Provide an example of externally sourced content

I've tried both html and markdown and not sure how I can get a correct answer. Possibly, it is how I am setting up my prompt, or the question itself. That said, possibly the input isn't clean enough. I've read in cases when chunking we want an overlap, but not sure that's the issue really. Can you have a look?
I was hoping to use parakeet to teach me about changes to go ;) Either of the following

https://go.dev/doc/go1.23
https://raw.githubusercontent.com/golang/website/master/_content/doc/go1.23.md

Here's an example diff
--- a/examples/36-rag-with-asciidoc/create-embeddings/main.go
+++ b/examples/36-rag-with-asciidoc/create-embeddings/main.go
@@ -21,12 +21,13 @@ func main() {
                log.Fatalln("😡:", err)
        }

-       rulesContent, err := content.ReadTextFile("./chronicles.adoc")
+       //https://raw.githubusercontent.com/golang/website/master/_content/doc/go1.23.md
+       rulesContent, err := content.ReadTextFile("./go1.23.md")
        if err != nil {
                log.Fatalln("😡:", err)
        }

-       chunks := content.SplitAsciiDocBySections(rulesContent)
+       chunks := content.SplitMarkdownBySections(rulesContent)

        // Create embeddings from documents and save them in the store
        for idx, doc := range chunks {
diff --git a/examples/36-rag-with-asciidoc/use-embeddings/main.go b/examples/36-rag-with-asciidoc/use-embeddings/main.go
index edc1ca3..64fc426 100644
--- a/examples/36-rag-with-asciidoc/use-embeddings/main.go
+++ b/examples/36-rag-with-asciidoc/use-embeddings/main.go
@@ -21,13 +21,10 @@ func main() {
                log.Fatalln("😡:", err)
        }

-       systemContent := `You are the dungeon master,
-       expert at interpreting and answering questions based on provided sources.
-       Using only the provided context, answer the user's question
-       to the best of your ability using only the resources provided.
-       Be verbose!`
+       systemContent := `Using only the provided context, answer the user's question
+       to the best of your ability using only the resources provided.`

-       userContent := `Who are the monsters of Chronicles of Aethelgard?`
+       userContent := `What changes to the archive/tar library happened in Go 1.23`
        //userContent := `Tell me more about Keegorg`

        // Create an embedding from the question

I have quite a few hypotheses for RAG (smarter chunking, using a more relevant embedding LLM, investigating similarity calculations, ...) but I need to find the time.
And I also need to figure out why my Elastic example is no longer working (Kibana does not start correctly). 😢

Elastic sample issue fixed 🎉

I did a test with ES, and the result of the similarity search is not better
I did the same test with a "bigger" LLM; it's not better (even worse 🤔 )

So, the first issue is probably how we chunk the document.
There is a chunking function with overlap chunks := content.ChunkText(documentationContent, 500, 100) but I did some tests, and it's not a solution because we will lose the document's semantics.
I have different possible solutions:

Add manually meta-data into the document (keywords, ...)
Allow choosing the level of the section you want to split (I added a method SplitMarkdownByLevelSections(content string, level int))
Add meta-data automatically when creating a chunk (like the title of the +1 level section, to keep a link)

First, I will work on the first solution. At the same time, I will investigate some NLP techniques like the Jaccard similarity coeff and the Levenshtein distance.

I added: content.ParseMarkdown https://github.com/parakeet-nest/parakeet/blob/main/content/advanced_chunkers.go
The result seems better: https://github.com/parakeet-nest/parakeet/tree/main/examples/39-rag-with-elastic-markdown

Good!
q: so [Brief] is that something that specifically works well in llama3.1?
I'm happy with the results of this, indeed with or without elastic they are better. I assume the key is the chunking, and not sure if model was required or not. I tried qwen2, but it seemed to just retort the sections as-is.
So, my understanding is:

RAG is best when the embedded data preserves semantic context. In many documents, there are a hierarchy of sections. When splitting a document into chunks, do so on section boundaries, and make obvious the section name. If a section is larger than the chunk size, take care to overlap some text so it knows it is a continuation. These are examples of approaches that help the LLM learn a more accurate representation of text embeddings.

What I noticed in the chunking is that each chunk, the prompt only includes the section title (e.g. ## crypto/x509\n\n), but not the hierarchy (e.g. ## Go 1.23 Release Notes crypto/x509), and somehow it works ;) If I remove the title prefix it is much less effective. So, the prefixing helps a lot, though not sure how it knows it is in the hierarchy of Go 1.23 except that most sections also say that.
p.s. I notice all the sections fit in one chunk each, so maybe my thoughts about overlap aren't proven here.

@codefromthecrypt, thanks for the remarks and questions 🙏
About [Brief], it's a "meta prompt"; it works for a lot of models (not for the "small qwen2"; it is not enough "disciplined" for that 😉)
By the way, other meta prompts exist; I did some helpers for that: https://github.com/parakeet-nest/parakeet/blob/main/prompt/meta.go.
I have the same understanding as you, but I wouldn't say I like the overlap technique. I think we should use it only with a document without structure or with a few structures.
To my mind, every chunk should be done cleverly: a single chunk has to be understandable even alone (with a signification), but a chunk must not be too big (especially with a small LLM)
The tricky thing is to "keep the link" if several chunks are related (perhaps by adding metadata like keywords to every related chunk). I need to study this topic more (I plan to read this: https://www.manning.com/books/knowledge-graph-enhanced-rag).
Regarding content.ParseMarkdown, I'm not totally sure why it's better (I had a long chat with ChatGPT to try to understand how to parse a markdown document while keeping the semantics of the document and did a lot of "tries")
Your idea to keep the hierarchy is pretty good 👍  (I will see If I can do something with this)

thanks for all the insight, research and code. We can keep this open or you can close it whenever you like

Keep it open 😄
btw I used another embedding model: embeddingsModel := "mxbai-embed-large"

@codefromthecrypt I did a new function to chunk the markdown content:
It produces:
[]Chunk struct {
	Header       string
	Content      string
	Level        int
	Prefix       string
	ParentLevel  int
	ParentHeader string
	ParentPrefix string
}

Then, I can keep a "link" between a section and its parent section (I think I can improve it more by adding all the child sections)
Then, with this, you can prepare the content for the embeddings like this (for example):
### Trace {#trace}

 <!-- Parent Section: ## Tools {#tools} -->

 <!-- go.dev/issue/65316 -->
The `trace` tool now better tolerates partially broken traces by attempting to
recover what trace data it can. This functionality is particularly helpful when
viewing a trace that was collected during a program crash, since the trace data
leading up to the crash will now [be recoverable](/issue/65319) under most
circumstances.

You can test it here: https://github.com/parakeet-nest/parakeet/tree/main/examples/40-rag-with-elastic-markdown

Ok, I added a new one, ParseMarkdownWithLineage
[]Chunk struct {
	Header       string
	Content      string
	Level        int
	Prefix       string
	ParentLevel  int
	ParentHeader string
	ParentPrefix string
}

Then you can add more "link":
#### [`path/filepath`](/pkg/path/filepath/)

 <!-- Parent Section: ### Minor changes to the library {#minor_library_changes} -->

 <!-- Parent Lineage: Standard library {#library} > Minor changes to the library {#minor_library_changes} > [`path/filepath`](/pkg/path/filepath/) -->

 The new [`Localize`](/pkg/path/filepath#Localize) function safely converts a slash-separated
path into an operating system path.

On Windows, [`EvalSymlinks`](/pkg/path/filepath#EvalSymlinks) no longer evaluates mount points,
which was a source of many inconsistencies and bugs.
This behavior is controlled by the `winsymlink` setting.
For Go 1.23, it defaults to `winsymlink=1`.
Previous versions default to `winsymlink=0`.

On Windows, [`EvalSymlinks`](/pkg/path/filepath#EvalSymlinks) no longer tries to normalize
volumes to drive letters, which was not always even possible.
This behavior is controlled by the `winreadlinkvolume` setting.
For Go 1.23, it defaults to `winreadlinkvolume=1`.
Previous versions default to `winreadlinkvolume=0`.

thanks, having a look quickly before flight! p.s. on 40 I have an error unrelated to the RAG approach:
$ docker compose up -d
[+] Running 4/6
 ✔ Network better-rag_default      Created                                                                    0.1s
 ✔ Volume "better-rag_kibanadata"  Created                                                                    0.0s
 ✔ Volume "better-rag_esdata"      Created                                                                    0.0s
 ⠹ Container better-rag-es01-1     Starting                                                                   0.2s
 ⠹ Container better-rag-setup-1    Starting                                                                   0.2s
 ✔ Container better-rag-kibana-1   Created                                                                    0.0s
Error response from daemon: error while creating mount source path '/Users/adriancole/oss/parakeet/examples/40-rag-with-elastic-markdown/certs': chown /Users/adriancole/oss/parakeet/examples/40-rag-with-elastic-markdown/certs: permission denied

fwiw I ran again and somehow it didn't mind 🤷


Unrecognized option "src_dir"

Suddenly we started to see this in our CI Server:

[Symfony\Component\Config\Definition\Exception\InvalidConfigurationException]
Unrecognized option "src_dir" under "coveralls"

Did anything changed recently that could be causing this?

this and that

My fault. Thanks!


Support Flutter Infinite Integration with Flutter Bloc

Is your feature request related to a problem? Please describe.
Often to fetch infinite data I use state management like bloc, and when I use ery_good_infinite_list I need Future to fetch data. And this will be completely different when using bloc.
Describe the solution you'd like
And this is an example of the implementation when using Bloc, maybe this can be a reference but for the implementation maybe you know better.
return BlocBuilder<SampleBloc, SampleState>(
      builder: (context, state) {
        return InfiniteList<String>(
          builder: InfiniteListBuilder<String>(
            success: (context, data) => Text('Success'),
            empty: (context) => Text('Empty'),
            error: (context, retry, error) => Text('Error'),
            loading: (context) => Text('Loading'),
          ),
          data: state is SampleSuccess ? state.data : '',
          isSuccess: state is SampleSuccess,
          isFailure: state is SampleFailure,
          isLoading: state is SampleLoading,
          itemLoader: () {
            // TODO: fetch data
          },
        );
      },
    );

Describe alternatives you've considered

Additional context

Hi @wisnuwiry 👋
Thanks for opening an issue!
This appears to be using an outdated version of very_good_infinite_list. Can you let us know if this is still a problem on the latest version? You can refer to an example here. Closing for now 👍


db:migrate StandardError Directly inheriting from ActiveRecord::Migration

Hi folks, I tried to install camaleonCMS on rails 5.1, but get this Error when trying to populate the db:
rake db:migrate fails
after Migration<PHONE_NUMBER>5653 MoveFirstNameOfUsers with:
StandardError: An error has occurred, this and all later migrations canceled: Directly inheriting from ActiveRecord::Migration is not supported. Please specify the Rails release the migration was written for: (...)
Full log:
camaleon_migration_log.TXT
This seems to be a problem with Migrations that don't follow the introduced scheme ActiveRecord::Migration[x.x]. But I can't find a workaround.
Any ideas? Thanks !

Fixed, please bundle update for cama_contact_form.

Great ! Thanks.
db migration runs smoothly now.


Add Form UI to add Team Members

Make a UI to add Team Members and the required fields are:

Name
Email
Linkedin Url
Github Url
Batch
Image Url

Example:
This is Ui to add events and the add Team Member UI should also look similar to this but with desired fields.

Current UI

hii, @lakshya-20  can i work on this

Hey @lakshya-20 I am skilled in React and UI Components. Please assign me this issue.

@ruhci28 @romasinha sure go ahead

Hey @lakshya-20 let me try it

we should not work on same issue. it just waste some one time

@ruhci28 go-ahead we are not going to reject any PR we won't waste anyone's time. also, nothing is a waste of time you are going to learn something new. you can also look at other issues to we going to add new issues tonight.  although you can start working on it.

@ruhci28 you can look in it #246 too.

@lakshya-20 The dashboard icon is not visible. I registered as a user too. Still unable to figure out where the Drawer component is. Can you help me please?

Hii @ravisaxena23 what is the api for  adding the user.?

@ruhci28 you will find API here https://radiant-thicket-94737.herokuapp.com/
for other issues, you can also mail me at<EMAIL_ADDRESS>

ok sure

@ravisaxena23 i have to make changes in user tab or team tab.?

You can do both but for now you can make changes in user tab


Keeps displaying " acquiring your weather"

Hi,
Thanks for the efforts you put to make us enjoy our health forecasting the weather.
The problem is that after installing the module, on the Magic Mirror screen keeps displaying the message "Acquiring your Weather" and nothing to be displayed at all even icons??

Below also the part I added to the confi.js
=============================================================
	{
	disabled: false,
		module: "MMM-BMW-DS",
		position: "bottom_bar",               // bottom_bar is best
		config: {
			apiKey: "https://api.darksky.net/forecast/xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx/30.04444,31.2357", // Free API key @ darksky.net
				tempUnits: "C",		              // C of F
 				lat: '30.04444',
 				lng: '31.2357',
				css: "3", // 1=default, 2=Clean, 3=Lord of the Rings, 4=handwriting, 5=Julee, 6=Englebert, "" = returns default css
				ownTitle: "Current Weather Conditions",   // Use your own language and statement
				playSounds: "yes", // yes = weather sounds, no = no weather sounds
				useHeader: true,
				header: "Cairo - EGYPT",
				maxWidth: "100%",
   				}
	},

=============================================================
Would you please help with that?
Regards,
Alaa

Dear SIR,
I have managed to get it working.
Thanks You so muck, it turned out that I must also edit the configurations inside the " MMM-BMW-DS.js " too.
Regards


Cache users on list releases

This will partially resolve #490.

Trusted LGTM

Joining the users table should be the best option, but LGTM for now.

Yes, we can improve it step by step.


How can I access to the Proficiency of a Skill

Hi,
First, thanks for the great gem you provide. I just want to know if it's to possible to access to the proficiency of a skill like this path :
 people/~/skills/0/proficiency

Thanks a lot.

I took a look and it seems that the proficiency is not being pulled in as part of the Skills api.  Pull requests are always appreciated...


feature request: expand fetchFlutterFavorites

Hi everyone, for one of my side projects I'm using this package to create a desktop app to browse pub.dev using the same concept of the AppStore, Windows Store, or other stores on Linux distros.
In my case I need to create a section with the list of packages of the Flutter Favorite program and those associated with Google that can be retrieved respectively with this two APIs:

fetchGooglePackages
fetchFlutterFavorites

Unfortunately, these two functions only return the List <String> with the package names while in my case I would need the complete information about the package represented by the PubPackage object. Right now I solved this issue by calling the fetchFlutterFavorites and after that in another widget call the packageInfo API to get all the info, something like that using Riverpod:

final allFlutterFavoritesProvider = FutureProvider.autoDispose<List<String>>((ref) async {
  return await PubClient().fetchFlutterFavorites();
});

final singlePackageProvider = FutureProvider.autoDispose.family<PubPackage, String>((ref, packageName) async {
  return await PubClient().packageInfo(packageName);
});

[...]

Widget build(BuildContext context, WidgetRef ref) {
    AsyncValue<List<String>> allFlutterFavoritesList = ref.watch(allFlutterFavoritesProvider);

    return Column(
      children: [
        ...
        allFlutterFavoritesList.when(
          loading: ...
          error: ...
          data: (list) {
            return GridView.builder(
              shrinkWrap: true,
              gridDelegate: const SliverGridDelegateWithFixedCrossAxisCount(
                  crossAxisCount: 3,
                  crossAxisSpacing: kDefaultPagePadding,
                  mainAxisSpacing: kDefaultPagePadding),
              itemCount: list.length,
              itemBuilder: (_, int index) {
                return PackageGridBox(
                  packageName: list.elementAt(index),
                );
              },
            );
          },
        ),
      ],
    );
  }

[...]

class PackageGridBox extends ConsumerWidget {
  const PackageGridBox({Key? key, required this.packageName}) : super(key: key);

  final String packageName;

  @override
  Widget build(BuildContext context, WidgetRef ref) {
    AsyncValue<PubPackage> singlePackage = ref.watch(singlePackageProvider(packageName));

    return singlePackage.when(
      loading: ...
      error: ...
      data: (package) {
        return Container(
          decoration: kDefaultBoxDecoration(context),
          child: Text(package.toString()),
        );
      },
    );
  }
}

Do you think it might be useful to add an API that allows you to immediately have all the information about the packages and not just the package name? Something like that:
/// Retrieves all the flutter favorites PubPackage
Future<List<PubPackage>> fetchFlutterFavoritesPubPackage() async {
  final searchResults = await search('is:flutter-favorite');
  final results = await recursivePaging(this, searchResults);
  return await Future.wait(
    results.map((r) => packageInfo(r.package)).toList());
}

I know that for all the packages you must wait for all the packageInfo calls but it might be useful to someone.
Best regards,
Alberto

@polilluminato this is an ongoing challenge with the API. I had to do something similar for the flutter.space API.
https://github.com/fluttertools/flutter.space/blob/main/lib/helpers.dart#L114
I think a helper function might be interesting, let me know if the link provided is something that it would work.

@leoafarias you recommend using flutter-favorites.json to get information on Flutter Favorites Packages to show in a list and then use the pub_api_client package to get more information on a detail page?
In this way, I don't have to change the behavior of the pub_api_client package.
I can use both the flutter.space endpoints to get lists (favorite, google, popular, most liked, and so on) and pub_api_client package to get detailed information.
Sounds good to me 😀

Yes feel free to use whatever you need for Flutter Spaces, if you end up with flutter space SDK, feel free to do a PR!

@polilluminato Can't you just use the search method?

@Rexios80 I think @polilluminato wants to also get the information within the search, as search returns just the package names. Not sure if this has changed in the last few months

You are right @leoafarias but right now I'm not developing that side project anymore, so nothing has changed since my last message.
@Rexios80 the search methods returns only the package name, so, to display a "pretty" list and not just the name, I have to call another API as mentioned by @leoafarias


feat: add new hook onRestartDevServerHook

Summary
Related Links

Checklist

[ ] Tests updated.
[ ] Documentation updated.

!canary

@9aoy @chenjiahan
This hook is used by external plugins, such as plugin-wrangler, to clean up when restarting or shutting down the devserver.
Currently it is called at the expected timing of the lifecycle. However @9aoy noticed that the closeServer callback and onRestartDevServerHook are also called when manually closing the devserver, which does not match their intended meaning.
https://github.com/web-infra-dev/rsbuild/blob/a89f2790f54b609903413ca7ab94c3e0370f1bbf/packages/core/src/server/devServer.ts#L231-L245
By reviewing the invokers of onBeforeRestartServer, I found that only one other line uses this function:
https://github.com/web-infra-dev/rsbuild/blob/d353a26a17f96c1d9a2e01cc16798f786824031a/packages/core/src/loadEnv.ts#L39-L45
This seems strange because:

The onBeforeRestartServer stores cleaners scoped by module and may interfere with other builder instances in the same process.
The cleanup of loadEnv is currently only invoked during restart but appears to be necessary for closure as well.

So how about removing the registration of onBeforeRestartServer and replacing it with a new builder plugin hook named either onCloseDevServer or onCleanupDevServer?

So how about removing the registration of onBeforeRestartServer and replacing it with a new builder plugin hook named either onCloseDevServer or onCleanupDevServer?

I think onCloseDevServer much better.

loadEnv is an independent function, is can not use rsbuild plugin hooks now.

loadEnv is an independent function, is can not use rsbuild plugin hooks now.

I would like to add a new callback as one of returns of loadEnv, and it can be able to invoked from some other places. So it will works like:
export async function init() {
  try {
    const root = process.cwd();
    const { publicVars, cleanup } = loadEnv({ cwd: root });
    const { createRsbuild } = await import('../createRsbuild');

    const builder = await createRsbuild({
      cwd: root,
      rsbuildConfig: config,
    });
    builder.onCloseDevStart(cleanup);
    return builder;
  } catch (err) {
  }
}

LGTM, please send separate PR for these changes

LGTM, please send separate PR for these changes

Sure, I think the onRestartDevServerHook is not needed anymore. I would close this PR and create a new one to work with loadEnv and onCloseDevStartHook.


summary tables

just a prototype… there's still a lot to do
This works in user land, which makes it easy to hack on and also means that anyone will be able to substitute whatever we come up with with their own code.
I'm beginning to think that this (when it's ready) should be the default inspector for Arrow tables, and not only tied to the sql fenced code blocks. (I don't think anyone will miss the current inspector which shows a Ho object with cryptic properties—and if you need it to debug something, you can just put the Arrow table inside an Array.)
I don't use DuckDB (yet) but maybe it will become necessary when we add filtering. But there will be a trade-off because setting up a DuckDB instance can only be slower than not doing it. We'll see what's easiest and fastest.
I also use Plot for faster prototyping, but the actual implementation will likely use d3. We'll need some kind of preprocessing of the channels, so we don't compute the bins twice.
The bin width is also often too small. I'm "hacking" the rects so that they are always visible, but a better implementation will be needed… (and maybe that's a flaw in the default strategy we're using in Plot to decide the number of bins).
closes #23

TODO:

[ ] detect dates since they are numbers as of apache-arrow@16 (see #1375)


Generate separate K8s manifests for EDP/MP dev example daemon.

This change is

I've been working on this while @yunyeng has been out. This partially replaces #273.

TODO: Add network policy.


[API] Change how orchestratorVersion is handled

What this PR does / why we need it:
Solve #921
Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #921, relates #1114
Special notes for your reviewer:
Ready to review.
TODO

[ ] Refactor Upgrade code

Release note:

This change is

@acs-bot test this please

@acs-bot test this please

@acs-bot test this please

@acs-bot test this please

@acs-bot test this please

@acs-bot test this please

@acs-bot test this please

@acs-bot test this please

@seanknox , there is one remaining question. How do we communicate this to acs-engine users?
For ACS RP, the impact will be 2017-07-01 api model only. And this one is in preview, so it is ok to change.
For ACS Engine users, most of them use vlabs version. This change will certainly break their existing  setup.

Can you give a 1-2 sentence elevator pitch summarizing this change, pretending we're speaking to a non-ACS engineer? I looked at the issues and couldn't quite make sense of it.

@seanknox , updated Context section in this pr's description.

Also, please rebase off of master—we just merged in CircleCI support. Rebasing will kick off a job.

@seanknox 👍

@seanknox @jchauncey I'm stumped why the most recent ci/circleci: test failed due to missing go-version. It's committed in this PR under vendor/:
https://github.com/Azure/acs-engine/pull/1108/files#diff-eb066af97cb10032e5af1303d0fe48de
My local make build runs are returning 0 exit code.

I'm stumped why the most recent ci/circleci: test failed due to missing go-version.

It's because CI also runs make bootstrap before running tests. If you try that on your machine, you'll see that go-version and its dependencies are dropped from vendor/ because go-version is missing from glide.yaml.
To fix:

add go-version to glide.yaml:

- package: github.com/hashicorp/go-version
  version: 03c5bf6be031b6dd45afec16b1cf94fc8938bc77

run glide update
commit changes to glide.yaml, glide.lock, and vendor/. You'll see changes to ginkgo and gomega which should be fine.
run make build test and unit tests should pass.

@seanknox post-0.5.0 release wave


expr: Optimizing for integer values

An attempt at resolving issue https://github.com/uutils/coreutils/issues/5591

nice, did you do some benchmark ? - just curious on what kind of impact this can have
(hyperfine is pretty good for this)

Not yet, was looking if there are some open test data sets available for expr. Will look into hyperfine, thanks for your suggestion!

Sorry for getting back on this so late, had a busy week!
@tertsdiepraam thanks for your review, have made fixes for all your comments.
I did some quick & dirty benchmarking on my local system (terrible reliability, got inaccuracies of ~30%) with hyperfine. For small numerical expressions( < 10 operations), I saw almost no gains (5% at best). For bigger numerical expressions (~100 operations) with huge numbers (< 10^150), saw an improvement of around 40%. For string operations, There was a performance loss of no more than 5%.
Tested release build of expr with shell=none - main branch (https://github.com/uutils/coreutils/commit/8b1a82edb9a1f47652ac55a536066ade3b28534e) against my branch (https://github.com/Arp-1/coreutils/commit/4d2ae8485cd65429e64606119acac3156158ea2b)
Let me know if I should put more details of my testing setup.

Thanks for taking a look at it again @tertsdiepraam !
On your benchmarking question, yes, I'd built expr with --release. Though reiterating on the instability of the runtimes on my local system, the spread of time taken for optimized expr was 0.74ms to 2.23ms and for unoptimized expr it was 0.73 ms to 2.85ms:

Maybe I should try and do this on a little less noisy system :)

This is great! Thanks so much for all your help.

green, merged :)


ESP32: Fix compilation of examples with CMake

Problem
ESP32 examples fail with CMake.
Summary of Changes
As described here: https://github.com/project-chip/connectedhomeip/issues/6774#issuecomment-840447955
Fixes #6774

@dhrishi Thanks for this fix. Can you please add CI to catch this as part of this PR?

@dhrishi Thanks for this fix. Can you please add CI to catch this as part of this PR?

Hey @woody-apple  I am planning to deprecate the support of automake for ESP32 examples in CHIP in a follow-on PR. Captured it through an issue #6850 . With this, the CI should also run CMake. Merging the current PR would unblock the users for now. Let me know if that sounds okay.

@gjc13 Is crypto (mbedTLS) used in the recent changes related to operational credentials? If yes, we generally suggest/keep the stack size as 8KB. LGTM


Failure compiling Ruby

Hi all, this looks really promising and I've been wanting to test drive it. I am running this in an OpenStack / KVM environment with a recent Trusty stemcell (bosh-openstack-kvm-ubuntu-trusty-go_agent v2840).
I am currently running into a compilation issue with Ruby:
https://gist.github.com/devcamcar/03f3ec8b4fee4cdec55e
I am curious which stemcell you are using?  I also tried a Lucid stemcell with the same result.
Thanks!

I have the same issue both in warden and AWS stemcells v2840. Your advice would be very appreciated.
Thanks

When I tested and cut the release I used a 2479 bosh stemcell. That stemcell had libyaml installed by default, but later stemcells dropped it (see commit https://github.com/cloudfoundry/bosh/commit/9e63d128dce0186f8bb23cdc4a13493b0108c277#diff-9b2773a8b14a55ca37b03dfe5e34a854L56).
The fix is already in the master of this repo, when compiling ruby you just need to compile the libyaml library (see commit https://github.com/cf-platform-eng/mesos-boshrelease/commit/c37855ca504a16a420477731c19b299959c654ac#diff-dd3a91430f204c303b0af44d4d4ec03eR37). But I didn't had time to finish my tests, IIRC there's still a problem when registering frameworks. I'll try to cut a new release with the fix during the next weeks.
Another option if you had a chance is to use an old stemcell with libyaml.

Using 2479 worked for me, thanks!

I would like to confirm also that 2479 for me as well in OpenStack however not in AWS

hello,
met this issue with openstack kvm 2922 stemcell. Is using an old stemcell the only option ?

@poblin-orange Unfortunately yes.

I've created a new Mesos Bosh release v2 that work with the latests stemcells.

thank you @frodenas :-) !


IN_IPYTHON can be True when running in python

Please see https://github.com/pete88b/decision_tree/blob/master/73_in_ipython.ipynb for explanation.
I'm happy to create a PR if it's OK to change to use get_ipython - fell free to let me know if there's more to it.

We can definitely try this approach.

Fixed by #179


contributing & naming conventions

I am an experienced C++ programmer (embedded). I love the work you have done and would like to participate. However, I noticed that the naming conventions are not ideal. Would you allow me to update the naming of the variables? I also have a few other updates in mind after this.

Hi Hixfield. You are more than welcome to help. My problem is that I currently have other priorities in my spare time projects and don't have much time to maintain this project. @FWeinb already started a V3.0.0 branch and it probably makes a lot of sense to continue work on that branch, also to avoid breaking downstream dependencies... What do you think?

That sounds good to me. @FWeinb are you open for collaboration?

Sure. I made an PR #16 Would really like to clean that up. The PR is against the dev branch for 3.0. Would be good to merge that one first and you can than pick it up and modify as you like.

@squix78 would you agree? How do you see the rights issue? Should we get the required rights from you?

Done. Please check if you have now commit permissions.

Thanks. I can commit. I would now merge the Outstanding PR and @hixfield could start refactoring from there.

Sounds like a plan! Let me know when I can pull it and from where :)

Great. Thank you guys in advance!

Just merged it to the dev-branch-3.0.0 branch. You can now checkout that branch and work on the code.

I would say you crate a new branch of of the dev-branch-3.0.0 and than do a PR against the dev-branch when you are done. Me and @squix78 can than review your changes and when everything looks good we merge it.

ok that sound good

By the way this is the naming convention I have been using for many years, everybody ok with this?
Variable names context prefix:
m_ : member variable
g_ : global variable
Variable names type prefix:
sz : zero terminated character array string
p : pointer
n : signed number
u : unsinged number
c : class
camelCase for variables, functions
PascalCase for objects, types
constants or defines in UPPERCASE
Example:
const in MAXSIZE = 255
#define MAXSIZESTRING 255
class CMyClass : CSomeRootClass {
private :
char m_szSearch[MAXSIZESTRING];
int m_nCharIndex;
char * m_pIndexPointer;
public:
int add(int nNumber1, int nNumber2);
}

As long as we maintain the public api where possible I am fine with that. I would not rename the SSD1306 class just to conform with this naming schema.


chore: remove lombok/querydsl/mapstruct

Type of modification

[ ] Breaking change
[ ] New Feature
[ ] Bug Fix
[x] Chore (refactor, documentation, tests... all the changes with no impact on ARA functionalities.)

Technical description
Remove lombok/querydsl/mapstruct librairies
lombok has been replaced by only necessary getter/setter/constructor
querydsl has been replaced by spring JPA
mapstruct has been replaced by jackson.
An "Organize imports" and "format" has been applied to all modified files.
Some behavior change :

for "Transformer class", these class has been removed and replace by jackson. In Transformer class, null object was mapped to empty Object with 0 has id. With jackson null is mapped to null. I haven't found any use of the old default value in front, but i'm not an expert of it.
ObjectUtil.java has been removed (util to trim all field of an object by reflection), it has been replaced by a JacksonDeserializer that trim all String. The util class was called in some rest resource class to trim DTO just after their deserialization. In the new version, all String in all deserialized DTO are trimed.

A file not linked to these modifications is present in this pull-request : code/api/database/src/main/resources/db/changelog/changes/h2/20220126152954-missing_changes.yaml
This file was generated by "make liquibase-diff" on main branch, and constaint modification already present in main but absent from migration on it
One file of existing migration has been modified : code/api/database/src/main/resources/db/changelog/changes/mysql/20220125173016-delete_cascade_on_problem_occurrences.yaml
Two changes has been inverted, without this inversion, the task "make liquibase-diff BASE=mysql" was in failure in my local environment.
PR CheckList
Please make sure your PullRequest respect all those items :

[x] Your PR's title has the prefix : feat:, fix: or chore:
[ ] You have asked a review from one of the ARA maintainer in your PR.
[ ] If your PR is related to an issue, add the issue's number in it.
[ ] All the code you added is documented.
[ ] All the code you added is tested and the  tests are in success.
[ ] You already signed the Contributor License Agreement and give us the document

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

J'ai un echec en local
Caused by: liquibase.exception.ChangeLogParseException: Error parsing classpath:/db/changelog/db.changelog-master-postgresql.yaml
code-ara-api-1            |     at liquibase.parser.core.yaml.YamlChangeLogParser.parse(YamlChangeLogParser.java:88)
code-ara-api-1            |     at liquibase.Liquibase.getDatabaseChangeLog(Liquibase.java:369)

je vais regarder

Dernière chose ça serait bien que tu suives la convention de nommage de commit -> https://github.com/angular/angular/blob/master/CONTRIBUTING.md#-commit-message-format
Et bien mettre le BREAKING CHANGE:  en message body sur ton premier commit


docs(crashlytics): Use PlatformDispatcher.instance.onError for async errors. Update Crashlytics example app to use "flutterfire-e2e-tests" project.

Description
Flutter has changed the way it handles errors as of Flutter 3.3 (See this commit).
Updated example app and documentation using latest implementation to catch uncaught async errors: PlatformDispatcher.instance.onError.
I've also updated the docs to be more explicit about what choice of error report is sent to Crashlytics. See: https://github.com/firebase/flutterfire/issues/8815
Also updated the example app to use "flutterfire-e2e-tests" Firebase project. Updated this issue: https://github.com/firebase/flutterfire/issues/9643
Related Issues
Closes https://github.com/firebase/flutterfire/issues/8815
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]).
This will ensure a smooth and quick review process. Updating the pubspec.yaml and changelogs is not required.

[ ] I read the Contributor Guide and followed the process outlined there for submitting PRs.
[ ] My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
[ ] All existing and new tests are passing.
[ ] I updated/added relevant documentation (doc comments with ///).
[ ] The analyzer (melos run analyze) does not report any problems on my PR.
[ ] I read and followed the Flutter Style Guide.
[ ] I signed the CLA.
[ ] I am willing to follow-up on review comments in a timely manner.

Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?

[ ] Yes, this is a breaking change.
[x] No, this is not a breaking change.

Hey @kevinthecheung, I've updated the documentation to show users how to record "fatal" & "non-fatal" errors. Could you have a look at the changes and see what you think, please?

Hey @kevinthecheung - could you let me know if the doc changes are acceptable, please?


DPL-690	Communicating LIMS updates (BP-Medium ¦ Should've)

As Tris (High Throughput Sequencing) would it be possible to place a ‘flash message’ across the top of LIMS when updates were due? This might capture those that are in the lab and maybe not read an email.

added this as an sequencescape issue as this is LIMS that user is referring to however this would be useful to display across other affected LIMS though perhaps increases the complexity.

Team Discussion 10Jul2024:

Who is the audience?
Streamlining communication channels?
Which Applications?
Need to identify options for notification?
What information is intended?
May be higher efforts v/s gains!
What are the use cases?

@SujitDey2022 I think we agreed that we weren't going to do this?


[W6.4b][T12-B3] Ruchir Aggarwal

DeveloperGuide.md: add non-functional requirements

Code ready for Review


On the computation of KL divergence for graph VAE

Dear @rusty1s,
First of all, I would like to congratulate you and your collaborators for this amazing work.
I recently noticed that your computation of the Kullback-Leibler divergence for the ELBO objective of graph VAE models slightly differs from Thomas Kipf's original TF implementation. More precisely, a square and a x2 terms are missing:

Current KL: -0.5 * torch.mean(torch.sum(1 + logvar - mu**2 - logvar.exp(), dim=1))
Pytorch equivalent of original KL:-0.5 * torch.mean(torch.sum(1 + 2*logvar - mu**2 - logvar.exp()**2, dim=1))

I think that the original version is the correct one (see e.g. here for the computation in 1 dimension ; taking mu_2 = 0 and sigma_2 = 1 in the final formula), and I therefore open this PR for an update.
Besides, I also propose to replace the logvar naming by logstd, as in the original implementation. Such notation would be more consistent with the mathematical terms actually used in the KL (the first one should be the log of the standard deviation ; the second one - with the square - is the variance). It would also be more consistent w.r.t. the "reparameterization trick" (see line 146 of torch_geometric/nn/models/autoencoder.py) where the N(0,I) random samples need to be multiplied by the standard deviation, not by the variance. I therefore updated all occurences of logvar by logstd in the project.
Best,
Guillaume

That's great. Thank you :)


KMS: Add set-primary-version to KMS snippets

This fixes failing integration tests. I've executed the tests on my
personal project to confirm. Important changes are:

Each test execution creates a CryptoKey.

CryptoKeys are free and creating a new CryptoKey fixes the caching
problem of creating a key version, setting it as primary, then
relying on the new primary in a subsequent call.

Destruction tests now destroy keys that they created rather than the primary
key set for the execution.
Added the setPrimaryVersion snippet w/ tests.

Merging before tests can run due to it being on a fork, I'll be giving you permission to commit to a branch shortly.


Support UTF-8 characters for excluded apps input in FancyZones Settings

Support UTF-8 characters for excluded apps input in FancyZones Settings.

@enricogior  if this is low cost, we should do it sooner vs later

Fixed with https://github.com/microsoft/PowerToys/pull/1669

The fix is now available in 0.16 https://github.com/microsoft/PowerToys/releases


UnsatisfiedLinkError:  Error looking up function 'strlen'

A report from a user. They got this error when trying to load a plugin but it failed:
at com.sun.jna.Function.<init> (Function.java:252)
    at com.sun.jna.NativeLibrary.getFunction (NativeLibrary.java:604)
    at com.sun.jna.NativeLibrary.getFunction (NativeLibrary.java:580)
    at com.sun.jna.NativeLibrary.getFunction (NativeLibrary.java:566)
    at com.sun.jna.Library$Handler.invoke (Library.java:243)
    at jdk.proxy3.$Proxy28.strlen (Unknown Source)
    at org.extism.sdk.Plugin.<init> (Plugin.java:49)
    at org.extism.sdk.Plugin.<init> (Plugin.java:61)
    at org.spirefy.engine.PluginEngine.load (PluginEngine.java:28)
    at org.spirefy.example.Example.main (Example.java:12)
    at org.codehaus.mojo.exec.ExecJavaMojo$1.run (ExecJavaMojo.java:254)
    at java.lang.Thread.run (Thread.java:1570)
java.lang.UnsatisfiedLinkError: Error looking up function 'strlen': The specified procedure could not be found.

Looks to me like this code is not correct: https://github.com/extism/java-sdk/blob/91c19490d2d492566ba67fd223220d5ff35b6d64/src/main/java/org/extism/sdk/Plugin.java#L49
we don't expose have a strlen function in libextism.

I am puzzled by this. The example URL code works fine from Java host. But trying to load a local wasm module it seems like it isn't even getting to my module.. e.g. the extism.sdk.Plugin.init call is looking for that strlen func for some reason? Which is odd that it would be since there is a length function in Java anyway. I feel like this is one of those "oh.. it's this other thing unrelated that is somehow causing this issue to rear up".

Just another thought on this.. it seems like the strlen() call is because the p is null (prior to it in the Plugin.java call). So my assumption is p being null means it did not find/load my plugin.. The code:
        Pointer p = LibExtism.INSTANCE.extism_plugin_new(manifestBytes, manifestBytes.length,                 ptrArr,                 functions == null ? 0 : functions.length,                 withWASI,                 errormsg);         if (p == null) {             if (functions != null)                 for (int i = 0; i < functions.length; i++) {                    LibExtism.INSTANCE.extism_function_free(functions[i].pointer);                 }             int errlen = LibExtism.INSTANCE.strlen(errormsg[0]);             byte[] msg = new byte[errlen];             errormsg[0].read(0, msg, 0, errlen);             LibExtism.INSTANCE.extism_plugin_new_error_free(errormsg[0]);             throw new ExtismException(new String(msg));         }
I assume above that Pointer P using LibExtism.INSTNACE.extism_plugin_new() is trying to load/create the plugin, but that it returns null and this the if (p == null) bit runs, which is where this strlen function not found is happening.
I'd be interested if whoever owns/knows the code might explain the issue with INSTANCE.strlen().

I think perhaps @thomasdarimont or @Zwiterrion may have written that piece. I believe it's a mistake maybe the testing plugin had that export but it's not part of Extism. I think we should remove it and instead use extism_plugin_error: https://github.com/extism/java-sdk/blob/91c19490d2d492566ba67fd223220d5ff35b6d64/src/main/java/org/extism/sdk/LibExtism.java#L108
Also perhaps @zshipko has an idea of the correct behavior here.

I'd be happy to fix it but I can't reproduce the problem yet.

@bhelx I'll take a look now.

I cannot reproduce the problem either, as the code is correctly executed.

The strlen function is exposed by the glibc
$ readelf -Ws --dyn-syms /usr/local/lib/libextism.so | grep strlen
    53:<PHONE_NUMBER>000000     0 FUNC    GLOBAL DEFAULT  UND<EMAIL_ADDRESS>(3)
 43603:<PHONE_NUMBER>000000     0 FUNC    GLOBAL DEFAULT  UND strlen@@GLIBC_2.2.5

I just check on arm64, and i got the strlen function.
@apisorbust can you give us your os ? You may be on windows and we tested on Mac and Linux

The strlen function is exposed by the glibc

Ohhh I see. Yeah, we can't assume that is there. We should be able to not rely on it. Idk what OS he was on, he didn't say, but his paths suggested windows

@bhelx I found a way to get rid of the strlen function... see #22

Sorry.. didn't see this update thread. Yah.. windows 64.. but ya'll figured it out already. Just waiting on maven push for my app to pull down the fix and get cracking. Thank you again for jumping in on this and fixing it.


smiles could not be converted in libinvent

Hello,
I was trying to run libinvent and failed due to an issue of smiles conversion.
Here the part of the toml file. Others are the same as the staged_learning.toml.
# REINVENT4 TOML input example for reinforcement/curriculum learning
#
#
# Curriculum learning in REINVENT4 is a multi-stage reinforcement learning
# run.  One or more stages (auto CL) can be defined.  But it is also
# possible to continue a run from any checkpoint file that is generated
# during the run (manual CL).  Currently checkpoints are written at the end
# of a run also when the run is forcefully terminated with Ctrl-C.

run_type = "staged_learning"
device = "cuda:0"  # set torch device e.g. "cpu"
tb_logdir = "tb_logs"  # name of the TensorBoard logging directory
json_out_config = "_staged_learning.json"  # write this TOML to JSON

[parameters]
# Uncomment one of the comment blocks below.  Each generator needs a model
# file and possibly a SMILES file with seed structures.  If the run is to
# be continued after termination, the agent_file would have to be replaced
# with the checkpoint file.

summary_csv_prefix = "staged_learning"  # prefix for the CSV file
use_checkpoint = false  # if true read diversity filter from agent_file
purge_memories = false  # if true purge all diversity filter memories after each stage

## Reinvent
#prior_file = "priors/reinvent.prior"
#agent_file = "priors/reinvent.prior"

## LibInvent
prior_file = "priors/libinvent.prior"
agent_file = "priors/libinvent.prior"
smiles_file = "scaffolds.smi"  # 1 scaffold per line with attachment points

After running I got an error as below:
$ reinvent -l lib.log staged_learning_test_lib.toml
Traceback (most recent call last):
  File "/home/***/anaconda3/envs/reinvent4/bin/reinvent", line 8, in <module>
    sys.exit(main())
  File "/home/***/anaconda3/envs/reinvent4/lib/python3.10/site-packages/reinvent/Reinvent.py", line 334, in main
    runner(
  File "/home/***/anaconda3/envs/reinvent4/lib/python3.10/site-packages/reinvent/runmodes/RL/run_staged_learning.py", line 367, in run_staged_learning
    terminate = optimize(package.terminator)
  File "/home/***/anaconda3/envs/reinvent4/lib/python3.10/site-packages/reinvent/runmodes/RL/learning.py", line 125, in optimize
    scaffolds = self._state.diversity_filter.update_score(
  File "/home/***/anaconda3/envs/reinvent4/lib/python3.10/site-packages/reinvent/runmodes/RL/memories/identical_murcko_scaffold.py", line 17, in update_score
    return self.score_scaffolds(scores, smilies, mask, topological=False)
  File "/home/***/anaconda3/envs/reinvent4/lib/python3.10/site-packages/reinvent/runmodes/RL/memories/diversity_filter.py", line 84, in score_scaffolds
    smiles = smilies[i]
IndexError: list index out of range

Looking at the log file, looks like there was a problem in recognizing the scaffold smiles strucutures:
16:19:42 <INFO> Creating scoring component QED
16:19:42 <INFO> Writing tabular data for stage to staged_learning_1.csv
16:19:42 <INFO> Starting stage 1 <<<
16:19:42 <INFO> Current GPU memory usage: 884 MiB used, 39562 MiB free
16:19:43 <WARN> reinvent_plugins.normalizers.rdkit_smiles: [*]Cc1c2cc(C[*])cnc2cnc1C1CN2CC(*)C1CC(OCc1c(-c3ccc(F)cc3)ccc1)C2O|*N(C)C1CCCNC1 could not be converted
16:19:43 <WARN> reinvent_plugins.normalizers.rdkit_smiles: n1cc(C[*])c2cc(C[*])ccc2c1c1c(*)c2c(c(-c3cc(C)c(OCc4nn(C)c(=O)c4CO)c(OC)cc3)cc2)cc1|*C could not be converted

The rdkit version I'm using is 2024.03.6. Any responses are appreciated.
Thanks.

Hi,
many thanks for your interest in REINVENT and welcome to the community!
I see two problems there:

You have a "|" in the SMILES but Libinvent requires a single scaffold as input.
Your scaffolds will not kekulize and you will have to fix the chemistry first.

Many thanks,
Hannes.

Hi Hannes,
Thank you for your quick response. I used scaffolds.smi as the input file provided by the program. I tested the staged learning process multiple times, and each time, it produced the same error message. However, the output files varied: most of the time, staged_learning_1.csv was empty, but occasionally, it contained a few hundred SMILES lines.
Below are the last few lines of the log file when staged_learning_1.csv was not empty.
09:36:53 <INFO> Creating scoring component QED
09:36:53 <INFO> Writing tabular data for stage to staged_learning_1.csv
09:36:53 <INFO> Starting stage 1 <<<
09:36:53 <INFO> Current GPU memory usage: 884 MiB used, 39562 MiB free
09:36:54 <INFO> Score: 0.74 Agent NLL: 20.46 Valid: 100% Step: 1
 | Agent Prior Target Score SMILES SMILES_state Input_Scaffold R-groups Scaffold Molecular weight Molecular weight (raw) Unwanted SMARTS Unwanted SMARTS (raw)
 | 16.6641 14.4043 113.5311 0.9994959 CC(C)Cc1cncc2ccc(CN3CCCCC3)cc12 1 c12c(C[*])cncc1ccc(C[*])c2 *C(C)C|C1CCCN(*)C1 c1cc2cc(CN3CCCCC3)ccc2cn1 0.9994959 282.4310 1.0000000 1.0000
 | 31.1224 32.3684 95.4699 0.9987366 CCc1ccc2cncc(CCCON=C(N)c3ccc(-n4cccn4)cc3CC)c2c1 1 c12c(C[*])cncc1ccc(C[*])c2 *CCON=C(c1ccc(-n2cccn2)cc1CC)N|*C C(=NOCCCc1cncc2ccccc12)c1ccc(-n2cccn2)cc1 0.9987366 427.5520 1.0000000 1.0000
 | 33.0129 30.6990 -30.6990 0.0000000 O=C(O)CC(CCO)c1ccc(CCc2ccc3cncc(CCCO)c3c2)c(Cl)c1 1 c12c(C[*])cncc1ccc(C[*])c2 *CCO|c1c(Cl)c(C*)ccc1C(CC(O)=O)CCO c1ccc(CCc2ccc3cnccc3c2)cc1 0.0000000 0.0000 0.0000000 0.0000
 | 11.6166 12.1508 107.0825 0.9315100 CCCc1ccc2cncc(CN(C)C)c2c1 1 c12c(C[*])cncc1ccc(C[*])c2 *N(C)C|*CC c1ccc2cnccc2c1 0.9315100 228.3390 1.0000000 1.0000
 | 10.3642 8.7407 56.0993 0.5065621 CCc1ccc2cncc(CNC)c2c1 1 c12c(C[*])cncc1ccc(C[*])c2 *NC|*C c1ccc2cnccc2c1 0.5065621 200.2850 1.0000000 1.0000
 | 6.6187 6.0158 22.1438 0.2199967 CCc1ccc2cncc(CN)c2c1 1 c12c(C[*])cncc1ccc(C[*])c2 *N|*C c1ccc2cnccc2c1 0.2199967 186.2580 1.0000000 1.0000
 | 21.0663 20.5225 107.4715 0.9999537 COc1ccc(CN)cc1Cc1cncc2ccc(CO)cc12 1 c12c(C[*])cncc1ccc(C[*])c2 *c1c(OC)ccc(CN)c1|O* c1ccc(Cc2cncc3ccccc23)cc1 0.9999537 308.3810 1.0000000 1.0000
 | 18.7851 18.1979 109.8013 0.9999936 Clc1ccc(Cc2cncc3ccc(Cc4nnn[nH]4)cc23)cc1Cl 1 c12c(C[*])cncc1ccc(C[*])c2 *c1ccc(Cl)c(Cl)c1|n1nn[nH]c1* c1ccc(Cc2cncc3ccc(Cc4nnn[nH]4)cc23)cc1 0.9999936 370.2430 1.0000000 1.0000
 | 13.8535 13.2819 114.6822 0.9997200 ClCCc1cncc2ccc(CN3CCCCC3)cc12 1 c12c(C[*])cncc1ccc(C[*])c2 C(*)Cl|C1N(*)CCCC1 c1cc2cc(CN3CCCCC3)ccc2cn1 0.9997200 288.8220 1.0000000 1.0000
 | 44.2730 44.1825 -43.7477 0.0033969 CCCc1cncc2ccc(CNc3nc4c(n3C)-c3cc(-c5cc(OC)ccc5C)c(CO)cc3C(=O)NC4)cc12 1 c12c(C[*])cncc1ccc(C[*])c2 C(*)C|c12nc(N*)n(C)c1-c1cc(-c3c(C)ccc(OC)c3)c(CO)cc1C(=O)NC2 O=C1NCc2nc(NCc3ccc4cnccc4c3)[nH]c2-c2cc(-c3ccccc3)ccc21 0.0033969 561.6860 1.0000000 1.0000
09:36:55 <WARN> reinvent_plugins.normalizers.rdkit_smiles: c1(C[*])cncc2c1cc(C[*])cc2*NC(=O)N|c1(*)c(C)nc(NC(c2c(Cl)ccc(N3CCC(F)(F)CCC(N)=NO)c2F)=O)nc1C could not be converted

Here is another log file without any output smiles.
09:50:27 <INFO> Creating scoring component QED
09:50:27 <INFO> Writing tabular data for stage to staged_learning_1.csv
09:50:27 <INFO> Starting stage 1 <<<
09:50:27 <INFO> Current GPU memory usage: 884 MiB used, 39562 MiB free
09:50:28 <WARN> reinvent_plugins.normalizers.rdkit_smiles: [*]Cc1cc2c(C[*])cncc2cc1*N1CCN(c2cc3c(c(=O)n3c(-c4ccc(NC(C)=O)cc4)nc(OC)n3)cn2)CC1C|*C could not be converted
09:50:28 <WARN> reinvent_plugins.normalizers.rdkit_smiles: c1(C[*])cc2c(cncc2C[*])nc1*NCCSc1c2sc(=O)cc-2c(O)cc1O|C* could not be converted

You can see the problematic smiles were actually generated from the program.  Please let me know if there was something wrong in the configuration of toml input.  I had listed the changes in REINVENT4/configs/toml/staged_learning.toml for libinvent early in this thread. Other part of the toml file was exactly the same as the original.
Thanks for your time.

Can you confirm that your input scaffolds have only 2  attachment points?

Hi,
I realize that this is a bug in the public version that has been fixed since then and will be available in the upcoming 4.5 release.
Many thanks and sorry for the inconvenience,
Hannes


 This is very apparent when you look at the size when compared to the 2.0.0-RC1 version:
-rw-r--r--  1 deepanshu  staff    20K Aug 27  2019 2.0.0-RC1/e18e2c2a611b30d5de472cf6fddee3c16d704d09/thrifty-compiler-2.0.0-RC1.jar
-rw-r--r--  1 deepanshu  staff    22M May 13 22:13 2.0.1/d8320ed69eb0f89c220566814cad2a8cbefb8c85/thrifty-compiler-2.0.1.jar

The side effect is that if someone wants to use it in a project with a different version of guava or some other dependency, it will be difficult.
Not sure what was the difference in compiling 2.0.0-RC1 and 2.0.0, but filing this issue so that it can be investigated before doing the next release.

The snapshots don't seem to have this problem:
-rw-r--r--  1 deepanshu  staff    21K Jun  4 13:09 2.0.2-SNAPSHOT/8f65912acdf620a3f3d593a91fa172c1200201f8/thrifty-compiler-2.0.2-SNAPSHOT.jar

That's strange; we have an -all classifier that is supposed to be the fat jar.  I'll see what broke in the build script.

Yeah, when I do a fresh build this is what I get:
~/D/thrifty ❯❯❯ ls -hal thrifty-compiler/build/libs/
total 26M
drwxr-xr-x 4 benbader 128 Jun  8 11:23 .
drwxr-xr-x 6 benbader 192 Jun  8 11:22 ..
-rw-r--r-- 1 benbader 25M Jun  8 11:23 thrifty-compiler-2.0.2-SNAPSHOT-all.jar
-rw-r--r-- 1 benbader 22K Jun  8 11:22 thrifty-compiler-2.0.2-SNAPSHOT.jar

Must be a problem with the uploadArchives task.

I double-checked the commit history, and it looks like I added the current publishing system (the gradle-maven-publish-plugin) after the most recent full release.  As best as I can tell, the next release won't have this issue.  I'll keep it open until then, and will double-check before publishing.

I'm preparing the 2.1.0 release, and can confirm that this is no longer an issue, as seen in this Sonatype screenshot:


fix(spacelist): add space list to home

@dgutride snapshot fabric8-ui is deployed and available for testing at https://fabric8-ui-fabric8-ui-pr-807-fabric8-ui.int.rdu2c.fabric8.io


Change appearance of required fields at first page load.

Description
Currently, in the Form node (and maybe others), required input fields are displayed in red even when the user has not entered any data. This makes the page\forms\input fields look as if there is something wrong or that the user already did something wrong when in fact, he\she did not do anything.
Please make it so that input fields are displayed in the theme colors and a "required" message \ change of display only occurs after the user has entered info in the field.
Epic/Story
No response
Have you provided an initial effort estimate for this issue?
I am no FlowFuse team member

Updated post: only Form node.


Heuristic Goal lanes:

Hey!
It would be great if you can point me towards the function which extracts the heuristic goal lanes for the target actor. Going through the repo, I was unable to find where this is calculated apart from the paper explanation. I would really appreciate it if you can resolve this issue.
Thanks.

Hey!
Great work. I would like to know when are you going to update this repository?
THank You!

Hey!
Great work. I would like to know when are you going to update this repository?
THank You!

I actually rewrote it for my recent paper. I will open source the repo within the next 2 weeks which contains the heuristic goal lanes search. If I still haven't, please tag me!!

@abviv what do you mean? You can find the heuristic goals in my functions.

@Linqingh as soon as possible, I am incorporating functions from another repository.

@Linqingh as soon as possible, I am incorporating functions from another repository.

thanks


Frontend needed

Since the backend is already implemented, we now need to see the frontend in action. Could you please add the registration and login pages for the frontend?

I have fixed this in: ceb013a107f68b54c6fd115ed5210d85c277700a


compute liveness and interference more quickly and with less memory

This addresses some issues found when compiling very large programs.
Previously, liveness sets would allocate much more memory than necessary (with one var set per instruction).  Now we use a much more efficient method, storing var sets just at join points in the control flow graph and interpolating liveness across straight-line instructions.  A new test is added to verify equivalence with the old/inefficient method of liveness calculation on random programs.
Also for extremely large programs, it was possible to silently truncate IDs for the 2D square interference bit matrix (used in register allocation) at the limit of int32 representation.  This change detects such truncation with an error and also extends these indexes to 64 bits to allow such large programs.

It looks like this builds and runs as expected on Linux.  For some reason the automated build fails on macOS due to a travis-ci package error.  I will follow up with those guys, though FWIW it builds/runs fine on my laptop.

Tried to update to llvm@8 (which works on my macbook), but travis-ci killed the job because it wound up building cmake and llvm from scratch and exceeded some maximum log length setting on their end (?).
I'm starting to feel like macOS support is more trouble than it's worth ...

Tried to update to llvm@8 (which works on my macbook), but travis-ci killed the job because it wound up building cmake and llvm from scratch and exceeded some maximum log length setting on their end (?).
I'm starting to feel like macOS support is more trouble than it's worth ...

it seems that moving to default osx image prevents travis-ci from pulling & rebuilding everything from scratch: https://github.com/chenkai036/hobbes/pull/7/files

Thanks Kai!  I put your .travis.yml changes in here and all stages pass.  The main change here has to do with this alternative compiler backend, which we aren't using so much in hobbes itself at the moment (but have some other large uses elsewhere).
Anyway, it's good to keep macOS support.

I get the "squash and merge" button but when I click on it, nothing happens.  Between this and the infinite progress indicator when assigning reviewers, I feel like github is trolling me.  ;)


Blazor Hybrid: Host and Deploy overview topic

When content is provided in an issue comment here, please remove the PU member assignment and assign the issue to @guardrex 🦖. PU member will be pinged on the PR when it goes up.
blazor/hybrid/host-and-deploy/index.md

It's not clear if there would be any content pertaining to the "host" part of this page, considering server-side concepts are out of the picture for Blazor Hybrid. Likewise, the publishing/deployment steps would be very similar to those of supported platforms for Blazor Hybrid. It seems like some alternatives to having a "Host and Deploy" page could be:

Add sections for Blazor Hybrid publishing considerations (if any) for supported platforms, similar to what we do for MAUI Windows.
Add a "publishing" page that primary links to the publishing pages for supported Blazor Hybrid platforms.

Do you have any opinions on the approach we should take, @guardrex?

I see what you mean. I merely listed it that way to match what we normally do for UID and physical paths for this general subject matter, which we hope 🤞 to set once at the outset and never need to change.
Do you want to change to "publish"-focused naming then? ...

Title: Publish ASP.NET Core Blazor Hybrid
UID: blazor/hybrid/publish/index
Physical path: blazor/hybrid/publish/index.md

@guardrex Yes, I think having "publish"-focused naming would be a good alternative 👍

Very well. After you paste into a comment here whatever content you think it should have, you can change the assignment to me, I'll whip up a PR based on that, and I'll ping u on the PR.

@guardrex I'm finally getting around to this... the content is short because it mostly involves linking to other publishing docs.
Publish ASP.NET Core Blazor Hybrid Apps
This article explains how to publish Blazor Hybrid apps.
Publish for a specific framework
Blazor Hybrid supports .NET MAUI, WPF, and Windows Forms. The publishing steps for apps using Blazor Hybrid are nearly identical to the publishing steps for the target platform. Blazor-specific considerations are discussed in the next section.

WPF and Windows Forms:

.NET application publishing overview

.NET MAUI:

Publish for Windows
Publish for Android
Publish for iOS
Publish for macOS

Blazor-specific considerations
Blazor Hybrid apps require a Web View to be present on the host platform. See Keep the Web View current in deployed Blazor Hybrid apps for more information.


About the dataset

Can you give a detailed description of the production process of the dataset used?Thanks

The old dataset has only about 200 grasps in each scene. In the last week I
will share a new dataset.
The data generation involves 4 steps.(1) simulate scenes and render
observed point cloud (2)construct collision-free grasps. (3) obtain grasp
quality scores (4) compute point grasp confidence for each point in the
observed point cloud. The code is based on the S4G.
Best wishes,
Binglei
liuxi1234 @.***> 于2021年4月29日周四 上午10:16写道：

Can you give a detailed description of the production process of the
dataset used?Thanks
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/zhaobinglei/REGNet_for_3D_Grasping/issues/1, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AICEB6B4KTRZERYSR4EANUDTLC6PFANCNFSM43YKXIMA
.

Same as the #3
The link to the new dataset is https://pan.baidu.com/s/1alwaKQZt0IGE11FFSClxOg . And the extraction code is x79a. (Maybe you can only use a Chinese proxy to access the link.)


Material specular renders differently between clustered lighting and non-clustered lighting

Post: https://forum.playcanvas.com/t/spotlight-gives-wrong-result/28440/11?u=yaustar
Project: https://playcanvas.com/project/1010843/overview/specular-highlights-issue
With clustered lighting

Without clustered lighting

This was probably fixed in this PR: https://github.com/playcanvas/engine/pull/4870.


Leverage the base bc wysiwyg html editor?

The newer email functionality has an html wysiwyg editor. I would like to re-use that on another page without needing to reinvent this wheel. There are plenty of examples out there, but in my opinion it's better to use the base when possible.
I'm referring to this page: https://github.com/microsoft/ALAppExtensions/blob/2cf3c3f8395aa2cda684513b738f69fedca3fe91/Modules/System/Email/src/Email/Outbox/EmailEditor.Page.al
The magic isn't in that file, so I suspect there's a page extension or some other magic inserting a control addin? It would be great if there was some way for me to leverage that.

@JesperSchulz

seems like a dupe of #15040
see also experience.dynamics.com/ideas/idea/?ideaid=6497fbae-cc6b-e911-b047-0003ff688f46

Same question yes. Didn't find that issue when searching. It's been about six months, so maybe the status has changed though.

I'm afraid we're still not able to release the rich-text editor as a standalone control :-( Please use one of the many alternatives out there. I cannot give an ETA when we'll be able to release it (if ever), or if we'll be forced to use a different editor internally and externally, to make it happen.


vpn

what is vpn for

what vpn?

what vpn?

what vpn?

Ah it just means if the user is connected to a vpn or not.

what vpn?

Ah it just means if the user is connected to a vpn or not.

ok


Column reordering is very unintuitive

Describe the bug
When you drag and drop columns to reorder them the new order is totally different to everything you're used to.
Steps to reproduce

Create a table with 5 columns
Drag column 2 between column 4 + 5
Column 2 will now become column 4 and column 4 will become column 2

Expected behavior

Column 2 should be between column 4 + 5 and become column 4
Column 4 + 3 should move to column 3 + 2 respectively

Are you using the mobile app?
Yes
Obsidian debug info
SYSTEM INFO:
Obsidian version: v1.2.8
Installer version: v1.2.7
Operating system: Windows 10 Pro 10.0.22621
Login status: not logged in
Insider build toggle: off
Live preview: on
Legacy editor: off
Base theme: dark
Community theme: none
Snippets enabled: 0
Restricted mode: off
Plugins installed: 10
Plugins enabled: 10
1: Obsidian Git v2.19.1
2: Calendar v1.5.10
3: Tasks v3.7.0
4: Dataview v0.5.55
5: Excalidraw v1.9.1
6: ExcaliBrain v0.1.13
7: Kanban v1.5.3
8: Natural Language Dates v0.6.1
9: Advanced Tables v0.18.1
10: Notion-Like Tables v6.9.1
RECOMMENDATIONS:
Community plugins: for bugs, please first try updating all your plugins to latest. If still not fixed, please try to make the issue happen in the Sandbox Vault or disable community plugins.
Relevant log output
No response

@trey-wallis Just tested rows and yeah, I think it also should be changed. Excel and LibreOffice Calc and basically every other application I've ever used simply move the dragged column/row between the two columns/rows where you drop it.

@trey-wallis Just tested rows and yeah, I think it also should be changed. Excel and LibreOffice Calc and basically every other application I've ever used simply move the dragged column/row between the two columns/rows where you drop it.

I agree. I just came here to open an issue about the row reordering. The current behavior is completely unexpected and frustrating. I was trying to organize similar items, but with the current behavior, it's impossible. Relatedly, it would be nice to be able to insert columns and rows at the current location, so there is less need for dragging and dropping.

@MSBack I am sorry for the frustration. I am pushing out a fix shortly. I have also made a new issue to insert above/insert below. Expect that to come out in the next few days. Cheers! :)

Thanks man, I appreciate the responsiveness!

@GuybrushX @MSBack Fixed in 6.9.3

@GuybrushX @MSBack Fixed in 6.9.3

Thanks a lot, that's much better and easier to work with! :-)


refactor(transformer): remove returning None from transform functions

Current dependencies on/for this PR:

main

PR #1074

PR #1075

PR #1076

PR #1077

PR #1078

PR #1079   👈

This comment was auto-generated by Graphite.

Merge activity

Oct 28, 4:46 AM: Graphite rebased this pull request after merging its parent, because this pull request is set to merge when ready.


pull.rb: Fix tap args

brew pull fetches a patch from a GitHub commit or pull request and applies it
     Failure/Error:
       expect { brew "pull", "https://jenkins.brew.sh/job/Homebrew\%20Testing/1028/" }
         .to output(/Testing URLs require `\-\-bottle`!/).to_stderr
         .and not_to_output.to_stdout
         .and be_a_failure

       expected block to output /Testing URLs require `\-\-bottle`!/ to stderr, but output "Error: no block given\n/home/linuxbrew/.linuxbrew/Homebrew/Library/Homebrew/dev-cmd/pull.rb:115:in `...ll.rb:112:in `pull'\n/home/linuxbrew/.linuxbrew/Homebrew/Library/Homebrew/brew.rb:100:in `<main>'\n"
     # ./test/dev-cmd/pull_spec.rb:15:in `block (2 levels) in <top (required)>'
     # ./test/support/helper/spec/shared_context/integration_test.rb:44:in `block (2 levels) in <top (required)>'
     # ./test/spec_helper.rb:106:in `block (2 levels) in <top (required)>'
     # ./vendor/bundle/ruby/2.3.0/gems/rspec-retry-0.5.6/lib/rspec/retry.rb:115:in `block in run'
     # ./vendor/bundle/ruby/2.3.0/gems/rspec-retry-0.5.6/lib/rspec/retry.rb:104:in `loop'
     # ./vendor/bundle/ruby/2.3.0/gems/rspec-retry-0.5.6/lib/rspec/retry.rb:104:in `run'
     # ./vendor/bundle/ruby/2.3.0/gems/rspec-retry-0.5.6/lib/rspec_ext/rspec_ext.rb:12:in `run_with_retry'
     # ./vendor/bundle/ruby/2.3.0/gems/rspec-retry-0.5.6/lib/rspec/retry.rb:33:in `block (2 levels) in setup'
     # ./vendor/bundle/ruby/2.3.0/gems/rspec-wait-0.0.9/lib/rspec/wait.rb:46:in `block (2 levels) in <top (required)>'

Codecov Report

Merging #667 into master will increase coverage by <.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #667      +/-   ##
==========================================
+ Coverage   68.73%   68.73%   +<.01%
==========================================
  Files         383      383
  Lines       20742    20743       +1
==========================================
+ Hits        14257    14258       +1
  Misses       6485     6485

Impacted Files
Coverage Δ

dev-cmd/pull.rb
31.73% <0%> (+0.17%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 19e04f8...fa3db34. Read the comment docs.

I changed @args.method_missing(:tap) to tap = @args[:tap]. I'll merge it once CI passes.

Thanks @sjackman


Fix 040 copy-n-paste errors

Few minor updates for the 050 release.

👍 looks good to me, sorry for missing those


Sort searches

Searches should be able to be sorted.
-Title asc/desc on click
-DateTime asc/desc on click
-(tags ex. 'User:', 'Date:', ... if time enough)
Parent: #12

careful, filtering is not the same as sorting:

to filter = show a subset of results
to sort = sort that (sub)set somehow

Okay, so I guess the search itself (#12) would qualify as a filter then. This issue has the purpose of sorting the resulting data.

indeed. searching, sorting and filtering are three different beasts.

No time to implement


Feature Request: Layered Armour with Hardened Layers

I don't know about GCS, but GCA takes armour in layers but only provides a total value, and it seems that's the same in game in VTT.  The system allows for Hardened armour, but not by layers.  It would be great to able to handled layered armour completely, including hardened layers, when calculating damage.
i.e. hardened clamshell UT-style armour with software nanoweave underneath that isn't hardened.  So AD is lessened by the clamshell, but not by the nanoweave.

I had a thought about how this might be easily implemented.
Suggestion is when you tick hardened in the ADD, it shows the current DR in the location already selected and then next to it an input box to modify how much of it is hardened if you want.  So if my UT combat warrior guy has DR20 hardened in a clamshell and then DR20 normal underneath as nanoweave, it shows the 40 but I can type in 20.  The calculation for hardened is then only applied to the first 20 DR.
So if I have the above DR and I'm attacked with an AD 2 weapon doing, say, 44 points of cutting damage.  ADD after ticking hardened shows 40 points total DR.  If all of it is hardened, I do nothing, and the AD2 becomes no AD and so just 4 points of cutting gets through (and the damage modifier is applied for the location).  However, if it type 20 in the input box, it means only 20 points is hardened.  So 44 has 20 points taken off it by the hardened layer, leaving 24 which is AD2 against the inner layer of DR20 so the DR only protects for 10 leaving 14 points to get through.
Thoughts?

Going to compile all armour/DR/damage handling into a single request.


Allocation failed - process out of memory

I'm getting a 'FATAL ERROR: CALL_AND_RETRY_LAST Allocation failed - process out of memory error' while trying to sync changes using livesync. The only fancy stuff i'm doing is through the following function, which uses the native Android API to apply a linear gradient to a given View:
export function setupBackgroundGradient(view: View, colorCodes: string[], stops: number[]) {
  var backgroundDrawable = new android.graphics.drawable.GradientDrawable();
  var colors = [];
  colorCodes.forEach(function(c) {
    let color = new Color(c);
    colors.push(color.android);
  });
  backgroundDrawable.setColors(colors);
  backgroundDrawable.setGradientType(0); // Linear Gradient
  var orientation = android.graphics.drawable.GradientDrawable.Orientation.LEFT_RIGHT;
  backgroundDrawable.setOrientation(orientation);
  backgroundDrawable.setAlpha(225);
  view.android.setBackgroundDrawable(backgroundDrawable);
}

The log trace is the following:
10:26:55 PM - File change detected. Starting incremental compilation...

FATAL ERROR: CALL_AND_RETRY_LAST Allocation failed - process out of memory

<--- Last few GCs --->

  170921 ms: Scavenge 1388.6 (1456.5) -> 1388.6 (1456.5) MB, 7.9 / 0 ms (+ 1.8 ms in 1 steps since last GC) [allocation failure] [incremental marking delaying mark-sweep].
  172462 ms: Mark-sweep 1388.6 (1456.5) -> 1388.5 (1456.5) MB, 1540.4 / 0 ms (+ 3.9 ms in 23 steps since start of marking, biggest step 1.8 ms) [last resort gc].
  173984 ms: Mark-sweep 1388.5 (1456.5) -> 1388.5 (1456.5) MB, 1522.1 / 0 ms [last resort gc].

<--- JS stacktrace --->

==== JS stack trace =========================================

Security context: 0x98f621b4629 <JS Object>
    1: modifierToFlag [/home/bruno/workspace/Signup-Test/node_modules/typescript/lib/tsc.js:~5365] [pc=0x9cd044e7cc3] (this=0x24d1bbcb35b9 <an Object with map 0x2997c117b269>,token=111)
    2: checkGrammarModifiers(aka checkGrammarModifiers) [/home/bruno/workspace/Signup-Test/node_modules/typescript/lib/tsc.js:23930] [pc=0x9cd01816162] (this=0x98f621041b9 <undefined>,node=0x160...

What's strange is that this doesn't come up 100% of the time, and not only when I make a change to the file containing the setBackgroundGradient function... and when I restart livesync, it works perfectly fine, at least for the first compilation.
Any idea where that might be coming from?

I see this alot too.

Have you found a solution? It's getting really annoying

Well actually, since 2.2.1 I'm getting less of these (It still comes from time to time though), so for now it's acceptable.
What version do you use?

It's really annoying, trying to figure out how to increase this with --max_old_space_size=4096


Add icons

Description
We have a need for icons in many of our components, and we dont want to use font-icons for this because it has some problems (font not loading, font loading slowly, etc...)
We would like to use SVG icons.
The icons should be designed:

on a 36*36px grid
as a single path (can we flatten the icons programatically? if not, it needs to be modified before export)
2px gap between icon and grid
... all design rules are listed in Figma: https://www.figma.com/file/hGQZ5IiihuCIstjKFpv0YQ/ADS-3---Ressurser?node-id=110%3A16

Other major icon libraries are also doing it in a very similar way, f.ex https://materialdesignicons.com
Additional Information
By enforcing designs to only contain 1 path element, its easier to enforce certain rules programatically, and it is also possible to export icons as "path strings" instead of complex components. The downsides are that it will only be possible with monocolor icons, and no animations within the icon. If we have a need for multicolor icons, or icons with animations, they need to be handled separately.
Example SVG export from Figma:
<svg width="36" height="36" viewBox="0 0 36 36" fill="none" xmlns="http://www.w3.org/2000/svg">
  <path d="M11.5228 34L10 32.4762L24.6566 18L10 3.52381L11.5228 2L27.3214 18L11.5228 34Z" fill="black"/>
</svg>

There are a couple problems with this icon. There is a fixed width and height on the SVG element, which makes it impossible to override this via css without using !important. There is also a fixed fill on the path element, which makes it impossible to override the color of the icon without using !important. These problems could be fixed by manually editing the file after export, or running them through a tool like SVGO to automatically clean up the code. But it still leaves us with a complex object we need to deal with.
If we instead extract the d attribute of the path, we can export all icons represented as a string:
const arrowRight = "M11.5228 34L10 32.4762L24.6566 18L10 3.52381L11.5228 2L27.3214 18L11.5228 34Z";

and the rest of the implementation can be done as a React component:
const Icon = (path: string) => {
  return (
    <svg viewBox="0 0 36 36" xmlns="http://www.w3.org/2000/svg">
      <path d={path} />
    </svg>);
}

In our icon library we have 2 weights of the icons. By using this approach, we can also easily increase the weight, instead of having several SVG's with different weights, by doing something like:
type IconProps = {
  path: string;
  weight?: Weight;
};

const Icon = ({ path, weight = Weight.Regular }: IconProps) => {
  const strokeProps =
    weight === Weight.Bold
      ? {
          stroke: "currentColor",
          strokeWidth: 1
        }
      : {};

  return (
    <svg viewBox="0 0 36 36" xmlns="http://www.w3.org/2000/svg">
      <path d={path} {...strokeProps} />
    </svg>
  );
};

Setting status back to draft, because we might use an external library instead, and this approach may not be what we end up with.

Closing this issue since the decision fell on using NAVs icons.


[vcpkg] Add nologo to windows toolchain

closes #11144
There are still some linker logos in the log but i am apparently unable to find the correct cmake variable for it

just for symmetry reasons, do you maybe also need to add it to CMAKE_SHARED_LINKER_FLAGS_DEBUG and CMAKE_EXE_LINKER_FLAGS_DEBUG?
Also, why is there a /DEBUG flag in a *_RELEASE symbol? I realize it was already there, just questioning it in principle

/azp run

@Neumann-A why do you have two different styles of adding this flag? both set and string(APPEND? Is there a reason for it?

@Neumann-A why do you have two different styles of adding this flag? both set and string(APPEND? Is there a reason for it?

_INIT flags versus normal flags. The set command completely overwrites the other variables and _INIT flags are used to initialize the normal values. I am just following the style of the other toolchains which use _INIT with string(APPEND)
https://github.com/microsoft/vcpkg/blob/305785ba9b2b4ebd37d0a2c9676b863bb7e0a94e/scripts/toolchains/linux.cmake#L12-L22

Ah, I see! why not modify the CMAKE_EXE_LINKER_FLAGS_RELEASE_INIT and CMAKE_SHARED_LINKER_FLAGS_RELEASE_INIT then?

Because it would require me to check the CMake source again to check how to change
    set(CMAKE_SHARED_LINKER_FLAGS_RELEASE "/nologo /DEBUG /INCREMENTAL:NO /OPT:REF /OPT:ICF ${VCPKG_LINKER_FLAGS}" CACHE STRING "")
    set(CMAKE_EXE_LINKER_FLAGS_RELEASE "/nologo /DEBUG /INCREMENTAL:NO /OPT:REF /OPT:ICF ${VCPKG_LINKER_FLAGS}" CACHE STRING "")

into the CMAKE_EXE_LINKER_FLAGS_RELEASE_INIT|CMAKE_SHARED_LINKER_FLAGS_RELEASE_INIT  variables if this is even possible. Since the last time I changed those variables I broke vcpkg (da0a15485256837569d0e6b00a5940757ff57971 9b44e4768bf25e1ae07e6eaba072c1a1a160f978) I don't dare to touch them again for some time ;)

I'd trigger a full rebuild before merging, just in case ;)

@strega-nil (something that a toolchain modification should already do 😉)


Integration test not able to track all messages

There is a problem with tracking messages that are sent from ASP.NET Core middleware after controller logic. The issue is reproduced in this simple app.
The app has a MessageMiddleware that sends the BeforeMessage before the controller and AfterMessage after the controller. In between, the controller sends it own message of type ControllerMesssage.
The all_messages_are_tracked test tries to track these messages. The tracking works when controller returns plain Ok() but does not work when controller returns any kind of object, even a simple string.

@mirinkinen I stumbled into this myself today while working on something completely different. The tracking was always used before on a single triggering message. In your case -- and mine -- it's able to think it's complete and trigger the task completion during the actions in the ExecuteAndWaitAsync(). I'm fixing this today to latch that. Easy money once and only once I saw a reproduction.


Printing error from esbuild can fail

Acknowledgements

[X] I searched existing issues before opening this one to avoid duplicates
[X] I understand this is not a place for seek help, but to report a bug
[X] I understand that the bug must be proven first with a minimal reproduction
[X] I will be polite, respectful, and considerate of people's time and effort

Minimal reproduction URL
na
Version
4.7.1
Node.js version
20.11.1
Package manager
npm
Operating system
macOS
Problem & Expected behavior
I have my project set up with tsx (macOS), which all works fine. However I wanted to test something in linux, so I created a VM with a bind mount to my project. This caused the node_modules folder that was installed on macOS, to also be used on linux. This is not supported by esbuild: https://github.com/evanw/esbuild/blob/c809af050a74f022d9cf61c66e13365434542420/lib/npm/node-platform.ts#L195
Which is my mistake. However this took me a bit to figure out, because tsx is accidentally hiding this error:
node --import tsx src/bin.mts --help

node:internal/process/esm_loader:34
      internalBinding('errors').triggerUncaughtException(
                                ^
TypeError [Error]: undefined is not iterable (cannot read property Symbol(Symbol.iterator))
    at bt (file:///foo/node_modules/tsx/dist/index-29948669.mjs:16:1598)
    at file:///foo/node_modules/tsx/dist/index-29948669.mjs:17:632
    at hr (file:///foo/node_modules/tsx/dist/index-29948669.mjs:16:1071)
    at Cr (file:///foo/node_modules/tsx/dist/index-29948669.mjs:17:560)
    at Z (file:///foo/node_modules/tsx/dist/esm/index.mjs:5:1755)
    at async nextLoad (node:internal/modules/esm/hooks:865:22)
    at async Hooks.load (node:internal/modules/esm/hooks:448:20)
    at async MessagePort.handleMessage (node:internal/modules/esm/worker:196:18)

Node.js v20.11.1

I think this is the code in question: https://github.com/privatenumber/tsx/blob/b39e9b143a9d080286c607f96aaa9f4b8ce8702a/src/utils/transform/index.ts#L28
Manually adding a console.log(error) to the minified code in node_modules/tsx, allowed me to figure out what was going on:
You installed esbuild for another platform than the one you're currently using.
This won't work because esbuild is written with native code and needs to
install a platform-specific binary executable.

Specifically the "@esbuild/darwin-arm64" package is present but this platform
needs the "@esbuild/linux-arm64" package instead. People often get into this
situation by installing esbuild on Windows or macOS and copying "node_modules"
into a Docker image that runs Linux, or by copying "node_modules" between
Windows and WSL environments.

If you are installing with npm, you can try not copying the "node_modules"
directory when you copy the files over, and running "npm ci" or "npm install"
on the destination platform after the copy. Or you could consider using yarn
instead of npm which has built-in support for installing a package on multiple
platforms simultaneously.

If you are installing with yarn, you can try listing both this platform and the
other platform in your ".yarnrc.yml" file using the "supportedArchitectures"
feature: https://yarnpkg.com/configuration/yarnrc/#supportedArchitectures
Keep in mind that this means multiple copies of esbuild will be present.

Another alternative is to use the "esbuild-wasm" package instead, which works
the same way on all platforms. But it comes with a heavy performance cost and
can sometimes be 10x slower than the "esbuild" package, so you may also not
want to do that.

    at generateBinPath (/foo/node_modules/esbuild/lib/main.js:1910:17)
    at esbuildCommandAndArgs (/foo/node_modules/esbuild/lib/main.js:1991:33)
    at ensureServiceIsRunning (/foo/node_modules/esbuild/lib/main.js:2162:25)
    at transform (/foo/node_modules/esbuild/lib/main.js:2049:37)
    at file:///foo/node_modules/tsx/dist/index-29948669.mjs:2553:32
    at hr (file:///foo/node_modules/tsx/dist/index-29948669.mjs:2511:29)
    at Cr (file:///foo/node_modules/tsx/dist/index-29948669.mjs:2550:32)
    at Z (file:///foo/node_modules/tsx/dist/esm/index.mjs:5:1755)
    at async nextLoad (node:internal/modules/esm/hooks:865:22)
    at async Hooks.load (node:internal/modules/esm/hooks:448:20)

This error value does not have an "errors" property.
I would suggest changing the code to look like (untested):
const handleEsbuildError = (
	error: TransformFailure | Error,
) => {
	let errorMessage;

	if ('errors' in error) { // assume TransformFailure
		const [firstError] = error.errors;
		errorMessage = `[esbuild Error]: ${firstError.text}`;

		if (firstError.location) {
			const {file, line, column} = firstError.location;
			errorMessage += `\n	at ${file}:${line}:${column}`;
		}

	} else {
		errorMessage = `[esbuild Error]: ${error.message}`;
	}

	console.error(errorMessage);

	// eslint-disable-next-line n/no-process-exit
	process.exit(1);
};

Contributions

[X] I plan to open a pull request for this issue
[ ] I plan to make a financial contribution to this project

PR welcome but I'd need verification that the fix is effective

Same issue. Really unhelpful error message.

I'm running into the same issue, though pnpm ls esbuild doesn't show anything so it looks like this issue might occur in situations not involving esbuild, too.

Oh, nvm. After patching tsx it looks like I'm getting the same error as @Joris-van-der-Wel.
Here's the patch file I created using pnpm patch in case it's useful to anyone:
<EMAIL_ADDRESS>

As per the Contribution Guide, I've hid comments that aren't produce towards landing a fix.
@narthur Would you be open to contributing a PR?

@privatenumber Sure, I can take a whack at it.

Same issue
tsx --env-file=.env src/index.ts

node:internal/process/esm_loader:34
      internalBinding('errors').triggerUncaughtException(
                                ^
TypeError [Error]: undefined is not iterable (cannot read property Symbol(Symbol.iterator))
    at bt (file:///Users/user/node_modules/tsx/dist/index-29948669.mjs:16:1598)
    at file:///Users/user/node_modules/tsx/dist/index-29948669.mjs:17:632
    at hr (file:///Users/user/node_modules/tsx/dist/index-29948669.mjs:16:1071)
    at Cr (file:///Users/user/node_modules/tsx/dist/index-29948669.mjs:17:560)
    at Z (file:///Users/user/node_modules/tsx/dist/esm/index.mjs:5:1755)
    at async nextLoad (node:internal/modules/esm/hooks:749:22)
    at async Hooks.load (node:internal/modules/esm/hooks:382:20)
    at async handleMessage (node:internal/modules/esm/worker:199:18)

Version 4.7.1

How to resolve this issus on docker ?

We no longer do the following so this should no logner happen:
const [firstError] = error.errors;

https://github.com/privatenumber/tsx/blob/bd83d3bf59e39767ec64eec86fe5b48a8e50b991/src/utils/transform/index.ts#L25C7-L34

If anyone is still encountering that non-transform related esbuild errors/warnings are being suppressed, please file an issue with a minimal reproduction
If you're getting an error from esbuild, file it at https://github.com/evanw/esbuild


Update flannel to 0.5.5

Current CoreOS stable release (835.9.0) ships with flannel 0.5.3, which have a problem regarding IP Tables generation that prevents pods to access services in other pods using the service IP, when proxy is configured to use iptables. Flannel version 0.5.5 works accordingly.
See this Kubernetes issues for insight.
So far, the quick and dirty way to fix this is by overwriting the unit's flanneld.service by its definition in #cloud-config.
For now, let's implement the above solution (both in master and workers) until CoreOS stable ships with flannel 0.5.5 which is currently in alpha.

562e82 Implements the quick and dirty way discussed above. There must be a better way to solve this.


Add Constraints

I need a constraint block, and it needs to be able to accept comparators and equations over numbers only. That is going to require changing how comparators and non-identity operators are in the same block, right now. Might need to move the comparator operators to math, but check to see if they work on anything else.

This was originally inteded as a Flora-2 issues, but s(CASP) has the same features, so I'm adding it to the s(CASP) project also.

Done in v1.


Security Advisory: Unmaintained Crate Detected

Summary
The recent audit job detected an unmaintained crate dependency in the project.
Further Details
Crate: dotenv
Version: 0.15.0
Warning: unmaintained
Title: dotenv is Unmaintained
Date: 2021-12-24
ID: RUSTSEC-2021-0141
URL: RUSTSEC-2021-0141
Dependency Tree:
dotenv 0.15.0
└── kopgen 1.10.0
Please address this issue by considering an alternative crate or updating the dependency.
Link
https://github.com/edenreich/kopgen/actions/runs/11957531044/job/33334895664#step:6:1

:tada: This issue has been resolved in version 1.12.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Verilog-A model not mathematically sound

The Verilog-A model does a manual integration of the filament thickness here:
https://github.com/google/skywater-pdk-libs-sky130_fd_pr_reram/blob/6574676cbbd062d63be0f090013d59ced7302349/cells/reram_cell/sky130_fd_pr_reram__reram_cell.va#L96
This is not a mathematically sound way to do this, because it makes the solution dependent on the simulator's chosen timestep. Such trajectory-dependent models will confuse adaptive integrators and generally cause more sophisticated simulators to error. The correct way to handle something like this is to give this as a separate ODE to the integrator, e.g.
as
eletrical Tfilament;
[....]
I(Tfilament) <+ ddt(V(Tfliament)) - Tfilament_dTdt

Of course, Tfilament isn't actually a voltage, so if one was bothered by that, one could do a custom discipline
nature Growth;
  units      = "m/s";
  access     = Growth;
  idt_nature = Length;
end

nature Length;
  units      = "m";
  access     = Length;
  ddt_nature = Growth;
end

discipline metric;
  potential Length;
  flow Growth;
enddiscipline

which would let you write the above as:
metric Tfilament;
[....]
Growth(Tfilament) <+ ddt(Length(Tfliament)) - Tfilament_dTdt

(I can submit a PR for this at some point, but I haven't tested that this actually works yet, so I'll do that once I get around to doing that, unless somebody beats me to it).

These two documents could be useful;

Guan, S. Yu, H.-S. P. Wong, "A SPICE Compact Model of Metal Oxide Resistive Switching Memory With Variations https://ieeexplore.ieee.org/abstract/document/6296677
Jiang, S. Yu, Y. Wu, J. Engel, X. Guan, H.-S. P. Wong, "Verilog-A compact model for oxide-based resistive random access memory (RRAM) https://ieeexplore.ieee.org/abstract/document/6931558

@Keno Does that also imply that the temperature integrator is wrong as well?
https://github.com/google/skywater-pdk-libs-sky130_fd_pr_reram/blob/6574676cbbd062d63be0f090013d59ced7302349/cells/reram_cell/sky130_fd_pr_reram__reram_cell.va#L99

Yes, sorry should have specified. Also it's not "wrong" as much as "bad"/"unsound". For integrators without adaptive time stepping or dynamic error detection, it will probably give sensible answers.

So basically we should remove all the unsound integrators, and replace them with custom disciplines.

Yes, though the "custom disciplines" part of that is optional (and I wouldn't be surprised if many simulators chocked on those) and of course thermal is already a standard discipline. But yes, replace all manual integration with proper ODE representations. Plus you'll be able to remove the time step bounding
https://github.com/google/skywater-pdk-libs-sky130_fd_pr_reram/blob/9ba7d408c9f360c9afd24c7ba8a4d0a3976549fb/cells/reram_cell/sky130_fd_pr_reram__reram_cell.va#L89
so your simulations will both be faster and more accurate :)

@Keno - Looking forward to your pull request! It would be great if we could add some spice simulations which produce the graphs found in the documentation too.

@Keno Is there a way to cap the growth of Tfilament? Tfilament is supposed to be limited to between 3.3nm and 4.9nm. Using the Growth(Tfilament) construct, it grows without bound.


Visualization of stage lighting vectors

When a light00.nuanmb is loaded in the stage lighting section, a way to visualize the stage lighting vectors. Specifically for the rotations but you could also visualize translations and scales too. It would also help to have the names of each vector display similar to the bone names.

Can you elaborate on what information you would want to see in a vizualization? The current renderer is primarily focused on character rendering, which just needs the direction vector. Programs typically represent directions as XYZ euler angles or as a 3D directional arrow in the viewport. Creating a meaningful visualization for the translation and scale would require researching what those values actually do in game. One possible theory is that directional lights are restricted to a region of influence. I believe smash 4 had a similar system, but I don't recall looking into it much.

I was thinking something like this

I actually like that idea.

Using arrows with the names seems like a good approach. There will need to be some UI changes to control the visualization. Lighting applies to the entire scene, so it probably doesn't need to be more advanced than some checkboxes to toggle the light shapes on/off in render settings. It depends on how many lights there are for a typical stage.


Appstudio update test-component-pac-mgmy

Pipelines as Code configuration proposal

Pipelines as Code CI/test-component-pac-mgmy-on-pull-request has successfully validated your commit.

StatusDurationName

✅ Succeeded
8 seconds
init

✅ Succeeded
13 seconds
clone-repository

✅ Succeeded
27 seconds
build-container

✅ Succeeded
17 seconds
deprecated-base-image-check

✅ Succeeded
17 seconds
sanity-inspect-image

✅ Succeeded
13 seconds
clair-scan

✅ Succeeded
34 seconds
clamav-scan

✅ Succeeded
12 seconds
sbom-json-check

✅ Succeeded
15 seconds
sanity-label-check

✅ Succeeded
14 seconds
sanity-optional-label-check

✅ Succeeded
6 seconds
show-summary


[SPARK-LLAP-129][TEST][FOLLOW-UP] Update Ranger error message.

What changes were proposed in this pull request?
This PR updates the test answer files for test_22_create_location.
BEFORE
$ python spark-ranger-secure-test.py
........F...............
----------------------------------------------------------------------
Ran 24 tests in 3165.302s

How was this patch tested?
Pass the test suite.

cc @bikassaha and @merlintang .

Thank you so much.


[WIP] Enable multisig testing for coldcard in CI

Probably doesn't Just Work but will give me some hint on what more there is to do.
would resolve https://github.com/bitcoin-core/HWI/issues/248

ok doesn't work as I expected. Need to figure out the new image situation.

Without change detection it should work if coldcard has the corresponding multisig wallet imported.
Example of the multisig wallet:
Name: MyMultisigWallet
Policy: 2 of 2
Derivation: m/48'/1'/0'/2'
Format: P2WSH
7C16EF20: tpubDFKT3s2snbsbu9ABgNwkne3pe2ygiXP3hWpoFhrprJP2ySsSVKqCZq8tuCBXXon4RiXAVpC1QnrjdA8y6Mk8WxcianZByPEm4T2zy2fWgN7
F79EC910: tpubDEe6NkFUArzPR4AZ5q5kKwaWLZjQhPjD3xqQbE51kQ6xb9cANrUyeauYtHrwTjX8z32xBHzVKYAiAoykBwt5LX1vb7j163RuMJn9qrQ8Hnc

Saving it as .txt file and importing it from the SD card would allow you to sign multisig transactions on the ColdCard (it should be possible to do over USB as well, but I don't know the exact command).
If you also want to detect change addresses you also need to provide xpubs in the global scope of the PSBT (according to the bip174 - 0x01<xpub>: <fingerprint><hardened_derivation>).
The problem here is that HWI is stateless so if co-signers are not connected we don't know their xpubs.

no time to carry this, sorry


fix: type definition build and remove unused eslint disables

'Local installation' of this package  (aka, from git url) was failing on build state because of missing dependencies. I've added those as devDependency to resolve said type definition build errors.
I've also removed unused eslint disables from the webpack.config.js of example folder which was causing precommit hook to fail.
Motivation

To be able to install and test latest changes from the git repo, a successful build is needed, specially when consuming the package on a TS project.
Test plan

Package builds without error.
Commit without precommit hook failing

Best regards.

Thanks for the PR, but the proper way to address this is to use a separate config for build which I added in https://github.com/satya164/react-native-tab-view/commit/c9b8c22b188c06416cd453f4de0bb08760b652b2