Ignore port number in domain matching entirely

Fixes https://github.com/istio/istio/issues/40474
This is finally available in Envoy so we can drop our hacks of adding
the port, adding :*, etc.
Please provide a description of this PR:

@howardjohn: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

unit-tests-arm64_istio
a08cd93ce2522fd8e3c4b7d90448186e28018f8c
link
true
/test unit-tests-arm64_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

unit-tests-arm64_istio
a08cd93ce2522fd8e3c4b7d90448186e28018f8c
link
true
/test unit-tests-arm64_istio

lint_istio
a08cd93ce2522fd8e3c4b7d90448186e28018f8c
link
true
/test lint_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

unit-tests-arm64_istio
a08cd93ce2522fd8e3c4b7d90448186e28018f8c
link
true
/test unit-tests-arm64_istio

lint_istio
a08cd93ce2522fd8e3c4b7d90448186e28018f8c
link
true
/test lint_istio

unit-tests_istio
a08cd93ce2522fd8e3c4b7d90448186e28018f8c
link
true
/test unit-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

unit-tests-arm64_istio
a08cd93ce2522fd8e3c4b7d90448186e28018f8c
link
true
/test unit-tests-arm64_istio

lint_istio
a08cd93ce2522fd8e3c4b7d90448186e28018f8c
link
true
/test lint_istio

unit-tests_istio
a08cd93ce2522fd8e3c4b7d90448186e28018f8c
link
true
/test unit-tests_istio

integ-ipv6_istio
a08cd93ce2522fd8e3c4b7d90448186e28018f8c
link
true
/test integ-ipv6_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

unit-tests-arm64_istio
a08cd93ce2522fd8e3c4b7d90448186e28018f8c
link
true
/test unit-tests-arm64_istio

lint_istio
a08cd93ce2522fd8e3c4b7d90448186e28018f8c
link
true
/test lint_istio

unit-tests_istio
a08cd93ce2522fd8e3c4b7d90448186e28018f8c
link
true
/test unit-tests_istio

integ-ipv6_istio
a08cd93ce2522fd8e3c4b7d90448186e28018f8c
link
true
/test integ-ipv6_istio

integ-basic-arm64_istio
a08cd93ce2522fd8e3c4b7d90448186e28018f8c
link
true
/test integ-basic-arm64_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

unit-tests-arm64_istio
a08cd93ce2522fd8e3c4b7d90448186e28018f8c
link
true
/test unit-tests-arm64_istio

lint_istio
a08cd93ce2522fd8e3c4b7d90448186e28018f8c
link
true
/test lint_istio

unit-tests_istio
a08cd93ce2522fd8e3c4b7d90448186e28018f8c
link
true
/test unit-tests_istio

integ-ipv6_istio
a08cd93ce2522fd8e3c4b7d90448186e28018f8c
link
true
/test integ-ipv6_istio

integ-basic-arm64_istio
a08cd93ce2522fd8e3c4b7d90448186e28018f8c
link
true
/test integ-basic-arm64_istio

integ-distroless_istio
a08cd93ce2522fd8e3c4b7d90448186e28018f8c
link
true
/test integ-distroless_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

unit-tests-arm64_istio
a08cd93ce2522fd8e3c4b7d90448186e28018f8c
link
true
/test unit-tests-arm64_istio

lint_istio
a08cd93ce2522fd8e3c4b7d90448186e28018f8c
link
true
/test lint_istio

unit-tests_istio
a08cd93ce2522fd8e3c4b7d90448186e28018f8c
link
true
/test unit-tests_istio

integ-ipv6_istio
a08cd93ce2522fd8e3c4b7d90448186e28018f8c
link
true
/test integ-ipv6_istio

integ-basic-arm64_istio
a08cd93ce2522fd8e3c4b7d90448186e28018f8c
link
true
/test integ-basic-arm64_istio

integ-distroless_istio
a08cd93ce2522fd8e3c4b7d90448186e28018f8c
link
true
/test integ-distroless_istio

integ-pilot-istiodremote_istio
a08cd93ce2522fd8e3c4b7d90448186e28018f8c
link
true
/test integ-pilot-istiodremote_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

unit-tests-arm64_istio
a08cd93ce2522fd8e3c4b7d90448186e28018f8c
link
true
/test unit-tests-arm64_istio

lint_istio
a08cd93ce2522fd8e3c4b7d90448186e28018f8c
link
true
/test lint_istio

unit-tests_istio
a08cd93ce2522fd8e3c4b7d90448186e28018f8c
link
true
/test unit-tests_istio

integ-ipv6_istio
a08cd93ce2522fd8e3c4b7d90448186e28018f8c
link
true
/test integ-ipv6_istio

integ-basic-arm64_istio
a08cd93ce2522fd8e3c4b7d90448186e28018f8c
link
true
/test integ-basic-arm64_istio

integ-distroless_istio
a08cd93ce2522fd8e3c4b7d90448186e28018f8c
link
true
/test integ-distroless_istio

integ-pilot-istiodremote_istio
a08cd93ce2522fd8e3c4b7d90448186e28018f8c
link
true
/test integ-pilot-istiodremote_istio

integ-pilot_istio
a08cd93ce2522fd8e3c4b7d90448186e28018f8c
link
true
/test integ-pilot_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

unit-tests-arm64_istio
a08cd93ce2522fd8e3c4b7d90448186e28018f8c
link
true
/test unit-tests-arm64_istio

lint_istio
a08cd93ce2522fd8e3c4b7d90448186e28018f8c
link
true
/test lint_istio

unit-tests_istio
a08cd93ce2522fd8e3c4b7d90448186e28018f8c
link
true
/test unit-tests_istio

integ-ipv6_istio
a08cd93ce2522fd8e3c4b7d90448186e28018f8c
link
true
/test integ-ipv6_istio

integ-basic-arm64_istio
a08cd93ce2522fd8e3c4b7d90448186e28018f8c
link
true
/test integ-basic-arm64_istio

integ-distroless_istio
a08cd93ce2522fd8e3c4b7d90448186e28018f8c
link
true
/test integ-distroless_istio

integ-pilot-istiodremote_istio
a08cd93ce2522fd8e3c4b7d90448186e28018f8c
link
true
/test integ-pilot-istiodremote_istio

integ-pilot_istio
a08cd93ce2522fd8e3c4b7d90448186e28018f8c
link
true
/test integ-pilot_istio

integ-cni_istio
a08cd93ce2522fd8e3c4b7d90448186e28018f8c
link
true
/test integ-cni_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

unit-tests-arm64_istio
a08cd93ce2522fd8e3c4b7d90448186e28018f8c
link
true
/test unit-tests-arm64_istio

lint_istio
a08cd93ce2522fd8e3c4b7d90448186e28018f8c
link
true
/test lint_istio

unit-tests_istio
a08cd93ce2522fd8e3c4b7d90448186e28018f8c
link
true
/test unit-tests_istio

integ-ipv6_istio
a08cd93ce2522fd8e3c4b7d90448186e28018f8c
link
true
/test integ-ipv6_istio

integ-basic-arm64_istio
a08cd93ce2522fd8e3c4b7d90448186e28018f8c
link
true
/test integ-basic-arm64_istio

integ-distroless_istio
a08cd93ce2522fd8e3c4b7d90448186e28018f8c
link
true
/test integ-distroless_istio

integ-pilot-istiodremote_istio
a08cd93ce2522fd8e3c4b7d90448186e28018f8c
link
true
/test integ-pilot-istiodremote_istio

integ-pilot_istio
a08cd93ce2522fd8e3c4b7d90448186e28018f8c
link
true
/test integ-pilot_istio

integ-cni_istio
a08cd93ce2522fd8e3c4b7d90448186e28018f8c
link
true
/test integ-cni_istio

integ-pilot-multicluster_istio
a08cd93ce2522fd8e3c4b7d90448186e28018f8c
link
true
/test integ-pilot-multicluster_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

unit-tests-arm64_istio
a08cd93ce2522fd8e3c4b7d90448186e28018f8c
link
true
/test unit-tests-arm64_istio

lint_istio
a08cd93ce2522fd8e3c4b7d90448186e28018f8c
link
true
/test lint_istio

unit-tests_istio
a08cd93ce2522fd8e3c4b7d90448186e28018f8c
link
true
/test unit-tests_istio

integ-ipv6_istio
a08cd93ce2522fd8e3c4b7d90448186e28018f8c
link
true
/test integ-ipv6_istio

integ-basic-arm64_istio
a08cd93ce2522fd8e3c4b7d90448186e28018f8c
link
true
/test integ-basic-arm64_istio

integ-distroless_istio
a08cd93ce2522fd8e3c4b7d90448186e28018f8c
link
true
/test integ-distroless_istio

integ-pilot-istiodremote_istio
a08cd93ce2522fd8e3c4b7d90448186e28018f8c
link
true
/test integ-pilot-istiodremote_istio

integ-pilot_istio
a08cd93ce2522fd8e3c4b7d90448186e28018f8c
link
true
/test integ-pilot_istio

integ-cni_istio
a08cd93ce2522fd8e3c4b7d90448186e28018f8c
link
true
/test integ-cni_istio

integ-pilot-multicluster_istio
a08cd93ce2522fd8e3c4b7d90448186e28018f8c
link
true
/test integ-pilot-multicluster_istio

integ-pilot-istiodremote-mc_istio
a08cd93ce2522fd8e3c4b7d90448186e28018f8c
link
true
/test integ-pilot-istiodremote-mc_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

unit-tests_istio
a08cd93ce2522fd8e3c4b7d90448186e28018f8c
link
true
/test unit-tests_istio

integ-ipv6_istio
a08cd93ce2522fd8e3c4b7d90448186e28018f8c
link
true
/test integ-ipv6_istio

integ-basic-arm64_istio
a08cd93ce2522fd8e3c4b7d90448186e28018f8c
link
true
/test integ-basic-arm64_istio

integ-distroless_istio
a08cd93ce2522fd8e3c4b7d90448186e28018f8c
link
true
/test integ-distroless_istio

integ-pilot-istiodremote_istio
a08cd93ce2522fd8e3c4b7d90448186e28018f8c
link
true
/test integ-pilot-istiodremote_istio

integ-pilot_istio
a08cd93ce2522fd8e3c4b7d90448186e28018f8c
link
true
/test integ-pilot_istio

integ-cni_istio
a08cd93ce2522fd8e3c4b7d90448186e28018f8c
link
true
/test integ-cni_istio

integ-pilot-multicluster_istio
a08cd93ce2522fd8e3c4b7d90448186e28018f8c
link
true
/test integ-pilot-multicluster_istio

integ-pilot-istiodremote-mc_istio
a08cd93ce2522fd8e3c4b7d90448186e28018f8c
link
true
/test integ-pilot-istiodremote-mc_istio

lint_istio
a5013964ad254c62317d12da681473bab32e00ea
link
true
/test lint_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-pilot-istiodremote_istio
a08cd93ce2522fd8e3c4b7d90448186e28018f8c
link
true
/test integ-pilot-istiodremote_istio

integ-cni_istio
a08cd93ce2522fd8e3c4b7d90448186e28018f8c
link
true
/test integ-cni_istio

integ-pilot-multicluster_istio
a08cd93ce2522fd8e3c4b7d90448186e28018f8c
link
true
/test integ-pilot-multicluster_istio

integ-basic-arm64_istio
34ac7bf9178151e68ec258bf412e32845da5120d
link
true
/test integ-basic-arm64_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-pilot-istiodremote_istio
a08cd93ce2522fd8e3c4b7d90448186e28018f8c
link
true
/test integ-pilot-istiodremote_istio

integ-cni_istio
a08cd93ce2522fd8e3c4b7d90448186e28018f8c
link
true
/test integ-cni_istio

integ-pilot-multicluster_istio
a08cd93ce2522fd8e3c4b7d90448186e28018f8c
link
true
/test integ-pilot-multicluster_istio

integ-basic-arm64_istio
34ac7bf9178151e68ec258bf412e32845da5120d
link
true
/test integ-basic-arm64_istio

integ-ipv6_istio
34ac7bf9178151e68ec258bf412e32845da5120d
link
true
/test integ-ipv6_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-pilot-istiodremote_istio
a08cd93ce2522fd8e3c4b7d90448186e28018f8c
link
true
/test integ-pilot-istiodremote_istio

integ-cni_istio
a08cd93ce2522fd8e3c4b7d90448186e28018f8c
link
true
/test integ-cni_istio

integ-pilot-multicluster_istio
a08cd93ce2522fd8e3c4b7d90448186e28018f8c
link
true
/test integ-pilot-multicluster_istio

integ-basic-arm64_istio
34ac7bf9178151e68ec258bf412e32845da5120d
link
true
/test integ-basic-arm64_istio

integ-ipv6_istio
34ac7bf9178151e68ec258bf412e32845da5120d
link
true
/test integ-ipv6_istio

integ-distroless_istio
34ac7bf9178151e68ec258bf412e32845da5120d
link
true
/test integ-distroless_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-pilot-istiodremote_istio
a08cd93ce2522fd8e3c4b7d90448186e28018f8c
link
true
/test integ-pilot-istiodremote_istio

integ-cni_istio
a08cd93ce2522fd8e3c4b7d90448186e28018f8c
link
true
/test integ-cni_istio

integ-pilot-multicluster_istio
a08cd93ce2522fd8e3c4b7d90448186e28018f8c
link
true
/test integ-pilot-multicluster_istio

integ-basic-arm64_istio
34ac7bf9178151e68ec258bf412e32845da5120d
link
true
/test integ-basic-arm64_istio

integ-ipv6_istio
34ac7bf9178151e68ec258bf412e32845da5120d
link
true
/test integ-ipv6_istio

integ-distroless_istio
34ac7bf9178151e68ec258bf412e32845da5120d
link
true
/test integ-distroless_istio

integ-pilot_istio
34ac7bf9178151e68ec258bf412e32845da5120d
link
true
/test integ-pilot_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-pilot-istiodremote_istio
a08cd93ce2522fd8e3c4b7d90448186e28018f8c
link
true
/test integ-pilot-istiodremote_istio

integ-pilot-multicluster_istio
a08cd93ce2522fd8e3c4b7d90448186e28018f8c
link
true
/test integ-pilot-multicluster_istio

integ-basic-arm64_istio
34ac7bf9178151e68ec258bf412e32845da5120d
link
true
/test integ-basic-arm64_istio

integ-ipv6_istio
34ac7bf9178151e68ec258bf412e32845da5120d
link
true
/test integ-ipv6_istio

integ-distroless_istio
34ac7bf9178151e68ec258bf412e32845da5120d
link
true
/test integ-distroless_istio

integ-pilot_istio
34ac7bf9178151e68ec258bf412e32845da5120d
link
true
/test integ-pilot_istio

integ-cni_istio
34ac7bf9178151e68ec258bf412e32845da5120d
link
true
/test integ-cni_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-pilot-multicluster_istio
a08cd93ce2522fd8e3c4b7d90448186e28018f8c
link
true
/test integ-pilot-multicluster_istio

integ-basic-arm64_istio
34ac7bf9178151e68ec258bf412e32845da5120d
link
true
/test integ-basic-arm64_istio

integ-ipv6_istio
34ac7bf9178151e68ec258bf412e32845da5120d
link
true
/test integ-ipv6_istio

integ-distroless_istio
34ac7bf9178151e68ec258bf412e32845da5120d
link
true
/test integ-distroless_istio

integ-pilot_istio
34ac7bf9178151e68ec258bf412e32845da5120d
link
true
/test integ-pilot_istio

integ-cni_istio
34ac7bf9178151e68ec258bf412e32845da5120d
link
true
/test integ-cni_istio

integ-pilot-istiodremote_istio
34ac7bf9178151e68ec258bf412e32845da5120d
link
true
/test integ-pilot-istiodremote_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-basic-arm64_istio
34ac7bf9178151e68ec258bf412e32845da5120d
link
true
/test integ-basic-arm64_istio

integ-ipv6_istio
34ac7bf9178151e68ec258bf412e32845da5120d
link
true
/test integ-ipv6_istio

integ-distroless_istio
34ac7bf9178151e68ec258bf412e32845da5120d
link
true
/test integ-distroless_istio

integ-pilot_istio
34ac7bf9178151e68ec258bf412e32845da5120d
link
true
/test integ-pilot_istio

integ-cni_istio
34ac7bf9178151e68ec258bf412e32845da5120d
link
true
/test integ-cni_istio

integ-pilot-istiodremote_istio
34ac7bf9178151e68ec258bf412e32845da5120d
link
true
/test integ-pilot-istiodremote_istio

integ-pilot-multicluster_istio
34ac7bf9178151e68ec258bf412e32845da5120d
link
true
/test integ-pilot-multicluster_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-basic-arm64_istio
34ac7bf9178151e68ec258bf412e32845da5120d
link
true
/test integ-basic-arm64_istio

integ-ipv6_istio
34ac7bf9178151e68ec258bf412e32845da5120d
link
true
/test integ-ipv6_istio

integ-distroless_istio
34ac7bf9178151e68ec258bf412e32845da5120d
link
true
/test integ-distroless_istio

integ-pilot_istio
34ac7bf9178151e68ec258bf412e32845da5120d
link
true
/test integ-pilot_istio

integ-cni_istio
34ac7bf9178151e68ec258bf412e32845da5120d
link
true
/test integ-cni_istio

integ-pilot-istiodremote_istio
34ac7bf9178151e68ec258bf412e32845da5120d
link
true
/test integ-pilot-istiodremote_istio

integ-pilot-multicluster_istio
34ac7bf9178151e68ec258bf412e32845da5120d
link
true
/test integ-pilot-multicluster_istio

integ-pilot-istiodremote-mc_istio
34ac7bf9178151e68ec258bf412e32845da5120d
link
true
/test integ-pilot-istiodremote-mc_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

IIUC, s/ignore port name/port number

/test benchmark

@howardjohn: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

lint_istio
42755466551e0e4b40cffbada5dff12593cddf64
link
true
/test lint

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

lint_istio
42755466551e0e4b40cffbada5dff12593cddf64
link
true
/test lint

gencheck_istio
42755466551e0e4b40cffbada5dff12593cddf64
link
true
/test gencheck

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn feel free to remove the hold once renamed

@howardjohn: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

release-test_istio
cd8fb20845b5dd31d9985b9c8bf30b72878914e1
link
true
/test release-test

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/retest

/cherry-pick release-1.15

@hzxuzhonghu: #40475 failed to apply on top of branch "release-1.15":
Applying: Ignore port name in domain matching entirely
Using index info to reconstruct a base tree...
M	pilot/pkg/features/pilot.go
M	pilot/pkg/networking/core/v1alpha3/gateway.go
M	pilot/pkg/networking/core/v1alpha3/httproute.go
M	pilot/pkg/networking/core/v1alpha3/httproute_test.go
M	pkg/test/util/assert/assert.go
M	tests/integration/pilot/common/routing.go
Falling back to patching base and 3-way merge...
Auto-merging tests/integration/pilot/common/routing.go
CONFLICT (add/add): Merge conflict in releasenotes/notes/ignore-port.yaml
Auto-merging releasenotes/notes/ignore-port.yaml
Auto-merging pilot/pkg/networking/core/v1alpha3/httproute_test.go
CONFLICT (content): Merge conflict in pilot/pkg/networking/core/v1alpha3/httproute_test.go
Auto-merging pilot/pkg/networking/core/v1alpha3/httproute.go
CONFLICT (content): Merge conflict in pilot/pkg/networking/core/v1alpha3/httproute.go
Auto-merging pilot/pkg/networking/core/v1alpha3/gateway.go
CONFLICT (content): Merge conflict in pilot/pkg/networking/core/v1alpha3/gateway.go
Auto-merging pilot/pkg/features/pilot.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Ignore port name in domain matching entirely
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherry-pick release-1.15

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@hzxuzhonghu: new issue created for failed cherrypick: #41880

In response to this:

/cherry-pick release-1.15

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Does this also need to be cherry-picked to 1.16?

Its in 1.16, this was merge a long time ago.


Pre-release merge for 0.2: Introduce InvalidStack exception, fixes to core events

Mainly adds work from ARXIVNG-458

Coverage decreased (-0.08%) to 93.415% when pulling b0d75e35375fe9ef4b1fffd495d8bdfc9e0cc5d9 on develop into 0f58395d7a016a1f76a6ac42ea1ebacfe95d13d1 on master.

Coverage decreased (-0.08%) to 93.415% when pulling b0d75e35375fe9ef4b1fffd495d8bdfc9e0cc5d9 on develop into 0f58395d7a016a1f76a6ac42ea1ebacfe95d13d1 on master.


When proxy is enabled but resource is on same domain as CKAN, plugin …

…throws variable reference error
Instead, set variable so it can be safely passed to the templates without throwing an exception

Fixed in the mean time, as part of ckan/ckanext-geoview#29


ExternalIPs always empty

The ExternalIPs is always empty even when a service have externalIPs;
$ kubectl get svc
NAME          TYPE           CLUSTER-IP   EXTERNAL-IP        PORT(S)                         AGE
kubernetes    ClusterIP      <IP_ADDRESS>     <none>             443/TCP                         72s
mserver       LoadBalancer   <IP_ADDRESS>   <IP_ADDRESS>,1000::1   5001:31093/TCP,5003:30150/TCP   43s
mserver-udp   LoadBalancer   <IP_ADDRESS>   <IP_ADDRESS>,1000::2   5001:31084/UDP                  43s
$  print-state
I0824 09:12:48.195326    2759 client.go:168] connecting to <IP_ADDRESS>:12090
# ------------------------------------------------------------------------
# 2021-08-24 09:12:48.210194493 +0000 UTC m=+0.024634303
#
&{Namespace:"default"  Name:"kubernetes"  Type:"ClusterIP"  IPs:{ClusterIPs:{V4:"<IP_ADDRESS>"}  ExternalIPs:{}}  Ports:{Name:"https"  Protocol:TCP  Port:443  TargetPort:6443} [IPs:{V4:"<IP_ADDRESS>"}]}
&{Namespace:"default"  Name:"mserver"  Type:"LoadBalancer"  IPs:{ClusterIPs:{V4:"<IP_ADDRESS>"}  ExternalIPs:{}}  Ports:{Name:"mconnect"  Protocol:TCP  Port:5001  NodePort:31093  TargetPort:5001}  Ports:{Name:"ctraffic"  Protocol:TCP  Port:5003  NodePort:30150  TargetPort:5003} [IPs:{V4:"<IP_ADDRESS>"}  Local:true IPs:{V4:"<IP_ADDRESS>"} IPs:{V4:"<IP_ADDRESS>"} IPs:{V4:"<IP_ADDRESS>"}]}
&{Namespace:"default"  Name:"mserver-udp"  Type:"LoadBalancer"  IPs:{ClusterIPs:{V4:"<IP_ADDRESS>"}  ExternalIPs:{}}  Ports:{Name:"mconnect-udp"  Protocol:UDP  Port:5001  NodePort:31084  TargetPort:5001} [IPs:{V4:"<IP_ADDRESS>"}  Local:true IPs:{V4:"<IP_ADDRESS>"} IPs:{V4:"<IP_ADDRESS>"} IPs:{V4:"<IP_ADDRESS>"}]}

So, regardless of backend kpng can't support external access.

Strange... I wonder what the difference is in my cluster.
The external IPs are fond in svc.Status.LoadBalancer.Ingress[i] if set by a cloud-provider or the metallb controller (or assign-lb-ip).
I made a grep and found "Ingress" only in backend/iptables.
kpng > grep -r Ingress .
./backends/iptables/service.go: for _, ing := range info.loadBalancerStatus.Ingress {
./backends/iptables/service.go: //TODO : CHECK Load Balancer Ingress IPs , service.Status.LoadBalancer.Ingress
./backends/iptables/service.go: // Obtain Load Balancer Ingress IPs
./backends/iptables/service.go: // for _, ing := range service.Status.LoadBalancer.Ingress {
./backends/iptables/service.go: //              info.loadBalancerStatus.Ingress = append(info.loadBalancerStatus.Ingress, v1.LoadBalancerIngress{IP: ip})

This is a bug.
https://github.com/kubernetes-sigs/kpng/blob/b26c64af90b6b54642d0d3ae93250d005b81cb20/jobs/kube2store/service-event-handler.go#L42
Only svc.Spec.ExternalIPs are collected, but they are actually not recommended to be used and has been subject to many discussions. Basically external addresses shall not be specified by the used in the service manifest.
The external addresses are normally taken from service.Status.LoadBalancer.Ingress which is usually set by the cloud-provider or the metallb-controller, but not by the user.
For test I made a small test;
func lbIPs(svc *v1.Service) []string {
	ips := []string{}
	for _, i := range svc.Status.LoadBalancer.Ingress {
		ips = append(ips, i.IP)
	}
	return ips
}
// ....
			ExternalIPs: localnetv1.NewIPSet(lbIPs(svc)...),

The correct way would be to concat both svc.Spec.ExternalIPs and svc.Status.LoadBalancer.Ingress into ExternalIPs.

/close
and moved to #68


Pin .python-version in uv init

Summary
I'm not convinced that the behavior is correct as-implemented. When the user passes a --python >=3.8 or we discover a requires-python from the workspace, we're currently writing that request out to .python-version. I would probably rather that we write the resolved patch version?
Closes https://github.com/astral-sh/uv/issues/6821.

I think I'd prefer that we resolve the version request, and write the major, minor, patch to .python-version. But need feedback.

Yes I think it'd be weird to echo the request — as that doesn't really have an effect in a project it just matches the constraint we infer from the requires-python definition. Let's resolve and write major / minor as you suggested.
I think we also need an opt-out --no-pin-python flag for this.

Sg.

Not patch?

Yeah I don't think we should pin to a patch version by default, since they're expected to have the same behavior and frequently vary in availability.

Yeah I don't think we should pin to a patch version by default, since they're expected to have the same behavior and frequently vary in availability.

I think that's quite normal, a lot of my .python-version files have just 3.12 these days

Added --no-pin-python, switched to minor version.


Proxy start fails with exception in monodroid

Executing proxyServer.Start() on Android  fails with exception.
This behavior is only reproducible when running the library in release mode.
The exception was traced to a file system access violation exception while writing the generated root certificate to disk cache.
Here's the relevant code in DefaultCertificateDiskCache.cs for getting the target certificate folder:
private string getRootCertificateDirectory()
{
    if (rootCertificatePath == null)
    {
        string assemblyLocation = GetType().Assembly.Location;

        // dynamically loaded assemblies returns string.Empty location
        if (assemblyLocation == string.Empty)
        {
            assemblyLocation = Assembly.GetEntryAssembly().Location;
        }

        string path = Path.GetDirectoryName(assemblyLocation);

        rootCertificatePath = path ?? throw new NullReferenceException();
    }

    return rootCertificatePath;
}

The target folder is set to be along side the assembly location.
However - this is not necessarily a writable path, as in the Android example.
Instead, I believe this folder should be used:
rootCertificatePath = Environment.GetFolderPath(Environment.SpecialFolder.ApplicationData);

You can implement you own certificate cache to prevent this.

Since filesystem APIs are quite difference for each platform (for example UWP, Xamarin iOS & Android), I don't think its appropriate for the proxy to handle each scenarios. Just implement the certificate cache interface.
https://github.com/justcoding121/Titanium-Web-Proxy/blob/master/src/Titanium.Web.Proxy/Network/ICertificateCache.cs
Your implementation won't be very different that what we have as default.
https://github.com/justcoding121/Titanium-Web-Proxy/blob/master/src/Titanium.Web.Proxy/Network/DefaultCertificateDiskCache.cs

If someone would like to add default certificate cache for each of the platforms I would be open to merge. We can use those defaults based on the RunTime.

Here's what I got.
I've tested this on Linux (Android) and UWP.
I'm not sure what's the writable folder in Mac, so it's just a guess.
On standard windows it defaults to the old mechanism (the assembly's location). I'm not sure that's a good thing...
private string getRootCertificateDirectory()
{
    if (rootCertificatePath == null)
    {
        if (RunTime.IsUwpOnWindows)
        {
            rootCertificatePath = Environment.GetFolderPath(Environment.SpecialFolder.LocalApplicationData);
        }

        else if (RunTime.IsLinux)
        {
            rootCertificatePath = Environment.GetFolderPath(Environment.SpecialFolder.ApplicationData);
        }

        else if (RunTime.IsMac)
        {
            rootCertificatePath = Environment.GetFolderPath(Environment.SpecialFolder.ApplicationData);
        }

        else
        {
            string assemblyLocation = GetType().Assembly.Location;

            // dynamically loaded assemblies returns string.Empty location
            if (assemblyLocation == string.Empty)
            {
                assemblyLocation = Assembly.GetEntryAssembly().Location;
            }

            string path = Path.GetDirectoryName(assemblyLocation);
            rootCertificatePath = path ?? throw new NullReferenceException();
        }
    }

    return rootCertificatePath;
}

Thanks. Looks simpler than I thought. I will take a look.


fix #1183: run before-hooks with locally installed gulp#4.0

gulp-4.0 changes the way tasks are registered and run internaly, so ionic-cli does not work when you install gulp 4.0. These changes will make before-hooks work again.

Please include in next release, thanks!


Updated pt_BR

Updated translation pt_BR
https://raw.githubusercontent.com/heloisatech/emulationstationBR/master/emulationstation2.po

Thanks for resolving the conflicts

Done. Thanks


MINIFI-50 - Update READMEs and adjust docs

Updating the root project README and providing READMEs for both the minifi and minifi-toolkit assemblies.
Adjusting needed LICENSE and NOTICE files.
Adding System Admin Guide to docs folder in generated minifi-assembly.
Adding KEYS file to repository.

@JPercivall made changes as per your feedback, but mulling things over a bit more, I'm pretty sure the LICENSE and NOTICE for the assembly as it stands is currently deficient.  Will issue another commit with just those items.

@JPercivall updated the NOTICE and LICENSE files for the assembly as well.  There were a few tricky items to hunt down given that some of our artifacts still have APIs to those projects even if not actively used.

+1
Looks good, I will merge it in.


extends Resource instead of BlockCollection

fixed references to "BlockCollection" in refactor

This change is

Review status: 0 of 3 files reviewed at latest revision, all discussions resolved.

Comments from Reviewable


Small refactor for different base distros

Still a lot more to do here, but this should help me stop conflicting with @toabctl's refactors against my local branch ;-)

@jhesketh now there is a merge branch commit. Can we try to avoid that to have a nice git history?

I was being lazy using the github UI, but will rebase next time.


Implement fields_for

Done commenting. I think this should be really helpful once it's in :D

Just had one comment on the documentation. The rest looks awesome!


Implement methods for submitting SPARQL queries

Should use async HTTP via http4s + ZIO
Define SPARQL endpoint API and decoder with Tapir
Multiple result options (different methods) for convenience:

direct Jena ResultSet
automatic mapping to a case class using FromQuerySolution typeclass (https://github.com/phenoscape/sparql-utils)

Similar design here but that is built on different libraries (akka-http + Future).

direct Jena ResultSet

Implemented in #27

Completed with #42.


fix the formatting of input filenames

Fix the formatting of input filenames

global_parameter
add_chr step: use "genoFile" instead of filename
qc_3 step: write the output to "${_output[0]:n}.stdout\n"

I'll close this PR because as discusesd the first two changes need further work. The last change was valid and @hsun3163 adopted it in his other PR.


About the Model parameters updating in OmniglotNet Class

Thanks for your good implementation of MAML, however, I think that maybe use state_dict() and load_stat_dict() is much faster than modifying the weights (in omniglot_net.py 43), can I first deepcopy the net parameters(state_dict()) and use the fast weights (also use a optimizer to update), then load the origin parameters back to update the meta learner? Thanks.

I also wanted to do that ，but the grad can not backword and parameters cannot update.   is the most important that to share grad between two models??


AssertStackManipulationsAreSameTest.java:31-31: Improve test coverage and mutation...

The puzzle 47-88d8b95b (from #47) in atom-codegen/src/test/java/oo/atom/codegen/bytebuddy/smt/AssertStackManipulationsAreSameTest.java (lines 31-31) has to be resolved: "Improve test coverage and mutation coverage for {@link AssertStackManipulationsAreSame}"
The puzzle was created by Kapralov Sergey on 29-Sep-17.
Estimate: 15 minutes, role: IMP.
If you have any technical questions, don't ask me, submit new tickets instead. The task will be "done" when the problem is fixed and the text of the puzzle is removed from the source code. Here is more about PDD and about me.

@skapral please pay attention to this new issue.

AssertStackManipulationsAreSameTest was removed. Closing.


Render Checkboxes using more common Markdown style, implements #875

In addition this changes the check list UI. Instead of splitting the description into a description and check list part, we treat each paragraph either as text paragraph or a checkable item. Checkable items and text items can be converted into each other.

I have tested it, it's a nice improvement. Thanks! :+1:


Feature Request: A better hex-string converter for the registry editor.

Feature Request: A better hex-string converter for the registry editor.
Hi. I really like this website tool.
I found that it is the only tool capable of doing the string to hex and hex to string conversions that I need for the Windows Registry Editor.
Because it allows queuing up multiple conversions.
Doing this I can now get the conversions I need from this link:
https://gchq.github.io/CyberChef/#recipe=To_Hex('Space')From_Hex('Space')Decode_text('UTF-8 (65001)')Encode_text(%27UTF16LE%20(1200)%27)To_Hex(%27Comma%27)
(This turns strings into a hex format usable with the windows registry editor.)
And this turns it from the above hex format into the string format:
https://gchq.github.io/CyberChef/#recipe=From_Hex('Comma')Decode_text('UTF16LE (1200)')Encode_text(%27UTF-8%20(65001)%27)To_Hex(%27Space%27)From_Hex(%27Auto%27)
The only problem though, is that this adds the new lines with the newline (\n) escape character whereas they must be carriagereturn+newline (\r\n) for the windows registry editor.

So, I would like an option to switch to using \r\n as new lines instead of only \n
Because of this, I have to correct the new lines manually any time I make new lines.

The windows registry editor wraps these hex values by placing a " \ " syntax
(this must not exceed 80 characters in length per line)
This is optional but it is how the Windows registry works. So, it would be nice if we could have an option to warp at 80 characters with the " \ " syntax. I believe this can be implemented programmatically.

The windows registry also does not work with a file encoding that is without BOM. The file encoding in this case can simply be made BOM by putting in a FF,FE at the start the conversion.

Example
So for example, it would look like this:
"this is a string"
FF,FE,74,00,68,00,69,00,73,00,20,00,69,00,73,00,20,00,61,00,20,00,73,00,74,00,72,00,69,00,6e,00,67,00
I don't think it would be hard to add an option to put the FF,FE characters at the start.
There are already converters and minifiers that is set to work with various different areas of computers in this tool. So I would like to ask that a "windows registry hex-string converter" be added to the "Other" section with the specified 3 changes implemented. You would be helping people who work with the windows registry IMMENSELY 👍
I am willing to provide any other information regarding this issue.
Thanks for your consideration!

Hi @SalviaSage, perhaps this recipe will help you:
https://gchq.github.io/CyberChef/#recipe=Find_/_Replace({'option':'Regex','string':'\\n'},'\\r\\n',true,false,true)Encode_text('UTF16LE (1200)')Find_/_Replace({'option':'Regex','string':'^'},'\\xff\\xfe',false,false,false)To_Hex('Comma')&input=dGhpcyBpcyBhIHN0cmluZwp3aXRoIGEgbGluZSBicmVhaw

oh wow. That is really nice.
Thanks for that.

Hi.
I also have the link for the reverse operation where the hex values get converted to the string.
This also needs the \r\n line breaks.
https://gchq.github.io/CyberChef/#recipe=To_Hex('Space')From_Hex('Space')Decode_text('UTF-8 (65001)')Encode_text('UTF16LE (1200)')To_Hex('Comma')
I don't know how to adapt your link into this configuration.
Can you help me please?
Thanks.

Dear @n1474335
I fear this link you have provided me is no longer 'baking'.
I tried restarting my computer and opening the link with 2 web browsers and although the page loads and the input section works, the output section is stuck in a spinning animation and it says 'Loading CharEnc module'.
It never loads, so I can not use this tool and thus can not proceed with my programming now.
Can you please check this link to see if it works for you or others and fix this link if necessary, other areas are 'baking' fine.

sal

Okay.
This no longer works.
It outputs the following syntax error:
Encode text - Error in https://gchq.github.io/CyberChef/modules/Encodings.js on line 27.Message: Unrecognized CP: undefined
Such a shame, because this is a very useful conversion for the project I work on.
I will try to get the converter working again but, in the meantime, perhaps you can
restore it for me.
I don't know if I can fix it on my own.
Thanks.

https://gchq.github.io/CyberChef/#recipe=Find_/_Replace({'option':'Regex','string':'\\n'},'\\r\\n',true,false,true,false)Encode_text('UTF-16BE (1201)')Find_/_Replace({'option':'Regex','string':'^'},'\\xff\\xfe',false,false,false,false)To_Hex('Comma')&input=dGhpcyBpcyBhIHN0cmluZwp3aXRoIGEgbGluZSBicmVhaw

Thanks for the reply, however I managed to fix it on my own.


Not compatible with Django REST Framework 3.0

post_save method doesn't exist anymore. Also, 'required' attribute is deprecated.
All changes in version 3:
http://www.django-rest-framework.org/topics/3.0-announcement/

@Zeioth it's probably fixed here https://github.com/sunscrapers/djoser/commit/1cb63683572139e52d4819417852eb3c730cbf75
We are using following approach:
class View(generics.CreateAPIView):

    def post_save(self, obj, created=False):
        (...)

    def perform_create(self, serializer):
        instance = serializer.save()
        self.post_save(obj=instance, created=True)

It's not the best, but it works.


windows_share: Improve path comparison to prevent convering on each run

Description
Fixes issue where updating a share will cause the share to be deleted
but not re-created until chef is next run, and for chef to fail the run
Signed-off-by: Jason Field<EMAIL_ADDRESS>Issues Resolved
Share cannot update a path without delete and recreate, however logic will only delete and not recreate currently
Check List

[ ] New functionality includes tests
[ ] All tests pass
[ ] RELEASE_NOTES.md has been updated if required (not required for bugfixes, required for API changes)
[ ] All commits have been signed-off for the Developer Certificate of Origin. See https://github.com/chef/chef/blob/master/CONTRIBUTING.md#developer-certification-of-origin-dco

Can someone let me know where I should put the changed inspec tests please?

Looks good, but you have a pretty minor chefstyle fix that needs to be done on the log message.

You'll want to include require "chef/util/path_helper" as well


Ensure protein and X are "C" order if dense

I already did this if using a layer, but we should always check whenever it's a dense numpy array.
In the case of proteins, if it's a dataframe we may need to overwrite the obsm with a new dataframe.

If sparse, let's make it csr .tocsr() I believe

Also @galenxing, in validate in totalVI we need to check if protein counts are nonnegative integers


Build failure with leptonica 1.83

Leptonica 1.83 moved a number of struct definitions into "private" headers, notably Pix and Box et al.
This causes a build failure:
src/TessTools.cpp:147:25: error: member access into incomplete type 'PIX' (aka 'Pix')
   l_uint32 *datas = pixs->data;
...

To address this, an extra import of <leptonica/pix_internal.h> needs to be added to src/TessTools.h.
On top of this, it looks like this version got rid of the library's lept alias, so references to -llept in qt-box-editor.pro need to be switched to -lleptonica.

qt-box-editor was IMO relevant for tesseract 3.x training (legacy engine) and it does not provide any value for the current tesseract version...
So what is the value if it is possible to build with the latest version of leptonica&tesseract?

It is not problem to include patch here, I just wander if really people are actively using this.

LSTM engine does not need to be trained from scratch (legacy engine has to). E.g. you can train and extend only problems.
IMO LSTM training is (could be) faster as you do not need to take care about bounding boxes of letters and training based on tutorials like this seem to be pretty easy.
Anyway I made requested changes of QTB code.

fixed.


Improve SDS service at Citadel agent

Bug description
Currently there are some improvements required at Citadel agent.

Make sure only one push is done per SDS request. We don't check push numbers for each SDS request, and we need to avoid multiple pushes.
Handle nonce in SDS request properly. This field is ignored by Citadel agent, only version info and token are checked.

Affected product area (please put an X in all that apply)
[ ] Configuration Infrastructure
[ ] Docs
[ ] Installation
[ ] Networking
[ ] Performance and Scalability
[ ] Policies and Telemetry
[X] Security
[ ] Test and Release
[ ] User Experience
[ ] Developer Infrastructure

cc @quanjielin @myidpt


Feature/difficulty

Continuation of #121 with a few final changes.

@gratimax can you fix the license violations?

I thought I did and pushed it up...

Fixed by 181f964a8ece7027


Update issue templates

We have a lot of bugs reported which has a poor description, it does not help us to reproduce and fix it quickly.
So I think the issue template should improve the situation :)

I think that's a great idea, but I believe it needs to be short - otherwise users might end up ignoring it. Personally, I like https://raw.githubusercontent.com/facebook/jest/master/.github/ISSUE_TEMPLATE/bug.md so I've shortened our template to be similar to that. What do you think?
Also pinging @guyonroche

why not also add a PR template ?😃

@Alanscut yeach it;s great idea:)

@alubbe for me the important thing is to give me a test which will fail before fixation. We have a lot of bugs reported, that we need a lot of time to inspect and analyze them.
Test code for an issue will give us:
set the quality of issues to the highest level
reduce the fixation time cost
encourage to creating new PRs (if someone makes a test it will probably make a fixation :) )
In other side, You have right, the short template should increase bug reports amount.
So I have shared my thoughts with you, and I'm really open to change my vision to something else.
@alubbe @Alanscut what do you think?

I completely agree, that's why I tried to find a 'middle-ground' approach, that both looks short, so that it actually gets read instead of deleted, but still wants a code example. That's not as much as a fully blown test case, but it's close enough. Here's my suggestion:
## Steps To Reproduce

<!-- The exact steps required to reproduce the issue, ideally with a code example and an expectation (like in a unit test) -->

```javascript
const wb = new ExcelJS.Workbook();
const ws = wb.addWorksheet('XYZ');
ws.getCell('A1').value = 7;
expect(ws.getCell('A1').value).to.equal(7);

@Alanscut this PR adds more templates: https://github.com/exceljs/exceljs/pull/1128


Setting create_vpc=false, still creates module.vpc.aws_vpc.this[0]

Description
On my first attempt to use the module, I ended up with two VPCs created. The TF resources were:

module.my_vpc.aws_vpc.this[0] and
module.vpc.aws_vpc.this[0]

Attempting to get rid of the second, I started editing my configuration, but no matter what I do, it still gets created
Looked at the module's code, and what I fail to understand basically is why
count = local.create_vpc ? 1 : 0  isn't working in the resource "aws_vpc" "this" block, despite setting create_vpc to false
Same issue with manage_default_network_acl, manage_default_route_table and manage_default_security_group (see code below)
And as a follow-up, even if I could achieve not creating any VPCs, if I actually want to create my VPC, am I stuck with an extra one created by module.vpc.aws_vpc.this[0], no matter what?

[x] ✋ I have searched the open/closed issues and my issue is not listed.

Versions

Module version [Required]: 5.16.0

Terraform version:  1.9.8

Provider version(s): registry.terraform.io/hashicorp/aws v5.78.0

Reproduction Code [Required]
module "my_vpc" {
  source = "terraform-aws-modules/vpc/aws"

  create_vpc = false # default: true

  name = "my_vpc"
  cidr = "<IP_ADDRESS>/16"

  azs             = ["eu-central-1a", "eu-central-1b", "eu-central-1c"]
  private_subnets = ["<IP_ADDRESS>/24"]
  public_subnets  = ["<IP_ADDRESS>/24"]

  enable_nat_gateway  = false
  enable_vpn_gateway = false

  create_igw = false
  create_private_nat_gateway_route = false

  manage_default_network_acl = false
  manage_default_security_group = false
  manage_default_route_table = false

  tags = {
    Terraform = "true"
    Environment = "my_env"
  }
}

Expected behavior
Plan output stating that configuration matches the state. Pretty much nothing to be planned to be created.
Actual behavior
Following resources get created:

module.vpc.aws_default_network_acl.this[0]
module.vpc.aws_default_route_table.default[0]
module.vpc.aws_default_security_group.this[0]
module.vpc.aws_vpc.this[0]

Nevermind me, was double declaring the module, both in main.tf as my_vpc and in my versions.tf as vpc. 😭


it is giving strange error

File "/home/ubuntu/segserver/venv/bin/TotalSegmentator", line 14, in
from totalsegmentator.preview import generate_preview
File "/home/ubuntu/segserver/venv/lib/python3.10/site-packages/totalsegmentator/preview.py", line 11, in
from fury import window, actor, ui, io, utils
File "/home/ubuntu/segserver/venv/lib/python3.10/site-packages/fury/window.py", line 12, in
from fury.interactor import CustomInteractorStyle
File "/home/ubuntu/segserver/venv/lib/python3.10/site-packages/fury/interactor.py", line 7, in
from fury.lib import (Command, InteractorStyleUser, InteractorStyleImage,
File "/home/ubuntu/segserver/venv/lib/python3.10/site-packages/fury/lib.py", line 7, in
import vtkmodules.vtkDomainsChemistryOpenGL2 as dcovtk
ImportError: libGL.so.1: cannot open shared object file: No such file or directory

Could you show what pip list is printing out?
Moreover, does it work if you do not use the option --preview?

yes sir
Send2Trash                    1.8.0
service-identity              18.1.0
setuptools                    63.4.1
SimpleITK                     2.0.2
sip                           4.19.13
six                           1.16.0
sklearn                       0.0.post1
smart-open                    5.2.1
sniffio                       1.2.0
snowballstemmer               2.2.0
sortedcollections             2.1.0
sortedcontainers              2.4.0
soupsieve                     2.3.1
Sphinx                        5.0.2
sphinxcontrib-applehelp       1.0.2
sphinxcontrib-devhelp         1.0.2
sphinxcontrib-htmlhelp        2.0.0
sphinxcontrib-jsmath          1.0.1
sphinxcontrib-qthelp          1.0.3
sphinxcontrib-serializinghtml 1.1.5
spyder                        5.2.2
spyder-kernels                2.2.1
SQLAlchemy                    1.4.39
sqlparse                      0.4.3
statsmodels                   0.13.2
sympy                         1.10.1
tables                        3.6.1
tabulate                      0.8.10
TBB                           0.2
tblib                         1.7.0
tenacity                      8.0.1
terminado                     0.13.1
testpath                      0.6.0
text-unidecode                1.3
textdistance                  4.2.1
threadpoolctl                 2.2.0
three-merge                   0.1.1
tifffile                      2021.7.2
tinycss                       0.4
tldextract                    3.2.0
toml                          0.10.2
tomli                         2.0.1
tomlkit                       0.11.1
toolz                         0.11.2
torch                         1.13.1
torchaudio                    0.13.1
torchvision                   0.14.1
tornado                       6.1
TotalSegmentator              1.4.0

I tried even TotalSegmentator==1.5.2 and TotalSegmentator==1.5
It was giving same error
It was working fine someday back

I am not using --preview tag
I am using "TotalSegmentator -i ct.nii.gz -o . --fast" only

fury is not in your list of installed packages. Therefore it does not work I guess.

I resolved it @wasserth
thanks.
I had used
sudo apt-get install ffmpeg libsm6 libxext6  -y


remove kanji from README

Almost part of README.md is written in English. But "以上" is not. I changed it.

Oh, I did not notice.
Thank you for your contribution!


Auto create table builder by fields in struct

type User struct{
  ID int `db:"id" sqldb:"int(11)"`
  Login string `db:"login" sqldb:"varchar(255)"`
}

ctb := sqlbuilder.NewCreateTableBuilder()
// compile struct to ctb obj
ctb = ctb.IfNotExists()
println(ctb.String())
// CREATE TABLE IF NOT EXISTS ...

I considered this feature in the past. I didn't implement it due to following reasons.

Column definitions could be quite long, e.g. BIGINT(20) NOT NULL AUTO_INCREMENT PRIMARY KEY COMMENT "comments..." so it's not easy to read and maintain in field tag. Simpleness and readability is the top design goal in this package.
There is no way to represent keys in field tag. We still need to call CreateTableBuilder#Define to define keys. If so, I prefer to define all table columns by Define as it's clearer.

Please let me know your thought.

My suggestion is to use the following rules:

When the field ends with the suffix  _id automatically associate this with the table
The id field is always AI PRIMARY
The type of the string field is always varchar (255)
Field int - always int (255)

This will make it possible for simple projects to automatically generate tables. For more complex projects, it makes sense to use more complex libraries. Use of this feature is at the discretion of the user.

The suggested rules are not well defined and extensible. They are project-specific features which work only for quite a limit number of projects.
As all rules can be implemented outside this package, e.g. call Define after analyzing struct field tags, I still suggest "won't fix" in this package and do it separately. It's welcome to create a separate package for this feature. I can list the package in the README as an extension for this package.

This is a good idea.


Unable to download backbone

I downloaded the backbone through the link and cannot proceed with the download due to permission reasons
The error display is as follows：
wget https://penzhanwu2bbs.blob.core.windows.net/data/GLIPv1_Open/models/swin_large_patch4_window12_384_22k.pth -O swin_large_patch4_window12_384_22k.pth
wget : PublicAccessNotPermittedPublic access is not permitted on this storage account. RequestId:54b491d5-a01e-0070-1f81-cb068d000000 Time:2023-08-10T11:57:32.7421018Z

I think you can download from the original swin transformer repo. I think this should be the same checkpoint as the one provided by GLIP.


Minor modifications

Hello,
Thank you @iKintosh for providing your code.
I'm currently trying to use your layer in my code (with torch 1.1.0) and I ran into some minor problems
I think the following lines should be updated in your code but I'm not sure so I decided to just point them out here :
1- Line 19 -> padding_mode should be added
super(GaborSmallConv2d, self).__init__(in_channels, out_channels, kernel_size, stride, padding, dilation, False, _pair(0), groups, bias, padding_mode='zeros')

2- Line 24 -> .type(torch.Tensor) should be added to make learnable parameter floating
self.theta = nn.Parameter(0.628*torch.randint(0, 6, (out_channels, in_channels)).type(torch.Tensor))

3- Line 62 -> same as #1
super(GaborConv2d, self).__init__(in_channels, out_channels, kernel_size, stride, padding, dilation, False, _pair(0), groups, bias, padding_mode='zeros')

4- Line 72 -> second parameter for meshgrid should be self.x0-1 not self.x0 (??)
y, x = torch.meshgrid([torch.linspace(-self.x0+1, self.x0, self.kernel_size[0]), torch.linspace(-self.y0+1, self.y0, self.kernel_size[1])])

5- Line 105 -> same as #1
super(GaborCurvedConv2d, self).__init__(in_channels, out_channels, kernel_size, stride, padding, dilation, False, _pair(0), groups, bias, padding_mode='zeros')

Thank you. You're right.
1,3,5 makes Gabor Layers not compatible with pytorch 1.1.0 now.
2 -- need to see if it's true, due to the fact that I multiply it by 0.628 it may be float already.
4 -- yes, I'm sure. Python does not include last index in arrays.

Resolved issue by adding GaborLayer_1.1.0.py file, which is compatible with Pytorch 1.1.0.
Old file is now called GaborLayer_1.0.0.py and is compatible with Pytorch <=0.4.0, >=1.0.0
https://github.com/iKintosh/GaborNet/blob/15904f35a194b0aa83053f0afc20eedb1691269f/GaborLayers_1.1.0.py#L55-L56

In addition, turns out that #2 is not an issue. self.theta is float.


Fix FlowControlHandler's autoreading breakage.

Fix FlowControlHandler's autoreading breakage
Motivation:
FlowControlHandler breaks auto-reading (i.e. the channel does not auto-read even though its config has auto-read set to true). This happens when auto-read is turned on when the queue is not empty. The reason is that FlowControlHandler.read() does not pass the call to the ChannelHandlerContext if at least one message has been dequeued. This is a problem when FlowControlHandler.read() has been called as a result of auto-read having been turned on (DefaultChannelConfig.setAutoRead() calling read() in case of autoRead && !oldAutoRead).
Modifications:
Always pass the call to read() down the pipeline.
Result:
Auto-reading works, regardless of the handler's queue state in the moment it is turned on.
Fixes #12445

Well, the Bug report and PR description can be different and as per https://netty.io/wiki/developer-guide.html, you must add a description.

@gbrdead thanks this looks good. Can you please sign our ICLA and let me know once done: https://netty.io/s/icla ?

@normanmaurer I just signed the ICLA.

Thanks!


You are using withImages as an option for configuring withSass plugin. They are two separate plugins. You should call use them this way:

I use bottom config, but no work
const withSass = require('@zeit/next-sass');
const withImages = require('next-images');
module.exports = withImages(
  withSass({
    sassLoaderOptions: {
      includePaths: ['./styles/']
    },
    cssModules: true,
    cssLoaderOptions: {
      importLoaders: 1,
      localIdentName: '[local]___[hash:base64:5]'
    }
  })
);

scss文件中
background<EMAIL_ADDRESS>top center;

Originally posted by @arefaslani in https://github.com/twopluszero/next-images/issues/10#issuecomment-426269041

@weeeziyuanli Please also try this package to compose plugins:
https://www.npmjs.com/package/next-compose-plugins


Are there any plans to drop support for older versions of Ruby?

This gem currently supports Ruby 2.0 and above.
https://github.com/rails/thor/blob/376e141adb594f3146c57e98151b97a20c93c484/thor.gemspec#L25
https://github.com/rails/thor/blob/376e141adb594f3146c57e98151b97a20c93c484/.github/workflows/tests.yml#L9
At this time, the officially supported Ruby version is 2.7 or later.
(2.7 will soon be EOL as well.)
https://www.ruby-lang.org/en/downloads/branches/
I am working on a PR for another issue, but it is not compatible with older Ruby.
https://github.com/rails/thor/pull/812#issuecomment-1448346323
Thank you.

Now that bundler dropped support to old Rubies we can as well. I'll do it

Oh, it depended on the support status of bundler.
Thank you very much!


feat: implemented i18n basic example, it's just for see how this work…

… and how is the architecture
at this moment I just create i18n for EN and PT-BR, but if necessary for now I can create more, and I just put i18n in the button (save, share and clear), because I don't see other place to do that, but if you have more thing I can do, if you have any one question I'm here :smile:
" Sorry for my bad English "

Some screenshot about how this is working in deploy
EN

PT-BR

Thanks for the PR @AbnerSilvaBarbosa!
I included some texts in the attributes of some HTML tags to
improve accessibility, like title=''. I think this needs to be translated too, and some modal texts, like Pomodoro Config.

You want I translate, too, the title of themes ? Like :

You want I translate, too, the title of themes ? Like :

Yes


rust linters should highlight part of line that contains error

The output from cargo check contains a number of spans that indicate exactly where the error was found, including the start and end column for the line. It'd be really neat if that segment of the line with the error was highlighted (I believe neomake recently got support for this, and does it by underlining the characters in question):
{
  "message": {
    "..."
    "spans": [
      {
        "byte_end": 54,
        "byte_start": 52,
        "column_end": 23,
        "column_start": 21,
        "expansion": null,
        "file_name": "src/main.rs",
        "is_primary": true,
        "label": "expected bool, found integral variable",
        "line_end": 4,
        "line_start": 4,
        "suggested_replacement": null,
        "text": [
          {
            "highlight_end": 23,
            "highlight_start": 21,
            "text": "    let foo: bool = 42;"
          }
        ]
      }
    ]
  },
  "..."
  }
}

This shouldn't be hard to accomplish. An end_col attribute is supported for the loclist items for setting the column where the highlight should end. Extract the information from the JSON message, add some tests, and that should do it.


电脑浏览器输入密码时重叠

Expected Behavior
Actual Behavior

Steps to Reproduce the Problem

Specifications
(The version of the project, operating system, hardware etc.)

浏览器型号？


beta update

Beta Update

https://github.com/kodadot/nft-gallery/pull/10023
https://github.com/kodadot/nft-gallery/pull/10015
https://github.com/kodadot/nft-gallery/pull/10013
https://github.com/kodadot/nft-gallery/pull/10012
https://github.com/kodadot/nft-gallery/pull/10010
https://github.com/kodadot/nft-gallery/pull/10003
https://github.com/kodadot/nft-gallery/pull/9994
https://github.com/kodadot/nft-gallery/pull/9993
https://github.com/kodadot/nft-gallery/pull/9991
https://github.com/kodadot/nft-gallery/pull/9990
https://github.com/kodadot/nft-gallery/pull/9983
https://github.com/kodadot/nft-gallery/pull/9977
https://github.com/kodadot/nft-gallery/pull/9970
https://github.com/kodadot/nft-gallery/pull/9969
https://github.com/kodadot/nft-gallery/pull/9966
https://github.com/kodadot/nft-gallery/pull/9964
https://github.com/kodadot/nft-gallery/pull/9960
https://github.com/kodadot/nft-gallery/pull/9959
https://github.com/kodadot/nft-gallery/pull/9956
https://github.com/kodadot/nft-gallery/pull/9955
https://github.com/kodadot/nft-gallery/pull/9953
https://github.com/kodadot/nft-gallery/pull/9952
https://github.com/kodadot/nft-gallery/pull/9948
https://github.com/kodadot/nft-gallery/pull/9946
https://github.com/kodadot/nft-gallery/pull/9945
https://github.com/kodadot/nft-gallery/pull/9944
https://github.com/kodadot/nft-gallery/pull/9942
https://github.com/kodadot/nft-gallery/pull/9938
https://github.com/kodadot/nft-gallery/pull/9936
https://github.com/kodadot/nft-gallery/pull/9934

17:58:00.601 | Detected the following tools from environment<EMAIL_ADDRESS><EMAIL_ADDRESS>-- | --
17:58:00.602 | Installing nodejs 20.5.1
17:58:00.675 | nodejs 20.5.1 is already installed
17:58:01.382 | Preparing<EMAIL_ADDRESS>for immediate activation...
17:58:03.814 | Installing project dependencies: pnpm install
17:58:04.515 | Scope: all 3 workspace projects
17:58:04.624 | Lockfile is up to date, resolution step is skipped
17:58:04.696 | ERR_PNPM_UNSUPPORTED_ENGINE  Unsupported environment (bad pnpm and/or Node.js version)
17:58:04.696 |
17:58:04.696 | Your Node version is incompatible with "/eslint/9.0.0".
17:58:04.696 |
17:58:04.697 | Expected version: ^18.18.0 \|\| ^20.9.0 \|\| >=21.1.0
17:58:04.697 | Got: v20.5.1

Can please someone from @kodadot/internal-dev check?

17:58:00.601 | Detected the following tools from environment<EMAIL_ADDRESS><EMAIL_ADDRESS>-- | --
17:58:00.602 | Installing nodejs 20.5.1
17:58:00.675 | nodejs 20.5.1 is already installed
17:58:01.382 | Preparing<EMAIL_ADDRESS>for immediate activation...
17:58:03.814 | Installing project dependencies: pnpm install
17:58:04.515 | Scope: all 3 workspace projects
17:58:04.624 | Lockfile is up to date, resolution step is skipped
17:58:04.696 | ERR_PNPM_UNSUPPORTED_ENGINE  Unsupported environment (bad pnpm and/or Node.js version)
17:58:04.696 |
17:58:04.696 | Your Node version is incompatible with "/eslint/9.0.0".
17:58:04.696 |
17:58:04.697 | Expected version: ^18.18.0 \|\| ^20.9.0 \|\| >=21.1.0
17:58:04.697 | Got: v20.5.1

Fixed here https://github.com/kodadot/nft-gallery/pull/10029 Let's merge it and see.

Fix is a magic keyword
![Screenshot 2024-04-09 at 13 44 17](https://github.com/kodadot/nft-
gallery/assets/22471030/07e035e6-3351-4a76-a258-0044435236c8)

Thanks for the fix @Jarsen136


Improve data in hotspot list

This can merge, although I think the hotspot list item is getting cluttered, we'll probably want a design pass on it. Maybe need to go to 3 lines?

nice 👍  yeah a design pass on list item subtitles would be great as we use the list items everywhere and the subtitles / variable width columns is a pretty finicky UI challenge
cc @PeterMain  if you have a chance to look at this, but no rush, screenshot for context:


New release

First of all thanks a lot! docformatter is a great tool.
Can the new version of docformatter be released, I'm particularly very interested in #44.
Thanks!

It has been almost one year since the last release. Is there any plan to have a new release?

Sure:
https://pypi.org/project/docformatter/1.4/


Show more than 3 values

Hello,
Thanks for putting out such a great work. I'd like to display about 10 items (instead of 3) at once on the picker.  Please kindly advise on how to implement that. I am using Java. Thank you.

Hi,
I'm not sure to understand what you're trying to achieve. Could you please provide me more details? A basic image would be even better

It takes a number of items equals to maxItems so yes it's possible. But I thought they was more behind the question


Improve contribution documentation

Fixes #91

I am still not sure on the poetry setup, we can make virtual environment and then ask user to switch IDE interpreter to the one from virtual environment. The issue is that for me (windows on this machine) poetry is crashing within venv, while working normally with pipx.


Texture packer

First PR for the initialization of a Texture Packer
TODO:
Enable the Power2 Layout and~Column Count Layout modes.
Enable the Extend Padding and Color Padding modes.
Add the ability to copy the content of a DynamicTextures instead of just Textures.
Create Function for Merging Similar Materials after compilation. -> this might be better to be left to the user.
Start Implementing PBR channels.
Export Method
Dispose Method
Load from JSON Method
Public method to update mesh lists to frame assignments
Finish Comments
Delete all Console.logs
Check spacing between all operators
Documentation
Example Scenes (Usage, Export, Load)
Performance Comparison Scene
What's New

I didn't mean to start a review...

For sure I'll fix that if get back to the house tonight.

Something odd happend to my last commit, things I did were not propigated over.  Sorry to make you review that last commit, it was not correct.
I will resubmit the correct one ASAP.

Still need to do the return after resolve then that should be it.  I'll do that before I go to bed tonight.

Congrats buddy!!!
Now last step is to provide examples in the doc :)


Add no-commit-to-branch pre-commit hook

Change Summary
Overview
This PR adds the no-commit-to-branch pre-commit-hook to prevent direct commits to the main and dev branches.
Updated Files

.pre-commit-config.yaml

Updated pre-commit config file to add the no-commit-to-branch check

@all-contributors please add @greglucas for review


Please lock posts older than 12 months automatically.

Would make my task as moderator a bit easier.

I don't like the prohibition some forums have against reviving old threads because I'd prefer to have all information on a specific topic collected in a single place rather than split into multiple threads.
There may be some exceptions where an old topic has become obsolete due to developments made since the last post in which case it would be better to start a new thread but I think that's a relatively rare occurrence.
I guess it would be helpful if you explained exactly how doing this would make it easier on the moderators.

Today several new visitors have highjacked an old thread and asked for help. happens on daily basis, (especially when new school assignments are out ?)
The requests for help varied from just "HELP!" to a slightly better description.
I conclude that these posts are only loosely connected to the existing thread.
So I split off the new question from the old topic.
(sometimes I get a report sometimes I see them first)
If someone has a problem, he/she should describe it him/herself and add a reference to the old thread(s) as look alikes of his/her problem. Often old threads are solved (yes that is an assumption ) so if they have the same problem they could use the same solution. If the problem is different start your own thread.
Hijacking someone elses thread will still happen, but less. So as a moderator I need to split less threads on a day. That gives me more time to do fun stuff.

Better make it posts older than 6 months

and another one

And another one

sigh

Leave them open.
I have found info that has helped issues and its nice to be able to thank the originator and or add additional information.
Hijacks should be reported to mods (cough) and mods should simply split the hijack / spam / whatever.

Splitting is not allways simple ...
For me the simplest is just to leave it as it is,  because... why split it as it is related?

A lot of hijacks are not the same topic. But I agree that should it be relevant then leave it alone


More suggestions for the "Spyder 3" icon theme

Discussed with @SylvainCorlay in person:
In Preferences:

[x] Use a keyboard icon for Keyboard shortcuts entry
[x] Use a palette icon for Syntax coloring
[x] Use the Python icon for Console
[x] Use question-circle for the Object Inspector

Other suggestions:

Add a menu entry to our main contextual menu so that people can decide the size of icons in toolbars. Suggested options: small: 16x16, medium: 24x24, large: 32x32, big: 48x48.
Add the possibility to turn off hinting in qtawesome for Linux.

I moved the remaining tasks to issue #2490, to have everything in once place.


_cargo: Add cargo package completion

Continuation of #7060
r? @ehuss

Ran on cargo repository:
% cargo update -p=<tab>
Completing packages
atty                  clap                  curl                  flate2                glob                  jobserver             log                   openssl               semver                strip-ansi-escapes    unicode-width
bufstream             core-foundation       curl-sys              fs2                   hex                   lazy_static           memchr                pretty_env_logger     serde                 tar                   url
byteorder             crates-io             env_logger            fwdansi               home                  lazycell              miow                  rustc-workspace-hack  serde_ignored         tempfile              url_serde
bytesize              crossbeam-utils       failure               git2                  ignore                libc                  num_cpus              rustfix               serde_json            termcolor             walkdir
cargo-test-macro      crypto-hash           filetime              git2-curl             im-rc                 libgit2-sys           opener                same-file             shell-escape          toml                  winapi

Ping @ehuss

This seems kinda buggy.  For example, the completion includes backslashes and whitespace sometimes.
Also, reading the manifest is a poor way to find the valid values for -p.
I personally would prefer to avoid spending any time enhancing these completion files (anything beyond trivial changes) and wait for #6645.  If you want to help with #6645, that would be appreciated!  The approach for that will be substantially different, using rust code to drive the completions which should be much easier to implement, test, etc.

Could you give an example how is this bugged?

Doing completion in cargo's own repo: > cargo build -p=clap\  .
This is on macOS: zsh 5.7.1 (x86_64-apple-darwin18.2.0)
But as I said, I'd rather not spend time reviewing or maintaining this code, since we intend to remove it.

I'm going to close this since it's been quiet for a bit and due to @ehuss's previous comments.


Number of images loaded more than existing images in folder

Describe the bug
In v2_alpha branch, especially when images more than 30 , and scroll down while loading images,
the total loaded images is more than the number of images in the project folder

Fixed in the latest PR #484


Range Map; Custom Break Points.

Is your feature request related to a problem? Please describe.
Add custom break points on the range map
Describe the solution you'd like
Need an input box for the numbers.
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
Additional context
Add any other context or screenshots about the feature request here.

Done.


Binary releases (try #2)

Same as #118, I think it got overwritten in the history somehow

OK cool. Try pushing a new tag and let's see if it works 🙏

Hmm, seems like the jobs are choking 😱
I'll make a patch real quick 🙇

Build: Some jobs were not successful
View workflow run
https://github.com/trealla-prolog/trealla/actions/runs/4191126921
[image: WebAssembly]
Build / WebAssembly
Failed in 5 seconds
[image: annotations for Build / WebAssembly] 2
https://github.com/trealla-prolog/trealla/actions/runs/4191126921
[image: Native (ubuntu-latest)]
Build / Native (ubuntu-latest)
Succeeded in 46 seconds
[image: Native (macos-latest)]
Build / Native (macos-latest)
Succeeded in 4 minutes and 28 seconds
On Thu, Feb 16, 2023 at 3:54 PM guregu @.***> wrote:

Hmm, seems like the jobs are choking 😱
I'll make a patch real quick 🙇
—
Reply to this email directly, view it on GitHub
https://github.com/trealla-prolog/trealla/pull/120#issuecomment-1432564039,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AFNKSEV7FQ5N5OURJKE52GLWXW6JFANCNFSM6AAAAAAU5WZ4PM
.
You are receiving this because you modified the open/close state.Message
ID: @.***>

2s
Run @.***
2s
Set environment (1/3)
0s
1
https://github.com/trealla-prolog/trealla/actions/runs/4191126921/jobs/7265236062#step:3:1Run
echo "WASI_VERSION_FULL=${WASI_VERSION}.0" >> $GITHUB_ENV
9
https://github.com/trealla-prolog/trealla/actions/runs/4191126921/jobs/7265236062#step:3:10Error:
Unable to process file command 'env' successfully.
10
https://github.com/trealla-prolog/trealla/actions/runs/4191126921/jobs/7265236062#step:3:11Error:
Invalid format '2.9.5'
Set environment (2/3)
0s
Set environment (3/3)
0s
Add Homebrew to $PATH
0s
Install WASI SDK
0s
Install Binaryen
0s
Setup Wasmer
0s
Build
0s
Test
0s
Upload artifacts
0s
Publish on WAPM
0s
Complete job
0s
On Thu, Feb 16, 2023 at 3:54 PM guregu @.***> wrote:

Hmm, seems like the jobs are choking 😱
I'll make a patch real quick 🙇
—
Reply to this email directly, view it on GitHub
https://github.com/trealla-prolog/trealla/pull/120#issuecomment-1432564039,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AFNKSEV7FQ5N5OURJKE52GLWXW6JFANCNFSM6AAAAAAU5WZ4PM
.
You are receiving this because you modified the open/close state.Message
ID: @.***>

Hmm, it seems that release was targeted at an old version (188cd64def556bde17fb09d55740962585eee02a)
Can you try to cut a tag from a8a22e6c73c700520e085cff4ec99098afe3f8f7?

No idea what that means.
On Thu, Feb 16, 2023 at 4:03 PM guregu @.***> wrote:

Hmm, it seems that release was targeted at an old version (188cd64
https://github.com/trealla-prolog/trealla/commit/188cd64def556bde17fb09d55740962585eee02a
)
Can you try to cut a tag from a8a22e6
https://github.com/trealla-prolog/trealla/commit/a8a22e6c73c700520e085cff4ec99098afe3f8f7
?
—
Reply to this email directly, view it on GitHub
https://github.com/trealla-prolog/trealla/pull/120#issuecomment-1432572775,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AFNKSEQ7FTAXK6DBBNVMY3TWXW7KRANCNFSM6AAAAAAU5WZ4PM
.
You are receiving this because you modified the open/close state.Message
ID: @.***>

Ah, sorry about that. Basically, that build was using the old script (before this PR). I think it breaks when two tags point to the same commit. The breaking part was removed in this PR.
If you create a new tag from the current main branch it might work.

I think you need to git pull before you make the tag.

Is it trigger both on a push to main & a tag?
On Thu, Feb 16, 2023 at 4:15 PM guregu @.***> wrote:

I think you need to git pull before you make the tag.
—
Reply to this email directly, view it on GitHub
https://github.com/trealla-prolog/trealla/pull/120#issuecomment-1432582474,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AFNKSEXN4423FVLRCVPW24DWXXAX5ANCNFSM6AAAAAAU5WZ4PM
.
You are receiving this because you modified the open/close state.Message
ID: @.***>

OK I think I can see what happened before, why the commit got removed from the history.

This PR got removed from the history again.
It's set up to release from tags only, but it should run on commits to main and PRs.

Yeah a -f. No real reason, My up-array just grabs it!
On Thu, Feb 16, 2023 at 4:25 PM guregu @.***> wrote:

OK I think I can see what happened before, why the commit got removed from
the history.

This PR got removed from the history again.
It's set up to release from tags only, but it should run on commits to
main and PRs.
—
Reply to this email directly, view it on GitHub
https://github.com/trealla-prolog/trealla/pull/120#issuecomment-1432589424,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AFNKSEXW5JVU5CWTVABDMMTWXXB5BANCNFSM6AAAAAAU5WZ4PM
.
You are receiving this because you modified the open/close state.Message
ID: @.***>

Hahaha alright. Let's try again. Third time's the charm :)
Sorry about this


[QUERY] Is there a way to stop a workflow in an early step without throwing error to an admin via Slackbot?

Question
The main question is if it is allowed to NOT call client.function.completeError/Success in a ViewClosedHandler callback in order to stop a Slack workflow early?
Context
Normally a SlackFunction is completed successfully or fails. But what about stopping the workflow early? The use case in mind is handling a modal view that the user closes early. You can do the following:
Call functions.completeSuccess
export default SlackFunction(..., ...)
  .addViewClosedHandler("myview", () => ({ client, body }) {
    /* clean up stuff */

    return await client.functions.completeSuccess({
      function_execution_id: body.function_data.execution_id,
      outputs: {}
    })
  })

The drawback with this is that the rest of the workflow needs to handle undefined or null outputs, and add some kind of a short circuit logic for all other slack functions.
Call functions.completeError
export default SlackFunction(..., ...)
  .addViewClosedHandler("myview", () => ({ client, body }) {
    /* clean up stuff */

    return await client.functions.completeError({
      function_execution_id: body.function_data.execution_id,
      error: "User closed the dialog early"
    })
  })

The drawback with this approach is that whenever the user legitimately closes the modal window (e.g. they don't have the time to complete the modal inputs) then the admins are all pinged by SlackBot with this error.
Do nothing at all
export default SlackFunction(..., ...)
  .addViewClosedHandler("myview", () => ({ client, body }) {
    /* clean up stuff */

   console.log('user closed the modal view early');
   // do nothing
  })

The modal view closes, an entry in activity log is made (when console.log is used) and the workflow doesn't continue (which is desired effect). However this possibility is not documented anywhere and I'm not sure if this will create some memory leak on Slack's end. Is this an allowed way of exiting the workflow early?
Environment
Not really applicable but:

Paste the output of cat import_map.json | grep deno-slack

    "deno-slack-sdk/"<EMAIL_ADDRESS>    "deno-slack-api/"<EMAIL_ADDRESS>

Paste the output of deno --version

deno 1.39.4 (release, x86_64-apple-darwin)
v8 12.0.267.8
typescript 5.3.3

Paste the output of sw_vers && uname -v on macOS/Linux or ver on Windows OS

ProductName:            macOS
ProductVersion:         14.2.1
BuildVersion:           23C71
Darwin Kernel Version 23.2.0: Wed Nov 15 21:54:10 PST 2023; root:xnu-10002.61.3~2/RELEASE_X86_64

Requirements
Please read the Contributing guidelines and Code of Conduct before creating this issue or pull request. By submitting, you are agreeing to those rules.
Cool beans 🤘

Hi, @spoike! Thanks so much for your query. 🙇
Since this isn't documented, I will check with the team internally to see if your proposed approach to "do nothing" is the standard for terminating a workflow early - will get back to you as soon as I have an update!

hi, @spoike!
After checking with the team, it seems like it's valid to end a workflow without reporting a success or error. There is not really much insights with regard to the memory leaks side as of right now, but your current approach seems like a valid pattern you can continue with! I'll be sure to update this if that changes.

I also surfaced this to our documentation team due to your suggestion of documenting it! I'll get back to you on any updates the team makes.
Thank you so much for submitting this question and feedback! 🙇

Thanks for the info!

I have a need for this exact thing.   However, in my custom function I am not using a modal, and thus I do not have a closed/submission handler - it is just a custom function (step) that is added to a workflow.
Is there a workaround to do something similar where you don't have a closed/submission handler?

@mcsescott sure, just set completed: false in the return value of your custom function/step.
Under the hood, the deno-slack-runtime project, which powers both the slack run local experience as well as the deployed-to-Slack slack deploy experience, will run your function, and based on the returned object's error and completed properties, will either hit the functions.completeSuccess or functions.completeError method (code ref here).
As long as both error and completed on the output object returned by your custom step are falsy, then neither of the functions.complete* APIs will be hit. However, this means the workflow engine will not continue with the next step in the workflow after your function. Not sure if that is what you want or not... what's your use case, if you don't mind me being nosy?

Thanks, @filmaj .
I just tried returning completed: false and the workflow shows as "In progress", so it does appear to be working and will stall the workflow. I wonder if there is/will be a timeout where it will eventually spit out an error.  Thinking about it, though, other workflows that are "in progress" don't really time out, so I guess we can live with that.  :-)  It's not like you give us an export capability from the activity log anyway.  :-P
Use case:  Trying to get around the lack of conditional branching in workflows.  We have several instances where we want to force a workflow to stop at a certain point, so I am building a custom step to do that.

Cool thanks for sharing. And as you gleaned, there is no timeout for incomplete workflows.

Thank you, @filmaj.  This was extremely helpful.  Like @mcsescott (thank you for asking first), I too am trying to get around the lack of conditional branching in workflows.

One way I have worked around the lack of conditional branching is to encapsulate each "branch" into a separate workflow. Then, using a custom function at the particular branching point, I create a dynamic one-time (no recurrence) scheduled trigger (see our docs on this here - flip the tab in this section to "create a scheduled trigger at runtime") for a few seconds in the future which trips whichever workflow represents the "branch" that I want to run.
Definitely a hack and non-ideal workaround until conditional branching is a first-class feature, which the team is hard at work on.
Going to close this issue as I believe the questions in here have been answered, but if there are any follow ups, feel free to re-open / at-mention me / file a new issue.


PowerShell steps to create free App Service Managed Certificate

Is there documentation on how one could create a free App Service Managed Certificate thru PowerShell? The steps aren't included in the script on the page.
https://docs.microsoft.com/en-us/azure/app-service/configure-ssl-certificate#powershell
@PramodValavala-MSFT

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: cc2ee874-df45-1de2-1b30-1fd75c7fd709
Version Independent ID: ee181722-8386-9842-407f-d0549012d2e9
Content: Add and manage TLS/SSL certificates - Azure App Service
Content Source: articles/app-service/configure-ssl-certificate.md
Service: app-service
GitHub Login: @cephalin
Microsoft Alias: cephalin

Hello @Ayanmullick, Thank you for your feedback! We will review and update as appropriate.

@Ayanmullick, You may use the workaround script to use with PowerShell.

Thanks @AjayKumar-MSFT , I was able to deploy the certificate using the workaround. How do I provide the path and the password for the cmdlet for binding?
New-AzWebAppSSLBinding -WebAppName $webappname -ResourceGroupName $webappname -Name $fqdn -CertificateFilePath $pfxPath -CertificatePassword $pfxPassword -SslState SniEnabled

@Ayanmullick I believe CertificateFilePath and CertificatePassword are for uploading a certificate, since the managed certificate is already available you will need to specify the thumbprint of it using the Thumbprint parameter instead. You will need to dynamically retrieve the thumbprint of the newly created managed certificate similar to how the workaround template does it.
"certificateThumprint": {
    "value": "[reference(resourceId('Microsoft.Web/certificates', variables('certificateName'))).Thumbprint]"
}

The binding fails due to some reason, @AjayKumar-MSFT and @krispenner

That worked. Thanks @AjayKumar-MSFT and @krispenner. It'd be great if a certificate creation cmdlet could be added to Az.Websites PowerShell module

@Ayanmullick, Glad to know it works now. We have shared your feedback with the concerned product/content owner to update the doc as appropriate. Thanks for your feedback and update.


[Feature Request][Spark] Support Spark 4 + Java 21

Feature request
Which Delta project/connector is this regarding?

[x] Spark
[ ] Standalone
[ ] Flink
[ ] Kernel
[ ] Other (fill in here)

Overview

Are there plans to upgrade the Spark connector to use Spark 4.x?
Motivation

Compatibility with Java 21 (SPARK-41111)

Further details
It looks like Spark 4.x is also dropping Scala 2.12 in favor of 2.13. Is the Spark connector compatible with Scala 2.13 today?

Willingness to contribute
The Delta Lake Community encourages new feature contributions. Would you or another member of your organization be willing to contribute an implementation of this feature?

[ ] Yes. I can contribute this feature independently.
[x] Yes. I would be willing to contribute this feature with guidance from the Delta Lake community.
[ ] No. I cannot contribute this feature at this time.

🤔 Nevermind, I think I found the plan details! https://github.com/delta-io/delta/releases/tag/v4.0.0rc1


Doesn't let someone block if they're too close and if they're in a doorway.

About the PR
Fixes #9731
Fixes #9502
This prevents someone from blocking if they're too close to a solid structure or entity.
It also prevents someone from blocking if they're intersecting a door.
Changelog

:cl:

fix: You can no longer clip people into walls with riot shields.
fix: You can no longer hide behind doors while using a shield.

Wasn't blocking doorways the primary utility the shield had?


Rework heredocs to improve syntax highlighting

Trying to write another parser and pulling this up in a handful of editors wouldn't properly syntax highlight. This adds assignment to each heredoc to make this a little more friendly.

@bensie that's weird... both Emacs and vim color it correctly. But yea seems reasonable to at least use the pattern of xml =  throughout the file.
Thank you :yellow_heart:

Haha I tried in Sublime and Atom :)

@bensie the new kids still gotta learn from the old boys :trollface:


flash publisher source code

I use flash as3 to create a live stream publisher (camera and microphone).
After connected successfully and started to publish stream, the connection is closed automatically.
Is there anything special I need to do in as3?
is there any flash source code of the flash publisher in demo (srs_publisher/release/srs_publisher.swf?_version=1.23)?
Thank you!

Yep, here: https://github.com/simple-rtmp-server/srs/tree/2.0release/trunk/research/players/srs_publisher/src/srs_publisher.as
BTW: Please file issues at https://github.com/simple-rtmp-server/srs/issues/new


Create 3 SDK: ValueError: badly formed hexadecimal UUID string

I am trying to connect to an irobot; however, there are many in the vicinity. How can I get the specific BLE ID for the robot?
Create3(Bluetooth(What goes here))

If you know the robot's name (which can be set using the web server, though this requires an application restart after saving), you can use Create3(Bluetooth('robot-name')). When you connect to the robot in this manner, I believe it prints the address to the screen upon connection. You could then subsequently connect to the robot with something like Create3(Bluetooth(address='hex-address')), if memory serves.

Thank you this works well.


#163966386 View office results

What does this PR do?

Builds the office results endpoint
Description of Task to be completed?

[x] Add results endpoint tests
[x] Add validation for the results
[x] Add methods to read the database

How should this be manually tested?
After cloning the repository to your local machine - check
README.md for instructions. Using
Postman open a request to create a party How to create a party. create an office How to create an office. Follow the instructions on the PR's on how to make those requests.
Once you have an office and party also register a user how to signup user. To register a user as a candidate for the office created How to register candidate Once you have a candidate and you have cast dummy vote how to vote. Open a new request, with an authorization header whose value is the token for the logged in user, to this endpoint GET /api/v2/office/{office_id}/result
What are the relevant pivotal tracker stories?
#163966386
Screenshots
GET /api/v2/office/10/result

Coverage increased (+0.02%) to 97.222% when pulling e2fea3c21632799ca0429932aa3f4977aff63730 on ft-view-office-results-163966386 into 8e9957475a78e3996e86099b2f222737cedfd1e1 on develop.


Dev Tools have lost their Windows Title Bar Edge Dev Version 115.0.1880.3 (Official build) dev (64-bit)

If I am using the latest Edge Dev version 115 and open Dev Tools in undocked mode i cannot minimise or drag and drop the dev tools as the Windows Title Bar is not visible as demonstrated in the image attached to this issue.

This issue doesn't exist in Edge Version 114.0.1823.43 (Official build) (64-bit) RTM

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: fb8172aa-183f-6821-f7a3-1a1f838d671c
Version Independent ID: fb8172aa-183f-6821-f7a3-1a1f838d671c
Content: Simplify DevTools using Focus Mode - Microsoft Edge Development
Content Source: microsoft-edge/devtools-guide-chromium/experimental-features/focus-mode.md
Product: microsoft-edge
Technology: devtools
GitHub Login: @MSEdgeTeam
Microsoft Alias: msedgedevrel

thanks for the info @captainbrosset 👍


Cleanup conversations tokens

Remove token storage when executing dialogs
Remove DicToken and ClockifyToken from UserProfile class

Closes #69

Please clean up conversation entries on the blob storage before merging.

Please clean up conversation entries on the blob storage before merging.

That will break proactive messages.


[Drawer] fix for server side rendering

[x] PR has tests / docs demo, and is linted.
[x] Commit and PR titles begin with [ComponentName], and are in imperative form: "[Component] Fix leaky abstraction".
[x] Description explains the issue / use-case resolved, and auto-closes the related issue(s) (http://tr.im/vFqem).

@pablo-bondacom Thanks!


Getting a Error as "ERROR: type "abstime" does not exist" when executing BPS DB scripts against Postgres 14.1

How to reproduce:

Configure postgres latest version (14.1) with a docker image
Create a  database and exectute the db postgres db scripts agaianst postgres 14.1
When execute /dbscripts/bps/bpel/create/postgresql.sql script getting below errors

Note
Didnt observe this issue against postres 11.5 . Got this against postgres latest version (14.1)

SQL Error [42704]: ERROR: type "abstime" does not exist
  Position: 131
  ERROR: type "abstime" does not exist
  Position: 131
  ERROR: type "abstime" does not exist
  Position: 131

2022-01-12 12:16:16.314 - org.jkiss.dbeaver.model.sql.DBSQLException: SQL Error [42704]: ERROR: type "abstime" does not exist
  Position: 131
	at org.jkiss.dbeaver.model.impl.jdbc.exec.JDBCStatementImpl.executeStatement(JDBCStatementImpl.java:133)
	at org.jkiss.dbeaver.ui.editors.sql.execute.SQLQueryJob.executeStatement(SQLQueryJob.java:513)
	at org.jkiss.dbeaver.ui.editors.sql.execute.SQLQueryJob.lambda$0(SQLQueryJob.java:444)
	at org.jkiss.dbeaver.model.exec.DBExecUtils.tryExecuteRecover(DBExecUtils.java:171)
	at org.jkiss.dbeaver.ui.editors.sql.execute.SQLQueryJob.executeSingleQuery(SQLQueryJob.java:431)
	at org.jkiss.dbeaver.ui.editors.sql.execute.SQLQueryJob.run(SQLQueryJob.java:220)
	at org.jkiss.dbeaver.model.runtime.AbstractJob.run(AbstractJob.java:105)
	at org.eclipse.core.internal.jobs.Worker.run(Worker.java:63)
Caused by: org.postgresql.util.PSQLException: ERROR: type "abstime" does not exist
  Position: 131
	at org.postgresql.core.v3.QueryExecutorImpl.receiveErrorResponse(QueryExecutorImpl.java:2553)
	at org.postgresql.core.v3.QueryExecutorImpl.processResults(QueryExecutorImpl.java:2285)
	at org.postgresql.core.v3.QueryExecutorImpl.execute(QueryExecutorImpl.java:323)
	at org.postgresql.jdbc.PgStatement.executeInternal(PgStatement.java:481)
	at org.postgresql.jdbc.PgStatement.execute(PgStatement.java:401)
	at org.postgresql.jdbc.PgStatement.executeWithFlags(PgStatement.java:322)
	at org.postgresql.jdbc.PgStatement.executeCachedSql(PgStatement.java:308)
	at org.postgresql.jdbc.PgStatement.executeWithFlags(PgStatement.java:284)
	at org.postgresql.jdbc.PgStatement.execute(PgStatement.java:279)
	at org.jkiss.dbeaver.model.impl.jdbc.exec.JDBCStatementImpl.execute(JDBCStatementImpl.java:330)
	at org.jkiss.dbeaver.model.impl.jdbc.exec.JDBCStatementImpl.executeStatement(JDBCStatementImpl.java:130)
	... 7 more

Related https://github.com/wso2/product-is/issues/10414
Environment
5.12.0 alpha 9
postgres version (14.1 (Debian 14.1-1.pgdg110+1))

This issue was also reported in earlier version and was closed stating unable to preproduce in 5.11 beta   #7343 .  It's back in the latest version. I wonder how.

@anuragpathak21 Did you check with the latest version ( 5.12.0) against postgres 14.1. #7343 was reported against postgres 12.1. This was observed against postgres 14.1

This issue has been fixed with [1]. The issue has been fixed from carbon-process 4.5.49 onwards but wso2is-5.12.0-alpha9 contains 4.5.47 therefore the issue was reproduced but with latest pack the issue has been fixed.
[1] https://github.com/wso2/carbon-business-process/pull/640


Update pvo.oims_2.0.xml to ver 2.1

Updated title, instrument name, and instrument description

🗒 Summary
Updated title, instrument name, and instrument description
⚙ Test Data and/or Report
♻ Related Issues

Changed destination branch to https://github.com/NASA-PDS/EdWG/tree/chimpdog_updates so we can consolidate and update these all together