libnetwork: different behavior while creating bridge with IPv6 support compared to v1.5 and v1.6

As described in the snapshot documentation Docker versions 1.5 and 1.6 did setup a route and enabled IPv6 routing to Docker's fixed-cidr-v6 subnet (e.g. 2001:db8:1::/64) while creating the docker0 bridge:
$ ip -6 route add 2001:db8:1::/64 dev docker0
$ sysctl net.ipv6.conf.default.forwarding=1
$ sysctl net.ipv6.conf.all.forwarding=1

Currently, with libnetwork merged in 1.7.0-dev, these steps are not executed.
Should those steps be executed manually by the user or automatically when starting the Docker daemon?
Either we have to adjust the docs or we have to add functionality.

Hi!
If you are reporting a new issue, PLEASE make sure that does not have any duplicates already open.
We would like to take this time to remind you of the information we need to debug the problem you are seeing. This is an automated response so if this ticket is not about a bug, do not fret.
If you fail to provide this information within 7 days, we will close this because we cannot debug your issue. We can reopen whenever the information is provided.
Thank you.
Please see:
https://github.com/docker/docker/blob/master/CONTRIBUTING.md#reporting-other-issues
Description of problem:

`docker version`:

`docker info`:

`uname -a`:

Environment details (AWS, VirtualBox, physical, etc.):

How reproducible:

Steps to Reproduce:
1.
2.
3.

Actual Results:

Expected Results:

Additional info:

#ENEEDMOREINFO

ping @mrjana @mavenugo possible regression after libnetwork integration

@MalteJ @thaJeztah will take a look. We need good ipv6 integration-cli to catch these early.

@mavenugo thanks, perhaps you could check https://github.com/docker/docker/pull/13226 as well, to see if the test is still relevant for libnetwork

That libnetwork PR still needs to be ported to docker, doesn't it @mavenugo?


Remove deprecated C++

Some of function utilities defined in  are deprecated in
C++11, and removed in C++17. Such as std::bind2nd, std::not1, and
std::binary_function.
This CL replaces them with lambda, so that the code can compile as
a C++17.

@sebsg, is there any chance of taking a look to this?

Hey! Thank you for writing that patch. I just updated the repo since it had been a while and there were a couple of changes that should affect/help you.
Can you let me know if this helps? Thanks!

Hi tzik,
unfortunately we don't currently have plans to support C++17 in the short term unfortunately.
Therefore, even by applying this patch, I would not be able to promise that then next change we don't won't break on C++17.
Sorry for the incovenience.
cheers!

Just the community support works fine for us rather than the official support: We may send a pull request when we find a C++17 mode breakage, but you don't need to care about C++17 mode breakages.
As described in a tracking downstream issue, libaddressinput is the last C++17 incompatible component for Chromium. Though it's possible to stick to C++14 for individual components, full C++17 adoption makes things easier for us.
Could you take this if this does not conflict to the goal of the project?

As we chatted, let me move the change to the internal repo.


Waves effect too large

I think Waves effect is too large.
The CSS size is 139 kb, but the Waves path is 67 kb.
about 48% of css size is for a effect. I it think should be smaller.

@phamquangbaoplus hey can you link to file-lines for know about your suggestion ?


proposal: use sidecar to pause the pod

Now we use a fake image to pause the pod, this is not elegant, I think we can use sidecar mechanism, maybe:

When we start the POD, using sidecar to inject an init container and start the init container.
Let the init container start the real container, so we can support pause.

This is just my guess, I don't think whether it can work or not, but we can have a try.
Or maybe we can find a better way?

You can use an ephemeral container rather than a sidecar.

@sftim Do you have any suggestion on how to pause a pod with the help of ephemeral container?
BTW, the securityContext of ephemeral container is not yet configurable). It stops us from using ephemeral containers in IO and Network Chaos 😣.

 If you have the access to run it, you can use ptrace() with PTRACE_ATTACH as well.
ptrace() with PTRACE_SEIZE offers opportunities to trace processes and then later suspend them with PTRACE_INTERRUPT.
Otherwise (no shared namespace) there's not so much the container can do.

Thank you for you advise @sftim , @cwen0 PTAL

@sftim This feature is enabled in v1.17，I think we can make this as a option to support all kinds of signals later

With a shared process namespace kill -STOP simulates failure to progress; kill -CONT resumes. If you have the access to run it, you can use ptrace() with PTRACE_ATTACH as well.
ptrace() with PTRACE_SEIZE offers opportunities to trace processes and then later suspend them with PTRACE_INTERRUPT.
Otherwise (no shared namespace) there's not so much the container can do.

When we stop the process by killing it with shared namespace, the container may restart again. I think what the proposal wants to achieve is making the container stop for some time. AFAIK, the fake image is the only way we can use now.

@tennix No. kill -STOP will not "kill" a process, but just send SIGSTOP signal. This inspired me another idea: we can use cgroup freezer to implement container pause (like docker does) in chaos-daemon!
Or simply use docker API to pause a container.

But pod-failure and process-pause maybe different kind of chaos. pod-failure means stop the pod and after several minutes it will restart. But process-pause will not stop and restart, but only fail to schedule. The difference is the "restart" process.
@cwen0 What's your opinion?

yep, I also think that pod-failure and process-pause are different kinds of chaos. Some processes will handle some signals, so these two types of chaos also behave differently for the process. Next, we also need support pod-pause.

I will close this issue. If there are anything still need todo, then we can reopen it


to add open source flutter app

Voting Dapp
https://github.com/a-m-a-nkumar/voting_dapp
Voting Dapp is a decentralised voting platform based on blockchain.
Category: Blockchain , Flutter , Solidity Contracts

I am a GSSOC Contributor . Please assign me this issue.

The project's readme is incomplete.


Update go version on CI to 1.22

Update the go version used on CI to 1.22

Don't you think it might be worth to add some logs in the LoadConfig method, in the error cases?

Don't you think it might be worth to add some logs in the LoadConfig method, in the error cases?

I will add them in another PR, as it isn't necessarily related to the Golang version bump


Steal connection

Resolves #2007
If the same taker tries to connect twice we prioritize the second connection. This can be useful if the taker thinks he is disconnected from the maker but the maker does not

bors r+


Logarithmic scale

My web site has strongly fluctuating number of visitors. In the charts I currently see a few spikes and otherwise a flat line at zero because regular traffic is so much lower than the spikes. I would love an option to set logarithmic scale on the y-axis so I can see both the high and the low counts. Added goodie: growth is much easier to estimate on a logarithmic scale.

This has already been discussed and is currently in the GoAccess 2.0 Milestone (you can refer to #933)

Great, thank you! And sorry for the duplicate.


For manual-instance-deploy branch, update .env.sample to reflect new compose.yaml variables.

Done.


"Add new project" link and fixed "My projects" link

This PR adds a new link to the header dropdown "Neues Projekt" (because there is no way to reach the projects page if there is no project. It also fixes the link to "My projects",  which is only visible if there are projects, thus leading to the first project.

:tada: This PR is included in version 1.0.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Update scroll registers on VBL interrupt

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Bug fix.

What is the current behavior? (You can also link to an open issue here)

On scene, sprite position sometimes gets out of sync with background.

(It might be hard to appreciate in the GIF, but the rock sprite moves one pixel up and down as the player walks and the scene scrolls)

What is the new behavior (if this is a feature change)?

SCX_REG and SCY_REG are now updated on a VBL interrupt. Keeping backgrounds and sprites in sync.

(the rock sprite stays in the same position with the scene scroll)

Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)

After some quick tests, doesn't seem to break anything. However I'm not 100% sure of the possible side-effects of moving the scroll updates. Further testing would be good.

Other information:

The change was inspired by ZGB logic for scroll https://github.com/Zal0/ZGB/blob/0f6f59eea1f4787ac76629661d2abc4ce8bb3b7a/common/src/main.c#L39

Nice, Seems you've caught for camera shake too,
Don't think it needs a particular bank either so it shouldn't be screwing up any processes it interrupts.

Nice work! I'm away from home at the moment so don't have much ability to test this but sounds great.
I wanted to investigate ZGB a bit more actually, I ended up coming across the project after most of the game engine was already complete, it helped with getting some of the finishing touches working but I found it too late to fully use it.
For the next GB Studio version I'd like to start looking to expanding the supported game genres and it might be a good time for an engine rewrite built on top of ZGB.

Finally got round to merging this, works great thanks!


Release pre: switch to the latest conventions

Reviewer checklist

[ ] Ensure relevant issues are linked (description should include text like "Fixes #")
[ ] Ensure any appropriate documentation has been added or amended

Coverage remained the same at 97.79% when pulling 2743ea978cf46318aa2e817548292b0e1b260d18 on release_prep into 947df2c1ca061f5e311e5d8e312c08e769ee61cc on main.


Array support for params (or better error message...)

I'm not sure if arrays can be supported, so if not, then I'm cool with just a better error message too..
Current, if you try to add an array type, you'll get the error
class SomeJob < Mosquito::QueuedJob
  params ids : Array(String)
  def perform
    # ...
  end
end

Error: unexpected token: "nil?"

This comes from this line
https://github.com/mosquito-cr/mosquito/blob/d0e40c3b1a59a7c82f6ce94cd920ef4c92119703/src/mosquito/queued_job.cr#L49
because simplified_type is defaulted to nil and only set if the type declaration type is_a? Path, but it's not... it's a Generic.
The code ends up trying to make @ids : nil? which is a syntax error.
Which means this block is skipped
https://github.com/mosquito-cr/mosquito/blob/d0e40c3b1a59a7c82f6ce94cd920ef4c92119703/src/mosquito/queued_job.cr#L36-L40
An easy solution could be just adding the else condition to raise an error saying the type isn't supported
Crystal version: 1.8.1
Mosquito Shard version:  1.0.0.rc3+git.commit.d0245eba8514e238c253267b0bdf7663c6b01590

I've got a similar issue using an array value as the param:
web          | There was a problem expanding macro 'finished'
web          |
web          | Called macro defined in macro 'inherited'
web          |
web          |  64 | macro finished
web          |
web          | Which expanded to:
web          |
web          |  >  1 |
web          |  >  2 |           def initialize; end
web          |  >  3 |
web          |  >  4 |           def initialize(@keys : Array(String))
web          |  >  5 |           end
web          |  >  6 |
web          |  >  7 |           # Methods declared in here have the side effect over overwriting any overrides which may have been implemented
web          |  >  8 |           # otherwise in the job class. In order to allow folks to override the behavior here, these methods are only
web          |  >  9 |           # injected if none already exists.
web          |  > 10 |
web          |  > 11 |
web          |  > 12 |             def vars_from(config : Hash(String, String))
web          |  > 13 |
web          |  > 14 |                 @keys = deserialize_array(string)(config["keys"])
web          |  > 15 |
web          |  > 16 |             end
web          |  > 17 |
web          |  > 18 |
web          |  > 19 |
web          |  > 20 |             def build_job_run
web          |  > 21 |               job_run = Mosquito::JobRun.new self.class.job_name
web          |  > 22 |
web          |  > 23 |
web          |  > 24 |                 job_run.config["keys"] = serialize_array(string)(@keys.not_nil!)
web          |  > 25 |
web          |  > 26 |
web          |  > 27 |               job_run
web          |  > 28 |             end
web          |  > 29 |
web          |  > 30 |
web          |  > 31 |
web          | Error: unexpected token: "("

The job:
class SomeJob < Mosquito::QueuedJob
  param keys : Array(String)
  ...
end

The mosquito serializer logic is certainly primitive. For this particular case, it's kind of straightforward to emit an error suggesting the developer do something else:
            elsif type.id =~ /Array|Hash/
              raise "Mosquito Job: Unable to build serialization for #{type}. Have you considered serializing using json?"

That looks like this:
Error: Mosquito Job: Unable to build serialization for Array(Int32). Have you considered serializing using json?

There's certainly a future in better serialization logic, but it's a lot of lift and I'm not sure the payoff is worth it at this time. I looked for a bit but I didn't see any better way in crystal macros to inspect the type to see if it's an array or a hash -- this problem would probably also rear if it were specified as an Enum or a Tuple. The logic for any of these things is trivial for the single case but significantly harder to generalize -- Avram has a lot of infrastructure around making this work.
In the mean time, is it reasonable to add an error message like that? Should it also regex on Tuple, Enum, or anything else?

I think it's reasonable to just add the error message for now with a suggestion.
Avram actually just checks {% if @type.is_a?(Generic) %} , but you can also do {% if @type < Array %}. Though opening up Array will end up leading to "How come X isn't supported" for other types, so having that error for unsupported types would be great either way.
What would be nice is something like Ruby's Marshal :joy: though, I guess JSON works here too? Is that what Sidekiq is doing?

A better error is definitely an improvement. As @jwoertink says, opening the door for Array will inevitably lead to more requests like these.
That said, what about supporting simple serialization? Something along the lines of:
class SomeJob < Mosquito::QueuedJob
  param keys : Array(String), as: :json
end

Or perhaps:
class SomeJob < Mosquito::QueuedJob
  json_param keys : Array(String)
end

In the background that would call .from_json on the passed type with the variable (always String). It would even allow more complex data structures without additional work:
class SomeJob < Mosquito::QueuedJob
  json_param data : SomeData

  struct SomeData
    include JSON::Serializable
    ...
  end
end

It's just an idea, I'm not trying to get you to work or anything 😊.

Yes, I think if I was going to support serialization it'd need to have some sort of interface module similar to what avram does.
I toyed around with like:
module Mosqito::Serializer(T)
   abstract serialize(input : T) : String
   abstract deserialize(input : String) : T
end

class KlassSerializer
   include Mosquito::Serializer(Klass)

   # ...
end

class Job < QueuedJob
  param data : Klass, serialize_with: KlassSerializer
end

It's a great idea and I'd like to implement it...but for now I think I'll just use Jeremy's suggestion to check for Array or maybe Generic so the error is less opaque and let it be for now.


Import module written in Typescript

Hello,
I have big module in typescript, I dont have much time for rewrite to Flow. Is it any way to import Typscript module in Flow file?
I tried without any special dependencies, just added preset-typescript in babel (for transpile TS).
// @flow

import TSModule from 'components/MyTSModule'
// Module not found: Error: Can't resolve 'components/MyTSModule'

class GenerateReport extends Component<Props, ComponentState> {
   return (
        <TSModule />
   )
}

Thank you :-)

If your TS workflow is outputting the transpiled .js file into the same directory, you can import that with Flow as usual.
As for Flow being able to read a non-transpiled .ts file, that won't be possible.  Flow has its own JS parser, completely independent of tools like Babel, which hasn't had extra support added for TS syntax.

I dont have much time for rewrite to Flow

One option you could look into is https://github.com/joarwilk/flowgen

If your TS workflow is outputting the transpiled .js file into the same directory, you can import that with Flow as usual.
As for Flow being able to read a non-transpiled .ts file, that won't be possible. Flow has its own JS parser, completely independent of tools like Babel, which hasn't had extra support added for TS syntax.

If your TS workflow is outputting the transpiled .js file into the same directory, you can import that with Flow as usual.
As for Flow being able to read a non-transpiled .ts file, that won't be possible. Flow has its own JS parser, completely independent of tools like Babel, which hasn't had extra support added for TS syntax.

For transpile I use babel where is preset-flow and I added preset-typescript. I found the solution for this.
In TSModule I create index.js with:

import test from './tsmodule'
export default test
Now it works in Flow files.
Is it good solution  ? I am afraid of types from TSmodule

I think what's happening there is that Flow sees that your index.js file has no // @flow header, so just ignores it, and treats any imports of it as the any type.  And therefore you could have any content in that file, and Flow won't complain.
So that solution sounds fine, if it gets things working for you in Babel.  But just bear in mind that Flow will only be typechecking files that have a // @flow header.
I think another solution might be that you could just import the .ts module directly from the Flow file, but you'd have to configure Flow to also resolve .ts files.

I tried add
module.file_ext=.ts
module.file_ext=.tsx

in .flowConfig, and it works.
I think its best solution, isnt it?
Bcs I dont need write $FlowFixMe comment, and even dont need index.js file for export TSModule.

It's fine if you don't mind that no usages of your TSModule in flow files will be typechecked (imports are just treated as the any type).
If you wanted typechecking, you'd instead want something transpiling to .js files, which then get imported by flow (and make sure the .js file has a // @flow header).

I tried add
module.file_ext=.ts
module.file_ext=.tsx

in .flowConfig, and it works.
I think its best solution, isnt it?
Bcs I dont need write $FlowFixMe comment, and even dont need index.js file for export TSModule.

Oh, sorry. I was wrong.
I have flow error

I dont know why, bcs I have
module.file_ext=.ts
module.file_ext=.tsx

in flowConfig

Probably because you do not have "components" package.

Probably because you do not have "components" package.

I have

Is it a real package or you aliased to src/components?

Sorry, my bad.
I had wrong flowConfig.

Now, it works, without $FlowFixMe comment and index.js file.


:star: new: emoji :twisted_rightwards_arrows: for merge conflict resolution

:twisted_rightwards_arrows: for merge conflict resolution

do you suggest editing the default git message?


Analysis isn't disassembling some instructions

Not sure what the root of this is or if it's covered by another ticket, but if you analyze the attached binary in Binary Ninja, the instructions at 0x9731109 appear as garbage, but if you disassemble with objdump, you can clearly see there is a call to mprotect that Ninja is missing.
aeg-binja.zip

Please run linear sweep on the binary manually. We are currently in the process of adding options to run linear sweep by default. You can run linear sweep from Tools...Run Analysis Module...Linear Sweep.


Add unittest for bfe_proxy ErrInvalidPortNumber error

Codecov Report

Merging #446 into develop will increase coverage by 0.00%.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop     #446   +/-   ##
========================================
  Coverage    53.06%   53.06%
========================================
  Files          257      257
  Lines        23680    23680
========================================
+ Hits         12565    12566    +1
  Misses        9631     9631
+ Partials      1484     1483    -1

Impacted Files
Coverage Δ

bfe_util/fixed_pool.go
83.33% <0.00%> (-16.67%)
:arrow_down:

bfe_spdy/server_conn.go
78.53% <0.00%> (-0.45%)
:arrow_down:

bfe_http2/server.go
71.50% <0.00%> (-0.17%)
:arrow_down:

bfe_spdy/frame_write.go
50.50% <0.00%> (+1.01%)
:arrow_up:

bfe_proxy/v1.go
88.31% <0.00%> (+6.49%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b52965b...b193100. Read the comment docs.


Record webcast for WKC user module

@scottdangelo I'm closing these recording issues, we are tracking in other repo.


piexif isn't getting installed as a dependency

This seems to be related to the default python version in 22.04 being 3.10. This results in the version 0.5.1 of pixe being install by pip. Bumping Python to 3.11 allows the latest version (0.5.4 at this time) to be installed, and the dependencies are installed as anticipated.


Unable to reproduce the accuracy of WRN-28-10 on Cifar-100

I git cloned the code and ran it with the command suggested by readme. However, the Top1 acc stopped at 76% after 160 epochs. I've seen the learning curve in the paper, and found that my model failed to reach 65% acc before 60 epochs. Instead, it just got around 6% lower. Could you please give some suggestion on debugging?

I haven't changed the meanstd value and dropout rate. The meanstd value is (0.5071, 0.4867, 0.4408), (0.2675, 0.2565, 0.2761). The dropout rate is 0.3. Both are just as you configured in the code. The learning rate scheme are also kept unchanged. I used a Tesla K40c to run the code. For every epoch, it took me 10 min, which is quite strange.

I'll run the code tonight and try to figure out if anythings wrong within the code.
Thanks for letting me know :) I'll reply soon !

That will be great, thank you very much!

Hi, sorry for the late response.
I've tested my model out for multiple GPUs (2 Titan X's) and a single GPU (a single GTX1070) for the last two days.
To cut into the result, the best accuracy after 200 epochs reached 79.73% and 80.05% each.
If you need specific logs for the training process, I'll start training a new model right away and will upload the training log in a seperate folder.
Since you didn't have changed any configurations within the repository, I'll double check the model 5 more times with various environments. As each training takes about 15 hours (for a single GPU), it will unfortunately take some time. Will that be OK for you?
Sincerely, Bumsoo Kim

Thanks very much! Really appreciate it! It's OK I can wait. I will also git clone and run it again to make sure I do follow the configuration.

I have run the default configuration again and confirmed that I can't reproduce the reported acc.

Hi, I've finally confirmed the result. I attached the log in the form of a text file. The final results are 80.46% in accuracy, and I think it corresponds the returned accuracy. May I see the log for your training and validation results?
wide_resnet_log.txt

Sorry I forgot to save my log, but I do see that before epoch 121 everything is almost the same with yours. But after that the acc just stopped at 76%. I will have to run it again to show you my log. I will check it more carefully to explore where the problem is, so could you please wait a few days? Really thank you for your log!

Of course! Take your time :)
I will appreciate a lot if you point out any inconsistencies or inconveniences within my code.
I have a lot to learn about Pytorch, so any kind of recommendation will help me a lot.
Thanks.

log.txt

Hi, here is my training log. Is there any problem with it?

@wishforgood Maybe you need to reduce the training batch size (in the config file) from 128 to something small,like 32, if your GPU memory is much lower than the Titan X.

@wronnyhuang Will do shortly :( Sorry for everyone that its taking such a long time

The problem is probably with using self.dropout the same way for both train and eval. Typically people use F.dropout in the forward function and pass self.training as an argument.
I was able to reproduce using this code that uses F.dropout: https://github.com/xternalz/WideResNet-pytorch/blob/master/wideresnet.py.

@fartashf I agree with you. After modifying the codes related to Dropout, I got 80% for the top-1 accuracy.


replaced the share icon button for posts

What does this pull request aim to achieve? 💯
Replaces the icon for share button from plane to three dots.
Please be concise and link any related issue(s):
Resolves #856

@idjevm Please check the size of the share icon to match that of like and comment

Moved this to draft as I am still making minor changes to it.


Feat/via state keeper

What ❔

Why ❔

Checklist

[ ] PR title corresponds to the body of PR (we generate changelog entries from PRs).
[ ] Tests for the changes have been added / updated.
[ ] Documentation comments have been added / updated.
[ ] Code has been formatted via zk fmt and zk lint.

the via_node_sync will be remove and instead of that i'm working to implement StateKeeperIO  for extrnalIO based on the bitcoin limitation or mock it, i'm not sure yet.


FLASK_ENV will be deprecated

In /asreview/entry_points/lab.py, LABEntryPoint starts the webapp by calling /asreview/webapp/start_flask.py:main:
https://github.com/asreview/asreview/blob/9b776ba928e1a2279867a0266d5c244afbe937da/asreview/entry_points/lab.py#L99-L106
Running the app in development mode requires an environment variable FLASK_ENV to be set to the string 'development'. FLASK_ENV will be deprecated in favor of FLASK_DEBUG starting in Flask 2.3

This seems to be resolved in our docs https://github.com/asreview/asreview/blob/master/DEVELOPMENT.md#back-end. Feel free to reopen if there is still some work to do.


[8.x] HasCorrectSignature UrlGenerator taking force scheme into account.

Problem:
If a signed route is generated by URL::signedRoute() or URL::temporarySignedRoute() it uses actual scheme (https or http).
However, validation method hasCorrectSignature() of Illuminate\Routing\UrlGenerator doeesn't consider forceScheme setting.
Scenario:
When using proxy balance loader, in hasCorrectSignature() scheme will be different from generated in URL::signedRoute() wich will lead to constand unauthorized error.
I suggest add forceScheme condition to hasCorrectSignature() method.

It's this solved by configuring trusted proxies? https://laravel.com/docs/8.x/requests#configuring-trusted-proxies

True. The problem can be solved by configuring trusted proxies. So far, it's the only way.
I just see the algorithm parts disagreement.

We generate hash using chosen schema (https)

When we validate it we change the schema to (http). Because of the lack of trusting proxy.

We should either, generate it using the same schema as request->url() method, or take into account forced scheme.

Isn't this solved by configuring trusted proxies? https://laravel.com/docs/8.x/requests#configuring-trusted-proxies

True. The problem can be solved by configuring trusted proxies. So far, it's the only way.
I just see the algorithm parts disagreement.
We generate hash using chosen schema (https)
When we validate it we change the schema to (http). Because of the lack of trusting proxy.
We should either, generate it using the same schema as request->url() method, or take into account forced scheme.


P4RT-2.1: P4RT Election

Hi @dplore, would you consider assigning this case to me?

Thanks @Hobbydos , I have assigned to you.  Please let us know when you expect to send a PR for this test. Thanks!

No Problem, just assessing the timeline and will comment with an estimated time.
As for now, it seems like This comment on Issue 64 seems to hint that p4runtime-go-client is the preferred client. One clarification I would like is if there's a preference for featureprofiles to use either p4runtime-go-client or go-p4.

Hi, the preferred client is now https://github.com/cisco-open/go-p4.   Please use the client for your test implementation.  Note, we acknowledge this is a new work and the p4rt tests here are also without much precedent.  We welcome feedback on your findings using this client.

@dplore
I have a quick question regarding the handling of multiple P4RT tests. P4RT-3.1 and P4RT-3.2, election IDs are being used (0,100=primary), (0,99=secondary) and I've observed that in two different vendor implementations of P4RT, the highest election ID is kept track. When featureprofile tests are ran sequentially, the P4RT server might remember the highest election ID until the P4RT server is restarted. Any following script using lower election ID for its clients will cause the client to fail to be elected as primary. Are there any expectations that users are to handle restarting the P4RT server via bindings file/CI process? If not, is there a proposed alternative?

@robshakir @Ankur19 this is a common issue with gRIBI as well.  Should we update our tests to have the client assume primary using a methodology like described in the gRIBI spec.   Are p4rt and gRIBI elections using the same algorithm?

PR https://github.com/openconfig/featureprofiles/pull/849

Renamed the test to "P4RT Election" to be more inclusive.

PR849 was merged


Update linters pypi links to latest version

I saw that some of the links to the linters PYPI page are not pointing to the latest version - updated those.
BTW - any reason to link to a specific version and not to the latest (https://pypi.org/project/ruff/ instead of https://pypi.org/project/ruff/0.0.228/) ?

Yeah, the versions actually were intentional, since they represent the version at which the plugin was ported over (in the event that they continue to evolve). But, maybe that's just confusing, and not very helpful.
If we do want to change this, though, it needs to be done in Rust files themselves -- so, e.g., we'd need to change this:
//! Rules from [flake8-tidy-imports](https://pypi.org/project/flake8-tidy-imports/4.8.0/).

Then run cargo dev generate-all to regenerate the README :)

Ok cool,
I found it confusing - but maybe it just needs to say that explicitly,
So whatever you think is best

I think it's fine to change it, if you don't mind modifying the references in those source files.

by change do you mean update to latest version or delete the version?

Ah sorry, I mean remove the version, and point to latest.

I think it makes sense to remove the versions since if anything we'd have to track the upstream version for each rule individually ... it doesn't make sense to track it for a whole linter.

Thanks!


SqlAGReplica: Failed to connect to SQL instance 'hostname\MSSQLSERVER'

Hi,
I was able to create an AG group and listener in the Primary node and tried to connect the details in secondary using SqlAGReplica. I got the following error.
Error: PowerShell DSC resource MSFT_SqlAGReplica  failed to execute Set-TargetResource functionality with error message: System.InvalidOperationException: Failed to connect to SQL instance 'hostname\MSSQLSERVER'.
Here are my parameters passed in:
 sqlagreplica{'SQLAddReplica':
      ensure = 'Present'
      name = 'hostname\MSSQLSERVER'
      availabilitygroupname = 'AGGroup'
      servername = 'hostname'
      instancename = 'MSSQLSERVER'
      primaryreplicaservername = $primaryhost
      primaryreplicainstancename = 'MSSQLSERVER'
      endpointhostname = 'hostname'
      failovermode = 'Automatic'
      availabilitymode =  'SynchronousCommit'
      psdscrunascredential = $SqlAdministratorCredential
  }

Any idea what could be the best way to do? I keep on bumping Error 26 when manually connecting using 'hostname\MSSQLSERVER' but successfully connected using 'AGGroup\MSSQLSERVER'.
Thanks.

This one might have been answered before, or something similar to it, but not sure. 🤔 Have you check other issues around SqlAG and SqlAGReplica for similar problems?

Hi @johlju, thanks for the reply.
Yes, I was able to Create AG using the SqlAG on the Primary node. However, I'm unable to add replica using the SqlAGReplica in the Secondary node. I used the same credentials on both Primary and Secondary nodes. I followed the steps from #910 and using the default port 5022 for SQLServerEndpoint. I can relate this to the #1220 issue. I am still getting failed to connect to instance error remotely. Appreciate if you can provide me a link to the answered issues? Thanks.

Hi, just an update. I found the solution with this one. Turns out this is Firewall problem between my Primary and Secondary nodes. Thanks.
Resolved using the following link: https://www.sqlserverlogexplorer.com/fix-error-code-26/#

Thank you for the update @emyatsuna, this will help other users too.


Origin warping

Some occurrence of events keeps some/all users back to origin in an unknown state.
Seems likely now from mqtt.js: onConnectionLost(). But What is causing dropped connection?

Found causes of warp, weird zombie state:

[x] Something from 9/29 group mtg.
[x] Something from 10/1 review mtg.
[x] Failure to parse schema from message format, bad image src, ...
[x] Failure to reconnect/resubscribe, without re-init user state

Found 2 error messages (not from logs) that will cause a warp. The downtown image is not found at the url. Something in mqtt parsing fires onConnectionLost(), we were then rightly reconnecting to the broker. However, were were also calling onConnect() again, which is probably a no-no since we use it as our user initialization, set to origin location and start a bunch of other state from scratch. We never need to call onConnect twice, maybe we should add a new parameter to onConnect(init=false)
mosquitto_pub -h arena.andrew.cmu.edu -t realm/s/example/my_image_floor -m '{"object_id": "my_image_floor", "action": "create", "type": "object", "persist": false, "data": {"object_type": "image", "position": {"x": 0, "y": 0, "z": 0.4}, "rotation": {"x": -0.7, "y": 0, "z": 0, "w": 0.7}, "scale": {"x": 12, "y": 12, "z": 12}, "color": "#ffffff", "url": "images/floor.png", "material": {"repeat": {"x": 4, "y": 4}}}}'
mosquitto_pub -h arena.andrew.cmu.edu -t realm/s/example/my_image_floor -m '{"object_id": "my_image_floor", "action": "create", "type": "object", "persist": false, "data": {"object_type": "image", "position": {"x": 0, "y": 0, "z": 0.4}, "rotation": {"x": -0.7, "y": 0, "z": 0, "w": 0.7}, "scale": {"x": 12, "y": 12, "z": 12}, "color": "#ffffff", "material": {"src": "https://arena.andrew.cmu.edu/abstract/downtown.png"}}}'

Above, fixed in #86. I'm still looking for more causes of warps.

Careful reconnect added https://github.com/conix-center/ARENA-core/pull/91

Added onMessageArrived() try/catch to log these errors and avoid tripping onConnectionLost() in https://github.com/conix-center/ARENA-core/commit/3a31b5696c4a183f2c46ddc7e57832042b1d4541

#96 and #97 are samples of what was causing warping originally in the meetings mentioned above.


UPDATE statement does nothing at all

PHP Driver version or file name

5.9.0

SQL Server version

SQL Server Standard 2019 (15.0.2080.9) running on Windows Server 2019 Standard

Client operating system

openSUSE Linux 15.2

PHP version

7.4.6

Microsoft ODBC Driver version

17

Problem description

I've been trying to make UPDATE statements to work, but do anything, although there is no error messages.
The SELECT and INSERT statements work fine.

My code:
    $sentenciaQueryUpdate = "UPDATE Contrato SET Estatus='?' WHERE MovID = '?' AND Cliente = '?';";
    $lecturaIni = parse_ini_file($nombreINI, true);

    $dataBase = $lecturaIni['database'];
    $usuario    = $lecturaIni['user'];
    $password = $lecturaIni['password'];

    $connectionOptions = array("Database"  => $dataBase,
                               "UID"                              => $usuario,
                               "PWD"                            => $password,
                               "ReturnDatesAsStrings" => true,
                               "Driver"                          => 'ODBC Driver 17 for SQL Server');

    $connection        = sqlsrv_connect($lecturaIni['dsn'], $connectionOptions);

    if ($connection === false)
        {
        echo '';
        echo "
Error de SQL
";
        echo 'Error en la conexion SQL SERVER a ' . $dataBase;
        echo "
";
        $errors = sqlsrv_errors();

        foreach ($errors as $error)
            {
            echo "SQLSTATE: " . $error['SQLSTATE'] . "
";
            echo "Código: "   . $error['code']     . "
";
            echo "Mensaje: "  . $error['message']  . "
";
            }

        die('');
        }

    $parameters = [$estatusNuevo, $contratoBusqueda, $clienteBusqueda];
    $statement  = sqlsrv_prepare($connection, $sentenciaQueryUpdate, $parameters);

    var_dump($statement);
    echo '
';

    if(!$statement)
        {
        die( print_r( sqlsrv_errors(), true));
        }

    $ejecucion = sqlsrv_execute($statement);

    var_dump($ejecucion);

    if($ejecucion === false)
        {
        die(print_r( sqlsrv_errors(), true));
        }

    sqlsrv_close($connection);

I'm using sqlsrv_prepare and sqlsrv_execute because I thought that sqlsrv_query was the problem in this issue.
Please, some guidance about what is going on.
Thanks in advance.

Hi @rvizuet
Please try calling sqlsrv_rows_affected() after sqlsrv_execute()
What's the fetched result of a select statement like this and supply the same input parameters for MovID and Cliente?
SELECT Estatus FROM Contrato WHERE MovID = '?' AND Cliente = '?';

Hi @yitam,
Thanks for your quick answer =)
The results of my execution are:

sqlsrv_prepare results: resource(9) of type (SQL Server Statement)
sqlsrv_execute results: bool(true)
sqlsrv_rows_affected results: 0
Now, the results of a SELECT Estatus FROM Contrato WHERE MovID = 'SRCB3701' AND Cliente = '0001757' are:

BAJA

Only the record I need to be updated... exactly that one.

Hi @rvizuet please check if the returned value of sqlsrv_rows_affected() is 0 or false, like this. If false, please check the errors.
$rows_affected = sqlsrv_rows_affected( $stmt);
if( $rows_affected === false)  {
}

Good morning @yitam,
This is what I'm doing regarding to sqlsrv_rows_affected:
 $rows_affected = sqlsrv_rows_affected($statement);

    if($rows_affected === false)
        {
        echo "
Error in calling sqlsrv_rows_affected.
";
        die(print_r(sqlsrv_errors(), true));
        }
    else if($rows_affected == -1)
        {
        echo "
No information available.
";
        }
    else
        {
        echo '
sqlsrv_rows_affected result: ' . $rows_affected;
        }

But it doesn't return false, it returns zero.

Hi @rvizuet in this case please provide odbc trace. You can trying running the same script using command line instead of a browser

My bad, @rvizuet , I didn't realize that you have used single quotes for the UPDATE statement. Please try this
$sentenciaQueryUpdate = "UPDATE Contrato SET Estatus=? WHERE MovID = ? AND Cliente = ?";

Hi @yitam,
I just removed the single quotes but the results are the same:

sqlsrv_prepare: resource(9) of type (SQL Server Statement)
sqlsrv_execute: bool(true)
sqlsrv_rows_affected: 0

The column wasn't updated with the new value.

Did you remove all single quotes, @rvizuet? How do you check if the column is updated? Run a new select query or use Management Studio?
Anyway, please provide ODBC trace if possible.

Hi @yitam,
This is my code, the way it is now:
$sentenciaQueryUpdate = "UPDATE Contrato SET Estatus=? WHERE MovID=? AND Cliente=?;";

And after the UPDATE, I check the row in Management Studio with:
       Cliente,
	   Estatus
  FROM Contrato
 WHERE MovID = 'SRCB3701'
   AND Cliente = '0001757'```

The results are:
![SELECTresults](https://user-images.githubusercontent.com/84986243/122441720-749b9f80-cf63-11eb-9a69-ad0355654e79.png)

Hi @yitam,
This is my code, the way it is now:
$sentenciaQueryUpdate = "UPDATE Contrato SET Estatus=? WHERE MovID=? AND Cliente=?;";

And after the UPDATE, I check the row in Management Studio with:
       Cliente,
	   Estatus
  FROM Contrato
 WHERE MovID = 'SRCB3701'
   AND Cliente = '0001757'```

The results are:
MovID	  Cliente	    Estatus
SRCB3701  0001757    BAJA

It seems we are not going anywhere, @rvizuet, so please provide odbc trace (run your php script in command line).
Last try: what are the field types for those columns? varchar, char, nvarchar?
Please add this block to your script before the update:
$contratoBusqueda = 'SRCB3701';
$clienteBusqueda = '0001757';
$parameters = [$contratoBusqueda, $clienteBusqueda];
$tsql = "SELECT Estatus FROM Contrato WHERE MovID=? AND Cliente=?";
$stmt = sqlsrv_query($conn, $tsql, $parameters);
if (sqlsrv_fetch($stmt) === false) {
    die(print_r(sqlsrv_errors(), true));
}
$value = sqlsrv_get_field($stmt, 0);
var_dump($value);

Sorry @yitam, I'm gonna try to get the odbc trace, using the command line and adding your code... Please be patient because I've never did it before.
In the meantime, let me give you the characteristics of the columns involved:
MovID - varchar(20)
Cliente - varchar(10)
Estatus - char(15)
Thanks

Hello again @yitam,
Finally I could get the ODBC trace!
The results of the executions are:
SELECT results:

string(15) "BAJA           "

sqlsrv_prepare: resource(7) of type (SQL Server Statement)

sqlsrv_execute: bool(true)

sqlsrv_rows_affected: 0

I'm attaching the odbctrace.log
odbctrace.log

Thanks @rvizuet for the trace! SQLExecute does return SQL_NO_DATA. So I have several more questions:

What is your database collation?
What is the new value for column Estatus (from "BAJA" to ??)? What are the typical values in this column?
Please try connecting with UTF-8, as shown below, and see if there's any difference.

$connectionOptions = array("Database"  => $dataBase,
                               "UID"                              => $usuario,
                               "PWD"                            => $password,
                               "ReturnDatesAsStrings" => true,
                               "CharacterSet"               => "UTF-8",
                               "Driver"                          => 'ODBC Driver 17 for SQL Server');

$connection        = sqlsrv_connect($lecturaIni['dsn'], $connectionOptions);

I will try to reproduce this on my side too.

Hi @yitam,
My database collation is: Modern_Spanish_CI_AS.
The value for Estatus has never changed, no matter how many UPDATES I run. It is still "BAJA".
The Typical values for this column are: BAJA, SINAFECTAR, VIGENTE, VENCIDO and CANCELADO
I reconnected using UTF-8 but there's no difference... The Estatus column value didn't change.

Thank you @rvizuet
We can reproduce this on our side. We will get back to you after some investigation.

Thanks a lot, @yitam. I'll be pending or you answer.
Good afternoon!

Sorry to disappoint you @rvizuet . There was a mistake with my repro script (see below) and once I fixed it I can no longer reproduce the UPDATE problem.
sqlsrv_1270.php.txt
I've tried in Windows, Ubuntu 18.04 and opensuse 15:

I changed the collation to the one you used:

This is my odbc trace (see line 598, SQLExecute returned SQL_SUCCESS instead of SQL_NO_DATA like yours):
odbc.log
Can you try running my repro script on your side?

Good morning @yitam,
I already did the test using your script. The only thing is I'm creating this new table Contratorri, because in Contrato I have thousands of records and I cannot drop this table, so I made a new one.
Surprisingly, the UPDATE works fine over this new table Contratorri, but over my old Contrato does not....

I'm thinking that Contrato has a trigger programming, so when I make changes directly from Management Studio, I can see the multiple lines of rows affected in some other tables. Do you think this might be causing the UPDATE does not work on it?... if this is the case, what should I do?
I attach for you the new odbctrace (with Contratorri table):
odbctrace3.log

Hi @rvizuet , if triggers have been created, then it's likely affecting your particular table(s) or column(s). My simple script proves that the current PHP (ODBC) drivers work with updating a regular table column.
Thus, I'm afraid this is beyond our support.  You might need to discuss with your DBA or the one who has created the trigger(s).

OK @yitam,
I appreciate your time and effort. If I can find the way to solve it, I'll let you know.
Thanks a lot.

Hi again, @yitam,
I continued doing some tests and finally could solve something I think worked for me. It's a little funny and I don't understand what is really happening. The point is as you'll see in the next two code blocks.
First (original) does not work:
$conn = sqlsrv_connect($server, $connInfo);

$sql        = "UPDATE Contrato SET Estatus=? WHERE MovID=? AND Cliente=?";
$parameters = [$nuevoEstatus, $contratoBusqueda, $clienteBusqueda];
$stmt       = sqlsrv_query($conn, $sql, $parameters);

$nrows      = sqlsrv_rows_affected($stmt);

sqlsrv_free_stmt($stmt);
sqlsrv_close($conn);

This first script tries to do the UPDATE directly, but does not work.
Second (modified) does work:
$conn = sqlsrv_connect($server, $connInfo);

$parameters = [$contratoBusqueda, $clienteBusqueda];

$sql  = "SELECT Estatus FROM Contrato WHERE MovID = ? AND Cliente = ?";
$stmt = sqlsrv_prepare($conn, $sql, $parameters);
$res  = sqlsrv_execute($stmt);

if (sqlsrv_fetch($stmt) === false)
    {
    die(print_r(sqlsrv_errors(), true));
    }

$value = sqlsrv_get_field($stmt, 0);

$sql        = "UPDATE Contrato SET Estatus=? WHERE MovID=? AND Cliente=?";
$parameters = [$nuevoEstatus, $contratoBusqueda, $clienteBusqueda];
$stmt       = sqlsrv_query($conn, $sql, $parameters);

$nrows      = sqlsrv_rows_affected($stmt);

sqlsrv_free_stmt($stmt);
sqlsrv_close($conn);

In this second script I included a SELECT statement previous to do the UPDATE and it DOES work.
How is it possible?.... I don't know but it works.
Anyway, I'm gonna let it this way because it's doing fine. I have an extra SELECT I don't need, but...
I just wanted to share this with you.
Thanks!

Hi @rvizuet I suspect this is something to do with cursor(s) and trigger(s). The trigger(s) might be the reason behind your other problem (#1263), which explains why server-side cursors did not work for you.
I suggest you dig deeper rather than looking for workarounds, which probably work until the triggers change again. That being said, do you have any other questions specifically related to our drivers?

Thanks, @yitam, for your feedback. The only thing I would like to ask is if there's some book or site you recommend to enrich SQL Server knowledge in order to solve the issues I have.

Hi @rvizuet
Please start with DML Triggers. There are other websites too for DBAs but you might need to search around.

You're so kind, @yitam.
Thanks for your time.


Implement "Persistent" Side Nav v2 Component

Spec reference: https://www.google.com/design/spec/patterns/navigation-drawer.html
"Persistent" drawers are the ones that remain on the page yet collapse into miniature drawers when not being used.

Superceded by https://github.com/material-components/material-components-web/issues/15


Add Guest Integration Services support

Now that the Guest Integration Services support is enabled in the bundled xHyper-V DSC resource, it would be good to expose this as an option.
Question is: Should this be ON by default?

Given it adds the capability to use the Copy-VMFile cmdlet to copy files into a VM  - I would say Yes

@MS-MatthewWalker I think I'll add it, but won't set it to ON by default. This mimics the default behaviour and you can always enable it by default with Set-LabVMDefault if wanted.


Update system admin user guide on how to use GEOPM configuration files to select agent and policies for all jobs using the GEOPM runtime

estimate 2

Parent story #806
Done criterion
Skeleton files created by #880 to fill in section on this topic.

Merged with #888.


format of MasterInfo stored in ZK nodes will change in mesos v0.24

From the user/dev mailing list:

Folks,
as heads-up, we are planning to convert the format of the MasterInfo
information stored in ZooKeeper from the Protocol Buffer binary format to
JSON - this is in conjunction with the HTTP API development, to allow
frameworks not to depend on libmesos and other binary dependencies to
interact with Mesos Master nodes.
NOTE - there is no change in 0.23 (so any Master/Slave/Framework that is
currently working in 0.22 will continue to work in 0.23 too) but as of
Mesos 0.24, frameworks and other clients relying on the binary format will
break.
The details of the design are in this Google Doc:
https://docs.google.com/document/d/1i2pWJaIjnFYhuR-000NG-AC1rFKKrRh3Wn47Y2G6lRE/edit
the actual work is detailed in MESOS-2340:
https://issues.apache.org/jira/browse/MESOS-2340
and the patch (and associated test) are here:
https://reviews.apache.org/r/35571/
https://reviews.apache.org/r/35815/

0.24 is coming out very soon, this needs to be prioritised.

/cc @jdef

Did we already pass the deprecation cycle? Protobuf for master info is
completely gone in v0.24?
On Mon, Sep 7, 2015 at 2:52 PM, Tomás Senart<EMAIL_ADDRESS>wrote:

/cc @jdef https://github.com/jdef
—
Reply to this email directly or view it on GitHub
https://github.com/mesos/mesos-go/issues/141#issuecomment-138357237.

should be fixed by #174


devcrypto engine: library deinit functions appear to be in wrong order

Hello,
I built the latest openssl master (commit ID 3c957bcd54d097167e53660fa100aa1ba85d63b5) which has devcrypto engine support. It mostly seems to work fine, but noticed a hang while testing openssl speed with the devcrypto engine on an ARM platform. The test itself passes fine, but hangs at closing down the openssl libraries. For example:
openssl speed -evp aes-256-cbc -engine devcrypto -elapsed
[   93.519151] cryptd: max_cpu_qlen set to 1000
engine "devcrypto" set.
You have chosen to measure elapsed time instead of user CPU time.
Doing aes-256-cbc for 3s on 16 size blocks: 757364 aes-256-cbc's in 2.99s
Doing aes-256-cbc for 3s on 64 size blocks: 593933 aes-256-cbc's in 3.00s
Doing aes-256-cbc for 3s on 256 size blocks: 67348 aes-256-cbc's in 3.00s
Doing aes-256-cbc for 3s on 1024 size blocks: 39539 aes-256-cbc's in 3.00s
Doing aes-256-cbc for 3s on 8192 size blocks: 11265 aes-256-cbc's in 3.00s
Doing aes-256-cbc for 3s on 16384 size blocks: 6028 aes-256-cbc's in 3.00s
version: 3.0.0-dev
built on: built on: Tue Nov 26 14:27:19 2019 UTC
options:bn(64,32) rc4(char) des(long) aes(partial) idea(int) blowfish(ptr)
compiler: arm-linux-gnueabihf-gcc -fPIC -pthread
 -Wall -O3 -DOPENSSL_USE_NODELETE -DOPENSSL_PIC -DNDEBUG -DL_ENDIAN
CPUINFO: N/A
The 'numbers' are in 1000s of bytes per second processed.
type             16 bytes     64 bytes    256 bytes   1024 bytes   8192 bytes  1
6384 bytes
aes-256-cbc       4052.78k    12670.57k     5747.03k    13495.98k    30760.96k
  32920.92k

... and nothing after that. Hitting ctrl-c gets out of this though.
I did debug this locally and the code gets stuck at CRYPTO_THREAD_write_lock, waiting for a lock that has been destroyed already. Re-ordering de-init calls appears to fix the issue, see the attached patch.
0001-cleanup-re-order-default-context-cleanup-and-engine-.patch.txt

Marking as inactive, to be closed at the end of 3.4 dev, barring further input


ROS2 galactic, ign fortress, find_package(geometry_msgs REQUIRED)

I found that in order to compile (colcon build) successfully on ROS2, ros_ign_gazebo/CMakeLists.txt needs to be modified:
find_package(geometry_msgs REQUIRED)
ament_target_dependencies(create
  rclcpp
  ignition-math6
  geometry_msgs
)

Otherwise, it results in a linking error:
undefined reference to `rosidl_message_type_support_t const* rosidl_typesupport_cpp::get_message_type_support_handle<std_msgs::msg::String_<std::allocator<void> > >()'

What branch are you on? And what ROS version are you using?

branch: ros2
ROS2 version: galactic
ignition version: fortress

The galactic branch has the same problem.  It needs the same modification to compile for me.

I just re-ran our CI and it compiled fine. I wonder what's different on your setup.
https://github.com/ignitionrobotics/ros_ign/runs/5428022992?check_suite_focus=true

Any information I can provide to help debug this?  Please let me know.  I'm no expert.  I got the idea to add geometry_msgs to solve my problem from this page: https://answers.ros.org/question/315023/ros2-debugging-techniques/

std::msgs added to the ros2 branch in https://github.com/gazebosim/ros_gz/pull/242


Error while using DeepFace.analyze when trying to detect emotion

I am getting the below error while trying to predict emotion using DeepFace.analyze
ValueError: Input 0 of layer sequential is incompatible with the layer: : expected min_ndim=4, found ndim=3. Full shape received: (None, 48, 48)

This the complete error:
facial_expression_model_weights.h5 will be downloaded...
Downloading...
From: https://github.com/serengil/deepface_models/releases/download/v1.0/facial_expression_model_weights.h5
To: /home/ubuntu/.deepface/weights/facial_expression_model_weights.h5
100%|█████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████| 5.98M/5.98M [00:00<00:00, 13.9MB/s]
Action: emotion:   0%|                                                                                | 0/1 [00:00<?, ?it/s]
Traceback (most recent call last):
File "", line 1, in
File "/home/ubuntu/AI/project_environments/retina_deep_face_env/lib/python3.6/site-packages/deepface/DeepFace.py", line 277, in analyze
emotion_predictions = models['emotion'].predict(img_gray, verbose=0)[0,:]
File "/home/ubuntu/AI/project_environments/retina_deep_face_env/lib/python3.6/site-packages/keras/engine/training.py", line 1751, in predict
tmp_batch_outputs = self.predict_function(iterator)
File "/home/ubuntu/AI/project_environments/retina_deep_face_env/lib/python3.6/site-packages/tensorflow/python/eager/def_function.py", line 885, in call
result = self._call(*args, **kwds)
File "/home/ubuntu/AI/project_environments/retina_deep_face_env/lib/python3.6/site-packages/tensorflow/python/eager/def_function.py", line 933, in _call
self._initialize(args, kwds, add_initializers_to=initializers)
File "/home/ubuntu/AI/project_environments/retina_deep_face_env/lib/python3.6/site-packages/tensorflow/python/eager/def_function.py", line 760, in _initialize
*args, **kwds))
File "/home/ubuntu/AI/project_environments/retina_deep_face_env/lib/python3.6/site-packages/tensorflow/python/eager/function.py", line 3066, in _get_concrete_function_internal_garbage_collected
graph_function, _ = self._maybe_define_function(args, kwargs)
File "/home/ubuntu/AI/project_environments/retina_deep_face_env/lib/python3.6/site-packages/tensorflow/python/eager/function.py", line 3463, in _maybe_define_function
graph_function = self._create_graph_function(args, kwargs)
File "/home/ubuntu/AI/project_environments/retina_deep_face_env/lib/python3.6/site-packages/tensorflow/python/eager/function.py", line 3308, in _create_graph_function
capture_by_value=self._capture_by_value),
File "/home/ubuntu/AI/project_environments/retina_deep_face_env/lib/python3.6/site-packages/tensorflow/python/framework/func_graph.py", line 1007, in func_graph_from_py_func
func_outputs = python_func(*func_args, **func_kwargs)
File "/home/ubuntu/AI/project_environments/retina_deep_face_env/lib/python3.6/site-packages/tensorflow/python/eager/def_function.py", line 668, in wrapped_fn
out = weak_wrapped_fn().wrapped(*args, **kwds)
File "/home/ubuntu/AI/project_environments/retina_deep_face_env/lib/python3.6/site-packages/tensorflow/python/framework/func_graph.py", line 994, in wrapper
raise e.ag_error_metadata.to_exception(e)
ValueError: in user code:
/home/ubuntu/AI/project_environments/retina_deep_face_env/lib/python3.6/site-packages/keras/engine/training.py:1586 predict_function  *
    return step_function(self, iterator)
/home/ubuntu/AI/project_environments/retina_deep_face_env/lib/python3.6/site-packages/keras/engine/training.py:1576 step_function  **
    outputs = model.distribute_strategy.run(run_step, args=(data,))
/home/ubuntu/AI/project_environments/retina_deep_face_env/lib/python3.6/site-packages/tensorflow/python/distribute/distribute_lib.py:1286 run
    return self._extended.call_for_each_replica(fn, args=args, kwargs=kwargs)
/home/ubuntu/AI/project_environments/retina_deep_face_env/lib/python3.6/site-packages/tensorflow/python/distribute/distribute_lib.py:2849 call_for_each_replica
    return self._call_for_each_replica(fn, args, kwargs)
/home/ubuntu/AI/project_environments/retina_deep_face_env/lib/python3.6/site-packages/tensorflow/python/distribute/distribute_lib.py:3632 _call_for_each_replica
    return fn(*args, **kwargs)
/home/ubuntu/AI/project_environments/retina_deep_face_env/lib/python3.6/site-packages/keras/engine/training.py:1569 run_step  **
    outputs = model.predict_step(data)
/home/ubuntu/AI/project_environments/retina_deep_face_env/lib/python3.6/site-packages/keras/engine/training.py:1537 predict_step
    return self(x, training=False)
/home/ubuntu/AI/project_environments/retina_deep_face_env/lib/python3.6/site-packages/keras/engine/base_layer.py:1020 __call__
    input_spec.assert_input_compatibility(self.input_spec, inputs, self.name)
/home/ubuntu/AI/project_environments/retina_deep_face_env/lib/python3.6/site-packages/keras/engine/input_spec.py:234 assert_input_compatibility
    str(tuple(shape)))

ValueError: Input 0 of layer sequential is incompatible with the layer: : expected min_ndim=4, found ndim=3. Full shape received: (None, 48, 48)

Are you using gray scale image?

No I am not using grayscale and the same image is giving correct o/p for other actions such as age, gender etc.

would you please share the image?

interesting. i am able to get emotion results.
{
    "emotion": {
        "angry": 12.318268418312073,
        "disgust": 1.4325009658932686,
        "fear": 70.27139067649841,
        "happy": 0.6975821685045958,
        "sad": 9.985145181417465,
        "surprise": 0.24122511968016624,
        "neutral": 5.053892731666565
    },
    "dominant_emotion": "fear",
    "region": {
        "x": 121,
        "y": 74,
        "w": 116,
        "h": 116
    },
    "age": 45,
    "gender": {
        "Woman": 0.04243064031470567,
        "Man": 99.9575674533844
    },
    "dominant_gender": "Man",
    "race": {
        "asian": 2.141670323908329,
        "indian": 3.8179349154233932,
        "black": 1.2815571390092373,
        "white": 37.041547894477844,
        "middle eastern": 23.6214816570282,
        "latino hispanic": 32.09580481052399
    },
    "dominant_race": "white"
}

i am firstly using tensorflow==2.7.4.
besides, would you please use the source code instead of pip version?
$ git clone https://github.com/serengil/deepface.git
$ cd deepface
$ pip install -e .

In my environment I have installed bot retina-face and deepface and installed tensorlow is 2.6.2.
Okay will try the installing it from source.
Thanks

and python 3.6.8

@monumahali, also please check your Python version.
Take a look at #674

Thanks, @ekkolon and @serengil for your help. It was related to the python version... Changed the python version and it's working fine now.


Play whatever a user is listening to on spotify

The bot will see what timestamp of a music a user is at through their discord profile with their Spotify connected and play the music with the timestamp sync on a voice channel.

It will use a lot of ressource but can be possible for a little bot. I'll maybe add it in dev


Switch default ECS service resource to Custom::ECSService.

This has been working pretty well on the apps that we've enabled it on, and the overall user experience will be better (especially in cases where rollback is necessary).
I think this should be merged before we release 0.11.0, but I don't plan on merging this until we've manually switched our applications over to Custom::ECSService, since it potentially incurs some downtime when the old ECS services are destroyed.

This can probably be safely merged now that https://github.com/remind101/empire/pull/878 was merged, but I'll try doing it manually on a couple apps in production to make sure there's no downtime.

For the record, also moved prod apps to this with 0 downtime

👍


Share dropdown should have a shadow or border

Should be differentiated visually somehow on active.
See:

Thanks @abdullahsalem for the PR! Closing in favor of https://github.com/zurb/building-blocks/pull/83


Fix misaligned size

Try too fix DESCRIPTION_MISALIGNED_SIZE error when cia network install.

Can you confirm this fixes the issue? Seems like a big chunk of code to add, so I just want to get confirmation it works.

Not very sure, I will install some cia files to test later.
All cia files is aligned by 64 bytes, is it right?

Update test info:
I test it on n3ds with gw3d 9.5.0 system.
I have installed two cia files use FBI via network, one 300M, one 600M.
Without this path, I cann't install any large cia via network.


[Discovery] Allow JSON to pass-through to calling method

Right now the SDK can produce significantly large heap sizes while serializing/deserializing JSON responses. Many times with large documents we are getting https://salesforce.stackexchange.com/questions/143598/exceeded-max-size-limit-of-6000000
I think to buy us some time, we could potentially pass the JSON response (in this case Discovery) directly to the calling method with a parameter of some sort like raw = true or a different method like queryRaw that just returns the response body as-is instead of attempting to deserialize it.
When reporting a bug, please be sure to include the following

[X] Salesforce version: Fall 2018
[X] SDK version: 2.9.0
[X] Steps to reproduce: using Watson Discovery, make a query that produces a fairly large response/result set - when the response exceeds 6MB, it fails
[X] Expected behavior: the apex code errors out with large JSON responses
[X] Actual behavior: the apex code doesn't error out with large JSON responses

When you open an issue for a feature request, please add as much detail as possible

[X] A descriptive title starting with the service name: Conversation, Discovery...
[X] A description of the problem you're trying to solve: see above
[X] A suggested solution if possible: see above

We are not going to support this. Happy to review. PR


Presto engine spec broken - Date column mapped to Datetime

Presto engine spec seems broken in 1.3.1 as DATE presto types are mapped to DATETIME sqlalchemy types which are not supported by the Presto engine spec.
How to reproduce the bug

Install 1.3.1
Sync column tables in Superset for a table that has a DATE column
Check the Superset type of the column, should be DATETIME

Expected results
Querying a Presto table with a time range should work.
Actual results
This will prevent Superset from query the table with time constraints. The query will return Cannot apply operator: date >= varchar(26) error. When looking at the generated query, temporal predicates do not get included in date conversion function, i.e.:
WHERE "eventdate" >= '2021-09-18 00:00:00.000000'
  AND "eventdate" < '2021-10-18 12:35:33.000000'

While it should be - and in prior versions was - :
WHERE "eventdate" >= from_iso8601_date('2021-09-18 00:00:00.000000')
  AND "eventdate" < from_iso8601_date('2021-10-18 12:35:33.000000')

Environment

superset version: 1.3.1
Presto version: 343
pyhive version: 0.6.4
python version: 3.7

Additional context
It seems like the issue comes from the Presto engine spec mapping Dates to Datetime in sqlalchemy (see this line) while the convert_dttm does not support DATETIME (see here).
Note that with past versions, DATE presto columns mapped to DATE Sqlalchmy columns.

Tried the following patch and it solves this particular issue. Date columns in Presto are mapped to DATE columns in SQLAlchemy.
--- presto.py	2021-10-18 11:28:52.466574000 -0400
+++ presto-patched.py	2021-10-18 11:32:53.766105000 -0400
@@ -508,7 +508,7 @@
         ),
         (
             re.compile(r"^date.*", re.IGNORECASE),
-            types.DATETIME(),
+            types.DATE(),
             utils.GenericDataType.TEMPORAL,
         ),
         (

@villebro, I see this being changed as part of this PR.
If you want to retain the DATETIME columns, another alternative would be to update the convert_dttm function to support DATETIME.

I run Superset in a sandboxed corporate environment so not easy to create a PR. So there seems to be to solutions:

Revert the conversion of SQL DATE types to Python DATE() types
Change the convert_dttm method to accept DATETIME().

1 may break the date adhoc filter (that you fixed in the previous PR).
I tried 2 with this patch:
--- presto.py	2021-11-02 17:46:57.561409000 -0400
+++ presto-patched.py	2021-11-02 17:49:27.742966000 -0400
@@ -748,7 +748,7 @@
         tt = target_type.upper()
         if tt == utils.TemporalType.DATE:
             return f"""from_iso8601_date('{dttm.date().isoformat()}')"""
-        if tt == utils.TemporalType.TIMESTAMP:
+        if tt == utils.TemporalType.TIMESTAMP or tt == utils.TemporalType.DATETIME:
             return f"""from_iso8601_timestamp('{dttm.isoformat(timespec="microseconds")}')"""  # pylint: disable=line-too-long
         return None

That "works" but does have a side effect. The queries now include CURRENT_DATE as
SELECT
  CURRENT_DATE,
  CURRENT_DATE < from_iso8601_timestamp('2021-11-02T22:16:38.000000')

Returns:
2021-11-02
true

So that's quite a breaking change as all existing dashboards are built with the assumption that today is excluded.


Lanelet2 for Waterways

I would like to create a Lanelet2 map consisting of waterways and regulatory navigation signs. Basically an extension of lanelet2_maps.
Are there any approaches to this that I haven't found yet?
Is it enough to modify lanelets.mapcss, lines.mapcss and laneletpresets.xml and insert the new traffic sign images?

I am not aware of any existing approaches in this direction, but the files you mentioned are just related to the visualization of elements in JOSM. If you only want to change the visualization, changing these should be enough.


Typegen - Fix generated Factory code

Ensure that loggedTypes property is present in the _abi property on the generated Factory code class.
Currently, it is being left out, and this is causing problems.

Ref: https://discord.com/channels/732892373507375164/1034937869736878160/1042901705949450271

Note to self: This will be firstly patched on the old typegen package. The new version did it right from the beginning, so everything will be fine when we swap them.


Boilerplate Update & re-generate test harness

What type of PR is this?
(bug/feature/cleanup/documentation/test/refactor)
test
What this PR does / why we need it?

boilerplate update
make boilerplate-update

test harness re-generate - uses new osde2e image
 make e2e-harness-generate

Which Jira/Github issue(s) this PR fixes?
SDCICD-1415

/test images

/lgtm
/approve


Video textures don't render on Firefox Android 106

Forum: https://forum.playcanvas.com/t/video-texture-does-not-work-under-ff-for-android/25344
Test project: https://playcanvas.com/project/405850/overview/tutorial-video-textures
The video texture just stays black and has the following warning:
WebGL warning: tex(Sub)Image[23]D: Failed to retrieve source bytes for CPU upload. [playcanvas-stable.min.js:6:323810](https://s3-eu-west-1.amazonaws.com/apps.playcanvas.com/Z0FlzPma/playcanvas-stable.min.js)
WebGL warning: generateMipmap: The texture's base level must be complete. [playcanvas-stable.min.js:6:324479](https://s3-eu-west-1.amazonaws.com/apps.playcanvas.com/Z0FlzPma/playcanvas-stable.min.js)

Works fine on FF 99 Desktop. I've also tried disabling mipmaps on the texture and reducing the texture upload rate to once per second and neither helped

No longer an issue with the latest version of FF

@yaustar This issue should be re-opened. The problem happens on Firefox for Android.

Confirmed not working on build 106

Works fine on Pixel 8 Pro, Android 126.0


1.9.0 is broken

Thanks for the great library, we are using it well in our projects.
Currently (v1.9.0) for the simplest case, the lintCode.js file is breaking generation. It seems as though it is attempting to lint the client as a javascript file instead of a typesript file. Here is a minimal reproduction of the error:
https://gist.github.com/andy-viv/8004ff39407f6d2fa14c8c4d14d36a2f
The error that occurs:
            throw new Error(`${error.reason} in ${error.evidence} (${error.code})`);
            ^

Error: Unexpected 'type'. in export type RequestHeaders = { (E024)
    at lint.errors.forEach (/Users/andrew.perlitch/repos/stg-test/node_modules/swagger-typescript-codegen/lib/enhance/lintCode.js:22:19)
    at Array.forEach (<anonymous>)
    at Object.lintCode (/Users/andrew.perlitch/repos/stg-test/node_modules/swagger-typescript-codegen/lib/enhance/lintCode.js:20:17)
    at Object.enhanceCode (/Users/andrew.perlitch/repos/stg-test/node_modules/swagger-typescript-codegen/lib/enhance/index.js:7:20)
    at Object.getTypescriptCode (/Users/andrew.perlitch/repos/stg-test/node_modules/swagger-typescript-codegen/lib/codegen.js:18:26)
    at Object.<anonymous> (/Users/andrew.perlitch/repos/stg-test/generate.js:6:28)
    at Module._compile (module.js:662:30)
    at Object.Module._extensions..js (module.js:673:10)
    at Module.load (module.js:575:32)
    at tryModuleLoad (module.js:515:12)

For now I am locking the version of swagger-typescript-codegen in my package.json to 1.8.1.
Are tests run on PR? I took the spec.json in the gist above directly from the test fixtures in this repo.
Also, I am noticing a strange discrepancy between npm versions and the releases on github. Perhaps check that you are tagging/releasing appropriately.
Regards

Thanks for reporting! This is strange, will take a look after the weekend.
Tests are run on PRs, but this might not be covered.
Re. versioning - I did some testing of publishing via Github and travis, but decided on not using that yet, which is probably why the versioning is inconsistent. I deleted the github tags now to clean it up. 1.9.0 is the correct latest version

We were discussing the removal of ESLint/jshint in the internal typescript rewrite, as it doesn't really make any sense since this project is only generating TS code anyway. I have created a PR for removing JS linting from the pipeline (#60), which fixes the issue.
We should look into adding a TSLint option ofc, but that can be done later

@andy-viv 1.9.2 published with the fix

Thanks @mtennoe, testing now!


Custom data

My data is of this shape (6,53,1,100,100). how can i feed it into the models proposed in the OpenSTL.

Remove reduplicative issues. Please refer to openstl/examples/tutorial.ipynb.


Dapp tool + others

@nmushegian @apmilen
So I've made a new branch and worked on the changes again because for some reason I lost the link between the previous PR and my repo.
This PR includes:

Upgrade last DSToken
Replace DSActor to last DSExec
Adapting structure for using dapp tool
Simplifying Wrapper Contract code using tryExec alias + DSMath functions.

Only doubt I have is about the real need of using DSExec. Not sure if we should use it (still do not get well why) or just do assert(msg.sender.send(value)); as the w-eth repo does.

I think we should:

consolidate into weth (or maybe evends-weth) repo
I really strongly prefer .call over .send, I think the wrapper should use it
DSExec has less verbose alias with 1 less arg tryExec(msg.sender, value), if we choose to use it
I think wrap and unwrap should be official aliases for deposit/withdraw

@apmilen @dbrock thoughts

if we're using imports might as well use DSMath (meaning remove the redundant safeAdd)? if not then yeah we should remove not just Exec but also Token and ERC20 dependency...

@nmushegian

In this PR it is already using the DSMath functions and I've removed the redundant safeAdd and safeSub.
In this PR it is also using the simplified tryExec with the only two parameters.
I think it makes sense to add the aliases wrap and unwrap.


New example to contribute

Link to your repo
https://github.com/vgoliber/airline-hubs/
Topic: Choosing airports for airline hubs
A challenging optimization problem in the airline industry is determining which airports should be hub locations for an airline.

@hhtong I added you to the repo so that you can review

Sounds good, I'll try to go through it by the end of this week

Closing. Airline hubs example can be found here: https://github.com/dwave-examples/airline-hubs


Update dependencies

Triggering reason is a vulnerability in pygments<2.15 All *.txt files updated with pip-compile --upgrade

If this one is merged #606 will likely go away automatically.


About data processing

Hi 👋, Thanks for your great work!
I try to run your code on my own dataset. For fairness comparison,  can you upload the whole data processing code? I find the user number in raw data is more than 10999 even when I filter by 3-cores. And how did you generate usr_prf.pkl, usr_emb_np.pkl, itm_prf.pkl and itm_emb_np.pkl?
Thank you for any reply!

Hi 👋!
Thank you for your interest! For the Amazon book dataset, we first filter interactions with the rating score of 3. To manage the dataset size, we uniformly sample 20% (25% for Yelp/Steam) of the users, as the GPT-3.5 API was quite costly for large-scale profiling at that time (though it's more feasible now).
We then apply a 10-core approach to obtain the initial datasets. Following that, we utilize multi-thread processing, as outlined in our code, to conduct profiling and text embedding encoding. Ultimately, we remove any users or items that were not successfully profiled or encoded (often due to internet issues) and format the data into usr_prf.pkl, usr_emb_np.pkl, itm_prf.pkl, and itm_emb_np.pkl.
I hope the above information is helpful for you :)
Best regards,
Xubin

Hi 👋!
Thank you for your interest! For the Amazon book dataset, we first filter interactions with the rating score of 3. To manage the dataset size, we uniformly sample 20% (25% for Yelp/Steam) of the users, as it was affordable for us to conduct profiling for a few dozen dollars using the GPT-3.5-Turbo API at that time. The good thing is that it is now much more feasible with a cheaper OpenAI API :)
We then apply a 10-core approach to obtain the initial datasets. Following that, we utilize multi-thread processing, as outlined in our code, to conduct profiling and text embedding encoding. Ultimately, we remove any users or items that were not successfully profiled or encoded (sometimes due to internet issues) and format the data into usr_prf.pkl, usr_emb_np.pkl, itm_prf.pkl, and itm_emb_np.pkl.
I hope the above information is helpful for you :)
Best regards, Xubin

I get it! Thank you for your reply!


Add marker for pytest

Add marker so pytest can select only mypy

Yes! The spec is in the pytest documentation and the inspiration came from pytest-pylint

Ah, yes I see they did something very similar in https://github.com/carsongee/pytest-pylint/pull/19.

Could you also release a new version and publish it on pypi?

Yup! We should probably make some doc improvements first (e.g. changelog updates and maybe a mention of this feature in the README), but those should be pretty straightforward. If you want to add that latter mention, I think this PR would be a good place for it. Otherwise, I'll merge this when I get that PR out.

I updated changelog, readme and version. All good to merge?


couch2pg integration testing for 0.6 requires dataset

https://github.com/medic/medic-webapp/issues/1872

Closing as this has a medic-webapp ticket already


about CanOpenNode dictionnary editor

hello all,
i just dicover a C# programm named CanOpenNode dictionnary editor
not sure about the goal of it,
is it a tool to create CO_OD.C for embeded microcontroler project ?
or, perhaps it is necessary to edit manually this file to customize the node slave project ?

Look for https://github.com/robincornelius/libedssharp, its a gui editor that generates your OD for CanOpenNode

perfect,
very usefull tool, thank you Geoffrey.
i remember my first work with CANopen, a very lonely moment !!!

about CanOpenNode dictionnary editor :
this usefull tool propose to generate source files for canopennode
CO_OD.C and the header CO_OD.H
a parameter " TOOLS / PREFERENCES " permit to choose to generate filesz for CANOPENNODE V4 or LEGACY.
here,
https://github.com/CANopenNode/CANopenNode
it's V2.
so my question are,
witch parameter i muste choose for canopenNode v2 ?  V4 or LEGACY
where can i find canOpenNode V4 ?
once more, thank you for your help

Hi , I just already tested the New Object Dicctionary with the LEGACY option and it seems it will work fine for the "Old Style" version.
Great Job¡¡¡


No video sent from Chrome Desktop to Android

Since a couple of days, this plugin won't work anymore on Android if I connect with a Chrome desktop browser as a peer. I can see my local video, but the peer's video isn't shown anymore.
I guess this is related to a recent change in Chrome 50 which Tokbox had adressed with their recent 2.7.5 version. This patch fixed the problems on desktop browsers, but if I connect Chrome with my Android device, I'm still getting errors. I'm using the latest 2.8.0 version of the JS API in Chrome.
In Android studio, I am getting this error message:
E/OTPlugin: subscriber exception: Internal error -- WebRTC subscriber error., stream id: 6ab447d6-8011-4f93-9eb6-53aaf4ec301f

In the Chrome browser, I see this:
Error while setting RemoteDescription OperationError: Failed to set remote answer sdp: Session error code: ERROR_CONTENT. Session error description: Failed to set remote video description send parameters..
OT.exception :: title: Unable to Publish (1500) msg: OT.Publisher PeerConnection Error: Error while setting RemoteDescription OperationError: Failed to set remote answer sdp: Session error code: ERROR_CONTENT. Session error description: Failed to set remote video description send parameters..

Is anybody else facing this or found a solution?
KR, Tom

@derwaldgeist - I had a similar problem. I was able to get IOS to work by updating the OT IOS framework updated to 2.8; once this was resolved I was able to publish and subscribe video streams from both Desktop (Chrome 50 using OT JS 2.8) and IOS (using IOS OT 2.8)

@kentchau Thanks for your feedback. I was able to resolve this in the meantime by updating the Android SDK to 2.8, too, just as you did for iOS. So I will close this issue.

@derwaldgeist - what steps did you take to update the Android source - and which version are you currently running on?

I've updated it to version 2.7. Here's the commit showing the steps involved:
https://github.com/guzzio/cordova-plugin-opentok/commit/58d25d4f3bcc4b403a1c422c874b07c74e857754
The .so files you need can be downloaded at the tokbox SDK page.


Tooltips do not work on disabled buttons

Describe the bug
When using the Tooltip component around a disabled Button component - the hover action must not bubble up to the tooltip because the tooltip does not show up on hover.
To Reproduce
Steps to reproduce the behavior:

Create a Button Component and wrap it in a Tooltip
See tooltip appear!
Give the Button a disabled={true}
Hover on the disabled button
See no tooltip appear

Expected behavior
Tooltip should be available on hover even on disabled buttons
Screenshots

Desktop (please complete the following information):

OS: Mac
Browser: Chrome
Version [e.g. 22]

Additional context
Happy to help with this but would love to hear any insight y'all have!

found it!
https://github.com/chanzuckerberg/sci-components/blob/d59af72ced81f4e4577aa85b6cd272a343170931/packages/components/src/core/Tooltip/index.tsx#L27C1-L30C4
Maybe we can add this to the Tooltip Docs here https://sds.czi.design/009eaf17b/p/74af45-tooltips/b/3989d2/t/page-74af45-76022694-3989d2-21?

And it is right here in my code editor - oh my goodness - you have already done such a good job trying to help me solve this easily.

We've also added a code example to demonstrate this on ZeroHeight. Thanks for the suggestion! 🥳🎉😬
https://sds.czi.design/009eaf17b/p/74af45-tooltips/t/3543fca49d


[Group 2][Accessible Pressable] Migrate ChangeExpensifyLoginLink

HOLD on https://github.com/Expensify/App/issues/16988
Description
Migrate ChangeExpensifyLoginLink to use PressableWithFeedback

Triggered auto assignment to @isabelastisser (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero process steps for feature requests for more details.

Triggered auto assignment to @twisterdotcom (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero process steps for feature requests for more details.

can you assign me to this one?

Apologies for commenting so late on this, but I think I haven't received a payment for PR review on this. Upwork is buggy so I can't trust it 100%, @roryabraham, could you check when you have time? Thanks

@eVoloshchak Looks like you're right and this one slipped through the cracks. Sorry about that, I've been managing a ton of these issues.

Can I work on it ?

@eVoloshchak sent you a hiring offer.
@Vishrut19 this issue has already been completed. You can find issues to work on by following the guidelines here.

All handled!


[ZEPPELIN-4004] Fix RemoteResource.invokeMethod()

What is this PR for?
RemoteResource is a representation of object in ResourcePool in Interpreter running on another process.
RemoteResource provides a invokeMethod() to call method of an object remotely, which is not working now. This PR provide a fix for that. Also improve the test case to cover this case.
Also provide small improvement to inference parameter type on remote invocation.
What type of PR is it?
Bug Fix, Improvement
What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-4004
How should this be tested?
Unittest included. CI pass.
Questions:

Does the licenses files need update? no
Is there breaking changes for older versions? no
Does this needs documentation? no

Thanks @Leemoonsoo Is there any integration test for it ?

Thanks @felixcheung @zjffdu for taking a look.
Regarding integration test, I believe DistributedResourcePoolTest.java pretty much do the job. It creates two interpreter processes and test using them.

Merge to master and branch-0.8 if no further comment.


Linking to MS Learn modules that are about each PBI dashboard

[Enter feedback here]
Some of the PBI dashboard have additional training available on MS Learn:

Business Continuity Dashboard at aka.ms/wpa-bcd
Ways of Working Assessment at aka.ms/wpa-collab
Teams Insights at aka.ms/wpa-teams
Ways of Working Tracker at aka.ms/wpa-i2a

For each of these dashboards, would it make sense to link to their MS Learn training modules under the "Tips and FAQs" section, or under "About the reports"?
This way users could find more training and info on each dashboard beyond what is in the documentation.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: f956ef4d-db6f-aa40-3ed6-572893e49b68
Version Independent ID: bef0b537-6004-ad42-1227-dea193ea8d27
Content: Ways of working assessment dashboard - Workplace Intelligence
Content Source: WorkplaceAnalytics/Tutorials/power-bi-collab-assess.md
Product: wpa
GitHub Login: @madehmer
Microsoft Alias: v-mideh

Thank you, Mark!
I've added these links. They will help people come up to speed.
-- Paul Schafer


Cleanup tenant specific metrics once a tenant is detached.

https://github.com/neondatabase/neon/issues/2271
Tenant/timeline specific metrics accumulate over time unless they are explicitly removed and this causes a lot of data points:
admin@zenith-1-ps-2:~$ curl -s localhost:9898/metrics | grep ^page | wc -l
1055998

admin@zenith-1-ps-3:~$ curl -s localhost:9898/metrics | grep ^page | wc -l
1019634

So we definitely should remove the metrics from registry when a tenant is detached as these are gathered every 30 seconds.
TODO:

[x] timeline metrics are not removed when we have timeline_id=- (which comes from https://github.com/neondatabase/neon/blob/1324dd89ed612e709fc8c84206d0a32936382789/pageserver/src/layered_repository.rs#L324)

While at it, also moved the rest of metric definitions to a single place. Objections for doing that?

Looks like benchmarks were using some of the metrics to run: https://github.com/neondatabase/neon/runs/8202742560?check_suite_focus=true#step:4:11501
__________________ test_parallel_copy_different_tables[neon] ___________________
test_runner/performance/test_parallel_copy_to.py:53: in test_parallel_copy_different_tables
    env.report_size()
test_runner/fixtures/compare_fixtures.py:136: in report_size
    total_files = self.zenbenchmark.get_int_counter_value(
test_runner/fixtures/benchmark_fixture.py:365: in get_int_counter_value
    assert matches
E   assert None

Opened PR https://github.com/neondatabase/neon/pull/2399 to fix that, as it got in the way when I was working on another PR. I hope I didn't joggle your elbow.


Rework _cap_set_color_pair method

It's been decided to simplify this method and remove unused code.

The current PR is incorrect, I forgot about using _cap_set_color_pair in linux_console.yml


Directive formatting

#if WebEncoders_In_WebUtilities
    public
#else
    internal
#endif
    static class WebEncoders { }
// formats as
#if WebEncoders_In_WebUtilities
    public
#else
internal#endif
static class WebEncoders { }

accidentally committed this right to master : (


Require at least a single match when defining discriminable properties

Fixes #53165

@typescript-bot test this
@typescript-bot test top100
@typescript-bot user test this
@typescript-bot user test tsserver
@typescript-bot test tsserver top100
@typescript-bot run dt
@typescript-bot perf test this

@RyanCavanaugh Ryan Cavanaugh FTE Here are the results of running the top-repos suite comparing main and refs/pull/53654/merge:
Something interesting changed - please have a look.
Details

Ehhh this looks unrelated to this change... right?

Ehhh this looks unrelated to this change... right?

I think so.

@typescript-bot perf test this faster

The fix in this PR unfortunately doesn't work right in all cases. Consider:
type Foo = { x: 0, y: 0, z: 'a' } | { x: 0, y: 1, z: 'b' } | { x: 1, y: 0, z: 'c' } | { x: 1, y: 1, z: 'd' };

let foo: Foo = {
    x: 0,
    y: 1,
    z: // Suggests "a" | "b" here
}

Above, only "b" should be in the completion list. The issue is that once discriminable[i] gets set to true for a particular constituent, it isn't possible for a later check to disqualify that constituent. So it doesn't work when there are multiple discriminant properties as in the example above.
In general, I find the original logic in discriminateTypeByDiscriminableItems hard to follow, and I can't really convince myself that it is correct. It basically starts out by saying that no constituents are in the discriminated result and then only includes constituents when they have a discriminant property with a matching type. I think it needs to be the other way around: By default, all constituents should be in the discriminated result, but when constituents have discriminant properties with types that don't match, they should be removed from the result. Then, in order to fix #53165, we need to additionally say that we only remove constituents when some other constituent has a discriminant property with a matching type (in other words, if we know a property will for sure cause an error, we should just ignore that property).
I'm going to put up a PR with the suggested changes.

@ahejlsberg oh well, I tried 😅 Thank you for coming up with a proper solution!

Closing as this PR has been superseded by #53709


Add down command

This PR adds a down command, for completion. Why? Sometimes a terminal connection is closed, in which case CMD+C is no longer an option, so make down is simple shorthand for docker-compose down and a natural companion to make up.

So this isn't quite right... the first line after a target is a list of other target dependencies.
So it should be:
down:
	docker-compose down

Want me to just do it, or you wanna fix the PR?

Fixed! I need to up my Makefile game (pun intended).

thx!


Test for assertions

Issue #, if available:
https://github.com/awslabs/aws-c-common/issues/471
Description of changes:
Proposal of how to address this issue
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@ColdenCullen @justinboswell This is still a draft, but how's the general idea look?


Limit size of logs coming from docker & kubelet

We should limit the size of logs to 10gb

On coreos & centos, docker logs to journald - which we limited via https://github.com/kubermatic/machine-controller/pull/301
On Ubuntu though, docker (Coming from the xenial repos) logs to file. When docker gets configured to use journald, it is not possible anymore to read container logs: https://github.com/moby/moby/issues/34066#issuecomment-314620360
We must set a logrotate config.

Was it before or after the move to xenial ?


test: fix out-of-dated test code in CodeIgniterTest

Description
If I run the test method only, it causes Error.

fix out-of-dated test code

Checklist:

[x] Securely signed commits
[] Component(s) with PHPDoc blocks, only if necessary or adds value
[] Unit testing, with >80% coverage
[] User guide updated
[x] Conforms to style guide

Thank you @kenjis


Will sonnet support tensorfow 2.0?

Sounds awesome! Is there any way that a Gitter chat room or something similar could be opened for Sonnet? I think it would help users to have a resource like that when making the switch over to Sonnet 2 and also alert the developers to incompatibilities or general bugs.

Sorry for the delay getting back to you @londoed! I don't think a chat room is on the cards for the moment, but we do plan to create great docs for Sonnet 2 and please feel free to file bugs on here, we do actively look into everything that is reported!

I'm trying to implement the VQ EMA block in tensorflow 2.0, since I come from a GAN background and I'd like to learn more about this approach.
It seems quite straightforward, since if I'm not mistaken there will be no need to enforce control dependencies anymore.
Still, I'm missing some points, like how the encoding could be updated while still being discrete (won't any update, made either with Ema or a gradient, change the value such that they become non-integer values?) or how to deal with batches of data.

@edoardogiacomello yes, if you write as TF 2.0 with eager execution, you can just write things in the order you want them to happen, no control dependencies will be required.
As for the discrete values - the discreteness in VQ-VAE is not that things get mapped to integer valued codes, but rather that there is a finite/discrete set of codes in your codebook. So you're right that EMA or gradients will provide small adjustments to the values, but that is all working as intended.
As for batching, the TF / Sonnet 1.0 version supports batched data so I think you can do close to a line-by-line translation, I don't think any big changes are necessary. Alternatively, we will be adding a  Sonnet 2.0 version of VQ VAE in the next few months.

Just stumbled back on this thread, @malcolmreynolds added snt.nets.VectorQuantizer and snt.nets.VectorQuantizerEMA to Sonnet 2 in deepmind/sonnet@67f036929d6be76ef142767a5d088ea60211b8fa.
If it's still relevant for you then you can install Sonnet 2 using the instructions at https://github.com/deepmind/sonnet/tree/v2 and give it a try 😄.

FYI Sonnet 2 is now available in beta on PyPi with support for TensorFlow 2. You can find more info in the read me :smile:.


Make entire menuitem clickable for copy query

Issue:

only span is specified in CopyToClipboard component, the user had to click on the text to copy a url, clicking on blank spaces or icon doesn't work

Solution:

move MenuItem to CopyToClipboard, make entire MenuItem clickable for copying query when rendering in menu

needs-review @mistercrunch @ascott

LGTM


Fill button in case of white color not showing any changes on hover

1 - Fill button (white) not shows any changes on hover
2 - I think white button should be removed or some shade of white should be shown
3 - Demo

4 - I can work on this issue if assigned

@ArshdeepSingh98 this is due to the background. If you switch to "Dark Mode" You can see it works fine. A fix here is not necessary, as the button's functionality needs to be like this. Thank you for reporting this!

Ok, Thanks for clearing it.


Higher level equivalence classes

We would like a way to 'expand' ASTs patterns into higher level "equivalent" ASTs that we then match against.
This can reduce AST surprises and allow simpler matching fragments so the actual matching engine is closer to developer intuitions.
Examples

https://github.com/getgrit/gritql/issues/503
https://github.com/getgrit/gritql/issues/530
https://github.com/getgrit/gritql/issues/552

is this related to #394 as well @morgante ?

Kind of, but it's a higher level concept. That approach only works for leaf nodes (where we can strip characters to get a normalized representation).
For this we actually want to support much higher level equivalence classes to rewrite queries into "equivalent" queries that are more likely to capture the user intent.


Make use of Connector SDK instead of plain job workers

The connector SDK is not yet released, but it uses some principles that are common among all connectors.
Also, it is a generic component maintained by Camunda directly. So using it would reduce maintenance overhead. Plus, we need to make the community aware of the Connector SDK.

Currently, both ways are supported. I am good with this.


Decide what kind of 3D data representation and corresponding network architecture to use for observations/policy

Considered option:

Voxel grid

https://github.com/Durant35/VoxNet
Straight-forward, but memory and computation inefficient
Don't use

Point cloud directly

https://github.com/charlesq34/pointnet and https://github.com/charlesq34/pointnet2
A function defined by the unordered points is approximated via applying a symmetric function (the function itself is approximated by mlp). Seems to be general and work well.

Octree

https://github.com/microsoft/O-CNN
Construct octree structure and use features of the finest leaf octants as input into CNN (averaged normal vector used in the paper, but other features can be used, e.g. rgb). 3D Convolution and pooling (which up-scales octants to higher depth) modules can then be used on these features only, to improve performance and lower memory requirements (rather than processing the entire voxel grid volume).

I have decided to go for https://github.com/microsoft/O-CNN after doing more research. Better memory efficiency than voxel grid and similar performance to pointnet. I think it has a lot of potential too.
There is another work https://github.com/mit-han-lab/pvcnn that also looks promising as it combines aspects of point-based networks and voxels for improved performance. Just keep it it mind if needed for later

I have decided to go for https://github.com/microsoft/O-CNN after doing more research. Better memory efficiency than voxel grid and similar performance to pointnet. I think it has a lot of potential too.
There is another work https://github.com/mit-han-lab/pvcnn that also looks promising as it combines aspects of point-based networks and voxels for improved performance. Just keep it it mind if needed for later


Test changes to make backporting fixes easier

Description of the pull request:
This switches to using import { test } from 'qunit' in all of the tests so that backporting bugfixes is easier between 0.10, 0.9, and 0.8.
It also adds a runner for the node tests to the build scripts.
Is breaking:
Nope.

BTW, the electron test is actually the node test. I just used electron to make node look like a browser since Karma doesn't run Node. That way, tests, reports etc. all run Karma. 😄

Also made QUnit consistently global since you can't use module to mean QUnit.module consistently across tests, node in particular.

Ah! I can't run electron in my usual dev environment because it has no X. I'll back that part out and verify that Rollup handles module correctly.

If it's a Windows issue, it must be some magic sauce on my system. I'll check that out later. 😄

Nah, it's because I usually work in vim in a tmux session over ssh.
Also, verified that rollup turns import { module } from 'qunitjs' safely into qunitjs.module.

Aha! I think I ran into this problem in travis. This portion is what I added:
addons:
  apt:
    packages:
      - xvfb
install:
  - export DISPLAY=':99.0'
  - Xvfb :99 -screen 0 1024x768x24 > /dev/null 2>&1 &