Tuple literals precedence

It would be great to improve the parsing of tuples so it binds a bit tighter.  Concretely, I'd like to avoid needing to surround tuples with parens in the following examples:
# without () it doesn't work :-(
p {1, 2}  # => Unexpected token: ,

def f
  yield {1, 2}   # => Unexpected token: {
end

# with () it works
p ({1, 2})  # OK

def f
  yield ({1, 2})   # OK
end

The example with yield should probably be easy to do.
But with an arbitrary call like p it's different because there's ambiguity with a block. More specifically, p {1} would legitimately be the single-element version of the tuple. But it can't be, because it's a block. Even if the syntax might be unambiguous for multiple elements, it doesn't seem very smart to make the syntax depend on the size of the tuple (think about splats for example...).

However, if the method accepts no blocks, then we certainly want to pass a tuple. This information may not be available at this parsing stage however.

If the intention is to call a method with a block, but the method does not accept a block, then it should be a clear error. Parsing of the method call must not depend on the method definition.

Ah yes, I didn't thought of 1-element tuples 🤦

Perhaps requiring a trailing comma for a one-element tuple would be a good disambiguator (Python does this, I believe) i.e. p {1,}. It looks a little funny, but AFAIK it's not valid syntax for any other context?

foo { x, y = [1, 2] }
``

That's unfortunate that's Blocks and Tuples are close syntaxically 😕.
I'm curious where the Tuple syntax inspiration came from?

By the way:

This is a duplicate: https://github.com/crystal-lang/crystal/issues/1051 https://github.com/crystal-lang/crystal/issues/2746 https://github.com/crystal-lang/crystal/issues/4826 https://github.com/crystal-lang/crystal/issues/6224
This also happens with hashes, it's not only with tuples, so it doesn't matter what syntax we use for tuples
This also happens in Ruby! They never "fixed" it because it's actually impossible to fix.


Removing some unused as a result of running yarn find-deadcode

my favorite npm script.


Drive shown full even if that's not the case.

Explain the bug
Files shows the remaining space of a drive as completely filled up once Windows claims the drive has as issue/problem with it.
To reproduce

Insert a DVD-RAM Disc
Provoke Windows to think the drive has a problem. This can be done by starting up Linux (in my case Zorin OS through Dual Boot, a VM with the drive mounted should probably be sufficient as well). A folder named "System Volume Information" should be written to the drive (you'll have to enable the showing of hidden files).
Back in Windows the drive will now be recognized as having a problem. At this point Files will show the drive as being completely full to the last bit.
Based on this process and it appearing with the existence of "System Volume Information" I'm guessing a USB Drive or anything else will work as well for this (with similar results probably).

Expected behavior
Files should display the remaining disc space correctly (for DVD-RAM typically x out of 4.7-ish GB).
Logfile
debug.log
debug_fulltrust.log
Upload the log file here for us to understand your issue better.
Screenshots

System Information

OS Version: Windows 10 21H1 19043.1110
App version: v<IP_ADDRESS>

Yeah, but I'm starting to think it might be a general Windows issue because Windows Explorer can't seem to write to the drive with that folder in place.

I will close this for now then. Feal free to make a comment if you have it with other ones as well


⚠ Bofrost.at has degraded performance

In b640881, Bofrost.at (https://www.bofrost.at) experienced degraded performance:

HTTP code: 200
Response time: 1228 ms

Resolved: Bofrost.at performance has improved in b44ffe6.


UpdateCollisionError when calling api.posts.edit

Issue Summary
409: UpdateCollisionError when calling api.posts.edit
To Reproduce

When I'm using the Admin-API nodejs package, calling api.posts.edit({id: xxxxx, updated_at: new Date().toISOString()})  will always result in error 409: UpdateCollisionError: Saving failed! Someone else is editing this post I have clear both browser and cloudflare cache, and have disabled cdn cache for /ghost/* route.

I followed the stack trace and found core/server/models/plugins/collision.js:60 is causing the problem. Because (clientUpdatedAt.diff(serverUpdatedAt) !== 0)  will always be true and throw the error

client's updated_at is definitely different than server's updated_at due to network latency. So am I calling api.posts.edit({id: xxxxx, updated_at: new Date().toISOString()}) wrong? What should be the value of updated_at? I couldn't find any examples about it.

Technical details:

* Ghost Version: 2.18.0
* Node Version: 8.15.1
* Browser/OS: Client: Chrome73/MacOS; Server: ghost:alpine/Docker18.09.3/Debian9
* Database: Sqlite

* Stack Trace:

UpdateCollisionError: Saving failed! Someone else is editing this post. at UpdateCollisionError.GhostError (/var/lib/ghost/versions/2.18.3/core/server/lib/common/errors.js:10:26) at new UpdateCollisionError (/var/lib/ghost/versions/2.18.3/core/server/lib/common/errors.js:53:20) at originalUpdateSync.apply.then (/var/lib/ghost/versions/2.18.3/core/server/models/plugins/collision.js:62:55) at tryCatcher (/var/lib/ghost/versions/2.18.3/node_modules/bluebird/js/release/util.js:16:23) at Promise._settlePromiseFromHandler (/var/lib/ghost/versions/2.18.3/node_modules/bluebird/js/release/promise.js:512:31) at Promise._settlePromise (/var/lib/ghost/versions/2.18.3/node_modules/bluebird/js/release/promise.js:569:18) at Promise._settlePromise0 (/var/lib/ghost/versions/2.18.3/node_modules/bluebird/js/release/promise.js:614:10) at Promise._settlePromises (/var/lib/ghost/versions/2.18.3/node_modules/bluebird/js/release/promise.js:694:18) at _drainQueueStep (/var/lib/ghost/versions/2.18.3/node_modules/bluebird/js/release/async.js:138:12) at _drainQueue (/var/lib/ghost/versions/2.18.3/node_modules/bluebird/js/release/async.js:131:9) at Async._drainQueues (/var/lib/ghost/versions/2.18.3/node_modules/bluebird/js/release/async.js:147:5) at Immediate.Async.drainQueues (/var/lib/ghost/versions/2.18.3/node_modules/bluebird/js/release/async.js:17:14) at runCallback (timers.js:810:20) at tryOnImmediate (timers.js:768:5) at processImmediate [as _immediateCallback] (timers.js:745:5)

For PUT requests the updated_at value you send to the API needs to be the same value that is stored on the server, that's how the collision detection works.
Simplified example of collision detection considering updated_at is an incremental integer, showing the value that is stored in the server at each stage.
Client A fetches post, updated_at: 1
Client B fetches post, updated_at: 1
Client B updates post, sends updated_at: 1, server is now updated_at: 2
Client A updates post, sends updated_at: 1, server is updated_at: 2, throws a collision error
If you need support using the API please post on our forum rather than opening bug reports, thank you!.

For PUT requests the updated_at value you send to the API needs to be the same value that is stored on the server, that's how the collision detection works.
Simplified example of collision detection considering updated_at is an incremental integer:
Client A fetches post, updated_at: 1
Client B fetches post, updated_at: 1
Client B updates post, sends updated_at: 1, server is now updated_at: 2
Client A updates post, sends updated_at: 1 but server has updated_at: 2, throws a collision error
If you need support using the API please post on our forum rather than opening bug reports, thank you!.

Sorry about opening the bug report. I have fix it now. The value of updated_at in api.posts.edit({id:xxx, updated_at: xxx}) should be the post's latest updated_at, not new Date().toISOString


Update README.md with how to make a PR

Update README.md with how to make a PR
Kindly make sure to add the hacktoberfest-accepted tag when accepting this PR.
Thank you.

Comgratulations @donheshanthaka on getting your first Pull Request merged in Banque-De-Questions :tada:
Thank you!
Keep contributing. :rocket:

It's my pleasure :)


Mods not working

Ok, if I install a mod using ASL, it works, but installing the mod using AST, or if it updates, arkmanager is crashing. There's no log, so I can't find out what is crashing.
Also, --update-mods does not seem to copy the files into the Content/Mods directory, while installmods does.
--It needs to be able to detect if the mod files changed and reboot the server.
Update 1
Also, now that I fixed whatever it was that was broken by installing the mod from ASL, now it seems to be working with AST.  I don't know what weirdness is happening here.  Are you missing a file that ASL puts in?
Update 2
I could write a script that would do a --update-mods, compare that with the Content/Mods directory, if they are different then stop the server, installmod, then start the server, but I'm worried that there might be a problem somewhere with the ASL fixing problems in AST, and this should be built into AST.  You should be able to use diff, though, or something like it , to detect an update.  Aaaand, I'll shut up about it for now :D.
Update 3
I can verify that if I use the mod installed by ASL it works, and that if I use the mod installed by AST it crashes.  I have copies of the 2 mods.
Update 4
I see differences in 3 .asset files.  Everything else is identical.   This is odd.  I'm hoping you guys have a handle on what's going on.  I've tried installmod 4 or 5 times, every time server crash.  I copy over the one from ASL, and it works perfect.  I could analyze the files further if you want, see if I can figure out what they're doing.
Update 5
The sizes are different, too -
 11.7 MB (12,311,307 bytes) - from ASL

 10.2 MB (10,723,373 bytes) - from AST

It looks like there might be some compression going on? They need to be decompressed? Would be the first thing I'd look at it, but I'll leave it to you guys. I don't even know if I'm helping or just rambling at this point, lol!

Moderated by @atriusftw - Please use the edit function next time to keep the issues simple and clean :shipit:

Also, now that I fixed whatever it was that was broken by installing the mod from ASL, now it seems to be working with AST.  I don't know what weirdness is happening here.  Are you missing a file that ASL puts in?

I could write a script that would do a --update-mods, compare that with the Content/Mods directory, if they are different then stop the server, installmod, then start the server, but I'm worried that there might be a problem somewhere with the ASL fixing problems in AST, and this should be built into AST.  You should be able to use diff, though, or something like it , to detect an update.

I can verify that if I use the mod installed by ASL it works, and that if I use the mod installed by AST it crashes.  I have copies of the 2 mods.

I see differences in 3 .asset files.  Everything else is identical.   This is odd.  I'm hoping you guys have a handle on what's going on.  I've tried installmod 4 or 5 times, every time server crash.  I copy over the one from ASL, and it works perfect.  I could analyze the files further if you want, see if I can figure out what they're doing.

The sizes are different, too -
11.7 MB (12,311,307 bytes)  - from ASL
10.2 MB (10,723,373 bytes)  - from AST
It looks like there might be some compression going on?  They need to be decompressed?  Would be the first thing I'd look at it, but I'll leave it to you guys.  I don't even know if I'm helping or just rambling at this point, lol!

What is the ID of the mod that isn't working?

508249924

It's a total conversion mod.

With ARK Server Launcher, are you using their ARK Remote to install the mod on the Linux server, or are you just looking at what it installs on a Windows server?  I was not able to get ARK Remote to work in order to test it.
I compared the files extracted by installmod with those extracted by the Linux client, and there were no differences (apart from the .mod file).    It worked.  When I delete all the mods in Content/Mod, then do an installmod, it installs the bad one.  I've done it 20 or so times now.  :/.  Hrm.

The Mod you gave us does not have any files larger than 8MB in size (ShooterGame/AssetRegistry is 7.5MB in size, and the next largest file [ShooterGame/Content/Effects/Materials/Water/M_WaterDrop_SubUV.uasset] is 1.7MB under Windows and 0.4MB under Linux), while you said there is one file that is around 10MB or 12MB in size.  This suggests that the Mod ID you gave us is not the correct one for the failing mod.  Either that, or it has been updated and steamcmd isn't pulling it down properly for you (it was last updated about 30 hours ago).  I'll push a possible fix (apparently ! has a lower precedence than -o in [ ... ]).
If you look in $ARKRemote/SteamCMD/steamapps/workshop/content/346110/508249924 and $steamcmdroot/steamapps/workshop/content/346110/508249924, are there any differences?

Then why am I getting the same md5 checksums as you are?  I posted the diffs up there.  Compare the checksums to the ones you got.  They're the same.  It's impossible for it to be a different mod.

It sounds like ARKRemote is using the Windows version of the mod instead of the Linux version of the mod.  Should we have some sort of configuration option that switches one or all of the mods between the Windows version and the Linux version?

Maybe, because the linux version of the mod crashes arkmanager on my linux machine.  Sorry, I didn't realize there were two versions.  ARKRemote.exe is giving me the windows version of the mod.  That's odd.

There is a WindowsNoEditor directory and a LinuxNoEditor directory in most mods.  For Linux clients, the contents of the LinuxNoEditor directory is used.  For Windows clients, the contents of the WindowsNoEditor directory is used.

Thanks, sometimes I fill in lack of knowledge with guesses then work backwards towards whatever my goal may be.

Ok, I tried 195, and it didn't seem to fix it - I put mod_branch=Windows and mod_branch=Linux, used installmod to add a new mod, added the mod to arkmanager.cfg.  Server crashes until I use ARKRemote.exe to install the mod, then everything is good.  Kind of frustrating.  Did you unit test this before you released?  All of this is working on your end?

You said you used mod_branch=Windows and mod_branch=Linux.
If you did do that, then the later of the two would have been used, so if you had mod_branch=Linux later in the file, then it would have installed the Linux version of the mod.

No, I used one, tested it, then I used the other one and tested it.  Neither one worked.  I did not try to use them both at the same time, that would be counter intuitive.  But, if you wish to assume that's what I meant, feel free.  I would just be incorrect.

If you are unable to duplicate this problem, and I'm the only one having it, feel free to close the ticket.  However, I am still having the same issue after this fix.

Please ensure that you remove the mods from the ShooterGame/Content/Mods directory when you change the mod_branch setting.

I will try that tomorrow, for sure.  I believe the first time I used installmod it was set to Linux, the second - for a different mod - it was set to Windows, however I'm not completely sure.


JENKINS-42651 add support for running single test on ALM server

Jenkins does not support running single test on ALM server, if user type a path points to test rather than test set, Jenkins will return "Test folder not found on ALM" error.
Added support for running single test on ALM.
Note:
This is a customer escalation by Nike Inc, the hot fix was verified by Nike Inc without any issue. Benny requested to add this change to our repository so other customer would be able to run single test.
JIRA ticket link:
https://issues.jenkins-ci.org/browse/JENKINS-42651
Corresponding AGM user story:
24143 Nike Jenkins CPE Support for running single test

tsName is supposed to be changed at this point, there is no point to introduce a new variable.
please ignore this sonar issue
changing code from:
a = 10;
to:
int b;
b = 10;
a = b;
does not make it any better to read.

Not only that it's better to read - it's also less error prone.
Changing method parameters could lead to future errors and to less readable code - instead you should use the second variable as the intermediary variable all along the method and to leave the method parameter intact.

more on that here:
https://dev.eclipse.org/sonar/rules/show/squid:S1226
http://stackoverflow.com/questions/13507025/avoid-reassigning-parameters

Moreover, it's suggested to use clean variable names that hint on their use - "tName" doesn't. it's not critical.

Waiting for your fix to merge.

sonar fix committed

:x: Build hp-application-automation-tools-plugin master.12-gkiskhqi failed (commit https://github.com/hpsa/hp-application-automation-tools-plugin/commit/9d0d98647d by @)

:x: Build hp-application-automation-tools-plugin latest.14-gffnixcw failed (commit https://github.com/hpsa/hp-application-automation-tools-plugin/commit/ea453aebf7 by @)

Approved for test build

Ignore codacy - seems irrelevant issue.


Transition to pyproject.toml

The current preferred way of controlling python packaging is through a pyproject.toml file that can mostly or entirely replace setup.py. This is a note to get this on our radar and save progress/knowledge.
This may allow us to stop tracking the version number in source code completely, relying on github tags if we want.
References:
https://setuptools.pypa.io/en/latest/userguide/pyproject_config.html

This is done.


[9.x] Improve JsonResource::class values

This PR improves the value of the JsonResource::class.
Example:
Resource:
return JsonResource::make([
  'array' => [1, 2, 3],
  'object' => (object) ['a' => 'b'],
  'arrayable' => $arrayableObject,
  'htmlString' => $htmlStringObject,
  'stringable' => $stringableObject,
]);

Before

After

Thanks.

This introduces a problem; because filtering happens before serialization Arrayable and Stringable will now take precedence over JsonSerializable.
For example:
class Foo implements Arrayable, JsonSerializable
{
    public function toArray()
    {
        return ['bar'];
    }

    public function jsonSerialize()
    {
        return ['baz'];
    }
}

Before:
["baz"]

After:
["bar"]

This could be fixed by also including JsonSerializable and Jsonable in the filter method, but personally I think only jsonserializable data should be returned by a resource. If you want an arrayable object to be represented as an array, either make it jsonserializable or call toArray() on it manually.

This can be a breaking change for many.

Yes @axlon, you're right. I wait for @taylorotwell's opinion.

Extra issue, when I add casting HtmlString::class instance to a property of Model. It's still empty {} when encoding. I think it causes by json_encode in Model don't know a property is stringable.

Thanks for your pull request to Laravel!
Unfortunately, I'm going to delay merging this code for now. To preserve our ability to adequately maintain the framework, we need to be very careful regarding the amount of code we include.
If possible, please consider releasing your code as a package so that the community can still take advantage of your contributions!
If you feel absolutely certain that this code corrects a bug in the framework, please "@" mention me in a follow-up comment with further explanation so that GitHub will send me a notification of your response.


Remove live data widget

Summary
liveDataEnabled jobs are no longer supported by the runtime api
fixes #397
Details and comments

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.7%) to 35.75%

Totals

Change from base Build<PHONE_NUMBER>:
0.7%

Covered Lines:
2495

Relevant Lines:
6979

💛  - Coveralls


💡 Feature Request - Add metricsEnabled parameter to policy definitions

Describe the solution you'd like
When deploying diagnostics settings one might need to disable metrics for particular resource type.
Describe alternatives you've considered
Parameterized option to opt-in/opt-out of metrics in Diagnostics Settings

Thanks for raising @teemukom, I have transferred this issue to the Enterprise-Scale repo as all our policies in ALZ live here as the source of truth.
This has come up a few times in the past, and we are looking to address it in next quarters policy refresh cycle (Oct-Dec 2023)
Related to #1245, #1252
cc: @Springstone

@jtracey93 will there the metricsEnabled parameter be added to all policies? And is the ETA still this quarter? imo setting the default to true for the metrics is wrong. We collect the audit and security logs centrally and metrics are left to the internal customer’s needs. Enabling metrics can have your costs go through the roof. Is there any development for using categories?

Ill hand over to @springstone to provide an answer here


How do I ...

error: building giflib:x64-windows failed with: BUILD_FAILED
Please ensure you're using the latest port files with git pull and vcpkg update.
Then check for known issues at:
https://github.com/microsoft/vcpkg/issues?q=is%3Aissue+is%3Aopen+in%3Atitle+giflib
You can submit a new issue at:
https://github.com/microsoft/vcpkg/issues/new?template=report-package-build-failure.md&title=[giflib]+Build+error
Include '[giflib] Build error' in your bug report title, the following version information in your bug description, and attach any relevant failure logs from above.
vcpkg-tool version: 2022-07-21-a0e87e227afb536c62188c11ad029954f28fdb22
vcpkg-scripts version: d293ac220 2022-08-12 (8 days ago)
You can also use the prefilled template from F:\dev\installed\vcpkg\issue_body.md.

@chuichuiY Is this issue duplicate of https://github.com/microsoft/vcpkg/issues/26439, if not please reply me and I will reopen it


Adding Dalle image generation

Created an ImageGen component which defaults to DalleImageGen. Currently there is no other provider to choose from.

I'm merging this. Let me know if there are issues and I'll fix them in a follow-up.


Research + implement HTTP tests

Using net/http/httptest, research on how to implement:

unit testing with controller(whether it handles DTO well)
integration testing with controller, service, persistence layers
acceptance testing

References:

quii's LGWT
Network Programming with Go
Practical Go
Learning GO(Testing chapter)

[ ] test


Merge master to develop

Description

Let's fix the dissonance between master and develop!

This doesn't seem to work as I imagined.


bug: Chrome Warnings

Type: bug
Platform: all
I've just seen this warning in Google "'Touch.webkitRadiusX' is deprecated and will be removed in M47, around November 2015. Please use 'Touch.radiusX' instead."
Have you plan to fix this?

This is just a general warning inside of chrome. It does not affect us in anyway (we don't use Touch.webkitRadiusX :grin: )
No issue here.

Thanks mhartington for your quick answer.
Ok, i will ignore that.
P.S.:
Really? It comes from "ionic.bundle.min.js:22" ;-)


Keep repeat payload focus when switching between GUI & XML views

For payloads that support multiple payloads of the same type (ex. Wi-Fi), additional payload tabs appear.  However, when switching between GUI & XML views, the first payload is always selected.  Would like PC to keep the selected payload in focus when switching between GUI & XML views.
A description of what happens currently:

With multiple payloads created, select any payload except the first in the GUI builder.

Click the XML view button.
XML view switches back to the first payload, rather than displaying the selected payload XML.

Select the desired payload in XML view.
Click the GUI builder button to switch back.
Once again, the first payload is selected.

Fixed for the next release.

Looks like this is actually a duplicate of #59

Fixed in 0.2.5 release


Develop unit tests for existing code

Develop unit tests for existing code

Upon review of backlog issues/cards, we found this one. The Unit test system is now operational in recent code releases and is evolving.


Added custom placeholder for date ranges display.

Types of changes
What types of changes does your code introduce?
Put an x in the boxes that apply

[x] Bugfix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

Description
Allow to pass custom placeholder for date ranges display. I've retain the defaults "Early" and "Continuous" if the placeholders were not provided.

Related Issue: #292

Is this plugin still being maintain?

@jeromemmiranda yes, actually @mkg0 is the core contributor for the next version but I will take a look to this one to merge

@keremciu great, thanks for that. This plugin is really helpful.
Also, do you accept donations? If yes, can you provide link.

Hi, any word on this getting merged? I really like the functionality but I need to be able to change the placeholder text.

HI guys, I will take care of PRs, I was so busy by finding a new job stuff, I will gonna spend a day to review them :)

The related issue is resolved in the latest release. (1.0.1) I couldn't merge your PR, since I have seen it after I was already working on it and after changing the file structure of the project. I'm closing this. Thank you for working on this.


Unable to download

Provide environment information
python 3.12
What OS are you using?
Linux
Describe the Bug
Retrieving folder contents
Processing file 1IuYqsKrkxfBK3pb6H4lelh0xtnmJydn0 helical.zip
Processing file 1kaejZUaAzjBqhFmbRlLlb869dPif_tow method.png
Retrieving folder contents completed
Building directory structure
Building directory structure completed
Failed to retrieve file url:
    Too many users have viewed or downloaded this file recently. Please
    try accessing the file again later. If the file you are trying to
    access is particularly large or is shared with many people, it may
    take up to 24 hours to be able to view or download the file. If you
    still can't access a file after 24 hours, contact your domain
    administrator.

You may still be able to access the file from the browser:
Expected Behavior
This has been an issue everytime, how do I overcome this?
To Reproduce
I have pip installed the gdown and then i give command gdown --folder link to the folder

I had the same problem as you


fix: templates plugins

Some things I didn't include:

ability to only apply middleware to specific features from within the config (instead of within the middleware)
Tests since SnapTemplates still can't be tested (LibraryStore & swiper imports)
Dynamic import/chunking of middleware (shopify updateResultsUrl) can't be done since plugins are attached to the config. Also since it's used at afterStore, it may delay the initial render if chunked?

Much refactoring was done - but still some work to do on documentation and testing.


Trigger aztables when proxy files are updated

So that I can avoid manually triggering this pipeline before merging an update to eng/common/testproxy/target_version.txt.

Might be good to add a comment alongside the path inclusion so the purpose is clear and people don't copy/paste the ci.yml files along with the proxy pipeline trigger.


Add SSL/TLS support to SCP

On this PR I tried to add ,as complete I could thought, SSL/TLS support to the SCP functionality of ApplicationEntity.
I would also like ,as a next step, add this functionality to SCU and then write some unittest for the whole procedure.

Changes Unknown when pulling f1f42f270c682a883d0560a118f149e606579b52 on fedjo:ssl-scp into ** on pydicom:master**.

Changes Unknown when pulling 01ab639af316ce928791792e4752cbd59182617d on fedjo:ssl-scp into ** on pydicom:master**.

Just a couple of things, the first is that I'll be away (and have very spotty internet access) for most of the next couple of weeks. Secondly, I won't merge any PRs without 90%+ (and preferably 100%) test coverage of any changes. Finally, I'd like to follow the pydicom PR policy of using a prefix of [WIP] in the title for PRs that are a work-in-progress and [MRG] for PRs that are ready to be reviewed, so if you could change the PR titles that'd be great.
Looking at your implementation, I also think it'd be better to have TLS/SSL invoked as a method, rather than in  __init__. Something like
ae = AE(..)
ae.use_ssl_or_something(...)

I think it's better to keep the AE constructor as simple as possible and use class methods to turn on/off features as required.

Changes Unknown when pulling cb1983a878616d162c660343faf745a387088170 on fedjo:ssl-scp into ** on pydicom:master**.

Some tests failed because ,as the log says, it cannot install pydicom!

Try pushing another commit, hopefully its fixed

I'd prefer SSL functionality be controlled using class methods and the SSL related tests to be in a new test_ssl.py file.

Builds should be working again, the upstream pydicom bug has been fixed.

@scaramallion , as you would like,
SSL functionality added as a separate method :-)

I also like the idea of setting up ssl/tls as init time rather than as a call later. Perhaps to keep the signature change clean would be to add a new param tls_arg=None that if not None is spread through to the ssl wrap call:
if self.tls_arg is not None:
    client_socket = ssl.wrap_socket(client_socket, **self.tls_arg)

Rather than hard coding which args are handled

I put up a PR (https://github.com/pydicom/pynetdicom3/pull/175) with some changes to this.


[SnapshotV2] Support centralize snapshot creation

Description
This PR centralizes snapshot create operations and integrate with timestamp pinning for snapshot creation. The snapshot creation has a sync execution and it can be scaled independently of number of shards in the cluster.
More details can be found in the RFC
Related Issues
Resolves https://github.com/opensearch-project/OpenSearch/issues/15123
Check List

[x] Functionality includes testing.
[ ] API changes companion pull request created, if applicable.
[ ] ~Public documentation issue/PR created, if applicable.~

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Lets also do the following things -

Add UTs corresponding to the changes done.

Add ITs for -

Concurrent snapshot creation / deletion.
Start Snapshot (S1) with Shallow v2, update repository settings, start snapshot (S1) with Shallow v1.
Active cluster manager failover during snapshot creation/deletion.
Network partition

Will take UTs  and more ITs in the followup.


Remove comparable

Fixes # .
Did you remember to?

[X] Add test case(s)
[X] Update CHANGES.txt

This pull request is essentially the properly rebased work done by @testn (original PR https://github.com/cbeust/testng/pull/852)
ping @juherr

Thx! @krmahadevan

ping @cbeust


⚠ ClamAV has degraded performance

In 14c9c99, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 189 ms

Resolved: ClamAV performance has improved in 0ae208b.


Same host in multiple namespaces leads to multiple certificate requests

I am using the same TLS host in multiple Ingress resources that are all in different namespaces (but backed by the same nginx Ingress controller). kube-lego requests a new certificate for each new Ingress/namespace combination, running up against Let's Encrypt rate limits.
Expected behavior: if a certificate has been requested for a host in an existing namespace, a new certificate should not be requested again if the same host is encountered in an Ingress in a different namespace.

I uninteionally exceeded the Let's Encrypt rate limit on a domain whilst running into this issue (oops!).
I'm willing to bet other folks are unintentionally sending more requests to Let's Encrypt like I was, but are lucky enough to not have enough hosts/namespaces to notice. 🤷


[BUG] Variables name containing underscore aren't available in Script Block

Describe the bug
When we pass a variable containing underscore in its name, that variable isn't available inside the Script Block.
To Reproduce
Check attached screenshot.
Expected behavior
Should be able to use that variable.
Screenshots

@AtlasZ-PM make input and output strings with same name


Bug report

I run the train.py,But it reports:
/tensorflow/core/util/tensor_slice_reader.h:168] Check failed: sss_[idx]->Get(key, &value) Failed to seek to the record for tensor res4b16_branch2b/weights, slice -:-:-:-: computed key =
Aborted (core dumped)
How can i solve it?

First, you would need to provide what script you are running and with what configuration.


Allow for passing in package parameters / installer arguments when installing a package

It would be great to be able to pass through package parameters and installer arguments as part of installation.
Other things to consider:

Setting to force which architecture of a package is installed (x64, x86)
Ability to select which version of a package is installed

Based on discussion during a Twitch session on 20th April 2020, the following things were discussed/mentioned regarding this topic (@AdmiringWorm @mkevenaar @mwallner @punker76)

[x]  Selected version should be the latest version available by default
~[ ]  In order for this to work, we need a new release of Chocolatey.Lib~ (Not needed)
[x]  We should restrict the number of available package versions, perhaps 20 by default (but this should be configurable), with an option to load more results
[ ]  There should be a More .. option, or similar, next to the combobox for loading more package versions
[ ]  Versions should be sorted from newest to oldest
[x]  Perhaps provide the ability to allow a package version number to be entered directly into the box, but this should be validated before usage
[ ]  Would be could to have autocomplete/filtering on the combobox to make it easy to find a package version
[ ]  There should be a checkbox to control whether pre-release package versions are included in the combobox
[ ]  Would be nice to fetch the available package versions once the Advanced dialog is opened, with a loading indicator

In addition, we went through the available options/switches for the install command, and decided that the following should be available:

Command Timeout
Log File
Version
Pre-Release (could be set automatically, based on selected package version)
Force x86
Install Args
Override Args
Not Silent (we were undecided on this one)
Package Parameters
Args Global
Params Global
Allow Downgrade (could perhaps infer this, based on current state of system)
SxS (we we undecided on this one)
Ignore dependencies
Force dependencies
Skip PowerShell
Checksums, and all related options - discussion to be had around this

Think that was everything that was discussed, but can add more

Yup, this has been asked before I believe. How would we surface this? Add an additional Install With... option or something that surfaces a text box for pasting in params?

How would you see it? I like maybe having a hidden area at the bottom where this can be specified, and the user just clicks like a right arrow (that converts to a down arrow) to expose this section.
Kind of like summary and detail tags in html5.

@RichiCoder1

How would we surface this? Add an additional Install With...

For simplicity this should be available only in the detail window, since only from there is visible that a package has parameters at all.
Ideally parameters would be parsed automatically and offered as UI options, but I'm not sure if there's a standard way to read those from package descriptors.
If it' possible, than a UI form could be generated from all those parameters. There are projects that do this already, e.g. http://ugui.io/

What happened to this? Another (seemingly related) issue for which I haven't found an answer is the collaboration of chocolateyGUI with useRemeberedArgumentsForUpgrades feature. From what I can tell, the remembered arguments are ignored: observed with git.install, cmake.install and many other packages.

What happened to this?

Hi @paul-michalik, note that the ticket is open and has no identified milestone. Currently it looks like we've given it some labels, so we've validated we want to do it. Then it goes into a prioritization schedule to determine "when" - that's a hard answer that has many variables (and projects) at play. That could be anywhere from a week to 2 years from now (just to give you a good expectation - we have a list and roadmap that goes out a few years to really give you an idea).
So we can actually document this somewhere, I'm going to spend a bit of extra time providing you a really good answer here.
Details
Ticket In Queue
So this ticket is in queue, validated that we'll do it. Here's how you can tell.

Ticket is still open - ticket has not been closed as invalid, won't do, or duplicate
Ticket has release determined or not based on milestone

Ticket at Release / Ready for Release
So when it has gone through the process, the ticket is updated and closed. If there is a milestone and it is closed, that is the release it is in. If that release has not happened yet, that means it is ready for release.

Ticket is closed with milestone identified

Are You a Customer?
If you are commercial customer and you are wanting us to look at bumping prioritization of this, please indicate so here so we can look at where this could bump in priority. It should go without stating that we need to prioritize workload based on needs of folks who keep us in a job and critical needs ahead of features that may have workarounds.
Not A Customer, But Really Need This?
It is open source, ask us to tag it as "Up for Grabs", and you can contribute the work to make those changes in a pull request. That is the spirit of open source at it goes - folks using and benefiting on those things that are free that can't give back in the way of financial support might want to consider documentation, feature requests and bug tickets (and testing), and contributing back.
Create Another Ticket For Related Bug?

Another (seemingly related) issue for which I haven't found an answer is the collaboration of chocolateyGUI with useRemeberedArgumentsForUpgrades feature. From what I can tell, the remembered arguments are ignored: observed with git.install, cmake.install and many other packages.

This sounds like a bug. Possibly related to this. But also probably deserving of its own issue so that it can be tracked and fixed separately (maybe even sooner!).

To add to this, as mentioned in #526 the GUI should allow rolling back (rollback, downgrading, versioning) to a previous version. This can be done via the CLI with "choco list packagename --all" then an uninstall and an install of the desired version, but if the GUI provided a list of all versions and allowed you to click on one to install that version (uninstalling the current one as well, obviously), that would be really useful for when the need arises to do so.

Work has started on implementing this feature.  I will update this issue as I have more information.

@AdmiringWorm @mkevenaar @mwallner @punker76 not sure if you will get a notification for the edit that I made to the first post in this issue, so thought I would follow up here.
I have updated the original post to include what was discussed on the twitch stream.  Let me know if I have missed anything.

Adding in all the properties that I believe are required into the dialog results in the following:

Obviously, there are changes that can be made to optimize this layout, but just wanted to put this out, to get some feedback on how it should look.
@AdmiringWorm @mkevenaar @mwallner @punker76

Adding in all the properties that I believe are required into the dialog results in the following:

:scream:

Obviously, there are changes that can be made to optimize this layout, but just wanted to put this out, to get some feedback on how it should look.

I think it's nice to have all options there, yet I'd prefer to have them grouped and maybe "collapsed" by default...
I've got no clue how this could be done in WPF, but I think something like this "accordion" would be a good option: https://getbootstrap.com/docs/4.0/components/collapse/#accordion-example :sweat_smile:
Groups titles/types could be:

checksum - Ignore Checksum / Allow Empty / Require / Checksum Strings
dependencies - Ignore / Force
debugging - log file / debug switch / verbose switch
...

What options, if any, should be shown by default?

I think --version and --params are the ones I use mostly. -ia is one that could be added by default as well. Rest could be collapsed like @mwallner suggested.

I agree with @mkevenaar on this, the Version, Package Parameters and Install Arguments are the ones that should be shown by default.
The rest could be either grouped in a single Expander or several expanders.
Some of the arguments should probably only be available in some instances, like Allow multiple versions only being useful if a package is installed.
PreRelease and allow downgrade should probably be implied depending on the version selected.
Regarding the UI, maybe changing the checkboxes to a ToggleSwitch would look a little better?
Probably would need a tooltip for the different options as well.
Btw, what are the Apply Install Arguments to and Apply Package Parameters for?
Can't say I have seen any arguments on choco.exe that those options would map to.

@AdmiringWorm said...
Btw, what are the Apply Install Arguments to and Apply Package Parameters for?
Can't say I have seen any arguments on choco.exe that those options would map to.

This is these options.  I used the full name for them.

@AdmiringWorm said...
Regarding the UI, maybe changing the checkboxes to a ToggleSwitch would look a little better?

I had the same thought, as it would be more consistent with what is in the current Settings screen.  I will have a stab at this, and post an image at some point.

@mkevenaar said...
I think --version and --params are the ones I use mostly. -ia is one that could be added by default as well. Rest could be collapsed like @mwallner suggested.

Okay, cool.  I will have a play, and let you know how I get on.

After some (and by that I mean, a lot) of help from @punker76, here is a first draft of all the options...

@AdmiringWorm @mwallner @mkevenaar @ferventcoder what are your thoughts?  Anything that should get moved around, changed?
I am thinking that we can make the ChecksumTypes into dropdownlists, that only have the supported checksum types in Chocolatey.

love it!
imo a slight improvement MAY be to vertically expand if necessary, so that no scrollbar will be shown when expanding the options.
also, bonus points if always only one options drop-down can be expanded at the same time.
this is looking GREAT!

I only got :shipit:
Perhaps "Advanced options" could be different as we are currently in "Install advanced" mode... It seems a bit to much "advanced".

Perhaps "Advanced options" could be different as we are currently in "Install advanced" mode... It seems a bit to much "advanced".

"Additional Options" would perhaps be better?
But that could probably cover too much.
In all, everything looks great to me. Although I feel there perhaps is a little too much space after the toggle switches, but that may just be me.

Looks good! Please make sure that the settings persist! Also in that case, we will need some sort of "reset" option and an indication whether advanced settings were used for a package.

@mwallner said...
also, bonus points if always only one options drop-down can be expanded at the same time.

That would be a question for @punker76 😄

@mkevenaar said...
Perhaps "Advanced options" could be different as we are currently in "Install advanced" mode... It seems a bit to much "advanced"

I had the same thought.  All strings need to be moved into the Resources.resx file, and at that point, I was going to review all of them.

@paul-michalik said...
Please make sure that the settings persist!

Can you elaborate on what you mean here?  I hadn't envisioned persisting any settings.

@paul-michalik said...
Please make sure that the settings persist!

Can you elaborate on what you mean here?  I hadn't envisioned persisting any settings.

I'm wondering if this is in reference to enabling useRememberedArguments?
Such that the next time I go to upgrade a package I installed with additional parameters, when I upgrade via the GUI I would like to see the remembered arguments?
Or I'm missing something in the meaning here.

@AdmiringWorm what are your thoughts on the following...

Put two toggle buttons per line.

@steviecoaster I was wondering the same, as this was the only thing that occurred to me as well.

@punker76 you had the idea of loading the available package versions within the Advanced Dialog, using a small loading icon to show that things were working.  Is this something that you might be able to provide via a PR into here?  Currently this work in done outside of the Dialog, and the available package versions are passed into the Dialog.

@gep13 said...
@AdmiringWorm what are your thoughts on the following...
Picture
Put two toggle buttons per line.

Yeah, IMO that looks much better. Still not a fan of the whitespace between the label and the switches (and text boxes) though, mostly because it looks like wasted space. But that isn't really a problem.

@punker76 you had the idea of loading the available package versions within the Advanced Dialog, using a small loading icon to show that things were working.  Is this something that you might be able to provide via a PR into here?  Currently this work in done outside of the Dialog, and the available package versions are passed into the Dialog.

@gep13 Yes will do this

Just remember loading all available versions causes strain.

@paul-michalik said...
Please make sure that the settings persist!

Can you elaborate on what you mean here?  I hadn't envisioned persisting any settings.

I'm wondering if this is in reference to enabling useRememberedArguments?
Such that the next time I go to upgrade a package I installed with additional parameters, when I upgrade via the GUI I would like to see the remembered arguments?
Or I'm missing something in the meaning here.

Exactly. Without such functionality the entire feature isn't going to be very useful - just think about the next upgrade of a package installed with package parameters, for example. This is the issue I keep bumping into for packages with badly chosen defaults such as git.install or cmake.install.

@paul-michalik said...
Exactly. Without such functionality the entire feature isn't going to be very useful - just think about the next upgrade of a package installed with package parameters, for example. This is the issue I keep bumping into for packages with badly chosen defaults such as git.install or cmake.install.

While I like the idea of hydrating the installation options during an upgrade in the UI, I would see that as a separate issue to what is being discussed here.  Assuming that you have the useRememberedArguments feature enabled, once you go through the advanced installation window that we are suggesting here, any future upgrades will already use those options.

Here is an update to the UI which was suggested by people here.

"accordion" like Expander
Right aligned Labels

So what are you think?

@punker76 that honestly looks awesome.

Next update... loading Packages inside dialog with the possibility to cancel this.
...waiting

...cancel it

@punker76 this is really starting to look very good!

Just from a user's perspective, it would be convenient if the Package Parameters section in the description wasn't obscured. The modal dialog looks great, but it's going to be frustrating trying to set your scrollbar set just right to see the parameters. It also prevents easily copy-and-pasting if you need several.

Re-opening this until I verify that all of the items in the original issue description have been completed.

@AdmiringWorm can you update the checkboxes in the description of this issue?  If any of them haven't been completed, or are in-complete, can you create follow up issues to track that functionality getting added? Thanks

@gep13 the checkboxes have been updated with what is currently included, with a followup issue #913 created

@steviecoaster SXS is added to the advanced installation.
Unless I have missed some, all arguments supported by open-source Chocolatey are supported except for specifying the custom log file path.

:tada: This issue has been resolved in version 0.20.0 :tada:
The release is available on:

GitHub Release
Chocolatey Package

Your GitReleaseManager bot :package::rocket:


Completeness?

How can we assess/illustrate the completeness of the archive holdings?

distance: volume density as a function of distance
Magnitude: density as a function of apparent mag

Others?

Our numbers against a simulated completeness to see how we're doing?


Can O' Spam: Watch emiratesvisaonline.com

Can O' Spam requests the watch of the watch_keyword emiratesvisaonline\.com. See the MS search here and the Stack Exchange search in text, in URLs, and in code.

Approved by Makyen in Charcoal HQ


VFSForGit installer displays option to install on non-root volume

VFSForGit on the Mac should be installable only on the boot partition. But the installer provides user with the option to choose a different partition for install.

Git & GCM Core installers show the same behavior.

Just came across this issue. If I remember correctly, specifying a <volume-check> tag with an <allowed-os-versions> section should solve it.


Typo Correction

Under the
"Creating a Model: Code First, the EF Designer, and the EF Workflows" section, the last word should be 'difference' instead of 'different'.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

 This is good feedback. It is also super easy to submit a PR when you find a typo like this. Look for the :pencil: icon in the page.


Dependency versions too rigid

It seems that in order to use this crate, we need exactly the same versions of the dependencies that this crate already has.
Is there any chance we can have this loosened? It would be great to not have to keep checking what version this library uses every time I (or anyone else) want(s) to use a dependency that is owned by it. This is mostly relevant when referring to serde-json and many other libraries that have mostly already stabilised - for example, serde-json's changelog: https://github.com/serde-rs/json/releases.
Otherwise, great crate! Looking forward to using this a lot more in the future so I don't have to use Candle or a similar framework for absolutely everything :sweat:

Hey @joshua-mo-143. Great suggestion. Will look into this.


[(ngModel)] + placeholder + Parent component OnPush = Bug

Bug, feature request, or proposal:
Bug
What is the current behavior?
When I use a simple input like this
<md-input-container>
  <input mdInput type="text" [(ngModel)]="assessment.title" name="title"
  placeholder="hello!" />
</md-input-container>

And the parent component is OnPush, the placeholder has a strange behavior:

What are the steps to reproduce?
It's simple: http://plnkr.co/edit/g5J40Puh5rmd3saPxip5?p=preview
in app.component.ts uncomment the line 9 changeDetection: ChangeDetectionStrategy.OnPush
Which versions of Angular, Material, OS, TypeScript, browsers are affected?
Angular material beta 8

Dupe of https://github.com/angular/material2/issues/3005

Any update? @willshowell @ThomasBurleson

It looks like this issue is no longer occuring as seen in this reproduction.


App is continuously crashing when opening

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number: <IP_ADDRESS>
Reproducible in staging?: Needs reproduction
Reproducible in production?: Needs reproduction
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @miljakljajic
Slack conversation: https://expensify.slack.com/archives/C05LX9D6E07/p1719218119857479
Action Performed:
Install and launch the app
Expected Result:
App launched without any issue
Actual Result:
App is continuously crashing
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android: Native
[ ] Android: mWeb Chrome
[x] iOS: Native
[ ] iOS: mWeb Safari
[ ] MacOS: Chrome / Safari
[ ] MacOS: Desktop

Screenshots/Videos
Add any screenshot/video evidence
https://github.com/Expensify/App/assets/38435837/131aaf5a-5e93-4ea5-ba18-2160133d4e3b

View all open jobs on GitHub

This has been labelled "Needs Reproduction". Follow the steps here: https://stackoverflowteams.com/c/expensify/questions/16989

<IP_ADDRESS> is pretty out-of-date. Can you please update to version <IP_ADDRESS> and try again?

Ah sorry - I was using TF and it didn't give me any indication at the time that there was a new version to download (I reported this yesterday morning). But regardless, it's working now!

Actually, it doesn't seem like this was resolved. I'm on <IP_ADDRESS> now and the app is crashing again whenever I open it.

Also should note that I deleted and re-installed the app and it's still happening.

OK, thanks! I'm trying to find your crash logs, but I need a little more information:

What is the OS version of your iPhone?
What is your iPhone model?

iPhone 13 Pro
iOS 17.5.1
Thank you!

@mountiny It looks like maybe you have been working on this according to the threads I found in Slack, so I hope you don't mind if I assign this to you.
@miljakljajic I think a fix has been deployed to staging, so can you update your app to the latest version and see if you still have the problem or not?

I'm getting an endless skeleton loader (which is a different issue, I believe tied to open app timeout).So we can call this fixed, I guess?


message: Add function to remove single newline in triple quoted string.

PR to address https://github.com/zulip/zulip/pull/28720#issuecomment-2010342989

Self-review checklist

[x] Self-reviewed the changes for clarity and maintainability
(variable names, code reuse, readability, etc.).

Communicate decisions, questions, and potential concerns.

[x] Explains differences from previous plans (e.g., issue description).
[ ] Highlights technical choices and bugs encountered.
[ ] Calls out remaining decisions and concerns.
[x] Automated tests verify logic where appropriate.

Individual commits are ready for review (see commit discipline).

[x] Each commit is a coherent idea.
[x] Commit message(s) explain reasoning and motivation for changes.

Completed manual review and testing of the following:

[ ] Visual appearance of the changes.
[ ] Responsiveness and internationalization.
[ ] Strings and tooltips.
[ ] End-to-end functionality of buttons, interactions and flows.
[ ] Corner cases, error conditions, and easily imagined bugs.

Addressed the review comment.

Nice, merged, thanks @prakhar1144!


Getting "Sorry, there was an error : unauthorized_client"

Im trying to redirect to the login page (Authservice) from React and getting below error.
URL:
https://localhost:5002/connect/authorize?client_id=testclient&redirect_uri=http%3A%2F%2Flocalhost%3A5001%2Ftoken%2F&response_type=id_token token&scope=retina openid contact profile&state=ac9b6058da3d4ed38c38d6a7c9ca60b0&nonce=0643034d94234b2b8e37fa3e1cd8cc36
Checked "ClientRedirectUri" and all good. Please help me on this

Check your logs.

@leastprivilege Im using serilog in my auth service solution. Nothing is generating :(

@leastprivilege Getting below error in console

Can you check the logs of identity server?
Maybe it is something with your redirect uri or something, it should be there.
Not the browser log, you won't find the error there.

I also experienced this error and commented it line 92 for the giggles and the issue went away. I'm not entirely sure why removing the line makes it work, but it does in case you need a workaround until the issue is addressed.

Im getting "Invalid grant type for client: implicit"

Im able to resolve the issue by changing the grant type from hybrid to implicit
Its logging in . But Unable to redirect to the call back URL.
2020-10-05 09:45:49.727 +05:30 [Information] Executed DbCommand ("16"ms) [Parameters=["@__userId_0='?'"], CommandType='Text', CommandTimeout='30']"
""SELECT "role"."Name"
FROM "AspNetUserRoles" AS "userRole"
INNER JOIN "AspNetRoles" AS "role" ON "userRole"."RoleId" = "role"."Id"
WHERE "userRole"."UserId" = @__userId_0"
2020-10-05 09:45:49.806 +05:30 [Information] AuthenticationScheme: "Identity.Application" signed in.
2020-10-05 09:45:49.814 +05:30 [Information] Executing RedirectResult, redirecting to "/connect/authorize/callback?client_id=retina&redirect_uri=http%3A%2F%2Flocalhost%3A5001%2Ftoken%2F&response_type=id_token%20token&scope=retina%20openid%20contact%20profile&state=99a5ada0fe8d4951a0da912b64853dce&nonce=1a90c125a18345749b0dc94bfa923147".
2020-10-05 09:45:49.816 +05:30 [Information] Executed action "IdentityServer4.Quickstart.UI.AccountController.Login (AuthService)" in 493.3721ms
2020-10-05 09:45:49.821 +05:30 [Information] Request finished in 516.8469ms 302
2020-10-05 09:45:49.825 +05:30 [Information] Request starting HTTP/1.1 GET https://localhost:5002/connect/authorize/callback?client_id=retina&redirect_uri=http%3A%2F%2Flocalhost%3A5001%2Ftoken%2F&response_type=id_token token&scope=retina openid contact profile&state=99a5ada0fe8d4951a0da912b64853dce&nonce=1a90c125a18345749b0dc94bfa923147
2020-10-05 09:45:49.826 +05:30 [Information] AuthenticationScheme: "Identity.Application" was successfully authenticated.
2020-10-05 09:45:49.827 +05:30 [Information] AuthenticationScheme: "Identity.Application" was successfully authenticated.
2020-10-05 09:45:49.827 +05:30 [Information] Invoking IdentityServer endpoint: "IdentityServer4.Endpoints.AuthorizeCallbackEndpoint" for "/connect/authorize/callback"
2020-10-05 09:45:49.836 +05:30 [Information] ValidatedAuthorizeRequest
"{
"ClientId": "retina",
"RedirectUri": "http://localhost:5001/token/\",
"AllowedRedirectUris": [
"http://localhost:5001/token/\",
"https://mbs.synapsemedical.com.au/token/\"
],
"SubjectId": "e9eb9161-2efd-4537-89a0-6d8ad5a0817b",
"ResponseType": "id_token token",
"ResponseMode": "fragment",
"GrantType": "implicit",
"RequestedScopes": "retina openid contact profile",
"State": "99a5ada0fe8d4951a0da912b64853dce",
"Nonce": "1a90c125a18345749b0dc94bfa923147",
"SessionId": "2323f796eb27b6175f548ac89bbc5b0f",
"Raw": {
"client_id": "retina",
"redirect_uri": "http://localhost:5001/token/\",
"response_type": "id_token token",
"scope": "retina openid contact profile",
"state": "99a5ada0fe8d4951a0da912b64853dce",
"nonce": "1a90c125a18345749b0dc94bfa923147"
}
}"
2020-10-05 09:45:49.836 +05:30 [Information] Showing login: User is not active
2020-10-05 09:45:49.836 +05:30 [Information] Request finished in 11.2017ms 302
2020-10-05 09:45:49.851 +05:30 [Information] Request starting HTTP/1.1 GET https://localhost:5002/account/login?returnUrl=%2Fconnect%2Fauthorize%2Fcallback%3Fclient_id%3Dretina%26redirect_uri%3Dhttp%253A%252F%252Flocalhost%253A5001%252Ftoken%252F%26response_type%3Did_token%2520token%26scope%3Dretina%2520openid%2520contact%2520profile%26state%3D99a5ada0fe8d4951a0da912b64853dce%26nonce%3D1a90c125a18345749b0dc94bfa923147
2020-10-05 09:45:49.852 +05:30 [Information] Executing action method "IdentityServer4.Quickstart.UI.AccountController.Login (AuthService)" with arguments (["/connect/authorize/callback?client_id=retina&redirect_uri=http%3A%2F%2Flocalhost%3A5001%2Ftoken%2F&response_type=id_token%20token&scope=retina%20openid%20contact%20profile&state=99a5ada0fe8d4951a0da912b64853dce&nonce=1a90c125a18345749b0dc94bfa923147"]) - ModelState is Valid
2020-10-05 09:45:49.853 +05:30 [Information] AuthenticationScheme: "Identity.Application" was successfully authenticated.
2020-10-05 09:45:49.856 +05:30 [Information] Executing ViewResult, running view at path "/Views/Account/Login.cshtml".
2020-10-05 09:45:49.864 +05:30 [Information] Executed action "IdentityServer4.Quickstart.UI.AccountController.Login (AuthService)" in 11.0974ms
2020-10-05 09:45:49.865 +05:30 [Information] Request finished in 13.7419ms 200 text/html; charset=utf-8

It has to redirect to http://localhost:5001 . But staying in login page itself

Issue is fixed .. Removed below lines


Graph dispatch zoom in action

One-line summary [问题简述]
I am unable to programmatically zoom into rendered graph.
As the page is loaded, graph is loaded. I need to zoom in particular part of the graph. Don't know how.
Version & Environment [版本及环境]

ECharts version [ECharts 版本]: 4.1.0
Browser version [浏览器类型和版本]: Chrome 69, but probably doesn't matter
OS Version [操作系统类型和版本]: Mac OS Mojave but probably doesn't matter

Expected behaviour [期望结果]
There should be available method for zoom in..
ECharts option [ECharts配置项]

option = {
            title: {
                text: ''
            },
            tooltip: {},
            toolbox: {},
            animationDurationUpdate: 1500,
            animationEasingUpdate: 'quinticInOut',
            series: [{
//                focusNodeAdjacency: true,
                type: 'graph',
                layout: 'none',
                symbolSize: 10,
                symbolKeepAspec: true,
                roam: true,
                dataZoom: {
                    type: 'absolute'
                },
                nodeScaleRatio: 0.6,
//                scaleLimit: {
//                    min: 0,
//                    max: 10,
//                },
                label: {
                    show: true,
                    position: 'bottom',
                    color: '#0066b2',
                    fontSize: 1,
                    distance: 0.1
                },
                edgeSymbol: ['circle', 'arrow'],
                edgeSymbolSize: [4, 10],
                edgeLabel: {
                    normal: {
                        textStyle: {
                            fontSize: 20
                        }
                    }
                },
                data: myChartData,
                links: myChartLinks
            }]
        }

Other comments [其他信息]

@Ovilia Is this still not implemented?

@narenderv7 You can get the zoom and center from chart.getOption().series[0] and save it.
Then, when you want to restore, set it with chart.setOption. It should work.
The document seems to be out of date, I will update it soon.


Examples don't run on Lambdalabs without various additional/manual steps

I used the setup script in the referenced issue (see here) install the correct pthon and pytorch version.
However, I got additional errors when running the examples, e.g.
accelerate launch scripts/finetune.py examples/openllama-3b/qlora.yml
ERROR:root:Exception raised attempting to load model, retrying with AutoModelForCausalLM
ERROR:root:/home/ubuntu/.local/lib/python3.9/site-packages/bitsandbytes/libbitsandbytes_cpu.so: undefined symbol: cquantize_blockwise_fp16_nf4
Traceback (most recent call last):

or
accelerate launch scripts/finetune.py examples/openllama-3b/lora.yml
results in
ERROR:root:Exception raised attempting to load model, retrying with AutoModelForCausalLM
ERROR:root:/home/ubuntu/.local/lib/python3.9/site-packages/bitsandbytes/libbitsandbytes_cpu.so: undefined symbol: cget_col_row_stats

I´m not very experienced - are these axolotl issues or issues of the downstream libraries?
Edit:
After force-reinstalling tensorflow, protobuf and wandb, the examples are running again:
python -m pip install --upgrade --force-reinstall tensorflow "protobuf<3.21" wandb
Originally posted by @jpdus in https://github.com/OpenAccess-AI-Collective/axolotl/issues/242#issuecomment-1620549837

Hello, may I ask which GPU you are using?
It would seem that bitsandbytes are giving issues. Have you tried installing from source or downgrading one version?
This also kind of pushes the need of versioning #153

Hello, may I ask which GPU you are using?
It would seem that bitsandbytes are giving issues. Have you tried installing from source or downgrading one version?
This also kind of pushes the need of versioning #153

I was using a A100 40GB (via lambdalabs) and installed bitsandbytes via the requirements.txt:
accelerate==0.20.3
axolotl==0.1
bitsandbytes==0.39.1
peft==0.4.0.dev0

python_version: 3.9.17

After my experience I would also strongly support #153 , was about to give up...

@jpdus , may I ask if you have tried docker? I usually have best success with that.
I agree we need better versioning. It has been on the TODO for a long time..

Hello, did you manage to get this all setup and running? If so, can we close this issue?

Yes I managed to get everything up and running but spent the better part of 2 days on it ;-) .
Will close this, but would advice version pinning like proposed in #153 (or at least mentioning known "good" versions in the examples/tutorials; i created some requirements.txt lists and known "good" commits of the git installs for myself).


ap

May I ask how much the AP value has dropped? The article said that it has dropped by 1%. Why do I feel that it is not only the drop of these

Hi! The performance is consistent with the paper. Many works, when reporting accuracy in the leaderboard, use test-time augmentations, such as image flip or multi-scale testing. This work uses single network forward pass for testing by default, you can enable multi-scale testing by passing --multiscale key to the validation script.

Thanks for your reply, I have another question, how can I get the visual test results in val.py

Pass --visualize key to the script.

Thank you very much for your reply again. May I ask what is included in this visualization result, and I have modified the network layer of your code and reached 38.8% in the first stage of training. Is this an improvement?

I suggest to follow the README.md file to check proper usage of the validation script.

Hope, it is helped.


Does it support mediapipe blazepose

Trying to use blazepose for pose detection

If it's a tflite file, it should be useable. You'd just need to figure out the input and output data shape I think. For what it is though, we're figuring out an actual MediaPipe plugin based on what you can find here.

[Tensor{_tensor: Pointer: address=0xb400007a3c9f8180, name: input_1, type: TfLiteType.float32, shape: [1, 256, 256, 3], data:  786432]
[Tensor{_tensor: Pointer: address=0xb400007a3ca00920, name: Identity, type: TfLiteType.float32, shape: [1, 195], data:  780, Tensor{_tensor: Pointer: address=0xb400007a3ca00b50, name: Identity_1, type: TfLiteType.float32, shape: [1, 1], data:  4, Tensor{_tensor: Pointer: address=0xb400007a3c9ffce0, name: Identity_2, type: TfLiteType.float32, shape: [1, 256, 256, 1], data:  262144, Tensor{_tensor: Pointer: address=0xb400007a3c9ffd50, name: Identity_3, type: TfLiteType.float32, shape: [1, 64, 64, 39], data:  638976, Tensor{_tensor: Pointer: address=0xb400007a3ca00a00, name: Identity_4, type: TfLiteType.float32, shape: [1, 117], data:  468]
This is input and output shape

Got it - I don't actually have an answer here. I'd probably hold off on that one until the MediaPipe plugin is started :)


Implement Dropdown Menu for Accessing incident templates

📑 I have found these related issues/pull requests
There are some incidents that often repeat. Therefore, we would like to implementing a dropdown menu for previous incidents.
🏷 Feature Request Type
Status-page
🔖 Feature description
To streamline our process and reduce redundancy, we're would like to implement a feature that archives previous incidents. This will enable us to access past incidents with fewer clicks, eliminating the need to retype the same text repeatedly.
✔ Solution

Upon selecting 'Templates,' a list should appear featuring either previous incidents or saved incidents.
❓ Alternatives
No response
📝 Additional Context
No response

I would need to look up if we save incidents somewhere in the database.
In any case this would be a larger feature. If you'd like to implement this, please first start of with a plan what you would like to add where ("How should this work") via annotated screenshots and what database modifications are needed to get there.
Here is our contribution guide: https://github.com/louislam/uptime-kuma/blob/master/CONTRIBUTING.md
Note that for larger features our pipeline is currently quite full already
=> I don't know when we would get to this.
Note to self:
I think the guidance on new features in our contribution guide is pretty lacking => we defintively need to improve that part ^^

@CommanderStorm There is indeed a table named incident. The status page UI indeed could benefit from an incident history

Ability to view past incident in the respective status page

I am going to reference a related PR which did not work our mostly because of being too big to review

https://github.com/louislam/uptime-kuma/pull/1253

=> "stealing" incident list from said PR might be a good starting point (keep it simple, no 4k changed lines please, that is not reviewable)
=> the correct issue (forgot to deduplciate in the last comment) is https://github.com/louislam/uptime-kuma/issues/862

How is the template linked to the status page itself? The only relation I see is between the template and the incident?

Them being global is fine by me. Don't think there needs to be a relation between incidents and templates (what would we use it for?)
What I am currently a bit torn is if adding/removing of templates should be done in the settings or in the same modal to select the template.

What I am currently a bit torn is if adding/removing of templates should be done in the settings or in the same modal to select the template.

I think the better thing would be to have it in the same modal. When writing an incident, you'd fill whatever info and have the option to save it as a template


Display friendly error message

ctx.Error only displays the text but ctx.ServerError renders the usual error page.

I was unable to create a backport for 1.21. @KN4CK3R, please send one manually. :tea:
go run ./contrib/backport 29105
...  // fix git conflicts if any
go run ./contrib/backport --continue


AVR8: Fix lpm/elpm implementation in SLEIGH specification

When Z & 0x1 == 1, the dereferenced data must be right-shifted 8 bits before assigning val:1 to the target register.
When Z & 0x0 == 0, val:1 is assigned to the target register straight away.
In short, we can reduce these condition to:
	tmp:2 = *[code]:2 (ptr >> 1);
	val:2 = (tmp >> (8 * (Z & 0x1)));
	R0 = val:1;

The following screenshot shows that, before the fix, the Basic Constant Reference Analyzer was not able to resolve the address pointed by X correctly:

However, after these changes, X is resolved correctly:

Merged 9556e6e212ff7db54111414491820f1142c780a1


traffic.out not found

Hi everyone,
I using TrafficSrever branch: master - #828b7d3
I added config to record.config, config as bellow:
CONFIG proxy.config.dump_mem_info_frequency INT 1
CONFIG proxy.config.res_track_memory INT 1

But when start trafficserver then traffic.out not found in ats/var/log/trafficserver
To Reproduce
autoreconf -i --force
./configure --prefix=/home/user/trafficserver/ats --enable-experimental-plugin
make && make install
/etc/init.d/trafficserver

Hi @HugManh.
ATS 10 is no longer using records.config, instead it uses records.yaml now.  If you need to convert your old records.config to yaml, please follow this.
Also, we've moved to cmake build system, please check this out.
Regards.

I would agree with @brbzull0 that you should move to the 10.0.0 release instead of using checkout of master.

Thank, @bryancall @brbzull0
Sorry for the late reply, I will try switching to the 10.0.0 release.


Need to create a Postman account to be able to use environments

Latest version of Postman requires you to sign in to Postman account to be able to create and use an environment

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: d25c7db3-badf-d848-1cca-9e5fe3390504
Version Independent ID: 70c9e985-9dbc-6415-5983-c551b05b0c87
Content: Set up a Postman environment (Microsoft Dataverse for Apps) - Power Apps
Content Source: powerapps-docs/developer/data-platform/webapi/setup-postman-environment.md
Service: powerapps
Sub-service: dataverse-developer
GitHub Login: @divkamath
Microsoft Alias: dikamath

Thanks for your comment, @julians1966. This issue has been assigned to the doc author for review.

PR #4559 raised


[Bug] Open union of float value type becomes int value type

Describe the bug
union FloatExtensibleEnum {
    float32,
    One: 1.0,
    Two: 2.0,
    Four: 4.0,
}

I defined an extensible enum with type float32, and several values 1.0.
To Reproduce
Call https://github.com/Azure/typespec-azure/blob/53cc4dee48de3e8b774643d5946bed1f768f8609/packages/typespec-client-generator-core/src/types.ts#L800
Expected behavior
Value type float32
Actual behavior
Value type int32
Additional context
See this line: https://github.com/Azure/typespec-azure/blob/53cc4dee48de3e8b774643d5946bed1f768f8609/packages/typespec-client-generator-core/src/types.ts#L658
The value type comes from actual value type which becomes 1 after it reads into memory, which is originally 1.0. Since we now have the ability to identify the real type of extensible enum as open union, we should respect the type defined in the spec, i.e. float32.

cc @tadelesh and @iscai-msft

i'll look into this.
@timotheeguerin should tsp know that the type of 1.0 is a float and not an int?

typespec doesn't today see this isssue https://github.com/microsoft/typespec/issues/2240 you have to figure out yourself if you care


Fix bugs for date parsing and reminders

Fix bug for dates where invalid dates like 30-02-2022 were accepted.
Fix bug where reminders were not deleted when the person was deleted.
Added check for Birthday to check if the date has not passed.

Codecov Report

Merging #106 (c673d4a) into master (393e38e) will decrease coverage by 0.32%.
The diff coverage is 60.71%.

@@             Coverage Diff              @@
##             master     #106      +/-   ##
============================================
- Coverage     76.57%   76.24%   -0.33%
- Complexity      524      525       +1
============================================
  Files            90       90
  Lines          1686     1705      +19
  Branches        180      182       +2
============================================
+ Hits           1291     1300       +9
- Misses          329      338       +9
- Partials         66       67       +1

Impacted Files
Coverage Δ

.../seedu/address/logic/commands/ReminderCommand.java
0.00% <ø> (ø)

...du/address/logic/parser/ReminderCommandParser.java
0.00% <0.00%> (ø)

src/main/java/seedu/address/model/Model.java
100.00% <ø> (ø)

...main/java/seedu/address/model/person/Birthday.java
55.55% <57.14%> (-21.37%)
:arrow_down:

...main/java/seedu/address/model/person/Reminder.java
54.54% <66.66%> (+4.54%)
:arrow_up:

...in/java/seedu/address/logic/parser/ParserUtil.java
94.33% <77.77%> (-3.49%)
:arrow_down:

...va/seedu/address/logic/commands/DeleteCommand.java
94.11% <100.00%> (+0.17%)
:arrow_up:

...rc/main/java/seedu/address/model/ModelManager.java
93.84% <100.00%> (+0.19%)
:arrow_up:

src/main/java/seedu/address/ui/PersonCard.java
100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


Encounter cluster has nodes with different OS images issue when using 1.17.0-pre.3

Is there an existing issue for this?

[x] I have searched the existing issues

Version
equal or higher than v1.16.4 and lower than v1.17.0
What happened?
environment: 1.17.0-pre.3
cilium-cli: built locally with 1.17.0-pre.3 source
When trying out new 1.17.0-pre.3, I noticed that the old cli is not compatible with new cilium version, so a new cli is built and used. In our EKS cluster, we do have two different OSes:

AL2 which is used in fargate node hosting Karpenter
Bottlerocket is configured on nodes provisioned by Karpenter

we do have nodeSelector in cilium values file for cilium agents/ operators/ envoys workloads. And in earlier version, our approach works well. This behavior breaks in 1.17.0-pre.3 (not in .2) with below error
cilium upgrade cilium cilium/cilium --namespace kube-system --version "$cilium_version" --values cilium-values.yaml       --set cluster.id=1       --set "cluster.name=${cluster_name}"       --set "eni.iamRole=${cilium_role_arn}"       --set "serviceAccounts.operator.annotations.eks\.amazonaws\.com/role-arn=${cilium_role_arn}" --set "k8sServiceHost=${cluster_api_endpoint}"
🔮 Auto-detected Kubernetes kind: EKS
ℹ  Using Cilium version 1.17.0-pre.3
ℹ  Using cluster name "truong-test-cluster"
🔮 Auto-detected kube-proxy has been installed
❌ Could not detect AWS node image family, defaulted to fallback value: Custom

Error: Unable to upgrade Cilium: cluster has nodes with different OS images: 'AmazonLinux2' and 'Bottlerocket'

I guess it might be related to this feature.
How can we reproduce the issue?
environment: 1.17.0-pre.3
cilium-cli: built locally with 1.17.0-pre.3 source
When trying out new 1.17.0-pre.3, I noticed that the old cli is not compatible with new cilium version, so a new cli is built and used. In our EKS cluster, we do have two different OSes:

AL2 which is used in fargate node hosting Karpenter
Bottlerocket is configured on nodes provisioned by Karpenter

we do have nodeSelector in cilium values file for cilium agents/ operators/ envoys workloads. And in earlier version, our approach works well. This behavior breaks in 1.17.0-pre.3 (not in .2) with below error
cilium upgrade cilium cilium/cilium --namespace kube-system --version "$cilium_version" --values cilium-values.yaml       --set cluster.id=1       --set "cluster.name=${cluster_name}"       --set "eni.iamRole=${cilium_role_arn}"       --set "serviceAccounts.operator.annotations.eks\.amazonaws\.com/role-arn=${cilium_role_arn}" --set "k8sServiceHost=${cluster_api_endpoint}"
🔮 Auto-detected Kubernetes kind: EKS
ℹ  Using Cilium version 1.17.0-pre.3
ℹ  Using cluster name "truong-test-cluster"
🔮 Auto-detected kube-proxy has been installed
❌ Could not detect AWS node image family, defaulted to fallback value: Custom

Error: Unable to upgrade Cilium: cluster has nodes with different OS images: 'AmazonLinux2' and 'Bottlerocket'

I guess it might be related to this feature.
Cilium Version
1.17.0-pre.3
Kernel Version
NA
Kubernetes Version
1.31
Regression
No response
Sysdump
No response
Relevant log output

Anything else?
No response
Cilium Users Document

[x] Are you a user of Cilium? Please add yourself to the Users doc

Code of Conduct

[x] I agree to follow this project's Code of Conduct

@viktor-kurchenko FYI

Hello, can you share an example of your nodeSelector-based approach for handling values in a mixed OS cluster?

sure, @nbusseneau an excerpt of our cilium values file
nodeSelector:
  kubernetes.io/os: linux
  karpenter.sh/registered: "true"

envoy:
  rolloutPods: true
  nodeSelector:
    kubernetes.io/os: linux
    karpenter.sh/registered: "true"

Ah sorry I misunderstood, I thought you were using nodeSelector to dispatch different values to different nodes in a mixed OS cluster, but this is "just" the regular nodeSelector field in the Cilium values for pod assignment. In other words, the issue you have is only because of the new block on mixed OS clusters, it is unrelated to nodeSelector setup => I got confused because it was mentioned in OP but this is only context and not directly related to the issue.

Technically it works in your case of mixed OS because both OS have a similar network interface setup (or you don't use masquerade), so even though Cilium is indeed currently unable to handle masquerading over a mixed cluster with different naming schemes for network interfaces, in your case the block is actively preventing a previously working situation.
I think we should switch from error to warning in the CLI, allowing such a use case.

@truongnht thanks for reporting the issue!
I've raised the PR to replace error with warning as a quick fix.

@viktor-kurchenko thanks raising the PR and letting me know. I believe it also needs to be fixed here

Well, the new PR will just log the error without returning it.
Does it make sense?

Yes but not complete, see my errors, there are two different (however related) errors

Encountering the same problem on cilium 1.16.4. On cilium 1.16.3 it still works.
Our cluster uses karpenter nodes for cilium, but it also runs one Fargate instance to run karpenter itself. That Fargate Karpenter Pod isn't managed by cilium. Maybe that is the problem?

Assuming it's safe to ignore Fargate nodes completely, how about something like:
labelSelector := "eks.amazonaws.com/compute-type notin (fargate)"
nodes, err := k.client.ListNodes(context.Background(), metav1.ListOptions{
	LabelSelector: labelSelector,
})

Found the last working cli release
0.16.20 still works, after it breaks the upgrade for our cluster. So problem is in since the last 2 cli releases.

Hey @marcofranssen and @gordonm
This PR should fix the error.
But still waiting for review...

I have also added another solution for the problem, in case it is decided to keep the AMI OS check. https://github.com/cilium/cilium/pull/36687
I'm fine either way, as long it gets fixed. Lets see what the maintainers think is the best way forward.


Disabling assert in libmp3lame to fix segfaults

Hi,
I've faced many segfaults in ffmpeg.
After inspecting the coredumps and searching around I've found this bug at VLC:
https://code.videolan.org/videolan/vlc/-/commit/c9e146e7872a6a16f9cf05e3f36aab14105cffa8
It appears that under certain circumstances ffmpeg can segfaults and disabling asserts in libmp3lame fix that.
In scripts.d/50-libmp3lame.sh, I've been able to do that with this line:
CFLAGS="$CFLAGS -DNDEBUG" ./configure "${myconf[@]}"
Do you think you could integrate this modification ?
Thanks.

That should be easy enough, and I'll give VLC the benefit of the doubt on this that it's safe.


Add theme colour to select id types button

This adds support for theme color in the id type selection screen.

Adding a few more changes


Images not loading on a preview page on the off. site

At the official site component preview page here images are not displayed. Probably some source issue

FWIW this project has been showing signs of rigor mortis for a while. You might want to move on (plume, tailwind, etc) .


(cStor-sparse) App stuck in containerCreating state on node recovery after multi-node failure (ephemeral disk-based pool registration)

Description
Application is seen to remain in containerCreating state due to inconsistencies in the cstor volume target, which was caused as a result of multiple failures on the cluster.
Expected Behavior
System/Cluster recovers from failures (such as service crashes, node reboots) etc., and application pod can be rescheduled with data written prior to failures still available.
Steps to Reproduce

Deployed percona application on cstor-sparse pools (volume created with 3 replicas)
Once Application pod entered running status, stopped the node's (say, node-1) kubelet service
This resulted in app pod getting rescheduled on node-2, while a stale pod continued to remain (in unknown status) on node-1. The pod was seen to remain in containerCreating state on node-2 post the reschedule.
Recovered node-1 (kubelet service brought online). With this, the pod entry in unknown status also disappeared.
Performed a graceful shutdown of the node-2. Application was node rescheduled on node-1 & remained in containerCreating state.
Recovered node-2
App was still not seen to run. Debug at this point revealed creation of new pools.

Logs for the above
after_chaos.txt
sathyaseelan_n@cloudshell:~ (strong-eon-153112)$ kubectl describe pod percona-786c6b7c7f-rnfz8 -n app-percona-ns
Name:           percona-786c6b7c7f-rnfz8
Namespace:      app-percona-ns
Node:           gke-vitta-cluster-default-pool-93336a3d-4n68/<IP_ADDRESS>
Start Time:     Tue, 13 Nov 2018 13:17:58 +0530
Labels:         name=percona
                pod-template-hash=3427263739
Annotations:    <none>
Status:         Pending
IP:
Controlled By:  ReplicaSet/percona-786c6b7c7f
Containers:
  percona:
    Container ID:
    Image:         percona
    Image ID:
    Port:          3306/TCP
    Host Port:     0/TCP
    Args:
      --ignore-db-dir
      lost+found
    State:          Waiting
      Reason:       ContainerCreating
    Ready:          False
    Restart Count:  0
    Limits:
      cpu:  500m
    Requests:
      cpu:  500m
    Environment:
      MYSQL_ROOT_PASSWORD:  k8sDem0
    Mounts:
      /var/lib/mysql from data-vol (rw)
      /var/run/secrets/kubernetes.io/serviceaccount from default-token-r5r8q (ro)
Conditions:
  Type           Status
  Initialized    True
  Ready          False
  PodScheduled   True
Volumes:
  data-vol:
    Type:       PersistentVolumeClaim (a reference to a PersistentVolumeClaim in the same namespace)
    ClaimName:  percona-mysql-claim
    ReadOnly:   false
  default-token-r5r8q:
    Type:        Secret (a volume populated by a Secret)
    SecretName:  default-token-r5r8q
    Optional:    false
QoS Class:       Burstable
Node-Selectors:  <none>
Tolerations:     node.kubernetes.io/not-ready:NoExecute for 300s
                 node.kubernetes.io/unreachable:NoExecute for 300s
Events:
  Type     Reason       Age                From                                                   Message
  ----     ------       ----               ----                                                   -------
  Warning  FailedMount  22m (x24 over 1h)  kubelet, gke-vitta-cluster-default-pool-93336a3d-4n68  MountVolume.WaitForAttach failed for volume "pvc-9131629d-e707-11e8-84fe-42010a800098" : failed to get any path for iscsi disk, last err seen:
iscsi: failed to attach disk: Error: iscsiadm: default: 1 session requested, but 1 already present.
iscsiadm: Could not log into all portals
 (exit status 15)
  Warning  FailedMount  3m (x40 over 1h)  kubelet, gke-vitta-cluster-default-pool-93336a3d-4n68  Unable to mount volumes for pod "percona-786c6b7c7f-rnfz8_app-percona-ns(7079fea3-e718-11e8-84fe-42010a800098)": timeout expired waiting for volumes to attach or mount for pod "app-percona-ns"/"percona-786c6b7c7f-rnfz8". list of unmounted volumes=[data-vol]. list of unattached volumes=[data-vol default-token-r5r8q]

Screenshots

Your Environment

Cluster type: GKE cluster
OS
OpenEBS version: 0.7.1

kubectl get nodes:

sathyaseelan_n@cloudshell:~ (strong-eon-153112)$ kubectl get nodes
NAME                                           STATUS    ROLES     AGE       VERSION
gke-vitta-cluster-default-pool-93336a3d-4n68   Ready     <none>    2h        v1.10.6-gke.2
gke-vitta-cluster-default-pool-93336a3d-pqkr   Ready     <none>    2h        v1.10.6-gke.2
gke-vitta-cluster-default-pool-93336a3d-xt01   Ready     <none>    4h        v1.10.6-gke.2

kubectl get pods --all-namespaces:

sathyaseelan_n@cloudshell:~ (strong-eon-153112)$ kubectl get pods --all-namespaces
NAMESPACE        NAME                                                              READY     STATUS              RESTARTS   AGE
app-percona-ns   percona-786c6b7c7f-rnfz8                                          0/1       ContainerCreating   0          2h
kube-system      event-exporter-v0.2.1-5f5b89fcc8-tz2v9                            2/2       Running             0          2h
kube-system      fluentd-gcp-scaler-7c5db745fc-2kb76                               1/1       Running             0          4h
kube-system      fluentd-gcp-v3.1.0-b2txk                                          2/2       Running             0          2h
kube-system      fluentd-gcp-v3.1.0-k2b78                                          2/2       Running             0          4h
kube-system      fluentd-gcp-v3.1.0-wvpcd                                          2/2       Running             0          4h
kube-system      heapster-v1.5.3-574b4fc8cd-2x7qh                                  3/3       Running             0          2h
kube-system      kube-dns-788979dc8f-55flt                                         4/4       Running             0          4h
kube-system      kube-dns-788979dc8f-6lnbq                                         4/4       Running             0          2h
kube-system      kube-dns-autoscaler-79b4b844b9-qjrp4                              1/1       Running             0          2h
kube-system      kube-proxy-gke-vitta-cluster-default-pool-93336a3d-4n68           1/1       Running             0          2h
kube-system      kube-proxy-gke-vitta-cluster-default-pool-93336a3d-pqkr           1/1       Running             0          1h
kube-system      kube-proxy-gke-vitta-cluster-default-pool-93336a3d-xt01           1/1       Running             0          4h
kube-system      l7-default-backend-5d5b9874d5-zqwtb                               1/1       Running             0          2h
kube-system      metrics-server-v0.2.1-7486f5bd67-bdcl5                            2/2       Running             0          4h
openebs          cstor-sparse-pool-7rhu-c4b6f6c5d-4sjzq                            2/2       Running             0          2h
openebs          cstor-sparse-pool-jpe2-dc7d5597b-sbtvs                            2/2       Running             0          4h
openebs          cstor-sparse-pool-t2qy-696d559894-njffw                           2/2       Running             0          2h
openebs          maya-apiserver-78db8786d7-lfdqr                                   1/1       Running             0          2h
openebs          openebs-ndm-4tbr5                                                 1/1       Running             0          4h
openebs          openebs-ndm-rxrzp                                                 1/1       Running             0          2h
openebs          openebs-ndm-sgrfb                                                 1/1       Running             0          4h
openebs          openebs-provisioner-6f7994f87b-f9chj                              1/1       Running             0          2h
openebs          openebs-snapshot-operator-5c998cddbd-bl7dd                        2/2       Running             0          2h
openebs          pvc-9131629d-e707-11e8-84fe-42010a800098-target-5bb575788dpmgmb   3/3       Running             0          4h

Fixes are available in 0.8.1(211) and master(206). Hence closing.


Allow the owner of a game to kick other players from the game

All players can kick others. Extend this functionality later.


Enable sdl2 forward compatibility

gfx_window_sdl requires sdl2 = "0.29" stopping usage of later sdl2 versions or requiring gfx to be updated manually for each sdl2 minor release.
Since this lib is used as a helper for sdl and isn't particularly likely to break with newer minor versions, it is more helpful to declare a minimum sdl2 version sdl2 = ">= 0.29, < 1". This allows a top-level consumer to declare, for example, sdl2 = "0" and have it work properly (ie currently fetching v0.30.0).
In the case newer versions cause issues, it is still clear which version(s) can be tried by viewing the minimum declared.
I've also added an sdl version of the triangle example, this adds a little compile assurance to gfx_window_sdl when running cargo test. I added the gfx dev-depencency sdl version to be sdl2 = "0" meaning the example will always test the latest 0 minor version, but this could be changed to sdl2 = "0.30" if greater build consistency is required. (However, I think its better as 0, as it matches the >= 0.29 better)
What are this projects views on forward compatibility of this sort?

I'd like us to avoid supporting another triangle example in the code base. Please check out #1258 for the way GLFW is tested.
As for sdl2 = ">= 0.29, < 1" condition, I think it goes against semver. We can't automatically use newer minor versions of non-stable dependencies.

gfx_window_sdl requires sdl2 = "0.29" stopping usage of later sdl2 versions or requiring gfx to be updated manually for each sdl2 minor release.

You don't have to use the newest release at every point in time, unless there are features you require. I suppose you can pick a version that gfx_window_sdl links to and work with that unless there is a blocker, in which case you can make a simple PR (even through Github web interface) to our crate and use a local override in the mean time. I don't think this situation is going to occur often. Let me know if your experience tell otherwise, or there are particular reasons to stick with the latest version of sdl all the time.

Thanks for taking a look. In that case I may as well convert this into updating sdl2 0.29 -> 0.30, and adding the window example.
To be honest though, I'll probably end up using my own fork of gfx_window_sdl when the next sdl update I fancy appears. But I can understand you wanting stronger consistency from the gfx point of view.

Thanks @alexheretic ! Code looks good, waiting for CI to test it.

Please squash the commits and fix CI errors to proceed.

Yeah just noticed the dev-dependencies thing, worked around it in the same way as glfw. For the commits can't you just click squash & merge ala

@alexheretic We're using homu, which does not support this.

@torkleyy Ok I've done it manually.

Thank you!
@homu r+

:pushpin: Commit dd5bcf7 has been approved by kvark

:hourglass: Testing commit dd5bcf7 with merge c8e37af...

:sunny: Test successful - status


Table Header Column Css Class

Hello... Loving this project so far.
I have a quick question. I am using the table component. I am specifying my ChildContent and my Column (s) for the table. And I need to make some of the columns dissapear on a small screen.
The Column child component has a CssClass parameter. But it only gets applied to the TD, not the TH. So, when the screen is small only the content is hidden, and the header stays.
How can I get around this?
Thanks

Hi!
If you can get the "if small screen" condition into a variable you can do
@if (!screenIsSmall)
{
    <Column>
        ....
    </Column>
}

Then the column won't be shown on smaller screens.
Maybe ResizeObserver can be of help as well https://tabblazor.com/docs/helpers/resize-observer.


finalized setup.py file

I rendered the .msi on my personal machine, ran fine for Windows.

Hello @Rw552! Thanks for opening this PR. We checked the lines you've touched for PEP 8 issues, and found:

In the file setup.py:

Line 9:9: E251 unexpected spaces around keyword / parameter equals
Line 9:11: E251 unexpected spaces around keyword / parameter equals
Line 10:12: E251 unexpected spaces around keyword / parameter equals
Line 10:14: E251 unexpected spaces around keyword / parameter equals
Line 11:16: E251 unexpected spaces around keyword / parameter equals
Line 11:18: E251 unexpected spaces around keyword / parameter equals
Line 12:12: E251 unexpected spaces around keyword / parameter equals
Line 12:14: E251 unexpected spaces around keyword / parameter equals
Line 13:29: E128 continuation line under-indented for visual indent
Line 13:58: E231 missing whitespace after ','
Line 13:68: E231 missing whitespace after ','
Line 13:80: E501 line too long (94 > 79 characters)
Line 13:82: E231 missing whitespace after ','
Line 14:16: E251 unexpected spaces around keyword / parameter equals
Line 14:18: E251 unexpected spaces around keyword / parameter equals
Line 15:2: W292 no newline at end of file

Cool. Do you think this would work on 64 bit windows as well?

Cool. Do you think this would work on 64 bit windows as well?

Uh I think so? Some of the GUI lines I left in from the documentation, so they may not be necessary. I think I’m running 64 bit windows right now on my test machine, but I just shut it down for the night. I’ll check it tomorrow.


PushNotification + Parse

Hello,
I'm currently trying to use PushNotificationIOS + Parse. However, the push notification is completely handled by Parse (and thus shown on the iphone, which means that the push notification arrives on the iphone successfully). The event in PushNotificationIOS is not triggered at all. Does anyone has experience with that?
My current debugging state is that the following function in the file RCTPushNotificationManager.m is not called at all, and thus it is not transferred to RN:

(void)handleRemoteNotificationReceived:(NSNotification *)notification
{
[_bridge.eventDispatcher sendDeviceEventWithName:@"remoteNotificationReceived"
body:[notification userInfo]];
}

Regards,
Philipp

I was able to fix it by adding the following code in appdelegate.m - however, I wonder why it is not working in RCTPushNotificationManager.m:

(void)application:(UIApplication *)application didReceiveRemoteNotification:(NSDictionary *)userInfo {
[[NSNotificationCenter defaultCenter] postNotificationName:@"RemoteNotificationReceived"
object:self
userInfo:userInfo];
}

I was looking for the exact same issue at the same time.
Thanks for your tip, I'm also clueless why that method isn't called in RCTPushNotificationManager.m, but needs to be included in AppDelegate. Method signature is identical, and for instance initWithInitialNotification is called correctly (in RCTPushNotificationManager.m)

I was working on this a week or two ago. IIRC, you should import "RCTPushNotificationManager.h" in AppDelegate. Then:
- (void)application:(UIApplication *)application didReceiveRemoteNotification:(NSDictionary *)userInfo     {
  [PFPush handlePush:userInfo];
  [RCTPushNotificationManager application:application didReceiveRemoteNotification:userInfo];
}

This might help. http://stackoverflow.com/questions/29683720/react-native-push-notifications-parse

@PhilippKrone seems u fix the problem. could you please teach me the detail?
I want to figure out, so if I use Parse(JS SDK) not iOS SDK so I do as follow could you help check it right?

Follow [Parse guide](https://parse.com/tutorials/ios-push-notifications until step 4.
Setup react-native PushNotificationIOS
Finally I can use Parse for send push and PushNotificationIOS can handle message.