Add flag to execute Hive queries as the user submitting the query

Adding the hive.read-as-query-user flag (default=false). When set to true Presto will read from HDFS as the user submitting the query. When set to false the query will read from HDFS as the presto daemon user.

Do we need similar code in https://github.com/facebook/presto/blob/master/presto-hive/src/main/java/com/facebook/presto/hive/HivePageSinkProvider.java

Do we need similar code in https://github.com/facebook/presto/blob/master/presto-hive/src/main/java/com/facebook/presto/hive/HivePageSinkProvider.java

We would need to do that to support hive.write-as-query-user which we don't yet support [1], but we plan to. We need to submit some more patches for CTAS that will require this, so my plan to was follow up with that in a separate patch.
1 - Per user temp directory: https://github.com/twitter-forks/presto/blob/twitter-master/presto-hive/src/main/java/com/facebook/presto/hive/HiveWriteUtils.java#L378

@billonahill: Teradata is actively working on supporting Kerberos in the Hive connector. As part of doing this, we get non-Kerberos impersonation basically for free. We have a branch in our fork that we'd love to have somebody else who has been working on this stuff take a look at.
I'll open an issue and add a link to our branch there, but in the meantime, you can check it out here:
https://github.com/Teradata/presto/tree/kerberos_hive_poc

Thanks for sharing that Eric, that's great. I do have a few comments, but
AFAIK I can't comment on a diff, only a PR. Could you make a PR just for
commenting?
On Thu, Jan 21, 2016 at 12:18 PM, Eric Diven<EMAIL_ADDRESS>wrote:

@billonahill https://github.com/billonahill: Teradata is actively
working on supporting Kerberos in the Hive connector. As part of doing
this, we get non-Kerberos impersonation basically for free. We have a
branch in our fork that we'd love to have somebody else who has been
working on this stuff take a look at.
I'll open an issue and add a link to our branch there, but in the
meantime, you can check it out here:
https://github.com/Teradata/presto/tree/kerberos_hive_poc
—
Reply to this email directly or view it on GitHub
https://github.com/facebook/presto/pull/4382#issuecomment-173696012.

@billonahill https://github.com/Teradata/presto/pull/105

Thanks @petroav and @ebd2, https://github.com/Teradata/presto/pull/105 looks good. We should focus on that PR instead of what I propose in this one.

https://github.com/prestodb/presto/pull/4867 has been merged, which it sounds like addresses this. If I misunderstood please re-open!


uxd initial review changes

This PR addresses several points mentioned in UXD's first review of Kaoto:

Swap out tiles for burger menu icon on Toolbar
Move Code Editor & Catalog icons closer together
Move Delete button (moved into dropdown)
Initial ADD STEP placeholder should be greyed out
Move mini map & controls together, but, ultimately, decided to hide the mini map for now (will create a separate issue to enhance it) because it's quite useless as you can't pan around yet
Made changes to attribution as requested
Based on @lhein 's feedback, changed it from a Play button to Deploy

Re-added header with helper text in Step Catalog
Re-added close icon
Add arrowhead to lines (small, you can barely see it, but it's there), also made all steps blue (we can change it to be animated on deployment or red/orange if not configured properly)

Moved Light/Dark mode into separate Appearance settings
Grouped together items in dropdown

Great. I still struggle a bit with how the settings work. In my desktop tooling world the settings menu would contain things like modifying the appearance of the UI but it seems in Kaoto Settings is more related to the project / integration. Maybe something to check with UX would be to have a "Project Settings" icon near the integration name and then use the right side settings menu for global settings only (which would include appearance settings)?

Great. I still struggle a bit with how the settings work. In my desktop tooling world the settings menu would contain things like modifying the appearance of the UI but it seems in Kaoto Settings is more related to the project / integration. Maybe something to check with UX would be to have a "Project Settings" icon near the integration name and then use the right side settings menu for global settings only (which would include appearance settings)?

@lhein I'm not sure if you were following the discussion on the UX review slides, but Missy also consulted with the UXD team about the naming, and, for me, it came down to this:

I reached out to the UX content team regarding this menu item they think Settings. Configuration or Preferences would work here so we can keep as is. We could move the dark/light mode in this dialog for now (until there are more "user" settings) and add subheadings to separate the WORKFLOW from the APPEARANCE.

So, to avoid scrolling in the settings with several sections, I decided to separate them into two modals. Alternatively we could 1) add a cog icon that opens all settings in one modal, like Milanote does, but we'd probably have to move the Delete button back to the toolbar, or 2) maybe add it in the left-hand dropdown, but that also doesn't feel super intuitive to me.
Personally I've never seen configuration settings accessed near something like the name, or in the middle of the toolbar, but maybe I'm not thinking of the right thing.


bodyParsers settings for FormData

I am trying to POST FormData from a React frontend using axios The client-side constructs the FormData object as it should, and I am able to iterate through the entries and see that my File is appended to FormData
Relevant code:
const drop = (file) => {
    const fd = new formData();
    fd.append('fileData', file);
    axios.post('http://localhost:3030/api/upload', fd, {
        headers: {
            'Content-Type': `multipart/form-data; boundary=${fd._boundary}`,
        }
    })
    .then(response => {
        console.log(response);
    })
    .catch(error => {
        console.log(error);
    });
}

This is my API:
"use strict";
const Busboy = require('busboy');
const ApiGateway = require("moleculer-web");
function uploader(req, res, next) {
	console.log(req.headers)
	const busboy = new Busboy({headers: req.headers});
	busboy.on('file', function(fieldname, file, filename, encoding, mimetype) {
		console.log('File [' + fieldname + ']: filename: ' + filename + ', encoding: ' + encoding + ', mimetype: ' + mimetype);
		file.on('data', function(data) {
		  console.log('File [' + fieldname + '] got ' + data.length + ' bytes');
		});
		file.on('end', function() {
		  console.log('File [' + fieldname + '] Finished');
		});
	  });

	res.end(next);
}

module.exports = {
	name: "api",
	mixins: [ApiGateway],
	// More info about settings: https://moleculer.services/docs/0.13/moleculer-web.html
	settings: {
		port: process.env.PORT || 3030,
		bodyParsers: {
			json: false,
			urlencoded: false,
		},
		routes: [{
			path: "/api",
			aliases: {
				"POST /upload": uploader,
			},
		}],
	}
};

The request reaches the API, butreq.body is always empty.
I banged my head around this problem and see nothing wrong with how I am constructing FormData The only place left for me to investigate is the API's bodyParsers setting.
I understand that for multipart/form-data requests, normal json and urlencoded parsers won't work and hence why I disabled them in favor of busboy But even that is not working.
Have I discovered a bug? Or is there a place in the documentation which could shed some light on this particular problem?

@rishighan FormData fields is available in ctx.meta.$multipart

Hmm. I tried that as well.
This is my service:
"use strict";

module.exports = {
	name: "assets",
	version: 1,
	settings: {

	},
	dependencies: [],
	actions: {
		upload: {
			cache: {
				keys: [],
			},
			params: {
				// payload: { type: "object", optional: false } ,

			},
			handler(context) {
                           console.log(context.params); // <- empty
                           console.log(context.meta) // <- undefined

			}
		}
	},
	events: {

	},
	methods: {

	},

	/**
	 * Service created lifecycle event handler
	 */
	created() {

		console.log("Assets service instance created");
	},

	/**
	 * Service started lifecycle event handler
	 */
	started() {
	},

	/**
	 * Service stopped lifecycle event handler
	 */
	stopped() {

	}
};

I am testing this on ‘localhost’ in Firefox with CORS restrictions disabled. I tried updating to the beta tag of ‘moleculer-web’ and trying ‘ctx.meta.$multipart’ but still getting nothing...

https://github.com/moleculerjs/moleculer-web/blob/master/CHANGELOG.md#file-upload-aliases
"POST /": "multipart:assets.upload",

I took that example and tried to hit http://localhost/3000/upload, keep getting 503 Unavailable

https://github.com/moleculerjs/moleculer-web/blob/master/CHANGELOG.md#file-upload-aliases
"POST /": "multipart:assets.upload",

Are my aliases incorrectly configured? I am on the most current beta for moleculer-web and using the file upload aliases and my action does have the multipart: tag. Still getting an empty ctx.params

Separately, for my own sanity, I took the code in the link you had shared, and changed it to point the actions in my service.
I tried hitting http://localhost:4000/upload and keep getting a 503 Service Unavailable and I am not sure if I understand the route configuration correctly.
I have a service called assets.service.js which I detailed in this comment
"use strict";
const Busboy = require("busboy");
const ApiGateway = require("moleculer-web");

module.exports = {
	mixins: [ApiGateway],
	settings: {
		port: 4000,
		path: "/upload",
		routes: [
			{
				path: "",
				// You should disable body parsers
				bodyParsers: {
					json: false,
					urlencoded: false
				},
				mappingPolicy: "restrict",
				aliases: {
					// File upload from HTML multipart form
					"POST /": "multipart:assets.upload",

					// File upload from AJAX or cURL
					"PUT /": "stream:assets.upload",

					// File upload from HTML form and overwrite busboy config
					"POST /multi": {
						type: "multipart",
						// Action level busboy config
						busboyConfig: {
							limits: {
								files: 3
							}
						},
						action: "assets.upload"
					}
				},

				// Route level busboy config.
				// More info: https://github.com/mscdex/busboy#busboy-methods
				busboyConfig: {
					limits: {
						files: 1
					}
					// Can be defined limit event handlers
					// `onPartsLimit`, `onFilesLimit` or `onFieldsLimit`
				},

			}
		]
	}
};

Could you create a reproduce repo?

Sure: https://github.com/rishighan/assets-service

And how do you send file?

The problem is that, you set the version number in assets service, so your action name in aliases is v1.assets.upload and not assets.upload

@icebob that was it! I did not know that an action would've to be accessed with a version prefix, if the service has that property defined.
One more thing to note: the FileStream object is made available in ctx.params and not ctx.meta.$multipart as previously mentioned.
Either way, thanks for your help, I can finally close this issue.

You're welcome.
I think nobody mentioned that File stream will be in ctx.meta. The ctx.params will be the Stream and the additional FormData will be in ctx.meta.$multipart.

You're welcome.
I think nobody mentioned that File stream will be in ctx.meta. The ctx.params will be the Stream and the additional FormData will be in ctx.meta.$multipart.

How to get it From Route-level middlewares ?  I'm testing with req.body but it's empty


feat: reclustering / reshard

Avoids big downtimes by reclustering / resharding indomitable one by one keeping the old processes alive until it's their turn to be reconfigured.

Will now also be included in https://github.com/Deivu/Indomitable/pull/3


add base64 util test

Codecov Report

:exclamation: No coverage uploaded for pull request base (main@6097ac9). Click here to learn what that means.
The diff coverage is n/a.

@@          Coverage Diff           @@
##             main     #12   +/-   ##
======================================
  Coverage        ?   3.30%
  Complexity      ?      19
======================================
  Files           ?      50
  Lines           ?     847
  Branches        ?     144
======================================
  Hits            ?      28
  Misses          ?     819
  Partials        ?       0

Flag
Coverage Δ

unittests
3.30% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6097ac9...be88542. Read the comment docs.


Zod validation errors when using streaming with functions/tools

Started getting this error after the upgrade (after fixing any breaking changes I could identify):
ZodError: [
  {
    "code": "invalid_type",
    "expected": "string",
    "received": "null",
    "path": [
      "data",
      "choices",
      0,
      "delta",
      "content"
    ],
    "message": "Expected string, received null"
  },
  {
    "code": "invalid_literal",
    "expected": "function",
    "path": [
      "data",
      "choices",
      0,
      "delta",
      "tool_calls",
      0,
      "type"
    ],
    "message": "Invalid literal value, expected \"function\""
  }
]
    at get error [as error] (<dir>/node_modules/.pnpm/zod@3.23.8/node_modules/zod/lib/types.js:55:31)
    at ZodObject.parse (<dir>/node_modules/.pnpm/zod@3.23.8/node_modules/zod/lib/types.js:160:22)
    at decoder (<dir>/node_modules/.pnpm/@mistralai+mistralai@1.0.2_zod@3.23.8/node_modules/@mistralai/mistralai/funcs/chatStream.js:96:31)
    at parseEvent (<dir>/node_modules/.pnpm/@mistralai+mistralai@1.0.2_zod@3.23.8/node_modules/@mistralai/mistralai/lib/event-streams.js:149:12)
    at [Symbol.asyncIterator] (<dir>/node_modules/.pnpm/@mistralai+mistralai@1.0.2_zod@3.23.8/node_modules/@mistralai/mistralai/lib/event-streams.js:42:35)
    at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
    at async Object.start (<dir>/src/lib/server/streams.ts:13:28)

Thank you for testing and reporting this issue.
This PR https://github.com/mistralai/client-ts/pull/15 will address the issue "message": "Invalid literal value, expected \"function\"", the other one will be fix with a change with our API and we will let you know once it is live.

Thank you @GaspardBT 👍 do you happen to have an estimate for when these changes will be published to npm?

It will be once this PR is merged 👍 (soon hopefully)


File vocabulary_movie

Hello, how to generate a new file vocabulary_movie for my data?

Check lines 51-60 of get_train_data.py. Just be careful with the index of the special symbols, BOS and EOS, their positions/indexes in the dictionary must be the same.

I already figured out. There was a misunderstanding with the code from the file split_qa.py:
for i, raw_word in enumerate(text):
pos = raw_word.find('+++$+++')
if pos > -1:
    person = raw_word[pos+7:pos+10]
    raw_word = raw_word[pos+8:]
while pos > -1:
    pos = raw_word.find('+++$+++')
    raw_word = raw_word[pos+2:]

raw_word = raw_word.replace('$+++','')
previous_person = person

What are signatures used for '+++$+++', '$+++' ? There are no such signatures in the text, variable 'persons' stays empty

Okay, next time, please close the issue after finding the solution.


Contribution graph page loads but does not show any information

Installed on premis, TFS 2017 update 2. When loading the page it only shows "Review | Report an Issue" in the upper right corner - no other information is displayed.
Debugging in browser shows a script error on File: contributionsHub.js, Line: 71, Column: 132:
Return Q.all([navigationService.getCurrentState(), filter_1.defaultFilter.getValue()]).then(([state, defaultFilter]) => {
	                const [hash] = Object.keys(state);
	                if (hash) {
	                    return parseHashStr(hash);
	                }
	                return defaultFilter;
	            });

Spesifically on the => line.
Known issue or related to on-premise solution?

I think this a browser issue specifically and ie issue.

Patched, IE is now working again


Cartesian product example makes no sense with current parameters

The Cartesian product example makes no sense when the 3rd column is fixed at a single value ([5]).
It should be 2 values for 2nd column and 3 values for 3rd column, as in the previous example, so the difference can be made apparent.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 5ec66d4d-34dc-ad45-e456-afaa20947616
Version Independent ID: 45e221db-2874-b65d-d67a-4bd6ebb203fd
Content: mv-expand operator - Azure Data Explorer
Content Source: data-explorer/kusto/query/mvexpandoperator.md
Service: data-explorer
GitHub Login: @orspod
Microsoft Alias: orspodek

Thanks for the feedback and bringing this to our notice . At this time we are reviewing the feedback and will update the document as appropriate .

@SsandmanN - see PR: https://github.com/MicrosoftDocs/dataexplorer-docs-pr/pull/789 with doc changes that should answer your question. Closing this issue.


Feature/runner complain

@louismerlin do you know why the CI is complaining?

Yup, new version of clippy == new things it complains about. Merged main into your branch :smile:


Issue Credential Protocol: accepted credentials are saved by credential type as name

Current behaviour:

Accepted credentials are saved by credential type as name in db ( as db key).

Problems:

very likely to have db key collision
can't save multiple credentials of same type (for ex: CreditCardStatement, CrudeProductCredential)
holder should know the exact type in advance to query it later which doesn't make sense in few scenarios (ex: wallet getting consent credentials from issuer)
holder is forced to call db twice for getting actual credential (get id by credential name and get credential by ID)

Proposal

Credentials should be saved by credential ID in db (Note: credential ID is unique and aries vc store uses uuid if credential id is missing)
accept credential should return id of credential saved, so that holder can retrieve it later (or correlate)

@sudeshrshetty  Credentials are stored under the provided name. If the name is absent then we will use an ID. If ID is absent then we will generate UUID. https://github.com/hyperledger/aries-framework-go/blob/master/pkg/didcomm/protocol/middleware/issuecredential/middlewares.go#L62
Could you please provide the credential you are using?

thanks @soluchok .
I was unaware that we can pass arbitrary names in request while accepting credentials.
I will close this issue.


Bash Heredoc Support

Hello,
I understand each justfile line executed as a separate command, since (from the docs):

Recipes without an initial shebang are evaluated and run line-by-line, which means that multi-line constructs probably won’t do what you want.

I would, however, like heredoc support, so that I can write multiline heredoc such as the following, without requiring a shebang:
generate_justfile:
    cat <<EOF > generated/Justfile
    default:
      @just --list
    EOF

I don't think that's currently possible. You could do this:
generate_justfile:
    cat <<EOF > generated/Justfile \
    default: \
      @just --list \
    EOF

But I think just would mangle the indentation in that case, and the string wouldn't be correct.
Using a shebang recipe isn't perfect, but wouldn't be too bad:
generate_justfile:
    #!/usr/bin/env bash
    set -euxo pipefail
    cat <<EOF > generated/Justfile
    default:
      @just --list
    EOF

Another option would be to use a variable:
export DEFAULT_JUSTFILE := '''
    default:
      @just --list
'''

generate_justfile:
	printf '%s' "$DEFAULT_JUSTFILE" > generated/Justfile

The dance with an exported environment variable and printf is to prevent the shell from interpreting any special characters in the justfile.
I'm going to go ahead and close this. It would be useful to support heredocs in linewise recipes, but I can't see a clean way to do.

Would it be possible to add this in the manual? It is exactly what I needed for my use case!

@filipdutescu I'm not opposed, although I'm not exactly sure where in the readme it would go, or how it would be worded 🤔

Maybe it could have it's own section? Or maybe a generic "Advanced usage"/"Tips and tricks"? Could be in a "Troubleshooting" or "Examples" section as well. Just throwing out some ideas.

I think that's reasonable. Can you elaborate a little bit on what was the thing that was helpeful? Was it that you can do dedented strings with '''…''', or was it the bit with using printf to print them?

Yes, sorry, I completely forgot to do that! The combination of the two mostly, but the other alternatives also helped, since I saw different options and could better understand what worked for my use case.
I just never thought of the printf option at all until I saw it here!
Thanks a lot for considering this and working with me to make it happen!

I added a section to the readme, which tries to mention everything together about printing complex strings, like using triple-quoted strings, printf instead of echo, and exporting them. It also mentions heredocs. I think it's a good addition, because all this is quite esoteric.

This is perfect! And very detailed! Thank you very much for the time and effort!


fix(storage): Add wrapper function for storage clear

Safari doesn't have managed storage and it causes extension to crash.
Managed storage returns undefined for safari so it can't find browser.storage.managed.clear throws error

Released in v1.1.3


Camera cannot be used from a threaded context

from picamera2.picamera2 import *

import threading

picam2 = Picamera2()
preview_config = picam2.preview_configuration()
picam2.configure(preview_config)

def worker():
	print('capturing')
	picam2.capture_file("test.jpg")
	print('captured and saved')

picam2.start()

thread = threading.Thread(target=worker)
thread.start()
print('thread started')
thread.join()
print('thread_completed')

Above is a minimal example of the problem. The problem remains if the camera is passed in as an argument and when it is started from inside the threaded context. From my own testing it seems that it is unable to capture the request.

Hi, thanks for reporting this. As far as I can see you may not be starting a "preview", which is really an event loop that drives the camera (see here). So maybe put picam2.start_preview() just after the picam2.start()?

Yep. I promise I've read through that whole page like 10 times now, and still forgot about that.
I do have to say that for contexts where having a 'preview window' is entirely unnecessary, it's a surprise that you need to have one, even if it is the "null" preview. Even the concept of a "null preview" is pretty confusing. Personally I think that's a bit of a design failure. Perhaps there's a way to create a null preview by default when the camera is started?

Fully understood about this being a preview release, and as I've said before - thanks for your effort. I only meant it as a suggestion for how I think the final product should look, not how I expect it to be right now.
That said, if my opinion matters at all, I think that useful code should fail fast and loud. The easiest solution in my mind is just to throw an informative error or at least a warning when you try to capture a request, but there's no preview window started. I can easily throw together a PR for that.
I think the best solution is probably the one you mention - you must start your preview window before calling start. If it's a requirement for using the camera, why would it not be required before you start using it?
Just my two cents. I'd be happy to put something together for either.

Hi, thanks for the suggestion. In the first instance I'm still quite keen to see if the whole thing can be run in a thread separate from the Qt one as that could have some other advantages. But obviously that's all for after the Easter break now.


 This way it will get there sooner. We usually push doc changes right away to master.

I've created a new patch with some more fixes.
Please see #2739


WeatherKit

WeatherKit has a CurrentWeather.isDaylight property and SunEvents struct that essentially replicate the functionality of this library. However, WeatherKit is only available for this year’s operating system releases (iOS 16, iPadOS 16, macOS 13, tvOS 16, watchOS 9). Should this library somehow integrate with WeatherKit on supported platforms, perhaps becoming a compatibility shim for it on unsupported Swift platforms like Linux?

This might be a tad optimistic, considering potential pricing and usage limits around WeatherKit in general, but I opened it in case the presumably local stuff above is exempt.

Yeah, it’s unfortunate that the calendrical functionality got bundled up with the live weather functionality. Maybe a good next step would be to see how well this library and WeatherKit agree on the sunrise/sunset calculations?


src: don't run timers before entering event loop

There should be no need to run timers prior to entering the event loop. Instead allow them to run normally at the end after the poll phase is complete.
Ref: https://github.com/libuv/libuv/pull/3927
Ref: https://github.com/libuv/libuv/issues/4017
@vtjnash We had discussed making this change in the original PR.

@vtjnash So the test flakiness is also a problem on v1.x?

I saw failures there too, yes. I haven't done extensive testing to check them however.


Enhance Test Coverage for @yamada-ui/input

package: @yamada-ui/input
Description
@yamada-ui/input has a test coverage of less than 80%. We will enhance it to above 80%.
Target files

packages/components/input/src/input-addon.tsx

L19
L57
L70

Problem Statement/Justification
Testing is essential to ensure quality when operating a package.
Additional Information
While it's ideal to cover all tests, if there are too many lines to work on, please create a PR within your capacity.
Any deficiencies not covered by the PR will be automatically created as issues.

@hirotomoyamada

hello!
May I work on this issue?

@JauneBrillant
Hi, thanks for the comment!
Yes, please!

Fixed


Cannot connect to Azure service: KeyError

Environment

Python: 3.6 x64
pyodbc: 4.0.23
OS: Windows 10
DB: Azure SQL server
driver: ODBC Driver 13 for SQL Server/SQL Server/SQL Native Client 11.0

Issue
Cannot connect to Azure Service. Error is KeyError: 'ODBC Driver 13 for SQL Server' (or other driver name)
My connection string is:
conn = pyodbc.connect('DRIVER={ODBC Driver 13 for SQL Server};SERVER={0};PORT=1433;DATABASE={1};UID={2};PWD={3}'.format(AzureServerPrefix + '.database.windows.net', DB, User, Pwd))
accordingly to suggestions from microsoft
https://docs.microsoft.com/en-us/azure/sql-database/sql-database-connect-query-python
Tried also other drivers SQL Server/SQL Native Client 11.0. All of them are available in my machine for ODBC x64 for system DSN.
also tried other format for connection strings that suggested under
https://www.connectionstrings.com/sql-azure/
but have no luck as well :
'Data source name not found and no default driver specified (0) (SQLDriverConnect)')'

Try to put the connection string directly as in pyodbc.connect('driver={ODBC Driver 13 for SQL Server};server=yourserver;database=yourdb;uid=youruser;pwd=yourpass'), also notice that Azure SQL does not have a fixed port number so do not specify the port in the connection string.
Provide an ODBC trace for further assistance.

bug is not valid


[HttpClient] Create Proxy Strawman

Before we begin to refactor some of the larger proxies, we first need to figure out how we want to structure our proxies going forward. For this task, we are going to create a strawman proposal for what it should look like for the HTTP Client. This proxy was chosen because it is very simple and already incorporated some elements of the proposal.

Whoops, created this on the wrong repo. My mistake.


Azure Cloud Service (classic) with EF Core 3.1 => sni.dll not found

Describe the bug
Using EF Core 3.1 with Azure Cloud Service (worker role) ends with
Failed to load ...\SniBugDemo\EFCore31Demo.Azure\csx\Debug\roles\EFCore31Demo.WorkerRole\approot\x64\SNI.dll
Stack trace:
at System.Threading.Tasks.Task.ThrowIfExceptional(Boolean includeTaskCanceledExceptions)
at System.Threading.Tasks.Task.Wait(Int32 millisecondsTimeout, CancellationToken cancellationToken)
at System.Threading.Tasks.Task.Wait()
at EFCore31Demo.WorkerRole.WorkerRole.Run() in D:\Projects\GitHub\SniBugDemo\EFCore31Demo.WorkerRole\WorkerRole.cs:line 21
at Microsoft.WindowsAzure.ServiceRuntime.RoleEnvironment.StartRoleInternal()
at Microsoft.WindowsAzure.ServiceRuntime.Implementation.Loader.RoleRuntimeBridge.b__2()
at System.Threading.ExecutionContext.RunInternal(ExecutionContext executionContext, ContextCallback callback, Object state, Boolean preserveSyncCtx)
at System.Threading.ExecutionContext.Run(ExecutionContext executionContext, ContextCallback callback, Object state, Boolean preserveSyncCtx)
at System.Threading.ExecutionContext.Run(ExecutionContext executionContext, ContextCallback callback, Object state)
at System.Threading.ThreadHelper.ThreadStart()
As I can say looks like x64\SNI.dll and x86\SNI.dll were not copied into Azure Cloud Service project.
For example: This is Worker Role DLL "bin" project folder

And this is Azure project folder.

As you can see x64 and x86 folders are missing.
To reproduce
I put source code here:
https://github.com/VeselovAndrey/SniBugDemo
Run "EFCore31Demo.Azure" to reproduce error (you even don't need DB to see an error)
Console app here just to make sure that code is working.
Same happens on publishing to Azure Cloud (it fails in cloud with same message).
Expected behavior
DLLs must be copied to Azure project and package
Further technical details
Microsoft.Data.SqlClient package version: both 1.0.19235.1 and 1.1.0
.NET target: .NET Framework 4.7.2
SQL Server version: LocalDB, SQL Server Azure
Operating system: Windows 10 (dev PC) Windows Server in Azure

Hi @VeselovAndrey
I am able to reproduce the problem and can see why it's happening.
Looks like you're using "Microsoft.WindowsAzure.targets" which is responsible to copy your Worker files from EFCore31Demo.WorkerRole\bin\Debug folder to intermediate path \EFCore31Demo.Azure\obj\Debug\EFCore31Demo.WorkerRole\. But it leaves out SNI DLLs in x86 and x64 folders, and copies the rest.
In order to support this, we have to add support to copy SNI files within target "CopyRoleFiles".
We're working on adding the same, could you verify by appending below targets in your "EFCore31Demo.Azure.ccproj" file:
<Import Project="..\packages\Microsoft.Data.SqlClient.SNI.1.1.0\build\net46\Microsoft.Data.SqlClient.SNI.targets" Condition="Exists('..\packages\Microsoft.Data.SqlClient.SNI.1.1.0\build\net46\Microsoft.Data.SqlClient.SNI.targets')" />
<Target Name="CopySNIRoleFiles"
        Condition="'@(WorkerRoleReferences)' != ''"
        Inputs="@(SNIFiles)"
        Outputs="@(SNIFiles -> '$(_IntermediateWorkerOutputPath)%(RecursiveDir)%(Filename)%(Extension)')">
  <PropertyGroup>
    <_IntermediateWorkerOutputPath>%(WorkerRoleReferences.OutputDir)</_IntermediateWorkerOutputPath>
  </PropertyGroup>
  <Copy SourceFiles="@(SNIFiles)"
        DestinationFiles="@(SNIFiles -> '$(_IntermediateWorkerOutputPath)%(RecursiveDir)%(Filename)%(Extension)')" />
</Target>
<PropertyGroup>
  <CollectRoleFilesDependsOn>
    $(CollectRoleFilesDependsOn);
    CollectSNIFiles;
  </CollectRoleFilesDependsOn>
  <CopyRoleFilesDependsOn>
    $(CopyRoleFilesDependsOn)
    CopySNIRoleFiles;
  </CopyRoleFilesDependsOn>
</PropertyGroup>

@cheenamalhotra Thanks for response!
I tested your proposal on test project and it works. I also tested same fix with deployment to Azure - it also works.
Thanks for this fix. I hope new NuGet package will be released soon. :)

Hi @VeselovAndrey
Microsoft.Data.SqlClient.SNI v1.1.1 has been released, please add reference to the same to get support for Azure Cloud SDK targets.
Closing the issue as fixed and delivered.

I have the same issue and the fix doesn't work for me. But there are a few differences:

I am using the new project format:

<Project Sdk="Microsoft.NET.Sdk">
  <PropertyGroup>
    <TargetFramework>net472</TargetFramework>
  </PropertyGroup>
  <ItemGroup>
    <PackageReference Include="Microsoft.Azure.WebJobs.ServiceBus" Version="2.2.0" />
    <PackageReference Include="Microsoft.Data.SqlClient" Version="1.1.0" />
    <PackageReference Include="Microsoft.Data.SqlClient.SNI" Version="1.1.1" />
    <PackageReference Include="Microsoft.EntityFrameworkCore.SqlServer" Version="3.1.1" />
    <PackageReference Include="Newtonsoft.Json" Version="10.0.3" />
    <PackageReference Include="Microsoft.NET.Sdk.Functions" Version="1.0.27" />
  </ItemGroup>
  <Import Project="..\..\packages\Microsoft.Data.SqlClient.SNI.1.1.1\build\net46\Microsoft.Data.SqlClient.SNI.targets" Condition="Exists('..\..\packages\Microsoft.Data.SqlClient.SNI.1.1.1\build\net46\Microsoft.Data.SqlClient.SNI.targets')" />
</Project>

This is Azure Function project.

Is there anything else I should do to fix it?

@marisks
I think you might be using dotnet build where another "bin" directory is created inside "bin\Debug\net472" whereas if you perform msbuild there is no additional "bin" folder and x86 and x64 folders are in sync with other dlls.
I think this is an inconsistency from the msbuild and dotnet build tools, but in order to support the same we'd have to consider this "DestinationSubDirectory" attribute as well. For now, I'd recommend using msbuild instead, while we investigate if there are more such cases. I'll open a different issue to track this case.
Let us know if find any more such behaviors, by opening a new ticket.

@cheenamalhotra Thanks! This sounds like the case I have. I will try with MSBuild.

@cheenamalhotra Using msbuild didn't help. It still creates bin folder inside "bin\Debug\net472" and SNI.dll folders are not copied there.
I will try to upgrade to Azure Functions v2.

@cheenamalhotra Sorry for late response but I just have time to update package. And its look like it not works. Can you explain what I did wrong? Example update to 1.1.1
https://github.com/VeselovAndrey/SniBugDemo (branch master-1-1-1)


Missing get_dreamplace_params function

Hi,
I have tried to run DREAMPlace to place the soft macros for the Ariane testcase available in the test_data directory using the following command:
python3 -m circuit_training.dreamplace.dreamplace_main --netlist_file=circuit_training/environment/test_data/ariane/netlist.pb.txt --init_placement=circuit_training/environment/test_data/ariane/initial.plc --output_dir=./output

The following screenshot shows the error message. Error message is AttributeError: module 'dreamplace.Params' has no attribute 'get_dreamplace_params'

I have used the ubuntu_circuit_training docker build.
Also, I have looked into the DREAMPlace Params.py and I do not see any get_dreamplace_params function. So could you please also provide the changes required in DREAMPlace to make it work with CT?
Thanks,
Sayak

Hi,
You should clone and install this branch
https://github.com/limbo018/DREAMPlace/blob/circuit_training/dreamplace/Params.py
of
the DREAMPlace. I'll change that in our code.
Thanks,
Ebrahim
On Sun, Feb 5, 2023 at 2:39 PM Sayak Kundu @.***> wrote:

Hi,
I have tried to run DREAMPlace to place the soft macros for the Ariane
testcase available in the test_data
https://github.com/google-research/circuit_training/tree/main/circuit_training/environment/test_data/ariane
directory using the following command:
python3 -m circuit_training.dreamplace.dreamplace_main --netlist_file=circuit_training/environment/test_data/ariane/netlist.pb.txt --init_placement=circuit_training/environment/test_data/ariane/initial.plc --output_dir=./output
The following screenshot shows the error message. Error message is AttributeError:
module 'dreamplace.Params' has no attribute 'get_dreamplace_params'
[image: image]
https://user-images.githubusercontent.com/80145162/216849741-c0f21ea2-cb4f-4aad-ad33-3d5ad301b7a6.png
I have used the ubuntu_circuit_training
https://github.com/google-research/circuit_training/blob/main/tools/docker/ubuntu_circuit_training
docker build.
Also, I have looked into the DREAMPlace Params.py
https://github.com/limbo018/DREAMPlace/blob/master/dreamplace/Params.py
and I do not see any get_dreamplace_params function. So could you please
also provide the changes required in DREAMPlace to make it work with CT?
Thanks,
Sayak
—
Reply to this email directly, view it on GitHub
https://github.com/google-research/circuit_training/issues/46, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/ABKKGW7HPJQLSFOE5LYHUE3WWATYPANCNFSM6AAAAAAUSAV2P4
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>

Hi @esonghori
Thank you for sharing the details. I have cloned the circuit_training branch of DREAMPlace and tried to run the following command. I have not received the previous error. But I am getting some new error.
python3 -m circuit_training.dreamplace.dreamplace_main --netlist_file=./circuit_training/environment/test_data/ariane/netlist.pb.txt --init_placement=./circuit_training/environment/test_data/ariane/initial.plc --output_dir=./output

Here is the screenshot of the error message:

Here is the log file
) of the above run. Please let me know if I am doing something wrong and how to fix this problem.
Thanks again,
Sayak

The problem is the numpy float type.  Can you change this line to float64 and retry: https://github.com/google-research/circuit_training/blob/334646f4bc70b757243b4184f713f2532ac77f97/circuit_training/dreamplace/plc_converter.py#L467

Hi @esonghori
I looked into the code and based on my understanding CT is not updating the DREAMPlace C++ database. So, I commented this line and now I can run the following command without any error.
python3 -m circuit_training.dreamplace.dreamplace_main --netlist_file=./circuit_training/environment/test_data/ariane/netlist.pb.txt --init_placement=./circuit_training/environment/test_data/ariane/initial.plc --output_dir=./output

Thanks,
Sayak


[release/0.6] resource synchro: fix set runnable for storage

What type of PR is this?
/kind bug

What this PR does / why we need it:
Which issue(s) this PR fixes:
pr https://github.com/clusterpedia-io/clusterpedia/pull/493
Special notes for your reviewer:
Does this PR introduce a user-facing change?:

/lgtm


Add 'single_index'

For #161
Using the same convention as single_lookup, I.E:
- Assumes Tensor needs expanding prior to predict.
- Same method name notation
Please let me know if you'd prefer I implemented inside of the existing index method.

Hi,
I've made the requested changes to naming convention and testing. Note I accidentally pushed on my work machine so my git user had no CLA signature. I dropped that commit and then re-did it on my personal account - Sorry about that.
Cheers,
Alex


How can I style my table?

Hello, how can I style my table, i.e. pagination? Is the idea to do this through core_components as page_size_link? But how I need to write that?

I'm not sure I understand the question. The components use default CSS classes that can be overridden, as described here. To style the components, you just write CSS styles for those classes, or set utility classes (e.g. Tailwind) in the options.

I'm sorry, I somehow missed this page... But one question still remains. I added the filter_form as in the documentation. But it complains that filter_fields is missing. Is there also an example how this must look like? I don't find it...
  def filter_form(%{meta: meta} = assigns) do
    assigns = assign(assigns, form: Phoenix.Component.to_form(meta), meta: nil)

    ~H"""
    <.form for={@form} id={@id} phx-target={@target} phx-change={@on_change} phx-submit={@on_change}>
      <.filter_fields :let={i} form={@form} fields={@fields}>
        <.input field={i.field} label={i.label} type={i.type} phx-debounce={120} {i.rest} />
      </.filter_fields>

      <button class="button" name="reset">reset</button>
    </.form>
    """
  end

Ah ok, i need to import Flop.Phoenix into CoreComponents. Now it renders the filter


Update Grafana to 7.1.5 and its dependencies

What's this PR about
This is update for Grafana 7.1.5 and its dependencies:

Zabbix DataSource (2.1.0)
ClickHouse DataSource (4.0.1)

TODO's:

[x] Run perfecto check on your spec file
[x] Write bibop tests
[x] Enable "Allow edits from maintainers" for this PR
[x] Update the messages below

Did you try to build the package with this spec?: Yes
Is this ready for review?: Yes

Looks good, merged. Thanks!

Packages were built and added to kaos-testing repository.
@gongled FYI It was impossible to build a grafana package based on this PR. Build failed on an attempt to apply 000-grafana-fhs-fix.patch. So I fixed that in b20865ab1b646537f6d410314ed47bdbe8fe9df7.


Map appears in background when ImageBasemaps is selected in Prod mode but not in Dev mode.

Describe the bug
When in Production mode the map appears in the background when displaying an image basemap instead of white background.
To Reproduce
Are you able to reproduce the problem in a new project after restarting the app?

Smartphone (please complete the following information):

Device: IPad Pro
OS: 13.x
StraboSpot2 Version 0.5.3

Additional context
Add any other context about the problem here.

@NathanNovak Can you please help me set up a production system, to debug this issue ? locally.

@sdamaraju See how we fixed this in commit 2d053ce68aa5733e43d3c17abf06b869a720bc58. Just needed to wrap BackgroundLayer in VectorSource.


Not possible to disable admin token

Trying to use this chart to replace another old one that i was using but running into issues...
The docs recommend setting adminToken=null to disable admin token but this does not work because because the secrets.yaml template tries to read .Values.adminToken.existingSecret which doesn't work because adminToken is null.
Setting adminToken.value to null also does not work as the chart tries to use the existing secret which i also do not want to use in the _podSec.tpl.

I faced the same problem and managed to work around it by creating a secret where the key referenced is empty.
# Not sure if it's necessary, so watch out for empty space at the end
kubectl -n vaultwarden create secret generic vaultwarden-disable-admin --from-literal=token=

adminToken:
  existingSecret: "vaultwarden-disable-admin"
  existingSecretKey: "token"

@JoaoSangue but does that not result in
[WARNING] `ADMIN_TOKEN` is enabled but has an empty value, so the admin page will be disabled.
[WARNING] To enable the admin page without a token, use `DISABLE_ADMIN_TOKEN`.


Updated tuf/api/metadata.py

Signed-off-by: Abhisman Sarkar<EMAIL_ADDRESS>Fixes #1938
Description of the changes being introduced by the pull request:
Annotated 'unrecognized_fields' as Dict instead of Mapping
Please verify and check that the pull request fulfills the following
requirements:

[ ✔] The code follows the Code Style Guidelines
[-] Tests have been added for the bug fix or new feature
[-] Docs have been added for the bug fix or new feature

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

5 of 5 (100.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 98.326%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
1187

Relevant Lines:
1203

💛  - Coveralls

The DCO check is likely failing because the bot requires every commit to have Signed-off-by.
squashing your changes into one commit and force pushing this branch is fine by me (so is a new branch with a new PR, totally up to you): result should be a branch with just a single commit on top of develop.
I would prefer a more descriptive commit message (one that answer question "Why?"). Something like this would workMetadata API: Annotate 'unrecognized_fields' as Dict

Annotating them Mapping seems to be wrong as we may actually want to
modify the contents in the repository code

Signed-off-by: Abhisman Sarkar<EMAIL_ADDRESS>

As advice, I suggest using a branch per PR (so not using your abs007:develop branch): it probably makes things easier. That said, technically using abs007:develop works just as well -- it just means if you modify or update your develop branch, this PR changes when you push

Thanks for the help. I will go on and make a new pr since as you said that further changes on develop would change this pr.


[FEAT]: Create tool to add/edit multiple custom attributes

Script would work exactly like the "Add attribute" function, but it would retain the parameters and allow for multiple variables (separated by commas)

I'd like to take this issue up if it's still open

I'd like to take this issue up if it's still open

Hey @NovusEdge
Yes, feel free to create it. Any help would be more than welcome.
To clarify the idea, here is a better description:
I thought of using a textField with a list of attributes the user could add to the selected objects.
This textField would allow for multiple attributes to be added at the same time (these would be separated by commas)
Ideally the script would also have an option to also delete all attributes in the list. (in case incorrectly created)
Here are some other things we could add:

All the options present in the “Add attribute” windows (so the user can customize what they want)
A button to create a “separator” attribute (essentially a locked attribute with an enum containing dashes “-------” to be used as a separator)
Maybe an import/export option?

Ideally the UI would be consistent with the rest of the scripts. So feel free to copy an existing script so you can to extract it from them.  "GT Path Manager" uses a QT version of it, while most of the other ones rely on Maya Cmds and the Open Maya library. "GT Generate Text Curve" has a similar system that uses a textfield to create curves, so it could be a good starting point.
If possible, try to keep all the code within the same script. I know it might be a bit inconvenient as it would be easier to create modules, but I'm trying to keep all scripts "standalone" in case people don't want to download the entire package.
Let me know in case you need any clarification or help :)

Consider adding:

Textfield with list of affected attributes.
Hide/unhide attributes for selected elements.
Lock/unlock attributes for selected elements.
Auto create a list of attributes for selected elements.
Auto delete a list of attributes for selected elements.
Maybe attempt to change the order of the attributes within Maya.

Will track using "Projects"


create db regardless of allow-share flag

cache also requires db, and compile.go always tries to use db to check
for cache, when running without -allow-share it crashes

Thanks @nnnn20430, sorry for the delay.
I think this is solved in latest version in master.


How to resize area cropped to square in rectangle

Hi,
thanks for your code, I've a question for you, this is my initialize string:
cropper_bg = new Cropper({width:350,height:90,onInit: function (crop) {crop.setWidth(600);crop.setHeight(200),crop.setZoom(0.1);},onChange: function(crop) {}});cropper_bg.reset();
the area was just correct but the layer trasparen of crop was the same, always squre, can you help me?
Thanks!

Yes, I have the same problem. How do you change the actual crop size?

i've used alternative script
js-cropper-master.zip
$html='';
Il giorno sab 11 lug 2020 alle ore 06:11 Vivek Pai<EMAIL_ADDRESS>ha scritto:

Yes, I have the same problem. How do you change the actual crop size?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/denis-kalinichenko/js-cropper/issues/1#issuecomment-656983793,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AKU2T5ONNLBP65ZH426JOCDR27Q7FANCNFSM4NZLNO4Q
.

change aspect ratio in aspectRatio:12/3 or what you want


Support comment

Hi.
I'm very happy if template6 supports comments, so I implemented it.
This implementation should work as TT's documented behavior ( http://template-toolkit.org/docs/manual/Syntax.html#section_Comments ).

Thanks a lot! That's great!


Inconsistency in clustermesh setup between Helm and Cilium CLI installations

Bug report
Cilium clustermesh status command not working when clustermesh is installed using Helm. I found 2 issues that are causing this issue.
1. Client secret name
Cilium CLI and Helm are naming clustermesh secrets differently. This causes Cilium CLI clustermesh status command to fail if Cilium clustermesh is installed using Helm. The difference is in trailing 's' in secret names that Cilium CLI appends to clustermesh secrets.
Secrets that have different names in Helm templates and Cilium CLI are:

clustermesh-apiserver-server-cert
clustermesh-apiserver-admin-cert
clustermesh-apiserver-client-cert
clustermesh-apiserver-external-workload-cert

If Cilium clustermesh is enabled using clustermesh.config Helm values, if I try to check clustermesh status using Cilium CLI command, I'm getting the following error:
Error: Unable to determine status:  unable to get secret "clustermesh-apiserver-client-certs" to access clustermesh service: secrets "clustermesh-apiserver-client-certs" not found
If I recreate the client cert secret created by Helm to clustermesh-apiserver-client-certs which Cilium CLI expects, the clustermesh status command terminates with another error.  This error is described below.
2. External workload secret
Cilium CLI clustermesh enable command creates a secret for the external workload (installCertificates method in clustermesh/certs.go). Helm doesn't generate this secret which is causing  this error:
Error: Unable to determine status:  unable to get secret "clustermesh-apiserver-client-certs" to access clustermesh service: secrets "clustermesh-apiserver-external-workload-certs" not found
This secret is not used in clustermesh status and I think that it shouldn't be checked for this command.

General Information

Cilium CLI version
cilium-cli: v0.12.1 compiled with go1.18.5 on darwin/arm64 cilium image (default): v1.12.0 cilium image (stable): v1.12.1 cilium image (running): v1.12.0

Orchestration system version in use
Client Version: version.Info{Major:"1", Minor:"17", GitVersion:"v1.17.3", GitCommit:"06ad960bfd03b39c8310aaf92d1e7c12ce618213", GitTreeState:"clean", BuildDate:"2020-02-13T18:08:14Z", GoVersion:"go1.13.8", Compiler:"gc", Platform:"darwin/amd64"} Server Version: version.Info{Major:"1", Minor:"24", GitVersion:"v1.24.4", GitCommit:"95ee5ab382d64cfe6c28967f36b53970b8374491", GitTreeState:"clean", BuildDate:"2022-08-17T18:47:37Z", GoVersion:"go1.18.5", Compiler:"gc", Platform:"linux/amd64"}

Helm Chart version
1.12.0

How to reproduce the issue

Configure clustermesh values in Helm values file:

clustermesh.useAPIServer: true
clustermesh.config.enabled: true
clustermesh.config.clusters: clusters configuration

Install Cilium
helm install cilium cilium/cilium --version 1.12.0 --namespace kube-system --values values.yml
Wait for clustermesh to start
Run cilium clustermesh status command

I believe there is still a issue separate from the naming here, the helm chart doesn't create the clustermesh-apiserver-client-cert unless externalWorkloads is enabled, but the clustermesh setup assumes that the secret will exist even though its not used unless there are external workloads.


How to use --disk-cache-dir

I want my disk cache dir. But don't work:
const browser = await puppeteer.launch({
    args: [
        '--no-sandbox', '--disable-setuid-sandbox',
        '--disk-cache-dir=/Temp/browser-cache-disk'
    ],
});

@NathanLi @kblok I use the same settings but when I try the follow to check if the responses are loaded from cache, it's always returning false. Seems like something is broken?
      page.on("response", (response) => {
        const prefix = response._fromDiskCache ? "[disk] " : "[network] ";
        console.log(`${prefix}${response.url()}`);
      });

It seems to be ignoring cache if interception is defined (at least on requests as this link suggest: )
https://github.com/puppeteer/puppeteer/issues/2497


Introduce Code Coverage tool

After #1, we have a lot of robust and quick unittests. In order to focus on new areas of application, we should introduce CodeCoverage tool ie. coverage.py together with coverage reporting tool (Coverall, CodeCov), which would be a pipeline step. If possible, combining report from coverage from unit tests and acceptance tests would be desired.

Merged with #9


Fix #1717: Handle JS properties named apply

A property in a facade type named apply needs to be explicitly made a
property (as opposed to a function application) by adding @JSName.
The changes in #1647 (@JSExport on method named apply) will align the
export behavior with this change.

Review by @sjrd

Refer to this link for build results (access rights to CI server needed):
https://scala-webapps.epfl.ch/jenkins/job/scalajs-pr/1806/
https://scala-webapps.epfl.ch/jenkins/job/scalajs-matrix-build/2344/
Test PASSed.

There should be a positive test for the case where the annotation @JSName is present.
That's all.

Refer to this link for build results (access rights to CI server needed):
https://scala-webapps.epfl.ch/jenkins/job/scalajs-pr/1813/
https://scala-webapps.epfl.ch/jenkins/job/scalajs-matrix-build/2352/
Test FAILed.

Updated

Refer to this link for build results (access rights to CI server needed):
https://scala-webapps.epfl.ch/jenkins/job/scalajs-pr/1815/
https://scala-webapps.epfl.ch/jenkins/job/scalajs-matrix-build/2354/
Test FAILed.

Updated. Sorry for the compile error. Was a rebase mistake.

LGTM

Refer to this link for build results (access rights to CI server needed):
https://scala-webapps.epfl.ch/jenkins/job/scalajs-pr/1816/
https://scala-webapps.epfl.ch/jenkins/job/scalajs-matrix-build/2356/
Test PASSed.


Remove devcontainer Git Feature

Out Alpine image has never really been supported by devcontainer/features/git.
In release 1.2.0, a distro check was added, and building the image now fails.
InvenTree installs git, so removing the git feature from devcontainer.json

Thanks @LavissaWoW ; 👍


How to convert the images in Disney mode without CUDA (using CPU)

Hi, I have updated the eval.py, and you can change line 48 to device = "cpu" for converting images using CPU.


Segfault on launch in SliTaz

Hi There,
I'm building dvtm from source. I've tried both the 0.15 tarball release and the master branch from the GitHub repo.  I'm running from within VirtualBox.
My build appears to work correctly: https://gist.github.com/GrooveStomp/19900f5f6ad4b9398fefa929e1337078
When running I get a segfault: https://imgur.com/a/hKeDg
I've recorded a debugging session that hopefully illuminates what's going on: https://gist.github.com/GrooveStomp/1ad5b0029cbbcfb18f4c5043fe2f58d4
I've tried reading through the code and making sense of it, but there are a few too many concepts at play that I'm not familiar with, so I figured it was time to reach out to the author. :-)

Sounds like your kernel is too old to run dvtm. SliTaz runs ancient kernels from the 2.4 and 2.6 release series, and those kernels probably have issues with current versions of ncurses.


Patch snowflake config

I don't believe this config used anywhere except my code - therefore this is patch.

Should we also tolerate null for those two fields, in case somebody wants to send in a JSON config with those values nulled (easier when rendering from a template)?

@alexanderdean agree.

Done. @knservis could you please cherry-pick it into your branch and close this PR?

Assigning to Kostas to handle.

Superseded by https://github.com/snowplow/iglu-central/pull/672

Removing from schedule


Update README.md

Make it more clear that Cordova is not enabled by default and that the comment tags need to be removed before the template makes use of Cordova

Thanks


Could not do docker-build

I had run: sudo docker-compose build which gives error:

Hi,
On which OS are you ?
I've tried on Ubuntu 18.04 and got no problems to build the image.

Hi,
On which OS are you ?
I've tried on Ubuntu 18.04 and got no problems to build the image.

Hello @KrustyHack,
I am using 16.04, and still have problems with the building.

Hello @KrustyHack,
I am using 16.04, and still have problems with the building.

Ay @tarunkant,
Can you try on a more up to date Ubuntu ? At least on 18.04 ? Just to be sure that it's not the Ubuntu version the problem.

Ay @tarunkant,
Can you try on a more up to date Ubuntu ? At least on 18.04 ? Just to be sure that it's not the Ubuntu version the problem.

Hey @tarunkant. Did you solve this issue?


Please release new version

The version on NPM (1.4.1) is out of sync with the code in this repo. Consequently, node-harmonize doesn't work properly when installed. Please update NPM.

Thanks, pushed it as 1.4.2

👍

Thanks very much!


Update PDFOptions.ts

Add case options consistent with documentation
Closes #8209 but without the test change suggested there.
What kind of change does this PR introduce?
Type change bugfix that brings code in line with documentation.
Did you add tests for your changes?
No, see comment on #8209
If relevant, did you update the documentation?
This is updating the code to match what the documentation already says.
Summary
See #8209 for the issue.
Does this PR introduce a breaking change?
No, at least not intentionally.

Someone else can take this and re-do the work; barriers to contribution in this repo exceed the value of the contribution.

Closed in https://github.com/puppeteer/puppeteer/pull/8211

Thanks! One small tweak you might consider is to have the Capitalize version first so that type hints shown on hover in certain IDEs match the documentation shown alongside it.


Respect SS_BASE_URL scheme for builds and tasks that are ran through CLI.

Affected Version
silverstripe/framework 4.10.11 The SilverStripe framework (probably >= 4.*)
Description
The dev/build process executed through CLI does not respect 'https' scheme from environment in a correct way. Due to how HTTPRequestBuilder processes URL's through the HTTPRequest constructor, requests will be using the 'http' scheme by default unless $variables['_SERVER']['HTTPS'] or variables['_SERVER']['SSL'] is set.
The desired execution of dev/build through CLI would be the same way dev/build is executed through the browser for an application with SS_BASE_URL="https://www.example.com" being set in the environment configuration.
Saying that, we currently have an issue of unstyled (static) error pages due to stylesheets and scripts being supplied over http. This is a known issue that describes the problem: https://github.com/silverstripe/silverstripe-errorpage/issues/20
I think the problem is caused because of HTTPRequestBuilder only validating HTTPS scheme based on SERVER variables.
// Set the scheme to HTTPS if needed
if ((!empty($variables['_SERVER']['HTTPS']) && $variables['_SERVER']['HTTPS'] != 'off')
    || isset($variables['_SERVER']['SSL'])) {
    $request->setScheme('https');
}

There are also several other issues semi-related to this change (might have missed some):
https://github.com/silverstripe/silverstripe-framework/issues/7492
https://github.com/silverstripe/silverstripe-framework/pull/8028
By setting the SERVER HTTPS scheme variables based on SS_BASE_URL within CLIRequestBuilder I expect to resolve these issues with minimal impact.
Steps to Reproduce

Setup a new SilverStripe framework project.
Add the SS_BASE_URL="https://www.example.com" environment variable for your project where HTTPS is enabled.
Execute the /dev/build?flush=1 command through the web browser navigated using the https scheme, a.e. https://www.example.com/dev/build?flush=1.
Review the contents of error-404.html or error-500.html and verify the base tag containing a https URL (correct).
Execute the /dev/build?flush=1 command through the CLI interface having the same SS_BASE_URL value.
Review the contents of error-404.html or error-500.html and verify the base tag containing a http URL (wrong).

This is a simple example of where the scheme is causing an issue and the impact might be much bigger when running a task from CLI.
Please ask for other required details that are needed to review my change, which I will submit through a pull-request in a minute.
PRs

https://github.com/silverstripe/silverstripe-framework/pull/10616

Pull request: https://github.com/silverstripe/silverstripe-framework/pull/10616

Should we be also setting the host then, not just the protocol, if SS_BASE_URL is defined?

Why is the protocol an issue and not the host? Or does the host get picked up in some other way and the protocol doesn't, meaning the issue could be somewhere else?

Yes, in this case the host is picked up in some other way. The issue is caused by HTTPRequest being initialized with default scheme value set to http. The passed URL is relative to base, thus scheme is stripped by Director::makeRelative in an earlier stage.
SilverStripe has a default fallback of setting HTTP_HOST to localhost when unknown. I would be able to add HTTP_HOST to the condition and assign the base URL to it if that's what you mean, but is there a good way to verify if this is the desired thing to do?
With my change I am trying to keep the impact as low as possible while HTTP_HOST is used in plugins for example (which I am probably not able to test).

This is now fixed in 4.12.1
Thanks @s-kerdel for reporting and fixing this.


Issue when running with docker

Hey y'all thanks so much for making this. It looks really great and will be helpful for my studies.
When I run docker-compose up it exits with the following error:
 => ERROR [6/7] RUN pip install --no-cache-dir -r /requirements.txt                                                  20.7s
------
 > [6/7] RUN pip install --no-cache-dir -r /requirements.txt:
#0 0.573 Collecting openai-whisper==20230124
#0 0.694   Downloading openai-whisper-20230124.tar.gz (1.2 MB)
#0 1.002      ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 1.2/1.2 MB 3.8 MB/s eta 0:00:00
#0 1.059   Preparing metadata (setup.py): started
#0 1.410   Preparing metadata (setup.py): finished with status 'done'
#0 1.449 Collecting pytube==12.1.2
#0 1.473   Downloading pytube-12.1.2-py3-none-any.whl (57 kB)
#0 1.489      ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 57.0/57.0 kB 3.6 MB/s eta 0:00:00
#0 1.726 Collecting SQLAlchemy==2.0.3
#0 1.772   Downloading SQLAlchemy-2.0.3-cp311-cp311-manylinux_2_17_aarch64.manylinux2014_aarch64.whl (2.8 MB)
#0 4.235      ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 2.8/2.8 MB 1.2 MB/s eta 0:00:00
#0 4.313 Collecting streamlit==1.18.1
#0 4.337   Downloading streamlit-1.18.1-py2.py3-none-any.whl (9.6 MB)
#0 8.298      ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 9.6/9.6 MB 2.4 MB/s eta 0:00:00
#0 8.548 Collecting numpy
#0 8.575   Downloading numpy-1.24.2-cp311-cp311-manylinux_2_17_aarch64.manylinux2014_aarch64.whl (14.0 MB)
#0 20.32      ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 14.0/14.0 MB 1.1 MB/s eta 0:00:00
#0 20.41 ERROR: Ignored the following versions that require a different python version: 0.55.2 Requires-Python <3.5; 1.21.2 Requires-Python >=3.7,<3.11; 1.21.3 Requires-Python >=3.7,<3.11; 1.21.4 Requires-Python >=3.7,<3.11; 1.21.5 Requires-Python >=3.7,<3.11; 1.21.6 Requires-Python >=3.7,<3.11
#0 20.41 ERROR: Could not find a version that satisfies the requirement torch (from openai-whisper) (from versions: none)
#0 20.41 ERROR: No matching distribution found for torch
------
failed to solve: executor failed running [/bin/sh -c pip install --no-cache-dir -r /requirements.txt]: exit code: 1

This could possibly be related to me running with an M1 mac?
Please let me know if there is anything I can do to help debug here.

Ah interesting!
From the error this looks like Python 3.11 is not supported. Could you try downgrading the Python version from 3.11 to 3.10 and see if that helps? If yes, I'll update the docker file.
(I've tested it on Ubuntu 22.04 and it worked fine so this is a tad confusing)

Downgrading to 3.10 worked like a charm!
Thanks :)

Awesome! Thanks for the flag! :)
I'll update the Dockerfile

Closing this since it couldn't be reproduced. Feel free to re-open if things change.


[FEATURE] Support Delivery Profile / CSCLSROZ-317

Support
- https://developer.salesforce.com/docs/atlas.en-us.mc-apis.meta/mc-apis/deliveryprofile.htm

relates to #61

relates to #54 and #61
blocks #62

the SOAP object "DeliveryProfile is non-retrievable via SFMC's SOAP API.
however, there is a REST-endpoint in the legacy API: beta/messaging/deliverypolicy/
will test that

worked. but only VERY basic.


Cleanup the containous/whoami vs traefik/whoami

There's a little mess with the image on Docker hub:

https://hub.docker.com/r/containous/whoami mentions https://www.github.com/containous/whoami as source repository, which redirects to https://github.com/traefik/whoami
containous/whoami contains old image, without features mentioned on https://github.com/traefik/whoami

Hello,
There is no mess here, we moved the project from containous GitHub org to traefik GitHub org.
The image containous/whoami is not maintained. This image is here for compatibility reasons (avoid breaking people that use this image).

I see. Maybe it's a good idea to mention this on https://hub.docker.com/r/containous/whoami page?

This page cannot be edited: Docker uses readme information, but this readme is now gone since the migration.


mission statement

Codecov Report

Merging #1668 (319fa09) into main (390c7cf) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1668   +/-   ##
=======================================
  Coverage   83.10%   83.10%
=======================================
  Files          69       69
  Lines        5836     5836
=======================================
  Hits         4850     4850
  Misses        986      986

Impacted Files
Coverage Δ

flax/linen/module.py
93.24% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 390c7cf...319fa09. Read the comment docs.

Thanks @jheek! Added a few comments.
Also, should we consider adding this to our RTD left pane? Or maybe later?


Make validateObjectKeys() Public for Tekton Chains to Use

Feature request
validateObjectKeys is validating properties against a ArrayOrSting, which is needed in Tekton Chains. To avoid code duplication, this worths becoming a public function
Use case
See above

/assign @chuangw6 Hi Chuang, I'm wondering if you have time to make the function public? Thanks

Hi Chuang, I'm wondering if you have time to make the function public? Thanks

sg! done #5073 !


Proposal to add Metropolis-adjusted Langevin algorithm

Description
Add MALA to the project.

For details see #97


Does this work in browser ?

I'm very interested in bringing this feature to webbrowsers, did you test it in browser and does it work ?

Closing this issue for now, feel free to reopen if needed!


Basic tests

Summary
This brings in some basic tests I had in the 2.0 branch. This allows me to delete that branch so that it is easier to track which version is active.

Tests are going to fail on CI because we don't have a published version of the new generator. It is linked locally. #worksonmymachine. LGTM!!

Sounds good, let's get this branch going.

Ideally tests should be fixed soon-ish by publishing an initial 0.0.x though.


Question about paired-end options for read2 with only CB + UMI

Hi!
I have paired-end reads with gene insert on read1 and only cell barcode + UMI on read2 (no transcriptomic information). Should I use the options
run-trust4
-t $SLURM_JOB_CPUS_PER_NODE
-f $ref_igmt_c_fa
--ref $ref_igmt_c_fa
-u $read1
--barcodeWhitelist $bc_white
--barcode $read2
--UMI $read2
--read-format bc:0:7,um:8:17
--trimLevel 0
--od $output_dir
or still use -1 -2?
Thank you for your help?

Your command looks fine. "-u" is appropriate for single-end data in your case. Just want to make sure, is your barcode only 8bp, and UMI 10bp?

Yes, thank you!


v1.10: Update Go to 1.16.15

/test-backport-1.10

/test-backport-1.10

/test-1.16-netnext

/test-1.19-5.4

runtime test failure is #18919: https://jenkins.cilium.io/job/Cilium-PR-Runtime-net-next/1479/
All other tests passed and two reviewers approved. Marking as ready to merge.


cellrank.estimators.GPCCA.compute_lineage_drivers if subset on clusters, confidence intervals are NaN- is this expected behavior?

Good morning! Apologies for so many questions recently.  I just have a quick question, when running `cellrank.estimators.GPCCA.compute_lineage_drivers`, I get confidence intervals returned if I only specify for example `lineages = ['3', '4', '5']`, but if I pass `lineages = ['3', '4', '5'], cluster_key = 'leiden', clusters = ['0', '1', '2', '3', '4', '5']`, I receive NaN for confidence intervals. I don't need the confidence intervals for what I am doing, but just wanted to post to see if this is expected behavior or a bug.  Happy to post more code if that will be helpful.  Thank you for your work!
...

Hi @JenniferWUSTL, I think that's a bug! I don't see why we wouldn't be able to compute the confidence intervals on a subset of the data. Do you know more here @michalk8 ?

I receive NaN for confidence intervals

Is it only for the CI, or the whole row (including the correlation value, etc.). If the whole row, it can be expected, since NaN values should only happen when the gene expression in the selected clusters is constant (e.g., 0); you can use the below snippet to check if the values are all 0s (or any other constant):
adata = g.adata  # g is the estimator, adata is the one from cr.datasets.pancreas()
clusters = ["Ngn3 low EP"]
subset = adata[adata.obs['clusters'].isin(clusters), 'Rragb']
subset.X  # all 0s, in the drivers, it has NaN correlation

Hi @michalk8 ! I receive it only for confidence intervals, not the correlations or p-values, etc.

Hi @michalk8 ! I receive it only for confidence intervals, not the correlations or p-values, etc.

Then this seems like a bug indeed. If you can share with us some way to replicate this, it would be great.

Hi @michalk8 ! I tried to reproduce this using cr.datasets.reprogramming_schiebinger() ;however, I cannot reproduce this with that dataset. I can reproduce it on my dataset with:
 drivers = b.compute_lineage_drivers(lineages = ['4_2', '5', '6', '3_2', '0'])
drivers
         4_2_corr  4_2_pval  4_2_qval  4_2_ci_low  4_2_ci_high
PLAU     0.536961       0.0       0.0    0.524940     0.548768

and then:
drivers = b.compute_lineage_drivers(lineages = ['4_2', '5', '6', '3_2', '0'], cluster_key = 'leiden', clusters = ['0', '1', '2', '3', '4', '5', '6', '7', '10', '11', '12', '8'])`
drivers
         4_2_corr  4_2_pval  4_2_qval  4_2_ci_low  4_2_ci_high
PLAU     0.544179       0.0       0.0         NaN          NaN

I checked the correlations on my data and they all fall within +/- 1, and looking through the code I found here (https://github.com/theislab/cellrank/blob/e54987b800a2a85f94c735ef0e9a33a4736f2e00/cellrank/_utils/_utils.py#L392) I can't seem to find why it shouldn't return confidence intervals but still compute the other values- in this case, I have no confidence intervals for any of my genes. I'm not using these downstream in my analysis, but I do wonder if I should be cautious about interpreting the results since these are not returned. What do you suggest for troubleshooting?
If it's helpful my data was processed as following the scanpy tutorial with normalized counts in adata.X and then I proceeded with the following code, prior to running compute_lineage_drivers as above:
adata.layers["spliced"] = adata.X
adata.layers["unspliced"] = adata.X
scv.pp.moments(adata, n_pcs=30, n_neighbors=30)
wk = WOTKernel(adata, time_key = 'time')
wk.compute_initial_growth_rates(organism = 'human', key_added = "growth_rate_init")
wk.compute_transition_matrix(growth_iters=3, growth_rate_key="growth_rate_init", self_transitions="connectivities")
cn = ConnectivityKernel(adata).compute_transition_matrix()
ck1 = 0.9*wk + 0.1*cn
b = cr.estimators.GPCCA(ck1)
b
b.compute_schur(n_components = 20)

b.compute_macrostates(n_states = 13, cluster_key = 'leiden')
b.set_terminal_states(["9", "8", "3_2", "0"])
b.compute_absorption_probabilities()

Thank you for your time, and sorry I don't have a reproducible dataset to share at this time!

To follow-up, if I use method = 'perm_test' instead of the default 'fisher', confidence intervals are returned with my dataset.

I checked the correlations on my data and they all fall within +/- 1, and looking through the code I found here (

That's strange, I ran the code manually for the correlation value of PLAU, it shouldn't be NaN. It's later assigned to the final DataFrame here, could you please print out whether before/after assignment the CI values are NaN? I suspect
Also, if you're not using the latest version (from master), can you please update it + post your pandas/numpy versions?
The other thing that can maybe cause this is the subset by clustering which happens here; the simplest way to check is to pass all the clusters and see whether all the values are the same as not passing the clusters (they should).

Thanks @michalk8 , how do you suggest I do this? It's later assigned to the final DataFrame here, could you please print out whether before/after assignment the CI values are NaN?
I think this is the most up to date version, but please let me know if I'm wrong and I'm happy to update:
cr.logging.print_versions()
cellrank==1.5.1+gd7f499c0 scanpy==1.9.2 anndata==0.8.0 numpy==1.23.5 numba==0.56.4 scipy==1.9.3 pandas==1.5.3 pygpcca==1.0.4 scikit-learn==1.2.0rc1 statsmodels==0.13.5 python-igraph==0.10.4 scvelo==0.2.5 pygam==0.8.0 matplotlib==3.6.2 seaborn==0.12.2

By visual inspection, the correlations are the same with
mine.compute_lineage_drivers(lineages = ['4_2', '5', '6', '3_2', '0'], cluster_key = 'leiden', clusters = ['0', '1', '2', '3', '4', '5', '6', '7', '8', '9', '10', '11', '12'])

PLAU   -0.482829     0.0     0.0       NaN        NaN

and
mine.compute_lineage_drivers(lineages = ['4_2', '5', '6', '3_2', '0'])

PLAU   -0.482829     0.0     0.0 -0.495563  -0.469887

where I have 13 clusters (0 through 12, so should not be subsetting.
I can check if all values are the same though, just need to figure out how :)
Also, I misspoke about method = 'perm_test', there are still some CIs that are NaN with q-values/p-values not NaN, but it's no longer every entry like is for "fisher", sorry for any confusion!

Hi @michalk8, is there anything to do here, or can we close this?

I haven't been able to find a reason why this happens. The one thing I could thought of was that n - 3 was negative, but in this case the p-value would also be NaN, which is not the case.
The other thing is the subsetting (using a view here; maybe copying it would solve, but doesn't make much sense that this would affect the results).
Due to the lack of reproducibility/inactivity, am closing this as unresolved.


Request to rename "Show Awards List" to "Award History"

I think award history makes more sense given the output a user will see.

+1


Enable INFO as the general log level

Silence some other modules as part of this.
Without this, we are not going to see warnings such as https://github.com/comit-network/xtra/commit/15fdd524f2ed3ac94acfc92e21d5f285a485c23d.

bors r+


[Feature] Layers

Right now it's capped at 1 (like the original). Photoshop goes up to 100, and even that is sometimes too small. More layers would make this product superior.

For exporting, since there are concerns on file format compatibility, one could have an option to export the combined image + the layers of said images. Ie:
image_combined.png
image_layer1.png
image_layer2.png
That way, if one wants to put the layers into a different program, it's just a matter of ordering the images properly. A bit unsophisticated, but I don't think it really needs anything beyond this to be useful. (Maybe putting the layers into a folder for convenience)

@123ldk To download multiple files, an archive format is needed, and ZIP is standard. Indeed, a ZIP with PNG files is a good idea and is the basis of the OpenRaster specification which is a ZIP with PNG files and an XML file for metadata.
I'd recommend Photopea to anyone who wants layers for now; it supports PSD and SVG, along with many sophisticated features.
For layer support in JS Paint, my main concern is undo history. It's a similar story for animations (GIF, APNG), multi-size icons (ICO, ICNS), layered images (ORA, PSD), and multi-page documents (PDF, DjVu), as well as comic strips (if one prefers a panel-by-panel workflow for creating comics).
We need:

A component to switch between sub-images (the easy part)
File format support (also pretty easy)
A new document model, handling undo/redo for multiple sub-images (the hard part)

The good news is that if we can do one of these features, we can do all of them pretty easily, which would be amazing.
The bad news is that it affects a large portion of the code, as all the tools and image operations integrate with undo history and the canvas. (There's 147 mentions of main_canvas in the codebase, for instance, and 73 for main_ctx.)
I'd also like to improve the undo/redo system for multiplayer support and for efficiency, with region updates instead of whole canvas snapshots, which might be good to implement at the same time, although it's somewhat orthogonal. Either feature would likely make the other feature easier, as either would require moving from a whole state snapshot to a targeted update.
Currently an undo state ("history node") looks like:
{
	parent = null, // the state before this state (its basis), or null if this is the first state
	futures = [], // the states branching off from this state (its children)
	timestamp = Date.now(), // when this state was created
	soft = false, // indicates that undo should skip this state; it can still be accessed with the History window
	image_data = null, // the image data for the canvas (TODO: region updates)
	selection_image_data = null, // the image data for the selection, if any
	selection_x, // the x position of the selection, if any
	selection_y, // the y position of the selection, if any
	textbox_text, // the text in the textbox, if any
	textbox_x, // the x position of the textbox, if any
	textbox_y, // the y position of the textbox, if any
	textbox_width, // the width of the textbox, if any
	textbox_height, // the height of the textbox, if any
	text_tool_font = null, // the font of the Text tool (important to restore a textbox-containing state, but persists without a textbox)
	tool_transparent_mode, // whether transparent mode is on for Select/Free-Form Select/Text tools; otherwise box is opaque
	foreground_color, // selected foreground color (left click)
	background_color, // selected background color (right click)
	ternary_color, // selected ternary color (ctrl+click)
	name, // the name of the operation, for the history window, e.g. localize("Resize Canvas")
	icon = null, // an Image representation of the operation type shown in the history window, e.g. get_help_folder_icon("p_blank.png")
}

and history nodes are only created via the undoable function, except for the root node (when creating or opening a document), although history nodes can also be modified with make_or_update_undoable, used for smearing selections.
Designing the app to treat sub-images as textures would allow even more possibilities, like painting onto 3D models, as well as symmetry, tessellation, and even an infinite canvas, as each of those features could be implemented as painting onto different sorts of geometry. For instance an infinite canvas could generate a field of squares/triangles with unique texture IDs/UV coordinates, and tessellations and symmetries would use some repeated UV coordinates such that the brush affects multiple areas on the screen via a single area in the texture.
(Some inspiration: this infinite zoom which generates 2D geometry for THREE.js to render)
I've outlined some of this in the Extended editing section of the todo.
My next focus is to fix my automated tests, and improve the maintainability of the codebase with things like autoformatting and typechecking, maybe add some new tests. Then I can feel better about changing core aspects of the app.


Add {:error, :econnrefused} return spec to pull

Dialyzer is complaining when I use this function. Tesla returns a {:error, :econnrefused} tuple when the connection fails. This is not accounted for in the existing type spec.

@googlebot I signed it!

This is a generated file. We need to modify the template instead, otherwise this will just get overwritten when the generator runs the next day.

I've modified the templates upstream, so this change will be made to all libraries when they get regenerated tonight.

Awesome! good to hear.


more fixes

initial defaults
initial updates
more
more updates
fix a lot of lint/style issues
more
a few more changes

I only have comment on the git history. Now that everything was copied and git pushed, it lost all the commit history, reasoning for things and also authorship credits from those who contributed. Was there reason for loosing the history?


Should work with any project

A great user input would be by listing projects from https://intranet.hbtn.io/dashboards/my_current_projects.json, and catching std input from the user.
The user should be able to pass a flag too, to bypass this.

37cf23d


Magento 2.3 Compatibility

Bumped version requirements
Use 2.3 in CI
Make product fixtures work

Awesome, thank you :+1:


CephFS Helm Chart Fails to Template config.json in ConfigMap

Describe the bug
Deploying the CephFS CSI Plugin via Helm chart. csiConfig values in values.yaml are not rendered in csiplugin-configmap.
Environment details

Image/version of Ceph CSI driver : 3.12.2
Kubernetes cluster version : 1.31.1
Ceph cluster version : 18.2.4

Steps to reproduce
Steps to reproduce the behavior:
values.yaml
---
csiConfig:
  - clusterID: "efadcb32-xxxx-xxxx-xxxx-5c9b1131c87a"
    monitors:
      - "10.xx.xx.91"
      - "10.xx.xx.92"
      - "10.xx.xx.93"
      - "10.xx.xx.94"
    cephFS:
      netNamespaceFilePath: "{{ .kubeletDir }}/plugins/{{ .driverName }}/net"
storageClass:
  create: true
  clusterID: "efadcb32-xxxx-xxxx-xxxx-5c9b1131c87a"
  fsName: cephfs

Render helm chart:
helm template ceph-csi-cephfs ./ceph-csi-cephfs --dependency-update -n ceph-csi-cephfs --include-crds
Actual results
ceph-csi/charts/ceph-csi-cephfs/templates/csiplugin-configmap.yaml
apiVersion: v1
kind: ConfigMap
metadata:
  name: "ceph-csi-config"
  namespace: ceph-csi-cephfs
  labels:
    app: ceph-csi-cephfs
    chart: ceph-csi-cephfs-3.12.2
    component: provisioner
    release: ceph-csi-cephfs
    heritage: Helm
data:
  config.json: |-
    []

Expected behavior
ceph-csi/charts/ceph-csi-cephfs/templates/csiplugin-configmap.yaml
apiVersion: v1
kind: ConfigMap
metadata:
  name: "ceph-csi-config"
  namespace: ceph-csi-cephfs
  labels:
    app: ceph-csi-cephfs
    chart: ceph-csi-cephfs-3.12.2
    component: provisioner
    release: ceph-csi-cephfs
    heritage: Helm
data:
  config.json: |-
    [
      {
        "clusterID": "efadcb32-xxxx-xxxx-xxxx-5c9b1131c87a",
        "monitors": [
          "10.xx.xx.91",
          "10.xx.xx.92",
          "10.xx.xx.93",
          "10.xx.xx.94"
        ],
        "cephFS": {
          "netNamespaceFilePath": "/var/lib/kubelet/plugins/cephfs.csi.ceph.com/net"
        }
      }
    ]

Logs
I'm a little new to helm templating so I'm not sure what logs would be helpful for this.
Additional context
I've tried various values for csiConfig and haven't been able to get anything to render in config.json, but I can't see what I'm doing wrong. I looked through the helm template files and can't see anything that would cause this (.Values.externallyManagedConfigmap is set to false eg).

@cdav3435  I have the same issue, did you fixed it ?
Otherwise could we reopen the issue ?

I ended up using the raw k8s objects.
apiVersion: kustomize.config.k8s.io/v1beta1
kind: Kustomization

namespace: ceph-csi-rbd

resources:
- ceph-csi-config-cm.yaml
- ceph-config-cm.yaml
- ceph-csi-encryption-kms-config.yaml
- https://raw.githubusercontent.com/ceph/ceph-csi/v3.13.0/deploy/cephfs/kubernetes/csidriver.yaml
- https://raw.githubusercontent.com/ceph/ceph-csi/v3.13.0/deploy/rbd/kubernetes/csi-provisioner-rbac.yaml
- https://raw.githubusercontent.com/ceph/ceph-csi/v3.13.0/deploy/rbd/kubernetes/csi-nodeplugin-rbac.yaml
- https://raw.githubusercontent.com/ceph/ceph-csi/v3.13.0/deploy/rbd/kubernetes/csi-rbdplugin-provisioner.yaml
- https://raw.githubusercontent.com/ceph/ceph-csi/v3.13.0/deploy/rbd/kubernetes/csi-rbdplugin.yaml

# patches:
# - path:


Demo recording

Demo recording and other minor corrections

LGTM. @jcabrerizo We should also update the overall readMe.md doc of the project so it has complete documentation which Partners can reference!

Working on that at the moment


Merge Failed retry logic

In case of merge failure at the end of the process, the retry should only try to merge the sources again, and not trigger another process. if the verification of the push was already successful, no need to run the same process again

@DVir669 - MERGE_FAILED should occur in the beginning of the process before triggering any build.
If 'merge failed' occur after PASS verification - it's indicated on a problem in the Jenkins job.
Even if a permitted user put the local repository out of sync with the protected branch, there is a mechanism that align the branches before actually doing the push.
The only reason I can think of (for now) is that the temp branch is not being verified against the protected branch.

@DVir669 - are you agree on closing this one? do you still think it is an issue?

Close it for now - I only had one instance in which it was relevant (no Jenkins job failure - proper GIT issue) - if I'll be able to reproduce I'll make sure to open it again :)


Allow Fragment-Only URLs for href-style Rule

Description
Updates the href-style rule to allow fragment-only URLs (href="#location"). Issue discovered when adding the rule to the Popcode web code editor.

Coverage remained the same at 100.0% when pulling a82723eb5259d6558b973a968aa86813e40ad0ec on alecmerdler:href-style-allow-fragment into fe68744c1ea87ebd92e6545fb342f7006237d20e on htmllint:master.

Coverage remained the same at 100.0% when pulling a82723eb5259d6558b973a968aa86813e40ad0ec on alecmerdler:href-style-allow-fragment into fe68744c1ea87ebd92e6545fb342f7006237d20e on htmllint:master.

@mlochbaum Any chance for a review?

@mlochbaum Thank you so much for the merge! When can we expect a release with the patch?

About five minutes ago.


Add Traversal methods that avoid cycles

The two traversal algorithm implemented in MoreLinq do not respect node quality, so the result may include a node multiple times, and the algorithm is sensitive to cycles.
I'd happily put together a PR to fix this (for example by storing visited nodes in a HashSet<T>), but I was wondering if this behavior was by design, so please give your thoughts on this.

Are you referring to TraverseBreadthFirst and TraverseDepthFirst ? If so, the behavior is by design (and documented). Trees can be large, and if they really are trees (ie, no loops), then doing the bookkeeping the seen nodes is an unnecessary expense.
OTOH, sometimes the source is not really a tree, so this bookkeeping is necessary. How do you propose it can be done, without burdening the users of tree-like structures?

You're right, but I think the overhead added by the tracking is not significant. If we use a HashSet, then adding an item and checking existence of an item both have constant complexity, which means that the overall complexity will remain linear.
But if you worry about it, writing a unit test to measure performance difference on a huge tree is not very difficult.

Indeed I worry. The bad performance from bookkeeping comes from at least two dimensions:

Memory usage. As per this StackOverflow post, a HashSet uses 12 bytes per slot + the actual data. Not only this increases memory usage and pressure in the application, but it requires frequent (at least at first) allocations. Allocations can be slow. This would be particularly damaging if the node type is a struct.
CPU usage. It is not a given that all node classes will implement GetHashCode and IEquatable correctly. A HashSet of such items is not really fast.

For this reason I would prefer if this bookkeeping would not be done unless the user requested it.

Thank you for the comments, you have definitely a higher level of insight in this topic. So I'd suggest introducing an optional argument which controls this behavior.

I don't think we should be adding this to the Traverse methods. Maybe a separate method should be added that does this. I've retitled the issue accordingly.


False/True added to SpinForts

Would it be possible to add a False/True in the configs for SpinForts? This way, instead of having to delete/re-add the task consistently, we can just change a single value.
Alternatively, why not bring back Poke/Farm/All option back?
Having to make multiple configs just for Farm Pokemon/Farm PokeStops is getting tedious.

You can change the type: "SpinFort" to type: "//SpinFort" to disable it


Lack of validation of RiskManager parameters

Severity: Medium					Difficulty: High
Type: Data Validation
Target: RiskManager.sol

Description
The RiskManager contract allows to change some important parameters without validation.
Deploying the RiskManager contract requires to provide a list of parameters, including the bondAuctionThreshold and auctionLength one:
https://github.com/keep-network/coverage-pools/blob/main/contracts/RiskManagerV1.sol#L182-L196
These parameters can be changed later, for instance:
https://github.com/keep-network/coverage-pools/blob/main/contracts/RiskManagerV1.sol#L305-L317
https://github.com/keep-network/coverage-pools/blob/main/contracts/RiskManagerV1.sol#L205-L226
However, these parameters are never validated and accept any numeric value.
Exploit Scenario
Alice deploys the risk manager contract, but some of the parameters are invalid (e.g. auctionLength is 0). Bob notifies new liquidations, creating an auction. When some user tries to interact with that auction, they are unable to do it because the invalid auctionLength causes a zero division revert when calling onTake.
Recommendation
Short term, properly validate the bondAuctionThreshold and auctionLength values, in particular if they are zero or very large values that can trigger an overflow.
Long term, review all the function inputs to make sure they are properly validated. Use Echidna and Manticore to test them.

This is controversial but... we decided to not implement the validation for any of them as it is hard to say what the correct range is, and to make it clear that it is up to the calling party (governance) to make sure values make sense.
For example, 0 auctionLength does not really make sense, but same for 1,2,...,100,... - it all depends on the TVL, same for the upper bound. For bondAuctionThreshold we could probably limit it to <= 100 but given that we do not validate other parameters, we did not add it here for consistency so that we do not suggest the rest of the parameters will be fine with arbitrary values.
I would lean towards going through all governable parameters and making it clear in the Solidity docs what are the expectations about the values accepted.


Current dbname not reported correctly

Running 1b2a58aff051d424fd216784a0cb9404db94a7fc:
neo4j> :status
Connected to 'neo4j://neo4j@localhost:7687' (insecure) [Neo4j/4.2.1]
neo4j> :dbname system
db set
neo4j> :dbname

Expected
current db is 'system'

Actual
current db is 'e'

Reproducibility: Sometimes. I’ve also seen the db name being reported as \ or the empty string. Sometimes, the correct name is reported. Repeated invocations of :dbname may yield identical or different results. A memory corruption issue…?

Yes - I had this issue too, but I guess I didn't nail it. Will look


Do not remove None values in RepoCardData serialization

More details in https://github.com/huggingface/datasets/issues/7243#issuecomment-2427121987 and especially https://github.com/huggingface/datasets/issues/7243#issuecomment-2429286597.
When serializing repo cards metadata, we are currently removing any none values from any dictionary, set, list or tuple. This is done since the module has been introduced in https://github.com/huggingface/huggingface_hub/pull/940 and never caused problems until https://github.com/huggingface/datasets/issues/7243 was reported. I do find automatically removing None values inside values to be pretty clunky as it is values set by the user and not default ones.
This PR updates this behavior to remove only top-level None values, i.e. values that are None by default and that therefore shouldn't be serialized (as not set by the users themselves). The _remove_none helper is still kept to remove None values from the model-index (where it's rightfully necessary), but that's all.
:warning: this is a breaking change. In practice, I don't expect it to break anything in the wild.

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Thanks for the quick reviews :)

Thanks for fixing this! - any plans for a new release with the fix?

This fix will be shipped in next release but can't commit on when it'll be. In the meantime, I advice you to install huggingface_hub from source: https://huggingface.co/docs/huggingface_hub/installation#install-from-source.


Update README.md: add another demo

Hi,
I have another demo with good UI, can you consider to add it in README?

Web app and signaling server: https://rewebrtc.herokuapp.com/
React native app repository: https://github.com/thoqbk/rewebrtc

thanks, I will add a section


Request for plugin/package manager module

Contributing guidelines

[X] I have read CONTRIBUTING.md
[X] I have read CODE_OF_CONDUCT.md

Module(s)
mini.plug
Description
Most Neovim setups that would include plugins manage them via a plugin/package manager, mainly to ease setup, installation, and synchronization. Popular Lua plugin managers such as lazy.nvim and packer.nvim exist, but they seem to be too complex. Plugin managers like paq-nvim however, are much simpler (quite a bit of features for only around 500 lines of code). I think it would be beneficial if mini.nvim were to implement some form of a simple plugin/package manager that can be used to keep itself updated, along with maybe some other plugins.
In addition, a lazy-loading feature could be skipped, similar to what paq-nvim does, as plugins can be made optional and be :packadd-ed later on through the use of an autocommand or keybind.
Thanks

Moving us ever closer to the future where the complete neovim setup to have everything you want in the whole world ends up being
require("mini.everything")

Moving us ever closer to the future where the complete neovim setup to have everything you want in the whole world ends up being
require("mini.everything")

Yep, something like this is the goal here.

@yamin-shihab, @ElectronSutra, well this took a bit longer than couple of weeks (for various reasons), but we'll there. The 'mini.deps' module is now a part of 'mini.nvim'. Check it out and leave your feedback in #689.

Sweet!