Reporting an error I receive anytime I try to open the query viewer.

Hey there, I installed this and went to give it a try (just opened it on the setup method of this plugin first) but I end up getting the error below whenever I try to open the query popup.
Error detected while processing CursorHold Autocommands for "<buffer=36>":
Error executing lua callback: vim/shared.lua:0: s: expected string, got nil
stack traceback:
        [C]: in function 'error'
        vim/shared.lua: in function 'validate'
        vim/shared.lua: in function 'gsplit'
        vim/shared.lua: in function 'split'
        ...vim/lazy/nvim-treesitter/lua/nvim-treesitter/parsers.lua:1628: in function 'guess_query_lang'
        ...ayground/lua/nvim-treesitter-playground/query_linter.lua:77: in function 'lint'
        ...ayground/lua/nvim-treesitter-playground/query_linter.lua:158: in function <...ayground/lua/nvim-treesitter-playground/query_linter.lua:157>
Press ENTER or type command to continue

Just for reference, this is where my cursor was when I gave it a go.

Hi @MostHated, I can't seem to reproduce the issue. Also your screenshot / stack trace doesn't have any direct connection to query-secretary itself.
I haven't updated my plugins for a while but your stack trace indicate something to do with nvim-treesitter-playground. Sorry but I can't really don't know how to help you atm.

Oh, interesting. I even read that and didn't think much of it. I didn't have TSPG opened or anything. I will try and play around with some settings and see if I can narrow something down.

So, it looks like, in the tree-sitter playground settings, if I turn off the setting
require'nvim-treesitter.configs'.setup {
    ...
    query_linter = { enable = false, }
    ...
}

Doing this, the error goes away, though, it is not really practical, to try and go in and swap out settings and what not each time I want to use it (which is quite frequently, at the moment).
Is there any sort of event exposed that I could tie into upon opening the window, then upon closing it? I am wondering if perhaps I can simply set that setting to false before it opens up, the re-enable it after it closes, if that might be enough.
If it were just one message upon opening it, that would not be a huge issue, but unfortunately, the error pops up for ever single cursor move you try to do while the query-secretary window is opened as seen below:
Once I turn it off, everything works as expected. It seems like whatever changes that are happening are making the CursorHold of the tree-sitters linter bug out.
If you have any recommendations, I would greatly appreciate it.

The query_linter option is quite foreign to me. This is my entire nvim-treesitter config
return {
    {
        "nvim-treesitter/nvim-treesitter",
        build = ":TSUpdate",
        dependencies = {
            "nvim-treesitter/playground",
            "windwp/nvim-ts-autotag",
            "p00f/nvim-ts-rainbow",
            "nvim-treesitter/nvim-treesitter-textobjects",
        },
        event = "BufReadPost",
        -- event = { "VeryLazy" },
        config = function()
            require("nvim-treesitter.configs").setup({
                ensure_installed = "all",
                sync_install = false,
                auto_install = true,

                highlight = {
                    enable = true,
                    additional_vim_regex_highlighting = false,
                },

                rainbow = {
                    enable = true,
                    extended_mode = true, -- Also highlight non-bracket delimiters like html tags, boolean or table: lang -> boolean
                    max_file_lines = nil, -- Do not enable for files with more than n lines, int
                },

                autotag = {
                    enable = true,
                },

                textobjects = {
                    select = {
                        enable = true,
                        keymaps = {
                            ["af"] =<EMAIL_ADDRESS>                            ["if"] =<EMAIL_ADDRESS>                            ["am"] =<EMAIL_ADDRESS>                            ["im"] =<EMAIL_ADDRESS>                            ["ab"] =<EMAIL_ADDRESS>                            ["ib"] =<EMAIL_ADDRESS>                            ["aa"] =<EMAIL_ADDRESS>                            ["ia"] =<EMAIL_ADDRESS>                            ["as"] =<EMAIL_ADDRESS>                        },
                    },
                },

                playground = {
                    enable = true,
                    disable = {},
                    updatetime = 25, -- Debounced time for highlighting nodes in the playground from source code
                    persist_queries = true, -- Whether the query persists across vim sessions
                    keybindings = {
                        toggle_query_editor = "o",
                        toggle_hl_groups = "i",
                        toggle_injected_languages = "t",
                        toggle_anonymous_nodes = "a",
                        toggle_language_display = "I",
                        focus_language = "f",
                        unfocus_language = "F",
                        update = "R",
                        goto_node = "<cr>",
                        show_help = "?",
                    },
                },
            })
        end,
    },
}

I understand. It looks like info on the query linter is on the acrual playground page, not the tree-sitter page: https://github.com/nvim-treesitter/playground#query-linter
I have the actual tree-sitter 'query language' language installed, as I am writing a tree-sitter grammar and parser for a language. My setup is probably a bit less common than other folks because of this, so not a lot of people may run into this issue. So not sure if it is worth your time to look into, which I can understand. I can just deal with the issue, and enable/disable the linter as needed.

Since I don't have adequate knowledge to diagnose and resolve the issue, I'll keep it open for now. Thank you for understanding.


Release tarballs now contain hardlinks

Since around 2024-05-31, Nixpkgs tarballs contain encoded hardlinks.
Older tarball:
$ curl https://releases.nixos.org/nixpkgs/nixpkgs-24.11pre632986.aa61b27554a5/nixexprs.tar.xz \
  | tar -Jxvv | grep 'link to'
[no result]

Newer tarball:
$ curl https://releases.nixos.org/nixpkgs/nixpkgs-24.11pre633168.6132b0f6e344/nixexprs.tar.xz \
  | tar -Jxvv | grep 'link to'
nixpkgs-24.11pre633168.6132b0f6e344/lib/tests/modules/declare-bare-submodule-deep-option.nix
  link to nixpkgs-24.11pre633168.6132b0f6e344/lib/tests/modules/declare-bare-submodule-deep-option-duplicate.nix
nixpkgs-24.11pre633168.6132b0f6e344/lib/tests/modules/disable-recursive/foo.nix
  link to nixpkgs-24.11pre633168.6132b0f6e344/lib/tests/modules/disable-recursive/bar.nix
nixpkgs-24.11pre633168.6132b0f6e344/lib/tests/packages-from-directory/c/support-definitions.nix
  link to nixpkgs-24.11pre633168.6132b0f6e344/lib/tests/packages-from-directory/c/not-a-namespace/not-a-package.nix
nixpkgs-24.11pre633168.6132b0f6e344/nixos/modules/hardware/video/radeon.nix
  link to nixpkgs-24.11pre633168.6132b0f6e344/nixos/modules/hardware/network/broadcom-43xx.nix
nixpkgs-24.11pre633168.6132b0f6e344/pkgs/applications/networking/cluster/k3s/1_28/chart-versions.nix
  link to nixpkgs-24.11pre633168.6132b0f6e344/pkgs/applications/networking/cluster/k3s/1_27/chart-versions.nix
[...]

Because of a new Nix bug, this causes problems when fetching these tarballs with builtins.fetchTarball, which happens CI of a project I maintain. While the bug should ultimately be fixed, this will take a while, and it would be best if we could revert to not generating hardlinks in these tarfiles.
Unfortunately I don't know what causes this. I suspect it's due to an optimised store now being enabled somewhere. It might also be related to @mweinelt updating all builders on 2024-05-29. It might also be related to the nixos-channel-scripts code that repacks the archive.
This was briefly discussed on Matrix

Should become more reproducible now thanks to https://github.com/NixOS/nixpkgs/pull/317122!


hasShareIntent not firing - Standalone Build

Hi,
first of all, thanks a lot for this library, it really saves a lot of time concerning configuration!
In my case however there is the following bug:
When i click my app icon in the share dialog from an image of the photo gallery, it does redirect correctly, i.e. it opens my app, but the useShareIntent hook does not fire (at all), no matter if the app is opened in the background or closed.
The App.js file looks like this, and i tested it just to see if it shows any Alert:
export default function App() {
  const { hasShareIntent, shareIntent, error } = useShareIntent();

  useEffect(() => {
    if (hasShareIntent) {
      Alert.alert(
        "HASSHARE INTENT",
        `has share intent: ${hasShareIntent} and also has text: ${shareIntent?.text}`
      );
    }
  }, [hasShareIntent]);

  useEffect(() => {
    if (!!error) {
      Alert.alert("ERROR SHARE INTENT", `has share intent: ${error}`);
    }
  }, [error]);

  return (...)

and nothing happens even when i come from a share intent.
Note: I create  my builds with EAS and when I created a dev-build, the app icon is not visible inside of the share dialog (e.g. of an image of the photo gallery), but when I create a standalone build, only then the app icon appears...(Not sure if I need some extra config steps to get it running on a local dev-build...)
Anyway, thats why I had to include Alerts, since I cant really debug it well with a standalone build
Details:

expo version 50
target: iOS
build created with EAS (standalone build)
package version 1.0.0
device: real device (iPhone 11)

Any ideas?
Also: if anyone knows how to get it running on a dev-client, please share :)

dev client and simulator build should not defere, make sure you do a expo prebuild --no-install --clean before running the app with expo run:ios

Hi @achorein, thanks for the response! Ok, I'll try that.
Concerning the main bug (that the hooks are not firing): Can you reproduce that one?
Do you need any additional infos?
Br

Ok strange...For some reason now it is working on the dev client (without ejecting from expo managed workflow).
But somehow for production build (created with eas build) it still doesn't fire the shareIntent hook...🤔
Does it have to do with how eas creates the binary?

I am also experiencing this issue. Everything works perfectly running with expo run:ios. Build created with eas build, hook does not fire. App opens as it should after sharing, just nothing happens.

do you have any third party which handle deep link ? (for iOS we need to have access to the deep link url)
i'm working on a new version to allow react navigation to work correctly for example

Not that I know of. Here's the dependencies and plugins. Anything look suspicious?
I've removed these and still the same behaviour
"@react-native-firebase/analytics": "^19.0.1",
"@react-native-firebase/app": "^19.0.1",
"@react-native-firebase/crashlytics": "^19.0.1",
"@react-native-firebase/messaging": "^19.0.1",
"@notifee/react-native": "^7.8.2",
"dependencies": {     "@backpackapp-io/react-native-toast": "^0.10.0",     "@fortawesome/fontawesome-svg-core": "^6.5.1",     "@fortawesome/free-brands-svg-icons": "^6.5.1",     "@fortawesome/free-regular-svg-icons": "^6.5.1",     "@fortawesome/free-solid-svg-icons": "^6.5.1",     "@fortawesome/react-native-fontawesome": "^0.3.0",     "@georstat/react-native-image-cache": "^3.1.0",     "@gorhom/bottom-sheet": "^4.6.0",     "@hcaptcha/react-native-hcaptcha": "^1.6.0",     "@notifee/react-native": "^7.8.2",     "@react-native-async-storage/async-storage": "1.21.0",     "@react-native-clipboard/clipboard": "^1.13.2",     "@react-native-community/netinfo": "11.1.0",     "@react-native-firebase/analytics": "^19.0.1",     "@react-native-firebase/app": "^19.0.1",     "@react-native-firebase/crashlytics": "^19.0.1",     "@react-native-firebase/messaging": "^19.0.1",     "@react-native-masked-view/masked-view": "0.3.0",     "@react-navigation/bottom-tabs": "^6.5.9",     "@react-navigation/native": "^6.1.8",     "@react-navigation/native-stack": "^6.9.14",     "@shopify/flash-list": "1.6.3",     "configcat-js": "^9.4.0",     "crypto-js": "^3.3.0",     "date-fns": "^3.3.1",     "expo": "^50.0.11",     "expo-application": "~5.8.3",     "expo-build-properties": "~0.11.1",     "expo-document-picker": "~11.10.1",     "expo-http-server": "^0.1.0",     "expo-image": "~1.10.6",     "expo-share-intent": "^1.0.1",     "expo-splash-screen": "~0.26.4",     "expo-system-ui": "~2.9.3",     "expo-updates": "~0.24.11",     "i18next": "^23.5.1",     "intl-pluralrules": "^2.0.1",     "lodash": "^4.17.21",     "lottie-react-native": "6.5.1",     "native-base": "^3.4.28",     "nativewind": "^4.0.36",     "react": "18.2.0",     "react-i18next": "^13.2.2",     "react-native": "0.73.4",     "react-native-animated-progress": "^1.0.2",     "react-native-dialog": "^9.3.0",     "react-native-file-access": "^3.0.4",     "react-native-gesture-handler": "~2.14.0",     "react-native-haptic-feedback": "^2.2.0",     "react-native-in-app-review": "^4.3.3",     "react-native-keyboard-aware-scroll-view": "^0.9.5",     "react-native-localize": "^3.0.2",     "react-native-modal": "^13.0.1",     "react-native-purchases": "^7.22.0",     "react-native-reanimated": "~3.6.2",     "react-native-recaptcha-that-works": "^2.0.0",     "react-native-safe-area-context": "4.8.2",     "react-native-screens": "~3.29.0",     "react-native-sensitive-info": "^6.0.0-alpha.9",     "react-native-svg": "14.1.0",     "react-native-webview": "13.6.4",     "timed-cache": "^2.0.0"   }
"plugins": [       "@react-native-firebase/app",       "@react-native-firebase/messaging",       "@react-native-firebase/crashlytics",       "expo-document-picker",       [         "expo-build-properties",         {           "android": {             "usesCleartextTraffic": true,             "extraMavenRepos": [               "../../node_modules/@notifee/react-native/android/libs"             ]           },           "ios": {             "useFrameworks": "static"           }         }       ],       [         "expo-share-intent",         {           "iosActivationRules": {             "NSExtensionActivationSupportsText": true,             "NSExtensionActivationSupportsWebURLWithMaxCount": 1,             "NSExtensionActivationSupportsWebPageWithMaxCount": 1           },           "androidIntentFilters": ["text/*", "image/*"],           "androidMultiIntentFilters": ["text/*", "image/*"]         }       ]     ]

🤔  i haven't tested with static build

Ah that could be the reason...we're using them too:
"plugins": [
      "expo-localization",
      "expo-apple-authentication",
      "expo-font",
      "react-native-iap",
      "@react-native-firebase/app",
      "@react-native-firebase/crashlytics",
      [
        "expo-share-intent",
        {
          "iosActivationRules": {
            "NSExtensionActivationSupportsImageWithMaxCount": 1,
            "NSExtensionActivationSupportsFileWithMaxCount": 1
          }
        }
      ],
      [
        "expo-build-properties",
        {
          "ios": {
            "useFrameworks": "static"
          }
        }
      ],
      [
        "expo-share-intent",
        {
          "iosActivationRules": {
            "NSExtensionActivationSupportsImageWithMaxCount": 1
          }
        }
      ]
    ]

I have removed firebase & static frameworks, unfortunately still seeing the issue

Ah that could be the reason...we're using them too:
"plugins": [
      "expo-localization",
      "expo-apple-authentication",
      "expo-font",
      "react-native-iap",
      "@react-native-firebase/app",
      "@react-native-firebase/crashlytics",
      [
        "expo-share-intent",
        {
          "iosActivationRules": {
            "NSExtensionActivationSupportsImageWithMaxCount": 1,
            "NSExtensionActivationSupportsFileWithMaxCount": 1
          }
        }
      ],
      [
        "expo-build-properties",
        {
          "ios": {
            "useFrameworks": "static"
          }
        }
      ],
      [
        "expo-share-intent",
        {
          "iosActivationRules": {
            "NSExtensionActivationSupportsImageWithMaxCount": 1
          }
        }
      ]
    ]

do you mind including your full dependencies? I removed almost all packages from my project and it started working, so I think there must be something in here that's causing the problem. Maybe we can compare and see what packages we have in common
"dependencies": {
    "@backpackapp-io/react-native-toast": "^0.10.0",
    "@fortawesome/fontawesome-svg-core": "^6.5.1",
    "@fortawesome/free-brands-svg-icons": "^6.5.1",
    "@fortawesome/free-regular-svg-icons": "^6.5.1",
    "@fortawesome/free-solid-svg-icons": "^6.5.1",
    "@fortawesome/react-native-fontawesome": "^0.3.0",
    "@georstat/react-native-image-cache": "^3.1.0",
    "@gorhom/bottom-sheet": "^4.6.0",
    "@hcaptcha/react-native-hcaptcha": "^1.6.0",
    "@notifee/react-native": "^7.8.2",
    "@react-native-async-storage/async-storage": "1.21.0",
    "@react-native-clipboard/clipboard": "^1.13.2",
    "@react-native-community/netinfo": "11.1.0",
    "@react-native-firebase/analytics": "^19.0.1",
    "@react-native-firebase/app": "^19.0.1",
    "@react-native-firebase/crashlytics": "^19.0.1",
    "@react-native-firebase/messaging": "^19.0.1",
    "@react-native-masked-view/masked-view": "0.3.0",
    "@react-navigation/bottom-tabs": "^6.5.9",
    "@react-navigation/native": "^6.1.8",
    "@react-navigation/native-stack": "^6.9.14",
    "@shopify/flash-list": "1.6.3",
    "configcat-js": "^9.4.0",
    "crypto-js": "^3.3.0",
    "date-fns": "^3.3.1",
    "expo": "^50.0.11",
    "expo-application": "~5.8.3",
    "expo-build-properties": "~0.11.1",
    "expo-document-picker": "~11.10.1",
    "expo-http-server": "^0.1.0",
    "expo-image": "~1.10.6",
    "expo-share-intent": "^1.0.1",
    "expo-splash-screen": "~0.26.4",
    "expo-system-ui": "~2.9.3",
    "expo-updates": "~0.24.11",
    "i18next": "^23.5.1",
    "intl-pluralrules": "^2.0.1",
    "lodash": "^4.17.21",
    "lottie-react-native": "6.5.1",
    "native-base": "^3.4.28",
    "nativewind": "^4.0.36",
    "react": "18.2.0",
    "react-i18next": "^13.2.2",
    "react-native": "0.73.4",
    "react-native-animated-progress": "^1.0.2",
    "react-native-dialog": "^9.3.0",
    "react-native-file-access": "^3.0.4",
    "react-native-gesture-handler": "~2.14.0",
    "react-native-haptic-feedback": "^2.2.0",
    "react-native-in-app-review": "^4.3.3",
    "react-native-keyboard-aware-scroll-view": "^0.9.5",
    "react-native-localize": "^3.0.2",
    "react-native-modal": "^13.0.1",
    "react-native-purchases": "^7.22.0",
    "react-native-reanimated": "~3.6.2",
    "react-native-recaptcha-that-works": "^2.0.0",
    "react-native-safe-area-context": "4.8.2",
    "react-native-screens": "~3.29.0",
    "react-native-sensitive-info": "^6.0.0-alpha.9",
    "react-native-svg": "14.1.0",
    "react-native-webview": "13.6.4",
    "timed-cache": "^2.0.0"
  },
  "devDependencies": {
    "@babel/core": "^7.22.20",
    "@babel/runtime": "^7.24.0",
    "@babel/preset-env": "^7.22.20",
    "@react-native-community/eslint-config": "^3.2.0",
    "@react-native/eslint-config": "^0.72.2",
    "@react-native/metro-config": "^0.73.5",
    "@tsconfig/react-native": "^3.0.2",
    "@types/crypto-js": "^4.1.1",
    "@types/jest": "^29.5.5",
    "@types/lodash": "^4.14.199",
    "@types/metro-config": "^0.76.3",
    "@types/react": "^18.2.22",
    "@types/react-native-animated-progress": "^1.0.1",
    "@types/react-native-dotenv": "^0.2.0",
    "@types/react-test-renderer": "^18.0.2",
    "@types/timed-cache": "^2.0.1",
    "@typescript-eslint/eslint-plugin": "^6.7.2",
    "@typescript-eslint/parser": "^6.7.2",
    "babel-jest": "^29.7.0",
    "babel-plugin-module-resolver": "^5.0.0",
    "eslint": "^8.50.0",
    "eslint-config-prettier": "^9.0.0",
    "eslint-import-resolver-babel-module": "^5.3.2",
    "eslint-plugin-import": "^2.28.1",
    "eslint-plugin-jest": "^27.6.1",
    "eslint-plugin-prettier": "^5.0.0",
    "jest": "^29.7.0",
    "metro-react-native-babel-preset": "0.77.0",
    "patch-package": "^8.0.0",
    "postinstall-postinstall": "^2.1.0",
    "prettier": "3.0.3",
    "react-native-dotenv": "^3.4.9",
    "react-native-svg-transformer": "^1.1.0",
    "react-native-url-polyfill": "^2.0.0",
    "react-test-renderer": "18.2.0",
    "tailwindcss": "^3.4.1",
    "typescript": "^5.3.0"
  },

Do you have your useShareIntent hook in your top App component ? It should be use before any other Provider.
(FYI: next version will add a ShareIntentProvider to persist data on multiple screen)
If it's already the case maybe the dependancy problem it's on the native module side :/

After doing some more digging, in my case, it's caused by expo-updates.
Disabling updates allows the share intent to work:
"updates": {
      "enabled": false,
      "url": "https://u.expo.dev/...."
    }

I'm still doing some more testing in release mode, but I'm seeing a couple other potential issues. They could be just issues with my project, or general issues, not sure yet.

Sharing once works fine. If I then go back to the other app and share the same thing again, the share sheet freezes. Sometime it will open the share modal, and then freeze.

Sharing unusual text causes the app to crash. Could be just my app, not sure yet. Text like this for example, possibly line breaks, or when the text is in multiple elements:

A datapoint if useful -- everything worked great for me, then today I installed expo-updates, and now it does not work anymore. This is the only change ive made today, and expo-share-intent worked great yesterday.
My symptoms are just as explained by @Roc8Trppn. The app opens, but useShareIntent does not fire.

My situation matches the OP -- everything works until it gets back to my app and the share intent doesnt fire. I removed another library that touched deep links and now it works again. So some kind of collision there.

@simonsturg thanks for your test ! can you open 2 new issues to address theses problem ? 👍
@joshmohrer great, do you have the dependancy name to make a reproductable example ?
Can your try with this hierarchy :
const { shareIntent ) = useShareIntent({ debug: true });
console.log(shareIntent);

return (
  <Provider1>
    <Provider2>
       <App>
     <Provider2>
  </Provider1>
)

After doing some more digging, in my case, it's caused by expo-updates.
Disabling updates allows the share intent to work:
"updates": {
      "enabled": false,
      "url": "https://u.expo.dev/...."
    }

I'm still doing some more testing in release mode, but I'm seeing a couple other potential issues. They could be just issues with my project, or general issues, not sure yet.

Sharing once works fine. If I then go back to the other app and share the same thing again, the share sheet freezes. Sometime it will open the share modal, and then freeze.
Sharing unusual text causes the app to crash. Could be just my app, not sure yet. Text like this for example, possibly line breaks, or when the text is in multiple elements:

Wow good catch! I removes expo-updates and it works now for my standalone version! nice one @simonsturge

@achorein just wondering if you have any ideas on what might cause the incompatibility with expo-updates, and if you think it's fixable?
i've disabled it in my app for now, however, I'd really like to be able to enable it at some point in the future

I kicked the tires a bit on my end and am sure airbridge sdk is creating a similar conflict as expo-updates. Both seem to break expo-share-intent in a similar way. Without either in my project, share intent works great.
But I have to pick those packages or this one, I think I choose this one. its too useful :)
Let me know if I can support this effort with any additional info.

I don't know why it's causing a problem, i need to make a minimal reproduction example to investigate.
I don't have the time right now but will do later.

@achorein i realize this would be a guess, but do you think it’s possible that the problem here would be resolved using expo router instead of react navigation?

@achorein i realize this would be a guess, but do you think it’s possible that the problem here would be resolved using expo router instead of react navigation?

Don't think so

@joshmohrer when using airbridge-expo-sdk you have to configure deeplink manualy (https://help.airbridge.io/en/developers/expo-sdk#deep-link-setup).
With react-navigation just add a listener in your linking configuration (see example here)
Airbridge.deeplink.setDeeplinkListener((deeplink) => {
   listener(deeplink);
})

any lib that intercepts deeplinks must be configured manually.

When I have this in place
  Airbridge.deeplink.setDeeplinkListener((deeplink) => {
    // code that will run when app is opened with deep-link or deferred-deep-link
    // deeplink = YOUR_SCHEME://...
    console.log("its me airbridge listener", deeplink);
  });

it logs
 LOG  its me airbridge listener wave-app://dataUrl=wave-appShareKey#file

can you try this :
  Airbridge.deeplink.setDeeplinkListener((deeplink) => {
    // import { getShareIntent } from "expo-share-intent";
    if (deeplink?.startsWith(`${Constants.expoConfig?.scheme}://dataUrl`)) {
      getShareIntent(deeplink);
    }
  })

this will trigger a change event from the native module (retreived by hook or provider)

That worked! @achorein you are a legend. Thank you!

It works fine with expo-updates for me now as well, btw.

I added expo-update in the basic example without any problems (simulator and eas with dev-client).
I also added some compatibilty check in v1.2.1 if you still have problem give it a try.

I added expo-update in the basic example without any problems (simulator and eas with dev-client).
I also added some compatibilty check in v1.2.1 if you still have problem give it a try.

Did you try this in release configuration also?

closing the issue for now, i will handle the expo-updates part in https://github.com/achorein/expo-share-intent/issues/46.


Github Collectors: Handle Premature close gracefully

Which area(s) are affected? (leave empty if unsure)
No response
To Reproduce
The error Premature close is causing some indexing errors.
Describe the Bug
Indexing is unnecessarily skipping some artifacts because it's encountering these errors.
Expected Behavior
We should retry connection failures such as Premature close when making calls to github or any other service.

Fixed in #429


web-data licensing question

I see that there is a mix of content and licenses in various parts of this repository (depending on their originating source, which makes total sense to me).
I wanted to inquire specifically about the web-data package/directory, and the data folder within. These don't seem to have a specific license applied, I'm not sure if the license from the root of the project applies, and so I wonder how they are licensed according to you?
Appreciate your help figuring this out.

I added a license file. I hope that's helpful.

That's great, thank you!

Thank you for replying, but I'm still not seeing any license in the web-data package folder (or any new commits in the last 5 days).
Something got missed perhaps?

Sorry, now it pushed (https://github.com/microsoft/vscode-custom-data/blob/main/web-data/LICENSE.md) and will be published to npm soon.

Thanks for posting the license.
I'd like to ask a clarification question.
We're interested in using the two files browsers.css-data.json and browsers.html-data.json, from the web-data/data folder.
How would you say those two files are licensed? I'm not super clear about the distinction between data and content in the license.  So I'm not sure under which one it falls.
CC BY-SA 2.5 is a viral license (like GPLv3) so this is critical for us to understand before consuming.
Hope this isn't a bother. :)

Sorry, I read up on this and removed the reference to CC BY-SA 2.5. It's now pure MIT.
This is based on my understanding  of the discussion here https://github.com/mdn/data/issues/210#issuecomment-387572808 that we had with MDN.
I'll have this checked with our legal guys, before I'll publish the next version.
You want to have this checked as well, if you have doubts.

Thanks for clearing this up, I'll be sure to run it past our legal too.

Hi, just wondering if it was settled and can be published?


error: 'timer_isr_callback_add'

Hello,
I try use it on ESP32 board. Please help, why dont work for me?
Thanx,
Jan
.pio\libdeps\Windows\ESP32_New_ISR_Servo\src\ESP32_New_FastTimerInterrupt.h:287:100: error: 'timer_isr_callback_add' was not declared in this scope             timer_isr_callback_add(_timerGroup, _timerIndex, _callback, (void *) (uint32_t) _timerNo, 0);                                                                                ^ .pio\libdeps\Windows\ESP32_New_ISR_Servo\src\ESP32_New_FastTimerInterrupt.h: In member function 'void ESP32FastTimerInterrupt::detachInterrupt()':     .pio\libdeps\Windows\ESP32_New_ISR_Servo\src\ESP32_New_FastTimerInterrupt.h:317:66: error: 'TIMER_INTR_T0' was not declared in this scope        timer_group_intr_disable(_timerGroup, (_timerIndex == 0) ? TIMER_INTR_T0 : TIMER_INTR_T1);                                                                   ^ .pio\libdeps\Windows\ESP32_New_ISR_Servo\src\ESP32_New_FastTimerInterrupt.h:317:82: error: 'TIMER_INTR_T1' was not declared in this scope        timer_group_intr_disable(_timerGroup, (_timerIndex == 0) ? TIMER_INTR_T0 : TIMER_INTR_T1);                                                                                ^ .pio\libdeps\Windows\ESP32_New_ISR_Servo\src\ESP32_New_FastTimerInterrupt.h: In member function 'void ESP32FastTimerInterrupt::reattachInterrupt()':   .pio\libdeps\Windows\ESP32_New_ISR_Servo\src\ESP32_New_FastTimerInterrupt.h:329:65: error: 'TIMER_INTR_T0' was not declared in this scope        timer_group_intr_enable(_timerGroup, (_timerIndex == 0) ? TIMER_INTR_T0 : TIMER_INTR_T1);                                                                  ^ .pio\libdeps\Windows\ESP32_New_ISR_Servo\src\ESP32_New_FastTimerInterrupt.h:329:81: error: 'TIMER_INTR_T1' was not declared in this scope        timer_group_intr_enable(_timerGroup, (_timerIndex == 0) ? TIMER_INTR_T0 : TIMER_INTR_T1);

You have to follow the Prerequisites and use the ESP32 core 2.0.0+, for example the latest v2.0.1
Good Luck,


Sass not compiling

Command called: "liveSass.command.watchMySass"
--------------------
Starting to compile all files
--------------------
Changing status bar to: "Working on it..."
--------------------
Getting SASS files
Query pattern: **/[^_]*.s[a|c]ss
Can be overwritten: true
--------------------
Checking folder 1 of 1
Folder: Jay Art bio
--------------------
No base folder override found. Keeping workspace folder
--------------------
Found 1 SASS files
--------------------
Compiling Sass/Scss Files:
e:\repos\Jay Art bio\style.scss
--------------------
Starting file 1 of 1
Path: e:\repos\Jay Art bio\style.scss
--------------------
Starting format 1 of 1
Settings: {"format":"expanded","extensionName":".css","savePath":null}
--------------------
Calculating file paths
Calculating the save paths for the css and map output files
Originating path: e:\repos\Jay Art bio\style.scss
--------------------
Searching for workspace
Need to find a workspace folder that holds the file
--------------------
Workspace has folder
Searching for the workspace folder where this file is located
Path: e:\repos\Jay Art bio\style.scss
--------------------
Checking folder 1 of 1
Folder: Jay Art bio
MATCH
--------------------
Using: e:\repos\Jay Art bio
--------------------
Starting compilation
Starting compilation of file
Path: e:\repos\Jay Art bio\style.scss
--------------------
Autoprefixer isn't false, applying to file
Path: e:\repos\Jay Art bio\style.scss
--------------------
Preparing autoprefixer
--------------------
Changing BROWSERSLIST_DISABLE_CACHE setting
Was: undefined
Now: 1
--------------------
Starting autoprefixer
--------------------
Completed autoprefixer
--------------------
Restored BROWSERSLIST_DISABLE_CACHE to: undefined
--------------------
Saving file
Saving a file to the system
Target: e:\repos\Jay Art bio\style.css.map
--------------------
Saving file
Saving a file to the system
Target: e:\repos\Jay Art bio\style.css
--------------------
Generated:
Changing status bar to: Success
Registered timeout to switch state back
--------------------
e:\repos\Jay Art bio\style.css.map
e:\repos\Jay Art bio\style.css
--------------------
Switching UI state
--------------------
Changing status bar to: Watching
--------------------
Watching...
--------------------
Switching UI state
--------------------
Changing status bar to: Watching
--------------------
Watching...
--------------------
Firing timeout function to switch back
--------------------
Changing status bar to: Watching
--------------------

This is the only output i get on scss file change. This doesnt send the change to the css file

VS Code event: "onDidSaveTextDocument"

The only it doesn't output after that point is if the file isn't a SASS file. I have copied the code below - this is the checks that the code performs.
FYI: fileName is the full path of the file that we are checking and partialSass is an argument that, in this case, is true.
return (
    (partialSass || !filename.startsWith("_")) &&
    (filename.endsWith("sass") || filename.endsWith("scss"))
);

What is the name and extension of the file you're saving?
Does it output the same message again when you save once more? It should do so every time you save anything in your project tbh.

Hi, so ive tried it with a file named _style.scss in a new vs code window and also with standard style.scss in my project but none are working correctly. it doesnt update the css on save at all only on the odd occasion where i delete something it randomly works then stops updating.
at the moment it only works on a forced compile when i click watch sass after turning off.
i get this print whenever i make a change VS Code event: "onDidSaveTextDocument"
This started happening about 2 days ago now.
Ive tried rolling back to a previous update also but to no avail.

Can you try the below, that is if it's the same issue as #96

I believe I have identified the issue. Can you see if v5.1.0-rc.2 fixes your issue.
You can see installation instruction here
Thanks

I tried the update yesterday but it didn't work for me!
It started not compiling since about 3 days ago where I made an extra scss file in one of my workspaces for my project started playing up and not updating so I deleted the extra scss file I had made and still was not working

Can you please run liveSass.command.debugFileList and paste the output here. Thanks

Can you please run liveSass.command.debugFileList and paste the output here. Thanks

Hey @CarterStevens1, have you had a chance to rn the above?

hi glenn,
I haven't unfortunately i have switched to using a bat file instead and running it through the terminal as nothing was working for me!

No problem. I will close this issue for now as more info is required


[Story] Sort organizations by their number of challenges supported (frontend)

Add an item to the menu of sorting strategy to sort challenges by their number of challenges supported in desc order.

@rrchai The backend is ready for this feature.


Compile class transformer work error in vite-react-swc

UnoCSS version
v0.51.13
Describe the bug
Configure the uno transformer with compile class transformer, vite react app get error when using :uno: in className.

Reproduction
https://stackblitz.com/edit/unocss-unocss-tublnd?file=tsconfig.node.json,vite.config.ts,src%2FApp.tsx,package.json
@vitejs/plugin-react works
@vitejs/plugin-react-swc not work
System Info
No response
Validations

[X] Read the Contributing Guidelines.
[X] Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
[X] Check that this is a concrete bug. For Q&A open a GitHub Discussion or join our Discord Chat Server.
[X] The provided reproduction is a minimal reproducible example of the bug.

Did you ever find out what the cause of this error is?
I'm having the same error in a different context: Vite + Vue + CSS files transformer + apparently using nesting, & and possibly pseudo selectors like &::backdrop.
I'm trying to create a repro on StackBlitz but it seems to work, so not sure what the trigger is.
BTW your repro link actually also works for me?? Yet I'm seeing this issue locally on latest release of everything (unocss, Vite).

It seems that this error is no longer seen in the latest version. I will close this issue first. If you still have problems, please update the demo and open it again. Thank you.


Assessment 1

Metric
Value

alert_status
:white_check_mark: OK

bugs
1

code_smells
7

reliability_rating
E (at least 1 Blocker Bug)Note: A being best, E being worst

security_rating
A (0 Vulnerabilities)Note: A being best, E being worst

vulnerabilities
0


different learning rates to different layers of a CNN.

Hi,
I wonder if there is a way to specify different learning rates to different layers of a CNN.
thanks

I also have this question - can there be different learning rates for different network layers? Also, can weights and biases have different learning rates?

hi
could you please check this:
[https://github.com/nagash91/keras/commit/08d73ef7957fbe5f59099b9e2986d8165ee131e8]
I receive this error when I want to call Convolution1D:
TypeError: init() takes at least 3 arguments (1 given)
and here is the code:
inp = Input(shape=(94319,1))
conv1_coch= Convolution1D(filters=129, kernel_size=401)(inp)

You could create your own optimizer where lr is a matrix and not a scalar.
https://github.com/fchollet/keras/blob/master/keras/optimizers.py#L133.

Thanks @Dref360 I'll give it a try.
@sajabdoli Your link is not working for me.


Figure out why NameRes is showing up as a TRAPI endpoint on SmartAPI

This appears to be because the URL https://trapi-openapi.apps.renci.org/utility/infores%3Asri-name-resolver?version=* has been registered in SmartAPI as https://smart-api.info/registry?q=9995fed757acd034ef099dbb483c4c82, and is therefore displayed in the ARAX SmartAPI list -- note this only has the translator tag, just like the actual NameRes production OpenAPI, but it's possible the "TRAPI vQuality" in the title might be cause ARAX to think that this is a TRAPI endpoint.

(Trapi vUtility) is now removed from the title of name resolution.

Thanks, Yaphet! That seems to have removed them from the list at https://arax.ncats.io/beta/?smartapi=1 -- I'll check with Eric and see if we're good to close this issue.


Convert to GenServer

Coverage decreased (-0.06%) to 98.592% when pulling 9b8647032f8a3d01186959b81718a4604f48b94d on genserver into 6b9a3ead650d4d9dcd6c92b912aaa125b7eafa65 on master.


Multiple Chosen enhanced selects in a singled field.

Assertions:

DropdownFields are enhanced in the CMS with Chosen
When using DateField with setConfig('dmyfields', true) you get 3 numeric fields wrapped in an outer div with class .field

I've extended DateField to create DropdownDateField which does the same thing as DateField with setConfig('dmyfields', true) BUT generates 3 DropdownFields instead of NumericFields.
The problem: Only one of the dropdowns gets the Chosen enhancement. It's because of this line in LeftAndMain.js.
Resolutions: Other then removing the line, I'm not sure. The comments indicate it's there to remove stale DOM elements from deferred cache but I was unable to recreate the issue.

We're no longer using DateField with a dmyfields option in 4.x, so closing this bug

4 years later 😂 I'm impressed by my comments.

Thanks Trevor - yeah, we got there evenntually ;)


x/pkgsite: package removal request for github.com/hoony9x-furiosa-ai/68b4a517-730a-4911-b068-18f7cbcd58a7

Above pkg was created for test purpose from my working place, and right now it is no longer needed.
Therefore, I need to remove it from pkg.go.dev.

GitHub repository hoony9x-furiosa-ai/68b4a517-730a-4911-b068-18f7cbcd58a7 already has been deleted too.

#70606
I re-created issue with proper template.


autoload issue with vimfiler

Consider the following minimal vimrc:
set nocompatible

let $ONEDRIVE_HOME = expand('C:/OD/Users/Pedro')
let $DOTVIM = expand('$ONEDRIVE_HOME/vimfiles')

if has('vim_starting')
    execute 'set runtimepath+=' . expand('$DOTVIM/bundle/neobundle')
endif
call neobundle#begin(expand('$DOTVIM/bundle/'))
NeoBundleFetch 'Shougo/neobundle.vim', {'name' : 'neobundle'}
NeoBundle 'Shougo/vimfiler', {'lazy' : 1, 'autoload' : {
        \ 'commands' : ['VimFilerBufferDir', 'VimFiler',
        \ 'VimFilerCreate', 'VimFilerTab'],
        \ 'explorer' : 1
        \ }
        \ }
call neobundle#end()

filetype plugin indent on

call vimfiler#custom#profile('default', 'context', {
            \ 'direction' : 'topleft'})
call vimfiler#set_execute_file('pdf,PDF', 'SumatraPDF')

Now open Gvim. You will get the following error:

I think the problem might be related to the recent changes in autoload function.

Yes, it is feature.
You should not vimfiler as lazy if call it in initialization.

@Shougo, I don't quite understand your answer.  For example doing:
NeoBundle 'thinca/vim-unite-history', {'lazy' : 1,
        \ 'unite_sources' : ['history/command', 'history/search']
        \ }

works just fine.

@petobens Your vimfiler defines as lazy.
But it is not lazy.  Because, it calls vimfiler functions in .vimrc.

Ahh okok. Thanks @Shougo.


Fix batch loss in training

Get rid of batch_loss in Trainer so that batches can be done more efficiently. Closes #722.

Codecov Report

Merging #726 (2c73658) into main (c068184) will increase coverage by 13.31%.
The diff coverage is n/a.

Additional details and impacted files


[SPARK-20990][SQL] Read all JSON documents in files when multiline mode is on

What changes were proposed in this pull request?
The PR improves the JSON parsing so that now all the JSON documents in a file are read also when the multiLine option is turned on.
How was this patch tested?
UTs have been added to verify this patch.
For previous review please check https://github.com/apache/spark/pull/18731/.
cc @gatorsmile

Can one of the admins verify this patch?

What is the status of this item?

@maracujah it is waiting for review

@mgaido91 This is the work you did three months ago. Could you clean the codes based on the discussions we did in the other PRs? Will review it when you think it is ready

yes, next week I will rebase it on top of current master. Thanks @gatorsmile


Mainnet

Just creating a placeholder ticket so I get a notification once I can try it out. I don't mind losing a small amount of bitcoin for the early adopter credit :-)
Right now if you launch lnd --bitcoin.active --neutrino.active --neutrino.connect=faucet.lightning.community without specifying testnet, it uses testnet anyway. I assume that's by design.

Yes it's testnet by design. No need for a placeholder, you'll likely see the tag on this repo (if you're watching it) once we tag our beta release (along with an announcement post, etc).


Feature/aovs

Refining some much-needed AOV support in HdCycles based on the branch @skwerner started. Currently the viewport is still locked to color as this is how it works inside of Blender and then you toggle which AOV to view. Houdini works differently, it wants all AOVs up-front and then you toggle which to view, and unfortunately there is no way to pass this information to Cycles. This will need a patch to Cycles to work how Houdini expects most likely.
There's also some strange bug where if you set the default display to color/Combined (beauty) and you also have DiffDir/direct-diffuse, it will always default to use DiffDir for the display, perhaps this is a Cycles bug? All other AOVs will not override the default beauty render as default...
Having said all of the above, if we render offline to an .exr or to MPlay with the HD_CYCLES_USE_TILED_RENDERING=1 environment variable, it will render correctly to what you expect, as long as your RenderVars/RenderProducts are all correctly set in the USD file.
For those of you playing at home, to make sure this env-var is working with MPlay, set the Pre-render script on the USD Render ROP node to Python and use:
import os;os.environ['HD_CYCLES_USE_TILED_RENDERING'] = '1';
And the currently searched for default AOVs are listed here, if you were to make your own RenderVars:
Blender Convention | USD Convention (RenderVar name)
Combined             color
Depth                cameraDepth
Normal               normal
IndexOB              primId
IndexMA              IndexMA
Mist                 depth
Emission             Emit
Shadow               Shadow
UV                   UV
Vector               Vector
DiffDir              DiffDir
DiffInd              DiffInd
DiffCol              DiffCol
GlossDir             GlossDir
GlossInd             GlossInd
GlossCol             GlossCol
TransDir             TransDir
TransInd             TransInd
TransCol             TransCol
VolumeDir            VolumeDir
VolumeInd            VolumeInd

I don't think we need to follow exact naming-convention that Blender uses here though, we could go cameCase with more descriptive names.
There is also the start of supporting Cryptomatte in this PR, however this will need to be refined still as Hydra's HDRenderBuffer can only know of 1 buffer at a time, while Cryptomattes need to have multiple ones based on depth/rank. Houdini's Karma gets around this by using a different base-class XUSD_HydraRenderBuffer here which supplies an index to an array of render-buffers:
https://github.com/sideeffects/HoudiniUsdBridge/blob/master/src/houdini/lib/H_USD/HUSD/XUSD_HydraRenderBuffer.h
So that husk will know how to write these to disk properly. If we go down this route we will need to hide it behind a pre-processor define so that there is no hard-dependency onto Houdini (it just means cryptomattes will only work in Houdini/Husk).
There's also the startings of custom AOVs, with the syntax:
"aovc:myCustomColor"
"aovv:myCustomValue"

With the AovOutput shader name being "myCustomColor"/"myCustomValue" to get detected and written to the AOV. However the AovOutput shader node will need some work so that it is successfully detected and added to the authored materials to really test that this works, for now.

Almost ready to non-draft this one.
I've decided to keep the default blender names, I've decoupled aovName from sourceName so it really doesn't matter now.
For example, in MPlay or the EXR, it will take the aovName so it could be whatever the RenderVars define, but sourceName will need to match the token name so that Cycles understands what pass it needs to be.

Just to clarify with what I said earlier about using XUSD_HydraRenderBuffer.h, I've decided to not use this and just manually make separate RenderVars, where sourceName is the base-name eg. CryptoObject, and the aovName(s) are CryptoObject00, CryptoObject01, etc. The cryptomatte_depth value under Cycles->Film acts as a rank value, so a value of 6 means there will need to be 3 RenderVars that go from 00-to-02.
For custom AOVs, these can just simply be either AOVC (colour) or AOVV (value) in sourceName, and the aovName should match the exact name of the AOV shader output. The AOV shader output is currently todo so I can't test this here yet, however I've made built-in ones like P and Pref which work.

#14


Remove warp config

Move somethings around and remove deprecated properties.

Should we add Bilbasen as well? I think Daniel mention the colors are ready.

Sure 👍 I will talk to him


Change default Github redirect

Github currently links to Just the docs.
Change this to say "DXdao Blog on Github", and direct to this base.

Update to this, lets make sure it says "DXdao Blog on Github".
"on Github" is important so users don't click on it expecting a homepage.


Mode safe text patching solution

Is your feature request about something that is currently impossible or hard to do? Please describe the problem.
I'm trying to implement a feature that likes a mirror cursor with text-prop because text-prop is a good solution for managing regions that will follow some text changes.
I tried the below approaches for the situation of
...
.

Listen TextChanged, TextChangedI and TextChangedP.
Detect modified tag name (e.g.: ...
 as span)
Reflect span to other regions

The steps of 3 can't implement for now.

normal! 1G11|v1G13|di... (patching buffer text by i)

It ideal solution but can't use normal! i... if pumvisible() is true.

normal! 1G11|v1G13|dP (patching buffer text by P command)

It does not modify text-props regions.

setline/append/deletebufline (patching buffer text by functions)

It can't realize char-wise changes.

Describe the solution you'd like
I think the ideal solution is allowing normal! i... even if the pumvisible() is true.
Describe alternatives you've considered
Also, the below approaches will solve this problem.

text-props follows the changes that by normal-mode commands
Add a function that likes settext(start_lnum, start_col, end_lnum, end_col, text)

Additional context
The behavior of normal! i... is mentioned in here (https://github.com/vim/vim/blob/master/runtime/doc/insert.txt#L672)

Related #5632

Related #5632

I found the implementation that is responsible for this behavior.
https://github.com/vim/vim/blob/master/src/edit.c#L173

I found the implementation that is responsible for this behavior.
https://github.com/vim/vim/blob/master/src/edit.c#L173

I found the way to solve it!
The substitute command will fix text-props tegions and it is safe to use with pumvisible() = true!

I found the way to solve it!
The substitute command will fix text-props tegions and it is safe to use with pumvisible() = true!


Observation Categories

Adds a mandatory category field to Observations, in anticipation of SHR FHIR profiles which require Observation.category.
Category is required for all Observations, and must come from the following value set: http://hl7.org/fhir/2017Jan/valueset-observation-category.html
For the wiki:
Observation
The Observation state type indicates a point in the module where an observation is recorded. Observations include clinical findings, vital signs, lab tests, etc. The Observation state must come after an Encounter state in the module, but must have the same start time as that Encounter; otherwise it will not be recorded in the patient's record.  See the Encounter section above for more details.
Observation Categories
Common observation categories include:

"vital-signs" :  Clinical observations measure the body's basic functions such as such as blood pressure, heart rate, respiratory rate, height, weight, body mass index, head circumference, pulse oximetry, temperature, and body surface area.
"procedure" : Observations generated by other procedures. This category includes observations resulting from interventional and non-interventional procedures excluding lab and imaging (e.g. cardiology catheterization, endoscopy, electrodiagnostics, etc.). Procedure results are typically generated by a clinician to provide more granular information about component observations made during a procedure, such as where a gastroenterologist reports the size of a polyp observed during a colonoscopy.
"laboratory" : The results of observations generated by laboratories. Laboratory results are typically generated by laboratories providing analytic services in areas such as chemistry, hematology, serology, histology, cytology, anatomic pathology, microbiology, and/or virology. These observations are based on analysis of specimens obtained from the patient and submitted to the laboratory.
"exam" : Observations generated by physical exam findings including direct observations made by a clinician and use of simple instruments and the result of simple maneuvers performed directly on the patient's body.
"social-history" : The Social History Observations define the patient's occupational, personal (e.g. lifestyle), social, and environmental history and health risk factors, as well as administrative data such as marital status, race, ethnicity and religious affiliation.

Supported Properties

Attribute
Type
Description

type
string
Must be "Observation".

category
string
The type of Observation being made, for example . Must be a valid HL7 Observation Category.

unit
string
The unit of measure in which the observation is recorded (e.g. "cm").

codes
[]
One or more codes that describe the Observation. Must be valid LOINC codes.

In SHR, Observation does not require category.  In some elements based on Observation (like VitalSign), it specifies that one of the categories must be a code meaning "vital sign" -- so in that case lower card is 1 because one must be the code for vital sign.  But in general, Observation shouldn't require category.
It appears there may be a bug in the profile exporter that misses the "includes code" constraint -- so the use case I mentioned above (Vital Sign) will show a lower card of 1 in the profile, but won't indicate that one value should be the code for vital sign.  This will require a slice to specify it correctly, and right now the exporter has very limited support for slices.

BTW -- I just logged a bug on the exporter for this: https://github.com/standardhealth/shr-fhir-export/issues/4

Interesting. But right now category is 1..1... and the PR satisfies that constraint. So...

Dylan, it looks like you removed a lot of target encounters... can you comment?

Removing target_encounters was intentional - those are optional/deprecated everywhere except ConditionOnset at this point, so I removed them from the Observations that I touched here. Sorry I probably should have mentioned that in the description.
Re: category not being truly required on Observation - even if it's not strictly required on every Observation it's at least optional so having the category there won't break anything. That said though this implementation does mean that a new module could use a code and specify the wrong category for it.  An alternative approach would be to parse through the SHR StructureDefinitions and produce a mapping of code => category, and then when exporting FHIR lookup the category. Would that be a better option?

No. This approach allows us to be ahead of the profiles. And unit tests (TBD) that focus on those profiles (matching by code, possibly) can catch those errors as they are introduced.

@jawalonoski : Just to be clear, Observation.category is not 1..1 now.  See the Observation struct def.  That said, it is 1..* on some elements (notably, the vital signs).
@dehall: I'm not sure I completely understand what you're suggesting, but it sounds complicated to me.  I'm not suggesting that GFM Observation shouldn't support category at all -- I'm just suggesting that it shouldn't be required for all Observations in GFM.


[checkov] Terraform_checkov stage failing on authentication

The terraform_checkov stage is failing on multiple repositories locally.
The error is complaining about an authentication token being expired or missing.
However, I am unaware of ever having set a token, set up an account over on Bridgecrew and it used to run fine as part of pre-commit.
repos:
- repo: https://github.com/antonbabenko/pre-commit-terraform
  rev: v1.80.0
  hooks:
    # TF Fmt
    - id: terraform_fmt
      args:
      - --args=-check
      - --args=-diff
      - --args=-write=true

    # TF Validate
    - id: terraform_validate
      args:
      - --args=-json
      - --args=-no-color

    # Checkov
    - id: terraform_checkov
      args:
      - --args=--quiet

    # Terraform Docs
    - id: terraform_docs
      args:
      - --hook-config=--add-to-existing-file=true
      - --hook-config=--create-file-if-not-exist=true

    # TF Lint
    - id: terraform_tflint
      args:
      # Manually Enabled Rules
      - --args=--enable-rule=terraform_typed_variables
      # Manually Disabled Rules
      - --args=--disable-rule=terraform_documented_variables
      - --args=--disable-rule=terraform_module_version
      - --args=--disable-rule=terraform_required_providers
      - --args=--disable-rule=terraform_required_version
      - --args=--disable-rule=terraform_unused_declarations

The error is as below:
Checkov..................................................................Failed
- hook id: terraform_checkov
- exit code: 2

2023-05-31 12:01:28,864 [MainThread  ] [ERROR]  Received an error response during authentication
2023-05-31 12:01:28,869 [MainThread  ] [ERROR]  Exception traceback:
Traceback (most recent call last):
  File "/opt/homebrew/Cellar/checkov/2.3.240/libexec/lib/python3.11/site-packages/checkov/main.py", line 355, in run
    bc_integration.setup_bridgecrew_credentials(repo_id=self.config.repo_id,
  File "/opt/homebrew/Cellar/checkov/2.3.240/libexec/lib/python3.11/site-packages/checkov/common/bridgecrew/platform_integration.py", line 263, in setup_bridgecrew_credentials
    self.set_s3_integration()
  File "/opt/homebrew/Cellar/checkov/2.3.240/libexec/lib/python3.11/site-packages/checkov/common/bridgecrew/platform_integration.py", line 276, in set_s3_integration
    repo_full_path, support_path, response = self.get_s3_role(self.repo_id)  # type: ignore
                                             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/opt/homebrew/Cellar/checkov/2.3.240/libexec/lib/python3.11/site-packages/checkov/common/bridgecrew/platform_integration.py", line 327, in get_s3_role
    response = self._get_s3_creds(repo_id, token)
               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/opt/homebrew/Cellar/checkov/2.3.240/libexec/lib/python3.11/site-packages/checkov/common/bridgecrew/platform_integration.py", line 354, in _get_s3_creds
    raise BridgecrewAuthError(error_message)
checkov.common.bridgecrew.platform_errors.BridgecrewAuthError: BCAuthError, Received unexpected response from platform (status code 403). Please verify that your API token is valid and has permissions to call the Bridgecrew APIs.The key must be associated with any role besides Auditor.

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/opt/homebrew/Cellar/checkov/2.3.240/libexec/lib/python3.11/site-packages/checkov/main.py", line 385, in run
    self.exit_run()
  File "/opt/homebrew/Cellar/checkov/2.3.240/libexec/lib/python3.11/site-packages/checkov/main.py", line 589, in exit_run
    exit(0) if self.config.no_fail_on_crash else exit(2)
                                                 ^^^^^^^
  File "<frozen _sitebuiltins>", line 26, in __call__
SystemExit: 2`

Are there some new steps involved in authentication for Checkov? It is possible this issue is not related to pre-commit-terraform. However, I wanted to flag it in case it is a known issue.

@NiallJude hi
These errors go from checkov itself.

(status code 403). Please verify that your API token is valid and has permission to call the Bridgecrew APIs.The key must be associated with any role besides Auditor.

Could you try to fix that error as specified in error msg?
If no luck - run checkov without pre-commit-terraform, and in case checkov produce an error - create an issue for https://github.com/bridgecrewio/checkov
In case checkov works but pre-commit-terraform hook - not please let us know


'Connection reset by peer' while calling using API

Hi folks,
We are often getting this ''Connection reset by peer' error while using various functions. Below is an example of the error while using the 'list_disks()'. Kindly look into this.
Traceback (most recent call last):
File "resources/azureMgr.py", line 426, in
print "--->",obj.get_disk_name_list()
File "resources/azureMgr.py", line 49, in get_disk_name_list
disks = self.sms.list_disks()
File "/usr/local/lib/python2.7/dist-packages/azure/servicemanagement/servicemanagementservice.py", line 2287, in list_disks
Disks)
File "/usr/local/lib/python2.7/dist-packages/azure/servicemanagement/servicemanagementclient.py", line 322, in _perform_get
response = self.perform_get(path, x_ms_version)
File "/usr/local/lib/python2.7/dist-packages/azure/servicemanagement/servicemanagementclient.py", line 136, in perform_get
response = self._perform_request(request)
File "/usr/local/lib/python2.7/dist-packages/azure/servicemanagement/servicemanagementclient.py", line 294, in _perform_request
resp = self._filter(request)
File "/usr/local/lib/python2.7/dist-packages/azure/http/httpclient.py", line 231, in perform_request
resp = connection.getresponse()
File "/usr/lib/python2.7/httplib.py", line 1030, in getresponse
response.begin()
File "/usr/lib/python2.7/httplib.py", line 407, in begin
version, status, reason = self._read_status()
File "/usr/lib/python2.7/httplib.py", line 365, in _read_status
line = self.fp.readline()
File "/usr/lib/python2.7/socket.py", line 430, in readline
data = recv(1)
File "/usr/lib/python2.7/ssl.py", line 241, in recv
return self.read(buflen)
File "/usr/lib/python2.7/ssl.py", line 160, in read
return self._sslobj.read(len)
socket.error: [Errno 104] Connection reset by peer

We also get it all the time when listing blobs in containers.
Ended up wrapping every uses in try except for socket and httplib

Hello,
Sorry for this late answer. Is the problem already there using the latest version of the library and the latest contribution library (like requests 2.9.1)?
Thank you,

Closing this issue due to inactivity. Please feel free to open a new issue if the problem still persists using the latest version.
Thanks!


chore(main): release 1.3.1

:robot: I have created a release beep boop
1.3.1 (2022-10-22)
Bug Fixes

add null-checks in excel export (#121) (0da2e25)

This PR was generated with Release Please. See documentation.

:robot: Release is at https://github.com/rotex1800/registration/releases/tag/v1.3.1 :sunflower:


[Event Hubs][hotfix] Adds try/catch statements around user callback to receive

Includes #5520 and #5779

/azp run js - eventhubs-client - tests

Azure Pipelines could not run because the pipeline triggers exclude this branch/path.

No CI checks?

@HarshaNalluru CI can't be triggered by the bot on hotfix branches. We did run it through DevOps, and locally.

Note that the lock file is only for this tag. I'll eventually have to merge this into master but after resolving merge conflicts what's in master should stay unchanged.


Upgrade embedded Kotlin to 1.8.0

Related

https://github.com/gradle/gradle/issues/21796
https://github.com/gradle/gradle/issues/21882

We also need the upgrade because of https://github.com/JetBrains/kotlin/pull/4933


commit!

Summary
Details and comments

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.1 out of 2 committers have signed the CLA.:white_check_mark: bicycle315:x: Jeong Won KimJeong Won Kim seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.

@bicycle315 Please use a descriptive name for PRs since if merged these are added to the git history. Also make sure you include a description of what you are doing in the PR in the body of the PR.


Card.CustomFields.Definition.Name is not set for some of the custom fields.

Custom Fields Definition.Name is null for some of the custom fields. I ran the unit test "TestMethod1" from Manatee.Trello.UnitTests and observed that there are five custom fields and Definition.Name is set for only one of them.

Thanks for reporting this.  I'll look into it.

I set up some tests.  Looks like this definitely an issue.  I'll have to dig deeper.

I think this was incorrectly closed.

I verified that the name property is turned by the API. It seems there is a break in the data flow at either serialization or in the context layer.

I got it.  It's the action data (and probably notification data, too).  It's attempting to use cached items, but it shouldn't because these should be snapshots of items.  It's only doing this for custom fields.
Now that I know what the problem is, I can fix it!

See Manatee.Trello v3.8.1


Feature/add fs notification mode to file consumer

This PR is related to #137

Added watch mode with file system event notifications
bundled seeker properties

Coverage remained the same at 64.686% when pulling a11af5873b55a105d81efe9fd5d5ef887cfd8118 on feature/add_fs_notification_mode_to_file_consumer into 79c9e891c32c7f311ddef242ffd770a4f0b01776 on master.

Coverage increased (+0.03%) to 64.719% when pulling 6fc11e5a98e94f3efd401819e99dbf6120828fda on feature/add_fs_notification_mode_to_file_consumer into 79c9e891c32c7f311ddef242ffd770a4f0b01776 on master.

Coverage decreased (-0.02%) to 65.159% when pulling c1ba13b101f12e81ca04a67e18d68581b0ffd4ab on feature/add_fs_notification_mode_to_file_consumer into e010ca7972a7740ff87a7407f0e37183bed2c081 on master.

@arnecls : requested changes updated

Coverage decreased (-0.02%) to 65.159% when pulling 22ac632eb72e32aad41d43ebe378f6abdadbd91a on feature/add_fs_notification_mode_to_file_consumer into e010ca7972a7740ff87a7407f0e37183bed2c081 on master.

Coverage decreased (-0.3%) to 65.018% when pulling ae275fc47d65e0117c5f3e7aef133b8a67e3d2a3 on feature/add_fs_notification_mode_to_file_consumer into 43c524641a6e8d82f9d7660726def5e2c471b140 on master.

Coverage decreased (-0.02%) to 65.631% when pulling b720b13168d2c395620a9857ebc6ec037f84b5e2 on feature/add_fs_notification_mode_to_file_consumer into 4b1972c45b90b508342f5a185f0639fc8b79ae92 on master.


Pg/1521 radio button input reset answer paginated layout

IMPORTANT: All PRs must be linked to an issue (except for extremely trivial and straightforward changes).
Fixes #1521
Description
answersChangedCallback was not called as local variable of class QuestionnaireItemViewItem "answers" was updated incorrectly.
Now updated "answers" field by using setAnswer() method to fix it
Type
Choose one: Bug fix
Screenshots (if applicable)
Checklist

[x] I have read and acknowledged the Code of conduct.
[x] I have read the Contributing page.
[x] I have signed the Google Individual CLA, or I am covered by my company's Corporate CLA.
[x] I have discussed my proposed solution with code owners in the linked issue(s) and we have agreed upon the general approach.
[x] I have run ./gradlew spotlessApply and ./gradlew spotlessCheck to check my code follows the style guide of this project.
[x] I have run ./gradlew check and ./gradlew connectedCheck to test my changes locally.
[x] I have built and run the demo app(s) to verify my change fixes the issue and/or does not break the demo app(s).

@aditya-07 can you review this?


import issues

Describe the bug
When I made the PR I tested using the storybook app, now Im trying to use in another application and getting errors:
if I try the default import:
import docx from "remark-docx";

// error
C:\Users\55119\Elucidário.art\elucidario\node_modules\.pnpm\remark-docx@0.1.2\node_modules\remark-docx\lib\index.js:4
var unistUtilVisit = require('unist-util-visit');
                     ^

Error [ERR_REQUIRE_ESM]: require() of ES Module<EMAIL_ADDRESS>from<EMAIL_ADDRESS>not supported.
Instead change the require of<EMAIL_ADDRESS>in<EMAIL_ADDRESS>to a dynamic import() which is available in all CommonJS modules.
    at Object.<anonymous> (C:\Users\55119\Elucidário.art\elucidario\node_modules\.pnpm\remark-docx@0.1.2\node_modules\remark-docx\lib\index.js:4:22)
    at async Promise.all (index 0) {
  code: 'ERR_REQUIRE_ESM'
}

Node.js v18.12.1
 ELIFECYCLE  Command failed with exit code 1.

if I try to import the mjs module:
import docx from "remark-docx/lib/index.mjs";

// error
file:///C:/Users/55119/Elucid%C3%A1rio.art/elucidario/node_modules/.pnpm/remark-docx@0.1.2/node_modules/remark-docx/lib/index.mjs:4
import { convertInchesToTwip, Packer } from 'docx';
                              ^^^^^^
SyntaxError: Named export 'Packer' not found. The requested module 'docx' is a CommonJS module, which may not support all module.exports as named exports.
CommonJS modules can always be imported via the default export, for example using:

import pkg from 'docx';
const { convertInchesToTwip, Packer } = pkg;

    at ModuleJob._instantiate (node:internal/modules/esm/module_job:123:21)
    at async ModuleJob.run (node:internal/modules/esm/module_job:189:5)
    at async Promise.all (index 0)
    at async ESMLoader.import (node:internal/modules/esm/loader:530:24)
    at async loadESM (node:internal/process/esm_loader:91:5)
    at async handleMainPromise (node:internal/modules/run_main:65:12)

Node.js v18.12.1
 ELIFECYCLE  Command failed with exit code 1.

It seems that default import of remark-docx is treated as commonjs but unist-util-visit is published as esm only.
So it may be solved if you transpile unist-util-visit to commonjs, such as transpilePackages in Next.js.
I'm not sure why remark-docx is detected as commonjs. It depends on your build tools.

Actually I'm not using any building script.
I created this repo with a minimal test, just as documented in README.md and the error still occurs: https://github.com/hgodinho/remark-docx-test

Published in 0.1.4.


Try compiling to wasm

Might need to change SQLite to the pure go version.
I think that would allow everything from a single browser tab. Need to check CORS etc.
Watch the memory usage.
Do we also need service worker(s)?

https://github.com/chelmertz/elly/compare/wasm?expand=1
sqlc want more db functions than what we get with the pure golang sqlite implementation, closing.
I could also see managing data migrations needing a rewrite, possibly moving away from sqlite. Not the most fun refactoring needed.


Update fixes

Various fixes for the meteor upgrade!
Also Changes from this pull request without the lint changes.

Nice thank you, what is Service Configuration btw?

That's to config the various Oauth things like facebook and twitter... I think you have to include it now...
If you use the exampleSettings.json
"oAuth": {
    "facebook": {
      "appId": "foo",
      "secret": "bar"
    }
  },  ```
  this will give you an error now "configuration" is not defined

[Service Configuration](https://docs.meteor.com/api/accounts.html#service-configuration)


Pattern: Get person based on "fødselsnummer" and last name

Description
Adding the correct person to a form is a often used pattern. We should have a suggestion on how to solve this.
Screenshots

Considerations

The user needs to enter "fødselsnummer" and at least 4 characters of the persons last name to validate correctly

If you try and fail to many times, you will be blocked from trying again. This also needs to be handled in some way.

What is the best way to search for the person? An own button beneath the input field, the primary button at the bottom, or an auto search/validation when clicking outside the field?

What happens when you enter the first 4 letters of the surname?
What happens if a surname contains less than 4 letters?

Ops requirements

Acceptance criteria

Specification tasks

[x] Design GUI that solves the challenges
[ ] Design an example of how the form should respond to different scenarios

Development tasks

Test

Definition of done

[ ] Documentation (docs.altinn.studio) is updated (if relevant)

[ ] Technical documentation
[ ] User documentation

[ ] QA
[ ] Manual test is complete (if relevant)
[ ] Automated test is implemented (if relevant)
[ ] All tasks in this userstory are closed (i.e. remaining tasks are moved to other user stories or marked obsolete)

Related to https://github.com/Altinn/altinn-studio/issues/7984

We've talked about this use-case in relation to this:

https://github.com/Altinn/app-frontend-react/issues/133

This pattern is needed to complete issue #2372
We suggest a pattern with two input fields and a CTA for validation.
Upon a successful validation, the name field will be populated with a full name and both input fields will be set to read only.
To edit or delete the entry, the user needs to click the "delete" button, which will clear the reset the input fields back to default state.
This pattern should allow for other ways of displaying the output in the future.
For example if there is more information needed from the output, it could be shown in a card or a summary component.

Closed by #2492


Added "strict checks with warnings" option for LDT

Borrows "strict checks with warnings" logic from lis/arch/Config.pl.
Resolves:  #161

Compiles with "strict checks" optimization level -3 - but only if the code described in issue #166 is not compiled.  That will have to be addressed through issue #166.
Approving this pull request.


Add webapp test troubleshooting for Jest / Node v10 compatibility issues

Troubleshooting information related to issues in initial setup when running make test in the mattermost-webapp repo and Jest tests failing if the installed/used version of Node are not v10.15.3+ and npm v6.4.1+
For full context on the issue:
https://community.mattermost.com/core/pl/7dryiy5bzbrufgxmn83ecer9pa

Thanks @henrymori for the pull request!
Per the CONTRIBUTING.md file displayed when you created this pull request, we need to add you to the list of approved contributors for the Mattermost project.
Please help complete the Mattermost contribution license agreement?
This is a standard procedure for many open source projects. Your form should be processed within 24 hours and reviewers for your pull request will be able to proceed.
Please let us know if you have any questions.
We are very happy to have you join our growing community! If you're not yet a member, please consider joining our Contributors community channel to meet other contributors and discuss new opportunities with the core team.

Looks good to me, thanks @henrymori 💯

/check-cla


Need ability to stop an image build in the UI

Description of problem
After an image is started in the UI, the user should be able to stop the process.
Component (web, API, etc)
web
Version or commit hash (if applicable)
0.1.0
Additional info
Refer to the UI design document for details about actions and messaging that should display as part of this workflow.
This issue is related to #278

This issue needs someone assigned to it soon.

Closing this, since #347 is merged


fix: modify keyword argument in get_sdk() of test_oauth.TestOAuth

fix: #22
Should the problem be solved this way?

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

lgtm


Lots of hosts do not respond for my internet connection

Hi,
Thanks for this list, this is going to be super useful for my little project to find out what port ranges are used for cgnat!
I noticed that I don't get any response for lots of hosts in the hourly updated valid_ipv4s.txt using my own script pystun, I tried to validate this by running "run.sh" on Fedora 35 but that's even worse (all hosts seem to fail):
OK 0 , DNS failure 78 , p/Timeout 0 , Timeout 508 , Incorrect 47

I guess there could be a difference in connectivity depending on the Internet connection, it would also be very helpful if the capabilities of the stun servers are available.

Hi @meeuw, thanks for opening the issue. I just ran your script against all valid_ipv4s.txt and virtually all hosts responded correctly.
It seems to me that your firewall/network provider might be blocking UDP traffic. Could you check if this is the case?

Thank you for your reply (as well as the suggestions for pystun).
I've ran your modified script on my internet connection and from an EC2 instance (VPS on AWS) and about 15 hosts don't respond, maybe I'm geo blocked? Anway, many hosts do respond, I might have too high expectations from "always online", it's still very useful.

@meeuw All right, thanks for confirming.
15 unresponsive hosts seem quite high (I get 2-3 when I run your script locally running on a WiFi and behind a CG-NAT) so it might be the case that some of the listed providers block AWS/Azure/GCP IP ranges.
However, I take your point that you expect all of hosts from the list to respond. Unfortunately, most of these STUN servers aren't run with any uptime or quality of service guarantees, so some can always be down even if they were operational at the hourly check time.
One idea that springs to mind would be to use the past checks (e.g. in a "sliding-window" fashion) to find the most reliable services, and publish them in a separate list. It should be fairly straightforward as each check is recorded as a separate commit, and there is a few months' worth of data now in the repository.
If I were to implement this, would you be able to re-run your script in a few different environments to see if there is any improvement?

If I were to implement this, would you be able to re-run your script in a few different environments to see if there is any improvement?

Sorry for the delay, yes most definitely!
Like I said, maybe I'm geoblocked, I haven't thoroughly checked but it seemed the same hosts were not responding everytime I tried.
This is the list ATM, will try again tomorrow:
Response from <IP_ADDRESS>:3478 -> Timeout or other error
Response from <IP_ADDRESS>:3478 -> Timeout or other error
Response from <IP_ADDRESS>:3478 -> Timeout or other error
Response from <IP_ADDRESS>:3478 -> Timeout or other error
Response from <IP_ADDRESS>:3478 -> Timeout or other error
Response from <IP_ADDRESS>:3478 -> Timeout or other error
Response from <IP_ADDRESS>:3478 -> Timeout or other error
Response from <IP_ADDRESS>:3478 -> Timeout or other error
Response from <IP_ADDRESS>:3478 -> Timeout or other error
Response from <IP_ADDRESS>:3478 -> Timeout or other error
Response from <IP_ADDRESS>:3478 -> Timeout or other error
Response from <IP_ADDRESS>:8800 -> Timeout or other error
Response from <IP_ADDRESS>:3478 -> Timeout or other error
Response from <IP_ADDRESS>:3478 -> Timeout or other error
Response from <IP_ADDRESS>:3478 -> Timeout or other error
Response from <IP_ADDRESS>:3478 -> Timeout or other error
Response from <IP_ADDRESS>:3478 -> Timeout or other error

List as of today, looks familiar:
Response from <IP_ADDRESS>:3478 -> Timeout or other error
Response from <IP_ADDRESS>:3478 -> Timeout or other error
Response from <IP_ADDRESS>:3478 -> Timeout or other error
Response from <IP_ADDRESS>:3478 -> Timeout or other error
Response from <IP_ADDRESS>:3478 -> Timeout or other error
Response from <IP_ADDRESS>:3478 -> Timeout or other error
Response from <IP_ADDRESS>:3478 -> Timeout or other error
Response from <IP_ADDRESS>:3478 -> Timeout or other error
Response from <IP_ADDRESS>:3478 -> Timeout or other error
Response from <IP_ADDRESS>:8800 -> Timeout or other error
Response from <IP_ADDRESS>:3478 -> Timeout or other error
Response from <IP_ADDRESS>:3478 -> Timeout or other error
Response from <IP_ADDRESS>:3478 -> Timeout or other error
Response from <IP_ADDRESS>:3478 -> Timeout or other error
Response from <IP_ADDRESS>:3478 -> Timeout or other error

Thanks for this. It's indeed very strange that these hosts don't work for you repeatedly. I'll take a look into this next week

@meeuw Wait, how do you actually check if they are "unavailable"? Do you "ping" them? Because as by my tests, all of those don't respond to "ping" / ICMP requests -> timeout, while they work very well when "treated right":  via https://webrtc.github.io/samples/src/content/peerconnection/trickle-ice/

For example:

Hi @kyr0 ! I'm using the script linked in this issue:
https://gist.github.com/meeuw/d25665c2ab8d68ecee7bd65a71ed365b

@kyr0 What was your setup when you did the check? Did you use a AWS/Azure/GCP VM, or a local machine w/ a consumer ISP?


Brainstorming generic async write support for advanced/wrapper streams #2

This is continuation of https://github.com/micropython/micropython/issues/3396 .
Definition: miniprotocol is a simplified, "single-behavior" protocol. A real world protocol is usually a combination/composition of miniprotocols.
Classification of miniprotocols:

By record delimitation type:
1.1. Length-delimited.
1.2. Separator-delimited.

Example: full WebSocket protocol starts with separator (line) delimited HTTP protocol, then switches to length-delimited protocol.
The idea is that length-delimited protocols are more efficient. But actually better to say that they compose better - we always know how much is left to read for the current miniprotocol, and thus can avoid over-read. The only way to have the same guarantee for separator-delimited miniproto is to read byte by byte, which is known to be not efficient. Thus, the only performance-efficient way to deal with SepProto is to buffer the underlying stream (on our side). But if this buffering happens on miniprotocol parser side, then once we need to switch to another protocol, we may have overread data, and it's a new problem how to pass that data forward to the next miniproto parser. Also, while LenProto is not susceptible to over-read problem, it doesn't mean it doesn't need buffering. For example, there can be many small records, and e.g. read "5 bytes by 5 bytes" isn't much better than SepProto's "1 byte by 1 byte". These 2 issues: a) over-read issue if buffering happens on miniproto parser side; b) need for buffering for performance in general, lead to obvious and well-known solution: buffering should happen on the input stream's side. Well, that still not ideal, if we have efficient, large-block LenProto. Consider for example that some proto start with line-based miniproto, to handle which we allocate 256 bytes buffer, and then switches to LenProto with 1K blocks. Those 256 bytes are then wasted beyond the initial line-based "handshake" phase.

By exchange behavior:
2.1. Single client request leads to protocol transaction in one direction.
2.2. Single client request leads to exchange of records in both directions.

Example: TLS clearly consists of initial handshake phase which requires exchange, but once that is done, single user write leads to single TLS record to send to peer, and single user read is backed by single record received from peer. One way to deal with this scenario is to perform complete handshake based on user request "open connection", so we had one-directional exchanges afterwards. But it's more complex if we postpone handshake until first actual read/write operation from user. And actually, it's more complex on TLS side too: at any time, a negotiation may be requested, which leads to the same issue that a user single operation may lead to the need to postpone it and perform series of exchanges.

Push vs pull handling
3.1. We can "push" any given data into miniproto parser.
3.2. Or we can let it "pull" data, specifying how much exactly it would like to get at the next step.

Push approach has another face of over-read problem: a parser might not accept all data we feed into it, yet produce some output already. This leads to "all hands are full" situation: we need to keep track/store input data which the parser yet not accepted, and need to deal with parser output, which me may not be able to accept in one go on our side either. Pull approach simplifies that somewhat. In reality, suitability push vs pull approach depends on the nature and direction of data passing. For application data -> convert to protocol data, push approach is obvious: the app already have that data (for classically written apps), so we can only push it, hold the remaining part which miniproto didn't consume, and iterate on sending out miniproto output until it's done and we can continue with feeding the rest of app data. On protocol data -> convert to app data, pull approach is beneficial: miniproto parser knows either how much exactly it needs, or otherwise, its internal buffer requirements, and can request data to avoid over-read.

Transformational vs non-transformational
4.1. Transformation miniprotos actually change application data when converting them to protocol records.
4.2. Non-transformational may frame app data, but the data itself is intact.

For example, WebSocket in one direction "masks" the data, but in another direction it's verbatim. Distinction here is of optimization nature: we may use "zero copy" operation, i.e. write user data directly to the underlying stream, instead of copying it to miniproto buffer for additional processing.

Implications so far:

Given push vs pull discussion above, the async "read" path for wrapper streams can reuse the code for sync streams, if that code is written to be able to handle EAGAIN from the underlying stream. That effectively means it should be written as a state machine, handle "number of bytes left to read to move to next state", etc. Well, that's for example how "websocket" module is written, and why it's reused in uasyncio.websocket.server. With "ssl" situation is less bright. Even in app data miniproto, axTLS had a bug which precluded "ssl" to work for async reads. It's now fixed and that works. But there's still handshake miniproto, and axTLS doesn't really have detailed enough state machine for that to work fully in async way.

Implication no. 2, re: Transformational vs non-transformational. So, if that optimization is to taken into account, then attempts to define some general meta-interface to implement some common proto handlers for both sync and async probably won't work. Instead, each one may need to written in more or less adhoc way, which however will allow to optimize it for traits of a particular protocol.

Thoughts re: handling handshake-like miniprotos. It's unclear what's the best to deal with these.
One good way is to be able to have detailed codes like NEED_READ, NEED_WRITE. I.e. if user calls write(), it may get NEED_READ instead, so that write goes to backlog, and user may need to queue a read operation on the underlying stream (data from which will likely be consumed internally by proto). Likewise, if read() is called, NEED_WRITE may be returned instead, notifying that read should be backlogged, and proto handler instead prepared a write record to spool to the underlying stream.
But in the current Python stream API, there're no separate NOT_READY vs NEED_READ vs NEED_WRITE return codes. There's only one - None, which originally means NOT_READY, and would need to be reused for 2 other codes. Then one would need to have additional means to query the more detailed state. For read that could be:
res = wrapper_stream.read()
if res is None:
    # See if wrapper actually asks us to send out something on its behalf
    if wrapper_stream.write_pending:
        ...

Obviously, this approach is less efficient than directly returning needed code from read(), and it's not clear how to apply that to .write() and NEED_READ, except in fully symmetrical way, by adding .read_pending() or a similar predicate.


Pelumi added his name

Update your code by pulling the latest code from upstream
git pull upstream main

git push origin main


Attempt to auto-send PRs to brew

Ideally for any formula that we identify vulnerabilities in we'd:

Bump dependencies (brew update-python-resources)
Verify that this fixes vulnerabilities
Bump revision
Send a PR to homebrew

This would significantly reduce the burdens of keeping the ecosystem secure

Send a PR to homebrew

I think this last step will be the fiddliest/most annoying -- I'm not sure if actions are allowed to create PRs on arbitrary repositories.
The rest should be pretty straightforward, though!

Yes I think that's correct -- it may require adding a secret to the env manually.

Migrated over to the Homebrew org, so this will hopefully be a little easier. I'll take a stab it soon.

We now send them.
We need to have them add/bump revision though.

Yeah, I'll make a separate follow-up for that and the other things we identified.


Goals

** Learn how to issues on GitHub
**GitHub students what other goals should I add here

** Learn how to issues on GitHub
**GitHub students what other goals should I add here

this is done on 15 march 2022


Added setting of the titlebar to the team name and number.

Also bumped up the version number.

Can you make this a toggleable option? I don't think everyone would want this, although it is awfully cool.


Velocity estimation

LiDAR velocity estimation which is redundancy for radar velocity detection
June 13 2024

Can't build due to docker filesystem error

June 27 (skipped a week for midterms

Avi has a preliminary implementation but is still trying to build the lidar node

July 18 2024

Working on basic estimation with markers
Testing still


VSCode plugin: Empty lines within a model definition breaks auto-formatting

I like to separate out scalars and relations in a model definition, but then, the auto-formatter messes up the spacing.
Steps to reproduce:
In a model with two fields, id & name, I'd expect the formatted output to be:
model User {
  id    Int     @id

  name  String
}

But instead, the auto-formatter changes it to:
model User {
  id Int @id

  name String
}

This is intended based on other discussions?

Yes, I also think this is intended behaviour.
But I think we should transfer this issue to vscode-prisma repository.


Add vaultManager property support

Hello,
is it possible to add the support to the vaultManager property of the dropInRequest?
Thanks
\m

Sure, can you send a pull request?
Thanks


Adding empty oauth2client.contrib

Fixes #326, follow-up PRs will be submitted to move flask_util, appengine, and django_orm.

Looks good to me; waiting on test results.

@dhermes' tricky docs thing got me again. It should pass tests now.

Do you see a less tricky way to make sure that contributors that add new code also document their new code?

No, I think it's great. I've just been dumb enough to let me bite me twice now. :)

@nathanielmanistaatgoogle ping - travis is green. :)


Use smithay-client-toolkit's dpi handling.

This depends on https://github.com/smithay/client-toolkit/pull/46

ping @vberger

Done

@vberger should this have a CHANGELOG entry?

should this have a CHANGELOG entry?

It doesn't really change anything from a winit user perspective, it works identically to the current version but is IMO easier to read. The only gain for winit is dpi issues affect all smitahy-client-toolkit users and should be opened or moved to the smithay-client-toolkit repo, so less code to maintain, and for smithay-client-toolkit users the advantage is they have tried and tested dpi handling.


Extractor update

Codecov Report

Merging #7 (7502e1d) into main (7b493be) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##              main        #7   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files           21        21
  Lines          688       688
=========================================
  Hits           688       688

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7b493be...7502e1d. Read the comment docs.


Please invite me to the Recode-Hive GitHub Community Organization

Name
Sudipta Mandal
Discord Username (if applicable)
sudipta186088
Additional Context
No response

Invitation sent to join the GitHub Organisation. Welcome to the community 🎉
Don't forget after accepting to make it public so it appears on your GitHub profile for everyone else to see. You can do this by finding your name in the GitHub organisation list and change the dropdown to public https://github.com/orgs/recodehive/people


App state is lost when changing display density on Android

In Flutter Gallery app navigate to 'Shrine basic shopping app',  add an item to the shopping cart.
go to Android Settings/Display/Advanced/Display size, move the slider selecting new value.
Switch back to Flutter Gallery app, note that you land on Flutter Gallery main page, and when you go to 'Shrine', shopping cart is empty there as well.

Root cause seems to be that Flutter framework doesn't handle density in it's AndroidManifest.xml configuration changes handler, which results in app restart, losing it's state.

The general problem is https://github.com/flutter/flutter/issues/6827.
We should probably set the flag to not restart when this particular change is made though.

For new apps created with flutter create, they will have the correct flag set to not restart.  Existing apps, however, will have to adjust their AndroidManifest.xml to included density and screenLayout.

we should make sure to document that on the changelog and on flutter-dev
and ideally, even handle it automatically. @xster was setting up the infrastructure to do that iirc.

#12573, though I'm not currently working on it

Since we're not currently working on the tool and this has been fixed since march I'm going to close the issue. Making an automatic fix should be a separate bug


Refactoring code from direct runner, and adding unit test for processing time timers.

I went through this code by trying to study the state and timers implementation in the direct runner. I added a bit of documentation, a unit test, and refactored a couple places for clarity.
r: @aaltay

Thoughts for myself:
I realized that currently, it is not possible to create a sequence generator in Python, because there is no way to have access to the watermark (other than using a test stream). (How about watermark holds? - i dont know enough about any of this basically : ))
If we use a sequence generator using a beam.Create transform, the watermark immediately goes to infinity, and the timers are not processed, because the pipeline ends.
Anyway.

I realized that currently, it is not possible to create a sequence generator in Python,
Is not the GenerateRecords you have here is a sequence generator?

I realized that currently, it is not possible to create a sequence generator in Python,
Is not the GenerateRecords you have here is a sequence generator?

I believe this PR broke TestDirectRunner-based tests in Python postcommit tests.
https://issues.apache.org/jira/browse/BEAM-7111


GC not work in Android app, memory leak.

v8Runtime.getGlobalObject().set("StringBuilder", StringBuilder.class);
v8Runtime.getExecutor("function main() {\n" +
"var builder = new StringBuilder();\n" +
"for (var i = 0; i < 1024; i++) builder.append('a');\n" +
"}\n" +
"for(var i = 0;i < 10000; i++){ main();}").executeVoid();

There are 2 things you may work on.

Change var to const.
Expose GC in V8 via V8Flags. Thus, you may explicitly enforce GC in the JS code.

I've tried this:
V8Flags flags = V8Host.getV8Instance().getFlags();
flags.setExposeGC(true);
V8Host.getV8Instance().setFlags();
How to explicitly enforce GC in the JS code ?
Also, I think that it's best to be collected automatically by the engine.

My js executor might long-running within a while loop, and each loop will create some objects which takes too many memories, so I need this engine auto release(auto collect) theses objects I never used.
Somethis like this:
while (true) {
const largeObj = createLargeObjectFromJavaInterop(); //V8ValueObject created by v8Runtime and bind to Interceptor
//some code invoke largeObj
//largeObj will not be used in next loop, and sure not be referenced anymore, so it should be collect by GC automatically.
}

You may increase the V8 heap size via V8Flags.

Also, you may monitor the heap usage with this guide.

I have tried gc() in each loop and it worked.
Thanks.

There are 2 things you may work on.

Change var to const.
Expose GC in V8 via V8Flags. Thus, you may explicitly enforce GC in the JS code.


Enhance Network Policies docs

Please if possible add here: https://kubernetes.io/docs/concepts/services-networking/network-policies/  at this paragraph: "Behavior of to and from selectors" a small working yaml example which shows that also with egress -to (now it's only shown with ingress -from) the - namespaceSelector:  and - podSelector:  specs can be added making simpler for developers and students to quickly pick up an example and use it. Thank you.

Page mentioned in the issue: https://kubernetes.io/docs/concepts/services-networking/network-policies
/language en

/retitle Enhance Network Policies docs
/kind feature
/sig network
/priority backlog
We definitely have higher priorities than this (if we accept it)

/triage accepted

Hi @giuliano-scassaioli, do you mean something like this ?
apiVersion: networking.k8s.io/v1
kind: NetworkPolicy
metadata:
  name: allow-ingress
spec:
  podSelector:
    matchLabels:
      app: my-app
  policyTypes:
    - Ingress
  ingress:
    - from:
        - namespaceSelector:
            matchLabels:
              user: alice
        - podSelector:
            matchLabels:
              role: client


Update Events

Added

Choya Pinata
Chak Gerent

Thanks for moving this over to the dev branch - I appreciate you adding those!  I'll close out #21.