Performance decrease with the latest version

Summary
General performance decreased with the latest version. I am using gopass a lot and that's really annoying :(

Unfortunately I can't say which version introduced the decrease because I did a go get yesterday and before I used the version I initially installed for a long time. I would say that was about 4 to 5 months from now. The previous, fast version didn't had the check marks in the output and the console wizard to chose one of the found passwords didn't had the boxes on top and bottom of the screen if that helps.
Steps To Reproduce
Install latest version from source via go get github.com/gopasspw/gopass. The performance to get a password to the clipboard is too slow. Maybe that just happens if one uses many passwords in different stores with different recipients. I didn't tested that.
Expected behavior
The password should be copied to the clipboard much faster. In the previous version I used there was no remarkable delay.
Environment

OS:

OS version:
  Linux 4.15.0-32-generic #35~16.04.1-Ubuntu SMP Fri Aug 10 21:54:34 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux

gopass Version: gopass 1.8.2-git+HEAD go1.10.3 linux amd64 (now)

Installation method: from source via go get github.com/gopasspw/gopass

Additional context
I am using gopass with several stores. Each with different recipients and with several hundreds of entries overall I guess.

I've read a discussion about Go 1.11 new tracing capabilities and we could add these with a lot of effort to gopass.
https://golang.org/doc/go1.11#trace
https://golang.org/pkg/runtime/trace/#hdr-User_annotation
Maybe that should show some slow parts. With a lot of stores I simply expect IO to be the main time consuming part, but that's just a gut feeling.

That's a very good idea. I'll try to have a look.

This was affecting my workflow greatly so I looked a little into this problem. After profiling I noticed that the program was spending a very large amount of time walking the /proc directory from the github.com/gopasspw/gopass/pkg/clipboard.killPrecedessors() function.
https://github.com/gopasspw/gopass/blob/909c8ac88bb11b15eee7392924c5a497d50d202f/pkg/clipboard/clipboard_others.go#L41-L42
The performance issue goes away when you remove the call to this function.
https://github.com/gopasspw/gopass/blob/909c8ac88bb11b15eee7392924c5a497d50d202f/pkg/clipboard/clipboard_others.go#L27
This function was introduced from this commit: https://github.com/gopasspw/gopass/commit/a3d6a23e1ba8675d859fd181da0c42dc87b1d428
I hope this information helps. Cheers!

@briancheldelin Thanks, that helps a lot. I'll have a look.

I'm also having this problem – would love to see a decreased delay in the future! :)


lcms2: Change name to lcms

LCMS version 1 is not used by any packages and is not packaged, therefore the 2 is unnecessary.
I'm not used to changing package names; my plan is to create pull requests for the packages which depend on lcms2 so Dylan can commit them all at once.

[x] openjpeg2 @IslandAlpha
[ ] cups-filters @Vouivre
[ ] gst-plugins @cemkeylan

You will need to wait for each maintainer to submit pull requests. :+1:

Thanks all. :+1:


[Feature] support qwen2 vl

Checklist

[X] 1. If the issue you raised is not a feature but a question, please raise a discussion at https://github.com/sgl-project/sglang/discussions/new/choose Otherwise, it will be closed.
[X] 2. Please use English, otherwise it will be closed.

Motivation
https://huggingface.co/collections/Qwen/qwen2-vl-66cee7455501d7126940800d
Related resources
No response

cc @JustinLin610

I eagerly look forward to the support for the qwen2-vl series models by sglang as soon as possible. Thanks!

I eagerly look forward to the support for the qwen2-vl series models by sglang as soon as possible. Thanks!

@ispobock's partner is currently working on it.

I would like to know will sglang support qwen2 vl gptq-int4 release with more than one GPU?
https://qwen.readthedocs.io/en/latest/quantization/gptq.html said vllm don't work and need padding and quantizated again.

ref https://github.com/sgl-project/sglang/pull/1546

Hello, does current QWen2-VL in sglang support video input like LLaVA-OneVision? Thanks!


x/website:

What version of Go are you using (go version)?

$ go version

Does this issue reproduce with the latest release?
What operating system and processor architecture are you using (go env)?
go env Output
$ go env

What did you do?

What did you expect to see?
What did you see instead?
I have several users that are getting flagged by our antivirus for the following. Is this a GO update?
Path
c:\program files\go\pkg\tool\windows_amd64\pack.exe
SHA-256
6967a984ccfde4f0ba075ca029050dcbab59f49f41f9d904584fab754deb9aed
MD5	668612d3dd798567a8658d6fa04f1d98
SHA-1	f001af8faf42977b3583e5b188438695032ed1fa

https://golang.org/doc/faq#virus


Added 2019 Toyota Highlander

Tested latest commit on ICE version, and it worked flawlessly out of box.  Fantastic experience despite not using TSS2 yet.

thanks


AndroidTV: Long press not firing event until after released

Description
This project is awesome!
Coming from react-native with mobile devices I've had such a nice time moving over to TV development and I'm so thankful for the work @douglowder and the rest of you guys have been doing.
One bug I've realised is that long press only gets fired after the button have been released. This is not the common behaviour since users expects something to happen while pressing. I haven't been able to test this on an AppleTV project but I'm guessing that's how it's working there.
Version
0.68.2-6
Output of npx react-native info
info Fetching system and libraries information...
System:
OS: macOS 12.5.1
CPU: (10) x64 Apple M1 Max
Memory: 622.58 MB / 32.00 GB
Shell: 5.8.1 - /bin/zsh
Binaries:
Node: 14.18.1 - ~/.nvm/versions/node/v14.18.1/bin/node
Yarn: 1.22.19 - ~/.nvm/versions/node/v14.18.1/bin/yarn
npm: 6.14.15 - ~/.nvm/versions/node/v14.18.1/bin/npm
Watchman: 2<IP_ADDRESS> - /opt/homebrew/bin/watchman
Managers:
CocoaPods: 1.11.3 - /opt/homebrew/bin/pod
SDKs:
iOS SDK:
Platforms: DriverKit 21.4, iOS 16.0, macOS 12.3, tvOS 16.0, watchOS 9.0
Android SDK:
API Levels: 29, 30, 31, 32
Build Tools: 29.0.2, 30.0.2, 30.0.3, 31.0.0, 33.0.0
System Images: android-23 | Android TV ARM EABI v7a, android-30 | Android TV Intel x86 Atom, android-30 | Google TV Intel x86 Atom, android-30 | Google Play ARM 64 v8a, android-31 | Android TV ARM 64 v8a, android-31 | Google TV ARM 64 v8a, android-31 | Google APIs ARM 64 v8a, android-31 | Google Play ARM 64 v8a, android-33 | Google Play ARM 64 v8a
Android NDK: Not Found
IDEs:
Android Studio: 2021.3 AI-213.7172.25.2113.9014738
Xcode: 14.0/14A309 - /usr/bin/xcodebuild
Languages:
Java: 11.0.16 - /usr/bin/javac
npmPackages:
@react-native-community/cli: Not Found
react: 17.0.2 => 17.0.2
react-native: Not Found
react-native-macos: Not Found
react-native-tvos:  0.68.2-6
npmGlobalPackages:
react-native: Not Found
info React Native v0.70.1 is now available (your project is running on v0.68.2-6).
info Changelog: https://github.com/facebook/react-native/releases/tag/v0.70.1.
info Diff: https://react-native-community.github.io/upgrade-helper/?from=0.68.2-6.
info To upgrade, run "react-native upgrade".
Steps to reproduce
Listen to a longSelect event like so:
  const myTVEventHandler = evt => {
    console.log(evt.eventType);

    if (evt && evt.eventType === 'select') {
      handleSelect(selectedChannel);
    } else if (evt && evt.eventType === 'longSelect') {
      console.log('Long press');
    }
  };

  useTVEventHandler(myTVEventHandler);

Notice that the log only shows up after you released the button.
Snack, code example, screenshot, or link to a repository
No response

Confirmed, the Android TV behavior is as described, and is different from Apple TV. I'll take a look.

This reproduces on 0.69.5-1. Also, we need to make sure that the fix for #349 does not regress

Facing the same issue. I need to implement bi-directional scrollview and bring the current row/column in front focus.  I am trying to implement scroll actions on my custom scrollview (as paging was not supported for vertical scrollview/flatlist) on directional events. But that only works for single event, since cannot detect if user is long pressing the directional control (so that my scrollview scrolls multiple rows/columns while user is long pressing).

This reproduces on 0.69.5-1. Also, we need to make sure that the fix for #349 does not regress

Still present on 0.69.6-2 even with this PR: https://github.com/react-native-tvos/react-native-tvos/pull/396

Probably we need a fix like this on this file
// Simple implementation of long press detection
if ((eventKeyAction == KeyEvent.ACTION_DOWN)
    && isSelectOrDPadEvent && mLastKeyDownTime == 0) {
    // dispatch long press event when it began
    dispatchEvent(KEY_EVENTS_LONG_PRESS_ACTIONS.get(eventKeyCode), mLastFocusedViewId, eventKeyAction, context);
    mLastKeyDownTime = time;
}

@janvandertaelen

i believe there is another issue where longSelect gets triggered even when I do a normal press. I dont have to necessarily wait for one second for longSelect to trigger. is there an existing issue for this? I am using version 0.68.2

@sharan-SKY you should upgrade to the latest (0.73.2-0)


Extended SemVer v2 compliance and reliability improvements

updated Dependencies parser to accept semver2 twiddle-wakka constraints -- versions like 1.2.3-beta.4 ended up with invalid upper constraint (>= 1.2.3-beta.4 < 1.2.3-beta.0 (beta))
changed version comparison to be more obvious and to follow semver2 rules more closely
changed extended SemVer Build to bigint, as string builds resulted in "unique" versions, not properly resolvable or comparable to anything else
extended SemVer parser to accept well-formed semver2 strings without misinterpreting embedded numbers in alphanumeric segments -- which is now special-cased for for semver1 support
updated SemVer parser to interpret malformed versions as close as possible to correct ones -- until now, they were accepted as-is without warnings or errors, but could not be properly compared, e.g. version like 1.2.3.beta.4 was accepted on all paths, but considered neither prerelease, nor part of 1.2.3 range
changed transitive prerelease versions of prerelease packages to use Concrete name where possible -- with "diamond dependencies" in graph, having transitive dependencies on All caused resolver loops, and broke the expectation of using only the named prerelease, unless prerelease was specified explicitly
added more prerelease and its transitivity information to conflict report
added tests and new cases to cover previously undefined edge cases

This looks very good!
Just some words of warning: This is a delicate part of Paket with high potential of breaking stuff (especially since there are a lot of packages out there which are not actually semver compatible) .
Therefore I suggest that this at least needs a green CI (Just to explain: We have a long history of broken CI and ignoring them for PRs on some occasions, if the failures look unrelated :) )
Also feel free to send the same PR to FAKE as we have a Fake.Core.SemVer package with basically the same logic, and it would be nice to have the proper author on the history :)
If I find the time before this thing is merged I might review this more in-depth, thanks for sending this.

Thank you! And I definitely agree this needs a thorough review & passing CI :)
I'm aware of the risks, as this was created to resolve our very real production issues, and mainly to bridge the gap between semver2 and non-semver cases, supporting more of both.

I didn't yet find time to look at this, but for quite some time I wanted to to have an integration test which checks ALL packages on nuget and verify we can understand the version no.
I know it's a big thing to ask, but tbh it would increase my confidence into this change dramatically if you could try to come up with such a test.

Actually that's a quite good idea, it may just take few more hours to implement :)
I'll do that separately, to see the tests' results before the changes, and merge into this branch/PR later.

Really really cool.

Should we merge and release as prerelease for couple of days?

@forki can you elaborate what you meant with the “ALL packages“ test and how it would work. I don’t think we can download all versions from nuget within a single test run. But we can generate a list of test-cases (but it will be way too long to review and the F# compiler will probably choke as well).
Or I just don’t get the idea...

We can maybe filter out “uninteresting” versions via regex.

As far as I understood and agreed on the "all of nuget" test idea, it should be possible to use the NuGetv3 Catalog to get all versions of all packages.
If they were in gallery order (need to confirm this), I could check our parsing & comparison is able to 1/ read all versions, 2/ return the latest release, and 3/ return the latest prerelease.
It will take me few days to do this in F# by myself; Do we perchance already have some helper in Paket or FAKE for catalog access?

Yes my naive idea was to scrape all package versions of all packages.
Am 10.02.2018 10:57 schrieb "Viktor Svub"<EMAIL_ADDRESS>
As far as I understood and agreed on the "all of nuget" test idea, it
should be possible to use the NuGetv3 Catalog
https://docs.microsoft.com/en-us/nuget/api/catalog-resource to get all
versions of all packages.
If they were in gallery order (need to confirm this), I could check our
parsing & comparison is able to 1/ read all versions, 2/ return the latest
release, and 3/ return the latest prerelease.
It will take me few days to do this in F# by myself; Do we perchance
already have some helper in Paket or FAKE for catalog access?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/fsprojects/Paket/pull/3030#issuecomment-364640169,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AADgNC6-NlcU5YBymOvpFiXoiyP73Sudks5tTWf9gaJpZM4R8_TR
.

Yes the only thing we need to watch out for is that afaik NuGet will respond with different results depending on the client and the feed :)

@viktor-svub could you please take a look at https://github.com/fsprojects/Paket/issues/3032#issuecomment-364398018 I think we interpret that range wrongly. I fixed the issue with lowest_matching but the problem around twiddle-Waka is still open

One more note on this:

A pre-release version MAY be denoted by appending a hyphen and a series of dot separated identifiers immediately following the patch version. Identifiers MUST comprise only ASCII alphanumerics and hyphen [0-9A-Za-z-]. Identifiers MUST NOT be empty. Numeric identifiers MUST NOT include leading zeroes. Pre-release versions have a lower precedence than the associated normal version. A pre-release version indicates that the version is unstable and might not satisfy the intended compatibility requirements as denoted by its associated normal version. Examples: 1.0.0-alpha, 1.0.0-alpha.1, 1.0.0-0.3.7, 1.0.0-x.7.z.92.

This means in fact that
> parseAndPrint "1.0.01-pre-001";;
val it : string =
  "{ Major: 1, Minor: 0, Patch: 1, Prerelease: Some {Origin = "pre-001";
      Name = "pre";
      Values = [AlphaNumeric "pre"; Numeric 1];}, Build: 0, BuildMetadata: , Original: Some "1.0.01-pre-001" }"

Is not the correct result. Apparently items are only split by . and therefore we have AlphaNumeric "pre-001" (or AlphaNumeric "pre"; AlphaNumeric "001").
Leading zeroes in numerical prerelease identifiers like 1.0.0-alpha.01 are not allowed, but I'm not too concerned if we allowed that.
Maybe we could have a property on the "SemVerInfo` indicating whether the given version is fully semver compliant.
@viktor-svub What is your opinion on this?

@forki

... could you please take a look at #3032 (comment)
I'll play with this a bit more then -- we are creating constraints like this in automated scripts, it happens when you have a 4-segment package version like Package-<IP_ADDRESS> and want to have semver-compliant constraint without allowing history versions: Package ~> 1.2 >= LOCKEDVERSION.
We should adjust the lower bound accordingly, and/or throw, if the second constraint part violates the first (twiddle) one.

@matthid I agree we should be SemVer2 compliant where feasible & useful, but the scheme pretty much ignores history -- packages like xunit.core 2.3.0-beta3-build3705 are and will be in use for long time, and should be resolved in expected order.
I'd like Paket to be actively helpful if a package switches to the currently proper scheme -- semver2 today, but even NuGet.org does not enforce semver (they even extend it), and we can safely assume there will be another scheme in foreseeable future (semver3? nuget4?) :)
In these cases the ordering should as close to what was intended -> xunit.core 2.3.0-beta3-build3705 may be followed by xunit.core 2.3.0-beta.4.build.4567 and they should compare to each other.
My take in this case is assuming a version without dots in prerelease can be interpreted as semver1-like, where dots were not allowed and hyphens were used to separate "segments", though formally there was only a single one.
We could keep & extend the existing heuristic to facilitate for existing versions, support new ones, and maybe allowing users to use hints in paket.dependencies to ensure the version is interpreted strictly.

@viktor-svub One important point to consider is that we don't want a different behavior than NuGet itself. afaik they will use a semver compliant ordering when using a recent client and V3.
While I agree with your reasoning I'm not sure if will matter that much in practice. For example consider your example xunit.core 2.3.0-beta3-build3705 and xunit.core 2.3.0-beta.4.build.4567. In the current implementation you propose it is 2.3.0-beta3-build3705 > xunit.core 2.3.0-beta.4.build.4567 already. And if you meant xunit.core 2.3.0-beta4.build.4567 (note the missing dot) than it doesn't matter how we handle - or . the one or the other way as the result will be the same. So I'd argue that the change I propose will not change a lot in practice.

I'd even go further than that: Let's assume xunit-core reaches the place where their build number has 5 digits and therefore my change would introduce a subtle difference. I think that package will not be recognized as newer by NuGet and they will immediately re-release with a higher previous segment.

@matthid You are right I should not try to workaround everything :)
I'm just really concerned about backwards compatibility -- AFAIK majority of NuGet packages still use semver1-like versions but with embedded zero-padded numbers to work around the lack of better solution at that time -- in may cases, they cannot be simply upgraded or replaced, and they should be interpreted as intended at the time of their creation.
As for semver2 compliance -- I'd assume any version actually using the new possibility of multiple dot-separated segments is created with knowledge of the semantics and should not be re-interpreted.
But we can harden/soften the rules as needed, and we should keep a foot in the door for next semver :)

in may cases, they cannot be simply upgraded or replaced, and they should be interpreted as intended at the time of their creation.

Yes, in fact I think doing the SemVer-compliant thing is actually the correct thing. Afaik NuGet always recognized the prerelease stuff as simple string (which was surprising and therefore the workarounds with zero padding). Applying SemVer compliance (ie only splitting by .) does exactly this: Parses this thing as raw string without any interpretation.

Having a "semverX" non/compliance hint & property on SemVerInfo could be better solution than heuristic, and better than accidentally breaking current use cases -- Paket's selling points are its differences  from NuGet -- specifically its ability to interpret embedded numbers and named prereleases -- I'd believe :)

Paket's selling points are its differences from NuGet -- specifically its ability to interpret embedded numbers and named prereleases -- I'd believe :)

Afaik we never said we would handle version parsing or comparisons differently than NuGet - at least I never heard of it ;)
Personally I'd consider this a bug :)
Just to be sure /cc @forki :)

@matthid I never thought of it that way :D Considering the heuristic parsing was even covered by tests, it might have been a bug-became-feature, but already in wide use for long time (we surely do) :)

Wow good job!

It cannot be submitted -- even with paged Catalog, full sweep takes more than an hour :/
With per-page cached responses, the whole test finishes in about 40 seconds,
but the per-page gzipped cache itself is more than 70MB -- a little too much.
I'm working on cached data reduction, what would you consider an acceptable size?

Good question, I think we at least would accept the code even if it takes a while to execute we could execute it from time to time if needed.
If we in-fact want to integrate it into the CI we could reduce the data a lot by removing all "common" cases and keeping the unusual ones.
At least for the ones where the old parser failed we should add a test into the CI (probably makes sense).
By the way it would be also interesting to see where the previous and the new parser changed ordering... But I think you have done enough to get this merged already. The only thing left is about the handling of - in the prerelease section.

It's now red!?

Working on the CI failure -- cached catalog size was reduced to "only" 18MB, and the merged branches pass on my machine in 30 seconds -- the CI server or jobs seem to behave differently.

looks like master build is broken as well. Something weird happen https://github.com/fsprojects/Paket/pull/3038 is canary and red

https://help.appveyor.com/discussions/problems/10253-maximum-allowed-artifact-storage-size-of-1000-mb-will-be-exceeded

As for the SemVer2 compliance, I believe we should support NuGet behavior described at
https://docs.microsoft.com/en-us/nuget/reference/package-versioning#semantic-versioning-200
where they use similar heuristics to allow semver1 and non-semver packages as fallback for non-compliant version strings, and we may want to double-check our wildcard handling.
We should also probably check discussion and issues described in https://github.com/NuGet/Home/issues/912 as Paket's approach was mentioned as viable solution over there :)

I'm still talking about the handling of - in prerelease strings as opposed to .. I still feel like we should treat them the semver way. I'm yet to hear a reason against that. The link https://docs.microsoft.com/en-us/nuget/reference/package-versioning#pre-release-versions just shows that they do exactly what I'm proposing:

When resolving package references and multiple package versions differ only by suffix, NuGet chooses a version without a suffix first, then applies precedence to pre-release versions in reverse alphabetical order.

I think the issue you link is orthogonal as we still can support a minimum prefix of the semver prerelease string in the dependencies file no matter they way we use to parse the versions?
Or maybe I just don't get what you are trying to tell me, sorry :)
If you say for example the current implementation is easier that's a fine reason to leave it as is (as I think the impact is minimal either way)

Ah, now I understand, and you are right :) Indeed, I got over-zealous changed the semver1 parser -- maybe while solving a real-world case, but a change nevertheless -- I'll try to keep that closer to original.

My problem is that people regularly complain here in issue tracker when
they see warnings. And this one would be very weird, since it's not very
specific and there is nothing what they can do about it.
Am 12.02.2018 19:24 schrieb "Viktor Svub"<EMAIL_ADDRESS>
@viktor-svub commented on this pull request.
In src/Paket.Core/Dependencies/NuGetV3.fs
https://github.com/fsprojects/Paket/pull/3030#discussion_r167643764:

@@ -277,7 +282,8 @@ let private getCatalogPageDirectory(basePath:String,item:String) =
| _ -> Uri.EscapeDataString(item)
let cachePath = Path.Combine(basePath,hostPath)
let directory = new DirectoryInfo(cachePath)

if directory.Exists |> not then

if directory.Exists |> not then

   traceWarnfn "Create \"%s\"" directory.FullName

it's not, as the page cache for the only code using this -- the public
catalog integration test --
should be committed (it is now) and the warning will trigger only if
called without the path existing
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/fsprojects/Paket/pull/3030#discussion_r167643764, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AADgNPLvrLxub_-DC24vr8AoBi8aZ7MFks5tUIHHgaJpZM4R8_TR
.

Oh, I see -- I can change that to detailed warning about re/building catalog cache from scratch and expecting very long operation/delay, would that be ok?

Mhm. I'm not sure what we are changing here. Can you please explain again
what is happening? I think I'm not fully understanding yet
Am 12.02.2018 19:34 schrieb "Viktor Svub"<EMAIL_ADDRESS>
Oh, I see -- I can change that to detailed warning about re/building
catalog cache from scratch and expecting very long operation/delay, would
that be ok?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/fsprojects/Paket/pull/3030#issuecomment-365018082,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AADgNNgpU8ZOVQ9wMYhIyHsWUplB4U3jks5tUIQagaJpZM4R8_TR
.

Catalog support was created just for the "all of nuget" integration test, but placed alongside the other
NuGet V3 "services" implementations -- this function is new and not used anywhere else.
Cursor-based implementation like https://docs.microsoft.com/en-us/nuget/api/catalog-resource#iterating-over-catalog-items would be only reliable and efficient if I used a compact and append-only representation on client side -- so I went for a more resilient and tolerant per-page cache.
Creating the page cache takes still more than an hour though, which is where the warning is appropriate -- missing directory means the cache will be created from scratch.
It seems this may not be a viable approach in the end -- while locally subsequent test runs take about half a minute, the CI servers do not exactly like it.

Ok, the test overhead outgrew its potential usefulness, I'm removing it from this PR.
I will try to come up with lightweight version, in another brach, as mixing the changes got messy.

AppVeyor RunIntegrationTestsNetCore failed with
`

System.Exception: Test failed on "test" "integrationtests/Paket.IntegrationTests.preview3/Paket.IntegrationTests.fsproj" ...
Command exited with code 42
`
https://ci.appveyor.com/project/paket/paket/build/<IP_ADDRESS>/job/bp3w37f1hb14rp6x#L2812

No specific test failed, and on local machine, the whole build seems to pass.

yes have that locally as well. wonder what changed!? /cc @enricosada @matthid

So far it seems that failed or successful test runs differ in the machines' performance -- the latest failed run has startup time -- and almost any subsequent measured operation -- 2-3 times longer than the successful ones, end ends with job timeout :/

@enricosada ideas?

@forki you were completely right about the public catalog verification :-) there was a regression and the latest commits (semver2 allows hyphens...) are the fix with new unit-tests
As for the verification -- this branch was merged into PR #3048 which passed:
https://github.com/fsprojects/Paket/pull/3048/commits/20df660a3313a698c7ff03dc8bd04ea666f55c68 shows the intentional changes (lines ending with !0.0.0 were not parse-able and interpreted as zero in the original requirement parser)
Do we still need to wait for the same verification to pass here?

I'm fine with merging if @matthid and you are saying it's "probably good" ;-)

As there is no further activity planned here at the moment,
unless you have any objections, feel free to merge anytime :)

Yes it probably is fine, thanks @viktor-svub for going all the way with us :)

^^ in the latest builds

Seems like conflict with #3040 -- I should have probably rebased/merged it immediately after this was merged. Line 6778 is especially suspicious, as it does not look like a parser issue but rather an ordering one (which I did not encounter before) or the catalog being updated accidentally during the test.
Note that updating is done through an TestCase("...",Explicit=true) "test" and if the attribute was ignored in the CI build runner, it would create quite interesting results.

any advice how to fix?

After looking a bit, it rather looks like the error expected to appear before #3030.
It's a merge/rebase issue most likely, or I might gave accidentally pushed older version of the catalog, i.e. not adapted by the #3030 -- as the catalog is saved in the "current" ordering, to detect any change i parser/order without keeping their older versions around :)

Currently it can be fixed semi-manually as the updating "test" #3030-9 update nuget catalog from public index does too much -- re-ordered version of current catalog without update from gallery needs only getCatalogCursor to setCatalogCursor -- there will be only changed line, no added, and the flat-text file can be diffed and reviewed manually to see if the ordering was broken or rather fixed.

Note that when the Expected line contained an exclamation mark and the But was did not, it's likely a fix rather error, as ! delimits the original version string and its normalized form if they differ, and non-parsed versions were interpreted as 0.0.0 in constraints -- that's what I see in the picture.

ok. please please send a PR ;-)
thank you!

I can push updated catalog after I get to my devbox, as there was already supposed to be one -- not sure how the old ordering ended up in the updated PR :)

here #3056 is the catalog update to correct ordering :)


purge-docker: fix ceph-osd-zap name container

purge-docker: fix ceph-osd-zap name container
the zap ceph osd disks task should iter on resolved_parent_device
instead of combined_devices_list which contain only the base device
name (vs. full path name in combined_devices_list).
this fixes the issue where docker complain about container name because
of illegal characters such as / :
"/usr/bin/docker-current: Error response from daemon: Invalid container
name (ceph-osd-zap-magna074-/dev/sdb1), only [a-zA-Z0-9][a-zA-Z0-9_.-]
are allowed.","See '/usr/bin/docker-current run --help'."
""

having the the basename of the device path is enough for the container
name.
Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1540137
Signed-off-by: Guillaume Abrioux<EMAIL_ADDRESS>

jenkins test  luminous-ansible2.4-purge_bluestore_osds_container


vapor_master: 0.1.0-0 in 'melodic/distribution.yaml' [bloom]

Increasing version of package(s) in repository vapor_master to 0.1.0-0:

upstream repository: https://github.com/roshub/vapor_master.git
release repository: https://github.com/roshub/vapor_master-release.git
distro file: melodic/distribution.yaml
bloom version: 0.6.9
previous version of package: null

vapor_master
* initial release

Including the header would be good though I know that js is often optimized to avoid content like that. But since the project license is clearly and consistently indicated at the top level it's good for us to merge.

The stretch builds are fialing due to npm not being in stretch: See #19845


[AfO] Network analytics references

Provide references to Azure for Operators network analytics solution accelerator.
CC: @rathishrms

fantastic, thank you @victorar !


Linking to the subsection doesn't seem to work

Describe the Bug
On the page https://github.com/JavaWebStack/Passport/wiki/OAuth-Services-Custom-Responses the subsections are not linked as intended it seems
To Reproduce
Have eyes or an appropriate screen reader which reads out links and run it.
Expected behavior
It links.
Screenshots / Logs
None
Environment Information:

Github [at the state of today]

Additional Context
None

Fixed


ART-2592 Attach RPM CVE tracker bugs to RPM advisory

Summary

https://issues.redhat.com/browse/ART-2592
This is a change to elliott find-bugs sweep functionality (see the full command below), to detect and attach rpm cve tracker bugs and attach those to rpm advisory
The bugs are validated against brew builds attached to advisory. If builds are not found then bugs are not attached, so the ideal sweep workflow needed for this change would be sweep builds and then sweep bugs.

Status

[X] Code changes
[ ] Some basic unit testing
[ ] Prepare_release job changes to run sweep builds and then sweep bugs

Testing:
./elliott -g openshift-4.6 find-bugs --mode sweep --cve-trackers --into-default-advisories --dry-run

Codecov Report

Merging #176 (bb349e5) into master (82130a8) will decrease coverage by 0.12%.
The diff coverage is 2.77%.

@@            Coverage Diff             @@
##           master     #176      +/-   ##
==========================================
- Coverage   22.44%   22.31%   -0.13%
==========================================
  Files          44       44
  Lines        3609     3634      +25
  Branches      706      714       +8
==========================================
+ Hits          810      811       +1
- Misses       2774     2798      +24
  Partials       25       25

Impacted Files
Coverage Δ

elliottlib/brew.py
60.73% <0.00%> (+1.09%)
:arrow_up:

elliottlib/cli/find_bugs_cli.py
0.00% <0.00%> (ø)

elliottlib/bzutil.py
47.22% <7.69%> (-2.29%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 82130a8...bb349e5. Read the comment docs.


Could you please release COCO pretrained model?

Hello, thx for your great work! I'm trying to use this repo in my project, but it is hard to converge and cost much more time.Could you plz release coco pretrained model. Thx a lot ❤!

I'm sorry that I cannot upload model due to company regulation.
But you can send me an email<EMAIL_ADDRESS> : )
which model do you want?  resnet18 or resnet50?  w/wo dcn? Show me the details in your email.


Fixed : Color of Hyperlinks in dark mode

Signed-off-by: chinmaym07<EMAIL_ADDRESS>Hey, I just made a Pull Request!
Fixes Issue #4615

:heavy_check_mark: Checklist

[ ] A changeset describing the change and affected packages. (more info)
[ ] Added or updated documentation
[ ] Tests for new functionality and regression tests for bug fixes
[x] Screenshots attached (for UI changes)

Tugboat has finished building the preview for this pull request!
Link:

https://pr4849-zul1dhgtd1nddfcx8tomr6x8cirnixnf.tugboat.qa

Dashboard:

https://dashboard.tugboat.qa/60434666f285af7a08a24900

Related to https://github.com/backstage/backstage/pull/4747

Thanks for this work, but I think it's a duplicate of what we have going on in #4747. I think we should continue the work over there, so will close this PR. Apologies!

No problem @benjdlambert sir .. Thanks for the info 👍🏻  😀


Windows Python Client Possibility

Stupid question really, but what if I really really really wanted to run the image_client example ,preferably using the gRPC protocol, from a windows python interpreter? Is there a very obvious way to do this that I am overlooking? I have tried the straight forward path of trying to install the server api to the windows interpreter using the .whl file made using the docker examples, but of course that doesn't work.
Apologies if this shouldn't be an issue and there is a better place to post this. I did try the Nvidia NGC forums for TensorRT and found this post: https://devtalk.nvidia.com/default/topic/1039319/tensorrt/tensorrt-inference-server-windows-support/post/5280697/#5280697, but I couldn't find a reference to anything on the repo about Windows support. Any thoughts?

The reason that you can't use the python wheel on windows is that it is not pure python. I contains a shared library that is build for linux. Ideally the python client would be written only in python but for reasons of expediency it is built on top of the C++ client implementation (which is the shared library). The client build is a makefile... and on master soon we will have a cmake version of the build, so that may be easier to port to Windows. Alternatively you could use grpc_image_client.py which is a version of image-client that uses the "standard" grpc generate API instead of our python library. You should be able to generate the grpc python implementation on Windows and then use it with grpc_image_client.py. See https://github.com/NVIDIA/tensorrt-inference-server/blob/master/Makefile.client#L222 for how to generate the API from the protobuf files.

Thanks for the quick reply. I have done something similar to your last
suggestion in the past, but I was not pleased with the performance. This
performance issue could be my problem though. I'll review your link for
more info about making the client. I appreciate you taking the time explain
the future direction with the cmake file, and I'll keep an eye out. This
issue is officially closed for me.
On Wed, May 8, 2019 at 4:47 PM deadeyegoodwin<EMAIL_ADDRESS>wrote:

The reason that you can't use the python wheel on windows is that it is
not pure python. I contains a shared library that is build for linux.
Ideally the python client would be written only in python but for reasons
of expediency it is built on top of the C++ client implementation (which is
the shared library). The client build is a makefile... and on master soon
we will have a cmake version of the build, so that may be easier to port to
Windows. Alternatively you could use grpc_image_client.py which is a
version of image-client that uses the "standard" grpc generate API instead
of our python library. You should be able to generate the grpc python
implementation on Windows and then use it with grpc_image_client.py. See
https://github.com/NVIDIA/tensorrt-inference-server/blob/master/Makefile.client#L222
for how to generate the API from the protobuf files.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/NVIDIA/tensorrt-inference-server/issues/278#issuecomment-490691369,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AFSEXYI5MX3RLX2AMBTC5XDPUNQ7NANCNFSM4HLVNBYQ
.

--
Padraic McGraw
Software Developer
Lucidyne Technoligies Inc.

FYI, we've ported the client library to Windows. https://github.com/NVIDIA/tensorrt-inference-server/blob/master/docs/client.rst#windows-10

Woah! Cool! Thanks for the heads up!
On Mon, Jul 1, 2019 at 3:29 PM deadeyegoodwin<EMAIL_ADDRESS>wrote:

FYI, we've ported the client library to Windows.
https://github.com/NVIDIA/tensorrt-inference-server/blob/master/docs/client.rst#windows-10
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
https://github.com/NVIDIA/tensorrt-inference-server/issues/278?email_source=notifications&email_token=AFSEXYIHR535FMUQ4T5OBW3P5KALRA5CNFSM4HLVNBY2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODY7QZCA#issuecomment-507448456,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AFSEXYJODKUMDMT6GVK5ZNDP5KALRANCNFSM4HLVNBYQ
.

--
Padraic McGraw
Software Developer
Lucidyne Technoligies Inc.

For got to mention that it is only on master right now. Will be in 19.07 release.

@deadeyegoodwin It's great that the client library is ported to Windows.
I read this: "At this time the Windows build does not include the C++ examples."
Is there any plan to have C++ examples that work on Windows?

Some of the simple examples will likely build as is. The image_client example doesn't because it depends on OpenCV... perhaps the build process just needs to be tweaked for that as well. It would be a great contribution to have a PR that enabled the examples on windows.


Reverts #140 and #141

This PR reverts #140, #141, as we have new fact check changes that prevent us from merging them.

@pmanrubia LGTM 👍


info_card content text size

Hi @TangleSpace
How do you change the font size of the content of a card?
e.g. here making

making the 395,495 larger

I have the same question...

version 1.0.10 added 3 new parameters to the infocard component to adjust the title text size, the content text size and the icon size.
title_text_size
content_text_size
icon_size
can use any HTML valid sizing, for example "2.5rem", "80%","150px" etc.


chore: Add version suffixes to Java & .NET artifacts

Label all Java artifacts with .DEVPREVIEW, and all .NET artifacts
with -devpreview.
Fixes: awslabs/cdk-ops#373

Please read the contribution guidelines and follow the pull-request checklist.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@RomainMuller this is ready for merge


look up OTT names for all OTT IDs

We are lacking OTT names for OTT IDs that come from taxonomy traversal (rather than from nexsons). This leaves us with tens of thousands of rows in the OTU table with name='tbd'. Here is relevant code in create_otu_table.

There is a peyotl method for this already. See https://github.com/OpenTreeOfLife/peyotl/issues/141

Fixed with this commit


:sparkles: implement User Management API, caching, and DI container

feat: :sparkles: implement User Management API, caching, and DI container for dependency resolution

Welcome to Codecov :tada:
Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests.
Thanks for integrating Codecov - We've got you covered :open_umbrella:


Write a Wiki Article on "Custom Launchers / Host Applications"

Summary
As part of the push for better documentation, write an article on how to implement a custom launcher or host application.
Analysis

What a launcher does.
A minimal launcher implementation.
A WinForms / GLControl host application.

Moved to the docs repo.


GoogleScholarAPIWrapper issue when initializing, pydantic_core._pydantic_core.ValidationError

Checked other resources

[X] I added a very descriptive title to this issue.
[X] I searched the LangChain documentation with the integrated search.
[X] I used the GitHub search to find a similar question and didn't find it.
[X] I am sure that this is a bug in LangChain rather than my code.
[X] The bug is not resolved by updating to the latest stable version of LangChain (or the specific integration package).

Example Code
import os
from langchain_community.tools.google_scholar import GoogleScholarQueryRun
from langchain_community.utilities.google_scholar import GoogleScholarAPIWrapper
os.environ["SERP_API_KEY"] = "my-key"
new_scholar = GoogleScholarAPIWrapper()
tool = GoogleScholarQueryRun(api_wrapper=new_scholar)
result = tool.run("LLM Models")
print(result)
Error Message and Stack Trace (if applicable)
Traceback (most recent call last):
File "googlescholar.py", line 9, in
new_scholar = GoogleScholarAPIWrapper()
File ".venv/lib/python3.13/site-packages/pydantic/main.py", line 212, in init
validated_self = self.pydantic_validator.validate_python(data, self_instance=self)
pydantic_core._pydantic_core.ValidationError: 2 validation errors for GoogleScholarAPIWrapper
SERP_API_KEY
Extra inputs are not permitted [type=extra_forbidden, input_value='2d2dd691e41cc3135c34c8ea...e40d9edf183c92213960ef2', input_type=str]
For further information visit https://errors.pydantic.dev/2.9/v/extra_forbidden
google_scholar_engine
Extra inputs are not permitted [type=extra_forbidden, input_value=<class 'serpapi.google_sc...ch.GoogleScholarSearch'>, input_type=type]
For further information visit https://errors.pydantic.dev/2.9/v/extra_forbidden
Description
I am trying to use the Google Scholar API Wrapper for testing.
I am following these links:
https://python.langchain.com/docs/integrations/tools/google_scholar/
https://api.python.langchain.com/en/latest/utilities/langchain_community.utilities.google_scholar.GoogleScholarAPIWrapper.html
I am stuck initializing it as it says "extra inputs are not permitted". I don't want to use my own class as I will be using this in a jupter notebook for testing and learning.
System Info
aiohappyeyeballs==2.4.3
aiohttp==3.10.10
aiosignal==1.3.1
annotated-types==0.7.0
anyio==4.6.2.post1
attrs==24.2.0
cachetools==5.5.0
certifi==2024.8.30
charset-normalizer==3.4.0
dataclasses-json==0.6.7
docstring_parser==0.16
frozenlist==1.4.1
google-api-core==2.21.0
google-auth==2.35.0
google-cloud-aiplatform==1.70.0
google-cloud-bigquery==3.26.0
google-cloud-core==2.4.1
google-cloud-resource-manager==1.12.5
google-cloud-storage==2.18.2
google-crc32c==1.6.0
google-resumable-media==2.7.2
google_search_results==2.4.2
googleapis-common-protos==1.65.0
grpc-google-iam-v1==0.13.1
grpcio==1.67.0
grpcio-status==1.67.0
h11==0.14.0
httpcore==1.0.6
httpx==0.27.2
httpx-sse==0.4.0
idna==3.10
jsonpatch==1.33
jsonpointer==3.0.0
langchain==0.3.4
langchain-community==0.3.3
langchain-core==0.3.12
langchain-google-vertexai==2.0.5
langchain-text-splitters==0.3.0
langsmith==0.1.136
marshmallow==3.23.0
multidict==6.1.0
mypy-extensions==1.0.0
numpy==1.26.4
orjson==3.10.10
packaging==24.1
propcache==0.2.0
proto-plus==1.24.0
protobuf==5.28.2
pyasn1==0.6.1
pyasn1_modules==0.4.1
pydantic==2.9.2
pydantic-settings==2.6.0
pydantic_core==2.23.4
python-dateutil==2.9.0.post0
python-dotenv==1.0.1
PyYAML==6.0.2
requests==2.32.3
requests-toolbelt==1.0.0
rsa==4.9
shapely==2.0.6
six==1.16.0
sniffio==1.3.1
SQLAlchemy==2.0.36
tenacity==9.0.0
typing-inspect==0.9.0
typing_extensions==4.12.2
urllib3==2.2.3
yarl==1.16.0

Hello, I've tested your code and confirmed that this is a problem. I'm a member of a team at University of Toronto and we're going to take a look at this issue and hopefully have a working pull request soon.


Uncaught RateLimitError in utils.py line 7495

Aider version: 0.54.8
Python version: 3.9.13
Platform: Windows-10-10.0.19045-SP1
Python implementation: CPython
Virtual environment: No
OS: Windows 10 (64bit)
Git version: git version 2.39.0.windows.2
An uncaught exception occurred:
Traceback (most recent call last):
  File "vertex_httpx.py", line 1481, in completion
    response.raise_for_status()
  File "_models.py", line 763, in raise_for_status
    raise HTTPStatusError(message, request=request, response=self)
httpx.HTTPStatusError: Client error '429 Too Many Requests' for url 'https://generativelanguage.googleapis.com/v1beta/models/gemini-1.5-pro-latest:generateContent?key=AIzaSyC-eGmdi_dbmLgRJcH2YeQU5ZS9JSUvIlQ'
For more information check: https://developer.mozilla.org/en-US/docs/Web/HTTP/Status/429

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "main.py", line 2006, in completion
    response = vertex_chat_completion.completion(  # type: ignore
  File "vertex_httpx.py", line 1484, in completion
    raise VertexAIError(status_code=error_code, message=err.response.text)
litellm.llms.vertex_httpx.VertexAIError: {
  "error": {
    "code": 429,
    "message": "Resource has been exhausted (e.g. check quota).",
    "status": "RESOURCE_EXHAUSTED"
  }
}

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "runpy.py", line 197, in _run_module_as_main
    return _run_code(code, main_globals, None,
  File "runpy.py", line 87, in _run_code
    exec(code, run_globals)
  File "__main__.py", line 7, in <module>
    sys.exit(main())
  File "main.py", line 680, in main
    coder.run()
  File "base_coder.py", line 728, in run
    self.run_one(user_message, preproc)
  File "base_coder.py", line 771, in run_one
    list(self.send_message(message))
  File "base_coder.py", line 1158, in send_message
    saved_message = self.auto_commit(edited)
  File "base_coder.py", line 1836, in auto_commit
    res = self.repo.commit(fnames=edited, context=context, aider_edits=True)
  File "repo.py", line 105, in commit
    commit_message = self.get_commit_message(diffs, context)
  File "repo.py", line 185, in get_commit_message
    commit_message = simple_send_with_retries(
  File "sendchat.py", line 44, in wrapper
    return decorated_func(*args, **kwargs)
  File "_sync.py", line 105, in retry
    ret = target(*args, **kwargs)
  File "sendchat.py", line 106, in simple_send_with_retries
    _hash, response = send_completion(**kwargs)
  File "sendchat.py", line 86, in send_completion
    res = litellm.completion(**kwargs)
  File "utils.py", line 1078, in wrapper
    raise e
  File "utils.py", line 966, in wrapper
    result = original_function(*args, **kwargs)
  File "main.py", line 2766, in completion
    raise exception_type(
  File "utils.py", line 8438, in exception_type
    raise e
  File "utils.py", line 7495, in exception_type
    raise RateLimitError(
litellm.exceptions.RateLimitError: litellm.RateLimitError: litellm.RateLimitError: VertexAIException - {
  "error": {
    "code": 429,
    "message": "Resource has been exhausted (e.g. check quota).",
    "status": "RESOURCE_EXHAUSTED"
  }
}

Thanks for trying aider and filing this issue.
It looks like you are out of quota with vertex. Aider should have retried for a couple minutes, but ultimately it can't proceed if the LLM provider API refuses.

I'm going to close this issue for now, but feel free to add a comment here and I will re-open or file a new issue any time.


Add OpenSUSE & CentOS dockerfiles

There are official Docker hub images for each of these:

https://hub.docker.com/_/centos/
https://hub.docker.com/_/opensuse/

We should take advantage of this and test on a few versions to try to cover enough different distros as possible.

This also requires changes to SemaphoreCI to use those after they're merged.


slf4j 2.0.3 + Lombok: logging class always resolved to org.slf4j.spi.DefaultLoggingEventBuilder

Describe the bug
It should have been resolved to the class issuing the logs, not the SPI class of the Slf4j.
To Reproduce
Steps to reproduce the behavior:

In Maven pom.xml

        <dependency>
            <groupId>org.slf4j</groupId>
            <artifactId>slf4j-api</artifactId>
            <version>2.0.3</version>
        </dependency>
        <dependency>
            <groupId>org.tinylog</groupId>
            <artifactId>slf4j-tinylog</artifactId>
            <version>2.5.0</version>
        </dependency>
        <dependency>
            <groupId>org.tinylog</groupId>
            <artifactId>tinylog-impl</artifactId>
            <version>2.5.0</version>
        </dependency>

Use Lombok @Slf4j in logging class, not manual import of tinylog Logger.
Log code sample

log.atInfo()
                .log("[{}] tasks were run by [{}] threads, with thread pool size [{}]",
                        TASK_COUNT,
                        actualThreadCount,
                        threadPoolSize);

Environment
tinylog version: 2.5.0
Java version: 17 (with release target 8)

@q3769 What is the output in the log file?

It looks like this when I do "mvn clean install":
2022-10-03 15:11:38 [main] org.slf4j.spi.DefaultLoggingEventBuilder.logViaPublicSLF4JLoggerAPI()
INFO: [100] tasks were run by [100] threads, with thread pool size [1000]


fix: hide other recipients

This PR addresses #873

[x] Addresses the issue in full
[ ] Addresses only certain aspects of the issue

Description
This PR sends emails via 'bcc' rather than the 'to' field in order to hide the other recipients of the email. My research showed that the options are simple: use the bcc field to send in bulk or loop through each email and send individually. I've included some resources below mentioning the use of the bcc field. Both implementations are straightforward but I worried that sending emails individually could lead to serious performance issues. I also heard mentions of this approach requiring queuing systems which seemed out of scope. The risk of the bcc approach is that the empty "to" field is more likely to be flagged as suspicious so a dummy email like<EMAIL_ADDRESS>could be used to help address that concern... though seemingly not entirely.
Nodemailer discussion: https://github.com/nodemailer/nodemailer/issues/385
SES advocating for the altenative of sending individually: https://aws.amazon.com/blogs/messaging-and-targeting/how-to-send-messages-to-multiple-recipients-with-amazon-simple-email-service-ses/
Stackoverflow supporting bcc: https://stackoverflow.com/questions/66627529/send-email-to-undisclosed-recipients-nodemailer
Mentions of potential flagging with empty "to" field: https://security.stackexchange.com/questions/177713/how-did-i-get-this-email-without-a-to-field
https://stackoverflow.com/a/27855503
How Can This Be Tested/Reviewed?
This can be tested most easily with the lottery flow. Create an admin and partner user connected to your email. Find a listing with lottery enabled and fill out two applications with two separate accounts on the public side. Then, go through the lottery flow with the two partners portal users and notice that emails sent to admins don't show<EMAIL_ADDRESS>in the recipient list. Then, publish the results to the public and you're two applicant emails should send separately and not have visibility to one another in the email information.
Author Checklist:

[x] Added QA notes to the issue with applicable URLs
[x] Reviewed in a desktop view
[ ] Reviewed in a mobile view
[ ] Reviewed considering accessibility
[ ] Added tests covering the changes
[ ] Made corresponding changes to the documentation
[ ] Ran yarn generate:client and/or created a migration when required

Review Process:

Read and understand the issue
Ensure the author has added QA notes
Review the code itself from a style point of view
Pull the changes down locally and test that the acceptance criteria is met
Either (1) explicitly ask a clarifying question, (2) request changes, or (3) approve the PR, even if there are very small remaining changes, if you don't need to re-review after the updates

Looking for thoughts on the decision between bcc and looping through emails described in the description above 🧼

@ColinBuyck is this still on Hold?


feat(exoflex): support a11y for radio

Add a11y support for RichRadio and Radio component

The reason I use checked for the state is refer to these:

https://www.w3.org/TR/2017/WD-wai-aria-practices-1.1-20170628/examples/radio/radio-1/radio-1.html
https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/ARIA_Techniques/Using_the_radio_role
https://www.w3.org/TR/2016/WD-wai-aria-practices-1.1-20160317/examples/radio/radio.html


Allow HTML in material tooltips and send tooltip clicks to server side

Vaadin layouts allow html in tooltips, so columnlayout should also allow. Click events for tooltips is just nice feature to have in material design.
Feature requested. To be implemented to 0.1.6.

Fixed to 0.1.6


Add support for Spring-boot 3

Auto configuration for Spring-boot 3 doesn't work because the name of the registration file (under META-INF) has changed.
See https://github.com/spring-projects/spring-boot/wiki/Spring-Boot-2.7-Release-Notes#auto-configuration-registration
and https://github.com/spring-projects/spring-boot/issues/33413
A workaround it to import the auto configuration classes explicitly by adding the following line to one of your configuration classes.
@ImportAutoConfiguration(MDCAutoConfiguration.class)
Thank you so much for your library.
Simon

Thanx for your report. Fixed in v1.1 (see changelog).


rendering for aquaducts

Style change requested
Aquaducts do not currently seem to be rendering in a way that is clear when crossing waterways.
Affected Tag or Tags
currently manifesting as bridge=aquaduct/waterway=canal when crossing a river
Where this is visible
Erie Canal Crossing the Mohawk River on the Rexford Aquaduct
https://www.openhistoricalmap.org/#map=18/42.85029/-73.88741&layers=O&date=1900&daterange=1800,2021

In the above example, the aqueduct has the waterway=canal tag included, but not the bridge=aqueduct tag.
vtiles:

OHM tags:

it appears i've mispelled it. i'll fix it and see if the rendering suddenly works.

no i spelled it right in the tag - aqueduct is correct. i spelled it wrong in the subject line of this ticket.

@Rub21, to style differently from other canals, I would need bridge=aqueduct available in tiles. Thanks!
Referenced here: https://github.com/OpenHistoricalMap/issues/issues/274#issuecomment-997026401

@tsinn  the feature bridge=aqueduct feature has been added in the water_lines layer.
https://vtiles.openhistoricalmap.org/#17.51/42.850258/-73.887852

cc. @batpad @geohacker

@tsinn Looks like this is something we never got to after Ruben updated vector tiles

This is styled in staging now:

Confirmed on live site:

https://www.openhistoricalmap.org/#map=17/42.84905/-73.88699&layers=O&date=1923-01-01&daterange=1923-01-01,2023-12-31


feat(Header): change the SupportIcon to the HelpIcon

What is the motivation for this pull request?
feat(Header): change the SupportIcon to the HelpIcon
What is the current behavior?

Header shows SupportIcon
GitHub uses short link

What is the new behavior?

Header shows HelpIcon
GitHub no longer uses short link
Minor copy improvements in Support page

Checklist:

[x] Conventional Commits
[x] Tests
[ ] Documentation

Codecov Report

Merging #1254 (9191454) into master (09d1e9d) will not change coverage.
The diff coverage is n/a.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.
@@            Coverage Diff            @@
##            master     #1254   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files           92        92
  Lines          894       894
  Branches       129       129
=========================================
  Hits           894       894

Impacted Files
Coverage Δ

src/components/Layout/Header.tsx
100.00% <ø> (ø)

src/pages/Support/Support.tsx
100.00% <ø> (ø)


0.1.0 as next package version

while you are away, I took the liberty of tagging some patch releases on my fork (it was mostly to do with updating the upstream zopfli submodule, while the API hasn't changed compared to wync/py-zopfli):
https://github.com/anthrotype/py-zopfli/releases
I had to recommend users of fonttools/fonttools who wished to compress WOFF 1.0 fonts to use my fork, as upstream bindings were not python 3 ready.
So it would be good if you bump the version package to anything greater than 0.0.7, which was the latest one I tagged on my fork.
Thanks.

Fixed in https://github.com/obp/zopfli/commit/aebbb59065e91be591b8d651bd146eb157581343#diff-2eeaed663bd0d25b7e608891384b7298


⚠ Bofrost.fr has degraded performance

In f6589be, Bofrost.fr (https://www.bofrost.fr) experienced degraded performance:

HTTP code: 200
Response time: 1155 ms

Resolved: Bofrost.fr performance has improved in 0940134 after 13 minutes.


Ginga detection incorrect when importing

With both ginga(3.4.0) and imexam installed, when I run import imexam, it gives Ginga not installed, use other viewer, or no viewer.
I checked the directories and found the detection returned Error at this line in the ginga.viewer.py. Should the AstropyWCS be change to any of this ones or any other things? Or did I forgot any package installed? Thanks.

I am having this issue as well.


[Mixcloud] Unable to extract title 2017.01.10

What is the purpose of your issue?

[x] Bug report (encountered problems with youtube-dl)
[ ] Site support request (request for adding support for a new site)
[ ] Feature request (request for a new functionality)
[ ] Question
[ ] Other

$ youtube-dl --extract-audio --audio-format mp3 --audio-quality 0 --embed-thumbnail --no-mtime https://www.mixcloud.com/fabric_London/mc-drs-marcus-intalex-mid-mic-crisis-mix-for-fabriclive/
[debug] System config: []
[debug] User config: []
[debug] Custom config: []
[debug] Command-line args: [u'--extract-audio', u'--audio-format', u'mp3', u'--audio-quality', u'0', u'--embed-thumbnail', u'--no-mtime', u'https://www.mixcloud.com/fabric_London/mc-drs-marcus-intalex-mid-mic-crisis-mix-for-fabriclive/', u'-v']
[debug] Encodings: locale UTF-8, fs utf-8, out UTF-8, pref UTF-8
[debug] youtube-dl version 2017.01.10
[debug] Python version 2.7.11 - Darwin-16.1.0-x86_64-i386-64bit
[debug] exe versions: ffmpeg 3.2.1, ffprobe 3.2.1, rtmpdump 2.4
[debug] Proxy map: {}
[mixcloud] fabric_London-mc-drs-marcus-intalex-mid-mic-crisis-mix-for-fabriclive: Downloading webpage
ERROR: Unable to extract title; please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; type  youtube-dl -U  to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.
Traceback (most recent call last):
  File "/usr/local/bin/youtube-dl/youtube_dl/YoutubeDL.py", line 694, in extract_info
    ie_result = ie.extract(url)
  File "/usr/local/bin/youtube-dl/youtube_dl/extractor/common.py", line 359, in extract
    return self._real_extract(url)
  File "/usr/local/bin/youtube-dl/youtube_dl/extractor/mixcloud.py", line 96, in _real_extract
    PREFIX + r'm-title="([^"]+)"', webpage, 'title')
  File "/usr/local/bin/youtube-dl/youtube_dl/extractor/common.py", line 671, in _html_search_regex
    res = self._search_regex(pattern, string, name, default, fatal, flags, group)
  File "/usr/local/bin/youtube-dl/youtube_dl/extractor/common.py", line 662, in _search_regex
    raise RegexNotFoundError('Unable to extract %s' % _name)
RegexNotFoundError: Unable to extract title; please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; type  youtube-dl -U  to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.

Mixcloud is unable to retrieve the title on a handful of pages.  On a couple occasions it's succeeded by re-running youtube-dl a few times.

Sorry, dupe of #11674 which just got patched an hour ago.


Fix tutorial. Support exporting network when device is not cuda.

Hi @itrendafilov thanks for this PR!
Generally we require an issue to be filed for each PR that explains the issue.
I'm running CI on your change and I've added @bamsumit to review.

Hi @itrendafilov thanks for your pull request. It looks like you skipped running the training part of the notebook and directly tried to load the trained torch model. That's why you are facing the issue. The exported hdf5 file is already there, so the fix is not required anyway.
If you want to load the network from the saved torch model, then yes what you are doing is the correct way to do it. But that is not the point of the tutorial.

Hi @bamsumit, I was running all steps in the tutorial. The problem is that by default the torch.load() is using map_location that is looking for a cuda device. If you don't have an nVidia GPU in your system, this throws an exception.

@itrendafilov are you sure you ran the training for more than 10 epochs? The code will only save the network at epoch=11 and it takes a lot of time for CPU training to reach there.

@itrendafilov, an acceptable solution is to change
if scheduler.snn_stat.best_accuracy:
    ...

to
if scheduler.snn_stat.best_accuracy or epoch==0:
    ...

in Training Loop block. This would save the model on the first epoch and load the trained model later.

@bamsumit  Sorry for the delayed reply. Yes, I was running with epoch=10 when I had observed the issue.  I just retested everything after a git hard reset. I haven't changed any code this time (beside enabling cpu), and it works without any exceptions. I suppose we can close the merge request. Do you want me to do that?

@itrendafilov, thanks for letting us know it is working now. I'll close this request now.


re-label salinity in TMIversion files

Can use S_p instead of Sp. Also check for absolute salinity.

New salinity labels in PR #105.
S_p for practical salinity in code.
Sstar for preformed salinity in NetCDF config files.


is there a way to Alphaimpute2 only impute samples in input file?

AlphaImpute2 is taking a long time ro run and a huge amount of memory due the to imputation genotypes of samples present in the whole pedigree file. Is there a way to impute genotypes only from the samples present in the genotype input file? I tried the -onlykeyed flag but it is not working.

Hi @mmudado, we are a bit slim with time and resources, but it would be very useful if you can give us some more details on:

the number of individuals in your pedigree,
the number of individuals genotyped, and
runtime

Thanks!

Hi Gregor,

18772
582
around 3 days
~600 GB RAM utilized.

Thanks,
On Wed, Aug 4, 2021 at 5:06 AM Gregor Gorjanc @.***>
wrote:

Hi @mmudado https://github.com/mmudado, we are a bit slim with time and
resources, but it would be very useful if you can give us some more details
on:

the number of individuals in your pedigree,
the number of individuals genotyped, and
runtime

Thanks!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/AlphaGenes/AlphaImpute2/issues/8#issuecomment-892455382,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ADGEGHE2KVEHPGHTQKXSQXTT3DYIXANCNFSM5BPN6I5A
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&utm_campaign=notification-email
.

Hi @mmudado this indeed looks excessive!
Can you also provide number of markers and the number of chromosomes these markers are spread over?

Hi,
Number of markers 537337
Number of chromosomes 30
We are trying to impute 50 samples from 35169 to 537337 markers. We are
using 532 samples fully genotyped with 537337 markers.
The time spent in the last AI2 run was :
Full Program Run: 132048.70 seconds
Thanks!
On Wed, Aug 4, 2021 at 12:13 PM Gregor Gorjanc @.***>
wrote:

Hi @mmudado https://github.com/mmudado this indeed looks excessive!
Can you also provide number of markers and the number of chromosomes these
markers are spread over?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/AlphaGenes/AlphaImpute2/issues/8#issuecomment-892742252,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ADGEGHCHX64QMYB7XVYDW23T3FKHZANCNFSM5BPN6I5A
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&utm_campaign=notification-email
.

@mmudado is it faster if you do one chromosome at a time? Then you can do them in parallel. You could also prune pedigree before imputation given that your only imputing 50 individuals.

Could I prune the pedigree file without losing accuracy?
On Wed, Aug 4, 2021 at 5:58 PM Gregor Gorjanc @.***>
wrote:

@mmudado https://github.com/mmudado is it faster if you do one
chromosome at a time? Then you can do them in parallel. You could also
prune pedigree before imputation given that your only imputing 50
individuals.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/AlphaGenes/AlphaImpute2/issues/8#issuecomment-892969198,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ADGEGHDANHSMAXNQJRK7IULT3GSWNANCNFSM5BPN6I5A
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&utm_campaign=notification-email
.

@mmudado this will depend on your pedigree. To summarise you have
pedigree: 18772
genotyped@500K: 532
genotyped@35K: 50
How "far" are your 50 animals from the 532 animals?
If you really want to leverage pedigree information in imputation, then I suspect the 50 are closely related to the 532. Since most of your pedigree is not-genotyped, you can prune out animals that will not provide any information to imputation - see http://didgeridoo.une.edu.au/km/prune.php this tool is for genetic evaluation (BLUP), but the principle is the same - individuals at the top of pedigree with only one progeny and no genotype data, or individuals at the bottom of pedigree with no genotype data don't contribute any information. I guess you will be able to shave of a lot of individuals. Doing chromosome by chromosome will help too.
If they are not closely related, you will not benefit from pedigree imputation and you can then use other population based approaches using Hidden Markov Models (say IMPUTE, IMPUTE2, ...).

Thanks!


Remove redundant order clause...

The main query to retrieve and order content items consists of Postgres JSON functions wrapping a sub query.
Ordering is attempted in the sub query which has no effect on the result
yet appears in the explain plan as a significant sort.
"              ->  Sort  (cost=23.04..23.05 rows=3 width=588)"
"                    Sort Key: content_items.public_updated_at"

See before and after explain plans for more detail.
explain-plan-before.txt
explain-plan-after.txt

I don't think this is significant - sorting 3 records shouldn't take any time at all. For instances like this it's best to use EXPLAIN ANALYZE to get real world timings of the query. Then pasting into http://explain.depesz.com/ will give a nice visualisation of where the most time is being spent.
Merged anyway for tidiness 👍


Support ObjectCreationHandling Serialisation Option

Is your feature request related to a problem? Please describe.
TL;DR; If a user assigns a default value to properties on objects they store in CosmosDB, then they won't get those properties back from the database when they retrieve the object (despite the data actually being in the database).
NewtonSoft.Json won't deserialise properties that have a default value, ie public FieldClass SomeField { get; set; } = new FieldClass(0);
See https://github.com/JamesNK/Newtonsoft.Json/issues/1675
The fix is to set the ObjectCreationHandling serialisation option to Replace - but this is not exposed in the SDK.
Describe the solution you'd like
Expose the ObjectCreationHandling option in CosmosSerializationOptions.
Describe alternatives you've considered
The user can work around this by using a custom serialiser (though this can be daunting to setup, especially in an existing codebase used in production).
Additional context
If a user stores an object in a property that always has a default value then it won't be deserialised from the database.
Examples include
public Foo Foo { get => this.foo ?? new(); set => this.foo = value ?? new() }
and
public FieldClass SomeField { get; set; } = new FieldClass(0);
This leads to hard-to-diagnose errors as they will only surface when objects are stored and retrieved and not in unit tests.
The problem is discussed here: https://github.com/JamesNK/Newtonsoft.Json/issues/1675
With NewtonSoft.Json you can fix this by setting ObjectCreationHandling to Replace
However, this option is not exposed in CosmosSerializationOptions meaning a user can't fix this with Cosmos without using a custom serialiser (which can be daunting to setup, especially in an existing codebase used in production).
System.Text.Json replaces by default but at the moment the serialiser in Cosmos seems to be NewtonSoft.
A downside to doing this would be if you have future plans to move to System.Text.Json as that does not have an equivalent option. However, making that move would change the default behaviour anyway and so would be a breaking change.

You can customize the serializer completely, for example, you can use System.Text.Json https://github.com/Azure/azure-cosmos-dotnet-v3/tree/master/Microsoft.Azure.Cosmos.Samples/Usage/SystemTextJson or simply have one using Newtonsoft.Json (like the one the SDK uses https://github.com/Azure/azure-cosmos-dotnet-v3/blob/master/Microsoft.Azure.Cosmos/src/Serializer/CosmosJsonDotNetSerializer.cs) but with your own custom configuration.

You can customize the serializer completely....

@ealsur Thank you. Yes, I understand that :) However, that is a bigger thing to do and potentially quite daunting if your code is already in use in production: By adding a custom serialiser you run the risk of inadvertently changing away from the standard settings in the SDK and breaking something. You can, of course, do it and you can look in this repo and copy the entire class you mentioned and just make that one change. But, it's more work and more risk.
Ideally the SDK should probably set this property Replace by default as that is the most logical for a database (not receiving back properties that exist in the database is not logical :)) - but I realise that would be a breaking change.

Right, the point is, by guideline of the global Azure SDKs, the public surface cannot have anything specific to an external library (so we cannot expose anything that takes in the Newtonsoft types).
The custom serializer is only used to deserialize customer data, not anything internal. The "danger" of adding a custom serializer is only if you have any data types that will behave differently with the new serializer when converting the raw json.
You are right that changing this internally might be a breaking change if it impacts other users.

Yeah, that makes sense. Not an easy thing :)
I guess the guidelines wouldn't preclude you from exposing your own version of "ObjectCreationHandling" - but it would tie your public interface uncomfortably close to an internal implementation detail.
I don't know the right answer - but I can see this is something that will catch people out and can definitely lead to actual data loss if they save the retrieved object back to the database.


Typescript errors when creating provider in ethersv5

✅ Prerequisites

[x] Did you perform a cursory search of open issues? Is this bug already reported elsewhere?
[x] Are you running the latest SDK version?
[x] Are you reporting to the correct repository (magic-sdk)?

🐛 Description
Trying to create an ethersv5 Web3Provider using magic.rpcProvider as described in docs results in a Typescript error
🧩 Steps to Reproduce

Install magic-sdk and ethersv5 in a typescript environment
Attempt to construct a Web3Provider using magic

🤔 Expected behavior
Types to match such that no error appears
😮 Actual behavior
Typescript reports that RPCProviderModule can't be assigned to ExternalProvider | JsonRpcFetchFunc

💻 Code Sample
I'm afraid I can't share the repo but here's the relevant code
import React, { createContext, ReactElement, useContext } from "react";
import { Web3Provider } from "@ethersproject/providers";
import { Magic } from "magic-sdk";

interface Props {
  children: ReactElement | ReactElement[];
}

interface State {
  magic?: Magic;
}

export const MagicContext = createContext({} as State);

export function useMagicContext(): State {
  return useContext(MagicContext);
}

function MagicProvider({ children }: Props) {
  // WARNING: This requires a domain whitelist to be set up on https://dashboard.magic.link/
  // Otherwise users are vulnerable to a phishing attack on other websites
  const MAGIC_API_KEY = "pk_test_5EF8CA802033ADE6";

  const customNodeOptions = {
    rpcUrl: "http://<IP_ADDRESS>:8545",
    chainId: 31337, // networkId of buidlerEVM test network
  };

  const magic = new Magic(MAGIC_API_KEY, {
    network: customNodeOptions,
  });

  return (
    <MagicContext.Provider value={{ magic }}>{children}</MagicContext.Provider>
  );
}

export const useProvider = (): Web3Provider | null => {
  const { magic } = useMagicContext();
  return typeof magic?.rpcProvider !== "undefined"
    ? new Web3Provider(magic.rpcProvider)
    : null;
};

export default MagicProvider;

🌎 Environment

Software
Version(s)

magic-sdk
2.4.8

Browser
N/A

yarn
1.22.4

Operating System
Linux

Possible dupe or related to #83?
For now, does casting magic.rpcProvider to any fix your issue?

Ah whoops, yeah this is a duplicate. I'm using // @ts-ignore for that line at the moment.

Ah whoops, yeah this is a duplicate. I'm using // @ts-ignore for that line at the moment.

This works, but I recommend casting to any so that any other type errors on that line become apparent 😃
I'll try to solve the typings issues between Web3JS and Ethers soon!

I'm on the latest version, but I'm also getting this error. I'm a bit worried using any will result in a mysterious bug later. Is there a fix?

I'm on the latest version, but I'm also getting this error. I'm a bit worried using any will result in a mysterious bug later. Is there a fix?

This one fell off the map for us a bit as it's strictly related to typings and has a known workaround (casting to any). I know it's not the prettiest solution, but considering that the Web3 provider interface is stabilized and standardized by the Ethereum foundation, I'm comfortable saying that the any typing shouldn't cause you backwards compatibility issues in the future.
We are open to a PR to update the typings, if you're game!

All good. thanks for the crazy fast response!


Questions about proxy.py

Hardware: facedancer
Software: kali, python3.8.9
After I downloaded the file from the library, I tried to run the facedancer\proxy.py file, but it always reported a dependency library problem
I am a newbie, can you please give me some guidance?
If this hardware/software doesn't work, is there any other way to enable the proxy? What I want is to capture the USB data packets fed back by the device under test

Hi, thank you for your questions!
Can you please copy and paste the error message that's being reported?

At first, I downloaded version 3.0.6 of the library locally and tried to run the proxy.py file. I encountered the first problem as follows:
Traceback (most recent call last):
File "/xxx/facedancer/facedancer/proxy.py", line 11, in
from .           import DeviceSpeed, USBConfiguration, USBDirection
ImportError: attempted relative import with no known parent package
For example, the import command from .request import USBControlRequest in the file, I deleted all the "." in the import command, renamed the error-prone types.py and logging.py files, and updated them to the various files in the facedancer folder.
Later, because the configuration.py file and the device.py file were imported in a loop, an error occurred. I merged the previous two files into con_device.py and made appropriate modifications after the merger. The current error content is:
Traceback (most recent call last):
File "/xxx/facedancer/facedancer/proxy.py", line 13, in
from con_device     import USBBaseDevice, USBConfiguration
File "/xxx/facedancer/facedancer/con_device.py", line 33, in
@dataclass
NameError: name 'dataclass' is not defined
That's my question. Thank you for your patience.

The main problems you're running into are:

You need to first install the Facedancer library into your local Python environment. See https://facedancer.readthedocs.io/en/latest/getting_started.html for more information.
If you want to run library files directly you'll want to specify the module rather than the path. i.e. python -m facedancer.proxy
There's also a standalone example in the examples/ directory you can run with python ./examples/usbproxy.py.

Can you please also tell me more about the hardware you're using, you said it is 'facedancer' but there are many different Facedancer devices such as the GoodFET, Cynthion, Hydradancer etc.


Not responding?

Hello, I installed all the recommended libraries, the sketch is compiling without any errors, unfortunatly when I uploaded the sketch, nothing is happening. Of course, I checked Serial Monitor with Baud 115200, to know what is happening, and there is nothing there also.
Plus no new device connected to my router.
Any help please.
Thx.

Hi,
This is a bit of an old project. I will have to look into it. I am happy to, but not before this weekend.
Cheers
Rob


Only one partition key value is supported in the query

@Incarnation-p-lee I think this is supported now with PartitionKeyDefinition. I am closing this issue, in case you feel otherwise, please feel to re-open it and we can discuss this.


Let Files pane remember last location or sync with current file

Let the Files pane (file system tree) remember last location when launched, or sync with current file, such as seen in Eclipse.

It's not an auto-sync like (I believe) was requested, but I've added a menu item to the text area's context menu that allows a manual sync with the current file and the file system tree.

Nice, thanks!


change version numbers in urls and text to latest

I’m closing this issue because it has been inactive for more than two years. Please reopen if you still encounter this issue with the latest version.


Weird bug when using transitions and a $navigating spinner together

Describe the bug
When switching pages, there is a bug happening when the layout contains some code to show a loading spinner on $navigating != null and the page we are navigating from contains a transition. The transition then happens, but stops and the DOM is not updated to remove the old page and render the new page.
Reproduction
https://github.com/Nightloewe/svelteKitBugTransition
Logs
src\routes\+layout.svelte
`<slot />` missing — inner content will not be rendered

System Info
Does not work

Severity
annoyance
Additional Information
No response

Closing this as I can't reproduce it on latest Svelte.


Error when using repository methods outside of a request context

On my open source project, we have a in memory queue, where we have some functions regards gamification stuff. So, those functions run asynchronously
Before version 0.1.17, everything worked fine, but now we are constantly getting the error below

As far as I can tell, it seems that when not bound to a http request context, the manager is null, and then everything stops working.

Hi @DavideCarvalho,
Can you follow: https://github.com/odavid/typeorm-transactional-cls-hooked#logging--debug and post the log?
Also, when do you patch the Repository and when do you initialize the context?
It is weird, since the Repository.manager get/set are doing the same thing they did before
https://github.com/odavid/typeorm-transactional-cls-hooked/blob/master/src/patch-typeorm-repository.ts#L9

Hi @DavideCarvalho - I could not reproduce the issue, however, I think I found a case within the code that can explain such behavior. After #61 was merged, I noticed that the manager can be null after a transaction was ended, but the context is still active. This seems to be a very rare case, but I restored the original behavior, so I hope it solves the issue
I would be glad if you let me know after upgrading to v0.1.18, if it still happens.

Hey @odavid, you were really fast replying! Thanks!
Renovate bot already PR my repo, will accept and have a quick test, I'll give you a feedback after it

Everything is working fine, ty very much!


The logout_url parameter from the DELETE /session request can not be provided just as an URL path like in ermrest_config.json

If I provide for the logout_url parameter just a URL path, webauthn does don't include in the Continue to ... link the hostname of the sender, like it does with the default_logout_path parameter from ermrest_config.json.
As this link appears in the Globus logout page, the Globus server hostname will be used instead of the sender's one.
The logout_url parameter works properly for URLs specified as href.

Tested and works as expected.


What is the plan to deal with the segwit2x support?

We are using omnicore to sign usdt transaction. How does it affected by segwit2x?

Hi @phuongnd08, we are going to publish a statement about this shortly.

Would you give some estimation on this? Where should be subscribe to hear about this statement?

We're probably going to publish a statement on https://blog.omni.foundation/ in the next week or so, but in short:
While the Omni protocol is blockchain agnostic, Omni Core uses Bitcoin Core as underlying base and we're going to continue to do so.

Please feel free to reopen this issue or leave any additional comments. :)


Add support for generative art collections

Why:
To enable and encourage artists to inscribe generative art collections in the most efficient manner possible.  With the advent of the Ordinals protocol, we feel it's becoming increasingly important to set good standards and best practices for optimizing block space usage.
For example, an entire art collection can be inscribed on a single ordinal by creating an HTML or SVG file which can accept url parameters to render different pieces in the collection.  Check out the OnChainBirds parent collection for a good example:
https://ordinals.com/content/551e65f2839c776524df295ccc25ce3cbd214fa3134f18b67264069250c9bbd2i0?tokenID=45
We can change the tokenID url param to render any of the 10k pieces in the collection.
Collections inscribed in this manner can save considerable space, and prevent unnecessary bloat on the btc blockchain.  Using the JSON format proposed below for each child, we can observe a space savings of more than 99.7% (159.5mb) for the OnChainBirds collection alone.  Rough calculation:
If each child had to inscribe the complete svg image (~16kb each), for the entire 10k collection we get:
10000*16kb = **160mb**

If we instead use a simple JSON pointer (.045kb each), for the entire 10k collection we get:
10000*.045kb = **0.45mb**

Moreover, the example above is only demonstrating space savings gained from a simple pixel art collection.  The space savings can be orders of magnitude greater when dealing with 3d/animated art, such as what can be generated with libraries such as threejs.  Instead of importing this large lib for each child inscription, we only need to import it once in the parent.
What:
This request is to add support for a child inscription pointer mechanism.  These child inscriptions are JSON documents containing url parameters that instruct the parent inscription to render a specific item in the collection.  A proposed JSON spec, in it's simplest form, is given below.  It is expandable to accept any number of url parameters, and can contain other optional fields such as metadata or similar.
How:
Since all art is contained in the parent, we can add a simple redirect to render the parent inscription with included url parameters. There are 3 constraints which must be met, in the child inscription, before the redirect can happen:

The child inscription must have a parent inscription.
The child inscription's body data must be valid JSON.
The child inscription's body JSON data must contain a field named "use_p", with any value.

Proposed JSON standard for child pointer inscriptions:
{
   "use_p": 1,
   "params": ["tokenID=4969"]
}

We have an open PR, with included test coverage, which implements the above functionality:
https://github.com/raphjaph/ord/pull/7
Any thoughts/feedback/code review are greatly appreciated.

I like the idea.  Would change params to a js object so it could be better handle complex parameters and be interpreted by URLSearchParams (or equivalent).
 {
   "use_p": 1,
   "params": {
      "tokenID": 4969
   }
}

Also, I would modify the 1st constraint to require that the parent is either html or svg before redirecting.  Without this check I think your code could double-redirect allowing holders to create children (grandchildren of the html) that would look like children.

Great points.  Regarding the double-redirect thing, instead of restricting to parent html or svg content types, we can do the opposite and prohibit redirecting to a parent with JSON content type.

I think this is covered by recursive inscriptions, since now an inscription can reference another inscription via the /content endpoint.


[BUG] full disc volume on server and don't login to admin pannel

Hello, don't be tired, I have faced server memory full for a few days, all 20 gb disk volume is showing full in aa pannel and it is not entered in the admin page, what file should I delete in the site panel to make it empty?

First you need to confirm what files are taking up your disk, use root login your server and check it.
Also reiterate that this is not a v2board bug, we are not obliged to help you solve your server problems.


Warning on local variable names masking global variable names

Golint doesn't flag on such global / local overloading conditions.  In the following case, it would have been a great help in finding a runtime error.
package main

var myIO   *io.Writer

function main() {
.
.
myIO := (create writer)    // error - created a local variable rather than setting
                           // the global with a := rather than =
.
}

function useit ()
{
.
.
fmt.Fprint(myIO, "stuff)    // null pointer at runtime since myIO defined, but set to null
.
}

Flagging global/local variable overloading would seem like a natural for the linter!


shift-insert doesn't work

i copy text and want to insert it with shift-insert
Specifications
version: 2.0.12
Commit hash:c2cebaa3
OS:Arch Linux
Terminal:xterm

What do you mean by "doesn't work"? Does it paste the wrong thing? Nothing at all? How are you copying the text?
Shift-Insert works for me (I'm on Linux), although it uses a different clipboard than Ctrl-c and Ctrl-v. Micro has some settings you can try to fiddle with (look up help copypaste and clipboard in help settings for details) but it's likely the issue is caused by your system / terminal configuration.

i think everything is ok with micro. The problem is on my side. But when i tried to copy data from browser, nothing was pasted.


Fixed required Django version

As mentioned in README - minimum Django version is 1.7

Coverage remained the same at 96.053% when pulling 641825f9fc490d7eebae2df360118a02549e504e on Stranger6667:update-dependency into 128812d4852af95ddff5907e0fe1002eadcf1e64 on sunscrapers:master.

Thanks @Stranger6667 for submitting! Good catch. For now I will merge it but I believe that we should remove this line in requirements file because of #110.


Custom Build Image: Cannot pull container error Too Many Request

I've been experiencing an issue today with building using a custom image. The error is telling me the Docker Hub is running into a request limitation. The limit is 100 pull requests per 6 hours fo anonymous access. We definitely haven't gotten close to 100. I can also still pull the image to my computer. We have a few other builds AWS Console which are using the same custom image without issues.
I've seen this error popup a few times randomly. I can usually make it past the error by redeploying but that's not the case today.

@karice We are looking into this and will let you know when we can resolve this for you.

fwiw, pretty sure this is a duplicate: https://github.com/aws-amplify/amplify-console/issues/837

#837 is asking about adding authentication for the request to docker hub to avoid the rate limit which is 100 requests per 6 hours for anonymous access. We haven't even come close to hitting this limit. We were able to push a different build using the same image a few times but this one is hung up on this error and won't go thru.

#837 is about exactly this error, I authored it, so I am quite certain. Any solution would be fine, having some way to set authentication is just one possible solution.
It's not you hitting the limit. It's the amplify build service, and the IP that docker hub sees. Which is probably a small-ish pool of IPs across all amplify jobs.

I'm periodically running into this issue. Given all the other bugs have been closed as a duplicate of this, I just want to make sure this issues does not get lost. Given the new Docker rate limits, this should likely be addressed ASAP. This is like a P0 or a P1 at worst.

Scratch that, this is now a regular issue.
I use Amplify because of it's simplicity, I don't have to set up Github Actions + S3 + CloudFront. But despite this issue being open for nearly 3 months and constant warning from Docker that rate limiting will and did happen, nothing is done. What am I paying for if I cannot deploy or constantly have to hit the "Redeploy" button until it is successful.
There's not even a work around? If you don't want folks using this service then please announce it's end of life.

Scratch that, this is now a regular issue.
I use Amplify because of it's simplicity, I don't have to set up Github Actions + S3 + CloudFront; it really is great that way. But despite this issue being open for nearly 3 months and constant warning from Docker that rate limiting will and did happen, nothing is done. What am I paying for if I cannot deploy or constantly have to hit the "Redeploy" button until it is successful?
It took 6 build before it worked. Next time it could be 20 or 50 or 2.
There's not even a work around? If you don't want folks using this service, then please announce it's end of life so we can move on and find a better solution like Digital Ocean or Render.

CMIIW but there is workaround by using your own image stored in AWS ECR. It probably will cost you < $1/mo, see cost.

Okay, thanks for the update.

@asendia Amplify Console does not allow you to pull custom images from ECR for some reason.Only docker hub. https://docs.aws.amazon.com/amplify/latest/userguide/custom-build-image.html
@div5yesh AWS is planning on releasing a public image hosting service to work around Docker Hub limits. No hard release date yet and don't know when they will change Amplify Console to work with it or ECR. It might be better to find a new CI service. https://aws.amazon.com/blogs/containers/advice-for-customers-dealing-with-docker-hub-rate-limits-and-a-coming-soon-announcement/

We face this issue every week now. Is there a projected fix for this? It seems like a relatively simple use case.

I faced this all day yesterday literally not able to run a build without waiting at least 10 minutes to trigger another build. I ended up dropping back to a AmazonLinux container with additional scripts to add what I need from the Docker image

Still experiencing this issue here

+1 I've created an AWS ticket regarding this issue. They recommend pushing a custom image to ECR and using it as a build image. The AWS support referenced the following links (incl. this thread) in their response:
[1] Custom Build Image: Cannot pull container error Too Many Request - https://github.com/aws-amplify/amplify-console/issues/1009
[2] Data transfer (number of pulls allowed per 6 hours) - https://www.docker.com/pricing
[3] Pushing an image - https://docs.aws.amazon.com/AmazonECR/latest/userguide/docker-push-ecr-image.html
[4] Pulling an image - https://docs.aws.amazon.com/AmazonECR/latest/userguide/docker-pull-ecr-image.html
[5] Have amplify build containers support ECR containers & custom container sizes - https://github.com/aws-amplify/amplify-console/issues/493
[6] https://github.com/aws-amplify/amplify-console/issues/254#issuecomment-556550722

I was able to make Amplify provision with a custom image by publishing a new image version in Docker hub... but can't have our team doing this every time though! Lol
We tried adding items as scripts during preBuild, but it's just too slow of a deploy, so this has quickly turned into a major blocker 😕 we may have to migrate elsewhere, at least temporarily, until this is fixed

Is there a guide to using ECR with Amplify? https://docs.aws.amazon.com/amplify/latest/userguide/custom-build-image.html doesn't contain any information on using an ECR-based image.

Is there any update on this? I am seeing this same error.

Waiting for an update on this too.

Still not any solutions yet?

Unable to build any new images due to this

Any updates? Can't be hitting redeploy over 10 times a day.

Any updates?

Looking to use Amplify for a new app, but this issue is preventing my first deployments.

This is such a big issue how is this not priorised

Its amazing how such a HUGE problem has not clear solution.

This is going to sound insane, but I tried to fix this issue for days...I mean, 9 hours a day, experimenting and poking at things, for about 8 straight days.
Finally, I thought to myself: "If I were AWS, how/where would I be testing or building?"
Answer: On an EC2, maybe?
So, I spun up an EC2, and built + pushed my Dockerfiles from that host.
Magically, my custom images began to work (getting past the "Provision" step with a green check!)
I've tried this with bullseye-slim & al2 images, successfully.
...totally weird.

You can fix this quickly if you put your image in a public ECR repository and configure your Amplify project in Build Settings to use that

So we're on the same page:
Does AWS maintain a public ECR image of official images on dockerhub for node, python, etc? If not, does it plan to in the future?
The reason why is I don't need a specialized container per se 😆 . Just the official containers w/ a specific version set.

I have a "custom image" set, but it's a commodity one: node:14.18.2

For anyone still running into this: If you only need a "standard" image like @tony you can pull it from https://gallery.ecr.aws/. For example, you can set your image to public.ecr.aws/docker/library/node:18.12.1

You can use this pattern.
public.ecr.aws/docker/library/node:your_node_version
For example if you use Node.js version v18.16.0,
public.ecr.aws/docker/library/node:18.16.0


3.1.0

This is a small bump to R 3.6.0 and a small civis-r release 2.1.0.
I deleted the environment variables in the image because they are not being maintained.

What do you mean by "not being maintained"? They look up to date to me.

 There's really no harm.

I would be curious to know if anyone uses them! I've definitely used the version number in Python packages, but I don't find myself checking package versions within R very often. Probably because I find version number to be a more common source of bugs in Python than R :)

Hmm, how did it let you merge before I approved?