Brand new VSCode + CRA + JestRunner fails to parse

I'm running a brand new Windows install -- no global NPM installs, no dangling configurations -- brand new, unadulterated setup.  I get an error from Babel when running Jest Runner against an untouched CRA Typescript application.
Steps to reproduce:

Install VSCode (latest) and the Jest Runner extension
Install Node/NPM LTS (v15)
Created an application using npx create-react-app demo --template typescript
Via CMD or Git Bash, execute npm test and see that the tests pass
Place a breakpoint in App.test.tsx as shown below and use Jest Runner's "Debug" option:

Expected Result:
Breakpoint is hit, test passes if I continue
Actual Result:

C:\Users\me\Projects\demo> cmd /C "set "NODE_OPTIONS=--require "c:/Users/me/AppData/Local/Programs/Microsoft VS Code/resources/app/extensions/ms-vscode.js-debug/src/bootloader.bundle.js" --inspect-publish-uid=http" && set "VSCODE_INSPECTOR_OPTIONS={"inspectorIpc":"\\\\.\\pipe\\node-cdp.21704-1.sock","deferredMode":false,"waitForDebugger":"","execPath":"C:\\Users\\me\\AppData\\Local\\nvs\\default\\node.exe","onlyEntrypoint":false,"autoAttachMode":"always","fileCallback":"C:\\Users\\me\\AppData\\Local\\Temp\\node-debug-callback-f8c90c09f6c08014"}" && C:\Users\me\AppData\Local\nvs\default\node.exe .\node_modules\jest\bin\jest.js c:/Users/me/Projects/demo/src/App.test.tsx -t "renders learn react link" --runInBand "
Debugger attached.
 FAIL  src/App.test.tsx
  ● Test suite failed to run

    SyntaxError: C:\Users\me\Projects\demo\src\App.test.tsx: Support for the experimental syntax 'jsx' isn't currently enabled (6:10):

      4 |
      5 | test('renders learn react link', () => {
    > 6 |   render(<App />);
        |          ^
      7 |   const linkElement = screen.getByText(/learn react/i);
      8 |   expect(linkElement).toBeInTheDocument();
      9 | });

    Add @babel/preset-react (https://git.io/JfeDR) to the 'presets' section of your Babel config to enable transformation.
    If you want to leave it as-is, add @babel/plugin-syntax-jsx (https://git.io/vb4yA) to the 'plugins' section to enable parsing.

      at Parser._raise (node_modules/@babel/parser/src/parser/error.js:60:45)
      at Parser.raiseWithData (node_modules/@babel/parser/src/parser/error.js:55:17)
      at Parser.expectOnePlugin (node_modules/@babel/parser/src/parser/util.js:157:18)
      at Parser.parseExprAtom (node_modules/@babel/parser/src/parser/expression.js:1153:18)
      at Parser.parseExprSubscripts (node_modules/@babel/parser/src/parser/expression.js:565:23)
      at Parser.parseUpdate (node_modules/@babel/parser/src/parser/expression.js:545:21)
      at Parser.parseMaybeUnary (node_modules/@babel/parser/src/parser/expression.js:529:17)
      at Parser.parseExprOps (node_modules/@babel/parser/src/parser/expression.js:349:23)
      at Parser.parseMaybeConditional (node_modules/@babel/parser/src/parser/expression.js:314:23)
      at Parser.parseMaybeAssign (node_modules/@babel/parser/src/parser/expression.js:269:21)

Test Suites: 1 failed, 1 total
Tests:       0 total
Snapshots:   0 total
Time:        3.042 s
Ran all test suites matching /c:\\Users\\me\\Projects\\demo\\src\\App.test.tsx/i with tests matching "renders learn react link".
Waiting for the debugger to disconnect...

The above happens with or without adding the following from the Jest Runner extension page to settings.json in VSCode:
    "jestrunner.jestCommand": "npm run test --",
    "jestrunner.debugOptions": {
        "args": ["--no-cache"],
        "sourcemaps": "inline",
        "disableOptimisticBPs": true
    }

(including both, or one or the other -- all 3 fail in the same way)
What's worse is that prior to re-installing Windows, I had this working without any extra VSCode configurations that I'm aware of.  Certainly no .vscode/whatever.json files for the project though there may have been something applied globally that I do not recall.
Really what I'm trying to do is just use VSCode Jest Runner on a typescript CRA application.  All documentation I've found has resulted in some form of error like the above.  Doing what the error says does not move the ball.  The specific error about adding to the babelrc because there is no babelrc in an untouched CRA application.
Though I know the two projects are not related, it's maybe worth noting that the "Jest" extension runs all tests and they pass within VSCode.  I like Jest Runner because of the elegant Debugging though.

hey @adamski52
thx for reporting
is this only happening for DEBUG or also for RUN?

hey @adamski52
thx for reporting
is this only happening for DEBUG or also for RUN?

@firsttris  hello. Also for Run. If there's any more info I can get to help please let me know.

@firsttris  hello. Also for Run. If there's any more info I can get to help please let me know.

@firsttris  I apologize -- I thought I had used this extension prior to reinstalling Windows, but apparently I never did, so my expectation that it work in the way I expected was a bad expectation.
The above conditions are still true, but my expectation that it work without a launch.json is probably wrong since I was using a different extension for which that was true, and I confused the two.  The errors are to do with it not transpiling from TypeScript to JavaScript (via Babel, or whatever) so maybe there's an option I could have added to the config to address that.
So, maybe the above is still a defect but more likely is that it's addressed by following the setup steps listed for CRA applications? The confusion/reason for opening this was because I did not have to do that with my application before, because I was using a different extension, I guess.

@firsttris  I apologize -- I thought I had used this extension prior to reinstalling Windows, but apparently I never did, so my expectation that it work in the way I expected was a bad expectation.
The above conditions are still true, but my expectation that it work without a launch.json is probably wrong since I was using a different extension for which that was true, and I confused the two.  The errors are to do with it not transpiling from TypeScript to JavaScript (via Babel, or whatever) so maybe there's an option I could have added to the config to address that.
So, maybe the above is still a defect but more likely is that it's addressed by following the setup steps listed for CRA applications? The confusion/reason for opening this was because I did not have to do that with my application before, because I was using a different extension, I guess.

Hey there :wave:
I had the same issue but only when running debug for a React application
My environment

create-react-app ^4
typescript 4.1
yarn2 with pnp

And my vscode config for jest-runner:
  "jestrunner.jestCommand": "yarn run react-scripts test",
  "jestrunner.enableYarnPnpSupport": true,
  "jestrunner.detectYarnPnpJestBin": true`

Investigation
After looking at the command used by the extension, I realized that when clicking run, the command was:
yarn run react-scripts test 'PATH_TO_TEST_FILE' -t 'TEST_FILE'

while the command for the debug was:
cd PROJECT_PATH ; /usr/bin/env 'NODE_OPTIONS=--require /usr/share/code/resources/app/extensions/ms-vscode.js-debug/src/bootloader.bundle.js --inspect-publish-uid=http' 'VSCODE_INSPECTOR_OPTIONS={"inspectorIpc":"/tmp/node-cdp.498108-5.sock","deferredMode":false,"waitForDebugger":"","execPath":"/usr/bin/node","onlyEntrypoint":false,"autoAttachMode":"always","fileCallback":"/tmp/node-debug-callback-f4c221c143caa000"}' /usr/bin/node --require PROJECT_PATH/.pnp.js "`yarn bin jest`" PATH_TO_TEST_FILE -t "TEST_FILE" --runInBand

My interpretation of the issue

when running run, the extension works fine because it used react-scripts test and therefore the create-react-app jest & babel configs
when running debug, the extension uses `yarn bin jest` and not react-scripts test. Since jest uses babel to transpile the typescript (doc) and the react (doc), it will fail because there is (theoretically) no babel.config.js file in a create-react-app repo.

Temporary solution
I have a temporary fix:

I added the babel-preset-react-app to my dev environment (yarn add --dev babel-preset-react-app)
I created a babel.config.js:

// babel.config.js
module.exports = {
  presets: [
    ["@babel/preset-env", { targets: { node: "current" } }],
    "babel-preset-react-app",
  ],
};

I ran debug and now its working just fine :ok_hand:

Hey there :wave:
I had the same issue but only when running debug for a React application
My environment

create-react-app ^4
typescript 4.1
yarn2 with pnp

And my vscode config for jest-runner:
  "jestrunner.jestCommand": "yarn run react-scripts test",
  "jestrunner.enableYarnPnpSupport": true,
  "jestrunner.detectYarnPnpJestBin": true`

Investigation
After looking at the command used by the extension, I realized that when clicking run, the command was:
yarn run react-scripts test 'PATH_TO_TEST_FILE' -t 'TEST_FILE'

while the command for the debug was:
cd PROJECT_PATH ; /usr/bin/env 'NODE_OPTIONS=--require /usr/share/code/resources/app/extensions/ms-vscode.js-debug/src/bootloader.bundle.js --inspect-publish-uid=http' 'VSCODE_INSPECTOR_OPTIONS={"inspectorIpc":"/tmp/node-cdp.498108-5.sock","deferredMode":false,"waitForDebugger":"","execPath":"/usr/bin/node","onlyEntrypoint":false,"autoAttachMode":"always","fileCallback":"/tmp/node-debug-callback-f4c221c143caa000"}' /usr/bin/node --require PROJECT_PATH/.pnp.js "`yarn bin jest`" PATH_TO_TEST_FILE -t "TEST_FILE" --runInBand

My interpretation of the issue

when running run, the extension works fine because it used react-scripts test and therefore the create-react-app jest & babel configs
when running debug, the extension uses `yarn bin jest` and not react-scripts test. Since jest uses babel to transpile the typescript (doc) and the react (doc), it will fail because there is (theoretically) no babel.config.js file in a create-react-app repo.

Temporary solution
I have a temporary fix:

I added the babel-preset-react-app to my dev environment (yarn add --dev babel-preset-react-app)
I created a babel.config.js:

// babel.config.js
module.exports = {
  presets: [
    ["@babel/preset-env", { targets: { node: "current" } }],
    "babel-preset-react-app",
  ],
};

I ran debug and now its working just fine :ok_hand:

thx for the summary @Dot-H i included your findings into the readme.

If anybody else comes across this, here's what works in our project. We have a script to generate the same jest.config.js file that's used under the covers of CRA:
// tests/debug/setup.js
const { writeFileSync } = require("fs");
const { resolve } = require("path");
const createJestConfig = require("react-scripts/scripts/utils/createJestConfig");

// Add jest.config.js file based on CRA scripts
const rootDir = resolve(__dirname, "../..");
const jestConfigFile = resolve(rootDir, "jest.config.js");
const jestConfig = createJestConfig(
  (relPath) => resolve(rootDir, "node_modules/react-scripts", relPath),
  rootDir,
  false
);
writeFileSync(
  jestConfigFile,
  `// autogenerated file for test debugging purposes only\nmodule.exports = ${JSON.stringify(
    jestConfig
  )}`
);

In your VSCode settings.json, all that's needed is this:
{
  "jestrunner.jestCommand": "npm run test --"
}

Run node tests/debug/setup.js to generate the config file (you may want to put it in .gitignore)
For us, with this setup, both run and debug buttons in VSCode work as expected

@Jack-Barry I have this problem, but I don't understand the algorithm of actions from your answer?
I have a React project on TS created with CRA. But there are no babel.config.js and jest.config.js
This is my command to call the tests:
"scripts": {     "start": "react-scripts start",     "build": "react-scripts build",     "test": "react-scripts test nyc --transformIgnorePatterns \"node_modules/(?!axios)/\"",   },
Everything works fine with JSX and TSX tests.
How do I generate a test.config file.js for Jest Runner?

@Dot-H
I did as you wrote
https://github.com/firsttris/vscode-jest-runner/issues/136#issuecomment-769707833
and Jet Runner started working for me, but only with TS. When I want to test tests with TS extensions, an error appears:

It looks like after adding babel.config.js import settings are broken for other types of file extensions, for example css modules.
To configure the import, I use react-app-env.d.ts
//react-app-env.d.ts
/// <reference types="react-scripts" />

Hope this helps some, I got debug to work for CRA in vscode by doing the following: https://github.com/firsttris/vscode-jest-runner/issues/315


dotnet restore cannot download Package from case-sensitive nuget mirror

dotnet restore cannot download Package from case-sensitive nuget mirror
When using dotnet restore to resolve NuGet dependencies, NuGet fails when using a nuget registry, which has a case-sensitive API.
General
used tools:

.NET Command Line Tools (2.2.203) on Linux
Ubuntu 18.04 x86_64
private NuGet registry hosted on Artifactory 6.6.5

When specifying a dependency, which has a name with UpperCase characters, like this:
<PackageReference Include="Newtonsoft.Json" Version="[12.0.2]" />
And specifying an internal Artifactory 6.6.5-based NuGet registry, like this:
<packageSources>
  <add key="ArtifactoryNuGetV3" value="https://####.net/api/nuget/v3/####/" protocolVersion="3" />
</packageSources>

and using dotnet restore -v n --no-cache to load NuGet dependencies, we can see in dotnet's cmd line output that dotnet is issuing these HTTP requests to the artifactory server:
1>Restore:
         Restoring packages for /home/perzl/git/####.csproj...
           GET https://####.net/api/nuget/v3/####/registration-semver2/newtonsoft.json/index.json

[....]

1>/usr/share/dotnet/sdk/2.2.203/NuGet.targets(119,5): error : The feed 'ArtifactoryNuGetV3 [https://####.net/api/nuget/v3/####/]' lists package 'Newtonsoft.Json.12.0.2' but multiple attempts to download the nupkg have failed. The feed is either invalid or required packages were removed while the current operation was in progress. Verify the package exists on the feed and try again. [/home/perzl/git/####.csproj]
/usr/share/dotnet/sdk/2.2.203/NuGet.targets(119,5): error :   Unable to find package 'Newtonsoft.Json.12.0.2'. [/home/perzl/git/####.csproj]

Especially have a look at the request URL
GET https://####.net/api/nuget/v3/####/registration-semver2/newtonsoft.json/index.json
in which the package name is converted to lower case
In my opinion, I think this is a problem in both tools: dotnet restore and Artifactory NuGet registry.

dotnet restore is making requests to the NuGet API with package names converted to lower case (it should not change the case of package names)
Artifactory should handle requests to its API case-insensitive

Any of these two changes would solve this issue for me, but I think that both should be solved.
Any feedback is appreciated

This is the corresponding ticket in the JFrog Artifactory ticket system:
https://www.jfrog.com/jira/browse/RTFACT-18567
When using a NuGet API v2, I can resolve my dependencies with dotnet and Artifactory without any problems.
<packageSources>
  <add key="ArtifactoryNuGetV3" value="https://####.net/api/nuget/####/" />
</packageSources>

So to make my initial issue more specific: it only affects NuGet protocol version 3

@rrelyea can you please help route this issue?

Hey @Parcley, thanks for taking the time to report this.
The V3 protocol by design expects the "registration" (package metadata) JSON URLs to contain lowercase IDs. The official protocol is documented to expect ID_LOWER:
https://docs.microsoft.com/en-us/nuget/api/registration-base-url-resource#registration-pages-and-leaves
For a real-life example, nuget.org's V3 expoints expect the ID to be lowercase.
https://api.nuget.org/v3/registration3-gz-semver2/newtonsoft.json/index.json (200 OK)
https://api.nuget.org/v3/registration3-gz-semver2/Newtonsoft.Json/index.json (400 Not Found)

Here's the code in NuGet client that lowercases the ID:
https://github.com/NuGet/NuGet.Client/blob/46afef4bc537ef92559d543e1e013d6f37072812/src/NuGet.Core/NuGet.Protocol/Resources/RegistrationResourceV3.cs#L56-L57
In short, this is by design.

Thank you all for the clarification.
I have linked this issue in the mentioned JFrog issue.

dotnet restore is working correctly and is NuGet protocol v3 compliant.
JFrog Artifactory is case-sensitive with regard to IDs and thus not NuGet protocol v3 compliant.


JSON parsing fails when json_name is not the camel-cased field name

This happens due to this assertion: https://github.com/stepancheg/rust-protobuf/blob/34a4ba1cdaccf2612747573d490d731b9fc3600e/protobuf/src/reflect/message.rs#L124
In the Java and Go implementations this restriction doesn't exist. Is there a reason it does here?

Is there a reason it does here?

Sanity check. Can you please provide a case when this assertion fires?
Because if it fires, it means, rust-protobuf does not map field names correctly, and it could be an issue for pure-rust codegen.

Ah, I see, JSON name can be specified in the annotation. It must be a recent thing.
https://developers.google.com/protocol-buffers/docs/proto3#json

I fixed it for protoc-rust in #448, but it looks like it also caught the pure-rust codegen not handling this.

So, yes, pure-rust codegen should be fixed too. Can you do it please or provide some workaround to mute tests and TODO?

Can do later today 👍


FPS issue in pose tracker solution

System information (Please provide as much relevant information as possible)

Have I written custom code (as opposed to using a stock example script provided in MediaPipe): Yes
OS Platform and Distribution (e.g., Linux Ubuntu 16.04, Android 11, iOS 14.4): Android 12
Mobile device (e.g. iPhone 8, Pixel 2, Samsung Galaxy) if the issue happens on mobile device: Realme X7 5G
Programming Language and version ( e.g. C++, Python, Java): Kotlin
MediaPipe version: v0.8.10
Bazel version (if compiling from source): bazel 5.2.0
Solution ( e.g. FaceMesh, Pose, Holistic ): Pose tracker

Describe the expected behavior:
I'm running pose tracker on my device, the Android phone is pretty new one and is capable of 30fps processing. The issue is I'm not getting 30fps on my phone for pose tracker, so when I profiled I'm can see the fps is too low for each calculator (8 FPS).
Trace file -
9.zip
My graph looks like this -
input_stream: "image"

# Output image with rendered results. (GpuBuffer)
# output_stream: "output_video"
# Pose landmarks. (NormalizedLandmarkList)
output_stream: "pose_landmarks"

output_stream: "throttled_input_video"

node {
  calculator: "FromImageCalculator"
  input_stream: "IMAGE:image"
  output_stream: "IMAGE_GPU:input_video"
  output_stream: "SOURCE_ON_GPU:is_gpu_image"
}

# Throttles the images flowing downstream for flow control. It passes through
# the very first incoming image unaltered, and waits for downstream nodes
# (calculators and subgraphs) in the graph to finish their tasks before it
# passes through another image. All images that come in while waiting are
# dropped, limiting the number of in-flight images in most part of the graph to
# 1. This prevents the downstream nodes from queuing up incoming images and data
# excessively, which leads to increased latency and memory usage, unwanted in
# real-time mobile applications. It also eliminates unnecessarily computation,
# e.g., the output produced by a node may get dropped downstream if the
# subsequent nodes are still busy processing previous inputs.

# https://github.com/google/mediapipe/blob/4a20e9909d55838d5630366ce719844cf06ae85c/mediapipe/calculators/core/flow_limiter_calculator.cc#L39
node {
  calculator: "FlowLimiterCalculator"
  input_stream: "input_video"
  input_stream: "FINISHED:pose_landmarks"
  input_stream_info: {
    tag_index: "FINISHED"
    back_edge: true
  }
  output_stream: "throttled_input_video"
  options: {
    [mediapipe.FlowLimiterCalculatorOptions.ext] {
      max_in_flight: 1
      max_in_queue: 1
    }
  }
}

# Subgraph that detects poses and corresponding landmarks.
node {
  calculator: "PoseLandmarkGpu"
  input_side_packet: "ENABLE_SEGMENTATION:enable_segmentation"
  input_side_packet: "MODEL_COMPLEXITY:model_complexity"
  input_side_packet: "SMOOTH_LANDMARKS:smooth_landmarks"
  input_side_packet: "USE_PREV_LANDMARKS:use_prev_landmarks"
  input_stream: "IMAGE:throttled_input_video"
  output_stream: "LANDMARKS:pose_landmarks"
  output_stream: "SEGMENTATION_MASK:segmentation_mask"
  output_stream: "DETECTION:pose_detection"
  output_stream: "ROI_FROM_LANDMARKS:roi_from_landmarks"
}

I'm using pose_detection.tflite and pose_landmark_litetflite.
Other info / Complete Logs :
Include any logs or source code that would be helpful to
diagnose the problem. If including tracebacks, please include the full
traceback. Large logs and files should be attached:
Trace file -
9.zip

Hey @Gojo1729,
Unfortunately I'm not involved in the pose tracker development, so it's hard to tell why is it giving you 9 FPS. I agree that Realme X7 5G is a decent Android phone (geekbench), so I'd be expecting 30 FPS from it too - but I'm not sure I fully understand the current performance profile for the pose tracker
@ivan-grishchenko any ideas?

Hey @ivan-grishchenko any suggestions ?

@ivan-grishchenko any suggestions on this ?

Hi @Gojo1729 ,
MediaPipe graphs will queue/drop frames when the input is faster than the system can handle.
The more powerful the device (or more simple the graph), the less frames dropped/queued, the higher fps can be achieved.

Hi @sureshdagooglecom ,
I know that Medipipe handles the FPS based on the device it's running on, but my device is a new one and it's capable to handle 30fps easily. https://browser.geekbench.com/android_devices/realme-7-5g, I am able to run face detection in 30fps

Hi @kostyaby , is there anyone who can provide some insights on this ?

bazel build -c opt

@luan78zaoha You mean while building AAR file ? I am already using that -
bazel build -c opt --strip=ALWAYS     --host_crosstool_top=@bazel_tools//tools/cpp:toolchain     --fat_apk_cpu=arm64-v8a,armeabi-v7a     --legacy_whole_archive=0     --features=-legacy_whole_archive     --copt=-fvisibility=hidden     --copt=-ffunction-sections     --copt=-fdata-sections     --copt=-fstack-protector     --copt=-Oz     --copt=-fomit-frame-pointer     --copt=-DABSL_MIN_LOG_LEVEL=2     --linkopt=-Wl,--gc-sections,--strip-all     //mediapipe/java/com/google/mediapipe/solutioncore:solution_core.aar
and even while building the graph -  bazel build -c opt mediapipe/graphs/pose_tracking:pose_tracking_gpu

@ivan-grishchenko Any updates on this ? 🙏

We are also having around 5-10fps, with a very similar graph to @Gojo1729 's, across multiple decent Android devices (samsung A11, samsung A70 etc). (Same model runs quite fine on iOS; around 60fps on XR).  Is this expected?

Hello @Gojo1729,
We are upgrading the MediaPipe Legacy Solutions to new MediaPipe solutions However, the libraries, documentation, and source code for all the MediapPipe Legacy Solutions will continue to be available in our GitHub repository and through library distribution services, such as Maven and NPM.
You can continue to use those legacy solutions in your applications if you choose. Though, we would request you to check new MediaPipe solutions which can help you more easily build and customize ML solutions for your applications. These new solutions will provide a superset of capabilities available in the legacy solutions. Thank you


WEB app works in release but not when deployed on NGINX

Steps to Reproduce

Hi, I'm getting a strange behaviour with flutter web.
The app runs perfectly in debug, profile and release on the device that build it.
When deploying the app on NGINX running on a linux server, other laptops and phones are getting grey widgets and the following error in the console :
Another exception was thrown: Instance of 'minified:fn'
Today I added Sentry to see if it would cath any errors :
I'm getting a NoSuchMethodError: method not found: 'toString' on null on every AppBar back button or showModalBottomSheet.
Disclaimer, i'm never using a toString() method in my code.

Logs

[✓] Flutter (Channel beta, 1.20.0-7.2.pre, on Linux, locale C.UTF-8)
• Flutter version 1.20.0-7.2.pre at /root/snap/flutter/common/flutter
• Framework revision a2bde82fbd (4 days ago), 2020-07-18 15:16:35 -0700
• Engine revision 60b269d898
• Dart version 2.9.0 (build 2.9.0-21.2.beta)
[✗] Android toolchain - develop for Android devices
✗ Unable to locate Android SDK.
Install Android Studio from:
https://developer.android.com/studio/index.html
On first launch it will assist you in installing the Android SDK
components.
(or visit https://flutter.dev/docs/get-started/install/linux#android-setup
for detailed instructions).
If the Android SDK has been installed to a custom location, set
ANDROID_SDK_ROOT to that location.
You may also want to add it to your PATH environment variable.
[✗] Chrome - develop for the web (Cannot find Chrome executable at
google-chrome)
! Cannot find Chrome. Try setting CHROME_EXECUTABLE to a Chrome executable.
[!] Android Studio (not installed)
• Android Studio not found; download from
https://developer.android.com/studio/index.html
(or visit https://flutter.dev/docs/get-started/install/linux#android-setup
for detailed instructions).
[✓] Connected device (1 available)
• Web Server (web) • web-server • web-javascript • Flutter Tools
! Doctor found issues in 3 categories.

The issue was caused because I was missing the following import in my main
import 'package:flutter_localizations/flutter_localizations.dart';
It was due to the localization package


Remove LookbackDelta and DefaultEvaluationInterval from the global variables of promql

Proposal
Use case. Why is this important?
The behaviour of a PromQL engine should not depend on global variables of the PromQL package, especially when we alter those global variables at runtime.
https://github.com/prometheus/prometheus/blob/0e912faf4f52ed3f803cc18d0ebbd4eb0ba5a8bd/promql/engine.go#L55-L63
Therefore I would like to move them as EngineOpts
https://github.com/prometheus/prometheus/blob/0e912faf4f52ed3f803cc18d0ebbd4eb0ba5a8bd/promql/engine.go#L216-L223

Do you have a particular use case in mind, or just general refactoring? The
last time this came up it was a misunderstanding of storage and PromQL
semantics.
On Sat 1 Feb 2020, 22:44 Julien Pivotto<EMAIL_ADDRESS>wrote:

Proposal
Use case. Why is this important?
The behaviour of a PromQL engine should not depend on global variables of
the PromQL package, especially when we alter those global variables at
runtime.
https://github.com/prometheus/prometheus/blob/0e912faf4f52ed3f803cc18d0ebbd4eb0ba5a8bd/promql/engine.go#L55-L63
Therefore I would like to move them as EngineOpts
https://github.com/prometheus/prometheus/blob/0e912faf4f52ed3f803cc18d0ebbd4eb0ba5a8bd/promql/engine.go#L216-L223
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/prometheus/prometheus/issues/6739?email_source=notifications&email_token=ABWJG5SICCPI6M5GF72SIHDRAXUMRA5CNFSM4KOVUAF2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4IKLTD4Q,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABWJG5UOSIRGFERIMBCQQ23RAXUMRANCNFSM4KOVUAFQ
.

It is general refactoring which I would like to use later to improve testing on these features.
The context one is just general refactoring.

LookbackDelta has been refactored in #6746.


Cannot find module 'graphql/validation/rules/ExecutableDefinitions' from 'xxx/node_modules/graphql-language-service-utils/dist'

Hi,
After get the source, I tried install and build the package, an error pop-up.
Thanks in advance.
The error shows "Cannot find module 'graphql/validation/rules/ExecutableDefinitions' from '/home/major/git/graphiql/node_modules/graphql-language-service-utils/dist'".
Full log:
major@VM-0-16-ubuntu:~/git/graphiql$ npm install && npm run build
npm WARN prepublish-on-install As of npm@5, prepublish scripts are deprecated.
npm WARN prepublish-on-install Use prepare for build steps and prepublishOnly for upload-only.
npm WARN prepublish-on-install See the deprecation note in npm help scripts for more information.

<EMAIL_ADDRESS>prepublish /home/major/git/graphiql
. ./resources/prepublish.sh

npm WARN<EMAIL_ADDRESS>requires a peer of<EMAIL_ADDRESS>|| ^16.0.0 but none is installed. You must install peer dependencies yourself.
npm WARN<EMAIL_ADDRESS>requires a peer of<EMAIL_ADDRESS>|| ^16.0.0 but none is installed. You must install peer dependencies yourself.
npm WARN<EMAIL_ADDRESS>requires a peer of<EMAIL_ADDRESS>but none is installed. You must install peer dependencies yourself.
npm WARN<EMAIL_ADDRESS>requires a peer of<EMAIL_ADDRESS>|| ^0.12.0 || ^0.13.0 but none is installed. You must install peer dependencies yourself.
npm WARN<EMAIL_ADDRESS>requires a peer of<EMAIL_ADDRESS>|| ^0.12.0 || ^0.13.0 but none is installed. You must install peer dependencies yourself.
npm WARN<EMAIL_ADDRESS>requires a peer of<EMAIL_ADDRESS>but none is installed. You must install peer dependencies yourself.
npm WARN optional SKIPPING OPTIONAL DEPENDENCY<EMAIL_ADDRESS>(node_modules/fsevents):
npm WARN notsup SKIPPING OPTIONAL DEPENDENCY: Unsupported platform for<EMAIL_ADDRESS>wanted {"os":"darwin","arch":"any"} (current: {"os":"linux","arch":"x64"})
up to date in 5.732s

<EMAIL_ADDRESS>build /home/major/git/graphiql
bash ./resources/build.sh

src/components/DocExplorer/Argument.js -> dist/components/DocExplorer/Argument.js
src/components/DocExplorer/DefaultValue.js -> dist/components/DocExplorer/DefaultValue.js
src/components/DocExplorer/FieldDoc.js -> dist/components/DocExplorer/FieldDoc.js
src/components/DocExplorer/MarkdownContent.js -> dist/components/DocExplorer/MarkdownContent.js
src/components/DocExplorer/SchemaDoc.js -> dist/components/DocExplorer/SchemaDoc.js
src/components/DocExplorer/SearchBox.js -> dist/components/DocExplorer/SearchBox.js
src/components/DocExplorer/SearchResults.js -> dist/components/DocExplorer/SearchResults.js
src/components/DocExplorer/TypeDoc.js -> dist/components/DocExplorer/TypeDoc.js
src/components/DocExplorer/TypeLink.js -> dist/components/DocExplorer/TypeLink.js
src/components/DocExplorer.js -> dist/components/DocExplorer.js
src/components/ExecuteButton.js -> dist/components/ExecuteButton.js
src/components/GraphiQL.js -> dist/components/GraphiQL.js
src/components/HistoryQuery.js -> dist/components/HistoryQuery.js
src/components/QueryEditor.js -> dist/components/QueryEditor.js
src/components/QueryHistory.js -> dist/components/QueryHistory.js
src/components/ResultViewer.js -> dist/components/ResultViewer.js
src/components/ToolbarButton.js -> dist/components/ToolbarButton.js
src/components/ToolbarGroup.js -> dist/components/ToolbarGroup.js
src/components/ToolbarMenu.js -> dist/components/ToolbarMenu.js
src/components/ToolbarSelect.js -> dist/components/ToolbarSelect.js
src/components/VariableEditor.js -> dist/components/VariableEditor.js
src/index.js -> dist/index.js
src/utility/CodeMirrorSizer.js -> dist/utility/CodeMirrorSizer.js
src/utility/QueryStore.js -> dist/utility/QueryStore.js
src/utility/StorageAPI.js -> dist/utility/StorageAPI.js
src/utility/debounce.js -> dist/utility/debounce.js
src/utility/elementPosition.js -> dist/utility/elementPosition.js
src/utility/fillLeafs.js -> dist/utility/fillLeafs.js
src/utility/find.js -> dist/utility/find.js
src/utility/getQueryFacts.js -> dist/utility/getQueryFacts.js
src/utility/getSelectedOperationName.js -> dist/utility/getSelectedOperationName.js
src/utility/introspectionQueries.js -> dist/utility/introspectionQueries.js
src/utility/normalizeWhitespace.js -> dist/utility/normalizeWhitespace.js
src/utility/onHasCompletion.js -> dist/utility/onHasCompletion.js
Bundling graphiql.js...
Error: Cannot find module 'graphql/validation/rules/ExecutableDefinitions' from '/home/major/git/graphiql/node_modules/graphql-language-service-utils/dist'
at /home/major/git/graphiql/node_modules/browser-resolve/node_modules/resolve/lib/async.js:46:17
at process (/home/major/git/graphiql/node_modules/browser-resolve/node_modules/resolve/lib/async.js:173:43)
at ondir (/home/major/git/graphiql/node_modules/browser-resolve/node_modules/resolve/lib/async.js:188:17)
at load (/home/major/git/graphiql/node_modules/browser-resolve/node_modules/resolve/lib/async.js:69:43)
at onex (/home/major/git/graphiql/node_modules/browser-resolve/node_modules/resolve/lib/async.js:92:31)
at /home/major/git/graphiql/node_modules/browser-resolve/node_modules/resolve/lib/async.js:22:47
at FSReqWrap.oncomplete (fs.js:149:21)

I had the same issue by following the README.md under example folder.

make sure you are using the right version of graphql. ExcutableDefinitions requires graphql-js 0.12 or later


feat(ally x): add convolver for Ally X

add initial files for Ally X convolver, it's been tested already by a few people on discord, but I haven't formally tested it directly on an actual device.
Big thanks to @adolfotregosa for creating the Ally X wav file. Adolfo gave informal permission to redistribute after asking him on discord.
Note, I assume there'll be additional fixes required to fix default HDMI output, etc, as was required for other convolvers like the Legion Go convolver.

add initial files for Ally X convolver, it's been tested already by a few people on discord, but I haven't formally tested it directly on an actual device.
Big thanks to @adolfotregosa for creating the Ally X wav file. Adolfo gave informal permission to redistribute after asking him on discord.
Note, I assume there'll be additional fixes required to fix default HDMI output, etc, as was required for other convolvers like the Legion Go convolver.

The zip file I gave you had all the hdmi and mic and convolver priority files already ready.

The zip file I gave you had all the hdmi and mic and convolver priority files already ready.

@adolfotregosa I remember you had to modify the bazzite hdmi and mic conf files for to get them to work on other distros, since the bazzite conf files didn't work for you. And I'm naively assuming you haven't tested your conf files on Bazzite.
I don't have an Ally X to test with, so I couldn't confirm whether your hdmi and mic configs would work.
All that being said, this was meant to be the initial PR to get the ball rolling for the convolver. Followup PRs can be done for the other parts.

The zip file I gave you had all the hdmi and mic and convolver priority files already ready.

@adolfotregosa I remember you had to modify the bazzite hdmi and mic conf files for to get them to work on other distros, since the bazzite conf files didn't work for you. And I'm naively assuming you haven't tested your conf files on Bazzite.
I don't have an Ally X to test with, so I couldn't confirm whether your hdmi and mic configs would work.
All that being said, this was meant to be the initial PR to get the ball rolling for the convolver. Followup PRs can be done for the other parts. The convolver in this PR is basically a copy of the already existing Ally conf shipped with Bazzite, just with the wav file updated + the node name updated properly.

I'm sure , mywireplumber priorities and will work on bazzite correctly and also fix what I consider and oversight on legion hdmi wireplumber config file. hdmi* will work for every hdmi option , not just stereo. So for the legionGO your guys should change that.


[ISSUE-845] Update contribution guide

Purpose
Resolves #845
Updated Contribution Guide
PR checklist

[x] Add link to the issue
[x] Choose Project
[x] Choose PR label
[ ] New unit tests added
[ ] Modified code has meaningful comments
[ ] All TODOs are linked with the issues
[ ] All comments are resolved

Testing
Provide test details

https://github.com/dell/csi-baremetal/issues/798

Resolves #845

@aaletov please, add also the valid link in use devkit section - https://github.com/dell/csi-baremetal/blob/master/devkit/README.md

@safronovD Done

Hi @aaletov please, sign your commits for passing DCO test


use eq rather than startswith which returns a list of resources

The startswith function returns a list of resources, should use eq instead, see below screenshot.
Will add test for accesspackageresource later on quite possibly in a separate PR.

@manicminer can you please take a look? Thanks.


Change in ActionButton class

I added a case for ActionEvent.ActionMove in the onTouchEvent method to check if the event takes place outside the view bounds. If this is true I set the state back to Normal.

Hello matias2425,
Thanks for your contribution!
However, this issue has been fixed already in branch 1.1.0 and soon will be merged with trunk and released
Check for updates


Add refund method to some gateways that do referenced credits

@Soleone and @titanous for review

Looks great!

:+1:


[types] Ensure string is checked before other types

Description
In Javascript, the types are erased, so inputs may not have the types associated.  However, string can still be checked, so all inputs should first be checked for if it's a string, then fall back on other options.
This was often manifesting as:
"TypeError: Cannot read properties of undefined (reading 'startsWith')",
    "    at n.fromString (file:///var/task/node_modules/@aptos-labs/ts-sdk/dist/esm/chunk-BZMO6Q6L.mjs:1:422)",
    "    at n.fromHexInput (file:///var/task/node_modules/@aptos-labs/ts-sdk/dist/esm/chunk-BZMO6Q6L.mjs:1:879)",
    "    at new r (file:///var/task/node_modules/@aptos-labs/ts-sdk/dist/esm/chunk-NUBFOYQZ.mjs:1:1038)",
    "    at Runtime.handler (file:///var/task/index.mjs:42:57)",
    "    at Runtime.handleOnceNonStreaming (file:///var/runtime/index.mjs:1173:29)"

Test Plan
Tested by replacing one of the AccountAddress shortcuts with a toString()
Related Links

I am confused about this change and if it is even a fix. Tests seem to pass if passing in a string/non-string from a js file before this change. Also, the description error complains on passing in an undefined

Yeah, this was my mistake.
The real question is if we want to bother protecting against undefined everywhere, or just leave it to the user to not mess up.


reconciliation for git source stuck with growing workqueue_unfinished_work_seconds

Hi,
On my flux installation in AWS EKS, version
flux: v2.1.2
helm-controller: v0.36.2
image-automation-controller: v0.27.0
image-reflector-controller: v0.23.0
kustomize-controller: v1.1.1
notification-controller: v1.1.0
source-controller: v1.1.2

periodically I see source-controller being stuck and not completing/starting any reconciliation on git sources, while helm sources seems running fine.
I can't find anything in the source controller log during the time or before workqueue_unfinished_work_seconds starting to grow.

Any pointers on where to look to find a solution?
Or what information might help to dig deeper

Do you see anything in the controller logs? Please use --log-level=debug. Please also check your consumption metrics. It would also help to have a git repository description.

I came across this issue researching about the "unfinished" metric. Although I am not using flux, my controller had a thread stuck because of https://github.com/kubernetes-sigs/controller-runtime/issues/2231 . For such, I did not have to, but I was recommended to use https://github.com/felixge/fgprof for detecting these kinds of scenario.


Form not displaying

Django 3.0, all requiments installed.
settings:
LANGUAGE_CODE = 'cs'
LANGUAGES = (
('cs', 'Čeština'),
('en', 'English'),
)
template:
{% csrf_token %}
{{ form.media }}
{{ form }}
javascript error:
TypeError: MutationObserver.observe: Argument 1 is not an object. recurrence-widget.init.js:7:11
 https://localhost:8000/static/recurrence/js/recurrence-widget.init.js:7
jQuery 2
mightThrow
process
Please, can you help me?

I had the same problem, it's looking for an element with an id of container so just put one in your html somewhere.


use_enum_values causes mypy failures, since mypy still expects an enum instance rather than the value

Checks

[X] I added a descriptive title to this issue
[X] I have searched (google, github) for similar issues and couldn't find anything
[X] I have read and followed the docs and still think this is a bug

Bug
Output of python -c "import pydantic.utils; print(pydantic.utils.version_info())":
             pydantic version: 1.9.0
            pydantic compiled: True
                 install path: /usr/local/lib/python3.9/site-packages/pydantic
               python version: 3.9.9 (main, Dec 21 2021, 10:24:34)  [GCC 8.3.0]
                     platform: Linux-5.11.0-41-generic-x86_64-with-glibc2.28
     optional deps. installed: ['typing-extensions']
...

When using use_enum_values, mypy (v0.931) still expects fields defined as enums to be instances of the enum, rather than instances of the enum value's type.
A minimal example:
import pydantic
from enum import Enum

class FishEnum(Enum):
    RED = "RED"
    BLUE = "BLUE"

class Model(pydantic.BaseModel):
    fish: FishEnum

    class Config:
        use_enum_values = True

model = Model(fish="RED")
fish: str = model.fish
assert isinstance(model.fish, str)

Here, the assertion passes (model.fish is indeed a str).  However, mypy reports the assignment on the previous line as an error:
test.py:16: error: Incompatible types in assignment (expression has type "FishEnum", variable has type "str")
Found 1 error in 1 file (checked 1 source file)

Expected behavior: when using use_enum_values, I'd expect mypy to expect the enum value's type for enum fields.
This mypy behavior is mentioned as a side-note in  #1917, however that issue and the discussion around it pertains to a feature request for an alternative to use_enum_values.  This issue is just about pydantic's current behavior with use_enum_values as it is -- the current implementation is incompatible with mypy.

Enums are weird things in Python and type checkers do special casing around them. Some of these issues can be alleviated if you make it a class FishEnum(str, Enum). To make mypy not complain about Model(fix="RED") we'll need to make changes to the MyPy plugin, contributions in this area are welcome.

I see there is a lot of interest in this issue, and that's very important to use.
But I also want to point out that this is probably an anti-pattern in terms of integration with tooling, etc:
When you have
class FishEnum(Enum):
    RED = "RED"
    BLUE = "BLUE"

FishEnum.RED and other instances of FishEnum are fundamentally not strings, as @adriangb noted. And when you annotate an attribute as having type FishEnum, it means to python tooling that that attribute will have that type.
As @adriangb noted, we would be open to a pull request modifying the mypy plugin to handle this correctly, but that will only affect usage of the pydantic mypy plugin. It won't affect VSCode/PyCharm, won't affect other type-checkers, and won't match the behavior people with other python-typing experience would expect.

Of course, if it's an internal codebase that you own and don't care what other people think, and you don't care how those other tools behave, maybe this is the best option. But I would strongly encourage the use of @adriangb's suggestion of class FishEnum(str, Enum) (or use of IntEnum as appropriate) as a better solution than the pydantic use_enum_values config setting.
Another alternative that may work instead would be FishEnum = typing.Literal["RED", "BLUE"]. (Or typing_extensions.Literal in older python versions.)

Note that the use_enum_values config flag was added to pydantic in v0.7.0, over five years ago(!). Back then, typing had much less widespread adoption, and the PEP adding Literal to typing wouldn't even be created for another year.
I think given the way the ecosystem has evolved, if we were creating the library from scratch today, we probably wouldn't add the use_enum_values config flag at all and would encourage people to use class StrEnum(str, Enum): (or StrEnum in 3.11)/IntEnum/Literal to work around these issues.


Shaun

I wondered what I was really worth after getting rejected by two silicon valley startups.  So I decided to stop giving up on my side projects.

Wow.. so many great projects on your site -- thanks!


[New Port Request] agones C++ server client sdk

Library name: agones C++ server client SDK
Library description:
Agones is a library for hosting, running and scaling dedicated game servers on Kubernetes.
The SDKs are integration points for game servers with Agones itself.
and it is C++ SDK.
Source repository URL:
https://github.com/googleforgames/agones/tree/release-1.28.0/sdks/cpp
Project homepage (if different from the source repository):
https://agones.dev/site/
https://agones.dev/site/docs/guides/client-sdks/cpp/
Anything else that is useful to know when adding (such as optional features the library may have that should be included):

If you wish to add this port in the future, you can reopen this issue, but we're closing it for now.


Fix Convert Date

Halts the functionality when not in debug mode.

Strange how this one got missed!!! thx.


Puback iscalled too soon on incoming publish message

With QoS 1 I expect that when my app crashes while processing incoming message, after my app starts again I will receive the message again. At least that's how I understand "at least once" delivery.
After my testing I looked at the code: connection.rs#L546 and realized this is not the case. Puback is sent right after publish packet is received, so there is no chance the app can persist and not lose the packet in case of crash. I believe this is wrong.
One way would be to call puback(pkid) only after on_message handler finishes.
Other way would be to give user a way to call puback(pkid) explicitly.

@tomasol When Mqtt protocol says At least once, that doesn't mean mqtt broker has to hold the message until client is done processing the message. I just means that broker has to hold the message until client receives the message. This helps the client to be robust in bad networks. At least that's what I understood.
I feel there is a reason why mqtt is this way

What if your code always panics while handling the message? Broker has to hold the message forever because the user code is wrong?

Maybe it's debatable why not but it'll be a different protocol. Spec clearly says message arrives at the receiver
http://docs.oasis-open.org/mqtt/mqtt/v3.1.1/os/mqtt-v3.1.1-os.html#_Toc398718101

Thanks for response.

What if your code always panics while handling the message? Broker has to hold the message forever because the user code is wrong?

There is already a window of opportunity for that, e.g. if processing incoming pub packet fails (I mean in any library, not yours in particular). QoS cannot protect you from bugs, so I think that is out of scope.
It should however protect from losing messages due to power/network outage. If the outage happens before puback is sent & received, broker just resends the message. If however the outage happens while I try to persist the data, I may never be able to recover it. There are applications where it does not matter, but most applications would not work correctly under these circumstances.
Spec says:

In the QoS 1 delivery protocol, the Receiver
MUST respond with a PUBACK Packet containing the Packet Identifier from the incoming PUBLISH Packet, having accepted ownership of the Application Message

IMO this is clear rerefence of owning the data and being responsible for persisting it if needed.
It is even more obvious for QoS2 but let's not get into that. Also, there are mqtt libraries that have persistence for QoS right in their design, e.g. paho java client

Thank you for your response. We can probably agree that the spec leaves some room for interpretation, ultimately it is the application's responsibility to decide what's the correct behavior for its use case.

I feel it's the other way around. Lot of client applications will be okay to loose data during power outages/crashes but for some it's not an option

It's hard to say what percentage of apps tolerate data loss, I just think it would be nice to have the ability to decide when the ack should be sent. Some libraries support persistence, some don't. I like the way the java client handles it - not only is there the mentioned persistence api, but you can use a callback that gets called before puback is sent. Also it is possible to turn on manual acks for even finer control.
Either one of those options would be sufficient and would give apps more robustness and protect them from data loss.

@tomasol Agreed. I'll leave this issue open and try to cater this in the new design. Maybe not immediately but eventually I'll add the support to send acks after handling


Ordering filter names should be Korean

Ordering filters names should be Korean.
populatiry -> 인기순
last added -> 게시순
size -> 크기순
alphabetic -> 이름순

close by https://github.com/ParallelSpaceInc/poly-web/commit/607c7931b9d32d1415872f09993a87611e3ef36c


failed to prepare bootstrap ios 15.7

I have a iPhone 6s IOS 15.7 and i did all correctly and when I install pogo that show me an error that is "Failed with -1 are you sure you have AMFI patched? "

and thank to creator and thank that person help me :)

Can you try to cd into the ramdisk directory, then run git checkout cfe0b0f63cd90ab43ba66c9bf44156f1ff766f9d. Then go back in the palera1n folder, remove the blobs folder, then run the script again.

my bro, i did that but it did not work, the same error

thank bro for your time and I can not install trollstore because my version is 15.7 and is not compatible, so what do you recomend me ?

my bro, i did that but it did not work, the same error

Did the ramdisk create again?

thank bro for your time and I can not install trollstore because my version is 15.7 and is not compatible, so what do you recomend me ?

You can use SSHRD_Script to install TrollStore to Tips, and it’ll work while palera1n is booted.

my bro, i did that but it did not work, the same error

Did the ramdisk create again?

thank bro for your time and I can not install trollstore because my version is 15.7 and is not compatible, so what do you recomend me ?

You can use SSHRD_Script to install TrollStore to Tips, and it’ll work while palera1n is booted.

thank now that work i install that with trollstore thankyou

I have the same issue like this, TrollStore and Pogo installed but unable to install bootstrap (possibly because I could not boot the device as amfi patched). Tried to run palera1n several times but the device always reset before the script finished. Here is partial of the log:
[*] Dumping blobs and installing Pogo 16195+189 records in 16375+1 records out 4192018 bytes transferred in 0.203440 secs (20605672 bytes/sec) ./palera1n.sh: line 119: 25142 Terminated: 15          "$dir"/iproxy 2222 22 >&"$out" >> "$out" [*] Switching device into recovery mode... ERROR: No device found! ERROR: No UDID specified

you must put in mode recovery when say ] Switching device into recovery mode

On Mon, 10 Oct 2022 at 3:45 AM, edwin @.***> wrote:

you must put in mode recovery when say ] Switching device into recovery
mode
—
Reply to this email directly, view it on GitHub
https://github.com/palera1n/palera1n/issues/63#issuecomment-1272639389,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/A3LOKVS6PAH7NUNV2V7UCQTWCM7WVANCNFSM6AAAAAAQ2COEIQ
.
You are receiving this because you are subscribed to this

[*] Walting for device in DFU mode

[*] Getting device info..
this may take a second
ing4tool version: 0.197-aca6cf005c94caf135023263cbb5c61a0081804f-RELEA
Compiled with plist: YES Saved IM4M to work/IM4M
libfragmentzip version: 0.60-120447d0f410dffb49948fa155467fc5d91ca3c8 init
pzb: null
[-] uploading logs, if this falls, it's not a big deal.
mv: cannot stat
*.log': No such file or directory Verston
3fc8c093f4660f6c6e07c0c9214618733da01ffc - 36 Error init failed
[-] An error occurred


Issue running bot

Hi there,
Having issues running the bot I have the .env in the directory with the following
DISCORD_TOKEN=BOTTOKENISHERE

The offending line of code would probably be line 30 as that's actually grabbing the env variable. It's const token = process.env['DISCORD_TOKEN'];
I can't see any particular reason why that wouldn't work if it's defined in your environment. You could try debugging dotenv with the steps listed here: https://stackoverflow.com/questions/26973484/how-do-i-setup-the-dotenv-file-in-node-js
If you're not too bothered by it, you can also just hardcode the bot token there.

adjusted code to suit as below
const token = "YOURBOTCODE HERE";

Would be good to see charts implemented at all?

Hi,
Not at this time, I don't have plans for it.
Feel free to submit a change request if you can do it.


Modify lint tool to add 'informative' warnings separate from errors

Also, change the lint tool to report mismatches of general category / glyph class (for marks) as warnings instead of errors.  See excerpt from email thread below.

We are often in a quandry when matching the Unicode sub-classification
of marks to OpenType classes.

I'd argue that there is no requirement to match them, since they serve different purposes. The classification of mark in GDEF is something that enables particular kinds of glyph-level operations that have nothing to do with character level classification

I suggest either removing this from the Lint testing or identifying such reports as informative rather than as errors.

Nice!


Add project metadata to the gemspec

Add bug_tracker_uri, changelog_uri, documentation_uri, and source_code_uri to the gemspec metadata.
These project metadata will facilitate easy access to project information. The URI will be available on the Rubygems project page, via the rubygems API, and the gem and bundle command-line tools with the next release.

@orien thanks!

@dblock: Apparently they need to be strings:

All keys and values must be Strings

https://guides.rubygems.org/specification-reference/#metadata


Add iid field

I'm using entity references in my level and the instance id isn't included. This updates the importer to include instance id.

And the data itself:

It was added in 1.0: https://ldtk.io/docs/game-dev/json-overview/unique-identifiers/#string-iids-aka-“instance-identifiers”

I had to fix some indentation that was done with spaces instead of tabs


Updating PR template

Summary of the Pull Request
What is this about?
due to a few recent misses, going to be a bit more rigorous.  Chatting with @enricogior in email, we believe directly calling out some of these things and being a bit more direct in the PR will provide needed items to be addressed like signing DLLs and the installer

WSX or WXS?

@davidegiacometti
thanks for pointing it out.


Test Only: Classify SIPNOX as a Ozone Program

Definition of Ready

[x] Does this meet the INVEST criteria?
[x] Does this have a clearly defined user?
[x] Does this have an estimate?
[x] Does this have acceptance criteria?
[x] Does this have sufficient context for the specific functionality being developed (design, business rules, etc.)
[x] Does this have a dev link been provided in the design?
[x] Is this traceable to a feature, epic, or PI?

User Story
As a custom data download user I want SIPNOX classified as a ozone program So that it is categorized correctly
Acceptance Criteria
Given that a user has made a get request to the programs MDM endpoint
When SIPNOX is displayed
Then the ozone indicator is set to true
AND the annual indicator is set to false
Given that a user has navigated to the custom data download
When the program functionality is displayed
Then SIPNOX is classified as a ozone program
Development Notes
Does this Story require 508 Testing?

[ ] Implementing a new authoring tool that will produce code / content for the application
[ ] Implementing a 3rd party widget that will be part of the application
[ ] Adding new / updating custom functionality
[ ] Adding new / updating a page template
[ ] Adding new / replacing existing functionality (unless the replacement has already passed 508 testing)
[ ] Full Site Review prior to a scheduled EPA 508 review
[ ] Planning a video that will appear on the application
[ ] Producing a video that will appear on the application
[ ] Producing Training materials
[ ] Producing documents

Context
[1:08 PM] Lageman, Travis
Jason Whitehead (Guest) janell coleman (Guest) Heese, Michael A while back I noticed that the SIPNOX program was being returned in the database (NCC side) as an annual program, when it is in fact an ozone program. The change was delayed since ERG was busy with other work, but they have since made the change. Therefore, the SIPNOX program now needs to be updated on the cloud side so that it properly displays in CAMPD's UI. The required change would be for SIPNOX to have the ozoneIndicator set to TRUE and the annualIndicator set to FALSE. Let me know if you have any questions. thx
Testing
Test Case: TC417
Tester: @JanellC
Definition of Done

[x] Have all Acceptance Criteria been agreed to and validated by the scrum team?
[x] Has the code been unit tested and peer reviewed?
[x] Have the functional tests been executed?
[x] Have all defects been reviewed and dispositioned, resolved, or deferred?
[x] Is the user story ready to be deployed to the test/staging environments?

TC417 passed @tlageman-epa


example/daily_note.md error in cron descriptions

I was trying to understand the cron codes but it wasnt making sense, then i discovered the it was shifted by one line, also it would be worth mentioning that it doesn't use the full cronjob code, only the last three (not time and minutes)

From the README:

{{ obligate * * * }} is a very powerful macro. It lets you set up recurring to-do items in your template. It uses a simplified version of the cron syntax, where the asterisk represent day-of-the-month, month-of-the-year, and day-of-the-week in that order.

Is this insufficient?


What is a Prometheus Domain?

On the metrics naming docs it references a "Prometheus Domain". However, I can't find any more docs on this. I just want some clarity that the naming of the etcd metrics are alright; for example should these be prefixed with etcd_?

rafthttp_message_sent_latency_microseconds
rafthttp_message_sent_failed_total

Yes, those should be prefixed with etcd_. Speaking in terms of the Go client library, you would set namespace = "etcd" and subsystem = "rafthttp" which results in etcd_rafthttp_<name>.
The documentation could be worded better in this case.

@fabxc Thanks for the context! I filed a bug on the etcd repo. I will leave it to you to fixup the Prometheus Domain thing since I really don't know what to replace it with. Maybe we can just replace it with an example of "${namespace}_${subsystem}metric_name${unit}"?

@fabxc
I was confused by the example here:
https://github.com/prometheus/client_golang/tree/master/prometheus.
It shows the namespace is the organization name (for example Google) and the subsystem is the actual system (BigTable).
It is also consistent with the example in the go-client example:
https://github.com/prometheus/client_golang/blob/master/examples/random/main.go#L53
So the component (RPC) within the system (It is unnamed in that case) is actually prefixed within the name.
And this is also how k8s/etcd uses it:
https://github.com/GoogleCloudPlatform/kubernetes/blob/master/pkg/apiserver/apiserver.go#L54
https://github.com/coreos/etcd/blob/master/rafthttp/metrics.go#L28
If I use namespace = "etcd" and subsystem = "rafthttp" , this is not quite similar to the example.
So I am still not quite sure if we should do subsystem = "etcd", name = "rafthttp_abc" or follow what you just said.
At least, we can make the example more clear. :)
Thanks

I also looked at the code in soundcloud/roshi. It seems to use namespace as a way to resolve the conflict the metrics. The namespace is passed in via command line flag.
Can you please help to clarify the best practice here?

From the perspective of the Prometheus server, the metric name is an
opaque string. What we are talking here are merely naming conventions
(but nevertheless important ones).
The only non alphanumerical character allowed in names are "" and
":". ":" is used for rules and should never be used in raw metric
names. "" is the natural separator for name components. Some client
libraries suggest a structure like <the_rest>,
but the first two components are optional. This is mere convenience
(or "eductational", if you want). In client_golang, the following
three will all result in the same metric name "foo_bar_baz":
prometheus.GaugeOpts{
Name: "foo_bar_baz",
Help: "I am helpful.",
}
prometheus.GaugeOpts{
Namespace: "foo",
Name: "bar_baz",
Help: "I am helpful.",
}
prometheus.GaugeOpts{
Namespace: "foo",
Subsystem: "bar",
Name: "baz",
Help: "I am helpful.",
}
For example, there is a convenience function in client_golang to
instrument HTTP endpoints. It uses by default
http_request_duration_microseconds as a metric name, and the /metrics
endpoint is by default instrumented with it. It makes sense because
you want to track HTTP request durations in general.
However, Prometheus exposes all the specific metrics about itself with
the prefix "prometheus_" followed by a subsystem, if applicable. E.g.
all the nice and interesting (for the storage developer) metrics about
the Prometheus local storage start with "prometheus_local_storage_".
Example: "prometheus_local_storage_ingested_samples_total".

Summed up, the recommended way for etcd as an open source project and under consideration of its size would be etcd_<subsystem>_<name>. That's also what the common exporters for haproxy, consul, and others do by default.
We will try to get our documentation more clear and consistent in this regard.

@fabxc Thank you! I will change the naming in etcd!

Lgtm thanks!
On May 22, 2015 5:59 AM, "Björn Rabenstein"<EMAIL_ADDRESS>wrote:

Closed #82 https://github.com/prometheus/docs/issues/82 via ccebb61
https://github.com/prometheus/docs/commit/ccebb61d2dde23362d4fd1da342fc1008f6c6b26
.
—
Reply to this email directly or view it on GitHub
https://github.com/prometheus/docs/issues/82#event-311641996.


ViewComponentResult should check if the response has already been sent before setting the ContentType

Short story:
I'm trying to combine multiple different ViewComponents in one single response. It renders the first viewcomponent but always fails on any succeeding call to vc.ExecuteResultAsync(context).
Long story:
I'm trying to combine multiple different ViewComponents from a controller. The ActionResult of all combined viewcomponents will be rendered to the browser. This is based on an article which does this with PartialViews and updates the PartialViews with ajax. That article is based on previous version of MVC. For more info see: https://www.simple-talk.com/dotnet/asp.net/revisiting-partial-view-rendering-in-asp.net-mvc/
After many hours I came to the following code example. But the problem is that it works only for the first viewComponent. When I change the order of viewcomponents it still renders the first one. So it doesn't seem to have anything with my viewcomponents. Always at second loop it ends at "vc.ExecuteResultAsync(context);" with no errors. So rendering the first one is always successful.
By the way I'm using VS 2015 Enterprise with Beta7 of MVC6 and all other dependencies.
Please see this stackoverflow question: http://stackoverflow.com/questions/32468238/combine-viewcomponents-in-asp-net-5-mvc-6
I guess it is in some way related to this issue: Fix #2338 - Add ViewComponentResult
// in controller class
public async Task<IActionResult> Dashboard()
    {
        // Combine multiple viewcomponents
        return new MultipleViewResult(
            ViewComponent(typeof(OrdersViewComponent))
            , ViewComponent(typeof(AccountsViewComponent))
            );
    }

    public class MultipleViewResult : ActionResult
    {
    public const string ChunkSeparator = "---|||---";
    public IList<ViewComponentResult> ViewComponentResults { get; private set; }
    public MultipleViewResult(params ViewComponentResult[] views)
    {
        if (ViewComponentResults == null)
        {
            ViewComponentResults = new List<ViewComponentResult>();
        }

        foreach (var v in views)
            ViewComponentResults.Add(v);
    }

    public override async Task ExecuteResultAsync(ActionContext context)
    {
        if (context == null)
            throw new ArgumentNullException(nameof(context));

        byte[] chunkSeparatorBytes = System.Text.Encoding.UTF8.GetBytes(ChunkSeparator);
        var total = ViewComponentResults.Count;
        for (var index = 0; index < total; index++)
        {
            var vc = ViewComponentResults[index];

            // No matter which viewcomponent, this line works only with the first viewcomponent.
            await vc.ExecuteResultAsync(context);

            if (index < total - 1)
            {
                await context.HttpContext.Response.Body.WriteAsync(chunkSeparatorBytes, 0, chunkSeparatorBytes.Length);
            }
        }
    }
}

@rynowak any thoughts on this one?

This is the offending line. I personally think it is a good idea to leave it the way it is, that is, it causes an exception. A more specific exception should be thrown however. I also believe that the response's ContentType property should be checked and only set it if the ViewComponentResult's ContentType property is different to the response's ContentType property - this I think is what needs to be done to fix this issue
if (!String.Equals(response.ContentType, contentType.ToString(), StringComparison.Ordinal))
{
    if (response.HasStarted)
    {
        throw new AMoreSpecificException("Cannot set ContentType when response has already sent.");
    }

    response.ContentType = contentType.ToString();
}

We can do for ViewComponentResult what we did recently for ViewResult - which is to ignore the content type if it has been set.
This is really done in support of scenarios like this:
public IActionResult MyAction(...)
{
    HttpResponse.ContentType = "text/plain";
    return new ViewComponentResult(...);
}

If you're building any type of framework on top of view components where they are used to render chunks of the page, it's totally off-road.

Changes here b544aabfdb4b6e1612bece65217f35500365a9fa will prevent a view component from trying to set the content type to the default value if it's already been set.
It feels worth mentioning again, this change is something we were happy to do because it's a good semantic for the result-type to have and is consistent with ViewResult and PartialViewResult.
We're not in-general looking to support building another framework layer out of view components.


Bug with some epsg values in Datum.cs

This issue was imported from CodePlex
JamesPP wrote 2012-01-13 at 17:47
Some epsg values (for example 3765) crash when initializing.
The issue seems to be that the Proj4 string is:
EPSG:3765 +proj=tmerc +lat_0=0 +lon_0=16.5 +k=0.9999 +x_0=500000 +y_0=0 +ellps=GRS80 +towgs84=0,0,0,0,0,0,0 +units=m +no_defs
The issue is I suspect with any string that has a +towgs84 with 7 params that are all 0. The following line sets the DatumType to be of Param3 (though I'm not clear why this is needed ??)
// checking to see if several blank values were included.
if (_toWgs84[3] == 0.0 && _toWgs84[4] == 0.0 &&
_toWgs84[5] == 0.0 && _toWgs84[6] == 0.0) _datumtype = DatumType.Param3;
This then causes a subsequent array out of range error as it looks for a towgs parameter past 3.
Changing the DatumType.Param3 ot .Param7 appears to fix it for these epsg codes (or just commenting out the lines) but may cause problems for other projections presumably.
Note there appears to a related (but different?) issue mentioned in:
http://dotspatial.codeplex.com/workitem/407

Not reproduced.


Add files via upload

Yenilikci Ogrenme Merkezi domain was added.

@onurtokgoz Pull request merged. Thank you!


Hacktoberfest 2020 summary

This repo received 1,314 @Hacktoberfest PRs and merged 559 (39%) of them (merges from 304 individuals)! Thanks everybody! @saritip, @GintasS, @LeoTino, @kadhirash, @ch-a-nd-a-n, @chessboards, and @harsh-kk had 6 or more commits merged. Thanks everyone, and I hope many of you didn't just do it for the t-shirts.
We created a cheatsheet page, added several course pages, several translated "ABOUT" and "CONTRIBUTING" pages, and vastly expanded our Indonesian pages.
Now that Hacktoberfest is over, it's time to tell the world! Post to social media, tell your friends, and brag about how you are part of one of the top ten starred repos out of tens of millions on GitHub (you did ⭐  the repo, didn't you?)
But don't stop there. Your contributions to Open Source benefit the whole world. For many of the 304 hacktoberists, this was a first contribution. Don't let it be their last!
If we didn't merge your commit, please forgive the very small team that triaged, reviewed, and merged the contributions. We had no idea we would get so many contributions. We can improve our documentation and our automation based on what we learned. Come back next year. Come back this month. Come back tomorrow.
Also consider sponsoring us. We are a charitable non-profit based in New Jersey, USA, Planet Earth.

Surely sir I am on my way to my nest repo.

I personally did it for the tree, way better than a t-shirt in my opinion. Thanks for you and the team for reviewing PRs!

It was a wonderful experience! Looking to contribute more and help clean the PR's! 😄

Update: Together with a small team of volunteers, we were able to review every one of the 1314 PRs from October. Some of the suggestions were not appropriate to the project, but now that the dust has settled, we have accepted 55% of the PRs submitted during Octoberfest. The 338 open-source enthusiasts whose changes we accepted come from all over the world, and for many of them, these represented their first ever contributions to open source. We sincerely hope that they will continue to enrich the world's information commons.
Free-Programming-Books now contains 3,770 links to free books, 1,254 free courses, and 822 other resources. There are lists of books in 35 spoken languages and courses in 20 of them. The list covers over 200 programming languages and platforms. October saw major expansions of our lists for Indonesian, Hindi, Tamil, and Portuguese readers.


Enhancement support recording table name and index name in audit log

Proposed changes
Issue Number: close #xxx

add a field queryTables in edit log to record table name and index name for a query
Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

run buildall

run p0

run p0

run p0

You should implement audit logger plugin in same PR, we will release 2.1 now, if this PR is merged and you not implement another PR, then 2.1 could not be released.

run buildall

You should implement audit logger plugin in same PR, we will release 2.1 now, if this PR is merged and you not implement another PR, then 2.1 could not be released.

I had add a new field in audit log plugin.

If a user is using doris 2.0 and using audit log plugin to load the log into doris table. If he upgrade doris 2.0 to doris 2.1 and there is a new column tables, what should he do??? I think there is a upgrade process and maybe need a doc.


Is there a way to avoid the default values validation during the compilation?

Hello and thanks for this library. I very much appreciate the effort and time you have put into this library.
I have a question. Is there a way to avoid the default values validation during the compilation?
I do not need default values; So I have defined the struct with default nil values for each attribute. But the type I have defined includes some mandatory attributes. I received the error "Invalid value nil for field :name of %TestApp.User{}. Expected the value matching the <<::*8>> type." during the compilation.
I want only to validate data during the struct creation. I do not need to validate the default values because they can be incomplete, like in my case.
Thank you for your answer.

Hey, thanks for the good words.
The library validates struct defaults to guarantee the valid state when the struct is instantiated with %User{} syntax.
Giving no default values at all sets them to nil and causes the failure of the compilation due to type spec mismatch.
Sometimes valid default values may not be known at the compile-time and such failure doesn't fit 🙂
That can be addressed in the following alternative ways:

Support the nil values with name: String.t() | nil definition in type spec explicitly.
Configuring the library to skip this kind of validation for the given struct with use Domo, ensure_struct_defaults: false
Disable the struct defaults validation for the whole project by adding config :domo, :ensure_struct_defaults, false into config.exs.

Thanks for your tips. I understand your reason for that behavior, but I mostly have incomplete default values in my models. Your recommendations are working for me, that is good.
I started to play with your library two days ago, and it looks constructive to me. I stay in testing it for my use cases, and I hope I could use it in production. Thanks for that and for your help again.


Konacha fails if browser uses extensions that add iframe

I experience:
Uncaught SecurityError: Blocked a frame with origin "http://localhost:3500" from accessing a frame with origin "chrome-extension://noojglkidnpfjbincgijbaiedldjfbhh".  The frame requesting access has a protocol of "http", the frame being accessed has a protocol of "chrome-extension". Protocols must match.

in google chrome in code:
// Check that all iframes loaded successfully.
  var iframes = document.getElementsByTagName('iframe');
  for (var i = 0; i < iframes.length; ++i) {
    if (!iframes[i].contentWindow.mocha) {
      (function (path) {
        mocha.suite.addTest(new Mocha.Test(path, function () {
          throw new Error("Failed to load " + path + ".\n" +
                          "Perhaps it failed to compile? Check the rake output for errors.");
        }));
      })(iframes[i].getAttribute("data-path"));
    }
  }

My workaround is to run the tests in incognito window where all extensions are disabled.

I guess the way to work around this would be to check the scheme and host of the iframe before trying to access contentWindow. Happy to accept a pull request that does so.


Error downloading files.

merged_depth >python utils\download_models.py
Traceback (most recent call last):
  File "utils\download_models.py", line 65, in <module>
    main()
  File "utils\download_models.py", line 62, in main
    extract_models(pretrained_models)
  File "utils\download_models.py", line 56, in extract_models
    with zipfile.ZipFile(file, 'r') as zip_ref:
  File "c:\g\vr\lw\python\lib\zipfile.py", line 1258, in __init__
    self._RealGetContents()
  File "c:\g\vr\lw\python\lib\zipfile.py", line 1325, in _RealGetContents
    raise BadZipFile("File is not a zip file")
zipfile.BadZipFile: File is not a zip file

That's odd, seems to work fine for me. Is there a pretrained.zip in that location? The download script first downloads a pretrained.zip file and then extracts the contents to a pretrained folder.
If you're still having difficulty, you can download it from here.

it requires access, sent the request, thank you.
On Mon, Mar 22, 2021 at 11:24 AM Pranav @.***> wrote:

That's odd, seems to work fine for me. Is there a pretrained.zip in that
location? The download script first downloads a pretrained.zip file and
then extracts the contents to a pretrained folder.
If you're still having difficulty, you can download it from here
https://drive.google.com/drive/folders/1seXeHWLaPU1iY14cC9yI6NPqeThL_aUu
.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/p-ranav/merged_depth/issues/1#issuecomment-804149146,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAK5KTOYE3PMTHXKOMP2NR3TE5OKPANCNFSM4ZSWM7WA
.

Should be publicly accessible now. Sorry about that.
You can check again if the script works OK.

Thank you, retrieved file.


[PE-D][Tester A] Phone numbers should not be only limited to 8 digits

There is no mention of the specificity of country or region in the user guide, which means that more regions should be considered when accepting phone numbers. Therefore, limiting phone numbers to exclusively 8 digits excludes people from many other foreign countries.

Labels: severity.Low type.FeatureFlaw
original: Green-Tea-123/ped#5

Updated the UG to include the target audience.


Add PNG download to 2D FTU page per Figma file

Add PNG download to 2D FTU page per Figma file

[ ] Add a PNG Download button on the 2D page  per the Figma spec.

Resources

Google Drive Folder - 2D Illustrations
Figma Design File
GitHub 2D Illustrations

We don't have pre-generated PNG files. Since we are using the SVGs directly for display we could theoretically convert to PNG on the browser on the fly, but I wonder if it would be better to pre-render at specific sizes. @katyb @libby-maier need a decision on this. We can't add PNG until we have PNG files...

Both Rachel and Katy requested PNGs be added. They live in Google Drive. This button was added to the spec during the last illustrator visit in October.

Ok, that's what I needed. @bhushankhope setup a PR on the ccf-releases pages to add the .png files to here: https://github.com/hubmapconsortium/ccf-releases/tree/main/v1.3/2d-ftu . Note that the filenames changed, so please update the png file names to match what is officially published (just with .png). Once merged, then you can easily link to them from the humanatlas portal.


feat: fix aggregation issues.

Use sort key instead of aggregate key for pre-aggregation
Add all potential extra attributes to the sort key so we bucket
properly
Add a version attribute to the table

Associated with Issue #144


Octo pr list: Not possible to filter by branch or author in PR picker

Issue Description
Type: feature request
Describe what happened (or what feature you want)
In the PR picker, there is no way to filter the PRs by author, either when typing or as arguments, and the only way to filter by branch name is as arguments.
This is more important for larger projects where there may be many PRs, and being able to use the generic sorter match against author and branch names would help significantly for projects that follow the convention of putting issue identifiers in the branch name.
Describe what you expected to happen
When I use Octo pr list, and then type my user name, it should show only PRs I created.
Anything else we need to know?

asdfasdfasdfasdf
asdfasdf
asdfasdfj

Agreed here. Adding the author to the line item in the fzf/telescope list would solve this for some teams.

I've been using this command
:Octo search author:USERNAME is:pr is:open


Max retries exceeded with url

Hi,
Firstly, thanks for all the job.
I have wapi install on my NAS on docker. I also have Home Assistant install on docker on my NAS.
When I want to send message like you do in the how to, i have "Max retries exceeded with url".
Whereas I try on postman on my computer, it works well.
Do you have an idea why ?
Thanks

In my config HA, I change IP address with "localhost"


Freezes JupyterLab when opening a CSV from S3

Describe the bug
When I navigate to a CSV file and try to open it, it freezes my Jupyter Lab 2.2.8.
To Reproduce
Steps to reproduce the behavior:
Navigate to a CSV on S3,
Expected behavior
CSV file should load in the Jupyter Lab CSV reader.
Screenshots

Desktop (please complete the following information):

OS: Linux
Chrome
Version of jupyterlab-s3-browser extension: latest

I think it's a problem with the CSV editor extension I use and not having write access to the S3 bucket.  Will remove the editor or use the default Jupyter reader (which works fine).
https://github.com/krassowski/jupyterlab-spreadsheet-editor


Upload/download files

Is your feature request related to a problem? Please describe.
I am frustrated when having to use a different syntax to upload/download files with boto3 compared to AWS Data Wrangler. For example, with boto3, I must create a client or resource and specify a bucket and key, but with AWS Data Wrangler, I can use 's3://path/to/my/file'. There is already functionality in AWS Data Wrangler to copy, delete, list, and read/write specific formats with S3 -- I would like a unified interface which lets me bypass having to use boto3.
Describe the solution you'd like
Add functions under the s3 namespace which allows uploading/downloading files using an s3 path such as 's3://bucket/my/file'. There should be ways to work with objects on disk and potentially in memory. Also need to consider encryption.

Released on version 2.4.0.


correct error receiving for potential bug

It's obvious that in the fatalf statement the errors should come from channel monitorErrch and rotatorErrch ,  and in the case monitor or rotator runs with some errors happening, the log should not be misleading .

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: leowucn
To complete the pull request process, please assign incfly
You can assign the PR to them by writing /assign @incfly in a comment when ready.
The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

security/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Hi @leowucn. Thanks for your PR.
I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test label.
I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@googlebot I signed it!

/ok-to-test

@leowucn: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

integ-new-install-k8s-presubmit-tests-master
cbd143d5056fb2d9e4aa65bdb14e18d4d2446146
link
/test integ-new-install-k8s-presubmit-tests-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/retest

/retest

/lgtm
/approve
do you happen to see one of these two lines got triggered?

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: incfly, leowucn
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

security/OWNERS [incfly]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@incfly No, I just dive into the codebase and found that the two lines would be misleading for debugging.

@leowucn: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

integ-new-install-k8s-presubmit-tests-master
cbd143d5056fb2d9e4aa65bdb14e18d4d2446146
link
/test integ-new-install-k8s-presubmit-tests-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/retest

@leowucn: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

integ-new-install-k8s-presubmit-tests-master
cbd143d5056fb2d9e4aa65bdb14e18d4d2446146
link
/test integ-new-install-k8s-presubmit-tests-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/retest


Samples/app/bookinfo doesn't work

I have deployed the bookinfo sample app but cannot get it to work:
details-v1-3121678156-8mqrv       2/2       Running   0          2d        <IP_ADDRESS>   ip-172-16-195-9.us-west-2.compute.internal
grafana-1395297218-5jrmp          1/1       Running   0          2d        <IP_ADDRESS>   ip-172-16-195-9.us-west-2.compute.internal
istio-ca-4001657623-h8ctz         1/1       Running   0          2d        <IP_ADDRESS>    ip-172-16-195-9.us-west-2.compute.internal
istio-egress-2219665963-7x9v8     1/1       Running   0          2d        <IP_ADDRESS>    ip-172-16-195-9.us-west-2.compute.internal
istio-ingress-2247081378-dhsx8    1/1       Running   0          2h        <IP_ADDRESS>   ip-172-16-195-9.us-west-2.compute.internal
istio-mixer-2450814972-6hg56      1/1       Running   0          2d        <IP_ADDRESS>   ip-172-16-195-9.us-west-2.compute.internal
istio-pilot-1836659236-hh4vj      2/2       Running   0          2d        <IP_ADDRESS>    ip-172-16-195-9.us-west-2.compute.internal
productpage-v1-1440812148-8fmmh   2/2       Running   0          14m       <IP_ADDRESS>    ip-172-16-195-9.us-west-2.compute.internal
prometheus-3067433533-m6c48       1/1       Running   0          2d        <IP_ADDRESS>   ip-172-16-195-9.us-west-2.compute.internal
ratings-v1-3755476866-qx75n       2/2       Running   0          2d        <IP_ADDRESS>   ip-172-16-195-9.us-west-2.compute.internal
reviews-v1-3728017321-8jl70       2/2       Running   0          2d        <IP_ADDRESS>    ip-172-16-196-88.us-west-2.compute.internal
reviews-v2-196544427-lg91b        2/2       Running   0          2d        <IP_ADDRESS>   ip-172-16-195-9.us-west-2.compute.internal
reviews-v3-959055789-121mr        2/2       Running   0          2d        <IP_ADDRESS>   ip-172-16-195-9.us-west-2.compute.internal
servicegraph-3127588006-cv6bd     1/1       Running   0          2d        <IP_ADDRESS>   ip-172-16-195-9.us-west-2.compute.internal
zipkin-4057566570-1f786           1/1       Running   0          2d        <IP_ADDRESS>    ip-172-16-195-9.us-west-2.compute.internal

When i try to call productpage, i get 503 service unavailable error
curl http://<IP_ADDRESS>:32119/productpage --noproxy <IP_ADDRESS> -v
*   Trying <IP_ADDRESS>...
* Connected to <IP_ADDRESS> (<IP_ADDRESS>) port 32119 (#0)
> GET /productpage HTTP/1.1
> Host: <IP_ADDRESS>:32119
> User-Agent: curl/7.43.0
> Accept: */*
>
< HTTP/1.1 503 Service Unavailable
< content-length: 57
< content-type: text/plain
< date: Fri, 23 Jun 2017 18:49:37 GMT
< server: envoy
<
* Connection #0 to host <IP_ADDRESS> left intact
upstream connect error or disconnect/reset before headers%

When I ssh to one of the box, and try calling the productpage pod, i get an error. So that mean the productpage app is not listening:
curl <IP_ADDRESS>:9080
curl: (56) Recv failure: Connection reset by peer

There are no logs:
kubectl logs productpage-v1-1440812148-8fmmh -f  -c productpage

I am also having similar issues.

This looks similar to https://github.com/istio/issues/issues/39, where we've identified that there are at least two possible causes:

some pods aren't scheduled due to a shortage of CPU/memory.
installation is a bit messed-up, see https://github.com/istio/issues/issues/39#issuecomment-321212835

please reopen in https://github.com/istio/issues/issues if it's still a problem after you checked if your cluster has at least 4 nodes etc


publicize QUIC varint reading and writing

Packages outside of quic-go might want to make use of QUIC's varint format. We should expose the respective functions, so they don't have to reimplement this.
Specifically, MASQUE uses varints for the Stream Chunk encoding.

That's what the second commit does.

That's what the second commit does.

But it looks like I forgot WriteVarInt. Fixed now.

But it looks like I forgot WriteVarInt. Fixed now.


Ignoreinjection: true in Frontend.json has no effect?

Busy with upgrading to v 4.9.1 and setting basic-auth/pass in Settings a couple of weeks ago. Now I realized that the dashboard shows injection data while my Frontend settings were the way that they should not be visible:
{
"ShowVoltage": true,
"Injection": false,
"Phases": 3,
"Fuse": 25,
"cdn": true,
"GasAvailable": true,
"HideInitial": false,
"Act_Watt": false,
"AvoidSpikes": true,
"IgnoreInjection": true,
"IgnoreGas": false,
"i18n": "nl"
}
Is there something wrong with this set?
One of the two meter readings for injection shows the value 0,097 but changed never. May be this triggers the injection data on the dashboard?

Did you remove the DSMRindexEDGE.html after upgrading to 4.9.1? The dongle wel download the latest index file after removing.

Thanks for quick response!
No.
You mean deleting that file in "Bestandsbeheer"?

correct, just remove it in "Bestandsbeheer" and refresh the browser once or twice.

OK, it works again as expected! Thanks!


Make a table to display all the data

Hey @aditeyaS , can you elaborate more about, like how you want to display the data into table format.? any images or examples would be suffix?

Hey @Devanshukoli I don't have an image for that. Earlier it was just displaying the top voted, then someone made it a list that shows all the votes. You can better the UI, the way you see fit.

Ok, Cool. Let me find some better UI for it and present it here. Then take a look at that and we can decide it later. sounds good?

Sure. You can directly raise a PR. This repo does not have that many contributors for that data to grow. If possible, please share it with your friends.


fix: defaultOptions undefined (Issue #31)

Current coverage is 25.90% (diff: 0.00%)

Merging #39 into master will decrease coverage by 0.51%

@@             master        #39   diff @@
==========================================
  Files            18         18
  Lines           193        193
  Methods           0          0
  Messages          0          0
  Branches          0          0
==========================================
- Hits             51         50     -1
- Misses          142        143     +1
  Partials          0          0

Powered by Codecov. Last update 68ceffe...477bc98

I updated it manually for the next release :)


feat: event tracking

Adds basic event tracking to the SDK with data payload and support for setting timestamp in the identifyRepository

:tada: This PR is included in version 1.0.0-beta.1 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:

:tada: This PR is included in version 1.0.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Mismatched types error

Hi,
I'm new to Rust and Juniper. I'm trying to port a graphql api written with Nestjs to Rust with Rocket & Juniper.
I litterally copied the sample code and made some little changes and I'm getting the following message:
error: mismatched types label: expected struct juniper::schema::model::RootNode, found struct State. Both occur on the get_graphql_handler and post_graphql_handler methods.
It looks like they don't like the parameter schema: &State,
To Reproduce
Steps to reproduce the behavior:
use the code below
use juniper::{EmptyMutation, EmptySubscription, FieldResult, RootNode, graphql_object};
use mongodb::{Client, Database};
use rocket::{response::content, Rocket, State};

struct AppDataPool {
    mongo: Database,
}
struct AppContext {
    pool: AppDataPool,
}
struct Query;
#[graphql_object(context = AppContext)]
impl Query {
    fn apiVersion() -> &'static str {
        "1.0"
    }
    fn say_hello() -> FieldResult<&'static str>{
        Ok("Hello")
    }
}

type Schema = RootNode<'static, Query, EmptyMutation<Database>, EmptySubscription<Database>>;

#[rocket::get("/")]
fn graphiql() -> content::Html<String> {
    juniper_rocket::graphiql_source("/graphql", None)
}

#[rocket::get("/graphql?<request>")]
fn get_graphql_handler(
    context: &State<Database>,
    request: juniper_rocket::GraphQLRequest,
    schema: &State<Schema>,
) -> juniper_rocket::GraphQLResponse {
    request.execute_sync(&*schema, &*context)
}

#[rocket::post("/graphql", data = "<request>")]
fn post_graphql_handler(
    context: &State<Database>,
    request: juniper_rocket::GraphQLRequest,
    schema: &State<Schema>,
) -> juniper_rocket::GraphQLResponse {
    request.execute_sync(&*schema, &*context)
}

#[rocket::main]
async fn main() {
        let client = Client::with_uri_str("---").await;
    let db = client.unwrap().database("-dev");

    Rocket::build()
        .manage(AppDataPool { mongo: db })
        .manage(Schema::new(
            Query,
            EmptyMutation::<Database>::new(),
            EmptySubscription::<Database>::new(),
        ))
        .mount(
            "/",
            rocket::routes![graphiql, get_graphql_handler, post_graphql_handler],
        )
        .launch()
        .await
        .expect("server to launch");
}

Expected behavior
App at least compiles
Additional context
[package]
name = "rocket_graphql"
version = "0.1.0"
edition = "2018"

[dependencies]
rocket = "0.5.0-rc.1"
dotenv = "0.15.0"
mongodb = "2.0.0-beta.2"
tokio = { version = "1.8.0", features = ["full"] }
juniper = { git = "https://github.com/graphql-rust/juniper" }
juniper_rocket = "0.8.0"

Thank you for your help

@folivi it seems that you've been a bit lost in Derefs here. Let's see:
You have schema: &State<Schema> parameter, so performfing &*schema you will have the following:

let deref_schema: State<Schema> = *schema;
let arg: &State<Schema> = &deref_schema;

You need double Deref here. The first will deref the & references, and the second will deref State into the inner Schema:

let deref_state: State<Schema> = *schema;
let deref_schema: Schema = *deref_state;
let arg: &Schema = &deref_schema;

Hope it explains what's going on 😅
So you shoud try:
#[rocket::get("/graphql?<request>")]
fn get_graphql_handler(
    context: &State<Database>,
    request: juniper_rocket::GraphQLRequest,
    schema: &State<Schema>,
) -> juniper_rocket::GraphQLResponse {
    request.execute_sync(&**schema, &**context)
}

#[rocket::post("/graphql", data = "<request>")]
fn post_graphql_handler(
    context: &State<Database>,
    request: juniper_rocket::GraphQLRequest,
    schema: &State<Schema>,
) -> juniper_rocket::GraphQLResponse {
    request.execute_sync(&**schema, &**context)
}

@folivi another problem that I see here, is that you queries root (Query struct) uses context = AppContext, while mutations and subscriptions are defined as EmptyMutation<Database>, which means that for them context = Database.
That simply won't type check. Either use context = Database for Query, or EmptyMutation<AppContext>/EmptySubscription<AppContext>.

Thank you very much for your reply. I'll check it as soon as I can.
Very kind of you

@folivi ok, I close this. Feel free to reopen if needed.

Hi @tyranron!
So now, I updated my code to use the AppContext as context like so:
use juniper::{EmptyMutation, EmptySubscription, FieldResult, RootNode, graphql_object};
use mongodb::{Client, Database};
use rocket::{response::content, Rocket, State};

struct AppDataPool {
    mongo: Database,
}
struct AppContext {
    pool: AppDataPool,
}
struct Query;
#[graphql_object(context = AppContext)]
impl Query {
    fn apiVersion() -> &'static str {
        "1.0"
    }
    fn say_hello() -> FieldResult<&'static str>{
        Ok("Hello")
    }
}

type Schema =  RootNode<'static, Query, EmptyMutation<AppContext>, EmptySubscription<AppContext>>;

#[rocket::get("/")]
fn graphiql() -> content::Html<String> {
    juniper_rocket::graphiql_source("/graphql", None)
}

#[rocket::get("/graphql?<request>")]
fn get_graphql_handler(
    context: &State<AppContext>,
    request: juniper_rocket::GraphQLRequest,
    schema: &State<Schema>,
) -> juniper_rocket::GraphQLResponse {
    request.execute_sync(&**schema, &**context)
}

#[rocket::post("/graphql", data = "<request>")]
fn post_graphql_handler(
    context: &State<AppContext>,
    request: juniper_rocket::GraphQLRequest,
    schema: &State<Schema>,
) -> juniper_rocket::GraphQLResponse {
    request.execute_sync(&**schema, &**context)
}

#[rocket::main]
async fn main() {
        let client = Client::with_uri_str("---").await;
    let db = client.unwrap().database("-dev");

    Rocket::build()
        .manage(AppDataPool{ mongo: db })
        .manage(Schema::new(
            Query,
            EmptyMutation::<AppContext>::new(),
            EmptySubscription::<AppContext>::new(),
        ))
        .mount(
            "/",
            rocket::routes![graphiql, get_graphql_handler, post_graphql_handler],
        )
        .launch()
        .await
        .expect("server to launch");
}

Now I'm getting the following error on the line request.execute_sync(&**schema, &**context)
label: expected struct juniper::schema::model::RootNode, found struct RootNode``

@folivi you should ensure that juniper_rocket and your crate refer the same major version of juniper in Cargo.toml.

hi @tyranron
Everything is working now with juniper 0.15.7 and juniper_rocket 0.8.0
Thank you for you help all along. I really appreciate


Add concatenateArrayBuffers to tf.io export for Node.js HTTP

The method is required by Node.js HTTP loader currently being worked
on in tfjs-node.
Towards: https://github.com/tensorflow/tfjs-node/issues/343

This change is

Review status: :shipit: complete! 1 of 1 LGTMs obtained

Comments from Reviewable