proposal: cmd/vet: do not warn about nil comparisons after for loop

What version of Go are you using (go version)?

$ go version
go version devel +e003c6f971 Mon Nov 19 17:33:37 2018 +0000 linux/amd64

Does this issue reproduce with the latest release?
I see this issue with vet installed via:
$ go get -v -u golang.org/x/tools/go/analysis/cmd/vet

What operating system and processor architecture are you using (go env)?
go env Output
$ go env
GOARCH="amd64"
GOBIN=""
GOCACHE="/home/mschoch/.cache/go-build"
GOEXE=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="linux"
GOOS="linux"
GOPATH="/home/mschoch/go"
GOPROXY=""
GORACE=""
GOROOT="/home/mschoch/Documents/research/gosrc"
GOTMPDIR=""
GOTOOLDIR="/home/mschoch/Documents/research/gosrc/pkg/tool/linux_amd64"
GCCGO="gccgo"
CC="gcc"
CXX="g++"
CGO_ENABLED="1"
GOMOD=""
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -fmessage-length=0 -fdebug-prefix-map=/tmp/go-build975661669=/tmp/go-build -gno-record-gcc-switches"

What did you do?

Run vet . on the following program:
package main

import (
	"io"
	"log"
)

func main() {

	var i int
	var err error
	for err == nil {
		i++
		if i == 10 {
			err = io.EOF
		}
	}
	if err != nil && err != io.EOF {
		log.Fatalf("got a real error")
	}
}

What did you expect to see?
No output
What did you see instead?
/home/mschoch/go/src/github.com/mschoch/vetter/main.go:18:9: tautological condition: non-nil != nil

Discussion
Following the output of this tool, one might rewrite the program as:
package main

import (
	"io"
	"log"
)

func main() {

	var i int
	var err error
	for err == nil {
		i++
		if i == 10 {
			err = io.EOF
		}
	}
	if err != io.EOF {
		log.Fatalf("got a real error")
	}
}

And for now, the program remains correct.
However, if a developer were to add a break statement, such as:
package main

import (
	"io"
	"log"
)

func main() {

	var i int
	var err error
	for err == nil {
		i++
		if i == 7 {
			break
		}
		if i == 10 {
			err = io.EOF
		}
	}
	if err != io.EOF {
		log.Fatalf("got a real error")
	}
}

Now, the program will incorrectly process an error, because the nil check was removed.
In my opinion, break is a first class feature of the language, and because of this, developers should not assume that the for loop condition is satisfied, just because control flow has proceeded past it.  Following the advice of the vet tool in this instance has made the code more brittle.
NOTE: this example is silly, but it came up in real code here: https://github.com/blevesearch/bleve/pull/1051
CC: @dgryski

Contrast #19727 and #20148.

Now, the program will incorrectly process an error, because the nil check was removed.

How often will such a mistake make it through testing? If a developer adds a break, presumably they had a reason to do so — what kinds of changes that would result in err == nil would also make it past (even cursory) testing?

(CC @alandonovan @josharian @mvdan for cmd/vet.)

I would argue that this is the checker working as intended. Much more often than not, a non-constant condition that is always true or false represents a misunderstanding about the local control flow. When a programmer adds a break statement, they're changing the control flow, and it's upon to them to evaluate the consequences of that change.

One can also argue that the redundant form is much more resistant to accidental breakage. If Go had assert, assert(err != nil) is something one may want to put after the loop. Lacking that, one pulls it into the if statement instead.

I haven't made up my mind about this issue, but I lean towards Dominik's opinion that vet shouldn't fight programmers that are being explicit with their invariants and pre/post conditions.
Also, this issue reminds me of #28446. That was about a different check, but the underlying point is similar. Vet complains about an expression that is technically pointless, but in practice it serves a purpose - to help future contributors not break an invariant.

Another step down the slippery slope: vet notices that all callers to a particular non-exported function pass a non-nil parameter.  Does it warn that the nil check in the function body is useless?

Per discussion with @golang/proposal-review, we agree the vet tool is working as intended with its current behavior.


Teams disappeared in application. Can find it in the web application.

One of my Teams has disappeared from the Teams app.
It started with the Teams channel disappeared, when I look at my notifications related to the channel, I could press them but nothing happened. Now also the notifications related to the channel are gone.
I can open and see the Team in the web application of Teams. When I try to click my way through sharepoint and "Open in Teams app", I get the following:
"we can't find that channel due to connectivity issues. please try again later"

We are mainly responsible for Microsoft Teams app development related issues.
For Microsoft Teams product issues/failures your tenant Admin can reach out to Microsoft 365 Product Support.

We are closing this issue for now, Please feel free to reopen it, if required.


Add files via upload

Please either generate new signatures, or use the withdrawal address "0xc668b480f8277e0f7d934c632201b02004dafd74". It is not possible to modify the fields - or it will invalidate the signature.


Using event.module as the field to taint translated metrics leads to issues due to constant_keyword field mappings

In https://github.com/elastic/opentelemetry-lib/pull/18, we've added a way to differentiate translated metrics by setting event.module to elastic/opentelemetry-lib:
https://github.com/elastic/opentelemetry-lib/blob/c8fcaba71b9d57d21d8c0926ae100e422693429e/remappers/internal/metric.go#L71
@andrzej-stencel found out that this leads to issues when the system integration is installed.
The error message is:
2024-06-20T16:41:59.387+0200    error   elasticsearchexporter@v0.102.0/elasticsearch_bulk.go:309        Drop docs: failed to index: struct { Type string "json:\"type\""; Reason string "json:\"reason\"" }{Type:"document_parsing_exception", Reason:"[1:370] failed to parse field [event.module] of type [constant_keyword] in a time series document at [2024-06-20T14:41:58.265Z]"}   {"kind": "exporter", "data_type": "metrics", "name": "elasticsearch", "status": 400}

One of the metrics he was trying to ingest looks like this:
{"@timestamp":"2024-06-20T14:41:58.265704997Z","data_stream":{"dataset":"system.diskio"},"event":{"module":"elastic/opentelemetry-lib"},"host":{"name":"astencel"},"os":{"type":"linux"},"system":{"diskio":{"io":{"ops":0,"time":140},"name":"nvme0n1p2","read":{"bytes":4600832,"count":146,"time":16},"write":{"bytes":462848,"count":70,"time":95}}}}

The reason this fails is that the system integration adds a constant_keyword mapping for the event.module field with system as a static value:
https://github.com/elastic/integrations/blob/119664bbf8fb93d8279374f34d1faf7e960777e2/packages/system/data_stream/cpu/fields/base-fields.yml#L9-L12
We'll need to find another field to taint the translated metrics, which isn't mapped as constant_keyword. From my perspective, we don't need to use a pre-existing ECS field for that (that could reduce the risk of similar clashes in the future), and a simple boolean may be enough.
cc @ishleenk17 @lahsivjar

@felixbarny : That sounds about right.
I will add a boolean flag is_remapped taint to the remapped metrics and remove event.module


Sharing capabilities

Being able to share a song by copying the link of the song to the clipboard

@Datsuke Thanks for the request. This feature existed for albums/playlists and has now been added to the songs actions dropdown.
Note though that it is only available for songs when you're not in a library view (ie. viewing a playlist, album or your songs from the "Library" menu).


feat(components): coachmark component

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots:
Before (If applicable):

After:

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] Documentation update
[x] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Other... Please describe:

Checklist:

[x] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[ ] I have read the CONTRIBUTING document.
[x] I have added tests to cover my changes.
[x] All new and existing tests passed.

In this case, this was done to determine the focus on the internal elements of the component, since inside there can be a slot with other elements. In my opinion, this is the most optimal option with focus.


Embroider Support

I'm not sure where work has to be done, wether in Embroider or in this project, so I'm creating this issue for tracking - unless someone wants to look into the cause.
When trying to use Embroider in an application which is using ember-bootstrap, it errors out. The error is reported here: https://github.com/embroider-build/embroider/issues/164

Note: the fix will have to be reverted unfortunately, see #914. It should nevertheless work fine when the upstream fix in Embroider (https://github.com/embroider-build/embroider/pull/341) is released!


Discuss: resources usage by CRD

First of all I would like to express my great interest in this project.
And I clone this project to use ( casue of have no arm64/darwin yet), but I noticed that there might be some problems.
KOR could not find resources used by crd.
For example, I use traefik ingressroute for my cluster ingress, and I would use cert signed by cert-manager, which store in kubernetes secret, but KOR treats it as orphaned resources.
I don't have a particularly good solution at the moment, so I hope to discuss it in this issue. Adding all CRDs is obviously unrealistic

Regarding arm64/darwin We can add support for that in one of the upcoming releases.
Regarding certificates, if these secrets are used in an ingress we should be detecting them.
@incubator4 Can you share the ingress manifest?

Regarding arm64/darwin We can add support for that in one of the upcoming releases.
Regarding certificates, if these secrets are used in an ingress we should be detecting them. @incubator4 Can you share the ingress manifest?

My apologize, maybe I didn't explain clearly. I means that resources usage by crd cound not be detected. May be workload resources could be detected, cause of pods are ultimately required to run workloads, and configmap/secret would be used by pod.
But  in other case, for example I use traefik for ingress controller and cert-manager to manage cert.
This is a  cert example.
apiVersion: cert-manager.io/v1
kind: Certificate
metadata:
  name: <some-name>
  namespace: default
spec:
  dnsNames:
  - <some-hostname>
  issuerRef:
    kind: ClusterIssuer
    name: cloudflare
  secretName: <secret-would-be-created>

And I would use this secret in traefik IngressRoute.This is an example.
apiVersion: traefik.containo.us/v1alpha1
kind: IngressRoute
metadata:
  name: <some-name>
  namespace: default
spec:
  entryPoints:
  - websecure
  routes:
  - kind: Rule
    match: Host(`<some-hostname>`)
    services:
    - name: <svc>
      port: 80
tls:
    secretName: <secret-would-be-created>

Got it. Thanks for clarifying!
2 follow up questions.
1.Does deletion of the certificate remove the secret as well?
2. Does the secret created by the certificate have a unique type or label that shows it was created by cert manager?

Closing as Stale


WIP: April 2019 Release

What's Changed

Add alliances tab (c1e78fc) @ofekashery

Close issue #278 (7db136e) @ofekashery

Working on the Retriever (fb1e52a, cebfc65) @Techno11

Add More Server Status (9dc13e3) @Techno11

Add Noah and Dominic to the about page (b92f763) @nholo1332

Add OPR to teams pages (9af4137, c2f93bb) @Techno11

Moved to #292


TUF deployment roadmap for PyPI

Is there a timeline for when TUF might be deployed to PyPI or what issues are blocking deployment?
Thanks!

We've been prodding them to try to get this going.  We're very interested
in helping to get this into Warehouse, but our understanding is that they
still aren't ready.
Datadog did do a pip integration of TUF that they are using with their
customers.  So the client side should be easy to do...
On Wed, Jan 2, 2019 at 9:07 AM Lucid One<EMAIL_ADDRESS>wrote:

Is there a timeline for when TUF might be deployed to PyPI or what issues
are blocking deployment?
Thanks!
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/theupdateframework/tuf/issues/816, or mute the thread
https://github.com/notifications/unsubscribe-auth/AA0XD_yoUwNPtFpGeCN0N97MEHrSLda7ks5u_L0FgaJpZM4Zmsmn
.

More progress: https://github.com/python/peps/pull/1177

Tracked separately by PyPI, so closing this issue


[BUG] Looping one single video does not work

I want to play a single youtube video in a loop. I've tried setting the loop field in YoutubePlayerParams to true. I've also tried to call setLoop() method on the controller. But with no success.
To Reproduce
Just use a YoutubePlayerIframe with a controller that has loop set to true.
Expected behavior
The video should start from the beginning when reaching the end.
Technical Details:

Device: Android, Web
OS: Android 11, Google Chrome
Version: 2.2.2

Fixed with v3.

hi @sarbagyastha this will be in 3.1.0? I'm experiencing this for 3.0.4.


[package_info_plus] fix MissingPluginException for windows and linux

Description
At commit 7e898675fbd18cb6ac90f36c1e6bd126aea1c64d the plugins for windows and linux had changes to auto register via static void registerWith(). But neither the plugins nor the main package versions were increased and published.
This commit fixes that by increasing the versions of the plugins and the main package.
Related Issues
Closes #806
Closes #760
Closes #747
Closes #773
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]).
This will ensure a smooth and quick review process.

[x] I read the Contributor Guide and followed the process outlined there for submitting PRs.
[x] My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
[x] All existing and new tests are passing.
[x] I updated the version in pubspec.yaml and CHANGELOG.md.
[x] I updated/added relevant documentation (doc comments with ///).
[x] The analyzer (flutter analyze) does not report any problems on my PR.
[x] I read and followed the Flutter Style Guide.
[x] I am willing to follow-up on review comments in a timely manner.

Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?

[ ] Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md and increment major revision).
[x] No, this is not a breaking change.

Still an issue on macOS (only in tests), left a comment in #214


CSS themes

Appears in documentation that it is possible to provide CSS themes for blogit.  Kindly provide an example of doing it in Rails 4?
http://gavinmorrice.com/blog/
seems like it is already possible with above site.  Is the site in older version?  looks like there is not the description field in the above site.
Thanks.

Hi. I've added some docs for the themes here:
http://blogit.katanacode.com/doc/file.HowTo.html
At the moment, there's only one basic theme (the default theme). I'll add more themes when I can.

You can also see the default theme in action by running the dummy app within the gem's spec directory.


How to show heatmap under text content ?

Please describe the issue you're facing, don't ask questions without descriptions on a repo. Read the docs, google it, maybe even ask on StackOverflow


feat: add lapack/base/dlange

Description

What is the purpose of this pull request?

This pull request adds JS implementation for lapack/base/dlange
Related Issues

Does this pull request have any related issues?

Towards #2464
Questions

Any questions for reviewers of this pull request?

No.
Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.
Checklist

Please ensure the following tasks are completed before submitting this pull request.

[x] Read, understood, and followed the contributing guidelines.
[x] Add tests to test correct value of Forbenius Norm.
[x] cleanup base implementation.
[x] refactor implementation following dlacpy.

@stdlib-js/reviewers

There are a few improvements we can make in this PR, post / in our meet today:

[ ] replace j,i with i0, i1
[ ] check correctness of comments in base implementation

@kgryte can we please do implementation of access variable in subsequent PRs? This is a major change, I'll prefer to do it in another PR, please.

@Pranavchiku I am not sure the benefit of doing in a follow-up PR. And also, s/access/axis/.

Done, this PR can have a review now :))


[MetaSchedule][UX] Support Interactive Performance Table Printing in Notebook

This PR further addes interactive table printing functionality following #12866, now performance table are print in dataframe style if running in jupyter notebook. Sample notebook see here

CC @junrushao

Ready for review and the current logger can:

CC @MasterJH5574 @spectrometerHBH would you like to review?


⚠ Bofrost.at has degraded performance

In 8f2fa2c, Bofrost.at (https://www.bofrost.at) experienced degraded performance:

HTTP code: 200
Response time: 1273 ms

Resolved: Bofrost.at performance has improved in 92fa850.


"python3": executable file not found in $PATH: unknown

When I enter docker-compose up -d on socialNetwork directory, I get this error.
Error response from daemon: OCI runtime create failed: container_linux.go:367: starting container process caused: exec: "python3": executable file not found in $PATH: unknown
When I modified python3 -> python in docker-compose.yml tried to run, I get this error.
python: can't open file './scripts/config.py': [Errno 2] No such file or directory
I do a small hack to see what is in scripts by running
$ sudo docker run --rm --entrypoint ls yg397/social-network-microservices:latest ./scripts, then I see
init_redis_cluster.py
init_social_graph.py

Hi bro, have you fix this problem?

Hi, I have the same problem. How did fix this problem?

The latest dockerhub build of yg397 doesn't include python3 (and some other files), so you need to build the docker images yourself from within the /docker directory.
If you wish to try out the docker-compose.yml you can also try my build, where you need to replace yg397/image:tag with stvdputten/social-network-microservices:latest or stvdputten/openresty-thrift:latest . I hope that helps.

Sorry guys, I did not see the notification. Yes, the issue is solved.
The problem was that the images are not up to date and I do not think it is being maintained.
I was creating my own images but thanks to @zhxie, I was able to run the application.
These are my notes about the steps:
Issue: Two important images (yg397/thrift-microservice-deps:xenial and  yg397/social-network-microservices) from docker hub are not updated. So, need to build them from the code.

Build yg397/thrift-microservice-deps:xenial image

cd into thrift-microservice-deps/cpp
docker build -t yg397/thrift-microservice-deps:xenial .
Go back to the root social network directory
5.docker build -t yg397/social-network-microservices:latest .
Now run `docker-compose up -d

Let me know if it still does not work.
Make sure to run it in Linux. It somehow does not work on MacOS.


Monad refactorings

Next steps:

(Maybe) refactor existing instances
Add missing monads: reader, id, writer
Add (lawful) mtl-like monad classes

I noticed that you adopted the convention that monad transformers have type Π m [monad m], Type u → Type v. Would it be a problem to move [monad m] out of there? It is an idiom and a feature that has been abandoned in Haskell because it produces un-modular code. It's more modular to put that constraint as part of the instance declarations:
instance [functor m] : functor (my_monad_transformer m) := ...
instance [applicative m] : applicative (my_monad_transformer m) := ...
instance [monad m] : monad (my_monad_transformer m) := ...

This way, you can still use the monad transformer if the underlying type is only an applicative functor -- although part of the interface may be unavailable in this situation.

It might be a good time to change the lift functions here: https://github.com/Kha/lean/blob/b6978ed1274e2937e988c6eaf46c1cf9eecffb23/library/init/category/combinators.lean#L82-L98
They don't need to rely on monad. applicative is enough and in one case, functor is enough.

@cipher1024

I noticed that you adopted the convention that monad transformers have type Π m [monad m], Type u → Type v.

No, all types have been changed in later commits :) .

It might be a good time to change the lift functions here: https://github.com/Kha/lean/blob/b6978ed1274e2937e988c6eaf46c1cf9eecffb23/library/init/category/combinators.lean#L82-L98

These lifts are older than functor/applicative, do we still need them/do Haskell people still use them? The duplication and indices look messy compared to <$> and <*>.

These lifts are older than functor/applicative, do we still need them/do Haskell people still use them?  If we people need them, they can define themselves.

These lifts are older than functor/applicative, do we still need them/do Haskell people still use them? The duplication and indices look messy compared to <$> and <*>.

 If we people need them, they can define themselves.

Thanks for the heads up! I'll bring it over to mathlib. @Kha, lift₂ is the one I see most often and it's mostly useful curried when you're feeding it to a higher order function. It's also useful when monadic actions return monadic actions: with x : m (m α), y : m (m β), f : α → β → γ, you can write lift₂ f <$> x <*> y to combine the results of x and y.

@Kha In data.buffer.parser, beside the use of unit, is there anything that constrains you to stay in universe 0?

@cipher1024 I don't think so, but I don't want to touch that type more than necessary in this PR. It should be moved from buffer to the now efficient string type anyway.

merged


Problems drag and droping files from vscode to external apps [Windows]

VSCode Version: 1.16.0
OS Version: Windows 10 64bit

It's possible to drag and drop files from VSCode's file explorer on external Windows apps but depending on the app it doesn't seem to work properly.
Here are some results:

droping an image from vscode explorer onto windows explorer: the file is correctly copied in the explorer's directory
droping an image from vscode explorer onto Affinity Photo: shows a "forbidden" sign
droping an image from vscode explorer onto Paint: shows a "+" but nothing happens when releasing the mouse
droping an image from vscode explorer onto a Skype window: shows a "+" but nothing happens
droping an image from vscode explorer onto the Skype window's text input: the path to the image is copied
droping an image onto a chrome window: shows a "+", but after releasing the mouse does nothing and the url is set to "about:blank"

It seems that vscode uses the object's path when doing drap & drop onto external apps. If the app recognizes it (eg. Windows Explorer), it will open the file. Unfortunately most apps doesn't recognize it.
My suggestion would be to improve vscode so that dragging files onto apps that support it work.

https://github.com/Microsoft/vscode/issues/164


Shuffle and repeat

Is it possible to add also shortcuts for shuffle and repeat? Maybe with "alt +shift + S" and "+ R"

The Alt+Shift+S shortcut is not possible because Firefox have a shortcut with Alt+S.
How about Alt+Shift+F for shuffle? @pintify

Alt+Shift+F works for me. My suggestions were mere examples.
I'll most likely modify them later if you implement the customization. Whenever possible I use something that matches visually such as Alt +    z-x-c-v-b (or a similar avoiding conflicts) as shuffle-prev-play-next-repeat in this case. Preferably usable with one hand.


[CODE TASK] Playbook takes a very long time.

Every time you spin up the Playbook, you have to wait for almost an hour as various things are downloaded, compiled, and installed.
I would like a faster way to "spin up" the environment for testing, especially for testing

the installation and configuration of the Islandora Starter Site
changes to the Islandora Starter Site, such as changes to config and module requirements, that do not impact external services.

I do not know what makes sense given our dev capacity, but

would it be feasible to cache a partially built state of the machine (maybe as a base box or whatever makes sense
can we re-evaluate whether Grok is necessary (it takes up the largest amount of time) and I heard a rumour we aren't using it in practice anyway? and maybe other slow services?

Notes from Tech Call today:

The Playbook is like this, that's why ISLE sounds so good!
an "everything but the drupal" base box might be nice, as we  used to
there might be instructions to create and load that base box somewhere.
automate - every merge to the playbook could automatically build a machine (vagrant cloud?)

Sorry I had a conflicting meeting, but I had a thought that the only issue would be for those that want to use the playbook to provision an actual server. Where they would want Solr/Blazegraph/etc downloaded and Grok compiled as well.
So some alternate playbook for choosing to install those items or assume they are installed would be good.


SUMO-231059: update doc for 10 v2 apps of phase 1

PLEASE READ
Following a recent back-end update, all contributors with a local clone or fork of our repository are required to run yarn install. This does not apply to direct page edits.

[ ] Yes, I've run yarn install
[ ] No, does not apply to me

Purpose of this pull request
This pull request...

Select the type of change:

[ ] Minor Changes - Typos, formatting, slight revisions, .clabot
[ ] Update Content - Revisions, updating sections
[ ] New Content - New features, sections, pages, tutorials
[ ] Site and Tools - Updates, maintenance, dependencies, new packages for the site (Docusaurus, Gatsby, React, etc.)

@kimsauce there is some changes in the Installation steps for V2 apps. Currently, we are only updating the UI for 30 apps so  the new reuse file (v2) created will be added to the new apps. Going forward when the installation process is changed for all the apps then we can delete the existing reuse file.

The intent of this PR is covered in the PR #3432.


[Bug] Video sound still playing while volume set to 0 on video

Description
In my XAML, I have set the volume property to 0  for a video stored on the device. The sound still plays.
Steps to Reproduce

Add a video clip to either the android or iOS project
Set the steam source to the video file
Set the Volume property to 0

Expected Behavior
Video will be silent
Actual Behavior
Video sound plays
Basic Information

Version with issue: 1.0.0.pre5
Last known good version:
IDE: VS2019
Platform Target Frameworks:

iOS:  14.3
Android: <!--Android 10
UWP:

Android Support Library Version:
Nuget Packages:
Affected Devices:

Workaround

Reproduction imagery

Reproduction Link

Android is fixed as a PR for #398

Android is fixed as a PR for #398


CONFIGURATION-634: BasePath is incorrectly computed while init of CompositeConfiguration

BasePath should be constructed from URL only when null
Added testcase to verify the same

Ran all the test cases using mvn clean test and all the tests passed

Code checked-in as part of Commit: 5544b5af78ba07308f17e37915c2c919bb143870


Cellenics® Submission

Thank you for submitting a portal to the HCA DCP Methods Registry!
To expedite your portal's addition to https://data.humancellatlas.org/analyze,
please provide the following package metadata.  You can easily edit this information later by clicking "Improve this page" at the bottom of your portal's detail page (example).
Required:

Tool title: Cellenics®

Contact name: Biomage Team

Contact email<EMAIL_ADDRESS>

Who to attribute: Cellenics® software was developed by © 2020-2022 President and Fellows of Harvard College. Biomage is an open source software company that provided services to Harvard Medical School for the design and development of Cellenics®.

Portal URL: https://scp.biomage.net/

Short description: (<= 200 characters, will appear on list page)
Cellenics® is an open source, cloud-based analytics tool for single-cell RNA sequencing data that that has been developed at Harvard Medical School.
Optional:

Long description: (will appear on detail page)
Cellenics® is an open-source scRNA-seq data analysis software developed by © 2020-2022 President and Fellows of Harvard College under the scientific supervision of prof. Peter Kharchenko and the administrative supervision of the Department of Biomedical Informatics at Harvard Medical School. Biomage is an open-source software company that hosts a community instance of Cellenics®.
Cellenics® is a cloud-based tool, which means users can analyze their dataset from anywhere in the world at any time. This tool is fast, versatile, and user-friendly, making it easy for biologists to analyze single-cell datasets without needing bioinformatics expertise. And it’s free of charge for academic researchers with datasets of up to 300 thousand cells.
Cellenics® offers an in-depth data processing and quality control workflow, as well as a variety of data exploration features. Users can create custom cell sets, calculate differential expression, find marker genes, perform pathway analysis and trajectory analysis. The software provides a range of pre-loaded plots so that users can customize and export publication-quality figures very quickly.
Researchers studying cancer, cardiovascular health, and developmental biology use Cellenics® analysis software to make discoveries about complex biological systems. Your field could be next!
You can learn more about Cellenics® here https://www.biomage.net/resources!

Logo or screenshot: (attach to this GitHub issue.)

Hi @quedoasya @kayleemathews
This is now live here:
https://data.humancellatlas.org/analyze/portals/cellenics
Thanks for the submission to the tools catalog!
Cheers,
D


Not showing fullname in adding people to channel modal dialog

Problem
When I'm trying to add people in channel I can't see their fullname, only nickname.

But search working with all attributes of users(including fullname) and from server we getting all information about user.
Summary
I think it's wrong behaviour and information about user must be full like in mention modal dialog.

Environment

Operating System: Any
Mattermost Desktop App version: 5.1.1
Mattermost Server version: 7.0.0

Transferring to server repo as this is a server/webapp issue.


macOS + Safari + Continuous Scroll Mode + Touchpad = malfunction

This issue is a Bug
Related issue(s) and/or pull request(s)
None
Expected Behaviour
Scroll up and down smoothly
Observed behaviour
Scroll up ok but scroll down locked
Steps to reproduce

Open epub with Safari 10 : https://readium.firebaseapp.com/?epub=epub_content%2Faccessible_epub_3&
Change the Settings of Scroll Mode to Continuous
On the book, cannot scroll down

Test file(s)
Every epub in the library
Product

Readium cloud reader app

latest development build uploaded at https://readium.firebaseapp.com
Safari 9 or 10
macOS Yosemite or Sierra

Additional information
Chrome + macOS + Continuous Scroll Mode = OK
Firefox + macOS + Continuous Scroll Mode = OK
Edge + Windows 10 + Continuous Scroll Mode = OK

@JackieFei  Hm.  Using Safari 10 on OSX 10.10 I cannot reproduce the problem.  I'll try some more but am not seeing the problem.

Upgrade Safari to 10.0.1 on OSX 10.10.5, the scroll down still locked. So I attach a mouse for testing, it works fine on scroll up or scroll down. So the problem should be narrow down to "touchpad".
When using MacBook Pro touchpad to scroll down in Safari, it fails.

@JackieFei Unfortunately, my laptop is OSX 10.10.11 (El Capitan).  Cannot reproduce the problem there.  I do have a computer with 10.10.5 (Yosemite) but it is an old Mac Pro - no trackpad.  I suppose you tried the obvious fixes like rebooting?

I have used a MacBook Pro with macOS Sierra v10.12.1 + Safari 10.0.1 private mode, the "touchpad scroll down directly" still fail. But when I "scroll up a little, without leaving the touchpad, then scroll down", it succeed.
The mouse still all success.
I am not sure if the mouse scroll wheel events is the same as touchpad events in Readium?

The scroll view "sensitivity" can probably be tweaked via CSS:
https://github.com/readium/readium-shared-js/blob/develop/js/views/scroll_view.js#L91
        _$contentFrame = $("#scrolled-content-frame", _$el);
        _$contentFrame.css("overflow", "");
        _$contentFrame.css("overflow-y", "auto");
        _$contentFrame.css("overflow-x", "hidden");
        _$contentFrame.css("-webkit-overflow-scrolling", "touch");
        _$contentFrame.css("width", "100%");
        _$contentFrame.css("height", "100%");
        _$contentFrame.css("position", "relative");

Note that this is a regular HTML scrolling div, but the scroll event is debounced by 300ms, see onScroll:
https://github.com/readium/readium-shared-js/blob/develop/js/views/scroll_view.js#L272

The css fix does not work and issue is still reproducing with Mac (Readium version: 0.8.0,Safari: 11.1.1
macOS: High Sierra (version: 10.13.5) ) track pad.

Is this issue fixed as I can see this issue to be opened. I am still facing the problem specifically for down scroll on Mac safari browser (version: 12.1.1) with the (Readium version : 0.8.0) track pad. The CSS fix does not work to resolve this particular issue.


JSON  results tab VERY hard to read in dark mode (and to a lesser extent also SQL)

Looks like this both in Dark (Visual Studio) and Dark+ (default dark) which I believe is the default for people who have their computer in dark mode.

Unfortunately we can't easily get access to vscode's syntax highlighting, but we do know whether we're in light or dark mode so we can have some brighter colors when we know we're in dark mode.


Unable to start server with await

Hello,
I'm using OCPP-RPC with Node.js.
When using
await server.listen(3000);
the Node.js throws the error "await is only valid in async functions and the top level bodies of module".
I can only start the server without await - i.e.:
server.listen(3000);
Can you please help?
Thank you in advance!
-ct-

As per the error message you received, you'll need to use await within an async function, like so:
(async function main() {
    await server.listen(3000);
})();

Super!!!
Thank you!!!
(I know this is more a Node.js question but your help is much appreciated!)

Super!!! Thank you!!! (I know this is more a Node.js question but your help is much appreciated!)
Actually my problem is that on the message Handlers in the OCPP server we need to communicate with our backend server and we should only "respond" to the OCPP Client after we receive the response from the backend server.
Current I'm not able to achieve this because once we receive the message from the client, the thread is closed without a response. Therefore I would need to use await to "suspend" the process until I have an answer and respond to the client afterward - i.e.:
server.on('client', async (client) => {
  client.handle('BootNotification', ({params}) => {

      const ret = await callBackendAsync('BootNotification', client.identity, params);
      return ret;

  }
}

This is not allowed by Node.js (it is returning the error "await is only valid in async functions and the top level bodies of modules")
I would like to avoid calling the backend server synchronously and I believe async should be used in this scenario.
Can you share some tips on how to achieve this? Thank you so much for your help once more! -ct-

I've managed to use the "await" by adding "async" to the handler function:
server.on('client', async (client) => {
  client.handle('BootNotification', async ({params}) => {

      const ret = await callBackendAsync('BootNotification', client.identity, params);
      return ret;

  }
}

Do you see any issue with this approach?
Thank you once more for your reply.
-ct-

This is fine. This is how I anticipated people to use handlers like this.

Thank you for confirming Mikuso!


updated MAX_STANDARD_TAPSCRIPT_STACK_ITEM_SIZE to match consensus

If you make a change like this, you need to update all the tests too. Which frankly is IMO a good reason not to make this change... the difference in efficiency between 80 bytes and 520 bytes is minimal for data publishing applications, and I'm not aware of any other application that really needs big pushes.

make check runs clean, but it looks like i missed some CI tests. closing for now. sorry for the noise!


Expose move breaks panels

When toggling expose while panels are pinned and then pulling panels the app starts to break down. While in expose apps can be pinned to a different side, then however get blurred into the background. when deactivating expose they return to their original location, but the background is laid out for the panels being pinned to the side were during expose.
Using the example provided (Map and TextView): when both panels are floating and expose is activated the both can (sometimes) be "resized", by pulling the bottom of the panels, which shrinks them down weirdly, even until they vanish. After deactivating expose they return to normal.

Thanks for creating this issue!
I think I've fixed it in 57a3160857d610ad1f693b079f6bba4ca0250cb2, let me know if anything else is broken.


Lastest commits in CwlUtils are breaking CwlSignal current version

As you did not have published CwlSignal and CwlUtils as CocoaPods public pod, people currently can only point to your github repo if they want to use CwlSignal.
Unfortunately with direct github links you cannot specify version of the pod. Lastest changes in CwlUtils (after Oct25, 2018/2.0 tag) therefore are breaking current CwlSignal pod.
It would be good idea to push stable releases of the CwlUtils and CwlSignal pods to CocoaPods specs repo to let people use stable builds with specified version. See:
https://guides.cocoapods.org/making/getting-setup-with-trunk

Thanks for alerting me to this. I'll sort it out this weekend.

Hi @xjki , I've pushed the podspecs for CwlSignal tag 2.1 and CwlUtils tag 2.1 to CocoaPods. Let me know if there are any further problems.

It's perfect. Thanks!


Continuous Integration and Delivery Improvements

Continuous Integration and Delivery Improvements
:recycle: Current situation & Problem
Replying an application to TestFlight requires a manual process in AppStore Connect to publish an app to beta app review and to release the application to testers.
:bulb: Proposed solution
This PR updates the fastlane configuration to automatically upload the publish an app to beta app review and to release the application to testers.
:gear: Release Notes

Automatically publish an app to beta app review and to release the application to testers.

Code of Conduct & Contributing Guidelines
By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines:

[x] I agree to follow the Code of Conduct and Contributing Guidelines.

Codecov Report

Merging #5 (ddee114) into main (78259bd) will decrease coverage by 4.77%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main       #5      +/-   ##
==========================================
- Coverage   91.31%   86.53%   -4.77%
==========================================
  Files           9       13       +4
  Lines         115      193      +78
==========================================
+ Hits          105      167      +62
- Misses         10       26      +16

Impacted Files
Coverage Δ

...erViews/Sources/PaulSchmiedmayer/ProfileView.swift
80.00% <0.00%> (ø)

...ws/Sources/PaulSchmiedmayer/PaulSchmiedmayer.swift
72.23% <0.00%> (ø)

...ews/Sources/PaulSchmiedmayer/DescriptionView.swift
80.96% <0.00%> (ø)

...ews/Sources/PaulSchmiedmayer/TwitterUsername.swift
84.22% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 78259bd...ddee114. Read the comment docs.


Update README.md

Added these sections:

https://github.com/sharetribe/flex-integration-api-examples/tree/add-warning-about-client-id-and-secret#what-is-it-for
https://github.com/sharetribe/flex-integration-api-examples/tree/add-warning-about-client-id-and-secret#warning-usage-with-your-web-app--website

LGTM 👍


Unfortunately sometimes the HF Spaces backend errors and we have to restart it. Not really something we can fix or control at the moment.


engine(dm): implement String method for enum type

What problem does this PR solve?

Issue Number: ref #5504
What is changed and how it works?

implement String method for TaskStage/WorkerStage/OperateType
move WorkerType From common to typedefs
implement String method for WorkerType

Check List
Tests

Unit test
Integration test

Release note
None

/run-engine-integration-test

Codecov Report

Merging #6992 (8b6a4a4) into master (9398176) will decrease coverage by 5.4823%.
The diff coverage is 56.1461%.

:exclamation: Current head 8b6a4a4 differs from pull request most recent head c2d0e70. Consider uploading reports for the commit c2d0e70 to get more accurate results

Additional details and impacted files

Flag
Coverage Δ

cdc
?

dm
51.8694% <25.0000%> (-0.0785%)
:arrow_down:

engine
62.2051% <57.8947%> (-0.0571%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.
@@               Coverage Diff                @@
##             master      #6992        +/-   ##
================================================
- Coverage   59.8253%   54.3429%   -5.4824%
================================================
  Files           791        419       -372
  Lines         90221      52073     -38148
================================================
- Hits          53975      28298     -25677
+ Misses        31498      21049     -10449
+ Partials       4748       2726      -2022

/unhold

/run-engine-integration-test

/merge

please fix broken test: https://ci2.pingcap.net/blue/organizations/jenkins/engine_ghpr_integration_test/detail/engine_ghpr_integration_test/485/pipeline

/run-engine-integration-test

/run-engine-integration-test

test case is not stable:
https://ci2.pingcap.net/blue/organizations/jenkins/engine_ghpr_integration_test/detail/engine_ghpr_integration_test/486/pipeline

/run-engine-integration-test


go.mod: update dependencies

Codecov Report

Merging #104 (0fcb563) into main (0c473e3) will not change coverage.
The diff coverage is n/a.

:exclamation: Current head 0fcb563 differs from pull request most recent head 9aff5b0. Consider uploading reports for the commit 9aff5b0 to get more accurate results

@@           Coverage Diff           @@
##             main     #104   +/-   ##
=======================================
  Coverage   76.92%   76.92%
=======================================
  Files          17       17
  Lines        1872     1872
=======================================
  Hits         1440     1440
  Misses        320      320
  Partials      112      112

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


[BUG] Cannot withdraw from  Lido wstETH vault

Contact Details
<EMAIL_ADDRESS>What happened?
When trying to withdraw any amount from the vault Lido wstETH vault with Metamask, I get the following error:
`Something went wrong
replacement fee too low (error={"code":-32603,"message":"[ethjs-query] while formatting outputs from RPC '{"value":{"code":-32000,"message":"replacement transaction underpriced"}}'","stack":"Error: [ethjs-query] while formatting outputs from RPC '{"value":{"code":-32000,"message":"replacement transaction underpriced"}}'"}, method="sendTransaction", transaction=undefined, code=REPLACEMENT_UNDERPRICED, version=providers/5.5.0)`
Can you please fix?
Thanks
Raphael
Steps to reproduce

Go to the Withdraw form for this vault
Try to withdraw any amount
Sign transaction with Metamask
Fail

Expected behavior
Transaction to go successfully
What browser were you using?
Firefox
If you selected "Other" above, fill in the browser you used here.
No response

Prnn


Navigation stack having problem starting up (Smoother server and localization server sometimes giving trouble when trying to launch navigation)

Robot Model
Turtlebot4 Standard
ROS distro
Humble
Networking Configuration
Discovery Server
OS
Ubuntu 22.04
Built from source or installed?
Installed
Package version
Unsure
Type of issue
Navigation (SLAM, Nav2 etc.)
Expected behaviour
I expect the nav2 navigation stack to start up without error so that it could be used for navigation.
Actual behaviour
Often times, when I start up the navigation node after running localization, I get the error that the smoother server has failed and will not not respond.
Error messages
[smoother_server.rclcpp]: failed to send response to /smoother_server/change_state (timeout): client will not receive response, at ./src/rmw_response.cpp:154, at ./src/rcl/service.c:314

To Reproduce

Run localization to load map: ros2 launch turtlebot4_navigation localization.launch.py map:=office.yaml
Run navigation node: ros2 launch turtlebot4_navigation nav2.launch.py # navigation

Other notes
I have tried re-flashing the image, setting up the turtlebot from scratch following the instructions, factory resetting the create3 base and the error still occurs. Most of them time, I have to restart the turtlebot multiple times before it can be loaded successfully.
I'm currently using the turtlebot4_standard_humble_1.0.0 image, and running it in the discovery server mode.
I'm also running this with an actual robot and not in simulation.

Hi @xylhal
Sorry to see you're encountering issues.
Can you please recreate the issue and provide full terminal output from localization and navigation?
Thank you,
Rusty

os2 launch turtlebot4_navigation localization.launch.py map:=maps/demo_map_0822.yaml
[INFO] [launch]: All log files can be found below /home/user/.ros/log/2024-09-13-13-52-34-263614-iMac-228661
[INFO] [launch]: Default logging verbosity is set to INFO
[INFO] [map_server-1]: process started with pid [228662]
[INFO] [amcl-2]: process started with pid [228664]
[INFO] [lifecycle_manager-3]: process started with pid [228666]
[lifecycle_manager-3] [INFO] [1726260754.518674706] [lifecycle_manager_localization]: Creating
[amcl-2] [INFO] [1726260754.519741823] [amcl]:
[amcl-2] 	amcl lifecycle node launched.
[amcl-2] 	Waiting on external lifecycle transitions to activate
[amcl-2] 	See https://design.ros2.org/articles/node_lifecycle.html for more information.
[amcl-2] [INFO] [1726260754.521076312] [amcl]: Creating
[lifecycle_manager-3] [INFO] [1726260754.521607375] [lifecycle_manager_localization]: Creating and initializing lifecycle service clients
[map_server-1] [INFO] [1726260754.534376180] [map_server]:
[map_server-1] 	map_server lifecycle node launched.
[map_server-1] 	Waiting on external lifecycle transitions to activate
[map_server-1] 	See https://design.ros2.org/articles/node_lifecycle.html for more information.
[map_server-1] [INFO] [1726260754.534482151] [map_server]: Creating
[lifecycle_manager-3] [INFO] [1726260756.523261554] [lifecycle_manager_localization]: Waiting for service map_server/get_state...
[lifecycle_manager-3] [INFO] [1726260757.548768447] [lifecycle_manager_localization]: Starting managed nodes bringup...
[lifecycle_manager-3] [INFO] [1726260757.549185823] [lifecycle_manager_localization]: Configuring map_server
[map_server-1] [INFO] [1726260757.551469384] [map_server]: Configuring
[map_server-1] [INFO] [map_io]: Loading yaml file: maps/demo_map_0822.yaml
[map_server-1] [DEBUG] [map_io]: resolution: 0.05
[map_server-1] [DEBUG] [map_io]: origin[0]: -17.7
[map_server-1] [DEBUG] [map_io]: origin[1]: -47.6
[map_server-1] [DEBUG] [map_io]: origin[2]: 0
[map_server-1] [DEBUG] [map_io]: free_thresh: 0.25
[map_server-1] [DEBUG] [map_io]: occupied_thresh: 0.65
[map_server-1] [DEBUG] [map_io]: mode: trinary
[map_server-1] [DEBUG] [map_io]: negate: 0
[map_server-1] [INFO] [map_io]: Loading image_file: maps/demo_map_0822.pgm
[map_server-1] [DEBUG] [map_io]: Read map maps/demo_map_0822.pgm: 615 X 866 map @ 0.05 m/cell
[lifecycle_manager-3] [INFO] [1726260757.694424180] [lifecycle_manager_localization]: Configuring amcl
[amcl-2] [INFO] [1726260757.694603223] [amcl]: Configuring
[amcl-2] [INFO] [1726260757.694668777] [amcl]: initTransforms
[amcl-2] [INFO] [1726260757.703748645] [amcl]: initPubSub
[amcl-2] [INFO] [1726260757.710451547] [amcl]: Subscribed to map topic.
[lifecycle_manager-3] [INFO] [1726260757.715998960] [lifecycle_manager_localization]: Activating map_server
[map_server-1] [INFO] [1726260757.716179254] [map_server]: Activating
[map_server-1] [INFO] [1726260757.716727144] [map_server]: Creating bond (map_server) to lifecycle manager.
[lifecycle_manager-3] [INFO] [1726260757.921461425] [lifecycle_manager_localization]: Server map_server connected with bond.
[lifecycle_manager-3] [INFO] [1726260757.921690619] [lifecycle_manager_localization]: Activating amcl
[amcl-2] [INFO] [1726260757.923081035] [amcl]: Activating
[amcl-2] [INFO] [1726260757.923336884] [amcl]: Creating bond (amcl) to lifecycle manager.
[amcl-2] [INFO] [1726260758.090311893] [amcl]: Received a 615 X 866 map @ 0.050 m/pix
[amcl-2] [INFO] [1726260758.171956936] [amcl]: createLaserObject
[lifecycle_manager-3] [ERROR] [1726260758.835965461] [lifecycle_manager_localization]: Failed to change state for node: amcl. Exception: transition invoked while in transition.
[lifecycle_manager-3] [ERROR] [1726260758.836363692] [lifecycle_manager_localization]: Failed to bring up all requested nodes. Aborting bringup.

This above is the output from running ros2 launch turtlebot4_navigation nav2.launch.py
The localization usually runs fine without throwing any errors.
[INFO] [launch]: All log files can be found below /home/user/.ros/log/2024-09-13-13-52-34-263614-iMac-228661
[INFO] [launch]: Default logging verbosity is set to INFO
[INFO] [map_server-1]: process started with pid [228662]
[INFO] [amcl-2]: process started with pid [228664]
[INFO] [lifecycle_manager-3]: process started with pid [228666]
[lifecycle_manager-3] [INFO] [1726260754.518674706] [lifecycle_manager_localization]: Creating
[amcl-2] [INFO] [1726260754.519741823] [amcl]:
[amcl-2] 	amcl lifecycle node launched.
[amcl-2] 	Waiting on external lifecycle transitions to activate
[amcl-2] 	See https://design.ros2.org/articles/node_lifecycle.html for more information.
[amcl-2] [INFO] [1726260754.521076312] [amcl]: Creating
[lifecycle_manager-3] [INFO] [1726260754.521607375] [lifecycle_manager_localization]: Creating and initializing lifecycle service clients
[map_server-1] [INFO] [1726260754.534376180] [map_server]:
[map_server-1] 	map_server lifecycle node launched.
[map_server-1] 	Waiting on external lifecycle transitions to activate
[map_server-1] 	See https://design.ros2.org/articles/node_lifecycle.html for more information.
[map_server-1] [INFO] [1726260754.534482151] [map_server]: Creating
[lifecycle_manager-3] [INFO] [1726260756.523261554] [lifecycle_manager_localization]: Waiting for service map_server/get_state...
[lifecycle_manager-3] [INFO] [1726260757.548768447] [lifecycle_manager_localization]: Starting managed nodes bringup...
[lifecycle_manager-3] [INFO] [1726260757.549185823] [lifecycle_manager_localization]: Configuring map_server
[map_server-1] [INFO] [1726260757.551469384] [map_server]: Configuring
[map_server-1] [INFO] [map_io]: Loading yaml file: maps/demo_map_0822.yaml
[map_server-1] [DEBUG] [map_io]: resolution: 0.05
[map_server-1] [DEBUG] [map_io]: origin[0]: -17.7
[map_server-1] [DEBUG] [map_io]: origin[1]: -47.6
[map_server-1] [DEBUG] [map_io]: origin[2]: 0
[map_server-1] [DEBUG] [map_io]: free_thresh: 0.25
[map_server-1] [DEBUG] [map_io]: occupied_thresh: 0.65
[map_server-1] [DEBUG] [map_io]: mode: trinary
[map_server-1] [DEBUG] [map_io]: negate: 0
[map_server-1] [INFO] [map_io]: Loading image_file: maps/demo_map_0822.pgm
[map_server-1] [DEBUG] [map_io]: Read map maps/demo_map_0822.pgm: 615 X 866 map @ 0.05 m/cell
[lifecycle_manager-3] [INFO] [1726260757.694424180] [lifecycle_manager_localization]: Configuring amcl
[amcl-2] [INFO] [1726260757.694603223] [amcl]: Configuring
[amcl-2] [INFO] [1726260757.694668777] [amcl]: initTransforms
[amcl-2] [INFO] [1726260757.703748645] [amcl]: initPubSub
[amcl-2] [INFO] [1726260757.710451547] [amcl]: Subscribed to map topic.
[lifecycle_manager-3] [INFO] [1726260757.715998960] [lifecycle_manager_localization]: Activating map_server
[map_server-1] [INFO] [1726260757.716179254] [map_server]: Activating
[map_server-1] [INFO] [1726260757.716727144] [map_server]: Creating bond (map_server) to lifecycle manager.
[lifecycle_manager-3] [INFO] [1726260757.921461425] [lifecycle_manager_localization]: Server map_server connected with bond.
[lifecycle_manager-3] [INFO] [1726260757.921690619] [lifecycle_manager_localization]: Activating amcl
[amcl-2] [INFO] [1726260757.923081035] [amcl]: Activating
[amcl-2] [INFO] [1726260757.923336884] [amcl]: Creating bond (amcl) to lifecycle manager.
[amcl-2] [INFO] [1726260758.090311893] [amcl]: Received a 615 X 866 map @ 0.050 m/pix
[amcl-2] [INFO] [1726260758.171956936] [amcl]: createLaserObject
[lifecycle_manager-3] [ERROR] [1726260758.835965461] [lifecycle_manager_localization]: Failed to change state for node: amcl. Exception: transition invoked while in transition.
[lifecycle_manager-3] [ERROR] [1726260758.836363692] [lifecycle_manager_localization]: Failed to bring up all requested nodes. Aborting bringup.
[amcl-2] [WARN] [1726260759.780823698] [amcl]: AMCL cannot publish a pose or update the transform. Please set the initial pose...
[amcl-2] [WARN] [1726260761.834404668] [amcl]: AMCL cannot publish a pose or update the transform. Please set the initial pose...
[amcl-2] [WARN] [1726260763.845259570] [amcl]: AMCL cannot publish a pose or update the transform. Please set the initial pose...
[amcl-2] [WARN] [1726260765.898655532] [amcl]: AMCL cannot publish a pose or update the transform. Please set the initial pose...
[amcl-2] [WARN] [1726260767.936217984] [amcl]: AMCL cannot publish a pose or update the transform. Please set the initial pose...
[amcl-2] [WARN] [1726260770.098911117] [amcl]: AMCL cannot publish a pose or update the transform. Please set the initial pose...
[amcl-2] [WARN] [1726260772.231447543] [amcl]: AMCL cannot publish a pose or update the transform. Please set the initial pose...
[amcl-2] [WARN] [1726260774.392645915] [amcl]: AMCL cannot publish a pose or update the transform. Please set the initial pose...
[amcl-2] [WARN] [1726260776.481303374] [amcl]: AMCL cannot publish a pose or update the transform. Please set the initial pose...
[amcl-2] [WARN] [1726260778.493120189] [amcl]: AMCL cannot publish a pose or update the transform. Please set the initial pose...
[amcl-2] [WARN] [1726260780.499769705] [amcl]: AMCL cannot publish a pose or update the transform. Please set the initial pose...
[amcl-2] [WARN] [1726260782.529359600] [amcl]: AMCL cannot publish a pose or update the transform. Please set the initial pose...
[amcl-2] [WARN] [1726260784.533451565] [amcl]: AMCL cannot publish a pose or update the transform. Please set the initial pose...
[amcl-2] [WARN] [1726260786.593174609] [amcl]: AMCL cannot publish a pose or update the transform. Please set the initial pose...
[amcl-2] [WARN] [1726260788.635358370] [amcl]: AMCL cannot publish a pose or update the transform. Please set the initial pose...
[amcl-2] [WARN] [1726260790.790227505] [amcl]: AMCL cannot publish a pose or update the transform. Please set the initial pose...
[amcl-2] [WARN] [1726260792.800804637] [amcl]: AMCL cannot publish a pose or update the transform. Please set the initial pose...
[amcl-2] [WARN] [1726260794.837358941] [amcl]: AMCL cannot publish a pose or update the transform. Please set the initial pose...
[amcl-2] [WARN] [1726260796.892083680] [amcl]: AMCL cannot publish a pose or update the transform. Please set the initial pose...
[amcl-2] [WARN] [1726260798.931796197] [amcl]: AMCL cannot publish a pose or update the transform. Please set the initial pose...
[amcl-2] [WARN] [1726260801.089906116] [amcl]: AMCL cannot publish a pose or update the transform. Please set the initial pose...
[amcl-2] [WARN] [1726260803.095597429] [amcl]: AMCL cannot publish a pose or update the transform. Please set the initial pose...
[amcl-2] [WARN] [1726260805.131669252] [amcl]: AMCL cannot publish a pose or update the transform. Please set the initial pose...
[amcl-2] [WARN] [1726260807.192199788] [amcl]: AMCL cannot publish a pose or update the transform. Please set the initial pose...
[amcl-2] [WARN] [1726260809.204753951] [amcl]: AMCL cannot publish a pose or update the transform. Please set the initial pose...
[amcl-2] [WARN] [1726260811.235314311] [amcl]: AMCL cannot publish a pose or update the transform. Please set the initial pose...
[amcl-2] [WARN] [1726260813.294502179] [amcl]: AMCL cannot publish a pose or update the transform. Please set the initial pose...
[amcl-2] [WARN] [1726260815.321780079] [amcl]: AMCL cannot publish a pose or update the transform. Please set the initial pose...
[amcl-2] [WARN] [1726260817.337651636] [amcl]: AMCL cannot publish a pose or update the transform. Please set the initial pose...
[amcl-2] [WARN] [1726260819.490639884] [amcl]: AMCL cannot publish a pose or update the transform. Please set the initial pose...
[amcl-2] [WARN] [1726260821.534726564] [amcl]: AMCL cannot publish a pose or update the transform. Please set the initial pose...
[amcl-2] [WARN] [1726260823.599306048] [amcl]: AMCL cannot publish a pose or update the transform. Please set the initial pose...
[amcl-2] [WARN] [1726260825.732267361] [amcl]: AMCL cannot publish a pose or update the transform. Please set the initial pose...
[amcl-2] [WARN] [1726260827.734740721] [amcl]: AMCL cannot publish a pose or update the transform. Please set the initial pose...
[amcl-2] [WARN] [1726260829.788403208] [amcl]: AMCL cannot publish a pose or update the transform. Please set the initial pose...
[amcl-2] [WARN] [1726260831.930044269] [amcl]: AMCL cannot publish a pose or update the transform. Please set the initial pose...
[amcl-2] [WARN] [1726260833.989823434] [amcl]: AMCL cannot publish a pose or update the transform. Please set the initial pose...
[amcl-2] [WARN] [1726260836.129902773] [amcl]: AMCL cannot publish a pose or update the transform. Please set the initial pose...
[amcl-2] [WARN] [1726260838.134984520] [amcl]: AMCL cannot publish a pose or update the transform. Please set the initial pose...
[amcl-2] [WARN] [1726260840.184767441] [amcl]: AMCL cannot publish a pose or update the transform. Please set the initial pose...
[amcl-2] [INFO] [1726260841.539704294] [amcl]: initialPoseReceived
[amcl-2] [WARN] [1726260841.540136813] [amcl]: Failed to transform initial pose in time (Lookup would require extrapolation into the future.  Requested time<PHONE_NUMBER>.539869 but the latest data is at time<PHONE_NUMBER>.477453, when looking up transform from frame [base_link] to frame [odom])
[amcl-2] [INFO] [1726260841.540248136] [amcl]: Setting pose<PHONE_NUMBER>.540247): 0.451 -24.106 -3.071
[amcl-2] [INFO] [1726260849.029340696] [amcl]: initialPoseReceived
[amcl-2] [WARN] [1726260849.029695591] [amcl]: Failed to transform initial pose in time (Lookup would require extrapolation into the future.  Requested time<PHONE_NUMBER>.029562 but the latest data is at time<PHONE_NUMBER>.980560, when looking up transform from frame [base_link] to frame [odom])
[amcl-2] [INFO] [1726260849.029862728] [amcl]: Setting pose<PHONE_NUMBER>.029862): 0.522 -24.138 -3.123
[amcl-2] [INFO] [1726260857.127122247] [amcl]: initialPoseReceived
[amcl-2] [WARN] [1726260857.127212914] [amcl]: Failed to transform initial pose in time (Lookup would require extrapolation into the future.  Requested time<PHONE_NUMBER>.127164 but the latest data is at time<PHONE_NUMBER>.029737, when looking up transform from frame [base_link] to frame [odom])
[amcl-2] [INFO] [1726260857.127238600] [amcl]: Setting pose<PHONE_NUMBER>.127239): 0.502 -24.269 3.116
[amcl-2] [INFO] [1726260865.302901101] [amcl]: initialPoseReceived
[amcl-2] [WARN] [1726260865.303006160] [amcl]: Failed to transform initial pose in time (Lookup would require extrapolation into the future.  Requested time<PHONE_NUMBER>.302943 but the latest data is at time<PHONE_NUMBER>.222835, when looking up transform from frame [base_link] to frame [odom])
[amcl-2] [INFO] [1726260865.303034315] [amcl]: Setting pose<PHONE_NUMBER>.303034): 0.527 -24.358 -3.134
[amcl-2] [INFO] [1726260872.092745123] [amcl]: initialPoseReceived
[amcl-2] [WARN] [1726260872.092867290] [amcl]: Failed to transform initial pose in time (Lookup would require extrapolation into the future.  Requested time<PHONE_NUMBER>.092801 but the latest data is at time<PHONE_NUMBER>.021836, when looking up transform from frame [base_link] to frame [odom])
[amcl-2] [INFO] [1726260872.092906877] [amcl]: Setting pose<PHONE_NUMBER>.092907): 0.597 -24.449 3.057
[amcl-2] [INFO] [1726260977.232779189] [amcl]: Message Filter dropping message: frame 'rplidar_link' at time<PHONE_NUMBER>.654 for reason 'discarding message because the queue is full'
[amcl-2] [INFO] [1726260977.367344168] [amcl]: Message Filter dropping message: frame 'rplidar_link' at time<PHONE_NUMBER>.777 for reason 'the timestamp on the message is earlier than all the data in the transform cache'
[amcl-2] [INFO] [1726260977.395209172] [amcl]: Message Filter dropping message: frame 'rplidar_link' at time<PHONE_NUMBER>.912 for reason 'the timestamp on the message is earlier than all the data in the transform cache'
[amcl-2] [INFO] [1726260977.493471133] [amcl]: Message Filter dropping message: frame 'rplidar_link' at time<PHONE_NUMBER>.035 for reason 'discarding message because the queue is full'
[amcl-2] [INFO] [1726260977.528298893] [amcl]: Message Filter dropping message: frame 'rplidar_link' at time<PHONE_NUMBER>.170 for reason 'discarding message because the queue is full'
[amcl-2] [INFO] [1726260977.682360804] [amcl]: Message Filter dropping message: frame 'rplidar_link' at time<PHONE_NUMBER>.293 for reason 'the timestamp on the message is earlier than all the data in the transform cache'
[amcl-2] [INFO] [1726260977.851396699] [amcl]: Message Filter dropping message: frame 'rplidar_link' at time<PHONE_NUMBER>.416 for reason 'the timestamp on the message is earlier than all the data in the transform cache'
[amcl-2] [INFO] [1726260978.234537421] [amcl]: Message Filter dropping message: frame 'rplidar_link' at time<PHONE_NUMBER>.932 for reason 'the timestamp on the message is earlier than all the data in the transform cache'
[amcl-2] [INFO] [1726260978.373043295] [amcl]: Message Filter dropping message: frame 'rplidar_link' at time<PHONE_NUMBER>.055 for reason 'the timestamp on the message is earlier than all the data in the transform cache'
[amcl-2] [INFO] [1726260978.528863363] [amcl]: Message Filter dropping message: frame 'rplidar_link' at time<PHONE_NUMBER>.436 for reason 'the timestamp on the message is earlier than all the data in the transform cache'
[amcl-2] [INFO] [1726260978.718702148] [amcl]: Message Filter dropping message: frame 'rplidar_link' at time<PHONE_NUMBER>.558 for reason 'the timestamp on the message is earlier than all the data in the transform cache'

Hi @RustyCPR, @smatarCPR
Any feedback on this? I realized that this is a common issue but this issue always gets closed. I would like to dive deeper into the cause of this.
Thanks

Hello @xylhal
Apologies for the delay on this we are still processing the data from the logs, but we will provide an update soon.
Best Regards,
Saif

Hi @xylhal, @RustyCPR, and @smatarCPR
I recently got into the same issue with my robot.

[lifecycle_manager-3] [ERROR] [1726260758.835965461] [lifecycle_manager_localization]: Failed to change state for node: amcl. Exception: transition invoked while in transition.

I found that this error is raised at this line, and it may be a timing-related issue while creating a bond between a lifecycle manager and a node, in this case, amcl.
https://github.com/ros/bond_core/blob/52e181c717186185cb25fed62ed95a16804b5a17/smclib/include/smclib/statemap.hpp#L168
I plan to look into it, but I just wanted to tell you what I found.
Best regards,

https://github.com/ros/bond_core/pull/97
I made a PR to bond_core, which may fix this issue.
Best,

@daisukes Thank you, please let us know if you have any update on whether your PR fixed the issue.
@RustyCPR, @smatarCPR Please also let me know what your findings are

@xylhal the logs that you provided are all from the localization launch, can you please share the log from the nav2 launch command that you are using? Additionally, can you clarify where you are running the localization / nav nodes? We recommend running them offboard, on a separate machine that runs Ubuntu natively (not on the turtlebot itself).
@daisukes I took a quick look at your PR and although your comment says that you want the change included on Humble, the PR is for Galactic. Galactic is end of life and is no longer supported, if you want them to look at your PR I would suggest creating a new one for Humble.

@daisukes I took a quick look at your PR and although your comment says that you want the change included on Humble, the PR is for Galactic. Galactic is end of life and is no longer supported, if you want them to look at your PR I would suggest creating a new one for Humble.

Thanks for the check!
There is no humble branch in bond_core, and humble use 3.0.2, equivalent to the galactic branch.
I've tried the ros2 branch, but it might have an API change and won't work with humble nav2.
Do you have any suggestions?
https://github.com/ros2-gbp/bond_core-release/tree/master?tab=readme-ov-file#bond_core-humble---302-3

@hilary-luo Apologies, here is the screenshot of the error we faced when running nav2 launch command. Although the error above from running the localization sometimes occurs as well, but most of the them, the error comes from launching nav2. And I am currently running them offboard on a dedicated Ubuntu machine following the discovery server architecture
~/turtlebot4_ws$ ros2 launch turtlebot4_navigation nav2.launch.py
[INFO] [launch]: All log files can be found below /home/.ros/log/2024-11-01-12-53-01-563861-iMac-797603
[INFO] [launch]: Default logging verbosity is set to INFO
[INFO] [controller_server-1]: process started with pid [797604]
[INFO] [smoother_server-2]: process started with pid [797606]
[INFO] [planner_server-3]: process started with pid [797608]
[INFO] [behavior_server-4]: process started with pid [797610]
[INFO] [bt_navigator-5]: process started with pid [797612]
[INFO] [waypoint_follower-6]: process started with pid [797614]
[INFO] [velocity_smoother-7]: process started with pid [797616]
[INFO] [lifecycle_manager-8]: process started with pid [797618]
[planner_server-3] [INFO] [1730490781.976843993] [planner_server]:
[planner_server-3] 	planner_server lifecycle node launched.
[planner_server-3] 	Waiting on external lifecycle transitions to activate
[planner_server-3] 	See https://design.ros2.org/articles/node_lifecycle.html for more information.
[smoother_server-2] [INFO] [1730490781.979593777] [smoother_server]:
[smoother_server-2] 	smoother_server lifecycle node launched.
[smoother_server-2] 	Waiting on external lifecycle transitions to activate
[smoother_server-2] 	See https://design.ros2.org/articles/node_lifecycle.html for more information.
[bt_navigator-5] [INFO] [1730490781.993174885] [bt_navigator]:
[bt_navigator-5] 	bt_navigator lifecycle node launched.
[bt_navigator-5] 	Waiting on external lifecycle transitions to activate
[bt_navigator-5] 	See https://design.ros2.org/articles/node_lifecycle.html for more information.
[bt_navigator-5] [INFO] [1730490781.993324240] [bt_navigator]: Creating
[smoother_server-2] [INFO] [1730490781.998475878] [smoother_server]: Creating smoother server
[planner_server-3] [INFO] [1730490782.000698533] [planner_server]: Creating
[waypoint_follower-6] [INFO] [1730490782.002810615] [waypoint_follower]:
[waypoint_follower-6] 	waypoint_follower lifecycle node launched.
[waypoint_follower-6] 	Waiting on external lifecycle transitions to activate
[waypoint_follower-6] 	See https://design.ros2.org/articles/node_lifecycle.html for more information.
[velocity_smoother-7] [INFO] [1730490782.007289702] [velocity_smoother]:
[velocity_smoother-7] 	velocity_smoother lifecycle node launched.
[velocity_smoother-7] 	Waiting on external lifecycle transitions to activate
[velocity_smoother-7] 	See https://design.ros2.org/articles/node_lifecycle.html for more information.
[waypoint_follower-6] [INFO] [1730490782.010565170] [waypoint_follower]: Creating
[controller_server-1] [INFO] [1730490782.012620460] [controller_server]:
[controller_server-1] 	controller_server lifecycle node launched.
[controller_server-1] 	Waiting on external lifecycle transitions to activate
[controller_server-1] 	See https://design.ros2.org/articles/node_lifecycle.html for more information.
[planner_server-3] [INFO] [1730490782.015495857] [global_costmap.global_costmap]:
[planner_server-3] 	global_costmap lifecycle node launched.
[planner_server-3] 	Waiting on external lifecycle transitions to activate
[planner_server-3] 	See https://design.ros2.org/articles/node_lifecycle.html for more information.
[behavior_server-4] [INFO] [1730490782.016740095] [behavior_server]:
[behavior_server-4] 	behavior_server lifecycle node launched.
[behavior_server-4] 	Waiting on external lifecycle transitions to activate
[behavior_server-4] 	See https://design.ros2.org/articles/node_lifecycle.html for more information.
[controller_server-1] [INFO] [1730490782.021188771] [controller_server]: Creating controller server
[planner_server-3] [INFO] [1730490782.022262209] [global_costmap.global_costmap]: Creating Costmap
[lifecycle_manager-8] [INFO] [1730490782.022583267] [lifecycle_manager_navigation]: Creating
[lifecycle_manager-8] [INFO] [1730490782.024381683] [lifecycle_manager_navigation]: Creating and initializing lifecycle service clients
[controller_server-1] [INFO] [1730490782.027705975] [local_costmap.local_costmap]:
[controller_server-1] 	local_costmap lifecycle node launched.
[controller_server-1] 	Waiting on external lifecycle transitions to activate
[controller_server-1] 	See https://design.ros2.org/articles/node_lifecycle.html for more information.
[controller_server-1] [INFO] [1730490782.028262660] [local_costmap.local_costmap]: Creating Costmap
[lifecycle_manager-8] [INFO] [1730490784.025644963] [lifecycle_manager_navigation]: Waiting for service controller_server/get_state...
[lifecycle_manager-8] [INFO] [1730490786.026172570] [lifecycle_manager_navigation]: Waiting for service controller_server/get_state...
[lifecycle_manager-8] [INFO] [1730490786.149798928] [lifecycle_manager_navigation]: Starting managed nodes bringup...
[lifecycle_manager-8] [INFO] [1730490786.149847865] [lifecycle_manager_navigation]: Configuring controller_server
[controller_server-1] [INFO] [1730490786.150178719] [controller_server]: Configuring controller interface
[controller_server-1] [INFO] [1730490786.150822070] [controller_server]: getting goal checker plugins..
[controller_server-1] [INFO] [1730490786.151235480] [controller_server]: Controller frequency set to 20.0000Hz
[controller_server-1] [INFO] [1730490786.151287888] [local_costmap.local_costmap]: Configuring
[controller_server-1] [INFO] [1730490786.159505710] [local_costmap.local_costmap]: Using plugin "static_layer"
[controller_server-1] [INFO] [1730490786.164340312] [local_costmap.local_costmap]: Subscribing to the map topic (/map) with transient local durability
[controller_server-1] [INFO] [1730490786.165983064] [local_costmap.local_costmap]: Initialized plugin "static_layer"
[controller_server-1] [INFO] [1730490786.166019785] [local_costmap.local_costmap]: Using plugin "voxel_layer"
[controller_server-1] [INFO] [1730490786.167386301] [local_costmap.local_costmap]: Subscribed to Topics: scan
[controller_server-1] [INFO] [1730490786.178629082] [local_costmap.local_costmap]: Initialized plugin "voxel_layer"
[controller_server-1] [INFO] [1730490786.178669909] [local_costmap.local_costmap]: Using plugin "inflation_layer"
[controller_server-1] [INFO] [1730490786.181501226] [local_costmap.local_costmap]: Initialized plugin "inflation_layer"
[controller_server-1] [INFO] [1730490786.193335752] [controller_server]: Created progress_checker : progress_checker of type nav2_controller::SimpleProgressChecker
[controller_server-1] [INFO] [1730490786.194380194] [controller_server]: Created goal checker : general_goal_checker of type nav2_controller::SimpleGoalChecker
[controller_server-1] [INFO] [1730490786.195646203] [controller_server]: Controller Server has general_goal_checker  goal checkers available.
[controller_server-1] [INFO] [1730490786.197504904] [controller_server]: Created controller : FollowPath of type dwb_core::DWBLocalPlanner
[controller_server-1] [INFO] [1730490786.199812368] [controller_server]: Setting transform_tolerance to 0.200000
[controller_server-1] [INFO] [1730490786.220061555] [controller_server]: Using critic "RotateToGoal" (dwb_critics::RotateToGoalCritic)
[controller_server-1] [INFO] [1730490786.221268136] [controller_server]: Critic plugin initialized
[controller_server-1] [INFO] [1730490786.221527939] [controller_server]: Using critic "Oscillation" (dwb_critics::OscillationCritic)
[controller_server-1] [INFO] [1730490786.222430116] [controller_server]: Critic plugin initialized
[controller_server-1] [INFO] [1730490786.222655996] [controller_server]: Using critic "BaseObstacle" (dwb_critics::BaseObstacleCritic)
[controller_server-1] [INFO] [1730490786.223017277] [controller_server]: Critic plugin initialized
[controller_server-1] [INFO] [1730490786.223214010] [controller_server]: Using critic "GoalAlign" (dwb_critics::GoalAlignCritic)
[controller_server-1] [INFO] [1730490786.228808436] [controller_server]: Critic plugin initialized
[controller_server-1] [INFO] [1730490786.229140930] [controller_server]: Using critic "PathAlign" (dwb_critics::PathAlignCritic)
[controller_server-1] [INFO] [1730490786.229743418] [controller_server]: Critic plugin initialized
[controller_server-1] [INFO] [1730490786.229968462] [controller_server]: Using critic "PathDist" (dwb_critics::PathDistCritic)
[controller_server-1] [INFO] [1730490786.230387334] [controller_server]: Critic plugin initialized
[controller_server-1] [INFO] [1730490786.230615356] [controller_server]: Using critic "GoalDist" (dwb_critics::GoalDistCritic)
[controller_server-1] [INFO] [1730490786.231594454] [controller_server]: Critic plugin initialized
[controller_server-1] [INFO] [1730490786.231634354] [controller_server]: Controller Server has FollowPath  controllers available.
[lifecycle_manager-8] [INFO] [1730490786.243495502] [lifecycle_manager_navigation]: Configuring smoother_server
[smoother_server-2] [INFO] [1730490791.386230954] [smoother_server]: Configuring smoother server
[smoother_server-2] [INFO] [1730490791.470714579] [smoother_server]: Created smoother : simple_smoother of type nav2_smoother::SimpleSmoother
[smoother_server-2] [INFO] [1730490791.474019006] [smoother_server]: Smoother Server has simple_smoother  smoothers available.
[smoother_server-2] [WARN] [1730490791.588452217] [smoother_server.rclcpp]: failed to send response to /smoother_server/change_state (timeout): client will not receive response, at ./src/rmw_response.cpp:154, at ./src/rcl/service.c:314
[controller_server-1] [INFO] [1730490798.341902004] [local_costmap.local_costmap]: StaticLayer: Resizing static layer to 615 X 866 at 0.050000 m/pix

@hilary-luo This is from a different session of re-running the nav2 launch file
`~/turtlebot4_ws$ ros2 launch turtlebot4_navigation nav2.launch.py
[INFO] [launch]: All log files can be found below /home/.ros/log/2024-11-01-13-03-28-962151-iMac-798691
[INFO] [launch]: Default logging verbosity is set to INFO
[INFO] [controller_server-1]: process started with pid [798692]
[INFO] [smoother_server-2]: process started with pid [798694]
[INFO] [planner_server-3]: process started with pid [798696]
[INFO] [behavior_server-4]: process started with pid [798698]
[INFO] [bt_navigator-5]: process started with pid [798700]
[INFO] [waypoint_follower-6]: process started with pid [798702]
[INFO] [velocity_smoother-7]: process started with pid [798704]
[INFO] [lifecycle_manager-8]: process started with pid [798706]
[behavior_server-4] [INFO] [1730491409.382424999] [behavior_server]:
[behavior_server-4] 	behavior_server lifecycle node launched.
[behavior_server-4] 	Waiting on external lifecycle transitions to activate
[behavior_server-4] 	See https://design.ros2.org/articles/node_lifecycle.html for more information.
[planner_server-3] [INFO] [1730491409.387354568] [planner_server]:
[planner_server-3] 	planner_server lifecycle node launched.
[planner_server-3] 	Waiting on external lifecycle transitions to activate
[planner_server-3] 	See https://design.ros2.org/articles/node_lifecycle.html for more information.
[velocity_smoother-7] [INFO] [1730491409.389075560] [velocity_smoother]:
[velocity_smoother-7] 	velocity_smoother lifecycle node launched.
[velocity_smoother-7] 	Waiting on external lifecycle transitions to activate
[velocity_smoother-7] 	See https://design.ros2.org/articles/node_lifecycle.html for more information.
[controller_server-1] [INFO] [1730491409.390346802] [controller_server]:
[controller_server-1] 	controller_server lifecycle node launched.
[controller_server-1] 	Waiting on external lifecycle transitions to activate
[controller_server-1] 	See https://design.ros2.org/articles/node_lifecycle.html for more information.
[planner_server-3] [INFO] [1730491409.394796486] [planner_server]: Creating
[controller_server-1] [INFO] [1730491409.396629725] [controller_server]: Creating controller server
[smoother_server-2] [INFO] [1730491409.398142869] [smoother_server]:
[smoother_server-2] 	smoother_server lifecycle node launched.
[smoother_server-2] 	Waiting on external lifecycle transitions to activate
[smoother_server-2] 	See https://design.ros2.org/articles/node_lifecycle.html for more information.
[smoother_server-2] [INFO] [1730491409.402195659] [smoother_server]: Creating smoother server
[controller_server-1] [INFO] [1730491409.404122805] [local_costmap.local_costmap]:
[controller_server-1] 	local_costmap lifecycle node launched.
[controller_server-1] 	Waiting on external lifecycle transitions to activate
[controller_server-1] 	See https://design.ros2.org/articles/node_lifecycle.html for more information.
[controller_server-1] [INFO] [1730491409.405062683] [local_costmap.local_costmap]: Creating Costmap
[planner_server-3] [INFO] [1730491409.409072905] [global_costmap.global_costmap]:
[planner_server-3] 	global_costmap lifecycle node launched.
[planner_server-3] 	Waiting on external lifecycle transitions to activate
[planner_server-3] 	See https://design.ros2.org/articles/node_lifecycle.html for more information.
[planner_server-3] [INFO] [1730491409.409607709] [global_costmap.global_costmap]: Creating Costmap
[lifecycle_manager-8] [INFO] [1730491409.415954329] [lifecycle_manager_navigation]: Creating
[waypoint_follower-6] [INFO] [1730491409.416887030] [waypoint_follower]:
[waypoint_follower-6] 	waypoint_follower lifecycle node launched.
[waypoint_follower-6] 	Waiting on external lifecycle transitions to activate
[waypoint_follower-6] 	See https://design.ros2.org/articles/node_lifecycle.html for more information.
[waypoint_follower-6] [INFO] [1730491409.417477151] [waypoint_follower]: Creating
[lifecycle_manager-8] [INFO] [1730491409.418233154] [lifecycle_manager_navigation]: Creating and initializing lifecycle service clients
[bt_navigator-5] [INFO] [1730491409.419928671] [bt_navigator]:
[bt_navigator-5] 	bt_navigator lifecycle node launched.
[bt_navigator-5] 	Waiting on external lifecycle transitions to activate
[bt_navigator-5] 	See https://design.ros2.org/articles/node_lifecycle.html for more information.
[bt_navigator-5] [INFO] [1730491409.420038891] [bt_navigator]: Creating
[lifecycle_manager-8] [INFO] [1730491411.419620761] [lifecycle_manager_navigation]: Waiting for service controller_server/get_state...
[lifecycle_manager-8] [INFO] [1730491413.431492682] [lifecycle_manager_navigation]: Starting managed nodes bringup...
[lifecycle_manager-8] [INFO] [1730491413.431895578] [lifecycle_manager_navigation]: Configuring controller_server
[controller_server-1] [INFO] [1730491413.435375529] [controller_server]: Configuring controller interface
[controller_server-1] [INFO] [1730491413.439997063] [controller_server]: getting goal checker plugins..
[controller_server-1] [INFO] [1730491413.451373748] [controller_server]: Controller frequency set to 20.0000Hz
[controller_server-1] [INFO] [1730491413.455163536] [local_costmap.local_costmap]: Configuring
[controller_server-1] [INFO] [1730491413.494030208] [local_costmap.local_costmap]: Using plugin "static_layer"
[controller_server-1] [INFO] [1730491413.503518598] [local_costmap.local_costmap]: Subscribing to the map topic (/map) with transient local durability
[controller_server-1] [INFO] [1730491413.508482258] [local_costmap.local_costmap]: Initialized plugin "static_layer"
[controller_server-1] [INFO] [1730491413.508537738] [local_costmap.local_costmap]: Using plugin "voxel_layer"
[controller_server-1] [INFO] [1730491413.512292888] [local_costmap.local_costmap]: Subscribed to Topics: scan
[controller_server-1] [INFO] [1730491413.527473349] [local_costmap.local_costmap]: Initialized plugin "voxel_layer"
[controller_server-1] [INFO] [1730491413.527527954] [local_costmap.local_costmap]: Using plugin "inflation_layer"
[controller_server-1] [INFO] [1730491413.528800583] [local_costmap.local_costmap]: Initialized plugin "inflation_layer"
[controller_server-1] [INFO] [1730491413.542775882] [controller_server]: Created progress_checker : progress_checker of type nav2_controller::SimpleProgressChecker
[controller_server-1] [INFO] [1730491413.544356124] [controller_server]: Created goal checker : general_goal_checker of type nav2_controller::SimpleGoalChecker
[controller_server-1] [INFO] [1730491413.545015609] [controller_server]: Controller Server has general_goal_checker  goal checkers available.
[controller_server-1] [INFO] [1730491413.546834473] [controller_server]: Created controller : FollowPath of type dwb_core::DWBLocalPlanner
[controller_server-1] [INFO] [1730491413.548840902] [controller_server]: Setting transform_tolerance to 0.200000
[controller_server-1] [INFO] [1730491413.573882422] [controller_server]: Using critic "RotateToGoal" (dwb_critics::RotateToGoalCritic)
[controller_server-1] [INFO] [1730491413.575788658] [controller_server]: Critic plugin initialized
[controller_server-1] [INFO] [1730491413.576044222] [controller_server]: Using critic "Oscillation" (dwb_critics::OscillationCritic)
[controller_server-1] [INFO] [1730491413.577728601] [controller_server]: Critic plugin initialized
[controller_server-1] [INFO] [1730491413.578130458] [controller_server]: Using critic "BaseObstacle" (dwb_critics::BaseObstacleCritic)
[controller_server-1] [INFO] [1730491413.578953310] [controller_server]: Critic plugin initialized
[controller_server-1] [INFO] [1730491413.579362270] [controller_server]: Using critic "GoalAlign" (dwb_critics::GoalAlignCritic)
[controller_server-1] [INFO] [1730491413.580370966] [controller_server]: Critic plugin initialized
[controller_server-1] [INFO] [1730491413.580593899] [controller_server]: Using critic "PathAlign" (dwb_critics::PathAlignCritic)
[controller_server-1] [INFO] [1730491413.582345469] [controller_server]: Critic plugin initialized
[controller_server-1] [INFO] [1730491413.582750961] [controller_server]: Using critic "PathDist" (dwb_critics::PathDistCritic)
[controller_server-1] [INFO] [1730491413.583623415] [controller_server]: Critic plugin initialized
[controller_server-1] [INFO] [1730491413.584113059] [controller_server]: Using critic "GoalDist" (dwb_critics::GoalDistCritic)
[controller_server-1] [INFO] [1730491413.585511370] [controller_server]: Critic plugin initialized
[controller_server-1] [INFO] [1730491413.585562340] [controller_server]: Controller Server has FollowPath  controllers available.
[lifecycle_manager-8] [INFO] [1730491413.597895524] [lifecycle_manager_navigation]: Configuring smoother_server
[smoother_server-2] [INFO] [1730491416.438685242] [smoother_server]: Configuring smoother server
[smoother_server-2] [INFO] [1730491416.519824384] [smoother_server]: Created smoother : simple_smoother of type nav2_smoother::SimpleSmoother
[smoother_server-2] [INFO] [1730491416.523847128] [smoother_server]: Smoother Server has simple_smoother  smoothers available.
[lifecycle_manager-8] [INFO] [1730491416.534255447] [lifecycle_manager_navigation]: Configuring planner_server
[planner_server-3] [INFO] [1730491416.534577649] [planner_server]: Configuring
[planner_server-3] [INFO] [1730491416.534613701] [global_costmap.global_costmap]: Configuring
[planner_server-3] [INFO] [1730491416.545457307] [global_costmap.global_costmap]: Using plugin "static_layer"
[planner_server-3] [INFO] [1730491416.552214808] [global_costmap.global_costmap]: Subscribing to the map topic (/map) with transient local durability
[planner_server-3] [INFO] [1730491416.554768000] [global_costmap.global_costmap]: Initialized plugin "static_layer"
[planner_server-3] [INFO] [1730491416.554814527] [global_costmap.global_costmap]: Using plugin "obstacle_layer"
[planner_server-3] [INFO] [1730491416.558558481] [global_costmap.global_costmap]: Subscribed to Topics: scan
[planner_server-3] [INFO] [1730491416.568221045] [global_costmap.global_costmap]: Initialized plugin "obstacle_layer"
[planner_server-3] [INFO] [1730491416.568255001] [global_costmap.global_costmap]: Using plugin "inflation_layer"
[planner_server-3] [INFO] [1730491416.569872568] [global_costmap.global_costmap]: Initialized plugin "inflation_layer"
[planner_server-3] [INFO] [1730491416.594632852] [planner_server]: Created global planner plugin GridBased of type nav2_navfn_planner/NavfnPlanner
[planner_server-3] [INFO] [1730491416.594672842] [planner_server]: Configuring plugin GridBased of type NavfnPlanner
[planner_server-3] [INFO] [1730491416.596340908] [planner_server]: Planner Server has GridBased  planners available.
[lifecycle_manager-8] [INFO] [1730491416.615512703] [lifecycle_manager_navigation]: Configuring behavior_server
[behavior_server-4] [INFO] [1730491416.615773326] [behavior_server]: Configuring
[behavior_server-4] [INFO] [1730491416.631017344] [behavior_server]: Creating behavior plugin spin of type nav2_behaviors/Spin
[behavior_server-4] [INFO] [1730491416.631896338] [behavior_server]: Configuring spin
[behavior_server-4] [INFO] [1730491416.641514662] [behavior_server]: Creating behavior plugin backup of type nav2_behaviors/BackUp
[behavior_server-4] [INFO] [1730491416.642597692] [behavior_server]: Configuring backup
[behavior_server-4] [INFO] [1730491416.653477271] [behavior_server]: Creating behavior plugin drive_on_heading of type nav2_behaviors/DriveOnHeading
[behavior_server-4] [INFO] [1730491416.654388926] [behavior_server]: Configuring drive_on_heading
[behavior_server-4] [INFO] [1730491416.661897725] [behavior_server]: Creating behavior plugin assisted_teleop of type nav2_behaviors/AssistedTeleop
[behavior_server-4] [INFO] [1730491416.663421982] [behavior_server]: Configuring assisted_teleop
[controller_server-1] [INFO] [1730491416.670739072] [local_costmap.local_costmap]: StaticLayer: Resizing static layer to 615 X 866 at 0.050000 m/pix
[behavior_server-4] [INFO] [1730491416.681505849] [behavior_server]: Creating behavior plugin wait of type nav2_behaviors/Wait
[behavior_server-4] [INFO] [1730491416.682343399] [behavior_server]: Configuring wait
[lifecycle_manager-8] [INFO] [1730491416.701783946] [lifecycle_manager_navigation]: Configuring bt_navigator
[bt_navigator-5] [INFO] [1730491416.702026112] [bt_navigator]: Configuring
[lifecycle_manager-8] [INFO] [1730491416.813230314] [lifecycle_manager_navigation]: Configuring waypoint_follower
[waypoint_follower-6] [INFO] [1730491416.813516454] [waypoint_follower]: Configuring
[waypoint_follower-6] [INFO] [1730491416.824753593] [waypoint_follower]: Created waypoint_task_executor : wait_at_waypoint of type nav2_waypoint_follower::WaitAtWaypoint
[lifecycle_manager-8] [INFO] [1730491416.826780829] [lifecycle_manager_navigation]: Configuring velocity_smoother
[velocity_smoother-7] [INFO] [1730491416.827079895] [velocity_smoother]: Configuring velocity smoother
[lifecycle_manager-8] [INFO] [1730491416.845764759] [lifecycle_manager_navigation]: Activating controller_server
[controller_server-1] [INFO] [1730491416.846143424] [controller_server]: Activating
[controller_server-1] [INFO] [1730491416.846176797] [local_costmap.local_costmap]: Activating
[controller_server-1] [INFO] [1730491416.846190198] [local_costmap.local_costmap]: Checking transform
[controller_server-1] [INFO] [1730491416.846340609] [local_costmap.local_costmap]: start
[controller_server-1] [INFO] [1730491417.097963466] [controller_server]: Creating bond (controller_server) to lifecycle manager.
[lifecycle_manager-8] [INFO] [1730491417.224351664] [lifecycle_manager_navigation]: Server controller_server connected with bond.
[lifecycle_manager-8] [INFO] [1730491417.224665986] [lifecycle_manager_navigation]: Activating smoother_server
[smoother_server-2] [INFO] [1730491417.226187102] [smoother_server]: Activating
[smoother_server-2] [INFO] [1730491417.226408413] [smoother_server]: Creating bond (smoother_server) to lifecycle manager.
[lifecycle_manager-8] [INFO] [1730491417.357861674] [lifecycle_manager_navigation]: Server smoother_server connected with bond.
[lifecycle_manager-8] [INFO] [1730491417.358081977] [lifecycle_manager_navigation]: Activating planner_server
[planner_server-3] [INFO] [1730491417.359853146] [planner_server]: Activating
[planner_server-3] [INFO] [1730491417.360054954] [global_costmap.global_costmap]: Activating
[planner_server-3] [INFO] [1730491417.360143500] [global_costmap.global_costmap]: Checking transform
[planner_server-3] [INFO] [1730491417.360267863] [global_costmap.global_costmap]: Timed out waiting for transform from base_link to map to become available, tf error: Invalid frame ID "map" passed to canTransform argument target_frame - frame does not exist
[planner_server-3] [INFO] [1730491417.701870291] [global_costmap.global_costmap]: StaticLayer: Resizing costmap to 615 X 866 at 0.050000 m/pix
[planner_server-3] [INFO] [1730491417.860485983] [global_costmap.global_costmap]: Timed out waiting for transform from base_link to map to become available, tf error: Lookup would require extrapolation into the past.  Requested time<PHONE_NUMBER>.793022 but the earliest data is at time<PHONE_NUMBER>.618683, when looking up transform from frame [base_link] to frame [map]
[controller_server-1] [INFO] [1730491418.337218527] [local_costmap.local_costmap]: Message Filter dropping message: frame 'rplidar_link' at time<PHONE_NUMBER>.999 for reason 'the timestamp on the message is earlier than all the data in the transform cache'
[planner_server-3] [INFO] [1730491418.360320052] [global_costmap.global_costmap]: Timed out waiting for transform from base_link to map to become available, tf error: Lookup would require extrapolation into the past.  Requested time<PHONE_NUMBER>.049098 but the earliest data is at time<PHONE_NUMBER>.618683, when looking up transform from frame [base_link] to frame [map]
[controller_server-1] [INFO] [1730491418.565687528] [local_costmap.local_costmap]: Message Filter dropping message: frame 'rplidar_link' at time<PHONE_NUMBER>.257 for reason 'the timestamp on the message is earlier than all the data in the transform cache'
[planner_server-3] [INFO] [1730491418.860521567] [global_costmap.global_costmap]: start
[planner_server-3] [INFO] [1730491419.963419420] [planner_server]: Activating plugin GridBased of type NavfnPlanner
[planner_server-3] [INFO] [1730491419.968374457] [planner_server]: Creating bond (planner_server) to lifecycle manager.
[lifecycle_manager-8] [INFO] [1730491420.217792727] [lifecycle_manager_navigation]: Server planner_server connected with bond.
[lifecycle_manager-8] [INFO] [1730491420.217901349] [lifecycle_manager_navigation]: Activating behavior_server
[behavior_server-4] [INFO] [1730491420.222494287] [behavior_server]: Activating
[behavior_server-4] [INFO] [1730491420.222772490] [behavior_server]: Activating spin
[behavior_server-4] [INFO] [1730491420.222810281] [behavior_server]: Activating backup
[behavior_server-4] [INFO] [1730491420.222838308] [behavior_server]: Activating drive_on_heading
[behavior_server-4] [INFO] [1730491420.222871998] [behavior_server]: Activating assisted_teleop
[behavior_server-4] [INFO] [1730491420.222898948] [behavior_server]: Activating wait
[behavior_server-4] [INFO] [1730491420.222932248] [behavior_server]: Creating bond (behavior_server) to lifecycle manager.
[planner_server-3] [INFO] [1730491420.404478646] [global_costmap.global_costmap]: Message Filter dropping message: frame 'rplidar_link' at time<PHONE_NUMBER>.063 for reason 'the timestamp on the message is earlier than all the data in the transform cache'
[planner_server-3] [INFO] [1730491420.665134867] [global_costmap.global_costmap]: Message Filter dropping message: frame 'rplidar_link' at time<PHONE_NUMBER>.321 for reason 'the timestamp on the message is earlier than all the data in the transform cache'
[planner_server-3] [INFO] [1730491420.883672490] [global_costmap.global_costmap]: Message Filter dropping message: frame 'rplidar_link' at time<PHONE_NUMBER>.578 for reason 'the timestamp on the message is earlier than all the data in the transform cache'
[lifecycle_manager-8] [INFO] [1730491421.345664862] [lifecycle_manager_navigation]: Server behavior_server connected with bond.
[lifecycle_manager-8] [INFO] [1730491421.345938720] [lifecycle_manager_navigation]: Activating bt_navigator
[bt_navigator-5] [INFO] [1730491421.350806691] [bt_navigator]: Activating
[bt_navigator-5] [INFO] [1730491421.597924374] [bt_navigator]: Creating bond (bt_navigator) to lifecycle manager.
[lifecycle_manager-8] [ERROR] [1730491422.521021728] [lifecycle_manager_navigation]: Failed to change state for node: bt_navigator. Exception: transition invoked while in transition.
[lifecycle_manager-8] [ERROR] [1730491422.521119908] [lifecycle_manager_navigation]: Failed to bring up all requested nodes. Aborting bringup.
^C[WARNING] [launch]: user interrupted with ctrl-c (SIGINT)
[velocity_smoother-7] [INFO] [1730491424.770654215] [rclcpp]: signal_handler(signum=2)
[velocity_smoother-7] [INFO] [1730491424.771421494] [velocity_smoother]: Running Nav2 LifecycleNode rcl preshutdown (velocity_smoother)
[lifecycle_manager-8] [INFO] [1730491424.770654233] [rclcpp]: signal_handler(signum=2)
[waypoint_follower-6] [INFO] [1730491424.770803187] [rclcpp]: signal_handler(signum=2)
[planner_server-3] [INFO] [1730491424.771104690] [rclcpp]: signal_handler(signum=2)
`

Hi @RustyCPR @smatarCPR @hilary-luo Do you have updates on your findings? We got a second turtlebot that is setup in a totally independent network and this is still happening.

Hi @xylhal
Could you try to clone my bond_cpp fix into your workspace and build it with your packages to see if it can fix the issue?
If it works, please leave a comment for support at the PR!

https://github.com/ros/bond_core/pull/97

Thanks

@daisukes Sure, I will try it out and get back to you

@daisukes you could try bringing it up on ROS discourse or discord to try and get some attention to your PR.
@xylhal was @daisukes solution able to address the issue? If not I would suggest bringing this forward to the Nav2 team to see if they can provide additional insight.

@hilary-luo I haven't had time to try @daisukes solution yet, I will update if it works or not. In the meantime, did your team find anything?


growl notification

Can you add a growl notification for when the image file has successfully been uploaded and url added to clipboard?

I would also like this functionality.


Fix Redis config file warning

Resolves issue #4 .
Changed

Addition of 'redis-server' path under both 'command' and 'volumes' options under 'redis' (in docker-compose, for which Sail works as a wrapper) is required

NOTE

Also requires addition of a redis.conf file (for Redis v7.0.11)] locally in /usr/local/etc/redis/ directory

Source: https://redis.io/docs/management/config/ > 'The self documented redis.conf for Redis 7.0.')

Successful output of $ ./vendor/bin/sail up:
quiz_app-redis-1         | 1:C 26 Oct 2023 22:26:23.510 # Configuration loaded


I added my nam eto to eddiehub practice

adds my name to the README.md file

closing due to inactivity. feel free to reopen


Fix concurrent.future crash with viztracer

concurrent.future requires a threading atexit function clean up
for python3.9+ if the executor is not explicitly shutdown in the
program, otherwise it will deadlock

Codecov Report

Merging #142 (d1d37a6) into master (f4aa723) will decrease coverage by 2.34%.
The diff coverage is 62.50%.

@@             Coverage Diff             @@
##            master     #142      +/-   ##
===========================================
- Coverage   100.00%   97.65%   -2.35%
===========================================
  Files           22       22
  Lines         2211     2215       +4
===========================================
- Hits          2211     2163      -48
- Misses           0       52      +52

Impacted Files
Coverage Δ

src/viztracer/main.py
97.46% <62.50%> (-2.54%)
:arrow_down:

src/viztracer/patch.py
83.63% <0.00%> (-16.37%)
:arrow_down:

src/viztracer/viztracer.py
94.30% <0.00%> (-5.70%)
:arrow_down:

src/viztracer/report_builder.py
94.44% <0.00%> (-5.56%)
:arrow_down:

src/viztracer/simulator.py
96.74% <0.00%> (-3.26%)
:arrow_down:

src/viztracer/flamegraph.py
97.67% <0.00%> (-2.33%)
:arrow_down:

src/viztracer/code_monkey.py
98.50% <0.00%> (-1.50%)
:arrow_down:

src/viztracer/prog_snapshot.py
98.88% <0.00%> (-1.12%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f4aa723...d1d37a6. Read the comment docs.