Document that local build cache should be discouraged from being shared on CI

It is often asked how to use the local build cache on CI: how it should be shared between builds and in what scenario. If we do not encourage using the local build cache on CI, we should write explicitly in our documentation that this is discouraged.
This may be a good place: https://docs.gradle.org/current/userguide/build_cache_use_cases.html#use_cases_cache
We have similar to best practices for the dependency cache here: https://docs.gradle.org/current/userguide/dependency_resolution.html#sub:ephemeral-ci-cache

I think this would be good to document since it causes confusion.


horusec-cli from within Kubernetes DinD container consistently reports no issues

What happened:
A Kubernetes pod with a simple Docker-in-Docker setup fails to report vulnerabilities from either a docker-based scan or the horusec-cli tool. This happens regardless of the state of the -D flag being set to true or false.
What you expected to happen:
When I run this on a Mac with Docker Desktop installed, the scan reports vulnerabilities.
How to reproduce it (as minimally and precisely as possible):

Create a deployment with a docker and docker-socket container

apiVersion: v1
kind: Pod
metadata:
  labels:
    run: horusec
  name: horusec
spec:
  containers:
  - image: docker:20.10.11
    name: docker
    command:
    - sleep
    args:
    - '99d'
    resources: {}
    volumeMounts:
    - name: varrun
      mountPath: /var/run
  - image: docker:20.10.11-dind
    securityContext:
      privileged: true
    name: docker-daemon
    resources: {}
    volumeMounts:
    - name: varrun
      mountPath: /var/run
  volumes:
  - name: varrun
    emptyDir: {}
  dnsPolicy: ClusterFirst
  restartPolicy: Always

in the docker container, execute a docker scan against some code

docker run --rm -v /var/run/docker.sock:/var/run/docker.sock -v ${PWD}:/workspace horuszup/horusec-cli:v2.6 horusec start '-p=/workspace/' '-P=${PWD}' '-o=sonarqube' '-O=/workspace/horusec.json'
Anything else we need to know?:
Regardless of whether I run a docker-based scan or a scan from the horusec-cli tool (both with and without -D="true") the scan always reports no vulnerabilities found
Environment: Kubernetes (1.18+)

Horusec version (use horusec version): v2.6.7
Operating System: Linux
Network plugin / Tool and version (if this is a network-related / tool bug):
Others:

Hi @ccureau, thank you for the bug report.
We are going to check what happened and return as soon as possible.

I did some fast tests to see what is happening, seems to be a problem with a invalid mount paths inside the dind container.
Using the direct binary with the -D I managed to run without errors and found some vulnerabilities. With this flag all tools that Horusec orchestrate will not run, leading to a analysis less assertive. Here you can check more infomation about the Horusec engine.
Until a fix is released, downloading the binary and running without docker  horusec start -D will work.

giving more context on this problem:

When running on dind container inside a k8s cluster as mentioned above we've got this error:

i believe this must be related to the way we're mounting the volumes on our containers in this line

i tried to change the propagation settings to see if the error continues and unfortunately it continued, so i believe the error is on our mount.Type param but changing this will not be so easy and probably will generate some breaking change or newer flags for cases like this.
What you guys think about? @matheusalcantarazup @nathanmartinszup @wiliansilvazup we should make a new flag and  a new feature to 2.8 milestone to solve this?

so i believe the error is on our mount.Type

Can we certify this before making any progress on this fix?

with more research i realize i was going for something too complicated and it's was easy to fix, i've runned this command
docker run --rm -v /var/run/docker.sock:/var/run/docker.sock -v ${PWD}:/workspace horuszup/horusec-cli:v2.7 horusec start '-p=/workspace/' '-P=/run/test' '-o=sonarqube' '-O=/workspace/horusec.json' --log-level=debug and was able to run the containers and get the vulnerabilities.
The problem was probably you were getting permission denied when calling $PWD in the start command argument and it returned a invalid path.
Steps to reproduce:

install kind tool
kind create cluster --name horusec
create a config file

apiVersion: v1
kind: Pod
metadata:
  labels:
    run: horusec
  name: horusec
spec:
  containers:
    - image: docker:20.10.12
      name: docker
      command:
        - sleep
      args:
        - '99d'
      resources: {}
      volumeMounts:
        - name: varrun
          mountPath: /var/run
    - image: docker:20.10.11-dind
      securityContext:
        privileged: true
      name: docker-daemon
      resources: {}
      volumeMounts:
        - name: varrun
          mountPath: /var/run
  volumes:
    - name: varrun
      emptyDir: {}
  dnsPolicy: ClusterFirst
  restartPolicy: Always

apply it to cluster kubectl apply -f ./config.yaml
exec into docker container exec kubectl exec -i -t -n default horusec -c docker "--" sh -c "clear; (bash || ash || sh)"
once inside a container create directory mkdir /run/test
cd to that dir cd  /run/test
install git on container apk add git
clone examples repository git clone https://github.com/ZupIT/horusec-examples-vulnerabilities
run the command docker run --rm -v /var/run/docker.sock:/var/run/docker.sock -v ${PWD}:/workspace horuszup/horusec-cli:v2.7 horusec start '-p=/workspace/' '-P=/run/test' '-o=sonarqube' '-O=/workspace/horusec.json' --log-level=debug

ps: remember that using this argument below could cause some security problems, so make sure you really know what you doing there
      securityContext:
        privileged: true

@nathanmartinszup @wiliansilvazup @matheusalcantarazup can you guys reproduce it?

it worked for me.

It worked for me too :)

closing since there was no response and two people could reproduce without error


Enter key doesn't submit forms

https://stackoverflow.com/questions/33211672/how-to-submit-a-form-using-enter-key-in-react-js

#417


failed test on green build.

see https://travis-ci.org/botandrose/eboshi_api_shootout/builds/83241536
node_hapi:
Run options: --seed 58673
# Running tests:
F.S
Finished tests in 0.087269s, 34.3763 tests/s, 22.9176 assertions/s.
  1) Failure:
test_0001_returns_a_json_list_of_clients(api::GET /api/clients) [test/test.rb:36]:
--- expected
+++ actual
@@ -1 +1 @@
-{"data"=>[{"type"=>"clients", "id"=>"1", "attributes"=>{"name"=>"Bot and Rose Design", "address"=>"625 NW Everett St", "city"=>"Portland", "state"=>"OR", "zip"=>"97209", "country"=>"USA"<EMAIL_ADDRESS>"contact"=>"Michael Gubitosa", "phone"=>"(503) 662-2712", "created_at"=>"2006-06-25T14:08:31Z", "updated_at"=>"2015-08-29T09:58:23Z"}}]}
+[{"id"=>1, "type"=>"clients", "attributes"=>{"name"=>"Bot and Rose Design", "address"=>"625 NW Everett St", "city"=>"Portland", "state"=>"OR", "zip"=>"97209", "country"=>"USA"<EMAIL_ADDRESS>"contact"=>"Michael Gubitosa", "phone"=>"(503) 662-2712", "created_at"=>"2006-06-25T14:08:31.000Z", "updated_at"=>"2015-08-29T09:58:23.000Z"}}]
3 tests, 2 assertions, 1 failures, 0 errors, 1 skips
registered bookshelf plugins
Hapi server started

Oh snap. Good catch. An untrustworthy test suite is worse than no test
suite at all.
On Thu, Oct 1, 2015, 9:09 PM Adam Horak<EMAIL_ADDRESS>wrote:

see https://travis-ci.org/botandrose/eboshi_api_shootout/builds/83241536
node_hapi:
Run options: --seed 58673
Running tests:
F.S
Finished tests in 0.087269s, 34.3763 tests/s, 22.9176 assertions/s.

Failure:
test_0001_returns_a_json_list_of_clients(api::GET /api/clients) [test/test.rb:36]:
--- expected
+++ actual
@@ -1 +1 @@
-{"data"=>[{"type"=>"clients", "id"=>"1", "attributes"=>{"name"=>"Bot and Rose Design", "address"=>"625 NW Everett St", "city"=>"Portland", "state"=>"OR", "zip"=>"97209", "country"=>"USA"<EMAIL_ADDRESS>"contact"=>"Michael Gubitosa", "phone"=>"(503) 662-2712", "created_at"=>"2006-06-25T14:08:31Z", "updated_at"=>"2015-08-29T09:58:23Z"}}]}
+[{"id"=>1, "type"=>"clients", "attributes"=>{"name"=>"Bot and Rose Design", "address"=>"625 NW Everett St", "city"=>"Portland", "state"=>"OR", "zip"=>"97209", "country"=>"USA"<EMAIL_ADDRESS>"contact"=>"Michael Gubitosa", "phone"=>"(503) 662-2712", "created_at"=>"2006-06-25T14:08:31.000Z", "updated_at"=>"2015-08-29T09:58:23.000Z"}}]
3 tests, 2 assertions, 1 failures, 0 errors, 1 skips
registered bookshelf plugins
Hapi server started

—
Reply to this email directly or view it on GitHub
https://github.com/botandrose/eboshi_api_shootout/issues/33.


bugfix/OK 52 fix random lists sorting

Jira Link:
[Jira: ](https://champlainsaintlambert.atlassian.net/jira/software/projects/OK/boards/55?selectedIssue=OK-52)
Context
Lists randomly switch order which can be confusing for users
Changes
added sorting to lists before being displayed

LGTM
Is there a specific logic behind this sort or does it just consistently order things and that's good enough?

Good question, it just sorts alphabetically based on the name of the list. In the array, the first item (item .at(0)) represents the name of the list.


feat(volo): improve TLS support

Motivation
TLS support in crates used to be confusing, for example, client-side TLS support was in volo, while server-side TLS support was in volo-grpc, and there is no convenient way to configure it.  In example of gRPC with TLS, rustls configuration is wrote manually and there is no example with native-tls.
Solution
This PR moves all TLS related codes to volo, and many convenient methods are added, e.g., TlsAcceptor::from_pem_file and TlsConnector::builder with TlsConnectorBuilder::add_pem_from_file.
However, for more complex usage, users still have to configure it themselves.
Additionally, in most cases users do not need to care whether they are using rustls or native-tls, they can simply select a feature to use it.


questions about transformation of tensor shape in Conv2d

Hello,I have built a Conv2d instance with num_filters=6 and kernei_size=(3,3),and the input of the conv2d layer is a tensor of [1,12,12,6] with complexed value. Shape=(batch_size, h, w, channels).
Then I found that the output of this layer is of [1,10,10,12] with real value.While the expected tensor should be [1,10,10,6] with complexed value.
Does the [1,10,10,12] tensor stand for the real part and imagenary part of output tensor?If so, we can concate the [1,10,10,:6] and [1,10,10,6:] to get the final expected tensor, right?
Thank you for reading,look forward to your reply.

Then I split the [1,12,12,6] complexed-value tensor into [1,12,12,12] real-valued tensor,and take it as imput,using the same conv2d layer mentioned above.Finally I got a [1,10,10,12] tensor with real value.
Does the [1,10,10,12] tensor stand for the real part and imagenary part of output tensor?If so, we can concate the [1,10,10,:6] and [1,10,10,6:] to get the final expected tensor, right?


I want to add weather app project.

A weather app project using API for fetch weather details and show in HTML page.
Please assign me this issue,So I can work on this.
Thank You.

Sure @pabitra0011  All the best

Hey ! I would like to work and contribute to it. Please assign it to me


Amazon S3 Bucket (Independent Publisher) - Bugfix

The connector now supports filenames with characters such as spaces (folder 1/my file.csv).
The connector now supports binary content such as PDF files.

Known Limitations:

Large files might run into timeout issues. (Microsoft FAQ: Script must be finished within 5 seconds)

When submitting a connector, please make sure that you follow the requirements below, otherwise your PR might be rejected. We want to make you have a well-built connector, a smooth certification experience, and your users are happy :)
If this is your first time submitting to GitHub and you need some help, please sign up for this session.

[ ] I attest that the connector doesn't exist on the Power Platform today. I've verified by checking the pull requests in GitHub and by searching for the connector on the platform or in the documentation.
[x ] I attest that the connector works and I verified by deploying and testing all the operations.
[x] I attest that I have added detailed descriptions for all operations and parameters in the swagger file.
[x] I attest that I have added response schemas to my actions, unless the response schema is dynamic.
[x] I validated the swagger file, apiDefinition.swagger.json, by running paconn validate command.
[x] If this is a certified connector, I confirm that apiProperties.json has a valid brand color and doesn't use an invalid brand color, #007ee5 or #ffffff. If this is an independent publisher connector, I confirm that I am not submitting a connector icon.

If you are an Independent Publisher, you must also attest to the following to ensure a smooth publishing process:

[x] I have named this PR after the pattern of "Connector Name (Independent Publisher)" ex: HubSpot Marketing (Independent Publisher)
[x] Within this PR markdown file, I have pasted screenshots that show: 3 unique operations (actions/triggers) working within a Flow. This can be in one flow or part of multiple flows. For each one of those flows, I have pasted in screenshots of the Flow succeeding.
[x] Within this PR markdown file, I have pasted in a screenshot from the Test operations section within the Custom Connector UI.
[x] If the connector uses OAuth, I have provided detailed steps on how to create an app in the readme.md.

Tests:
Fix for long filenames with spaces such as folder with space/my file.csv:

Fix for binary content:

[[certify-connector]]

Hello Partner,
I hope you are doing well.
Congratulations, the deployment of your connector and documentation page was already completed, We have a short survey on the connector certification process that we would like for you to complete. Your feedback is appreciated and will help us improve the program.
Thank you very much for working with us.


View - implement chart1.py

please implement the Altair.chart object for chart 1

see pull request #33


[Improvement][Resource Center] Display brief file name in file-details page

Search before asking

[X] I had searched in the issues and found no similar issues.

What happened
hadoop集群与dolphin是分开部署的，不知道这个需要怎么配置，才能显示不是全路径的，只显示文件名称

What you expected to happen
hadoop集群与dolphin是分开部署的，不知道这个需要怎么配置，才能显示不是全路径的，只显示文件名称
How to reproduce
hadoop集群与dolphin是分开部署的，不知道这个需要怎么配置，才能显示不是全路径的，只显示文件名称
Anything else
No response
Version
3.2.x
Are you willing to submit PR?

[X] Yes I am willing to submit a PR!

Code of Conduct

[X] I agree to follow this project's Code of Conduct

Hi @zhangjiwei , you can make some modification on UI part.

If no one is working on this, i'd like to submit a PR

If no one is working on this, i'd like to submit a PR

Okay, assign to you :D


Running forever as systemctl service

This is almost certainly user error, but perhaps someone can be of assistance.
I can run npm start to start my app via a bash script via a systemctl service that points to the script. I can also run forever via the bash script. However if I run forever via a systemctl that points to a bash script, nothing happens. Here is the scripts, to be clear I can ./onstart, but doing a systemctl startup.service does not error, nor does my app start nor does forever list list any processes:
onstart
#!/bin/bash
forever start /home/user/app/myapp/app.js --port 1337
startup.service
[Unit]
Description=Startup Applications
[Service]
Type=oneshot
RemainAfterExit=false
ExecStart=/home/user/app/onstart
[Install]
WantedBy=multi-user.target

have you solved this problem?
now I start my service with same way, and has same problem


Support custom buttons in modal-footer?

Would it be possible to add support for custom buttons in the <modal-footer> element? As of now you only support <button> and <au-button> which doesn't allow custom elements.
In my case I use a custom element <ladda> which gives the submit button a spinner when you click it.

@Andreas-Hjortland Yes this is fine we can certainly switch to a more open content selector, PR accepted.

please merge my pull request to resolve this issue: https://github.com/PWKad/aurelia-bs-modal/pull/33


sourcemaps aren't working with kernel/ddk externally (maybe internally too)

Need to investigate whether this is an issue with package:build, package:test, package:front_end, or package:dev_compiler.
I added the dev_compiler area for now just because there isn't a better option until we know more.

It looks like this isn't working because the Dart uris we get back have the org-dartlang-app:// scheme - which makes sense on the kernel side of things given that is the uri we use to load the dart files.
We will have to figure out if we want to strip that out before writing the sourcemaps or handle it some other way.

I was able to clean this up in the source maps after the fact (within build_web_compilers), which while a bit gross does at least put the code in the place that has the knowledge of what needs to actually be done.

I believe @sigmundch designed the "org-dartlang-app://" scheme but I'm not sure the intent w.r.t. source maps.
You can pass --multi-root-scheme to configure it to something else, would that work? Or do you need the source maps to exactly match DDC+Analyzer? I seem to recall trying to make DDK match DDC, but I don't recall why that change didn't land.

Yeah, the special scheme has a bad interaction with source-maps.
We use it to hide machine-specific location information (tmp folders, etc) that especially interfere in distributed build systems like bazel. The main thing that makes it works for the CFE is that we use a custom URI scheme. For that reason, the URIs are incompabtible with browser's sourcemaps out of the box (since browsers will not understand any custom scheme).
Our solution internally to support source-maps in dart2js is that we post-process the .source-map file and replace the scheme with a relative path that the development server understands. We could alternative have a flag to do that when invoking the compiler itself, but we found it simpler and more compositional to do it as a separate step.
Would that be feasible to do for DDK in webdev serve?
We haven't look into it, but someone recommended we look into generating source-maps with root-relative paths and provide a sourceRoot in the source-map header instead. It is equivalent to what we already do, but it would keep minimal the updates we need to make to the sourcemap files.

We haven't look into it, but someone recommended we look into generating source-maps with root-relative paths and provide a sourceRoot in the source-map header instead. It is equivalent to what we already do, but it would keep minimal the updates we need to make to the sourcemap files.

Oooh, +1 that sounds very useful.

@jakemac53 @jmesserly - is the plan to handle in webdev / pbr or in ddk?

I think Siggi's theory is correct: ideally this should be handled by the server, because it knows where the files will be served from, and the compiler doesn't. We can make that transform easier by using the sourceRoot feature of source maps.
That's a longer term plan. Short term, if you need DDK to attempt to match DDC semantics, I can try to implement it. I'm not sure if we have all of the relevant information, but maybe we do.

@jakemac53 is post-processing in build.  Dropping this from 2.3.

One thing to note is this might make a sourceRoot change harder to land in the future - we will probably need to guard it behind a flag. That does sound like a better approach but manually editing all the sources works for now.


Feature added: reuse-query

Anytime the player queries or receives a card, it gets cached in their user doc in the database as lastQueriedCard, and can be referenced by the user with a "."
Ex: ->summon . summons lastQueriedCard

Example use: referencing a claimed card
->claim
->eval .
->auc sell .
Example use: viewing and rating unrated cards
->sum !rated
->rate 8 .
Example: referencing a forged card
->forge [card1],[card2]
->fav .
->rate 10 .
->info .


EDISON Error: Illegal arguments for construction of _exports_Gpio

Running Intel Eddison using MRAA for interrupt. Code was working fine till today. It gives
Error: Illegal arguments for construction of _exports_Gpio
MRAA Version: v1.1.1 also did a NPM install for the latest version but still getting same error
21.01.17 14:35:12 [-0500] /usr/src/app/main.js:100
21.01.17 14:35:12 [-0500] InterruptPin2 = new mraa.Gpio(32) // mraa8 -gp28
21.01.17 14:35:12 [-0500] ^
21.01.17 14:35:12 [-0500]
21.01.17 14:35:12 [-0500] Error: Illegal arguments for construction of _exports_Gpio
21.01.17 14:35:12 [-0500] at Error (native)
21.01.17 14:35:12 [-0500] at Object. (/usr/src/app/main.js:100:17)
21.01.17 14:35:12 [-0500] at Module._compile (module.js:570:32)
21.01.17 14:35:12 [-0500] at Object.Module._extensions..js (module.js:579:10)
21.01.17 14:35:12 [-0500] at Module.load (module.js:487:32)
21.01.17 14:35:12 [-0500] at tryModuleLoad (module.js:446:12)
21.01.17 14:35:12 [-0500] at Function.Module._load (module.js:438:3)
21.01.17 14:35:12 [-0500] at Module.runMain (module.js:604:10)
21.01.17 14:35:12 [-0500] at run (bootstrap_node.js:394:7)
21.01.17 14:35:12 [-0500] at startup (bootstrap_node.js:149:9)

If the code was working - what has changed "today" in your environment? OS, Node, whatvere else updates/reconfigs?

@Niko-La, is this still actual?

Closing for no response, feel free to post here if this is still actual.


Consolidate visualReducer and templateReducer Assets into store

These have been spread over types, config and store, and should be better located. This will include moving the store API back into the store folder and the cleanup of other assets, such as the template API, and schemas.

Resolved in build 118.


[SPARK-7031][ThriftServer]let thrift server take SPARK_DAEMON_MEMORY and SPARK_DAEMON_JAVA_OPTS

We should let Thrift Server take these two parameters as it is a daemon. And it is better to read driver-related configs as an app submited by spark-submit.
https://issues.apache.org/jira/browse/SPARK-7031

Test build #30664 has started for   PR 5609 at commit 4fb25ed.

Test build #30664 has finished for   PR 5609 at commit 4fb25ed.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.
This patch does not change any dependencies.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/30664/
Test FAILed.

Test build #30674 has started for   PR 5609 at commit 0565831.

Test build #30674 has finished for   PR 5609 at commit 0565831.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.
This patch does not change any dependencies.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/30674/
Test FAILed.

Test build #30823 has started for   PR 5609 at commit 624e652.

Test build #30823 has finished for   PR 5609 at commit 624e652.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.
This patch does not change any dependencies.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/30823/
Test PASSed.

BTW I have tested on my cluster with setting

export SPARK_DAEMON_MEMORY=1111m
export SPARK_DAEMON_JAVA_OPTS=" -Dx=y "

in spark-env.sh.
Before this patch the jinfo shows:

VM Flags:
-Xms512m -Xmx512m -XX:MaxPermSize=128m
After:

VM Flags:
-Dx=y -Xms1111m -Xmx1111m -XX:MaxPermSize=128m

Jenkins, retest this please.

Jenkins, test this please.

Jenkins, test this please.

Test build #728 has started for   PR 5609 at commit d3ddfb6.

Test build #728 has finished for   PR 5609 at commit d3ddfb6.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.
This patch does not change any dependencies.

@vanzin So though it is not a best idea but ok to go?

Just a small nit, but otherwise looks good.

Merged build triggered.

Merged build started.

Merged build triggered.

Merged build started.

Test build #31373 has started for   PR 5609 at commit 8d3fc16.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/31371/
Test FAILed.

Jenkins, retest this please.

Merged build triggered.

Merged build started.

Test build #31378 has started for   PR 5609 at commit 8d3fc16.

Test build #31373 has finished for   PR 5609 at commit 8d3fc16.

This patch fails SparkR unit tests.
This patch merges cleanly.
This patch adds no public classes.
This patch does not change any dependencies.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/31373/
Test FAILed.

Jenkins, retest this please.

Merged build triggered.

Merged build started.

Test build #31384 has started for   PR 5609 at commit 8d3fc16.

Test build #31378 has finished for   PR 5609 at commit 8d3fc16.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.
This patch does not change any dependencies.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/31378/
Test FAILed.

Looks like the failed test case is flacky. Jenkins, retest this please.

Merged build triggered.

Merged build started.

Test build #31389 has started for   PR 5609 at commit 8d3fc16.

Test build #31384 has finished for   PR 5609 at commit 8d3fc16.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.
This patch does not change any dependencies.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/31384/
Test FAILed.

Merged build finished. Test FAILed.

Another different case failed. Jenkins, retest this please.

Merged build triggered.

Merged build started.

Test build #31398 has started for   PR 5609 at commit 8d3fc16.

Test build #31389 has finished for   PR 5609 at commit 8d3fc16.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.
This patch does not change any dependencies.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/31389/
Test PASSed.

Merged build finished. Test PASSed.

Test build #31398 has finished for   PR 5609 at commit 8d3fc16.

This patch passes all tests.

This patch merges cleanly.

This patch adds no public classes.

This patch adds the following new dependencies:

jaxb-api-2.2.7.jar
jaxb-core-2.2.7.jar
jaxb-impl-2.2.7.jar
pmml-agent-1.1.15.jar
pmml-model-1.1.15.jar
pmml-schema-1.1.15.jar

This patch removes the following dependencies:

activation-1.1.jar
jaxb-api-2.2.2.jar
jaxb-impl-2.2.3-1.jar

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/31398/
Test PASSed.


Server hangs randomly

This module seems to make the server freeze randomly. There are no errors or anything, server suddenly just stops responding and uses 0% CPU. I've created a test plugin to make sure it's cause by this module. With only this plugin running, the server freezes eventually every single time, usually within 10 minutes.
Test plugin: https://pastebin.com/T4JnRAKD
I also tried it without the JSON part, with cURL being the only module running, and it had the same results.

I managed to compile the module myself using the latest libcurl (7.61.1), but that didn't fix the issue.

fixed in 9d1edc291667e50a96b6cea59e0b03911144c371


cluster processing: passing the parameter dictionary to each job directly

Hi!
I enjoy using psweep for local sweeps and started looking into the experimental remote cluster processing bits, since I would like to expand my sweeps onto our HPC. I have some questions on how to use the current implementation:
In your example you have a template run.py, which is pretty much what is executed on each machine. You eventually use the substitute method from the string module to replace placeholders for each parameter. I makes perfect sense, but it is a little less convenient than what was possible with the run_local() function, where the worker function is directly given and the parameter dictionary is directly passed to that function. I was hoping to have a similar mechanism available, i.e., where I just get a dictionary and can have my 'template' run.py just deal with a dictionary. This allows to have an actually executable template run.py and I do not have to modify it for each sweep (e.g., when adding a sweep parameter).
The question I have is how to pass such a dictionary to a new script. Do you have a good idea? A straightforward answer could be by pickling it and simply loading the dictionary. Since we want to add the parameters to a pickable database, all entries must be pickable anyway. The difficulty I have now, is that prepare_batch() does the replacement and I cannot access the pset to create the pickled dict myself. Looking at your suggested workflow here, it seems that there used to be a hook for a func(), which I could have used, but it there is none in prepare_batch(). Perhaps I misunderstand something, but could it be that the documentation on the workflow is not quite up to date?

Thanks for your interest in the project.
Your question is spot-on and describes accurately the template workflow's limitations.
Yes, using dask (#9) will avoid all that and you just need to replace
ps.run(func, params)

by
from dask.distributed import Client

# Or SGECluster or ...
from dask_jobqueue import SLURMCluster

cluster = SLURMCluster(
    ... HPC settings here ...
)
client = Client(cluster)

ps.run(func, params, dask_client=client)

I have now pushed a branch develop, with ATM is the same as feature-dask. This won't see any force-push :) and you can experiment with the new dask support. Note that in main and newer branches, so develop and feature-dask, run_local() was renamed to run(), but we have backwards compatibility and you'll see a deprecation warning.
You need to install psweep manually as described here, e.g.
python -m venv psweep
. ./psweep/bin/activate
git clone ...
cd /path/to/psweep
git checkout develop
pip install -e ".[dask]"

I have extended the docs in that regard, adding a detailed comparison of dask vs templates and when to use which method. GitHub renders the markdown quite well but is missing things like included example files. There are new examples here. The improved docs also explain a pickle-based workflow using templates as you describe (since I did that in the past but haven't documented it).
If you want to render the docs locally (which needs a lot of stuff installed), do, in the same venv as above probably:
cd /path/to/psweep/doc
pip install -e ".[doc]"
sh generate-doc.sh

That's what we do in the gh pages CI as well.
If you use the dask support, feel free to report back any problems that you faced. Thanks a lot.

Thank you for this very detailed report, that's highly appreciated!
Some comments on your findings.
Environment
We don't have any HPC-related install docs yet. Would something like this have helped?
"Jobs on HPC systems usually inherit the environment from which they were started. For instance, you can have a venv in your $HOME with psweep and dask installed. This will end up in $HOME/.virtualenvs/psweep which is venv's default. Then submit from this environment, which will propagate all environment variables to batch jobs. $HOME on most if not all HPC machines is on a shared file system mounted at each node, which makes things work.

Robustness of dask_jobqueue and psweep's relation to workflow engines
HPC machines are a complex piece of tech, so I think that dask_jobqueue is a great help. It covers probably about 80% of the common situations, but it can't handle each setup for sure (+- a few bugs maybe).
Outside of the dask ecosystem and psweep's scope, there are many projects which deal with failed jobs on HPC and other infrastructure. There is a non-comprehensive list in the psweep docs which lists tools for parameter sweeps, experiment tracking and workflow orchestration, all of which relate in some way. Some tools fall into multiple categories, so the boundaries a blurry here. Workflow engines usually offer resilience measures against failing workers. I can't give recommendations since I haven't used them yet, but nevertheless here are docs related to failed jobs for aiida and fireworks. Both tools are built by the materials modeling community, which makes heavy use of HPC resources.
Those tools are super powerful, but also more complex to set up and use (so no free lunch here). Many require you to set up a database server (PostgreSQL, MongoDB) where they can store results and metadata. They can also manage complex workflows such as jobs that depend on each other as a DAG and much more.
In psweep we assume the simplest case, workloads are independent (embarrassingly parallel). Thus we just expose the dask_client arg to leverage dask's concurrent.futures API. psweep provides simple helpers to set up the params (plist, pgrid, stargrid) and gives you a DataFrame with useful metadata such as pset hashes and UUIDs for psets and runs.
One way to solve task dependencies with psweep is by running things in order manually, say 10prepare.py, 20production.py, 30eval.py, where the first two can use psweep to compute stuff, update the database and store intermediate data on disk, which the next script would pick up. The "workflow" is to run all scripts in order. This is super low tech, simple, but also a bit brittle. For more challenging dependencies and more reproducibility, I'd look into using one of the tools above.
In the context of psweep these tools may become interesting if one can use their job scheduling features (so what dask.distributed + dask_jobqueue do) without the need to buy into their DSLs or database setups.
Code changes to support specific use cases (chunking)
You are right, I probably wouldn't want to add features that solve a narrow use case which I haven't been facing and testing in production myself. However, if you have a well tested feature that doesn't break current functionality and comes with tests, please feel free to send a PR.
psweep notes

ps.run(..., tmpsave=True) will save results from each pset on disk to <calc_dir>/tmpsave/<run_id>/<pset_id>.pk. This won't be used by dask workers. This feature assumes that you collect those results manually into a DataFrame later by a post-processing script. The idea for this was that if some workers fail, we have at least some results saved. Also for long running workloads, one can start to analyze already finished results. But as mentioned, that requires a bit of scripting. Also I haven't used it all that much in production. See also this comment.
If you have only one plist, you can skip the pgrid call.

Dear @wilkeber, if you have more findings to add here, please don't hesitate to do so. The basic dask support is now in release 0.11.1 in the form discussed above, ps.run(..., dask_client=client). If you run into any issues with this, please open a new issue. I'm taking the liberty to close this one since I think the original question is answered. Again, thank you for your question and detailed report!

Even if the issue is closed, I'll add one more comment, because I believe it might be useful for people using psweep with dask, when they are actually developing their own applications.

No worries, these notes are very much welcome. I may integrate some of your tips in the docs at some point. For now, I have linked from the docs to this issue at least.

As you pointed out, jobs in HPC cluster usually inherit the environment. However, when starting a sweep from some local repository, in which you are currently developing and quickly changing things, I found it useful to know of the UploadDirectory plugin. It allows you to copy your files onto the workers environment, see https://distributed.dask.org/en/stable/plugins.html#built-in-nanny-plugins

Interesting, thanks for sharing. I was not aware of this. If by repository you mean a git repo, then my way of dealing with this, if the code in the repo is a Python project, is

set up a venv, maybe with access to system libs, so python -m venv --system-site-packages ... (actually I use virtualenvwrapper)
cd /path/to/dev-repo; pip install -e . the dev-repo into that venv, which just says to import code from /path/to/dev-repo and not some install location
submit dask_control.slurm from within that venv

This makes sure (at least on our machine, using SLURM) that each worker has access to the current state in dev-repo. For non-python stuff, a shared file system should grant access to modified files, so I wonder which use case you cover by uploading, where I guess files end up in each worker's tmp dir (e.g. something like dask_tmp/dask-scratch-space/worker-f5qjbu83/ if SLURMCluster(..., local_directory="dask_tmp"))?


Auto color friends/foes/moderators in different colors

Possibly as part of the color format settings, introduce automatic colorization (using some default colors, or, should the user want to, custom picked colors) that would apply to friends, moderators, clanmates and foes.
For example, in the old client:
Normal message: Slightly grey
Moderator message: White
Friend message: Light blue
Clanmate (that is not a friend) message: Light green
Foe message: Red
Those could be the default colors, and then the user can choose what color applies to what type of message as well.
Currently, there is indeed an ability to assign a custom color to each person, but that is very rarely used. I feel this would be a much more useful as it requires less input from the user. (no need to manually assign a different color to each moderator, friend, clanmate, etc.)

probably a duplicate

Fixed in #2028


WASM: The inner handler has not been assigned - Configure AuthorizationMessageHandler

When trying to use the code in the section #configure-authorizationmessagehandler, I receive the erorr:

Microsoft.AspNetCore.Components.WebAssembly.Rendering.WebAssemblyRenderer[100]
Unhandled exception rendering component: The inner handler has not been assigned.

In a vanilla Blazor WASM app (from the template) have the following in Program.cs:
	builder.Services.AddTransient(sp =>
			{
				return new HttpClient(sp.GetRequiredService<AuthorizationMessageHandler>()
						.ConfigureHandler(
								authorizedUrls: new[] { $"https://api.mysite.com" },
								scopes: new[] { "scope1", "scope2" }))

				{
					BaseAddress = new Uri($"https://api.mysite.com")
				};
			});

I then call Http.GetFromJsonAsync and the above error occurs.
If I configure a named client (i.e. use AddHttpClient rather than AddTransient) otherwise identically, I don't get the error.
Is there something missing in the docs, or is it something I'm doing wrong?

Document details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: f2cdb52c-843f-5944-429d-11ea821c1e22
Version Independent ID: 9c4f99ef-f070-b527-4efc-96a04798d9ef
Content: ASP.NET Core Blazor WebAssembly additional security scenarios
Content Source: aspnetcore/security/blazor/webassembly/additional-scenarios.md
Product: aspnet-core
Technology: aspnetcore-security
GitHub Login: @guardrex
Microsoft Alias: riande

Hello @paulguz ... Open that for engineering at ...
https://github.com/dotnet/aspnetcore/issues
... add a cc: @guardrex to your opening comment.
We can leave this open here while Javier responds to your engineering issue.

@paulguz You changed builder.HostEnvironment.BaseAddress to a string URI. Are they the same value?

No, this is a standalone WASM app that is communicating with an existing API elsewhere.

Why is the base address the address of the API? Did you try ...
BaseAddress = new Uri(builder.HostEnvironment.BaseAddress)

... and it also failed the same way?

@guardex Yes, it also fails when I tried that.  It works if I set it up as a named client.

Why is the base address the address of the API?
The Base Address of the Http Client should be the address of the api, shouldn't it? It is "the base adress ... of the internet resource used when sending requests".

Oh, sorry ... yes. I forgot it's the host env base address in the example because this is a hosted Blazor solution that the example is showing. It just threw me off. MORE ☕☕☕☕☕ PLZ! :smile:
It's unrelated to your issue, but I don't think I care for that example ... the URL of https://www.example.com/base and BaseAddress that would be https://www.example.com/base. Seems like we could explain that out a bit more or present a clearer example.

That code snippet is wrong. Likely because you are not using HttpClientFactory. In that case you need to create an HttpClientHandler instance and assign it as the innerhandler of the AuthorizationMessageHandler manually.

Strange. I'll research how the bad code came in and get it fixed immediately.

It came in from the Preview 5 blog post at https://devblogs.microsoft.com/aspnet/blazor-webassembly-3-2-0-preview-5-release-now-available/. It's the example code provided at the end of the Attach tokens to outgoing requests section, except that we changed the registration from AddSingleton to AddTransient later.
It might have gone stale at some point. It wasn't caught on dotnet/AspNetCore.Docs#18616 when I made a minor change to it while adding the Custom AuthorizationMessageHandler class coverage.

Closing as fixed.


Sampling profiler - adding configuration to select target directory for profiling files

Is your feature request related to a problem?

Our sampling profiler creates both JFR and activation-events files as part of its execution process.
By default, these files are created in the default tmp file directory, but there may be cases where this may cause issues.
In one known case, a java.nio.file.FileSystemException was encountered when using the sampling profiler on a system that uses Azure file share. This may be related to I/O rate limiting when using such systems with the sampling profiler (which can be I/O intensive), or some other unknown issue like improper support for writing to such file shares through direct byte buffers.
Describe the solution you'd like

Adding a config option to select alternative directory for the Sampling Profiler files.
Describe alternatives you've considered

Catch errors and try alternative directories, e.g. a subdirectory in the agent installation directory.

Should we have a general setting that controls where all the temporary files are being written to (not specific to only the async profiler) ? It might help for the rare cases where a read-only filesystem is being used (or has limitations like we previously experienced with executables in /tmp).

Sure, we can use a general config option. Which other files did you have in mind?

Here are the files that we currently create (references to java.io.tmpdir property) :

async-profiler data (what this issue is about)
async-profiler binary path (already covered by profiling_inferred_spans_lib_directory)
properties files created for runtime attach
temporary agent binary created for runtime attach
agent log shipping in JSON format


fix: update dayjs call

add ".default" to avoid error "dayjs is not a function".

Summary
What kind of change does this PR introduce? (check at least one)

[x] Bugfix
[ ] Feature
[ ] Code style update
[ ] Refactor
[ ] Docs
[ ] Build-related changes
[ ] Other, please describe:

If changing the UI of default theme, please provide the before/after screenshot:
Does this PR introduce a breaking change? (check one)

[ ] Yes
[x] No

If yes, please describe the impact and migration path for existing applications:
The PR fulfills these requirements:

[ ] When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)

You have tested in the following browsers: (Providing a detailed version will be better.)

[x] Chrome
[ ] Firefox
[ ] Safari
[ ] Edge
[ ] IE

If adding a new feature, the PR's description includes:

[ ] A convincing reason for adding this feature
[ ] Related documents have been updated
[ ] Related tests have been updated

To avoid wasting your time, it's best to open a feature request issue first and wait for approval before working on it.
Other information:

Hey @adajoy, thanks for fixing this! Just stumbled upon this and began wasting time on it ;-)

Hey @adajoy, thanks for fixing this! Just stumbled upon this and began wasting time on it ;-)

Thanks for your PR.
I found it's an issue from dayjs and webpack.
webpack/webpack#4742 iamkun/dayjs#480 iamkun/dayjs#492

Thanks for your PR.
I found it's an issue from dayjs and webpack.
webpack/webpack#4742 iamkun/dayjs#480 iamkun/dayjs#492

Close by #94

Close by #94


IDC Dev tool for posting data elsewhere

Create a dev (console only) function which will upload the current study to a different server.
The function should be exposed to window.OHIF.devUtils if using this debug extension.

The extension should take config which contains the server + authorization to post to.

Would be good to add/unify the upload with the features exposed here:
https://github.com/pieper/Viewers/blob/master/platform/viewer/src/App.js#L74
Would be fine to change the name from window.app to window.ohif to avoid possible namespace clash.  Also please add some documentation on a wiki or somewhere with example commands for downloading data and uploading to a new dicom store.  The overall goal is to have these utilities to facilitate debugging and data management.

As discussed with @fedorov this will be helpful for debugging public data with OHIF devs who don't have access to IDC dicom stores.

P.S. I vote to renam the dicom-p10-downloader extension to the debug extension, as that's what its molding into, and it makes it clearer for other consumers that might want to disable (easy) downloading/pushing of the data.


Minor bugs

/assign @JimBugwadia

/check-cla

/ok-to-test

/lgtm
/approve

@JimBugwadia i think i have messed up the ssh configurations of my local.

/check-cla


Please Add

[FastMM4-AVX](https://github.com/maximmasiutin/FastMM4-AVX). `[Delphi]` `[FPC]` FastMM4 fork with AVX support and multi-threaded enhancements (faster locking)

Very impressive! Added, thanks


Changed to use native EF Core 2.0 mapping configuration

Hi Eduardo,
The Entity Framework Core 2.0 implements a native configuration of entity mappings. I made the change and eliminated the unnecessary use of a custom implementation.

Code Review +1

Code Review Done!
Thanks for your collaboration!


Farming time tracker show when partially ready

Can the farming time trackers change to maybe show a yellow "Ready" when some of the patches in that section are finished? For example the tree tab, if you hardwood trees are ready but my normal trees aren't, instead of showing "Ready Sunday at 9:05", it tells you that some of the patches are ready

+1 to this idea. Would love to see it implemented


hf_hub_download always writes to disk when revision is not a complete commit hash

Due to the behavior of _cache_commit_hash_for_specific_revision (https://github.com/huggingface/huggingface_hub/blob/99ac57b5f8e7cf9ed6a4cfe840e3cd246d4f997a/src/huggingface_hub/file_download.py#L842), if the revision is not a complete commit hash, hf_hub_download will always write the commit hash to the refs folder, even if the file already exists.
This can be problematic if the user loading the pretrained model does not have write access to the transformers cache directory.
I suggest first checking if the refs file containing the commit hash exists and has the same commit hash, before trying to write it.
To reproduce

Download a pretrained model

import transformers
model = transformers.DistilBertModel.from_pretrained("distilbert-base-uncased")

Change the HF_HOME directory permissions to remove write permission
Try to load the same model

import transformers
model = transformers.DistilBertModel.from_pretrained("distilbert-base-uncased")

-> Should break with a permission error

@mhham Thanks for reporting. I made a PR (https://github.com/huggingface/huggingface_hub/pull/1219) to fix this.
Another (immediate) solution is to set HF_HUB_OFFLINE environment variable to true. The user that has read-only access to the cache will not try to fetch latest version from the Hub (and therefore not trigger PermissionError).

Thanks for the quick fix @Wauplin , and the workaround !


ament_cmake: 1.5.3-6 in 'rolling/distribution.yaml' [bloom]

Increasing version of package(s) in repository ament_cmake to 1.5.3-6:

upstream repository: https://github.com/ament/ament_cmake.git
release repository: https://github.com/ros2-gbp/ament_cmake-release.git
distro file: rolling/distribution.yaml
bloom version: 0.11.2
previous version for package: 1.5.3-5

ament_cmake
* [rolling] Update maintainers - 2022-11-07 (#411 <https://github.com/ament/ament_cmake/issues/411>)
  * Update maintainers to Michael Jeronimo
* Contributors: Audrow Nash

ament_cmake_auto
* Fix ament_auto_add_gtest's parameter passing (#421 <https://github.com/ament/ament_cmake/issues/421>)
* [rolling] Update maintainers - 2022-11-07 (#411 <https://github.com/ament/ament_cmake/issues/411>)
  * Update maintainers to Michael Jeronimo
* Contributors: Audrow Nash, Christopher Wecht

ament_cmake_core
* Use file(GENERATE OUTPUT) to create dsv files (#416 <https://github.com/ament/ament_cmake/issues/416>)
  Using file(WRITE) and file(APPEND) causes the modification stamp of the
  file to be changed each time CMake configures, resluting in an
  'Installing' message rather than an 'Up-to-date' message even though the
  file content is identical.
  Using file(GENERATE OUTPUT) updates the timestamp of the file only if
  the content changes.
* Warn when trying to symlink install an INTERFACE_LIBRARY (#417 <https://github.com/ament/ament_cmake/issues/417>)
* Workaround to exclude Clion's cmake folders from colcon test (#410 <https://github.com/ament/ament_cmake/issues/410>)
  - Add AMENT_IGNORE to CMAKE_BINARY_DIR to avoid picking up cmake
  specific folders created by CLion in colcon build and colcon test
  commands
* if (NOT ${UNDEFINED_VAR}) gets evaluated to false, so change to if (NOT UNDEFINED_VAR) so it evaluates to true. (#407 <https://github.com/ament/ament_cmake/issues/407>)
* [rolling] Update maintainers - 2022-11-07 (#411 <https://github.com/ament/ament_cmake/issues/411>)
  * Update maintainers to Michael Jeronimo
* Contributors: Audrow Nash, Kenji Brameld, Michael Orlov, Scott K Logan, Shane Loretz

ament_cmake_export_definitions
* [rolling] Update maintainers - 2022-11-07 (#411 <https://github.com/ament/ament_cmake/issues/411>)
  * Update maintainers to Michael Jeronimo
* Contributors: Audrow Nash

ament_cmake_export_dependencies
* [rolling] Update maintainers - 2022-11-07 (#411 <https://github.com/ament/ament_cmake/issues/411>)
  * Update maintainers to Michael Jeronimo
* Contributors: Audrow Nash

ament_cmake_export_include_directories
* [rolling] Update maintainers - 2022-11-07 (#411 <https://github.com/ament/ament_cmake/issues/411>)
  * Update maintainers to Michael Jeronimo
* Contributors: Audrow Nash

ament_cmake_export_interfaces
* [rolling] Update maintainers - 2022-11-07 (#411 <https://github.com/ament/ament_cmake/issues/411>)
  * Update maintainers to Michael Jeronimo
* Contributors: Audrow Nash

ament_cmake_export_libraries
* [rolling] Update maintainers - 2022-11-07 (#411 <https://github.com/ament/ament_cmake/issues/411>)
  * Update maintainers to Michael Jeronimo
* Contributors: Audrow Nash

ament_cmake_export_link_flags
* [rolling] Update maintainers - 2022-11-07 (#411 <https://github.com/ament/ament_cmake/issues/411>)
  * Update maintainers to Michael Jeronimo
* Contributors: Audrow Nash

ament_cmake_export_targets
* [rolling] Update maintainers - 2022-11-07 (#411 <https://github.com/ament/ament_cmake/issues/411>)
  * Update maintainers to Michael Jeronimo
* Contributors: Audrow Nash

ament_cmake_gen_version_h
* [rolling] Update maintainers - 2022-11-07 (#411 <https://github.com/ament/ament_cmake/issues/411>)
  * Update maintainers to Michael Jeronimo
* Contributors: Audrow Nash

ament_cmake_gmock
* Fix compiler warnings related to gtest/gmock (#408 <https://github.com/ament/ament_cmake/issues/408>)
  * Suppress compiler warnings when building gmock
  definition of implicit copy constructor ... is deprecated because it has a user-declared copy assignment operator [-Wdeprecated-copy]
  * Declare gtest/gmock include dirs as SYSTEM PRIVATE for test targets
* [rolling] Update maintainers - 2022-11-07 (#411 <https://github.com/ament/ament_cmake/issues/411>)
  * Update maintainers to Michael Jeronimo
* Contributors: Audrow Nash, Robert Haschke

ament_cmake_google_benchmark
* [rolling] Update maintainers - 2022-11-07 (#411 <https://github.com/ament/ament_cmake/issues/411>)
  * Update maintainers to Michael Jeronimo
* Contributors: Audrow Nash

ament_cmake_gtest
* Fix compiler warnings related to gtest/gmock (#408 <https://github.com/ament/ament_cmake/issues/408>)
  * Suppress compiler warnings when building gmock
  definition of implicit copy constructor ... is deprecated because it has a user-declared copy assignment operator [-Wdeprecated-copy]
  * Declare gtest/gmock include dirs as SYSTEM PRIVATE for test targets
* [rolling] Update maintainers - 2022-11-07 (#411 <https://github.com/ament/ament_cmake/issues/411>)
  * Update maintainers to Michael Jeronimo
* Contributors: Audrow Nash, Robert Haschke

ament_cmake_include_directories
* [rolling] Update maintainers - 2022-11-07 (#411 <https://github.com/ament/ament_cmake/issues/411>)
  * Update maintainers to Michael Jeronimo
* Contributors: Audrow Nash

ament_cmake_libraries
* [rolling] Update maintainers - 2022-11-07 (#411 <https://github.com/ament/ament_cmake/issues/411>)
  * Update maintainers to Michael Jeronimo
* Contributors: Audrow Nash

ament_cmake_nose
* Deprecate ament_cmake_nose (#415 <https://github.com/ament/ament_cmake/issues/415>)
* [rolling] Update maintainers - 2022-11-07 (#411 <https://github.com/ament/ament_cmake/issues/411>)
  * Update maintainers to Michael Jeronimo
* Contributors: Audrow Nash, Scott K Logan

ament_cmake_pytest
* [rolling] Update maintainers - 2022-11-07 (#411 <https://github.com/ament/ament_cmake/issues/411>)
  * Update maintainers to Michael Jeronimo
* Contributors: Audrow Nash

ament_cmake_python
* [rolling] Update maintainers - 2022-11-07 (#411 <https://github.com/ament/ament_cmake/issues/411>)
  * Update maintainers to Michael Jeronimo
* Contributors: Audrow Nash

ament_cmake_target_dependencies
* [rolling] Update maintainers - 2022-11-07 (#411 <https://github.com/ament/ament_cmake/issues/411>)
  * Update maintainers to Michael Jeronimo
* Contributors: Audrow Nash

ament_cmake_test
* [rolling] Update maintainers - 2022-11-07 (#411 <https://github.com/ament/ament_cmake/issues/411>)
  * Update maintainers to Michael Jeronimo
* Contributors: Audrow Nash

ament_cmake_version
* [rolling] Update maintainers - 2022-11-07 (#411 <https://github.com/ament/ament_cmake/issues/411>)
  * Update maintainers to Michael Jeronimo
* Contributors: Audrow Nash

This was necessary to add an additional patch that I missed in #36598


Improve a11y by reverting outline default styles

Closes https://github.com/CloudCannon/pagefind/issues/159

Thanks @joachimesque
I'm curious though whether this is a net positive or negative for a11y overall. This change does ensure that the browser default focus styles always apply, so that's good. On the other hand, if a site has created a specific focus style on a website (say, a red outline) then this change would remove that and make the focus styles on their website inconsistent. An end user would have to look for either the custom focus style for the rest of the site, or the browser focus style on Pagefind elements.
What are you thoughts about that case?

That is true, I hadn't thought that non-default focus styles would be overwritten by browser default styles.
In https://github.com/elad2412/the-new-css-reset/issues/25, the choice was made to just document the fact that default focus styles would be erased (without mentioning that using the reset would make your website or component inaccessible). With that, I think that it's not a good idea to
My opinion is that something should still be done to ensure that basic accessibility requirements are met, and default focus styles are better than no focus styles. In the case of custom focus styles, the reset can be overwritten by more specific selectors, but the developer has to be warned in the documentation.
If the choice is made to keep the reset as it is, there should be a warning on the documentation that keeping the resetStyles to true will not be accessible unless a CSS rule is added.
In both cases the solution will require documentation, I'll amend the PR accordingly.
(PS: I love that the doc is in the same repo as the code, it makes these kinds of things easier)

Hey @joachimesque sorry for the mega-delay here! Forgot about this over the holiday break and then the underlying code churned around a bit.
I re-reviewed this and am happy, but as files have moved around it isn't directly merge-able. I've instead pushed a co-authored commit with the same change (https://github.com/CloudCannon/pagefind/commit/456c573c13d511bab700eef872d6b77ba704482c) — hope that's ok! This will go out with the 1.0 release.
Thanks again 🙏


Any way to disable docs publication?

Hi,
I'm using dune-release to publish a package that already have some website/documentation under gh-pages, when I run dune-release it pushes to the branch overriding the website artifacts with odoc artifacts.
I would like to disable the odoc generation somehow without losing the documentation field under opam.

Hi @davesnx. You can try to call dune-release publish distrib instead of dune-release publish, that should avoid the documentation being pushed.
With the new package documentation on ocaml.org we should probably disable the documentation pushing by default, since it is clearly inferior to those.

Thanks for the fast answer @Leonidas-from-XIV
I will try in the next release to publish the distribution only, Thanks.


Possibly get rid of defineFunctions or change how it works

For example, passing in an element as well (or an id). Relying on getting the script element is kinda problematic and can be left to users.

It also might be smart to rename it Game.defineFunctions, to show the connection there.


My account link for the invited flows are not teneted.

Describe the issue:
My account link for the invited flows are not tented.
Link: https://wso2.is:9443/myaccount

How to reproduce:

Login to console (teneted)
Do user invite to set a password flow
Get the link received for the email
Click and set the password.
Click the My account link to access the tented my account

Expected behavior:
User should be navigate to the teneted my account login page.
Environment information (Please complete the following information; remove  any unnecessary fields) :

Product Version: [e.g., IS 5.10.0, IS 5.9.0]
OS: [e.g., Windows, Linux, Mac]
Database: [e.g., MySQL, H2]
Userstore: [e.g., LDAP, JDBC]

Optional Fields
Related issues:

Suggested labels:

Presently, on the frontend side, we extract the My Account link URL using the IdentityManagementEndpointUtil.getUserPortalUrl method (source: link). However, the current behavior of this method is limited to returning only the My Account URL for the super tenant and does not include the tenanted My Account URL (source: link).

Fixed with : https://github.com/wso2/carbon-identity-framework/pull/5325


View for general survey info

[Frontend] - View for survey info with its logo and organization details

Done


fix: allow targets without a options attribute

This pr makes it so the options attribute does not need to be present on a  target within a project.json ( NX )
This originally came from here where Jaka had a valid project.json without a options attribute in his build target, adding an empty one like "options": {} satisfied NIXPACKS.
I seem to be unable to run the NX tests on my branch neither main. So ill look into that tomorrow afternoon if i cant find the cause asap ( Sleep is vital :))

Need to swap out the builder for something that does not require a options attribute -_-

Just pushed an astro project without the options attribute. Please not ive used a dumby start command as astro build a static site with this nx extension and as we dont care about the start command in this test its fine.
thanks to whoever has run ci. quick reaction times :)

Interesting ive broken some of the other NX tests. ill try get the working on my mac, its an m1 so i am having issues with that atm

Should be fixed. Caused by sleep deprivation 🙄

Looks like its happy. Just talking to neb about some unwraps i noticed. Happy to fix them in this PR or create another just dont want to be spammy with PR's  https://discord.com/channels/713503345364697088/960605685920452669/1020105591210922055

Good idea. renamed!
Also spoke to neb and he suggested that a new pr should be made to fix the unwraps in the node provider.


markdown live edit: moved buttons so that there is more horizontal ed…

Increased the horizontal edit area size by moving the save/close button group above and below the text area.

Thank you, that helps.
Merged.


Fix a report card issues for passing to awesome-go list

https://goreportcard.com/report/github.com/grafov/m3u8
Refs to https://github.com/avelino/awesome-go/pull/2810

Congrats! We have added to the awesome list :) https://github.com/avelino/awesome-go/pull/2810#event-2796308789


Support other storage types

Ideas but open to any

Big Query
SQL Server
MySQL
MongoDB
Amazon DynamoDB
Oracle
more welcome

parquet would be a great one
https://parquet.apache.org


Create mendizabala.txt

Adding CIFP MENDIZABALA LHII name to the domain list.

@asagasti First stage of verification passed, official domain is euskadi.eus as far as I verified. This is just an informational note. Pull request is still in the review. I appreciate your patience while waiting for the final decision. Proof of domain ownership: https://www.euskadi.eus/ac70cPublicidadWar/historicoAnuncios?idExpediente=625585&idioma=es

That's right, but euskadi.eus is the domain of the basque government. Our school's domain is mendizabala.eus.

@asagasti Thank you for the clarification and your patience while waiting for a review and processing your request. Pull request merged.


Rails 5 undefined method `on'

Hi.
I migrated my project from RAILS 4.2.6 to RAILS 5.0.0.
I see an error when I try start server on RAILS 5.0.0, work well on RAILS 4.2.6.
Error:
<top (required)>: undefined method 'on' for Bot:Module (NoMethodError)
from /home/vitalii/.rvm/gems/ruby-2.3.1@cai_bot/gems/activesupport-5.0.0/lib/active_support/dependencies.rb:293:in 'require'

Code:
include Facebook::Messenger
Bot.on :optin do |optin|
  recipient(optin)

  Bot.deliver(
      recipient: optin.sender,
      message: {
          text: 'Welcome message'
      }
  )
end

My fault.
I created a new project called BOT.
I changed the name of project and the error has disappeared


ess_imu_driver2: 2.0.0-1 in 'humble/distribution.yaml' [bloom]

Increasing version of package(s) in repository ess_imu_driver2 to 2.0.0-1:

upstream repository: https://github.com/cubicleguy/ess_imu_driver2.git
release repository: https://github.com/ros2-gbp/ess_imu_driver2-release.git
distro file: humble/distribution.yaml
bloom version: 0.12.0
previous version for package: 1.0.1-1

ess_imu_driver2
* port changes from imu_linux_example, remove V340 support
* auto-detect/initialize IMU model at runtime

Found small default variable assignment issue in CMakelists.txt.


POST request body is undefined when use willSendRequest

path : packages/apollo-datasource-rest/src/RESTDataSource.ts line 210
issue : POST request body is undefined when use willSendRequest
current code :
    const modifiedRequest: WillSendRequestOptions = {
      ...request,
      // guarantee params and headers objects before calling `willSendRequest` for convenience
      params:
        request.params instanceof URLSearchParams
          ? request.params
          : new URLSearchParams(request.params),
      headers: request.headers ?? Object.create(null),
      body: undefined,
    };

change required :
    const modifiedRequest: WillSendRequestOptions = {
      ...request,
      // guarantee params and headers objects before calling `willSendRequest` for convenience
      params:
        request.params instanceof URLSearchParams
          ? request.params
          : new URLSearchParams(request.params),
      headers: request.headers ?? Object.create(null),
    };

actual behavior : when use willSendRequest which post method in any class extends RESTDataSource every post request have missing body
expected behavior : when use willSendRequest request body is the same as defined by user
reproduce : create any class extends RESTDataSource, create anyone POST request and try to use willSendRequest method. Body in this request will be undefined

Sort of related, but it also means there is no way to post application/x-www-form-urlencoded where body would be url encoded string, the condition after this block sets modifiedRequest body only if it is an object, this must be a bug

exactly :)

Any update ? It's been more than 3 weeks and this is critical

@dycor sure. I have a PR open as you can see in the updates on this issue.
A combination of holiday/vacation and other work priorities mean it's not ready to land just yet,but it's in progress and on my radar.
In the meantime, you're welcome to continue using the previous version of this package which doesn't have this regression or fork and patch it yourself until we release a fix for it. You're also welcome to try out the build from my PR and use it until we release a fix. I've solicited feedback for exactly that and would be happy to hear of it solves the issue for you. It's obviously WIP so use at your own risk.


remove impl<E> From<E> for Error where E: StdError + Send + Sync + 'static

This might a bit controversial but I'd like to bring it up. I want to suggest to remove the generic From<StdError>.
The reason being the following:
As long as this generic implementation exists it is not possible for errors as defined by users of this library to implement their own Into implementations, this makes it hard to use when you need non-generic 500 error codes.

I think this would also solve #88


Should ceylon.ast comply with the compiler instead of the specification?

The ceylon.ast.core module documentation says:

ceylon.ast seeks to comply only with the [Ceylon Language Specification][spec], not its implementation in the compiler.
[spec]: https://ceylon-lang.org/documentation/1.3/spec/html_single/

Should we abandon this, and instead seek compliance with the compiler?
If yes: how far do we go? The module documentation cites the example of empty resource lists for try, which are permitted by the grammar so that the compiler can give you a better error message than a syntax error. Should cases like this be allowed as well, or only cases that are actually legal on at least one backend, without any error messages, like #122?
Pros:

It would probably make ceylon.ast more useful.

@jvasileff might finally stop pestering me with non-bugs like #122.

Cons:

The additional rules in the compiler are undocumented and subject to change with even less notice than the specification. I recall several cases where I only noticed a spec change relevant to ceylon.ast or ceylon.formatter by sheer luck, and it’s likely that I already missed some that @gavinking smuggled past me. I can’t imagine how I could hope to keep up with the compiler if every change potentially needs to be reflected by ceylon.ast.

If a feature is later adopted in the specification, the specification’s description of it might be different from the ceylon.ast model, and ceylon.ast would have to be updated, breaking users’ code.

We boast an “exhaustive… specification” in our quick intro, so this issue should not even be up for debate in my opinion.

@jvasileff might pester me with a lot more now-actually-bugs like #122.

My thoughts:

For ceylon.ast to be used for a backend, it's important that it accept everything that passes through the typechecker without error. This includes code written for all backends, due to how native works.
For other proposed uses, such as https://github.com/ceylon/ceylon/issues/1865, it seems the same
There don't seem to be that many deviations from the spec. I've reported all that I have found.

There don’t seem to be that many deviations

I assume that you don’t want to accept try () and suchlike? Because there’s a lot more of cases like that.

accept everything that passes through the typechecker without error

To be clear, I mean within reason, and for things that aren't considered bugs-that-will-be-fixed in the typechecker.

try ()?

Yes, because that gets you an

error: empty resource list

instead of an

error: incorrect syntax: extraneous token ',' expecting closing parenthesis ')'

which is what the “how far do we go?” question in the issue is about.

I see. I'm not currently exposing ceylon.ast to trees that have errors, recognition or otherwise.
Except... I am concerned about what to do about native(other) declarations that have errors like that, since I'm currently ignoring errors that don't apply to Dart. Its unclear to me if the ones I should care about can be distinguished from those that can't. This is a tricky problem:
native("jvm") void foo() {
    try() {}
}

crashes compile-dart, while the same w/o native does not.
Maybe I can pre-process the rhAst to remove stuff I want to completely ignore. But then, what if there's some reason I do need those declarations? Just brainstorming, another option may be to have some filtering mechanism in ceylon.ast.redhat.

@lucaswerkmeister I propose we resolve this issue by saying that "within reason" ceylon.ast should accept whatever the typechecker accepts without error, for any backend, after full typechecking.
Hopefully some form of pre-processing or filtering can address issues with allowing errors in native("other") declarations, but that seems like a separate issue.
Tell me if I'm wrong, but it seems that having ceylon.ast vastly reduce its type safety and assertions, to support uses such as being used during typechecking or ceylon/ceylon#1865 before typechecking, would be a much bigger, more complicated, and more fundamental change.

@jvasileff opinions on fe3a0e2?

@lucaswerkmeister I think that looks great 👍

Alright, then let’s close this issue :)


Capture and log user information in endpoint requests to help with monitoring and troubleshooting

There is no user ID's  available to us in the lambda context object, at least not without implementing API gateway +Authorization first so we can't log this information using the python logger.
However this can be implemented by using AWS CloudTrail.
Create a new 'Data Events' trail using CDK that listens to our lambda endpoints and then update geostore configuration in elastic shipper if needed.
Log shipper should automatically pick up these CloudTrail logs with user identifications.

@MitchellPaff can you please update here with your initial findings.

Hi @MitchellPaff . Sorry forgot to talk about this one this morning. Fine to finish this off if it's only a little bit of work. Let me know when you've got something ready to review.


Why can't I create an elliptic curve cipher with default parameters

If I try to generate an elliptic curve key pair and use it to initialise an ECIES cipher as follows:
        val keyGen = KeyPairGenerator.getInstance("EC")
        keyGen.initialize(521)
        val keyPair = keyGen.genKeyPair()

        val cipher = Cipher.getInstance("ECIES")
        cipher.init(Cipher.ENCRYPT_MODE, keyPair.public)

The cipher.init line throws the exception:
cannot handle supplied parameter spec: must be passed IES parameters
java.lang.IllegalArgumentException: cannot handle supplied parameter spec: must be passed IES parameters
	at org.bouncycastle.jcajce.provider.asymmetric.ec.IESCipher.engineInit(IESCipher.java:367)

Looking at the code I can see the reason for this exception in the ed and edec classes IESCipher:
        // NOTE: For secure usage, sender and receiver should agree on a fixed value for the nonce.
//        if (engineSpec == null)
//        {
//            byte[] nonce = null;
//            if (ivLength != 0 && opmode == Cipher.ENCRYPT_MODE)
//            {
//                nonce = new byte[ivLength];
//                random.nextBytes(nonce);
//            }
//            this.engineSpec = IESUtil.guessParameterSpec(engine.getCipher(), nonce);
//        }
//        else
        if (engineSpec instanceof IESParameterSpec)
        {
            this.engineSpec = (IESParameterSpec)engineSpec;
        }
        else
        {
            throw new InvalidAlgorithmParameterException("must be passed IES parameters");
        }

The following code however will work:
        val iesParamSpec = IESParameterSpec(
            /* derivation = */ null,
            /* encoding = */ null,
            /* macKeySize = */ 256,
            /* cipherKeySize = */ 256,
            /* nonce = */ null,
            /* usePointCompression = */ false
        )

        val keyGen = KeyPairGenerator.getInstance("EC")
        keyGen.initialize(521)
        val keyPair = keyGen.genKeyPair()

        val cipher = Cipher.getInstance("ECIES")
        cipher.init(Cipher.ENCRYPT_MODE, keyPair.public, iesParamSpec)

So it looks to me like you used to support default parameters for ECIES and then removed this support because "For secure usage, sender and receiver should agree on a fixed value for the nonce." but I'm still able to create an IES cipher with a null nonce.
For reference I'm only using this cipher locally. A user generates a key pair, encrypts data with the public key and decrypts it with the private key. There is no key exchange in my application.
Is it actually insecure to initialise a cipher with a null nonce value and if not, why not allow default parameters for IES cipher again to better support the JCA interface? If it is insecure maybe you should throw an exception if a user passes a null nonce?

Perhaps you could tell me what security properties/vulnerabilities IESCipher has when used without a nonce? Looking at the code it looks like you generate a random number and implement a stream based cipher. I'm curious why this is not considered a reasonable default/fallback implementation if the user does not provide IESParameterSpec?

For algorithms like ECIES (a.k.a ECIESwithSHA1) that don't involve a symmetric cipher, there is no nonce needed (in the code ivLength == 0), so it does appear that engineSpec == null (in engineInit) could still be supported in that case, and the original patch went a little too far.
The security vulnerability being addressed is that a randomly generated nonce has to be communicated to the receiver, and this introduces a malleability problem (nonce -> plaintext) unless that nonce is protected using an authentication mechanism; but we have no way to know whether that is present and so it is a bad idea to just generate such a random nonce as a default behaviour. A user can still choose to use a random nonce if they know it will be safe, but it appears the current recommendation is just to agree on a fixed nonce (if one is needed) to use across many operations (since each operation is using a new random key already).
That concern is clearly moot when no nonce is even needed, so IMO the original functionality should be partially restored for the no-nonce case.

I've now partially reversed the earlier fix so that a null engineSpec is acceptable if the specific IES algorithm does not require a nonce.

Sorry for the late reply. Thanks for taking a look.

Hi SamAmco, Have you fixed this problem yet? , if yes, please tell my your solution to fix it, I'm facing that problem

@HuyenNguyenVan I can confirm that I am now able to initialize an ECIES cipher with no parameter spec yes. I'm not sure what issue you're facing specifically.
You can see my code here:
https://github.com/SamAmco/MEND4/blob/master/core-mend/src/main/java/co/samco/mend4/core/crypto/impl/DefaultJCECryptoProvider.kt
Specifically the function:
    private fun getAsymmetricEncryptCipher(): Cipher {
        val cipherTransform = settings.getValue(Settings.Name.ASYMMETRIC_CIPHER_TRANSFORM)
            ?: throw NoSuchSettingException(Settings.Name.ASYMMETRIC_CIPHER_TRANSFORM)
        val cipher = Cipher.getInstance(cipherTransform)
        assertValidAsymmetricCipher(cipherTransform)
        cipher.init(Cipher.ENCRYPT_MODE, getPublicKey())
        return cipher
    }

Where it is possible for the asymmetric cipher transform to be "ECIES". I appreciate the above fix as it keeps this code more generic and doesn't require special case code depending on the asymmetric cipher transform provided.


Swift 3 Support

does Kingfisher support Swift 3 and new API changes in IOS SDK ?

There is already a swift3 branch for it. However, it is just a auto migration and not following Swift 3 API guide at all.
Kingfisher will not support Swift 3 in such an early stage, since it is only the first preview. There could be quite a lot of additional changes in Swift 3 and now no one could use Swift 3 in their product.
Maybe we will work on it from next month.

@indrajitsinh Swift 3.0
Refer to the adjustment changes here
https://github.com/ideago/MouQu

Swift 3 support is in progress in #371

swift3branch needs a new update for the Xcode 8 Beta 6 compatibility.

Swift 3 supported from Kingfisher 3, and in master branch now.


Is this packade is only for SPA (csrfCookie) not for Mobile Apps (Token) ?

Hi,
I'm building a mobile app and I would like to use this package, but it looks like it's only to be used with csrfCookie. We cannot make it works for Sanctum Token ?

Yes, you are correct. I know some people have modified this package for use in their React Native apps, but these are unfortunately not open source.
It shouldn't be too hard to modify the code to not use cookies, however I haven't done this before myself so I'm afraid I can't help you with that part.


we should enforce the contribution guidelines

see https://github.com/hyperledger/fabric/blob/master/README.md#coding-golang-
we should be running golint and go vet in the CI build and flagging PRs that aren't conforming.
Would advise we do so after we transition to Jenkins @bmos299

I, too, like the "treat warnings as errors" approach. Otherwise, it may be difficult to allow only X (for example) lint issues, X \neq 0 (e.g., "oh, we all know about these X acceptable lint warnings").
Better/simpler not to allow any deviation from the guidelines at all.

Sure.   All enterprise grade products I have worked on classify build warnings as a failure.  Adding @rameshthoomu to the issue.

I would add gofmt to the list as well: Check that diff of file and 'gofmt file' is null for all changed Go files.

@bcbrock yes, agree - in fact, golint and go vet are required already https://github.com/hyperledger/fabric/blob/master/README.md#coding-golang- of course, I just noticed that this guidance is misplaced.

closing, we have this in place


Update for moment feature deprecation

'Deprecation warning: moment construction falls back to js Date. This is discouraged and will be removed in upcoming major release. Please refer to https://github.com/moment/moment/issues/1407 for more info.'

@imsickofmaps Please review.

:+1:


Update Python examples with fresh generated code

Sanity is currently failing for this change because check_copyright.py currently presumes that if a file is protocol buffer compiler output it will contain the text "DO NOT EDIT" in it.
@soltanmm-google: any idea why our _pb2.py files contain "DO NOT EDIT" in their text but not our _pb2_grpc.py files? We don't seem to instruct protoc to put it in either, so why does it show up in one but not the other?

Probably because *_pb2.py files are primarily generated by the built-in Python proto plugin. Will add that line in for the *_pb2_grpc.py files soonish.

@nicolasnoble: please review the change to check_copyright.py.


Add prometheus metrics to tpc-api-generator

#140  👈
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @tremarkley and the rest of your teammates on  Graphite


Fix perfect scrollbar issues

This makes the total left sidebar real estate 40px taller and brings
it flush with the bottom of the screen, giving more room to the
streams list.
Fixes: #6549.

updated with an onupdate call!

Merged, thanks @brockwhittaker!


Updates v1.25 config.toml for v1.29 release

Updating config.toml for release v1.29.
/hold until v1.29 release day.

/approve

/unhold


One-off Signed-off-by on older commits (OSS Hygiene)

Now that we enforce "signed-off-bys", we'll need to collect them for older commits.

[ ] enable GitCop on all org repos. (oof, can we have a script do this?)
[x] draft email to contributors
[ ] make list of (commit, author, email, commit gh link) for commits needing signed-off-bys
[ ] make google form
[ ] send out email (only send out after it's been enabled all over)

i'll do most of this but could use help with the enabling GitCop everywhere. if we can script that, it would be awesome.

this is just a draft for prep.

TL;DR: we need explicit "Signed-off-by" sigs for some git commits. You can just sign this google doc form, and done!
<google-form-link>

Long Version:
Greetings Everyone,
Thank you very much for your past, present, and future contributions to the IPFS Project. Sorry to bother you with this silly Open Source hygiene thing.
As you may remember, the various code repositories of the IPFS Project are MIT Licensed. All contributions carry the same MIT license, except for "vendored" or "linked" code, which carries compatible licenses (BSD, Apache 2, etc).
You're getting this email beacuse you contributed code to an IPFS Repository, before we began enforcing the "License commit trailers required" policy. A "License trailer" is a small signoff in the bottom of a commit message, that looks like this:
License: MIT
Signed-off-by: Juan Batiz-Benet<EMAIL_ADDRESS>
The "Signed-off-by" part is the sign-off typical to the linux kernel, git, docker, and other projects. The "Sign-off" agrees to the Developer Certificate of Origin (1.1), which is a document that certifies the contribution. You can find out more about the DCO here: http://elinux.org/Developer_Certificate_Of_Origin and see our own hosted copy here: https://github.com/ipfs/community/blob/master/docs/developer-certificate-of-origin
The reason these projects ask for the explicit "Signed-off-by" trailer in commits is that a conscious step must be taken by the contributor to formally sign the work to the license, even if only done once. As far as lawyers are concerned, it is really not enough to make a pull-request on a repo with a given License file (as of 2015-06). Rather than hope law practice catches up to common open-source practice, we want to make absolutely sure that all users can use and contribute to IPFS without any worry. Thus (advised by our lawyers) we are making sure all the commits have a "Signed-off-by" clause. And we now have a bot that checks Pull Requests for us: GitCop (many thanks to the author gazler and chriscool for setting it all up). GitCop verifies the trailers, and otherwise asks the author to add them, pointing to guidelines, instructions, and even a helpful git commit hook.
The "License: MIT" part is a section added to make it clear, beyond shadow of a doubt, that all the code in the the commit at hand has been Licensed MIT, as the rest of the project, regardless of where that commit lands. Note that it is understood that if non-MIT vendored code is included and clearly labeled with its own LICENSE file in its own directory and/or with License headers on the files then that code carries that License. (We do not have an automated check today for verifying the LICENSE files added are all compatible with the MIT License, but we may in the future).
So, there's a few commits you made that we need to get explicit "Signed-off-bys" from you. The commits are technically already covered by the License file in the root of the repo, as is common practice and our contribution documentation states, but it is important that we make sure we apply the same level of OSS hygiene to them.
To make this easy for you, we've made a google doc form for everyone. You just need to fill out your name and email, as it would appear on the commit sign-off, for example:
Juan Batiz-Benet<EMAIL_ADDRESS>
We'll then make one commit to the repository noting all the relevant commit hashes, with all the "Signed-off-by" lines. The google form takes only a few seconds, and is over at:
<google-form-link>

Again, thank you so much for your contribution, thank you for your prompt reply, and sorry to bother you with this silly thing!
Thanks,
Juan Benet

We should get this for the JS repos as well. @RichardLitt could you lead this?

Talked to @flyingzumwalt a bit about this today. I can certainly help, but not sure I'd be the best DRI for this particular effort.
Are we still going with gitcop? I haven't seen it in a while - have I just not been watching go-ipfs enough? That's the only repo we use it for, currently, correct?

Just had some fun: It would be possible to ask users to add a global git commit hook without too much hassle. We could have them add this:
#!/bin/sh

if [[ $(git remote get-url origin | grep "[ipfs|libp2p|ipld|orbit|multiformats]") ]]; then
  grep "^License:" "$1" || {
  	echo >>"$1"
  	echo "License: MIT" >>"$1"
  	echo "Signed-off-by: $(git config user.name) <$(git config user.email)>" >>"$1"
}
fi

If you're working on any of our repos, you would automatically add the same things we currently add only to go-ipfs.

Oh, I didn't know you global commit hooks. Where would you put that script?
About GitCop, I've seen it just the other day -- we're eager to switch away from it. It's just very blunt and unfriendly.

Oh, I didn't know global commit hooks. Where would you put that script?

It's a relatively new thing that has not yet trickled down to dists: https://github.com/git/git/commit/867ad08a
You still need to distribute a config somehow, this is the closest to "safe" I was able to come up with some time ago (read the commit message carefully): https://github.com/dbsrgits/dbix-class/commit/1f99022a59

It's pretty easy to implement: https://coderwall.com/p/jp7d5q/create-a-global-git-commit-hook.
@ribasushi I'm not sure about that config setup. The solution I just l pointed to seems to work for me. Maybe I am missing something?

@RichardLitt you mentioning global commit hook made me think of the git 2.11 feature, not of init templates.
The extra faffing I show in the second paragraph is a workflow to both allow updates from upstream ( the scripts are hosted in-repo, instead of some one-off comment on github ) while at the same time highlighting the concern that a malicious committer might drop unsavory code into the hook/config areas.

@dignifiedquire Pointed out that github  added a default contributor license. We could potentially use that. However, as @Kubuxu mentioned in the All Hands call, this means it is a bit more removed from git.


Typo on module dir constant

Questions
Answers

Description?
Typo on module dir constant

Type?
bug fix

BC breaks?
no

Deprecations?
no

Fixed ticket?
none

How to test?
upgrade

Possible impacts?
none

thank you @jf-viguier :+1:


[feature] Multiple emails

Status: ready for review

@lyndsysimon Let's focus this PR on the limited multiple emails requirement i.e. ability to add emails to a user account that are non-existent, or unregistered/unconfirmed -- and then knock this out -- OK

1st pass finished. :point_up:

Ready for second pass.

2nd pass finished. :v:

Bah. For some reason, Travis isn't building this every push.
I've got my repo to build as well, and this passes: https://travis-ci.org/lyndsysimon/osf.io/builds/56771321

Response to 2nd pass complete. Your move, @sloria...
:game_die:

Pass finished. :tanabata_tree:

Third pass review complete.
:pager:ing @sloria.

Is there any way to resend a confirmation email?

Minor "bug": When adding an unconfirmed that is already in the list of unconfirmed emails, the growl message says "Email added" when it should probably say "Email already added" or something similar.

Bug: Whenever I input an unconfirmed email with an uppercase character, I get an error message "Email validation failed", but the email still gets added.

Doesn't have to be added before this is merged, but we might want to add a little helper text (e.g. with a question-mark button) to explain what it means to make an email "primary".

Pass finished. :deciduous_tree:

Some input from Trello re: the "Email added" message: https://trello.com/c/X8aJ9lC7/73-more-information-when-email-is-added

Also: https://trello.com/c/Udvre4jB/75-adding-an-email-for-a-confirmed-account-with-no-email-set

ed20e52 address https://trello.com/c/X8aJ9lC7/73-more-information-when-email-is-added

@sloria rdy for review

:+1:


chore: add sanitary actions

add dependabot for version bumps
add linting for PRs
update package info

This PR can go in once approved. I separated the release bits into PR #7

Same question on this PR I guess, still skipping?
https://github.com/awslabs/aws-proton-plugins-for-backstage/blob/main/.github/workflows/upgrade-backstage.yml

yeah not completely sold yet. I think a broken main branch that we cant tell is broken still bugs me. particularly with a green checkmark we get from running the units.

Addressed separately


Fix name spelling

I am French :-)

Ouch, so sorry! Bad fingers, bad!

fixed in master and RB-1.6


A problem in trajectories.py

I think there is a problem in this code segment.
def poly_fit(traj, traj_len, threshold):
"""
Input:
- traj: Numpy array of shape (2, traj_len)
- traj_len: Len of trajectory
- threshold: Minimum error to be considered for non linear traj
Output:
- int: 1 -> Non Linear 0-> Linear
"""
t = np.linspace(0, traj_len - 1, traj_len)
res_x = np.polyfit(t, traj[0, -traj_len:], 2, full=True)[1]
res_y = np.polyfit(t, traj[1, -traj_len:], 2, full=True)[1]
if res_x + res_y >= threshold:
return 1.0
else:
return 0.0
res_x and res_y are residuals of quadratic terms, so if the value of (res_x + res_y) is bigger than threshold, indicating that the trajectories don't conform to the quadratic distribution. But the code indicates Non Linear. Is not contradictory？

I think the code should be changed to the following:
res_x = np.polyfit(t, traj[0, -traj_len:], 1, full=True)[1]
res_y = np.polyfit(t, traj[1, -traj_len:], 1, full=True)[1]
Is my idea correct？


.Net: ADR for AI connector support

The purpose of this task is to create an ADR to describe our AI Connector strategy and how new AI Connectors can be contributed.
Below are a series of user stories that must be addressed by the ADR.
Strategy
As a developer using Semantic Kernel I can use AI Connectors that access LLM's deployed in the Cloud e.g. OpenAI, Azure OpenAI, Hugging Face, ... or deployed locally so that I can configure by application to use the optimum LLM or to run completely offline.

Our strategy should allow us to maximise the reuse of AI Connector implementations e.g. if we can configure the same connector to work with online and offline deployments that is a win.
Developers should be able to deploy and use local models easily.

Contributing an AI Connector
As a contributor to Semantic Kernel I can read the documentation which describes how to contribute an AI connector so that I can understand the development process and requirements to have a new AI Connector included in a Semantic Kernel release

Describe how we successfully co-develop AI connectors with the community.
We want to avoid receiving huge PR's that are very difficult to review.
We want to ensure each AI connector includes a defined level of unit tests and integration tests.

P0 LLMs

Phi-2 (Microsoft)
Gemini (Google)
Llama + function calling (Facebook)
Claude (Anthropic)
Multi-modal models (e.g., Stable Diffusion)

Deployment types

Azure AI
Hugging face
Local

LM Studio - Discover, download, and run local LLMs
Ollama
Pure C# (e.g., LlamaSharp or ONNX runtime)

Bedrock (Amazon)

So... If I understand correctly you prefer connector project per one model (or model faimily) (even if has multiple deployment types) than project per deployment (one project contains multiple models)?

As I understand is a Connector per platform/API definition, so a connector can support the same model on a specific platform.
i.e:
LMStudio -> Phi-2
HuggingFace -> Phi-2

@RogerBarreto thanks for clarification I was wondering if the "googlevertexai connector" way is ok.

@Krzysztof318, will review your PR today and give you a better feedback, is a big one, this one may be graduated to a feature branch later on.

@RogerBarreto I would appreciate for dedicated branch, it will also be more convenient for me to maintain small PRs.


import error in example

from fastapi_oidc import IDToken
cant find the IDToken.
I could use it as bellow
from fastapi_oidc.types import IDToken

Whoops! Thanks @sohan99. I'll expose IDToken (and other types) in the project root. In the meantime from fastapi_oidc.types import IDToken should work.

Patched and release in v0.0.8 @sohan99 😺 Thanks for the heads up!


create adr for migrating from TEST stellar wallets to STD

Description
create adr for migrating from TEST stellar wallets to STD
Checklist

[ ] Pre-commit hook is installed to do formatting checks before committing code...etc
[ ] Tests included
[ ] Build pass
[ ] Documentation
[ ] Code format and docstrings

Codecov Report

Merging #2074 (72d7520) into development (3c8b530) will decrease coverage by 0.01%.
The diff coverage is 60.00%.

@@               Coverage Diff               @@
##           development    #2074      +/-   ##
===============================================
- Coverage        32.54%   32.53%   -0.02%
===============================================
  Files              136      136
  Lines            13197    13187      -10
===============================================
- Hits              4295     4290       -5
+ Misses            8902     8897       -5

Impacted Files
Coverage Δ

jumpscale/entry_points/threebot.py
34.73% <60.00%> (-0.87%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c61a151...72d7520. Read the comment docs.


Arrow keys are not working when debugging

Your environment

ruby -v:  ruby 3.3.4 (2024-07-09 revision be1089c8ec) [x86_64-darwin23]
rdbg -v:  rdbg 1.10.0

Describe the bug
When I debug a ruby script I am not able to use the arrow keys.
To Reproduce
gemfile
source 'https://rubygems.org'

ruby '3.3.4'

gem 'debug'

issue.rb
require 'debug'

debugger
puts 'something'

running the script and hitting the up arrow:
➜  ruby issue.rb
[1, 4] in issue.rb
     1| require 'debug'
     2|
=>   3| debugger
     4| puts 'something'
=>#0	<main> at issue.rb:3
(rdbg) ^[[A

Expected behavior
I expect the up arrow to go throw history and the left array to be able to move backwards on the line.
Additional context
Thank you so much for this gem!
I suspect something is wrong with my setup/OS that is causing this issue, but I am not sure how to track it down at this point and would appreciate any feedback.
I am able to use the arrow keys if I swap debug gem out for the pry gem, and the arrow keys work in irb.

I can't reproduce this issue. Can you try the following approaches:

Run bundle exec ruby issue.rb to make sure it picks up debug v1.10.0 instead of the version shipped with Ruby 3.3.4?
Check if the reline version in Gemfile.lock is the latest release

Thank you for the help!
I am still seeing the issue with bundle exec ruby issue.rb

The gemfile is showing reline at 0.6.0.

 Full Gemfile.lock
```
GEM
  remote: https://rubygems.org/
  specs:
    date (3.4.1)
    debug (1.10.0)
      irb (~> 1.10)
      reline (>= 0.3.8)
    io-console (0.8.0)
    irb (1.14.3)
      rdoc (>= 4.0.0)
      reline (>= 0.4.2)
    psych (5.2.2)
      date
      stringio
    rdoc (6.10.0)
      psych (>= 4.0.0)
    reline (0.6.0)
      io-console (~> 0.5)
    stringio (3.1.2)
PLATFORMS
ruby
x86_64-darwin-23
DEPENDENCIES
debug
RUBY VERSION
ruby 3.3.4p94
BUNDLED WITH
2.5.14
</details>

I have some new information!
It works fine if I sudo ruby issue.rb. So I must have installed something with the the wrong privileges.
I think this issue could be closed since it sounds like it is likely not an issue with the gem. I can continue to update the issue with more information once I find my permissions issue.

For anyone else who encounters this problem, I was able to resolve it by removing the following line from my ~/.zshrc file:
export RUBY_DEBUG_NO_RELINE=1

After removing this line, the arrow keys started working as expected during debugging. Thanks to the maintainers for their hard work on this gem!


Release new version?

Would love to get a new version that includes https://github.com/paulmillr/chokidar/commit/11aea72ad7c65216a0f767142ce57151c7b3d0c1 👍

@es128 or @paulmillr is there something that is holding this back? I'd be willing to put in some time to make this happen.

2.0.4 is out