Remove IEntity (Komm, Süsser Tod)

Requires https://github.com/space-wizards/RobustToolbox/pull/2305

PR Status:
I'm gonna need some serious help from maintainers or any voluntaries to finish this.
There are, approximately, 3k errors that need to be taken care of... And not only that, but countless optimizations need to be done now. After this is merged, we should probably instate a code freeze until we take care of the aftermath.

Builds, goes ingame and most tests pass. Unsetting draft


task: setup basic agones sdk actions and introduce autoscaler

@muratozkan - thanks for the review! I was able to use cargo features to implement a game server manager without the need of a trait!


First impression glow-ups ✨

In no particular order
On our website:

Add an image preview to downloads page https://zoo.dev/modeling-app/download (might be worth considering having one downloads page for all of our products vs per project (I like how figma does this)

Modeling App icon:

Adjust Icon to have fewer words (either just ZOO and we use the KittyCAD yellow for now, or create a unique one)

In Modeling App main home base:

Preview image of project on each project card as default, with icons to be able to choose whether you want projects displayed as a grid or as list. Image preview hidden in list view.
Ability to group projects into folders with previews of all (I like the format Figma does for this)
Move "+ New File" to the top, and rename to be either New Project, etc. so we're consistent (If you have a lot of projects, you currently have to scroll down to get to the New File button)
Add a top or side navbar that for now has helpful pages linked like Release Notes, Keymap, KCL Docs, KCL Samples (and can expand to other things around collaboration as well once we add more of those features)
Background color in light mode looks yellow to me, and dark mode shows up as dark green for me, so need to think a bit on colors here.
Ability to add tags to projects.
Add design bells and whistles so the main dashboard has more cohesion to our website.
"Recently Edited" section at the top or bottom with the 4 most recent, then "your files" or "all files" separate.
Share button that can let you send a project, etc.
Ability to search for a project in Command Palette
Rename Command Palette to Search or Find or Command (if we don't have a separate search bar)
Ability to customize keymap (future idea)

Misc questions/thoughts:

Do we have a keymap?
Customize shortcuts (like command L starting a line)
Consider using more common phrasing like "viewport" or "3d viewport"
Add "Mouse Controls" to settings (we think this was before but isn't now)
Ability to customize mouse controls
Ability to hover over line and get the midpoint, so you can just click the midpoint
Fix the way the grid zooms

I really like the ideas to improve the home screen aka the project picker. Especially having a screenshot of each project.

Nice a lot of cool ideas here for the Modeling App home. I'll mock something up with all this in mind and land it here; Home has been next on my hit list for glow-ups after I get the modeling view looking a bit better. Everything in your notes I think I can do but I may have to defer on tags. There's a rabbit hole of UX around tags that will require more thought. But I might be able to swing it, I have a few ideas. I'll convert your bullet points to individual issues as I get to them.

Preview image of project on each project card as default, with icons to be able to choose whether you want projects displayed as a grid or as list. Image preview hidden in list view.
Yeah I dig that idea, and I don't think it'll be too hard to get a first version of it where we save the last frame from the feed as the screenshot before the user quits or goes back to home.

Background color in light mode looks yellow to me, and dark mode shows up as dark green for me, so need to think a bit on colors here.
For sure the gray color ramp hasn't been migrated to the new one that has no saturation and is pure white at the top end, so it still has a little tint to it that I've gotta get rid of.

Share button that can let you send a project, etc.
I'm not sure what it would mean to share a project at the moment. We're not storing any project information anywhere on the web at the moment so it isn't possible to link to a project and share it. The two things I can think of a Share button doing are:

If the project is set up with version control and has a remote like GitHub, the link could lead to the remote repository
When we have a web version with remote web projects, a link with sharing permissions and all that, but that would have to be a future implementation.

Do we have a keymap?
No but we definitely should. In those newest mockups of the editor interface that is meant to be an option under the new question mark help icon in the lower right.

Customize shortcuts (like command L starting a line)
100%. We don't have a unified keybindings system and we should. I'll make an issue for this.

Consider using more common phrasing like "viewport" or "3d viewport"
Is this a note on the wording in the onboarding, or something like in the settings descriptions that we use a more confusing term? Happy to change it.

Add "Mouse Controls" to settings (we think this was before but isn't now)
Ah yeah Mike ran into this as well. It's a User-level-only setting, so if you're in a project it's easy to miss that you have to click into the User tab of the settings to be able to change them, but they're still available. I'll find a solution to make this problem of setting discovery between levels easier, that's definitely a design oversight on my part.

Ability to customize mouse controls
So you'd like the ability to click a "Set orbit controls" button, then perform the combination of keys and mouse presses that you like to save for that interaction?

Ability to hover over line and get the midpoint, so you can just click the midpoint
A good UX that has some surprising technical difficulties I've discussed with @Irev-Dev. I definitely agree we will need this.

Fix the way the grid zooms
Agreed, this is also in Jess' notes from that demo

Another idea for Modeling App Home as well as things like onboarding, side navs, pop up windows, etc. @franknoirot - is to play around with more glass/glassmorphism elements. When done subtly, it really modernizes things.

Ability to search for a project in Command Palette

Is this so that you can operate on a project; like open, rename, or delete it? You can do this today, but you first choose what command you want to perform, then search for the project you want to perform it on.


Possible bug in SSE code generation

USING: arrays kernel math math.vectors math.vectors.simd.cords sequences ;
IN: test9

! In this test, we should try to have a SIMD register live when gc is
! performed.
: test-simd-gc ( a b -- c )
    v+ dup first 10 > [ second ] [ third ] if 1array ; inline

: do-test ( -- a )
    double-4{ 2 20 30 40 } double-4{ 2 4 3 2 }
    test-simd-gc ;

IN: scratchpad do-test .
{ 5.349853483873686e-317 }

The result should be { 33.0 } (cause 30+3=3). I think it reads from an uninitialized spill slot which causes the weird looking value. Maybe something with normal 64bit registers being 8 byte long and SSE registers being 16 bytes.

Hmm, sounds like a job for @slavapestov !

@bjourne did you ever look into this more?

Not yet! :+1:

Works now!


feat: add gap option to allow you to set the gap between items

Motivation
Virtual lists operate on an absolute positioning basis, meaning that traditional list styling like marginBottom or marginTop doesn't work as expected. These styles require manual adjustment for proper spacing between items. Therefore, by introducing the gap option, we provide a convenient way to easily set spacing within the list.
https://github.com/TanStack/virtual/assets/41789633/b86d5e72-00d8-497c-b405-72ae5649a98f

Yeah let's merge it, saw a request for this few times already. Thank you for your contribution!


CSHARP-678 Execution profiles at session level

This is rebased on top of #444 so whoever reviews this PR can see this smaller diff instead https://github.com/datastax/csharp-driver/compare/refactor-unittests..CSHARP-678. I will rebase the target branch after #444 is merged to master.

Rebased after #444 was merged

What do you think about something like:
Cluster.Builder()
    .AddContactPoint("<IP_ADDRESS>")
    .WithExecutionProfiles(x =>
    {
        x.WithProfile("default", y => y.WithConsistencyLevel(ConsistencyLevel.LocalQuorum));
        x.WithProfile("timeseries", y => y
            .WithConsistencyLevel(ConsistencyLevel.LocalOne)
            .WithRetryPolicy(new LoggingRetryPolicy()));
	})
	.Build();

What do you think about something like:
Cluster.Builder()
    .AddContactPoint("<IP_ADDRESS>")
    .WithExecutionProfiles(x =>
    {
        x.WithProfile("default", y => y.WithConsistencyLevel(ConsistencyLevel.LocalQuorum));
        x.WithProfile("timeseries", y => y
            .WithConsistencyLevel(ConsistencyLevel.LocalOne)
            .WithRetryPolicy(new LoggingRetryPolicy()));
    })
    .Build();

Yeah the IExecutionProfileOptions supports this way already but it also has a method that takes the already built IExecutionProfile instance. Do you think that we should just remove the method take receives an already built profile instance? Here is the xml docs that I've added recently to show both ways that the user can go for when adding execution profiles: https://github.com/datastax/csharp-driver/blob/CSHARP-678/src/Cassandra/Builder.cs#L693-L722

Do you think that we should just remove the method take receives an already built profile instance?
It's funny that we came to the same methods, sorry I didn't check it existed already.
I'm +1 on removing the other, I think having just 1 way of doing is better.

There is no "default" execution profile, like in node.js or python, is there a reason for it?
Discussed this offline, I will change the implementation to have a "default" profile which can be configured in the same way as the remaining profiles.

I think we should include a doc entry for this, something like: https://github.com/datastax/nodejs-driver/tree/master/doc/features/execution-profiles

Should we also add a way to retrieve the execution profiles from the Cluster?

I think we should include a doc entry for this, something like: https://github.com/datastax/nodejs-driver/tree/master/doc/features/execution-profiles

Yeah I'm planning to do that after all of this is merged to the feature branch (related to https://datastax-oss.atlassian.net/browse/CSHARP-762)

Should we also add a way to retrieve the execution profiles from the Cluster?

It would be nice to have a read only property to get the execution profiles along with their names.

Should we also add a way to retrieve the execution profiles from the Cluster?

It would be nice to have a read only property to get the execution profiles along with their names.

Added a read only dictionary property getter to Cluster that allows a user to retrieve the execution profiles.

There is no "default" execution profile, like in node.js or python, is there a reason for it?

Discussed this offline, I will change the implementation to have a "default" profile which can be configured in the same way as the remaining profiles.

Done
Also noticed that I forgot to add Prepare methods that receive an execeution profile parameter so I've added them now to Session.

When I saw that execution profiles for Prepare() method was being introduced, I thought it was going to be the "default profile" for the bound statements created from the prepared statement, but I see that the profile at Prepare() level affects how the prepare statement is executed.
I think we shouldn't expose many options on how an prepare request is executed, the user should only care about whether it's prepared or it failed and the rest should be defined by the driver (there are some settings like prepare on all nodes, and those are set cluster/session-wide).
Query preparation should take a few cycles on the server and can be blindly retried on the following node.

What made me go for this was seeing the load balancing policy being called. I'm concerned mostly about Mapper and LINQ where users don't actually do any calls to Prepare and they probably don't expect the default LoadBalancingPolicy being used in a Mapper / LINQ call if they specify a different one with an execution profile. Maybe we should make these methods internal and be used only in LINQ and Mapper?

Maybe we should make these methods internal and be used only in LINQ and Mapper?

I think we can live without it:

When "prepare on all nodes" is enabled (default), the driver should use all nodes that we actually have an open connection to, instead of a LBP, and prepare it (so all nodes that matter should already have prepared the query).
When disabled, the flow -> EXECUTE -> UNPREPARED -> (re) PREPARE -> EXECUTE will kick in (once per node that hasn't prepared the query)

Maybe we should make these methods internal and be used only in LINQ and Mapper?

I think we can live without it:
* When "prepare on all nodes" is enabled (default), the driver should use all nodes that we actually have an open connection to, instead of a LBP, and prepare it (so all nodes that matter should already have prepared the query).

* When disabled, the flow -> `EXECUTE` -> `UNPREPARED` -> (re) `PREPARE` -> `EXECUTE` will kick in (once per node that hasn't prepared the query)

I've pushed a draft implementation of this but haven't tested it yet. Lmk if this is what you were thinking of: https://github.com/datastax/csharp-driver/pull/442/commits/16dfe484dd5f069eb517fe47465048038e83f749

yes! that approach lgtm.

Pushed final changes to Session.Prepare API and PrepareHandler class. Also added some unit tests.


Figure out update hook differences

Chances are I'll want to go with Ember's update hook algorithm, but I should strongly consider when Stateman's might be preferable.

Stateman:
update is sandwiched between exit and enter.
Exit starts at the deepest route, and works its way up.
Update works in the same way.
Enter goes in the opposite direction.
I'm a visual person so I'ma write this out in symbolic form:

exit↑
update↑
enter↓

Ember
Described completely by their README:

The order of callbacks are:
exit in reverse order
enter starting from the first new handler
setup starting from the first handler whose context has changed


Add support for python 3.x and ITK 5

This PR is a work-in-progress, the following external module should be updated first:

[ ] https://github.com/blowekamp/itkStreamingSinc/issues/4

The functionality of the StreamingSinc module has been incorporated into ITKv5. Updating the code in this module to use the new ITKv5 classes will require Slicer being updated to the ITKv5 release.
Also some modules in this extension should simply be removed.

Thanks for the update.

Also some modules in this extension should simply be removed.

See https://github.com/blowekamp/Slicer-IASEM/issues/7


Wrong use of logging module

Root cause of: https://github.com/neuropoly/spinalcordtoolbox/issues/2993
API modules should not configure the root logger, instead they should simply define a module-scoped logger and use it:
logger = logging.getLogger(__name__)
logger.info("something...")

It is always the caller that should configure root logger based on its needs.
This gets the root logger instead of the module scope logger.
https://github.com/ivadomed/ivadomed/blob/3c9d32c41ef4222848f0dfb024e89c11f7264046/ivadomed/utils.py#L17
It should be logger = logging.getLogger(__name__)
This is used to configure the root logger, not the module scoped logger
https://github.com/ivadomed/ivadomed/blob/3c9d32c41ef4222848f0dfb024e89c11f7264046/ivadomed/utils.py#L18
logging.basicConfig configures the root logger. logger.setLevel() can be used to configure the module-scoped logger (assuming it is defined correctly)

Will make a PR to fix


Feature request: add the option to choose specific un-available dates

currently we can specify a range of un-available dates, if there will be an option to select dates with out the limitation of them being one after another it will be a grate help.
thanks in advance, keep up the good work

If I'm understanding correctly, it sounds like you need to set SelectionType to SelectionType.Single and SelectionAction to SelectionAction.Replace in the CalendarView. This will make the user only able to select a single date, and when this is done, the previous selection will be overwritten by it.

I will try  to clarify with an example :
assume we are talking about this month, I want to be able to the  22.5 , 27.5 and 29.5 to be un-available dates (i.e. not clickable and with different style to indicate the user they are no available)
currently I can not do it because they don't appear sequentially in the calendar( we can only select  DayRangeMinimumDate and DayRangeMaximumDate to be available instead)

This is currently possible if you inherit from CalendarDayView.
For example you could add an InvalidDates bindable property which you set to a collection in your ViewModel from CalendarView's DayTemplate property.
Then just override the 'IsDateTimeOutOfRange' method to return if DateTime is present in that collection.
It took me a while to remember that I gave CalendarDayView virtual methods exactly for purposes like these so I think the real issue is not having good documentation yet again.
Despite that, I do agree that there should be a way to do this without having to inherit from a control at the very least. I'll look into that. However if you're happy with the solution provided please close the issue.

In 4.0.0 you can inherit from Calendar in XCalendar.Core namespace and override the IsDateTimeInvalid function.
Or set the CalendarView's DayTemplate to a CalendarDayView and bind the IsInvalid property to something in your ViewModel.


accessTokenAcceptedVersion to 2 not working - Can't use third party domains as saml app

"If you do not update the accessTokenAcceptedVersion to 2 you will recieve an error message requiring a verified domain"
this isn't true, as if you use any thirs party url it will throw the error, regardless of whether this value is set.whatever has changed means that unless i build the saml app myself and host it on a domain i own, then it will not work.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 7f4e153e-0fe3-2f8f-58b9-0402e3d11951
Version Independent ID: 8f7af191-8ac1-ac6c-a733-0216075373ee
Content: Configure Azure Active Directory B2C as a SAML IdP to your applications
Content Source: articles/active-directory-b2c/saml-service-provider.md
Service: active-directory
Sub-service: b2c
GitHub Login: @kengaderdus
Microsoft Alias: kengaderdus

@doodlleus
Thanks for your feedback! We will investigate and update as appropriate.

If you set the accessTokenAcceptedVersion attribute to 2 and still get an error message, please check the supported account types of your application. You can find it in the app's manifest. It should be
"signInAudience": "AzureADMyOrg"

If it's not AzureADMyOrg please recreate your application. In the Register your SAML application in Azure AD B2C step, make sure to select Supported account types, select Accounts in this organizational directory only..

#please-close


#1337 isolation level fix for all values accept string

Hello,
Waiting for review.
Thanks.

Congrats @enesacikoglu

@enesacikoglu It looks like this change actually causes a regression.  Previous versions of HikariCP could accept an integer value, such as 4096, as the isolation level.  After this change, only strings of the form "TRANSACTION*" are supported, therefore existing users who were using integer values will now be broken.
It is my fault for not catching this in my review of the code.

@enesacikoglu It looks like this change actually causes a regression. Previous versions of HikariCP could accept an integer value, such as 4096, as the isolation level. After this change, only strings of the form "TRANSACTION*" are supported, therefore existing users who were using integer values will now be broken.
It is my fault for not catching this in my review of the code.

Hello @brettwooldridge ,
Actually, I was aware of doing this change because it seems to be not configured correctly. It must be the string instead of number because client can not understand which isolation level refers to that number.
I know , it is a kind of breaking change but I would not want to add a workaround solution inside code for only 4096.
If it is a fault, it is not only your fault.
Finally , we can document this change as a breaking change for the client before to build a new version. I hope it will work.
Thanks
Enes


static 10k buffer

Following up on #5
Had to set "strictPropertyInitialization" to false in tsconfig.json, otherwise typescript complained:
Property 'storage' has no initializer and is not definitely assigned in the constructor.

So the problem with this approach is that fdb-tuple is used for other things than just being called from foundationdb. Unless I’m mistaken, this approach will mean that subsequent calls to fdbtuple.pack() will invalidate previous calls.
I want the optimization, but I’d like a different approach to implement it which preserves the behaviour of the previous code if it’s used in a naive way. Maybe, we should expose a separate packSharedBuf method or something?
Thoughts?

Do you mean calling tuple.pack() twice will result in both resulted buffers being equal to second one? e.g.:
buf1 = tuple.pack(); buf2 = tuple.pack(); buf1===buf2;
If yes, it's avoided by .make() call inside .packRaw() which allocates new buffer, and copies data from shared into private.
const assert = require('assert/strict')
const a = fdb.tuple.pack(1)
const b = fdb.tuple.pack(1)
console.log(a==b, a===b) // false false
console.log(assert.deepEqual(a, b)) // ok

Every call to pack() returns new buffer. In this patch we remove one initial allocation of 64 bytes per call, that is mostly not enough, and subsequent "growth" allocations within each call up to 10,000 bytes.
By the way, .make() should technically use .allocUnsafe(), but I thought it'll be an improvement for later.
Hopefully I understood you correctly.

Thanks! Yeah, I just had a re-read of this code (I haven't touched it in a couple years). You're quite right. I've done a tweak to the PR to pull out the property to an explicit global (rather than a hidden global). That also lets us keep strictPropertyInitialization in typescript.
Thanks for the contribution. Welcome to github!


experimental newer builds fail on arm64v8 with platform incompatibility error msg

Build process seems to be wrong for docker hub on neo4j/neo4j-arm64-experimental

Steps to reproduce:

$ docker run \
    --publish=7474:7474 --publish=7687:7687 \
    --volume=$HOME/neo4j/data:/data \
    --volume=$HOME/neo4j/logs:/logs \
    neo4j/neo4j-arm64-experimental:4.1.6-arm64

The output of the docker version command

$ sudo docker version
Client: Docker Engine - Community
 Version:           20.10.3
 API version:       1.41
 Go version:        go1.13.15
 Git commit:        48d30b5
 Built:             Fri Jan 29 14:33:47 2021
 OS/Arch:           linux/arm64
 Context:           default
 Experimental:      true

Server: Docker Engine - Community
 Engine:
  Version:          20.10.3
  API version:      1.41 (minimum version 1.12)
  Go version:       go1.13.15
  Git commit:       46229ca
  Built:            Fri Jan 29 14:32:03 2021
  OS/Arch:          linux/arm64
  Experimental:     false
 containerd:
  Version:          1.4.3
  GitCommit:        269548fa27e0089a8b8278fc4fc781d7f65a939b
 runc:
  Version:          1.0.0-rc92
  GitCommit:        ff819c7e9184c13b7c2607fe6c30ae19403a7aff
 docker-init:
  Version:          0.19.0
  GitCommit:        de40ad0

Operating system: (for example Windows 95/Ubuntu 16.04)
Ubuntu 20.04.1 ARM64. 5.8.0-41-generic

Additionally, include (as appropriate) log-files, stacktraces, and other debug output.

WARNING: The requested image’s platform (linux/amd64) does not match the detected host platform (linux/arm64/v8) and no specific platform was requested

standard_init_linux.go:219: exec user process  caused: no such file or directory

oh yes that does seem to be very broken. Thanks for reporting it.
I found a bug in the Makefiles which was preventing ARM64 images from being built properly, and I've pushed a fix.
Re-releasing everything will be non-trivial to fix, but you could build your own ARM images by cloning this repository and doing:
NEO4JVERSION=4.1.6 make -f make-arm64.mk package-arm

(assuming you still want to build version 4.1.6 and not something more recent).

Thanks for the quick fix. Works, tested with neo4j/docker-neo4j@b2b7720 and NEO4JVERSION=4.2.3.


Disabling optional modules using Webpack is not working

Hi there, trying not to include the optional packages using 0.9.2, here is my resolve code:
resolve : {
    root       : paths.client(),
    extensions : ['', '.js', '.jsx', '.json'],
    alias: {
      './dist/cpexcel.js': '',
      './dist/jszip.js': ''
    }
  },

Unfortunately it does not have any impact, my build file size stays the exact same with or without of these in my config file.
Anything I'm missing?
Thanks!
P

We have a webpack demo in demos/webpack directory of the repo: https://github.com/SheetJS/js-xlsx/tree/master/demos/webpack  I copied that directory to a new location and installed a copy of xlsx from npm.
The main.js is very simple, the only purpose is to expose the XLSX variable:
var XLSX = require('xlsx');
console.log("it works!");
module.exports = XLSX;

The webpack config file is:
module.exports = {
	output: {
		libraryTarget: 'var',
		library: 'XLSX'
	},
	module: {
		noParse: [/jszip.js$/]
	},
	node: {
		fs: false,
		Buffer: false
	},
//	resolve: {
//		alias: { "./dist/cpexcel.js": "" }
//	}
}

And the command is:
$ webpack main.js --output-filename webpack.js --display-modules --profile

If I run with those 3 lines commented out (so the build includes the cpexcel library), the file is included:
     Asset    Size  Chunks                    Chunk Names
webpack.js  933 kB       0  [emitted]  [big]  main
   [1] ../~/xlsx/xlsx.js 454 kB {0} [built]
       [] -> factory:5ms building:399ms = 404ms
   [2] ../~/xlsx/dist/cpexcel.js 188 kB {0} [built]
       [] -> factory:3ms building:145ms = 148ms
   [3] ../~/xlsx/jszip.js 287 kB {0} [built]
       [] -> factory:3ms building:4ms = 7ms
   [5] ./main.js 77 bytes {0} [built]
        factory:21ms building:16ms = 37ms
    + 2 hidden modules

If I uncomment those 3 lines, webpack skips the file
webpack.js  745 kB       0  [emitted]  [big]  main
   [0] ../~/xlsx/xlsx.js 454 kB {0} [built]
       [] -> factory:5ms building:396ms dependencies:3ms = 404ms
   [2] ../~/xlsx/jszip.js 287 kB {0} [built]
       [] -> factory:4ms building:4ms = 8ms
   [4] ./main.js 77 bytes {0} [built]
        factory:21ms building:15ms = 36ms
    + 2 hidden modules

I am not that familiar with webpack, based on the file sizes there's a significant difference between the two.  If you can share a small example where this breaks down, I can take a look

This worked for me @SheetJSDev. Thanks for providing detailed sample. :1st_place_medal:

@petergombos I believe that the aforementioned fix resolves the issue.  Please reopen the issue if it doesn't work


Aj/2moment

This PR adds the 2-moment rain formation (autoconversion and accretion) options from CloudMicrophysics.jl v0.9

@charleskawczynski I'm getting a warning that:
┌ Warning: The parameter set SHOULD be isbits in order to be stack-allocated.
I'm guessing it's because one of my parameters is now a string. Could you give me a hint what to do about it?

@charleskawczynski I'm getting a warning that:
┌ Warning: The parameter set SHOULD be isbits in order to be stack-allocated.
I'm guessing it's because one of my parameters is now a string. Could you give me a hint what to do about it?

Yes, it looks like we should be able to avoid the string-- the string looks like it's basically being used for dispatch

I struggled a little with autoconversion arguments being a mix of keyword arguments and not. I managed by having the conv_args only return a named tuple and passing in the rest. As a result we still have the if/else between the 1-moment and 2-moment options.
I'm hoping thats ok for now. I'll soon be adding a proper 2-moment scheme to CM.jl Maybe at that point we can take a look and see what argument patterns would be best for dispatching.
@charleskawczynski - could you take another look?

bors r+


Logical definitions organelle transport

Hello,
The logical definitions for transport into/out of organelles are inconsistent:
we sometimes have
transport
and ('has target start location' some cytoplasm)
and ('has target end location' some nucleus)
and ('results in transport across' some 'nuclear envelope')
but sometimes the start location is cytosol.
I think cytosol is correct; isn't it ?
@dosumis @cmungall @ukemi @thomaspd

This came up while working on #14711

Yes, use cytosol here

Cytoplasm is broader.  Could cover starting point inside some other organelle.

thanks


fix(api): Don't infinite-loop when reserved volume is too high to make progress

Overview
WIP PR for fixing #6170. Reviews in the meantime are welcome.
So far, I've fixed the exact reproduction case in that bug. However:

Unit tests caught what I think are other bugs, which I think are unrelated.
Manual fiddling caught a different reproduction case for 6170, which I haven't fixed yet.

The current game plan is to:

Carpet-bomb the module with a highly parametrized unit test to see if there are any other cases hiding out.
In this PR, fix the bugs that cause the API to hang.
Leave the fixes for the other bugs for a different PR (with xfail'd unit tests in this PR).

Notes to self
The fixes for the infinite loops can probably go out without an API version bump. The fixes for the wrong behavior will need a version bump.

Changelog

Review requests

Risk assessment

https://github.com/Opentrons/opentrons/issues/7243 looks like it could be related.

https://github.com/Opentrons/opentrons/issues/7243 looks like it could be related.

Based on review comments and out-of-band conversations, this bug doesn't seem like a good thing to attempt to solve incrementally.
The backwards compatibility concerns that make this such a slog to work on are ticketed for research in #7477.
Meanwhile, I'll re-draft this PR, try to understand the variants of this bug that I had deferred investigating, and see if we can fix them all in one apiLevel-bumping chunk.

Based on review comments and out-of-band conversations, this bug doesn't seem like a good thing to attempt to solve incrementally.
The backwards compatibility concerns that make this such a slog to work on are ticketed for research in #7477.
Meanwhile, I'll re-draft this PR, try to understand the variants of this bug that I had deferred investigating, and see if we can fix them all in one apiLevel-bumping chunk.

I think that it would be good enough to dive potential other bug(s) and create tickets. The most important thing is to fix the infinite loop; either by raising an exception or doing nothing.

I'm dropping this, for now. A combination of things makes this bug deceptively difficult to solve correctly.
This particular area of code:

Has an enormous parameter surface area. (Think of all the possible ways of combining disposal_volume, air_gap, distribute vs. consolidate vs. transfer, Single-Channel vs. 8-Channel pipettes, transfer volume, pipette volume, and tip volume.)
Has never had parameter validation.
Generally only has test coverage of its happy paths.

So, there's currently a big space of uncharacterized, undefined behavior that you can accidentally fall into. #6170, the bug that kicked this off, originally reported an infinite loop—but depending on the exact test case, instead of that, you can get other confusing results, like a big transfer breaking down into a pick_up_tip with no liquid handling steps.
Fully characterizing this space of undefined behavior turns out to be a lot of work. The work so far in this PR only partially accomplishes it.
But, by my understanding of our Python Protocol API's versioning policy, we must characterize and preserve that behavior in fixing these bugs. Even though it was undocumented, and didn't make sense, and only happened in incorrectly written protocols.
In short, I can't be confident that, if I fix these bugs, I won't unintentionally change behavior in some place where I'm not specifically looking.

The more general versioning problem is ticketed for research as #7477. Depending on the outcome of that research, this could get a lot easier, and we could revisit it.
If/when we come back to this, I left #todo and #fixme comments in this branch to record the next steps.
And, anyway, we think we'll rewrite this code in Protocol Engine (the ongoing overhaul of our protocol-running back-end).


Adding 2 tests for RatingScreen

I added 2 tests that should cover the functionality of our RatingScreen component. Please review and let me know if there are any issues.

Looks good! It's ready to merge.

Thank you for your review. I'm merging this.


Two thermostat setup

Hey there :-)
saw the disclaimed limitations, and still installed the plugin. I have an ecobee 3, and an ecobee 4 with multiple sensors.
The switch actually still works - it just sets both thermostats into away mode, whereas I would love for it to be just the upstairs one. The end goal would be to create a simple 'when the last person leaves, set the upstairs thermostat to away' Homekit automation. I can't do that to the downstairs thermostat, as our dog would get extremely hot, ha ;-)
Would love it if you are open utilizing my use case to add a 'by device' type feature.

This should be supported now.


Researching filtering

We think that

If the Search team provide users with a range of filters, users will find what they are looking for within the collection more easily
Therefore we hypothesise that
By adding filters for

availability
subject/genre
license type
author

Users of the Wellcome Collection.org site will be able to locate their items of interest with more ease
As measured by

Number of participants correctly identifying the filter functionality in moderated tests
Number of website users entering works pages

We are right if

Users find more items that they are looking for

@taceybadgerbrook we need to chat about what metrics we want to gather and how we should do that to ensure that we are making effective change

Here is what I found when I looked at the data I collected on initial searches not derived from Google or other search engine activity:

I think there is enough evidence to support provision of date and image filters.

To evaluate the success of any filters that are introduced, either filter usage and viewing need to be tracked in Elasticsearch or we are stuck with using GA to monitor filter usage and attributing any increased views of works to the new filter. This is a big assumption.
The reason is because GA cannot trace a user journey. I can get GA to produce stats on total users who use a filter (providing this event is tagged appropriately) and total users who view a work by workId but I can't segment for users who use a filter and then produce stats on those who view a work.

I’ve been looking at GA Goal funnels to evaluate conversion rates for searches with filters.  GA seems to chop out the query bit of the URL for workType but not for dates.  Maybe it can only handle so many query elements in a typical URL? This might be at the heart of why Kibana started being used to evaluate search behaviour.
In addition, I can’t include downloading digital images in a goal funnel because users pass through the https://iiif/wellcomecollection.org which is a different domain from wellcomecollection.org.
@jtweed - Success for filter usage would mean filter users find what they need higher up in the page position and so have a lower median page depth. I will need Elasticsearch to pick up filter usage to conduct this analysis.

Thanks @taceybadgerbrook, I am keen that we measure the use of filters. In particular so we can use that to influence the ordering of filters on the page, as we might end up with quite a few. As you say, we should also see which ones influence the other click metrics the most too.
Let’s pick this up in planning, to make sure it gets considered as part of the work to add the filters.

Some thoughts on how the filters could affect the data:
People might start out thinking they only want items online for example but then change their mind depending on the results served and spend time trying out different combinations of availability and images/people/subjects/formats. This would result in increased numbers of searches and lower click through rate.
In addition, a user might decide that the combination of filters they used 5 minutes ago was the best but not remember exactly what that was.  They may search even more trying to find what that combination of filters was.
As a consequence removing the topic buttons, searches might decrease because users have to work harder. To check whether this is a risk at all, I could look at subsequent searches following topic button usage.

To test whether removal of the topic link buttons make users panic and leave, I analysed the percentage of exits to unique page views, combining data for both "wellcomecollection.org/works" and the new homepage,  "wellcomecollection.org/collections."
The graph below shows weekly percentages for the period 30/8/20 - 21/11/20

The topic buttons were removed 13/10, the week indicated by the red arrow. It does appear that increased percentages of users are exiting from the collection homepage following removal of the buttons.

Next steps:

to use Kibana to analyse the behaviour of users who filter
to use these observations as the basis for more research or changes in the way filters are presented

https://github.com/wellcomecollection/wellcomecollection.org/issues/5833


Add support for using Buzz\Browser instance (fixes #2)

This change allows instances of Buzz\Browser to be used in the adapater, which is what people generally use with Buzz. Also allow any instance implementing Buzz's ClientInterface to be used, such as the curl implementation.
Note that MultiCurl does not work at this time as it needs to be flushed to send requests.

As mentioned in #2, the tests fail when using Buzz's Curl instance because no request body is sent for GET, OPTIONS and TRACE requests. The tests explicitly send a request body rather use query string parameters in these cases, which isn't what you would do in practice.

Hm, since I haven't written the adapter tests I can't say for sure why we send a body for GET requests. @egeloen any ideas? Is this something that we should fix in the test suite?

This is the relevant section in the test suite btw: https://github.com/php-http/adapter-integration-tests/blob/master/src/HttpBaseTest.php#L188

thanks @lboynton , looks good!
GET requests are allowed to have a body. see for example elasticsearch...
so i think if the tests want to explicitly set a body, its fair to test that the body exists. is this what we talk about, or do the tests expect an empty body to be automatically present even when not doing anything? the later would sound like an implementation detail that should not be required by the tests.

Yes GET requests can have a body, but the Curl class in Buzz does not send a body for GET requests. So the current tests fail with the Curl class, but in practice the Curl class will probably work fine with the adapter as people don't generally use GET bodies. Perhaps this should be documented in the adapter.

okay, so that is essentially a bug of the buzz curl class. imo what we should do in the adapter is throw an exception when a body is set on a get request to tell the user this is not supported. if somebody wants to use elasticsearch for example, they will be glad to have an exception rather than nothing working as expected.
the tests are currently green, not sure why. but i think in that case it would be ok to make the acceptance test skip the test about GET body, or have an alternative test that ensures we get the exception when setting a body.
the test suite should also do GET requests without body, if it not already does.

OK I've added an exception which is thrown when trying to send a request body for GET, HEAD or TRACE requests when using the Curl client.
I've overridden the test methods to assert this behaviour. I'm not sure if this is the best approach or if I should modify the acceptance tests directly to be more flexible.

Awesome work. I think this looks really good! Thank you.

great work, i think this is exactly right. also the tests seem to me what they should be. i consider it a bug or at least unexpected restriction from buzz to not support bodies in GET requests, so we should not make the test suite encourage such behaviour ;-)
your test alterations are exactly at the right place.
apart from that question about custom HTTP methods with body, this looks good to merge.

I've squashed my commits, is there anything else that needs doing on this?

thanks a lot!

Thanks all! :tada:

Sorry that I kind of missed this PR. Quickly reviewed it and it looks good to me. Thank you @lboynton for your work.


Lesson about the Ability class and admin access.

Hydra uses cancancan to do authorization of many actions: https://github.com/CanCanCommunity/cancancan#1-define-abilities
Cancancan generates app/models/ability.rb into your application and then Hydra's generator and later Hyrax's generator each adds a couple of lines so that the class looks like this:
class Ability
  include Hydra::Ability

  include Hyrax::Ability
  self.ability_logic += [:everyone_can_create_curation_concerns]

  # Define any customized permissions here.
  def custom_permissions
    # Limits deleting objects to a the admin user
    #
    # if current_user.admin?
    #   can [:destroy], ActiveFedora::Base
    # end

    # Limits creating new objects to a specific group
    #
    # if user_groups.include? 'special_group'
    #   can [:create], ActiveFedora::Base
    # end
  end
end

You don't need to make any changes to this class as the included behavior provides all that you need to get started.   However, if you are integrating an group system other than the default (See Hydra::RoleMapper), then you may want to change who has the admin role.
You can do this by overriding the admin? method on the Ability class like this:
    def admin?
      user_groups.include? 'librarians'
    end

We have this page/section on access controls: https://github.com/projecthydra/projecthydra.github.io/blob/refactor_docs/pages/hydra/developer_resources/access-controls.md, so we can be sure this content is in it.
However there was discussion about refactoring cancan at LDCX, this seems like another possible topic for a potential refactoring doc section, too. Any thoughts? @jcoyne @jeremyf @atz

I sent forward to my team the following about CanCan:
https://schwad.github.io/ruby/cancan/saas/2017/04/06/oligarchical-saas-with-cancan.html
On Wed, Apr 12, 2017 at 10:43 AM, Jennifer Lindner<EMAIL_ADDRESS>
wrote:

We have this page/section on access controls: https://github.com/
projecthydra/projecthydra.github.io/blob/refactor_docs/
pages/hydra/developer_resources/access-controls.md, so we can be sure
this content is in it.
However there was discussion about refactoring cancan at LDCX, this seems
like another possible topic for a potential refactoring doc section, too.
Any thoughts? @jcoyne https://github.com/jcoyne @jeremyf
https://github.com/jeremyf @atz https://github.com/atz
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/projecthydra/projecthydra.github.io/issues/23#issuecomment-293599735,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAAIUh6THfsfGHwhZcWv_ii4-rSIsZUBks5rvOMAgaJpZM4M6gdA
.

--
Jeremy Friesen
takeonrules.com

Deployed.


Test Update base image PR notifier

Add workflow to notify new base image updates
Change event type in base image PR notifier

Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Closing this PR used for testing.


grpc service needs to mutate self

The generated code doesn't seem to work for my use case since the grpc methods are called with &self instead of &mut self. However, I suspect plenty of other services besides mine will want to mutate state. Am I missing something?
here's my project branch attempting to use this library:
https://github.com/katzenpost/multispool/tree/service_multi_spool.0

The service implementation object can be invoked from multiple threads (not in the default setup, but it is possible).
If you want to mutate data, you can guard the data with mutex:
struct MyServiceData {
    ...
}

struct MyServiceImpl {
    data: Mutex<MyServiceData>,
}

impl MyService for MyServiceImpl {
    fn call(&self, req: Req) -> Future<Resp> {
        let data = self.data.lock().unwrap();
        data.mutate()
    }
}


[2039] Select age range for new course

Context
New courses
Changes proposed in this pull request
Add "age range" selection for new course flow
Guidance to review
🚢
Note: Validation to be handled via the backend later

 Add "new" page for course age range


How to run a android apllication

Hi experts,
I tried to run the below commands:
wa run -f angrybirds

firstly, it compains 'CRITICAL <'s apk> could not be found'. Then I cp angrybirds.apk to /usr/local/lib/python2.7/dist-packages/wlauto/workloads/angrybirds. But it still compains:
CRITICAL <'s revent> could not be found
So I use the revent to generate a revent.bin, and copy the file to  /usr/local/lib/python2.7/dist-packages/wlauto/workloads/angrybirds. But it doesn't help.
Is that because of  I assigned the wrong file name for the revent file? If so, what's the right one?
Thank you!

Hi zhizhouzh,
Yes, revent files need to be named <device name>.(setup|run).revent; please see revent section documentation for details:
http://pythonhosted.org/wlauto/revent.html#using-revent-with-workloads
(Also, you can put these files under ~/.workload_automation/dependencies/angrybirds rather than copying them into /usr/local.)

After several other problems were solved, howerver, at last, I successed to run angry birds now.
Thank you very much!


"AttributeError: 'proxy' object has no attribute 'created'" after 0.2.2 update

After updating to 0.2.2, I'm getting the following Traceback:
Traceback (most recent call last):
  File "/.../python3.7/site-packages/django/core/handlers/exception.py", line 34, in inner
    response = get_response(request)
  File "/.../python3.7/site-packages/django/core/handlers/base.py", line 115, in _get_response
    response = self.process_exception_by_middleware(e, request)
  File ".../python3.7/site-packages/django/core/handlers/base.py", line 113, in _get_response
    response = wrapped_callback(request, *callback_args, **callback_kwargs)
  File ".../python3.7/site-packages/django/views/decorators/csrf.py", line 54, in wrapped_view
    return view_func(*args, **kwargs)
  File ".../python3.7/site-packages/graphql_jwt/decorators.py", line 136, in wrapped_view
    expires = refresh_token.created +\
AttributeError: '__proxy__' object has no attribute 'created

I've added JWT_REFRESH_EXPIRED_HANDLER to settings, but still same error.
Also, after adding the revoke_refresh_token recommendation, the token is getting revoked, as subsequent calls (after getting above Traceback error) will fail for Invalid refresh token ...
Reverting back to 0.2.1 works as expected.

Hi @douglasspeights, I am having the same issue after upgrading, had to downgrade as well, did you find a fix? Please let us know when you do, in the meantime, we just have to wait for @mongkok to respond.

I have the same issue

Thanks for reporting the bug @douglasspeights :)
I've created a new PR 135 to fix it.

Hi @mongkok. PR 135 didn't seem to fix the problem for me so I added another PR that addresses just the small bug that would make the jwt_cookie decorator function as expected PR 140

I'm sorry guys, I am just overloaded with work and I haven't been able to read it before.
The PR 135 is fixed and merged.
Thank you @coltonbh for the PR.

No worries, thanks for the fix!


Modal don't remove modal-open when use History.back()

Hi,
We try to use a Modal with a button which execute a History.back(). Seems that this action prevent Model to hide properly because "modal-open" style is not removed on the body, even if I add a myModal.hide() on my handler just before the back.
Let me know if you need more details or code.
Thanks,

@maveilletechno, could you provide more details? I can't seem to replicate this.
I created a modal, added a button and in the button's ClickHandler:
modal.hide();
History.back();

After clicking the button everything behaves as it should - the modal is getting hidden (or completely removed from DOM if removeOnHide="true"), the <body> element has the modal-open style removed and history goes back one item.

I will keep this open for a few more days, if no response then I will close it. Thanks for investigating this @klimeryk

Hi guys, sorry I had this issue during a mission for a customer and this mission is over. I don't have access to source code now. I'll try to reproduce on another project but no time today.

Might pull this out of the 0.9 release then, until we can narrow this down more.

IMO this can be closed.

Agreed.


[Event Request] Table 290 "VAT Amount Line" - OnInsertLine

Hi, would it be possible to modify the OnInsertLine event in table 290 (VAT Amount Line) by adding the Result parameter (with var keyword), like this:
    procedure InsertLine(): Boolean
    var
        VATAmountLine: Record "VAT Amount Line";
        IsHandled: Boolean;
        Result: Boolean;
    begin
        IsHandled := false;
        // Modified Event begin
        // OnInsertLine(Rec, IsHandled);
        // if IsHandled then
        //    exit(true);
        OnInsertLine(Rec, IsHandled, Result);
        if IsHandled then
           exit(Result);
        // Modified Event end

        if not (("VAT Base" <> 0) or ("Amount Including VAT" <> 0)) then
            exit(false);

        Validate(Positive, "Line Amount" >= 0);
        OnInsertLineOnAfterValidatePositive(Rec);
        VATAmountLine := Rec;
        if Find then begin
            "Line Amount" += VATAmountLine."Line Amount";
            "Inv. Disc. Base Amount" += VATAmountLine."Inv. Disc. Base Amount";
            "Invoice Discount Amount" += VATAmountLine."Invoice Discount Amount";
            Quantity += VATAmountLine.Quantity;
            "VAT Base" += VATAmountLine."VAT Base";
            "Amount Including VAT" += VATAmountLine."Amount Including VAT";
            "VAT Difference" += VATAmountLine."VAT Difference";
            "Pmt. Discount Amount" += VATAmountLine."Pmt. Discount Amount";
            "VAT Amount" := "Amount Including VAT" - "VAT Base";
            "Calculated VAT Amount" += VATAmountLine."Calculated VAT Amount";
            "VAT Base (Lowered)" += VATAmountLine."VAT Base (Lowered)";
            OnInsertLineOnBeforeModify(Rec, VATAmountLine);
            Modify;
        end else begin
            "VAT Amount" := "Amount Including VAT" - "VAT Base";
            OnInsertLineOnBeforeInsert(Rec, VATAmountLine);
            Insert;
        end;

        exit(true);
    end;

    [IntegrationEvent(false, false)]
    local procedure OnInsertLine(var VATAmountLine: Record "VAT Amount Line"; var IsHandled: Boolean; var Result: Boolean)
    begin
    end;

#14863
Thanks!

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. Please do not reply to this, as we do not monitor closed issues. If you have follow-up questions or requests, please create a new issue where you reference this one.


docs: Text within Benchmark results page isn't visible properly

Issue
Page: https://dicedb.io/benchmarks/ (Results Observed sections in Redis and DiceDB Benchmarks)

Fix
I tried a small change in main.css and the results much cleaner. Happy to contribute in case this looks fine.
pre {
  background-color: hsl(0, 0%, 96%) !important;
}

Are you using some dark mode extension? It is perfectly visible to me

Nope, I'm not using any dark mode extensions. I'm using latest versions of Chrome (Version 131.0.6778.140 (Official Build) (arm64)) and Safari, and able to reproduce it consistently, including on mobile (iOS).

Works fine for me too. Maybe some extension conflicts with your browser @checkaayush
Try once in incongnito

Same behaviour for me in incognito tab as well. Tried in another browser with no extensions as well (Safari) and have the same issue.

quite strange, let's wait till someone else also face this?


ColorSpectrum Saturation and Value arrow key navigation inverted

Describe the bug
A ColorSpectrum with ValueSaturation or SaturationValue has inverted left right navigation. This will be closed with a PR shortly.
Steps to reproduce the bug
Steps to reproduce the behavior:

Set components of ColorSpectrum to ValueSaturation or SaturationValue
Press left arrow key, observe that the indicator moves to the right
Press right arrow key, observe that the indicator moves to the left

Expected behavior
Left is left, right is right.
Version Info
Commit:
f4c811b

This is the same as #3234, what was it created? Should instead this be the issue for RightToLeft?

Oh I thought #3234 was with regard to RightToLeft. I'll update this issue. Thanks for pointing that out!


Write migration guide & manually test migration for FF v1.1->v1.2

Pls include the following Discord-thread with your tests, thx:
https://discord.com/channels/905194001349627914/928377875827154984/threads/1062145402834526228

Hi @Rabax55, sorry it doesn't look like that link is working anymore. Do you mind posting here which tests you were hoping to have run? Thanks!

It's with the FF-Upgrade, and on Besu-Networks only:
From the Discord-Thread:
"...just upgraded my FF-Version from 1.1.1 to 1.1.2:
jms@LAP-10:~$ ff upgrade proc_10
jms@LAP-10:~$ upgrading stack  'proc_10'... done
Your stack has been upgraded.
After starting the upgraded stack, the stacks core-nodes fail to start. The Docker-Image logs state:
2023-01-09 23:51:01 FF10412: Bad network version: %!!(MISSING)s() "
Easy to reproduce (w/ versions 1.1.1 and 1.1.2 (a real upgrade), or just use a freshly created Besu-stack/Version 1.1.2 (nothing to upgrade). From the Discord-Thread:
"-> The problem is with 1. the upgrade and 2. on besu networks only
-> It occurs on all versions 1.1.1 and 1.1.2
-> It occurs even if there is nothing to upgrade
-> Easy to reproduce: fire up any Besu-stack (with whatever version), directly start the upgrade-cmd, wait some seconds, check the result..."
Regards, Joerg

Thanks for the details! That should be tracked as a separate issue/bug on https://github.com/hyperledger/firefly-cli itself. This issue is for testing that FireFly itself can upgrade cleanly from one version to the next, regardless of automation with the CLI.


Re-adding streams that errored out

My yta runs with --retry-stream option, for reasons, and occasionally there is a period where the cally to YT made by yta will encounter some error. This temporary issue causes yta to close and hoshinova to list those streams as error on the web interface. I believe there are similar temporary issues with different unknown yta output that can also occur.
Once more advanced yta output handling is implemented, I'd love an option to have hoshinova re-add a queued job that errored out.  Here is the scenario I encountered.
I am monitoring a channel to capture all its live steams (filter on a specific keyword).
When the channel announces its live earlier, it is detected on the rss feed and tries to capture it - which fails and mark it as errored.
It never retries it ever again and I end up missing the record altogether...
Since I am only using Hoshinova as a monitoring tool, this defeats the purpose with channels announcing their streams earlier 😥
2 solutions to handle that would be to:

Detect and prevent streams from RSS that have not started yet (thus ensuring never starting the capture before it becomes available) - but this solution would not resolve the issue this topic mentions.
Allow to set up a retry mechanism on errored entries?


Make development versions more visible (again)

There have been many important new features (ubershaders for example) and many bug fixes since 5.0. Also, users on the forums keep reporting issues that could have been avoided just by using a newer version (notably Wii Remotes and System Menu stuff).

Yes please!


sds part 1-7 add links to prereq and next

link tutorials using url links

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


tag and slide class don't play nice

Adding class="slide" breaks the shadow on
 in every browser I've tried. I'm looking through the CSS to try and figure something out. No luck!

Just to be clear, this is using pre as a nested slide and specifically the Web 2.0 theme, correct?

Right, so the markup looks like

[...]
   [...]

And I believe it is the web 2.0 theme. Same as the introduction starts out with.

Thanks, will look into it.

https://github.com/imakewebthings/deck.js/commit/af024461bb7794eb000c674b1a65a124acf9af77 does what it can to fix this.  Give the source on master a try, but here's the deal:
The shadow techniques I'm using are basically straight from http://nicolasgallagher.com/css-drop-shadows-without-images/demo/, which uses box-shadows on pseudoelements.  There are a number of bugs in modern browsers concerning CSS transforms and pseudoelements, so during any transitions that use them (horizontal and vertical slide) you will still see the shadow on top of the element.  The change I checked in should at least let the shadows display correctly when the slide is still.
I'm going to wait for the browser vendors to catch up and fix the bugs in this case, and recommend a small workaround in the meantime:

...

As long as the element with the pseudoshadows is not the root element of the transform, it works fine.

After further investigation and spec reading, this isn't a bug with browser vendors.  CSS Transformed elements automatically create a new stacking context, just like setting a z-index, and this cannot be undone.  Since our pre in this case is the root of a stacking context, there's no way to make the pseudo render behind it.  Again, using a wrapper is a viable workaround, but I'll probably just change the Web2.0 theme to use some other shadows instead of these fancy pseudo-based ones.

I haven't been paying attention.  Nicolas Gallagher's technique I'm using has a fix for this in place in his last example.  Updating my theme and pushing it now.


Fix/ Editor-in-Chief Console: link to new forum page

Add option to EiC console to make all forum links go to new forum page.
Related to https://github.com/openreview/openreview-web/pull/899

Is this PR still valid?

does it mean the EICs will see the new forum page first? instead of having the option to switch using the banner?

Yes, this option changes the forum link in the tables to /forum-new. If you'd rather they continue being directed to the old forum we don't have to add the option on live.

I would like to give them the option to choose if they want to go to the new forum. There are links to the forum everywhere and it can be confusing that one of the links go to the new one and the others don't.

OK, then I guess I'll close this PR for now.


[incubator/vault] Adding extraParameter field to accommodate adding extra parameters to…

What this PR does / why we need it:
There is a lack for a parameter that is
Which issue this PR fixes
(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)

fixes #12751

Special notes for your reviewer:
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

[x] DCO signed
[x] Chart Version bumped
[x] Variables are documented in the README.md

/ok-to-test

@Artemu What parameters are you trying to add and use? What is your use case?


Incompatible with Angular2 rc.6

When using Angular2 Release Candidate 6, I'm not able to load my app, when including Polymer Components via angular2-polymer, because of the following error:
17:37:59.764 TypeError: core_1.provide is not a function
PolymerElement()main.bundle.js:71861
AppModule<()main.bundle.js:58569
<anonymous>main.bundle.js:58556
__webpack_require__()inline.js:53
<anonymous>main.bundle.js:58955
__webpack_require__()inline.js:53
<anonymous>main.bundle.js:34322
Zone</ZoneDelegate</ZoneDelegate.prototype.invokeTask()polyfills.bundle.js:3277
Zone</Zone</Zone.prototype.runTask()polyfills.bundle.js:3177
ZoneTask/this.invoke()polyfills.bundle.js:3344
t/</<()localhost:4200:25
Zone</ZoneDelegate</ZoneDelegate.prototype.invokeTask()polyfills.bundle.js:3277
Zone</Zone</Zone.prototype.runTask()polyfills.bundle.js:3177
ZoneTask/this.invoke()polyfills.bundle.js:3344
1main.bundle.js:71861:13

Probably because of this change in the Angular2 API.
This is the code, where the Error comes from:
import {NgModule, CUSTOM_ELEMENTS_SCHEMA}      from '@angular/core';
import { BrowserModule } from '@angular/platform-browser';
import { AppComponent }  from './app.component';
import { MainComponent } from "./main/main.component";
import {PolymerElement} from "@vaadin/angular2-polymer";
import {routing} from "./app.routing";
import {ConfigFileApiConfigurationService} from "./shared/configuration/config-file-api-configuration.service";
import {API_CONFIGURATION_TOKEN} from "./shared/configuration/api-configuration";
import {HttpModule} from "@angular/http";

@NgModule({
  imports: [
    BrowserModule,
    routing,
    HttpModule
  ],
  declarations: [
    AppComponent,
    MainComponent,
    PolymerElement('paper-scroll-header-panel')
  ],
  providers: [
    {provide: API_CONFIGURATION_TOKEN, useClass: ConfigFileApiConfigurationService}
  ],
  schemas: [ CUSTOM_ELEMENTS_SCHEMA ],
  bootstrap:    [ AppComponent ]
})
export class AppModule { }

Same issue with RC6

This work for me. I think ^.^
clone the project change and compile.
`
import {Provider...} from '@angular/core';
import { NgControl as OldNgControl, NG_VALUE_ACCESSOR as OLD_NG_VALUE_ACCESSOR,
FormControlName, NG_VALUE_ACCESSOR } from '@angular/forms';
providers: [{
provide: OLD_NG_VALUE_ACCESSOR,
useExisting: forwardRef(() => formElementDirective),
multi: true
},{
provide : NG_VALUE_ACCESSOR,
useExisting: forwardRef(() => formElementDirective),
multi: true
}
],
`
or change polymer-element.js
https://www.dropbox.com/s/l8j2kpdo9holfdf/polymer-element.js?dl=0
https://www.dropbox.com/s/dp0oqer2w8jhycb/polymer-element.ts?dl=0

Hi @niveo, we can't reach dropbox links :(, can use plunker instead?
I've tried a similar approach but something went wrong when extends BrowserDomAdapter, receiving errors on browser console below:
unexpected token export [...]

p.s.: which command launch to compile it?

clone https://github.com/vaadin/angular2-polymer.git
**change package.json
//DEP
"@angular/common": "^2.0.0-rc.6",
"@angular/core": "^2.0.0-rc.6",
"@angular/forms": "^2.0.0-rc.6",
"@angular/platform-browser": "^2.0.0-rc.6"
//DEV
"@angular/compiler": "^2.0.0-rc.6",
"@angular/platform-browser-dynamic": "^2.0.0-rc.6"**

NOW
npm install
REMOVE
import { NgControl as OldNgControl, NG_VALUE_ACCESSOR as OLD_NG_VALUE_ACCESSOR } from '@angular/common';
ADD
import { NgControl as OldNgControl, NG_VALUE_ACCESSOR as OLD_NG_VALUE_ACCESSOR,
FormControlName, NG_VALUE_ACCESSOR } from '@angular/forms';
CHANGE
providers: [{
provide: OLD_NG_VALUE_ACCESSOR,
useExisting: forwardRef(() => formElementDirective),
multi: true
},{
provide : NG_VALUE_ACCESSOR,
useExisting: forwardRef(() => formElementDirective),
multi: true
}
]
REMOVE FILE
polymer-element.spec.ts
npm run prepublish
REPLACE FILE FOR YOUR PROJECT "node_module/@vaadin/angular2-polymer/src/"
polymer-element.js
COPY AND PAST IN YOUR BROWSER
https://www.dropbox.com/s/l8j2kpdo9holfdf/polymer-element.js?dl=0
https://www.dropbox.com/s/dp0oqer2w8jhycb/polymer-element.ts?dl=0
//https://github.com/vaadin/angular2-polymer
SAMPLE CRAZY
//https://github.com/niveo/-vaadin-polymer-element

I did same steps but nothing changed :(.
Now I've branched my project and downgrade the master on RC5. Maybe the issue is also linked on my platform (Meteor) and its angular2-compilers package.
Anyway, thanks @niveo for all :D.

Hello! Thanks for filing this issue and sharing the information.
We’re working on the solution, see PR #80. The pull request is currently under a team review, but your feedback would be also helpful. Please try the upgrade branch and say if it works for you.

angular2-polymer-upgrade-angular-v2.0.0-rc.6
it's works, thanks.

@platosha it's works, thanks.
My issue was on using  [...] extends BrowserDomAdapter instead [...] extends __platform_browser_private__.BrowserDomAdapter :D.
Have you plan an official release date?


Feature Request: Keybinds for the 4 Hotbar slots

I would like to include this eventually, but I'll have to see how obsolete this mod is made next update when they add official keybinds
Might just end up deprecating this mod unless there's major missing features from official support


In some cases, Producer has an uneven sending flow

There are two topics, T1 {Q0, Q1} and T2 {Q0, Q1}
The following timings exist

Counter = 0
Send T1, 0% Queue Sizeof T1 = 0, send to T1-Q0
Counter = 1
Send T2, 1% Queue Sizeof T2 = 1, send to T2-Q0
Counter = 2
Send T1, 2% Queue Sizeof T1 = 0, still send to T1-Q0
Counter = 3
Send T2, 3% Queue Sizeof T2 = 1, still send to T2-Q0
...

It can be seen that in step 6, for T1, two consecutive transmissions are sent to Q0,
In the same way, in step 8, for T2, two consecutive transmissions are sent to Q0, and the transmission flow is not balanced
The counter is global. For Topic T1, when counter% T1's Queue number = T1 send step size, there will be a problem of unbalanced flow

Good issue, just fix it


how to build ?

Is there a way to build with a live reload ?
Maybe add a coverage :)

how to build it?
nothing make the build create JS files + all failed in the compilation.


Disconnect/Reconnect of RTM.ManageConnection() leaves RTM unsuable

Version: 0.4.0
If the bot looses internet connection for a few minutes, then reconnects, the RTM incoming/outgoing events no longer work.
Steps to reproduce:

Start the bot.
After the ConnectedEvent is reached.
Message the bot, observe the log for MessageEvent gets triggered.
Disable the system's internet access.
Wait for bot to reach DisconnectedEvent (seems to get triggered twice, different bug?).
Enable the system's internet access.
The bot reconnects to the internet and ConnectedEvent is reached.
Wait a minute (If tested right away, message the bot, observer the log for MessageEvent gets triggered (timeout not reached yet?))
Message the bot

Expected: MessageEvent is triggered, with LatencyReport logged periodically.
Actual: MessageEvent is not triggered, no LatencyReports logged. RTM.SendMessage no longer works.
Code tested with:
func (b *Bot) runSlackLoop() {
   log.Println("Slack RTM connection handler starting up")
   go b.rtm.ManageConnection()

   for event := range b.rtm.IncomingEvents {
	switch data := event.Data.(type) {
            case *slack.ConnectedEvent:
		log.Printf("[DEBUG] Connection counter: %d", event.ConnectionCount)

	case *slack.MessageEvent:
		log.Printf("[DEBUG] Message received: %v", event)
		go b.handleMessage(data)

	case *slack.LatencyReport:
		log.Printf("[DEBUG] Latency: %v\n", event.Value)

	case *slack.RTMError:
		log.Printf("[ERROR] RTMError: %s", event.Error())

	case *slack.ConnectionErrorEvent:
		log.Printf("[ERROR] ConnectionError: %s", event)

	case *slack.DisconnectedEvent:
		log.Printf("[WARN] Disconnected: (intentional? %v)", event.Intentional)

	case *slack.InvalidAuthEvent:
		log.Println("[ERROR] Invalid credentials")
	}
   }
}

Can you post the output from sending a SIGABRT to the program while it's in this state? I'm running into a similar issue, and based on that stack trace I think I've narrowed it down to a deadlock introduced by https://github.com/nlopes/slack/pull/354. The DisconnectEvent that gets triggered twice is in fact the same bug as this one, and I think the reason becomes clear as to why as we dig in.
Specifically, these two goroutines are of interest:
goroutine 22 [chan receive, 52 minutes]:
github.com/nolanlum/tanya/vendor/github.com/nlopes/slack.timerReset(0xc4200746e0, 0x1bf08eb000)
        /home/travis/gopath/src/github.com/nolanlum/tanya/vendor/github.com/nlopes/slack/misc.go:237 +0x70
github.com/nolanlum/tanya/vendor/github.com/nlopes/slack.(*RTM).resetDeadman(0xc4200b49a0)
        /home/travis/gopath/src/github.com/nolanlum/tanya/vendor/github.com/nlopes/slack/websocket.go:113 +0x3c
github.com/nolanlum/tanya/vendor/github.com/nlopes/slack.(*RTM).handlePong(0xc4200b49a0, 0xc42001f680, 0x37, 0x40)
        /home/travis/gopath/src/github.com/nolanlum/tanya/vendor/github.com/nlopes/slack/websocket_managed_conn.go:405 +0x5a
github.com/nolanlum/tanya/vendor/github.com/nlopes/slack.(*RTM).handleRawEvent(0xc4200b49a0, 0xc42001f680, 0x37, 0x40, 0xc4203d2040, 0x5)
        /home/travis/gopath/src/github.com/nolanlum/tanya/vendor/github.com/nlopes/slack/websocket_managed_conn.go:361 +0x174
github.com/nolanlum/tanya/vendor/github.com/nlopes/slack.(*RTM).handleEvents(0xc4200b49a0, 0xc4201b0de0)
        /home/travis/gopath/src/github.com/nolanlum/tanya/vendor/github.com/nlopes/slack/websocket_managed_conn.go:230 +0x2d3
github.com/nolanlum/tanya/vendor/github.com/nlopes/slack.(*RTM).ManageConnection(0xc4200b49a0)
        /home/travis/gopath/src/github.com/nolanlum/tanya/vendor/github.com/nlopes/slack/websocket_managed_conn.go:64 +0x290

goroutine 1328 [chan send, 52 minutes]:
github.com/nolanlum/tanya/vendor/github.com/nlopes/slack.(*RTM).receiveIncomingEvent(0xc4200b49a0, 0xc4201b0de0, 0x0)
        /home/travis/gopath/src/github.com/nolanlum/tanya/vendor/github.com/nlopes/slack/websocket_managed_conn.go:339 +0x24f
github.com/nolanlum/tanya/vendor/github.com/nlopes/slack.(*RTM).handleIncomingEvents(0xc4200b49a0, 0xc4201b0de0)
        /home/travis/gopath/src/github.com/nolanlum/tanya/vendor/github.com/nlopes/slack/websocket_managed_conn.go:252 +0x4b
created by github.com/nolanlum/tanya/vendor/github.com/nlopes/slack.(*RTM).ManageConnection
        /home/travis/gopath/src/github.com/nolanlum/tanya/vendor/github.com/nlopes/slack/websocket_managed_conn.go:61 +0x275

The first goroutine is blocked on a channel receive from a time.Timer that will never return, because the event was already consumed here https://github.com/nlopes/slack/blob/v0.4.0/websocket_managed_conn.go#L208-L211, which is the cause of the second disconnect event you see. Besides the immediate issue of a deadlocked goroutine, the second problem is that the first goroutine is responsible from reading from the channel that the second goroutine is waiting to sent to (i.e. the incoming events from Slack channel). This is wh that I believe to be the root cause of the hang as observed in this issue.
I've not enough time to come up with a solution to the issue, but hopefully this sheds a little light on what's going on here. cc: @james-lawrence

@nolanlum @asadana if either of you would confirm the fix from the #456 I'll merge it.


Regenerate Vision client

This PR was generated using Autosynth. :rainbow:
Here's the log from Synthtool:
synthtool > Executing /tmpfs/src/git/autosynth/working_repo/synth.py.
synthtool > Cloning https://github.com/googleapis/elixir-google-api.git.
synthtool > Running: docker run --rm -v/home/kbuilder/.cache/synthtool/elixir-google-api:/workspace -v/var/run/docker.sock:/var/run/docker.sock -w /workspace gcr.io/cloud-devrel-public-resources/elixir16 scripts/generate_client.sh Vision
Error in atexit._run_exitfuncs:
Traceback (most recent call last):
  File "/tmpfs/src/git/autosynth/env/lib/python3.6/site-packages/synthtool/metadata.py", line 63, in write
    with open(outfile, "w") as fh:
FileNotFoundError: [Errno 2] No such file or directory: 'clients/Vision/synth.metadata'

Closing for regeneration


Fix Tileset::ComputeLoadProgress incorrectly reporting done, when main thread loading exists

Fixes performance tests reporting completion times that are a little too early (1 second in some warm cache tests).
Could also fix any bugs in user applications where they use ::computeLoadProgress to determine loading completion.
Ex. waiting for loading before taking a screenshot, some parts of the screenshot might not have loaded to final detail
This fixes a bug in the mentioned function, where this->_workerThreadLoadQueue.size() is being used to calculate tile completion, but it's always 0, because it is cleared at the end of every ::update_view. The fix is to use the saved value in _updateResult.
Discovered while working on PR #779.
Also relates to PR #733, which has a similar fix. I wouldn't be surprised if this was the original cause, but that PR just happened to fix it too. Regardless, the older PR is still valuable. Counting "tiles kicked" as current progress sounds reasonable.

Thanks @csciguy8 !


Data loading very slow

Hello, yuiseki-san!
First of all I would like to appreciate you very much for creating this editor, it gives the mapper a view of what work has been done and it gives a sense of achievement when the avatar is displayed on the map.
However, I would like to ask you to speed the access of the site, it is difficult to load specific roads outside of Japan and it is difficult to know where visitors are trying to view. The buildings take a long time to load and sometimes only a few buildings are visible and only the progress circle is spinning all the time.
If you think this issue bothers you, or have no plans to fix it, you can simply close it without any explanation.
Again, I apologise for taking your time and making you read these complaints!

您好，yuiseki桑
首先我应当对您所创造的这个编辑器非常感谢，它令绘图者可以更清晰的认识到做出了哪些工作，并且当头像显示在地图上的时候将更具有成就感。
但我希望向您请求改进网站的访问速度，在日本以外的地方都很难加载出来具体的道路，很难知道所查看的试图位于何处。且建筑的加载时间很长，有时只能看到很少的几座建筑，只有进度条在旋转。
如果您觉得这份issue会令您感到困扰，或者没有计划修复它，您可以直接关闭掉它而不做任何解释。
再次为耗费您时间，让您阅读这些抱怨感到抱歉！

Thank you so much for report the Issue!
I have been developing this project alone, so it would be great to hear from you.
I think you are right that data loading was very slow,
because until yesterday this project was incomplete,
It was at the prototype level.
Today, I have made some improvements about data loading.
Take measures to avoid loading data too frequently,
and the amount of data to be loaded is now adjusted according to the zoom level of the map.
I hope this has improved things a bit.
It seems to be another problem with the map loading.
I am currently using map data provided free of charge by a Japanese company in this project.
Therefore, there may be some problem accessing from outside of Japan or displaying maps outside of Japan.
I hope this project will be interested and useful for OpenStreetMap mappers around the world,
and I would very much want to improve it so that people in any country can use it comfortably.
So I will investigate and take action with the map loading.
And I am sorry, but you may face another problem if you actually try to use this project for edit address.
The data structure of addresses in OpenStreetMap has no clear rules and quite different from country to country,
and this project only supports Japan yet.
I'm trying to figure out what I can do about this issue as well.
Until support another country can be made,
I would like you to go to the OpenStreetMap website and edit the building address.
Thanks for contacting me with interest in this project!

It seems to be another problem with the map loading.
I am currently using map data provided free of charge by a Japanese company in this project.
Therefore, there may be some problem accessing from outside of Japan or displaying maps outside of Japan.

I noticed this, and found attribuation of geoloniamaps in the right bottom of screen.
Maybe you can try mapbox? They offer some free quota for personal developer.

And I am sorry, but you may face another problem if you actually try to use this project for edit address.
The data structure of addresses in OpenStreetMap has no clear rules and quite different from country to country,
and this project only supports Japan yet.

I also feel sorry for this……because I'm not a frontend developer. If those pattern can stored in some makeup language, it will allow mapper from other country write their own pattern.
(It is another kind of l10n, so I'm afraid this requeset will bring a havey burden to you)

Hi LaoshuBaby-san!
Thank you for kind reply.
I've figure out that vector tile map I've used does not support detailed zoom level outside of Japan.
So I decide to change the base map of this project to the OpenStreetMap official raster tile server.
Now this project is available to the whole world!
...At least as far as browsing who are last editor of building.
Also I've made more improvement about data loading.
If the zoom level is less than 16, maps does not load any data and just displays an icon asking for further zooming.
I will continue to look into the editing of the address in other country.
I've put that on a separate Issue #2
Thank you for your concern.
I am on a mission with this project.
The more difficult the problem, the more motivated I am, and that's okay.
This issue is closed as resolved.
If you still have problems, please Reopen.
Once again, thanks so much for bringing to my attention that this map wasn't working outside of Japan!
P.S.
I could find you near Beijing station using this map...!
I have great respect for OpenStreetMap mappers.
I am honored to have been so kindly contacted by one of the mapper I so respect.
https://yuiseki.github.io/osm-address-editor-vite/#17.44/39.904563/116.419165


FM Radio

When I want to add a shortcut key to turn on FM Radio, this option does not exist in the menu. And when I try on chirp, it has the option, but then the radio doesn't recognize it. Am I doing something wrong or is it a bug?
Best regards.

Hello,
Simple. You're probably using Banscope version. This version does not include FM braodcast.
Armel F4HWN.

Before seeing your answer I already realized the error. Anyway, thanks for your quickness in helping.
Best regards.


add web search

Description
Search web for information.
When agent ask a question, google search can provide a list of urls which relative with the question, then using requests to get
each url and extract text. Split the text to small chunks and feed to chatgpt to get answer.
Notice: these functions require google api key you can find here https://developers.google.com/custom-search/v1/overview,
and search engine id you can find here https://cse.google.com/cse/all.
So, can anyone add these two key into the github actions, my pr need them to pass the test, thanks!
They look like this:
GOOGLE_API_KEY = os.getenv("GOOGLE_API_KEY")
SEARCH_ENGINE_ID = os.getenv("SEARCH_ENGINE_ID")

Motivation and Context
Why is this change required? What problem does it solve?
Give the agent ability to search internet.

[ ] I have raised an issue to propose this change (required for new features and bug fixes)

Types of changes
What types of changes does your code introduce? Put an x in all the boxes that apply:

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds core functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] Documentation (update in the documentation)
[ ] Example (update in the folder of example)

Implemented Tasks

[ ] Subtask 1
[ ] Subtask 2
[ ] Subtask 3

Checklist
Go over all the following points, and put an x in all the boxes that apply.
If you are unsure about any of these, don't hesitate to ask. We are here to help!

[x] I have read the CONTRIBUTION guide. (required)
[ ] My change requires a change to the documentation.
[x] I have updated the tests accordingly. (required for a bug fix or a new feature)
[ ] I have updated the documentation accordingly.

I think this pr is awesome! Any reason why you close this?

I have just noticed this new PR but before reviewing I think it would be better for you to do local cheks first before committing and pushing. It sends quite a lot of emails into my inboxes... And may I ask why you close this?

I think this pr is awesome! Any reason why you close this?

This pr is submmit from my fork, it can't use sercet api key, so I opened another pr #274 from a branch.

I have just noticed this new PR but before reviewing I think it would be better for you to do local cheks first before committing and pushing. It sends quite a lot of emails into my inboxes... And may I ask why you close this?

sorry about that, i met a wierd error. Everything goes well in my laptap, but get wrong in github, it said i give a 'function' type, but expect 'Callable' type, i dont know why, so i try to delete some functions.

I have just noticed this new PR but before reviewing I think it would be better for you to do local cheks first before committing and pushing. It sends quite a lot of emails into my inboxes... And may I ask why you close this?

This pr is submmit from my fork, it can't use sercet api key, so I opened another pr https://github.com/camel-ai/camel/pull/274 from a branch.


Error TypeError: Failed to fetch with startKeepAliveServiceWorker

We are having errors TypeError: Failed to fetch (linked to startKeepAliveServiceWorker) appear with the last itnerval of the "refresh_time_before_tokens_expiration_in_second" setting. @axa-fr/react-oidc version 7.18.5 and we are in service worker mode only, with Chrome last version
Have you a idea why this error is occuring ?

hi @damienborgniet ,
Thank you for you issue.
TypeError seem strange. Do you have a screen of the console or something like this?

Hello @guillaume-chervet ,
we face the same issues when running headless chrome in docker with playwright:
we migrated from 7.13.15 -->7.20.1

The login is done, but then it fails after...


Read app settings from *.settings.json

Coming up with a reasonable way to read the app settings from a config file.  Coming from an embedded resource, this shouldn't be too expensive.
The only thing left to figure out is how we conditionally include a local.app.settings for debug and use app.settings for release.  I added some code that tried to achieve that in the .csproj but it doesn't seem to be working.  Needs another look.

We just got to make sure if the app is updated to add/remove regions we update the local storage.


Disable persistent pop-up to install formatter

Occasionally, a popup will appear in the bottom-right telling me to install a formatter like autopep8, black, or yapf. Despite clicking the X button, the popup will continue to appear. My Edtior: Format On Save setting is disabled for both User and Workspace, but this popup is persistent.
In my case,  I don't want to use an autoformatter because I prefer camelCase and two spaces when indenting, and I prefer to line up long arguments a certain way. I generally don't spend much time at all on formatting after the fact since I write the code correctly the first time.

Thanks for the feature request! We are going to give the community 60 days from when this issue was created to provide 5 👍 upvotes on the opening comment to gauge general interest in this idea. If there's enough upvotes then we will consider this feature request in our future planning. If there's unfortunately not enough upvotes then we will close this issue.

@FriskySaga Just checking, you can disable formatting for just Python. have you tried that?

Thank you for submitting your feature request and everyone who considered it! Unfortunately this issue did not receive enough votes over the allotted time, and so we are closing the issue.


libgcrypt "make check" fails on OS X 10.11

Partial build log:

PASS: version
PASS: mpitests
PASS: tsexp
PASS: t-convert
PASS: t-mpi-bit
PASS: t-mpi-point
PASS: curves
PASS: t-lock
PASS: prime
PASS: basic
PASS: keygen
PASS: pubkey
PASS: hmac
PASS: hashtest
PASS: t-kdf
PASS: keygrip
PASS: fips186-dsa
PASS: aeswrap
PASS: pkcs1v2
dyld: Library not loaded: /nix/store/g18vsy0lg78yj97ysdmql61pwp6q5n0k-libgcrypt-1.6.4/lib/libgcrypt.20.dylib
  Referenced from: /Users/dhess/tmp/libgcrypt-1.6.4/tests/.libs/random
  Reason: image not found
random: running '/Users/dhess/tmp/libgcrypt-1.6.4/tests/.libs/random --in-recursion --early-rng-check' failed
FAIL: random

Each test is wrapped with a script to pick up libgcrypt.20.dylib from src/.libs, rather than the final install location (which does not exist yet when "make check" is run).
This works fine for all tests except the "random" test. The "random" test fails because tests/random.c forks itself multiple times; the original exec from the wrapper script succeeds, but subsequent forks fail, so the fork does not appear to be picking up the DYLD_LIBRARY_PATH set by the wrapper.
(I wonder if this has to do with the recent fix for CVE-2015-3760 and not 10.11 specifically. Can someone running 10.10.5 try to reproduce the problem?)
Because it's a crypto library, disabling "make check" does not seem like a good solution. Maybe the "make check" tests should be moved to the installCheckPhase.
This has been reported upstream, and is also being tracked in Homebrew.
https://bugs.gnupg.org/gnupg/issue2056
https://github.com/Homebrew/homebrew/issues/41599

Note: this issue is fixed/worked around by 34c092b11479b7dac2cfda6c806772d8951ca077.


Update from github

Add feature to the python editor which would allow users to get the latest scripts from github. The current process of copying files around is a bit too complicated.

http://mcneel.myjetbrains.com/youtrack/issue/MR-1726


Add pvsadm mac binary into Homebrew

https://docs.brew.sh/Adding-Software-to-Homebrew

Here is another way of doing this is - https://docs.brew.sh/How-to-Create-and-Maintain-a-Tap

@KeerthanaAP anything else pending for this task?

@KeerthanaAP anything else pending for this task?

No.
Created a tap with pvsadm formula and updated the installation instruction with brew in README.
Fix via
https://github.com/ppc64le-cloud/homebrew-pvsadm/pull/1
https://github.com/ppc64le-cloud/pvsadm/pull/407

/close


Broke on 1.20.5

The shader broke on 1.20.5 because they removed IViewRotMat. Is there any way to fix it?

Can confirm, the update removed IViewRotMat, it's broken on 1.20.5 and above

@MiniBooM7 I fixed it, here u go https://drive.google.com/file/d/1xUnX5AyOhVmYsdz6HPYuHzRPJf0NOue0/view?usp=sharing

@MiniBooM7 I fixed it, here u go https://drive.google.com/file/d/1xUnX5AyOhVmYsdz6HPYuHzRPJf0NOue0/view?usp=sharing

yo can you look at my current core shaders they were modified by model engine

Unfortunately can't but if you just replace the entire core folder with the one I sent it should work

Unfortunately can't but if you just replace the entire core folder with the one I sent it should work

model engine had to modify to make it work it should have same code structure just some things shifted

https://github.com/bradleyq/stable_player_display/issues/7#issuecomment-2148675485
can you reupload?

@MiniBooM7 I fixed it, here u go https://drive.google.com/file/d/1xUnX5AyOhVmYsdz6HPYuHzRPJf0NOue0/view?usp=sharing

can you reupload?


[i18n]Zh cn update 1207

Merge from the main branch(until 20231207) and translate new changes to Chinese.
@enitrat Sorry we(StarknetAstro) have been so busy recently. Now we have finished all translations for CairoBook, and some new members joined us this time.
Can you review this PR? Thanks!

This change is

Great!


Remove libp2p debug logspam that prints 100x per millisecond

Here's a non-exhaustive list:
Lines that contain:
"adding resolved addr"
"ResolveUnspecifiedAddresses"
"protocol negotiation took"
"received listen addrs for"
"received message from"
"opening stream to peer"


add support for AIDA-X models

as talked over on discord a support for other model types and AIDA-X would be a huge benefit.

oh yes please!! this will be an amazing addition!!

This is coming up in our next release. Closing.


Patch 1201 (changing H and L to ignore scrolloff in operator-pending mode) seems undesirable

The commit in question: 44cc4cf72fdd12cd9a779031d443aac4254d51ae
This change seems rather undesirable to me. I expect H and L to behave the same in normal mode as in operator-pending mode, which they always have done, but now all of a sudden they’re behaving differently. This breaks my mental model of how motions work.
I believe that patch 1201 should be reverted.
The only reason I don’t feel strongly about this is that I don’t think I’ve ever actually used H or L as a motion for an operator, only ever for navigation (where my scrolloff value of 2 is well-cemented in my mind). But I’m pretty sure that if I did, I’d be ever so mildly distressed at finding the motion worked differently in operator-pending mode.

I would rather drop cursor_correct() entirely or create an option to control whether it is called then revert the change.

Just FYI, this was discussed here: https://groups.google.com/d/topic/vim_use/NUCq3aS3_xA/discussion


Small fix to abstractions.py so it runs errorless on Windows

Here's the error message we were getting on Windows when we tried to run abstractions.py:
We add the dll export in to fix this.

lgtm


npm start is very slow (server.js)

I find that npm start takes a long time everytime I make a change and need to see it. I changed babel-node to babel in package.json which I think made it a little bit faster, but it is still quite slow.
Any ideas for how to make faster turn-around for changes? I tried to run webpack --watch but that did nothing.

In isomorphic-relay-boilerplate for the client side code I used hot module replacement mechanism provided by webpack. And probably, it can be improved further by using the babel --watch together with nodeamon for the server side code.

selam gardaşlar

The monsters running wild inside of me am faded