Prepare for K2

Stuck on https://youtrack.jetbrains.com/issue/KT-63653

Stuck on https://youtrack.jetbrains.com/issue/KT-63653, and probably anvil, and probably missing a compose-multiplatform release

Held up on https://youtrack.jetbrains.com/issue/KT-64187

No compose multiplatform support for Beta3 so far, makes it more or less impossible to continue testing this for now https://github.com/JetBrains/compose-multiplatform/issues/4227

Waiting for a compose-compiler Beta4 release on https://maven.pkg.jetbrains.space/public/p/compose/dev/org/jetbrains/compose/compiler/compiler/

Are we waiting for 1.5.9-kt-2.0.0-Beta4?

RC1, which has a fix we need to make commonized parcel annotations work

Parked on three different bugs atm

expect/actual annotations not working correctly with members with default values: https://youtrack.jetbrains.com/issue/KT-67488
KAPT4 doesn't work, seemingly unable to read generated code from KSP: https://youtrack.jetbrains.com/issue/KT-66541
Contributed interfaces during anvil's IR merging don't make it to compiled classes: https://youtrack.jetbrains.com/issue/KT-67490

KT-67490 is unfortunately WAI, so interface merging will require language version 1.9 for now until anvil has another solution

Lint is falling behind here too
 Reason: Task ':backstack:generateReleaseUnitTestLintModel' uses this output of task ':backstack:generateResourceAccessorsForAndroidUnitTest' without declaring an explicit or implicit dependency. This can lead to incorrect results being produced, depending on what order the tasks are executed.

    Possible solutions:
      1. Declare task ':backstack:generateResourceAccessorsForAndroidUnitTest' as an input of ':backstack:generateReleaseUnitTestLintModel'.
      2. Declare an explicit dependency on ':backstack:generateResourceAccessorsForAndroidUnitTest' from ':backstack:generateReleaseUnitTestLintModel' using Task#dependsOn.
      3. Declare an explicit dependency on ':backstack:generateResourceAccessorsForAndroidUnitTest' from ':backstack:generateReleaseUnitTestLintModel' using Task#mustRunAfter.

iOS support will be stuck waiting for SKIE

Compose Multiplatform appears to have published 1.6.10 depending on a pre-release stdlib dep https://github.com/JetBrains/compose-multiplatform/issues/4853


Introduce PrawnHtml::Instance class to preserve the context

Introduce a PrawnHtml::Instance to be able to preserve styles. Related to #41
Sample usage:
  pdf = Prawn::Document.new(page_size: 'A4')
  phtml = PrawnHtml::Instance.new(pdf)
  phtml.append(html: '')
  phtml.append(html: '
Some HTML before
')
  pdf.text('Some Prawn text') # call any Prawn method external to PrawnHtml
  phtml.append(html: '
Some HTML after
')

One of the use cases for this is in setting ')

phtml.append(html: '
some html before
')

# do something in the pdf

phtml.append(html: '
some html after
')

phtml.append(html: "</html")

pdf.render_file('/tmp/test.pdf')

I'm not sure if that will actually work in your implementation?  And it's not necessarily super convenient for the caller either?
At any rate, if the use case that motivates this is mine in #41, that requires you to somehow set some CSS, add some HTML, do some other things to the PDF, add some more html....
It would be good to see an example test case that actually does that, to see what the UX is like, and verify that the PR can satisfy the use case!
Thinking more, I wonder if allowing CSS style to be set in another way is actually the answer....
pdf = Prawn::Document.new(page_size: 'A4')
phtml = PrawnHtml::Instance.new(pdf)

phtml.set_css = <~EOS
  body {
    font-size: 24em
  }
EOS

phtml.append(html: '
some html before
')
# do something in the pdf
phtml.append(html: '
some html after
')
pdf.render_file('/tmp/test.pdf')

I already found it kind of annoying to have to use teh otherwise unnecessary wrapper html/head/body tags to get the CSS in there...  although I'm not sure if this particular example will work, will setting CSS on body work if I don't actually have a body?  Maybe it could be made to?
Anyway, those are some thoughts, sorry for the stream of consciousness!

At any rate, if the use case that motivates this is mine in #41, that requires you to somehow set some CSS, add some HTML, do some other things to the PDF, add some more html....

The goal of this PR is the same: preserving styles (at this time, I don't know if there could be something else useful to retain) in the instance.
Initially I thought it was enough having an instance, but yesterday I made different tests and found out that the styles are not preserved in the current implementation. So I added a new commit to fix this behaviour.

phtml.set_css = <<~EOS
body {   font-size: 40px;  }
h1 { font-size: 80px; }
EOS
...
I already found it kind of annoying to have to use teh otherwise unnecessary wrapper html/head/body tags to get the CSS in there... although I'm not sure if this particular example will work, will setting CSS on body work if I don't actually have a body? Maybe it could be made to?

set_css 🤔 yeah, it could be an idea. I'll think about it.
At the moment I like to keep the API as simple as possible, so in my current implementation an example would be:
  pdf = Prawn::Document.new(page_size: 'A4')
  phtml = PrawnHtml::Instance.new(pdf)
  phtml.append(html: '')
  phtml.append(html: '
Some HTML before
')
  pdf.text('Some Prawn text') # call any Prawn method external to PrawnHtml
  phtml.append(html: '
Some HTML after
')

A test output is here: https://github.com/blocknotes/prawn-html/blob/prawn-html-instance/examples/instance.pdf

Ah, ok, does it let you set CSS just with phtml.append(html: '')?
That would work then!  In present prawn-html, I was unable to get that to work, the style tag needed to be wrapped in a head tag that was wrapped in a html tag, with the content in a body tag. Which was a bit of an annoyance, since those tags were otherwise not needed.
So this is an improvement, that will work!  If I want to set styles that apply to the entire document like font-size: 20px... do I still need a  tag somehow, so I can set the style for body { font-size: 20px; }?  If so, is there a way to supply a body tag with this new method of sending the html in separate segments?

So this is an improvement, that will work! If I want to set styles that apply to the entire document like font-size: 20px... do I still need a  tag somehow, so I can set the style for body { font-size: 20px; }? If so, is there a way to supply a body tag with this new method of sending the html in separate segments?

I think that this is getting out of scope for this PR and the standard scenario for me is using PrawnHtml.append_html method.
Also consider that you could achieve something similar with:
  phtml.append(html: '')
  phtml.append(html: '
The first part
')
  phtml.append(html: '
The second part
')
  phtml.append(html: '
The third part
')

Thanks, it's good to see explicitly that you can provide a


Baseline: Adds issue to xml when file is excluded

Expected Behavior
gradlew detektBaseline creates a xml file containing all issues to ignore them. I would expect, this file does not contains issues marked in an exclude folder.
Observed Behavior
baseline.xml contains issues for files matching the exclude filter. This is a little bit confusing.
Steps to Reproduce
import io.gitlab.arturbosch.detekt.*

plugins {
    kotlin("jvm") version "1.6.10" apply false
    id("io.gitlab.arturbosch.detekt") version "1.19.0"
}

allprojects {
    repositories {
        mavenCentral()
    }
}

detekt {
    source = files(rootProject.rootDir)
}

tasks {
    withType<Detekt>().configureEach {
        include("**/*.kt")
        exclude("**/*.kts")
        exclude("**/resources/**")
        exclude("**/build/**")
    }
}

fun b() {

}

./gradlew detekt
Context
I want to ignore issues in some files, mostly generated Kotlin files from code generators (sqlDelight).
If I add manually a new file which contains some issues which should be ignored and I run detektBaseline, the resulting diff is much larger because now baseline adds all issues, not my new issues but also issues from generated code.

Your Environment

Version of detekt used: 1.19
Version of Gradle used (if applicable): 7.3.3
Gradle scan link (add --scan option when running the gradle task):
Operating System and version: macOS 12.1
Link to your project (if it's a public repository):
baselineExclude.zip

These seems like an issue in our documentation. You need to add this too:
    withType<DetektCreateBaselineTask>().configureEach {
        include("**/*.kt")
        exclude("**/*.kts")
        exclude("**/resources/**")
        exclude("**/build/**")
    }

@BraisGabin Thanks!


Feature Request. Custom title.

Add CLI flag for custom title of the webUi.
Then provide the title to the page to be displayed on browser's tab and also somewhere in UI.
When having several Selenoid-UIs on several machines, that would ease switching between them.

Probably it can just reflect the hostname without any cli args

@lanwen well, yeah, it can! But it won't be useful when you got IPs as host names.
Unless you remember all the IPs :-p

Is that still actual with ggr-ui existence?


Update Microsoft.OneDriveInternalSlow to 21.170.0822.0002

[x] Have you signed the Contributor License Agreement?
[x] Have you checked that there aren't other open pull requests for the same manifest update/change?

[ ] Have you tested your manifest locally with winget install --manifest <path>?
[x] Does your manifest conform to the 1.0 schema?

Note: <path> is the name of the directory containing the manifest you're submitting.

Microsoft Reviewers: Open in CodeFlow

cc @palenshus @ChuckFerring @ryfu-msft


[MM-43441] Delinquency Credit Card Update Modal

Summary
This PR adds a condition to the existing purchase modal that will render a different card on the right hand side in the event an installation is delinquent
Adding a credit card in this context will save the new card to Stripe, and attempt to pay all outstanding invoices for the particular subscription.
This modal will be openable from a URL (that will be in the delinquency emails) with the query param show_delinquency_modal
Ticket Link
https://mattermost.atlassian.net/browse/MM-43441
Related Pull Requests

Has server changes (please link here)
Has mobile changes (please link here)

Screenshots
The modal with new card:

Clicking "View Breakdown":

Clicking on one of the individual invoices in the breakdown:

Release Note

None

@nickmisasi what happens when they click the Download link? Does it open a new tab with the PDF?

By the way, the design for opening up the invoice is slightly different from the screenshot above

@johndavidlugtu clicking the download button will download the invoice. No tabs open or anything, just downloads it.
The invoice preview modal is about as close to the design as we can get it right now. What it's actually doing is just grabbing the generated invoice PDF from the CWS and simply displaying that PDF, which means all the padding/borders/etc are included.
If we want it to look exactly as the design, we'll need to implement the invoice display natively in the webapp JavaScript, which is a large effort

My thoughts on the first screenshot:

Remove the Most Popular banner
Replace "Settle Your BalancewithTotal owed`
Remove "Total owed" in the blue box section

If we want it to look exactly as the design, we'll need to implement the invoice display natively in the webapp JavaScript, which is a large effort

Okay something for next time

@johndavidlugtu @marianunez I've configured this spinwick to be delinquent - it has 2 invoices in the history.
Please do not actually "reactivate" the subscription, just look at the modal
It takes a while to get the data set up

Can we add some padding on the top section of the blue box? Keep the text inside centered

Also, not sure if this is known, but that's the view I got after clicking on View Breakdown

@nickmisasi

@johndavidlugtu Thanks for pointing that out - it was related to viewing the preview from channels rather than the system console. Should be fixed with the next update of the spinwick.

@johndavidlugtu Thanks for pointing that out - it was related to viewing the preview from channels rather than the system console. Should be fixed with the next update of the spinwick.

The list of invoices now LGTM but the invoice view header seems to still having some styling issues:

In this state (which I'm assuming they have been downgraded - the test server seems to still be in Professional), when they go to the System Console they see the banner that their Payment Failed with a link to update the CC.
I think we need to add something more in the CC screen regarding the deliquency state because it currently shows the default banner that says their CC will not be charged at that time but in reality it will in this state:

The list of invoices now LGTM but the invoice view header seems to still having some styling issues:

@marianunez fixed in latest diff

@marianunez good call out - discussed this with John. I've made it so that clicking the edit icon on the payment info screen will direct you to the delinquency modal if the delinquent_since value is set, rather than the existing edit payment scree. This way, the customer will be able to still see the breakdown of what they'll be charged for when they update their CC info.

@marianunez good call out - discussed this with John. I've made it so that clicking the edit icon on the payment info screen will direct you to the delinquency modal if the delinquent_since value is set, rather than the existing edit payment scree. This way, the customer will be able to still see the breakdown of what they'll be charged for when they update their CC info.

That sounds good to me. However, the CC screen is still available to change their credit card and the banner is misleading that they are not going to be charged. We need at least to show another banner that can link to the Delinquency modal to see what they will be charged.

However, the CC screen is still available to change their credit card and the banner is misleading that they are not going to be charged. We need at least to show another banner that can link to the Delinquency modal to see what they will be charged.

The banner you mention is only shown inside the cc edit screen AFAICT. What I've done is made it so that clicking the pencil icon on the payment info screen opens the modal instead of the cc edit screen when delinquent (live in the spinwick right now if you want to check it out)

However, the CC screen is still available to change their credit card and the banner is misleading that they are not going to be charged. We need at least to show another banner that can link to the Delinquency modal to see what they will be charged.

@marianunez The banner you mention is only shown inside the cc edit screen AFAICT. What I've done is made it so that clicking the pencil icon on the payment info screen opens the modal instead of the cc edit screen when delinquent (live in the spinwick right now if you want to check it out)

Ah gotcha! I thought it was only from the banner. Yeap - that works 🎉

E2E tests not automatically triggered, because PR has no approval yet. Please ask a developer to review and then try again to attach the QA label.

/update-branch

@nickmisasi can we adjust the total owed card to look like this please?

@nickmisasi can we adjust the total owed card to look like this please?

/e2e-test

Successfully triggered e2e testing!
https://git.internal.mattermost.com/qa/cypress-ui-automation/-/pipelines/234207

I only see the close icon upon hover
Can we please left align the Total column?
Can we please add an "Invoice" column title?

@annelieseklein updated the card:

I only see the close icon upon hover

Fixed

Can we please left align the Total column?

Done

Can we please add an "Invoice" column title?

Could you clarify? Not sure where you want this

Can the "Invoice(s)" modal title be Metropolis, semibold, 22px

Done

Should we do a max of 5 invoices before we show the pagination at the bottom?

Done - note this will affect the billing_history page in the system console.

/update-branch

/update-branch

@annelieseklein gentle ping on this one :)

@nickmisasi heads up the blue box is missing in the test server

@johndavidlugtu
Used the wrong variable fixing this: https://github.com/mattermost/mattermost-webapp/pull/10984#discussion_r959754842
Should be good now

@nickmisasi Looks great, can we please:

update the "invoice(s)" title to be Semibold and size 22 to be consistent with other modal titles.
Add 32 px padding left and right of the modal and 24 px padding top and bottom to be consistent with modals
Remove the grey background on that rectangle where the titles are

/update-branch

@stevemudie going to defer QA Review on this one until post merge, where we'll be able to test all of delinquency as a whole

E2E tests not automatically triggered, because the PR is not in a mergeable state. Please update the branch with the base branch and resolve outstanding conflicts.


Need to add more FFDC

A PRD error is reported recently from customers recently.  PRD failed because targets that existed on the previous IPL no longer exist during the checkstop analysis. However, not enough FFDC has been recorded for this failure. Has shared the logs with Daniel and Zane.  Maybe need to modify the code to add more FFDC.

Zane, have you looked at the logs?  Any conclusions?  If we need more info, can we suggest gathering any other data?

@Frank-yujiang I am just now finding some old issues. Does this issue still need to be resolved?


Inline editor

@asanzo suggested in #207 to have editor inlined, as in RubyMonk. I have tested the idea, and I have got mixed results. In some cases, particullary when the description is mostly text and a bit of code, I think that the proposed layout is better.

But in other scenarios, when you have more code and/or images, the results are worse:

You can notice large blank areas.
Since exercise description is just markdown, which does not have any directive for grids or layouts, it is not actually possible to change it from within description. Changing from css it is technically possible, but results of a transformation may be semantically broken since you wont't have any idea where image description will appear.
I have no real solution for this. I would like to hear your comments @asanzo, @faloi

Hm, ok, actually after iterating over it a bit more, and after enabling tables extended syntax for markdown, I notice that we can have some control of the layout within the exercise.
Updated samples:

So it is actually just a matter of tunning the descriptions.

As discussed in #222, we got bad results. We will rollback those changes

But in the end, we will have something similar to this, but configurable, see #235


Error migrating entry

Hi,
I used the bouni luxtronik integration first and then switched to yours now. when I'm trying to migrate from below version, the migration fails and I have no idea how to fix. If I remove the integration and re-add , it works. But then all Dashboards and automations are broken.
Thank you very much for your work here, really appreciated!
Installed Version 2023.9.10
New Version 2024.9.30
below is the error:
Error migrating entry "removed" for luxtronik2
Traceback (most recent call last):
File "/usr/src/homeassistant/homeassistant/config_entries.py", line 933, in async_migrate
result = await component.async_migrate_entry(hass, self)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/config/custom_components/luxtronik2/init.py", line 112, in async_migrate_entry
config_entry.version = 3
^^^^^^^^^^^^^^^^^^^^
File "/usr/src/homeassistant/homeassistant/config_entries.py", line 443, in setattr
raise AttributeError(
AttributeError: version cannot be changed directly, use async_update_entry instead
2024-10-13 14:59:21.448 INFO (MainThread) [homeassistant.setup] Setting up luxtronik2
2024-10-13 14:59:21.449 INFO (MainThread) [homeassistant.setup] Setup of domain luxtronik2 took 0.00 seconds
2024-10-13 14:59:21.449 DEBUG (MainThread) [custom_components.luxtronik2] Migrating from version 2
2024-10-13 14:59:21.451 INFO (MainThread) [custom_components.luxtronik2] Connected to Luxtronik heatpump X.X.X.X:8889 with timeout 60.0s
2024-10-13 14:59:21.455 DEBUG (MainThread) [custom_components.luxtronik2] Command 3003
2024-10-13 14:59:21.456 DEBUG (MainThread) [custom_components.luxtronik2] Length 1141
2024-10-13 14:59:21.459 DEBUG (MainThread) [custom_components.luxtronik2] Read 1141 parameters
2024-10-13 14:59:21.461 DEBUG (MainThread) [custom_components.luxtronik2] Command 3004
2024-10-13 14:59:21.504 DEBUG (MainThread) [custom_components.luxtronik2] Stat 0
2024-10-13 14:59:21.504 DEBUG (MainThread) [custom_components.luxtronik2] Length 263
2024-10-13 14:59:21.505 DEBUG (MainThread) [custom_components.luxtronik2] Read 263 calculations
2024-10-13 14:59:21.507 DEBUG (MainThread) [custom_components.luxtronik2] Command 3005
2024-10-13 14:59:21.556 DEBUG (MainThread) [custom_components.luxtronik2] Length 365
2024-10-13 14:59:21.557 DEBUG (MainThread) [custom_components.luxtronik2] Read 365 visibilities
2024-10-13 14:59:21.559 ERROR (MainThread) [homeassistant.config_entries] Error migrating entry "removed" for luxtronik2
File "/config/custom_components/luxtronik2/init.py", line 112, in async_migrate_entry

@BenPru TODO: Change "config_entry.version = 3" to "async_update_entry"


Expose florist state variables as preferences

Enables the ability to re-check the florist friars without having to relaunch KoLmafia.
Followup to #1856

Thank you for this. Do you think it makes sense to merge in with #1858, or does it cover everything you want to cover.

Thank you for this. Do you think it makes sense to merge in with #1858, or does it cover everything you want to cover.

I think that one is more comprehensive. If any of the test cases I've provided are useful then that might be worth merging in.


Renamed several files in the covidcast signals folder

Removed -inactive, and renamed quidel files to distinguish covid and flu.
closes|addresses
Summary:

Prerequisites:

[X] Unless it is a documentation hotfix it should be merged against the dev branch
[X] Branch is up-to-date with the branch to be merged with, i.e. dev
[ ] Build is successful
[ ] Code is cleaned up and formatted

Not breaking links to doc pages was easiest by keeping the active (covid) quidel doc file named quidel.md instead of quidel-covid.md; the only other link that needed to be updated was an .../indicator-combination-inactive.html in this repo. No other outdated URLs exist in this repo or other Delphi repos.


Missing device configuration: Ring Glass Break Sensor EU 0x0401

Checklist

[X] It is not in the configuration DB

[X] It was not merged recently or has a pending PR

[X] The device was interviewed completely and has no missing or undefined IDs

Which device is missing?
Ring Glass Break Sensor EU
Manufacturer ID
0x0346
Product Type
0x0a01
Product ID
0x0401
Firmware Version
1.11.0
Is the device listed on the Z-Wave Alliance website?
https://products.z-wavealliance.org/products/4560
Do you have a manual?
Hi @AlCalzone , can you please approve PR 6590 for missing device fingerprint ?

Have you tried to put the modified json file in your store/config folder and reinterview your device.  That should get you going.

Yep.
It works fine.
I'm just try to understand when the PR will be merged and if there is something that I've to do (it's my first PR ... so If I have missed something .... please let me know)

Did you see the tagged item about parental leave? I think the worst-case scenario is April.  I have several open PRs myself.  IMO yours should sail through.

Did you see the tagged item about parental leave?
Awh ... didn't see it !!!
This explain all of this

I think the worst-case scenario is April. I have several open PRs myself. IMO yours should sail through.
Yep .... I was worried about have done something wrong!
So no prbl .... it's a very very low priority PR


Share with twitter without dialog.

Hi, I´m wondering if we can share twitter without the dialog.
I need to check if the user is logged in twitter, and then send the message and picture to twitter without the dialog of posting in twitter. I want to create the share just like the one on Instagram or nike running.
Any suggestion in how to do this?
Thanx in advance.

Hi, you can't with this plugin. Perhaps search for a dedicated Twttr plugin, I'm not aware of its existence.

Thanx for your help! Nice plugin by the way!


Create siem.txt

@lokesh182 First stage of verification passed, official domain is siem.sandipfoundation.org as far as I verified. This is just an informational note. Pull request is still in the review. I appreciate your patience while waiting for the final decision. Proof of domain ownership: https://siem.sandipfoundation.org/wp-content/uploads/2021/11/Exam-form-Notice-final.pdf

@lokesh182 Thank you for your patience while waiting for a review and processing your request. Pull request merged.


Question about recompose/branch

Hello there,
i'm struggling a bit with different HOCs that are using input as rendered element. I want to use uncontrolled input, where values is stored inside DOM, but i want to keep this value after reupdate with recompose/branch.
I'm attaching jsfiddle, where my problem is described. There are two HOC. Each render different input border depending on value inside input. When its "red", border should be red. Thing is, when branch render second HOC (blue), it will discard last input value.
Is there any way (without using controller input with value={}) ?
https://jsfiddle.net/m2wxk0wa/3/
OR:
class Input extends React.PureComponent {
        render() {
            return <input
                {...this.props}
                type="text"
             />;
        }
      }

      const redInput = () => (Component) => {
        class RedInput extends React.Component {
           render () {
              return (

<Component className="red" {...this.props} />

              );
           }
        }

        return RedInput;
      }

       const blueInput = () => (Component) => {
        class BlueInput extends React.Component {
           render () {
              return (

<Component className="blue" {...this.props} />

              );
           }
        }

        return BlueInput;
      }

const colloredInput = Recompose.branch(({ isRed }) => isRed, redInput(), blueInput());
const FormColloredInput = colloredInput(Input);

class App extends React.Component {
    constructor (props) {
       super(props);
       this.state = {
         isRed: false,
       };
    }

    render () {
      return (

          <FormColloredInput isRed={this.state.isRed} onChange={(event) => this._onInputChange(event)} />
          {this.state.isRed ? 'isRed' : 'isBlue'}

      );
    }

    _onInputChange (event) {
       this.setState({
         isRed: event.target.value === 'red',
       });
    }
}

      ReactDOM.render(<App />, document.getElementById('container'));

The problem with your solution is that you've got two completely separate components (even though they look almost the same). It means react will unmount first component, and mount second when changing from red to blue. The reason is that (simplified) react makes simple comparison to determine if that's the same component (it checks something like BlueInput === RedInput). And that check fails, so remounting happens. That's why you lose state.
I mean branch is just not what you need in this case. Passing simple prop instead of different component will work perfectly. If you have some more complex usecase, please describe it.

I'm going to close this issue and please feel free to reopen it if there is any further question.


Android app  collapsed after upload to 0.26

React native code is integrated into Android app, works fine with react-native 0.25.+,
After uploaded to 0.26, unable to work anymore, as the following:
"unfortunately, xxxxx(app name) has stopped"
react 15.0.1
react-native 0.26.2
osx 10.11.4
gradle:   compile "com.android.support:appcompat-v7:23.0.1"

Can you check the crash log with Logcat?

@facebook-github-bot label Needs more information

Unable to load script from assets: index.android.bundle
06-04 10:03:25.992 18310-18544/com.kenny.embedded E/ReactNative: Got JS Exception: ReferenceError: Can't find variable: __fbBatchedBridge
06-04 10:03:26.014 18310-18310/com.kenny.embedded D/AndroidRuntime: Shutting down VM @charpeni

I just make it works in 0.26.2, while I think there are there problems needs to be solved.

I just realized the correct peer dependence of 0.26.2 is react 15.0.2 instead of 15.0.1, according to #7697
It is still not able to run app with Android Studio directly. Log is as mentioned previously. I have to type in terminal "react-native bundle"  to generate bundle file.
After step 2, app still crash with new log "undefined is not a function (evaluating 'UIManager.setChildren(containerTag,createdTags)')", I changed the UIManager.js under node_modules/react-native/Libraries/Utilities following #7409, finally app works.

any better solutions?

I just realized the correct peer dependence of 0.26.2 is react 15.0.2 instead of 15.0.1, according to #7697

It should be fixed with 0.26.3.

@charpeni you meant 0.27+ ? I tried with 0.26.3 do not work with #7409

Hi there! This issue is being closed because it has been inactive for a while.
But don't worry, it will live on with ProductPains! Check out its new home: https://productpains.com/post/react-native/android-app-collapsed-after-upload-to-026
Product Pains has been very useful in highlighting the top bugs and feature requests:
https://productpains.com/product/react-native?tab=top
Also, if this issue is a bug, please consider sending a pull request with a fix.

After upgrading from version 0.38.0 to 0.42.0 i am getting the same error
java.lang.RuntimeException: Unable to load script from assets 'index.android.bundle'. Make sure your bundle is packaged correctly or you're running a packager server.
 at com.facebook.react.cxxbridge.CatalystInstanceImpl.jniLoadScriptFromAssets(Native Method)
 at com.facebook.react.cxxbridge.CatalystInstanceImpl.loadScriptFromAssets(CatalystInstanceImpl.java:198)
 at com.facebook.react.cxxbridge.JSBundleLoader$1.loadScript(JSBundleLoader.java:33)
 at com.facebook.react.cxxbridge.CatalystInstanceImpl.runJSBundle(CatalystInstanceImpl.java:216)
 at com.facebook.react.ReactInstanceManager.createReactContext(ReactInstanceManager.java:994)
 at com.facebook.react.ReactInstanceManager.access$600(ReactInstanceManager.java:109)
 at com.facebook.react.ReactInstanceManager$4.run(ReactInstanceManager.java:746)
 at java.lang.Thread.run(Thread.java:761)


Add a property for the margin

Add a property where the user can specify the margin of the barcode

Released with version 1.04.16


fix: added job to publish to docker for monthly release publish step

Signed-off-by: Allison Suarez Miranda<EMAIL_ADDRESS>
Summary of Changes
added docker publish, need to do for other repos
Tests
What tests did you add or modify and why? If no tests were added or modified, explain why. Remove this line
Documentation
What documentation did you add or modify and why? Add any relevant links then remove this line
CheckList
Make sure you have checked all steps below to ensure a timely review.

[ ] PR title addresses the issue accurately and concisely. Example: "Updates the version of Flask to v1.0.2"

In case you are adding a dependency, check if the license complies with the ASF 3rd Party License Policy.

[ ] PR includes a summary of changes.
[ ] PR adds unit tests, updates existing unit tests, OR documents why no test additions or modifications are needed.
[ ] In case of new functionality, my PR adds documentation that describes how to use it.

All the public functions and the classes in the PR contain docstrings that explain what it does

[ ] PR passes make test

Codecov Report

Merging #275 (3c06323) into master (2752492) will increase coverage by 3.63%.
The diff coverage is 73.17%.

@@            Coverage Diff             @@
##           master     #275      +/-   ##
==========================================
+ Coverage   74.10%   77.73%   +3.63%
==========================================
  Files          25       27       +2
  Lines        1255     1379     +124
  Branches      136      164      +28
==========================================
+ Hits          930     1072     +142
+ Misses        297      259      -38
- Partials       28       48      +20

Impacted Files
Coverage Δ

metadata_service/api/column.py
100.00% <ø> (ø)

metadata_service/api/popular_tables.py
100.00% <ø> (ø)

metadata_service/api/system.py
66.66% <ø> (ø)

metadata_service/api/user.py
100.00% <ø> (ø)

metadata_service/proxy/statsd_utilities.py
81.25% <ø> (ø)

metadata_service/util.py
100.00% <ø> (ø)

metadata_service/proxy/shared.py
28.57% <28.57%> (ø)

metadata_service/api/badge.py
61.29% <61.29%> (ø)

metadata_service/proxy/neo4j_proxy.py
71.55% <61.53%> (-3.45%)
:arrow_down:

metadata_service/proxy/base_proxy.py
67.07% <73.33%> (-0.07%)
:arrow_down:

... and 17 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0544d88...3c06323. Read the comment docs.


1.19 update and future?

Hello, can we get an update to 1.19 please?
Are there any plans to continue adding music from MC Dungeons? There have been a number of updates for MCD but nothing else was added to this mod. It it just lack of interest in updating this mod or is it something like time constraints? Because I would love to see more updates to this mod.

1.18.1 threw a lot of wrenches into the systems Atmosfera uses and updating it would be a huge burden. I don't have the time to commit to this project anymore but would be open to somebody else with the skills to do so taking over.

@Haven-King I did ask Fourmisain to help out and he seems can help and he is a great dev with a good spirit. I hope you all can get along and continue this journey.
Thanks both of you guys <3 <3

@Fourmisain I would be happy to have you take over as maintainer of this project! I am out of town for the next few days and unable to test your fork, but if you open a PR just so we keep the changes all together, I will try to review it this weekend and add you to both the GitHub and CurseForge projects.

Regarding the future of Atmosfera, i will also try to do my bit, as I like the mod too, and would like to see it more commonly used

I guess illumination was the culprit of that crash but IDK maybe konkret update helped too

IDK why I get so many memory leak. I even installed memory leak fix mod to combat any possible memory leak. but still there are so many logs like this:
[21:35:07] [Render thread/WARN]: Reclaimed 32720 bytes at address<PHONE_NUMBER>128 that were leaked from an unknown location (logging is disabled)
I get so many sound errors like:
[21:35:23] [Render thread/WARN]: Unable to play empty soundEvent: minecraft:entity.salmon.ambient
[21:54:28] [Render thread/WARN]: Unable to play empty soundEvent: minecraft:entity.cod.ambient
[21:50:10] [Render thread/WARN]: Unable to play empty soundEvent: minecraft:entity.tropical_fish.ambient
[21:50:11] [Render thread/WARN]: Unable to play empty soundEvent: minecraft:entity.puffer_fish.ambient
also getting this error :
[21:55:20] [Server thread/WARN]: Can't keep up! Is the server overloaded? Running 8167ms or 163 ticks behind
[21:54:57] [Server thread/WARN]: Can't keep up! Is the server overloaded? Running 2242ms or 44 ticks behind
full log file:
latest.log

I still doubt your memory leak is caused by Atmosfera, I have done some testing on this and didn't run into any issues, though I also cannot fully dismiss it - but not for the reasons you might be thinking. Sounds not ending and stuff like that will not cause a memory leak.
Try to get rid of Farsight first and retest, that's still the most likely candidate.
About those warnings:

[21:35:07] [Render thread/WARN]: Reclaimed 32720 bytes at address<PHONE_NUMBER>128 that were leaked from an unknown location (logging is disabled)

That's Sodium trying it's best to fix the mess.

 Is the server overloaded? Running 8167ms or 163 ticks behind
[21:54:57] [Server thread/WARN]: Can't keep up! Is the server overloaded? Running 2242ms or 44 ticks behind

This just means the server is temporarily running slow. If your memory is nearly full and your game is chugging, this is to be expected.
There are some cases where these warnings are completely normal, e.g. after booting up a dedicated server or right here in your log:

[21:48:44] [Server thread/WARN]: Can't keep up! Is the server overloaded? Running 10014ms or 200 ticks behind
[21:48:44] [Render thread/INFO]: [CHAT] The nearest minecraft:desert is at [2985, 81, 3924] (4802 blocks away)
[21:48:44] [Server thread/INFO]: [EGOIST23: Set own game mode to Creative Mode]
[21:48:44] [Render thread/INFO]: [CHAT] Set own game mode to Creative Mode
[21:48:54] [Render thread/INFO]: [CHAT] The nearest minecraft:desert is at [2985, 81, 3924] (4802 blocks away)
[21:49:00] [Server thread/INFO]: [EGOIST23: Teleported EGOIST23 to 2985.500000, 81.000000, 3924.500000]
[21:49:00] [Render thread/INFO]: [CHAT] Teleported EGOIST23 to 2985.500000, 81.000000, 3924.500000
[21:49:03] [Server thread/WARN]: Can't keep up! Is the server overloaded? Running 3086ms or 61 ticks behind

You used /locate, which is an expensive command (because it needs to search surroundings for your biome) and followed it up with /teleport, which loads/generates a bunch of new chunks, so it's normal for the server to run behind.
Again, please try disabling mods one-by-one and do long play sessions to get an idea if one particular mod is causing the issue or not.
Logs don't help narrow down the cause, because the memory leaks are invisible.

This just means the server is temporarily running slow. If your memory is nearly full and your game is chugging, this is to be expected

I have 32GB ram and it's not even half used when I launch minecraft and I already dedicated 6GB to it. it can't be nearly full tho
but even after I teleported somewhere and let it settle and loads chunks around still has problem and is going down to even 2 fps ;-;
BTW I removed farsight and replaced phosphor with starlight and it seems fps is now 150+ even tho the chunk I'm in is not loadedd yet

it might be phosphor or farsight. but now it's much better
thanks so much <3

I have 32GB ram and it's not even half used when I launch minecraft and I already dedicated 6GB to it. it can't be nearly full tho

By "memory nearly full" I mean the game's heap memory, you can see it if you press F3 on the top right. You'll see the numbers quickly rise and fall down again. When it's constantly at high values, you know very little free space is left and that's where the game starts chugging (and crashing).

even tho the chunk I'm in is not loadedd yet

I had that very chunk loading issue too in All of Fabric 5, not sure what that's caused by.

it might be phosphor or farsight. but now it's much better

It's very unlikely it's Phosphor.
I saw Farsight had some reported issues about memory usage and potential leaks, though nothing came of it.
If you still want high view distance, you can give Bobby a shot.

I had that very chunk loading issue too in All of Fabric 5, not sure what that's caused by.

So it's not just me.
thanks for the info and help you been provided for me. I really appreciated <3

IDK if this kinda "add support" need to be done from that side of development or this side

@Fourmisain btw have you seen charmonium mod? it has really good performance and sounds pick up really fast(biome and elevation detection is really fast)
can you check the mod to see can we improve atmosfera with that? if you have time
thanks <3

@Haven-King @Fourmisain any news on the state of this mod and future plans?
thanks in advance <3

Haven't come around porting to 1.19.3 yet, not sure when I'll be able to. This might take a little more effort since this is where Mojang started putting major technical changes into minor patches, which has it's pros and cons - though I feel like 1.19.2 is still perfectly viable to use in the meantime.
Apart from that, I / we are waiting on Haven-King.

Any chance for a 1.20+ update?

Hey, any info or willingness for 1.21(.1) update? Pity that the main dev died and didn't add people willing to update it as maintainers, as it kinda made Atmosfera dead... And it was such a great mod. It still is. Sadly - without updates.
Anyways, 1.20 version works (?) on 1.21, except the mod menu config is borked, not sure how it plays out in game tho

The mod was surprisingly unaffected by the massive NBT changes in 1.20.5 and all that broke in 1.21.1 was literally just
new Identifier() -> Identifier.of()
Here's the port: #40
Release found inside as always!

Bro, did you just update a mod in less than an hour of some random dude asking online? 😭
I'm so gonna test it rn lmao

Okay, so now that this one awesome person updated Atmosfera up to 1.21, how does it look like when used with Charmonium and/or MAmbience. I used it as a replacement, and sometimes along with Atmosfera, but not quite sure how well they go together. I do know there is stated conflict in mod json, but it'ws only conflicting, not breaking, so not sure if I should/can use it together...
(Also still confused as to how you just did that update so quickly lmaooo, like that's crazyXD)

Fourmisain is a great dev that I asked to help to keep this mod alive and
he is just awesome at it
Many thanks to him
<3 <3 <3
On Thu, Aug 15, 2024, 3:43 PM Gregory @.***> wrote:

Okay, so now that this one awesome person updated Atmosfera up to 1.21,
how does it look like when used with Charmonium and/or MAmbience. I used it
as a replacement, and sometimes along with Atmosfera, but not quite sure
how well they go together. I do know there is stated conflict in mod json,
but it'ws only conflicting, not breaking, so not sure if I should/can use
it together...
(Also still confused as to how you just did that update so quickly lmaooo,
like that's crazyXD)
—
Reply to this email directly, view it on GitHub
https://github.com/Haven-King/Atmosfera/issues/36#issuecomment-2291159130,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AUULT62C7UO6U2UO7M6R623ZRSLOFAVCNFSM5ZC6COD2U5DIOJSWCZC7NNSXTN2JONZXKZKDN5WW2ZLOOQ5TEMRZGEYTKOJRGMYA
.
You are receiving this because you commented.Message ID:
@.***>

Haven-King just added me as a maintainer and gave me push access on this repo!
I'll start merging the PRs and publishing the releases to CurseForge.
@Haven-King A bit of revenue share would be nice to have too if you haven't!
Also, should I create a page on Modrinth too? People will wanna have it on there too.

@Fourmisain I've already assigned 100% of future revenue to you on CurseForge 🙂 You are welcome to create a Modinth page as well if you wish.

Thanks a ton!
Will create a Modrinth page soon too!

Modrinth page is up and is already approved!


helm charts return 404

Hi @hgye
I finally made it to this issue. You will find that accessing /charts directly from the browser will yield a 404 since there is no index.html there. Instead, you could use Artifact Hub to view the chart.

I just make it working and write a gist for others ref:
https://gist.github.com/hgye/644bfaa8157108d6c203ce22b5f17814

This is very very interesting. Thanks for sharing!
Pedro
On Wed, Mar 31, 2021 at 2:25 AM hgye @.***> wrote:

I just make it working and write a gist for others ref:
https://gist.github.com/hgye/644bfaa8157108d6c203ce22b5f17814
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
https://github.com/fonoster/routr/issues/99#issuecomment-810806513, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AAEDY7WPDYSMYJMIR3WKWDDTGK55HANCNFSM4W54AR7A
.


Taking Input source and Destination of the User

Common places like Patel brothers should show up
Source address is not reflected on


feat: replace_if_let_with_match works on chained if let ... {} else if let ... expressions

Now instead of only working on if let ... {} else {} if expressions it now works on all of them where the condition expression is the same text-wise.
This includes if let expressions without an else block, in which case a simple _ => () will be generated in the resulting match but also in more complex cases where multiple if let expressions are chained.
bors r+

@Veykril do you know if we can keep a reasonable selection range after the assist?

I'm a bit confused as to why we are even getting a selection there afterwards 🤔

I think we get a selection from the previous cursor position to the end of the edit, if that makes sense.

but I don't quite see why VSCode would even select anything there nevertheless. I'd expect only the cursor to move if nothings selected...


Migrate demo script to Gen2

This PR is currently in progress
Gen2_demo script is able to utilize model downloader used in gen1 demo to download and convert the blobs, and there is support for both mobilenet, yolo, and generic neural networks. Users can now run this demo to run an nn of a choice and see the output on the screen.
A couple of todos:

[x] Provide spatial coordinates of the detected bounding box
[x] replace gen1 downloader with blobconverter cli
[x] support for rgbr parameter
[x] support for rgbf parameter
[x] support for -cs parameter
[x] support for -monor parameter
[x] support for -monof parameter
[x] support for -dct parameter
[x] support for -med parameter
[x] support for -lrc parameter

I'll be working on these in the following days and then mark the PR as ready

Spatial coordinates PR: https://github.com/luxonis/depthai/pull/350

Cool to see more progress on this.  Excited for this to be available for quickly trying out DepthAI features/functionalities!

In progress - Gen2 calibration script. depthai_demo,py is ready for first review @szabi-luxonis @themarpe, looking forward to your suggestions

@VanDavv Flashing calibration to EEPROM is not available on main of gen2. And adding it to main of gen2 here might lead to extra questions from users when they try it.
So may be we can keep that in different branch till this PR gets merged ?
and will add write to EEPROM at the end of the same script.
Thoughts ?

It looks now like this @themarpe , bumped blobconverter package
Downloading /home/vandavv/.cache/blobconverter/mobilenet-ssd_openvino_2021.3_13shave.blob...
[==================================================]
Done

Default run python3 depthai_demo.py doesn't work on OAK-1 devices.
Need to implement a check for device capabilities in depthai-core but maybe for now we should issue a warning?

Let's merge it, since it's functional, to not confuse people w/ gen2 vs gen1. (depthay vs depthai-python)
When we will be able to retrieve device capabilities (OAK1 vs OAK-D) we will update the script, until then print a warning maybe as @themarpe  suggested?
Before merging create a gen1_main, gen1_develop branch based on current main and develop branches keeping the capability of easily switching to gen1.
Thoughts?
@Erol444 @VanDavv

@szabi-luxonis I added a param or, if not provided, I ask user to provide a device type

I'll merge latest main to gen2 so it's mergeable.
Thoughts on merging @themarpe @Erol444 ?

Let's merge it, since it's functional, to not confuse people w/ gen2 vs gen1. (depthay vs depthai-python)
When we will be able to retrieve device capabilities (OAK1 vs OAK-D) we will update the script, until then print a warning maybe as @themarpe suggested?
Before merging create a gen1_main, gen1_develop branch based on current main and develop branches keeping the capability of easily switching to gen1.
Thoughts?
@Erol444 @VanDavv

Just wanted to say, yes, I 100% agree with this.  ^. Thanks, all.

@szabi-luxonis I added a param or, if not provided, I ask user to provide a device type

I'll merge latest main to gen2 so it's mergeable.
Thoughts on merging @themarpe @Erol444 ?

If its okay to work with non-release build I'd go with using the device_improvements as provides needed API to not need the above.

@themarpe the device_improvements branch worked well (added support in #362), I think we can go ahead and merge this PR


Kubernetes 1.25+ : Helm is Unable to Recover from a Single Failed Helm Deploy

Output of helm version: version.BuildInfo{Version:"v3.11.2", GitCommit:"912ebc1cd10d38d340f048efaf0abda047c3468e", GitTreeState:"clean", GoVersion:"go1.20.2"}
Output of kubectl version: Client Version: version.Info{Major:"1", Minor:"26", GitVersion:"v1.26.2", GitCommit:"fc04e732bb3e7198d2fa44efa5457c7c6f8c0f5b", GitTreeState:"clean", BuildDate:"2023-02-22T13:32:21Z", GoVersion:"go1.20.1", Compiler:"gc", Platform:"darwin/arm64"}
The server version is the point of this ticket: 1.24 is not broken, 1.25 and 1.26 are.
Cloud Provider/Platform (AKS, GKE, Minikube etc.): This is reproducible with kwok, we are using GKE but that is unrelated.
Summary
In kubernetes versions 1.25 and above, if there is an error when applying a manifest, changing the ports of a service or container is blocked by kubernetes and the helm deploy is broken.
This gives us the below error message:
Error: UPGRADE FAILED: cannot patch "port" with kind Service: Service "port" is invalid: spec.ports[1].name: Duplicate value: "http" && cannot patch "broken-port" with kind Service: Service "broken-port" is invalid: spec.ports[1].name: Duplicate value: "http"

Reproduction:
You will need kwok: https://github.com/kubernetes-sigs/kwok

Spin up a kwok cluster to test against:

# Make a kubeconfig to use temporarily
export KUBECONFIG=$( mktemp )
export CLUSTER_NAME=broken-ports
KWOK_KUBE_VERSION=1.25.0 # Or try 1.24 or 1.26
kwokctl create cluster --name=$CLUSTER_NAME
kubectl config set-context kwok-$CLUSTER_NAME

Create a helm chart, delete the templates, and add a very basic service.yaml:

cd $( mktemp -d )
helm create test
cd test
rm -rf templates
mkdir templates
cat > templates/service.yaml <<'EOF'
apiVersion: v1
kind: Service
metadata:
  name: port
spec:
  type: ClusterIP
  ports:
    - name: http
      port: {{ .Values.port }}
      targetPort: http
      protocol: TCP
  selector:
    app: test
---
apiVersion: v1
kind: Service
metadata:
  name: broken-port
spec:
  type: ClusterIP
  ports:
    - name: http
      port: {{ .Values.brokenPort }}
      targetPort: http
      protocol: TCP
  selector:
    app: test
EOF

The below script demonstrates the issue:

namespace=default

# Successfully install the chart
helm upgrade -n $namespace --install test . --set brokenPort=4000 --set port=5000
kubectl get svc

# Upgrade the chart with a broken port so that the install fails
helm upgrade -n $namespace --install test . --set brokenPort=fail --set port=6000
kubectl get svc

# Try to upgrade the chart again with a working port: this does not work
helm upgrade -n $namespace --install test . --set brokenPort=6000 --set port=7000
kubectl get svc

# Try to upgrade the chart again again with a working port: this still does not work
helm upgrade -n $namespace --install test . --set brokenPort=4000 --set port=8000
kubectl get svc

Now you can no longer change the ports to their desired values:
helm upgrade -n $namespace --install test . --set brokenPort=4000 --set port=8000

How to workaround the issue
You can workaround the issue by getting helm to apply successfully. To do this, you get the current ports and do a helm apply with those ports:
helm upgrade -n $namespace --install test . --set brokenPort=6000 --set port=6000

And now we can change the ports:
helm upgrade -n $namespace --install test . --set brokenPort=4000 --set port=8000

Testing in 1.24
If you do the same steps above, but set KWOK_KUBE_VERSION=1.24.0 you will see that it works perfectly fine in 1.24.

That's really interesting.
The simple solution is to use the --atomic flag to revert failed releases.
But it's interesting how kubernetes' behavior has changed for how it accepts patches. Worth looking in to. I don't see anything obvious in the api commit history.

I wanted to test this a bit, so I made a repo with a Makefile, and added a github action to make things easier.
Running make test in that repo, you can see the patch behavior differences between 1.24.12 and 1.25.8.
What I find interesting is that in 1.25+ there's a partial patch, but in 1.24 both fail when one fails, is that an expected change between those k8s versions?
Test with 1.24.12
--> this installs without error
helm upgrade --install test test/. --set servicePortA=1000 --set servicePortB=2000 > /dev/null 2>&1
NAME        TYPE        CLUSTER-IP   EXTERNAL-IP   PORT(S)    AGE
service-a   ClusterIP   <IP_ADDRESS>   <none>        1000/TCP   0s
service-b   ClusterIP   <IP_ADDRESS>    <none>        2000/TCP   0s

--> service-a and service-b both fail
helm upgrade --install test test/. --set servicePortA=fail --set servicePortB=3000 > /dev/null 2>&1 || true
NAME        TYPE        CLUSTER-IP   EXTERNAL-IP   PORT(S)    AGE
service-a   ClusterIP   <IP_ADDRESS>   <none>        1000/TCP   0s
service-b   ClusterIP   <IP_ADDRESS>    <none>        2000/TCP   0s

--> service-a and service-b both succeed
helm upgrade --install test test/. --set servicePortA=4000 --set servicePortB=5000 > /dev/null 2>&1
NAME        TYPE        CLUSTER-IP   EXTERNAL-IP   PORT(S)    AGE
service-a   ClusterIP   <IP_ADDRESS>   <none>        4000/TCP   1s
service-b   ClusterIP   <IP_ADDRESS>    <none>        5000/TCP   1s

Test with 1.25.8
--> this installs without error
helm upgrade --install test test/. --set servicePortA=1000 --set servicePortB=2000 > /dev/null 2>&1
NAME        TYPE        CLUSTER-IP   EXTERNAL-IP   PORT(S)    AGE
service-a   ClusterIP   <IP_ADDRESS>   <none>        1000/TCP   0s
service-b   ClusterIP   <IP_ADDRESS>   <none>        2000/TCP   0s

--> helm upgrade fails, service-a fails, but service-b succeeds and is now 3000
helm upgrade --install test test/. --set servicePortA=fail --set servicePortB=3000 > /dev/null 2>&1 || true
NAME        TYPE        CLUSTER-IP   EXTERNAL-IP   PORT(S)    AGE
service-a   ClusterIP   <IP_ADDRESS>   <none>        1000/TCP   0s
service-b   ClusterIP   <IP_ADDRESS>   <none>        3000/TCP   0s

--> helm upgrade fails, service-a succeeds and is now 4000, but service-b fails
helm upgrade --install test test/. --set servicePortA=4000 --set servicePortB=5000 > /dev/null 2>&1 || true
NAME        TYPE        CLUSTER-IP   EXTERNAL-IP   PORT(S)    AGE
service-a   ClusterIP   <IP_ADDRESS>   <none>        4000/TCP   1s
service-b   ClusterIP   <IP_ADDRESS>   <none>        3000/TCP   1s

--> helm upgrade fails, service-a and service-b both fail consistently
helm upgrade --install test test/. --set servicePortA=6000 --set servicePortB=7000 > /dev/null 2>&1 || true
NAME        TYPE        CLUSTER-IP   EXTERNAL-IP   PORT(S)    AGE
service-a   ClusterIP   <IP_ADDRESS>   <none>        4000/TCP   1s
service-b   ClusterIP   <IP_ADDRESS>   <none>        3000/TCP   1s

I added another test, where I take the output of helm template and pipe that into kubectl apply.
Still seeing the behavior where in 1.24 both services are rejected, and in 1.25 one service fails and one succeeds.
However, the kubectl apply variation works in both versions:
Test with kubectl apply in 1.24.12
--> this installs without error
helm template test/. --set servicePortA=1000 --set servicePortB=2000 | kubectl apply -f- > /dev/null 2>&1
NAME        TYPE        CLUSTER-IP   EXTERNAL-IP   PORT(S)    AGE
service-a   ClusterIP   <IP_ADDRESS>   <none>        1000/TCP   0s
service-b   ClusterIP   <IP_ADDRESS>    <none>        2000/TCP   0s

--> service-a and service-b both fails
helm template test/. --set servicePortA=fail --set servicePortB=3000 | kubectl apply -f- > /dev/null 2>&1 || true
NAME        TYPE        CLUSTER-IP   EXTERNAL-IP   PORT(S)    AGE
service-a   ClusterIP   <IP_ADDRESS>   <none>        1000/TCP   0s
service-b   ClusterIP   <IP_ADDRESS>    <none>        2000/TCP   0s

--> service-a and service-b both succeed
helm template test/. --set servicePortA=4000 --set servicePortB=5000 | kubectl apply -f- > /dev/null 2>&1
NAME        TYPE        CLUSTER-IP   EXTERNAL-IP   PORT(S)    AGE
service-a   ClusterIP   <IP_ADDRESS>   <none>        4000/TCP   0s
service-b   ClusterIP   <IP_ADDRESS>    <none>        5000/TCP   0s

Test with kubectl apply in 1.25.8
--> this installs without error
helm template test/. --set servicePortA=1000 --set servicePortB=2000 | kubectl apply -f- > /dev/null 2>&1
NAME        TYPE        CLUSTER-IP   EXTERNAL-IP   PORT(S)    AGE
service-a   ClusterIP   <IP_ADDRESS>   <none>        1000/TCP   0s
service-b   ClusterIP   <IP_ADDRESS>   <none>        2000/TCP   0s

--> service-a fails, and service-b succeeds
helm template test/. --set servicePortA=fail --set servicePortB=3000 | kubectl apply -f- > /dev/null 2>&1 || true
NAME        TYPE        CLUSTER-IP   EXTERNAL-IP   PORT(S)    AGE
service-a   ClusterIP   <IP_ADDRESS>   <none>        1000/TCP   1s
service-b   ClusterIP   <IP_ADDRESS>   <none>        3000/TCP   1s

--> service-a and service-b both succeed
helm template test/. --set servicePortA=4000 --set servicePortB=5000 | kubectl apply -f- > /dev/null 2>&1
NAME        TYPE        CLUSTER-IP   EXTERNAL-IP   PORT(S)    AGE
service-a   ClusterIP   <IP_ADDRESS>   <none>        4000/TCP   1s
service-b   ClusterIP   <IP_ADDRESS>   <none>        5000/TCP   1s

Helm uses server-side patching https://github.com/helm/helm/blob/952708b436bb2c8d5ef0e2e9ef1d8aabe64aeae9/pkg/kube/client.go#L684. Kubectl apply doesn't.

I have taken a couple stabs at looking to see what's changed in kubernetes. Haven't found it yet.

I have same weird behavior on azure kubernetes 1.25


Finding the secret passage in the Abductor's Throne Room

Not a bug exactly, more of a matter of style:
The description of the Throne room in the Abductor's Quarters is:
"You are in a very large room. On the south wall is a large, fancy throne bedecked in blood-red drapes. Gold statues stand on either side of the throne. In the middle of the room is a fine oak table with what appear to be blood stains. A jewel-encrusted goblet rests on the table."
I examine the table, the goblet the throne and the drapes.  Nothing helpful.
But if I examine south, then:
"You find a hidden button on the throne which causes part of the south wall to open!"
To my mind, a puzzle isn't about finding the exact right command, it's about realising that there's something important and looking in the right place.  So I think that an adventurer who examines the throne (as well as one who examines the south wall) should find the button and the secret passage.
Sometimes authors are right to require specificity and accuracy, for example, when saying magic words.  Sometimes the code needs to accommodate the fact that different people write the same basic request in different terms.
I think this case is the latter.

Fixed. Examining the throne is the intended way to find that secret door. I'm definitely trying to avoid the "guess the command" situation in most cases. This is just one I missed when porting the adventure.
I updated a few room descriptions and artifact properties as well, trying to polish a few of the remaining rough edges.
I also scaled back the difficulty a little, as I seem to get horribly killed every time I play this adventure, even with an experienced character and liberal use of the HEAL and SPEED spells. (This was true of the Apple II original, as well. It's the layout of the adventure; you have to fight almost everyone in the place before you meet any friendly NPCs.)


About Image Title

It seems that image title can not be shown in the page
I used both way
![](test.jpg "test title")
{% asset_img "test.jpg" "test title" %}

and all it can just show the image itself, and nothing about the title.
Is there a way to show title?
Anyway, thank you for the theme. I like it very much.

well maybe i can add a title by myself just below the image

FYI, ![](test.jpg "test title") corresponds to <img src="test.jpg" title="test title">. This title attribute is not the same as a caption, but is shown as a tooltip in most browsers. See https://www.w3schools.com/tags/att_global_title.asp for more info.


4.27

I was able to get this working via the following
Update LoadingScreen.uplugin
"EngineVersion": "4.27",
Update LoadingScreen.Buid.cs to include:
PublicDependencyModuleName.Add("DeveloperSettings");
Recompile the plugin

thanks! that fixed my problem 👍🏻

Thank you!


new decives

Hello,
This is de message:
This is a device which is not listed in this category. Please visit https://github.com/inderkumarrathore/UIDevice-Hardware and add a comment there.
Your device hardware string is: iPhone7,1
Thank you.

Hi NES8,
Could you please tell me which device is this?
Thanks

I hope you have the latest code

I forgot put in my Podfile for update automatically. I'm really sorry, it's my mistake. Thank you a lot!

No problem dear.

No problem dear.


feat: add formatPhone

related: #146

Hello nice MR @linconkusunoki and thanks @pedrovsp for the review! Another thing that I think could be improved is the removal of the config param... I know that I've suggested this but looking at the code and the test cases, maybe its better to just format the prefix when receiving this prefix. Something like:
format('5133333333') // (51) 3333-3333
format('555133333333') // +55 (51) 3333-3333

What do you think about it?

hey guys thanks for the feedback and sorry for the late, I'll work on these changes

I like the idea of receiving the phone number and format the country code if it is present (eg. length > 11).

Hello guys, do you need some help?

hey @hyanmandian for me it's ok if anyone wants to get this task #186, maybe close this PR and open another one?


You cannot add BottomNavigationBarItem to a  BottomNavigationBar with icon only

Steps to Reproduce

Add this to a BottomNavigationBar

BottomNavigationBarItem(
    icon: Icon(Icons.list),
),

Expected results:
I get a BottomNavigationBarItem with only an icon, no label
Actual results:
This assertion within BottomNavigationBar fails (even though the BottomNavigationBarItem has no required fields missing)
assert(
    items.every((BottomNavigationBarItem item) => item.title != null) ||
    items.every((BottomNavigationBarItem item) => item.label != null),
    'Every item must have a non-null title or label',
),

Context
I am trying to make a bottom nav bar like this, with no labels

It is possible to do this with the deprecated field title which is a widget. But not with label since it cannot be null or empty

@MilesAdamson
Although I see the same behavior upon trying to use only icons in the bottom nav bar, but the material io of the widget recommends to always use text or label with icon specially if icons don't have obvious meaning:
https://www.material.io/components/bottom-navigation#anatomy

recommends

Which means it shouldn't crash if I do not provide a label. Spotify, Reddit, and Instagram have tab bars without a label. I don't think this recommendation should be forced onto the developer when using BottomNavigationBar

Thanks for the feedback. Keeping this open for further insights from the team.
The documentation says The argument icon should not be null and the argument label should not be null when used in a Material Design's BottomNavigationBar..
https://master-api.flutter.dev/flutter/widgets/BottomNavigationBarItem/BottomNavigationBarItem.html
Also, for reference: https://github.com/flutter/flutter/pull/65539#discussion_r488279180

 flutter doctor -v
[✓] Flutter (Channel stable, 2.2.3, on Mac OS X 10.15.4 19E2269 darwin-x64,
    locale en-GB)
    • Flutter version 2.2.3 at /Users/dhs/documents/fluttersdk/flutter
    • Framework revision f4abaa0735 (5 weeks ago), 2021-07-01 12:46:11 -0700
    • Engine revision 241c87ad80
    • Dart version 2.13.4

[✓] Xcode - develop for iOS and macOS
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Xcode 12.3, Build version 12C33
    • CocoaPods version 1.10.1

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] VS Code (version 1.58.2)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.21.0

[✓] Connected device (4 available)
    • Darshan's iphone (mobile)  • 21150b119064aecc249dfcfe05e259197461ce23 •
      ios            • iOS 14.4.1
    • iPhone 12 Pro Max (mobile) • A5473606-0213-4FD8-BA16-553433949729     •
      ios            • com.apple.CoreSimulator.SimRuntime.iOS-14-3 (simulator)
    • macOS (desktop)            • macos                                    •
      darwin-x64     • Mac OS X 10.15.4 19E2269 darwin-x64
    • Chrome (web)               • chrome                                   •
      web-javascript • Google Chrome 92.0.4515.107

• No issues found!

Cc: @HansMuller

@darshankawar is correct, both the Material Design spec and the BottomNavigationBar implementation require a title to be specified for each item and the widget is working as intended. I agree @MilesAdamson that it would be nice if BottomNavigationBar could handle the case where the items were just icons, but - for the moment anyway - we're not planning on adding that feature.

but - for the moment anyway - we're not planning on adding that feature.

The feature already existed, it is being taken away
      BottomNavigationBarItem(
        icon: Icon(Icons.chat),
        // Using deprecated title field to hide labels
        title: SizedBox.shrink(),
      ),

Material Design spec and the BottomNavigationBar implementation require a title

This is simply false. Material Design spec recommends a title if you have space. The latest version of BottomNavigationBar forces you to have a label unless you use the deprecated title field.


Add French-speaking communities

Please check the following before submitting your pull request:

[x] Submit one item per pull request.
[x] Additions are inserted preserving alphabetical order.
[x] You have searched the repository for any relevant issues or PRs, including closed ones.
[x] Any chat you are adding to the list is active.
[x] The pull request title is informative, unlike "Update README.md".

Thanks ! 💯


[ENH] Require source to target data in bep guidelines

Addresses issue #470
As mentioned in the issue, happy to make this a hard requirement but right now author is under the impression that the BEP process needs to be amended to do so.
Feel free to commit directly and merge if the author is wrong on this or tag him for a review.

Made it a requirement.

Integrate my two suggestions and I approve!

No bad latin! Removed your etc.


Support particle modification

Signed-off-by: Nate Koenig<EMAIL_ADDRESS>🦟 Bug fix
Attempting to modify a particle emitter using a particle_emitter message would cause a segfault. This fixes the segfault and also allows the modification to take place.
This will allow a TriggeredPublisher to start/stop fog.
Requires: https://github.com/ignitionrobotics/ign-msgs/pull/137
To test

Save the following to fog.sdf

<?xml version="1.0" ?>
<sdf version="1.6">
<world name="fog">
  <plugin
    filename="ignition-gazebo-physics-system"
    name="ignition::gazebo::systems::Physics">
  </plugin>
  <plugin
    filename="ignition-gazebo-user-commands-system"
    name="ignition::gazebo::systems::UserCommands">
  </plugin>

  <plugin
    filename="ignition-gazebo-scene-broadcaster-system"
    name="ignition::gazebo::systems::SceneBroadcaster">
  </plugin>

  <include>
    <uri>
      https://fuel.ignitionrobotics.org/1.0/OpenRobotics/models/fog emitter
    </uri>
  </include>
</world>
</sdf>

Run the world

ign gazebo -v 4 -r fog.sdf

You should see no fog.
Start the fog using

ign topic -t "/model/fog_generator/particle_emitter/fog_generator" -m ignition.msgs.ParticleEmitter -p "emitting: {data: 1}"

You should see fog.
Stop the fog using

ign topic -t "/model/fog_generator/particle_emitter/fog_generator" -m ignition.msgs.ParticleEmitter -p "emitting: {data: 0}"

Checklist

[X] Signed all commits for DCO
[X] Updated tests
[X] codecheck passed (See contributing)
[X] All tests passed (See test coverage)
[X] While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge

looks good to me. Just need to wait for  ignitionrobotics/ign-msgs#137 and a  ign-msgs6 release

@osrf-jenkins run tests please


Handle getComputedStyle returning null

If an iframe is display:none in Firefox, window.getComputedStyle returns null.   How about this fix?

Yes, this should be merged soon!

Hello, sorry but I have not seen your "request Pull" rather.
I tried to reproduce the bug, but I can not.
Do you have an example of a website?
Also, why is it that the bait would be an "iframe"?
While default is a "div".

The problem occurs when a page using fuckadblock is embedded in an iframe that is display:none.
For example - here's a codepen with a display:none iframe, pointing to a second codepen that uses fuckadblock

At yes, I understand better. And the error is immediate!
Here we go, I merge...


Migrate existing modules to the new toolchain registration API

See https://github.com/bazelbuild/bazel/issues/15829
This:
module(
  name = "foo",
  version = "2.0",
  toolchains_to_register = ["@toolchain_repo//:toolchain"],
)

ext = use_extension("//:extensions.bzl", "ext")
ext.some_tag()
use_repo(ext, "toolchain_repo")

should become this:
module(
  name = "foo",
  version = "2.0",
)

ext = use_extension("//:extensions.bzl", "ext")
ext.some_tag()
use_repo(ext, "toolchain_repo")
register_toolchains("@toolchain_repo//:toolchain")

Is there some min,max version of Bazel where both ways are supported, to allow the transition?

The support for the old API isn't deleted at HEAD yet (the BCR presubmit uses Bazel@HEAD), but we'll probably delete them before 6.0 cut. Since Bzlmod is still under an experimental flag, I think that should be enough?
@Wyverald Do you think we need to cherry-pick recent Bzlmod changes into 5.3?

Hopefully people have been testing Bzlmod-related stuff with rolling releases (maybe we should've been clearer about that)

We've been testing across Bazel stable releases after 5.0.0.
This just broke our CI when testing against anything other than 5.3.0.
It's not a problem, we'll just drop support for 5.2.0 and below but certainly confused us for 15 minutes why the API didn't suddenly exist.
Looking forward to bzlmod becoming non-experimental: we really like it :)

To be clear, we haven't removed the old API from HEAD yet. @meteorcloudy's change merely migrated existing modules to use the new API, which is what broke you since the new API wasn't available before. (But now that that's done, I can remove the old API)
Sorry about the inconvenience!

@mattyclarkson Sorry for the confusing.
It's recommended to test Bzlmod with Bazel@HEAD, since we are making lots of improvements to it.
If you are using Bazelisk, just set USE_BAZEL_VERSION=last_green

Some are cherry-pickable (like this one) but the flag parsing ones are probably harder. Hopefully people have been testing Bzlmod-related stuff with rolling releases (maybe we should've been clearer about that)

That would be nice, I have been testing bzlmod with 5.3.0


These instructions and screenshots don't match the current user interface

These instructions and screenshots don't match the current user interface

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: cc2ee874-df45-1de2-1b30-1fd75c7fd709
Version Independent ID: ee181722-8386-9842-407f-d0549012d2e9
Content: Add and manage TLS/SSL certificates - Azure App Service
Content Source: articles/app-service/configure-ssl-certificate.md
Service: app-service
GitHub Login: @cephalin
Microsoft Alias: cephalin

@scottjreece Thanks for the feedback! I have assigned the issue to the content author to investigate further and update the document as appropriate.


@conda-forge-admin, please re-render

@conda-forge-admin, please re-render.

Hi! This is the friendly automated conda-forge-webservice.
I just wanted to let you know that I rerendered the recipe in conda-forge/altgraph-feedstock#9.


When using the reqparse.RequestParser(), App test_client throw exceptioin, while the normal start don't

Here is my demo url: https://github.com/jiamo/flask_demo
normal
python run.py
http <IP_ADDRESS>:5000/api/test testlist=='[1]'              # ok
curl "<IP_ADDRESS>:5000/api/test?testlist=%5B1%5d"  # ok

failed:
python -m tests.test_apis

Traceback (most recent call last):
File "demo/__init__.py", line 16, in get
  args_parser = self.get_parser.parse_args()
File "/usr/lib/python2.7/site-packages/flask_restful/reqparse.py", line 301, in parse_args
  value, found = arg.parse(req, self.bundle_errors)
File "/usr/lib/python2.7/site-packages/flask_restful/reqparse.py", line 161, in parse
  source = self.source(request)
File "/usr/lib/python2.7/site-packages/flask_restful/reqparse.py", line 102, in source
  value = getattr(request, l, None)
File "/usr/lib/python2.7/site-packages/werkzeug/local.py", line 343, in __getattr__
  return getattr(self._get_current_object(), name)
File "/usr/lib/python2.7/site-packages/flask/wrappers.py", line 108, in json
  return self.get_json()
File "/usr/lib/python2.7/site-packages/flask/wrappers.py", line 145, in get_json
  rv = self.on_json_loading_failed(e)
File "/usr/lib/python2.7/site-packages/flask/wrappers.py", line 162, in on_json_loading_failed
  raise BadRequest()
BadRequest: 400: Bad Request\n', u'res'

But without using RequestParser() the test is ok like my code test_demo2

I think I found the reason.  The problem is that I using 'Content-Type': 'application/json'  in GET method.
In source your code
            values = MultiDict()
            for l in self.location:
                value = getattr(request, l, None)
                if callable(value):
                    value = value()
                if value is not None:
                    values.update(value)
            return values

May be we need a try catch to continue find the another possible location.

Actually, as per RFC 2616 (HTTP/1.1), "The Content-Type entity-header field indicates the media type of the entity-body sent to the recipient". Therefore it should not be set if the body of the request is empty, which seems to be the case in your test code.
So if your requests states that a JSON-body is included, and the parser can not parse the body as valid JSON (because it is void), a response with error code 400 "Bad Request" is actually perfectly in line with the HTTP standard. As a rule of thumb: only set the Content-Type header if your method is POST or PUT.

Thanks for your explain.

Why doesn't reqparse return any meaningful error messages? Just came across this case in a more complex setup and tracing it down was a pain.


Keyboard focus is moved to end of file upon save in diff view

This seems to happen in diff views only, so to reproduce, create an empty Git repo, create a new file, and open it by double-clicking in Source Control.
Before saving:

After saving:

This does not happen with only the black extension installed:
Before:

After:

Version: 1.73.1 (user setup)
Commit:<PHONE_NUMBER>f055b99068d3688932416f2346dd3b
Date: 2022-11-09T04:27:29.066Z
Electron: 19.0.17
Chromium: 102.0.5005.167
Node.js: 16.14.2
V8: <IP_ADDRESS>-electron.0
OS: Windows_NT x64 10.0.19044
Sandboxed: No
isort v2022.8.0


Replace with nothing

Is there an easy way to omit the placeholders, and simply replace with nothing?  (Aside from regex removing things in {{}})

http://scrubadub.readthedocs.io/en/stable/advanced_usage.html#customizing-filth-markers

Hey @mattare2, sorry... right after I closed this out I realized what you were asking.
It sounds like you additionally want to get rid of the EMAIL or NAME parts as well as the {{ and }}. When scrubadub was developed, it was created from the point-of-view that omitting the context of an omitted field was "bad form", but I can see why you'd want to do this.
I can imagine accomplishing this with a few options that have to do with overriding the behavior in scrubadub.filths.base.Filth:

overriding the Filth.placeholder property to return an empty string while simultaneously setting the Filth.prefix and Filth.suffix to an empty string, as I preemptively suggested with the documentation link above.

overriding the Filth.replace_with method to return an empty string.

creating a new replace_with='nothing' keyword argument for Filth.replace_with that has the desired behavior.

Here's an example of doing this with option 2 that doesn't involve changing the scrubadub source code directly:
import scrubadub.filth.base

def replace_with(*args, **kwargs):
    return ''
scrubadub.filth.base.Filth.replace_with = replace_with

import scrubadub
print scrubadub.clean(text)

Please note that this won't work for any Filth that overrides the Filth.replace_with method, like CredentialFilth.
If you think this is a common enough use case, it would be nice to include something like option 3 as a PR, which I'd certainly welcome!

The latest version of scrubadub supports this now:
import scrubadub
scrubber = scrubadub.Scrubber(post_processor_list=[
    scrubadub.post_processors.FilthRemover(),
])
scrubber.clean("Contact me at<PHONE_NUMBER> or<EMAIL_ADDRESS>'Contact me at  or '


download error of bam bai file

Hello everyone.
I want to use Bam.iobio.io, but it says "Error downloading file Pleasecheck the URL." and I can't run it.
The procedure I did was to select Local BAM/CRAM file and specify two BAM and BAI files saved on my PC. So I don't understand the meaning of the instruction to check the URL.
This may be a rudimentary question, but please help me.

Hi @Fuji11198, the way bam.iobio works requires (portions of) the files to be streamed to our backend for processing. We have a special proxy we use for this that makes the files available via URLs, which is where the confusing error comes from. That proxy does have issues sometimes. Usually it's not broken for very long, though. Can you try running again?

Hi, ＠anderspitman
Thank you for your kind response.
I am not familiar with data processing and do not understand words like proxy well, but I will try again.
The amount of data is about 27 GB, how long does it usually take to display the results?
I may have cancelled before the process was finished.
I am sorry to keep asking this question, but I am waiting for an answer.
Thank you.


cmd: cli / repl support

Hi @fibonacci1729 ! I've used to work with a CLI framework called Cobra, What do you think to migrate the CLI/REPL part of the engine to this guy?

PS.: I'll love to work on the core, but just for me to get familiar with the codebase, I prefer to start from here...


collectd integration

Being able to send logs to collectd, which will also allow us to support services like signal fx.

+1 We need this too.

We may not need to create any new plugin for this, collectd already have a (statsd plugin)[https://collectd.org/wiki/index.php/Plugin:StatsD] which supposed to collect metrics. Will run some test to confirm this.

Hi @thefosk, can you clarify if you meant logs or metrics?

SignalFx has released a Kong collectd plugin that works in tandem with a metric aggregating Kong plugin:
https://github.com/signalfx/collectd-kong
https://github.com/signalfx/kong-plugin-signalfx
This should be functional for any collectd users via collectd-python.

Thanks @rmfitzpatrick , great contribution! I'm going to close this Issue with the assumption that the https://github.com/signalfx/collectd-kong satisfies this request.


I

Summary
1-2 sentences. Say what this is about.
Motivation and goals
1-2 paragraphs, or a bullet-pointed list. What existing pain points does this solve? What evidence shows it's valuable to solve this?
In scope
A list of major scenarios, perhaps in priority order.
Out of scope
Scenarios you explicitly want to exclude.
Risks / unknowns
How might developers misinterpret/misuse this? How might implementing it restrict us from other enhancements in the future? Also list any perf/security/correctness concerns.
Examples
Give brief examples of possible developer experiences (e.g., code they would write).
Don't be deeply concerned with how it would be implemented yet. Your examples could even be from other technology stacks.

There's no issue here.


Add selected-area clip

Contributes to #56

Remove the area-outline layers as the outline is duplicated in the areaStyle
Update the area style:

Made the outlines lighter
Removed the highlight-area background
Add stronger highlight-area outline

Mask the selected area

Extended the areas/[id] API, so it also returns the geometry of the area. While doing that, I optimised the DB query, so we’re only sending one query that returns all the data we need.
Added a mask layer, using @turf/mask, with a semi-transparent white background
Added a dark outline

Superseeded by #77


Update Docs and generated files with --project=appalias

Looks like there might be a neat way to avoid accidental deployment to the wrong target with the use of --project=appalias.
More info: https://firebase.google.com/docs/cli#use_aliases

Now Documented here: https://github.com/simondotm/nx-firebase/blob/main/docs/nx-firebase-projects.md#binding-nx-projects-to-firebase-projects


Support cell method queries

When we have cell methods in the database, we want to be able to issue something approximating plain language queries such as:
"Find me all the monthly mean data"
"Find me all the climatological monthly mean data"
and other likely combinations of cell methods queries.

Probably start by finding specific cell method strings. One option would be to copy one from a query on a variable and then find all other variables with that cell method.

We discussed this yesterday, there are several considerations which were bound up here, but aren't really cell method queries, e.g. find all the monthly mean data is a question about cell methods (mean) and frequency (monthly).  It is non-trivial to know if a dataset is monthly, at least by inspection of the time axes (coordinate and bounds) alone.  However, we determined that while it can be done, it's not a priority for now, What is a priority for now is for @davidhassell to get cf-python support for when during an aggregation, it is recognised that a) the cell extent is the same for each time-cell, and b) the cell frequency is constant. In this case we would have field variable (domain) attributes representing sampling_bound, and sampling_frequency (recognising that both may need two values for a number and units and we don't want to pack those into a string, so we may have 0, 2, or 4 attributes in play).  cfstore should then support that when the aggregation delivers it (we may have to be a bit clever about backporting for existing CANARI aggregations).


[RELENG-4539] User webhooks to trigger the manager

Codecov Report

Merging #55 (1891dc6) into main (24b5615) will increase coverage by 12.03%.
The diff coverage is 47.82%.

@@             Coverage Diff             @@
##             main      #55       +/-   ##
===========================================
+ Coverage   64.09%   76.13%   +12.03%
===========================================
  Files          20       12        -8
  Lines         674      574      -100
===========================================
+ Hits          432      437        +5
+ Misses        242      137      -105

Impacted Files
Coverage Δ

setup.py
0.00% <0.00%> (ø)

srcs/runners_manager/monitoring/prometheus.py
100.00% <ø> (ø)

srcs/runners_manager/runner/RunnerFactory.py
35.84% <ø> (ø)

srcs/runners_manager/runner/VmType.py
94.73% <ø> (ø)

...unners_manager/runner/tests/test_runner_manager.py
99.18% <ø> (ø)

srcs/runners_manager/vm_creation/Exception.py
100.00% <ø> (ø)

.../runners_manager/vm_creation/github_actions_api.py
46.42% <ø> (ø)

srcs/runners_manager/vm_creation/openstack.py
37.25% <ø> (ø)

srcs/runners_manager/runner/Manager.py
66.19% <33.33%> (ø)

srcs/runners_manager/runner/RunnerManager.py
96.77% <80.00%> (ø)

... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 24b5615...1891dc6. Read the comment docs.


Remove functions

How to test
$ ampmake build
$ amp fn
Error: not an amp command: fn
See 'amp --help
$ amp --help

Usage:	amp [OPTIONS] COMMAND [ARGS...]

Deploy, manage, and monitor container stacks and functions.

Examples:
amp version

Options:
  -h, --help            Print usage
  -s, --server string   Specify server (host:port)
  -v, --version         Print version information and quit

Management Commands:
  cluster     Cluster management operations
  org         Organization management operations
  password    Password management operations
  service     Service management operations
  stack       Stack management operations
  team        Team management operations
  user        User management operations

Commands:
  login       Login to account
  logout      Logout of account
  logs        Fetch log entries matching provided criteria
  stats       Display amp statistics
  version     Show amp version information
  whoami      Display currently logged-in user

Run 'amp COMMAND --help' for more information on a command.

Good catch


how to print sk,pk and Ciphertext？

Hi guys,
I am new and learning the SEAL example.I want to know how to save sk,pk to a file.
if possible，can you show me a few lines of code in windows to learn?    thank you very much!

Hi @DGQAQ , you may use save(std::ofstream &stream) to save any key
KeyGenerator keygen(context);
PublicKey public_key = keygen.public_key();
string strpk = "pk_file.pk";
ofstream fpk(strpk, ios::binary);
public_key.save(fpk);
fpk.close();

Hi @DGQAQ , you may use save(std::ofstream &stream) to save any key
KeyGenerator keygen(context);
PublicKey public_key = keygen.public_key();
string strpk = "pk_file.pk";
ofstream fpk(strpk, ios::binary);
public_key.save(fpk);
fpk.close();

thanks.But l don't know how to open .pk file ,I want see pk and ciphertext polynomial Intuitively and send ciphertexts to my cloud server . I am new and learning Painfully，does this library have documentations , besides comment code. thank you .

The comments in examples are the most helpful documentation at the moment. There are serialization examples. Data are serialized to a binary file which is not meant for human to read. You can load the data back to an object to print it.

i can use the examples to print the cipherfile? i failed when i use the way

i can use the examples to print the cipherfile? i failed when i use the way

Follow the examples to load an object. Then use the same method in your other comment to print it.


Get PhantomCSS to work with Travis

Issue is actually a "Public service announcement" ;)
we have created a yo generator that scaffolds apps that also include PhantomCSS, and adds an integration to Travis.
A nice thing we've added is the possibility to upload images of failed tests from Travis to a public image, which really helps debugging.
http://www.gizra.com/content/phantomcss-ui-regression/

Great stuff, thanks!


We should not support SQL Server specific syntax or features

For example, the store type varbinary(max) should not be supported. The Jet equivalent would just be a longbinary.

@ChrisJollyAU Please link the PR(s) that fixed this to this issue. Thanks!

Didn't need to make any changes as the issue wasn't an issue.
I believe this got open due to a comment I had with my PR for byte array support #228 .

LENB seems to only work properly if column is a longbinary. If has a max length set column type becomes varbinary(5) (if length is 5). In this case the return value is 6. Is this a length+1 or the closest multiple of 2 (because double byte char set as LEN returns 3)

If that was true then changing it all to longbinary would be required but further investigation showed that my original statement was wrong. longbinary and varchar(max) both work fine and LENB has the same behaviour on both

I am still finding references for varchar(max) other (max) suffixes for types in the main project. They are then all getting translated to other store types (without (max)):

JetByteArrayMethodTranslator
JetByteArrayTypeMapping
JetStringMethodTranslator
JetTypeMappingSource

Jet does not support the (max) suffix that SQL Server uses.
(There are other SQL Server specific code paths as well. For example, the JetModelExtensions class contains sequence related methods though Jet does not support sequences (AFAIK).)
So this issue should be reopened.

Are you talking about in the _storeTypeMappings variable?
That is only used when scaffolding a database (i.e. database first). The model gets created from JetDatabaseModelFactory and the store type is read from that (acquired in AdoxSchema/DaoSchema in GetDataTypeString
This is the value that is later used to match against the _storeTypeMapping. Naturally as the type is coming from the database itself you will never get varbinary(max)
If you want to do anything, just delete the respective lines.

(There are other SQL Server specific code paths as well. For example, the JetModelExtensions class contains sequence related methods though Jet does not support sequences (AFAIK).)

Correct. There are no sequences in Jet. Effectively they are just a no-op. All they do is set or get the annotation, but nowhere actually uses the annotation value

Right, that is what this issue is about. All SQL Server specific syntax references or features that are not part of Jet, should be removed from the codebase.

Not really a bug then. More just code that will never be used. Changed tag to code-cleanup

Sure, that's a first then.


[CSL-1703] Fix a memory leak in Pos.Delegation.Logic.Common

This PR fixes a memory leak in Pos.Delegation.Logic.Common, as reviewed together with @arybczak . To replicate this, I have isolated the piece of code I thought was leaking (I was lucky that it was a perfect self-contained candidate) and whipped up a small single-module which I could test with a fast turnaround. The program was replicating - in a pathological setting - the behaviour in Cardano, where we were invalidating the delegation cache by calling each second runDelegationStateAction $ invalidateProxyCaches.
This is the situation from which I started:

As you can see this exhibit the classic "exponential growth", whereas we would be expecting constant memory allocation. This is because we have X (say 100) slots available into the LRU cache, so after an initial allocation period we should see memory stabilise to the maxBound of the cache, but this wasn't the case. After adding the bang, this is how memory looks like:

Much better! The PINNED you see there is because I'm storing ByteStrings into the cache.
The icing on top
This chart looks fine, but I suggest we delve a little bit more into the lrucache package, aka we fork & maintain it up until we don't replace the current caching mechanisms. Maybe it's overkill, but there are some low-hanging fruits:

fromList is using foldr, instead of its strict counterpart. I think that being lazy here might not be the best choice as ultimately we need to consume the entire list to build the final cache anyway.

The library is not using Data.Map.Strict but its lazy version for most part, it seems for compatibility reasons, but I think we can expect in 2017 to have the majority of projects using a decently-updated version of containers. In particular, I feel that for LRU should apply the same principle of Data.Map.Strict which is that it should be strict on the spine, lazy on the values. Current implementation isn't, for no good reasons.

In the sandboxed experiments I've told you about I have done exactly this, and this is the end result, which I like better because it yields a much "fuller" memory allocation pattern (but I might be wrong, so please GHC experts do chime in 😉  -- one may argue that the first graph is better because it's allocated on demand in only that spike, whereas this second one seems to yield a bit more predictable allocation pattern. No clue which one is best!) :

Last but not least: In Cardano we have the following function in Pos.Util.LRU:
-- | Filter LRU cache by given predicate.
filterLRU :: Ord k => (v -> Bool) -> LRU.LRU k v -> LRU.LRU k v
filterLRU predicate lru =
    LRU.fromList (LRU.maxSize lru) . filter (predicate . snd) . LRU.toList $ lru

I think we can do much better if we modify the LRU type to be a Functor and even a Bifunctor, so we wouldn't need to do this "unpacking/packing" every time we want to operate on a cache.

Regarding the suggestion to maintain the fork of lrucache I'd say that i see it as useless overhead. Isn't it better to make PR with suggested changes to https://github.com/chowells79/lrucache directly?
By the way, remember that it is not possible to make Bifunctor instance of LRUCache for the same reason you can't do it with Data.Set -- methods require keys to be Ord'ed which doesn't match with Bifunctor class methods definition.

Isn't it better to make PR with suggested changes to https://github.com/chowells79/lrucache directly?

The package seems abandoned, but of course if the maintainer is able to pick our fixes up, that's 1000 times better than forking.

By the way, remember that it is not possible to make Bifunctor instance of LRUCache for the same reason you can't do it with Data.Set -- methods require keys to be Ord'ed which doesn't match with Bifunctor class methods definition.

Ah drat you are dead right, I realise just now that indeed there is the nagging Ord instance which prevents us from hitting the data structure with category theory 😬  but regardless, this shouldn't stop us from having an internal API (internal as it coded inside Data.Cache.LRU.Internal) and later exposed to application writers which would provide things like map, filter and so on and so forth (basically in the same vein as Data.Set exposes the various map, filter, etc combinators, which are implemented more efficiently than converting to & from list every time).

Apparently merging master wasn't enough. Trying to run pkgs/generate.sh as well..

Ok @fersel, I'm happy for this to be merged.

This was merged to 1.0 branch.

@domenkozar right, we'll merge cardano-sl-1.0 to master instead.


docs(migration): configure archive-test as v1.0

the archive-test branch has been configured to be an archived branch in that branch's config.toml.
This config.toml - changed params.version to use v1.0 archive-test branch. This demonstrates the "archive" banner across the top of all archived content.

preview looks good


QUESTION: What's the default user/password combination for Grafana?

I found that I can't log into Grafana using admin/[The password I gave to setup.sh], then I tried to sudo rm -rf ./storage/grafana/*, restart the Grafana container and it worked. So I guess you have set up the dashboards already so we could use this stack fast and easy, but where's the password? :)

Errr... it should be admin // admin for unsecure mode -  try that? Not sure why it is not picking up
    environment:
      - GF_SECURITY_ADMIN_PASSWORD=${PASSWORD}

in docker-compose.secure.yml anymore. Feel free to investigate.
... and thanks for the PR earlier. :)


Added Tabs for  both  near-cli-rs  and  near-cli  commands

As discussed in  https://github.com/near/docs/pull/1476.
Docs are updated with tabs for both near-cli and near-cli-rs commands .
Commands mentioned in https://github.com/near/near-cli-rs/issues/236 are yet to be changed .

You should run and check locally if everything works.
In this case, you need to import the Tabs components or else it won't show up:
import Tabs from '@theme/Tabs';
import TabItem from '@theme/TabItem';


github release

I did intend for the html to be there but it doesn't render like I was expecting so it is probably best to remove it


Cryptographic module for Android and iOS

Hello,
we are trying to use you library for a mobile app but we still struggling with find the proper Cryptographic modules for android and iOS. Do you have any suggestions? In your sample this have been mocked and for iOS you set a string.empty.
Thanks and regards

I'm not aware of any vendor providing PKCS#11 library for Android or iOS.

I'm not aware of any vendor providing PKCS#11 library for Android or iOS.

Hey Jariq,
thanks a lot for your quick reply...appreciate it.
I was looking at your repo and found this: https://github.com/Pkcs11Interop/empty-pkcs11#android. Is it something we can use and even on a production app? If you are not aware of any vendor providing PKCS#11 library for Android or iOS, would have any suggestion about how we can address this?
Regards

Closing because of 14+ days without a response.


Fixed V0.7.2

Fixed V0.7.2


Updated animated.d.ts to point to correct type references

Description:
Updated dependencies in package.json to use latest version of react-spring (9.1.2).  react-spring types used in animated.d.ts have been moved from react-spring/shared to react-spring/types The current version with the latest version of react-spring causes a build error:

https://github.com/pmndrs/react-spring/commit/d4e582a9a879a67ff3d54d41a15318dfde16cefd#diff-843ed19e8a4e3e5d73431ff372cfeb3d9dcf02742775499b93ccb84bf11633b5

Thanks @negomansini !

Published a patch 👉<EMAIL_ADDRESS>


Removed eager initialization

When running in STAGING or PRODUCTION environemnts, this object needs to
communicate with a live KMS, which makes it very difficult to test -
specifically the InjectorTest which loads each env's complete
configuration and makes sure Guice can initialize it.
Removing the .asEagerSingleton() part means that when the Cipher
object is constructed it won't need the KmsClient until first use.
There are other ways to exercise all the relevant code paths in Cipher
for testing without using a real KMS.

Is there an initialization error? If there's initialization required for a binding we usually make it a Service, which doesn't get run on injector tests. Or is this in tink and outside your control?

You might want to add in(Singleton.class) to preserve the scope. As is this is turning it from a singleton into a non-singleton (unless overridden in the implementation with @Singleton)

Closing this PR because there are other changes I'd like to introduce (https://github.com/square/misk/pull/927) and I don't see a reason to merge this by itself


Add Indian Hospital directory Api

Add Indian Hospital directory Api to Health

@matheusfelipeog waiting for maintainers to approve workflow


add dotnet.exe setting variable for zip deployed SDK

Motivation
when I want to use daily SDK build, I use zip-deployed SDK(currently, dotnet-sdk-3.0.100-*).
Currently, I must prepend custom sdk's dotnet.exe directory path to  "PATH" env.
Because environment variable may have session-global effect, I want to avoid setting PATH env.
Suggestion
adding "DotNetExePath" to EnvironmentOptions, and then use it in build.

Thanks! Very nice work.