Slow requests to multiple prometheus using HA with sidecars and query

Thanos, Prometheus and Golang version used
thanos, version 0.1.0 (branch: master, revision: 3bb4076af3fcf6d166d6690581af22cee086cc8d)
  build user:       circleci@90ace2f33852
  build date:       20181108-16:06:28
  go version:       go1.10.5

Prometheus 2.5.0

What happened
I create this infrastructure:

all infrastructure working in aws in the same network and region and connected to each other using local aws ip addresses for faster connection
install 8 different Prometheus servers for different type of data.
Every prometheus have replica for HA.
Every prometheus have uniq label for deduplication on thanos query component.
4 prometheus have 30 days retention locally
4 prometheus have retention 1 year locally to keep data federated from fist 4 prometheus with retention 30 days
each prometheus have near 3-4 millions of series
install and configure thanos sidecar on each prometheus including servers with 1 year retention
do not use thanos store and s3 storage, just thanos sidecar and thanos query for HA

All working fine and actually requests is only 1.5 or 2 times slower than directly querying prometheus, but only if using query that include result for 1-2 days. if i need to query 2 or more days in result the speed is dropping dramatically.
What i try to do to inspect the problem.

i run 1 and 2 server and the speed is the same.
then i try to run sidecar locally on prometheus to use localhost to communicate between thanos sidecar and prometheus, but result is almost the same again.

with the one query its not the big deal but if you run grafana dashboard with 10 or mote graphs its almost impossible to see result if you choose time interval bigger than 1 week, it took almost 2 minutes to load it using thanos, but querying prometheus directly dashboard loads in 15 seconds.
For 1 days interval thanos load in 15 seconds, prometheus load in 6-7 seconds. We can give you any data or info you need because its blocking us to use thanos in production right now.
I suspect that there is needed some improvements in remote read api that thanos sidecar use to query prometheus, but i am not sure. Can you guys help to investigate and navigate how we can improve the code and what the problem may be.
What you expected to happen
I expected to see dropping of speed will be the same for all intervals of query comparing to prometheus directly
How to reproduce it (as minimally and precisely as possible):
Just run data for bigger than 1 week and install sidecar and query thanos component, and try to run query for bigger than 1 week
Full logs to relevant components

Anything else we need to know

I am guessing thanos querier is on some remote cluster right?
I think you are definitely hiting the issue of basically high volume of data between thanos querier and prometheus. As you seen in your experiments that you provided on slack channel some of the data like:
d.lukyanchikov [5 days ago]
No  problem with numbers, run all locally, prometheus 2.5.0, thanos-query and thanos-sidecar all  configured to conenct thru localhost interface on one host. The query `count(job:node_cpu_usage_percentage:irate5m)` for 4 weeks on prometheus run near 2 seconds, on thanos near 27 seconds

The single request was taking 600 MB between thanos querier and prometheus (and sidecar in between). And all adds up:

just raw one series for 4w takes ~2.5MB with 15s interval (compressed ~0.4 MB)
raw samples for 2640 series, 4w is 6600MB
after snappy compression (11-12x) it is ~600MB

This means that for your high number of series and samples (4w means 161 280 samples just for one series!), just sending it between cluster takes time, not mentioning deduplication for this number of samples.
We can definitely investigate the hot path and check the latency of every step in the query to check where it spends the most time. For this I would suggest using tracing we have built in Thanos (we can instrument it even further to make sure every we have enough spans). Thanos uses stackdriver, which you can quickly set up, but of course we can think about moving to open census for more flexibility.
Definitely stream Remote read will improve latency and used memory by sidecar as we potentially don't need to encode/decode all which can take.. for example:
Assuming one sample can be encoded in ~20 nanosec (rough assumption) for your query it is ... 10s spent just in sidecar (:
But even with fixes here & there, except the Remote Read and Distributed Query (which is really difficult to achieve), there is no other solution than... Downsampling!
Which Thanos offers only if you use compactor + long term storage. It might be the solution that will help for you if you have so huge volume.
There are some users who uses Trickster for caching query results with some successes, you might want to look on this as well.


Welcome Page Bug: Change content to storage

Welcome Page Bug: Change content to storage
content

to
storage

Fixed


ADref and ADalt switched

Not sure where this happened because the previous line of code for the WSNRAF is correct...so it's a nonsensical error on my end. Should have only affected my work with the EHH (and reversed the colors on my plots).
Fixed now. Error catch also needed a quick change. Conflicts are due to old documentation. This would be 3-10 keystrokes to fix yourself. Sorry

will update with new


chore(main): release 2.4.0

:robot: I have created a release beep boop
2.4.0 (2023-04-22)
Features

better network message filters (c39d590)
bottom navigation view of devices (56ddeab)
discovery auto-notify devices (5b6a3c9)
link to github repo (1c9a00e)
new message log format (2978499)

Bug Fixes

hide presentation button when no url (c3b2980)
open proper source URL (dfdbb43)
setting tile icon color (41b4173)

This PR was generated with Release Please. See documentation.

:robot: Release is at https://github.com/huffSamuel/upnp_explorer/releases/tag/v2.4.0 :sunflower:


Upgrade gradle and lib versions.

The app didn't built. I've upgraded to a new version of libraries and tools, it forced me to enable multiDex. Then I've encountered the  'duplicate entry for common.annotations.Beta' error. I've fixed it by modifying the build.gradle file.

@orian according to Travis your changes make build to fail. Could you review changes?

I believe it's not possible to merge at this point. The Travis available version of libraries is older than the updated one. Can we make the PR wait for some time? I think someone may want to use it.

Please squash commits and do a force push. I see that your changes in travis are OK so we need to launch new travis job to check the result.

I've squashed commits. Sorry it took so long.


Optionally log errors

Not all log are errors and it is useful to differentiate when something goes wrong when everything is ok

Why isn't that useful? If you add a new server, you want to know whether a pool was created or not

@neumino I'm confused, are you saying console.error is necessary to know if the pool was created? Why can't console.log work?

@neumino when use rethinkdbdash in a child proccess, a console.error redirect messages to stderr, not to stdout, this is a ploblem, because the stderr can be used to dispatch an alert, log activity, trace execution and eventually restart the child process, i agree that log new pool connections is useful, but this is not an error, is a desired task.
For this reason not removes the line of the log, only change the target of this message from stderror to stdout.

Why can't stderr dispatch an alert? Isn't that an issue with your paging system?  You can also just use the log event if you don't want everything to go to stderr.
If you want to change the core/default behavior, please submit a proposal to classify all messages in debug/info/warn/error.
So far no one has proposed a clean API - feel free to reopen https://github.com/neumino/rethinkdbdash/issues/325 if you want

I had started to spec out an API for this in https://github.com/neumino/rethinkdbdash/issues/334#issuecomment-293423825. That's probably a good starting point if anyone wants to submit a formal proposal.

Check out #355 as the follow-up to this PR. 😄


fix localisation helper

Codecov Report
Patch coverage has no change and project coverage change: -0.71 :warning:

Comparison is base (63a7161) 82.03% compared to head (1f60bf1) 81.33%.

:exclamation: Current head 1f60bf1 differs from pull request most recent head cf71f73. Consider uploading reports for the commit cf71f73 to get more accurate results

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #693      +/-   ##
==========================================
- Coverage   82.03%   81.33%   -0.71%
==========================================
  Files          27       19       -8
  Lines         668      584      -84
  Branches      120      109      -11
==========================================
- Hits          548      475      -73
+ Partials      120      109      -11

see 8 files with indirect coverage changes
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


How Do I Reach Out Shakepay Support Number

How can I recover my Shakepay account? If you need to recover your Shakepay account, you can contact their customer service hotline at +1-(209)-798-6943 or +1-(209)-798-6943 USA for assistance in the recovery process.
How to contact Shakepay Manager? You can access live chat by clicking the "Contact Us" ☎+1-(209)-798-6943 button in the help center and then selecting "Chat." Phone: Shakepay also offers phone support for urgent issues. You can call Shakepay at ☎+1-(209)-798-6943 for Quick response & Support. There are in brief ways to talk to someone on Shakepay.
Does Shakepay have a live chat? Yes, Shakepay does offer a live chat option for customer support. To access the live chat feature:
Go to Shakepay's Help Center on the platform.
Look for the "Contact Us" ☎+1-(209)-798-6943 option.If you are trying to reach Shakepay Support +1-(209)-798-6943 (24/7), the only Shakepay phone number is ☎+1-1-(209)-798-6943 (24/7) or +1-(209)-798-6943 USA for Quick response & Support. You can also access live chat by clicking the "Contact Us" button in the help center and then selecting "Chat."
Choose the chat option to speak with a live person.
You can also contact Shakepay support at ☎+1-(209)-798-6943 (Talk with Human) & (☎+1-(209)-798-6943 (Contact-USA)).
Follow the prompts to describe your issue and get assistance.

Closing this issue as spam.


Link is dead on page

The link to the financial dimension whitepaper is dead.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 9cd46bd8-b305-8e61-c0cb-4373de8c96f0
Version Independent ID: b2101cbc-7f68-bddc-6c38-6786b7c0f582
Content: Implementing the Account and Financial Dimensions Framework (White paper)
Content Source: dynamicsax2012-technet/implementing-the-account-and-financial-dimensions-framework-white-paper.md
Product: dynamicsax-2012
GitHub Login: @Khairunj

The link opens the white paper that is found at this address: https://go.microsoft.com/fwlink/?linkid=213133. The link opens a file, which you can download and does not open a new window. Most likely the file download is located at the bottom of your browser.

The link opens the white paper that is found at this address: https://go.microsoft.com/fwlink/?linkid=213133. The link opens a file, which you can download and does not open a new window. Most likely the file download is located at the bottom of your browser.


Euler's totient Function

Euler's totient Function
what will change -
Type of Issue -

[x] Adding New Code

Programming Language
Please add/delete options that are not relevant.

[x] C++

Self Check

Ask for issue assignment before making Pull Request.
Add your file in the proper folder
Clean Code and Documentation for better readability
Add Title and Description of the program in the file

Happy Coding,

@cp1307 Create a new folder in C++/Algorithms and name it Mathematical Algoritms and add your files there.


GitHub 611: Fix dynamic offset indexing

Fix #611

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.

Good catch. Fix pushed to master, thanks!


Add syntax highlight support for PostScript language

VSCode Version: 1.17.2
OS Version: Windows 10 x64 Pro 1709 Build 16299.19

Steps to Reproduce:

open a postscript file
Click on [Plain Text] at the bottom and type PostScript
No result for postscript...

Reproduces without extensions: Yes/No

For syntax highlighting the files from textmate could be used. This one looks also good, is newer than the files from the other repo.

@wstaelens Would this okay for you?

sure, better this than nothing 👍

I will make an extension and notify you once it is released.

Great, thanks!

Extension is published, just search for PostScript.

Thanks, may be closed. works perfectly! You guys rock!

You can close it yourself, just press the Close issue button. :smiley:


Links to Job Details don't work when requireAuth is set to true or auto

Description
When viewing logs in Log-Viewer we also have the ability to click through to the job details of any given job that is in the audit logs. The issue for a certain project where I have access to view logs and view job details (but where requireAuth is not false) is that when I login via the sidekick, I am able to view logs, but when I click through to the job details link, I get a 401 and then need to also login to admin.hlx.page/login for those links to work.
Related Issue: https://github.com/adobe/helix-tools-website/issues/34
To Reproduce
Steps to reproduce the behavior:
**Flow 1**

1. in a new browser window, go to https://tools.aem.live/tools/log-viewer/index.html and put in https://main--<byom site>--aemsites.aem.live/ and submit
2. get a 401, tells me login via sidekick
3. go to https://admin.hlx.page/login and login
4. log viewer still gives me a 401

Why doesn't this work? Is logging into sidekick and logging into admin service fundamentally different?

**Flow 2**

1. in a new browser window, go to https://tools.aem.live/tools/log-viewer/index.html and put in https://main--<byom site>--aemsites.aem.live/ and submit
2. get a 401, tells me login via sidekick
3. got to https://main--<byom site>--aemsites.aem.live/ and login with sidekick
4. log viewer no longer 401s, but if I click on a code link referenced from a log that gives me a 401
5. now go to https://admin.hlx.page/login and login
6. now the code link works

why is this different than above? aren't logging into sidekick and logging into admin service fundamentally the same thing?

**Flow 3, a combo of both:**

1. in a new browser window, go to https://tools.aem.live/tools/log-viewer/index.html and put in https://main--<byom site>--aemsites.aem.live/ and submit
2. get a 401, tells me login via sidekick
3. go to https://admin.hlx.page/login and login
4. log viewer still gives me a 401
5. go to https://main--<byom site>--aemsites.aem.live/ sidekick tells me I am logged in
6. log viewer still gives me 401

Expected behavior
Once I login via the sidekick to my project, as long as my role and permissions assigned correctly, I should be able to view audit logs and job details without having to login to anything else.

Putting this on hold after a convo with @rofe and try and get log-viewer to use fetch for the data rather than send the user directly to the job details.
cc: @shsteimer

Fixed this in Log Viewer https://github.com/adobe/helix-tools-website/pull/37


Update file-juicer to 4.64

After making all changes to the cask:

[x] brew cask audit --download {{cask_file}} is error-free.
[x] brew cask style --fix {{cask_file}} left no offenses.
[x] The commit message includes the cask’s name and version.

https://www.virustotal.com/#/file/184236048e1e687d9b3717231644f08bc5ed6b3469393da89ed6c8f17510cd35/details


Understanding noise in depth map in NeusFacto v.s. MonoSDF

So I've been trying to understand how NeusFacto compares to other methods specifically for indoor. I've noticed that for NeusFacto does a much better job in image quality, but there's a strange amount of noise specifically in the depth reconstruction. I've shared examples on a room I captured using Polycam.
https://api.wandb.ai/report/pablovela5620/psjincx1
Would love to know if ya'll have any insight on this. Is this mostly a problem with the rendering method of Neus v.s. VolSDF?
I also noticed this issue when I tried experimenting with Highres tanks and temples on Neus-facto v.s. monosdf.
Heres NeusFacto

and here's MonoSDF

Hi, are you using the same network configurations for all of them? Looks like you are using feature grid for neus-facto while using pure MLP for all others?

looks like they're all using hashgrid. This is what the config.yml file looks like for all of the runs

Though I did notice that the background model for Neus-Facto is None while for all others its MLP. Are you talking about the sdffield? or the background model

Hi, I mean the use_grid_feature in sdf_field. It's false in your screenshot. I think I should update it so that we can set encoding_type to none when we don't want use feature grid. Now it's a little bit confusion because we have two attribute use_grid_feature and encoding_type.

Ah okay I see, yea. So that swirl type pattern that seems to appear in the depth images is due to using the hashgrid instead of the MLP? Is this something that goes away with enough iterations? From some testing I was doing it seemed to lead to some floater artifacts, I remember in the MonoSDF paper reading that MLP gives slightly better accuracy v.s. hashgrid. Is this where that shows up?

Hi, I think it gets better in the end if the model converges but the artefacts won't completely go way. Yes, we found in MonoSDF that feature grids tends to produce noise results or artefacts compared to pure MLP, but it also converges faster and brings more details. It's a trade off here and maybe we need better regularization.

Understood, thank you for the insight. I'll do some more investigation/testing.

I did find this in the recent NeuS2 paper

Seems like an interesting potential direction. Would love to see both NeuS2 and NeuRIS integrated into SDFStudio

So I've been trying to understand how NeusFacto compares to other methods specifically for indoor. I've noticed that for NeusFacto does a much better job in image quality, but there's a strange amount of noise specifically in the depth reconstruction. I've shared examples on a room I captured using Polycam.
https://api.wandb.ai/report/pablovela5620/psjincx1
Would love to know if ya'll have any insight on this. Is this mostly a problem with the rendering method of Neus v.s. VolSDF? I also noticed this issue when I tried experimenting with Highres tanks and temples on Neus-facto v.s. monosdf.
Heres NeusFacto
and here's MonoSDF

Hello, I would like to ask how to export depth map in sdfstudio, does it provide an interface?


ci: macos-latest is changing to macos-14 ARM runners

Committed via https://github.com/asottile/all-repos

3.8 was added, probably okay now.


[chore](routine load)  make error msg clear if routine load name illegal (#40037)

pick (#40037)

run buildall


[BUG] Lua Linter setup

Describe the bug
This is not exactly a bug, but I don't see a better choice for where to put this.
The instructions for installing luac on Mac should be: brew install lua
Also, I have installed Visual Studio Code, lua (including luac), and lualinter. It says it is running in Visual Studio Code, with the default options. And my Code explorer shows the Lua Scripts folder that contains luaconfig.config. But I'm getting no de-linting joy. Any ideas?

Ok, I'll update the markdown file.
If you go to preferences (⌘ comma), is "Format on Save" turned on? If not, that's likely the issue. I'm also adding that to the markdown file.

All three of Format on Save, Paste, and Type were unchecked. But I'm still
not getting the love.
On Tue, Jun 9, 2020 at 6:40 PM Nick Mazuk<EMAIL_ADDRESS>wrote:

Ok, I'll update the markdown file.
If you go to preferences (⌘ comma), is "Format on Save" turned on? If not,
that's likely the issue. I'm also adding that to the markdown file.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/Nick-Mazuk/jw-lua-scripts/issues/5#issuecomment-641635959,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ACYB6X2TDKBWOCDSTLSYD73RV3B3PANCNFSM4NZ3DIRA
.

I mean, I'm still not getting the love after checking them.
On Tue, Jun 9, 2020 at 6:58 PM Robert Patterson<EMAIL_ADDRESS>wrote:

All three of Format on Save, Paste, and Type were unchecked. But I'm still
not getting the love.
On Tue, Jun 9, 2020 at 6:40 PM Nick Mazuk<EMAIL_ADDRESS>wrote:

Ok, I'll update the markdown file.
If you go to preferences (⌘ comma), is "Format on Save" turned on? If
not, that's likely the issue. I'm also adding that to the markdown file.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/Nick-Mazuk/jw-lua-scripts/issues/5#issuecomment-641635959,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ACYB6X2TDKBWOCDSTLSYD73RV3B3PANCNFSM4NZ3DIRA
.

I'm getting some formatting, but it seems to be generic. Like it
automatically maintains the indent levels for if end, for end, etc. But it
does not change the formatting if you put an if statement on a single line.
On Wed, Jun 10, 2020 at 12:21 PM Nick Mazuk<EMAIL_ADDRESS>wrote:

Hmm…
I'm not sure why it's not working.
The only thing I can think of is that perhaps you are already writing
formatted code?
If you want to test this, try using this line of code:
if variable<2 then print('hello') end
It should turn into
if variable < 2 then
print("hello")

end
@CJGarciaMusic https://github.com/CJGarciaMusic Have you used the
linter? If so, anything else you had to do to set it up?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/Nick-Mazuk/jw-lua-scripts/issues/5#issuecomment-642147918,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ACYB6X4ANQXN2TEM24V5YZTRV66FTANCNFSM4NZ3DIRA
.

Interesting. Honestly, I don't know what's causing that. I had no trouble with the setup myself. I've tried to replicate the issue on my end, but I haven't been able to.

I may have written about the wrong plugin…
In short, I was wondering why my code formatting wasn't working anymore for Lua files and had to debug it. The lua-linter extension did not seem to be formatting the code. Instead, I had another extension called vscode-lua-format which formats the code.
This extension was already installed for me, but I had to add this to VS Code's settings.json
"[lua]": {
    "editor.defaultFormatter": "Koihik.vscode-lua-format"
},

So my guess is that to get the code formatting, you need to:

Install vscode-lua-format
Add the above snippet to your settings.json

If this works for you, I'll update the docs.

Remind me how to tell if it's working. Also, the settings.json I found was
in
~/Library/Application Support/Code
Adding it to that didn't seem to make any difference. Is there another
settings.json?
On Fri, Jul 30, 2021 at 9:43 PM Nick Mazuk @.***> wrote:

I may have written about the wrong plugin…
In short, I was wondering why my code formatting wasn't working anymore
for Lua files and had to debug it. The lua-linter extension did not seem
to be formatting the code. Instead, I had another extension called
vscode-lua-format which formats the code.
This extension was already installed for me, but I had to add this to VS
Code's settings.json
"[lua]": {
"editor.defaultFormatter": "Koihik.vscode-lua-format"

},
So my guess is that to get the code formatting, you need to:

Install vscode-lua-format
https://marketplace.visualstudio.com/items?itemName=Koihik.vscode-lua-format
Add the above snippet to your settings.json

If this works for you, I'll update the docs.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/Nick-Mazuk/jw-lua-scripts/issues/5#issuecomment-890280096,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ACYB6XZXIB2RDLXH65JF4WTT2NPL5ANCNFSM4NZ3DIRA
.

If everything is working, this…
if variable<2 then print('hello') end

…should be reformatted to this when you save:
if variable < 2 then
    print("hello")
end

If it is not formatted, you can try to manually trigger the format. The easiest way is to use the command palette (⌘⇧P) and type/select Format Document.

For the settings.json, I'm not 100% sure where it is on the disk. I always open it through the command palette (⌘⇧P) and select Preferences: Open Settings (JSON) to edit it straight in VS Code.

Can you show me the thing I need to add to settings.json in context? For
now, I've installed the vscode_lua_format thing, but I'm still not getting
any formatting.
Thanks,
Robert
On Sat, Aug 7, 2021 at 11:23 AM Nick Mazuk @.***> wrote:

If everything is working, this…
if variable<2 then print('hello') end
…should be reformatted to this when you save:
if variable < 2 then
print("hello")

end
If it is not formatted, you can try to manually trigger the format. The
easiest way is to use the command palette (⌘⇧P) and type/select Format
Document.
For the settings.json, I'm not 100% sure where it is on the disk. I always
open it through the command palette (⌘⇧P) and select Preferences: Open
Settings (JSON) to edit it straight in VS Code.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/Nick-Mazuk/jw-lua-scripts/issues/5#issuecomment-894675062,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ACYB6X3TBPYGSPCPPOGNEADT3VMT3ANCNFSM4NZ3DIRA
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&utm_campaign=notification-email
.

Hate to beat a dead horse, but I was playing around with a new folder structure for Lua scripts this weekend and found out that this setting must be set for code formatting to work.
The formatter seems to not automatically pick up the config file.

Just created PR https://github.com/finale-lua/lua-scripts/pull/156 which includes all my relevant settings and extensions for this repo.
(or at least I think it has all my relevant settings and extensions).

I applied the settings from the files in PR #156 and I now have Lua linter function in VS Code. It is complaining that it can't find the file ./luaconfig.config. Is that something that should be added to the Pull Request?

A new issue I'm having is that it is adding in spurious line breaks when I save. Is there a setting to prevent this?

Never mind. I found ./luaconfig.config (lol) and it also addressed the spurious line breaks.

Great! Glad you finally got it working and figured out those issues. Is it time to close this issue?


Update shortcuts-search extension

Description
Added new command "Show shortcuts for the frontmost web page". Fetches shortcuts for current active browser page.
Note: it doesn't support Firefox.
Checklist

[x] I read the extension guidelines
[x] I read the documentation about publishing
[x] I ran npm run build and tested this distribution build in Raycast
[x] I checked that files in the assets folder are used by the extension itself
[x] I checked that assets used by the README are placed outside of the metadata folder

@pernielsentikaer https://fastmail.com/ is the only example currently, see https://github.com/solomkinmv/hotkys/blob/72fce2a27582eb9488ba817a456d3ac13005061a/shortcuts-disco-site/shortcuts-data/fastmail.json#L4 and this search: https://github.com/search?q=repo%3Asolomkinmv%2Fhotkys+hostname+path%3A%2F^shortcuts-disco-site\%2Fshortcuts-data\%2F%2F&type=code
I've been contributing some desktop shortcuts to this dataset already, and also want to add web shortcuts for Figma, Slack, Whimsical, Notion, Penpot, Tally.so, ... in the near future.

Could it be an idea to update the README (and changelog in this case) to let users know its only for fastmail right now?

The database is more dynamic than the extension, so I’d prefer to omit listing the exact web apps. However, I can explain how it works in the README.
Moreover, I can add a command to display the list of supported web apps. What do you think?


cfssl: 1.5.0 -> 1.6.0

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://github.com/cloudflare/cfssl/releases.
meta.description for cfssl is: "Cloudflare's PKI and TLS toolkit"
meta.homepage for cfssl is: "https://cfssl.org/"
meta.changelog for cfssl is: ""
Updates performed

Golang update

To inspect upstream changes

Release on GitHub

Compare changes on GitHub

Impact

Checks done (click to expand)

built on NixOS

The tests defined in passthru.tests, if any, passed

/nix/store/8llb2prabqnlkk1q7jkgdlb7rf23f56k-cfssl-1.6.0/bin/cfssljson passed the binary check.

/nix/store/8llb2prabqnlkk1q7jkgdlb7rf23f56k-cfssl-1.6.0/bin/cfssl passed the binary check.

/nix/store/8llb2prabqnlkk1q7jkgdlb7rf23f56k-cfssl-1.6.0/bin/cfssl-bundle passed the binary check.

/nix/store/8llb2prabqnlkk1q7jkgdlb7rf23f56k-cfssl-1.6.0/bin/cfssl-scan passed the binary check.

/nix/store/8llb2prabqnlkk1q7jkgdlb7rf23f56k-cfssl-1.6.0/bin/cfssl-certinfo passed the binary check.

/nix/store/8llb2prabqnlkk1q7jkgdlb7rf23f56k-cfssl-1.6.0/bin/cfssl-newkey passed the binary check.

/nix/store/8llb2prabqnlkk1q7jkgdlb7rf23f56k-cfssl-1.6.0/bin/multirootca passed the binary check.

/nix/store/8llb2prabqnlkk1q7jkgdlb7rf23f56k-cfssl-1.6.0/bin/mkbundle passed the binary check.

8 of 8 passed binary check by having a zero exit code.

3 of 8 passed binary check by having the new version present in output.

found 1.6.0 with grep in /nix/store/8llb2prabqnlkk1q7jkgdlb7rf23f56k-cfssl-1.6.0

found 1.6.0 in filename of file in /nix/store/8llb2prabqnlkk1q7jkgdlb7rf23f56k-cfssl-1.6.0

directory tree listing: https://gist.github.com/4458391f4a5b514f251cf57415764846

du listing: https://gist.github.com/35371f29ea9ebb691d405b8173f32cbb

Rebuild report (if merged into master) (click to expand)

4 total rebuild path(s)

1 package rebuild(s)

1 x86_64-linux rebuild(s)
1 i686-linux rebuild(s)
1 x86_64-darwin rebuild(s)
1 aarch64-linux rebuild(s)

First fifty rebuilds by attrpath
cfssl

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/8llb2prabqnlkk1q7jkgdlb7rf23f56k-cfssl-1.6.0 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A cfssl https://github.com/r-ryantm/nixpkgs/archive/acb4c290de547a296ebe7356cd3112766966b57d.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/8llb2prabqnlkk1q7jkgdlb7rf23f56k-cfssl-1.6.0
ls -la /nix/store/8llb2prabqnlkk1q7jkgdlb7rf23f56k-cfssl-1.6.0/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

1 package built:

cfssl

Maintainer pings
cc @mbrgm @kalbasit for testing.

Result of nixpkgs-review pr 125844 run on x86_64-linux 1

1 package built:

cfssl


Add Github Action for CI

This commit adds a github action to try to run basic validation on every PR for CI purposes. It is meant to replace the travis-ci setup.
Two workflows are managed by these changes:

CI : Basic linux based make run. Checks if the module still compiles. Migrated from Travis
IIS-tests : Windows IIS based ftw test suite run. Checks if the module works on IIS and if the ruleset tests pass.

new file:    .github/workflows/main.yml

Triggers set to pushes and pull_requests for waf_nginx branch
Logs into Azure Container Registry to fetch build environment container image
Runs make commands inside the docker-compose generated environment

new file:   .github/workflows/tests.yml

Triggers set to pushes and pull requests for waf_nginx branch
Starts IIS and publishes modsec package to IIS
Runs ftw tests on IIS with modsec.
Set ftw version to v1.1.7 specifically in the buildscript

modified:   iis/build_dependencies.bat

Remove hardcoded path for 7-zip.
7zip is dynamically managed by the build.

modified:   iis/build_release_amd64.bat

Change vcvars path for VS 2019 compatibility.
Older versions aren't available on Github Actions.

deleted:   appveyor.yml, .travis.yml

Delete files. The contents have been translated to github actions.

Some notes for the record, I tried running the tests in a python3 env, but none of it worked. 3.10 has breaking changes that doesn't even allow ftw. 3.7 can install ftw v1.2.3 but test runs fail because of dependencies on libraries not present in this version.
This is currently built on top of a windows-2019 IIS server environment that happens to have an old python 2 installation hidden away apart from mainline python3.7.


Claire maven.assign1

Assignment is ready for review.
Thank you!

Great work, Claire.

Hello Kelvin,
Am a little confused, I only have one branch and there's nothing on #13. So what am I merging??


Add cost column to subgraph_deployments table

Resolves #619

@Jannis happens automatically :)
The DEFAULT 1 column constraint applies to future insertions too, not just the initial column creation


chore: latest guava

I've noticed that there are Guava versions from 2017 used.
I guess dependabot might have trouble comparing versions like "23.0" and "30.0-jre", or it ignores versions with suffixes.

Interesting find! It looks like just today dependabot has raised some guava PRs, although I don't remember ever seeing it do so before.
Thank you, but as dependabot seems to be raising these PRs I'll merge those to keep things consistent.

@rnorth I was wrong - dependabot can tackle guava updates. But there are 4 modules under "examples" that still use guava 23.0. I presume those are excluded from dependebot updates.
Should those be included in dependabot scans?


Multiple methods definition

Is your feature request related to a problem? Please describe.
I use go-chi and I have an endpoint which can handle all http method.
I want to describe it to see it in swagger.
ex:
r.HandleFunc("/*", controller.RewriteURL(shadowCompareHandler, rewriteRule))

Describe the solution you'd like
I would like to be able to configure the router option with all the method it supports.
// @Router / [get, post, put, options]

Describe alternatives you've considered
I have considered creating a fake handler for each method but it becomes verbose and doesn't bring value.

The option to describe a single route with many options does not get any real benefit if you are really building a RESTfull sevice.
in most cases, the routes need additional parameters that you will want to be defined per method. (which is not possible) .
In the end, you will require an expert to define the annotations in order to get the right definitions.
As a work-around you can copy the same definition on top of additional 3 empty handlers and you will get the same result.

My use case is that I created a proxy endpoint that can shadow traffic, in that case, it should manage every method.
I can use 3 empty handlers but it will add some code that does nothing and it will be hard to understand for future contributors.

@thomaspoignant I perfectly understand your case but the documentation won't reflect the true get/post/put request/response pair.


Target of URI doesn't exist when importing Font awesome package in Windows 10

Hi, I am facing an issue whenever I tried importing the font-awesome package in my project. The flutter can't analyze the package correctly and throwing an error "Target of URI doesn't exist"
Package Name: font-awesome-flutter
Version: ^8.8.1
Import declaration: import 'package:font_awesome_flutter/font_awesome_flutter.dart';
IDE: Android Studio 3.6.3 latest build
Flutter Channel: Master build 2.9.0-7.0.dev 617bc54b71
OS: Windows 10 Home 64
reproduce:

Put font_awesome_flutter: ^8.8.1 under dependencies in pubspec.yaml
Run flutter pub get in the terminal
Declare package : import 'package:font_awesome_flutter/font_awesome_flutter.dart';

The import 'package:font_awesome_flutter/font_awesome_flutter.dart'; will show a red line and an error when hovered.

pudspec.yaml
  font_awesome_flutter: ^8.8.1

pubspec.lock
font_awesome_flutter:
dependency: "direct main"
description:
name: font_awesome_flutter
url: "https://pub.dartlang.org"
source: hosted
version: "8.8.1"

Hi, I tried to uninstall and re-install the package. It now works. I will close this ticket now. Thanks


[Feature Request] PassKeys API

Describe the bug

Passkeys are the future of authentication, and for good reason! They're incredibly easy to use and intuitive, eliminating the need for complicated password creation processes and the hassle of remembering them. Plus, they're unique to each website or application, so you don't have to worry about someone using your passkey to access other services. And unlike passwords, passkeys are resistant to phishing attempts, making them a much more secure option. Best of all, you can use your passkey across all your devices, so you never have to worry about forgetting your password again!

Unfortunately, there is no information on how to use it with c#/winui (I couldn't find it).
So it is very exciting to have API for it.
https://support.microsoft.com/en-us/windows/passkeys-in-windows-301c8944-5ea2-452b-9886-97e4d2ef4422
Packaging type
Packaged (MSIX), Unpackaged
Windows version
Windows 11 version 22H2 (22621, 2022 Update)
IDE
Visual Studio 2022

Hey @ddsilva-msft - do you have anything coming as API support for Passkeys in apps? There's the https://learn.microsoft.com/windows/win32/api/webauthn/ API surface, but I don't see a WinRT variant for direct app use.

👋
Curious, has there been any updates in regards to Passkey support for developers on Microsoft's side?
It seems odd for Microsoft to tout passkey support yet offer not a single page of documentation for developers? From the looks of it, no actual support either? Outside of the webauthn API in win32.

@huwaireb Could you please let me know, what you have done to get it working.

@huwaireb Could you please let me know, what you have done to get it working.

I've dropped WinUI 3 outright, so i can't help you apologies. You'll have to generate the bindings using CsWin32 for WebAuthn.* methods first.
Now the issue is there's no official Microsoft example on the use of the API, so your best luck is browser implementations. Chromium, Firefox and the like.
There's a fairly old repo ~5 years in C++ that extracts the firefox implementation here: https://github.com/aseigler/HelloSample/tree/master.
May serve to be helpful, there's also a newer go version: https://github.com/Ink-33/authn. I can't say about their reliability, but these are your best bets unless you want to use https://sourcegraph.com/ to scour through the browsers codebases, which I recall doing ;c.
best of luck

Thanks @huwaireb


useFakeTimers isn't working for the setInterval.

Environment
System:
    OS: Linux 5.15 Ubuntu 20.04.6 LTS (Focal Fossa)
    CPU: (8) x64 Intel(R) Core(TM) i5-10210U CPU @ 1.60GHz
    Memory: 7.71 GB / 15.38 GB
    Container: Yes
    Shell: 5.0.17 - /bin/bash
  Binaries:
    Node: 20.11.1 - ~/.nvm/versions/node/v20.11.1/bin/node
    npm: 10.2.4 - ~/.nvm/versions/node/v20.11.1/bin/npm
  Browsers:
    Chrome: 112.0.5615.49
  npmPackages:
    vitest: 1.6.0 => 1.6.0

Reproduction
Non-working code with setInterval -
  describe('Testing timers', () => {
    let triggered = false;
    beforeAll(() => {
      vi.useFakeTimers();
      setInterval(()=>{
        triggered = true;
      }, 1000)
    });
    afterAll(() => {
      vi.useRealTimers();
    });
    it.only('Should trigger the timer', () => {
      vi.advanceTimersByTime(1000);
      expect(triggered).toEqual(true); // Fails. triggered = false here
    });
  });

Working with setTimeout
  describe('Testing timers', () => {
    let triggered = false;
    beforeAll(() => {
      vi.useFakeTimers();
      setTimeout(()=>{
        triggered = true;
      }, 1000)
    });
    afterAll(() => {
      vi.useRealTimers();
    });
    it.only('Should trigger the timer', () => {
      vi.advanceTimersByTime(1000);
      expect(triggered).toEqual(true); // Successful.
    });
  });

Reproduction - https://stackblitz.com/edit/github-agxb9y-xks33q?file=test%2Fapp.nuxt.spec.ts
Works without nuxt - https://stackblitz.com/edit/vitest-dev-vitest-hr7i1i?file=test%2Ftimer.test.ts
Describe the bug
setInterval isn't triggering with fakeTimer, however setTimeout does. I have tried advanceTimersByTime, advanceTimersToNextTimer and runAllTimers but doesn't help.
Note - I don't find this issue with the Vitest itself. using defineVitestConfig is causing this behaviour.
Additional context
No response
Logs
No response

When I tried with window.setInterval, this works. As per the above reference, it seems like we have defined our own setInterval. Is there any config in the nuxt to prevent that?

Using window.setInterval is definitely not a good idea.
If users are not familiar with Nuxt's implementation details, they will be very confused about why tests fail when using setInterval.
Before seeing this issue, I spent a lot of time debugging this problem.
If Nuxt has wrapped the original setInterval, then this issue should be handled properly to allow users to directly call setInterval.


Update to Xcode 16b6

[x] install new Xcode version on builders
[x] Update spi-images https://gitlab.com/finestructure/spi-images/-/merge_requests/36
[x] update builder https://gitlab.com/finestructure/swiftpackageindex-builder/-/merge_requests/309

[x] SwiftVersion.xcodeVersion
SwiftVersion.dockerImage doesn't need changing, this is done via spi-images

Run #11 is under way.


In-cluster API access

Question/Freature request.
With kubectl or certain clients k8s allows to access to cluster from within pod. Is it possible to use ksonnet from within cluster to create resources?
https://kubernetes.io/docs/tasks/access-application-cluster/access-cluster/#accessing-the-api-from-a-pod

Alternative would be to write k8s manifests to file (or stdout) and kubectl create -f them.

Figured it out:)
 ks env add default --token=$(cat /var/run/secrets/kubernetes.io/serviceaccount/token) --server=https://${KUBERNETES_SERVICE_HOST}:${KUBERNETES_SERVICE_PORT_HTTPS}
ks apply default --token=$(cat /var/run/secrets/kubernetes.io/serviceaccount/token)

Thanks inc0 for figuring this out. It's really helpful as I am facing the same need.
Does it make sense for ks CLI to automatically choose between kubeconfig and env variable, so that users don't need to pass in them manually? I would imaging using ks in a pod could be common.


[5.4] Blade @extends() new ordering system harder to reason about

Laravel Version: 5.4.4
PHP Version: 7.1.0
Database Driver & Version: MySQL 5.7.17

Description:
The new blade @extends() ordering system introduced in version 5.4 has made it harder to reason about view files and also made it almost impossible (to my knowledge) to implement a few hierarchical functionalities enjoyed in previous versions...
Steps To Reproduce:
Using this setup
global-layout.blade.php
<html>
<head>
@stack('scripts')
@section('scripts')@show
</head>
<body>

</body>
</html>

app-layout.blade.php
@extends('global-layout')

@push('scripts')
<script src="/js/jquery.js"></script>
@endpush

@section('scripts')
<script src="js/jquery.js"></script>
@endsection

some-view.blade.php
@extends('app-layout')

@push('scripts')
<script src="js/some-view.js"></script>
@endpush

@section('scripts')
    @parent
    <script src="js/some-view.js"></script>
@endsection

Using the @stack directive,
Expected 'jquery' to render before 'some-view.js'
but  'some-view.js' is rendered before 'jquery'
Reason: Child view executed first before parent view (extended view)
Using the @section method
This should work right?? But NO.. it doesn't but instead displays a ##parent-placeholder-3880b9413975c06b32c01851bbe852c1198bf003## in the HTML output...
The reason being that Calling the @parent directive would try to load the section content of the extended layout.. but this doesn't exist as the child view is executed first before the parent view..

See #17541 where this was discussed in detail. Taylor also spoke directly to this in the #internals slack channel yesterday.

The ##parent-placeholder-3880b9413975c06b32c01851bbe852c1198bf003## should not be shwon in the html output. Can you verify that you really are on 5.4.4 and try a php artisan view:clear?

@sisve @devcircus
Yea.. I do understand the ordering and it seems right since when the view is compiled the @extends is moved to the bottom of the generated php file....
But my issue is how do I achieve what I want using the arrangement above.... in a sane way....
** Thought ** I am thinking of creating a custom @prepends() directive that prepends the content to the stack instead.

I copied the Blade Template Inheritance example verbatim and I'm also getting ##parent-placeholder-...## in the output.
php artisan view:clear seems to allow the template to be rendered correctly but subsequent requests cause ##parent-placeholder-...##. to come back.

There are no plans to change the new behaviour. It's already been discussed at length.

@GrahamCampbell Forget what's been said previously for a moment -- are you saying that the official example in the documentation should produce placeholder garbage as the intended result?
I'm getting:
##parent-placeholder-19bd1503d9bad449304cc6b4e977b74bac6cc771##
This is appended to the master sidebar.

This is my body content.

Errrr. Ping @taylorotwell.

@GrahamCampbell @taylorotwell Just updated to version 5.4.6 of the framework and I am still getting the ##parent-placeholder--xxxx##

Also, if you have discussed this new behavior at length, can you suggest the way to go forward in achieving  what i want?
I have a template.blade.php layout and a few other layouts that extends the template layout...  app.blade.php  and auth.blade.php.... controller views extends from each of these say login.blade.php extends auth.blade.php.... I don't really care about the execution order that was discussed... But content inserted in the auth layout have to be rendered before those defined in the login view extending the auth layout...
So how to go about this?
Asked this in forums and no response....

Also, if you have discussed this new behavior at length, can you suggest the way to go forward in achieving what i want?
I have a template.blade.php layout and a few other layouts... app.blade.php layout and auth.blade.php layouts that extend the template layout.... controller views extends from each of these say login.blade.php extends auth.blade.php.... I don't really care about the execution order that was discussed... In my situation, content inserted in the auth layout have to be rendered before those defined in the login view extending the auth layout...
So how to go about this?
Asked this in forums and no response....

@mjason4x Throw the baby out with the bathwater and switch to Twig. I'm not going to waste any more time with this when there exists a viable alternative that works. Sometimes it's better in the long run to cut your losses.

@morrelinko Did you php artisan view:clear after upgrading Laravel version?

@sisve @taylorotwell @GrahamCampbell
Cleared it all yet no way forward... ** NOTE ** already upgraded to 5.4.6
I had to duplicate my global layout just to move forward..
It seems when you discussed this new behavior, multiple nested layouts, @parent directive and PARENT  -> CHILD order content injection were not considered...
Makes no logical sense why core team thinks content from child views should display first...
I would really like to see the thread where this was discussed to understand the reasoning behind it, probably they also discussed a way out of my issue...

I can't replicate this placeholder thing on latest 5.4, followed the steps to replicate stated in the original issue and @parent successfully displayed the content of the parent section.
Replacing the scripts loaded with some strings to be able to debug, the output I get is:
child stack content
parent stack content
parent section content
child section content

@themsaid I think the parent placeholders are from old cached 5.4.0 views, and should be fixed with an upgrade to 5.4.1 and a php artisan view:clear.
@mjason4x The view:clear would fix the "##parent-placeholder--xxxx##" issue mentioned earlier, not anything related to the order of the output.
Views are rendered before layouts so they can push content into stacks and sections that are contained within the layout. Imagine that the layout is executed first; the @stack would be empty when rendered, before the @push has executed by the view.
The blade-examples in this issue use several chained/nested layouts which further complicates the issue, they are all executed in reverse order so that the topmost is executed last and have the full @stack result.

If you think that the starting point of a view render is the top most parent then you'll find this as a bug, however the starting point is the view being rendered, in this case it's some-view.blade.php not global-layout.blade.php.

The @push issue is fixed a few days ago, I've submitted a PR to introduce a @reversestack that people who prefer the 5.3 behaviour can use. https://github.com/laravel/framework/pull/17675


Warn if context supplied without corresponding childContextTypes

I think it would be useful to warn/error if context option is supplied without corresponding childContextTypes option (and possibly vice versa, though i imagine that's far less likely to occur).
In the last few days, a teammate of mine and someone on reactiflux have both made the mistake of omitting childContextTypes. So it seems like an obvious place to guide developers in the right direction.

Related to #664.

Now that #664 is merged, if you fail to provide childContextTypes, then children simply won't get your context - so this should no longer require a warning.


Feature Request: Caching

Describe your proposal
Currently, caching in the SettingGateway is done through DiscordJS Collections. There should be an option to add optional caching providers, such as Redis. I see this as adding it to the Provider constructor:
constructor(...args) {
  super(...args, { cache: true });
}

Usecases for your proposal
Better caching for large bots, where the huge caches can affect memory.

I actually like this idea, if it can be implemented then I'd surely use Redis for caching while RethinkDB as my main data provider.

This was done before in a much earlier version, and it actually had the opposite result (killed speed, increased CPU load, and memory). This even being an "option" kills Klasa as an option for any large bots, so this is not feasible by design.


JsonRpcAioHttpClient: Allow empty password

Even though empty passwords are considered bad practice, they can still be used.

Codecov Report

Merging #899 (4e66f76) into devel (b13f2ff) will not change coverage.
The diff coverage is n/a.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
@@           Coverage Diff           @@
##            devel     #899   +/-   ##
=======================================
  Coverage   89.92%   89.92%
=======================================
  Files          28       28
  Lines        4677     4677
=======================================
  Hits         4206     4206
  Misses        471      471

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

I have never tested, if empty password are allowed by CCU. Good (bad) to know.


Add minimal placeholder for Hardware Test again

For v1.7 we removed the old hardware test because it was not much needed anymore when most run RP4
see: https://github.com/rootzoll/raspiblitz/issues/2185#issuecomment-821759248
But it can make sense for little things like checking if HDD is connected to USB3 (not USB2) #909 or check sd card speed #1063 etc and maybe bigger things in the future. So in preperation for the v1.8 refactoring we should have a small placeholder for a hardware check on startup/setup and one in the repair/settings menus. Also to be part of the debug log so that on support people can spot problems with the hardware.
So v1.7.1 should introduce a little placeholder for the hardware test again - it can be further improved then even after v1.8

[ ] Mem test https://github.com/rootzoll/raspiblitz/issues/517

see: https://github.com/rootzoll/raspiblitz/issues/2185#issuecomment-830345792

use new script blitz.hardware.sh for this - see branch 1126-provision

SSD Hardwaretest see: #2599


Does variable list type not account for multiple list items in a single row?

This is a question more than an issue:
Do variable list types not allow for grid based lists? I have a list that can fit multiple items on the X axis (depending on screen width), and the entire list scrolls on the Y axis.
When setting the list type to variable, the scroll threshold only seems to work correctly if I shrink my screen down to a size where only 1 element fits per row.
The example page shows a case where "uniform" is used to achieve my desired effect, but I'm running into freezing/overflowing stack issue without a good way to debug why it thinks my repeating elements are of different sizes (inspecting the DOM shows them all as the same size).

@Diasporism I experienced same freezing effect for such reason: I've changed display property of container or list items from 'flex' to 'inline-block or something' by CSS in media queries. because of that react-list made some inner recalculations and freezes whole website.
Once I removed that display mutations - everything became just fine (I also have grid layout with multiple items per row). My grid still uses media queries to dynamically change items width to fit items accordingly in row while resize window and react-list handles this type of changed without problems, as expected.

Same issue here. But even if the container is a normal div ('block') and the items are div ('inline-block'), I've the 'ReactList failed to reach a stable state' message in the console (and a freeze in rendering). Note that all my items have a well established and fixed size.


⚠ Bofrost.be has degraded performance

In ff7d111, Bofrost.be (https://www.bofrost.be) experienced degraded performance:

HTTP code: 200
Response time: 977 ms

Resolved: Bofrost.be performance has improved in 6fb2a6b after 14 minutes.


Can not import @materialze with newest ember-cli version.

Error message:
/Users/newuser/Project/beauty_now_pro/ember/tmp/tree_merger-tmp_dest_dir-CDIj1KxA.tmp/app/styles/app.scss:1: file to import not found or unreadable: 'materialize'
Current dir: /Users/newuser/Project/beauty_now_pro/ember/tmp/tree_merger-tmp_dest_dir-CDIj1KxA.tmp/app/styles/
 [string exception]

My ember-cli version:
version: 0.2.0-beta.1
node: 0.10.26
npm: 2.1.8
Temporary solution:
Add these lines:
  var ENV = {

    sassOptions: {
      includePaths: ['bower_components/materialize/sass']
    },
  }

FIxed

I'm seeing this again, I'm on 0.2.7

Next release should take care of it, now that the sassOptions in Brocfile has been walked back. see: #139
You could point to #master until @sgasser pushes a new release to npm

Having the same/similar problem:
File: /Users/username/projectName/tmp/tree_merger-tmp_dest_dir-ZOpqIPtK.tmp/app/styles/app.scss (1)
file to import not found or unreadable: materialize
Current dir: /Users/username/projectName/tmp/tree_merger-tmp_dest_dir-ZOpqIPtK.tmp/app/styles/

Using:
Ember 1.13.5
Ember CLI 1.13.1
Node 0.12.2
NPM 2.7.5
Tried a number of different fixes including the one mentioned by @Chun-Yang but no dice. In another issue I read there may be a conflict between broccoli-sass vs. ember-cli-sass so I tried removing one, then the other, still nothing. Tried putting sassOptions in the brocfile. Any other ideas?

I suspect that you're missing the required
   sassOptions: {
      includePaths: ['bower_components/materialize/sass']
    },

Can you ls the tmp directory you see in your error message (i.e., ls /Users/username/projectName/tmp/tree_merger-tmp_dest_dir-ZOpqIPtK.tmp/app/styles/)?

Yeah, I tried including sassOptions in my environment.js within ENV = {} as well and I get:
/Users/userName/projectName/tmp/broccoli_merge_trees-output_path-Ueb3BW8t.tmp/app/styles/app.[scss|sass] does not exist

So then, when I ls the broccoli_merge_trees-output_path-Ueb3BW8t.tmp directory, I get no such file or directory. (I ls'd each successive directory from the root just to be sure I wasn't using the wrong path)

So, just as in #132 it turns out I just had to remove broccoli-sass from my dependencies, AND include sassOptions in my environment.js. I thought I had already tried that combination, but I guess not!
Thanks!

I'll make a note that this addon is only to be used w/ ember-cli-sass -- not broccoli-sass


Dismissing window should deinitialise it

When dismissing the window it should be deinitialised and removed, however, this does not happen. When recalling the window later the .onAppear modifier does not execute.

Thank you for reporting this issue! I am already aware of it, and as a temporary workaround, you can use the following code:
if manager.isPresented {
  Color.clear
    .windowOverlay(isPresented: true) {
      ToastRootView(manager: manager)
    }
}

This should help in properly deinitializing and removing the window when dismissed. We're open to any suggestions or ideas for improvements if you have any.

Thanks for the reply. Unfortunately, this doesn't really work for my use. Hopefully you can make the isPresented binding and deinitialise the window

https://github.com/sunghyun-k/swiftui-window-overlay/releases/tag/1.0.1
The latest release has resolved this issue. Thank you for feedback!


Frontend is not responding

Unable to send or perform operation using frontend
Able to register, login, post, get, put or delete using the Curl command or in Postman but not through the frontend

Hey, I’m just starting out with open source, and I’d love to try fixing this issue! I’ll take a look and do my best to figure it out.

Hey @Hugs-4-Bugs can you assign this issue to me.


Fix TLV buffer overflow

Fix out of bounds memory access picked up by coverity
5 bytes were being allocated for the TLV header, which works in most
cases. But in the case where a 16 bit identifier is used with a
24 bit length the resulting header will be 6 bytes and overflow.
Signed-off-by: Chris Dewbery<EMAIL_ADDRESS>

+1


Allow checklist import to match existing name for parent instead of Root

When parentNameUsageID is blank, importer can now try to match the name against existing TaxonNames in the project.
This allows users to make fixes to errored rows and re-upload for import. Previously, re-importing the same rows in a new checklist would create duplicate entries if the top-level name's parent was changed from Root, as the new top-level name would have parent Root and no names would match.
Now, when the setting is enabled, the importer will re-use the existing "top-level" name, allowing its children to also match existing names if they haven't changed.

Codecov Report
Attention: 19 lines in your changes are missing coverage. Please review.

Comparison is base (80146b2) 72.31% compared to head (c502e70) 59.93%.

:exclamation: Current head c502e70 differs from pull request most recent head f829de0. Consider uploading reports for the commit f829de0 to get more accurate results

Files
Patch %
Lines

app/models/dataset_record/darwin_core/taxon.rb
0.00%
16 Missing :warning:

app/models/import_dataset/darwin_core/checklist.rb
33.33%
2 Missing :warning:

...ollers/tasks/dwca_import/dwca_import_controller.rb
0.00%
1 Missing :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@               Coverage Diff                @@
##           development    #3654       +/-   ##
================================================
- Coverage        72.31%   59.93%   -12.38%
================================================
  Files             1639     1519      -120
  Lines            55384    46186     -9198
================================================
- Hits             40049    27680    -12369
- Misses           15335    18506     +3171

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


filter for "new episodes" for tv shows in 3.0 snapshots does not behave like 2.x

What TMM version are you using?
Version: 3.0-SNAPSHOT
Build: 2018-06-23 00:22
OS: Windows 10 10.0
JDK: 10.0.1 amd64 Oracle Corporation
release, pre-release, nightly, or directly from GitHub/branch?
pre-release snapshots
What is the actual behaviour?
as you can see when new episodes enabled as a filter it still shows you seasons/episodes that are not new

What is the expected behaviour?
in this example... only the highlighted episode (and seasons) should be shown like it did in 2.x
I don't have 2.x installed otherwise I would provide a screenshot but I am pretty sure you know what I mean if not ask and I will provide more info.
Steps to reproduce:

first enable filter for new episodes using 3.x
second
...

Additional
Have you attached the Logfile from the day it happened?
Your Operating system? (win/mac/linux? version?)
Windows 10 x64bit
Thanks

will be fixed in the next build

thanks - working great


CHAOSPLT-124: fix - update disruption target status with multiple kinds

What does this PR do?

[ ] Adds new functionality
[ ] Alters existing functionality
[x] Fixes a bug
[ ] Improves documentation or testing

Please briefly describe your changes as well as the motivation behind them:

The target disruption status was not taking into account when a disruption injects multiple kinds of injections. Now the target status of the disruption lists the status of all its chaos pods.
It also resolves another issue: in the case of a disruption with multiple types of injections, the disruption's status was marked as injected if only one of the two injections succeeded. The correct behavior is to mark the disruption status as injected only when all injections are successfully completed.

Example with the following disruption:
# Unless explicitly stated otherwise all files in this repository are licensed
# under the Apache License Version 2.0.
# This product includes software developed at Datadog (https://www.datadoghq.com/).
# Copyright 2023 Datadog, Inc.

apiVersion: chaos.datadoghq.com/v1beta1
kind: Disruption
metadata:
  name: network-drop
  namespace: chaos-demo
  annotations:
    chaos.datadoghq.com/environment: "lima"
spec:
  level: pod
  selector:
    app: demo-curl
  count: 100%
  network:
    drop: 100 # percentage of outgoing packets to drop
  diskFailure:
    paths:
      - /mnt/data/disk-read
      - /mnt/data/disk-write
    openat:
      exitCode: ENOENT
    probability: 100%

This disruption creates two chaos pods per target. One for the network disruption and one for the disk failure:
$ kubectl get pods
NAME                               READY   STATUS    RESTARTS   AGE
chaos-controller-6b586f7b9-hg29g   2/2     Running   0          83s
chaos-network-drop-kv4zm           1/1     Running   0          60s
chaos-network-drop-zkcp8           1/1     Running   0          59s

Before

Status of the disruption
kubectl -n chaos-demo get disruption network-drop -ojson | jq .status

{
  "desiredTargetsCount": 1,
  "ignoredTargetsCount": 0,
  "injectedTargetsCount": 1,
  "injectionStatus": "Injected",
  "selectedTargetsCount": 1,
  "targetInjections": {
    "demo-curl-bbc858869-z67wx": {
      "injectionStatus": "Injected",
      "injectorPodName": "chaos-network-drop-zkcp8",
      "since": "2023-10-30T16:48:11Z"
    }
  }
}

After

Status of the disruption
kubectl -n chaos-demo get disruption network-drop -ojson | jq .status

{
  "desiredTargetsCount": 1,
  "ignoredTargetsCount": 0,
  "injectedTargetsCount": 1,
  "injectionStatus": "Injected",
  "selectedTargetsCount": 1,
  "targetInjections": {
    "demo-curl-bbc858869-z67wx": [
      {
        "disruptionKindName": "network-disruption",
        "injectionStatus": "Injected",
        "injectorPodName": "chaos-network-drop-5flc4",
        "since": "2023-10-30T16:44:59Z"
      },
      {
        "disruptionKindName": "disk-failure",
        "injectionStatus": "Injected",
        "injectorPodName": "chaos-network-drop-g9qjc",
        "since": "2023-10-30T16:45:10Z"
      }
    ]
  }
}

Code Quality Checklist

[x] The documentation is up to date.
[x] My code is sufficiently commented and passes continuous integration checks.
[x] I have signed my commit (see Contributing Docs).

Testing

[ ] I leveraged continuous integration testing

[ ] by depending on existing unit tests or end-to-end tests.
[ ] by adding new unit tests or end-to-end tests.

[x] I manually tested the following steps:

[x] locally.
[ ] as a canary deployment to a cluster.

well, it's a little unfortunate that kubectl describe doesn't split up the output by chaos pod in any obvious way, but at least it is ordered correctly:
Status:
  Desired Targets Count:   1
  Ignored Targets Count:   0
  Injected Targets Count:  1
  Injection Status:        Injected
  Selected Targets Count:  1
  Target Injections:
    demo-curl-bbc858869-7fhpv:
      Disruption Kind Name:  network-disruption
      Injection Status:      Injected
      Injector Pod Name:     chaos-network-drop-ldcrg
      Since:                 2023-10-30T18:00:27Z
      Disruption Kind Name:  disk-failure
      Injection Status:      Injected
      Injector Pod Name:     chaos-network-drop-4nbj7
      Since:                 2023-10-30T18:00:37Z

I don't think we can fix that easily? we'd need to use the kind names as map keys, instead of items within the struct list. e.g.:
Status:
  Desired Targets Count:   1
  Ignored Targets Count:   0
  Injected Targets Count:  1
  Injection Status:        Injected
  Selected Targets Count:  1
  Target Injections:
    demo-curl-bbc858869-7fhpv:
      network-disruption:
          Injection Status:      Injected
          Injector Pod Name:     chaos-network-drop-ldcrg
          Since:                 2023-10-30T18:00:27Z
     disk-failure:
          Injection Status:      Injected
          Injector Pod Name:     chaos-network-drop-4nbj7
          Since:                 2023-10-30T18:00:37Z
      ```


chore(discv4): remove deprecated EF bootnodes

The bootnodes were removed in geth already: https://github.com/ethereum/go-ethereum/pull/26828

@skylenet you also need to change static array length from 8 to 4 here
https://github.com/paradigmxyz/reth/blob/76223f9a90729c4291c5422078b9f3dfa7ad61e2/crates/net/discv4/src/bootnodes.rs#L8

Codecov Report

Merging #1680 (32a3d24) into main (279ad34) will decrease coverage by 57.58%.
The diff coverage is n/a.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
@@             Coverage Diff             @@
##             main    #1680       +/-   ##
===========================================
- Coverage   75.02%   17.44%   -57.58%
===========================================
  Files         378      378
  Lines       45463    45463
===========================================
- Hits        34107     7931    -26176
- Misses      11356    37532    +26176

Flag
Coverage Δ

integration-tests
17.44% <ø> (-4.11%)
:arrow_down:

unit-tests
?

Flags with carried forward coverage won't be shown. Click here to find out more.

 Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

state test failure is unrelated


no image 'kubernetes/redis-slave:v2'  in redis-slave-deployment.yaml on LAB3

There is no image 'kubernetes/redis-slave:v2'  in redis-slave-deployment.yaml on LAB3.
Could you replace correct image name?
$ kubectl get pods -l app=redis,role=slave
NAME                           READY   STATUS         RESTARTS   AGE
redis-slave-5db5dcfdfd-4d7pn   0/1     ErrImagePull   0          43s
redis-slave-5db5dcfdfd-gsck8   0/1     ErrImagePull   0          43s
$ kubectl logs redis-slave-5db5dcfdfd-4d7pn
Error from server (BadRequest): container "redis-slave" in pod "redis-slave-5db5dcfdfd-4d7pn" is waiting to start: image can't be pulled

Thanks!
very interesting
https://github.com/kubernetes/examples/issues/321
need to switch to
"k8s.gcr.io/redis-slave:v2"
or otherwise configure the default image to do the right thing.

@kyokonishito going to switch to  ibmcom/guestbook-relay-slave:v2 as that is under our control.


Simplify 8-bit display interface

I simplified the API for the parallel GPIO interface by grouping the bus into an array of pins rather than 8 individual pins. This allows to further simplify the set_value() function.

Any feedback on this one? Concerns?

Sorry, didn't get to testing it yet. No concerns from just reading the code.

#20 solves this problem in a different way, feel free to check it out and let me know what you think

@andresovela I have to agree with @GrantM11235 here that having to downgrade pins is not ideal. The main problem that I see is that using downgraded pins usually cause some additional overhead due to the dynamic calculation of the right addresses and bits and that is not ideal for this usecase.

Alright. Closing this PR in favor of #20 then. May I ask about the "additional overhead" though? I was not aware of that. What dynamic calculation of addresses and bits?

Here is a simplified example of how set_high() could be implemented based on this example
impl PA0 {
    fn set_high(&mut self) {
        port_a_registers.set_output_bits(0b00000001);
    }
}

impl Pin {
    fn set_high(&mut self) {
        let registers = match self.port {
            Port::A => port_a_registers,
            Port::B => port_b_registers,
            Port::C => port_c_registers,
            Port::D => port_d_registers,
        };

        let bits = 1 << self.pin;

        registers.set_output_bits(bits);
    }
}

To be honest, I don't actually think that performance is a big concern here. With inlining and LTO, PA0.set_high(); and Pin { port: Port::A, pin: 0 }.set_high(); will probably compile down to the exact same thing

May I ask about the "additional overhead" though? I was not aware of that. What dynamic calculation of addresses and bits?

Usual pins are zero-sized types, the implementation of which get monomorphized into pretty much ideal code. OTOH downgraded pins are by concept unified structures containing registerblock adresses and pin offsets so a generic implementation can be used.

To be honest, I don't actually think that performance is a big concern here. With inlining and LTO, PA0.set_high(); and Pin { port: Port::A, pin: 0 }.set_high(); will probably compile down to the exact same thing

Well, it is theoretically possible that it compiles into the comparable code but it's somewhat unlikely due to dependence on a number of factors (implementation, optimization flags and what not)...


Fix figures in postprocessor

When using plot_node_field without title for the figure it add the axes to the last figure.

Fixed by 0695848a84096eb386f916ab3976c2ce1353a648


[language][src_map] add type formal names to transaction scripts

Transaction script docs were missing these, which are nice to have. This PR fixes the problem by adding a forgotten record_src_loc macro to the code for producing the bytecode-source map for tx scripts.
Motivation
Better source maps, better docs. Closes #4500.
Have you read the Contributing Guidelines on pull requests?
Y
Test Plan
Rebuilt stdlib docs, transaction script docs now include type parameter names.

@bors-libra r=wrwg

:pushpin: Commit dce54aa has been approved by wrwg

:hourglass: Testing commit dce54aa9cc9377e8a9ed9811cf4dee8657886475 with merge 1fd1e5a0c875a9f981bf7a012846ed3d276d11ba...

:sunny: Test successful - checks-actions_land_blocking_test, checks-circle_commit_workflow
Approved by: wrwg
Pushing 1fd1e5a0c875a9f981bf7a012846ed3d276d11ba to master...


[#77] Implement new DeleteCommand to delete individual student records

Closes #77
Update DeleteCommand to delete individual student records using a new format.
Examples: delete n/Jonathan Tan or delete id/123A

LGTM.


Improve Windows networking code

Rename BSD emulation functions to include aeron_ prefix.
Use Aeron style error handling within those functions to make error handling more consistent
Add AERON_SET_ERR_WIN macro for use with windows specific errors (i.e. those coming from GetLastError() and WSAGetLastError())
Format windows errors with FormatMessage instead strerror.

LGTM


[site] Add interactive earlgrey block diagram to site

Summary
This PR adds an alternative implementation of the interactive block diagram for earlgrey to the site.
Based on the excellent block diagram from this PR: https://github.com/lowRISC/opentitan/pull/17405
Differences to the original block diagram
This version of the diagram was made to avoid introducing Node.js and its ecosystem into OpenTitan.

Diagram styled using CSS grids, avoiding JavaScript hydration.
Diagram specified declaratively in HTML. Should be easy to make others.
Stats generated into a JSON file stored on the server.
Client-side JavaScript fetches the stats and creates the tooltips.

There's a trade-off to using this diagram, but I personally think the benefits outweigh the drawbacks:
Benefits:

Avoids introducing a new technology to OpenTitan (Node.js) which requires maintenance.
Avoids adding large dependencies (Node.js, headless chrome, and puppeteer).
Faster build time (only fetch_block_stats.py has to run, and ideally only nightly).
Design/verification stages taken from the .hjson files, keeping them up to date.

Drawbacks:

The CSS file is fairly large, though I've tried to document it thoroughly.
Browser requires JavaScript to be enabled to see the tooltips (rest of diagram still works).

Screenshots
Looks mostly the same as the original:

Screenshot

Unresolved
Currently no styling for:

[x] Dual-lockstep ibex
[ ] Crossbar crosses

Also TODO:

[ ] Would like util/site/fetch_block_stats.py to run nightly rather than on build.
[ ] The JavaScript should surface errors better when it can't fetch or parse the report.
[ ] Remove the old diagram. At the very least, disable generation in util/site/build-site.sh.

Force pushed to change block_diagram.css's license comment and satisfy the license checker.

Rebased. I will have a look at these remaining TODOs sometime this week.

I've added the dual-lockstep styling, plus made the Ibex text a bit bigger like in the original diagram.

Rebased with fixups squashed.

@jwnrt Could you do some cross-browser testing just for any showstoppers?

The only real issue appears to be the arrows continuing beyond the block in the always on domain.
Webkit (Gnome Web):

Blink (Chromium):

Force pushed to fix the arrows and @marnovandermaas's comments.
The arrow problem came from Firefox giving 0 for unset variables, while Blink gives some kind of NaN that breaks calculations. Had a quick skim for other instances of that, but didn't see any obvious ones.


scripts/deploy.sh can't run twice on master

This section is completed by the issue reporter
On which version(s) do you encounter this issue?
master
What type of issue is this? Please tick the appropriate box.

[x] bug - existing functionality that does not work for you as documented
[ ] feature - new functionality that you would like to see added

What is the expected behavior?
Ability to use ./scripts/deploy.sh multiple times
What is actually happening?
Impossible to use ./scripts/deploy.sh multiple times, due to a failure to:
mv /etc/openstack_deploy/user_variables.yml /etc/openstack_deploy/user_osa_aio_variables.yml
What were you attempting to do when you encountered this error (give as much detail as possible)?
Ran the ./scripts/deploy.sh , it failed for an unrelated reason, then restarted the scripts/deploy.sh, which activated a different part of its code, by checking the existence of the folder /etc/openstack_deploy. (It wasn't existing before for, and it now exists after my first run)
How can we reproduce this issue?
Run the script twice.
How can we verify your issue is addressed?
You can run the script twice.
If you are using or know of a workaround please describe the necessary steps?
What is your evaluation on the importance of this issue, and why?
Moderate priority: High criticality (could impact gates for minor upgrades later, negative impact on deployer confidence, ...) - Low impact (master only - no customer affected)

This section is completed during the issue resolution process. If you are reporting an issue, please do not modify the section below.
Which branches are impacted by this issue?
Remove branches that are not impacted.
For each pull request, update the branch line to reference it.

[ ] master
[ ] liberty-12.2
[ ] kilo

Upgrade impact. Consider the impact on moving between major, minor and patch releases.

[ ] This change does not impact upgrades
[ ] This change addresses a potential upgrade impact
[ ] The upgrade impact is being tracked by another issue.

The issue tracking the upgrade impact is:
Testing impact

[ ] An issue/pull-request has been create or exists to track the testing gap, and is referenced below
[ ] This change includes additional testing
[ ] This change is tested by the existing setup

Additional testing links:
Release note

[ ] This change includes a release note.
[ ] This change does not require a release note.

Doc Impact
Does your change require documentation?

[ ] Yes, and I submitted an issue to Docs issues
[ ] Yes, and I contributed a documentation patch to docs-rpc
[ ] No documentation required for this change

Additional documentation links (please add links if you have ticked yes):

Probably a
if test -f /etc/openstack_deploy/user_variables.yml; then
on L62 and L121 would help.

@evrardjp at what point did your run fail for you to see this? If /etc/openstack_deploy already exists, the step to mv the /etc/openstack_deploy/user_variables.yml  file would be skipped.
Can you please provide very clear steps to reproduce?

Sorry my bad, it's a problem with my paste, it's not in user_variables, but for secrets.
L62 is to be ignored. Only L121 is important.


Proximity Trigger Not Working

So I'm trying to add in a Proximity Trigger using the tutorials for Denizen but in the console the script only seems to go to the First Step of each interact script and not actually run it.
Here is my code:
LarsTriphook:
    type: assignment
    actions:
        on assignment:
            - trigger name:proximity state:true radius:5
            - trigger name:click state:true
            - flag player 'PreviouslyMet:false'
        on click:
            - inventory open d:in@LarsTriphookMenu
    interact scripts:
        - 10 LarsTriphookIntroduction
        - 20 LarsTriphookDialogue

LarsTriphookMenu:
    type: inventory
    title: "Lars Triphook"
    size: 9
    slots:
    - "[i@LarsTriphookMenu_Slot1] [i@LarsTriphookMenu_Slot2] [] [] [] [] [] [] []"
LarsTriphookMenu_EventHandler:
    type: world
    events:
        on player clicks in LarsTriphook:
        - determine cancelled
        on player drags in LarsTriphookMenu:
        - determine cancelled
        on player clicks LarsTriphookMenu_Slot1 in LarsTriphookMenu:
        - execute as_player "quests list"
LarsTriphookMenu_Slot1:
    type: item
    material: 387
    display name: Shop
LarsTriphookMenu_Slot2:
    type: item
    material: 386
    display name: Jobs

LarsTriphookIntroduction:
    type: interact
    requirements:
        Mode: All
        List:
        - flagged player 'PreviouslyMet:false'
    steps:
        1:
            Proximity Trigger:
                entry:
                    Script:
                    - RANDOM:
                        - CHAT "Hey there, the name's Lars. I run the Vesper Castle blacksmith."
                        - CHAT "You're new around here? I'm Lars the Vesper Castle blacksmith."
                        - CHAT "Welcome traveller, the name's Lars. Any metalwork you need done I'm your best man."
                    - FlAG player 'PreviouslyMet:true'
                exit:
                    Script:
                    - CHAT "Alright then, I'll be on my way."

LarsTriphookDialogue:
    type: interact
    requirements:
        Mode: All
        List:
        - flagged player 'PreviouslyMet:true'
    steps:
        1:
            proximity trigger:

                entry:
                    - flag player 'PlayerChat:true'
                    - while flagged player 'PlayerChat:true' {
                        - RANDOM 3
                        - CHAT "Do you need some of your armor repaired?"
                        - CHAT "I've got the best weapons and armor for sale."
                        - CHAT "You're welcome to browse my armor and weapons."
                        - WAIT 3s
                        - RANDOM 3
                        - CHAT "Have you heard about the recent dragon attacks?"
                        - CHAT "My pal Lars had a whole flock of his sheep stolen by dragons."
                        - CHAT "Be careful on your travels on the road, dragons can be resting anywhere."
                        - WAIT 3s
                    }

                exit:
                    - flag player 'PlayerChat:false'

You've done it entirely wrong; please follow the tutorials available at http://one.denizenscript.com/denizen/vids (the first set, not the ones at the bottom!)


Fix type of "ref" property on custom component

Description:
The type of "ref" property on the class component always be a reference to an instance of a class component. But in react-pixi, it's a Pixi instance, so should set it to a function component and specify the type of ref property.
Related issue (if exists):

Hi @vimcaw,
The ref type are already handled correctly for all components, the Stage however should result in a class instance to the Stage itself.
I’ll close this PR, thanks for collab!

It's correct in preset component (Stage, Graphics, Sprite, etc), but not in a custom component.
Look at this example: https://codesandbox.io/s/react-pixi-ref-type-error-on-custom-component-5fwot?file=/src/App.tsx
Custom component:

Preset component：

That's because Preset Components use React.FC to define ref type:
https://github.com/inlet/react-pixi/blob/c049ca6c52bcc765add26c88cf18eec0fca93aac/index.d.ts#L310-L320
export const Text: React.FC<_ReactPixi.IText>;
export const Sprite: React.FC<_ReactPixi.ISprite>;
export const Container: React.FC<_ReactPixi.IContainer>;
export const Graphics: React.FC<_ReactPixi.IGraphics>;
export const BitmapText: React.FC<_ReactPixi.IBitmapText>;
export const NineSlicePlane: React.FC<_ReactPixi.INineSlicePlane>;
export const ParticleContainer: React.FC<_ReactPixi.IParticleContainer>;
export const TilingSprite: React.FC<_ReactPixi.ITilingSprite>;
export const SimpleRope: React.FC<_ReactPixi.ISimpleRope>;
export const SimpleMesh: React.FC<_ReactPixi.ISimpleMesh>;
export const AnimatedSprite: React.FC<_ReactPixi.IAnimatedSprite>;

https://github.com/inlet/react-pixi/blob/master/index.d.ts#L139-L161
  type Container<T extends PIXI.DisplayObject, U = {}> = Partial<
    Omit<T, 'children' | P | ReadonlyKeys<T> | keyof U> &
    WithPointLike<P>
    > & U & InteractionEvents & { ref?: React.Ref<T> };

  type IContainer = Container<PIXI.Container>;
  type ISprite = Container<PIXI.Sprite, WithSource>;
  type IText = Container<PIXI.Text, WithSource>;
  type IGraphics = Container<PIXI.Graphics, {
    /**
     * Draw a graphic with imperative callback.
     *
     * @param {PIXI.Graphics} graphics - The graphics instance to draw on
     * @example
     *
     * draw={g => {
     *   g.beginFill(0xff0000);
     *   g.drawRect(0,0,100,100);
     *   g.endFill();
     * }}
     */
    draw?(graphics: PIXI.Graphics): void;
  }>;

Oops, I closed this PR too soon.. yes you’re right, ref is missing for custom components. Thanks for letting me know..
I’ll review this PR as soon as I’ve time


Tip for MIR_new_func_arr

MIR_new_func_arr sets vars[i].name to the allocated name (which may be different from the chosen name)
see the diff

Yes. Still weird though.
I'll merge this once i get to updating things for latest zig build.
I the middle of rewriting the ast and everything using it right now.

@iacore turns out that fix does not work, I had to revert to the previous (ugly) usage

Interesting! Did MIR update?

No it just did not work


[Feature]: Add 4 - 34 character password generation!

Proposed solution
Add 4 - 34 character password generation!
Justification
Currently it is from 6 to 32 but there is a case where I need 4 or 34 characters!
Alternatives
Suggest options!
Additional context
I accept suggestion!
Are you willing to submit a PR for this issue?
no
Validations

[X] Check that there isn't already an issue that request the same feature to avoid creating a duplicate.

Hi. It is in there. You can set your password length to 4 or 34 in extension's settings.

It's the quick adjustment slider that has some additional logic:

Default min/max values of the slider are 6-32
If your default length is out of the range, the slider's range will adjust (e.g. if your default length is 4, then the slider's range will be 4-32 and vice versa)

I've made it this way, so the slider doesn't have a great range, otherwise it would be hard to manipulate.
Though, I could make some adjustments to the UX. I am not happy about current state of the quick adjustments bar, so I'll think what I can do about it.

@XFox111 Thanks
Yes, I had already done that, but when I need a password with 4 numbers I need to change it down and when I need one with 34 numbers I need to change it again, can you leave the default between 4 and 34 in the quick setting?
Thanks
Maison

Hi @maisondasilva. I've reworked quick adjustments section for the next version. Can you test this and give me your thoughts? Note, that this is a WIP, so it has some bugs.
TabsAside-286-WIP.zip

It was very good! With this new version need to translate anything new?
You could leave it by default between 4 and 34, this would be very useful for the customers me install it!

Thanks

Between the lines it would be nice to have a space for design ends!

Great! I'll prepare the PR tomorrow.

With this new version need to translate anything new?

Not exactly. Copilot surprisingly does a great job. However, I'll put you into reviewers to make sure that the wording is good.

You could leave it by default between 4 and 34, this would be very useful for the customers me install it!
I think the password pattern instead of 8 could also be 10

I'll lower it to 4 characters, but I'm keeping the upper bar and default length as is. These are optimal for the most of users.

Between the lines it would be nice to have a space for design ends

This is a number range, and the rules tell that there should be no spaces (besides, in my opinion it looks worse with them). Though I'll change the dash character, since apparently it should be en dash (–) instead of em dash (—).


Depth vs. Transmit Frequency

Hi,
I am just wondering if there was a relationship between the set depth, and its transmit frequency.
Thanks!

Yes, the transmit frequency is a function of the depth, scanner model and preset.


[BUG] Azure-Core cannot encode with some character in query param

Describe the bug
Azure-Core cannot encode with some character in query param like $, /
To Reproduce
Steps to reproduce the behavior:
run the following code, it will request with http://httpbin.org/get?$filter=a/b
Code Snippet
public class App {
    public static void main(String[] args) {
        try {
            HttpClient client = new NettyAsyncHttpClientBuilder().build();
            Service proxy = RestProxy.create(Service.class, new HttpPipelineBuilder().policies(new UrlPolicy()).httpClient(client).build());

            proxy.get("http://httpbin.org/", "a/b")
                    .doOnNext(System.out::println)
                    .block();

        } catch (Exception e) {
            System.out.println(e.getMessage());
            e.printStackTrace();
        }
    }

    @Host("{$host}")
    @ServiceInterface(name = "Service")
    private interface Service {
        @Get("/get")
        Mono<Map<String, Object>> get(@HostParam("$host") String host, @QueryParam("$filter") String filter);
    }

    private static class UrlPolicy implements HttpPipelinePolicy {

        @Override
        public Mono<HttpResponse> process(HttpPipelineCallContext context, HttpPipelineNextPolicy next) {
            System.out.println(context.getHttpRequest().getUrl());
            return next.process();
        }
    }
}

Expected behavior
It should request with http://httpbin.org/get?%24filter=a%2Fb instead.
Setup (please complete the following information):

OS:  Windows 10
IDE : Java 1.8.0_231
Version of the Library used

Azure-core, Azure-core-http-netty 1.5.0

Information Checklist
Kindly make sure that you have added all the following information above and checkoff the required fields otherwise we will treat the issuer as an incomplete report

[x] Bug Description Added
[x] Repro Steps Added
[x] Setup information Added

@ChenTanyi
'/' and '?' can be used in query param values according to RFC 3986. Please refer to this [stackoverflow post].(https://stackoverflow.com/questions/2322764/what-characters-must-be-escaped-in-an-http-query-string/31300627#31300627)
Azure core doesn't encode query param names ("$filter" in you example) because we assume no azure service uses a param name that has a space that breaks. Unencoded "$" in param name should work.
Are you aware of any problems caused by this encoding design?

@YijunXieMS Yes, in the PR I mentioned above. The azure SQL database listMetrics will fail due to the encoding. You could see the code sample in https://github.com/azure/azure-sdk-for-java/blob/4bb437c58cdf2c7645fa6932862507c931d47b21/sdk/resourcemanager/azure-resourcemanager-samples/src/main/java/com/azure/resourcemanager/sql/samples/GettingSqlServerMetrics.java#L199 while the track 1 code with encoding will succeed.

After discussing, the SQL request error is due to the time format instead of encoding. So close it.


HAWKULAR-767 - Perform build and deploy in one step

@ppalaga , @stefannegrea , @Jiri-Kremser , not sure if this was done/tested like this before, but it should solve the problem of processing standalone.xml twice (once during the "script" part, and once again at the "after_success" part). The side effect is that it would fail the build if there's a failure during the deployment, but I think this is actually a good thing, as we would then be sure that the "latest" would be deployed. What do you think ?

https://issues.jboss.org/browse/HAWKULAR-780 - For a more longer term fix. This should fix the issues that QE is having with living on the edge.


Carla PythonClient/manual_control.py problems

I downloaded the latest master repository and built it from source. I packaged the game for Linux and then started it in server mode:
./CarlaUE4.sh /Game/Maps/Town01 -carla-server -windowed -ResX=640 -ResY=480 -benchmark -fps=25
Then I ran the manual_control.py in the source code I cloned from GIT.
I see that the main window created by the carla server keeps flickering if it was opened in a different resolution than that specified in the camera settings of manual_control.py.
This is the message I get in the terminal.

Although this doesn't create any problems since the view in the main window is not really used anywhere, I see a 2 - 3 FPS drop in performance because of this. It also means that the server now has to render the output at a resolution specified in the client code. So, if I set my cameras for 1920x1080, my server also has to run at the same resolution. This uses the precious Compute and GPU memory, which can be better used elsewhere.

Hello @YashBansod , take a look to the SceneCaptureCamera.cpp when the UTextureRenderTarget2D* CaptureRenderTarget is created it uses the InitCustomFormat with the size in width and height (sizex and sizey), and this is where the render target texture is allocating memory, so it's normal and it's not rendering a 1920x1080 viewport (that's only for your screen resolution in your scene camera render, not ASceneCaptureCamera).
You can also take a look to the unreal engine code for UnrealEngine_4.18/Engine/Source/Runtime/Renderer/Private/PostProcess/SceneRenderTargets.cpp:
if( (BufferSize.X != DesiredBufferSize.X) ||
                (BufferSize.Y != DesiredBufferSize.Y) ||
                (CurrentGBufferFormat != GBufferFormat) ||
                (CurrentSceneColorFormat != SceneColorFormat) ||
                (CurrentMobileSceneColorFormat != MobileSceneColorFormat) ||
                (bAllowStaticLighting != bNewAllowStaticLighting) ||
                (bUseDownsizedOcclusionQueries != bDownsampledOcclusionQueries) ||
                (CurrentMaxShadowResolution != MaxShadowResolution) ||
                (CurrentRSMResolution != RSMResolution) ||
                (CurrentTranslucencyLightingVolumeDim != TranslucencyLightingVolumeDim) ||
                (CurrentMobile32bpp != Mobile32bpp) ||
                (CurrentMSAACount != MSAACount) ||
                (bCurrentLightPropagationVolume != bLightPropagationVolume) ||
                (CurrentMinShadowResolution != MinShadowResolution))
        {
                CurrentGBufferFormat = GBufferFormat;
                CurrentSceneColorFormat = SceneColorFormat;
                CurrentMobileSceneColorFormat = MobileSceneColorFormat;
                bAllowStaticLighting = bNewAllowStaticLighting;
                bUseDownsizedOcclusionQueries = bDownsampledOcclusionQueries;
                CurrentMaxShadowResolution = MaxShadowResolution;
                CurrentRSMResolution = RSMResolution;
                CurrentTranslucencyLightingVolumeDim = TranslucencyLightingVolumeDim;
                CurrentMobile32bpp = Mobile32bpp;
                CurrentMSAACount = MSAACount;
                CurrentMinShadowResolution = MinShadowResolution;
                bCurrentLightPropagationVolume = bLightPropagationVolume;

                // Reinitialize the render targets for the given size.
                SetBufferSize(DesiredBufferSize.X, DesiredBufferSize.Y);

                UE_LOG(LogRenderer, Log, TEXT("Reallocating scene render targets to support %ux%u Format %u NumSamples %u (Frame:%u)."), BufferSize.X, BufferSize.Y, (uint32)GetSceneColorFormat(), CurrentMSAACount, ViewFamily.FrameNumber);

                UpdateRHI();
        }

Notice that when there is a change in the scene related to color, shadows, msa, lights or other things that triggers the regeneration of the render texture, it will allocate memory again, check also that the engine will try to reuse the same resource so even when you restart an episode, it will not allocate the render texture again.
Ah, because vsync you may drop some fps but not all the time. Because of this depends on your GPU manufacturer's driver, and also settings such as r.vsync it is the reason why they wont support dynamic resolutions for UE4.19.
Regards,
Juan


Only download drivers for the current OS

It would be nice if this plugin could download only the drivers that are needed for the current OS, since that would make the build faster and it's completely unnecessary to download drivers for other OSes ;)

This is possible by omitting the drivers tag.
From docs:
If no drivers are provided the latest drivers will be installed for the running platform and the bit version will be chosen as if it has not been provided (see rule below).

If no bit version is provided for a driver the bit will automatically be set to 32 if running the plugin on a windows or mac platform. However if running the plugin from a linux platform the bit will be determined from the OS bit version.

Yes but I don't need to download all drivers, only the gecko one ;)

Then use the following config
<drivers>
  <driver>
    <name>geckodriver</name>
  </driver>
</drivers>

ok cool didn't realized that this would work. Cool.
Now I had to specify the version and url since version 0.15.0 is not in the default list... (sent a PR that you applied for that, thxs! Would need it released to be perfect ;)).

I merged the repo PR so it should be available right away.

ok didn't realize that the plugin required an internet connection... hmm... Thanks anyway!

#31 fixes version selection for chromedriver on 64bit windows if you configure chromedriver like
<drivers>
 <driver>
    <name>chromedriver</name>
  </driver>
</drivers>

Fix #31 released in version 3.1.2


Blacklist Jupyter 5.0.

... due to issues with IOPub rate limiting (yes, there are ways around
this but pip install 'notebook!=5.0' is simpler).
attn @imatlab-helper
Planning to merge this myself after jupyter 5.1 comes out.  I don't want to document workarounds for 5.0 (https://github.com/imatlab/imatlab/issues/2#issuecomment-294107129, https://github.com/imatlab/imatlab/issues/24#issuecomment-318167728).
Thoughts?

This sounds reasonable to me.  Thanks!


Less hash for cooler links

Yeah man

Thanks. I use '##' to indicate links into the docs in release notes, and I guess I started pointlessly typing them in docstrings as well. Merged.