Test "make" on Linux and OSX

Now that Henry and I have got the OSX build working on his machine, we need to check if it will work on the others. I have a feeling we will run into some problems, so I need everyone to pull the most recent version and try to make (inside the code folder).
If/when it fails, please let me know what the error is by posting it here. Also, please check inside your .stack-work folder for something along the lines of:
.stack-work/dist/x86_64-osx/Cabal-<IP_ADDRESS>/build and let me know what the full path to the build folder is.
Thanks!

Hi Dan.  I pulled the most recent version and I believe that everything worked.  There were some errors, but I believe those are known errors.  I'll attach the full output of make, in case my assumption is incorrect.  As far as the folder for the work, it is the same as the one you suggested:
.stack-work/dist/x86_64-osx/Cabal-<IP_ADDRESS>/build
Full output of make:
drasil-0.0.6: unregistering (components added: exe:swhs)
drasil-0.0.6: build
Preprocessing library drasil-0.0.6...
Preprocessing executable 'chipmunkdocs' for drasil-0.0.6...
Preprocessing executable 'glassbr' for drasil-0.0.6...
Preprocessing executable 'pcm' for drasil-0.0.6...
Preprocessing executable 'ssp' for drasil-0.0.6...
Preprocessing executable 'swhs' for drasil-0.0.6...
Preprocessing executable 'tiny' for drasil-0.0.6...
drasil-0.0.6: copy/register
Installing library in
/Users/smiths/Repos/litNew/code/.stack-work/install/x86_64-osx/lts-8.12/8.0.2/lib/x86_64-osx-ghc-8.0.2/drasil-0.0.6-AkbXHZWzOz36lG44xlYli9
Installing executable(s) in
/Users/smiths/Repos/litNew/code/.stack-work/install/x86_64-osx/lts-8.12/8.0.2/bin
Registering drasil-0.0.6...
make: [swhs] Error 1 (ignored)
make: [swhs] Error 1 (ignored)
make: [swhs] Error 1 (ignored)
make: [swhs] Error 1 (ignored)
make: [swhs] Error 1 (ignored)
drasil-0.0.6: unregistering (components added: exe:tiny)
drasil-0.0.6: build
Preprocessing library drasil-0.0.6...
Preprocessing executable 'chipmunkdocs' for drasil-0.0.6...
Preprocessing executable 'glassbr' for drasil-0.0.6...
Preprocessing executable 'pcm' for drasil-0.0.6...
Preprocessing executable 'ssp' for drasil-0.0.6...
Preprocessing executable 'swhs' for drasil-0.0.6...
Preprocessing executable 'tiny' for drasil-0.0.6...
drasil-0.0.6: copy/register
Installing library in
/Users/smiths/Repos/litNew/code/.stack-work/install/x86_64-osx/lts-8.12/8.0.2/lib/x86_64-osx-ghc-8.0.2/drasil-0.0.6-AkbXHZWzOz36lG44xlYli9
Installing executable(s) in
/Users/smiths/Repos/litNew/code/.stack-work/install/x86_64-osx/lts-8.12/8.0.2/bin
Registering drasil-0.0.6...
drasil-0.0.6: unregistering (components added: exe:ssp)
drasil-0.0.6: build
Preprocessing library drasil-0.0.6...
Preprocessing executable 'chipmunkdocs' for drasil-0.0.6...
Preprocessing executable 'glassbr' for drasil-0.0.6...
Preprocessing executable 'pcm' for drasil-0.0.6...
Preprocessing executable 'ssp' for drasil-0.0.6...
Preprocessing executable 'swhs' for drasil-0.0.6...
Preprocessing executable 'tiny' for drasil-0.0.6...
drasil-0.0.6: copy/register
Installing library in
/Users/smiths/Repos/litNew/code/.stack-work/install/x86_64-osx/lts-8.12/8.0.2/lib/x86_64-osx-ghc-8.0.2/drasil-0.0.6-AkbXHZWzOz36lG44xlYli9
Installing executable(s) in
/Users/smiths/Repos/litNew/code/.stack-work/install/x86_64-osx/lts-8.12/8.0.2/bin
Registering drasil-0.0.6...
drasil-0.0.6: unregistering (components added: exe:glassbr)
drasil-0.0.6: build
Preprocessing library drasil-0.0.6...
Preprocessing executable 'chipmunkdocs' for drasil-0.0.6...
Preprocessing executable 'glassbr' for drasil-0.0.6...
Preprocessing executable 'pcm' for drasil-0.0.6...
Preprocessing executable 'ssp' for drasil-0.0.6...
Preprocessing executable 'swhs' for drasil-0.0.6...
Preprocessing executable 'tiny' for drasil-0.0.6...
drasil-0.0.6: copy/register
Installing library in
/Users/smiths/Repos/litNew/code/.stack-work/install/x86_64-osx/lts-8.12/8.0.2/lib/x86_64-osx-ghc-8.0.2/drasil-0.0.6-AkbXHZWzOz36lG44xlYli9
Installing executable(s) in
/Users/smiths/Repos/litNew/code/.stack-work/install/x86_64-osx/lts-8.12/8.0.2/bin
Registering drasil-0.0.6...
make: [glassbr] Error 1 (ignored)
make: [glassbr] Error 1 (ignored)
make: [glassbr] Error 1 (ignored)
drasil-0.0.6: unregistering (components added: exe:chipmunkdocs)
drasil-0.0.6: build
Preprocessing library drasil-0.0.6...
Preprocessing executable 'chipmunkdocs' for drasil-0.0.6...
Preprocessing executable 'glassbr' for drasil-0.0.6...
Preprocessing executable 'pcm' for drasil-0.0.6...
Preprocessing executable 'ssp' for drasil-0.0.6...
Preprocessing executable 'swhs' for drasil-0.0.6...
Preprocessing executable 'tiny' for drasil-0.0.6...
drasil-0.0.6: copy/register
Installing library in
/Users/smiths/Repos/litNew/code/.stack-work/install/x86_64-osx/lts-8.12/8.0.2/lib/x86_64-osx-ghc-8.0.2/drasil-0.0.6-AkbXHZWzOz36lG44xlYli9
Installing executable(s) in
/Users/smiths/Repos/litNew/code/.stack-work/install/x86_64-osx/lts-8.12/8.0.2/bin
Registering drasil-0.0.6...
make: [gamephys] Error 1 (ignored)
make: [gamephys] Error 1 (ignored)
drasil-0.0.6: unregistering (components added: exe:pcm)
drasil-0.0.6: build
Preprocessing library drasil-0.0.6...
Preprocessing executable 'chipmunkdocs' for drasil-0.0.6...
Preprocessing executable 'glassbr' for drasil-0.0.6...
Preprocessing executable 'pcm' for drasil-0.0.6...
Preprocessing executable 'ssp' for drasil-0.0.6...
Preprocessing executable 'swhs' for drasil-0.0.6...
Preprocessing executable 'tiny' for drasil-0.0.6...
drasil-0.0.6: copy/register
Installing library in
/Users/smiths/Repos/litNew/code/.stack-work/install/x86_64-osx/lts-8.12/8.0.2/lib/x86_64-osx-ghc-8.0.2/drasil-0.0.6-AkbXHZWzOz36lG44xlYli9
Installing executable(s) in
/Users/smiths/Repos/litNew/code/.stack-work/install/x86_64-osx/lts-8.12/8.0.2/bin
Registering drasil-0.0.6...

@hmadej . @smiths could you test the version I just pushed (commit 0a63045c1de7af05e006bccfafecc06ce60ae929). If it works (I had issues with the exec command before, but it seems to be working) then we should be good on all OS.

It is going to take a bit of work for me to do this.  My version of Ubuntu only comes with GHC 7.8.4, so I'll need to update that first.

Latest version (commit 0a63045) works for me.

Alright @JacquesCarette , no real rush (except for when you want to test things :) ). I can spin up one of my old Linux VMs to test it right now, and I'm sure Steven will test it when he gets a chance since he's probably up-to-date.

I needed to update anyways.  Stack is installed, I'm currently installing ghc.

Hello Dan.  I'm not sure what you are looking for in the output of make.  There are some error messages, but I think they are the "known" errors.  I'll attach the full output of make:
stack build :swhs
drasil-0.0.6: unregistering (components added: exe:swhs)
drasil-0.0.6: build
Preprocessing library drasil-0.0.6...
Preprocessing executable 'chipmunkdocs' for drasil-0.0.6...
Preprocessing executable 'glassbr' for drasil-0.0.6...
Preprocessing executable 'pcm' for drasil-0.0.6...
Preprocessing executable 'ssp' for drasil-0.0.6...
Preprocessing executable 'swhs' for drasil-0.0.6...

Preprocessing executable 'chipmunkdocs' for drasil-0.0.6...
Preprocessing executable 'glassbr' for drasil-0.0.6...
Preprocessing executable 'pcm' for drasil-0.0.6...
Preprocessing executable 'ssp' for drasil-0.0.6...
Preprocessing executable 'swhs' for drasil-0.0.6...
Preprocessing executable 'tiny' for drasil-0.0.6...
drasil-0.0.6: copy/register
Installing library in
/Users/smiths/Repos/litNew/code/.stack-work/install/x86_64-osx/lts-8.12/8.0.2/lib/x86_64-osx-ghc-8.0.2/drasil-0.0.6-AkbXHZWzOz36lG44xlYli9
Installing executable(s) in
/Users/smiths/Repos/litNew/code/.stack-work/install/x86_64-osx/lts-8.12/8.0.2/bin
Registering drasil-0.0.6...
stack exec tiny
diff --strip-trailing-cr ./stable/tiny/SRS.tex ./SRS/SRS.tex &> log.log
diff --strip-trailing-cr ./stable/tiny/MG.tex ./MG/MG.tex >> log.log 2>&1
diff --strip-trailing-cr ./stable/tiny/SRS.css ./Website/SRS.css >> log.log 2>&1
diff --strip-trailing-cr ./stable/tiny/SRS.html ./Website/SRS.html >> log.log 2>&1
stack build :ssp
drasil-0.0.6: unregistering (components added: exe:ssp)
drasil-0.0.6: build
Preprocessing library drasil-0.0.6...
Preprocessing executable 'chipmunkdocs' for drasil-0.0.6...
Preprocessing executable 'glassbr' for drasil-0.0.6...
Preprocessing executable 'pcm' for drasil-0.0.6...
Preprocessing executable 'ssp' for drasil-0.0.6...
Preprocessing executable 'swhs' for drasil-0.0.6...
Preprocessing executable 'tiny' for drasil-0.0.6...
drasil-0.0.6: copy/register
Installing library in
/Users/smiths/Repos/litNew/code/.stack-work/install/x86_64-osx/lts-8.12/8.0.2/lib/x86_64-osx-ghc-8.0.2/drasil-0.0.6-AkbXHZWzOz36lG44xlYli9
Installing executable(s) in
/Users/smiths/Repos/litNew/code/.stack-work/install/x86_64-osx/lts-8.12/8.0.2/bin
Registering drasil-0.0.6...
stack exec ssp
diff --strip-trailing-cr ./stable/ssp/SSP_SRS.tex ./SRS/SSP_SRS.tex &> SSP_log.log
diff --strip-trailing-cr ./stable/ssp/SSP_MG.tex ./MG/SSP_MG.tex >> SSP_log.log 2>&1
diff --strip-trailing-cr ./stable/ssp/SSP_SRS.css ./Website/SSP_SRS.css >> SSP_log.log 2>&1
diff --strip-trailing-cr ./stable/ssp/SSP_SRS.html ./Website/SSP_SRS.html >> SSP_log.log 2>&1
stack build :glassbr
drasil-0.0.6: unregistering (components added: exe:glassbr)
drasil-0.0.6: build
Preprocessing library drasil-0.0.6...
Preprocessing executable 'chipmunkdocs' for drasil-0.0.6...
Preprocessing executable 'glassbr' for drasil-0.0.6...
Preprocessing executable 'pcm' for drasil-0.0.6...
Preprocessing executable 'ssp' for drasil-0.0.6...
Preprocessing executable 'swhs' for drasil-0.0.6...
Preprocessing executable 'tiny' for drasil-0.0.6...
drasil-0.0.6: copy/register
Installing library in
/Users/smiths/Repos/litNew/code/.stack-work/install/x86_64-osx/lts-8.12/8.0.2/lib/x86_64-osx-ghc-8.0.2/drasil-0.0.6-AkbXHZWzOz36lG44xlYli9
Installing executable(s) in
/Users/smiths/Repos/litNew/code/.stack-work/install/x86_64-osx/lts-8.12/8.0.2/bin
Registering drasil-0.0.6...
stack exec glassbr
diff --strip-trailing-cr ./stable/glassbr/GlassBR_SRS.tex ./SRS/GlassBR_SRS.tex &> GlassBR_log.log
make: [glassbr] Error 1 (ignored)
diff --strip-trailing-cr ./stable/glassbr/GlassBR_MG.tex ./MG/GlassBR_MG.tex >> GlassBR_log.log 2>&1
make: [glassbr] Error 1 (ignored)
diff --strip-trailing-cr ./stable/glassbr/GlassBR_SRS.css ./Website/GlassBR_SRS.css >> GlassBR_log.log 2>&1
diff --strip-trailing-cr ./stable/glassbr/GlassBR_SRS.html ./Website/GlassBR_SRS.html >> GlassBR_log.log 2>&1
make: [glassbr] Error 1 (ignored)
stack build :chipmunkdocs
drasil-0.0.6: unregistering (components added: exe:chipmunkdocs)
drasil-0.0.6: build
Preprocessing library drasil-0.0.6...
Preprocessing executable 'chipmunkdocs' for drasil-0.0.6...
Preprocessing executable 'glassbr' for drasil-0.0.6...
Preprocessing executable 'pcm' for drasil-0.0.6...
Preprocessing executable 'ssp' for drasil-0.0.6...
Preprocessing executable 'swhs' for drasil-0.0.6...
Preprocessing executable 'tiny' for drasil-0.0.6...
drasil-0.0.6: copy/register
Installing library in
/Users/smiths/Repos/litNew/code/.stack-work/install/x86_64-osx/lts-8.12/8.0.2/lib/x86_64-osx-ghc-8.0.2/drasil-0.0.6-AkbXHZWzOz36lG44xlYli9
Installing executable(s) in
/Users/smiths/Repos/litNew/code/.stack-work/install/x86_64-osx/lts-8.12/8.0.2/bin
Registering drasil-0.0.6...
stack exec chipmunkdocs
diff --strip-trailing-cr ./stable/gamephys/Chipmunk_SRS.tex ./SRS/Chipmunk_SRS.tex &> Chipmunk_log.log
make: [gamephys] Error 1 (ignored)
diff --strip-trailing-cr ./stable/gamephys/Chipmunk_MG.tex ./MG/Chipmunk_MG.tex >> Chipmunk_log.log 2>&1
diff --strip-trailing-cr ./stable/gamephys/Chipmunk_SRS.css ./Website/Chipmunk_SRS.css >> Chipmunk_log.log 2>&1
diff --strip-trailing-cr ./stable/gamephys/Chipmunk_SRS.html ./Website/Chipmunk_SRS.html >> Chipmunk_log.log 2>&1
make: [gamephys] Error 1 (ignored)
stack build :pcm
drasil-0.0.6: unregistering (components added: exe:pcm)
drasil-0.0.6: build
Preprocessing library drasil-0.0.6...
Preprocessing executable 'chipmunkdocs' for drasil-0.0.6...
Preprocessing executable 'glassbr' for drasil-0.0.6...
Preprocessing executable 'pcm' for drasil-0.0.6...
Preprocessing executable 'ssp' for drasil-0.0.6...
Preprocessing executable 'swhs' for drasil-0.0.6...
Preprocessing executable 'tiny' for drasil-0.0.6...
drasil-0.0.6: copy/register
Installing library in
/Users/smiths/Repos/litNew/code/.stack-work/install/x86_64-osx/lts-8.12/8.0.2/lib/x86_64-osx-ghc-8.0.2/drasil-0.0.6-AkbXHZWzOz36lG44xlYli9
Installing executable(s) in
/Users/smiths/Repos/litNew/code/.stack-work/install/x86_64-osx/lts-8.12/8.0.2/bin
Registering drasil-0.0.6...
stack exec pcm
diff --strip-trailing-cr ./stable/pcm/PCM_SRS.tex ./SRS/PCM_SRS.tex &> PCM_log.log
diff --strip-trailing-cr ./stable/pcm/PCM_SRS.css ./Website/PCM_SRS.css >> PCM_log.log 2>&1
diff --strip-trailing-cr ./stable/pcm/PCM_SRS.html ./Website/PCM_SRS.html >> PCM_log.log 2>&1
sh log_check.sh

SWHS_log.log IS NOT EMPTY -- DIFFERENCE
BETWEEN GENERATED AND STABLE OUTPUT FOUND

GlassBR_log.log IS NOT EMPTY -- DIFFERENCE
BETWEEN GENERATED AND STABLE OUTPUT FOUND

Chipmunk_log.log IS NOT EMPTY -- DIFFERENCE
BETWEEN GENERATED AND STABLE OUTPUT FOUND

ERROR IN GENERATED OUTPUT SEE ABOVE FOR -

        MORE DETAILS                -

@smiths yours is working properly, so there's no problem there :D I was having issues with some build directories having different names (so the executables weren't running), but I believe it is all cleared up now. Essentially, since I didn't have OSX I couldn't be sure it had worked.

Looks like it worked (with the expected failures) on Linux.  And as a bonus, I now have stack and GHC 8.0 installed.  I'll update my other machines later.

Works for me on Windows 7 & Ubuntu.

Alright, I got it to work on Linux Mint (which is considered an 'unsupported' distro for stack) as well as my Win7, so I think we can consider it working.
Should any other problems arise, they're likely machine-specific and not an issue with the Makefile itself.


sha1_mb: Add missing ISAL_ prefixes to base aliases

Commit 0106da915b7024075fc74900ff63fa931ac15475 somehow missed updating the base aliases, which broke build on architectures for which SHA1 routines were not specifically optimized, e.g. loongarch64.
This commit addresses that.
Fixes: 0106da915b7024075fc74900ff63fa931ac15475

Update:

applied clang-format
add forgotten  sign-off for the commit


[SPARK-45646][SQL] Remove hardcoding time variables prior to Hive 2.0

What changes were proposed in this pull request?

Remove the following hardcoding time variables prior to Hive 2.0
hive.stats.jdbc.timeout
hive.stats.retries.wait

Why are the changes needed?

It's kind of a cleanup since Spark 4.0 only supports Hive 2.0 and above.
The removal also reduces the warning message on spark-sql bootstrap.
Does this PR introduce any user-facing change?

Yes, it reduces the warning message on spark-sql bootstrap.
  ➜  $ build/sbt clean package -Phive-thriftserver
  ➜  $ SPARK_PREPEND_CLASSES=true bin/spark-sql
  NOTE: SPARK_PREPEND_CLASSES is set, placing locally compiled Spark classes ahead of assembly.
  23/10/24 15:42:22 WARN Utils: Your hostname, pop-os resolves to a loopback address: <IP_ADDRESS>; using <IP_ADDRESS> instead (on interface wlp61s0)
  23/10/24 15:42:22 WARN Utils: Set SPARK_LOCAL_IP if you need to bind to another address
Setting default log level to "WARN".
  To adjust logging level use sc.setLogLevel(newLevel). For SparkR, use setLogLevel(newLevel).
  23/10/24 15:42:23 WARN NativeCodeLoader: Unable to load native-hadoop library for your platform... using builtin-java classes where applicable
- 23/10/24 15:42:25 WARN HiveConf: HiveConf of name hive.stats.jdbc.timeout does not exist
- 23/10/24 15:42:25 WARN HiveConf: HiveConf of name hive.stats.retries.wait does not exist
  23/10/24 15:42:28 WARN ObjectStore: Version information not found in metastore. hive.metastore.schema.verification is not enabled so recording the schema version 2.3.0
  23/10/24 15:42:28 WARN ObjectStore: setMetaStoreSchemaVersion called but recording version is disabled: version = 2.3.0, comment = Set by MetaStore<EMAIL_ADDRESS>  23/10/24 15:42:28 WARN ObjectStore: Failed to get database default, returning NoSuchObjectException
  Spark Web UI available at http://<IP_ADDRESS>:4040
  Spark master: local[*], Application Id: local-1698133344448
  spark-sql (default)>

How was this patch tested?

Pass GA and manually test.
Was this patch authored or co-authored using generative AI tooling?

No.

cc @wangyum @yaooqinn @LuciferYang

CI is stuck, rebased(no code change since the first approval) to re-trigger CI.

Merged into master for Spark 4.0. Thanks @pan3793 @HyukjinKwon @yaooqinn

thanks @LuciferYang and all


Add prebuilt query encodings and test cases for SPLADE reproduction

What does this PR do?
Add pre-encoded topics (queries) for SPLADEv2 reproduction
Newly created pre-encoded topics using splade_distil_cocodenser_medium are showed as follows:
1. arguana: test
2. climate-fever: test
3. dbpedia-entity: test
4. fever: test
5. fiqa: test
6. hotpotqa: test
7. nfcorpus: test
8. nq: test
9. quora: test
10. scidocs: test
11. scifact: test
12. trec-covid: test
13. webis-touche2020: test
14. msmarco: dev-subset

Before submitting

[x] Did you write any necessary tests?
[x] Local test passed?

Codecov Report

Merging #1806 (125c3e9) into master (2e8e9fd) will increase coverage by 0.05%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##             master    #1806      +/-   ##
============================================
+ Coverage     57.83%   57.89%   +0.05%
  Complexity     1045     1045
============================================
  Files           175      175
  Lines          9913     9927      +14
  Branches       1362     1362
============================================
+ Hits           5733     5747      +14
  Misses         3699     3699
  Partials        481      481

Impacted Files
Coverage Δ

...in/java/io/anserini/search/topicreader/Topics.java
100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2e8e9fd...125c3e9. Read the comment docs.


KAFKA-16341: fix the LogValidator for non-compressed type

Context
Previously in the LogValidator, the offsetOfMaxTimestamp depends on two parameter check

timestampType
batch.toMagic

If the timestampType is LOG_APPEND_TIME, and the toMagic is larger or equals to MAGIC_VALUE_V2, then we assign offsetCounter.value - 1 to it, otherwise keep the initial value.
However, in KAFKA-14477, this was changed, which modify offsetOfMaxTimestamp no matter whether it's LOG_APPEND_TIME or not, but only verify the toMagic, which led to this issue. More details can be found in KAFKA-16310
Besides, in KIP-734, we have enables MAX_TIMESTAMP of listOffset, where the name shallowOffsetOfMaxTimestamp become confusing since we actually get the offset of the max timestamp at the record level, not in the batch level.
Solution

Fix the verifying logic. If it's LOG_APPEND_TIME, we choose the offset of the first record. Else, we choose the record with the maxTimeStamp.
rename the shallowOffsetOfMaxTimestamp to offsetOfMaxTimestamp

Test
test with
./gradlew clean core:test --tests kafka.log.LogValidatorTest
./gradlew clean client:test --tests org.apache.kafka.common.record.MemoryRecordsBuilderTest
./gradlew clean core:test --tests kafka.admin.ListOffsetsIntegrationTest
./gradlew clean core:test --tests kafka.log.LogSegmentTest
./gradlew clean core:test --tests kafka.log.LocalLogTest
./gradlew clean client:test --tests org.apache.kafka.common.record.MemoryRecordsBuilderTest

and it passed
Committer Checklist (excluded from commit message)

[ ] Verify design and implementation
[ ] Verify test coverage and CI build status
[ ] Verify documentation (including upgrade notes)

The fix is perfect. Please rewrite the test according to #15474. Putting all test cases together is more readable.

thanks for the quick review @chia7712 , sure let me address that

Please also address this comment in this PR: https://github.com/apache/kafka/pull/15474#discussion_r1520262997 . Thanks.

@johnnychhsu Could you please rebase code and address following comments.

update KIP-734 according to https://github.com/apache/kafka/pull/15476#discussion_r1523677272

complete the tests according to https://github.com/apache/kafka/pull/15474#discussion_r1524067155

remove the shallow part in RecordsInfo.shallowOffsetOfMaxTimestamp according to https://github.com/apache/kafka/pull/15474#discussion_r1520262997

Sorry that we bring some extra works to this PR, and thank to you for taking over this PR :)

thanks @junrao @chia7712 @showuon for the suggestions and comments!
I have updated the following:

rename the ValidationResult.shallowOffsetOfMaxTimestamp to ValidationResult.recordOffsetOfMaxTimestampMs
rename the RecordsInfo.shallowOffsetOfMaxTimestamp to RecordsInfo.recordOffsetOfMaxTimestampMs
modify some comments to replace the "shallow" wording
added tests in ListOffsetsIntegrationTest.testThreeRecordsInSeparateBatch

test with
 ./gradlew clean core:test --tests kafka.log.LogValidatorTest
./gradlew clean client:test --tests org.apache.kafka.common.record.MemoryRecordsBuilderTest
./gradlew clean core:test --tests kafka.admin.ListOffsetsIntegrationTest

and passed

test with
./gradlew clean core:test --tests kafka.log.LogSegmentTest
./gradlew clean core:test --tests kafka.log.LocalLogTest

and it passed

@johnnychhsu Could you check the failed tests?

@chia7712 thanks for the reminder.
Below are the failed tests from the build

Build / JDK 17 and Scala 2.13 / kafka.api.CustomQuotaCallbackTest.testCustomQuotaCallback()
Build / JDK 17 and Scala 2.13 / kafka.api.DelegationTokenEndToEndAuthorizationWithOwnerTest."testNoDescribeProduceOrConsumeWithoutTopicDescribeAcl(String, boolean).quorum=kraft, isIdempotenceEnabled=false"
Build / JDK 17 and Scala 2.13 / kafka.server.LogDirFailureTest.testIOExceptionDuringCheckpoint(String).quorum=kraft
Build / JDK 17 and Scala 2.13 / kafka.server.ReplicaManagerTest.testRemoteFetchExpiresPerSecMetric()
Build / JDK 11 and Scala 2.13 / org.apache.kafka.common.network.SslTransportLayerTest."testUngracefulRemoteCloseDuringHandshakeRead(Args).tlsProtocol=TLSv1.2, useInlinePem=true"
Build / JDK 11 and Scala 2.13 / kafka.api.ConsumerBounceTest.testConsumptionWithBrokerFailures()
Build / JDK 11 and Scala 2.13 / kafka.api.PlaintextConsumerTest.testExpandingTopicSubscriptions(String, String).quorum=kraft+kip848.groupProtocol=consumer
Build / JDK 11 and Scala 2.13 / kafka.network.DynamicConnectionQuotaTest.testDynamicListenerConnectionCreationRateQuota(String).quorum=kraft
Build / JDK 11 and Scala 2.13 / kafka.server.ControllerRegistrationManagerTest.testWrongIncarnationId()
Build / JDK 11 and Scala 2.13 / kafka.server.LogDirFailureTest.testIOExceptionDuringLogRoll(String).quorum=kraft
Build / JDK 11 and Scala 2.13 / kafka.server.ReplicaManagerTest.testRemoteFetchExpiresPerSecMetric()
Build / JDK 11 and Scala 2.13 / kafka.zk.ZkMigrationIntegrationTest.testNewAndChangedTopicsInDualWrite [1] Type=ZK, MetadataVersion=3.4-IV0, Security=PLAINTEXT
Build / JDK 11 and Scala 2.13 / org.apache.kafka.tools.MetadataQuorumCommandTest.testDescribeQuorumReplicationSuccessful [5] Type=Raft-Combined, MetadataVersion=3.8-IV0, Security=PLAINTEXT
Build / JDK 11 and Scala 2.13 / org.apache.kafka.trogdor.coordinator.CoordinatorTest.testTaskRequestWithOldStartMsGetsUpdated()
Build / JDK 8 and Scala 2.12 / kafka.server.LogDirFailureTest.testIOExceptionDuringLogRoll(String).quorum=kraft
Build / JDK 8 and Scala 2.12 / kafka.server.ReplicaManagerTest.testRemoteFetchExpiresPerSecMetric()
Build / JDK 8 and Scala 2.12 / org.apache.kafka.controller.QuorumControllerTest.testBootstrapZkMigrationRecord()
Build / JDK 8 and Scala 2.12 / org.apache.kafka.tools.MetadataQuorumCommandTest.testDescribeQuorumStatusSuccessful [2] Type=Raft-Isolated, MetadataVersion=3.8-IV0, Security=PLAINTEXT
Build / JDK 8 and Scala 2.12 / org.apache.kafka.tools.MetadataQuorumCommandTest.testDescribeQuorumStatusSuccessful [6] Type=Raft-Isolated, MetadataVersion=3.8-IV0, Security=PLAINTEXT
Build / JDK 21 and Scala 2.13 / org.apache.kafka.connect.integration.ExactlyOnceSourceIntegrationTest.testSeparateOffsetsTopic
Build / JDK 21 and Scala 2.13 / kafka.api.ConsumerBounceTest.testConsumptionWithBrokerFailures()
Build / JDK 21 and Scala 2.13 / kafka.api.SaslPlainPlaintextConsumerTest.testCoordinatorFailover(String, String).quorum=kraft.groupProtocol=classic
Build / JDK 21 and Scala 2.13 / kafka.api.SaslPlainPlaintextConsumerTest.testCoordinatorFailover(String, String).quorum=kraft+kip848.groupProtocol=classic
Build / JDK 21 and Scala 2.13 / kafka.api.SaslPlaintextConsumerTest.testCoordinatorFailover(String, String).quorum=kraft.groupProtocol=classic
Build / JDK 21 and Scala 2.13 / kafka.coordinator.transaction.ProducerIdManagerTest."testUnrecoverableErrors(Errors).error=INVALID_REQUEST"
Build / JDK 21 and Scala 2.13 / kafka.server.LogDirFailureTest.testIOExceptionDuringLogRoll(String).quorum=kraft
Build / JDK 21 and Scala 2.13 / kafka.server.LogDirFailureTest.testIOExceptionDuringLogRoll(String).quorum=kraft
Build / JDK 21 and Scala 2.13 / kafka.server.ReplicaManagerTest.testRemoteFetchExpiresPerSecMetric()
Build / JDK 21 and Scala 2.13 / org.apache.kafka.controller.QuorumControllerTest.testFenceMultipleBrokers()

test with
 ./gradlew cleanTest core:test --tests CustomQuotaCallbackTest --tests LogDirFailureTest --tests ReplicaManagerTest --tests ConsumerBounceTest --tests PlaintextConsumerTest --tests DynamicConnectionQuotaTest --tests ControllerRegistrationManagerTest --tests ZkMigrationIntegrationTest --tests SaslPlainPlaintextConsumerTest --tests ProducerIdManagerTest clients:test --tests SslTransportLayerTest tools:test --tests MetadataQuorumCommandTest connect:test --tests ExactlyOnceSourceIntegrationTest

and it passed
as for DelegationTokenEndToEndAuthorizationWithOwnerTest, which looks like a flaky test KAFKA-15411 I tried with
./gradlew cleanTest core:test --tests DelegationTokenEndToEndAuthorizationWithOwnerTest

and it succeed

I will take a look later.

I have rebase the PR to trigger QA again, and I will merge it if no related failed tests.

JDK 11 gets cancel. It should be fine as it gets test in previous QA
I run the failed tests on my local:
./gradlew cleanTest :tools:test --tests MetadataQuorumCommandTest.testDescribeQuorumStatusSuccessful --tests MetadataQuorumCommandTest.testDescribeQuorumReplicationSuccessful :storage:test --tests TransactionsWithTieredStoreTest.testSendOffsetsToTransactionTimeout --tests TransactionsWithTieredStoreTest.testAbortTransactionTimeout --tests TransactionsWithTieredStoreTest.testCommitTransactionTimeout :connect:runtime:test --tests org.apache.kafka.connect.integration.ExactlyOnceSourceIntegrationTest.testSeparateOffsetsTopic --tests org.apache.kafka.connect.integration.OffsetsApiIntegrationTest.testAlterSinkConnectorOffsetsOverriddenConsumerGroupId :metadata:test --tests QuorumControllerTest.testBootstrapZkMigrationRecord --tests QuorumControllerTest.testFenceMultipleBrokers --tests QuorumControllerTest.testBalancePartitionLeaders :trogdor:test --tests CoordinatorTest.testTaskRequestWithOldStartMsGetsUpdated :connect:mirror:test --tests IdentityReplicationIntegrationTest.testReplicateSourceDefault --tests MirrorConnectorsIntegrationBaseTest.testReplicateSourceDefault --tests MirrorConnectorsIntegrationBaseTest.testSyncTopicConfigs --tests MirrorConnectorsIntegrationExactlyOnceTest.testReplication --tests MirrorConnectorsWithCustomForwardingAdminIntegrationTest.testSyncTopicConfigs --tests MirrorConnectorsIntegrationTransactionsTest.testReplicateSourceDefault --tests MirrorConnectorsIntegrationSSLTest.testSyncTopicConfigs :core:test --tests DelegationTokenEndToEndAuthorizationWithOwnerTest.testNoConsumeWithDescribeAclViaSubscribe --tests DelegationTokenEndToEndAuthorizationWithOwnerTest.testDescribeTokenForOtherUserPasses --tests ConsumerBounceTest.testClose --tests ConsumerBounceTest.testConsumptionWithBrokerFailures --tests PlaintextAdminIntegrationTest.testElectPreferredLeaders --tests LogDirFailureTest.testIOExceptionDuringLogRoll --tests LogDirFailureTest.testIOExceptionDuringCheckpoint --tests ReplicaManagerTest.testRemoteFetchExpiresPerSecMetric --tests LogRecoveryTest.testHWCheckpointWithFailuresMultipleLogSegments

all pass, so I'm about to merge it

@johnnychhsu thanks for this contribution! please complete the follow-up:

3.6 branch has many conflicts so please file a PR for branch 3.6
update KIP-734 for the offset of max timestamp

I have backport to 3.7 manually due to less conflicts.


fix: fixed pagination problems

This PR:

removes the padding from the top and bottom (elements should not be padded IMO).
makes it so the focus ring is not cut off anymore.
makes it so the focus does not get lost when elements move.

Hey @jguddas if you remove the padding the scale animation will be break since it needs some space to display it, I had to use it because the overflow need to be the scroll one


Unable to install ros package with noetic container

Within the noetic container, trying to do:
apt update
apt install ros-noetic-rgbd-launch
return the following error:
E: Unable to locate package ros-noetic-rgbd-launch
as I can find this package on my PC, I suspect an architecture issue?

Hi @camelator, ROS Noetic is built from source in the container, because there aren't Noetic packages in apt for Ubuntu 18.04.  So you may need to build this package from source.

this is what I presumed.
now I am tring to build the package for about 6 hours because of dependencies
It is a shame that Jetson has no official image for Ubuntu 20 :(

hi @dusty-nv in this case, how would you recommend I manage a workspace for large projects with many dependencies? Do I build the dependencies from source with the ROS workspace during the docker build process then create an overlay?

Do I build the dependencies from source with the ROS workspace during the docker build process then create an overlay?

Yes, here is one such example that builds/installs packages on top of ROS2 container:   https://github.com/dusty-nv/jetbot_ros/blob/master/Dockerfile

ok, found the issues I had with dependencies.
I tried to add opencv to the dusty-nv images without success.
What is important is to change the docker parameters to run it with nvidia runtime:
/etc/docker/daemon.json
{
"runtimes": {
"nvidia": {
"path": "/usr/bin/nvidia-container-runtime",
"runtimeArgs": []
}
},
"default-runtime": "nvidia"
}
Then no issue to integrate cuda libs during a build step


[Feature Proposal] More intuitive way to extend default theme

This relates to https://github.com/tailwindcss/tailwindcss/pull/655
Overview
By exposing access to resolved configuration file users will be able to extend default theme in a more intuitive way.
const defaultConfig = require('tailwindcss/defaultConfig')

module.exports = {
  // ...
  theme: {
    borderWidths: {
      ...defaultConfig.theme.borderWidths,
      '10': '10px',
      '12': '12px',
    },
  }
}

Please see https://github.com/tailwindcss/tailwindcss/pull/756 for implementation details.

See #756 for details why this does not work as described.


SB-19964 adding mandatory fields for processing self-declared users

This must not be preserved in system settings. Closing down this PR.


Don't warn on structurally overlapping TypedDicts

( There's a chance my "bug" is considered a "feature", so I'll post it as feature)
Consider the following code. A1 has a loose definition of a while A2 has a strict definition of a. Their structure overlaps, so {"a": 1} could be considered as either one.
class A1(TypedDict, total=False):
   a: int

class A2(TypedDict):
   a: int

The following code triggers an error/issue "a" is not required in "type[A1]".
def run(param: A1):
   print (param)

var: A2 = {"a": 1}
run(var)

Suggestion:
Don't warn in these cases.
Reasoning:
Working around this kind of problem might include static type casting or the use of Any, which will make the code more prone to problems and less readable.

Pyright (the type checking upon which pylance is built) is correct in flagging this as a type violation.
The problem is that with type A2, the key a must exist and cannot be deleted. With type A1, a can be deleted.
def run(param: A1):
    del param["a"] # This is allowed for A1 but not for A2

var: A2 = {"a": 1}
run(var)
print(var["a"]) # Crash!

Not surprisingly, mypy also generates the same error for your code sample.
Refer to PEP 589 for details about how TypedDict works.

Thank you very much for taking the time to explain! 🙇
I indeed did oversee the mutability of the object.
So my proposal would only be possible if immutability of the object could be guaranteed.


Improve initial exception to user when grails server completely down

Due to recent refactorings, we now get the following obscure message to :  "Failure to initialize EnvironmentService;

Yes sorry this is my bad - was on my mental list to fix, glad it is on a real list now.


Added ChatBot Project

🛠 Issue (975)

Closes #
Description
Please include a summary of the change. Please also include relevant motivation and context. List any dependencies that are required for this change.
Type of change

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

Checklist:

[x] I have made this from my own
[x] I have taken help from some online resourses
[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[x] The title of my pull request is a short description of the requested changes.

ATTACH SCREEN-SHOTS / DEPLOYMENT LINK

You should write as Closes #975

Do not start working on any project before the issue is assigned to you


fix(routes): pagination count returning as string for postgres conns

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 100.0%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
514

Relevant Lines:
514

💛  - Coveralls


[ENHANCEMENT] [question] Is optimizely virtual thread / loom friendly?

Description
I wonder if optimizely is loom-friendly - e.g. does not pin the platform threads? I can see that you hardcode underneath platform thread, I would like to replace it with virtual one, currently I can do it only with nasty reflection
Benefits
Users of sdk can use its resources effectively. The very same goes for reactive apps.
Detail
No response
Examples
No response
Risks/Downsides
No response

I can see there is a bunch of synchronized methods which could be synchronized with ReentrantLock

@wyhasany thanks for your feedback! We do not support loom yet. Can you submit your feedback here for our future consideration?

What a product should I choose? Am I reaally need to do that? To allow support of loom you need to allow to inject external executor service and replace synchronized blocks with ReentrantLock.

@jaeopt any updates?

@wyhasany You can submit a ticket for "Feature Experimentation" > "SDKs and Agent" in the link above. Not clear what we should change in the SDK to support Loom. We'll look into it. If you want, you can also consider to submit a PR for the enhancement with backward compatibility for Java8+.

@wyhasany A new release (4.1.0) includes your PR to add this feature. Let us know if it works good for you.


cramtools-3.0/src/main/java/htsjdk/samtools/cram/lossy/Binning.java:61: error: unmappable character for encoding ASCII

Hi,
I am not sure this is a cramtools issue but maybe an issue with htsjdk which you have bundled in your source tree? anyway, looks there are some UTF8 or whatever encoded-chars left in the java file. Java8 is too picky about these, even in comment lines. :(
>>> Emerging (1 of 1) sci-biology/cramtools-3.0::science
 * cramtools-3.0.tar.gz SHA256 SHA512 WHIRLPOOL size ;-) ...                                                                                [ ok ]
 * Using: oracle-jdk-bin-1.8
>>> Unpacking source...
>>> Unpacking cramtools-3.0.tar.gz to /scratch/var/tmp/portage/sci-biology/cramtools-3.0/work
>>> Source unpacked in /scratch/var/tmp/portage/sci-biology/cramtools-3.0/work
>>> Preparing source in /scratch/var/tmp/portage/sci-biology/cramtools-3.0/work/cramtools-3.0 ...
>>> Source prepared.
>>> Configuring source in /scratch/var/tmp/portage/sci-biology/cramtools-3.0/work/cramtools-3.0 ...
Rewriting attributes
Rewriting ./build/build.xml
>>> Source configured.
>>> Compiling source in /scratch/var/tmp/portage/sci-biology/cramtools-3.0/work/cramtools-3.0 ...
Buildfile: /scratch/var/tmp/portage/sci-biology/cramtools-3.0/work/cramtools-3.0/build/build.xml

clean-dirs:

clean:
   [delete] Deleting: /scratch/var/tmp/portage/sci-biology/cramtools-3.0/work/cramtools-3.0/cramtools-3.0.jar

setup:
    [mkdir] Created dir: /scratch/var/tmp/portage/sci-biology/cramtools-3.0/work/cramtools-3.0/target/classes

compile:
    [javac] Compiling 82 source files to /scratch/var/tmp/portage/sci-biology/cramtools-3.0/work/cramtools-3.0/target/classes
    [javac] /scratch/var/tmp/portage/sci-biology/cramtools-3.0/work/cramtools-3.0/src/main/java/htsjdk/samtools/cram/lossy/Binning.java:61: error: unmappable character for encoding ASCII
    [javac]     // ???40 40
    [javac]        ^
    [javac] /scratch/var/tmp/portage/sci-biology/cramtools-3.0/work/cramtools-3.0/src/main/java/htsjdk/samtools/cram/lossy/Binning.java:61: error: unmappable character for encoding ASCII
    [javac]     // ???40 40
    [javac]         ^
    [javac] /scratch/var/tmp/portage/sci-biology/cramtools-3.0/work/cramtools-3.0/src/main/java/htsjdk/samtools/cram/lossy/Binning.java:61: error: unmappable character for encoding ASCII
    [javac]     // ???40 40
    [javac]          ^
    [javac] /scratch/var/tmp/portage/sci-biology/cramtools-3.0/work/cramtools-3.0/src/main/java/net/sf/cram/common/Utils.java:639: error: unmappable character for encoding ASCII
    [javac]         System.out.println(calculateMD5String("??????".getBytes()));
    [javac]                                                ^
    [javac] /scratch/var/tmp/portage/sci-biology/cramtools-3.0/work/cramtools-3.0/src/main/java/net/sf/cram/common/Utils.java:639: error: unmappable character for encoding ASCII
    [javac]         System.out.println(calculateMD5String("??????".getBytes()));
    [javac]                                                 ^
    [javac] /scratch/var/tmp/portage/sci-biology/cramtools-3.0/work/cramtools-3.0/src/main/java/net/sf/cram/common/Utils.java:639: error: unmappable character for encoding ASCII
    [javac]         System.out.println(calculateMD5String("??????".getBytes()));
    [javac]                                                  ^
    [javac] /scratch/var/tmp/portage/sci-biology/cramtools-3.0/work/cramtools-3.0/src/main/java/net/sf/cram/common/Utils.java:639: error: unmappable character for encoding ASCII
    [javac]         System.out.println(calculateMD5String("??????".getBytes()));
    [javac]                                                   ^
    [javac] /scratch/var/tmp/portage/sci-biology/cramtools-3.0/work/cramtools-3.0/src/main/java/net/sf/cram/common/Utils.java:639: error: unmappable character for encoding ASCII
    [javac]         System.out.println(calculateMD5String("??????".getBytes()));
    [javac]                                                    ^
    [javac] /scratch/var/tmp/portage/sci-biology/cramtools-3.0/work/cramtools-3.0/src/main/java/net/sf/cram/common/Utils.java:639: error: unmappable character for encoding ASCII
    [javac]         System.out.println(calculateMD5String("??????".getBytes()));
    [javac]                                                     ^
    [javac] 9 errors

BUILD FAILED
/scratch/var/tmp/portage/sci-biology/cramtools-3.0/work/cramtools-3.0/build/build.xml:147: Compile failed; see the compiler error output for details.

 Java 1.7.0 and 1.8.0 fail with the unprintable test characters, while 1.6.0 fails for other reasons (too old I assume).
Is there a recommended release to use, or will it work with 1.8.0 with a different locale?


ALT and VS knob rotating by themselves

With V5.5, setting up the ALT or the VS on the TBM930 AP, the knob randomly starts to rotate by themselves.
Clean of any addon except the navigraph data.

Seems to be FS related. My bad


Get orientation as Vector2 on Box2D Transform

Helps one avoiding have to sin and cos the returned angle from getRotation.

Added the changes you asked, :)

I avoided making an output parameter because that's not what getPosition do (I'm trying to make  what nearby code do), and I can't change getPosition to have an output parameter, because that would break existing code. Still is a possibility to use an overloaded method to change getPosition() and mark the old as deprecated. Thoughts?

My vector math is extremely rusty, so dummy question. Does this guarantee returning a unit length vector? I think so, if so, it should be documented, it's a nice guarantee to have.
Can you rebase and squash your changes into a single commit please?

Yes! sin² + cos² = 1. Since
Now now, my Git is extremely rusty, so dummy question: How do I rebase and squash my changes into a single commit?

The formatting needs to be fixed. There is some missing newlines and trailing tabs.

Yes! sin² + cos² = 1. Since a unit vector is a vector which has the same property x²+y²=1, then it means a vector [cos(theta), sin(theta)] will always be a vector of unit length.

Cool, can you add it to the javadoc?

Now now, my Git is extremely rusty, so dummy question: How do I rebase and squash my changes into a single commit?

Follow this tutorial.
Although first, apply the Eclipse formatter to fix the formatting issues.

Can we move towards moving the temp vectors out of the class and have it pass in as an argument? Or is there a particular reason for the box2d extension to still use that approach?
I'm not native English, but wouldn't direction be a better naming?


Regarding Regression Models

Hello João,
I have been trying to make regression models using the package. However, I'm having difficulty in trying to work on this. Can you show an example code of a regression model here for ML and DL?
Thank you,
Juliyan

Hi Juliyan,
Example with random forest regressor (ML):
rf = RandomForestRegressor()
model = SklearnModel(model=rf)
model.fit(regression_dataset)
metrics = [Metric(mean_squared_error), Metric(mean_absolute_error)]

# evaluate the model
test_score = model.evaluate(self.regression_dataset_test, metrics)

Example with deepchem models:
MolGraphConvFeat().featurize(train_dataset)

gcn = torch_models.GCNModel(n_tasks=1, graph_conv_layers=[32, 32], activation=None,
                            residual=True, batchnorm=False, predictor_hidden_feats=64,
                            dropout=0.25, predictor_dropout=0.25, learning_rate=1e-4,
                            batch_size=64, mode="regression")
model = DeepChemModel(gcn, epochs=2, use_weights=False, model_dir=None)
model.fit(train_dataset)

Example with keras:
from tensorflow.keras.layers import Input, Dropout, Dense, BatchNormalization, Activation
from tensorflow.keras.models import Sequential
from tensorflow.keras.optimizers import Adam
from tensorflow.keras.regularizers import l1_l2

MorganFingerprint().featurize(train_dataset)

def dense_builder(input_dim=None, hlayers_sizes=None, initializer='he_normal',
                  l1=0, l2=0, hidden_dropout=0, batchnorm=True, learning_rate=0.001):
    # hlayers_sizes was passed as a str because Pipeline throws RuntimeError when cloning the model if parameters are lists

    if hlayers_sizes is None:
        hlayers_sizes = [10]
    model = Sequential()
    model.add(Input(shape=input_dim))

    for i in range(len(hlayers_sizes)):
        model.add(Dense(units=hlayers_sizes[i], kernel_initializer=initializer,
                        kernel_regularizer=l1_l2(l1=l1, l2=l2)))
        if batchnorm:
            model.add(BatchNormalization())

        model.add(Activation('relu'))

        if hidden_dropout > 0:
            model.add(Dropout(rate=hidden_dropout))

    # Add output layer
    model.add(Dense(1, activation='linear', kernel_initializer=initializer))

    # Define optimizer
    opt = Adam(lr=learning_rate)

    # Compile model
    model.compile(loss='mean_squared_error', optimizer=opt)

    return model

model = KerasModel(model_builder=dense_builder, epochs=2, input_dim=2048, mode="regression")
model.fit(train_dataset)

Let me know if you have issues running this.


Remove function selector & portal opcodes

The avm_return function also seems to be unused, should it be removed as well?

I looked for portal opcode related code in transpiler, simulator, or circuit and did not find anything. This task thus consists in removing function selector flavor of GETENVVAR_16 opcode.


AttributeError when using uproot.pandas.iterate.

Hi I get the following error when doing
for df in uproot.pandas.iterate(files, "ntuple/DecayTree",
    namedecode="utf-8", branches=branches):

File "/afs/cern.ch/work/m/mmarinan/anaconda3/envs/analysis/lib/python3.7/site-packages/uproot/tree.py", line 126, in iterate
    arrays.index._start += globalentrystart
AttributeError: can't set attribute

Does PR #332 solve the issue?

It does thanks 👍

This will be included in uproot 3.10.0, a major release including TTree-writing!


Question about basic usage

Apologies since I know this is simple, but I'm not just understanding correctly. I have a simple stream block for letting a user upload multiple files which are then all looped through and displayed in a page template:
class DocumentBlock(blocks.StructBlock):
   # block allowing user to upload multiple images for single page
    title = blocks.CharBlock(required=True, help_text='add your title')

    # create list block
    docs = blocks.ListBlock(
        blocks.StructBlock(
            [

                ('related_document', DocumentChooserBlock(required=True)),
                ('title', blocks.CharBlock(required=True, max_length=100)),
                ('description', blocks.TextBlock(required=True, max_length=200)),

            ]
        )
    )

    class Meta:
        template = 'streams/document_block.html'
        icon = 'placeholder'
        label = 'Document Entries'

In order to implement preview-generator I need the path of the file I want a thumbnail for. However, I only have access to the file url in the template after a file has actually been uploaded. I'm confused about where to put this code:
cache_path = '/tmp/preview_cache'
file_to_preview_path = '/tmp/an_image.png'

manager = PreviewManager(cache_path, create_folder= True)
path_to_preview_image = manager.get_jpeg_preview(file_to_preview_path, width=1000, height=500)

It seem like I need to put it in the template since that is where I have {{doc.related_document.url}}, which can be put here: file_to_preview_path = '/tmp/an_image.png'
Thanks for any guidance you can give!

Right now I'm thinking I need to use Django custom template tags to make a function with the preview-generator code inside it. The function will take in the file name which I then use in: file_to_preview_path = f"/tmp/{file_name}.pdf"

Django custom template tags worked

Hi @vbroskas could you give a code snippet? It would be interesting for other django developers.

The template tag function is working but I'm having an issue with getting the preview image to work.
Preview-generator returns a path to the image, but I need the URL for the image so I can display it in a template. Once I figure out how to do this I'll post some snippets.


Fix URL Error

Resolves:  #26689
Change /zh/docs/user-guide/load-balancer to /zh/docs/tasks/access-application-cluster/create-external-load-balancer/

/assign @tengqm

Thank you for proposing this fix. However, we will not merge partial fixes as per stated in the guideline. To find out what are the upstream changes to be synced, do this:
./scripts/lsync.sh content/zh/docs/tutorials/services/source-ip.md

@Xunzhuo Please perform a "complete" update to this page. There are other changes not synced in this PR.


Peer code review

1.You should remove junk usings like here https://github.com/ImLewel/lab4_SDMT/blob/master/ToDoListApp/ToDoList.cs#L1-L6
using System; // <- this one
using System.Collections.Generic;  // <- this one
using System.Linq;  // <- this one
using System.Text;  // <- this one
using System.Threading.Tasks; // <- this one
using Newtonsoft.Json;

2.The savePath variable is hardcoded as "../../../data.txt". I think it`s better to avoid hardcoded paths and instead provide a more flexible approach, such as allowing the path to be passed as a parameter or configurable through a settings file.
https://github.com/ImLewel/lab4_SDMT/blob/master/ToDoListApp/ToDoList.cs#L10
3.The code lacks proper error handling.
4.Class names should use PascalCase, so consider renaming TDTask to TdTask to follow the convention.
https://github.com/ImLewel/lab4_SDMT/blob/master/ToDoListApp/Task.cs#L10
public class TdTask
{
   ...
}

4.Instead of using public fields, I think it`s  better to use properties with proper encapsulation (getters and setters) for better control and maintainability.  And maybe for better readability of code, you should add modifiers to fileds Like this:
    public string Caption { get; set; }
    public string Description { get; set; }
    public string DeadLine { get; set; }
    private readonly bool Done = false;
    private readonly CultureInfo Culture = new CultureInfo("en-EN");
    private readonly string Pattern = "yyyy dd MMMM HH:mm";

5.If you want to represent the absence of a deadline, it might be better to use a nullable type (DateTime?) for the deadLine property instead of using a string value like "No deadline."

    public DateTime? DeadLine { get; set; }

      [JsonConstructor]
      public TdTask(string caption, string description, DateTime deadline)
      {
          Caption = caption;
          Description = description;
          Deadline = deadline;
      }

      public TdTask(string caption, string description)
      {
          Caption = caption;
          Description = description;
          Deadline = null;
      }

Thanks, waiting for further reviews!


Add an API check/test for docker build -f Dockerfile

I noticed that while we have tests to make sure that people don't
specify a Dockerfile (via -f) that's outside of the build context
when using the docker cli, we don't check on the server side to make
sure that API users have the same check done. This would be a security
risk.
While in there I had to add a new util func for the tests to allow us to
send content to the server that isn't json encoded - in this case a tarball.
I also tweaked an error message that wasn't really accurate.
Signed-off-by: Doug Davis<EMAIL_ADDRESS>

Forgot to mention that in addition to the new test I also added a check in the code to block people from leaving the build context.

@duglin Already needs rebase :)

that was quick!  Rebase is done.

After reading #10323 I switched this to use filepath.

@jfrazelle ping

woohooo tests I love tests LGTM

Should this be in the 1.5 milestone, given that this (-f) is a new feature in Docker 1.5?

@thaJeztah good point. W/o the check it in 1.5 its a bit of security risk. @icecrime any chance of adding it?

Agree, it looks necessary for 1.5 :+1:

LGTM (@LK4D4 @tiborvass: are you available for a 3rd look?)

Clearing milestone so we can focus on the replacement PR #10513

Closing in favor of #10524


how about use text-davinci-002-render model?

It seems that text-davinci-002-render is origin ChatGPT model. It will generate more interesting answer.

No official api docs, not sure if it will work at all

There is leaked text-chat-davinci-002-20221122 but text-davinci-003 seems more factual.

No possible anymore, need to wait for new api for chatgpt, added option to set model so user can choose new models.


Area Preservation when dragging polygons.

When dragging polygons to different latitudes, area is not being preserved.
Specifically, when a polygon is created in towards the poles and brought towards the equator, its width is not adjusting appropriately. Height is adjusting though.
Steps to reproduce the issue: Can be done on main site https://geoman.io/leaflet-geoman

Create a circle over a northern country (like the uk)
Create a polygon over the same circle.
Drag the circle to the equator.
Drag the polygon to the same location at the equator.

In theory they should both remain the same size. However they distort in different ways.
Circle and polygon created in north with same shape.

Circle and polygon with different shapes after being dragged to the equator.

I don't really have a solution to this but thought I'd offer some findings on the matter.
This is probably due to the curvature of the earth and the way that leaflet handles it's coordinates.
check out the leaflet draw demo
Though you can't reproduce it exactly as polygons aren't draggable. If you draw a circle say over Iceland and a square over the circle:

Then drag them both down to the equator, a similar effect can be seen.

Hmm, interesting. I have had the topic when we fixed this for circles (and I believe they behave correctly currently). The question is if the difference between polygons and circles is correct or not.
I COULD imagine this being correct as polygons have dedicated coordinates that are moved while a circle only has a center and a radius and the circle is just... projected... not "real".
But this is purely a guess

@codeofsumit that was my thinking on this.
Kind of 'unexpected expected behaviour'.

#585 goes in the similar direction


Reimplement teams_controller.rb

Background:
The teams_controller.rb file contains operations on teams like listing of teams of an assignment/course, updating a team, deleting teams of an assignment/course, copying teams between two assignments or courses among others. The model team.rb contains a lot of functions, with probable violations of single responsibility principle and this needs to be reimplemented with care. The files do not benefit from the complex names the functions are given.
What needs to be done:
Emphasize on Single Responsibility Principle
There are a questionable amount of functions that are directed at copying teams and team members between parents (courses/assignments). There are a lot of class functions in the model, which could be bad design. While reimplementing, make sure that SRP is maintained. See if any code is repetitive, and can be cut down.
Improve naming
Some functions have confusing names. For example, the function “bequeath_copy” can definitely be given a better name if the functionality needs to be reimplemented. The over-populated “copy” related functions in this controller decrease the readability of the code.
Better comments
Bigger files and functions require better comments for readability.

Initial thoughts on the new model
@nitinjoseph11 Let me know what else we might need to consider
We will need to generate a new model and controller: TeamAssignment, TeamsAssignmentController.
The TeamAssignment model will need a database schema with a minimum of a team and assignment reference:
rails generate scaffold TeamAssignment team:reference  assignment:reference
In addition, the team model will need to have a team assignment and the Assignment needs to reference a team:
rails generate migration AddTeamAssignmentRefToTeam team_assignment:reference

The database schema will be
create_table "teams", id: :integer, force: :cascade, options: "ENGINE=InnoDB DEFAULT CHARSET=latin1" do |t|
t.string "name"
t.integer "parent_id"
t.string "type"
t.text "comments_for_advertisement"
t.boolean "advertise_for_partner"
t.text "submitted_hyperlinks"
t.integer "directory_num"
t.integer "grade_for_submission"
t.text "comment_for_submission"
t.integer "pair_programming_request", limit: 1
end
also, we will need to add the corresponding addition to the seeds.rb file, which will run when a post query is sent on Postman which should fetch us the db contents there which would mean the backend works fine.
We also need to write corresponding rspec tests for model and controller.


Refund: Convert Allocation and Support Trigger Action

WI-11563652
Critical Changes
Changes

Fixed amount opportunity Allocations will be converted to percentages when a partial refund is initiated
Support Opportunity Amount and Allocations calculation when the refund is created from the trigger

Issues Closed
Community Ideas Delivered
Features Intended for Future Release
Features for Elevate Customers
New Metadata
Deleted Metadata

we have JEST failure on this PR but it is not related to this work so we are merging and will address the JEST failure in a separate work stream


Remove requirement for protoc binary

Now that the schemas have isolated the problem of schemas development, I think we can remove protoc as a requirement in the development documentation. It's in development.rst. We already provide this documentation in the schemas here.
This issue can be closed when mentions of the protobuf binary are removed from the server code. I believe we can also remove the binary from travis since schemas isolates its use.

Related https://github.com/ga4gh/schemas/issues/828


*: add share code revoke api; add a config to allow disabling custom prom addr

add share code revoke api: In the past, we could not revoke the authorization code obtained through "Share TiDB Dashboard Sessions" and could only wait for it to expire. I added a new API to revoke all authorization codes by resetting the key.
add a config to allow disabling custom prom addr: For security reasons, we need to introduce a configuration item to disable the custom promtheus address to avoid SSRF attacks.

/cherry-pick release-7.5

/cherry-pick release-7.1


Update source of liftover in variant script

Use hail native helper functions to liftover GRCh38 varaints to GRCh37, rather than relying on the gnomad variant liftover hailtables.

@phildarnowsky-broad requesting review at your convenience. No real rush on this one.
This one has 3 commits, each smol. The one with real substance is the second one that actually updates the source of the liftover. I had been doing a funky thing using the gnomad liftover tables, but turns out hail has a convenience function for doing liftover for an arbitrary coordinate that makes things much simpler and faster.


replace _.extend in favor of Object.assign

Since Chromium 45 supports native Object.assign for merging objects. Let's get rid extends from underscore in favor of native method.

I guess you might need Object.setPrototypeOf for doing inheritance

I guess you might need Object.setPrototypeOf for doing inheritance

Object.assign and _.extends for merge objects (not inheritance) and the are equals.
Object.setPrototypeOfdoes something quite different.

sorry, got confused with @prototype

What benefit does this give?

What benefit does this give?

Just a little less depending of extend library. Why use extend function if browser has equal function?

Thanks for contributing!


Issue42

Adding clarifications in issue #42

Addresing issue #42

@pebaum - Hi Peter, please assist to approve and merge the content for this PR in relation to issue https://github.com/MicrosoftDocs/OfficeDocs-O365ITPro/issues/42. This PR had to be recreated to properly link to the right issue. Can you please help to merge the content?
Thank you.

@AndreaBarr - This PR can be closed. Thank you.


If more than one partition has a COS_* label, upgrade wont work

Reported to harvester folks: https://github.com/harvester/harvester/issues/3070
FC storage without multipath, so the disk is seen 4 times.
This seems to confuse elemental-cli as it will just try to mount the fist found partition for COS_STATE. We should make sure that we mount the ACTIVE COS_STATE (On upgrade it should be mounted RO and we remount it RW)
Patch that fixes it: https://github.com/Vicente-Cheng/elemental-cli/commit/5ccfbbc22f3870ab667408a9377af1649f770f8d
This patch could be backported to an older version to unblock the harvester upgrade path.
Harvester is using v0.0.14+gedc412

Reported to harvester folks: harvester/harvester#3070
FC storage without multipath, so the disk is seen 4 times.
This seems to confuse elemental-cli as it will just try to mount the fist found partition for COS_STATE. We should make sure that we mount the ACTIVE COS_STATE (On upgrade it should be mounted RO and we remount it RW)
Patch that fixes it: Vicente-Cheng@5ccfbbc
This patch could be backported to an older version to unblock the harvester upgrade path.
Harvester is using v0.0.14+gedc412

update the more clear patch here Vicente-Cheng@42611f5
thanks!

PR to specific branch for harvester here: https://github.com/rancher/elemental-cli/pull/350
As harvester uses luet for bringing the packages, we will also need to create an specific branch on cos-toolkit and bump elemental-cli in that branch so it gets pushed to the repos.
They are using<PHONE_NUMBER>1313-repository.yaml which sucks because its before we used the commit id to identify the repos :/
Looking to match the exact commit to that repository.yaml file
Extra info: using the green repo.

We are lucky, the package meta indicates that this was built on 17/04/2022 so there is only one push that day. The commit sha linked to harvester repository is https://github.com/rancher/elemental-toolkit/commit/087d40ce5c8c0a2c2160803491733a67f981a635

https://github.com/rancher/elemental-toolkit/tree/v0.8.9-11-harvester1 is the branch that supports the elemental-cli branch with he fix
We should probably also rework the workflows to publish on main AND that extra branch as part of the branch, otherwise  it wont be published

To me this unveils there could be corner cases where identifying partitions by default labels or partitions is not reliable enough. In fact there are cases in which it could actually make sense including more than one disk with valid Elemental layouts as @bk201 pointed out in https://github.com/rancher/elemental-cli/pull/350#issuecomment-1299969243.
So I believe there two different but closely related scenarios where we fail:

Multiple disks including elemental installations
Same physical device represented by multiple devices in udev database

For issue 1:
A possible fix for this could be making all labels configurable at install time. Which is currently not fully possible as the grub configuration is coupled with the layout (it includes label literals in its configuration). This would be a clean solution for the multiple disk including elemental partitions cases. This would require #297, one of the motivations of this card was to decouple as much as possible the static grub.cfg provided by the image to the installed layout (aka provide the rd.cos.oemlabel according to the installation setup instead of hardcoding it). Probably we should assume grub always gets the label values from a variable (which could be set at install/reset time) instead of hardcoding it.
Another option, probably more robust, could be relaying on UUIDs instead of labels. However this would not be possible for MSDOS partition tables we also support, probably time to deprecate (not drop) MSDOS support. If we relay on UUIDs we could set the UUID within the state yaml and keep a unique reference to partitions and find them by UUID as the first option, then fallback to label if missing and finally fallback to partition label.
For issue 2:
For these other weird cases where we have the same disk as different devices the state of both is not fully equivalent (mountpoints and such) I am not sure how to deal with it. I am wondering what happens if we mount persistent partition from device A but state partition from device B. This should be still ok right? So probably what we need is ensure calls to remounts and similar stuff are always pointing the right device. I believe the in those cases the logic belongs to places like https://github.com/rancher/elemental-cli/blob/29bbdc21d6d9bd6dac133458939a7835db4ee89c/pkg/types/v1/config.go#L330-L354 My problem here is how actually distinguish the appropriate device. Which would be the criteria? Any idea? Probably enforce using the mounted device of the currently running system?
Finally another point that this issue raises it that it would be nice to load state yaml confing during upgrades to get a better insight on the configuration. So probably all this can be somehow split in three different issues. @Itxaka do you have other ideas around this ? I see proper fixes require quite some work, probably we should brainstorm around it.

:+1: on sunsetting DOS partition tables

on the issue 2 (which I think its the one to tackle, more on this later) I guess it depends on the boot path.
If active/passive -> Mount whatever is mounted already, i.e. what has a mountpoint as that its the one being used and that we are able to remount RW.
if recover -> Mount whichever, we should really not care.
There is no other way we can work around this unless multipath is enabled and we use the md device no? To the system, both "disks" are different but they actually will have the same values everywhere, including UUIDs.
I mean, we could store the device in the state.yaml and use that to identify the "original" path for a given partition but...Im havent used FC storage, what happens if you install on /dev/sda but the system thinks you booted from /dev/sdb? Is that even possible?
On issue 1 -> I would disregard that. Not supported. Otherwise the whole cli has to change to support this. Is this something that any sane person is gonna do? Install elemental-based systems into several disks on the same server? Doesnt seems to me like a use-case, nor anything we have supports that use-case. I would mark it as non-supported and thats that.

on the issue 2 (which I think its the one to tackle, more on this later) I guess it depends on the boot path.

I agree this is the urgent one to tackle as if it raises there won't be easy workarounds. We should think how to gate that into a single place. Gonna check if there are other parts beyond the code I already pointed.

On issue 1 -> I would disregard that. Not supported. Otherwise the whole cli has to change to support this. Is this something that any sane person is gonna do? Install elemental-based systems into several disks on the same server? Doesnt seems to me like a use-case, nor anything we have supports that use-case. I would mark it as non-supported and thats that.

Well, it is not the whole cli has to change, elemental-toolkit should not relay on a hardcoded layout, we are not that far. We just need to get rid of label literals in elemental-toolkit (grub2 config and cloud-init OEM partition config). Also the use case reported by @bk201 if I got it right make sense to me. Imagine a harvester host deploying elemental teal nodes where VM disks are actual volumes/disks visible to the harvester host. In that case there could be a collision of labels.

Imagine a harvester host deploying elemental teal nodes where VM disks are actual volumes/disks visible to the harvester host. In that case there could be a collision of labels.

I dunno, for that it would require raw disks to be passed to the VMs if Im understanding this, so the harvester hosts would have several directly attached disks and those would appear on the hosts when looking by label. BUT that gets fixed by the issue 2, if its not mounted, ignore it for the upgrade.
Recovery its another beast but I dont think harvester does the upgrades via recovery, nor anything else (You can do the upgrade from active/passive, recovery should be to recover.
Seems to me a very minor case that will probably be fixed by the issue 2 fix as well, so I would ignore it for now.

Do we count this as fixed @davidcassany ? Patch is in and also patch provided to harvester, we could expand this further but it should be in a different card with no bug or high prio attached?

Yes I think this card can be closed, the bugfix is provided to harvester and we already fixed that on our main. I'd just close it


[BUG]: UAT| SBI payment issue

Describe the bug
*Generate notice/Summons via_https://dristi-kerala-uat.pucar.org/digit-ui/employee &
*make a  payment via _https://dristi-kerala-uat.pucar.org/digit-ui/citizen
To Reproduce
Steps to reproduce the behavior:

login with 'citizen ' creds_9034328347
go to 'pending task'  Payment for Notice via post.
do sbi 'Delivery Partner Fee' payment.
See error

Reference:
https://jam.dev/c/d54e8357-87e1-425e-8ea4-75af4dfcf089

Office IP is white-listed so any Other IP cannot access SBI E-payment


airline: There is an error in theme "ayu".

This message appears when you set the ayu theme in Neovim 0.4

This bug was introduced by 6375cd8. Line 87 in the file autoload/airline/themes/ayu.vim needs to be replaced with let s:I2 = s:Array('base6', 'base3').


Update unatteneded-upgrades template attribute reference to match name used in attribute file

The template used enabled, however the default attributes used enable.
This unifies both on using enable as the attribute name.

Thanks for the merge!


Feat: To create the Login Page

To create the login page of the official Website of IIITians Network
Developer can take reference from the below figma link given in below
Figma Design

I'd like to work on this issue, @DhairyaMajmudar


Flash messages

Flash messages are short text messages stored in a one-request cookie which is used to add that text (often in a banner or alert popup) to the next page load.
https://hexdocs.pm/phoenix/controllers.html#flash-messages
Should we sign these flash cookies? https://github.com/lpil/wisp/issues/5

I made this middleware to use in my app https://hexdocs.pm/wisp_flash/index.html

Ah wonderful! Thank you!


Add simple example with onhover

I'm ok with adding it as it is. Thx!
One thing we should improve is the styling. For that, IMO we should start using what we already have, as much as we can, adding the airship css to the mix, instead of creating new css.
Could we reuse, at least some of the classes, from https://carto.com/developers/airship/reference/#/components/info-window ?

Added to the CH ticket


Can't seem to find .storybook/main.js

.storybook/main.js does not exist when trying to add this addon to a react expo app.
Wanting to use it to have both a web view and in device view.
These files do exist.
storybook/addons.js
storybook/rn-addons.js
Storybook 5.3.23

With -f it will force installation for react app.
npx sb init --type react -f

Then I can see the config file for .storybook/main.js
But it still seems to load the storybook directory if I just run yarn storybook had to start storybook with different script.
    "start-storybook-web": "cross-env NODE_OPTIONS=--openssl-legacy-provider<EMAIL_ADDRESS>    "build-storybook-web"<EMAIL_ADDRESS>
This guide helped I suppose
https://dev.to/ugglr/step-3-setting-up-storybook-with-react-native-web-show-your-mobile-components-the-browser-12ke

@LiamKarlMitchell if you want to use this addon you should be using npx sb init --type react
The react-native storybook has a different setup.
in this blog I have a getting started guide that might help
https://www.dannyhwilliams.co.uk/introducing-react-native-web-storybook

Thanks @dannyhw , I managed to get it showing I think, however do you also know of example with nativewind to make it show the tailwind in browser? Looked at the example in the other issue but couldn't seem to get it to work.
I mean tailwind is loaded in the react storybook but the class names from classNames="bg-blue-200" for example are not present it's like they get minified or something into one class name.

@LiamKarlMitchell I've been using nativewind myself and not having issues. Let me see if I can find that example.

Thanks @dannyhw , the example was linked by you here: https://github.com/storybookjs/addon-react-native-web/issues/45
But I can't seem to figure out why the class names for tailwind are not on the elements when I view them in storybook.

Sorry to hijack the issue :D, can probably close this one now and discuss on #45 ?
  "resolutions": {
    "autoprefixer": "^10.4.12",
    "postcss-preset-env": "^7.2.3",
    "postcss": "^8.4.19"
  },

Well setting up for both requires a bit more work but there are some templates i made for that
https://github.com/dannyhw/expo-template-storybook
And
https://github.com/dannyhw/react-native-template-storybook

Thanks Danny, I'll have to give these a go :)

Going close this as resolved, if you would like to reopen just let me know.


Fix typo

Fixes #35481

@Potapy4 : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@Potapy4 - thanks for catching these.


Dynamic Instance Domain Adaptation

Impressive work. Can' t wait to get the code. so when?!

https://github.com/Zhongying-Deng/DIDA


Change project name to Vueports

I mean, come on, this really seems like a missed opportunity here! 😎

This is a really nice idea, it needs some planning since this project is featured on awesome-vue but is doable.


Add Laravel 5.5 auto discovery

Add Laravel 5.5 auto discovery feature

Thank you!

Could you do a version bump to enable the auto discovery feature when installing through composer?
Thanks!

LOL, Sorry about that!


Windows SA: Audio/MIDI settings

Apologies for the semi-crazy diff.

Windows standalone is now a single header/source unit, and the main() file has been renamed and cleaned up.

Implemented a message manager to make construction and handling messages easier
Audio/MIDI settings now work and state is saved as a JSON file in the same location as the plugin autosave and default states. We can also save plugin window position now
GUI handling has been much improved and most of the bugs have been fixed. There may be some remaining bugs in regards to resizing, however.
We are using Windows.Data.Json (using C++/WinRT that ships with the Windows SDK to avoid another dependency) for the settings

I have tried to be as minimally invasive to the standalone host to implement changing audio ins/outs, buffer sizes & sample rates, and MIDI devices. This should be double checked against the mac and linux versions for any breakage but the behavior should be the same on those platforms.

Closes #188.


Fix bug in resolving log message of user assertion

https://github.com/Consensys/mythril/blob/ca2dc138f856643784fa245ad29e02788f8cea2f/mythril/analysis/module/modules/user_assertions.py#L71-L81
The function decode_single() at L72 resolves log messages of user assertions. However, referring to the release notes of eth_abi, the function will return a python str instead of bytes if called with ABI type "string" since v2.0.0-alpha.1. Thus, the function will always fail silently as all exceptions will be catched by the except statement at L80.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.伊祁 seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.


Add installation note regarding non-numeric model IDs

The migration published during installation assumes that model IDs are integer fields (related #69). This causes issues when used on a project where IDs aren't numeric, e.g. UUIDs or similar. While this is easy to resolve, it would be helpful if this was noted in the installation instructions.
This PR adds a short note advising people to review/modify the published migration before running where they have non-numeric model IDs.

Thanks!


Optimize onsets and frames create_dataset

Hey there!
I noticed that the onsets and frames data processing was taking a lot longer than I expected. With some rough profiling I found that most of the runtime was being taken up by calls to audio_io.wav_data_to_samples. Additionally, I found that calls to audio_io.crop_wav_data were resulting in redundant calls to wav_data_to_samples. So I came up with this fix.
I ran a few tests directly comparing the old and new values of new_wav_data to verify that this code is functionally equivalent to the original. Running generate_train_set with TRAIN_DIRS=['AkPnBcht/MUS'], I got the following results with my gtx1080ti intel i7 desktop at home:

Original code: 57 min 22.20 sec
Optimized code: 2 min 56.36 sec

30 files, processed into 371 chunks.
This is around a 20x speedup :) On another dataset, this brought my overall processing time (including test data) down from 8 hrs to 45 min.
Also included in this commit are a couple more py3 compatibility fixes, and one aesthetic change that I found useful!

Awesome, thanks! Can you please confirm that it also works for py2?

Yup, ran it on a py2 environment and it works!


Text rendering monospaced

Some special characters are 2 parts. so when we draw with monospace they show in two pieces instead of one. Not sure where the font widths would be. maybe in the EXE?
https://user-images.githubusercontent.com/1035905/56608044-e5d7a600-65d7-11e9-86e3-12e6cc6a2467.png
related issue: https://github.com/MaKiPL/OpenVIII/issues/54

http://wiki.ffrtt.ru/index.php/FF8/FileFormat_TDW i guess this tdw has more than just the tim file. i'll try to parse it out.

okay monospace is fixed. though it only looks correct on new fonts from pc version old fonts VI of VIII barely has 1 pixel of anything there. so it looks like VII with anything other than the new font.
Just need to correct font zoom I have both games running at 720p and ours is drawing text a bit smaller.  I'm like I done the math... I will keep tweaking it but the monospace is fixed.


Pull-secret dialog alternative

We need to come up with a solution to more clearly indicate the location to get the pull-secret, as the palette option is hard to understand; not very visible and provides no information on the next step to solve this.
While we have:

https://github.com/containers/podman-desktop/issues/1920
https://github.com/containers/podman-desktop/issues/1992

It is not clear when this will be available.

We might be able to add a temporary dialog inside the askAndStorePullSecret function:
  extensionApi.window.showInformationMessage(`To pull container images from the registry, a pull secret is necessary.
  You can get a pull secret from the Red Hat OpenShift Local download page.
  Use the "Copy pull secret" option and paste the content.

  https://cloud.redhat.com/openshift/create/local`);

Two issues here, it is shown before the actual step where it is necessary, which is not ideal though still better than the current situation.
But second, this does not allow the link to be highlighted and clicked on.
@evidolob what are your thoughts on this?

Yes, we should provide a quick fix for this until we have a better solution to handle the modal dialog in the API of podman-desktop extensions.
Suggestion from @gbraad is nice!

Could we have that message in the placeholder being displayed both in the command palette and in the preferences?

We have also added a clear 'Obtain Pull-secret' on the dashboard, right under the initialize button.
Will see how much we can fit in the Preferences.

thanks @gbraad !

Ideally, this would have been a single dialog;


ci: disable prowox

Welcome to UESTC Open Source Commnunity 👏

Add a issue link after Fix:, if you have created a issue

/lgtm

/release-note-none

/hold

/retest

/hold cancel


While buffering, spinner should be shown even when other controls are hidden

Have you read the FAQ and checked for duplicate open issues?
Yes
What version of Shaka Player are you using?
master
Can you reproduce the issue with our latest release version?
No
Can you reproduce the issue with the latest code from master?
Yes
Are you using the demo app or your own custom app?
Demo
If custom app, can you reproduce the issue using our demo app?
N/A
What browser and OS are you using?
Chrome stable on Linux
For embedded devices (smart TVs, etc.), what model and firmware version are you using?
N/A
What are the manifest and license server URIs?
Any
What did you do?

Load content
Force buffering state in JS console with

shakaDemoMain.player_.isBuffering = () => true;
shakaDemoMain.player_.dispatchEvent(
    new shaka.util.FakeEvent('buffering', {buffering: true}));

What did you expect to happen?
The buffering spinner should show up immediately.
What actually happened?
The spinner only shows up when the mouse is over the controls.

Fixing this will require reorganizing the DOM.  Making the controls opacity: 0 means all of them.  So the spinner will have to be a peer of the controls, not a child.


Use term uncertain

In the controlled vocabularies for establishmentMeans and origin, you currently have:
Origin Uncertain
Presence Uncertain

I would change both to uncertain.

Do you agree or not? This hasn't been changed in the vocabs yet.
Pro tip: if in your commit message you write "Fixes #4" and merge to master, this issue will close automatically, with a reference to the commit.

Then I must be looking in the wrong place

I balked at "origin uncertain" as well (see my separate pull request). But this is as adopted by IUCN, so there is something to be said for being consistent with their vocabulary.


Fix issue in runtime picklers with singleton objects

Is it good to close this? I'm trying to clean up a little bit old PRs :smile:


refactor: move gRPC credential types example

This example shows how to use the IAM library to get different
credential types and then use those with a client library (in this case
Spanner). It did not belong in the "iam/" directory, it is an example
showing how to use two libraries at the same time.
I am planning to add even more examples of errr... uncommon gRPC credentials here.

This change is

Ping.


DCN Compilation support for nvcc 7.5

Issue summary
I have the following configuration below but at the very start of compilation, it throws the errors for all gpu modules:
nvcc --version

nvcc: NVIDIA (R) Cuda compiler driver
Copyright (c) 2005-2015 NVIDIA Corporation
Built on Tue_Aug_11_14:27:32_CDT_2015
Cuda compilation tools, release 7.5, V7.5.17
gcc --version

gcc (Ubuntu 5.4.0-6ubuntu1~16.04.12) 5.4.0 20160609
Copyright (C) 2015 Free Software Foundation, Inc.
/usr/bin/nvcc -DWITH_CUDA -I/home/jason/github/yolact/external/DCNv2/src -I/home/jason/anaconda3/envs/yolact-env/lib/python3.7/site-packages/torch/include -I/home/jason/anaconda3/envs/yolact-env/lib/python3.7/site-packages/torch/include/torch/csrc/api/include -I/home/jason/anaconda3/envs/yolact-env/lib/python3.7/site-packages/torch/include/TH -I/home/jason/anaconda3/envs/yolact-env/lib/python3.7/site-packages/torch/include/THC -I/home/jason/anaconda3/envs/yolact-env/include/python3.7m -c /home/jason/github/yolact/external/DCNv2/src/cuda/dcn_v2_im2col_cuda.cu -o build/temp.linux-x86_64-3.7/home/jason/github/yolact/external/DCNv2/src/cuda/dcn_v2_im2col_cuda.o -D__CUDA_NO_HALF_OPERATORS__ -D__CUDA_NO_HALF_CONVERSIONS__ -D__CUDA_NO_HALF2_OPERATORS__ --expt-relaxed-constexpr --compiler-options '-fPIC' -DCUDA_HAS_FP16=1 -D__CUDA_NO_HALF_OPERATORS__ -D__CUDA_NO_HALF_CONVERSIONS__ -D__CUDA_NO_HALF2_OPERATORS__ -DTORCH_API_INCLUDE_EXTENSION_H -DTORCH_EXTENSION_NAME=_ext -D_GLIBCXX_USE_CXX11_ABI=0 -gencode=arch=compute_61,code=sm_61 -std=c++11
nvcc fatal   : Unsupported gpu architecture 'compute_61'
error: command '/usr/bin/nvcc' failed with exit status 1
Helpful Resource: https://github.com/BVLC/caffe/issues/5141

Your CUDA version is too old for your GPU. You architecture (compute_61) is only supported by CUDA 8.0 and higher, so upgrading should fix this.


Add the ability to check the markup of a single reference block

Submit PR to ddhingra feature branch: https://github.com/ddhingra/elife-ingest-xsl/tree/feature/markup-test-dev-new


[Doc-enhancement] Deep link to chat shall open directly in teams app

Currently deep links to chat (example https://teams.microsoft.com/l/chat/0/0?users=) always open in the browser first and then redirect to the desktop app. but a left-over dummy window remains in the browser.
But if we replace https with msteams, it is opening Teams desktop client directly from web application.
Ex: “msteams://teams.microsoft.com/l/chat/0/0?users=”
If this is an intended behavior, updating in documentation will help.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 45541337-ecd7-5cf6-cbe4-3f0d2f39aa79
Version Independent ID: 6b4203f0-2844-06c9-eaa3-9cc03e6f76c0
Content: Create deep links to content - Teams
Content Source: msteams-platform/concepts/build-and-test/deep-links.md
Product: msteams
GitHub Login: @laujan
Microsoft Alias: lajanuar

@SubbaReddi - did you try using microsoftTeams.executeDeepLink(/deepLink/); ? More info here: Deep linking from your tab.

Hi @Wajeed-msft ,
As far as i understand, microsoftTeams.executeDeepLink is to navigate from Teams tab to chat/other content in teams.
But the scenario which i was checking is to navigate from web application opened in browser. microsoftTeams.executeDeepLink is not working in web application.

Checking internally, get back to you soon.

Using the msteams: protocol directly is not correct since that will only work in Windows. Teams launcher has logic that knows how to launch the Teams Desktop Client correctly on a variety of platforms (e.g. Windows, MacOS, Linux, iOS, Android, etc.). Bypassing it should be discouraged.


Remove the mentions of Azure supporting any kind of autoscaling

Closes https://github.com/giantswarm/giantswarm/issues/13649

13.0.0 will have autoscaling AFAWK.
I would leave this docs untouched.
WDYT?

13.0.0 will have autoscaling AFAWK.
I would leave this docs untouched.
WDYT?

So we'll have it the final version, but not in the alpha? Are we sure about that?

The reasoning is that the final version will use k8s 1.18, which is supposed to fix the issues with the autoscaler. Also, the final version will be tested before releasing.

Closing as per the comments above. Moved the cluster autoscaler docs removal to https://github.com/giantswarm/docs/pull/599


Several fixes

Thank you for pointing that out! PhpStan is integrated now and the errors on level 0 are fixed


RFC: induction with “fixed targets”

Context and status quo
Consider a function like merge (as known from mergesort):
universe u
def merge {α : Type u} (r : α → α → Prop) [DecidableRel r] : List α × List α → List α
  | ([], l') => l'
  | (l, []) => l
  | (a :: l, b :: l') => if r a b then a :: merge r (l, b :: l') else b :: merge r (a :: l, l')
  termination_by merge l => l.1.length + l.2.length

When proving things about this, I might be inclined to define a custom induction principle, like the following, which will directly focus on the four cases and give me suitable induction hypotheses:
theorem merge.induct {α : Type u} (r : α → α → Prop) [DecidableRel r] (motive : List α × List α → Prop)
  (case1 : ∀ (l' : List α), motive ([], l'))
  (case2 : ∀ (l : List α), ¬ (l = []) → motive (l, []))
  (case3 : ∀ (a : α) (l : List α) (b : α) (l' : List α), r a b → motive (l, b :: l') → motive (a :: l, b :: l'))
  (case4 : ∀ (a : α) (l : List α) (b : α) (l' : List α), ¬r a b → motive (a :: l, l') → motive (a :: l, b :: l'))
  (x : List α × List α) : motive x := sorry

But if I try to use it like this
theorem perm_length (l) : length (merge r l) = length l.1 + length l.2 := by
  induction l using merge.induct

I get 6 goals, including two unwanted ones for r and DecidbableRel r.
This is expected, as the current induction applies (roughly) the following rules about how to treat the induction principle’s parameters:

The motive is identified by its use in the result type, and is instantiated from the goal state.
The major premises (or “targets”) are the parameters to the motive in the result type (here: x)
Instance parameters are instantiated as MVars and filled using type class resolution.
Other implicit arguments are instantiated as MVars.
Other explicit arguments are considered alts, and turned into cases.

The code for this characterization is in getElimInfo and the actual instantiation, given the “targets“, happens in mkElimApp.
This explains why r is treated as an alt here.
Issues
This is, however, not a great user experience. One can continue the proof with
  case r x y => exact r x y

but to the user r really isn’t a “case” of the induction, and much more like the target l. In this case, both originate from parameters or merge, and it is not clear why they should be treated differently.
Furthermore, in this care r really should be instantiated explicitly, so that the [DecidableRel r] can be solved, and so that the real goals are free of uninstantiated ?r terms that could confuse users and tactics alike.
Proposed solution
The common origin of the fixed paraeter r and the major premise x suggests that a good UX would be to treat them the same, and allow (and require) the user to write
theorem perm_length (l) : length (merge r l) = length l.1 + length l.2 := by
  induction r, l using merge.induct

Consequences:

The list of expressions passed to induction here now consists of “fixed targets” and (regular) “targets”.
getElemInfo has to recognize them. I propose these rules:

targets remain those that are arguments to the motive in the result type.
alts are those explicit parameters of the eliminator that mention the motive.
fixedTargets are all other explicit parameters.

The induction tactic passes the fixedTargets to the induction principle, but (crucially) does not generalize them (in evalInduction).

Open questions
Will these rules treat something a fixedTarget that should be considered an alt? Maybe some side-condition on the major premise? For example, in the lemma (which as of today is not suitable to be used with induction)
Nat.decreasingInduction.{u_1} {m n : ℕ} {P : ℕ → Sort u_1} (h : (n : ℕ) → P (n + 1) → P n) (mn : m ≤ n) (hP : P n) : P m

the mn would be a fixedTarget. Is that desirable?
Alternative
An alternative would be to allow arbitrary terms after using, so that the user can write
theorem perm_length (l) : length (merge r l) = length l.1 + length l.2 := by
  induction l using merge.induct (r := r)

This is closer to how Isabelle solves this problem. I have been going back and forth between the two, and they both have their pros and cons. This variant is more powerful (you can instantiate implicit parameters, or even instantiate some alts), while the one above might be a bit simpler and more intuitive in the common case.
Community Feedback
I tossed these ideas around on zulip first.
Impact
Add :+1: to issues you consider important. If others benefit from the changes in this proposal being added, please ask them to add :+1: to it.

Fwiw, my gut feeling (based on reading this RFC, without playing with code) is that I find the using (r := r) a bit more intuitive than induction r, l. Because we're not inducting on r and actually want to keep it fixed.

Yeah, it’s a tough call.
For experts, i.e. those that can read the induction principle, or maybe even wrote it, and know roughly what induction does, (r := r) is certainly quite natural.
But if you put yourself in the shoes of someone who just wrote merge, and now want to use the (eventually) autogenerated merge.induct, understanding why r goes there and l goes here may pose a sizeable hurdle.
Happy to hear more points-of-view and arguments either way.
Maybe I should do the using <term> generalization first, as it doesn’t hurt and is useful as the more general one, and leave the other change to when and if we have evidence that the general syntax is too arcane?

Have you considered a separate tactic for induction schemes generated from recursive function definitions?
What you are doing reminds me a lot of coverset induction and how ACL2 generates induction schemes.  The syntax could be something like coverset (merge r l) and it would generate an induction scheme using the definition of merge and fill in the parameters with r and l to get the four cases.
Joe

No I haven't! That's an interesting alternative as well, I'll mull it over.
Does it also unfold merge for you, if the goal mentions it?


Thanks for this lib，how to set firstWeekday in this version？

in the old version，we can set 'firstWeekday' like this: "...calendar.firstWeekday = 1,2...",but in this version,  the 'firstWeekday' property went away. when the 'firstWeekday' come back ? and how to set 'firstWeekday' in the new version! ^_^ thank you！

Do you use self.calendar.calendarAppearance.calendar.firstWeekday = 1?
Because I don't have the problem. I think (try to remember) it may have a problem when you set the locale and the firstWeekday for NSCalendar, the locale override firstWeekday.

thank you for your reply !
i use the new version,and solve the problem about firstWeekday setting.
i tried this:
"_calendarManager.dateHelper.calendar.locale = [NSLocale localeWithLocaleIdentifier:@"zh_CN"];
_calendarManager.dateHelper.calendar.firstWeekday = 2;"
it works！
---------------------------------------------------separator-----------------------------------------------
Another question:
how to disable the year menu and weekday menu scrolling?

thanks a lot , have a good day! ^_^


Support Bagri on Apache Ignite

Apache Ignite is a JCache compilant and has allmost all features as Hazelcast.
I think it make sense implement Ignite support.

Hi Alexey. Initially, when the project just started, I had in mind to make it cache-agnostic. The first prototype was built on Oracle Coherence, actually. Then I moved to Hazelcast and now it'll be not so easy: the HZ infrastructure used not only for data storage, but for administrative tasks also. System nodes are managed from admin server via HZ tasks. This part is not easy to move to another JCache implementation... Will think about it..

Hi! I think it will be cool to abstract cache layer as much as possible.
Locking to HZ will reduce possible adoption of Bagri.
Ignite also has ability to run tasks.
It is possible to abstract all logic in base classes/interfaces and implement appropriate HZ implementations? And same for Ignite?
For example: SomeTaskClass -> SomeTaskClassHz & SomeTaskClassIgnite?
Other people could implement SomeTaskClassAnotherCacheImpl.

The major HZ feature used in Bagri is an ability to have several cache clusters within the same JVM. If the same is supported in Ignite then yes, it can be done. But I'd start from client side first. The task #5 is already here..

Yes, Ignite can run several nodes in same JVM.


Understanding fp8 static vs dynamic

Looking over here:
https://medium.com/squeezebits-team-blog/vllm-vs-tensorrt-llm-7-weight-activation-quantization-331cf9eadc0d
I'm seeing really negligible performance hit on dynamic vs static fp8, while static takes calibration and results in worse performance generally on downstream tasks. Is there any argument for static or is it just something of the past? What am I missing?

Static quantization is faster since you avoid calibration at inference time

There is a <1% end-to-end performance impact for static vs dynamic. We suggest using dynamic since accuracy will be better and more robust to outliers.


graph-tool import error: Incompatible libstdc++.so.6 version on HPC system

Comment:
Summary:
I'm attempting to use graph-tool (version 2.58) installed via conda-forge on my University's HPC system, but I'm encountering an import error due to an incompatible libstdc++.so.6 version.
Error Message:
ImportError: /sw/pkgs/arc/python3.9-anaconda/2021.11/bin/../lib/libstdc++.so.6: version `GLIBCXX_3.4.29' not found (required by /home/cstansbu/miniconda3/lib/python3.9/site-packages/graph_tool/libgraph_tool_core.so)

Troubleshooting Steps:

Verified LD_LIBRARY_PATH: I've set LD_LIBRARY_PATH to include a compatible libstdc++.so.6 prior to installing graph-tool via conda.
Checked Linkage: ldd libgraph_tool_core.so  indicates the shared object is correctly linked to the compatible libstdc++.so.6.
System Environment: The HPC environment might have a pre-existing libstdc++.so.6 in a standard path that is taking precedence.

Request:
I'd appreciate guidance on diagnosing the root cause: Why is the incompatible system libstdc++.so.6 being used despite the correct linkage?
System Specifications:
uname -a
>>> Linux gl0006.arc-ts.umich.edu 4.18.0-372.75.1.el8_6.x86_64 #1 SMP Thu Sep 21 18:03:22 EDT 2023 x86_64 x86_64 x86_64 GNU/Linux

lsb_release -a
>>>  LSB Version:    :core-4.1-amd64:core-4.1-noarch
>>>  Distributor ID: RedHatEnterprise
>>>  Description:    Red Hat Enterprise Linux release 8.6 (Ootpa)
>>>  Release:        8.6
>>>  Codename:       Ootpa

Additional Notes:

I suspect this issue might be specific to HPC environments with potentially conflicting libraries.
The HPC admin maintain several read-only conda distributions, which require local configuration. The conda environments are complex.

Verified LD_LIBRARY_PATH: I've set LD_LIBRARY_PATH to include a compatible libstdc++.so.6 prior to installing graph-tool via conda.

There should be no need to set LD_LIBRARY_PATH, and it is probably a bad idea.  Your own conda environment will include a compatible libstdc++.so in its own lib/ directory.  Judging from your error message above, it should be here:
/home/cstansbu/miniconda3/lib/libstdc++.so

BTW, it appears that you have installed graph-tool into your miniconda base environment.  You should probably try installing it to a dedicated environment, at least for testing purposes.
First, make sure your version of conda is up-to-date.  Since you appear to have multiple conda installations on your machine, be careful to work with your own base environment:
source /home/cstansbu/miniconda3/bin/activate base
conda install -n base 'conda>=24.5.0'

And then try installing graph-tool-base with the following command:
conda create -n gt --override-channels -c conda-forge 'graph-tool-base>=2.68'

And check to see if it was installed properly:
conda activate gt
python -c 'import graph_tool.all as gt'

If that works, you can try installing the full graph-tool package (which includes drawing dependencies).
conda install -n gt --override-channels -c conda-forge `graph-tool>=2.68`

If you're still having trouble, please reply with the output of conda info, along with a transcript of the commands you tried.

A fresh conda install worked. I will close.
Best,