authentication

Basic authentication support (with sane multiuser workflow):
• User will login with intended username in the beginning of the script
• They need not provide password (if they do, it’ll be ignored)
• User implicitly owns resources described in their config after POST /config
• If POST /config contains resources already owned by another user, respective error will be returned
• Re-logging with same username (without having logged out previously) will release any previously owned resources
• There’s no predefined list of usernames, nor will anybody be allowed to create it – hence, usernames will just be validated for having a certain length and containing alphanumeric chars
User will logout in the end of script
• If user was logged in, it will release previously owned resources
• If user was not logged in, it’s a no-op
• If user was logged in and didn’t explicitly logout, the resources will be released after X minutes of inactivity (or when apiserver is restarted)
No extra action required by user to send consecutive requests
• OpenAPI will implicitly insert username / password in header for each request
In any case, requests with header containing username that isn’t logged in will error out

This appears to be more of case of port location management as opposed to authentication.
At this time the sonic mgmt customer works under the assumption that they will manage port locations.
As a result the schemas and API do not include anything related to port location management.


Moderator's panel is covering content

Because of the extension, the Moderator's panel is covering profiles and content in Moderate All. Probably because of the size of the screen.  It will be fine if this will fit on every PC screen: https://prnt.sc/sj3693

Hmm, I will try to have a fix for this one. I the mean time, you can try to hide the panel when you don't need it or you can move the moderator panel from left side to right side of your screen by clicking the >> button at the bottom of the panel


crawler crash on old amazon widget

First of all, this is a very cool repo, I do some GO web crawling as well, but not as elaborate or complete as this wonderful project :raised_hands:
Describe the bug
I tried out seonaut to crawl one of my blogs and it had an ancient (and dysfunctional) amazon affiliate widget that caused the crawler to crash.
To Reproduce
Steps to reproduce the behavior:

place the below code onto a page to be crawled
start the crawler to have it discover it

(the HTML version, original is markdown)

Expected behavior
It should flag both link and image link as a regular error, but instead it crashes the currently running crawl:
SEOnaut-app  | 2024/08/04 09:33:31 callback function error: Get "https://ws-na.amazon-adsystem.com/widgets/q?_encoding=UTF8&MarketPlace=US&ASIN=0321966465&ServiceVersion=20070822&ID=AsinImage&WS=1&Format=_SL250_&tag=redacted-30-01": dial tcp: lookup ws-na.amazon-adsystem.com on <IP_ADDRESS>:53: no such host
SEOnaut-app  | panic: runtime error: invalid memory address or nil pointer dereference

This should be fixed in cc7dc26.
Thanks for reporting the issue.


Adding SkyPilot example for FlexGen

This PR is to add the SkyPilot example for the FlexGen benchmark. It will make the benchmark more reproducible and convenient to manage.
Several future TODOs for SkyPilot:

Use the memory filtering in the resources section (https://github.com/skypilot-org/skypilot/pull/1746) to make the example easier to run on different clouds, i.e.

resources:
  cpus: 32+
  memory_gb: 200+
  accelerators: T4

Add the support in changing the disk type to be used for the instance, so that we can run the commands that requires high performance SSD disks.

Tested:

[x] sky launch -c flexgen --use-spot --detach-setup ./flexgen/apps/task.yaml

One UX comment, the progress bar & cursor around the following section seems a bit weird. It doesn't show one line; and the cursor is not at the bottom line. Is it expected?

Yea.. that is a pretty annoying problem. It is indeed due to the parallel download, and I don't have a solution right now. Maybe we can leave it for the future.


Update overview.md

PR types

PR changes

Describe

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

感谢你的PR！ 这里确实反了


I'm open for drafts (as image).

Hi all, I really like the new detail-page. There is much less scrolling involved.
After trying it in the field there is one thing.
The current order is: Detail, Description, Logbook, Waypoints.
Wouldn't it make much more sense to swap Logbook and Waypoints?
Since when i'm in the field i only need the lookbok when i can't find a WP or anything.
This makes me scroll over the logbookpage alot when swapping from description to waypoints
Thus, my suggestion is to make the order:
Detail, Description, Waypoints, Logbook
Thanks in advance.

I am still voting for moving the attributes back from "description" to "details" but it seems I am the only one.
I often have to change the page because I always want to see the attirbutes before starting a cache-run.
What do the others think about that ?

Here's a screenshot from my device (HTC Desire): http://imgur.com/oTdVR

Looks quite the same on my screen.
So If we want to avoid scrolling in any case on the details page, I agree to wait for redesign.
On the other hand the "Watchlist" function is only randomly used by myself (and maybe also by other users), so as I suggested already somewhere, what about placing attributes between "Offline" and "Watchlist".
But of course in this case scrolling is necessary for adding to Watchlist.

Looks quite the same on my screen.
So If we want to avoid scrolling in any case on the details page, I agree to wait for redesign.
On the other hand the "Watchlist" function is only randomly used by myself (and maybe also by other users), so as I suggested already somewhere, what about placing attributes between "Offline" and "Watchlist".
But of course in this case scrolling is necessary for adding to Watchlist.

And we should not forget: There are devices with smaller screens. But this is definitely a point that we'll change later.

Cant wait to have it ;-)
On my Galaxy SII with rather large screen (but maybe the same resolution as yours ?!) it looks the same:
http://imgur.com/PMfWv

I would suggest, to remove the Offline-section from the Details..
Maybe instead of the home-button in the left upper corner (is someone using it?!) place there a SAVE-symbol. When it is already saved, overlay a reload-symbol.
I think more people are reloading a saved cache for the new logs, and not for new listing. But at the Logs it's now not available.. And up there, it's present on every page

The toolbar should follow the Android UI guidelines, and therefore it wouldn't be good to have such an action. At least not on the left. Additionally I must admit I don't want people be able to refresh a cache from every page. Refreshing all the time is not necessary for caching and for sure places a high additional load on the GC servers.

I am using the offline section from time to time to update a single cache.
I agree that it should be placed one a single point and that is the detail-page...I think it is good at the point where it is placed right now. Also if we would go to a symbol the storage-time information would get lost (beside the fact, that this information is not accurate sometimes....but thats another issue).
I have seen another new thing:
Now the own gcvote is displayed in a separate line (if available). Its nice but this take more space and the information is not that important. I was also fine with showing it in brackets after the votes.
Anyway this is only for found caches, thus its not that important.

The point for getting away the offline section was that you try to minimice the detail view by deleting single lines but the offline sections needs about 5 .. just for one thing.
And that people do more refresh caches if there is a better placed button is not true.. but now they must switch back to detail view, if they realy want.. I prefear to put refresh into the menuebutton-menu

Now the own gcvote is displayed in a separate line (if available). Its nice but this take more space and the information is not that important. I was also fine with showing it in brackets after the votes.

It has never been there before. The number in braces is the total number of votes.

to have as much information as possible

yes

and to make every bit of that configurable

not necessarily. With a clean design where you don't need to search through a long list, it would be ok also with all details. At the moment I miss the graphically eye candy.

If I look onto the current detail page I like it. All necessary information is included and nothing is useless.
So the only possible things are:

To make the details selectable
To redesign to save spacce

However the options for 2. are not many. You could make a smaller font and therefore compress the view, but that would make it less readable. Putting several things into one line would be another option, but also for this, therre is not much space. So I dont have any idea how it could be achieved without making restrictions to the users.
Be aware that is a very prominent page in c:geo because everyone needs it.
So in case you will drastically change it, users might not like it.
Anyhow I am open to a complete new idea of how to do it, but doubt this is possible.

I do also like the page as it is. But I think there would be a better option for "Offline" and "Watchlist".. It would also be possible to make those options in one line with pcitpictureure-buttons or so ...
Those two sections are using so much place, .. and it would be so much better to save place there and not with font-size or something like that.

I suggest that we collect some screenshots of other geocaching apps and how they show the same information. (We can also add screenshots of other apps if we think they show much information in a small place). That way it might be easier to discuss where we or others have advantages/disadvantages and what alternatives might exist. I do not say that we shall simply clone parts of other user interfaces, but I believe it's always good to get fresh ideas. I'm not sure, can we put those screenshots into the wiki or do we need to use an external image hoster?

I looked at screenshots from GeOrg, CacheBox, GeoBeagle, Columbus, Opencaching from Garmin and the official one. None of these are "nice". This seems to be a really difficult task.

Well, I didn't want to search for "nice" screens, but for alternatives to our long list. So for instance the neongeo screen shot shows how easy 3 or 4 different cache details can be shown in a row and that most labels are not needed if the icons are meaningful.

Removing the headers:

I believe that users can understand the interface without the header titles, so I'd vote yes to save the space. Nevertheless I'm not sure if I like the many lines. Maybe we can still improve that by graphics or style definitions.

Perfect !
So only if there are more than 9 attributes it will take more than one screen.
And only if there is the additional line for own gcvote .
I think its a good compromise for now.

Offtopic: Where are you ? 9000km to Niedersachsen ? :-)

Android default coordinates, 37.422006 -122.084095 => http://maps.google.com/maps?q=37.422006+-122.084095&hl=de&sll=52.616811,10.063194&sspn=0.352691,0.617294&vpsrc=0&t=m&z=17


MSID: 88775 Version: 2 DOI: 10.1101/2<IP_ADDRESS>5295

MSID: 88775
Version: 2
Preprint DOI: https://doi.org/10.1101/2<IP_ADDRESS>5295
Step 1. Awaiting reviews
Editorial to post reviews via hypothesis
Useful links:

DocMap: https://data-hub-api.elifesciences.org/enhanced-preprints/docmaps/v2/by-publisher/elife/get-by-manuscript-id?manuscript_id=88775
New model tracking: https://docs.google.com/spreadsheets/d/1_fHaoOy7hjyocptKtVJRijeNpUY4hBS7Ck_aVmx6ZJk/
Reviews on sciety: https://sciety.org/articles/activity/10.1101/2<IP_ADDRESS>5295

For trouble shooting (e.g. no Docmaps available):

DocMap issue addressing: https://miro.com/app/board/uXjVNCwK6EI=/
Explore DataHub DocMaps API: https://lookerstudio.google.com/reporting/4c2f0368-babb-4beb-b5b3-497e7e7b0f08/page/ejphD
Unmatched submissions and preprints: https://lookerstudio.google.com/u/0/reporting/9f86204f-3bf7-477c-9b18-5c5ef141bf69/page/p_gxi57ha93c
Unmatched manuscripts spreadsheet: https://docs.google.com/spreadsheets/d/15QcK8w-ssB7109RQEDtFpJPZ0J5HTGxoHa_2TtpMBbg/edit#gid=1336081641

Step 2. Preview reviewed preprint
Production QC content ahead of publication
Instructions:

QC preview: https://prod--epp.elifesciences.org/previews/88775v2
Update ticket with any problems (add blocked label)
When QC OK, add QC OK label to ticket and add publication date and time to https://docs.google.com/spreadsheets/d/1amAlKvdLcaDp5W8Z8g77NmkwbMF5n_u89ArSqPMO8jg
Move card to next column
(At end of the day post link in #enhanced-preprint and ask for PDF to be generated)

Useful links:

Preprint DOI :  https://doi.org/10.1101/2<IP_ADDRESS>5295
Confirm reviews returned by EPP: https://prod--epp.elifesciences.org/api/reviewed-preprints/88775/v2/reviews
To update the MECA path in the docmap: https://docs.google.com/spreadsheets/d/1mctCQuNFBjSn97Lihy7_vBO6z7-N-oqyLv4clyi6zHg

Step 3: Awaiting search reindex
This step adds the reviewed preprint to the homepage: https://elifesciences.org
The search reindex is triggered once an hour. We need the reviewed preprint to be indexed as the search application serves the journal homepage.
Useful links:

Jenkins pipeline to reindex search can be triggered sooner or monitored here: https://alfred.elifesciences.org/job/process/job/process-reindex-reviewed-preprints/

Step 4: Published! PDF requested
Waiting for PDF to be generated
Useful links:

PDF tracking: https://docs.google.com/spreadsheets/d/106_XeDjmuBae7gexOTNzg60lapeqjl2aRn9DzupGyS8/

Step 5: Introduce PDF to data folder and git repo
Upload PDF to relevent folder in git repo https://github.com/elifesciences/enhanced-preprints-data/
Step 6: Done!

[ ] Kettle is on!

Issues in structure


bug fix.

prevent other click until when complete to load transaction detail page.

Current coverage is 40.33% (diff: 100%)

No coverage report found for master at 8b2b8f8.

Powered by Codecov. Last update 8b2b8f8...c5ca9ff


Add debug error handler

Attempt to troubleshoot prod issues that we can't reproduce locally.
In prod after a few mins the index seems to through an uncaught exception that we can hopefully see in the logs once this is deployed.

Looks good!

Codecov Report

Merging #651 into master will decrease coverage by 0.26%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##           master     #651      +/-   ##
==========================================
- Coverage   35.83%   35.56%   -0.27%
==========================================
  Files          40       40
  Lines         932      939       +7
  Branches       24       23       -1
==========================================
  Hits          334      334
- Misses        598      605       +7

Impacted Files
Coverage Δ

...g/scalaexercises/exercises/ApplicationLoader.scala
0% <0%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 35b4458...212715a. Read the comment docs.


chore: bump Kit version in demo app

@geoffrich  apologies, it was a fall alarm. I was setting up the adapter on one of the apps in a mono-repo built with Turbo. I realised that it only throws the error for unresolved dependency of 'set-cookie-parser' if you use PNPM.
I initialised a second repo cause running some test and it works like a charm with NPM.
So it seems to be a PNPM issue rather than the adapter itself.


🐛 [firebase_messaging dev] iOS app is not receiving silent notification using 'firebase_messaging: 8.0.0-dev.9'

We have created a Mobile app using Flutter. We are using Firebase for Push Notification. We are using AWS SNS to send the push notification to firebase.
We are not receiving silent push notification on the iOS device. Other notification are working correctly.
We are using below Flutter packages:
firebase_core: ^0.5.2+1
firebase_crashlytics: 0.2.3+1
firebase_messaging: 8.0.0-dev.9

We are using below string to send notification in AWS SNS:
sns params:: { TargetArn:
'arn:aws:sns:us-east-1:142484709551:endpoint/GCM/Drov/e372e022-4aeb-3865-bb4f-30cb99055d1d',
Message:
'{"default":"This is a default message","GCM":"{\\"content_available\\":true,\\"data\\":{\\"title\\":\\"Refresh Page\\",\\"body\\":\\"Refresh Page\\",\\"sound\\":\\"default\\"}}"}',
MessageStructure: 'json' }

When we are using AWS SNS service to send the silent notification, we are getting success response from AWS SNS. However the mobile device is not receiving the silent notification.If we send silent notification using this link - https://fcm.googleapis.com/fcm/send, we are getting success response and the mobile device is getting the silent notification.

Hi @hirenvolansys
First off please upgrade to the latest firebase_messaging: ^8.0.0-dev.14 (this also means you have to upgrade the other firebase plugins to the latest). There have been a lot of improvements and stability fixes.
Secondly on sending notifications - you are using the deprecated FCM API, which means you will have to manually set "content_available": true for data-only notifications to iOS devices. It is recommended to move to the v1 FCM API instead, see https://github.com/FirebaseExtended/flutterfire/issues/4611#issuecomment-757917877 for more.
Does this solve the issue for you?
Thank you

Hi @hirenvolansys
First off please upgrade to the latest firebase_messaging: ^8.0.0-dev.14 (this also means you have to upgrade the other firebase plugins to the latest). There have been a lot of improvements and stability fixes.
Secondly on sending notifications - you are using the deprecated FCM API, which means you will have to manually set "content_available": true for data-only notifications to iOS devices. It is recommended to move to the v1 FCM API instead, see https://github.com/FirebaseExtended/flutterfire/issues/4611#issuecomment-757917877 for more.
Does this solve the issue for you?
Thank you

Hi @markusaksli-nc, Thanks for quick reply.
I will updated the package to the latest versions(firebase_messaging: ^8.0.0-dev.14).
We are using AWS SNS so I don't know AWS SNS is using which version of the FCM API.
Is that something we need to upgrade AWS SNS or we need to send the message directly using FCM API?

Hi @markusaksli-nc, Thanks for quick reply.
I will updated the package to the latest versions(firebase_messaging: ^8.0.0-dev.14).
We are using AWS SNS so I don't know AWS SNS is using which version of the FCM API.
Is that something we need to upgrade AWS SNS or we need to send the message directly using FCM API?

That was more of a comment on the post request you used for debugging purposes.
The problem is I'm not sure how AWS SNS is integrated with FCM exactly. From what I understand there are issues with using the two so you would be better off just using the API directly.
What steps did you follow to set up FCM in SNS?

That was more of a comment on the post request you used for debugging purposes.
The problem is I'm not sure how AWS SNS is integrated with FCM exactly. From what I understand there are issues with using the two so you would be better off just using the API directly.
What steps did you follow to set up FCM in SNS?

Steps to setup FCM in SNS:
We have configured a platform in SNS for mobile,
On the Create platform application page, under Details, do the following:

Enter an Application name.
For the Push notification platform, choose Firebase Cloud Messaging (FCM).
Under Firebase Cloud Messaging Credentials, paste the API key of FCM.

// Code in AWS function is as below >
var AWS = require('aws-sdk');
var snsClient = new AWS.SNS({ apiVersion: '2010-03-31' });
const publishParams = {
TargetArn: topicARN, // SNS endpoint
Message: JSON.stringify({
"default": "This is a default message",
"GCM": notificationObject
}),
MessageStructure: "json"
};
const sendNotificationResult = await snsClient.publish(publishParams).promise();
console.log('Push notification sent successfullyto mobile');

Steps to setup FCM in SNS:
We have configured a platform in SNS for mobile,
On the Create platform application page, under Details, do the following:

Enter an Application name.
For the Push notification platform, choose Firebase Cloud Messaging (FCM).
Under Firebase Cloud Messaging Credentials, paste the API key of FCM.

// Code in AWS function is as below >
var AWS = require('aws-sdk');
var snsClient = new AWS.SNS({ apiVersion: '2010-03-31' });
const publishParams = {
TargetArn: topicARN, // SNS endpoint
Message: JSON.stringify({
"default": "This is a default message",
"GCM": notificationObject
}),
MessageStructure: "json"
};
const sendNotificationResult = await snsClient.publish(publishParams).promise();
console.log('Push notification sent successfullyto mobile');

Since it works when sending through FCM directly it could be an incompatibility with the old GCM implementation in SNS. For now you could just try using the API directly.

Since it works when sending through FCM directly it could be an incompatibility with the old GCM implementation in SNS. For now you could just try using the API directly.


Lock Device Orientation in react-native-swiper

Which OS ?
Android
Version
Which versions are you using:

react-native-swiper v1.7.0
react-native v0.61.5

How To Lock Device Orientation in react-native-swiper

try to use useDimension from react-native if the width > height it will be landscape, if the hight > width it will be portrait


Peer Feedback

Hi guys! Great work on this project and some interesting results you shown. My feedback is small details mainly just around the documentation, analysis/reasoning and suggestions on communication.
Documentation - it is great overall. The only comment would be to have a raw data folder and processed data folder. I know that you have adapted the file names accordingly but perhaps for future.
Code - it is great!
Analysis/reasoning - somewhat

Usage of words like "hyperparameter" under the analysis section of your report - this may not make sense to a wider audience. I am referencing this post from Varada who said it best: https://ubc-mds.slack.com/archives/C24J4AVFZ/p1606457033427100
I am also unable to see your coefficients table under analysis!
Under the Limitations + Future section, you mention that for future, you will do Random Forest Regression but you have done your regression analysis above!
I don't see your references under the references section.

Other general suggestions -

Your readme usage section should be updated to reflect the new make all code rather than the individual scripts! So the user should just be able to run - "make all" rather than the scripts individually.
The first part of your readme mentions breast cancer images but your project is actually about housing prices in Alberta! This may just have been an oversight when copying over Tiffany's read me file.
You have produced a great makefile png but I wish it could be seen on the Readme file.

Hi Javaira,
Thank you very much for your detailed and meaningful feedback. We are taking action to address every issue and suggestion. Again, we appreciate you taking the time to contribute to our project in such an important manner.
Stay tuned =)


Migrate to OpenTelemetry

Given OpenTracing has now been superseded by OpenTelemetry, would you accept a pull request to migrate not.go to OpenTelemetry?

@josephwoodward do you have any examples/forks/etc of this for otel?


Correctly support version: "latest" for download_dsyms

Checklist

[x] I've run bundle exec rspec from the root directory to see all new and existing tests pass
[ ] I've followed the fastlane code style and run bundle exec rubocop -a to ensure the code style is valid
[x] I've read the Contribution Guidelines
[x] I've updated the documentation if necessary.

Motivation and Context
While trying to use the download_dsyms tool to download the Bitcoded dSYMs from iTC, I wanted to use the "latest" version as described in the documentation. Unfortunately it seems to ignore that option, and unless a specific version is stated, begins downloads dSYMs for all available versions in iTC.
I've tested this on my project locally and after the provided fix everything looks good

Description
It seems the "latest" codepath doesn't actually set the version retrieved from the call to Spaceship, and also doesn't warn if it can't retrieve that latest version.
note: While running rubocop It complains about Perceived complexity for run is too high. [19/18]. This warning is removed if I get rid of the test to make sure there is an available version. I prefer not to remove that check but can if you prefer so.
Let me know if there's any extra information needed !
Shai

I signed it!

Passing this here so it's clear why CI is failing. If this is an issue I can get rid of that test, but think its beneficial to have:

note: While running rubocop It complains about Perceived complexity for run is too high. [19/18]. This warning is removed if I get rid of the test to make sure there is an available version. I prefer not to remove that check but can if you prefer so.

Whops, really sorry for the delay here, taking a look now 👍

Thanks @KrauseFx. Seems this is passing tests now, just this CLA thing, which seems to be a manual merge you would need to do regardless of merge status ?

Thanks @KrauseFx ! And no worries :)


Build failure - XCode/C++ stdlib version?

Hi,
I thought I'd take a look at this in my quest to retire MacVim. As head allows including a pre-built binary I thought I'd try building from that rather than the v0.2 release which relies on an old patched version of Neovim.
In my first attempts the build failed (MacOS 13.5, Xcode 14.2, arm64) with three fatal errors all linked back to msgpack.hpp:
...
/Users/timhatch/Developer/neovim-mac/src/msgpack.hpp:21:10: fatal error:
      'coroutine' file not found
#include <coroutine>
         ^~~~~~~~~~~
1 error generated.

I compared msgpack.hpp in head with the v0.2 release and can see that it now calls #include <coroutine> where v0.2 called #include <experimental/coroutine> (and likewise there are a few functions in msgpack.hpp/.cpp which used std::experimental::suspend_never|suspend_always|coroutine_handle and have now dropped the experimental)
I guess this is an issue with Xcode (and its included C++ standard library) and I was able to get the build to succeed by adding back experimental.
EDIT: I see the switch from include <experimental/coroutine> to include <coroutine> was made in the last commit to fix warnings in Xcode 14.
If I'm correct, I guess the question would be whether to include some note in the readme about the required Xcode version (I don't know how otherwise to ensure that an up-to-date version of the C++ standard library is available).
Now that I've got everything up and running I'll have a play with the app, then perhaps hold my breath and update XCode...

This was changed in PR #21.
I was hoping Xcode would have coroutine support going back further than that. Probably something I should've verified first. For what it's worth things build on Xcode 14.3.1.
Will either add something to the README or some fallback logic for older compilers.


Add support for hyper::body::Sender equivalent in salvo

I'm working on HLS streaming and it is expensive to spawn ffmpeg and pipe the stdout to the response body so looking into doing that in a background thread. hyper supports hyper::body::Sender. Would be great if there is an equivalent of this api exposed in salvo.
#[handler]
async fn hello() -> Result<()> {
  let (mut sender,body)=hyper::body::Body::channel();

  tokio::spawn(async move { // or   std::thread::spawn(move || { ... })
    // Command::new() ... and send stdout to sender.
    sender.send_data(some_bytes).await?;
  });

  res.render(body)
  Ok(())
}

Or is this somehow already possible with streaming?

https://github.com/salvo-rs/salvo/blob/channel/examples/body-channel/src/main.rs


⚠ Bofrost.es has degraded performance

In b34ce9b, Bofrost.es (https://www.bofrost.es) experienced degraded performance:

HTTP code: 200
Response time: 1558 ms

Resolved: Bofrost.es performance has improved in e70ef0a after 14 minutes.


After manual install two operators error: Error: ImagePullBackOff

must-gather.local.7201955160566774722.zip
cluster: 3 master|1worker load|1worker infrastructure
OpenShift version: 4.11.0-0.okd-2022-07-29-154152
Two operators error: Error: ImagePullBackOff

Seems CVO is not applying OperatorHub spec correctly:
   managedFields:
    - apiVersion: config.openshift.io/v1
      fieldsType: FieldsV1
      fieldsV1:
        f:metadata:
          f:annotations:
            .: {}
            f:capability.openshift.io/name: {}
            f:include.release.openshift.io/ibm-cloud-managed: {}
            f:include.release.openshift.io/self-managed-high-availability: {}
            f:include.release.openshift.io/single-node-developer: {}
            f:release.openshift.io/create-only: {}
          f:ownerReferences:
            .: {}
            k:{"uid":"202e6090-cc42-48a0-a9f5-d77263c9e868"}: {}
        f:spec: {}
      manager: cluster-version-operator
      operation: Update
      time: "2022-08-03T09:49:48Z"
...
  spec: {}

Workaround: apply https://github.com/openshift/okd-machine-os/blob/master/manifests/99-okd-community-operators.yaml manually


"Fill match arms" assist removes comments

We need to preserve the useful trivia already located in the match body, otherwise, the assist totally erases it.

Also, as a side note, it would be better if the match arms body were curly braces because I frequently find myself changing the parentheses to curlies in order to start writing the match arm body.

Impl notes: instead of replacing the whole MatchArmList, we should "append" new arms. This should works similar to ItemList::append_items.
That is, in that edit.rs file we should add
impl ast::MatchArmList {
    #[must_use]
    pub fn append_arms(&self, arms: impl IntoIterator<Item = ast::MatchArm>) -> ast::MatchArmList {

    }
}

(As a general design note, all assists should prefer to copy/move/append existing ranges of syntax nodes, written out by the user, rather than trying to construct fresh nodes)


Code workflow

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: RishalCardoza sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.


Fix spacing for search summary panel

Why these changes are being introduced:
The current CSS rules for the search summary panel results in an unintended top margin if geospatial/advanced search terms are entered without a keyword.
Relevant ticket(s):
N/A
How this addresses that need:
This puts the top margin for applied terms on the ul elements instead of the li elements. It also adjusts the margin to match the others.
Side effects of this change:
N/A
Developer
Accessibility

[x] ANDI or WAVE has been run in accordance to our guide.
[ ] This PR contains no changes to the view layer.
[ ] New issues flagged by ANDI or WAVE have been resolved.
[ ] New issues flagged by ANDI or WAVE have been ticketed (link in the Pull Request details above).
[x] No new accessibility issues have been flagged.

New ENV

[ ] All new ENV is documented in README.
[ ] All new ENV has been added to Heroku Pipeline, Staging and Prod.
[x] ENV has not changed.

Approval beyond code review

[ ] UXWS/stakeholder approval has been confirmed.
[x] UXWS/stakeholder review will be completed retroactively.
[ ] UXWS/stakeholder review is not needed.

Additional context needed to review
This is unticketed because I noticed it while working on an unrelated ticket.
Code Reviewer
Code

[ ] I have confirmed that the code works as intended.
[ ] Any CodeClimate issues have been fixed or confirmed as
added technical debt.

Documentation

[ ] The commit message is clear and follows our guidelines
(not just this pull request message).
[ ] The documentation has been updated or is unnecessary.
[ ] New dependencies are appropriate or there were no changes.

Testing

[ ] There are appropriate tests covering any new functionality.
[ ] No additional test coverage is required.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

0 of 0   changed or added relevant lines in 0 files are covered.
1 unchanged line in 1 file lost coverage.
Overall coverage decreased (-0.2%) to 98.628%

Files with Coverage Reduction
New Missed Lines
%

app/controllers/search_controller.rb
1
98.11%

Totals

Change from base Build<PHONE_NUMBER>:
-0.2%

Covered Lines:
575

Relevant Lines:
583

💛  - Coveralls


Title: Laptop Price Prediction

Is your proposal related to a problem? Please describe.
The problem of my proposal is to design a laptop price prediction model based on important features of a laptop. We will be analyzing a given dataset and will get useful insights as well as design a prediction model for the same. @Kushal997-das Please assign me this issue for SWOC 23.
Add any other context or screenshots about the proposal request here.
No response

@aryaman1202 Create one issue at a time let complete the first one then i'll assign.

@Kushal997-das please assign this issue to me. Would like to contribute in this repository for SWOC' 23

@Kushal997-das Please assign the issue to me


HoverWidget - codicons are not vertically aligned

Steps to Reproduce:

Open a folder/workspace that contains a git repository
Open a file, make some changes, and create a commit
In the Source Control view hover over a particular commit in the incoming/outgoing section (notice that the codicons are not aligned)

Fixed with https://github.com/microsoft/vscode/pull/221251

I see this is styled differently now:

I assume that this alignment isn't needed anymore.

The layout of the hover changed, but the alignment fix can be observed with the "account" and "history" icons.


Duration of occurrence over DST boundary needs to be an exception

I’ve got a three hour event scheduled every week from midnight to 3am Sunday morning, and another event scheduled from 3am to 6am every Sunday. I’m using durations of three hours each.
On March 13, the three hour event starting at midnight goes until 4am, causing a time conflict with the event starting at 3am. Is it possible for that one occurrence to be two hours long? Or to specify in some other way that it must end at 3am?

sunday = Time.new(2016, 1, 31, 0, 0, 0)
schedule = IceCube::Schedule.new(sunday, duration: 3600 * 3) do |s|
  s.rrule(IceCube::Rule.weekly)
end
schedule.next_occurrences(8).map { |occurrence| occurrence.end_time.hour }

#=> [3, 3, 3, 3, 3, 3, 4, 3]

You can set an exception time (add_exception_time / extime) for your schedule, but there is no way to replace it with an occurrence of a different length. (Duration is global to the whole schedule.)
These occurrences still have the same duration, so they are technically valid. I don't think raising an exception applies.
What we could add is a method that tells you if the occurrence is affected by DST change. Something like this?
occurrence.dst_change?  #=> true
occurrence.dst_change  #=> 0 or -3600.0 or 3600.0

Depending on your circumstance you could subtract that from the end time. Would that work?


Deployment Schedule

[ ] Database Settings - add in settings.py

Add URL to facebook app dashboard, and to allowed_hosts
Install Postgres
Install packages

[ ] psycopg2
[ ] django v2.1.4
[ ] social-auh-app-django


Add attribute collecting to standard shader chunk

This pull request changes standard program lib in order to make in collect custom attributes from VertexShader by pc.shaderChunks.collectAttribs.
Afterwards, merges it with existing attributes.
I confirm I have signed the Contributor License Agreement.

Hey @mvaligursky - this PR has been open for 2 years! Wow. Can you take a look and make a final judgement with what to do with it please?

this cannot be added directly. As an example, it breaks instancing (engine/examples/#graphics/hardware-instancing.html).
Reason:
in standard.js, instancing is mapped to textcoords
https://github.com/playcanvas/engine/blob/f591bbeeb6ae6151f04f4e5ef0c11fcb1093e4b7/src/graphics/program-lib/standard.js#L546-L552
but in chunks.js, instancing is not part of attrib2Semantic
https://github.com/playcanvas/engine/blob/f591bbeeb6ae6151f04f4e5ef0c11fcb1093e4b7/src/graphics/chunks.js#L13-L28
and so it would add additional attribute "ATTR0". And that's not correct.
https://github.com/playcanvas/engine/blob/f591bbeeb6ae6151f04f4e5ef0c11fcb1093e4b7/src/graphics/chunks.js#L45
I think in ideal situation, we remove manual processing of attributes in standard.js, and only use the line this PR adds, similarly to how collectAttribs is used in particle.js - it just collects attributes, but does not add to attributes opening double adding issue.

@mvaligursky Since this PR is quite old, @Mikecoon may no longer be available to respond to your feedback (but let us know if you are!). If we don't hear anything, you may have to attack this yourself, or alternatively just close it. Let's give @Mikecoon a few days to respond though.

I'm here, but I don't quite follow what should I change to address it.
And seems like I removed this repo :c

I've decided to close this. It's a good idea, and I wish it would work, but our shader chunks contain more attributes than the final shader needs.
Example - looking at character shader that gets generated for one of the engine examples, and the chunk contains "attribute vec4 vertex_tangent;" and that line is added to vscode. But it is not used at all in that shader, as code that uses it is added conditionally based on some conditions is not included. In this shader, there's about 4 attributes that are in vshader code but not used by it.
So we cannot scan vshader and use all attributes from it.


Clean up workflows to fix references

The repo was migrated, but in some places the references to the artifacts in the prior location are still present (e.g., the one below). Those references should be fixed to point to the current repo. I do not think this is urgent at this point.
https://github.com/ImagingDataCommons/Cloud-Resources-Workflows/blob/1598c638d84726aa38b5b9896eca9b9746d45a7c/Terra/TotalSegmentator/splitWorkflow/twoVM.wdl#L109

Yes, I'm aware of that.
Also, could you take a look at the response we got from the dockstore community about the permissions? https://discuss.dockstore.org/t/dockstore-github-integration/7528/2

Also Docker images sources, such as here:
https://github.com/ImagingDataCommons/Cloud-Resources-Workflows/blob/e2967bebf922b605406aac97c155fd63d3406814/SevenBridges/TotalSegmentator/splitWorkflow/twoVM.cwl#L187-L188


Add parsing support for organizations, roles, people, etc.

Whois results, specifically the REST services, provide many organizations, roles, and person information. This data is currently not being parsed.
Pending analysis of common traits from each of the RIRs to create a new standard dictionary result for this data. Initial research indicates that some of this will result in additional queries per IP. For those cases, there may be a parameter for whether to pull that data or just provide a link.
I will update this thread with additional information as research progresses.

Further research uncovered that the new RDAP service is now live as of last month for ARIN, RIPE, LACNIC, and APNIC. I have not found a status on AFRINIC yet.
I am currently validating that all of these provide the same format output and expected results. If so, this is going to change the entire ipwhois library. I expect much less code, better results, and increased performance.
More updates to come...

I did not find country code information for ARIN's RDAP service (the other 3 RIR's provide it). Additionally, ARIN only provides address information un-parsed, in a inconsistent \n separated format, which differs from their restful API. I sent them an email, and here is their response:

Thanks for your questions regarding RDAP.

With regards to the country field, ARIN does not collect this information on networks. We only capture this information on organizations and points of contacts. Other RIRs do collect this information, and therefore they can populate that field in RDAP.

The issue regarding addresses has a similar cause. RDAP uses jCard (vCard for JSON) to represent postal addresses. jCard has two forms of addresses, structured and unstructured. ARIN uses the unstructured form because ARIN does not collect address information in structured form completely (city, state, country, and postal code are collected in a structured manner, but the street address is not).

I hope this answers your question, and thanks for your feedback.

I followed up with an email asking about parsing the country information from the address field, and if they have plans to provide a country code rather than the name (in all caps). I will update this thread when I get a response.
If ARIN parsing through RDAP is not an option, I may implement a standard parser for the other 3, and continue to use a custom parser to query ARIN's restful API.
More updates to come, including a standard result structure for RDAP.

It looks like I will need to stick with ARIN's restful interface for now, unless their country name matches the ISO name standard. Here is their response:

Yes, for ARIN the country will always be the last element in that set of values.

As for changing to the ISO country code, the jCard/vCard standard specifies that the name is to be spelled out. So we cannot change it to the ISO country code, unfortunately.

I am working on a quick fix for LACNIC (identified in https://github.com/secynic/ipwhois/issues/72), and will hopefully have something out this week/weekend, and will work on the overall major changes mentioned in this thread after.

Him did you push this in the version available on Pypi ?

The above mentioned fix for LACNIC https://github.com/secynic/ipwhois/issues/72 is the latest master release, and is published to PyPi: https://pypi.python.org/pypi/ipwhois/0.10.3. That fix does not contain the structure changes in this issue.
The major fixes mentioned in this issue (including the new enhanced return dictionary with people entities, etc) are not yet published to dev, master, or PyPi. Things are progressing very well with the items mentioned in this thread. I have split out RDAP and Whois functionality to their own files, and am finishing up writing the better structured classes. Once I have finished the new structure, I am going to push it to dev (hopefully very soon), and start working on improving debugging and logging.

Yes ok because with the version of franky branch add_person/add_person4all it's not working too. I planned to work on it, but if you already does some stuff, then I will wait.

Shouldn't be long. I am finishing up some parsing for RDAP and ironing out some bugs. Here is a preview of what the new lookup_rdap() return dictionary is looking like:
{
    'asn': '15169',
    'asn_cidr': '<IP_ADDRESS>/24',
    'asn_country_code': 'US',
    'asn_date': '2007-03-13',
    'asn_registry': 'arin',
    'entities': [{'contact': {'address': [{'type': None,
                           'value': '1600 Amphitheatre Parkway\nMountain View\nCA\n94043\nUNITED STATES'}],
                           'emails': None,
                           'kind': 'org',
                           'name': 'Google Inc.',
                           'phones': None,
                           'role': None,
                           'title': None},
               'depth': 0,
               'events': [{'action': 'last changed',
                           'actor': None,
                           'timestamp': '2013-08-07T19:59:17-04:00'},
                          {'action': 'registration',
                           'actor': None,
                           'timestamp': '2000-03-30T00:00:00-05:00'}],
               'events_actor': None,
               'handle': 'GOGL',
               'links': ['https://rdap.arin.net/registry/entity/GOGL',
                         'http://whois.arin.net/rest/org/GOGL'],
               'notices': None,
               'raw': None,
               'referrer': 'NET-74-125-0-0-1',
               'remarks': None,
               'roles': ['registrant'],
               'status': None}],
     'network': {'country': None,
             'end_address': '<IP_ADDRESS>',
             'events': [{'action': 'last changed',
                         'actor': None,
                         'timestamp': '2012-02-24T09:44:34-05:00'},
                        {'action': 'registration',
                         'actor': None,
                         'timestamp': '2007-03-13T12:09:54-04:00'}],
             'handle': 'NET-74-125-0-0-1',
             'ip_version': 'v4',
             'links': ['https://rdap.arin.net/registry/ip/<IP_ADDRESS>',
                       'http://whois.arin.net/rest/net/NET-74-125-0-0-1'],
             'name': 'GOOGLE',
             'notices': [{'description': 'By using the ARIN RDAP/Whois service, you are agreeing to the RDAP/Whois Terms of Use',
                          'title': 'Terms of Service'}],
             'parent_handle': 'NET-74-0-0-0-0',
             'raw': None,
             'remarks': None,
             'start_address': '<IP_ADDRESS>',
             'status': None,
             'type': None},
     'query': IPv4Address('<IP_ADDRESS>')
}

I mainly need to finish the entity object parsing (emails, phones, role, title) and enable recursive entity lookup (entities that have entities - there is a depth parameter to determine how deep to search).
The regular legacy whois functionality has also been converted to a new file/class structure, but it is looking like the output from that will remain unchanged (at least through the next release).

Wow that looks good man. Keep the good work,  this module really rocks.
On Sep 30, 2015 1:28 AM, "Philip Hane"<EMAIL_ADDRESS>wrote:

Shouldn't be long. I am finishing up some parsing for RDAP and ironing out
some bugs. Here is a preview of what the new lookup_rdap() return
dictionary is looking like:
{
'asn': '15169',
'asn_cidr': '<IP_ADDRESS>/24',
'asn_country_code': 'US',
'asn_date': '2007-03-13',
'asn_registry': 'arin',
'entities': [{'contact': {'address': [{'type': None,
'value': '1600 Amphitheatre Parkway\nMountain View\nCA\n94043\nUNITED STATES'}],
'emails': None,
'kind': 'org',
'name': 'Google Inc.',
'phones': None,
'role': None,
'title': None},
'depth': 0,
'events': [{'action': 'last changed',
'actor': None,
'timestamp': '2013-08-07T19:59:17-04:00'},
{'action': 'registration',
'actor': None,
'timestamp': '2000-03-30T00:00:00-05:00'}],
'events_actor': None,
'handle': 'GOGL',
'links': ['https://rdap.arin.net/registry/entity/GOGL',
'http://whois.arin.net/rest/org/GOGL'],
'notices': None,
'raw': None,
'referrer': 'NET-74-125-0-0-1',
'remarks': None,
'roles': ['registrant'],
'status': None}],
'network': {'country': None,
'end_address': '<IP_ADDRESS>',
'events': [{'action': 'last changed',
'actor': None,
'timestamp': '2012-02-24T09:44:34-05:00'},
{'action': 'registration',
'actor': None,
'timestamp': '2007-03-13T12:09:54-04:00'}],
'handle': 'NET-74-125-0-0-1',
'ip_version': 'v4',
'links': ['https://rdap.arin.net/registry/ip/<IP_ADDRESS>',
'http://whois.arin.net/rest/net/NET-74-125-0-0-1'],
'name': 'GOOGLE',
'notices': [{'description': 'By using the ARIN RDAP/Whois service, you are agreeing to the RDAP/Whois Terms of Use',
'title': 'Terms of Service'}],
'parent_handle': 'NET-74-0-0-0-0',
'raw': None,
'remarks': None,
'start_address': '<IP_ADDRESS>',
'status': None,
'type': None},
'query': IPv4Address('<IP_ADDRESS>')
}
I mainly need to finish the entity object parsing (emails, phones, role,
title) and enable recursive entity lookup (entities that have entities -
there is a depth parameter to determine how deep to search).
The regular legacy whois functionality has also been converted to a new
file/class structure, but it is looking like the output from that will
remain unchanged (at least through the next release).
—
Reply to this email directly or view it on GitHub
https://github.com/secynic/ipwhois/issues/71#issuecomment-144219747.

 Lots of logger code, tests, comments, and documentation to do before next release.

The output seems very promising. waiting for the dev push. thanks for your hard work.

Thanks for the kind words. Check the dev branch. Still working on more tests, logging, documentation, and some final tweaks.

Added for v0.11.0 release


[Backport 2.9] Cannot Provision RKE1 on vSphere

Backport for https://github.com/rancher/rancher/issues/47938

The fix can be validated on the latest v2.9-head image


Update conditional-rendering.mdx

Description
Again If condition update to make use of the condition variable and resolve any upcoming confusion about the code.

Could you add this to the other PR instead of a separate one?

@Maximilian-v-H I think if you edit the file on your branch for the PR: https://github.com/Maximilian-v-H/yew/tree/patch-1 it should work even from the web interface.


Add Spice lexer

Add the lexer implementation for the Spice language.

Merged, thanks a lot for your contribution!


how to use tags

hello, there is little documentation on how to use tags with this sentry sink.
the original sentry could create tags via the following:
  webBuilder.UseSentry((context, options) =>
                    {
                        var demoId = context.Configuration.GetValue<string>("DemoId");
                        if (!string.IsNullOrEmpty(demoId))
                        {
                            options.ConfigureScope(scope =>
                                scope.SetTag("DemoId", demoId));
                        }
                    });

and now every log entry had the tag set. this is helpful when somebody needs to identify multiple servers, etc.

Hi @schmitch,
The sink has tags parameters, which can contain a comma-separated list of tags.
Before sending an event, the sink tries to match Serilog properties with the tags collection, and if there are matches, these properties will be sent as tags.
Here is an example
new LoggerConfiguration()
    .WriteTo.Sentry("dsn", tags: "DemoId,UserId")
    .Enrich.WithProperty("DemoId", demoId)

...
// UserId and DemoId will be logged as tags
_log.Error("Something went wrong {UserId}", userId);

ok, that's cool. sadly it adds it to "additional data" not sentry tags.

Sorry, but I can't reproduce this, here is the full code:
int demoId = 5;
Log.Logger = new LoggerConfiguration()
	.WriteTo.Sentry("put_your_dsn_here", tags: "DemoId,UserId")
	.Enrich.WithProperty("DemoId", demoId)
	.CreateLogger();

// UserId and DemoId will be logged as tags
var userId = 10;
Log.Logger.Error("Something went wrong {UserId}", userId);

Here are the tags

Closed due to inactivity, feel free to reopen the issue.


Publish a new version at pypi

Hi,
Can you publish a new version of project at pypi? The current version is calling pypandoc.
from distutils.core import setup
import pypandoc

setup(
  name = 'zerobounce',
  packages = ['zerobounce'],
  version = '0.1.3',
  description = 'ZeroBounce Python API',
  long_description = pypandoc.convert("README.md", "rst"),
  author = 'Tudor Aursulesei',
  author_email =<EMAIL_ADDRESS>  url = 'https://github.com/zerobounce/zerobounce-python-api',
  download_url = 'https://github.com/zerobounce/zerobounce-python-api/archive/0.1.3.tar.gz', # I'll explain this in a second
  keywords = ['email', 'validation'], # arbitrary keywords
  classifiers = [],
)

bumped to 0.1.4


avoid putting user code inside unsafe blocks

In particular, raw_field! is a publicly exposed macro, and it could be used to execute unsafe operations without clients writing an unsafe block.

That's great, thank you :)
This looks important enough in order to avoid future user breakage that I should probably release another patch version today.

Hold off on the release; I plan to fix https://github.com/Gilnaa/memoffset/issues/52 this week-end. :)

This looks important enough in order to avoid future user breakage that I should probably release another patch version today.

I don't have any further PRs planned currently, so if you'd like to make another release, now is a good time. :)


Add Apache 2 license

Codecov Report

:exclamation: No coverage uploaded for pull request base (develop@b0788af). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             develop       #6   +/-   ##
==========================================
  Coverage           ?   26.36%
  Complexity         ?       36
==========================================
  Files              ?       14
  Lines              ?      220
  Branches           ?       27
==========================================
  Hits               ?       58
  Misses             ?      157
  Partials           ?        5

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b0788af...b555e81. Read the comment docs.


Color palette from image

Create a node which analyzes the colors of an input image and produces a palette in the form of a vec of colors as output.
A good starting point for some background reading: https://spin.atomicobject.com/2016/12/07/pixels-and-palettes-extracting-color-palettes-from-images/

I was searching for an opportunity to start contributing to the project, despite my non-artistic background.
It seems to my good entry point to it. @Keavon, I would to try solving this issue.
Is there more information that I should to know before starting?


Fix warnings on elixir 1.11

Currently, when we build the lib with elixir 1.11, we have the following warnings:
warning: Ecto.Query.Builder.Select.fields!/2 defined in application :ecto is used by the current application but the current application does not directly depend on :ecto. To fix this, you must do one of:

  1. If :ecto is part of Erlang/Elixir, you must include it under :extra_applications inside "def application" in your mix.exs

  2. If :ecto is a dependency, make sure it is listed under "def deps" in your mix.exs

  3. In case you don't want to add a requirement to :ecto, you may optionally skip this warning by adding [xref: [exclude: Ecto.Query.Builder.Select]] to your "def project" in mix.exs

  lib/scrivener/paginater/ecto/query.ex:81

warning: Ecto.Query.Builder.Select.apply/2 defined in application :ecto is used by the current application but the current application does not directly depend on :ecto. To fix this, you must do one of:

  1. If :ecto is part of Erlang/Elixir, you must include it under :extra_applications inside "def application" in your mix.exs

  2. If :ecto is a dependency, make sure it is listed under "def deps" in your mix.exs

  3. In case you don't want to add a requirement to :ecto, you may optionally skip this warning by adding [xref: [exclude: Ecto.Query.Builder.Select]] to your "def project" in mix.exs

  lib/scrivener/paginater/ecto/query.ex:94

warning: Ecto.Query.Builder.Select.apply/2 defined in application :ecto is used by the current application but the current application does not directly depend on :ecto. To fix this, you must do one of:

  1. If :ecto is part of Erlang/Elixir, you must include it under :extra_applications inside "def application" in your mix.exs

  2. If :ecto is a dependency, make sure it is listed under "def deps" in your mix.exs

  3. In case you don't want to add a requirement to :ecto, you may optionally skip this warning by adding [xref: [exclude: Ecto.Query.Builder.Select]] to your "def project" in mix.exs

  lib/scrivener/paginater/ecto/query.ex:88

warning: Ecto.Query.Builder.Select.apply/2 defined in application :ecto is used by the current application but the current application does not directly depend on :ecto. To fix this, you must do one of:

  1. If :ecto is part of Erlang/Elixir, you must include it under :extra_applications inside "def application" in your mix.exs

  2. If :ecto is a dependency, make sure it is listed under "def deps" in your mix.exs

  3. In case you don't want to add a requirement to :ecto, you may optionally skip this warning by adding [xref: [exclude: Ecto.Query.Builder.Select]] to your "def project" in mix.exs

  lib/scrivener/paginater/ecto/query.ex:81

warning: Ecto.Query.Builder.LimitOffset.apply/3 defined in application :ecto is used by the current application but the current application does not directly depend on :ecto. To fix this, you must do one of:

  1. If :ecto is part of Erlang/Elixir, you must include it under :extra_applications inside "def application" in your mix.exs

  2. If :ecto is a dependency, make sure it is listed under "def deps" in your mix.exs

  3. In case you don't want to add a requirement to :ecto, you may optionally skip this warning by adding [xref: [exclude: Ecto.Query.Builder.LimitOffset]] to your "def project" in mix.exs

  lib/scrivener/paginater/ecto/query.ex:44

warning: Ecto.Query.subquery/1 defined in application :ecto is used by the current application but the current application does not directly depend on :ecto. To fix this, you must do one of:

  1. If :ecto is part of Erlang/Elixir, you must include it under :extra_applications inside "def application" in your mix.exs

  2. If :ecto is a dependency, make sure it is listed under "def deps" in your mix.exs

  3. In case you don't want to add a requirement to :ecto, you may optionally skip this warning by adding [xref: [exclude: Ecto.Query]] to your "def project" in mix.exs

  lib/scrivener/paginater/ecto/query.ex:93

warning: Ecto.Query.select/3 defined in application :ecto is used by the current application but the current application does not directly depend on :ecto. To fix this, you must do one of:

  1. If :ecto is part of Erlang/Elixir, you must include it under :extra_applications inside "def application" in your mix.exs

  2. If :ecto is a dependency, make sure it is listed under "def deps" in your mix.exs

  3. In case you don't want to add a requirement to :ecto, you may optionally skip this warning by adding [xref: [exclude: Ecto.Query]] to your "def project" in mix.exs

  lib/scrivener/paginater/ecto/query.ex:81

warning: Ecto.Query.select/2 defined in application :ecto is used by the current application but the current application does not directly depend on :ecto. To fix this, you must do one of:

  1. If :ecto is part of Erlang/Elixir, you must include it under :extra_applications inside "def application" in your mix.exs

  2. If :ecto is a dependency, make sure it is listed under "def deps" in your mix.exs

  3. In case you don't want to add a requirement to :ecto, you may optionally skip this warning by adding [xref: [exclude: Ecto.Query]] to your "def project" in mix.exs

  lib/scrivener/paginater/ecto/query.ex:94

warning: Ecto.Query.select/2 defined in application :ecto is used by the current application but the current application does not directly depend on :ecto. To fix this, you must do one of:

  1. If :ecto is part of Erlang/Elixir, you must include it under :extra_applications inside "def application" in your mix.exs

  2. If :ecto is a dependency, make sure it is listed under "def deps" in your mix.exs

  3. In case you don't want to add a requirement to :ecto, you may optionally skip this warning by adding [xref: [exclude: Ecto.Query]] to your "def project" in mix.exs

  lib/scrivener/paginater/ecto/query.ex:88

warning: Ecto.Query.offset/2 defined in application :ecto is used by the current application but the current application does not directly depend on :ecto. To fix this, you must do one of:

  1. If :ecto is part of Erlang/Elixir, you must include it under :extra_applications inside "def application" in your mix.exs

  2. If :ecto is a dependency, make sure it is listed under "def deps" in your mix.exs

  3. In case you don't want to add a requirement to :ecto, you may optionally skip this warning by adding [xref: [exclude: Ecto.Query]] to your "def project" in mix.exs

  lib/scrivener/paginater/ecto/query.ex:43

warning: Ecto.Query.limit/2 defined in application :ecto is used by the current application but the current application does not directly depend on :ecto. To fix this, you must do one of:

  1. If :ecto is part of Erlang/Elixir, you must include it under :extra_applications inside "def application" in your mix.exs

  2. If :ecto is a dependency, make sure it is listed under "def deps" in your mix.exs

  3. In case you don't want to add a requirement to :ecto, you may optionally skip this warning by adding [xref: [exclude: Ecto.Query]] to your "def project" in mix.exs

  lib/scrivener/paginater/ecto/query.ex:44

warning: Ecto.Query.exclude/2 defined in application :ecto is used by the current application but the current application does not directly depend on :ecto. To fix this, you must do one of:

  1. If :ecto is part of Erlang/Elixir, you must include it under :extra_applications inside "def application" in your mix.exs

  2. If :ecto is a dependency, make sure it is listed under "def deps" in your mix.exs

  3. In case you don't want to add a requirement to :ecto, you may optionally skip this warning by adding [xref: [exclude: Ecto.Query]] to your "def project" in mix.exs

  lib/scrivener/paginater/ecto/query.ex:87

warning: Ecto.Query.exclude/2 defined in application :ecto is used by the current application but the current application does not directly depend on :ecto. To fix this, you must do one of:

  1. If :ecto is part of Erlang/Elixir, you must include it under :extra_applications inside "def application" in your mix.exs

  2. If :ecto is a dependency, make sure it is listed under "def deps" in your mix.exs

  3. In case you don't want to add a requirement to :ecto, you may optionally skip this warning by adding [xref: [exclude: Ecto.Query]] to your "def project" in mix.exs

  lib/scrivener/paginater/ecto/query.ex:80

warning: Ecto.Query.exclude/2 defined in application :ecto is used by the current application but the current application does not directly depend on :ecto. To fix this, you must do one of:

  1. If :ecto is part of Erlang/Elixir, you must include it under :extra_applications inside "def application" in your mix.exs

  2. If :ecto is a dependency, make sure it is listed under "def deps" in your mix.exs

  3. In case you don't want to add a requirement to :ecto, you may optionally skip this warning by adding [xref: [exclude: Ecto.Query]] to your "def project" in mix.exs

  lib/scrivener/paginater/ecto/query.ex:63

warning: Ecto.Query.exclude/2 defined in application :ecto is used by the current application but the current application does not directly depend on :ecto. To fix this, you must do one of:

  1. If :ecto is part of Erlang/Elixir, you must include it under :extra_applications inside "def application" in your mix.exs

  2. If :ecto is a dependency, make sure it is listed under "def deps" in your mix.exs

  3. In case you don't want to add a requirement to :ecto, you may optionally skip this warning by adding [xref: [exclude: Ecto.Query]] to your "def project" in mix.exs

  lib/scrivener/paginater/ecto/query.ex:54

warning: Ecto.Query.exclude/2 defined in application :ecto is used by the current application but the current application does not directly depend on :ecto. To fix this, you must do one of:

  1. If :ecto is part of Erlang/Elixir, you must include it under :extra_applications inside "def application" in your mix.exs

  2. If :ecto is a dependency, make sure it is listed under "def deps" in your mix.exs

  3. In case you don't want to add a requirement to :ecto, you may optionally skip this warning by adding [xref: [exclude: Ecto.Query]] to your "def project" in mix.exs

  lib/scrivener/paginater/ecto/query.ex:53

warning: Ecto.Queryable.to_query/1 defined in application :ecto is used by the current application but the current application does not directly depend on :ecto. To fix this, you must do one of:

  1. If :ecto is part of Erlang/Elixir, you must include it under :extra_applications inside "def application" in your mix.exs

  2. If :ecto is a dependency, make sure it is listed under "def deps" in your mix.exs

  3. In case you don't want to add a requirement to :ecto, you may optionally skip this warning by adding [xref: [exclude: Ecto.Queryable]] to your "def project" in mix.exs

  lib/scrivener/paginater/atom.ex:7

@drewolson We love to have a new release with this fix, will help in our migration to elixir 1.11.

@thiamsantos I should have a release out today.


Add go-vet shadow variable checking.

Description
We lost shadow variable checking when we moved from go tool vet to go vet. This PR fixes that oversight and any missed vars.
Reviewer Notes
Here are the problems I have to fix:
# github.com/transcom/mymove/cmd/ecs-service-logs
cmd/ecs-service-logs/main.go:287:10: declaration of "err" shadows declaration at line 271
# github.com/transcom/mymove/cmd/health_checker
cmd/health_checker/main.go:223:14: declaration of "err" shadows declaration at line 211
cmd/health_checker/main.go:254:14: declaration of "err" shadows declaration at line 242
# github.com/transcom/mymove/cmd/renderer
cmd/renderer/main.go:38:9: declaration of "err" shadows declaration at line 29
# github.com/transcom/mymove/pkg/auth
pkg/auth/cookie.go:120:11: declaration of "err" shadows declaration at line 113
# github.com/transcom/mymove/pkg/gen/dpsapi
pkg/gen/dpsapi/server.go:195:7: declaration of "err" shadows declaration at line 155
pkg/gen/dpsapi/server.go:225:7: declaration of "err" shadows declaration at line 155
# github.com/transcom/mymove/pkg/models
pkg/models/move.go:277:3: declaration of "verrs" shadows declaration at line 267
pkg/models/move.go:277:10: declaration of "err" shadows declaration at line 267
pkg/models/shipment_summary_worksheet.go:171:15: declaration of "err" shadows declaration at line 159
pkg/models/traffic_distribution_list.go:83:10: declaration of "err" shadows declaration at line 71
# github.com/transcom/mymove/pkg/gen/ordersapi
pkg/gen/ordersapi/server.go:195:7: declaration of "err" shadows declaration at line 155
pkg/gen/ordersapi/server.go:225:7: declaration of "err" shadows declaration at line 155
# github.com/transcom/mymove/pkg/uploader
pkg/uploader/uploader.go:99:10: declaration of "err" shadows declaration at line 50
# github.com/transcom/mymove/pkg/awardqueue
pkg/awardqueue/awardqueue.go:94:6: declaration of "err" shadows declaration at line 63
pkg/awardqueue/awardqueue.go:120:10: declaration of "err" shadows declaration at line 97
# github.com/transcom/mymove/cmd/generate_shipment_edi
cmd/generate_shipment_edi/main.go:98:26: declaration of "err" shadows declaration at line 59
cmd/generate_shipment_edi/main.go:167:22: declaration of "err" shadows declaration at line 125
# github.com/transcom/mymove/pkg/gen/internalapi
pkg/gen/internalapi/server.go:195:7: declaration of "err" shadows declaration at line 155
pkg/gen/internalapi/server.go:225:7: declaration of "err" shadows declaration at line 155
# github.com/transcom/mymove/pkg/gen/restapi
pkg/gen/restapi/server.go:195:7: declaration of "err" shadows declaration at line 155
pkg/gen/restapi/server.go:225:7: declaration of "err" shadows declaration at line 155
# github.com/transcom/mymove/pkg/paperwork
pkg/paperwork/generator.go:219:13: declaration of "err" shadows declaration at line 208
pkg/paperwork/generator_test.go:81:6: declaration of "err" shadows declaration at line 73
pkg/paperwork/generator_test.go:102:13: declaration of "err" shadows declaration at line 73
pkg/paperwork/shipment_summary_test.go:136:3: declaration of "params" shadows declaration at line 83
# github.com/transcom/mymove/pkg/rateengine
pkg/rateengine/nonlinehaul.go:150:13: declaration of "err" shadows declaration at line 118
# github.com/transcom/mymove/cmd/milmove
cmd/milmove/main.go:866:9: declaration of "err" shadows declaration at line 837
cmd/milmove/main.go:875:5: declaration of "err" shadows declaration at line 870
cmd/milmove/main.go:918:8: declaration of "err" shadows declaration at line 837
cmd/milmove/main.go:921:8: declaration of "err" shadows declaration at line 837
cmd/milmove/main.go:991:15: declaration of "err" shadows declaration at line 837
cmd/milmove/main.go:1166:3: declaration of "err" shadows declaration at line 837
cmd/milmove/main.go:1342:15: declaration of "err" shadows declaration at line 837
# github.com/transcom/mymove/pkg/services/fuelprice
pkg/services/fuelprice/diesel_fuel_price_storer.go:99:12: declaration of "err" shadows declaration at line 78
pkg/services/fuelprice/diesel_fuel_price_storer.go:125:3: declaration of "verrs" shadows declaration at line 77
pkg/services/fuelprice/diesel_fuel_price_storer.go:178:14: declaration of "err" shadows declaration at line 158
pkg/services/fuelprice/diesel_fuel_price_storer_test.go:79:10: declaration of "err" shadows declaration at line 61
pkg/services/fuelprice/diesel_fuel_price_storer_test.go:94:10: declaration of "err" shadows declaration at line 61
pkg/services/fuelprice/diesel_fuel_price_storer_test.go:107:10: declaration of "err" shadows declaration at line 61
pkg/services/fuelprice/diesel_fuel_price_storer_test.go:115:10: declaration of "err" shadows declaration at line 61
pkg/services/fuelprice/diesel_fuel_price_storer_test.go:122:10: declaration of "err" shadows declaration at line 61
pkg/services/fuelprice/diesel_fuel_price_storer_test.go:129:10: declaration of "err" shadows declaration at line 61
# github.com/transcom/mymove/pkg/services/invoice
pkg/services/invoice/process_invoice.go:30:10: declaration of "err" shadows declaration at line 27
pkg/services/invoice/process_invoice.go:39:3: declaration of "verrs" shadows declaration at line 35
pkg/services/invoice/process_invoice.go:39:10: declaration of "err" shadows declaration at line 27
# github.com/transcom/mymove/pkg/services/shipment
pkg/services/shipment/price_shipment.go:67:10: declaration of "err" shadows declaration at line 47
pkg/services/shipment/recalculate_shipment_test.go:92:4: declaration of "err" shadows declaration at line 74
# github.com/transcom/mymove/pkg/unit
pkg/unit/base_quantity_test.go:8:2: declaration of "BaseQuantity" shadows declaration at line 21
pkg/unit/base_quantity_test.go:18:2: declaration of "BaseQuantity" shadows declaration at line 21
pkg/unit/base_quantity_test.go:28:2: declaration of "BaseQuantity" shadows declaration at line 21
pkg/unit/base_quantity_test.go:38:2: declaration of "BaseQuantity" shadows declaration at line 21
pkg/unit/base_quantity_test.go:48:2: declaration of "BaseQuantity" shadows declaration at line 21
# github.com/transcom/mymove/cmd/generate_test_data
cmd/generate_test_data/main.go:69:12: declaration of "err" shadows declaration at line 28
cmd/generate_test_data/main.go:78:11: declaration of "err" shadows declaration at line 28
# github.com/transcom/mymove/pkg/handlers/publicapi
pkg/handlers/publicapi/generic_move_documents.go:112:11: declaration of "err" shadows declaration at line 82
pkg/handlers/publicapi/service_agents.go:146:12: declaration of "err" shadows declaration at line 138
pkg/handlers/publicapi/shipment_line_items.go:422:9: declaration of "err" shadows declaration at line 403
pkg/handlers/publicapi/shipment_line_items.go:428:6: declaration of "err" shadows declaration at line 403
pkg/handlers/publicapi/shipments.go:160:12: declaration of "err" shadows declaration at line 154
pkg/handlers/publicapi/shipments.go:574:12: declaration of "err" shadows declaration at line 567
pkg/handlers/publicapi/transportation_service_provider.go:48:12: declaration of "err" shadows declaration at line 42
# github.com/transcom/mymove/pkg/handlers/internalapi
pkg/handlers/internalapi/generic_move_documents.go:70:11: declaration of "err" shadows declaration at line 54
pkg/handlers/internalapi/generic_move_documents.go:82:8: declaration of "err" shadows declaration at line 54
pkg/handlers/internalapi/move_documents.go:164:5: declaration of "err" shadows declaration at line 130
pkg/handlers/internalapi/moving_expense_documents.go:73:11: declaration of "err" shadows declaration at line 57
pkg/handlers/internalapi/moving_expense_documents.go:85:8: declaration of "err" shadows declaration at line 57
pkg/handlers/internalapi/personally_procured_move.go:406:19: declaration of "err" shadows declaration at line 397

Setup
Add any steps or code to run in this section to help others prepare to run your code:
pre-commit run -a go-vet

Code Review Verification Steps

[x] Deploy to experimental
[x] Request review from a member of a different team.
[x] Have the Pivotal acceptance criteria been met for this change?

References

Pivotal story for this change
More info on shadowing with examples

This works on experimental. But I saw a failure with the awardqueue and I'm worried about it. So I'm going to check that out first and try to find out what's up.

This works on experimental. But I saw a failure with the awardqueue and I'm worried about it. So I'm going to check that out first and try to find out what's up.

Subsequent reruns worked. Though please give a closer look if you can and try to catch anything I messed up.

@akostibas - I keep seeing this problem with the award queue. Any idea what's up with this?
2019-05-03T21:03:40.940Z	INFO	awardqueue/awardqueue.go:158	TSP Award Queue running.
2019-05-03T21:03:40.945Z	INFO	awardqueue/awardqueue.go:57	Attempting to offer shipment	{"shipment_id": "a04abc47-b5a4-4879-997b-3e39e6fabbc9", "traffic_distribution_list_id": "b56228f3-47df-4794-aadf-ad95bc4741f2"}
2019-05-03T21:03:40.965Z	INFO	awardqueue/awardqueue.go:95	Attempting to offer to TSP	{"tsp_id": "e777c01b-606b-4cd7-87cb-e46617fbaf4d"}
2019-05-03T21:03:40.982Z	INFO	awardqueue/awardqueue.go:116	Shipment offered to TSP!	{"quality_band": 1, "offer_count": 1}
2019-05-03T21:03:41.010Z	INFO	awardqueue/awardqueue.go:57	Attempting to offer shipment	{"shipment_id": "040878d2-06d0-4e1a-9680-08923eea51ca", "traffic_distribution_list_id": "b56228f3-47df-4794-aadf-ad95bc4741f2"}
2019-05-03T21:03:41.029Z	INFO	awardqueue/awardqueue.go:95	Attempting to offer to TSP	{"tsp_id": "e777c01b-606b-4cd7-87cb-e46617fbaf4d"}
2019-05-03T21:03:41.044Z	INFO	awardqueue/awardqueue.go:116	Shipment offered to TSP!	{"quality_band": 1, "offer_count": 2}
2019-05-03T21:03:41.073Z	INFO	awardqueue/awardqueue.go:57	Attempting to offer shipment	{"shipment_id": "16799be3-30f8-47a8-a924-e9c9c6340a6b", "traffic_distribution_list_id": "b56228f3-47df-4794-aadf-ad95bc4741f2"}
2019-05-03T21:03:41.092Z	INFO	awardqueue/awardqueue.go:95	Attempting to offer to TSP	{"tsp_id": "e777c01b-606b-4cd7-87cb-e46617fbaf4d"}
2019-05-03T21:03:41.107Z	INFO	awardqueue/awardqueue.go:116	Shipment offered to TSP!	{"quality_band": 1, "offer_count": 3}
2019-05-03T21:03:41.136Z	INFO	awardqueue/awardqueue.go:57	Attempting to offer shipment	{"shipment_id": "5ed7a448-2fd3-4f1d-a1db-0b50c6c8e30b", "traffic_distribution_list_id": "b56228f3-47df-4794-aadf-ad95bc4741f2"}
2019-05-03T21:03:41.156Z	INFO	awardqueue/awardqueue.go:95	Attempting to offer to TSP	{"tsp_id": "e777c01b-606b-4cd7-87cb-e46617fbaf4d"}
2019-05-03T21:03:41.174Z	INFO	awardqueue/awardqueue.go:116	Shipment offered to TSP!	{"quality_band": 1, "offer_count": 4}
2019-05-03T21:03:41.213Z	INFO	awardqueue/awardqueue.go:57	Attempting to offer shipment	{"shipment_id": "66a6a7c5-b3fd-4560-9af1-a038d83bfc87", "traffic_distribution_list_id": "b56228f3-47df-4794-aadf-ad95bc4741f2"}
2019-05-03T21:03:41.233Z	INFO	awardqueue/awardqueue.go:95	Attempting to offer to TSP	{"tsp_id": "e777c01b-606b-4cd7-87cb-e46617fbaf4d"}
2019-05-03T21:03:41.257Z	INFO	awardqueue/awardqueue.go:116	Shipment offered to TSP!	{"quality_band": 1, "offer_count": 5}
2019-05-03T21:03:41.290Z	INFO	awardqueue/awardqueue.go:57	Attempting to offer shipment	{"shipment_id": "2febba16-1f13-4f47-8dac-539f6eb46807", "traffic_distribution_list_id": "b56228f3-47df-4794-aadf-ad95bc4741f2"}
2019-05-03T21:03:41.310Z	INFO	awardqueue/awardqueue.go:95	Attempting to offer to TSP	{"tsp_id": "e777c01b-606b-4cd7-87cb-e46617fbaf4d"}
2019-05-03T21:03:41.334Z	INFO	awardqueue/awardqueue.go:116	Shipment offered to TSP!	{"quality_band": 1, "offer_count": 6}
2019-05-03T21:03:41.369Z	INFO	awardqueue/awardqueue.go:57	Attempting to offer shipment	{"shipment_id": "cde90886-e407-4580-a8d5-ca57e17ba031", "traffic_distribution_list_id": "b56228f3-47df-4794-aadf-ad95bc4741f2"}
2019-05-03T21:03:41.389Z	INFO	awardqueue/awardqueue.go:95	Attempting to offer to TSP	{"tsp_id": "e777c01b-606b-4cd7-87cb-e46617fbaf4d"}
2019-05-03T21:03:41.415Z	INFO	awardqueue/awardqueue.go:116	Shipment offered to TSP!	{"quality_band": 1, "offer_count": 7}
2019-05-03T21:03:41.449Z	INFO	awardqueue/awardqueue.go:57	Attempting to offer shipment	{"shipment_id": "6bae49a7-a444-437d-aae5-fc4bef11a368", "traffic_distribution_list_id": "b56228f3-47df-4794-aadf-ad95bc4741f2"}
2019-05-03T21:03:41.470Z	INFO	awardqueue/awardqueue.go:95	Attempting to offer to TSP	{"tsp_id": "e777c01b-606b-4cd7-87cb-e46617fbaf4d"}
2019-05-03T21:03:41.499Z	INFO	awardqueue/awardqueue.go:116	Shipment offered to TSP!	{"quality_band": 1, "offer_count": 8}
2019-05-03T21:03:41.533Z	INFO	awardqueue/awardqueue.go:57	Attempting to offer shipment	{"shipment_id": "89ed0f34-faea-494f-ad3d-4a8c9a9feeff", "traffic_distribution_list_id": "b56228f3-47df-4794-aadf-ad95bc4741f2"}
2019-05-03T21:03:41.553Z	INFO	awardqueue/awardqueue.go:95	Attempting to offer to TSP	{"tsp_id": "e777c01b-606b-4cd7-87cb-e46617fbaf4d"}
2019-05-03T21:03:41.580Z	INFO	awardqueue/awardqueue.go:116	Shipment offered to TSP!	{"quality_band": 1, "offer_count": 9}
2019-05-03T21:03:41.645Z	INFO	awardqueue/awardqueue.go:57	Attempting to offer shipment	{"shipment_id": "53036d4b-f859-4eea-be2c-3119b5fc3a47", "traffic_distribution_list_id": "b56228f3-47df-4794-aadf-ad95bc4741f2"}
2019-05-03T21:03:41.691Z	INFO	awardqueue/awardqueue.go:95	Attempting to offer to TSP	{"tsp_id": "e777c01b-606b-4cd7-87cb-e46617fbaf4d"}
2019-05-03T21:03:41.731Z	INFO	awardqueue/awardqueue.go:116	Shipment offered to TSP!	{"quality_band": 1, "offer_count": 10}
2019-05-03T21:03:41.777Z	INFO	awardqueue/awardqueue.go:173	Awarded some shipments.	{"shipments_awarded": 10, "shipments_unawarded": 0}
2019-05-03T21:03:45.505Z	INFO	awardqueue/awardqueue.go:158	TSP Award Queue running.
2019-05-03T21:03:45.509Z	INFO	awardqueue/awardqueue.go:57	Attempting to offer shipment	{"shipment_id": "f1da198a-51d1-4d45-bc49-4c83de60377d", "traffic_distribution_list_id": "b8095e74-0909-4dd4-9612-53f99663e0cb"}
2019-05-03T21:03:45.529Z	INFO	awardqueue/awardqueue.go:95	Attempting to offer to TSP	{"tsp_id": "e557a63a-b3c7-4418-9ddf-520579838755"}
2019-05-03T21:03:45.545Z	INFO	awardqueue/awardqueue.go:116	Shipment offered to TSP!	{"quality_band": 1, "offer_count": 1}
2019-05-03T21:03:45.575Z	INFO	awardqueue/awardqueue.go:57	Attempting to offer shipment	{"shipment_id": "e37d2d9f-604a-40a8-a751-bd3a1602daa1", "traffic_distribution_list_id": "b8095e74-0909-4dd4-9612-53f99663e0cb"}
2019-05-03T21:03:45.595Z	INFO	awardqueue/awardqueue.go:95	Attempting to offer to TSP	{"tsp_id": "99adb0a4-ceae-4e1c-8b5c-a7f4cfa766c1"}
2019-05-03T21:03:45.610Z	INFO	awardqueue/awardqueue.go:116	Shipment offered to TSP!	{"quality_band": 1, "offer_count": 1}
2019-05-03T21:03:45.642Z	INFO	awardqueue/awardqueue.go:57	Attempting to offer shipment	{"shipment_id": "ff600170-429f-4fbe-af3e-8b4fd7a80219", "traffic_distribution_list_id": "b8095e74-0909-4dd4-9612-53f99663e0cb"}
2019-05-03T21:03:45.662Z	INFO	awardqueue/awardqueue.go:95	Attempting to offer to TSP	{"tsp_id": "378ecdca-173a-4127-9f63-6afe07fd9081"}
2019-05-03T21:03:45.678Z	INFO	awardqueue/awardqueue.go:116	Shipment offered to TSP!	{"quality_band": 1, "offer_count": 1}
2019-05-03T21:03:45.710Z	INFO	awardqueue/awardqueue.go:57	Attempting to offer shipment	{"shipment_id": "d447f5ab-18a2-4158-a3e0-4e283b844835", "traffic_distribution_list_id": "b8095e74-0909-4dd4-9612-53f99663e0cb"}
2019-05-03T21:03:45.730Z	INFO	awardqueue/awardqueue.go:95	Attempting to offer to TSP	{"tsp_id": "7a0f972b-3f88-4050-92cd-1595b63d5793"}
2019-05-03T21:03:45.746Z	INFO	awardqueue/awardqueue.go:116	Shipment offered to TSP!	{"quality_band": 1, "offer_count": 1}
2019-05-03T21:03:45.776Z	INFO	awardqueue/awardqueue.go:57	Attempting to offer shipment	{"shipment_id": "17258c7a-3ccb-4973-8b58-1d318dd33402", "traffic_distribution_list_id": "b8095e74-0909-4dd4-9612-53f99663e0cb"}
2019-05-03T21:03:45.797Z	INFO	awardqueue/awardqueue.go:95	Attempting to offer to TSP	{"tsp_id": "121c2ea6-d71c-4305-a151-905ec6f75607"}
2019-05-03T21:03:45.814Z	INFO	awardqueue/awardqueue.go:116	Shipment offered to TSP!	{"quality_band": 1, "offer_count": 1}
2019-05-03T21:03:45.845Z	INFO	awardqueue/awardqueue.go:57	Attempting to offer shipment	{"shipment_id": "22f964f6-0533-4b7c-ba17-b98c81d852e6", "traffic_distribution_list_id": "b8095e74-0909-4dd4-9612-53f99663e0cb"}
2019-05-03T21:03:45.867Z	INFO	awardqueue/awardqueue.go:95	Attempting to offer to TSP	{"tsp_id": "121c2ea6-d71c-4305-a151-905ec6f75607"}
2019-05-03T21:03:45.883Z	INFO	awardqueue/awardqueue.go:116	Shipment offered to TSP!	{"quality_band": 1, "offer_count": 2}
2019-05-03T21:03:45.912Z	INFO	awardqueue/awardqueue.go:57	Attempting to offer shipment	{"shipment_id": "e190c816-c235-43ad-bd38-9cff09b0e51a", "traffic_distribution_list_id": "b8095e74-0909-4dd4-9612-53f99663e0cb"}
2019-05-03T21:03:45.931Z	INFO	awardqueue/awardqueue.go:95	Attempting to offer to TSP	{"tsp_id": "7a0f972b-3f88-4050-92cd-1595b63d5793"}
2019-05-03T21:03:45.946Z	INFO	awardqueue/awardqueue.go:116	Shipment offered to TSP!	{"quality_band": 1, "offer_count": 2}
2019-05-03T21:03:45.975Z	INFO	awardqueue/awardqueue.go:57	Attempting to offer shipment	{"shipment_id": "1948c328-d02c-4aba-91d8-b9662dd5fc97", "traffic_distribution_list_id": "b8095e74-0909-4dd4-9612-53f99663e0cb"}
2019-05-03T21:03:45.995Z	INFO	awardqueue/awardqueue.go:95	Attempting to offer to TSP	{"tsp_id": "378ecdca-173a-4127-9f63-6afe07fd9081"}
2019-05-03T21:03:46.010Z	INFO	awardqueue/awardqueue.go:116	Shipment offered to TSP!	{"quality_band": 1, "offer_count": 2}
2019-05-03T21:03:46.039Z	INFO	awardqueue/awardqueue.go:57	Attempting to offer shipment	{"shipment_id": "bb88951c-1e2b-4680-8ffc-f4fe51093de2", "traffic_distribution_list_id": "b8095e74-0909-4dd4-9612-53f99663e0cb"}
2019-05-03T21:03:46.060Z	INFO	awardqueue/awardqueue.go:95	Attempting to offer to TSP	{"tsp_id": "99adb0a4-ceae-4e1c-8b5c-a7f4cfa766c1"}
2019-05-03T21:03:46.076Z	INFO	awardqueue/awardqueue.go:116	Shipment offered to TSP!	{"quality_band": 1, "offer_count": 2}
2019-05-03T21:03:46.107Z	INFO	awardqueue/awardqueue.go:57	Attempting to offer shipment	{"shipment_id": "651e98fb-b50b-419f-832f-7bd2ca1ff682", "traffic_distribution_list_id": "b8095e74-0909-4dd4-9612-53f99663e0cb"}
2019-05-03T21:03:46.129Z	INFO	awardqueue/awardqueue.go:95	Attempting to offer to TSP	{"tsp_id": "e557a63a-b3c7-4418-9ddf-520579838755"}
2019-05-03T21:03:46.144Z	INFO	awardqueue/awardqueue.go:116	Shipment offered to TSP!	{"quality_band": 1, "offer_count": 2}
2019-05-03T21:03:46.174Z	INFO	awardqueue/awardqueue.go:57	Attempting to offer shipment	{"shipment_id": "7112f0cb-41c4-4bf6-97a9-37ef97edac96", "traffic_distribution_list_id": "b8095e74-0909-4dd4-9612-53f99663e0cb"}
2019-05-03T21:03:46.194Z	INFO	awardqueue/awardqueue.go:95	Attempting to offer to TSP	{"tsp_id": "e557a63a-b3c7-4418-9ddf-520579838755"}
2019-05-03T21:03:46.210Z	INFO	awardqueue/awardqueue.go:116	Shipment offered to TSP!	{"quality_band": 1, "offer_count": 3}
2019-05-03T21:03:46.241Z	INFO	awardqueue/awardqueue.go:57	Attempting to offer shipment	{"shipment_id": "78d98dbf-eb05-4c77-8d83-ec6210814984", "traffic_distribution_list_id": "b8095e74-0909-4dd4-9612-53f99663e0cb"}
2019-05-03T21:03:46.263Z	INFO	awardqueue/awardqueue.go:95	Attempting to offer to TSP	{"tsp_id": "99adb0a4-ceae-4e1c-8b5c-a7f4cfa766c1"}
2019-05-03T21:03:46.281Z	INFO	awardqueue/awardqueue.go:116	Shipment offered to TSP!	{"quality_band": 1, "offer_count": 3}
2019-05-03T21:03:46.314Z	INFO	awardqueue/awardqueue.go:57	Attempting to offer shipment	{"shipment_id": "aa75c1b3-1606-4194-b166-3309c302bc5d", "traffic_distribution_list_id": "b8095e74-0909-4dd4-9612-53f99663e0cb"}
2019-05-03T21:03:46.337Z	INFO	awardqueue/awardqueue.go:95	Attempting to offer to TSP	{"tsp_id": "378ecdca-173a-4127-9f63-6afe07fd9081"}
2019-05-03T21:03:46.354Z	INFO	awardqueue/awardqueue.go:116	Shipment offered to TSP!	{"quality_band": 1, "offer_count": 3}
2019-05-03T21:03:46.386Z	INFO	awardqueue/awardqueue.go:57	Attempting to offer shipment	{"shipment_id": "5a61ccd8-a974-4000-8c6b-c7b523e158eb", "traffic_distribution_list_id": "b8095e74-0909-4dd4-9612-53f99663e0cb"}
2019-05-03T21:03:46.406Z	INFO	awardqueue/awardqueue.go:95	Attempting to offer to TSP	{"tsp_id": "7a0f972b-3f88-4050-92cd-1595b63d5793"}
2019-05-03T21:03:46.423Z	INFO	awardqueue/awardqueue.go:116	Shipment offered to TSP!	{"quality_band": 1, "offer_count": 3}
2019-05-03T21:03:46.454Z	INFO	awardqueue/awardqueue.go:57	Attempting to offer shipment	{"shipment_id": "78c76db2-2c95-424f-a09e-80ecac7dadf0", "traffic_distribution_list_id": "b8095e74-0909-4dd4-9612-53f99663e0cb"}
2019-05-03T21:03:46.476Z	INFO	awardqueue/awardqueue.go:95	Attempting to offer to TSP	{"tsp_id": "121c2ea6-d71c-4305-a151-905ec6f75607"}
2019-05-03T21:03:46.492Z	INFO	awardqueue/awardqueue.go:116	Shipment offered to TSP!	{"quality_band": 1, "offer_count": 3}
2019-05-03T21:03:46.524Z	INFO	awardqueue/awardqueue.go:57	Attempting to offer shipment	{"shipment_id": "4f5cbaee-8b50-4a21-81f4-4347617f1ddf", "traffic_distribution_list_id": "b8095e74-0909-4dd4-9612-53f99663e0cb"}
2019-05-03T21:03:46.544Z	INFO	awardqueue/awardqueue.go:95	Attempting to offer to TSP	{"tsp_id": "121c2ea6-d71c-4305-a151-905ec6f75607"}
2019-05-03T21:03:46.561Z	INFO	awardqueue/awardqueue.go:116	Shipment offered to TSP!	{"quality_band": 1, "offer_count": 4}
2019-05-03T21:03:46.590Z	INFO	awardqueue/awardqueue.go:57	Attempting to offer shipment	{"shipment_id": "954a0558-071c-4293-86bc-ba1ca2c65587", "traffic_distribution_list_id": "b8095e74-0909-4dd4-9612-53f99663e0cb"}
2019-05-03T21:03:46.611Z	INFO	awardqueue/awardqueue.go:95	Attempting to offer to TSP	{"tsp_id": "7a0f972b-3f88-4050-92cd-1595b63d5793"}
2019-05-03T21:03:46.627Z	INFO	awardqueue/awardqueue.go:116	Shipment offered to TSP!	{"quality_band": 1, "offer_count": 4}
2019-05-03T21:03:46.656Z	INFO	awardqueue/awardqueue.go:173	Awarded some shipments.	{"shipments_awarded": 17, "shipments_unawarded": 0}
2019-05-03T21:03:47.079Z	INFO	awardqueue/awardqueue.go:226	Assigning performance bands	{"traffic_distribution_list_id": "4a6fba19-b119-478f-a563-01c73fdabb9a", "performance_period_start": "2018-05-15 00:00:00 +0000 +0000", "performance_period_end": "2018-07-31 00:00:00 +0000 +0000", "rate_cycle_start": "2018-05-15 00:00:00 +0000 +0000", "rate_cycle_end": "2018-09-30 00:00:00 +0000 +0000"}
2019-05-03T21:03:47.083Z	INFO	awardqueue/awardqueue.go:244	Assigning tspPerformance to band	{"tsp_performance_id": "654dce69-8e4a-4ed2-ba5c-b1f1f6f871b6", "band": 1}
2019-05-03T21:03:47.089Z	INFO	awardqueue/awardqueue.go:244	Assigning tspPerformance to band	{"tsp_performance_id": "73dbc6c4-8965-443e-a431-8ebf9f2fe07f", "band": 1}
2019-05-03T21:03:47.094Z	INFO	awardqueue/awardqueue.go:244	Assigning tspPerformance to band	{"tsp_performance_id": "8baeeca1-91e5-4ca8-a7fa-c5e107d4ff0d", "band": 2}
2019-05-03T21:03:47.100Z	INFO	awardqueue/awardqueue.go:244	Assigning tspPerformance to band	{"tsp_performance_id": "da550ffd-1ff9-4143-be4d-24c17b08b6f4", "band": 3}
2019-05-03T21:03:47.106Z	INFO	awardqueue/awardqueue.go:244	Assigning tspPerformance to band	{"tsp_performance_id": "81df0e4f-9a67-4ee4-9b78-50ed1c9fae75", "band": 4}
2019-05-03T21:03:47.766Z	INFO	awardqueue/awardqueue.go:158	TSP Award Queue running.
2019-05-03T21:03:47.770Z	INFO	awardqueue/awardqueue.go:57	Attempting to offer shipment	{"shipment_id": "43789da1-f852-45e4-9544-4eaa4e00b6ab", "traffic_distribution_list_id": "5871954b-6353-4e24-918b-c617f15584d2"}
2019-05-03T21:03:47.788Z	INFO	awardqueue/awardqueue.go:95	Attempting to offer to TSP	{"tsp_id": "17816353-7e2c-43aa-8a82-aabea73b0013"}
2019-05-03T21:03:47.802Z	INFO	awardqueue/awardqueue.go:116	Shipment offered to TSP!	{"quality_band": 1, "offer_count": 1}
2019-05-03T21:03:47.830Z	INFO	awardqueue/awardqueue.go:57	Attempting to offer shipment	{"shipment_id": "78fec67a-bff6-41aa-bfbf-34da9b1d0fd7", "traffic_distribution_list_id": "5871954b-6353-4e24-918b-c617f15584d2"}
2019-05-03T21:03:47.848Z	INFO	awardqueue/awardqueue.go:95	Attempting to offer to TSP	{"tsp_id": "eb7b3b50-b4f5-4642-b4cd-df2680078a1c"}
2019-05-03T21:03:47.863Z	INFO	awardqueue/awardqueue.go:116	Shipment offered to TSP!	{"quality_band": 1, "offer_count": 1}
2019-05-03T21:03:47.891Z	INFO	awardqueue/awardqueue.go:173	Awarded some shipments.	{"shipments_awarded": 2, "shipments_unawarded": 0}
2019-05-03T21:03:48.448Z	INFO	awardqueue/awardqueue.go:57	Attempting to offer shipment	{"shipment_id": "20d0c4ad-bd9c-418c-8a4a-1dc02f934f20", "traffic_distribution_list_id": "b040b878-b40b-42a7-a31d-a15f277299ea"}
2019-05-03T21:03:48.468Z	INFO	awardqueue/awardqueue.go:95	Attempting to offer to TSP	{"tsp_id": "2f4d0020-8bad-4803-91ff-60ee37336a90"}
2019-05-03T21:03:48.483Z	INFO	awardqueue/awardqueue.go:109	Shipment pickup date is during a blackout period. Awarding Administrative Shipment to TSP.
2019-05-03T21:03:48.483Z	INFO	awardqueue/awardqueue.go:136	Selected TSP has blackouts. Checking for another TSP.
2019-05-03T21:03:49.152Z	INFO	awardqueue/awardqueue.go:158	TSP Award Queue running.
2019-05-03T21:03:49.157Z	INFO	awardqueue/awardqueue.go:57	Attempting to offer shipment	{"shipment_id": "6643340b-a0c0-4324-bc63-8f4839bc327e", "traffic_distribution_list_id": "1748502f-5c67-4316-bffd-3cb1fa65b190"}
2019-05-03T21:03:49.176Z	INFO	awardqueue/awardqueue.go:95	Attempting to offer to TSP	{"tsp_id": "6da43b98-cb86-4688-98d9-bb901840f012"}
2019-05-03T21:03:49.191Z	INFO	awardqueue/awardqueue.go:116	Shipment offered to TSP!	{"quality_band": 1, "offer_count": 1}
2019-05-03T21:03:49.221Z	INFO	awardqueue/awardqueue.go:57	Attempting to offer shipment	{"shipment_id": "23ee72e9-d552-43ad-9816-286518657d61", "traffic_distribution_list_id": "1748502f-5c67-4316-bffd-3cb1fa65b190"}
2019-05-03T21:03:49.240Z	INFO	awardqueue/awardqueue.go:95	Attempting to offer to TSP	{"tsp_id": "6da43b98-cb86-4688-98d9-bb901840f012"}
2019-05-03T21:03:49.254Z	INFO	awardqueue/awardqueue.go:109	Shipment pickup date is during a blackout period. Awarding Administrative Shipment to TSP.
2019-05-03T21:03:49.254Z	INFO	awardqueue/awardqueue.go:136	Selected TSP has blackouts. Checking for another TSP.
2019-05-03T21:03:49.267Z	ERROR	awardqueue/awardqueue.go:167	Failed to offer shipment	{"error": "could not find a TSP without blackout dates in 1 tries"}
github.com/transcom/mymove/pkg/logging/hnyzap.(*Logger).TraceError
	/home/circleci/go/src/github.com/transcom/mymove/pkg/logging/hnyzap/hnyzap.go:95
github.com/transcom/mymove/pkg/awardqueue.(*AwardQueue).assignShipments
	/home/circleci/go/src/github.com/transcom/mymove/pkg/awardqueue/awardqueue.go:167
github.com/transcom/mymove/pkg/awardqueue.(*AwardQueueSuite).Test_CheckShipmentDuringBlackOut
	/home/circleci/go/src/github.com/transcom/mymove/pkg/awardqueue/awardqueue_test.go:149
reflect.Value.call
	/usr/local/go/src/reflect/value.go:447
reflect.Value.Call
	/usr/local/go/src/reflect/value.go:308
github.com/stretchr/testify/suite.Run.func2
	/home/circleci/go/pkg/mod/github.com/stretchr/testify@v1.3.0/suite/suite.go:126
testing.tRunner
	/usr/local/go/src/testing/testing.go:865
2019-05-03T21:03:49.267Z	INFO	awardqueue/awardqueue.go:173	Awarded some shipments.	{"shipments_awarded": 1, "shipments_unawarded": 1}
2019-05-03T21:03:49.830Z	INFO	awardqueue/awardqueue.go:57	Attempting to offer shipment	{"shipment_id": "12f669fb-2d3b-4661-a586-3bf4ec1866c5", "traffic_distribution_list_id": "f73f7b96-994c-4c1d-93f9-cba3c27b2b2c"}
2019-05-03T21:03:51.344Z	INFO	awardqueue/awardqueue.go:57	Attempting to offer shipment	{"shipment_id": "86cc3584-63a0-4b4b-a99b-3ff33faf98fc", "traffic_distribution_list_id": "3733e61c-1d56-4075-b57d-45fae2a82c83"}
2019-05-03T21:03:51.363Z	INFO	awardqueue/awardqueue.go:95	Attempting to offer to TSP	{"tsp_id": "860018c3-4376-437c-8b7f-9182f5d63954"}
2019-05-03T21:03:51.379Z	INFO	awardqueue/awardqueue.go:116	Shipment offered to TSP!	{"quality_band": 1, "offer_count": 1}
--- FAIL: TestAwardQueueSuite (16.51s)
    --- FAIL: TestAwardQueueSuite/Test_AssignTSPsToBands (0.37s)
        awardqueue_test.go:647: Wrong quality band: expected 1, got 4
        awardqueue_test.go:647: Wrong quality band: expected 1, got 3
        awardqueue_test.go:647: Wrong quality band: expected 3, got 1
        awardqueue_test.go:647: Wrong quality band: expected 4, got 1
FAIL
coverage: 76.3% of statements
FAIL	github.com/transcom/mymove/pkg/awardqueue	16.554s

Turns out the awardqueue problem wasn't part of this PR. It was fixed in https://github.com/transcom/mymove/pull/2093


KartaView: Filtering by date removes sequence line

URL
No response
How to reproduce the issue?
https://www.openstreetmap.org/edit#map=20/52.5687772/9.0223215
Filtering by i.e. '2016' removes the sequence line from KartaView, but not from Mapillary.
Chrome 129.0.6668.71 on Windows 10
Screenshot(s) or anything else?
Without filter

With filter. Notice there is no line between the individual images.

Which deployed environments do you see the issue in?
Released version at openstreetmap.org/edit
What version numbers does this issue effect?
2.30.2
Which browsers are you seeing this problem on?
Chrome

https://www.openstreetmap.org/edit#map=20/52.8757631/10.1159847
Here some but not all. (filter set to '2021')

@danieldegroot2 i am interested in this issue and i am taking it up ...


test: fixed tests for model generation

Description
With the new update to Modelina the test packages are no longer a valid package name, so just changing it to something that makes more sense

@jonaslagoni I think you need to reinstall node_modules

I can, but the release workflow will revert the changes anyway, I think 🤔 So it won't really solve anything, other then this PR can be merged 🧐


rpm installation of atom in centos7 causes errors for some packages

On centos 7 with Atom 1.13.0x64 the following warning is thrown when the autocomplete-python package first attempts to autocomplete.
/bin/sh: module: line 1: syntax error: unexpected end of file
/bin/sh: error importing function definition for `BASH_FUNC_module'

Steps to Reproduce

Install Centos7
Install atom with the 1.13.0 rpm
Install autocomplete-python package
Close Atom
Open Atom
Open python file
Start typing something that might trigger autocomplete

Expected behavior:
autocomplete dialogue appears, no warnings are thrown
Actual behavior:
no dialogue appears the warning/error is thrown
As far as I can tell this is an issue with the atom rpm install for fedora/centos.
After running
rpm -Uvh atom.x84_64.rpm

I can now find 2 copies of the atom executable one at /bin/atom and one at /usr/share/atom/atom. I would typically expect one of those to be a symlink to the other but that is not the case here. The desktop icon that the rpm adds to Gnome is pointed at the executable /usr/share/atom/atom
If I run atom from the command line with /usr/share/atom/atom I get the following error
bash: cannot set terminal process group (-1): Inappropriate ioctl for device
bash: no job control in this shell

and the BASH_FUNC_module error for autocomplete-python persists. So you obviously see this same behaviour with the desktop icon.
If I run atom with /bin/atom there are no errors and everything works as expected.
Current Solutions
Either

Run atom from the commandline allowing it to resolve to /bin/atom
As I'm using gnome I changed the atom desktop icon to always call /bin/atom is called. I made the following edits to /usr/share/applications/atom.desktop

Exec=/bin/atom %F
Icon=/usr/share/atom/atom.png

and then log out and back in to Gnome

Also seen on Fedora 25.  Some additional details on closed module ticket autocomplete-python/autocomplete-python#275

@ungb is this due to dependencies?

Strikes me that the runtime dependencies are satisfied given that /bin/atom runs without error. Some manner of relative path problem seems likely.

I do see the error
bash: cannot set terminal process group (-1): Inappropriate ioctl for device
bash: no job control in this shell

come up but I am unable to repro the issue where autocomplete doesn't work.   Is there any thing else you can provide that might be different about your system?  where is atom mapped on your terminal if you run which atom.
see gif of my repro on Centos 7.

which atom
returns
bin/atom
Here is the behaviour when launched from /usr/share/atom/atom

I am still unable to repro your issue on centos
This is what I see when I follow your steps(NOTE my Centos VM is completely new install of Centos 7.3 64-bit):

I get this error any time I try to install dependencies on Fedora 25 with Atom 1.15.0. Here is a compressed webm screen capture showing the error. To reproduce this error on Fedora:

Install a package that requires a dependency (e.g. linter)
Click install in the blue popup asking about dependencies.
See error.

After this has happened once, every time you start Atom again you will get the blue popup asking you to install dependencies again and the error will happen once more.

Check this:
#https://github.com/autocomplete-python/autocomplete-python/issues/275#issuecomment-310929013


[Feature Idea] Loan Duration Tiers

A feature I would really love to see would be tiered loan durations. Currently, there is the ability to set a longer loan period if the rate is above a certain value.
However, if we could set multiple conditions that would allow users to optimize their returns. Eg:
If > 0.5%, then 10 days.
If > 0.75% then 20 days.
If > 2.0% then 60 days.
Hope this makes sense but happy to try again if it's not clear.
Also, being able to set loan duration at a coin level (rather than across all coins) might be handy.
Thanks!

Did you see this:
http://poloniexlendingbot.readthedocs.io/en/latest/configuration.html#variable-loan-length
?

I did not! That's perfect, thanks!! Looks like its a new addition to the config file since my version. Sorry for missing it.