CARD4L SAR Extension (NRB + POL)

Work in progress Read the proposal here: https://github.com/radiantearth/stac-spec/blob/card4l-sar-nrb/extensions/card4l-sar/README.md
Related Issue(s): Partly #912, Requires PR #934
Proposed Changes:

Add a STAC "extension" that explains how to map CARD4L SAR metadata to STAC. This includes both Normalized Radar Backscatter (NRB) and Polarimetric Radar (POL) in a single extension. This extension supports two "modes", one is "STAC only" and one is "XML mode" (a smaller "STAC Item on to of a XML file as specified in the CARD4L metadata spec).

cc @matthewhanson @alexgleith
PR Checklist:

[x] This PR is made against the dev branch (all proposed changes except releases should be against dev, not master).
[x] This PR has no breaking changes.
[ ] I have added my changes to the CHANGELOG or a CHANGELOG entry is not required.
[ ] This PR affects the STAC API spec, and I have opened issue/PR #XXX to track the change.

In the current xml, IncAngleNearRange and IncAngleFarRange are for the source data, which means this doesn't necessarily correspond to actual incidence angle range for this output. If the view:incidence_angle is intended to be for the sensor, then it's appropriate to use the middle point angle.
The SAR extension has a few product type defined, so it should be RTC in that list (CARD4L requires RTC). However, the Sentinel-1 product has backscatter power/intensity, not amplitude. Therefore, an additional field is needed in the sar extension.
There are a few pieces of important information related to processing that's not yet in STAC, e.g. filtering (whether a speckle filter has been applied to the data), thermal noise removal (whether it has been applied),

@fangfy Thank you for your comments, very much appreciated! Sorry for the delay, I was waiting for #907 to be merged.

In the current xml, IncAngleNearRange and IncAngleFarRange are for the source data, which means this doesn't necessarily correspond to actual incidence angle range for this output. If the view:incidence_angle is intended to be for the sensor, then it's appropriate to use the middle point angle.

I understand the spec the way that view:incidence_angle indeed is intended to be for the sensor.

The SAR extension has a few product type defined, so it should be RTC in that list (CARD4L requires RTC). However, the Sentinel-1 product has backscatter provided as power/intensity, not amplitude. Therefore, an additional field is needed in the sar extension.

@matthewhanson What do you think? You proposed RTC, but what would be the preferred way out? Should we add more product types for SAR or go another route?

There are a few pieces of important information related to processing that's not yet in STAC, e.g. filtering (whether a speckle filter has been applied to the data), thermal noise removal (whether it has been applied), not sure whether they should be in "about".

We are likely not capturing all details in STAC, but they are available in the additional XML file that is required anyway, right?

where does processing time and software + version go in  STAC?

We've recently introducted the processing extension with OR #907. There are now fields for things like software + version and I'll add that now to the proposal.

There are a few pieces of important information related to processing that's not yet in STAC, e.g. filtering (whether a speckle filter has been applied to the data), thermal noise removal (whether it has been applied), not sure whether they should be in "about".

We are likely not capturing all details in STAC, but they are available in the additional XML file that is required anyway, right?

CARD4L doesn't require XML, if all required metadata can be provided in STAC, then only one metadata file is needed.

I've finished writing up the document that captures (I hope) all requirements from CARD4L SAR NRB and POL in a single STAC extensions. It got pretty heavy and was quite a bit of effort, but I've now also included a "pure" STAC mode, if you don't want the XML. The question is how to proceed with this? Is there a way to get that through some CEOS review or so? In the best case we could finalize it with CEOS and actually make it somewhat official or so. @fangfy @alexgleith

@m-mohr , my response to your question on 1.7.3 below. sorry for the delay.
I went through the entire document, so included other comments and typos I noticed as well:

card4l-document: prod, should be 1.4, not 1.5
card4l:orbit_data_source and orbit-data-file: these should be applicable to prod as well if additional orbit correction has been applied.
access: src 1.6.1, prod 1.7.1
Re 1.7.3: ProductColumnSpacing, ProductRowSpacing are the actual product sampling. They should be in meter or degree (in ground geometry as required by CARD4L, therefore different to the sar:pixel_spacing_azimuth and sar:pixel_spacing_range which are in radar geometry). I think this can be implied if proj:transform is provided? could still be useful for users to have a direct reference.
bbox: prod should be 1.7.5
geometry: prod should be 1.7.6
card4l:pixel_coordinate_convention: prod should be 1.7.8
the metadata assets (2.3 -2.6) should have relevant unit defined.
for the backscatter image assets (or as overall metadata), BackscatterMeasurement (should be gamma0 for CARD4L, but for other radar product, this can be sigma0, beta0 etc), and BackscatterConvention (amplitude or power, this is important!) should be defined. These two (and probably a few others) would make most sense to be included in the sar extension.
id: I guess this should be required for prod as well?

Thank you, @fangfy. I highly appreciate that you took the time and have added your feedback here. It's just in time for us to implement it. I've applied all suggested changes and updated the document accordingly, but some additional comments below:

Re 1.7.3: ProductColumnSpacing, ProductRowSpacing are the actual product sampling. They should be in meter or degree (in ground geometry as required by CARD4L, therefore different to the sar:pixel_spacing_azimuth and sar:pixel_spacing_range which are in radar geometry).

In STAC sar:pixel_spacing_azimuth and sar:pixel_spacing_range are always in meters, so it sounds like they could really be used for Src and Prod. I've changed the document accordingly.

the metadata assets (2.3 -2.6) should have relevant unit defined.

I've added a card4l:unit flag that can be set, but we could maybe remove it if it's always the same unit?

for the backscatter image assets (or as overall metadata), BackscatterMeasurement (should be gamma0 for CARD4L, but for other radar product, this can be sigma0, beta0 etc), and BackscatterConvention (amplitude or power, this is important!) should be defined. These two (and probably a few others) would make most sense to be included in the sar extension.

I couldn't find these metadata entries in the official CARD4L SAR NRB metadata specification. Have I missed them? If they are missing there, why are they missing there if this information is important? Also, which part of the specification requires them? It's a bit strange to require them but not list the requirement number.

Thank you, @fangfy. I highly appreciate that you took the time and have added your feedback here. It's just in time for us to implement it. I've applied all suggested changes and updated the document accordingly, but some additional comments below:

Re 1.7.3: ProductColumnSpacing, ProductRowSpacing are the actual product sampling. They should be in meter or degree (in ground geometry as required by CARD4L, therefore different to the sar:pixel_spacing_azimuth and sar:pixel_spacing_range which are in radar geometry).

In STAC sar:pixel_spacing_azimuth and sar:pixel_spacing_range are always in meters, so it sounds like they could really be used for Src and Prod. I've changed the document accordingly.

Problem is the _azimuth and _range part, which are relative to sensor not ground, so they don't apply to card4L product.

the metadata assets (2.3 -2.6) should have relevant unit defined.

I've added a card4l:unit flag that can be set, but we could maybe remove it if it's always the same unit?

The units are different for the different images, hence it's important, I'd say required.

for the backscatter image assets (or as overall metadata), BackscatterMeasurement (should be gamma0 for CARD4L, but for other radar product, this can be sigma0, beta0 etc), and BackscatterConvention (amplitude or power, this is important!) should be defined. These two (and probably a few others) would make most sense to be included in the sar extension.

I couldn't find these metadata entries in the official CARD4L SAR NRB metadata specification. Have I missed them? If they are missing there, why are they missing there if this information is important? Also, which part of the specification requires them? It's a bit strange to require them but not list the requirement number.

They are listed as parameters in the backscatter measurements (3.1). They do apply directly to the backscatter images/assets.
I hope these help to clarify.

Thank you again, @fangfy!

Problem is the _azimuth and _range part, which are relative to sensor not ground, so they don't apply to card4L product.

In #962 I'm now proposing some additional fields to be added to the SAR extension. I hope I understood things correctly with my limited SAR knowledge. Thus there are separate fields for row and column. I'd appreciate if you could have a look at PR #962.

The units are different for the different images, hence it's important.

I was not giving the idea clear enough, I think.  I meant if it's a fixed unit for the individual assets, one may not give them, but I'm fine to just leave them in and make it explicit.

They are listed as parameters in the backscatter measurements (3.1). They do apply directly to the backscatter images/assets.

Thank you, I found them now and also looked at POL again so align better. I have also tried to add those to the SAR extension directly, see #962.

The STAC CARD4L SAR Extension has been migrated to a separate repository: https://github.com/stac-extensions/card4l/tree/main/sar


Guidance on CA (Certificate Authority) verification

In my env, I see encountered this error while trying to connect:
Error 1 connecting to abhishgu.redis.cache.windows.net:6380. [SSL: CERTIFICATE_VERIFY_FAILED] certificate verify failed: unable to get local issuer certificate (_ssl.c:1108).

This was fixed by adding ssl_cert_reqs='none' to the constructor. The document should add guidance on the recommended configuration for client apps:
(1) Is ssl_cert_reqs='none' alright?
(2) Required CA certificate should be obtained as per env
> note: the doc does mentions RHEL, but the app could be running anywhere e.g. a standalone Docker container, AKS cluster, ACI, App Service etc.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 53362ade-89a6-97fb-4fdf-2ee723954ac4
Version Independent ID: 6a0cf549-8ec7-722f-218b-b4267f2d7a8d
Content: Quickstart: Create a Python app - Azure Cache for Redis
Content Source: articles/azure-cache-for-redis/cache-python-get-started.md
Service: cache
GitHub Login: @yegu-ms
Microsoft Alias: yegu

@abhirockzz Thank you for the detailed feedback.
This is being assigned to the content author to evaluate and update the documentation as appropriate.

Thanks for your dedication to our documentation. Unfortunately, at this time we have been unable to review your issue in a timely manner and we sincerely apologize for the delayed response. Though the scope of our feedback channel here on GitHub covers specific documentation fixes, we can help redirect you to the right support channel to get an answer to your question: https://docs.microsoft.com/en-us/answers/topics/azure-cache-redis.html. Because this issue does not relate to documentation, we are closing this issue. #please-close


some duplicate proteins have no InterPro domains

I don't think this is likely anything to do with the new release, it might be to do with the way the pipeline works

Systematic ID
Gene name
Product description

SPAPB8E5.02c
rpn502
19S proteasome regulatory subunit Rpn502

SPAC144.11
rps1102
40S ribosomal protein S11

SPAC3H5.05c
rps1401
40S ribosomal protein S14

i.e rnp501 is an exact duplicate of rpn502 and does have Pfam domains
https://www.pombase.org/gene/SPAC1420.03

i.e rnp501 is an exact duplicate of rpn502 and does have Pfam domains

Thanks for the hint.  That was the problem.  The InterProScan pipeline produces one result for each unique AA sequence its given.  It was producing a single result for rnp501 and rpn502, with a section like this at the end of the result JSON:
  "xref" : [ {
    "name" : "SPAC1420.03.1:pep rpn501|19S proteasome regulatory subunit Rpn501",
    "id" : "SPAC1420.03.1:pep"
  }, {
    "name" : "SPAPB8E5.02c.1:pep rpn502|19S proteasome regulatory subunit Rpn502",
    "id" : "SPAPB8E5.02c.1:pep"
  } ]

My code was only using the first "xref" so rpn502 wasn't getting any domains.
Fixed for tonight's load.  I'll check in the morning.


bug(chat): lacking padding in count char

STR:

go to chat
count char is lacking padding

macOS, m1

is this still the case in newest dev branch? i have some padding on my end

latest dev
macOS


SRVKP-4523: add alert related deadlock / crashloop panels for core tekton controllers

Also fixing issues with older panels as various var substitutions only work in App SRE, some metrics names were incorrect, and some 'prometheus' filters were no longer (if ever) valid

cluster deploy failed
/retest

/retest

/retest

OK Rosa working again
local testing good ... merging


IntelliJ: should .idea/misc.xml really be excluded?

Currently the file .idea/misc.xml is excluded when using Intellij+iml on gitignore.io.
I'm not sure if this is correct.
In my project this file has the following content:
  <component name="JavaScriptSettings">
    <option name="languageLevel" value="ES6" />
  </component>

This clearly specifies a project specific configuration which should be shared in a team.

Please submit template PR's to https://github.com/toptal/gitignore


Default Browser on Launch

Task/Issue URL:
Description
Steps to test this PR
Feature 1

[ ]
[ ]

UI changes

Before
After

!(Upload before screenshot)
(Upload after screenshot)

Current dependencies on/for this PR:

develop

PR #2743   👈

This comment was auto-generated by Graphite.


Question about the PointTansformer Code

Hi, thanks for your great work. I can not find the code about the PointTransformer Backbone, could you release it for replicate the result.

Hi @hschu11,
We will update the code for Point Transformer as soon as possible. However, you can refer to this implementation as we adopt it for our work.
Best regards,
Toan.

Thanks for your reply.


system-tests: new test for disk encryption with support for TMPv2 PCR protection

Ready for review:

Needs global functions defined in https://github.com/openshift-kni/eco-gotests/pull/128
This PR is split from This is PR is split from https://github.com/openshift-kni/eco-gotests/pull/83 to review the global code only to review the Test code only
Missing Polarion IDs -> will be added in a future PR
Missing additional test case for to test PCR1 protection

This PR adds a CI test for TPM encryptions with PCR 1 and 7
The test defines the following 3 tests:

"Verifies that disabling Secure Boot prevents Disk decryption (PCR 7)":

start from a SNO system with secure boot enabled and the root disk encrypted with PCR 1 and 7
check that secure boot is enabled with PCR 1 and 7
check that reserved slot is not present
Disable secure boot with Redfish (gofish)
Restart the node gracefully and observe console with Redfish (ssh console)
wait for disk decryption failure logs to be detected
Enable secure boot
Force reboot node

"Verifies update indication with file (/etc/host-hw-Updating.flag)"

start from a SNO system with secure boot enabled and the root disk encrypted with PCR 1 and 7
check that secure boot is enabled with PCR 1 and 7
check that reserved slot is not present
Touch the "/etc/host-hw-Updating.flag" to notify a firmware upgrade. This essentially disables PCR protection. So any changes to PCR 1 and 7 will not prevent the disk to be decrypted
Disable secure boot with Redfish (gofish)
Restart the node gracefully and observe console with Redfish (ssh console)
wait for disk decryption to succeed and for the system to finish booting
Enable secure boot
Gracefully reboot node

"Verify that changing Host boot order prevents Disk decryption (TPM PCR 1)":

start from a SNO system with secure boot enabled and the root disk encrypted with PCR 1 and 7
check that secure boot is enabled with PCR 1 and 7
check that reserved slot is not present
Change the Server boot order
Restart the node gracefully and observe console with Redfish (ssh console)
wait for disk decryption failure logs to be detected
Change the Server boot order back to original settings
Force reboot node
Notes:

uses environment variables ECO_CNF_RAN_BMC_USERNAME, ECO_CNF_RAN_BMC_PASSWORD, ECO_CNF_RAN_BMC_HOSTS to get BMC credential for SNO
uses KUBECONFIG to access SNO spoke
needs to the spoke to configure text mode on the console. This can be done with this extra manifest

apiVersion: machineconfiguration.openshift.io/v1
kind: MachineConfig
metadata:
  labels:
    machineconfiguration.openshift.io/role: master
  name: 05-worker-kernel-log
spec:
  kernelArguments:
    - nomodeset
    - console=tty0
    - console=ttyS0,115200n8

lgtm

lgtm


bug: output string should be quoted

leetgo pick 1092 -l cpp

generates this code:
int main() {
	ios_base::sync_with_stdio(false);
	stringstream out_stream;

	string str1; cin >> quoted(str1);
	string str2; cin >> quoted(str2);

	Solution *obj = new Solution();

	auto &&res = obj->shortestCommonSupersequence(str1, str2);

	out_stream << res;
	cout << "output: " << out_stream.rdbuf();

	delete obj;
	return 0;
}

While a correct version would be:
int main() {
	ios_base::sync_with_stdio(false);
	stringstream out_stream;

	string str1; cin >> quoted(str1);
	string str2; cin >> quoted(str2);

	Solution *obj = new Solution();

	auto &&res = obj->shortestCommonSupersequence(str1, str2);

	out_stream << res;
	cout << "output: " << quoted(out_stream.str()) << endl;

	delete obj;
	return 0;
}

@w43322 Hi, sorry to bother. Would you mind taking a look of this?

@w43322 Hi, sorry to bother. Would you mind taking a look of this?

Yes, I'll look into it


Editor randomly freezes after Save & Quit on save_each_scene = false

Operating system or device - Godot version:
Antergos x86_64 | Godot Engine master 4e12bf1
Issue description:

Expected: editor to save and quit normally
Happened: editor freezes and won't quit after saving
Steps to reproduce:

Set interface/save_each_scene_on_quit to false
Make two or more scenes, save to disk (issue seems less likely to happen when there's only one unsaved scene)
Make unsaved changes in those scenes
Try to exit the editor. The prompt should say the scenes' name.
Choose "Save & Quit"
The scenes will be saved but sometimes the editor will freeze and not quit

Does #9870 fix this issue? If so can this be closed?

I'll test it in the morning.


[init] Remove grpc_register_plugin

Per https://github.com/grpc/proposal/pull/325
There's a couple of plugins left, move them directly into init whilst we figure out what to do with them.

Looks like a dependency problem with xds stuff still exists... will need to debug a little bit


Login/logout redirection tabs are defaulting to 0 instead of -1

Description of bug
After login/logout redirection settings were migrated to Site Settings (#3845), there is an issue when saving.
When other settings in the panel are changed but Redirect After Login/Logout are left untouched, their default values are set to 0, instead of -1. This causes DNN to navigate to tab ID 0 after logout, causing a 404:
http://platform-9-7-1.dnndev.me/tabid/0/Default.aspx
Notice the tabid/0 part of the URL.
Upon further investigation, I noticed that these values are null in the front-end, and converted to 0 in the back-end when cast to integers.
Steps to reproduce

Clean DNN 9.7.0 or above
Open SETTINGS > Site Settings > Site Behavior > DEFAULT PAGES
Click on the User Profile Page dropdown (the dropdown expands and the Save button becomes enabled)
Click Save
Close the Persona Bar
Log out

Current behavior
DNN redirects to /tabid/0/Default.aspx after logout, causing a 404.
Expected behavior
DNN should redirect to the home page.
Screenshots

Error information
N/A
Additional context
N/A
Affected version

[X] 10.00.00 alpha build
[X] 09.08.00 release candidate
[X] 09.07.02 latest supported release
[X] 09.07.01 latest supported release
[X] 09.07.00 latest supported release
[ ] 09.06.02 latest supported release

Affected browser

[X] Chrome
[X] Firefox
[X] Safari
[X] Internet Explorer 11
[X] Microsoft Edge (Classic)
[X] Microsoft Edge Chromium

I can confirm this in v9.8. I had to change the redirect drop-downs to home and then back to  to resolve.

We had this happen today on a large ecommerce site.  It was a major issue with no clear cause.  Switching redirects in site settings to home, saving, then switching back to none specified fixed it.

We had this happen today on a large ecommerce site.  It was a major issue with no clear cause.  Switching redirects in site settings to home, saving, then switching back to none specified fixed it.

@valadas has this been fixed meanwhile, do you know?

I am really not sure, I know I have a strange issue after login/logout on a clean 9.9.1 site but did not have time to dig into the details yet.


Ollama 0.4 not using VRAM on AMD RX 7900 XTX

What is the issue?
Any model that I load seems to use system RAM instead the VRAM. This doesn't happen on version 0.3 of ollama. Something is clearly wrong because ollama freezes after a couple of requests and the only way to make it work again is to restart it every minute.
Here is the server log server.log
Also below I attached 2 screeshots with ollama with a loaded model and ollama stut down.
Model unloaded

Model loaded

OS
Windows
GPU
AMD
CPU
AMD
Ollama version
0.4.2

Same issue here
After updating amd drivers to v-24.10.1 was working earlier today, rolling back does not seem to fix it

@MrMiladinovic can you clarify which version you rolled back to?  I believe you'll need to go back to 24.8.1 or older to resolve the problem until a newer driver is released.
We're tracking the driver bug with #7107

Same problem for me on 7900 XTX. A day i have do an uptade of ollama, and now he do not want work anymore.
I have have try many things, re-install ollama. Uninstall > Re-install rocm 6.1.2 and 5.7.1 and every combinaison.
He do not want heard anything, only cpu use.
With https://github.com/likelovewant/ollama-for-amd
I have made it work on GPU now ... but he only use CPU RAM, he do not want VRAM.
PS C:\Users\Evangelion> ollama ps
NAME                    ID              SIZE     PROCESSOR    UNTIL
mistral-small:latest    d095cd553b04    15 GB    100% GPU     4 minutes from now
Where are the older version of ollama ? I want try themes !
Windows 10 - 7900 XTX - Ollama 0.4.2

@Torckane , we are referring to AMD drivers>
Windows 11
Windows 10
Hope this helps


NOISSUE - Update magistrala messaging

What does this do?
It updated Magistrala messaging docs. It provides examples of how to do it.
List any changes that modify/break current functionality
It adds the functionality of running Magistrala with TLS and MTLS.
Have you included tests for your changes?
Yes.
Did you document any new/modified functionality?
Yes
Notes

@nyagamunene @JeffMboya What's the status of this PR?

@nyagamunene @JeffMboya What's the status of this PR?

It was placed on hold because it is dependant on this PR

@nyagamunene What's the status of this PR?

@nyagamunene What's the status of this PR?

This is ready


code generation for TypeScript about JsonExtensionData

Is JsonExtensionData code generation not supported in typescript?

in typescript.
is this code generator support?

Yes, but you need something like this in typescript?

yes. using typescript, my data  was filtered out by the proxy class.

Yep, not implemented yet...

How to avoid this problem and let my data display?
is there any good way?

I think the only way to fix that right now is to use interfaces instead of classes for DTOs...

What's the status on this?
Not sure if it belongs here or in a new issue, but the code in the generated TypeScript code to handle JsonExtensionData doesn't seem to follow spec. It expects there to be a property "extensions" in the JSON data but that will not be there in correctly generated JSON, as specified in the documentation for the property Extensions on ProblemDetails:

Extension members appear in the same namespace as other members of a problem type.

So for example, given this constructed ProblemDetails:
new ProblemDetails
{
	// ...
	Extensions =
	{
		["CustomExtension"] = "custom value"
	}
};

The following JSON will be generated (standard fields omitted):
{
	"CustomExtension": "custom value"
}

However, NSwag's TypeScript code expects this:
{
	"extensions": {
		"CustomExtension": "custom value"
	}
}

Not sure how the C# JSON libraries handle them, but I suppose the way to handle it is to treat any root-level field on the JSON that doesn't have a matching property in the TypeScript class/interface as an extension and stuff it into the "extensions" property on the TypeScript class.


[Event Request] - Codeunit 5760 PostSourceDocument

We are using BC 14.0.35570.
We would like the ability to handle the PostSourceDocument function. So, something like this would work for us:
LOCAL PostSourceDocument(WhseRcptLine : Record "Warehouse Receipt Line")
OnBeforePostSourceDocument(WhseRcptLine, PurchHeader, SalesHeader, TransHeader, CounterSourceDocOK, HideValidationDialog, Handled); // New
IF Handled then // New
  EXIT; // New
WhseSetup.GET;
WITH WhseRcptLine DO BEGIN

With an event definition:
LOCAL [IntegrationEvent] OnBeforePostSourceDocument(WhseRcptLine : Record "Warehouse Receipt Line"; VAR PurchHeader: Record "Purchase Header"; VAR SalesHeader: Record "Sales Header"; VAR TransHeader: Record "Transfer Header";VAR CounterSourceDocOK: Integer;  HideValidationDialog: Boolean; VAR Handled: Boolean)

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. We will update this issue with information about availability.

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. We will update this issue with information about availability.


Cannot connect Nicla Sense

I'm trying to connect a Nicla Sense to collect data but even though it is found and pairs successfully - the device does not show as connected, so I can't collect any data.
I've had this problem with the standalone bhy-controller where it would connect but would not show that it was connected.  I could still get sensor data.  This was using an executable that I built from the current github repo.  I downloaded the pre-built bhy_1.0.3 executable and it would show the connect correctly.  Is it possible that you are having the same problem.

Did you follow the instructions here to flash the latest edge-ml firmware on your Nicla?

Yes, I did all that last night and flashed it this morning.  I am using Arduino IDE 1.8.13.
I can see that the device does pair.
I will try this with the Nano33BLESense.  I've never tried it with WebBLE.   As I mentioned my Nicla does work correctly when I use bhy_1.0.3.  I am on Windows10 using Chrome.

Thanks, yes WebBLE is shaky from time to time. Does the Chrome Developer Console print any errors?

The Nano had the same issue - pairs but doesn't indicate connected.
I do see an error in the console.  Maybe I missed a step somewhere?

@tk-king any ideas?

@ralphjy can you check which version of the edge-ml library you have installed in your Arduino IDE?

1.1.2
I tried downgrading to 1.1.0 but had the same result (had to rename the EdgeML.h file in the App when downgrading)

This seems to be a server issue.
I am working on it.

The problem should be fixed now. An old image of the backend server was deployed on the server.


new plugin added (geogrid.js)

LGTM.
I could nitpick about a few implementation details (e.g. why the absolute need for WebGL?), but overall looks nice.

Thanks!
Regarding your question: the plugin can actually also use SVG to render the grid (see option renderer), but performance is much worse than in case of WebGL.

I guess as much, but in that case I'd push for a full-fledged WebGL L.Renderer for Leaflet. It comes down to development priorities and available development time, I guess.


fast skip of none in pipeiterator

@z3z1ma do you plan to review again?

LGTM, my only question is why self._initial_sources_count is decremented in the round robin method but not in the current method.


creating user gives siteid, apikey constrain error when creating second user

Using master:
When i create an user with api_key the value doesnt get saved.
When i create a second user i get a constrain error on the api_key because it tries to insert again with empy api_key

Fixed, thanks :pizza:


Issue 302 clean up pr 286

Issue 302
Clean up from PR #286 #302

[x] Remove developers.time_zone and developers.utc_offset
[x] Remove conditional validation for locations.latitude and locations.longitude

Pull request checklist

[x] Your code contains tests relevant for code you modified
[x] You have linted and tested the project with bin/check

Looks great, thanks for the PR!


extended stub for merging values

To summarise the conversations here for @SimonGreenhill , Robert's function has to do with API connection. I haven't used that before in this project, so I don't feel equipped to make a final review here.


rename Plugin to FlexibleCallbackPlugin or something similar

Just to leave room for other plugins that might be part of "labs" someday? Would resolve my concerns from #11

done


Why did you remove the clean shutdown code from net.cpp?

This is needed on Linux so SIGINT/SIGTERM will shut down solarcoind cleanly so databases and wallets don't get corrupted.
To re-add go to the end of ThreadMessageHandler2 and add this right below MilliSleep(100):
if (fRequestShutdown)
StartShutdown();

Thanks, Crypto2!


Feature/43 initial angular velocities

Main Changes
Added initialAngularVelocity in main.cpp which is then subtract  from the measuredAngularVelocity to give the angularVelocityCorrected which is used for the controlAction
Associated Issues

Addresses #43

@jamie-54 This looks good - have you noticed whether this has an effect on the behaviour of the quadcopter?

@jamie-54 Would the following work?
void initAngularVelocity()
{
  float angularVelocityTemp[3] = {0};
  int numInitAngularVelocity = 10;

  for (int i = 0; i < numInitAngularVelocity; i++)
  {
    ahrs.update();
    ahrs.angularVelocity(angularVelocityTemp);
    initialAngularVelocity[0] += angularVelocityTemp[0];
    initialAngularVelocity[1] += angularVelocityTemp[1];
    initialAngularVelocity[2] += angularVelocityTemp[2];
  }
  initialAngularVelocity[0] /= (float)numInitAngularVelocity;
  initialAngularVelocity[1] /= (float)numInitAngularVelocity;
  initialAngularVelocity[2] /= (float)numInitAngularVelocity;
}

@jamie-54 Would the following work?
void initAngularVelocity()
{
  float angularVelocityTemp[3] = {0};
  int numInitAngularVelocity = 10;

  for (int i = 0; i < numInitAngularVelocity; i++)
  {
    ahrs.update();
    ahrs.angularVelocity(angularVelocityTemp);
    initialAngularVelocity[0] += angularVelocityTemp[0];
    initialAngularVelocity[1] += angularVelocityTemp[1];
    initialAngularVelocity[2] += angularVelocityTemp[2];
  }
  initialAngularVelocity[0] /= (float)numInitAngularVelocity;
  initialAngularVelocity[1] /= (float)numInitAngularVelocity;
  initialAngularVelocity[2] /= (float)numInitAngularVelocity;
}

I don't see any reason for this not to work, I'll test it on hardware tomorrow and then update.
Then I'll check PR #45


The API examples for the Shortcuts class don't compile in Dartpad

The error says that the code won't compile to JavaScript.
api.flutter.dev/flutter/widgets/Shortcuts-class.html

This is duplicate of #85854

Closing this as duplicate as linked above and reason.


duplicate and replay example error

Hello I am trying to understand duplicate and replay process so I tried to run dup_and_replay.py but there is something that I keep getting this error
Addon error: Traceback (most recent call last):
File "dup.py", line 6, in request
ctx.master.view.add(f)
AttributeError: 'DumpMaster' object has no attribute 'view'
Could you please help me

Hi there! Thanks for reporting this - I have updated the example in PR #3097, which will be merged shortly.
There were a number of issues here:

The "view" addon is only present for interactive tools. I've changed the example to gracefully handle cases where view is absent.
We want to discourage direct invocation of methods on addons. I've exposed the "view.add" command that lets you add flows to the view.
Client replay is now also a command.
There was an infinite loop issue that I've fixed.

Hello, Thanks a lot for that quick reaction!
Could you please explain me what is view. I am connecting the proxy from chrome browser. My aim is changing the query parameters in a loop. in case of successful duplicate, is it possible to see in the browser all of these results ? In other words if loop changed the url 10 times, Can I see 10 different response at the browser or should I also add a mechanism to forward these responses to browser ?
And when I tried your example it gives me this error:
Addon error: Traceback (most recent call last):
File "dup.py", line 14, in request
ctx.master.commands.call("replay.client", [flow])
TypeError: call() takes 2 positional arguments but 3 were given
I could not understand there are 2 parameters but error says 3 were given.


update lat_lon geographic location (latitude and longitude)?

Current:
Definition = The geographical origin of the sample as defined by latitude and longitude. The values should be reported in decimal degrees and in WGS84 system
Expected value = decimal degrees
Value syntax = {float} {float}
Example = 50.586825 6.408977

Should the definition be updated to include defined areas using linear ring notation? (A linear ring is a closed LineString with four or more positions). If so the above values would become:
Definition = The geographical origin of the sample as defined by latitude and longitude. The values should be reported in decimal degrees and in WGS84 system, to specify an area you may use the Closed Linear Ring notation with a maximum of 4 reference points.
Expected value = decimal degrees
Value syntax = {float} {float} | [[{float} {float}],[{float} {float}],[{float} {float}],[{float} {float}],[{float} {float}]]
Example = 50.586825 6.408977 | [[-72.2803187, 42.92827], [-72.2804046,42.9268364],[-72.2778833,42.9267736],[-72.2778511,42.9282819],[-72.2803187,42.928274]]

I suggest a max of 4 reference points because otherwise, the value could become extremely long! NB- the closed linear ring notation requires that the first and last values be identical, this makes the 4 points result in 5 pairs of co-ordinates in the value where pairs 1 and 5 are the same.
If anyone has a different preference for the notation format please suggest it.

needs more discussion, but should consider a separate field for ranges or areas

was discussed at various calls: the consensus seems to be keep it as 1 field to facilitate continued use by NCBI.
Some issues raised include:
How do we accept range and area if its kept as 1 field?
EBI already accepts lat and lon terms separately at point of submission, but will continue to merge them for display and sharing with NCBI/INSDC, so if a change to individual terms is required in future EBI will not have a problem with it.
I suggest we keep the term as it is for MIxS v6 release.

likely to be a separate field for location area /boundary. This requires further discussion with CIG, hence flagged for v7.


Update ex5_6.cpp

Add consideration of negative numbers and numbers greater than 100.

It is my first time to use create a pull request . If it bother you ,i am sorry!


Add a copy of MIT license

It is good practice to add a copy of the license to the repository.

added it in 644382c as a text file, thanks for the recommendation


Type Formula not recognized when it returns String

Hi, thanks for creating this amazing library!
I've found one issue when accessing formulas of cells:
When a formula of a cell returns a String, like in
=IF(1,"1","0")
the cell gets parsed as a String, not as a Formula object.
If the formula returns plain numbers, like in
=IF(1,1,0)
it is correctly parsed as a Formula object.
My concrete use case is a bit different, where i have a cell with a formula that generates text:
="Some text with value from cell "&A5&" with other text"
and i would like to access the Formula to insert the value myself at runtime.
I've had a short look at parse.dart
https://github.com/justkawal/excel/blob/b43e587796b7d0f45450b9e81f584eca76b03dc1/lib/src/parser/parse.dart#L497
and it looks like the issue could lie not in the parser, but in the way Excel saves such cells. Not entirely sure tough, as i not fully understand what is going on there...
Maybe you have a better idea whats going on in this case?

@bbjay
Thanks for this issue,
Sorry for late response, As was stuck into Covid-19.
I will look it into week-ends as I'll will be free from my day-job.

@justkawal any update on this formula issue. I am trying to read a file which can have formula. After reading the formula, I need the value. After moving to null safety version, value is not available.
P.S. I am using excel files created by end user and will be processed by my web app.

Sorry for late response,
I know these functionalities are important.
Right now, I'm trying to focus on my day job in these hard-times in India.
It's very tough to earn these days in India.
Contributions are welcome,
Thanks for understanding.

any news ?


qa_openstack: Remove cloud-init plus dependencies

When running qa_openstack on an instance on cloud.suse.de and the
instance has cloud-init installed, there might be conflicts while trying
to install the cloud_* patterns due to already installed
packages (i.e. python-paramiko) and a needed vendor change.
Removing cloud-init plus dependencies resolves this.

This is a replacement PR for https://github.com/SUSE-Cloud/automation/pull/333

+1


fix: lazily run npm install when applying 'prettier' and client modules

If a package-lock.json is detected, and npm command is present, run npm install.
Fixes #11106
If we agree on the solution, we should do the same with:

[ ] react-core
[ ] angular-core

Let me having a look on this solution


Update tapir-akka-http-server, ... to 1.5.5

About this PR
📦 Updates

com.softwaremill.sttp.tapir:tapir-akka-http-server
com.softwaremill.sttp.tapir:tapir-asyncapi-docs
com.softwaremill.sttp.tapir:tapir-core
com.softwaremill.sttp.tapir:tapir-json-circe
com.softwaremill.sttp.tapir:tapir-openapi-docs
com.softwaremill.sttp.tapir:tapir-swagger-ui-bundle

from 1.4.0 to 1.5.5
📜 GitHub Release Notes - Version Diff
Usage
✅ Please merge!
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

🔍 Files still referring to the old version number
The following files still refer to the old version number (1.4.0).
You might want to review and update them manually.
.github/workflows/ScalaCI.yml
modules/zim-server/src/main/resources/static/js/cookie.js

⚙ Adjust future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "com.softwaremill.sttp.tapir" } ]

Or, add this to slow down future updates of this dependency:
dependencyOverrides = [{
  pullRequests = { frequency = "30 days" },
  dependency = { groupId = "com.softwaremill.sttp.tapir" }
}]

labels: library-update, early-semver-minor, semver-spec-minor, version-scheme:early-semver, old-version-remains, commit-count:1

Superseded by #345.


Author Docs for usage in React

Two phases:

docs on how to wrap a component in @lit/react + Lit SSR NextJS integration library
once #4432 is completed update docs to point to those

Any guidance on how should I use @material/web on my react application?

Sorry we've been racked with post 1.0 bug work and haven't gotten around to docs. Our recommendation for the docs (and for future auto-generation) is to use @lit/react
it's 1.19k and 695B gzipped.
If you want to use it in Nextjs SSR use @lit-labs/nextjs

Thank you for replying.
I was able to make it work earlier using @lit/react, as suggested.
I will leave an example here, just in case someone else is wondering how to use @material/web with react:
// file: Fab.react.tsx
import {MdFab} from<EMAIL_ADDRESS>import React from 'react';
import {createComponent} from '@lit/react';

export type {FabSize, FabVariant} from<EMAIL_ADDRESS>
export default createComponent({
  tagName: 'md-fab',
  elementClass: MdFab,
  react: React,
  events: {
    onClick: 'click',
  },
});

Now it is just a matter to import this default export and use it on the views.
@e111077, I am struggling to understand what and how many events each component dispatch in order to attach appropriated listeners on the createComponent . Is there an easy way to find it out? Are you planning to add this mapping on the documentation as well?

unfortunately this is a lack in our documentation. We need to manually annotate each element class with the proper @event jsdoc so that it can appear in material-web.dev
For example, we annotated Menu as a test example:
https://material-web.dev/components/menu/#events-2

Thank you for replying.
I was able to make it work earlier using @lit/react, as suggested.
I will leave an example here, just in case someone else is wondering how to use @material/web with react:
// file: Fab.react.tsx
import {MdFab} from<EMAIL_ADDRESS>import React from 'react';
import {createComponent} from '@lit/react';

export type {FabSize, FabVariant} from<EMAIL_ADDRESS>
export default createComponent({
  tagName: 'md-fab',
  elementClass: MdFab,
  react: React,
  events: {
    onClick: 'click',
  },
});

Now it is just a matter to import this default export and use it on the views.
@e111077, I am struggling to understand what and how many events each component dispatch in order to attach appropriated listeners on the createComponent . Is there an easy way to find it out? Are you planning to add this mapping on the documentation as well?

Thank you so much for your example, it saved me a lot of time! I can't believe the docs are not explicit on how to use the components in react js

I can't believe the docs are not explicit on how to use the components in react js

The two lil' devs over here would love a docs PR to help 🥲

Codegen anyone?

We (Grayhat) are working on a thin React wrapper which is in-sync with this repository. It's in its early stages, we'd appreciate any help.
https://github.com/grayhatdevelopers/material-web-react


[Discussion]                               ServiceWeaver as Distributed Monolith

"A long time ago in a galaxy far, far away...." CORBA provided similar approach.
And failed.One reason - when you build complex application and base negotiation between modules on methods/calls (object oriented style) instead of messages, you cannot achieve clean separation. Moreover you forget about networking, timing etc.
Negotiation between modules should be explicit, this is the only way to force developer to design application as set of undependable "network" components
With the same cost instead of interfaces, you can provide typed mailboxes and similar abstractions for negotiation.
ServiceWeaver tries to solve problem of convenient development and deployment of microservices.
But it didn't prevent building of distributed monolith
It doesn't change mindset

Hi @g41797,
Thank you for starting a discussion here. We received many similar statements, some from experts in distributed systems.
@mwhittaker wrote a response as a blog here. If you have time, we would welcome you to read it and share your thoughts back here.

first of all - thank you for small response latency
second - great blog and specially links within
"...is a mistake to try to isolate the programmer from the fundamental issues of remote calls" - I agree that ServiceWeaver helps to solve some problems of remote calls
but my point is different - not only remote calls are bad, any type of CALL is bad (local&remote)
message oriented paradigm is hard, but it's only way to change mind set and force developer/designer really decouple parts of the system.
Yesterday I saw some youtube videos and unknown terminology raised my attention - modular monolith - best solution etc, etc
I dived dipper (because I also didn't know what monolith is) and dipper (microservices - also silver bullet)
one link pointed to serviceweaver
what i understood:

a lot of applications were developed as monolith
microservices were created to solve problem of monolith (and other problems..)
develop microservices is not easy task
serviceweaver simplifies development/deployment of microservices and improves system stability
but (from my point of the view) it doesn't change way of design

and it turned out that last 30 years i developed modular monoliths

btw i opened new issue How to build modular monolith in another project
please take a look, possibly it will explain better what is the real problem
(and i don't participate in this project)

Discussion - discord

Closing the issue since the discussion moved to discord.


Assistant v2

Adds a new framework for the AssistantV2 service.
Generated using the following commits:

https://github.ibm.com/Watson/developer-cloud--api-definitions/tree/8e785da94f0c8d62ade5f8c54c1b73447b9aa321
https://github.ibm.com/MIL/watson-swagger-codegen/tree/4e7a739d8a08e2e18149521400cc26e0ff378280

In Source/AssistantV2/Assistant.swift, I had to add a line by hand to the createSession() method. For some reason, this method fails with the error message "Unsupported media type" when run on Linux. Adding the Content-Type: application/json header fixes it.
To elaborate: the API definition for createSession in AssistantV2 has the consumes property set to application/json. The generator was not adding that. So an alternative to adding yet another hand-edit to the long list of post-generation changes for the Swift SDK is making this change to the generator, and accepting that it will add many headerParameters["Content-Type"] = "application/json" lines to methods that don't actually need it. In particular, several methods in Discovery, Natural Language Classifier, Natural Language Understanding, Speech to Text, and Visual Recognition get this new header with the generator update. I ran all tests, and they seem to behave the same with or without that header (with the exception of the one AssistantV2 method).
Here is the change I made to the generator to add the header.
@mkistler Which option do you think is better? Creating another hand edit to just add the Content-Type header to that one method in AssistantV2, or updating the generator and adding the header to a bunch of other methods? As much as I hate the idea of hand-edits, I'm leaning towards that option to avoid unnecessary bloat.

Regarding the content-type header parameter, I think we should in the near term hand edit to add this just to createSession. In parallel, we should implore the Assistant service team to fix their API.

Hopefully that's doable. It's very strange that it works fine on macOS but not Linux. I checked the network requests from each platform, and they were identical. I'm wondering if it fails on any other platforms.
@dpopp07 Can you check what happens when you try to create a session in AssistantV2 in the Node SDK without the "Content-Type: application/json" header?

The "Content-Type: application/json" header is generated in the Node SDK so every time I've created a session, I have used that header. I have not had any problems at all.


Backspace Button Changes

[x] My code follows the style guidelines of this project.
[x] I have performed a self-review of my own code.
[x] I have commented my code, particularly in hard-to-understand areas.
[x] I have made corresponding changes to the documentation.
[x] My changes generate no new warnings.

Hey @sairish2001  why it is creating conflicts I am not getting?
I didn't have modified anything in index.html only id attribute is added.


Support of hardware H.264 video on Android

I wonder what is the reason that Gstreamer androidmedia plugin (amc) is not used in OpenWebRTC under Android platform? openh264 could be used as a fallback.

For decoding that would be ok but the encoder API is too under specified to be able to be used reliably. The uncompressed input video format is not defined nor is it possible to specify and it is not the same on every device. And then even when Google fix it, the problem is that only new Android will support it.

What do mean by saying encoder API too under specified? The amc plugin uses at the end oficial http://developer.android.com/reference/android/media/MediaCodec.html API. That should hide most of the incompatibilities of various hardwares. It is definitly better then interface with the c-libriaries directly.
I have tested AMC on two different Android devices with OpenWebRTC and it looks to work fine except the fact AMC itself needs minor improvements to use the MediaCodec API correctly.

@sdroege can answer better than I, but from what I have understood, the MediaCodec API does not allow enough information to be specified about the video format and memory layout of the input video frames. This means that you could end up with garbage output or segfaults unless you happen to get lucky.
If you have modifications to propose to the GStreamer AMC elements and can show that it works across different devices, we are absolutely interested in this and we will test on a few devices that we have too. :smile: It's not that we have anything against Android, just that the MediaCodec API has not been good enough so far and we have been tracking every Android update.

Maybe I get lucky ;), so this is why I am asking for more details if you can share. I bet you have not included AMC for a good reasons. Do you know if these garbage/segfaults applies to particular hardware or Android version? Which one? I would like to verify/reproduce it.

@marcin-sielski The main problem with the mediacodec API for encoding is that you don't know which color formats (layout, stride, plane offsets, etc) a specific encoder accepts. GStreamer could provide anything needed, we just don't know what is needed and it's different for every device.
I saw that there were some improvements in version 22 of the mediacodec API that improve some other aspects, but this still seems to be unsolved.
If you have any improvements to the androidmedia plugin, or ideas how things can be improved, please let us know :) GStreamer patch reviews, etc are happening at https://bugzilla.gnome.org (the GStreamer Bugzilla product there).

@sdroege Thank you for explanation. But still I have two different devices where I use encoder and it works just fine (Android v4.2.2, v5.1.1). I would like to find a device that is known cusing problems. I can imagine that there are devices based on the chipset family from the same manufacturer that will not work.

Which hardware is in those?
And you mentioned changes you had to do, what are those?

@marcin-sielski ^

Some updates on that issue:

I found currently one device where AMC ends up strange colors (it is Exynos based).
WebRTC.org added HW encoder support for H.264 for Androids starting from KitKat+ mainly because of possibility to change bitrate dynamically (MediaCodec.setParameters method).
AMC works for JB with the limitation described in 2.

@marcin-sielski , could you please share your change about enabling hardware encoder on android?
I'm also trying to verify it on android devices.
thanks


BigDouble Mod Error

I think there is an error with the mod function.
Error occurs when testing mod functions with values greater than two digits.
Is there any solution or test case? or something I wrong?

Fix it and make a PR https://github.com/mkrd/Swift-BigInt/pull/73


added upload endpoint method for private/partners apikey

I think this is a pretty good change. If you want to create a PR on my repo and add a few tests, that would be awesome!


New version: Tiled.Tiled version 1.10.0

Result: Installation Failed

Manifest
Add/Remove Programs

Name
Tiled

Version
1.10.0

Publisher
mapeditor.org

ProductCode

Auto-updated by vedantmgoyal2009/winget-pkgs-automation in workflow run 6547
Microsoft Reviewers: Open in CodeFlow

Hi @vedantmgoyal2009,
The application installed normally, but gave an error when it launched:


Current database reverts to Master after a short time passes

I'm not sure where this problem is coming from so I'll describe it and maybe someone has a clue!
On Mac.
Using Docker for Mac.
I'm running a container from the linux image.
I then start up sqlcmd via mssql. By default it points to master.
I use a different database. Run some commands (.tables, a sql query).
If I let it sit for about one minute it has reverted to master. For example if I re run the tsql query, it says the table I'm querying doesn't exist. Then I do some commands to discover I'm back on master.
I don't know if this is coming from the image or from sql-cli.
Thanks

At the beginning you say 'sqlcmd'. At the end you say sql-cli.  Can you please clarify which tool this is happening with?  And when you say 'start up sqlcmd via mssql' - what does that mean?  You mean you are running sqlcmd inside the container?

sorry, that was messy. I've edited the original comment. Using sql-cli from outside the container. HTH

@julielerman - I tried this just now on my mac.  Was able to repro.  Here's what I tried.  docker run a mssql-server-linux.  Connect using mssql (sql-cli) from the host to the container - i.e. mssql -s localhost and dont pass a specific database name.  Run select @@version and select name from sys.databases.  Use a simple user database i have on the container.  Run .tables and it shows me the tables in the user db.  Run a couple of select queries.  Let it sit for a couple of minutes.  Run the select query again.  Table could not be found.  I'd suggest opening an issue on the sql-cli project and see if this is something they have heard of before.  Seems to be pretty easy to reproduce.  https://github.com/hasankhan/sql-cli

thanks Travis. submitted here: https://github.com/hasankhan/sql-cli/issues/44
Also happening on Windows.
When I first saw this, I was so new to all of these tools SQL at command line, docker, and sql for linux) that I wasn't sure where to look for the source of the problem. I'm feeling a little more savvy now though. Thanks for your patience :)


Missing proxy support for jenkins::slave

There is no support to install a jenkins slave if you only have internet access via proxy

Resolved by https://github.com/jenkinsci/puppet-jenkins/commit/1867f4ec8506a5d0a3ff9b09911500c2345cab98


Heterogeneous policy?

Can the configuration files be changed to make each agent uses different algorithms during training? For example, one agent uses the IPPO algorithm while another agent uses IQL algorithm.

Yes.
RLlib provides an example here.

Is it possible to replicate the example you provide by simply altering the .yaml files you provide in this package?


Remove System.Private.Uri reference

This is an issue for us to effectively undo #8833 once a new version of the MS.VS.Telemetry library is available that doesn't bring in System.Diagnostics.Trace anymore. The PR for that work is here

nit (for search ability): do you mean System.Diagnostics.Tracing?

@jaredpar Is there anything to do here still?

Make it so!


Fix ruby 3.4 compatibility

Same as https://github.com/pganalyze/pg_query/pull/320 but that PR got no workflow to approve anymore and author not responding for 5 days

Thanks for opening a new PR!

No idea what's wrong

I'm not sure what changed in Ruby 3.4 for this require to no longer be needed, but we'll surely need to still require it for older Ruby versions. For example:
require 'pg_query/pg_query' unless RUBY_VERSION > '3.4'

Also note that you'll want to add Ruby 3.4 to the CI matrix. But with the comment on that line, there may be some extra work to support Ruby 3.4 in the protobuf gem.

Updated, added 3.4.0-rc1 to matrix (would 3.4 pick up rc versions? I dunno
Found [google-protobuf](https://rubygems.org/gems/google-protobuf) PR for ruby 3.4 https://github.com/protocolbuffers/protobuf/pull/19752 but CI failing so no idea if it supports 3.4 yet

I just run locally to see without workflow approval
Without the require some methods are not defined

Adding back the require brings us back to the same issue...

Turns out it might be development version specific issue
See https://github.com/grpc/grpc/pull/31970 (I took some code changes from that gem's latest version)
Locally run on 3.2, 3.3, 3.4.0-rc1

No idea how to test freebsd one (not in CI matrix as well)

Update Gemfile.lock I guess...?
(For my own gems I never got it checked-in
Also 3.4.0-rc1 is unavailable on windows. Do you prefer skipping it or using head?

Yes I forgot to run bundle update, my fault...

It looks like it's still failing on 3.4 due to protobuf issues, but it's also failing on 2.7. I think for 2.7, we could consider dropping it, since that's been out of support for over a year...

Ya google-protobuf native gems are declared to be incompatible with 3.4 until 3.4 released
We can still test 2.7 if Gemfile.lock is dropped.

Do we want to try using force_ruby_platform just to see if CI passes? (Can still wait for native version to be released


I don't know what is wrong...

For some reason, it keeps crashing when ever I load up my private server, and gives me the same error...
I don't know what is wrong... I, at first, thought it was my mythicmobs installation, so I removed that.
I supposed I should have just went here in the first place.
Here is my log:
crash-2018-03-21_21.40.10-server.txt
Sorry about that... XD I have been messing with OTG for a while, and It is AMAZING!

Oh, and btw, I'm not 100% active, so it may be a while for me to get back...

Oh, and I am also running Spigot 1.12.2. I don't remember which build, but I think it is the latest.
Thanks in advanced!
-- C_Corp2002

Aaand it crashed again, on another multiworld plugin...
Here's the log:
crash-2018-03-22_16.41.34-server.txt
I love this plugin, but it just wont work.

Hey, thanks for reporting this and sorry for the late response. If you're still having this issue, feel free to re-open this ticket or join us on the OTG discord at /openterraingen.


expect_raises rescues AssertionFailure

Consider this method in single_spec.mt
    def expect_raises(&block)
      block()
      raise %AssertionFailure{@name, expected_error, "no error"}
    rescue
      # If an error was raised, the assertion passes.
    end

If we pass it a non-error producing block it will still pass the spec since the AssertionError will be rescued

Nice catch! I suppose a simple solution could be to add a second rescue clause for AssertionFailures and re-raise in that case?
def expect_raises(&block)
  block()
  raise %AssertionFailure{@name, expected_error, "no error"}
rescue ex : AssertionFailure
  # Rescuing an AssertionFailure implies that `block` did
  # not raise an exception, so the exception is re-raised.
  raise ex
rescue
  # Otherwise, the error must have come from `block`, so the
  # assertion is successful.
end

That feels kind of ugly, but I can't think of a nicer way to handle that case...


Tooltip: remove is prefix in props

Closes #3417
Description
Removing all is prefix from is*
Current behavior (updates)
Before: isOpen, defaultIsOpen, isDisabled
New behavior
After: open, defaultOpen, disabled
Is this a breaking change (Yes/No):
No
Additional Information

@hirotomoyamada I have removed them, please re-review.


[DOC] Get snapshot status docs have incorrect information

What do you want to do?

[ X] Request a change to existing documentation
[ ] Add new documentation
[ ] Report a technical problem with the documentation
[ ] Other

Tell us about your request. Provide a summary of the request and all versions that are affected.
Hi Team,
Can we please review this bit of the documentation.
Three request variants provide flexibility:

    GET _snapshot/_status returns the status of all currently running snapshots in all repositories.

    GET _snapshot/<repository>/_status returns the status of only currently running snapshots in the specified repository. This is the preferred variant.

    GET _snapshot/<repository>/<snapshot>/_status returns the status of all snapshots in the specified repository whether they are running or not.

The last bit says returns the status of all snapshots in the specified repository whether they are running or not.. I'm pretty sure this is incorrect as the request path already has a specific snapshot id in it, so the response will have to be snapshot specific. This is in alignment with the example request underneath...
GET _snapshot/my-opensearch-repo/my-first-snapshot/_status
{
   "ignore_unavailable": true
}

...that returns status information of a single snapshot called my-first-snapshot from the my-opensearch-repo repository.
And the Elasticsearch docs seem to agree with me as well :)
https://www.elastic.co/guide/en/elasticsearch/reference/current/get-snapshot-status-api.html#get-snapshot-status-api-example
I recommend that we change the second and the third examples in our docs as follows:
Three request variants provide flexibility:

    GET _snapshot/_status returns the status of all currently running snapshots in all repositories.

    GET _snapshot/<repository>/_status returns all currently running snapshots in the specified repository. This is the preferred variant.

    GET _snapshot/<repository>/<snapshot>/_status returns detailed status information of a specific snapshot in a specific repository, regardless of whether it is currently running or not.

Cheers,
Laz

Thanks for discovering the problem and entering this issue, @lmako-aws ! Would you be willing to push up a PR with this change to expedite the process?

I'd love to help @hdhalter but unfortunately I have no idea how to do a PR, sorry.

OK : ) But if you'd like to learn how, it's pretty straight-forward.  We then review it and merge it in production. Full instructions are here: We https://github.com/opensearch-project/documentation-website/blob/main/CONTRIBUTING.md.

Thanks, @lmako-aws! But can you please fork the doc repo and make your changes there? Alternatively, we can create a new PR with your changes. Whichever you prefer! Thanks. Here is the file: https://github.com/opensearch-project/documentation-website/edit/main/_api-reference/snapshots/get-snapshot-status.md.

Hi @hdhalter - My apologies, I thought I've already replied to your previous comment. If you could do this please, that would be very much appreciated. Thanks for your help!

Hi @hdhalter - My apologies, I thought I've already replied to your previous comment. If you could do this please, that would be very much appreciated. Thanks for your help!

No problem, thanks!


Making logging to file work again

Putting up as a draft but I think I should make at least one more change: not logging to file in release builds.
Logging to file in this implementation is stupidly expensive, because AFAICT you can only write whole files with the Expo FileSystem API. I don't really want to keep all log lines in memory but maybe that would actually be better? At least then I wouldn't need to read the whole file before writing 🤷. Anyway, I try to minimize the badness by buffering up writes and flushing at most once per second. I'm guessing that our old logging package was doing something similar but I don't know.
The other change I made was to centralize creation of the logger object and make it a singleton.
Now, the good news: you can get badass views of these log files. Here's one showing filtering by log level, colored output and nice object formatting:

This PR will resolve #383, but emailing log files on iOS won't be supported until #382 is resolved.

Seems reasonable. The state of the ecosystem for logging client-side and doing things like flushing and log rotation is really bad. Not a blocker, but you might consider some naive log rotation code to ensure we don't eat up too much filesystem space on the user's device if they use the app all season.

Seems reasonable. The state of the ecosystem for logging client-side and doing things like flushing and log rotation is really bad. Not a blocker, but you might consider some naive log rotation code to ensure we don't eat up too much filesystem space on the user's device if they use the app all season.

yeah, there's naive rotation here, where the file gets truncated to 0 bytes by the write:
https://github.com/NWACus/avy/blob/bdf37b96a0b357716af1ddb7103576e76c84353f/logging/fileStream.ts#L9-L13
might be a little subtle, I'll add a comment calling out what's happening there.

(but also, if we don't log to file in the actual production builds then we should be ok)

yeah, there's naive rotation here, where the file gets truncated to 0 bytes by the write:

So the file will only ever contain 1s of logs? Seems like it might be of limited utility then.

(but also, if we don't log to file in the actual production builds then we should be ok)

I understood the main reason we want to log to the file is to allow users to submit the logs with bug reports, right? Would we enable logging in the production builds at some point then?

yeah, there's naive rotation here, where the file gets truncated to 0 bytes by the write:

So the file will only ever contain 1s of logs? Seems like it might be of limited utility then.
No, that's in the constructor for the FileStream - truncating the file at startup, in other words.

(but also, if we don't log to file in the actual production builds then we should be ok)

I understood the main reason we want to log to the file is to allow users to submit the logs with bug reports, right? Would we enable logging in the production builds at some point then?

Mayyyyyybe? It seems like an option. I guess we should see if we think it's useful, and balance that with the potential issues around allowing unrestrained emails to us :)
We can probably get a long way by attaching files to our Sentry issues: https://docs.sentry.io/platforms/react-native/enriching-events/attachments/

What would be the use of logging to the file if it's not for users to send with bug reports? Could we just remove the feature?>


since ios 14, animated gif without loop are rendered twice

Description
since ios 14, animated gif without loop are rendered twice
React Native version:
"react-native": "^0.63.2" and ios 14
Steps To Reproduce
use a gif without loops and use it like:
<Image source=
Expected Results
run the gif without the second loop

Same issue here on 0.63.3 with iOS14.

I am having same issue with IOS 14

+1 Also same issue on 0.63.3 with iOS14

I did a bit of digging into the ios animated image code and found that if I changed this:
      // A loop count of 1 means it should repeat twice, 2 means, thrice, etc.
      if (loopCount != 0) {
        loopCount++;
      }

to this:
      if(@available(iOS 14, *)) {
      } else {
      // A loop count of 1 means it should repeat twice, 2 means, thrice, etc.
        if (loopCount != 0) {
          loopCount++;
        }
      }

then my animated gif renders only once on iOS 14 and still renders only once (as it always has) on iOS 13.7 as well. Maybe something changed with the way that gifLoopCount is calculated in iOS 14?

FWIW - this is the only thread I could find on this, but I was having the same issue with a non-looping gif rendering twice in a web project (not React or React Native). It was happening in both Safari and Chrome on my iOS 14 device until I updated to iOS 14.2 last night, and that resolved the issue for me.

I did a bit of digging into the ios animated image code and found that if I changed this:
      // A loop count of 1 means it should repeat twice, 2 means, thrice, etc.
      if (loopCount != 0) {
        loopCount++;
      }

to this:
      if(@available(iOS 14, *)) {
      } else {
      // A loop count of 1 means it should repeat twice, 2 means, thrice, etc.
        if (loopCount != 0) {
          loopCount++;
        }
      }

then my animated gif renders only once on iOS 14 and still renders only once (as it always has) on iOS 13.7 as well. Maybe something changed with the way that gifLoopCount is calculated in iOS 14?

can you explain how this line if(@available(iOS 14, *)) works?

I did a bit of digging into the ios animated image code and found that if I changed this:
      // A loop count of 1 means it should repeat twice, 2 means, thrice, etc.
      if (loopCount != 0) {
        loopCount++;
      }

to this:
      if(@available(iOS 14, *)) {
      } else {
      // A loop count of 1 means it should repeat twice, 2 means, thrice, etc.
        if (loopCount != 0) {
          loopCount++;
        }
      }

then my animated gif renders only once on iOS 14 and still renders only once (as it always has) on iOS 13.7 as well. Maybe something changed with the way that gifLoopCount is calculated in iOS 14?

can you explain how this line if(@available(iOS 14, *)) works?

loopCount is not increased on iOS 14 or higher.
https://developer.apple.com/documentation/swift/objective-c_and_c_code_customization/marking_api_availability_in_objective-c
Can someone prepare a pull request with the fix?

I did a bit of digging into the ios animated image code and found that if I changed this:
      // A loop count of 1 means it should repeat twice, 2 means, thrice, etc.
      if (loopCount != 0) {
        loopCount++;
      }

to this:
      if(@available(iOS 14, *)) {
      } else {
      // A loop count of 1 means it should repeat twice, 2 means, thrice, etc.
        if (loopCount != 0) {
          loopCount++;
        }
      }

then my animated gif renders only once on iOS 14 and still renders only once (as it always has) on iOS 13.7 as well. Maybe something changed with the way that gifLoopCount is calculated in iOS 14?

can you explain how this line if(@available(iOS 14, *)) works?

loopCount is not increased on iOS 14 or higher.
https://developer.apple.com/documentation/swift/objective-c_and_c_code_customization/marking_api_availability_in_objective-c
Can someone prepare a pull request with the fix?

I did a bit of digging into the ios animated image code and found that if I changed this:
      // A loop count of 1 means it should repeat twice, 2 means, thrice, etc.
      if (loopCount != 0) {
        loopCount++;
      }

to this:
      if(@available(iOS 14, *)) {
      } else {
      // A loop count of 1 means it should repeat twice, 2 means, thrice, etc.
        if (loopCount != 0) {
          loopCount++;
        }
      }

then my animated gif renders only once on iOS 14 and still renders only once (as it always has) on iOS 13.7 as well. Maybe something changed with the way that gifLoopCount is calculated in iOS 14?

changing the above code does not work on my project, still animating twice in ios 14,
attaching the gif and the video how it behaves on the app
https://user-images.githubusercontent.com/38404135/108080357-c73c7c00-7095-11eb-839b-1c8bcda3cc20.mov

I did a bit of digging into the ios animated image code and found that if I changed this:
      // A loop count of 1 means it should repeat twice, 2 means, thrice, etc.
      if (loopCount != 0) {
        loopCount++;
      }

to this:
      if(@available(iOS 14, *)) {
      } else {
      // A loop count of 1 means it should repeat twice, 2 means, thrice, etc.
        if (loopCount != 0) {
          loopCount++;
        }
      }

then my animated gif renders only once on iOS 14 and still renders only once (as it always has) on iOS 13.7 as well. Maybe something changed with the way that gifLoopCount is calculated in iOS 14?

changing the above code does not work on my project, still animating twice in ios 14.4,
attaching the gif and the video how it behaves on the app
https://user-images.githubusercontent.com/38404135/108080357-c73c7c00-7095-11eb-839b-1c8bcda3cc20.mov

are you sure that modal is gif?
and have you tried to rebuild your app after you change the module?

Any update on this issue? Or any official fix is done?

Same here animated gifs animate *2

Same in iOS 14.5 and android

It seems to have been fixed. Thanks!
On Sun, Jan 9, 2022 at 4:46 AM stale[bot] @.***> wrote:

Hey there, it looks like there has been no activity on this issue
recently. Has the issue been fixed, or does it still require the
community's attention? This issue may be closed if no further activity
occurs. You may also label this issue as a "Discussion" or add it to the
"Backlog" and I will leave it open. Thank you for your contributions.
—
Reply to this email directly, view it on GitHub
https://github.com/facebook/react-native/issues/30147#issuecomment-1008282217,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ACLWJGRAG5QQNULK3PL7GSTUVFYRTANCNFSM4SJ7JFWQ
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>

--
Ethan Dirks
www.ethandirks.com
210-310-8757


EventDataBatch.TryAdd does not copy buffer to batch as documentation indicates

Library name and version
Azure.Messaging.EventHubs v5.7.2
Describe the bug
The documentation for Azure.Messaging.EventHubs.Producer.EventDataBatch.TryAdd has the following remarks:

Remarks
When an event is accepted into the batch, its content and state are frozen; any changes made to the event will not be reflected in the batch nor will any state transitions be reflected to the original instance.

However, when trying to use a shared buffer as the backing source per EventData instance, the data is not persisted in the EventDataBatch
Expected behavior
using var eventDataBatch = await _eventHubClient.CreateBatchAsync();
var buffer = new byte[1024];
while (true)
{
    buffer.Clear();
    buffer = someInput;
    if (!eventDataBatch.TryAdd(new EventData(buffer))
        break;
}

I would expect, based on the remark, that during TryAdd, the buffer's contents are serialized into the raw amqp message and added to the batch, allowing it to be reused in the add loop.
Actual behavior
What I am seeing however is that clearing the buffer is being reflected back into the batch itself, making the use of a buffer completely impossible and causing the above remark to be inaccurate at best and (in my case), quite dangerous.
Reproduction Steps
See the above.
Environment
I am seeing the same behavior on Windows, Linux and MacOS, on .NET 6.

Hi @Stabzs.  Thank you for reaching out and we regret that you're experiencing difficulties.  The value that you're passing the EventData constructor is of type ReadOnlyMemory<byte> which, by contract, offers a guarantee that it will not change and is safe to use as a buffer.   Internally, the body of the serialized message references this read-only memory buffer until it is sent over the network.
That said, it wasn't our intent to allow a side-effect like this and the serialized form is intended to be immutable; we did not account for this specific scenario.  I'll take a look at getting this patched up so the side-effect is no longer possible.
The mitigation, in the meantime, would be to create a new buffer for each EventData to honor the contract of ReadOnlyMemory<T>

Thanks for the quick response @jsquire!
Do you have documented guidance on the guarantee of ReadOnlyMemory<byte> by chance? My interpretation has always been that the guarantee is for that specific call and that there is no guarantee beyond the specific call, which would make sense whenever you have a reusable buffer that you have to project to ReadOnlyMemory<T>. I was expecting the behavior to be similar to System.Text.Json.JsonSerializer.Deserialize<ReadOnlySpan<byte> utf8Json, ...) where instead of returning an object, the ReadOnlyMemory<byte> was serialized to the amqp payload.
If it helps, the intent is have zero allocations during the serialization of the payload and adding to the batch, and instead allowing the batch itself to allocate what it needs for the raw amqp message.  I can absolutely continue creating intermediary byte arrays in the interim, but being able to use a patched version in the near future would be wonderful since it would avoid the intermediary allocation.

Let me see if I can find a public write-up for ROM where the .NET team talks about the contract.
In the meantime, I'll mention that the number of allocations isn't likely to change for your scenario if we do add a specific guard.   We'd need to make a defensive copy of the buffer you pass in, which would then serve as where the body of the serialized message points as a buffer.  The main difference would likely be that we'd increase allocations for common case where callers don't mutate the body after creating the event, since we'd have to assume that any byte[] is potentially unsafe.

If there isn't any option for directly writing to the batch output stream, adding the guard doesn't make a lot of sense since like you said, it hurts the common case. That doesn't seem like a useful tradeoff to accommodate this edge case especially if it doesn't meet my optimization goal in the first place.

Apologies for the slow follow-up.   I wanted to let my brain spin on things for a bit, poke at the code, and grab some additional opinions.   Here's where we're at:
I agree your statement "the guarantee is for that specific call".   In this case, since the memory was passed to the EventData constructor, and the scope of the "call" is the lifetime of the associated instance.  I verified that this also aligns with the internal guidance that we used when choosing the type.  After asking around, we weren't able to locate documentation with explicit guidance for the read-only memory contract.  I opened a request for the Docs team to consider adding some.
Where it gets interesting is that, in this scenario, we explicitly state that the EventData is no longer relevant to the batch after TryAdd completes.   I believe your perspective here is the correct one - it should not matter what you do with the buffer at this point, the batch should be fully immutable.  We're not, currently, because "serialization" in this case means "projecting into an intermediate model that our transport library uses" rather than the normal connotation of "translated this into a set of bytes to put on the wire."   To avoid allocations, we're not making a defensive copy of the event body among some other optimizations which is where we violated our own intent.
The correct behavior is expressed by the docs; we overlooked this scenario and are going to patch it up.   I've got some thoughts that I want to play with around to avoid making a direct copy always to minimize impact on the common case.   It'll take me a bit to work through and given the potential impact, I also want to leave time to do a full set of stress/reliability runs.
This won't make the October release, but we'll aim to include it in November.  For now, I'm going to reclassify as a bug and schedule it.

Makes sense @jsquire and I appreciate the thoughtful response! Looking forward to the November release :).

Thank you all for the perspectives and discussion in the prototype PR (#31845).  The outcome of those conversations ended in agreement that the performance cost of making a defensive copy outweighs the desire to guarantee the batch is fully immutable.   Rather than doing so, we've updated the documentation to call out that any memory buffers held by the event are referenced by the batch and must remain available and unchanged until the batch is disposed.   (see: #3204)
Closing this out.


Typekit integration in Kirki

Hi!
This code has some issues.
https://github.com/aristath/kirki/issues/1265
When I have several fonts installed on my site, one with Google font and the other with a typekit, there appears an error and gfonts not loaded. Can I fixed it?
https://fonts.googleapis.com/css?family=Work+Sans%3A100%2C200%2C300%2Cregular%2C500%2C600%2C700%2C800%2C900%7CVidaloka%3Aregular%7CPlayfair+Display%3Aregular%2Citalic%2C700%2C700italic%2C900%2C900italic%7Chalyard-display%3A100%2C100italic%2C200%2C200italic%2C300%2C300italic%2Cregular%2Citalic%2C500%2C500italic%2C600%2C600italic%2C700%2C700italic%2C800%2C800italic%2C900%2C900italic&subset=Cyrillic%2CCyrillic+Extended%2CDevanagari%2CGreek%2CGreek+Extended%2CKhmer%2CLatinFailed to load resource: the server responded with a status of 400 (HTTP/2.0 400)

So in console i have next error
https://fonts.googleapis.com/css?family=Work+Sans%3A100%2C200%2C300%2Cregular%2C500%2C600%2C700%2C800%2C900%7CVidaloka%3Aregular%7CPlayfair+Display%3Aregular%2Citalic%2C700%2C700italic%2C900%2C900italic%7Chalyard-display%3A100%2C100italic%2C200%2C200italic%2C300%2C300italic%2Cregular%2Citalic%2C500%2C500italic%2C600%2C600italic%2C700%2C700italic%2C800%2C800italic%2C900%2C900italic&subset=Cyrillic%2CCyrillic+Extended%2CDevanagari%2CGreek%2CGreek+Extended%2CKhmer%2CLatinFailed to load resource: the server responded with a status of 400 (HTTP/2.0 400)

Yes. I also have this problem. I hope, this problem will solution.

Hey there!
How exactly are you adding those typekit webfonts?
Do you have this in a repository on github perhaps?

Yep.
I tried to use this filter 'google_fonts', but this is not working. (See the first message of this issue)
https://github.com/vlthemes/VLThemes-Add-Typekit-fonts-to-Kirki

Is there a solution already?

fixed.


Llama3.1 prefill hang

@tstescoTT reports that running continuous batching in a loop leads to hangs during prefill, usually on seqlen=256 and 512.

Thanks for reporting the issue here, I'll add some logs:
2024-09-20:12:00:28,778 INFO     [lm_backend.py:455] Decoding batch with indices [237, 1541, 574, 691, 406, 733, 387, 767, 231, 596, 767, 618, 461, 461, 626, 758, 443, 212, 793, 1559, 666, 290, 375, 1045, 487, 619, 503, 669, 496, 694, 820, 257]
2024-09-20:12:00:28,897 INFO     [lm_backend.py:415] Filling kv cache for user_id:= 10, prefill_ids.shape:=torch.Size([1, 256]), seq_len=151
2024-09-20:12:00:29,333 INFO     [lm_backend.py:434] completed prefill user_id:= 10, next_token:=1271
2024-09-20:12:00:29,333 INFO     [lm_backend.py:455] Decoding batch with indices [238, 1542, 575, 692, 407, 734, 388, 768, 232, 597, 151, 619, 462, 462, 627, 759, 444, 213, 794, 1560, 667, 291, 376, 1046, 488, 620, 504, 670, 497, 695, 821, 258]
...
2024-09-20:12:00:30,390 INFO     [lm_backend.py:455] Decoding batch with indices [247, 1551, 584, 701, 416, 743, 397, 777, 241, 606, 160, 628, 471, 471, 636, 768, 453, 222, 803, 1569, 676, 300, 385, 1055, 497, 629, 513, 679, 506, 704, 830, 267]
2024-09-20:12:00:30,509 INFO     [lm_backend.py:415] Filling kv cache for user_id:= 18, prefill_ids.shape:=torch.Size([1, 256]), seq_len=241

... hang for 10+ minutes

It happens almost always on 256, not always on the same prompt, and typically after 1000+ prompts are completed.

Resolved this with PR https://github.com/tenstorrent/tt-metal/pull/13348


Web RDP: Investigate supporting dynamic resizing without a refresh

Can we support dynamic resizing without a refresh? When we originally created this module I believe this was working, but I could be mistaken.
A couple of customers reported this as well
https://www.loom.com/share/03ef61e0f0fc40419a192a9e74b357b4

@Parkreiner @stirby was this something we originally investigated, or is this a new request? My memory isn't serving me correctly

I think this is something Kirby was looking into. So far, I don't think the Coder module logic does enough that would cause Devolutions to break. All it's doing is handling the form auto-submission and  hiding the sidebar
I guess it's possible that when the app resizes, the Devolutions app logic tries subtracting the width the sidebar should be from the width of the rest of app. And because the sidebar is gone, that extra width being subtracted isn't being added back
I can look into that part specifically, but I think @stirby was looking into some other parts of this issue


Test: webview debugging

Refs: #96626

[ ] anyOS @eamodio
[ ] anyOS @alexdima

Complexity: 4
Create Issue

We can now debug webviews native in VS Code, such as those created in custom editors and notebook renderers. Test this!
If you have a notebook renderer or webview editor already, you can use that. Otherwise, you can use a sample project / the yeoman generator for notebooks.

Make sure you're on the latest Insiders build
Make sure you're using js-debug nightly https://github.com/microsoft/vscode-js-debug#nightly-extension
Add "webview.experimental.useIframes": true, to your user configuration. (Workspace configuration only will not work!)
Add debugWebviews: true to your extensionHost launch config.

By default this will attach to all webviews, to narrow this you can instead specify an object like { "urlFilter": "*yourExtensionId*" } for custom editors or { "urlFilter": "*notebookRenderer*" } for notebook renderers
This object is a subset of the normal chrome launch config. If you need to set up webroots, source map overrides, etc. you can do that in here.

F5 and it should 'just work' :sparkles:

Note: iframe webviews are experimental (https://github.com/microsoft/vscode/issues/83188). If you have issues with the webview itself/when not in debug mode, please report those to Matt. Also, with iframes, "open webview developer tools" will no-op, instead you can open the normal developer tools and look at iframes there.

Please ensure electron is bumped to 7.3.2 prior to testing

Very cool!! This just works  ✨ ✨ ✨

This is so awesome! Works great! This will make debugging webview so much less painful.


Static pages

tests are failing for all commits do to an issue with the latest patch to Node 6.x. I have updated our node install to 8.x in PR #745

No conflicts so merging this one. @bhavi just be sure to rebase and squash your git history before submitting your next PR


move the root all data statistics to ErrorReport and ErrorAnalysisData (part 2)

Description
Note: this is part 2 of the change, which is for responsibleai and the UI after erroranalysis package has been published.
Move the root all data statistics to ErrorReport and ErrorAnalysisData.
Currently we pass the root data statistics only in the error analysis dashboard, which is the data set on the "all data" cohort when it is first initialized. This PR moved the root data statistics to ErrorReport and ErrorAnalysisData in order to make it consistent with other error analysis properties. This also resolves the issue where error rate statistics are shown for the regression scenario when the RAI dashboard is first loaded.
Areas changed

npm packages changed:

[ ] responsibleai/causality
[ ] responsibleai/core-ui
[ ] responsibleai/counterfactuals
[ ] responsibleai/dataset-explorer
[ ] responsibleai/fairness
[ ] responsibleai/interpret
[ ] responsibleai/localization
[ ] responsibleai/mlchartlib
[ ] responsibleai/model-assessment

Python packages changed:

[ ] erroranalysis
[ ] raiutils
[ ] raiwidgets
[ ] rai_core_flask
[ ] responsibleai

Tests

[ ] No new tests required.
[ ] New tests for the added feature are part of this PR.
[ ] I validated the changes manually.

Screenshots (if appropriate):
Documentation:

[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.

Codecov Report

Merging #1352 (6c55cb8) into main (04b7fa1) will decrease coverage by 10.76%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##             main    #1352       +/-   ##
===========================================
- Coverage   86.34%   75.58%   -10.77%
===========================================
  Files         100       10       -90
  Lines        4723      258     -4465
===========================================
- Hits         4078      195     -3883
+ Misses        645       63      -582

Flag
Coverage Δ

unittests
75.58% <ø> (-10.77%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

...dgets/raiwidgets/error_analysis_dashboard_input.py

raiwidgets/raiwidgets/explanation_constants.py

responsibleai/responsibleai/_interfaces.py

responsibleai/responsibleai/_internal/constants.py

...i/responsibleai/managers/error_analysis_manager.py

raiwidgets/raiwidgets/error_handling.py

...iwidgets/raiwidgets/model_performance_dashboard.py

.../responsibleai/_managers/error_analysis_manager.py

raiwidgets/raiwidgets/responsibleai_dashboard.py

responsibleai/responsibleai/__version__.py

... and 80 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 04b7fa1...6c55cb8. Read the comment docs.


feat(Import external CSS files):

Support importing external CSS files and optimizing HMR mechanism

Added the function of importing external CSS files, supporting importing CSS files through vineStyle.copied
Optimize HMR mechanism, support updating only changed style files, and improve hot update efficiency
Add the importTag property to identify the imported CSS file
Fixed some issues related to importing style files

close #151

Close by #155