Tags cannot be numbers

Trying something like the following:
write('logins', fields={'value': 1}, tags={'tag1': 1})

Getting back:
InfluxDBClientError: 500: {"error":"json: cannot unmarshal number into Go value of type string"}

Substituting 1 with '1' in tags works though:
write('logins', fields={'value': 1}, tags={'tag1': '1'})

This is by design. Check out the docs here:
http://influxdb.com/docs/v0.9/concepts/reading_and_writing_data.html#tags
Any questions, let us know.
Philip
On Fri, Mar 13, 2015 at 9:17 AM, Federico Capoano<EMAIL_ADDRESS>wrote:

Trying something like the following:
write('logins', fields={'value': 1}, tags={'tag1': 1})
Getting back:
InfluxDBClientError: 500: {"error":"json: cannot unmarshal number into Go value of type string"}
Substituting 1 with '1' in tags works though:
write('logins', fields={'value': 1}, tags={'tag1': '1'})
—
Reply to this email directly or view it on GitHub
https://github.com/influxdb/influxdb/issues/1939.

Ok sorry I missed that bit in the docs.
So in case I wanted to have a column that is a number but is also indexed as a tag I should make it both a (typecasted) tag and a column, right? Or maybe this doesn't make sense at all and there are better ways?
Thanks

Yes, you can use set a tag to the string version of a number, but it not may make sense. You'd need to provide more details on your data, so we can provide schema advice. Please send a message to the mailing list since it's not a bug, just a question.

hey @otoolep this is the question i've sent on the ML: https://groups.google.com/d/msg/influxdb/DoP8gV9IBA8/gEQdlsWWlpoJ


-verbose flag

Hi Declan,
Is there a chance you can add a -verbose option? for removing all the print. (For debugging purposes, when I denoise multiple frames it will be more readable if all the print are hidden). Thanks again for your work.
Chris

Hey Chris,
Sorry for the slow response. Sounds like a reasonable enough request, I'll try and add something soon!
Cheers!

Thanks Declan, you rock !

My pleasure! 😄


Align the Set Notification button

The button is not getting aligned in the control bar of the youtube video player.
Using button -> svg, so will need to check if the margin or padding can be adjusted somehow.
Remember that the regular controls on the player uses the use and path elements.

Need to align the button with all other buttons on control bar. All buttons are off at the moment.

The buttons are aligned now.


Marking algebra

It would be nice to have a complete algebra on markings (type PTMarking) with + - >=
in order to be able to write:
var m : PTMarking = [...]
var mm : PTMarking = [...]
let mmm= m+ mm
let m4= mmm-m
m>=mm

Implemented in #6.


Paket 5.212.0 doesn't extract packages copied from the dotnet Nuget fallback folder

Description
When a Nuget package is referenced which is available from C:\Program Files\dotnet\sdk\NuGetFallbackFolder, only the .nupkg file is copied to ~/.nuget/packages/<package>/<version> i.e. the package is not extracted.
Repro steps

Reference a version of a Nuget package which is available in the dotnet NuGetFallbackFolder

Run package restore

I've not created a repository or attached an archive for this issue, because which packages will show the issue depends on a user's own machine. For example, this paket.dependencies showed the issue on my machine:
source https://www.nuget.org/api/v2

nuget System.Composition 1.0.31

but it won't on a machine which already has that specific version of that package installed.
Expected behavior
The package should be copied from the Nuget fallback folder to the appropriate location in the user's Nuget packages folder and then extracted there.
Actual behavior
The package is copied to the appropriate location in the user's Nuget packages folder as expected, but is not extracted.
Known workarounds
Pin the version of Paket used to less than 5.212.0 e.g. add this to the top of the paket.dependencies file:
version 5.211.0

can you please retry with 5.213.0 which will be available in about 5min? thanks!

Yes, that fixed it - thanks!


Can't draw the generated gif onto canvas as expect

Only first frame is shown, does canvas not support drawing gif ? Or, there's a bug within the generated gif ? Thanks very much.

Not supported by canvas

For a while, chrome would draw GIFs animated on the canvas, but the spec says to only draw the first frame. If you need to draw animated GIFs on the canvas, you can use a library that will parse GIFs. If you just want to playback the frames such as to preview the GIF, you can handle that yourself by keeping ImageData objects or canvases.

@1j01 Thanks for your reply.I saw a library called fabricjs that draw animated images on canvas, but with using sprites, it's unconvince. I think it's painful to draw aniamated image onto canvas now.

@Julyyq Have you tried https://github.com/buzzfeed/libgif-js? Looks like you should be able to set auto_play and it should animate a GIF onto a canvas you give it.

@1j01 libgif tries to draw gif into canvas which is inside in a iframe, that is, I can't specific the canvas that I wanna draw in. And, Its propose is to make gif rubbable and plays like a video. Anyway, the library tells me that gif could be draw into canvas with some work-around.

@Julyyq Yeah, that library doesn't really live up to its name. Maybe readwrite-gif instead? Both libraries it uses have both encoders and decoders, but neither jsgif nor omggif have documentation, so I guess readwrite-gif is an attempt at giving some kind of API to them, although I'm not sure why it uses both...


Workaround for making RDKit can be installed by pip directly

As title, I am trying to make RDKit installable by pip directly, which is the recommend installation for a python package. To do this, we need to add a setup.py, a MANIFEST.in, and probably need to put more settings into setup.cfg.
The main challenge of this is that RDKit is natively built by CMake, which is not directly supported by Python standard library. Therefore, we need to extend the build extension mechanism for CMake. There are two projects I found that use CMake as well: cmake_example and boost-python-cmake-mac. There are also other resources like stackoverflow question and quora question.
I put my current work here: https://github.com/hsiaoyi0504/rdkit/tree/d442394c45fb05d4f989c7f031ab67213ad1536d. However, I failed to finish. In principle, that is not so hard to extend the build extension process. We just need to call some CMake commands and put the result in build_temp directory. One observation I found is that after running
mkdir build
cd build
cmake ..
cmake --build  # or make

In cmake_example, it will produce a file cmake_example.cpython-36m-darwin.so, but for our RDkit, it doesn't have a file like that.
@greglandrum Do you know how to produce such a file ? Where should I edit the CMakeLists.txt?

RDKit Version: based on Release_2017_09_3.
Platform: MacOS, but should be the same on Linux.

This is a brave thing to attempt, and if it works it would be great, but the requirements for an RDKit install are pretty tricky: you need to install all of the .py files, the shared libraries for the extension modules (I believe that these are the equivalent of the cmake_example.cpython-36m-darwin.so file), and the shared libraries that those extension modules need.

@greglandrum Although the installation is tricky as you described, I think it should be possible. I will keep working on this. However, based on my observation, I have a question. Does the build/rdkit folder is the only final product we need to use rdkit ?  I mean, just add this folder into python search path will make something like from rdkit import Chem work, right?

Have you looked at bdist_wheel?  It is designed to make pip+cmake coexist
somewhat gracefully:
https://blog.kitware.com/cmake-python-wheels/
On Mon, Apr 9, 2018 at 8:45 AM, hsiao yi<EMAIL_ADDRESS>wrote:

@greglandrum https://github.com/greglandrum Although the installation
is tricky as you described, I think it should be possible. I will keep
working on this. However, based on my observation, I have a question. Does
the build/rdkit folder is the only final product we need to use rdkit ? I
mean, just add this folder into python search path will make something like from
rdkit import Chem work, right?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/rdkit/rdkit/issues/1812#issuecomment-379739055, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AJbioESM9Tr5jpBvLc51WpsK84vQrL2Kks5tm1fugaJpZM4TMD8-
.

@bp-kelley Hmm... somewhat. Based on my understanding, bdist_wheel is about building a package accessible from pypi or other place. That will be the second step of this. For me, I think initial step for this is to make rdkit can be installed by pip using pip install . and consider make it a distribution later. The other thing is that the link you mentioned above is about you can install cmake through pip install cmake and it’s not for building the extension during the installation.

@hsiaoyi0504 unfortunately the build/rdkit folder does not contain everything you need. It will be missing the python files from $RDBASE/rdkit, the shared libraries that the python extensions also need, and the data files. The easiest way to figure out what should be installed is to do a cmake build that is configured with -DCMAKE_INSTALL_PREFIX=/some/directory/you/can/find and then look at make install puts in that directory. (I think I got that incantation right, I don't have an easy way to test it at the moment).

@greglandrum By using -DCMAKE_INSTALL_PREFIX=/some/directory/you/can/find, I now can see all stuffs installed by make install, but I am somewhat get confused about the directories. As I can see, there are three directory
.
├── include
├── lib
└── share
3 directories, 0 files

The python package (rdkit folder) is located at lib/python3.6/site-packages, and there are many .dylib and .a files there inside the lib. If we only consider using python API, can we just use the files in lib/python3.6/site-packages ?
Similarly, how about the include and share directory. My assumption is that the files in include are .h header files. It's for application using C++ API and we don't need to install that if we only use Python API. At the same time, I have no idea about share directory.

It seems that I need to include the dylib in lib, I will get an error when I directly execute python under ·lib/python3.6/site-packages`.

Yeah, you definitely need the stuff that's in lib. Those are the shared libraries that the python bindings require.
You're right that include is almost certainly not necessary.
share includes data, parameter files, documentation, the Contrib folder, etc:
glandrum@Otter:/scratch/RDKit_git/builds$ ls ~/anaconda5/envs/py36_rdkit/share/RDKit/
Contrib  Data  Docs  license.txt  Projects  README

I think it's important to include this stuff, particularly the Data directory.

Very interesting endeavor.
pip install cmake

Does install cmake in ~/.local/bin on Linux.
It would quite useful if rdkit is also installable via pip.
Since then pure python scripts which are pip-enabled would be able
to automatically install rdkit as a dependency if it is missing.

Intuitively, just changing the install prefix to ~/.local should do the job.
Maybe, a first step is to be able to do a source install of rdkit in there and
check that it is working from a python interpreter.
Then, we can have a look at how to create the complete pip package.

Can this issue be assigned to me?

Apparently you need to listed as a collaborator on the project (or have submitted the issue) for me to assign it to you. I just sent you an invite to be a collaborator

No, but now I can assign you. :-)

@UnixJunkie I think the hardest part of this issue is about the C part. It seems to me that *.so or *.a  are not easily to be installed into a virtual environment.

@hsiaoyi0504 @UnixJunkie Hi, I am also very interested interested in being able to install rdkit via pip because at the moment it appears I will be unable to use the GoogleCloud ML Engine unless I can do so. Do you mind filling me in on the current status/progress of the task and how, if at all, I would able to help?

In this thread there are pointers to useful resources.
I guess the status/progress is that someone has to start from scratch since there is no pull request
associated with this issue.

@hsiaoyi0504 Would you happen to have any code you've written that you think would be useful to make public here?

@greglandrum Although I haven't touched that for a while, but I found in my note, I would like to know if is it possible to build the dynamic libraries inside the python package directory ? That means, after running some cmake commands.
We can have a $GIT_REPO_ROOT_DIRCTORY/rdkit that can be moved everywhere and works without any external dependencies (i.e. any other stuffs in /usr/lib or other similar things). That means, if I have a project with following file directories tree:
project ---- rdkit
               |-- main.py

And in main.py:,
from rdkit import Chem
# do whatever rdkit can do

It seems to me that there is a -DRDK_INSTALL_INTREE=ON option, but I didn't make it work before.

Hi, is it still plan to have rdkit in pip ?

We need an installer for pip3 also (for python3).

alright, so did anyone manage to get this thing into the real world by making it pip installable yet?

There is some work in progress there:
https://github.com/rdkit/rdkit/pull/2690

Can this issue be renamed to "pip installer for rdkit"?
Also, is there any progress on this front?

Hey!
So may be it's possible to use scikit-build to solve this problem?

@churnikov : thanks for pointing that out. It's an interesting possibility. We would still have to figure out how to handle the boost library dependencies via pip.

@greglandrum maybe this tool could be used instead of python boost?
https://pybind11.readthedocs.io/en/stable/intro.html

Theoretically, but that would require rewriting thousands of lines of code.

Has anyone looked into Conda-Press as a way to auto-generate an RDKit wheel from the Conda package?

I have and it’s ugly.  Almost too ugly. I need to try it or more Linux systems.

conda press might not be a good general solution, but if we can use it to get a package that works with the GCP VMs behind colab it might be really useful to speed up installs there...

@bp-kelly Does it work though, and could that be a short-term solution?

I found a solution using the manylinux docker images. Please see https://github.com/kuelumbus/rdkit_platform_wheels. Python wheel packages are available for Python 3.7 and 3.8.

@kuelumbus This is great.  I had tried the package that turns condo packages into wheels but it brought along a lot of junk.
This is way better.

I found a solution using the manylinux docker images. Please see https://github.com/kuelumbus/rdkit_platform_wheels. Python wheel packages are available for Python 3.7 and 3.8.

It works for me. I hope it can be officially published to pypi, so that packages that depends on rdkit could directly add rdkit as a install requirement.

I’m happy to try this on as many Linux variants as I can :)

I have upload the wheels to pypi: https://pypi.org/project/rdkit-pypi/2020.9.5/
This should work now on Linux systems.
pip install rdkit-pypi

I can confirm that this approach works, at ProteinQure we've been testing a very similar approach internally: https://github.com/ProteinQure/rdkit-wheels

Also, while the currently both @kuelumbus and mine repos only support Linux systems, I'm quite confident this work could be extended to support MacOS X and Windows platforms. If this looks like promising development to the maintainers (cc @greglandrum ), it could be contributed to the build process of RDkit itself.
@kuelumbus perhaps you'd want to join forces on this one?

@tbabej It would've been great if you could make it work on MasOS. We at Biocad use Macs for development and Ubuntu on servers, so for us it would be great to remove Conda from development setup.
Specifically, I really hate to mix coda and poetry, but we have to right now with rdkit.

https://github.com/joerick/cibuildwheel seems to be a promising solution to get it work for MacOS and Windows. I will give it a try.

Yep, it would be great if the pip installer also works on Mac.

I was able to build a Mac wheel for RDKit. Can somebody try it please? It is available at https://github.com/kuelumbus/rdkit_platform_wheels/actions/runs/712514749 in the artifact ZIP file.

Can somebody please check if the wheels at https://github.com/kuelumbus/rdkit_platform_wheels/actions/runs/790692407 (artifact.zip) work on Mac?

@kuelumbus Trying pip3 install artifact.zip installs a non-importable package UNKNOWN-0.0.0 on my Mac (original, not M1). No sign of rdkit package named as such.

@kuelumbus Trying pip3 install artifact.zip installs a non-importable package UNKNOWN-0.0.0 on my Mac (original, not M1). No sign of rdkit package named as such.

Did you unzip archive?
Installing wheel from zip archive worked for me

Ah, ok - my mistake: artifact.zip is a bundle of wheels:
Archive:  artifact.zip
  inflating: rdkit_pypi-2021.3.1-cp36-cp36m-macosx_10_9_x86_64.whl
  inflating: rdkit_pypi-2021.3.1-cp37-cp37m-macosx_10_9_x86_64.whl
  inflating: rdkit_pypi-2021.3.1-cp38-cp38-macosx_10_9_x86_64.whl
  inflating: rdkit_pypi-2021.3.1-cp39-cp39-macosx_10_9_x86_64.whl

I assumed it was a pip installable archive. Selecting an appropriate wheel seems to work fine.

Tried it on macOS and it seems to work. Thank you!
I'm not quite clear on how this is fixed now after so much discussion on how it would be difficult/impossible. What was the solution?

I didn't follow the discussion but I think platform wheels just recently became thing.

@kuelumbus : thanks for this!
I just quickly tried it out on my linux box and M1 Mac (using the intel build, doesn't look like there's a build for the M1 there yet) and everything seems to work.
I haven't followed the developments on the python packaging front, but it looks like they've found a workable solution to the shared library problem that was so problematic. That's really cool!
It would be nice if it were possible to complete the build matrix a bit and at least have builds for 64bit windows and apple silicon. Can I help out with that?

It seems there is still some problems with the linux wheels (did not try Mac, but I suspect it will be the same):

some internal constants don't have a correct value, for example : rdkit.RDConfig.RDDataDir is set at /tmp/pip-req-build-5c4y6o05/build/temp.linux-x86_64-3.9/rdkit_install/share/RDKit/Data while it should be the final installation directory I think.
This seems to be caused by some variables in RDPaths.py not properly set:RDCodeDir=os.path.join(r'/tmp/pip-req-build-5c4y6o05/build/temp.linux-x86_64-3.9/rdkit_install/lib/python3.9/site-packages','rdkit')
# not really hard-coded alternative RDCodeDir=os.path.dirname(__file__)
_share = os.path.join(r'/tmp/pip-req-build-5c4y6o05/build/temp.linux-x86_64-3.9/rdkit_install', r'share/RDKit')

Plus, those directories are missing in the installation.
as such, some files are not installed, for example, the oddt package is looking for a file named BaseFeatures.fdef, but it (nor I) can't find it anywhere in the installation.

@kuelumbus : thanks for this!
I just quickly tried it out on my linux box and M1 Mac (using the intel build, doesn't look like there's a build for the M1 there yet) and everything seems to work.

There is an option to cross-compile arm64/aarch64 wheels for MacOS but I think it will work for Python >= 3.9 only. I will enable arm64/aarch64 wheels for Linux and MacOS.

I haven't followed the developments on the python packaging front, but it looks like they've found a workable solution to the shared library problem that was so problematic. That's really cool!
It would be nice if it were possible to complete the build matrix a bit and at least have builds for 64bit windows and apple silicon. Can I help out with that?

I have never worked with Python on windows but I will give it a try. RDKit fails to build with Cairo 1.15 (available in the CentOS 7 repo). Do you know why? Also, can you check if the cmake build flags are correctly set at setup.py.
@ElricleNecro thanks for pointing this out.

It seems there is still some problems with the linux wheels (did not try Mac, but I suspect it will be the same):

some internal constants don't have a correct value, for example : rdkit.RDConfig.RDDataDir is set at /tmp/pip-req-build-5c4y6o05/build/temp.linux-x86_64-3.9/rdkit_install/share/RDKit/Data while it should be the final installation directory I think.
This seems to be caused by some variables in RDPaths.py not properly set:RDCodeDir=os.path.join(r'/tmp/pip-req-build-5c4y6o05/build/temp.linux-x86_64-3.9/rdkit_install/lib/python3.9/site-packages','rdkit')
# not really hard-coded alternative RDCodeDir=os.path.dirname(__file__)
_share = os.path.join(r'/tmp/pip-req-build-5c4y6o05/build/temp.linux-x86_64-3.9/rdkit_install', r'share/RDKit')

Plus, those directories are missing in the installation.

Looks like RDCodeDir is mostly used to run tests. It should be not critical to run RDKit. @greglandrum  Can you help?

as such, some files are not installed, for example, the oddt package is looking for a file named BaseFeatures.fdef, but it (nor I) can't find it anywhere in the installation.

rdkit/rdkit/Chem/Pharm2D/test_data/BaseFeatures.fdef & rdkit/rdkit/Chem/Pharm3D/test_data/BaseFeatures.fdef
are part of test directories which are not installed by default. @greglandrum Can you also clarify?

Ok. I see. I am not sure what's the best way to do this.
I don't think that we can modify python files of the wheels at install time. I wonder if the best solution would be to set
_share=os.path.dirname(__file__) in RDPaths.py. I can then copy the Data dir to the main tree and things should work?

I have pushed an arm64 rdkit wheel for MacOS to pypi. Can someone with a M1 Mac please test if the wheel works? You would need Python >= 3.9 and pip >= 20.3.

Seems to have problems:
(py39_pypi) Marder:~ glandrum$ python -c 'import rdkit'
Traceback (most recent call last):
  File "<string>", line 1, in <module>
  File "/Users/glandrum/miniforge3/envs/py39_pypi/lib/python3.9/site-packages/rdkit/__init__.py", line 2, in <module>
    from .rdBase import rdkitVersion as __version__
ImportError: dynamic module does not define module export function (PyInit_rdBase)

That's running on an M1 mac mini and installing in a fresh conda environment. Using the intel version I didn't have problems, so it's probably not the conda env that's causing this

Thanks for testing. Looks like the libs are missing.

I just want to say thanks so much for this. Saved me so much headache by making it pip installable.

Seems to have problems:
(py39_pypi) Marder:~ glandrum$ python -c 'import rdkit'
Traceback (most recent call last):
  File "<string>", line 1, in <module>
  File "/Users/glandrum/miniforge3/envs/py39_pypi/lib/python3.9/site-packages/rdkit/__init__.py", line 2, in <module>
    from .rdBase import rdkitVersion as __version__
ImportError: dynamic module does not define module export function (PyInit_rdBase)

That's running on an M1 mac mini and installing in a fresh conda environment. Using the intel version I didn't have problems, so it's probably not the conda env that's causing this

D'you have any ideas how to resolve this manually on an M1 Macbook? I've tried symbolic links, DYLD_LIBRARY_PATHS and install_name_tool but I keep getting the same error :/

Please use

Seems to have problems:
(py39_pypi) Marder:~ glandrum$ python -c 'import rdkit'
Traceback (most recent call last):
  File "<string>", line 1, in <module>
  File "/Users/glandrum/miniforge3/envs/py39_pypi/lib/python3.9/site-packages/rdkit/__init__.py", line 2, in <module>
    from .rdBase import rdkitVersion as __version__
ImportError: dynamic module does not define module export function (PyInit_rdBase)

That's running on an M1 mac mini and installing in a fresh conda environment. Using the intel version I didn't have problems, so it's probably not the conda env that's causing this

D'you have any ideas how to resolve this manually on an M1 Macbook? I've tried symbolic links, DYLD_LIBRARY_PATHS and install_name_tool but I keep getting the same error :/

Unfortunately, the compilation on arm64 M1 Mac is a headache. Until this gets better, please use the intel builds. I have also yanked all the arm64 builds on PyPi. You should actually not be able to install the arm64 builds if you're using pipi.

Seems to have problems:
(py39_pypi) Marder:~ glandrum$ python -c 'import rdkit'
Traceback (most recent call last):
  File "<string>", line 1, in <module>
  File "/Users/glandrum/miniforge3/envs/py39_pypi/lib/python3.9/site-packages/rdkit/__init__.py", line 2, in <module>
    from .rdBase import rdkitVersion as __version__
ImportError: dynamic module does not define module export function (PyInit_rdBase)

That's running on an M1 mac mini and installing in a fresh conda environment. Using the intel version I didn't have problems, so it's probably not the conda env that's causing this

D'you have any ideas how to resolve this manually on an M1 Macbook? I've tried symbolic links, DYLD_LIBRARY_PATHS and install_name_tool but I keep getting the same error :/

Unfortunately, the compilation on arm64 M1 Mac is a headache. Until this gets better, please use the intel builds. I have also yanked all the arm64 builds on PyPi. You should not be able to install the arm64 builds using pip.

Thanks for your reply. I've been able to install the latest version fine. But my issue has ben building an older custom rdkit from source via cmake.

Seems to have problems:
(py39_pypi) Marder:~ glandrum$ python -c 'import rdkit'
Traceback (most recent call last):
  File "<string>", line 1, in <module>
  File "/Users/glandrum/miniforge3/envs/py39_pypi/lib/python3.9/site-packages/rdkit/__init__.py", line 2, in <module>
    from .rdBase import rdkitVersion as __version__
ImportError: dynamic module does not define module export function (PyInit_rdBase)

That's running on an M1 mac mini and installing in a fresh conda environment. Using the intel version I didn't have problems, so it's probably not the conda env that's causing this

D'you have any ideas how to resolve this manually on an M1 Macbook? I've tried symbolic links, DYLD_LIBRARY_PATHS and install_name_tool but I keep getting the same error :/

Unfortunately, the compilation on arm64 M1 Mac is a headache. Until this gets better, please use the intel builds. I have also yanked all the arm64 builds on PyPi. You should not be able to install the arm64 builds using pip.

Thanks for your reply. I've been able to install the latest version fine. But my issue has ben building an older custom rdkit from source via cmake.

What version do you need? I can try to compile it and put on pypi.

Seems to have problems:
(py39_pypi) Marder:~ glandrum$ python -c 'import rdkit'
Traceback (most recent call last):
  File "<string>", line 1, in <module>
  File "/Users/glandrum/miniforge3/envs/py39_pypi/lib/python3.9/site-packages/rdkit/__init__.py", line 2, in <module>
    from .rdBase import rdkitVersion as __version__
ImportError: dynamic module does not define module export function (PyInit_rdBase)

That's running on an M1 mac mini and installing in a fresh conda environment. Using the intel version I didn't have problems, so it's probably not the conda env that's causing this

D'you have any ideas how to resolve this manually on an M1 Macbook? I've tried symbolic links, DYLD_LIBRARY_PATHS and install_name_tool but I keep getting the same error :/

Unfortunately, the compilation on arm64 M1 Mac is a headache. Until this gets better, please use the intel builds. I have also yanked all the arm64 builds on PyPi. You should not be able to install the arm64 builds using pip.

Thanks for your reply. I've been able to install the latest version fine. But my issue has ben building an older custom rdkit from source via cmake.

Which version do you need? I can try to compile it and put it on pypi.

I would really appreciate that. I'm trying to use a modified version for compatibility with a toolkit :
https://github.com/connorcoley/rdkit/tree/master/rdkit

@kuelumbus thanks a lot for your effort on making RDKit available on PyPi.
Following the conversation here between you and @greglandrum , is it established that kuelumbus/rdkit-pypi is a fully functional version of RDKit installable by pip? If not, is it possible to create some small documentation on what does not work?

@j3mdamas I believe the wheels are fully functional (at least I don't know of any issue). In case you find something not working, please open an issue. I would try to fix issues rather than documenting.

The wheels are missing quite a few data files and don’t have the full cohort of descriptors, they are missing about half.

@bp-kelley Can you please point out the missing files?

OK, that is fair, @kuelumbus.
I phrase it differently then: is there a possibility of kuelumbus/rdkit-pypi to be included as part of the official releases of RDKit?

What I am doing right now is to compile a new RDKit version and push to PyPi for each new version tag in the RDKit repo, as you can see at https://pypi.org/project/rdkit-pypi/#history.  So, in that sense, you have a PyPi version for each RDKit release.

The wheels are missing quite a few data files and don’t have the full cohort of descriptors, they are missing about half.

I don't think this is the case any more. I believe it's now complete.

I phrase it differently then: is there a possibility of kuelumbus/rdkit-pypi to be included as part of the official releases of RDKit?

What would that mean for you? At the moment the only "official releases" that the core team does are the source releases. The various binary releases, like the ones on conda-forge or pypi, are done by other volunteers.

@greglandrum I thought the conda releases were also done by the core team. I was just looking for more core support around the PyPi releases. I think your answer clarifies it though, thanks!

@Greg Landrum @.***> I'll double check the descriptors,
this was true a few weeks ago at least.
On Tue, Dec 14, 2021 at 6:03 AM João M. Damas @.***>
wrote:

@greglandrum https://github.com/greglandrum I thought the conda
releases were also done by the core team. I was just looking for more core
support around the PyPi releases. I think your answer clarifies it though,
thanks!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/rdkit/rdkit/issues/1812#issuecomment-993426556, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/ACLOFICRNTAANW5OZCOXUU3UQ4QBZANCNFSM4EZQH47A
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

Greg and I looked at the descriptors, and it does look like the latest
release solves the Data problem.  Congrats on that.
On Tue, Dec 14, 2021 at 8:27 AM Brian Kelley @.***> wrote:

@Greg Landrum @.***> I'll double check the descriptors,
this was true a few weeks ago at least.
On Tue, Dec 14, 2021 at 6:03 AM João M. Damas @.***>
wrote:

@greglandrum https://github.com/greglandrum I thought the conda
releases were also done by the core team. I was just looking for more core
support around the PyPi releases. I think your answer clarifies it though,
thanks!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/rdkit/rdkit/issues/1812#issuecomment-993426556, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/ACLOFICRNTAANW5OZCOXUU3UQ4QBZANCNFSM4EZQH47A
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

I phrase it differently then: is there a possibility of kuelumbus/rdkit-pypi to be included as part of the official releases of RDKit?

What would that mean for you? At the moment the only "official releases" that the core team does are the source releases. The various binary releases, like the ones on conda-forge or pypi, are done by other volunteers.

Are there plans to update https://www.rdkit.org/docs/Install.html to include rdkit-pypi, or are there still reasons to prefer conda that should be articulated here?

Are there plans to update https://www.rdkit.org/docs/Install.html to include rdkit-pypi, or are there still reasons to prefer conda that should be articulated here?

Pull request are welcome. ;-)


AppContent should retain 1 1 100% to provide layout for the footer.

Expected Behavior
AppContent should retain 1 1 100% to provide layout for the footer.  Appcontent is set to 100% to  target the bottom of the browser area when the content of the app wouldn’t normally reach it, e.g. to provide layout for the footer.
Actual Behavior
AppContent is set to 1 1 auto
Supporting Images or Videos
Specifications

Version:
Platform:
Subsystem:

1 1 100% is not import per @shanberg .  Closing the issue.


Workflow and developer count statistics not shown correctly

Workflow and developer counts are showing up as 0 on the splash page and the stats page. Probably an issue with the periodic task that computes aggregate stats.

Addressed by 4d0343d


Bb more complex blackout dates

Description
This is an additional small change toward the goal of taking fields beyond dates into consideration when saying if a blackout date applies to a move or not. This PR changes one argument for all blackout date querying functions from PickupDate (time.Time) to a ShipmentWithOffer object.
Verification Steps

[ ] All tests pass.
[ ] The requirements listed in Querying the Database Safely have been satisfied.

References

Pivotal story for this change

Nice! Thanks, @kilbergr.


proposal: Go2: introduce check keyword for errors on LHS of assignment

Would you consider yourself a novice, intermediate, or experienced Go programmer?
Experienced

What other languages do you have experience with?
C, C++, Assembly, Java, Python, Javascript, SML, Rust, Racket, Shell, SQL, LATEX.

Would this change make Go easier or harder to learn, and why?
It would make Go harder to learn, since it is one more choice the user must make before handling an error. Hopefully though, it becomes the default.

Has this idea, or one like it, been proposed before?
The proposal that comes closest to this idea is #42318. Other similar issues are #32500 #32601 #32884 #33150.

If so, how does this proposal differ?
1. #42318 uses a special character to mark the variable, whereas this proposal uses a new keyword.
2. #42318 returns the zero value for unannotated variables, whereas this proposal relies on named return values to do the heavy lifting.
3. #42318 allows substituting a handler function for the annotation, whereas this proposal makes use of defer for handlers.
4. #32500 is far too broad in that it suggests panics, returns, and special operators, but doesn't specify evaluation order.
5. #32884, #32601, and #33150 do not assign an identifier to the variable on the left-hand side, and don't specify how that variable is mapped to the return value, leaving us to assume that it relies on some convention around the last return value being an error. They also use an operator instead of a keyword, which obscures the early exit that can happen.
6. #33150 introduces a separate mechanism for wrapping an error.

Who does this proposal help, and why?
1. It helps authors of Go source code avoid three extra lines of code in the common case where they early exit on an error.
2. It helps readers of Go source code follow a function's core logic more easily, by collapsing the gap between two successive lines of logic.
3. Preserves the imperative style of Go source code. Unlike the try proposal, this proposal can't be abused to favor function composition.

What is the proposed change?
1. A new keyword check is introduced.
2. The keyword is only valid on the left-hand-side of an assignment or short variable declaration.
3. The keyword is only valid if it precedes an identifier that refers to a variable of type error.
4. The keyword can only be used in a function that has named return values.
5. In all other cases, check is a normal identifier. This keeps the change backwards-compatible to Go1.
6. Given a function like this:
func foo() (v1 T, err error) {
  x, check err := f()
}

is equivalent to the following code:
func foo() (v1 T, err error) {
  x, err := f()
  if err != nil {
    return v1, err
  }
}

Is this change backward compatible?
Yes

Show example code before and after the change.
Before
func printSum(a, b string) error {
	x, err := strconv.Atoi(a)
	if err != nil {
		return err
	}
	y, err := strconv.Atoi(b)
	if err != nil {
		return err
	}
	fmt.Println("result:", x + y)
	return nil
}

After (normal return) https://play.golang.org/p/nYugCFk4o-Z
func printSum(a, b string) (err error) {
	x, check err := strconv.Atoi(a)
	y, check err := strconv.Atoi(b)
	fmt.Println("result:", x + y)
	return nil
}

After (return with additional context) https://play.golang.org/p/zaTO6KjUXmF
func printSum(a, b string) (err error) {
	defer func() {
		if err != nil {
			err = fmt.Errorf("printSum: %w", err)
		}
	}()
	x, check err := strconv.Atoi(a)
	y, check err := strconv.Atoi(b)
	fmt.Println("result:", x + y)
	return nil
}

After (with a hypothetical error wrapper) https://play.golang.org/p/LQCn_Nj_I4C
func printSum(a, b string) (err error) {
	defer errors.Wrap(&err, "printSum")
	x, check err := strconv.Atoi(a)
	y, check err := strconv.Atoi(b)
	fmt.Println("result:", x + y)
	return nil
}

What is the cost of this proposal? (Every language change has a cost).

How many tools (such as vet, gopls, gofmt, goimports, etc.) would be affected?
As long as they upgrade to the latest libraries for parsing/type-checking packages, most of their static analyses should be unaffected. I'm unsure if there are outliers that check for weird properties on the LHS of an assignment, or if their error handling analyses that would trigger false positives because they expect if err != nil.
What is the compile time cost?
Time-complexity-wise the same. Can be implemented entirely in the frontend.
What is the run time cost?
Nothing

Can you describe a possible implementation?
I have a partial implementation on https://github.com/smasher164/check-go. I haven't had time to finish changes to the typechecker, so all it does right now is tokenize and parse the check keyword on the LHS of an assignment.

Does this affect error handling?
Yes

Why are named return values necessary?
When annotating the error result, the natural question to ask is "what happens when the error is non-nil?"

Some proposals argue that we return zero values for everything except the error value, but that forces us to adopt the convention that there is only a single error value returned as the last. If we went this route, then named return values aren't necessary, but we would be enforcing a convention.
We could do a naked return, and was my original plan. But the assignment would fail in a nested scope where the err variable is shadowed. If we went this route, then named return values are still necessary, since they permit the naked return.
We could return the values of the currently shadowed names for the named return values. This permits the user to redeclare err in a new scope. This is the approach I preferred, since it provides the most flexibility around where the assignment can happen.

Edit:

I have relaxed the requirement on excluding underscores in named return values. We can simply return the zero value of that type when there's an underscore.
Referenced other similar issues.
Added playground links for the "After" examples.
Explain why named return values are necessary.

Don't mind checking error in the next line (for clarity and control). But would prefer if it was lesser words/lines though. Something like below, where the function returns automatically with first error value it sees in the error list (along with default values of other return types).
func g() (int, error) {
    e1, e2, v := f()
    returnOnError(e1, e2)
    return v
}

Considering returnOnError is a built-in function here.

Don't mind checking error in the next line (for clarity and control). But would prefer if it was lesser words/lines though. Something like below, where the function returns automatically with first error value it sees in the error list (along with default values of other return types).
func g() (int, error) {
    e1, e2, v := f()
    returnOnError(e1, e2)
    return v, nil
}

Considering returnOnError is a built-in function here.

@gptankit Feel free to draft a separate proposal for that idea, but it has been brought up before: https://github.com/golang/go/issues/33233
Defining built-in function carries the risks that it looks like a regular function call. Inspecting code that redefines returnOnError would make it unclear that it's changing control flow.
One of the consequences behind this proposal is that an editor can highlight the check keyword differently, signifying during an assignment that something different is going on.

This seems similar to #32500 #32601 #32884 #33150.

I don't understand why this requires named result variables.
Purely as a matter of style, the new use of check seems to emphasize the error result, which tends to obscure the more important non-error code.

Hopefully the golang team will consider for an automatic error check as in rust because
if err = call() {
return
}

is about 15% of my code
In a source code I am developing we have:
if err = ...  583 occurrences
if err := ... 176 occurances
multiplied by 3 lines of code it means 2277 LOC just to treat the errors with the same exact error handling pattern.
The entire source code is 16095 LOC. The error handling is 14.14%

@ibudisteanu This has been discussed at great length elsewhere.  A good starting point is #40432.  Let's keep discussion on this issue focused on this specific proposal.  Thanks.

@ianlancetaylor

This seems similar to #32500 #32601 #32884 #33150.

I can update my proposal to mention these. However,

#32500 is far too broad in that it suggests panics, returns, and special operators, but doesn't specify evaluation order.
#32884, #32601, and #33150 do not assign an identifier to the variable on the left-hand side, and don't specify how that variable is mapped to the return value, leaving us to assume that it relies on some convention around the last return value being an error. They also use an operator instead of a keyword, which obscures the early exit that can happen.
#33150 introduces a separate mechanism for wrapping an error.

I don't understand why this requires named result variables.
Purely as a matter of style, the new use of check seems to emphasize the error result, which tends to obscure the more important non-error code.

I should have explained this more in the original proposal, but when annotating the error result, the natural question to ask is "what happens when the error is non-nil?"

Some proposals argue that we return zero values for everything except the error value, but that forces us to adopt the convention that there is only a single error value returned as the last. If we went this route, then named return values aren't necessary, but we would be enforcing a convention.
We could do a naked return, and was my original plan. But the assignment would fail in a nested scope where the err variable is shadowed. If we went this route, then named return values are still necessary, since they permit the naked return.
We could return the values of the currently shadowed names for the named return values. This permits the user to redeclare err in a new scope. This is the approach I preferred, since it provides the most flexibility around where the assignment can happen.

Purely as a matter of style, the new use of check seems to emphasize the error result, which tends to obscure the more important non-error code.

if you look at the code:
func printSum(a, b string) error {
	x, err := strconv.Atoi(a)
	if err != nil {
		return err
	}
	y, err := strconv.Atoi(b)
	if err != nil {
		return err
	}
	fmt.Println("result:", x + y)
	return nil
}

the error handling code tends to obscure the more important non-error code.

better then error-handling
expr? // return if err

@qingtao One of the goals of this proposal is to make it more obvious to the reader that there are changes to control flow. This is why I chose a keyword over an operator. If you have an argument for using a ? operator, please file separate proposal.

make it more obvious to the reader
@smasher164 sorry, add extra keywords check vs? The purpose is the same. Not much help for reading.

@qingtao Clearly there is a subjective element to this. If you feel that strongly about it, please file a separate proposal.
That being said, on one hand @ianlancetaylor has stated that

check seems to emphasize the error result

while you state that ? and check have the same level of readability. This is something that I presume will be decided through this review process.

A keyword takes up more space.
It can be syntactically highlighted as a keyword in an editor.
It is consistent with the other mechanisms of altering control flow in Go programs, those being return and panic, both of which use an identifier.

Therefore, I would not argue that a keyword and ? are the same.

Something nice about Go is that general errors are simply values, the language doesn't give them any special treatment. This feature would contradict that idea. If we are to solve error handling, I would like it to be a solution that doesn't give errors special treatment. I'm alright with this solution, though.

the language doesn't give them any special treatment.

It kind of does though. The error interface is a universal-scope lower-cased exported type.

the language doesn't give them any special treatment.

It kind of does though. The error interface is a universal-scope lower-cased exported type.

Right, when I say “special treatment” I mean “behaves differently from other values”. Such as in Java with being able to throw Throwables and automatically unfurl the stack, or (not quite as drastically) Swift where errors have a special “slot” for functions to return an error.
Currently, the Go spec does not have any “special treatment” for errors besides providing a universal interface for them. Using this interface is entirely optional, and the language itself doesn’t “encourage” its use in any way (ie special language features which only work on the builtin error interface). I would like it to stay that way if possible. The standard library encourages its use, which (in my opinion) is good.

@deanveloper

the language doesn't give them any special treatment. This feature would contradict that idea.

I believe most of the error handling proposals fall into this category, so this flaw is not unique to this proposal.

I would like it to be a solution that doesn't give errors special treatment

There are generalizations of this proposal that could be applied to non-error values, but I want to keep this narrow in scope. For example, check could be made to work with any interface or even nillable type.
However, I think even if errors were given special treatment, this is an example of a language evolving with the needs of users. Rather than introducing a type-level feature, we address the syntactic issue with a special form of assignment.
I suspect some might wonder how this proposal would interact with generics, where functions may start returning Result[T], defined as
type Result[T any] interface {
    T | error
}

I believe check can be extended when that time comes to apply to Result values as well, as a form of destructuring assignment. But we should cross that bridge when we get to it.

I believe most of the error handling proposals fall into this category, so this flaw is not unique to this proposal.

Yeah, pretty much all of them do. Not quite all though, however the ones that don't aren't very elegant... Not sure how possible it would be to do successfully.

There are generalizations of this proposal that could be applied to non-error values, but I want to keep this narrow in scope. For example, check could be made to work with any interface or even nillable type.

I think it would be quite strange (at least with the spelling check) for this to apply outside of errors. I'm not trying to say it should by any means. I just think that a "perfect" feature wouldn't treat errors as special values. Go doesn't need to shoot for perfect, though.

I believe check can be extended when that time comes to apply to Result values as well, as a form of destructuring assignment. But we should cross that bridge when we get to it.

This would be really cool provided that some kind of Result would end up being used. However a benefit of a system which doesn't treat errors specifically would work with Results as well

I almost always wrap my errors with a short message. In the example above I would have
func printSum(a, b string) error {
	x, err := strconv.Atoi(a)
	if err != nil {
		return errors.Wrap(err, "parse a")
	}

	y, err := strconv.Atoi(b)
	if err != nil {
		return errors.Wrap(err, "parse b")
	}

	fmt.Println("result:", x + y)

	return nil
}

check keyword looses that option. So I would have to drop my nice error descriptions or I wouldn't be able to use that proposal.
I don't also see any problem with these ifs. With empty lines it looks pretty clear what's happening here.

@nikandfor
This proposal isn't meant to replace if err != nil in every context, but in most usages.
That being said, typically the context associated with a returned error is scoped at the function level, and not at each return. In the example you gave above, parse a and parse b provide different context for each parameter name. So while this would be a place where if err != nil makes sense, I question the value gained from referring to the parameter name in the error message here. Why isn't something like parse: strconv.Atoi: parsing "asdf": invalid syntax good enough?

Would the check return the err unaltered, or would it wrap the error with information about where the error occurred?

@leighmcculloch
check returns the err unaltered, so location information is lost. However, because deferred functions can modify return values, you can still add context (just not at the granularity of which line the error came from).

It occurs to me that if something like check is to be added it must handle what for many is the most common case of error handling, where the error is wrapped and appropriately annotated. How to do that though is unclear to me.
Maybe something like the below, or that achieves the same effect as the below, but better because this seems not great:
x, check("annotation %s: %w", someInput, err) := f()

it must handle what for many is the most common case

I don't know that it's true that adding context to every return is the most common case of error handling. I think if per-return context is needed, one would want to draw attention to it, and the two extra lines of control flow serve that purpose.

Maybe something like the below

https://github.com/golang/go/issues/33150 and https://github.com/golang/go/issues/32500 suggest something similar. They are not very specific on evaluation order, and overlap with the work that error wrappers like fmt.Errorf do. Can the wrapper be any arbitrary function? Does it need to accept an argument of type error (as the first argument)? I'd be interested to see variants of this proposal that allow one to wrap at the assignment.
Otherwise, writing the function so that in most cases, the context can be provided at the function-level would allow one to reuse mechanisms like defer for adding context.

As noted above, this is similar to previous proposals that were not accepted.  It adds a new keyword, so it is not backward compatible.  Based on that and the discussion above this is a likely decline.  Leaving open for four weeks for final comments.

Based on the upvote/downvote ratio, I can understand that this proposal is likely to be declined. However, for future reference, I'd like more clarity on why this language change is not considered backwards compatible. Although a new keyword is introduced, the keyword is not usable in a context where it is ambiguous. Typically, keywords are used in statements, and are not available on the left-hand side of an assignment. Moreover, there is no ambiguity with other identifiers on the left-hand side of an assignment, because currently it is not legal to have two identifiers next to each other on the left-hand side that are only separated by whitespace.

By definition, a new keyword is not backward compatible.  As the language spec says, a keyword may not be used as an identifier.
Reading more closely, I see that although you say that check is a keyword, you mean something else: it is an identifier that has a special meaning in certain circumstances.  Sorry for missing that point.
There isn't anything like that in Go today.  In Go identifiers are always defined, or not, in a given scope.  The approach you describe raises a different kind of concern: identifiers that only sometimes have a special meaning can be confusing for programmers, because minor changes can have surprising repercussions.

identifiers that only sometimes have a special meaning can be confusing for programmers, because minor changes can have surprising repercussions

Understandable. I can imagine it being confusing for a programmer to see that
x, check err := foo()

and
x, check := foo()

have different semantics, although an editor highlighting check as a keyword would help. I will add this to the list of costs in the proposal text.

No change in consensus.


[Missing SNMP Polling Profile] Juniper qfx5110-48s-4c Ethernet Switch

Device Vendor: Juniper
Device Model: qfx5110-48s-4c Ethernet Switch
System Object Identifier (SysOID): .<IP_ADDRESS>.4.1.26<IP_ADDRESS>.4.82.17
List of critical metrics that you expect in the profile (does not need to be all-inclusive, just a general idea of your expectations):

Double check Rx/Tx/etc utilization OIDs match between profile and device.

If there is a New Relic technical support case related to this request, please provide the case number: 00075880
Screenshot showing the drops in some common metrics.

The profile is correct for this device, the gaps you are seeing are not related to anything in the profile or the data would never show up at all.  I'll discuss your ticket with the the support engineer, but closing out this issue as this is not related to a profile change.


RunOn.. commands - Propagate errors in restart configurations

The RunOn{Init,Ready, etc} commands call back with a generic 'exited with code 0' message if the command is specified with its relevant 'Restart' option set to 'yes'. eg
runOnInit command exited: command exited with code 0
This PR allows underlying err result to actually be seen in logs, eg
runOnInit command exited: exec: "ffmpeg": executable file not found in %PATH%

i applied gofmt and merged, thanks!


Bug when displaying notifications on Login screen

The notification text is barely visible since it almost shares the same colour with the background. The text should be white or smth.

Iiiieh, @MaximilianHausen fix please 🐛🐛

Fixed in 434cc0054b3cee5b6f9f2682be3ddbcef3b85591


Remove badge when notification count is zero

🐞 Bug Report
This should be an easy one. when the count of notifications is zero, don't show a red badge in the notification button.

Hi, can you please assign this to my name?

@Badrri-Narayanan you got it!
let me know if you need help getting up and running, the deployment documentation is slightly out of date (i'll fix that now).
The easiest way is to use the docker-compose command
$ docker-compose --env-file configs/.env.dev up --build

@Badrri-Narayanan give me 5 minutes and I'll get on this

@Badrri-Narayanan I've updated the docs on setting up the client locally. There's 2 environment variables to set
After that, the mock service worker should be initiated when REACT_APP_HT_ENV environment variable is set to TEST in the, and you should be able to log in with username testuser1 and password password1

I'm going to look into why the docker-compose file is not working, I have a theory.

@Badrri-Narayanan thank you so much for finding this issue with the docker-compose, I've found the problem and will be fixing this today.


ShowCaption still not working

I would actually want to reopen #3495 as this issues exist also in BC, which at that time I could not verify. As you can see in the screenshot (taken in BC15) the caption SeminarDateName1 should not be shown as it is defind as:
group(ThisPeriod)
{
    Caption = 'This Period';
    field(SeminarDateName1; SeminarDateName[1])
    {
        ApplicationArea = Advanced;
        ShowCaption = false;
    }

Hi @lvanvugt, thank you for reporting the issue. Could you please provide the BC/AL version and the source code/project demonstrating the issue. It will significantly help us reproduce the bug. Thank you.

Could you please provide the BC/AL version

So far as I have seen it's on any version. As reported #3495 it was there on NAV 2018 (with it's AL extension on VSCode) and is still there on recent BC 15 with AL extension for VSCode from the marketplace.

Could you please provide the ... source code/project demonstrating the issue.

AL Solution Development.zip
Find attached the project.

Hi @lvanvugt, I tried the code attached, it seems the issue is not reproducible anymore. Could you try it with the latest daily build.
ALProject53.zip

Could you try it with the latest daily build.

Do you mean BC17 insider?

@lvanvugt, yes try that please, it might be already fixed there. Let us know if the issue is still there, thanks.

@AndreyKorepanov, trying now to test it my VSCode deployment, with a report I would like to verify this on, crashes. I know this is not the topic here, but I ned to get it fixed to allow me to test.
What is the case?

I have deployed a BC17 insider container using image:

$bcdockerimage = 'bcinsider.azurecr.io/bcsandbox-master:base'

I have installe the BC17 AL Language extension form the docker folder
I have donwloaded the symbols an build the .app (so that's working fine)
Now deploying with F5 I get a whole list of errors (being actually due to 5 times the same attempt):

Unhandled exception. System.AggregateException: One or more errors occurred. (Could not load file or assembly 'Newtonsoft.Json, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=30ad4fe6b2a6aeed'. The located assembly's manifest definition does not match the assembly reference. (0x80131040))
 ---> System.IO.FileLoadException: Could not load file or assembly 'Newtonsoft.Json, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=30ad4fe6b2a6aeed'. The located assembly's manifest definition does not match the assembly reference. (0x80131040)
File name: 'Newtonsoft.Json, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=30ad4fe6b2a6aeed'
   at Microsoft.Dynamics.Nav.EditorServices.Protocol.MessageProtocol.MessageWriter..ctor(Stream outputStream, IMessageSerializer messageSerializer)
   at Microsoft.Dynamics.Nav.EditorServices.Protocol.Channel.StdioServerChannel.Initialize(IMessageSerializer messageSerializer) in D:\a\1\s\source\Prod\Microsoft.Dynamics.Nav.EditorServices.Protocol\Channel\StdioServerChannel.cs:line 27
   at Microsoft.Dynamics.Nav.EditorServices.Protocol.Channel.ChannelBase.Start(MessageProtocolType messageProtocolType, ProtocolEndpointCompletionSource completionSource, DiagnosticServiceOptions diagnosticServiceOptions) in D:\a\1\s\source\Prod\Microsoft.Dynamics.Nav.EditorServices.Protocol\Channel\ChannelBase.cs:line 44
   at Microsoft.Dynamics.Nav.EditorServices.Protocol.MessageProtocol.ProtocolEndpoint.Start(ChannelBase channel, MessageProtocolType messageProtocolType, DiagnosticServiceOptions diagnosticServiceOptions) in D:\a\1\s\source\Prod\Microsoft.Dynamics.Nav.EditorServices.Protocol\MessageProtocol\ProtocolEndpoint.cs:line 27

   --- End of inner exception stack trace ---
   at System.Threading.Tasks.Task.ThrowIfExceptional(Boolean includeTaskCanceledExceptions)
   at System.Threading.Tasks.Task.Wait(Int32 millisecondsTimeout, CancellationToken cancellationToken)
   at Prod.EditorServices.Host.Program.Main(String[] args) in D:\a\1\s\source\Prod\Microsoft.Dynamics.Nav.EditorServices.Host\Program.cs:line 156
[Info  - 09:19:36] Connection to server got closed. Server will restart.
Unhandled exception. System.AggregateException: One or more errors occurred. (Could not load file or assembly 'Newtonsoft.Json, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=30ad4fe6b2a6aeed'. The located assembly's manifest definition does not match the assembly reference. (0x80131040))
 ---> System.IO.FileLoadException: Could not load file or assembly 'Newtonsoft.Json, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=30ad4fe6b2a6aeed'. The located assembly's manifest definition does not match the assembly reference. (0x80131040)
File name: 'Newtonsoft.Json, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=30ad4fe6b2a6aeed'
   at Microsoft.Dynamics.Nav.EditorServices.Protocol.MessageProtocol.MessageWriter..ctor(Stream outputStream, IMessageSerializer messageSerializer)
   at Microsoft.Dynamics.Nav.EditorServices.Protocol.Channel.StdioServerChannel.Initialize(IMessageSerializer messageSerializer) in D:\a\1\s\source\Prod\Microsoft.Dynamics.Nav.EditorServices.Protocol\Channel\StdioServerChannel.cs:line 27
   at Microsoft.Dynamics.Nav.EditorServices.Protocol.Channel.ChannelBase.Start(MessageProtocolType messageProtocolType, ProtocolEndpointCompletionSource completionSource, DiagnosticServiceOptions diagnosticServiceOptions) in D:\a\1\s\source\Prod\Microsoft.Dynamics.Nav.EditorServices.Protocol\Channel\ChannelBase.cs:line 44
   at Microsoft.Dynamics.Nav.EditorServices.Protocol.MessageProtocol.ProtocolEndpoint.Start(ChannelBase channel, MessageProtocolType messageProtocolType, DiagnosticServiceOptions diagnosticServiceOptions) in D:\a\1\s\source\Prod\Microsoft.Dynamics.Nav.EditorServices.Protocol\MessageProtocol\ProtocolEndpoint.cs:line 27

   --- End of inner exception stack trace ---
   at System.Threading.Tasks.Task.ThrowIfExceptional(Boolean includeTaskCanceledExceptions)
   at System.Threading.Tasks.Task.Wait(Int32 millisecondsTimeout, CancellationToken cancellationToken)
   at Prod.EditorServices.Host.Program.Main(String[] args) in D:\a\1\s\source\Prod\Microsoft.Dynamics.Nav.EditorServices.Host\Program.cs:line 156
[Info  - 09:19:38] Connection to server got closed. Server will restart.
Unhandled exception. System.AggregateException: One or more errors occurred. (Could not load file or assembly 'Newtonsoft.Json, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=30ad4fe6b2a6aeed'. The located assembly's manifest definition does not match the assembly reference. (0x80131040))
 ---> System.IO.FileLoadException: Could not load file or assembly 'Newtonsoft.Json, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=30ad4fe6b2a6aeed'. The located assembly's manifest definition does not match the assembly reference. (0x80131040)
File name: 'Newtonsoft.Json, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=30ad4fe6b2a6aeed'
   at Microsoft.Dynamics.Nav.EditorServices.Protocol.MessageProtocol.MessageWriter..ctor(Stream outputStream, IMessageSerializer messageSerializer)
   at Microsoft.Dynamics.Nav.EditorServices.Protocol.Channel.StdioServerChannel.Initialize(IMessageSerializer messageSerializer) in D:\a\1\s\source\Prod\Microsoft.Dynamics.Nav.EditorServices.Protocol\Channel\StdioServerChannel.cs:line 27
   at Microsoft.Dynamics.Nav.EditorServices.Protocol.Channel.ChannelBase.Start(MessageProtocolType messageProtocolType, ProtocolEndpointCompletionSource completionSource, DiagnosticServiceOptions diagnosticServiceOptions) in D:\a\1\s\source\Prod\Microsoft.Dynamics.Nav.EditorServices.Protocol\Channel\ChannelBase.cs:line 44
   at Microsoft.Dynamics.Nav.EditorServices.Protocol.MessageProtocol.ProtocolEndpoint.Start(ChannelBase channel, MessageProtocolType messageProtocolType, DiagnosticServiceOptions diagnosticServiceOptions) in D:\a\1\s\source\Prod\Microsoft.Dynamics.Nav.EditorServices.Protocol\MessageProtocol\ProtocolEndpoint.cs:line 27

   --- End of inner exception stack trace ---
   at System.Threading.Tasks.Task.ThrowIfExceptional(Boolean includeTaskCanceledExceptions)
   at System.Threading.Tasks.Task.Wait(Int32 millisecondsTimeout, CancellationToken cancellationToken)
   at Prod.EditorServices.Host.Program.Main(String[] args) in D:\a\1\s\source\Prod\Microsoft.Dynamics.Nav.EditorServices.Host\Program.cs:line 156
[Info  - 09:19:38] Connection to server got closed. Server will restart.
Unhandled exception. System.AggregateException: One or more errors occurred. (Could not load file or assembly 'Newtonsoft.Json, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=30ad4fe6b2a6aeed'. The located assembly's manifest definition does not match the assembly reference. (0x80131040))
 ---> System.IO.FileLoadException: Could not load file or assembly 'Newtonsoft.Json, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=30ad4fe6b2a6aeed'. The located assembly's manifest definition does not match the assembly reference. (0x80131040)
File name: 'Newtonsoft.Json, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=30ad4fe6b2a6aeed'
   at Microsoft.Dynamics.Nav.EditorServices.Protocol.MessageProtocol.MessageWriter..ctor(Stream outputStream, IMessageSerializer messageSerializer)
   at Microsoft.Dynamics.Nav.EditorServices.Protocol.Channel.StdioServerChannel.Initialize(IMessageSerializer messageSerializer) in D:\a\1\s\source\Prod\Microsoft.Dynamics.Nav.EditorServices.Protocol\Channel\StdioServerChannel.cs:line 27
   at Microsoft.Dynamics.Nav.EditorServices.Protocol.Channel.ChannelBase.Start(MessageProtocolType messageProtocolType, ProtocolEndpointCompletionSource completionSource, DiagnosticServiceOptions diagnosticServiceOptions) in D:\a\1\s\source\Prod\Microsoft.Dynamics.Nav.EditorServices.Protocol\Channel\ChannelBase.cs:line 44
   at Microsoft.Dynamics.Nav.EditorServices.Protocol.MessageProtocol.ProtocolEndpoint.Start(ChannelBase channel, MessageProtocolType messageProtocolType, DiagnosticServiceOptions diagnosticServiceOptions) in D:\a\1\s\source\Prod\Microsoft.Dynamics.Nav.EditorServices.Protocol\MessageProtocol\ProtocolEndpoint.cs:line 27

   --- End of inner exception stack trace ---
   at System.Threading.Tasks.Task.ThrowIfExceptional(Boolean includeTaskCanceledExceptions)
   at System.Threading.Tasks.Task.Wait(Int32 millisecondsTimeout, CancellationToken cancellationToken)
   at Prod.EditorServices.Host.Program.Main(String[] args) in D:\a\1\s\source\Prod\Microsoft.Dynamics.Nav.EditorServices.Host\Program.cs:line 156
[Info  - 09:19:39] Connection to server got closed. Server will restart.
Unhandled exception. System.AggregateException: One or more errors occurred. (Could not load file or assembly 'Newtonsoft.Json, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=30ad4fe6b2a6aeed'. The located assembly's manifest definition does not match the assembly reference. (0x80131040))
 ---> System.IO.FileLoadException: Could not load file or assembly 'Newtonsoft.Json, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=30ad4fe6b2a6aeed'. The located assembly's manifest definition does not match the assembly reference. (0x80131040)
File name: 'Newtonsoft.Json, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=30ad4fe6b2a6aeed'
   at Microsoft.Dynamics.Nav.EditorServices.Protocol.MessageProtocol.MessageWriter..ctor(Stream outputStream, IMessageSerializer messageSerializer)
   at Microsoft.Dynamics.Nav.EditorServices.Protocol.Channel.StdioServerChannel.Initialize(IMessageSerializer messageSerializer) in D:\a\1\s\source\Prod\Microsoft.Dynamics.Nav.EditorServices.Protocol\Channel\StdioServerChannel.cs:line 27
   at Microsoft.Dynamics.Nav.EditorServices.Protocol.Channel.ChannelBase.Start(MessageProtocolType messageProtocolType, ProtocolEndpointCompletionSource completionSource, DiagnosticServiceOptions diagnosticServiceOptions) in D:\a\1\s\source\Prod\Microsoft.Dynamics.Nav.EditorServices.Protocol\Channel\ChannelBase.cs:line 44
   at Microsoft.Dynamics.Nav.EditorServices.Protocol.MessageProtocol.ProtocolEndpoint.Start(ChannelBase channel, MessageProtocolType messageProtocolType, DiagnosticServiceOptions diagnosticServiceOptions) in D:\a\1\s\source\Prod\Microsoft.Dynamics.Nav.EditorServices.Protocol\MessageProtocol\ProtocolEndpoint.cs:line 27

   --- End of inner exception stack trace ---
   at System.Threading.Tasks.Task.ThrowIfExceptional(Boolean includeTaskCanceledExceptions)
   at System.Threading.Tasks.Task.Wait(Int32 millisecondsTimeout, CancellationToken cancellationToken)
   at Prod.EditorServices.Host.Program.Main(String[] args) in D:\a\1\s\source\Prod\Microsoft.Dynamics.Nav.EditorServices.Host\Program.cs:line 156
[Error - 09:19:39] Connection to server got closed. Server will not be restarted.

I never experienced this on any image of previous version (BC16 and down). Is this an image issue?

Ok, @lvanvugt now we got another issue. It seems the assembly "Newtonsoft.Json, Version=<IP_ADDRESS>" is missed. Does the re-installing the vsix an restarting VSCode helps?
Otherwise you can try to get a repro on the previous daily build.

Ok, @lvanvugt now we got another issue. It seems the assembly "Newtonsoft.Json, Version=<IP_ADDRESS>" is missed. Does the re-installing the vsix an restarting VSCode helps?

No.

Otherwise you can try to get a repro on the previous daily build.

How do I get that using docker image? In other words, what is the url for that?

@lvanvugt, if you still experience a problem with the latest build, please report a separate issue. Let's come back to working environment, have you tried the project I attached? I used it to verify the issue and maybe I missed some details. Please let me know if the "show caption" issue is there, then I'll create a bug. Thank you.

This issue has been closed because it needs more information and has not had recent activity. Please open a new issue if you believe this has not been resolved and reference the current issue.


CompositeHealthContributor instead of simple HealthIndicator

Is your feature request related to a problem? Please describe.
I am using spring-cloud-gcp 1.2.3 with spring boot 2.2.3.
My application instanciate two PubsubTemplate beans because I need to communicate with two PubSub from two Google Cloud projects.
If I enable the PubSub Health Indicator, my application can not start because of this error :

Parameter 0 of method pubSubHealthIndicator in org.springframework.cloud.gcp.autoconfigure.pubsub.health.PubSubHealthIndicatorAutoConfiguration required a single bean, but 2 were found:
	- project1PubSubTemplate: defined by method 'getProject1PubSubTemplate' in class path resource [io/myapp/configuration/PubSubConfiguration.class]
	- project2PubSubTemplate: defined by method 'getProject1PubSubTemplate' in class path resource [io/myapp/configuration/PubSubConfiguration.class]

Describe the solution you'd like
To avoid this, I set management.health.pubsub.enabled=false and created a custom CompositeHealthContributor.
public class PubSubHealthIndicatorAutoConfiguration extends CompositeHealthContributorConfiguration<PubSubHealthIndicator, PubSubTemplate> {

    @Bean
    @ConditionalOnMissingBean
    public HealthContributor pubSubHealthContributor(Map<String, PubSubTemplate> pubSubTemplates) {
        return createContributor(pubSubTemplates);
    }
}

Would this change may take place directly in Spring Cloud GCP instead of having to disable standard health indicator ?

@olivierboudet And thank you extra for bringing the solution, too!
In case it's useful in the future -- when overriding autoconfiguration, it's enough to supply a custom user bean. Because all our autoconfiguration is annotated with @ConditionalOnMissingBean, it will back off if it sees a (non-autoconfigured) user bean of the same type. Then you might not need to disable the property.


Transcript for user and bot is not available. In bot V3.0 there is IActivityLogger  , can we have similar sample using V4.0

I would like to see all conversation history, Including bot and user's responses
For Ex.
Bot : Hi,
User : Hellow
Bot : What is your location
User : some city
Bot : Please enter your current location
..........

Please refer to the TranscriptLogger middleware

could you please add link of code sample which uses transcriptLogger middleware?


Prepare for final 1.0.0 release

Preparing to publish 1.0.0 version of this as a gem in preparation for Bonnie 2.0 release. Also standardize authors.
Submitter:

[x] This pull request describes why these changes were made.
[ ] JIRA ticket for this PR:
[ ] JIRA ticket links to this PR
[x] Code diff has been done and been reviewed (it does not contain: additional white space, not applicable code changes, debug statements, etc.)
[x] If UI changes have been made, google WAVE plug-in has been executed to ensure no 508 issues were introduced. N/A
[x] Tests are included and test edge cases
[x] Tests have been run locally and pass (remember to update Gemfile when applicable)
[x] Code coverage has not gone down and all code touched or added is covered.

In rare situations, this may not be possible or applicable to a PR. In those situations:

Note why this could not be done or is not applicable here:
Add TODOs in the code noting that it requires a test
Add a JIRA task to add the test and link it here:

[ ] Automated regression test(s) pass

If JIRA tests were used to supplement or replace automated tests:

[ ] JIRA test links:
[ ] Justification for using JIRA tests:
[ ] JIRA tests have been added to sprint

Reviewer 1:
Name:

[ ] Code is maintainable and reusable, reuses existing code and infrastructure where appropriate, and accomplishes the task’s purpose
[ ] The tests appropriately test the new code, including edge cases
[ ] You have tried to break the code

If JIRA tests were used to supplement or replace automated tests:

[ ] JIRA tests have been run and pass
[ ] You agree with the justification for use of JIRA tests or have provided input on why you disagree

Reviewer 2:
Name:

[ ] Code is maintainable and reusable, reuses existing code and infrastructure where appropriate, and accomplishes the task’s purpose
[x] The tests appropriately test the new code, including edge cases NA
[x] You have tried to break the code NA

If JIRA tests were used to supplement or replace automated tests:

[x] JIRA tests have been run and pass NA
[x] You agree with the justification for use of JIRA tests or have provided input on why you disagree NA

Good point... changed.


Add Windows distribution publishing (msi)

@wieslawsoltes checkout this handy dotnet tool: https://github.com/quamotion/dotnet-packaging it allows creating multiple platform pages using just simple command.


Write ATS for TG requirement 27

Each "Dataset Feed" shall contain separate entries for each format/CRS combination in which the pre-defined dataset is available to download.

The draft ATS does only test that no entries are available for the same alternate link.
Is this test sufficient or should it be extended / changed?

I would say it is not suffifcient.
The test has to ensure that all downloads are available to the user.

Thanks for thinking along :). Maybe I don't understand your comment correctly. Do you mean that we need to resolve the links? This is done in another test already (where all downloadlinks are resolved). Or should we also try to compare the responses?

No, I mean that the most important point is to ensure that a user can find a download for any format/CRS combination.

Angelo, how does "ensure" translate to the ATS? That is not clear to me. If you have any additions / proposed changes for the ATS, please feel free to change the ATS text.

I think @aquaglia's point may well be valid: There is requirement #20 demanding a category element in the Download Service feed for each CRS provided by the service. Now the question is if this should be interpreted as

a requirement to provide all the datasets of the service using exacly the same set of CRSes, or
is it a superset of CRSes used by any datasets provided by this service.

In the case 1) we should have a test that each dataset feed contains at least one download link with rel="alternate" with each of category CRS elements contained in it parent Download Service feed (which can be found using the upward link (rel="up") if given.
In the case 2) We could only check that there are no download links with category not mentioned in the parent Download Service Feed.
Note, that If the up-link is not given, it may be very difficult to find the parent Download Service, especially when there seems to no requirement that the relation between the Download Service Feed and the Dataset Feed must be 1..n and not n..n. That is: can more than one Download Service Feeds point to a same Dataset Feed?

It is a valid point, I agree, but I'm wondering how we could have a robust test for it. @ilkkarinne, your suggestion means we could check that for each CRS at least one download is provided (i.e.: there is an entry in a Dataset feed with the same category values, which is related to #35 ). This would be a partial solution. It solves the CRS part. Because: how do we now what formats should be available? The test is about CRS/format combinations.
Should we rewrite the test to be something like: test if the category elements in each dataset feed entry match with the service feed entry's category elements?


import "github.com/chaosblade-io/chaosblade/exec/os/bin" is a program, not an importable package

$ go version
1.12.6
I have a common.go file in the exec/os/bin/ directory, and its package name is bin. Then I imported the package bin in exec/os/bin/burncpu/burncpu.go, and I reported this error.

exec/os/bin/ is package main. You cannot import package main as the message says.

What @AlexRouSg said.

@AlexRouSg @mvdan  Hi, thanks for your reply.  I am still confused.
(1). The package name I defined for the common.go file located in the exec/os/bin directory is bin (that is, its direct directory name). Why do you say its package name main?
(2). Is this because the golang syntax specifies that the package name of the file in the bin directory must be main?
(3). Then, if I want to refer to the function in exec/os/bin/.common in exec/os/bin/burncpu/burncpu.go, how do I import the package?

From files like burnio.go, you can clearly see package main.
If you have questions, look up tutorials and documentation online. And if you have questions, see https://github.com/golang/go/wiki/Questions.

Not understand.

See: https://github.com/jievince/chaosblade/blob/master/exec/os/bin/common.go#L1
Package name is not determined by the path, that is the import path. Package names are determined by the line package main

Hi @AlexRouSg ,the previous common.go file is like this:
`package bin
import (
"os"
"fmt"
)
const ErrPrefix = "Error:"
func printAndExitWithErrPrefix(message string) {
fmt.Fprint(os.Stderr, fmt.Sprintf("%s %s", ErrPrefix, message))
os.Exit(1)
}
func printErrAndExit(message string) {
fmt.Fprint(os.Stderr, message)
os.Exit(1)
}
func printOutputAndExit(message string) {
fmt.Fprintf(os.Stdout, message)
os.Exit(0)
}`

Then you are still using the original package and not the edited one.


Language cleanup

Cleaned up a lot of language to make it more readable.

Thank you for proofreading the readme!


fix #687 - validate table handle prior to use

Describe the contribution
fixes a bug where a table handle is used prior to validation (used in the variable initialization at the top of CFE_TBL_Load() .)
Fix #687
Contributor Info - All information REQUIRED for consideration of pull request
<EMAIL_ADDRESS>

Squash these (just don't assign NULL):
[fsw/cfe-core/src/tbl/cfe_tbl_api.c:681] -> [fsw/cfe-core/src/tbl/cfe_tbl_api.c:689]: (style) Variable 'AccessDescPtr' is reassigned a value before the old one has been used.
[fsw/cfe-core/src/tbl/cfe_tbl_api.c:682] -> [fsw/cfe-core/src/tbl/cfe_tbl_api.c:690]: (style) Variable 'RegRecPtr' is reassigned a value before the old one has been used.
[fsw/cfe-core/src/tbl/cfe_tbl_api.c:680] -> [fsw/cfe-core/src/tbl/cfe_tbl_api.c:696]: (style) Variable 'WorkingBufferPtr' is reassigned a value before the old one has been used.

updated, squashed, pushed, better? :)

CCB 20200513 - Approved


Windows Phone 8 / 8.1support

@gbenvenuti Nice plugin! This is exactly when I've been searching for!!
I would like to know any plans on implementing this plugin for Windows Phone? I need it for a project and I'm working on. Besides Windows Phone is considered as one of the 3 major platforms :)
Awaiting any feedback on this.
Thanks

WP8 support added in 1.3.4


Payment Iframe not stylable

I just used your library to implement SEPA Transactions.
Now i wanted to integrate the "create-ui"-example from this library and everything works as expected. But there are no options to style the content of the iframe.
Are there options style this iframe? cssUrl and iframeCssUrl won't do.

I believe you are referring to the credit card. If it is correct, I'd have to advise you to our seamless integration help if not, then you will find the example on how we produce the form in this file.


workbench.action.navigate* hotkeys no longer work with terminal.

Does this issue occur when all extensions are disabled?: Yes

VS Code Version:

1.64.1
d6ee99e4c045a6716e5c653d7da8e9ae6f5a8b03
x64

OS Version:

osx 11.6.1

Steps to Reproduce:
Prior to a recent update of vscode, I was able to switch cursor focus back and forth between the terminal, the editor, the file tree / search explorer, using the following keyboard shortcuts:
    {
        "key": "ctrl+h",
        "command": "workbench.action.navigateLeft"
    },
    {
        "key": "ctrl+l",
        "command": "workbench.action.navigateRight"
    },
    {
        "key": "ctrl+k",
        "command": "workbench.action.navigateUp"
    },
    {
        "key": "ctrl+j",
        "command": "workbench.action.navigateDown"
    },

These commands now only allow moving cursor focus between all panels except for the terminal. I can't navigate to or from it. I'm constantly switching back and forth between my vs code terminal and editor. I want to be able to navigate to it using the same navigation keys i use to navigate to/from every other panel. This is a recent regression.

What is your Panel Alignment setting: left/right/center/justify?
That seems to affect these commands.  For instance, I have the Panel set to justify so that's the full width.  Then workbench.action.navigateLeft or workbench.action.navigateRight don't do anything.  Should it?  The Panel is below the Side Bar and Side Panel so there is no view container technically to its left or right, only above it.
If I set the Panel alignment to center then all your commands work as you would expect.

I believe this is already fixed, can you see if you can reproduce in the Insiders build?
I can't repro there

As of the latest update today (not insiders build) I am no longer able to replicate this bug.
1.64.2
f80445acd5a3dadef24aa209168452a3d97cc326
x64

We can probably close this issue. I can re-open if it resurfaces.


feat: sequential and low

fix: Response Headers to lowerCase
feat: add writeHead to Response
feat: add query to Response
others: create utils directory

Hi @jesusvilla, thanks again for spending some of your time on improving this project. By doing this, several other projects benefit as well.
I will merge and prepare the release.
Regards.

Hi @jkyberneees, a pleasure to help, then more things will come, I really like what you have done with low server, I am trying to create a framework based on this, that is why I need all the possible compatibility with the native version.  I have already worked with uWebSocket, it is too fast but it escapes from NodeJS.  Count on me to continue contributing.


Fix Dereference of null pointer in HashMap

clang-analyzer find

[approve ci clang-analyzer]

Also remember to set all the fields (Milestones etc.) on the PRs :-).


what workaround for tooltips inside div?

Hi,
How can I make the tooltip appear outside the div so that the whole/full tooltip gets displayed properly? I tried adding z-index with no luck. Please see screenshot to see what's going on on what I'm experiencing.

Thanks

Hi
I have the same problem with tooltip z-index. Do you have any solutions for it ?


Fixes #1925. Preserve trailing spaces on word wrap must be refactored…

Thanks to @tig for insisting on this.

@BDisp are you ok with me merging this now so that it will go in v1.7.2 that I plan on releasing today?

@BDisp are you ok with me merging this now so that it will go in v1.7.2 that I plan on releasing today?

Of course I'm with you. I thought you don't agree with these changes. In TextView, the best solution is not to mix preservation spaces on the right with not preserving, because controlling the selected text is not possible in all situations.

The immeidate issue I had has been resolved via ReadOnly == true && WordWrap == true.
I think we should consider a re-factor/rewrite of all text handling as part of v2.0 instead of continuing to hack at what's in there.
Are you ok with me closing this PR and opening a new Issue where we can focus on that?

The immeidate issue I had has been resolved via ReadOnly == true && WordWrap == true.

But with this pr you have the same behavior like you did, with the difference keep trailing space, to allowing consistence with the selected text no mater ReadOnly is enabled or not with the WordWrap enabled.

I think we should consider a re-factor/rewrite of all text handling as part of v2.0 instead of continuing to hack at what's in there.

I agree with a re-factor/rewrite as part part of v2.0 in the way you want on the TextView, by hacking. This pr has changes that correct some bug and preserve trailing spaces more correctly.

Are you ok with me closing this PR and opening a new Issue where we can focus on that?

Not totally because this PR has important changes to the word wrap API when preserve trailing spaces is enabled.


wasm: remove no longer needed Emscripten metadata.

Signed-off-by: Piotr Sikora<EMAIL_ADDRESS>

@envoyproxy/dependency-shepherds Could you take a quick look? Thanks!


[Feature] Add Tencent docs sink connector

Search before asking

[X] I had searched in the issues and found no similar issues.

Feature Request
Add Tencent docs sink connector
Are you willing to submit PR?

[ ] Yes I am willing to submit a PR!

Code of Conduct

[ ] I agree to follow this project's Code of Conduct *

@qqeasonchen i want to have a try, please assign me.

It seems like we're going to fall to the first step.Tencent Documents currently does not support individual developer access. Or can EM apply as the certification subject?

 It seems like we're going to fall to the first step.Tencent Documents currently does not support individual developer access. Or can EM apply as the certification subject?

@qqeasonchen @pandaapo


Extend custom mode API with start/end and keyword mapping

This PR adds two extra capabilities to the custom mode rule Java API:

start/end to support things like block comments
keyword mapper support

With these two changes modes like the SQL mode can be completely defined via the Java API.

@F0rce I realised too late that the JS changes should have been done in https://github.com/f0rce/lit-ace instead of in this project. If you're OK with the proposed changes I'll split up this PR into one for lit-ace and one for this project.

@pepijnve jeah, I should have mentioned anywhere, that JS changes have to be made in https://github.com/F0rce/lit-ace
The feature sound really interesting and I'll be sure to check it out as soon as the development is done. If you need help with the JS part, just ping me in the PR and I'll be sure to help you out. LGTM

https://github.com/F0rce/lit-ace/pull/11 here you go. I can update this PR once there's a build containing that enhancement.


shiori: 1.5.5 -> 1.7.0

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://repology.org/project/shiori/versions.
meta.description for shiori is: Simple bookmark manager built with Go
meta.homepage for shiori is: https://github.com/go-shiori/shiori
Updates performed

Golang update

To inspect upstream changes

Release on GitHub

Compare changes on GitHub

Impact
Checks done

built on NixOS
Warning: a test defined in passthru.tests did not pass
found 1.6.1 in filename of file in /nix/store/c6646cdlw4ddw9kbgqfdfdbw7qf59pza-shiori-1.6.1

Rebuild report (if merged into master) (click to expand)

1 total rebuild path(s)

1 package rebuild(s)

First fifty rebuilds by attrpath
shiori

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/c6646cdlw4ddw9kbgqfdfdbw7qf59pza-shiori-1.6.1 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A shiori https://github.com/r-ryantm/nixpkgs/archive/30fc118fa87e94c0673153ca317d6862c190af87.tar.gz

Or:
nix build github:r-ryantm/nixpkgs/30fc118fa87e94c0673153ca317d6862c190af87#shiori

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/c6646cdlw4ddw9kbgqfdfdbw7qf59pza-shiori-1.6.1
ls -la /nix/store/c6646cdlw4ddw9kbgqfdfdbw7qf59pza-shiori-1.6.1/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review --extra-nixpkgs-config '{ allowInsecurePredicate = x: true; }' run on x86_64-linux 1

1 package built:

shiori

Maintainer pings
cc @minijackson for testing.

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://github.com/go-shiori/shiori/releases.
meta.description for shiori is: Simple bookmark manager built with Go
meta.homepage for shiori is: https://github.com/go-shiori/shiori
Updates performed

Golang update

To inspect upstream changes

Release on GitHub

Compare changes on GitHub

Impact
Checks done

built on NixOS
Warning: a test defined in passthru.tests did not pass
found 1.6.2 with grep in /nix/store/r0bmf0mhy00krzzsmq5yrll8bwrsnlgp-shiori-1.6.2
found 1.6.2 in filename of file in /nix/store/r0bmf0mhy00krzzsmq5yrll8bwrsnlgp-shiori-1.6.2

Rebuild report (if merged into master) (click to expand)

1 total rebuild path(s)

1 package rebuild(s)

First fifty rebuilds by attrpath
shiori

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/r0bmf0mhy00krzzsmq5yrll8bwrsnlgp-shiori-1.6.2 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A shiori https://github.com/r-ryantm/nixpkgs/archive/cb15602c2ff8c092f9cb9f868f473f193372336c.tar.gz

Or:
nix build github:r-ryantm/nixpkgs/cb15602c2ff8c092f9cb9f868f473f193372336c#shiori

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/r0bmf0mhy00krzzsmq5yrll8bwrsnlgp-shiori-1.6.2
ls -la /nix/store/r0bmf0mhy00krzzsmq5yrll8bwrsnlgp-shiori-1.6.2/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review --extra-nixpkgs-config '{ allowInsecurePredicate = x: true; }' run on x86_64-linux 1

1 package built:

shiori

Maintainer pings
cc @minijackson for testing.

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://github.com/go-shiori/shiori/releases.
meta.description for shiori is: Simple bookmark manager built with Go
meta.homepage for shiori is: https://github.com/go-shiori/shiori
Updates performed

Golang update

To inspect upstream changes

Release on GitHub

Compare changes on GitHub

Impact
Checks done

built on NixOS
Warning: a test defined in passthru.tests did not pass
found 1.7.0 in filename of file in /nix/store/z8ampyv9ll3xx04s94xp8872pj17xdpn-shiori-1.7.0

Rebuild report (if merged into master) (click to expand)

2 total rebuild path(s)

2 package rebuild(s)

First fifty rebuilds by attrpath

shiori

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/z8ampyv9ll3xx04s94xp8872pj17xdpn-shiori-1.7.0 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A shiori https://github.com/r-ryantm/nixpkgs/archive/6e509c618a077cd41b7e0bbbe94e81275aaa6729.tar.gz

Or:
nix build github:r-ryantm/nixpkgs/6e509c618a077cd41b7e0bbbe94e81275aaa6729#shiori

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/z8ampyv9ll3xx04s94xp8872pj17xdpn-shiori-1.7.0
ls -la /nix/store/z8ampyv9ll3xx04s94xp8872pj17xdpn-shiori-1.7.0/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review --extra-nixpkgs-config '{ allowInsecurePredicate = x: true; }' run on x86_64-linux 1

1 package built:

shiori

Maintainer pings
cc @minijackson for testing.

Done in #307123.


QUESTION: Are individual words in multiple word based extensions extended?

Let's take the following example:
POST /v1/c11y/extensions

{
  "concept": "Winlogon Helper DLL",
  "definition": "...",
  "weight": 1
}

In this result, Winlogon Helper DLL is seen as a single concept. But does it also relocate the definitions of: Winlogon, Helper and DLL?
It would be great that -for example- the word 'helper' now also moves into the direction of Winlogon Helper DLL. Or would this already be the case based on the definition?

@bobvanluijt to add some more detailed examples.