feat: Added docstring examples to AnimatedBuilder and ChangeNotifier

I have added an example to document how an AnimatedBuilder can be used along with a ChangeNotifier. Follow up for https://github.com/flutter/flutter/pull/97256
List which issues are fixed by this PR. You must list at least one issue.

https://github.com/flutter/flutter/issues/98624

Pre-launch Checklist

[x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
[x] I read the [Tree Hygiene] wiki page, which explains my responsibilities.
[x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
[x] I signed the [CLA].
[x] I listed at least one issue that this PR fixes in the description above.
[x] I updated/added relevant documentation (doc comments with ///).
[ ] I added new tests to check the change I am making, or this PR is [test-exempt].
[x] All existing and new tests are passing.

@Hixie I have only updated the documentation so no tests are required

Thank you @goderbauer for your time, I've created and tested an example as you suggested

Looks like the checks are unhappy with this change. Can you take a look?

Overall I am actually not convinced that this needs a huge example. Maybe a simple sentence in the doc would be enough. Something like: "Oh, by the way, an AnimiatedBuilder accepts any Listenable (not just an Animation) and works great with Listenable subclasses such as ChangeNotifier, ValueNotifier, etc." (of course phrased a little more formal)
That may be easier to understand than having to parse a big block of sample code.

@goderbauer I have simplified the text and also simplified the example.
I think that having a short example (along with some descriptive text) is a good thing. A person can play with the code, see it in action and we can make sure that our words are misunderstood 🙂
I've followed you valuable comments to improve the code. I've also removed the InheritedWidget which yeah adds more complexity. It's all inside a simple StatefulWidget now and I agree that it looks simpler/better

Looks like one of the checks is failing. Can you take a look?

I've addressed all of your feedbacks and figure out the proper fix for the docs.
Thank you for your reviews

I have thought about this some more and I still think what I said in https://github.com/flutter/flutter/pull/98628#issuecomment-1045254459 is valid. A simple doc comment saying that any subclass of a Listenable (e.g. ChangeNotifier and friends) can be used with AnimatedBuilder is clearer and more concise than this example. You have to do a lot more reading to get that point from this example - and may even miss what the example is trying to illustrate altogether.

Would you suggest to simply drop the example and keep these lines?
/// A [State.setState] method call requires Flutter to entirely rebuild the
/// current widget plus a variable portion of the subtree, depending on the
/// depth and the structure.
///
/// To avoid unnecessary work, the [AnimatedBuilder] class can be used along
/// with a [Listenable] to only rebuild certain portions a widget,
/// leaving other parts and the subtree untouched. For example,
/// [ChangeNotifier] and [ValueNotifier] are subtypes of [Listenable].
///
/// Since a [ChangeNotifier] is a subtype of [Listenable], it can be used in
/// an [AnimatedBuilder] to listen for changes.

I would really like to keep the example but we can remove it if you want 🙂
I think that we could keep the lines I posted above. If we wrote even less contents, maybe it wouldn't give enough context to understand why one should use a ChangeNotifier in an AnimatedBuilder. Also, a very few lines wouldn't add much value and so they wouldn't even need to be there.
What do you think? Do you agree in at least keeping that text?

Here's my suggestion for the docs:
## Improve rebuild performance using AnimationBuilder

Despite the name, [AnimationBuilder] is not limited to [Animation]s: Any subtype
of [Listenable] (e.g. [ChangeNotifier] and [ValueNotifier]) can be used with an
[AnimatedBuilder] to rebuild only parts of a widget when the [Listenable] notifies its listeners.

If you want to include an example below that, let's use one that is concise and focused on that particular use case. Here's my suggestion:
The following example implements a simple counter widget, that uses the
[AnimationBuilder] to limit rebuilds to only the [Text] widget showing the current
count (stored in a [ValueNotifier]) when the value of the counter is changing.

import 'package:flutter/material.dart';

class CounterBody extends StatelessWidget {
  const CounterBody({Key? key, required this.counterValueNotifier}) : super(key: key);

  final ValueNotifier<int> counterValueNotifier;

  @override
  Widget build(BuildContext context) {
    return Center(
      child: Column(
        mainAxisAlignment: MainAxisAlignment.center,
        children: [
          const Text('Current counter value:'),
          // Thanks to the [AnimatedBuilder], only the widget displaying the
          // current count is rebuilt when `counterValueNotifier` notifies its
          // listeners.
          AnimatedBuilder(
            // [AnimatedBuilder] accepts any [Listenable] subtype.
            animation: counterValueNotifier,
            builder: (BuildContext context, Widget? child) {
              return Text('${counterValueNotifier.value}');
            },
          ),
        ],
      ),
    );
  }
}

class MyApp extends StatefulWidget {
  const MyApp({Key? key}) : super(key: key);

  @override
  State<MyApp> createState() => _MyAppState();
}

class _MyAppState extends State<MyApp> {
  final ValueNotifier<int> _counter = ValueNotifier<int>(0);

  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      home: Scaffold(
        appBar: AppBar(title: const Text('AnimatedBuilder example')),
        body: CounterBody(counterValueNotifier: _counter),
        floatingActionButton: FloatingActionButton(
          onPressed: () => _counter.value++,
          child: const Icon(Icons.add),
        ),
      ),
    );
  }
}

void main() {
  runApp(const MyApp());
}

I really like your changes! Thank you for having considered keeping an example, I think it will be very valuable

I have rebased but the diff isn't going away...


Feature/notifier

What does this PR do?

Implements a proper hot reload of the chi router, this way we can guaranty that all the plugins are gonna be reloaded properly.

👍


Remove obsolete libsecp256k1 bindings

Replaced by #34.

Fixes #64.

@apoelstra You don't have to review this, but you may wish to run it through your CI.

Sure. Verified that this is a delete-only commit. Will post an ACK once my local CI finishes.


SLSA Build Provenance

Should be more straightforward now with the new "Bring your own Builder" feature.
Since we're likely to want SLSA build provenance later and it imposes a bunch of restrictions on how a workflow is allowed to be used we should think about building this feature in even if it doesn't get used end-to-end by PyPI now. Creating the provenance file per artifact and then not doing anything with them (unless the user explicitly outputs them to a directory?) might be a good starting point?

Yes, agreed. I suspect that the BYOB might be challenging to use with something like the manylinux base images that we'll need for #2, but planning for it now (and potentially generating the provenance to do nothing with it) sounds like a good idea.


to-file stage failure

Traceback (most recent call last):
  File "/opt/conda/envs/morpheus/bin/morpheus", line 11, in <module>
    sys.exit(run_cli())
  File "/opt/conda/envs/morpheus/lib/python3.8/site-packages/morpheus/cli.py", line 1381, in run_cli
    cli(obj={}, auto_envvar_prefix='CLX', show_default=True, prog_name="morpheus")
  File "/opt/conda/envs/morpheus/lib/python3.8/site-packages/click/core.py", line 1130, in __call__
    return self.main(*args, **kwargs)
  File "/opt/conda/envs/morpheus/lib/python3.8/site-packages/click/core.py", line 1055, in main
    rv = self.invoke(ctx)
  File "/opt/conda/envs/morpheus/lib/python3.8/site-packages/click/core.py", line 1657, in invoke
    return _process_result(sub_ctx.command.invoke(sub_ctx))
  File "/opt/conda/envs/morpheus/lib/python3.8/site-packages/click/core.py", line 1657, in invoke
    return _process_result(sub_ctx.command.invoke(sub_ctx))
  File "/opt/conda/envs/morpheus/lib/python3.8/site-packages/click/core.py", line 1689, in invoke
    return _process_result(rv)
  File "/opt/conda/envs/morpheus/lib/python3.8/site-packages/click/core.py", line 1626, in _process_result
    value = ctx.invoke(self._result_callback, value, **ctx.params)
  File "/opt/conda/envs/morpheus/lib/python3.8/site-packages/click/core.py", line 760, in invoke
    return __callback(*args, **kwargs)
  File "/opt/conda/envs/morpheus/lib/python3.8/site-packages/click/decorators.py", line 26, in new_func
    return f(get_current_context(), *args, **kwargs)
  File "/opt/conda/envs/morpheus/lib/python3.8/site-packages/morpheus/cli.py", line 543, in post_pipeline
    pipeline.run()
  File "/opt/conda/envs/morpheus/lib/python3.8/site-packages/morpheus/pipeline/pipeline.py", line 1239, in run
    asyncio.run(self._do_run())
  File "/opt/conda/envs/morpheus/lib/python3.8/asyncio/runners.py", line 44, in run
    return loop.run_until_complete(main)
  File "/opt/conda/envs/morpheus/lib/python3.8/asyncio/base_events.py", line 616, in run_until_complete
    return future.result()
  File "/opt/conda/envs/morpheus/lib/python3.8/site-packages/morpheus/pipeline/pipeline.py", line 1214, in _do_run
    self.build_and_start()
  File "/opt/conda/envs/morpheus/lib/python3.8/site-packages/morpheus/pipeline/pipeline.py", line 1038, in build_and_start
    self.start()
  File "/opt/conda/envs/morpheus/lib/python3.8/site-packages/morpheus/pipeline/pipeline.py", line 998, in start
    self._neo_executor.start()
  File "/opt/conda/envs/morpheus/lib/python3.8/site-packages/morpheus/pipeline/pipeline.py", line 960, in inner_build
    s.build(seg)
  File "/opt/conda/envs/morpheus/lib/python3.8/site-packages/morpheus/pipeline/pipeline.py", line 526, in build
    dep.build(seg, do_propagate=do_propagate)
  File "/opt/conda/envs/morpheus/lib/python3.8/site-packages/morpheus/pipeline/pipeline.py", line 526, in build
    dep.build(seg, do_propagate=do_propagate)
  File "/opt/conda/envs/morpheus/lib/python3.8/site-packages/morpheus/pipeline/pipeline.py", line 526, in build
    dep.build(seg, do_propagate=do_propagate)
  [Previous line repeated 10 more times]
  File "/opt/conda/envs/morpheus/lib/python3.8/site-packages/morpheus/pipeline/pipeline.py", line 504, in build
    out_ports_pair = self._build(seg, in_ports_pairs)
  File "/opt/conda/envs/morpheus/lib/python3.8/site-packages/morpheus/pipeline/pipeline.py", line 783, in _build
    return [self._build_single(seg, in_ports_streams[0])]
  File "/opt/conda/envs/morpheus/lib/python3.8/site-packages/morpheus/pipeline/output/to_file.py", line 113, in _build_single
    to_file = neos.WriteToFileStage(seg,
ValueError: Read/Write mode ('+') is not supported by WriteToFileStage. Mode: w+

Do you have a repro script?

WriteToFileStage supports w (write, truncate) and a (write, append) modes, but not w+ (read/write truncate). Are you providing the mode explicitly? If so, just change the mode to w, since WriteToFileStage doesn't need to read. If not, how are you producing this error, and what is the expected result?

This is simply using the to-file stage like this:
morpheus run --use_cpp=True --num_threads=8 --pipeline_batch_size=8192 --model_max_batch_size=32 --edge_buffer_size=32  pipeline-nlp --model_seq_length=256 from-file --filename=./data/pcap_dump.jsonlines dropna monitor --description='Drop Null Attributes rate' deserialize monitor --description='Deserialization rate' preprocess --vocab_hash_file=./data/bert-base-uncased-hash.txt --truncation=True --do_lower_case=True --add_special_tokens=False monitor --description='Preprocessing rate' inf-triton --force_convert_inputs=True --model_name=sid-minibert-onnx --server_url=ai-engine:8001 --use_shared_memory=True monitor --description='Inference rate' --smoothing=0.001 --unit inf add-class monitor --description='Classification rate' serialize --exclude '^ts_' monitor --description='Serialization rate' to-file --filename=/common/data/output/sid-minibert-onnx-output.jsonlines --overwrite

there are no arguments that relate to modes save --overwrite I suppose.

https://github.com/NVIDIA/Morpheus/blob/branch-22.04/morpheus/pipeline/output/to_file.py#L115

Works if I drop the --overwrite arg

What should happen to the output file if the overwrite flag is not provided? Should it be appended to, or should the write fail? Something else?


Fix node version requirement

Recent builds of favicons breaks because of an implied need for Node 6+.
Removing the requirement for Node 6+ by:
Locking down svg2png dependency to patch releases only of 3.0.x. This is done since svg2png 3.1.x+ requires node 6+ (https://github.com/domenic/svg2png/releases).

Awesome, thanks for fixing this! :)


revert multipack batch sampler changes

The loss isn't quite right w/ #1619, off by an order of magnitude.

just to make it easier, the previous state was https://github.com/OpenAccess-AI-Collective/axolotl/blob/fe650dd3260d0c24d6c5366b90d3507773872b2c/src/axolotl/utils/samplers/multipack.py


Enable SIMD

It would be great to have simd-enabled APIs

There is already a simd package. Though it is not accelerated yet in any case, but will be in the future.
https://github.com/jtransc/jtransc/tree/master/jtransc-rt-core/src/com/jtransc/simd
Closing this until a desktop navigator / v8 / node supports SIMD without flags and we can do more tests/checks easily.


Save All for multiple rows changes

I am using the crud table from basic-demo, is there a way I can get all changes made to multiples rows, and I can customize my own Save All button to trigger save at once?
After the user changing multiple different rows/columns, it would be nice if they decide to Save All at once.
Your help is very much appreciated. Thanks.

Collect the modified lines, then save using the custom function
  private subscriptions: Subscription[] = [];
  private changedRows = new Set<Row>();

  ngOnInit() {
    const subCell = this.dataManager.events.cellSource$.subscribe((data) => {
      if (data.type === CellEventType.ValueChanged) {
        const row = this.dataManager.rows[data.rowIndex];
        if (!this.changedRows.has(row)) {
          if (this.dataManager.rowChanged(row)) {
            this.changedRows.add(row);
          }
        } else {
          if (!this.dataManager.rowChanged(row)) {
            this.changedRows.delete(row);
          }
        }
      }
    });
    this.subscriptions.push(subCell);
  }

  ngOnDestroy() {
    this.subscriptions.forEach(s => s.unsubscribe());
  }

it works with your code changes above, appreciates your help, thanks alot.


README.md Edits: Athena privileges and Information on locally running Repokid

I have started working on the Athena Hook. Starting off with making edits to the README.md.

Coverage remained the same at 53.607% when pulling<PHONE_NUMBER>294e0cccb666975bb244e2296e78a2 on nasehim7:permission into f46767dcf88f3728701b1ff3371a97f063fb3d3b on Netflix:master.

Closing this as stale. Happy to reopen if you're still interested in getting this merged (pending changes based on @mcpeak's comment).


docs: enforce conventional commits in contributing.md

I agree, this should go through for sure.
I've never contributed to a project before so I didn't know what the conventional commit practice was - I will make sure to adhere to it from now on!

@not-ivy I'd say to enforce it for pr and issue titles. It doesn't really matter for commit messages as we squash merge them anyway.


„Special chars“

This is a "very low level" issue:

As you can see, a German umlaut stops marking project and content highlighter. Not hard to overcome (simply change ä → ae…) but a little inconvenient while fast typing.
A typical "first world problem" – I know :)

This should be fixed in v0.1.5 1bd8e39c35b9dc0a4d467d27f7f9f1e308e6552e


fixing compliation for systems where APR doesn't have crypto support

I think this can be closed, now that #834 was fixed by f9464b46bf3cddcf857c453cc2524b2cacf2b73b.


Fix assets directory cannot locate error during twill setup stage

References: #25
This PR fixed this problem by removing all publishAssets operations from the ServiceProvider as well as the Setup command, cause assets has been compiled by the project using twill instead.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


chore: replace writeShellScriptBin in prime.nix with enableOffloadCmd

option introduced in this commit:
https://github.com/NixOS/nixpkgs/commit/2a7130d13a032093f5394ef0961842d1e1928789
Description of changes
Things done

[ ] Tested the changes in your own NixOS Configuration
[ ] Tested the changes end-to-end by using your fork of nixos-hardware and
importing it via <nixos-hardware> or Flake input

@bors merge

We can potentially check for nixpkgs.config.nvidia.acceptLicense here?

I'm unfamiliar with Nix (and Git) and I don't actually know what's going on here. :/
Can you show me how to do it exactly? And I've enabled Allow edits by maintainers.

Looks like your change doesn't affect the build issue here at all.

@mergify queue


Shoud .jshintrc use space-2 to keep consistency?

In the
https://github.com/meanjs/mean/blob/master/.jshintrc#L33
it use 4 space as ident.
However, in the
https://github.com/meanjs/mean/blob/master/.editorconfig#L18
it use 2 space as ident.
Is there any conflicts between these?

@QiyuLi #766 address this and actually removes it from the jshint file. Nice catch though!

Oh, didn't check that. Thanks!

@QiyuLi Np. Thanks for pointing that out!


Removed unused dependencies using nebula-linter

Context
Removed unused dependencies inside the project
Checklist

[x] ./gradlew build compiles code correctly
[x] Added new tests where applicable
[x] ./gradlew test passes all tests
[x] Extended README or added javadocs where applicable

Hi @sundargates
Thanks for the review!, let me know if any further changes will be required.


Extra row with "null" in reader fetchAll result

Using fetchAll I have extra row with NULL in result.
See following testcase:
<?php
require_once 'vendor/autoload.php';
use League\Csv\Reader;

$reader = Reader::createFromString("a,b".PHP_EOL."3,11");
$result = $reader->fetchAll();
var_export($result);// array(0 =>array (0 => 'a',1 => 'b',),1 =>array (0 => '3',1 => '11',),2 =>array (0 => NULL,),)

My environment:
Ubuntu 14.04.1 LTS
PHP 5.5.21-1+deb.sury.org~trusty+2

Hi @teplolog,
This bug has been corrected in the coming 7.0 version which should be release next week. In the meantime you can simply do this
require_once 'vendor/autoload.php';
use League\Csv\Reader;

$reader = Reader::createFromString("a,b".PHP_EOL."3,11");
$reader->setFlags(SplFileObject::DROP_NEW_LINE);
$result = $reader->fetchAll();
var_export($result)

This issue is still present on 7.0 and 7.1.
array (
  0 =>
  array (
    0 => 'a',
    1 => 'b',
  ),
  1 =>
  array (
    0 => '3',
    1 => '11',
  ),
  2 =>
  array (
    0 => NULL,
  )

Hi @barroca,
can you provide your PHP/HHVM version please as I fail to reproduce this issue

php version 5.6.9, I'm using a vagrant box with CentOS Linux release 7.1.1503
Thanks.

okay, I get it ..it's a change in PHP behavior so the result depend on PHP version
look at this results which mimic what you are experimenting
http://3v4l.org/c56KM
So it's not a package bug per se. Let see what we can do to mitigate this

A way to mitigate this changed behaviour is to NOT use the DROP_NEW_LINE constant. Like this
require_once 'vendor/autoload.php';
use League\Csv\Reader;

$reader = Reader::createFromString("a,b\n3,11");
$reader->setFlags(SplFileObject::READ_AHEAD|SplFileObject::SKIP_EMPTY);
$result = $reader->fetchAll();
var_export($result)

like shown here: http://3v4l.org/oqmvp

I see, so for now will you keep the package with the same behavior?
Thank you for the help! :)

yes maybe I'll change with a new major version I don't know yet

I got the same issue using fetchAssoc. I think this issues should be put into the documentation. I'm parsing 26k rows of data and getting the incorrect reading at the end of process is not a good sign.

@donnykurnia It is documented but I'll make it more obvious then. Or better yet do you want it to be documented elsewhere ? you can make a PR I'll review it and update the documentation

Hi @nyamsprod
I missed the flags because I follow the example page: http://csv.thephpleague.com/examples/
I think setting the obvious flags every time is easily missed steps. Why not make the flags as default flag, still let the user change the flags later, but without any flags setting, it will assume the default flags (SplFileObject::READ_AHEAD|SplFileObject::SKIP_EMPTY) ?

@donnykurnia agree but doing so would be consider BC Break that's why this issue is stated to be tackle with the 8.0 release when I start working on it see #105

Great @nyamsprod
I'll try to help as much as I can within my spare time.


How to get Gather instead of GatherV2 in GraphDef?

Tried to use "tf.gather", each time when I export GraphDef, just saw op GatherV2, so how could I get Gather in graphdef?

code snippet:
import tensorflow as tf

indices = tf.constant([0, 1, 1])
x = tf.constant([[1, 2, 3],
                 [4, 5, 6],
                 [7, 8, 9]])

result = tf.gather(x, indices, axis=1)

with tf.Session() as sess:
    out = sess.run(result)
    print(out)
    print(sess.graph_def)

Got it, seems if using old tf version like 1.5, Gather will be used instead for same graph definition. Does that mean Gather is never used in TF new versons like 1.9+?

This is not Build/Installation or Bug/Performance issue. Please post this kind of support questions at Stackoverflow. There is a big community to support and learn from your questions. GitHub is mainly for addressing bugs in installation and performance. Thanks!

posted it is stackoverflow - https://stackoverflow.com/questions/55484373/how-to-get-gather-in-graphdef

@yongwww Thank you very much.

reopen it since nobody responds to the question on stackoverflow.

if we can not find the Gather anymore, it should be removed

Same questions for Zeros, Ones, ZerosLike, OnesLike

Same questions for Zeros, Ones, ZerosLike, OnesLike

TensorFlow at one point changed to emit GatherV2 in GraphDef instead of Gather, because GatherV2 has correct shape inference, and changing the shape inference behavior of Gather could have broken existing graphs.
In general the set of ops emitted by TensorFlow for a given set of python API calls is not fixed, and can change from version to version.
If you rely on downstream processing of TensorFlow ops I recommend you use our compat module to run nightly tests against future versions of TensorFlow's graph emitting code.


Yarn loader throws dependency error

When using esm imports and having "type":"module" in package.json
C:\Users\zkulb\WebstormProjects\ProjectX\.pnp.cjs:17509
      Error.captureStackTrace(firstError);
            ^

Error: @bull-board/api tried to access @bull-board/ui, but it isn't declared in its dependencies; this makes the require call ambiguous and unsound.

Required package: @bull-board/ui (via<EMAIL_ADDRESS>Required by: @bull-board/api@npm:3.11.0 (via C:\Users\zkulb\WebstormProjects\ProjectX\.yarn\cache\@bull-board-api-npm-3.11.0-859450c715-0973ec382a.zip\node_modules\@bull-board\api\dist\src\)

Require stack:
- C:\Users\zkulb\WebstormProjects\ProjectX\.yarn\cache\<EMAIL_ADDRESS>    at require$$0.Module._resolveFilename (C:\Users\zkulb\WebstormProjects\ProjectX\.pnp.cjs:17509:13)
    at Function.resolve (node:internal/modules/cjs/helpers:108:19)
    at eval (eval at createBullBoard (C:\Users\zkulb\WebstormProjects\ProjectX\.yarn\cache\@bull-board-api-npm-3.11.0-859450c715-0973ec382a.zip\node_modules\@bull-board\api\dist\src\index.js:13:47), <anonymous>:1:9)
    at createBullBoard (C:\Users\zkulb\WebstormProjects\ProjectX\.yarn\cache\@bull-board-api-npm-3.11.0-859450c715-0973ec382a.zip\node_modules\@bull-board\api\dist\src\index.js:13:47)
    at file:///C:/Users/zkulb/WebstormProjects/ProjectX/projectx-server/index.js:55:61

Hi, Thank you for reporting this issue,
Can you prepare a small repo that recreates the issue?
There is no import of @bull-board/ui from @bull-board/api.

Repo with issue
I suppose it happens when project uses workspaces.

Hi 👋
I'm in v3.11.1 but still have the issue. Using yarn 2 with workspaces too.
 /app/.pnp.cjs:14111
   return Object.defineProperties(new Error(message), {
                                  ^

 Error: Your application tried to access @bull-board/api, but it isn't declared in your dependencies; this makes the require call ambiguous and unsound.

 Required package: @bull-board/api (via<EMAIL_ADDRESS> Required by: /app/packages/core/plugins/bull.mjs

     at makeError (/app/.pnp.cjs:14111:34)
     at resolveToUnqualified (/app/.pnp.cjs:15019:21)
     at Object.resolveToUnqualified (/app/.pnp.cjs:15169:26)
     at resolve$1 (file:///app/.pnp.loader.mjs:210:31)
     at Loader.resolve (node:internal/modules/esm/loader:88:40)
     at Loader.getModuleJob (node:internal/modules/esm/loader:241:28)
     at ModuleWrap.<anonymous> (node:internal/modules/esm/module_job:57:40)
     at link (node:internal/modules/esm/module_job:56:36)

Thanks for you help !

Are you sure? Can you try older version?

@felixmosh I am getting this with @bull-board/api: "^4.11.0"
Error: @bull-board/api tried to access @bull-board/ui, but it isn't declared in its dependencies; this makes the require call ambiguous and unsound.

Required package: @bull-board/ui (via<EMAIL_ADDRESS>Required by: @bull-board/api@npm:4.11.0 (via /app/.yarn/cache/@bull-board-api-npm-4.11.0-be42249947-17dc2cd3a4.zip/node_modules/@bull-board/api/dist/src/)

Require stack:
- /app/.yarn/cache/<EMAIL_ADDRESS>- /app/.yarn/cache/<EMAIL_ADDRESS>- /app/src/loaders/express.ts
- /app/src/index.ts

@JasonMan34 the API packages only resolves the path of @bull-board/ui with<EMAIL_ADDRESS>nothing else.

Interesting, yarn start worked for you out of the box in the reproduction repo? It should not by all means
What about with workspaces?
Either way, I don't understand why you wouldn't want to list @bull-board/ui as a dependency of @bull-board/api, when it is in fact a dependency of it. Even if ideally you would only want people using @bull-board/api with @bull-board/express, yarn won't let me do that because of the danger that the crash branch demonstrates

It will create a circular dependency, I've tested the crash branch, and I got the error.
Adding @bull-board/express solved the issue.

oh, I see from your screenshot now that your local code is using node_modules.
I am using yarn's zero-installs system, where the original error I mentioned happens (Even with @bull-board/express and everything, yarn refuses to resolve an ambiguous dependency)
Apologies for the misconfigured repro, I thought that using<EMAIL_ADDRESS>would force pnp module resolution. I've added a nodeLinker: "pnp" setting to the repro, maybe it will happen to you locally now?

I will test asap

@JasonMan34 I'm able to reproduce the issue with pnp, if I'll define UI as a peerDeps of api, will it solve that issue?
Can you open a new issue that describes the issue with pnp?

Listing it as a peerDep should solve the issue
Opened an issue here


Error with MessageFormat and async loading

I have a problem getting MessageFormat interpolation to work when translations are loaded asynchronous.
It seems like MessageFormat is trying to load the language file instead of waiting for Angular Translate to load it.
Error:
Uncaught ReferenceError: Locale no could not be loaded: require is not defined
Plunkr:
http://plnkr.co/edit/AxSZjWaJAtdWzMSOzNji?p=preview

Hi!
This is not directly an issue of angular-translate, but of messageformat - maybe http://stackoverflow.com/questions/19059580/client-on-node-uncaught-referenceerror-require-is-not-defined helps for you.

Hmm, yes. It also seems to fail if the loader is not async:
http://plnkr.co/edit/ZDwPU0I7QBm4WWT3f7WX?p=preview
It works fine if the language is en though.
Anyways, I "solved" my problem by using ngMessageFormat.


FR: Allow overriding HTTP / RPC client target Host, enables Docker bridged networking

The go-chia-libs source seems to indicate the library supports overriding the default client host of localhost via client options: https://github.com/Chia-Network/go-chia-libs/blob/ceada8b288422263b24e855d6604b7504e43df51/pkg/httpclient/httpclient.go#L60
.. However chia-exporter does not provide a flag nor set any client options to provide said overrides. If that option existed it would allow a traditional Docker deployment of running the exporter as a sidecar with bridged networking and providing the address of the Chia container to the exporter. As it currently stands, using host networking on both containers is the only option to allow localhost to point to the right service.

I need to actually go back and double check that we still support that. An early iteration definitely did support this, and then some of the client options got weird with the addition of the websocket support. I think hostname is something that should work in both cases though, so if its currently pulled out, it can likely get added back in as something to support.


Add -c omnia flag

Installation instructions of foyer require -c omnia flag. Without it, antefoyer installation instructions result in conflicts preventing the creation of a conda environment.

@jaclark5 Thank you again. I tested the new instructions last night but of course have omnia in my defaults channel priority list.


Rewrite PyTorch Node

Co-authored-by: Simon-Martin Schroeder
<EMAIL_ADDRESS>
[x] tests added
[x] all tests pass
[x] documentation
[x] AUTHORS entry
[x] Changelog entry

:books: Documentation preview :books:: https://morphocut--106.org.readthedocs.build/en/106/

Hi, thanks for the update! Could you please address my remaining two comments and merge the master branch to resolve the conflicts?

TODO @moi90 : Setup GitHub Actions so that torch tests are executed.

For now, it is the easiest solution that I run the pytorch tests locally and upload the results manually to Codecov.
Current Coverage issues:

autocast is never True
pre_transform is always None
pin_memory is always False

Thanks for your great work!


Added devices datasource

terraform datasource for getting devices enrolled in an account.
Terraform for https://api.cloudflare.com/#devices-list-devices

thanks @suhrit-cf, this is awesome work!


Upgrade discord.py to v1.0.1

Description:
Upgrade discord.py to v1.0.1 to have Discord notify component working again
Related issue: fixes #21374
Checklist:

[X] The code change is tested and works locally.
[X] Local tests pass with tox. Your PR cannot be merged unless tests pass
[X] There is no commented out code in this PR.

If user exposed functionality or configuration variables are added/changed:

[ ] Documentation added/updated in home-assistant.io

If the code communicates with devices, web services, or third-party tools:

[ ] The manifest file has all fields filled out correctly (example).
[X] New dependencies have been added to requirements in the manifest (example).
[X] New or updated dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
[X] New files were added to .coveragerc.

If the code does not interact with devices:

[ ] Tests have been added to verify that the new code works.

Hello @cyrosy,
When attempting to inspect the commits of your pull request for CLA signature status among all authors we encountered commit(s) which were not linked to a GitHub account, thus not allowing us to determine their status(es).
The commits that are missing a linked GitHub account are the following:

27b7494215194b30fda875e33da5551a72bfca36 - This commit has something that looks like an email address (git@cyrosy.fr). Maybe try linking that to GitHub?.

Unfortunately, we are unable to accept this pull request until this situation is corrected.
Here are your options:

If you had an email address set for the commit that simply wasn't linked to your GitHub account you can link that email now and it will retroactively apply to your commits. The simplest way to do this is to click the link to one of the above commits and look for a blue question mark in a blue circle in the top left. Hovering over that bubble will show you what email address you used. Clicking on that button will take you to your email address settings on GitHub. Just add the email address on that page and you're all set. GitHub has more information about this option in their help center.

If you didn't use an email address at all, it was an invalid email, or it's one you can't link to your GitHub, you will need to change the authorship information of the commit and your global Git settings so this doesn't happen again going forward. GitHub provides some great instructions on how to change your authorship information in their help center.

If you only made a single commit you should be able to rungit commit --amend --author="Author Name<EMAIL_ADDRESS>
(substituting Author Name and<EMAIL_ADDRESS>for your actual information) to set the authorship information.
If you made more than one commit and the commit with the missing authorship information is not the most recent one you have two options:

You can re-create all commits missing authorship information. This is going to be the easiest solution for developers that aren't extremely confident in their Git and command line skills.
You can use this script that GitHub provides to rewrite history. Please note: this should be used only if you are very confident in your abilities and understand its impacts.

Whichever method you choose, I will come by to re-check the pull request once you push the fixes to this branch.

We apologize for this inconvenience, especially since it usually bites new contributors to Home Assistant. We hope you understand the need for us to protect ourselves and the great community we all have built legally. The best thing to come out of this is that you only need to fix this once and it benefits the entire Home Assistant and GitHub community.
Thanks, I look forward to checking this PR again soon! :heart:

Hi @cyrosy,
It seems you haven't yet signed a CLA. Please do so here.
Once you do that we will be able to review and accept this pull request.
Thanks!


[Feature] Implement Executor interface

Rather than just being able to submit subprocess calls it would be great to also submit python function calls to an executor, which then executes those in a separate environment.

A first implementation is available at https://github.com/pyiron/pympipool/pull/251


Use GitHub public api to fetch usernames

Use GitHubs public api to fetch usernames instead of scraping a whole page for it.

We intentionally didn't do this as the API is rate limited.

Err! My bad. GitHub has a mere 60 public requests per hour limit. Closing this.

I wouldn't mind getting a token and pasting it the extension's options. OctoLinker and others do it.
GHE seems to support it under /api: https://developer.github.com/v3/enterprise/

@bfred-it That would work. With a personal access token, limit extends to 5000 per hour.
The way I think about it is:

If a token is available through settings then use it

If location points to GitHub use api.github.com endpoint else
use the location to get the GHE API endpoint

If token is not available then use the scraping method.

Seems fair to me.
@sindresorhus What do you think?

If we use an API I token anyways, I suggest using the new Graph API instead

@bfred-it Why complicate and change something that already works fine? 5000 can easily be used up too if you browse many long discussions.

If we want to go all nuts with that we can just fetch ~10 usernames and only when you scroll to get more :)

Why complicate and change something that already works fine?

We don't necessarily need to change old things, but new features could take advantage of faster speeds. But if GHE ends up being a problem it may not be worth it. Also definitely against having both methods in as described in https://github.com/sindresorhus/refined-github/pull/581#issuecomment-313436331

5000 can easily be used up too if you browse many long discussions.

Caching avoids that

I would be happy if @bfred-it s webext-option-sync had support for text fields.

It does

but new features could take advantage of faster speeds

But the speed is not currently an issue. Nobody has complained about it.

I just don't see the downsides being worth the slight, but pretty unnoticeable upsides.

Is any one having issues with loading real user names on a fresh install of plugin?

I see issues with the cached names (which for a fresh install the cached names object is undefined).

@ramlmn unrelated.

off topic

@bfred-it Sorry, didn't know where to ask.

Closing and moving discussion to #585.


Feature/ssr serverside rendering nuxtjs

when using serverside-rendering with nodejs and nuxtjs for example there is a problem with the PolyFills.js and using "self". The context there doesn't have "self". Add this one line to fix the issue.

My build still doesn't work, so i guess i wait with the PR and renew if needed


Pods automatic update

Description
This PR adds the automatic update of pods every 30 seconds, so there is no need to refresh the page to show when pods are added/deleted from a cluster.

/rebase

ref. #19


dbeaver/pro#3306 [SUB] Fix data filters in Neo4j

Insert attributes by ordinal position

Fixed issue with ordering document type attributes.


Clue Helper - Falo Master Clue doesn't show Bow of Faerdhinen (c) as valid

Type
Incorrect behavior
Operating System
Windows
OS Version
Windows 10
Bug description
The Falo The Bard clue for showing him "A bow of elven craft was made, it shimmers bright, but will soon fade." shows only a crystal bow as a valid answer, but I gave him a Bow of Faerdhinen (c) which was also accepted. According to the wiki, both are accepted for this clue step.
Screenshots or videos
No response
RuneLite version
RuneLite version: 1.10.14
Oldschool revision: Rev 217
Launcher version: 2.6.7
Logs
No response

Would be fixed by #16887


Curried interface functions only return single interface type

As seen in the test code below the function newTest only accepts a number value, even though the interface says it should accept number or number[]
var _ = {
	curry: (fn: Function) => {return fn}
}

interface Test {
	(val: string, num: number): string
	(val: string): (num: number) => string
}

var test = <Test> _.curry((val: string, num: number) => {})

interface Test2 {
	(val: string, num: number[]): any // {} with any properties
	(val: string): (num: number[]) => any
}

var test2 = <Test2> _.curry((val: string, num: number[]) => {})

interface Test3 extends Test, Test2 { }

var test3 = <Test3> _.curry((val: string, number: number | number[]) => {})

var newTest = test3('')
newTest([1, 2])  //fails
newTest(1)        //succeeds

You've explicitly type-asserted that test is of type Test3. There are no overloads of Test3 that take a string[] as a first parameter.

I extend Test and Test2 which accept a string not string[] as the first parameter and then accept a number or number[] as the second parameter. But TypeScript only accepts the first one, number.

newTest should have type (num: number): string or (num: number[]): any, but newTest only has type (num: number): string

@RyanCavanaugh I see the confusion now. I updated my original question to reflect the actual code. Sorry about that. Aargh!

Sorry, I misread the code as well.
The "flattened" version of Test3 is this:
interface Test3 {
    (val: string, num: number): string
    (val: string): (num: number) => string
    (val: string, num: number[]): any // {} with any properties
    (val: string): (num: number[]) => any
}

The invocation of test3('') selects the first applicable overload, which returns (num: number) => string
There's no logic in the type system that says "If you see multiple matching overloads, union the return types". I'm not sure that that has any analog in the real world. We always use the rule that the first applicable overload is the one that gets used.

It doesn't make sense to only accept the first function return value since it hasn't been decided which function type is being used yet. It doesn't work with polymorphic, curried functions. Which is the real world, since I am programming this for a real application.

Just so you have an idea of how I'm using this code. I am parsing xml callbacks. I use the first argument to get the xml base to loop through the xml document. The second argument is the xml string. The third argument can be multiple values, if I just want the value from the xml document I pass a string, if I want a value as an object I pass an array with the object key string and the xml key, if I want multiple values I pass and array of arrays and return an object.
So, the first two values are the "settings" and I don't want to repeat it, so I curry the function. I then can access the xml document easily. JavaScript is a functional language, in addition to its object orientation. So, I think it would make for sense TypeScript to embrace more of its functional abilities. If we say that we only return the first rather than the union of types then we are poo, pooing JavaScripts functional and polymorphic sides.

I'm all for functional things, it's just that the type system has to have rules and it's really not clear that a rule that says "combine the overloads of multiple matching return values" is a good idea. A function only returns one thing; it doesn't make sense to say "This function will return one of two things based on things that happen later".
If you really want Test3 to work that way, you'll have to write the overload set out yourself.

Yeah, that is what I ended up doing. I don't know all the internals of how TypeScript works and the hurdles it would have to overcome and headaches it would cause to make it work, so I'll just accept your answer, although, it is a bit frustrating to have to repeat myself over and over on the interface side, it doesn't seem intuitive to me.
In a sense the function is only returning one thing, an overloaded function. A function is one thing, yet it can have multiple types, in JavaScript at least. So, still not making sense to me why that would be a design decision we we are allowing polymorphic functions to begin with.


CPL File

Hi, can you add the CPL? I need it for JLCPCB
There's a sample https://jlcpcb.com//video/JLCSMT_Sample_CPL1.xlsx?_ga=2.19650808.1931900423.1650716192-1476452342.1648375495&_gac=1.16912331.1650716192.CjwKCAjwx46TBhBhEiwArA_DjEUBKml_yAA1PaGkPxgTZW3rSurY9-y1C894mUQ6OZ8IGE_1M7f6yRoCqXoQAvD_BwE

I'm sorry, I was very busy and I didn't get to answer you earlier. I will add a CPL file in the coming days.


Local apps

implies npub shares their geo/location
related to
categories of apps https://github.com/zapstore/zapstore/issues/48

What apps/users are you targeting first?
For security/platform apps; not useful, bad opsec.
For restaurants, local ride share, event venues; excellent.

What apps/users are you targeting first?
For security/platform apps; not useful, bad opsec. For restaurants, local ride share, event venues; excellent.

Mostly this. You land at some country/state and would be great to see the most popular local apps for other users on that region. Of course this would only be available if the user agrees to share the app info with zap.store


Bad WriterInterface implementation

AbstractWritter::setFormatter($formatter, array $options = null) does not conform WriterInterface::setFormatter($formatter).
Changed WriterInterface and all descendat subclasses.
Tests has the same result as master.

@naprstek Duplicate of #79, but here I can see more changes

This is a BC break due to how php 7.2 handles addition of optional parameters to interfaces and overriden parents methods.

@naprstek can you register php 7.2 to .travis.yml file ?

file updated (hope it is correct).
V.

S pozdravem
Vladimír Náprstek
2018-04-09 19:14 GMT+02:00 Abdul Malik Ikhsan<EMAIL_ADDRESS>
@naprstek https://github.com/naprstek can you register php 7.2 to
.travis.yml file ?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/zendframework/zend-log/pull/86#issuecomment-379826283,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ANnqDK9qZ18RTgFEIKeBX1g6K6uEO8Oeks5tm5brgaJpZM4TLbtR
.

the zend-validator requirement at composer.json seems need to be upped to version at least 2.10.1 which fixes the idn_to_utf8() error at php 7.2 environment. Once it updated, composer.lock need to be updated by run : composer update --prefer-lowest --prefer-stable and commit it. /cc @webimpress  if any better suggestion

needs rebase

@naprstek I've rebased for you, and incorporated the changes I suggested.

THanks, @naprstek!


Disabled in the configuration file.

Hi guys, I am using this bot for the first time. I get the following error after putting my settings into the config file and starting the ArchiSteamFarm bot app.
''We can not start this bot instance because it is disabled in the configuration file.''
Thanks for helping!**

please refer to the wiki and read it. wiki

then read again, because your issue can be resolved VERY easily

I solved the problem myself thanks.
(Enter the config file then click your .json file, open it notebook and change false values to true)

then you didn't read because you didn't need to change all false values

also it could impact asfs behaviour against your will

and please close the issue if it's resolved.

Hey there! Thank you for contacting our development team at GitHub.
We believe that your issue does not meet our contributing guidelines referenced during issue creation.

Before you open an issue please review the contributing guidelines for this repository.
(...)
I understand that if my issue is not meeting contributing guidelines specified above, especially if it's a question or technical issue that is not related to ASF development in any way, then it will be closed and left unanswered.

Reason for closing: this question is not related to ASF development in any way.
Please check out our wiki if you need further help.
Have a nice day!
~Archi


Added Hello World for TrumpScript - Closes #155

It's time to make python great again :laughing:

Just added the issue!


Datacite client

DoiClient interface which abstracts away the details for communicating with a Registry Agency for working with DOIs.

It currently lacks test coverage for the logging that being done for errors in DataciteClient and tests covering errors.

I could need some help to get past https://app.codacy.com/gh/BIBSYSDEV/nva-doi-registrar-client/pullRequest?prid=6483195 issue. :(

Please resolve open issues.


Add compatibility for Django 4.1 and Python 3.10

Djangop 4.1 has been released for a bit now. Add it to the build matrix and declare supprot for it.

tried to add Python 3.11 but apprently there is no image?

LGTM, thanks.

@browniebroke released at 1.8.0: https://github.com/django-webpack/django-webpack-loader/releases/tag/1.8.0


negated types via Not operator based on conditional types

there is no clear answer as to what extent the conditional types can be used to for modeling negated types,

from what i know Not can be just something that flips the extends constraint:

type Not<T, U> = T extends U ? never : T;

it's not as clear when it comes to a complementary type to the given one Not<U> like in https://github.com/Microsoft/TypeScript/issues/22375

so can negated types (as described above) be modeled with conditional types or it takes some additional machinery?

By 'complementary type' do you mean something like: Complement<T> that returns the type of all values not in T?

if you look at Complement<T> just as like a negated expression of T (not yet evaulated!) it would be much easier to wrap your head around it

I think some of the scenarios that would need negated types should be now possible with conditional types.. but it does not address all of them.. negated types is still a feature on its own that is not supported today, specially when it comes to reasoning about infinite sets, like number - 0 and how that relates to narrowing.
Some of the things you can do today are adding constraints on type parameters to ensure they are not a specific type like #22375, or using intersection types e.g.:
type NotPromise<T> = T extends Promise<any> ? never : T;
function f<T>(a: ()=> T & NotPromise<T>) { }

f(() => { }); // OK
f(async () => { }); // Error

@aleksey-bykov, do you want me to mark this issue as a suggestion for negated types?

closing in favor of any of the following:

negated types #4196
allow negated types + F-bounded mapped type #18280
negating type constraints #7993


sqlalchemy 2.0.4 error when using process.extract

Hi,
When I have SQLAlchemy 2.0.4 installed in my venv, and I run my process.extract, I see this error:
  File "lib/sqlalchemy/cyextension/resultproxy.pyx", line 67, in sqlalchemy.cyextension.resultproxy.BaseRow.__getitem__
TypeError: tuple indices must be integers or slices, not str

However, if I rollback the SQLAlchemy version to 1.4.46, there is no error.  Everything works fine.
my process.extract statement looks like this:
for data in filtered_data:
    result = process.extract(data['name'], data_df.name, scorer=fuzz.WRatio, score_cutoff=score_limit)

Its within a loop of the values for 'data' that are the result of a SQLAlchemy query, and data_df is a pandas dataframe of values that were populated by another/different SQL Alchemy query.  e.g.
data_df = pd.DataFrame(some__other_query, columns=['id', 'name'])

Do you have a minimal reproducible example I can just copy and run?

Apologies.  In the process of creating a smaller running example, I answered my own question.
It turns out this is a SQLAlchemy migration bug, that just appeared in this process.extract, and doesn't have anything to do with rapidfuzz.
With SQLAlchemy 2.0.4, you need to use this format:
for data in filtered_data:
    result = process.extract(data.name, data_df.name, scorer=fuzz.WRatio, score_cutoff=score_limit)

i.e. data['name'] must change to data.name
I hope this helps someone else that runs into the same problem.


Add quad mesh to material preview

Implements and closes https://github.com/godotengine/godot-proposals/issues/10744.
Adds a quad mesh with 0.0-1.0 UVs to the material preview panel, useful for previewing VFX, foliage shaders, or any time you want to test something out in the 0.0-1.0 UV space.
With this PR:
A quad mesh is available in the material preview.

Works in the visual shader editor:

With a quad mesh, there are some extra usability considerations. Unlike the sphere or box mesh, with backface (default) culling, the quad is only visible from some angles. It's possible to rotate the quad such that you cannot see it. I believe this is a valid usecase, as you may be testing double-sided materials. I don't believe that limiting the rotation, or forcing a double sided quad is the correct solution. Instead, whenever you select the quad mesh, the rotation resets to 0 so you can see the quad.
Alternately, we can clamp the rotation so that the quad is always visible. There is already clamping code, so we just need to change the maximum angles based on the current preview mesh.
Icons:
I created icons in the same style as the existing ones, 16x16px with a 1px black border. I'm not sure if I need to optimize these, I started from an existing icon and used inkscape to edit.
SVGs:
Currently used is a 14x14 sideways perspective quad. I think making it a little smaller keeps the aspect ratio closer to square. The total filled area is in line with the sphere and cube. Like the cube and sphere, it has a hint of perspective.

Alternates:
16x16 square:
Topdown perspective:
Side Perspective, 16x16:
In the editor:
16x16 square:

Topdown perspective, 16x16:

Sideways perspective, 16x16. This is a little bigger than the current icon.

After thinking about it some more, maybe the quad's rotation should be clamped so it's always be visible (assuming you have default backface culling). Testing backface shaders is enough of an edge case that it can be done with the current workaround of previewing with a scene, and usability would be improved in most other cases if the quad rotation is clamped.

For some reason the quad is rotated when the preview is refreshed:
https://github.com/user-attachments/assets/2df58c0e-2a3e-4f23-bebf-4f93493566c9

The rotation resets when changing the material on 4.3 already. But because the quad has a different default rotation than the cube and the sphere, it's more noticable with this PR.
https://github.com/user-attachments/assets/dc607e66-d43f-47a4-aaad-cb9590b6ed83
I'll at least reset to the correct quad rotation, and also look into improving the existing behavior. Switching seamlessly between materials and keeping rotation seems like a useful feature.

Billboarding doesn't really look good in the preview, which is unfortunate. This could in theory be special-cased for standard materials,  by changing the viewport's camera for billboarded shaders. But you can't easily test if a shader material is billboarded.

The more robust solution (not for this PR) might be some kind of zoom feature for the material preview.

Pushed an update. Now the rotation is clamped to ~80 degrees on both axes. The rotation is remembered when switching materials or closing the editor. You can reset the rotation to default angles by changing the mesh preview type.
https://github.com/user-attachments/assets/766427e5-8dc1-4139-a25c-f0ea755d694a

Made the icon 1px taller, so the aspect ratio looks more square. Also optimized the svg.

I think there is some work left from the other reviewers, but from a usability point your proposal makes sense to me and is a good enhancement.

I'm aware of one edge case behavior. If you have open both a material in the inspector, and a preview in the visual shader editor, and you rotate the visual shader preview, then navigate to the previously selected material in the inspector, you get a visual jump in rotation.
This is a side effect of remembering the rotation, and storing it in a single project metadata. This is fixable if we either write separate rotation values for different previews, or we reset the rotation every time the material changes instead of remembering the rotation. IMO remembering the rotation is a good feature improvement, and storing individual rotations for the visual shader preview and the inspector preview may not be worth the extra code.
https://github.com/user-attachments/assets/ae4a8261-e08d-499b-a891-d5970defd36f

Made the quad size bigger. It's now the same size as the sphere, 0.375, exactly 1.5x as big as it was.

For a later PR: The preview in the visual shader is nicely resizeable. We should see if that can be implemented in the inspector version, too.
https://github.com/user-attachments/assets/48f89371-17c9-4a16-ac4b-0ce8cb729879

Thanks!


⚠ Thumbnails API Endpoint has degraded performance

In ee65479, Thumbnails API Endpoint (https://thumbnails.roblox.com/v1/assets?assetIds=82738847&format=Png&isCircular=false&size=30x30) experienced degraded performance:

HTTP code: 200
Response time: 5407 ms

Resolved: Thumbnails API Endpoint performance has improved in 1baadf1 after 13 minutes.


Bind events to document only for the first grid added

This avoids to bind the same event to document multiple times.
This can be done by adding this line before binding events.
if (Object.keys($.fn.jexcel.defaults).length == 1)
or if you don't want to put the code in the big if you can do this when binding the events:
$(document).off('keydown').on('keydown', function(e) {     // put your logic in here    });
This fixes a bug you can reproduce by adding and destroying grids in the same view. and keeps the same logic used when unbinding the events

All bind happens only if the CORNER element does not exists, so should be executed only once.
Line: 515
if (! $('.jexcel_corner').length) {
}


Wrap creation of CryptoConfig in a constructor 'Init'

Signed-off-by: Stefan Berger<EMAIL_ADDRESS>

@crosbymichael This patch attempts to clean up the creation of the CryptoConfig in various places and we could use it for the next PR to have functions WithCryptoConfig rather than WithDcParameters, if this helps.

LGTM


Update README.md

I would've have accepted this but rejecting it because of your toxic comments in other user's Pull Requests


Add a way to identify gold members

There needs to be a way to identify which members have paid for a gold membership.
The MVP for this issue would be to be able to identify who our gold members are. Bonus points if we can can figure out a way to also identify companies with a corporate gold membership.

Below is a suggestion I received from Toni regarding how we could handle the corporate gold membership:

I think maybe we could just add a gold or green leaf icon as a designation and then put somewhere on the page, or create a link, that explains green = business member, gold = professional member.

Talking with her I think it would be a good idea to have a FAQ page and have one of the questions/answers explain the leaf colors. The biggest challenge with this suggestion will be figuring out how to match up the user's company with what we will be storing in the database.

Per discussion with Toni we are no longer going to have a gold/elite membership. Closing this as no longer relevant.


AnimatedSquareToCircle is not in the script?

PS C:\Users\G\Files\Project\Code\temp> manim -pqh scene.py AnimatedSquareToCircle
Manim Community v0.14.0
[11/25/22 14:37:51] ERROR                                                                                module_ops.py:88
AnimatedSquareToCircle is not in the script
[11/25/22 14:37:53] INFO     Animation 0 : Partial movie file written in                                               scene_file_writer.py:514
'C:\Users\G\Files\Project\Code\temp\media\videos\scene\1080p60\partial_movie_files\Create
Circle\450974505_4049512628_1793580042.mp4'
[11/25/22 14:37:55] INFO     Animation 1 : Partial movie file written in                                               scene_file_writer.py:514
'C:\Users\G\Files\Project\Code\temp\media\videos\scene\1080p60\partial_movie_files\Create
Circle\34786186_596079725_1793580042.mp4'
[11/25/22 14:37:57] INFO     Animation 2 : Partial movie file written in                                               scene_file_writer.py:514
'C:\Users\G\Files\Project\Code\temp\media\videos\scene\1080p60\partial_movie_files\Create
Circle\34786186_1566666130_1793580042.mp4'
[11/25/22 14:37:59] INFO     Animation 3 : Partial movie file written in                                               scene_file_writer.py:514
'C:\Users\G\Files\Project\Code\temp\media\videos\scene\1080p60\partial_movie_files\Create
Circle\34786186_379839975_1904605041.mp4'
INFO     Combining to Movie file.                                                                  scene_file_writer.py:608
INFO                                                                                scene_file_writer.py:729
File ready at
'C:\Users\G\Files\Project\Code\temp\media\videos\scene\1080p60\CreateCircle.mp4'
                INFO     Rendered CreateCircle                                                                                scene.py:237
                         Played 4 animations

[11/25/22 14:38:00] INFO     Previewed File at:                                                                                file_ops.py:202
'C:\Users\G\Files\Project\Code\temp\media\videos\scene\1080p60\CreateCircle.mp4'

Define a class name by command.


Add ORM

Basic ORM of User, Course, Lecture.
Add utils for creating database & db manipulations

Thanks @TalSk for this code contribution!


fix: bypass initial page requests

Recreating https://github.com/valendres/playwright-msw/pull/46 on behalf of @SetupCoding since the PR was automatically closed when deleting the target branch.
TODO:

[x] add test case to reproduce the issue (🙏 @SetupCoding)
[x] address the root cause

@SetupCoding, I finally got around to implementing this. Sorry for the delay!
I've added a waitForPageLoad boolean flag (defaults to false) that waits for the page to load before mocking API calls. When enabled, it allows playwright-msw to mirror the behaviour of msw when it is running in the browser, where the initial static resource requests will not be mocked because msw will have only been initialized until after page load.
A couple of things I'm uncertain about are:

should this be the default behavior? if so, will changing the behavior negatively impact those already using the library?
does waitForPageLoad make sense, or is there a better name?

@valendres  thank you very much for taking the time! No need to apologize!
Yeah I do believe that it should be the default behavior and I think there is no impact on the people who are already using the library.
Another test that should be added - to ensure that there is no impact - might consist of the following scenario:

A frontend route localhost:3000/list  where a list of items is being fetched e.g. inside a useEffect.
A backend route mocked with rest.get(*/list, ...)

Then for the test somethign along the lines of:
test('should not mock initial page request', async ({
    page,
    worker,
  }) => {
    await worker.use(
      rest.get('*/list', (_, response, context) =>
        response(context.delay(250), context.status(200), context.json([1,2,3,4]))
      )
    );
    await page.goto('/list');

    // expect page to be loaded - e.g. some heading should be visible
    // expect items to be fetched and displayed successfully e.g. list is visible and has 4 items
  });

waitForPageLoad sound good to me.
Maybe also something like: startWorkerAfterPageLoad, passthroughPageLoadRequest,.
Again: Huge thanks for taking the time!
I am based in Germany so sorry for replying so late :)

@SetupCoding making this the default behavior makes sense to me. I've updated the default config to reflect this.

Another test that should be added - to ensure that there is no impact - might consist of the following scenario:
A frontend route localhost:3000/list where a list of items is being fetched e.g. inside a useEffect.
A backend route mocked with rest.get(*/list, ...)
...

I think I might be misunderstanding something here, but I believe that's what the original test that you wrote does. It loads a frontend route /search and performs a GET /api/search to load search results. With waitForPageLoad set to true, it does not mock the initial page route as desired. Whereas, when waitForPageLoad is set to false, the initial page route will be mocked and the subsequent GET /api/search will not be performed. I have added a test for this second scenario.

Well, the original test that I wrote only ensures that the page is being loaded and the initial page response is not overridden by the service worker.
With the second test I wanted to ensure the same and additionally test that any subsequent requests that happen (e.g. in a useEffect) when a component is mounted (as part of the initial load of the page) are correctly mocked.

Well, the original test that I wrote only ensures that the page is being loaded and the initial page response is not overridden by the service worker.

@SetupCoding Woops, I don't know how I missed this. My bad! Thanks for clarifying what you meant. I've added some tests to make sure that subsequent API calls are still being mocked as expected.

Perfect! :D


[FEEDBACK] How to donate money via Github?

I like to donate a small token of appreciation of those Repositories I'm using.
The Github payment function is for me quite neat for that.
Do you want to enable that functionality here?
https://github.com/sponsors

Hi @Robert-Ernst - that's super kind of you, thank you so much!
I've created a sponsor profile: https://github.com/sponsors/Lissy93

Thank you so much @Robert-Ernst - Very kind of you ❤


Zenodo DOI

currently blocked by non-open and license issues

It needs an Anaconda API token...

Done


Add Enable tips parameter

This PR provides a new parameter, enable_tips.
This way, it is not always necessary to support the tip concept.

@faddat thanks for opening this!
Could we add some tests to x/feemarket/post/fee_test to verify that this behavior is working as expected?

Absolutely, id be very happy to!

So it seems the conditional adds 18 gas -- next commit fixes existing tests.... (by adding 18 gas to them)

@aljo242 - I think this is good to go.  Only thing I am unsure about right now is if I should make 18 a constant, continue to use it as a bare number, or something else

@faddat we are not going to be adding any features to feemarket for the time being. The project is going to be upstreamed into the mainline cosmos sdk soon along with an audit

thank you so much for this.
Do you have any suggestion on how to test for this? Because another thing that we learned here is that the tests that I wrote are probably not good enough.


Removes max damage threshold on healing for hyperzine

About the PR

Removed the max damage threshold that limits the ability for Hyperzine to heal if a person goes beyond 120 total damage
Why / Balance

I was asked to do it by an admin but besides that, this makes hyperzine easier to use for antags without making it an effective healing option over other chems
You still only get healed to the point of having 70 damage total regardless of how much hyperzine you have in you and at which point you still need other healing options. The only difference now is you don't need to be super precise when you're injecting it into someone and worrying about whether or not they took just enough bloodloss or asphyxiation damage to go above the 120 threshold to benefit from Hyperzine's tiny bit of burn/brute heals which is basically what happens every time.
It doesn't even heal asphyx or clot bleeding so it's not going to replace other options by any means.
Media

[x] I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Changelog

:cl:

tweak: Hyperzine's effective healing range has been changed from 70 to 120, to anything above 70 total damage.

I requested this as a potential buff to a very underused chem that is barely used.


Add build step to check the behavior on OpenJ9 (Java 11)

Not sure it works... We would need to test that it can retrieve the right openjdk build

it does work :-)


How to rotate a chart arc in version 1.0 as like version Chartjs 2.0.

I am looking for a chart rotation  option in chart js 1.0.1 version for IE8 support.The chart arc rotation start from bottom center . Here is the code working with chart js version 2 use rotation option.
Chart js 2 example
  rotation: (-0.5 * Math.PI) - (Math.PI).
How to do that with chart js 1 : version 1
https://codepen.io/balix/pen/XXwBpW

This ain't a "How To" section.
You'll have better luck getting a solution on forums like StackOverflow.

@MohamedSahir that option was not available in v1.


WIP - Add production chains feature and CLI, etc

Alrighty, this has been a long time in the making. Lots of stuff in this PR, this is mostly for posterity but I'm always open to input!

In the evedb package, fixed GetRegion and added Description field to ItemType struct.

Changed the market stat fetching method signatures in model to require at least one typeID. This change enforces that at least one typeID is being passed at compile-time, instead of a runtime error.

Added app package into which I moved all the general tomfoolery related to initializing all of the motki magic.
The use-case is as follows: I find myself making lots of dummy apps where I copy and paste all that giant init code to mess around with various things, always needing to deal with changes and minor, but annoying, inconsistencies that naturally get introduced over time. So I put the One True version of the complete motkid suite of service initialization logic in its own package.
One decision I made here was making the app package import every other motkid package. This is to prevent any possible abuse of the ungodly thing-- only external packages can use it. And now there's two examples of how external packages can use the app package! (those being the motki and motkid commands)

Added motki command line interface, it's super neat.
It behaves as a sort of interactive shell, with commands and subcommands and all that. For example, to search for an item, you would do something like
> types search invuln

which spits out something like
Found 18 items.

Type ID     Name
578         Adaptive Invulnerability Field I
2050        Gistum C-Type Adaptive Invulnerability Field
2281        Adaptive Invulnerability Field II
etc

and its liek, totally flexible too. For example:
> types search
Specify search terms: invuln
Found 18 items.

Type ID     Name
578         Adaptive Invulnerability Field I
etc

Commands implemented right now: item types search and display, production line listing, creation, editing and so on, and built in help text which is fairly complete.

And the fun stuff, production lines or chains or products, whatever. Not sure what to call them! Supply chains? Production chains?
These are the first iteration on automatically determining overall cost for a given manufacturing job. It's pretty simplistic right now, able to specify either "buy" or "manufacture" for a given component, and fetching market prices from whatever region.
I sort of got carried away with the product command in the CLI, but it's really cool. I have a git add --interactive style chain editor that shows prices and its all nicely formatted and lined up. The code is quite messy, however. I need to go through and straighten out all the random integer constants and overall formatting. I've added several printing helper functions that could be a good base for something more standard across the CLI. These could probably be improved as well-- there's also a couple of issues with them I believe, see todos below.
Here's the product command "help" text:
> product

Command "product" can be used to manipulate production lines.

All production lines used here have the corporation ID of 0, and are therefore
not accessible by normal means.

When invoking a subcommand, if the optional ID parameter is omitted, an
interactive prompt will begin to collect the necessary details.

Subcommands:
  view [typeID]        Preview production lines for a specific item type ID.
  add [typeID]         Create a new production line.

  list                 List all production lines for corpID 0.
  show [productID]     Display details for a given production line.
  edit [productID]     Edit an existing production line.

and the aforementioned interactive editor:
> product new

Specify Item ID: 440
                             5MN Microwarpdrive II
                                    Domain

 #  Material Name                         Cost/ea    Qty Req         Cost/unit
 1  Tritanium                                5.64      3,967         22,373.88
 2  Pyerite                                  5.77      2,131         12,295.87
 3  Mexallon                                77.10        228         17,578.80
 4  Isogen                                  50.01         13            650.13
 5  Nocxium                                384.98          2            769.96
 6  Morphite                            11,646.86         17        197,996.62
 7  Plasma Thruster               M     49,891.10         24      1,197,386.40
 8    Fernite Carbide                      170.00         13          2,210.00
 9    Phenolic Composites                1,894.08          3          5,682.24
10    Ferrogel                          41,998.86          1         41,998.86
11  Ion Thruster                  M     50,078.82         15        751,182.30
12    Crystalline Carbonide                184.44         13          2,397.72
13    Phenolic Composites                1,894.08          3          5,682.24
14    Ferrogel                          41,998.86          1         41,998.86
15  Antimatter Reactor Unit       M    160,780.47          8      1,286,243.76
16    Tungsten Carbide                     197.83          9          1,780.47
17    Fermionic Condensates             79,500.00          2        159,000.00

                                    Per Unit:        Revenue      4,962,889.12
                                                        Cost      3,486,477.72
                                                      Profit      1,476,411.40
                                                      Margin      %      29.75

* 'M' indicates the component will be manufactured in-house.

Specify operation [Q,S,V,U,R,M,?]: ?

The production line editor is an interactive viewer and editor for managing
arbitrary production lines. Individual components can be tagged as either "buy"
or "manufacture", with cost projections updating accordingly. The target market
region can also be modified for the production line as a whole.

When invoking a tool and omitting an optional parameter, an interactive prompt
will begin to collect the necessary information.

  S       Save the current production line and exit the editor.
  V       View the production line details.
  U       Update market prices.
  R       Set the market region for a production line.
  M [#]   Set the production kind (buy or manufacture) for a specific line item.
  Q       Quit the editor without saving changes.
  ?       Display this help text.

Specify operation [Q,S,V,U,R,M,?]:

Installing the CLI app
You'll need motkid setup, with postgres connectivity and an eve developer account (see https://github.com/motki/motkid/blob/master/README.md)
Then:

go get -u github.com/motki/motkid/...
your $GOBIN should now contain both a motki and a motkid program. motki is the interactive CLI.
Run motki

TODO

[x] biggest issue: "production lines" needs a much better name. it's clearly nonsensical
going with "production chains"

[x] second biggest issue: I WANT TERMCOLORS MAN

[x] need another tidy up pass: product and all of the CLI

[x] add support for region lookup

[x] finish the production kind (buy or manufacture) handling

[x] solidify the exit signal handling, not happy with how messy it is in the motki command.

[ ] docs, or somethign idk

[x] clean up CLI text printing, I am pretty sure that padTextLeft or padTextRight is adding or forgetting a space.

[ ] maybe think about standardizing the use of wrapText or something
[x] and the random fmt.Println()s everywhere is annoying af

[x] also think about implications of allowing the user to specify an identity so that the CLI can use a real corpID and get your skills and all that.
but I have some reservations:

For example, if someone signs up on the MOTKI website and link their characters, I'm sure they would prefer I not impersonate them from this neat CLI. But then again, I'm not sure any code I write will deter abuse-- I would like to try to prevent it.
So I think straight up specifying your username and password when starting the CLI, which then loads your user as normal, which would neatly allow for integrating corporation- and character-specific calculations.

With only docs left to do, I'm merging this. Cause yeah, liek, who needs docs amirite


updating master

Codecov Report

Merging #242 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #242   +/-   ##
=======================================
  Coverage   97.09%   97.09%
=======================================
  Files          45       45
  Lines        1444     1444
  Branches      165      165
=======================================
  Hits         1402     1402
  Misses         41       41
  Partials        1        1

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 661bd21...ab818a5. Read the comment docs.


Feature-resize-large-images (prod)

PR checklist:

[x] Changes previewed and QC'ed
[x] In PR, mention team member for FYI, review, or approval

New content (if applicable):

[ ] Date updated
[ ] Tags and keywords updated
[ ] Feature box updated

New data (if applicable)

[ ] Added to Recently Updated
[ ] Added to 311-crosswalk

@mmontesanonyc Moving our large images from static to assets so that we can resie them. Inspired by the 4.1MB featured image on the home page.

Also reduces the data transfer required to load the home page from ~14.5MB to 4.0MB.

Thanks - good call on this.


Uncaught RangeError: Maximum call stack size exceeded

Whenever I set search: true it causes this error.  I have reason to believe that because my page is so large, there is a parsing issue that occurs which breaks search functionality and therefore the left sidebar of navigation/table of contents never shows and this error results on console output.

Just tried this on a massive page and couldn't reproduce. It's been a while since this bug has been reported, so assuming you don't have the file in question any more? @niftylettuce
Closing now, but if it's still a problem, feel free to reopen.


Think about to fix the issues found by adapter checker

I am an automatic service that looks for possible errors in ioBroker and creates an issue for it. The link below leads directly to the test:
https://adapter-check.iobroker.in/?q=https://raw.githubusercontent.com/ioBroker/ioBroker.ham-seasons

[ ] [E301] Tests on Travis-ci.org are broken. Please fix.

I have also found warnings that may be fixed if possible.

[ ] [W113] Adapter should support compact mode
[ ] [W400] Cannot find "ham-seasons" in latest repository

Thanks,
your automatic adapter checker.

Do you need help fixing the bugs?


Using "filter" flag seems to include filtered files

Hiya, thanks for such a useful tool!
I have a directory which contains third-party code at "./utils/libraries"
There is a primary includes.h file which contains:
#include "utils/libraries/imgui/imgui.h"
#include "utils/libraries/FOOBAR"
// etc

When I run the following:
# Pipe every .cpp file not in "./utils/libraries" into "cpp-amalgamate"
$ find . -path ./utils/libraries -prune -o -name "*.cpp" -type f -print | \
  xargs cpp-amalgamate -v --filter "utils/libraries/**" -o hunt_amalgamated.cpp -d "./"

I get:
[INFO ] Writing to "hunt_amalgamated.cpp"
[INFO ] Processing source file "entity.cpp"
[INFO ] Processing "entity.cpp"
[INFO ] Processing "includes.h"
[INFO ] Processing "imgui.h"
[INFO ] Processing <OTHER THIRD-PARTY LIBRARIES>

And the source in utils/libraries is inlined into the amalgam.
Do you know what I am doing wrong?
Thank you!

Hi,
the filters are applied to the absolute path of the include not the relative one specified in the #include "...", so it should probably work if you change it to --filter "**/utils/libraries/**.
I'm not super happy with how it works right now, a filter like yours should just work. When I last tried to come up with a version of filter that works both the relative & absolute path it quickly became way to complicated and wasn't really intuitive either. I should probably revisit that topic at some point.
I hope that fixes your problem (if not, let me know), and thanks for using this, I'm glad it's useful for someone besides just me 😄.

Ohh, understood, thank you!

When I last tried to come up with a version of filter that works both the relative & absolute path it quickly became way to complicated and wasn't really intuitive either. I should probably revisit that topic at some point.

Maybe something like this?
use std::env; // for getting CWD

impl InliningFilter {
    pub fn should_inline(&mut self, path: &Path, is_system: bool) -> bool {
        let base_path = env::current_dir().expect("Failed to get current directory");
        let (set, infos) = if is_system {
            (&self.system_set, &self.system_infos)
        } else {
            (&self.quote_set, &self.quote_infos)
        };
        check_should_inline(path, set, infos, &mut self.indices, &base_path)
    }
}

fn check_should_inline(
    path: &Path,
    set: &GlobSet,
    infos: &[GlobInfo],
    indices: &mut Vec<usize>,
    base_path: &Path, // Add a parameter for the base path
) -> bool {
    let relative_path = if path.is_absolute() {
        path.to_path_buf()
    } else {
        base_path.join(path)
    };

    let candidate = Candidate::new(&relative_path);
    let log_name = debug_file_name(path);
    set.matches_candidate_into(&candidate, indices);
    if let Some(&idx) = indices.last() {
        let glob_str = &infos[idx].str;
        if infos[idx].inverted {
            debug!("Inlining {:?} (cause: '{}')", log_name, glob_str);
            true
        } else {
            debug!("Not inlining {:?} (cause: '{}')", log_name, glob_str);
            false
        }
    } else {
        debug!("Inlining {:?} by default", log_name);
        true
    }
}


Only build picosystem hardware test for picosystem

Running it on non-picosystem things can result in some brokenness due to the GPIO stuff. (Make me think I've broken VGA more than once...)

Ooh that makes a lot of sense :laughing: thank you!


echo command fails on Windows (testProjectExec unit tests)

The echo command is used in a number of unit tests, particularly the testProjectExec unit tests in UtilsTest.groovy. This command isn't supported on Windows. The tests are currently disabled on Windows but should be enabled once an alternative is established to the echo command. Current exception:
org.gradle.process.internal.ExecException: A problem occurred starting process 'command 'echo''

@gocursor - it would be a great help to have your insights on this. I don't have a Windows machine, so this is much harder for me to fix. Can you figure out what command can be used to do something like echo for Windows? Echo works on Mac / Linux but for some reason it give the error seen in the description.
cc @advayDev1
Probably the easiest test to work with is testProjectExec_StdOut. Modify line 565 onwards to remove the return and uncomment the line before. The trick will be to replace the ???? section with a command that works. For example:
String executableCmd = 'echo'
if (Utils.isWindowsNoFake()) {
    executableCmd = 'WORKING_COMMAND'
}

i guess echo is not a binary, but a built-in of the shell.  try:
executableCmd = 'cmd'
and prepend '/C' as the first arg. (and everything else the same)
http://stackoverflow.com/questions/515309/what-does-cmd-c-mean

That did the trick. I'm close to getting those tests to pass now.
On Tue, Aug 25, 2015 at 11:07 PM Advay Mengle<EMAIL_ADDRESS>wrote:

i guess echo is not a binary, but a built-in of the shell. try:
executableCmd = 'cmd'
and prepend '/C' as the first arg. (and everything else the same)
http://stackoverflow.com/questions/515309/what-does-cmd-c-mean
—
Reply to this email directly or view it on GitHub
https://github.com/j2objc-contrib/j2objc-gradle/issues/422#issuecomment-134848493
.


Update Android Gradle plugin to 2.3.1

The build failed for unknown reasons. Restarting Travis by doing a --no-edit amend and force push.

Thanks!


Add basic upsert support for delta table format in filesystem destination

Description
This PR adds basic merge support for the fileystem destination when using delta as table format.

only supports upsert merge strategy (not delete-insert and scd2)
does not support deleting records from child tables (so updates to complex columns that involve element removals are not propagated)

Related Issues
#1453
Additional context

First 35 commits are from earlier PR: https://github.com/dlt-hub/dlt/pull/1466.
New commits start from https://github.com/dlt-hub/dlt/pull/1600/commits/04437e72eed778e53bb2a89be1008b8d429ef277.

@jorritsandbrink this is already looking quite good. I have a question about the tests though. Shouldn't we be able to make most tests in "/Volumes/dlthub/dlt/tests/load/pipeline/test_merge_disposition.py" work with delta tables? I can see that you are not using the merge keys (at least it seems to be this way) and those tests would've caught that.


[Feature Request] Biome-specific ore generation options

I'd like to suggest config options for custom ores that whitelist or blacklist ores from generating in specific biome ids or categories, like so:
[["Custom Ore"]]
	"Ore Name" = "minecraft:emerald_ore"
	"Filler Name" = "minecraft:stone"
	"Max Vein Size" = 1
	"Min Vein Level" = 1
	"Max Vein Level" = 256
	"Spawn Rate" = 2
	"Biome Category Whitelist" = ["MOUNTAIN"]
	"Biome ID Whitelist" = ["minecraft:mountains", "biomesoplenty:alps"]

This example would limit emerald generation to a few mountainous biomes. For the example, I mixed using categories and biome IDs, but that probably wouldn't be very helpful in an actual config.

A whitelist that overrides an optional blacklist would be neat.


[WIP] (Part 1) Classes for partially known shapes, possibly unknown dimensions

@rkimballn1 @silee2 FWIW/FYI: it looks like you guys were tagged because you are the code owners for CMakeLists.txt.

TESTNOW

TESTNOW


Use Burocrata to check license notices in code

The tool replaces our custom script (which is now removed).

cc fatiando/community#140


fix installed tests

forgive comparison tests for installed repo (psi4 and cfour ref data not installed)

Codecov Report

Merging #8 into master will increase coverage by 0.04%.
The diff coverage is n/a.


[#noissue] bug fix.

Disappear merged link when merged node has loop link.
Display wrong side bar data when merge node has multi input link.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Support reading from &[IoSlice]

Sometimes, the data we want to parse can be split in several buffers, and not in a single &[u8].
Being able to parse from &[IoSlice] would make it easier to do so.
We could probably have an internal Input type, with From<[u8]> and From<[IoSlice]> implemented for it, and I: Into<Input> instead of &[u8] as parameter from parsers

I'd be willing to try to implement this and submit a PR if it would be accepted.


add iMessage 2fa code extract shortcut extension

Description
iMessage Two Factor Authentication Code
Screencast

Checklist

[x] I read the extension guidelines
[x] I read the documentation about publishing
[x] I ran npm run build and tested this distribution build in Raycast
[x] I checked that files in the assets folder are used by the extension itself
[x] I checked that assets used by the README are placed outside of the metadata folder

Good extension! I tried it, but it didn't seem to work,  cannot get the messages on M1 mac, did I miss anything?

Hi 👋
Thanks for the contribution 🔥
We do also have #1954 in the queue which looks more or less like the same thing?

Good extension! I tried it, but it didn't seem to work, cannot get the messages on M1 mac, did I miss anything?

This tool can search within last 24 hours ago messages which may contain two factor auth code possibly.

@yuercl  I know, and I confirm that I have received SMS messages on my Mac within 24 hours.  I checked using the console log, it seems that it can't read the SMS.
I don't know much about the development environment of Apple desktop, but I am curious as to how the program reads the user's text messages without the user's knowledge and authorization to do so. This is inconsistent with what I understand to be Apple's system privacy policy.
My device: Apple M1 Pro, OS: 13.0 Beta(22A5373b)

Ok, I just pulled your latest code and it works as expected now. 🎉

Could it be nice with a preference to select how long timespan you'll see 2FA codes, or is that irrelevant?

I used it and feel good.  I have a suggestion, could you add an action Copy  to Clipboard on the main page if the 2fa code is detected? so that the user can easily copy it to the clipboard after receiving the code, instead of going to the sub-page and then get it.
Also, it would be better to display the SMS details with Detail components, currently one line list  may not be able to display the full SMS content.

submit a new version @tisfeng

Great, this extension will help many users who are used to receiving 2FA code on Mac, I'm looking forward to seeing it in the store!

Could it be nice with a preference to select how long timespan you'll see 2FA codes, or is that irrelevant?

latest code has support preference search time gap.
add new filter for search 2fa code or not.
quick link to copy 2fa code in main list.
improve ui that displays entire message content to list detail component.
@pernielsentikaer


Add 'Shaking the can is more effective' config toggle

Amazing mod, but I would much prefer to shake the spray can as it was like in the base game. This mod, whilst fast, makes it feel 'buggy' with such a short animation playing.
Thank you.

This please!

working on this now! the next release will have this setting :>

alrighty, v2.0.0 is finally out, thank you for your patience!
take a look at the three new shaking-related settings that are now fully configurable: ShorterShakeAnimation, ShakeEfficiency, and ShakingNotNeeded!

@taffyko Thank you so much for this update! Just tried it out and everything was working perfectly during my brief test. I really appreciate your hard work on this. It's likely I'm going to spend more time painting than actually collecting scrap with the new colour and size controls 😄


Annotate bots/jabber_mirror_backend.py

Annotated bots/jabber_mirror_backend.py. A few things were annotated as Any, particularly the Jabber and the Zulip events (I think), whose types I couldn't figure out.

Automated message from Dropbox CLA bot
@xdizzaster, thanks for the pull request! It looks like you haven't yet signed the Dropbox CLA. Please sign it here.

Hi @xdizzaster!
Thank you for working on this!
You have resubmitted the task, but you haven't addressed @TomaszKolek's two comments - could you look into that?
Also, when you're updating your pull request, rather than adding commits you should amend the existing one - here is a guide on that and some more info on commit history.
Could you read those guides and tidy your commit history?
Thanks!

In order to end the discussions about the JabberToZulip class' msg arguments, I took a look through sleekxmpp and discovered that they are all defined as sleekxmpp.stanza.Message objects. Updated the pull request.
PS sorry for the commit mess, still trying to find the right way to do things. Please don't be mad :)

@timabbott and @xdizzaster, this is ready to merge once Travis passes.  There are a few Any cases here left, but we tried pretty hard to track down the reasonable cases.  To give an example, the values in an event dictionary can be one of many types, so we just leave that as Any.

Merged!  Thanks @xdizzaster!!


provide option to disable clusterrolebinding for multitenancy

issue
We would like to provide argocd multitenancy inside one cluster, provide multiple argocd server instances in different namespaces, hand the administrative responsibility to the respective teams. The upstream argocd implementation fully supports this: https://github.com/argoproj/argo-cd/tree/master/manifests and the operator also supports multiple instances of argocd but it creates a clusterrolebinding for the $argocdinstance-application-controller service account which gives global read rights.
This global read right is allowing the account to read into system or other tenant resources and based on the link and our testing it's not strictly necessary.
request
We would like to install argocd instances which have kubernetes rbac permissions only on their own namespaces and only the operations team can give rbac permissions to individual namespaces for the service account. It would be good if there will be a parameter for the argocd instance to enable/disable the clusterrolebinding of the service account.

but it creates a clusterrolebinding for the $argocdinstance-application-controller service account which gives global read rights.

We are aware of this and we are classifying this as a bug which we are working on a fix on priority.
After the fix:

the cluster config argocd in Openshift config namespace will have cluster-scoped read.
Any other argocd will not have the cluster scoped read.

Would this help?

Thank you for the quick reply!
I don't see this "cluster config argocd in Openshift config namespace" in our system with oc get argocd -A, I suppose this will be a new feature? But as far as I understand this will be an internal, system component which isn't exposed to the end users, this way it will be good for us.

Upgraded and tested the 1.1.1 version today and it's working as expected, I will close this ticket.

Thank you!
On Fri, May 28, 2021, 03:50 Andras Babos @.***> wrote:

Upgraded and tested the 1.1.1 version today and it's working as expected,
I will close this ticket.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/redhat-developer/gitops-operator/issues/121#issuecomment-850224235,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAEFEADIOONL6BT7PUR7JDLTP5DLLANCNFSM44VES5IA
.


image rotated upside down, preview shows correctly

See https://lbry.tv/@LilCryptita:4/IMG_5860:c
The unfurl preview shows correctly, but thumb + image are upside down.

seems to not honor EXIF metadata.


Update rss-reader-rust-for-windows.md

Add missing ampersand before "uri" argument in step 8 code. This omission makes the sample fail to compile. It is correct in step 9, but for students following along and adding code step-by-step, this is easy to miss.

Learn Build status updates of commit 0462abe:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

hub/dev-environment/rust/rss-reader-rust-for-windows.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the learn.microsoft.com contributor guidesPost your question in the Learn support channel


chore(deps): update micromatch to 4.0.5

https://github.com/micromatch/micromatch/commit/002d0d184c95e76775528fa1dbe0c446518879b2

Coverage remained the same at 97.872% when pulling a51077459ab5a8668fd03aee1c7ada4ada89e09b on bump-micromatch into 98d03dbe1d7743c2f28c87ab80e6debb80d44ad6 on v3.


Migrated from Dep to Modules. Good chance some of the vendored packages need to be updated as well. As stated in the comments the protobuf package needs to be updated and syncs in the mod file. If thats the case:
go get github.com/golang/protobuf/proto
go mod vendor
Tested builds with Go 1.14.2 as well.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.shoran seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.


Voice chatting in Controling Monster

I use this mod and Control Company to help a friend who isn't good at directions when I dead and find the way.
But it's a pity that I can't talk while helping my friend.
The official control company says that talking in Monster Control is not in the plan.
Can you make me a function to speak in Controling Monster?
(I'm Korean, so I used a translator.)

So far, I couldn't find a way to do this :/


fix: log searching through props instead of state

Had accidentally set the filter function to use the logs from state, this meant the filter could only ever become more constrained because it could only filter from previously filtered results instead of the entire set.
Fixes ADO#2195

:tada: This PR is included in version 0.366.5 :tada:
The release is available on:

npm package (@next dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Updating stale poetry.lock

I was getting a warning about a stale poetry.lock:
> poetry install --with dev
Installing dependencies from lock file
Warning: poetry.lock is not consistent with pyproject.toml. You may be getting improper dependencies. Run `poetry lock [--no-update]` to fix it.

So I ran:
> make full
> poetry lock

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

:exclamation: No coverage uploaded for pull request base (main@6bfce78). Click here to learn what that means.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #464   +/-   ##
=======================================
  Coverage        ?   80.95%
=======================================
  Files           ?       45
  Lines           ?     4447
  Branches        ?        0
=======================================
  Hits            ?     3600
  Misses          ?      847
  Partials        ?        0

Flag
Coverage Δ

unittests
80.95% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Thanks for the contribution! We're going to pull this onto a feature branch so we can run the checks all the way through.