MONDO:0800153 | urea cycle disorder or inherited hyperammonemia

MONDO:0800153 | urea cycle disorder or inherited hyperammonemia | A disorder of amino acid metabolism that has its basis  in the disruption of the urea cycle and/or there is an inherited  increased concentration of ammonia in the blood.
This seems a strange grouping term.
MONDO:0800153 | urea cycle disorder
is a collection of  specific diseases
Is  inherited hyperammonemia  a specific disease
but  inherited hyperammonemia  sound like a phenotype "increased concentration of ammonia in the blood."
What was the rationale for the grouping?
Which disease genes (other than urea cycle disorder ) cause inherited hyperammonemia

Hi @ValWood we are revising this hierarchy to match the expert-recommended classification outlined in this paper (https://onlinelibrary.wiley.com/doi/abs/10.1002/jimd.12348), see related ticket:
https://github.com/monarch-initiative/mondo/issues/4985

the authors listed the genes in the table in their paper

does this answer your question?

Yes!
In this case, should the def be
MONDO:0800153 | urea cycle disorder or inherited hyperammonemia |
A disorder of amino acid metabolism that has its basis in the disruption of the urea cycle a OR [an inherited hyperammonemia, any specific disease which causes an inherited increased concentration of ammonia in the blood].
To make it clearer that this is a disease classification, not a disease plus a phenotype (it's actually diseases identified by phenotype, which is fine as long as they are defined as diseases)

thanks @ValWood, I updated the definition.


Test on io.js

How was the test?

@jaydson I just added io.js to the Travis engines list, this means all our commits/PRs will be tested on io.js as well (via Travis) from now on.

Got it. That's awesome :)


QDM 5.0

Support for QDM 5.0

In case it's hidden from being outdated.

@holmesie did we decide to just keep this as the cql4bonnie branch? In that case, should we close this branch without a merge? Or maybe do a merge and not delete this branch and keep updates on this branch?
We were thinking we'd keep cql4bonnie so everyone is  pointing to the same remote repo types across the different repos.

Yeah, I think we decided to keep it separate. I will close the pull request, and we can continue to merge into the cql4bonnie branch.


[BUG] Roblox launching into the app instead of the website

Acknowledgement of preliminary instructions

[X] I have read the preliminary instructions, and I am certain that my problem has not already been addressed.

What problem did you encounter?
The option that was available in previous versions is now missing. The option to disable the roblox app completely is not there. When launching roblox it launches the app and not the website like it used to. Is there a workaround to disable the roblox app so that the website launches?

The ability to disable the desktop app was unstable and was causing crashes.


[SKIP CI] Update Edit me link on customer facing documents to point to vmware:master

This PR addresses issue #1847.
This change ensures that "Edit me" on vmware.github.io points to vmware:master/docs folder

@ashahi1 Please regenerate the site to apply this change.


insider for ARM based computers

Hello insider team. I am using insider from sometime now. I have recently shifted to M1 MAC and therefore running an ARM based version of Kali as a virtual machine and I am unable to run insider on Kali as it is not supported yet.
If I am missing an already existing compatible version please point me to it if not please consider my request. Thank you.

Hello insider team, is there any progress with M1 Macs?

I am using M1 Macbook, and insider_3.0.0_darwin_x86_64.tar.gz works fine.


[AXI4Lite][VHDL][Bug] RGGen generated code not compiling

Hi
I have been experimenting with rggen for few weeks now with quite positive outcome and was looking forward to use it.
However after recent changes There are synthesis/compilation errors inside due to strobe width mismatch:
[Synth 8-549] port width mismatch for port 'o_register_strobe': port width = 32, actual width = 4 ["rggen/rggen_axi4lite_adapter.vhd":51]

@taichi-ishitani:
$ rggen --verbose-version
RgGen 0.31
  - rggen-core 0.31.0
  - rggen-default-register-map 0.31.0
  - rggen-sv-rtl 0.31.0
  - rggen-sv-ral 0.31.0
  - rggen-c-header 0.4.0
  - rggen-markdown 0.25.0
  - rggen-spreadsheet-loader 0.24.0

$ git log
commit cfb07744352f203ef45dfceacafb66cb52b8e243 (HEAD -> master, origin/master, origin/HEAD)
Author: Taichi Ishitani<EMAIL_ADDRESS>Date:   Tue Sep 12 16:24:10 2023 +0900

    change strobe width

    (refs: rggen/rggen#164)

@SzymonHitachi ,
Can you also provide version of the VHDL plugin?
$ rggen --plugin rggen-vhdl --verbose-version

@taichi-ishitani
- rggen-vhdl 0.7.0

Version of RgGen and commit hash of common VHDL modules are OK.
Can you generate RTL modules again?

Full git re-clone and full rebuild of all CSRs seem to have helped. There probably was some old code missed during rebuild (aka, one of CSRs wasn't rebuilt).
So somewhere on the version upgrade path I had to:

Upgrade Rggen gem
Upgrade VHDL-RTL
Rebuild every CSR

It seems that one of the steps was partially missing from my side (PEBKAC).
ありがとう ございます. Let me see how it works out now.


Change the mobile content settings tabs using swipe gesture

Problem

The mobile content settings modal is tabbed, it should support native-like interactions.
Description

To imitate the native tabbed navigation behavior, we can add swipe gesture detection to the mobile content settings modal to change the tabs.
Additional context

Implementation

[ ] 🙋 I would be interested in implementing this feature.

Closing as not planned


GH-26 osgi-fragment added

see #26
WIP
to make this work:

change the fragment host with yours see https://github.com/adobe/aio-lib-java/pull/27/files#r715102169
install the fragment to your localhost/aem using from the osgi-fragment folder :  mvn -Dlicense.header.path=../copyright_header.txt -P localInstall clean install sling:install

replaced by https://github.com/adobe/aio-lib-java/pull/29


Site broken in IE11

Deployed site does not load in IE11. Will post error message tonight when I test it again.

fixed on testdb


Review label for OBI_0003005 'device for resting of adult arthropods for collection'

Definition is fine: "A device that is designed to provide a solid surface that is attractive to an arthropod as a place to rest during a period of inactivity."
I found the label hard to parse.
label could be "device for collection of resting adult arthropods" ?
http://www.ontobee.org/ontology/OBI?iri=http://purl.obolibrary.org/obo/OBI_0003005

Change was made in latest OBI release


include federation e2e in merge bot testing

 Issue by nikhiljindal
Thursday Jun 02, 2016 at 17:57 GMT
Originally opened as https://github.com/kubernetes/kubernetes/issues/26723

We should include federation e2e in merge bot testing, so that we can catch PRs that break the test.
We need to ensure that it is 100% green before doing this.
@colhom Can you take this up?
cc @kubernetes/sig-cluster-federation

 Comment by quinton-hoole
Thursday Jun 02, 2016 at 18:02 GMT

I can take this.  Lets focus on getting them all green first though.

 Comment by nikhiljindal
Monday Jun 13, 2016 at 18:41 GMT

@quinton-hoole can you detail the steps that are required?
It will be good to get a PR ready.

 Comment by quinton-hoole
Monday Jun 13, 2016 at 18:51 GMT

@nikhiljindal I don't know the precise steps offhand, but in essence there are two parts:

the merge-bot configuration needs to be updated to to include the "kubernetes-e2e-gce-federation" test job as a merge-blocker.  That way, if that job is failing, automated merges will be blocked.
the per-PR merge bot needs to be updated to deploy the federation control plane into the e2e test cluster, and add "--test_args="--ginkgo.focus=[Feature:Federation]" to the e2e tests that are run on every PR. This will ensure that the federation e2e tests are run (against a federation which includes only a single underlying cluster) for every PR.  We can extend this to multiple clusters as a second step (as this might be slightly more difficult to configure).

 Comment by goltermann
Monday Jun 13, 2016 at 22:11 GMT

Applying P1 priority (should do for 1.3) - adjust if that's not right.

 Comment by nikhiljindal
Monday Jun 13, 2016 at 22:17 GMT

cc @lavalamp

 Comment by lavalamp
Monday Jun 13, 2016 at 23:14 GMT

the per-PR merge bot needs to be updated to deploy the federation control plane into the e2e test cluster, and add "--test_args="--ginkgo.focus=[Feature:Federation]" to the e2e tests that are run on every PR. This will ensure that the federation e2e tests are run (against a federation which includes only a single underlying cluster) for every PR. We can extend this to multiple clusters as a second step (as this might be slightly more difficult to configure)

You can only do this if it doesn't make the test take longer! Needs to stay under 30 minutes.

 Comment by quinton-hoole
Monday Jun 13, 2016 at 23:23 GMT

Agreed, that is part of what I meant by "more difficult" :-)

 Comment by nikhiljindal
Tuesday Jun 14, 2016 at 20:36 GMT

Created a test-infra issue for the second item as per discussion with @ixdy
https://github.com/kubernetes/test-infra/issues/155

 Comment by quinton-hoole
Thursday Aug 11, 2016 at 18:45 GMT

@nikhiljindal seems to have this done.  Reassigning.

 Comment by quinton-hoole
Thursday Aug 18, 2016 at 17:14 GMT

This is done in kubernetes/test-infra#335. Closing.

 Comment by nikhiljindal
Friday Aug 19, 2016 at 18:29 GMT

Yes that PR was merged. But the test is still not passing on Jenkins. federation-apiserver pod fails to come up. I am trying to figure out how to get logs (We dont get pod logs right now)

 Comment by goltermann
Tuesday Sep 06, 2016 at 20:31 GMT

@nikhiljindal @quinton-hoole are these passing now?  Is this issue a 1.4 blocker?

 Comment by madhusudancs
Wednesday Sep 07, 2016 at 20:28 GMT

@goltermann federation tests are passing, but this issue isn't completely resolved. This isn't a 1.4 blocker. Re-targeting to 1.5.

 Comment by dims
Wednesday Nov 16, 2016 at 14:05 GMT

@madhusudancs : is this still target-ted for 1.5?

 Comment by saad-ali
Thursday Nov 17, 2016 at 23:59 GMT

@nikhiljindal @kubernetes/sig-cluster-federation I am marking this as non-release blocking for 1.5.
FYI the federation E2E suite for release-1.5 is ci-kubernetes-e2e-gce-federation-release-1.5

 Comment by nikhiljindal
Friday Nov 18, 2016 at 01:00 GMT

Yes removed from 1.5 milestone

cc @nikhiljindal

This is irrelevant now. federation code vendors in other repos of k8s and no longer in-tree.
Updating vendors is a manual process. We cannot put restriction on merge bot based on federation e2e tests.
/close


Allow use of personal token on the Portal API

Issue
https://gravitee.atlassian.net/browse/APIM-903
https://github.com/gravitee-io/issues/issues/8569
Description
Allow use of personal token on the Portal API

🚀 CI was able to deploy the build of this PR, so you can now try it directly here
Notes: The deployed app is linked to the management API of APIM master. (Same login and password as APIM master)

📚  View the storybook of this branch here

Closing as it is the intended behaviour for now, as there is no token management screen on the Portal side.
Also, Management and Portal API are exposing the same data, so there shouldn't be anything preventing to use the Management API.


Fix domain listing query

A domain can appear in multiple country lists, so we need to pick the first occurrence of it sorted by country_code (so we give priority to the category code of the domain in the global list).

1.0.51~pr653-37 deployed on -test

1.0.51~pr653-37 deployed on FSN


dbeaver/pro#1902 Disable data export and copying data

Provided policy data export-copy provider for restriction operation.

In order to restrict export data operation pls add in dbeaver.ini:
-Dpolicy.data.export.disabled = true
or in windows registry:
HKEY_CURRENT_USER\Software\DBeaver Corp\DBeaver\policy
policy.data.export.disabled = true
In order to restrict copy data operation pls add in dbeaver.ini:
-Dpolicy.data.copy.disabled = true
or in windows registry:
HKEY_CURRENT_USER\Software\DBeaver Corp\DBeaver\policy
policy.data.copy.disabled = true

Also I think we must hide export menu and toolbar items.

Verified

Reopened: https://github.com/dbeaver/dbeaver/pull/21555


"nix-shell" command's execution time

Greetings,
I am in the process of installing and using the DFFRAM compiler, and I am following the steps mentioned in "Usage.md" file (https://github.com/AUCOHL/DFFRAM/blob/main/docs/Usage.md). However, since I ran the "nix-shell" command, it is taking so much time, almost 3 hours now. I am writing to ask if it is normal for the "nix-shell" to be running for a long time or there is a mistake somewhere.
As a side note, maybe it helps in identifying the problem, I am using openLane from this repo (https://github.com/The-OpenROAD-Project/OpenLane).
Thanks in advance.

This may happen if you forgot the Cachix step or did not execute it correctly- it will build every tool included with OpenLane from scratch. Needless to say, this will take forever: https://github.com/AUCOHL/DFFRAM/blob/main/docs/Usage.md#setting-up-the-binary-cache
Some logs would be helpful.

As a side note, maybe it helps in identifying the problem, I am using openLane from this repo (The-OpenROAD-Project/OpenLane).

DFFRAM pulls its own OpenLane as part of nix-shell, so that's not an issue.

Thanks for your answer.
I did the Cachix step correctly. Here is what happened. It took this long time only the first time I executed this command, but now it opens immediately.
Another question, is there an instructions file for porting the DFFRAM compiler to another PDK other than "gf180mcu_fd_sc_mcu7t5v0" and "sky130_fd_sc_hd"?

It took this long time only the first time I executed this command, but now it opens immediately.

So as a small primer, nix will cache the result of any nix-shell on your computer, which is why it doesn't take that long the second time.
What Cachix tries to do is insert an alternative cache where OpenLane's dependencies are already built, so you don't have to do that too. So it's weird that it didn't pull dependencies.
THAT SAID; out of curiosity, are you on an Apple Silicon Mac? If so, that would explain the lack of binaries.


Fix typo in README

I was reading the docs/readme and I couldn't resist creating a PR fixing extendsions.

Note: And after that I couldn't resist putting this meme 👇🏼  🤣

👍


Add channel/revision/config for every component

Ensure to add ability to configure channel, revision, config options for every service.

CI failure due to https://github.com/charmed-kubernetes/actions-operator/issues/67

snap-openstack test with this PR passed.
https://github.com/canonical/snap-openstack/pull/74


error when installing php

Issue description
php does not install. no version in fact.
Steps to reproduce
$ nix-env -i php
Technical details
result:
installing ‘php-7.0.5’
error: Package ‘uw-imap-2007f’ in ‘/nix/store/phqb57liyaqm9jxlawk47y3d97whq2bv-nixpkgs-16.09pre83147.df89584/nixpkgs/pkgs/tools/networking/uwimap/default.nix:39’ is not supported on ‘x86_64-darwin’, refusing to evaluate.
a) For nixos-rebuild you can set
{ nixpkgs.config.allowBroken = true; }
in configuration.nix to override this.
b) For nix-env, nix-build or any other Nix command you can add
{ allowBroken = true; }
to ~/.nixpkgs/config.nix.

System: OS X 10.11.4
Nix version: 1.11.2
Nixpkgs version: "16.09pre83147.df89584"

@dwenaus this should be fixed via #16078 :) Could you try it out and report if the issue still exists?

@mpscholten
I can confirm that PHP now installs successfully on Darwin.

System: Darwin 15.5.0 (OS X 10.11.5)
Nix version: 1.11.2
Nixpkgs version: 16.09pre-git


[Jenkins]: update Jenkins jobs to upload to COS instances

Update all Jenkins jobs to upload to new COS instances. See Carbon for IBM.com - CDN - Web Components - Canary job for an example. Once new transfers are verified to be working, the deprecated rsync commands can be removed (or commented out).
Jenkins buckets:
https://github.com/carbon-design-system/carbon-for-ibm-dotcom/issues/9649#tasklist-block-bfae2d0d-6d12-4050-b1b6-cfe354173936

Hey team! Please add your planning poker estimate with Zenhub @ariellalgilmore @kennylam @IgnacioBecerra @emyarod


[Rust] Fix deprecation warning in clippy

Master and all PRs are failing with a deprecation warning in clippy. This fixes it.

Codecov Report

Merging #9314 (d427d8f) into master (cf7638f) will decrease coverage by 0.00%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #9314      +/-   ##
==========================================
- Coverage   81.89%   81.88%   -0.01%
==========================================
  Files         215      215
  Lines       52988    52988
==========================================
- Hits        43392    43391       -1
- Misses       9596     9597       +1

Impacted Files
Coverage Δ

rust/parquet/src/encodings/encoding.rs
95.24% <0.00%> (-0.20%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cf7638f...d427d8f. Read the comment docs.

Codecov Report

Merging #9314 (d427d8f) into master (cf7638f) will decrease coverage by 0.00%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #9314      +/-   ##
==========================================
- Coverage   81.89%   81.88%   -0.01%
==========================================
  Files         215      215
  Lines       52988    52988
==========================================
- Hits        43392    43391       -1
- Misses       9596     9597       +1

Impacted Files
Coverage Δ

rust/parquet/src/encodings/encoding.rs
95.24% <0.00%> (-0.20%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cf7638f...d427d8f. Read the comment docs.

It seems like perhaps this is related to the release of criterion: https://crates.io/crates/criterion/0.3.4 (On Jan 24 2021)

It seems like perhaps this is related to the release of criterion: https://crates.io/crates/criterion/0.3.4 (On Jan 24 2021)

The Clippy test still is failing; I found I had to run cargo update in my local arrow checkout to reproduce the failure.

The Clippy test still is failing; I found I had to run cargo update in my local arrow checkout to reproduce the failure.

It should be fixed now. :)

It should be fixed now. :)

Looking clean and green 💚

Looking clean and green 💚

I will file a JIRA ticket and merge this in

I will file a JIRA ticket and merge this in


Skipper S3 stream-upload memory buffer fills up while passing disk parameter

Trying to stream-upload to S3 using skipper and skipper-s3 using this code
image_upload : function  (req,res) {

		// depends on bodyparser:skipper in confing/http.js

		console.log("Uploading image .. ");

		req.file('image')
			.upload({
				adapter: require('skipper-s3'),
				key: KEY,
				secret: SECRET,
				bucket: 'mybucket',
                                tmpdir: 'tmp/s3-multiparts'

			}, function whenDone(err, uploadedFiles) {
				if (err){
					return res.negotiate(err);
				} else {
					dict=	{
						files: uploadedFiles,
						textParams: req.params.all()
					}
					return res.ok(dict);
				}
			}

		);

I have 2 problems
First: when I try to upload some file, I can see that this file buffers in memory, instead just buffering to the disk (path added to options).
Actually this is a big problem, as my memory will fill up so quickly when having many users concurrently uploading
Second: my application crashes when upload is bigger than 5MBs, giving me this error
events.js:85
      throw er; // Unhandled 'error' event
            ^
Error: Request aborted
    at IncomingMessage.onReqAborted (~Desktop/myApp/node_modules/sails/node_modules/skipper/node_modules/multiparty/index.js:175:17)
    at IncomingMessage.emit (events.js:104:17)
    at abortIncoming (_http_server.js:279:11)
    at Socket.serverSocketCloseListener (_http_server.js:292:5)
    at Socket.emit (events.js:129:20)
    at TCP.close (net.js:485:12)

What shall I do with those 2 problems?

Hm, the tests for this are passing, meaning that for at least our test key and bucket, it's able to upload files >25mb without issue.  How are you determining that it's buffering to memory and not disk?  As for the error, unfortunately it's not giving you much info there, but you could try throwing a log around here in the multiparty index.js file to see what the actual error is.

I run the sails app and run process monitor, which checks the disk, cpu, and memory utilization. Regarding throwing the error, will do in the close future


Can we enable LIBCXX_ENABLE_FILESYSTEM in libcxx?

Hi there!
I have just recompiled wasi-sdk v10 for a project I am working on and I thought I'd try to enable LIBCXX_ENABLE_FILESYSTEM for libcxx in order to have access to std::filesystem from my WASM code - the custom environment I am using is WASI-capable and works fine with C file I/O and C++ streams, but I hit a problem when trying to use std::filesystem::create_directory (or std::__fs::filesystem::create_directory as it seems to be named here).
My problem is that enabling the flag leads to an include error with a missing <sys/statvfs.h> included in "filesystem_common.h": does anyone know if it is at all possible to get std::filesystem to compile in libcxx for use in WASM?
For a bit of context, I am compiling under Ubuntu 18.04 (through WSL in Windows 10), cloned the wasi-sdk repo and used make. Everything works as expected without the flag.
Thanks a lot for your hard work!!!

At a quick glance, it looks like the only thing in libcxx that needs <sys/statvfs.h> is the space functions, which you don't need for create_directory or indeed most of the filesystem library.
It would probably be straightforward to get the filesystem library to build if you disabled use of <sys/statvfs.h> and the space functions. If someone wanted to write up a patch that introduced a new CMake variable like LIBCXX_ENABLE_FILESYSTEM_SPACE or so that did that, we may be able to help land that in upstream LLVM and use it in wasi-sdk to allow us to enable the rest of LIBCXX_ENABLE_FILESYSTEM.
We could also talk about adding functionality to WASI to support a subset of <sys/statvfs.h> sufficient to implement the space` function, though that would be more involved.

Dan,
I've done what you suggested but I then have another issue with ::utimes (not available when targetin WASI) being used in posix_utimes (filesystem_common.h). I'll follow the same idea as for statvfs and see where i get.
Thanks for your help. :)

For fchmod/chmod the underlying functions were added to WASI ephemeral here: https://github.com/WebAssembly/WASI/pull/170/files.  I imagine that once we make next snapshot and this migrates into wasi-sdk we can them implement fchmod and chmod.
For chdir/getcwd we don't currently implement them in wasi-libc, but I don't see why we couldn't implement this purely in userspace.
realpath  looks a bit more tricky.   We already support readlink (via __wasi_path_readlink) which might be enough get a useful implementation.


Added new agent capability AllowWorkDirectoryRepositories so repositories can be checked out below the work directory level too on self hosted agents

Added new agent capability AllowWorkDirectoryRepositories. Can be activated by passing "--allowWorkDirectoryRepositories" when configuring the agent, the default behavior is for the capability to not be activated.
The feature request for this new capability can be found here: https://github.com/microsoft/azure-pipelines-agent/issues/3951
The pull request for the documentation of this new feature, which has to be approved after the feature has been implemented, can be found here: https://github.com/MicrosoftDocs/azure-devops-docs/pull/11154
If the allowWorkDirectoryRepositories capability was activated then repositories can be checked out below the work directory level too, and not just below the build directory level, by adding "../" at the beginning of the checkout path. So "../Repositories/RepoName" would then be a valid repository checkout path (but not any higher, so "../../Repositories/RepoName" is still not allowed). This is to potentially save enormous amounts of agent drive space on self hosted agents with large repositories which are shared between pipelines.
The .agent configuration file for an agent with this capability activated would for example then look like this:
{
  "agentId": 1,
  "agentName": "TestAgent",
  "poolId": 1,
  "poolName": "default",
  "serverUrl": "https://dev.azure.com/testurl/",
  "workFolder": "_work",
  "allowWorkDirectoryRepositories": true,
}

This setting is also visible in the agent capability page as setting "AllowWorkDirectoryRepositories".
A valid yaml checkout step checking out the repository below the working directory would for exmample then look like this (provided allowWorkDirectoryRepositories was enabled in the .agent configuration file):
- checkout: self
  path: ../Repositories/MyRepo

This allows for agent scoped repositories instead of just pipeline scoped repositories and can potentially save a lot of space on self hosted agents with multiple pipelines using the same large repository/repositories. For example: We have one 50 GB and an additional 10 GB repository which we would have to check out and use drive space for each pipeline we use. It's just not possible to use pipelines the way they are intended then and we have to work with tricks to not fill up our drives immediatly (like triggering the same pipeline with differnt settings through other pipelines). This however would finally provide a clean way to save enormous amounts of agent drive space, and in the end also money, on self hosted agents (just imagine having to check out 60 GB for every pipeline or just once per agent). It would also allow us to finally use pipelines as intended and create one for every needed setting we have. So we really need this feature, that's why I implemented it as an option and really hope you'll incorporate into the next version(s).
The default behavior remains allowing only pipeline scoped repositories (below the build directory level) and it is highly recommended to not specifically allow work directory repositories for public agents as build pipelines could interfere with each other and it could pose a security risk by allowing users with access to yaml pipelines defintions to change any files below the work directory. I also added UnitTests for this functionality when the capability is activated and for the default behaviour (capability is not activated) which should be to continue to not allow work directory repositories.

@echalone thanks! Let us review and test this PR

/azp run

Do we really need to "shared" repository to be a setting? Since a build agent can only process a single job at a time, there are no concurrency issues. When my assumption about the hosted agents having a fresh server each build there is no risk of accessing other's code. If this is the case there is an argument to be made to have repositories shared over different pipelines by default

Could it probably make sense to save repositories in some specific folder inside of _work folder in this case (for example '_sharedRepos')? This should help to avoid conflicts between repos names and agent internals.

This changes can potentially break the agent's work and imposes a restriction on the naming of the path parameter for the checkout task (By example  1, SourceRootMapping, _task, etc). The following scheme will be invalid:

Could it probably make sense to save repositories in some specific folder inside of _work folder in this case (for example '_sharedRepos')? This should help to avoid conflicts between repos names and agent internals.

It makes sense in this case to rename this setting to make it more transparent to an user.

It's true that you'd have to be careful not to use one of the potentially used directories, though I would have left this in the responsibility of the user... if you wanna use this option you gotta know what you do so to say.
If I thought about this correctly then we would need another additional parameter during the checkout step that would tell us that this is a shared directory. This would pose a problem as the Yaml definition for pipelines is strictly defined and would need extension first (and this option value would need to be forwarded to the agent then)... there would also be no ability to use this feature for us then until a new Azure DevOps Server On-Premis version with this new Yaml definition would then be available. Currently there hasn't been a new Azure DevOps Server On-Premis release since 2020 for example.

So what's next for this? I guess we need someone to decide if we want to actually build this functionality, and if so, how it should be implemented. @AndreyIvanov42 could you weigh in here and tell us if and how we should build this?

Right, so, in my opinion there are three options, in any case you would have to enable this option when installing the agent, so it won't be a breaking change or impact Microsoft hosted agents:

Go with it as I wrote it, in this case the user has to know not to use a subdirectory that's in use by the agent (like 1, 2, 3, _work, etc.), but we could simply add this to the documentation (personally I think that'd be good enough)
Change the programming so that the path has to be at least ".._shared<repository>" or some other fixed name for the first subdirectory. Though the user could just make sure they use it this way themselves in the first option of course. This would need a bit of reworking and rewriting of the UnitTests. I don't know when I'd find time for this or if you'd want to do this yourselfes.
Add an aditional option to the yaml checkout step that would tell us its a shared directory and would automatically put it in the _shared subdirectory or something like that. However this would need the most additional effort as well as a change to the yaml checkout step definition which would not arrive anytime soon in an on-premises Azure DevOps Server which we're using for example. It would also need aditional coordination with whatever team is maintining the yaml checkout step definition and it would need a complete rework of the functionality. So I'd rather not got with this option ^^

What if we simply go with moving the path to which to repo is checked out to a "shared" location like _repos in the agent folder. In what scenario would this break any existing functionality? If we also change the $(Build.SourcesDirectory) to point to this folder, the change should be transparent, except when people would use the $(Build.SourcesDirectory) like $(Build.SourcesDirectory)\..\SomeOtherFolder which doesn't really make sense.
The hosted agents should also be fine, because a fresh agent is used for each job, and this fresh agent doesn't have any source from prior builds.
This way we wouldn't even need a setting at all

I think it could potentially break the agents of other people who do not use a fresh agent every time and may have two repositories with the same name but which are not actually the same repos. But that's for you guys to decide if that's acceptable. If so, then yes that's another way.
Question is how this would impact the currently already wrong primary repository detection and its fix which I'd be fixing with this PR: https://github.com/microsoft/azure-pipelines-agent/pull/3473
And how it would impact the potential option to set another repository as the default working directory which would be this PR (though this isn't too important as its just some additional feature that's not really needed by us): https://github.com/microsoft/azure-pipelines-agent/pull/3479

Changed link to issue since it was wrongfully closed by a stale-bot

Hi @echalone thank you for your work! We have decided to implement basically what you wrote, with the difference that it is activated by an agent knob instead of a capability, as this approach seems simpler and more flexible. Here is the PR: https://github.com/microsoft/azure-pipelines-agent/pull/4423 Feel free to participate if you don't mind
As for your other PRs, we'll also take a look at them once there's no higher-prioritized tasks.

Hi @echalone thank you for your work! We have decided to implement basically what you wrote, with the difference that it is activated by an agent knob instead of a capability, as this approach seems simpler and more flexible. Here is the PR: #4423 Feel free to participate if you don't mind As for your other PRs, we'll also take a look at them once there's no higher-prioritized tasks.

Thank you :)


fix: RP2040 I2C fundamental issues

This is more to open a discussion about the current I2C implementation and the issues with it.
I was experiencing severe stability issues with I2cSlave, which I was not experiencing with the rp-rs embedded-hal crate. The maximum speed possible seems to be 5KHz (as per the current example in the repo, so I assume this problem is tribal knowledge?). This is probably because the current slave implementation doesn't set IC_RX_FULL_HLD_BUS_EN - which essentially enables clock stretching.
The current I2cSlave interface seems to be incompatible with clock stretching. I have brought over the "event iterator" interface from rp-rs and made it async. This is really sad because the existing interface seemed much nicer to use than the event iterator one.
The combination of my changes to I2c and I2cSlaveEventIterator bring things up to 400KHz on my prototype. Unfortunately it also looks like this completely breaks I2cSlave.
Also:

Limit slew rate, per RP2040 spec.
Move pin configuration to single fn.
In the Arduino/C sources, and rp-rs, the system clock is used as for the timing calculations. The peripheral clock makes more sense, so I'm not entirely sure what's correct here.
Stop/start flags for async methods have been corrected.
write_read method added to I2c (which is required for idiomatic i2c)

I'll have another go at getting the existing interface working, but will provide some of the other fixes as separate PRs first.


Update of Getting Started to reflect LTR merge.

Hi
I have updated Getting Started to reflect our recent source merge of framework and ltr_support.
Thank you

Thanks!


Support configuring ServicesNodePortRange via network config

This PR adds support for configuring the servicesNodePortRange of the KubeAPIServerConfig via the network config API. This is necessary to handle cases where the default range (30000-32767) is not sufficient for users who have more services in their cluster than the range can handle.

/test e2e-aws
/test e2e-aws-operator

/lgtm
/approve


Suitable Way of Displaying Toast from Data Table Row Action

I have a delete action in my data table row action, I wanted to display a toast for a successful deletion. I am able to get the expected result in dev run, but I am getting this ESLint rule error upon building the project for production.
 Error: React Hook "useToast" is called in function "cell" that is neither a React function component nor a custom React Hook function. React component names must start with an uppercase letter. React Hook names must start with the word "use".
Based on next.js docs, it's possible to disable rules, but is there a more suitable way of going around this?
Here is my columns.tsx file:
"use client";

export const columns: ColumnDef<File>[] = [
  {
    ...
  },
  {
    id: "actions",
    cell: ({ row }) => {
      const file = row.original;

      const { toast } = useToast();
      const onDeleteFile = async () => {

          const response = await deleteFileById(file.id);

          if (response.success) {
            toast({
              duration: 2000,
              variant: "success",
              description: response.success
          })
          }
      };

      return (
        <DropdownMenu>
          <DropdownMenuTrigger asChild>
            <Button variant="ghost" className="h-8 w-8 p-0">
              Open menu
              <MoreHorizontal className="h-4 w-4" />
            </Button>
          </DropdownMenuTrigger>
          <DropdownMenuContent align="end">
            <DropdownMenuItem>
                <Button
                  variant='destructive'
                  className="flex gap-x-2 w-full"
                  onClick={ async () => await onDeleteFile()}
                >
                    <Trash className="h-4 w-4"/>
                    Delete File
                </Button>
            </DropdownMenuItem>
          </DropdownMenuContent>
        </DropdownMenu>
      )
    },
  }
]

Solved this by creating a separate cell action component:
const CellAction = ({ row }: CellContext<File, unknown>) => {
  const file = row.original;
  const { toast } = useToast();
  const router = useRouter();

  return (
    <DropdownMenu>
      <DropdownMenuTrigger asChild>
        <Button variant="ghost" className="h-8 w-8 p-0">
          Open menu
          <MoreHorizontal className="h-4 w-4" />
        </Button>
      </DropdownMenuTrigger>
      <DropdownMenuContent align="end">
        <DropdownMenuItem
          className='text-red-600 focus:text-red-700 bg-red-100/50'
          onClick={ async () => {
            const { success } = await deleteFileById(file.key)

                  if (!success) {
                    toast({
                      duration: 4000,
                      variant: "default",
                      description: `💥 Something went wrong, couldn't delete the file!`
                    })
                    return
                  }

                  toast({
                    duration: 4000,
                    variant: "success",
                    description: `🗑 Deleted successfully!`
                  })

                  router.refresh();
          }}
        >
            <Trash className="mr-2 h-4 w-4" />
            Delete file
        </DropdownMenuItem>
      </DropdownMenuContent>
    </DropdownMenu>
  )
}

And passing it in the column definition:

export const columns: ColumnDef<File>[] = [
  {
   ...
  },
  {
    id: "actions",
    cell: CellAction,
  }
]


Plotlyswitc

change visualization for draw-collection and underlying functions from plotly express to plotly for greater customization

Viz module slated for depreciation eventually


groupBy does not take a filter option

Per the Pilosa documentation, GroupBy can be used with a filter option:
https://www.pilosa.com/docs/latest/query-language/#read-operations

The optional filter argument takes any type of Row query (e.g. Row, Union, Intersect, etc.) which will be intersected with each result prior to returning the count. This is analogous to a WHERE clause applied to a relational GROUP BY query.

Currently this is not supported via the Java client.
https://github.com/pilosa/java-pilosa/blob/master/com.pilosa.client/src/main/java/com/pilosa/client/orm/Index.java#L322
Everything is simply concatenated with a comma, meaning I have to convert the query to a string, add the filter=(...) string myself, then cast it back to a PqlQuery

Should be a very easy fix:
    public PqlBaseQuery groupBy(PqlRowsQuery... queries, PqlRowsQuery filter) {
        if (queries.length < 1) {
            throw new IllegalArgumentException("there should be at least one rows query");
        }
        String text;
        if (filter != null) {
            String.format("GroupBy(%s, filter=%s)", joinQueries(queries), filter);
        } else {
            String.format("GroupBy(%s)", joinQueries(queries));
        }
        return pqlQuery(text, false);
    }

Hi @timbogatchev, Thanks for submitting this issue. I've pushed a PR  that adds all variants of GroupBy at https://github.com/pilosa/java-pilosa/issues/177


Error upon installation package in editable mode

When running the command pip install -e '.[dev]' I get the following error:
ERROR: File "setup.py" or "setup.cfg" not found. Directory cannot be installed in editable mode: C:\Users\Yoav\Workspace\Code\MarketPlace\standard-app-api
(A "pyproject.toml" file was found, but editable mode currently requires a setuptools-based build.)

This can be worked around by this rather hacky solution: https://stackoverflow.com/a/71946741
A more robust solution should probably be put in place.

Updating pip to its latest version solved this issue.


GET request endpoints for cloning page done and POST request endpoint for Cloning implemented

did some minor aesthetic changes and hooked up the get request endpoints for pulling datasources to clone page

packaged data into a format that the endpoint will recognize as well as made the hook to send a POST request to the endpoint when the button is pressed

TODO: For now until backend cloning endpoint works, will decouple hook


Multinomial random generator

dask/array/random.py is missing a multinomial random generator (there is aplaceholder # multinomial).
Will dask have a multinomial random generator at some point? Does it require a significantly different approach than the other generators?

See https://github.com/dask/dask/pull/1150

Thanks I appreciate it.
I'll give it a try.


PlutusLedgerApi.V1.Interval.contains is wrong for discrete intervals

Summary
Hello!
The problem
I expect contains to check the relation $\supseteq$ on intervals. For discrete intervals, this expectation is violated when comparing (some) open and closed intervals.
For instance, for intervals of integers, $[0,2]=\{0,1,2\}=[0,3)$, and in particular $[0,2]\supseteq[0,3)$, but
Interval (LowerBound (Finite 0) True) (UpperBound (Finite 2) True)
  `contains` Interval (LowerBound (Finite 0) True) (UpperBound (Finite 3) False)

evaluates to False.
This has confusing consequences when applied to, say, the txInfoValidRange, which is a (discrete) Interval of milliseconds. Here is an example of a validator that checks that a transaction happens before a given deadline. It does so in the obvious way, and is subtly wrong in doing so, due to the behaviour of contains.
The cause
Following the implementation, and in particular the Ord instance of UpperBound, we see that for all integers a and b
Interval (LowerBound a True) (UpperBound (b-1) True)
   `Interval.contains` Interval (LowerBound a True) (UpperBound b False)
  == (LowerBound a True <= LowerBound a True) && (UpperBound b False <= UpperBound (b-1) True)
  == True                                     && False
  == False

The wrong step here is (UpperBound b False <= UpperBound (b-1) True) == False. It arises because the Ord instance of UpperBound first compares the bounds, and only if they are equal checks whether they are inclusive or not. The wrong assumption it makes is that "if b is bigger than b-1, an interval ending at b cannot be contained in an interval ending at b-1". This holds in the continuous case, but not in the discrete case.
The Ord instance of LowerBound makes the same mistake, mutatis mutandis.
A bonus bug
contains is also wrong when it comes to empty sets. It holds $[0,1]\supseteq\emptyset=[3,2]$, but
Interval (LowerBound (Finite 0) True) (UpperBound (Finite 1) True)
  `contains` Interval (LowerBound (Finite 3) True) (UpperBound (Finite 2) True)

evaluates to False.
Steps to reproduce the behavior

Open a repl.
import Plutus.V1.Ledger.Interval
Evaluate a few examples like the ones above.

Actual Result
If one reads contains as $\supseteq$, and does the appropriate translations of open and closed intervals, inclusions of the forms

$[a,b-1]\supseteq[a,b)$
$[a+1,b]\supseteq(a,b]$
$[a+1,b-1]\supseteq(a,b)$
...

all evaluate to False on Integer.
Expected Result
The inclusions above should all evaluate to True.
Describe the approach you would take to fix this
If I'm not mistaken, there are no uses of Interval a with "continuous" a. Should that be the case, a solution would be to have Interval a be isomorphic to (Maybe a, Maybe b), where every Just denotes an included bound, and Nothing stands for $\pm\infty$.
If there are uses for intervals of "continuous" element types, one could implement a function like containsDiscrete :: (Ord a, Enum a) => Interval a -> Interval a -> Bool to do the right thing in the discrete case. (Edit: Enum is probably not a good idea, since it relies on Int, which may be too small...)
In any case, the problem with empty sets is easy to solve by adding an emptyness check for the second argument to the implementation of contains.
System info
irrelevant

Thank you very much for such a well-written report. We're already working on the issue.

@carlhammann, the issue is resolved, thanks again for the fantastic report!

Yep, this was gold.


refactor: remove hadoop-aws dependency for connector node

This hadoop-aws dependency will result in a large jar aws-java-sdk-bundle-1.11.1026.jar (about 216M). Since our java iceberg has been replaced by the rust implementation, the only one left is the deltalake sink.  Let's find a way to remove them.

cc @wenym1


updated franz (0.9.10)

Changes to a cask
Editing an existing cask

[x] Commit message includes cask’s name (and new version, if applicable).
[x] brew cask audit --download {{cask_file}} is error-free.
[x] brew cask style --fix {{cask_file}} left no offenses.

I wonder if they finally settled, with this change.


fix: update swift-syntax GitHub URL from apple to swiftlang organisation

The old organisation causes SPM errors because other packages I use have updated the URL already.

Merged. Thanks!


Update wiki video implementation

Need to elaborate on implementation of data transfer and addressing resultant bugs (#51 ) to video part #4.

decoupling capacitors


Migrate to function base

Change from just using Commons js style to Class-operated typescript

Need some cleaning...

Done with cleaning up after my rough merge.


Update webtech Scan to only run on active subdomains

💡 Summary
Webtech takes a long time to run and only returns results for live subdomains.  So we are going to filter the domains we run through webtech to only live domains
Implementation notes
This will be a simple query adjustment once the subdomains have been checked with whoisxml to see which are live and which are not
Acceptance criteria

[ ] Only live domains are scanned

no longer using webtech


sys.executable is not executable with Mono

With Mono, sys.executable returns /absolute/path/to/ipy.exe, which can't be directly executed, but needs to be run by mono: mono ipy.exe. This makes subprocess.Popen([sys.executable]) fail.
On the contrary, with .NET Core, sys.executable returns the shell wrapper, which could be launched directly. Thus subprocess.Popen([sys.executable]) succeeds.

We could add some Mono shell wrappers and do a runtime check when setting sys.executable.


Nlp to sql sample

Please fill out this template! There are three different types of contributions, feel free to delete the checklists that are not applicable to your contribution type.
If you are submitting a new azd template to the gallery
Fill this out if you want your template to be added to the awesome-azd gallery!
Your template repository
Place your template repository link here:

[ ] Added an entry to https://github.com/Azure/awesome-azd/blob/main/website/src/data/users.tsx that includes:

[ ] Template title - A short title that reflects the local application stack that someone could use to get their application on Azure (e.g. "Containerized React Web App with Java API and MongoDB")

[ ] Description - 1-2 sentence description of the architecture (e.g. Azure services) or solution that is defined by the template.

[ ] Architecture Diagram or Application Screenshot - The image should include all services and their connections (example). You should add the image to the website/src/data/images/.

[ ] Link to Author's GitHub or other relevant website - Used for attribution

[ ] Author's Name -  Name to credit on the gallery card

[ ] Link to template source - Link to the template GitHub repo

[x] Tags - Specify tags to represent the template. If you don't see a relevant tag for your template? Feel free to add one!
Required tags:

[x] Tag your template as Micrsoft-authored ("msft") or Community-authored ("community")
[x] Tag the IaC provider ("bicep" or "terraform")
[x] At least 1 tag for programming language used
[x] At least 1 tag for Azure services integrated
[x] Add the "new" tag for any newly authored templates

[x] In the PR comment, if you can also add a link to the PR where you made your repo azd compatible this will allow us to provide feedback on your template and speed up the review process.

[ ] If the template is Microsoft-authored, we encourage you to also publish it to learn.microsoft.com/samples.

If you are submitting a resource to be added to the awesome-azd README:

[ ] Name of resource
[ ] Resource author - who created this resource? (so we can credit them!)
[ ] What section should this resource be included in? -Is the resource an article? A video? Something else?

pr: https://github.com/Azure-Samples/nlp-sql-in-a-box/pull/4

@v-xuto Could you test the new template?

Testing

@hemarina, @codebytes  We have finished this template test, and we filed two issues. Please review.

https://github.com/Azure-Samples/nlp-sql-in-a-box/issues/6
https://github.com/Azure-Samples/nlp-sql-in-a-box/issues/7

Any needed changes or additional work on my repo pr?

@hemarina @v-xuto both issues resolved

@codebytes There are still some problems with issue7, please check the latest comments.

@hemarina, @codebytes  All issues have been fixed. There are currently no issues with this template. Please review.


Fix changing properties, scale images and other improvements

Advertise that we may write icon pixmal/title/tooltip
Set values as props.Properties.Set when setting
Save properties to instance
Improve logging and log messages
Fix linter warnings
Add support for auto-scaling images

Thanks for this. In the future please don't force push once review has been done - just makes it a little harder to review ongoing.


MSID: 89376 Version: 2 DOI: 2<IP_ADDRESS>8362

[PLACE MANUSCRIPT AND EDITOR DETAILS HERE WHEN AVAILABLE] See step 3
[PLACE PDF URL HERE WHEN AVAILABLE] See step 7
Step 1. Inform bioRxiv
Who can help: @QueenKraken, @nlisgo, @scottaubrey

[x] Manuscript is in data hub index (https://data-hub-api.elifesciences.org/enhanced-preprints/docmaps/v2/by-publisher/elife/get-by-manuscript-id?manuscript_id=89376)

Step 2. Create preview of manuscript
Who can help: @fred-atherden, @nlisgo, @scottaubrey

[ ] Manuscript is available for preview (https://prod--epp.elifesciences.org/preview/89376/v2)

[ ] Trigger import for staging: https://prod--epp.elifesciences.org/import
[ ] Sync data folder with s3://prod-elife-epp-data/data
[ ] Trigger import for staging: https://staging--epp.elifesciences.org/import
[ ] Sync data folder with s3://staging-elife-epp-data/data
[ ] Pull request created to enhanced-preprint-data
[ ] Post link to pull request below

Pull request: [PLACE LINK TO PULL REQUEST HERE]
Detailed instructions: https://github.com/elifesciences/enhanced-preprints-data#add-a-manuscript
Step 3: Awaiting public reviews and QC
Who can help: Production team

[ ] QC passed or QC not needed

Who can help: Editorial team

[x] Public reviews available on sciety (https://sciety.org/articles/activity/10.1101/2<IP_ADDRESS>8362)
[ ] Manuscript and editor details at the top of this issue (Supplied by Editorial team)
[ ] Reviews returned by EPP - https://prod--epp.elifesciences.org/api/reviewed-preprints/89376/v2/reviews

Example
"msas": "Genetics and Genomics", "Neuroscience"
"msid": "84628"
"version": "1"
"preprintDoi": "10.1101/2<IP_ADDRESS>4241"
"articleType": "Reviewed Preprint"
"status": "Published from the original preprint after peer review and assessment by eLife."

"Reviewed Preprint posted": "2023-01-02"
"Sent for peer review": "2022-10-28"
"Posted to bioRxiv": "2022-11-21" (link: "Go to bioRxiv": "https://www.biorxiv.org/content/10.1101/2<IP_ADDRESS>4241v1")

Editors:
Reviewing Editor
Michael B Eisen
University of California, Berkeley, United States
Senior Editor
Michael B Eisen
University of California, Berkeley, United States

Step 4: Modify manuscripts.json (no PDF)

[ ] Reviewed preprint is published to EPP (https://elifesciences.org/reviewed-preprints/89376)

[ ] Pull request created to enhanced-preprint-client
[ ] Pull request switched to "Ready for review"
[ ] Post link to pull request below

[ ] Request that a doi be registered

[ ] Post link to #enhanced-preprint comment below

Pull request: [PLACE LINK TO PULL REQUEST HERE]
#enhanced-preprint comment thread: [PLACE LINK TO COMMENT HERE]

Instructions to modify manuscripts.json

Visit: https://github.com/elifesciences/enhanced-preprints-client/actions/workflows/publish-manuscript.yaml
Click: Run workflow
Complete the form and click "Run workflow"
A successful run should result in a new pull request at https://github.com/elifesciences/enhanced-preprints-client/pulls
Open the pull request and click the "Ready for review" button to trigger tests
Once the tests pass and you are happy with the changes the PR can be merged

Example pull request: https://github.com/elifesciences/enhanced-preprints-client/pull/334/files
Once the pull request is merged in it should be available a few minutes later.

Request that a doi
Post the following in #enhanced-preprint:
@Fred can you register a doi for https://elifesciences.org/reviewed-preprints/89376

Step 5: Awaiting search reindex

[ ] Reviewed preprint is avaliable on journal homepage (https://elifesciences.org)

The search reindex is triggered once an hour. We need the reviewed preprint to be indexed as the search application serves the journal homepage.

Additional info
If needed, the jenkins pipeline to reindex search can be triggered sooner.
https://alfred.elifesciences.org/job/process/job/process-reindex-reviewed-preprints/

Step 6: Published! Request PDF generation

[ ] Post the link to the PDF url at the top of the issue

[ ] Post link to #enhanced-preprint comment below

#enhanced-preprint comment thread: [PLACE LINK TO COMMENT HERE]
Post the following to the #enhanced-preprint on slack:
@Ryan Dix-Peek please can you generate a PDF for https://elifesciences.org/reviewed-preprints/89376

Step 7: Introduce PDF to data folder and git repo

[ ] PDF is avaliable at https://github.com/elifesciences/enhanced-preprints-data/raw/master/data/89376/v2/89376-v2.pdf

Detailed instructions: https://github.com/elifesciences/enhanced-preprints-data#add-a-pdf
Step 8: Add PDF url to manuscripts.json

[ ] Reviewed preprint PDF is available for download (https://prod--epp.elifesciences.org/reviewed-preprints/89376)

[ ] Pull request created to enhanced-preprint-client
[ ] Pull request switched to "Ready for review"
[ ] Post link to pull request below

[PLACE LINK TO PULL REQUEST HERE]

Instructions to add PDF url to manuscripts.json

Visit: https://github.com/elifesciences/enhanced-preprints-client/actions/workflows/add-pdf-url-to-manuscript.yaml
Click: Run workflow
Complete the form and click "Run workflow"
A successful run should result in a new pull request at https://github.com/elifesciences/enhanced-preprints-client/pulls
Open the pull request and click the "Ready for review" button to trigger tests
Once the tests pass and you are happy with the changes the PR can be merged

Example pull request: https://github.com/elifesciences/enhanced-preprints-client/pull/397/files
Once the pull request is merged in it should be available a few minutes later.

Step 9: Done!

[ ] Kettle is on!

elocations missing from references.


Handle invalid colstart

This patch handles colStart when it is greater than line length, throwing an exception.
Another solution may be to set colStart equals to the line length (defensive approach), but I think it is better to warning the programmer the parameter passed is wrong.
(I didn't squash the commits because I made the job via web - I am out of town)

LGTM. Thanks!


Update comments in all export_test.go scripts

Update comments in all export_test.go scripts

Fixed in https://github.com/RedHatInsights/insights-results-smart-proxy/pull/142


ClassCastException in Animation.getKeyFrames()

Issue details
Affected calss com.badlogic.gdx.graphics.g2d.Animation
code:
Animation<TextureRegion> animation = new Animation<TextureRegion>(...);
TextureRegion[] f = animation.getKeyFrames();
cause:
Exception in thread "LWJGL Application" java.lang.ClassCastException: [Ljava.lang.Object; cannot be cast to [Lcom.badlogic.gdx.graphics.g2d.TextureRegion;
this code:
Object[] f = animation.getKeyFrames();
does not throw exceptions
Version of LibGDX and/or relevant dependencies
LibGDX v1.9.5
Please select the affected platforms

[ ] Android
[ ] iOS (robovm)
[ ] iOS (MOE)
[ ] HTML/GWT
[x] Windows
[x] Linux
[x] MacOS

Backing array is an Object[], without a class provided in the constructor T[] will not be able to be cast.  Probably best to use an Array internally, otherwise the class would have to be passed in.

Can not reproduce this issue, please add a www.sscce.org
Works fine here. At least what I tried worked fine.

Environment:
LibGDX: LATEST from master branch on Github as of 18-Feb-2017
IntelliJ IDEA IDE Community Edition
Java: jdk1.8.0_102
Gradle Source Compatibility = 1.8
The issue is related to which constructor overload is used in Animation.java. The constructor that takes a var-arg parameter works correctly (no issue with type erasure), but the other constructors that take an Array object result in runtime exceptions shown below.
I took the latest source of LibGDX and the following sample demonstrates the bug (related to type erasure):
The existing test class that was modified:
\libgdx\tests\gdx-tests\src\com\badlogic\gdx\tests\AnimationTest.java
Changes to two methods:
import com.badlogic.gdx.utils.Array;
@Override
public void create () {
	texture = new Texture(Gdx.files.internal("data/walkanim.png"));

	Array<TextureRegion> leftWalkFrames = new Array<>();
	leftWalkFrames.addAll(TextureRegion.split(texture, 64, 64)[0]);

	Array<TextureRegion> rightWalkFrames = new Array<>(leftWalkFrames.size);

	for (int i = 0; i < rightWalkFrames.size; i++) {
		TextureRegion frame = new TextureRegion(leftWalkFrames.get(i));
		frame.flip(true, false);
		rightWalkFrames.set(i, frame);
	}
	leftWalk = new Animation<>(0.25f, leftWalkFrames);
	rightWalk = new Animation<>(0.25f, rightWalkFrames);

	cavemen = new Caveman[100];
	for (int i = 0; i < 100; i++) {
		cavemen[i] = new Caveman((float)Math.random() * Gdx.graphics.getWidth(),
			(float)Math.random() * Gdx.graphics.getHeight(), Math.random() > 0.5 ? true : false);
	}
	batch = new SpriteBatch();
	fpsLog = new FPSLogger();
}

@Override
public void render () {
	Gdx.gl.glClear(GL20.GL_COLOR_BUFFER_BIT);
	batch.begin();
	for (int i = 0; i < cavemen.length; i++) {
		Caveman caveman = cavemen[i];

		TextureRegion frame = null;

		if(caveman.headsLeft){
			frame = leftWalk.getKeyFrames()[0];
		}else{
			frame = rightWalk.getKeyFrames()[0];
		}
		batch.draw(frame, caveman.pos.x, caveman.pos.y);
	}
	batch.end();

	for (int i = 0; i < cavemen.length; i++) {
		cavemen[i].update(Gdx.graphics.getDeltaTime());
	}

	fpsLog.log();
}

Runtime exception and stack Trace:

:tests:gdx-tests-jglfw:classes
java.lang.ClassCastException: [Ljava.lang.Object; cannot be cast to [Lcom.badlogic.gdx.graphics.g2d.TextureRegion;
at com.badlogic.gdx.tests.AnimationTest.render(AnimationTest.java:95)
at com.badlogic.gdx.backends.jglfw.JglfwApplication.render(JglfwApplication.java:270)
at com.badlogic.gdx.backends.jglfw.JglfwApplication$2.windowRefresh(JglfwApplication.java:157)
at com.badlogic.jglfw.GlfwCallbacks.windowRefresh(GlfwCallbacks.java:45)
at com.badlogic.jglfw.Glfw.glfwPollEventsJni(Native Method)
at com.badlogic.jglfw.Glfw.glfwPollEvents(Glfw.java:793)
at com.badlogic.gdx.backends.jglfw.JglfwInput.update(JglfwInput.java:140)
at com.badlogic.gdx.backends.jglfw.JglfwApplication.frame(JglfwApplication.java:221)
at com.badlogic.gdx.backends.jglfw.JglfwApplication.start(JglfwApplication.java:200)
at com.badlogic.gdx.backends.jglfw.JglfwApplication.initialize(JglfwApplication.java:180)
at com.badlogic.gdx.backends.jglfw.JglfwApplication$1.run(JglfwApplication.java:89)
at java.lang.Thread.run(Thread.java:745)
:tests:gdx-tests-jglfw:launchTestsJglfw

The issue is in a constructor in Animation.java:
public Animation (float frameDuration, Array<? extends T> keyFrames)
{
...
		T[] frames = (T[]) new Object[keyFrames.size];
...
}

One fix could be to support passing the type as a parameter to the constructor as Tom-Ski noted.

Sorry, my fault when I last updated Animation.
Using an Array internally doesn't help because the internal Array would still need to be aware of the type.
Take a look at the PR. I updated it to use a correct type of backing array if the source Array was type aware, and I made TextureAtlas.findRegions() return a type-aware Array.

In this PR. the reason I didn't add a constructor to Animation that has a Class parameter is that Array already has that option, so there's no reason to clutter this class with two more constructors. But I did need to update TextureAtlas to return type-aware Arrays to take advantage of this.

I get the same exception with libGDX 19.6 .

Can confirm. :-(

This PR was made after the 1.9.6 release. It won't show up until 1.9.7
unless you use the snapshot.
On Sat, Sep 30, 2017 at 5:39 PM Benjamin Schulte<EMAIL_ADDRESS>wrote:

Can confirm. :-(
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/libgdx/libgdx/issues/4476#issuecomment-333337669, or mute
the thread
https://github.com/notifications/unsubscribe-auth/ABwfuzYUB0qmFSzB5niAsTGLOr7icnOnks5snrUTgaJpZM4LKthd
.

Ah, I was not aware that it was pulled in June - did only see your commit from March. Thank you for pointing out.

This still happen in 2019. Any solution?

@samboadas221 This has already been fixed. Read the javadoc of the constructors carefully.


Device Encryption Support failed automatic device encryption

OS Name Microsoft Windows 10 Pro
[Version	10.0.19042 Build 19042]
Device Encryption Support Reasons for failed automatic device encryption:
PCR7 binding is not supported, Hardware Security Test Interface failed and the device is not Modern Standby, Un-allowed DMA-capable bus/device(s) detected, TPM is not usable

Is this a WSL issue? Can you explain how these are related?

Agreed with @DHowett , this seems unrelated. I'm going to close this out for bookkeeping, please add more context and a precise description of your issue so that we can understand it and reopen this if needed.

Never use Docker before, So for this first time I'm getting an error, An error occurred.
Relating errors, I am not sure 100%
but I think it's related to:
Hyper-V - VM Monitor Mode Extensions >Yes
Hyper-V - Second Level Address Translation Extensions >No
Hyper-V - Virtualisation Enabled in Firmware >No
Hyper-V - Data Execution Protection

Yes


Remove the OpenCV dependency in morph::Visual

Take opencv dependency away from morph::Visual by integrating the code from https://github.com/lvandeve/lodepng to save pngs.

Or alternatively https://github.com/randy408/libspng

Sorted with 01a4824fa5248027f


[AzureML] Remove hard dependency on requests

Azure SDKs support pluggable transports, while we use requests as our default, customers should be able to uninstall this an replace it with an alternative transport (e.g. aiohttp, httpx) without breaking any SDK functionality.
Ultimately it's planned that any direct imports of requests in the SDK will be blocked by CI:
https://github.com/Azure/azure-sdk-for-python/issues/24989

Tagging @azureml-github for broader visibility.

Now resolved :)


feat: cache init

I think the naming of CachedConstants<Fp> is misleading, it actual specifically means the constant of HashSpec<Fp, 3, 2>.


[embedded] Do not emit entry point data (__swift5_entry) in embedded Swift

This saves a couple bytes and a section in resulting binaries. We don't expect any embedded Swift usage to need this entry point section (instead, functions are either exported, or a main function is provided).

@swift-ci please test

@swift-ci please test


Scribble crashes my game!

I've implemented scribble in my game, but recently people have started to report Scribble-related crashes that I cannot seem to fix. I cannot reproduce the issue on my end so I was hoping to get some answers here. I'm consistently getting 2 crash reports.
Crash report #1:
For context - the object referenced in the error (obj_gate) does not contain any scribble code at all. Neither does it have any parents or child objects containing scribble code.
___
############################################################################################
ERROR in
action number 1
of Create Event
for object obj_gate:

DoAdd :2: undefined value
at gml_Script_scribble_tick
############################################################################################
gmlScriptscribble_tick (line -1)
gml_Script_anon@950@scribbleinitializescribble_system

Crash report #2:
___
############################################################################################
ERROR in
action number 1
of Draw Event
for object obj_header_money:

Variable <unknown_object>.__flushed(100103, -2147483648) cannot be resolved.
at gml_Script_scribble
############################################################################################
gml_Script_scribble (line -1)
gml_Object_obj_header_money_Draw_64

The object referenced in the error here does contain the following scribble code:
var _money = string(floor(money));
scribble("[spr_money]" + _money).scale(gui_text_scale).align(halign, valign).blend(color, 1).draw(gui_bbox_left + gui_text_margin, gui_y);

After giving it more thought it seems the errors are being reported by players shortly after updating the GameMaker Runtime to 11.1.160.
For more context - my game has a consistent playerbase of 1k+ daily users and the issue hasn't been reported before October 17th. Reverting runtime now to see if it still comes up.

What version of Scribble are you on? What platforms are you encountering the bug on? Are you distributing your game using YYC?
Somewhay unlikely to be Scribble itself considering the highly weird nature of these crashes and their recent occurrence. For example, __flushed is an intrinsic property of Scribble text elements and the text element cache only contains text elements so that variable must always exist for every member of the contents of that array.
From experience solving weird crashes in the past I'd guess that this is either:

2023.11 broke something inside the garbage collector
Some sort of global token (globalvar, macro, script, perhaps enum) is interfering with Scribble's operation
Rarely, a bug in YYC

It is going to be hard to track this down properly due to lack of repro. However, it looks like an invalid text element reference is being found inside Scribble's internal cache, either due to it being invalid to begin with or it being corrupted, or a bug in the garbage collector breaking something internally.
Quick word on that strange Create event error message - __scribble_tick() runs in a time source and that might be throwing the event name off.
I have some suggestions as to how to track down this bug. First thing is to set up some try...catch blocks in known sensitive areas to try to catch the issue as it happens. You can then mitigate the crash (hopefully it doesn't snowball!) and, more importantly, dump state to disk for analysis later. The real power move here is to set up a bug tracking service to automatically collect bug reports and state dumps.
If you do decide to implement try...catch blocks, please make multiple try...
catch blocks inside __scribble_tick(). It is not immediately clear to be exactly what part of it is crashing.
What state should you dump? I'd start with the contents of Scribble's internal caches. That'll tell us a lot about what Scribble thinks is happening. I'd also store any relevant game state too - what room the player is in, where they are in the room etc.  You'll need to use your kmowledge of your own game to figure out what's going on.
Let me know when you have some more data (exact repro obviously preferred!) and we can talk further.

Just wanted to follow this up to say that I reverted GameMaker Runtime version and the issue has since not come up again - so I assume there's an issue with Scribble and GameMaker Runtime 11.1.160.

Also to answer your questions:
What version of Scribble are you on? Latest one
What platforms are you encountering the bug on? PC (Steam)
Are you distributing your game using YYC?  No, I just have users send me crash errors

Did you make any further progress on this?

Did you make any further progress on this?

Thanks for checking back. I have managed to fix the issue, but I don't understand the logic behind it.
This piece of code was causing the game to crash when var _money was between 1.204.000 and 1.210.000 for which I have absolutely no logical explanation:
var _money = string(floor(money));
scribble("[spr_money]" + _money).scale(gui_text_scale).align(halign, valign).blend(color, 1).draw(gui_bbox_left + gui_text_margin, gui_y);

I have tried different things for hours but eventually managed to 'fix' the crash by adding a space:
"[spr_money]" > "[spr_money] "
I have not received any crash reports since then, so I'm confident this solved the issue. I don't understand what difference the space makes though.

lol what
Yeah I have no idea why that would be causing problems. There might be some sort of caching issue maybe? Very strange.


Studio bash logger

Adds bash logger to studio as #733 and #734 😁

closes partially https://github.com/iterative/leo-server/issues/36

10x smaller than #733; I like :P

10x smaller than #733; I like :P
2.5 times, bearing in mind that #733 had tests

10x smaller than #733; I like :P

2.5 times, bearing in mind that #733 had tests

Indeed your work is going to be used in leo-server at least

@0x2b3bfa0 @dacbd  - Ping for status. Since it was approved, can be merged  & released ?

Probably 😅

getting there, please hold 🙃

@dacbd Its ready to be merged. It worked perfectly. We are still missing the first provisioning state but that should be done in  tpi


chore: Update Service Mapping Option ADR

Basis for discussion.

For the service mapping topic, here is my opinion.

It makes sense to generate a default file (e.g., in the default path like odata), when there is no user input. The default service mapping can then be used as initial state and the user can adjust it.
I prefer having one service mapping file like the odata instead of N files for every service, because for example when using Concur, I as a user would like to make one config file instead of maintaining 10 files in different folders.
The missing part is the generation of the default service mapping then, I would also argue this can be improved after GA.
The naming of the service mapping is not perfect, but still ok. Some other alternatives can be service-config.json (--serviceConfig option).

@jjtang1985 We have now decided to NOT generate a service mapping by default. In know you were leaning in the other direction about this, therefore please review the outcome of the discussion. I added some more context on the service mapping specifically.
This is also discussed with @artemkovalyov.

As discussed, it's nice to have the alignment between odata and openapi. Removing the default file makes sense typically for openapi, which does not really need this mapping. For some special odata services, which needs this mapping, we'll improve it as a 2.0 topic.

For the service mapping topic, here is my opinion.

It makes sense to generate a default file (e.g., in the default path like odata), when there is no user input. The default service mapping can then be used as initial state and the user can adjust it.
I prefer having one service mapping file like the odata instead of N files for every service, because for example when using Concur, I as a user would like to make one config file instead of maintaining 10 files in different folders.
The missing part is the generation of the default service mapping then, I would also argue this can be improved after GA.
The naming of the service mapping is not perfect, but still ok. Some other alternatives can be service-config.json (--serviceConfig option).

@jjtang1985 We have discussed options around the naming here and came up with --optionsPerService. Is that name ok for you?

@jjtang1985 We have discussed options around the naming here and came up with --optionsPerService. Is that name ok for you?
Not bad, option is even better than config.


Update deps

This updates the deps for @bufbuild and @connectrpc to the latest. It also updates the setup-node Action to use the latest LTS.

It does enforce it, at least with nvm:
$ nvm use 20.0.0
Now using node v20.0.0 (npm v9.6.4)

$ nvm list
       v14.21.3
       v16.15.0
       v16.15.1
       v16.20.0
        v17.9.0
        v18.8.0
       v18.15.0
       v18.16.0
       v18.16.1
       v18.17.0
       v18.17.1
       v18.18.0
        v19.2.0
        v19.3.0
        v19.6.0
->      v20.0.0
        v20.8.0
        v20.9.0

$ cd plain                                                                                Found '/Users/sayers/Projects/examples-es/plain/.nvmrc' with version <20>
Now using node v20.9.0 (npm v10.1.0)

$ cd ..

$ nvm use 18
Now using node v18.18.0 (npm v9.8.1)

$ cd plain                                                                                Found '/Users/sayers/Projects/examples-es/plain/.nvmrc' with version <20>
Now using node v20.9.0 (npm v10.1.0)

Re: using --import, we can't use --loader either because that doesn't work with 20.6.0 and above. I reverted it back to using ts-node. It doesn't seem to make sense to switch it if we have to install tsx and using ts-node works in all versions.

It does enforce it, at least with nvm:

You already have v20.9.0 installed, so it's going to pick it for 20. But if you only have v20.0.0 installed, I expect it to pick this version instead, and not install or ask for the current LTS v20.9.0.

Re: using --import, we can't use --loader either because that doesn't work with tsx on 20.6.0 and above.

Oh boy :face_with_head_bandage:


Searching fields with special character

In my database, there is a field name called "@timestamp" which starts with a special character "@". Is it possible to search this field
using the NEST client?
In particular, I want to write something like below, which obviously didn't work:
var searchResponse = client.Search<Project>(s => s
  .Query(q => q
    .DateRange(r => r
      .Field(f => f.@timestamp // here
  ...

public class Project
{
    [Date(Name = "@timestamp")]
    public DateTime Timestamp { get; set; }
}

Add that property together with the attribute to your Project class. You can read more in the documentation about mapping.

Hi @ptrknow
As @mortenmoulder proposes, one way is to use attribute mapping. Another way would be to define the default mapping for Project on ConnectionSettings
public class Project
{
    public DateTime Timestamp { get; set; }
}

var projectsIndex = "projects";
var pool = new SingleNodeConnectionPool(new Uri("http://localhost:9200"));

var settings = new ConnectionSettings(pool)
    .DefaultMappingFor<Project>(i => i
        .IndexName(projectsIndex)
        .PropertyName(p => p.Timestamp, "@timestamp")
    );

var client = new ElasticClient(settings);

var createIndexResponse = client.Indices.Create("projects", s => s
        .Map<Project>(m => m
            .AutoMap()
        )
    );

var searchResponse = client.Search<Project>(s => s
    .Query(q => q
        .DateRange(r => r
          .Field(f => f.Timestamp)
          .GreaterThan(DateMath.Now)
        )
    )
);

results in
PUT http://localhost:9200/projects
{
  "mappings": {
    "properties": {
      "@timestamp": {
        "type": "date"
      }
    }
  }
}

POST http://localhost:9200/projects/_search
{
  "query": {
    "range": {
      "@timestamp": {
        "gt": "now"
      }
    }
  }
}

The Field type has implicit conversions from string, PropertyInfo and Expression<Func<TDocument, TProperty>> so you could do simply
var searchResponse = client.Search<Project>(s => s
    .Query(q => q
        .DateRange(r => r
          .Field("@timestamp")
          .GreaterThan(DateMath.Now)
        )
    )
);

However, you likely want the client to map the @timestamp returned in the _source document to a property on the Project type, in which case the client needs to be told about this either with attribute mapping or DefaultMappingFor<T>


Macro ring

Oh this'll be fun to review...

Regarding the following trick:

A version of this was already created on master previously, as documented below:

@Master-Bw3, @enjarai, and @Vlue, I'd like to keep only one of these. I personally prefer the one that accepts an address, as it's more versatile. But I'm not too set on the naming or pattern. Thoughts? (Pinging cotton as she was particularly interested in being able to get a list.)

I've made some changes that I'll push in a moment. Otherwise, the only issue I notice is that the macro map read/write tricks don't work if the ring is in the second slot. Also I'm sure enjarai has something to say about them being in the items category...

Oh last thing, I promise. It'd be nice if the trickster.spell.fragment.Map package didn't existence, and especially not capitalized in such a way. Perhaps Hamt would enjoy another home?

Anything I haven't covered, I've either touched in my commit, or it looks fine enough! Very nice PR, thank you.

The GitHub Actions build keeps failing, but even on a fresh clone of the repo it works for me... strange.

It's somehow my fault, but I don't know why...

Oh, it's the datagen.

Commit https://github.com/enjarai/trickster/pull/62/commits/29f1cb04b5ac14e6970d2de13d69e1b964ca92d1 solves the macros applying incorrectly in any kind of spell greater than a single circle due to changes in SpellPartWidget structure. In addition, it removes the attempt at using drawingPart for the replacement callback, when there is already a field on SpellPartWidget specifically for replacement callbacks. (I can't believe I didn't notice that merge conflict the first time.)

Hot damn this is a lot. I'm gonna have to take my time to sift through this today.

I'd like to keep only one of these. I personally prefer the one that accepts an address, as it's more versatile. But I'm not too set on the naming or pattern. Thoughts? (Pinging cotton as she was particularly interested in being able to get a list.)

I personally prefer the former. It's more atomic, and paired with other patterns which im pretty sure exist, the same effect can be had as with flock's.

I'd like to keep only one of these. I personally prefer the one that accepts an address, as it's more versatile. But I'm not too set on the naming or pattern. Thoughts? (Pinging cotton as she was particularly interested in being able to get a list.)

I personally prefer the former. It's more atomic, and paired with other patterns which im pretty sure exist, the same effect can be had as with flock's.

Alright, fair enough. Cotton said something similar in DMs.

@enjarai hey guess what, MapFragment is missing an implementation!

More recursive calculation of fragment sizes! Yippee!

Well this is an issue.

Found it.

The field depth is being incremented to a value greater than 6, and being used to access progressStack, which has a size of 7, when iterating over the Hamt... which is needed for weight calculations.

I've resolved https://github.com/enjarai/trickster/pull/62#issuecomment-2390364483 based on feedback from @enjarai and @Vlue.

Very important: worlds created with the latest commit cannot be loaded once saved. This is a critical issue that must be addressed as soon as possible.


How to open pdf file form url

There are some pull requests to add this functionality to the project but as it stands they are not 100% robust.
The url has to be downloaded and saved to the device before opening.
However, in my opinion this is out of scope for this project. There are potentially many things to consider like connectivity status, activity lifecycle, managing the cache etc. which should be handled by application developer.
So have a look at downloading files on Android, possibly using DownloadManager, a Service, AsyncTask or some library and implement for your own project.

You can use something like below:
new AsyncTask<Void, Void, Void>() {
@Override
protected Void doInBackground(Void... voids) {
try {
InputStream input = new URL("url here").openStream();
pdfView.fromStream(input).load();
} catch (IOException e) {
e.printStackTrace();
}
return null;
}
}.execute();

Where should I upload the PDF files to load them in my Android app from a URL?

@TuanSon The current thread is worker thread inside  doInBackground you need to move "pdfView.fromStream(input).load()" code line to onPostExecute.

How can I preview the pdf url file in the firebase in to my android application?

You can use something like below:
new AsyncTask<Void, Void, Void>() {
@override
protected Void doInBackground(Void... voids) {
try {
InputStream input = new URL("url here").openStream();
pdfView.fromStream(input).load();
} catch (IOException e) {
e.printStackTrace();
}
return null;
}
}.execute();
This is really works! Thank you!

@beckkey can you show me how it worked for plz

@beckkey can you show me how it worked for plz

I do something like this:
    @BindView(R.id.receipt_view)
    PDFView receiptView;

    private void getPdf() {
        new AsyncTask<Void, Void, Void>() {
            @SuppressLint("WrongThread")
            @Override
            protected Void doInBackground(Void... voids) {
                try {
                    InputStream input = new URL("http://www.africau.edu/images/default/sample.pdf").openStream();
                    receiptView.fromStream(input).load();
                } catch (IOException e) {
                    e.printStackTrace();
                }
                return null;
            }
        }.execute();
    }

Is there any way to save on device the pdf after it is loaded in pdfview as
stream? Or it needs to download the pdf before and then load as a file?
Any method to save on device the loaded pdf as stream directly ?
Thanks in advance for the answer.
Il Gio 21 Nov 2019, 13:18 beckkey<EMAIL_ADDRESS>ha scritto:

@beckkey https://github.com/beckkey can you show me how it worked for
plz
I do something like this:
@BindView(R.id.receipt_view)
PDFView receiptView;

private void getPdf() {
    new AsyncTask<Void, Void, Void>() {
        @SuppressLint("WrongThread")
        @Override
        protected Void doInBackground(Void... voids) {
            try {
                InputStream input = new URL("http://www.africau.edu/images/default/sample.pdf").openStream();
                receiptView.fromStream(input).load();
            } catch (IOException e) {
                e.printStackTrace();
            }
            return null;
        }
    }.execute();
}

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/barteksc/AndroidPdfViewer/issues/634?email_source=notifications&email_token=AHQ634EC7XFQDOQPLO6HZ73QUZ4BVA5CNFSM4FJY2EQ2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEE2A6GY#issuecomment-557059867,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AHQ634DETNVQIUMK6C3WNQ3QUZ4BVANCNFSM4FJY2EQQ
.

Is there any way to save on device the pdf after it is loaded in pdfview as stream? Or it needs to download the pdf before and then load as a file? Any method to save on device the loaded pdf as stream directly ? Thanks in advance for the answer.

You can modify the above function:
new AsyncTask<Void, Void, Void>() {
                @SuppressLint("WrongThread")
                @Override
                protected Void doInBackground(Void... voids) {
                    try {
                        File file = new File(activity.getCacheDir(), "receipt.pdf");
                        try (OutputStream output = new FileOutputStream(file)) {
                            byte[] buffer = new byte[4 * 1024]; // or other buffer size
                            int read;
                            InputStream test = new URL(receiptGetUrl).openStream();
                            while ((read = test.read(buffer)) != -1) {
                                output.write(buffer, 0, read);
                            }
                            output.flush();
                            PrintDocumentAdapter printAdapter = new PdfDocumentAdapter(file);
                            printManager.print("Document", printAdapter,new PrintAttributes.Builder().build());
                        } catch (FileNotFoundException e) {
                            e.printStackTrace();
                        } catch (IOException e) {
                            e.printStackTrace();
                        }
                    } finally {
                        try {
                            input.close();
                        } catch (IOException e) {
                            e.printStackTrace();
                        }
                    }
                    return null;
                }
            }.execute();

As you can see, pdf downloaded and saved as a file. You can do anything with saved pdf file (by default file saved in temp dir). In this example file printed with default android print manager.

Thank you so much for your quick reply and for your code!
I wanted to open and view the pdf first in the pdfview from an url as
stream and then have the chance to save it on device... I guessed it was
not possible and it needs the file to be stored first on device... But you
give me a good idea for storing first in temp dir and then printing it. I
will try your code!! Thanks again.
Il Ven 22 Nov 2019, 08:57 beckkey<EMAIL_ADDRESS>ha scritto:

Is there any way to save on device the pdf after it is loaded in pdfview
as stream? Or it needs to download the pdf before and then load as a file?
Any method to save on device the loaded pdf as stream directly ? Thanks in
advance for the answer.
You can modify the above function:
new AsyncTask<Void, Void, Void>() {
@SuppressLint("WrongThread")
@Override
protected Void doInBackground(Void... voids) {
try {
File file = new File(activity.getCacheDir(), "receipt.pdf");
try (OutputStream output = new FileOutputStream(file)) {
byte[] buffer = new byte[4 * 1024]; // or other buffer size
int read;
InputStream test = new URL(receiptGetUrl).openStream();
while ((read = test.read(buffer)) != -1) {
output.write(buffer, 0, read);
}
output.flush();
PrintDocumentAdapter printAdapter = new PdfDocumentAdapter(file);
printManager.print("Document", printAdapter,new PrintAttributes.Builder().build());
} catch (FileNotFoundException e) {
e.printStackTrace();
} catch (IOException e) {
e.printStackTrace();
}
} finally {
try {
input.close();
} catch (IOException e) {
e.printStackTrace();
}
}
return null;
}
}.execute();
As you can see, pdf downloaded and saved as a file. You can do anything
with saved pdf file (by default file saved in temp dir). In this example
file printed with default android print manager.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/barteksc/AndroidPdfViewer/issues/634?email_source=notifications&email_token=AHQ634HCBLLPOEFI5PIF4GDQU6GGNA5CNFSM4FJY2EQ2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEE43OXI#issuecomment-557430621,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AHQ634E7QJ4ACXI3UKAQDILQU6GGNANCNFSM4FJY2EQQ
.

KOTLIN CODE WITH PROGRESS BAR
private fun loadPdf() {
MyAsyncTask(this).execute()
}
companion object{
    class MyAsyncTask internal constructor(context: MainActivity) : AsyncTask<Unit, Unit, InputStream>() {
        private val activityReference: WeakReference<MainActivity> = WeakReference(context)
        override fun onPreExecute() {
            val activity = activityReference.get()
            if (activity == null || activity.isFinishing) return
            activity.progressBar.visibility = View.VISIBLE
        }

        override fun doInBackground(vararg params: Unit): InputStream {
            return URL("https://www.w3.org/WAI/ER/tests/xhtml/testfiles/resources/pdf/dummy.pdf").openStream()
        }

        override fun onPostExecute(result: InputStream) {
            val activity = activityReference.get()
            if (activity == null || activity.isFinishing) return
            activity.progressBar.visibility = View.GONE
            activity.pdfView.fromStream(result).load()
        }

    }
}

This works. Thanks

You can load pdf from stream using Executors from java.util.concurrent package like this on kotlin lang:
val executor = Executors.newSingleThreadExecutor()
val handler = Handler(Looper.getMainLooper())
val url = "https://document_url.pdf"

executor.execute {
    val input = URL(url).openStream()
    handler.post {
        pdfView.fromStream(input).load()
    }
}

Source: my answer on stackoverflow.


Plant and Defused types are mixed up

Describe the bug
Defuser event types sometimes to not line up
To Reproduce
Team Secret .vs KOI Villa @ 2023-04-12 Blast/EU 2023 Stage 1 LCQ
9th round, Team Secret plants, KOI defuses
Current behavior
{
            "type": {
                "name": "DefuserPlantStart",
                "id": 2
            },
            "username": "yzn.SECRET",
            "time": "0:27",
            "timeInSeconds": 27
        },
{
            "type": {
                "name": "DefuserPlantStart",
                "id": 2
            },
            "username": "cryn.KOI",
            "time": "0:40",
            "timeInSeconds": 40
        },
        {
            "type": {
                "name": "DefuserPlantComplete",
                "id": 3
            },
            "username": "cryn.KOI",
            "time": "0:33",
            "timeInSeconds": 33
        }

Expected behavior
{
            "type": {
                "name": "DefuserPlantStart",
                "id": 2
            },
            "username": "yzn.SECRET",
            "time": "0:27",
            "timeInSeconds": 27
},
{
            "type": {
                "name": "DefuserPlantComplete",
                "id": 'idk whats meant to be here instead'
            },
            "username": "yzn.SECRET",
            "time": "0:27",
            "timeInSeconds": 27
},
{
            "type": {
                "name": "DefuserDisableStart",
                "id": 'idk whats meant to be here instead'
            },
            "username": "cryn.KOI",
            "time": "0:40",
            "timeInSeconds": 40
        },
        {
            "type": {
                "name": "DefuserDisableComplete",
                "id": 'idk whats meant to be here instead'
            },
            "username": "cryn.KOI",
            "time": "0:33",
            "timeInSeconds": 33
        }

Additional context
Seems to be getting confused on whether a player is planting or disabling the defuser.
Defenders, obviously should never be able to plant a defuser and visa versa.

interesting, will take a look

do you still experience this issue @Grimbyy? if so, do you have a more recent replay that exhibits this behavior?

@redraskal I actually do have a newer replay that exhibits this behaviour. According to r6-dissect the defender donkabi70 successfully started and finished planting the bomb when in reality he/she defused it.
I renamed the file to end with .png because of Github file upload limitations.


improve bounding box queue for other coord systems

Transform operator supports coordinate transforms. For example cylindrical (in database) to cartesian (VisIt internal) or spherical (in database) to cartesian (VisIt internal). However, once you do that, the bounding  box visual queue axis tick marks, labels, etc. aren't all that useful.
I suggest the following feature enhancement...

add option to annotation object to support cylindrical and spherical equivs of square bounding box. The cylindrical case is obvious. The spherical one is less so. But, in either case, one can imagine for angular dimensions having circles drawn on the bounding box faces with tick marks around those circles. Radial dimension can then be a line drawn from the middle of those circles to the edges, perhaps along the two cartesian directions the face is parallel too.
Add an 'auto' option to the above where annotation attributes bounding box mode takes its queue from output of transform operator. If mutliple plots and all do not have a coordinate transforming transform operator applied, not sure what to do in that case as it would mean the object(s) being visualized consist of a mix of coordinate systems. Oh, wait, display both then...bounding box with tick marks on the box edges and circles on the appropriate faces (as determined by cylindrical or spherical coords).
Ok, so the annotation object control here just turns on/off circle displays on the bbox faces either manually as requested by user or automagically as determined by transform operator existence.

Another attempt at suggesting how to do this. I looked on line for some refs. Couldn't find any tools that do vis. of the coordinate axes


Restore scipy.linalg.calc_lwork also in master

Forward port of gh-4418

Scipy tests and statsmodels 0.6.1 pass.

In it goes. Thanks Pauli.


Add EXPOSE to DockerFile

Please add EXPOSE port to dockerfile, as this will add support to docker desktop app on windows. Without this, you can't set port in the desktop app.

@pete02 I will submit a fix in 1hr, thanks for reporting

@pete02 This should now be available with the latest tag


_HW_INITIALIZATION_DATA isn't correct.

Structure in 17134 Storport.w you must pull the correct header for documentation.  #ifdef < Win8 is above here.  >= Win8
#if (NTDDI_VERSION >= NTDDI_WIN8)
//
// Define new HW_INITIALIZATION_DATA to support extended SRB type. Going
// forward, VIRTUAL_HW_INITIALIZATION is consolidated into
// HW_INITIALIZATION_DATA so there is only one structure to maintain.
//
typedef struct _HW_INITIALIZATION_DATA {
ULONG                       HwInitializationDataSize;
INTERFACE_TYPE              AdapterInterfaceType;
PHW_INITIALIZE              HwInitialize;
PHW_STARTIO                 HwStartIo;
PHW_INTERRUPT               HwInterrupt;
//
// If miniport is physical, HwFindAdapter shall be of type PHW_FIND_ADAPTER.
// If miniport is virtual, HwFindAdapter shall be of type
// PVIRTUAL_HW_FIND_ADAPTER.
//
PVOID                       HwFindAdapter;
PHW_RESET_BUS               HwResetBus;
PHW_DMA_STARTED             HwDmaStarted;
PHW_ADAPTER_STATE           HwAdapterState;
ULONG                       DeviceExtensionSize;
ULONG                       SpecificLuExtensionSize;
ULONG                       SrbExtensionSize;
ULONG                       NumberOfAccessRanges;
PVOID                       Reserved;
UCHAR                       MapBuffers;
BOOLEAN                     NeedPhysicalAddresses;
BOOLEAN                     TaggedQueuing;
BOOLEAN                     AutoRequestSense;
BOOLEAN                     MultipleRequestPerLu;
BOOLEAN                     ReceiveEvent;
USHORT                      VendorIdLength;
PVOID                       VendorId;
union {
USHORT ReservedUshort;
USHORT PortVersionFlags;
} ;
USHORT                      DeviceIdLength;
PVOID                       DeviceId;
PHW_ADAPTER_CONTROL         HwAdapterControl;
PHW_BUILDIO                 HwBuildIo;
//
// Following 5 callbacks are virtual miniport specific and should not be set
// by physical miniports.
//
PHW_FREE_ADAPTER_RESOURCES  HwFreeAdapterResources;
PHW_PROCESS_SERVICE_REQUEST HwProcessServiceRequest;
PHW_COMPLETE_SERVICE_IRP    HwCompleteServiceIrp;
PHW_INITIALIZE_TRACING      HwInitializeTracing;
PHW_CLEANUP_TRACING         HwCleanupTracing;
//
// New fields should only be added after this one as the previous fields match
// the HW_INITIALIZATION definition for pre-Win8.
//
PHW_TRACING_ENABLED         HwTracingEnabled;
// Used to indicate features supported by miniport such as virtual miniports
ULONG             FeatureSupport;
// New fields added to support extended SRB format(s)
ULONG             SrbTypeFlags;
ULONG             AddressTypeFlags;
ULONG             Reserved1;
//
// Unit control callback
//
PHW_UNIT_CONTROL  HwUnitControl;
} HW_INITIALIZATION_DATA, *PHW_INITIALIZATION_DATA;

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 3eb29277-0674-6534-c5b3-33f23c8d1139
Version Independent ID: 56fc2963-d527-21e9-5411-8d721ce1bc81
Content: _HW_INITIALIZATION_DATA
Content Source: wdk-ddi-src/content/storport/ns-storport-_hw_initialization_data.md
Product: windows-hardware
GitHub Login: @windows-driver-content
Microsoft Alias: windowsdriverdev

Thanks, @Ron-Hu
@aahill can you triage and correct, please?

Thanks for your help and patience Ron, I was able to find the right header and location. I've updated the page with the correct information, but the structure's syntax block is causing some strange behavior in our content rendering system. I'm following up with our support team, and will update the thread once we have the issue figured out, and the update live.

Hi again @Ron-Hu, the rendering system should be fixed soon, after which I'll promote the changes live. Should be a day or so.
Thanks again for bringing this to our attention!


[WIP] MFA Workflow UI

MFA UI

@eleanorakh 🙈 I couldn’t help myself — I’ve created issues for all the stuff we picked up so far. Should make it much easier to work on em’ together I reckon.


Additional localizations

Add additional localizations to the current ones (en-US and es-ES) using https://poeditor.com/.

A system without end of cycle has been implemented so that the community can translate the bot: https://poeditor.com/join/project/emirhxA4pG


17 q3 dev

worked at the beamline on Ophyd startup files and learning how to push in github

I'm going to merge this for now I may clean this up a little before tomorrow.


Use delayed translations for constants

We cannot use a plain _() for constants, since these are being evaluated at the app load
time (rather than run time). We need to use N_() here (delayed translation) and apply
the gettext where needed in run-time (in this case, in the view).
Reproducer:

Switch to non-English locale
Storages -> Storage Manager -> Monitoring -> Timelines, look at the first dropdown
The strings in the first dropdown are in English

https://bugzilla.redhat.com/show_bug.cgi?id=1393310

Euwe backport details:
$ git log -1
commit<PHONE_NUMBER>982ff02b547d17f9f011b3a8b2e55e
Author: Dan Clarizio<EMAIL_ADDRESS>Date:   Mon Nov 21 10:12:53 2016 -0800

    Merge pull request #12769 from mzazrivec/gettext_fix_in_timelines_screen

    Use delayed translations for constants
    (cherry picked from commit 13b28699af2223c71bd05c7b2642a4a8a2cda850)

    https://bugzilla.redhat.com/show_bug.cgi?id=1397532