Wrong menu items ordering in the first load

It's when load for the first time

It's fix after rearrange again in menu items management

Issue still exist, please re-check
thankyou


Support Range for non ValueTuple by remove the GetOffsetAndLength method

Description (optional)
Support Range for non ValueTuple by remove the GetOffsetAndLength method
Rationale
Code like "Hello World"[..5] does not need to use Range. It just be compiled to "Hello World".Substring(0, 5). So please remove GetOffsetAndLength when ValueTuple is not referenced like this Range.cs.

Things like (a, b) = (b, a) does not need to use ValueTuple. Why they have to check ValueTuple existing?

Things like (a, b) = (b, a) does not need to use ValueTuple. Why they have to check ValueTuple existing?

The final codegen of swapping variables not using ValueTuple due to optimization doesn't mean the compiler won't check the existence of ValueTuple to make sure the ValueTuple feature itself works. And the compiler still needs to get the type ValueTuple so that it can bind the symbols.

But (a, b) = (b, a) can't be ValueTuple. Create ValueTuple need (var c, var d) = (b, a). Distrust (a, b) = c seems not check ValueTuple.

You are trying to construct a ValueTuple at the right expression (b, a), but as for (a, b) = c where (a, b) is on the left, it is a completedly unrelated feature called destruction.

...


Add timeouts to logic blocks

Add a timeout to logic blocks such as counters, sequences and sequels. It should reset the block if it expires. This should only cover this very basic usecase and everything advanced can use an external timer.

Jan,  I'll take this one.  I have it 90% done, but not sure how to instantiate a timer.  I have looked at code elsewhere, but its completely different between high scores and sequence shots.  How should this be implemented?  When it is enabled, I want to start the timer (in its own def), and when it hits the value set in the config, then it should trigger.  The def calls the reset method, and restarts the timer (reset calls the def to reinstantiate it).
I am sure there is some module that already exists that says when the method is called start ticking.  Then I can write my def to write a while loop and check the timer against the value in the config.  Then when its called again, it would reset that system timer and go again.  Any method or imported class would help so I am not trying to reinvent the wheel.  Once that is done, I have the tests written, and should be just some minor debugging.

Awesome. We usually use DelayManager for that. If you search the MPF code you should find a few examples. If not please ask.
Jan

Jan,
Thanks! After going around a bit more I found the delays.py, etc high contains that. I was just struggling with how to pass the arguements. But now that I have this, I think I should be able to get it working.
I am doing one at the logic block level called logic_lock_timeout that works for all three (counters, accruals and sequences). Are you okay with that? Or do you want me to build it at the lower level and have counter_timeout, etc.?
Sent from my iPhone

On Apr 21, 2021, at 1:56 AM, jabdoa2 @.***> wrote:

Awesome. We usually use DelayManager for that. If you search the MPF code you should find a few examples. If not please ask.
Jan
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or unsubscribe.

Jan,
Handled in PR 1564.  We can move convo over there, and then close this once we get that approved and merged.


[porn] False positive, libgen.is.

Please consider removing libgen links from porn list.

https://github.com/StevenBlack/hosts/issues/2337

Thank you    Lucio @mabequinho.
Ping @sinfonietta, looks like all of these could be false positives, the first one looks invalid:
9546:<IP_ADDRESS> libgen.i
9547:<IP_ADDRESS> libgen.is
9548:<IP_ADDRESS> libgen.onl

Closing!


Delete this repo.

Its outdated and we can install from the original repo: https://github.com/ujifgc/pagedown
Having this listed in the bower packages is actually causing conflicts.

@givanse What bower package do you recommend that uses the original repo?


feat: which-key integration

Add which-key label when available
Fixes https://github.com/LunarVim/LunarVim/issues/2022

Thanks for working on this. But I have to decline as I don't want to integrate other plugins like which-key.
As you might know, I made some APIs public so the user can use them as they please. In your case, you can bind them to support which-key. Please read https://github.com/numToStr/Comment.nvim/blob/master/doc/API.md
Side note: Current API might be limiting but you can easily use the internal functions to make up for what's missing. I'll soon work on expanding the API :)

As you might know, I made some APIs public so the user can use them as they please. In your case, you can bind them to support which-key.

Just in case you missed it, I'm only adding the labels here. The actual binding is still done using the native API. And even if which-key is installed but not loaded, it will still load the keys correctly. I figured that I can share this for others, because the alternative is either maintaining a duplicate list of keymaps or removing the setup function altogether and thus disabling the bindings themselves and set them manually.

Please read master/doc/API.md

I already went through it to be able to fix the table :)

Which-key does support "label only" registrations. For example, the default keymaps for Comment.nvim could be labeled:
local wk = require('which-key')

-- basic
wk.register({
  gb = 'Togggle block comment',
  gbc = 'Toggle block comment',
  gc = 'Toggle line comment',
  gcc = 'Toggle line comment',
}, { mode = "n" })

wk.register({
  gb = 'Togggle block comment',
  gc = 'Toggle line comment',
}, { mode = "x" })

-- extra
wk.register({
  gco = 'Comment next line',
  gcO = 'Comment prev line',
  gcA = 'Comment end of line',
}, { mode = "n" })

-- extended
wk.register({
  ["g>"] = 'Comment region',
  ["g>c"] = 'Add line comment',
  ["g>b"] = 'Add block comment',
  ["g<lt>"] = 'Uncomment region',
  ["g<lt>c"] = 'Remove line comment',
  ["g<lt>b"] = 'Remove block comment',
}, { mode = "n" })

wk.register({
  ["g>"] = 'Comment region',
  ["g<lt>"] = 'Uncomment region',
}, { mode = "x" })


How to use this as the reference policy?

I'm trying to use unsloth, PPOTrainer and vllm to write a RLHF trainer. Now their is a problem that when I called model.eval() and model.train(), it actuall gives different logprobs(it can't be dropout, since a training model gives stable logprobs, and temperature isn't the issue). this could cause problems like negative KL.

In theory, the vllm.generate, unsloth model(under training = True) and unsloth(under training = False) should give the same logits under same policy and generation condition(plus top_k = 0), but they are actually different(I copy the weights of policy to vllm before every rollout)


webkit: file upload button not completely cursor pointer

Check with chrome on materializecss.com/forms.html, hover mouse over file upload button. Only the bottom area of the button shows the pointer cursor, the text overlays the button at the top.
To fix this, add this:
.file-field input[type=file]::-webkit-file-upload-button {
  display: none;
}

Great tip @fabyeah, thank you ;-)

Still not fixed.
Here is the video demo - https://share.viewedit.com/aDEkxpHY27Yn3E5K9a6xCc

Please test the following code
.file-field input[type=file]  {
    text-indent: -999px;
}

.file-field .btn, .file-field .btn-large {
    position: relative;
    overflow: hidden;
}

@kmmbvnr I can't spot the issue

@tomscholz inspect the file input element, its size and how the cursor changes when moving the mouse over it. Same in Chrome.

Added in 494df27b

input[type='file']{
opacity: 0;
cursor: pointer;
width: 24px;
height: 24px;
font-size: 0;
position: absolute;
}

cursor:pointer does not work on input file just because of the default button. No special reason here. You need to remove its appearance via this code, pay attention with font-size:0.
It works perfectly on Chrome, Firefox and IE for me. I hope, this will also help you.

Check with chrome on materializecss.com/forms.html, hover mouse over file upload button. Only the bottom area of the button shows the pointer cursor, the text overlays the button at the top.
To fix this, add this:
.file-field input[type=file]::-webkit-file-upload-button {
  display: none;
}

Targeted by class name and works completely fine , Thanks a lot man


Fix code style for Rubocop 1.16.0

I updated rubocop rules in our template-gem, please rebase this branch.


Convert result numpy.product (Pt. 2)

Missed another numpy.product that needed conversion to int. This fixes it.
xref: https://github.com/nanshe-org/nanshe/pull/387

Trying to restart CI.

Having issues downloading stuff from anaconda.org.


Add workflows feat/use-package-type.git.md

here.Tap workflow direct to master use package-repository.md

Closing, this, as it's missing a description why it would be a good addition and useful.


Create facebook pixel Integration extension

Could You provide some more spec + acceptance criteria for this featuer?

facebook pixel plugin：like
https://marketplace.magento.com/apptrian-facebook-pixel.html

Plugin available here https://github.com/new-fantastic/vsf-facebook-pixel


minor: release remove rule react/jsx-no-target-blank

ok, I don't know what I'm doing. sorry. 😬

Hehe no worries. This is my experience every time with semantic release 😄
Looks like this didn't run in Circle because this repo hasn't been bumped to use Circle 2 and it's the Circle build that does the semantic release. I'll fix that and get this released.


Logo for Android-Call-Sms-Blocker

Hi sir. I'm graphic designer. I have studied your work and I think a new design will make you more visible. I would like to offer logo. I can give you all the formats of the design free. If you want I send you PR or a change please specify.

Thanks @familqasimov, am still working on this project it might take few weeks to improve this in UI wise. Will happy to take your help to improve the UI / screens. You can post the layout over here / raise a merge request for the same.

I have a few works in Hospital. I can send you PR in yesterday, if you want.
Best regards
Famil Qasimov
3 may 2018, C.A. 12:27 tarixində Rohit Mahto<EMAIL_ADDRESS>yazdı:

Thanks @familqasimov https://github.com/familqasimov, am still working
on this project it might take few weeks to improve this in UI wise. Will
happy to take your help to improve the UI / screens. You can post the
layout over here / raise a merge request for the same.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/mahtorohit/Android-Call-Sms-Blocker/issues/4#issuecomment-386224311,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AivpjQxDxRBji4THgPhokYSDExiXWGdzks5tur9lgaJpZM4TwAlq
.


Scrolling a tab with scroll wheel while holding a layout placeholders desyncs the position of the layout placeholder with the mouse position.

Oh wow, apparently having "Fixes #18" in the commit message automatically closed this issue. neat.


Check config loader in nested functions

for config values changed while runtime

works even if the module is re-imported


feat: basic working version

This PR adds the functionality needed for a basic working version

/stub: maybe change to better fitting name or move content to domain
station_query_protocol.py [27:33]: refactor for better readability and add comments for understanding the solved Problem
ctx.storage for handling stations: imo a lightweight database is more suitable bc ctx.storage is in memory and maybe would cause future Problems with performance when gas_goblin crashes. gas_golbin should maintain a small database with few data points and save them on local storage. On changes add, change or delete station. In memory solutions are just for debugging and dev imo.
asyncio.ensure_future: add comment for better understanding

1:
I feel like /stub is a pretty fitting name since it is only there to help debug/test the "real" code - https://en.wikipedia.org/wiki/Method_stub

3:
I agree but I don't think it is necessary for this PR and should be added in a future one


JavaScript: default parameter causes type to be incorrectly inferred

From https://github.com/Microsoft/vscode/issues/62013

TypeScript Version:  3.2.0-dev.20181027

Search Terms:
Code
For the javascript:
var SomeObject = {
    SomeFunction: function (SomeInput) {
        return SomeInput * 2;
    },
    SomeOtherFunction: function (SomeOtherInput, SomeOptionalInput = SomeObject.SomeFunction(2)) {
        return SomeOtherInput * SomeOptionalInput;
    }
};

SomeObject

Hover over SomeObject
Bug:
Type is any. If the default parameter is removed then the type is correct

It looks like something causes us to pull on the signature type early which, with the initializer, depends on the object type itself and causes it to get marked as circular, specifically with noImplicitAny on, we get the
'SomeObject' implicitly has type 'any' because it does not have a type annotation and is referenced directly or indirectly in its own initializer.

error. Thing is, if you wrote the same thing in a more namespace-y way:
namespace SomeObject {
    export function SomeFunction(SomeInput) {
        return SomeInput * 2;
    }
    export function SomeOtherFunction(SomeOtherInput, SomeOptionalInput = SomeObject.SomeFunction(2)) {
        return SomeOtherInput * SomeOptionalInput;
    }
}

we do waaaaaaaay better, even though the two are pretty much equivalent in this case. I think that technically this is working as intended; but for the sake of our JS users, we could do better here.

One more example of this:
type Currency = {
  unit: 'EUR' | 'GBP' | 'JPY' | 'USD'
  value: number
}

let Currency = { // TypeError 1
  DEFAULT: 'USD',
  from(value: number, unit = Currency.DEFAULT): Currency { // TypeError 2
    return {unit, value}
  }
}

It would be nice if this typechecked, since when you run it, it works as expected. Would this be a lot of work to improve?


How to visualize the Figure3?

Hello,
Thanks for this amazing work!
I want to know how to obtain distribution like Figure3. Can you share the visualization code with me?
I am looking forward to your reply!

1, get the attention-map outputs of some samples
2, draw data bins(i.e. 2048 bins) in figure use the pyplot

Thanks for your reply!
I want to know how to set the x-axis like Figure3？And, how many samples you used？

Thanks for your reply!
I want to know how to set the x-axis like Figure3？And, how many samples you used？

use matplotlib with plt.xscale('log')
We use 100 random samples on ImageNet and we believe that the number of samples has little influence on that distribution.


Document setAttribute to update document using Postgresql 9.5's jsonb_set

Make use of Postgresql 9.5's jsonb_set to update a document attribute.
Will append if key is not found -- may need to revisit this default behavior.

Hi @dmfay. Is there any plan to continue to support 9.4? The tests now fail when running against 9.4.

Confirmed - quite a few failing tests with this PR. Please revert.

Looks like it's polluting the schema. There's another ES6-only bit I inadvertently added a little while back so I'll see if I can fix everything up quickly. @robconery can you take a look at #165 when you have a minute? I didn't want to take over management stuff like that...

Done :)

On Jan 26, 2016, at 9:25 AM, Dian Fay<EMAIL_ADDRESS>wrote:
Looks like it's polluting the schema. There's another ES6-only bit I inadvertently added a little while back so I'll see if I can fix everything up quickly. @robconery https://github.com/robconery can you take a look at #165 https://github.com/robconery/massive-js/pull/165 when you have a minute? I didn't want to take over management stuff like that...
—
Reply to this email directly or view it on GitHub https://github.com/robconery/massive-js/pull/182#issuecomment-175128549.


Add O:XML

Adding a language
Add O:XML

[x] The code displays "Hello World"
[x] I have updated the readme to include the new language
[x] I have incremented the language count in the readme
fixes part of #790

@Richienb does it matter if I use a commit message when making a pull request?

Should it be o:XML or O:XML

It should be o:XML like on the homepage.

Done ✔

Thank you
On April 27, 2021, at 9:03 PM, Richie Bendall @.***> wrote:
Merged #991 into master.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.￼
[ { @.": "http://schema.org", @.": "EmailMessage", "potentialAction": { @.": "ViewAction", "target": "https://github.com/leachim6/hello-world/pull/991#event-4653867429", "url": "https://github.com/leachim6/hello-world/pull/991#event-4653867429", "name": "View Pull Request" }, "description": "View this Pull Request on GitHub", "publisher": { @.": "Organization", "name": "GitHub", "url": "https://github.com" } } ]

Hey, I shared some photos and videos with you. Click here to view and add your own: https://www.amazon.com/photos/groups/share/mrwz0VMOSmqA9arXxitLPA.hWFExGjVjwt6r1dGkhZ6-o?i=t
Get Outlook for Androidhttps://aka.ms/AAb9ysg


Specific nested masks + filter breaks drawing (v5 and v4)

Expected Behavior
Filters and masks should work together normally
Current Behavior
Objects disappear and only certain masks are applied
Steps to Reproduce
In Pixi5, the issue occurs when a filter is added to an object (A) which contains a masked child object, and object A's parent chain includes an EVEN number of masks >= 2.
In Pixi4, the issue occurs when object A's parent chain includes an ODD number of masks >= 3.
Test Case
https://www.pixiplayground.com/#/edit/PmNR2aqebJB2i56E5IiBz
In the test case, 4 objects are created, each with a masked bunny and a gray bg.  Clicking on an object will move it down by 10px and add a ColorMatrixFilter which darkens the object, clicking again will restore it.
You can change the level of nesting by modifying the length prop on line 69 - a value of 0 will add the objects directly to the stage, 1 will make a single container, etc.  Each container has a different background color, and each mask's x position is offset by 10px to make it easier to visualize the nesting.
Pixi5
Changing the level of nesting to anything >= 2 will show the problem.  If the level of nesting is EVEN, clicking on the objects will make them disappear (since it adds a filter), and once all 4 have filters, the circle at the bottom will no longer be drawn.  If the level of nesting is odd, the objects won't disappear, but you can see that only alternating masks are being applied (changing the nesting level to 7 and clicking on the first object makes this very clear, as you can notice the "jailbars" effect at the left while the object is masked).
Pixi4
Running the same playground link in pixi4 will result in similar problems, except the nesting level has to be >=3, and the objects will disappear if the level of nesting is ODD, vs EVEN in pixi5.

OK guys, we failed somewhere in MaskSystem in both versions.
https://github.com/pixijs/pixi.js/blob/dev/packages/core/src/mask/MaskSystem.js#L173
https://github.com/pixijs/pixi.js/blob/dev/packages/core/src/mask/StencilSystem.js#L55
Ideas?

Filter and masks are working together here: https://github.com/pixijs/pixi.js/blob/dev/packages/core/src/renderTexture/RenderTextureSystem.js#L98

Can you check the result please? https://www.pixiplayground.com/#/edit/t09LhS3_ttR6R7przuBOi
That gray bar at the right - is that supposed to happen?

Nope, the bar shouldn't be there - nothing should go out of the green square.
I also noticed that when you click on the 3rd item, the bunny in the 4th item is masked properly, but it's background isn't:

On the plus side, nothing disappears anymore.

OK, now its better. Right?

Yep, I just checked again, and it looks like it's working great, thanks!  Is https://pixijs.download/fix-mask-filters/pixi.js in a state where I can try my actual code against it?

yep.

Ok, great, I'll try it out and let you know.

we just found a critical in separate thread, so you'll have to move to dev version as soon as both PR's get merged.

I just tried it on our actual code, and it works great, thanks again!


longest_common_prefix_java code

This is the java code for longest common prefix @plazzy99 @rish-singhal

Resolve conflicts. Sort the readme list & give spaces around operators =,>,<,... if they are not there.

@rish-singhal

Resolve conflicts

Resolved

@rish-singhal check the changes requested by you

@ssaumyaa7 make these changes before 31/05 to get this PR marked under GSSOC

@Rohan27s @rish-singhal

Which issue is this PR for?

I don't know what issue is there, from my end it is indented well. Please check.

Hey also give extra line before function declaration.

That's weird let me see again on GitHub.

the two brackets are not properly aligned.


Add windowInsets to BottomSheet

Please add windowInsets to bottomsheet navigator. I tried using windowInsetsPadding in bottomsheet screen's content, however it work fine on Android. But doesn't work properly on iOS.
I tried the
ModalBottomSheet(
            onDismissRequest = { historyExpanded = false },
            sheetState = modalBottomSheetState,
            dragHandle = { BottomSheetDefaults.DragHandle() },
            windowInsets = WindowInsets.safeDrawing
        )

It works fine on both android and iOS

Updating like this can solve the issue
ComposeUIViewController(
    configure = {
        onFocusBehavior = OnFocusBehavior. DoNothing
    }
) {
    // Composable content
}


Version 0.12.2

Codecov Report

Merging #716 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #716   +/-   ##
=======================================
  Coverage   95.29%   95.29%
=======================================
  Files          83       83
  Lines        9014     9014
=======================================
  Hits         8590     8590
  Misses        424      424

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a7ecabc...e1684f4. Read the comment docs.


Feature request: being able to edit item pages

I was able to do it for this page:
https://tanyaclement.github.io/znh_jacksonville_1939/t86-243/
But not this page:
https://tanyaclement.github.io/sexton_sweetbriar_1966/anne-sexton-at-sweetbriar-1966/

Fixed.  The problem was the jekyll template wasn't updated on the AudiAnnotate server.  (We had manually merged it into the ZNH project.)


Filter for memory search

I need some sort of prefiltering for my embedded documents that is more sophisticated than only having different indexes. Our customer has multiple products in multiple product categories and also multiple versions of the same product over the past time. I need to specify some sort of combination of those categories before searching otherwise I might end up with, say 10 top results but they all are for another product so filtering after search does not work.
Best case would be some sort of prefiltering based on the metadata of the entries.
As SK supports multiple vector DBs this might need to have some sort of fallback implementation if the underlying DB does not support additional query parameters.
Maybe the open-ai plugin implementation could be used as a blueprint for this:
https://github.com/openai/chatgpt-retrieval-plugin/blob/main/datastore/providers/redis_datastore.py#L221

@HSven1611 We did it for QDrant (but extendible to other DBs) in our fork and are trying to merge it, although it's apparently waiting for some major architecture changes before we can continue...
https://github.com/microsoft/semantic-kernel/pull/1481

@HSven1611 , thank you for bringing this up, we have work in process to make this easier for you.  You should be able to start doing filtering in a few more weeks.

What's the status on this? My use case also requires pre-filtering of the documents in an ACS index, so I'm curious to know if there has been any progress here.

@dluc has implemented filtering in the Semantic Memory project. Does this address your needs?

I think it does. We worked around this issue by using multiple indices for now.

All .Net issues prior to 1-Dec-2023 are being closed. Please re-open, if this issue is still relevant to the .Net Semantic Kernel 1.x release. In the future all issues that are inactive for more than 90 days will be labelled as 'stale' and closed 14 days later.


Any Release for NuGet Package?

Can you publish a release of binaries and push output to an artifact like NuGet?

There wasn't any release but I made quick publish after you open this issue. It isn't published yet. It may take a hour to start appear on search. I leave open this issue until it is successfully published.
Here is the link for it.
https://www.nuget.org/packages/Irensaltali.Currency/0.1.0-beta

It is published.
PM> Install-Package Irensaltali.Currency -Version 0.1.0-beta


why I could not update cFS

Dear,
I clone the repository using git clone, cd to the directory then git submodule init, but when update it, it could not get the cfe, is there any wrong? Thanks
I can update the cFE repository.
Sincerely

Worked for me.  Please provide the exact steps to replicate your issue.
Working sequence:
> git clone git@github.com:nasa/cFS.git
Cloning into 'cFS'...
remote: Enumerating objects: 6, done.
remote: Counting objects: 100% (6/6), done.
remote: Compressing objects: 100% (5/5), done.
remote: Total 605 (delta 1), reused 4 (delta 1), pack-reused 599
Receiving objects: 100% (605/605), 3.80 MiB | 13.76 MiB/s, done.
Resolving deltas: 100% (275/275), done.
> cd cFS
> git submodule update --init
Submodule 'apps/ci_lab' (https://github.com/nasa/ci_lab.git) registered for path 'apps/ci_lab'
Submodule 'apps/sample_app' (https://github.com/nasa/sample_app.git) registered for path 'apps/sample_app'
Submodule 'apps/sample_lib' (https://github.com/nasa/sample_lib.git) registered for path 'apps/sample_lib'
Submodule 'apps/sch_lab' (https://github.com/nasa/sch_lab.git) registered for path 'apps/sch_lab'
Submodule 'apps/to_lab' (https://github.com/nasa/to_lab.git) registered for path 'apps/to_lab'
Submodule 'cfe' (https://github.com/nasa/cFE.git) registered for path 'cfe'
Submodule 'osal' (https://github.com/nasa/osal.git) registered for path 'osal'
Submodule 'psp' (https://github.com/nasa/PSP.git) registered for path 'psp'
Submodule 'tools/cFS-GroundSystem' (https://github.com/nasa/cFS-GroundSystem.git) registered for path 'tools/cFS-GroundSystem'
Submodule 'tools/elf2cfetbl' (https://github.com/nasa/elf2cfetbl.git) registered for path 'tools/elf2cfetbl'
Submodule 'tools/tblCRCTool' (https://github.com/nasa/tblCRCTool.git) registered for path 'tools/tblCRCTool'
Cloning into '/export/home/jhageman/cFS/cFS/apps/ci_lab'...
Cloning into '/export/home/jhageman/cFS/cFS/apps/sample_app'...
Cloning into '/export/home/jhageman/cFS/cFS/apps/sample_lib'...
Cloning into '/export/home/jhageman/cFS/cFS/apps/sch_lab'...
Cloning into '/export/home/jhageman/cFS/cFS/apps/to_lab'...
Cloning into '/export/home/jhageman/cFS/cFS/cfe'...
Cloning into '/export/home/jhageman/cFS/cFS/osal'...
Cloning into '/export/home/jhageman/cFS/cFS/psp'...
Cloning into '/export/home/jhageman/cFS/cFS/tools/cFS-GroundSystem'...
Cloning into '/export/home/jhageman/cFS/cFS/tools/elf2cfetbl'...
Cloning into '/export/home/jhageman/cFS/cFS/tools/tblCRCTool'...
Submodule path 'apps/ci_lab': checked out 'adc0edb707bdd8595654676deddf4dda4f39c669'
Submodule path 'apps/sample_app': checked out 'b798efc39900574fa2b08c2588fa2c6e2254ec99'
Submodule path 'apps/sample_lib': checked out '8f81bfdfda3ace8fc9f9f18d4e8bd7ec3b7ef4b9'
Submodule path 'apps/sch_lab': checked out 'f7b0595e9184cf5b846dc405a18deaac471f8ec8'
Submodule path 'apps/to_lab': checked out '47793f0c9d74bde8b3779717b779ff3c955d7eea'
Submodule path 'cfe': checked out '56397a3a2c47c674892c14610e78263030441d73'
Submodule path 'osal': checked out 'd698a4d7ddc66826a4c7c287468b5f1aa6ca372f'
Submodule path 'psp': checked out '317892063e94a063337a6713eb7a24ab69d2ed69'
Submodule path 'tools/cFS-GroundSystem': checked out '10efa7050f82a4acc3013e9fddf31fd0ea5efe28'
Submodule path 'tools/elf2cfetbl': checked out 'eb5e326a3c85af2dd34735913881f8e15db808db'
Submodule path 'tools/tblCRCTool': checked out 'f21a641c784b49a811e548b71322b953332e53a3'

It worked, maybe the unstable wireless network caused this, thanks


Reuse ReadMessage from reader

no need to reinvent the wheel here.

Codecov Report

Merging #143 into mirror will increase coverage by <.01%.
The diff coverage is 0%.

@@           Coverage Diff            @@
##           mirror   #143      +/-   ##
========================================
+ Coverage     6.5%   6.5%   +<.01%
========================================
  Files          29     29
  Lines        6239   6237       -2
  Branches      868    868
========================================
  Hits          406    406
+ Misses       5820   5818       -2
  Partials       13     13

Impacted Files
Coverage Δ

Mirror/Runtime/UNetwork.cs
0% <0%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 413d7cf...77dfec4. Read the comment docs.

:tada: This PR is included in version 1.0.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


[Feature] [ci] Add rerun bot

Search before asking

[X] I had searched in the feature and found no similar feature requirement.

Description
Add a rerun bot which can help developers rerun the actions by themself.
Usage Scenario
No response
Related issues
No response
Are you willing to submit a PR?

[ ] Yes I am willing to submit a PR!

Code of Conduct

[X] I agree to follow this project's Code of Conduct

It would be nice to be able to describe in detail how to do this.

hi @CalvinKirs, I am also learning 😃


Add more cross project resolvers for production

The resolver that is created on project instantiation should contain more projects/buckets to enable access to public data.
Particular use case: fetching Emodels and Morphologies from bbp/mmb-point-neuron-framework-model for created by the user ME-models stored in vlab/project bucket.

LGTM

Thank you, Bilal.
For some reason tests are failing, I'll see tomorrow what's going on.


[BUG] v0.12.0 impacted by CVE-2023-49569

Is there an existing issue for this?

[X] I have searched the existing issues

Kubernetes Version
Any supported
Shipwright Version
v0.12.0
Current Behavior
builds v0.12.0 contains a Critical security adivsory in the go-git library, which was patched last December and is scheduled to be released with v0.13.0.
Expected Behavior
We should patch v0.12.0 with this security fix, and release a v0.12.1.
Steps To Reproduce
No response
Anything else?
Advisory: https://github.com/go-git/go-git/security/advisories/GHSA-449p-3h89-pw88
PR with fix: https://github.com/shipwright-io/build/pull/1445#issuecomment-1952471856

Hey @adambkaplan @qu1queee , This issue is open for a quite long time, if possible can you please elaborate more about the issue, and how can i fix this?
I would love to look into it

This item was actually fixed by #1543 today. Thanks for looking into this, though!


Add a "Hello JerryScript!" program to the tests

The current code base does not contain any "first JavaScript
program" for those who build JerryScript for Linux console. It
does contain a LED-blinking example -- blinky.js -- but that's
only useful on an developer board where LEDs-to-be-blinked are
available. And the rest of the tests are just that: tests, giving
passed/failed information but nothing eye candy.
This patch adds a simple JS script that can act as a warm welcome
to anyone after the first successful build trying to run something
proving that Jerry works.
JerryScript-DCO-1.0-Signed-off-by: Akos Kiss<EMAIL_ADDRESS>

Good to me

lgtm


Null policy

Is there a way to get null/noop version of FailsafeExecutor and perhaps even of the individual policies? I would like to add a requirement to pass FailsafeExecutor to some APIs, but I have to make sure this feature can be easily disabled by submitting some kind of null/noop FailsafeExecutor that just executes everything as if the code was executed directly.
I see that Failsafe.with() will throw IllegalArgumentException if I give it an empty list of policies. I could probably find a workaround, for example by calling .handleIf(e -> false) on RetryPolicy. But is there a clean, concise solution with minimal overhead?

Same issue. I would like to feature-toggle a circuit breaker for roll out, but I can't have an empty list of policies. Can't really have if (circuitBreakerEnabled) { Failsafe.with(circuitBreaker).get(this::apiMethod); } else { this.apiMethod(); } for all api methods.

Why don't you wrap Failsafe in a minimal interface of your own?  And then you have a single place to do stuff like this. No need to wait for a library to provide you this.

That's a good overall idea, but an investment cost I can't pay now to sell to team/pm the need of using failsafe (or any other stability framework). That's why I was going for a feature toggle solution, so they have confidence in merging.

That's a good overall idea, but an investment cost I can't pay now to sell to team/pm the need of using failsafe (or any other stability framework).

Honestly, I'd say it's the other way around. Binding to a 3rd-party library that you might not want to bind to or not having resilience built in both sound like something that one can't afford not to have.

The problem of using a library is out of question and I'd prefer not to sidetrack the discussion to this topic.
To keep it straight:

I need to convince and educate the team;
to give them safety, they requested feature toggling;
Failsafe doesn't allow for empty list of policies;

The idea is to prove the concept with one simple resource, then generalize. If I start with a big change, it'll be harder to justify.

The issue description mentions

some kind of null/noop FailsafeExecutor that just executes everything as if the code was executed directly.

This raises some questions: Would this no-op FailsafeExecutor call onComplete and onSuccess listeners? (Presumably it would never call onFailure.) Would it support asynchronous execution and configuration? Would it support ContextualSupplier/ExecutionContext? AsyncSupplier/AsyncExecution? If so, then it's hard to see how you'd beat the performance of simply adding a single always-successful policy instead of an empty list of policies.
If not, then you're asking for an implementation of FailsafeExecutor that doesn't meet its contract. One could create such an implementation and provide a wrapper that handles empty policy lists (responding more to @robertvazan here):
public final class FailsafeAllowingEmptyPolicyList {
    public static <R, P extends Policy<R>> FailsafeExecutor<R> with(List<? extends Policy<R>> policies) {
        if (policies.isEmpty())
            return new NoPoliciesFailsafeExecutor<R>();
            // Using this instead preserves FailsafeExecutor semantics on the returned value:
            // return Failsafe.with(alwaysSuccessfulPolicy());
        else
            return Failsafe.with(policies);
    }
    // ... similarly for with(P... policies)

    static class NoPoliciesFailsafeExecutor<R> extends FailsafeExecutor<R> {
        // ... pass dummy policy to super constructor
        // ... reimplement most (all?) methods, mostly trivially
    }

    Policy<R> alwaysSuccessfulPolicy() ... // e.g., handleIf(e -> false)
}

But it would be hard to convince me (and here I'm addressing both @robertvazan and @hkupty) to use a new facility that could at any point return an object that doesn't meet the contract of its interface. (There are valid cases where one might break the contract of an interface deliberately, of course, but I don't think this is good example.)
Using the commented-out return statement above instead of the incomplete FailsafeExecutor implementation would give users the option of supplying empty policy lists and still using the full FailsafeExecutor API safely and reasonably efficiently. I'm not saying I think offering this option is a good idea, just that it can be done without modifying the Failsafe code base.
Or (responding more to @hkupty here) you could use a configuration method taking a boolean argument that uses either the passed in policies or the single always-successful policy, depending on the value of that boolean. See below for how that might look.
If the only thing your users will ever do is synchronous get/run, and they don't need the full FailsafeExecutor interface, consider a simple wrapper that returns a minimal interface, as @whiskeysierra suggested, that only exposes those methods, without exposing FailsafeExecutor. For example (leaving out a few details):
interface MinimalFailsafeExecutor<R> {
    <T extends R> T get(CheckedSupplier<T> supplier) throws FailsafeException;
    void run(CheckedRunnable runnable) throws FailsafeException;
}
...
public final class MinimalFailsafe {

    static class Builder {
        private final boolean enabled;
        Builder(boolean enabled) { this.enabled = enabled }

        public <R, P extends Policy<R>> MinimalFailsafeExecutor<R> with(List<? extends Policy<R>> policies) {
            if (enabled) {
                FailsafeExecutor<R> fsExec = Failsafe.with(policies);
                return new MinimalFailsafeExecutor<R>() {
                    ... get(CheckedSupplier supplier) { ... fsExec.get(supplier) ... }
                    ... run(CheckedRunnable runnable) { ... fsExec.run(runnable) ... }
                };
            } else {
                return new MinimalFailsafeExecutor<R>() {
                    ... get(CheckedSupplier supplier) { ... supplier.get() ... }
                    ... run(CheckedRunnable runnable) { ... runnable.run() ... }
                };
            }
        }
    }

    public static Builder enabled(boolean enabled) { return new Builder(enabled); }

    public static <R, P extends Policy<R>> MinimalFailsafeExecutor<R> with(List<? extends Policy<R>> policies) {
        return Builder.enabled(true).with(policies);
    }
}

Then your users can write the following, and disable the Failsafe machinery with a boolean:
MinimalFailsafeExecutor<String> mfsExec = MinimalFailsafe.enabled(circuitBreakerEnabled).with(circuitBreaker);
...
String result = mfsExec.get(this::apiMethod);

That last call is nearly equivalent to this.apiMethod(), apart from the exception handling, since checked exceptions would need to be wrapped.
Later, once users are comfortable, if you decide that you need the full FailsafeExecutor interface, you can either add to this minimal interface or change MinimalInterface.with to return FailsafeExecutor instead of MinimalFailsafeExecutor, necessitating recompilation but no code change apart from imports.

(...) to use a new facility that could at any point return an object that doesn't meet the contract of its interface.

I agree with you. To be honest, I was surprised to find out that an empty list of policies was not accepted (which would essentially mean no-op), but I understand there might be implementation implications. That'd be preferred over a policy that does nothing IMO.
I didn't mean to make this more than it really was: if I can configure enablement of policies through config, not a single enabled shouldn't break the application. I'm ok with the library not wanting to provide a semantically incorrect policy. This is a bit different and sounds worthy debating it...

@Tembrel Just to clarify my original post, nobody is asking for breaking the API contract. Doing so would actually reduce usefulness of the no-op implementation. The tiny performance overhead of forwarding calls through FailsafeExecutor is rarely a concern.
All we are asking for is simplicity. The alternative you proposed is not simple, at least not as simple as Failsafe.none() would be. After all, simplification of error handling code is something Failsafe is valued for.
I think your objections (i.e. performance and rendering some features useless) apply to any API that offers some sort of null implementation, for example Stream.empty() or OutputStream.nullOutputStream().

I probably confused things unnecessarily by responding to both @robertvazan and @hkupty within one long comment. So here I go with another long comment. :wink:
In responding to @robertvazan's issue description, that first code snippet is complicated because it's trying to demonstrate two things:

that the only reasonable interpretation of a FailsafeExecutor based on an empty policy list is going to be equivalent to one using a single always-successful policy, and
that you can therefore roll your own trivial wrapper to get the appearance of allowing empty policy lists, if you want it that badly, without any need for a change in Failsafe behavior.

@hkupty seemed to be asking for something slightly different, a facility for bypassing Failsafe entirely based on a boolean variable, and complexity of the later code snippets is in sketching a way to achieve this without changing Failsafe.
My point was that in both cases you can get what you want without changing Failsafe, if you really want it. I was also trying to hint that maybe you shouldn't really want it. There's not much point to a null FailsafeExecutor, since it will never behave exactly like calling the target code directly, because of checked exceptions. And I think if you're going to be bypassing Failsafe with a boolean flag it's actually better (for readers of the code) to have an explicit if-else, so that users can see exactly what's going on.
Yes, it's awkward that Failsafe can't enforce the precondition that the policy list be non-empty at compillce time, leading to run-time surprises. (Incidentally, why isn't it FailsafeExecutor<R> with(P firstPolicy, P... otherPolicies)?) But I think it was a mistake to let with take a list or array of policies in the first place, mainly (as I've commented on other issues) because it's too easy for users to get mixed up about which way the composition works.
OT rant (that should probably be its own issue)
Does anyone really need to build lists of policies in advance just to pass them into with(...)? I bet not. I bet most uses involve the varargs version of with using a short chain.
Wouldn't it be nicer to have FailsafeExecutor also be a builder for FailsafeExecutor? One could have wrapping(Policy p) and wrappedBy(Policy p) that would return new FailsafeExecutor instances equivalent to this but with the policy chain of this wrapping or wrapped by the given policy. Similarly for the with methods of FailsafeExecutor, and possibly the onXXX methods that currently return void.
@jhalterman has elsewhere (where?) expressed concern that it's hard to find method names that convey the composition of policies clearly, but I think wrapping and wrappedBy are pretty clear.

If I may add my 2ct to this as well...
I ran into the Exception as well, when I was starting with the library... Simplest approach, no vararg in with()... bam.
The important question is really, how important is the ability to have an empty list / default policy for productive use...
I think it might be useful for testing in contrast to deployment or even, as mentioned above, to have some checkboxes in a configuration to toggle the Policies...
When I ran into that, I just used a quick-n-dirty solution: Retry with only one attempt. This seems to be the closest we get to the "empty" Policies...
I've put together a simple example, that illustrates the problem with the custom wrapper / interface (which in general seems very reasonable - see below).
import java.util.concurrent.ExecutionException;
import java.util.concurrent.ExecutorService;
import java.util.concurrent.Executors;
import java.util.concurrent.Future;
import net.jodah.failsafe.Failsafe;
import net.jodah.failsafe.RetryPolicy;

public class FailsafeNoPolicy {

    public static void main(String[] args) throws ExecutionException, InterruptedException {

        Runnable helloTask = () -> System.out.println("Hello World @ " + Thread.currentThread());
        Runnable booomTask = () -> {throw new RuntimeException("Booom!");};

        Runnable task = helloTask;

        ExecutorService executor = Executors.newSingleThreadExecutor();

        Future<?> future;
        if(true){
            future = executor.submit(task); // just Future
        } else {

            future = Failsafe.with(new RetryPolicy<>().withMaxAttempts(1))
                                                     .with(executor)
                                                     .runAsync(task::run); // cancellable (!) Completable Future
        }
        executor.shutdown();

        future.get(); // nothing fancy with CompletionStage possible...

    }

}

The explicit distinction between Failsafe / no Failsafe is good for readability - but not for the interface. If I would create an interface / facade to wrap this distinction, I could only provide java.util.concurrent.Future instead of CompletableFuture which is way more powerful. I could use CompletableFuture's static runAsync-Methods instead of the Executor, but the returned CompletableFuture does not respond to interrupt (which is a very bad design, in my opinion, even if the reason is clear...). So to still have interruptability (which Failsafe's returned CompletableFuture provides! Yay! :-) ), We have to fall back to Executor.submit or even new Task(new FutureTask()).start, which both provide only Futures without support of CompletionStages.
Therefore, the general idea to wrap a library in a custom interface is very good, but even then I would want the CompletableFuture, which is way more labour-intensive, if it shall be cancellable...
So yes, I think an Executor, that just executes and does nothing else - like my workaround new RetryPolicy<>().withMaxAttempts(1) - would be a good thing, which might even be a reasonable default, if the Policy-List is empty...

Any preference for how to go about this? Some options:

FailsafeExecutor<Object> failsafe = Failsafe.with()
FailsafeExecutor<Object> failsafe = new FailsafeExecutor<>()

I tend to like the straightforward simplicity of option 2.

I think it's better to preserve the option of having FailsafeExecutor be an interface or abstract class, which option 2 precludes. So if I have to choose between the two, I think option 1 is better.

Interesting point @Tembrel. What do you think that might be useful for?
I wonder if there's a better option then Failsafe.with(). It's awkward to call with but not provide it with anything.

It would allow you the option of using alternative implementations based on the provided policies, rather than forcing a single implementation to serve for all.
More generally, if you don't have to have a public constructor, why make one part of the API?
How about

providing Failsafe.none(), or something other method name that conveys the absence of any policies;
deprecating no-arg Failsafe.with() as an alias for Failsafe.none() (or removing entirely); and
adding Failsafe.with(Policy aPolicy, Policy... otherPolicies)?

+1 for the first option. It is consistent with the non-empty with-calls; otherwise one wouldn'd find this option as easy, as you would need to consult another class as usual (FailsafeExecutor instead of Failsafe).
Both options seem reasonable, using an empty with(vararg) or introducing none().
Why not allowing both? So one would be able to use the explicit none or could just stick with the with but wouldn't have to bother with the split into two arguments. For the with-javadoc I'd simply state, that an empty with(vararg) is equal to none().

Providing a public constructor pins down a specific implementation without adding anything that can't be provided by a static factory method. API design best practices argue against adding dependencies unnecessarily. Once you've promised the availability of a public constructor, you can't take it back.
If FailsafeExecutor is to be used for extension by regular users, then a protected constructor would make sense, but I don't think that's in the cards right now.

@Tembrel Seeing your suggestion in another thread that with should require one policy made sense. I recently added a with method that does this: 940f6b74e9400a303e29f4fd0b34f98000ef5a01. Did you have in mind a reason why it's worth keeping but deprecating the no arg with() method? I realize removing it would cause a compile error but actually using it should yield a runtime exception.

No, better to fail at compile time, you're right.
On Fri, Aug 6, 2021, 5:36 PM Jonathan Halterman @.***>
wrote:

@Tembrel https://github.com/Tembrel Seeing your suggestion in another
thread that with should require one policy made sense. I recently added a
with method that does this: 940f6b7
https://github.com/failsafe-lib/failsafe/commit/940f6b74e9400a303e29f4fd0b34f98000ef5a01.
Did you have in mind a reason why it's worth keeping but deprecating the no
arg with() method? I realize removing it would cause a compile error but
actually using it should yield a runtime exception.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/failsafe-lib/failsafe/issues/252#issuecomment-894531255,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AABZ5SWIYF67WBUMD73C2PTT3RIVTANCNFSM4NP4XZGA
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&utm_campaign=notification-email
.


Add support for redis password authentication

This pull request updates redigo to the latest and incorporates optional use of the client key config parameter to use for redis password auth. Thanks goes to israelchen for initially tackling this.
This pull request will bring the code up to date with confd's master.
This should resolve #317.

@ericbarch Awesome!


Made download link more obvious in README.md

I honestly would rather have "download for macOS" button image than this if it's okay with you ?


Bump CronExpressionDescriptor version for improved Norwegian translat…

I submitted a PR to CronExpressionDescriptor, improving the Norwegian translations. Release 2.21.0 contains those (and only those) changes.
Pull request type

Please check the type of change your PR introduces:

[ ] Bugfix
[ ] New feature or enhancement
[ ] UI change (please include screenshot!)
[ ] Code style update (formatting, renaming)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] Documentation content changes
[x] Internationalization and localization
[ ] Other (please describe):

What is the current behavior?
The Norwegian translations were a bit rusty.
What is the new behavior?
Now they're better 😊
Quality check
Before creating this PR:

[x] Did you follow the code style guideline as described in CONTRIBUTING.md
[x] Did you build the app and test your changes?
[x] Did you check for accessibility? On Windows, you can use Accessibility Insights for this.
[x] Did you verify that the change work in Release build configuration
[x] Did you verify that all unit tests pass
[x] If necessary and if possible, did you verify your changes on:

[x] Windows
[ ] macOS (DevToys 2.0)
[ ] Linux (DevToys 2.0)

Thank you for this ! :)


Standardize sample ID field data type in pipeline scripts

Currently, IDs that can be coerced to integer or numeric are being converted automatically between integer and character by some steps in the pipeline. We should standardize how it's handled.

A few more notes:

It occurred to me that the IDs won't always be coercible to integer, so I think they'll have to be character.
from @HanleyKingston: the sample.ids in the PC-AiR file end up as characters, but in the gds and phenotype file they are characters. I had to add: pcs$sample.id <- as.integer(row.names(pcs))

I think this stems from two things that are happening in the pipeline

if the sample ID field can be coerced to integer, it looks like that is the default behavior by seqBED2GDS(). See an example here: /acct/jbroome/tmp/plinkgdstest/test.gds. (this could be the case for creating a GDS in a different way, but I only tested with seqBED2GDS())
pca_plots.R has the line that @HanleyKingston mentioned: pcs$sample.id <- row.names(pcs). This coerces the IDs to character

I'm thinking we could either force sample.id to be character in our GDS files, just deal with this on a case-by-case basis since I think most of the time sample.id will be character anyway


Containers with same hostname/domainname can't resolve eachother

We're currently using Weave with custom domain names, for each new environment we start up, to namespace things properly, and containers with the same hostname, cannot resolve eachother, unless we query for DNS directly.
We use Swarm (not that I think it matters), Weave Proxy, and Compose.
To start containers, we define our Swarm as the docker host, which is sending traffic into the Weave Daemon, rather than the original Docker Daemon.
Our containers can't resolve other containers in general, if we don't either define the FQDN as the hostname, or use a combination of hostname, and domainname in our compose.yml-files.
Example that works for us:
foo:
  image: foo
  hostname: foo
  domainname: bar.weave.local

This container will have a /etc/hosts file with contents similar to:
# created by Weave - BEGIN
# container hostname
<IP_ADDRESS>    foo.bar.weave.local foo

# static names added with --add-host

# default localhost entries
<IP_ADDRESS>       localhost
::1             ip6-localhost ip6-loopback
fe00::0         ip6-localnet
ff00::0         ip6-mcastprefix
ff02::1         ip6-allnodes
ff02::2         ip6-allrouters
# created by Weave - END

The problem here is that it's adding the FQDN, and not just the hostname, so it will never be able to resolve other containers with the same hostname.
I'd like to either choose not to use the FQDN in the hosts-file, or have some way to query for DNS records, with an added prefix, like _foo.bar.weave.local (not a good way to do it at all, but it's just to get the idea out there)

Try getent hosts.foo.weave.local. - notice the trailing dot.
$ weave launch
$ eval $(weave env)
$ docker run --name=foo1 -h foo.weave.local -dti ubuntu
bb81dd3c887d717a0816f416ef42a24ce468e63d429ebd1f41e51729b351ee15
$ docker run --name=foo2 -h foo.weave.local -dti ubuntu
f766711fc7f23167eaf172e131d67643eacd8c30251a2334110a811950a9b87d
$ docker exec foo1 getent hosts foo
<IP_ADDRESS>       foo.weave.local foo
$ docker exec foo1 getent hosts foo.weave.local
<IP_ADDRESS>       foo.weave.local foo
$ docker exec foo1 getent hosts foo.weave.local.
<IP_ADDRESS>       foo.weave.local
<IP_ADDRESS>       foo.weave.local

This does depend on the resolver. Doesn't work in alpine, the benchmark for broken DNS resolvers.

We should probably document this behaviour.

I'll add a topic for this one.

It might be related to this issue, maybe: https://github.com/docker/docker/issues/14282

@multiply it is the same area, but that issue is focused on the hostname being configured incorrectly while this issue is about the FQDN being resolved via /etc/hosts.  The latter is not incorrect, but it does produce inconsistent behaviour.

@Multiply have you given my "add a trailing dot" suggestion a try?

@rade I did, yes. Eventually, we stopped using custom domains, because it wasn't exactly needed in the long run.

To clarify: It still won't see other containers, even with the trailing dot on the end.

To clarify: It still won't see other containers, even with the trailing dot on the end.

Please provide the exact steps to reproduce this.

Doesn't work in alpine

/ # getent hosts foo
<IP_ADDRESS>         foo.weave.local  foo.weave.local foo
/ # getent hosts foo.weave.local.
<IP_ADDRESS>         foo.weave.local.  foo.weave.local.

Notice how the answer changes but only returns one result. Repeated queries return a different result, so I think it's just picking the first answer from the result set. This problem is not specific to looking up the container's own name; the same behaviour arises when looking up other names that have multiple DNS entries.
So this is a general bug in alpine's getent, or, worse, alpine's resolver.

So this is a general bug in alpine's getent, or, worse, alpine's resolver.

I think it's just alpine's getent, which only looks at the first entry returned by gethostbyname().

Sorry for not getting back to you @rade - Must've missed the notification.
Yes, the getent is only returning one record for me as well. I ended up using nslookup with alpine instead.


Bump build to Go 1.12.4

Bump build to Go 1.12.4

Coverage remained the same at 91.94% when pulling 4518d227d7af68f11a03d54db672b6882b5545ab on cs/1.12.4 into b0ab870f46e45fada3a3033709e1760018c4dd01 on master.


Lack of information

The title of this article does not clearly explain which .NET version this is for.
Is it for .NET Framework, .NET Core, or .NET 5 and above?

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 46af0b96-2d12-9cac-2f8f-15eb49d0292d
Version Independent ID: 33db41be-42f9-bb94-65fe-0cf7d1c64f12
Content: Use the IHttpClientFactory - .NET
Content Source: docs/core/extensions/httpclient-factory.md
Product: dotnet-fundamentals
GitHub Login: @IEvangelist
Microsoft Alias: dapine

Hi @DavidKlempfner,
Thanks for posting this issue. The IHttpClientFactory type was introduced in .NET Core 2.1, and the two introduction paragraphs mention that, but you're correct that it's not necessarily obvious from the title.
With that info, what would you recommend for the title if we were to change it?

Hi @IEvangelist, maybe something like:
IHttpClientFactory with .NET Core 2.1+

After discussing this with the team, we're going to leave this as is. The opening paragraphs communicate the version it was introduced and the title says ".NET" which now is used to convey ".NET Core" and ".NET 5+". Thank you for this feedback though, I'm going to close this one for now. But if we get enough feedback like this, we'll revisit it then. Thank you.


Update Testing section in Makefile

This commit applies some conventions to the targets and documentation in
the testing section:

Use single spaces before help text (results in shorter lines)
Clarify build and push image targets for content
Add documentatin for prep-e2e
Add e2e target to the testing section
Fix the must-gather target by adding push-must-gather-image

Fixes #159

/retest
@Vincent056 fixed up the content images for CI - so we should be good to rerun the e2e tests.

/test e2e-aws-parallel
/test e2e-aws-serial
Failure due to issues with image registries, which is affecting more than just our project.


Support bytes, kilobytes and megabytes conversion

Context
Some metrics, like the Erlang VM's memory usage, are reported in bytes. It might be interesting for some reporters to have the ability to convert this value a bigger unit.
Here's an example of a memory usage graph using bytes vs one using megabytes:

1000 vs 1024
The International System of Units (SI) definition was used here, which means that 1 Kilobyte is defined as 1000 bytes instead of 1024.
This definition was chosen to avoid ambiguity since it seems like 1024 notation should now be called kibibytes, mebibytes, gibibytes and so on. This is also the conversion used by Google:

If you think we're better off using the 1024 definition, please let me know.
References:

https://physics.nist.gov/cuu/Units/binary.html
https://en.wikipedia.org/wiki/Kilobyte
https://cseducators.stackexchange.com/questions/4425/should-i-teach-that-1-kb-1024-bytes-or-1000-bytes

@arkgil can you please give me permission in Circle CI? It seems the build got stuck and it is not actually an application error.

Codecov Report

Merging #43 into master will increase coverage by 0.19%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master      #43      +/-   ##
==========================================
+ Coverage   96.77%   96.96%   +0.19%
==========================================
  Files           2        2
  Lines          93       99       +6
==========================================
+ Hits           90       96       +6
  Misses          3        3

Flag
Coverage Δ

#1_5_otp18
96.9% <100%> (+0.16%)
:arrow_up:

#1_5_otp20
96.9% <100%> (+0.16%)
:arrow_up:

#1_9_otp20
96.96% <100%> (+0.19%)
:arrow_up:

#1_9_otp22
96.96% <100%> (+0.19%)
:arrow_up:

Impacted Files
Coverage Δ

lib/telemetry_metrics.ex
98.43% <100%> (+0.16%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ecc6602...69aaca0. Read the comment docs.

:heart: :green_heart: :blue_heart: :yellow_heart: :purple_heart:

As far as I know, erlang:system_info(wordsize) is a relevant number with relation to items like max_heap_size. It feels somewhat relevant here, has any thought gone into that side of things?


add first pass at adding NVM to modules

Add an NVM module to manage Node versions and autoswitching. I have several projects using NVM and thought others could benefit from this.

It seems like this might be a better fit for an option in the node module. Would you be willing to rewrite this to fit in there?


[Feature request] Tab name should reflect the file name after "Save As..."

Is your feature request related to a problem? Please describe.
When I "Save As..." the json for the tab in focus, the tab name does not change.
Describe the solution you'd like
I would like the tab name to reflect the name of the file I just saved.
Describe alternatives you've considered
None
Additional context
None

Implemented.


birdwatcher: init at 2.2.4, alice-lg: init at 6.0.0, nixos/birdwatcher: init, nixos/alice-lg: init

Description of changes
Adding packages and modules for:

https://github.com/alice-lg/alice-lg
https://github.com/alice-lg/birdwatcher

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[x] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[x] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
23.05 Release Notes (or backporting 22.11 Release notes)

[x] (Package updates) Added a release notes entry if the change is major or breaking
[x] (Module updates) Added a release notes entry if the change is significant
[x] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

@RaitoBezarius thanks for the review, to be honest I fell like this was quite sloppy work of mine, gonna try better next time. Should be fine now. I will look into writing tests for NixOS modules in a bit only wrote some for home-manger until now, please just give me a bit more time :)

Don't forget tests in a follow-up PR :P

Don't forget tests in a follow-up PR :P

you can also leave this one open for some more time and I will try learning how to write tests this weekend :)

Don't forget tests in a follow-up PR :P

you can also leave this one open for some more time and I will try learning how to write tests this weekend :)

Sure, but if for some reason, we miss the branch-off, it might not be part of 23.05 FWIW. :)

I think it's ready to get merged now, writing tests was quite a good idea since I discovered a small mistake I made in the alice-lg module which is now fixed :)
I know the tests are quite basic but should be enough to ensure both services start properly.

Once CI passes, let's merge


Add openFyde icon & Update FydeOS icon

Add openFyde icon
Update FydeOS icon

Thanks for this! This look great!
Could you remove the .DS_Store file?

Thanks for this! This look great!
Could you remove the .DS_Store file?

Just removed another .DS_Store file ~

Thanks!


Is it possible to get continuous point cloud generation while running rs-pointcloud app?

Required Info

Camera Model
D435i

Firmware Version
<IP_ADDRESS>

Operating System & Version
Linux 20.04

Kernel Version (Linux Only)
5.8.9-050809-generic

Platform
laptop

SDK Version
2.43.0

Language
C

Segment
others

Issue Description
Hi,
If i am not wrong, the point cloud generated from rs-pointcloud.cpp (by adding " points.export_to_ply("pointcloud.ply", color)") is per frame and generated ply file is just for last updated frame. Thus previous data is lost.
I want to append the pointcloud data till the app runs like wanted to get pointcloud for a big environment where i am holding the camera and moving within the environment.
Note-
I have checked the "start recording " option in realsense-viewer app. I want similar thing but with code and with raw pointcloud data.
Is it possible ? thanks.

Hi @rahulsharma11   It is possible to build up a point cloud over time until you are satisfied with the amount of detail on the scan.  This is demonstrated in Intel's D435i SLAM tutorial for ROS.  At the bottom of the guide, the process for saving the cloud as a 2D map in a pcd file and playing back the pcd is described.
https://github.com/IntelRealSense/realsense-ros/wiki/SLAM-with-D435i
Another approach is to record multiple individual ply point cloud files and then "stitch" then together into a single large ply file.  This method is useful for creating a 'mega-cloud' with a single camera if you do not have multiple cameras.
The point clouds can be aligned with an affine transform operation.
https://github.com/IntelRealSense/librealsense/issues/7853#issuecomment-733733434

Hi @MartyG-RealSense ,
Thanks for the points.
I used ros based example and found no display on Rviz. Terminal output is -
[ERROR] (2021-04-03 16:24:51.940) Rtabmap.cpp:1147::process() RGB-D SLAM mode is enabled, memory is incremental but no odometry is provided. Image 1097 is ignored!
[ INFO] [1617447291.940370128]: rtabmap (1): Rate=1.00s, Limit=0.000s, RTAB-Map=0.0002s, Maps update=0.0000s pub=0.0000s (local map=1, WM=1)
[ WARN] (2021-04-03 16:24:52.001) OdometryF2M.cpp:557::computeTransform() Registration failed: "Not enough inliers 0/20 (matches=0) between -1 and 1049"
[ INFO] [1617447292.001975490]: Odom: quality=0, std dev=0.000000m|0.000000rad, update time=0.047713s
[ WARN] (2021-04-03 16:24:52.070) OdometryF2M.cpp:557::computeTransform() Registration failed: "Not enough inliers 0/20 (matches=0) between -1 and 1050"
[ INFO] [1617447292.070473352]: Odom: quality=0, std dev=0.000000m|0.000000rad, update time=0.048623s
Any settings i am missing?

Advice about the inlier warning is provided by Doronhi the RealSense ROS wrapper developer in the link below.
https://github.com/IntelRealSense/realsense-ros/issues/1080
Doronhi advises adjusting the position of the camera to see whether the inlier warning goes away.

Another approach is to record multiple individual ply point cloud files and then "stitch" then together into a single large ply file. This method is useful for creating a 'mega-cloud' with a single camera if you do not have multiple cameras.
Any c++ example to do stiching of multiple ply files? or it is done through affine-transform only? But this is used by python only right? So any sample code for the same?

one more thing,
I also checked this link "https://github.com/IntelRealSense/realsense-ros" to get ros based output.
Ran with- "roslaunch realsense2_camera rs_camera.launch filters:=pointcloud"
Terminal output is -
process[camera/realsense2_camera_manager-1]: started with pid [90753]
process[camera/realsense2_camera-2]: started with pid [90754]
[ INFO] [1617610928.922958382]: Initializing nodelet with 8 worker threads.
[ INFO] [1617610929.250957027]: RealSense ROS v2.2.23
[ INFO] [1617610929.251017262]: Built with LibRealSense v2.42.0
[ INFO] [1617610929.251042466]: Running with LibRealSense v2.43.0
[ WARN] [1617610929.251076296]: ***************************************************
[ WARN] [1617610929.251096351]: ** running with a different librealsense version **
[ WARN] [1617610929.251127846]: ** than the one the wrapper was compiled with!   **
[ WARN] [1617610929.251144726]: ***************************************************
[ INFO] [1617610929.283295530]:
[ INFO] [1617610929.300793379]: Device with serial number<PHONE_NUMBER>41 was found.
[ INFO] [1617610929.300839289]: Device with physical ID /sys/devices/pci0000:00/0000:00:08.1/0000:04:00.3/usb2/2-2/2-2:1.0/video4linux/video2 was found.
[ INFO] [1617610929.300847203]: Device with name Intel RealSense D435I was found.
[ INFO] [1617610929.301146778]: Device with port number 2-2 was found.
[ INFO] [1617610929.301186999]: Device USB type: 3.2
[ INFO] [1617610929.308207239]: getParameters...
[ INFO] [1617610929.345561992]: setupDevice...
[ INFO] [1617610929.345608173]: JSON file is not provided
[ INFO] [1617610929.345625744]: ROS Node Namespace: camera
[ INFO] [1617610929.345655906]: Device Name: Intel RealSense D435I
[ INFO] [1617610929.345672425]: Device Serial No:<PHONE_NUMBER>41
[ INFO] [1617610929.345692290]: Device physical port: /sys/devices/pci0000:00/0000:00:08.1/0000:04:00.3/usb2/2-2/2-2:1.0/video4linux/video2
[ INFO] [1617610929.345711414]: Device FW version: <IP_ADDRESS>
[ INFO] [1617610929.345729806]: Device Product ID: 0x0B3A
[ INFO] [1617610929.345745483]: Enable PointCloud: On
[ INFO] [1617610929.345765659]: Align Depth: Off
[ INFO] [1617610929.345782298]: Sync Mode: On
[ INFO] [1617610929.345944682]: Device Sensors:
[ INFO] [1617610929.361919474]: Stereo Module was found.
05/04 13:52:09,362 WARNING [140024456673024] (backend-v4l2.cpp:1357) Pixel format 36315752-1a66-a242-9065-d01814a likely requires patch for fourcc code RW16!
[ INFO] [1617610929.388166222]: RGB Camera was found.
[ INFO] [1617610929.390001849]: Motion Module was found.
[ INFO] [1617610929.390055132]: (Confidence, 0) sensor isn't supported by current device! -- Skipping...
[ INFO] [1617610929.390072863]: Add Filter: pointcloud
[ INFO] [1617610929.394091746]: num_filters: 1
[ INFO] [1617610929.394129592]: Setting Dynamic reconfig parameters.
[ WARN] [1617610929.440075468]: Param '/camera/rgb_camera/power_line_frequency' has value 3 that is not in the enum { {50Hz: 1} {60Hz: 2} {Disabled: 0} }. Removing this parameter from dynamic reconfigure options.
[ INFO] [1617610929.455989091]: Done Setting Dynamic reconfig parameters.
[ INFO] [1617610929.457171272]: depth stream is enabled - width: 848, height: 480, fps: 30, Format: Z16
[ INFO] [1617610929.458515267]: color stream is enabled - width: 1280, height: 720, fps: 30, Format: RGB8
[ INFO] [1617610929.458640697]: setupPublishers...
[ INFO] [1617610929.461555865]: Expected frequency for depth = 30.00000
[ INFO] [1617610929.512069064]: Expected frequency for color = 30.00000
[ INFO] [1617610929.546208222]: setupStreams...
[ INFO] [1617610929.547208595]: insert Depth to Stereo Module
[ INFO] [1617610929.547281222]: insert Color to RGB Camera
[ INFO] [1617610929.616292632]: SELECTED BASE:Depth, 0
[ INFO] [1617610929.631485774]: RealSense Node Is Up!
but after opening Rviz, nothing is there. I saw "Global_status:Error".
Any ideas? Thanks.

RealSense ROS v2.2.23
Built with LibRealSense v2.42.0
Running with LibRealSense v2.43.0
The messages above indicate that you may have built the ROS wrapper on librealsense 2.42.0 and then upgraded to 2.43.0.  You have to rebuild the ROS wrapper after a change of librealsense version though, otherwise you receive the above error.
I could not find any librealsense code examples for stitching ply files.  The open-source software CloudCompare has the ability to stitc multiple ply into a single ply though if you are able to use non-SDK software for the operation.
https://cloudcompare.org/forum/viewtopic.php?t=2543
https://www.danielgm.net/cc/
http://www.cloudcompare.org/doc/wiki/index.php?title=Merge

Thanks for support.


WSL install fails with errors on Windows 10 guest VM

***** Your Windows build number:**  10.0.16299.15**
*** What you're doing and what's happening:**
I installed Ubuntu from the Windows Store.

When I click Launch, I get this. It's 0x8007007e. I tried searching that error code, nothing very helpful.

I tried enabling WSL in Windows Features:

Which appears to work and then request restart:

But when I restart, it's disabled again:

Attempting to enable the feature via PowerShell gives me this error message:

I am running Windows 10 Educational edition in VMware Fusion 10.1.1 (7520154) on macOS 10.13.2 (17C205) on a MacBook Pro 2015.
The VMware image is configured to support hypervisors in the Guest.

*** What's wrong / what should be happening instead:**
Users cannot install WSL on VMware Fusion guests.

I'm also having this issue, any luck with a fix? I just can't launch bash.exe it just sits at a black screen, and then eventually I get an error. I look and I can't seem to get the service to run.

Which virtualization program do you use? I can install WSL in VirutalBox VM (haven't tried Store Apps).

@ideal2545 -

Do you have WSL enabled & have you rebooted since enabling? Run the following from an elevated Cmd/PowerShell prompt to double-check you've got WSL enabled:

Get-WindowsOptionalFeature -FeatureName microsoft-windows-subsystem-linux -online

Do you have 3rd party Anti Virus installed?
What do you see when you run wslconfig /l from Cmd/PowerShell?

@Biswa96 I am using VMware fusion pro (8.5 and 10)
@bitcrazed

WSL is enabled based on that.
No Anti Virus
wslconfig /l - results in error: 0x800880005

P.S. I have been able to reproduce this on two machines now - both from clean/scratch without too much configuration.

I have had the same problem on a physical machine having Insider Build 10.0.18356.1
All the symptoms were equal: feature enabled, lxrun not found, wslconfig /l shows no distros. https://aka.ms/wslstore link not working.
To fix this, I've found Ubuntu in Windows Store and installed it. Right after installation, nothing worked as well. Then I've opened Windows Store once again and pressed Launch for Ubuntu there. It has done some initialization and "bash" command started to work after that, however "lxrun" still shows "not found"


Fixing async issue on completion callback for perform batch updates

Currently the completion callback when performing a reload with batch updates is being called prematurely because performing batch updates happens asynchronously on the animation thread. We should use the completion block provided by performBatchUpdates(:) instead

You need to update the tests. They are failing.

Yeah just saw, updated!

@nicksnyder I moved the pendingInsertedIndexPaths.removeAll() in flushPendingInserts call back outside of the completion block. It seems like calling it directly after calling reload and not waiting until completion is the right thing to do, is this correct?

@e-liu yes, that makes sense to me. We handle them synchronously by queueing up the animation. We don't need to wait for the animation to finish before considering them handled.


KeyError on netifaces.AF_INET

When useing netifaces.AF_INET on a gre tunnel i get a key error.
*** KeyError: KeyError(2,)
Example:
gre_iface = netifaces.ifaddresses("dummy_gre")

print(gre_iface) ={17: [{'broadcast': 'ff:ff:ff:ff:ff:ff', 'addr': 'b2:22:6b:2f:63:3e'}], 10: [{'netmask': 'ffff:ffff:ffff:ffff::', 'addr': `'fe80::b022:6bff:fe2f:223e%dummy_gre'}]}

print(gre_iface[netifaces.AF_INET])
*** KeyError: KeyError(2,)

A gre interface.
1: dummy_gre@NONE: <BROADCAST,MULTICAST,UP,LOWER_UP> mtu 1462 qdisc pfifo_fast master br_eth0 state UNKNOWN qlen 1000
    link/ether 12:d3:08:8e:33:d2 brd ff:ff:ff:ff:ff:ff
    inet6 fe80::10d3:8ff:fe8e:33d2/64 scope link
       valid_lft forever preferred_lft forever

To create a gre tunnel/interface
ip link add <name_of_iface> type gretap remote <remote_ip_of_tunnel> ttl 255 local

My machine
CentOS Linux release 7.4.1708 (Core)
Linux l2lgw 3.10.0-862.2.3.el7.x86_64 #1 SMP Wed May 9 18:05:47 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux
Note:
gre tunnels are have a fairly niche application so i doubt this is a priority just wanted to let people know. Nice project very handy keep up the good work.

That's because there's no AF_INET address configured on that interface. Not really a bug — you simply need to be aware that not every interface you will encounter has an IPv4 address (or indeed an IPv6 address).


[lit-html] Add a template compiler transform

A lit-html template compiler could do the one-time template prep work at build-time rather than runtime, giving us a boost on initial rendering performance.
A transform would turn template expressions into CompiledTemplates and CompiledTemplateResults. This is prototyped in https://github.com/lit/lit/pull/1484

Oops, this was covered in https://github.com/lit/lit/issues/189


How to connect to my user table

I build a user, role, permission table and implement some method what I need.
I found this library , I think I can only create user table only, but i want to connect this library and I don't know how to do.
Or...I misunderstand this library use for?

I think issue #12 maybe related to this issue, but anyway, you need to load your roles from somewhere, and about the user roles, the best way to store his roles is it's token, the jwt, it doesn't force you to use jwt, but technically You need a way to get all user roles from user object, so in my opinion the user token is suitable for that.

Starting from v2.0.1, there is a way to load the roles async see #12. and see CHANGELOG.


Add Service Discovery Event

Issue
We need a mechanism to dynamically discover Prometheus metrics endpoints for applications deployed to a k8s cluster.
Rather than co-opt an existing Juju hook to handle such discovery events, it is desirable to have an event dedicated to this purpose.
Solution
Here we use the Ops facility for custom events to add a new event and event source extension, so that charms can use it to handle metrics endpoint changes.
Context
From the charm's tools directory, such an event can be dispatched by using the juju-run command like this:
./juju-run -u my-application/0 "JUJU_DISPATCH_PATH=hooks/discovery ./dispatch"

Testing Instructions
See the usage instructions added with the new lib. Follow them to:

Recruit MetricsEndpointChangeCharmEvents for an existing charm's on member.
Add a handler for the event.
Deploy a unit of the charm.
SSH to the unit.
For the unit's tools directory, dispatch the event as described in Context above.
Verify that the handler was invoked.

Release Notes
Adds a new custom hook event that can be recruited to handle upcoming metrics endpoint changes within a K8s cluster.

Testing instructions seems to contain some copy/paste artifacts. :sweat_smile: To get it to work I had to replace hooks/discovery with hooks/metrics_endpoint_change.
Is there a way we could change this to not have to extend self.on manually, for instance through a MetricsEndpointDiscovery class we could subscribe to in a fashion similar to what is being done here?


Using ruff to enforce that no line can be longer than 140 characters

What is the change?
This PR uses ruff to enforce that no line can be longer than 140 characters.  (Check out the changes to the pyproject.toml file.)
Why is the change being made?
I would like to get ARMI down to 100 characters. But that will change about 1000 files (though mostly in minor ways).  So, that's a big step.
I consider this PR a first step in that direction. I have also looked at making a next PR after this one, that reduces the maximum line length to 120 characters, that only touches ~100 files.  I think that PR will follow this one.
There are no code changes in this PR, just formatting changes.

Checklist

[X] This PR has only one purpose or idea.
[X] Tests have been added/updated to verify that the new/changed code works.

[X] The code style follows good practices.
[X] The commit message(s) follow good practices.

[X] The release notes (location doc/release/0.X.rst) are up-to-date with any important changes.
[X] The documentation is still up-to-date in the doc folder.
[X] If any requirements were affected, mention it in the release notes.
[X] The dependencies are still up-to-date in pyproject.toml.

Ok we got the change in I wanted for the internal release so you can merge this one whenever you want!


FF not removing handler.html from background page

Can reproduce by logging out, then navigating to coil.com and refreshing

"load" event does not seem to be firing

It seems that:

The content script does not run in the iframe
Upon extension reload: FF runs all the content scripts in all open tabs

So ...
Getting the token via injecting the handler.html page into the background page won't work on FF