Dist-Upgrade is not fully noninteractive

In the latest release the upgrade system on first boot option results in non-functional nodes (nodes not coming up), when system files are changed. In the startup script the dist-upgrade is not called with dpkg-noninteractive mode. To fix this the line
https://github.com/kubermatic/machine-controller/blob/2e0d2f0875316755ac1a8dbc3b61d2110abf5968/pkg/userdata/ubuntu/userdata.go#L195
should be changed to
DEBIAN_FRONTEND=noninteractive apt-get -o Dpkg::Options::="--force-confdef" -o Dpkg::Options::="--force-confold" dist-upgrade -y

This might also be necessary for https://github.com/kubermatic/machine-controller/blob/2e0d2f0875316755ac1a8dbc3b61d2110abf5968/pkg/userdata/ubuntu/userdata.go#L217

Correct me if I am wrong, but as I understand the apt docs (I am not a debian/ubuntu expert), this is more about forcing apt to not overwrite files if possible, right?

Yes and no. When a file was changed on the system (e.g. the cloud-init config) and the package gets updated, the dpkg call (which apt uses in the background) will still ask how it should behave (the -y is only relevant for the apt process). As dkpg has no user session, the user query will fail and the script will hang in a infinite loop.
In our example we have nodes, being initialized on Ubuntu 16.04.4, which will upgrade to 16.04.5 and try to replace the cloud-init and motd files, as they are changed in the image we use. (But the update should ignore file-system changes anyway, as they should be user- or pipeline-managed anyways when changed initially)


Friends List Glitch #2

Currently you can add multiple friends with the same name. For example, you can add lets say "Jimmy" as many times as you like (1, 5, 10000000), but once you 'close/re open' the list, it only shows the first original addition. I wouldn't say this is an important thing to be fixed, but nonetheless less glitchy is better :P
Screenshot: http://puu.sh/huQT4/2b542fe21b.jpg

Also fixed in commit f1d3e28


Add a deny.toml file for cargo-deny

This just adds portions for dealing with the licenses of all of our dependencies. cargo-deny also supports a lot more functionality on dealing with security advisories or detecting duplicate dependencies that could be useful as well, but wasn't the focus of this PR

Hmm I'm a bit hesitant about this. I'm a very copy left person. So copy left that I don't even really believe in licenses. If you can physically see and view a piece of code, bar actually breaking into someones machine to steal it, I think you should be able to use it.
Same way that mathematicians that publish their formulas cannot copyright them. I only include the MIT license to satisfy people that do care about licenses. Like you said in the comment, so many licenses are being broken every day with no outcome its comic.
But on a less philosophical note maybe this would be a little useful but I can't really justify using a cargo plugin for something that could just be a PR to remove a line from Cargo.toml. Thanks for this idea though, happy to discuss further :)

I'm fine either way. To me licenses represent how downstream authors want their code to be handled, so it seems respectful at the very least to try and follow that
If we don't merge this then I'll probably just include it locally to keep an eye on things from time to time, so it doesn't really matter to me if it's actually committed or not

Not a big deal here, so I'm gonna go ahead and close this


Need to test bug with  1900 A DEEDS B161-200/1900/1900_01_01_A_NONE_DEED_169_128_2537063_SPLITPAGE_2

https://deed-machine.mappingprejudice.umn.edu/admin/deed/deedpage/31575266/change/?_changelist_filters=matched_terms__term%3Dwhite%2Brace%26o%3D6%26q%3DDEED_169%26workflow__id__exact%3D8

Test both DeedPage preview and previous page image


[HeXXen 1733] Update to Version 1.0.3

Changes / Comments
All Changes are documented in the Changelog here:
https://github.com/m-gora/Roll20-Charactersheet-HeXXen1733/wiki/Changelog
Roll20 Requests
Comments are very helpful for reviewing the code changes. Please answer the relevant questions below in your comment.

[x] Does the pull request title have the sheet name(s)? Include each sheet name.
[x] Is this a bug fix?
[x] Does this add functional enhancements (new features or extending existing features) ?
[x] Does this add or change functional aesthetics (such as layout or color scheme) ?
[ ] If changing or removing attributes, what steps have you taken, if any, to preserve player data ?
[ ] If this is a new sheet, did you follow Building Character Sheets standards ?

If you do not know English. Please leave a comment in your native language.

Character Sheet Info Roll20 Internal Use only.


Documentation page docs.rs/slab is broken

Hi,
When I click on the documentation link of this repository, I am redirected to https://docs.rs/slab.
I get the following error with my browser:
Your connection is not secure

The owner of docs.rs has configured their website improperly. To protect your information from being stolen, Firefox has not connected to this website.

I think that this is related to misconfiguration of certificates.
I am using firefox 60.0.2 (64 bit) on Ubuntu.

This seems to be a docs.rs. bug. I believe they fixed it.
Closing as there is no action on our part.


wcslib: init at 4.25

I've made the improvements. Did not yet add the home page as the official page seems down right now, will wait too see if it comes back.

Would that be http://www.atnf.csiro.au/people/mcalabre/WCS/wcslib/? That works fine here, but mentions 5.12 as current version so I'm not sure.

If it is the same library at an older version, please add a short explanation why in the commit.

@bnikolic: any news?

I've updated to most recent version (now that the official FTP site with the most recent version is reliably available again).

Re- baselined again, implemented the suggested change

Excellent, thanks.


Dark Mode kg-bookmark

kg-bookmark title & content should use the white colour variable in dark mode.
I tried adding them to dark.css which didn't work, I wasn't totally sure on how the dark-mode worked.

Thanks!

Hey @Slethen, thanks for that! Fixed in https://github.com/TryGhost/Alto/commit/32acac045fa00daccd2c3d5b7b0a0c5ab841b8a9. You can also see that working on the page Style Guide of the demo.

Fantastic! Thanks so much @minimaluminium. Updated my blog 😊


v0.8.6 _02: Size scale bar is missing

SUMMARY:
1) Size scale bar is missing
2) OK button is not functional
SEVERITY: Major
MODULE: Stage
Platform: Windows 7 / Chrome 48.0
STEPS TO REPRODUCE:

Navigate to URL: https://stage-tools.gapminderdev.org/tools/
Tools page is loaded.
Note that on the right panel size scale bar is missing
Click “Options”
Note that size scale bar is missing here also
Click OK to close pop up screen of “Options”
Note that OK button is not functional

ACTUAL RESULTS:
Size scale bar is missing on the right panel and in the options and OK button is not functional
EXPECTED RESULTS:
Size scale bar should be available and OK button should be functional
SCREENSHOT:

Ok button is fixed on dev.
Cannot reproduce missing size scale bar

Retest Result: Fail
Platform: Windows 7 / Chrome 48.0
Testing Environment: https://stage-tools.gapminderdev.org/tools/
Screenshot:

Same as #826. pannels need reconsideration

@k6Labz Cannot reproduce the missing scale bar on first load.  Is it missing with every possible window size?

Retest Result: Pass
Platform: Windows 7 / Chrome 48.0
Testing Environment:
1) https://stage-tools.gapminderdev.org/tools/
2) http://static.gapminderdev.org/vizabi/develop/preview/bubblechart.html

Retest Result: Pass
Platform: Windows 7 / Chrome 48.0
Testing Environment:
1) https://stage-tools.gapminderdev.org/tools/
2) http://static.gapminderdev.org/vizabi/develop/preview/bubblechart.html


Invalid escape sequence in tplinkrouterc6u/client.py

This error originated from a custom integration.
Logger: py.warnings
Source: custom_components/tplink_router/coordinator.py:6
integration: TP-Link Router (documentation, issues)
First occurred: 21:48:06 (2 occurrences)
Last logged: 21:48:06
/usr/local/lib/python3.12/site-packages/tplinkrouterc6u/client.py:1128: SyntaxWarning: invalid escape sequence '[' regexp = search('[\d,\d,\d,\d,\d,\d](\d)', line)
/usr/local/lib/python3.12/site-packages/tplinkrouterc6u/client.py:1318: SyntaxWarning: invalid escape sequence '$' result = search('$.ret=(.*);', response_text)
Additional Information (please complete the following information)
Router:

Firmware versie: 1.3.4 Build 20230906 rel.74809(4555)
Hardware versie: Archer AX11000 v1.0

@pHiR0 Fixed. Please try version 1.19.0


Hyphen symbol is incorrect

The hyphen symbol for the PowerShell script in the "Additional steps if you moved key vault to a subscription in a new tenant" section is invalid. This means that copying and pasting the script into a console window does not work.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: fc648f77-1e4c-2722-f3a5-8cbb7565a593
Version Independent ID: cfbf4697-6ddd-fdb9-b97e-875ecc21f9e7
Content: Azure Key Vault moving a vault to a different subscription
Content Source: articles/key-vault/general/move-subscription.md
Service: key-vault
Sub-service: general
GitHub Login: @ShaneBala-keyvault
Microsoft Alias: sudbalas

Thanks for updating.


picard fails with new installs (JRE SIGSEGV)

Running on a new install of atlas and am getting a new error during the remove_pcr_duplicates job. I get the same error when running a config file that previously ran without issue. Any insights? Thanks.
# A fatal error has been detected by the Java Runtime Environment:
#
#  SIGSEGV (0xb) at pc=0x00007f68e765952a, pid=9385, tid=0x00007f68e51cf700
#
# JRE version: OpenJDK Runtime Environment (8.0_121-b15) (build 1.8.0_121-b15)
# Java VM: OpenJDK 64-Bit Server VM (25.121-b15 mixed mode linux-amd64 )
# Problematic frame:
# V  [libjvm.so+0x61652a]  InstanceKlass::oop_follow_contents(ParCompactionManager*, oopDesc*)+0x14a
#
# Failed to write core dump. Core dumps have been disabled. To enable core dumping, try "ulimit -c unlimited" before starting Java again
#
# An error report file with more information is saved as:
# /home/mdjlynch/working/metagenombio/analysis_metagenome/greenhouse/data/processed/atlas/hs_err_pid9385.log
#
# If you would like to submit a bug report, please visit:
#   http://www.azulsystems.com/support/
#
/home/mdjlynch/working/metagenombio/analysis_metagenome/greenhouse/data/processed/atlas/.snakemake/conda/cc9cda9a/bin/picard: line 62:  9385 Aborted                 (core dumped) /home/mdjlynch/working/metagenombio/analysis_metagenome/greenhouse/data/processed/atlas/.snakemake/conda/cc9cda9a/bin/java -Xmx64g -jar /home/mdjlynch/working/metagenombio/analysis_metagenome/greenhouse/data/processed/atlas/.snakemake/conda/cc9cda9a/share/picard-2.11.0-0/picard.jar MarkDuplicates INPUT=tRN5-S41-L001-001/megahit_21_121_20_normalization_k21_t100/alignments/tRN5-S41-L001-001.bam OUTPUT=tRN5-S41-L001-001/megahit_21_121_20_normalization_k21_t100/alignments/tRN5-S41-L001-001_markdup.bam METRICS_FILE=tRN5-S41-L001-001/megahit_21_121_20_normalization_k21_t100/alignments/tRN5-S41-L001-001_markdup_metrics.txt ASSUME_SORT_ORDER=coordinate MAX_FILE_HANDLES_FOR_READ_ENDS_MAP=1000 REMOVE_DUPLICATES=TRUE VALIDATION_STRINGENCY=LENIENT CREATE_INDEX=TRUE
Error in job remove_pcr_duplicates while creating output files tRN5-S41-L001-001/megahit_21_121_20_normalization_k21_t100/alignments/tRN5-S41-L001-001_markdup_metrics.txt, tRN5-S41-L001-001/megahit_21_121_20_normalization_k21_t100/alignments/tRN5-S41-L001-001_markdup.bam.
RuleException:
CalledProcessError in line 618 of /home/mdjlynch/anaconda3/lib/python3.5/site-packages/atlas/rules/assemble.snakefile:
Command ' picard MarkDuplicates -Xmx64g INPUT=tRN5-S41-L001-001/megahit_21_121_20_normalization_k21_t100/alignments/tRN5-S41-L001-001.bam                OUTPUT=tRN5-S41-L001-001/megahit_21_121_20_normalization_k21_t100/alignments/tRN5-S41-L001-001_markdup.bam METRICS_FILE=tRN5-S41-L001-001/megahit_21_121_20_normalization_k21_t100/alignments/tRN5-S41-L001-001_markdup_metrics.txt ASSUME_SORT_ORDER=coordinate                MAX_FILE_HANDLES_FOR_READ_ENDS_MAP=1000 REMOVE_DUPLICATES=TRUE                VALIDATION_STRINGENCY=LENIENT CREATE_INDEX=TRUE' returned non-zero exit status 134
  File "/home/mdjlynch/anaconda3/lib/python3.5/site-packages/atlas/rules/assemble.snakefile", line 618, in __rule_remove_pcr_duplicates
  File "/home/mdjlynch/anaconda3/lib/python3.5/concurrent/futures/thread.py", line 55, in run
Removing output files of failed job remove_pcr_duplicates since they might be corrupted:
tRN5-S41-L001-001/megahit_21_121_20_normalization_k21_t100/alignments/tRN5-S41-L001-001_markdup.bam
Will exit after finishing currently running jobs.

Appears to be an issue with that version and I haven't updated yet. I'm at 2.9:
$ picard MarkDuplicates --version
2.9.0-1-gf5b9f50-SNAPSHOT

This is more of the same related to not pinning versions. The next release will be made soon and in that these issues are addressed.

Okay, thanks. Look forward to the update.

I have the same problem, would downgrading picard to 2.9.0 solve the problem?

Yes, see https://github.com/pnnl/atlas/blob/master/atlas/envs/required_packages.yaml


add direction support to shear

Tasks like OCR need shear in x direction only.
This pull request adds an ability to add shear only in x, or y or both directions while creating pipeline.shear
E.g.
p = Augmentor.DataPipeline(ims, labels)
p.shear(probability=1, max_shear_left=10, max_shear_right=10, direction=['x'])

Hi @sizhky, first of all, sorry for the late reply. Yes, this is a good idea. Let's add it but I would suggest we first make the user-facing option in Pipeline.py a little bit more friendly than directions=['x', 'y']. How about the direction can be either random, left, or right. Also, let's then change the parameter name to direction in this case. The signature would then be:
def __init__(self, probability, max_shear_left, max_shear_right, direction='random')

So it defaults to random, but you can specify left or right. We then need to change the code slightly in Operations.py to use these three possible parameters and adjust x and y accordingly there.


Fix notebook link in Readme

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.


⚠ Bofrost.at has degraded performance

In 700ea63, Bofrost.at (https://www.bofrost.at) experienced degraded performance:

HTTP code: 200
Response time: 1476 ms

Resolved: Bofrost.at performance has improved in 52e5cae after 9 minutes.


Add --relax-float-ops and --convert-relaxed-to-half

The first pass applies the RelaxedPrecision decoration to all executable
instructions with float32 based type results. The second pass converts
all executable instructions with RelaxedPrecision result to the equivalent
float16 type, inserting converts where necessary.

I think I have addressed all concerns to this point.


Handle if condition in slice element

See generated chart at: test/output/0800/mychart

Partially fix https://github.com/yeahdongcn/kustohelmize/issues/37


fix: Adds back custom Result type for generate function

This brings back: https://github.com/pepperoni21/ollama-rs/pull/16 which seems to have gotten squashed / left behind due to: https://github.com/pepperoni21/ollama-rs/commit/37b6e614ba67e9843e49c03064739309b9ad8939
Maybe there are some tests that could be added to assert the right types are being returned so client consumers don't have disruption using this library? I'm using it with anyhow and I had to apply this patch to get generate to be accepted easily as an anyhow::Result

Thanks for the contribution. Yeah I might add some tests before releasing a new version!


Seccomp profile defaulting webhook

How to categorize this PR?

/area security
/kind enhancement
What this PR does / why we need it:
This PR adds a new gardenlet feature gate called DefaultSeccompProfile. If enabled Gardener managed workloads in the seed cluster will have their seccomp profiles defaulted to RuntimeDefault.
The following components in the shoot (k8s version >= 1.19.0) now have its seccomp profile defaulted to "RuntimeDefault":

apiserver-proxy
blackbox-exporter
node-exporter
kube-proxy
node-local-dns
node-problem-detector
vpn-shoot
coredns
metrics-server
kubernetes-dashboard addon

Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Together with @ialidzhikov we discussed that it will be easier to not enable this webhook for the shoots, but explicitly enable a seccomp profile for the components that are deployed there. This is mainly because of the deprecation of PodSecurityPolicy and all complications that may occur in the process.
With k8s version 1.25+ there will be the ability to enable the defaulting of the seccomp profile cluster-wide (ref). This can be implemented so that this feature is enabled/disabled through the shoot specification. I will follow up with an issue on this topic.
Release note:

A new `gardenlet` feature gate called `DefaultSeccompProfile` was introduced. If enabled all Gardener managed workloads in the seed will have their seccomp profiles defaulted to "RuntimeDefault".

Components `apiserver-proxy`, `blackbox-exporter`, `node-exporter`, `kube-proxy`, `node-local-dns`, `node-problem-detector`, `vpn-shoot`, coredns`, `metrics-server` now have their seccomp profiles set to "RuntimeDefault".

Had a joint look with @acumino :
It looks good in general.
There are some more components deployed in the shoot which needs to be adapted:
eg, coredns, metrics-server and the kubernetes-dashboard charts in shoot-addons.
/assign @shafeeqes @acumino

@shafeeqes Thanks for the review! As far as I understand the 1.19-0 is the more permissive check meaning that allows prerelease version (ref). For the sake of consistency we can use what is already used across the codebase.

@ialidzhikov Thanks for the review! I addressed your comments. Please, have another look.

@ialidzhikov I observed some flaky behavior when I ran the test suite. Sometimes the webhook server was not ready to serve requests so I added an additional check to the webhook tests that I found.
Also I am not sure if here the namespace was omitted on purpose. If not I can also add it to this PR.

@ialidzhikov I observed some flaky behavior when I ran the test suite. Sometimes the webhook server was not ready to serve requests so I added an additional check to the webhook tests that I found.

Ok, thanks.

Also I am not sure if here the namespace was omitted on purpose. If not I can also add it to this PR.

I think the idea behind the namespace is to allow parallel executions. My first thought was that parallel execution for the webhook tests is unlikely to be supported due to the webhook port. But checking https://github.com/gardener/gardener/blob/bf9dcf5704d2bb53273f1807c6e2e73dd17a9fd1/vendor/sigs.k8s.io/controller-runtime/pkg/envtest/webhook.go#L115-L129 I see that the handling is supposed to suggest every time a free port. I haven't played with it to check whether parallel execution for these webhook tests works as expected.
If parallel executions works as expected after the change, then we could apply it for the podschedulername webhook envtest as well. 👍

@ialidzhikov You are right. The webhook should not be enabled for the shoot GRM. I missed that when refactoring the code. Thanks for the catch!
I do not have the whole context on testing but I think that restricting the manager's cache to a single namespace for the podschedulername webhook should be OK and will not cause any side effects. It also corresponds to the guidelines here.

With k8s version 1.25+ there will be the ability to enable the defaulting of the seccomp profile cluster-wide (ref). This can be implemented so that this feature is enabled/disabled through the shoot specification. I will follow up with an issue on this topic.

Can you open the follow-up issue to make sure we do not forget it?

Can you open the follow-up issue to make sure we do not forget it?

Yes I will. Thanks for the detailed review


feat: admin badge

Adds admin badge in player list and profile page. Also, uses pipes to create Steam, ETF2L and logs.tf profile links.

Codecov Report

Merging #55 into master will increase coverage by 0.17%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master      #55      +/-   ##
==========================================
+ Coverage    74.4%   74.57%   +0.17%
==========================================
  Files          76       79       +3
  Lines         875      881       +6
  Branches       51       51
==========================================
+ Hits          651      657       +6
  Misses        202      202
  Partials       22       22

Impacted Files
Coverage Δ

src/app/players/steam-profile-link.pipe.ts
100% <100%> (ø)

src/app/players/etf2l-profile-link.pipe.ts
100% <100%> (ø)

src/app/players/logs-tf-profile-link.pipe.ts
100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 501fa4d...7238ea3. Read the comment docs.


npm ERR! cb() never called!

•I installed the create-react-app -g
• I don't know how to set it not -g
• also brew and git are installed in my mac
•
npm ERR! cb() never called!

npm ERR! This is an error with npm itself. Please report this error at:
npm ERR!     <https://npm.community>

npm ERR!      /Users/apple/.npm/_logs/2020-06-19T09_31_51_738Z-debug.log

Aborting installation.
  npm install --save --save-exact --loglevel error react react-dom react-scripts has failed.

Deleting generated file... package.json
Deleting myapp / from /Users/apple
Done.
(base) apples-MacBook-Pro:~ apple$

Did you you look at the quick overview or start guides? Try running npx create-react-app my-app.
Here's the format for a bug report:

name: Bug report
about: Create a report to help us improve
labels: 'issue: bug report, needs triage'
Please note that your issue will be fixed much faster if you spend about
half an hour preparing it, including the exact reproduction steps and a demo.

If you're in a hurry or don't feel confident, it's fine to report bugs with
less details, but this makes it less likely they'll get fixed soon.

In either case, please use this template and fill in as many fields below as you can.

Note that we don't provide help for webpack questions after ejecting.
You can find webpack docs at https://webpack.js.org/.

Describe the bug
(Write your answer here.)
Did you try recovering your dependencies?
Your module tree might be corrupted, and that might be causing the issues.
Let's try to recover it. First, delete these files and folders in your project:
* node_modules
* package-lock.json
* yarn.lock

Then you need to decide which package manager you prefer to use.
We support both npm (https://npmjs.com) and yarn (http://yarnpkg.com/).
However, they can't be used together in one project so you need to pick one.

If you decided to use yarn, update it first (https://yarnpkg.com/en/docs/install).
Then run in your project directory:
yarn

This should fix your project.
Importantly, if you decided to use yarn, you should never run npm install in the project.
For example, yarn users should run yarn add <library> instead of npm install <library>.
Otherwise your project will break again.
Have you done all these steps and still see the issue?
Please paste the output of npm --version and/or yarn --version to confirm.
(Write your answer here.)
Which terms did you search for in User Guide?

They are described in the Troubleshooting section of the User Guide:
https://facebook.github.io/create-react-app/docs/troubleshooting
Please scan these few sections for common problems.
Additionally, you can search the User Guide itself for something you're having issues with:
https://facebook.github.io/create-react-app/
If you didn't find the solution, please share which words you searched for.
This helps us improve documentation for future readers who might encounter the same problem.
(Write your answer here if relevant.)
Environment
To help identify if a problem is specific to a platform, browser, or module version, information about your environment is required.
This enables the maintainers quickly reproduce the issue and give feedback.
Run the following command in your React app's folder in terminal.
Note: The result is copied to your clipboard directly.
npx create-react-app --info
Paste the output of the command in the section below.
(paste the output of the command here.)
Steps to reproduce
How would you describe your issue to someone who doesn’t know you or your project?
Try to write a sequence of steps that anybody can repeat to see the issue.
(Write your steps here:)

Expected behavior
How did you expect the tool to behave?
It’s fine if you’re not sure your understanding is correct.
Just write down what you thought would happen.
(Write what you thought would happen.)
Actual behavior
Did something go wrong?
Is something broken, or not behaving as you expected?
Please attach screenshots if possible! They are extremely helpful for diagnosing issues.
(Write what happened. Please add screenshots!)
Reproducible demo
If you can, please share a project that reproduces the issue.
This is the single most effective way to get an issue fixed soon.
There are two ways to do it:
* Create a new app and try to reproduce the issue in it.
  This is useful if you roughly know where the problem is, or can’t share the real code.

* Or, copy your app and remove things until you’re left with the minimal reproducible demo.
  This is useful for finding the root cause. You may then optionally create a new project.

This is a good guide to creating bug demos: https://stackoverflow.com/help/mcve
Once you’re done, push the project to GitHub and paste the link to it below:
(Paste the link to an example project and exact instructions to reproduce the issue.)
What happens if you skip this step?
We will try to help you, but in many cases it is impossible because crucial
information is missing. In that case we'll tag an issue as having a low priority,
and eventually close it if there is no clear direction.
We still appreciate the report though, as eventually somebody else might
create a reproducible example for it.
Thanks for helping us help you!


🐛 Fix body length limit when uploading themes

My theme deploys began failing last week with the axios error described in this issue: https://github.com/TryGhost/SDK/issues/195
It turns out that axios now requires maxBodyLength to be the property we use in config to remove the upload limit.
I haven't been able to pin down exactly why or when this config changed, though it might be connected to this recent pull request introducing the separate maxBodyLength option https://github.com/axios/axios/pull/2781

Got some code for us? Awesome 🎊!
Please include a description of your change & check your PR against this list, thanks!

[x] There's a clear use-case for this code change
[x] Commit message has a short title & references relevant issues
[x] The build will pass (run yarn test and yarn lint)

More info can be found by clicking the "guidelines for contributing" link above.

Codecov Report

Merging #422 (12a06d5) into main (1f90c51) will decrease coverage by 0.12%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #422      +/-   ##
==========================================
- Coverage   87.60%   87.48%   -0.13%
==========================================
  Files          54       54
  Lines        2485     2485
  Branches      440      426      -14
==========================================
- Hits         2177     2174       -3
- Misses        305      307       +2
- Partials        3        4       +1

Impacted Files
Coverage Δ

...l-utils/lib/utils/markdown-absolute-to-relative.js
88.00% <0.00%> (-8.00%)
:arrow_down:

.../lib/utils/markdown-absolute-to-transform-ready.js
64.00% <0.00%> (-4.00%)
:arrow_down:

...ackages/url-utils/lib/utils/_markdown-transform.js
94.89% <0.00%> (-1.03%)
:arrow_down:

packages/url-utils/lib/utils/_html-transform.js
80.41% <0.00%> (-0.70%)
:arrow_down:

index.js
91.38% <0.00%> (+0.39%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1f90c51...12a06d5. Read the comment docs.

Thanks for taking time to contribute @AWaselnuk!

Hello!
I'm surfacing this issue, which appears to be somewhat related to this thread: https://github.com/TryGhost/action-deploy-theme/issues/68
@AWaselnuk, did you find that the change to Infinity helped your use case? I've found that Infinity isn't respected--you have to pass some value. In my case, changing this option to 500MB did the trick.


[1.18.2] how to obtain salt?

I can not see the recipe for this.

I think the advancements tell you how to


Add maven enforcer to enforce Maven 3.9 is used in builds

Use Maven Enforcer in the parent POM in this project to enforce correct Maven versions are used.
https://maven.apache.org/enforcer/maven-enforcer-plugin/usage.html
See the requireMavenVersion tag.

Closed by be53bad2f661f726d48b08c599965192cce5b29a


57 - Implement support for the editorjs-undo plugin

Developing #57.

Hi @juanhurtado10, this PR closes #57 and #32.
A mutation observer was implemented to keep the assigned attributes to a block when it belongs to a toggle and the editorjs-undo plugin is executed. Also, the stylesheet and other methods were updated to support other types of blocks inside the toggle, i.e., to nest images, lists, paragraphs (default), headers, and others.
The following gif can show you how the nesting of different types of blocks works, which was added to the project documentation.


Error when building with Dockerfile.local

I'm running into an interesting error. When I use the Dockerfile to build threagile, the application is running without any issues. However, if I clone the repo locally, then build it using the Dockerfile.local, I see the error
{"error":"graph rendering call failed with error:fork/exec /app/render-data-flow-diagram.sh: no such file or directory"}
Any ideas why that might be?

That's weird, that's file is not used for a while. Is it still reproducible with you?


[DRAFT] 🧠 Logic: 🧱 json_prolog, add predicate to convert json to prolog terms

📝 Purpose
In the logic module, we will need a set of new predicates to handle json conversion between json string to prolog term and vice versa.
🧪 Expected behavior
json_prolog(?Json, ?Term).

Where

Json is the string representation of the json
Term is an Atom that would be unified by the JSON representation as Prolog terms.

In addition, when passing Json end Term, this predicate return true if both result match.
The canonical representation for Term is:

Json
Prolog
Value

Object

Mapped to a term json(Attributes), where Attributes is a list of all JSON attributes mapped to a pair term -(Attribute, Value), where Attribute is an atom created from the JSON string and Value is the JSON value.

{
  "foo": "bar",
  "foobar": "barfoo"
}

Result:
json[-(foo, 'bar'), -(foobar, 'barfoo')]

Array
List of JSON values

["foo", "bar"]

Result:
['foo', 'bar']

String
Atom

"foo"

Result:
'foo'

Number
Number

1

Result:
1

Constant true and false

Atom @(true) and @(false)

true

Result:
@true

Constant null

Atom @(null)

null

Result:
@null

🎯 Example
Given the following JSON
{
  "s": "string",
  "n": 1,
  "a": ["string1", "string2"],
  "o": {
    "b": true,
    "n": null
  }
}

json([
  -(s, 'string'),
  -(n, 1),
  -(a, ['string1', 'string2']),
  -(o, json([
    -(b, @true),
    -(n, @null),
  ])
])

✅ Acceptance Criteria

[ ] The predicate is implemented according to the described behavior and examples
[ ] The predicate passes all test cases
[ ] Any related documentation is updated

🔗 References and linked predicate

SWI-Prolog : https://www.swi-prolog.org/pldoc/man?section=json
A compatible JSON predicate for Tau Prolog's library's implemented on ichiban/prolog : https://github.com/guregu/predicates/blob/master/taujson/json.go

This is excellent! Thanks @bdeneux 🥇
I think this is functionally speaking complete and pretty suited.
We may just need to mention the edge case of a simple string being a valid JSON.

That's brilliant @bdeneux 🤩!

Specification updated since implementation of the json empty array fix : https://github.com/okp4/okp4d/issues/398.


Running a Camel-main batch application

Hi. I have been trying to run a simple camel-main (new in CR3) application in java and kotlin. No luck.
Any examples or pointers highly appreciated (in java or kotlin, both better hehehe).
Exception in thread "main" java.lang.RuntimeException: java.lang.LinkageError: loader constraint violation: loader io.quarkus.bootstrap.classloading.QuarkusClassLoader @7068f7ca wants to load class io.quarkus.bootstrap.model.AppModel. A different class with the same name was previously loaded by 'app'. (io.quarkus.bootstrap.model.AppModel is in unnamed module of loader 'app') 	at io.quarkus.deployment.dev.DevModeMain.start(DevModeMain.java:130) 	at io.quarkus.deployment.dev.DevModeMain.main(DevModeMain.java:56) Caused by: java.lang.LinkageError: loader constraint violation: loader io.quarkus.bootstrap.classloading.QuarkusClassLoader @7068f7ca wants to load class io.quarkus.bootstrap.model.AppModel. A different class with the same name was previously loaded by 'app'. (io.quarkus.bootstrap.model.AppModel is in unnamed module of loader 'app')

can you share an example ?
we have this small example but may not be what you were looking for

Ciao Luca. It is basically that example (with a few embellishments). Added the camel-main, camel-log, camel-timer to the pom.xml and it compiles ok. The problems are trying to do mvn clean quarkus:dev (I get the messages above) and java -jar ....-runner.jar when I get the messages below:
Exception in thread "main" java.lang.NoClassDefFoundError: org/apache/camel/quarkus/core/CamelConfig$$accessor 	at io.quarkus.runtime.generated.Config.<clinit>(Config.zig:590) 	at io.quarkus.runner.ApplicationImpl.<clinit>(ApplicationImpl.zig:45) 	at java.base/jdk.internal.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method) 	at java.base/jdk.internal.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:62) 	at java.base/jdk.internal.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45) 	at java.base/java.lang.reflect.Constructor.newInstance(Constructor.java:490) 	at java.base/java.lang.Class.newInstance(Class.java:584) 	at io.quarkus.runtime.Quarkus.run(Quarkus.java:60) 	at io.quarkus.runtime.Quarkus.run(Quarkus.java:38) 	at com.example.Main.main(Main.java:11) Caused by: java.lang.ClassNotFoundException: org.apache.camel.quarkus.core.CamelConfig$$accessor 	at java.base/jdk.internal.loader.BuiltinClassLoader.loadClass(BuiltinClassLoader.java:581) 	at java.base/jdk.internal.loader.ClassLoaders$AppClassLoader.loadClass(ClassLoaders.java:178) 	at java.base/java.lang.ClassLoader.loadClass(ClassLoader.java:522) 	... 10 more
The main class is simple:
`
package com.example;
import io.quarkus.runtime.Quarkus;
import io.quarkus.runtime.annotations.QuarkusMain;
import org.apache.camel.quarkus.main.CamelMainApplication;
@QuarkusMain
public class Main {
public static void main(String... args) {
Quarkus.run(CamelMainApplication.class, args);
}
}
`

do you mind sharing the entire project ? just to be sure I'm testing the same thing

Sure!
https://github.com/gus-maurizio/data/tree/master/example-main

camel-quarkus 1.0.0-CR3 is based on quarkus 1.6.0.Final so I think the only think you need to do is changing the quarkus versionsin the pom

That did it. Thanks!

Just one more question.It seems like the bean used in some examples (pasted here below) is compiling fine but cannot be found. Has something changed in CR3 regarding CDI and injections?
`
package com.example;
import javax.enterprise.context.ApplicationScoped;
import javax.inject.Named;
import io.quarkus.runtime.annotations.RegisterForReflection;
@ApplicationScoped
@Named("myNamedBean")
@RegisterForReflection
public class NamedBean {
public String hello(String name) {
return "Hello " + name + " from the NamedBean";
}
}
`

you need camel-quarku-bean extension, forget to tell you that before

Aha!!! wonderful, might be good to add that in the documentation.
your next Chianti is on me!


Needs an Update - Uses old terminology and excludes new capabilities

Issue in ./help/quicksilver/people-teams-and-groups/work-with-groups-and-teams/understanding-differences-and-similarities-between-groups-and-teams.md
we noticed, in conversation today, that you can filter for groups in the Workload Balancer (says planner on this list, we don't use planner anymore) - this says only teams are filterable in the resource planner.

@CianOB , thanks so much for the feedback. I have updated the article with your information and the changes I made will be public sometime later today - October 12, 2022.
I apologize for the delay in responding to your comment - this should not happen in the future. Please let us know how we can continue to update our documentation.
Thanks.
Alina


Problem with "PageType = API" - not working?

I have tried to create an API page like:
page 50102 MyInfo
{
    PageType       = API;
    EntityName     = 'myInfo';
    EntitySetName  = 'myInfos';
    APIVersion     = 'beta';
    SourceTable    = "My Infos";
    ODataKeyFields = "Id";
    layout
    {
        area(content)
        {
            field("Id"; Id) {}
            field("Item No.";"Item No.") {}
            field("Item Id";"Item Id") {}
        }
    }
}

I have also tried to extend an existing API page e.g. Customer Entity
pageextension 50101 "Customer Entity Ext" extends "Customer Entity"
{
    layout
    {
        addlast(content)
        {
            field("myData"; 'sss') { ApplicationArea = All; }
        }
    }
}

My NAV Version is:

I have enabled the API in CustomSettings.config:
  <!-- Specifies whether the API web services are enabled. -->
  <add key="ApiServicesEnabled" value="true" />

The new API-Page was not present, when I have tried to query by Postman with URL:
....azure.com:7048/NAV/api/beta/myInfos/
The existing API-Page (Customer Entity) did not contain the new Field.
{
<EMAIL_ADDRESS>"....azure.com:7048/NAV/api/beta/$metadata#customers",
    "value": [
        {
<EMAIL_ADDRESS>"W/\"JzM2O0VnQUFBQUo3Q0RRQU5nQTRBRGtBTndBNEFEZ0FPUUFBQUFBQTY7MzE3ODU5MDsn\"",
            "id": "14cad1e0-db33-418f-a14a-00a4bf4623aa",
            "number": "46897889",
            "displayName": "Englunds Kontorsmöbler AB",
            "type": "Company",
            "phoneNumber": "",
            "email": "",
            "website": "",
            "taxLiable": false,
            "taxAreaId": "7eba3574-f889-49c0-876b-7c416f552c6f",
            "taxAreaDisplayName": "Debitoren und Kreditoren in EU",
            "taxRegistrationNumber": "777777777701",
            "currencyId": "0685ebce-5c90-4786-82d3-da6f206b7df5",
            "currencyCode": "SEK",
            "paymentTermsId": "487c7f01-7d6f-4764-af77-5d07ed7ee392",
            "shipmentMethodId": "093a2f3a-c4a8-488e-aac4-7f3050cc0ecc",
            "paymentMethodId": "00000000-0000-0000-0000-000000000000",
            "blocked": " ",
            "balance": 1043.55,
            "overdueAmount": 0,
            "totalSalesExcludingTax": 0,
            "lastModifiedDateTime": "2017-11-23T02:12:37.593Z",
            "address": {
                "street": "Kungsgatan 18",
                "city": "Norrköping",
                "state": "",
                "countryLetterCode": "SE",
                "postalCode": "600 03"
            },
            "paymentTerms": {
                "code": "LM",
                "description": "Laufender Monat"
            },
            "shipmentMethod": {
                "code": "EXW",
                "description": "Ab Warenhaus"
            },
            "paymentMethod": null
        }
   ]
}```
Where is my fault?

Hi @megel ! We will look into this and see where the issue lies.

Any update on this? I have created a new API page as an object which works fine - but when I convert to AL and publish as an extension the 'testapiintegration' API page is not seen.
page 50001 "Test API Integration"
{
Caption = 'testapiintegration', Locked=true;
EntityName = 'testapiintegration';
EntitySetName = 'testapiintegration';
PageType = API;
SourceTable = "Test API Integration";
layout
{
area(content)
{
repeater(Group)
{
field("Function App URL";"Function App URL")
{
}
field("Web App URL";"Web App URL")
{
}
field("Azure Function App Key";"Azure Function App Key")
{
}
}
}
}
}

This is work in progress and should be available in Dev Preview in the next few weeks.

Which #Docker tag should I use?

These two blog posts should have all the information you need:
https://blogs.msdn.microsoft.com/freddyk/2018/04/16/which-docker-image-is-the-right-for-you/
https://blogs.msdn.microsoft.com/nav/2018/05/03/al-developer-previews-multiple-releases-and-github/

Any update when we can have custom API support in Business Central?

Custom API's should be working and have done so for a while.
From my previous post, our API(s) has now been updated to look as below, note the new properties. Use an up to date VSIX compiler, preferably 2.0 or higher.
page 50001 "Test API Integration"
{
    Caption = 'testapiintegration';
    PageType = API;
    DelayedInsert = true;
    EntityName = 'testapiintegration';
    EntitySetName = 'testapiintegration';
    APIVersion = 'v1.0';
    APIGroup = 'someapiGroup';
    APIPublisher = 'someApiPubnlisher';

    SourceTable = "Test API Integration";

    layout
    {
        area(content)
        {
            repeater(Control3)
            {
                ShowCaption = false;
                field(functionAppURL; "Function App URL")
                {
                    Caption = 'functionAppURL';
                }
                field(webAppURL; "Web App URL")
                {
                    Caption = 'webAppURL';
                }
                field(functionAppKey; "Function App Key")
                {
                    Caption = 'functionAppKey';
                    ExtendedDatatype = Masked;
                }
            }
        }
    }
    trigger OnOpenPage()
    begin
        RESET();
        if not Get() then begin
            INIT();
            INSERT();
        end;
    end;
}

Yes new version works pretty well. I have used in a new object last week. But I didn't try to extend an existing API object.

@megel On which Business Central version you have API working?
I am using Business Central RC1 On-Premises US Dynamics NAV 13.0 (24285), but can't get custom API in list of API via Postman.
AL Language compiler version 2.0.42188

@jatinmittal1822 I have used for my demo RC2 and VS Code to call the API
Use RESTClient as extension for VS Code:
I create a file api.http and called my API:
### GET all Entities
GET https://MY-BUSINESS-CENTRAL-URL.cloudapp.azure.com:7048/nav/api/API-PUBLISHER/API-GROUP/API-VERSION/companies(6b8c92a5-5d63-49ab-bb1b-5aa7fba47f0b)/ENTITIES-NAME
Content-Type: application/x-www-form-urlencoded
Authorization: Basic BC-USERNAME BC-WEBSERVICE-ACCESS-TOKEN

It was also my fault :) as I started

Closing as this old entry seems to have been resolved


Update promo banners

banner text will say NFL, MMA, CRYPTO. Remove the 'coming soon' from MMA
Images for NFL and Crypto below:

Kindly open this live chat link to talk to the customer service directly on your issue  https://direct.lc.chat/14164218/


ScottPlot 4.1.59

ScottPlot 4.1.59
not yet published on NuGet...

Ticks: Improve datetime tick labels for systems with a 24-hour display format (#2132, #2135) Thanks @MareMare and @bclehmann
Axis: Plot.AddAxis() now uses auto-incremented axis index unless one is explicitly defined (#2133) Thanks @bclehmann and Discord/Nick
Axis: Plot.GetAxesMatching() was created to obtain a given vertical or horizontal axis (#2133) Thanks @bclehmann and Discord/Nick
Axis: Corner label format can be customized for any axis by calling CornerLabelFormat() (#2134) Thanks @ShannonZ
BarSeries: Improved rendering of negative values (#2147, #2152) Thanks @fe-c
Function Plot: Added optional XMin and XMax fields which limit function rendering to a defined horizontal span (#2158, #2156, #2138) Thanks @bclehmann and @phil100vol
FormsPlot: Plot viewer now has RefreshLegendImage() allowing the pop-out legend to be redrawn programmatically (#2157, #2153) Thanks @rosdyana
Function Plot: Improved performance for functions which return null (#2158, #2156, #2138) Thanks @bclehmann
BarSeries: improve support for negative and horizontal bar labels (#2148, #2159, #2152) Thanks @bclehmann
Palette: Added Normal Palette based on Anton Tsitsulin's Normal 6-color palette (#2161, #2010) Thanks @martinkleppe
BarSeries: Added helper function to create a bar series from an array of values (#2161) Thanks @KonH
SignalPlot: Add Smooth option (#2174, #2137) Thanks @rosdyana
Signal Plot: Use correct marker when displaying in legend (#2172, #2173) Thanks @bclehmann
Data Generation: Improved floating point precision of RandomNormalValue randomness (#2189, #2206) Thanks @arthurits and @bclehmann_
Finance Plot: Improved SMA calculations for charts with unordered candlesticks (#2199, #2207) Thanks @zachesposito and @xenedia
Avalonia Control: Fixed subscription to ContexMenu property changes (#2215) Thanks @DmitryZhelnin
Legend: Support horizontal orientation and added cookbook example (#2216) Thanks @lucabat
Data Generation: Added generic support for Consecutive(), Random(), and RandomWalk()
SignalPlot: New SignalPlotGeneric type allows AddSignal() to support generic data types (#2217) Thanks @codecrafty

Hi @swharden, thank you for the release!...did you notice that it seems to be failing in Action? https://github.com/ScottPlot/ScottPlot/actions/runs/3405520885/jobs/5663553101
Thank you in advance.

NuGet API keys expire yearly 😝 I think I fixed it... publishing now!

Thank you for your prompt response. It worked.


dockerize

Great!
Can we parameterize the ruby and pt-osc versions that will be used for the machine? That will allow testing any combination like we do with the Travis matrix.
If not, I'd prefer that we use the latest supported Ruby version as the default test environment.

I'm not aware of any way to parameterize the FROM command.
According to https://docs.docker.com/engine/reference/builder/#/environment-replacement
it supports a handful of commands, but FROM isn't one of them.
Updated the Dockerfile to point to 2.2.


Implement _check # My-first-contri

Delete me and write your Pull Request message here!

Thank you


SUOPA-X Minievent form

To test:

make fresh
go to: https://suomidigi.docker.sh/en/form/add-new-event
open to another window: https://xd.adobe.com/spec/ba71d258-eba5-4a06-57b8-e3b89749d908-cc40/screen/a554ee30-51ef-4b5c-b9f4-4a5e2a77c95d/Suomidigi-minitapahtuma-luonti/
compare these two pages and make sure that they match visually. The page https://suomidigi.docker.sh/en/form/add-new-event  should look like the design in https://xd.adobe.com/spec/ba71d258-eba5-4a06-57b8-e3b89749d908-cc40/screen/a554ee30-51ef-4b5c-b9f4-4a5e2a77c95d/Suomidigi-minitapahtuma-luonti/
check also that the start date and time and end date and time fields work properly (you can choose the date and time and they show in the input fields fully)

@khalima

This PR needs few updates on translations and on Webform handler. Will close this one and open a new one https://github.com/vrk-kpa/suomidigi/pull/120.


Add ValuesIndicesTuple

Codecov Report
Patch coverage: 100.00% and no project coverage change.

Comparison is base (6d75df7) 100.00% compared to head (e7cbfe5) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #386   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files           18        19    +1
  Lines         1765      1781   +16
  Branches       183       184    +1
=========================================
+ Hits          1765      1781   +16

Files Changed
Coverage Δ

src/redcat/return_types.py
100.00% <100.00%> (ø)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Memory leak while doing pipeline start - stop

Required Info

Camera Model
{ D400 }

Firmware Version
-

Operating System & Version
Win (10)

Kernel Version (Linux Only)
-

Platform
PC

SDK Version
2.50.0 }

Language
{C }

Segment
{others }

Issue Description
Hi,
I noticed significant increase of memory usage over time while performing start/stop IMU stream via RaelSense Viewer. Same is with start/stop of depth or rgb streams.
I tried to debug the code and came to the conclusion that if I comment out "glCopyTexImage2D" function call (file rendering.h, inside function draw_motion_data) memory increase  stops. Is this issue known?

Hi @niho518  The top line of the What's New section of the release notes for RealSense SDK version 2.50.0 describe how repeated stop-start (like in a stress test) can cause intermittent failures if firmware version <IP_ADDRESS> is currently installed in the camera.
https://github.com/IntelRealSense/librealsense/wiki/Release-Notes#whats-new
A fix for memory leaks during stop-start of the IMU was also implemented in version 2.48.0 so it may be worth testing 2.48.0 to see whether your issue might be a regression in 2.50.0 from the previous fix.
https://github.com/IntelRealSense/librealsense/releases/tag/v2.48.0
You can obtain a standalone version of the 2.48.0 Viewer from the 'Assets' file list at the above link by downloading and running the file Intel.RealSense.Viewer.exe

Hi @MartyG-RealSense,
with 2.48.0 and D415 camera I can reproduce a memory leak while starting and stopping RGB stream (will test IMU on D435i later during the day).

Thanks very much for the information.  I look forward to your later D435i test results.

Tested with D435i (wtih RealSense SDK version 2.48.0) memory leak can be reproduced. Simple continuous start/stop of IMU stream in RealSense viewer.

Thanks for the results.  Which tool are you using to track the memory leak, please?  For example, it was found that detecting leaks with Valgrind may result in false positive results of leaks, as discussed at https://github.com/IntelRealSense/librealsense/issues/9141#issuecomment-853658523

I'm using visual studio 'Diagnostic Tools' and windows task manager (simply observe memory usage increase over time).

As you found that the leaks stopped if you commented out glCopyTexImage2D, does the leak still occur if you update the graphics drivers on your Windows computer and therefore update the OpenGL driver too in doing so?

Hi @niho518  Do you require further assistance with this case, please?  Thanks!

Hi @MartyG-RealSense, my gpu drivers are up to date so the initial problem still exist.

Which firmware version are you using, please?  Firmware <IP_ADDRESS> included a fix for intermittent failures during repeated depth stop-start.
https://github.com/IntelRealSense/librealsense/wiki/Release-Notes#whats-new

Hi @niho518  Do you require further assistance with this case, please?  Thanks!

Case closed due to no further comments received.


Error "Mapping values not allowed in this context"while parsing phishlet

PLEASE READ THE POSTING GUIDELINES AND ANSWER THE QUESTION BEFORE POSTING, OTHERWISE ISSUE WILL BE CLOSED AND MARKED AS INVALID

I hereby declare the following issue is a [tool specific question/bug report] and it is NOT a help request about creating a phishlet.
I am fully aware that this is not a customer support portal, I can't demand answers and I'm aware I am using a free tool.
I am not going to use Evilginx to hax my girlfriend's account or use it for any other illegal purpose.
I am not trying to set up a domain on FreeNOM (also read the sentence above again).
I am not a robot.

Please type in "I CONFIRM" below if you confirm the sentences above or otherwise make some funny remark:
I CONFIRM
Thanks!
Hi, I attempted to use a custom made phishlet, and when I try to load it into Evilginx, the software returns a red error saying
"Failed to load phishlet '': While parsing config : yaml : line 609 : Mapping values are not allowed in this context"
Pretty sure the file follows the requirements to be successfully loaded. Any idea what could cause the error ? I can send the phishlet if needed

I CONFIRM
[image: Mailtrack]
https://mailtrack.io?utm_source=gmail&utm_medium=signature&utm_campaign=signaturevirality5&
Sender
notified by
Mailtrack
https://mailtrack.io?utm_source=gmail&utm_medium=signature&utm_campaign=signaturevirality5&
07/27/19,
03:05:04 AM
On Fri, Jul 26, 2019 at 9:00 PM XLuma<EMAIL_ADDRESS>wrote:

PLEASE READ THE POSTING GUIDELINES AND ANSWER THE QUESTION BEFORE POSTING,
OTHERWISE ISSUE WILL BE CLOSED AND MARKED AS INVALID

I hereby declare the following issue is a [tool specific
question/bug report] and it is NOT a help request about creating a
phishlet.
I am fully aware that this is not a customer support portal, I can't
demand answers and I'm aware I am using a free tool.
I am not going to use Evilginx to hax my girlfriend's account or use
it for any other illegal purpose.
I am not trying to set up a domain on FreeNOM (also read the
sentence above again).
I am not a robot.

Please type in "I CONFIRM" below if you confirm the sentences above or
otherwise make some funny remark:
I CONFIRM
Thanks!
Hi, I attempted to use a custom made phishlet, and when I try to load it
into Evilginx, the software returns a red error saying
"Failed to load phishlet '': While parsing config : yaml : line 609 :
Mapping values are not allowed in this context"
Pretty sure the file follows the requirements to be successfully loaded.
Any idea what could cause the error ? I can send the phishlet if needed
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/kgretzky/evilginx2/issues/340?email_source=notifications&email_token=AJJWNHFCVKSTRULG5BWJWQLQBOM3VA5CNFSM4IHIBG5KYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4HB2JBJQ,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AJJWNHBDERJ5F5KLEHF2GGTQBOM3VANCNFSM4IHIBG5A
.


Build error after package removals

Hello,
It seems the recent commit 932dbc has caused build errors.
../../klauspost/compress/flate/crc32_amd64.go:9:2: cannot find package "github.com/klauspost/cpuid" in any of: 	$HOME/builds/AUR/gogs-git/src/build/go/src/github.com/klauspost/cpuid (from $GOROOT) 	$HOME/builds/AUR/gogs-git/src/build/src/github.com/klauspost/cpuid (from $GOPATH) ../../klauspost/compress/gzip/gunzip.go:13:2: cannot find package "github.com/klauspost/crc32" in any of: 	$HOME/builds/AUR/gogs-git/src/build/go/src/github.com/klauspost/crc32 (from $GOROOT) 	$HOME/builds/AUR/gogs-git/src/build/src/github.com/klauspost/crc32 (from $GOPATH) modules/setting/setting_memcache.go:10:2: cannot find package "github.com/macaron-contrib/cache/memcache" in any of: 	$HOME/builds/AUR/gogs-git/src/build/go/src/github.com/macaron-contrib/cache/memcache (from $GOROOT) 	$HOME/builds/AUR/gogs-git/src/build/src/github.com/macaron-contrib/cache/memcache (from $GOPATH) modules/setting/setting_redis.go:10:2: cannot find package "github.com/macaron-contrib/cache/redis" in any of: 	$HOME/builds/AUR/gogs-git/src/build/go/src/github.com/macaron-contrib/cache/redis (from $GOROOT) 	$HOME/builds/AUR/gogs-git/src/build/src/github.com/macaron-contrib/cache/redis (from $GOPATH) modules/setting/setting_redis.go:11:2: cannot find package "github.com/macaron-contrib/session/redis" in any of: 	$HOME/builds/AUR/gogs-git/src/build/go/src/github.com/macaron-contrib/session/redis (from $GOROOT) 	$HOME/builds/AUR/gogs-git/src/build/src/github.com/macaron-contrib/session/redis (from $GOPATH)
I think this is similar to issue [#1664] (https://github.com/gogits/gogs/issues/1664)

Hi,
How did you build?

Do a go get, then try to build gogs again.

Do go get -u would be better.

go get -u returns
package github.com/gogits/gogs: unable to parse output of git config remote.origin.url

ping @fanningert

I will check it


Feature Request: Make it possible to specify the animation used for a transition

It would be helpful to be able to specify which animation is used for a transition. Here is an example use case of my app. I have a tab view listing the soccer matches of the next soccer world championship. So the list looks like this:

Match 1
Match 2
Match 3
Match 4
...

Each match list entry is linked to a detail page for that match. So the link structure is like this:

Match 1 -> Detail View Match 1
Match 2 -> Detail View Match 2
Match 3 -> Detail View Match 3
Match 4 -> Detail View Match 4
..

All pretty normal. To enable a faster navigation the detail views are working like a carousel (I can not use a carousel there because of performance issues, it would have to load all details of all matches at once). Thus it is possible to navigate from a match detail view directly to the detail view of the next match or to the detail view of the previous match without having to return to the list main view. So the link structure in the detail view for match 2 looks like this
Detail View Match 2 -> Detail View Match 1
Detail View Match 2 -> Detail View Match 3
Detail View Match 2 Back Button -> List View
The use case now is as follows:

The user chooes in the list match 2. -> The app changes to Detail View Match 2.
The user changes directly from Detail View Match 2 to Detail View Match 1.

Now it is necessary to tell Ionic to use a left to right transition because the user is logically going backwards in the list to the previous match. If Ionic uses the standard right to left transition this is irritating for the user in this situation. It is like a carousel using a right to left transition for going backwards.
I have the navigation working as described above apart from the transition direction. For the navigation I am using $location.path(url).replace();

Also interested in the navigation pack. Any updates on this?

+1

+1 as well. I have an
A -> B1 -> B2 -> B3 -- $state.go("A") --> A
The transition back to A is right to left. I know it is impossible to guess the correct animation, which is why it would be fantastic to allow something like:
$ionicHistory.nextViewOptions({
    animationRightToLeft: false
});

I just found the nav-direction directive, but it doesn't appear to be working for me.
<ion-nav-bar>
    <ion-nav-buttons>
      <div class="buttons">
        <button class="button button-icon icon ion-ios-arrow-back" ng-click="goHome()" nav-direction="back"></button>
      </div>
    </ion-nav-buttons>
</ion-nav-bar>

Me neither. Ionic still deserves a clearer way, or a good example on how to set/hack page transitions the proper/official way.

You can do it programmatically with the $ionicViewSwitcher.
$ionicViewSwitcher.nextDirection('back');
$state.go('login');

Thank you @ChristiaanScheermeijer!!! This works perfectly!  Where is it documented?

It's not documented that's why I'm not sure if this is supposed to be used. But at least it works :)

AH! it's been driving me crazy for weeks, and I finally figured out animations in ionic after digging through the code.. here's what I've learned, hopefully it'll help someone else out there:
There's actually quite a few ways to set the animations for ion-view when using ion-nav-view.  According to ionic-angular.js, function getTransitionData():
// Priority
// 1) attribute directive on the button/link to this view
// 2) entering element's attribute
// 3) entering view's $state config property
// 4) view registration data
// 5) global config
// 6) fallback value
for item #1: you can simply set the next-transition attribute on any button or link.  This also means you can set $ionicViewSwitcher.nextTransition('transitionName') in your javascript before performing any type of view change.  Keep in mind that this transition will not be relevant when you go backwards!
#2:You can simply set the view-transition attribute on the highest level element for the incoming view (generally ion-view). Will apply when the view is leaving and coming;
#3: As part of the configuration in your app.js, or as part of your controller setup, you can set the viewTransition property on the $state object.  Will apply when the view is leaving and coming;
#4: not sure what this is about, seems to be an outdated comment
#5:  Sets the transition across the application, set this as part of the config.  I believe for this one you'll need to set the $ionicConfigProvider.views.transition function to handle your transition.
In general, when you're setting the transtions, there are three options, ios (default), android, and none.  If you want to define your own, it's not very hard.
The format is something along the lines of this (copied from the ios transition, replace instances of ios with your transition name):
.config(function ($ionicConfigProvider) {
$ionicConfigProvider.transitions.views.ios= function (enteringEle, leavingEle, direction, shouldAnimate) {
alert('testing my animation");
        function setStyles(ele, opacity, x, boxShadowOpacity) {
            var css = {};
            css[ionic.CSS.TRANSITION_DURATION] = d.shouldAnimate ? '' : 0;
            css.opacity = opacity;
            if (boxShadowOpacity > -1) {
                css.boxShadow = '0 0 10px rgba(0,0,0,' + (d.shouldAnimate ? boxShadowOpacity * 0.45 : 0.3) + ')';
            }
            css[ionic.CSS.TRANSFORM] = 'translate3d(' + x + '%,0,0)';
            ionic.DomUtil.cachedStyles(ele, css);
        }

        var d = {
            run: function (step) {
                if (direction == 'forward') {
                    setStyles(enteringEle, 1, (1 - step) * 99, 1 - step); // starting at 98% prevents a flicker
                    setStyles(leavingEle, (1 - 0.1 * step), step * -33, -1);

                } else if (direction == 'back') {
                    setStyles(enteringEle, (1 - 0.1 * (1 - step)), (1 - step) * -33, -1);
                    setStyles(leavingEle, 1, step * 100, 1 - step);

                } else {
                    // swap, enter, exit
                    setStyles(enteringEle, 1, 0, -1);
                    setStyles(leavingEle, 0, 0, -1);
                }
            },
            shouldAnimate: shouldAnimate && (direction == 'forward' || direction == 'back')
        };

        return d;
    };
});

followed by the css:
// iOS View Transitions
// -------------------------------
$ios-transition-duration:              500ms !default;
$ios-transition-timing-function:       cubic-bezier(.36, .66, .04, 1) !default;
$ios-transition-container-bg-color:    #000 !default;
[nav-view-transition="ios"] {
[nav-view="entering"],
[nav-view="leaving"] {
@include transition-duration( $ios-transition-duration );
@include transition-timing-function( $ios-transition-timing-function );
-webkit-transition-property: opacity, -webkit-transform, box-shadow;
transition-property: opacity, transform, box-shadow;
}
&[nav-view-direction="forward"],
&[nav-view-direction="back"] {
background-color: $ios-transition-container-bg-color;
}
[nav-view="active"],
&[nav-view-direction="forward"] [nav-view="entering"],
&[nav-view-direction="back"] [nav-view="leaving"] {
z-index: $z-index-view-above;
}
&[nav-view-direction="back"] [nav-view="entering"],
&[nav-view-direction="forward"] [nav-view="leaving"] {
z-index: $z-index-view-below;
}
}

Any exciting update on this? I am newbie on ionic, where can I find all the animation definition in ionic, like slide-left-right?

what happened on this issue?

+1

This was added in beta 14.
http://ionicframework.com/docs/api/directive/navTransition/
http://ionicframework.com/docs/api/directive/navDirection/

Yes. Thanks.
I used this, and it works great.
$ionicViewSwitcher.nextDirection('back');
$state.go('login');

@boshmaf Great !!!!


Tests

Will need unit tests for desktop client and service.

Test bases for unit & integration tests are here.


Enhancement: Set Custom Endpoint Vision Models and Select Vision Model

What happened?
I used the librechat.yaml provided by the project to establish an OpenRouter endpoint configuration as follows.

- name: "OpenRouter"
  apiKey: "sk-***********-*******-*************************************************************************************"
  baseURL: "https://openrouter.ai/api/v1"
  models:
    default: ["mistralai/mixtral-8x7b-instruct"]
    fetch: true
  titleConvo: true
  titleModel: "gpt-3.5-turbo"
  summarize: false
  summaryModel: "gpt-3.5-turbo"
  forcePrompt: false
  modelDisplayLabel: "OpenRouter"

When I use claude3, questions with images are forced to be sent to gpt-4-vision-preview, as shown below, the first message "hello" is replied to by claude3, the second message with an image is sent by liberchat to gpt-4-vision-preview, and the second message with an image is sent to gpt-4-vision-preview by liberchat. The second message with the image was sent by liberchat to gpt-4-vision-preview, with my OpenRouter logs below.
Steps to Reproduce
Creating custom endpoints using profiles, with image questioning
What browsers are you seeing the problem on?
No response
Relevant log output
No response
Screenshots

Code of Conduct

[X] I agree to follow this project's Code of Conduct

Not supported yet, but will add it soon

Just realized this is a duplicate issue, closing in favor of the older one https://github.com/danny-avila/LibreChat/issues/2103

Closed in favor of which issue, that's linked here? It's a link to here.
TL;DR:

can we update the list of vision models, and have an easy way to automatically update the list?
In my tests, the cheapest good model for images is google/gemini-flash-1.5 and I would want that as my default
Either disable images on non-supported models, or, have it pass ONLY THE IMAGE to a vision model to "convert it".
Here's a prompt to get a vision model to fully describe a picture, so that it can be passed back to a regular model.

This was discussed on discord today - people testing new vision models in openrouter and but was silently sending not just the image but the entire conversation to openai/4o-mini when using openrouter.
I'd like the idea of automatically converting the image by a chosen provider and the continuing in the chosen model if it dosen't support images, but I would want to know, e.g. a notice: "[This image was automatically converted to text by OpenAI 4o-mini]"
Here's all the models currently supporting vision in openrouter, and a dependency-free script to generate it:
https://gist.github.com/avimar/e8f39f59f345157482f73efaee529086
(resorted alphabetically for clarity:)
[
'anthropic/claude-3-haiku:beta',
'anthropic/claude-3-haiku',
'anthropic/claude-3-opus:beta',
'anthropic/claude-3-opus',
'anthropic/claude-3-sonnet:beta',
'anthropic/claude-3-sonnet',
'anthropic/claude-3.5-sonnet:beta',
'anthropic/claude-3.5-sonnet',
'google/gemini-flash-1.5-exp',
'google/gemini-flash-1.5',
'google/gemini-flash-8b-1.5-exp',
'google/gemini-pro-1.5-exp',
'google/gemini-pro-1.5',
'google/gemini-pro-vision',
'google/gemini-pro',
'meta-llama/llama-3.2-11b-vision-instruct:free',
'meta-llama/llama-3.2-11b-vision-instruct',
'meta-llama/llama-3.2-90b-vision-instruct',
'mistralai/pixtral-12b',
'openai/chatgpt-4o-latest',
'openai/gpt-4-turbo',
'openai/gpt-4-vision-preview'
'openai/gpt-4o-2024-05-13',
'openai/gpt-4o-2024-08-06',
'openai/gpt-4o-mini-2024-07-18',
'openai/gpt-4o-mini',
'openai/gpt-4o:extended',
'openai/gpt-4o',
'qwen/qwen-2-vl-72b-instruct',
'qwen/qwen-2-vl-7b-instruct',
'qwen/qwen-2.5-72b-instruct',
]

I have this prompt saved for "please describe this image" and it seems to be more thorough:
Please describe the image in detail, covering relevant aspects such as:

  For photographs, illustrations, or artwork:
  - The main subject(s) and their appearance, positioning, and actions
  - The setting, background, and any notable objects or elements
  - Colors, lighting, and overall mood or atmosphere
  - Any interesting details, textures, or patterns
  - The style, technique, or medium used (if discernible)

  For screenshots or images containing text:
  - The content and purpose of the text
  - The layout, formatting, and organization of the information
  - Any notable visual elements, such as logos, icons, or graphics
  - The overall context or message conveyed by the screenshot

  For graphs, charts, or data visualizations:
  - The type of graph or chart (e.g., bar graph, line chart, pie chart)
  - The variables being compared or analyzed
  - Any trends, patterns, or outliers in the data
  - The axis labels, scales, and units of measurement
  - The title, legend, and any additional context provided

  Be as specific and descriptive as possible while maintaining clarity and concision.

Simple prompt: "tell me everything about this image"
Got me this with google flash:
This is a two-panel meme.  The top panel shows a father and son sitting on a couch. The son is holding a thick book and asks his father, "Dad, why is this book so thick?"

The bottom panel shows the same father, now closer and smiling, and implying a more complex explanation, saying, "It's a long story."

The humor comes from the implied complexity and possibly embarrassing or lengthy explanation behind the thickness of the book, left to the viewer's imagination.  The meme plays on the common experience of parents having to explain complicated situations to their children.

and the longer prompt got me this (it's all accurate, but all simpler models can't explain the pun):
Here's a description of the image:

The image is a two-panel meme.  The top panel shows a father and son sitting on a light beige couch in a well-lit living room. The father, a dark-skinned man with a short, styled haircut, is wearing a blue shirt and jeans. He's sitting slightly behind his son, a dark-skinned boy with a similar haircut, who is holding an open book.  The boy is asking his father, "Dad, why is this book so thick?" via a speech bubble above his head.  The background is blurry but shows a neutral-toned living room with elements suggestive of comfort. The lighting is soft and natural, contributing to a calm atmosphere.

The bottom panel shows a close-up of the father from the top panel, again dark-skinned with a similar haircut.  His expression is one of a knowing smile. A speech bubble from him states, "It's a long story."  The background is a plain, blurred, light-colored wall.  The mood is somewhat humorous due to the implied joke.

The meme's humor lies in the juxtaposition of the son's simple question and the father's cryptic, suggestive response that hints at a complex, potentially embarrassing or funny, backstory behind the book's thickness. The use of similar shots of the father in both panels connects the meme's two parts. The overall style is a digitally created meme, likely using photographs combined with added text bubbles.  A watermark for @PunHubOnline is visible in the top right corner of the middle panel.

this is the one I meant to point to: https://github.com/danny-avila/LibreChat/issues/1634


Issue that Google Site keeps disconnecting or thinks that there is a new IP address.

This is a duplicate to 392.


Newtype optimisation broken in the REPL

Load this file then try matching on x—You can't. The pattern won't be lowered to a cast and we'll try to index a string.
type foo = Foo of string

let x = Foo "foo"

bbb303cd42 disables newtype opt in the repl but we still need to address it.

Of course a possible solution is just stating that newtype optimisation isn't guaranteed to run.

Yeah, this is something I've been thinking about for a while - if we ever start running the optimiser before linking modules together (which we should), then we need to think about this.
I think the only correct thing to do here is to implement the optimisation as part of lowering. Unlike other optimisations, it actually changes the signature (and sometimes semantics) of the module, so I think this is our only option. We'd then effectively store a "type representation" flag within the LowerState, and use that to guide lowering of other modules.
This is obviously going to make pattern lowering even more ugly, but I think it's the best losution.


Incremental decoding for the UTF family of encodings

This is a change in the incremental decoding approach. Instead of relying on exception to detect an incomplete sequence at the end of the increment, it now inspects the increment data to detect anomalies. The old approach was not working correctly:

True invalid data was being detected as incomplete data and pushed to the next increment; CPython reports invalid data in the same increment in which it occurs (if possible).
Some incomplete but otherwise valid data (completed in the next increment) was being reported as invalid, when the decoder divided unknown bytes into several calls to the fallback. For instance, uneven UTF-16 surrogate pair sequence is being reported as 2 + 1 bytes; unpaired UTF-8 surrogate is being reported as 2 + 1 bytes (and starting from .NET Core 3.0 as 1 + 1 + 1 bytes).
In case of UTF-7, some incomplete data was not being detected at all, with the decoder caching data without invoking any fallback (Issue #649)
It only worked with the 'strict' error handler but all error handlers need to be supported (including user-registered ones).

The problem reported in #649 is resolved now and any workaround introduced in #430 can be removed.
Note that incremental decoding still does not work correctly with stateful error handlers (that is, surrogateescape). This is for another PR.

I am also not quite happy with this -1 business. It was meant to be an optimization: since input is going to be converted to byte[] it will be cheap to get Count. However, although ICollection.Count is expensive, but IList.Count should be OK.
Even then, the constant defined for -1 (AllBytes) is in a wrong place. It is defined in _codecs but the meaning is established in StringOps.DoDecode. I'm going to get rid of -1.


Why is Struct part of the public API?

While the Struct trait seems useful, it is unrelated to amp's stated purpose of being a non-blocking concurrency framework for PHP applications. Why is it part of the public API?

Same as CallableMaker, because it's useful in other packages. And it's not worth having yet another package.

Okay. I don't agree with making the public API larger with distracting, unrelated functionality but I appreciate where you're coming from. Thanks for replying, I'm gonna close this issue now.


Make canEditReportAction return false for deleted actions

Details
Fixed Issues
$ https://github.com/Expensify/App/issues/15477
Tests

Send two messages in a chat
Press ArrowUp, then delete the whole message.
Wait a few seconds (to make sure the deletion is finalized)
Press ArrowUp
Verify that the first message you sent in step 1 is brought up for editing.

[x] Verify that no errors appear in the JS console

Offline tests

Send two messages in a chat.
Press ArrowUp, then delete the whole message.
Press ArrowUp
Verify that the first message you sent in step 1 is brought up for editing.

QA Steps
Same as tests and offline tests.

[ ] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android / native
[x] Android / Chrome
[x] iOS / native
[x] iOS / Safari
[x] MacOS / Chrome / Safari
[x] MacOS / Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is correct English and approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)

[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[x] I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web
https://user-images.githubusercontent.com/47436092/221739064-f60ee7f7-20a6-4617-9560-8c9db388e9aa.mov
https://user-images.githubusercontent.com/47436092/221739077-9bfc7d76-c555-480c-b404-5926970571fe.mov

Mobile Web - Chrome
n/a – no arrow keys

Mobile Web - Safari
n/a – no arrow keys

Desktop
https://user-images.githubusercontent.com/47436092/221739099-ee307eb8-05d5-4a6d-b51c-a45737eabb69.mov
https://user-images.githubusercontent.com/47436092/221739103-560ffaea-922b-4c9c-b115-9b5de12a9f33.mov

iOS
n/a – no arrow keys

Android
n/a – no arrow keys

@rushatgabhane @joelbettner One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

🚀 Deployed to staging by https://github.com/roryabraham in version: 1.2.78-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to production by https://github.com/mountiny in version: 1.2.78-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


Cleaned up Gemfile by relaxing version numbers and removed references to SearchWorks

Also, added badges to README and updated VERSION number
@cbeer @jkeck

do you want me to merge this?


[HOPS-147] Reloading SSL key manager

[HOPS-147]  Implement a basic keystore manager
[HOPS-147]  Reloading thread
[HOPS-147]  Basic reloading testing for the key manager
[HOPS-147]  Test key manager when keystore is missing or corrupted
[HOPS-147]  Add more tests for reloading keystore manager
[HOPS-147]  Refactor key store factory to support reloadable key manager
[HOPS-147]  Add documentation
[HOPS-147]  Remove unused imports
https://hopshadoop.atlassian.net/browse/HOPS-147

Can one of the admins verify this patch?

Jenkins test this please


Fix index for local snapshot data

This PR fixes 2 things:

It's safe to always grab the first instance of data since we always have at least 1 replica.
Set ATL_FORCE_CFG_UPDATE to true to overwrite Jira's dbconfig.xml if local_home_snapshot is defined. This will force image entrypoint to generate the file from scratch.

What was the behaviour without the fixes?


Buttons 'DWQueue' and 'Restoring' present under the table of 'Migration' tab, is not keyboard accessible while navigating with tab key.

“Check out Accessibility Insights! - Identify accessibility bugs before check-in and make bug fixing faster and easier.”
GitHubTags:#A11yMAS;#A11yTCS;#BM_SQL Azure Data Studio_Mac_Sept2023;#SQL Azure Data Studio;#A11ySev2;#WCAG2.1.1;#Keyboard;#DesktopApp;#Win11;#Mac
Environment Details:
Azure Data Studio: Version: 1.48.0-insider (Universal)
Operating System: macOS Sonoma 14.1.1
Steps to Reproduce:

Turn on the Voice over.
Install Azure data studio and open.
Tab till Extension press enter key and install Azure SQL Migration
Tab till Respective server and right click.
Tab till 'manage' and press enter key.
Tab till Azure SQL Migration and press enter key.
Tab till 'migrate to azure sq'l and press enter key.
Saved session page will open.
Select start new session and give next.
Databases for assessment page will open.
Select the respective databases and give next.
Assessment results and SKU recommendations page will open.
Tab till next button and press enter.
Target platform and assessment results page will open.
Tab till 'select target type' dropdown and select Azure SQL Managed Instance.

Tab till Next button and press enter.
17. Azure SQL target page will open.
18. Filled the required field and tab till next button and press enter.
19. Azure database Migration service page will open.
20. Fill the required field and tab till next button.
21. Data source configuration page will open.
22. Fill the required field and tab till next button and press enter.
23. Summary page will open.
24. Tab till Start migration button and press enter.
25. Tab till Migration tab.
26. Tab till the controls present under the table.
Actual:
Buttons 'DWQueue' and 'Restoring' present under the table of 'Migration' tab, is not keyboard accessible while navigating with tab key.
Focus after the Ascending checkbox button, it is going over the whole table. After pressing tab again, it is going over the Problems tab.
Expected:
Buttons 'DWQueue' and 'Restoring' present under the table of 'Migration' tab, should be keyboard accessible while navigating with tab key.
User Impact:
Keyboard users will not be able to access the button present under the table of 'Migration' tab.
Attachment:
ScreenRecordingForKeyboardFocus.zip

@BhanuPrakashGit the attachment is empty. Can you please add screenshots or a new attachment?

GithubTags:#Regressed:01-15-24;#Closed;
Verified the bug in the environment:
Version: 1.48.0-insider (Universal)
Commit: e5e1204d4fb4d4e880cdd893347752ee5736459a
Date: 2023-12-05T06:38:01.191Z
VS Code: 1.82.0
Electron: 25.9.6
Chromium: 114.0.5735.289
Node.js: 18.15.0
V8: <IP_ADDRESS>-electron.0
OS: Darwin arm64 23.2.0
Issue is fixed, we are able to navigate over the button with the help of the arrow keys. Hence closing the bug.
PFA for reference
25150_FocusIssue.zip


Proper units for water price

The restricted_weekly_average_volumetric_price of Restrictions.cpp, like weekly_average_volumetric_price of Utility::calculateWeeklyAverageWaterPrices, must be divided by a factor 1e6, if other fiscal parameters in Problem objects are given in millions of dollars, or if measuring by millions is meant to be the standard financial outcome (as is currently implied by PaperTestProblem.cpp). Currently they are divided by WEEKS_IN_MONTH, which should be removed if typesMonthlyDemandFraction is unitless values between [0,1] and typesMonthlyWaterPrice contains prices in units of $/MGal or other unit of dollars-per-water-sold (which they are for PaperTestProblem.cpp).

Hi Dave, thanks for submitting the issue and sorry about the awfully delayed reply. I've been busy for a while helping a Brazilian MS student using WaterPaths and her schedule is quite tight, which is why I haven't gotten into this yet.
If you have the time and the disposition, would you mind creating a unit test for this and submitting a pull request with your bug fix?


Add auto determination of return or raise presence

Read function body to determine whether a return or raises section should be present

Will have a look into the ast for that

https://github.com/JanEricNitschke/pyment/commit/6d1f19c001f0d862aa1663f381153e775b247105


Potential TypeScript issue beyond version 3.6.1

I've setup a small repo here. A simple npm start is enough to have it crashing due to something that is related to this issue. However, it might be the RBX typings since others reported that their issue was fixed by upping the version to upcoming releases - which it doesn't on my machine.

Closing in favor of #116.


Spy network settings now follows comfig style

https://github.com/mastercoms/mastercomfig/pull/222#issuecomment-594794438
Following the comfig style, I think it should be like this.

This is not necessary at all, it is only a aesthetic issue.

I don't understand the benefit of this.

I don't understand the benefit of this.

It has no benefit, it's just an aesthetic issue like I said. It's just to make it more "organized".

I feel like it's more confusing, because of the additional alias layer.


Causes Playnite to crash from a 'cold' start

When starting Playnite (on Windows startup or after closing Playnite completely) CheckDLC will often cause an unreacoverable error,

Choosing to restart Playnite will make it start normally.
The crash can happen during normal use, but it's rare and doesn't follow the same pattern every time.
Starting playnite after it's been shutdown completely is the most consistent method to make CheckDLC cause a crash.
Here's what I found in the playnite.log
14-07 00:07:28.034|INFO |PlayniteApplication:Application <IP_ADDRESS>67 started
14-07 00:07:29.052|ERROR|PlayniteApplication:Unhandled exception occured.
System.NullReferenceException: Object reference not set to an instance of an object.
   at CommonPluginsShared.Collections.PluginDatabaseObject`4.Games_ItemUpdated(Object sender, ItemUpdatedEventArgs`1 e) in D:\GitHub\Lacro59\playnite-checkdlc-plugin\source\playnite-plugincommon\CommonPluginsShared\Collections\PluginDatabaseObject.cs:line 998
   at System.EventHandler`1.Invoke(Object sender, TEventArgs e)
   at Playnite.Database.ItemCollection`1.OnItemUpdated(IEnumerable`1 updates) in C:\projects\playnite\source\Playnite\Database\Collections\ItemCollection.cs:line 623
   at Playnite.Database.ItemCollection`1.Update(IEnumerable`1 itemsToUpdate) in C:\projects\playnite\source\Playnite\Database\Collections\ItemCollection.cs:line 568
   at Playnite.Database.GamesCollection.Update(IEnumerable`1 itemsToUpdate) in C:\projects\playnite\source\Playnite\Database\Collections\GamesCollection.cs:line 200
   at DuplicateHider.DuplicateHiderPlugin.<OnApplicationStarted>d__49.MoveNext() in E:\Programmierung\playnite-dev\DuplicateHider\source\DuplicateHiderPlugin.cs:line 321
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.CompilerServices.AsyncMethodBuilderCore.<>c.<ThrowAsync>b__6_0(Object state)
   at System.Windows.Threading.ExceptionWrapper.InternalRealCall(Delegate callback, Object args, Int32 numArgs)
   at System.Windows.Threading.ExceptionWrapper.TryCatchWhen(Object source, Delegate callback, Object args, Int32 numArgs, Delegate catchHandler)
   at System.Windows.Threading.DispatcherOperation.InvokeImpl()
   at System.Windows.Threading.DispatcherOperation.InvokeInSecurityContext(Object state)
   at MS.Internal.CulturePreservingExecutionContext.CallbackWrapper(Object obj)
   at System.Threading.ExecutionContext.RunInternal(ExecutionContext executionContext, ContextCallback callback, Object state, Boolean preserveSyncCtx)
   at System.Threading.ExecutionContext.Run(ExecutionContext executionContext, ContextCallback callback, Object state, Boolean preserveSyncCtx)
   at System.Threading.ExecutionContext.Run(ExecutionContext executionContext, ContextCallback callback, Object state)
   at MS.Internal.CulturePreservingExecutionContext.Run(CulturePreservingExecutionContext executionContext, ContextCallback callback, Object state)
   at System.Windows.Threading.DispatcherOperation.Invoke()
   at System.Windows.Threading.Dispatcher.ProcessQueue()
   at System.Windows.Threading.Dispatcher.WndProcHook(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam, Boolean& handled)
   at MS.Win32.HwndWrapper.WndProc(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam, Boolean& handled)
   at MS.Win32.HwndSubclass.DispatcherCallbackOperation(Object o)
   at System.Windows.Threading.ExceptionWrapper.InternalRealCall(Delegate callback, Object args, Int32 numArgs)
   at System.Windows.Threading.ExceptionWrapper.TryCatchWhen(Object source, Delegate callback, Object args, Int32 numArgs, Delegate catchHandler)
   at System.Windows.Threading.Dispatcher.LegacyInvokeImpl(DispatcherPriority priority, TimeSpan timeout, Delegate method, Object args, Int32 numArgs)
   at MS.Win32.HwndSubclass.SubclassWndProc(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam)
   at MS.Win32.UnsafeNativeMethods.DispatchMessage(MSG& msg)
   at System.Windows.Threading.Dispatcher.PushFrameImpl(DispatcherFrame frame)
   at System.Windows.Threading.Dispatcher.PushFrame(DispatcherFrame frame)
   at System.Windows.Application.RunDispatcher(Object ignore)
   at System.Windows.Application.RunInternal(Window window)
   at System.Windows.Application.Run(Window window)
   at Playnite.DesktopApp.ProgramEntry.Main(String[] args) in C:\projects\playnite\source\Playnite.DesktopApp\ProgramEntry.cs:line 71
14-07 00:07:31.184|DEBUG|WindowFactory:Show dialog window Playnite.Windows.ExtensionCrashHandlerWindowFactory: 98b4fb85-ff19-44f0-8f37-60a32f0f5019

Can you try with the last version?

Just tested it out with with a handful of cold starts with Playnite, and no crash or error's.


docs(quickstart): remove extra quote in example

About
This pull request removes an extra quote from the Quickstart page. This quote causes the code to throw a SyntaxError. The change has been made in the first example in the Creating and sending Components section.
Checklist

[x] I've ran pre-commit to format and lint the change(s) made.
[x] I've checked to make sure the change(s) work on 3.8.6 and higher.
[x] This fixes/solves an Issue.

#643 :

[x] I've made this pull request for/as: (check all that apply)

[x] Documentation
[ ] Breaking change
[ ] New feature/enhancement
[ ] Bugfix

Please make sure to link an existing issue or to create one as per our contribution requirements.

Done! 👍🏼


feature: process not found prints to debug(1) instead of (0)

Is your feature request related to a problem? Please describe.
https://discord.com/channels/1186394868336038080/1186421052071477428/1299328371943280713
Got request from network but process X doesn't exist can happen often, for example in the case of uninstalling an app, and still getting network requests from it. These will be discarded by the kernel but their verbosity is very high right now.
Describe the solution you'd like
Perhaps a config? Or just put in them in verbosity 1 or 2.
Additional context
Code links where this happens:
https://github.com/kinode-dao/kinode/blob/8ef4fbcacddb35429727d5b8725e7a402b2ebb3e/kinode/src/kernel/mod.rs#L803-L826

#586


Update README.md

I added some portable bashscripts here with almost zero dependencies (except awk/perl for some scripts).

Added kanban.bash in<PHONE_NUMBER>41303904c6d66eedfbe926fe9fdd8e and powscript in ded47748f730b5deed4db1ba0998e56ba0814091. The rest of the links don't yet meet the notability requirements or are no longer available.


Callback for no result

Add a callback function if no result is returned #213

+1

Very good, it is necessary.


fix(Button): Disabled Button with Label leaves Label enabled (#1026)

Current coverage is 100% (diff: 100%)

No coverage report found for master at 1293e18.

Powered by Codecov. Last update 1293e18...e92f4fb


Prompt wont work in it has quote in it

eg. this wont work

Add 'aa_' prefix to module names
I think they should be escaped for command line  with ` ?

Seems to work for me, which OS do you use?

Note: ' characters are already escaped.
This is the resulting command:
ollama run mistral 'Summarize the following text:
Add \'aa_\' prefix to module names
I think they should be escaped for command line with ` ?'

Did you maybe override require('gen').command since you couldn't set the model?

Ok, did some debugging on this, as this is happening with me too.
The issue is in escaping the ' character, for shell it needs to be '\''
see :h shellescape
the fix is pretty simple, I can open a pr for it
        text = string.gsub(text, "'", "'\\''")

I still have this issue for some reason 🤔
this is a 'test' - works
this is a test - works
this is a "test" - doesn't work

i have this issue too, also happening with double quotes, for example calling :Gen Review_Code on the following input:
"test"

generates the following query:
curl --silent --no-buffer -X POST http://localhost:11434/api/generate -d "{""model"": ""zephyr"", ""stream"": true, ""prompt"": ""Review the following code and make concise suggestions:\n```cpp\n\""test\""\n```""}"

but calling it with the code:
'test'

generates:
curl --silent --no-buffer -X POST http://localhost:11434/api/generate -d "{""model"": ""zephyr"", ""stream"": true, ""prompt"": ""Review the following code and make concise suggestions:\n```cpp\n'test'\n```""}"

my OS is windows

Unfortunately I don't have a windows machine to test, but just ran the same tests above, and both works
Input: "test"
command
curl --silent --no-buffer -X POST http://localhost:11434/api/generate -d '{"model": "codellama", "stream": true, "prompt": "Review the following code and make concise suggestions:\n```cpp\n\"test\"\n```"}'

Input: 'test'
command
curl --silent --no-buffer -X POST http://localhost:11434/api/generate -d '{"model": "codellama", "stream": true, "prompt": "Review the following code and make concise suggestions:\n```cpp\n'\''test'\''\n```"}'

Although cannot say for sure, but it might be that neovim doesn't recognize your shell that you are using, or it's mis-configured somewhere.
see
help 'shell'
help 'shellquote'
and help 'shellxquote'

it seems to be a windows only problem, it has to do with the fact that the commands are being called with cmd so vim.fn.shellescape() has to substitute every double quote with two double quotes, but vim.fn.json_encode() already tries to escape double quotes like \".
so when the command is called the json is all messed up and doesn't have consistent escaping.
i think I've already fixed it on my end, I'll open a PR.


⚠ Bofrost.nl has degraded performance

In 71a74ae, Bofrost.nl (https://www.bofrost.nl) experienced degraded performance:

HTTP code: 200
Response time: 1376 ms

Resolved: Bofrost.nl performance has improved in c2c4ec4 after 7 minutes.