wildfly:run fails to run the Wildfly

Hi Team,
To reproduce this issue:
Create an empty project, containing only this pom.xml at the root:

4.0.0
maven.wildfly
maven-wildfly
1.0-SNAPSHOT
pom

org.wildfly.plugins
wildfly-maven-plugin
1.1.0.Alpha1

The contents of pom.xml is not displayed properly, hence I have attached an image of pom.xml
And run: mvn wildfly:run -Dwildfly.version=8.2.0.Final
Then the following error is generated:
Failed to execute goal org.wildfly.plugins:wildfly-maven-plugin:1.1.0.Alpha1:run (default-cli) on project maven-cargo-wildfly: The deployment 'MavenCargoWildfly\target\maven-wildfly-1.0-SNAPSHOT.maven-project' could not be found. -> [Help 1]
[ERROR]
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR]
[ERROR] For more information about the errors and possible solutions, please read the following articles:
[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoExecutionException
However start goal works fine:
For e.g: mvn wildfly:start -Dwildfly.version=8.2.0.Final

The start goal attempts to start and deploy an application. Since your pom has a packing type of pom it attempts to deploy maven-wildfly-1.0-SNAPSHOT.maven-project which does not exist. I assume you have a WAR or EAR module on here. You need to use the following configuration.
<plugin>
    <groupId>org.wildfly.plugins</groupId>
    <artifactId>wildfly-maven-plugin</artifactId>
    <version>1.1.0.Alpha1</version>
    <configuration>
        <skip>true</skip>
    </configuration>
</plugin>

Then in either your EAR or WAR project use the same configuration except change the <skip>true</skip> to <skip>false</skip>.

Hi Team,
Thanks for the response.
With the packaging type as 'pom', start goal is able to run successfully.
Its only the run goal fails.
With packaging type as 'pom', when I run "mvn wildfly:start", it runs successfully, where as "mvn wildfly:run" fails.
Our use case is, The plugin will be used in a parent pom of QA functional and integration tests, which will start an existing wildfly instance in local machine without deploying any app.  The setup of wildfly with the deployments and configuration is already done by a script.  We only need to start the existing local wildfly with the existing configurations (standalone.xml, ears, etc).  So we need to use this plugin in a pom, which has packaging type as 'pom', as we don't have anything to deploy in our use case.
If the wildfly:run goal, gracefully ignores the deployment if the packaging type is 'pom' then it will be very helpful for us.  You can take this as a feature request to this plugin.

It doesn't sound like you want the run goal anyway. That goal will deploy an application and block until you shutdown WildFly or use SIGINT for the process.

The use case is, "start" goal will be used while running "mvn clean install".  If there are any test failures, then "mvn wildfly:run" will be executed and the individual failing test will be run from IDE to debug or to fix the test.  The idea was to use the "run" goal similar to starting a wildfly from bin folder and stop it whenever the debugging is completed, but the maven configurations will abstract the actual details to be made in the wildfly server startup by using standalone.bat or standalone.sh (for e.g sending server args for port offset, setting jvm args etc will be captured in the pom.xml) instead of setting it through standalone.conf.bat or command line

It would probably be best to set a profile which can be run on the specific deployment then. Note though that maven will block though and no further plugins, goals or anything from maven will be executed.
As an example in your WAR you could do something like:
    <profiles>
        <profile>
            <id>test.debug</id>
            <activation>
                <property>
                    <name>test.debug</name>
                </property>
            </activation>
            <build>
                <plugins>
                    <plugin>
                        <groupId>org.wildfly.plugins</groupId>
                        <artifactId>wildfly-maven-plugin</artifactId>
                        <executions>
                            <execution>
                                <phase>package</phase>
                                <goals>
                                    <goal>run</goal>
                                </goals>
                            </execution>
                        </executions>
                    </plugin>
                </plugins>
            </build>
        </profile>
    </profiles>

You can then just do mvn package -Dtest.debug or mvn package -Ptest.debug.

<?xml version="1.0" encoding="UTF-8"?>
<project xmlns="http://maven.apache.org/POM/4.0.0"
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
<modelVersion>4.0.0</modelVersion>
<groupId>maven.wildfly</groupId>
<artifactId>maven-wildfly</artifactId>
<version>1.0-SNAPSHOT</version>
<packaging>pom</packaging>
<build>
<pluginManagement>
<plugins>
<plugin>
<groupId>org.wildfly.plugins</groupId>
<artifactId>wildfly-maven-plugin</artifactId>
<version>1.1.0.Alpha1</version>
</plugin>
</plugins>
</pluginManagement>
</build>
<profiles>
<profile>
<id>test.run</id>
<activation>
<property>
<name>test.run</name>
</property>
</activation>
<build>
<plugins>
<plugin>
<groupId>org.wildfly.plugins</groupId>
<artifactId>wildfly-maven-plugin</artifactId>
<executions>
<execution>
<phase>pre-integration-test</phase>
<goals>
<goal>run</goal>
</goals>
</execution>
</executions>
</plugin>
</plugins>
</build>
</profile>
<profile>
<id>test.start</id>
<activation>
<property>
<name>test.start</name>
</property>
</activation>
<build>
<plugins>
<plugin>
<groupId>org.wildfly.plugins</groupId>
<artifactId>wildfly-maven-plugin</artifactId>
<executions>
<execution>
<phase>pre-integration-test</phase>
<goals>
<goal>start</goal>
</goals>
</execution>
</executions>
</plugin>
</plugins>
</build>
</profile>
</profiles>
</project>

Hi James,
I had tried the following commands with the above pom.xml.  Please note the packaging type is still 'pom':
mvn clean install -Dtest.start
mvn clean install -Dtest.run
"mvn clean install -Dtest.start" works even if the packaging type is 'pom', it doesn't try to deploy the current module if the packaging type is 'pom'.  However "mvn clean install -Dtest.run" doesn't work, because it tries to deploy the current module with packaging as 'pom'.
It will be ideal if the "run" goal gracefully ignores the deployment step if the packaging type of the module is 'pom' and just carry on in starting the wildfly server.
Regards,
Harish

Hi Team,
I had a look at org.wildfly.plugin.server.RunMojo.java file.
The doExecute() method checks for the deploymentFile, whether it exists or not.
If the doExecute() checks if the package type is not ignored (org.wildfly.plugin.deployment.PackageType.isIgnored) and then deploy the package if the package type is not ignored.
I can see isIgnored() method is always returning false, but I guess it will be enhanced to return 'true' if the package type is 'pom'

Ignoring the package type wouldn't really work. Say you have an EAR project. That EAR likely depends on a WAR and maybe an EJB jar. If we skipped the POM and the EJB jar would likely build first and then that would where the run goals is executed. The run goal needs to be run on the sub-module that you'd like to run. There's no way around that.

Hi James,
My use case is:
As a developer, I want to start an existing local wildfly instance before running integration test and shutdown the instance once the integration test is completed.  This use case is satisfied by "wildfly:start" goal.  This goal is a non-blocking goal and hence carries on to run the integration tests.  This goal works even with packaging type as 'pom'
My other user case is:
As a developer, I want to start an existing local wildfly instance and keep running this instance until I press ctrl+c.  This will enable me to verify my application manually and also helps me to run single integration test from IDE.  I couldn't use the start goal because it doesn't keep the server running.  Also I couldn't use run goal because it tries to deploy the module and fails if the module is of packaging type 'pom'.  I want a goal similar to 'start', which will keep the server running, but doesn't try to deploy like the 'run' goal.
Do we have any mechanism to achieve this?  If not available, then can it be taken up as a request for enhancement?

Also, in my previous comment, I was not suggesting to ignore the whole module if the packaging is 'pom'.  What I was suggesting was:
In the code, as part of RunMojo, there is a check to see if the deployment file exists and this deployment file is deployed to the running instance of wildfly.  I was suggesting if the check is removed if the packaging type is 'pom' and subsequently by-pass the deployment step alone if the packaging type is 'pom', otherwise it will continue to perform as it does now..It can move on to its sub-modules and continue to do it recursively.

Also when I was referring to the documentation for "run" goal as in here..
https://docs.jboss.org/wildfly/plugins/maven/latest/run-mojo.html
The property "checkPackaging" describes something like maven package types 'pom' is ignored.

There are two ways this will work.

You could cd into the maven module you want to run, e.g. your war module, and execute mvn wildfly:run.
You could create a profile for the run goal in the module pom for your deployment.

That's the only way it can work. There's no way for the plugin to know which child of the parent should be run.

Hi James,
I don't have a war module in my project.  It is only root model and two sub modules which are acceptance test modules.. The war will be available in the internal maven repository uploaded by the development team.  This use case is for the QAs to download the war file from internal maven repository and deploy in the local wildfly instance and start the instance before running the acceptance test.  The above method will work for the development team, who generates the war.  But our use case is QA acceptance test is in different repository, which doesn't contain the war module, it contains only the acceptance tests.

The run goal is meant to deploy the maven artifact it is working with. I'd consider changing the start goal to not exit after the maven build is complete. There's no changes for the run goal that would work for what you're trying. It's mean to run WildFly, deploy an archive and block until SIGINT is hit.

Yes, if the start goal takes an extra flag or variable and keeps the wildfly to run until ctrl+c is pressed will be ideal for me..

It can't block until CTRL+C is pressed. There's no way for the process to know where to block.

Hi, in your previous comment you suggested to consider changing the start goal not to exit after the build is complete.  I want that feature.  If the start goal doesn't exit after build, then there should be some mechanism to stop it once the user want to stop it

The only way would be to issue a shutdown to the server process or kill the processes. You can do this via the shutdown goal, executing $JBOSS_HOME/bin/jboss-cli.sh -c ":shutdown" or any other management way of shutting it down.

That will solve our use case.  I can use shutdown goal to stop the running instance.  So my understanding is "start" goal will take some flag to leave the server running even after the maven build is complete and then I can use "shutdown" goal to stop the running instance.  This will work perfectly for my use case.  Please take this as a change request or enhancement.

Closing in favor of #34


[BUG] Missing enum values in Dynatrace - billingCycle, usageType

API Spec link
https://github.com/Azure/azure-rest-api-specs/blob/0b38eb96c2692db05a881c2147d89c8017a5c88a/specification/dynatrace/resource-manager/Dynatrace.Observability/stable/2023-04-27/dynatrace.json#L1737, https://github.com/Azure/azure-rest-api-specs/blob/0b38eb96c2692db05a881c2147d89c8017a5c88a/specification/dynatrace/resource-manager/Dynatrace.Observability/stable/2023-04-27/dynatrace.json#L1741
API Spec version
2023-04-27
Describe the bug
As described in Swagger, these 2 values should be enums instead of strings.
Expected behavior
billingCycle should have values:
"MONTHLY",
"WEEKLY"

usageType should have  values:
"PAYG",
"COMMITTED"

Actual behavior
Now these 2 values are treated as strings.
Reproduction Steps
The actual behavior is not aligned with the description of the values in Swagger.
Environment
No response

@abhargavams Please help take a look, thanks.


Undefined method error w/ user_ulimit on Chef 12

Cookbook version
bmhatfield/chef-ulimit@370b4b0
Chef-client version
12.21.4
Platform Details
Ubuntu 16.04
Scenario:
Use the user_ulimit resource on Chef 12
Steps to Reproduce:

Add a user_ulimit resource to a cookbook
Attempt to converge using Chef 12

Expected Result:
Successful convergence
Actual Result:
Failure:
================================================================================
Recipe Compile Error in /tmp/kitchen/cache/cookbooks/ulimit/providers/domain.rb
================================================================================

NoMethodError
-------------
undefined method `action' for Chef::Provider::UlimitRule:Class

Cookbook Trace:
---------------
  /tmp/kitchen/cache/cookbooks/ulimit/providers/rule.rb:8:in `<class:UlimitRule>'
  /tmp/kitchen/cache/cookbooks/ulimit/providers/rule.rb:1:in `<top (required)>'
  /tmp/kitchen/cache/cookbooks/ulimit/providers/domain.rb:1:in `require_relative'
  /tmp/kitchen/cache/cookbooks/ulimit/providers/domain.rb:1:in `class_from_file'

Relevant File Content:
----------------------
/tmp/kitchen/cache/cookbooks/ulimit/providers/rule.rb:

  1:  class Chef::Provider::UlimitRule < Chef::Provider
  2:    def load_current_resource
  3:      new_resource.domain new_resource.domain.domain_name if new_resource.domain.is_a?(Chef::Resource)
  4:      node.run_state[:ulimit] ||= Mash.new
  5:      node.run_state[:ulimit][new_resource.domain] ||= Mash.new
  6:    end
  7:
  8>>   action :create do # ~FC017
  9:      node.run_state[:ulimit][new_resource.domain][new_resource.item] ||= Mash.new
 10:      node.run_state[:ulimit][new_resource.domain][new_resource.item][new_resource.type] = new_resource.value
 11:    end
 12:
 13:    action :delete do
 14:      # NOOP
 15:    end
 16:  end
 17:

This works well under Chef 13.

I think Chef::Provider doesn't have an action method in Chef 12.

c83088e46876479ce4f919aeacfca708f3322e93 works for me if someone wants to bisect

I’ll give it a shot.

Alrighty, got some results:
35e93a08774d1f187a87b1b0c5f2e0ecfd3081fe is the first bad commit
commit 35e93a08774d1f187a87b1b0c5f2e0ecfd3081fe
Author: Tim Smith<EMAIL_ADDRESS>Date:   Wed Jul 26 19:43:49 2017 -0700

    Properly extend Chef::Provider not Chef::Resource

    This is how we get use_inline_resources to work

    Signed-off-by: Tim Smith<EMAIL_ADDRESS>
:040000<PHONE_NUMBER>387a691718bf7de11f7a9a6abfc3d699b876 d0644b5cb86fde7d50a53719001cce2ee2d3cd9f M	providers
:040000<PHONE_NUMBER>1ca883507395046b5049a63c6b967f87a184 8b0c6cf026e549ca544fd42502106184dd2fbdcb M	recipes

I did also see an issue w/ use_inline_resources, but ignored that to focus on this issue. That turns out to be good, considering what this commit’s message says 😄

Well, I dug into this a bit, and… well, things are rather confusing to me. Some questions:

If these are Chef 12.5-style Custom Resources, why are there still separate provider & resource files?
Why are these written library-style, instead of using the DSL?
Why are there actions on the resources and the providers of the ulimit_domain and ulimit_rule resources?
Would it make sense to, instead of having arbitrary rule blocks on a ulimit_domain resource, to have an array of hashes? E.g., instead of this:

ulimit_domain 'my_user' do
  rule do
    item :nofile
    type :hard
    value 10000
  end
  rule do
    item :nofile
    type :soft
    value 5000
  end
end

we had this:
ulimit_domain 'my_user' do
  rules([{
    item: :nofile
    type: :hard
    value: 10000
  ],
  [
    item: :nofile
    type: :soft
    value: 5000
  ]
end

We could simplify a ton of the logic inside ulimit_domain, and perhaps do away completely with the load_current_resource stuff (which should probably be refactored to be load_current_value) on both resources, since, in the end, a template is what we do, and that resource has its own idempotency we can depend upon.

@tas50 any chance you could weigh in? @jeffbyrnes making some good points :)

This should be fixed in the 1.0 release that's up on the Supermarket now. We have kitchen tests now and everything is green.


enhance threadpool and bug fix

enhance threadpool

support entry_code reuse, reduce loadstring times
fix bug create uv_key_t to hold lua vm
fix bug when threadpool(uv.new_work) use wrong stack index

crash on linux,because uv_key_set,(imp with pthread_setspecific), MikePall give https://github.com/LuaJIT/LuaJIT/issues/8,

@rphillips  @creationix any ideas?

Perhaps this PR might help: https://github.com/luvit/luvi/pull/121


Added configuration, refactored Agent and Tools

agent/alpaca is not used anywhere
I think agent/ should have an extra layer to support other types than ReWOO


Update and rename main.py to mainwithcomments.py

please merge it soon

Hi @nikcode9, thank you for your contribution. We will not rename main.py, also you removed some parenthesis which does not make sense so I’ll close the PR, but feel free to open another one with the improved comments!


[BUG]: nothing happens after entering token

every time after inserting token the program gives an error and closes without anything else happens, how to solve it?

Thrown error indicates that your DNS cannot resolve domain address of Mi Cloud.
You should check if your internet connection settings are correct.


Extract creation and last updated timestamp for v3 dump

Pull Request
Related issue
Fixes #2988
What does this PR do?
Inspired by the v4 dump implementation, this extracts the first createdAt and last updatedAt fields by parsing the task queue.
Questions:

Should the parsing of the tasks be cached instead of being parsed for every index since it might add a performance penalty?
I am not sure if the created_at and processed_at fields are correct
Should I assume the data is sorted in some order like with uuid or updateId? I assumed the list is unordered.
I was planning to populate my dev instance with data and dump my data. Is there a way to dump with previous versions?

PR checklist
Please check if your PR fulfills the following requirements:

[x] Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)?
[x] Have you read the contributing guidelines?
[x] Have you made sure that the title is accurate and descriptive of the changes?

Thank you so much for contributing to Meilisearch!

Hey @FrancisMurillo! Thanks for your PR, from what I see the code is pretty clean that’s nice!

Should the parsing of the tasks be cached instead of being parsed for every index since it might add a performance penalty?

We don't mind at all about performance when importing dumps (at least old one), the only thing that matters it to keep the code simple and easily testable thus I would prefer if you keep it like that but thanks for asking 👍

Should I assume the data is sorted in some order like with uuid or updateId? I assumed the list is unordered.

The list seems to be sorted, but all the indexes are mixed together.
Which means you’ll typically have things like that;
{ "index_uid": "a", "task_uid": 0 }
{ "index_uid": "a", "task_uid": 1 }
{ "index_uid": "a", "task_uid": 2 }
{ "index_uid": "b", "task_uid": 0 }
{ "index_uid": "a", "task_uid": 3 }
{ "index_uid": "b", "task_uid": 1 }
{ "index_uid": "b", "task_uid": 2 }

I was planning to populate my dev instance with data and dump my data. Is there a way to dump with previous versions?

The only way to create an old dump is to run an old version of meilisearch and create a dump sadly.
I already took some time to craft a dump for each version of meilisearch so you don’t have though. It doesn’t test every possible things but it’s still pretty good.
You should find the dump-v3 version here; MeiliSearch/dump/tests/assets/v3.dump
And since the dump are just a .tar.gz you can actually extract it to see its content if you want with the following question; tar xzf v3.dump

@irevoire Thanks for the feedback.

The only three kind of tasks that can create an index.
The documentAddition and Settings can create it even if they fails, they’ll do it anytime they starts processing the task

I changed the meta.createdAt and meta.updatedAt to use the task.finishedAt field instead of task.enqueuedAt as specified by your code sample and comment. Since only finished tasks have this value, I filtered for that as well.
I also just took the earliest createdAt and latest updatedAt instead of depending on updateId

(On Index Deletion) We reset both markers

When an index is deleted, it uses a new id and resets the updateId so I don't think we need to reset anything.

bors merge

bors merge

I removed the cache of the CI to fix this


🐛 BUG: allow route setting to be empty string

What version of Wrangler are you using?
2.10.14
What operating system are you using?
All
Describe the Bug
The following wrangler.toml is valid in Wrangler 1:
...
route = ""
...

In Wrangler 2 it is reported as invalid. For backward compatibility, should we allow this to be equivalent to not setting the route?

I guess. Probably with a warning. Pretty silly behaviour by wrangler 1 tbh, but we should "support" the miss on our part.


Decouple privkey management from cert handling

          In a separate issue, should we decouple privkey management from cert handling?

Originally posted by @sed-i in https://github.com/canonical/observability-libs/pull/66#discussion_r1407053949

@sed-i is the current implementation what you meant, or can you specify what this change is supposed to be?

@lucabello, ideally I'm hoping for https://github.com/canonical/operator/issues/1328.
In a sense, private key management has nothing to do with cert handling.


License is missing

Please keep license info in package.json and in file as in original repo: https://github.com/etchteam/storybook-addon-status/blob/master/LICENSE

How I can install this fork?


I Can't add PURA MAX into PETKIT App devices

I have purchased PETKIT PURA MAX in the Chinese version is not compatible with PETKIT(international), How I can add devices on PETKIT app for use hasscc control?

Have you tried creating a Chinese account to bind the device ?

Ok, I use it outside china, no have Chinese account have only international account.

Ok, I use it outside china, no have Chinese account have only international account.

Did you solve the connection problem?

I purchased the Chinese version of Pura Max locally. It cannot be used in other countries. Is there a way to make it usable?

When I change the region to China on my iPhone and set the region to China in the Petkit app, device registration fails at around 70%.


issue-11 Rename Builder#with(File cwd) and Builder#with(Map<String, S…

…tring> env) to avoid name clashes

@dakusui I've added a test case for Cmd Builder with all methods being refactored.

Cool, why don’t we merge it now?


Approximate European option price under Heston model

Heston model has accurate density approximations for European option prices, which are of interest.
The module implementing this method should live under tf_quant_finance/volatility/heston_approximation.py. It should support both European option puts and calls approximations. Tests should be in heston_approximation_test.py in the same folder.

I'd like to work on this!

@cyrilchim the link to the training you're referring isn't available. Has it been moved?

Hi Michael,
Yes the trainings have now been moved. They are available under examples/jupyter_notebooks.
-Ashish

Thanks a lot for your reply :)
On Sat, Apr 18, 2020, 12:09 PM Ashish Saxena<EMAIL_ADDRESS>wrote:

Hi Michael,
Yes the trainings have now been moved. They are available under
examples/jupyter_notebooks
https://github.com/google/tf-quant-finance/blob/master/tf_quant_finance/examples/jupyter_notebooks/Introduction_to_TensorFlow_Part_1_-_Basics.ipynb
.
-Ashish
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/google/tf-quant-finance/issues/9#issuecomment-615836166,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABEIAZZNNGQW42VP2IIE3BLRNF37PANCNFSM4IVTYKBA
.

@brilhana
Hi Alexandre,
Are you still working on this issue? If you are, could you please let us know.
-Ashish

I am very interested to work on it. If Alexandre is not working it, I would like to take up the work.

Thank you for the interest, Siddhant!
@michaelazer are you still working on this?

Ok, I am reassigning to @iamsiddhantsahu

@cyrilchim Thanks! Pleasure to work on this. Taking this assignment as part of my university semester project.
As stated in your first comment quoted below,

The module implementing this method should live under tf_quant_finance/volatility/heston_approximation.py. It should support both European option puts and calls approximations. Tests should be in heston_approximation_test.py in the same folder.

But, I am afraid I do not see the volatility folder in the path mentioned. Do I need to create it?

Found it. I guess it has been refactored. I guess it should go inside the models/heston/approximations/european_option.py?

Yes, that is the correct folder

Hi, Can I contribute to this issue if not closed?

Hi @mudgala3,
Sorry for late reply. Yes, the issue is still open. Please let me know if you are still interested, I can assign this to you

Thanks. I'll start working on it. Any help on supporting reading material would be appreciated, I am new to the project

It is worth going through the training. A good reference point is Attari approximation for European option pricing.


[CARBONDATA-2249] Fixed bug for querying data through presto

Added lz4 dependency in presto's pom.xml as it was throwing an exception when the store location for presto is local.
Be sure to do all of the following checklist to help us incorporate
your contribution quickly and easily:

[ ] Any interfaces changed?

[ ] Any backward compatibility impacted?

[ ] Document update required?

[ ] Testing done
Please provide details on
- Whether new unit test cases have been added or why no new tests are required?
- How it is tested? Please attach test report.
- Is it a performance related change? Please attach the performance test report.
- Any additional information to help reviewers in testing this change.

[ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.

Build Success with Spark 2.1.0, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder1/4236/

Build Failed with Spark 2.2.1, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder/2992/

Build Success with Spark 2.1.0, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder1/4241/

Build Success with Spark 2.2.1, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder/2997/

Build Success with Spark 2.2.1, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder/3014/

Build Success with Spark 2.1.0, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder1/4258/

@jackylk I have made the required changes but there are some extra commits on my PR please check.

Build Success with Spark 2.2.1, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder/3112/

Build Success with Spark 2.1.0, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder1/4346/

@geetikagupta16 please rebase to master and drop the unwanted commit

@jackylk I have rebased the PR. Please check

SDV Build Success , Please check CI http://<IP_ADDRESS>:8080/job/ApacheSDVTests/3895/

Build Success with Spark 2.2.1, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder/3140/

SDV Build Success , Please check CI http://<IP_ADDRESS>:8080/job/ApacheSDVTests/3896/

SDV Build Success , Please check CI http://<IP_ADDRESS>:8080/job/ApacheSDVTests/3897/

Build Success with Spark 2.1.0, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder1/4365/

Build Success with Spark 2.2.1, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder/3368/

Build Success with Spark 2.1.0, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder1/4594/

LGTM

SDV Build Success , Please check CI http://<IP_ADDRESS>:8080/job/ApacheSDVTests/4092/


[ZEPPELIN-385] Notebook offline view mode

What is this PR for?
This PR is to address so called offline view (view only + offline) mode. In this mode you open notebook in only view mode meaning can't do any editions + notebook and paragraph bars are disabled. Further, it's called offline, in case someone else does any changes in the notebook while you have it open, the changes will not be rendered in your screen until you reload it. There was initial work under #389, however some notable differences exist. For example, same functionality here available from frontend menu without need to restart Zeppelin. Also it provides offline view which was absent in initial PR.
What type of PR is it?
Feature
Todos

[x] - basic frontend implementation
[ ] - address comments + green CI

What is the Jira issue?
related to ZEPPELIN-385
How should this be tested?

open any notebook
click offline view from the dropdown menu of notebook looknfeel bar on the  top right
try to edit note or do any changes

Screenshots (if appropriate)

Questions:

Does the licenses files need update? No
Is there breaking changes for older versions? No
Does this needs documentation? Possibly

@khalidhuseynov may be we should consider enabling show/hide editor and output buttons

I'm not sure what the usage of this feature as if would be.
#389 was aiming at having a view only experience at a time when auth was not implemented.
In our case it would make more sense to link this feature to the notebook user access settings, especially since only changing the url would still allow to access it in edit mode

@khalidhuseynov one thing: as soon as this changes the URL -  you might want to double-check and make sure that URLs to each separate paragraph (+IFrame ones) and a Search work with new URL.

@r-kamath that's good point, but that differs according to use cases (also as a workaround, possible to set those before switching to offline link). from point of view having offline view, no changes on notebook should be displayed and basically any paragraph updates are blocked to render in here, which includes updates from show/hide editor and output forms. However it can be reconsidered depending on more feedback on use cases.
@corneadoug it makes some sense, however view only isn't the only feature. i updated the description with second screenshot on offline view. anyways, I'll look more into how it goes along with the authentication and get back here.
@bzz thanks for feedback, i'll look into that.

Copying from Zeppelin mailing list:
It's not clear to me if offline mode would allow changing input controls (dropdowns/input box etc) and view the new result. Our requirement is for a dashboard mode, where multiple users can play with the data using the input controls but don't interfere with each other's work. This is a very basic requirement for making Dashboards using Zeppelin.
I think isolating a notebook copy in a web socket/user session (in Dashboard mode), can achieve the desired results.

Copying from Zeppelin Dev List:
It's not clear to me if offline mode would allow changing input controls (dropdowns/input box etc) and view the new result. Our requirement is for a dashboard mode, where multiple users can play with the data using the input controls but don't interfere with each other's work. This is a very basic requirement for making Dashboards using Zeppelin.
I think isolating a notebook copy in a web socket/user session (in Dashboard mode), can achieve the desired results.

@khalidhuseynov do you think we can close this one now, until you look into it more again? Or is it WIP?

@khalidhuseynov 1 week ping

@bzz thanks for ping, i'm closing it for now


Pk dev3

Hey. This is the first pull request I've done, so hopefully I've done it right and it works! Before doing this pull request I merged pk-dev3 with baselines_improvements, and I resolved conflicts.
I've only edited ppo2.py and runner.py (and gitignore). But below there are more files with changes -- those changes didn't show up when I merged my branch with baselines_improvements, so I'm a little confused why they show up here.

The reason more changes were showing up was because you were merging to master rather than the baseline_improvements branch. I switched the PR to be to that branch. Also good practice is to name the PR with a short description that summarizes the high-level changes across all commits.


how to read in specific rows and columns only?

In the xlsx package (which is hell to install so I chose readxl), you can specify certain rows and columns to read in with the arguments colIndex and rowIndex. readxl seems to lack this - how to accomplish the same with readxl?

See the discussion in #8. I think this will come.


Feature/bump core dependencies to angular 8

This PR contains the following changes:

Initial @angular/cli:^8.0.3 update by @DenisaSurdu

Squashed and signed commits into current

Bumping project dependencies to @angular/cli:^2.4.0 compatible versions
Bumping peer dependencies to @angular/cli:^2.4.0 compatible versions
Updating angular.json with compatible tags

- "architect" + "targets"

Because of the scripts-tag in package.json it seems like the primary package manager is yarn. Therefore I reconfigured the angular.json and removed the package-lock.json as well.

to: @kuhnroyal
cc: @DenisaSurdu
fixes: #69

Good to merge? Angular 9 is almost upon us

* polyfills.ts is out of date

no wonder, if nobody merges this within years :D @intellix

Hello, any progress on this issue? What prevents the merge?


fix: refine readme

:tada: This PR is included in version 1.1.4 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Feat #256: Support for stake addresses

Closes #256.

Currently, GYPubKeyHash corresponds to public payment key's hash. To make this more explicit, perhaps we should rename it later to something like GYPaymentKeyHash.


[BUG REPORT] Battle scene crashes upon losing

Bug Description:
When you enter the battle scene, and the player loses health entirely before the enemy, the game will crash instead of exiting the scene and switching scenes.
Formal reproduction steps:
Before replicating the bug, we made sure there were no variables being caused from prior scenes. That is, we went ahead and made sure that the game starts fresh, then all we do is enter into the battle scene. No talking with NPCs, or trying to switch scenes over and over, just kept it simple.
Upon entering the battle scene, we did a variety of moves. we restarted the game and entered the battle scene 3 times:
1. The first time, we just used the flirt button until losing. The game crashes.
2. The second time, we used a combination of flirting and attacking until we lost. The game crashes.
3. The final time, we used only attacking until we lost. The game crashes.
It is clear that the bug only comes from losing the battle

April 22nd: We realized the problem occurs after switching scenes upon losing. We forgot to include the timer changes that fixed the issue for crashing after the player wins. Simply, we just needed to change the function for the NPC to match the changes in the player's function.

April 23rd: pushed appropriate changes to GitHub


Nuke spams errors

Correctly set Explosion.ExplosionType to something that doesn't interact with terrain and buildings.

The errors also happen on the server, as well as, all clients.

O what would be a good explosion type to use then?

Explosion.ExplosionType=Enum.ExplosionType.NoCraters
(No craters for those that don't want huge gaping holes in their terrain that destroy their map, as well as, fixing errors caused by terrain/objects that can't be destroyed by explosions and cause errors.)


Deprecate Chronos

Starting to deprecated Chronos. Jobs with dependencies has been recently added to Marathon and DC/OS 2.2.
@kaiwalyajoshi @timcharper @pierrebeitz please review.
/cc @vinodkone

i strongly agree, @vinodkone. that was the first thing i checked. i haven't found it in universe and am 100% sure that we don't interpret something like that in the UI.

Building of .dcos file successful here: https://teamcity.mesosphere.io/viewLog.html?buildId=2967212&tab=buildResultsDiv&buildTypeId=DcOs_Enterprise_Components_PackageRegistry_UniversePackageBuilder_BuildCh


[Feature Request]Add Customizable TOOLBAR Option Similar to MS Visual Studio 2019

Add a toolbar similar to that in MSVS2019 and make it so that user can customize it with whatever commands are needed.
The Command Palette is a great feature, but often not as convenient as a toolbar would be.  It is also not as natural for users who are accustomed to using the toolbar in most other MS software.
I reviewed the "contributing guidelines" and searched existing requests for "toolbar" or "button.**

Duplicate of #41309

According to your own rules, the issue is in-scope in accordance with criterion 2. As for criterion 4, a user has started working on a prototype (see https://github.com/Microsoft/vscode/issues/41309#issuecomment-403222101 and https://github.com/junalmeida/vscode/pull/1 ), only to be immediately shut down by saying that a pull request creating a toolbar wouldn't be accepted.
The boilerplate message says that you are "happy to listen and to reconsider". Well, then listen to your users! And if you aren't willing to immediately reconsider, then at least provide some feedback. (Your only feedback so far has been to summarily ignore the existing issue, and to summarily close any new requests for a toolbar as out of scope and/or as a duplicate.)

I did not intend for this to be such an issue and did not know when I
posted that it had been.
Microsoft does not intend for VS Code to be a full on IDE that competes
with VS. This is one feature they can omit to prevent that. It's very
annoying and I will work to circumvent it as I learn more, but, at the same
time, MS Code is free, and is quite usable for me as a novice. VS (2019,
e.g.), while still free for me as I just do this to learn, is not as usable
(especially since I cannot figure out how to work on Jupyter notebooks in
there).
I appreciate that they are a business that needs to make money.  Also, they
do provide a lot of software on a free or free-for-non-commercial basis,
significantly discount costs for schools and nonprofits, and sponsor a lot
of good causes. MS has, for the most part, always been, more or less, a
good corporation. I have no interest in them whatsoever, but appreciate the
services. I am quite familiar with their data collection practices, and
believe them to be much more ethical than the F and G in FANG.
That being said, I think that people should be allowed (though not
necessarily encouraged) to find creative ways to solve issues such as this,
so long as it is not for commercial gain or with malicious intent. They
should not interfere with that by preventing someone from submitting or
sharing it on Github (if I understand what you are alleging correctly).
However, MS should be able to adapt the software to render those things
non-functional to protect IP and business interests.
Just my 2 cents.
On Thu, Jul 30, 2020 at 7:07 AM MikeRosoft<EMAIL_ADDRESS>wrote:

According to your own rules, the issue is in-scope in accordance with
criterion 2. As for criterion 4, a user has started working on a prototype
(see #41309 (comment)
https://github.com/microsoft/vscode/issues/41309#issuecomment-403222101
and junalmeida#1 https://github.com/junalmeida/vscode/pull/1 ), only to
be immediately shut down by saying that a pull request creating a toolbar
wouldn't be accepted.
The boilerplate message says that you are "happy to listen and to
reconsider". Well, then listen to your users! And if you aren't willing to
immediately reconsider, then at least provide some feedback. (Your only
feedback so far has been to summarily ignore the existing issue, and to
summarily close any new requests for a toolbar as out of scope and/or as a
duplicate.)
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/microsoft/vscode/issues/101961#issuecomment-666386336,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AMVTNVTR6EZEMAVXK2OZQOLR6F5BHANCNFSM4OVBLUWA
.


across() should auto-vectorize

across() should auto-vectorize functions using the same rules as normal auto-vectorization.

While this would be interesting, in reality this is very hard to do so we probably should not do it.
For named functions, we could in theory accomplish this by wrapping them inside an anonymous function (eg convert mean to x -> mean(x)). However, for anonymous functions, we would need to introspect the function body to auto-vectorize the body. We wouldn't want to autovectorize the anonymous function itself because there may be instances where the anonymous function needs to be able to see be whole vector at once.
Thus, I'm going to close this issue. We will plan to document this issue in the docs.


BART (Bay Area Rapid Transit) sensor

This is a sensor which provides the upcoming train departure times as well as any active advisories for BART using their official API.
Configuration looks like this:
sensor:
  - platform: bart
    origin: 19TH
    lines:
      - MLBR
      - SFIA

I'll write some real documentation shortly.

You have removed the checklist for both your PRs so you missed the instructions and both test and coverage are failling. Please fix.

@balloob I'm sorry, I was so excited that I wiped out the checklist thinking it was for issues and not PRs! Will fix both in a few minutes.

@balloob Fixed all on this one as well, thanks again

Closed in favor of #1623


Address deprecation warnings for tests and add local install gradle action

This adds a new make command and corresponding gradle task to install the plugin in the user's local plugins directory. This is to make it a little bit easier to get started with plugin development.
make install-plugin

The settings on this repo require you to both 'sign-off' (git commit --signoff) and cryptographically sign (git commit --gpg-sign) all commits before I can merge.

Signed and delivered 🫡


BSO =buy amylase pack

🐛 Bug Report
Currently when you try to =buy amylase pack, you’re are given the option to buy x100 amylase crystal using x100 amylase crystal. You’re only options are to confirm or cancel and when you confirm it says an unexpected error occurred.

Seems to be fixed now


Fixed closing html tags

Description
Fixed closing button html tags in message README.md
What's included?

Example docs changes

Test Steps

N/A

General Tests for Every PR

N/A

Screenshots or link to CodePen/Plunker/JSfiddle

Whoops, thanks for that!


Add homekit adaptive lighting support

Great Plugin! Really nice to control the lights with Apple HomeKit too. Do yo think it would be possible to add homekit adaptive lighting support for the non-streaming times?
Thanks!

I don't want to say to much, but you may want to look forward to the next update 😉
Seriously though, yes, this is on my to-do list since homebridge 1.3 added support for adaptive lighting.
I can't make any promises on a date, but as soon as I get the time I'll implement this.

I'm willing to venmo/paypal/whatever $50 for adaptive lighting support!

Preliminary support for adaptive lighting is available in the beta release v1.3.0-1 next
The version should be mostly stable, but there can be some issues when you change the light brightness very quickly.
I'm in the process of rewriting the plugin to also support the Elgato Light Strips, but no harm in allowing you to play around with adaptive lighting :)

Preliminary support for adaptive lighting is available in the beta release v1.3.0-1 next
The version should be mostly stable, but there can be some issues when you change the light brightness very quickly.
I'm in the process of rewriting the plugin to also support the Elgato Light Strips, but no harm in allowing you to play around with adaptive lighting :)

Wow working great so far!! Amazing job!

I'm in the process of rewriting the plugin to also support the Elgato Light Strips, but no harm in allowing you to play around with adaptive lighting :)

@derjayjay
Is there any update on this? I have the light strips and I can't find a single plugin that can work with Homebirdge. I'm willing to help in writing this but I have no clue where to start (since you're talking about a rewrite).

I haven't had the time to finish working on it and since I recently moved my test setup is also not yet functional.
The Light Strips have a different API, so some work is still required.

I happen to have Light Strips and a homebridge instance running on my local NAS. I'll try to see if I can implement something and make a PR if possible. If you have any resources / guides it would greatly help me.

Awesome, much appreciated!
You could start by installing the Elgato Control App on your computer and capture the traffic (e.g. with WireShark) when you change settings, switch the light strip on and off, etc.
That's my main issue in supporting the light strips, since they support color, the API is a bit different.
You can send me a mail if you need any more guiding 🙂

I'm extremely grateful for your immediate responses. I'll try to be as helpful as possible.
So... not sure if this is the right place (maybe we should move it to an other issue) but these are some preliminary results from some captured traffic from the control app:
It seems like it polls the following while you have the app opened (tested from macOS):
HTTP GET elgato-light-strip-b6d7.local.:9123/elgato/lights
{
    "lights": [
        {
            "brightness": 30,
            "hue": 40.0,
            "on": 0,
            "saturation": 49.0,
            "temperature": 0
        }
    ],
    "numberOfLights": 1
}

HTTP GET elgato-light-strip-b6d7.local.:9123/elgato/lights/settings
{
    "colorChangeDurationMs": 150,
    "powerOnBehavior": 1,
    "powerOnBrightness": 40,
    "powerOnHue": 40.0,
    "powerOnSaturation": 15.0,
    "switchOffDurationMs": 400,
    "switchOnDurationMs": 150
}

HTTP GET elgato-light-strip-b6d7.local.:9123/elgato/accessory-info
{
    "displayName": "",
    "features": [
        "lights"
    ],
    "firmwareBuildNumber": 209,
    "firmwareVersion": "1.0.4",
    "hardwareBoardType": 70,
    "productName": "Elgato Light Strip",
    "serialNumber": "EW52J1A******"
}

Now, to the fun part, if we try to just turn it on/off it does a simple PUT request with the following payload:
HTTP PUT elgato-light-strip-b6d7.local.:9123/elgato/lights
{
    "lights": [
        { "hue": 40, "saturation": 49, "brightness": 30, "on": 1 }
     ],
    "numberOfLights": 1
}

It sends the exact same request where on is set to 0 when you try to turn it off from the app
I have mine set to just warm/cold light so I suppose the payload must be different if it's set to a colour. I'll update this with more findings as we move forward, but I don't want to pollute this thread with spam. If you'd like me to open a new investigation issue, let me know.
Off-topic: It's my first time trying to play with Homebridge from a developer's perspective so I'm not familiar yet with what it needs to implement something new. I'll take a deeper look at the source code of this plugin to understand a little bit more.

Thanks for the captures. Let's create a new issue for Light Strip support.
As a starting point, you can have a look at KeyLight.ts

I'm using Homebridge UI with Keylights 1.2.3, and it shows as up to date.  Sorry for the basic question, but how would I force an upgrade to the latest version with Adaptive lighting support?

@peternear You can do so easily via the web UI. Under plugins, find the keylight plugin. There should be a wrench symbol next to settings. There you have the option "Install previous version" where you can select the v1.3.0-1 with adaptive lighting support.
Please note that adaptive lighting is not perfect because the keylights do not support the full color temperature range required.

@peternear You can do so easily via the web UI. Under plugins, find the keylight plugin. There should be a wrench symbol next to settings. There you have the option "Install previous version" where you can select the v1.3.0-1 with adaptive lighting support.
Please note that adaptive lighting is not perfect because the keylights do not support the full color temperature range required.

/elgato/lights

Unfortunately I had no time to extend the current plugin to be compatible with Elgato Light Strips. For anyone interested in a workaround you can use: https://github.com/staromeste/homebridge-http-advanced-accessory to actually send HTTP payload to elgato light strips. A sample config for on/off controls:
{
    "accessory": "HttpAdvancedAccessory",
    "service": "Lightbulb",
    "name": "Office Lights",
    "forceRefreshDelay": 1,
    "debug": false,
    "urls": {
        "getOn": {
            "url": "http://YOUR_LOCAL_IP:9123/elgato/lights",
            "mappers": [
                {
                    "type": "jpath",
                    "parameters": {
                        "jpath": "$.lights[0].on",
                        "index": "0"
                    }
                },
                {
                    "type": "static",
                    "parameters": {
                        "mapping": {
                            "on": 1,
                            "standby": 0
                        }
                    }
                }
            ]
        },
        "setOn": {
            "httpMethod": "PUT",
            "body": "{ \"lights\": [{ \"on\": {value} }] }",
            "url": "http://YOUR_LOCAL_IP:9123/elgato/lights"
        }
    }
}

Thanks for your feedback :)
This is unfortunately an issue with the lights. They do not cover the whole light temperature range covered by adaptive lighting in HomeKit, so they will look wrong when compared to other lights - they are intended as studio lights after all.


Allow not having to set values for Helm release

I sometimes just want to deploy a helm release without having to set any values outside of the defaults, however flux doesn't allow me to do this.

As in, it requires a values: section in the HelmRelease manifest?

@squaremo  Yes.

A workaround is to use values: {}

I suppose we should alter the OpenAPI schema so values isn't required (and make sure the code doesn't balk if it's absent).


Implement counter control

Counter control is implemented in v1.2.0:
https://www.jplist.org/documentation/controls/counter


Add ATTC for Technical Education domain

Add Advanced Teacher's Training College for Technical Education domain name, located in Cameroon.

@cnoumbo Regrettably, the official school's website lacks important information. It prevents us from verifying the school's eligibility for this repository. Please see the screenshot attached below.
Please apply for free educational license with an official document which proves that you are a student. You can do it using "OFFICIAL DOCUMENT" tab at https://www.jetbrains.com/shop/eform/students.
I have to close the request without merging.
Thank you for your understanding!


Provide expected output in errors, where there is none

https://github.com/foundry-rs/starknet-foundry/pull/340#discussion_r1279273268

Perhaps we should also work on error messages? eg if wrong (non rpc) url id provided, the message is: Error: error decoding response body: expected value at line 1 column 1, it could be more descriptive


Make getQueriedIds more efficient

You can use key-value object like dictionary to make the performance better.
Instead of using set, put id on key so that you can get access speed of almost zero.

Rejected. Their performances are similar, and sometimes an object works worse.


Show Coup actions and characters

Show a summary of what all characters can do, and show on hover what the character can do

Some progress has been made on the issue-175 branch, where some more information about the Coup actions is sent to frontend. Using that approach it's very easy to add description for each action as well.
That could be utilized and used in the frontend which you have started on here.


Repo active

Is this repo still active? Wanting to use it in a RN project

@robcalcroft yes it is

Great 😄  thanks


Activity dispatching optimization

extend ScheduleActivityTask decision attributes with a requestStart flag to let client to start an activity upon RespondDecisionTaskCompleted response from server.

Coverage increased (+0.06%) to 68.904% when pulling 36b8345abebf3bda781fb9b1551442117959527a on mkolodezny:dispatch into 3fb129a431adb508996afee4375b90b111b622df on uber:master.

Any additional unit test you can add?

Looks good to me! I think it may worth to add an integration test for the e2e behavior so that it won't be break accidentally. I am not sure how much change is needed for the integration test framework though.

sure, thats scheduled as a follow up on client side.

Any additional unit test you can add?

added


python311Packages.gpiozero: disable failing test

Description of changes
Fix build (https://hydra.nixos.org/build/232332678)

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 250954 run on x86_64-linux 1

16 packages built:

home-assistant-component-tests.hassio
home-assistant-component-tests.homeassistant_hardware
home-assistant-component-tests.homeassistant_sky_connect
home-assistant-component-tests.homeassistant_yellow
home-assistant-component-tests.otbr
home-assistant-component-tests.zha
python310Packages.gpiozero
python310Packages.gpiozero.dist
python310Packages.gpiozero.doc
python310Packages.zigpy-zigate
python310Packages.zigpy-zigate.dist
python311Packages.gpiozero
python311Packages.gpiozero.dist
python311Packages.gpiozero.doc
python311Packages.zigpy-zigate
python311Packages.zigpy-zigate.dist


FontIcon custom styles are ignored if used inside a FlatButton

Problem description
Custom styles on a  are ignored when the icon is used as the icon of a
Steps to reproduce
Make a FontIcon
<FontIcon                 className={fa fa-user}                 color={Colors.white}                 style={{ fontSize: '1.4em' }}               />
Now try the FontIcon as part of a FlatButton
<FlatButton
        label={this.props.text}
        icon={<FontIcon
            className={`fa fa-${this.props.icon}`}
            color={Colors.white}
            style={{ fontSize: '1.4em' }}
          />}
      />

Versions

Material-UI: 0.15.1
React: 15.1.0

Running into this myself. Looks like https://github.com/callemall/material-ui/blob/master/src/FlatButton/FlatButton.js#L216 uses cloneElement, which shallowly merges the supplied style dict into the passed icon node. I'd think that should be flipped so user-supplied styles override the base styles.

Also if used inside a RaisedButton.   Perhaps all buttons should have a iconStyle prop?


feat: optionally allow attaching a waf policy to cdn

This PR exposes the webacl param on the cloudfront distribution allowing you to pass a waf acl in to do things like restrict traffic from certain ip's or perform application security scanning at the edge

bump

This is the PR I needed!

Thanks for the PR & sorry for the delay here.
Will try to get it merged by end of this week & release a new version from it 👍

This has been released in v0.11.0.


Update babylon.babylonFileLoader.ts

Optimizing loops. This prevents each loop has to recalculate the length of the array/objects

OOps, I made a small error on line 2. I cancel the PR and I remade into other


Installation instructions.

Trying to discover how to install please. Tried the powerscript script in the build directory but it fails with
Error: The plugin path doesn't exist: ..\src\streamdeck-commandline\bin\Debug\com.springhillsoftware.commandline.sdPlugin
Any assistance appreciated please.

You can find general installation instructions here.
Basically you'll want download the .streamDeckPlugin from the Releases page, then double-click that file to "launch" it in the Stream Deck app.

Thanks Mike…much appreciated and thanks for the plug-in. Cheers Alan

On 5 Jul 2022, at 10:32 pm, Mike Powell @.***> wrote:

You can find general installation instructions here.
Basically you'll want download the .streamDeckPlugin from the Releases page, then double-click that file to "launch" it in the Stream Deck app.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you authored the thread.

No problem, I'm glad it's helpful!


fix(DropdownItem): Added pointer cursor

Closes #2629

That issue looks good to me, even brings up issues I didn't realize at the time


New network request - EVMOS

Network information

Name: EVMOS(testnet & mainnet)

ChainId:
testnet: 9000
mainnet: 9001

RPC http/s address:
testnet: https://eth.bd.evmos.dev:8545
mainnet: https://evmos-evm.publicnode.com

Link to https://chainlist.org/
testnet: https://chainlist.org/chain/9000
mainnet: https://chainlist.org/chain/9001

Blockexplorer:
testnet: https://testnet.escan.live/
mainnet: https://escan.live/

Testnet RPC is not working for us

@Uxio0 which json rpc relay are you using?
The ones listed here or on chainlist.org should work.

@Uxio0 works for me?
curl https://eth.bd.evmos.dev:8545 \
  -X POST \
  -H "Content-Type: application/json" \
  --data '{"method":"eth_chainId","params":[],"id":1,"jsonrpc":"2.0"}'

response:
{"jsonrpc":"2.0","id":1,"result":"0x2328"}

Could you try our script? (you can set a random MNEMONIC). Sorry, I cannot debug every network

We changed the steps for getting the deployment, please:

[ ] I have run RPC='http://my-rpc-address' yarn estimate
[ ] I have sent requiredFunds to 0xE1CB04A0fA36DdD16a06ea828007E35e1a3cBC37

And then let us know

@Uxio0 this isn't a high priority for me, as there's already a non-canonical deployment on EVMOS i.e. https://safe.evmos.org/

Then I will close the issue so we don't spend time checking it again, if you need this in the future please open another issue


Add option to download youtube storyboard as jpg

Checklist

[X] I'm reporting a feature request
[X] I've verified that I'm running yt-dlp version 2021.12.01. (update instructions)
[X] I've searched the bugtracker for similar issues including closed ones. DO NOT post duplicates
[X] I've read the guidelines for opening an issue

Description
YouTube storyboard download feature is very useful but I need to download storyboard as jpg or png, I tried some online sites to convert  mhtml files to jpg and other formats but no luck with that.

You can use --keep-fragments as a workaround.
Ref: https://github.com/yt-dlp/yt-dlp/pull/343#pullrequestreview-674508539

You can use --keep-fragments as a workaround.
Ref: #343 (review)

thanks a lot for your help, I use this command "yt-dlp --keep-fragments -f sb0 Link"  and I got 5 files besides the mhtml file, I rename them and add .jpg at the end of the name, I hope we can download the storyboard as one jpg file soon.

I hope we can download the storyboard as one jpg file soon.

That is not possible/out of scope. Even if an option is added to download storyboards as jpeg, It will be downloaded as multiple files since that is how it is provided from the source

i wonder if there is some way to merge the 5 files to one file automatically.

ffmpeg should be able to do it

storyboards on youtube are very complicated and low quality, easier and better to generate it manually

ffmpeg should be able to do it

I searched now for that but I couldn't find how to download youtube storyboard with ffmpeg, can you tell me the command.

@BahzBeih
You can composite multiple image files into a single image file via the tile parameter:
$ ffmpeg -i img%03d.jpg -filter_complex tile=1x7 output.jpg
This command will take a collection of named .jpg files in the current working directory (img001, img002, img003 etc) and create a new image file, with the source images appearing in vertical sequence - in this case, we specify a total of 7 source images (1x7).
To get the same effect with a horizontal listing instead:
$ ffmpeg -i img%03d.jpg -filter_complex tile=7x1 output.jpg
This syntax is for Debian Linux, but should be very similar if you are running under Mac or Windows.
ffmpeg has a bunch of options available for fine-tuning pretty much every aspect of the output, so I highly recommend that you consult the online docs to get the effect you want:
https://ffmpeg.org/ffmpeg-filters.html#tile-1
Hope this helps!
Parmjit V.

I found a Firefox extension called "Youtube Storyboard" which downloads the storyboard as one image and has more control options like "number of rows.....etc", sadly I want to download the whole YouTube channel storyboards, not one video storyboard, so this will take so long time :(
I found that he is using these two sources to download the storyboard
https://www.labnol.org/internet/youtube-image-frames/24608/
https://github.com/darkoatanasovski/photojoiner
I don't know how to use this to download the whole YouTube channel storyboards, I got the script that was used by the extension but I don't know how to use it.

it's such an odd choice to pick mhtml as the format for the end result. it's not exactly trivial to unpack it, and it just adds unnecessary extra work to be done if one wants to do some kind of image operations with those storyboard files.
it is just not helpful, and the 'info' about individual storyboards that it prints in the mhtml file, ends up being more inaccessible trapped on that page, than if it were to be just appended to the individual storyboard's file name.
fragments themselves are just webp files. so, --keep-fragments works. but it would be nice if it could append a correct .webp extension to files (though it can be fixed later and still is much less work than unpacking mhtml files), or if there were an option to just, save the output as individual storyboard fragments, that'd just rename them/append correct file extension at the end (without creating an extraneous mhtml file).
what could be actually useful is gzipping files at the end, but idk whether having an ability to pack files would be possible or within the scope of this program.
as for 'stitching storyboard images together', defaulting to that could be somewhat troublesome as well - it might end up recompressing the images (which are already lossy and crunchy enough, so doing that wouldn't do them any more good), and it could end up producing cumbersome results for, say, very long videos, where a stitched image might end up being very long and kinda unmanageable/impractical to use. or, it might end up producing unexpected results with stitched output image format, either in terms of compression and size, or even just running into format limitations (webps are 16383x max on both sides, so it'd take only ~37 storyboards stacked together to run into that limitation).
a sensible default would be to keep fragments as they are, and just rename them to .webp (which they are), instead of packing them into a cumbersome file format (it's trivial to have other software do operations directly on image files - less so when having to deal with packed mhtmls).

it's such an odd choice to pick mhtml as the format for the end result.

The author of the code wanted it as a single file. I have no reason to block such a PR since we can add individual jpg downloads as a future feature. It's just that nobody has contributed such an implementation yet. Anyone is free to try and make a PR.
Core code can duplicate the storyboard formats, making a jpg/webp version of it available in format selection. Then a downloader has to be written that downloads the images in multiple files (do not merge/zip). Filenames could derive from the same outtmpl type as --split-chapters, or better, a new type can be created for this, defaulting to something like <normal outtmpl>.%(section_number).%(ext)s


No API is present

There is no API present for this project.

Minimal API present in release-v0.0.1.


Modify OpenAI Dashboard to display new endpoints

What does this PR do?
Modifies the OpenAI Overview dashboard to include prompt completion logging for the extra endpoints supported by the OpenAI V2 integration (ref).
Also modifies the template variable $model to use the tag name openai.request.model instead of openai.model as per the V2 integration's tag name change.
Motivation

The OpenAI V2 integration added tracing support for additional OpenAI endpoints, which means we should add prompt-completion log sampling for the audio/images/edits endpoints. Additionally, the V2 integration changed the tag name for the OpenAI model from openai.model to openai.request.model, which means the template variables, graphs, and metrics querying for model names should change correspondingly.
Additional Notes

Review checklist (to be filled by reviewers)

[ ] Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
[ ] PR title must be written as a CHANGELOG entry (see why)
[ ] Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
[ ] PR must have changelog/ and integration/ labels attached
[ ] If the PR doesn't need to be tested during QA, please add a qa/skip-qa label.

Hi @FlorentClarret and @buraizu, thank you for the timely reviews!
This can wait to be merged until next Monday, no rush on my end.

Hi @FlorentClarret, are we okay to merge this now? Thanks!

Yes 🙂


Conntrack work-around no longer works

In wrapkubeadm, the script passes --conntrack-max=0 and --conntrack-max-per-core=0 to kube-proxy in an attempt to tell it to skip trying to update the hashsize, when there is a large conntrack max configured on the host to avoid docker issue https://github.com/docker/docker/issues/24000.
Unfortunately, recent changes to kube-proxy have it read the CLI args, and then attempt to read from a config file. If there is a config file (there always is), the CLI args are ignored. As a result, with the reading of the config file, there are no conntrack settings so the default conntrack max-per-core value of 32768 is used. When on a system with 32 CPUs, the resulting conntrack value (1048576) can be more than four times larger than the hashsize (e.g. 262144), which causes kube-proxy to attempt to increase the hashsize and hits the docker issue.
DinD needs to be able to set both conntrack max and max-per-core to zero in the config file, which tells kube-proxy to ignore attempting to modify the hashsize in the condition where there is a large number of conntracks.

As a temporary work-around, one can change kube-proxy to force the default conntrack settings to zero, which will prevent kube-proxy from trying to update hashsize. The BUILD_HYPERKUBE and BUILD_KUBEADM flags can be set and the following patch applied to a local kubernetes repo:
--- a/cmd/kubeadm/app/apis/kubeadm/v1alpha1/defaults.go
+++ b/cmd/kubeadm/app/apis/kubeadm/v1alpha1/defaults.go
@@ -133,6 +133,14 @@ func SetDefaults_ProxyConfiguration(obj *MasterConfiguration) {
                obj.KubeProxy.Config.ClientConnection.KubeConfigFile = KubeproxyKubeConfigFileName
        }

+       if obj.KubeProxy.Config.Conntrack.Max == nil {
+           obj.KubeProxy.Config.Conntrack.Max = utilpointer.Int32Ptr(0)
+       }
+
+       if obj.KubeProxy.Config.Conntrack.MaxPerCore == nil {
+           obj.KubeProxy.Config.Conntrack.MaxPerCore = utilpointer.Int32Ptr(0)
+       }
+
        kubeproxyscheme.Scheme.Default(obj.KubeProxy.Config)
 }

Just to clarify on the docker issue. The current code, does a check to see if the filesystem is writeable, in an attempt to detect when there is a nested docker environment and to be able to avoid the docker issue. However, what is happening, is that the filesystem is reporting as writeable, but later, when the writing is attempted, it fails. So, the code in kube-proxy to address the docker issue, does not work.
There was an issue about the file system not allowing writing (https://github.com/kubernetes/kubernetes/issues/25543#issuecomment-282503251). There was no solution to that issue, so the work around is to set conntrack max and max-per-core to zero to avoid changing the hashsize. This could be done in a nested docker situation (like DinD), and was, via the CLI arguments, but that solution will no longer work.  Instead, the workaround must be employed via the config file, which is the request of this issue.


crouched defenders can soak up entire deployable turret magazines with 0 damage

Title

This is intentional and parity. Normal sentries only do a little damage with fortify, and minis do none.


Release 52

Coverage increased (+0.2%) to 16.806% when pulling<PHONE_NUMBER>ddc57b746ad67ef6899bf71d1c224c on current into 8d0c3c75edcfb1db7beed363dfcf3551315b35d6 on master.


yamlscript: 0.1.41 -> 0.1.45

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://github.com/yaml/yamlscript/releases.
meta.description for yamlscript is: Programming in YAML
meta.homepage for yamlscript is: https://github.com/yaml/yamlscript
Updates performed

Version update

To inspect upstream changes

Release on GitHub

Compare changes on GitHub

Impact
Checks done

built on NixOS
The tests defined in passthru.tests, if any, passed
found 0.1.42 with grep in /nix/store/n35yyc8wgkx53bnbqff28b56hmqbvajh-yamlscript-0.1.42
found 0.1.42 in filename of file in /nix/store/n35yyc8wgkx53bnbqff28b56hmqbvajh-yamlscript-0.1.42

Rebuild report (if merged into master) (click to expand)

1 total rebuild path(s)

1 package rebuild(s)

First fifty rebuilds by attrpath
yamlscript

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/n35yyc8wgkx53bnbqff28b56hmqbvajh-yamlscript-0.1.42 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A yamlscript https://github.com/r-ryantm/nixpkgs/archive/484ec7b9793dbd840a30e549c93d017977518e78.tar.gz

Or:
nix build github:r-ryantm/nixpkgs/484ec7b9793dbd840a30e549c93d017977518e78#yamlscript

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/n35yyc8wgkx53bnbqff28b56hmqbvajh-yamlscript-0.1.42
ls -la /nix/store/n35yyc8wgkx53bnbqff28b56hmqbvajh-yamlscript-0.1.42/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review --extra-nixpkgs-config '{ allowInsecurePredicate = x: true; }' run on x86_64-linux 1

1 package built:

yamlscript

Maintainer pings
cc @stigtsp for testing.

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://github.com/yaml/yamlscript/releases.
meta.description for yamlscript is: Programming in YAML
meta.homepage for yamlscript is: https://github.com/yaml/yamlscript
Updates performed

Version update

To inspect upstream changes

Release on GitHub

Compare changes on GitHub

Impact
Checks done

built on NixOS
The tests defined in passthru.tests, if any, passed
found 0.1.45 with grep in /nix/store/7l5fpy61xzm2k869jbjbcdhw0dxgsi83-yamlscript-0.1.45
found 0.1.45 in filename of file in /nix/store/7l5fpy61xzm2k869jbjbcdhw0dxgsi83-yamlscript-0.1.45

Rebuild report (if merged into master) (click to expand)

1 total rebuild path(s)

1 package rebuild(s)

First fifty rebuilds by attrpath
yamlscript

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/7l5fpy61xzm2k869jbjbcdhw0dxgsi83-yamlscript-0.1.45 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A yamlscript https://github.com/r-ryantm/nixpkgs/archive/92b5c524fbd0c0c156aeb6bad209641171cb01df.tar.gz

Or:
nix build github:r-ryantm/nixpkgs/92b5c524fbd0c0c156aeb6bad209641171cb01df#yamlscript

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/7l5fpy61xzm2k869jbjbcdhw0dxgsi83-yamlscript-0.1.45
ls -la /nix/store/7l5fpy61xzm2k869jbjbcdhw0dxgsi83-yamlscript-0.1.45/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review --extra-nixpkgs-config '{ allowInsecurePredicate = x: true; }' run on x86_64-linux 1

1 package built:

yamlscript

Maintainer pings
cc @stigtsp for testing.


Release info

Codecov Report

Merging #136 (ee1f890) into development (17f4174) will not change coverage.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##           development     #136   +/-   ##
============================================
  Coverage        82.76%   82.76%
============================================
  Files               89       89
  Lines             8518     8518
============================================
  Hits              7050     7050
  Misses            1468     1468

Impacted Files
Coverage Δ

neo3/__init__.py
86.51% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 17f4174...ee1f890. Read the comment docs.


Custom serialisation doesn't sanitise illegal unicode characters

Hi,
Thanks for the library.
Could you explain the motive for including a json_stringify method rather than just using the native JSON.stringify?
The custom method doesn't seem to sanitise illegal characters in strings properly. This can cause the terminal to error if a user inputs illegal characters as a command, which is then loaded from local storage the next time the page is loaded. The JSON.parse fails on the illegal characters and stops the terminal from initialising.
An easy way to test this is to open an image file in a text editor, copy and paste the contents into the terminal and execute the command, then refresh the page to see the terminal load the command history.
I made a quick fork of the library in which I just rely on JSON.stringify and the problem disappears.

I've created my own json stringify because I was using Biwascheme (one of the examples use it) that use protoytype.js that did something with arrays that that make invalid JSON, but in the meantime biwascheme replaced prototype with jQuery. I can change json_stringify with JSON.stringify but I will need to update biwacheme example.

replaced json_stringify with JSON.stringify in version 0.11.15

Thanks :)


Include sis_user_id in User table

Including sis_user_id in the user table would greatly help the joining process with tables in data warehouse.

verified that the SIS_ID is included in the USER table


fix: Remove Orphan file and Correct Linter issues - avm/res/sql/server

Description

Pipeline Reference

Pipeline

Type of Change

[ ] Update to CI Environment or utilities (Non-module affecting changes)
[X] Azure Verified Module updates:

[ ] Bugfix containing backwards-compatible bug fixes, and I have NOT bumped the MAJOR or MINOR version in version.json:

[ ] Someone has opened a bug report issue, and I have included "Closes #{bug_report_issue_number}" in the PR description.
[X] The bug was found by the module author, and no one has opened an issue to report it yet.

[ ] Feature update backwards compatible feature updates, and I have bumped the MINOR version in version.json.
[ ] Breaking changes and I have bumped the MAJOR version in version.json.
[ X] Update to documentation

Checklist

[ ] I'm sure there are no other open Pull Requests for the same update/change
[X] I have run Set-AVMModule locally to generate the supporting module files.
[ ] My corresponding pipelines / checks run clean and green without any errors or warnings

Abandoning pull request as this was completed in a different PR.


Request: labelled tuples

In Ruby, you can use a Hash to store labelled values of different types:
person = {
   name: "Fred Pillockson",
   age: 7,
   status: :dead
}
puts person[:name] + " is " + person[:status]

In Crystal, we must use a Tuple instead:
person = {"Fred Pillockson", 7, :dead}
puts person[0] + " is " + person[2]

This is barely readable, and makes it difficult to spot errors. So I tried to implement a macro to generate an anonymous class:
macro declare_anon_struct(name, fields)
	class %theclass
		attr_reader {{fields.keys}}
		def initialize
			{% for f in fields %}
				@{{f.key}} :: {{f.value}}
			{% end %}
		end
	end
        {{name.id}} = %theclass.new
end
declare_anon_struct person, {name: String, age: Int, status: Symbol}

But it simply cannot be done. For starters, it won't compile unless I add * before fields in the macro signature - I have no idea why. Secondly, and more importantly, it is not permitted to declare a class inside a def, so this macro simply cannot be used, period!
So what we need is language support for a labelled tuple:
person = Tuple.new(name: String, age: Int, status: Symbol)
puts person.name

We also need support for nested classes, IMO.

Hmm... Would struct help me here?

That's what I was thinking, something like this: https://carc.in/#/r/q80
Probably would want some nil? checks on the inputs for a "real-life" use case

We already have this, it's the record macro. But you must use it outside a def.

Unfortunately, I kinda need to use it inside a def. I also want it to be anonymous, like in my example.
Also, the record macro doesn't seem to have any support for type annotation.

I believe the new NamedTuples fulfill this usecase.


Add ssh providers to Airflow

This PR adds the SSH provider for Airflow to the image, along with a number of changes related to permissions management so that Airflow can reference and use the host's ssh config.

I am going to merge this and address the tests in a follow up so don't build tons of images to ghcr.io while I figure this out.


PHP 5.3 namespaces

PHP 5.3 has been out for years, 5.2 has been end-of-lifed over a year ago, 5.4 is around the corner. At some point the community has to move on.
It would be nice if solarium would move to PHP 5.3 namespaces. For the user it's just a matter of replacing underscores with namespaces.
Would be awesome if you would consider this for the 2.4 branch. I don't mind doing the work, but first I need to know if you will merge it.

Traits are a great addition to the language but, realistically speaking and the slow rate in the adoption of every major release of PHP being considered, I wouldn't wait to make some changes to the library unless you are targeting 3.0 for something like one year from now (at the very least). While I'm always +1 when it comes to see a library moving on, at the same time I think that pushing a new major version just for the sake of having namespaces and without any actual change or improvement in the feature set of the library is probably not worth it. Well in the end I think I've just contributed to instill more doubt :-)

You're right, it's too early to factor 5.4 features in, I was thinking more about the long term. So first of all, let's forget 5.4 to keep things simple.
I agree that just creating a new major version to introduce namespaces alone is not ideal, and it would also mean that the third mayor version would again be short lived as there are more changes upcoming. Therefore I've gone through some notes I had collected over time with (possible) future improvements. When some of these can be combined a new version makes sense. Without going into details here are some items:

namespaces
interfaces (issue #50)
reorganize files to create components, as Solarium continues to grow
replace the custom event handler with the Symfony event dispatcher
Plugins and standard Solarium components should be similar, both event based.

(this is not by any means a definitive list)
What I'd like to do is create a feature branch where we can start on namespacing and than work on some of the other items. The downside would be that this delays the namespacing somewhat.

Sounds good! Maybe even use a third party lib for doing http requests. Buzz maybe? https://github.com/kriswallsmith/Buzz

This may be worth a shot to convert to namespaces: http://blog.calevans.com/2010/03/27/zends-new-namespace-converter/. I haven't tried it yet. If you have time, I guess you can see if it works. Else I'll try it in the next few days and if it worked out make a PR.

This can be closed, right?

How about your comment on use statements in the PR? As far as I can see the use statements have already been added where needed?

Oh yes, that one. Well they aren't really needed, but it's a good practice to add them, because it makes the names everywhere shorter.
So yes, we should keep this open until we have use statements everywhere.

In addition to the 5.3 namespaces, it would be nice to have PSR-0 compatible autoloading.  There's some talk about exploring Solarium for integration with Drupal's Apache Solr module (http://drupal.org/node/1351752) but that won't proceed without these things.

Solarium is already PSR-0 compliant. It already was, even before namespaces were added.

That's right, PSR-0 shouldn't be an issue. Namespaces are however, and that will be the case until the next major version is released. It's being worked on but will take some time still....
BTW I've made some progress on this issue. During the restructuring done for issue #54 I've added a lot of use statements. For the library I've added them just about anywhere possible. Now they only need to be added to the unittests.

The unittests now also have use statements everywhere.


Drive to a designated spot or area with the help of Google GeoLocation API

User Story
As a driver of the Magess car, I want the car to drive automatically to a designated spot, so that I myself won't need to maneuver the car against obstacles.
Acceptance Criteria
The car's geolocation is accurately updated and depicted in the map of the car.

Not done because of time constraints

No need to close it, it can be left as a guideline for future developers


Update tellsens.yml

Needs to be updated so users are not confused of which value to be entered in web hooks form input fields.

Summary

Users gets confused
...
Changes

Changed default input field values

...
...

Notes for Reviewers

...
Checklist

[x] Scope: The referenced issue is addressed, there are no unrelated changes.
[x] Compatibility: The changes are backwards compatible, they don't break existing deployments.
[x] Testing: The changes are tested.
[x] Documentation: Relevant documentation is added or updated.

When adding our plugin from TTI's market place, the value of the input fields displays a default value of "clientId" and "secret". Please resolve this as these input fields should only contain inputs from the user.

There are no default values for the tellsens.yml template:

What default value are you seeing, and where ?

@tore-jan-s I also don't see any defaults. Can you please fix the clientid field?

@tore-jan-s any update here?


live server issue

First i open my html file.
click on live
opens 5500
but my html file is not there .Whenever i click on live it goes to same location . I dont know what to do.

Can you give me a screenshot of your Work space files?

I am not sure, is the .html in your workspace or not?

Are you new in vscode?

yes i am new in vscode.
I dont know what is workspace.

don't drag and drop the the index.html to your Vscode.
From vscode, File -> Open Folder -> select the folder where you've the index.html.
or,
From the file explorer, open CMD and type code .  (in the same location of the index.html)

thanks brother.
i love this

Is the issue solved?

yes

If you like the extension, please drop a review to vscode marketplace.

m


SQL syntaxic coloration error

As you can see when my file get bigger, I have some coloration errors.

On version

Solve by updating...


Excessive disk usage after dbsync

Disk usage after db-sync is quite excessive. Even with aggressive pruning, the chain consumes close to 3-4GB per hour, almost all going to application.db

The recommended mitigation for disk filling up issue after db sync is to use aggressive pruning + force compaction:
If you are on 2.0.47beta or later version, set the following configs in app.toml:
sed -i.bak -e 's/pruning = ./pruning = "custom"/' /root/.sei/config/app.toml
sed -i.bak -e 's/pruning-keep-recent = ./pruning-keep-recent = "1"/' /root/.sei/config/app.toml
sed -i.bak -e 's/pruning-keep-every = ./pruning-keep-every = "0"/' /root/.sei/config/app.toml
sed -i.bak -e 's/pruning-interval = ./pruning-interval = "1"/' /root/.sei/config/app.toml
sed -i.bak -e 's/compaction-interval = .*/compaction-interval = "60"/' /root/.sei/config/app.toml


Remote Capture Tool Download Link

Hi,
I am planning to run the tests for Miscorsoft Teams Skype certification testing. Remote capture tools shall be installed and used inorder to run most of the tests as Microsoft Team video capture specification (Microsoft_Teams_VideoSpecification_4_Final.pdf). I have referred below page and downloaded and installed Video TMT 2.3 and Skype Certification Video analyzer tools but I couldn't find any link to download Remote capture tool.
https://docs.microsoft.com/en-us/skypeforbusiness/certification/test-spec
Can you please point where to download the remote capture tool?
Regards
Suresh

Hi,
I could find Remote Control Package in %ProgramFiles(x86)%\Microsoft Corp\Video TMT\Remote Capture Tool\ location and I am getting below error when I tried to install it using powershell. Can you please help me to install this tool?
Found bundle: C:\Program Files (x86)\Microsoft Corp\Video TMT\Remote Capture Tool\RemoteCaptureTool\RemoteCaptureTool\RemoteCaptureTool.Windows_<IP_ADDRESS>_Test\RemoteCaptureTool.Windows_<IP_ADDRESS>_x86_x64_arm.appxbundle
Found certificate: C:\Program Files (x86)\Microsoft Corp\Video TMT\Remote Capture Tool\RemoteCaptureTool\RemoteCaptureTool\RemoteCaptureTool.Windows_<IP_ADDRESS>_Test\RemoteCaptureTool.Windows_<IP_ADDRESS>_x86_x64_arm.cer
Error: The developer certificate "C:\Program Files (x86)\Microsoft Corp\Video TMT\Remote Capture Tool\RemoteCaptureTool\RemoteCaptureTool\RemoteCaptureTool.Windows_<IP_ADDRESS>_Test\RemoteCaptureTool.Windows_<IP_ADDRESS>_x86_x64_arm.cer" has expired. One possible cause is the system clock isn't set to the correct date and time. If the system settings are correct, contact the app owner to re-create a package or bundle with a valid certificate.
Regards
Suresh

@dsureshmadhu Thank you for submitting feedback and contributing to the docs. We are currently investigating this.

@dsureshmadhu thank you for submitting feedback.
I think the best way forward is if you open a service ticket in your tenant so this can get resolved ASAP. Based on the outcome let me know if it is something that can be called out in the docs.
Please follow this link to contact support for business products:https://docs.microsoft.com/office365/admin/contact-support-for-business-products
Please keep us posted here on the resolution so we can feed whatever information you discover into the content.


Firebase Admin SDK breaks with some service account keys

Describe the bug
Apparently the Firebase SDK used by serverpod_auth_firebase_flutter has an issue where some service account keys cannot be read. This bug https://github.com/appsup-dart/firebase_admin/issues/7 and this here https://github.com/appsup-dart/firebase_admin/issues/21 probably describe what is going on.
Finding this solutions was difficult, because it was not clear where the issue was coming from (in this case the admin SDK) - maybe there needs to be a way to prefix log output of dependencies to properly trace issues. This might be possible with Zones.
For me generating the key 3 times did the trick because I came across these issues when diving into the dependencies of the auth package.
To Reproduce
Follow the steps in https://docs.serverpod.dev/concepts/authentication/providers/firebase and create a service account key firebase_service_account_key.json -  since this is a flaky bug, you might need to generate a couple of files until you encounter the issue :)
Expected behavior
An error message which tells me that my keyfile could not be read (or an error message which suggests that this could be the case).
Screenshots

Serverpod versions

CLI Version: 1.2.5
Library version: 1.2.5

Platform information
Macos arm64
Additional context
An alternative implementation for the firebase admin sdk could be the implementation by Invertase https://github.com/invertase/dart_firebase_admin

Thanks for the report @dkbast!
If I understand the issue correctly, we can't really fix the issue from our side. But what we can do is to improve our documentation so that users are aware of this issue.
Does that sound like an acceptable action based on the bug report?

Yes - I think mentioning it in the tutorial should be enough, maybe add a reminder in the future to reinvestigate this once either of the firebase SDKs leaves alpha?

We no longer depend on the firebase_admin package. We never got around to updating the documentation but my question is if this could be closed now instead?

If you no longer depend upon the this package this can probably be closed, as it was mostly an upstream issue :)


Hovering over sidecar expand button does not show tooltip message

Screenshot, minimize, and close buttons in sidecar all display a tooltip message.  For some reason the expand button does not show a message, the design behavior is not consistent.

thanks for the bug report. the issue here is a conflict with the carbon-components css. we have the tooltip classes on an , which carbon-components dresses up in a way that conflicts with the balloons.
c.f. https://github.com/IBM/kui/issues/1444


Add enable route functionality.

Description
This change introduces the option for the CR submitter to enable/disable routes for the Apiserver. When the route is enabled, an oauth proxy container is added to the api server and a k8s route is created.
To ensure that all external traffic goes through the route, and all pod-to-pod communications to apiserver go through port 8888 (default), we use a k8s network policy to enforce this behavior.
By allowing pods to communicate to apiserver via port 8888, we can continue provisioning mlpipelines-ui alongside this feature, otherwise the ui would also need to go through oauth proxy.
If the CR submitter switches enableRoute from 'true' to 'false' then the operator will clean up the existing route on the cluster.
How Has This Been Tested?
Locally and on OCP OSD with: quay.io/hukhan/data-science-pipelines-operator:pull-33
Run unit tests on this pr by cloning the branch and following instructions here.
Deploy on dev cluster with ocp pipelines (logged in as cluster admin):
oc new-project data-science-pipelines-operator
make podman-build podman-push IMG=$YOUR_CONTAINER_REPO
make deploy IMG=$YOUR_CONTAINER_REPO

Deploy a sample cr with the updated resource kind:
apiVersion: datasciencepipelinesapplications.opendatahub.io/v1alpha1
kind: DataSciencePipelinesApplication
metadata:
  name: sample
  namespace: data-science-project
spec: {}

By default the field enableRoute will be set to true.
Login to the UI,  confirm you can login w/o issues, upload/start a run.
Navigate to the Routes page and fetch the apiserver route, or run:
# assuming namespace: data-science-project, and cr name: sample
ROUTE=`https://$(oc get routes -n data-science-project ds-pipeline-sample --template={{.spec.host}})`

Curl this route and see if you can by pass the oauth proxy and fetch runs:
curl --insecure --location --request GET "${ROUTE}/apis/v1beta1/runs"  --header "Authorization: Bearer $(oc whoami --show-token)"

Further testing can include confirming the network policy works. Try curling the service for the api server from another pod that is not deployed by dspo:
This should fail:
$ oc -n openshift-monitoring rsh alertmanager-main-0
$ curl --location --request GET http://ds-pipeline-sample.data-science-project.svc.cluster.local:8888/apis/v1beta1/runs

The above command will succeed if you try it from a dspo component pod, for example the associated persistenceagent pod.
This should succeed:
# YOUR_TOKEN == $(oc whoami --show-token)
curl --location --request GET https://ds-pipeline-sample.data-science-project.cluster.local:8443/apis/v1beta1/runs --header 'Authorization: Bearer ${YOUR_TOKEN}' --insecure

This also resolves: https://github.com/opendatahub-io/data-science-pipelines-operator/issues/9
Merge criteria:

[x] The commits are squashed in a cohesive manner and have meaningful messages.
[x] Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
[x] The developer has manually tested the changes and verified that the changes work

/hold
from @rimolive: we should also test using pipeline sdk and confirm nertwork policy doesn't interfere with pipeline creation via api server when we try to use the sdk against oauth proxy.

/unhold
Please see the following gif of the sdk being used against the oauth proxy:

/unhold
Please see the following gif of the sdk being used against the oauth proxy + networkpolicy in this pr:

In this example testuser is given this role:
kind: Role
apiVersion: rbac.authorization.k8s.io/v1
metadata:
  name: example
rules:
  - verbs:
      - get
    apiGroups:
      - route.openshift.io
    resources:
      - routes

Ok, that's enough for DSP users.

/lgtm

/approve

/hold

/unhold
/lgtm
/approve


Correct import ordering

Closes #13

Coverage remained the same at 100.0% when pulling 297d2801aea77f1f69b98038d843065e2a754810 on AlwxSin:correct_import_ordering into 40a35684de1158aa2837ee682723a38d075e3672 on sobolevn:master.


Changes required to make release the default branch

Some minor changes in the Readme.md in order to make release the default branch of the repo.
cc @tjvantoll

@vakrilov Looks good 👍
When you’re ready to turn this on we should set release as the default branch in GitHub as well.


TextResult.SOAPLine.SOAPLineCode mapping

The SOAPLineCode (NL-CM:13.6.5) concept allows communicating a code for an S or E SOAPLine.
The SOAPLine is mapped to an Observation with the SOAPLineHeader on Observation.code and the SOAPLineText on Observation.valueString.
It is not completely clear how we could best map SOAPLineCode. There are at least the following three options:

In STU3 this has been modelled in a Observation.component. We do not have a proper code for the Observation.component.code (https://bits.nictiz.nl/browse/ZIB-1448) that clearly identifies the component.
Use an extension that defines the SOAPLineCode. This can be added to the root of the Observation, or more specifically, to Observation.valueString, as this code actually states something about the value of the Observation.
We could use Observation.valueCodeableConcept for both concepts: Observation.valueCodeableConcept.text for SOAPLineText and Observation.valueCodeableConcept.coding` for SOAPLineCode. This omits the use of another extension. It does however feels a bit odd. Normally you use a CodeableConcept for coded elements where you can use an unstructured free text to describe the concept. In this scenario, we would then firstly use the unstructured text option that may have a code that represents the most important part of the text.

Ping @ahenket  :)

@LuudSlagter , @niekvangalen , aangezien jullie bezig zijn met SOEPVerslag ...


Can't build faiss index

Thanks for the great repo!  I'm trying to build a faiss index for retrieval, but can't get the script to run.  I was originally using python3.8 and torch 1.8 in a docker container, but also downgraded to torch 1.6 to see if that would work.
I'm running
CUDA_VISIBLE_DEVICES="0,1" OMP_NUM_THREADS=1 \
python3.8 -m torch.distributed.launch --nproc_per_node=1 -m \
        index --root $PWD/experiments/ --amp --doc_maxlen 180 --mask-punctuation --bsize 256 \
        --checkpoint out-of-the-box-model.pt \
        --collection passages.tsv \
        --index_root /faiss --index_name INDEX \
        --root $PWD/experiments/ --experiment out_of_the_box \
        --local_rank 0

But I get the error "Default process group is not initialized".  That also happens even if I manually put dist.init_process_group('nccl') in the script.
Do you know why this is happening?
Thanks!

Looks resolved?
Closing but feel free to reopen if I can help with other issues!