AWS Migration & Related Tasks

[ ] Create a LinkedIn Account for the MyDailyReminder, with a post on it: "Stay tuned" or along those lines, ask friends to subscribe so we can use it in the AWS Activate credits form.
[ ] Create an account on Gmail, AWS
[ ] Buy a Domain from GoDaddy
[ ] Create an Org on GitHub (Vercel does not allow connecting to an Organization, so you have to pay at that point). To avoid downtime and maneuver around that --> we deploy the frontend on Achraf's AWS account. Meanwhile, we move the repo to the org we are allowed to
[ ] Migrate GitHub resources to AWS ( Amplify), with the necessary tweaks (changing the APIs + remove the 15 min things in the frontend)
[ ] Create RDS PostgreSQL cluster and then create 2 dbs (Quraan and Hadeeth) with their associated stuff. you can use psycopg or sqlite3 (just like work), allow traffic from everywhere.
[ ] Add related env variables for the backend _(as before + FRONT_END_BASE_URL(PROD/DEV)) and the frontend (BACKEND_BASE_URL_PROD/DEV, dont forget to add end var for that in the frontend dir)
[ ] use the AWS emailing service rather than what we have (I think SNS)
[ ] Submit the domain to the console search with the proper headers (need to be updated under public/index.html)
[ ] Properly setting up how the website will direct to the three things we have (landing page, main my-daily-reminder with the three products we have iA)
[ ] The first app to migrate is MyDailyVerse.
[ ] Reach out again to Achraf to finalize everything.

iA I will be taking care of this ticket fully, may Allah swt aid and accept us

Waiting on the acceptance of the fund request by AWS, Ya Rabbb. Meanwhile, I will reach out to Achraf to double-check regarding the domain name and the organization, moving it, and aws deployment


Make 'None' size-independent, Add discussion call to end message

Just minor things.

Thanks for contributing back all these improvements @LZaw !


This issues page is pretty ridiculous

First, I added an issue five days ago and so far as I can tell nobody has even read the question.
I think I know why and that leads to this "issue" post.
Have you looked at the instructions for reporting an issue? Would even one person in a thousand understand what was being requested as feedback?   For example, read the issue "template" instructions below.......
Platform: output of uname -a (UNIX), or version and 32 or 64-bit (Windows)
Mercury-Parser Version: the specified version in your package.json file
Node Version: output of node --version
Seriously? If I understand any of that I would probably be technically competent enough to write my own version of Reader.
And that is just the tip of the iceberg of technical jargon that is being requested when you report an issue.
......... Give me a break! ..........
Here is what I would like to do. I have run across a webpage that I would like to "Readerize" if you will, and send to Kindle for later reference. This particular webpage is 100% unaffected by Mercury Reader. Absolutely NOTHING changes on the page when I use the Reader extension. I mean NOTHING! I would think postlight would be interested in examining the page and determine why their' program fails utterly in that instance. How else are you supposed to make your product viable if you don't allow any means for users to easily and clearly report instances where it fails?
Really..... this "issues: form is just insane.
The end!
Thanks for reporting an issue!
This issue tracker is for bugs and issues found within Mercury Parser.
Please fill in as much of the template below as you're able.
Platform: output of uname -a (UNIX), or version and 32 or 64-bit (Windows)
Mercury-Parser Version: the specified version in your package.json file
Node Version: output of node --version
If possible, please provide a stack trace and/or code that demonstrates the
problem, keeping it as simple and free of external dependencies as you are able.
-->

Platform:
Mercury Parser Version:
Node Version (if a Node bug):
Browser Version (if a browser bug):

Expected Behavior

Current Behavior

Steps to Reproduce

Detailed Description

Possible Solution

Thanks for your feedback. Please feel free to open a new issue with details on the page you've encountered that is not being affected by Reader.
You're welcome to leave some or all of the issues template blank if the information it requests is not accessible to you or relevant to your issue. We provide that template as a convenience for submitters and maintainers alike, to ensure that we're collecting as much context as possible to aid in resolving issues efficiently.


No way to set desired openssl package version

May I suggest adding an $ensure paramter similar to:
class openssl (
  $package_ensure => present,
){
}

class openssl::packages {
  package { 'openssl':
    ensure => $openssl::package_ensure,
  }
}

If no one has any objection, I will make the change and submit a pull request.
Any thoughts?

I'm good with that, go ahead and attach code.


enable .eslintignore again

This line of code has been added by this PR.
But I cannot understand why react-script doesn't support the essential config file of eslint.
I'd say that it should be needed for some cases such as ignoring generated files or something like that.
This topic about .eslintignore has been discussed as follows

https://github.com/facebook/create-react-app/issues/2339
https://github.com/facebook/create-react-app/issues/7339

I signed up just now!

Maybe only enable it when EXTEND_ESLINT=true?

@mrmckeb any concerns with this one having done the eslint config work?

Maybe only enable it when EXTEND_ESLINT=true?

That could be a good idea. I guess the question is should we support this file even if the user isn't modifying our OOTB lint config?

I think it would be more consistent to only respect the ESLint ignore if EXTEND_ESLINT=true, since without this variable an ESLint config is ignored, and ESLint ignores often accompany ESLint configs.

@igtm We think we can get this into our 3.2 release, but it needs to be behind the flag EXTEND_ESLINT=true for now.
Can you make that change?

I'm sorry for the late reply.
I changed the code so that it can be enabled only when EXTEND_ESLINT is true


angular-router RC1

when you release angular-router RC1 right now the router is still in beta.2...

Can you elaborate your issue with angular-cli? Route generation is disabled right now

i cant use the new Routing and navigation from angular.io documentation
import { Routes, RouterModule }   from '@angular/router';
can't import Routes and Routermodule

i solve the issue by reinstalling angular-cli into angular-cli@webpack thankyou :)


Investigate how fast can we get all the e2e tests to run

Describe the solution you'd like
At the moment, running all the e2e tests takes 30ish mins. Can we investigate what is the bottleneck, and if it is possible to speed this up?

This is where all our e2e tests live - https://github.com/vmware-tanzu/cluster-api-provider-bringyourownhost/tree/main/test/e2e
This issue involves doing some research on what steps in the tests are consuming a lot of time and if there are ways to mitigate this.

Good to start with the quickstart tests - https://github.com/vmware-tanzu/cluster-api-provider-bringyourownhost/blob/main/test/e2e/e2e_test.go

[ ] identify how much time each step takes (test setup, creating management cluster, docker hosts, apply cluster template, log collection, teardown)
[ ] identify possible improvements
[ ] the team can then review what improvements can be done in a reasonable time
[ ] implement!

This would be an interesting investigation! 😄

Personally I have seen more speed when using more CPU and RAM - this is based on experience from TCE when running E2E tests for Docker clusters (CAPD). For other clusters like AWS, Azure, VMC(vSphere), the speed was dependent on the kind of machines we were spinning up on AWS, Azure, VMC, and required only little resources (CPU and RAM) from the host machine running the tanzu CLI where the kind bootstrap cluster had to be run on top of Docker
Also, one tricky thing is, usually Docker runtime has all resources of the host machine but it need not be the case. So that's something to check out too. In dev machines, many devs would allocated only a part of their host resources to Docker runtime. In CI/CD environments with container support, like GitHub Actions, the VMs provide full resources to the Docker runtime usually but it's worthwhile to confirm it during investigation than assuming

It takes time to building host agent separately for every container. If we move it to suit-test.go to run it only once for entire e2e. It can save some time. My test is as followed:
Before do this:

e2e_test: time elapse: 4m38.405165171s
md_scale_test: time elapse: 11m2.787283875s
byohost_reuse_test: time elapse: 7m14.318728577s

After do this:

e2e_test: time elapse: 5m27.469585284s
md_scale_test: time elapse: 7m26.022867913s
byohost_reuse_test: time elapse: 6m51.386107789s

It can save more time for md_scale_test.

More improvement is on the way...


Extension issue

Issue Type: Bug
Extension Name: gitblame
Extension Version: 2.6.3
OS Version: Linux x64 5.0.2-050002-generic
VSCode version: 1.32.3

:warning: We have written the needed data into your clipboard. Please paste! :warning:
{
	"activationTimes": {
		"startup": false,
		"codeLoadingTime": 35,
		"activateCallTime": 0,
		"activateResolvedTime": 0,
		"activationEvent": "onDebugResolve:chrome"
	}
}

Hello Tolu.
I am unsure what is being reported here. What did you try to do and what happened?

I'll close this now. If it's ever a problem again please get back to me.


Initial enso changes to ScatterPlot

This makes the enso changes for

if the left most column is numeric it's set as the x axis
sends all y values if multiple numeric columns for multi series plots

Important Notes

Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:

[ ] The documentation has been updated, if necessary.
[ ] Screenshots/screencasts have been attached, if there are any visual changes. For interactive or animated visual changes, a screencast is preferred.
[ ] All code follows the
Scala,
Java,
TypeScript,
and
Rust
style guides. In case you are using a language not listed above, follow the Rust style guide.
[ ] Unit tests have been written where possible.

Could we get a screenshot showing how this works in the GUI? It is very useful when reviewing such changes that have mostly visual impact.

Thanks for addressing the comments, it looks really good 🙂
I think it would be good to add some new tests to Scatter_Plot_Spec to see this Y_multi in action and avoid accidental regressions. And definitely a screenshot of it working in the GUI would be appreciated.


A better default save directory than ~ on OSX?

By default, MBS wants to save project files in my home directory. This feels a bit weird and wrong.
Perhaps it could default to "~/Mapbox Studio/" or at least ~/Documents or something?

I am fine with ~/ - And this would be slightly complicated to implement/test, so closing.


markdown badge in README document doesn't seem to work

On development branch (the default one) the badges on the README document doesn't seem to work.

yeah, when we have our testrunner machines back


Possible memory leak

I'm running some analysis on my business' application and came through this data from xCodes Instrument on Memory Leak analyzer mode:

It seems like there's a memory leak with mmkv's get function:

Xcode's Instrment's Profile data:  https://drive.google.com/file/d/10TX6kSu9b8Y8jtHkaeLHrFDQeY9ufYWt/view?usp=sharing
Currently using<EMAIL_ADDRESS>and<EMAIL_ADDRESS>

Oh that's interesting! Could you profile if this happens on Android too?

i got same results on IOS, is it possible to introduce a something like "release memory" function example in FastImage we use FastImage.clearMemoryCache() after the component unmount to clear the image from memory and use the disk cache

Yea I think this is a leak, and adding a clear function is a bit hacky. I'll need to find the root cause for this, but if this is in MMKV's codebase then maybe we should create an issue there?

Possibly related? https://github.com/mrousavy/react-native-mmkv/issues/440

@mrousavy Hi, any updates about this? We are ready to migrate to mmkv but we are worried about this 😿

Hey! Sorry I cannot reproduce the issue here and it has been inactive for a while.
I am going over issues right now and want to keep the repo clean - so I'm closing this for now, if anyone can post a reproduceable example here I can re-open and take a look :)


feat: Asset link

Describe the feature you'd like to request
Add link to brand assets
Describe the solution you'd like to see
Add link to brand assets
Additional information
No response

https://drive.google.com/drive/folders/17vrwIjwqifxBVTkHmxoK1VhQ31hVSbDH


fix:change sql types and multi tables

What this PR does:
Which issue(s) this PR fixes:

Fixes #345
Special notes for your reviewer:
Does this PR introduce a user-facing change?:

Codecov Report

Merging #348 (a0c2c5d) into master (0b39d86) will not change coverage.
The diff coverage is 0.00%.

@@           Coverage Diff           @@
##           master     #348   +/-   ##
=======================================
  Coverage   39.75%   39.75%
=======================================
  Files         108      108
  Lines       14320    14320
=======================================
  Hits         5693     5693
  Misses       7924     7924
  Partials      703      703

Impacted Files
Coverage Δ

pkg/runtime/ast/proto.go
57.14% <ø> (ø)

pkg/runtime/ast/show.go
26.17% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


Foolproof booleans

Hi,
Could you be interested in a pull request adding a new type of transform called :strict_boolean or :flag where it would act like :boolean but raise if the value is anything but "true", "false", "0" or "1".
This would allow us not to write this:
stuff_enabled? = env!("MY_VAR", :string!, "false") == "true"

Because as it is now, the boolean type is very permissive and people might put stuff like yes/no, on/off, or make mistakes like "flase".

anything not in ~w(0 1 false true) would raise with :flag! and :flag, except...
... that an empty string would be considered false with :flag
and an empty string would be nil with :flag? as it is that suffix purpose.

Hmm... I'd have to think about that because one person's idea of "strict" may not match someone else's.
As a workaround that would be visually explicit and upgrade-safe, you could define your own function and apply it, e.g.
# runtime.exs
import Config
import Dotenvy

strict_boolean! = fn
  "true" ->
    true

  "1" ->
    true

  "false" ->
    false

  "0" ->
    false

  _ ->
    raise("Variable not strict boolean")
end

config :myapp, :some_bool, env!("SOME_BOOL", strict_boolean!)

one person's idea of "strict" may not match someone else's

Yes. The :flag name seems better to me because you know that you cannot just assume what it is and have to look it up.
A function could be nice indeed, but it should receive the var name as a second argument to raise a proper error message.
It could be done easily without adding the variable name to all to! clauses with something like that:
def env!(variable, type) when is_function(type, 2) do
    env!(variable, fn value -> type.(value, variable) end)
end

Since the detailed error reporting about which variable failed is handled via the rescue blocks in env!/2 and env!/3, you could almost do something like this:
strict_boolean! = fn
  "true" ->
    true

  "1" ->
    true

  "false" ->
    false

  "0" ->
    false

  _ ->
    raise Dotenvy.Transformer.Error, message: "Values must be one of 0,1,true, or false"
end

But the current code fails when it tries to print out the function reference:
** (Protocol.UndefinedError) protocol String.Chars not implemented for #Function<42.3316493/1
I think I should fix the above for sure -- and maybe rename the exception to simply Dotenvy.Error for simplicity. That would help keep the core flexible for any other custom modifications (regardless of whether :flag or :strict_boolean are explicitly supported).
I tried a quick hack by changing the rescue block to something like:
  rescue
    error in Error ->
      if is_function(type) do
        reraise "Error converting variable #{variable} using custom function: #{error.message}", __STACKTRACE__
      else
        reraise "Error converting variable #{variable} to #{type}: #{error.message}", __STACKTRACE__
      end

and that causes the error message to be reported like this:
** (RuntimeError) Error converting variable SOME_BOOL using custom function: Values must be one of 0,1,true, or false

Which is decent I think.
I have to think a bit about opening up the arity of the callback function -- it feels possibly smelly to open up an additional argument just to pass it down to the logs. 🤔  This is why Logger.metadata/1 is so brilliant, for example: you can add extra info without disrupting any existing calls.
I think I would prefer to add an attribute to the exception struct -- maybe :type or :name and then add that to the error message, e.g.
reraise "Error converting variable #{variable} using custom function of type #{error.type}:  #{error.message}", __STACKTRACE__

and then your custom function could set the value when the error was raised:
raise Dotenvy.Transformer.Error,
      message: "Values must be one of 0,1,true, or false",
      type: "strict_boolean"

I think that fundamentally accomplishes the visibility (which I agree is important).  What do you think?

Take a look at PR #17 -- it's the candidate for v0.8.0.

Sorry for the delay!
This seems a nice solution.
Thank you :)

Great!  I'll close this but I'm open to adding something to the core later if the custom-function option is too much friction.
Here's the ref for PHP .ini files:
; Boolean values can be set to either:
;    true, on, yes
; or false, off, no, none
register_globals = off
track_errors = yes

It looks like YAML has gone back and forth on this (?): https://yaml.org/spec/1.2.2/


Adjusting the output format of a model (mask2former)

I am currently about 90% of the way there in converting mask2former into torchscript.  The issue I am running into is how to adjust the output of the model as it outputs a list of numpy arrays that are of course incompatible with torchscript.  I so far have been unable to find the code relating to the model output in the mm detection code base.  My assumption is that since it is a pytorch model, it must be outputting a tensor and the conversion into numpy arrays is happening after the fact during a post-processing step.  If someone could point me to the spot where that it is happening it would be greatly appreciated!

The forward and post-process code is both in the simple_test of maskformer detector. https://github.com/open-mmlab/mmdetection/blob/master/mmdet/models/detectors/maskformer.py#L111. You can use the outputs of mask2former_head forward which is without postprocess.

@avickars  @jbwang1997  Hello, have you successfully trained mask2former? Have you encountered any of the following errors: ValueError: matrix contains invalid numeric entries? For details, see #8155


mbed-edge-core: add platform version file

This adds two LwM2M Resources intended for reporting platform versions.
The contents of each resource is read from a corresponding file on disk,
and it's up to the user to decide what values to write to the file.
It is intended for one file to contain a "friendly" or "readable" version
string, perhaps something that follows semantic versioning, and for the
other file to contain a hash over some data, such as the md5 hash of
a list of all installed packages.
Platform Version friendly version:
file: /var/lib/pelion/readable_version
lwm2m: /10252/0/10
Platform Version MD5 hash:
file: /var/lib/pelion/platform_version
lwm2m: /10252/0/11

Follow up PR:
https://github.com/PelionIoT/distro-pelion-edge/pull/133

Here's the CI failure:
/usr/bin/ld: ../lib/mbed-cloud-client/mbed-client-pal/Source/libpalRTOS.a(pal_rtos.c.o): in function pal_osReboot':
pal_rtos.c:(.text+0x7f): undefined reference to `pal_plat_osApplicationReboot'
collect2: error: ld returned 1 exit status
`


devServer API improvements

HMR requires improvement:

Request a partial reload
Request flushing on demand (removing modules from cache) using a pattern

#115

Request flushing on demand (removing modules from cache) using a pattern

Think https://github.com/fuse-box/fuse-box/pull/158 will solve it :rose:


Add identities GC test based on control-plane framework

This PR leverages the control-plane test framework to add a new unit test equivalent to the test/k8s/identities.go Ginkgo test.
The test will verify that, after the amount of time specified in the operator config, the "dummy identity" will be garbage collected.
The operator code has been modified to run in memory and to be able to be reset and restarted again in the same test binary. This way, the framework is able to support future operator-related test cases without any further change.

/test


unique completion should not open completions list

From<EMAIL_ADDRESS>on 2010-09-15T08:01:30Z
What steps will reproduce the problem?

at console enter 'imp' and hit [TAB] What is the expected output? What do you see instead? I expect my input to complete to 'import'. Instead the list of completions is shown with 'import' being the only option, so that I have to hit [enter] or [tab] again to get the expected result.

This happens in spyder 2.0.0beta3
Original issue: http://code.google.com/p/spyderlib/issues/detail?id=361

From pierre.raybaut on 2010-09-25T02:02:17Z
Status: Fixed

From pierre.raybaut on 2011-04-24T07:36:03Z
This issue was closed by revision 9028de74be50 .


Launching a new instance from an existing instance

This idea is from another friend of mine, inspired by the open new window feature of web browsers. I think a new command in command palette is more suitable than something in the menu. I don't know any text editors have menu -> open new window like web browsers.

Also already existing feature: Settings -> New Window in command pallete is called Create New Window (command: create-new-window).

You can also open a document in a new window by right clicking a document tab and Open in New Window...


Validate cyclic rule definitions

Closes issue/198.
Proposes left recursion validation.

I've considered the algorithm, proposed by @msujew, and took a decision postpone its implementation. The main reason is that currently there is no concrete application domain of this algorithm. How I understand we need to validate cyclic definitions to don't catch stack overflow in a process of grammar handling. However, the only one stack overflow which I've met for now was fixed by refactoring here.
Actually, it doesn't mean we can drop validation of cyclic definitions or left recursion (it can be useful to prevent Chevrotain's errors), but we should determine exact cases / grammar rules that must be validated, because cycles not always have to be forbidden.
Regarding to the proposed algorithm of cyclic definition rules detection.

We identify every mandatory rule call inside of a ParserRule instance by just walking down the AST, ignoring any optional (?/*) elements and collecting all mandatory rule calls inside

Can we omit optional element here?
EntryRule: (r+=R)* 'end'; R: R;

Once we have all mandatory rule calls, we can just apply any old graph cycle detection algorithm on top of that.

Thanks to alternatives we have not simple graph, but "multidimensional" graph: each node with alternatives have some groups of children, that have to be considered "in parallel". For example, the EntryRule has children [X, Y], but X has 3 possible children groups: [R, Y], [S], [T]. It makes us consider 3 different graphs: where X has children from the 1st alternative, from the 2nd and the 3rd.
EntryRule: X Y; X: R Y | S | T;
Rules R, Y, S and T also can have alternatives. So, the graph cycle detection algorithm has to be modified and becomes more complicated.

Removing the milestone assignment as I think we need more time to think this through.

This PR is 3 month old now.
@Pluralia @spoenemann is it still valid?
I've no idea how much effort rebasing might be.
Currently, it doesn't seem that reviewing it makes sense.

Let's close it for now. It was my fault: see #198


Error when installing milvus on K8s  with pulsarV3

I'm getting the following error when I try to install milvus.
helm install milvus-dev milvus/milvus -n milvus -f milvus.yaml

Error: template: milvus/charts/pulsarv3/templates/pulsar-manager-deployment.yaml:20:51: executing "milvus/charts/pulsarv3/templates/pulsar-manager-deployment.yaml" at <.Values.extra.pulsar_manager>: nil pointer evaluating interface {}.pulsar_manager
I have tried using the operator but I'm still getting the same error.

It should be fixed after v4.2.29, try again with newest version


Update zio-interop-cats to <IP_ADDRESS>

About this PR
📦 Updates dev.zio:zio-interop-cats from <IP_ADDRESS> to <IP_ADDRESS>
📜 GitHub Release Notes - Version Diff
Usage
✅ Please merge!
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

⚙ Adjust future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "dev.zio", artifactId = "zio-interop-cats" } ]

Or, add this to slow down future updates of this dependency:
dependencyOverrides = [{
  pullRequests = { frequency = "30 days" },
  dependency = { groupId = "dev.zio", artifactId = "zio-interop-cats" }
}]

labels: library-update, commit-count:1

Superseded by #553.


[themes] Settings sync update when previewing themes

Issue Type: Bug
Hey there!
Hope you're having a great time developing this beauty,
I was checking out themes I had installed ( the one I was using just bored me) and checking themes with command palette made settings sync requests! ( I guess it shouldn't until user confirms the theme; right? Oh and sorry bad English :) )
VS Code version: Code 1.58.2 (c3f126316369cd610563c75b1b1725e0679adfb3, 2021-07-14T22:10:15.214Z)
OS version: Windows_NT x64 10.0.22000
Restricted Mode: No

System Info

Item
Value

CPUs
Intel(R) Core(TM) i3-9100F CPU @ 3.60GHz (4 x 3600)

GPU Status
2d_canvas: enabledgpu_compositing: enabledmultiple_raster_threads: enabled_onoop_rasterization: enabledopengl: enabled_onrasterization: enabledskia_renderer: enabled_onvideo_decode: enabledvulkan: disabled_offwebgl: enabledwebgl2: enabled

Load (avg)
undefined

Memory (System)
15.95GB (7.72GB free)

Process Argv
--crash-reporter-id 1c2d542d-98c6-44ae-9134-31ab9ae687a3

Screen Reader
no

VM
0%

Extensions (19)

Extension
Author (truncated)
Version

c-cpp-compile-run
dan
1.0.14

python-extension-pack
don
1.6.0

xml
Dot
2.5.1

prettier-vscode
esb
8.0.1

vdf
GEE
0.0.7

csharp
ms-
1.23.13

python
ms-
2021.6.944021595

vscode-pylance
ms-
2021.7.4

jupyter
ms-
2021.8.1046824664

cpptools
ms-
1.5.1

notepadplusplus-keybindings
ms-
1.0.7

vscode-typescript-next
ms-
4.4.20210715

debugger-for-chrome
msj
4.12.12

material-icon-theme
PKi
4.8.0

live-sass
rit
3.0.0

LiveServer
rit
5.6.1

vscodeintellicode
Vis
1.2.14

JavaScriptSnippets
xab
1.8.0

txt-syntax
xsh
0.1.6

(7 theme extensions excluded)

A/B Experiments
vsliv368cf:30146710
vsreu685:30147344
python383cf:30185419
pythonvspyt602:30300191
vspor879:30202332
vspor708:30202333
vspor363:30204092
pythonvspyt639:30300192
pythontb:30283811
pythonvspyt551:30311712
vspre833:30321513
pythonptprofiler:30281270
vshan820:30294714
vstes263:30335439
pythondataviewer:30285071
vscus158:30321503
pythonvsuse255:30340121
vscod805cf:30301675
pythonvspyt200cf:30331938
vscextlang:30333561
binariesv615:30325510
vsccppwtct:30329789
bridge0708:30335490

Looking at themes with the theme picker does not change the settings.

Looking at the settings sync log I don't think it makes actual requests.

That's odd, it does recognize changes for me.
https://user-images.githubusercontent.com/41096570/126459383-891fa04b-e3f5-402c-97ce-56450e1230aa.mp4
And even if it didn't, it shouldn't trigger sync until confirmation anyways.

Oh, the storage is changed. We use it to open up flicker free.
Pushed a fix. Thanks!


fix: skip authentication when creating new user

Server returned 401 unauthorized error when trying to create a new user. Authentication for creating new user should be skipped, since there is no user credentials to verify against until the new user is created in the database.

excellent


change

Hi
how to switch between languages?
example ?chang=nl

Just use I18n.setLocale('nl');

I wonder how to do this user?
how can the user switch the language?

You can for example have a React component with a button with an onClick handler which calls I18n.setLocale('nl');.

nonsense, this with cookies will be a problem

react-i18nify doesn't use cookies at all :confused:


Context  type with generics not supported

I need a Context type with generics because it contains a database handler whose type varies according to the situations. The Context type with generics is supported by juniper:
https://docs.rs/juniper/0.14.1/juniper/macro.graphql_object.html#generics-and-lifetimes
But this doesn't seem to be supported by juniper-from-schema :
error[E0107]: wrong number of type arguments: expected 1, found 0
  --> lib/modules/gva/src/schema.rs:37:19
   |
37 |     context_type: Context<DB: BcDbInReadTx>
   |                   ^^^^^^^^^^^^^^^^^^^^^^^^^ expected 1 type argument

error[E0229]: associated type bindings are not allowed here
  --> lib/modules/gva/src/schema.rs:37:31
   |
37 |     context_type: Context<DB: BcDbInReadTx>
   |                           ^^^^^^^^^^^^^^^^ associated type not allowed here

error: aborting due to 2 previous errors

Have you planned to support context type with generics and/or explicit lifetime?

Good catch. I would like to get https://github.com/davidpdrsn/juniper-from-schema/pull/74 merged first so we don't have to migrate more graphql_object! macro code to juniper::object. That PR is currently blocked by https://github.com/graphql-rust/juniper/pull/441. I have requested a re-review of that from @theduke so lets wait and see.
Until then you might be able to box your db type
struct Context {
    db: Box<dyn BcDbInReadTx>,
}


Assertion failure in Cartridge regressions test reaction.sql on PG11

Description:

RDKit Version: 201803.4
Platform: Debian unstable

I tried running the Cartridge regression tests and had to disable 8 (2x4 identical?) tests due to Boost assertion failures like the following:
[17:03:32] product 0 has no mapped atoms.
res contrib_regression ::1(44082) SELECT: /usr/include/boost/dynamic_bitset/dynamic_bitset.hpp:815: boost::dynamic_bitset<Block, Allocator>& boost::dynamic_bitset<Block, Allocator>::operator|=(const boost::dynamic_bitset<Block, Allocator>&) [with Block = long unsigned int; Allocator = std::allocator<long unsigned int>]: Assertion `size() == rhs.size()' failed.
2018-12-08 17:03:32.140 UTC [27941] LOG:  server process (PID 28045) was terminated by signal 6: Aborted
2018-12-08 17:03:32.140 UTC [27941] DETAIL:  Failed process was running: SELECT tanimoto_sml(reaction_structural_bfp('c1ccccc1>CC(=O)O.[Na+]>c1ccncc1',2), reaction_structural_bfp('c1ncccc1>[Na+]>c1ncncc1',2));

Not sure if the product 0 has no mapped atoms. is part of the problem, there's lots of similar such messages above it.
The following tests failed:
SELECT tanimoto_sml(reaction_structural_bfp('c1ccccc1>>c1ccncc1',2), reaction_structural_bfp('c1ccccc1>>c1ccncc1',2));
SELECT tanimoto_sml(reaction_structural_bfp('c1ccccc1>>c1ccncc1',2), reaction_structural_bfp('c1ncccc1>>c1ncncc1',2));
SELECT tanimoto_sml(reaction_structural_bfp('c1ccccc1>CC(=O)O.[Na+]>c1ccncc1',2), reaction_structural_bfp('c1ccccc1>CC(=O)O.[Na+]>c1ccncc1',2));
SELECT tanimoto_sml(reaction_structural_bfp('c1ccccc1>CC(=O)O.[Na+]>c1ccncc1',2), reaction_structural_bfp('c1ncccc1>[Na+]>c1ncncc1',2));
[...]
SELECT tanimoto_sml(reaction_structural_bfp('c1ccccc1>>c1ccncc1',2), reaction_structural_bfp('c1ccccc1>>c1ccncc1',2));
SELECT tanimoto_sml(reaction_structural_bfp('c1ccccc1>>c1ccncc1',2), reaction_structural_bfp('c1ncccc1>>c1ncncc1',2));
SELECT tanimoto_sml(reaction_structural_bfp('c1ccccc1>CC(=O)O.[Na+]>c1ccncc1',2), reaction_structural_bfp('c1ccccc1>CC(=O)O.[Na+]>c1ccncc1',2));
SELECT tanimoto_sml(reaction_structural_bfp('c1ccccc1>CC(=O)O.[Na+]>c1ccncc1',2), reaction_structural_bfp('c1ncccc1>[Na+]>c1ncncc1',2));

I built RDKit with shared libraries and the Cartridge from the Code/PgSQL/rdkit/Makefile, which I had to modify a bit to make it work, but I don't think the changes are relevant (I will file issues for those changes later):
https://salsa.debian.org/debichem-team/rdkit/blob/master/debian/patches/postgres_Makefile_fixes.patch
After disabling the above tests, the regression tests pass.


Add tests for KBaseAuthConfig class.

Per @scanon this doesn't require a review so will merge when the build passes.


Unable to download abc.go.com

I am unable to download videos such as
http://abc.go.com/shows/once-upon-a-time/episode-guide/season-05/1-season-5-premiere-the-dark-swan
EDIT: It is also not available as http://www.hulu.com/watch/848953

already requested in #4661 and #1629.


Get-DbaLogin - Improve Speed for Lots of Logins

Type of Change

[ ] Bug fix (non-breaking change, fixes #)
[ ] New feature (non-breaking change, adds functionality)
[ ] Breaking change (effects multiple commands or functionality)
[x] Ran manual Pester test and has passed (`.\tests\manual.pester.ps1)
[ ] Adding code coverage to existing functionality
[ ] Pester test is included
[ ] If new file reference added for test, has is been added to github.com/sqlcollaborative/appveyor-lab ?
[ ] Nunit test is included
[ ] Documentation
[ ] Build system

Purpose
Improve speed of Get-DbaLogin when there are a lot of logins.
Approach
Get-DbaLogin was doing a query for every login to get the last login time. I changed it to get the last login times for all logins once per server and then locally lookup the login time instead of going back to SQL Server to get it. This approach took the time on a server with 150 logins from 600ms to 175ms.
Commands to test
Get-DbaLogin -SqlInstance 'MyServer'

fantastic! thank you!

unrelated test failure, will merge 💯  (i also have removed that other test in another PR, it's becoming unreliable on appveyor)


Unable to retrieve email from Twitter account

Hi. I was originally using TwitterKit, but I'm going to switch to this library.
But I ran into a problem implementing it.
I want to get the account email through v1 getAccountVerify, but the function does not work. Can you help? My implementation code looks like this:
// after login

self.client = .init(
    consumerKey: consumerKey,
    consumerSecret: consumerSecret,
    oauthToken: oauthToken,
    oauthTokenSecret: oauthTokenSecret
)

self.client
    .v1
    .account
    .getAccountVerify(.init(skipStatus: true, includeEmail: true, includeEntities: false))
    .responseObject { response in
        print("responseAccount > \(response.success)")
    }

On TwitterKit I was able to get the email value by calling include_email true in the same /1.1/account/verify_credentials.json. But I can't get it from this library.

Thanks for using TwitterAPIKit!
I tried "GET account/verify_credentials" and was able to get the email.

Here is the code.
let client = TwitterAPIClient(
    consumerKey: "my-key",
    consumerSecret: "my-secret",
    oauthToken: "my-token",
    oauthTokenSecret: "my-token-secret"
)

let response = await client.v1.account
    .getAccountVerify(.init(skipStatus: true, includeEmail: true, includeEntities: false))
    .responseObject

    print(response.prettyString)

Here are the steps I took to get the email.
Turn on the "Request email from users" switch in your developer portal

Regenerate token
Perhaps this step may not be necessary.
I forgot my token and had to regenerate it.
Run getAccountVerify(.init(skipStatus: true, includeEmail: true, includeEntities: false))
I was able to run the code and verify that the response contained the email.
Please double check
Since you are already using TwitterKit, your application is probably already configured in the Developer Portal, but please double check.
And could you double check that the account you are using has the email set up and verified? The API documentation says that if verification is not complete, null will be returned.

https://developer.twitter.com/en/docs/twitter-api/v1/accounts-and-users/manage-account-settings/api-reference/get-account-verify_credentials
If the user does not have an email address on their account, or if the email address is not verified, null will be returned.

Hi @mironal
Thank you for answer.
There was a problem with the settings in the Twitter Developer Dashboard. It wasn't a library issue😅


Not auth-token but access-token

Woops! Thanks for the fix.
@KAW0 have you used the clickup-to-sqlite successfully?


FastRT does not support resnest backbone

I see that FastRT project doesn't support restnest backbone. Can you update it in the future?
Is another way to convert restnest model to tensorrt?
Thanks!

Done by fastreid/tools


Make openssl dependency optional

Default behavior is unchanged. Other roles dependent on this role will have several options to skip the openssl dependency.
--skip-tags=ssl-dependency

or
vsftpd_enable_ssl: false

Thank for the PR and sorry for the late merge... busy days :)
Just to streamline the names, I changed the tag name from ssl-dependency to openssl-dependency.

No worries, thanks for the update.
On Sun, Dec 8, 2019 at 12:42 AM franklin<EMAIL_ADDRESS>wrote:

Thank for the PR and sorry for the late merge... busy days :)
Just to streamline the names, I changed the tag name from ssl-dependency
to openssl-dependency.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/weareinteractive/ansible-vsftpd/pull/13?email_source=notifications&email_token=ABMJBTL7YXW6UTKRB2JJF7DQXSQMTA5CNFSM4JI4XQYKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEGGX56I#issuecomment-562921209,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABMJBTLTR5KZKWBLKOLBI6TQXSQMTANCNFSM4JI4XQYA
.

--
Regards,
Carlos Hernandez


Driver loading problem

For building the driver,followed the steps in this documentation
https://falco.org/blog/falco-driverkit-debian-docker/#launching-falco-with-the-new-driver
I am facing an issue while executing this step
./driverkit/driverkit docker -c debian.yaml
while executing this command,getting output as
INFO using config file                             file=debian.yaml
INFO driver building, it will take a few seconds   processor=docker
FATA exiting       error=kernel headers not found
kindly help me in solving this issue

And also while using minikube cluster and
while installing falco through helm when giving this command
helm install falco falcosecurity/falco --set driver.kind=ebpf --namespace falco --create-namespace
my pod is in running state....But in devcluster or anyother cluster,when trying to install falco with this command getting crash loopbackoff state
This is the debian.yaml file
target: debian
driverversion: 2.0.0+driver
kernelrelease: 5.19.0-40-generic
kernelversion: 4122.04.1-Ubuntu
output:
module: ./drivers/2.0.0+driver/x86_64/falco_debian_5.19.0-40-generic_4122.04.1-Ubuntu.ko
probe: ./drivers/2.0.0+driver/x86_64/falco_debian_5.19.0-40-generic_41~22.04.1-Ubuntu.o

Hi...after executing uname --all,got the below output
Linux hp-HP-250-G8-Notebook-PC 5.19.0-41-generic #42~22.04.1-Ubuntu SMP PREEMPT_DYNAMIC Tue Apr 18 17:40:00 UTC 2 x86_64 x86_64 x86_64 GNU/Linux
Now after changing values in debian.yaml,the debian.yaml looks like
target: debian
driverversion: 2.0.0+driver
kernelrelease: 5.19.0-41-generic
kernelversion: 42~22.04.1-Ubuntu
output:
module: ./drivers/2.0.0+driver/x86_64/falco_debian_5.19.0-40-generic_41~22.04.1-Ubuntu.ko
probe:  ./drivers/2.0.0+driver/x86_64/falco_debian_5.19.0-40-generic_41~22.04.1-Ubuntu.o

Yep 42 is the right versioning.
Is it working now?

No,it is not working..still facing the same issue.

Now again after executing the  command ./driverkit/driverkit docker -c debian.yaml,I can see the below output,
INFO using config file                             file=debian.yaml
INFO driver building, it will take a few seconds   processor=docker
FATA exiting                                       error="kernel headers not found"
Can you share the exact command  for -l debug? Because am getting -l command not found

./driverkit/driverkit docker -c debian.yaml -l debug

/driverkit/driverkit docker -c debian.yaml -l debug
INFO using config file                             file=debian.yaml
DEBU running with options                          arch=amd64 driverversion=2.0.0+driver kernelrelease=5.19.0-41-generic kernelversion="42~22.04.1-Ubuntu" output-module="./drivers/2.0.0+driver/x86_64/falco_debian_5.19.0-40-generic_41~22.04.1-Ubuntu.ko" output-probe="./drivers/2.0.0+driver/x86_64/falco_debian_5.19.0-40-generic_41~22.04.1-Ubuntu.o" repo-name=libs repo-org=falcosecurity target=debian
INFO driver building, it will take a few seconds   processor=docker
DEBU doing a new docker build
FATA exiting                                       error="kernel headers not found"

Did you update your debian.yaml to only use 42 as kernelversion?

Also please, use code blocks when posting code or shell output; it is much more readable!

But I guess,you have driver for version 40.But in my case, version is 42.Will it cause any issue?.And also after downloading the driver,how to use it?Will  this driver supports anycluster like devcluster also?

You are still using
kernelversion: 42~22.04.1-Ubuntu
while you should be using
kernelversion:42
target: debian
driverversion: 2.0.0+driver
kernelrelease: 5.19.0-41-generic
kernelversion: 42
output:
  module: ./drivers/2.0.0+driver/x86_64/falco_debian_5.19.0-40-generic_41.ko
  probe: ./drivers/2.0.0+driver/x86_64/falco_debian_5.19.0-40-generic_41.o

This should work fine.
Remember also that kernel headers discovery algorithm is best effort, that's why we developed the kernel-crawler tool, that actually crawls multiple distros kernels and outputs a driverkit like format list.
Btw latest kernel-crawler run discovered the new kernel: https://falcosecurity.github.io/kernel-crawler/?arch=x86_64&target=Ubuntu&search=5.19.0-41-generic and the CI is building the drivers for it: https://prow.falco.org/view/s3/falco-prow-logs/logs/build-new-drivers-ubuntu-generic-5-postsubmit/1653369276062502912
The new driver should be available in a couple of hours.

Will it cause any issue?.And also after downloading the driver,how to use it?Will this driver supports anycluster like devcluster also?

Yep, it won't load if the kernelversion is different. But you are soon going to find the new prebuilt drivers for your version tjhat will work :)

I want to install falco through helm in dev cluster.So after downloading driver,what should I do next?

You should then follow: https://github.com/falcosecurity/charts/tree/master/falco#adding-falcosecurity-repository
Again, as soon as the driver is available on download.falco.org, everything will go smoothly.

The driver is now available on download.falco.org: https://download.falco.org/driver/site/index.html?lib=4.0.0%2Bdriver&target=ubuntu-generic&arch=x86_64&kind=kmod&search=falco_ubuntu-generic_5.19.0-42-generic_43.ko

Hi....Again facing Crash LoopBack off issue.
Below is my values.yaml file
falco:   driver:     name: "https___download.falco.org_driver%2F4.0.0%2Bdriver%2Fx86_64%2Ffalco_ubuntu-generic_5.19.0-42-generic_43.ko"     source: "file://home/shifnazarnaz/falco-install/https___download.falco.org_driver%2F4.0.0%2Bdriver%2Fx86_64%2Ffalco_ubuntu-generic_5.19.0-42-generic_43.ko"
After giving  helm install falco falcosecurity/falco -f values.yaml -n falco
My pods are in crashLoop backoff state

Hi....Again facing Crash LoopBack off issue.
Below is my values.yaml file
falco:
driver:
name: "https___download.falco.org_driver%2F4.0.0%2Bdriver%2Fx86_64%2Ffalco_ubuntu-generic_5.19.0-42-generic_43.ko" source: "file://home/shifnazarnaz/falco-install/https___download.falco.org_driver%2F4.0.0%2Bdriver%2Fx86_64%2Ffalco_ubuntu-generic_5.19.0-42-generic_43.ko
```"
After giving  helm install falco falcosecurity/falco -f values.yaml -n falco

My pods are in crashLoop backoff state

Here as you can see my problem has not solved,still am facing crashloopback off state,after using the driver for my kernel version.So kindly help me in solving this issue

Yes but the opening post is talking about:

For building the driver,followed the steps in this documentation
https://falco.org/blog/falco-driverkit-debian-docker/#launching-falco-with-the-new-driver
I am facing an issue while executing this step
./driverkit/driverkit docker -c debian.yaml

But ok; if you install Falco through the helm chart there is no need to download any driver locally; your values.yaml is weird looking (name and source for driver?)
Have you tried just following https://github.com/falcosecurity/charts/tree/master/falco#adding-falcosecurity-repository?
Quoting from that page:

The driver should be installed on the node where Falco is running. The kernel module (default option) and the eBPF probe are installed on the node through an init container (i.e. falco-driver-loader) that tries to build drivers to download a prebuilt driver or build it on-the-fly or as a fallback. The Modern eBPF probe doesn't require an init container because it is shipped directly into the Falco binary. However, the Modern eBPF probe requires a kernel version equal to or greater than 5.8.

after kernel update. I can't build drivers
my debian.yaml:
target: debian
driverversion: 5.0.1+driver
kernelrelease: 5.18.16-1-amd64
kernelversion: 1
output:
module: drivers/5.0.1+driver/x86_64/falco_debian_5.18.16-1-amd64_1.ko
probe:  drivers/5.0.1+driver/x86_64/falco_debian_5.18.16-1-amd64_1.o

Can you share debug log (-l debug at cmdline)?

Uh i see it is not finding kernelurls. Are you sure that is the correct kernel release?

Can you share your uname -a?

5.18.0-0.deb11.4-amd64

yeah, its uname -r

I was able to download the driver from DRIVER_REPO but Falco is not start
I have an error:

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
If this issue is safe to close now please do so with /close.
Provide feedback via https://github.com/falcosecurity/community.
/lifecycle stale

/close
This has nothing to do with driverkit. Feel free to open an issue on Falco repository.


Parallel scheduler fixes

This PR is based on #1452. The last 4 commits are of this PR.
I can (and probably should) remove some of the yaml tests. I just wanted to demonstrate the extent of the correctness provided by these fixes.
There are 2 bug fixes and then an improvement. The 2 bug fixes are around checking if a transaction is a predecessor of a predecessor (and so on), where the previous check had just been if the transaction was a predecessor of a predecessor. The improvement sorts the predecessors and stores them in a list when they are first calculated instead of when they are accessed.

I rebased on master after #1452 was merged. I am still working on organizing the test files with the commits and trying to come up with a means of reducing the overall lines committed.

Two suggestions:

The sorting commit is an improvement rather than a bug fix, so it
should probably go in a separate PR so it can be discussed,
profiled, etc. without holding up the bug fixes.

The data structure commit looks like a refactor, but it also
includes a change in behavior. It would be easier to see what's
going on if the refactor were done before the behavior change.

Closing in favor of https://github.com/hyperledger/sawtooth-core/pull/1499


When you maximize the windows(double click on the header).. all the tasks currently there.. goes away.. until u restore

fixed with 9427c8229ff6cf8c81106a45032b6f538392d5f2 please verify and close

looks good :)


Breaking change in 1.10

I just upgraded deps and ended up with an unexpected error, caused by https://github.com/Kikobeats/cacheable-response/commit/a69239276d06d5fd1bcea204989bc1bfa26e09b9
This change of signature for getKey is breaking:
-(req, res) => ...
+({ req, res }) => ...

Took me quite some time to figure it out. I was using req.headers.host inside getKey, which now became opts.headers.host (opts.headers is undefined, hence TypeError).
Not sure what to do. Perhaps, the signature change should be reverted in 1.10.1, followed by the release of the new signature as 2.0.0

Sorry for that; I added the migration guide as part of the release note
https://github.com/Kikobeats/cacheable-response/releases/tag/v1.10.0
🙂

🤔 Not sure if adding migration instructions will be enough for the users, because the semver 'contract' is still not followed. When upgrading from x.y.0 to x.z.0, no migration steps are expected.
This is why package.json usually contains "some-package": "^x.y.0" (this means that x.z.0 is good to go too). The only 'regression' that's allowed within one major version is now warnings, suggesting to refactor things in preparation to the next major version bump.

I agree but based on npm, only two packages is using it https://www.npmjs.com/package/cacheable-response so it's not a big deal for this time

I think that quite a lot of the usage of this library (which is very good, by the way :-) are directly from applications and not other libraries. So the numbers on npmjs.com does not really tell the whole truth :-)


RNN stateful is incompatible with initial_state

If stateful=True is being used with an RNN (e.g. LSTM), if you pass in an initial_state (either with initial_state= kwarg or as a list of tensors in the argument when calling the layer (.call()), the initial state overrides the stored states in the stateful RNN.

This still fails with Tensorflow 2.0.0-rc0.
@gowthamkpr would you mind labeling this issue so this bug might get more visibility?

See https://github.com/tensorflow/tensorflow/issues/32299


Add 'org' flag (enable use outside of team folder)

Adds an optional flag, --org or --organisation, that overrides the organisation set in local Bosco config or that associated with the current folder during bosco team setup.
This means you can run an app outside a team folder (lack of org was the only thing stopping you before). Bosco will simply run all the dependencies in docker containers. The org you set obviously needs to be the correct Github org for the microservices you're trying to run.
Example: bosco run -d --org tes
Also fixes a few moderate npm audit vulnerabilities.
@varvarra cc'ing you as you requested it. Also @rouanw @ksnll

Coverage remained the same at 81.284% when pulling f856046bfad6e387ac36f6cda1c74b766e46923f on use-outside-team-folder into bf1055f2d20d1ed19720b98d26b044dac413d635 on master.

@gwpmad don't forget about your PR 😃

Ah good point, I've thought about this and I don't think it's all that important a feature given you can configure this on your machine anyway. I think I'm going to close the PR


new adapter pi-hole

Forum-Thread for first testings:
https://forum.iobroker.net/topic/22715/aufruf-neuer-adapter-iobroker-pi-hole

Welcome to the repository.
One personal code-review note: Using intervalls is dangerous because the intervall fires regardless if the former request was finished. So on network issues or load problems you may end up in having many parallel requests running against the server ... It is better to use setTimeout and set the next timeout once the request before was finished ... so you make sure that you only have one request active at any time.
Additionally having "setObjectNotExist in each "Loop" is not ideal from a performance perspective, it would be better to only do this in the first "Loop".


exit() function bypasses END probe processing

END probe processing is bypassed when the tracing session is terminated with a call to the exit() function:
# cat END-bypass.bt
tracepoint:syscalls:*
{
  @[probe] = count()
}

interval:s:5
{
  exit();
}

END
{
  clear(@);
}

# bpftrace.new END-bypass.bt
Attaching 612 probes...
<chop>
@[tracepoint:syscalls:sys_exit_sendto]: 17988
@[tracepoint:syscalls:sys_enter_sendto]: 17988
@[tracepoint:syscalls:sys_enter_recvfrom]: 19187
@[tracepoint:syscalls:sys_exit_recvfrom]: 19191

As expected, if I terminate the session with a <Ctrl-C> then the END probe is processed and nothing is printed.
The documentation isn't explicit on the behaviour of END processing in this case but I think it feels more natural for END probes to be processed on a controlled exit regardless of termination mechanism.

Thanks @caringi for fixing this! Really appreciate all the work.


when use deleteBucket,the bucket  is deleted ,but s3.configure auth metadata is not auto deleted

Describe the bug
when use s3Client.deleteBucket(bucket),the bucket  is deleted ,but s3.configure auth metadata is not auto deleted
Expected behavior
when use s3Client.deleteBucket(bucket),all the related metadata should be deleted

some use cases may want to re-create the bucket and reuse the same auth metadata?


BSOD High GPU Setting

Please check if your issue is not a duplicate by searching existing issues
Describe the bug
A clear and concise description of what the bug is.
To Reproduce
Steps to reproduce the behavior:

Go to Fossil island while having a GT940m + i5
Enable the GPU setting and increase the number to above 60.
Wait for a couple of minutes
WHEA_UNCORRECTABLE_ERROR BSOD

Expected behavior
Increased render distance, definitely not a BSOD.
Screenshots
If applicable, add screenshots to help explain your problem.
Environment (please complete the following information):

OS: Windows
RuneLite version: [e.g 1.4.6]

Additional context
2019-03-18 23:26:34 [AWT-EventQueue-0] INFO  net.runelite.client.ui.ClientUI - Showing frame net.runelite.client.ui.ContainableFrame[frame0,0,0,1920x1040,layout=java.awt.BorderLayout,title=RuneLite,resizable,maximized,defaultCloseOperation=DO_NOTHING_ON_CLOSE,rootPane=javax.swing.JRootPane[,0,0,949x1041,layout=org.pushingpixels.substance.internal.ui.SubstanceRootPaneUI$SubstanceRootLayout,alignmentX=0.0,alignmentY=0.0,border=org.pushingpixels.substance.internal.utils.border.SubstancePaneBorder@63bfd1fb,flags=16777673,maximumSize=,minimumSize=,preferredSize=],rootPaneCheckingEnabled=true]
Latest line from my client.log file before crashing.

#6803 seems related to this issue.


[ListItem] height not growing with avatar

If the primaryText is empty (or Number(0) in this case), then the list item height will not be large enough to contain the avatar.

I think it's because we are using absolute positioning and not a flexbox system.

This is still an issue.

Hey, is there a solution dor this already? I'm having the same issue. Thanks!

The issue has been solved on the next branch. I'm closing it. Thanks for the report. We are now relying on the flexbox layout model.

@oliviertassinari Thanks for the news - however may I ask if there is a specific version that this is fixed? I am using "^0.20.1" (had not upgraded because of another dependency) and it seems that I am still encountering this issue.

0.x is no longer maintained.

I see.
Will try to follow the migration guide and use both 1.x and 0.x at parallel then (I assume that 1.x will have the issue fixed)
Thanks anyway!


Add support for IFileOperation interface

I've managed to implement support for the IFileOperation interface in pure C 😃. Right now, the program falls back to the old SHFileOperation function for versions lower than Windows 8, but I think we should remove support for the old API altogether, as recycle on delete is the default behavior with IFileOperation for Windows 7 and Vista, according to Electron. Dealing with COM interfaces in C/C++ is a little bit ugly in general, so I've added some macros to help with error checking. Not sure if that's the best way to do so, open for improvements.
I added some comments for stuff that requires a little explanation to understand.
Resolves #1

but I think we should remove support for the old API altogether

👍

Can you add a test for a long file path (more than 255 characters)? So we can ensure that works now.

How do you want me to add a test? Could you please elaborate?

How do you want me to add a test? Could you please elaborate?

Some tests that prove the new functionality works correctly by executing the binary with various input. For example, create a very deep nested path and try to delete it. Create a path with Unicode characters and try to delete it. Could use a Batch script for this, unless you can think of a better way? Example: https://github.com/sindresorhus/win-clipboard/blob/218dcffb9ee5b4bed47bad42b0f1cde654b35781/test.bat

IShellItem can be created with long paths using simple pidls (SHSimpleIDListFromPath),
- https://www.zabkat.com/blog/max-path-programmers-cookbook.htm

Yeah, I found that function too, but if take a look at the docs you can see that it's marked as deprecated.

So I justed tried the other shell functions we found (SHSimpleIDListFromPath, SHCreateItemFromParsingName, ILCreateFromPath) and none of them works with a prefix of \\?\ 😢. The one that seems to support the longest paths is ILCreateFromPath.

@sindresorhus I've added some test cases. Please take a look at the results:

SHFileOperation
IFileOperation

Windows 7
Test case #1: FAILED Test case #2: FAILED Test case #3: FAILED
Test case #1: PASSED Test case #2: PASSED Test case #3: FAILED

Windows 10
Test case #1: PASSED Test case #2: PASSED Test case #3: PASSED
Test case #1: PASSED Test case #2: PASSED Test case #3: PASSED

If I run the binary from the cmd.exe on Windows 10, it interactively prompts me if I'm sure I want to trash the item. It should not do that.

@sindresorhus That's a good catch! Apparently, it's possible to suppress that warning by implementing a custom subclass of the IFileOperationProgressSink interface. The only other alternative would be an undocumented internal Windows API.
You can take a look at the code if you want, but be warned, there's an insane amount of boilerplate needed to resolve that single problem, because COM requires you to implement EVERY SINGLE FUNCTION of that interface.

Can you move the interface implementation into a separate file?

@sindresorhus Sure, the code looks much nicer now 😊. I would really to add a test case for this scenario, but I'm out of ideas on how to do that (would need some kind of fake USB/Network Drive).

I think there is a problem with the code depending on how you intend to compile it. Some flags like FOFX_ADDUNDORECORD were added in Windows 8. Therefore this won't compile on Windows 7 even when using the version check IsWindows8OrGreater() because the flag isn't defined.

@robertguetzkow That's correct, do you think we should add an #ifdef to fall back to the old flags on Windows 7?
We definitely need to compile the release on Windows 8 or 10 to be able to support the new behavior, for use in other projects.

I don’t think we should add if-defs. I’m fine with it only being possible to compile it on Windows 10.

@medusalix @sindresorhus You could add the following to define the flags that aren't available in the headers of Windows Vista and 7.
#ifndef FOFX_ADDUNDORECORD
#define FOFX_ADDUNDORECORD 0x20000000
#endif

#ifndef FOFX_RECYCLEONDELETE
#define FOFX_RECYCLEONDELETE 0x00080000
#endif

@medusalix Anything left before this can be merged?

@sindresorhus Ready to merge 😃.

@sindresorhus Just a little reminder that this can be merged 👍.

Sorry for the delay. I had to get my Windows VM fixed so I could test it.
It tried compiling a binary, but it's not really working. I have a file named foo on my Windows VM desktop, and when I run recycle-bin.exe foo nothing happens. No error message. Not moved to the trash.

IFileOperation can only be applied in a single-threaded apartment (STA) situation. It cannot be used >for a multithreaded apartment (MTA) situation. For MTA, you still must use SHFileOperation.

https://docs.microsoft.com/en-us/windows/desktop/api/shobjidl_core/nn-shobjidl_core-ifileoperation
last of the page
and google what means COINIT_MULTITHREADED
https://github.com/medusalix/recycle-bin/blob/34a86c5e8c1d1ddf8d28963b9acb52690a91e446/recycle-bin.c#L39

@alexeyneu Good catch 😄. I always choose COINIT_MULTITHREADED, because I'm not using the Windows message loop:

If you specify apartment threading, you are making the following guarantees:

You will access each COM object from a single thread; you will not share COM interface pointers between multiple threads.
The thread will have a message loop. (See Window Messages in Module 1.)

But apparently it works 👍.

Great. Works now :)

Awesome 😄.


Firebird SET TERM (delimiter) support

Support of custom Firebird delimiters in scripts. The syntax is:
set term <new_delimiter> <old_delimiter>
like:
set term # ;
...
set term ; #

Best regards

You can select the block you are trying to execute and it will execute regardless of what the current terminator is. It also ignores ; within the block.

OK, but I'm trying to execute a script to build the database and it's about 80 pages. It's impossible to run it block by block, I have 200 stored procedures at least.

Sorry, wrong button.

Great!! Many thanks!!

The SET TERM feature for Firebird script execution seems to have stopped working properly from DBeaver 7.25+. Working fine in 7.22. Tested in 7.22 (working), 7.25 (broken), 7.30 (broken).
DBeaver 7.22:
set term #;
execute block returns (results varchar(1000)) as
   declare variable dummy1 varchar(20);
   declare variable dummy2 varchar(20);
begin
   results = 'Hello World';
   suspend;
end#
set term ;#

RESULTS
Hello World

DBeaver 7.30:
set term #;
execute block returns (results varchar(1000)) as
   declare variable dummy1 varchar(20);
   declare variable dummy2 varchar(20);      -- << Adding this 2nd local variable forces the error!!
begin
   results = 'Hello World';
   suspend;
end#
set term ;#

It complains about the "#" on the "end#" line:
> SQL Error [335544634] [42000]: Dynamic SQL Error; SQL error code = -104; Token unknown - line 7, column 4; # [SQLState:42000, ISC error code:335544634]
>   Dynamic SQL Error; SQL error code = -104; Token unknown - line 7, column 4; # [SQLState:42000, ISC error code:335544634]
>   Dynamic SQL Error; SQL error code = -104; Token unknown - line 7, column 4; # [SQLState:42000, ISC error code:335544634]
>     Dynamic SQL Error
>     Dynamic SQL Error
>       SQL error code = -104
>       Token unknown - line 7, column 4
>       #


Error waiting for NAT Gateway to become available: unexpected state 'failed', wanted target 'available'. last error: %!s()

Hello,
Terraform version: v0.15.3
aws provider = 3.59.0
We are using terraform VPC module to deploy 2 private subnets and attaching that subnet to my Redis Elastic Cache. After applying it is working fine.
But when a new request comes to add 2 more private subnets to the existing infra, we added 2 more private subnets to the existing infra and then run terraform apply command. After running some time we got the below error:
Error: Error waiting for NAT Gateway to become available: unexpected state 'failed', wanted target 'available'. last error: %!s()
Is there any solution for the same?
Because of this error, we are not able to continue with incremental infra deployments.

Please fill in the issue template when opening an issue, include code snippet and error log. It is very important if you want to get a reply.
From the information you provided I think you hit some AWS quotas that prevent you from deploying change. Read more here - https://aws.amazon.com/premiumsupport/knowledge-center/manage-service-limits/
I am going to close this one.


p3x-onenote: 2023.4.117 -> 2023.10.243 and change the name to pname

Description of changes

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 267480 run on x86_64-linux 1

1 package built:

p3x-onenote


Can't get plugin working

Not sure what I'm doing wrong. I'm following the example in the readme. At startup I see:
caddy   | {"level":"info","time":"2024-11-26T23:34:22.132Z","msg":"started lambda runtime","lambda_name":"hello_world","worker_id":0,"worker_pid":15,"worker_timeout":60}
But querying the API endpoint just gives me
< HTTP/1.1 200 OK
< Server: Caddy
< Date: Tue, 26 Nov 2024 23:38:01 GMT
< Content-Length: 0
<

Even if I change the return code to 404.
route /api/* {
            lambda {
                name hello_world
                runtime python
                python_executable /usr/bin/python3
                entrypoint /scripts/hello.py
                function handler
            }
        }
    route {
        respond "OK"
    }

Even adding  order lambda after encode and having an empty lambda section at the root of the site it doesn't seem to work. The python path is correct because if I change it I get warnings.

@torarnv , enable debugging and attach your logs here.


windows run xgo test error

func TestMethodMock(t *testing.T) {
	myStruct := &MyStruct{
		name: "my struct",
	}
	otherStruct := &MyStruct{
		name: "other struct",
	}
	mock.Mock(myStruct.name, func(ctx context.Context, fn *core.FuncInfo, args core.Object, results core.Object) error {
		results.GetFieldIndex(0).Set("mock struct")
		return nil
	})

	// myStruct is affected
	name := myStruct.Name()
	if name != "mock struct" {
		t.Fatalf("expect myStruct.Name() to be 'mock struct', actual: %s", name)
	}

	// otherStruct is not affected
	otherName := otherStruct.Name()
	if otherName != "other struct" {
		t.Fatalf("expect otherStruct.Name() to be 'other struct', actual: %s", otherName)
	}
}

command: xgo test -run TestMethodMock .\mock_tcp_conn\
error: create ~/.xgo/log: mkdir C:\Users\admin\.xgo\go-instrument\go1.20.5_C:_Us_ad_sc_ap_go_cu_90061880: The directory name is invalid.
maybe create windows dir/file could not include ":"

Noted,will fix it tomorrow morning. Thanks for feedback

This has been fixed, see commit https://github.com/xhd2015/xgo/commit/a651abf3abfec58ea52a4d774a1b04c6f7c70c1d
You may need to update xgo to build again:
cd xgo
git pull
go run ./script/build-release --local

P.S. I managed to get a PC on my hand, I will do a thorough test on windows today. Hope all windows issues be settled tonight, please stay tuned!

Alright, It seems to be a new error: replace not permitted:C:\Users\admin\.xgo\go-instrument\go1.20.5_C_Us_ad_sc_ap_go_cu_90061880\go1.20.5, maybe no permission although I run xgo inadministrator
In addition, maybe fix shasum command not found in script/build-release is Urgent, It look like build failed

👌, will fix it this afternoon

Update: have fixed a bunch of issues related to windows.
The biggest one seems to be when IR rewriting enabled, windows needs to disable optimization(gcflags=-N).
Hopefully most things on windows will be resolved tonight.

Excited to announce windows passed all tests, see commit https://github.com/xhd2015/xgo/commit/f07938bdff12fa4bd066d0e9cfde64e99f17122a (tag v1.0.6)
With this update, xgo v1.0.6 has been released: https://github.com/xhd2015/xgo/releases/tag/v1.0.6.
You may need to update xgo to build again:
cd xgo
git pull
go run ./script/build-release --local

Maybe something wrong?
I test in my windows, and got error:
func TestMethodMock(t *testing.T) {
	myStruct := &MyStruct{
		name: "my struct",
	}
	otherStruct := &MyStruct{
		name: "other struct",
	}
	mock.Mock(myStruct.name, func(ctx context.Context, fn *core.FuncInfo, args core.Object, results core.Object) error {
		results.GetFieldIndex(0).Set("mock struct")
		return nil
	})

	// myStruct is affected
	name := myStruct.Name()
	if name != "mock struct" {
		t.Fatalf("expect myStruct.Name() to be 'mock struct', actual: %s", name)
	}

	// otherStruct is not affected
	otherName := otherStruct.Name()
	if otherName != "other struct" {
		t.Fatalf("expect otherStruct.Name() to be 'other struct', actual: %s", otherName)
	}
}

❯ xgo test -run TestMockArg -v ./test
# runtime
..\..\..\..\runtime\proc.go:241:1: undefined: __xgo_is_init_finished
..\..\..\..\runtime\proc.go:242:20: undefined: __xgo_on_init_finished_callbacks
..\..\..\..\runtime\proc.go:245:1: undefined: __xgo_on_init_finished_callbacks
..\..\..\..\runtime\proc.go:3627:20: undefined: __xgo_on_goexits
exit status 1

xgo on  master [!] via 🐹 v1.20.5
❯ xgo version
1.0.6

May I ask what is your go version, and go env GOROOT? Is there any space inside the GOROOT?

golang\src\gotest via 🐹 v1.20.5 took 2s
❯ go version
go version go1.20.5 windows/amd64

golang\src\gotest via 🐹 v1.20.5
❯ go env GOROOT
C:\Users\admin\scoop\apps\go\current

And also the output of xgo exec go version of xgo exec go eng GOROOT?
Seems the above error is due to the GOROOT pointing to original go source, not the instrumented source.

And also the output of xgo exec go version of xgo exec go env GOROOT? Seems the above error is due to the GOROOT pointing to original go source, not the instrumented source.

Got same error, maybe build --local error? See #8 Or maybe I Install golang by scoop? (C:\Users\admin\scoop\apps\go\current Is link but not a directory)

Ok understood,I've not tested that against a symbolic GOROOT on windows. Can you run xgo test --with-goroot your/real/goroot ... (replace your/real/goroot with the actual goroot on your machine), this forces xgo uses the specified GOROOT instead of environment value.

Ok understood,I've not tested that against a symbolic GOROOT on windows. Can you run xgo test --with-goroot your/real/goroot ... (replace your/real/goroot with the actual goroot on your machine), this forces xgo uses the specified GOROOT instead of environment value.

Not work, got same error

I just tested with a symbolic link on windows, got error:
PS C:\Projects\xgo> xgo exec --with-goroot C:\installed\go1.22.1-sym.lnk go version
exec: "C:\\installed\\go1.22.1-sym.lnk\\bin\\go": executable file not found in %PATH%

It is obvious that windows does not think go1.22.1-sym.lnk to be a directory.
Can you verify if your GOROOT installed by scoop is a link? And if it is, can you run the above command with your goroot to check what will happen?

Ok so I installed scoop, and successfully ran all tests on windows(powershell):
cd xgo

$Env:Path="C:\Users\xhd2015\scoop\apps\go\current\bin;C:\Users\xhd2015\.xgo\bin"

xgo test -v .\test\xgo_test\...

Output:
=== RUN   TestTrapSet
--- PASS: TestTrapSet (0.00s)
PASS
ok      github.com/xhd2015/xgo/test/xgo_test/link_on_init_finished      0.273s
=== RUN   TestMemEqual
--- PASS: TestMemEqual (0.00s)
PASS
ok      github.com/xhd2015/xgo/test/xgo_test/mem_equal  0.234s
=== RUN   TestMethodShouldHaveFMSuffix
--- PASS: TestMethodShouldHaveFMSuffix (0.00s)
PASS
ok      github.com/xhd2015/xgo/test/xgo_test/method_fm_suffix   0.255s
=== RUN   TestMethodRecvValueShouldBeCopied
--- PASS: TestMethodRecvValueShouldBeCopied (0.00s)
PASS
ok      github.com/xhd2015/xgo/test/xgo_test/method_recv_value  0.217s
=== RUN   TestMethodValueCompare
--- PASS: TestMethodValueCompare (0.00s)
PASS
ok      github.com/xhd2015/xgo/test/xgo_test/method_value_cmp   0.179s
=== RUN   TestRewriteChallenge
--- PASS: TestRewriteChallenge (0.00s)
PASS
ok      github.com/xhd2015/xgo/test/xgo_test/rewrite_challenge  0.175s
=== RUN   TestTrapSet
--- PASS: TestTrapSet (0.00s)
PASS
ok      github.com/xhd2015/xgo/test/xgo_test/trap_set   0.178s

I test in my work computer and got same error, I don't know the reason for this error

❯ xgo test -run TestMethodMock -v ./test
# runtime
..\..\..\..\runtime\proc.go:241:1: undefined: __xgo_is_init_finished
..\..\..\..\runtime\proc.go:242:20: undefined: __xgo_on_init_finished_callbacks
..\..\..\..\runtime\proc.go:245:1: undefined: __xgo_on_init_finished_callbacks
..\..\..\..\runtime\proc.go:3627:20: undefined: __xgo_on_goexits

This looks weird, I will add a debug flag to enable log to see what's going on.(The log will contain environment info and building log).
By the way, what kind of terminal are you using on windows, powershell or other thing?

❯ xgo test -run TestMethodMock -v ./test
# runtime
..\..\..\..\runtime\proc.go:241:1: undefined: __xgo_is_init_finished
..\..\..\..\runtime\proc.go:242:20: undefined: __xgo_on_init_finished_callbacks
..\..\..\..\runtime\proc.go:245:1: undefined: __xgo_on_init_finished_callbacks
..\..\..\..\runtime\proc.go:3627:20: undefined: __xgo_on_goexits

This looks weird, I will add a debug flag to enable log to see what's going on.(The log will contain environment info and building log).
By the way, what kind of terminal are you using on windows, powershell or other thing?

powershell 5.1

@WAY29 I have added a flag to log internal compile process, see a90c6ef
First, upgrade xgo:
cd xgo
git pull
go run ./script/build-release --local

Then, run xgo with --log-debug:
xgo test --log-debug -run TestMethodMock -v ./test

And check debug.log in your current directory. Debug log example:
2024-03-25 17:55:24 start: [C:\Users\lukas\AppData\Local\Temp\go-build2111748048\b001\exe\xgo.exe exec --log-debug go version]
2024-03-25 17:55:24 runtime.GOOS=windows
2024-03-25 17:55:24 runtime.GOARCH=amd64
2024-03-25 17:55:24 runtime.Version()=go1.22.1
2024-03-25 17:55:25 effective GOROOT: C:\installed\go1.22.1
2024-03-25 17:55:25 go version: go1.22.1
2024-03-25 17:55:25 instrument dir: C:\Users\lukas\.xgo\go-instrument-dev\go1.22.1_C_in_go_5dd13d4a
2024-03-25 17:55:25 sync goroot C:\installed\go1.22.1 -> C:\Users\lukas\.xgo\go-instrument-dev\go1.22.1_C_in_go_5dd13d4a\go1.22.1
2024-03-25 17:55:25 patch compiler at: C:\Users\lukas\.xgo\go-instrument-dev\go1.22.1_C_in_go_5dd13d4a\go1.22.1
2024-03-25 17:55:26 setup dev dir: C:\Users\lukas\.xgo\go-instrument-dev\go1.22.1_C_in_go_5dd13d4a\go1.22.1
2024-03-25 17:55:27 compiler changed: false
2024-03-25 17:55:27 tool exec flags: -toolexec=C:\Users\lukas\.xgo\bin\exec_tool.exe --enable --
2024-03-25 17:55:27 command: [go version]
2024-03-25 17:55:27 command env: [ALLUSERSPROFILE=C:\ProgramData APPDATA=C:\Users\lukas\AppData\Roaming CHROME_CRASHPAD_PIPE_NAME=\\.\pipe\crashpad_7388_YDEVBNMAIHLMTUHG CommonProgramFiles=C:\Program Files\Common Files CommonProgramFiles(x86)=C:\Program Files (x86)\Common Files CommonProgramW6432=C:\Program Files\Common Files COMPUTERNAME=DESKTOP-Q4TKH82 ComSpec=C:\Windows\system32\cmd.exe DriverData=C:\Windows\System32\Drivers\DriverData FPS_BROWSER_APP_PROFILE_STRING=Internet Explorer FPS_BROWSER_USER_PROFILE_STRING=Default GOPATH=C:\Projects\gopath GOROOT=C:\installed\go1.22.1 HOMEDRIVE=C: HOMEPATH=\Users\lukas LOCALAPPDATA=C:\Users\lukas\AppData\Local LOGONSERVER=\\DESKTOP-Q4TKH82 NUMBER_OF_PROCESSORS=4 OneDrive=C:\Users\lukas\OneDrive ORIGINAL_XDG_CURRENT_DESKTOP=undefined OS=Windows_NT Path=C:\installed\go1.22.1\bin;C:\Program Files (x86)\Intel\Intel(R) Management Engine Components\iCLS\;C:\Program Files\Intel\Intel(R) Management Engine Components\iCLS\;C:\Windows\system32;C:\Windows;C:\Windows\System32\Wbem;C:\Windows\System32\WindowsPowerShell\v1.0\;C:\Windows\System32\OpenSSH\;C:\installed\go1.22.1\bin;C:\cygwin64\bin;C:\Users\lukas\.xgo\bin;C:\Projects\gopath\bin;C:\Projects\gopath\bin;C:\Users\lukas\scoop\shims;C:\Users\lukas\AppData\Local\Microsoft\WindowsApps;C:\Users\lukas\AppData\Local\Programs\Microsoft VS Code\bin PATHEXT=.COM;.EXE;.BAT;.CMD;.VBS;.VBE;.JS;.JSE;.WSF;.WSH;.MSC;.CPL PROCESSOR_ARCHITECTURE=AMD64 PROCESSOR_IDENTIFIER=Intel64 Family 6 Model 158 Stepping 10, GenuineIntel PROCESSOR_LEVEL=6 PROCESSOR_REVISION=9e0a ProgramData=C:\ProgramData ProgramFiles=C:\Program Files ProgramFiles(x86)=C:\Program Files (x86) ProgramW6432=C:\Program Files PSModulePath=C:\Users\lukas\Documents\WindowsPowerShell\Modules;C:\Program Files\WindowsPowerShell\Modules;C:\Windows\system32\WindowsPowerShell\v1.0\Modules PUBLIC=C:\Users\Public SESSIONNAME=Console SystemDrive=C: SystemRoot=C:\Windows TEMP=C:\Users\lukas\AppData\Local\Temp TMP=C:\Users\lukas\AppData\Local\Temp USERDOMAIN=DESKTOP-Q4TKH82 USERDOMAIN_ROAMINGPROFILE=DESKTOP-Q4TKH82 USERNAME=lukas USERPROFILE=C:\Users\lukas windir=C:\Windows TERM_PROGRAM=vscode TERM_PROGRAM_VERSION=1.87.2 LANG=en_US.UTF-8 COLORTERM=truecolor GIT_ASKPASS=c:\Users\lukas\AppData\Local\Programs\Microsoft VS Code\resources\app\extensions\git\dist\askpass.sh VSCODE_GIT_ASKPASS_NODE=C:\Users\lukas\AppData\Local\Programs\Microsoft VS Code\Code.exe VSCODE_GIT_ASKPASS_EXTRA_ARGS= VSCODE_GIT_ASKPASS_MAIN=c:\Users\lukas\AppData\Local\Programs\Microsoft VS Code\resources\app\extensions\git\dist\askpass-main.js VSCODE_GIT_IPC_HANDLE=\\.\pipe\vscode-git-3c257e6a92-sock VSCODE_INJECTION=1 GOROOT=C:\Users\lukas\.xgo\go-instrument-dev\go1.22.1_C_in_go_5dd13d4a\go1.22.1 PATH=C:\Users\lukas\.xgo\go-instrument-dev\go1.22.1_C_in_go_5dd13d4a\go1.22.1\bin;C:\installed\go1.22.1\bin;C:\Program Files (x86)\Intel\Intel(R) Management Engine Components\iCLS\;C:\Program Files\Intel\Intel(R) Management Engine Components\iCLS\;C:\Windows\system32;C:\Windows;C:\Windows\System32\Wbem;C:\Windows\System32\WindowsPowerShell\v1.0\;C:\Windows\System32\OpenSSH\;C:\installed\go1.22.1\bin;C:\cygwin64\bin;C:\Users\lukas\.xgo\bin;C:\Projects\gopath\bin;C:\Projects\gopath\bin;C:\Users\lukas\scoop\shims;C:\Users\lukas\AppData\Local\Microsoft\WindowsApps;C:\Users\lukas\AppData\Local\Programs\Microsoft VS Code\bin GOCACHE=C:\Users\lukas\.xgo\go-instrument-dev\go1.22.1_C_in_go_5dd13d4a\build-cache XGO_COMPILER_BIN=C:\Users\lukas\.xgo\go-instrument-dev\go1.22.1_C_in_go_5dd13d4a\compile.exe]
2024-03-25 17:55:27 command dir:
2024-03-25 17:55:27 command executable path: C:\installed\go1.22.1\bin\go.exe
2024-03-25 17:55:27 finished successfully

I try --log-debug but got same error without extra information

I see you are using sudo, can you run it without sudo?

I see you are using sudo, can you run it without sudo?

It got same error.

And I'm curios that there is sudo for windows? Is it built in?

And I'm curios that there is sudo for windows? Is it built in?

no. I install it by scoop install busybox

Is there any debug.log?

Your shell is busy box? Maybe I can install that on my local machine and try to reproduce

Your shell is busy box? Maybe I can install that on my local machine and try to reproduce

No, It just a tool sets named busybox

Your shell is busy box? Maybe I can install that on my local machine and try to reproduce

Yes I found it:
2024-03-25 19:38:20 start: [C:\Users\admin\.xgo\bin\xgo.exe exec --log-debug go version]
2024-03-25 19:38:20 runtime.GOOS=windows
2024-03-25 19:38:20 runtime.GOARCH=amd64
2024-03-25 19:38:20 runtime.Version()=go1.20.5
2024-03-25 19:38:20 os exe suffix: .exe
2024-03-25 19:38:20 os force copy unsym: true
2024-03-25 19:38:20 effective GOROOT: C:\Users\admin\scoop\apps\go\current
2024-03-25 19:38:20 go version: go1.20.5
2024-03-25 19:38:20 instrument dir: C:\Users\admin\.xgo\go-instrument\go1.20.5_C_Us_ad_sc_ap_go_cu_90061880
2024-03-25 19:38:20 current revision: 1.0.6 a90c6ef098ea021488a507ab255b738b8712c3be_DEV_2024-03-25T11:38:16Z BUILD_103, last revision:  from file C:\Users\admin\.xgo\go-instrument\go1.20.5_C_Us_ad_sc_ap_go_cu_90061880\xgo-revision.txt
2024-03-25 19:38:20 revision changed, reset C:\Users\admin\.xgo\go-instrument\go1.20.5_C_Us_ad_sc_ap_go_cu_90061880
2024-03-25 19:38:21 sync goroot C:\Users\admin\scoop\apps\go\current -> C:\Users\admin\.xgo\go-instrument\go1.20.5_C_Us_ad_sc_ap_go_cu_90061880\go1.20.5
2024-03-25 19:38:22 patch compiler at: C:\Users\admin\.xgo\go-instrument\go1.20.5_C_Us_ad_sc_ap_go_cu_90061880\go1.20.5
2024-03-25 19:38:22 finished with error: exit status 1

Huh, maybe the line revision changed is an indicator.Normally it should take some seconds to finish.
I guess your directory is not writable.
Can you try to put add a line into `

I know exactly which line caused the problem. I'll fix it.
It seems there were something blocking windows from using an existing go runtime.
Let me deliver a fix quickly.

I know exactly which line caused the problem. I'll fix it.
It seems there were something blocking windows from using an existing go runtime.
Let me deliver a fix quickly.

It's because when patching the runtime code, xgo will invoke go to run $GOROOT/src/cmd/compile/internal/typecheck/mkbuiltin.go.
The implementation that causes this problem is the go being used is inside ~/.xgo/go-instrument/GOROOT, which is incomplete due to some reason.
The incompleteness is caused by this line:
dstFile := filepath.Join(goroot, "src", "runtime", "xgo_trap.go")
...
content = bytes.Replace(content, []byte("//go:build ignore\n"), nil, 1)

We are using \n, however on windows this should be \r\n.
So to fix this issue:

check "\r\n" instead of "\n" on windows,
using original GOROOT instead of instrumented GOROOT to run mkbuiltin.go.

@WAY29 Thanks for following on this issue, I've made another commit https://github.com/xhd2015/xgo/commit/c5d26155557db3f039bbf0c92c4da64e34143738
You can git pull and build it again, and run xgo exec go version to test again.

Got another error:
❯ xgo test --log-debug -run TestMethodMock -v .\mock_tcp_conn\
# github.com/jtolds/gls
C:\coding\golang\src\gotest\__xgo_autogen_register_func_info.go:2:6: internal compiler error: LookupRuntime: can't find runtime.__xgo_trap
https://go.dev/issue/new
# github.com/agiledragon/gomonkey/v2/creflect
C:\coding\golang\src\gotest\__xgo_autogen_register_func_info.go:2:6: internal compiler error: LookupRuntime: can't find runtime.__xgo_trap

Please file a bug report including a short program that triggers the error.https://go.dev/issue/new
# github.com/xhd2015/xgo/runtime/functab
..\..\pkg\mod\github.com\xhd2015\xgo\runtime@v1.0.6\functab\functab.go:169:6: internal compiler error: LookupRuntime: can't find runtime.__xgo_retrieve_all_funcs_and_clear

Please file a bug report including a short program that triggers the error.https://go.dev/issue/new
# github.com/smartystreets/assertions/internal/go-render/render
C:\coding\golang\src\gotest\__xgo_autogen_register_func_info.go:2:6: internal compiler error: LookupRuntime: can't find runtime.__xgo_trap

Please file a bug report including a short program that triggers the error.https://go.dev/issue/new
# github.com/smartystreets/assertions/internal/oglematchers
C:\coding\golang\src\gotest\__xgo_autogen_register_func_info.go:2:6: internal compiler error: LookupRuntime: can't find runtime.__xgo_trap

Please file a bug report including a short program that triggers the error.https://go.dev/issue/new
# golang.org/x/arch/x86/x86asm
C:\coding\golang\src\gotest\__xgo_autogen_register_func_info.go:2:6: internal compiler error: LookupRuntime: can't find runtime.__xgo_trap

Please file a bug report including a short program that triggers the error.https://go.dev/issue/new
# testing
C:\Users\admin\.xgo\go-instrument\go1.20.5_C_Us_ad_sc_ap_go_cu_90061880\go1.20.5\src\sync\atomic\type.go:43:6: internal compiler error: LookupRuntime: can't find runtime.__xgo_get_test_starts

Please file a bug report including a short program that triggers the error.https://go.dev/issue/new
FAIL    gotest/mock_tcp_conn [build failed]
FAIL

Lol 😂 another fix: https://github.com/xhd2015/xgo/commit/42bc8080ae3bca80a1f32b5d60bead4a55ea942c
Please git pull and try again

Work well.

Thanks for your patience, the bugs found were so meaningful haha.


Permissions explanation.

Hello! Why does the plugin require "Download files and read and modify the browser’s download history"? All the other permissions I get for a plugin of this nature, but don't get this one. It is holding me back from trying it.
Thanks!

Extension Permissions

Tabs: Access to your tabs proprieties for saving them among the groups
Storage: Save your groups on disk for not losing them when quitting
Notifications: Giving you feedback
Context Menu: Adding elements on right click on tabs and the extension icon
Sessions: Find which group is in a window even after restarting Firefox
Downloads: Save your groups in a file for exporting and doing backup.

It is for saving on the disk.

You can check browser.downloads in this repo to see where it is used.


Doesn't respect existing anchors

I have part of the readme generated by jsdoc-to-markdown and it creates it's own anchors for each function, like this:

#### footprint.activate() ⇒ void

Although toc-md detects it as a header and adds it to the list,
it refers to different anchors (that don't exist on the page).
    - [footprint.activate() ⇒ void](#footprintactivate--codevoidcode)

Would nice to recognize existing markers to use them for the reference.
Thank you.

Hi! It is a bug!
The header
#### footprint.activate() ⇒ void
should be displayed is a TOC as
 - [footprint.activate() ⇒ void](#footprintactivate--void)

Although toc-md detects it as a header and adds it to the list...

If you do not want to display a header in a TOC you can ignore it, see the docs.

A little bit more detail description can be found in another comment.

(Copying it over)
Let's focus on one of the headers that ends up in the TOC, for example this one:

#### footprint.transport ⇒ void

after I run toc-md I get following reference to this header at the top of my file:
- [footprint.transport ⇒ void](#footprinttransport--codevoidcode)

As you can see it references #footprinttransport--codevoidcode anchor, assuming that Github and NPM would generate it while rendering markdown into HTML.
But there is another anchor already present on the page for this header – name="Footprint+transport",
so it would be nice if toc-md could recognize it and use it instead of auto-generated one.
So TOC would look like following:
- [footprint.transport ⇒ void](#Footprint+transport)

PS. Also, this is internal project and we're using Stash, not Github, so md->html rendering is a bit different.
I hope it helped.
Thank you.


Multi-gpu is taking more time than single gpu

I tried running the downstream ASR model using both single-gpu and multi-gpu (DDP) settings:
Single-gpu command:
python3 run_downstream.py -m train -n asr_tera -u tera -d asr
Multi-gpu command:
distributed="-m torch.distributed.launch --nproc_per_node 4";
python3 $distributed run_downstream.py -m train -n asr_tera_ddp -u tera -d asr -o config.runner.gradient_accumulate_steps=2

However, the multi-gpu code is taking more time than the single-gpu one.
Time taken by multi-gpu setting: ~6 days (using 4 gpus)
Time taken by single-gpu setting: ~3 days (using 1 gpu)
Do you have any idea as to why is this happening? Have you tested the code using DDP?

Hey,
Sorry for the unclear documentation. We do not automatically decrease the total training steps so you will need to also override the config.runner.total_steps to get faster training.
In you case, if the original total_steps if 200000, then you can use
-o config.runner.gradient_accumulate_steps=2,,config.runner.total_steps=100000

Hope this help!

Hi, I tried running the downstream ASR experiment (using the same pre-trained model ckpt) in single-gpu (200000 steps) and multi-gpu (100000 steps) settings. However, there is a large gap in the results (WER) obtained in both the experiments on Libri test-clean set: ~2.0 (without LM) and ~1.5 (with LM). Any comments on this performance difference?

Hi just to make sure we are on the same page.
Can we provide the detailed configs between two experiments in the following format?
eg.
num GPU=?
gradient_accumulate_steps=?
total_steps=?

vs
num GPU?
gradient_accumulate_steps=?
total_steps=?

Hi, here is the detailed config used in both the settings:
Single GPU:
num GPU=1
gradient_accumulate_steps=1
total_steps=200000
batch_size=12
test-clean wer=18.18

Multiple GPUs (DDP):
num GPU=2
gradient_accumulate_steps=2
total_steps=100000
batch_size=6
test-clean wer=20.01

Hi,
Sorry for the late reply, and thanks for the detailed information!
In my point of view, the following two settings should be equivalent:
num GPU=1
gradient_accumulate_steps=1
total_steps=200000
batch_size=12

vs.
num GPU=2
gradient_accumulate_steps=1
total_steps=200000
batch_size=6

or
num GPU=1
gradient_accumulate_steps=2
total_steps=100000
batch_size=12

vs.
num GPU=2
gradient_accumulate_steps=1
total_steps=100000
batch_size=12

The above two comparisons are equivalent. However, the comparison setting you share is not equivalent in my point of view, since the second one actually uses large effective batch size (24) and fewer steps (100000). In practice, usually we use larger batch size to get more accurate gradient so that the training converges faster and requires fewer steps. However, this does not mean that 2x batch size & 0.5x training steps is mathematically equivalent to 1x batch size & 1x training steps. In your case, it seems larger batch size does not help or even get worse WER. In my experience, our ASR setting won't benefit from larger batch size which kind of aligning to your results.
Hence, the above result does not look very weird to me. Please feel free to point out my mistake if you think I am wrong. Thanks!
Sincerely,
Leo

Hello, is it okay to reduce training steps if I use multi gpu then?
i.e. is it equivalent setting?
num GPU=2
gradient_accumulate_steps=1
total_steps=100000
batch_size=12
vs
num GPU=1
gradient_accumulate_steps=1
total_steps=50000
batch_size=12
Best reagrds,
Kangwook


faust2jaqt: make it work again

My update from 2.5.23 to 2.20.2 broke this pkg, this commit fixes it.

Motivation for this change
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

Doing random review.
For me, this package's binaries don't work at all, in all versions that I checked (release-19.09, master, and this PR). Here is what I see in all cases:
> faust2jaqt
which: no qmake-qt5 in (... a long list of directories ...)
which: no qmake-qt4 in (... a long list of directories ...)

However, if I try to run faust2jaqt in a pure nix-shell environment, the result is different.
In release-19.09:
$ faust2jaqt
/nix/store/ysqw6aqgxc61albr5j3papksnjcdp3hb-faust2jaqt-2.5.23/bin/.faust2jaqt-wrapped: line 39: which: command not found
/nix/store/ysqw6aqgxc61albr5j3papksnjcdp3hb-faust2jaqt-2.5.23/bin/.faust2jaqt-wrapped: line 39: which: command not found

In master:
$ faust2jaqt
sh: which: command not found
sh: which: command not found
sh: which: command not found
/nix/store/i8v9bask59xs22sfgv882414lc6psyyd-faust2jaqt-2.20.2/bin/.faust2jaqt-wrapped: line 29: which: command not found
/nix/store/i8v9bask59xs22sfgv882414lc6psyyd-faust2jaqt-2.20.2/bin/.faust2jaqt-wrapped: line 29: which: command not found

With this PR:
$ faust2jaqt
which: no qmake-qt5 in (... a long list of directories ...)
which: no qmake-qt4 in (... a long list of directories ...)

@pvgoran Thanks for the review!
These faust scripts are all compilers, so they need a file to compile:
touch tst.dsp
echo "process = +;" > tst.dsp
faust2jack tst.dsp
./tst

Note that I used faust2jack and not faust2jaqt  since for some of these scripts there is, as you noted, a difference  between running them in nix shell or not, see https://github.com/NixOS/nixpkgs/issues/78610
To test  faust2jaqt, you need to run it from inside a suitable nix-shell.
I use
nix-shell --command zsh $NIXPKGS -A magnetophonDSP.faustCompressors

but guess/hope you found a simpler and more generic command; I'm quite new to nix-shell.
What did you use to get in a suitable shell?

The latest faust release has a bug, causing it not being able to compile a lot of code.
This fixes that.

Closed in favour of these PR's, which have more granular commits with better messages:
https://github.com/NixOS/nixpkgs/pull/82650
https://github.com/NixOS/nixpkgs/pull/82652


add command queue for windows

Objective
Draft PR of #4530

separating Window into components seems pretty simple except for Window::set_resolution and Window::set_scale_factor_override that use requested_width/requested_height

I love the idea behind the PR. I like the code at least. Looking forward to the completion of the PR.

separating Window into components seems pretty simple except for Window::set_resolution and Window::set_scale_factor_override that use requested_width/requested_height

@fowenix for this, I think I would probably just do a Resolution component:
struct Resolution {
   physical_width: u32,
   physical_height: u32,
   scale_factor: f64,
}

And then move those methods to methods on the new Resolution component :)


automate deployment

hey,
attempts to address #10
not really sure what sort of strategy you specifically want here, just added the settings ive used for other projects

you'll need to add a user/password for pypi and an api key for github releases
i set it to prerelease since the current version number is 0.2.2

Closing this PR since we no longer use Travis CI. Thank you for your help nevertheless!


Eval command doesn't work properly

Scripting.zip
When I bother execute this command:
dotnet script eval main.csx

I get an error:
(1,1): error CS0103: The name 'main' does not exist in the current context

Is it my error or bug?

eval is supposed to be used when passing inline C# code, not with a script file. to run a script just invoke `dotnet script main.csx‘


mean_table - Add ttest and Anova

Figure out a way to get common hypothesis testing statistics and other related info (e.g., sum of squares) from a mean_table. May be an enhancement to mean_table, but it will probably be a separate function called on the results of a mean_table

Make function wrappers that work statistics I commonly need into a dplyr pipeline (chi-square, fisher, ttest, even regression)
Chi-square should not add onto mean_table. It should create a new separate stats table, but think of a way to make it easily transfer information about significance back and forth (e.g., joins).

After you've added in hypothesis testing here and in #14, then change the version number for bfuncs to 0.3.


Range GET requests are not supported by the copy source

It looks like we have a problem with Range GET requests. #85

Looks like an undocumented requirement. I get why it's there but I think it should be removed

The winget cli supports range requests.
A manifest that specifies a Url that references a web server that doesn't support range requests/streams will correctly fail-over to download, as per https://github.com/microsoft/winget-cli/blame/cc7904cd23bf1cdb1178a9dd8e634edf82d51e68/src/AppInstallerCLICore/Workflows/InstallFlow.cpp#L124.
The validation-pipeline.yaml is the pipeline that appears to be broken, as far as I can tell it's the 'Installers Scan' task.  I'm not really familiar with Azure pipelines but it appears to be calling executables/functions that haven't been open sourced.  Otherwise I would have attempted to find and fix the problem and sent a PR.
An example of a manifest that passes local validation but fails the pipelines is HeidiSQL.
PS C:\devel\winget\winget-pkgs> winget install -m manifests\AnsgarBecker\HeidiSQL\<IP_ADDRESS>19.yaml Found HeidiSQL [AnsgarBecker.HeidiSQL] This application is licensed to you by its owner. Microsoft is not responsible for, nor does it grant any licenses to, third-party packages. Downloading https://www.heidisql.com/installers/HeidiSQL_<IP_ADDRESS>19_Setup.exe   ██████████████████████████████  22.1 MB / 22.1 MB Successfully verified installer hash Installing ... Successfully installed!
This can be found failing here: https://github.com/microsoft/winget-pkgs/pull/1914
The output from the 'Installers Scan' is here: https://dev.azure.com/ms/winget-pkgs/_build/results?buildId=90013&view=logs&j=c8020aa5-4aab-5881-691f-21986e02afd0&t=bade86d6-d2be-5ddd-c1b9-7d8db9c4a60d&l=41
I don't want to minimise the issue, obviously range requests have been around for quite a while, but we can't expect everyone to renovate their server infrastructure.  The winget cli supports failing over, so drop these failures down to warnings and move on?

@denelon Is the milestone for this issue correct please prioritise since a lot of packages can't be added to winget because of this issue.

@floh96 We've been independently working milestones between the client and the services behind this repository. The fix for this was just pushed into production. We're going to re-run and validate all of the PRs to see how many of them will complete now before closing this issue.

@floh96 We've been independently working milestones between the client and the services behind this repository. The fix for this was just pushed into production. We're going to re-run and validate all of the PRs to see how many of them will complete now before closing this issue.
Heidi SQL #950 just passed validation. Thanks for fixing this.

It looks like all of the issues with "Range Get requests" are passing now.  I'm going to go ahead and close this issue. Feel free to open it back up if anything else fails due to this reason.


Suggestion

if they have a payment attached have it auto buy nitro

I am actually against it. What if someone tried to test the program and bought nitro because of that. That'd be a problem