CSV Exports filename should be in ISO date format

Todays it's looking like znarf--20200202000200-20200430130485.csv
It would be clearer if it was znarf-2020-02-01-2020-04-30.csv or znarf-from-2020-02-01-to-2020-04-30.csv.

The dates are also incorrect. The to date has inadvertently an extra month added:
2020-01-01 to 2020-01-31 is exported as
2020-01-01 to 2020-02-31 (without any data from February in there).

I can give it a try at this one if no one is already working on this. :smile:

Here I've done a pull request to change the filename structure to reflect sudharaka-from-2020-02-01-to-2020-04-30.csv format.
@SleeplessByte : Within the generated CSV files it seems that we generate the date times in YYYY-MM-DD format. Example,
Transaction Description,User Name,User Profile,Transaction Date,Collective Currency,Host Currency,Transaction Amount,Host Fee (USD),Open Collective Fee (USD),Payment Processor Fee (USD),Net Amount (USD),Subscription Interval,Order Date
"$100 bug bounty claim for https://github.com/jhipster/generator-jhipster/pull/9509","Vishal Mahajan","http://opencollective.com/vishal423",2019-04-26 01:58:35,"USD","USD",-100.00,0.00,0.00,-5.55,-105.55,"one time","2019-04-26T08:58:35.000Z"
"Monthly financial contribution to JHipster (Backer)","Ergon TI SpA","http://opencollective.com/ergon-ti",2019-04-24 18:10:30,"USD","USD",2.00,-0.10,-0.10,-0.38,1.42,"month","2019-04-25T01:10:30.000Z"
"Monthly financial contribution to JHipster (Backer)","Jaime Freire Sáenz de la Calzada","http://opencollective.com/jaime-freire-saenz-de-la-calzada",2019-04-24 16:57:57,"USD","USD",2.00,-0.10,-0.10,-0.38,1.42,"month","2019-04-24T23:57:57.000Z"

So I am not sure exactly where within the CSV file we generate it in MM/DD/YYYY format. Can you provide an example by any chance? :thinking: :thinking:

@SleeplessByte can you give us an example of MM/DD/YYYY within the file?

Of course. So the CSV seems okay, the receipts are not:

https://opencollective.com//transactions
Get receipts

(I'm okay sharing this "personal" information).
derk-jan_opensource_2020-01-01_2020-02-31 (2).pdf
Check the filename, and the issue with the dates insides.

@SleeplessByte : Thanks for the information.
I've made two more pull requests in addition to the csv file name change;

To change the file name of the generated transactions pdf files; it should now have the format similar to the csv; derk-jan_opensource-from-2020-01-01-to-2020-02-31.pdf

To change all dates within the transactions pdf file to have the format YYYY/MM/DD.

I hope this helps. :smile:

It helps a lot. The datesTo is still incorrect for the pdfs. The format is now correct, but the value is not. The generated file: derk-jan_opensource_2020-01-01_2020-02-31.pdf should have been:
derk-jan_opensource_2020-01-01_2020-01-31.pdf
- derk-jan_opensource_2020-01-01_2020-02-31.pdf
+ derk-jan_opensource_2020-01-01_2020-01-31.pdf

@SleeplessByte : The pull requests I've made are not merged yet. You will only see the changes reflected after they are reviewed, merged and new deployment is done. 🙃

I meant: I didn't see the date fixed in the PRs ;)

@SleeplessByte : Ah, got it; sorry I misunderstood. I'll do some more tests on why the month has a problem and will try to fix it. :thinking:

Okay, I've found the root cause of the wrong value in the filename as well. Just made a commit to #4112 which should take care of it. So to summarize I have three PRs related to this issue;

https://github.com/opencollective/opencollective-frontend/pull/4098 : I am not sure if this is needed or not since the issue is not about CSV files as we initially thought but rather about PDFs.

https://github.com/opencollective/opencollective-frontend/pull/4112 : Fixes the filename issue of the transactions PDF file.

https://github.com/opencollective/opencollective-pdf/pull/356 : Converts all dates within the transactions PDF file to international format.

Feel free to let me know if there's any further suggestions. :smile:


App reject / non-public api imageWithName/nextStartIndex

Hi,
our iOS app was recently rejected for using/referencing the following non-public APIs:

imageWithName
nextStartIndex

I sent the app few times and I sued the latest release of this plugin and also the dev branch but nothing changed.
To my understanding this was fixed by Google in version 1.13.2 (See issue):
https://code.google.com/p/gmaps-api-issues/issues/detail?can=2&start=0&num=100&q=&colspec=ID Type Status Introduced Fixed Summary Stars ApiType Internal&groupby=&sort=&id=9704
How I can fix it ?
Thanks.

Merge into #1047


module 'webdriver_manager' has no attribute 'update'

golem-admin createdirectory testdir
New golem test directory created at D:\golem_Project_9.2\testdir
Use these credentials to access the GUI module:
user:     admin
password: admin
Would you like to download ChromeDriver now? [Y/n]Y
Traceback (most recent call last):
appdata\local\programs\python\python38-32\lib\site-packages\golem\cli\commands.py", line 238, in createdirectory_command
webdriver_manager.update('chrome', drivers_folder)
AttributeError: module 'webdriver_manager' has no attribute 'update'
latest webdriver_manager not support update attribute.

User need to install py-webdriver-manager
using pip install py-webdriver-manager
then webdriver_manager.update('chrome', drivers_folder)  will work and download the driver in drivers_folder.


Do not depend on assemblage, please

Assemblage is not released, so this will make very difficult to release the project properly. Maybe include the generated Makefile directly?

Yeah that is what the no-assemblage branch is for -- although it is not at all up to date at the moment.

Could this be tackled please.

It what way? Updating the no-assemblage branch, or switching to another build system?
I was just going to leave it as is until I get around to trying to release this library properly.

It what way? Updating the no-assemblage branch, or switching to another build system?

Whatever. It would be nice if we can pin the repo without having to maintain a pin to a specific assemblage version.

I think that updating the no-assemblage branch would be sufficient for that. That assumes that opam can pin a specific branch in a repo.

Does it really have to be that complicated ? Besides you will need to keep master and no-assemblage in sync or you will forget to do so and I will be annoying for us.

 I'll still need to keep things in sync but meh.

Should now be fixed

Thanks !

You forgot to update the opam file.

Fixed


feat(CategoryTheory): constructor for pseudofunctors from a strict locally discrete category

In this file, we define a constructor pseudofunctorOfIsLocallyDiscrete for the type Pseudofunctor B C when C is any bicategory, and B is a strict locally discrete category. Indeed, in this situation, we do not need to care about the field map₂ of pseudofunctors because all the 2-morphisms in B are identities.

Thanks @callesonne for the review!

Thanks :tada:
bors merge


feat: relate lists and infinite sequences

Transfer basic API on lists (append, take etc) to infinite sequences.
Taken from https://github.com/sven-manthe/A-formalization-of-Borel-determinacy-in-Lean

You might want to implement these operations on Stream' instead.

Indeed, all definitions and most lemmas are already there for Stream'. I'm not sure how to use this in relation to my project (when I started, I also created a def ... := ℕ → A and was told that using ℕ → A directly would be more coherent with mathlib style. However, the existence of Stream' suggests that these operations should not be available for sequences). A rather extreme change for my project would be the following, would this be considered appropriate for mathlib?: Register a global TopologicalSpace instance on Stream' given by the product of the discrete topologies (even if the underlying type has a nondiscrete topology). Then define bodies of trees, hence payoff sets of Gale-Stewart games as sets of Stream', not of sequences. Finally, relate those to PiNat/CantorScheme using the homeomorphism id.

I think it'd make more sense to register the product topology on Stream, and separately, define a type alias (if it doesn't already exist) to give a type the discrete topology.

I indeed switched to Stream' for my project and thus will PR more API on that (after a short discussion I decided to use a scoped instance for the product of the discrete topologies on Stream' to avoid the meaningless typeclass arguments throughout).


History re-write: commit sign off

Rewrite history and add correct sign off message to all commit messages
Signed-off-by: Author Name<EMAIL_ADDRESS>

https://stackoverflow.com/questions/3690049/rewriting-git-history-how-do-i-remove-a-sign-off
https://git-scm.com/book/en/v2/Git-Tools-Rewriting-History

Via https://github.com/newren/git-filter-repo
git-filter-repo --message-callback '
  if b"Signed-off-by:" not in message:
    message += b"\nSigned-off-by: Me My<EMAIL_ADDRESS>  return re.sub(b"[Ee]-?[Mm][Aa][Ii][Ll]", b"email", message)'

https://htmlpreview.github.io/?https://github.com/newren/git-filter-repo/blob/docs/html/git-filter-repo.html#CALLBACKS

it has been done. :wink:


JS: add command line arguments as a source for js/command-line-injection

This adds a command line arguments as a source for command line injections. This may sound like a trivial source of false positives, since the user probably is the one to type the command in the first place.
I am open to converting this to a separte command line injection query since its alerts are harder to exploit than the alerts from the ordinary js/command-line-injection. Personally, I even think that the alerts are more likely to result in spurious failures when the user accidentally includes a meta-character in otherwise benign arguments.
Security people do care about this however, since it effectively bypasses any quotation mechanisms used by the user. It may for instance be used to escalate a path injection vulnerability, if the injected file name later is used as a command line argument. Consider this example from https://hackerone.com/reports/390631:
$ ascii-art preview 'doom"; touch /tmp/malicious; echo "'

Which is vunerable due the following concatenation in the implemenation of ascii-art:
exec('open "http://www.figlet.org/fontdb_example.cgi?font='+target.toLowerCase()+'.flf"')

Similar PoCs by me can be seen here: https://git.semmle.com/gist/esben/674823c3703d85c2c6f59ccbe4b2a9fc
The full evaluation contains several results in prominent projects.

OK,  I will turn it into a separate query.

I have extracted this into a warning, medium, security query. The results will therefore not be displayed by default for now.
Performance is practically unchanged when js/command-line-injection is run with/without this new query, I hypothesize that the low number of sources for this query is the cause.

For example, many of the results in the evaluation involve command line arguments called cmd being interpreted as commands which sounds very deliberate.

I agree that this can be the case, but it is still dubious because even a well-meaning programmer may not realize that a cmd argument like my$java$class.class will cause two shell substitutions. We try to whitelist for trivial developer utilities by ignoring results with direct propagation of command-line parameters to the sinks.
For the record, one of the cmd results you saw is a TP of the form: let cmd = "node " + someConfigPath + " --module commonjs " + filesFromCommandLine.join(" ");, filesFromCommandLine is obviously not supposed to be executed
I have not added a change note yet, let me know if you think this should make it to 1.21.

Rebased on master, ready for 1.22.

Two hackerone examples, as an argument by authority for usefullness: https://hackerone.com/reports/390631, https://hackerone.com/reports/388936.

All comments have been addressed. Let me know if you are still unsure of the usefulness of the query.

I have redone the documentation for the query. See the latest commit.

Needs a rebase.

I have overhauled the qhelp file. I think it addresses all of your concerns.

Comments addressed.

@mc-semmle, a gentle reminder: this pr is waiting for a doc review

@xiemaisi - apologies I must have missed the notification about this PR

ps - I couldn't check the preview as it's no longer available (but it's totally my fault).

Comments addressed (https://github.com/Semmle/ql/pull/1015/commits/bbd4fb553c4ef2a2cf9696303c7f3164b5ff235d)

One of them is that I thought that any existing CWE that were defined in the ql file would automatically add links to the relevant CWE on the MITRE website in the qhelp file, but maybe I'm wrong.

They are added to the compiled qhelp file,if the preview had been available, you would have seen them.

@esben-semmle - Ah, yes, you are right.
LGTM, thanks for the updates.

@esben-semmle - I haven't been able to approve this PR for some reason, but I am happy with it from my point of view.

That should be it. Sorry for the rebases in the end, the similarly named files are easy to mix up.

Since you're rebasing anyway, could you clean up the commit history a bit? Just squashing everything down into a single commit would be fine with me.

Squashed


Provide a means to inform ReactCrop when custom media has loaded #319

Might be of interest @rgreen312


[BUG] Cannot view profile of author of Tweet

Describe the bug
When trying to view the author of a Tweet, sometimes the app will simply be unresponsive.
To Reproduce
Steps to reproduce the behavior:

Go to Feed.
Click on  a "Replying to."
Click on author's profile image and username.
Nothing happens.

Screenshots
https://user-images.githubusercontent.com/25624882/126406684-2407ea8e-32a8-49f3-b13a-4c0ec9d281fa.mp4
Device
Pixel 3a
Android 11
v2.13.0+20210716

This should be fixed in 62c9874652a1c19ff32424e26a22fc401ae53213, and will go out in v2.15.0!

Great!
On Fri, Oct 1, 2021, 1:45 PM Jonjo McKay @.***> wrote:

This should be fixed in 62c9874
https://github.com/jonjomckay/fritter/commit/62c9874652a1c19ff32424e26a22fc401ae53213,
and will go out in v2.15.0!
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/jonjomckay/fritter/issues/201#issuecomment-932432608,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AGDQCMTT4TK2QPV36E44C73UEXXSZANCNFSM5AWZXTTQ
.


global declaration of prior may be messing up multiple runs of rail_bpz

Currently DESC_BPZ handles the prior calculations by creating a dictionary, declaring it as a global, and then every time the prior is calculated, it round the input magnitude to 1 decimal and saves the prior in the dictionary and checks the dict for an existing value rather than recalculating to save some time.  If you run BPZ twice with different priors, e.g. in a jupyter notebook, the global prior dict will report the first run through of values rather than recalculate.  So, we need to either reset that dictionary after BPZ is run, or replace the use of prior_with_dict from DESC_BPZ with prior_function and not save the prior calculations.  Given that removing the dictionary storage looks to only increase runtime by ~15-20% and my not really liking globals floating around that are a little harder to keep track of, I'm leaning towards just removing the global dict.

Another couple small bugs I noticed while making the demo notebook: I forgot that the likelihoods for bright galaxies with mag > m0 can screw up the calculation of the type fractions.  BPZ priors usually set mag < m0 values to m0, so I'll add a line that does that.  Also, the minimizer occasionally sets a type fraction negative when exploring parameter space, so I'll put in an if statement to not take the log of those negative probs and avoid a NaN that pops up.  I'll lump these in with the change over to the prior_function in the code.

closed by #20


PUD 253 Capture recall email date-time with PACT workaround

Supersedes prior approved https://github.com/ministryofjustice/manage-recalls-ui/pull/88

Closing.  PACT rule by-passed on Jon's PR.  PACT passed locally.


chore: lets disable checks by default and enable desired ones using helm values

/approve

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: rawlingsj
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rawlingsj: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

pr-bot-check
f5e8094fea1cc65f2deb0ea7303150bd60ce7be8
link
/retest

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository. I understand the commands that are listed here.


totalMemoryPool is truncated to 32 bits

with heap set to 50gb seeings lots of errors like this
Jul 17, 2015 3:18:14 PM WARNING: org.apache.parquet.hadoop.MemoryManager: Total allocation exceeds 95.00% (2,147,483,647 bytes) of heap memory
this is because the ratio passed into calculate the total memory is a float which when used is causing the long value to be truncate to max int32.
Fix this by making it a double instead
Reporter: Chris Bannister / @Zariel
Assignee: Chris Bannister / @Zariel
Note: This issue was originally created as PARQUET-340. Please see the migration documentation for further details.

Chris Bannister / @Zariel:
resolved by pull request, https://github.com/apache/parquet-mr/pull/246
A better solution would be to type the ratio to a double but that requires API change and version of Hadoop doesnt have getDouble

Julien Le Dem / @julienledem:
+1 thanks!

Julien Le Dem / @julienledem:
Issue resolved by pull request 246
https://github.com/apache/parquet-mr/pull/246


Payload too large returned when storing trees

I am parsing Java files, producing ASTs and storing them. The operation fails because I get the answer 413 Payload Too Large. I get it on most ASTs. The smallest size causing problems that I noticed is 171461 bytes.
I think we should support much larger files. I had in the past files in the tens of megabytes, that I would expect to be able to store in the repository.

Note that a Java file of 64 bytes, when parsed produce an AST that serialized to JSON takes 14317 bytes. In other words it is 224 times larger than the original file.
So our format is not particularly efficient :D

Something like app.use(express.bodyParser({limit: '50mb'})) in the server should solve this.

On my side, I will see if I can enable zipping the payload

@ftomassetti Any luck yet?

@joswarmer not yet. I tried some experiments with compression but I have issues activating the compression on the server side. The header Content-Encoding seems not to arrive to the server. I hope to be able to play with this a lit bit more.
On the positive side gzip seems to reduce by 20 times the size of the payload


[ADD] Replace metadata with extra_info in step function

Only review after #5.

Would it be helpful to support both fixed metadata and data that changes every step?

Not sure if having both is a good thing complexity-wise, one can simply pass meta-data via extra_info and achieve the same.


Cell dropdown not visible on smaller resolutions

See screenshot: If you use the modeler on a smaller resolution you cannot access the Expression Language Box in the menu. I moved a row up to access it, but then I cannot select JUEL (too far down in the list).

Not an issue in latest dmn-js.


borken url: Clear Linux staless docs

Description of problem
https://clearlinux.org/features/stateless is not longer working, lets update the docs
Expected result
Point to as probably a more stable URL.
https://github.com/clearlinux/clr-man-pages/blob/master/stateless.7.rst

:heart:  it - borken is my favourite word of the week! :laughing:

🤔 why did people change their URLs in this week together?

I have no idea :smile: It's good to know the URL checker is actually working though.
Ideally, we'd have a daily / weekly CI run on master to identify these sorts of issues faster as it would be checking all the docs in a repo, not just those that a PR changed.
Related: https://github.com/kata-containers/ci/issues/101.


Feature Request: connect a particular container in swarm

As a software developer who wants to debug issues pertaining to the application, I would like to have the capability to connect to a particular replica within a swarm network.
It will be great to have a functionality to create new endpoint/proxy to connect a particular container in swarm network. The connection can happen on Http/TCP protocol so as enable remote debugging.

This will be available with #461.
It aims to solve that issue by aggregating all the containers from all the nodes in a cluster inside the containers view.
I'll close this issue.


Pop up a conflict dialog when clicking 'Cancel' button in clone file dialog

Storage Explorer Version: 1.12.0
Build: 20200217.1
Branch: master
Platform/OS: Windows 10/ Linux Ubuntu 18.04
Architecture: ia32/x64
Regression From: Previous release(1.12.0)
Steps to reproduce:

Expand a storage account -> File Shares.
Create a new file share -> Upload a file to it.
Right click the file -> Click 'Clone with New Name...' -> Click 'Cancel'.
Check the result.

Expect Experience:
Succeed to cancel.
Actual Experience:
Pop up a conflict dialog.

More Info:
This issue also reproduces in clone directory dialog.

Can you share a recording of the repro steps? I cannot reproduce the bug with on build 20200217.1.

Hi @JasonYeMSFT
This issue still reproduces on build 20200219.2. Please see the recording.
https://web.microsoftstream.com/video/2ab9d8b0-6dbc-4b67-ab59-a9c8fe8f339c

Verified on build 20200226.4. This issue has been fixed. So we close it.


XGBoost - Documentation

I want to work on this issue as it hadn't mentioned earlier. I have great knowledge of model selection and it might be of great use here.

Task : Create detailed documentation of the XGBoost ML algorithm by updating readme.md
Level-1 : 10 points

Sure @hritikchaturvedi11  ,You have been assigned the task to create detailed documentation of XGBoost .
Try to submit a PR in 2 days.

@ashwani-rathee I want to contribute to this issue if this has not been done yet. I am a GSSoC'21 Participant.

Hey @ashwani-rathee , Please assign me this issue. I will be adding the documentation and the complete code for this model. I have plenty of knowledge about this model and can submit a PR within 36 hours.

Can I create make the README for XGBoost @ashwani-rathee @geekquad?

@surbhi2408 want to go ahead?

@surbhi2408 want to go ahead?

Yes sure


Add auth.test to supported APIs in the test server.

I'm implementing a slack bot that makes use of the auth.test API. For testing purposes in my own project (and perhaps the convenience of others), I've added support for that API call to the test server.
There are no behavioural changes to the core library, and I've added tests to cover the new handler in the style of the existing tests.
Please let me know if I've missed anything.

ahh wonderful, thanks for the imrpovement.


Working with imageSizes

Hi, I've used your plugin recently and I had a great experience so far! I've noticed that, while uploading the imageSizes  works great, Payload's API would return the local domain instead of the S3 URL (for the sizes only).
I didn't find a good solution with the hook configured on a field level. Even if the correct URL is stored in the database for a particular size, say with the help of a beforeChange hook, the url property would still be overridden on API requests.
I've found the best way to deal with this behavior is to apply the afterRead hook on the collection level instead. So here's my implemention, maybe that can be helpful to others?

Hey, thank you for your contribution!
Like for https://github.com/jeanbmar/payload-s3-upload/issues/2, it will be worth managing this in plugin code at some point.


[BUG] The .NET Aspire dashboard resource filter doesn't remove selections

When you're on the .NET Dashboard Resources tab, and you apply a filter, the selected detail view isn't reset. I would have expected that when I apply a filter that removes a resource (filters it out) that if it was previously selected for details, it would be no longer selected.
I only have Container resource types selected, however, my previous Project details view is still displayed. This isn't a huge problem, so low priority, just not the behavior I expected.

Assuming we'd like this to apply to all pages with filters and selection, not just /resources. @JamesNK in case you have any thoughts on the functionality or alternatives in those other pages.

I think this would just apply to resources and structured logs.
Traces opens a new page. Trace detail doesn't have filtering (yet)

@JamesNK Thinking more about the structured logs case:

I had the resources page only closing the details panel if the selected resource was not in the filtered list
It doesn't seem like the selected log entry being outside of the current page of data should cause the details pane to close, so
Determining if the selected log entry is still in the updated filtered list would require checking the entire (filtered) unpaged log set. Which depending on the filter could still be a very large set

Do you think it makes more sense to just always clear the selected log entry when the filter changes (and possibly change my implementation for resources to always clear as well)?


Swagger schema body payload

Informations

Type
Version

Improvement
4.x

Description
When multiple BodyParams parameters used in a method or function the Swagger generator generates a Body Payload schema dynamically with a lengthy name.  It would be helpful to have a custom schema name to be used through decorators or support a formData type instead of body type.
For example:

Controller name: AuthCtrl
Function/Method name: register
Multiple Body parameters (appId, clientId, pin)

Then, the generated schema would look like this:

Json:
"schema": {
"$ref": "#/definitions/AuthCtrlRegisterPayload"
}

Schema Definition:
{
appId: string,
clientId: string,
pin: string
}

Acceptance criterias

[ ] Example (In this situation, either there has to be a provision to have a custom name for the schema such as "Register" or alternatively to support formData type with separate params instead of JSON body type.
)

You can use Model to do that.
class AuthCtrlRegisterPayload {
  @Property()
  appId: string;

  @Property()
  clientId: string;

  @Property()
  pin: string
}

@Controller('/')
class Ctrl {
    @Post('/')
    post(@Body() payload: AuthCtrlRegisterPayload) {

    }
}

See you,
Romain

Hi Romain,
Thanks, in fact I was using it that way.
However, as this name is generated dynamically I was thinking to avoid
defining a separate class.

src/swagger/class/OpenApiParamsBuilder.ts
https://github.com/Romakita/ts-express-decorators/blob/0aeb34c2dcdf4bbdad51172fb3a63c1fb3321342/src/swagger/class/OpenApiParamsBuilder.ts
->
build()
const model = ${this.name}*Payload*;

Referring to the suggested workaround, the current working usage is with
@BodyParams() not @Body():
post(@BodyParams() payload: AuthCtrlRegisterPayload)
tell me if I'm wrong.
Regards,
DGKM
On 1 June 2018 at 21:10, Romain Lenzotti<EMAIL_ADDRESS>wrote:

You can use Model to do that.
class AuthCtrlRegisterPayload {
@Property()
appId: string;
@Property()
clientId: string;
@Property()
pin: string
}
@Controller('/')class Ctrl {
@Post('/')
post(@Body() payload: AuthCtrlRegisterPayload) {
}

}
See you,
Romain
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/Romakita/ts-express-decorators/issues/378#issuecomment-393981393,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ACmpR-qEQK0nZAvz4cNq05QmLFZltYzpks5t4ZGWgaJpZM4UXKrB
.

--
Thanks,
Keshav

Yes it's BodyParams, sorry :)
You've right, for BodyParams without model, the name is generated automatically.
For example:
@Controller('/')
class Ctrl {
    @Post('/')
    post(@BodyParams('clientId') clientId: string, @BodyParams('appId') appId: string) {

    }
}

This example will generate a custom model name for swagger

Other example:
@Controller('/')
class Ctrl {
    @Post('/')
    post(@BodyParams('test') model: MyModel, @BodyParams('test2') model2: MyModel2) {

    }
}

This example will generate a custom model name for swagger

But to avoid that you can create a model:
class MyPostPayload {
   @Property()
   model: MyModel;

   @Property()
   model2: MyModel2;
}

@Controller('/')
class Ctrl {
    @Post('/')
    post(@BodyParams() payload: MyPostPayload) {

    }
}

this example will use the MyPostPayload as swagger name.

But If this example does not fit your case, I need some example code like my previous examples.
See you,
Romain

Hi Romain,
Great!!.  for PUT/POST methods having consumption type "application/json"
and/or with complex objects, then the proposed solution works perfectly
alright.  Thanks for the same.
There is another use case, with a flat attributes and where we would like
to PUT/POST methods having a consumption
type "application/x-www-form-urlencoded", then the in type will be ""in":
"formData".
For example:
please refer to POST /pet/{petId} method under
http://petstore.swagger.io/v2/swagger.json
Swagger.json sample:

"post": {
"tags": [
"pet"
],
"summary": "Updates a pet in the store with form data",
"description": "",
"operationId": "updatePetWithForm",
"consumes": [
"application/x-www-form-urlencoded"
],
"produces": [
"application/json"
],
"parameters": [
{
"name": "petId",
"in": "path",
"description": "ID of pet that needs to be updated",
"required": true,
"type": "integer",
"format": "int64"
},
{
"name": "name",
"in": "formData",
"description": "Updated name of the pet",
"required": false,
"type": "string"
},
{
"name": "status",
"in": "formData",
"description": "Updated status of the pet",
"required": false,
"type": "string"
}
],
"responses": {
"405": {
"description": "Invalid input"
}
},
"security": [
{
"petstore_auth": [
"write:pets",
"read:pets"
]
}
]
},

Requirement is to support method to consume "application/x-www-form-urlencoded"
and to go with "formData" in type.
If you need anything more on this please do let me know.
Regards,
DGKM
On 2 June 2018 at 09:50, Romain Lenzotti<EMAIL_ADDRESS>wrote:

Yes it's BodyParams, sorry :)
You've right, for BodyParams without model, the name is generated
automatically.
For example:
@Controller('/')class Ctrl {
@Post('/')
post(@BodyParams('clientId') clientId: string, @BodyParams('appId') appId: string) {
}

}
This example will generate a custom model name for swagger
Other example:
@Controller('/')class Ctrl {
@Post('/')
post(@BodyParams('test') model: MyModel, @BodyParams('test2') model2: MyModel2) {
}

}
This example will generate a custom model name for swagger
But to avoid that you can create a model:
class MyPostPayload {
@Property()
model: MyModel;
@Property()
model2: MyModel2;
}
@Controller('/')class Ctrl {
@Post('/')
post(@BodyParams() payload: MyPostPayload) {
}

}
this example will use the MyPostPayload as swagger name.
But If this example does not fit your case, I need some example code like
my previous examples.
See you,
Romain
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/Romakita/ts-express-decorators/issues/378#issuecomment-394067411,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ACmpR4iynnmoMF5Motu2m794I0Ags1PIks5t4kPhgaJpZM4UXKrB
.

--
Thanks,
Keshav

You try that:
@Controller('/')
class Ctrl {
    @Post('/')
    @Operation({consumes: ["application/x-www-form-urlencoded"]})
    post(@BodyParams() payload: MyPostPayload) {

    }
}

// or create your own decorator:

export function Consumes(...consumes: string[]) {
  return Operation({consumes})
}

@Controller('/')
class Ctrl {
    @Post('/')
    @Consumes("application/x-www-form-urlencoded")
    post(@BodyParams() payload: MyPostPayload) {

    }
}

If it works and If you have a time, you can create a PR to with the Consumes decorators ;)
See you,
Romain

@dgkmurthy The consumes decorator is released :)

Hi @Romakita , The consumes decorator indeed adds the correct consume property in the json definition. However, i have some troubles accepting a text/plain body payload. the following definition :
    @Post("/")
    //   @Authenticated()
    @Description("doSomething")
    @Status(200, { description: "Success", type: String })
    @Consumes("text/plain")
    public async doSomething(
        @Required()
        @BodyParams("body") body: string
    ): Promise<string> {
        return "something";
    }

produces :
                "parameters": [
                    {
                        "in": "body",
                        "name": "body",
                        "required": true,
                        "schema": {
                            "$ref": "#/definitions/KeyCtrlDoSomethingPayload"
                        }
                    }
                ],

so the schema contains a $ref with a generated model, while I would expect a type:string.
Any specific way to solve this?
Thanks!

You can remove body field if it's possible for your front-end consumers => @BodyParams() body: string


fix: #5915 Added JSConvertible to access the row background color.

Description

Enable the JS convertible options for handling row background color.

Fixes #5915
Type of change

Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Tested locally.

Checklist:

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes

Test coverage results :test_tube:
:red_circle: Total coverage has decreased
// Code coverage diff between base branch:release and head branch: fix/5915-table-properties-jsconvertible

Status
File
% Stmts
% Branch
% Funcs
% Lines

:red_circle:
total
55 (-0.01)
36.61 (0)
34.82 (0)
55.48 (-0.01)

:green_circle:
app/client/src/utils/validation/common.ts
60.66 (1.64)
58.13 (0.63)
33.33 (0)
60 (1.67)

:x:
app/client/src/widgets/CircularProgressWidget/constants.ts
100
100
100
100

:x:
app/client/src/widgets/CircularProgressWidget/index.ts
100
100
100
100

:x:
app/client/src/widgets/CircularProgressWidget/component/index.tsx
37.04
40
0
41.67

:x:
app/client/src/widgets/CircularProgressWidget/widget/index.tsx
94.12
100
75
93.75

/ok-to-test sha=09f3180

/ok-to-test sha=b2cb553

/ok-to-test sha=7125bab

/ok-to-test sha=0202dc3

/ok-to-test sha=210ef14

/ok-to-test sha=4ae2345

/ok-to-test sha=f21876b

/ok-to-test sha=95f8163

Hi @vibhandikyash The tests are failing since we are validating fontStyle.
There's an issue with BUTTON_TABS property control. I'm working on it while resolving #6797
Can you remove validation for fontStyle in this PR for the time being?

/ok-to-test sha=bded580

@vibhandikyash while testing this PR I've noticed that when cell background is set to any color light/dark the hover on any row is not visible.  Only when cell background is empty on hover the rows are highlighted. Without the hover action I wouldn't be able to continue testing this DP. Also one more observation is when the cell background is set to any color light/dark the selected rows are not visible. Please refer video
https://loom.com/share/ebd364a83f5648aabfd94c8f864b19d2

@vibhandikyash I am not getting the context right,

What is the issue here?
What is your fix?
why was this not taken forward up-till now?

/ok-to-test sha=fb96fe6

Closing this for now until we have a solution for perfect hover background.


[enhancement]: Adding EufyCam E330 (Professional)

Describe the solution you'd like
Hello, thank you for your work on this plugin. I never thought I would be able to add any Eufy products to anything but your plugin made it possible! I am however, having an issue adding my E330 Professional cameras. I'm assuming this is because these are new products and wanted to see if it was possible to get those added?
The camera does show up in the plugin config but the only option I have is to ignore. I'm also getting the following in my Hombridge logs:
[EufySecurity]  WARN    This accessory is not compatible with HomeBridge Eufy Security plugin: Front Door Type: 24
I'm using Homebase 3. If there is any other information I can provide, please let me know and thank you again for your work!

Road Map link goes to 404 Not Found. Can you post proper link? Or let us know if the E series cameras and doorbell on the road map? Timing?  Thaks for all your great work.

Eufy E330 can be used with plugin homebridge-eufy-security v2.3.30 by lenoxys. So far this is the only version that I can get to function. One the cameras are connected you need to go into the advanced video config for each E330 cam and set the config to performance. After doing this I have been able to stream all of my E330 cameras on Homekit.
Let me know if this works for you @GFlik

Yes, sorry I should have closed this issue, these have been working for me for a couple months now. Thanks!


Flattening does not include root xmlns on schema

Bug Report
See https://github.com/phpro/soap-client/issues/495
view-source:https://immobinetagenzie.immobinet.it/webservices/webservicemodagenzia/service.wsdl
view-source:https://immobinetagenzie.immobinet.it/webservices-deps/webservicecore/schema.xsd
Results in flattened:
    <xsd:schema xmlns:imm="http://www.immobinet.it/schema/WebserviceCoreBundle" targetNamespace="http://www.immobinet.it/schema/WebserviceCoreBundle" elementFormDefault="qualified">

But should be:
    <xsd:schema xmlns="http://www.w3.org/2001/XMLSchema" xmlns:imm="http://www.immobinet.it/schema/WebserviceCoreBundle" targetNamespace="http://www.immobinet.it/schema/WebserviceCoreBundle" elementFormDefault="qualified">

Resulting in XSD's "string" to be unknown cause it is not prefixed:
  Can't find type named {http://www.immobinet.it/schema/WebserviceCoreBundle}#string, at line 309 in immobinet.it.wsdl

This seems to be an ext-dom issue.
See more details in this gist: https://gist.github.com/veewee/32c3aa94adcf878700a9d5baa4b2a2de
To overcome this, an additional XMLNS copying check must be wrapped when appending the external node:
https://github.com/php-soap/wsdl/blob/22a8fce96a8d151004fa4e639c6968ec0aa33878/src/Xml/Configurator/FlattenXsdImports.php#L190-L192
However, since this looks like a PHP bug, it might make more sense to try get it solved there.

However, since this looks like a PHP bug, it might make more sense to try get it solved there.

I received your e-mail this week and I have replied to it, but I'm not sure if you got my reply.

Oh snap ... it was delivered in my spam folder :)


Configure loguru with the RichHandler

Feature request

Current Behavior

Loguru and rich do not interact very well together at the moment.
Expected Behavior

The logs should be displayed in a way that works well in the Rich TUI.
Possible Solution

Use the RichHandler: https://rich.readthedocs.io/en/latest/logging.html

Helping Links:

https://github.com/Textualize/rich/issues/163
https://github.com/Delgan/loguru/issues/540


Add Github actions for CI

Description of your changes
Adds Github actions.
Please note, this repo is only consumed as a go library and no docker/helm artifacts are produced.
Hence, related CI steps were not included
I have:

[x] Read and followed Upbound's contribution process.
[x] Run make reviewable to ensure this PR is ready for review.

How has this code been tested
To be tested after merge.

Merging without approval to be able to test the actions.


Unsupported Version

When I log in with my credentials, the app displays the following message:

This is a fresh build, and i have changed the endpoint to my application. I've tested it on the desktop build (Linux) and on an android emulator.
Flutter: 3.24.3
App: 1.3.0

Hello,
Mobile release 1.3.0 works with ThingsBoard v3.8.0. That's why you see this message.

Hello,
According to your documentation (https://thingsboard.io/docs/pe/mobile/getting-started/), the Mobile release 1.3.0 is compatible with ThingsBoard 3.6.3PE and above, correct?

Not really. Documentation is wrong and will be fixed.
Mobile release 1.3.0 is compatible only with the 3.8.0 platform version.


Show Trust server certificate on dialog and fix bool select-box defaults

This PR adds Trust server certificate property to main connection dialog with Tooltip and info icons as in screenshot below:

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

5 of 16 (31.25%)  changed or added relevant lines in 3 files are covered.
4 unchanged lines in 1 file lost coverage.
Overall coverage decreased (-0.008%) to 41.93%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

src/sql/workbench/browser/modal/dialogHelper.ts
2
3
66.67%

src/sql/workbench/services/connection/browser/connectionWidget.ts
0
10
0.0%

Files with Coverage Reduction
New Missed Lines
%

extensions/notebook/src/jupyter/serverInstance.ts
4
75.5%

Totals

Change from base Build<PHONE_NUMBER>:
-0.008%

Covered Lines:
28870

Relevant Lines:
63945

💛  - Coveralls


Add visibility to auth extension interactions with third-party services

Anything that interacts with an external system (like OAuth, or SMTP) should have sufficient logging for developers to troubleshoot configuration issues, bugs, deliverability issues, etc.

The original idea here was to add logging, but maybe a more robust and integrated solution is to have auth events generate audit entries. This could also integrate with the planned webhook implementation (#7484).
Needs design!

Closed in #7944


Homebrew errors

homebrew package feature is long time. I think due to not using sudo? (so is it being installed as a user?)
I'm getting hung for a long time on error message that says
 => => # Error: Need to download https://formulae.brew.sh/api/formula.jws.json
 => => # but cannot as root! Run `brew update` without `sudo` first then try ag
 => => # ain.
 => => # +++ brew --prefix
 => => # ++ git -C /home/linuxbrew/.linuxbrew/Homebrew/Library/Taps/homebrew/ho
 => => # mebrew-core fetch --unshallow

This is effecting features that rely on homebrew. Specifically for me, neovim-homebrew failed installation.

This was a truely severe bug, during homebrew 4 the default behavior changed and packages could no longer get installed using root. It has rendered all homebrew based features broken.
The fix was to install with the remote user.


Incorrect AppSource delivery despite 'appSourceContinuousDelivery' set to false

Description
Our app is always delivered to the AppSource, even though the "appSourceContinuousDelivery" parameter is set to false.
Logs
Rent_DeliverToAppSourceLog.zip

@janlehmkuhl Is the issue the same or similar to https://github.com/microsoft/AL-Go/issues/451
If so, please close the current one as duplicate and mention your findings in the original one.

@mazhelez Part of the problem is addressed in #451, I agree with you on that. The second part of my issue, however, is that our app is constantly being delivered to the AppSource even though the "appSourceContinuousDelivery" parameter is set to false. I will remove the part of the problem related to #451 from this issue.

@janlehmkuhl - please share your .AL-Go\settings.json here, thanks.

@janlehmkuhl could it be that you have set the AppSourceContinuousDelivery to "false" instead of false.
i.e. a string instead of a boolean?


feat: adding Google sign in/sign up in Login page

The login page does not authenticate the user. We can add a Sign in/Sign up option using Google, to verify the user

@Tejashri-Taral
Assign me this issue


Generate Assets Packs for on demand resource tags and update Firebase

Question Checklist

[x] Updated fastlane to the latest version
[x] I read the Contribution Guidelines
[x] I read docs.fastlane.tools
[x] I searched for existing GitHub issues

Question Subject
What tool/action do you have a question about?  gym
Is this a question about documentation?  yes

Question Description

I am working on an iOS app which contains a huge amount of on demand resources (up to 6Gb). I am using fastlane as my CI tool. Although the xcode project settings is set to do not embed the assets in the binary (and post it on an external url), I am getting a huge ipa with everything packed. How I have to configure gym to generate the assets pack for me to upload to my managed host? Is there any possibility to automatically upload such assets pack to an S3 bucket?

Although the xcode project settings is set to do not embed the assets in the binary (and post it on an external url)

How?

Is there any possibility to automatically upload such assets pack to an S3 bucket?

Anything that is possible in Ruby, is possible in fastlane - and that can definitely be done. Question is how you tackle it.

How?
There are some XCode project configuration that are missing such as the bitcode ones. Any way, not a big deal.

Question is how you tackle it.
I managed to make it work but inspecting .xcarchive. The problem now is internal routing. I am doing some test.

Could you please let me know which command you are using to generate the asset packs using fastlane? Thanks in advance.I have looked through the doc but wasn't able to see anything that would help.

I used export options of gym
gym(scheme: scheme,
    export_method: "ad-hoc",
    archive_path: "./Archive",
    export_options: {
	compileBitcode: false,
	uploadBitcode: false,
	embedOnDemandResourcesAssetPacksInBundle: false,
	onDemandResourcesAssetPacksBaseURL: $assets_remote_path
    }
)

Once gym finishes, I could find assets pack on Archive.xcarchive/Producs/OnDemandResources. I am pushing them into my server. But the problem I am facing now is AssetPackManifestTemplate.plist on the <my_app>.app points to my local Derived Data. Thus, the installed app can not access tags. 😢

Update: My last comment was no accurate. It is true that OnDemandResources are included oon the xcarchive, but those "folders" are not able to be used since they are unsigned. They need to be signed to be converted in "files" which are able to be consumed by app from a server.
I am tuning gym export params to achieve my goal. I will close the issue if I find a solution. In the meanwhile, I would appreciate any help.
Thanks

Continuing my investigation I found out the path where asset packs are generated. They area placed on a temporal folder. Appearing on the generated xcodebuild command:
/usr/bin/xcrun /Users/<user>/.rbenv/versions/2.4.1/lib/ruby/gems/2.4.0/gems/fastlane-2.142.0/gym/lib/assets/wrap_xcodebuild/xcbuild-safe.sh -exportArchive -exportOptionsPlist '/var/folders/0c/zjyj2w4d0cxg0vjv6ftdk6wc0000gr/T/gym_config20200303-17713-1g895h.plist' -archivePath /Users/<user>/Library/Developer/Xcode/Archives/2020-03-03/BetVictor\ 2020-03-03\ 14.30.14.xcarchive -exportPath '/var/folders/0c/zjyj2w4d0cxg0vjv6ftdk6wc0000gr/T/gym_output20200303-17713-1tn62w9'

Is there any way to override /var/folders/0c/zjyj2w4d0cxg0vjv6ftdk6wc0000gr/T/gym_output20200303-17713-1tn62w9 ???
Or at least to identify that folder to copy it

Having the same issue. I've tried setting output_directory, build_path and result_bundle: true and none of these options seems to produce a set of signed ODR (i.e. like doing it via XCode Archive would).

@jonnyjorvik try the following suggestion to see if it helps. I haven't had a chance to test mine again but I couldn't get the singed ORD files either.
https://github.com/fastlane/fastlane/pull/16117#issuecomment-597037954

So my issue was I was using Legacy build system win Fastlane to create the On Demand resources and when running my app from Xcode I was using the new build system. That is why I couldn't access my Resources and nothing was downloading. Hope this will help someone. Make sure the build systems are same when creating and running the app


[keymgr,lint] Fix remaining width mismatches in keymgr code

This fixes or waives some width mismatches reported by Verilator in the keymgr code. The first commit sorts out something that can easily be fixed in the RTL. The second waives the "wrong size enum" problem, which is really hard to deal with in a way that both AscentLint and Verilator accept.

Hi @tjaychen! I've split this up so that the bit array stuff now just waives the warning. Does this look ok to you?


resource allocation

Hi, I have questions about the job configuration options:
[job.defaults]
job_type=slurm
pwatcher_type=blocking
JOB_QUEUE = test
JOB_NAME = 200kb_test
MB = 32768
NPROC = 12
njobs = 32
submit = srun --wait=0 -p ${JOB_QUEUE} -J ${JOB_NAME} -o ${JOB_STDOUT} -e ${JOB_STDERR} --mem-per-cpu=${MB}M --cpus-per-task=${NPROC} ${JOB_SCRIPT}
I work on a cluster that has 24 cores and 65G RAM per node. Should I set NPROC=24 MB=2700 (65/24)?
How to set njobs? How many jobs are needed to run for a 1.3G plant genome with about 100X pacbio reads?
Thanks

You want 3GB per CPU, so you will need to configure DALIGNER that way. By default it uses 4 CPUs per task, so you need -M12000 in you daligner_opt configuration. You would need to ensure that your block-size allows processing to fit within 12GB, Gene Myers suggests approximately DB split -s150`.
For job submissions,
submit = srun --wait=0 -p ${JOB_QUEUE} -J ${JOB_NAME} -o ${JOB_STDOUT} -e ${JOB_STDERR} --mem-per-cpu=3000 --cpus-per-task=4 ${JOB_SCRIPT}

That will give you 4 CPUs per task, which means you will end up with . However, some tasks benefit from more, and some need only 1. You might want to override these per-task-group.
Here is a ton of documentation:

https://github.com/PacificBiosciences/pb-assembly

Thanks very much for your explanation.
I am still a little bit confused.

You want 3GB per CPU, so you will need to configure DALIGNER that way. By default it uses 4 CPUs per task, so you need -M12000 in you daligner_opt configuration. You would need to ensure that your block-size allows processing to fit within 12GB, Gene Myers suggests approximately DB split -s150`.

In my case (24core-65G per node), if --mem-per-cpu=3000 --cpus-per-task=4, does that mean 6 tasks can run simultanueously on one node?

If using 4 CPUs by default, can I set --mem-per-cpu=16250, so to fully employ the memory (65G per node) ?  I understand that this setting can help to increase the DB split -s,  thus speed up the processing. Am I right?

However, some tasks benefit from more, and some need only 1. You might want to override these per-task-group.

Is there any empirical knowledge about which task need more, which need only 1?

If I want to use multiple nodes, do I need to specified the -N option in submit = srun ... ? or falcon knows how to submit the tasks to multiple nodes?

So sorry for these annoying questions. I am a beginner in this area and your explanation would be appreciated very much!

In my case (24core-65G per node), if --mem-per-cpu=3000 --cpus-per-task=4, does that mean 6 tasks can run simultanueously on one node?

Yes.

If using 4 CPUs by default, can I set --mem-per-cpu=16250, so to fully employ the memory (65G per node) ? I understand that this setting can help to increase the DB split -s, thus speed up the processing. Am I right?

Basically. DBsplit chooses the block size. Given that, you can assume how much memory daligner needs (and assume 4 cores). You need to pass that to daligner in its -M flag so it limits the kmer table size too. And given all that, you can adjust how you submit jobs. (Yes, it's a bit complicated.)

Is there any empirical knowledge about which task need more, which need only 1?

Unfortunately, we've been a bit lax in that. We're working with other systems internally.

srun ...

I'd rather not starting helping with job-submission systems. You're much better off talking to your sysadmin and some other resource.
Cheers!


Adds UEFIBOOT and ESXIBOOT

Description
This adds the beginnings of being able to drop directly into different Operating Systems such as ESXi and Windows 20xx
Why is this needed
Removes the need to reboot, saving on valuable provisioning time.
Fixes: #
How Has This Been Tested?
Tested with qemu, some hardware might yield different results at this time.
How are existing users impacted? What migration steps/scripts do we need?
They are not, these are new options.
Checklist:
I have:

[ ] updated the documentation and/or roadmap (if required)
[ ] added unit or e2e tests
[ ] provided instructions on how to upgrade

Agree with @nshalman this looks very interesting.   @thebsdbox do you intend to continue working on this PR?    If not maybe someone else would like to pick up where you've left off.

Hey @thebsdbox, would you like some help on this? or should we close this for now?

@thebsdbox please let us know if your plan is to continue work on this. Otherwise we will likely close this during the next triage in two weeks.

Tidied and questions answered.. this is extremely beta though :-)

this is extremely beta though :-)

Should this come with a version bump?

Hey @thebsdbox, looks like this one is looking for some review response?


[QA] trashcan "Empty" fails

Deployed ocis master 2020-12-11 13:30h via hetzner-deploy/make_ocis_test.sh -> ocis/deployments/examples/ocis_traefik/

login as einstein
upload a file
delete the file
visit trashcan
click "Empty". An error occurs. BAD

select all files, click "Delete". OK

expected behaviour: "Empty" empties the trashcan the same way as deleting all would do.

The DELETE request with an empty path is not implemented in reva, so we land here:
https://github.com/cs3org/reva/blob/e791b5599a89577db43da51b60c98592b4814ca1/internal/http/services/owncloud/ocdav/trashbin.go#L125

duplication of https://github.com/owncloud/product/issues/254

closing as duplicate of https://github.com/owncloud/product/issues/254

closing as duplicate of https://github.com/owncloud/product/issues/254


[RESTEASY-2996] Calling send for each chunk with flush and completing the future

This is an alternate approach to this PR that is being discussed here.
Instead of sending a flux of byte array, a mono of byte array is sent and flushed every time and the completion of the future is done on 'doOnSuccess' of the resulting Publisher.

If we want to try to avoid the flush-on-every-asyncwrite performance problem, then:

We can consider making the byte[] array in ProviderHelper configurable such that we'd match the size netty uses before choosing to flush.
In ChunkedOutputStream do some accumulation of byte[] before providing it to NettyOutbound#send, but I don't see how that's good performance wise..

Just a few thoughts.

@jamezp / @asoldano - Please help reviewing this change. This is a bug that is currently affecting streaming cases with reactor-netty server adapter. Please refer the "Steps to Reproduce" section on this JIRA issue to reproduce the problem with the existing code.

@jamezp Please let me know if you are waiting for anything from me.

https://issues.redhat.com/browse/RESTEASY-3012

@jamezp are we good to accept this PR? The configurable buffer PR shall wait for the above story.  Because this bug is currently affecting the streaming scenarios in our apps and we are trying to get this onboard ASAP to use this fix.


Make lazy evaluation even faster

There are a couple of optimizations that we can still do on the lazy item evaluator:

cache GetAllItems results: https://github.com/Microsoft/msbuild/blob/master/src/XMakeBuildEngine/Evaluation/LazyItemEvaluator.cs#L149
Remove and Update can shortcuit matching items if their itemspec refers to itself (e.g. <Compile Remove="@(Compile)"> or <Compile Update="@(Compile)">)

Continuing the discussion from here: https://github.com/Microsoft/msbuild/pull/891#discussion_r74658336

Hmm, even then, the cache would be per LazyItemList instance. For example, the lists representing [include] and [include;update] would have 2 different GetItems caches because they are 2 objects. So another item pointing to the first list would not get affected by subsequent operations, since those would be in different lazylist objects.

Using your sample, there are three LazyItemLists.  We can call the first one i2_1, and it is produced by this:
<i2 Include='a;b;c'>
    <m1>m1_contents</m1>
    <m2>m2_contents</m2>
</i2>

Then we have i, which simply copies the contents of i2_1:
<i Include='@(i2)'/>

Then we have i2_2, which modifies the metadata for the items coming from i2_1:
<i2 Update='a;b;c'>
    <m1>m1_updated</m1>
    <m2>m2_updated</m2>
</i2>

Your comment seems to refer to the fact that i and i2_2 are separate objects with separate caches.  That is true, but they both refer to i2_1, which is a single instance.  So when i is evaluated, it will call GetItems for i2_1, which is stored in it's _previous field.  This will create the items for i2_1 with the correct metadata, and if we implement caching then it will cache that list before returning it for i to use.
Then when i2_2 is evaluated, it will have a reference to the same instance of LazyItemList which represents i2_1.  This time it will return the cached value, which will be the same item instances that were used by i.  Then the evaluation of i2_2' will update the metadata on those item instances, which will be the same ones that are in the i` item list, meaning that it will change the metadata of the unrelated item list.
Hopefully this helps make it more clear.  A possible solution is to clone all the items before modifying their metadata.

@cdmihai You did the second half of this for Update in #2326, right?

Closing as caching was done in #1192 and #2314 is tracking the Update / Remove optimizations


Bug fix lc 332 reactivation code

Fix for boolean issue in email updated recently flag and recently reactivated flag.

Closing as replaced by https://github.com/Civil-Service-Human-Resources/identity-service/pull/163


Newest version isn't working with @create-react-app or with @craco

Attach (recommended) or Link to PDF file here:
After upgrading to the newest version I get this error:

Configuration:

Web browser and its version: Chrome Latest
Operating system and its version: Windows
PDF.js version: 4.0.189
Is a browser extension: No

Steps to reproduce the problem:

Upgrade to the latest version
Try to run the app using yarn start

What is the expected behavior? (add screenshot)
Load all the js properly and work
What went wrong? (add screenshot)
Didn't work with the default @create-react-app configuration. I've enabled top-level-await using @craco but still not working :

@craco configuration:

Didn't work with the default @create-react-app configuration. I've enabled top-level-await using @craco but still not working :

Unfortunately we don't use, and thus cannot provide help/support for, either of those frameworks.
Based on your error messages it seems that enabling the necessary functionality didn't actually work, however asking those projects for help will probably provide better answers than we can provide here. For future reference: Please always provide error message and code as text, since images are much more difficult to work with (e.g. you cannot copy-and-paste from them).
Please also note https://github.com/mozilla/pdf.js/blob/master/.github/CONTRIBUTING.md (emphasis mine):

If you are developing a custom solution, first check the examples at https://github.com/mozilla/pdf.js#learning and search existing issues. If this does not help, please prepare a short well-documented example that demonstrates the problem and make it accessible online on your website, JS Bin, GitHub, etc. before opening a new issue or contacting us in the Matrix room -- keep in mind that just code snippets won't help us troubleshoot the problem.


M13 and layoutParams

Given that one of the features in M13 is "Java get/set pairs are now seen as properties in Kotlin" layoutParams as in the example below and in the README no longer works since it is referencing getLayoutParams/setLayoutParams instead.
linearLayout {
    button("Login") {
        textSize = 26f
    }.layoutParams(width = wrapContent) {
        horizontalMargin = dip(5)
        topMargin = dip(10)
    }
}

It has been renamed to lparams. (See https://github.com/JetBrains/anko/commit/246ad696babbd044626b27853f8677647c68bf2c)

Hmm. I'm not getting lparams as an option in Android Studio. I'm currently using org.jetbrains.anko:anko-sdk15:0.7.


How do I customize data in tree? I don't want to use fixed title, key and so on.

Version
1.4.0
Environment
ng6 ngzorro1.1.1
Reproduction link
https://stackblitz.com/run?file=src%2Fapp%2Fapp.component.ts
Steps to reproduce
I just started writing code with ng-zorro, without understanding the specific [key:string]: any.
What is expected?
Give me an example or some inspiration
What is actually happening?
Other?

@zhaoshaokun You cannot use a library without following its API. You should write code to parse your data. And your reproduction link is invalid.

@zhaoshaokun NzTreeNodeOptions accpet any data u provided, then u can use them with NzTreenode.origin. official demo


Kyma - Screenshot Update: One more tab added: Resources

Hello,
Scenario URL: https://developers.sap.com/tutorials/cp-kyma-redis-function.html#c1579029-cff3-43a6-b9ff-116af0477c97
Step 6.3: Choose the tab Configuration.
->> screenshot update: one more tab is added: 'Resources'
Please update the tutorial with new screenshot
New screenshot:

Labels to be added:
Landscape label: Landscape label: trail1, trail2, trail3
Sprint Label: SCPTest-2101
Scenario label: SCPTest-Kyma
Prio: low-prio
Thanks,
Shubham Agarwal

Fixed in qa, will be in prod in next push.

Fixed in qa, will be in prod in next push.


Re-run the pipeline for FinRegistry with updated OMOP harmonization

This would require:

[ ] Running the python preproc script on FinRegistry raw data, when the script is updated with Javier's new harmonization tables.
[ ] Running Risteys pipeline code on this

Cancelled, will just use FinnGen data.


[Bug]: The label text truncates on resizing the input widget

Is there an existing issue for this?

[X] I have searched the existing issues

Current Behavior
It is observed that when the user resizes the input widget the label text truncates when the text size is chosen as Heading 1

Steps To Reproduce
1.Launch appmsith app in release/Production environment
2.Drag and drop Input widget
3.Add label text
4.Resize the widget position - Top to bottom
5.Choose the text size as heading 1 and observe
Environment
Production
Version
Cloud

Needs to be solved, when label text size changes the input area needs to decrease accordingly.
@somangshu adding this to product backlog. Can we assign this to Paul to be picked up after the label enhancements ?

This issue has been fixed on the PR at https://github.com/appsmithorg/appsmith/pull/10600


Adding a dataset with dots needs to be quoted or it shows as not existing

Describe the bug
Creating a dataset name with dots, i.e. eth.recent_blocks will create a dataset with that table name:
sql> show tables
+---------------+--------------------+-------------------+------------+
| table_catalog | table_schema       | table_name        | table_type |
+---------------+--------------------+-------------------+------------+
| datafusion    | public             | eth.recent_blocks | BASE TABLE |
| datafusion    | information_schema | tables            | VIEW       |
| datafusion    | information_schema | views             | VIEW       |
| datafusion    | information_schema | columns           | VIEW       |
| datafusion    | information_schema | df_settings       | VIEW       |
+---------------+--------------------+-------------------+------------+

But querying without quoting will return an error:
sql> select * from eth.recent_blocks limit 10
Error An internal error occurred while processing the query. Show technical details with '.error'

Querying with quotes will work correctly:
select * from "eth.recent_blocks" limit 10

Expected behavior
We should warn users when they try to create/load a dataset with a name that has dots.

@phillipleblanc do you mean only in cli command spice dataset configure or it should be logged in runtime logs?

Both

@phillipleblanc looks like that is not possible (probably after some changes in re-architecture) - data fusion doesn't allow to register table with dots in name, because it parses that as a datafusion catalog

@ewgenius can we fix the error message so the action the user needs to take is more clear?


Add tutorial that explains step by step how to create a simple Generator Template

Reason/Context
So we already have https://www.asyncapi.com/docs/tools/generator/template-development that nicely explains all basic requirements for a template and possible features.
What we are missing is a tutorial that someone follows to:

create a simple template
without additional noise of explaining every feature - this can be mitigated by linking to other docs
explanation of something in action, that reader can actually run at the end

This could be a foundation for further development of more tutorials that would basically add more features to this test template
Description

it should follow the same for as other tutorials, like -> https://www.asyncapi.com/docs/tutorials/create-asyncapi-document
it should be as simple to use as possible, so for example we do not explain how to create an AsyncAPI document, as in this tutorial it is just one of required assets that someone should already have so we just say if you do not have asyncapi document to test your template with, just run asyncapi new --example=tutorial.yml --no-tty to get one
tutorial examples should be based on AsyncAPI document generated with asyncapi new --example=tutorial.yml --no-tty from AsyncAPI CLI
we could have a super simple code generator as an example (https://medium.com/python-point/mqtt-basics-with-python-examples-7c758e605d4 Publish to a Topic). So the tutorial would explain all about code generation template, how to grab channel name and message info from AsyncAPI using Parser
then we would have another section that would guide someone on how to test the template locally, how to run it and make sure it works

I'm happy to help with knowledge sharing session and initial development of the template that will serve as an example here

Makes sense👍 It's about time we add a separate tutorial that a reader can follow to create and run an example template

This issue is part of the AsyncAPI Bounty Program, interested contributors need to follow the guidelines below to ensure fairness and timely completion of assigned tasks:
Task Assignment
The assignment of tasks will be prioritized in the following order:

AsyncAPI maintainers (from any repository)
Regular contributors (individuals who have merged three or more pull requests)
Other (if an individual doesn't fall under the above, the maintainer can determine the criteria i.e regular volunteers, etc)

We encouraged everyone to apply as long as the task is for you (falls under your skill set). We will not be using the first comment - get assigned method for assignments. Instead, we will provide 3 days to consider all individuals interested before assigning any bounty task.
Deadline
To maintain accountability and ensure the timely completion of the deadline for this task will be 6 - 8 weeks from the date of assignment. If a contributor requires an extension on their task, it should be communicated and approved by the maintainer.
Issue Tracking and Updates
Contributors must provide weekly updates on the task they are working on to help maintainers stay informed of progress. If a contributor fails to provide an update, they will be reminded via a ping. If a contributor fails to provide an update after three pings over three weeks, we will assume they have silently dropped the issue, and it will be reassigned to someone else.
Issue Drop-outs
Any contributor who drops an assigned issue will be penalized and will not be eligible to participate in the bounty program for 6 months. We understand that unforeseen circumstances can arise, and dropping an assigned issue may be unavoidable in some cases. However, we believe that enforcing this penalty is necessary to ensure the effectiveness of the bounty program, respect maintainer time, and honor the efforts of other contributors who could have solved the issue but were unable to do so due to the drop-out.
We encourage all contributors to follow these guidelines to ensure a fair and timely completion of tasks assigned through our bounty program.

@derberg I am interested too in this

@derberg Oops there arent any other bounty issues available

@octonawish-akcodes There are some -> https://github.com/issues?q=is%3Aopen+org%3Aasyncapi+label%3A"bounty"
or did you look for docs task only?

@derberg 8th May will work well for me since I'm going on holiday next week.

@Florence-Njeri perfect, we have lots of holidays next week in Poland anyway 😃 Let's sync on slack for an onboarding call

Hey, @Florence-Njeri how's the task going?

for now Florence is blocked by my tech input that I work on "as we speak" 😃

@Florence-Njeri ok, so when I started working on technical input, I kinda started feeling the blues, you know and while making notes, I figured I can turn it into article.
I just opened PR to my blog https://github.com/derberg/derberg.github.io/pull/62 and you can preview it here https://derberg-github-io-git-articlecodegenpython-derberg.vercel.app/blog/asyncapi-codegen-python

it is work in progress, there are some technical issues

this doesn't mean the tutorial is not needed. On the contrary, it is super needed. Article is written from a personal note, as a story, so it can only be reused by you as technical input. Of course you do not have to explain parser, generator and other stuff like I did as your tutorial is part of the docs where these things are explained and you can link.
anyway, you can already start working on tutorial. The best way to write it is when you will replicate tutorial steps on your own.
ah, and one more note, article is in progress, I did not read it as a whole, there is a bunch of grammar mistakes so please don't laugh 😄

This blog, ehn, took the words right out of my mouth.

@thulieblack @derberg  I've started working on the tutorial, hoping to put up a PR before end of the week

ok, so article is now live: https://www.brainfart.dev/blog/asyncapi-codegen-python
sample template that I developed while writing the article is here: https://github.com/derberg/python-mqtt-client-template
enjoy 😄

Hey guys @derberg @thulieblack, I've finished writing the first draft for the tutorial. I need to do an editorial check then I'll put up a PR for this issue.


Support allowInvalid model option with validateAfterResize

When ngf-validate-after-resize="true" then allowInvalid model option doesn't work

i've published this under ng-file-upload2 on npm if somebody wants to use it with this fix


pytest migration of unit.common.resolve.test_Resolve

🚀 Pull Request
Description

Consult Iris pull request check list

Add any of the below labels to trigger actions on this PR:

https://github.com/SciTools/iris/labels/benchmark_this

@pp-mo Thanks for the review and wading through this one 💯
Back to you 👍

Thanks @bjlittle -- done.


Add Godot Google Play Games Services plugin

Hi! I'm adding my Godot android plugin for integration with Google Play Games Services. There's one for Godot 4.2+ and another for Godot 3.5+
Hope it's useful!

Thanks to you!!!!


Add setter on StrawberryAnnotation.annotation

Fixes this issue on Strawberry Django:
AttributeError: property 'annotation' of 'StrawberryAnnotation' object has no setter

Thanks for adding the RELEASE.md file!

Here's a preview of the changelog:

This release adds a setter on StrawberryAnnotation.annotation, this fixes
an issue on Strawberry Django.

Here's the preview release card for twitter:

Here's the tweet text:
🆕 Release (next) is out! Thanks to @patrick91 for the PR 👏

Get it here 👉 https://github.com/strawberry-graphql/strawberry/releases/tag/(next)


401 on private user's lists

Hi,
Trying accessing a private user's lists will return a 401 error, even if authenticated, instead of a 403.
Example: https://api.trakt.tv/users/wakodemo/lists

Please post the full request and response, including all headers. A 401 means the OAuth credentials don't have access to view that list.

I may have forgotten to mention that I'm not the owner of the list, that's why the access is forbidden for me. The behavior is as expected (no access to the resource) but the 401 code returned, while authenticated, is "wrong". It should return a 403 forbidden code.
The common practice when you receive a 401 code is to logout the user because his token is not valid anymore.

A 403 is currently reserved for an invalid application api key, so we can't really use that in this case. Along with the 401 there is a X-Private-User header that is also sent. If that is set to true, maybe that can help determine this use case?


ldap new user registration

Register a new user in ldap first, to get around keycloak - ldap issues.
Will close #5 when complete.

[x] testing ldap server set up
[ ] new user is created in ldap
[ ] new user is visible in keycloak
[ ] tests for all of this

Turns out we don't need to create users in LDAP first after all.  The (better) alternative is to only use the basic user classes (inetOrgPerson, organizationalPerson) when setting up the LDAP sync in Keycloak.  Then adding things like posixAccount later if requested.
So we'll still need a library in which to modify LDAP profiles, but won't need this in the initial user creation.


Bug Report: Pressing R Key In Chart Editor Does This:

Which target are you using?
[Windows]:
Explain your issue
Please check first if your issue haven't already been reported yet.
Pressing R Key ANYWHERE (Even When Trying To Use Events)  In Chart Editor Does This:

do you have any addons in your addons folder? iirc there's no code for even checking the R key.

do you have any addons in your addons folder? iirc there's no code for even checking the R key.

No, Its Just Base Code name With No Changes What-So-Ever.


Blank screen when opened

Udeler shows blank page when opening but when i end one task in the task manager, its back to normal as shown in the pic below
This issue has been in udeler for long, but last update fixed it, now its back again.

Hi @itsmemac Thanks for reporting.
Why do you have multiple instances of Udeler running? Does it not close properly on quitting?
I am not a windows user. On mac it works fine. I will try to reproduce this on windows and see what's wrong.

Hi Sir. I also have this issue. When I download multiples courses in the background for a while and when I come back, I get that blank screen with edit panel.  About multiples instances in task manager, same three process here every time that I launch the app.
I'm using
Windows 10 Home 1803 64 bits
Intel Core i3-6006U
8GB DDR4

Whenever i open udeler, it happens. Rarely it shows the main screen without closing the instances.
95% of the time it shows me a blank screen then i have to close the low resource consuming instance to make it show the login screen. Not a major issue but it would be awesome if its fixed.

Found a fix for the issue. It was running on my AMD graphics card and i switched to intel graphics using amd control center and the issue is gone. @FaisalUmair Kindly check this.
Still it has the 3 instances but no more blank screen on startup

Hi @itsmemac  Thanks again for reporting.
How about you give latest version a try? I updated some dependencies to latest version in v1.6.1 .  Give it a try and let me know the results. If by any chance you are already using the latest version, please specify which windows version are you using, what architecture (32 bit or 64bit) also what architecture of Udeler.

@FaisalUmair using the latest already.
using Windows 10 x64 Home Single Language
Windows 10 build version 1803 (17134.191)
x64 architecture of udeler


Discussion: Reconsider serialization method for partition-based state

Migrated from GitLab: https://gitlab.com/meltano/sdk/-/issues/307
Originally created by @aaronsteers on 2022-01-19 20:56:05

When a tap contains multiple partitions, the state tracking for each partition is stored in a partitions list inside the stream's bookmark. This recently broke, and appears to be being created as a map instead of a list. However, there are advantages to storing this as a map and I'm opening this issue to discuss pros/cons and to decide if we should move to a map-based implementation permanently instead of a list-based implementation.
Consideration 1: Scalability and random-access
Merging, deduping, and traversing partitions is slower if not stored in map format. Implementations will likely need to convert to a map in order to efficiently access partition states in memory, which then needs to be serialized again back into list format every time a STATE message is to be emitted. The continual conversion of the partition states between list and map formats has a performance cost.
Consideration 2: Interop with Meltano and other Singer orchestrators
The default state merge() behavior in Meltano requires that states be traversable as nested maps. More discussion here:
Related to Singer "Composable states" working group item here: https://github.com/MeltanoLabs/Singer-Working-Group/issues/6#issuecomment-1016850184
Consideration 3: Need for deterministic string keys for each partition
One challenge with trying to create a map-based implementation is that we'd need to be able to create a deterministic string key for each partition. (Whereas now the state index can be its own dictionary of any number of keys or data types).
For example, a partition index could be {'region': 'west', 'city': 'Seattle'} or  {'project': 'meltano/meltano', 'issue': 12345}.
Consideration 4: Backwards compatibility
If we want to change the schema, we can implement a conversion process in the default implementation of load_state() here: https://gitlab.com/meltano/sdk/blob/main/singer_sdk/tap_base.py#L274

View 10 previous comments from the original issue on GitLab

Still relevant


[Help Wanted] [Bug] AdventureZ and Moonrise

Mod Name
Moonrise
Mod Homepage
https://modrinth.com/mod/moonrise-opt/version/0.1.0-beta.1+98e8a08
Minecraft version
1.21*
Describe the bug
Crash on start-up.
Steps to reproduce

Download AdventureZ
https://modrinth.com/mod/adventurez
Download Moon Rise 1.21
https://modrinth.com/mod/moonrise-opt/version/0.1.0-beta.1+98e8a08
Utilize connector and fabricated api
Launch

Crash Report
crash-2024-09-13_16.47.26-client.txt
Logs
https://gist.github.com/Cixon/40045a6c6867ec82ab0acffc9b3a2be3
Additional context
MC version: 1.21
NeoForge: 21.0.160

Help wanted because idk if this is connector related or something Moonrise would need to fix

did you try on fabric ? and if yes does it make the same issue ? if it's the case then it's a problem between adventurez and moonrise

did you try on fabric ? and if yes does it make the same issue ? if it's the case then it's a problem between adventurez and moonrise

Moonrise is a NeoForge mod. AdventureZ is a fabric mod, there's no mod-loader alternative for either or.

??? moonrise are also on fabric

https://modrinth.com/mod/moonrise-opt/version/Kxy5mXbm I just ask you to try reproduce the crash on fabric

https://modrinth.com/mod/moonrise-opt/version/Kxy5mXbm I just ask you to try reproduce the crash on fabric

Using fabric mod-loader 1.21.1 - 0.16.5 with both the mod version you provided and Adventure Z, it does not crash. Seems stable with fabric mod-loader.
Trying that same mod version you provided with connector in addition to Adventure Z, crash still persists.

ok

org.spongepowered.asm.mixin.injection.throwables.InvalidInjectionException: InjectionPoint(Shift)[@At("INVOKE_ASSIGN")] on net/minecraft/world/level/Explosion::collectBlocksAndDamageEntitiesMixin with priority 1000 cannot inject into net/minecraft/world/level/Explosion::explode()V merged by ca.spottedleaf.moonrise.mixin.collisions.ExplosionMixin with priority 1000 [PREINJECT Applicator Phase -> adventurez.mixins.json:ExplosionMixin from mod adventurez -> Prepare Injections -> handler$zca000$adventurez$collectBlocksAndDamageEntitiesMixin(Lorg/spongepowered/asm/mixin/injection/callback/CallbackInfo;Ljava/util/Set;IFIIIIIILjava/util/List;)V -> Prepare ->  -> { target: explode()V }]

A mixin conflict between adventurez and moonrise, it seems. Please report it to them so that they can change their priorities.


apps.c: Check potential NULL returned by OPENSSL_strdup

I add a null pointer check for retdb->dbfname = OPENSSL_strdup(dbfile);.
I think the null pointer check is necessary for the following usage:
I searched the codebase, and found only one location that uses the field dbfname,
it's apps/ocsp.c:index_changed:
static int index_changed(CA_DB *rdb)
{
    struct stat sb;

    if (rdb != NULL && stat(rdb->dbfname, &sb) != -1) {
        if (rdb->dbst.st_mtime != sb.st_mtime
            || rdb->dbst.st_ctime != sb.st_ctime
            || rdb->dbst.st_ino != sb.st_ino
            || rdb->dbst.st_dev != sb.st_dev) {
            syslog(LOG_INFO, "index file changed, reloading");
            return 1;
        }
    }
    return 0;
}

If the dbfname is a null pointer, stat(rdb->dbfname, &sb) will always fail, and the function will always return 0 regardless of the status of the index file.
Checklist

[ ] documentation is added or updated
[ ] tests are added or updated

Close and reopen the PR to refresh CLA check following the CLA email.


Added label-based mechanism to identify docker-gen container. This is needed w…

Added label-based mechanism to identify docker-gen container. This is needed when using docker compose or other container mechanisms that define dynamically container's name.

the change to app/nginx_location.conf may not be required. it's the results of different attempts to fix the issues i was facing in getting the certificate created. but the problem indeed was all related to the impossibility of connecting to the correct container due to the dynamic naming. the com.github.jrcs.letsencrypt_nginx_proxy_companion.nginx_gen label can be optional of course. let me know what you think.

I need this, if you hadn't, I would! 👍

I need this, if you hadn't, I would! 👍

I found an issue with containers getting redeployed during letsencrypt lifecycle, so I made my own attempt with #231. It's working in production right now, with the helder/letsencrypt-nginx-proxy-companion fork (temporary until the PR is merged).

#231 was merged so this can be closed.

Closed by #231


some improvements

@ryanjbaxter imho: this should be a no-brainer too, as it just clears things a bit


archive.org 503 Server Unavailable

oh dear what's happened to internet archive .org

oh dear what's happened to internet archive .org

https://blog.archive.org/2024/10/18/internet-archive-services-update-2024-10-17/

what if we use https://github.com/alanmcgovern/monotorrent and scrape the magnet links from pleasuredome https://pleasuredome.github.io/pleasuredome/mame/

Hello @paulmortlock
Yes archive.org has been attacked. I hope they should be back up soon.
The PD torrents are something I have considered and that monotorrent library looks like it may be the way to go.
Cheers
Sam

I have branched and am working on monotorrent using the magnet links from pleasuredome and so far does start downloading the files.

Looks like archive.org is working for anonymous access but you can't log in yet.

MAME-AO still wont work until you can login.

Looks like archive.org is down again.

Am working on something that can use the magnetlinks and run mame-ao any ideas welcome.

Hello @paulmortlock I've not had a chance to look at your work yet. But will do soon.

Lets keep this thread on topic for people arriving wondering what's happened to archive.org
@paulmortlock use this for BT comments https://github.com/sam-ludlow/mame-ao/issues/60

Yeah still not allowing logins, lets hope it gets sorted soon.

Hello. I made it to login yesterday, please, can you check?

Hello archive.org is now allowing logins.
But MAME-AO is not working with it, maybe they changed something to do with auth.
WORKAROUND:
Log into archive.org
Go here https://archive.org/download/mame-merged/mame-merged/005.zip/
Hit F12/network Grab the cookie and paste into this file.
D:\MAME AO\_TEMP\CACHE\archive.org-auth-cookie.txt

That should get you going.
I will fix properly later.
Cheers
Sam

Which browser are you using?

Hello @anonimo82 I'm using Edge.

I made it with the cookie, but I can't download mame-ao and mame, the first times out, the latter never gets done and I have to halt it.
I tried to manually download the json files, but I don't know where should I put them.
Where?
Thanks for any help.

I just tested a totally clean MAME-AO 1.97 with just the auth cookie.
It worked fine for mrdo and a2600 et

Please, use code tags

i had to do this.. sed -i 's/\r//g' filename && tr -d '\n' < filename > new_filename
but i'm using wine. oddly though i saved with notepad and got the same stuff, but i'm also cut and pasting accross platforms so.. anyway..  yeehaw! launched!

Please, which file did you exactly did that sed stuff?
I'm using wine too, so I'm very interested!
Thanks in advance for any help. @cewatkins

The auth cookie workaround
!!! must only be one line in the file

Sorry should have mentioned that before.

Please, which file did you exactly did that sed stuff? I'm using wine too, so I'm very interested! Thanks in advance for any help. @cewatkins P.S.: If you can, please, provide detailed info

Ok, yes, so it is what sam said, now I tried cut and paste, both browsers, notepad, nothing.
Then if you sed -i 's/\r//g' archive.org-auth-cookie.txt && tr -d '\n' < archive.org-auth-cookie.txt > archive.org-auth-cookie.txt1
then copy the .txt1 file over the .txt, it removes /n/r's that the editor puts back in
and somehow the api test does't like that, as sam-ludlow it must be one line, which I got, but as I cmp'd them, it complained of EOF too.  So. Also copy value out of the debugger helps a bit.
Now I did not edit the string so I don't  know what the %2 note above is.
when you have a non-authed cookie, it's simple enough, it doesn't complain that way but it has spaces too..
So, cookie jar management.. haha. I said .jar
Cookie Monster..
Also, to get it to make the .txt file in the first place i logged in with blank user name and passwords or it isn't there.

Thanks so much for sharing. But I'm stuck at downloading mame-ao and mame from github, the cookie already works.

MAME-AO has been fixed for the new archive.org auth in 1.98
https://github.com/sam-ludlow/mame-ao/releases
If you have any problems delete this file and restart MAME-AO
MAME AO\_TEMP\CACHE\archive.org-auth-cookie.txt
Cheers
Sam

Hello @cewatkins
As MAME-AO caches the GitHub metadata for 3 hours you probably just caught it wrong.
https://github.com/sam-ludlow/mame-ao/blob/026ca2c37cfda2092c39a147d499627eec80ec9a/source/Tools.cs#L298
Cheers
Sam

Closing archive.org has settled down now and MAME-AO is using the new archive.org authentication.

Yep, thanks a lot


Last to Disconnect, Please Unsubscribe!

TwitchChannelManager is not shutting down the respective twitchClient when the last kindle-user disconnects. We want to persist the secret code indefinitely (for now).
If the user de-authorizes manually, or their authorization expires by other means, there should be an exception produced when we use their cached OAuth. Catch that, and tell the user their secret key has expired and they'll need to go re-authenticate for a new one.

[ ] Connect a Kindle. Disconnect a Kindle. Reconnect a Kindle with the same secret code (saved as a cookie). Without producing a duplicate chat.

In the TwitchChatClient.java file, specifically on line 20 - 38, the following code snippet is present:
TwitchChat client = twitchClient.getChat();

// source the user's name from their authorization token
client.joinChannel(twitchChannel);

System.out.println("Connected to Twitch Chat Channel: " + twitchChannel);

EventManager eventManager = twitchClient.getEventManager();

eventManager.onEvent(IRCMessageEvent.class, event -> {
    Optional<String> message = event.getMessage();
    Optional<String> userDisplayName = event.getUserDisplayName();

    if(message.isPresent() && userDisplayName.isPresent()) {
        System.out.println(event.getUser().getName() + " > " + message.get());
        onMessage.accept(new ChatMessage(userDisplayName.get(), message.get()));
    }

});

Issue Description:
The client object is allocated for every subscription to a channel. Consequently, if all existing connections to a channel, such as AlgoBro, are closed and a new connection to the chat is subsequently opened, a new client will be spawned. The previous client instance will persist in memory, leading to potential issues and inefficiencies. This lingering object in memory is colloquially referred to as Limbo.

Rewrote from scratch. Got it workin, but it's a little messy.


localStorage.clear() not clearing

Steps to reproduce
Tell us about your environment:

Puppeteer version: 1.12.2
Platform / OS version: Mac os 10.13.6 (17G3025)
URLs (if applicable):
Node.js version: 11.9.0

What steps will reproduce the problem?
The following test:
describe("LocalStorage test", () => {
    it("tests localstorage", async () => {
        await page.goto("http://google.com");
        await page.evaluate(() => localStorage.setItem("foo", "bar"));
        await page.evaluate(() => localStorage.clear());
        await expect(await typeof page.evaluate(() => localStorage.getItem("foo"))).toBe(null);
    })
});

Fails saying foo is still a string, even after running localStorage.clear().

Error: expect(received).toBe(expected) // Object.is equality

Expected: null
Received: "object"

Difference:

  Comparing two different types of values. Expected null but received string.
Expected :null
Actual   :object
<Click to see difference>

      43 |         await page.evaluate(() => localStorage.setItem("foo", "bar"));
      44 |         await page.evaluate(() => localStorage.clear());
    > 45 |         await expect(await typeof page.evaluate(() => localStorage.getItem("foo"))).toBe(null);
         |                                                                                ^
      46 |     })
      47 | });
      48 |

      at Object.toBe (login.test.js:45:85)

 page.evaluate() returns Promise, typeof Promise return string 'object', and await 'object' returns the same string 'object'. You need something like:
await expect(await page.evaluate(() => localStorage.getItem("foo"))).toBe(null);

That does seem to work. Thanks!


Change default results_timeout to 12h

Signed-off-by: Zack Cerza<EMAIL_ADDRESS>

Cool, looks good, thx !

Tests passed for this pull request.
Refer to this link for build results: http://jenkins.ceph.com/job/teuthology-pull-requests/787/

LGTM

Tests passed for this pull request.
Refer to this link for build results: http://jenkins.ceph.com/job/teuthology-pull-requests/788/


myaccount apps access error in WSO2IS 6.1 K8S, then ingress have only 443 and 80 ports

Describe the issue:
in K8S ingress access only 443 and 80 ports. Then trying to access myaccount app - 404 error, because GET request send to https://wso.domain.com:9443/api/identity/auth/v.1.1/data/AuthRequestKey/
How to reproduce:

Deploy in K8S
Enable proxy in deployment.toml 443 port
Change hostname as Option 2 https://is.docs.wso2.com/en/latest/deploy/change-the-hostname/
Edit Identity Provider Entity ID (remove port 9443)
Edit callback for myaccount app

In logs ERROR {org.wso2.carbon.identity.application.authentication.endpoint.util.AuthenticationEndpointUtil} - Sending GET request to URL : https://is.test.com:9443/api/identity/auth/v1.1/data/AuthRequestKey/<some_key>, failed. org.apache.http.conn.HttpHostConnectException: Connect to is.test.com:9443 [is.test.com/<IP_ADDRESS>] failed: Connection refused (Connection refused)
How change GET request port?

so, if you want to use ingress & set your own endpoints for project . In versions 6.1 you need do add
/t endpoint. And in my case don't need "internal_hostname" parameter in deployment.toml


Patch ORTTrainer inference with ONNX Runtime backend

What does this PR do?

[x] Enable loss as output in ORTModelForCausalLM
[x] Enable using cache for causal lm task when doing inference in ORTTrainer
[x] Fix the ORT inference of ORTSeq2SeqTrainer when predict_with_generate=True

The PR is tested locally, and a PR will be opened for improving the current nightly test.
The caveat #719 always exists, but I won't deal with it because of a lack of bandwidth and need from the community.

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.


[Feature Request] Detecting web game engine which is packed to .asar file by electron

There are some games created by game engines those support to publish games to web platforms, for example, Cocos Creator, BabylonJS, Three JS, PlayCanvas, and so on.
Although, Cocos Creator does support to publish games to Native platforms, e.g. Mac/PC/Android/iOS, some developers may still publish their games to web platform directly by some reasons and use Electron to package the web content.
So the electron package format .asar can't be a detection rule for checking which game engine its content uses.
For instance, this game https://steamdb.info/app/2001150/depots/ is created by Cocos Creator. The detection script could not recognize that it's made by Cocos Creator.
Could you support to unpack .asar file and apply file rules inside its content to detect game engines?

Hi @diedyesterdaywashere , thanks for your fast reply.  May I ask how many electron apps committed to Stream?
Is it possible to add this feature if the number of electron app is small?

I saw that currently there is a little bit more than 500 games using electron, a very small portion of all games.
But we fully understand the additional cost, if there could be other ways, for example just read file headers inside Zip file without decompressing it, this would save a lot.
Reference:

https://pkware.cachefly.net/webdocs/APPNOTE/APPNOTE-6.3.9.TXT
https://docs.python.org/3/library/zipfile.html#zipfile.ZipFile.testzip

I see, download would be a noticable cost too


Documentation for app.set is ambiguous

I think the recommended usage of app.set includes storing your own values in there. For instance, the examples in the docs show: app.set('title', 'My Site');. Yet the description for this method doesn't necessarily allow for this usage:

Assigns setting name to value, where name is one of the properties from the app settings table.

This sentence seems to be quite explicit in that name must be one of the app settings values in the table that appears beneath this section, yet title doesn't appear in that table. This leads to ambiguity in how this method should be used.
If I'm right that this is also a general-purpose way to store values, would you be up for a PR that makes this more explicit? Consider:

Assigns setting name to value. You may store any value that you want, but certain names have a special meaning to Express. These special names are listed in the app settings table.

If this is not the case, then the examples should probably be updated, and Express should possibly throw an Error if you set an invalid value.
Thanks for reading!

Hi @jmeas would it be OK to re-log the issue in the repo for the website? https://github.com/expressjs/expressjs.com

But to the underlying question: yes, you can add custom settings in there to your liking.

And P.P.S yes, absolutely welcome to send a PR to add clarity 👍

Sure thing, @dougwilson ! Issue opened over there. I'll make a PR now.
Thanks for the quick response!


Feature request: Use favicons for pub.dartlang.org pages

Could be used to distinguish between the different kind of packages for the package specific pages and the filtered views.

Yes, would be great if:

the individual package pages show a custom favicon when kind is flutter_plugin (use favicon.png)

the flutter specific pub pages -- currently just /flutter/plugins -- also show that favicon

cc @isoos this would be a fairly small change, right?

Right now we have only detectedType=flutter_plugin, but what happens in the future where we may have several types and a package could get two or more? In those cases, choosing the icon may not be straightforward (e.g. who gets the priority?).
It would be also nice if we could maintain some kind of consistency across the pages, e.g. the flutter-plugin-favicon is a combination of the Dart logo + the Flutter logo.
Another option would be to fetch the favicon from the package's homepage, although it will be usually the github icon, so I wouldn't see much value in that.

detectedType is meant to be exclusive, so not too worried about that part.

I'm not sure that detectedType is exclusive, and even if it is now, in the future there may be overlaps.