Merge all regions into a single playlist and epg, Documentation

Hi, I've tried various switches to the end of index.js -all and tried adding a second mapping into config.json. I'm able to get the outputs for the two regions separately but can't workout how to combine the two together. Could we have an updated document to help with this?
Script works very well I'm just stuck on the combining.  Thanks

you could also use the --all command line option


Add Cloud capabilities

Temporarily closing and reopening this one to jog our CLA Bot so that we can get you setup there. Thanks for your contribution!

Hi @srimathiS, I'm your friendly neighborhood Azure Pull Request Bot (You can call me AZPRBOT). Thanks for your contribution!

It looks like you're working at Microsoft (sris). If you're full-time, we DON'T require a contribution license agreement.

If you are a vendor, DO please sign the electronic contribution license agreement. It will take 2 minutes and there's no faxing! https://cla.azure.com.

TTYL, AZPRBOT;

Closing this since it is not the latest


[Python] Dependabot changes ~=1.1.0 to >=1.1.0,<1.3.0

We have our requirements specified in Python using ~= and instead of just bumping the version, dependabot insists on changing the format using >=,<.

Hi! 👋 Thanks for reporting this.  The team is pretty swamped at the moment scaling Dependabot for all of GitHub :octocat:, but we'll take a look at this as soon as we can.

Can't reproduce in last time (https://github.com/fire-square/fire-square-style/pull/49, https://github.com/PerchunPak/pinger-bot/pull/49, https://github.com/fire-square/fire-square-style/pull/45).
Last PR with this problem was https://github.com/PerchunPak/mc-plugin-helper/pull/43.
Is this was accidentally fixed?

Reproduced this again in https://github.com/PerchunPak/mc-plugin-helper/pull/47, maybe it's now happening when dependency's version bumps on 2 version in one time?

Hello @PerchunPak! Sorry for not getting back earlier, too many things you know 😅.
I actually think this is intentional. Dependabot default for libraries (as opposed to applications, which would get the behavior you want by default) is to widen requirements instead of bumping them, see https://docs.github.com/en/code-security/dependabot/dependabot-version-updates/configuration-options-for-the-dependabot.yml-file#versioning-strategy.
You should get what you want by changing your configuration once we support the increase and increase-if-necessary strategies in Python. This is not yet supported, but will be very soon.

We added the required changes in this repo at https://github.com/dependabot/dependabot-core/pull/5605, but then I noticed that we still need some internal changes for this to work. I will update and close this issue once we roll those out.

@PerchunPak This is now live, can you verify the increase-if-necessary strategy works for you?


Some search parameters support not indicated in CapabilityStatement

Describe the bug
A consumer of our FHIR server refuses to use the _summary search result parameter, as they (reasonably) determine whether they can use it based on its presence in the server's CapabilityStatement.  The only items in CapabilityStatement.rest.searchParam are _type and _count (this is on release 4.0.198):
[
    {
        "name": "_type",
        "definition": "http://hl7.org/fhir/SearchParameter/type",
        "type": "token"
    },
    {
        "name": "_count",
        "type": "number"
    }
]

The server does accept a _summary=count and returns a Bundle in the expected form, e.g.
{
    "resourceType": "Bundle",
    "id": "1328b006-3cc2-4935-a832-a6034c8d3806",
    "type": "searchset",
    "total": 121
}

So it seems reasonable that this should be reflected in the CapabilityStatement, probably along with all other supported parameters.  See e.g. the lists of Common search parameters and Search result parameters.
FHIR Version?
Stu3
Data provider?
SQL Server
To Reproduce
Steps to reproduce the behavior:

Query the server's capability statement at the /metadata endpoint.

Expected behavior
All supported search/search result parameters will be returned in the CapabilityStatement.
Actual behavior
Not all supported search parameters were returned; in particular _summary is missing.

The global search parameters appear to be added at https://github.com/microsoft/fhir-server/blob/main/src/Microsoft.Health.Fhir.Core/Features/Conformance/CapabilityStatementBuilder.cs#L172 - explicitly just the 2 parameters mentioned above.

Thanks for reporting the issue and we will take a look.


Invalid context storeSubscription of type Subscription...

I am seeing the following error in the Chrome dev tools:
Warning: Failed context type: Invalid context `storeSubscription` of type `Subscription` supplied to `Connect(connectForm(Form))`, expected instance of `Subscription`.

The error happens when I @connect a component that contains another connected component somewhere deeply in the tree. The error is on the nested component, not the parent component. I have tried boiling this down to a minimally reproducible case, but I am having trouble coming up with one. When I remove the @connect from my top-level component, the error goes away. I haven't noticed any functional problems.
Any suggestions on creating a reproducible case?
FYI, the following case does not produce the error in the console:
@connect(state => ({
  hello: true,
}))
class Outer extends React.Component {
  render() {
    return <Child><Inner /></Child>;
  }
}

class Child extends React.Component {
  render() {
    return this.props.children;
  }
}

@connect(state => ({
  hello: true,
}))
class Inner extends React.Component {
  render() {
    return hello;
  }
}

render(<Provider store={store}><Outer /></Provider>, document.body);

Hmm.  For reference, are you using the React-Redux v5 beta release?

Whoops -- meant to include that in the original note. Yes, I am using 5.0.0-beta.3.

Is it possible you have 2 copies of React Redux loading?

Actually yes, that is exactly what's happening. Sorry for the false alarm!
For future reference: React uses the instanceof operator to check the type of StoreSubscription. Since I had two copies of React Redux loading, the left side of the instanceof check was a StoreSubscription from React Redux A, and the right side of the instanceof check was from React Redux B. Whoops!

Sorry, guys...but I have same error and still can't fix it. What do you mean 'two copies of React Redux loading'? In my case it looks like only one connect per component.
p.s.: I'm not sure, but my 'root' component connects to redux and also using own context.

It means you're code is including more than one copy of react-redux. If you see this error, you likely have issues with how your app is being bundled.

@jimbolla I include only once 'react-redux' at each component where 'connect' is required :(

@jimbolla

I have npm package with component that connects to redux (so it has dependency on react-redux). let's name it MyProvider

in my application I also connect other components, so it depends on react-redux

I moved MyProvider from npm package directly to application and there is no error anymore.
Is problem here?

I don't know enough about how you're bundling your code to be able to give you specific advice. General advice: run npm update and npm dedupe to make sure you don't have extraneous packages. If you're using webpack, you can use its visualizer tools to see specifically what's being included in your bundle.

@plandem My problem was that I was creating two bundles: common.js and a page-specific js file. Because of an error in the way I was bundling, the code for react-redux ended up in both bundles.

ok, finally  I moved  redux support into differ npm package with peerDependency. Now it works fine. Thanks.

Happened to me today after upgrading react-redux. Seems to be caused by hot reloading. Simply restarting webpack-dev-server solved the issue.

I also had this problem. For me, I had a duplicate react-redux due to using react-intl-redux that has listed react-redux as a dependency and not a peer dependency.  I've decided to remove this package from my project and just use react-intl provider directly.


The navPush binding doesn't seem to work in ts ?

this code :
<button grey [navPush]="pushPage">       Liste       <ion-icon name="ios-list-outline"></ion-icon>     </button>
Throws this error in the console :

If replaced with a this.nav.push(...) everything works fine.
Which will be the right way to implement when Ionic 2 will be in release mode (in Typescript ;-))?
How ever thanks a lot for your awesome framework.

What does your template/class look like?

The buggy code is in the end of the html template, (and I'm quite new to ionic)
this is the html :
`<ion-navbar *navbar primary>

Lieux disponible

<button secondary solid (click)="presentConfirm()">
Valider

      Liste

`
this is the class :
`import {Page, NavController, Alert} from 'ionic-angular';
import {ListPage} from '../list/list';
@Page({
templateUrl: 'build/pages/map/map.html',
providers: [ListPage]
})
export class MapPage {
private nav: NavController = null;
private pushPage: ListPage = null;
constructor(_nav: NavController, _listPage: ListPage) {
this.nav = _nav;
this.pushPage = _listPage;
}
presentAlert() {
let alert = Alert.create({
title: 'Low battery',
subTitle: '10% of battery remaining',
buttons: ['Dismiss']
});
this.nav.present(alert);
console.log('test');
}
presentConfirm() {
let alert = Alert.create({
title: 'Choisir une autre adresse de retour',
buttons: [
{
text: 'Non',
role: 'cancel',
handler: () => {
console.log('Fin');
}
},
{
text: 'Oui',
handler: () => {
console.log('Autre retour');
}
}
]
});
this.nav.present(alert);
}
switchList() {
console.log ("in switch");
this.nav.push(ListPage, {});
}
}`

So it's a little off.
[navPush] expects there to be a property on your class to bind to.
So a correct example would be.
<button grey [navPush]="myPage">

export class MyClass {
  myPage = ListPage;
}

Since you've used the [] bindings, it needs to point to a property.

I had one called pushPage that was initialized with a ListPage type but doing your way worked perfectly, thanks !


LlamaCpp - Logits Processor never ends

Describe the issue as clearly as possible:
Generating logits with LlamaCpp using the Logits Processor fails to terminate and to generate the last character '}', see example:
Steps/code to reproduce the bug:
# %%
from enum import Enum

from llama_cpp import Llama, LogitsProcessorList
from pydantic import BaseModel, constr

from outlines.integrations.llamacpp import JSONLogitsProcessor

# %%
class Weapon(str, Enum):
    sword = "sword"
    axe = "axe"
    mace = "mace"
    spear = "spear"
    bow = "bow"
    crossbow = "crossbow"

class Armor(str, Enum):
    leather = "leather"
    chainmail = "chainmail"
    plate = "plate"

class Character(BaseModel):
    name: constr(min_length=3, max_length=10)
    age: int
    armor: Armor
    weapon: Weapon
    strength: int

# %%
llama = Llama("TheBloke/Mixtral-8x7B-Instruct-v0.1-GGUF/mixtral-8x7b-instruct-v0.1.Q4_K_M.gguf", n_gpu_layers=999)

# %%
prompt = "Instruct: You are a leading role play gamer. You have seen thousands of different characters and their attributes.\nPlease return a JSON object with common attributes of an RPG character. Give me a character description\nOutput:"

logits_processor = JSONLogitsProcessor(Character, llama)

json_str = llama.create_completion(
    prompt,
    top_k=40,
    top_p=0.95,
    temperature=0.7,
    max_tokens=100,
    logits_processor=LogitsProcessorList([logits_processor]),
)["choices"][0]["text"]

print(json_str)
print(Character.model_validate_json(json_str))

Expected result:
{"name":"RPG_CHAR","age":25,"armor": "leather","weapon":"sword", "strength":10}

but results are most often:

{"name":"RPG_CHAR","age":25,"armor":  "leather","weapon":"sword", "strength":1000000000000000000000000000000000000000000000000000000000000000000

Error message:
No response
Outlines/Python version information:
Version information

```
0.0.36
Python 3.11.8 (main, Feb 26 2024, 15:36:12) [Clang 14.0.6 ]
```

Context for the issue:
This makes Outlines unusable with the LlamaCpp backend.

This is surprising to me because even GTP2 outputs reasonable results.
Two things:

The model seems to choose weird whitespace patterns. You can constraint this with the whitespace_pattern argument to LogitsProcessor.
Try setting temperature to 1.
We could also implement the constraints on the integer range.


New field creation when pressing enter

Hi,
when inserting text in a repeatable text input, if the "enter" key is pressed a new repeatable field will be created, which is nice, but unfortunately this behavior happens again when pressing the enter key on an unrelated text field (on the same Nova model, like a title field), which results in creating empty text fields and preventing the form submission.
I suggest removing this feature because it interferes with the normal form submission process and instead keep the permanent button "Add field" below a fields list.
Thank you for your work.
Simon

@SimonRTV thanks very much for reporting this.  If I'm honest I don't recall shooting for the whole "input on enter" thing as a feature - pretty sure that wasn't by design!
I'll try and replicate this locally and see if I can come up with a fix.  Will try and keep the same functionality within the field itself but without the more global side effects if possible.  Cheers


When dragging a tab to the top of another tab and dropping it, the shadow is displayed incorrectly

Describe the bug
When dragging a tab to the top of another tab and dropping it, the shadow is displayed incorrectly.
If you drag to the edge of the TabItem, the problem disappears.
In addition, when dragging Tab to the TabStrip area, the corresponding TabStripDragOver event will not be triggered (the triggerable area is too small)
Steps to reproduce the bug

Steps to reproduce the behavior:

Drag tab from another process/Drag and drop tabs in the same TabView
Make sure the two tabs overlap

Expected behavior

There should not be a situation where both tabs have shadows
Screenshots

Version Info

NuGet package version:
[Microsoft.UI.Xaml 2.4.3]

Windows app type:

UWP
Win32

Yes

Windows 10 version
Saw the problem?

Insider Build (xxxxx)

May 2020 Update (19041)
Yes

November 2019 Update (18363)

May 2019 Update (18362)

October 2018 Update (17763)

April 2018 Update (17134)

Fall Creators Update (16299)

Creators Update (15063)

Device form factor
Saw the problem?

Desktop
Yes

Xbox

Surface Hub

IoT

Additional context

@stmoy and @teaP FYI

Any solution about this?

I am unable to reproduce this issue. Can you try out the latest WinUI prerelease or provide a repro app? @StephenLPeters FYI

@chingucoding
Here is a repro:
TabDragBug.zip
It is worth noting that you should open two instances and drag tabs between the windows. Make sure the tab you drag is released above the selected tab in another window

Thank you for the repro app, I am able to repro this now. I'll take a look what is causing this behavior.

Unfortunately, this is not an issue with TabView but rather an issue with the underlying ListView which takes care of the visual states (also the issue is not about shadows but the pointerover behavior). See #3458 for more context.
There are multiple ways TabView can deal with this:

Switch to ItemsRepeater, this however is not a small task and will take quite some time
Handle the PointerOver state manually by using a different VisualState and handle PointerOver state manually. This is not ideal, however is an easier mitigation to the issue
Wait for the bugfix in ListView, this would need to wait until WinUI 3 to arrive which will be the slowest way to resolve this

@StephenLPeters @ranjeshj What are your thoughts on the way to handle this?

@chingucoding  I don't know VisualState very well, could you provide some code to alleviate this problem? Thanks a lot~

I'm afraid, there is no simple way to mitigate this for you. One thing you could do is handle the pointer over logic yourself, that would mean:

Listen to PointerExited
Listen to PointerEntered
Listen to Drop
Listen to DragEnter
Listen to DragLeave

and respond accordingly.
In addition to that, you would also need to retemplate TabView and remove the "PointeOver" visual state while introducing a new visual state that you will use to indicate pointer over.

This is a fairly low-level BUG. ListView is the most basic control. It should not have such or other problems and cannot be fixed in time.
Please set this problem as an urgent problem in WinUI3，and I hope that WinUI3 can be released as scheduled and not delayed like WinUI2.5.

Per comment of @marcelwgn, marking this as duplicate of #3458.


condition for granting _GROUPS_EDITOR_ROLE not working...

Please confirm the following:

I have upgraded to the latest GAM release from https://git.io/gamreleases and I still have this issue.
Yes, I am using version 6.17 on macOS 10.15.7
I am typing the command as described in the GAM Wiki at https://github.com/jay0lee/gam/wiki
Yes, I am using this command:

√ admin@station[~]% gam create admin<EMAIL_ADDRESS>_GROUPS_EDITOR_ROLE customer condition nonsecuritygroup

to give a user the groups editor role for the whole domain but limit  it to non-security groups
Result is:
Giving<EMAIL_ADDRESS>admin role _GROUPS_EDITOR_ROLE for CUSTOMER

ERROR: 403: The operation is not supported - forbidden

I can run the command successfully for the same user without the condition...

closing as this issue should be fixed in latest GAM7 release.


Add automatically generated change log file.

Hi, as I can see, you are carefully fill tags and labels for issues in your repo.
For such cases I create a github_changelog_generator, that generate change log file based on tags, issues and merged pull requests from :octocat: Issue Tracker.
This PR add change log file to your repo (generated by this script).
You can check, how it is look like here: Change Log
Some essential features, that has this script:

it exclude not-related to changelog issues (any issue, that has label question duplicate invalid wontfix )
Distinguish issues according labels:

Merged pull requests (all merged pull-requests)
Bug fixes (by label bug in issue)
Enhancements (by label enhancement in issue)
Issues (closed issues w/o any labels)

Generate neat Change Log file according basic change log guidelines.

You can easily update this file in future by simply run script: github_changelog_generator DaveWoodCom/XCGLogger in your repo folder and it make your Change Log file up-to-date again!
Hope you find this commit as useful. :wink:

Thanks for this, but I think I'm going to keep doing it manually for now.


build: use version catalog instead of properties

To support dependabot.

:tada: This PR is included in version 2.3.1 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Philio Tech PAN04-1B switch not reporting status in ZwaveJS

@AlCalzone already explained on discord the input he needed for this issue. I'm now putting this same information in Github as I  assume it is more appropriate to log it here.
I have migrated a Philio Tech PAN04-1B (link to zwave JS config DB;  link to manual) from my old home automation solution to Home Assistant and ZwaveJS.
Trouble is that in Z-waveJS it doesn't report it's status when I manually click the light switch (it does when I turn on/off the light in Home Assistant).
@AlCalzone and this forum post already hinted to the need to manually add associations so that group 2 and 3 point at the controller.
I have set an association to NodeID_1 for Load1 and Load2 using ZwaveJS2MQTT but that didn't solve the problem.
With these changes, the logs show these reports being sent when physically turning off one of the lights and these reports when physically turning on that same light.
Here is the homeid.json file  and here is the homeid.values.jsonl file.
This is all the information @AlCalzone asked for (and I produced it using the ZwaveJS2MQTT addon) but here is also the JSON dump which I produced using the ZwaveJS addon:
zwave_js_dump.zip

Hmm - seems like the device doesn't want to tell us which load was switched. I think the only way to get the actual status is to poll the values for endpoint 1/2 status whenever the value on endpoint 0 is changed.
To get these endpoint 0 values to exist, you'll need to edit the config file. Take the one I attached, and mount it as<EMAIL_ADDRESS>into the container (I am not sure what the first part of the path is in HA).
Afterwards, re-interview the device.
pan04.json.txt

@AlCalzone thank you.
As zwavejs doesn't allow re-interviewing the node I installed this file also in zwavejs2mqtt.
I reinterviewed the node using zwavejs2mqtt.
The change you did to the file is:
	"compat": {
		"preserveRootApplicationCCValueIDs": true
	}

I understand from what you write that this should somehow give me new values, but I didn't see any changes in what's available in zwavejs2mqtt.
Not sure you need it but just in case I attach here some logs (I have described for each report what action I took in terms of turning on or off a light):
zwavejs.log
I also attach instructions in case ever usefull for someone else how to get new device config files into zwavejs or zwavejs2mqtt (for me this was quite challenging):
instructions to install zwave device config file into zwavejs or zwavejs2mqtt addon.txt

I'm wondering whether the fact that it doesn't say which load was switched isn't related to this configuration parameter described in the manual:

And then there's also this configuration parameter:

Ohhh. I missed the last parameter there. That looks good, can you select the multi channel option?

When we discussed yesterday on Discord I mentioned that z-wavejs and z-wavejs2mqtt do not have the configuration parameter for this set-up.
I've tried to set this manually in home assistant in de developers tools panel using zwave_js.set_config_parameter with parameter 31, value 2 and bitmask 1, but I' not sure whether that is the correct way of doing it.

Leave out the bitmask, just set parameter 31 to value 2

When I launch the following service call:
service: zwave_js.set_config_parameter
target:
  entity_id: switch.licht_kelder_beide
data:
  parameter: '31'
  value: '2'

The log shows the error:
"Unexpected error for call_service at pos 1: Configuration parameter with value ID 22-112-0-31 could not be found"

Not entirely sure about HA. You could try defining the new config parameter in your mounted file and try with that.

OK I have guessed a bit how to do that and confirm that with this file it's working (also power consumption).
pan04NEW.json.txt
What is the next step now to get this fix in zwavejs for everyone?

@blhoward2 what do you think? Should we add something to our device files under metadata to mention known quirks?
I'm hesitant to change the configuration on users' devices by default, but we could at least mention it.

This would for example also be usefull for the Aeotec Smart switch 6, where Basic CC is disabled by default. The result is that if a user pushes the little button on this power plug to turn it on, ZwaveJS won't get notified. I guess allmost all users will want to turn this on and mentioning it as a known quirk would be helpfull.

What makes you believe this would apply to the Aeotec device? It doesn't have this parameter and we don't disable the Basic CC we map it usually. You should open your own issue so we can take a look.

Perhaps I wasn't clear enough. I was just illustrating how AlCalzone's suggestion to have a place where users can read about known quirks can be usefull. This Philip Tech device clearly has a quirk that is worth flagging to the user, and I was trying to illustrate it is not the only case as the aeotec also has some quirks that are worth flagging to the user.

OK well it was just a suggestion, in any case it is crystal clear that there's a crucial configuration parameter missing for this device and this configuration file adds it (https://github.com/zwave-js/node-zwave-js/files/6289927/pan04NEW.json.txt) so could we include this in zwaveJS so that at least the smart people (who can figure out they need this parameter without having read it in a 'known quirks' section) can use this z-wave device?

Yeah, that makes sense!

Maybe I misread your post. I thought you meant to add the parameter to the Aeotec file.

@quizzical86 are you sure about the parameter number 11? The manual says this is parameter 31.

No I'm not. This is a mistake on my side, it should indeed be parameter 31. However, what is very strange: I double checked and indeed I have configured it incorrectly with parameter 11 and yet this really solved my problem:
    {
      "id": "22-112-0-11",
      "nodeId": 22,
      "commandClass": 112,
      "commandClassName": "Configuration",
      "endpoint": 0,
      "property": 11,
      "propertyName": "Select Auto Report Type",
      "type": "number",
      "readable": true,
      "writeable": true,
      "label": "Select Auto Report Type",
      "default": 1,
      "stateless": false,
      "min": 0,
      "max": 255,
      "list": true,
      "allowManualEntry": false,
      "states": [
        {
          "text": "Basic type",
          "value": 1
        },
        {
          "text": "Multichannel type",
          "value": 2
        }
      ],
      "value": 2,
      "lastUpdate":<PHONE_NUMBER>195,
      "newValue": 2
    },

I have no explanation how this is possible, this device is not even supposed to have a parameter 11.

WTF... Maybe it does have both parameters. Anyways - I've merged it with parameter 31. Once the update is available, can you please test if the device reacts to that param too?

OK but my device which wasn't working is now working (with a non-existing parameter 11 set to "2").
Does that mean that to be able to test the new version you will be releasing I should:
1: remove the device from the network
2: factory reset it
3: add it back to the network and set the parameter 31 which you added
?

Yeah you can do that to make sure parameter 31 exists and is working.

I removed the device from the network reset the device multiple times and then added it back.
Either my resets were unsuccesful or the reset does not restore the parameters to factory defaults, since some parameters I had set did not go back to default and in addition my device works perfectly which probably indicates the multichannel parameter is still set.
So I don't seem able to do tests whether using parameter 31 (as specified in the manual) also works; unless there's another way to undo the fact that I have changed the non-existing parameter 11.

I knew I shouldn't have touched it while it was working perfectly :'-(
I wanted to test it for the good of others who use this device. So I downloaded the new file you created (the latest version is not yet available in home assistant) and installed it manually. Removed the z-wave device, did my best to reset it (not completely sure I succeeded but tried many many times) and then added it back.
So now the situation is that only Endpoint 3 (this is a virtual entity that controls both switches in the Z-wave device at the same time and can also show the sum of the wattage used by both lights) is updated.
So when I physically click the switch to turn on light 1 or light 2, this shows in this endpoint 3 (both in terms of the on/off status and the wattage) but does not show in Z-waveJS for the light in question.
Going back to the file I created (with the incorrect parameter 11, but which did solve my problem at the time) gives me the same result.
This is super frustrating as I had just gotten all my automations that are based on these lights working :-s
I have tried for many hours but can't find a way to get my device back to working condition :-(

What are your current configuration settings and associations?

My heart skipped a beat I think when you posted this reply!
Because z-waveJS in home assistant doesn't support associations I had forgotten about that.
I fired up ZwaveJS2MQTT and set an association to NodeID_1 for Load1 and Load2.

So I conclude that through some black magic this device accepts both parameter 11 and parameter 31 and the result is the same in both cases.
And the more important conclusion is that your new configuration file for this device works well if the user subsequently implements the known quirks of changing the default value of parameter 31 and sets the associations for Load1 and Load2 (using ZwaveJS2MQTT).

So I conclude that through some black magic this device accepts both parameter 11 and parameter 31 and the result is the same in both cases.

Might be that they realized their typo too late and subsequently changed the firmware to match 🤷🏻♂

Same Issue with the PAN06 switch from Philio. older version of the PAN04. Can this be fixed too? I cannot get it managed by myself.

Don't comment on a closed issue. Open a new one and reference this issue number if need be.


AB#8758 Components serialization

It would be good to also add some guidance on how to use them to README.md

Closing because the fix for collections is in here: https://github.com/Sitecore/Sitecore.Demo.XmCloud.PlaySummit/pull/85


CVE-2023-45288: Bump golang.org/x/net to v0.23.0

What this PR does / why we need it:
Address https://github.com/advisories/GHSA-4v7x-pqxf-cx7m by bumping golang.org/x/net to v0.23.0.
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #
Special notes for your reviewer:
Release note:

NONE

/approve

/cherry-pick release-v1.1

/cherry-pick release-v1.1


Regression - Array.filter

Bug Report
Array filter have possibly wrong signature or 4.8 introduced "Unconstrained Generics No Longer Assignable to {}" introduced type error
🔎 Search Terms

🕗 Version & Regression Information
After the update to 4.8.2
⏯ Playground Link
Playground - long cause copy some angular types for perfect reproduction - actual code on the end of code
💻 Code

export const serializeParams = <T extends {}>(query: T): HttpParams => {
  return new HttpParams().appendAll(
        Object.fromEntries(Object.entries(query))
        )
};

export const serializeParams2 = <T extends {}>(query: T): HttpParams => {
      return new HttpParams().appendAll(
        Object.fromEntries(Object.entries(query).filter(val => val[1] !== undefined))
    )
};

export const serializeParams3 = <T extends {}>(query: T): HttpParams => {
  return new HttpParams().appendAll(Object.fromEntries(Object.entries(query)
    .filter(([_, value]) => value !== undefined)
    .map(([key, value]) => {
      if (typeof value === 'object' && value !== null && !Array.isArray(value)) {
        return [key, JSON.stringify(value)];
      } else {
        return [key, value ?? ''];
      }
    })));
};

export const serializeParams4 = <T extends {}>(query: T): HttpParams => {
  const entries = Object.entries(query)
    .filter(([_, value]) => value !== undefined)
    .map(([key, value]) => {
      if (typeof value === 'object' && value !== null && !Array.isArray(value)) {
        return [key, JSON.stringify(value)];
      } else {
        return [key, value ?? ''];
      }
    });

  return new HttpParams().appendAll(Object.fromEntries(entries)); // here very weird - moving body to separate const fixes type error in VS code but build still fails with error
};

🙁 Actual behavior
unfiltered and filtered arrays behave differently
🙂 Expected behavior
unfiltered and filtered arrays behave the same

🔎 Search Terms

This should probably be replaced with a list of terms people can search for to find this issue and related issues.

I'm not seeing a difference between 4.7 and 4.8 in the Playground link here. Regardless, we'd need a shorter repro to be able to investigate this

What the OP mean is:
declare function f(arg: Record<string, string>): void;

function foo<T extends {}>(arg: T) {
    f(Object.fromEntries(Object.entries(arg).filter(val => val[1] !== undefined))); // TS(2345)
}

function bar<T extends {}>(arg: T) {
    f(Object.fromEntries(Object.entries(arg))); // OK
}

I'm working on clearer and shorter reproduction, will try to post it today

What the OP mean is:
declare function f(arg: Record<string, string>): void;

function foo<T extends {}>(arg: T) {
    f(Object.fromEntries(Object.entries(arg).filter(val => val[1] !== undefined))); // ts(2345)
}

function bar<T extends {}>(arg: T) {
    f(Object.fromEntries(Object.entries(arg))); // OK
}

@kbrilla I've already written that for you.

@MartinJohns Yes, I can confirm that. All the versions I tried raise the same error. I didn't agree with the OP either.


Fields do not appear - hasonefield entwine error

Current state:
On a versioned DataObject with multiple links, I cannot create a link as the different link type options do not refresh when the selection is changed.
The following error is visible in the console on the DataObject.
hasonefield.js?m=1545272442:2 Uncaught TypeError: $.entwine is not a function
    at hasonefield.js?m=1545272442:2
    at hasonefield.js?m=1545272442:13

If I refresh the "create new link" page, the error is not present and the link creation behaves as expected.
SilverStripe: 4.4.0
gorriecoe/silverstripe-link: 1.2.4
gorriecoe/silverstripe-linkfield: 1.0.0
silvershop/silverstripe-hasonefield: 3.0.1

This was fixed in https://github.com/gorriecoe/silverstripe-linkfield/pull/15


[Bug][Issue #14] : Disable note saved message for empty notes

[Issue #31] : Upgrade gradle version to Android Studio 2.2.3 recommended version

Also fixes #14, right?


update trust wallet icon

update trust wallet icon

I've merged this into a feature branch since it needs a changeset before it can be merged to master. I'll handle that.


Scaffold Tree: Render a structure in a tooltip

Draw large structures in a tooltip similarly to the filters panel (see https://github.com/datagrok-ai/public/issues/1608)

Structure tooltip is now available for tree nodes in version 1.5.9 of Chem package


NTR defense response to symbiont

Following up on #20255

+[Term]
+id: GO:0140546
+name: defense response to symbiont
+namespace: biological_process
+def: "Reactions triggered in response to the presence of a symbiont that act to protect the cell or organism from damage caused by that symbiont." [GOC:pg]
+is_a: GO:0098542 ! defense response to other organism
+property_value: term_tracker_item https://github.com/geneontology/go-ontology/issues/20261 xsd:anyURI
+created_by: pg
+creation_date: 2020-11-11T17:19:06Z


Missing train.py

Hi Guanglei,
Thanks for sharing the code. I guess the file train.py is missing from the GitHub repo. Could you please share the file as well?
Thanks.

It is run.py

Sorry, I have updated.

The line below imports Trainer from train.py but I could not find this file in the repo. Maybe I am missing something.
from train import Trainer

Thanks.


[build][relay][te][tir] remove unused vars / args

Fix clang 15.0.3 '-Wunused-but-set-variable' and '-Wunused-lambda-capture' warnings by removing / commenting-out code.

My overall goal is to get TVM building without warnings on clang 15.  This PR addresses '-Wunused-but-set-variable' and '-Wunused-lambda-capture' warnings.
I commented-out vs. removed code on a case-by-case basis, depending on my guess about authors' intents.
@ashutosh-arm @vinx13 @multiverstack-intellif : FYI this PR touches code that you guys contributed.

@csullivan : FYI this also touches some code you contributed.


UI: Edit instance - offer existing Groups

Description
Edit instance - offer existing Groups
This PR for fix https://github.com/apache/cloudstack-primate/issues/743

Types of changes

[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] New feature (non-breaking change which adds functionality)
[x] Bug fix (non-breaking change which fixes an issue)
[ ] Enhancement (improves an existing feature and functionality)
[ ] Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale

[ ] Major
[x] Minor

Bug Severity

[ ] BLOCKER
[ ] Critical
[ ] Major
[x] Minor
[ ] Trivial

Screenshots (if appropriate):

How Has This Been Tested?

@blueorangutan ui

@utchoang a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. [S]

UI build: :heavy_check_mark:
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/4820 (SL-JID-25)

@davidjumani @shwstppr was this manually tested?

@rhtyd Yes, tested and working


[google_sign_in] Plugin for web

Description
Adds a web implementation of the google_sign_in plugin, via JS interop with the gapi object.
Related Issues
https://github.com/flutter/flutter/issues/43774
Missing stuff

Unit tests
Update the pubspec.yaml once everything else has been pushed.

Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

[x] I read the Contributor Guide and followed the process outlined there for submitting PRs.
[ ] My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
[ ] All existing and new tests are passing.
[x] I updated/added relevant documentation (doc comments with ///).
[x] The analyzer (flutter analyze) does not report any problems on my PR.
[x] I read and followed the Flutter Style Guide.
[x] The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
[x] I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
[x] I updated CHANGELOG.md to add a description of the change.
[x] I signed the CLA.
[x] I am willing to follow-up on review comments in a timely manner.

Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?

[ ] Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md and increment major revision).
[x] No, this is not a breaking change.

(Rebased with latest federated_google_sign_in_native)

(Rebased with latest federated_google_sign_in_native)


Chache glitch and log spam

After upgrade to v1.4.1 storm of calling updateCache can be observed from unknown source.

There is additional repetative messages:
INFO (rpc-cache) rpc cache not found {"filename": "cache-0013142000-0013143000.cache", "read_store_url": "file:///firehose/sf-data/rpc-cache", "error": "not found"}
INFO (firehose.tier2) not saving cache, because empty {"parent_trace_id": "ce1298b5ee1e9df69170ea2201d7fc79", "trace_id": "f7a89284e5c91d73982d4caa0dc4d4b2", "module": "store_supply", "block_range": "[13141000, 13142000)"}

this comes from a build problem, these debug lines are not committed. I will produce another build with clean state.

Please try with the "rebuilt" binaries for v1.4.1.
Same commit hash, just a new binary.
Thanks

This fixed the issue. Now everything works as expected. Can be closed. Thank you !


Fix some issues in SensorHistory

The main bug was that sensor timestamps were incorrectly converted to
dump indices, because self.rx.timestamp_base was read before it was
initialised (and hence was 0). To avoid such silent bugs in future,
timebase_base now starts life as None rather than 0.
There is a deeper design flaw, in that sensor values may be received
before the first piece of data, at which point it's impossible to
convert timestamps to dump indices. This is fixed by changing the
SensorHistory class to work with timestamps instead of dump indices.
This removes the optimisation that allowed multiple updates of a sensor
during a single dump to be collapsed.
There was a secondary bug that if a sensor sample was received "late"
(i.e. after the value was already queried for the subsequent dump), it
was dropped entirely, instead of added and used for future dumps.

Fixes OPS-1262.


Added Binance to Zenbot

Hi Guys,
Here is the code to make binance work in zenbot. I've tested it in both sim, paper and live. Please contact me on discord if you have any questions.

Epic af!!!

:+1:  (didn't review)

@DeviaVir Fixed.

Are there options for the API keys in the conf.js? I cant find them

in the same fashion as all other exchanges you can add key and secret to a binance object.


Small release fixes

This does 2 things:

Prompts for confirmation before running the java artifact validation (this should save time)
Undoes the changes from https://github.com/apache/beam/commit/bc4ee851b5cb49a8c88754a22e75b0d45c16557e which caused artifacts to be staged to dist.apache.org with an _rcX appended to them

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

[ ] Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
[ ] Update CHANGES.md with noteworthy changes.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)

See CI.md for more information about GitHub Actions CI.

R: @jrmccluskey

Run Go PreCommit

Run Java PreCommit


'site clone-env' is not a registered command

Hi,
We're using the latest master branch of cli. A week ago we started to get the following error when running usual terminus site clone-env --site=sitename --from-env=test --to-env=branchname --db --yes command:
Error: 'site clone-env' is not a registered command. See 'terminus help'
Sometimes this issue disapears itself, sometimes it appears again. I'll update the issue if I find the reason of this weird behavior. But anyway - thoughts are very welcome.

Update: terminus help site clone-env doesn't show any information. For other commands terminus help works properly.

Steps to reproduce the issue are simple:

Clone the latest master branch of cli
run ``composer install` inside of a cloned git repo
try to run site clone-env command - it doesn't work.

Okay, found the reason in your changelog:
``

site clone-env is now site clone-content. Flags have changed from inclusive --db and --files to exclusive --db-only and --files-only and defaults to cloning both. (#403)
``

Thanks for keeping the changelog, guys! Much appreciated. The issue was solved.


#8892 image duplicates fix

Alright, this PR solves issue. (tho I will definitely work on it some more, because some test didn't pass). I figured out that this part of code is the problem. If used image model have additional fields, form.is_valid() can't be true, because user need yet to fill those fields (like alt in this example), therefore else: is executed, and there isn't any duplication validation there, so I just added it there.

After some investigation it turned out tests were failing because something else that I changed, but stuff on that branch is fine, sorry for my misunderstanding. This PR is basically ready for review.

@Dolidodzik  do you mind updating the branch for this PR then - it still has many tests that are failing

@lb- Yeah, you are right, I haven't commited that stuff. It's already on branch and everything seems to be okay.


[vulkan] Avoid dropping work in serializing command queue

We inspect all deferred submission one by one in ProcessDeferredSubmissions()
and put them in remaining_submissions if they are not ready. These work should
be returned to deferred_submissions_ when we cannot prepare VkSubmitInfo for
any of them. Previously we will just silently dropping them.
Also we cannot std::move the fence from FencedSubmission until it's clear that
we can prepare VkSubmitInfo with it. Otherwise the remaining_submissions will
see a nullptr fence.
These are issues exposed by https://github.com/google/iree/pull/2196.
Thanks Scott! :)

Updated to revert the change for inlining lambda and pulled in Scott's magic for silencing ASAN check.


Supress unneeded links for exotic / external terms on details pages

External terms should not really be having annotations in AmiGO; linking to annotations that will not be there in the usual closures can be confusing (see: #450 ) .
See the template additions for handling http://dev.planteome.org/amigo/term/ECO:0000501

duplicate with #559


bypass getItem on keys-only db streams

for faster createKeyStream functionality

Looks great, closing in favor of #70 so that we can test in Travis though.


#1786 - Enable Search Student for Institutions - part 1

In this PR

moved SearchStudents.vue to SearchStudentsCommon.vue to reuse the same UI for institutions and ministry users;
added link for BC Public institutions;
created API to search students by institutions;

I will create another PR to:

create e2e tests
fix bug on UI (responsiveness)
check an issue with the search when the user application has any pending exception. In that case the location_id is not defined and the user won't be found by the institution.

BC Public Institution

Other Institutions

Thanks for making the changes. Just one outstanding question.


[ISSUE #8405] Add the ability to write ConsumeQueue using fileChannel to prevent JVM crashes in some situations

Which Issue(s) This PR Fixes

Fixes #8405
Brief Description
Add the ability to write ConsumeQueue using fileChannel to prevent JVM crashes in some situations
How Did You Test This Change?

Codecov Report
Attention: Patch coverage is 51.85185% with 13 lines in your changes missing coverage. Please review.

Project coverage is 45.06%. Comparing base (d9d53d5) to head (2c790b3).

Files
Patch %
Lines

...n/java/org/apache/rocketmq/store/ConsumeQueue.java
42.85%
2 Missing and 2 partials :warning:

...ache/rocketmq/store/logfile/DefaultMappedFile.java
60.00%
3 Missing and 1 partial :warning:

...pache/rocketmq/store/queue/SparseConsumeQueue.java
0.00%
3 Missing :warning:

...ache/rocketmq/store/config/MessageStoreConfig.java
50.00%
2 Missing :warning:

Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #8403      +/-   ##
=============================================
- Coverage      45.12%   45.06%   -0.06%
+ Complexity     10931    10923       -8
=============================================
  Files           1274     1274
  Lines          88970    88993      +23
  Branches       11434    11439       +5
=============================================
- Hits           40144    40106      -38
- Misses         43826    43876      +50
- Partials        5000     5011      +11

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Excuse me. How can this prevent JVM crashes? Is it because fileChannel uses off-heap memory?

How can this prevent JVM crashes? Is it because fileChannel uses off-heap memory?

yes


Sample interval for Waymo model

Hi, thanks again for publishing the code for your work!
The waymo_dataset.yaml config file used by the Waymo models have SAMPLED_INTERVAL for train split set to 5, i.e. 20% of Waymo. However, the reported results are included in the 100% Waymo table in OpenPCDet repo.
Given that the model is only trained for 12 epochs, I assume the SAMPLED_INTERVAL needs to be set to 1, i.e. 100% Waymo, to reproduce the results?

Hi,
Yes. The result is trained on 100% Waymo.
Regards,
Yukang Chen

Thanks for the clarification!


Added polyfills for IE9+

Draft.js website doesn't work in IE9+. This is because Draft.js relies on 3 methods that are not currently supported in IE; String.startsWith, String.endsWith and Object.assign. This pull request adds them.
I assumed the Babel Polyfill would have added all three, but that appears not to be the case.
Please see https://github.com/facebook/draft-js/issues/83 for more details.

I believe #123 takes care of this.

Yep, my bad.

No worries, thanks for being proactive. :)


Missing init in cryptid_setup

Brief
The cryptid_setup function takes a parameter of type PublicParameters *. By looking at other top-level functions, clients would expect, that the instance being pointed to should not be initialized prior to the call. However, that's not the case, setup expects publicParameters->q to be already initialized.
See the TODO comment at CryptiID.c#125.
Task
Modify cryptid_setup so that clients do not have to initialize the appropriate field.

Closing this issue in favor of #10


Fix wrong case for "Sirupsen"

According to sirupsen/logrus/README.md:
"Everything using logrus will need to use the lower-case: github.com/sirupsen/logrus. Any package that isn't, should be changed"

Update mkconfig.go

Update server.go

Update dnssrv.go

Oops, this was already included in #15, never mind.


1.21

pls add 1.21
when i tried to port it, it was crashing and not sending the messages ingame

I will update it today or tomorrow!

Done, commit a8ddf94fc980c6d27e1c4556ddb6747c6dfc819b targets version 1.21.


deprecated parameters in settings.json

terminal.integrated.shell.linux
terminal.integrated.shellArgs.linux

https://github.com/owtaylor/toolbox-vscode/blob/main/code.sh#L371-L381

Also, these parameters causing errors for some tasks.
Example:
> Executing task: func host start <

func host start: No such file or directory
The terminal process "/usr/sbin/capsh '--caps=', '--', '-c', 'exec "$@"', '/bin/sh', '/usr/bin/fish', '-l', 'func host start'" failed to launch (exit code: 127).

I don't think the error is related to the deprecation. Can you give reproduction instructions for the error - is this with https://marketplace.visualstudio.com/items?itemName=ms-azuretools.vscode-azurefunctions ? It's not obvious to me why/how the terminal arguments would be manipulated to produce an error like that.

For some background the capsh invocation is to avoid problems because the user's UID is actually effectively root in the container and gets root like capabilities - in particular cap_dac_override, which means that it completely overrides file permissions.
The error is likely caused by some dodgy code in Visual Studio Code:
https://github.com/microsoft/vscode/blob/main/src/vs/workbench/contrib/tasks/browser/terminalTaskSystem.ts#L1141
// Set shellArgs to the value from the config
// Set toAdd to ['-c']
toAdd.forEach(element => {
if (!shellArgs.some(arg => arg.toLowerCase() === element)) {
	shellArgs.push(element);
        }
});
shellArgs.push(commandLine);

Because -c is already in shellArgs it doesn't get added, so what should have been:
/usr/sbin/capsh -caps= -- -c exec "$@"' /bin/sh /usr/bin/fish -l -c 'func host start'

ends up as:
/usr/sbin/capsh -caps= -- -c exec "$@"' /bin/sh /usr/bin/fish -l 'func host start'

I can't see any way that skipping -c could ever produce the right result. So, I think there's a Visual Studio code bug here. This part of the code was added as part of a larger commit, so it's not clear what the intent is - a pretty safe change would be to limit the the skipping to the Windows case, though I doubt it is correct in this case either.
I don't know a great workaround here - one thing we could do is set "terminal.integrated.automationShell.linux" to bash - we'd still have funky capabilities in the automated task case, which could be confusing, but the scope would be limited.

Filed a vscode issue - https://github.com/microsoft/vscode/issues/136459 - will need a workaround here however.


Create polymorphism.java

Example for polymorphism in java

great work please give this repo a star and follow me follow back😊


add method to get column indices created in segment folder

Description
This method expose the column indices created in local segment folder, which can be compared with indices in table config to decide which indices to remove as to be implemented in https://github.com/apache/pinot/pull/7286.
Upgrade Notes
Does this PR prevent a zero down-time upgrade? (Assume upgrade order: Controller, Broker, Server, Minion)

[ ] Yes (Please label as backward-incompat, and complete the section below on Release Notes)

Does this PR fix a zero-downtime upgrade introduced earlier?

[ ] Yes (Please label this as backward-incompat, and complete the section below on Release Notes)

Does this PR otherwise need attention when creating release notes? Things to consider:

New configuration options
Deprecation of configurations
Signature changes to public methods/interfaces
New plugins added or old plugins removed

[ ] Yes (Please label this PR as release-notes and complete the section on Release Notes)

Release Notes

Documentation

Codecov Report

Merging #7297 (b57b6dc) into master (0ea617f) will decrease coverage by 2.24%.
The diff coverage is 38.88%.

:exclamation: Current head b57b6dc differs from pull request most recent head 357022a. Consider uploading reports for the commit 357022a to get more accurate results

@@             Coverage Diff              @@
##             master    #7297      +/-   ##
============================================
- Coverage     71.26%   69.01%   -2.25%
+ Complexity     3274     3192      -82
============================================
  Files          1506     1109     -397
  Lines         74241    52154   -22087
  Branches      10735     7793    -2942
============================================
- Hits          52906    35995   -16911
+ Misses        17734    13581    -4153
+ Partials       3601     2578    -1023

Flag
Coverage Δ

integration1
?

integration2
?

unittests1
69.01% <38.88%> (+0.06%)
:arrow_up:

unittests2
?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

...va/org/apache/pinot/common/utils/SegmentUtils.java
0.00% <0.00%> (-68.75%)
:arrow_down:

...manager/realtime/HLRealtimeSegmentDataManager.java
0.00% <0.00%> (-83.03%)
:arrow_down:

...ata/manager/realtime/RealtimeTableDataManager.java
10.61% <0.00%> (-57.28%)
:arrow_down:

...t/local/segment/store/SegmentLocalFSDirectory.java
67.37% <0.00%> (-1.47%)
:arrow_down:

.../pinot/segment/spi/store/ColumnIndexDirectory.java
66.66% <ø> (ø)

...ache/pinot/segment/spi/store/SegmentDirectory.java
83.33% <ø> (ø)

...va/org/apache/pinot/spi/utils/CommonConstants.java
25.00% <ø> (ø)

...ache/pinot/common/metadata/ZKMetadataProvider.java
12.03% <7.69%> (-64.61%)
:arrow_down:

...not/common/metadata/segment/SegmentZKMetadata.java
43.29% <37.14%> (-32.71%)
:arrow_down:

...manager/realtime/LLRealtimeSegmentDataManager.java
47.26% <57.14%> (-25.88%)
:arrow_down:

... and 577 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dc90161...357022a. Read the comment docs.


port utils::mkdir_parents to rust

See #334. I'm casting mode_t to a signed int before sending it over. Not sure if there was a more appropriate way of going about it.

Coverage increased (+1.2%) to 40.413% when pulling 29157fec92d0af589b20d25be6f759f88c078409 on SeanBE:rust-mkdir-parents into c01acf47142637b8959036585bc30eaf28c30052 on newsboat:master.

Also, src/libnewsboat/src/configpaths.rs already has some similar code, can you please rewrite that try_mkdir in terms of mkdir_parents, to avoid duplication?

I appreciate the feedback/comments. Learnt a ton!

The remaining issues are trivial, so I'm approving this. Good job! You can rewrite history now if you want, to get rid of the revert commit. I'll merge this when you've fixed the import.
As we already discussed on IRC, clang-format is not used at the moment because different versions produce different formatting. The only formatter we use is for Rust, and your code passed it without a hitch. You don't have to get clang-format working for this PR, so don't worry about it.

cargo fmt is unhappy about an extra empty line, which is not worth an extra review round—I'll just fix it after merging. Thanks for doing all the hard work, @SeanBE!


Most popular journals

we made a list in 2022.
A couple of people said they would find it useful to see over the past 5 years, and maybe we could host on PomBase somewhere.
It doesn't need to be very prominent,  maybe:
https://www.pombase.org/documents

Do you have the previous list to jog my memory?

Action: add to "Other documents" here: https://pombase.org/documents

Action: add to "Other documents" here: https://pombase.org/documents

That's done for Tuesday morning.  I'll check then.

That's done for Tuesday morning. I'll check then.

https://pombase.org/documents
I turned it into an Excel file.  It's the last link on the page, under "Other documents".  It's not exactly prominent.  Should it be in a different section maybe?
The Documents page could do with updating anyway.

I will tag this onto a future announcement, but I just tried the link and I can't open the file.

I just tried the link and I can't open the file.

What error do you get?

I get this:

then when I  say yes I get a message that just says "style" and still nothing opens

Can you open this one?:
journal_count_with_year-2024.xlsx

yes!

I've swapped in the file that works.   I've put the file in its own "Statistics" sub-heading because it was very hidden under the "Other documents" heading.  Do you have a better suggestion for the heading?

Maybe call it 'publication metrics' (and we can broaden if we include other data?)

Maybe call it 'publication metrics' (and we can broaden if we include other data?)

Sounds good.  That change will be on the main site in a little while.

all done.
How often is the file updated?

How often is the file updated?

It has to be done manually.  I can put it in the calendar to remind myself.  How often do you think it should be updated?

every 3- (earth!) months.
But maybe update it next week  to pick up all the new Nature/Cell papers (I will put it in the next list of announcements).

that was meant to be every 3-6 months closer to 6 would be ok,

that was meant to be every 3-6 months closer to 6 would be ok,

I've put it in the calendar for every 5 months.

Out of curiosity what do we include int he journal list?  Ideally everything except "wrong organism" and "loaded in error".
I suddenly wondered about this last night...

Out of curiosity what do we include int he journal list? Ideally everything except "wrong organism" and "loaded in error".
I suddenly wondered about this last night...

It comes from a Chado query so includes every publication in Chado.  It might not be very accurate because there are non-pombe papers in Chado (like the UniProt paper and the SignalP paper now).
This is the list of triage types we export from Canto:

Curatable
Browser datasets, to host
Browser datasets, hosted
Method or reagent
Review or comment
Mutagenicity or toxicity study
Biotech
Modelling
Database
3D genome organization
Phylogeny and evolutionary studies
Cell composition or WT feature
Not physically mapped
Transposon related
Mating-type related
DNA replication related
DNA recombination related
Mitochondrial sequence related
Sequence feature or region
Structure
Other

OK sounds good!

I've updated https://www.pombase.org/data/documents/journal_count_with_year-2024.xlsx

That looks too low? Only around 80 publications so far this year?
What do we include here?

Sorry!  I should have said that I've updated it in SVN and it will be on pombase.org tomorrow.
The updated file is here if you do svn update:
pombe-embl/ftp_site/pombe/documents/journal_count_with_year-2024.xlsx

I was looking at the attached file though?
The current number for 2024 should be ~200 I would have thought (all in scope papers- there are >100 curated)

I was looking at the attached file though?

I didn't attach a file.  I just included the website link which will be up to date tomorrow,
The file in SVN has 203 publications for 2024.

I've updated the file on pombase.org:
https://www.pombase.org/data/documents/journal_count_with_year-2024.xlsx

OK, I thought I has looked at an attached file. Ignore!


🏃🏽 Getting started

This is an issue reserved for the TU Delft Student Software Project '23 - LaplaceRedux
Here are two issues that should help you get started with this package ...
Firstly, what I believe is a small bug, but failed to document properly a while ago (see issue for details):

[ ] #7

Secondly, I'd like you to revisit this previously closed issue for adding multi-class support. In particular, I would like you to test if this is actually working (I previously found that for multi-class problem we seem to end up with overly conservative posteriors (high predictive uncertainty everywhere).

[ ] #11

If you find the same, then I think this may be related to #20, which is the next item on the agenda and the first task of #25.

closed by #33


Internal Logging

Could you please add more information on:

How to log exceptions properly so that full stack trace is available
Why try catch should be on the top? I log an error but I don't see function failing in AppInsights
If I use multiple classes and Core DI, how logging should be configured for internal classes, how to log exceptions properly so that full stack trace is available

Thanks in advance.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: da28e92f-8a1e-9937-4547-180e26ede62e
Version Independent ID: 2b95e024-e55b-98d4-bd84-8cba06319c9e
Content: Azure Functions error handling guidance
Content Source: articles/azure-functions/functions-bindings-error-pages.md
Service: azure-functions
GitHub Login: @craigshoemaker
Microsoft Alias: cshoe

@demichev78 Thanks for the feedback! We will review and update accordingly.


Predefined searches are being generated with default viewer_enabled == false

This code in models.py appears that it should handle this, but didn't when I created test searches for api/event/log, they were all created with viewer_enabled == false.
viewer_enabled = models.BooleanField(blank=True, default=True,
                                         help_text='True if this search should'
                                                   'be displayed in the client'
                                                   'UI')

====================
example:
System default returns 1 predefined search for "Api call search".
1 search shows up in the ui for the Api call viewer:

And 1 in the saved search manager:

And after creating a new saved search...

There are now to save searches returned but the user-created search is not visible to to the default viewer_enabled flag being set to false:

So while the searches are returned via the api call, they will not be rendered to the client.

@jxstanford @vichargrave per John's suggestion I tried adding viewer_enabled: true 2 the client api call upon saved search creation. This does solve the problem. I will make a branch, commit this fix, and issue a pull request.


white listed IPs per service port

I'm deploying a new service, and this service will receive requests on port 8000. I want to ensure that only a static list of IPs can connect to this port.
In my mind the ideal solution is one where I can configure the iptables on each host, and have those rules precede anything that Docker does, so I can let Docker do all of it's networking magic without worrying about security.
Here is a solution that I have found: http://rudijs.github.io/2015-07/docker-restricting-container-access-with-iptables/
Unfortunately it relies on running an extra script on Docker start up, this seems not-intuitive and difficult to maintain.
I have also come across a PR which could address this: https://github.com/docker/libnetwork/pull/1032
Sadly it only recently entered triage.
This is a serious roadblock for us! Also worth noting that I am not deploying to cloud, working with a physical machine. Any suggestions on how we can resolve this issue are welcome!

@StefanPanait It has been detected that this issue has not received any activity in over 6 months. Can you please let us know if it is still relevant:

For a bug: do you still experience the issue with the latest version?
For a feature request: was your request appropriately answered in a later version?

Thank you!
This issue will be automatically closed in 1 week unless it is commented on.
For more information please refer to https://github.com/docker/libnetwork/issues/1926


Called workflows cannot be queued onto self-hosted runners across organisations/enterprises.

See, https://github.com/balena-io/environment-staging/actions/runs/3109617436 and https://github.com/balena-io/environment-staging/pull/717
A workflow called in balena-io (from product-os) appears not to be schedule-able on self-hosted runners. Could be a GH limitation.

For a laugh, logged a ticket under my personal account: https://support.github.com/ticket/personal/0/1806898
Let's see what they say...

I've confirmed with GH support, a workflow called in balena-io (from product-os) and scheduled on self-hosted runners, requires both orgs to be part of an enterprise. So we'll need to upgrade our GH plan(s), or make everything public. cc @klutchell @Page-

I believe we are already in the process of upgrading our plan.
On Sun, Sept 25, 2022, 7:40 p.m. Anton Belodedenko @.***>
wrote:

I've confirmed with GH support, a workflow called in balena-io (from
product-os) and scheduled on self-hosted runners, requires both orgs to be
part of an enterprise. So we'll need to upgrade our GH plan(s), or make
everything public. cc @klutchell https://github.com/klutchell @Page-
https://github.com/Page-
—
Reply to this email directly, view it on GitHub
https://github.com/product-os/flowzone/issues/225#issuecomment-1257310951,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AE4CWIEE64LFAEYK2JFRHJTWADPG3ANCNFSM6AAAAAAQTRNCEM
.
You are receiving this because you were mentioned.Message ID:
@.***>

I believe we are already in the process of upgrading our plan.

@apostolism @LPapapo can you folks confirm or deny this?

Upgraded to enterprise.


⚠ Bofrost.at has degraded performance

In 7315c33, Bofrost.at (https://www.bofrost.at) experienced degraded performance:

HTTP code: 200
Response time: 2083 ms

Resolved: Bofrost.at performance has improved in d4cdba9.


New package: NIS.One-Click-Backup version 1.2

[x] Have you signed the Contributor License Agreement?
[x] Have you checked that there aren't other open pull requests for the same manifest update/change?
[x] This PR only modifies one (1) manifest
[x] Have you validated your manifest locally with winget validate --manifest <path>?

[x] Does your manifest conform to the 1.5 schema?

Note: <path> is the name of the directory containing the manifest you're submitting.

Microsoft Reviewers: Open in CodeFlow

@microsoft-github-policy-service agree

Automatic Validation ended with:

Standard error:  Exception during executable launch operation System.AggregateException: One or more errors occurred. (The specified executable is not a valid application for this OS platform.)  ---
System.ComponentModel.Win32Exception (216): The specified executable is not a valid application for this OS platform.
--- End of stack trace from previous location where exception was thrown ---    --- End of inner exception stack trace ---    at System.Threading.Tasks.Task.ThrowIfExceptional(Boolean includeTaskCanceledExceptions)

@microsoft-github-policy-service agree

/AzurePipelines run

I believe it passed validation, but I'm going to run it again - without the label - to make sure.

Manual Validation ended with:

12:52:59 PM:  > 2023-09-12 12:52:58.366 [FAIL] Installer failed security check. Url: https://gitlab.com/dev-nis/nis-one-click-backup-qt/uploads/ded806b331306a9dfef4eb388cae135b/nis-ocb-install.exe Result: 0x80004005

This might be a false positive, and we can retry tomorrow.

Installer failed security check.

@stephengillie what does this exactly mean? What type of security is checked here?

/AzurePipelines run

Installer failed security check.

@stephengillie what does this exactly mean? What type of security is checked here?

Hi @dev-nis,
It's like a virus scan. We scan packages several times during different parts of validation.


Improve product loading performance for variants logic

Currently, variant guard uses an unscoped product data which is not optimal. We should:

Use scope to get product data
Consider creating specialized scope for variant data

QA steps:

When opening a PLP page with variants (or not purchasable one), additional call for product data should contain only minimum required fields (no categories, classifications, etc.)


Create a way for test runners to provide the project root of the test target

This issue applies to running both Dart and Flutter tests (dart test, and flutter test), but I'm filing in the Flutter repo to at least track the discussion somewhere.
Background:
DevTools extensions may need to connect to a test target to provide tooling (e.g. package:patrol which already provides a DevTools extension, and an in-progress extension for package:rohd. This is possible right now if a test target is run via dart run or flutter run, but is broken when a test is run via dart test or flutter test (tracked at https://github.com/flutter/devtools/issues/7183).
In order to detect which DevTools extensions are available for a VM service connection, we need to know what the package root is for the debug target (the directory that contains the .dart_tool/package_config.json file). We try to determine this by looking up the root library for the main isolate: https://github.com/flutter/devtools/blob/master/packages/devtools_app/lib/src/extensions/extension_service.dart#L198.

For dart run and flutter run this properly resolves to the target library (e.g. file:///path/to/my_test.dart).
For dart test and flutter test, this resolves to a file path like: file:///var/folders/gf/14ctmb656m3100h5z857669800fv4z/T/flutter_tools.9i1YVt/flutter_test_listener.ASUv35/listener.dart. In this case, we can't find the project root of my_test.dart.

See this thread on the #devtools-extension-authors Discord channel for the full discussion.
Proposed solution:
@jakemac53  proposed having the test runners (both for dart test and flutter test) register a service extension that returns the package root of the test target. This service extension should be available to call from DevTools, meaning it needs to be registered on the isolate we have access to (i.e. the isolate with the root library file:///var/folders/gf/14ctmb656m3100h5z857669800fv4z/T/flutter_tools.9i1YVt/flutter_test_listener.ASUv35/listener.dart in the example above).
We'd also need a way from DevTools to determine when we should call this service extension. In other words, we need to be able to detect when the main isolate was spawned by dart test or flutter test. We may be able to determine this solely by looking to see whether this new service extension is registered, and if it is, we can assume we are debugging a test target.
Tagging team members from the Discord discussion: @jakemac53 @christopherfujino @derekxu16 @bkonyi @DanTup

The draft at https://github.com/dart-lang/test/pull/2184/ addresses this issue dart test, but not for flutter test.
When running dart test test/foo_test.dart --pause-after-load, a VM service connection is available to debug the test runner where we have registered the service extension.
When running flutter test test/foo_test.dart --start-paused, the VM service connection that is available does not have access to the isolate where the service extension was registered. There appears to be another layer in flutter_tools (flutter test) that is not present in the dart test case. @christopherfujino

Update: with a combination of https://github.com/dart-lang/test/pull/2184 and https://github.com/flutter/flutter/pull/143481, this is the current state.

dart test test/foo_test.dart --pause-after-load: DevTools can successfully detect the service extension registered by package:test (https://github.com/dart-lang/test/pull/2184) and call it. This is because the VM service connection contains the isolate where this service extension was registered.
flutter test test/foo_test.dart --start-paused

Initially, DevTools cannot detect the service extension because the service extension will not get registered until you unpause.
After setting a breakpoint in the test library (a hack to ensure the process does not exit when hitting resume - we wouldn't need to do this if we had a --pause-on-exit flag), hit resume, and now the service extension is detectable and can be called. This is problematic because the service extension should be available when DevTools first connects.

A couple possible solutions:

register the service extension in some other place that is called on the test VM before it gets paused (is there a better place to perform the registration? @jonahwilliams)
Modify --start-paused flag behavior to still run some bootstrap code for the test before pausing so that the service extension will be registered
change DDS so that you can have it run a callback on start to optionally register service extensions that need to be available at startup. Here is a related request for being able to set initial service extension values on start up (https://github.com/dart-lang/sdk/issues/44611).

I think option one or two would be simpler. Thoughts @jonahwilliams @bkonyi @christopherfujino?

Maybe the vm service is not the way to do this? or alternatively, is there a way that flutter tools could provide some metadata to the vm service or dds when it starts it up?

Unfortunately, I don't think any solution with a service extension is going to work if the isolate it's registered on is paused since service extensions will only execute on running isolates.
It's hardly ideal, but the best way to find the project root for a test target will probably involve making some assumptions about how the actual test is run from the bootstrapping code in the root library. Since the root library will be importing the actual library we're interested in, we can look at the list of dependencies through Library.dependencies to find it. The code probably always has the following structure:
// @dart=3.4
import "dart:isolate";

import "package:test_core/src/bootstrap/vm.dart";

import "file:///private/tmp/foo/test/foo_test.dart" as test; // This is the library we're interested in

void main(_, SendPort sendPort) {
  internalBootstrapVmTest(() => test.main, sendPort);
}

Looking for the dependency where LibraryDependency.prefix is equal to 'test' should be good enough to figure out the library actually running the test. Assuming this prefix is always going to be 'test', this is probably the best approach, but someone more familiar with package:test is going to have to confirm whether or not that's the case.

Tests can be in any directory

Tests can be in any directory

I'm not sure that matters in this case. If the import prefix is always 'test', we should be able to find the library.

Oh sorry, I misunderstood what you were saying. Generally, we wouldn't consider it breaking to change that prefix, it is not a part of the public API. So I would definitely prefer that we not rely on it. The fact that we even bootstrap tests at all like this this, or any specifics of it, are private.

I'm picking this work back up. Sounds like there are drawbacks / concerns with trying to use service extensions and to trying to detect based on the test bootstrapping code, like @bkonyi suggested.
@jakemac53 is there a way we could use an environment variable that could be set from the test runner code (ideally in a way that would work for both dart test and flutter test) and then read that environment variable from DevTools?

I don't know a whole lot about environment variables, but I think a process can only set the environment for its subprocesses? At least via Dart APIs? So, I don't know that this is feasible since test doesn't actually spawn DevTools itself.
Please correct me if I am wrong/misunderstanding though!

Note that we also can't set -D Dart environment variables (I just realized I am not sure if you meant system or Dart environment variables, I was talking about system ones).
But in any case, in some modes we spawn tests as an isolated which cannot afaik have custom Dart environment variables.

Open Question: can we modify dart test to set the --mark-main-isolate-as-system-isolate flag in the VM? Users will not pass this flag to run their tests, and I think it is unreasonable to expect them to in order to use developer tools.

Will that also happen for dart run test and dart pub run test? I don't know how much these commands are just aliases for each other or what.

I think we can, it'll just involve some annoying plumbing in the short term...  This won't be a problem once we migrate DartDev to AOT since we'll be spawning child processes for dart run and dart test and can easily add the --mark-main-isolate-as-system-isolate flag to the argument list.

If this is more work than is justified pre-moving to DartDev to AOT, another option for the short term is to handle this in two separate ways for flutter test and dart test.

flutter test: for this case, we can grab the root library of the main isolate and look for the library import containing the test target.
dart test:

short term: use the service extension solution https://github.com/dart-lang/test/pull/2184 and call this service extension from DevTools when we cannot find the import containing the test in the main isolate's root library available.
long term: add the --mark-main-isolate-as-system-isolate flag for dart test once DartDev is moved to AOT

We'd still want test coverage for the flutter test case where we are poking at a library and making assumptions about its imports, which would eventually become the long term solution for dart test as well.
Thoughts?

How does this work with --pause-after-load? The service extension will be on an isolate that's paused, won't it?

Somehow the service extension gets registered from package:test and we can call it from DevTools... maybe it is registered on an isolate that is not paused? @jakemac53  may know the specifics.

I think it's probably just worth doing the work to pass the flag back to the VM since there's no ETA for the DartDev migration to AOT.

If you think this is the right approach, then this is fine with me. This will simplify things on our side anyway to have a single way to grab the test target that works for both flutter test and dart test. Do you have any cycles to help with this?

This issue is resolved. With a combination of Ben's change and this DevTools PR, we are able to find the URI of the test target, from which we can detect the project root using existing logic. This solution will break if the import or the prefix containing the test library from Flutter tools or package:test changes. To prevent future regressions, we will:

Add a comment to the code that generates the 'test' prefix for both the flutter test and dart test code paths.
Add an integration test in DevTools that verifies we can detect extensions for Dart and Flutter test targets (https://github.com/flutter/devtools/issues/7748).
Add a test to package:test and flutter_tools to verify the prefix does not change.

@jakemac53 do you have a code pointer for where the best place is to address items #1 and #3 from my previous comment?

This looks like the test bootstrapping code you are trying to find.
This is done in many different places and tools, specifically for the platform it is being compiled to, etc. Depending on specific contents is probably going to be highly problematic, because we allow people to "bring their own" bootstrapping too (build_test does this, and google3 does its own).

The specific URI you will see here is also likely going to vary by platform and not always be something useful.

The specific URI you will see here is also likely going to vary by platform and not always be something useful.

Can you provide an example of a case where the URI would not be useful? Do define what "useful" means for our case, we are looking for a URI from which we can detect the package root of the test target library. We detect this by walking up the tree until we find the folder that contains the .dart_tool directory, or by using a regexp check if the walk fails.

Can you provide an example of a case where the URI would not be useful?

Specifically the org-dartlang-app:// or other multi-root URI cases. These are special URIs which have their own "root" (the thing you actually want, but the point of them is to remove it from the URI so we have deterministic output).
So for a test you would see something like org-dartlang-app://test/some_test.dart which wouldn't afaik help you, because you don't know what org-dartlang-app means (there was a special flag to the compiler, to tell it what that means).

Note that it is quite possible in the test runner itself we don't today use these particular URIs, but we might want to in the future, and this would be a frustrating thing to be blocked on.
Google3 almost certainly does use these URIs, and build_test uses a relative URI (which I think won't help you).

Specifically the org-dartlang-app:// or other multi-root URI cases. These are special URIs which have their own "root" (the thing you actually want, but the point of them is to remove it from the URI so we have deterministic output).
So for a test you would see something like org-dartlang-app://test/some_test.dart which wouldn't afaik help you, because you don't know what org-dartlang-app means (there was a special flag to the compiler, to tell it what that means).

For this case, how can we give tooling access to the true value of org-dartlang-app://?

For this case, how can we give tooling access to the true value of org-dartlang-app://?

This is where a service extension or some other communication that is more explicit from the test runner about the project root would work better.

Also, general question about this logic: why do the URIs that use org-dartlang-app:// need to be deterministic?

Specifically for hermetic build systems like build_runner/bazel this matters (the result should be the same regardless of which computer the build runs on).
But also, for release builds it is better not to have the file system structure of the system the binary was built on be a part of the compiled app. Tests are different from release builds, but it is still generally not useful information (on a CI test failure you don't really want the full stack trace just the parts relative to the package root).

we are looking for a URI from which we can detect the package root of the test target library

We do not currently have a restriction that a test suite library is in a directory under the package root. This will be true by convention in the vast majority of cases, but it is not a structural guarantee.
If we want package information, we should be using the package config. Can you read the package config information from the isolate?

I suppose the package config doesn't track which package is the root  - I can't recall how reliably the package_config.json file is under the root package - @jakemac53 do you know if that's always the case?
We might want to revisit the idea of storing the working directory at startup.

I suppose the package config doesn't track which package is the root - I can't recall how reliably the package_config.json file is under the root package - @jakemac53 do you know if that's always the case?

The package config could be anywhere, and definitely in some cases might be just under some random temp or build directory.

we need to know what the package root is for the debug target (the directory that contains the .dart_tool/package_config.json file)

I guess I didn't stop to think if we were looking for that directory just for that file...
@kenzieschmoll - Is finding the root directory an indirect way to find package_config.json? Or is there another file that you will need to look for in .dart_tool?
If we only need to find package_config.json, I think the VM should already have that information. If we are looking to read some other file, it probably won't be in .dart_tool whenever package_config.json isn't in that location.

If we want package information, we should be using the package config. Can you read the package config information from the isolate?

How can we do this? I see this information is available from dart:isolate, but not from package:vm_service. @bkonyi can we expose this?
For detecting runtime extensions (which is what we are trying to do here for dart test and flutter test run targets), we are trying to find the package root for the sole purpose of finding the package_config.json file: https://github.com/flutter/devtools/blob/master/packages/devtools_shared/lib/src/extensions/extension_manager.dart/#L147-L151. So if we could get this from the main isolate, we wouldn't need to do any special detection for dart test and flutter test that is different from dart run and flutter run.

If we want package information, we should be using the package config. Can you read the package config information from the isolate?

How can we do this? I see this information is available from dart:isolate, but not from package:vm_service. @bkonyi can we expose this?

I'm not sure this is always populated, particularly for Flutter applications. I tried access this property with a Flutter desktop application and got the following exception:
[ERROR:flutter/runtime/dart_vm_initializer.cc(41)] Unhandled Exception: Unsupported operation: Isolate.packageConfig
#0      Isolate.packageConfigSync (dart:isolate-patch/isolate_patch.dart:326:7)
#1      Isolate.packageConfig (dart:isolate-patch/isolate_patch.dart:319:25)
#2      main (package:gallery/main.dart:28:23)
#3      _runMain.<anonymous closure> (dart:ui/hooks.dart:301:23)
#4      _delayEntrypointInvocation.<anonymous closure> (dart:isolate-patch/isolate_patch.dart:297:19)
#5      _RawReceivePort._handleMessage (dart:isolate-patch/isolate_patch.dart:184:12)

There's a similar exception thrown for Flutter web.
AFAIK, the VM only cares about the package config to pass it to the CFE, which needs it for package resolution. In the case of Flutter, the VM doesn't host the CFE itself so it's not necessary for the package config to be populated. Maybe there's an argument to be made for including the package config URI in the kernel format so it's always accessible?

Yeah, in general there are a lot of contexts where a package config might not be available to a running application - and I don't think that it makes sense for it to be generally available. Once an app is compiled, the package config is no longer relevant, may not longer exist at all, or the URI might not be valid at all in the context in which the app is running (web, a different machine, etc).

If we think this information doesn't make sense to expose from the VM service generally, but does make sense to expose from the test runner, I think it would be OK to register a VM service extension that proxies the dart:isolate APIs in the test runner. I do think that for the places we use the test runner, the VM's understanding of the package config is going to be as reliable or more than anything we can build in the test runner itself.

This issue has been resolved: https://github.com/dart-lang/test/issues/2246.


Adds task to load app users.

Note that the migration files shared drive now has a new file for app_users.tsv.

This PR creates an app user using the POST /users endpoint. Unfortunately, looking at how boostrap-superuser.pl works, there are user records in related tables that need to be made in order for the user to "work" properly in FOLIO. Need to POST to /perms/users and /service-points-users as well. See https://github.com/sul-dlss/folio-k8s/blob/a532824e95242b3dbefe5d93c56bf75ec0bc2d3c/docker/bootstrap-superuser/bootstrap-superuser.pl#L68-L126 . It is unclear if we should continue down this road or decide to use /user-import endpoint and decide upon a patron group and email address to assign app users.

I already ran the rake task on dev.

Based on #62 I'm not so sure we want to create the user this way.


in debugger, when calling toString(), make a 2nd call to get the full string text

Background here: https://github.com/dart-lang/sdk/issues/25242

(only if the first string result is truncated)

fixed in https://github.com/dart-atom/dartlang/pull/651


switch workspace on mouse-down to match swaybar

closes #686
Previously, the workspace only switched when you release the mouse, which feels slow and clunky compared to i3bar and swaybar.

LGTM, thanks!


Intro Chords shown with space's

Hi, @paurakhsharma .
Can you explain how to add some Chords Line without lyric?
For example:
Dear God - Avenged Sevenfold

[INTRO]
[F]  [C]  [Dm]  [Am]  [Bb]  [F]  [C]

"A[F] lonely [C]road, crossed[Dm] another cold sta[Am]te line..."

With format on above, i got result like this
Dear God - Avenged Sevenfold

INTRO
FCDmAmBbFC

 F        C             Dm                 Am
A lonely road, crossed another cold state line

As you can see, the output on intro part is not as i expected, What i need to do to get the result like below?
Dear God - Avenged Sevenfold

INTRO
F C Dm Am Bb F C

 F        C             Dm                 Am
A lonely road, crossed another cold state line

is this package discontinued and not maintained anymore?

Hey @fadhly-permata, sorry for late replay.
Currently this packages doesn't support this, I will work on adding this support soon.
For now you might need to add more spaces between the texts like this:
[F]    [C]    [Dm]        [Am]         [Bb]        [F]       [C]

It's ok for being slow resp, just feel wrong if I use not maintained version of packages.

For now you might need to add more spaces between the texts like this:

Yes, I've tested it already, and it works.
Thanks a lot for your response. I'll close this issue then

FYI, sometime multiple space not working, as you can see on my screenshot

For chords with 2 or 3 characters more spaces are required.

As you can see on my screenshot, I am using 4 spaces (even though I've tried using tab or \t char) still not taking any effect. there is no difference between, 3, 4, 5, 6, 7, or 8 spaces

Oh another thing is.
May you add some interpreter for ChordPro or Ultimate Guitar format?
You can use my  simple logic from my post on StackOverflow: https://stackoverflow.com/questions/75673904/get-chars-and-put-back-to-next-line

Ultimate Guitar format to Chord Pro format parser? Yes we can add it, please create a PR and may be add some tests for it.

Ultimate Guitar format to Chord Pro format parser?

Yes, I mean parser to convert from UG format to CP format.
OK, after I've done with my own project, I'll add the parser into flutter_chord.
Thanks  a lot


ImportError: cannot import name 'Dataset'

Since I was using allennlp in a different project, I continued using the pip version and not the allennlp branch -  git@5fd28f0f63d8ca96fc0931bebac8224fa071c35f outlined in this repo.
When running the baseline solvers (entailment based or BiDAF), I get the error ImportError: cannot import name 'Dataset' [entailment_tuple_reader.py] - which in the current release of allennlp seems to have been refactored away from allennlp.data.dataset.
Any ETA on when the arc-solvers codebase will be compatible with the release version of allennlp?

Same issue here. I think it's because the EntailmentTupleReader is written as the previous version. Have you tried to rewrite this class?

Since the numbers were reported with the 5fd28f0f63d8ca96fc0931bebac8224fa071c35f version of AllenNLP, we wanted to stick with the same version for reproducibility. If there is interest, we can create a new branch in this repo with the latest version of AllenNLP

Hi Tusha,
Thanks for the reply! I tried to rewrite the code using the latest version and was able to get similar results.
I have one more question about adapting bidaf model to arc. As mentioned in the paper "BiDAF was trained on SQuAD then further tuned to science questions using continued training. ", I wonder how you tune the model? For science questions, we do not have start and end position for ground truth labels. How do you handle that?

We used the BiDAF models trained on the Science and Bio questions in a previous AAAI paper. To create training data for the RC models from multiple-choice, we identified spans with sufficient overlap with the correct answer choice in the retrieved sentences. These spans were marked as the correct answers for training the BiDAF model. Daniel, the first author on the AAAI paper, would have a better idea about the exact details


Redirect only works on "Back up" and "Bidirectional"

Ludusavi version
v0.21.0
Operating system
Windows
Installation method
Standalone
Description
If you choose "Restore" neither mode would recognize the redirection.
Logs
No response

Huh.....
My understanding is first redirect input is what's path actually on disk, second input is what's on the mapping.yaml, then configured accordingly and it works in Bidrectional mode I'm using because I sync accross 2 Win + 1 Linux.
This understanding to me is natural but seems, wrong?

For a restore redirect:

The first input is where it was originally backed up from
The second input is where you'd like it to be restored to

There are some more notes and examples here: https://github.com/mtkennerly/ludusavi#redirects

Then how can make sense of bidirectional when restore and backup both field mean different thing?

In backup mode, a bidirectional redirect behaves like a backup redirect, with the same field order.
In restore mode, a bidirectional redirect behaves like a restore redirect, with the fields reversed.

In other words:

Backup redirect: When we back up a file from [source], we back it up as if it were from [target] instead
Restore redirect: When we restore a file that was backed up from [source], we restore it to [target] instead
Bidirectional redirect:

When we back up a file from [source], we back it up as if it were from [target] instead
When we restore a file that was backed up from [target], we restore it to [source] instead

([source] is the first field, and [target] is the second field)


Updated.

Better structure.

Wow, didn't realise anyone was actually interested in this project!
I'm having a little trouble understanding what's been changed here - has each file been copied into frameworks/php-mvc? I don't really understand the point of that.

This is flexible and standard(in future will be) structure for multiple frameworks and multiple applications.

I haven't seen this in any other projects - can you show me those which have done this?

Other projects??
Why should we imitate them?
The other projects do not have a standard directory structure.
Each to their own structural. zend cake ci symfony yii... Also, The main directory is not clean!
This is flexible/clean structure for multiple applications and multi-framework.

Plz checkout this:
http://forum.iranphp.org/attachment.php?aid=546
http://forum.iranphp.org/attachment.php?aid=547
:)


Removed autoprefixer as dependency, manual adding required prefixes for ...

...animations

looks good, merging :+1:

Indeed, you did it :+1:
Kudos!