Fixes all statement leaks in the driver.

Close all statements in the driver that are initialized locally but are never / sometimes not closed.
Fixes issue #308.

@peterbae,
Thanks for your contribution as a Microsoft full-time employee or intern. You do not need to sign a CLA.
Thanks,
Microsoft Pull Request Bot

Codecov Report

:exclamation: No coverage uploaded for pull request base (dev@93e087c). Click here to learn what that means.
The diff coverage is 38.09%.

@@          Coverage Diff           @@
##             dev     #455   +/-   ##
======================================
  Coverage       ?   46.36%
  Complexity     ?     2202
======================================
  Files          ?      108
  Lines          ?    25258
  Branches       ?     4175
======================================
  Hits           ?    11710
  Misses         ?    11529
  Partials       ?     2019

Flag
Coverage Δ
Complexity Δ

#JDBC41
46.23% <38.09%> (?)
2193 <0> (?)

#JDBC42
46.16% <38.09%> (?)
2194 <0> (?)

Impacted Files
Coverage Δ
Complexity Δ

...oft/sqlserver/jdbc/SQLServerPreparedStatement.java
50.91% <ø> (ø)
161 <0> (?)

...soft/sqlserver/jdbc/SQLServerDatabaseMetaData.java
29.7% <0%> (ø)
49 <0> (?)

.../microsoft/sqlserver/jdbc/SQLServerXAResource.java
0% <0%> (ø)
0 <0> (?)

...oft/sqlserver/jdbc/SQLServerParameterMetaData.java
24.46% <62.5%> (ø)
32 <0> (?)

...oft/sqlserver/jdbc/SQLServerCallableStatement.java
29.19% <75%> (ø)
90 <0> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 93e087c...195719e. Read the comment docs.

Codecov Report

:exclamation: No coverage uploaded for pull request base (dev@93e087c). Click here to learn what that means.
The diff coverage is 38.09%.

@@          Coverage Diff           @@
##             dev     #455   +/-   ##
======================================
  Coverage       ?   46.36%
  Complexity     ?     2202
======================================
  Files          ?      108
  Lines          ?    25258
  Branches       ?     4175
======================================
  Hits           ?    11710
  Misses         ?    11529
  Partials       ?     2019

Flag
Coverage Δ
Complexity Δ

#JDBC41
46.23% <38.09%> (?)
2193 <0> (?)

#JDBC42
46.16% <38.09%> (?)
2194 <0> (?)

Impacted Files
Coverage Δ
Complexity Δ

...oft/sqlserver/jdbc/SQLServerPreparedStatement.java
50.91% <ø> (ø)
161 <0> (?)

.../microsoft/sqlserver/jdbc/SQLServerXAResource.java
0% <0%> (ø)
0 <0> (?)

...soft/sqlserver/jdbc/SQLServerDatabaseMetaData.java
29.7% <0%> (ø)
49 <0> (?)

...oft/sqlserver/jdbc/SQLServerParameterMetaData.java
24.46% <62.5%> (ø)
32 <0> (?)

...oft/sqlserver/jdbc/SQLServerCallableStatement.java
29.19% <75%> (ø)
90 <0> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 93e087c...195719e. Read the comment docs.


ibmcloud provider

Adding ibmcloud as a new provider

@googlebot I fixed it.

@googlebot I fixed it.


Customizing components in theme with 0 margin doesn't work (uses defaults instead)

Description
Passing a 0 value to for instance marginTop property should produce no top margin for the component, but default one is applied instead. It can be "fixed" by passing "0" (as string).
CodeSandbox/Snack link
https://snack.expo.dev/-01m8XvAb
Steps to reproduce

Open reproduction link.
Observe the space between both labels.
Comment lines 10 and 11.
See that no changes were applied.
Uncomment lines 13 and 14.
See that there's no space between labels (margins are actually set to 0).

NativeBase Version
3.4.16
Platform

[X] Android
[ ] CRA
[ ] Expo
[X] iOS
[ ] Next

Other Platform
Web
Additional Information
I suppose 0 here is treaded as falsy value so the default one is used instead. That's why when passing "0" which is not falsy, everything works ok. Probably there is somewhere an OR (||) operator used instead of Nullish coalescing operator (??).

Hi @mkurczewski, Thanks for reporting the issue. we will look into this. for now, you can do my : 0 or pass value in string.


When I compile example/chi-tool on the Raspberry Pi, there is an error in the compilation

g++ -MMD -MF obj/commands/pairing/chip-tool.PairingCommand.cpp.o.d -Wconversion -O0 -g2 -fno-common -ffunction-sections -fdata-sections -fno-exceptions -fno-unwind-tables -fno-asynchronous-unwind-tables -fPIC -Wall -Wextra -Wshadow -Wunreachable-code -Werror -Wno-unused-parameter -Wno-psabi -Wno-cast-function-type -fdiagnostics-color -fno-strict-aliasing -D_REENTRANT -isystem../../third_party/connectedhomeip/third_party/ot-br-posix/repo/src -isystem../../third_party/connectedhomeip/third_party/ot-br-posix/repo/include -I/usr/include/dbus-1.0 -I/usr/lib/aarch64-linux-gnu/dbus-1.0/include -I/usr/include/gio-unix-2.0 -I/usr/include/libmount -I/usr/include/blkid -I/usr/include/glib-2.0 -I/usr/lib/aarch64-linux-gnu/glib-2.0/include -std=gnu++14 -fno-rtti -Wnon-virtual-dtor -DCHIP_CONFIG_IM_ENABLE_SCHEMA_CHECK=1 -DCHIP_HAVE_CONFIG_H=1 -DLWIP_IPV4=1 -DLWIP_IPV6=1 -DLWIP_API=1 -DLWIP_ETHERNET=1 -DLWIP_SLIP=0 -DLWIP_6LOWPAN=1 -DLWIP_PPP=1 -I../.. -I../../third_party/connectedhomeip/src/app/util -I../../third_party/connectedhomeip/src/app -Igen/third_party/connectedhomeip/src/app/include -I../../third_party/connectedhomeip/src/include -I../../third_party/connectedhomeip/src -Igen/include -I../../third_party/connectedhomeip/src/lib -I../../third_party/connectedhomeip/config/standalone -I../../third_party/connectedhomeip/third_party/nlassert/repo/include -I../../third_party/connectedhomeip/third_party/nlio/repo/include -I../../third_party/connectedhomeip/src/lwip/standalone -I../../third_party/connectedhomeip/third_party/lwip/repo/lwip/src/include -I../../third_party/connectedhomeip/src/lwip/include -I../../third_party/connectedhomeip/src/setup_payload -Igen -Igen -I../../third_party/connectedhomeip/third_party/inipp/repo/inipp -I../../third_party/connectedhomeip/src/app/server -c ../../commands/pairing/PairingCommand.cpp -o obj/commands/pairing/chip-tool.PairingCommand.cpp.o
../../commands/pairing/PairingCommand.cpp: In member function ‘CHIP_ERROR PairingCommand::PairWithoutSecurity(Command::NodeId, Command::PeerAddress)’:
../../commands/pairing/PairingCommand.cpp:80:95: error: ‘CHIP_ERROR chip::Controller::DeviceCommissioner::PairTestDeviceWithoutSecurity(chip::NodeId, const chip::Transport::PeerAddress&, chip::Controller::SerializedDevice&)’ is deprecated: Available until Rendezvous is implemented [-Werror=deprecated-declarations]
80 |     return mCommissioner.PairTestDeviceWithoutSecurity(remoteId, address, serializedTestDevice);
|                                                                                ^
In file included from ../../commands/pairing/../../config/PersistentStorage.h:21,
from ../../commands/pairing/PairingCommand.h:21,
from ../../commands/pairing/PairingCommand.cpp:19:
../../third_party/connectedhomeip/src/controller/CHIPDeviceController.h:341:5: note: declared here
341 |     PairTestDeviceWithoutSecurity(NodeId remoteDeviceId, const Transport::PeerAddress & peerAddress, SerializedDevice & serialized);
|     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
cc1plus: all warnings being treated as errors
[173/395] c++ obj/config/chip-tool.PersistentStorage.cpp.o
ninja: build stopped: subcommand failed.
Proposed Solution
<suggested fix, suggested enhancement>

My gcc version is：
g++ (Ubuntu 10.2.0-13ubuntu1) 10.2.0
Copyright (C) 2020 Free Software Foundation, Inc.
This is free software; see the source for copying conditions.  There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
In file included from ../../third_party/connectedhomeip/src/platform/Linux/bluez/AdapterIterator.cpp:18:
../../third_party/connectedhomeip/src/platform/Linux/bluez/AdapterIterator.h:87:22: error: missing initializer for member ‘chip::DeviceLayer::Internal::AdapterIterator::::address’ [-Werror=missing-field-initializers]
87 |     } mCurrent = { 0 };
|                      ^
../../third_party/connectedhomeip/src/platform/Linux/bluez/AdapterIterator.h:87:22: error: missing initializer for member ‘chip::DeviceLayer::Internal::AdapterIterator::::alias’ [-Werror=missing-field-initializers]
../../third_party/connectedhomeip/src/platform/Linux/bluez/AdapterIterator.h:87:22: error: missing initializer for member ‘chip::DeviceLayer::Internal::AdapterIterator::::name’ [-Werror=missing-field-initializers]
../../third_party/connectedhomeip/src/platform/Linux/bluez/AdapterIterator.h:87:22: error: missing initializer for member ‘chip::DeviceLayer::Internal::AdapterIterator::::powered’ [-Werror=missing-field-initializers]
../../third_party/connectedhomeip/src/platform/Linux/bluez/AdapterIterator.h:87:22: error: missing initializer for member ‘chip::DeviceLayer::Internal::AdapterIterator::::adapter’ [-Werror=missing-field-initializers]
cc1plus: all warnings being treated as errors
[6/126] c++ obj/third_party/connectedhomeip/src/platform/Linux/libDeviceLayer.MdnsImpl.cpp.o
ninja: build stopped: subcommand failed.


Implement dataset class

Initial idea from meeting on 7th April:

Something we need to coordinate with @callummole is how DD1 will look like. The QUiPP style is slightly different to the Stadler.

Requires #4

Use a class method for instatiation on the TabularDataset


Do not include drain_timeout_ms set to 0 in exported config file when it is not set for services.

Rancher Server - v1.6.11-rc4
Do not include drain_timeout_ms set to 0 in exported config file when it is not set for services.

Tested with rancher-server build from v1.6 branch.
drain_timeout_ms is not included in exported config file when it is not set for services.


Cleanup CAM in Chalmers Vehicle Adapter

New code for creating local CAMs using the getters implemented by TNO.


fixes libgdx/libgdx#2252 reduce CPU usage in OpenALAudioDevice

I had the same problem as in libgdx/libgdx#2252. When writing to audio device, Thread is not sleeping because of a wrong time calculation which result to zero (no sleep at all) with sample rate of 44100 Hz or above.

What exactly is this fixing and why is this a fix for #2252 ?

Sorry, I thought my commit comment body was enough.
When writing to an AudioDevice, OpenALAudioDevice implementation wait for a free buffer to fill using Thread.sleep. With some configurations, wait duration is rounded to zero which lead to poll continuously OpenAL without sleeping and then eat 100% of CPU.
This issue is due to wait duration calculation : (long)(1000 * secondsPerBuffer / bufferCount)
Divide by bufferCount doesn't make sense, it should just wait 1000 * secondsPerBuffer which ensure to have a free buffer after this delay.
Default configuration is concerned by this issue :

stereo (2 channels)
PCM 16 bits (2 bytes per sample)
sample rate of 44100 Hz
audioDeviceBufferSize = 512
audioDeviceBufferCount = 9,

secondsPerBuffer is computed like this : secondsPerBuffer = (float)bufferSize / bytesPerSample / channels / sampleRate;
with default configuration : secondsPerBuffer = 512 / 2 / 2 / 44100 ~= 3 ms. And thread sleep time is 3/9 rounded to zero.
Once fixed, thread sleep time is 3ms and doesn't eat 100% CPU anymore.
Both lwjgl and lwjgl3 implementations are concerned.
I mentionned Issue #2252 because it describe the problem.

I was surprised this fix was not shipped with last LibGDX release. Do you need more information on this ? how can I help ?

Surprised as well, I'm using your patch in my custom backend and works as intended. So well, thanks!

Mostly because we haven't pulled it in before the release. Will be part of the next release.

OK, I understand, PR was very close to 1.9.5 release.


Feature request: fetch options

Can we add default fetch options such as {follow: 'manual'}. See https://developer.mozilla.org/en-US/docs/Web/API/Fetch_API/Using_Fetch#supplying_request_options
I've put pocketbase behind an SSO proxy. When auth is needed, the proxy redirects to a login page.
In that case, doing any fetch request (i.e. Records.getList) will automatically follow the redirect and hit a valid html login page, which fails silently. doesn't even throw an error.
my proposal is adding something like:
client.setDefaultFollow('manual')
client.setDefaultCredentials('include')
client.setDefaultCache('no-cache')
And also to throw an error if response.status >= 300.

This was recently discussed in https://github.com/pocketbase/js-sdk/issues/18.
I would consider adding a way to set a default fetch configuration options in the next minor version of the SDK (somewhere around next week).
About following redirects and throwing if response.status >= 300 - you usually want to follow redirects because, depending of your network infrastructure, there could be several non-auth layers before reaching the application (eg. load balancer).
I'm not sure how easy is to customize the SSO proxy you are using, but in my opinion the more correct way to resolve the issue with the silently failing redirect would be to redirect to the login page with 401/403 and you'll be able to catch the error.

awesome!

About following redirects and throwing if response.status >= 300 - you usually want to follow redirects because, depending of your network infrastructure, there could be several non-auth layers before reaching the application (eg. load balancer).

a user in that scenario can leave the default, follow: 'redirect', and redirect responses will never be encountered, only the final response.
thinking about it, we're checking for successful client responses, so a check for response.ok would be technically correct. as per https://developer.mozilla.org/en-US/docs/Web/API/Response/ok.
if checking for successful client responses is not possible, perhaps expose the response object? or any of the following would do: response.ok, response.status, response.redirected. though, this would likely be the most difficult option.

@kennethklee In the recent v0.3.0 release of the SDK package, you could make use of the beforeSend and afterSend functional hooks to adjust, inspect, throw, etc. the request and response data:
const client = new PocketBase('http://localhost:8090');

client.beforeSend = function (url, reqConfig) {
    // For list of the possible reqConfig properties check
    // https://developer.mozilla.org/en-US/docs/Web/API/fetch#options
    reqConfig.headers = Object.assign(reqConfig.headers, {
        'X-Custom-Header': 'example',
    });

    return reqConfig;
};

client.afterSend = function (response, data) {
    // do something with the response state
    console.log(response.status);

    return Object.assign(data, {
        // extend the data...
        "additionalField": 123,
    });
};

More details you could find in the docblock comment of the function hooks - https://github.com/pocketbase/js-sdk/blob/d87034337ff3ce24c972a45646db12236e86a2cf/src/Client.ts#L21-L63
The above should cover your use case and enables you to throw on 200 response or to disable following redirects.

awesome, thanks for exposing the response object!


Should we trim function parameters?

E.g. for clang_Comment_getChild(CXComment Comment, unsigned ChildIdx);

No, but at least we can do more Go idiomatic names. Lowercase the first character and get rid of the underlines.


Fix typo in specifications.md

The sentence:

You can read those specifications to bet information on newer features.

Should read:

You can read those specifications to get information on newer features.

Internal previews

📄 File
🔗 Preview link

docs/csharp/language-reference/specifications.md
C# standard specification

Thanks for the prompt follow up @BillWagner 👍


Update History for Devs

add the ability to see update history for smart apps, so devs can easily see logs and past responses from a smart app
this data should be stored in memory, with the last 10 requests.   and should be available from the context menu
when open, all smart apps should pause

added


Fixed broken link to Holographic button

Overview
Found a broken link to the Holographic Button prefab in the readme. Fixed it
Changes

Fixes: Changed readme file link to correct prefab.

Needs to target htk_development branch, not master

@StephenHodgson Oops! Changed branch


Dividers don't touch when using .is-narrow and .has-content-centered when the content is too wide

Can't replicate, so I assume it has been fixed in the meantime.


content and hotel python examples

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

BingAds/hotel-service/code-example-subaccounts.md
:white_check_mark:Succeeded

BingAds/shopping-content/code-example-download-catalog-status-report.md
:white_check_mark:Succeeded

BingAds/shopping-content/code-example-manage-catalogs.md
:white_check_mark:Succeeded

BingAds/shopping-content/code-example-manage-products.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


[BUG] Discrepancy between patch and reload functionals in FLOPs profiler

In the Flops profiler, the list of functionals restored in _reload_functionals is missing some functions wrapped in _patch_functionals. This leads to wrong FLOPs counts when using consecutive calls to profiler.start_profile (and possibly some minor overhead when using these functional later on).
To reproduce
Example comparing torch.nn.LayerNorm (not properly restored) and torch.nn.Linear (properly restored): Repeated calls with the exact same inputs should give the same result.
modules_test = [torch.nn.LayerNorm(256), torch.nn.Linear(256, 128)]
num_calls = 3
for m in modules_test:
    print(f"\n\nTesting {m}")
    for i in range(num_calls):
        flops, macs, params = get_model_profile(m, (1, 256), print_profile=False)
        print(f"  Call {i + 1}: flops = {flops}; macs = {macs}; params = {params}")

giving the output:
Testing LayerNorm((256,), eps=1e-05, elementwise_affine=True)
  Call 1: flops = 1.28 K; macs = 0 MACs; params = 512
  Call 2: flops = 2.56 K; macs = 0 MACs; params = 512
  Call 3: flops = 3.84 K; macs = 0 MACs; params = 512

Testing Linear(in_features=256, out_features=128, bias=True)
  Call 1: flops = 65.54 K; macs = 32.77 KMACs; params = 32.9 k
  Call 2: flops = 65.54 K; macs = 32.77 KMACs; params = 32.9 k
  Call 3: flops = 65.54 K; macs = 32.77 KMACs; params = 32.9 k

Expected behavior
_reload_functionals should restore all functionals wrapped in _patch_functionals. It seems that (layer, group, instance)norm are missing, but I haven't checked the list carefully.

issue addressed/fixed in this thread: https://github.com/microsoft/DeepSpeed/pull/2068


just --list should display first line of multi-line comment

#!/usr/bin/env just --justfile

# example of a multiline comment where just --list picks the last line.

# Brief description.
#
# More detailed description.
# Possibly spanning multiple lines
@example:
  just --list

Expect: just example prints Brief description
Actual: just example prints Possibly spanning multiple lines

Dupe of #1337. Definitely an annoying limitation, and hard to fix without breaking existing justfiles, although it can be fixed in an edition.


App with Prisma compiled by vercel/pkg get "UNEXPECTED-15" error in Windows 10

Bug description
I'm using pkg to compile my code for Windows 10.
But after compiled and running .exe file, I get an UNEXPECTED-15 error and don't know how to pinpoint this error
Without using Prisma, the exe file run without error. but when using Prisma, the exe file throw error, please help.
Error output
This is error when running .exe file, with environment variable $env:DEBUG="*"
  prisma:tryLoadEnv  Environment variables not found at C:\snapshot\tr\.env +0ms
  prisma:tryLoadEnv  Environment variables not found at C:\snapshot\tr\.env +1ms
  prisma:tryLoadEnv  No Environment variables loaded +1ms
  prisma:client  checkPlatformCaching:postinstall false +0ms
  prisma:client  checkPlatformCaching:ciName undefined +1ms
  prisma:tryLoadEnv  Environment variables not found at C:\snapshot\tr\.env +1ms
  prisma:tryLoadEnv  Environment variables not found at C:\snapshot\tr\.env +0ms
  prisma:tryLoadEnv  No Environment variables loaded +1ms
  prisma:client  dirname C:\snapshot\tr\node_modules\.prisma\client +0ms
  prisma:client  relativePath ../../../prisma +0ms
  prisma:client  cwd C:\snapshot\tr\node_modules\.prisma\client +0ms
  prisma:client  clientVersion 5.2.0 +1ms
  prisma:client:libraryEngine  internalSetup +0ms
Begin
  prisma:client  Prisma Client call: +1ms
  prisma:client  prisma.user.findFirst({}) +1ms
  prisma:client  Generated request: +0ms
  prisma:client  {
  "modelName": "User",
  "action": "findFirst",
  "query": {
    "arguments": {},
    "selection": {
      "$composites": true,
      "$scalars": true
    }
  }
}
 +0ms
  prisma:client:libraryEngine  sending request, this.libraryStarted: false +4ms
  prisma:client:engines:resolveEnginePath  enginePath C:\snapshot\tr\node_modules\.prisma\client\query_engine-windows.dll.node +0ms
  prisma:client:request_handler  PrismaClientInitializationError: Unable to require(`C:\snapshot\tr\node_modules\.prisma\client\query_engine-windows.dll.node`).
The Prisma engines do not seem to be compatible with your system. Please refer to the documentation about Prisma's system requirements: https://pris.ly/d/system-requirements

Details: UNEXPECTED-15
    at dn.loadLibrary (C:\snapshot\tr\node_modules\@prisma\client\runtime\library.js:112:9956)    at processTicksAndRejections (node:internal/process/task_queues:95:5)
    at process.runNextTicks [as _tickCallback] (node:internal/process/task_queues:64:3)
    at Function.runMain (pkg/prelude/bootstrap.js:1980:13)
    at node:internal/main/run_main_module:17:47
    at async pr.loadEngine (C:\snapshot\tr\node_modules\@prisma\client\runtime\library.js:114:447)
    at async pr.instantiateLibrary (C:\snapshot\tr\node_modules\@prisma\client\runtime\library.js:113:1762)
    at async pr.start (C:\snapshot\tr\node_modules\@prisma\client\runtime\library.js:114:2166)    at async pr.request (C:\snapshot\tr\node_modules\@prisma\client\runtime\library.js:114:3828)
    at async Object.singleLoader (C:\snapshot\tr\node_modules\@prisma\client\runtime\library.js:123:5246) {
  clientVersion: '5.2.0',
  errorCode: undefined
} +0ms
}

Similar Issue
#17173
What I had tried

test from: https://github.com/prisma/ecosystem-tests/tree/dev/binaries/pkg
after running exe file, it show help info:

I think this mean Prisma engine is ok, but I don't know how to use this test to run some query for testing Prisma client.
rename query_engine-windows.dll.node file in node_modules\.prisma\client to query_engine-windows.dll.no to test pkg does or doesn't include query_engine-windows.dll.node file
after run command yarn pkg . and run exe file, it shows this error：

It shows different error output, so I think current problem might came from this file.
remove some code in index.js like this:

after run command yarn pkg . and run exe file, it is no error：

How to reproduce
Clone This repository.
Or following these steps:

create package.json file

yarn init -y

install pkg  and prisma package

yarn add -D pkg prisma
yarn add @prisma/client

make test file index.js

//index.js
const prisma = require('@prisma/client')
const client = new prisma.PrismaClient()
console.log('Begin')

client.user.findFirst().then(v => {
    console.log(v)
 })

create prisma schema

yarn prisma init

edit schema.prisma file

//schema.prisma
generator client {
  provider = "prisma-client-js"
}

datasource db {
  provider = "mysql"
  url      = env("DATABASE_URL")
}

model User {
  id    Int     @id @default(autoincrement())
  email String  @unique
  name  String?
}

generate Prisma client

yarn prisma generate

add Prisma query engine binary path to packege.json (https://www.prisma.io/docs/guides/other/troubleshooting-orm/help-articles/pkg-issue#solution)

npm pkg set pkg.assets="node_modules/.prisma/client/*node"

add pkg config to packege.json

npm pkg set bin="index.js"
npm pkg set pkg.targets[]="node18-win-x64"

create .exe file

yarn pkg .

run .exe file in Powershell

Expected behavior
exe file should run without error.
Prisma information

generator client {
  provider = "prisma-client-js"
}

datasource db {
  provider = "mysql"
  url      = env("DATABASE_URL")
}

model User {
  id    Int     @id @default(autoincrement())
  email String  @unique
  name  String?
}

// main.js
const prisma = require("@prisma/client")
const client = new prisma.PrismaClient()
console.log("Begin")

client.user.findFirst().then(v => {
    console.log(v)
})

Environment & setup

OS: Windows 10 with Microsoft Visual C++ Redistributable 2015 installed
Database: Mysql
Node.js version: 18.16.0

Prisma Version
prisma                  : 5.2.0
@prisma/client          : 5.2.0
Current platform        : windows
Query Engine (Node-API) : libquery-engine 2804dc98259d2ea960602aca6b8e7fdc03c1758f (at<EMAIL_ADDRESS>Schema Engine           : schema-engine-cli 2804dc98259d2ea960602aca6b8e7fdc03c1758f (at<EMAIL_ADDRESS>Schema Wasm             : @prisma/prisma-schema-wasm 5.2.0-25.2804dc98259d2ea960602aca6b8e7fdc03c1758f
Default Engines Hash    : 2804dc98259d2ea960602aca6b8e7fdc03c1758f
Studio                  : 0.494.0

I can make it work now.
In short, add node_modules/.prisma/client/index.js to pkg assets in package.json file:

I try to search error "UNEXPECTED-15" in many package, and it's in pkg (node_modules/pkg/prelude/bootstrap.js line 943)
I check some variables, and found the STORE_CONTENT number is not in entity, and it throw "UNEXPECTED-15"

After some search in google, I found this: https://github.com/vercel/pkg/discussions/1623#discussioncomment-2729625
So I tried to add node_modules/.prisma/client/index.js in assets, and it's working now.

Any idea why defining that file in assets is necessary?
https://github.com/vercel/pkg#assets
Wasn't it included before?

Any idea why defining that file in assets is necessary? https://github.com/vercel/pkg#assets Wasn't it included before?

without defining assets , pkg will include \node_modules\.prisma\client\index.js as bytecode.
According to https://github.com/vercel/pkg#other-considerations, the project that aren't explicitly marked as public by the license in their package.json will only be included as bytecode
Using command yarn pkg . --public-packages ".prisma/client" without defining \node_modules\.prisma\client\index.js in assets to make exe file will work, too. The files in .prisma/client will be included as DISCLOSED code (with sources)
Still don't know why including file as bytecode throw "UNEXPECTED-15" error, I need to dig a little deeper in pkg...

Interesting. So we could also fix that by adding a license to the generated Client?
Of course I am not sure if we should do that, as the generated code technically is ours, but yours as it is customized with your Prisma schema. Interesting problem.

@janpio apparently the workarounds suggested by @xpcn2015, while still working (and required) to get a normal setup working, they do not fix the issue when using a custom output for the Prisma client. I created a reproduction repo that demonstrates this: https://github.com/mikeseese/prisma-pkg-test
This is currently blocking me from releasing my product, and I'm happy to do more legwork to help figuring out a solution. I'm also happy to open a new issue if you'd like

Well I'm not sure why I had issues the first time using @xpcn2015's strategy for for determining the file that needed to get included in the assets array for pkg, but I was able to get it to work.
I needed to also include runtime/library.js, so the below works for me:
{
  "pkg": {
    "assets": [
      "node_modules/my-custom-prisma/index.js"
      "node_modules/my-custom-prisma/runtime/library.js"
    ],
}

for my custom output schema:
generator client {
  provider = "prisma-client-js"
  output = "../node_modules/my-custom-prisma"
}


Fix shellcheck issues

Pasting your script into https://www.shellcheck.net/ shows many issues:

Line 8:
    PATH=`pwd`/.dedynauth
    ^-- SC2123: PATH is the shell search path. Use another name.
         ^-- SC2006: Use $(..) instead of legacy `..`.

Line 13:
source .dedynauth
^-- SC1091: Not following: .dedynauth was not specified as input (see shellcheck -x).

Line 16:
    PATH=`pwd`./dedynauth
    ^-- SC2123: PATH is the shell search path. Use another name.
         ^-- SC2006: Use $(..) instead of legacy `..`.

Line 24:
    PATH=`pwd`./dedynauth
    ^-- SC2123: PATH is the shell search path. Use another name.
         ^-- SC2006: Use $(..) instead of legacy `..`.

Line 48:
curl -X PUT "${args[@]}" -f https://desec.io/api/v1/domains/$DEDYN_NAME/rrsets/_acme-challenge.../TXT/ \
                                                            ^-- SC2086: Double quote to prevent globbing and word splitting.

Line 49:
|| $(>&2 echo "If the previous error was a 404 error, that's ok"; curl -X POST "${args[@]}" https://desec.io/api/v1/domains/$DEDYN_NAME/rrsets/)
   ^-- SC2091: Remove surrounding $() to avoid executing output.
                                                                                ^-- SC2086: Double quote to prevent globbing and word splitting.

Line 52:
>&2 echo "Current Time: `date`"
                        ^-- SC2006: Use $(..) instead of legacy `..`.

Line 54:
for i in `seq 1 60`;
^-- SC2034: i appears unused. Verify it or export it.
         ^-- SC2006: Use $(..) instead of legacy `..`.

Line 57:
        CURRENT=$(host -t TXT _acme-challenge.$DEDYN_NAME ns1.desec.io | grep -- "$CERTBOT_VALIDATION")
                                              ^-- SC2086: Double quote to prevent globbing and word splitting.

Thanks a lot for pointing this out! <3 We fixed the non-cosmetic issues.


Timeline not showing

I have a friend that is trying to get cactbot to work however when testing it out everything is working but the timeline. When testing at the dummies everything showed up fine. But during ex fights like Susano or the new raids nothing is showing for him but is working 100% fine for me.

Real silly question but do they have it enabled as one of the overlays and not just the DPS meter? Are the files all unblocked? Have they tried reloading the overlay mid-fight when it stopped working?
I've had times where the raidboss module needs to be kicked once or twice and then it works again.

I actually have the same problem.
On E1S, the triggers are working (shares, swap tank, etc.), but the Timeline is not showing.
Work fine on dummies, Tsukuyomi/Seiryu Ex or Omega Savage (but not on Susano Ex with the same symptoms, triggers OK but no timeline).
Reloading mid.-fight doesn't change anything.
if that matters, my game is in french.

Timeline in SusanoEx is triggered by him saying 'Let the Revels begin'. This has not been translated yet, so it will only work on english client.
Eden is still pretty new and work in progress

Yeah, this is almost certainly just translations not being ready yet.  Is this still happening for you with the latest version?

It's been resolved for me, indeed (although I still have some delay in the mechs countdowns starting the flares part, but it's a minor hindrance).
No problem for the followings fights either


WIP: Implement EC2 describe_vpc_endpoint_services()

@bblommers - This is not ready for review, but if you want to take a look to see if you're ok with the approach, that would be good.  I still have to add the endpoint services to the rest of the backends, finish a unit tests and correct the next_token.

Codecov Report

Merging #4322 (143f4e3) into master (5b10671) will decrease coverage by 0.00%.
The diff coverage is 92.66%.

@@            Coverage Diff             @@
##           master    #4322      +/-   ##
==========================================
- Coverage   95.09%   95.08%   -0.01%
==========================================
  Files         493      493
  Lines       55342    55535     +193
==========================================
+ Hits        52628    52807     +179
- Misses       2714     2728      +14

Flag
Coverage Δ

servertests
52.79% <63.70%> (-0.04%)
:arrow_down:

test_responses
32.69% <28.18%> (-0.04%)
:arrow_down:

unittests
94.99% <92.66%> (-0.01%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

moto/ec2/responses/vpcs.py
98.61% <66.66%> (-0.46%)
:arrow_down:

moto/ec2/models.py
95.62% <92.15%> (-0.09%)
:arrow_down:

moto/ec2/exceptions.py
97.68% <93.33%> (+0.08%)
:arrow_up:

moto/backends.py
77.77% <100.00%> (+2.02%)
:arrow_up:

moto/config/models.py
99.34% <100.00%> (+<0.01%)
:arrow_up:

moto/core/models.py
96.62% <100.00%> (+<0.01%)
:arrow_up:

moto/s3/models.py
94.84% <100.00%> (+<0.01%)
:arrow_up:

moto/apigateway/responses.py
93.45% <0.00%> (-0.73%)
:arrow_down:

moto/apigateway/utils.py
100.00% <0.00%> (ø)

... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5b10671...143f4e3. Read the comment docs.

@bblommers I generate the privateDnsNames (plural) info, but it's not being returned from the API.  It goes into the botocore libraries and gets removed.  This is a field that was added last year: https://awsapichanges.info/archive/changes/d2b896-ec2.html
I don't know how you manage the botocore libraries and "shapes", but the "shape" for this API would need to be updated.

I don't know how you manage the botocore libraries and "shapes", but the "shape" for this API would need to be updated.

Hey @kbalk, that's managed directly by boto3, and taken directly from the botocore dependency - so as long as the dependencies are up to date, it should work

@bblommers I just remembered there is a elbv2 and a rds2 ... I added default VPC endpoint services to elb and rds.  How are the version 2's handled?  I don't want duplicate sets of endpoint services.


Creation of New Firewall Groups is Broken in 23.7

Important notices
Before you add a new report, we ask you kindly to acknowledge the following:

[X] I have read the contributing guide lines at https://github.com/opnsense/core/blob/master/CONTRIBUTING.md
[X] I am convinced that my issue is new after having checked both open and closed issues at https://github.com/opnsense/core/issues?q=is%3Aissue

Describe the bug
When creating a new firewall group on the Firewall > Groups page, the group is created successfully. However, when attempting to add firewall rules to the group, the Interface dropdown box does not default to the new group. In addition, the firewall group does not appear at all as an option in the Interface dropdown box nor under the Firewall > Rules menu or Interfaces menu (if grouping interfaces is allowed). It is as though the group does not exist at all other than on the Firewall > Groups page.
Even on a new installation of 23.7, new firewall groups can be created but the groups do not show up under the Firewall > Rules page as well as in the Interface dropdown when creating new rules.
It is important to note that any existing groups created before updating to 23.7 still work properly. They show up under the Firewall > Rules menu as well as in the Interface dropdown when creating new firewall rules. Only creating new groups is an issue.
To Reproduce
Steps to reproduce the behavior:

Go to Firewall > Groups
Click on the "+" button to add a new group
Enter the name, select the members, and click "Save"
Click the "Apply" button
Click on the new group in the list of groups to open the firewall rules for the new group
Click on the "+" button to add a new rule
Notice that the "Interface" will default to some interface other than the group. Also note that you cannot see the group's interface in the dropdown list
Also go to the Firewall > Rules menu and notice you do not see the new firewall group at all in the menu

Expected behavior
When creating new rules on the interface, the Interface dropdown should default to the system generated alias for the firewall group. Also the firewall group should be displayed under the Firewall > Rules menu so that you can navigate to that firewall group's page to view and create new firewall rules.
Describe alternatives you considered
There are no alternative options to consider since existing functionality was broken in 23.7 (possibly due to recent MVC changes that were made to web interface).
Additional context
Confirmed with another user on Twitter/X that could replicate the same issue so I know it is not just my issue. Also confirmed the issue on a new installation of 23.7 in a VM.
Environment
OPNsense 23.7.1_3 (but also applies to new installation of 23.7 that was tested in a VM)

@AdSchellevis Perhaps! I'm not familiar enough with the backend code to say for certain but I know that new groups don't act like they are created properly in other parts of the interface.

@dlcasto if you execute the following command on a console, do these new groups act like you expect?
configctl interface invoke registration

@AdSchellevis Yep! That works!

ok, then we can close this, https://github.com/opnsense/core/commit/3f80ddbe9e52466e760dcbf84ec187c973dc610f fixes exactly that :)


No complete response

I created the project file in the root directory, but there is no complete response, I was very anxious to complete the semantic configuration of God, beg God for help!

can you try to debug it with netcat?

Received the great God's reply very excited, colleagues are very ashamed, I'm a rookie, I'm using the system is Mac OS, can you point out how I should use netcat?


Include Support

Add in support for configuration file includes.

Coverage decreased (-0.6%) to 89.441% when pulling 9e92aaa2de8badfb2b97ad9f829b0bdec78477b0 on include into a9897f8fd7d3cc07824819fb99d1c231ed7a652c on master.


A call to UI designers

Hello,
Working with a free and open-source software allow us as a community to experiment with new features and new user interfaces. @yasaricli and I are both good developers, but I guess not excellent designers (and even if we were, input from the community are always invaluable).
I would like to open a brainstorming about the user interface and experience; feel free to share any UI/UX idea you have, and if you have a graphical talent also share some mock-ups of your ideas!
Let's start this thread by some picture of trello redesign tries:

by Fabrice Liut — http://www.liut.me/a-trello-redesign

by Duncan Malashock  — https://dribbble.com/shots/613931-Trello-Redesign-v3

by Stu Greenham — https://dribbble.com/shots/1854771-Trello-Redesign-Concept

by Fran Pérez  — https://dribbble.com/shots/540307-Trello-Redesign

by Philippe HONG — https://dribbble.com/shots/1847564-Trello-Redesign
And now some alternative kanban board softwares:

https://kanbanflow.com/

https://www.odoo.com

https://pintask.me

https://kanbanize.com

http://kanboard.net
I hope all these user interfaces will inspire you! Let's design the best open-source kanban board!

Have you considered asking any of the people who have made their own redesign mockups directly if they would design for LibreBoard?
One thing I see in a lot of these that is a particular peeve of mine of the UI design some companies are using these days: Please avoid differentiating elements solely by varying shades of light grey. It can be difficult to see on poorly contrasted monitors.

:+1: to Stu's concept. A great clean theme. Capacitive and forgiving.

Another crazy thought: Could LibreBoard support multiple styles? There is a good point that it should not by default use Trello's. (Though it is common for users to host sites designed to look like other sites, and it may be acceptable to have a similar option.)
Then new styles could be tested or tried, and that could end up being a core differentiating feature as well. As traditional closed source cloud service products like Trello offer limited customization in that regard.

While I like Stu's concept, it does not show nearly as much information on first glance as the current project or other mockups.

Inviting @stugreenham to the conversation;

Agree, :+1: Stu Greenham's.

I for one would move on with the redesign as priority #1, right now it's a 1:1 rip-off of Trello and I'm not sure how legal that even is. As for the examples brought up above, regardless of which direction you'll take, I hope it's not a 1:1 rip-off of that either. Plenty of designers in the open source space, if you guys had a IRC channel or something, would love to help out.

Hi Guys,
Thanks for including me in the list. My reason for doing the redesign in the first place was because I was unhappy with the existing Trello look and feel. It feels dated, something I contacted Trello about but got nowhere.
Whilst I don't disagree with Crawford95's comment, I must add that this was done intentionally. I wanted to clean up the UI and remove anything that wasn't super important so that the focus was more on the lists and the cards. Simplify.
A user can still get to his/hers other boards, or invite another user in, etc but some of these features sit behind a click, something I felt I was okay with. As a user of Trello myself, I find that 90% of the time, I am just dealing with the cards.
Cheers,
Stu

May I add - I am more then happy to help out with this project if you need any help from a visual/ux point of view. Just let me know!
Cheers,
Stu

@zakbach I'd move further discussion of copyright or trademark issues to #92.
@stugreenham There's some things about your design that's appealing, and I guess I buy the notion of hiding less used things like user controls in a menu. However it looks like you also hid the feed, which I consider pretty critical of Trello. In a large board, that feed is how you know if anything is different since last time you opened it.
My other note is that you seem to have nearly doubled the vertical space between cards. And the top bar seems to be very thick as well. I know companies like Google have been pushing incredibly bloated padding and margins as the "new" look and feel, but it feels like a huge compromise in space utilization for meager to non-existent benefits.

UX nerd here: Can you guys redesign the "Boards" button? :smiley: From an info architecture point of view, a side bar ("secondary nav") seems more appropriate. I can make a sketch later. Think of slack's ui where the rooms/convos are on the left in a column. Or your default notes application for mac. I think that's how a number of boards should be managed.

@ocdtrekkie I don't disagree with your comments - but I must stress that this mockup isn't to be taken too literal. I did this one mockup on a Sunday afternoon so I could play with Sketch. Had this project been a more then me just 'playing with ideas', then I would have gone into more detail and ensured all angles were covered and other screens and flows were sketched and designed.
I agree about the feed - but I must mention that this critical feed you speak of is also hidden by default on Trello. I hadn't ignored this or any of the other features and like I said above - this isn't a design that I was commissioned for. But I do think this is a good point.
Re the spacing - this is something I considered and from my experience dealing with Trello boards involving 15+ people I personally prefer the slightly larger spacing because I find the content more readable. When you add user icons/labels/comments and more to every card it soon becomes a chore to follow with your eyes. I had considered a compact mode similar to Gmail.
If you compare the header on Trello to the header on mine you will notice maybe 5 more pixels in height. Nothing hugely worrying there.
I'm happy to look into developing these concepts further if anyone is interested - This was purely a 'first crack' at it which tbh I am pretty happy with at a starting point.

@stugreenham :+1:

I'm not a designer thats why I posted my proposal not here. But I would suggest to focus also on tags, how they can be organized and nested. For me tags work best when I have a huge pile of information pieces in front of me and I need to organize it.
https://github.com/libreboard/libreboard/issues/98

@stugreenham I am a big fan of compact display density as a setting. :) I would still likely be a happy Google customer if they were willing to keep offering it on their newer products.
If the feed's hidden by default on Trello, I might just never have noticed. The sidebar does collapse, I suppose, though it remembers it's position, perhaps, because I never see it collapsed.

Everyone's talking about Stu's so I'll chime in:
Really good job, Stu
I think 'boards' button being on the top right might not follow convention. Normally it's primary links horizontally on top, secondary links vertically on the left side, and utilities or tertiary links on the top right.
I like the skeumorphic style. When distinguishing between this and the default ui, I'd say Trello has a more visceral feel of grouping cards because they're separated and contained within each dark area. Right now it just looks like a list and it isn't clear that they're cards in a container. I don't think people will immediately get this concept (that it's cards in a group) when looking at the software for the first time.

Oops i wrote in another thread, about my design concept thoughts, i will repeat my message:
i'm not ui/ux designer, but i draw simple sketch of board in material like style, please criticize it we need do something comfortable to use

Copying my notes here from #97
@ozodrukh I will cry many tears if this goes material design. Many. Tears. #materialnono
I don't think a free software project should be implementing Google's branding. And material design has poor contrast between various layers.

i like simple ideas in material design, yeah you are right contrast in material design is poor, but we can improve it here

Hi everyone, just want to align the train of though here and please correct me if I'm wrong:
— stu said that he might be able to develop his vision of trello ui further if anyone is interested. From discussion here it looks like there are 2 main directions to go:

implement new distinctive look
figure out new distinctive features / layout
While first seems to be a focused task the scope of which is relative easy to narrow down, the second seems to be a never ending improvement of ui/ux that not only touches how application looks but also how it functions (eg implementation might require backend changes, even db migrations).

Since scope of first one is easier to pick on and easier to evaluate short term this is where I would propose to concentrate on. Eg in respect to his time, to ask Stu to further develop his vision of trello libreboard ui. Maybe concentrate on figuring out general ui guidelines - card, activity, settings etc. making it possible in the future for developers to extend ui using these guides in a way that product would evolve by that time. Again if you guys feel like it's the way to go.

I think Stu's probably the best bet, if he's interested in taking it on, as I assume it's a fairly hefty workload. I'd really love if the ability to change out styles was actually a feature for LibreBoard in the future, as it'd be a particularly key differentiation from traditional cloud services. (Under such a system, something like Stu's could even be default, but it'd be possible to have a more Trello-ish style available as well, for example.)

Stu's concept isn't great, i can't determine where is what, usability of his concept is poor, i think if cards will be implemented there, it really would be best bet

@ozodrukh They're already cards... Everything on kanban boards is cards...

Are there any metrics that could help us to stay on the path? Eg. What are the things that could be improved (in Existing design)? I think as users we could quantify usability issues (from our perspective) and leave it up for professionals to figure out the best way to solve those problems. There is no need to micromanage or introduce bias options like material design etc.
I personally only figured 1 metric:

new layout should maintain a distinctive look to make product recognizable. Define that line where trello concept and libreboard concept floated apart. Criteria of success would be a layout that inherits all existing functionality (no judgement of what goes or stays at this stage) plus it's flexible enough to take in some realignment at the time new features land on to the project.

I believe guys started this thread in the first place to find their own identity whilst having a default trello feature set bro start with.
Any ideas ?

I have a few comments regarding small improvements to the current interface. With the UI redesign plans in this Issue, I wasn't sure whether improvements to the current design would be continuing. I can make separate issues for these, but I figure I would just mention here first.

Popup menus should close when their button is clicked again. Examples of this include the Profile/Name menu in top right, the New Board '+' button in top right, a card's options button in the card's top right, etc. Currently you have to click somewhere else on the page to close these popups.
On the flip-side, the click-to-edit paradigm currently requires clicking on an 'X' to cancel/hide the editable text field. This form should cancel (or save?) when clicking elsewhere on the page and lose focus. Example of this include clicking a list's title to rename. I don't think this should apply to forms with multi-line textareas as this generally indicates a large amount of data can go in, and this should not be lost when changing focus - example of this would be adding a new card form.

I really hope that Stu's solution will become the default look of the project!

+1 for Stu (but with the feed)

Yeah, @stugreenham's design is great. Stu's a real UI designer, how about we let him call the shots on aesthetics.

I think that all these concepts are great, and while I agree that a nice theme and out of the box installation is great... I think it would be good to take a queue from the bootstrap team and abstract the styles from the core project. This allows everything to remain lightweight and customizable.
Obviously, this takes much more planning than just choosing one style, but it allows for much broader adoption if users aren't forced to reset a bunch of gradients, drop-shadows and sprites when reskinning.

There's also the design used by https://taiga.io -- I think they have a great design, and their code's open source already:

@cjb Soooooo much wasted space o_o

As for the number of lists visible on the screen (3? 4? 5?), you could make the argument for 4. We used to think we could hold 7 things in our short term memory, but recent research has shown it's more like 4 or 5. I actually like trello's sized lists on my laptop screen because there's 4 and a half. The half list indicates that you can scroll right to see more lists. I think that's the perfect number of lists to be on a screen at any one time.

The number of visible lists depends on your screen size. Trello fits six and a half on mine. (Maybe you need a better screen?) Large high resolution screens rightfully should display more information than smaller screens.

@ocdtrekkie True, you make a good point. For laptops, I guess I'd like at least 4 dude. And can we make this responsive for mobile to have just one? Here's a sketch. Sorry it looks really polished. Trust me, it took just a few minutes to make.. So feel free to criticize the heck out of it! I'm going to make a sketch of a secondary nav I'd like to see that can distinguish our app from trello (and avoid DMCA complaints)

It would make sense for mobile to have just one wide before scrolling.
As for your mockup, I'd probably suggest the top bar should be more distinctly different than Trello's in style as well.

Here's the sketch for some ux improvements. Basically everything you need to be productive. The notes is placed at the bottom, so your list of notes can grow into infinity and all you need to do is scroll down. (Although a load more button is possible).
You could put a search bar up top as well.
Think Slack + Trello + Notes ftw

Definitely Stu!... at least in terms of the overall feel and direction...

 Stu: add parts that others have requested and maybe upgrade it with your latest ideas and provide another UI mockup for a review. This should move a bit faster.

Hi all, interface designer from Fetchnotes here!
I think one thing that's missing from this conversation is a high level set of goals/usecases/niceties that we want to serve with this design. Before we start trying to find an alternative interface, we should be figuring out the shape of the problems it'll try to solve.
If we're trying to copy the goals and usecases of Trello 1-to-1, then we're inevitably going to trend very closely to their product design, with only the room to make superficial changes (re-jiggerred navigation, changed visual style, etc.) but I think taking some time to figure out our fundamental differences and perspective on the problem space (a spatial, manipulable layout of information that you can use with other people) will be very useful to how this discussion moves forward, and how us designers can help contribute.

We released v0.8 yesterday (with a lot of new great features in it!), and it's now the time to fully focus on our new UI. Due to the DCMA notice, we won't push any code on github, but we'll keep working in the open on a self-hosted gitlab instance. I've also set a separate instance of the online application on http://newui.librebroad.com so we can share our experiments and break things.
I'm not certain @yasaricli agree with me on that (please share what you think!), but for my part I don't want this re-design to be “just change the CSS so we can get back on github”. I'm willing to work on much more deeper modifications to the way the application work (how we assign members and label to a card in the board view, how the multi-selection feature will work, how we select a board, how we integrate pomodoro timers, etc.). So if you're thinking about how we can improve things, don't feel limited by the amount of code re-write you're idea will require.
There is also the mobile. We're not going to develop native LibreBoard applications on Android and iOS, instead we will wrap the web client in Cordova (which is easy to do with meteor by the way). I don't want to abuse marketing words, but “mobile first” could be a good approach for our new user interface.
@ocdtrekkie Multi-design would be a very cool feature indeed. Unfortunately, due to the way meteor works (take all the CSS files it can find and merge them in one big file) this is not something we can implement easily. So let's keep this idea for a later release.
@ryngonzalez I would love to tell you that we have a vision about the way we want to spatially organize information. But as far as I know our only fundamental difference is to be a free and open-source software; I'm not sure we can emphasize data privacy in the UI (I don't think so), but maybe one point to consider here would be plugin extensibility.
Also, if someone has some ideas to improve the kanban paradigm, feel free to share them (@JamborJan proposed #98). Maybe the multi-selection idea could have some ramifications? For instance we could make the labels click-able to open a menu like “Remove this label” + “Filter cards on this label”, and have a similar menu on the member icon.
It seems that there is a consensus to use the mockup of @stugreenham as a basis, and iterate on that (side note commenters, keep in mind Stu didn't originally made this mockup for our use case). Stu, could you authorize others to iterate on your design? For me, this mockup raises a number of issues we need to figure out:

Do we need a sidebar (similar to the Trello sidebar)?. I tend to think it would be possible to move all board actions to the top board bar. Maybe this top board content could also change depending on the context, for instance become a “drop here to archive” when we are dragging a card (like on the android version of Trello), or became a filter selection if we are in the filtered view. Non-frequent actions could be moved to a menu accessible by cliquing on the gears icon on the right. However we definitely need a sidebar on the mobile UI.
How do we keep a level of board user customization? Should the user be able to select a header color? Do we want to support background images for the header (a bit like chrome themes) while we keep the content on a white background?
How do we select a board? It seems that the top left hamburger icon could open a left pane with a board list?
How about white cards on a grey background, like Google Now?

There are also potential discussions about square vs round avatars, or about the way we display labels on the board view (anyone like the way Fabrice Liut [1] solves this?), but I don't have a strong opinion on these.
And we also need a new logo #64.

we'll keep working in the open on a self-hosted gitlab instance

Wouldn't you just expect to receive a DMCA notice to the gitlab instance, then?

for my part I don't want this re-design to be “just change the CSS so we can get back on github”.

I'm nobody here, but I'd suggest the opposite approach, so that you have a project that people can use, develop and deploy in the open without waiting for your full feature design and implementation to finish first.

@mquandalle I agree with you.

"Do we need a sidebar?"
I haven't used the activity sidebar feature, but then again, I do most my work on jira at my real job. That's an interesting design question worth asking everybody here. How much do you love the side bar on trello?
Also, we can group some of these functions together and put them in a Settings modal to keep the interface clean.
I like the hamburger icon + list instead of selecting from a boards page
The gray sounds good. One thing to consider is the visual weight of your top navigation bar. The darker gray you go, the less visual weight the dark navigation bar will have. So while it makes the white text boxes pop more, it makes the whole page pop less. That's why I used light grays in my design (the red one above). Your call, boss! Just providing you with information to make your decision.

@ryngonzalez makes an excellent point! One thing I noticed using hipchat + jira (it's like slack + trello) is back and forth between chat window and project management board. It'd be cool if we could use sockets.io to let people select things, like you can have multiple people edit the same document in Google Docs. I'd love to see a box with a highlight around it from my project manager. It'd be even better if we added chat and kept it to the same website. I showed this possibility in the red sketch above where the side navigation has Private Messages, Chat Room Channels, Trello Boards, and a section for Notes. That's a holistic approach to project usecase, if you ask me.

Also in most mockups the logo is tacking a significant area. I don't think we care enough about our brand to take all that place, and I believe we don't even need to put the logo in the board interface (just keep the application name in the window title).

+1 for Duncan Malashock

+1 for white card instead of grey

@stugreenham :+1:

I say get the CSS changed and get it back up here so all of us can help make the changes that are needed for this project. Take out what Trello is considering to be theirs and then there are no issues.

This doesn't have to be a complete UI paradigm shift to get back on GitHub. There is only so much that you can change while still keeping the cleanliness and simple flow that is inspired by Trello flows.
Just remove offending hot-linked assets and styling that is 100% original to Trello so that others can continue to contribute.
@mquandalle @yasaricli I can take a stab at a UI cleanup to get this back here so that other people can continue to contribute. Short of forking this and taking it a different direction, how could I contribute?

@andreioprisan if you want to help you can send a merge request on http://git.libreboard.com/libreboard/libreboard

I started working on a new design today. What I have below is an actual implementation (not an image). A lot of features are bugged due to some code reorganisation, so I'll try to fix that before I release the code (hopefully tomorrow, or after tomorrow).

One of the idea here, is to have quick access to starred boards on the small top bar, this is a feature inspired by reddit sub-reddit. I also removed the sidebar and put all the board information in the top bar. This bar will change depending on the context, for instance if I'm on a filtered view the bar will display the filters, if I'm dragging a card the bar will display a “drop here to archive” button, and on the home page, the bar will just display a LibreBoard logo.
Also I moved the menu that was on the sidebar into a popup that is accessible by clicking on the board title. For instance to change the board color:

As I said, this is a very early prototype (not even 24 hours!), so I haven't worked on typography, space rhythm, clean animations, color adjustment, etc. I just like to share what I have done today :-)

That is clean work! Are you planning to put a historical activity log pane?

So my ideas around activities:

On the home page have a feed of activities for all starred board, and all followed members (like github)
On the board page click on the board menu then “Activities” and that will open an overlay window containing all the activities for this board.
We also need to redesign activities UI, personally I love how github/githab draw their feed with a vertical time line with messages and events. Since the gitlab design is released under the MIT license I might just use that for our activities feeds

@mquandalle great job! If you need help with gitlab infrastructure please let me know :)

@mquandalle Looking forward to start contributing :)

@Coppolaemilio Cool! What kind of this would you like to do? Implement new features? Help with the design?

Took a shot at this — very unfinished, and everything is subject to change.

Love @fnky proposal. Really clean and focused on the cards... :+1:

@mquandalle early look of the design is looking much better. Actually much much better than Trello :smile:, which is now looking like meh.. compared to this.....
I know this is very early design, but the dotted lines  between the lists are little distracting...

love what @fnky did
Idea: just brainstorming here, if you moved the green button to the left side of the box, would that make it more scannable? I like how you have it as well.
I think it's looking really good in terms of actual interface changes. What would the lists look like if they were even like a darker gray or a brownish dark grey with white text instead? Just curious.
Good work!
Tyler

@fnky Check this out. Tell me what you think
Just a quick sketch we can perfect later

Here we have buttons moved left for scannability

@mquandalle Nice sketches as well! Going to be tough to decide which format to go with :) I can see where you're inspired by Google Now with the headings being outside the lists and as part of the background.

@Squ34k3rZ Thanks for the input :-)
I tried different ways of presenting boards/lists. I took the decision for a light background, that didn't feel too off the overall design and still preserving the functionality

Can be moved
Groups tasks/cards and visually shows its volume.

As for the buttons, I chose to put it in the right side, as this layout is used widely throughout every day applications—both on the web and OS').
They could also fill the whole board/list, but that feels too bulky.

@stugreenham :+1:

@stugreenham nice and simple. Now to move on to implementing.

@mquandalle Just caught up with the thread - I'm happy to discuss the potential of using my mockup design but I would want my input. There is a lot of different opinions on here (which is good btw) and I'd be worried that once everyone has there input we could end up with a car crash of 100 different styles and ideas.
I think a lot of people are focusing too much on theming and colours etc. I've always thought of this feature on Trello along with their stickers etc to be an unnecessary distraction – If you are worrying about the colour of the board and not the content then you are doing something wrong.
What did you have in mind going forward then? Is this purely going to be web based for now?

Hey @stugreenham, happy to read you here again. Did you see my last two comments in the flow? https://github.com/libreboard/libreboard/issues/94#issuecomment-71327633 and https://github.com/libreboard/libreboard/issues/94#issuecomment-71393038 (←I started an actual implementation)

Other interesting features for the new UI are collapsible cards and  swimlanes, like in Jira Agile...   @mquandalle you should install UserVoice or something similar in your website so people can vote for the preferred features... or maybe you could open a board where people can vote...

@Telemakhos I agree 100%, uservoice would help so much here.

@mquandalle++ I'm appreciated for all your efforts to bring a new UI to this awesome opensource project.
As I didn't catch up everything in this thread, I would like to suggest you - if it isn't yet - to create a new libreboard project to create the new UI, without any functionality, maybe from the scratch, but accepting PRs and specific issues (as this one is already huge).
With that, we could even try different paths for the UI and have a progressive check for anything different from the main functionality or copyright issues.

The top bar with the tags from @mquandalle looks great and very clean.
The cards with small icons and sidebar from @fnky are also great.
A combination of these two styles would get my vote.

Ok. Let's first get a confirmation from the owners which design should be implemented. My opinion is (and I see majority thinks the same) that Stu's version should be implemented. A developer can only design an interface as good as they know, a designer (and possibly a UX designer) can go even further.
I suggest Stu's design be implemented and guided by Stu himself, so he can tell implementers what's invalidly implemented and which parts should be included as well. And he's right when he says that colour is not important. That's always right in design. If it works in BW it will work even better in colour. So UX first and then design as per Stu's guidance.

:+1: I agree with @litera — We need to organise tasks for anyone who would like to participate in putting this together as a team, not as individuals.
It's important that we don't waste our time discussing the look & feel of the app, but rather start discussing the functionality and the user experience.

Give me a few days to implement a design proposition and release the code; then we will be able to collectively iterate on that.

For the curious, here is where I am currently (again it's an implementation not a mockup):

There is even more bugged features than last time because I've been touching code everywhere. But nothing to worry here, I just need some time.

Np, take your time pal. What we need is a way for proposing and voting the best features... maybe open a dedicated board in libreboard.com? With community feedback we'll know what tasks should take priority...

Looking great @mquandalle. I think the work you're doing is a great combination of some of the proposals.
I think you could ween some more simplicity/clarity out of it by sharpening up the shadow on the cards and ditching the embossed lane borders.

http://jsfiddle.net/c850pa0m/1/

+1 to @bmathews proposal. It looks much nicer with that clean style.

Thank you very much @bmathews, this is a great feedback; I've updated the stylesheet to follow your recommendations.  This is going to be great

@bmathews  :+1:  it certainly looks soooooo much nicer....it feels so much simple, clear and elegant!

hahah wow I missed this part "We received a DMCA takedown notice from Github regarding our user interface", that's pretty low, not like Trello looks good... at all... or does anything good really

I'm still not sure about the “should we have a sidebar” question. My initial idea was to differentiate from trello and simplify the layout by merging the sidebar into the header bar. If you take a look at alternative kanban boards on my first post you'll see than none of them have a sidebar.
On the other hand a retractable sidebar like the one @Squ34k3rZ did seems useful, and difficult to improve. It gives informations (board members, labels, and activities) that other kanban software doesn't provide as easily.
Any thought on this topic?

From my point of view it would make sense for easy selecting tags to navigate through big amounts of cards (see: https://github.com/libreboard/libreboard/issues/98).

The biggest thing I need from a sidebar or similar UI element is the
ability to see the recent history of people manipulating cards.
-Jake Weisz
On Wed, Jan 28, 2015 at 8:46 AM, JJ<EMAIL_ADDRESS>wrote:

From my point of view it would make sense for easy selecting tags to
navigate through big amounts of cards (see: #98
https://github.com/libreboard/libreboard/issues/98).
—
Reply to this email directly or view it on GitHub
https://github.com/libreboard/libreboard/issues/94#issuecomment-71845498
.

Perhaps have notifications always shown on large viewports. And auto collapse it on x size view ports?
Also, some great ideas here around Material Design: https://www.polymer-project.org/components/paper-elements/demo.html#core-toolbar

@mquandalle I vote for having the sidebar and @fnky and @Squ34k3rZ design fits well. If  I were to put  the users shoes  for a minute,  if I am working on a project,  I like my stream of activities and any changes made to the cards close by, so that the information can be accessed with no friction, rather than going to a overlay screen to access the information, which might lead to cognitive dissonance as I am breaking my train of thought, as the  app created an additional step to get to the information I need. The reason the sidebar works the way it works i guess, is very similar to how we all work, in the sense when we are working on a project we want to feel and see that the   necessary information for the project is close to us  and can easily get to it, with out taking any extra steps . Sometimes if something fits well in a absolute sense within the good usability   framework and solves a problem, then it is best to stick with it, regardless of who started it first.

@mquandalle  Actually from a color rhythm   point of view, I like @fnky design better. Having a main body with grey background and white cards, while having a activity sidebar with  white background and grey boxes for activity and event text, creates a simple, clear contrast and makes it more elegant from a UI perspective.

I like the @mquandalle WIP better than @fnky mockup. Colors look cleaner, and less space is wasted on mquandalle's. You only need so many nested borders on a page!
But it needs a history sidebar.

You could just use twitter bootstrap:
http://bootsnipp.com/snippets/featured/kanban-board

Don't know if it's 'modern' enough, but I thought the look of TaskBoard might at least give someone some ideas.

Is there an ETA on when "we'll be back"?

@catmanjan Given that the preview @mquandalle gave above was like two days of work, I imagine it will not be very long.

I agree with @ocdtrekkie . @mquandalle  is a coding badass :smile:

@mquandalle I think one thing we need to consider is our user. Is he going to be working alone or on a team?
If on a team, I'd recommend a side-bar with the extra functionality (such as chat, 1 on 1 messages, and notes)
If he's just doing his own thing, then those might be superfluous features.
The other nice-to-have feature to roadmap is Natural Language Processing and identifying the cards. And then when people chat, being able to refer to each card with a #searchterm
Depends on our resources/ability to implement obv. I'm just going by actual behavior out in the wild. Another thing we use is gchat to voice/video chat. So if we could add a group voice feature to the chat rooms, that would be mega. ;) Plenty of possibilities to work on!

Took some of the ideas into consideration and made a few changes + an extra mockup without sidebar as @mquandalle suggested.

@Squ34k3rZ I don't quite see the idea in implementing a chat system in a Kanban board, since it can easily be integrated with a wide range of services (like Slack, HipChat, etc...)
It's important to make one thing and that thing well. Implementing chat, voice- and video is certainly something that takes time to implement, which isn't mandatory as there is lots of services out there.
As for the audience, we will never know, but Kanban is a widely used method for small to large groups of people and it'll probably be picked up by any kind of company. Therefore it's important to discuss about features that are useful to Kanban.

Are you guys considering having the panel/menu on the left instead ? I just think it might prevent some additional legal issues

@alvinsight implementing or left or right is not a legal issue in and of itself. The issue was with the 100% style copy, which we can't do. Having the same data feed there would be OK.

@fnky I love the view without the explicit right sidebar and being able to just toggle the Activity feed if needed.

Thank you @fnky, your mockups are inspiring. I decided to give a try to the no board sidebar approach. We could then use a sidebar on large screen to display card detailed view (you can discuss this idea in #127) and for the board activity feed — but not for labels and members that will be in the header.
Also we don't need a filter selector like the one you drawn, we will be able to filter cards by clicking on a member avatar and selecting “Filter cards with this member”. The top bar will then change to display a big "X Filter view" title and displaying all the active filters. Clicking on "X" will reset the filter. I will implement this in the coming days so you can share what you think of it.
Here is the current state of my implementation:

I imagine a lot of graphical details could be discussed from it. Round avatars? Border-less covers? Improving "Add a card/list" buttons? Also I don't really like the Starred/Labels/Search top toolbar; I will probably try with bigger icons and no text, a bit like in the @fnky mockup.
Any feedback?

Also since there is already more than 100 messages here, I propose to split the new design discussion in multiple thematics threads:
Re-design discussions:

#126 For the home page and the activity feed
#127 For the board general view
(current) For the card detailed view

The landing page will also be redesigned, but later.

@Squ34k3rZ LibreBoard will be used by both individuals users, and teams (since it synchronize the view in real time) — like Trello. And LibreBoard is not only available in English but also in French, German, Japanese, Chinese, Turkish, and Portuguese (more are coming).

I think it'd be great if users were able to pick/swap which "skin"/UI their LibreBoard had. It could be an option on settings or something.

@mquandalle Wondering from usability point of view, the header might get crowded if there many members (for example 10-15 members on one board). My opinion is, I like the current implementation state of the board but with sidebar component  as designed by @fnky (or maybe the sliding sidebar  might be a middle ground?)

@Shekar73 Not all members need to be displayed at the same time. There can only be a handful 7+-2 and a dropdown. A similar approach is done on Google Docs where one can collaborate with users that are on the same doc at the same time.
Go check this Google Doc that usually has many many concurrent viewers. Cklick link and wait for the document to completely load and check the upper right corner user list.
Users are anonymized as per Google's implementation, but that's not the issue here.

Thanks for the response @mquandalle
When I initially made the mockup, I thought of adding labels with explanations of the components. I like the approach that having a sidebar by demand on larger screens, and keeping everything tight but still available on smaller screens.
The Filter dropdown should actually be a Labels/Tags dropdown. I already had in mind, that you filter by members by clicking on the members avatars, since you'd be able to also filter by more than one member. However, only about 7 avatars will be visible, so that'll need a dropdown as well to list all members within a project and filter by them.
Filtering by tags is just a matter of opening the tags dropdown and select the tags you'd like to filter by and searching would be a smart search with commands and keywords.
We'd also need to be able to filter by tasks assigned to you, and perhaps also unseen activities.
I like the approach that when you're filtering, it'll show you the filter settings. This gives the user a notice that the data they see is filtered and they can change the filters or reset them.

Should the menu has transition animation when being hide/shown?
This way the actions would seem more natural and fluent.

Stu's or Fran's are my picks

Right now there seem to be serious issues with logging on to Libreboard.com . like you go to the login screen, put in your info, hit submit and nothing.

Might not be helping much but I would love to see this plugin's UI on Libreboard.
https://github.com/MikoMagni/Trello-Monochrome-Chrome

Playing around with background styles....

Let's try to establish some rules.

the used fonts MUST not be too extravagant like in @Squ34k3rZ 's card titles right above me or in taiga.io 's extravagant design; it makes them harder to read and that is absolutely something to avoid, I think we all agree there.
I see a lot of people are liking Stu's design, however I believe having color is very important to have an easy overview of either what the cards contain (color in function of content) or freedom to choose the color of a card upon its creation (personally I'd be more inclined to the former, which would prevent a lot of headaches I believe)

What do you think?

@orangejuic regarding #2. It's not that anybody opposes usage of colours. I don't think that majority like Stu's design because of that but rather of the execution, how well vertical space is used by adjoining cards visually separating them by line only. This gives cards more breathing space and doesn't confine individual ones inside strictly defined borders. That's the great thing about his proposed redesign.
This way each "list" becomes a column of visually joined cards. Why people relate to that so well? Because it better mimics real world. Imagine a newspaper where each individual article would be put inside a visually defined container. Articles in newspapers run in columns and usually not being separated by any other marker than whitespace and their content emphasised parts (titles separate individual articles in the same column vertically, whitespace separates columns horizontally)
So that's the whole beauty of Stu's design. I wouldn't use black background either. Actually I'd try doing it even more like real world and keep background white and individual lists without any borders. But in this case majority of card data should be left aligned to relate stuff correctly (i.e. avatars belong to the card with data on the left, not to ones on the right)
Something along these lines:

@litera The UI in the one you just posted is so faint, it just appears to be floating blocks of text on my screen.

@ocdtrekkie I'm not sure what you mean or what kind of a screen you're using, but the main idea to post the UI was to show that Stu's design isn't so much about colour as it is about individual elements design. I've maybe done it all to light. It displays fine on my monitor though.
My changes are just put directly on Stu's original design. It should of course be greatly improved upon as I was just removing or changing a few bits and pieces.

@litera I wasn't saying stu's design is entirely bad, just that the lack of color is a flaw that has to be remarked upon. Now about that design you posted, I believe @ocdtrekkie to be right in that there are no cards anymore, only floating blocks of text, simply because the separation between the cards and the columns aren't clear.
From afar, I can't distinguish clearly the cards in your design, and that's a major flaw in my opinion because a card is so much more than only text. It's supposed to be designed to contain files, images, recordings, a video or even a link.
The design you posted doesn't seem to be adapted to all of that, because it's made to contain a bit of text and that's it, when Trello (the base idea of this project) is made to contain so much more.

 The community has done its part for now. Stu's design was the majority's favorite. You don't need 10 contributors to accomplish what comes next, no matter how cool and intoxicating it is that so many people have been willing to pour so much energy into this. (I've hardly seen anything like it, so cool!. I'm sure it'll come in handy again when it's time to open the floor for smaller iterations and possibly alternative themes if that's ever supported).
In Stu's own words

I'm happy to discuss the potential of using my mockup design but I would want my input. There is a lot of different opinions on here (which is good btw) and I'd be worried that once everyone has there input we could end up with a car crash of 100 different styles and ideas.

This is exactly where you are headed right now. There's no room in here for a single, unified direction.
My 2 cents: Stop this discussion, get in touch with Stu and finish the design that you already know is fully capable of wow-ing people.

so many great designs!

@erlend-sh Exactly my sentiment. I've pointed somewhat to this same issue some time ago - 27th Jan but nobody seemed to reply upon it.

@mquandalle Just wanted to pitch in that http://newui.libreboard.com is looking great.  I agree with @erlend-sh that the value now is in getting that delivered in a 0.9 release that allows you to come back to Github.
Looking forward to 0.9 so I can move my team over to libreboard!

@mquandalle, I do like the visibly clickable tags on @fnky's mockup: it's intuitive, much moreso than a nested menu might be. If we're avoiding a side bar (are we?) there may be some way to integrate the coloured tags into the top bar for easy topic-level filtering.

Pardon me if I'm missing something, but http://newui.libreboard.com/ looks nearly identical to Trello and doesn't seem to incorporate any of the new design directions discussed here. Is there a new URL for the new UI?

:+1:

I have just redesigned in the code source the app. If you are interested, i'll push it on the source.

@fix  :+1: :+1:  Love  the custom board backgrounds and chalk board metaphor in the home page!!

@fix this is really cool and useful for branding!

So is there a downloadable version available ?

Some friends worked a year ago on a kanban design. Maybe you would like to use this design. I have to confirm, but i think it's opensource. You can see and test this it : http://kanban.apps.patapouf.org/ login : demo et pwd : demo . I think the app will never be updated as a bigger community exists to develop this common, we prefer to support libreboard. I'll ask mockup to the designer (and psd files) if that's in your interest

Wow, I think that design looks great!  I would vote for using it.
Cheers
Andy
On Tue, May 12, 2015 at 9:58 AM, SimonSarazin<EMAIL_ADDRESS>wrote:

Some friends worked a year ago on a kanban design. Maybe you would like to
use this design. I have to confirm, but i think it's opensource. You can
see and test this it : http://kanban.apps.patapouf.org/ login : demo et
pwd : demo . I think the app will never be updated as a bigger community
exists to develop this common, we prefer to support libreboard. I'll ask
mockup to the designer (and psd files) if that's in your interest
--
Reply to this email directly or view it on GitHub
https://github.com/libreboard/libreboard/issues/94#issuecomment-101293284
.

excellent design !!
+1 for me
Angel
2015-05-12 15:59 GMT+02:00 SimonSarazin<EMAIL_ADDRESS>
Some friends worked a year ago on a kanban design. Maybe you would like to
use this design. I have to confirm, but i think it's opensource. You can
see and test this it : http://kanban.apps.patapouf.org/ login : demo et
pwd : demo . I think the app will never be updated as a bigger community
exists to develop this common, we prefer to support libreboard. I'll ask
mockup to the designer (and psd files) if that's in your interest
—
Reply to this email directly or view it on GitHub
https://github.com/libreboard/libreboard/issues/94#issuecomment-101293284
.

Here are the complete designs : https://drive.google.com/folderview?id=0B1GiMK8ptm02fjRYazFXTFdSaWRBcUgyNU1BZU5oMUpVRDRUMExENVMtZEw1d292TWZJWW8&usp=sharing . It is in creative commons (just please keep the designer paternity if libreboard finally use it). All is in one psd that i can share if you need this design.

:+1: For Stu's Design. So how is this going? have you guys decided yet to go towards any specific design? I could help here and there.

https://userstyles.org/styles/browse/trello

I am fond of Stu's but would like some more material design elements added because I think they would make the UI/UX language more clear
I agree with @Squ34k3rZ about the slide out left menu, I think that floating menus can often cause problems visually.
There are actually several designs on here that use slide out menus that float above other text and I think it would be really helpful to implement material design concepts on top of this because it makes the separation a bit more obvious.
Near the beginning of the conversation, someone mentioned multiple shades of gray as being problematic on low quality displays. I agree with this, and also think that the slight shadowing between levels in material design alleviate this.
just my 2 cents.

@TheElf Material design, is, by definition, terribly unclear language. (There's a recent article by Lauren Weinstein, who has actually done a lot of work for Google, about how 'modern' UIs tend to fail badly: http://lauren.vortex.com/archive/001112.html)

Very interesting read Jacob, thanks for posting that.
I myself have found it to be very helpful, but I don't suffer from the
problems listed in the article. (I'm sure they will be problematic for me
in the future, just not now)
The things that I was highlighting material design for when recommending it
in my post were more in regards to visual separation of elements with depth
(cued by shadow). This isn't something that the article took issue with,
and is still not something that existed in many of the posted mock ups.
Now this may have been because they are simply prototypes, but I think it
makes a big difference in how readily identifiable different pieces of a
page are.
On Tue, Jul 7, 2015, 4:59 PM Jacob Weisz<EMAIL_ADDRESS>wrote:

@TheElf https://github.com/TheElf Material design, is, by definition,
terribly unclear language. (There's a recent article by Lauren Weinstein,
who has actually done a lot of work for Google, about how 'modern' UIs tend
to fail badly: http://lauren.vortex.com/archive/001112.html)
—
Reply to this email directly or view it on GitHub
https://github.com/libreboard/libreboard/issues/94#issuecomment-119356141
.

@TheElf I suppose it's definitely important to qualify what sort of "material design elements" you talk about then. ;) I'd definitely agree shadows can help define layers of the UI. (Though it can't be the sole indicator of hierarchy, as fine details like shadows are completely overlooked by some viewers.) There are other elements I'd be more wary of though, like Google's recent fascination with animations, which can be resource-intensive.

Lol animations are so pretty though. But I definitely see your point. I
think a lot of the animations would be fine if they're implemented as pure
CSS (yes I know some of them can't be implemented this way). This means it
will take advantage of graphics acceleration on supported platforms, and
can be disabled very easily.
But believe me, I think all of the icons and buttons should have clear
labeling and be linked to reasonable actions
On Wed, Jul 8, 2015, 12:35 AM Jacob Weisz<EMAIL_ADDRESS>wrote:

@TheElf https://github.com/TheElf I suppose it's definitely important
to qualify what sort of "material design elements" you talk about then. ;)
I'd definitely agree shadows can help define layers of the UI. (Though it
can't be the sole indicator of hierarchy, as fine details like shadows are
completely overlooked by some viewers.) There are other elements I'd be
more wary of though, like Google's recent fascination with animations,
which can be resource-intensive.
—
Reply to this email directly or view it on GitHub
https://github.com/libreboard/libreboard/issues/94#issuecomment-119442694
.

@fix Hmm, the title font of the first pic... I feel Geocities and Comic Sans are coming after me...

So, as a supplement, however as a main point try this amazing free app. Createer.com is an online software for easily designing online ads, responsive landing pages and print materials such as flyers, posters, covers, invitations and more. Createer lets you easily share your designs on social media, send them via email, download as HTML, image or PDF. You can even design UI mockups for mobile as for standard display (html, js, css always generating without any coding required from you). Createer also includes 3,000 predesigned templates (browse here: https://beta2.createer.com/Templates?ghi) and over 250,000 images (illustrations, photos and icons) to work with in its user-friendly drag’n’drop enviroment. And finally this amazing stuff is here: https://beta2.createer.com/?ghi

For pomodoro timers, check out Pomello.

@SimonSarazin Nice to see you here. Is pierreozoux also around?

Thanks @almereyda to let me know the project was here :) I was still on the gitlab :/ Great to see new development!
excited


Test & refine walkthrough on small screens

As reported in osm-dev irc, the walkthrough has some alignment and space issues in very small screens.

Closing; this hasn't drawn much attention for 3 years. While it's still probably a useful thing to explore, it's not doable on its own and would likely fit into a larger "making iD work on mobile" sprint.


Pass in options to rustc compilation command

I need to pass in a library search path to rustc with -L (looking for some C .dylibs) in order for my program to compile, and I can't find a way to do this with cargo. The ability to pass in options to the rustc command when compiling a file would be a very nice feature to have. Perhaps an option under a [[bin]] specifying additional compilation arguments, ie:
[package]

name = "test"
version = "0.1.0"
authors =<EMAIL_ADDRESS>
[[bin]]

name = "test"
rustc_args = "-L/usr/local/lib"

Apologies if this is already implemented or there's another issue for it.

Could you give a pointer to the current solution, if any? It would be useful for people ending up here after a Google search.

It's been a while since I used Rust, but from memory there was no way to actually pass command line options to the linker. I ended up setting some environment variable (don't remember what it was), but I think this method has been superseded by the rustc-link-search feature in Cargo.


Tesselating small TiltedSquareLattice's on big ones

Imagine I have a little 2x2 tilted square lattice circuit that I want to run in all the possible spots on a larger (e.g. 10x8 tilted square lattice) device. I'd like to tessellate my small graph and make sure that no qubits are "overlapping"

(Meta: triage/needs-feasibility is not ideal, but is closest triage label to "needs agreed design". Maybe we should have triage/needs-agreed-design? @dstrain115 )


Add synchronize event to pull requests

This is needed for triggering CI from forks of kapp-controller.
More details here: https://github.community/t/what-is-a-pull-request-synchronize-event/14784

It seems to have fixed my issue!
Thanks!


Can help in contributing..

Hi,
I can help in fixing issues and closing pending PRs. If you are seeking who can actively maintain this.
Please add me contributor.
Thanks

@gs-akhan
Active project is at https://github.com/peacechen/react-native-modal-selector

@peacechen  Thanks. Looking forward for it. :)


audio/mp3, audio/vorbis, audio/wav: Decode should accept a non-io.Seeker stream

CC @essial

What type should it accept?

io.ReadCloser. And, if the value is io.Seeker, we have to detect this and keep the current behavior.

Would replacing the argument type with an interface be a suitable course of action for being able to accept both audio.ReadSeekCloser and io.ReadCloser?

Or should I make a new type that contains audio.ReadSeekCloser and io.ReadCloser and then determine which one is null and implement specific functionality to handle the available one?

Would replacing the argument type with an interface be a suitable course of action for being able to accept both audio.ReadSeekCloser and io.ReadCloser?

Right.

Or should I make a new type that contains audio.ReadSeekCloser and io.ReadCloser and then determine which one is null and implement specific functionality to handle the available one?

No, you don't have to create a new type. Just use io.ReadCloser.


Bundled/Minified file still named martin.js

Awesome library; I love your work! When installed from NPM, there's the main index.js file and also bundled martin.js and martin.min.js. It looks like the rollup config is still set to those names:
https://github.com/mapbox/martini/blob/f87ad03edae1d42cd0cc773ac794e3f41c01d778/rollup.config.js#L15-L16
Did you mean to rename those to Martini too?

Thank you!


Feature/267 Add rule to replace setMethods to onlyMethods

Issue #267

Wait for this PR https://github.com/rectorphp/rector-phpunit/pull/278

Thank you


[FEATURE] Remove the ThreadContext dependency on the User from Common Utils for creating detector

Is your feature request related to a problem?
Since we are removing the dependency of Common Utils for detector. Auth User from the codebase required to create detectors can be removed.
What solution would you like?
A clear and concise description of what you want to happen.
What alternatives have you considered?
A clear and concise description of any alternative solutions or features you've considered.
Do you have any additional context?
Add any other context or screenshots about the feature request here.

I'm a bit concerned with the language remove.
The concept of an authenticated user is integral to identity (see #14) and the existing implementation is depended on by the current authentication implementation (see #19).
I certainly agree that User needs to be moved elsewhere and/or possibly incorporated in a different identity/authentication model, but this particular issue/feature is going to be blocked by initial answers to the above two issues.

Initial commit removed the dependency on Common Utils.  However, the X in the XY problem here is that we want to stop storing and retrieving the user from the ThreadContext.  That's easily done by commenting out code and disabling tests, but I think more important is to leave placeholder comments outlining the functionality that will replace them under the new security model. I'll update the PR tonight with that added context (pun intended.)

It turns out that someone decided that a null user was the super-admin, so this is easily accomplished by making the user null.  For the record, I think this was a horrible design choice!

Having connections always pass is good, except that the failures which never happen mean the test coverage is lower and is failing jacoco tests.
Options are to lower the jacoco threshold or comment out all the code for what to do when it fails (which we would have to put back once we get a new auth/permissions scheme in).
I favor lowering the jacoco threshold.  Thoughts, @saratvemulapalli  and @owaiskazi19 ?
Execution failed for task ':jacocoTestCoverageVerification'.
> Rule violated for class org.opensearch.ad.auth.UserIdentity: branches covered ratio is 0.58, but expected minimum is 0.60
  Rule violated for class org.opensearch.ad.auth.UserIdentity: lines covered ratio is 0.73, but expected minimum is 0.75
  Rule violated for class org.opensearch.ad.transport.IndexAnomalyDetectorTransportAction: branches covered ratio is 0.58, but expected minimum is 0.60
  Rule violated for class org.opensearch.ad.transport.handler.ADSearchHandler: branches covered ratio is 0.25, but expected minimum is 0.60

I favor lowering the jacoco threshold. Thoughts, @saratvemulapalli and @owaiskazi19 ?

Since we are working on our own feature branch for AD. I'm fine with lowering the threshold for now. We can change it back to the original value once we finish https://github.com/opensearch-project/opensearch-sdk/issues/20. Let's track this change somewhere may be on #20.

Yeah +1. We can ignore them for now. But when we are ready for production use, this should match what we had.
May be lets track this as an issue overall for AD as an extension?

In that case the PR is ready for review with the only needed change figuring out where to lower that threshold.

Since we are working on our own feature branch for AD. I'm fine with lowering the threshold for now.

Looks like the thresholds apply to the whole project, but classes can be excluded, so I just excluded the problematic classes with a TODO to add them back when we've re-implemented security in the new model.

Completed in https://github.com/opensearch-project/anomaly-detection/pull/617


Fails to build under node 0.12.x

I know I can now start scripts with node --harmony-proxies to get V8 built-in support for Proxy but for scripts that still depend on this library (and situations where it's a pain to start node with custom flags), I'm wondering if this is a simple fix to get it working again?
Complete log here:
https://gist.github.com/natevw/c45b5abdc79f34c84729

fixed by https://github.com/samshull/node-proxy/commit/7aa4c269079d95b59ff2e39b76e46abc434635e4

Awesome, thanks for the quick turnaround! (I'm using this in https://github.com/natevw/fermata — and the version where it's an optional dependency is still under development, so this will be appreciated by users of the stable version where it's still required.)


testcase versioning changes

b'## WARNING: A Blackduck scan failure has been waived
A prior failure has been upvoted

Upvote reason: OK

Commit: fce289ff2e5b1827f7a46b3154228dc80cb43d7a
'


Updated Readme

Updated README with more recent information incorporating changes made to design and utilities, etc.

Updated remaining READMEs and merged into 'dev' branch.