Remove ununsed permission for gateways.

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: morvencao
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

install/OWNERS [morvencao]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@morvencao: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-multicluster-e2e.sh
557c28e06bd8f71ae343f65b8919fe91bb6dae73
link
/test istio-pilot-multicluster-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@morvencao: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-multicluster-e2e.sh
557c28e06bd8f71ae343f65b8919fe91bb6dae73
link
/test istio-pilot-multicluster-e2e

prow/release-test.sh
557c28e06bd8f71ae343f65b8919fe91bb6dae73
link
/test release-test

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@morvencao: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-multicluster-e2e.sh
05c8aacac1fc6b756ca7067dda61b366bcee6804
link
/test istio-pilot-multicluster-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@morvencao: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-multicluster-e2e.sh
05c8aacac1fc6b756ca7067dda61b366bcee6804
link
/test istio-pilot-multicluster-e2e

prow/istio-integ-k8s-tests.sh
05c8aacac1fc6b756ca7067dda61b366bcee6804
link
/test istio-integ-k8s-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@morvencao: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-integ-k8s-tests.sh
7cefb1cfcce8d507b194c07e11b031103f3fb2ee
link
/test istio-integ-k8s-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Close this as we need permission for sds.


Remove layout from CollectionViewDriver

Simplify CollectionViewDriver initializer by removing the layout param.

Realized this is probably here for compatibility with UICollectionViewControllers, I might just make this an optional param.

Ok, so this was originally intended to enforce using UICollectionViewCompositionalLayout.
Some history / reasoning
This is because of the poor design of the older FlowLayout and it's delegate, UICollectionViewDelegateFlowLayout:

The UICollectionViewFlowLayout object expects the collection view’s delegate object to adopt this protocol. Therefore, implement this protocol on the object assigned to your collection view’s delegate property.

The problem is that the layout does not have its own delegate. Instead, it piggybacks off of collectionView.delegate. That's a problem because CollectionViewDriver becomes the delegate. So then there's this whole mess about how to deal with that, because clients wouldn't be able to provide the additional FlowLayoutDelegate methods. (gross)
However, there should never be any reason to use FlowLayout over CompositionalLayout. The CompositionalLayout has all the features of FlowLayout and more, but without this legacy baggage. So my thinking was that we should simply enforce using CompositionalLayout to avoid all this.
(The truth is that the layout: param here is totally superfluous.)
Thoughts on layouts
However, perhaps this restriction is not fair? Because someone could implement a custom layout and want to use that. I think that is exceedingly rare now that we have CompositionalLayout, but it is a possibility.
Back to flow layout: all of the methods on FlowLayoutDelegate are optional. They allow you to provide dynamic cell sizing and spacing, etc. Instead, you can also set fixed values on the layout object that correspond to every delegate method. For example, instead of implementing collectionView(_:layout:sizeForItemAt:) you can set the layout.itemSize property. So... we could allow FlowLayout with the caveat: "Hey, sorry, but you can't use the FlowLayoutDelegate. You'll have to have use the static .itemSize property, etc etc. If you want more flexibility, then you should use CompositionalLayout instead."
What to do
Given all that, I'm leaning toward allowing any kind of layout and removing this restriction. And we can see how it goes and revisit when that becomes a problem.
So instead of making this optional, I think we should remove it completely. We can let clients just give us the collectionView that is already completely configured.


added namespace support

Added namespace support flag to that it works against Enterprise Vault which support namespaces.
The mock vault test framework does not seem to support this feature, however I was able to test this functionality with an Enterprise Vault cluster.

Thanks for your contribution and sorry for the delay in reviewing this one.
Is there something you forgot to commit? I see the changes affect the README and the viper flags, but I don´t see any logic that uses the provided namespace


 Some screenshots may help me to get your point.

 Some screenshots may help me to get your point.

curl http://<IP_ADDRESS>/apisix/admin/routes/00000000000000000015 -X PUT -d '
{
    "uris": [
        "/*"
    ],
    "hosts": [
        "local-web.com"
    ],
    "plugins": {

    },
    "upstream": {
         "nodes": {
            "<IP_ADDRESS>:8081": 1,
            "<IP_ADDRESS>:8082": 1
        },
        "type": "roundrobin",
        "retries": 2,
        "checks": {
            "active": {
                "http_path": "/status",
                "host": "local-web.com",
                "healthy": {
                    "interval": 2,
                    "successes": 1
                },
                "unhealthy": {
                    "interval": 1,
                    "http_failures": 2
                },
                "req_headers": ["User-Agent: curl/7.29.0"]
            },
            "passive": {
                "healthy": {
                    "http_statuses": [200, 201],
                    "successes": 3
                },
                "unhealthy": {
                    "http_statuses": [500],
                    "http_failures": 3,
                    "tcp_failures": 3
                }
            }
        }
    }
}'

比如我执行上述命令，手动添加了负载均衡，并添加了健康检查。在列表中、编辑页面上看不到这两方面的信息（会误以为没有添加）。相对的，在这情况下，我继续编辑页面上修改并保存，如果选了Upstream会覆盖掉我之前定义的负载均衡和健康检查；如果没有修改或修改描述这些数据保存则会报错invalid configuration: object matches none of the alternatives

clearly now, thanks for your reply. Currently, dashboard will only show upstreams added by selecting id. I will fix this issue this weekend.

clearly now, thanks for your reply. Currently, dashboard will only show upstreams added by selecting id. I will fix this issue this weekend.

第二点：在路由上已经配置有hosts，checks. active 还需要配置host 是否显得有点儿多余／重复？安装我的理解，它既然已经绑在在路由上，应该就对该路由上的hosts都生效才对

Hi @membphis , could you help to involve this issue?


Code sample is referring to the older ODBC Driver

Driver={ODBC Driver 13 for SQL Server};Server=ServerNameHere;Encrypt=YES;TrustServerCertificate=YES
Other examples use ODBC Driver 17, but the example shown above refers to Driver 13.  Driver version should be consistent throughout the entire article.
[DSN name]
[MSSQLTest]
Driver = ODBC Driver 17 for SQL Server
Server = [protocol:]server[,port]
Server = tcp:localhost,1433

Note:
Port is not a valid keyword in the odbc.ini file
for the Microsoft ODBC driver on Linux or macOS

[Enter feedback here]

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 3cfdda44-e9f6-d18a-6fbb-311b12847f4e
Version Independent ID: 4755f473-a601-79d8-1de9-15e7bc18c51e
Content: Connecting using ODBC - SQL Server
Content Source: docs/connect/odbc/linux-mac/connection-string-keywords-and-data-source-names-dsns.md
Product: sql
Technology: connectivity
GitHub Login: @David-Engel
Microsoft Alias: v-daenge

@cawrites Thanks for the feedback. I'll update the reference.
Regards,
David

#assign:David-Engel

@cawrites The documentation has been updated.
Thanks,
David
#please-close


Email tickbox

change:
tickbox email allowed?
To be
tickbox Would you like to receive emails about the members club and listings? (TBC by Wharf)
Change tickbox to be off by default.

Would you like to receive emails with updates about your club and upcoming events?


Load Webview on react-native

Submitted for PR

Sorry this does not look interesting enough to be added to the list
Please do not submit again


Fix svg canvas

Description
This PR is a follow-on from #259 that includes the uncommited changes described at the end of that PR (my git mistake) and additional changes to support the canvas properly containing shapes with negative coordinates. The results are now as follows:

Type of change

[x] Bug-fix (non-breaking change which fixes an issue)

References
#259, #178
How has this been tested?

[x] example/to_svg.py

Final checklist:

[x] My PR is the minimum possible work for the desired functionality
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have made corresponding changes to the documentation
[ ] I have added tests that prove my fix is effective or that my feature works

Hello @sofroniewn! Thanks for opening this PR. We checked the lines you've touched for PEP 8 issues, and found:

In the file napari/components/_viewer/model.py:

Line 238:1: W293 blank line contains whitespace
Line 243:40: E225 missing whitespace around operator

In the file napari/layers/_base_layer/model.py:

Line 375:40: E225 missing whitespace around operator


How does the macro condition works?

Hello,
Can someone explain to me how the "macro" condition works. Or has someone an example?
With kind regards,
Tim Nobbenhuis

If I understand right, you can add you own condition function, like:
$jsonq->macro('lengthLessThen', function ($value, $comparable) {         return count($value) < $comparable;     } );
and then use it:
$jsonq->from('users')->where('name', 'lengthLessThen', 10)->get();
@nahid , correct if I am wrong, please.

It worked, thank you very much.

@Timenator you are welcome.

@GitHubHubus absolutely right. Thank you for your response

@nahid When you use the macro, is there also a possibility to somehow add sorting? maybe add a field?, in our case we calculate a distance, and I like to sort the results by that number.
the items with the shortest distance first.


Version <IP_ADDRESS> - aspnetcore2openapi generate code where NSwagStudio will

I have a minimal api .net8 app and I need an automated way to generate an OpenApi file at build time (one without the Servers property).  I thought aspnetcore2openapi would be the ideal tool because Studio generates it from the project with no problem.  But when I run the console command I get the following error:

Done executing command. Exit Code: 0.
Done executing command
Output:
AssemblyName: Miniter.Services.ImagingApi
OutputPath: bin\Debug\net8.0
PlatformTarget:
Platform: AnyCPU
ProjectDepsFilePath: C:\Projects\Miniter\Miniter.Webs\Imaging\Miniter.Services.ImagingApi\bin\Debug\net8.0\Miniter.Services.ImagingApi.deps.json
ProjectDir: C:\Projects\Miniter\Miniter.Webs\Imaging\Miniter.Services.ImagingApi
ProjectRuntimeConfigFilePath: C:\Projects\Miniter\Miniter.Webs\Imaging\Miniter.Services.ImagingApi\bin\Debug\net8.0\Miniter.Services.ImagingApi.runtimeconfig.json
TargetFileName: Miniter.Services.ImagingApi.dll
TargetFrameworkIdentifier: .NETCoreApp
System.InvalidOperationException: Unsupported target framework '.NETCoreApp'.
at NSwag.Commands.Generation.AspNetCore.AspNetCoreToOpenApiCommand.d__45.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
at NConsole.CommandLineProcessor.d__12.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
at NConsole.CommandLineProcessor.d__11.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
at NSwag.Commands.NSwagCommandProcessor.d__3.MoveNext()

ran into the sam issue, using the correct executable
<Exec ... Command="$(NSwagExe_Net80) ..."/>

fixed it

Thank you.  I could have sworn I tried that and got a different error.  But doing it this morning worked like a charm.

Could you please share the configuration you've used? I'm using $(NSwagExe_Net80) in the command, but still getting this error.


Optionally add vmlinux to output

For some kernel debugging, in particular with perf, it would be useful to optionally include the uncompressed/unstripped vmlinux file to the rootfs if present in the kernel package

I am just working on a platform that boots the vmlinux, although I think I should be able to boot the stripped one in this case, but I would like to add some more options here... Is your use case for running the debug kernels?

I can't remember the details...but I think enabling CONFIG_KALLSYMS_ALL might also do the trick.


updated notes api routes and rendered the calendar again by commentin…

…g out the script tag at the bottom of the main.handlebars

Merge approved


Remove old references to "wiki" or "trac"

Remove vestigial references to trac or wiki.
Testing Plan:
Untested.  How do we test puppet apply?

I think we use wiki auth for both munin and nagios; so maybe monitoring would be a better new name for it?
For testing of zulip_ops, one should push a branch to the internal repository, check it out on the target system, and run zulip-puppet-apply there.  This workflow isn't viable for application servers, where we use the checkouts for running the application, but it's correct for all the other systems.
(And application server configuration is generally easy enough to test on a dedicated test server, or with upgrade-zulip-from-git on staging)

I merged 3/4 commits as the series ending with 107fe3d3b454aa44a7a9026cd4264bde1ddc6b2c.

What's your preferred working strategy for partial-merges like that?  Rebase and push the one remaining commit to the same branch and PR?  Open a new PR?

yep, just rebase and push the updated remaining commit to the same branch and PR.  That keeps all the conversation about those commits in one place.
We do this process a lot for large PRs for big features, where we often merge various preparatory refactoring commits each time it's reviewed, even if the remaining work isn't ready.  Saves a lot of time on the part of reviewers rereading the same code changes repeatedly.
This in turn means that we aim to write PRs in a way where that sort of incremental merging is possible and will decrease the mental complexity of a PR.

Pushed the remaining commit, renamed to monitoring

Great, merged, thanks @alexmv!


Fix cache clear command

This PR

[x] Fixes an issue with the clear:cache command

Follows #792.
Found this when trying to run the internal php server on master.

Applied this fixes you suggested @localheinz

Thanks @localheinz


workbench & locli:  differential run analysis

We need means for automated differential analysis & reporting between runs.

A trial version is currently implemented in bench-master.
The first runs that undergone this procedure were:

https://github.com/input-output-hk/cardano-node/issues/4066
https://github.com/input-output-hk/cardano-node/issues/4065

Closing this. If this is still relevant please reopen.


adjust how users change the values

I think the sliders are much easier to use than simply put a few text field with up/down button. For example, if you look at the "level" on the attached the screenshot, it gives you a very intuitive way to change min/mid/max, but on our version, e.g., "Gamma", it is much harder to adjust.

If you look at the example from allen cell, the picture in the original issue: for "levels" there are three pins along the slider. This is what we want to change for Gamma. So, for Gamme, it would be good to have only one slider, but with three pins (min, mid, max).

@Adrian-Sebuliba If you look at the example from allen cell, the picture in the original issue: for "levels" there are three pins along the slider. This is what we want to change for Gamma. So, for Gamme, it would be good to have only one slider, but with three pins (min, mid, max).

This issue has been addressed

this is nice! can we do the same fix for clip region? Basically, one slider with two pins for each axis. 3 sliders in total.

this is nice! can we do the same fix for clip region? Basically, one slider with two pins for each axis. 3 sliders in total.

@jxchen01 The requested changes have been made, thank you!


chore(release): 0.48.5

0.48.5 (2024-06-18)

Closing because no meaningful changes are in this release.


Error with multiple jvmargs parameters with gradle

New Issue Checklist

[x] Updated fastlane to the latest version
[x] I read the Contribution Guidelines
[x] I read docs.fastlane.tools
[x] I searched for existing GitHub issues

Issue Description
I am trying to use gradle plugin in that way:
gradle(
task: "jacocoFullReport",
flags: "--stacktrace",
system_properties: {
"org.gradle.jvmargs" => "-Xmx4g -XX:MaxPermSize=2048m -XX:+UseParallelGC -XX:+HeapDumpOnOutOfMemoryError",
"org.gradle.parallel" => true,
"org.gradle.configureondemand" => true,
"org.gradle.caching" => true,
"file.encoding" => "UTF-8"
}
Then I get this error:
invalid option: -XX:MaxPermSize=2048m
It seems fastlane only use the first parameter.
Environment

Key
Value

OS
debian_based bullseye/sid

Ruby
2.7.2

Bundler?
false

Git
git version 2.36.1

Installation Source
/opt/hostedtoolcache/Ruby/2.7.2/x64/bin/fastlane

Host
Ubuntu 20.04.4 LTS debian_based bullseye/sid (5.13.0-1031-azure)

Ruby Lib Dir
/opt/hostedtoolcache/Ruby/2.7.2/x64/lib

OpenSSL Version
OpenSSL 1.1.1f  31 Mar 2020

Is contained
false

Is homebrew
false

Is installed via Fabric.app
false

System Locale

Variable
Value

LANG
C.UTF-8
✅

LC_ALL

LANGUAGE

Unfortunately parameter does not getting applied. I added jvmArguments logging to ToolingApiInvoker.java runTasks method. Gradle plugin 5.4.1, MacOS.


Improvement: Submit button at the top of environment edit window

I have tons of variables setup for my environments and some I have to update frequently. It's very inconvenient to scroll down for Save changes. Can you implement Submit button at the top of that window?

We're working on a major UI overhaul, and saving environments will certainly be a lot easier. I'll keep this thread updated.

@yurik @abhijitkane The latest updates ensure that the submit button is always visible and doesn't require a scroll to find. Closing this issue, thanks for reporting.


v0.15 not working with cordova - iOS emulator

Hi,
I have encountered following behaviour with current version of the satellizer (which is btw excellent library):
When authenticating with Facebook (IMO this is true for all OAuth2 providers) the in-app-browser window is displayed and after signing in with Facebook it stays opened until closed by user manually.
From my point of view the problem is in polling the satellizer "popup" rather then binding event listener. This is implemented in "OAuth2.prototype.init" method, where the popup is created and poll method initiated. The execution in emulator "ends" on line 542 of the source code (method "Popup.prototype.polling" on if (!_this.popup || _this.popup.closed || _this.popup.closed === undefined).
If I miss understood the concept then I'm sorry.
Downgrading to version 0.14.1 solved this and I am using it for development now.

@johnfox I found the source of the problem. It's totally all my fault that occurred during the TypeScript refactoring.
I will release the patch shortly.

Let me know if this release fixes your issue: https://github.com/sahat/satellizer/releases/tag/0.15.5

@sahat I don't think your patch solved the issue... I struggle with this, and I can see there are many other open issues around the same problem. When running a page in facebooks in-app browser the popup stays opened.
I find it difficult to debug, but I have tried anyway with jsconsole (remote-debugging). I can see something throws an undefined. But I don't know where/why. Any ideas?


Create Nessus integration

https://github.com/frikky/Shuffle-apps/issues/25

Try to use open source if possible

Built as Tenable app.


setAutoValues should preserve original field order for the same depth

Order of the autoValue functions may be random when doing setAutoValues while cleaning. The problem is that the Array.sort() is not necessarily stable.
As a consequence, some field's autoValue function that depends on some other field's autoValue does not work properly (sometimes, but randomly, depending on the count of the fields in the schema).
This PR changes the way the function objects are sorted so that we are sure the correct order at the same field depth is preserved.
Note that in the test that I've added, the are 11 fields because below that number the order was preserved by the Array.sort().
Might be the fix for #227

Thanks for figuring this out.


[WIP Multicast] Add IPv6 support for Multicast

Signed-off-by: ceclinux<EMAIL_ADDRESS>TODO:

[ ] dual-stack, IPv4 only, and IPv6 only check
[ ] Multicast group auto-discovery for IPv6, similar to #2652
[ ] e2e tests

Codecov Report

Merging #3572 (dc03432) into main (117b9bb) will decrease coverage by 22.35%.
The diff coverage is 22.70%.

@@             Coverage Diff             @@
##             main    #3572       +/-   ##
===========================================
- Coverage   65.61%   43.25%   -22.36%
===========================================
  Files         268      210       -58
  Lines       26780    25370     -1410
===========================================
- Hits        17571    10974     -6597
- Misses       7314    13306     +5992
+ Partials     1895     1090      -805

Flag
Coverage Δ

kind-e2e-tests
?

unit-tests
43.25% <22.70%> (+0.65%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.


Use mainstream GCC 12.1.0 and Binutils 2.39.0

Description
This PR basically removes the legacy IOP toolchain using now just the mainstream one.
bison dependency has been added for compiling in MacOS
Atention
If you take a look, gcc repo is still pointing to ps2dev, this is because they have an issue in the 12.1.0 and I have needed to apply 2 different commits by cherry-picking them.
More info here:
https://github.com/ps2dev/gcc/commits/iop-v12.1.0
GNU assembler (GNU Binutils) 2.39
Copyright (C) 2022 Free Software Foundation, Inc.
This program is free software; you may redistribute it under the terms of
the GNU General Public License version 3 or later.
This program has absolutely no warranty.
This assembler was configured for a target of `mipsel-ps2-elf'.
GNU ld (GNU Binutils) 2.39
Copyright (C) 2022 Free Software Foundation, Inc.
This program is free software; you may redistribute it under the terms of
the GNU General Public License version 3 or (at your option) a later version.
This program has absolutely no warranty.
mipsel-ps2-elf-gcc (GCC) 12.1.0
Copyright (C) 2022 Free Software Foundation, Inc.
This is free software; see the source for copying conditions.  There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.

Will merge after checks pass


Remove redundant word (that that)

Suggested Reviewer: @Rick-Anderson

@badersur Thank you for the fix! Your change will go live within the next 24 hours.

You're welcome @scottaddie


Working to fix this now.


Get-DbaDependency - detect a circular reference

Type of Change

[X] Bug fix (non-breaking change, fixes #7139 )
[ ] New feature (non-breaking change, adds functionality, fixes # )
[ ] Breaking change (effects multiple commands or functionality, fixes # )
[X] Ran manual Pester test and has passed (`.\tests\manual.pester.ps1)
[ ] Adding code coverage to existing functionality
[X] Pester test is included
[ ] If new file reference added for test, has is been added to github.com/sqlcollaborative/appveyor-lab ?
[ ] Nunit test is included
[ ] Documentation
[ ] Build system

Purpose
Ensure the dependency check does not get into an infinite loop.
Approach
The code checks that dependency is not a parent object.
Commands to test
See the new integration tests.

@SamWalkerRxSense, great work on this PR. A few small suggestions so this PR is ready for the maintainers to review:
Ensure the issue is referenced in the PR description:

After pushing code to a PR there are automation tests that run:

It looks like you'll need to run the formatter on the updated file(s), something like:
Invoke-DbatoolsFormatter -Path \functions\Get-DbaDependency.ps1

There are a few other integration tests that failed but they are for other commands that experience occasional environment stability issues.
Have fun with it and thanks for your contribution!

@lancasteradam  thanks for the tips!  PR is updated.

Hey @SamWalkerRxSense and\or @lancasteradam - any chance you can take a look at these integration tests and see if there is any performance improvements to be had? Tests make sense to me - but for a long time.
Thanks @SamWalkerRxSense for your contribution - sorry for the delays in merging this in!

@jpomfret  What sort test timings are you seeing?  I'm seeing 4 sec 141 ms, I checked some previous build it seems the added tests increase ~500ms.  Is that right?  I'm new to this, just wanted to make sure I was looking at the right thing.

Thank you both so much. I've seen similar increases with this particular command, so it makes sense, @SamWalkerRxSense. Merging now 🥳


Didn’t receive data from facebook lead form

I test Facebook Lead Ad Forms, status it succeeded. But the post api doesn't get any data. Do you know what to do?
Please help me thx

Hey, @Aompos, it looks like you're not getting a notification whenever a new lead has been acquired, right?
I would strongly recommend you make use of the Lead Ads Testing Tool. These are my suggestions:

Take a look at the documentation inside the "docs" folder in this repository.
Leverage the Lead Ads Testing tool for creating a "dummy lead" and making sure your webservice is being called.
You can also make use of the Postman collection "FB Lead Ads (Part 1 - The Webhook)" and the "3 - TEST Lead Generation Notification" example to make sure everything is fine on your side.
I hope all that helps... And since there is no problem regarding the accelerator/sample itself, I'm closing this issue.
Thanks,
França.

@MFranca
I get page specific information but no lead form data,
Is it relevant to verify the business? pages_manage_metadata,leads_retrieval  permission

@Aompos , are you sure you're calling the right endpoint?
To retrieve the lead data, you should call https://graph.facebook.com/v{{api version}}/{{leadgen id}}
You can use either a "user-expiring token" or a "non-expiring token" - you have both examples in the Postman collection provided with the samples. Also, make sure you have the right permissions!


Fixed typos in test names and comment

Hi @minho42. Thanks for this, again.
You seem to be sending in a small PR every couple of weeks with a few typos corrections. Are you able to combine all your fixes into one PR, which would be easier to review and cleaner in the commit history?

Hi @carltongibson,
Thanks for reviewing.
Did you mean to combine all the previously merged commits with the current one?
If that's the case, I need some time to find out how.

Hi @minho42. No, I meant combine all the still-to-come fixes you can find into one PR.
Are you using a script/tool to find these errors? Can we run that on the whole repo?

@carltongibson
I'm using my own script to find typos which is still work in progress to go public.
Typos I found are from searching the whole repo, and going through those manually.
I found some here and there once in a while.
It's not like I'm separating all findings to small PRs.
But I can definitely combine as much as I can for the future fixes :)
Thanks again for your work.

Hi @minho42. Sounds like a good tool! Can you share a preliminary version so we can play?

Hi @carltongibson
I'll try to make it a public repo soon!
Will let you know.

Thanks!

Hi @carltongibson
Just made my script public.
https://github.com/minho42/typofinder


Release notes bug: Figma Design Resources For Clarity lead to 404

Describe the bug
The figma design resources buttons in the version 2.0.0 release notes link to https://clarity.design/null
How to reproduce
https://clarity.design/news/2.0.0

Also the #2947 bugfix is mentioned twice


add: content + solution for challenge "Match Non-Whitespace Characters"

[x] I have read freeCodeCamp's contribution guidelines.
[x] My pull request has a descriptive title (not a vague title like Update index.md)
[x] My pull request targets the master branch of freeCodeCamp.
[x] None of my changes are plagiarized from another source without proper attribution.
[x] My article does not contain shortened URLs or affiliate links.

Closed and Reopened this PR to attempt to resolve a specific Travis build failure.

Your solution was fine, but your hint was not a great example.  We have gone with another PR which provided the same solution, but a better hint section.  Thank you for your contribution.  We look forward to others.


Update Seattle Login/Logout URL Redirects

This needs to happen after #4705 is done, but right before Seattle deploys to prod.

As of https://github.com/civiform/civiform/pull/4801 the Login, Language, Landing changes are all submitted.