Cannot use RiverMapper & pyDEM in the same script

@feiye-vims while you're working on the latest generated mesh to see if it's useful or not, I started using RiverMapper and pyDEM to learn a bit more about them. To start I tried both serial and parallel sample for each of them successfully.
My next step was to try to combine the two serial scripts so that I end up with a single script that gets DEM as input and outputs river polygons. This is where I ran into an issue.
After some digging I realized that the issue stems from this line:
https://github.com/schism-dev/RiverMeshTools/blob/4ee6cd1cddb0df349dc20960b0e46710972eb578/RiverMapper/RiverMapper/make_river_map.py#L35
Basically setting this error handling in RiverMapper affects the results of pyDEM. So when at the top of myscript I import:
from pyDEM.dem import dem
from RiverMapper.make_river_map import make_river_map

I run into an issue during the calculation of the DEM thalwegs:
        dem_obj.compute_river(acc_limit=catchment_area)
        gdf = dem_obj.write_shapefile(npt_smooth=thalweg_smoothing)
        gdf.to_file(out_stem)

So I was wondering if there's any reason why this error handling is set for numpy errors?

I'm not sure if this just means we shouldn't set the error handling or we should fix the pyDEM's failure as a result of setting this error handling. If I comment that line in make_river_map.py, after calculating the thalwegs, when trying to create river map I get the following:
  File "/home/smani/workarea/sandbox/RiverMeshTools/RiverMapper/RiverMapper/make_river_map.py", line 1255, in make_river_map
    S, is_new_cache = Tif2XYZ(tif_fname=tif_fname, cache=i_DEM_cache)
  File "/home/smani/workarea/sandbox/RiverMeshTools/RiverMapper/RiverMapper/river_map_tif_preproc.py", line 62, in Tif2XYZ
    cache_name = tif_fname + '.pkl'
TypeError: unsupported operand type(s) for +: 'PosixPath' and 'str'

Hi Soroosh, I'm glad you are testing the tools.
I set "np.seterr(all='raise') " to catch any error during numpy calculation such as division by zero or other invalid values. It is werid it can cause a different output from pyDEM without actually throwing an error in pyDEM. I can ask Linlin to check what caused the problem.
In the meantime, I'll just comment this line out, since make_river_map never throws this error in my previous tests.
We're still in the process of the annual update for STOFS-3D, so I didn't have a chance to get back to the grid problem, which I don't think is a big issue, it's just I never met a similar problem before. Hope you can allow a few more days.

Hi, no problem! OK, I'll also let you know if I figured out why pyDEM is doing this.

In the meantime, I'll just comment this line out

Thank you, I'll let you know if during my tests I notice anything strange in RiverMapper as a results of commenting this out.
@cuill in my case the easiest way to see the issue is by adding
+ import numpy as np
+ np.seterr(all='raise')

after importing all other packages in the pyDEM_Samples/Serial/run_serial.py example case.

@SorooshMani-NOAA Thanks for the information. I'll take a look.

@SorooshMani-NOAA You can pull the latest changes and test now. The issue with NaN values was also resolved. It should only have feature_id not reach_id.

@cuill I'm using the latest code from the repo, but I still get the same error when I set np.seterr(all='raise')  at the top of my script. The error happens during writing the dataframe to file due to invalid coordinates:
Traceback (most recent call last):
  File "/mnt/c/Users/Soroosh.Mani/WorkArea/Development/RiverMapper/own_test/dem_to_rivermap_parallel.py", line 315, in <module>
    main()
  File "/mnt/c/Users/Soroosh.Mani/WorkArea/Development/RiverMapper/own_test/dem_to_rivermap_parallel.py", line 270, in main
    shp_files = extract_thalwegs_mpi_wrap(
  File "/mnt/c/Users/Soroosh.Mani/WorkArea/Development/RiverMapper/own_test/dem_to_rivermap_parallel.py", line 75, in extract_thalwegs_mpi_wrap
    dist_gen_files = extract_thalwegs(
  File "/mnt/c/Users/Soroosh.Mani/WorkArea/Development/RiverMapper/own_test/dem_to_rivermap_parallel.py", line 130, in extract_thalwegs
    gdf.to_file(out_stem)
  File "/home/smani/miniconda3/envs/meshdev/lib/python3.10/site-packages/geopandas/geodataframe.py", line 1263, in to_file
    _to_file(self, filename, driver, schema, index, **kwargs)
  File "/home/smani/miniconda3/envs/meshdev/lib/python3.10/site-packages/geopandas/io/file.py", line 539, in _to_file
    _to_file_fiona(df, filename, driver, schema, crs, mode, **kwargs)
  File "/home/smani/miniconda3/envs/meshdev/lib/python3.10/site-packages/geopandas/io/file.py", line 568, in _to_file_fiona
    colxn.writerecords(df.iterfeatures())
  File "/home/smani/miniconda3/envs/meshdev/lib/python3.10/site-packages/fiona/collection.py", line 549, in writerecords
    self.session.writerecs(records, self)
  File "fiona/ogrext.pyx", line 1413, in fiona.ogrext.WritingSession.writerecs
RuntimeError: GDAL Error: Coordinates with non-finite values are not allowed. Failed to write record: <fiona.model.Feature object at 0x7fa3aca5c4c0>

@SorooshMani-NOAA Yes, I just got this error, too. In the previous test, I accidentally comment out np.seterr(all='raise') which did not raise an error. I'll look into this again when I have time.

https://github.com/OSGeo/gdal/issues/3542


Cannot find manifest for 32b9363b-09ff-4959-929a-cab2663fb223_2.2.1. Store had [3.0.2].

Target SharePoint environment
SharePoint Online
What SharePoint development model, framework, SDK or API is this about?
💥 SharePoint Framework
Developer environment
Windows
What browser(s) / client(s) have you tested

[ ] 💥 Internet Explorer
[X] 💥 Microsoft Edge
[X] 💥 Google Chrome
[ ] 💥 FireFox
[ ] 💥 Safari
[ ] mobile (iOS/iPadOS)
[ ] mobile (Android)
[ ] not applicable
[ ] other (enter in the "Additional environment details" area below)

Additional environment details

SPFx version: 1.16.1
Node.js version: 16.18.

 "dependencies": {
    "@microsoft/decorators": "1.16.1",
    "@microsoft/mgt-react": "2.6.1",
    "@microsoft/mgt-sharepoint-provider": "2.6.1",
    "@microsoft/sp-adaptive-card-extension-base": "1.16.1",
    "@microsoft/sp-application-base": "1.16.1",
    "@microsoft/sp-core-library": "1.16.1",
    "@microsoft/sp-dialog": "1.16.1",
    "@microsoft/sp-lodash-subset": "1.16.1",
    "@microsoft/sp-office-ui-fabric-core": "1.16.1",
    "@microsoft/sp-property-pane": "1.16.1",
    "@microsoft/sp-webpart-base": "1.16.1",
    "@pnp/graph": "2.14.0",
    "@pnp/sp": "2.14.0",
    "@pnp/spfx-controls-react": "3.12.0",
    "@pnp/spfx-property-controls": "3.11.0",
    "@uifabric/file-type-icons": "7.10.10",
    "moment": "2.29.4",
    "office-ui-fabric-react": "7.199.1",
    "react": "17.0.1",
    "react-dom": "17.0.1",
    "react-router-dom": "5.3.4",
    "tslib": "2.3.1"
  },

Describe the bug / error
One of our custom SharePoint Webparts which was running fine for over a year now suddenly stopped working a few days ago, stating the following error:
Cannot find manifest for 32b9363b-09ff-4959-929a-cab2663fb223_2.2.1. Store had [3.0.2]. Service worker version: odsp-web-prod_2024-07-19.009; App version: odsp-web-prod_2024-07-19.012; Next app version: odsp-web-prod_2024-07-19.012

CALL STACK:
Error: Cannot find manifest for 32b9363b-09ff-4959-929a-cab2663fb223_2.2.1. Store had [3.0.2]. Service worker version: odsp-web-prod_2024-07-19.009; App version: odsp-web-prod_2024-07-19.012; Next app version: odsp-web-prod_2024-07-19.012
    at e.getManifest (https://res-1.cdn.office.net/files/sp-client/sp-pages-assembly_en-us_d2d0d2e1b878580f3a2b5b3163b29183.js:207:5083)
    at e.requestManifest (https://res-1.cdn.office.net/files/sp-client/sp-pages-assembly_en-us_d2d0d2e1b878580f3a2b5b3163b29183.js:207:7401)
    at e._configureComponentResource (https://res-1.cdn.office.net/files/sp-client/sp-pages-assembly_en-us_d2d0d2e1b878580f3a2b5b3163b29183.js:199:9476)
    at e.configLoadComponent (https://res-1.cdn.office.net/files/sp-client/sp-pages-assembly_en-us_d2d0d2e1b878580f3a2b5b3163b29183.js:199:7324)
    at e._loadComponent (https://res-1.cdn.office.net/files/sp-client/sp-pages-assembly_en-us_d2d0d2e1b878580f3a2b5b3163b29183.js:199:12715)
    at e.loadComponent (https://res-1.cdn.office.net/files/sp-client/sp-pages-assembly_en-us_d2d0d2e1b878580f3a2b5b3163b29183.js:209:346)
    at https://res-1.cdn.office.net/files/sp-client/sp-pages-assembly_en-us_d2d0d2e1b878580f3a2b5b3163b29183.js:199:11071
    at new Promise (<anonymous>)
    at e.loadComponent (https://res-1.cdn.office.net/files/sp-client/sp-pages-assembly_en-us_d2d0d2e1b878580f3a2b5b3163b29183.js:199:10957)
    at e.loadComponent (https://res-1.cdn.office.net/files/sp-client/sp-pages-assembly_en-us_d2d0d2e1b878580f3a2b5b3163b29183.js:199:2270)

As far as we analyzed it for now, it seems that SharePoint somehow isn't providing v.2.2.1 of microsoft-graph-client any more, whereas it gets listed as componend in the generated manifest:

We suspect there was an breaking update to SharePoint lately.
Steps to reproduce
No changes were made to the already working Webpart, so basically setting up a new webpart with the given dependecies and SPFx version should lead to the error.
Expected behavior
Webpart works again with the expected microsoft-graph-client 2.2.1.

We noticed that the problem does not appear on some of our customers tenants.
One finding is, that the following script seems to get loaded correctly on the other tenants but is missing somehow on our productive tenant.:

vs.


Add Internships

https://github.com/lodthe/awesome-internships
A lot of students look for summer internships. This repo contains useful information for them, i. e. companies who are hiring interns, guides on how to create a cv, behavioral interview advice.
I reviewed:

#1959
#1961
#1966

By submitting this pull request I confirm I've read and complied with the below requirements 🖖
Please read it multiple times. I spent a lot of time on these guidelines and most people miss a lot.
Requirements for your pull request

Don't waste my time. Do a good job, adhere to all the guidelines, and be responsive.
You have to review at least 2 other open pull requests.
Try to prioritize unreviewed PRs, but you can also add more comments to reviewed PRs. Go through the below list when reviewing. This requirement is meant to help make the Awesome project self-sustaining. Comment here which PRs you reviewed. You're expected to put a good effort into this and to be thorough. Look at previous PR reviews for inspiration. Just commenting “looks good” or simply marking the pull request as approved does not count! You have to actually point out mistakes or improvement suggestions.
You have read and understood the instructions for creating a list.
This pull request has a title in the format Add Name of List.

✅ Add Swift
✅ Add Software Architecture
❌ Update readme.md
❌ Add Awesome Swift
❌ Add swift
❌ add Swift
❌ Adding Swift
❌ Added Swift

Your entry here should include a short description about the project/theme of the list. It should not describe the list itself. The first character should be uppercase and the description should end in a dot. It should be an objective description and not a tagline or marketing blurb.

✅ - [iOS](…) - Mobile operating system for Apple phones and tablets.
✅ - [Framer](…) - Prototyping interactive UI designs.
❌ - [iOS](…) - Resources and tools for iOS development.
❌ - [Framer](…)
❌ - [Framer](…) - prototyping interactive UI designs

Your entry should be added at the bottom of the appropriate category.
The suggested Awesome list complies with the below requirements.

Requirements for your Awesome list

Has been around for at least 30 days.That means 30 days from either the first real commit or when it was open-sourced. Whatever is most recent.
Don't open a Draft / WIP pull request while you work on the guidelines. A pull request should be 100% ready and should adhere to all the guidelines when you open it.
Run awesome-lint on your list and fix the reported issues. If there are false-positives or things that cannot/shouldn't be fixed, please report it.
The default branch should be named main, not master.
Includes a succinct description of the project/theme at the top of the readme. (Example)

✅ Mobile operating system for Apple phones and tablets.
✅ Prototyping interactive UI designs.
❌ Resources and tools for iOS development.
❌ Awesome Framer packages and tools.

It's the result of hard work and the best I could possibly produce.
If you have not put in considerable effort into your list, your pull request will be immediately closed.
The repo name of your list should be in lowercase slug format: awesome-name-of-list.

✅ awesome-swift
✅ awesome-web-typography
❌ awesome-Swift
❌ AwesomeWebTypography

The heading title of your list should be in title case format: # Awesome Name of List.

✅ # Awesome Swift
✅ # Awesome Web Typography
❌ # awesome-swift
❌ # AwesomeSwift

Non-generated Markdown file in a GitHub repo.
The repo should have awesome-list & awesome as GitHub topics. I encourage you to add more relevant topics.
Not a duplicate. Please search for existing submissions.
Only has awesome items. Awesome lists are curations of the best, not everything.
Does not contain items that are unmaintained, has archived repo, deprecated, or missing docs. If you really need to include such items, they should be in a separate Markdown file.
Includes a project logo/illustration whenever possible.

Either centered, fullwidth, or placed at the top-right of the readme. (Example)
The image should link to the project website or any relevant website.
The image should be high-DPI. Set it to maximum half the width of the original image.

Entries have a description, unless the title is descriptive enough by itself. It rarely is though.
Includes the Awesome badge.

Should be placed on the right side of the readme heading.

Can be placed centered if the list has a centered graphics header.

Should link back to this list.

Has a Table of Contents section.

Should be named Contents, not Table of Contents.
Should be the first section in the list.
Should only have one level of nested lists, preferably none.
Must not feature Contributing or Footnotes sections.

Has an appropriate license.

We strongly recommend the CC0 license, but any Creative Commons license will work.

Tip: You can quickly add it to your repo by going to this URL: https://github.com/<user>/<repo>/community/license/new?branch=main&template=cc0-1.0 (replace <user> and <repo> accordingly).

A code license like MIT, BSD, Apache, GPL, etc, is not acceptable. Neither are WTFPL and Unlicense.
Place a file named license or LICENSE in the repo root with the license text.
Do not add the license name, text, or a Licence section to the readme. GitHub already shows the license name and link to the full text at the top of the repo.
To verify that you've read all the guidelines, please comment on your pull request with just the word unicorn.

Has contribution guidelines.

The file should be named contributing.md. Casing is up to you.
It can optionally be linked from the readme in a dedicated section titled Contributing, positioned at the top or bottom of the main content.
The section should not appear in the Table of Contents.

All non-important but necessary content (like extra copyright notices, hyperlinks to sources, pointers to expansive content, etc) should be grouped in a Footnotes section at the bottom of the readme. The section should not be present in the Table of Contents.
Has consistent formatting and proper spelling/grammar.

The link and description are separated by a dash. Example: - [AVA](…) - JavaScript test runner.
The description starts with an uppercase character and ends with a period.
Consistent and correct naming. For example, Node.js, not NodeJS or node.js.

Doesn't use hard-wrapping.
Doesn't include a Travis badge.You can still use Travis for list linting, but the badge has no value in the readme.
Doesn't include an Inspired by awesome-foo or Inspired by the Awesome project kinda link at the top of the readme. The Awesome badge is enough.

Go to the top and read it again.

unicorn

Thanks for making an Awesome list! 🙌
It looks like you didn't read the guidelines closely enough. I noticed multiple things that are not followed. Try going through the list point for point to ensure you follow it. I spent a lot of time creating the guidelines so I wouldn't have to comment on common mistakes, and rather spend my time improving Awesome.

It seems I'm not able to understand why the suggested repo doesn't meet the guideline rules.
Let's wait for someone's review ¯_(ツ)_/¯

I think you have an mistake in this requirement

Your entry here should include a short description about the project/theme of the list. It should not describe the list itself. The first character should be uppercase and the description should end in a dot. It should be an objective description and not a tagline or marketing blurb.
✅ - iOS - Mobile operating system for Apple phones and tablets.
✅ - Framer - Prototyping interactive UI designs.
❌ - iOS - Resources and tools for iOS development.
❌ - Framer
❌ - Framer - prototyping interactive UI designs

so you have this line  ❌ - [Framer](…) instead of this one ✅ - [Framer](…) - Prototyping interactive UI designs.

I think you have an mistake in this requirement

Your entry here should include a short description about the project/theme of the list. It should not describe the list itself. The first character should be uppercase and the description should end in a dot. It should be an objective description and not a tagline or marketing blurb.
white_check_mark - iOS - Mobile operating system for Apple phones and tablets.
white_check_mark - Framer - Prototyping interactive UI designs.
x - iOS - Resources and tools for iOS development.
x - Framer
x - Framer - prototyping interactive UI designs

so you have this line  ❌ - [Framer](…) instead of this one ✅ - [Framer](…) - Prototyping interactive UI designs.

Thanks! Hope it'll help.

Any updates on what is wrong? 👉👈

Any updates on what is wrong? 👉👈

I think I checked everything and cannot find any issues. @sindresorhus I hope I don't waste your time. but for me everything seems to be fine here. I am just wondering because you said you noticed multiple things that don't meet the guidelines.

Has contribution guidelines.

The file should be named contributing.md. Casing is up to you.
It can optionally be linked from the readme in a dedicated section titled Contributing, positioned at the top or bottom of the main content.
The section should not appear in the Table of Contents.

@lodthe I guess you should create a dedicated section for the contribution guidelines which doesn't appear in the Table of Contents. Currently the link is in the intro description.

Has contribution guidelines.

The file should be named contributing.md. Casing is up to you.
It can optionally be linked from the readme in a dedicated section titled Contributing, positioned at the top or bottom of the main content.
The section should not appear in the Table of Contents.

@lodthe I guess you should create a dedicated section for the contribution guidelines which doesn't appear in the Table of Contents. Currently the link is in the intro description.

@marc0olo thank you so much!
Fixed.

@marc0olo thank you so much!

not 100% sure if this is sufficient. we will see :D

Tweet: https://twitter.com/awesome__re/status/1420173775740579843


[UI] Feature Request: Close app logs and exec windows when underlying app or parent namespace is deleted

Is your feature request related to a problem?
Currently, on version 9.0-0.0.3 if I click on clear button and I delete the namespace the logs are cleaned, but the parent windows stay. This may result misleading for the user

Solution you'd like
Close the windows tabs that contained old logs already cleared.
Alternatives you've considered
No response
Anything else?
No response

@scures We still need to agree a flow for validating issues with Julien / Manuel. I've previously kept them open and moved them to To Test - https://github.com/epinio/ui/projects/1 for when a UI release is made (will do the same with this one). @juadk / @mmartin24 Shall we continue with that pattern?

https://github.com/epinio/ui/issues/135#issuecomment-1215273309
Thanks @scures and @richard-cox for the heads up.  I am normally ok with keeping things as they were, unless I am quite sure about a change, bu  I am not sure exactly how the process went and for which tasks this was followed; for instance do all UI tasks or just the one reported by us?, did we normally do a previous checkup with latest dev version?, when you say a UI release is made, do you mean directly pushed into epinio or ready to be pushed? Maybe we can clarified them separately.

I just checked this issue on latest dev with latest UI and unless I am missing something I am not sure I am seeing the change:

Am I missing something perhaps

@mmartin24 I'm not sure we officially had a process, but would be good to have one agreed by all now. It would be good to have QA test all new feature and bug issues (some issues will be more framework orientated that won't need validating).
From our side the validation could be done in either a dev build (building the UI locally from epinio-dev) or from a UI release (the UI is built and bundled with Epinio, so tests are done from the UI deployed in epinio). The former would be quicker and wouldn't be blocked waiting for a new build, the latter a more fitting environment to validate in though. That decision one is up to you.

Just retried with newest version and see it there. Probably the pr is still not in. @scures, would you pls ping me when it is in?
Thank you.

@richard-cox, sorry, I then misunderstood you when you said above (#135 (comment)) if we should continue the pattern; I thought there was a process in place. If it was not and the aim is to have one, I think it should start by testing in dev, since testing right before release as first time can be very time-consuming and delay things. Ideally, it would be both, when the task is still in dev and after releasing but always that a person can keep up with everything. I'd like to share this thought with the QA team as well before saying something definitive.

@mmartin24 I agree with you.

Tested on epinio version v1.1.0-68-g9f88f884 and working.
Deleting the workspace or the individual apps before clearing or with or without clearing the logs will now close the tabs.


Automated Package Upgrade

:tada: This PR is included in version 7.7.184 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Azure adapter: remove env prefix from stored path

Azure Adapter:
Construct stored_path without env prefix.
media.src attributes (in the database) will now look something like this:
subject_location/7c669787-2677-40ce-90bc-5d3ef185863d.jpeg
project_avatar/1adcb95b-06bf-4f84-ab83-530c1df7c086.jpeg
In leu of using the env prefix, we will have two CDN domains, one for prod and one for staging:
staging: panoptes-uploads-staging.zooniverse.org
production: panoptes-uploads.zooniverse.org
We will store the respective domain URLs in the STORAGE_URL env var. We'll also include the container name in the STORAGE_URL env var, so it'll look like panoptes-uploads-staging.zooniverse.org/public, etc.
The azure adapter get_url method will call the StoredPath class, which will use the correct domain to construct the URL at which the public media item can be accessed. The final URL returned to the client will look something like this:
panoptes-uploads-staging.zooniverse.org/public/subject_location/7c669787-2677-40ce-90bc-5d3ef185863d.jpeg

Review checklist

[ ] First, the most important one: is this PR small enough that you can actually review it? Feel free to just reject a branch if the changes are hard to review due to the length of the diff.
[ ] If there are any migrations, will they the previous version of the app work correctly after they've been run (e.g. the don't remove columns still known about by ActiveRecord).
[ ] If anything changed with regards to the public API, are those changes also documented in the apiary.apib file?
[ ] Are all the changes covered by tests? Think about any possible edge cases that might be left untested.

My reasoning on why I removed it was that I wanted the code to reflect the actual behavior (so that when we go back and look at it we dont end up spending time thinking about whether that @prefix attribute ever gets used or not), if our current plan does not use the prefix, might as well remove it from the code.
If it turns out that this way of proceeding doesn't work, we'll probably need to make other code changes as well if we need to add the prefix back in.


BindingResolutionException

I am new for laravel and I start to use Laravel 5.2
I am making an admin panel so I created a Middleware calling Admin. However there is a binding error and I have no idea about how can I fix that.
My routes.php code is that:
Route::get('/', 'HomeController@index');
Route::get('home', 'HomeController@index');
Route::controllers([
    'auth' => 'Auth\AuthController',
    'password' => 'Auth\PasswordController'
]);
Route::group(['prefix' => 'admin', 'middleware' => 'auth', 'namespace' => 'Admin'], function(){
    Route::pattern('id', '[0-9]+');
    Route::get('dashboard', 'DashboardController@index');
});

This is my Admin.php:
    <?php

namespace App\Http\Middleware;

use Closure;
use Illuminate\Contracts\Auth\Guard;
use Illuminate\Routing\ResponseFactory;
use App\Models\AssignedRole;

class Admin
{
    protected $auth;
    protected $response;
    protected function __construct(Guard $auth,ResponseFactory $response)
    {
        $this->auth = $auth;
        $this->response = $response;
    }
    public function handle($request, Closure $next)
    {
        if($this->auth->check())
        {
            $admin = 0;
            if($this->auth->user()->admin === '1')
            {
                $admin = 1;
            }
            if($admin === 0)
            {
                return $this->response->redirectTo('/');
            }
            return $next($request);
        }
        return $this->response->redirectTo('/');
    }
}

This is my routeMiddleware in the Kernel.php file:
protected $routeMiddleware = array(
    'auth' => \App\Http\Middleware\Authenticate::class,
    'auth.basic' => \Illuminate\Auth\Middleware\AuthenticateWithBasicAuth::class,
    'can' => \Illuminate\Foundation\Http\Middleware\Authorize::class,
    'guest' => \App\Http\Middleware\RedirectIfAuthenticated::class,
    'throttle' => \Illuminate\Routing\Middleware\ThrottleRequests::class,
    'admin' => \App\Http\Middleware\Admin::class
);

And exception message is:

'Illuminate\Contracts\Container\BindingResolutionException' with message 'Target [App\Http\Middleware\Admin] is not instantiable.' in C:\wamp64\www\neredenal\vendor\laravel\framework\src\Illuminate\Container\Container.php:752

Any idea to fix this exception?

Why don't you extend the BaseMiddleware?

I am new for laravel and I start to use Laravel 5.2

Please ask questions on the forums.

What do you mean with BaseMiddleware? Sorry, i didn't understand something completely.


Script to list orphaned pages of user guide

This script crawls the user-guide url, build the list of links and compare with the html files present in the docs/documentation/ folder.

@poornima-krishnasamy are you still working on this, or should we close it?

@digitalronin , totally forgot about this. I will check the comments and update the PR.


Narrower condition to allow for testing with prod values

Coverage remained the same at 94.721% when pulling 994f6848f6e157709bc4b73ee255828e2e2d1e91 on dev_sandbox_filter_health into 6e3fc462423f0220e48305280e5530bf34b88994 on sandbox_filter.


Update Git to [PR BUILD] vfs-2.20.0

Includes v2.20.0.windows.1

@kewillford The functional tests are breaking on things like 'reset' and 'status', and the biggest change in gvfs-2.19.1 since the last time we had functional tests succeeding with a 2.20 release candidate is the post-index-changed hook. Could you take a look at these build failures?

@derrickstolee @benpeart  was there some change to the output of reset --mixed to not display the files that are updated/deleted.  Maybe we aren't setting a flag in the control repo that we are using in VFSForGit?  I will dig in and see what I can find.

@kewillford @benpeart @jrbriggs It appears that the "reset.quiet" setting doesn't work well in our setting. I tried setting it to true in our control repo, but that wasn't enough. Disabling it in our processes made the functional tests pass.
My guess is that the index-changed hook merged cleanly with the reset quiet code in 2.20.0, but that merge introduced a different behavior than the hook expects. For now, I'll clean up this PR to only update the Git version and remove the "reset.quiet" setting and we can work to fix the integration in a follow-up PR.

I'm tempted to pull the change out of the v2.20.0 PR and work to reapply the change directly to that branch. We can then find the best way to halt auto-GC in a VFS for Git repo.

Yes, please pull this patch out of 2.20.0 - I'll go back and figure out best to handle the automatic 'git gc --auto' commands (which will fail silently later as we turn off auto GC in VFSForGIT repos).
My bad - I hadn't merged the PR to switch VFSForGIT to use the new version of git yet and didn't expect it to get pulled into 2.20.0 before I'd had a chance to run the functional tests.

Do you know what is running the gc --auto or why it is running? We set { "gc.auto", "0" }, in the config for the repo which I though should be disabling it.

Several git commands spawn "gc --auto" themselves (am, commit, fetch, merge, rebase, etc).  I've updated the patch in git to check for --auto and will only die if the config setting 'gc.auto' isn't "0" (ie turned off).

The latest push disables the builtin rebase. This is to check the performance results. It may cause a failure in the functional tests due to different warning/error messages.


Error when calling px4_nuttx_make_uavcan_bootloadable

If run：
make esc35-v1_default
or
make px4esc-v1_default
or
make s2740vc-v1_default
or
make px4cannode-v1_default
there will coming a same error:
make[3]: *** [  1%] No rule to make target `src/firmware/nuttx/firmware_nuttx.bin', needed by...
and if remove the calling of px4_nuttx_make_uavcan_bootloadable in the ./cmake/configs/*.cmake,the bilud will be passed!

I think this may be related to your build setup.
This builds fine https://semaphoreci.com/px4/firmware/branches/master/builds/1221 see ./Tools/docker_run.sh 'make alt_firmware'
Please run make clean and ensure you have all the submodules updated (make distclean) also check the version of the compiler it should be 5.4.1

@zouboan is this resolved?

@zouboan I am closing this. If it still an issue please feel free to reopen


Prepare 2.0.0 release

Codecov Report

Merging #27 (f896a2d) into master (6106737) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #27   +/-   ##
=======================================
  Coverage   36.36%   36.36%
=======================================
  Files           1        1
  Lines          22       22
=======================================
  Hits            8        8
  Misses         14       14

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6106737...f896a2d. Read the comment docs.


prometheus: remove feature gate for the prometheus receiver

Description
Removing experimental feature gate before we go GA.
Related issue
b/265973579 | P1 | Remove feature gate for the prometheus receiver for GA
Checklist:

Unit tests

[ ] Unit tests do not apply.
[x] Unit tests have been added/modified and passed for this PR.

Integration tests

[ ] Integration tests do not apply.
[x] Integration tests have been added/modified and passed for this PR.

Documentation

[ ] This PR introduces no user visible changes.
[ ] This PR introduces user visible changes and the corresponding documentation change has been made.

Minor version bump

[ ] This PR introduces no new features.
[x] This PR introduces new features, and there is a separate PR to bump the minor version since the last release already.
[ ] This PR bumps the version.

i have never in my life seen this before. this is all i wanted for years. i guess i can mark my career as complete now.

Test failures seem unrelated. Merging now


findWithoutFail Method does not exist

Get nice Whoops! message: Call to undefined method App\Repositories\FlightRepository::findWithoutFail()

I believe I have this fixed locally, it's from updating Laravel to the latest version, waiting on some aux 3rd party library to be updated as well.


Execute automated performance/load testing

Would like to ensure that the site won't fall over during a public beta review period.

Set up some concurrency tests with Blazemeter. AWS seems to keep up spawning new app servers as the load goes up; site seemed to be totally OK getting hammered with 500 concurrent users over a 20 minute period.
Response time creeps up until a new app server is spawned and then drops back down:

During times of peak demand users can expect to get a few 503 errors until new app servers come on board, but this can be easily ameliorated by proactively provisioning more than we'd normally want (like right after a public announcement).


Use memcached in tile server

Overview
This introduces the use of memcached in the tile server. This requires a switch from scaffine caching library to scalacache. We bring in the elasticache aware memcache client: https://github.com/awslabs/aws-elasticache-cluster-client-memcached-for-java
Introduces new environment variables:

MEMCACHED_HOST: default to tile-cache.service.rasterfoundry.internal
MEMCACHED_PORT: default to 11211

We still require caffine, which is now used through scalacache in order to perform in-memory caching for the tile readers and attribute stores. The story with attribute stores is a little strange because they maintain internal cache for the layer metadata attributes. This can be made less strange by writing a GeoTrellis AttributeStore mixin that does the caching in memcached.
The default behavior is in memcached is to use Java serialization to encode the values (tiles). This is OK, but can be made better by using Kryo instead.
At this point this PR should be OK to be tested.
Checklist

[x] Use memcached through scalacache for tiles
[x] Add configuration and env vars for memcached
[x] Test single scene endpoint
[x] Test mosaic endpoint
[ ] AttributeStore caching based on memcached
[ ] More efficient compression Codec for memcached

Connects #763

Tested the project mosaic endpoint manually, it appears to work and caching is seen to be effective when switching between two projects using the same scenes. We can leave the final two checkboxes for next PR.

+1 nice


Error on first usage of :IronRepl

The first time i run :IronRepl i get the folloing error. After that it seems to work. I also can't seem to send any text to the repl "ctr$" just does nothing.
Error detected while processing function remote#define#CommandBootstrap[5]..remote#define#request:
line    2:
error caught in request handler '/home/roman/.config/nvim/plugged/iron.nvim/rplugin/python3/iron:command:IronRepl [0]':
Traceback (most recent call last):
File "/home/roman/.config/nvim/plugged/iron.nvim/rplugin/python3/iron/init.py", line 70, in create_repl
self.iron_repl([ft], bang=bang)
File "/home/roman/.config/nvim/plugged/iron.nvim/rplugin/python3/iron/init.py", line 101, in iron_repl
self.open_repl(template, **kwargs)
File "/home/roman/.config/nvim/plugged/iron.nvim/rplugin/python3/iron/base.py", line 311, in open_repl
create_new_repl()
File "/home/roman/.config/nvim/plugged/iron.nvim/rplugin/python3/iron/base.py", line 300, in create_new_repl
repl_id = self.termopen(command, with_placement)
File "/home/roman/.config/nvim/plugged/iron.nvim/rplugin/python3/iron/base.py", line 93, in termopen
return open_term(self.nvim, cmd)
File "/home/roman/.config/nvim/plugged/iron.nvim/rplugin/python3/iron/zen/ui.py", line 81, in open_term
ret = nvim.funcs.termopen(cmd)
File "/usr/lib/python3.6/site-packages/neovim/api/nvim.py", line 229, in call
return self.request('nvim_call_function', name, args, **kwargs)
File "/usr/lib/python3.6/site-packages/neovim/api/nvim.py", line 130, in request
res = self._session.request(name, *args, **kwargs)
File "/usr/lib/python3.6/site-packages/neovim/msgpack_rpc/session.py", line 97, in request
raise self.error_wrapper(err)
neovim.api.nvim.NvimError: b'Vim:Can only call this function in an unmodified buffer'
Error detected while processing function remote#define#CommandBootstrap:
line    5:
E171: Missing :endif

This is strange.
Could you paste the versions of neovim and the neovim python lib you're using?

I am on Arch Linux and using the community repo to install NeoVim which is version 0.2.2 atm and the python lib is version 0.2.0

I just tested here and everything seems to be working correctly.. Can you give more details regarding repl type and what happens besides the stack trace? Any information will help debugging this..
Cheers,

Well I open nvim then open a .py file via NerdTree then either IronRepl or IronPromptRepl (no difference) causes the error while also opening an empty split. Then running the command again another split opens with the repl active inside.
But even with it open I can't send any text to the repl unless I enter it manually ("ctr$" does nothing, well the "ctr" does change the cursor and with "$" it changes back but nothing happens.)
Hope that helps. Ill be trying this on another system of mine and see how it goese there.

I have the same issue. error occur when i initial IronRepl, but it still work after the error.
I can only access these commands
IronClearReplDefinition  IronDumpReplDefinition IronPromptCommand IronPromptRepl            IronRepl
and these commands are missing:
IronSend IronSendMotion IronSendSpecial
my python version is 3.6.3 with GCC 7.2.0,
neovim python lib 0.20,
NVIM v0.2.3 ,
Lua 5.1.4,
Red Hat 4.4.4-13

Ok, I could get what's happening but not why. It's trying to open a new repl over the current buffer instead of opening the repl over a new buffer, created with enew. Since the current buffer is modified (but not saved), the repl opening fails. This is very strange.

Hi,
I'm revisiting this now that iron has changed to a lua backend.
This issue should be gone, since there's no python/pynvim/remote abstraction layer in between.
I'll close this but feel free to reopen if you're using the legacy python backend or open a new one if you have any other questions or problems.
Cheers,
Henry John Kupty


bug:

Bug Report
IonButton not reacting to "Enter" on form with react-hook-form. Occurs in browser under chrome, not tried on mobile.
Ionic version:
[x] 5.1.0
Current behavior:
Using IonButton with react-hook-form.  When standard <button> is used expected behaviour of running "onSubmit" runs when "Enter" is pressed within a form field.  If <button> is changed to <IonButton> then "Enter" does not run onSubmit, the IonButton must be pressed.
Expected behavior:
When <IonButton type="submit"> is placed on react-hook-form and "Enter" is pressed while in form input field, the "onSubmit" function should be run.
Steps to reproduce:
Hope it's OK but I'll reference the code from this article https://medium.com/better-programming/how-to-use-react-hook-form-with-ionic-react-components-eaa4426d8a2d
There is a related CodeSandbox.io project here: https://codesandbox.io/s/react-hook-form-ionic-input-components-29zur
Run the project, complete the form validation, and press "Enter" while in a form input field.  Nothing will happen,
Modify the code of the submit button changing <IonButton> to <button> and repeat the exercise.
This time the onSubmit function will run and a popup will display the form fields.
Related code:
As above
Other information:
Ionic info:
This is from my own project which exhibits the same behaviour:
Ionic:
Ionic CLI       : 6.9.3 (/usr/lib/node_modules/@ionic/cli)
Ionic Framework : @ionic/react 5.1.0
Capacitor:
Capacitor CLI   : 2.0.1
@capacitor/core : 2.0.1
Utility:
cordova-res : not installed
native-run  : not installed
System:
NodeJS : v12.17.0 (/usr/bin/node)
npm    : 6.14.4
OS     : Linux 4.19

Thanks for the issue. Does this still reproduce without the use of react-hook-form? It may just been that react-hook-form does not support Ionic fully.

Sorry, haven't tried that.  Only just learning to work with this technology
stack.
It's just gone 23:30 here so I will test that tomorrow.
THANKS
Peter Hancox | Consulting Architect
*D *DELTA Technology Consulting | p +61 2 9420 1800 | m +61 418 426 269 |
skype phancox
On Wed, 3 Jun 2020 at 23:27, Liam DeBeasi<EMAIL_ADDRESS>wrote:

Thanks for the issue. Does this still reproduce without the use of
react-hook-form? It may just be that react-hook-form does not support
Ionic fully.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/ionic-team/ionic/issues/21427#issuecomment-638196276,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAFNPQ6MR6YLMQNLY7OJX4TRUZFU5ANCNFSM4NRTUHSQ
.

Seems to be an issue without react-hook-form as well.
ionic start ionic-form blank
Replace Home.tsx with the following.  Put the cursor in the Test Input
field and press Enter.  Nothing happens.  Replace IonButton with button and
repeat.  This time the alert is shown when Enter is pressed in the input
field.
import { IonContent, IonHeader, IonPage, IonTitle, IonToolbar, IonInput,
IonButton } from '@ionic/react';
import React from 'react';
import './Home.css';
const Home: React.FC = () => {
return (

Blank

Test Input
<IonButton type="submit" onClick={() => {alert("Form Submitted")}}

Submit

);
};

export default Home;
Peter Hancox | Consulting Architect
*D *DELTA Technology Consulting | p +61 2 9420 1800 | m +61 418 426 269 |
skype phancox
On Wed, 3 Jun 2020 at 23:27, Liam DeBeasi<EMAIL_ADDRESS>wrote:

Thanks for the issue. Does this still reproduce without the use of
react-hook-form? It may just be that react-hook-form does not support
Ionic fully.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/ionic-team/ionic/issues/21427#issuecomment-638196276,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAFNPQ6MR6YLMQNLY7OJX4TRUZFU5ANCNFSM4NRTUHSQ
.

Thanks for the follow up. So the reason why this is happening is buttons in the Shadow DOM are not picked up by the parent form. In this case, clicking the button and pressing "Enter" would normally not submit the form.
We added some code to submit the form when you click the button: https://github.com/ionic-team/ionic/blob/master/core/src/components/button/button.tsx#L155
The issue still persists for pressing "Enter". I will look into adding a fix for this in Ionic Framework, but for now you can add a keyup listener on the form to work around this limitation.

Hi Liam, thanks for taking the time to look into this for me.  And I really
appreciate you providing a workaround.
So with your fix to the Ionic code, if the cursor is in an input field on
the form when the enter key is pressed, it will submit the form, right?
Peter Hancox | Consulting Architect
*D *DELTA Technology Consulting | p +61 2 9420 1800 | m +61 418 426 269 |
skype phancox
On Sat, 6 Jun 2020 at 01:03, Liam DeBeasi<EMAIL_ADDRESS>wrote:

Thanks for the follow up. So the reason why this is happening is buttons
in the Shadow DOM are not picked up by the parent form. In this case,
clicking the button and pressing "Enter" would normally not submit the form.
We added some code to submit the form when you click the button:
https://github.com/ionic-team/ionic/blob/master/core/src/components/button/button.tsx#L155
The issue still persists for pressing "Enter". I will look into adding a
fix for this in Ionic Framework, but for now you can add a keyup listener
on the form to work around this limitation.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/ionic-team/ionic/issues/21427#issuecomment-639551026,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAFNPQZUCXVRKLWTTITFOTDRVECLLANCNFSM4NRTUHSQ
.

The behavior I am looking to implement is to have the form be submitted and the submit button's click event be dispatched when pressing "Enter" in a focused input.

Perfect.  Thanks
Peter Hancox | Consulting Architect
*D *DELTA Technology Consulting | p +61 2 9420 1800 | m +61 418 426 269 |
skype phancox
On Mon, 8 Jun 2020 at 23:48, Liam DeBeasi<EMAIL_ADDRESS>wrote:

The behavior I am looking to implement is to have the form be submitted
and the submit button's click event be dispatched when pressing "Enter" in
a focused input.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/ionic-team/ionic/issues/21427#issuecomment-640614343,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAFNPQZRCI4GAR3SJHV7ONLRVTT2HANCNFSM4NRTUHSQ
.

Looks like this is a duplicate of https://github.com/ionic-team/ionic/issues/19368, so I am going to close this one out in favor of that issue. Thanks!


[Map] Changes to LOI geometries not reflected on map

This code doesn't actually remove and re-add modified features, it removes features which have been deleted, and adds all the features back to the map on each update:
https://github.com/google/ground-android/blob/59e21435853fc7a60330c0c8b331575c04ecce6a/ground/src/main/java/com/google/android/ground/ui/map/gms/GoogleMapsFragment.kt#L290-L300
For example:
https://github.com/google/ground-android/blob/59e21435853fc7a60330c0c8b331575c04ecce6a/ground/src/main/java/com/google/android/ground/ui/map/gms/renderer/PolygonFeatureManager.kt#L76-L81
And:
https://github.com/google/ground-android/blob/59e21435853fc7a60330c0c8b331575c04ecce6a/ground/src/main/java/com/google/android/ground/ui/map/gms/GoogleMapsFragment.kt#L276-L288
@shobhitagarwal1612 FYI

Fixed by #2157.


Welcome collabrators

Happy to help. Need to update the dashboard etc to latest version and close a lot of these issues.

Should we docker-parse-cloud, dashboard and server under a new organization in GitHub and collaborate on that, since they are interdependent it makes more sense I think

Agreed, but I am still thinking about the organization name

Any Update? I have a project really like that. Maybe I can help to maintain this project.

@trylovetom , sure.

+1


input from dorks in stdin is all added into a single query

if you have in your dorks file like this:
"Index of/"
inurl:example.com
the script will read and transform in a query as ["Index of" inurl:example.com]. All the dorks are added to the query in a single line, which decreases the odds of getting any desirable result.
As a workaround, what I'm doing is basically cat dorks | xargs -I {} go-dork -q "{}" -e . Works just fine
Because of this, it would be nice to run from stdin and for each line on dorks file adding a new line in the query. So, instead of interpreting each line as new data to be added to a single query, just run it for each line and run as a single query for each line:
query "index of/" --> search
query "inurl:example.com --> search
Wonderful tool, never the less. Very good job!

No, that didn't happen. It's just a display, actually it will be executed correctly. Try to debug it with Burp Suite or another proxy to monitor your requests.

I just tested and you're absolutely right, I was running it and just checking how the query was being made. Very sorry to raise this issue. Thank you so much for your fast reply. Once again, excellent tool


refactor(config): set default value CommonJS after resolving tsconfig

Summary

Set default module CommonJS after resolving tsconfig
Test plan

Adjusted unit test, green CI
Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information
N.A.

Pull Request Test Coverage Report for Build 488018417

0 of 1 (100.0%)  changed or added relevant line in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.01%) to 93.668%

Totals

Change from base Build 487936243:
0.01%

Covered Lines:
948

Relevant Lines:
978

💛  - Coveralls

Pull Request Test Coverage Report for Build 488018417

0 of 1 (100.0%)  changed or added relevant line in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.01%) to 93.668%

Totals

Change from base Build 487936243:
0.01%

Covered Lines:
948

Relevant Lines:
978

💛  - Coveralls

Pull Request Test Coverage Report for Build 488018417

1 of 1 (100.0%)  changed or added relevant line in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.01%) to 93.668%

Totals

Change from base Build 487936243:
0.01%

Covered Lines:
948

Relevant Lines:
978

💛  - Coveralls

Pull Request Test Coverage Report for Build 488018417

1 of 1 (100.0%)  changed or added relevant line in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.01%) to 93.668%

Totals

Change from base Build 487936243:
0.01%

Covered Lines:
948

Relevant Lines:
978

💛  - Coveralls


Add Camera Icon near Search and it Functionality to click picture and store it somewhere

@pratibh13 closing this issue, create a different story for handing the clicked image.


Sidepanel support

Sidepanel is available now in Chrome extension
https://developer.chrome.com/docs/extensions/reference/api/sidePanel?hl=fr
It would be great to add it in in generated templates.

sorry, already done ;)


Correlation id (traceparent) is not propagated in 0.7.0

In what area(s)?
/area runtime
What version of Dapr?
0.7.0
I have a typical pub sub scenario and using Service Bus as a message broker.
My publisher uses Dapr State Store API and Dapr Publish API and I pass correlation id (now traceparent id) to both calls so that I can track requests end-to-end in Application Insight.
In my subscriber app I extract the correlation id passed by publisher and pass it along when calling dapr output bindings.
After installing dapr 0.7.0 I am seeing 2 issues:

My subscriber app no longer receives correlation id from the publisher:
{ traceparent: '00-00000000000000000000000000000000-0000000000000000-00' }

note: traceparent looks normal in publisher app: 00-acbd9521619856c592b5971cebfb2adc-0000000000000000-01

In Application Insight all calls are disconnected now. It was a tree like structure before.

I changed my tracing configuration to:
apiVersion: dapr.io/v1alpha1
kind: Configuration
metadata:
  name: tracing
spec:
  tracing:
    samplingRate: "1"

Also renamed "x-correlation-id" to "traceparent" everywhere in my apps and cleaned the Service Bus queue. Anything else I am missing?

@shalabhms @youngbupark can you assist?

@programaka Sorry for breaking your scenario! We will investigate it about what we missed. Can you please share the screenshot of app map in application insights?

If this is correct, it's a P0.

@youngbupark
now:

before:

End-to-end transaction view (now):

End-to-end transaction view (before):

@programaka Thanks for the report. We have changed the behavior in 0.7.0, but this is not what we expected.
@shalabhms Unfortunately, new code doesn't extract trace id from cloudevent payload so that @programaka found zeros trace/span ids. I remembered that we decided to create the dependency node for pubsub component, but it doesn't seems like it works as we decided--publish and subscribe dependencies are supposed to be same and trace id should not be zeros trace/span ids.
The old way that @programaka shared makes more sense. We can treat pubsub as a normal service invocation. state/binding can be treat it as normal dependency node. Can we write up small proposal for state/binding/pubsub for http and grpc scenarios ? Also we have to provide good documentation for distributed trace for each components. Instead of rushing out fix the problem, I suggest to fix this with proposal and good documentation in 0.8.0 release.
cc/ @yaron2 @amanbha @msfussell @orizohar

Since this is a regression, I would say this is a P0 and should be released as 0.7.1.

Since this is a regression, I would say this is a P0 and should be released as 0.7.1.

Yup, make sense. Pubsub part is easy to fix; extracting correlation id from cloudevent payload.

Since this is a regression, I would say this is a P0 and should be released as 0.7.1.

Yup, make sense. Pubsub part is easy to fix; extracting correlation id from cloudevent payload.

Yeah. We need to fix this and the binding event, and release docs about how to propogate the context (which should be the same for invocation/pubsub/state/bindings) and extracting the context in user code for invocation/pubsub/binding

Agreed on getting this fixed in a 7.1 release and especially have docs on how to propogate the context across different calls.

Agree to fix  Pubsub in 0.7.1,
We will refactor tracing code soon for next milstone. I do recommend to change bindings and state behavior with the docs and samples in the next milestone. The previous tracing for binding and state was wrong because we expose internal localhost communication. we need to find a way to hide localhost communication and show proper dependency tracing. That’s why I suggest to write Small proposal first.
Also we need to have a proper change in dotnet sdk and java sdk which allows user to pass their own correlation headers in a seamless way.
In sum, here is my suggestion:

Change pubsub in 0.7.1 - populate missing trace id to subscriber app
Write small proposal for binding and state first and then implement it with tracing Code refactoring for 0.8.0 release
Write docs, samples, and sdks in 0.8.0 release

@yaron2 @msfussell any feedbacks?

@shalabhms ^

Agree to fix Pubsub in 0.7.1, but not for the others, state and bindings.
We will refactor tracing code soon for next milstone. I do recommend to change bindings and state behavior with the docs and samples in the next milestone. The 0.6.0 tracing for binding and state was wrong because we exposed internal localhost communication. we need to find a way to hide localhost communication and show proper dependency tracing. That’s why I suggest to write Small proposal first.
Also we need to have a proper change in dotnet sdk and java sdk which allows user to pass their own correlation headers in a seamless way.
In sum, here is my suggestion:

Change pubsub in 0.7.1 - populate missing trace id to subscriber app
Write small proposal for binding and state first and then implement it with tracing Code refactoring for 0.8.0 release
Write docs, samples, and sdks in 0.8.0 release

@yaron2 @msfussell any feedbacks?

lgtm. I'm ok with this because state can still be traced today. The details of how it looks on the map is ok to change for 0.8.

Looking at the issue . Thanks.

I think the fix is this PR https://github.com/dapr/dapr/pull/1482 .
cc @yaron2 , @youngbupark , @amanbha

This issue is fixed through https://github.com/dapr/dapr/pull/1544


Added support for audit

Codecov Report
Base: 4.52% // Head: 4.60% // Increases project coverage by +0.07% :tada:

Coverage data is based on head (ebc1818) compared to base (6ff55cd).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff             @@
##             master     #36      +/-   ##
===========================================
+ Coverage      4.52%   4.60%   +0.07%
  Complexity       39      39
===========================================
  Files           171     171
  Lines          3290    3298       +8
  Branches        374     374
===========================================
+ Hits            149     152       +3
- Misses         3117    3123       +6
+ Partials         24      23       -1

Impacted Files
Coverage Δ

...lin/io/github/ydwk/ydwk/impl/entities/GuildImpl.kt
0.00% <0.00%> (ø)

...hub/ydwk/ydwk/impl/rest/type/SimilarRestApiImpl.kt
0.00% <0.00%> (ø)

...wk/event/backend/managers/CoroutineEventManager.kt
38.46% <0.00%> (+11.53%)
:arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Fix naming issues

The order of template arguments are reversed for some classes (e.g. itkMeshInterface). For example, the arguments reads template<int Dimension, TPixel> where ITK usually do template<TPixel, int Dimension>.
Also see #109.

Comment in #135: "The interfaces starts with lower-case itk while everything else starts with Itk. We should harmonize the conventions at some point."

ItkDisplacementFieldImageWarperComponent vs selxDisplacementFieldImageWarperComponent.


Fix the deserialization error of FieldEntry when the 'options' field …

Currently, FieldEntry deserialization is done manually by using a custom deserializer. During the parsing process, if  the "options" field appears before the "type" field, an error will occur.
Example of json on which the error occurs:
{
  "name": "title",
  "options": {
    "indexing": {
      "record": "position",
      "tokenizer": "default"
    },
    "stored": false
  },
  "type": "text"
}

This pull request changes the custom serializer to serde_derive macro, which fixes the described error.

Thank you!


ngscopeclient: spectrogram rendering

It seems this issue can be closed as it seems implemented since commit https://github.com/glscopeclient/scopehal-apps/commit/bf81dbc4cc6a9d5d80950a8359aa74e5e450241c to be clarified


Support running tests in root privilege on Linux.

PR Summary
Support running tests in root privilege on Linux. Delete skip tag in tests which require sudo.
PR Checklist
Note: Please mark anything not applicable to this PR NA.

[x] PR has a meaningful title

[x] Use the present tense and imperative mood when describing your changes

[x] Summarized changes
[NA] User facing Documentation needed

[NS] Issue filed - Issue link:

[x] Change is not breaking
[NA] Make sure you've added a new test if existing tests do not effectively test the code changed

[NA] Add [feature] if the change is significant or affects feature tests

[x] This PR is ready to merge and is not Work in Progress.

If the PR is work in progress, please add the prefix WIP: to the beginning of the title and remove the prefix when the PR is ready.

@kalgiz  You had an error . https://ci.appveyor.com/project/PowerShell/powershell/build/v6.1.0-preview.7918#L19  this needs to be fixed.

you also need to resolve merge conflicts.


Minor changes in quickstart guide

Add build-essential and libssl-dev as pre-reqs
for bigchaindb installation

Codecov Report

Merging #1648 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1648   +/-   ##
=======================================
  Coverage   98.46%   98.46%
=======================================
  Files          59       59
  Lines        2862     2862
=======================================
  Hits         2818     2818
  Misses         44       44

I approved this PR under the assumption that the forthcoming fix to setup.py resolves the issue with pip install bigchaindb

fixes #1658


React to breaking change latest API Check detects

see PR aspnet/BuildTools#259 and issue aspnet/BuildTools#146

@Tratcher was f5107596a5486f9531276af290ac32d2a62780ec an intentional breaking change? If not, we should revert it before I check aspnet/BuildTools#259 in.

Yes it was.

5b9e129


Closes #23: Added work process to the Readme

Closes #23
see this updated Readme here

Added demo link to top of the README
Updated Readme with links to collaboration tools
Added process documentation
Updated some team member roles

@gclancy @ajturner this should have been merged not closed, right?

Merged - sorry

Got it


Test | Fix akvtest issues

I noticed the AKVTests (3 tests in total) are skipped and have never run on our AE tests due to nameof(DataTestUtility.AreConnStringsSetup) in tests condition.
There will be one failure due to an exception change in Azure.Identity 1.7.0 since the expected error message has been changed. Read here.

/azurepipelines run


Testing updates and Fixing rollout timeouts

Testing updates

updating test files to get CI working properly
Bumping Jenkinsfile container version
fixing headers that were missed

Various script updates

Setting context for every call. Not relying on a content that can
change mid stream.
Fixing linting problems.
Setting timeout on rollout

please test this

test this please

/ltgm


Add last activity date to teams-usage-report.md

Closes https://github.com/MicrosoftDocs/OfficeDocs-SkypeForBusiness/issues/9784.

@MikePlumleyMSFT
PR has been copyedited and is ready for final review, could you please check and merge? Thanks!


ETH: ERROR - Error getting balance: NOTOK

This error is coming on every wallet prompt. See shot
Do I need to upgrade the API endpoint on etherscan for it to work properly on ETH?

SOLVED!
I figured out based on the "closed issues" that the issue is related to API.
as I had configured the API in the docker file, I thought it got placed everywhere it needed to be.
The fact is, you need to go into your Docker Container "EXEC" and edit the file "EnigmaCracker.env" and put your API key there too.
The bad is, that Docker doesn't have an Editor by default.
my working method was:
apt-get update
apt-get install nano
nano EnigmaCracker.env
after editing and saving the file, just stop and start the container again to load new settings.

you see 😊  no more error!


Add param ip to config ip resolver

Hi,
Thanks for your pull request. I just had a quick look at it and it seems to solve the issue.
However, I would have the following suggestions to improve it:

Instead of two parameters (-local and -ip) one parameter would be better imho. For example:

-ip:local
-ip:public
-ip:<IP_ADDRESS>

Instead of putting the new logic into the existing LocalIpResolver, there should be a new implementation for IIpAddressResolver. Depending on the part behind „ip:“ the right implementation could be created/selected.
The port of the AdminPanel has been changed. Is there a reason for it: should we add another parameter?
The readme of the Startup project needs to be updated as well

Whould you like to provide a param of port admin panel for it, example -adminport:1234


adding conditioned support to multichannel SincConv

As discussed in (Issue 774)[https://github.com/speechbrain/speechbrain/issues/774], I'm trying to batch the channels for multichannel support on the SincConv operation.
This modification is heavily inspired by the espnet2 repo.

Thank you  @Hguimaraes! I tested and everything seems to work properly!


Update sbt to 1.4.9

Updates org.scala-sbt:sbt from 1.4.7 to 1.4.9.
GitHub Release Notes - Version Diff
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "org.scala-sbt", artifactId = "sbt" } ]

labels: library-update, semver-patch

Codecov Report

Merging #179 (366f3f4) into master (fe1597c) will decrease coverage by 1.50%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #179      +/-   ##
==========================================
- Coverage   72.47%   70.96%   -1.51%
==========================================
  Files          12       15       +3
  Lines         436      496      +60
  Branches       18       22       +4
==========================================
+ Hits          316      352      +36
- Misses        120      144      +24

Impacted Files
Coverage Δ

...n/scala/io/github/vigoo/clipp/zioapi/package.scala
69.56% <0.00%> (-16.15%)
:arrow_down:

.../main/scala/io/github/vigoo/clipp/catseffect.scala
75.00% <0.00%> (-12.50%)
:arrow_down:

...e/src/main/scala/io/github/vigoo/clipp/clipp.scala
62.50% <0.00%> (ø)

...c/main/scala/io/github/vigoo/clipp/ClippImpl.scala
50.00% <0.00%> (ø)

.../io/github/vigoo/clipp/zioapi/config/package.scala

...src/main/scala/io/github/vigoo/clipp/parsers.scala
48.57% <0.00%> (ø)

...src/main/scala/io/github/vigoo/clipp/choices.scala
80.00% <0.00%> (ø)

.../src/main/scala/io/github/vigoo/clipp/errors.scala
38.46% <0.00%> (ø)

.../src/main/scala/io/github/vigoo/clipp/syntax.scala
76.92% <0.00%> (ø)

...hub/vigoo/clipp/usageinfo/UsagePrettyPrinter.scala
38.70% <0.00%> (+0.24%)
:arrow_up:

... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fe1597c...366f3f4. Read the comment docs.


error converting YAML to JSON: yaml works on 4.7.0 but does not work in 4.8.0

What happened?
Kubernetes manifests that works with 4.7.0. don't work with 4.8.0 anymore
Error
Applying manifests with kubectl  Error deploying mysql: failed to unmarshal manifest: error converting YAML to JSON: yaml: line 2: mapping values are not allowed in this context Please make sure kubectl applydoes work locally with manifestmysql-service.yaml``
kubectl apply works with the given manifests without problems.
Using devspace 4.7.0 also works
What did you expect to happen instead?
Manifest should be applied
How can we reproduce the bug? (as minimally and precisely as possible)
devspace yaml
version: v1beta7
deployments:
  - name: mysql
    kubectl:
      manifests:
        -mysql-service.yaml
dev: {}

mysql-service.yaml
apiVersion: v1
kind: Service
metadata:
  name: mysql
spec:
  ports:
  - port: 3306
  selector:
    app: mysql
  clusterIP: None
---
apiVersion: apps/v1
kind: Deployment
metadata:
  name: mysql
spec:
  selector:
    matchLabels:
      app: mysql
  strategy:
    type: Recreate
  template:
    metadata:
      labels:
        app: mysql
    spec:
      containers:
      - image: mysql:5.7
        name: mysql
        readinessProbe:
          exec:
            command: ["mysql", "-h", "<IP_ADDRESS>", "-u","user","-ppassword", "-e", "SELECT 1"]
          initialDelaySeconds: 5
          periodSeconds: 2
          timeoutSeconds: 1
        env:
        - name: MYSQL_USER
          value: "user"
        - name: MYSQL_ROOT_PASSWORD
          value: "password"
        - name: MYSQL_ALLOW_EMPTY_PASSWORD
          value: "true"
        ports:
        - containerPort: 3306
          name: mysql
        volumeMounts:
        - name: mysql-storage
          mountPath: /var/lib/mysql
        - name: config-volume
          mountPath: /etc/mysql/conf.d
      volumes:
      - name: mysql-storage
        emptyDir: {}
       # hostPath:
       #   path: /var/lib/mysql
      - name: config-volume
        configMap:
          name: mysql

---
apiVersion: v1
kind: ConfigMap
metadata:
  name: mysql
  labels:
    app: mysql
data:
  config.cnf: |
    [mysqld]
    sql_mode = ERROR_FOR_DIVISION_BY_ZERO,NO_ENGINE_SUBSTITUTION

Local Environment:

DevSpace Version: 4.8.0
Operating System: mac
Deployment method: kubectl apply

Kubernetes Cluster:

Cloud Provider: aws
Kubernetes Version:
Client Version: version.Info{Major:"1", Minor:"18", GitVersion:"v1.18.0", GitCommit:"9e991415386e4cf155a24b1da15becaa390438d8", GitTreeState:"clean", BuildDate:"2020-03-26T06:16:15Z", GoVersion:"go1.14", Compiler:"gc", Platform:"darwin/amd64"}
Server Version: version.Info{Major:"1", Minor:"15+", GitVersion:"v1.15.10-eks-bac369", GitCommit:"bac3690554985327ae4d13e42169e8b1c2f37226", GitTreeState:"clean", BuildDate:"2020-02-26T01:12:54Z", GoVersion:"go1.12.12", Compiler:"gc", Platform:"linux/amd64"}

Anything else we need to know?

/kind bug

@feguiguren  thanks for reporting! The issue is kubectl v1.18 that has deprecated the flag --dry-run we are using, and devspace tries to parse the error message that kubectl spits out which results in the above error. I'll fix this for the next version!

Fixed in 4.9.0


Color output

Describe the bug
the component outputs Color from a list of dictionaries as {'color': <System.Drawing.Color object at 0x0000027557785800>}
my input is colour CMYK component from grasshopper which is added to a list of dictionaries list = [{'color': input_color}]
Expected output
{'color': (0,0,0)} or {'color': [A=255, R=0, G=0, B=0]}
OS

OS: Windows
Rhino 8

Additional bug
bug which is indirectly related
script-sync fails if input is a list with more than 2 items

Hello @nizartaha thanks for reporting this!
To be able to help you could you please provide:

the exact Rhino version (go to "help >> about Rhinoceros.." and see the small number on the right of the poped up window
could you add a .ghx and/or the code you are trying to runnin?

Thanks!

Hello @9and3
Here you go. Thank you for the plugin

Version 8 SR12 (8.12.24282.7001, 2024-10-08)
github doesnt support .ghx so here is the script for a color_bug.py file and here a screenshot to be able to reproduce from grasshopper.
please note that i included another issue with the file related to a list of lists output.

# 1 _ bug 1 color
data = [
    {
        "type": "list of dictionaries",
        "color": [color_CMYK]
    }
]

# 2 _ bug 2
x = pt.X
y = pt.Y
z = pt.Z
s = ["Hello World"]
lxyz = [x, y, z]

out = [s]
out2 = [lxyz]
# please comment out the following line
# out3 = [x, y, z, s]

Hello @nizartaha ,
So I finally got some time to have a look at this issue:

Concerning the color output of a dictionnary. This is a normal behavior that you see the System.Drawing.Color object since this is how Grasshopper internalize color objects. If you want to visualize it in the pannel as you described you can use a magic method __str__(), like this:


Adding Types Declaration

fixes #28
Howdy, and Happy Thanksgiving! Hope you are well. Thank you for your work. I wanted to use this lib in a ts project and ended up writing the types for myself and saw you say in #28 that you'd take a PR for it, so here it is.
I nearly went the jsdoc route since that is very en vogue in 2023, in order to let typescript generate the type declarations automatically. However, that would have required touching more files. Since this is a very static lib, I instead went the minimalist route, only what is necessary to provide types. It pretty much matches the api doc section of the readme.
The only "creative license" I took was instead of having Point be strictly an alias for Vector, I declared Point to optionally be Vector | [number, number] | { x: number, y: number } to reflect the flexibility that you provide with your auto normalization via _normalizePoint(point). I then used this flexible point definition for all type 'inputs' from constructors and functions but used Vector's for all return values since there is no ambiguity there. It's not technically exactly the same as the underlying js since Point and Vector are identical in the js, but it's functionally pretty identical while maintaining the input type flexibility in a sane typescript way. Tested this in a personal TS project and it seems to work well.

Hi @GPeye,
thanks a lot for your work, this is amazing! I added some missing types and I will merge this one! Thanks a lot!


HDFS-16178. Make recursive rmdir in libhdfs++ cross platform

Description of PR

The TempDir class in libhdfs++ is currently
using nftw API provided by ftw.h, which is
only present in Linux and not on Windows.
This PR uses the remove_all API from C++17
std::filesystem to make this cross platform
in an equivalent manner.

How was this patch tested?
The API used here was tested with standalone
program -
https://github.com/GauthamBanasandra/x-platform/commit/87e68a626548aac87c4e0bdcff8a33d2d769dc69
For code changes:

[x] Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'HADOOP-17799. Your PR title ...')?
[ ] Object storage: have the integration tests been executed and the endpoint declared according to the connector-specific documentation?
[ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
[ ] If applicable, have you updated the LICENSE, LICENSE-binary, NOTICE-binary files?

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
83m 26s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  1s

codespell was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
47m  6s

trunk passed

+1 :green_heart:
compile
5m  1s

trunk passed

+1 :green_heart:
mvnsite
0m 34s

trunk passed

+1 :green_heart:
shadedclient
74m 15s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 16s

the patch passed

+1 :green_heart:
compile
4m 57s

the patch passed

+1 :green_heart:
cc
4m 57s

the patch passed

+1 :green_heart:
golang
4m 57s

the patch passed

+1 :green_heart:
javac
4m 57s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
mvnsite
0m 54s

the patch passed

+1 :green_heart:
shadedclient
23m 33s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

-1 :x:
unit
210m 44s
/patch-unit-hadoop-hdfs-project_hadoop-hdfs-native-client.txt
hadoop-hdfs-native-client in the patch failed.

+1 :green_heart:
asflicense
0m 38s

The patch does not generate ASF License warnings.

401m 29s

Reason
Tests

Failed CTEST tests
test_libhdfs_threaded_hdfspp_test_shim_static

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3311/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/3311

Optional Tests
dupname asflicense compile cc mvnsite javac unit codespell golang

uname
Linux 0518f36ad580 4.15.0-153-generic #160-Ubuntu SMP Thu Jul 29 06:54:29 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 93d8ed5c17d69e0b5324d840b9a863b35c0fcc75

Default Java
Red Hat, Inc.-1.8.0_302-b08

CTEST
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3311/1/artifact/out/patch-hadoop-hdfs-project_hadoop-hdfs-native-client-ctest.txt

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3311/1/testReport/

Max. process+thread count
596 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs-native-client U: hadoop-hdfs-project/hadoop-hdfs-native-client

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3311/1/console

versions
git=2.9.5 maven=3.6.3

Powered by
Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 56s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
34m  2s

trunk passed

+1 :green_heart:
compile
2m 34s

trunk passed

+1 :green_heart:
mvnsite
0m 23s

trunk passed

+1 :green_heart:
shadedclient
53m 13s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 15s

the patch passed

+1 :green_heart:
compile
2m 25s

the patch passed

+1 :green_heart:
cc
2m 25s

the patch passed

+1 :green_heart:
golang
2m 25s

the patch passed

+1 :green_heart:
javac
2m 25s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
mvnsite
0m 15s

the patch passed

+1 :green_heart:
shadedclient
16m  6s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
86m  4s

hadoop-hdfs-native-client in the patch passed.

+1 :green_heart:
asflicense
0m 30s

The patch does not generate ASF License warnings.

161m 50s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3311/2/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/3311

Optional Tests
dupname asflicense compile cc mvnsite javac unit codespell golang

uname
Linux b714f584b549 4.15.0-153-generic #160-Ubuntu SMP Thu Jul 29 06:54:29 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 0ae3c13ceb40b6e8af2e8012e00dd9bec53ff94e

Default Java
Red Hat, Inc.-1.8.0_302-b08

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3311/2/testReport/

Max. process+thread count
517 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs-native-client U: hadoop-hdfs-project/hadoop-hdfs-native-client

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3311/2/console

versions
git=2.9.5 maven=3.6.3

Powered by
Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
25m 34s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
23m 10s

trunk passed

+1 :green_heart:
compile
2m 45s

trunk passed

+1 :green_heart:
mvnsite
0m 35s

trunk passed

+1 :green_heart:
shadedclient
42m 47s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 19s

the patch passed

+1 :green_heart:
compile
2m 34s

the patch passed

+1 :green_heart:
cc
2m 34s

the patch passed

+1 :green_heart:
golang
2m 34s

the patch passed

+1 :green_heart:
javac
2m 34s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
mvnsite
0m 22s

the patch passed

+1 :green_heart:
shadedclient
15m 51s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
86m 45s

hadoop-hdfs-native-client in the patch passed.

+1 :green_heart:
asflicense
0m 38s

The patch does not generate ASF License warnings.

177m  1s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3311/2/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/3311

Optional Tests
dupname asflicense compile cc mvnsite javac unit codespell golang

uname
Linux 13a7f62566ec 4.15.0-153-generic #160-Ubuntu SMP Thu Jul 29 06:54:29 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 0ae3c13ceb40b6e8af2e8012e00dd9bec53ff94e

Default Java
Red Hat, Inc.-1.8.0_302-b08

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3311/2/testReport/

Max. process+thread count
516 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs-native-client U: hadoop-hdfs-project/hadoop-hdfs-native-client

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3311/2/console

versions
git=2.27.0 maven=3.6.3

Powered by
Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
15m  3s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
30m  3s

trunk passed

+1 :green_heart:
compile
2m 25s

trunk passed

+1 :green_heart:
mvnsite
0m 22s

trunk passed

+1 :green_heart:
shadedclient
53m 16s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 14s

the patch passed

+1 :green_heart:
compile
2m 19s

the patch passed

+1 :green_heart:
cc
2m 19s

the patch passed

+1 :green_heart:
golang
2m 19s

the patch passed

+1 :green_heart:
javac
2m 19s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
mvnsite
0m 15s

the patch passed

+1 :green_heart:
shadedclient
20m 15s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
90m 48s

hadoop-hdfs-native-client in the patch passed.

+1 :green_heart:
asflicense
0m 30s

The patch does not generate ASF License warnings.

184m 50s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3311/2/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/3311

Optional Tests
dupname asflicense compile cc mvnsite javac unit codespell golang

uname
Linux 6a46954d984e 4.15.0-153-generic #160-Ubuntu SMP Thu Jul 29 06:54:29 UTC 2021 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 0ae3c13ceb40b6e8af2e8012e00dd9bec53ff94e

Default Java
Debian-11.0.12+7-post-Debian-2

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3311/2/testReport/

Max. process+thread count
532 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs-native-client U: hadoop-hdfs-project/hadoop-hdfs-native-client

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3311/2/console

versions
git=2.32.0 maven=3.6.3

Powered by
Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
1m  0s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
23m  7s

trunk passed

+1 :green_heart:
compile
2m 54s

trunk passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
compile
2m 52s

trunk passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
mvnsite
0m 21s

trunk passed

+1 :green_heart:
shadedclient
45m  4s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 13s

the patch passed

+1 :green_heart:
compile
2m 41s

the patch passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
cc
2m 41s

the patch passed

+1 :green_heart:
golang
2m 41s

the patch passed

+1 :green_heart:
javac
2m 41s

the patch passed

+1 :green_heart:
compile
2m 48s

the patch passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
cc
2m 48s

the patch passed

+1 :green_heart:
golang
2m 48s

the patch passed

+1 :green_heart:
javac
2m 48s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
mvnsite
0m 16s

the patch passed

+1 :green_heart:
shadedclient
15m 58s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
86m 19s

hadoop-hdfs-native-client in the patch passed.

+1 :green_heart:
asflicense
0m 28s

The patch does not generate ASF License warnings.

156m 53s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3311/2/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/3311

Optional Tests
dupname asflicense compile cc mvnsite javac unit codespell golang

uname
Linux 7699f5deb741 4.15.0-153-generic #160-Ubuntu SMP Thu Jul 29 06:54:29 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 0ae3c13ceb40b6e8af2e8012e00dd9bec53ff94e

Default Java
Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3311/2/testReport/

Max. process+thread count
520 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs-native-client U: hadoop-hdfs-project/hadoop-hdfs-native-client

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3311/2/console

versions
git=2.25.1 maven=3.6.3

Powered by
Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.


Provide a public API to compare precedence groups

Description
I had a small use case in swift-format where I wanted to check the precedence of an operator relative to another one (https://github.com/apple/swift-format/pull/647).
Unfortunately there's no public API to do this from OperatorTable; the logic is inside PrecedenceGraph, which is internal. Can we have this API or something like it in public form?

Tracked in Apple’s issue tracker as rdar://116416740

I wouldn’t be opposed to adding a public function to perform this comparison on OperatorTable.

Thanks! It's not an urgent need but I'll tinker with it and put up a PR.


This plugin is still useful!

The latest v1.0.0 Obsidian update added the collapse all button natively, but it doesn't have the command in the command palette like this plugin!
The note in the README about the plugin being "no longer needed" isn't totally true because of this :p
I still find the command palette shortcut to be pretty handy.

Same for me, I sadly realised I no longer can attach a shortcut to the now native command. Is there any place where I could report that need for the official Obsidian app?

Is there any place where I could report that need for the official Obsidian app?

@beetrootpaul I think new features are requested here: https://forum.obsidian.md/c/feature-requests/8
I haven't requested it yet, so I guess you could go ahead and report it there.

@CabbageCanFly Thanks, here you go! 🙂 👉 https://forum.obsidian.md/t/add-hotkey-binding-for-explorers-collapse-all-action/45367

Same.
This Plugin is still useful. Obsidian has no native Hotkeys to Activate "Collapse All" or "Expand All" (as of 2023-08-02). Party On Wayne!

Thanks everyone. I'll work on an update to this plugin that allows it to work better with the internal collapse/expand to add a hot key, at least until the obsidian devs add one.

Done in #40, once released please update and check the plugin's settings. You'll probably need to rebind the hotkeys.


[Improvement] Unsafe memory management in RSS mappers

Code of Conduct

[X] I agree to follow this project's Code of Conduct

Search before asking

[X] I have searched in the issues and found no similar issues.

What would you like to be improved?
We can refer to https://github.com/uber/RemoteShuffleService/issues/59
How should we improve?
No response
Are you willing to submit PR?

[ ] Yes I am willing to submit a PR!

+1. I like this feature. If I have time, I will pick up this.


Deep Link to another app not working.

Hello,
The deep link provided in the adaptive card button is not working, which was working previously.
Adaptive card JSON for reference-
{
body: keyMessageDetails,
actions: [
{
type: "Action.OpenUrl",
title: "Link Testing",
url: "tact://assistant",
}
],
type: "AdaptiveCard",
version: "1.4",
msTeams: { width: "full" },
}

clicking on button received was redirecting to the external app, but now it is not doing anything.

@at-pi - To create a link to launch app in Teams, append the app ID to the following URL: https://teams.microsoft.com/l/app/<your-app-id>.
Could you please try in this way?

@Prasad-MSFT - as mentioned earlier I am trying to open an external app outside teams, I want to redirect to this external app by clicking on the deep link provided in the adaptive card. This was working with the sample code pasted on the thread, but now it has stopped working.

@at-pi - Could you please try to update your MS Teams app version and check if it helps?

@at-pi - Could you please try to update your MS Teams app version and check if it helps?

@Prasad-MSFT - I updated the app but the problem is still not resolved.

@at-pi - Thanks for the confirmation.
We will investigate on your issue and get back to you.

Seems like it is currently not supported. Here is the deep-link format as mentioned in official doc:
https://docs.microsoft.com/en-us/microsoftteams/platform/concepts/build-and-test/deep-links?tabs=teamsjs-v2#deep-linking-to-an-app

We are closing this issue for now. Please feel free to reopen if required. Thanks!


Consolidate inversion lemmas

Currently there's both formalization/inversion.v and formalization/ptt_inversion.v. We could have just one of them, preferably configuration-agnostic.

They are separated for historical reasons, ptt_inversion.v was used to prove sanity, and sanity was used in inversion.v. We need to investigate that as it might no longer be the case.

With the current version, we no longer feature both files. However, we lost all the previous inversion principles that were proved using sanity.


Rephrase RSC-005/016/017

because the previous phrasing was a bit misleading and had redundant apostrophes
RSC_005=Error while parsing file '%1$s'.

Example:
Error while parsing file 'element "package" incomplete; missing required element "spine"'.

The error didn’t appear in file '%1$s' but instead the variable was holding the error message which appeared when parsing the file. The filename however was never part of the message.
New phrasing should be clearer now:
RSC_005=Error while parsing file: %1$s

Example:
Error while parsing file: element "package" incomplete; missing required element "spine"

@rdeltour can you do a quick review soon as this blocks #650 rebase?
Otherwise I'm going to merge this as it's only rephrasing and nothing big...


Refactor Analyzer so that RuleSetProvider.instance is only called once

Background
I WTF'ed when debugging https://github.com/detekt/detekt/pull/3515. Also, my colleague @kkoser WTF'ed when working on a custom detekt rule.
Solution
The problem here is that we are not only calling RuleSetProvider.instance() twice for each rule, but the first time to generate IdMapping is even wrong because the top-level config instead of config.subConfig(it.ruleSetId) is passed to each ruleSet.
To fix this, I have refactored the code to share Sequence<> to make sure RuleSetProvider.instance().
(Technically, RuleSetProvider.instance() is called again in :detekt-output-sarif/RuleDescriptors.kt, but I am going to address this in #3554)

The problem here is that we are not only calling RuleSetProvider.instance() twice for each rule, but the first time to generate IdMapping is even wrong because the top-level config instead of config.subConfig(it.ruleSetId) is passed to each ruleSet.

Twice for each rule? We call it once per file and one more time when we instantiate the analyzer, right? And in this last one we don't care about the configuration because we just want to extract the ids. I imagine that this last part is not true for what you want to do with SARIF, right?
All those calls to RuleSetProvider.instance() are gone in the new analyzer. But the fact that you need to instantiate a rule just to get it's id is something that I don't like too much. Luckly the rules are light to instantiate and in the new analyzer they are instantiated just once.

Agreed.

All those calls to RuleSetProvider.instance() are gone in the new analyzer.
Could we push the new analyzer to a separate branch on master and start collaboration?

Twice for each rule? We call it once per file and one more time when we instantiate the analyzer, right? And in this last one we don't care about the configuration because we just want to extract the ids. I imagine that this last part is not true for what you want to do with SARIF, right?

To make sure the idea is communicated properly:

The first call is wrong https://github.com/detekt/detekt/pull/3555/files#diff-6149700bc8437bfd660774c9282c1051c9de2e5f7ea07711393cc17ca5944edeL38
The second call is correct https://github.com/detekt/detekt/pull/3555/files#diff-6149700bc8437bfd660774c9282c1051c9de2e5f7ea07711393cc17ca5944edeL109
The third call is inside SARIF report but that's out of the scope for this PR

@schalkms I am reverting this since this is for 1.17 release. We are probably waiting for Kotlin 1.4.32 so that we can release 1.16.1

@schalkms sorry again, my bad. Can you please reopen this changeset and tag it with a blocked label. Then we can prevent this things from happening in the future.


[change-resource] : grav-plugin-users-page-ownership

I would like to add my new plugin/theme to the Grav Repository._Here are the project details: Moonlight63/grav-plugin-users-page-ownership
This is an update/change to my previous plugin. I have removed the users management functionality since david-szabo97 has been doing a great job with his plugin, including getting group management to work. I have instead decided to simply expand on the idea of users 'owning' pages and admins being able to manage who can see and edit pages.
I renamed my old repo before I thought about it, because I wanted to change the name of the plugin. That's why this is under 'change-resource.' The original repo was under grav-plugin-advanced-admin-users-managment, which is now gone. I apologize if that was a mistake.

This has been done.


Error after update AMP plugin / amp toolbox composer dependency

Bug Description
While testing another PR #7292, I updated AMP Plugin and AMP toolkit. After doing this, I started getting error in unit test.
I locked the commit down composer file to https://github.com/ampproject/amp-toolbox-php/commit/8e1dfacf4f4df8835c6a9ed1d3be8b4a7bf7b92e and https://github.com/ampproject/amp-wp/commit/1bac57aba4e3b58351381b4967ab6ee9b9b00aa6 that this seem to fix this issue.
Expected Behaviour

Steps to Reproduce

Screenshots
Error in PHPUnit

After commenting out the line above.

Additional Context

Plugin Version:
WordPress Version:
Operating System:
Browser:

Do not alter or remove anything below. The following sections will be managed by moderators only.
Acceptance Criteria

Implementation Brief

CC @westonruter @schlessera for visibility

You updated the AMP plugin from what version to what version? If AMP__VERSION is not defined, then the amp.php file wasn't included.

I noted the shas above, anything passed that commits, as this issue.

I noted the shas above, anything passed that commits, as this issue.

But what was the version you were on before?

These are the shas that were in the lock file.

ampproject/amp-toolbox-php@8e1dfac and ampproject/amp-wp@1bac57a

Which is why I locked down to them.


PlaneFinding.dll is missing for Plugins\WSA\x64

Under Assets\HoloToolkit\SpatialMapping, there are two versions of PlaneFinding.dll for x86 (one in Plugins\WSA\x86 and the other in Plugins\x86.) There is, however, only one version of PlaneFinding.dll for x64, found in Plugins\x64.
I think this causes the VisualStudio side of the build to fail because it can't find the dll it is looking for.

Could not copy the file "D:\Project\App\Project\Plugins\x64\PlaneFinding.dll" because it was not found.

I'm pretty sure that x64 is unsupported on HoloLens

Which scene are you building for?

Related to https://github.com/Microsoft/MixedRealityToolkit-Unity/issues/746

Closed By https://github.com/Microsoft/MixedRealityToolkit-Unity/commit/dc4375db8643632565fa21c4d21893d7f098a98d