Could you please keep OpenUtau Linux compatible?

Our userbase isn't that small, and I'm not a programmer, but from what I've seen, it's easier to port a program from Linux to Windows, than from Windows to Linux.

Hello,
From what I see, the code of OpenUtau is heavily based on the .NET Framework, which is not GNU/Linux compatible. Maybe some elements might be supported by the Mono Framework, but it is unlikely that the whole project is. And this issue is deeply rooted in this project due to the language used: C#. Had it been C++ or Java, it would have been “easier” to change the UI framework (it would still be very complex to do so), but there is close to no alternative for GNU/Linux and OS X/macOS when using the .NET Framework.
So, unless a brave programmer decides to convert all of the code to another language and port the UI to a cross-platform framework (such as C++ with Qt or Java with its own framework for instance), it is very unlikely to see OpenUTAU running on GNU/Linux, except maybe with wine (but there is not way of knowing if this will indeed work).
And if anyone could prove me wrong, I’d be damn glad to hear that.
Also, I would like to see OpenUtau running on GNU/Linux, but let’s be real for a moment: only about 2% on June 2017 of desktop and laptop users use GNU/Linux, and a good share of them dual-boot GNU/Linux with either Windows (84% on June 2017) or macOS (12% on June 2017). If any platform needs to be supported first after Windows it would be first OS X/macOS, then GNU/Linux.
I hope that answered your question.
(also side note: I’m currently looking at the code and discovering how it works and I’ll see if I might be able to help, I’m not really well versed in C#)

Sorry, it's heavily based on WPF technology, therefore not Linux compatible from the very beginning.

I was reading the framework and how to make it compatible, is framework 45, in monodevelop project has some part of the compatible
http://www.mono-project.com/docs/about-mono/compatibility/
"
C# 5.0 - async support
Async Base Class Library Upgrade
MVC4 - Partial, no async features supported.
MVC5 - Partial, no async features supported.
ASP.NET 4.5 Async Pipeline - Needs a parallel processing pipeline with async support, not done.
"
there are stuff i do not know, like if openutau use pipeline, there fore not compatible with monoproject who is make not easy to porting.  also if some of the partly features are used. when i try to run in monodevelop, it didn't run, saying "Not in the list of compatible projects"
Maybe need to debug a lot more, or a little more. Therefore there is much I don't know, but thats my two penny's.


Please create a .jar file, including your license, for distribution

Is your feature request related to a problem? Please describe.
OpenRocket (https://github.com/openrocket/openrocket) has begun using your library, and we would like to properly cite your license.  At the moment we're just linking to the license here on your project page; we'd also like to link to a copy embedded in your .jar
Describe the solution you'd like
As in the title:  we'd very much appreciate if you could distribute a .jar with your license file, preferably at the top level.
Describe alternatives you've considered
We spent a little while trying to add it in ourselves, but eventually concluded simply having your library distributed with this would be of benefit both to us and to your other users.
Additional context
Add any other context about the feature request here.

OpenRocket (https://github.com/openrocket/openrocket) has begun using your library

Cool project!
Yeah I agree that would be nice, just need to figure out the correct maven magic to do that. Help would be appreciated.

See PR: https://github.com/commonmark/commonmark-java/issues/253

Ok, released 0.18.2 with the fix for this: https://github.com/commonmark/commonmark-java/blob/main/CHANGELOG.md#0182---2022-02-24
It should show up on Maven Central shortly.

Thank you!


Update minimum version of dask

Xarray currently states that it supports dask version 0.9 and later. However, 1) I don't think this is true and my quick test shows that some of our tests fail using dask 0.9, and 2) we have a growing number of tests that are being skipped for older dask versions:
$ grep -irn "dask.__version__" xarray/tests/*py
xarray/tests/__init__.py:90:    if LooseVersion(dask.__version__) < '0.18':
xarray/tests/test_computation.py:755:        if LooseVersion(dask.__version__) < LooseVersion('0.17.3'):
xarray/tests/test_computation.py:841:    if not use_dask or LooseVersion(dask.__version__) > LooseVersion('0.17.4'):
xarray/tests/test_dask.py:211:    @pytest.mark.skipif(LooseVersion(dask.__version__) <= '0.15.4',
xarray/tests/test_dask.py:223:    @pytest.mark.skipif(LooseVersion(dask.__version__) <= '0.15.4',
xarray/tests/test_dask.py:284:    @pytest.mark.skipif(LooseVersion(dask.__version__) <= '0.15.4',
xarray/tests/test_dask.py:296:    @pytest.mark.skipif(LooseVersion(dask.__version__) <= '0.15.4',
xarray/tests/test_dask.py:387:        if LooseVersion(dask.__version__) == LooseVersion('0.15.3'):
xarray/tests/test_dask.py:784:    pytest.mark.skipif(LooseVersion(dask.__version__) <= '0.15.4',
xarray/tests/test_dask.py:802:    pytest.mark.skipif(LooseVersion(dask.__version__) <= '0.15.4',
xarray/tests/test_dask.py:818:@pytest.mark.skipif(LooseVersion(dask.__version__) <= '0.15.4',
xarray/tests/test_variable.py:1664:        if LooseVersion(dask.__version__) <= LooseVersion('0.15.1'):
xarray/tests/test_variable.py:1670:        if LooseVersion(dask.__version__) <= LooseVersion('0.15.1'):

I'd like to see xarray bump the minimum version number of dask to something around 0.15.4 (Oct. 2017) or 0.16 (Nov. 2017).
cc @mrocklin, @pydata/xarray

DataArray.dot() is using dask.einsum, and it only woks with dask >= 0.17.5 (#2089).
Does this requirement sound is too strict? If so, we maybe better to add another pass for older dask.

We have traditionally allowed for a fairly large lag in version dependencies so I'd guess that 0.17.5 (May 16, 2018) is too recent. That said, I'm in favor of shrinking that window to facilitate faster integration of new features.

Requiring 0.15.4 seems reasonable to me. There is virtue in supporting a (small) range of versions in dependency. But clearly 0.9 was too out of date here.
We should probably add a CI test against the oldest version of dask that we support, just to make sure things don't sneak through.

How do we consider the minimum version of optional dependency?
If we say "the minimum version of dask is 0.16", then all our dask related functions should work with dask=0.16?
or do we allow functions that only work with newer version of dask if we raise an appropriate error message?

The policy I've tried to keep to is keeping everything working with base
supported version, but we can add new features that rely on new dask
features.
On Wed, May 30, 2018 at 8:20 PM Keisuke Fujii<EMAIL_ADDRESS>wrote:

How do we consider the minimum version of optional dependency?
If we say "the minimum version of dask is 0.16", then all our dask related
functions should work with dask=0.16?
or do we allow functions that only work with newer version of dask if we
raise an appropriate error message?
—
You are receiving this because you are on a team that was mentioned.
Reply to this email directly, view it on GitHub
https://github.com/pydata/xarray/issues/2203#issuecomment-393389052, or mute
the thread
https://github.com/notifications/unsubscribe-auth/ABKS1uTxKa_GJxvqVj2H2LvL-IYTOCWPks5t32FugaJpZM4UT_GD
.


FEATURE - Add force release for channels

Description
This PR adds a force flag to the sparkswap wallet release command that allows the user to force close all channels that are open w/ the exchange.
The Broker may run into an issue where it has open channels with the relayer, however the relayer may be down or offline. We want the broker to be able to close those channels HOWEVER the only way possible is by forcing the closing of the channel through the engines.
if the call to sparkswap wallet release fails, we will prompt the user to the user the --force flag if they understand that force releasing could take an extended amount of time AND this may add additional fees to the closing tx of the channel.
Related PRs
List related PRs if applicable
Todos

[ ] Tests
[ ] Documentation
[ ] Link to Trello

 Add force option to smart release


Instrumentation for bigtable client

I see there is already an issue for bigtable instrumentation for google cloud trace in https://github.com/GoogleCloudPlatform/gcloud-golang/issues/150 but it would also be great to have a general way to instrument the client for request metrics. Currently, I am doing this by adding instrumentation code around each call to the client but it's brittle and requires several lines of metrics-related code everywhere a bigtable request is sent. If there was a way to do this with grpc client options that could also work but I'm not aware of any way to do that currently.
I know bigtable already publishes trace information to /debug/requests using the net/trace package but not everyone uses that and there are no tools available to consume and aggregate trace data.

Now that gRPC has client-side interceptors, you can implement some basic metrics using something like this as an example:
https://github.com/grpc-ecosystem/go-grpc-prometheus

Also see: https://cloudplatform.googleblog.com/2017/04/distributed-tracing-for-Go.html


Can the shape of convolutional kernels be designed by users themselves ？

Can the shape of convolutional kernels be designed by users themselves ？

Yes. Just specify the kernel shape (e.g., kernel_size = (1,3,3)) when defining the conv layer.


css minifier has changed the signature

csso.minify is not a valid call anymore, it returns an object.

Fixed in: c989833915c63af412405864e7561fc70c37d82c


(BKR-1137) Require hosts flag with init subcommand

Refer to this link for build results (access rights to CI server needed):
http://jenkins-beaker.delivery.puppetlabs.net//job/qe_beaker_btc-intn/3873/

test this please

Refer to this link for build results (access rights to CI server needed):
http://jenkins-beaker.delivery.puppetlabs.net//job/qe_beaker_btc-intn/3876/

LGTM!


Disabled Gateways Show In Gateway Widget

I noticed the other day when I disabled a gateway it still appears in the gateway widget.  It will show 0.0ms 0.0% and as online.

more info: gif + dynamic, this doesn't happen with "normal" gateways

@fichtner I think this happens with all "dynamic" types, the very obscure return_gateways_array() looks responsible.
Take a look here for example https://github.com/opnsense/core/blob/master/src/etc/inc/gwlb.inc#L634-L667 this seem to add the just disabled gateway again. We should probably refactor this into something readable..... there doesn't seem to be an easy fix.

related to https://github.com/opnsense/core/issues/957

125808e addresses the remaining problems described in this ticket. I'm not entirely sure that this will backported to 16.1 with 16.7 just around the corner, but it is worth mentioning. :)


Improve memo and Any message documentation

The changes here look good, but I'll think about whether I could come up with any solution to the issue with stargate

@mergify backport release/2.0


Feature Request: routerLink property for NgxGalleryImage

Hi again;
I've just had this idea: I think it would be a good addition to have a routerLink  property in NgxGalleryImage type, so that when clicked, instead of requesting/defining in code a full URL, we can just define relative path.

Going to bump this one up as I would love this feature. Any news about this one? Because it would create a more fluent user experience.
Unless I missed something, because upon navigating the SPA reloads because it's routing via the browser instead via the application.

+1, would've been really awesome!


error: cannot find symbol variable PostInteractor

import youpackagename.main.interactors.PostInteractor;

Hi, @platypus36 !
Try to update imports with your package name.

@Batishev-Rozdoum  and @mahireid ur explanations on this is not clear. You both said "update imports with your package name." There are several embeded files in this repo. So where do we start from?

Hi @tobimichigan! here is Post Interactor file.
Actually, when you change the package in you project,  all files in src folder should should be updated with new package name and import of all the files should be updated too.

@Batishev-Rozdoum I will recheck and give you feedback shortly.

I added this line
import com.rozdoum.socialcomponents.main.interactors.PostInteractor; to Application.java and it's building fine.

Hi, @platypus36 !
Try to update imports with your package name.

How can I update imports with my package name?


Document space mini header

See https://github.com/huggingface/moon-landing/pull/8753

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.


Make sure we don't run post_run & pre_run during diff

pretty straight forward... diff is a subclass of build which means by default it was running the hooks.

Thanks!  Honestly at some point we should probably make a common master class for Build and Diff, rather than setting the precident we do here, since dangerous things like this could potentially be the result.  For now though, this should work.


fog driver not working for alternative ec2_endpoint

I've set up a very simple test project to demonstrate this problem. It can be found at:
https://github.com/nextcode-health/qstack-chef-provisioning
I'm trying to point the fog:AWS driver to an ec2_endpoint for our local cloud cluster which is set up with QStack (https://qstack.com/) which has an EC2 compatable API. I've verified that aws-cli works against QStack so it should work with Fog as well.
However, when I point it towards our QStack EC2 endpoint I get the following error:
    Fog::AWS::IAM::Error
    --------------------
    InvalidClientTokenId => The security token included in the request is invalid.

I've investigated this a bit and it looks like Fog is still talking to the AWS IAM endpoint even though I've set the ec2_endpoint to the QStack location. I don't think QStack implements IAM though but as I said, it the aws-cli tool works fine so they are obviously authenticating users somehow.
So I'm not quite sure how this can be solved. Can the Fog driver be instructed to not use IAM? Or is IAM the only way to authenticat against EC2 (meaning that there must be a IAM endpoint in our QStack somewhere, I just haven't found it).

You can see it in the project I linked to but the way I'm setting up the driver is below:
# The qstack in the below driver name refers to the profile name in ~/.aws/credentials
with_driver('fog:AWS:qstack', :compute_options => {
    :ec2_endpoint => 'http://c.qstack.nextcode.local',
    #:iam_endpoint => 'http://c.qstack.nextcode.local'
})

I got some help with this from GreenQloud personnel and they figured out what was wrong and a workaround.
Basically, chef-provisioning-fog doesn't provide any way for you to skip the IAM service request.
Below is a very ugly workaround but the fog driver should make the IAM service optional.
require 'chef/provisioning/fog_driver/driver'

server = WEBrick::HTTPServer.new :Port => 8123
trap 'INT' do server.shutdown end
server.mount_proc '/' do |req, res|
    res.body = '''
      <GetUserResponse xmlns="https://iam.amazonaws.com/doc/2010-05-08/">
        <GetUserResult>
          <User>
            <UserId>AIDACKCEVSQ6C2EXAMPLE</UserId>
            <Path>/division_abc/subdivision_xyz/</Path>
            <UserName>Bob</UserName>
            <Arn>arn:aws:iam::123456789012:user/division_abc/subdivision_xyz/Bob</Arn>
            <CreateDate>2013-10-02T17:01:44Z</CreateDate>
            <PasswordLastUsed>2014-10-10T14:37:51Z</PasswordLastUsed>
          </User>
        </GetUserResult>
        <ResponseMetadata>
          <RequestId>7a62c49f-347e-4fc4-9331-6e8eEXAMPLE</RequestId>
        </ResponseMetadata>
      </GetUserResponse>
    '''
end
Thread.new { server.start }

# The qstack in the below driver name refers to the profile name in ~/.aws/credentials
with_driver('fog:AWS:qstack', :compute_options => {
  :endpoint => '...',
  :iam_endpoint => 'http://localhost:8123',
})

I'm going to close this out at this point since we removed support for fog-aws and instead suggest that users use fog-provisioning-aws which uses the native aws-sdk and resolves a large number of longstanding AWS issues.


Bug: TextWidget is unusable

When activating the TextWidget under measurements, the widget "freezes" in the middle of the screen and there are a bunch of errors thrown saying "this.widgetmanager is undefined" or "this.openGLRenderWindow is undefined".

Was fixed by #455


Package brings some weird behaviour with my own package

Hi,
I'm developing an Atom Plugin which does a lot of things and makes some panels (right, bottom, top), and with your theme, some simple actions as stopping a process don't work as expected (the process becomes zombi) even if it works with One Dark. It's very very weird, and I really don't know how to help you with this, but I have to go back to One Dark :/ (even if I prefer Reduce-ui).
Thank you

Hi, I'm not really surprised that there are collisions with other functionality since this project got a bit out of hands in its magnitude :)
But anyway, It has been a great pleasure for me to talk with you, and thank you a thousand times for the massive amount of feedback you've provided!
I hope you won't give up all hope just yet - maybe try again when this theme has matured a bit? :) Ps. if it's okay with you, I'd very much like to see if I can find the source for these problems of yours - it surely would help prevent other similar problems! Do you have a public repo for the project?
I'll be cleaning stuff up as well as deprecating parts completely, now that I have the actual structuring for the project figured out.

Don't worry I don't give up that easy ;) my project is on alanzanattadev/atom-molecule-dev-environment, but the project doesn't use css for now (soon) but inline style, leading to a theme not compatible with atom theme variables. Still usable with reduced (except input with white background) but not with its panel funky behaviour haha. I'll come back when everything will be fixed :)


meteor update just gave me<EMAIL_ADDRESS>but there's no tag in the repo

If 0.10.0 was released, shouldn't it have been tagged?
Thanks,
S

yes! you're right

next version will be tagged. apologies :)


Webpack: add/build RTI target

I'm excited to introduce RuntimeTypeInspector.js, which I believe will benefit Transformers.js as a whole and our debugging workflows in specific. RTI is designed to type-check the arguments of every function and method. It detects type errors while the engine is running in a way that goes beyond the capabilities of TypeScript, as demonstrated in this video (there is another one on the website debugging the Microsoft Holometric Video PC project).
During the development of RTI it already helped me to understand and fix things, for example various JSDoc types and this NaN bug: https://github.com/xenova/transformers.js/issues/390
I believe that RTI will help improve productivity and efficiency, by catching errors early on and reporting them in detail.
Runtime Type Inspector is implemented using Babel AST traversal with custom JSDoc parsing (powered by TypeScript itself for highest compatibility).
TLDR: It adds type assertions for runtime type checking, for example:

Being able to set breakpoints exactly where the errors are happening for the first time helps to track down problems that are otherwise difficult to pinpoint (and saves a lot of time :sweat_smile:).
Try for yourself: https://pc.runtimetypeinspector.org/#/animation/blend-trees-2d-cartesian
Just make sure to pick the right JS context - the exampleIframe:

I'm working on this for quite some time by now, a mix of fun and frustration - rewriting code on the AST level first seemed tricky, but given enough time, it was a rather straightforward way to automate type validations. I'm excited to read feedback and suggestions. :pray:

I wanted the examples to be build-free while also being able to use RTI type checking on each of them. Because that was quite a challenge in the beginning, I decided to make a custom repo for it: https://github.com/kungfooman/transformers-examples.js
The first main challenge was loading a worker containing ESM code depending on import map resolution... I found some brittle solutions, but ended up making my own NPM package for it: https://github.com/kungfooman/worker-with-import-map/
Still working on some examples and making everything easier to use, but most of them already work build-free and with RTI :see_no_evil:


Publishing error

Hi Andy @lambtron
First, thanks for creating this very useful app. Like you , I wish if I could publish Medium from CLI
I installed it thru npm and looks every thing is working fine except for the publishing .. here is a complete view of what I did .. Please advise if I am missing anything
`bash-4.3$ pwd
/home/ajain/buzzfeed
bash-4.3$ medium login
medium Â· Please open https://medium.com/me/settings in your browser.
Â· At the bottom of the page, under Integration Tokens, copy
Â· this description:
     Â· "Medium-CLI basic publishing access."

     Â· Then generate the new token and copy it.

Paste your Integration Token here:
#####################################################################
     Â· Authenticating into Medium..

     Â· Saved!

bash-4.3$ medium publish
(node:19796) UnhandledPromiseRejectionWarning: Unhandled promise rejection (rejection id: 1): TypeError: Cannot read property 'split' of undefined
bash-4.3$ ls
articles
bash-4.3$ cd articles/
bash-4.3$ ls
test-post-from-medium-cli
bash-4.3$ cd test-post-from-medium-cli/
bash-4.3$ ls
index.md
bash-4.3$ cat index.md
title: test post from medium command line interface
tags:
canonicalUrl:
publishStatus: draft
license: all-rights-reserved
Testing a post from medium command line interface
bash-4.3$ `

btw - all the other three commands are working fine  ..

Me too.  Medium publish command didn't work at all and no related information founded.

Thanks for sharing. Let me see what might be the issue.

Hmm this works for me.
What OS are you using? And node/npm version?
Thanks!

Mac OSX el capitan
Node version is the latest.
However,  I've turned to my personal blogger using Hugo.
Thanks again for your asking.
On Fri, May 12, 2017 at 11:04 AM, Andy Jiang<EMAIL_ADDRESS>wrote:

Hmm this works for me.
What OS are you using? And node/npm version?
Thanks!
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/lambtron/medium-cli/issues/4#issuecomment-301146164,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABlYld4_3pnu4n9EzHnm7RuBAwqTITi1ks5r5J9GgaJpZM4L7zIr
.

--
Jun Xiong, Ph.D.
U.S. Geological Survey
2255 North Gemini Drive,
Flagstaff, AZ, USA.
Office:<PHONE_NUMBER>


Support for optional arguments in blocks

It's finally happening!
The purpose of this PR is to surface optional arguments in TS functions up to the blocks. You can do it like this:
/**
 * A test api
 */
//% weight=99 inlineInputMode="inline"
//% blockId=whatever block="normal args %str %ang || optional args %opt %enu"
export function whatever(str: string, ang: number, opt?: boolean, enu?: Direction) {
}

The double pipe (||) is used to specify where the optional arguments begin. All arguments after that will be hidden by default and can be revealed using the + and - buttons at the end of the block.
As part of this change, I had to redo the block parser and it is now new-and-improved! Changes include:

You no longer need to use | to separate parameters
Support for the markdown bold and italics syntax. I think this is technically a breaking change because we were supporting the wrong syntax before (single asterisk for bold instead of double asterisk). You can even nest styles if you're crazy.
Support for adding arbitrary CSS classes to text! I copied the markdown link syntax for this (e.g. [some text](aClassName))
Very rudimentary escape sequences! I currently do not support any of the special escapes (like newlines), unicode escapes (\uXXXX), or latin-1 escapes (\xXX). Really it's only useful for escaping the characters that have special meanings in the block string (like |)

Things that still need to be done:

Proper escape sequence parsing. This could end up being pretty useful in combination with the CSS class feature to do things like embed font icons in blocks
Add docs for all of this
Better errors for bad block definitions in the console

I'm putting "DO NOT MERGE" on this because I still need to do some tests to make sure everything is backwards compatible.

@mmoskal test

I'm going to redo this PR


test: don't close CRT fd handed off to uv_pipe_t

After 4ed29c2498408c99079f25bfc0c6aec5bfbf42c4 got fixed, when a CRT fd
is handed off to a pipe handle using uv_pipe_open libuv will close it
properly, so it's an error to do so ourselves.
CI: https://ci.nodejs.org/view/libuv/job/libuv-test-commit-windows/126/

/cc @libuv/collaborators

LGTM


Undo/ Redo & Macro Recording

🚀 Feature
For a while in napari we've discussed that we want undo/ redo functionality, a nice history feature, and the ability to do some sort of macro recording / action recording that can yield runnable python scripts, but we havn't got too many issues describing what these exactly should look like.
We created this issue #474 a while ago that described one approach for making actions undoable, but there are alternatives we should discuss too.
One thing that we should align on first is what actions are undoable / recordable. Even there, I can see slightly different needs where e a user wants undo on anything that changes any state while they are using the GUI, but we might only want to record the actions that are more associated with image analysis.
Another question is if the only things that are undoable/ recordable are "actions" that we have defined, or if any API change to our models should be undoable/ recordable.
I.e. if someone goes to the drop down menu and changes the colormap from "red" to "blue", should that be undoable? What if someone does layer.colormap = "blue" in the console?
If one "action" causes many attribute changes are they all undoable individually, or do they get batched into one "action"?
One idea that I like that I think @tlambert03 proposed is to think of a having an event listener that listens to all the events emitted by our core models - that is viewer, dims, the layers etc (i.e. NOT the qt/ GUI code), and records them.
Undo/ redo now becomes about recording the state transition that happened so "red" to "blue" for the colormap change. Once we have our new evented models everywhere this could be done easily as each event can be given an old_value in addition to the new_value.
This approach will work well for all our strings/ small objects, but it might lead to a memory explosion for our data properties which can be large arrays. There we might need to be more clever.
Note that this approach is a little different than the action recorder approach, it's more centered on listening to events from our model code and tracking changes to the model.
Curious how others feel about this? Note I see this as the beginning of a discussion, not a concrete proposal at this point in time. cc @tlambert03 @jni @Carreau @goanpeca @ppwadhwa @justinelarsen

I like Talley's proposal — I think it works with almost everything, except data. We probably have to handle data separately anyway, since for things like painting you don't want to copy over the whole data but rather only what was painted. But handling two things is a lot easier than handling a hundred. 😅

I like Talley's proposal —

@jni what do you mean by this? Where is that proposal 🙃 ?

Thanks for starting a discussion around this topic @sofroniewn !
I think a general rule for what actions to make undoable could be any action that alters the state of the main canvas. In Illustrator, it looks like they follow this method where adding/removing objects, changing object properties like color, size, scale, etc and even visibility of objects on the canvas are undoable. But actions like changing tool types, zooming or even selecting objects are not undoable.
For the data, maybe we could keep a history of just the differences instead of a copy of the entire data every time there is a change?

I can start looking at this and have the event listener record changes if enabled as @tlambert03 proposed.

one thing that we briefly discussed is the likelihood that those events are going to be terribly verbose at first.  So this venture will A) be a good opportunity to identify some "problem areas" where we're being overly cavalier with our event emission and B) probably require a lot of "manual" selection and de-duplication of the events that actually mean something from the perspective of a user action...

events are going to be terribly verbose at first

It might I have noticed events being triggered multiple times which is invisible to the user... but might be problematic for this.

A) be a good opportunity to identify some "problem areas"

Indeed :)

B) probably require a lot of "manual" selection and de-duplication of the events

Sounds like fun. Are there "complex" event that the UI exposes as a single thing, but under the hood several things happen at once or sequentially? This would require having a concept of a single action vs a complex action (which groups several single actions)
Just wondering about things...

I'm probably most worried now about de-duplication of the events due to poor code paths causing things to happen multiple times which we should fix.

This would require having a concept of a single action vs a complex action (which groups several single actions), so the undo/redo takes this into account.

We could also group things temporally - so if something happens within a couple milliseconds of each other it is likely the same user triggered action. Having timestamps for events like that could help grouping, but I don't know - that's just an idea

Adding a note here for undo to include undo for deleting layers - see request https://forum.image.sc/t/missing-features/41518/6?u=sofroniewn


 Remove it to reduce total code footprint that has to be maintained.

So you are killing Christmas ;-)

Mostly gone as of #24


Added navi.vim.

Integrates Navi with Vim.

Closing since the file is accidentally not in the last revision.


AstraDB component Ingest all items twice

As I run the flow to ingest data, it does it twice. So each item is captured twice in the AstraDB data collection.
Browser and Version

Langflow version 1.0.6 running on local a virtual environment

To Reproduce

use the pre-built flow 'Vector Store RAG'
use the existing flow to ingest any content

Does anyone that experience the same?

Hey @thomasbachet thanks for reporting. Yes it's a bug. I've fixed it in this PR #2573
Meanwhile you could replace the entire astradb component with this content: https://raw.githubusercontent.com/langflow-ai/langflow/98beda5532b9029e016d966cfc81bca1722d4c5c/src/backend/base/langflow/components/vectorstores/AstraDB.py


add armhf binary

seems like armhf isn't in stable or unstable repositories.

Is there instructions to make the deb package? I could need a armhf deb package but dont know how to compile and package it

Currently there is no support for the apt plugin on ARM environments and no timeline for completion. We'll discuss with the team and provide an ETA once it gets prioritized.


added code for assignment-1

What changes are you trying to make? (e.g. Adding or removing code, refactoring existing code, adding reports)
Added code for assignment -1
What did you learn from the changes you have made?
I've learnt the workings of graph data structures and methods to traverse them
Was there another approach you were thinking about making? If so, what approach(es) were you thinking of?
we could use an iterative approach over recursive.
Were there any challenges? If so, what issue(s) did you face? How did you overcome it?
estimating the space and time complexity for the recursive function was difficult
How were these changes tested?
A reference to a related issue in your repository (if applicable)
Checklist

[X] I can confirm that my changes are working as intended

A1 marked complete


fix: allow opening interpretations for AOs without a time dimension

Implements DHIS2-15781
Requires https://github.com/dhis2/analytics/pull/1571

Key features

Allow opening interpretations for AOs without a time dimension

Description
When opening a visualization in the interpretations modal, we pass a relativePeriodDate to ensure we are only showing data that was avaiable when the interpretation was created. However, some visualizations do not include a time dimension and for these visualizations adding the relativePeriodDate parameter does not make sense and sometimes also casues an error.
So this PR adds a isAoWithTimeDimension function which can be used to check if the visualization (AO object) includes a valid time dimension and only adds the relativePeriodDate param if that functions returns true.
I'd say the thinking behind this makes sense, but I am not at all sure if isAoWithTimeDimension is correctly catching all visualizations with a valid time dimension. When I was testing things locally the issue seemed solved, but I have no idea if the logic behind it is sound and/or complete....

Consideration
After creating this PR something occurred to me which might make us want to close this PR and turn this into a backend issue:

As I understand it, the whole point of providing the relativePeriodDate parameter is that the visualization does not include any data which was added after the interpretation was written, so that the user reading the interpretation is looking at exactly the same thing as the person who wrote it.
The fix I have produced here omits the relativePeriodDate parameter, and the consequence of this is that the person reading the interpretation at a later date may be looking at something quite different than the person who originally wrote the interpretation. So while my fix "solves" the issue from a technical perspective (no error response, and data is being displayed), it comes with some considerable disadvantages as well.
And assuming a data-point also has a created-at/updated-at field in the DB, it seems that this issue can simply be addressed by excluding data which was created (or perhaps updated?) after the relativePeriodDate. This seems like a better solution to me, and this would make it a backend issue.

Decision
@janhenrikoverland, @cooper-joe & @maikelarabori discussed the consideration above and it was decided that we would stick with the current implementation with the addition of some warning messages. We show one when writing the interpretation and one when viewing one. The addition of this warning when writing the interpretation had to be done in the analytics repo.

Screenshots
Will be added once the analytics lib is updated and all messages can be displayed

To test:

I have created an environment which includes both the changes from this PR as well as the related changes in analytics
Here's a link to a line list with a time dimension, which shouldn't show the warnings:
And here's one without a time dimension, which should show the warnings.
Warnings are in two places:

Below the rich text editor when creating the interpretation
Above the visualization in the interpretations modal

Closing in favour of https://github.com/dhis2/line-listing-app/pull/447


Load trajectories from string.

Loading trajectories from strings is useful for building a desktop app to test and plot the trajectories generated by PathPlanner (bypassing the RoboRIO-specific deploy directory code and avoiding the need to mock it). These changes allow this to happen, while keeping the existing method for loading paths on a RoboRIO.
These changes were instrumental to identifying the issues in the trajectory generation (from https://github.com/mjansen4857/pathplannerlib/pull/3) and correcting them. As in the other pull request, the Java version has been tested and the C++ version should work but it untested (other than knowing that it builds).

I was able to put together a program to test these changes in the C++ version and they work.


Blank screen after fresh install via docker

Describe your problem
When accessing Bludit after finishing the installation (clicking the Install button below the admin password), the page will go blank. No errors with be logged in docker.
I get the same results on a server that has been running bludit 3.4 (unable to update) and on fresh laptop / desktop
Expected behavior
Something shows up
Actual behavior
Completely empty response from server
Steps to reproduce the problem
docker run --name bludit \
    -p 8000:80 \
    -v bludit:/usr/share/nginx/html/bl-content \
    -d bludit/docker:latest

Bludit version
3.8.1

Hi,
do you have the directory bludit ?
Before the command you paste, have you create the directory ?
Can you create a new directory and check the logs menwhile you are installing, the following steps.
mkdir ~/bluditx

docker run --name bluditx -p 8000:80 -v ~/bluditx:/usr/share/nginx/html/bl-content -d bludit/docker:latest

docker logs -f bluditx

Then go to the browser localhost:8000 and do the installation and check the logs.

If I pass the folder to it, it will complain that it has no write permissions (which makes sense, as it runs under a certain non-root user)
Chmod 777'ng the folder will make the install able to continue, but will fail
The issue also exists when I don't pass the folder from the host, just running the container alone.

Strange behavior because if you run the docker without the volume, Docker create a filesystem directory for that docker.
docker run --name bluditx -p 8000:80 -d bludit/docker:latest

Can you paste the logs ? and what version of Docker are you using ?

Have everything logged here:
https://hastebin.com/xuzojuyifo.sql

There was a few problem in the image tag latest because was downloading a wrong version.
I create a new Dockerfile with PHP 7.2 and Bludit v3.8.1, also I enabled the debug mode TRACE by default.
Can you try with the latest tag ? just in case delete the image from your system.
docker rmi bludit/docker:latest
docker run --name bludit -p 8000:80 -d bludit/docker:latest

The latest tag worked now! Both new install and our previous blog are back up and running.
I also confirm I had to remove existing containers and docker system prune -a... that whole deal.
Now getting a lot of php debug spam on log as expected, but the web is working perfectly.
Thanks a lot!

Good, I will improve the logs.
You can also delete this line https://github.com/bludit/docker/blob/master/Dockerfile#L60 and build the docker for you self.


No scroll bar in Firefox

I know Firefox is not currently supported, but it actually works great with the exception of one relatively major feature:
Using Firefox 77.0.1, there are no scroll bars in chat windows. This concerns the small 'Facebook-style' pop-up chat windows as well as the big, right-column chat bar. Even in the absence of scroll bars, scrolling in these regions is impossible. I cannot use my mouse or do the old trick of marking text and dragging it.
There are scroll bars in the left "status" bar column, so I am hoping this would be an easy fix.
Thanks for looking into this once you find time. It is not urgent for me.

Related issues (covers both Edge and FF):
https://bugzilla.mozilla.org/show_bug.cgi?id=1042151
https://github.com/philipwalton/flexbugs/issues/108

According to that first Mozilla bug, the fix for this has landed in FF81 in literally the last 19 days and will reach users from 2020-09-22 (see Release schedule). My recommendation therefore is not to adjust the existing code and wait to see if the patch to FF resolves this for us.

Just installed the FF81 beta 81.0b2 (64-bit) and can confirm it has fixed the issue, so definitely best to just wait. Also validated the fix against ICFP.

yoo-hoo!

Closing as the new UI has been developed after this issue was opened and this issue relates only to the old UI.


fixed get_current_field function

Codecov Report
All modified lines are covered by tests :white_check_mark:

Comparison is base (9c3ec78) 72.67% compared to head (73b67ba) 73.09%.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #35      +/-   ##
==========================================
+ Coverage   72.67%   73.09%   +0.41%
==========================================
  Files          34       34
  Lines        2401     2423      +22
  Branches      441      447       +6
==========================================
+ Hits         1745     1771      +26
+ Misses        497      495       -2
+ Partials      159      157       -2

Files
Coverage Δ

alchql/query_helper.py
73.66% <100.00%> (+4.43%)
:arrow_up:

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Add PropTypes to components

Hey there! ✌😁
Is there a plan to add PropTypes to this project's React components?
Currently I'm working on a possible solution for https://github.com/mikecao/umami/issues/466 and I noticed that none of the components I've encountered have typed properties. Per the discussion in https://github.com/mikecao/umami/issues/238 I figure that Typescript won't be added anytime soon, so my question is if prop-types will be added at least.
I hear your concerns regarding development velocity. But untyped components slow adoption rate and development speed of (new) contributors (a much greater source of development velocity, if I might say so 😅).
Let me know what you think ✌

Now that the components are more stable it should be easy to do. I'll gladly take a PR if anyone wants to do it.


嵌套引用自身会导致栈溢出

嵌套引用自身会导致栈溢出，比如，创建一个person类，类里有person类属性

Sorry I can not understand your language, but google helped me translating it 😄:
Nesting a reference itself can cause a stack overflow, for example, creating a person class with a person class attribute

This is a duplicate of #44 . You need to set the objectPoolSize parameter in order to avoid the infinite recursion: https://github.com/j-easy/easy-random/wiki/Randomization-parameters#object-pool-size


FreeFlowPages to be production-ready

Freeflow pages needs to be more streamlined for an end user with no technical background.
Signup/Sign in process needs to be very intuitive and easy for people to join.
In that respect, we need to explain better the process and improve the usability in the sign up page.
we also need freeflow logo to add to itsyouonline organization

Text for signing up:

Step 1: Register with ItsYouOnline
SAFE. SECURE. PRIVATE.
Step 2: Fill in your data
Step 3: Confirm your identity
Step 4: Welcome to FreeFlowPages!

Text for signing in:

Log in with ItsYouOnline
(Temporary) Log in with Username/Password

➤ samaradel commented:
done & sent to @Hamdy

➤ Hamdy commented:
There's a pull request ( https://github.com/itsyouonline/identityserver/pull/743 ) now for IYO modifications to allow for skipping Phone Verification
It's being processed by GIG
On the other hand: We've a 3 Bot login Module ( https://github.com/freeflowpages/freeflow-threebot-login )
for integration with 3bot Login.
We're making Login with IYO deprecated
Please check 3bot login @staging Here ( https://github.com/freeflowpages/freeflow-threebot-login )


CasperJS does not reset state between test files

I have ~6 test files, which should soon grow to about 20.  I had expected each test file to be starting from a clean state, but it looks like any changes I make in the first test file persist in the second file.  The outcome is that if I run "Test # 2" manually it works fine, but if I run "All Tests", the changes made by "Test # 1" cause all the "Test # 2" tests to fail.
For example, "Test # 1" adds +1 to a counter.  "Test # 2" is expecting the counter to be 0 at the start (as it is when it is run alone) but when run as part of a group it starts off at 1 already.
Is there some kind of reset commend to ensure that each test file is isolated?  Requiring each test file to completely undo its changes would be a maintenance headache.

Figures... hours of searching for an answer, 5 minutes after posting a question I find it.  This link seems to discuss my problem perfectly and uses ".clear()" as a workaround.  It is working for me as long as I end every test with a clear call.
https://github.com/dalekjs/dalek/issues/59


bug and fixed ,when there is a empty json object field would convent to be array .

Laravel Version: 5.5.39
PHP Version: 7.1.7
Database Driver & Version: mysql 5.7
Description:  hello. I found a bug when I using  Illuminate\Http\Request::json method .
Steps To Reproduce:

Route::post("/test", function(Illuminate\Http\Request $request){
    $json = $request->json()->all();
    return response()->json($json);
});

that was the request data

curl -H "Content-Type:application/json" \
     -X POST --data '{"foo":{},"bar":[],"foobar":[1,2],"barfoo":{"test":"ok"}}' http://localhost:8000/test

get response

{"foo":[],"bar":[],"foobar":[1,2],"barfoo":{"test":"ok"}}

"foo":[] does not matched "foo":{} , when using rpc system , that will cause bug in java or go or nodejs,
because others give you an object and you returned an array .

This is my unit test before add $assoc param to Illuminate\Http\Request::json() method .
and it is do not matched with the empty object json field . so I think there was a bug that
cause json do not match when using api transport with java or golang project .

unit test passed

    public function testJSONMethodByString()
    {
        $payload = '{"foo":[],"bar":{},"foobar":[1,2],"barfoo":{"test":"ok"}}';
        $request = Request::create('/', 'GET', [], [], [], ['CONTENT_TYPE' => 'application/json'], $payload);
        $data = $request->json(null,null)->all();
        $this->assertEquals($payload, json_encode($data));
    }

$ phpunit
PHPUnit 7.0.2 by Sebastian Bergmann and contributors.

Runtime:       PHP 7.1.7 with Xdebug 2.6.0
Configuration: F:\framework\phpunit.xml.dist
...
...

F:\framework\tests\Filesystem\FilesystemTest.php:60

7) Illuminate\Tests\Http\HttpRequestTest::testJSONMethodByString
Failed asserting that two strings are equal.
--- Expected
+++ Actual
@@ @@
-'{"foo":[],"bar":{},"foobar":[1,2],"barfoo":{"test":"ok"}}'
+'{"foo":[],"bar":[],"foobar":[1,2],"barfoo":{"test":"ok"}}'

F:\framework\tests\Http\HttpRequestTest.php:479

--
...
...

So that I add the param to control if the json has the empty object json field ,
when the request begin,empty object json field  will be  stdClass , when decode
it will convent to "bar":{}

Illuminate\Http\Request::json()
    /**
     * Get the JSON payload for the request.
     *
     * @param  string  $key
     * @param  mixed   $default
     * @param  bool    $assoc
     * @return \Symfony\Component\HttpFoundation\ParameterBag|mixed
     */
    public function json($key = null, $default = null, $assoc = true)
    {
        if (! isset($this->json)) {
            $this->json = new ParameterBag((array) json_decode($this->getContent(), $assoc));
        }

        if (is_null($key)) {
            return $this->json;
        }

        return data_get($this->json->all(), $key, $default);
    }

unit test passed

    public function testJSONMethodByString()
    {
        $payload = '{"foo":[],"bar":{},"foobar":[1,2],"barfoo":{"test":"ok"}}';
        $request = Request::create('/', 'GET', [], [], [], ['CONTENT_TYPE' => 'application/json'], $payload);
        $data = $request->json(null,null,true)->all();
        $this->assertEquals($payload, json_encode($data));
    }

sorry . the correct unit test is :
    public function testJSONMethodByString()
    {
        $payload = '{"foo":[],"bar":{},"foobar":[1,2],"barfoo":{"test":"ok"}}';
        $request = Request::create('/', 'GET', [], [], [], ['CONTENT_TYPE' => 'application/json'], $payload);
        $data = $request->json(null,null,false)->all(); // false give stdClass  . true give array
        $this->assertEquals($payload, json_encode($data));
    }

These changes include changes to existing method signatures. Those are breaking changes that can cause troubles to already deployed Laravel installations. Could you target the next upcoming release (5.7) instead?

so I create pr on 5.7 ? @sisve

Yes, a new branch based on master and a new PR is the easiest way to retarget to the 5.7 release.


refactor(probabilistic_occupancy_grid_map): rework parameters

Description
Implement the ROS Node configuration layout described in https://github.com/orgs/autowarefoundation/discussions/3371 for the probabilistic_occupancy_grid_map package.

Renamed the grid_map_param.yaml file to grid_map.param.yaml file.
Move the default parameter file to a standardized location. Created a lot of JSON files for schema.
Updated readme file.

Tests performed
Package built and launched locally.
Notes for reviewers
Nothing inside the src code part was changed, only taking the parameters out.
Interface changes
Parameter values are now required to be passed to the node when launched.
Effects on system behavior
None
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.

[x]  I've confirmed the contribution guidelines.
[x]  The PR follows the pull request guidelines.

In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.

[ ]  The PR follows the pull request guidelines.
[ ]  The PR has been properly tested.
[ ]  The PR has been reviewed by the code owners.

Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.

[ ]  There are no open discussions or they are tracked via tickets.
[ ]  The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

@tby-udel Thanks for the PR.
However, the PR seems to be failing in the CI for DCO check. When you push commits, could you push with signed-off commits?
For example by running the following command:
git rebase -i --signoff origin/main

Thank you for the reminder, I have pushed the signed off commit.

The required changes have been made.


Taking so long and on some API not returning location on only Android

HI, on iOS there is no problems.
But on Android it takes over 15 seconds to get current location.
Also, API28 not even returning location info.
Any workaround?
Thank you

I have had one user who have reported an issue with it never getting a GPS fix.  I've given them the ability to also use forceAndroidLocationManager, but this doesn't resolve the issue.  They are using a Samsung Galaxy Core Prime which even the user admitted was an old phone.  Any ways around this?

Most issues with locations not being fetched are solved in version 6.0.0. However certain phones did not implement the Android specifications correctly and will keep on returning location information slow. An excellent troubleshooting guide can be found here: #507


patch progress meters

partially addresses #96

Codecov Report

Merging #98 (d84ad28) into main (8a085ed) will decrease coverage by 0.06%.
The diff coverage is 100.00%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
@@            Coverage Diff             @@
##             main      #98      +/-   ##
==========================================
- Coverage   94.76%   94.71%   -0.06%
==========================================
  Files          14       14
  Lines         401      397       -4
==========================================
- Hits          380      376       -4
  Misses         21       21

Impacted Files
Coverage Δ

src/gram_matrix.jl
76.38% <100.00%> (-1.25%)
:arrow_down:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Cross table fetch duplicates results

Your Question
Hello, I have some domain objects with cross-table relationships.
I have a 1-to-many relationship between two types.
When I retrieve them I am getting duplicate records.
A reproducer is here: https://github.com/manstis/gorm-playground/tree/duplicate-records
The reproducer is a simplification of my issue; but demonstrates it well.
I need to fetch a collection of records so using First() is not an option. I also need the all child objects populated.
The document you expected this should be explained
https://gorm.io/docs/has_many.html
Expected answer
Advice on how to return the correct number of records.

I didn't understand the problem here. If you use left join, you must return two records. If you only want to return one record, you can use preload to do it.

Fair enough. I'm new to gorm and didn't know whether this was the expected behaviour. I'll close this issue. I had been experimenting with Preload(...) and reported thr other issue around soft-deletes. Thank-you.


Make a basic README file

[![PyPI version](https://badge.fury.io/py/gravify.svg)](https://badge.fury.io/py/gravify)

[![GitHub issues](https://img.shields.io/github/issues/bsoyka/gravify)](https://github.com/bsoyka/gravify/issues)

[![GitHub stars](https://img.shields.io/github/stars/bsoyka/gravify)](https://github.com/bsoyka/gravify/stargazers)

[![GitHub license](https://img.shields.io/github/license/bsoyka/gravify)](https://github.com/bsoyka/gravify/blob/master/LICENSE)


Unknown provider on injecting "video" in  controller.

Error: [$injector:unpr] Unknown provider: videoProvider
.controller("myCtrl",["$scope","$sce","$ionicLoading","$filter","video",function($scope,$sce,$ionicLoading,$filter,video){
}
here i am getting error on injecting video

Make sure that  angular,module('app', ['ngVideo']) is there and that your <script src="path.to.ng-video.js"> is in your main html file.


Title: Add a Crossword puzzle Game

Is your feature request related to a problem? Please describe.
**Create an interactive Tech Crossword Puzzle for our website.
**This game will provide an enjoyable and engaging experience for our users, demonstrating our ability to develop interactive web applications.
**The puzzle should feature essential clues, a scoring system, and an intuitive interface.
Describe the solution you'd like.
The entire crossword game content is centered on the screen for better visibility and user experience.
Dark/Light Mode Toggle: A button allows users to switch between dark and light modes, enhancing accessibility.
Flexbox is used to ensure the layout adapts to different screen sizes.
Crossword clues are updated to reflect technology-related terms.
User input changes color based on correctness, providing immediate visual feedback.
The crossword is organized in a structured HTML table for easy input.
External CSS is used to manage styling, ensuring separation of content and presentation.
JavaScript handles user interactions and dynamic updates to input fields.
The interface is designed to be user-friendly with a straightforward layout.
The code is structured into separate HTML, CSS, and JavaScript files for better maintainability
Describe alternatives you've considered.
Dark/light mode toggle theme button.
More enhanced UI.
Add any other context or screenshots about the feature request here.

I would like to work on this issue under GSSOC'24. Kindly assign this to me.


Use higher bit-depth for texture baking

Texture baking currently only exports an image with 8 bit depth. This causes noticeable stepping, because there are only 256 possible values to use. Supporting a 16 bit-depth is important for using the terrain with any other tool.
Example
When you take the texture baking output of this terrain:

And try to use it in something like Blender, you get this:

It's also flipped for some reason (ExportTexture.cpp:23).
Heightmap:

Hey an update to this issue this feature will be included from the next release along with 32 but export too.

https://github.com/Jaysmito101/TerraForge3D/commit/caf3f55d055919322302441794e3051ff6572018 Added Internal support for 8, 16 and 32 bit textures


Add SECURITY_CONTACTS

Fixes #68
/cc @yliaog @mbohlool

Codecov Report

Merging #73 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #73   +/-   ##
=======================================
  Coverage   93.51%   93.51%
=======================================
  Files          11       11
  Lines         972      972
=======================================
  Hits          909      909
  Misses         63       63

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 78472de...45f080e. Read the comment docs.

/lgtm


Two iziModal bug on close

Hey,
I having a problem here with two iziModal opened. One is just a modal with form, but the second is a alert modal with timeout. So, whats happens is when the alert timeout reach to zero and close, the first modal with form is close too.
In the url you can see whats happen:

url#modalForm - when modal form open.
url#modalTimeout- when alert open.
url# - when alert close by timeout, closing the modalForm together.

@MaikeAlame, Are you opening two Modals together?
If so, it is wrong, the plugin does not work that way.

Ha ok. Yep, I tried with two, a modal to form and a alert to errors. Maybe with Toast can do it.

Yes! ;)


Initialize country_pools, region_pools and pop_pools for updates

fixes #2659

I'm not sure how to test that this does what I expect it to.

let's pin down the issue and what is happening first. from there we can look at how to test this.

#2673 proposed a solution to this that didn't involve initialising the empty maps and addressed the underlying cause here.


Change files names to keep consistency between packages

In this PR we rename files in order to keep consistency between the different packages, in order to facilitate the user usage

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.


IVirtualMachineOperations.CreateDeploymentAsync should support deploying multiples roles at once

Right now if the Roles property of VirtualMachineCreateDeploymentParameters used in a call to IVirtualMachineOperations.CreateDeploymentAsync contains more than one role (why is a collection in the first place?) the call will fail complaining the the collection should contain only one role.
Either support deploying multiple roles at once or convert the property to a scalar.

please reopen if this is still an issue.


[WIP] Breaks import cycles.

This is work in progress, I am planning to break some more cycles in this PR.
So far I have added two commits -

Breaks cycle echo.js -> message_events.js.
Breaks cycle muted_topics_ui.js -> recent_topics_ui.js.

So far the metrics measured by Cycle-Analysis tool are down to 116, 64 from the current 118, 66.

Self-review checklist

[x] Self-reviewed the changes for clarity and maintainability
(variable names, code reuse, readability, etc.).

Communicate decisions, questions, and potential concerns.

[x] Explains differences from previous plans (e.g., issue description).
[x] Highlights technical choices and bugs encountered.
[x] Calls out remaining decisions and concerns.
[x] Automated tests verify logic where appropriate.

Individual commits are ready for review (see commit discipline).

[x] Each commit is a coherent idea.
[x] Commit message(s) explain reasoning and motivation for changes.

Completed manual review and testing of the following:

[x] Visual appearance of the changes.
[x] Responsiveness and internationalization.
[x] Strings and tooltips.
[x] End-to-end functionality of buttons, interactions and flows.
[x] Corner cases, error conditions, and easily imagined bugs.

@zulipbot add "buddy review"

I merged all but one commit as the series ending with a18b1662cb8b857794794380135a2ded938be90a, thanks @Lalit3716!
For https://github.com/zulip/zulip/pull/26068#discussion_r1245265254, I don't want to introduce a hooks system -- I suspect a cleaner option would be to have compose.js be passed the hook it needs to start the scheduled message process.

I'm going to close this since the one remaining commit we don't want to merge, and it'll be nicer to have a replacement just be its own PR without the clutter of the existing discussion.


【テスト】全部検索：Domain

概要
・テストを実装した
変更種類

[ ] フィーチャー実装
[ ] バッグ修正
[ ] リファクタ
[ ] ドキュメンテーション
[ ] その他（）

テスト

[ ] Unit Test
[ ] UI Test
[ ] 動作確認
[ ] N/A

No error was reported but at least one warning was found.

  Generated by :no_entry_sign: Danger

Codecov Report

Merging #210 (4c8a7e0) into feature/get-repositories-test (eb82f57) will increase coverage by 4.25%.
The diff coverage is n/a.

@@                        Coverage Diff                        @@
##           feature/get-repositories-test     #210      +/-   ##
=================================================================
+ Coverage                          27.18%   31.44%   +4.25%
=================================================================
  Files                                 34       34
  Lines                                423      423
  Branches                              58       58
=================================================================
+ Hits                                 115      133      +18
+ Misses                               296      278      -18
  Partials                              12       12

Impacted Files
Coverage Δ

...oid/code_check/domain/usecases/SearchAllUseCase.kt
100.00% <0.00%> (+100.00%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eb82f57...4c8a7e0. Read the comment docs.


 IF YOU DO NOT FOLLOW THE FORMAT OR MAKE A GENERIC TOKEN REQUEST YOUR ISSUE WILL BE DELETED WITHOUT COMMENT
YOUR JUSTLIST MUST FOLLOW THE JSON SPECIFICATION
https://github.com/justswaporg/justlists/example.justlists.ts
Checklist

[ ] I understand that this is not the place to request a token listing.
[x] I have tested that my JustList is compatible by pasting the URL into the add a list UI at justswap.org.
[ ] I understand that filing an issue or adding liquidity does not guarantee addition to the justlists website.

Please provide the following information for your token.
JustList URL must be HTTPS.
JustList URL:
JustList Name:
Link to the official homepage of the JustList manager:

https://list.justswap.io/justswap.json
https://justlists.just.network/?lang=en-US#/detail?uri=https://list.justswap.io/justswap.json

Sorry, but your issue will be closed because you did not submit your information in the correct format.


[SP-4178] - Backport of PPP-3991 - AEL: Size of transformation Hard-c…

…oded in web-socket max message buffer (500kb) (8.0 Suite)

Backport of PPP-3991 - AEL: Size of transformation Hard-coded in web-socket max message buffer (500kb) (8.0 Suite)

Build Completed
:fire: This pull request has some issues. It would be preferable to fix them in order for it to be just perfect. See below for more details. Some links are also available below for further assistance in addressing those issues.
Build Commands
mvn -Dsurefire.runOrder=alphabetical -B -fn -f 'pom.xml' -pl 'engine-ext/api' -P '!assemblies' -amd clean install && mvn -B -f 'pom.xml' -pl 'engine-ext/api' -P '!assemblies' -amd site

Cleanup Commands
mvn -B -f 'pom.xml' -pl 'engine-ext/api' -P '!assemblies' -amd build-helper:remove-project-artifact

Changed files
  engine-ext/api/pom.xml
  engine-ext/api/src/main/java/org/pentaho/di/engine/api/remote/EncodeUtil.java
  engine-ext/api/src/main/java/org/pentaho/di/engine/api/remote/MessageDecoder.java
  engine-ext/api/src/main/java/org/pentaho/di/engine/api/remote/MessageEncoder.java
  engine-ext/api/src/test/java/org/pentaho/di/engine/api/remote/EncodeUtilTest.java

Unit Test Coverage
These statistics help you identify how your changes have affected the coverage of the following files. If a file is not in this list, then its coverage was not affected by your changes. To get some help interpreting these metrics, please refer to Jacoco's documentation.

:warning: Coverage Changes: <0.1% (click to expand)
org.pentaho.di.trans.steps.constant.ConstantMeta

Instruction Change: -0.1% :small_red_triangle_down:

org.pentaho.di.trans.steps.ifnull.IfNullMeta

Branch Change: -2% :small_red_triangle_down:
Complexity Change: -1.9% :small_red_triangle_down:
Instruction Change: -0.2% :small_red_triangle_down:

org.pentaho.di.trans.steps.replacestring.ReplaceStringMeta

Instruction Change: -0.1% :small_red_triangle_down:

org.pentaho.di.trans.steps.systemdata.SystemDataMeta

Branch Change: -2% :small_red_triangle_down:
Complexity Change: -2% :small_red_triangle_down:
Instruction Change: -0.3% :small_red_triangle_down:
Line Change: -0.8% :small_red_triangle_down:

:new: org.pentaho.di.engine.api.remote.EncodeUtil

Branch Coverage: 31.6% :exclamation:
Complexity Coverage: 13.6% :exclamation:
Instruction Coverage: 44.8% :exclamation:
Method Coverage: 66.7% :exclamation:

org.pentaho.di.engine.api.remote.MessageDecoder

Instruction Change: -0.8% :small_red_triangle_down:

org.pentaho.di.engine.api.remote.MessageEncoder

Instruction Change: -1% :small_red_triangle_down:

org.pentaho.di.trans.steps.gpload.GPLoadMeta

Branch Change: -0.9% :small_red_triangle_down:
Complexity Change: -0.8% :small_red_triangle_down:
Instruction Change: -0.2% :small_red_triangle_down:

org.pentaho.di.ui.repository.pur.repositoryexplorer.model.UISecurityRole

Branch Change: -1.8% :small_red_triangle_down:
Complexity Change: -1.5% :small_red_triangle_down:
Instruction Change: -0.2% :small_red_triangle_down:
Line Change: -0.5% :small_red_triangle_down:

@pamval , @mbatchelor , @pentaho-lmartins , @mchen-len-son , @flbrino , @apreto please review and merge if it's all ok.
Note: this pull request should be reviewed together with the following one:
https://github.com/pentaho/pentaho-ee/pull/1104


hpx::partitioned_vector is not serializable

hpx::vector is not serializable despite being meant to.
Example: http://pastebin.com/1FytwhNA

The actual question is: 'should it be serializable'? I'm open to suggestions here.

It would make handling vectors easier as you could use it as argument to actions. After all a distributed storage is usually created to be used from multiple locations.

It would make handling vectors easier as you could use it as argument to actions. After all a distributed storage is usually created to be used from multiple locations.

Sure, but all you need is to register the vector using a unique name and send that name over the wire. This allows to access the distributed data from there as well:
/////////////
// node 1:
/////////////
partitioned_vector v(...);
v.register_as("some_unique_name");

// send "some_unique_name" to node 2 here...

/////////////
// node2
/////////////
std::string name;

// receive the name from node1 here...
name = ...;

// establish a connection to the distributed data
partitioned_vector v;
v.connect_to(name);

What about type-safety? Will connect_to refuse to connect to a differently typed vector?

What about type-safety? Will  connect_to  refuse to connect to a differently typed vector?

No :/ You have to be careful to maintain consistency yourself.

@hkaiser Can this be closed now that #2762 is closed?


Support periods in label syntax

Kythe needs support for '.' characters in its labels because several of its directories contain the character.

Just wondering, which directories specifically?

Directories under $GOPATH/src that correspond to domain names (e.g. third_party/go/src/golang.org/x/net).

Just as a note, this feature is critical for properly supporting Kythe's third_party Go libraries (since packages are stored under directories like github.com and google.golang.org).  Otherwise, we have to have 1 large, rather unmaintainable BUILD file for all of our imported libraries.  This will likely come up in Bazel's official Go support as well.

Any progress on this?

Not really. I'm slowly convincing myself that we should be able to add a couple characters without any problems. The question is - which ones?
Here's EBNF for the currently accepted labels (this will be rolled into the docs):
label =   ( “@” <workspace_name> )? “//” <package_name> “:” <target_name>
        | “:”? <target_name>
        | ( “@” <workspace_name> )? “//” ( <package_name> “/” )? ( [0-9A-Za-z_-]+ )

workspace_name = [0-9A-Z_a-z_.-] ( “/”? [0-9A-Z_a-z_.-] )*
package_name = [0-9A-Za-z_-] ( “/”? [0-9A-Za-z_-] )*
target_name = ( <letter> | [/.+,=~_@-] )+
              except strings starting with “/”,  “./”,  or “../”
              except strings ending in     “/”          or “/..”
              except strings containing    “//”, “/./”, or “/../”
              except strings identical to  “”              “..”
letter = any character for which java.lang.Character.isLetterOrDigit returns true

The consistent thing would be to make package_name closer to target_name, with similar restrictions on the full string (i.e., no "./", no "//", no "/../", etc). Actually, looking at it right now, it looks like the workspace_name is broken, because it allows things like ".", and "./.", and "./../.", which all lead to invalid paths.

I have started work on the Go rules again. I'll work on this shortlty.

I have a proposal. Let's talk.
On Thursday, 24 September 2015, Han-Wen Nienhuys<EMAIL_ADDRESS>wrote:

I have started work on the Go rules again. I'll work on this shortlty.
—
Reply to this email directly or view it on GitHub
https://github.com/bazelbuild/bazel/issues/118#issuecomment-143007827.

dots are allowed in package names as of c1caffaabd028493188b7e3419bedf3a9506dfee


Revert "66-update brats bundle"

Reverts Project-MONAI/model-zoo#67
The PR has some unsolved issues, thus we need to revert it so far.

Update: @KumoLiu will submit a new PR to fix the torch version issue, thus this PR is closed.


adding rtcp processing example

Wanted to contribute an example like the one in the Pion project here: https://github.com/pion/webrtc/tree/master/examples/rtcp-processing

Hi @themusicman, thanks for the contribution!
A couple of notes:

current example is almost the same as the echo example so we add a lot of code that we need to maintain and update as API changes
handling RTCP in ex_webrtc is a little easier as we get those packets automatically. I can see why Pion has a separate example for this as they need to call ReadRTCP in a loop (link)

I would favor adding a clause for RTCP in our echo example that just ignores those packets. We can add a short comment too. Something like this:
  defp handle_webrtc_msg({:rtcp, _packets}, state) do
    # do something with RTCP packets
    {:ok, state}
  end

This way:

we show how to receive RTCP packets
we don't add too much extra code that needs to be maintained
we don't send messages to the FE or log them in the console so the output is clean

@mickel8 Fair points. I updated the PR.

Thanks for the PR @themusicman! i have deleted the comment as we are going to talk about RTCP in our guides section (in hex docs) at some point.

Is there anything that you want help with in regards to the project? Maybe RTCP Sender and Receiver Reports?

That's something @LVala is already working on!
When it comes to the roadmap itself, I am working on ICE features (mDNS and TURN servers support) .
Other things I have in my mind but are not planned for 0.2 (i.e. neither @LVala  nor me are going to work on them)

support for AV1 codec, see #35
datachannels
ex_webrtc_dashboard - more metrics, performance optimizations
jitter buffer

and many more, I will update the list later this evening :wink:

@mickel8 I was thinking about suggesting datachannels too. I will look into that some and come up with a plan for implementation and present it to you. What do you think about that?

@themusicman Sounds great!

@themusicman I've created a new section in our Roadmap where I put things that can be addressed: https://github.com/elixir-webrtc/ex_webrtc/issues/28


Interface breakout configuration and removal Test Automation

Interface breakout configuration and removal Test Automation
Automation for test RT-5.1.4, RT-5.1.5 , RT-5.1.6
https://github.com/openconfig/featureprofiles/blob/main/feature/interface/singleton/otg_tests/singleton_test/README.md

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 52.21%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
1654

Relevant Lines:
3168

💛  - Coveralls


sentry: Untangle from page_params

I was thinking this would be a good follow-up to this morning's issues. Looks good to me assuming you've tested, aside from the one question above.


Add BigQueryKmsKey Dataflow sample

Creating a Dataflow sample to show how to use Customer-Managed Encryption Keys (CMEK) for the Using customer-managed encryption keys docs page.
Also updating the templates README for consistency.

Hi @lesv, can you take a look at this whenever you have a chance? Thanks!

@davidcavazos  Apache Beam does not have full support for Java 11 [https://beam.apache.org/roadmap/java-sdk/]. The Polidea team is still working on it. Does Dataflow Runner fully support Jave 11?  I am not sure if we should use this version.

Hi @mik-laj, although Apache Beam SDK itself isn't in Java 11 yet, the package can still be used by Java 11 applications. I would go ahead and try to stick with the latest Java version while the Beam SDK catches up. This would mean not having to migrate from one version to another once the old version drops support (like what happened with Python 2), which we've seen can be a huge effort.
I haven't run into any issues by using Java 11, so I would still recommend using the latest version to try to keep up to date.


Unified Data API

Data API Proposal
It certainly has been a while since I've last made a rather large API PR It's been three weeks since my last major API PR, however, this is the culmination of some major features being created and designed before this proposal could come to fruition. Without further ado, I present the Data API.
What is DataAPI?
Quite simply, it's an API centered around anything holding mutable data being a DataHolder. The front facing view of DataHolder doesn't have any guarantees about the data possibly being held by the holder.
So... what's the point?
Well, to put it bluntly, Entities, TileEntities, Blocks, and Items all become similar DataHolders in that they all are "basic" objects that can have extraneous data associated with them.
But you already wrote Items API!
Yeah, and? It was a pretty sweet API, wasn't it? As an idea, Items API was simply a stepping stone towards this overall Data API to cover more than just Items. The same structure that Items API had is now applicable to Entities, Blocks, and TileEntities!
Ok but why the change?
Sadly, there were several limitations of what could be represented by ItemData. First, ItemData could not translate anything about an Entity or its data. Second, ItemData couldn't represent TileEntityData without blatantly defining a method such as TileEntityData<?> getTileEntityData() which, let's be honest, is almost as useless as saying "Hey! I'll give you an Object but you have to check what type of object it is first!". Lastly, it was impossible to define various information about an Entity within an ItemStack without creating some sort of EntityData.
But before you ask more questions or make comments, let's actually review the new structure of Data.
New Beginnings for DataHolder
DataHolder was a simple interface that has existed for quite some time now, having a single method: <T> Optional<T> getData(Class<T> dataClass). Great! Well, we learned to actually use it in a few places, but it has its own set of limitations. Namely, we can't modify a DataHolder.  To change this, DataManipulator was created with a few simple methods to make it usable:

clear()::void
from(DataHolder)::DataManipulator
from(DataContainer)::DataManipulator

All is good. But what about overrides? I mean, when we have a DisplayNameData, we usually want to be able to do the following

displayName.setName("[MySuperPlugin]" + displayName.from(myItemStack).getName());`

So, what do we do? Add Generics!
DataManipulator became abstract enough that DataHolder could effectively house all getters and setters for data! What used to reside in ItemStack now resides in DataHolder! And since DataHolder is a super interface, well, we have the capability of representing data from almost any DataHolder source and sending that data to any compatible DataHolder!
Tidying Up
Because DataHolder was a super interface, we gained the ability to make changes to DataManipulators and set them on more than a single type of DataHolder. However, we still had the problem of actually representing data that hasn't been represented before, namely, data from Entity and data from previously known as BlockLoc.
Getting this done required lots of contemplation about every Entity interface and the data represented by it and what "function" that interface had. In reality, many interfaces were kept mostly for the sake of being able to comply with the underlying structure of entities in Minecraft.
I didn't really like that bit. Especially since something as simple as OcelotType is in itself representing some sub type of an Ocelot entity. So, what could be done? Well, a compromise:
I came to the conclusion that any Entity interfaces that needed to exist for their functionality and mixing compatibility with implementation would stay. Their data accessor methods however, would now reside into categorized DataManipulators such that we now have the following possible:

Entity randomEntity = randomEntityEvent.getEntity();
Optional<HorseData> optional = randomEntity.getData(HorseData.class);
if (optional.isPresent()) {
    HorseData data = optional.get();
    data.setVariant(HorseVariants.SKELETON_HORSE);
	randomEntity.offer(data);
}
DisplayNameData data = randomEntity.getOrCreate(DisplayNameData.class).get();
data.setDisplayName(Texts.of(TextColors.AQUA, TextStyles.BOLD, "SKELETOR"));
randomEntity.offer(data);

One thing while writing these various DataManipulators for entities is that there's quite a bit of overlap with some specific ItemData and EntityData. Namely, the overlaps involved things like PotionEffects, DisplayName, DyeColor, etc. So, I made sure that these overlaps didn't exist.
Finally, came the final step in this challenge: Representing BlockState information with Data API...
It took a while, but the end result is that BlockState can be considered an immutable DataHolder where it has an ImmutableCollection<? extends DataManipulator<?>> where these manipulators are mutable, but again, the underlying BlockState can not be changed.
Finally, with the BlockState change, representing various BlockProperties was doable! In came the various DataManipulators for block information, like, RailDirectionData, and TreeTypeData, but something that I further realized is that there is even duplication across almost all DataManipulators that hold a single value and allow the developer to change that single value based on some predetermined bound of either the object type or a primitive type boundary.
What ended up being created is an exhaustive list of all types of DataManipulators that now not only represent Items, Entities, Blocks, and TileEntities, but DataManipulators that can be interchanged with other DataHolders!
Just imagine it this way: Remember how I demonstrated that you can set an inventory on a chest, even though the chest is in the form of an ItemStack? Apply the same idea to the four big DataHolders: BlockData can be retrieved from an ItemStack, and an ItemStack can set Entity data, and an Entity can be manipulated by a TileEntity just the same! Pretty freaking awesome, isn't it?
With PR, we've gained the following features:

Interchangeable DataManipulators that can be used to manipulate data on any Item, Block, Entity, and TileEntity
Removed all remnant getByteData methods and notions to represent "magic values"
Provide a step forward for plugin developers to start using data more intelligently
Potentially future proof the core Data API for future Minecraft versions to come
Unify Data Manipulation across multiple APIs with minimal maintenance overhead

Being that this PR will break several API's when merged, an implementation PR is being prepared for merging such that Sponge Implementation can update with minimal wait time during the API breakage.

@gabizou Pretty impressive.
I did not have time to read all the changes yet, but i will do this once the javadocs are changed.
But i have noticed that the Player's compass target is not get/set-able in the API (now and before), it is possible as proven by Bukkit. Am i right this will/would be implemented as a data class as well? (Will you add it here as well or does that needs discussion and thus be better off in its own issue?)
I have seen the EntityState and similar classes have been removed, does that mean, that if i grab the entities' data they are no longer live? Is it for Entity, TileEntity, Block and Item all the same?
Example: Every change to Entity is live, but the data objects returned by getData() are some kind of copy i can modify and store somewhere (even in a file) without affecting the entity (unless i set the modifed data directly back to the entity). Are all data objects safe/detached or may they cause async execution errors?

@gabizou Pretty impressive.
I did not have time to read all the changes yet, but i will do this once the javadocs are changed.
But i have noticed that the Player's compass target is not get/set-able in the API (now and before), it is possible as proven by Bukkit. Am i right this will/would be implemented as a data class as well? (Will you add it here as well or does that needs discussion and thus be better off in its own issue?)
I have seen the EntityState and similar classes have been removed, does that mean, that if i grab the entities' data they are no longer live? Is it for Entity, TileEntity, Block and Item all the same?
Example: Every change to Entity is live, but the data objects returned by getData() are some kind of copy i can modify and store somewhere (even in a file) without affecting the entity (unless i set the modifed data directly back to the entity). Are ALL data objects safe/detached or may they cause async execution errors?

Short answer: Yes.
Long answer: Yes it would be a data class. No I won't add it here, yes it will need discussion and added in a later PR. Yes data is no longer live, just like getting data from any of the data accessors that are currently available in an entity. Yes, all data is now joined in a unified format, all are grabbed and not retaining any form of synchronization with the owner of the data. Almost all objects are safe. The only one that is not always safe is anything to do with Inventory.

I am curious as to how modular this system is in terms of adding custom data.
For instance, would it be possible to add a special type of modifier to an item stack to apply some special effect that is defined.
Another example could be adding a custom ability to a zombie entity.
These custom data APIs would essentially have to have callback functions to provide the proper functionality. I would imagine that a custom data type for a weapon would implement some interface that provides a method for when that weapon is used (i.e. weapon was used to attack some entity), which then would implement said method with the custom special effects.
I really love the idea and I think it is intuitive, but just curious how far you think we could push this to add custom data effects.

Yes it can, but Wouldn't it just be easier to have the plugin listen to the events, then act on them or modify the events based on the custom data present?
Making the custom DataManipulator do it just seems strange.

That is essentially how I handle custom data in bukkit, which can get tedious as I have to keep track of which entity uuids I want to have custom abilities.
Would be nice to just bind the custom data to the entity I am spawning and not have to worry about when that specific entity does the event. (So another example could be one set of zombies have one ability, whereas another set are completely different)
Perhaps the entity example is more for customizing the AI for specific mobs, but it really depends on how we define data. Same goes for item custom data as I want to modify how a specific item behaves when it is being used (however I dont want all items of the same type to behave like this, it would be more of a unique item that spawns rarely).

Except you don't need to keep track of UUID's because you can tag it with the custom data, and it may be persistent.

Thinking more in terms of what makes up an entity and what defines the entity.
Something more along the lines of this: https://forums.spongepowered.org/t/component-system-and-minecraft/76/23
Where you define the custom data and attach them. For me it feels intuitive and simple to implement for plugin developers compared to having all of my custom data handling be done in events.
Using the current proposed system, how to identify which custom data is applied to a particular entity?
Given three types: CustomAttack1, CustomAttack2, CustomAttack3
Would I need to specifically check if each of these custom data types are present for every entity that attacks? I think this would not be efficient. And a better solution would be to iterate over every custom attack data attached to each entity that attacks. If there is no custom attack data attached, then nothing happens, otherwise the appropriate method hook is called.
Example code:
interface CustomAttack
{
   // target is the entity that is being attacked, returns damage dealt
   double attack(Entity target, double damage);
}

class CustomAttack1 implements CustomAttack
{
    double multi;
    public CustomAttack1(double multiplier)
    { multi = multiplier; }

   @Override
   public double attack(Entity target, double damage)
   {
       return damage * multi;
   }
}

...

Entity newEntity = Entity.spawn(Zombie.class);
newEntity.attach(new CustomAttack1(2.0);

I hope you see the benefits of this system and trying to incorporate things at a lower level.

@ryantheleach The last thing you want is to register an event handler for each entity. Especially since the only way to unregester them last time I checked is to unregester all event handlers for a given plugin.
Thus why you would need to keep track of the uuids within a single event handler.

@Jameshobbs21 I rather like the idea of DataManipulator having callbacks based on the type of DataHolder. It would create a really similar workflow to unity if you think of (DataHolder -> GameObject) and (DataManipulator -> Component)

Would also take care of my wish for #447

You wouldn't need one for each entity, you would only need a single listener for all entities.
listenForInterestingEntityEvent(entityEvent e){
Optional myData = e.getEntity().getData(MyCustomDataManipulator.class);
if(myData.isPresent()){
doCustomBehavior(myData.get());
}
}
In addition, all the entity component systems I've seen, the component is just data that you need for rapid processing in a system, and/or a reference to where you can find less used data.
The CustomDataManipulator would take the role of the Component, and the rest of the plugin the system.

@ryantheleach Unity Doesn't really follow that so its not really an ECS by defination. But it works and can work here too.

Unity isn't the only ECS system in existence.

I like the idea of binding specific attack patterns/effects to an entity.
However there are some points/concerns I have with the suggested system.
If it uses the DataAPI with a callback then it does not persist. At least not without some special restore code. This does not occur if you use a simple data tag and check for it during events.
More importantly you cannot do very much in this Attack object. You can cast some particles and sound and define the damage, but you cannot define attack speed, range, passive weapon effects ...
These all are features for a AI API I would like to see, so my mayor concern with this proposal is that it may interfere with the AI API because it implements a part of it without taking care of the rest.
So i would suggest using @ryantheleach's suggestion with data tag and event handler to solve your issue until the full blown AI API is there.

@ST-DDT I see what you mean, and agree that it fits better with the entity AI API.
Would this apply to item stacks as well? For instance could we define AI for a particular item so that whenever an attack occurs it does some form of AOE damage. Or perhaps the item increases some modifiers for a player when that item becomes equipped, such as increasing custom attributes defined by a plugin i.e. strength, agility ,etc.

I guess this is possible using AttributeModifiers:
org.spongepowered.ap.attribute
org.spongepowered.api.data.manipulators.AttributeData
I'm not sure but there seems to be some issue with the API there.
AttributeData extends ListData<AttributeModifier, AttributeData>
provides AttributeModifiers, but there is no way to get them for a single attribute.
Maybe AttributeData should be changed to
extends MappedData<Attribute, AttributeModifier, AttributeData>

@AlphaModder @gabizou Can you check whether
AttributeData extends ListData<AttributeModifier, AttributeData>
is right?
IMO it should be:
AttributeData extends MappedData<Attribute, AttributeModifier, AttributeData>


test: Base token price client, fix: ratio calculation multiplicative inverse error

What ❔

I introduce tests to external_price_api crate. Some work was taken from https://github.com/matter-labs/zksync-era/pull/2315
fix multiplicative inverse ratio calculation bug

Why ❔

We want to make sure the flow of data from API response to token ratio is correct

Checklist

[X] PR title corresponds to the body of PR (we generate changelog entries from PRs).
[X] Tests for the changes have been added / updated.
[X] Documentation comments have been added / updated.
[X] Code has been formatted via zk fmt and zk lint.

General observation - originally I've split up the tests across multiple files so that CMC and CG can reuse the same setup functions while implementing their specifics in the files of their own. Do you think it's still useful to keep that separation, or should we consolidate all tests code in a single place?

@ischasny I would think that this may be still useful as tests.ts provides some framework to properly test each integration by implementing only the relevant mock and client setup in each test. If this doesn't work well with CMC we can get rid of this and consolidate. Hard to tell IMHO without implementing the CMC tests.


⚠ Secret Website 3 has degraded performance

In 1d86d2b, Secret Website 3 ($SECRET_WEBSITE_3) experienced degraded performance:

HTTP code: 200
Response time: 2275 ms

Resolved: Secret Website 3 performance has improved in a08b6dd.


[Bug]: Checking "No File Icon" in style settings add strange string to file name in file explorer.

Bug Description
Checking "No File Icon" in style settings add strange string to file name in file explorer.
As what is looks like.
But actually it doesn't change the actual file name.
When I go to file, it has correct file name, but only the name displayed in file explorer are changed.
(Not in the recent file(plugin) starred file, or the result of file search... )
Especially, the strange string "setting"is added to the filename.
For example if I have file named Obsidian Index, and if I turn on the "No File Icon" setting, then it goes to settingObsidian Index.
I think it is scss/css related problem.
This is so annoying.
Relevant Screenshot

Strange string "setting"is added to the filename.
Does not affect real file name.

To Reproduce
My current Obsidian version is v0.15.8 (Installer version: v0.15.6)
Installed Plugins

Calendar
Dataview
Icon Folder
Kanban
Recent Files
Sliding Panes (Andy's Mode)
Style Settings
Templater

Settings to reproduce this problem

Install "Style Settings" Plugin
Go to Settings>Style Settings>User Interface>File Explorer
Check the setting File Explorer: No File Icons

Obsidian Version
0.15.8
Installer Version
0.15.6
Font Size
20
Which editor are you using?

[X] New Editor
[x] Legacy Editor

In which mode(s) does the problem occur? (if applicable)

[X] Source (Edit)
[X] Reading (Preview)
[X] Live Preview

Which operating system?

[X] macOS
[ ] Linux
[ ] Windows
[ ] iOS
[ ] Android

Plugin-Specific Problems

[X] I took note of the specific instructions regarding those plugins.

Checklist

[X] I updated to the latest version of the theme (Settings → Appearance → Themes - Manage → Update).
[X] I made sure that the issue is related to this theme by checking that the problem does not occur with the default theme.
[X] In case I am missing an UI element, I have checked that it cannot be re-enabled with the Style Settings plugin.
[X] If the bug occured after updating the theme, I read the last couple of entries in the changelog to make sure the bug is not an intentional change. (In that case, there will most likely be a style setting to turn it off again.)

Hi! As you may have heard, the upcoming Obsidian update 0.16 has a massive amount of changes for theme development, necessitating a complete rewrite of Shimmering Focus. This means:

A lot of bugs and feature requests will be obsolete. with Obsidian 0.16 and the rewritten Shimmering Focus.
As the theme has over 15,000 lines of CSS, the rewriting will take a considerable amount of time. Recreating the core features alone will likely take me a while, so I simply will not have much time to implement many feature requests, since the recreation of the past core features has priority.

Basically, this is the reason why I am – for now – closing this issue. If your bug still exists / your feature request is still relevant in the upcoming version 3.0 of Shimmering Focus, please comment here and I will re-open it. 🙂


gRPC streaming support in Python.

This is an effort of #343, for Python:

allow parameter flattening and retrying for server-side streaming
the same interface as grpc-generated one for
client-side streaming and bidi-streaming
something like page-streaming might be helpful for some server-side
streaming methods -- that's not yet implemented.

Current coverage is 82.58% (diff: 86.66%)

Merging #460 into master will increase coverage by 0.29%

@@             master       #460   diff @@
==========================================
  Files           206        206
  Lines          7655       7666    +11
  Methods           0          0
  Messages          0          0
  Branches       1011       1016     +5
==========================================
+ Hits           6299       6331    +32
+ Misses         1053       1038    -15
+ Partials        303        297     -6

Powered by Codecov. Last update 03f487a...00451c4

rebased and fixed the build failure.

Suggestion: make a new grpcStreaming config section that is independent of page streaming. Then you don't need conditions like !method.getResponseStreaming() && config.getMethodConfig(method).isPageStreaming() or changes to PageStreamingConfig. I think this makes sense because changes to GAX to support "chunk" stream flattening will likely need to be separate from the GAX code that handles conventional page streaming.

I've also modified the proto structures, so now it's grpc_streaming config instead of page_streaming (the internal structures are same currently though). PTAL.

@geigerj, please take another look.

Rebased. It still fails due to codecov reports, but I feel like this is not helpful (mostly not-covering error reports).

Okay, now the merge conflicts are resolved. PTAL.


[Bug fix] Devise login forms do not show correct error messages (#850)

fix(): show error messages while invalid login attempt

fix(): remove '.turbo_stream' text form url for login requests

fix(): validation errors not showing in sign-up & my-settings page

chore(): test cases added

@alis-khadka this is the one causing the error in the forum:
just replicated the issue on Heroku


Deploy Storybook

Based on findings from the blocking issue, implement the tooling to build and deploy Storybook.

Duplicate