[Feature Request] Compile to static HTML

This is probably too broad for a feature request, but I would like to use this without needing JavaScript enabled on my browser.
I'm planning on adding it to a page that uses Nuxt, so I imagine this being a library with a function or a Vue component you can import and place on your view, and when generating the static site it builds the HTML like it would on a browser.
But I can see that might mean making a entirely different repo, and then maybe using that as a dependency of the emgithub page.

So it would be an npm library and a CDN that provides the js for sites like yours that do the embedding in the browser.

I'm not a front-end developer so I don't write much Vue/React code. For me, the need of code embedding only happens when I am writing static blogs. That's why emgithub is designed to be used by embedding a script tag.
The idea of making emgithub a Vue/React component sounds interesting and helpful. But I may not be able to implement this, since I haven't written Vue/React code for years. Anyway, I'll mark this as help-wanted in case someone could do this.

On my fork I'll try to decouple the html code generation from the browser writing. I'll comment here if it seems it can be included without breaking changes.

It'd be really useful, if the script tag wasn't needed, because now emgithub can't be used in places like a GitHub readme, where regular iframe embeds still work. Should I open a separate issue for that, or are they related?

It'd be really useful, if the script tag wasn't needed, because now emgithub can't be used in places like a GitHub readme, where regular iframe embeds still work. Should I open a separate issue for that, or are they related?

I believe they mean the different things: compiling with a static site generator, vs embedding with a iframe.
However, it seems like GitHub doesnot support rendering iframe tag 🤔  https://stackoverflow.com/questions/48402823/embed-openstreetmap-iframe-in-github-markdown
Personally, I think iframe may be too heavy?!

@louis1001 did you have any work started for this? I'm facing the same case where I'm generating a static site and would like to generate my embeds at build time - rather than at load time (e.g. what if GitHub is down?).
As you said decoupling the HTML generation would be perfect!

@whitfin I think I might have lost my local changes, it was a while ago. I do have a fork for a lib version of this tool, but no progress uploaded. If you'd like to contribute we work there, or just let me know of a your own repo if you make one.
either way, yeah I'll try to get it working again.
Here's my fork: https://github.com/louis1001/libemgithub


[UI Feature] Tooltip for some buttons when hovering over them.

Is your feature request related to a problem? Please describe.
Not a severe problem, it's more like a would-like feature. Some newcomers won't be able to understand what some buttons do. Some buttons already have labels, but the home buttons don't have any labels. I feel like there needs to be some consistency.
Buttons With No Labels

Buttons That Do Have Labels

Describe the solution you'd like
Up to now I have seen the React side of the source code. Possibly add kofta/src/app/components/Tooltip.tsx.
Labels should be dynamically translated as well.
Describe alternatives you've considered
Simply put a label beneath but UI wise doesn't look pretty in my opinion :(
Additional context
Some tooltip examples, Material UI.  (Doesn't have to be mui)

Hey, I think I can try and make a prototype using Material UI, but I can't seem to find where I'd implement it in the kofta file. I'm definitely new to this project so any help would be appreciated!

Hey, I think I can try and make a prototype using Material UI, but I can't seem to find where I'd implement it in the kofta file. I'm definitely new to this project so any help would be appreciated!

I believe you should be doing it in kibbeh, the directory for the Next.js frontend.


Install error

There is a problem with installing Twitch Leecher 1.4.2x86. During the Setup, the sentence saying that 'your system has not been modified' has been kept appeared on the screen, so if you can help me out, it would be good. (by the way, my window is 7 and 32bits with NET framework of 4.5)

Are you familiar with console commands?
You can start the installer in the console with
C:\dir\to\installer\TwitchLeecher_1.4.2_x86.exe -l "log.txt"
The try to install as you normally would. This should create 2 logfiles, one named log.txt and another one named log_1.txt or something. We need both.

After experiencing the same error, the cmd-call surprisingly works. Did not check any potential reasoning behind.
In my case: TwitchLeecher_1.4.2_x64.exe

@sschnug that does not make sense (technically). A cmd call is not different from clicking on the exe file unless the cmd is opened as admin or something. I suppose in your case it would now also work normally. What can be an issue though is when you start the installer from a network drive. .NET does not like running code on network drives and throws a lot of permission errors.

As a CS-guy i get your point. It is like i described and i know it's of limited use for debugging.
I don't know anything about the installer and can't reason about potential side-effects and consequences (5 sec inet-loss; HDD-response time, ...).

The installer is "WiX Toolset", a natively compiled C++ application that wraps a WPF GUI. It is near impossible calling a native exe from cmd or explorer makes any difference (otherwise many people would lose a lot of faith in their job 😈).
But anyway, cool that you're up and running, but there's no word from the OP... so I am closing this one for now.


Don't format exceptions before logging

Fixes #253
traceback.format_exception is added to report_error with https://github.com/graphql-python/graphql-core/pull/154 two years ago, it solves another problem but i couldn't understand why did anyone need to stringify all exceptions on such central place. It removes all details of an exception and downgrades is to simple string. That change makes crucial impact on error logging.
Before the change:

All exceptions have same type and same title. No traceback. There are some autogenerated breadcrumbs thanks to Sentry, but it's impossible to find why and where this error is happening. Message is truncated. All details are lost.
After the change:

Exceptions have their own types. Message is short, clear and gives information. Traceback is on place. Breadcrumbs are useful.

@ulgens thanks a lot for creating this PR, I ran into the same problem.
I'm pretty sure to get the tests to pass you have to fix the code in graphql/execution/tests/test_executor_thread.py

@lucas-sonnabend The issue with test wasn't related to code, it was on Travis side. Tests are fixed on a second test run, but now coverall fails :face_with_head_bandage:

LGTM 🚀 Don't worry about the code coverage, nothing has changed but coveralls calculation isn't always exact leading to slighty changes on its coverage report.

@syrusakbary
@jhgg
@dittos
as you are the main contributors according to the readme, what are the next steps to get this approved, merged and released?

Would love to see this merged in, as right now we're forced to use Django middleware to bubble the actual exceptions up to Sentry, leaving us with duplicate Sentry issues (one with the big truncated string as shown in the OP, another with the actually useful information like the second one shown in the OP). We've considered hiding all exceptions that come through graphql.execution.utils from Sentry, but since there's a probability that this will be fixed (since this PR exists), we'll hang tight on that for now and hope to hear news that this makes its way into core.
 Wrapping the default GraphQL view is pretty straightforward, but does lead to the aforementioned problem of duplicate Sentry issues if you don't block the graphql.execution.utils logger.

@jkimbo :wave:

Is there any way we can get this merged and release? I'm happy to help if it is needed :smiley:


add code of conduct [https://github.com/apache/incubator-heron/issues…

…/3636]
https://github.com/apache/incubator-heron/issues/3636
Signed-off-by: Sree Vaddi<EMAIL_ADDRESS>

I'm not sure we can add this as we are an Apache Foundation project.  Apache has their own guidelines for contributors and etc.  This may need to be raised to our mentors before this is merged.

The Apache Code of Conduct can be found here: https://www.apache.org/foundation/policies/conduct
Closing this ticket.


Vite Vue

How can I integrate this with Vite Vue for usage in .vue files, in the <script setup lang="ts"> ?
I loved Civet's official docs, I had fun! Now I wish that I can integrate this with Vue and will start promoting it heavily!!!
Thank you for making this dreamy language taking TypeScript to the next level!
Wish you health, peace, and success.

Oh didn't notice there's a Discussions tab. Can you convert this to a Question, please? :)


adapter-static does not create the fallback file when prerender.enabled = false

Describe the bug
With config like this, the fallback file is not created:
 import adapter from '@sveltejs/adapter-static';

export default {
 adapter: adapter({
   fallback: 'index.html'
 }),
 prerender: {
   enabled: false,
 },
}

Reproduction
https://stackblitz.com/edit/sveltejs-kit-template-default-hhb1ve?file=package.json
Run npm run build and notice that build/index.html does not exist. I suspect this changed with the recent "prerender during build" PR. It was working with kit version 288 and adapter-static 28.
Logs
No response
System Info
kit 303, adapter-static 29

Severity
blocking an upgrade
Additional Information
No response

Looks like https://github.com/sveltejs/kit/blob/eebe92847bf1c5cc8fbab47203c7bb8899ac897f/packages/kit/src/core/build/prerender/prerender.js#L58 checked if fallback was enabled before #4192 but now it doesn't.

I tried making a change to move the fallback creation from the bottom of the function to just after where server is created, and then moved the prerender.enabled check to just after that.
This appears to work fine in my testing. Any thoughts on this?
 const server = new Server(manifest);

 const rendered = await server.respond(new Request('http://sveltekit-prerender/[fallback]'), {
         getClientAddress,
         prerender: {
                 fallback: true,
                 default: false,
                 dependencies: new Map()
         }
 });

 const file = `${config.kit.outDir}/output/prerendered/fallback.html`;
 mkdirp(dirname(file));
 writeFileSync(file, await rendered.text());

 if (!config.kit.prerender.enabled) {
         return prerendered;
 }


Add List and Link

Add and export List
Add and export Link
Export more mixins

PTAL thank you 😄 🎉

Thanks again for reviewing, @jshoe ! Merging!


Simplify CaseTest entities

The response of the CaseTest requests (PUT and GET) are complicated. They should be either simplified as well or well documented.

This should help a little bit


Support location (path) proxy routing

I develop on a complex web app with many services, and most of these services are proxy routed via path (like nginx's location) rather than subdomain.
Would it be possible for katon to route different paths on a single domain to different upstream services?

Can you provide an example please? Not sure to understand.

For example, in nginx, you can proxy requests to the same domain to different upstream servers depending on URL path:
    location / {

      location ~ /api {
        proxy_pass $api_server;
      }

      location ~ ^/assets {
        proxy_pass $assets_server;
      }

      proxy_pass $app_server;
    }

Requests for /api/xyz will be proxied to $api_server, requests for /assets/pic.jpg will be proxied to $assets_server, and all other requests will be proxied to $app_server.

Thanks for the example. Unfortunately, katon doesn't support that.
But creating a simple proxy server could do the trick. I've not tested the code but it should give you the overall idea.
// proxy.js
var http = require('http')
var httpProxy = require('http-proxy')
var proxy = httpProxy.createProxyServer()

http.createServer(function(req, res) {
  // Extract id from /:id/*
  var arr = req.url.split('/')
  arr.shift()
  var id = arr.shift()

  // Reconstruct URL
  req.url = arr.join('/')

  // Proxy to http://:id.ka
  proxy.web(req, res, { target: 'http://' + id + '.ka'  })
}).listen(process.env.PORT)

~/proxy$ katon add 'nodemon proxy.js' --name my-project
~/api$ katon add 'cmd'

Requests to http://my-project.ka/api should then be proxied http://api.ka
For more information, see https://github.com/nodejitsu/node-http-proxy
Tell me if it doesn't work.


page_entries_info view helper ported from will_paginate

Renders a helpful message with numbers of displayed vs. total entries.
Ported from mislav/will_paginate
Basic usage:
<%= page_entries_info @posts %>
=> Displaying posts 6 - 10 of 26 in total
Very useful in views to display paginated collection information. Present in Mislav's will_paginate.
Commit includes helper and test coverage.

Merged this. Thanks!


Added IBU field

Added IBU field to the Beer object so it would pull down that info when you do a search.

Thanks for the PR!


[Surface Book 2] Touchscreen not working

As title says, touchscreen doesn't work. This is a fresh install of Manjaro on this Surface Book 2.
I followed this [Fix] here https://github.com/dmhacker/arch-linux-surface/issues/56
Also tried installing pre-compiled binary.

Can you try running the setup script again in conjunction with the 5.13.15 kernel? I've updated the firmware, libwacom, and mkinitcpio options.

Closing this unless there are further updates.


Double-clicking causing poor user experience in dark mode

Issue Summary
Double-clicking in the vicinity of the parent div responsible for toggling between dark and light themes, accessing settings, and profile icons results in a background color reset, consequently leading to an undesirable user experience

Check bottom left, how it is before double click

After double click

Steps to Reproduce
To replicate the issue:

Open the Ghost admin interface.
Locate and click on the parent div situated in the bottom left corner of the settings section.

Ghost Version
5.71.2
Node.js Version
18.12.1
How did you install Ghost?
MacOs
Database type
MySQL 5.7
Browser & OS version
No response
Relevant log / error output
No response
Code of Conduct

[X] I agree to be friendly and polite to people in this repository

It could probably  be solved by adding  user-select none  to div container.
If it's considered as bug, please do assign will take it up.

Hey @daniellockyer, can you assign the issue to me?

Hello @Akhi88S
I attempted to replicate this issue, but unfortunately, I couldn't reproduce it. Could you please double-check and provide more details about the issue? Let me know if you encounter the issue again.


Fixed some typos and in store.py if the store directory doesn't exist then create it

Minor update

😄


Code documentation

Describe functions, React components, etc.

what it does
which function parameter means what
...

Documenting only the important parts of the code and less readable code.


Empty filter and sorting array causes issues

When filters and sorts are disabled, the collection-grid module still looks for items in each of these arrays and raises an issue which prevents rendering. This took awhile for me to figure out, and in order to resolve this issue, you have to add an item to the sort or filter array in shop settings.

Above is an example of an error shown when trying to render a collection before you've added a sort to the sort array in shop settings.

Hey there @isaacmattern sorry about that!
This is a good catch, glad you were able to resolve it. I just added a few more checks so that it doesn't fail if that data's not set in the Shop Settings.

awesome! thank you so much for the quick fix


[e-Terminology] Dropped calls

@koidl reported that calls to e-Terminology get dropped. I checked the logfile and I cannot see log messages that indicate that a calls is dropped because of server overload. It is still possible that the server is overloaded though. I need some more information:

What exactly do you mean by "Dropped call"? What is the http status code and does FREME provide more information like an error message?
Is there a way we can reproduce the problem? I mean, is there a specific API call that fails all the time?
Can you point me to a time when the problem occured? Then I can better search the log files.
Do you do the same amount of calls to another e-Service also? I want to know if this is e-Terminology specific.
You mention 10 calls per second. How many calls do you do in parallel?

What exactly do you mean by "Dropped call"?

Dropping the connection.

What is the http status code and does FREME provide more information like an error message?

I can't provide status code. Most of the time we get connection timeout.

Is there a way we can reproduce the problem? I mean, is there a specific API call that fails all the time?

We use multiple services.

Can you point me to a time when the problem occured? Then I can better search the log files.

Monday and Tuesday i ran some tests.

Do you do the same amount of calls to another e-Service also? I want to know if this is e-Terminology specific.

I do the same amount of calls for multiple services. The pipelines to get the labels, we used e-Terminology (this is the service we get connection timeout more often), one Aylien service (no issues here) and some times for testing things I use Open Calais (no issues here)

You mention 10 calls per second. How many calls do you do in parallel?

Depends of how many websites I crawl but between 1 and 5.
What Apache you run in your server and what version?
If is not too much to ask can you run for me in your server the command "htop" and please send me a screenshot?

We further discussed this via email and now the issue is delayed for some weeks.

@xFran do you still have this problem?

I think we can close this


Overflow alarm metric displays properly on alarms tab

The current display of alarm metrics does not overflow onto the next line for some reason. We have set up the wrap setting via flex but it does not respect. It allows up to 9 on the same line before throwing up rendering issues. So this needs looking into/fixing.

Ideally, we want to just keep adding as many panels and have it overflow, but if that doesn't work for any reason, we can just manually create two rows for a tablet display.

Hi, please review. Thanks


Add latest static Gaelic translations

What is the context of this PR?
Adds latest static Gaelic translations.
How to review
Check the translations match crowdin.
Checklist

[ ] New static content marked up for translation
[ ] Newly defined schema content included in eq-translations repo

 Load Irish PO files for NISRA

 Load Irish PO files for NISRA


Add possibility to track output windows (problems, output, debug console, terminals)

Hi, currently in output windows possible to add some information from extensions, but it couldn't read information from output windows.
For DEBUG CONSOLE it is possible to track with DebugAdapterTracker, but for other windows, it is not possible.
Maybe it is possible to add something like onDidWriteTerminalData for all windows/outputs?
It will be helpful to analyze/diff changes in the build process, tests, and so on and help to fix many hard bags in projects

These are all separate features. We wouldn't add one way to track info that works in all of them. It seems like output channels is the main one that's missing, but I don't really think there's a good use case for that API

build process, tests, and so on

In my experience, output channels are primarily just used for internal logs. If an extension wants to expose some info that they are writing to an output channel, they probably should come up with their own way to do that. Do you have some specific use case in mind?

This feature request is now a candidate for our backlog. The community has 60 days to upvote the issue. If it receives 20 upvotes we will move it to our backlog. If not, we will close it. To learn more about how we handle feature requests, please see our documentation.
Happy Coding!

That's interesting, but I don't really think it fits into the way things are done in vscode.


[SPARK-44760][INFRA] Fix list index out of range for JIRA resolution in merge_spark_pr

What changes were proposed in this pull request?

This PR fixes list index out-of-range error for the merge_spark_pr script
The error occurs when the branch we merge into does not have a jira project version.
>>> versions = sorted(versions, key=lambda x: x.name, reverse=True)
>>> versions
[<JIRA Version: name='4.0.0', id='12353359'>, <JIRA Version: name='3.5.1', id='12353495'>, <JIRA Version: name='3.5.0', id='12352848'>, <JIRA Version: name='3.4.2', id='12353368'>, <JIRA Version: name='3.3.4', id='12353505'>, <JIRA Version: name='3.3.3', id='12352932'>]
>>> list(filter(lambda x: x.name.startswith(""), versions))[-1]
<JIRA Version: name='3.3.3', id='12352932'>
>>> list(filter(lambda x: x.name.startswith("3.2"), versions))[-1]
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
IndexError: list index out of range

Unlike other archived branches or versions, v3.2.5 is missing from our JIRA. This crushes the merging scripts during JIRA resolution if branch-3.2 is chosen.
Why are the changes needed?

happy merging
Does this PR introduce any user-facing change?

no, infra only change
How was this patch tested?

manually tested
>>> default_fix_versions = []
>>> for b in merge_branches:
...     if b == "master":
...         default_fix_versions.append(versions[0])
...     else:
...         found = False
...         for v in versions:
...             if v.name.startswith(b.replace("branch-", "")):
...                 default_fix_versions.append(v)
...                 found = True
...         if not found:
...             print(
...                 "Target version for %s is not found on JIRA, it may be archived or "
...                 "not created. Skipping it." % b)
...
Target version for branch-3.2 is not found on JIRA, it may be archived or not created. Skipping it.
>>> default_fix_versions
[<JIRA Version: name='4.0.0', id='12353359'>, <JIRA Version: name='3.5.0', id='12352848'>, <JIRA Version: name='3.5.1', id='12353495'>, <JIRA Version: name='3.4.2', id='12353368'>, <JIRA Version: name='3.3.3', id='12352932'>, <JIRA Version: name='3.3.4', id='12353505'>]
>>> quit

cc @dongjoon-hyun @cloud-fan @HyukjinKwon, thanks

ah, need to fix the lint by dev/reformat-python

Thank you for the reminder, @zhengruifeng.

Merged to master. Thank you all.

Merged https://github.com/apache/spark/pull/42407, https://github.com/apache/spark/pull/42404, https://github.com/apache/spark/pull/42442 by last updated script. It shall be fine now

Merged to master, thanks @zhengruifeng @dongjoon-hyun @cloud-fan @HyukjinKwon


ID-1783: support additional iris investigate operators

Changes:

Updated and removed unused dependencies
Updated Copyright year
Added operators for pivot module (create_date_within, first_seen_within and first_seen_since)

Changes look good, nice job!

What are you using for the auto formatting? Asking because the upstream repo has git hooks that require black format. No biggie, but if you're using something else I might turn it off or switch for this project so we don't have to reformat again to pass their release checks
Loom video always helps for functional changes if you're able. No need this time around but just keep in mind for the next one


How to write using nfcV

I've checked the example with nfcA in the Pokemon app, but I can not implement the same logic for  NfcV. What's the first parameter which I should put here?
await NfcManager.nfcVHandler.transceive([????, 4, ...blockData]);

Hi @Daba314 , thought we also support transceive for NfcV, however different tags have different commands so you generally cannot expect to achieve the same functionality by sending the same payload to different tags.


Only two ECS instances out of four are working

Every time I launch the CloudFormation Stack, no matter the number of ECS instances I choose, only 2 are appearing in ECS.
If I choose 4 instances I can see that 4 EC2 instances are created, but only 2 available in ECS.
Logging in the other two shows that there is a problem with docker:

$ cat /var/log/docker
\nTue Jun  7 16:30:39 UTC 2016\n
time="2016-06-07T16:30:39.219356348Z" level=info msg="API listen on /var/run/docker.sock"
\nTue Jun  7 16:31:12 UTC 2016\n
time="2016-06-07T16:31:12.241744210Z" level=info msg="New containerd process, pid: 2772\n"
time="2016-06-07T16:31:14.023350929Z" level=fatal msg="Error starting daemon: error initializing graphdriver: Device is Busy"

Hi @lucacome,
I was able to replicate the issue you saw and agree updating the AMI should resolve the issue.
I've done so in:
https://github.com/awslabs/ecs-refarch-service-discovery/commit/02bf7f35ba6d979813789cf322d55cb36a47e93f
Please let me know if you continue to see the issue.


UI feedback after testing NFT Showcase

Ordering by the highest bid can be potentially abused, as not all bids can be expected to be accepted.
NFT Showcase tab seems to be loading all of the listed posts at once, which causes performance issues, especially on slower client devices.
Its hard to navigate the NFT Showcase as the back button scrolls it to the top.
When price of the bid (on the My Auctions / All Bids) is rounded to the display value, sorting does not occur on bids making it impossible to differentiate tying and potentially blocking the auction.

Also, as pointed by @tijno - can't multiple diamond a post from Showcase
SendDiamonds: Problem creating transaction: Blockchain.CreateCreatorCoinTransferTxnWithDiamonds: Problem getting creator coin nanos: : RuleErrorCreatorCoinTransferPostAlreadyHasSufficientDiamonds


Fixed django storage issues with summernote lang = 'en-US' settings

Added check summernote language is not 'en-US' before adding i18n script

Codecov Report

Merging #237 into master will increase coverage by 0.03%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #237      +/-   ##
==========================================
+ Coverage   96.69%   96.72%   +0.03%
==========================================
  Files          11       11
  Lines         212      214       +2
==========================================
+ Hits          205      207       +2
  Misses          7        7

Impacted Files
Coverage Δ

django_summernote/widgets.py
95.38% <100%> (+0.14%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 75ea378...dd400ba. Read the comment docs.

This will fix #237

@clichedmoog it looks like this fixes #236, not #237 itself. Anyway, thanks for your contribution.

Yes fix for #236 my confusion.


Dummy test PR

Dummy for testing. Do not merge.

/azp run PowerFx-PR

Pull Request Test Coverage Report for Build 302219

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 55.684%

Totals

Change from base Build 302212:
0.0%

Covered Lines:
26242

Relevant Lines:
47127

💛  - Coveralls


Add TSSOP packages

Generated with parts-generator, see https://github.com/LibrePCB/librepcb-parts-generator/pull/28
I couldn't find a standard, so I based the values on the TSSOP family by TI: http://www.ti.com/packaging/docs/searchtipackages.tsp?packageName=SO

Great, the long-awaited TSSOP packages! :smile:
I didn't review them in detail yet, but so far I have some questions/comments:

Regarding standard: Did you see JEDEC MO-153?
The name follows a different pattern than SOIC, *QFP and DFN packages. Is this intended, and if yes, what's the reason?
From the description it's not clear what the last two numbers (after "L") in the name are actually meaning. Would be good to extend the description to explicitly mention these numbers.

The geometry itself is of course very nice since you could reuse the SOIC generator :)

Regarding standard: Did you see JEDEC MO-153?

Whoa, why is the JEDEC search totally useless? I searched for such a document for quite a while and didn't find it. Thanks! I updated all dimensions used according to JEDEC and added a few more packages.

The name follows a different pattern than SOIC, *QFP and DFN packages. Is this intended, and if yes, what's the reason?

IPC7351B vs IPC7351C Draft. I used the latter. I also think it's the better approach.
We can still rename the other packages later on to become more consistent.

From the description it's not clear what the last two numbers (after "L") in the name are actually meaning. Would be good to extend the description to explicitly mention these numbers.

It's lead length and width. I updated the generator.


Silence stdout during snakemake workflows

This PR runs snakemake in quiet mode (default is quite verbose), and since snakemake doesn't do it for us, also silences the underlying command line tools as well (which may not be necessary when run via a cluster).
The tool silencing is being done using the venerable Perl tool chronic (originally invented for use with cron), which will capture and suppress the stdout/stderr provided the tool has a zero return code. If the tool fails, the output is restored.
This does add another dependency and point of failure, so I would prefer snakemake handled it - see https://github.com/snakemake/snakemake/issues/3152
Note that chronic is part of the moreutils package which is in conda-forge, but at the time of writing has an undeclared perl dependency provided by the perl-ipc-run package which is currently in bioconda only. That in turn needs perl-io-tty which is in conda-forge, but not yet packaged for ARM. See https://github.com/conda-forge/moreutils-feedstock/issues/6
A possible alternative is a new chronic implementation in go, which is not yet packaged for conda - https://github.com/docwhat/chronic
The motivation is for the main public facing command line interface (CLI), where I intend to use a progress bar alone (which with these changes works nicely in the non-error case).
Type of change

[ ] Bug fix (non-breaking change that fixes an issue)
[x] New feature (non-breaking change that adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality not to work as expected)
[ ] This change requires a documentation update
[ ] This is a documentation update

Action Checklist

[x] Work on a single issue/concept (if there are multiple separate issues to address, please use a separate pull request for each)
[x] Fork the pyani-plus repository under your own account (please allow write access for repository maintainers)
[x] Set up an appropriate development environment (please see CONTRIBUTING.md for this repository)
[x] Create a new branch with a short, descriptive name
[x] Work on this branch

[x] style guidelines have been followed (please see CONTRIBUTING.md for this repository)
[x] new code is commented, especially in hard-to-understand areas
[ ] corresponding changes to documentation have been made
[ ] tests for the change have been added that demonstrate the fix or feature works

[x] Test locally with pytest-plus -v non-passing code will not be merged
[x] Rebase against origin/master
[x] Check changes with linting/formatting tools before submission (please see CONTRIBUTING.md for this repository)
[x] Commit branch
[x] Submit pull request, describing the content and intent of the pull request
[x] Request a code review
[x] Continue the discussion at Pull requests section in the pyan-plus repository

GitHub Actions failures under Linux:
BEGIN failed--compilation aborted at /home/runner/miniconda3/envs/pyani-github/bin/chronic line 37.

Says is it using:
moreutils-0.5.7            |                1          27 KB  bioconda

I did test this on our Linux server and its worked, but here I have version 0.67 from conda-forge. In my local copies of the script, line 37 is still part of the help text.

The response at https://github.com/snakemake/snakemake/issues/3152 seems to have misunderstood your issue, and to think you want to log errors using echo .

Is it possible to avoid the additional dependency by wrapping calls to each tool in a function using subprocess.run()? I'm thinking that the function might:

checks the return code
log stdout/stderr to a pyani-plus logger if the return code is non-zero

That would give us flexibility to define return codes that are nonero but not in error, for any non-standard tools we might come across.

Under https://docs.python.org/3/library/subprocess.html there is the note:

If check is true, and the process exits with a non-zero exit code, a CalledProcessError exception will be raised. Attributes of that exception hold the arguments, the exit code, and stdout and stderr if they were captured.

Can the main script see errors/logs from the workflow scripts?

Let's merge this in the interim, but with a view to testing the feasibility of the subprocess.run(check=True) -style wrapper, which may let us log tool run failures gracefully in the pyani-plus logger.


[Bug]: Error running playwright install

Playwright version
1.12.0
Operating system
Linux
What browsers are you seeing the problem on?
No response
Other information
.NET 5 app,
What happened? / Describe the bug
Error when running playwright install Failed to install browsers #21 1.129 Error: Failed to download chromium, caused by #21 1.129 Error: certificate is not yet valid
Everything worked 3 days before

Which Linux distribution are you using? This is likely because your Linux installation has not the latest root certificates locally, so an apt-get update && apt-get upgrade should probably fix it.

NAME="Ubuntu"
VERSION="20.04.2 LTS (Focal Fossa)"
ID=ubuntu
ID_LIKE=debian
PRETTY_NAME="Ubuntu 20.04.2 LTS"
VERSION_ID="20.04"
HOME_URL="https://www.ubuntu.com/"
SUPPORT_URL="https://help.ubuntu.com/"
BUG_REPORT_URL="https://bugs.launchpad.net/ubuntu/"
PRIVACY_POLICY_URL="https://www.ubuntu.com/legal/terms-and-policies/privacy-policy"
VERSION_CODENAME=focal
UBUNTU_CODENAME=focal
This is my linux version. It worked on Friday with the same configuration. I run it in docker container. I have some issues running apt-get update when building the image. is there any other alternative for this?

I would also verify if your time on your host is correct. In the best case you should use a NTP time server.

Where are you running the docker containers on? Is it on Windows? There are reports of time drift being a common problem for Docker Desktop. Can you check?

Closing due to inactivity.


Add Discord invite to profile README

Should "Find us on GitHub" be removed, since we're already on GitHub?


Example for External Memory support

The documentation for interop and external memory support is rather sparse and I can't get it to work, so I would like to ask if example code can be provided (in the documentation) on how to set it up.
What I have right now is roughly:
// create an example image creation struct to get the correct memory type for the pool
VkImageCreateInfo exampleImgInfo{};
exampleImgInfo.sType = VK_STRUCTURE_TYPE_IMAGE_CREATE_INFO;
exampleImgInfo.imageType = VK_IMAGE_TYPE_2D;
exampleImgInfo.format = VK_FORMAT_R32G32B32A32_SFLOAT;
exampleImgInfo.tiling = VK_IMAGE_TILING_OPTIMAL;
exampleImgInfo.sharingMode = VK_SHARING_MODE_EXCLUSIVE;
exampleImgInfo.usage = VK_IMAGE_USAGE_SAMPLED_BIT | VK_IMAGE_USAGE_STORAGE_BIT | VK_IMAGE_USAGE_TRANSFER_SRC_BIT;
exampleImgInfo.samples = VK_SAMPLE_COUNT_1_BIT;
exampleImgInfo.flags = 0;
exampleImgInfo.mipLevels = 1;
exampleImgInfo.arrayLayers = 1;
exampleImgInfo.initialLayout = VK_IMAGE_LAYOUT_UNDEFINED;
exampleImgInfo.queueFamilyIndexCount = 1;
exampleImgInfo.pQueueFamilyIndices = &QfIndices.GraphicsFamily.value();
exampleImgInfo.extent = VkExtent3D(1, 1, 1);

// allocation for the example image
VmaAllocationCreateInfo allocCreateInfo = {};
allocCreateInfo.usage = VMA_MEMORY_USAGE_AUTO;

uint32_t memTypeIndex;
vmaFindMemoryTypeIndexForImageInfo(Device->MemoryAllocator, &exampleImgInfo, &allocCreateInfo, &memTypeIndex);

// create an extra pool which will handle memory and allocations for shared resources
PoolCreateInfo.memoryTypeIndex = memTypeIndex;

VkExportMemoryAllocateInfo ExportMemAllocInfo{};
ExportMemAllocInfo.sType = VK_STRUCTURE_TYPE_EXPORT_MEMORY_ALLOCATE_INFO;
#ifdef _WIN32
	ExportMemAllocInfo.handleTypes = VK_EXTERNAL_MEMORY_HANDLE_TYPE_OPAQUE_WIN32_BIT;
#else
	ExportMemAllocInfo.handleTypes = VK_EXTERNAL_MEMORY_HANDLE_TYPE_OPAQUE_FD_BIT;
#endif
PoolCreateInfo.pMemoryAllocateNext = &ExportMemAllocInfo;

VkResult result = vmaCreatePool(Device->MemoryAllocator, &PoolCreateInfo, &Device->ImageInteropPool);

// ...
VkImageCreateInfo createInfo{};
createInfo.sType = VK_STRUCTURE_TYPE_IMAGE_CREATE_INFO;
createInfo.extent = VkExtent3D(1200, 800, 1);
createInfo.format = VK_FORMAT_R32G32B32A32_SFLOAT;
createInfo.imageType = VK_IMAGE_TYPE_2D;
createInfo.initialLayout = VK_IMAGE_LAYOUT_UNDEFINED;
createInfo.mipLevels = 1;
createInfo.arrayLayers = 1;
createInfo.tiling = VK_IMAGE_TILING_OPTIMAL;
createInfo.usage = VK_IMAGE_USAGE_SAMPLED_BIT | VK_IMAGE_USAGE_STORAGE_BIT | VK_IMAGE_USAGE_TRANSFER_DST_BIT | VK_IMAGE_USAGE_COLOR_ATTACHMENT_BIT;
createInfo.samples = VK_SAMPLE_COUNT_1_BIT;
createInfo.sharingMode = VK_SHARING_MODE_EXCLUSIVE;
createInfo.flags = 0;

VkExternalMemoryImageCreateInfo extMemInfo{ VK_STRUCTURE_TYPE_EXTERNAL_MEMORY_IMAGE_CREATE_INFO };
#ifdef WIN32
	extMemInfo.handleTypes = VK_EXTERNAL_MEMORY_HANDLE_TYPE_OPAQUE_WIN32_BIT;
#else
	extMemInfo.handleTypes = VK_EXTERNAL_MEMORY_HANDLE_TYPE_OPAQUE_FD_BIT;
#endif
createInfo.pNext = &extMemInfo;

VmaAllocationCreateInfo allocInfo{};
allocInfo.usage = VMA_MEMORY_USAGE_AUTO;
allocInfo.pool = Device->ImageInteropPool;

VkResult result = vmaCreateImage(Device->MemoryAllocator, &createInfo, &allocInfo,
	&VulkanImage, &Allocation, nullptr);

but this crashes when running vmaCreateImage. The validation layers tell me

vkCreateImage: pCreateInfo->pNext chain includes a structure with unknown VkStructureType<PHONE_NUMBER>); Allowed structures are [VkBufferCollectionImageCreateInfoFUCHSIA, VkDedicatedAllocationImageCreateInfoNV, VkExportMetalObjectCreateInfoEXT, VkExternalFormatANDROID, VkExternalMemoryImageCreateInfo, VkExternalMemoryImageCreateInfoNV, VkImageCompressionControlEXT, VkImageDrmFormatModifierExplicitCreateInfoEXT, VkImageDrmFormatModifierListCreateInfoEXT, VkImageFormatListCreateInfo, VkImageStencilUsageCreateInfo, VkImageSwapchainCreateInfoKHR, VkImportMetalIOSurfaceInfoEXT, VkImportMetalTextureInfoEXT, VkOpaqueCaptureDescriptorDataCreateInfoEXT, VkOpticalFlowImageFormatInfoNV, VkVideoProfileListInfoKHR]. This error is based on the Valid Usage documentation for version 250 of the Vulkan header.  It is possible that you are using a struct from a private extension or an extension that was added to a later version of the Vulkan header, in which case the use of pCreateInfo->pNext is undefined and may not work correctly with validation enabled The Vulkan spec states: Each pNext member of any structure (including this one) in the pNext chain must be either NULL or a pointer to a valid instance of VkBufferCollectionImageCreateInfoFUCHSIA, VkDedicatedAllocationImageCreateInfoNV, VkExportMetalObjectCreateInfoEXT, VkExternalFormatANDROID, VkExternalMemoryImageCreateInfo, VkExternalMemoryImageCreateInfoNV, VkImageCompressionControlEXT, VkImageDrmFormatModifierExplicitCreateInfoEXT, VkImageDrmFormatModifierListCreateInfoEXT, VkImageFormatListCreateInfo, VkImageStencilUsageCreateInfo, VkImageSwapchainCreateInfoKHR, VkImportMetalIOSurfaceInfoEXT, VkImportMetalTextureInfoEXT, VkOpaqueCaptureDescriptorDataCreateInfoEXT, VkOpticalFlowImageFormatInfoNV, or VkVideoProfileListInfoKHR (https://vulkan.lunarg.com/doc/view/<IP_ADDRESS>/windows/1.3-extensions/vkspec.html#VUID-VkImageCreateInfo-pNext-pNext)

but that explcitily lists VkExternalMemoryImageCreateInfo which is what I have been using, so I don't know why this fails.

VMA provides help in memory allocation, but for learning correct usage, I recommend to start from bare Vulkan and its documentation. You can try to do the interop using Vulkan functions only: vkAllocateMemory, vkCreateImage, etc. to exclude the possibility of experiencing bugs in VMA. When it works, you can switch to using VMA for these interop images for convenience.
One possible issue I can see in your code is that you attach structure VkExternalMemoryImageCreateInfo to VkImageCreateInfo when creating the actual image, but not when doing "example image info" and calling vmaFindMemoryTypeIndexForImageInfo. You should use it there as well, because structures in pNext chain like this one can influence what memory types are supported.
Are you sure that VK_IMAGE_TILING_OPTIMAL is supported for interop? Maybe try VK_IMAGE_TILING_LINEAR as well.

Thank you for the hints, I have tried both the pNext addition in the example image and the TILING_LINEAR, but the crash is still the same. Regardless, I will take a look the bare Vulkan interop usage again.

I actually found the reason for the crash, so for completeness sake: the above code will work (or at least run without crashes), but I had simplified the debug code a bit and some of my creation structs were out of scope by the time of creation. This would lead to the vulkan error and VMA crash.

Thanks for the information. You likely met the case that the documentation of VmaPoolCreateInfo::pMemoryAllocateNext warns about:
https://gpuopen-librariesandsdks.github.io/VulkanMemoryAllocator/html/struct_vma_pool_create_info.html#abf71afe846790f72d1860e0afb12b883

Structures pointed by this member must remain alive and unchanged for the whole lifetime of the custom pool.


Feature/cluster without pipeline

@dim I would like to merge this (after squashing the commits). What do you think?

Looks OK, do you want me to add a separate PR for the ClusterPipeline?

Yeah, separate PR would be nice. Going to squash and merge it.

Made the tests more robust in https://github.com/go-redis/redis/commit/2cd5ac188806761fd736ee2e020dfd08236cff1e#diff-a0c7225d6bebd1194ed175feb4da9d2e


audio manager 0.8.2 not working in android

im add plugin but not working  in Android  , but working good in ios please  help me .
this my version  :
Doctor summary (to see all details, run flutter doctor -v):
[✓] Flutter (Channel stable, 2.2.2, on macOS 11.6 20G165 darwin-arm, locale en-SD)
[✓] Android toolchain - develop for Android devices (Android SDK version 31.0.0)
[✓] Xcode - develop for iOS and macOS
[✓] Chrome - develop for the web
[!] Android Studio (version 2020.3)
✗ Unable to find bundled Java version.
[✓] Connected device (2 available)
! Doctor found issues in 1 category.

Same here

i'm use audio_service: ^0.17.0


descriptors: fix analysis of missing signatures post #575

Needs more testing but that should do the trick: we need to take into account the derivation path appended to the xpub in addition to the one from the origin!

Rebased on master to fix the flaky functional test in CI.

Addressed @edouardparis's review comments and rebased on master.

Reverted the change that broke the MSRV.

ACK 10acc482e15c0f5832da576baddd10ce44dc85df -- Edouard ACK'd the child PR at https://github.com/wizardsardine/liana/pull/599#pullrequestreview-1571990532


feat(card): add logo variant

Related Ticket(s)
DDS Consulting Issue: https://github.com/carbon-design-system/carbon-for-ibm-dotcom/issues/7139
HC JIRA Ticket: https://jsw.ibm.com/browse/HC-2312
Description

This PR adds a new variant within the Card component called Card logo.

Changelog
New Components/Props

<dds-image-logo> - this component extends from <dds-image> and is needed because of styling requirements.

Removed

N/A

Testing Instructions

Visit the Card UI component with Logo variant - ?path=/story/components-card--logo
Ensure that the preview matches with the design specs

Design and functional spec Box folder

Thanks @proeung! Not opposed to creating dds-image-logo, but wondering if we just want to make this within the card directory such as dds-card-logo or a logo prop in dds-image ?
cc: @IgnacioBecerra

@ariellalgilmore Thanks for the review! What you're suggesting makes sense as well. I created dds-image-logo based on my discussion with @IgnacioBecerra and the potential future usage of that component, but I'm open to adding a logo prop in dds-image or creating a dds-card-logo within the /card directory if these implementations make more sense. Let me know which direction I should take.

@proeung FYI we're checking with the other devs to get their thoughts on this as well, will keep you updated 👍

@proeung We agreed that it was better to extend the component since the adding a prop/attribute should mainly affect that specific component (like hidden, disabled) instead of changing in favor of another component. So your current changes are good, just a little thing, could you move the dds-image-logo file to the card folder? Just so we can have all the files needed for Card in one place, especially to be added to the index.ts file 😄

@IgnacioBecerra No prob!
Looks like we just need design QA approval for this PR. @skuruvil Can you help take a look? Thanks!

@proeung Here are some of my observations. Please let me know if you have any questions.

Text link CTA  is optional to use or have the entire card area be interactive. I think we don't have an Icon CTA variant. We have defined the interactive states as well in the design spec (Since we have the logo/image, interactive states applied only to the border but not to the background)

We have one more optional variant with a heading.  I can see the card heading option in the knobs but it's not reflecting on the preview.

Right now the logo/image size seems to be bigger, it is supposed to be 160px x 80px fixed in all the breakpoints

The space between the logo and the eyebrow is 24px in design spec, right now it seems like 16px.

@small we are not adding 32px padding to the text width but it will be full width

The minimum aspect ratio we have set as 4:3 in design spec, in the preview it seems like 1:1

@skuruvil I just pushed up a commit that should address all of the design QA feedback that you've listed above. Can you take a look again?

@proeung Everything looks great to me, thanks. I found a small issue. The bottom margin seems to be more in the preview. In design spec it's 32pix total bottom margin however in the SB preview it seems like 32px + 16px padding. I am thinking that could be the one reason that the 4:3 minimum ratio is still not achieved, there is a slight difference in the height.

@proeung looks perfect to me. Thanks

I have read the DCO document and I hereby sign the DCO.

recheck

@proeung looks like CI checks are failing for web components, it's having a hard time finding the image being imported:

@proeung thanks for changing!
It looks like there are merge conflicts now with @ariellalgilmore 's latest PR merged in.

@jeffchew @ariellalgilmore Just resolved the merge conflicts. Can you take a look again?

Looks good! Wondering though if we can update the knobs to have the same format though as the other stories now? Also, @skuruvil do you think the logo variant should be it's own story or maybe just an additional knob under "Add image:" then we could add "Add logo:"

@ariellalgilmore My understanding is that "Logo" is its own variant of the Card component since it has different design specs and the mouse over effect is slightly different from your regular card or static variants (see link).
For the purpose of moving these changes forward in the v.128 release for AEM adoption, I think we can capture any follow-up enhancements for the settings of the knobs in a different issue.

@proeung okay thanks! Yeah let's get this one in

Waiting for the React CSB examples job to run and if it looks good, will get this one merged in!


AboutToQuit gets eaten with Spyder 5.1.5 and Python 3.9

Problem Description
AboutToQuit not executed with Spyder 5.15, Python 3.9.8, Qt 5.15.1, PyQt5 5.15.1 (complete installation of Winpython64-<IP_ADDRESS>post1.exe). However, working when running from command prompt.
AboutToQuit executed properly with Spyder 5.15, Python 3.8.9, Qt 5.12.10, PyQt5 5.12.3 (complete installation of Winpython64-3.8.9.exe).
What steps reproduce the problem?
Run the simple script below and close the window. Observe the terminal. In the correct case you will get "stopping...", in the incorrect case you won' t get "stopping...".

def stopApplication():
    print ("stopping...")

app = QApplication([])
app.aboutToQuit.connect(stopApplication)
label = QLabel("Hello World!")
label.show()
app.exec_()

Versions

Spyder version: 5.1.5
Python version: 3.9.8
Qt version: 5.12.10
PyQt version: 5.12.3
Operating System name/version: Windows 10

Hi @torge2,
I'm unable to reproduce your issue, it is running with the correct case as you can see in the screenshot below,

Please try updating Spyder to 5.2.0, and let me know if the error persists in this version.

Updated to Spyder 5.2.0, Python 3.9.8 64 bit, Qt 5.12.10, PyQt5 5.12.3, Windows 10. Problem remains.
Still no problem when executing from CMD line.
It may have something to do with the spyder settings: IPython console-->Graphics-->Graphics backend.
I normally change the graphics backend from 'Inline'(Default) to 'Automatic' since I don' t want matplotlib graphs to be displayed in the console window.
The script it is working with 'Inline', but not with 'Automatic' or 'Qt5' with thes settings.

Well that makes sense because the app is then not quitting. The graphic backend uses a QApplication to work so the QApplication will not close.


WithPwm trait should be public

I writing a generic struct that takes a pwm channel to control a motor.
We've tried this code:
struct Motor<TIM: TimerExt, const C: u8> {
    pwm: PwmChannel<TIM, C>,
}

And I get the following error:
error[E0599]: the method `get_max_duty` exists for struct `PwmChannel<TIM, C>`, but its trait bounds were not satisfied
  --> base-roulante/src/main.rs:64:73
   |
64 |         let consigne = pid_correction / Self::MAX_CORRECTION * self.pwm.get_max_duty();
   |                                                                         ^^^^^^^^^^^^ method cannot be called on `PwmChannel<TIM, C>` due to unsatisfied trait bounds
   |
  ::: /home/fomys/.cargo/registry/src/github.com-1ecc6299db9ec823/stm32f1xx-hal-0.9.0/src/timer/pwm.rs:89:1
   |
89 | pub struct PwmChannel<TIM, const C: u8> {
   | --------------------------------------- doesn't satisfy `PwmChannel<TIM, C>: PwmPin`
   |
   = note: the following trait bounds were not satisfied:
           `TIM: stm32f1xx_hal::timer::sealed::WithPwm`
           `TIM: stm32f1xx_hal::timer::sealed::WithPwm`
           which is required by `PwmChannel<TIM, C>: PwmPin`

The ideal resolution would be to add trait bound with WithPwm trait, but it's impossible as it's a sealed trait.
Shouldn't it be public in order write this trait bound ? If this isn't the case, how should I resolve ?

Yeah. Generic code with sealed trait is often problematic.
As fast fix you could use get_max_duty from PwmPin:
https://github.com/stm32-rs/stm32f1xx-hal/blob/f9b24f4d9bac7fc3c93764bd295125800944f53b/src/timer/hal_02.rs#L136

To use PwmPin I have to add the trait bound PwmPin<Duty = u16> as the Duty is also generic.
Should I make a PR to make WithPwm public ?


Automatic creation of devices when populating bays

Issue type
[x] Feature request
[ ] Bug report
[ ] Documentation
Environment

Python version:  3.4.5
NetBox version:  2.1.3

Description
A detailed description of the proposed functionality
I am struggling a bit with the concept that I need to pre-create a device for e.g. every line card I want to populate to a switch.
For more conveniance there could be some auto-generated device if I populate a device bay. In my idea this would add a drop-down for the device type and a "auto-genarate" button to the populate menu - in addition to "save" and "cancel". Anybody who wants to do assign an existing device could just use the menu as before.
This button would then create a device with the same properies as the parent, the selected type and device name could be "parent devicename"-"bay name", size 0.
A use case for the new feature
Populate new infrastructure more quickly
A rough description of any necessary changes to the database schema
None, just UI change and coding
Any relevant third-party libraries which would be needed
No

I am struggling a bit with the concept that I need to pre-create a device for e.g. every line card I want to populate to a switch.

NetBox does not currently support modeling line card within a device; see #824. If you're trying to use the device model to represent line cards, it's not going to work well.

For more conveniance there could be some auto-generated device if I populate a device bay.

You would still need to select a manufacturer, device type, and role, and likely set some other attributes as well. Trying to fit all this on the same page as creating a device bay would be convoluted.


add lean direction for trees >10cm with lean angle >15degrees

@jess-shue , could we add a lean direction (compass bearing)  for trees in the mortality census (>10cm) with lean angle >15degrees? This is a variable that Dan wants to add to the mortality census (for all sites).

@teixeirak That should be do-able. I'm working very hard to fix the recruits layer right now. Do you have a thought on when they will start collecting mortality? Also, what about training? We did not go through that protocol thoroughly while I was there...(hence why I asked if Dan's group was swinging through).

There are few stems with that much lean, so it's not an urgent fix.
Training for & starting the mortality census is another issue. I'll open one.

@teixeirak  The lean direction will be recorded in degrees correct? Or, will it be N, NE, E, SE, S etc.? I need to know the data type to add this field.

the direction should be recorded in Degrees azimuth
On Wed, Apr 19, 2023 at 12:27 PM jess-shue @.***> wrote:

@teixeirak https://github.com/teixeirak The lean direction will be
recorded in degrees correct? Or, will it be N, NE, E, SE, S etc.? I need to
know the data type to add this field.
—
Reply to this email directly, view it on GitHub
https://github.com/SCBI-ForestGEO/2023census/issues/25#issuecomment-1515032473,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ADK3BJM6W6F5DHS6WQSHZLTXCAG7BANCNFSM6AAAAAAW5PD5L4
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>


Error when joining or creating singleplayer world: "Client disconnected with reason: Failed to synchronize client with the server!"

Sorry if this is the wrong place but i'm so confused and nowhere on google has anything helpful. I'm thinking it's a quilt problem but it's hard to be sure. When a world is done loading or creating (100%) it shows "mismatched entries for state of minecraft:block" and brings me to the multiplayer server screen (?)
latest.log
I had it briefly fixed after removing Bedrockify so I put like 5 other mods back in (since they must not have been causing the problem) and it hasn't worked since then even after re-removing those mods. So it's exactly as it was when it did work. It doesn't help to delete the config folder or any other tricks. This is really weird for singleplayer and idk what exactly I should do to fix it

Quilt Mappings isn't the place to file issues like this, as it's more of a mod-dev-focused part of quilt. I suggest you join the Discord and ask in the #quilt-basic-support or #quilt-player-support channels, as helpers will be able to better help you there!

This should actually be moved to QFAPI probably. You can see a thread I made on a mod I'm making causing this issue. And it is, very, very annoying.

^ this was a rare occurrence, so a GUI ive never seen before


Pass current namespace to argo via environment variable

Reference Issues or PRs

Closes #2256 (it turned out to be an issue with hardcoded namespace in argo-scheduler)
Requires https://github.com/nebari-dev/argo-jupyter-scheduler/pull/7 (and new release of argo-jupyter-scheduler) to take effect
See https://github.com/nebari-dev/argo-jupyter-scheduler/issues/6 for context

What does this implement/fix?
Put a x in the boxes that apply

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds a feature)
[ ] Breaking change (fix or feature that would cause existing features not to work as expected)
[ ] Documentation Update
[ ] Code style update (formatting, renaming)
[ ] Refactoring (no functional changes, no API changes)
[ ] Build related changes
[ ] Other (please describe):

Testing

[ ] Did you test the pull request locally?
[ ] Did you add new tests?

Any other comments?

Hi @krassowski this LGTM, I just need to make sure all the vars are defined already and have some defaults. Then we can merge


Improve CI: check that the extension installs in VS2017 and VS2019 [skip changelog]

closes https://github.com/conan-io/conan-vs-extension/issues/96
closes https://github.com/conan-io/conan-vs-extension/issues/116
Playing with Appveyor we can create the extension in the first job using VS2019, upload the artifact and then get the artifact from the other jobs and install it in the corresponding VS version.
TODO:

Check that it is actually installed
Do something with the extension to know it works.
Uninstall and check it is not installed

initially I was going to use MSBuild tasks exposed from the vsix to verify it's correctly installed
however, it turns out it's not something recommended per https://blogs.msdn.microsoft.com/visualstudio/2010/06/09/vsix-best-practices/:
Some extensions still need to be installed by MSI: for example some of your files might have to be in a specific, well-known loca
tion, you might have a component like an MSBuild task that VSIX install doesn’t support, you might need to use binding redirection – see more information here

as installation location isn't something we have control over, I think it's not the way to go.
however, it turns out there is a simpler way - just expose command line switch for devenv.exe: https://docs.microsoft.com/en-us/visualstudio/extensibility/adding-command-line-switches?view=vs-2019
therefore, calling devenv.exe without our own switch may trigger extension to be loaded, and we may verify that it's actually installed and loaded.

I'm really worried about the test line . "$devenv" /ConanVisualStudioVersion /?. Sometimes it works and sometimes it doesn't print the version, so you get lots of false positives 😕
Besides that, I like the approach in three stages:

Build: build the vsix and run the tests
Test: testing with different VS images
Deploy: only for tags, upload the vsix generated in the first step to marketplace

Please, @SSE4 , review paying extra attention. I think it is ready although I'm still worried with the false negatives

About the other comments, I prefer to leave them there for the future... This PR already contains enough noise


fix(docs): Update unconstrained function call image

Update unconstrained function call image

Docs Preview
Hey there! 👋 You can check your preview at https://65df5462fb35cc23bfbf0c07--aztec-docs-dev.netlify.app

Benchmark results
No metrics with a significant change found.

Detailed results
All benchmarks are run on txs on the Benchmarking contract on the repository. Each tx consists of a batch call  to create_note and increment_balance, which guarantees that each tx has a private call, a nested private call, a public call, and a nested public call, as well as an emitted private note, an unencrypted log, and public storage read and write.
This benchmark source data is available in JSON format on S3 here.
Values are compared against data from master at commit 237f870c and shown if the difference exceeds 1%.
L2 block published to L1
Each column represents the number of txs on an L2 block published to L1.

Metric
8 txs
32 txs
128 txs

l1_rollup_calldata_size_in_bytes
54,212
214,436
855,332

l1_rollup_calldata_gas
259,904
1,019,276
4,060,136

l1_rollup_execution_gas
354,090
1,138,724
4,281,537

l2_block_processing_time_in_ms
1,200 (-1%)
4,574 (-10%)
17,915 (-2%)

note_successful_decrypting_time_in_ms
207 (+2%)
553 (-4%)
1,966

note_trial_decrypting_time_in_ms
20.9 (+30%)
90.5 (-24%)
167 (+1%)

l2_block_building_time_in_ms
16,025
63,520
257,704

l2_block_rollup_simulation_time_in_ms
12,263
48,701
198,374

l2_block_public_tx_process_time_in_ms
3,729 (+1%)
14,726
59,056 (+1%)

L2 chain processing
Each column represents the number of blocks on the L2 chain where each block has 16 txs.

Metric
5 blocks
10 blocks

node_history_sync_time_in_ms
15,185 (-1%)
28,818 (-2%)

note_history_successful_decrypting_time_in_ms
1,489 (+3%)
2,547 (-2%)

note_history_trial_decrypting_time_in_ms
172 (+10%)
230 (-12%)

node_database_size_in_bytes
19,128,400
36,507,728 (+1%)

pxe_database_size_in_bytes
29,923
59,478

Circuits stats
Stats on running time and I/O sizes collected for every circuit run across all benchmarks.

Circuit
circuit_simulation_time_in_ms
circuit_input_size_in_bytes
circuit_output_size_in_bytes

private-kernel-init
239 (-2%)
44,664
27,457

private-kernel-ordering
154 (-1%)
45,777
14,627

base-rollup
1,305
175,344
933

root-rollup
71.5 (-1%)
4,192
825

private-kernel-inner
305 (-1%)
73,099
27,457

public-kernel-app-logic
187 (-1%)
32,254
25,379

merge-rollup
5.76 (-1%)
2,712
933

Tree insertion stats
The duration to insert a fixed batch of leaves into each tree type.

Metric
1 leaves
2 leaves
8 leaves
16 leaves
32 leaves
128 leaves
64 leaves
512 leaves
1024 leaves
2048 leaves
8192 leaves

batch_insert_into_append_only_tree_16_depth_ms
9.86 (-1%)
12.7 (+10%)
14.6 (+15%)
17.0 (+2%)
22.3 (+1%)
61.7 (-24%)
N/A
N/A
N/A
N/A
N/A

batch_insert_into_append_only_tree_16_depth_hash_count
16.9
17.5
23.0
31.6
47.0
143
N/A
N/A
N/A
N/A
N/A

batch_insert_into_append_only_tree_16_depth_hash_ms
0.571 (-1%)
0.702 (+10%)
0.615 (+15%)
0.524 (+2%)
0.465
0.426 (-24%)
N/A
N/A
N/A
N/A
N/A

batch_insert_into_append_only_tree_32_depth_ms
N/A
N/A
N/A
N/A
N/A
81.5 (+11%)
46.0
234
449 (+1%)
874
3,426

batch_insert_into_append_only_tree_32_depth_hash_count
N/A
N/A
N/A
N/A
N/A
159
96.0
543
1,055
2,079
8,223

batch_insert_into_append_only_tree_32_depth_hash_ms
N/A
N/A
N/A
N/A
N/A
0.491 (+8%)
0.470
0.427 (+2%)
0.419
0.416
0.412

batch_insert_into_indexed_tree_20_depth_ms
N/A
N/A
N/A
N/A
N/A
100 (-1%)
55.8
338 (-1%)
665
1,320 (-1%)
5,226 (-1%)

batch_insert_into_indexed_tree_20_depth_hash_count
N/A
N/A
N/A
N/A
N/A
197
104
691
1,363
2,707
10,771

batch_insert_into_indexed_tree_20_depth_hash_ms
N/A
N/A
N/A
N/A
N/A
0.476
0.490
0.459 (-1%)
0.456
0.454 (-2%)
0.454 (-1%)

batch_insert_into_indexed_tree_40_depth_ms
N/A
N/A
N/A
N/A
61.9 (-1%)
N/A
N/A
N/A
N/A
N/A
N/A

batch_insert_into_indexed_tree_40_depth_hash_count
N/A
N/A
N/A
N/A
110
N/A
N/A
N/A
N/A
N/A
N/A

batch_insert_into_indexed_tree_40_depth_hash_ms
N/A
N/A
N/A
N/A
0.536
N/A
N/A
N/A
N/A
N/A
N/A

Miscellaneous
Transaction sizes based on how many contracts are deployed in the tx.

Metric
0 deployed contracts

tx_size_in_bytes
18,431

Transaction processing duration by data writes.

Metric
0 new note hashes
1 new note hashes

tx_pxe_processing_time_ms
2,548 (+1%)
1,297 (-1%)

Metric
0 public data writes
1 public data writes

tx_sequencer_processing_time_ms
0.0339 (-5%)
459


Update Usage in readme.md

Usage says we need to give parameters to pokecli.py, but that's not even possible anymore

It seems that none of the flags are working anymore? Or is it just me?

Because you have to use a config file, and it doesnt seem to be documented anywhere how it works

Alright, I see now.  Just have to delete the "example" off the end of the release_config.json and config.json.

yea should be updated.. and some functions are not added to the config file (like evolve etC) how do i still evolve in this case?

should be updated now


How do we specify paste entrypoints

[x] I have searched the issues of this repo and believe that this is not a duplicate.
[x] I have searched the documentation and believe that my question is not covered.

Question

How can I replicate the non-script / paste entrypoints? Specifically, for a pyramid project, I've got:
    entry_points={
        'paste.app_factory': [
            'main = someproject:main',
        ],

Is there a way to do this in poetry?

@viraptor this is done via the plugin section.
[tool.poetry.plugins."paste.app_factory"]
main = "someproject:main"

i wonder whether an entrypoints section in the docs for the pyproject.toml that points to the plugins and scripts sections would be helpful to avoid such confusions. i'm always looking for it in the sidebar, but have to search the whole page to find what i'm looking for.

For the record, there is a way to avoid the need for paste entry point with Pyramid: https://github.com/Pylons/pyramid/issues/3270#issuecomment-427417681
But I agree that entry points are still a useful feature for various use cases, so general-purpose packaging tools should support them.

I think this issue can be closed. Maybe a new issue could be open for documentation improvements as scripts versus entrypoints versus plugins seems to create a lot of confusion.

Hello all,
there is already a discussion about scripts/entrypoints in #241 and https://github.com/sdispater/poetry/pull/1504.
I see it like @pawamoy that this issue can be closed in favor of the others.
If someone disagree please let me know :)
fin swimmer

That other issue seems to be about scripts (I didn’t re-read all messages)
This one here was a question about entry point (which got answered, support is already there), so why not keep it open as a documentation ticket?

Hello @merwok ,
the issue tracker isn't the right place for a applications documentation. We need it in first place, to have an overview about what work needs to be done. Of course it contains a lot of knowledge by the time. But  if this is in general interested it should be put on the help page/documentation itself.
fin swimmer

I wasn’t saying to keep this ticket open to serve as documentation, but that the ticket is a doc bug, i.e. a request to enhance poetry’s doc and avoid other people asking the same question in the future.


CLOUDSTACK 9601: Upgrade: change logic for update path for files

For going from version A to version D, it uses to run the SQL files in
that order: A -> B -> C -> D -> A-cleanup -> B-cleanup -> C-cleanup ->
D-cleanup. If you had upgraded each version separatively you would have
run A -> A-cleanup -> B -> B-cleanup -> C -> C-cleanup -> D ->
D-cleanup.
This change the logic to follow the same path if you are jumping over
versions.
Signed-off-by: Marc-Aurèle Brothier<EMAIL_ADDRESS>

The second commit can be removed if the cleanup is not wanted.

This may break db upgrade, as the cleanup paths are run at the end. Can you prove if changing the sequence will be idempotent? Thanks.

@rhtyd Changing the sequence is only idempotent if you have been upgrading to each new versions step by step. If you jumped other versions, then the path is different for each original version. This fix wants to avoid such a difference.

@marcaurele I tend to agree with @rhtydthat it could break some of the upgrades. If I get it right with your proposed changes, upgrade scripts become obsolete since all the changes can be done in upgrade scripts.

@serg38 Not sure to understand what you mean with:

If I get it right with your proposed changes, upgrade scripts become obsolete since all the changes can be done in upgrade scripts.

You meant: If I get it right with your proposed changes, upgrade cleanup scripts become obsolete since all the changes can be done in upgrade scripts. ?

I'll try to make my point clearer with a better use case. Let say you were running version ACS 4.4.2 and wish to upgrade to 4.7.1. After installing the 4.7.1, when ACS starts for the first time you will execute SQL scripts in that order (case A):
schema-442to450.sql       -----> schema-442to450-cleanup.sql
      |                  |             |
      v                  |             v
schema-450to451.sql      |       schema-450to451-cleanup.sql
      |                  |             |
      v                  |             v
schema-451to452.sql      |       schema-451to452-cleanup.sql
      |                  |             |
      v                  |             v
schema-452to460.sql      |       schema-452to460-cleanup.sql
      |                  |             |
      v                  |             v
schema-460to461.sql      |       schema-460to461-cleanup.sql
      |                  |             |
      v                  |             v
schema-461to470.sql      |       schema-461to470-cleanup.sql
      |                  |             |
      v                  |             v
schema-470to471.sql >----        schema-470to471-cleanup.sql

But if you would have updated to each versions, one after the other, you would have run those scripts in that order (case B):
schema-442to450.sql -----> schema-442to450-cleanup.sql
                                 |
       --------------------------
      |
      v
schema-450to451.sql -----> schema-450to451-cleanup.sql
                                 |
       --------------------------
      |
      v
schema-451to452.sql -----> schema-451to452-cleanup.sql
                                 |
       --------------------------
      |
      v
schema-452to460.sql -----> schema-452to460-cleanup.sql
                                 |
       --------------------------
      |
      v
schema-460to461.sql -----> schema-460to461-cleanup.sql
                                 |
       --------------------------
      |
      v
schema-461to470.sql -----> schema-461to470-cleanup.sql
                                 |
       --------------------------
      |
      v
schema-470to471.sql -----> schema-470to471-cleanup.sql

Since case B is that most developer would expect when fixing bugs and doing changes, but case A is the most common case of production upgrade, I wanted to correct the algorithm so that everyone will follow the same route (case B).
Most -cleanup.sql scripts are either empty or only updating the configuration table, so it's safe. There is only one possible problematic script: https://github.com/apache/cloudstack/blob/master/setup/db/db/schema-481to490-cleanup.sql today. This one does change views, which IMO was a mistake to put in the cleanup script file, it should have gone into schema-481to490.sql (@rhtyd ?). Leaving the mechanism as it is today would leave people with a possible bug while upgrading from any version prior to 4.9.0 if any future SQL script was to change the views modified inside schema-481to490-cleanup.sql because of scenario case A. Did I lost people there?
Any comment @remibergsma @DaanHoogland @syed @nvazquez ?

@marcaurele your point is clear and valid. I see that the change worries people as it will actually change existing upgrade paths.
@serg38 @marcaurele 's version of your comment doesn't hold if changes in java are encoded as well!
/me about to look at the code

LGTM but
I hope you appreciate the concerns @marcaurele , on the other hand let's fix what breaks and make sure the 4.9 to 4.10 works with this. We can always advice to upgrade to 4.9 before going up.

btw @marcaurele @rhtyd idempotent will only be possible if we encode it. It is not encoded in older upgrades. Unless we clean those upgrades up we will have some issues.

@karuturi I think this should go in. Even being a bit of a risk, it will potentially reduce the support hours on upgrades.

As a reminder for -cleanup SQL scripts:

We rarely need cleanup scripts, only when some field/value is required during the data migration and has to be dropped later on.

https://cwiki.apache.org/confluence/display/CLOUDSTACK/DB+Upgrade+in+CloudStack

I agree with @DaanHoogland , as @marcaurele mentioned, the only file we need to worry about is schema-481to490-cleanup.sql the rest of them are either empty or change the configuration where the order of execution doesn't really matter. Looking at it briefly it looks like it modifies ovs_tunnel_network table which is used to manage OVS tunnels when using non-vxlan isolation. I've never seen anyone use this in production. Would be useful if we can find someone who has used this before. Or if no one is using, it is LGTM from me as well.

@syed I would prefer to move what's inside schema-481to490-cleanup.sql to the end of the file schema-481to490.sql as it would have been the way of processing during an update from 481 to 490.
If I get the go about the move, I'll do it too in this PR.

@syed the -cleanup scripts are for removing data that had been migrated, not for temporary tables. also a use case for those may be if things are done partly in the migrate script and partly in the migrate class, though I can't think of a real instance of that use case.
as for the ovs-tunnel code, we don't have to loose that, do we? SO even with people using it we can apply this.

@BlueOrangUtan package

@BlueOrangUtan help

@blueorangutan package

@borisstoyanov a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

Packaging result: ✔centos6 ✔centos7 ✔debian. JID-532

I looked at the code inside Upgrade481to490.java and I cannot understand why the table alterations have been made inside the Java class instead of the SQL file. Because now we cannot move the code from the -cleanup without changing that class too, other the column role_id won't be present when creating the account_view.
To make the change transparent, I'll have to change those too. I'll push another commit for that.

@blueorangutan test

Forget my last comment, the files can remains as they are.

@marcaurele Nice improvement, thanks! Tested it and works as you described. LGTM.

@DaanHoogland Can you post test results?

@blueorangutan test

@DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

@marcaurele can we have a unit test to confirm that this does not break upgrade for older systems, also by changing the order for all older versions, the way someone would upgrade from say 4.3 to 4.10, will be different from someone who upgraded from 4.3->4.9->4.10 -- this may have side effects.

@rhtyd I don't see how I could write such a test case. My point is exactly what you're saying, the upgrade would be different today for anyone who comes from an older version, which I don't think you're currently testing. I want to avoid such situation, therefore I'm pushing this PR to stop having different upgrade paths.
Can you be more explicit in what you think can become a problem compared to the current situation we're in today?

Actually, BVT is not going to verify this as this is db upgrade related and travis would have tested it.
I am merging this.

@marcaurele I appreciate the cleanup, it should have been like this from the beginning but since we've the workflow to execute all the upgrades first and then the cleanup. In https://github.com/apache/cloudstack/blob/master/setup/db/db/schema-481to490-cleanup.sql the views are executed at the end because certain columns are added by the java based upgrade path and views can only access them after the script/java-based-upgrade is complete. I think with this change future db upgrade paths need to written carefully.
I've no objections with the overall goal to cleanup the sequence logic, though I have a concern that this might cause upgrade regressions in some environments as writing upgrade validation tests may not be possible. /cc @DaanHoogland @karuturi

@rhtyd I don't see how your concern is more true for the new code by @marcaurele then it is true for old code. cleanup is still going to be executed after the scripts, is it? only directly after instead of waiting for unrelated upgrade scripts to complete as well. We never have and never can have full coverage of upgrades as every cloud is a different snowflake. So we'll need to fix problems after intitial release most of the time. That is no worse or better with this code it is just a little more predictable.

1768.network.results.txt
1768.vpc_routers.results.txt
just for form @karuturi . I see failures in network but can not relate these to the upgrades

Thanks everyone. merging this now.


Document the theme compatibility

As required in  https://www.jenkins.io/doc/book/managing/ui-themes/#information-for-theme-developers, themes should have explicit compatibility documentation

Documented here:
https://github.com/jenkinsci/dark-theme#browser-compatibility


Feature/ionic template

Changes proposed in this Pull Request:

Add ionic template
Wrap's angular templates with ionic-wrapper + resources

Running into this issue when trying to copy over the auth template.

I forgot to mention that this will only work with the @beta blank and @beta authentication templates.
pxb new ionic --template=routing

Running into this issue when trying to copy over the auth template.

same here

I didn't run anything yet...just looked at the code

is it ok that we can run with beta or alpha with calling @X.X.X
pxb new ionic --template=angular-template-blank@beta works just wondering

is it ok that we can run with beta or alpha with calling @X.X.X
pxb new ionic --template=angular-template-blank@beta works just wondering.
also forgot, I have a package-lock rather than a yarn lock

I used the same template parsing logic as the new angular command so these should work:
$ pxb new ionic --template=routing
$ pxb new ionic --template=routing@alpha
$ pxb new ionic --template=routing@beta
$ pxb new ionic<EMAIL_ADDRESS>
I didn't test this out with a local template though.

I would be careful using the @{{version}} & @latest commands though because the older versions of the angular templates don't have a file structure that will work with the ionic-wrapper logic that was added.  I just tried this and ran into an error because the CLI tried to edit a file that didn't exist.

what about the package-lock? I have package-lock and not a yarn-lock...

when I run ionic cordova run ios it defaults to 14.4 iPod touch. The blank template loads and displays fine but I would rather have it run on a iPhone 12.
For me I have to run ionic cordova run ios --list (displays all the target mac addresses)
Then I run ionic cordova run ios --target=xxxxx.xxxx.xxxx (for my iPhone 12)
I end up with this....

also on my system I see in the terminal....
warning: block implicitly
retains 'self'; explicitly mention 'self' to indicate this is intended behavior [-Wimplicit-retain-self]
if (!_destroyed) {
^
self->
/Users/e0458886/pxblue/pxblue-cli/ion4/platforms/ios/MyApp/Plugins/cordova-plugin-splashscreen/CDVSplashScreen.m:502:46: warning: block implicitly
retains 'self'; explicitly mention 'self' to indicate this is intended behavior [-Wimplicit-retain-self]
if (!_destroyed) {
^
self->
and further down the output....
warning: 'setStatusBarStyle:' is
deprecated: first deprecated in iOS 9.0 - Use -[UIViewController preferredStatusBarStyle] [-Wdeprecated-declarations]
warning: implicit conversion loses
integer precision: 'UIStatusBarStyle' (aka 'enum UIStatusBarStyle') to 'int' [-Wshorten-64-to-32]
vc.sb_statusBarStyle = [NSNumber numberWithInt:style]
warning: 'setStatusBarHidden:' is
deprecated: first deprecated in iOS 9.0 - Use -[UIViewController prefersStatusBarHidden] [-Wdeprecated-declarations]
[app setStatusBarHidden:YES];

what about the package-lock? I have package-lock and not a yarn-lock...

The package-lock is because the project is generated using the ionic CLI and not the angular CLI.
That IOS looks funky, that's a good catch.  I'll need to add some styles to the toolbar and drawer to fix this.
The warnings you see, I have no idea.  Any warning that you see inside cordova plugins will require more research outside of this story.


bump to golang 1.21 and k8s to 1.29

Jira: https://issues.redhat.com//browse/OSPRH-6501

/test glance-operator-build-deploy-kuttl


fix item size on re-measuring

If the style width or height is set to 'auto', it will override values, that were probably defined in css for this item. Setting it to null allows to use default width/height of the item.

Can't merge this as-is. If you're interested in collaborating more on supporting this new edge-case, let's talk more! I'm going to close this PR for now though 👍


Add filtering by undefined and fix searching by name

Closes #2711
Closes #2712

Fixed a bug where filter categories would be disabled if their first value was undefined
Fixed display of undefined values in data across the app (in all tables, filter dialogs, and chips). Empty data is now represented by -
Fixed a bug in the filterText function that didn't allow searching by name with the new object structure (name can be a function instead of a string). The function now finds the row's value as other filtering functions do - with field.value(row) or row[field.value], which supports both strings and functions.
Fixed a styling bug that adjusted content when chips appeared. ChipGroup is now set at 40px
Changes in tests allow for us to change what the filter separator is without breaking everything. I also added a test in ChipGroup to test if changing chips that end with the filter separator add a - to properly display undefined.

Quick vid showing filtering and searching on the notifications page:
https://user-images.githubusercontent.com/65822698/188746495-ef1d15b4-91bf-4134-b7fd-e2d9f9778a95.mov

How the user determine which fields are searchable? I see the textSearchable prop, but only as a developer, is there a visual indication for the fields you can search? The first thing I tried searching was by channel and type, it didn't work. Then I read that search is enabled only for names.

If using the Chip component imported from Material-UI causes such problems, can we just create our own Chip component which has two props, label and value (or maybe not label to avoid confusion with the original Chip component), and combines them as the label of the original Chip  component it renders with a filterSeparator const, like <OriginalChildComponent label={${OurChipComponentLabelProp}${filterSeparator}${OurChipComponentValueProp}}>? So, we can always know that we are not messing up a real value.

Created some follow-up issues - for now I've removed the hack in ChipGroup and left the filterByText function as is

The UI tests are failing, including locally for me.

Is it expected behavior that an empty filter dialog is displayed for the events table? I don't think it's specific to this PR.
I remember fixing sorting in the events table but don't remember working with filters in it. Is the events table supposed to have filters or should we add hiding the filter dialog button for it?

@opudrovs
"Not Ready" wrapping - I don't believe it's intentional that it's wrapping, but I also don't see any limits on the width of the status column
Events Table empty filters - we aren't providing a filter state to the table so it makes sense that it's empty. We should probably disable search and filtering on this table with a boolean prop on DataTable

We decided to make the filter dialog optional on the data table since the events table has never had any filtering functionality


Malayalam Bible story names contains only story index #224

1.For some stories in malayalam (numbers 14,16,18,19) story name box contains only index of the story.

2.For urdu stories, not able to see the story indexes from the dropdown.

Testing completed and the issue with the story name box  is fixed. As discussed moving this issue to done.


Bar Charts for wavefunction probabilities

We often want to display the wavefunction as a plot.  Best would be to have a built-in bar chart for wavefunctions:
wav, _ = qvm.wavefunction(p, [0])
wav.plot()
wav.plot(qubit_subset=[0, 2, 8])

This would plot a bar chart with bitstring on the x axis and probability on the y axis.
The second option could restrict to plotting a subset of the Hilbert space.  As the number grows exponentially this is useful for ignoring the ancilla qubits, etc.

I could make the crux of this code work independently in my environment. Was able to plot the bar chart for whole of the wavefunction. For the subset part, i understand that the
quantum_simulator.bit_string_probabilities seems to be deprecated. Hence, I left the fourth-to-last line incomplete.
In wavefunction.py
def plot(self, qubit_subset=None):
        """
        Plots a bar chart with bitstring on the x axis and probability on the y axis.

        :param list qubit_subset: Optional parameter used for plotting a subset of the Hilbert space.
        """
        if not qubit_subset:
            prob_dict = self.get_outcome_probs()
            plt.bar(range(len(prob_dict)), prob_dict.values(), align='center')
            plt.xticks(range(len(prob_dict)), prob_dict.keys())
            plt.show()

        else:
            sub_dict = {}
            qubit_num = len(self)
            for index in qubit_subset:
                if index > (2**qubit_num - 1):
                    raise IndexError("Index {} too large for {} qubits.".format(index, qubit_num))
                else:
                    outcome = get_bitstring_from_index(index, qubit_num)
                    sub_dict[outcome] = abs() ** 2
            plt.bar(range(len(sub_dict)), sub_dict.values(), align='center')
            plt.xticks(range(len(sub_dict)), sub_dict.keys())
            plt.show()

@rasa97 would you like to package this up and make a pull request?


Linalg.norm ndim along axis partial fix

This is a partial fix for #3895, working towards feature parity with numpy's linalg.norm.
For the implementation of SVD based norms along arbitrary axis the tsqr algorithm could be extended, or some clever choice of rechunk/map_blocks should be made, both of which I feel not confident to be able to fix at this point in time, as such the code will throw NotImplementedErrors for now in these cases.
I feel however that the extension of functionality for arrays of vectors and arrays of matrices for non-SVD based norms makes it still worth it to merge. If we merge, I will create a new issue for the SVD based norms.
Feedback is welcome as always.

[x] Tests added / passed
[x] Passes flake8 dask

@mrocklin: thanks for the feedback. I did not consider speed yet when I was writing these tests, and have plenty ideas to speed this up, both in simply tuning the test cases and some additional stuff. I will have a look in the near future.

Thanks!
Keeping tests fast helps encourage people to run them frequently when
developing :)
On Sun, Sep 2, 2018 at 4:38 PM, Tobias de Jong<EMAIL_ADDRESS>wrote:

@mrocklin https://github.com/mrocklin: thanks for the feedback. I did
not consider speed yet when I was writing these tests, and have plenty
ideas to speed this up, both in simply tuning the test cases and some
additional stuff. I will have a look in the near future.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/dask/dask/pull/3933#issuecomment-417958126, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AASszFuWE1cYMkvxVKkU_r_DKMt0T1ZHks5uXEGzgaJpZM4WWn3l
.

Thanks @TAdeJong. Took a quick look. This seems fine to me.

It looks like we ignore this in setup.cfg
On Tue, Sep 4, 2018 at 11:42 AM, jakirkham<EMAIL_ADDRESS>wrote:

@jakirkham commented on this pull request.
In dask/array/tests/test_linalg.py
https://github.com/dask/dask/pull/3933#discussion_r214966895:

 a_r = np.linalg.norm(a, ord=norm, axis=axis, keepdims=keepdims)
 d_r = da.linalg.norm(d, ord=norm, axis=axis, keepdims=keepdims)

 assert_eq(a_r, d_r)

+@pytest.mark.parametrize("shape, chunks, axis", [

[(4, 5, 6, 7), (2, 2, 2, 2), (1,2)],
[(4, 5, 6, 7), (2, 2, 2, 2), (-1,-2)],

Yeah, also thought that was weird. @mrocklin https://github.com/mrocklin,
do you have any ideas why flake8 missed this?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/dask/dask/pull/3933#discussion_r214966895, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AASszEZyjLBxj4qzjXvyqSZ6XAbOJwGYks5uXp9tgaJpZM4WWn3l
.

@mrocklin: Is this fast enough to you, although we are still up from the 5ish seconds master needs on my machine?

@mrocklin: Is this fast enough to you, although we are still up from the 5ish seconds master needs on my machine?

Should be fine.  I've marked it as slow so that it doesn't get run by default when devs run tests, but will still run on travis-ci.

OK, merging this in.  Thanks @TAdeJong for finding and resolving this and thanks @jakirkham for the review.


no matches for kind "Issuer" in version "certmanager.k8s.io/v1alpha1

Bugs should be filed for issues encountered whilst operating cert-manager.
You should first attempt to resolve your issues through the community support
channels, e.g. Slack, in order to rule out individual configuration errors.
Please provide as much detail as possible.

Describe the bug:
A clear and concise description of what the bug is.
=> Already install cert-manager v0.12.0 through Helm3, when I try to install RANCHER, it got error message as below
root@rancher1:~# helm install rancher rancher-stable/rancher --namespace cattle-system --set hostname=rancher1 --set ingress.tls.source=rancher
Error: unable to build kubernetes objects from release manifest: unable to recognize "": no matches for kind "Issuer" in version "certmanager.k8s.io/v1alpha1"
Expected behaviour:
A concise description of what you expected to happen.
==> It have to install RANCHER successfully, please help to fix. Thanks.
Steps to reproduce the bug:
Steps to reproduce the bug should be clear and easily reproducible to help people
gain an understanding of the problem.
Anything else we need to know?:
root@rancher1:~# k get certificate -n cert-manager
No resources found in cert-manager namespace.
root@rancher1:~# k get issuer -n cert-manager
No resources found in cert-manager namespace.
root@rancher1:~# k api-versions |grep manager
acme.cert-manager.io/v1alpha2
cert-manager.io/v1alpha2
Environment details::

Kubernetes version (e.g. v1.10.2): v1.18.3
Cloud-provider/provisioner (e.g. GKE, kops AWS, etc): On-premise, VM
cert-manager version (e.g. v0.4.0): v0.12.0
Install method (e.g. helm or static manifests): helm

/kind bug

/triage support
v1alpha1 is removed since 0.11 (we are at 0.15 now)
There is an upgrade guide here: https://cert-manager.io/docs/installation/upgrading/upgrading-0.10-0.11/

Thanks Maartje for help.
I installed cert-manager version 0.12.0
helm install cert-manager --namespace cert-manager --version v0.12.0
jetstack/cert-manager
kubectl -n cert-manager rollout status deploy/cert-manager
deployment "cert-manager" successfully rolled out
kubectl -n cert-manager rollout status deploy/cert-manager-webhook
deployment "cert-manager-webhook" successfully rolled out
The following command will add rancher-latest as a helm repository and
update our local repository cache.
helm repo add rancher-latest
https://releases.rancher.com/server-charts/latest
helm repo update
I want to install Rancher, so following command run and got an error. Can
you help how to go further step?
root@rancher1# helm install rancher rancher-latest/rancher --namespace
cattle-system --set hostname=rancher --set ingress.tls.source=rancher
Error: unable to build kubernetes objects from release manifest: unable to
recognize "": no matches for kind "Issuer" in version
"certmanager.k8s.io/v1alpha1 http://certmanager.k8s.io/v1alpha1"
Best Regards,
Thomas
From: Maartje Eyskens<EMAIL_ADDRESS>Sent: Friday, May 22, 2020 9:15 PM
To: jetstack/cert-manager<EMAIL_ADDRESS>Cc: Thomas-In<EMAIL_ADDRESS>Author<EMAIL_ADDRESS>Subject: Re: [jetstack/cert-manager] no matches for kind "Issuer" in
version "certmanager.k8s.io/v1alpha1 (#2938)
/triage support
v1alpha1 is removed since 0.11 (we are at 0.15 now)
There is an upgrade guide here:
https://cert-manager.io/docs/installation/upgrading/upgrading-0.10-0.11/
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/jetstack/cert-manager/issues/2938#issuecomment-632661803,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/APEWHCYKIYLUSY3MAMKHITTRSZUFPANCNFSM4NHVWJFA
.

If certmanager.k8s.io/v1alpha1 comes from the rancher install it is a Rancher issue not cert-manager

Closing this in favor or https://github.com/rancher/rancher/issues/26674 seems to be a known issue there.
/close


Revert "Drive documentation url from S3 doc archives"

This reverts commit ad8898684db20835bd5d36f3c00de4e74df1b333.
It looks like this change is a source of 404s. Let's revert this to see if that fixes it. (Unfortunately our logging doesn't show which urls 404 - that needs fixing separately.)

(2.71.7 isn't what switched this on but reverting to the "old" way of generating the doc urls should short circuit any issues caused by 2.71.7.)

Well, whatever the source of the 404 is, it wasn't related to the doc archives change:


ng-model bug: Options shifted by one after selecting the first time

If you use the ng-model attribute, all the data-option-array-index attributes for li the elements under the chosen-results list are shifted by one (1, 2, 3... instead of 0, 1, 2...). Selection works the first time -- I'm guessing because the placeholder option is in the array and shifting all the other elements -- but every subsequent selection actually assigns the value after the selected value to the model (click on the second option, and the model is assigned the value for the third option). Picking the last value causes JQuery to throw an error.
How to reproduce:
Open angular-chosen/example/index.html
Pick a value from "Chosen with static options"
Pick another one and watch the model update to the value after it (or if the value selected is the last one, see JQuery throw an error in the console)
I'll try to see if I can fix it.

I think that this issue is covered in the recent documentation. Just add an empty valued option element:

https://github.com/localytics/angular-chosen

Also important: if your ngModel is null or undefined, you must manually include an empty option inside your , otherwise you'll encounter strange off-by-one errors.

Used   to get around this issue

I just had the same problem lately, but I wasn't able to use the ng-init solution because my options were generated by ajax, so when the ng-init was applied, my array wasn't filled yet.
I used a very simple solution, I'm not sure if it's the best (I'm a beginner with Angular), but it worked very well for me. I just deleted the first empty option generated by Chosen, just before activate Chosen for my select : $('#mySelect option').eq(0).remove();

Also, you can call $('#yourSelect').trigger('chosen:updated'), but it is not angular way


Using other attributes for authentication

Our users table has an attribute is_enabled which is a boolean value supposed to govern whether or not a user account is active.  I would like to include this in the criteria for authentication.  In other words, in order to log in successfully, I would like to check 1) that the credentials match what is in LDAP, and 2) that the user's is_enabled flag is set to TRUE.
I note that user accounts which did not exist in the users table would have to be created -- or would have to have an is_enabled default value of TRUE for when Adldap2-Laravel creates them...
Any pointers on what is the best way to accomplish this?
Many thanks.

Hi @darthtaco,
Right now, the only option to reject a users authentication request if a field on their model is equal to a condition, would be extending the AdldapAuthUserProvider:
namespace App\Providers;

LdapAuthUserProvider extends AdldapAuthUserProvider
{
    public function retrieveByCredentials(array $credentials)
    {
        $model = parent::retrieveByCredentials($credentials);

        return $model->is_enabled ? $model : null;
    }
}

Then, extend the AdldapAuthServiceProvider, and insert that into your config/app.php file:
namespace App\Providers;

use Illuminate\Contracts\Hashing\Hasher;

class LdapAuthServiceProvider extends AdldapAuthServiceProvider
{
    protected function newAdldapAuthUserProvider(Hasher $hasher, $model)
    {
        return new LdapAuthUserProvider($hasher, $model);
    }
}

'providers' => [
    '...',
    //Adldap\Laravel\AdldapAuthServiceProvider::class,

    App\Providers\LdapAuthServiceProvider::class, // Your custom LDAP auth provider.

]

To accomplish your second request, you could catch the event Adldap\Laravel\Events\AuthenticatedWithCredentials, which allows you to have access to the authenticated users Adldap model, as well as their Eloquent model.
    /**
     * Create the event listener.
     *
     * @return void
     */
    public function __construct()
    {
        //
    }

    /**
     * Handle the event.
     *
     * @param  AuthenticatedWithCredentials  $event
     * @return void
     */
    public function handle(AuthenticatedWithCredentials $event)
    {
        $model  = $event->model;

        if (! $model->exists) {
            $model->is_enabled = true;
        }
    }

Great @stevebauman!  I was hoping to avoid extending your class but the way you have laid it out it seems to be a clean way of accomplishing what I'm looking for.  I had not considered an event handler as well.  Thanks for the detailed and quick response, very helpful.

No problem! If you encounter anything else please don't hesitate to create another issue here.


Extensions don't follow system proxy settings

Tableau extensions don't follow password protected proxy on Mac.
Even though Tableau application prompts for proxy username and password, the extensions fail to follow the same settings.
The extension might prompt user for username and password just like Google Chrome or Slack:

Yep! We've got this one filed internally. This requires a bit of work on our end to get all sorted. I've added this github issue to the internal bug for followup. :)

Sorry, we are not going to get to this anytime soon.