Commit from container error vnc

Hello and thanks for your job !
I have a question : when do you have finish with my container made from your image (tiryoh/ros2-desktop-vnc:humble) how to commit correctly my docker container with vnc ? because i have some issue when i commit and run the new image :

enable custom user: ubuntu
useradd: user 'ubuntu' already exists
set default password to "ubuntu"
source /opt/ros/humble/setup.bash
source /usr/share/colcon_argcomplete/hook/colcon-argcomplete.bash
============================================================================================
NOTE: --security-opt seccomp=unconfined flag is required to launch Ubuntu Jammy based image.
See https://github.com/Tiryoh/docker-ros2-desktop-vnc/pull/56
============================================================================================
2024-01-25 14:25:19,861 INFO Included extra file "/etc/supervisor/conf.d/supervisord.conf" during parsing
2024-01-25 14:25:19,861 INFO Set uid to user 0 succeeded
2024-01-25 14:25:19,872 INFO RPC interface 'supervisor' initialized
2024-01-25 14:25:19,872 CRIT Server 'unix_http_server' running without any HTTP authentication checking
2024-01-25 14:25:19,873 INFO supervisord started with pid 37
2024-01-25 14:25:20,877 INFO spawned: 'novnc' with pid 38
2024-01-25 14:25:20,880 INFO spawned: 'vnc' with pid 39
2024-01-25 14:25:21,104 INFO exited: vnc (exit status 1; not expected)
2024-01-25 14:25:22,286 INFO success: novnc entered RUNNING state, process has stayed up for > than 1 seconds (startsecs)
2024-01-25 14:25:22,288 INFO spawned: 'vnc' with pid 60
2024-01-25 14:25:22,425 INFO exited: vnc (exit status 1; not expected)
2024-01-25 14:25:24,430 INFO spawned: 'vnc' with pid 69
2024-01-25 14:25:24,525 INFO exited: vnc (exit status 1; not expected)
2024-01-25 14:25:27,531 INFO spawned: 'vnc' with pid 78
2024-01-25 14:25:27,626 INFO exited: vnc (exit status 1; not expected)
2024-01-25 14:25:28,628 INFO gave up: vnc entered FATAL state, too many start retries too quickly

How to reproduce

run build docker container of tiryoh/ros2-desktop-vnc:humble-amd64
docker run -p 6080:80 --security-opt seccomp=unconfined --shm-size=512m tiryoh/ros2-desktop-vnc:humble-amd64

make some change inside it, stop it (ctrl+c) and commit the container
docker commit 766f3e47cf4b lmontagnon/testimagevnc:v1

Relaunch step 1. but with my new image lmontagnon/testimagevnc:v1
docker run -p 6080:80 --security-opt seccomp=unconfined --shm-size=512m lmontagnon/testimagevnc:v1

I'm using ubuntu 22.04 LTS and docker version 25.0.3
Thank you for your help,
lmontagnon

Hi @lmontagnon, not the maintainer. Just a fellow user like you and I have at least managed to get it working.
Not exactly sure what the cause of the issue here is just based on the terminal output you have provided.
However, following the exact steps listed below got it workingfor me. Maybe you can give it a try and see if it works for you as well:
Environment :bookmark_tabs:

Ubuntu 22.04 LTS
Docker 25.0.4

Steps To Reproduce :hammer:
1. Download repository:
cd $HOME
git clone https://github.com/Tiryoh/docker-ros2-desktop-vnc.git --depth 1 --single-branch

2. Build tiryoh/ros2-desktop-vnc:humble-amd64 docker image:
cd $HOME
cd docker-ros2-desktop-vnc/humble
docker buildx build --platform=linux/amd64 --progress=plain -t tiryoh/ros2-desktop-vnc:humble-amd64 .

3. Build docker container:
docker run -p 6080:80 --security-opt seccomp=unconfined --shm-size=512m tiryoh/ros2-desktop-vnc:humble-amd64

4.  If it still doesn't, try posting the output of both the docker build and docker run in its entirety.

Hi @cardboardcode ,
Thank you for your reply ! The build from source and run the container it's already working for me.
The problem is when I commit the container created once the work is finished inside and I want to relaunch this new image I get this error.
How to reproduce

run build docker container of tiryoh/ros2-desktop-vnc:humble-amd64
docker run -p 6080:80 --security-opt seccomp=unconfined --shm-size=512m tiryoh/ros2-desktop-vnc:humble-amd64

make some change inside it, stop it (ctrl+c) and commit the container
docker commit 766f3e47cf4b lmontagnon/testimagevnc:v1

Relaunch step 1. but with my new image lmontagnon/testimagevnc:v1
docker run -p 6080:80 --security-opt seccomp=unconfined --shm-size=512m lmontagnon/testimagevnc:v1

Can you try this and tell me if you have same issue ? I will add "How to reproduce" on my first comment.

Hi @cardboardcode ,
Thank you for your reply ! The build from source and run the container it's already working for me.
The problem is when I commit the container created once the work is finished inside and I want to relaunch this new image I get this error.
 Relaunch **step 1.** but with my new image lmontagnon/testimagevnc:v1
   `docker run -p 6080:80 --security-opt seccomp=unconfined --shm-size=512m lmontagnon/testimagevnc:v1`

Can you try this and tell me if you have same issue ? I will add "How to reproduce" on my first comment.

Ah I get it now. Thank you @Imontage for clarifying further. Will try and update accordingly since I wish to do the same myself.

Tried this. Encountered the same issue as original thread author.
Environment
-Ubuntu 22.04 LTS

Docker 25.0.4

Steps To Reproduce :hammer:
1. Download repository:
cd $HOME
git clone https://github.com/Tiryoh/docker-ros2-desktop-vnc.git --depth 1 --single-branch

2. Build tiryoh/ros2-desktop-vnc:humble-amd64 docker image:
cd $HOME
cd docker-ros2-desktop-vnc/humble
docker buildx build --platform=linux/amd64 --progress=plain -t tiryoh/ros2-desktop-vnc:humble-amd64 .

3. Build docker container:
docker run -p 6080:80 --security-opt seccomp=unconfined --shm-size=512m tiryoh/ros2-desktop-vnc:humble-amd64

4. Access the docker VNC and make new changes:
Open your preferred browser and go to http://<IP_ADDRESS>:6080/
Within VNC, open up terminal and run the following commands:
# Create a new .txt file on ~/Desktop
cd $HOME/Desktop
touch NEW_CHANGES.txt

5. Commit the new change to a new docker image:
docker commit <container_id> my_new_vnc_image:1

Determined the <container_id> by running docker container ls -a
6. Build docker container using new docker image:
docker run -p 6080:80 --security-opt seccomp=unconfined --shm-size=512m my_new_vnc_image:1

Expected Behaviour :green_circle:
Able to run docker container and access VNC as per normal upon running Step 6.
Actual Behaviour :red_circle:
Encountered the following error upon running Step 6. Unable to access failing VNC docker container.
* enable custom user: ubuntu
useradd: user 'ubuntu' already exists
  set default password to "ubuntu"
source /opt/ros/humble/setup.bash
source /usr/share/colcon_argcomplete/hook/colcon-argcomplete.bash
============================================================================================
NOTE: --security-opt seccomp=unconfined flag is required to launch Ubuntu Jammy based image.
See https://github.com/Tiryoh/docker-ros2-desktop-vnc/pull/56
============================================================================================
2024-03-09 01:47:07,627 INFO Included extra file "/etc/supervisor/conf.d/supervisord.conf" during parsing
2024-03-09 01:47:07,627 INFO Set uid to user 0 succeeded
2024-03-09 01:47:07,632 INFO RPC interface 'supervisor' initialized
2024-03-09 01:47:07,632 CRIT Server 'unix_http_server' running without any HTTP authentication checking
2024-03-09 01:47:07,633 INFO supervisord started with pid 37
2024-03-09 01:47:08,638 INFO spawned: 'novnc' with pid 38
2024-03-09 01:47:08,644 INFO spawned: 'vnc' with pid 39
2024-03-09 01:47:08,946 INFO exited: vnc (exit status 1; not expected)
2024-03-09 01:47:09,988 INFO success: novnc entered RUNNING state, process has stayed up for > than 1 seconds (startsecs)
2024-03-09 01:47:09,993 INFO spawned: 'vnc' with pid 64
2024-03-09 01:47:10,321 INFO exited: vnc (exit status 1; not expected)
2024-03-09 01:47:12,327 INFO spawned: 'vnc' with pid 73
2024-03-09 01:47:12,625 INFO exited: vnc (exit status 1; not expected)
2024-03-09 01:47:15,632 INFO spawned: 'vnc' with pid 82
2024-03-09 01:47:15,916 INFO exited: vnc (exit status 1; not expected)
2024-03-09 01:47:16,917 INFO gave up: vnc entered FATAL state, too many start retries too quickly

Remarks
Issue is reproducible. Will try and debug once I am free. Updating it here once I do.

@lmontagnon Did a bit of debugging. Still can't determine the root cause but narrowed down the issue and figured out a dirty workaround.
Update
The cause of issue seems to be specifically due to:
Running the following command in line 350 of docker-ros2-desktop-vnc/humble/entrypoint.sh file:
exec /bin/tini -- supervisord -n -c /etc/supervisor/supervisord.conf

The program vnc fails when its command is ran in the supervisord.conf file:
[program:vnc]
command=gosu '$USER' bash '$VNCRUN_PATH'

Tried having the command run in verbose to give more info about the unexpected error causing vnc program to exit with status 1. However, for unknown reasons, it refuses to output in verbose mode so I am currently stuck at this stage of debugging.
Dirty Workaround :adhesive_bandage:
While I can't have supervisord in the docker container run in verbose mode, I found out that the same failing error does not occur when running the committed docker image manually.
You can follow the steps below to manuallycommit the docker container and run the VNC server based on the new docker image:
Instructions

Modify line 350 docker-ros2-desktop-vnc/humble/entrypoint.sh file to the following:

...
# exec /bin/tini -- supervisord -n -c /etc/supervisor/supervisord.conf
/bin/bash

Build the new docker image with the modified entrypoint.sh:

docker buildx build --platform=linux/amd64 --progress=plain -t tiryoh/ros2-desktop-vnc:humble-amd64 .

Build and run the docker container in interactive bash shell:

docker run -it -p 6080:80 --security-opt seccomp=unconfined --shm-size=512m tiryoh/ros2-desktop-vnc:humble-amd64

Introduce a small change within the docker container:

# Inside Docker Container
cd /home/ubuntu/Desktop
mkdir NEW_CHANGES.txt

Commit docker container to new docker image:

docker commit <container_id> my_new_image:1

Build and run docker ccontainer based on new saved  image in interactive bash shell

docker run -it -p 6080:80 --security-opt seccomp=unconfined --shm-size=512m my_new_image:1

Verify that the same changes is still present in the new container:

# Within Docker Container
ls /home/ubuntu/Desktop

You should see NEW_CHANGES.txt file is still present.

Run vnc program within the new docker container:

gosu $USER bash $HOME/.vnc/vnc_run.sh -v

Open a new terminal in your Host Machine and access the docker container:

docker exec -it <container_id> bash

Run novnc program within the new docker container:

gosu $USER bash -c "websockify --web=/usr/lib/novnc 80 localhost:5901"

Open your preferred browser and go to http://<IP_ADDRESS>:6080/

You should be able to access the VNC server now based on the new commited docker image.
Remarks
Still unable to deduce the root cause and have supervisord run in verbose mode. @Tiryoh Please advise on this issue. Also thank you for your hard work in this repository.

Hi @cardboardcode @lmontagnon
Thanks for pointing this out!
Sorry for my late responding, I have been away for a while for various reasons. I will check it out.
I'm still checking, but maybe this comment is relevant.
https://github.com/Tiryoh/docker-ros2-desktop-vnc/issues/100#issuecomment-1646863650

Hi @cardboardcode @lmontagnon
Thanks for pointing this out! Sorry for my late responding, I have been away for a while for various reasons. I will check it out.
I'm still checking, but maybe this comment is relevant. #100 (comment)

Hi @Tiryoh, no worries. Thank you for replying. :blush:
Will try logging out before stopping the container and update if this addresses the issue.

Hi @cardboardcode , @Tiryoh ,
I tried logging out before commit and it seems to work! When I reproduce the same commands (step to reproduce) it works!
Can you confirmed that @cardboardcode ?
Thanks for your help,
lmontagnon

@Tiryoh @lmontagnon
Can confirm that logging out before stopping the docker container and commiting to new docker image resolves this thread issue on my side as well.
Solution :sparkles:
Before stopping to commit docker container to new docker image, log out first.

Hi @cardboardcode @lmontagnon
Great! Thank you for your research and thank you for sharing it with us!

Hi @cardboardcode @lmontagnon
What do you think of adding the note like the following?

@Tiryoh Not quite sure what is the purpose of the screenshot/note you attached above. Can you elaborate further?
For now, it is just a screenshot with information that the root README.md file already provided.

@cardboardcode
I made the earlier suggestion with the thought that a message on the console when "docker run" might tell the user that they need to log out before stopping to commit the docker container to a new docker image.
I am thinking of adding "docker commit instructions" to the README as well as the console message above until the issue is resolved.

@cardboardcode I made the earlier suggestion with the thought that a message on the console when "docker run" might tell the user that they need to log out before stopping to commit the docker container to a new docker image.
I am thinking of adding "docker commit instructions" to the README as well as the console message above until the issue is resolved.

Ah I see. Apologies. I didn't catch the first time.
I think the NOTE 2 is helpful and important. Do leave it in as well as supplement the README.md as well. :relaxed: :+1:

@cardboardcode Thanks a lot for getting back to me with your thoughts. Really appreciate it! 🙏

@cardboardcode @Tiryoh
Thank you a lot for your help, @Tiryoh I think adding NOTE 2 it's very important and helpful too !
I have a new issue if you can help me ! https://github.com/Tiryoh/docker-ros2-desktop-vnc/issues/146
Best regards,
lmontagnon

@Tiryoh @lmontagnon Can confirm that logging out before stopping the docker container and commiting to new docker image resolves this thread issue on my side as well.
Solution ✨
Before stopping to commit docker container to new docker image, log out first.

excuse me， could you explain how to logout？

You can logout from here

Hi everyone, so before reaching to this thread I was facing same whenever I restart the container. It's seems that whenever we improperly shut down the container vnc stucks.

I found two solutions for this.

 Yes I annoying as you have to wait for 60 seconds for shutting down.

However if you have accidentally closed the container and unable to start it, you can do as follows

https://github.com/Tiryoh/docker-ros2-desktop-vnc/assets/36335324/e9ebfa56-e698-4a5c-ac85-322f7ad12364
Enter below commands in Exec tab of that container
rm -f /tmp/.X1-lock
rm -f /tmp/.X11-unix/X1

or you can connect to terminal of that container by it's ID
docker exec -it CONTAINER ID bash

and Enter above commands.

Hi @SaadRana17,
Thank you for the detailed report! I'll check it out as well.


Set-AzVMExtension Example

Hi, the example for Set-AzVMExtension  on a VM appears to be missing a }  on line 12

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 02cd947d-30c3-2551-4dd6-9762db6869f7
Version Independent ID: 4e5a974c-686c-2005-c036-55dac3107573
Content: Monitor performance on Azure VMs - Azure Application Insights - Azure Monitor
Content Source: articles/azure-monitor/app/azure-vm-vmss-apps.md
Service: azure-monitor
Sub-service: application-insights
GitHub Login: @AaronMaxwell
Microsoft Alias: aaronmax

@andybuk Thanks for your comment. We will review the issue and get back to you shortly.

There are 5 open and 5 close braces in the sample code. Please feel free to reopen this issue if further clarity can be provided.
Install or update the Application Insights Agent as an extension for Azure virtual machines
$publicCfgJsonString = '
{
  "redfieldConfiguration": {
    "instrumentationKeyMap": {
      "filters": [
        {
          "appFilter": ".*",
          "machineFilter": ".*",
          "virtualPathFilter": ".*",
          "instrumentationSettings" : {
            "connectionString": "InstrumentationKey=00000000-0000-0000-0000-000000000000;IngestionEndpoint=https://xxxx.applicationinsights.azure.com/" # Application Insights connection string, create new Application Insights resource if you don't have one. https://portal.azure.com/#blade/HubsExtension/BrowseResourceBlade/resourceType/microsoft.insights%2Fcomponents
          }
        }
      ]
    }
  }
}
';
$privateCfgJsonString = '{}';
#please-close


HHH-14657 Use the compile instead of runtime classpath (5.4 backport)

The runtime classpath contains the dependencies as jars that are not yet built when the plugin needs them. So use the compile classpath plus the compiled classes of the current project.
Since Spring Boot 2.6 (which uses Hibernate 5.5) will be released not before November, it would be nice to have this fix available for Spring Boot 2.5 (which uses Hibernate 5.4).

Ok, sounds reasonable I'll apply this. Thanks!


Re-enables tests previously failing due to new semantics flag.

Description
This change re-enables the tests disabled in PRs #65194 and #63595.
Related Issues
#65194
#63595
Tests
I added the following tests:
N/A
Checklist
Before you create this PR, confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

[X] I read the Contributor Guide and followed the process outlined there for submitting PRs.
[X] I signed the CLA.
[X] I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
[X] I read the Tree Hygiene wiki page, which explains my responsibilities.
[X] I updated/added relevant documentation (doc comments with ///).
[X] All existing and new tests are passing.
[X] The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
[X] I am willing to follow-up on review comments in a timely manner.

Breaking Change
Did any tests fail when you ran them? Please read Handling breaking changes.

[X] No, no existing tests failed, so this is not a breaking change.
[ ] Yes, this is a breaking change. If not, delete the remainder of this section.

[ ] I wrote a design doc: https://flutter.dev/go/template Replace this with a link to your design doc's short link
[ ] I got input from the developer relations team, specifically from: Replace with the names of who gave advice
[ ] I wrote a migration guide: https://flutter.dev/go/breaking-changes-template Replace this with a link to a pull request that adds the migration guide to https://flutter.dev/docs/release/breaking-changes

(PR triage) @abrush21 What is the status of this? Is this ready or could you link to what it is blocked on?

@abrush21 The engine changes should have rolled into Flutter. Can you please rebase this PR to see if tests are now passing? Thanks.


tweak error message

Closes #5238.

@bors r+

:pushpin: Commit 29c0169 has been approved by matklad

@matklad  It seems that 967f094 should be approved. I rebased the commit and sorry for that.

@bors r+

:pushpin: Commit 967f094 has been approved by matklad

:hourglass: Testing commit 967f0944a1ea9d2e2bcb37e12c9e01074ca720d2 with merge 6b8d5899538a060909e791af74ac7d993261af24...

:sunny: Test successful - status-appveyor, status-travis
Approved by: matklad
Pushing 6b8d5899538a060909e791af74ac7d993261af24 to master...


newline between if and condition

This slips through the validation.
if
(some) {
        void 0;
}

Okay or not okay? The style guide is unclear about this.
I would assume this is better:
if (some) {
        void 0;
}

Lets see if any eslint rule can enforce it.


[error] Failed to convert one or more packages, result will not be merged together.

There's nothing I can answer here...


Implement MLP for regression

Hello @rafaelgreca, following up on our email conversation, I’m interested in handling this issue. Could you assign it to me?
Sebastián

Done!

Added on version 10.0.0! Thanks for your contribution!


Version ^4 is no longer compatible with older PHP

We're running a Wordpress fixed at PHP 7.0 and since the update to version 4.0 there is a breaking change to older PHP versions, like nullable (introduced at PHP 7.1)

There's no problem with the upgrade at all, but I guess is time to update the PHP min version:
define('CLOUDFLARE_MIN_PHP_VERSION',` '5.3.10');

Made a PR here https://github.com/cloudflare/Cloudflare-WordPress/pull/370
We'll get this deployed soon. Thanks for the report.

should be fixed by #370

released in v4.1.0


User login flow

User login flow
I need user login flow with this boilerplate. I am sure you know this https://github.com/sotojuan/saga-login-flow
Is there any repo that was combined the login flow and this boilerplate?

Ask StackOverflow.

I'm not sure if it is the right way but here is how I'm doing it in my project.
Basically you create sagas and attach them to some container that always loads (App for example):
export default function* rootWatcher() {
  yield takeLatest(AUTH_USER, createAuthWatcher);
  yield takeLatest(LOAD_CURRENT_USER, loadCurrentUserWatcher);
}

// Login flow
export function* createAuthWatcher(data) {
  yield fork(authUser, data);

  const action = yield take([AUTH_USER_ERROR, AUTH_USER_SUCCESS]);

  if (action.type === AUTH_USER_SUCCESS) {
    // After user is logged, wait for logout
    yield take(LOGOUT_USER);
    yield call(logoutUser);
  }
}

// Load current user flow
export function* loadCurrentUserWatcher(data) {
  yield fork(loadCurrentUser, data);
  const action = yield take([LOAD_CURRENT_USER_SUCCESS, LOAD_CURRENT_USER_ERROR]);

  if (action.type === LOAD_CURRENT_USER_SUCCESS) {
    // After user is loaded, wait for logout
    yield take(LOGOUT_USER);
    yield call(logoutUser);
  }
}

Then in your container you can simply do:
export class App extends React.PureComponent {
  componentWillMount() {
    this.props.loadCurrentUser();
  }
...
}
...

const mapDispatchToProps = {
    loadCurrentUser: loadCurrentUserAction,
};

And of course handle the loginAction from some login form and logout action anywhere you want.
I'm not showing actions and reducer since it is pretty obvious and often needs to be customized to your needs.

@Droow can you show your actions and reducer?

Sure. Here you go:
const initialState = fromJS({
  currentUser: false,
  loading: false,
  error: false,
  authToken: null,
});

function authReducer(state = initialState, action) {
  switch (action.type) {
    case LOAD_CURRENT_USER:
    case AUTH_USER:
      return state
        .set('loading', true)
        .set('error', false);
    case LOAD_CURRENT_USER_SUCCESS:
    case AUTH_USER_SUCCESS:
      return state
        .set('loading', false)
        .set('error', false)
        .set('currentUser', action.user)
        .set('authToken', action.user.auth_token);
    case AUTH_USER_ERROR:
      return state
        .set('loading', false)
        .set('error', action.error);
    case LOGOUT_USER_ERROR:
    case LOAD_CURRENT_USER_ERROR:
      return state.set('loading', false); // No error passed because I don't really care, for me it is just information that the user is not logged in - in other cases this should be solved differently
    case LOGOUT_USER_SUCCESS:
      return state
        .set('currentUser', false)
        .set('authToken', null);
    default:
      return state;
  }
}

export default authReducer;

And very simple actions:
/**
 * User login flow actions
 */
export const userLoginAction = (data) => ({
  type: AUTH_USER,
  username: data.username,
  password: data.password,
});
export const userLoginError = (error) => ({
  type: AUTH_USER_ERROR,
  error,
});
export const userLoginSuccess = (data) => ({
  type: AUTH_USER_SUCCESS,
  user: data.user,
});

/** Load current user flow */
export const loadCurrentUserAction = (data) => ({
  type: LOAD_CURRENT_USER,
});
export const loadCurrentUserError = (error) => ({
  type: LOAD_CURRENT_USER_ERROR,
  error,
});
export const loadCurrentUserSuccess = (data) => ({
  type: LOAD_CURRENT_USER_SUCCESS,
  user: data.user,
});

It is just the simplest idea but it works for me. However there are lot of improvments that can be done. I will welcome any suggestions for improvement.

@Droow thks, could you upload a working project to github?


Add apt install source

add a simple apt install recipe
makes it easier to stay on mainline cookbooks in wrapper cookbook situations, using things like tomcat for example.

We have an apt source now.


fixed vulnerability upgrde to webpack 4

Thank you for submitting this PR, I'm going to close it as we've just updated the repo to webpack 4.


0.14.1 regression

With these simple metrics :
discovery:
  exportedTagsOnMetrics:
    ec2:
      - Name
  jobs:
    - region: ap-northeast-1
      type: ec2
      searchTags:
        - Key: d2nova:common:project
          Value: evox
        - Key: d2nova:common:environment
          Value: prod
      metrics:
        - name: DiskSpaceUtilization
          statistics:
            - Average
          period: 600
          length: 3600
          additionalDimensions:
            - name: MountPath
              value: /
        - name: NetworkIn
          statistics:
            - Maximum
          period: 60
          length: 600
        - name: NetworkOut
          statistics:
            - Maximum
          period: 60
          length: 600

With 0.14.0, I can get all of them. But after I upgrade to 0.14.1, NetworkIn and NetworkOut are no longer generated.
I suspect it's because of the introduction of awsDimension interferring with additionalDimensions in the DiskSpaceUtilization beforehand.

Thanks for reporting this. Will dig into it.

I am having a very similar issue.  The following works if I remove awsDimensions but does not work if I leave it in.  Latency metric works with no issues either way.
  discovery:
    exportedTagsOnMetrics:
      elb:
        - kubernetes.io/service-name
        - AssetID
        - AssetName
    jobs:
    - type: elb
      region: us-east-1
      awsDimensions:
       - AvailabilityZone
      searchTags:
        - Key: AssetID
          Value: 2269
      metrics:
        - name: HTTPCode_ELB_4XX
          statistics:
          - Sum
          period: 60
          length: 600
          delay: 60
          nilToZero: true

@ywliu / @AceHack could you please try again with newest "alpha" version and give me feedback if it is still not working?

Closing. Please tag me if this is still a problem and i will reopen


fix to use configured pipeline api host

Motivation is same with #117.
Fixed URL make fail on self-hosted CircleCI .

Your development orb has been published. It will expire in 30 days.
You can preview what this will look like on the CircleCI Orb Registry at the following link:
https://circleci.com/developer/orbs/orb/circleci/orb-tools?version=dev:7fc6d14564ba2b3fa4327c3c3293b2c402224f8e

Your development orb has been published. It will expire in 30 days.
You can preview what this will look like on the CircleCI Orb Registry at the following link:
https://circleci.com/developer/orbs/orb/circleci/orb-tools?version=dev:6a148422095c99ba9c0995016d27b82fe89f862f

Your orb has been published to the CircleCI Orb Registry.
You can view your published orb on the CircleCI Orb Registry at the following link:
https://circleci.com/developer/orbs/orb/circleci/orb-tools?version=11.2.0


refactor(ar_tag_based_localizer): simplify the launch of artag

Description
In the current launch mechanism, input/output topic names are given using remap instead of parameters. This makes launch codes complicated.
Therefore, I changed launch.xml and cpp so that the topic name can be set in the parameter file. As a result, the settings for each environment can be completed in the parameter file, and there is no need to create a launch within tier4_localization_launch, reducing the number of layers by one.
Tests performed
It has been confirmed that the logging_simulator runs with the same accuracy as before on AWSIM data with GT.

Before : 0.462 m
After : 0.460 m

Effects on system behavior
There are no effects on system behavior.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.

[x] I've confirmed the contribution guidelines.
[x] The PR follows the pull request guidelines.

In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.

[ ] The PR follows the pull request guidelines.

Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.

[ ] There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

This pull request is closed because it conflicts with the implementation of pose_estimator_arbiter.
https://github.com/autowarefoundation/autoware.universe/pull/5846


Bug: Is the LexicalNode isBefore logic correct?

I was looking at the logic and it looks like it should be backwards, I think. Or I could be wrong and open to be corrected.
As per the comment, the code should return true if this node is BEFORE the target node.
The question occurs when one is the parent of another.
If this node is a parent of the target node, doesn't that mean the parent is before the child?
In the code, the logic is such that if a node is a child of the parent, the child is before the parent.
If I'm just misunderstanding it, I apologize in advance.
Below is how the code is written in the codebase.
  /**
   * Returns true if this node logical precedes the target node in the editor state.
   *
   * @param targetNode - the node we're testing to see if it's after this one.
   */
  isBefore(targetNode: LexicalNode): boolean {
    if (this === targetNode) {
      return false;
    }
    if (targetNode.isParentOf(this)) {
      return true;  // <-- isn't this backwards?
    }
    if (this.isParentOf(targetNode)) {
      return false;  // <-- same with this?
    }

I was also confused by this logic the last time I was looking into it. IIRC it might have something to do with the node being entirely before, not just starting before. You really have to look at how it's used to see why it's done this way and it's been a few months since I've looked at that part of the code.


Docpage

Updated the community, documentation pages folder structure.

Added the static page for documentation, release, release version page (WIP)

Added the release note pages.

minor other changes.

Hey @indraraj, @uidoyen, just to make sure we're all on the same page: eventually, the releases information should be data-driven, derived from these files: https://github.com/debezium/debezium.github.io/tree/develop/_data/releases. I.e. this information should not go into hand-written asciidoc files for each release.


feat: Doc Translations

Add Translation
GetDocTranslations

I just had a thought, what do you think about adding another case which is specific where the context is defined to the last level (docfield).
I think this mostly applies when the field is code field holding HTML, for instance. So instead of setting the HTML content as the key, we can rely on doctype:docname:docfield without the key


Segfault on setup on Linux

Running "haxelib run lime setup" causes a segfault.
This is the terminal output:
Called from lime/utils/ByteArray.hx line 109
Called from lime/system/System.hx line 286
Called from lime/system/System.hx line 405
Uncaught exception - Segmentation fault

This is from a fresh install, in ~/.haxe/ after having the same issue in a previous install.
Running Linux Mint 17.
Edit: Got it to work. Went with another fresh install, this time using OpenFL's install-haxe.sh script instead.

Does haxelib run lime setup -nocffi work? What does haxelib path lime return?

Nevermind, I got it to work. Thanks for helping anyways :)

What was wrong? :smile:

To be honest, I have no idea. It works now and that's really all I know.


support first-class modules in load syntax

I want to bring to a discussion an option to have a wildcard load in order to load all values from a module:
load("module.star", "*")

Our use case is that we are trying to allow user of Cirrus CI to write configuration files in Starlark rather then YAML. In order for the configuration look prettier than just a bunch of dicts we'd like to have a module with syntactic sugar like this:
load("core.star", "task", "container", "script", "always", "artifacts")

def main(ctx):
    return [
        task(
            name="Lint",
            instance=container("golangci/golangci-lint:latest", cpu=1.0, memory=512),
            instructions=[
                script("lint", "echo $STARLARK", "golangci-lint run -v --out-format json > golangci.json"),
                always(
                    artifacts("report", "golangci.json", type="text/json", format="golangci")
                )
            ]
        )
    ]

Having to explicitly specify all symbols loaded from a module might be a bit of a struggle. It will be nice if we could do something like that with the standard Starlark rather then creating our own builtin for that:
load("core.star", "*")

Also Python itself can do wildcard imports so it seems consistent with the idea of Startlark.

Wildcard loads, in any language, are a bad idea because they make it hard to know where a name is defined. But there is a cleaner way to solve the same problem: first-class modules. In Python, you can say from os import mkdir, analogous to a Starlark load, or you can say import os and later refer to os.mkdir. Indeed, the second form is the more usual one in Python. In Bazel, many .bzl files construct an explicit struct to act as a module, like so (sticking with the os analogy):
def mkdir_(...): ...
def rmdir_(...): ...

os = struct(
   mkdir=mkdir_,
   rmdir=rmdir_,
)

If Starlark had first-class modules, then a load statement would be able to import the entire module as a value. The syntax would presumably be something like:
  load("os.bzl") # binds 'os' to the "os.bzl" module

or
 load(alt="os.bzl") binds alternative name 'alt' to the "os.bzl" module

I think this would be a worthwhile language change.

I agree that wildcard imports are generally bad because of the reasoning issues but I don't see wildcard imports as bad for small applications comparing to big projects with hundreds of files.
What do you think about allowing at most one wildcard import in order to simplify reasoning and implementation? Looks like a good compromise to still support Python-like wildcard imports but also don't allow to go out of hand with exponentially growing amount of modules to look into while resolving a symbol.

I agree with Alan.
With wildcards, it's easy to get conflicts (two files defining the same name). So defining a new function becomes a breaking change for other Starlark modules. It also easily confuses the reader (it's hard to find where something is defined). It adds complexity to the tools and IDEs (e.g. how to jump to definition).
I'd rather not add complexity to the language and tools, just so that it's easier to write code that will eventually be harder to maintain.

I don't see wildcard imports as bad for small applications comparing to big projects with hundreds of files.

Every big project with hundreds of files starts as a small application.

What do you think about allowing at most one wildcard import in order to simplify reasoning and implementation?

I still don't like. You would have to pay all the complexity of the feature but then place an artificial limit on it.
More importantly, wildcard imports are completely incompatible with the Python compilation model. They are feasible to implement in a compiled language like Java or Go because the names defined by the imported module are enumerable at compilation time. By contrast, in a Python-like language, compilation occurs one file at a time, before the module becomes available during execution, so you simply don't know what names would be bound by each import statement. This means it's impossible to tell during compilation whether a reference is defined by an import, predeclared, or undefined.

See spec proposal: https://github.com/bazelbuild/starlark/issues/111


Add --stash as alternative to --clean to update-checkout

Use of --clean can lead to irreversible loss of uncommitted data. It is still desirable to reset Swift project repositories to a clean state, but without deleting all of the in-progress changes. Passing --stash instead of (or in addition to) --clean will preserve uncommitted changes in stashes of corresponding repositories instead of completely deleting those.

@swift-ci smoke test macos

@swift-ci smoke test

@swift-ci smoke test

LGTM. A test would be nice.

Can you provide some details on what would be the best way to cover this with tests, in your opinion?

update-checkout has a Python unit test suite at utils/update_checkout/tests. You can run it using utils/update_checkout/run_tests.py or lit + validation-test/Python/update_checkout.swift. The test suite is centered around an intermediary unittest.TestCase subclass from which all the effective test classes inherit. This base class is responsible for setting up and tearing down a mock-up environment consisting of a directory of local remotes and a source root — a directory for their clones. Subclasses define test functions that run update-checkout commands against these mock repositories and perform state checks.
I think a single test function that

clones the remotes using update-checkout
creates some untracked files in several clones
runs update-checkout with --stash
verifies that the untracked files have indeed been stashed and nothing else happened

would good enough for now (the update/clone tests, if any, are really basic anyway). I would place this function in a new subclass in its own file.


Delete homepage related code

Now that we have a new homepage, we can safely delete related code.

Change in coverage is interesting but the code is still used in user-report so I will ignore it.


PermissionsImplementation+d__8.MoveNext A task was cancelled

I think this issue sits somewhere between a feature request and a bug. i.e. the feature should stop the bug from occurring...
If you are creating an issue for a BUG please fill out this information. If you are asking a question or requesting a feature you can delete the sections below.
Failure to fill out this information will result in this issue being closed. If you post a full stack trace in a bug it will be closed, please post it to http://gist.github.com and then post the link here.
Bug Information
Version Number of Plugin: <IP_ADDRESS>
Device Tested On: Samsung S6, S8, J7 Pro
Simulator Tested On:
Version of VS: 2017 - 15.9.13
Version of Xamarin: <IP_ADDRESS>
Versions of other things you are using: Target and build API 28
Steps to reproduce the Behavior
Start the camera invoking the permission request. Deny access for the app to use the camera. Request again (now with reasoning), deny again AND select "Don't Ask Again".
Restart the app.
Button mash the request to start the camera
Expected Behavior
Ability to display alert... "Access to camera has been denied, provide access in app settings" Or something to that effect.
Actual Behavior
Crash:
PermissionsImplementation+d__8.MoveNext ()
System.Threading.Tasks.TaskCanceledException: A task was canceled.
Code snippet
private async void Scan_Tapped(object sender, EventArgs e)
{
	if (scan_tapped)
	{
		return;
	}

	scan_tapped = true;

	qrScanStack.IsEnabled = false;

	var device = Plugin.DeviceInfo.CrossDeviceInfo.Current;

	GetCameraPermission();

	if (CameraPermissionStatus == PermissionStatus.Granted)
	{
		Analytics.TrackEvent($"Setup page, scan new connection");

		await Navigation.PushAsync(scanPage);
	}
	qrScanStack.IsEnabled = true;

	scan_tapped = false;
}

private async void GetCameraPermission()
{
	CameraPermissionStatus = await CrossPermissions.Current.CheckPermissionStatusAsync(Permission.Camera);

	if (CameraPermissionStatus != PermissionStatus.Granted)
	{
		if (await CrossPermissions.Current.ShouldShowRequestPermissionRationaleAsync(Permission.Camera))
		{
			await Xamarin.Forms.Application.Current.MainPage.DisplayAlert(AppResources.needCamera, AppResources.CameraPermission, AppResources.OK);
		}

		var results = await CrossPermissions.Current.RequestPermissionsAsync(new[] { Permission.Camera });
		CameraPermissionStatus = results[Permission.Camera];
	}
}

within MainActivity:
public override void OnRequestPermissionsResult(int requestCode, string[] permissions, [GeneratedEnum] Android.Content.PM.Permission[] grantResults)
{
	PermissionsImplementation.Current.OnRequestPermissionsResult(requestCode, permissions, grantResults);
	base.OnRequestPermissionsResult(requestCode, permissions, grantResults);
}

in OnCreate:
CrossCurrentActivity.Current.Init(this, bundle);
Is there a flag to help determine if a user has requested not to be asked about a permission again, what if they then attempt to use it again?

I seemed to of stopped this from crashing now, changed a couple of things.

A flag to see if I'm already requesting a permission (I think this is more related to my use of tapgesturerecognizer rather than a button that can be disabled) this attempts to ensure I don't re-enter the cross permissions functions.
Add in a second show rationale request after request permission. If this is false, and permission is denied then it appears the user has selected Never ask again.

Here's my new code:
private async void GetCameraPermission()
		{
			if (requestingPermission)
			{
				return;
			}

			requestingPermission = true;

			CameraPermissionStatus = await CrossPermissions.Current.CheckPermissionStatusAsync(Permission.Camera);

			if (CameraPermissionStatus != PermissionStatus.Granted)
			{
				bool showRationale = await CrossPermissions.Current.ShouldShowRequestPermissionRationaleAsync(Permission.Camera);
				if (showRationale)
				{
					await Xamarin.Forms.Application.Current.MainPage.DisplayAlert(AppResources.needCamera, AppResources.CameraPermission, AppResources.OK);
				}

				var results = await CrossPermissions.Current.RequestPermissionsAsync(new[] { Permission.Camera });
				CameraPermissionStatus = results[Permission.Camera];

				if (CameraPermissionStatus != PermissionStatus.Granted)
				{
					showRationale = await CrossPermissions.Current.ShouldShowRequestPermissionRationaleAsync(Permission.Camera);
					if (!showRationale)
					{
						bool opensettings = await Xamarin.Forms.Application.Current.MainPage.DisplayAlert(AppResources.needCamera, AppResources.NeverAskAgainCamera, AppResources.OK, AppResources.Cancel);

						if (opensettings)
						{
							CrossPermissions.Current.OpenAppSettings();
						}
					}
				}
			}

			requestingPermission = false;
		}

I'd be interested to hear if you think this is a good method for checking if Never Ask Again has been selected.


Need a newbie tutorial doc

Specifically, from creating a new flutter project to running a rust-in-flutter project step-by-step: show different types of functions as examples: simple math calculations and returning the result, dart passing an array to Rust, dart passing a string to rust and then returning another string, etc.

This is a good idea :) It would be nice to let users adopt this package more easily. Though it would be better to avoid explaining steps that other tutorials do better, more detailed communication examples can be provided.
By the way, which people do you think that those new guides should target? People with Rust background, or Flutter background, or both?

I think the tutorial should be geared towards Flutter developers with a little bit of Rust foundation rather than the professional Rust programming crowd. The library should make it easy for Flutter users to convert Rust libraries into packages usable by Flutter.

I also think that at the current size of the project, the doc should just be placed in the Readme.md

Looking forward to your new docs!

@moluopro The step-by-step tutorial is now added. I generated Chinese translations which might look awkward, so please fix various grammar and sentences when you are free!

I will also be fixing some errors in the guides and add some more about MessagePack types and organize sections in a day or two :)

okk

I also need to make some changes to the English doc, about the doc structure

If you have a better idea about organizing the base guide structure, feel free to leave a PR so that we can discuss about this!

Just changed the tips to FAQ and moved the question about ndkVersion to here.
I don't think users have to consult about Android packaging failures before they start using our libraries, so moved this section to the FAQ.

My pr is coming ~ QAQ

That change looks reasonable, looking forward to read your PR!


Splitting operator roles creation from the ROSA STS cluster creation

Hey there, not much Ii can comment at the moment. I think the separation looks good.

Hey there, not much Ii can comment at the moment. I think the separation looks good.


Unit tests broken

The unit tests which run successfully on main do NOT run on the imsub branch. We should not merge until we understand the discrepancy.

Resolved
afe0e016c574ef1daf984a3865240ea1979bf8b5
32118f4c20218b3d0b20f15be522a2d86c16542a


retry during "apply patch" on connection failures

based on build 1611: We should retry on case of failing connections to github.com in all communication steps of apply_patch2.py

another example


[Texture support][Part 3] Support storage scope tag in graph runtime codegen, planning, runtime and compile engine

This PR adds generic support for the use of storage scope in Relay's graph runtime lowering path. The key conceptual additions made are:

Introduce a target dependent CollectStorageInfo pass which returns a storage mapping for the outputs of each Expr in a Relay function. The consumers of the output storage scope annotations are:

The graph runtime memory planner, which can utilize the output storage scope when doing token allocation optimization
The graph runtime codegen, which annotates the graph json with these storage scopes.
The target dependent CollectBufferBinds packed function which translates these storage scopes into buffers to be bound when lowering a Relay primitive func in CompileEngine (via the binds field of tvm::lower/build)
Finally the graph runtime, which utilizes the storage scope annotations in the graph json when setting up data space storage

The two introduced CollectStorageInfo and CollectBufferBinds are dispatched to via a target dependent packed function. If no implementation exists for a given target, the storage scope of each Expr defaults to global scope and the runtime is unaffected.
See RFC here: https://discuss.tvm.apache.org/t/rfc-texture-memory-support/9467

Subsumed by https://github.com/apache/tvm/pull/11875.


Add last_transaction_modified_at field to Checkout

I want to merge this change because it adds denormalized field for storing transaction.modified_at to the checkout.
The PR is related to the bug reported here: https://github.com/saleor/saleor/issues/14733, it extends the checkout model with required fields to solve the problem.
The part of extending is explained as a subtask of the bug: https://github.com/saleor/saleor/issues/14768

Impact

[x] New migrations
[ ] New/Updated API fields or mutations
[ ] Deprecated API fields or mutations
[ ] Removed API types, fields, or mutations

Docs

[ ] Link to documentation:

Pull Request Checklist

[ ] Privileged queries and mutations are either absent or guarded by proper permission checks
[x] Database queries are optimized and the number of queries is constant
[x] Database migrations are either absent or optimized for zero downtime
[ ] The changes are covered by test cases
[ ] All new fields/inputs/mutations have proper labels added (ADDED_IN_X, PREVIEW_FEATURE, etc.)
[ ] All migrations have proper dependencies
[x] All indexes are added concurrently in migrations
[x] All RunSql and RunPython migrations have revert option defined

Closing, as this will go to 3.14, ref https://github.com/saleor/saleor/pull/14788


Add H3 hexes for the state

Summary

Proposed Readable Name: Utah H3 Hexes Level 5/6/7/8/9
Proposed Internal Dataset Name: h3_hexes_z5/6/7/8/9
Proposed External Dataset Name: h3_hexes_z5/6/7/8/9
Proposed Data Category: Index
Data Description: The H3 hexes covering the State of Utah at zoom levels 5-9
Source Agency/Entity: UGRC
Contact: Jacob Adams
Update Frequency: Static

These are five datasets, one for each H3 hex zoom levels 5-9. They were created using the method described in my blog post. I had to buffer the state boundary to make sure I got all the hexes that cover the state (the h3.polyfill method just searches if the centroid of a hex is within a polygon), so there are some hexes that are outside the state boundary.
The data should be available in
1 Check [x] all the areas where you expect the data to show up.

[x] Internal SGID
[x] Open SGID
[x] ArcGIS Online
[x] Open Data

The data is of high quality

[ ] Sweeper checks have run and passed (name on 2022/00/00)
[ ] The minimum requirements for metadata are populated (name on 2022/00/00)
[ ] The data complies with our domain rules (name on 2022/00/00)

Where is the data source
Choose one.

[x] Internal SGID
[ ] Farm from AGOL (agol item url)

Action items

Assign a person who should complete the task by replacing name with their github @name.
Check [x] the box when the task is completed and add the date of completion.
~Strike~ out all items that do not apply.

[ ] Add data to the Internal SGID (@jacobdadams, completed: 2022/00/00)
~- [ ] Configure forklift for Farm from AGOL (name, completed: 2022/00/00)~
[ ] Update relevant gis.utah.gov data pages (@jacobdadams, completed: 2022/00/00)
[ ] Add a Stewardship record (@jacobdadams, completed: 2022/00/00)
[ ] Complete a SGID.META.AGOLItems record (@jacobdadams, completed: 2022/00/00)
~- [ ] Complete an AGOLItems_shelved record for any static or shelved item (name, completed: 2022/00/00)~

:robot: Automation validation

Assign yourself or someone to check the item by replacing name with their github @name.
Check [x] the box and add the date of verification 2020/01/01 when the task is verified.
~Strike~ out all items that do not apply.

[ ] Open SGID via cloudb (@steveoh on 2022/00/00)
[ ] ArcGIS Online via forklift (@stdavis on 2022/00/00)
[ ] Auditor ran successfully (@jacobdadams on 2022/00/00)
[ ] Open Data (@jacobdadams on 2022/00/00)
[ ] gis.utah.gov data pages (@jacobdadams on 2022/00/00)
[ ] sgid-index (@steveoh on 2022/00/00)

Notification

[ ] Twitter (@steveoh)

Group Task Assignments

Check [x] the box when you have assigned all the tasks relevant to your group.

[x] Data Team (@gregbunce)
[x] Dev Team (@steveoh)
~- [ ] Cadastre Team (@rkelson)~

i agree. I think it's super useful for comparative analysis and having these spatial pieces (the geom) readily available will be a huge time saver and also make the system easier to work with.  i think if it's in the sgid, other folks will take advantage of it as well.
i would say if an official source decides to serve it in the future then we point to that layer, but in the meantime, we serve it for ease of use.
that's my opinion.
others?

Yeah, what Greg said. It provides a standardized grid that other agencies can use in their analyses. I see it as a functional/foundational layer.

We'll need to update the proposed names. / in a table name is not a great idea. If we follow the political boundary convention it would be something like h3_hexes_5_to_9.

There are five different layers- 5, 6, 7, 8, and 9.

It seems like a good fit for the SGID to me as well. Just because it allows for a common standard for analysis across the state.

For sweeper, should I do that before I load into SGID internal or wait until its in there and let the main sweeper check get it?

You could probably let sweeper get it after loading to internal.

Ok, here's an interesting licensing thought. The H3 system itself is licensed under Apache 2.0 (an open-source, preserve-copyright license). However, the polygons are generated by the H3 system but are not necessarily part of the system or the code (you don't download the polygons, you generate them).
Does this mean the polygons are still under the Apache 2.0 license? Or can we put them under our CC license?
And if it's under Apache, is there anything special we need to do to tell sweeper?

Does that imply we shouldn't use h3 in the table name?

conductor results for tasks - 214

check
status

@jacobdadams has completed 0 out of 7 tasks
:no_entry:

@steveoh has completed 1 out of 4 tasks
:no_entry:

@stdavis has completed 0 out of 1 tasks
:no_entry:

gregbunce has completed 1 out of 1 tasks
:+1:

@eneemann or someone, will you create a draft pr referencing this issue as a part of the introduction steps please.

I've got a branch read for sweeper; @steveoh or @eneemann, can you give me write access to the repo so I can push?

I've got a branch ready for sweeper; @steveoh or @eneemann, can you give me write access to the repo so I can push?

It looks like you are already a contributor. What's the error you get?

conductor results for tasks - 214

check
status

@jacobdadams has completed 3 out of 9 tasks
:no_entry:

@steveoh has completed 1 out of 4 tasks
:no_entry:

@stdavis has completed 0 out of 1 tasks
:no_entry:

gregbunce has completed 1 out of 1 tasks
:+1:

conductor results for tasks - 214

check
status

@jacobdadams has completed 3 out of 10 tasks
:no_entry:

@steveoh has completed 1 out of 4 tasks
:no_entry:

@stdavis has completed 0 out of 1 tasks
:no_entry:

gregbunce has completed 1 out of 1 tasks
:+1:

conductor results for indices.h3_hexes_z5

check
status

internal sgid
:no_entry:

meta table

- item id
:no_entry:

- item name
:no_entry:

- geometry type
:no_entry:

stewardship
:no_entry: Did not find indices.h3_hexes_z5 in the worksheet

Ok, sweeper has been updated with the h3 license info, along with some dependency updating. @eneemann, what do we need to do to get that updated on the main sweeper instance?

I'll update the package in production

conductor results for tasks - 214

check
status

@jacobdadams has completed 8 out of 11 tasks
:no_entry:

@steveoh has completed 1 out of 4 tasks
:no_entry:

gregbunce has completed 1 out of 1 tasks
:+1:

Ok, I think I've got all my stuff done. I'm marking Open Data as verified because they work if you link directly to them in open data. They don't show up if you search, but that's the broader Index Group issue and not specifically these layers.


fs/inode: combine multiple file list allocs into one to improve performance

Summary
fs/inode: combine multiple file list allocs into one to improve performance
combine multiple file list allocs into one to improve the task create performance
Signed-off-by: chao an<EMAIL_ADDRESS>Impact
sim/nsh
Testing
ci-check

@anchao what is the impact of this change? Could you please show the output of toolchain-size command (i.e. arm-none-eabi-size) before and after this modification? And the "nsh> free" before and after this modification.
I think this modification is very good, but we need to see how it will impact small microcontrollers as well. Depending on results it is better to have an way to keep the original behavior.

@anchao what is the impact of this change? Could you please show the output of toolchain-size command (i.e. arm-none-eabi-size) before and after this modification? And the "nsh> free" before and after this modification.
I think this modification is very good, but we need to see how it will impact small microcontrollers as well. Depending on results it is better to have an way to keep the original behavior.

@acassis
I just measured the related performance of Task Termination. The focus in the process is mainly on the time consumption in interval B:

After applying this PR, the time consumption will be reduced ~2us (Tricore TC397 300MHZ):
15.97(us) -> 13.55(us)
But after testing about this change, I found that this PR has a regression issue. The file pointer held by the user will be invalid due to memory re-allocation after the file is expanded, so I will close this PR later.


License of FirebaseAnalytcs and GoogleAppMeasurement in Podspec vs SPM

Description
The Podspecs for FirebaseAnalytics and GoogleAppMeasurement are marked with a “Copyright 202x Google” license in the Podspec (link).
The same dependencies, in SPM, are marked as Apache 2.0 (GitHub - google/GoogleAppMeasurement ).
In this other issue, it was mentioned that because these 2 libraries are distributed as binaries they can't be Apache 2.0. I'm not an expert, but is this true? If it is shouldn't you change the SPM license?
Reproducing the issue
No response
Firebase SDK Version
10.26
Xcode Version
15.4
Installation Method
CocoaPods
Firebase Product(s)
Analytics
Targeted Platforms
iOS
Relevant Log Output
No response
If using Swift Package Manager, the project's Package.resolved
No response
If using CocoaPods, the project's Podfile.lock
No response

@lucatorella Thanks for the report. We'll get the fix into the next GoogleAppMeasurement release after today's.

@lucatorella Thanks for the report. We'll get the fix into the next GoogleAppMeasurement release after today's.

Hi @lucatorella– you can actually expect this fix a little earlier. Due to the timing of things, this fix will actually release this week (planned for tomorrow). Thanks again!

thanks!
Can you also fix FirebaseAnalytics? It has the same problem: https://github.com/CocoaPods/Specs/blob/master/Specs/e/2/1/FirebaseAnalytics/10.25.0/FirebaseAnalytics.podspec.json

I'll reopen, since it will take a bit more thought. SPM doesn't provide a good way to describe different sets of licenses for different include products from the same repo. BTW all Firebase licenses are concatenated in https://github.com/firebase/firebase-ios-sdk/blob/main/CoreOnly/NOTICES

On further research, it seems the LICENSE in the repository refers to the code in the repository to enable Swift Package Manager which is Apache licensed.
The License in the podspec refers to the binary pointed to by the podspec.

I see, thanks for the clarification 👍


Fixed the reference link for 'secret permissions with default mode'

Fixes: #43253

As given in the https://github.com/kubernetes/website/pull/38083, the commit (line 195) shows the heading is changed to Set POSIX permissions for Secret Keys from Secret file permissions.

/approve


Extract etcd transaction logs for user

i have some commonn doubts in etcd DB. They are
1.how i can tail the logs of etcd like how can i get entries in the etcd db or How can i get to see logs about etcd transactions?
2. Is there any method to see key-value data in normal human readable format?
3.And if the user wants to know what is happening during transaction how user can know ... Is there any methods to see transaction logs for the user??
For example : suppose i have one application with mysql as a DB. so whenever i save some info. in that application in the backgrounds it will perform some MySQL query like INSERT and save the info right.. i want that kind of information's.. this is just a example :)
Isit possible to extract similar kind of information from etcd...

@nizam037

etcd system log outputs to stderr by default. etcd Raft logs persists to WAL (on disk). And if you are talking about transaction events log (e.g. https://dev.mysql.com/doc/refman/5.7/en/binary-log.html), etcd doesn't have it. If you are talking about historical data before transaction, you can query by the revision.

See https://github.com/coreos/etcd/tree/master/tools/etcd-dump-db.

No.


Don't explicitly set cmd on single-user spawned servers

In an issue that's stumped me and @Carreau, setting command explicitly causes kernels to fail!
wat.

so wtf was going on?

Me and @Carreau just went into a room so we could go "WHAT THE FUCK". We
don't know, but we know this fixes it.
On Thu, Mar 23, 2017 at 5:21 PM, Chris Holdgraf<EMAIL_ADDRESS>wrote:

so wtf was going on?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/data-8/jupyterhub-k8s/pull/152#issuecomment-288898903,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAB23uRW-kPT1enxmVU6Szz5K8nJCMooks5rowxvgaJpZM4Mnhjp
.

--
Yuvi Panda T
http://yuvi.in/blog


Importing small assets causes a computer crash for large project

When unity imports a lot of small assets wakatime spawns up dozens of python processes using 100% CPU on my i7-6800K until my computer runs out of memory and crashes (48GB of RAM). Tested a few times and removing the wakatime directory fixes the insane resource usage and the import is much faster as well.

Hello!
Sorry for the (very) late reply! I didn't pay much attention to this repository :D
You were right, it was going crazy even with really small amount of changes. I've introduced some changes to prevent that:

I've wrapped requests into Tasks, so they run in the background
I've limited the number of concurrent requests (5 by default, editable in the window)

But the big problem is still python: a single request can take more than 5 secs :/
https://wakatime.com/unity
It's probably better to check other implementations that have native C# client


builds fail when CARGO_HOME is relative path

When setting CARGO_HOME to a relative path projects will not build anymore. This can be reproduced  by trying to build a project like racer.  Using an absolute path for CARGO_HOME everything is fine:
git clone https://github.com/phildawes/racer.git && cd racer && CARGO_HOME=/tmp/racer/cargo_home/ cargo build

When a relative path is used the build fails:
$ git clone https://github.com/phildawes/racer.git && cd racer && CARGO_HOME=./cargo_home/ cargo build
Cloning into 'racer'...
remote: Counting objects: 2378, done.
remote: Compressing objects: 100% (35/35), done.
remote: Total 2378 (delta 10), reused 0 (delta 0), pack-reused 2341
Receiving objects: 100% (2378/2378), 4.21 MiB | 1.31 MiB/s, done.
Resolving deltas: 100% (1473/1473), done.
Checking connectivity... done.
    Updating registry `https://github.com/rust-lang/crates.io-index`
 Downloading unicode-xid v0.0.1
 Downloading syntex_syntax v0.6.0
 Downloading log v0.3.1
 Downloading bitflags v0.1.1
 Downloading toml v0.1.20
 Downloading libc v0.1.8
 Downloading rustc-serialize v0.3.14
 Downloading term v0.2.7
   Compiling term v0.2.7
error: couldn't read "./cargo_home/registry/src/github.com-1ecc6299db9ec823/term-0.2.7/./cargo_home/registry/src/github.com-1ecc6299db9ec823/term-0.2.7/src/lib.rs": No such file or directory (os error 2)
   Compiling libc v0.1.8
   Compiling bitflags v0.1.1
error: couldn't read "./cargo_home/registry/src/github.com-1ecc6299db9ec823/bitflags-0.1.1/./cargo_home/registry/src/github.com-1ecc6299db9ec823/bitflags-0.1.1/src/lib.rs": No such file or directory (os error 2)
   Compiling rustc-serialize v0.3.14
error: couldn't read "./cargo_home/registry/src/github.com-1ecc6299db9ec823/rustc-serialize-0.3.14/./cargo_home/registry/src/github.com-1ecc6299db9ec823/rustc-serialize-0.3.14/src/lib.rs": No such file or directory (os error 2)
   Compiling unicode-xid v0.0.1
Build failed, waiting for other jobs to finish...
error: couldn't read "./cargo_home/registry/src/github.com-1ecc6299db9ec823/unicode-xid-0.0.1/./cargo_home/registry/src/github.com-1ecc6299db9ec823/unicode-xid-0.0.1/src/lib.rs": No such file or directory (os error 2)
Could not compile `term`.

To learn more, run the command again with --verbose.
$

Ah yeah I can see where this would go badly quickly! I think we should just make it an absolute path as soon as it's read.

I am going to see if I can fix this...


Convert 'standard' calendar to 'gregorian' and visa versa

Although standard and Gregorian calendars are equivalent, when plotting time series, we need the two strings to compare. To facilitate this, we should add two new functions cal2std and cal2greg that make it easy to change the calendar name. This has to be done by making a new cordinate and deleting the old one.

I don't think you need to create a new coordinate, just replace the units on your existing coordinate.  Does this work?
tcoord = cube.coord('time')
tcoord.units = cf_units.Unit(tcoord.units.origin, calendar='gregorian')

would it be worth making a section in "Iris examples" for this type of thing?

FWIW in cf-units 2 we introduced calendar aliases so that Gregorian is standard.
>>> import cf_units
>>> cf_units.__version__
'2.0.1'
>>> a = cf_units.Unit('days since 2000-01-01', calendar='standard')
>>> b = cf_units.Unit('days since 2000-01-01', calendar='gregorian')
>>> a == b
True
>>> a
Unit('days since 2000-01-01', calendar='gregorian')
>>> b
Unit('days since 2000-01-01', calendar='gregorian')

cf-units 2 is part of the Iris 2.1 release, and will be rolling out to an organisation near you soon 😉. Even sooner if you make use of "experimental" type software environments 😉

would it be worth making a section in "Iris examples" for this type of thing?

This isn't really something that documents that well. Truth is it would be best documented in somewhere like StackOverflow where it would be optimally indexed by Google.
Thanks for raising @nhsavage, and thanks for answering @rcomer!

I eventually found this and it was super useful. If any of you want to answer, here's a stack overflow question https://stackoverflow.com/q/52702433/10473080


crystal: fix CRYSTAL_PATH

Fixes #31844
The crystal compiler tries to search crystal dependencies by looking at CRYSTAL_PATH,
this commit adds lib to CRYSTAL_PATH, so that crystal can find dependencies installed locally by shards.
Motivation for this change
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[x] Fits CONTRIBUTING.md.

Thank you!


ActiveSync policy requires selection of Device Platform

When following instructions for "Exchange Online and SharePoint Online policy", on step 2 for EAS. I have created the policy as described but receive the following error when trying to save:
"MAM policy should be applied to Android or iOS client platforms."
If I specific Android and iOS as Device Platform conditions, the policy will save and apply. This step likely needs to be updated in multiple areas on this page.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: a1d67eec-b53c-4bbc-b160-b3fb8fca5ff4
Version Independent ID: b943cd70-2c1b-5b9b-8ed7-0b0331da3982
Content: How to require approved client apps for cloud app access with Conditional Access in Azure Active Directory
Content Source: articles/active-directory/conditional-access/app-based-conditional-access.md
Service: active-directory
Sub-service: conditional-access
GitHub Login: @MicrosoftGuyJFlo
Microsoft Alias: joflore

@StephenFerrero  Thank you for your query. We will check it with the engineering internally and let you know accordingly.

@StephenFerrero Step 1 includes this information. Are you saying that Step 2 needs this as well? Feel free to reach out to me I would like to get this resolved. Email is in my profile.

Working this into the following private PR https://github.com/MicrosoftDocs/azure-docs-pr/pull/104385

Being resolved through a private PR. Closing.

#please-close


#19992 add escape parameter for bulk load copy command

Please check

[x] - import from another table
[x] - import from the file
[x] - different special characters in a source

https://www.postgresql.org/docs/current/sql-copy.html

Verified


Backport of 2595 in stable-3.1

Backport of #2595 in stable-3.1
Closes: https://bugzilla.redhat.com/show_bug.cgi?id=1577846

jenkins test luminous-ansible2.4-switch_to_containers

@ktdreyer from our discussion on IRC, we should change the target for 3.1 in the BZ if I've understood correctly?

That's correct!


main: updating the version properly pin patch version

This updates the version behaivor to have ~> 0.0.0: any non-beta version >= 0.0.0 and < 0.1.0
https://www.terraform.io/docs/modules/usage.html#gt-1-2

thanks @geekbass, I see that the latest tag is set to 0.1.x. Nice catch. I've updated this repo to reflect the changes.


How to specify CUDA ARCH while building xgboost?

It looks by default, to cmake xgboost, it would build for ALL cuda architectures.
Where and how to specify a particular cuda architecture just for my native computer, say sm_75 ONLY?
Cheers

Please see this CMake option: https://github.com/dmlc/xgboost/blob/04fc575c0eef61eac71de11f0d4c610e4458ebdc/CMakeLists.txt#L54
It was added before CUDA language support was added in CMake.  In the long term I think we will migrate to modern CMake builtin option.


BorderRadius should be BindType.FourPixelsOrPercent

There are several components with BorderRadius attribute. I've checked js implementation with mj-button and it seems that it allows any value (String). It seems incorrect to me, but the type should be unified in the .Net impl to BindType.FourPixelsOrPercent

The components that we added later have partially been generated from mjml directly.

Closed by last commit


Move Parser Utils to separate package

Maybe directly expose the string extension?
Update string extension with info from updated SO post
Add tests for extended grapheme clusters
fix typos
add tests for parseAmountDecimalFrom (see importer)
update header comment

Afterwards update:

This repo to use new package
Wealthsimple Mapper to use the new package instead of the Parser
Rogers Mapper to use the new package instead of the Parser
Importer (ManuLife) to use the new package instead of a copy of the method

https://github.com/Nef10/SwiftBeanCountParserUtils

Fixed in #89


⚠ Bofrost.es has degraded performance

In 36b9e25, Bofrost.es (https://www.bofrost.es) experienced degraded performance:

HTTP code: 200
Response time: 1765 ms

Resolved: Bofrost.es performance has improved in 54e5e97 after 3 hours, 22 minutes.


[BUG] Latest version of ast-github-action (2.0.24) with problem when generating PDF report with scansummary

Describe the bug
The latest ast-github-action version (2.0.24) is not working properly when using PDF report generator options with scansummary, resulting in a scan failed result even the scan finishing correctly. This behavior is happing in the actual @main of this repo.
Expected behavior
Keep using the scansummary option to generate PDFs reports without failed the action.
Actual behavior
The action failed when using the option scansummary to generete PDFs. As shown here:
2024/04/09 12:22:15 Scan Finished with status:  Completed
report option "scansummary" unavailable
Creating PR decoration for scan ID: 5f6f322a-9c98-.....
2024/04/09 12:22:50 github PR comment created successfully.
2024/04/09 12:23:00 Creating Markdown Summary Report:  cx_result.md
Scan failed

Steps to reproduce

Create an action using aditional params to generate PDF report using the scansummary option:
--report-format pdf --report-pdf-options Sast,Sca,Iac-Security,**ScanSummary**,ExecutiveSummary,ScanResults
Run the action and wait to fail.

Additional comments
Propose to fix:
Looks like the updated ast-cli version (version 2.0.72)  is not working properly, so maybe downgrade the version to use a versino that doesn't have this behavior (2.0.71) or update after they fix it.
An issue is already open in ast-cli repo related to this problem: https://github.com/Checkmarx/ast-cli/issues/703

Solved


WIP: Implement Streams for Forms

Connection with issue(s)

Close #1155
Solution description
FormBuilderState now has a StreamSubscription named onChanged so that people can subscribe to the stream of changes and react to the changes.
This PR is a WIP (work-in-progress) and should not be merged yet.

Devs can use _formKey.currentState!.onChanged.listen((FormBuilderFields fields) {}) to listen to the form changes.
Devs can use _formKey.currentState!.onChanged.cancel() to dispose of the stream.
A very primitive example has been implemented, but is subject to change. See the video below.
I have no idea as to how to test the streams. I have been trying to test it for a week now and cannot do so. That is the main reason why I don't want this feature to be merged. Let me first figure out a way to test the streams. The example works like a charm, though.

Screenshots or Videos
https://user-images.githubusercontent.com/2399084/205637854-38e66db1-95b1-435d-93ed-2516b36b1c3a.mp4
This is what I added in example project, which is not very elegant to look at. I will refactor this later on. This is only for demo purposes.
As you can see, StreamBuilder reacts to the changes live and re-renders each time the form is updated.
To Do

[x] Read contributing guide
[ ] Check the original issue to confirm it is fully satisfied
[x] Add solution description to help guide reviewers
[ ] Add unit test to verify new or fixed behaviour
[ ] If apply, add documentation to code properties and package readme

I stylized the example app. You can see the changes in realtime in a table.
https://user-images.githubusercontent.com/2399084/205753276-3725bb93-9574-4961-bd15-0a379c22a898.mp4

Tests are done. Added a section to readme. There are still things to do, though. Currently, StreamBuilder strangely needs setState to refresh its content in the example app. I'll try to write a StatelessWidget and investigate it.

So, I've changed example/main.dart on my local machine. This is what I've done, and it's the ideal usecase in my mind.
The Minimum Ideal Usecase
class CompleteForm extends StatelessWidget {
  final _formKey = GlobalKey<FormBuilderState>();

  CompleteForm({super.key});

  @override
  Widget build(BuildContext context) {
    return FormBuilder(
      key: _formKey,
      child: Scaffold(
        body: Padding(
          padding: const EdgeInsets.all(8),
          child: Center(
            child: Column(
              mainAxisSize: MainAxisSize.min,
              children: [
                FormBuilderTextField(name: 'text1'),
                StreamBuilder(
                  stream: _formKey.currentState!.onChanged,
                  builder:
                      (context, AsyncSnapshot<FormBuilderFields> snapshot) {
                    return Text(
                        snapshot.data?.values.first.value.toString() ?? 'null');
                  },
                ),
              ],
            ),
          ),
        ),
      ),
    );
  }
}

Why do I consider this as ideal?

It's a stateless widget. Flutter won't unnecessarily hold states for rerendering like stateful widget.
Stateless widgets are much more readable and comprehensible than stateless ones.

This doesn't work though. The reason is currentState in _formKey.currentState!.onChanged is null when the app is first loaded. Thus the whole app crashes saying null-check operator used in a null value.
This can be avoided by hot reloading or hot refreshing the app, but a real world user won't be able to do that.
What Works
class CompleteForm extends StatefulWidget {
  const CompleteForm({super.key});

  @override
  State<CompleteForm> createState() => _CompleteFormState();
}

class _CompleteFormState extends State<CompleteForm> {
  final _formKey = GlobalKey<FormBuilderState>();

  @override
  Widget build(BuildContext context) {
    return FormBuilder(
      key: _formKey,
      onChanged: () {
        setState(() {});
      },
      child: Scaffold(
        body: Padding(
          padding: const EdgeInsets.all(8),
          child: Center(
            child: Column(
              mainAxisSize: MainAxisSize.min,
              children: [
                FormBuilderTextField(name: 'text1'),
                StreamBuilder(
                  stream: _formKey.currentState?.onChanged,
                  builder:
                      (context, AsyncSnapshot<FormBuilderFields> snapshot) {
                    return Text(
                        snapshot.data?.values.first.value.toString() ?? 'null');
                  },
                ),
              ],
            ),
          ),
        ),
      ),
    );
  }
}

This one works because we do setState on form's each onChanged.
Why do I not find this ideal usecase?

Again, readability.
onChanged on form constantly does setState on each keypress, which is frequent enough that it is not desirable. It might cause some performance and consistency issues in some edge cases (like performance overhead or keyboard buttons not responding in some cases as the user is fast-typing).

So, from this point on, I need to figure out a way to make sure that currentState is not null and keep the devs on StatelessWidget. I'm not quite sure as to how, but I will figure it out somehow I guess.

These days, I'm busy with work, so I need to have a hold on this. Will come back to it tho.

It's been almost a month. I've asked this question on SO. Let's see if someone can figure it out.
This comment from 1157 does not do anything good in our case.


THRIFT-3637: Dart compact protocol

https://issues.apache.org/jira/browse/THRIFT-3637

@brianshannan-wf @markerickson-wf  could you look into 3 make cross failures ?
It may be http servers and haskell's faults so in that case we can put these three to the test/known_failures.

@nsuke Thanks, it looks like it is just these three combinations.  Other combinations involving dart + compact and the same languages / transports are passing.  We'll look into it.
https://issues.apache.org/jira/browse/THRIFT-3702


check argv to detect if install in setup.py

this would avoid installing numpy even when --help is called on setup

See qiime-default-reference for an example of how to do this.

I wonder if something like the following is what you had in mind:
# numpy is not required with help or information display options
if any(arg.startswith('--') and arg not in ['--verbose', '--quiet', '--dry-run', '--no-user-cfg', '--command-packages'] for arg in sys.argv):
    setup_requires = []
else:
    setup_requires = ['numpy >= 1.9.2']

That makes sense, thanks for the code! Are you interested in issuing a pull request?

Closing in favor of #1296.


README.md#official-links

🐛 Bug Report
https://github.com/matter-labs/zksync-era/blob/main/README.md#official-links
📝 Description
Discord link is use https://join.zksync.dev/ may be use https://discord.com/invite/xetcQ7S will better

The new link doesn't work for me either. I think there is something wrong with the Discord server in general. I joined the server one evening and was just trying to get a feeling for the existing channels without writing anything. I did join the developer group to get access to the corresponding channels. Overall I planned to read more in the first weeks without writing anything. Looks like I got banned or the server is unavailable now.


[Feature][Datasource] support multi hosts in Datasource Module

Purpose of the pull request

Brief change log

Verify this pull request

This pull request is code cleanup without any test coverage.
(or)
This pull request is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:

Codecov Report

:exclamation: No coverage uploaded for pull request base (2.0.1-prepare@4e8507e). Click here to learn what that means.
The diff coverage is n/a.

@@               Coverage Diff                @@
##             2.0.1-prepare    #7251   +/-   ##
================================================
  Coverage                 ?   32.13%
  Complexity               ?     1569
================================================
  Files                    ?      432
  Lines                    ?    14484
  Branches                 ?     1438
================================================
  Hits                     ?     4655
  Misses                   ?     9369
  Partials                 ?      460

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4e8507e...e3cf15f. Read the comment docs.


Create feature where tool automatically loads UI components present in Products folder

This will not be implemented here. We will have a new tool that will be able to implement that.


Add CSS style to element challenge missing final step

Challenge Use CSS Selectors to Style Elements has an issue.
User Agent is: Mozilla/5.0 (Windows NT 10.0; WOW64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/49.0.2623.87 Safari/537.36.
Please describe how to reproduce this issue, and include links to screenshots if possible.
My code:

CatPhotoApp

Kitty ipsum dolor sit amet, shed everywhere shed everywhere stretching attack your ankles chase the red dot, hairball run catnip eat the grass sniff.

exercise did not include final step adding  text

The text is already there.
Starting code:

CatPhotoApp

Kitty ipsum dolor sit amet, shed everywhere shed everywhere stretching attack your ankles chase the red dot, hairball run catnip eat the grass sniff.

Please elaborate if you're talking about some other text or, if I have missed the point of your post.

Thanks so much! Sorry about that. I'm new. :)
On Tue, Mar 29, 2016 at 3:25 PM, Brian<EMAIL_ADDRESS>wrote:

The text is already there.

Please elaborate if you're talking about some other text or, if I have
missed the point of your post.
—
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
https://github.com/FreeCodeCamp/FreeCodeCamp/issues/7801#issuecomment-203137539

--

Laura Brown M.B.A., P.M.P., C.S.M., S.M.A.C.
Scrum Master - Senior Executive Project Manager
http://www.linkedin.com/pub/laura-brown/0/7b3/32a

http://lauradbrown.smugmug.com/
FundRaising Campaign for Ecuador: http://bit.ly/1N1A7ZQ

@lauradb Don't worry about it.
Closing as resolved.

Saved my day! Thank you so much👊🏾

omg thanks so much for posting this it helped me out so much as well :)


Example request: Fluxcd example?

So this is probably the wrong place, but I'm not sure to where's a better place to ask. Is there an example combining both tekton pipelines and fluxcd for gitops?
Flux is most useful when used as a deployment tool at the end of a Continuous Delivery pipeline (like Tekton!!!) . Flux will make sure that your new container images and config changes are propagated to the cluster.
Flux is really three things, which are munged together for those historical reasons we're always hearing about.

something that applies kubernetes manifests in git to a cluster, with some embellishments (like being able to ignore resources)
something which automates the update of image refs in manifests, with an API and command-line tooling
an image metadata database which you can query

I would ideally like to have a github pull request trigger a tekton pipeline which will build an image, and push it to a docker registry, and then have flux update my manifest image refs in git, and apply them to a kubernetes cluster. However, I could avoid polling a docker registry if a tekton pipeline were to use the flux api or command line tooling to update the manifest image refs..
Is that something that someone has already got working?

This was the first I'd heard of Flux, so thanks for the heads-up. I'm not aware of anyone already getting these two tools running together but I don't see anything immediately problematic in the description of how Flux operates.
Running specific containers and command line tools as part of a Tekton Task is eminently doable - in fact it's how they fundamentally work. See the steps field in the Task spec here: https://github.com/tektoncd/pipeline/blob/master/docs/tasks.md#syntax
Calling an API is likewise easy to do given the right Secrets and container / CLI tools to make the requests.
I'm going to close this issue since it's not really an issue with Tekton Pipelines per se and instead suggest that you join us on Slack to try and find people interested in a similar use case to your own: https://github.com/tektoncd/community/blob/master/contact.md#slack

Chatted with @bobcatfish about this a bit more who thought this would be an excellent opportunity to develop a Catalog entry that shows how to tie the two systems together.  I'm going to reopen this issue for anyone who is interested in working on this further!

Hi @sbwsg ,
I'm new to tekton, I think this issue is a good opportunity to start contributing,
Can I work on it?
Thanks :)

sure thing, have at it @medkbadri !

@medkbadri are you still working on (or planning to work on) this issue?

@dibyom
Hey, I will update asap (already working with tetkton and flux combined in a project for my company)
will just clean files

@medkbadri I don't suppose you have the unclean files lying around anywhere, do you?

Also interested on this. How is the progress going? Can I help? @medkbadri

Tekton can build and publish images, Flux should be able to detect the new images and update the cluster accordingly.
They should operate quite separately, is there something needed at all ?


Fix funding display

Fixes a display issue with the hourly funding rate in MarketDetails.
Expected behavior is:

Display 1H while the page loads
If the 1H funding rate query fails, display the instant funding rate from the contract

Description
The order that we retrieve data is causing a display bug in MarketDetails where it flashes the instant funding rate before displaying the hourly funding rate. The instant rate is used as a backup if the hourly query fails. This change checks if the funding query has a value of null before displaying the instant rate, which makes sure the query was attempted and failed.
How Has This Been Tested?

Forced null values for 1 market
Forced null values for all markets

Both situations behaved as expected.

Works fine on Optimism. When switching network to OP Goerli, it shows Instant again until I refresh or go to dashboard and return to a market. On L1, shows Instant only.
Not sure it's a blocker. When switching back to L2 Optimism, 1h Funding shows correctly again.


assert_no_error() fails immediately after build_glium() in the triangle example on OSX

I was debugging my own program and noticed that assert_no_error() was failing after build_glium().  Inserting assert_no_error() into the glium triangle example also failed.
Trace file here: https://www.dropbox.com/s/lsa63yj35hso69e/triangle.trace?dl=0

Does the program work?
After some investigation I think it comes from this code: https://github.com/tomaka/glium/blob/master/src/context/extensions.rs#L228
On older versions of OpenGL, you have to call glGetString to get the list of extensions, and on newer versions you have to call glGetStringi. In this code glium tries to call the former, and if it fails calls the latter. The problem is that this probably triggers a GL error.
I'll fix this to be cleaner, and add assert_no_error at the end of the initialization.

The program does work, but it makes it hard for me to find the other error in my program :cry:

I merged #782, maybe this fixes it.

This seems to have done it; thanks!
Now to find the actual error in my program! :sob:


Editor sizes wrong when moving between retina screen and non-retina 2nd monitor

Operating system or device - Godot version:
OSX 10.11
Godot 2.1.3
Macbook pro retina with attached thunderbolt display.
Issue description:
Godot opens up fine on the laptop window. I can move the project browser fine between the monitors. Open up a project it renders fine on the retina display but gets completely blown out of perportions on the thunderbolt display.
My guess is that its not detecting the switch between retina resolution on the one monitor and non-retina on the 2nd monitor and thus not adjusting the scaling accordingly.
Strange that the project selection window works fine though.
Steps to reproduce:
Move the editor window between a retina and non-retina display

Closing as duplicate of #5688.


Update parameters

This updates the Vagrant boxes from the Bento project to the official (?) boxes.
Bento seems to be loosely maintained, and official boxes exist, so this probably makes sense?

To Do: Manually test some of those, in case absurd things happen like missing TAR.


Azure OpenAI: add parity custom (re)serialization logic to mirror custom deserialization logic of StreamingChatCompletionsUpdate

Library name
Azure.AI.OpenAI
Please describe the feature.
The AOAI .NET SDK provides a custom surface to simplify consumption of streamed chat completion responses, StreamingChatCompletionsUpdate. In situations where a client needs to act as a passthrough or intermediate agent, this customization then requires said client to hand-reserialize the streaming object model back into the appropriate JSON, which is highly cumbersome and (in this specific circumstance) ironically "made harder via attempts to make things easier."
Given there's no direct utility of serializing the custom object model, it could be very helpful for the SDK to provide custom serialization that reproduces the original wire format to more easily enable this style of use case.

We just added support for serializing .NET model types to the exact "wire" format. This feature is not yet exposed in the OpenAI SDK, but we should do it. There is a rudimentary doc about it: https://github.com/Azure/azure-sdk-for-net/tree/main/sdk/core/System.ClientModel#read-and-write-persistable-models


Airfoil Data

In the given example of NREL5MW, have the data cl and cd of airfoil DU21 been tested and verified when Re=7000000 or Re=6000000? Is there any experimental data to support it?

Dear @EVElove444,
See a similar question asked and answered on our forum: https://forums.nrel.gov/t/original-nrel-5-mw-2d-airfoil-data/713.  My understanding is that the original 2D airfoil data for the DU airfoils of the NREL 5-MW baseline wind turbine were wind tunnel tested between approximate -10 to +20 deg angle of attack and a Reynolds number of 7M.
Best regards,

Hello, the answer you gave did not directly give the data of DU airfoil, angle of attack of -10 to +20 degrees and RE=7M wind tunnel test, such as the relationship between angle of attack and CL/CD, etc. Are there any references? Thank you again.

My post dated Jun 26, 2013 in the forum topic I linked to contains zip archive with the airfoil data you seek.

Greetings, Do the aerodynamic data for the airfoil in the 5MW baseline file, which are presented at a Reynolds number of 7,500,000, originate from wind tunnel experiments and subsequently extrapolated to the range of -180-180°? Discontinuities in the drag coefficient are observed in the NACA64A17 airfoil input file between 4 and 12 degrees, as well as after 10 degrees, resulting in significant fluctuations in the lift-to-drag ratio. Is this typical? The discrepancy between the wind tunnel data and the calculated results utilizing XFOIL and SST transition models at the identical Reynolds number of 7500000 is substantial, and the ideal range of lift to drag ratios differs. Does this appear to be accurate?

Dear @EVElove444
The airfoil data of the NACA64 airfoil is actually for a Reynolds number of 6M.
Regardless, the DOWEC report from which the original 2D data came mentions the following:

the airfoil data for the NACA 64-618 as copied from appendix IV of Abbott and Von Doenhoff, apply to a Reynolds number of 6 million

These data were then extended to the full AoA range, as also mentioned in the DOWEC report:

For all airfoils measured coefficients were available between angles of attack of approximately -10° and +20°, depending on the airfoil. These coefficients were extended to -180° and +180° using results from the ECN tool StC (Stall Coefficients), release "MAR-2001"

The aspect ratio of the blade used for the StC calculations was (A) = 17, which is on the conservative side when comparing it with the PHATAS estimation (A) = 16.4.

The NREL version of the data includes corrections for rotational stall delay based on the Selig and Eggars method and to drag using the Viterna method.
Best regards,


Use the Clingo --time-limit option only on Solving phase

Hello,
I'm trying to run some benchmarks and I noticed that the --time-limit option also count the pre-processing and grounding phases so, with big amount of data, it kills the process even before it start the solving phase.
This is my current batch file:
for f in $FILES
do
	echo $f
	clingo 0 --time-limit=300 --mode=clingo -t 8 test.lp $f > ./benchmarks/clingo/results/result_$i.txt
	i=$((++i))
done

Is there any way to start the timer when the solving stage is reached?
Thank you!

There is no such option. You could ground your program first and then solve it:
clingo --mode=gringo test.lp > test.asp
clingo --mode=clasp test.asp --time-limit=300

There is no such option. You could ground your program first and then solve it:
clingo --mode=gringo test.lp > test.asp
clingo --mode=clasp test.asp --time-limit=300

That was exactly what I was looking for!
Thanks a lot!!

Sorry, I still have an issue:
Running clingo --mode=clasp 0 test.asp --time-limit=20 -t8 kills the process in "Reading from test.asp". So, still before starting the Solving step, right?
Any way to avoid this?
Thanks again!

Yes, there is still reading and preprocessing. There is no option to just set a time limit on the solving time. When we do benchmarking we typically include these times.

Thanks!


Solar heat tab refers to solar panels

The solar heat tab refers to the solar panels section of households and buildings. I think it would be helpful if the text makes clear this is about solar thermal. Secondly, for buildings solar thermal is in the space heating tab, not solar panel tab.

Fixed:


add zero shot classification task

This PR adds zero shot classification, and should be merged along with this PR: https://github.com/huggingface/autonlp-backend/pull/681

Oh, one thing that occurred to me: we'll need to have a special AutoTrain payload to specify the hardware for this task. We should definitely include that in this PR once that feature is implemented in AutoTrain

@mathemakitten now that https://github.com/huggingface/autotrain-backend/pull/681 has been merged, WDYT about giving this feature a test run with a small model / dataset that can run on the default AutoTrain GPUs?

Ran this successfully with Autotrain main commit 9a81e379363ae3d9fade37491b15185c3da93e7f (Sept 8), results here.
Will add a modification to the payload shortly, then I think we're good to go!


Clean DatabaseLog table before migrations (task #5457)

Run the garbage collector shell which cleans up the database_log
table, before executing the migrations.

Codecov Report

Merging #479 into master will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master     #479   +/-   ##
=========================================
  Coverage     28.23%   28.23%
  Complexity      809      809
=========================================
  Files            72       72
  Lines          2787     2787
=========================================
  Hits            787      787
  Misses         2000     2000

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b1b833c...473b86b. Read the comment docs.


Do not decode CDATA content

In #109, I mistakenly decode the raw text content in a CDATA block.

oops :)
thanks for the fix

Mind releasing this? :)

done v2.7.1


Fix for issue #38 Handle XMLNS protocol change from http to https

The repo successfully builds after the changes
Also validated with the examples provided at https://dmg.org/pmml/pmml_examples/

Added some more comments to #38.
TLDR: The protocol change from http to https was a DMG.org mistake, and should be rejected by PMML vendors.


Adjustable Cave Generation Depth

A way to limit caves to generate only below a certain depth would make building underground/mountain stuff a lot less annoying.

added in the upcoming release


PR to add some hash problems

(Put an X inside the [ ] to denote check mark [X].)

[x] If creating a new file :

[x] added links to it in the README files ?
[x] included tests with it ?
[x] added description (overview of algorithm, time and space compleixty, and possible edge case) in docstrings ?

[ ] if done some changes :

[ ] wrote short description in the PR explaining what the changes do ?
[ ] Fixes #[issue number] if related to any issue

[ ] other

@goswami-rahul @keon I have updated!

Pull Request Test Coverage Report for Build 715

62 of 65 (95.38%)  changed or added relevant lines in 6 files are covered.
5 unchanged lines in 2 files lost coverage.
Overall coverage decreased (-0.6%) to 71.426%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

algorithms/map/word_pattern.py
14
15
93.33%

algorithms/map/is_isomorphic.py
12
14
85.71%

Files with Coverage Reduction
New Missed Lines
%

algorithms/sort/top_sort.py
2
90.38%

tests/test_backtrack.py
3
95.92%

Totals

Change from base Build 712:
-0.6%

Covered Lines:
4297

Relevant Lines:
6016

💛  - Coveralls

nice work :)


Missing Tests?

I have made some improvements to the ingester, but it looks like the way the tests work is to download the test files from a mongodb database. Is it possible to add those test files into the repo or provide it in some other way?

@ramarnat want to compare notes on your updates?

The files we used for testing are not shared as it depended on the specific customer use cases. It is possible to recreate these tests with your files, however I can understand that keeping these in mongodb etc. would be a pain.

@jonhilgart22 I moved some of the atomic functions to rust. I didn't want to make a a lot of other changes without the tests because the code seems to deal with a lot of edge cases, and without the tests it's hard to know what the impact of a change might be.
@ansukla-salesforce I understand why they maybe hard to share. maybe the tests can be shared under an NDA or private repo and we can run them independently before contribution. Maybe there is a way to do something via gihubactions that can run the tests without exposing the tests publicly.

The files we used for testing are not shared as it depended on the specific customer use cases. It is possible to recreate these tests with your files, however I can understand that keeping these in mongodb etc. would be a pain.

It would be great to see some test files to ensure existing functionality works!