Build fails

Original clone of repository complains about:
<EMAIL_ADDRESS>The engine "node" is incompatible with this module. Expected version ">=4 <=9". (installed node version: 10.6.0)
The solution is to remove yarn.lock and rebuild but that results in :
node-pre-gyp ERR! Tried to download(403): https://mapbox-node-binary.s3.amazonaws.com/sqlite3/v3.1.13/node-v64-darwin-x64.tar.gz
Any ideas on how to fix it?
The issue is with shopify-express dependency.

Having the same problem

I get this issue when pushing to heroku but is fine running locally. My guess would be I have whatever module is being requested locally cached and is failing for any new install.

Same here, pushed to heroku and had this issue. It shouldn't need sqlite if I am not using that strategy correct?

I was able to resolve this. I made sure my local and Heroku node versions matched up. Heroku was trying to use some version of 10, which sqlite 3 doesn't seem to work.
Locally I was using 8.9.1, so I set that same version for Heroku and it all worked :)

I ended up updating sqlite version to ^4.x.x in shopify-express module as that was causing my issue. The one used in the module is deprecated.

Facing Issue on after running git push heroku master
Tried after after updat sqlite3 version but still same issue.
Can someone face same issue annd give solution for this.
Below are console logs
-----> Creating runtime environment
    NPM_CONFIG_LOGLEVEL=error
    NPM_CONFIG_PRODUCTION=true
    YARN_PRODUCTION=true
    NODE_VERBOSE=false
    NODE_ENV=production
    NODE_MODULES_CACHE=true

-----> Installing binaries
engines.node (package.json):  >= 8.1.0
engines.npm (package.json):   unspecified (use default)
engines.yarn (package.json):  unspecified (use default)
    Resolving node version >= 8.1.0...
    Downloading and installing node 10.7.0...
    Using default npm version: 6.1.0
    Resolving yarn version 1.x...
    Downloading and installing yarn (1.9.2)...
    Installed yarn 1.9.2

-----> Restoring cache
Skipping cache restore (not-found)
-----> Building dependencies
Installing node modules (yarn.lock)
yarn install v1.9.2
[1/4] Resolving packages...
[2/4] Fetching packages...
(node:342) [DEP0005] DeprecationWarning: Buffer() is deprecated due to security and usability issues. Please use the Buffer.alloc(), Buffer.allocUnsafe(),
info<EMAIL_ADDRESS>The platform "linux" is incompatible with this module.
info<EMAIL_ADDRESS>is an optional dependency and failed compatibility check. Excluding it from installation.
[3/4] Linking dependencies...
warning " ><EMAIL_ADDRESS>has incorrect peer dependency<EMAIL_ADDRESS>[4/4] Building fresh packages...
error /tmp/build_81b459888c04d03a9e30bad88b2386e7/node_modules/sqlite3: Command failed.
Exit code: 1
Command: node-pre-gyp install --fallback-to-build
Arguments:
Directory: /tmp/build_81b459888c04d03a9e30bad88b2386e7/node_modules/sqlite3
Output:
node-pre-gyp ERR! Tried to download(403): https://mapbox-node-binary.s3.amazonaws.com/sqlite3/v3.1.13/node-v64-linux-x64.tar.gz
node-pre-gyp ERR! Pre-built binaries not found for<EMAIL_ADDRESS>and<EMAIL_ADDRESS>(node-v64 ABI, glibc) (falling back to source compile with node-gyp)
node-pre-gyp ERR! Tried to download(undefined): https://mapbox-node-binary.s3.amazonaws.com/sqlite3/v3.1.13/node-v64-linux-x64.tar.gz
node-pre-gyp ERR! Pre-built binaries not found for<EMAIL_ADDRESS>and<EMAIL_ADDRESS>(node-v64 ABI, glibc) (falling back to source compile with node-gyp)
make: Entering directory '/tmp/build_81b459888c04d03a9e30bad88b2386e7/node_modules/sqlite3/build'
ACTION deps_sqlite3_gyp_action_before_build_target_unpack_sqlite_dep Release/obj/gen/sqlite-autoconf-3150000/sqlite3.c
make: Entering directory '/tmp/build_81b459888c04d03a9e30bad88b2386e7/node_modules/sqlite3/build'
ACTION deps_sqlite3_gyp_action_before_build_target_unpack_sqlite_dep Release/obj/gen/sqlite-autoconf-3150000/sqlite3.c
TOUCH Release/obj.target/deps/action_before_build.stamp
CC(target) Release/obj.target/sqlite3/gen/sqlite-autoconf-3150000/sqlite3.o
TOUCH Release/obj.target/deps/action_before_build.stamp
CC(target) Release/obj.target/sqlite3/gen/sqlite-autoconf-3150000/sqlite3.o
AR(target) Release/obj.target/deps/sqlite3.a
COPY Release/sqlite3.a
CXX(target) Release/obj.target/node_sqlite3/src/database.o
AR(target) Release/obj.target/deps/sqlite3.a
COPY Release/sqlite3.a
CXX(target) Release/obj.target/node_sqlite3/src/database.o
In file included from ../../nan/nan.h:192:0,
from ../src/database.h:10,
from ../src/database.cc:4:
../../nan/nan_maybe_43_inl.h: In function Nan::Maybe<bool> Nan::ForceSet(v8::Local<v8::Object>, v8::Local<v8::Value>, v8::Local<v8::Value>, v8::PropertyAt         ../../nan/nan_maybe_43_inl.h:112:15: error: class v8::Object' has no member named ForceSet'         return obj->ForceSet(isolate->GetCurrentContext(), key, value, attribs);         ^         In file included from ../../nan/nan.h:192:0,         from ../src/database.h:10,         from ../src/database.cc:4:         ../../nan/nan_maybe_43_inl.h: In function Nan::Maybe Nan::ForceSet(v8::Localv8::Object, v8::Localv8::Value, v8::Localv8::Value, v8::PropertyAt
../../nan/nan_maybe_43_inl.h:112:15: error: class v8::Object' has no member named ForceSet'
return obj->ForceSet(isolate->GetCurrentContext(), key, value, attribs);
^
In file included from ../src/database.h:10:0,
from ../src/database.cc:4:
../../nan/nan.h: In function v8::Local<v8::Value> Nan::MakeCallback(v8::Local<v8::Object>, v8::Local<v8::Function>, int, v8::Local<v8::Value>*)':         ../../nan/nan.h:835:60: warning: v8::Localv8::Value node::MakeCallback(v8::Isolate*, v8::Localv8::Object, v8::Localv8::Function, int, v8::Local<v8::
v8::Isolate::GetCurrent(), target, func, argc, argv);
^
In file included from ../src/database.h:10:0,
from ../src/database.cc:4:
../../nan/nan.h: In function v8::Local<v8::Value> Nan::MakeCallback(v8::Local<v8::Object>, v8::Local<v8::Function>, int, v8::Local<v8::Value>*)':         ../../nan/nan.h:835:60: warning: v8::Localv8::Value node::MakeCallback(v8::Isolate*, v8::Localv8::Object, v8::Localv8::Function, int, v8::Local<v8::
v8::Isolate::GetCurrent(), target, func, argc, argv);
^
In file included from ../../nan/nan.h:49:0,
from ../src/database.h:10,
from ../src/database.cc:4:
/app/.node-gyp/10.7.0/include/node/node.h:172:50: note: declared here
NODE_EXTERN v8::Localv8::Value MakeCallback(
^
/app/.node-gyp/10.7.0/include/node/node.h:88:42: note: in definition of macro NODE_DEPRECATED'         __attribute__((deprecated(message))) declarator         ^         In file included from ../../nan/nan.h:49:0,         from ../src/database.h:10,         from ../src/database.cc:4:         /app/.node-gyp/10.7.0/include/node/node.h:172:50: note: declared here         NODE_EXTERN v8::Local<v8::Value> MakeCallback(         ^         /app/.node-gyp/10.7.0/include/node/node.h:88:42: note: in definition of macro NODE_DEPRECATED'
attribute((deprecated(message))) declarator
^
In file included from ../src/database.h:10:0,
from ../src/database.cc:4:
../../nan/nan.h: In function v8::Local<v8::Value> Nan::MakeCallback(v8::Local<v8::Object>, v8::Local<v8::String>, int, v8::Local<v8::Value>*)':         ../../nan/nan.h:850:62: warning: v8::Localv8::Value node::MakeCallback(v8::Isolate*, v8::Localv8::Object, v8::Localv8::String, int, v8::Local<v8::Va
v8::Isolate::GetCurrent(), target, symbol, argc, argv);
^
In file included from ../../nan/nan.h:49:0,
from ../src/database.h:10,
from ../src/database.cc:4:
/app/.node-gyp/10.7.0/include/node/node.h:165:50: note: declared here
NODE_EXTERN v8::Localv8::Value MakeCallback(
^
/app/.node-gyp/10.7.0/include/node/node.h:88:42: note: in definition of macro NODE_DEPRECATED'         __attribute__((deprecated(message))) declarator         ^         In file included from ../src/database.h:10:0,         from ../src/database.cc:4:         ../../nan/nan.h: In function v8::Localv8::Value Nan::MakeCallback(v8::Localv8::Object, const char*, int, v8::Localv8::Value)':
../../nan/nan.h:865:62: warning: v8::Local<v8::Value> node::MakeCallback(v8::Isolate*, v8::Local<v8::Object>, const char*, int, v8::Local<v8::Value>*)' is         v8::Isolate::GetCurrent(), target, method, argc, argv);         ^         In file included from ../../nan/nan.h:49:0,         from ../src/database.h:10,         from ../src/database.cc:4:         /app/.node-gyp/10.7.0/include/node/node.h:158:50: note: declared here         NODE_EXTERN v8::Local<v8::Value> MakeCallback(         ^         /app/.node-gyp/10.7.0/include/node/node.h:88:42: note: in definition of macro NODE_DEPRECATED'
attribute((deprecated(message))) declarator
^
In file included from ../src/database.h:10:0,
from ../src/database.cc:4:
../../nan/nan.h: In function v8::Local<v8::Value> Nan::MakeCallback(v8::Local<v8::Object>, v8::Local<v8::String>, int, v8::Local<v8::Value>*)':         ../../nan/nan.h:850:62: warning: v8::Localv8::Value node::MakeCallback(v8::Isolate, v8::Localv8::Object, v8::Localv8::String, int, v8::Local<v8::Va
v8::Isolate::GetCurrent(), target, symbol, argc, argv);
^
In file included from ../../nan/nan.h:49:0,
from ../src/database.h:10,
from ../src/database.cc:4:
/app/.node-gyp/10.7.0/include/node/node.h:165:50: note: declared here
NODE_EXTERN v8::Localv8::Value MakeCallback(
^
/app/.node-gyp/10.7.0/include/node/node.h:88:42: note: in definition of macro NODE_DEPRECATED'         __attribute__((deprecated(message))) declarator         ^         In file included from ../src/database.h:10:0,         from ../src/database.cc:4:         ../../nan/nan.h: In function v8::Localv8::Value Nan::MakeCallback(v8::Localv8::Object, const char*, int, v8::Localv8::Value)':
../../nan/nan.h:865:62: warning: v8::Local<v8::Value> node::MakeCallback(v8::Isolate*, v8::Local<v8::Object>, const char*, int, v8::Local<v8::Value>*)' is         v8::Isolate::GetCurrent(), target, method, argc, argv);         ^         In file included from ../../nan/nan.h:49:0,         from ../src/database.h:10,         from ../src/database.cc:4:         /app/.node-gyp/10.7.0/include/node/node.h:158:50: note: declared here         NODE_EXTERN v8::Local<v8::Value> MakeCallback(         ^         /app/.node-gyp/10.7.0/include/node/node.h:88:42: note: in definition of macro NODE_DEPRECATED'
attribute((deprecated(message))) declarator
^
In file included from ../src/database.h:10:0,
from ../src/database.cc:4:
../../nan/nan.h: In member function v8::Local<v8::Value> Nan::Callback::Call_(v8::Isolate*, v8::Local<v8::Object>, int, v8::Local<v8::Value>*) const':         ../../nan/nan.h:1479:5: warning: v8::Localv8::Value node::MakeCallback(v8::Isolate, v8::Localv8::Object, v8::Localv8::Function, int, v8::Local<v8::
));
^
In file included from ../../nan/nan.h:49:0,
from ../src/database.h:10,
from ../src/database.cc:4:
/app/.node-gyp/10.7.0/include/node/node.h:172:50: note: declared here
NODE_EXTERN v8::Localv8::Value MakeCallback(
^
/app/.node-gyp/10.7.0/include/node/node.h:88:42: note: in definition of macro NODE_DEPRECATED'         __attribute__((deprecated(message))) declarator         ^         In file included from ../src/database.h:10:0,         from ../src/database.cc:4:         ../../nan/nan.h: In member function v8::Localv8::Value Nan::Callback::Call_(v8::Isolate*, v8::Localv8::Object, int, v8::Localv8::Value*) const':
../../nan/nan.h:1479:5: warning: v8::Local<v8::Value> node::MakeCallback(v8::Isolate*, v8::Local<v8::Object>, v8::Local<v8::Function>, int, v8::Local<v8::         ));         ^         In file included from ../../nan/nan.h:49:0,         from ../src/database.h:10,         from ../src/database.cc:4:         /app/.node-gyp/10.7.0/include/node/node.h:172:50: note: declared here         NODE_EXTERN v8::Local<v8::Value> MakeCallback(         ^         /app/.node-gyp/10.7.0/include/node/node.h:88:42: note: in definition of macro NODE_DEPRECATED'
attribute((deprecated(message))) declarator
^
../src/database.cc: In static member function static void node_sqlite3::Database::Work_BeginOpen(node_sqlite3::Database::Baton*)':         ../src/database.cc:144:9: warning: unused variable status' [-Wunused-variable]
int status = uv_queue_work(uv_default_loop(),
^
../src/database.cc: In static member function static void node_sqlite3::Database::Work_BeginOpen(node_sqlite3::Database::Baton*)':         ../src/database.cc:144:9: warning: unused variable status' [-Wunused-variable]
int status = uv_queue_work(uv_default_loop(),
^
../src/database.cc: In static member function static void node_sqlite3::Database::Work_BeginClose(node_sqlite3::Database::Baton*)':         ../src/database.cc:230:9: warning: unused variable status' [-Wunused-variable]
int status = uv_queue_work(uv_default_loop(),
^
../src/database.cc: In static member function static void node_sqlite3::Database::Work_BeginClose(node_sqlite3::Database::Baton*)':         ../src/database.cc:230:9: warning: unused variable status' [-Wunused-variable]
int status = uv_queue_work(uv_default_loop(),
^
../src/database.cc: In static member function static void node_sqlite3::Database::Work_BeginExec(node_sqlite3::Database::Baton*)':         ../src/database.cc:525:9: warning: unused variable status' [-Wunused-variable]
int status = uv_queue_work(uv_default_loop(),
^
../src/database.cc: In static member function static void node_sqlite3::Database::Work_BeginLoadExtension(node_sqlite3::Database::Baton*)':         ../src/database.cc:625:9: warning: unused variable status' [-Wunused-variable]
int status = uv_queue_work(uv_default_loop(),
^
../src/database.cc: In static member function static void node_sqlite3::Database::Work_BeginExec(node_sqlite3::Database::Baton*)':         ../src/database.cc:525:9: warning: unused variable status' [-Wunused-variable]
int status = uv_queue_work(uv_default_loop(),
^
../src/database.cc: In static member function static void node_sqlite3::Database::Work_BeginLoadExtension(node_sqlite3::Database::Baton*)':         ../src/database.cc:625:9: warning: unused variable status' [-Wunused-variable]
int status = uv_queue_work(uv_default_loop(),
^
node_sqlite3.target.mk:115: recipe for target 'Release/obj.target/node_sqlite3/src/database.o' failed
make: Leaving directory '/tmp/build_81b459888c04d03a9e30bad88b2386e7/node_modules/sqlite3/build'
make: *** [Release/obj.target/node_sqlite3/src/database.o] Error 1
gypnode_sqlite3.target.mk:115: recipe for target 'Release/obj.target/node_sqlite3/src/database.o' failed
make: Leaving directory '/tmp/build_81b459888c04d03a9e30bad88b2386e7/node_modules/sqlite3/build'
make: *** [Release/obj.target/node_sqlite3/src/database.o] Error 1
gyp  ERR! build error
ERR! build error
gyp ERR! stack Error: make failed with exit code: 2
gyp ERR! stack     at ChildProcess.onExit (/tmp/build_81b459888c04d03a9e30bad88b2386e7/.heroku/node/lib/node_modules/npm/node_modules/node-gyp/lib/build.js
gyp ERR! stack     at ChildProcess.emit (events.js:182:13)
gyp ERR! stack     at Process.ChildProcess._handle.onexit (internal/child_process.js:237:12)
gyp ERR! System Linux 4.4.0-1019-aws
gyp ERR! command "/tmp/build_81b459888c04d03a9e30bad88b2386e7/.heroku/node/bin/node" "/tmp/build_81b459888c04d03a9e30bad88b2386e7/.heroku/node/lib/node_mod
modules/sqlite3/lib/binding/node-v64-linux-x64/node_sqlite3.node" "--module_name=node_sqlite3" "--module_path=/tmp/build_81b459888c04d03a9e30bad88b2386e7/node_modu
gypgyp  ERR!ERR!  stackcwd Error: make failed with exit code: 2
/tmp/build_81b459888c04d03a9e30bad88b2386e7/node_modules/sqlite3
gypgyp  ERR!ERR!  stacknode -v v10.7.0
at ChildProcess.onExit (/tmp/build_81b459888c04d03a9e30bad88b2386e7/.heroku/node/lib/node_modules/npm/node_modules/node-gyp/lib/build.js:258:23)
gypgyp  ERR!ERR!  stacknode-gyp -v     at ChildProcess.emit (events.js:182:13)
v3.6.2
gyp gypERR!  ERR!stack     at Process.ChildProcess._handle.onexit (internal/child_process.js:237:12)
not ok
gyp ERR! System Linux 4.4.0-1019-aws
gyp ERR! command "/tmp/build_81b459888c04d03a9e30bad88b2386e7/.heroku/node/bin/node" "/tmp/build_81b459888c04d03a9e30bad88b2386e7/.heroku/node/lib/node_mod
modules/sqlite3/lib/binding/node-v64-linux-x64/node_sqlite3.node" "--module_name=node_sqlite3" "--module_path=/tmp/build_81b459888c04d03a9e30bad88b2386e7/node_modu
gyp ERR! cwd /tmp/build_81b459888c04d03a9e30bad88b2386e7/node_modules/sqlite3
gyp ERR! node -v v10.7.0
gyp ERR! node-gyp -v v3.6.2
gyp ERR!node-pre-gyp ERR! build error
not ok
node-pre-gyp ERR! stack Error: Failed to execute '/tmp/build_81b459888c04d03a9e30bad88b2386e7/.heroku/node/bin/node /tmp/build_81b459888c04d03a9e30bad88b23
3a9e30bad88b2386e7/node_modules/sqlite3/lib/binding/node-v64-linux-x64/node_sqlite3.node --module_name=node_sqlite3 --module_path=/tmp/build_81b459888c04d03a9e30ba
node-pre-gyp ERR! stack     at ChildProcess. (/tmp/build_81b459888c04d03a9e30bad88b2386e7/node_modules/node-pre-gyp/lib/util/compile.js:83:29)
node-pre-gyp ERR! stack     at ChildProcess.emit (events.js:182:13)
node-pre-gyp ERR! stack     at maybeClose (internal/child_process.js:961:16)
node-pre-gyp ERR! stack     at Process.ChildProcess._handle.onexit (internal/child_process.js:248:5)
node-pre-gyp ERR! System Linux 4.4.0-1019-aws
node-pre-gyp ERR! command "/tmp/build_81b459888c04d03a9e30bad88b2386e7/.heroku/node/bin/node" "/tmp/build_81b459888c04d03a9e30bad88b2386e7/node_modules/sql
node-pre-gyp ERR! cwd /tmp/build_81b459888c04d03a9e30bad88b2386e7/node_modules/sqlite3
node-pre-gyp ERR! node -v v10.7.0
node-pre-gyp ERR! node-pre-gyp -v v0.6.39
node-pre-gyp ERR! not ok
Failed to execute '/tmp/build_81b459888c04d03a9e30bad88b2386e7/.heroku/node/bin/node /tmp/build_81b459888c04d03a9e30bad88b2386e7/.heroku/node/lib/node_modu
/sqlite3/lib/binding/node-v64-linux-x64/node_sqlite3.node --module_name=node_sqlite3 --module_path=/tmp/build_81b459888c04d03a9e30bad88b2386e7/node_modules/sqlite3
info Visit https://yarnpkg.com/en/docs/cli/install for documentation about this command.
-----> Build failed
    We're sorry this build is failing! You can troubleshoot common issues here:
    https://devcenter.heroku.com/articles/troubleshooting-node-deploys

    Some possible problems:

    - Dangerous semver range (>) in engines.node
    https://devcenter.heroku.com/articles/nodejs-support#specifying-a-node-js-version

    Love,
    Heroku

!     Push rejected, failed to compile Node.js app.
!     Push failed
Verifying deploy...
!       Push rejected to shopifynodereact.
: Your console font probably doesn't support Unicode. If you experience strange characters in the output, consider switching to a TrueType font such as Consolas!
s://git.heroku.com/shopifynodereact.git
ote rejected] master -> master (pre-receive hook declined)
failed to push some refs to 'https://git.heroku.com/shopifynodereact.git'

Deleting upath from yarn.lock and allowing it to install a newer version worked for me.

Closing because this project is now deprecated.


Bot sending duplicates

Hello everyone!
I'm a newcomer for Telegram bot programming and I'm not really sure if this is a bug or it's me doing something wrong. If that's the case forgive me!
I'm trying to create a bot which simply returns data from a json file, filtering and manipulating it. Each json has a tag called "level", so I wrote a "search by level" callback query. Once is fired, this callback sends a message to ask the user to input the level (from 0 to 9). Then the bot simply reads the json and filters the output to send as a message.
The problem is that it sends duplicates while the callback is fired more than once.
Here's the code:
 val holder = deserializeSpells("/home/nicola/Desktop/formattedFile.json")
 val bot = bot {
        dispatch {
            command("start") {
                bot.sendMessage(ChatId.fromId(update.message!!.chat.id),"Benvenuto in WizardBook!", parseMode = ParseMode.HTML)
                bot.sendMessage(ChatId.fromId(update.message!!.chat.id),"Ti aiuterò a trovare gli incantesimi!")
                val replyMarkup = InlineKeyboardMarkup.create(
                    listOf(
                        InlineKeyboardButton.CallbackData("Cerca per livello","bylevel"),
                        InlineKeyboardButton.CallbackData("Cerca per classe","byclass")),
                    listOf(
                        InlineKeyboardButton.CallbackData("Cerca per scuola","byschool"),
                        InlineKeyboardButton.CallbackData("Cerca per nome (o un pezzo)","byname")),
                    listOf(InlineKeyboardButton.CallbackData("Cerca per nome (preciso)","byreference")),
                    listOf(InlineKeyboardButton.CallbackData("La magia del giorno!","byday")),
                    listOf(InlineKeyboardButton.CallbackData("Contatti","bycontacts"))
                )
                bot.sendMessage(ChatId.fromId(message.chat.id),"Scegli il metodo di ricerca", replyMarkup = replyMarkup)
            }

            callbackQuery ("bylevel") {
                val chatId = update.callbackQuery?.message!!.chat.id
                bot.sendMessage(ChatId.fromId(chatId),"Che livello stai cercando? (Da 0 a 9)", parseMode = ParseMode.HTML)
                text {
                    var out :String = ""
                    holder.forEach {
                        if (it.level == text) out+= "\n${it.name}\nLvl. ${it.level} Classi ${it.combat}"
                    }
                    bot.sendMessage(ChatId.fromId(chatId),out, parseMode = ParseMode.HTML)
                }
            }
        }
    }
    bot.startPolling()

Maybe it's me not understanding how to properly handle updates?
Thanks a lot!

I think this behaviour is intended. Every time you call text { }, you are adding a handler for text messages. If you call text { } every time you get a specific answer from the callback, you'll have as many handlers as answers (previous handlers are kept unless you remove them) and thus the duplicates and so on.
I think that if you put the text {} call outside of the callback query lambda you'll get the behaviour that you expect. If what you want is to add this text handler ad-hoc once the users has selected an option in the first keyboard, there are a few of options to do it with the current APIs. For example, using another inline keyboard to let the user choose between 0-9 as you have done for the fist interaction, having a text handler outside of the callbackQuery that is only active once you have received the response, etc...
I had never considered this use case, but it could be interesting to offer an API in the library that allows you get the behaviour you'd like here, i.e. a text handler that processes a single text message and then is destroyed, I'll probably give that a thought.
Thanks for reporting your issue and asking @NicolaM94, and let me know if you need more help with that.

Having a library like that would be awesome, one could build much complex commands and queries. Up until that Christmas present though, I'll try to work something around implementing one of the solutions you guys suggested and poke it around to see the behavior, maybe manually closing the text handler each time. Thanks a lot!

@NicolaM94 good day to you, gentleman, would you kindly answer to my issue that is mentioned this one in? My project depends on this behaviour and sadly, if I can't get removeHandler() to work, I am considering choosing another library. Thank you.

I think I've mistakenly menthioned the wrong user. Here we go @seik @vjgarciag96


ruby mysql examples [T633]

PR fixes mysql protocol parsing, and updates ruby example to work with both MySQL and PostgreSQL.

Basically this PR fixes mysql protocol parsing, and updates ruby example to work with both MySQL and PostgreSQL.
From my opinion we should start log messages from capital :)

From my opinion we should start log messages from capital, but it's not critical
agree. better when all message has one format. I will fix it

What is the proper way of running this example?
Acra should be on and running on localhost machine? As well as database?

actually, I remembered that we explain python examples in our wiki - https://github.com/cossacklabs/acra/wiki/Using-Acra-to-Protect-Your-Django-App#if-you-want-to-try-acra-in-containers-first
And all examples are the same. They differ only by running program (python/ruby/golang). Other are the same actually.


[WIP] Memory profiler

[ ] abstract memory profile listener
[ ] use hook of function and variable

fix #918

See #2925


Don't send too many error reports

If you have a PHP-level warn/info error it doesn't stop execution, so you can see hundreds of them per request. We should (client-side) unique the errors, sort the list by severity and take the top 10, or something like that.

Duplicate of #62


Useless getter in Application class

[x] I have checked issues with bug label and found no duplicates

Unexpected Behavior
Here there's a getter that simply calls return this;. I can't imagine any use cases for this.
Environment

Typedoc version: GitHub Master

TypeDoc has a "component" architecture, most of the old classes in the project extend the AbstractComponent class.
This class provides a getter - application which is used for any classes in the component hierarchy to access the root level component. Once we get to the Application class though, we don't want to bubble up through the component owners anymore, and just want to return the current object.
Technically, the getter is no longer necessary. Before #845, the AbstractComponent class would return null if the component had no owner and therefore the Application class needed to override the method. Now, there is a check to satisfy strict null checks (with a type assertion that needs to go away eventually).
I want to remove the @Component decorator and the hard to follow component class structure along with it, but this needs to be done in parts to keep the changes small enough that they probably won't break things. (It has already been done to the options + options readers, next up is probably the converters)


repr for our dataclasses

Currently when we do someting like
idata = IData.from....
print(idata)

then we get a lot of mainly useless information. It would be nice if this print statement would lead to some helpful information, e.g.
IData with shape [1 1 20 30 40]
This would require to implement __repr__ method for our dataclasses. See e.g. https://www.pythontutorial.net/python-oop/python-repr/

Suggestion:
IData -> IData with shape [...], FOV [...], TE, TR, TI and flip angle
QData -> QData with shape [...] and FOV [...]
KNoise/DcfData -> KNoise/DcfData with shape [...]
KData -> KData with shape [...], trajectory shape [...], FOV, TE, TR, TI and flip angle, encoding_matrix, recon_matrix

I would suggest to put fov, te etc. in kheader repr.
And in kdata return
Kdata instance: (shape, dtype) and header.repr


CI: update docker/build-push-action

Problem
docker/build-push-action@v6 produces build summary[0], let's see if it's useful for us.

[0] https://docs.docker.com/build/ci/github-actions/build-summary/

Summary of changes

Update docker/build-push-action from v5 to v6

Checklist before requesting a review

[x] I have performed a self-review of my code.
[ ] If it is a core feature, I have added thorough tests.
[ ] Do we need to implement analytics? if so did you add the relevant metrics to the dashboard?
[ ] If this PR requires public announcement, mark it with /release-notes label and add several sentences in this section.

Checklist before merging

[ ] Do not forget to reformat commit message to not include the above checklist

Superseded by #7694


Incorrect calculation of average message for week

It seems like statistic is incorrect. It was a seven day since channel was created although.

Perhaps, earlier there was a label "New" or something.

@rishig any idea what's going on here?

@FoggyFinder just to check, is this on zulipchat.com?  If not, what server version?

just to check, is this on zulipchat.com?

@timabbott yep, on zulipchat.com.

hm, 5eccabc3c575d6fc8768765d8253a6d1aa1131d0 is the relevant commit.

Well, the effective case for this in get_average_weekly_stream_traffic is this:
stream_age = (timezone_now() - stream_date_created).days >= STREAM_TRAFFIC_CALCULATION_MIN_AGE_DAYS
Compare with is_old_stream:
return (datetime.date.today() - stream_date_created.date()).days \
        >= STREAM_TRAFFIC_CALCULATION_MIN_AGE_DAYS

So I'm guessing the bug is that datetime.date.today()  in is_old_stream should be timezone_now(), or there's a narrow gap between the two around 7 days in...

(Ideally, we'd also have the check in get_average_weekly_stream_traffic just call is_old_stream, to avoid that kind of mismatch in the future)


should dotProp.has({foo: undefined}, 'foo') be true ?

var a = {foo: undefined}

console.log(dotProp.has(a, 'foo'))  // false

console.log('foo' in a) // true
console.log(a.hasOwnProperty('foo'))  // true

cc @thatjessicakelly

Yes, that's a bug.

@qiu8310 Can you try #29?

I wrote a different version libs/lang/DotProp.js, and test file libs/lang/test/__DotProp.js.
Would you like to merge it?

@qiu8310 if you can prove that implementation is better (we have good perf tests here) 😄


Ability to track and revoke sessions

As an admin, I'd like an endpoint to be able to revoke all sessions for a particular user
As an user, I'd like an endpoint to be able to revoke all of my sessions
As an admin or user, I'd like to specify one or more or all types of sessions when I make the revoke call

The UI maintains its session via a Rack session. The way this works is that when a user makes a request, Rack will assign that request a session id, and the response will include that session id as a cookie. Then subsequent requests are made with that cookie, and the session is continued for that user. Since sessions are distributed by Rack, these are not done in a user context, and therefore sessions are not directly associated with a user.
The backing store for a session is based on the Settings.server.session_store value and interpreted in an initializer here. In all cases, we use the underlying Rails session stores.

:active_record_store ultimately ends up using the Session model
:memory_store is in-memory
:mem_cache_store ultimately uses Rack::Session::Dalli from the dalli gem.

The API maintains tokens in a bespoke manner. The TokenManager is used for token generation, and generated values are stored in the TokenStore. The TokenStore looks at Settings.server.session_store, but doesn't use the same Rack session code, instead doing it itself.

Proposal:

For the API, remove a majority of the custom TokenManager / TokenStore implementation and use the Rails conventions to treat a session like a token, leveraging Rack sessions. We may have to find a way to tell the Rack session classes to store the value in a different header than the cookie, so we can keep compatibility with current API header name for clients. However, the content of the token is not important to the end user, nor is it important between versions, so we can store whatever we like such as a session id.

Find a way to store the user id as part of the session for indexed lookup. The idea here is to be able to look up all current sessions by the user's id, In :active_record_store, this would mean adding a sessions.user_id column. In :memory_store this would mean adding a second memory-based index of the user's id => session list or reusing the existing lookup, but with a prefix. In :mem_cache_store this would mean storing a second entry mapping the user id to a list of sessions (which may mean we need an atomic update - CAS).

Introduce a revoke backend command and /api/revoke endpoint. A user should be able to revoke their own sessions. A super-admin can revoke anybody's sessions. It should be parameterized by type ("api", "ui", "ws", etc) and default to "all"

In a multi-appliance setup (with memcache), we will need to broadcast a revoke to all appliances, since each will have their own memcache.

Idea for item 4
Is it possible to have a single memcachd instance for multiple instances like we do for the database? This is the original intent of memcached
@himdel Do we store have too much data in the session for a single (remote) database to work?

The old forms do still use the session for all the form data. It should not longer store any instances, but a list of all eligible somethings to populate a selectpicker would still be stored in the session.
So, yeah, I think it should work (but it may not be much faster than sql for data-heavy forms, until those get converted).

For the API, remove a majority of the custom TokenManager / TokenStore implementation and use the Rails conventions to treat a session like a token, leveraging Rack sessions.

So, SUI would use cookies?
Does this mean relying on ui-classic to log in, or making SUI into a rails engine to have a server part to get the cookie and csrf from? Or will the API implement a login screen?

While the rack session defaults to cookies, I think we may be able to change it to use any header (a cookie is just a header after all).  If it's a response header then it's really no different than any other token returned in the header.

I think we may be able to change it to use any header (a cookie is just a header after all).

Ah, good point, cool :)

Or, yeah, maybe SUI should just use cookies...might be a lot easier and consistent?

Maybe, I'm not opposed to it, but a login cookie should be http(s)-only, which means we need to be able to do a login action that results in the server returning the cookie and either html, or a redirect to a html endpoint (not json).
So we would need to reuse the ui-classic login screen, or add one to the API.

Done


JoyCon ID is different

Hey,
First thanks for your extension, it's super useful for me !
I wanted to let you know that the ID of the JoyCon is not the same on my computer.
From your code I see you have Joy-Con (R) (Vendor: 057e Product: 2007) but on my side it's Wireless Gamepad (Vendor: 057e Product: 2007).
Do you have an idea where this difference may come ?
I'll try to do a pull request to support top / bottom keys when I find some time :)
Cheers,
Louis

Sorry for not noticing this earlier! I'm going to do some work on this, so will clean up the device detection. Looks like I should just use the Vendor: 057e Product: 2007 substring.


Color issue!

I set the color from xml to blue but it's gives me a black wheel, also from code using wheel.setBarColor(Color.BLUE); but still black!
Is there anyway to fix that?!

I have a same problem

In my case, I set only in javacode and works now. Don't set the Bar Color in xml file.

@viniciusfmaciel Actually i tried what you did but not works too, share your code plz.

I found the solution, just define the color code from code like this
mWheel.setBarColor(0xFF448AFF);
if you define the color from code but get color from xml like this it will not work
mWheel.setBarColor(R.color.myColor);

Yeah, it doesn't expect a color Id. Closing the issue.


Support ligature

Fork the topic from mainstream.
Any issue related to my fork should go here.
Notice that this fork might take a long time to develop and possibly not (able to) merge back to the mainstream.

@kchibisov How are the odds this work could inspire upstream?
If this could be achieved it would play nicely in a platform independent way: https://github.com/zenixls2/alacritty/commit/b92f094399f08c9bb5ae362d13d317ce3103f849#r39874718

If it won't regress any performance we're all ears, which will likely require a lot of effort from us as well, however upstream is focused on a bit different things right now. So the patch must be complete and don't regress any rendering and throughput performance.

If possible, I want to know more details on how the core developers estimate the performance.

Close the pr due to changes in the branch (now freetype links to servo's repo)

https://github.com/alacritty/alacritty/blob/master/CONTRIBUTING.md#performance and also render_timer values.

Ok, I've got some data in performance.md.
Seems no big influence on performance.

Please, look at render_timer while running vtebench the performance of this branch is ~15x slower than master branch. (2ms to render frame compared to 30ms on it). Even your performance.md is showing that due from increased throughput performance, meaning that VTE parser has more time to run and meaning, due to less amount of locks due to very slow rendering.
Unless you'll have performance in a margin of error on render_timer or let's say 50% difference, I won't even try to look into it.

I see you already put some effort in some tweaks in your latest commit https://github.com/zenixls2/alacritty/commit/9427d568d8113f783ebb2359bc5da584b36456a6 Just wanted to highlight that. Maybe with the guidance he gave, this can be pushed further to convince @kchibisov into looking at it?

It seems like the performance hit from ligature is unavoidable. How do you think if performance is unchanged when ligature option is turned off?
In branch ligature I've introduced a text_run hashset to cache the rendered output. This works for most cases, but not for the tests of random writes.
In ligature_test branch I'm trying to replace all RenderableCells with TextRun. There is slight performance improvement but may introduce some issue on Colors in config.

is there a config change I need to make to get ligatures to work? I compiled your branch.

@blaggacao do you have a windows machine or mac os machine to build? I want to know if my changes break the other systems. The final goal is to support harfbuzz for shaping in different systems, but hard to do so by myself since i currently only have one linux machine...

I'm afraid, I'm not even having one within reach, let alone using one. @kchibisov would you be able to suggest somebody or a some way?

harfbuzz only works on linux/bsd. On other platforms core text and direct write should be used.

Could country flag emoji issue also be solved? Are those also ligatures?
https://github.com/alacritty/alacritty/issues/4025

@dashezup not sure, maybe you could give it a try on the latest commit in ligature branch. My libraries in centos are too old to support emojis, also I don't have a mac to test if my modifications really works.

Your fork has been working pretty well by my side but I noticed recently that ligatures do not work anymore. Which information could be relevant to share in order for this to be solved beside the fact I am using the package from aur/alacritty-ligatures-git <IP_ADDRESS>5.ga15eb3b-1 ?

Hey, I ran into the same problem after the last commit.
System
OS: Linux 5.9.16-1 (Manjaro 20.2 Nibia);
Version: alacritty 0.7.0-dev (a15eb3b)
Linux: X11, i3
Package: aur/alacritty-ligatures-git
Font/Terminal Size: Iosevka SS09 / maximized borderless
Here are examples:

before the commit

and after

Thanks in advance, appreciate your work.

I tried to confirm from remote but gl rendering is not supported in vnc.
might be something wrong in my fork of crossfont.
currently I have no way for fixing it and the situation will be lasting until Jan 4th that I could sit in front of my linux pc/'.

@SiamionRalionak @danielementary can u check again?

@SiamionRalionak @danielementary can u check again?

Hey, I've tested the new build. unfortunately the issue isn't fixed yet.
Would it be possible to use merging master instead of rebasing one squashed commit onto master.
And probably use separate commits for new changes? It would be easier to monitor the changes and more feasible to help.
Moreover an issue I have currently, as I'm using fixed commits (for packaging reproducibility), is the garbage collection of github. All older rebased commits disappear after a week or so (that's the frequency github runs garbage collection to remove dangling commits) could be more or less, but after some time it's not possible anymore to download older (in this case working) commits.
Later when a PR to the upstream is opened, it should be no issue to rebase and squash everything into one commit onto master, as the merge commits are resolved while squashing, so no manual changes should be necessary if the current master is merged into this branch.
Thanks for the great work, keeping it up to date with master btw.

Hey, I've tested the new build. unfortunately the issue isn't fixed yet.
Would it be possible to use merging master instead of rebasing one squashed commit onto master.
And probably use separate commits for new changes? It would be easier to monitor the changes and more feasible to help.
Moreover an issue I have currently, as I'm using fixed commits (for packaging reproducibility), is the garbage collection of github. All older rebased commits disappear after a week or so (that's the frequency github runs garbage collection to remove dangling commits) could be more or less, but after some time it's not possible anymore to download older (in this case working) commits.
Later when a PR to the upstream is opened, it should be no issue to rebase and squash everything into one commit onto master, as the merge commits are resolved while squashing, so no manual changes should be necessary if the current master is merged into this branch.
Thanks for the great work, keeping it up to date with master btw.

@Philipp-M did you tested the latest ligature branch, or just the aur package? Aur package is still not updated, and I'm not the maintainer of it either, so it might take time to react. I'm currently using the same version in my branch and it works fine with Iosevka Term Extended.
I've also tested the latest crossfont ligature branch that Fira Code works fine.
I tried to merge the upstream before, but in the end gave up because there were too many redundant conflicts to resolve. Using single rebase commit on top helps me rect faster to the changes in upstream. To address the garbage collection issue you mentioned, probably i should create a branch for backup?

@Philipp-M did you tested the latest ligature branch, or just the aur package? Aur package is still not updated, and I'm not the maintainer of it either, so it might take time to react. I'm currently using the same version in my branch and it works fine with Iosevka Term Extended.
I've also tested the latest crossfont ligature branch that Fira Code works fine.
I tried to merge the upstream before, but in the end gave up because there were too many redundant conflicts to resolve. Using single rebase commit on top helps me rect faster to the changes in upstream. To address the garbage collection issue you mentioned, probably i should create a branch for backup?

Hey @zenixls2, thanks for your reaction. I just cloned the repo and built the ligature branch but the issue do no seem to be solved. Is there anything I can help you with ?

Hey @zenixls2, thanks for your reaction. I just cloned the repo and built the ligature branch but the issue do no seem to be solved. Is there anything I can help you with ?

What about explicitly set ligatures = true in config file?
This is the only reason I could think of

What about explicitly set ligatures = true in config file?
This is the only reason I could think of

Okay, so this was apparently a config issue, it is working now. Thanks for your precious help and contribution, this is priceless.

Okay, so this was apparently a config issue, it is working now. Thanks for your precious help and contribution, this is priceless.

Can confirm, setting font.ligatures = true fixes the issue.
Some comments though after skimming the patch:
https://github.com/zenixls2/alacritty/blob/974e49f157a78ededb08ccefe0ba6be2421a4387/alacritty.yml#L182 shows ligature instead of ligatures, this should probably be ligatures.
And I don't see anywhere, where font.ligatures gets its default value (true) AFAIK, the default value of a boolean is false isn't it?
So this might explain the issue we had?

Can confirm, setting font.ligatures = true fixes the issue.
Some comments though after skimming the patch:
https://github.com/zenixls2/alacritty/blob/974e49f157a78ededb08ccefe0ba6be2421a4387/alacritty.yml#L182 shows ligature instead of ligatures, this should probably be ligatures.
And I don't see anywhere, where font.ligatures gets its default value (true) AFAIK, the default value of a boolean is false isn't it?
So this might explain the issue we had?

Yes, correct. Recently there was a commit in upstream that changes the serialize/deserialize method of configuration. In order to resolve the conflict and fix the compilation, I remove the use of struct DefaultTrueBool(or DefaultBoolTrue, whatever) and modify it to bool. Probably at that time I forgot to define the Default trait implementation of font config.
Anyway will fix this soon.
Also there was a big change in the upstream recently and introduce lots of conflicts. That's why there's no update in my branch since then. Anyone who is waiting please be patient.

Yes, correct. Recently there was a commit in upstream that changes the serialize/deserialize method of configuration. In order to resolve the conflict and fix the compilation, I remove the use of struct DefaultTrueBool(or DefaultBoolTrue, whatever) and modify it to bool. Probably at that time I forgot to define the Default trait implementation of font config.
Anyway will fix this soon.
Also there was a big change in the upstream recently and introduce lots of conflicts. That's why there's no update in my branch since then. Anyone who is waiting please be patient.

I just wanted to give my appreciation for your efforts and offer my Mac system if you need to do any testing on said platform.
I would love to contribute to this project!

I just wanted to give my appreciation for your efforts and offer my Mac system if you need to do any testing on said platform.
I would love to contribute to this project!

I just tried this fork on Arch Linux and it works perfectly for Arabic script. Thanks for the effort put into the fork. I just want to mention, for what it's worth it, HarfBuzz compiles to WASM, and there are WASM runtimes other than Browsers, just in case.

will this ever be pushed to upstream Alacritty?
Was this ever mentioned in https://github.com/alacritty/alacritty/issues/50 ?

will this ever be pushed to upstream Alacritty?
Was this ever mentioned in alacritty#50 ?

Only if all platforms are tested and supported.
Also, current implementation still have a lot of bugs.
It's not of performance but about stability now that blocks me from sending pr.

I compiled the binary from source with cargo as the instructions describe, but when trying any of the formats of ligatures: true that are discussed in this thread do not seem to enable ligatures and simply give me config errors. I am using the JetBrains Mono Nerd patched font for reference.
Any help would be greatly appreciated, cloned the repo today to the build for reference as well.

I compiled the binary from source with cargo as the instructions describe, but when trying any of the formats of ligatures: true that are discussed in this thread do not seem to enable ligatures and simply give me config errors. I am using the JetBrains Mono Nerd patched font for reference.
Any help would be greatly appreciated, cloned the repo today to the build for reference as well.

Did you checkout the ligature branch?

I did not, and now I am not sure why I didn't think of that before this. It seems like it is not in this issue thread, so I will post it in the correct one, but I can also confirm the fact that any of the arrow styling to the right ->, ==>, =>, etc do not render correctly, but the left facing version work fine.

update the fork please

Please update the fork, this is like five versions behind

also it doesn't seem to work, I'm using Fira Code and with ligatures: true


Add support for puppet forge

A number of puppet modules are hosted here on github. It would be nice for some features which are accessible from the puppet forge api https://forgeapi.puppetlabs.com/ to be visible as badges.
Off the top of my head, I think version would be the most useful badge.
Here are some links:

Puppetlabs stdlib on github
Puppetlabs stdlib on puppet forge
API which shows details about package

The version can be found in the "releases" property, which is an array of objects. In the object the "version" property holds the version.

Thanks a lot for this information!

If you want the current version then using the current_release from the modules endpoint seem more useful than using the releases endpoint.


Update README.md to include direction parameter in spinToItem method

The docs are missing this parameter.
Really nice documentation, btw. It was really easy to learn and use this library ❤

Thanks for the PR @joka828!


Add age support in line with birthday

Shifting to milestone 1.4 due to complexity with Person immutability.


Not Backing up after 0.1.8 update

I am in Obsidian v1.7.4.  Local backups now appear to be empty...

Backup . obsidian/plugins/local-backup/data.json, and reinstall the plugin.

Thank you, that fixed it!
On Thu, Oct 10, 2024 at 7:35 PM GC Chen @.***> wrote:

Backup .obsidian/plugins/local-backup/data.json, and reinstall the plugin.
—
Reply to this email directly, view it on GitHub
https://github.com/cgcel/obsidian-local-backup/issues/46#issuecomment-2406225593,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ACCPSBDXD2U3CC5NVFWDFGDZ24FKXAVCNFSM6AAAAABPXRUM2KVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIMBWGIZDKNJZGM
.
You are receiving this because you authored the thread.Message ID:
@.***>


Centralizing our analytics for everything onto Supabase

I wonder if it makes sense to start thinking about centralizing our analytics for everything onto Supabase. For example, we have a global errors table. That way, we have a common place to dump every error across every instance of our bot.
Originally posted by @pavlovcik in https://github.com/ubiquity/bounty-bot/issues/123#issuecomment-1430875305

Could you define this issue in more detail once you're free?

@0xcodercrane might have input here on other solutions but the idea was simply to create an analytics table on Supabase and then log all bot errors there for later review.


Adding contract file for the newly supported beaglebone-play device

Needs review (this file was generated by hand).

Change-type: patch
Signed-off-by: Sidd-Gupta<EMAIL_ADDRESS>

The commit needs a Change-type. See https://github.com/balena-io/contracts/pull/296 for example

The commit needs a Change-type. See #296 for example

@floion - I already added the comment message (similar to the one in #296). Is there anything else that needs to be added ?


Added missing space in "SET LOCK_TIMEOUT"

(I've never done this before, hope I followed the directions correctly.)

@carenrose : Thanks for your contribution! The author(s) have been notified to review your proposed change.

#label:"aq-pr-triaged"

Thanks @carenrose! We really appreciate the contribution to our docs! I'll approve this.
#sign-off


Error while iterating Users data using PageIterator

GO Version: 1.20
SDK version
require (
	github.com/Azure/azure-sdk-for-go/sdk/azidentity v1.2.1
	github.com/joho/godotenv v1.5.1
	github.com/microsoftgraph/msgraph-sdk-go v0.56.0
	github.com/microsoftgraph/msgraph-sdk-go-core v0.34.0
)

Error:
panic: reflect: call of reflect.Value.IsNil on zero Value

goroutine 1 [running]:
reflect.Value.IsNil(...)
	/usr/local/opt/go/libexec/src/reflect/value.go:1556
github.com/microsoftgraph/msgraph-sdk-go-core.convertToPage({0x1d10f20, 0xc0004de720})
	/Users/caturandip/golang-apps/pkg/mod/github.com/microsoftgraph/msgraph-sdk-go-core@v0.34.0/page_iterator.go:205 +0x4e5
github.com/microsoftgraph/msgraph-sdk-go-core.NewPageIterator({0x1d10f20?, 0xc0004de720?}, {0x1ef7b90, 0xc000142be0}, 0x1e20ff0)
	/Users/caturandip/golang-apps/pkg/mod/github.com/microsoftgraph/msgraph-sdk-go-core@v0.34.0/page_iterator.go:55 +0x49
main.main()
	/Users/caturandip/golang-apps/gographapi/main.go:51 +0x389
exit status 2

Line code trigger error:
// Use PageIterator to iterate through all users
	pageIterator, err := msgraphgocore.NewPageIterator(result, client.GetAdapter(), models.CreateUserCollectionResponseFromDiscriminatorValue)

	if err != nil {
		log.Fatalln("Error in Iterator ", err.Error())
	}

	err = pageIterator.Iterate(context.Background(), func(pageItem interface{}) bool {
		user := pageItem.(models.Userable)
		fmt.Printf("%s\n", *user.GetDisplayName())
		return true
	})

the error happens after successfully authentication
Please help

Hi @caturandi-labs, this can be achieved by logging all the request that are sent via http.Client, you can use a number of different methods available such as tracing using https://go.dev/blog/http-tracing or a number of libraries out there that are present to log the http request.

You will need to provide an implementation of the http.Client that has logging
Provide this to the request adapter i.e

For example using the http.Client to implement this tracing
         t := &transport{}

        req, _ := http.NewRequest("GET", "https://google.com", nil)
        trace := &httptrace.ClientTrace{
            GotConn: t.GotConn,
        }

	httpClient := &http.Client{
		Transport: t,
	}
	adapter, err := msgraphsdk.NewGraphRequestAdapterWithParseNodeFactoryAndSerializationWriterFactoryAndHttpClient(auth, nil, nil, httpClient)

// get the client
client := msgraphsdk.NewGraphServiceClient(adapter)

A simple alternative, you can use a log library to simply provide a traced transport object

is it released already? or waiting for v0.34.1 ? try using 0.34.1 but got error  @rkodev

Hi @caturandi-labs it should be released, please upgrade the dependency

@rkodev , the result when i run  go list -u -m all
not found<EMAIL_ADDRESS>invalid version: unknown revision v0.34.1

any clue ?

SOLVED ! THANKS ALL


Fix nil derefs when args or ret is not specified

This fixes an issue that crops up if either args or return values (both apparently valid) are not specified

Thanks a lot for your contribution!😁


Add Dummy Issuer

Motivation
All teams developing a relying party will need an issuer to test their implementation.
In this PR, I introduce a canister that will issue any credential requested.
Changes

New project "dummy_issuer" with canister implementing the Issuer API.
Add dummy_issuer to dfx.json

Tests

Add tests for the dummy issuer with Pocket IC.

Todos

[x] Add entry to changelog (if necessary).

The dummy issuer does not have a front-end currently. Is the plan to provide a separate canister that serves the front-end?

I'm not planning on adding a frontend to the dummy issuer. The idea is that it will return any credential for any user. No need to log in the issuer to get the credential.

@frederikrothenberger ready for another review


[Feature Request]: MITRE Attack Framework

Feature Description
It would be appreciated if you could integrate the MITRE ATTACK Framework loader into the LlamaHub.
Reason
There is no available loader for this main source of cybersecrity incidents
Value of Feature
Cybersecurity is of paramount importance for any industry.
Integrating the loader for LlamaHub can convince industries to rely on this framework and leverage the potential of RAG for enhancing cybersecurity.

I'd advise pulling from the API directly: https://github.com/center-for-threat-informed-defense/attack-workbench-rest-api

Thanks for your response.
Is there any example of doing that? It would be appreciated if you could share it with me.


SetAlpha(1) does absolutely nothing

I have no idea why this is a thing

Fixed in 2.3.1 (0bb856a)


Missing GetCurrentUserPlaylists fetch function

get-a-list-of-current-users-playlists
The only function to get playlists of a user that exists in the library is GetUserPlaylists which returns public playlists of the user.
Any suggestion how to implement this manually at least until there is a PR for it?
Thanks.

After looking at the code again, the code seems to be fine, however I only get the current user's public playlists.
Can anyone solve this?

The problem was in the scope definition. I solved it.


[NoQA] Add policyID to getOrderedReportIDs and sortReportsByLastRead

Details
In this PR have been modified two functions. To both of them has been added an additional param: policyID. The modified functions:

getOrderedReportIDs -> To this function has been added possibility to filter reports by the given policyID
sortReportsByLastRead -> This function is used in findLastAccessedReport. Thanks to the additional param it's possible to find a last accessed report within the specific workspace. It will be useful in the future when we try to open the app from the deeplink only with the workspace id without the information about a specific report that we should open.

When the workspace switcher is ready, the appropriate policyID should be passed to the functions listed above.
cc: @hayata-suenaga
Fixed Issues

$ https://github.com/Expensify/App/issues/31877
PROPOSAL: described in the design doc:  https://docs.google.com/document/d/1VnEf2ThbbiQj0kx9KnAihF0DWf50s2Bn_MztEyEwtjg/edit?pli=1#bookmark=id.v253hbgx14pm
Tests
To test whether filtering works properly, pass an example policyID to the functions mentioned above, and check if the returned data is associated with the workspace whose ID was passed to the function.

[x] Verify that no errors appear in the JS console

Offline tests
To test whether filtering works properly, pass an example policyID to the functions mentioned above, and check if the returned data is associated with the workspace whose ID was passed to the function.

QA Steps
To test whether filtering works properly, pass an example policyID to the functions mentioned above, and check if the returned data is associated with the workspace whose ID was passed to the function.

[x] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos
This PR only modifies utility functions.

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

Thank you for opening the PR @WojtekBoman while I'm still working the backend API 🙇 I like how you're working on things you can work on right now 🙇

All comments have been resolved :)

@WojtekBoman sorry for the wait 🙇 I'm back from OOO
another internal engineer took over the task of creating the backend API. I'll give you update as that progresses 🙇

The backend API has been deployed to the staging environment. I will notify you when it is deployed to production. The new API is named OpenWorkspace.

wait, I think the NewDot talks to the staging server right? if that is the case, you can already test your PR if you need the new API to do so. @WojtekBoman

Let us know in slack when this is ready, we can merge to the feature branch

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

🚀 Deployed to staging by https://github.com/mountiny in version: 1.4.28-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to production by https://github.com/mountiny in version: 1.4.28-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
failure ❌

🕸 web 🕸
success ✅


How to use tweakpane

I want to write an article about this on LogRocket blog, How do I use it. I followed the get started page.

Added a Script tag to my html file.
Created a new new TweakPane()
Added some configurations as specified in the Page

After all this, I preview the HTML file and nothing displayed. Please how do i use this TweakPane library?

First, please fix a typo: new TweakPane() -> new Tweakpane()
If the problem still occurred,

What is a browser do you use?
You can use a developer tool of a browser to find a cause. Is there any logs or error messages in a console?

Problem solved? What is the cause?

My fault, I had a typo


Game Room Chats

This section involves the implementation of room related chats. Game rooms must contain a:

Global Chat

and may contain several:

Group Chats (2 to n participants)

Chat messages should include at a minimum

player_id
timestamp
message (Set a maximum length!)

Furthermore these states will influence how the client displays chats:

Blocked - Gives the ability to block a player for

Only the current game
For all games

Obviously this would require the ability to unblock someone from either 1. or 2.
The player will send a request to fetch all recent messages after timestamp X from chat Y.
Keep in mind:

When a player sends a message, only ask for necessary details. This would, for example, include just the session_id and the message. Please do not add unnecessary dependencies like the player_id itself. Current Subterfuge has proven vulnerabilities which allows to send messages as other players, this can be easily avoided. If you need the player_id, player_name etc. fetch it with the session token.
Allow the retrieval of chats iff the player has access to it and is authenticated.

@billyb2 Commented:
So could chats just be written onto a text file on the server? It'd be pretty easy to implement and wouldn't have to clog the MySQL database.
So I'm thinking there are two ways this could happen:

Every game has a text file where all the chat messages are stored and in different "sections". As in, a section for public chat, a section for group chats, etc.

Pros:
Relatively easy to implement
There would be minimal .txt files on the server
Cons:
Will be (slightly) more difficult to program
If the user somehow exploited the algorithm for reading the chat they could read all chat messages

Every separate group chat, public chat, etc. are stored in different text files. Like if the room id was 256, the text file for a conversation between Bob and Alice would be bob-alice-256.txt

Pros:
Very easy to implement
User exploits would have to be able to view every text file
Cons:
A ton of text files to manage

@XATEV commented:
Clogging the databases wouldn't be an issue, you can create a separate database which stores all chats.
A player request would always look like: Give me all messages from either

a specific chat
all game chats

that I am part of from game room Y.
Then you would have one single table in the sandbox database which simply has the entries player_id, chat_id, room_id.
We can count chat_id from 0 for each room whereas 0 is the global chat. To get the participants of a chat room you can simply query for the room_id, if you want the chats a player is in (room specific) you query for player_id + room_id.
I am not sure how the file based approach would work and if it would be better performance wise in the end. Also like you said, making sure access is restricted and working correctly would be more difficult.
(MySQL has been in development for nearly 3 decades and it can easily query from a table with millions of entries in less than a second.)

@billyb2 commented:
1 to 1 direct messages are finished with 700002a1, however, you cannot retrieve messages (yet).

Nice work! One thing to think about as well is once we have pulling from the database, we will want users to be able to get live updates from chat messages when they are online in the game. We will need to setup a socket server for users to send and recieve communications from about live chat and game events. This could probably be a new issue once we get there though.

@billyb2 replied:

Nice work! One thing to think about as well is once we have pulling from the database, we will want users to be able to get live updates from chat messages when they are online in the game. We will need to setup a socket server for users to send and recieve communications from about live chat and game events. This could probably be a new issue once we get there though.

Added the ability to receive messages past a certain time frame with c907bc9e.

@billyb2 comment:
Added the ability to block/unblock other players with 98f2f160731e025cec6422be16ff2b6d40671398

Most of this is implemented in the Laravel codebase, however, we cannot yet close this issue as there is one thing missing, namely the Global Chat. Upon room creation a chat with all players should be created (and marked as being a special global chat in some way).


All matcher messages must be lazy; SummaryReporter prints per character.

Summary
Seems like calling prettyFormat on every spy matcher causes a memory leak. This stops the bleeding but should certainly be fixed so that we don't leak when pretty-printing, obviously. At least I have a repro now :)
Test plan
jest at FB
Fixes #1834

ah... we should require it to always be a function and not allow returning a string


Update insertAtHeadOfLinkedList.java

head of the linked list needs to be updated.
check this out https://github.com/dsalgos/linked-list/tree/master/src/main/java/org/ds/algos/datastructures/singlylinked/list
Pull Request Template
Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes # (issue)
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Please also note any relevant details for your test configuration.

[ ] Test A
[ ] Test B

Checklist:

[ ] My code follows the style guidelines of this project
[ ] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] My changes generate no new warnings
[ ] Any dependent changes have been merged and published in downstream modules

The head of the list is not being updated after adding the new node.

After adding the newNode it becomes a new head
Submitted and tested the code here 👇
https://www.hackerrank.com/challenges/insert-a-node-at-the-head-of-a-linked-list/problem

Actually even doing the following
llist = newNode
will not update the head, as its pass by value not reference.
I was considering something like head as member variable.


"Search For Text When I Start Typing" does not work

Configuration:

Web browser and its version: Firefox 95
Operating system and its version: all
Is a browser extension: no

Steps to reproduce the problem:

get the option "Search For Text When I Start Typing" On in Firefox
Open a pdf
Start typing

What is the expected behavior?
Search bar should come up and start searching in the pdf for the text the user is typing
What went wrong?
Search bar does not come up. User has to hit Ctrl+F everytime

It's a Firefox bug, so I filed one:
https://bugzilla.mozilla.org/show_bug.cgi?id=1749355


Extensions

Implementation Details :construction:

Checklist:

[x] I added test coverage (if applicable).
[x] I documented my changes.

          1 Warning

:warning:
Big PR, try to keep changes smaller if you can

  Generated by :no_entry_sign: Danger


docker-sys interface not configured properly with Docker args

RancherOS Version: (ros os version)
[rancher@server ~]$ ros -v
version v1.4.0 from os image rancher/os:v1.4.0

Where are you running RancherOS? (docker-machine, AWS, GCE, baremetal, etc.)
OpenStack
This is potentially a bug and I'm opening this issue for clarification of expected behavior with the new way to configure the system-docker bridge network. I've already reviewed https://github.com/rancher/os/issues/2329 and https://github.com/rancher/os/issues/2422.
After following the instructions in the above issues, I've opened a new one because I believe the network isn't being properly configured. At least it's not being configured how I would expect it.
My cloud-config:
#cloud-config
rancher:
  docker:
    extra_args:
      - "--bip=<IP_ADDRESS>/16"
  system_docker:
    extra_args:
      - "--bip=<IP_ADDRESS>/16"

The above cloud-config produces the user-docker network as I expect. Output below.
[rancher@server ~]$ ifconfig docker0
docker0   Link encap:Ethernet  HWaddr 02:42:85:BE:5D:2E
          inet addr:<IP_ADDRESS>  Bcast:<IP_ADDRESS>  Mask:<IP_ADDRESS>
          ...

But it doesn't configure the system-docker network as I expect. Output below:
[rancher@server ~]$ ifconfig docker-sys
docker-sys Link encap:Ethernet  HWaddr 02:42:6F:2D:38:1C
          inet addr:<IP_ADDRESS>  Bcast:<IP_ADDRESS>  Mask:<IP_ADDRESS>
          ...

I would expect that the broadcast address (Bcast) for the docker-sys interface would be set just like it is for the docker0 interface.

Is this expected behavior?
If not, are their workarounds?

The only one we've come up with is running ifconfig on the server to properly configure the broadcast address for the interface.

Our system-docker is based on docker 17.06. I guess this is a problem with docker itself.
I tried to switch user-docker to 17.06, then reboot the machine.
[root@ip-172-31-17-143 ~]# docker version
Server:
 Version:      17.06.2-ce
 API version:  1.30 (minimum version 1.12)
 Go version:   go1.8.3
 Git commit:   cec0b72
 Built:        Tue Sep  5 19:59:19 2017
 OS/Arch:      linux/amd64
 Experimental: false

I checked the docker0, it's the same with docker-sys. I cannot see the broadcast address:
[root@ip-172-31-17-143 ~]# ifconfig docker0
docker0   Link encap:Ethernet  HWaddr 02:42:6C:F2:61:BE
          inet addr:<IP_ADDRESS>  Bcast:<IP_ADDRESS>  Mask:<IP_ADDRESS>
          inet6 addr: fe80::42:6cff:fef2:61be/64 Scope:Link
          UP BROADCAST MULTICAST  MTU:1500  Metric:1
          RX packets:0 errors:0 dropped:0 overruns:0 frame:0
          TX packets:10 errors:0 dropped:0 overruns:0 carrier:0
          collisions:0 txqueuelen:0
          RX bytes:0 (0.0 B)  TX bytes:836 (836.0 B)

So this should be a problem with the early version of Docker, but it was fixed later.
I need backport some commits to our system-docker if we need to fix it.
BTW, what impact does this issue have on you?

There may be a workaround, just add these to the cloud-config:
runcmd:
- ip addr del <IP_ADDRESS>/16 dev docker-sys
- ip addr add <IP_ADDRESS>/16 brd + dev docker-sys

Then reboot, check again:
[root@ip-172-31-17-143 rancher]# ifconfig docker-sys
docker-sys Link encap:Ethernet  HWaddr 02:42:3E:34:E0:29
          inet addr:<IP_ADDRESS>  Bcast:<IP_ADDRESS>  Mask:<IP_ADDRESS>
          inet6 addr: fe80::42:3eff:fe34:e029/64 Scope:Link
          UP BROADCAST MULTICAST  MTU:1500  Metric:1
          RX packets:0 errors:0 dropped:0 overruns:0 frame:0
          TX packets:7 errors:0 dropped:0 overruns:0 carrier:0
          collisions:0 txqueuelen:0
          RX bytes:0 (0.0 B)  TX bytes:606 (606.0 B)

@niusmallnan thanks for getting back to us!
And thanks for providing those workarounds!
This currently hasn't caused use any issues.... but was noticed when troubleshooting the bip config changes.
If it is fixed in a future version of Docker then I think we can close this.
Do you happen to know what version of Docker this was fixed in?

Fixed in docker 17.12.0-ce.


Trailing slash is not being removed before request is forwarded to backend

Do you want to request a feature or report a bug?
Bug
What did you do?

I used this traefik.toml and started Traefik using traefik --configFile=traefik.toml.
curl https://git.io/fp2aJ -o traefik.toml; traefik --configFile=traefik.toml

I started the referenced backend using:
cd $(mktemp -d); echo "ping http1" > ping; python3 -m http.server 8003

I used curl to retrieve the ping file via Traefik, intentionally adding a trailing slash:
curl http://localhost:80/ping/

What did you expect to see?
As I understand keepTrailingSlash with it's default value of false requests with a trailing slash should be stripped of trailing slashes before being forward to the backend.
If this is working as intended then the bug might be in the documentation :)
What did you see instead?
The request arrived at the backend containing the trailing slash. Causing a 404 response.
~ curl -si http://localhost:80/ping/ | head -n1
HTTP/1.1 404 Not Found
~ curl -si http://localhost:80/ping | head -n1
HTTP/1.1 200 OK

Traefik Version
Version:      dev
Codename:     cheddar
Go version:   go1.11.2
Built:        I don't remember exactly
OS/Arch:      darwin/amd64

Reported as 1.7.4 in /dashboard. Installed via brew install traefik. Wanted to use a Docker image but couldn't get host networking set up.
Environment
see above
Debug Logs
http://sprunge.us/qPdLm4

Started looking into this, complete beginner with regards to Go but will try to at least create a failing test case here: https://github.com/martinklepsch/traefik/tree/fix-4247.
If you want to help me contribute/get this done, I'm also @martinklepsch in the Traefik Slack.

Hello,
This issue was for the v1, but as described in our deprecation notices the v1 is not supported anymore.
Accordingly, we are closing this issue.


Set up Kanban Board

We are a team of two people, and we've divided the work evenly from our point of view. Here's the link to our project:
https://github.com/sadaf-Daneshgar/recipe_app/projects/1
@sadaf-Daneshgar  is designated as Team Member # 2 ( As seen in https://github.com/sadaf-Daneshgar/recipe_app/issues/5), @Arch-Noize is designated as Team Member # 1 (as seen in https://github.com/sadaf-Daneshgar/recipe_app/issues/4), and both are divided to work on the Group Tasks (as seen in https://github.com/sadaf-Daneshgar/recipe_app/issues/10)

Hi @Arch-Noize @sadaf-Daneshgar
Your project is complete  👍 💯   There is nothing else to say other than... it's time to merge it :shipit:
Congratulations! 🎉
Highlights 👏🏻
✔ Correctly Set up RoR group project: set up your Kanban board.
✔ Correctly organization and description about the number of people in group.
Optional suggestions
_Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will really improve your application.


Add history dock

Closes https://github.com/godotengine/godot-proposals/issues/953

In a future PR, I wonder if it could be possible to associate icons to each history actions. This would make it a bit easier to navigate long histories by improving visual grepping :slightly_smiling_face:

Actually it could be in EditorUndoRedoManager and shouldn't be difficult to do, but we have to deteine what icons to use. Assign them automatically based on type? Setting icon manually for each action is lots of code.

Move/scale/rotate, for instance, could reuse the move/scale/rotate toolbar button icons, and yep, assigning automatically by type is probably the way to go.

Thanks!

The ability to hide this dock is missing from the editor feature profiles menu:

Thank you KoBeWi!!


[Feature] Add glitch support

Did this take me 30 minutes? Yes.

Interesting. I was wondering if they supported ports and I saw some examples on their forum of apps using ports.


Fixed small typos in merge-conflicts.md

removed the repeated word
fixed lower font size for one header

You may disregard these recommendations if you used the Edit on GitHub button from dvc.org to improve a doc in place.

❗ Please read the guidelines in the Contributing to the Documentation list if you make any substantial changes to the documentation or JS engine.
🐛 Please make sure to mention Fix #issue (if applicable) in the description of the PR. This causes GitHub to close it automatically when the PR is merged.
Please choose to allow us to edit your branch when creating the PR.
Thank you for the contribution - we'll try to review it as soon as possible. 🙏

Merged the restyled version of it here- #1869


Other fields?

Hi,
Thanks for this integration!
Any plans to expose/return the remaining fields?   I'd love to see the confidence, ID, etc.  I'm seeing some odd results in the log and could add a filter using the confidence.
Thanks!

This is on my list of things to do.


Cannot restore secrets with owner reference set

What steps did you take and what happened:
[A clear and concise description of what the bug is, and what commands you ran.)
I have a cluster with Service Catalog installed and with some ServiceInstance/ServiceBindings created. Service Catalog is creating secrets for each ServiceBinding and setting owner reference in that secret.
I created a backup of those resources (ServiceInstance/ServiceBindings/Secrets) and wanted to test the restore procedure.
Unfortunately secrets were not restored. In logs I see such info message:
time="2018-09-03T09:53:44Z" level=info msg="production/mwtest-binding has a controller owner - skipping" logSource="pkg/restore/restore.go:342"
What did you expect to happen:
Secrets are restored
Anything else you would like to add:
[Miscellaneous information that will assist in solving the issue.]
Ref: slack discussion
Environment:

Ark version (use ark version):  0.9.0
Kubernetes version (use kubectl version): 1.10.5
Kubernetes installer & version: acs-engine, 0.20.0
Cloud provider or hardware configuration: azure
OS (e.g. from /etc/os-release): ubuntu

@mwieczorek thanks for filing this!
@skriss @rosskukulinski IIRC, we had previously discussed removing the code that keeps us from restoring things that have controller owners. I think we said we wanted to proceed with the removal. WDYT?

@ncdc Yep I think we were 👍 on moving forward with that change.  I believe #445 is the associated issue?

@rosskukulinski yes-ish. The intent of #445 is what to do about controlled pods whose labels don't match their controller's labels. I'd say this issue is more appropriate for removing the code the doesn't restore controlled things.

I agree with @ncdc - I’d just like to get ’controlled’ secrets and other resources restored.
And I would be happy if it gets into v0.10.0 ;)

@mwieczorek would you be able to do a PR for this?

@ncdc this would be a change in default behavior (I'm +1 on that) -- do you think we should add a CLI flag to maintain current behavior?

@rosskukulinski in this case, I don't think it's worth it. We will be moving toward a more faithful restoration of the contents in the source cluster. My assumption is this is a 100% positive improvement and that nobody will notice any detrimental effects.

@ncdc Sure, I'll try to do it.
What about the 'breaking change'? Is mentioning it in docs and release notes enough?

Also: do you recommend some e2e tests? I just removed 'ownerReference' check, tested my use-case and everything was working. But maybe I'm not aware of some details.

@mwieczorek we don't have an e2e test framework yet, so no need for e2e tests at this time (but thanks for offering!). Another thing you could test is replicasets that were generated by the deployment controller - make sure they're restored correctly, with all their labels, annotations, etc.

Oh, and I think mentioning this change in the v0.10 release notes will be sufficient (we'll take care of that).

Sorry, just catching up here.  One thing we're going to have to think about here is the order in which resources get restored.  If, for example, a deployment got restored before its associated replicaset, a new replicaset may be created on the cluster before the backed-up one gets restored.  Up until now, we've avoided actually having some kind of dependency graph of resources during restore by just doing a partial ordering based on things that we knew had dependencies.  But this may fall down if we start restoring all child objects.

@skriss Good point. For "built-in" resource types, it should be easy to change defaultRestorePriorities list (f.e. add ReplicaSet).
For CRDs - it could be the user's duty to modify the list appropriately
@skriss, @ncdc wdyt?

But this may fall down if we start restoring all child objects.

At worst, ark captures it as a warning.
I think we should adjust the default restore priorities to include replicasets and anything else we can think of that requires ordering.
We could also consider taking note of dependency ordering when taking the backup, and recording that information in the backup json and/or tarball. For example, if we back up a replicaset and see that it has a deployment owner, we could encode this ordering (replicaset before deployment) and use that information when restoring.


Some links are getting lost in the dom -> aria tree conversion

Example:
State: {"kind":"ObjectiveState","url":"https://hdr.is/people","ariaTree":"[0,\"RootWebArea\",\"About - High Dimensional Research\",[[1,\"link\",\"HIGH DIMENSIONAL RESEARCH\"],\"⚲\",[2,\"link\",\"PRODUCT\"],[3,\"link\",\"BLOG\"],[4,\"link\",\"DOCUMENTATION\"],[5,\"link\",\"COMPANY\"],"progress":["Navigated to the `Company` page to find the email address of Tynan Daly.","Navigated to the `Company` page to find the email address of Tynan Daly"],"objective":"please find the email address link for tynan daly on the company page"}Response: {"progressAssessment":"Cannot find Tynan Daly's email address in the current ariaTree. The page might not contain the required information or it may need additional navigation to reach the desired information.","command":[{"kind":"Click","index":4}],"description":"Attempting to navigate to the `About` page to find Tynan Daly's email address. Clicked on `About`."}
Step response: [object Object]Performing action:[{"kind":"Click","index":4}]

The base tree should contain email links so i think they're getting filtered out during tree simplification.
Working on a fix.

Strangely enough, this seems to have been closed by #32


How does image-repository get authenticated?

The readme mentions image-repository and explains to enter a string name reference to the repo. 👍
I've some questions (Framed around the idea of using them to improve the readme):

How does the docker image pull/push get authenticated?
Where should that information be stored?
Is it secure?
Should it be used for private projects? Is it a recommended thing to do?
Is this a best practice? Do you want to encourage people to do this?

Thanks! I've just updated our docs in a087627 to try to answer all these questions.


Refs #13091 -- Added test for commit=False idiom with partial unique_together validation.

Reviewing PR #8470 for ticket #13091, I noted a missing test for the important commit=False idiom, with partial unique_together validation:
if form.is_valid():
    instance = form.save(commit=False)
    # Set some attributes...
    instance.save()

This PR adds a test for that case.
(Based on Carl Meyer's longstanding assessment of that ticket.)

Argh, I broke a related test. I will patch that up.

MariaDB failure is ModuleNotFoundError: No module named 'memcache'


Update docs for emacs support

The old integration example was still based on a global opam installation. Let's
use the reason-cli instead and add a section for Spacemacs.

The best editor is neither Emacs nor Vim, it's Emacs and Vim!

Note that Reason-cli is still work in progress. I'll hold this off for a week or two. Thanks!

Bah we'll come back and update that bit later. Thanks!


[26.x][WFLY-15868] Upgrade Elytron 1.18.1.Final

Fixes https://issues.redhat.com/browse/WFLY-15868 for WildFly 26.x
Please find git diff links in the Jira.

@boris-unckel Thanks for catching this. I've created the following PRs to move the Elytron OIDC Client related dependencies from WildFly to Core:
https://github.com/wildfly/wildfly-core/pull/4918
https://github.com/wildfly/wildfly/pull/15060

Since this PR is now superseded by https://github.com/wildfly/wildfly-core/pull/4918 and https://github.com/wildfly/wildfly/pull/15060, I'm going to close this one.
Thanks, @boris-unckel.


Support Multiple Availability Zones

Currently, all infrastructure in this project is deployed to a single AWS availability zone, as defined by the aws_region and aws_availability_zone variables.  To improve our fault-tolerance, we should come up with a reasonable way to spread assessment resources across multiple availability zones so that assessment operations can continue if a particular availability zone becomes unavailable.
Our solution should also consider the usage of multiple AWS regions as well.

With respect to AWS regions, this is easier than it used to be thanks to Transit Gateway peering.

With respect to AWS regions, this is easier than it used to be thanks to Transit Gateway peering.

Good point.
Important limitation to note (subject to change by the time we actually implement this):

You can create a transit gateway peering attachment between transit gateways in the following AWS Regions: US East (N. Virginia), US East (Ohio), US West (Oregon), Europe (Frankfurt), and Europe (Ireland).


Match doesn't pull info from input team_name and team_id

New Issue Checklist

[x] Updated fastlane to the latest version
[x] I read the Contribution Guidelines
[x] I read docs.fastlane.tools
[x] I searched for existing GitHub issues

Issue Description
We white label a lot of apps and most are under their own team_name and team_id
Problem areas in fastfile
def update_signing(options)

	register_devices(
		devices_file: "devices.txt",
		api_key: api_key(options)
	)

	match(
		type: options[:match_type] || ENV["MATCH_TYPE"] || "development",
		# username: options[:match_username] || ENV["MATCH_USERNAME"] || "...",
		# team_id: options[:team_id] || ENV["TEAM_ID"] || "...",
		# team_name: options[:team_name] || ENV["TEAM_NAME"] || "...",
		api_key: api_key(options),
		git_branch: "main",
	)

	# Sets profile names correctly in xcode.
	mapping = Actions.lane_context[SharedValues::MATCH_PROVISIONING_PROFILE_MAPPING]

	xcodeproj_path = File.expand_path("../OurApp.xcodeproj", Dir.pwd)
	update_code_signing_settings(
		path: xcodeproj_path,
		profile_name: mapping[options[:match_app_identifier] || ENV['MATCH_APP_IDENTIFIER']],
		bundle_identifier: options[:match_app_identifier] || ENV['MATCH_APP_IDENTIFIER'] || $bundle_identifier,
	)
end

def api_key(options)

	if !ENV["API_KEY_PATH"].to_s.strip.empty?
		key_filepath = ENV["API_KEY_PATH"]
	else
		if ENV["IS_FACTS_APP"] == "true"
			key_filepath = options[:api_key_path] || ENV["API_KEY_FACTS_PATH"]
		else
			key_filepath = options[:api_key_path] || ENV["API_KEY_A3_PATH"]
		end
	end

	app_store_connect_api_key(
		key_id: options[:api_key_id] || ENV["API_KEY_ID"] || "...",
		issuer_id: options[:api_issuer_id] || ENV["API_ISSUER_ID"] || "...",
		key_filepath: key_filepath,
		is_key_content_base64: false,
		duration: 1200,
		in_house: false,
	)
end

+--------------------------------+--------------------------------------+
|                       Summary for match 2.193.1                       |
+--------------------------------+--------------------------------------+
| type                           | appstore                             |
| username                       | Correct email                        |
| team_id                        | Correct id                           |
| team_name                      | Correct team name                    |
| api_key                        | ********                             |
| git_branch                     | main                                 |
| readonly                       | false                                |
| generate_apple_certs           | true                                 |
| skip_provisioning_profiles     | false                                |
| app_identifier                 | ["Correct bundle id"]                |
| storage_mode                   | git                                  |
| git_url                        | Correct repo url                     |
| shallow_clone                  | false                                |
| clone_branch_directly          | false                                |
| keychain_name                  | login.keychain                       |
| force                          | false                                |
| force_for_new_devices          | false                                |
| skip_confirmation              | false                                |
| skip_docs                      | false                                |
| platform                       | ios                                  |
| derive_catalyst_app_identifier | false                                |
| fail_on_name_taken             | false                                |
| skip_certificate_matching      | false                                |
| skip_set_partition_list        | false                                |
| verbose                        | false                                |
+--------------------------------+--------------------------------------+

What I get is:

- com.somebundleId1
- com.somebundleId2
- com.somebundleId3
- com.somebundleId4
- com.somebundleId5
- com.somebundleId6 // These are all correct bundle id's from our main account. But shouldln't exist in the one I'm trying to fetch from in this pipeline.
- com.somebundleId7
- com.somebundleId8
- com.somebundleId9
[11:39:44]: Make sure to run `fastlane match` with the same user and team every time.
+------------------+-------------------------+
|                Lane Context                |
+------------------+-------------------------+
| DEFAULT_PLATFORM | ios                     |
| PLATFORM_NAME    | ios                     |
| LANE_NAME        | ios publish_to_appstore |
+------------------+-------------------------+
[11:39:44]: Couldn't find bundle identifier 'com.correct.bundle.id' for the user<EMAIL_ADDRESS>+------+---------------------------------------------------------------+-------------+
|                                  fastlane summary                                  |
+------+---------------------------------------------------------------+-------------+
| Step | Action                                                        | Time (in s) |
+------+---------------------------------------------------------------+-------------+
| 1    | opt_out_usage                                                 | 0           |
| 2    | default_platform                                              | 0           |
| 3    | git rev-parse --abbrev-ref HEAD | tr -d '                     | 0           |
|      | '                                                             |             |
| 4    | printenv | sort                                               | 0           |
| 5    | Switch to ios pod_install lane                                | 0           |
| 6    | bundle exec pod install                                       | 9           |
| 7    | set_info_plist_value                                          | 0           |
| 8    | Switch to ios build_archive lane                              | 0           |
| 9    | Switch to ios pod_install lane                                | 0           |
| 10   | bundle exec pod install                                       | 7           |
| 11   | Switch to ios get_config lane                                 | 0           |
| 12   | curl --http1.1 -o 33644-config.zip 'https://ourcompany.net/api/sy | 5           |
| 13   | unzip -o 33644-config.zip 'amp-ios/*' -d '../'                | 0           |
| 14   | get_xcconfig_value                                            | 0           |
| 15   | get_xcconfig_value                                            | 0           |
| 16   | Switch to ios update_signing lane                             | 0           |
| 17   | app_store_connect_api_key                                     | 0           |
| 18   | register_devices                                              | 0           |
| 19   | app_store_connect_api_key                                     | 0           |
| 💥   | match                                                         | 6           |
+------+---------------------------------------------------------------+-------------+
[11:39:44]: fastlane finished with errors
[!] Couldn't find bundle identifier 'com.correct.bundle.id' for the user<EMAIL_ADDRESS>Cleaning up file based variables
00:01
ERROR: Job failed: exit status 1

What I expect is match to see and use the existing identifier under the passed in team_name and team_id.

If no team_id is provided, then the queue SID is used as the unique ID. The team_id attribute is required to display team_name

I'm not exactly sure what that means. I provide the team_id and team_name every time.

This is a blocker for us atm. If anyone has any input that would be great.

Small update on this. it appears that if you use an api key, then the team_id and team_name are no longer needed? So now with swapping out the api key for each client, however I still get this error which is displaying the wrong email:
[13:28:57]: Certificate '...' (stored in your storage) is not available on the Developer Portal
[13:28:57]: for the user ... # this is the wrong email which is our default for internal apps.
[13:28:57]: Make sure to use the same user and team every time you run 'match' for this
[13:28:57]: Git repository. This might be caused by revoking the certificate on the Dev Portal
[13:28:57]: If missing certificate is a Developer ID Installer, you may need to auth with Apple ID instead of App Store API Key


android.content.ActivityNotFoundException:

android.content.ActivityNotFoundException: Unable to find explicit activity class {com.myapp.videomodule/com.myapp.videomodule.VideoCallActivity}; have you declared this activity in your AndroidManifest.xml?
My app package is com.myapp.doctors
module package is com.myapp.videomodule
I am still confused how that same thing is working with this project but not with my own project.
My code
if(splitInstallManager.getInstalledModules().contains("videomodule")){ Intent intent = new Intent();          intent.setClassName("com.myapp.videomodule","com.myapp.videomodule.VideoCallActivity");             startActivity(intent);         }

This is out of scope for this sample's issue tracker. Please create a question on StackOverflow.
Feel free to post it as comment here and I'll take a look.

I am also having the same issue. I tried following AppBundle guide but didn't have any problem. I even tried adding a new dynamic module to this project. Then too getting the same exception

Is the code open source or can you create a MVCE?