Known Issues

By 猫猫丁
学者：高等级会导致收到伤害增加逐渐变成负数，然后实际上变成减伤，20级会变成免伤。再高伤害会变成回血。
侵蚀，高等级原罪侵蚀会变成自己伤害增加，这个伤害能打穿抗性提升5和原罪学者。
by Silent123261
如果同时拥有带药水效果的护甲、混乱原体、异常治疗，则异常治疗会不断触发，刷满3种buff，但是会不停受到攻击（仅有被攻击的效果，没有伤害，非常影响体验）
by QQ酱455256
混乱原体,只要一直刷新效果 就会一直回血 相当于无敌 给帽子附个别的mod里的夜视附魔 然后就能一直刷新有夜视效果 然后一直触发这个的回血,作者能不能加个触发间隔呀
by 伝説
混乱原体加上循环的夜视头盔可以无限刷生命不掉血，在加上异常治疗，会无限刷状态，就是偶然会扣一下血，混乱原体介绍写的是加生命上限但是变成了加生命，不知是bug还是特性
English version:
By 猫猫丁
Scholar of Original Sin & Original Sin Erosion do not support working over the highest level of enchantment level.
by Silent123261
If you also have armor with potion effect, Prototype Chaotic, Exotic Healer, the Exotic Healer will be constantly triggered, brush full of 3 kinds of buffs, but the player will be constantly attacked (only the effect of being attacked, no damage, very impactful experience)
by QQ酱455256
Prototype Chaotic, as long as the effect has been refreshed, it will always return to healing, which is equivalent to invincibility. With a halmet in other mod with night vision enchantment, you can always refresh the effect of night vision, and then always trigger healing. Can author add a trigger interval?
by 伝説
Prototype Chaotic plus a night vision helmet of other mod can trigger infinitely healing. Prototype Chaotic's introduction says it adds life cap but actually it becomes healing, Is it a bug or a feature?

Can these be translated to English because Google Translate isn't accurate enough to understand.
Its not important for me to actually understand them as long ass they are not too harmful to gameplay.

Considering this mod is about to discontinue and only has limited support now, problem 1, 2 and 3 won't be fixed.


Interact Touch Custom Collider Screwing Up Controllers??

Environment

Source of VRTK (Unity Asset Store or Github)

AssetStore

Version of VRTK:

3.2.1

Version of Unity3D

2017.3f1

Hardware used (e.g. Vive/Oculus)

Windows Mixed Reality Dell Visor

SDK used

SteamVR

Steps to reproduce
Just put your custom controller with collider into the Custom Collider field and play?
Expected behavior
The collider on the controller for Interacting with objects should be more precise to the controller.
Current behavior
A Giant clone of the controllers appear next to each one and are tracked with them.
Not sure exactly what's happening here, or if I'm just doing something wrong...
I know that if I don't use a custom collider it defaults to the Vive controller colliders.  This doesnt work for me because I use custom controller models...
Thanks!

Sincere apologies if this was the wrong place to post my question :)
Thanks so much for your help!

I have a pretty large game so far and don't want it to break.  Is there anything to know before updating?


Accumulated updates for heap profiling

What problem does this PR solve?
Issue Number: close #9241 close #3236
Problem Summary:
What is changed and how it works?

Check List
Tests

[ ] Unit test
[ ] Integration test
[ ] Manual test (add detailed scripts or steps below)
[ ] No code

Side effects

[ ] Performance regression: Consumes more CPU
[ ] Performance regression: Consumes more Memory
[ ] Breaking backward compatibility

Documentation

[ ] Affects user behaviors
[ ] Contains syntax changes
[ ] Contains variable changes
[ ] Contains experimental features
[ ] Changes MySQL compatibility

Release note

None

mv: can't rename 'log': No such file or directory

/retest

/retest


Improve User model methods to get the name

Description
User methods get_full_name() and get_short_name() should return sensible default values or raise an exception since the fields they rely on are no longer used.
Rationale
This projects does not make use of User fields first_name and last_name.
Recently, in #2998, these fields were removed from the User model altogether.
Calling the methods above do not return meaningful values.
>>> user.get_full_name()
'None None'

>>> user.get_short_name()
None

Hey! I'd like to work on the following issue.
Could you please provide a little bit more information.
I observed in the code that in the User model first and last name fields have been explicitly set to 'None', does this require a change to that?
Thankyou.

@cachitas @bansaljas I'm against any changes to those functions since it adds unnecessary code. They really don't make any sense since we use the name column/attribute instead of first_name and last_name for international purposes. get_full_name is basically just getting the name attribute. get_short_name only makes sense in terms of first_name.

we use the name column/attribute instead of first_name and last_name for international purposes.

I agree that the field name is overall better and my intent on opening this issue was not to change that.
I just wanted to let you know that the methods mentioned above are returning meaningless values and, for consistency, we should adapt them to use the name field value somehow.
For instance, we could define them as simple as
def get_full_name(self):
    return self.name

def get_short_name(self):
    return self.name.split()[0]

Or if you don't want to go into specifics, just raise NotImplementedError and let everyone handle it as they see fit. The inconsistency in returning 'None None' or None is what I think could be improved.
Anyway, if in the end you still feel like this adds unnecessary code, feel free to close this :)

just a person with some thoughts :) I like the idea of raise NotImplementedError to signify to the dev that they really shouldn't be using those methods anymore!

I agree with @Andrew-Chen-Wang here. If we're talking about adding these methods just for the sake of adding them, then I'm -1 on this.
If this is causing a lot of issues with some third party django packages that rely on them, we might consider fixing these, but I don't think that's the case (otherwise this issue would get a lot more attention).


about tulu v2 conversion

Hi, I have a two questions regarding the tulu v2 dataset.
Q1. If I'm understanding correctly, the reformat_datasets.py is used to reproduce the tulu dataset. It converts a bunch of different datasets and concat into tulu v2. I can see random subsamplings, have you considered a more curated approach of subsampling from these dataset? Will it help further increase performance? (or perhaps the granularity of this research question belongs to a different study)
Q2. I am trying to convert the tulu v2 dataset into sharegpt multiturn format to adapt to my existing code. I first download the 3 parquet files, turn them into jsonl, and turn the format into sharegpt format. However, I find it extremely hard to perform the conversion, either by regex or even manually. Somehow there are always some JSON formatting issues that hf.dataset fails to deal with. Here is some code snippet that i tried to use:
def process_jsonl_file(input_file_path, output_file_path):
    # Define the regex patterns and replacements
    replacements = [
        (r'^"', ''),  # Remove leading quotation mark at the start of each line
        (r'\}\]"', '"}]}'),  # Replace '}]" with "}]},
        (r"\[{'role': 'user', 'content': \\", '{"conversations": [{"from": "human", "value": "'),  # Handle escape character
        (r"\[{'role': 'user', 'content': '", '{"conversations": [{"from": "human", "value": "'),
        (r'\}\n \{', '}, {'),  # Replace }\n { with }, {
        (r"\[{'role': 'system', 'content': '", '{"conversations": [{"from": "human", "value": "'),  # New pattern for 'system' role
    ]

def correct_json_format(json_string):
    # Correct common string format issues
    #corrected_string = json_string.replace("\\n", "\n")
    # Replace specific patterns
    corrected_string = json_string.replace("\"}\n {'role': 'user', 'content': '", "\"}, {\"from\": \"human\", \"value\": \"")
    corrected_string = corrected_string.replace("'}\n {'role': 'user', 'content': '", "\"}, {\"from\": \"human\", \"value\": \"")
    corrected_string = corrected_string.replace("'}\n {'role': 'user', 'content': \"", "\"}, {\"from\": \"human\", \"value\": \"")

    corrected_string = corrected_string.replace("'}\n {'role': 'assistant', 'content': \"", "\"}, {\"from\": \"gpt\", \"value\": \"")
    corrected_string = corrected_string.replace("'}\n {'role': 'assistant', 'content': '", "\"}, {\"from\": \"gpt\", \"value\": \"")
    corrected_string = corrected_string.replace("\"}\n {'role': 'assistant', 'content': '", "\"}, {\"from\": \"gpt\", \"value\": \"")

    # Return the corrected string
    return corrected_string

This is the target format (from UltraChat):
{"conversations": [{"from": "human", "value": "Are there any X?"}, {"from": "gpt", "value": "Yes, there are X"}, {"from": "human", "value": "That sounds great! Can you Y?"}, {"from": "gpt", "value": "Sure, here are Y"}]}
{"conversations": [{"from": "human", "value": "What percentage A?"}, {"from": "gpt", "value": "About 71%."}, {"from": "human", "value": "Wow, that's B"}, {"from": "gpt", "value": "Yes, it certainly is! "}]}

Like, am i doing this correctly? I'm completely lost at this point.
thank you for your help!

Hi!

Yes, we randomly subsampled many of the datasets to try and reduce the overall dataset size. More careful curation (as opposed to random sampling) would probably help improve performance, and there is lots of interesting research being done (and to be done) in this direction :)

Huggingface will automatically load the json into python-native formats, so you shouldn't be trying to do regex. I think rather what you want to do is something like this:

from datasets import load_dataset
ds = load_dataset('allenai/tulu-v2-sft-mixture')
new_data = []
for sample in ds:
    messages = sample['messages']
    conversations = []
    for message in messages:
        conversations.append({"from": message['role'], 'value': message['content']})
    new_data.append(conversations) # one sample is now converted
# save new_data

That works! Leaving the code for reference.
Thank you for your kind response and best wishes to you.
from datasets import load_dataset
import json

ds = load_dataset('allenai/tulu-v2-sft-mixture')

new_data = []
# Access the 'train' subset of the dataset
train_dataset = ds['train']

# Now you can iterate over the samples in the train dataset
new_data = []

for sample in train_dataset:
    messages = sample['messages']
    conversation = []  # This will hold the conversation pairs
    for message in messages:
        # Change 'user' and 'assistant' to 'human' and 'gpt'
        role = 'human' if message['role'] == 'user' else 'gpt'
        conversation.append({"from": role, 'value': message['content']})
    new_data.append({"conversations": conversation})  # Wrap the conversation in another dict

# save new_data
# Write to a JSONL file
with open('/content/drive/MyDrive/tulu_Sharegpt.jsonl', 'w', encoding='utf-8') as jsonl_file:
    for message in new_data:
        jsonl_file.write(json.dumps(message, ensure_ascii=False) + '\n')


my crude understanding of a pipeline stub

How is this different/the same as what goes on in Plots? I mean where would it enter the Plots pipeline?

I think the idea is just to define functions for what happens between apply_recipe. Plots could hook into recipe_after_plot and call _plot_setup and _subplot_setup.

Thats correct, this would kind of replace/ split the plotting pipeline of plots. And plots would hook in to the recipe-functions (which could do nothing by default)

That's the exact opposite of my design :joy:

we should look about the pros/cons of either approach then ^^

I guess it is about, whether the order of recipe processing calls need to have a hard contract or whether it is okay for other packages to do with the recipe processing functions as they see fit

Its a gripe of me, that sometimes I wanted to have hooks into the Plots pipeline for the backend, but there simply was none at the point I'd like to. Also it is not too well documented what is available when ( hence my call for the mock-backend).


Rspec compatibility is added

Hi,
I extracted the "pretend_..." and the other two methods into a module and included into the right rspec class.
This way it can be used very conveniently in rspec too :)
I like this syntax :)
pretend_... {
#test code syntax
}
Now this works with rspec too :)

@orbanbotond Thanks for the pull request! I'm going to merge this into Harvest and see how it plays there. Assuming that's fine, I'll release a new version of the gem.


configurable normalizations

This PR adds configurable normalizations for both the source and targets similar to the transformations/augmentations that are applied to the samples.

@ziw-liu just tested with new dataset using the preprocessing and we can do the normalizations


Focal Frequency Loss TF2 Keras implementation

Hello, thanks to publish your great idea on the web.
I tried to implement tensorflow 2(keras) version of Focal Frequency Loss.
But I noticed my loss value easily inflate into inf....... is there any way to fix that?

When will you release the code?

import tensorflow as tf
def fft2d(img):
img = tf.cast(img,dtype=tf.complex64)
fft = tf.signal.fft2d(img)
fft = tf.math.real(fft)
return fft
#loss stable than focal frequency loss
def frequency_loss(y_true,y_pred):
fft_true = fft2d(y_true)
fft_pred = fft2d(y_pred)
return tf.keras.losses.MeanSquaredError()(fft_true,fft_pred)
#easily go to inf....
def focal_frequency_loss(y_true,y_pred):
fft_true = fft2d(y_true)
fft_pred = fft2d(y_pred)
alpha = tf.constant(1.0, dtype=tf.float32)
sub = tf.math.subtract(fft_true,fft_pred)
sub_abs = tf.math.abs(sub)
norm = tf.math.divide(sub_abs, tf.math.reduce_max(sub_abs))
weight = tf.math.pow(norm,alpha)
se = tf.math.square(tf.math.subtract(fft_true,fft_pred))
w_se = tf.math.multiply(weight,se)
loss = tf.math.reduce_mean(w_se)
return loss
2021年9月2日(木) 16:20 Wangbo Yu @.***>:

When will you release the code?
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
https://github.com/EndlessSora/focal-frequency-loss/pull/2#issuecomment-911305459,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AG22FNVI4PQXQUIDWUTA7MTT74QVBANCNFSM4YEJS2KA
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.


Migrate big blogs of text into PANDA.text.*

Or even PANDA.trans.en.*

Nevermind, the need for this is obviated by moving the tooltips into inline templates. Better solution for now.


Is it better to consider generating sparse matrix in R?

As far as I know, using model.matrix is generating a dense matrix https://github.com/szilard/benchm-ml/blob/master/2-rf/1.R#L16 which is extremely memory inefficient.
The glmnet package in R can do linear regression on top of sparse matrix. I guess H2O can handle sparsity really well so it never crashes. If we can also have the result with the sparse matrix, then it is getting fairer and more meaningful.

Well, linear models are not really the main focus of this study (due to lower accuracy), but if you rewrite the code with SparseMatrix and send me the code and timings, I'll be happy to include your findings.

Another reason to argue this is xgboost also supports sparse matrix input. I will send you the code with this transformation soon.
One thing is I am not working on a decent machine so probably I cannot test the code with too large data sets. I hope there's nothing happening in the transformation process on them.

Merges your code, re-run results, updated docs. Thanks for the tip/code with sparse matrix.


Difference between Normal and Normalout ?

What is the difference between the Normal and Normalout classes (in utils/BBBdistributions.py )? They seem to have identical code, but it is confusing.

There is no difference. It has now been fixed.


Version bump?

Can you please version bump this in the supermarket?
Thanks!

Seconding the version bump requrest.
FWIW, we are using Berkshelf to manage our dependencies, and as a workaround have our Berksfile pointed directly at this repo (with appropriate version pinning) instead:
source 'https://supermarket.chef.io'

metadata
cookbook 'application_ruby', git: 'https://github.com/poise/application_ruby.git', ref: 'fde770d176b5d0519982e2ec93bcf2d1a3ad35bb'

I can second this work around. I was too sad about this workaround to post it. I am glad you did though.

+1

The next release is going to be 4.0.


Release Summary report Rerun link causing a 'comment is too long' issue

Unable to create an issue because of this:

Close this issue as we removed the rerun link in the release summary report.


Move to Heroku

We've only really used the club's Digital Ocean cluster for Handy since its creation. Heroku can provide everything Handy needs for free, and with less maintenance required.

:pray:

No, since Handy spends most of its time idle. It won't come close to the 18-hour maximum uptime per 24-hour period.

Sweet

@jroggeman: This seem okay to you? If so, I'll merge this tonight and give you and @alexlafroscia push access to the Heroku app.


Overriding configuration for thresholds based on filnname pattern

Do we have any option like:
https://github.com/karma-runner/karma-coverage/blob/master/docs/configuration.md#check
I am using [karma-coverage-istanbul-reporter] for angular4 project, and I need different coverage thresholds for *.component.ts and *.service.ts and base classes

Added in 1.3.0 😄


Support for EasyRepro Dynamics 2021 release wave 2

Question
Hi, Could you please advise if there are plans/timescale to support the 2021 Release Wave 2 version of Dynamics 365? We have updated one of our testing environments to the update scheduled for release in October via early access and noticed quite a substantial impact on our automation test scripts. Your answers will help us plan our remediation effort accordingly.
Thanks in Advance.
Nidhi

#1169 @VikramKurri, this is related and I'm linking the work items. Reviewing now.

@aliyoussefi Do you have any update on this query please? If you could let us know by when EasyRepro is planning to release an update to support the 2021 Release Wave 2 version of Dynamics 365? This will help us in strategizing our next steps accordingly.
Thanks.

Hi @nidhimishradeloitte I do not have the date for the update for the release wave 2 but I have a change that fixes the grid and most of the subgrid (still working on get subgrid items). The issue is the dynamic loading of data from state that the pcf grid control now performs.  Here is the fork I am referring to and working on: https://github.com/aliyoussefi/EasyRepro

Hi @aliyoussefi @ewingjm,
Could you please let us know if EasyRepro has launched official release of  Wave 2 2021?
Thanks,
Nidhi


unpack with tuple as return value

This is a problem that I run into, but I didn't find any reference in the documentation.
If we take the following example
from flask_restful import Api, Resource
from flask import Flask

app = Flask(__name__, )
api = Api(app)

class MyResource(Resource):
    def get(self, attribute):
        if attribute == 'string':
            return 'one two'
        if attribute == 'tuple':
            return ('one', 'two')
        if attribute == 'list':
            return ['one', 'two']
        return "Nothing there"

api.add_resource(MyResource, '/<string:attribute>/', endpoint='example')

app.run(host='<IP_ADDRESS>', debug=True, use_reloader=True)

If we access:

http://localhost:5000/string/  => "one two"
http://localhost:5000/list/ => ['one', 'two']
http://localhost:5000/tuple/ => one

The problem with the tuple, it that the unpack method takes the second element as code and doesn't raise a warning or anything,  so we think everything works as expected.
The most obvious solution is add the code to the return statement return ('one', 'two'), 200
But the fact that the code is not mandatory in the return makes it too easy to make a mistake

Is this different from Flask's response parsing?


Don't truncate image names in container creation log messages.

Loglines like "Creating new container for quay.io/" aren't helpful. This just emits the full name.

I wonder why someone gave it such a short range...

I think it was supposed to be the short name for the image ID not the name. Full name is better, though, obviously. :)


Song lyrics

Can you get song lyrics?

Hello, sorry for delay, yes we can, but i need some help in android

Fixed in V2


[feature request]: url uploader

Paid support is available for quick resolution & help.
For paid support, please write mail to<EMAIL_ADDRESS>

If by that issue you mean being able to pass an URL rather than a PATH, I don't think that should be the package's responsabilities, that should be on us, users, to handle file downloading before passing the PATH to the package.


Create function for inserting csv

Can now insert csv directly to relevanceai
Supports chunking csv
Checks for id
Returns failed document ids
Also updated json serializer to check for NAN floats

This is a solid PR


default values does not not take in account when resolving annotation options

Setup

"react": "^17.0.2",
"chart.js": "^3.0.2",
"chartjs-plugin-annotation": "^1.0.0",

import Annotation from 'chartjs-plugin-annotation';
...
data={ ... }
options={ {
    ....
    annotations: [ {
	drawTime: "afterDatasetsDraw",
	id: "hline",
	type: "line",
	mode: "horizontal",
	scaleID: "yAxes",
	value: 62,
	borderWidth: 2
    } ]
} }
plugins={ [ Annotation ] }

Description
I was struggling to get this to work quite some time. No example worked for me. Sometimes event some error of undefined poped out.
And it seems that default values are not take in account when resolving annotation options. It started to work after suggested fix.
Fix suggestion
Modify resolveObj in annotation.js as follows
function resolveObj(resolver, defs) {
  const result = {};
  for (const name of Object.keys(defs)) {
    const optDefs = defs[name];
    const value = resolver[name];
	result[ name ] = isObject( optDefs )
		? resolveObj( value ? value : {}, optDefs )
		: value
			? value
			: optDefs;
  }
  return result;
}

From the README:

This plugin needs to be registered. It does not function as inline plugin

Looks like this note is not in docs.

I confirm, registered plugin works out of the box.
I wonder tough. That was the second thing that i did after installing it and back then it did not work. And when looking to codes i saw:
chart_js.Chart.register( Annotation );

From this i though it might not need to be registered anymore.
I suppose that options format was incorrect back then and when i started to messing up i forgot to register it again. All examples I found specified options as
annotation: {
    ...
    annotations: [...]
}


How do transform-connector, transformations, actions and operations fit together

I've got a pretty good mental model of how everything works in orbit.js and ember-orbit now. One area which is very hazy though is what's happening with the transformation pipeline, in particular how the transform-connector mediates the processing flow in transformable. @dgeb could you spare a few minutes in IRC at some point to answer a few questions? I'd be very happy to write it up in the wiki.

The reason I'm looking at this at the moment is because I've got a test which fails because the transformations hang. It's proving extremely difficult to debug...

@opsb sure, just ping me in IRC and I'll respond as soon as I'm available.

This issue should no longer be applicable with the rethink merger.


Provide Option to read unsynced lyrics using Metadata or ID3Tags

Replace the content in the sections below.
[REQUIRED] Use case description
Provide Option to read unsynced lyrics using Metadata or ID3Tags
Currently I Am trying to read unsynced lyrics
Using the below code
override fun onTracksChanged(tracks: Tracks) {
                    //https://github.com/androidx/media/issues/922
                    //https://github.com/androidx/media/issues/1305
                    tracks.groups.forEach { group ->
                        for (i in 0 until group.length) {
                            group.mediaTrackGroup.getFormat(i).metadata?.let { metadata ->
                                for (j in 0 until metadata.length()) {
                                    metadata.get(j).let {

                                        if (it is CommentFrame) {
                                            println("${it.id} ${it.text}") // COMM <value>
                                        }
                                        if (it is BinaryFrame) {
                                            Log.e(
                                                "Metadata",
                                                "id3 BinaryFrame key: " + it.id + " data: " + it.data.size
                                            )
                                            if ("USLT".equals(
                                                    it.id,
                                                    ignoreCase = true
                                                )
                                            ) {
                                                Log.e(
                                                    "Metadata",
                                                    "id3 UNSYNCEDLYRICS onTracksChanged: " + String(
                                                        it.data
                                                    )
                                                )
                                            }
                                        }
                                    }
                                }
                            }
                        }
                    }

                }

This code is able to read synced Lyrics like below

How ever when we try to read unsynced Lyrics it is not able to read them like below

Proposed solution
It would be better if we are able to read it as metadata using
override fun onMediaMetadataChanged(mediaMetadata: MediaMetadata) {
                   super.onMediaMetadataChanged(mediaMetadata)
                   mediaMetadata.title?.let( { println(it) } )

               }

Which provides various options like Title, composer , Artist , Album etc
Alternatives considered
there are options to use Third party alternativos like .
jaudiotagger
Or  mp3agic
How ever they can be unreliable and an inbuilt solution will be helpful.

This looks like a duplicate of https://github.com/androidx/media/issues/922


Added EMPD2 samples contributed by Matthias

Hi! I'm your friendly automated EMPD-admin bot!
Thank you very much for your data submission! I will now run some tests on your data.
In the meantime: please review your test data on the EMPD viewer using
this link: https://EMPD2.github.io/?repo=EMPD2/EMPD-data&branch=Matthias&meta=Matthias.tsv
This bot is helping you merging your data. I am checking for common issues and I can fix your climate, country or elevation data.
Type @EMPD-admin help in a new comment in this PR for usage information.
Make sure, that all the commands for the @EMPD-admin are on one single line and nothing else. Only
@EMPD-admin help
will work, not something like
<other words> @EMPD-admin help
or
@EMPD-admin help <other words>
Note that you can also run these tests on your local machine with
pytest.

Hi! I'm your friendly automated EMPD-admin bot!
This is just to inform you that I tested your data submission in your PR (Matthias.tsv) and found it in an excellent condition!

@EMPD-admin finish --commit

Hi! I'm your friendly automated EMPD-admin bot!
I processed your command and hope that I can help you!

finish --commit

Finished the PR!
You may want to have a final look into the viewer (https://EMPD2.github.io/?repo=EMPD2/EMPD-data&branch=Matthias) and then merge it.


[storage] Rename NVMe -> Nvme

[storage] Rename NVMe -> Nvme
[storage] auto-generate protos

We've already renamed NVMe to Nvme some time ago. Here we renamed NVMf to Nvmf.  I don't mind.
However, I still see commit message for 8d0ca21 as
[storage] Rename NVMe -> Nvme

Naming NVMe caused proto to force "nv_me" syntax which is weird

Let's update it to better represent the point of the change, maybe smth like
[storage] Rename NVMf -> Nvme

Naming NVMf caused proto to force "nv_mf" syntax which is weird.
Unify the naming to Nvme format utilized throughout all API components.

Wdyt?

Wdyt?

done


RSocketClient from TCP socket

This allows creating RSocketClient directly from the opened TCP socket (folly::AsyncSocket) via 2 synchronous calls.

there is a known race condition in the async tests causing travis to fail. I will unblock myself and land the PR and then follow up on the test failure.


Subscription override for corp and online

Community Note

Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description
Hi,
I am using the enterprise scale module to create corp and online management groups under "Landing Zones" with this config:
deploy_corp_landing_zones   = true
deploy_online_landing_zones = true
How am I supposed to assign my Landing zone subscriptions to corp and online management groups?
I have tried with the following code in "settings.core.tf":
locals {
subscription_id_overrides = {
root           = []
decommissioned = []
sandboxes      = []
landing-zones  = [] # Not recommended, put Subscriptions in child management groups.
platform       = [] # Not recommended, put Subscriptions in child management groups.
connectivity   = [] # Not recommended, use subscription_id_connectivity instead.
management     = [] # Not recommended, use subscription_id_management instead.
identity       = [] # Not recommended, use subscription_id_identity instead.
corp           = ["ID"]
online         = ["ID"]
}
}
Have also tried with the Custom landing zone.
https://github.com/Azure/terraform-azurerm-caf-enterprise-scale/blob/main/docs/wiki/[Variables]-custom_landing_zones.md
Do I have to add archetype_config_overrides? If the answer is yes, do you have a guide available for how to use archetype config?
https://registry.terraform.io/modules/Azure/caf-enterprise-scale/azurerm/0.0.3-preview
Thanks in advance!

Describe the solution you'd like

Additional context

Hi @linus-lysell,
Thanks for raising this issue. How have you deployed your corp and online management groups?
If you have used the deploy_demo_landing_zones option, then you can add subscriptions to these management groups using the subscription_id_overrides variable in the module.
module "enterprise_scale" {
  source  = "Azure/caf-enterprise-scale/azurerm"
  version = "1.0.0"

  providers = {
    azurerm              = azurerm
    azurerm.connectivity = azurerm
    azurerm.management   = azurerm
  }

  root_parent_id = data.azurerm_client_config.core.tenant_id
  root_id        = var.root_id
  root_name      = var.root_name
  library_path   = "${path.root}/lib"

  deploy_demo_landing_zones = true

  subscription_id_overrides = {
    corp = [
      "00000000-0000-0000-0000-000000000000",
      "00000000-0000-0000-0000-000000000001"
    ]
  }
}

If you are using a local to define the subscription_ids, then you can map this as follows:
module "enterprise_scale" {
  //...
  subscription_id_overrides = local.subscription_id_overrides
  //...
}

Note, that you don't have to specify an empty list for the other management groups. You can be explicit and omit any others that you do not want to manage.
However, if you are deploying corp and online as a custom landing zone archetype, then you should use the subscription_ids list in that definition, just like the example main.tf.
Hope this helps!

Hi,
Thanks for a quick and good answer.
I had missed to map the local value. "subscription_id_overrides = local.subscription_id_overrides"


Demo PR

can we please start doing "proper" packages that are getting ready for releases, etc. So, please include dependencies, install targets etc. I'm happy to merge this now, but please keep the quality of PRs high.

Hi yes this was temporary as we needed to have the latest demo ready for tomorrow when I'm back I'll document this propely and include the right dependencies licence and install targets

We should probably start testing these before pulling them as well, as a few of the recently pull requests have been quite buggy...

Get @jailander to agree and write tests 😀

This one only has the play twice bug as far as I know, once again I only made this PR so @pet1330 could have the demo running tomorrow for the visitors. Please if you see any other bug open an issue.

I'm just teasing you @jailander 😉

Haha I know that, I was intrigued by the buggy part given that is my second PR to upstream and I wanted to know if @pet1330 had found another bug I had to fix I just sound grumpy because of the cold :P

@Jailander I found another one... :stuck_out_tongue_winking_eye:


build: fix cross-compilation on Darwin platforms

After https://github.com/apple/swift/pull/32705 was merged, cross-compiling stdlib from Darwin to other platforms (such as WebAssembly/WASI) fails. This is fixed by performing the condition check for Darwin targets within the buil-script loop.

Related to SR-9307

@swift-ci Please smoke test


clone failed according to readme

$ git clone git@github.com:blockstack/blockstack-stats.git
Cloning into 'blockstack-stats'...
Warning: Permanently added the RSA host key for IP address '<IP_ADDRESS>' to the list of known hosts.
Permission denied (publickey).
fatal: Could not read from remote repository.
Please make sure you have the correct access rights
and the repository exists.

use 'git clone https://github.com:blockstack/blockstack-stats.git' instead


Space in feature name is not possible

Executing bdd2octane for a feature file with a space in the filename results in a skip since the space is converted to %20 and bdd2octane doesnt recognize this. Is there a configuration that needs to be set to prevent this?
When downloading a gherkin test from alm octane which has spaces in its name, it also copies the spaces like it is in Octane.
If there is no workarround for this we either need to use PascalCasing in octane, or we always need to download a script, copy its contents to the file without spaces and delete the file with spaces. Because ALM Octane plugin doesn't let you configure the name through the IDE (IntelliJ).
The command line execution log:
`java -jar C:\Dev\bdd2octane\bdd2octane-1.1.2.jar --reportFiles="/target/surefire-reports/..xml" --featureFiles="/src/test/resources/features/**/*.feature" --framework="cucumber-jvm" --resultFile="target/bdd2octane-reports/cucumber-jvm-result.xml"
Picked up JAVA_TOOL_OPTIONS: -agentlib:jvmhook
Picked up _JAVA_OPTIONS: -Xrunjvmhook -Xbootclasspath/a:"C:\Program Files (x86)\Micro Focus\Unified Functional Testing\bin\java_shared\classes\jasmine.jar"
All xml files matching pattern "/target/surefire-reports/..xml":
target\surefire-reports\TEST-testrunners.RunCucumberTest.xml
All feature files matching pattern "/src/test/resources/features/**/*.feature":
src\test\resources\features\example.feature
src\test\resources\features\webshop\Buy Items_65001.feature
src\test\resources\features\webshop\contact\DemoBDD2_67003.feature
src\test\resources\features\webshop\login\Login_64003.feature
src\test\resources\features\webshop\login\poc_10001.feature
cannot locate a feature file by path:  classpath:features/webshop/Buy%20Items_65001.feature skipping...
8 test case(s) processed
1 test case(s) skipped`

The issue was resolved on latest release 1.1.3


Do you have a very simple example of how to trigger a push to our sentry server using raven-go?
I'm on OSX 10.11.1, and running go1.5.1 darwin/amd64.
I've tried using some of the examples in this repo, and some I've found elsewhere, but I must be doing something fundamentally wrong as I just can't get it to push to sentry.
Any tips, or links, gratefully accepted.

@mjdavies; can you post a code sample of your best attempt so far?

Hi Taylor
Thanks for getting back to me.
I've used https://github.com/getsentry/raven-go/blob/master/example/example.go as a starting point, and simply added my sentry details like so.
package main

import (
	"errors"
	"fmt"
	"github.com/getsentry/raven-go"
	"log"
	"net/http"
	"os"
)

func init() {
    raven.SetDSN("http://MYSENTRYDETAILS")
}

func trace() *raven.Stacktrace {
	return raven.NewStacktrace(0, 2, nil)
}

func main() {
	client, err := raven.NewWithTags(os.Args[1], map[string]string{"foo": "bar"})
	if err != nil {
		log.Fatal(err)
	}
	httpReq, _ := http.NewRequest("GET", "http://example.com/foo?bar=true", nil)
	httpReq.RemoteAddr = "<IP_ADDRESS>:80"
	httpReq.Header = http.Header{"Content-Type": {"text/html"}, "Content-Length": {"42"}}
	packet := &raven.Packet{Message: "Test report", Interfaces: []raven.Interface{raven.NewException(errors.New("example"), trace()), raven.NewHttp(httpReq)}}
	_, ch := client.Capture(packet, nil)
	if err = <-ch; err != nil {
		log.Fatal(err)
	}
	log.Print("sent packet successfully")
}

// CheckError sends error report to sentry and records event id and error name to the logs
func CheckError(err error, r *http.Request) {
	client, err := raven.NewWithTags(os.Args[1], map[string]string{"foo": "bar"})
	if err != nil {
		log.Fatal(err)
	}
	packet := raven.NewPacket(err.Error(), raven.NewException(err, trace()), raven.NewHttp(r))
	eventID, _ := client.Capture(packet, nil)
	message := fmt.Sprintf("Error event with id \"%s\" - %s", eventID, err.Error())
	log.Println(message)
}

When I then run go build, and go install, and then execute the example file, I get this.
trj260-mdmac:example$ example
panic: runtime error: index out of range

goroutine 1 [running]:
main.main()
	/Users/mjdavies/go/src/github.com/uniglam/example/example.go:21 +0x9ce

goroutine 17 [syscall, locked to thread]:
runtime.goexit()
	/usr/local/go/src/runtime/asm_amd64.s:1696 +0x1

goroutine 5 [chan receive]:
github.com/getsentry/raven-go.(*Client).worker(0xc8200ac0b0)
	/Users/mjdavies/go/src/github.com/getsentry/raven-go/client.go:417 +0x60
created by github.com/getsentry/raven-go.newClient
	/Users/mjdavies/go/src/github.com/getsentry/raven-go/client.go:306 +0x192

Like I said, I may be doing something really stupid.

you need to call it like so
go build && ./example http://MYSENTRYDETAILS

and take out the init function, you don't need that.
NewWithTags creates a new instance of client with the first arg being your dsn cred, so you need to pass it in as an arg when you run example
https://github.com/getsentry/raven-go/blob/1cc47a9463b90f246a0503d4c2e9a55c9459ced3/client.go#L319

Thanks Jack, that worked a treat!!


Project saves with .DS_Store on windows

For some reason projects have the macOS .DS_Store file included.

Oh those pesky things get everywhere... I've fixed this in the develop branch so next release shouldn't have this problem 2554bf4ba7375dce5aeaed5a9d1cffede2020130


[AIRFLOW-561] Redshift to S3 Operator

Dear Airflow Maintainers,
Please accept this PR that addresses the following issues:

https://issues.apache.org/jira/browse/AIRFLOW-561

Per Apache guidelines you need to create a Jira issue.
Testing Done:

Unittests are required, if you do not include new unit tests please
specify why you think this is not required. We like to improve our
coverage so a non existing test is even a better reason to include one.

Reminders for contributors (REQUIRED!):

Your PR's title must reference an issue on
Airflow's JIRA.
For example, a PR called "[AIRFLOW-1] My Amazing PR" would close JIRA
issue #1. Please open a new issue if required!

For all PRs with UI changes, you must provide screenshots. If the UI changes are not obvious, either annotate the images or provide before/after screenshots.

Please squash your commits when possible and follow the How to write a good git commit message.
Summarized as follows:

Separate subject from body with a blank line
Limit the subject line to 50 characters
Do not end the subject line with a period
Use the imperative mood in the subject line (add, not adding)
Wrap the body at 72 characters
Use the body to explain what and why vs. how

Please provide tests.. assuming you can mock the redshift/s3 backends. Also, please squash your commits and preface your commit message with [AIRFLOW-561]. We need that in both the commit and PR titles.

Thanks for the feedback @r39132. I've squashed my commits, but I'm not sure it makes sense to add additional tests because the operator is composed of the S3Hook and the PostgresHook, which have already been thoroughly tested. I can't think of a good way to test the behavior of this operator specifically because it is using an SQL query that contains the S3 path to make the unload, making it difficult to mock.

It would be nice if it accepted role-based CREDENTIALS, not just key-based ones.

Current coverage is 65.94% (diff: 2.32%)

Merging #1831 into master will decrease coverage by 0.23%

@@             master      #1831   diff @@
==========================================
  Files           127        128     +1
  Lines          9764       9807    +43
  Methods           0          0
  Messages          0          0
  Branches          0          0
==========================================
+ Hits           6462       6467     +5
- Misses         3302       3340    +38
  Partials          0          0

Powered by Codecov. Last update 9b689d0...3225403

@mmmaia I'm not quite sure I understand what you mean - the only role-based credentials I see in the S3_Hook.py are used for STS, which requires the key-based credentials. Would you mind clarifying on next steps?

@jackar sorry for the delay in getting back to this.. I've been going thru a mountain of PRs in my late hours/spare time, which is less these days with a newborn at home.
This looks pretty good, but I agree with @drknexus comment and wonder if you can create a redshift hook here to support extra params like PARALLEL = On/Off (True/False).

@r39132 no worries - I appreciate you getting back to me at all, it sounds like you have your hands full. Let me know if you think my solution makes sense. Thanks!

+1


Update README.md

[x] update footnote on validation to point to my wiki on validation (& update signature file name to match wiki).
[x] add table of contents
[ ] move example to examples folder with actual scripts.

examples are fine where they are.


WebRtc getUserMedia frameRate is not supported

Original post at https://github.com/mozilla/kuma/issues/5994
Hello:
I called Firfox's webrtc api, and MDN showed support, but I made a mistake when I called it.
https://developer.mozilla.org/en-US/docs/Web/API/Media_Streams_API/Constraints
https://developer.mozilla.org/zh-CN/docs/Web/API/MediaDevices/getUserMedia
1.webRtc getuserMedia frameRate:
image
2.my code
navigator.mediaDevices.getUserMedia({
// audio: this.config.audio,
video: {
width: { min: 640, ideal: 1920 },
height: { min: 400, ideal: 1080 },
aspectRatio: { ideal: 1.7777777778 },
frameRate: { max: 15},
},
}).then((stream) => {
this.successCb(stream);
})
3.error in firefox
image
UA
"Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:69.0) Gecko/20100101 Firefox/69.0"
other
When I wrote like this, he returned a dynamic bit rate.
navigator.mediaDevices.getUserMedia({
  // audio: this.config.audio,
  video: {
    width: { min: 640, ideal: 1920 },
    height: { min: 400, ideal: 1080 },
    aspectRatio: { ideal: 1.7777777778 },
    frameRate: 15
  },
}).then((stream) => {
  this.successCb(stream);
})

I wonder why this happens？

This behavior is exactly as expected. If you specify frameRate: 15, you're saying "I would like 15 but will accept whatever you can give me." If you specify frameRate: {max: 15}, you're saying "I will not accept a frame rate higher than 15 FPS."
At least on my Mac, my camera will not produce a stream at 15 FPS, so the latter (max: 15) fails with an OverConstrainedError.
Give the "constraint exerciser" a try on this page:
https://developer.mozilla.org/en-US/docs/Web/API/Media_Streams_API/Constraints#Example_Constraint_exerciser
Keep in mind this uses JSON so you need to format the constraint strings in JSON format:
{
  "width": 320,
  "height": 240,
  "frameRate": { "max": 15 }
}

(For example)
Let me know if I've misunderstood your ticket; if not, then there isn't any documentation update required for this.


update Command line options docs on README.rst

the "Command line options" section on docs is deprecated.
this pull-request update the docs to same output of pylama==7.0.0

Thank you!


Improve page type specification logic.

Improve page type specification logic.
Modify the Element type specification logic and API so that you can write code more easily when setting up the HotReloader for each Xamarin.Forms Element.
Use case
As described in README.md, ALL XAML partial classes (ContentPage, ViewCell etc.) MUST be set up like:
#if DEBUG
using Xamarin.Forms.HotReload.Reloader;
#endif

using System.Windows.Input;

namespace Xamarin.Forms.HotReload.Sample
{
    public partial class MainPage : ContentPage
    {
        public MainPage()
        {
#if DEBUG
            this.InitializeElement();
#else
            InitializeComponent();
#endif
        }
    }
}

However, I did not want to write the HotReloader setup code-InitializeComponent-repeatedly
(DRY-Don't Repeat Yourself). Instead, I wanted to use the Page Factory to generate the Page, and have the HotRenderer setup code run alongside. This will bring the HotReloader related code into one place. In other words, all of the Page classes are isolated from HotReloader, so you can keep your code clean! Therefore, the range of influence of HotReloader related code addition/deletion task becomes smaller, and anxiety felt in the task is reduced. Obviously, difficulty of the task also becomes easier. Let's look at a concrete use case with following two source code.

How to apply HotReloader setup code to PageFactory.
public class PageFactory : IPageFactory
{

    // ...

    public TPage Create<TPage>() where TPage : Xamarin.Forms.Page
    {
        TPage page = _container.Resolve<TPage>();
#if UseHotReload
        Xamarin.Forms.HotReload.HotReloader.Current.InitializeElement<TPage>(page);
#endif
        return page;
    }

    // ...

}

How to customize the PageNavigationService when using the Prism Framework. If you customize only the Prism Framework's INavigationService as follows, HotReloader is automatically set to all pages.
public class PageFactoryNavigationService : PageNavigationService
{

    // ...

    protected override Page CreatePage(string segmentName)
    {
        Page page = base.CreatePage(segmentName);
#if UseHotReload
        // Existing API
        // Xamarin.Forms.HotReload.HotReloader.Current.InitializeElement<Page>(page);

        // New API
        Xamarin.Forms.HotReload.HotReloader.Current.InitializeElement(page, page.GetType());
#endif
        return page;
    }

    // ...

}

Problems with existing code
When setting up the HotReloader in the second use case, the problem occurs if you call the existing InitializeElement method as follows:
// Existing API
Xamarin.Forms.HotReload.HotReloader.Current.InitializeElement<Page>(page);

In this case, the TXaml Generic Type is of type Xamarin.Forms.Page, the problem is that the InitializeElement <TXaml> (TXaml element) method internally uses TXaml to infer the type of the page instance.
Solution
Modify the method so that the caller can specify the type when calling the InitializeElement method. At the same time, existing APIs are useful, so consider supporting it as they are. As a result, the HotReloader initialization API consumer will be able to use following two APIs:
// Existing API
// void InitializeElement<TXaml>(TXaml element) where TXaml : Element
Xamarin.Forms.HotReload.HotReloader.Current.InitializeElement(page);

// New API
// void InitializeElement(Element element, Type elementType)
Xamarin.Forms.HotReload.HotReloader.Current.InitializeElement(page, page.GetType());

https://github.com/AndreiMisiukevich/HotReload/blob/a4b43869a96391d32d8fdf53de0971cd48ab975f/Reloader/Xamarin.Forms.HotReload.Reloader/HotReloader.cs#L43-L74
Obsolete solution
Modify the existing InitializeElement method to use the type of the element instance instead of using the TXaml generic type. To do this, modify line 52 in the following code to var classType = element.GetType ();.
https://github.com/AndreiMisiukevich/HotReload/blob/a3880c5c4b44c7a7a3ce23feb539682ae0585418/Reloader/Xamarin.Forms.HotReload.Reloader/HotReloader.cs#L43-L70
The reason for discarding this solution is that we can no longer support the use cases provided by the exiting API approach. It is useful to be able API consumer to specify the type that is appropriate for the element that is passed in as argument, so you must support the existing use case.

@wplong11 hi) thanks for your PR
Hm, it makes sense to add isLoaded parameter for preventing redundant double loading (InitializeComponent and InitializeElement).
public void InitializeElement<TXaml>(TXaml element, bool isLoaded = false) where TXaml : Element;
public void InitializeElement(Element element, Type elementType, bool isLoaded = false)

And ..

            if (string.IsNullOrWhiteSpace(item.Xaml))
            {
               if(!isLoaded) // check is loaded..
               {
                    element.LoadFromXaml(elementType);
                    _fileMapping[className] = item;
               }
                return;
            }
        }

Or we can create new methods.. Any ideas?
Or we can avoid using isLoaded - just check is Content == null

https://github.com/AndreiMisiukevich/HotReload/pull/5#issuecomment-449870834
I did not think it was a big problem to load Xaml twice by InitializeComponent and InitializeElement. I think the problem that I can think of is the performance problem, but I do not think I can feel it.
It seems like to need to test if just check is Content == null is a sophisticated method, and the isLoaded parameter might not be intuitive.
I think create new methods is a valid approach, but there is no solution that I have right now.

@wplong11 ok, merge it for now
but i need to think how to improve it
Also, i need to add named variables support :) but it's another issue


Issue templates

Preferably in the format of issue forms, just to make our life a bit easier when it comes to feature requests and bug reports.

Thanks, @osfanbuff63 !

No problem! Are there any other issue templates you think we should make, or am I good to close this issue?

I don't know.

Alright, going to mark this as completed now. Go ahead and make a new meta issue if you think of one to add.


TS-4472: Decrement http_current_active_client_connections_stat in HTTP/2

http_current_active_client_connections_stat is incremented in HttpSM.
And if client connection is HTTP/1.1, this is decremented in Http1ClientTransaction.
But if client connection is HTTP/2, this is not decremented anywhere.

👍  - looks good


Point EZID metadata url to Pulmap only after identifier is minted

Closes #1482

Coverage remained the same at 99.406% when pulling bcc918ae935c58abec7cb0b0f7c0ce389d2a511d on 1482-geo-works-mint into 28c422528e43283bfb0515ea1ed2a698833cba12 on master.


[SSH] Add support for ephemeral keypair generation and public key signing only operation

Add support for hardware tokens (don't require the private key be passed in)
Add support for cert signing only
Add numerous short parameters
Add support for and switch default behavior to ephemeral keypair generation when no public key is passed in
Add support for Host * by not writing Hostname into ssh_config files
Cleanup stray file at the root

This checklist is used to make sure that common guidelines for a pull request are followed.

About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your PR is merged into master branch, a new PR will be created to update src/index.json automatically.
The precondition is to put your code inside this repo and upgrade the version in the PR but do not modify src/index.json.

If this PR is for a new extension or change to an existing extension, use the following to try out the changes in this PR:
docker run -it microsoft/azure-cli:latest
export EXT=<NAME>
pip install --upgrade --target ~/.azure/cliextensions/$EXT "git+https://github.com/N6UDP/azure-cli-extensions.git@topic/sshcertephemeral#subdirectory=src/$EXT&egg=$EXT"

SSH

/azp run


if a post has both images & videos, it only downloads the images.

if a post has both images & videos, it only downloads the images.
Example:
https://twitter.com/tzuyusbbl/status/1583090161294139392

I also have this problem.
Additionally, if a tweet has more than one video (but no images) it only downloads first video.
As a workaround, I was able to go to the users' profile and use the bulk media download tool, but it's time consuming to do that each time there's a mixed-media or multiple-video tweet.


Is it possible to stream more than one audio track?

There is content with different audio track options. Is it possible to stream more than one track so that when viewing, you can select the desired one?

Generally speaking, no, ETV will only process a single audio track.
The only exception to this is using HLS Direct which will send all (unprocessed) audio tracks when the schedule item and channel have no preferred audio language and no preferred audio title. Note that HLS Direct does have significant limitations (from https://ersatztv.org/docs/user-guide/create-channels#streaming-mode)

HLS Direct does not transcode content and can perform better on low power systems, but does not support watermarks and some clients will have issues at program boundaries


chore: publish blockifier

version = "0.7.0-dev.1"

This change is

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 75.18%. Comparing base (bb32e76) to head (106304f).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1758   +/-   ##
=======================================
  Coverage   75.18%   75.18%
=======================================
  Files          59       59
  Lines        8550     8550
  Branches     8550     8550
=======================================
  Hits         6428     6428
  Misses       1698     1698
  Partials      424      424

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Python side: https://reviewable.io/reviews/starkware-industries/starkware/34643

crates/native_blockifier/Cargo.toml line 30 at r3 (raw file):
Previously, yair-starkware (Yair) wrote…
I think you don't need it now

Should I delete it?

crates/native_blockifier/Cargo.toml line 30 at r3 (raw file):
Previously, aner-starkware wrote…
Should I delete it?

Done.

Need to wait for Hodor to pass anyways...


Angrifel 3148 updatedbcli

Solves Issue #3148
@anurse

Hi @angrifel, I'm your friendly neighborhood .NET Foundation Pull Request Bot (You can call me DNFBOT). Thanks for your contribution!

In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes. I promise there's no faxing. https://cla2.dotnetfoundation.org.

TTYL, DNFBOT;

@angrifel, Thanks for signing the contribution license agreement so quickly! Actual humans will now validate the agreement and then evaluate the PR.
Thanks, DNFBOT;

Pretty nice. I thought about something similar (but done via code, didn't knew migrate.exe) - but the PR seems to be including previous commits from dev.

Yeah my bad.., I forgot to change the base from 'master' to 'dev'. i'll create a new PR.


Raw input allows "lost cursor" to trigger in macOS

Enable raw input and move the mouse cursor quickly to trigger the lost cursor accessibility feature in macOS (if it's enabled).
https://streamable.com/4v9da

Turn off the feature.


[PackageBuilder] own SymplifyFileInfo covering relative path

See https://github.com/TomasVotruba/tomasvotruba.cz/pull/492

Resolved by https://github.com/Symplify/Symplify/pull/1125


Alpha Program => Error connecting to your code-server instance

Web Browser: chrome 87
Local OS: macos 10.15.2
Remote OS: Debian 4.19.67-2+deb10u1 (2019-09-20) x86_64 in a VPS(KVM)
Remote Architecture: x86_64
code-server --version: 3.7.4 11f53784c58f68e7f4c5b3b8dae9407caa41725b

try to run with --log debug. but the  .local/share/code-server/coder-logs/code-server-stderr.log is empty.

I'm not sure what exactly is happening there - does code-server print any logs to the terminal?

# code-server -vvv --link
[2020-12-18T18:18:12.813Z] trace child:6894 got message {"message":{"type":"handshake","args":{"_":[],"bind-addr":"<IP_ADDRESS>:8080","auth":"none","password":"xxxxx","config":"/root/.config/code-server/config.yaml","verbose":true,"link":{},"user-data-dir":"/root/.local/share/code-server","extensions-dir":"/root/.local/share/code-server/extensions","log":"trace","host":"localhost","port":0,"proxy-domain":[],"usingEnvPassword":false}}}
[2020-12-18T18:18:12.816Z] info  code-server 3.7.4 11f53784c58f68e7f4c5b3b8dae9407caa41725b
[2020-12-18T18:18:12.817Z] info  Using user-data-dir ~/.local/share/code-server
[2020-12-18T18:18:12.817Z] trace Using extensions-dir ~/.local/share/code-server/extensions
[2020-12-18T18:18:12.832Z] info  Using config file ~/.config/code-server/config.yaml
[2020-12-18T18:18:12.832Z] info  HTTP server listening on http://<IP_ADDRESS>:33663 (randomized by --link)
[2020-12-18T18:18:12.833Z] info    - Authentication is disabled (disabled by --link)
[2020-12-18T18:18:12.833Z] info    - Not serving HTTPS
[2020-12-18T18:18:12.833Z] info  Remember --link is a beta feature and requires being accepted for testing
[2020-12-18T18:18:12.833Z] info  See https://github.com/cdr/code-server/discussions/2137
[2020-12-18T18:18:12.833Z] debug running agent with bind,--code-server-addr=<IP_ADDRESS>:33663,
[2020-12-18T18:18:13.136Z] info  Proxying code-server to Coder Cloud, you can access your IDE at https://xxxx.cdr.co

It seems that there is no useful information😨😨

I have the same issue too. I'll post what I can to see if it helps
Web Browser: chrome 87
Local OS: windows 10 20H2
Remote OS: Debian 10
Remote Architecture: x86_64
code-server --version: 3.8.0 c4610f7829701aadb045d450013b84491c30580d
$ code-server -vvv --link [2020-12-30T01:39:24.491Z] trace child:4119388 got message {"message":{"type":"handshake","args":{"_":[],"password":"xxx","config":"/home/xxx/.config/code-server/config.yaml","verbose":true,"link":{},"user-data-dir":"/home/pillows/.local/share/code-server","extensions-dir":"/home/xxx/.local/share/code-server/extensions","log":"trace","auth":"none","host":"localhost","port":0,"proxy-domain":[],"usingEnvPassword":false,"usingEnvHashedPassword":false}}} [2020-12-30T01:39:24.493Z] info  code-server 3.8.0 c4610f7829701aadb045d450013b84491c30580d [2020-12-30T01:39:24.494Z] info  Using user-data-dir ~/.local/share/code-server [2020-12-30T01:39:24.494Z] trace Using extensions-dir ~/.local/share/code-server/extensions [2020-12-30T01:39:24.507Z] info  Using config file ~/.config/code-server/config.yaml [2020-12-30T01:39:24.507Z] info  HTTP server listening on http://<IP_ADDRESS>:4483 (randomized by --link) [2020-12-30T01:39:24.507Z] info    - Authentication is disabled (disabled by --link) [2020-12-30T01:39:24.507Z] info    - Not serving HTTPS (disabled by --link) [2020-12-30T01:39:24.507Z] debug running agent with bind,--code-server-addr=<IP_ADDRESS>:4483, [2020-12-30T01:39:26.937Z] info  Proxying code-server to Coder Cloud, you can access your IDE at https://xxx.cdr.co

@J3n5en actually reading back at the messages, it may be this part where we are failing "Remember --link is a beta feature and requires being accepted for testing"

I think it is still beta, but it no longer requires being accepted.

I think it is still beta, but it no longer requires being accepted.

Hi, I'm receiving the following error. Any idea about this?
!code-server --link
[2021-01-12T12:34:26.111Z] info  Wrote default config file to ~/.config/code-server/config.yaml
[2021-01-12T12:34:26.669Z] info  code-server 3.8.0 c4610f7829701aadb045d450013b84491c30580d
[2021-01-12T12:34:26.673Z] info  Using user-data-dir ~/.local/share/code-server
[2021-01-12T12:34:26.710Z] info  Using config file ~/.config/code-server/config.yaml
[2021-01-12T12:34:26.710Z] info  HTTP server listening on http://<IP_ADDRESS>:33187 (randomized by --link)
[2021-01-12T12:34:26.710Z] info    - Authentication is disabled (disabled by --link)
[2021-01-12T12:34:26.710Z] info    - Not serving HTTPS (disabled by --link)
[2021-01-12T12:34:26.726Z] info  Name must conform to regex ^[a-z][a-z0-9_]{0,50}$
[2021-01-12T12:34:26.736Z] error coder cloud agent exited with 1

Hi, I'm receiving the following error. Any idea about this?
!code-server --link
[2021-01-12T12:34:26.111Z] info  Wrote default config file to ~/.config/code-server/config.yaml
[2021-01-12T12:34:26.669Z] info  code-server 3.8.0 c4610f7829701aadb045d450013b84491c30580d
[2021-01-12T12:34:26.673Z] info  Using user-data-dir ~/.local/share/code-server
[2021-01-12T12:34:26.710Z] info  Using config file ~/.config/code-server/config.yaml
[2021-01-12T12:34:26.710Z] info  HTTP server listening on http://<IP_ADDRESS>:33187 (randomized by --link)
[2021-01-12T12:34:26.710Z] info    - Authentication is disabled (disabled by --link)
[2021-01-12T12:34:26.710Z] info    - Not serving HTTPS (disabled by --link)
[2021-01-12T12:34:26.726Z] info  Name must conform to regex ^[a-z][a-z0-9_]{0,50}$
[2021-01-12T12:34:26.736Z] error coder cloud agent exited with 1

Hi, I'm receiving the following error. Any idea about this?
!code-server --link
[2021-01-12T12:34:26.111Z] info  Wrote default config file to ~/.config/code-server/config.yaml
[2021-01-12T12:34:26.669Z] info  code-server 3.8.0 c4610f7829701aadb045d450013b84491c30580d
[2021-01-12T12:34:26.673Z] info  Using user-data-dir ~/.local/share/code-server
[2021-01-12T12:34:26.710Z] info  Using config file ~/.config/code-server/config.yaml
[2021-01-12T12:34:26.710Z] info  HTTP server listening on http://<IP_ADDRESS>:33187 (randomized by --link)
[2021-01-12T12:34:26.710Z] info    - Authentication is disabled (disabled by --link)
[2021-01-12T12:34:26.710Z] info    - Not serving HTTPS (disabled by --link)
[2021-01-12T12:34:26.726Z] info  Name must conform to regex ^[a-z][a-z0-9_]{0,50}$
[2021-01-12T12:34:26.736Z] error coder cloud agent exited with 1

@lezwon
Name must conform to regex ^[a-z][a-z0-9_]{0,50}$

You should modify your computer name to match the regular expression🤔🤔

Hi, I'm receiving the following error. Any idea about this?
!code-server --link
[2021-01-12T12:34:26.111Z] info  Wrote default config file to ~/.config/code-server/config.yaml
[2021-01-12T12:34:26.669Z] info  code-server 3.8.0 c4610f7829701aadb045d450013b84491c30580d
[2021-01-12T12:34:26.673Z] info  Using user-data-dir ~/.local/share/code-server
[2021-01-12T12:34:26.710Z] info  Using config file ~/.config/code-server/config.yaml
[2021-01-12T12:34:26.710Z] info  HTTP server listening on http://<IP_ADDRESS>:33187 (randomized by --link)
[2021-01-12T12:34:26.710Z] info    - Authentication is disabled (disabled by --link)
[2021-01-12T12:34:26.710Z] info    - Not serving HTTPS (disabled by --link)
[2021-01-12T12:34:26.726Z] info  Name must conform to regex ^[a-z][a-z0-9_]{0,50}$
[2021-01-12T12:34:26.736Z] error coder cloud agent exited with 1

@lezwon
Name must conform to regex ^[a-z][a-z0-9_]{0,50}$

You should modify your computer name to match the regular expression🤔🤔

It's in Google colab

It's in Google colab

It's in Google colab

@lezwon  try to custom instance name by
code-server --link lezwon

It's in Google colab

@lezwon  try to custom instance name by
code-server --link lezwon

@J3n5en that worked. Thanks a lot mate. 👍

@J3n5en that worked. Thanks a lot mate. 👍

Unfortunately, it didn't work for me. Is there any settings I need to change or provide any logs that can help?

It's in Google colab

@lezwon try to custom instance name by
code-server --link lezwon

i tried it on my colab but not working

Yea. it does not work for me anymore too. I'm not sure if colab is blocking tunnels.

but i tried in my linux machine then it just end up I hope developers working on it

There's a bug we're working on but for now if you access the IDE URL again it should work (the one that outputs from --link; refreshing the page shown in the screenshot won't work).

Your error should be fixed @mrfoxie

Your error should be fixed @mrfoxie.
@lezwon what sort of error message are you getting? If it's
An internal server error occurred

Would you mind pasting me the id that is returned?

still I'm facing problem

Reporting in that this still happens when using it in google colab.

Having the same issue as OP, it was working fine yesterday when I tried it, however I woke up this morning and I'm getting "Error connecting to your code-server instance" when trying to access my server. I have tried this on both DigitalOcean and GCP so I have a feeling that it's an issue with cdr.
Nothing gets printed out to the stderr log file when running --log debug. It would be nice if I could get this working as I would like to get to development on my iPad.

Actually something new, after I try and connect to the server, this doesn't happen straight away, but I eventually receive the message
[2021-02-16T09:59:22.641Z] info  2021/02/16 09:59:22 [ERR] yamux: Failed to read header: failed to get reader: failed to read frame header: EOF                                             [2021-02-16T09:59:22.645Z] info  2021-02-16 09:59:22.644 [WARN] <proxy.go:48>   code-server proxy exited      {"error": "accept tcp [::]:36221: use of closed network connection"}
Hopefully this helps :)

Just a sidenote, looking into the console when trying to connect to the page, I receive a 502 Bad Gateway error.


Update ingress-controller-troubleshoot.md

Update Troubleshooting guide to follow required ingress configuration for AGIC.

@greg-lindsay
Can you review the proposed changes?
Important: When the changes are ready for publication, adding a #sign-off comment is the best way to signal that the PR is ready for the review team to merge.
#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

@greg-lindsay did you have a chance to review?

@greg-lindsay
Can you review this old PR and determine whether it needs to be closed or merged?

#sign-off


linked and started basic css changes

updated linking of css and started basic visual changes

cancelled to update javascript


Guillermo Alvarado contribution

Please accept my contribution that respond a new feature.

Please add unit test in order to check any problem


Typo in warning message

See original issue on GitLab
In GitLab by [Gitlab user @TheRealMichaelCatanzaro] on Feb 13, 2018, 00:49
Ignored is misspelled here: WARNING Updated reference will be ingnored as source has open workspace

In GitLab by [Gitlab user @juergbi] on Feb 13, 2018, 04:50
closed via commit ecef1319bcd0e10b6ff17019cc298e2d3e5ce880

In GitLab by [Gitlab user @juergbi] on Feb 13, 2018, 04:56
mentioned in commit ecef1319bcd0e10b6ff17019cc298e2d3e5ce880


Tracking Error

How do I get errors with the GongShell. Errors come just about this library and cause crashes whole program.

Hi @apachexampp - could you provide more details? A repro would be most useful, but otherwise at least a description of the actual error would be useful.

Microsoft .NET Framework - JIT

You can not access the deleted object.
Facility Name: 'TreeView'.
in GongSolutions.Shell.ShellTreeView.RefreshItem(TreeNode node)
in GongSolutions.Shell.ShellTreeView.m_ShellListener_ItemUpdated(Object sender, ShellItemEventArgs e)
in GongSolutions.Shell.ShellNotificationListener.NotificationWindow.WndProc(Message& m)

Hmm, that doesn't tell me enough to diagnose the problem I'm afraid, and I've never seen that error before.
Could you perhaps create a minimal project that reproduces the error and upload it to GitHub?

I checked and problem is in another part of the code than the library :) Thank you for a great library and sorry for the problem.


RESTful API supports killing engine forcibly

:mag: Description
Issue References 🔗

Describe Your Solution 🔧
I'd like to introduce the feature that allows users to forcibly kill an engine through API.
Types of changes :bookmark:

[ ] Bugfix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Test Plan 🧪
Behavior Without This Pull Request :coffin:
Behavior With This Pull Request :tada:
Related Unit Tests

Checklist 📝

[x] This patch was not authored or co-authored using Generative Tooling

Be nice. Be informative.

Codecov Report
Attention: 7 lines in your changes are missing coverage. Please review.

Comparison is base (3af7551) 61.23% compared to head (da653ad) 61.07%.
Report is 27 commits behind head on master.

:exclamation: Current head da653ad differs from pull request most recent head e3476a6. Consider uploading reports for the commit e3476a6 to get more accurate results

Files
Patch %
Lines

...rg/apache/kyuubi/server/api/v1/AdminResource.scala
0.00%
6 Missing and 1 partial :warning:

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #6008      +/-   ##
============================================
- Coverage     61.23%   61.07%   -0.16%
  Complexity       23       23
============================================
  Files           622      623       +1
  Lines         36887    37072     +185
  Branches       5014     5025      +11
============================================
+ Hits          22587    22642      +55
- Misses        11869    11988     +119
- Partials       2431     2442      +11

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Done. Thanks

plz review it again @wForget

We're using Spark engine in most of time, so we would like a way to kill Spark engine forcibly thus fail to take other engines into account. Maybe I can make some improvements to support multiple engines by passing the ApplicationManagerInfo instead of Spark Info.
@turboFei

Could you plz review it again ? @turboFei

Thanks all for reviewing this pr@wForget @turboFei

I fixed UT. Plz take a look @turboFei

a little bit concern about the design, which exposed too many details to end users, let me think this weekend

How about register the app mgr into to discovery service?
https://github.com/apache/kyuubi/pull/6360/commits/4cf2852ebb2343a47c7e5a182a58832076c0255b

@turboFei @zhaohehuhu Sorry for forgetting this one, the new approach lgtm, let fix the UT the get it in.

the failed UTs are related, because this PR appends a new configuration to the engine launch command, they should be easy to debug.

Please don't forget to update the RESTful API docs.

Please don't forget to update the RESTful API docs.

Done.

the failed UTs are related, because this PR appends a new configuration to the engine launch command, they should be easy to debug.

OK. I'm looking into it

cc @turboFei, this patch now adopts your suggestions, please take a look when you have time.

would you update the AdminRestApi and CommandLine?

Thanks, merged to master


Tests now run on Linux

Fixes #53. Thanks to some fancy grep/sed and vim macros I got all the tests to run on linux fairly easily.

Codecov Report

Merging #90 into master will increase coverage by 0.31%.
The diff coverage is 100%.

@@            Coverage Diff            @@
##           master     #90      +/-   ##
=========================================
+ Coverage   95.19%   95.5%   +0.31%
=========================================
  Files          40      40
  Lines        3370    3361       -9
=========================================
+ Hits         3208    3210       +2
+ Misses        162     151      -11

Impacted Files
Coverage Δ

Tests/GuakaTests/HelpTests.swift
100% <ø> (ø)
:arrow_up:

Tests/GuakaTests/CommandTypeTest.swift
100% <ø> (ø)
:arrow_up:

Tests/GuakaTests/CommandTests.swift
77.63% <ø> (ø)
:arrow_up:

Tests/GuakaTests/ParsingTests.swift
94.48% <ø> (ø)
:arrow_up:

Tests/GuakaTests/FlagTests.swift
75.86% <ø> (ø)
:arrow_up:

Tests/GuakaTests/CommandParsingTests.swift
100% <ø> (ø)
:arrow_up:

Tests/GuakaTests/FlagsTests.swift
100% <ø> (ø)
:arrow_up:

Tests/GuakaTests/FlagHelpTests.swift
100% <ø> (ø)
:arrow_up:

Tests/GuakaTests/HelpGeneratorTests.swift
100% <ø> (ø)
:arrow_up:

Tests/GuakaTests/CommandType+Run.swift
100% <ø> (ø)
:arrow_up:

... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a1485a7...6f3de5a. Read the comment docs.

Oh that's handy! Does it add the allTests to the the test files as well? Or just the generate the LinuxMain.swift?

It generates a LinuxMain.swift and XCTestManifests.swift file that has the allTests.

This was released as part of 0.3.0.


Purpose and use of showStackError in module /config/lib/express.js

Hi folks,
A query regarding a setting in module config/lib/express.js...
Inside the function initMiddleware there is the following call:
app.set('showStackError', true);
What is the intent behind this? I suspect it is related to whether or not to show full stack traces in the client response on error, however I am puzzled as to how/where this is used. I ask this question for the following reasons:

this setting doesn't appear to be used/read anywhere else in the app. i.e. a search here in the github repository for the setting showStackError returns only a single result, i.e. where it is set. I understand from this that it is probably not intended to be 'used' by the app but rather by the express module internally;

according to the express API doc, app.set(name, value) assigns setting name to value, where name is one of the properties from the app settings table. However, I note that showStackError isn't listed in said app settings table.

I must admit, I am still learning and understanding the meanjs project so please forgive me in advance if I have misunderstood something.
Thanks for your time reading and considering this question.
Sincerely,
Dan

@danoz-direct it's an old one indeed that doesn't exist anymore.
Can you submit a PR to remove both this one and the other jsonp option that you noted in the other issue?

Resolved with #1463


Issues with zero package

Hi,
I'm trying to run the mlp.py model but I have issues with the zero package. Functions like iloader, set_randomness does not exist in the GitHub version.
Best,
Rbt

Hi, make sure that you follow these step when setting up the environment. In particular, you should have libzero==0.0.3.dev7 (see requirements.txt).

Feel free to reopen the issue if help is needed!