fix(web): remove file handling option

Removes the "File Handling" from the options menu.
This option is currently not implemented and the interface is broken. It starts as checked, but if you uncheck it, and then re-open the menu, it will be checked again. Furthermore, there does not appear to be any code that references the convertSupportedTypes parameter, so it seems like this option is not wired up to the code at all.
In #1062 @z3dev said:

I'm not sure about the elimination of the "File Handling" option. I know that it's not used but could be in the future. Also, there are other options that should be removed as well, e.g. Storage path. So, let's do these as part of another PR.

If it is implemented in the future, it is easy to restore this code. In the meantime, I strongly feel that we should NOT give users an option that is broken or unimplemented.
I am happy to also remove the "storage path" option, but wanted to keep this PR focused on the file handling.
All Submissions:

[x] Have you followed the guidelines in our Contributing document?
[x] Have you checked to ensure there aren't other open Pull Requests for the same update/change?
[x] Does your submission pass tests?

@platypii ok. Your reasoning is pretty much what I tell others as well.
let’s remove the file storage as well. It’s lame.
FYI, the file handling is for driving the IO library options. This setting should allow users to convert to JSCAD script or just geometry. But there are a lot of other options for the IO libraries, such as unit, etc. Those should be par of the choices as well. This is a far larger task, which I don’t want to take on with the current UI.

FYI, the file handling is for driving the IO library options.

@z3dev maybe we should open a ticket or a discussion to  define those options for future reference and also so I can take them in consideration during the development of the new prototype. It is better to be aware of such features in advance to better guide choices during deveompment.


Travis CI build error: bad argument

I’m not sure what’s the cause, as the message is a bit cryptic:
https://travis-ci.com/riboseinc/metanorma.com/builds/90256237
jekyll 3.8.4 | Error:  bad argument (expected URI object or URI string)
rake aborted!
Command failed with status (1): [JEKYLL_ENV=production jekyll build --confi...]
/home/travis/build/riboseinc/metanorma.com/Rakefile:65:in `block (2 levels) in <top (required)>'
/home/travis/.rvm/gems/ruby-2.5.1/gems/rake-12.3.1/exe/rake:27:in `<top (required)>'
/home/travis/.rvm/gems/ruby-2.5.1/bin/ruby_executable_hooks:24:in `eval'
/home/travis/.rvm/gems/ruby-2.5.1/bin/ruby_executable_hooks:24:in `<main>'
Tasks: TOP => test:production => build:production
(See full trace by running task with --trace)

@ronaldtse could you help or refer someone?

Latest build works on my machine as usual, but www.metanorma.com doesn’t seem to get updated after a few recent pushes

Going to try updating Rakefile with bundle exec in front of Jekyll build

Issue identified:
bundler: failed to load command: jekyll (/Users/tony/.rvm/gems/ruby-2.4.4/bin/jekyll)
ArgumentError: bad argument (expected URI object or URI string)
  /Users/tony/.rvm/rubies/ruby-2.4.4/lib/ruby/2.4.0/uri/common.rb:739:in `URI'
  /Volumes/Ribose/jekyll-theme-open-project-helpers/lib/jekyll-theme-open-project-helpers/external_links.rb:16:in `block in <top (required)>'
  /Users/tony/.rvm/gems/ruby-2.4.4/gems/jekyll-3.8.4/lib/jekyll/hooks.rb:103:in `block in trigger'
  /Users/tony/.rvm/gems/ruby-2.4.4/gems/jekyll-3.8.4/lib/jekyll/hooks.rb:102:in `each'


Documentation does not reflect new arguments for MSBot Clone Services

Is your feature request related to a problem? Please describe.
MSBot Clone Services autoprovision for ApplicationId was failing (see https://github.com/Microsoft/botbuilder-tools/issues/596). The issue was fixed with a hotfix by adding new parameters to the command line (see https://github.com/Microsoft/botbuilder-tools/pull/639).
The current readmes do not reflect these changes, they have the following command line to deploy to Azure:
msbot clone services -f deploymentScripts/msbotClone -n <BOT-NAME> -l <Azure-location> --subscriptionId <Azure-subscription-id>

Describe the solution you'd like
Steps about how to obtain the AppID and AppSecret from Application Registration Portal should be added to the readme, along with the addition of --appID and --appSecret to the command line:
msbot clone services -f deploymentScripts/msbotClone -n <BOT-NAME> -l <Azure-location> --subscriptionId <Azure-subscription-id> --appID "<App-Id>" --appSecret "<App-Secret>"

[enhancement]

Closed due to Microsoft#772


store: open check quorum default.

@ngaut @BusyJay

Any tests to make sure it works ?

no, hard to simulate now, later @tiancaiamao can add it with some strategies.

Why open this option?

if leader doesn't receive from majority, it will make a appendlog request to verify it's still leader. This can accelerate detection of some problem by avoid waiting for election timeout @BusyJay
as for tests, this PR has a dependency https://github.com/pingcap/tikv/pull/451 , while the later won't work before we fix CI https://github.com/pingcap/tikv/issues/427 @ngaut

if leader doesn't receive from majority, it will make a appendlog request to verify it's still leader.
I don't think so. It will just step down as follower in this case.
... by avoid waiting for election timeout
Actually it checks quorum after election timeout.

you're right... I verify the code  just now...
I misunderstand or that can be a bonus

Opening this is ok, if election timeout, the stale leader will try to check its whether it is still leader first, so we don't start the election again.
Etcd opens this too. /cc @xiang90

LGTM

LGTM

We were not trying to make this a fancy algorithm. Leader just simply checks if receives ANY valid append responses or heartbeat responses from the majority. If not, then it steps down. If you feel this is too aggressive, you can make it step down after 2 election timeout. If you feel this is too conservative, you can make it steps down after 1/2 election timeout. If you want to be fancy, you can make this adaptive.
For etcd, we just want to make sure the leader does step down. Without enabling this, the old leader might never step down if it is partitioned with the other nodes.

Thanks for explanation @xiang90


account assignment throwing errors in master account only where we have configured SSO service

module "sso" {
source = "../terraform-modules/sso"
permission_sets = {
  master-rtc-finance = {
  description      = "Finance Team Of RTC Access To AWS Master Account",
  session_duration = "PT8H",
  relay_state      = "https://s3.console.aws.amazon.com/s3/buckets/rtc-monthly-invoices?region=eu-central-1&tab=objects"
  inline_policy    = file("policies/finance_rtc_policy.json")
},

}
account_assignments = [
 {
  principal_name = "app_sso_aws_sinch_rtc_finance"
  principal_type = "GROUP"
  permission_set = "master-rtc-finance"
  account_ids    = ["797180668684"]
},

]
}
==============
No issues when i use the module when its trying to create the permission set at first. Issue is only when i am trying to do the account assiggnment is when im seeing this issue. This happens only when trying to create the resources in master account where i have configured the sso service
================
TERRAFORM PLAN OUTPUT
Terraform will perform the following actions:
Terraform will perform the following actions:
module.sso.aws_ssoadmin_account_assignment.this["app_sso_aws_sinch_rtc_finance.master-rtc-finance.797180668684"] will be created

resource "aws_ssoadmin_account_assignment" "this" {

id                 = (known after apply)
instance_arn       = "arn:aws:sso:::instance/ssoins-6987325f4070a778"
permission_set_arn = (known after apply)
principal_id       = "9967182253-cbe1a0b4-a479-43f6-9a0e-a8da3523e720"
principal_type     = "GROUP"
target_id          = "797180668684"
target_type        = "AWS_ACCOUNT"
}

module.sso.aws_ssoadmin_permission_set.this["master-rtc-finance"] will be created

resource "aws_ssoadmin_permission_set" "this" {

arn              = (known after apply)
created_date     = (known after apply)
description      = "Finance Team Of RTC Access To AWS Master Account"
id               = (known after apply)
instance_arn     = "arn:aws:sso:::instance/ssoins-6987325f4070a778"
name             = "master-rtc-finance"
relay_state      = "https://s3.console.aws.amazon.com/s3/buckets/rtc-monthly-invoices?region=eu-central-1&tab=objects"
session_duration = "PT8H"
tags_all         = {

"cg_iac" = "terraform"
}
}

module.sso.aws_ssoadmin_permission_set_inline_policy.this["master-rtc-finance"] will be created

resource "aws_ssoadmin_permission_set_inline_policy" "this" {

id                 = (known after apply)
inline_policy      = jsonencode(
{
+ Statement = [
+ {
+ Action   = [
+ "s3:ListBucket",
+ "s3:GetObject",
]
+ Effect   = "Allow"
+ Resource = [
+ "arn:aws:s3:::rtc-monthly-invoices",
+ "arn:aws:s3:::rtc-monthly-invoices/",
]
},
+ {
+ Action   = "s3:HeadBucket"
+ Effect   = "Allow"
+ Resource = ""
},
]
+ Version   = "2012-10-17"
}
)
instance_arn       = "arn:aws:sso:::instance/ssoins-6987325f4070a778"
permission_set_arn = (known after apply)
}

Plan: 3 to add, 0 to change, 0 to destroy.
module.sso.aws_ssoadmin_permission_set.this["master-rtc-finance"]: Creating...
module.sso.aws_ssoadmin_permission_set.this["master-rtc-finance"]: Creation complete after 1s [id=arn:aws:sso:::permissionSet/ssoins-6987325f4070a778/ps-d3d988f762fbd9d1,arn:aws:sso:::instance/ssoins-6987325f4070a778]
module.sso.aws_ssoadmin_permission_set_inline_policy.this["master-rtc-finance"]: Creating...
module.sso.aws_ssoadmin_account_assignment.this["app_sso_aws_sinch_rtc_finance.master-rtc-finance.797180668684"]: Creating...
module.sso.aws_ssoadmin_permission_set_inline_policy.this["master-rtc-finance"]: Creation complete after 6s [id=arn:aws:sso:::permissionSet/ssoins-6987325f4070a778/ps-d3d988f762fbd9d1,arn:aws:sso:::instance/ssoins-6987325f4070a778]
╷
│ Error: waiting for SSO Account Assignment for GROUP<PHONE_NUMBER>-cbe1a0b4-a479-43f6-9a0e-a8da3523e720) to be created: unexpected state 'FAILED', wanted target 'SUCCEEDED'. last error: %!s()
│
│   with module.sso.aws_ssoadmin_account_assignment.this["app_sso_aws_sinch_rtc_finance.master-rtc-finance.797180668684"],
│   on ../terraform-modules/sso/main.tf line 95, in resource "aws_ssoadmin_account_assignment" "this":
│   95: resource "aws_ssoadmin_account_assignment" "this" {

Getting this issue also. @pavankumarshambhu / @aurimasmick  any fixes? I checked in my case and I was not running into any limits

Got similar issues described above. Found out using the aws cli it was due to permission errors. It seems the management account does not use the Service principal and thus uses the role/user you are assigned with to create/list/update Saml identity providers required for the account assignment.
I've solved it by adding the following permissions to the role running terraform:
 "iam:GetSAMLProvider",
 "iam:ListSAMLProviderTags",
 "iam:ListSAMLProviders",
 "iam:TagSAMLProvider",
 "iam:UntagSAMLProvider",
 "iam:UpdateSAMLProvider",

You can see the actual error with the following commands
aws sso-admin list-account-assignment-creation-status --instance-arn arn:aws:sso:::instance/$id
aws sso-admin describe-account-assignment-creation-status --instance-arn  arn:aws:sso:::instance/$id--account-assignment-creation-request-id $request-id

@maxvandermeij thanks a lot.
those two commands shared really helped in checking which permissions were missing in the role being used by terraform.
"iam:CreateRole",
"iam:PutRolePolicy",
"iam:AttachRolePolicy",
it was missing above permissions in my case.
now im able to deploy resources through terraform in master account
command output which helped in determing it for one of the failed request id
aws sso-admin describe-account-assignment-creation-status --instance-arn  arn:aws:sso:::instance/$id--account-assignment-creation-request-id $request-id
{
"AccountAssignmentCreationStatus": {
"Status": "FAILED",
"RequestId": "3d6f474f-2267-451d-9d8c-40352a683aaa",
"FailureReason": "Received a 403 status error: Access denied by IAM. Please check your policy, or wait for role propagation to complete. IAM Error: User: arn:aws:sts:::assumed-role/SSO-Terraform-Role/terraform-aws-sso is not authorized to perform: iam:AttachRolePolicy on resource: role AWSReservedSSO_Master-Billing-Cost_2257a6c066c3e619 because no identity-based policy allows the iam:AttachRolePolicy action (Service: AmazonIdentityManagement; Status Code: 403; Error Code: AccessDenied; Request ID: 16181209-4cbe-4617-b3c6-094f96e7c31b; Proxy: null)",
"TargetId": "",
"TargetType": "AWS_ACCOUNT",
"PermissionSetArn": "arn:aws:sso:::permissionSet/ssoins-6987325f4070a778/ps-80768d1c308e5daf",
"PrincipalType": "GROUP",
"PrincipalId": "9967182253-70973ba0-162e-4d9b-a35f-1e2f2486be35",
"CreatedDate": "2023-05-23T16:10:00.135000+05:30"
}
}

Also worth mentioning that adding account assignments in the Management account requires MFA. So when using AWS cli, in the profile config (in ~/.aws/config) make sure that you have the below:
mfa_serial = arn:aws:iam::1234567890:mfa/MFA_NAME


Multi-mission radioisotope thermoelectric generator knowledge

#839

Also, the folder name has a misspelling that should be corrected.
knowledge/science/astronomy_tech/radioisotope_thermo_generator

Closing due to combined PR here:  #1142


Add build action

Try to ensure that make build-dev works all the time

Not sure if start should also be tested. I suppose testing build would be enough for the time being.
@FinnStutzenstein any opinion on this?

You should add thinks like check-formatting (analog to make run-cleanup, but just for the exit code) and call make run-tests. I'm not sure, if make run-tests currently works. We should not start it, but should build the client (make build-dev just builds the container, not the application). The prod build can be deferred to the point, where we enable prod in all services...

okay, so far we covered:

deps
lint
prettier
debug build
docker build dev

I am not entirely sure if are able to ensure that the docker container starts successfully, since it tries to keep angulars dev server up and running.

tests are now executed inside the docker container using nothing but make run-tests
should be done now

I suppose it's as good and as fast as it gets for the moment.
Unfortunately, we cannot really run the tests in parallel, since we cannot pass the docker container between the jobs. We could, however, run certain tests in parallel outside of docker. I might think about that later.


Adapting to RLLib

Hello,
Is there any way that this project gets implemented in the RLLib library?
Thanks in advance 😊

Hello,
We don't plan to implement this project in RLLib, since this implementation is mainly for educational purposes.


Evaluate volatile template bindings

🧹 Tech Debt
We need to evaluate our template bindings for conditional statements that need to be made into volatile getters.
One instance of this was found as a bug in the table and fixed (see #1839), but we need to do a more thorough evaluation of our existing bindings to see if any other ones need to be modified.
If there are only a handful of issues to be fix, this issue can cover fixing them. If there are many, we could split this into separate issues and tackle them over time.

I've dug into FAST's binding code a bit to better understand what is and is not allowed regarding volatile bindings in templates. Here are some key takeaways:

Bindings in templates are automatically inspected to determine whether or not they are volatile. A template binding is automatically considered volatile if it contains one of the following: :, &&, ||, if. See the check in FAST code which uses this regex.
Aggregate bindings are never considered volatile. Therefore, conditional statements cannot be used within them.

An aggregate binding is something of the form my-attr="foo ${x => x.bar}"

Therefore, bindings like the following will work correctly:

my-attr="${x => x.foo && x.bar}
my-attr="${x => x.foo || x.bar}
my-attr="${x => x.foo ? x.bar : x.baz}
my-attr="${x => x.foo} ${x => x.bar}"
my-attr="foo ${x => x.bar}"
my-attr="${x => ['foo', x.bar && x.baz && 'cool-value'].filter(Boolean).join(" ")}"

And bindings like the following will not work correctly:

my-attr="${x => x.foo ?? x.bar}
my-attr="foo ${x => x.bar && x.baz}
my-attr="foo ${x => x.bar || x.baz}

Aside: Looks like in the signals proposal computed signals are always "volatile" so guess that's what template bindings would be:

Computed Signals track their dependencies dynamically--each time they are run, they may end up depending on different things, and that precise dependency set is kept fresh in the Signal graph.

We talked about possibly adding CONTRIBUTING docs with guidance about setting volatile. Personally I'd be fine with closing this without docs. If we find ourselves referring back to this comment frequently then we could revisit that.


Nan::Newv8::Function Memory Leak

I just found the following memory leak. All other created v8::Value instances are handled by the active scope but this call leaks memory:
Nan::Set(obj, Nan::New<v8::String>("nativeListener").ToLocalChecked(), Nan::New<v8::Function>(PropertyUpdated));

If this line is called thousand of times many MB of memory are leaking. It seems the created function template is never freed.
PropertyUpdated is defined as NAN_METHOD(PropertyUpdated).
This is line 253 of https://github.com/cbratschi/aminogfx-gl/blob/master/src/base_js.cpp.
Is there another way to set a function reference or is this a Nan bug?

With what node.js version are you seeing that?

Node.js 4.x.

Sorry, missed your reply.  v4 is okay, older versions had some known issues w.r.t. creating functions.
It's not a nan bug but you could argue it's a V8 bug. v8::Function::New() creates new code stubs in the code space.  The code space is not frequently (sometimes never) garbage collected, making it easy to "leak" memory.
I put "leak" between scare quotes because it's not a memory leak in the traditional sense.  The memory is reclaimable except it never happens.

Is there another way to set a function reference

Instantiate it once and cache the result in a persistent handle.

That's what I already implemented as a workaround and memory consumption is now stable. It was "leaking" memory before until the app was crashing with an out of memory error.
So there is no way to free this reference by force? I can imagine situations where you need to create many dynamic callbacks which leads to memory issues especially in long running processes like Node.js apps.
I did not see any similar issues with other data types created through Nan::New() calls. And my stress test calls global.gc() every second. So in my opinion this is a bug. At least there should be a warning somewhere to strictly use (bad by design) singletons.

So there is no way to free this reference by force?

No.

I can imagine situations where you need to create many dynamic callbacks

In my experience such situations pretty much don't exist.  When you don't pass in a data argument, you're just creating the same function object over and over again, so what's the point?

And my stress test calls global.gc()

gc() doesn't sweep the code space, only data spaces.

At least there should be a warning somewhere to strictly use (bad by design) singletons.

Spare me from ideological puritanism!  I think we're open to documentation pull requests but where exactly would you put it?


Pre-installed JDKs on Hosted Agents

It would be good to see a cohesive and consistent map of pre-installed JDKs across GitHub Actions and Azure Pipelines virtual environments / hosted build agents.
As of December 2019, these are the versions installed what is default:

Azure Pipelines Image Name
Image version
Java versions installed
Default Java

Hosted Windows 2019 with VS2019
v20191009.1
1.7.0_232, 1.8.0_222, 11.0.4
1.8.0_222

Hosted VS2017
v20191009.1
1.7.0_232, 1.8.0_222, 11.0.4
1.8.0_222

Hosted Ubuntu 1804
v20191025.1
1.7.0_242, 1.8.0_232, 11.0.5, 12.0.2
12.0.2

Hosted Ubuntu 1604
v20191025.1
1.7.0_242, 1.8.0_232, 11.0.5, 12.0.2
12.0.2

Hosted macOS
macOS-10.14
1.7.0_242, 1.8.0_232, 11.0.5, 12.0.2, 13.0.1
13.0.1

Hosted macOS High Sierra
macOS-10.13
1.7.0_242, 1.8.0_232, 11.0.5, 12.0.2, 13.0.1
13.0.1

Thank you

Hello, docs for all images contain the list of installed OpenJDK:

macOS
Windows
Ubuntu

I am planning to close the issue. Please let me know if you have any concerns

@maxim-lobanov the links you provide point to bullet lists that do not provide consistent defaults. In fact, the only image that states which JDK is the default is macOS image.
Plus, images have different defaults. I know that on macOS, default is Java 8, while on Ubuntu the default is not Java 8.
I'd appreciate a better resolution than just closing this issue because there is a bullet list somewhere.

I got your point. That makes sense to put information about default versions to the docs.

I'd also very much like to see a single unique version being the default across all images. Right now, it is not consistent.
The latest LTS release is Java 11, fwiw, and a vendor-neutral build would be very much preferred, such as AdoptOpenJDK.

We have updated the information about default version of JDK. Images with new docs will be rolled out around next week.
If you want to suggest using a single unique version of JDK for all images, could you please open a separate issue for it.

Recent change to the java-tools.sh file indicates that JDK 12 is the default, but the script sets JAVA_HOME to JDK 8. Shouldn't the script set JAVA_HOME to the default JDK?
https://github.com/actions/virtual-environments/blob/0ddeb1ac4b2e81f45ba752d49ec5825b77141d40/images/linux/scripts/installers/java-tools.sh#L10
https://github.com/actions/virtual-environments/blob/0ddeb1ac4b2e81f45ba752d49ec5825b77141d40/images/linux/scripts/installers/java-tools.sh#L75

@nikita-bykov Java 12 is not LTS. We on the Java team at Microsoft strongly advise to set an LTS as the default across all agents. Currently, the latest LTS is Java 11.

Fixed default label on Ubuntu. It was my typo and thank you for your report!
As for the suggestion to set the LTS version (Java 11) as default consistently across all images, we like this suggestion but worry about regression for some customers because if we update default Java from 8 to 11, their builds could be broken.
Probably, the appropriate communication is required here. That is the reason why we would like to track this request as a separate issue.

Ok, I'll submit a new issue then. Thanks.


Mnemonic for FCVT

I noticed that FCVT can convert from float to integer or vice versa. However, I am confused about its suffix. For example, SPEC 20.7 points out

FCVT.W.S or FCVT.L.S converts a floating-point number in floating-point register rs1 to a signed 32-bit or 64-bit integer, respectively, in integer register rd. For XLEN > 32, FCVT.W[U].S sign-extends the 32-bit result to the destination register width.

When XLEN = 64, it seems that FCVT.W.S and FCVT.L.S both convert a 32-bit single-precision value to a sign-extends 64-bit integer. What's the difference between these two?

I noticed that FCVT can convert from float to integer or vice versa. However, I am confused about its suffix. For example, SPEC 20.7 points out

FCVT.W.S or FCVT.L.S converts a floating-point number in floating-point register rs1 to a signed 32-bit or 64-bit integer, respectively, in integer register rd. For XLEN > 32, FCVT.W[U].S sign-extends the 32-bit result to the destination register width.

When XLEN = 64, it seems that FCVT.W.S and FCVT.L.S both convert a 32-bit single-precision value to a sign-extends 64-bit integer. What's the difference between these two?

When XLEN=64, FCVT.W.S converts a floating-point number to a signed 32-bit integer. FCVT.L.S converts a floating-point number to a 64-bit integer without sign extension.

When XLEN=64, FCVT.W.S converts a floating-point number to a signed 32-bit integer. FCVT.L.S converts a floating-point number to a 64-bit integer without sign extension.

Thank you for your reply! Nice to see your answer again :-) In this case, what's the difference between FCVT.W.S and FCVT.LU.S?
I think I am kind of confused for the suffix S. From my understanding it means single-precision. But I noticed the following table.

It seems that FCVT.L.S valid input can be a double. If so, it can help to answer the previous quetsion: FCVT.L.S converts a double to a 64-bit integer while FCVT.W.S converts a single to 32-bit integer(or signed 64-bit integer when XLEN = 64).

Oh wait, I guess a single can cover the range from $-2^{63}$ to $2^{63} -1$. So S should be single-precision.


diff fails with clashes, missing option ignore-name-clashes

When doing a diff I get the following message:
$ drive diff
X /DSC01967.JPG "0B8VjUTiD7WpWQW8yM1JseEV6V0E"
X /DSC01927.JPG "0B8VjUTiD7WpWWm51dmJ2RTRpek0"
X /DSC01927.JPG "0B8VjUTiD7WpWZE5NMHdQVlh6aUE"
X /DSC01940.JPG "0B8VjUTiD7WpWQm9oRnRUc2JSYms"
clashes detected. use `ignore-name-clashes` to override this behavior

But if I add that option I get:
$ drive diff -ignore-name-clashes
flag provided but not defined: -ignore-name-clashes

I get no diff output, which I think is because of the clashes.

Hello @kleptog. Thank you for raising this issue and my apologies for the late reply. Fix coming up in a few.

Addressed by PR #235. Please get the latest from master.

Three hours is really quick, really.
But I'm not sure this is resolved. There is now an "ignore-conflict" option, but it's still complaining about "ignore-name-clashes" which it doesn't recognise. And I still can't diff.

Haha my bad, I hadn't looked closely at the flag name, my apologies. Re-opening and setting the flag in a second..

Please get the latest from master, and thank you for the correction :)

Can confirm that it works now. Thanks!


Final version of Readme.MD file.

Hi @PaoloPia, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!
You've already signed the contribution license agreement. Thanks!
The agreement was validated by Microsoft and real humans are currently evaluating your PR.
TTYL, MSBOT;


Ads are appearing again

Select your issue type: (check at least one)

[x] Bug
[ ] Question
[ ] Suggestion
[ ] Other (please describe):

Describe your issue:
ads are coming back ,hope you guys can fix this, :)

duplicate #115


Static mods are not loaded

If the mod class is static, it will not be scanned.

Fixed in commit d4360cc0c2452563543923da6d565331bd262c8f and release with 1.0.


Suggestion: Spells priority

about blood cast priority... right now is blood simultaneously distributed to all spells equally, even if they have different requirements
maybe add option for set priority which spell % limit fulfill first? (also good for some challenges)

usable only in some challenges

usable only in some challenges


Update Methadone example

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 82.599%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
1462

Relevant Lines:
1770

💛  - Coveralls


Sound not working on mobile device

Click me

If you click the link, you will hear sound on your PC or mobile.
However, setTimeout does not sound on mobile devices.
The same is true for functions other than click events.

Seems to be a restriction on mobile devices. They seem not to play sound if it's not triggered by click, check out this fiddle on a mobile device, only the manually opened notice will play sound: https://jsfiddle.net/zsqg3Loh/

Thank you for your quick and kind answers.


feat(chromium): add GenerateDocumentOutline option

Resolves #1043
Added the option generateDocumentOutline for chromium PDF generation. Example usage:
curl \
  --request POST http://localhost:49153/forms/chromium/convert/url \
  --form url=https://liquidlearning.vercel.app/pdf/a00Mn00000PmwksIAB \
  --form generateDocumentOutline=true \
  -o example.pdf

Here's the PDF produced when printing the Mozart Wikipedia Page

example.pdf

Key point being the outline generated on the left sidebar (firefox PDF preview):

Hey @nktnet1 👋 thanks for this well written PR!
I'll release a new version soon, but first I have to update the PHP client + the documentation 😉
In the meantime, gotenberg/gotenberg:edge should be available within ~1 hour.


Bluetooth MAC is AA:AA:AA:AA:AA:AA after bluez upgrade

Hi Lars,
I've followed your guide to upgrade bluez from 5,23 to 5.43 closely but it is not working correctly for me.
I'm on a raspberry pi 3 with the integrated bluetooth module and started out with a clean install of raspbian lite (image from January 2017).
Initially, bluez 5,23 is already installed and the bluetoothctl command shows the controller itself and discovers the nuimo just fine. Then, I carried out the bluez upgrade steps and immediately after, everything is still ok. Nuimo can be disovered etc.
However, after a "sudo reboot", bluetooth is not working anymore. The MAC address of the bluetooth controller is set to AA:AA:AA:AA:AA:AA and also the discovery is not working.
pi@raspberrypi:~ $ sudo bluetoothctl
[NEW] Controller AA:AA:AA:AA:AA:AA raspberrypi [default]

pi@raspberrypi:~ $ sudo hciconfig -a
hci0:   Type: Primary  Bus: UART
        BD Address: AA:AA:AA:AA:AA:AA  ACL MTU: 1021:8  SCO MTU: 64:1
        UP RUNNING
        RX bytes:1496 acl:0 sco:0 events:160 errors:0
        TX bytes:2624 acl:0 sco:0 commands:142 errors:0
        Features: 0xbf 0xfe 0xcf 0xfe 0xdb 0xff 0x7b 0x87
        Packet type: DM1 DM3 DM5 DH1 DH3 DH5 HV1 HV2 HV3
        Link policy: RSWITCH SNIFF
        Link mode: SLAVE ACCEPT
        Name: 'raspberrypi'
        Class: 0x000000
        Service Classes: Unspecified
        Device Class: Miscellaneous,
        HCI Version: 4.1 (0x7)  Revision: 0x0
        LMP Version: 4.1 (0x7)  Subversion: 0x2209
        Manufacturer: Broadcom Corporation (15)

I've tried this procedure twice - once on the raspbian lite and once in a volumio installation which is my actual target system.
Any hints?
Jochen

Hi Jochen,
If you follow the BlueZ upgrade steps closely, BlueZ should continue to work after a reboot. We use the the same steps on our Pi3 with Raspbian Lite.
Did you uninstall/purge BlueZ before upgrading? This can lead to your issue as uninstalling BlueZ also removes the Bluetooth driver. This said, keep the pre-installed Bluetooth packages and only run the installation steps in this readme.
Please also do a web search for "BlueZ AA:AA:AA:AA:AA" as this is a common failure symptom with BlueZ. However, as said, following the upgrade steps as per this readme should work.

We don't run sudo apt-get install --no-install-recommends bluetooth as we always install BlueZ from sources. Maybe that made the difference.

And try running again
sudo systemctl restart bluetooth
sudo hciconfig hci0 up

Hi Lars,
thanks for your quick reply on a Sunday ;-)
I read those articles related to that MAC problem but they did not help. They indicate that the base firmware of the BT module is missing or something..  very strange. It was a completely fresh installation and copy&paste of your steps. No purge or other messing with the old bluetooth stuff.
Since I had this phenomenon on two different systems (the clean raspbian lite and an older volumio with the older nuimo scripts running) I think that there is something wrong when used with the onboard bluetooth module.
However, during my fiddling I found that there is an even newer version of bluez that is just 2 days old. So, I started over and used that one and voila: everything works - both in raspbian lite and volumio. The new bluez apparently fixes something GATT-related so I'll just assume this was the cause ;-)
For reference, compared to the hciconfig snippet above, the output is exactly the same except for the MAC and the HCI version. It is now:
        HCI Version: 4.1 (0x7)  Revision: 0xb6
Cheers,
Jochen

Happy to hear that it's working – but I'm not sure if using BlueZ 5.44 fixed the issue or if it was simply the circumstance that you set up a completely fresh installation. As said, we're running our development on a Raspberry Pi 3 here with a built-in Bluetooth adapter, too. And it had worked for us quiet good so far.


Run e2e tests against an OSS release

Run e2e tests also against an OSS release and not only against ISOx

blocked : need an implementation similar to the test lsm frontend, but without the LSM part.
Might require it's own set of e2e test.


Add a file-filter option, ex: to be able to upload only *.ipa files from the specified directory

There hasn't been any activity on this issue recently. Due to the high number of incoming GitHub notifications, we have to clean some of the old issues, as many of them have already been resolved with the latest updates.
@viktorbenei  please let us know if we can help with anything and we'll reopen this issue!


[Design] New rep system interaction

Iterate the UI to provide clarity for user when they interact with the app
relate to: https://github.com/Unirep/Unirep-Social/issues/76

@vimwitch will need you to help understand the logic of subsidy epoch key

Ah the subsidy epoch key isn't really a thing. We just use the first epoch key for spending subsidy.

https://www.figma.com/file/wotPPn36lbheCaGHTlPX0N?node-id=3806:40352#261678010
touch points:

home (side widget has updated)
onboarding (msg has updated)
making a post or comment, the interaction kit has been updated
boost/squash template

@kittybest
@vimwitch if you want to have a look, much apperciated.


peer: remove unused propose_snapshot

What have you changed? (mandatory)
propose_snapshot is no longer needed since #2639 .
What are the type of the changes? (mandatory)

Improvement (non-breaking change which is an improvement to an existing feature)

How has this PR been tested? (mandatory)
No.
Does this PR affect documentation (docs) update? (mandatory)
No.
Does this PR affect tidb-ansible update? (mandatory)
No.

LGTM.


Test: Refine FrameworkSkipConditionAttribute

Simply eliminate it. Since with multiple netcoreapp tfm we need different enum.
We have 4 tests disabled by it. (without tracking issue)
One of them is blocked on coreclr issue which is already fixed. Rest 3 no clue.

Added a note to #7160


issue - When kibana is removed, the kibanaapi object can be removed with them

It's merge on main.


Manifest.category raises an error if category isn't set in manifest.

Manifest.category raises an error if category isn't set in manifest.
But, in the documentation category is defined as str or None.

Hm, that's weird. I added a test for that and it passes (https://github.com/acsone/manifestoo-core/pull/85).
Do you remember how you had that error?

I had the error at this line in my code: https://github.com/acsone/odoo-sort-manifest-depends/pull/9/files#diff-8067500c0f9c3d2a6189cd0a74c937ef50dc50639d24303f90b3dfb47f087d66R92
but it seems to be fixed :+1:


linux: cap number of in-flight io_uring SQEs

Limit the number of in-flight submission entries to the size of the completion queue. The kernel's sqpoll thread hoovers them up really fast and we may end up posting way more submissions than fit in the completion queue.
That's not fatal as such, the kernel stores them in an overflow queue that we flush eventually, but that queue can grow pretty big if the program submits lots of file operations.
Salient questions are:

Is this change a bug fix? If yes, why? If not, why not?

Is this change a (de)optimization? Is the kernel's overflow queue more or less efficient than libuv's thread pool?

This commit removes the IORING_SQ_CQ_OVERFLOW handling that was added in commit 30fc896c ("unix: handle CQ overflow in iou ring") from May 2023 because it is no longer needed.
Fixes: https://github.com/libuv/libuv/issues/4598

Is this change a bug fix? If yes, why? If not, why not?

I don't think it's a bug fix. Probably it's equally difficult for the kernel to run out of memory than the libuv run application.

Is this change a (de)optimization? Is the kernel's overflow queue more or less efficient than libuv's thread pool?

From the documentation, it seems to be a deoptimization. Whether it's better or worse than going through the threadpool... that's a different story. We may want to run some benchmarks.

@santigimeno Santi, what's the conclusion here? Merge, not merge? I'm guessing the latter?

I tend to agree. I was planning to make a PoC of the queue solution but I don't know when I'll have the time.


Formats documentation

I'm implementing the Mad-Studio formats in http://recoil.sourceforge.net
mad-studio-file-formats.pdf was very handy, thanks!
I have some doubts:

What resolution to display sprites in? (single-line vs double-line) The PDF contains the players in double-line res but the missiles in single-line.

*.mpl is defined to be fixed at 174 bytes. Does it mean the first byte is always 40?

examples/CASTLEX.AN4 doesn't conform to the format (no header).

*.tl4 - PDF says the first byte is height and the second is width. From the examples and code I believe it's the other way around.

Hello!
1.) The P/M resolution doesn't matter, because it is set after reading file into the program.
2.) No, it is not fixed anymore. It was changed after specific request, but I forgot to update docs. This value depends on the value set in field Player height, which can be set up to 40 pixels in height.
3.) This will be checked furthermore.
4.) True, you are right, it's the other way around :) My mistake (copy/paste issue)
This is the first issue request for this program. Thank you for your investigation and keep going with your great software, including useful Recoil viewer, which I use time to time.

Documentation about program formats is updated!

3.) Confirmed, this file is without header and does not conform to the standards of the program. I forgot to remove it when first package was created. So I deleted it now.

Thank you and good luck with your project!


Get old app revisions

Retrieving non-current revisions of apps through the API is a challenge because the app IDs attached to the app objects include the number of the latest revision.
This means that when using the App.get_revision() function, it tries to append the desired revision number on to the current revision number (resulting in an invalid request).
I'm not quite sure how to fix this, because the instances of App that are retrieved through api.apps.query() already come with the revision number attached, but I imagine it would not be too hard for someone who knows the ins and outs of your API wrapper, because the return values of list-all-apps-available-to-you do not include revision numbers.

Actually, it looks like it is in fact the documentation for list-all-apps-available-to-you which is wrong. Since the IDs returned by that call include the latest revision number, that would have to be stripped to provide a revision agnostic app ID.

Fixed in v0.4.3

Awesome, thx!


Review Ticket week 18

CPT Scoring
OOP Hacks
Model and Frontend Hacks
Scrum Board

1 Model
.9 View
.85 CPT


Fix alignment issues with double-wide atomics on i386

The SysV ABI defined uint64_t with 4 byte alignment on i386 — so we can’t just assume that the integer types will have the right alignment for atomics out of the box.
Emulate the original _Atomic<Width>Storage types from the old C shims even in native atomics configuration, so that they can carry a custom @_alignment attribute.
Resolves #99.
Checklist

[X] I've read the Contribution Guidelines
[X] My contributions are licensed under the Swift license.
[X] I've followed the coding style of the rest of the project.
[ ] I've added tests covering all new code paths my change adds to the project (if appropriate).
[X] I've verified that my change does not break any existing tests.
[ ] I've updated the documentation if necessary.

@swift test

@swift-ci test


Add files via upload

Removed auto reward feature and descriptions and added encouragement for developers to join Slack.

I took most of your text, but reworded it somewhat:  https://github.com/lbryio/lbry.io/commit/65b86772073f01bb8b897f4ac84631ed046a2a75
Thanks for the PR!


Password Org Reset Email Sending (web)

Functional Requirements
The web app must offer a password reset feature.
The app must send a password reset link to the organizer's email.
Non-Functional Requirements
The password reset process must adhere to security best practices.
The password reset email should be received by the user within 5 minutes.
Dependencies
Existing log-in functionality.
Supabase configuration for email services to handle password reset.
Resources
https://supabase.com/docs/guides/auth/auth-password-reset
https://supabase.com/docs/guides/auth/auth-email-templates
Set up email sending with Supabase - 3 hours

Completed


Display foils as... foils in front end?

Hello,
This issue will be use to talk about the foil effect.
As far as I know, there is no way to have a foil print image through Scryfall. I hope you can correct me. An alternative would be to rely on a foil effect in the frontend. It is quite easy to achieve and in fact this is how the website archidekt handle it. Lets implement this effect in MTGADraft!
I start working on it and the result works quite well imho:

I was thinking about something more discreet, like the old foil symbol:

What kept me from adding it until now is the need to store and send some metadata along with the booster, prompting changes in multiples places. Right now a "booster" is just a list of Arena IDs.

@Senryoku I am not sure what would be the benefit as a arena player though. I finished the implementation I will open a PR with the frontend. Feel free to ignore it for now :)

@aloisdg Did you ever open that PR?
As long as there is a foil option, I think it's very nice to show such cards it in the frontend during drafting and building on the page at least. For the area import they could be normal cards.
Otherwise it's mostly impossible to know if the option is working at all.

49c8bf53c15043518362cbe3309756254c3db23e


upgrade code base to go1.18

This updates to go 1.18 as base since some dependencies now only support go 1.18 as latest.  Updates all the dependencies.
Move to any{} over interface{}{} and updates travis
Signed-off-by: R.I.Pienaar<EMAIL_ADDRESS>

Awesome, thanks!


Update Eclipse download to 2019-06 release

Undecided on a backport for this one. Thoughts?
Closes #284

Honestly, I think a backport policy needs to be developed. Maybe even added to CONTRIBUTING.md? Clearly anything that breaks the playbook (jGRASP) must be backported. But Eclipse keeps old versions around. The last thing I want is a potentially bad Eclipse update to break student machines mid-semester. At this point, a new release is coming soon enough that I don't think a backport is necessary.

On mine, Checkstyle still registers under Window -> Preferences -> Checkstyle. Can't say it's completely functional, but it at least loaded.


parsing env vars in scripts

The code looks for env vars to start with '2729' instead of just a single '$' no matter the operating system.
resolves #42
TODO:

[x] Add documentation to README regarding parsing environment.

:+1:


docking site tool term

New term to make it easy for researchers to find all available docking site insertions
[Term]
name: docking site
namespace: experimental_tool_descriptor
def: "A docking site is an element that has been introduced into a site in the genome to allow integration of DNA at a defined location; this neutralizes the problem of position effects that are seen with non-specific insertion techniques such as transposable-element-mediated transgenesis. A docking site contains a single target site for an integrase, allowing subsequent integration of DNA into this site from a donor element via integrase mediated recombination. The docking site in the genome typically contains the 'attB' site and the donor plasmid contains the 'attP' site, since this directionality gives higher integration rates compared to the alternative combination where the 'attB' site is integrated into the genome. A docking site insertion is typically selected to be 'benign' (that is it does not result in disruption of an endogenous locus) and to show a high rate of integration in the presence of integrase." [FBC:GM, PMID:11359900, PMID:12563279, FlyBase:FBrf0194996, FlyBase:FBrf0192974]
is_a: FBcv:0005075 ! genome engineering tool
synonym: landing site
Examples
P{CaryP}	https://flybase.org/reports/FBtp0018807
M{3xP3-RFP.attP}	https://flybase.org/reports/FBtp0021844

Would we want this to cover RMCE target sites in the genome? (see FBrf0231034 Fig 10)
At the moment it does not, if this is what is desired, perhaps we should rename to 'integrase-mediated docking site' or similar and make it a subclass of 'integrase target site'. Otherwise the definition needs expanding.

Would we want this to cover RMCE target sites in the genome?

I made a separate 'RMCE target' term for the RMCE case  (FBrf0231034 Fig 10b and 10c) where a chunk of sequence is surrounded by 2 recombinase/integrase sites and can be 'swapped' with sequence from a compatible donor  - This separate term is one of the two in: https://github.com/FlyBase/flybase-controlled-vocabulary/issues/33
This "docking site" terms is meant to cover just FBrf0231034 fig10a (where there is a single integrase site).
I think that the current definition is what is wanted - I just checked Bloomington, and they have these two things as two separate lists on their https://bdsc.indiana.edu/stocks/phic31/index.html page:

"Single attP-bearing insertions for standard integration" (this is what docking site is meant to represent), which goes to https://bdsc.indiana.edu/stocks/phic31/phic31_attp.html

"Double attP-bearing insertions for integration via Recombination-Mediated Cassette Exchange (RMCE)", which goes to https://bdsc.indiana.edu/stocks/phic31/phic31_rmce.html

So I think its OK as is.


Error in Building from scratch

Hi
I ran into the following error while trying to build the project from scratch using the main branch, below are the steps to reproduce the issue.
git clone git@github.com:WildlifeDatasets/wildlife-tools.git

cd wildlife-tools
pip install -e .

Output
wildlife-tools$ pip3 install -e .
Obtaining file:///home/azureuser/workspace/eagleeyecloud/wildlife-tools
  Installing build dependencies ... done
  Checking if build backend supports build_editable ... done
  Getting requirements to build editable ... error
  error: subprocess-exited-with-error

  × Getting requirements to build editable did not run successfully.
  │ exit code: 1
  ╰─> [6 lines of output]
      running egg_info
      writing wildlife_tools.egg-info/PKG-INFO
      writing dependency_links to wildlife_tools.egg-info/dependency_links.txt
      writing requirements to wildlife_tools.egg-info/requires.txt
      writing top-level names to wildlife_tools.egg-info/top_level.txt
      error: package directory 'wildlife_tools/evaluation' does not exist
      [end of output]

  note: This error originates from a subprocess, and is likely not a problem with pip.
error: subprocess-exited-with-error

× Getting requirements to build editable did not run successfully.
│ exit code: 1
╰─> See above for output.

note: This error originates from a subprocess, and is likely not a problem with pip

It looks like the main branch is missing a folder  "wildlife_tools.evaluation",  under  wildlife-tools
Thanks
CR

Hi,
I fixed the pyproject file and it should work fine now.


Unexpected breakdown

VSCode Version: Code 1.9.0 (27240e71ef390bf2d66307e677c2a333cebf75af, 2017-02-02T08:31:00.827Z)
OS Version: Windows_NT ia32 10.0.10586
Extensions:

Extension
Author
Version

Steps to Reproduce:

Please provide more information


Blocking calls in authentication extractor

Reviewing the auth implementation, I found that blocking calls to heed were performed in the implementation of the extractor.

blocking calls are made in async contexts.
FromRequest should not return a Ready future, but a custom future, encapsulating the authentication action. a boxed future should do the trick, but it should be possible to do it more elegantly.

Fixed by #2204


iOS app shows notifications when in background but not foreground.

Issue (on iOS 9, all this works on android)
App is receiving remote notifications when not running and displaying them in notification bar. When app is in foreground it receives remote notifications but does not show the notification. When doing local notifications they show up in the notification list but it doesn't make any sounds or show the banner for a couple seconds.
For local notifications I call
FCM.presentLocalNotification({
      title: 'Local Notification Test',
      body: 'Look at that you can hit a button!',
      priority: "high",
      sound: "notification",
      auto_cancel: true,
      vibrate: 300,
      lights: true,
      show_in_foreground: true,
      local: true,
      icon: "ic_notif",
      large_icon: "ic_launcher",
      color: "#497EE3"
    });

For remote notifications I'm sending this data:
{
  "data":{
     "screen":"dev"
  },
  "notification":{
     "title":"Remote Push Notification Test",
     "body":"This has been a test of XXXXXXX's remote push notification system.",
     "screen":"dev",
     "big_text":"This has been a test of XXXXXXX's remote push notification system.",
     "icon":"ic_notif",
     "largeIcon":"ic_notif_launcher",
     "click_action":null,
     "color":"#497EE3",
     "vibrate":300,
     "sound":"notification",
     "priority":"High",
     "badge":0
  },
  "registration_ids":[
     "XXXXXXXXXXX",
     "XXXXXXXXXXX"
  ]
}

my notification listener
this.notificationListener = FCM.on(FCMEvent.Notification, async (notif) => {
      console.log('we got a push notification!', notif);
      if(notif.local_notification){
        // this is a local notification
        // we aren't doing these yet, but actions can be triggered from here eventually
      } else if(notif.opened_from_tray){
        // app is open/resumed because user clicked banner
        const fun = NavigationActions[notif.screen];
        if(typeof fun === 'function') {
          eval(fun({ type: ActionConst.RESET }));
        }
      }

      if(Platform.OS ==='ios') {
        switch(notif._notificationType){
          case NotificationType.Remote:
            // other types available: RemoteNotificationResult.NewData, RemoteNotificationResult.ResultFailed
            notif.finish(RemoteNotificationResult.NewData)
            break;
          case NotificationType.NotificationResponse:
            notif.finish();
            break;
          case NotificationType.WillPresent:
            // other types available: WillPresentNotificationResult.None
            notif.finish(WillPresentNotificationResult.All)
            break;
        }
      }
    });

What version of RN and react-native-fcm are you running?
"react-native": "0.40.0",
"react-native-fcm": "9.1.0"
What device are you using? (e.g iOS9 emulator, Android 6 device)?
iOS 9 iPod touch
Is your app running in foreground, background or not running?
foreground
Advanced:
Have you tried adding break point in native handlers to see if message gets delivered?
can share a project with issue?
Yes, FCM.on(FCMEvent.Notification, async (notif) => console.log(notif)) always prints received notifications.
Am I missing something? I know I'm super close I just don't know what to try next to debug this issue.

iOS9 doesn't support showing notification when app is foreground. It starts from iOS 10
sound: "notification" try file name? like notification.mp3

@evollu

iOS9 doesn't support showing notification when app is foreground
Shouldn't the remote notifications at least show up in the notifications list? The local ones do.

right I'm afraid that's system limitation.
There are many stackoverflow questions already like this
https://stackoverflow.com/questions/30852870/displaying-a-stock-ios-notification-banner-when-your-app-is-open-and-in-the-fore

iPhone6: iOS:11.4 app shows notifications when in background but not foreground. :/ have been trying for 2 days


Book: Fix typos of MessagePack format name in the "Record" page

This PR fixes 4 typos of MessagePack format name in the "Record" page of the Book.
By the way, thank you for the great work :)
Pull Request Template
Checklist

[ ] Confirmed that run-checks all script has been executed.
I got several errors from burn-* crates, which stopped the script execution before all checks run, but I didn't touch those crates, and these errors occurred even when I run the checks against the "main" branch.
Could you please tell me if it's fine to ignore them or there are some workaround to finish all the checks despite the errors?

[x] Made sure the book is up to date with changes in this PR.

Related Issues/PRs
None.
Changes

Problem:
In the "Record" page, there are 4 places where "Pack" is written as "Park."
Solution:
Changing "Park" to "Pack".
Also, since the official name of the format is in CamelCase, I removed the spaces and captialized the two words in the last place. If the spaces and lowercases are used intentionally, please let me know.

Testing
cargo xtask books burn open

You are welcome. I'm glad I could help :)


[WIP] UI and Styling Improvements

Tasks / Notes

[x] css scrollbar styling (vertical): https://gist.github.com/natterstefan/d294080bd0dee372cca03a81fa5c25c9
[ ] fix css that causes horizontal scrollbar to stop at 240px (remove/refactor this: https://d.pr/i/8TMgQC/oWBD8tZly6)
[ ] MuiDrawer-docked-98: has 100% height (full height of the screen) + border (https://d.pr/i/LxVFkA/xzCDNLIj9r)

Coverage remained the same at 83.961% when pulling 325a14d405db3e62ddb27456c2020c20e529782d on feature/css-styling-adjustments into 52bc7e6675bb064f69497dac23cff3c7bf86ecce on master.


add support and tests for ejsvm emitFreeLogs option - Used for debug

Hey guys, some tools for debugging and creating coverage reports of contracts relay on adding events before compiling and testing, this approach was proven to work on the solidity-coverage project https://github.com/sc-forks/solidity-coverage
By doing this, they elevate the cost of all the calls, and they can't cover views and pure functions, because the EVM will throw when those functions try to emit an event.
The "emitFreeLogs" option allows instantiating an EVM instance without this limitation, enabling any contract to emit an unlimited quantity of events without modifying the block gas limit, and also to emit events during STATICCALLS.
In ethereumjs-vm was merged this parameter. see (https://github.com/ethereumjs/ethereumjs-vm/pull/378).
Related:
sc-forks/solidity-coverage#234
OpenZeppelin/openzeppelin-solidity#876 (comment)

Is there anything blocking this? ethereumjs-vm has supported emitFreeLogs since v2.5.0 (v3.0.0 was released a couple days ago), and we need ganache-core to expose this option so that the cli can enable it.

Closing due to significant conflicts due this PR's age. Sorry about this! I've opened an issue for the feature and referenced this PR:


allow multiple operations per file

It seems that decoupling require a duplication as far as this two function are heavily coupled)
My PR is some kind of a quick fix)
Lately the generator will require a little bit refactoring)


Migrate to new repository

We decided that we will create a separate repository for the new sphinx based webpage at https://github.com/fortran-lang/webpage. This allows to keep this repository and maybe also the current page at https://old.fortran-lang.org or similar.
We expect to make the new page the default latest by end of August 2022.

We plan to finish the migration by end of next week. Next step is to add a banner to the current page to make visitors aware of the upcoming migration.
Once we migrated to the sphinx based webpage this repository will be available at the default GH pages URL https://fortran-lang.github.io/fortran-lang.org and we will create a banner on the new webpage referencing the old repository in case somebody finds something missing.

Sorry, have been on vacation until yesterday. I'll have a look into finishing the migration tomorrow, since this is still August we are just perfectly in time ;).

Migration should be done now


Clean up code a bit and add some tests

Cleaned up the code a bit by extracting functions. I've noticed you've done some cleaning up in the main repo too in the meantime.
I've added a few tests for some of the extracted methods; no integration/system tests for Flask yet.
Would be good to check that the refactoring still has the same functionality. As far as I can tell all should be good to go.

Thanks @jslvtr i will give this a test today! Sorry about the messy code ha...

TypeError: get_payee_details_for_transaction() takes exactly 2 arguments (1 given)

How do you test this locally by the way?

@jslvtr I use foreman start which runs the Procfile. But you can just copy the web command from the Procfile and run that 👍
I then have a webhook body from Monzo (you can get this by adding a requestb.in as a webhook URL to Monzo) which I post with Postman.

@jslvtr there is a Python version of Foreman that may be more useful for you https://github.com/nickstenning/honcho
So that will run the Procfile. This will be more useful once we add background workers in etc.

That's a good one, thanks for that!

@jslvtr other than those error codes, this looks good :)

@scottrobertson all fixed up! I'll try it out locally when I get the webhook body. Need to go to the shops 😂

@jslvtr you can use Stripe :) Charge £1, and the refunds process instantly too :D

@jslvtr merged. What is the best way to run these tests?

Awesome @scottrobertson ! I've been running them with python -m unittest tests.unit.test_main.

@jslvtr i am getting:
Traceback (most recent call last):
  File "/usr/local/Cellar/python/2.7.13/Frameworks/Python.framework/Versions/2.7/lib/python2.7/runpy.py", line 174, in _run_module_as_main
    "__main__", fname, loader, pkg_name)
  File "/usr/local/Cellar/python/2.7.13/Frameworks/Python.framework/Versions/2.7/lib/python2.7/runpy.py", line 72, in _run_code
    exec code in run_globals
  File "/usr/local/Cellar/python/2.7.13/Frameworks/Python.framework/Versions/2.7/lib/python2.7/unittest/__main__.py", line 12, in <module>
    main(module=None)
  File "/usr/local/Cellar/python/2.7.13/Frameworks/Python.framework/Versions/2.7/lib/python2.7/unittest/main.py", line 94, in __init__
    self.parseArgs(argv)
  File "/usr/local/Cellar/python/2.7.13/Frameworks/Python.framework/Versions/2.7/lib/python2.7/unittest/main.py", line 149, in parseArgs
    self.createTests()
  File "/usr/local/Cellar/python/2.7.13/Frameworks/Python.framework/Versions/2.7/lib/python2.7/unittest/main.py", line 158, in createTests
    self.module)
  File "/usr/local/Cellar/python/2.7.13/Frameworks/Python.framework/Versions/2.7/lib/python2.7/unittest/loader.py", line 130, in loadTestsFromNames
    suites = [self.loadTestsFromName(name, module) for name in names]
  File "/usr/local/Cellar/python/2.7.13/Frameworks/Python.framework/Versions/2.7/lib/python2.7/unittest/loader.py", line 100, in loadTestsFromName
    parent, obj = obj, getattr(obj, part)
AttributeError: 'module' object has no attribute ''

@scottrobertson that's a bit strange. Seems to work here :/

Ah, i copied the trailing .. Never mind...


Background and foreground app is breaking event listeners

I am trying to use react-native-notifications with react-native-navigation on Android device
When app is foreground, everything works fine
When app goes to background for first time, still everything works fine.
However, when app comes back to foreground from background , its breaking all the event listeners related to notification
After that onNotificationReceived, onNotificationOpened doesn't get call.
I am adding listeners  on my top level component just before creating Navigation

Did you fix this? I'm having the same problem :(


Built-in animation support?

With lifecycle events going away #717, what options do we have to animate elements and can Hyperapp offer declarative animation hooks out of the box to help library authors?

I'm not expecting to have anything else except Hyperapp when using import { h, app } from 'hyperapp'. And I'm not using animation on a daily-basis so I don't think it should be built-in. But I'm eager to listening to others' opinions.

I think it's not a priority. In my opinion, we should keep the library as simple as possible and animation should be handled by other libraries, including the entire process.

I think to pull off declarative animations, we need hooks into the patching cycle, so we can see the DOM before & after (at an arbirtrary VNode, not just the whole tree).
React has getSnapshotBeforeUpdate and componentDidUpdate, which enabled this new library to do really nice FLIP animations (albeit with somewhat complex code):  https://github.com/aholachek/react-flip-toolkit
snabbdom's "hero" module is another example which is enabled by exposing those before/after-patch hooks.
@jorgebucaran Were you thinking of something higher-level?

@SkaterDad

Remove lifecycle events and follow the footsteps of Elm's elm-style-animation package. Another option (that does not conflict with the aforementioned state-first only solution) is an animation library based on mutation observers is another option.

Expose a declarative, higher level API that uses our current lifecycle events under the hood. We can use popmotion/pose for inspiration. This path does not conflict with either of the options suggested above.

I want to proceed with (1), but also interested in how (2) could look like.

Something like @zaceno's hyperapp-transitions API { Enter, Exit, Move } sounds like a good place to start perhaps for (2).

I tossed @hyperapp/transitions into a pot with MutationObserver and customElements, and let it all boil together into a framework agnostic custom element: <transition-group> with a similar behavior as the <transition> tag of Vue.js.
The implementation is definitely not elegant by any means (marrying the contorsions of @hyperapp/transitions with the cludgy lifecycle-hook-emulation of mutation observers). It's probably the least fun programming I've had in a long time. But it works.
Here are the examples from @hyperapp/transitions ported to use my <transition-group> instead:

Carousel
15-Puzzle
Toasts

And here's the codepen with the "implementation" 🤢 : https://codepen.io/zaceno/pen/qKwXXK?editors=0010
Unfortunately we can't have the nice {Enter, Exit, Move} API this way, because all transitions applying to an element all need to be handled by the same MutationObserver.

@zaceno Thank you, for putting that together. 🙇
First implementations are never as fun as later ones!

Built-in animation support in Hyperapp is out of the question for the foreseeable future but never say never. We may get back to this idea again someday.


Website: Allow for comparison of two certificates

It would be nice to have an option to select two certificates for comparison. The differences and similarities of the certificates could be visually displayed to the user.

Done for CC.

Now also for FIPS.


remove duplicate array in redirect_from directive

This PR fixes a build failure I saw locally with the latest version of github-pages.
  Liquid Exception: undefined method `end_with?' for ["/cs-engine/release-notes/prior-release-notes/"]:Array in 404.md
  bundler: failed to load command: jekyll (/Users/parkr/.rbenv/versions/2.3.1/lib/ruby/gems/2.3.0/bin/jekyll)
  NoMethodError: undefined method `end_with?' for ["/cs-engine/release-notes/prior-release-notes/"]:Array

Goodness gracious, @parkr is opening a PR against our docs! Welcome, we are big fans of Jekyll around here. While I have you: Bump Rouge to 2.0! @jneen added Dockerfile lexer support! :)
Okay, the toc.yaml change looks great.
The problem with pinning to GH-Pages 121, however, is that we are using starefossen/github-pages to synchronize our Dockerfile's GH-Pages environment and the Gemfile's GH-Pages environment, and the latest versions-specific tag on that repo is 112:

https://hub.docker.com/r/starefossen/github-pages/tags/
https://github.com/docker/docker.github.io/blob/docs-base/Dockerfile
https://github.com/docker/docker.github.io/blob/master/Gemfile

If there's a better way to get Dockerized GitHub Pages then I'd love to use the latest, but I'm nervous of having the production environment (specified in the Dockerfile) lose sync with Gemfile we are using to author locally, set up staging on Netlify, etc.
Long story -- the TL;DR is would you mind backing out your Gemfile change?

Bump Rouge to 2.0! @jneen added Dockerfile lexer support! :)

Haha, we have it filed (https://github.com/jekyll/jekyll/issues/5556) but we hit a bit of a compatibility roadblock under SemVer: https://github.com/jekyll/jekyll/pull/5230#issuecomment-258889736

we are using starefossen/github-pages to synchronize our Dockerfile's GH-Pages environment and the Gemfile's GH-Pages environment, and the latest versions-specific tag on that repo is 112

Perhaps we can work together to automatically release a new version whenever we push a new Release to github/pages-gem. I'll open an issue.

Long story -- the TL;DR is would you mind backing out your Gemfile change?

Happy to! I will remove the commit. 👍

@parkr I would love to work with you on Dockerizing GitHub Pages. We're pretty good at crafting Docker files here. ;)

@parkr Let me know when your issue is opened.


Error occured in NfcPlugin.java

hi, i follow all the steps to install the plugin but it happens that there is some errors occur in NfcPlugin.java. Error says that : the method sendJavascript(String) from the type CordovaWebView is deprecated. What does it mean? Sorry i'm just a newbie. I'm doing this for my FYP. Urgent to solve this problem.How to solve this? I'm using cordova 4.3.0.
Steps i have done to install nfc plugin in my project:
cordova create nfc com.example.nfc NFC
cd nfc
cordova platform add android
cordova plugin add com.chariotsolutions.nfc.plugin
cordova build
This is the error after open in eclipse:

That deprecation method is a warning, not an error. The deprecated messages means that sendJavascript will be removed in a future version of Cordova. You can safely ignore the warning and your app will work fine.

Ya..you are right. I just run it and it is fine. Thanks for your fast reply!


Bump go.mau.fi/whatsmeow

Resolves bugs #2175 and #2178, where the WhatsApp version was not up to date, causing a 405 error.
I have bumped the whatsmeow library by one version. Some minor capitalisation changes were introduced. More recent whatsmeow versions introduce breaking changes, so this (v0.0.0-20240625083845-6acab596dd8c) is a first step which fixes the bug.

Thanks @IntGrah but I've just created https://github.com/42wim/matterbridge/pull/2180 which contains this and some other dependencies. Feel free to test it, I'm going to close this.