unable to point node-gyp to python

this issue is caused by installing anaconda (which uses 3.5.3) over the weekend and then trying to build today. if you have a fix where i do not have to manually switch versions or uninstall anaconda that would be super helpful

Node Version:
v8.4.0
Platform:
Darwin Michaels-MacBook-Pro-2.local 16.7.0 Darwin Kernel Version 16.7.0: Thu Jun 15 17:36:27 PDT 2017; root:xnu-3789.70.16~2/RELEASE_X86_64 x86_64
Compiler:
Apple LLVM version 8.1.0 (clang-802.0.42)
Target: x86_64-apple-darwin16.7.0
Thread model: posix
InstalledDir: /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin
Module:
nsfw

Verbose output (from npm or node-gyp):

0 info it worked if it ends with ok
1 verbose cli [ '/usr/local/Cellar/node/8.4.0/bin/node',
1 verbose cli   '/usr/local/bin/npm',
1 verbose cli   'run',
1 verbose cli   'release' ]
2 info using<EMAIL_ADDRESS>3 info using<EMAIL_ADDRESS>4 verbose run-script [ 'prerelease', 'release', 'postrelease' ]
5 info lifecycle<EMAIL_ADDRESS><EMAIL_ADDRESS>6 verbose lifecycle<EMAIL_ADDRESS>unsafe-perm in lifecycle true
7 verbose lifecycle<EMAIL_ADDRESS>PATH: /usr/local/lib/node_modules/npm/bin/node-gyp-bin:/Users/michaelmclaughlin/Sites/specless/cloud-compiler/sync/node_modules/.bin:/Users/michaelmclaughlin/anaconda/bin:/Users/michaelmclaughlin/.rvm/gems/ruby-2.2.3/bin:/Users/michaelmclaughlin/.rvm/gems/ruby-2.2.3@global/bin:/Users/michaelmclaughlin/.rvm/rubies/ruby-2.2.3/bin:/Library/Frameworks/Python.framework/Versions/3.6/bin:~/Library/Python/2.7/bin:/opt/local/bin:/opt/local/sbin:/opt/local/bin:/opt/local/sbin:/Users/michaelmclaughlin/.npm-global/bin:/Users/michaelmclaughlin/google-cloud-sdk/bin:/usr/local/bin:/usr/bin:/bin:/usr/sbin:/sbin:/opt/X11/bin:/usr/local/go/bin:/Users/michaelmclaughlin/bin:/usr/local/mongodb/bin:/usr/local/mysql/bin:/usr/local/bin:/Users/michaelmclaughlin/.rvm/bin
8 verbose lifecycle<EMAIL_ADDRESS>CWD: /Users/michaelmclaughlin/Sites/specless/cloud-compiler/sync
9 silly lifecycle<EMAIL_ADDRESS>Args: [ '-c', 'git push && gulp build --env=production' ]
10 silly lifecycle<EMAIL_ADDRESS>Returned: code: 0  signal: null
11 info lifecycle<EMAIL_ADDRESS><EMAIL_ADDRESS>12 verbose lifecycle<EMAIL_ADDRESS>unsafe-perm in lifecycle true
13 verbose lifecycle<EMAIL_ADDRESS>PATH: /usr/local/lib/node_modules/npm/bin/node-gyp-bin:/Users/michaelmclaughlin/Sites/specless/cloud-compiler/sync/node_modules/.bin:/Users/michaelmclaughlin/anaconda/bin:/Users/michaelmclaughlin/.rvm/gems/ruby-2.2.3/bin:/Users/michaelmclaughlin/.rvm/gems/ruby-2.2.3@global/bin:/Users/michaelmclaughlin/.rvm/rubies/ruby-2.2.3/bin:/Library/Frameworks/Python.framework/Versions/3.6/bin:~/Library/Python/2.7/bin:/opt/local/bin:/opt/local/sbin:/opt/local/bin:/opt/local/sbin:/Users/michaelmclaughlin/.npm-global/bin:/Users/michaelmclaughlin/google-cloud-sdk/bin:/usr/local/bin:/usr/bin:/bin:/usr/sbin:/sbin:/opt/X11/bin:/usr/local/go/bin:/Users/michaelmclaughlin/bin:/usr/local/mongodb/bin:/usr/local/mysql/bin:/usr/local/bin:/Users/michaelmclaughlin/.rvm/bin
14 verbose lifecycle<EMAIL_ADDRESS>CWD: /Users/michaelmclaughlin/Sites/specless/cloud-compiler/sync
15 silly lifecycle<EMAIL_ADDRESS>Args: [ '-c',
15 silly lifecycle   'git push && GH_TOKEN="CORRECT_TOKEN_HERE" build' ]
16 silly lifecycle<EMAIL_ADDRESS>Returned: code: 255  signal: null
17 info lifecycle<EMAIL_ADDRESS>Failed to exec release script
18 verbose stack Error<EMAIL_ADDRESS>release: `git push && GH_TOKEN="CORRECT_TOKEN_HERE" build`
18 verbose stack Exit status 255
18 verbose stack     at EventEmitter.<anonymous> (/usr/local/lib/node_modules/npm/lib/utils/lifecycle.js:289:16)
18 verbose stack     at emitTwo (events.js:125:13)
18 verbose stack     at EventEmitter.emit (events.js:213:7)
18 verbose stack     at ChildProcess.<anonymous> (/usr/local/lib/node_modules/npm/lib/utils/spawn.js:40:14)
18 verbose stack     at emitTwo (events.js:125:13)
18 verbose stack     at ChildProcess.emit (events.js:213:7)
18 verbose stack     at maybeClose (internal/child_process.js:927:16)
18 verbose stack     at Process.ChildProcess._handle.onexit (internal/child_process.js:211:5)
19 verbose pkgid<EMAIL_ADDRESS>20 verbose cwd /Users/michaelmclaughlin/Sites/specless/cloud-compiler/sync
21 verbose Darwin 16.7.0
22 verbose argv "/usr/local/Cellar/node/8.4.0/bin/node" "/usr/local/bin/npm" "run" "release"
23 verbose node v8.4.0
24 verbose npm  v5.3.0
25 error code ELIFECYCLE
26 error errno 255
27 error<EMAIL_ADDRESS>release: `git push && GH_TOKEN="CORRECT_TOKEN_HERE" build`
27 error Exit status 255
28 error Failed at the<EMAIL_ADDRESS>release script.
28 error This is probably not a problem with npm. There is likely additional logging output above.
29 verbose exit [ 255, true ]

TRACE

Everything up-to-date
Rebuilding native production dependencies for darwin:x64
Error: /usr/local/Cellar/node/8.4.0/bin/node exited with code 1
Output:

><EMAIL_ADDRESS>install /Users/michaelmclaughlin/Sites/specless/cloud-compiler/sync/node_modules/nsfw
> PYTHON="/Users/michaelmclaughlin/Library/Python/2.7/bin" node-gyp rebuild --python /Users/michaelmclaughlin/Library/Python/2.7/bin

Error output:
gyp ERR! configure error
gyp ERR! stack Error: Can't find Python executable "/Users/michaelmclaughlin/Library/Python/2.7/bin", you can set the PYTHON env variable.
gyp ERR! stack     at PythonFinder.failNoPython (/usr/local/lib/node_modules/npm/node_modules/node-gyp/lib/configure.js:483:19)
gyp ERR! stack     at PythonFinder.<anonymous> (/usr/local/lib/node_modules/npm/node_modules/node-gyp/lib/configure.js:397:16)
gyp ERR! stack     at F (/usr/local/lib/node_modules/npm/node_modules/which/which.js:68:16)
gyp ERR! stack     at E (/usr/local/lib/node_modules/npm/node_modules/which/which.js:80:29)
gyp ERR! stack     at /usr/local/lib/node_modules/npm/node_modules/which/which.js:89:16
gyp ERR! stack     at /usr/local/lib/node_modules/npm/node_modules/which/node_modules/isexe/index.js:42:5
gyp ERR! stack     at /usr/local/lib/node_modules/npm/node_modules/which/node_modules/isexe/mode.js:8:5
gyp ERR! stack     at FSReqWrap.oncomplete (fs.js:153:5)
gyp ERR! System Darwin 16.7.0
gyp ERR! command "/usr/local/Cellar/node/8.4.0/bin/node" "/usr/local/lib/node_modules/npm/node_modules/node-gyp/bin/node-gyp.js" "rebuild" "--python" "/Users/michaelmclaughlin/Library/Python/2.7/bin"
gyp ERR! cwd /Users/michaelmclaughlin/Sites/specless/cloud-compiler/sync/node_modules/nsfw
gyp ERR! node -v v8.4.0
gyp ERR! node-gyp -v v3.6.2
gyp ERR! not ok
npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR<EMAIL_ADDRESS>install: `PYTHON="/Users/michaelmclaughlin/Library/Python/2.7/bin" node-gyp rebuild --python /Users/michaelmclaughlin/Library/Python/2.7/bin`
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>install script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

npm ERR!      /Users/michaelmclaughlin/.npm/_logs/2017-09-19T00_19_37_058Z-debug.log

    at ChildProcess.childProcess.once.code (/Users/michaelmclaughlin/Sites/specless/cloud-compiler/sync/node_modules/electron-builder-util/src/util.ts:135:14)
    at Object.onceWrapper (events.js:318:30)
    at emitTwo (events.js:125:13)
    at ChildProcess.emit (events.js:213:7)
    at maybeClose (internal/child_process.js:927:16)
    at Socket.stream.socket.on (internal/child_process.js:348:11)
    at emitOne (events.js:115:13)
    at Socket.emit (events.js:210:7)
    at Pipe._handle.close [as _onclose] (net.js:545:12)
From previous event:
    at spawn (/Users/michaelmclaughlin/Sites/specless/cloud-compiler/sync/node_modules/electron-builder-util/src/util.ts:103:3)
    at /Users/michaelmclaughlin/Sites/specless/cloud-compiler/sync/node_modules/electron-builder/src/yarn.ts:135:5
From previous event:
    at rebuild (/Users/michaelmclaughlin/Sites/specless/cloud-compiler/sync/node_modules/electron-builder/out/yarn.js:93:22)
    at /Users/michaelmclaughlin/Sites/specless/cloud-compiler/sync/node_modules/electron-builder/src/yarn.ts:16:11
    at Generator.next (<anonymous>)
    at runCallback (timers.js:781:20)
    at tryOnImmediate (timers.js:743:5)
    at processImmediate [as _immediateCallback] (timers.js:714:5)
From previous event:
    at installOrRebuild (/Users/michaelmclaughlin/Sites/specless/cloud-compiler/sync/node_modules/electron-builder/out/yarn.js:33:21)
    at /Users/michaelmclaughlin/Sites/specless/cloud-compiler/sync/node_modules/electron-builder/src/packager.ts:404:13
    at Generator.next (<anonymous>)
From previous event:
    at Packager.installAppDependencies (/Users/michaelmclaughlin/Sites/specless/cloud-compiler/sync/node_modules/electron-builder/out/packager.js:486:11)
    at /Users/michaelmclaughlin/Sites/specless/cloud-compiler/sync/node_modules/electron-builder/src/packager.ts:231:20
    at Generator.next (<anonymous>)
From previous event:
    at Packager.doBuild (/Users/michaelmclaughlin/Sites/specless/cloud-compiler/sync/node_modules/electron-builder/out/packager.js:379:11)
    at /Users/michaelmclaughlin/Sites/specless/cloud-compiler/sync/node_modules/electron-builder/src/packager.ts:170:52
    at Generator.next (<anonymous>)
    at runCallback (timers.js:781:20)
    at tryOnImmediate (timers.js:743:5)
    at processImmediate [as _immediateCallback] (timers.js:714:5)
From previous event:
    at Packager.build (/Users/michaelmclaughlin/Sites/specless/cloud-compiler/sync/node_modules/electron-builder/out/packager.js:274:11)
    at /Users/michaelmclaughlin/Sites/specless/cloud-compiler/sync/node_modules/electron-builder/src/builder.ts:198:33
    at Generator.next (<anonymous>)
From previous event:
    at build (/Users/michaelmclaughlin/Sites/specless/cloud-compiler/sync/node_modules/electron-builder/out/builder.js:70:21)
    at Object.<anonymous> (/Users/michaelmclaughlin/Sites/specless/cloud-compiler/sync/node_modules/electron-builder/out/cli/build-cli.js:71:41)
    at Module._compile (module.js:573:30)
    at Object.Module._extensions..js (module.js:584:10)
    at Module.load (module.js:507:32)
    at tryModuleLoad (module.js:470:12)
    at Function.Module._load (module.js:462:3)
    at Function.Module.runMain (module.js:609:10)
    at startup (bootstrap_node.js:158:16)
    at bootstrap_node.js:598:3

BEFORE I TRIED TO FIX BY PASSING ENV VAR AND FLAG

Error: /usr/local/Cellar/node/8.4.0/bin/node exited with code 1
Output:

><EMAIL_ADDRESS>install /Users/michaelmclaughlin/Sites/specless/cloud-compiler/sync/node_modules/nsfw
> node-gyp rebuild

Error output:
gyp ERR! configure error
gyp ERR! stack Error: Python executable "/Users/michaelmclaughlin/anaconda/bin/python" is v3.5.3, which is not supported by gyp.
gyp ERR! stack You can pass the --python switch to point to Python >= v2.5.0 & < 3.0.0.
gyp ERR! stack     at PythonFinder.failPythonVersion (/usr/local/lib/node_modules/npm/node_modules/node-gyp/lib/configure.js:492:19)
gyp ERR! stack     at PythonFinder.<anonymous> (/usr/local/lib/node_modules/npm/node_modules/node-gyp/lib/configure.js:474:14)
gyp ERR! stack     at ChildProcess.exithandler (child_process.js:262:7)
gyp ERR! stack     at emitTwo (events.js:125:13)
gyp ERR! stack     at ChildProcess.emit (events.js:213:7)
gyp ERR! stack     at maybeClose (internal/child_process.js:927:16)
gyp ERR! stack     at Socket.stream.socket.on (internal/child_process.js:348:11)
gyp ERR! stack     at emitOne (events.js:115:13)
gyp ERR! stack     at Socket.emit (events.js:210:7)
gyp ERR! stack     at Pipe._handle.close [as _onclose] (net.js:545:12)
gyp ERR! System Darwin 16.7.0
gyp ERR! command "/usr/local/Cellar/node/8.4.0/bin/node" "/usr/local/lib/node_modules/npm/node_modules/node-gyp/bin/node-gyp.js" "rebuild"
gyp ERR! cwd /Users/michaelmclaughlin/Sites/specless/cloud-compiler/sync/node_modules/nsfw
gyp ERR! node -v v8.4.0
gyp ERR! node-gyp -v v3.6.2
gyp ERR! not ok
npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR<EMAIL_ADDRESS>install: `node-gyp rebuild`
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>install script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

npm ERR!      /Users/michaelmclaughlin/.npm/_logs/2017-09-19T00_24_56_847Z-debug.log

    at ChildProcess.childProcess.once.code (/Users/michaelmclaughlin/Sites/specless/cloud-compiler/sync/node_modules/electron-builder-util/src/util.ts:135:14)
    at Object.onceWrapper (events.js:318:30)
    at emitTwo (events.js:125:13)
    at ChildProcess.emit (events.js:213:7)
    at maybeClose (internal/child_process.js:927:16)
    at Socket.stream.socket.on (internal/child_process.js:348:11)
    at emitOne (events.js:115:13)
    at Socket.emit (events.js:210:7)
    at Pipe._handle.close [as _onclose] (net.js:545:12)
From previous event:
    at spawn (/Users/michaelmclaughlin/Sites/specless/cloud-compiler/sync/node_modules/electron-builder-util/src/util.ts:103:3)
    at /Users/michaelmclaughlin/Sites/specless/cloud-compiler/sync/node_modules/electron-builder/src/yarn.ts:135:5
From previous event:
    at rebuild (/Users/michaelmclaughlin/Sites/specless/cloud-compiler/sync/node_modules/electron-builder/out/yarn.js:93:22)
    at /Users/michaelmclaughlin/Sites/specless/cloud-compiler/sync/node_modules/electron-builder/src/yarn.ts:16:11
    at Generator.next (<anonymous>)
    at runCallback (timers.js:781:20)
    at tryOnImmediate (timers.js:743:5)
    at processImmediate [as _immediateCallback] (timers.js:714:5)
From previous event:
    at installOrRebuild (/Users/michaelmclaughlin/Sites/specless/cloud-compiler/sync/node_modules/electron-builder/out/yarn.js:33:21)
    at /Users/michaelmclaughlin/Sites/specless/cloud-compiler/sync/node_modules/electron-builder/src/packager.ts:404:13
    at Generator.next (<anonymous>)
From previous event:
    at Packager.installAppDependencies (/Users/michaelmclaughlin/Sites/specless/cloud-compiler/sync/node_modules/electron-builder/out/packager.js:486:11)
    at /Users/michaelmclaughlin/Sites/specless/cloud-compiler/sync/node_modules/electron-builder/src/packager.ts:231:20
    at Generator.next (<anonymous>)
From previous event:
    at Packager.doBuild (/Users/michaelmclaughlin/Sites/specless/cloud-compiler/sync/node_modules/electron-builder/out/packager.js:379:11)
    at /Users/michaelmclaughlin/Sites/specless/cloud-compiler/sync/node_modules/electron-builder/src/packager.ts:170:52
    at Generator.next (<anonymous>)
    at runCallback (timers.js:781:20)
    at tryOnImmediate (timers.js:743:5)
    at processImmediate [as _immediateCallback] (timers.js:714:5)
From previous event:
    at Packager.build (/Users/michaelmclaughlin/Sites/specless/cloud-compiler/sync/node_modules/electron-builder/out/packager.js:274:11)
    at /Users/michaelmclaughlin/Sites/specless/cloud-compiler/sync/node_modules/electron-builder/src/builder.ts:198:33
    at Generator.next (<anonymous>)
From previous event:
    at build (/Users/michaelmclaughlin/Sites/specless/cloud-compiler/sync/node_modules/electron-builder/out/builder.js:70:21)
    at Object.<anonymous> (/Users/michaelmclaughlin/Sites/specless/cloud-compiler/sync/node_modules/electron-builder/out/cli/build-cli.js:71:41)
    at Module._compile (module.js:573:30)
    at Object.Module._extensions..js (module.js:584:10)
    at Module.load (module.js:507:32)
    at tryModuleLoad (module.js:470:12)
    at Function.Module._load (module.js:462:3)
    at Function.Module.runMain (module.js:609:10)
    at startup (bootstrap_node.js:158:16)
    at bootstrap_node.js:598:3

</details>

PYTHON should be the path to the binary, not the directory containing the binary.  Hope that helps.


RNVectorIconsModule not available using wix navigation

Hi guys,
I've got an error like this when I tried to use the icon for toolbar in wix navigation

Error: RNVectorIconsModule not available, did you properly integrate the module? Try running react-native link react-native-vector-icons and recompiling.

The other screen beside icon toolbar is work. I've been following all the instructions and read all issue but can't get through with it.
This is the code that I tried to run from wix documentation. FYI I've got a friend of mine who use the same code and it worked (and he didn't know how)
thanks in advance

Did you run react-native link react-native-vector-icons and recompile like the error suggests?

my bad, I'm not following the detail tutorial from wix. the issue has been closed :)

Hi @kriptonhaz,
I'm having the same problem. Can elaborate on how you fixed it?

Make sure you make a mapping for your icon that you want to use

@kriptonhaz, can you post the snippet of your code?

Following the the manual installation steps solved the problem


Proper key names in save file

Is it intentional that the keys in the safe file are all pretty much useless without looking at the code constantly to see what the configured serialization names are?
Having proper names would allow people who are not experienced with code to also tinker with their save files, or is this actively discouraged and hence the obfuscation? One could even explain in the readme or somewhere else what some of the values mean and influence.

While obfuscation wasn't the intention, I won't change it and don't approve of save editing. The actual reason was file size, in case you had a lot of different items it was 5-10 times the difference.
You still need to be experienced user to change some parts of the file even if it had full names specified, because some things need runtime information to be read correctly like item indices.


Absolute symlinks within generated docs

I really like the looks of the output from typedoc-theme-yaf.  However, because it uses typedoc-plugin-versions under the covers, the symbolic links that get created are absolute ones -- relative to the directory hierarchy on my development environment.
That makes it basically impossible to transport the generated docs directory to some static webserver, or publish it as GitHub Pages.
Is there any way that you (or the maintainers if any for typedoc-plugin-versions) could make relative symbolic links possible?

Hi @craigmcc
Typedoc-plugin-versions was written as a precursor to this theme, but made published as a separate module for reasons of practicality.
I remember there being issues at the time of writing with symlinks and GitHub. I will need to wrap my head around these again as it was a while ago!
Would you raise this issue on that project page so that my co-maintainer can have eyes in it too.
For use of this theme on GitHub (which does work with the symlinks as they are, depending on how you approach the problem 😅), see the CID guide in the Readme for using GitHub workflows: https://github.com/citkane/typedoc-plugin-versions#cid


Agent: Include Cilium version in output of cilium status --verbose

Bug report
General Information
When using cilium status --verbose to introspect Cilium installations, it would be helpful if the output included the Cilium version running.

@joestringer can you assign me this issue? Thanks.


Running on Windows

Hi! This isn't really an issue, but I'm not confident enough for a PR yet.
I got the example program running on Windows by using Msys2.

install msys2 by following https://code.visualstudio.com/docs/cpp/config-mingw

Install g++ and make within msys2 ucrt64

pacman -S --needed base-devel mingw-w64-x86_64-toolchain

Add the msys2 ucrt64 bin folder to path C:\msys64\ucrt64\bin

Install make by running pacman -S make in msys2 ucrt66
Set rust to use msys2: by running rustup toolchain install stable-x86_64-pc-windows-gnu in Windows Powershell/Cmd
Add .cargo/config file in the project with the following contents:

[target.x86_64-pc-windows-gnu]
linker = "C:\\msys64\\ucrt64\\bin\\gcc.exe"
ar = "C:\\msys64\\ucrt64\\bin\\ar.exe"

Run cargo run  in Windows Powershell/Cmd

I'm not the main developer, so take what I say with a grain of salt.
That's awesome that you got it working on Windows!
I think this would great to put in a markdown file (maybe named buildHelp.md, buildInstructions.md or FAQ.md) in a docs folder.
Potentially it should be added to the main README.md in a section called "Windows Support" or something.
I encourage you to make your own fork, create a PR to this repo with what you have above in a markdown file, and then linking this issue (if you can).
It's what I did the other day and @tazz4843 was great to work with!

I'd say exactly what @bruskajp said to do here, put these instructions in /BUILDING.md, and link to it from the README.

I was able to get it to work natively on Windows, the only hiccups being I needed Visual Studio C++, cmake, and to use the git repo instead of crate version.

Submitted PR https://github.com/tazz4843/whisper-rs/pull/27 that combines everything I could find about building into BUILDING.md.

I've never heard of msys2 or know what it does/is useful for, but using the repo instead of the crate is a different bug that isn't related to building on Windows, just the "two" dependencies needed to compile whisper.cpp were all I needed (VS w/ C++ & CMake)
You could also use WSL, Arch even using Archwsl or Distrod to use pacman like msys2, but that would be a linux subsystem on windows rather than msys2, curious if there's any performance difference between native vs msys2 vs wsl.

@ShayBox The msys2 project is basically a way to use GCC/Clang on Windows. It produces a native binary, so I suspect the performance is pretty good.
I think WSL is generally not a bad way to go, but my laptop has been having issues with WSL lol, and you'd need to do a cross-compile for the binary, which isn't bad.

Hi, guys. I tried the steps above. But it doesn't work with some build errors.
In my Windows11, these steps below did work:

Install MSYS2 by following https://code.visualstudio.com/docs/cpp/config-mingw
Install mingw-w64-x86_64-gcc within MSYS2 MINGW64
a. pacman -S --needed base-devel mingw-w64-x86_64-toolchain
b. Add C:\msys64\mingw64\bin to the environment variable Path in Windows
Setup LLVM
a. Download and install LLVM from https://releases.llvm.org/download.html
b. Set the environment variable LIBCLANG_PATH to C:\Program Files\LLVM\bin
Set Rust to use MSYS2 : by running rustup toolchain install stable-x86_64-pc-windows-gnu and rustup default x86_64-pc-windows-gnu in Windows Powershell/Cmd
Add .cargo/config.toml file in the project with the following contents:

[target.x86_64-pc-windows-gnu]
linker = "C:\\msys64\\mingw64\\bin\\gcc.exe"
ar = "C:\\msys64\\mingw64\\bin\\ar.exe"

Run cargo run in Windows Powershell/Cmd

I hope this helps someone.

You could probably also use cross-rs which uses docker/podman which uses wsl, to cross-compile windows binaries on linux (wsl) on windows, depends on your workflow, but wsl, cross-rs, and msys2 seem overly complicated to setup unless you were already using them
Native worked for me after installing cmake because I already had VS w/ C++ installed to compile other rust and nodejs libraries that need VS build tools installed

Closed by #27

@ShayBox

Native worked for me after installing cmake because I already had VS w/ C++ installed to compile other rust and nodejs libraries that need VS build tools installed

Which version of Visual Studio/cmake are you using?
I am using the following and I get an error when cargo build.

Visual Studio 2022 (17.5.4)
cmake 3.26.3
rustc 1.68.2 (9eb3afe9e 2023-03-27)

My error:
PS D:\Users\xxxx\xxxx> cargo build
warning: unused manifest key: dependencies.whisper-rs.commit
   Compiling whisper-rs-sys v0.3.1 (https://github.com/tazz4843/whisper-rs#dfe74508)
error: failed to run custom build command for `whisper-rs-sys v0.3.1 (https://github.com/tazz4843/whisper-rs#dfe74508)`

Caused by:
  process didn't exit successfully: `D:\Users\xxxx\xxxx\target\debug\build\whisper-rs-sys-8025d127ac81a2a6\build-script-build` (exit code: 101)
  --- stderr
  thread 'main' panicked at 'Failed to build libwhisper.a', C:\Users\xxx\.cargo\git\checkouts\whisper-rs-c8b9fa7c09c8c913\dfe7450\sys\build.rs:87:9
  note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

I have also tried the following versions of cmake with the same problem.

3.25.3
3.24.4
3.23.5
3.22.5

This error seems to occur on this line:
https://github.com/tazz4843/whisper-rs/blob/dfe74508dc361034d267d8b36560f2d8ac064ece/sys/build.rs#L87
If you have any ideas on how to resolve this error, it would be appreciated.

Perhaps try out the fixes in #30 @kecbigmt?

I already tried #30 and git repo, but got same error.
cmake --build . --config Release was returning status code 1, but stdout did not seem to be UTF-8 and could not encode in Rust code.
However, this error was finally resolved with #31 !
Now I can successfully build using VS/cmake without using MSYS2 and Whisper is working without any problems.
Thank you guys.

Hi,
I tried the instruction to run the example on windows but I get the following error:
could not find native static library whisper, perhaps an -L flag is missing?
Is this error coming from whisper.cpp or from whisper-rs ?
I plan to use it with tauri so I don't think I can rely on cross compilation.
`cargo run --example basic_use
Compiling winapi-x86_64-pc-windows-gnu v0.4.0
Compiling winapi v0.3.9
Compiling proc-macro2 v1.0.60
Compiling memchr v2.5.0
Compiling libc v0.2.146
Compiling glob v0.3.1
Compiling quote v1.0.28
Compiling unicode-ident v1.0.9
Compiling minimal-lexical v0.2.1
Compiling syn v1.0.109
Compiling either v1.8.1
Compiling regex-syntax v0.7.2
Compiling once_cell v1.18.0
Compiling bindgen v0.64.0
Compiling shlex v1.1.0
Compiling log v0.4.19
Compiling lazy_static v1.4.0
Compiling lazycell v1.3.0
Compiling clang-sys v1.6.1
Compiling peeking_take_while v0.1.2
Compiling regex v1.8.4
Compiling rustc-hash v1.1.0
Compiling bitflags v1.3.2
Compiling cfg-if v1.0.0
Compiling hound v3.5.0
Compiling which v4.4.0
Compiling nom v7.1.3
Compiling libloading v0.7.4
Compiling cexpr v0.6.0
Compiling whisper-rs-sys v0.6.1 (C:\Users\Thibaut\Documents\code\whisper-rs\sys)
Compiling whisper-rs v0.8.0 (C:\Users\Thibaut\Documents\code\whisper-rs)
error: could not find native static library whisper, perhaps an -L flag is missing?`


Facebook video download fails with authentication and 2018.10.05

This is follow up of #17050 and #17171
Make sure you are using the latest version: run youtube-dl --version and ensure your version is 2018.10.05. If it's not, read this FAQ entry and update. Issues with outdated version will be rejected.

[x] I've verified and I assure that I'm running youtube-dl 2018.10.05

Before submitting an issue make sure you have:

[x] At least skimmed through the README, most notably the FAQ and BUGS sections
[x] Searched the bugtracker for similar issues including closed ones
[x] Checked that provided video/audio/playlist URLs (if any) are alive and playable in a browser

What is the purpose of your issue?

[x] Bug report (encountered problems with youtube-dl)
[ ] Site support request (request for adding support for a new site)
[ ] Feature request (request for a new functionality)
[ ] Question
[ ] Other

$ youtube-dl 'https://www.facebook.com/ChefClubItalia/videos/1995926910684284/' --no-part --netrc -c -o 'download/%(id)s.mp4' --verbose
[debug] System config: []
[debug] User config: []
[debug] Custom config: []
[debug] Command-line args: ['https://www.facebook.com/ChefClubItalia/videos/1995926910684284/', '--no-part', '--netrc', '-c', '-o', 'download/%(id)s.mp4', '--verbose']
[debug] Encodings: locale UTF-8, fs utf-8, out UTF-8, pref UTF-8
[debug] youtube-dl version 2018.10.05
[debug] Python version 3.6.5 (CPython) - Linux-4.4.0-17134-Microsoft-x86_64-with-Ubuntu-18.04-bionic
[debug] exe versions: ffmpeg 3.4.4-0ubuntu<IP_ADDRESS>, ffprobe 3.4.4-0ubuntu<IP_ADDRESS>
[debug] Proxy map: {}
[facebook] Downloading login page
[facebook] Logging in
[facebook]<PHONE_NUMBER>684284: Downloading webpage
[facebook]<PHONE_NUMBER>684284: Downloading webpage
[facebook]<PHONE_NUMBER>684284: Downloading webpage
ERROR: Unable to download webpage: HTTP Error 404: Not Found (caused by <HTTPError 404: 'Not Found'>); please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; see  https://yt-dl.org/update  on how to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.
  File "/usr/local/lib/python3.6/dist-packages/youtube_dl/extractor/common.py", line 604, in _request_webpage
    return self._downloader.urlopen(url_or_request)
  File "/usr/local/lib/python3.6/dist-packages/youtube_dl/YoutubeDL.py", line 2211, in urlopen
    return self._opener.open(req, timeout=self._socket_timeout)
  File "/usr/lib/python3.6/urllib/request.py", line 532, in open
    response = meth(req, response)
  File "/usr/lib/python3.6/urllib/request.py", line 642, in http_response
    'http', request, response, code, msg, hdrs)
  File "/usr/lib/python3.6/urllib/request.py", line 570, in error
    return self._call_chain(*args)
  File "/usr/lib/python3.6/urllib/request.py", line 504, in _call_chain
    result = func(*args)
  File "/usr/lib/python3.6/urllib/request.py", line 650, in http_error_default
    raise HTTPError(req.full_url, code, msg, hdrs, fp)

$ youtube-dl --version
2018.10.05

The URL that fails is the TAHOE video URL that has been removed by Facebook.
'https://www.facebook.com/video/tahoe/async/1995926910684284/?chain=true&isvideo=true'

Same here Windows 7
[debug] System config: []
[debug] User config: []
[debug] Custom config: []
[debug] Command-line args: ['-v', '--username', 'PRIVATE', '--password', 'PRIVATE', 'https://m.facebook.com/mercedita.medio/videos/931295653728924/']
[debug] Encodings: locale cp1252, fs mbcs, out cp1252, pref cp1252
[debug] youtube-dl version 2018.10.05
[debug] Python version 3.4.4 (CPython) - Windows-7-6.1.7601-SP1
[debug] exe versions: ffmpeg N-92086-gd702769213, ffprobe N-92086-gd702769213
[debug] Proxy map: {}
[facebook] Downloading login page
[facebook] Logging in
[facebook]<PHONE_NUMBER>28924: Downloading webpage
[facebook]<PHONE_NUMBER>28924: Downloading webpage
[facebook]<PHONE_NUMBER>28924: Downloading webpage
ERROR: Unable to download webpage: HTTP Error 404: Not Found (caused by HTTPError()); please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; type  youtube-dl -U  to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.
  File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\rg3\tmp5xdqinp2\build\youtube_dl\extractor\common.py", line 604, in _request_webpage
  File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\rg3\tmp5xdqinp2\build\youtube_dl\YoutubeDL.py", line 2211, in urlopen
  File "C:\Python\Python34\lib\urllib\request.py", line 470, in open
  File "C:\Python\Python34\lib\urllib\request.py", line 580, in http_response
  File "C:\Python\Python34\lib\urllib\request.py", line 508, in error
  File "C:\Python\Python34\lib\urllib\request.py", line 442, in _call_chain
  File "C:\Python\Python34\lib\urllib\request.py", line 588, in http_error_default

Same here


Add new sideEffects flag for Webpack 4

Webpack 4 comes with a new sideEffects flag for package authors to add in their package.json. This makes it possible for Webpack to do further optimisations in its compilation.
I think the filters are free of side effects by Webpack's definition, so they should have the flag set to false. It would be nice to confirm this with some kind of test (or a third-party tool that does the check?), and to know how much of a performance benefit it is for this package.

[ ] Add new "sideEffects": false, flag in package.json
[ ] Write a test, or integrate a tool, that checks for this
[ ] Assess performance benefit of using the new flag

@thibaudcolas i would like to work on this but i dont really know how i would write a test for this.

@JipSterk I think we can go without tests (see my comment in #25) – all the projects I checked out have just added the flag without blinking:

https://github.com/marionettejs/backbone.marionette/pull/3577
https://github.com/ReactTraining/history/pull/597
https://github.com/kensho-technologies/orama/pull/34

I think the best way to properly test this would be to have a linting rule (ESLint or Flowlint) for it, but that's a lot of work.

Fixed in #25.


Demo App Crashed on iOS working Fine on Android

Environment
System:
OS: macOS 10.15.7
CPU: (8) x64 Intel(R) Core(TM) i5-8257U CPU @ 1.40GHz
Memory: 157.21 MB / 16.00 GB
Shell: 3.2.57 - /bin/bash
Binaries:
Node: 14.15.0 - ~/.nvm/versions/node/v14.15.0/bin/node
Yarn: 1.22.10 - ~/.nvm/versions/node/v14.15.0/bin/yarn
npm: 6.14.8 - ~/.nvm/versions/node/v14.15.0/bin/npm
Watchman: 4.9.0 - /usr/local/bin/watchman
Managers:
CocoaPods: 1.10.0 - /usr/local/bin/pod
SDKs:
iOS SDK:
Platforms: iOS 14.2, DriverKit 20.0, macOS 11.0, tvOS 14.2, watchOS 7.1
Android SDK:
API Levels: 28, 29, 30
Build Tools: 28.0.3, 29.0.2, 29.0.3, 30.0.2
System Images: android-30 | Google APIs Intel x86 Atom
Android NDK: Not Found
IDEs:
Android Studio: 4.1 AI-201.87<IP_ADDRESS>58069
Xcode: 12.2/12B45b - /usr/bin/xcodebuild
Languages:
Java: 1.8.0_272 - /usr/bin/javac
Python: 2.7.16 - /usr/bin/python
npmPackages:
@react-native-community/cli: Not Found
react: ^16.14.0 => 16.14.0
react-native: ^0.63.3 => 0.63.3
react-native-macos: Not Found
npmGlobalPackages:
react-native: Not Found

Hi @sacmii, I was not able to reproduce this issue.

Did you make any change to the demo app?
What's the version of AmazonChimeSDK.framework and AmazonChimeSDKMedia.framework that you are using?

Hi @sacmii, I was not able to reproduce this issue.

Did you make any change to the demo app?
What's the version of AmazonChimeSDK.framework and AmazonChimeSDKMedia.framework that you are using?

AmazonChimeSDK-0.8.2.tar.gz and
AmazonChimeSDKMedia-0.6.1.tar.gz

Looks like you are not providing ExternalMeetingId in your chime.createMeeting call and it's returning you null ExternalMeetingId.

Thanks @marcspicer. While I'm also curious about what happened to ExternalMeetingId, it shouldn't be the root cause because it's a string "<null>", not a nil string. I also tested with ExternalMeetingId set to "<null>" and nil, but there was no crash.
The error indicates that there is something that should be a NSString but it's actually a NSNull. @sacmii, could you provide more details on what have you changed in the demo app, especially in NativeMobileSDKBridge.startMeeting()?

startMeeting
there are no changes i made.
Adding startMeeting function over here
`

pragma mark: Native Function
RCT_EXPORT_METHOD(startMeeting:(NSDictionary *)meetingInfoDict attendeeInfo:(NSDictionary *)attendeeInfoDict)
{
if (meetingSession != nil)
{
[meetingSession.audioVideo stop];
meetingSession = nil;
}
logger = [[ConsoleLogger alloc] initWithName:@"NativeMobileSDKBridge" level:LogLevelDEFAULT];
[logger infoWithMsg: [[NSString alloc] initWithFormat:@"Running Amazon Chime SDK (%@)", Versioning.sdkVersion]];
// Parse meeting join data from payload
NSDictionary *mediaPlacementDict = [meetingInfoDict objectForKey:kMediaPlacement];
// Parse meeting info
NSString *meetingId = [meetingInfoDict objectForKey:kMeetingId];
NSString *externalMeetingId = [meetingInfoDict objectForKey:kExternalMeetingId];
NSString *meetingRegion = [meetingInfoDict objectForKey:kMediaRegion];
// Parse meeting join info
NSString *audioFallbackUrl = [mediaPlacementDict objectForKey:kAudioFallbackUrl];
NSString *audioHostUrl = [mediaPlacementDict objectForKey:kAudioHostUrl];
NSString *turnControlUrl = [mediaPlacementDict objectForKey:kTurnControlUrl];
NSString *signalingUrl = [mediaPlacementDict objectForKey:kSignalingUrl];
// Parse attendee info
NSString *attendeeId = [attendeeInfoDict objectForKey:kAttendeeId];
NSString *externalUserId = [attendeeInfoDict objectForKey:kExternalUserId];
NSString *joinToken = [attendeeInfoDict objectForKey:kJoinToken];
// Initialize meeting session through AmazonChimeSDK
MediaPlacement *mediaPlacement = [[MediaPlacement alloc] initWithAudioFallbackUrl:audioFallbackUrl
audioHostUrl:audioHostUrl
signalingUrl:signalingUrl
turnControlUrl:turnControlUrl];
Meeting *meeting = [[Meeting alloc] initWithExternalMeetingId:externalMeetingId
mediaPlacement:mediaPlacement
mediaRegion:meetingRegion
meetingId:meetingId];
CreateMeetingResponse *createMeetingResponse = [[CreateMeetingResponse alloc] initWithMeeting:meeting];
Attendee *attendee = [[Attendee alloc] initWithAttendeeId:attendeeId
externalUserId:externalUserId joinToken:joinToken];
CreateAttendeeResponse *createAttendeeResponse = [[CreateAttendeeResponse alloc] initWithAttendee:attendee];
MeetingSessionConfiguration *meetingSessionConfiguration = [[MeetingSessionConfiguration alloc] initWithCreateMeetingResponse:createMeetingResponse
createAttendeeResponse:createAttendeeResponse];
meetingSession = [[DefaultMeetingSession alloc] initWithConfiguration:meetingSessionConfiguration
logger:logger];
[self startAudioClient];
}
`

Hi @sacmii ,
The startMeeting() implementation looks good to me. Could you try to log out all the NSStrings in startMeeting() and see which one is nil? Also, could you try to clone the repo again and strictly follow How to Run the React Native Demo Application guide and see if the issue persists?

implementation

issue still persists.. attaching log
RNDemo[...] 3affde2b-3eeb-4314-bb56-d4acefdbcef9 meetingId
RNDemo[...] <null> externalMeetingId
RNDemo[...] us-east-1 meetingRegion
RNDemo[...] wss://haxrp.m3.ue1.app.chime.aws:443/calls/3affde2b-3eeb-4314-bb56-d4acefdbcef9 audioFallbackUrl
RNDemo[...] b002e21a0fec0eed9ed387fcfce27b84.k.m3.ue1.app.chime.aws:3478 audioHostUrl
RNDemo[...] https://ccp.cp.ue1.app.chime.aws/v2/turn_sessions turnControlUrl
RNDemo[...] wss://signal.m3.ue1.app.chime.aws/control/3affde2b-3eeb-4314-bb56-d4acefdbcef9 signalingUrl
RNDemo[...] ab8bd69d-1f22-17bb-15ed-1f0e31f46791 attendeeId
RNDemo[...] 0f148bee-a1d3-4727-a73e-e9a1754fc850 externalUserId
RNDemo[...] YWI4YmQ2OWQtMWYyMi0xN2JiLTE1ZWQtMWYwZTMxZjQ2NzkxOmUxMGVlMjBlLTEzYjctNGJlYi05NDZlLWJmOTI4N2E4NTQ0Ng joinToken
RNDemo[...] -[NSNull _fastCStringContents:]: unrecognized selector sent to instance 0x1fb909ee0
[fatal][tid:com.facebook.react.NativeMobileSDKBridgeQueue] Exception '-[NSNull _fastCStringContents:]: unrecognized selector sent to instance 0x1fb909ee0' was thrown while invoking startMeeting on target NativeMobileSDKBridge with params (
        {
        ExternalMeetingId = "<null>";
        MediaPlacement =         {
            AudioFallbackUrl = "wss://haxrp.m1.ue1.app.chime.aws:443/calls/3a8ac2ab-c050-42fc-8033-35d0879d1b51";
            AudioHostUrl = "c7b8e2fa0bd7b098d53452c12493845a.k.m1.ue1.app.chime.aws:3478";
            ScreenDataUrl = "wss://bitpw.m1.ue1.app.chime.aws:443/v2/screen/3a8ac2ab-c050-42fc-8033-35d0879d1b51";
            ScreenSharingUrl = "wss://bitpw.m1.ue1.app.chime.aws:443/v2/screen/3a8ac2ab-c050-42fc-8033-35d0879d1b51";
            ScreenViewingUrl = "wss://bitpw.m1.ue1.app.chime.aws:443/ws/connect?passcode=null&viewer_uuid=null&X-BitHub-Call-Id=3a8ac2ab-c050-42fc-8033-35d0879d1b51";
            SignalingUrl = "wss://signal.m1.ue1.app.chime.aws/control/3a8ac2ab-c050-42fc-8033-35d0879d1b51";
            TurnControlUrl = "https://ccp.cp.ue1.app.chime.aws/v2/turn_sessions";
        };
        MediaRegion = "us-east-1";
        MeetingId = "3a8ac2ab-c050-42fc-8033-35d0879d1b51";
    },
        {
        AttendeeId = "a86b5efc-5aef-f121-3c74-5377c8b036db";
        ExternalUserId = "3cc73837-8a0b-4382-a76c-bd0c5f7da4f7";
        JoinToken = YTg2YjVlZmMtNWFlZi1mMTIxLTNjNzQtNTM3N2M4YjAzNmRiOjllZWVlNjY4LTI3ODItNGI2ZS1iNDZhLTFiMGQ3NjdjYzFhNw;
    }
)
callstack: (
	0   CoreFoundation                      0x00000001ada3d9e8 96F8386D-D88A-3C89-A323-A17975C3317F + 1157608
	1   libobjc.A.dylib                     0x00000001c13eeb54 objc_exception_throw + 56
	2   CoreFoundation                      0x00000001ad94dbac 96F8386D-D88A-3C89-A323-A17975C3317F + 175020
	3   CoreFoundation                      0x00000001ada40018 96F8386D-D88A-3C89-A323-A17975C3317F + 1167384
	4   CoreFoundation                      0x00000001ada41f8c _CF_forwarding_prep_0 + 92
	5   libswiftCore.dylib                  0x00000001b15c0498 $ss18_bridgeCocoaStringys01_C4GutsVyXlF + 100
	6   libswiftCore.dylib                  0x00000001b15c0788 $sSS12_cocoaStringSSyXl_tcfC + 24
	7   libswiftFoundation.dylib            0x00000001b12bbefc $sSS10FoundationE36_unconditionallyBridgeFromObjectiveCySSSo8NSStringCSgFZ + 32
	8   AmazonChimeSDK                      0x0000000105fdc6a4 block_destroy_helper + 1516
	9   RNDemo                              0x000000010203fdd0 -[NativeMobileSDKBridge startMeeting:attendeeInfo:] + 1296
	10  CoreFoundation                      0x00000001ada42130 96F8386D-D88A-3C89-A323-A17975C3317F + 1175856
	11  CoreFoundation                      0x00000001ad9251c0 96F8386D-D88A-3C89-A323-A17975C3317F + 8640
	12  CoreFoundation                      0x00000001ad925720 96F8386D-D88A-3C89-A323-A17975C3317F + 10016
	13  RNDemo                              0x00000001025c5464 -[RCTModuleMethod invokeWithBridge:module:arguments:] + 1880
	14  RNDemo                              0x00000001025c8b2c _ZN8facebook5reactL11invokeInnerEP9RCTBridgeP13RCTModuleDatajRKN5folly7dynamicE + 648
	15  RNDemo                              0x00000001025c86e0 _ZZN8facebook5react15RCTNativeModule6invokeEjON5folly7dynamicEiENK3$_0clEv + 128
	16  RNDemo                              0x00000001025c8654 ___ZN8facebook5react15RCTNativeModule6invokeEjON5folly7dynamicEi_block_invoke + 28
	17  libdispatch.dylib                   0x0000000106057ce4 _dispatch_call_block_and_release + 24
	18  libdispatch.dylib                   0x0000000106059528 _dispatch_client_callout + 16
	19  libdispatch.dylib                   0x00000001060605ac _dispatch_lane_serial_drain + 748
	20  libdispatch.dylib                   0x0000000106061234 _dispatch_lane_invoke + 452
	21  libdispatch.dylib                   0x000000010606ca5c _dispatch_workloop_worker_thread + 1456
	22  libsystem_pthread.dylib             0x00000001f409e5a4 _pthread_wqthread + 272
	23  libsystem_pthread.dylib             0x00000001f40a1874 start_wqthread + 8
)

Hi @sacmii,
I checked again and actually @marcspicer was right. In your log ExternalMeetingId = "<null>"; actually means the ExternalMeetingId is NSNull, because "<null>" is the result of [[NSNull null] description].
Could you check your React Native code and make sure when you call NativeFunction.startMeeting(meetingInfo, attendeeInfo) the meetingInfo.ExternalMeetingId is not null? Ref to the demo app: https://github.com/aws-samples/amazon-chime-react-native-demo/blob/master/src/App.js#L67

Issue resolved when a new serverless demo is created.

Well, I solved it by adding this
meeting.Meeting.ExternalMeetingId= ""
before  this
NativeFunction.startMeeting(meeting.Meeting, attendee.Attendee);
So together
meeting.Meeting.ExternalMeetingId= ""
NativeFunction.startMeeting(meeting.Meeting, attendee.Attendee);


NULL_DEREFERENCE not found when there are && in loop conditions

I was playing with an OpenSSL function  https://github.com/openssl/openssl/blob/5f96a95e2562f026557f625e50c052e77c7bc2e8/crypto/modes/cbc128.c#L55 and found this issue.
I came up with a few minimized examples to see why Infer missed the NULL_DEREFERENCE.

Infer can capture them when there are no&& in the loop conditions in test1_1 and test2_1.
However, if I changed the loop condition and added && (such as test1_2 or test1_3), infer missed the issues.
I also tried and added || to loop condition. Infer can capture them correctly.

Please make sure your issue is not addressed in the FAQ.
Please include the following information:

[x] The version of infer from infer --version.

$ infer --version
Infer version v1.1.0-119e20698
Copyright 2009 - present Facebook. All Rights Reserved.

[x] Your operating system and version, for example "Debian 9", "MacOS High Sierra", whether you are using Docker, etc.

ubuntu 20.04
5.8.0-50-generic #56~20.04.1-Ubuntu SMP

[x] Which command you ran, for example infer -- make.

infer run -- gcc -c 1.c

[x] The full output in a paste, for instance a gist.

$ infer run -- gcc -c 1.c
Capturing in make/cc mode...
Found 1 source file to analyze in /home/work/d2a/test/infer-out
1/1 [################################################################################] 100% 57.098ms

1.c:16: error: Null Dereference
  pointer `in` last assigned on line 14 could be null and is dereferenced at line 16, column 9.
  14.     const unsigned char *in = NULL;
  15.     while (len) {
  16.         * in;
              ^
  17.         len--;
  18.     }

1.c:41: error: Null Dereference
  pointer `in` last assigned on line 39 could be null and is dereferenced at line 41, column 9.
  39.     const unsigned char *in = NULL;
  40.     for (;len;) {
  41.         * in;
              ^
  42.         len--;
  43.     }

Found 2 issues
          Issue Type(ISSUED_TYPE_ID): #
  Null Dereference(NULL_DEREFERENCE): 2

[x] If possible, a minimal example to reproduce your problem (for instance, some code where
infer reports incorrectly, together with the way you run infer to reproduce the incorrect
report).

#include <stdio.h>

void original(size_t len, const unsigned char *in, unsigned char *out) {
    size_t n = 0;
    in = NULL;
    while (len) {
        for (n = 0; n < 16 && n < len; ++n)
            out[n] = in[n];
        len -= 16;
    }
}

void test1_1(size_t len) {
    const unsigned char *in = NULL;
    while (len) {
        * in;
        len--;
    }
}

void test1_2(size_t len) {
    const unsigned char *in = NULL;
    while (len && len) {
        * in;
        len--;
    }
}

void test1_3(size_t len) {
    const unsigned char *in = NULL;
    while (len && len < 16) {
        * in;
        len--;
    }
}

void test2_1(size_t len) {
    const unsigned char *in = NULL;
    for (;len;) {
        * in;
        len--;
    }
}

void test2_2(size_t len) {
    const unsigned char *in = NULL;
    for (;len && len;) {
        * in;
        len--;
    }
}

void test2_3(size_t len) {
    const unsigned char *in = NULL;
    for (;len && len < 16;) {
        * in;
        len--;
    }
}

Infer does find all the null dereference here but some of them are filtered out. You can see them with -F.
As an aside, the new pulse analysis (--pulse) also finds all the issues but doesn't report them straight away as they are only triggered on certain values of len (namely len ≠ 0). Pulse would report these bugs once these functions get called.


test: Fix test for create_ai_extract_structured method (box/box-codegen#618)

Pull Request Test Coverage Report for Build<PHONE_NUMBER>5
Details

0 of 0   changed or added relevant lines in 0 files are covered.
2 unchanged lines in 1 file lost coverage.
Overall coverage decreased (-0.02%) to 92.428%

Files with Coverage Reduction
New Missed Lines
%

box_sdk_gen/internal/base_object.py
2
85.95%

Totals

Change from base Build<PHONE_NUMBER>4:
-0.02%

Covered Lines:
10596

Relevant Lines:
11464

💛  - Coveralls


Use of deprecated API

I'm now getting this warning on the latest version of Home Assistant:

Entity None (<class 'custom_components.dual_smart_thermostat.climate.DualSmartThermostat'>) is using deprecated supported features values which will be removed in HA Core 2025.1. Instead it should use <ClimateEntityFeature: 0>, please create a bug report at https://github.com/swingerman/ha-dual-smart-thermostat/issues and reference https://developers.home-assistant.io/blog/2023/12/28/support-feature-magic-numbers-deprecation

Thanks for reporting this

What version of the component are you using currently?

We have already fixed this requirement. I assume you are on an older version, so I am closing this for now.

This is still happening for me on <IP_ADDRESS>.  My most recent instance of this log entry is from yesterday morning and I'm using the latest release.

Fiesd the issue and it will be included in the next release


⚠ Jenkins Plugins Artifactory has degraded performance

In fed283c, Jenkins Plugins Artifactory (https://get.jenkins.io/plugins/artifactory/) experienced degraded performance:

HTTP code: 200
Response time: 1273 ms

Resolved: Jenkins Plugins Artifactory performance has improved in f102bae after 12 minutes.


OpenTaxii + Postgresql DB configuration throws up 'Invalid argument(s) ..., using configuration PGDialect_psycopg2/QueuePool/Engine

I have been trying to setup an openTaxii server with a postgresql DB running on the same box.
I have the following configuration file (defaults.yml):
---

domain: "localhost:9000"

support_basic_auth: no
return_server_error_details: no

auth_api:
  class: opentaxii.persistence.sqldb.SQLDatabaseAPI
  parameters:
    db_connection: postgresql://opentaxii:**********@localhost:5432/opentaxii
    create_tables: yes
    secret: some-secret-key
    token_ttl_secs: 3600

taxii1:
  save_raw_inbox_messages: no
  xml_parser_supports_huge_tree: yes
  count_blocks_in_poll_responses: no
  unauthorized_status: UNAUTHORIZED
  hooks:
  persistence_api:
    class: opentaxii.persistence.sqldb.SQLDatabaseAPI
    parameters:
      db_connection: postgresql://opentaxii:*******@localhost:5432/opentaxii
      create_tables: yes

taxii2:

logging:
  opentaxii: info
  root: info

however, every time I try to startup the server or use opentaxii-sync-data, I am coming across the following error:
2022-12-01T17:36:12.571131Z [opentaxii.utils] info: api.initialized {api=opentaxii.persistence.sqldb.SQLDatabaseAPI}
2022-12-01T17:36:12.571381Z [opentaxii.server] info: opentaxii.server_configured
Traceback (most recent call last):
  File "/usr/local/bin/opentaxii-sync-data", line 11, in <module>
    load_entry_point('opentaxii==0.9.3', 'console_scripts', 'opentaxii-sync-data')()
  File "/usr/lib/python3/dist-packages/pkg_resources/__init__.py", line 490, in load_entry_point
    return get_distribution(dist).load_entry_point(group, name)
  File "/usr/lib/python3/dist-packages/pkg_resources/__init__.py", line 2854, in load_entry_point
    return ep.load()
  File "/usr/lib/python3/dist-packages/pkg_resources/__init__.py", line 2445, in load
    return self.resolve()
  File "/usr/lib/python3/dist-packages/pkg_resources/__init__.py", line 2451, in resolve
    module = __import__(self.module_name, fromlist=['__name__'], level=0)
  File "/usr/local/lib/python3.8/dist-packages/opentaxii-0.9.3-py3.8.egg/opentaxii/cli/__init__.py", line 10, in <module>
    server = TAXIIServer(config)
  File "/usr/local/lib/python3.8/dist-packages/opentaxii-0.9.3-py3.8.egg/opentaxii/server.py", line 879, in __init__
    server=self, api=initialize_api(config["auth_api"])
  File "/usr/local/lib/python3.8/dist-packages/opentaxii-0.9.3-py3.8.egg/opentaxii/utils.py", line 41, in initialize_api
    instance = cls(**params)
```  File "/usr/local/lib/python3.8/dist-packages/opentaxii-0.9.3-py3.8.egg/opentaxii/common/sqldb.py", line 16, in __init__
    self.db = SQLAlchemyDB(
  File "/usr/local/lib/python3.8/dist-packages/opentaxii-0.9.3-py3.8.egg/opentaxii/sqldb_helper.py", line 28, in __init__
    self.engine = engine.create_engine(db_connection, **kwargs)
  File "<string>", line 2, in create_engine
  File "/usr/local/lib/python3.8/dist-packages/sqlalchemy/util/deprecations.py", line 309, in warned
    return fn(*args, **kwargs)
  File "/usr/local/lib/python3.8/dist-packages/sqlalchemy/engine/create.py", line 636, in create_engine
    raise TypeError(
TypeError: Invalid argument(s) 'secret','token_ttl_secs' sent to create_engine(), using configuration PGDialect_psycopg2/QueuePool/Engine.  Please check that the keyword arguments are appropriate for this combination of components.

NOTE: this works fine if I am using the default sqllite config!
I could not find much documentation on the web on this, so any information/response would be really helpful!

For reference, I am running the following versions of dependencies:
PyJWT~=2.4.0
structlog~=22.1.0
opentaxii~=0.9.3
SQLAlchemy~=1.4.40
Werkzeug~=2.2.2

Apologies, I figured out the problem, this was due to a misconfiguration for the auth_api class on my part:
I had mistakenly set it to class: opentaxii.persistence.sqldb.SQLDatabaseAPI instead of:
class: opentaxii.auth.sqldb.SQLDatabaseAPI
With this setting corrected, everything works fine.
I will close this issue now! Again apologies for this..


python3Packages.aioconsole: 0.3.1 -> 0.3.2

Motivation for this change
Update to latest upstream release 0.3.2
Change log: https://github.com/vxgmichel/aioconsole/releases/tag/v0.3.2
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
21.11 Release Notes (or backporting 21.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 135044 run on x86_64-linux 1

2 packages built:

python38Packages.aioconsole
python39Packages.aioconsole


Create package wheel for pymialsrtk and publish it to PyPI in CircleCI

Add job to create package wheel and publish it to PyPI when release are made.
A very nice guide:
https://circleci.com/blog/continuously-deploying-python-packages-to-pypi-with-circleci/

Closed by #59


should we keep tool-specific configs in conf/envs/? or move them under the tool directories?

my hot take is that it's better to have all the tool-specific things under one common directory.

This is a good idea, @ctb . What else besides the conda environments would go under tools?


deadlink shouldn't be used?

see fakebyte discord posts

Kcp.DEAD_LINK default of '20' is possibly too small

possibly related: https://github.com/skywind3000/kcp/issues/308

MaxRetransmits aka dead_link is now configurable in server ctor / client.connect.
will also be configurable in mirror / dotsnet inspector.
we can try with higher defaults and see if that works better.
if it still fails then it might be a bug in kcp.


bug: next 13.1.6 incompatible with @trpc/next ^10.9.0

Provide environment information
  System:
    OS: Linux 5.10 Debian GNU/Linux 11 (bullseye) 11 (bullseye)
    CPU: (16) x64 AMD Ryzen 7 2700X Eight-Core Processor
    Memory: 12.92 GB / 14.23 GB
    Container: Yes
    Shell: 5.1.4 - /bin/bash
  Binaries:
    Node: 18.14.2 - ~/.config/nvm/versions/node/v18.14.2/bin/node
    npm: 9.5.0 - ~/.config/nvm/versions/node/v18.14.2/bin/npm

  "ct3aMetadata": {
    "initVersion": "7.5.7"
  }

Describe the bug
Running npm install fails with the following error:
npm ERR! code ERESOLVE
npm ERR! ERESOLVE unable to resolve dependency tree
npm ERR!
npm ERR! While resolving<EMAIL_ADDRESS>npm ERR! Found<EMAIL_ADDRESS>npm ERR! node_modules/next
npm ERR<EMAIL_ADDRESS>from the root project
npm ERR!
npm ERR! Could not resolve dependency:
npm ERR! peer<EMAIL_ADDRESS>from<EMAIL_ADDRESS>npm ERR! node_modules/@trpc/next
npm ERR<EMAIL_ADDRESS>from the root project
npm ERR!
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution.
npm ERR!
npm ERR!
npm ERR! For a full report see:
npm ERR! /home/jorisblanken/.npm/_logs/2023-02-28T04_20_22_539Z-eresolve-report.txt

npm ERR! A complete log of this run can be found in:
npm ERR!     /home/jorisblanken/.npm/_logs/2023-02-28T04_20_22_539Z-debug-0.log

### Reproduction repo

NA

### To reproduce

NA

### Additional information

_No response_

Incompatible dependency version is the issue for me
Solution:
In package.json,
Changing from "next": "13.1.6"
to "next": "13.2.1" solves the problem.

fixed


Potential message duplication

Apparently in some conditions messages can be duplicated during send. Originally reported here https://github.com/django/channels/issues/398

Fixed in 1.4.0.


Testing with arm support for Juno and Osmosis

Hi I have some comments and questions here.
First of all, is this desired?  I figure that wasmer 2.2.0 may land in time for the osmosis upgrade.
Secondly, I really couldn’t figure out why the hackathon contract was failing. If anybody has any pointers for me about this, I would really appreciate it.
Thirdly, I’d like to say why I desire this. The reasons are I suppose twofold:
I think that this will remove developer friction when working on both contracts and Blockchain code. Many of us, including me have shifted to using the Apple M1 CPU. And so part of my motivation here is to allow developers to work on the stuff with the same ease and fluidity that they were anything else.
My second motivation, is something I have spoken about a little bit but have taken much more serious measures toward recently. I would like to create a single board computer for validators. One of the appealing platforms for this is the nvidia Jetson.
In fact, a Jetson CPU will even be compatible with the GPU requirements needed for the bostrom project.
we have chosen a hardware engineering design firm at Notional, and have begun preliminary engineering discussions and paid a deposit. Ensuring that CW is arm compatible, will ensure that chains built using CW will be able to use this hardware, which is designed to make validating as simple and secure as possible.

This is desired, but we'll not rush into this. This has multiple reasons.

Various patches have to be shipped this week/near term in order to unblock Juno
Wasmer 2.2.0 is not ready and has open issues
We want to perserve a wider range of Rust compiler versions than proposed in this diff

Secondly, I really couldn’t figure out why the hackathon contract was failing. If anybody has any pointers for me about this, I would really appreciate it.

This is because the compiled Wasm got very efficient for the Argon2 execution when using the latest Rust version. See https://gist.github.com/webmaster128/c0f8292d071522f694fd69a11e280738 and https://github.com/cosmos/cosmjs/pull/907#issuecomment-1030923344.

@webmaster128 OK, sounds good to me.  When I patched CI, I dropped the concept of MSRV, and just used the latest released Rust.  Is that alright?
Appreciate your detailed reply.
<3

I am as excited as you for the ARM support, @faddat 🚀. Thanks for giving it a try. I already tested locally what you proposed here. We'll get there very soon. But the new feature should not get in the way of pending patches.
MSRV is a hot topic and pretty problematic. We compile with Rust 1.55.0 in wasmvm as we had big issues with newer version. Those can be handled, but we cannot so everything at once.
So basically what I would like to do is to take it easy and bring it down. We can bump the MSRV to 1.54 without issues. This might already help to compile everything.

So basically, it's failing because the gas estimation looks too low to be correct?

The cargo wasm command created the Wasm of the contract. By bumping the compiler version in the CI, you use a compiler that produces more efficient output. So in order to fix the test in the CI, you need to reduce the expected gas usage in that test.

Hey!
So I just encountered-- everything you just said :).
I'll summarize and please let me know if I have any of this wrong?

MSRV is because of contract gas?  Different versions of rust can cause quite different gas estimates, basically?

I haven't worked with rust very much before-- is this like, a rust thing, or a cw thing?

Different versions of rust can cause quite different gas estimates, basically?

In this particular case, the difference is very big. The Wasm output is 3x faster than a few months ago. But this is Argon2 where a few optimization in the hot path of the code can make a huge difference.
The general rule of thumb is: be nice to developers and accept a wide range of Rust compilers. For the production build, use a very recent one to get the latest and greatest optimizer.


Need Help connect with Sign in Apple

Hi, i have a problem in Django backend to connect with Sign In Apple . Now, My backend works fine with Facebook.
I working with these dependencies(only i thing important with that issue):
Django==2.2.5
drf-social-oauth2==1.0.8
djangorestframework==3.10.3
PyJWT==2.3.0
social-auth-core==3.3.3

I created and set up application , i don't have problem to generate token and refresh  using endpoint /auth/token but i used endpoint /auth/convert-token i have that error:
IndexError at /auth/convert-token
list index out of range

Request Method: POST
Request URL: http://localhost:8000/auth/convert-token
Django Version: 2.2.5
Python Executable: /usr/local/bin/python
Python Version: 3.7.9
Python Path: ['/app', '/usr/local/lib/python37.zip', '/usr/local/lib/python3.7', '/usr/local/lib/python3.7/lib-dynload', '/usr/local/lib/python3.7/site-packages']
Server time: vie, 29 Oct 2021 13:19:00 +0000
Installed Applications:
['django.contrib.auth',
 'django.contrib.contenttypes',
 'django.contrib.sessions',
 'django.contrib.messages',
 'django.contrib.staticfiles',
 'rest_framework',
 'phone_field',
 'oauth2_provider',
 'social_django',
 'drf_social_oauth2',
 'material.admin',
 'material.admin.default',
 'apps.accounts',
 'apps.i18n_switcher',
 'apps.location',
 'apps.events',
 'apps.emergency_contact',
 'django_extensions',
 'debug_toolbar']
Installed Middleware:
['debug_toolbar.middleware.DebugToolbarMiddleware',
 'django.middleware.security.SecurityMiddleware',
 'django.contrib.sessions.middleware.SessionMiddleware',
 'django.middleware.common.CommonMiddleware',
 'django.middleware.csrf.CsrfViewMiddleware',
 'django.contrib.auth.middleware.AuthenticationMiddleware',
 'django.contrib.messages.middleware.MessageMiddleware',
 'django.middleware.clickjacking.XFrameOptionsMiddleware',
 'django.middleware.locale.LocaleMiddleware']

Traceback:

File "/usr/local/lib/python3.7/site-packages/django/core/handlers/exception.py" in inner
  34.             response = get_response(request)

File "/usr/local/lib/python3.7/site-packages/django/core/handlers/base.py" in _get_response
  115.                 response = self.process_exception_by_middleware(e, request)

File "/usr/local/lib/python3.7/site-packages/django/core/handlers/base.py" in _get_response
  113.                 response = wrapped_callback(request, *callback_args, **callback_kwargs)

File "/usr/local/lib/python3.7/site-packages/django/views/decorators/csrf.py" in wrapped_view
  54.         return view_func(*args, **kwargs)

File "/usr/local/lib/python3.7/site-packages/django/views/generic/base.py" in view
  71.             return self.dispatch(request, *args, **kwargs)

File "/usr/local/lib/python3.7/site-packages/django/utils/decorators.py" in _wrapper
  45.         return bound_method(*args, **kwargs)

File "/usr/local/lib/python3.7/site-packages/django/views/decorators/csrf.py" in wrapped_view
  54.         return view_func(*args, **kwargs)

File "/usr/local/lib/python3.7/site-packages/drf_social_oauth2/views.py" in dispatch
  37.         return super(CsrfExemptMixin, self).dispatch(*args, **kwargs)

File "/usr/local/lib/python3.7/site-packages/rest_framework/views.py" in dispatch
  505.             response = self.handle_exception(exc)

File "/usr/local/lib/python3.7/site-packages/rest_framework/views.py" in handle_exception
  465.             self.raise_uncaught_exception(exc)

File "/usr/local/lib/python3.7/site-packages/rest_framework/views.py" in raise_uncaught_exception
  476.         raise exc

File "/usr/local/lib/python3.7/site-packages/rest_framework/views.py" in dispatch
  502.             response = handler(request, *args, **kwargs)

File "/usr/local/lib/python3.7/site-packages/drf_social_oauth2/views.py" in post
  93.         url, headers, body, status = self.create_token_response(request._request)

File "/usr/local/lib/python3.7/site-packages/oauth2_provider/views/mixins.py" in create_token_response
  124.         return core.create_token_response(request)

File "/usr/local/lib/python3.7/site-packages/drf_social_oauth2/oauth2_backends.py" in create_token_response
  30.         return super(KeepRequestCore, self).create_token_response(request)

File "/usr/local/lib/python3.7/site-packages/oauth2_provider/oauth2_backends.py" in create_token_response
  149.                                                                   headers, extra_credentials)

File "/usr/local/lib/python3.7/site-packages/oauthlib/oauth2/rfc6749/endpoints/base.py" in wrapper
  116.             return f(endpoint, uri, *args, **kwargs)

File "/usr/local/lib/python3.7/site-packages/drf_social_oauth2/oauth2_endpoints.py" in create_token_response
  92.             request, self.default_token_type

File "/usr/local/lib/python3.7/site-packages/oauthlib/oauth2/rfc6749/grant_types/refresh_token.py" in create_token_response
  60.             self.validate_token_request(request)

File "/usr/local/lib/python3.7/site-packages/drf_social_oauth2/oauth2_grants.py" in validate_token_request
  100.             user = backend.do_auth(access_token=request.token)

File "/usr/local/lib/python3.7/site-packages/social_core/backends/apple.py" in do_auth
  146.         decoded_data = self.decode_id_token(jwt_string)

File "/usr/local/lib/python3.7/site-packages/social_core/backends/apple.py" in decode_id_token
  108.         public_key = RSAAlgorithm.from_jwk(self.get_apple_jwk(kid))

File "/usr/local/lib/python3.7/site-packages/social_core/backends/apple.py" in get_apple_jwk
  97.             return json.dumps([key for key in keys if key['kid'] == kid][0])

Exception Type: IndexError at /auth/convert-token
Exception Value: list index out of range
Request information:
USER: AnonymousUser

My request  was:
POST /auth/convert-token HTTP/1.1
> Host: localhost:8000
> User-Agent: insomnia/7.1.1
> Cookie: sessionid=""
> Content-Type: application/json
> Authorization: Bearer X5RMn....
> Accept: */*
> Content-Length: 599

{
   "grant_type":"convert_token",
"client_id": "4wQ,,,",
"client_secret": "KP8d....",
"backend": "apple-id",
"token": "eyJ0eXAiOiJKV1Q......"
}

I tested in this field "token". field, testing both with the token given by the backend, and also with the token generated as a secret.
To generate the secret use the following python script based on this link: link
import jwt
from datetime import datetime, timedelta

key = settings.SOCIAL_AUTH_APPLE_PRIVATE_KEY

headers = {"kid": settings.SOCIAL_AUTH_APPLE_KEY_ID}

payload = {
    "iss": settings.SOCIAL_AUTH_APPLE_TEAM_ID,
    "iat": datetime.now(),
    "exp": datetime.now() + timedelta(days=180),
    "aud": "https://appleid.apple.com",
    "sub": settings.CLIENT_ID,
}

client_secret = jwt.encode(payload, key, algorithm="ES256", headers=headers)

Thanks in advance and sorry for my basic English.

@cuococarlos does the client secret that you generated properly decode when you use a tool like https://jwt.io ?

@cuococarlos does the client secret that you generated properly decode when you use a tool like https://jwt.io ?

Thanks @rodgutierrez  , I use  https://jwt.io and I can check the client secret.
Later, i debug  in social-core library and I find the problem with the signature is expired, but the error don't say never about this.
I created PR in this project to  generate better feedback.PR in social-core apple backend

@cuococarlos thanks for raising your issue and for your PR in social-auth. Congrats by the way.

Thanks @wagnerdelima  , the pr was merged. I close that issue


feat: display collection profile in search result

Thank you for your contribution to the KodaDot - One Stop Shop for Polkadot NFTs.
👇 __ Let's make a quick check before the contribution.
PR Type

[ ] Bugfix
[x] Feature
[ ] Refactoring

Context

[x] Closes #5500
[ ] Requires deployment <snek/rubick/worker>

Before submitting pull request, please make sure:

[x] My contribution builds clean without any errors or warnings
[x] I've merged recent default branch -- main and I've no conflicts
[x] I've tried to respect high code quality standards
[x] I've didn't break any original functionality

Optional

[ ] I've tested it at </ksm/collection>
[ ] I've tested PR on mobile
[ ] I've written unit tests 🧪
[ ] I've found edge cases

Had issue bounty label?

[x] Fill up your KSM address: Payout

Community participation

[x] Are you at KodaDot Discord?

Screenshot 📸

[x] My fix has changed something on UI; a screenshot is best to understand changes for others.

Copilot Summary

🤖 Generated by Copilot at 120792d
Improved the appearance and functionality of the search result components, showing larger and better-styled NFT thumbnails and displaying the floor price and the number of units for collections and series. Modified SearchResultItem.vue and SearchSuggestion.vue files.

🤖 Generated by Copilot at 120792d

NFT thumbnails
bigger, styled, informative
showing floor price - spring

Sometimes doesn't work hmm

I don't see any related errors

Any idea why it doesn't work for me? I don't see any error console nor pending network request in console.

@floyd-li it actually returns in network well, yet it doesn't shows?
My thesis is that.. if resources comes later than in some "first batch", we don't swap the new resource, is that possible?

@floyd-li it actually returns in network well, yet it doesn't shows?
My thesis is that.. if resources comes later than in some "first batch", we don't swap the new resource, is that possible?

working on this

working on this

looks like it's working! 😍

Pls hide floor: 0 KSM where the collection has no item having a price.
Here is what opensea does in this case.

is it okay?

is it okay?

Yes, it looks good.

this was quick @floyd-li , love it!
pay 40 usd
let's look maybe on this one

https://github.com/kodadot/nft-gallery/issues/5725

😍 Perfect, I’ve sent the payout
💵 $40 @ 34.26 USD/KSM ~ 1.168 $KSM
🧗 EZiu1PjV2j2JHKxY6mHnFwwCRCoV27uHKQSkKXATSh1srJT
🔗 0x1ddbf6b06f6204ae1a2992bca766f4183d73b8e1fdf23815a1b3cbb29fcde35c
🪅 Let’s grab another issue and get rewarded!
🪄 github.com/kodadot/nft-gallery/issues


Illustrative Fortran

Illustrative Fortran is a work meant for beginning programmers in Fortran. Add to learn section.
www.illustrative-fortran.com

Illustrative Fortran seems to be an extensive resource, thanks for making it available and working on it, @agicelestial.


Treat setVIPById as SET_VIP_BY_ID instead of SET_V_I_P_BY_ID

The camelToScreamingSnake function would be great if it could treat setVIPById as SET_VIP_BY_ID instead of SET_V_I_P_BY_ID. Currently, I wrote it as setVipById. Test it out on Rambda REPL.

We've experienced this issue in the past as well, but haven't had a chance to fix it, and these days we're moving to MobX.

Ah, cool! Good luck!


[3.12.3] SSG/prerender broke

Environment

Operating System: Linux
Node Version:     v20.15.0
Nuxt Version:     3.12.3
CLI Version:      3.12.0
Nitro Version:    2.9.7
Package Manager<EMAIL_ADDRESS>Builder:          -
User Config:      future, devtools, experimental, devServer, runtimeConfig, ignore, app, components, imports, vue, modules, site, i18n, shadcn, css, primevue, svgo, features, colorMode, eslint, telemetry
Runtime Modules<EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS>Build Modules:    -

Reproduction
TBA if needed, a bit busy currently sorry.
Describe the bug
After upgrading from v3.12.2 to v3.12.3, SSG broke.
Additional context
No response
Logs
This is on v3.12.2, SSG still working:

frontend:build: [info] [nitro] Initializing prerenderer
frontend:build: [info] [nitro] Prerendering 5 initial routes with crawler
frontend:build: [log] [nitro]   ├─ /__sitemap__/style.xsl (27ms)
frontend:build: [log] [nitro]   ├─ /robots.txt (35ms)
frontend:build: [log] [nitro]   ├─ /200.html (81ms)
frontend:build: [log] [nitro]   ├─ /404.html (73ms)
frontend:build: [log] [nitro]   ├─ / (3338ms)
frontend:build: [log] [nitro]   ├─ /_payload.json?fe0c5c74-fd78-46a4-b0b9-b52b30f3e1a4 (14ms) (skipped)
frontend:build: [log] [nitro]   ├─ /__nuxt_island/IsSST_heipOnaRLn.json (6ms)
frontend:build: [log] [nitro]   ├─ /_payload.json (3ms)
frontend:build: [log] [nitro]   ├─ /seat (257ms)
frontend:build: [log] [nitro]   ├─ /seat/_payload.json?fe0c5c74-fd78-46a4-b0b9-b52b30f3e1a4 (7ms) (skipped)
frontend:build: [log] [nitro]   ├─ /seat/_payload.json (3ms)
frontend:build: [log] [nitro]   ├─ /favorite (405ms)
frontend:build: [log] [nitro]   ├─ /favorite/_payload.json?fe0c5c74-fd78-46a4-b0b9-b52b30f3e1a4 (5ms) (skipped)
frontend:build: [log] [nitro]   ├─ /favorite/_payload.json (3ms)
frontend:build: [log] [nitro]   ├─ /schedule ([591](https://git.gameloft.org/csd/workspace/-/jobs/7709018#L591)ms)
frontend:build: [log] [nitro]   ├─ /schedule/_payload.json?fe0c5c74-fd78-46a4-b0b9-b52b30f3e1a4 (4ms) (skipped)
frontend:build: [log] [nitro]   ├─ /schedule/_payload.json (3ms)
frontend:build: [log] [nitro]   ├─ /__og-image__/image/og.png (1214ms)
frontend:build: [log] [nitro]   ├─ /sitemap.xml (9ms)
frontend:build: [info] [nitro] Running link inspections...
frontend:build: [log] [nitro]   ├─ / [1 warning]
frontend:build: [log] [nitro]      /
frontend:build: [log] [nitro]         ⚠ Should have descriptive text. (link-text)
frontend:build: [log] [nitro]   ├─ /seat [1 warning]
frontend:build: [log] [nitro]      /
frontend:build: [log] [nitro]         ⚠ Should have descriptive text. (link-text)
frontend:build: [log] [nitro]   └─ /favorite [1 warning]
frontend:build: [log] [nitro]      /
frontend:build: [log] [nitro]         ⚠ Should have descriptive text. (link-text)
frontend:build: [log] [nitro]   ├─ /schedule [1 warning]
frontend:build: [log] [nitro]      /
frontend:build: [log] [nitro]         ⚠ Should have descriptive text. (link-text)
frontend:build: [info] [nitro] Prerendered 15 routes in 32.199 seconds
frontend:build: [success] [nitro] Generated public .output/public

This is on v3.12.3, SSG is broken:
frontend:build: [info] [nitro] Initializing prerenderer
frontend:build: [info] [nitro] Prerendering 4 initial routes with crawler
frontend:build: [log] [nitro]   ├─ /__sitemap__/style.xsl (17ms)
frontend:build: [log] [nitro]   ├─ /robots.txt (22ms)
frontend:build: [log] [nitro]   ├─ /200.html (48ms)
frontend:build: [log] [nitro]   ├─ /404.html (45ms)
frontend:build: [log] [nitro]   ├─ /sitemap.xml (14ms)
frontend:build: [info] [nitro] Prerendered 5 routes in 35.268 seconds
frontend:build: [success] [nitro] Generated public .output/public

Currently using this as workaround:
export default defineNuxtConfig({
  nitro: {
    prerender: {
      routes: ['/']
    }
  },
})

Originally posted by @danielroe in https://github.com/nuxt/nuxt/issues/27490#issuecomment-2162890462

Since 3.12.3, it works if you create pages/index.vue.
However, the default case (app.vue alone) still does not work.

Shortest bug description I can give you is that right now, with 3.12.3, this workflow is broken:

nuxi create tmp
cd tmp && yarn && yarn generate

It will say "You can now deploy .output/public to any static hosting" but you cannot. I guess that the simplest layout (just app.vue, no pages/ folder) is not supported by the static site generator.

Originally posted by @teajaymars in https://github.com/nuxt/nuxt/issues/28042#issuecomment-2210635263

Hi @manniL, my case seems to be different as I do have pages/index.vue,
I'll try to create a reproduction tomorrow, caught in a fever currently.

Here is a case that upgrade from 3.11.x to 3.12.3 will cause this problem.

I have this one as well. There are no pages rendered in SSG mode. I'm at 3.12.3

I'm also experiencing this since updating to 3.12.3
For me the workaround from NamesMT doesn't work.
The only thing that gives me a working homepage now is disabling SSG by renaming index.vue file to index.client.vue.
[slug].vue works just fine on the other hand.
Also, reverting to an earlier version of Nuxt doesn't resolve the issue, so assuming the bug might be in a dependency.
Unfortunately there is no helpful error thrown to debug with

Hi @manniL, @danielroe, hope the tagging doesn't bother you,
Just got out of my flu and did more testing, seems like it could be reproduced with the same procedure in #27490, that is, install nuxt-seo with robots module turned on.
I have update the repro for this issue (with Nuxt 3.12.3) here: https://github.com/NamesMT/repro-ssg-seo
I could confirm that the SSG generates normally when turning off robots (of course a pages/index.vue also required)


compile error

运行官方demo时候
报错
# go.opentelemetry.io/otel/sdk/resource
../../../../go/pkg/mod/go.opentelemetry.io/otel/sdk@v1.0.0-!r!c2/resource/process.go:141:75: semconv.ProcessCommandArgsKey.Array undefined (type attribute.Key has no field or method Array)

which demo?

@LetLetMe fixed the problem?

bye bye

remove "go.opentelemetry.io/otel" from go.mod and run go mod tidy


Exercise 5 Level 6: Incompatible type error

Hi, I don't understand why ? extends Maybe<? extends R> cannot be substituted with Maybe

I think this is because Maybe<? extends R> means that it is either Maybe<R> or in any Maybe with a type parameterisation that extends from R. In the second case, it cannot be directly converted to Maybe<R> and hence the error occurs. Perhaps the link below will be useful for you to understand this!
https://docs.oracle.com/javase/tutorial/java/generics/subtyping.html

I have exactly the same issue with you initially. If you look at the error given, you are trying to return a Maybe<? extends R> into a Maybe<R>. As of current, your mapper.apply(this,thing) returns a Maybe<? extends R>. Instead, what you should do is to find a way to make your mapper.apply(this,thing) returns a Maybe<R>. I hope this helps you to understand the error better.

Ah i get why there is an error now! Could you please give me some hints on how to convert Maybe<? extends R> to Maybe? I have been thinking for hours already yet I still dont know how to do :")

#178 might help! TL;DR: use a function that you've implemented previously.

@ziyi105 Hello! May I know your approach to this issue? I have the same exact problem as you

I used the orElse method to solve it!


Update CI files

Codecov Report

Merging #5 (f8afc99) into master (32c2804) will not change coverage.
The diff coverage is n/a.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.
@@           Coverage Diff           @@
##           master       #5   +/-   ##
=======================================
  Coverage   88.57%   88.57%
=======================================
  Files           1        1
  Lines          35       35
=======================================
  Hits           31       31
  Misses          4        4

Flag
Coverage Δ

unittests
88.57% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Update monte0x00 i3 rice

I deleted my previous repository, and now I renew it, this version of my i3 rice is much lighter and more stable.

Looks good! :fire:


add ldap authentication support

opsman 2.3 api supports ldap authentication https://docs.pivotal.io/pivotalcf/2-3/opsman-api/#setting-up-with-ldap
It would be nice to have this in the cli as an authentication method similar to saml and internal.
https://github.com/pivotal-cf/om/blob/master/docs/configure-authentication/README.md
https://github.com/pivotal-cf/om/blob/master/docs/configure-saml-authentication/README.md

@patrick-huber-pivotal, thanks for bringing this to our attention. We'd welcome a PR on this.

We are in a situation where we are required to use LDAP to authenticate to opsman, which is great that opsman 2.3 supports it, but now our automation won't work without using a non-ldap account. Is there any ETA on this?

Nope. Last update was accepting PRs at the moment.

Is there an ETA on when the next release will be cut? This option will be very useful for us.

Now!


Launchpad Scenario - Screenshot Update: Added setting button

Hello,
Scenario URL: https://developers.sap.com/tutorials/cp-portal-cloud-foundry-new-sapui5.html
Step 1: Click the Content Manager icon in the side panel to open the Content Manager.
Screenshot Update: Setting option is not there in old screenshot.
Please update the screenshot.
New screenshot:

Labels to be added:
Landscape label: Landscape label: trail1, trail2, trail3
Sprint Label: SCPTest-2101
Scenario label: SCPTest-psite
Prio: low-prio
Thanks,
Shubham Agarwal

Updated - you can close the ticket

Updated - you can close the ticket

@LindsayBert You can close your issues in this repository.

@LindsayBert You can close your issues in this repository.


add compat for HTTP 1.x

Added compat for HTTP 1.x.
Does not seem to require any changes except in Project.toml.
Also bumped version, anticipating a patch release.

I think I was mistaken. Local tests for the prometheus exported passed, but looks like there are other packages in this repo that fail unless they are all updated together..
Is it required to maintain the Manifest.toml files? How should the Manifest.toml be updated to match Project.toml? Is julia --project=. and Pkg.update() the recommended way?

Looks like the error is due to OpenTelemetryInstrumentationGenie.
I think we can safely merge this PR and fix the CI errors later.


[bugfix][diesel_cli] parse dbname from connection string in a way that still leaves bugs

I corrected to the parsing logic for database name in the connection string
When connecting to a new server, the database specified by the user
in the connection string may not exist. We instead make the first connection
to the default database which will always exist. We accomplish this by
editing the provided connection string to replace the database name with the
default database for the specific database backend.
MySQL and Postgres both have the same connection string format where the database
name appears after the third '/' character. In Postgres the database names continues
until a '?' or until the end of string. In MySQL the database name continues until
the end of the string. As a dirty hack, we parse all connection strings as if they
were Postgres connections, treating the dbname as any characters that occur between
the third '?' and the next '?'. This prevents us from using the '?' character
in the name of MySQL databases.

Can we use the URL crate here instead?

@sgrif Good idea. I tried it and found the URL crate is unable to parse the postgres percent encoded unix domain socket format (postgresql://%2Fvar%2Flib%2Fpostgresql/dbname), which is the one connection string format I actually need. Other than that the code is really short.
When you go to handling the error case, it looks like you are back to manually implementing regex.
fn change_database_of_url(database_url: &str, default_database: &str) -> (String, String) {
    let mut connection_string = match Url::parse(database_url) {
        Ok(string) => string,
        Err(_) => {println!("{}", database_url); panic!()},
    };
    let database: String = connection_string.path().trim_left_matches('/').to_string();
    connection_string.set_path(default_database);

    (database, connection_string.into_string())
}

Note that using URL crate will not solve the problem of being unable to use question mark character in the name of MySQL databases.

Since you're doing the work of parsing the connection strings, maybe it would be worthwhile to move it to a separate function and actually pull out all the info. Going off of the following cases:
    // These are the only possible results
    //   MySQL: ["mysql:", "", "[user[:password]@]host"]
    //   MySQL: ["mysql:", "", "[user[:password]@]host", "database_name"]
    //   Postgres: ["postgresql:", "", "[user[:password]@][netloc][:port]"]
    //   Postgres: ["postgresql:", "", "[user[:password]@][netloc][:port]", "dbname[?param1=value1&...]"]

you could pull everything out with a regex. This would also allow parsing mysql database names that have ? and passwords with non a-z characters (see issue #871 ). See playpen

@jaemk provided regex panics on r"postgresql://user@host:3200/dbname?param1=value1&p2=v2"
I think that before any more effort to implement connection string parsing is expended, we need to determine exactly what the grammar for Postgres and MySQL connection strings are. We have tried the route of "string split here and there" or run a quick regex which satisfies 95% of users but now the long tail has dragged itself out of the woods.
Aka: We need the specification for connection strings beyond just the cutesy "these are the parts of the connection string" provided by database online documentation. What characters are allowed in each part? Are there escapes? Once we have a complete specification we can proceed with firm footing. Otherwise this piece of code will be rewritten half a dozen times over coming years as each new technically correct connection strings slams into the "works for me" code merged by the previous voyager.

after reading the libpq source I can speak authoritatively that for Postgres that

the user cannot contain the characters '@' and '/' but can contain the ':' character
the password cannot contain the '@' or ':' character but can contain the '/' character
the netloc cannot contain the ':', '/', '?', or ',' characters
the dbname cannot contain the '?' character

Given the context dependent requirements for parsing, I doubt that a readable regex can be constructed to parse this string. It would be simpler to wire up rust C-bindings to the already functional postgres C code where the automata has been constructed by hand over several hundred lines.

@YetAnotherMinion If the full connection string spec needs to be met, then yes it may be beneficial to write up some C-bindings. On the otherhand, if connection strings are restricted to a reasonable subset, I think a regex would work fine. Here's an updated version for optional passwords playpen. The tricky part would be the : being allowed in the username.

@jaemk Obviously it is possible by definition to write a regex because that C parser is a finite automata. However there are two problems I forsee with regex based solution

Readability. Consider the email specification -- looks like an even simpler grammar than connection strings -- which has an ungodly long regex.
The full connection spec needs to be met. This simple pull request (which greatly expands subset of connection strings that will now be parsed correctly) has brought every #!@$ nitpicker out of the woodwork complaining how it is not perfect. It is apparent to me that only a perfectly standards compliant implementation will be allowed to merge.

I just want the correct functionality for non standard directory unix sockets to be available from upstream so I can stop screwing around with symlinks. The whole point of using a non standard directory was so I did not have to learn where each different distro's postgres package considers "default" .
The code sitting in front of you today satisfies:

if connection strings are restricted to a reasonable subset,

and does not pull in an extra dependency on the regex crate for the extremely simple use case of change the database name. That's it. The entire business requirement is only to parse the database name, nothing else.

This simple pull request (which greatly expands subset of connection strings that will now be parsed correctly) has brought every nitpicker out of the woodwork complaining how it is not perfect

Please be polite. There is no need to be offended at one additional person reviewing the code. I've been traveling since I left my previous comment, and haven't had a chance to look at the problem more in depth.

we need to determine exactly what the grammar for Postgres and MySQL connection strings are

Ok let's try to lay this out as explicitly as possible then. A valid connection string that we accept for MySQL or PostgreSQL is a subset of URLs which meet the following requirements:

The scheme MUST be one of the expected schemes for the adapter (postgres:// or postgresql:// for PG, mysql:// for MySQL).
The path MUST have exactly 0 or 1 segments
The fragment MUST NOT be present
The query MUST either not be present, or be represented as application/x-www-form-urlencoded, where all keys given are additional options expected by that backend

This means that the definition of how to extract the database name should authoritatively be:

Parse the URL
Validate the scheme
If the path length is greater than one, error
If the path length is zero, return the default database as determined by the scheme
Otherwise, return the result of percent_decoding the single path segment

I submit that the database C driver code is the final authority.

Since this applies to drivers other than libpq (and even our PG driver won't use libpq forever), I'd prefer to keep our specification separate. That said, I suspect that they will align more often than not.

Note that using URL crate will not solve the problem of being unable to use question mark character in the name of MySQL databases.

We should be respecting percent encoded question-marks. That is a separate bug, which should have a separate issue opened.

The full connection spec needs to be met.

No, we can fix one issue at a time, and open issues for each bug as they come in. My main concern is implementing our own pseudo-url-parser when there's already a crate out there for this.

I tried it and found the URL crate is unable to parse the postgres percent encoded unix domain socket format (postgresql://%2Fvar%2Flib%2Fpostgresql/dbname)

As best I can tell, that's a bug in the URL crate. Based on the URL spec, that host should be valid since postgresql is not a "special" host, meaning that the host should be parsed as an opaque host string, which does not percent decode its input. I'd open an issue against the URL crate. As a workaround, you can use the host query param instead.

@sgrif

Since this applies to drivers other than libpq (and even our PG driver won't use libpq forever), I'd prefer to keep our specification separate. That said, I suspect that they will align more often than not.

I do not understand your reasoning for deciding to introduce a new competing universal standard here, could you elaborate?
I understand that it is very tempting to change the specification to cover the case of shoving a potentially square peg into the off the shelf round hole by just banning square pegs.

No, we can fix one issue at a time, and open issues for each bug as they come in.

This is exactly what I do at work because my boss's incentive compensation is tied to average age of tickets. That line of thinking is what we all do 5 days a week at work, and it is exactly that approach that drive me nuts.  It is the weekend, it is my time, let cost-benefit of complete resolution be damned. I -- personally -- would strongly prefer to implement The Right Thing That Completely Addresses The Underlying Problem (tm).
I understand the aversion to writing lots of code. The best code is the lines you never write. However there is no business pressure to be quick right now. No manager pressuring you to just hack something together so you can close the ticket before lunch (to avoid that extra 30 minutes of time to close). We can take as long as we want to implement a robust, simple, and sound solution that completely solves the issue. No more connection string related issues is a glorious future that I can look forward to.

If the consensus is to use the URL crate then I can go to the URL repository, spend time to understand their code, submit PR, wait weeks to get it merged, wait more weeks to get a point release, come back here and introduce the fixed URL crate.
At this point I don't care about turnaround. My original hope was that I could fix the problem I encountered that Friday at work on my own time over the weekend so that crates.io would have the fixed version when I came into Monday. I was encouraged by the active Gitter channel, that I got a response to my questions, and even PR comments the next day. But then nothing happened and I had to go into work that Monday and spend time inserting the patched version of diesel into build farm and development images. That is just another sunk cost now.
The reason I am still here and willing to work on this is because I care about the elegant and correct. It would please me to be part of the "it just works" foundation of the world, where anyone in the future can switch to diesel, use their existing connection strings, and it always works. No chasing rabbit holes where you think the database was set up incorrectly (because coincidentally you just upgraded the OS for the developer image).
My argument against your proposal to require a URL grammar for connection strings is that it stands against the principle of least surprise. The least surprise for me would be to take an existing connection string from a working application, add it to diesel, and it always works. I don't think introducing a new proprietary format is the best tradeoff to make; against having a free internet volunteer spend an hour porting some while loops from C to Rust.

Appveyor cannot reach crates.io
    Updating registry `https://github.com/rust-lang/crates.io-index`
error: failed to load source for a dependency on `time`
Caused by:
  Unable to update registry https://github.com/rust-lang/crates.io-index
To learn more, run the command again with --verbose.

After examining URL RFC and the URL crate, I do not thing that getting percent encoding for the host will be free. out of

url            = httpurl | ftpurl | newsurl |
                 nntpurl | telneturl | gopherurl |
                 waisurl | mailtourl | fileurl |
                 prosperourl | otherurl

You are correct that the database connection strings are defined within the URL RFC
3.1. Common Internet Scheme Syntax. How
//<user>:<password>@<host>:<port>/<url-path>

   Some or all of the parts "<user>:<password>@", ":<password>",
   ":<port>", and "/<url-path>" may be excluded.  The scheme specific
   data start with a double slash "//" to indicate that it complies with
   the common Internet scheme syntax. The different components obey the
   following rules:

    user
        An optional user name. Some schemes (e.g., ftp) allow the
        specification of a user name.

    password
        An optional password. If present, it follows the user
        name separated from it by a colon.

   The user name (and password), if present, are followed by a
   commercial at-sign "@". Within the user and password field, any ":",
   "@", or "/" must be encoded.

However it looks like the URL crate only implements a subset of the grammar, specifically the subset useful for a browser. They do not have a generic parser for Common Internet Scheme Syntax. For web urls (http, https, ftp, gopher), percent encoding is not permitted in the host part. To use the URL crate it looks like you would need to introduce a new abstraction for  Common Internet Scheme Syntax and I am not sure how well that would be received as it is pretty orthogonal to the purpose of Servo's needs.

I'm going to go ahead and close this. Nobody on the team wants to deal with the rudeness on this PR, and it has merge conflicts that will require additional work from someone. If anyone wants to take this over and work on this without the attitude, feel free as there are still bugs to be addressed.

@sgrif  That is really unfortunate given that I gave you every change you asked for. You wanted to use the URL crate and I put that into the PR, you wanted to not handle every case, I put a panic! in for the todo.
I registered my strong objections to your design choices but in the patch I submitted over a month ago I put in exactly what you asked for and nothing more.


Chocolatey install method

Description
Install nodejs on windows servers using chocolatey
Issues Resolved
[List any existing issues this PR resolves]
Check List

[ ] All tests pass.
[ ] New functionality includes testing.
[ ] New functionality has been documented in the README if applicable

There is no windows test in the ci/cd.  This feature needs to be tested locally.

@MarkGibbons did you intend on the windows platform to be included on any of the other suites or just the chocolately suite? I tried a few of the other suites and they aren't working.

Nope, windows should have been excluded from the other test suites.

@ramereth thanks for hanging in there on the reviews.  I'm fitting in work on this during 10 minute breaks and early mornings mostly.  Working 4 different branches so every once in a while the responses go wrong.  Appreciate the comments.

@MarkGibbons no problem! Thanks for putting up with my reviews! I'll get this released soon.


Update

Why:
Closes [issue link]

What's being changed:

Check off the following:

[ ] I have reviewed my changes in staging (look for "Automatically generated comment" and click Modified to view your latest changes).
[ ] For content changes, I have completed the self-review checklist.

Writer impact (This section is for GitHub staff members only):

[ ] This pull request impacts the contribution experience

[ ] I have added the 'writer impact' label
[ ] I have added a description and/or a video demo of the changes below (e.g. a "before and after video")

Далбоебсик ты
ср, 9 лют. 2022, 05:52 користувач welcome[bot] @.***>
пише:

Thanks for opening this pull request! A GitHub docs team member should be
by to give feedback soon. In the meantime, please check out the contributing
guidelines https://github.com/github/docs/blob/main/CONTRIBUTING.md.
—
Reply to this email directly, view it on GitHub
https://github.com/github/docs/pull/15274#issuecomment-1033315657, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AUKM7YO7HRVDZAQX2YR2XDDU2HQIBANCNFSM5N4KAOWA
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>