pyscf: 2.3.0 -> 2.4.0

Description of changes
https://github.com/pyscf/pyscf/releases/tag/v2.4.0
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[x] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

@GrahamcOfBorg build python3Packages.pyscf

The darwin x86-64 failure is a simple timeout on the builder but up to that point the test suite ran fine.


Write new pipeline editor UI

We kind of have this, further tickets can be raised for more UI work


Set delta callback in Shadow test

In response to #825
Adds a (different) delta callback in the update callback test; this will ensure that the correct function is being set.

/bot run checks

/bot run checks


How to Init Hash navigation

I'm trying to use the basic hash navigation. However unless I do a router.navigate(''), the router does not get init.
So when I call
domain.com or domain.com/ it should hit the router and be init-ed to
domain.com/#/home
Any Idea how to do this ?

For Grapnel to remain unobtrusive, it's up to your app to call router.navigate() to initialize subsequent events.


[BUG] When using ClientCertificateCredential to connect to azure inputstream isn't closed used by the pfx file

Hi,
When using ClientCertificateCredential  to connect to azure.
After getting the certificate and public/private key form the fix file
The application doesn't close the stream,
See identityClient -> getCertificateBytes
identityClient  -> getCertificateInputStream
Should close the stream after getting all results.
Thanks,
Itay

Hi @rickle-msft
Are you aware of this issue?
Thanks,
Itay

Hi @rickle-msft
Are you aware of this issue?
Thanks,
Itay

Hey, @ihudedi I was not aware of it. @g2vinay can help you out more with the identity package.

Hey, @ihudedi I was not aware of it. @g2vinay can help you out more with the identity package.

@ihudedi  Thanks for reporting this issue.
Investigating this and will add the fix as needed. Will update soon.

@ihudedi  Thanks for reporting this issue.
Investigating this and will add the fix as needed. Will update soon.

Hi @g2vinay
Thanks for the response.
Itay

Hi @g2vinay
Thanks for the response.
Itay

@ihudedi
The fix for this issue has been released.
Use the latest identity dependency in your application:
<dependency>
  <groupId>com.azure</groupId>
  <artifactId>azure-identity</artifactId>
  <version>1.2.5</version>
</dependency>

Let us know if you need any further help on this issue.


Notice headline inform about discontinue Cryptowar (on top of the game) after 6/6

It should link to the announcement article

@VinhTruong2001 can you complete this asap to avoid misunderstanding from users because many users not being aware of this

Yes, I'm done


fix(Page): Use _pageBindings as a Map

In accordance with its declared type, Map<string, Function>.
Currently, it is used as a plain old JS object. The compiler marks this
usage as an error when noImplicitAny: true. This change switches to
use the appropriate Map methods has/get/set.
Fixes #3000

I missed the rule that says scopes are lowercase. How do you prefer that I fix the commit title?


telenet.tv.xml EPG is 3 weeks old

Hi
I'm kinda new in the IPTV scene.
I see that the EPG telenet.tv.xml (Belgium) is 3 weeks old.
How can I "create" this XML myself? OR are there mirrors available?
Tnx

Hi, this repo has been closed for 3 weeks until yesterday.
Epg files will be updated once #2017 is done

hello
he doesn't work for me either, I wonder when he'll co tvplus-and.digiturk.and.dsmart no work  please, I'm waiting for news
thanks

That was fast... Seems to be fixed!

I was 100% sure that telenet.tv.xml was updated earlier today, but now it's 3 weeks old again. Strange...

grab it for a while from another site, there are multiple options, just google it
(I recommend bevy.be myself)

I'm using Webgrabplus for now to compile an EPG myself, but TNX!

Epg files will be updated once https://github.com/iptv-org/epg/issues/2017 is done


fix nan handling with zero heatmaps

Replace uniform heatmaps with zero heatmaps when labels have NaNs

It passed pytests on my side so I think it should work

looks good to me!


Keep it Simple :)

That was meant to be to show it works with something other than the Roman alphabet (reversed)

Reversed it :)


fixed#213-show dialogbox

closes https://github.com/odk-x/tool-suite-X/issues/213
demo: https://drive.google.com/file/d/1dKjK1Uy_8JSzcCQv9YhP3XCIoHmoxLRx/view?usp=sharing

runtests

@maprehensive please review to make sure it works like you envision.

@maprehensive please review to make sure it works like you envision.

@maprehensive please review to make sure it works like you envision so it will count as completed contribution.

Sure!! @maprehensive


Wal

caution this is not finished and needs rebase no need to review yet :)
todo:

~checkpoint with async io~
fsync on wal writes
~run_once on checkpoint while io~
~reset wal~

Hey @pereman2!
I was testing this with an existing SQLite database:
penberg@vonneumann limbo % sqlite3 foo.db
SQLite version 3.45.2 2024-03-12 11:06:23
Enter ".help" for usage hints.
sqlite> PRAGMA journal_mode = WAL;
wal
sqlite> CREATE TABLE users (id INT, email TEXT);
sqlite> INSERT INTO users VALUES (1, 'penberg@iki.fi');
sqlite>

but am hitting the following error when I attempt to insert with Limbo:
penberg@vonneumann limbo % cargo run foo.db
Limbo v0.0.2
Enter ".help" for usage hints.
limbo> .schema
CREATE TABLE users (id INT, email TEXT);
limbo> SELECT * FROM users;
<EMAIL_ADDRESS>limbo> INSERT INTO users VALUES (2, 'penberg@gmail.com');
thread 'main' panicked at core/sqlite3_ondisk.rs:502:25:
already borrowed: BorrowMutError
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

@penberg ahggg thanks for the testing. I should mark this a wip again. I've had to redesign a lot to include fsync as now there is a state machine while doing commit/flush

peristocles :: ~/fun/limbo » rm foo.db
peristocles :: ~/fun/limbo » sqlite3 foo.db
SQLite version 3.43.2 2023-10-10 13:08:14
Enter ".help" for usage hints.
sqlite> PRAGMA journal_mode = WAL;
wal
sqlite> CREATE TABLE users (id INT, email TEXT);
sqlite> INSERT INTO users VALUES (1, 'penberg@iki.fi');
sqlite> ^D

    Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.36s
     Running `target/debug/limbo foo.db`
syncing
Limbo v0.0.4
Enter ".help" for usage hints.
limbo> .schema
CREATE TABLE users (id INT, email TEXT);
syncing
limbo> select * from users;
<EMAIL_ADDRESS>syncing
syncing
limbo> INSERT INTO users VALUES (2, 'penberg@gmail.com');

@penberg I couldn't reproduce it

I will fix linux IO uring stuff tomorrow once I get access to my linux pc


Frc3620

Add the ability to turn off the FRC900 cosine compensator in SwerveModule.java. Existing JSON configurations will continue to use it; one will have to be explicit to turn it off, and leaving the setting out of the JSON will leave it turned on as it is now.

I can, but I don't understand what that does. I looked at it, and didn't understand how it addressed the issue I was having.
On Tuesday, January 23, 2024 at 10:40:32 PM EST, T Grinch<EMAIL_ADDRESS>wrote:

Can you add the other patch where if desired speed velocity is 0 then cosine scalar is 0 too.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you authored the thread.Message ID: @.***>

Yes. Will do this afternoon.
On Thu, Jan 25, 2024 at 1:36 AM, T @.***> wrote:
Can you fix the merge conflicts?
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you authored the thread.Message ID: @.***>

Can you fix the merge conflicts?

done.


Weired Runtime Error during Inference

I have fine-tuned Llama-2 13-B chat model saved locally in my system [ Linux OS ]
When I am running the following code :-
from model.ea_model import EaModel
from pathlib import Path
import torch
from fastchat.model import get_conversation_template
import os
device = "cuda:0"
base_model_path="llama"
EAGLE_model_path="yuhuili/EAGLE-llama2-chat-13B"
model = EaModel.from_pretrained(
base_model_path=base_model_path,
ea_model_path=EAGLE_model_path,
torch_dtype=torch.float16,
low_cpu_mem_usage=True,
#map_location='cuda:0'
device_map=device
)
model.eval()
ues_llama_2_chat=1
use_vicuna=0
your_message="Hello"
if ues_llama_2_chat:
conv = get_conversation_template("llama-2-chat")
sys_p = "You are a helpful, respectful and honest assistant. Always answer as helpfully as possible, while being safe.  Your answers should not include any harmful, unethical, racist, sexist, toxic, dangerous, or illegal content. Please ensure that your responses are socially unbiased and positive in nature.\n\nIf a question does not make any sense, or is not factually coherent, explain why instead of answering something not correct. If you don't know the answer to a question, please don't share false information."

Traceback (most recent call last):
File "/home/azureuser/tensorrtllm_backend/llama-experiments/EAGLE/sample_code.py", line 45, in
output_ids=model.eagenerate(input_ids,temperature=0.5,max_new_tokens=512)
File "/usr/local/lib/python3.10/dist-packages/torch/utils/_contextlib.py", line 115, in decorate_context
return func(*args, **kwargs)
File "/home/azureuser/tensorrtllm_backend/llama-experiments/EAGLE/model/ea_model.py", line 218, in eagenerate
tree_logits, logits, hidden_state, sample_token = initialize_tree(
File "/home/azureuser/tensorrtllm_backend/llama-experiments/EAGLE/model/utils.py", line 164, in initialize_tree
tree_logits, outputs, logits,hidden_state,sample_token = model(
File "/usr/local/lib/python3.10/dist-packages/torch/nn/modules/module.py", line 1501, in _call_impl
return forward_call(*args, **kwargs)
File "/home/azureuser/tensorrtllm_backend/llama-experiments/EAGLE/model/ea_model.py", line 159, in forward
ea_logits = self.ea_layer.topK_genrate(hidden_states, input_ids, self.base_model.lm_head, logits_processor)
File "/usr/local/lib/python3.10/dist-packages/torch/utils/_contextlib.py", line 115, in decorate_context
return func(*args, **kwargs)
File "/home/azureuser/tensorrtllm_backend/llama-experiments/EAGLE/model/cnets.py", line 867, in topK_genrate
topk_index,topk_prob=self.sample(last_headout,logits_processor,k=top_k,)
File "/home/azureuser/tensorrtllm_backend/llama-experiments/EAGLE/model/cnets.py", line 805, in sample
sampled_indices = torch.multinomial(probabilities, k, replacement=False)
RuntimeError: CUDA error: device-side assert triggered
CUDA kernel errors might be asynchronously reported at some other API call, so the stacktrace below might be incorrect.
For debugging consider passing CUDA_LAUNCH_BLOCKING=1.
Compile with TORCH_USE_CUDA_DSA to enable device-side assertions.
When I am running the above code after setting os.environ["CUDA_VISIBLE_DEVICES"] = "1", I am getting the following runtime error -
Traceback (most recent call last):
File "/home/azureuser/tensorrtllm_backend/llama-experiments/EAGLE/sample_code.py", line 12, in
model = EaModel.from_pretrained(
File "/home/azureuser/tensorrtllm_backend/llama-experiments/EAGLE/model/ea_model.py", line 118, in from_pretrained
ea_layer_state_dict = torch.load(load_model_path,
File "/usr/local/lib/python3.10/dist-packages/torch/serialization.py", line 809, in load
return _load(opened_zipfile, map_location, pickle_module, **pickle_load_args)
File "/usr/local/lib/python3.10/dist-packages/torch/serialization.py", line 1172, in _load
result = unpickler.load()
File "/usr/local/lib/python3.10/dist-packages/torch/serialization.py", line 1142, in persistent_load
typed_storage = load_tensor(dtype, nbytes, key, _maybe_decode_ascii(location))
File "/usr/local/lib/python3.10/dist-packages/torch/serialization.py", line 1116, in load_tensor
wrap_storage=restore_location(storage, location),
File "/usr/local/lib/python3.10/dist-packages/torch/serialization.py", line 1086, in restore_location
return default_restore_location(storage, str(map_location))
File "/usr/local/lib/python3.10/dist-packages/torch/serialization.py", line 217, in default_restore_location
result = fn(storage, location)
File "/usr/local/lib/python3.10/dist-packages/torch/serialization.py", line 182, in _cuda_deserialize
device = validate_cuda_device(location)
File "/usr/local/lib/python3.10/dist-packages/torch/serialization.py", line 173, in validate_cuda_device
raise RuntimeError('Attempting to deserialize object on CUDA device '
RuntimeError: Attempting to deserialize object on CUDA device 0 but torch.cuda.device_count() is 0. Please use torch.load with map_location to map your storages to an existing device.

Attempting to deserialize object on CUDA device 0 but torch.cuda.device_count() is 0.

It seems that your GPU is unavailable

Attempting to deserialize object on CUDA device 0 but torch.cuda.device_count() is 0.

It seems that your GPU is unavailable

When I am loading the finetuned model from my local disk am facing the above issue , but when I try to load a pre-trained model from Huggingface am not facing any issue


Powertools 1.12.2 with graalvm

Issue #, if available:
Description of changes:
Added reflect config for powertools , dependencies of powertools in pom and annotations for logging, metrics and tracing in java classes.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

The GraalVM native-image configuration would be better placed directly into the Powertools project, so that customers wouldn't have to add it to their individual projects.


2.0.5 did not start due to missed tables

I try to use 2.0.5 and if fails by default:
org.springframework.context.ApplicationContextException: Failed to start bean 'quartzScheduler'; nested exception is org.springframework.scheduling.SchedulingException: Could not start Quartz Scheduler; nested exception is org.quartz.SchedulerConfigException: Failure occured during job recovery. [See nested exception: org.quartz.impl.jdbcjobstore.LockException: Failure obtaining db row lock: Table 'localShema.QRTZ_LOCKS' doesn't exist [See nested exception: com.mysql.jdbc.exceptions.jdbc4.MySQLSyntaxErrorException: Table 'localShema.QRTZ_LOCKS' doesn't exist]
It needs some database layout, but did not create it by itself, also I can not find any sql script to create all needed db stuff.

This is double of https://github.com/grails-plugins/grails-quartz/issues/50. I am already propose the pull request, I am don't undestend why owner does not apply it. I think your debug problem linked with this, maybe you better play with 2.0.1, as i see by commits between them is not a big difference.

Alex, thanks. But do you have sql script for creating all need db layout? I want to launch 2.0.5 anyway, so need to create layout manually.

https://quartz-scheduler.org/downloads, Docs\DBTables in archive

+1 on this issue

we can't auto create the tables, the proper schema needs to be applied for
the ddl for your database from the quartz distribution. If you don't have a
database set the jdbcstore to false in the config and it will use the ram
store.
On Tue, Feb 16, 2016 at 1:33 PM, tolyo<EMAIL_ADDRESS>wrote:

+1 on this issue
—
Reply to this email directly or view it on GitHub
https://github.com/grails-plugins/grails-quartz/issues/55#issuecomment-184844990
.

Please publish the version 2.0.6 , my patch already in it. Otherwise ramstore is not working with hibernate.

2.0.6 has published from bug #50  - however the plugin will not create tables for you, as I said you have to use the DDL supplied with quartz distro for your particular database.


Added ability to adjust tap and pair key delays

Added basic functionality for users to adjust keyboard delay. What is the 200 delay on line 261 represent? Is this another value that should be adjusted? I couldn't tell exactly what was happening there with my basic understanding of the codebase currently

The 200 ms delay is used to distinguish between Tap-key and fast typing. If we type D (a Tap-key) andU fast, U is pressed before D is released, and D is released before Uis released.

When dt1 < 500 and dt1 > 200, consider it as fast typing
When dt1 < 500 and dt2 > 200, use it as a composite key

     D down    U down   D up     U up
      |         |        ^        ^
      v         v        |        |
------+---------+--------+--------+---------> t

      <--------> <------>
         dt1       dt2

200 is a threshold of dt2. Maybe we should set the threshold based on dt1.
By the way, I was thinking to change is_tapped to is_tap_key. How do you think?

Ok that makes sense. I made that an adjustable property as well. I thought abotu a good way to make it dependent on dt1, but I think people will like to be able to tweak each value individually.
Also I like the name change to is_tap_key I think it makes it more clear what it is checking. I made this change as well.


DockerCompose build-arg

How do I pass build-arg in DockerCompose Task?

You can pass the build arguments for docker compose command in the following format-
build --build-arg key-value. (Refer to link)
Example as in picture below-


Annotate and export as tsv

Hello,
I've loaded only about 1000 variants filtered external to gemini. I'd like to annotate and dump into a tsv for building some reports. Is there any pre-cooked annotate and export functionality? Is there a recommended query to jointly select across all the relevant annotation tables?
Thanks!

what other tables do you want to join?

All the gene and variant anno I can get!


perf(ui/index-bar): add class and call function

Codecov Report

Merging #395 (2c8331c) into dev (af630c9) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##              dev     #395   +/-   ##
=======================================
  Coverage   96.48%   96.48%
=======================================
  Files         217      217
  Lines        5092     5096    +4
  Branches      989      987    -2
=======================================
+ Hits         4913     4917    +4
  Misses        175      175
  Partials        4        4

Impacted Files
Coverage Δ

...rc/bottom-navigation-item/BottomNavigationItem.vue
100.00% <ø> (ø)

packages/varlet-ui/src/checkbox/Checkbox.vue
100.00% <ø> (ø)

...ackages/varlet-ui/src/index-anchor/IndexAnchor.vue
91.66% <100.00%> (+0.75%)
:arrow_up:

packages/varlet-ui/src/index-bar/IndexBar.vue
94.11% <100.00%> (+0.17%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update af630c9...2c8331c. Read the comment docs.


Update create-swap-file-linux-vm.md

Changed wording simplified steps leaving custom path options instructions in NOTE!'s
Pull request guidance
Thank you for your contribution. The content team is monitoring the pull requests. Once your pull request is ready for review, please add a comment such as "PR is ready for review".

@markusries I made some editorial changes to your content. Could you help review if they are fine? If no problem, we will merge this PR. Thanks.


Remove Watermark missing in home page

The page remove-watermark page is missing in the home page:

This is expected
The feature was removed and isn't expected to be used


Allow specifying data with the Inference API wrapper

This is required to be able to make inference with images and audios.

Friendly ping @LysandreJik  :)

 dataset = datasets.load_dataset("Narsil/image_dummy", "image", split="test") contains them https://huggingface.co/datasets/Narsil/image_dummy/tree/main


Complex expressions mixed with simple class expression renders incorrectly for domain and range restrictions.

Describe the bug
Domain and range restrictions are not rendered when they complex.
To Reproduce
See for example RO_0001025.

Expected behavior
In the above example domain and range should render as follows:
Domain

independent continuant
(independent continuant and not spatial region)

Range

independent continuant
(independent continuant and not spatial region)

A potentially related issue happens for properties where has_dbxref and has_definition give unknown class expression errors.
Example:


Optimize bundle size (now 317KB with v4)

Hi, this is not an issue but i'd like to know if there is some room to improve the bundle size, or if  there is something i can do as a user to reduce the size. currently it is like this:
https://bundlephobia.com/result?p=<EMAIL_ADDRESS>There seem to be some components which are rather big in comparision for example TablePagination SwipeableDrawer TabScrollButton
I was unable to check for the v5 though yet. Will it improve?

@masbaehr You can track the bundle size of v5 using https://bundlephobia.com/result?p=@material-ui/core@next. We have made significant progress:

split IE11 into a different bundle -6kB
migrate to emotion -5kB
Popper.js v2 upgrade -700B

We still have a few opportunities to improve bundle size with better tree-shaking between components:

#21782 should significantly reduce the cost of a standalone TextField component
https://github.com/mui-org/material-ui-pickers/issues/1670 surface how the architecture of the date pickers might be wrong

@masbaehr You can track the bundle size of v5 using https://bundlephobia.com/result?p=@material-ui/core@next. We have made significant progress:

split IE11 into a different bundle -6kB
migrate to emotion -5kB
Popper.js v2 upgrade -700B

We still have a few opportunities to improve bundle size with better tree-shaking between components:

#21782 should significantly reduce the cost of a standalone TextField component
https://github.com/mui-org/material-ui-pickers/issues/1670 surface how the architecture of the date pickers might be wrong

⚠ the total cost is almost useless, nobody imports all the components in a single page.

Instead, consider the cost of individual modules but consider that when importing two modules, the bundle size isn't the addition of the two reported sizes, there is a lot of shared modules.

⚠ the total cost is almost useless, nobody imports all the components in a single page.

Instead, consider the cost of individual modules but consider that when importing two modules, the bundle size isn't the addition of the two reported sizes, there is a lot of shared modules.

In a single page - this is true. But isn't everything still packed into one *.chunk.js file? That is at least the case if you're not using code-splitting. I already do this for heavy stuff like recharts, but material-ui being something which is needed almost everywhere I find it rather hard to do this. Throughout all the pages, I use most of the components somewhere. While 381k 111k gzipped is not much per se, the thing is, it adds up rather quickly.

In a single page - this is true. But isn't everything still packed into one *.chunk.js file? That is at least the case if you're not using code-splitting. I already do this for heavy stuff like recharts, but material-ui being something which is needed almost everywhere I find it rather hard to do this. Throughout all the pages, I use most of the components somewhere. While 381k 111k gzipped is not much per se, the thing is, it adds up rather quickly.

While 381k 111k gzipped is not much per se, the thing is, it adds up rather quickly.

With what does it add up though? Most of the components implement base UI patterns on the web. We don't recommend that you import 3 different Autocomplete implementations in your page. So it shouldn't ever add up in your bundle.

I already do this for heavy stuff like recharts, but material-ui being something which is needed almost everywhere I find it rather hard to do this.

What makes this easier to do with recharts but not Material-UI?
Again, are you importing all of material-ui everywhere?
It would be more helpful to share the bundle you're currently shipping. That helps us finding duplicates  we can potentially eliminate. For example, maybe most of our users need a different popper library in which case we should use that instead of @popperjs/core. Or maybe there are other Autocomplete implementations that are preferred over our solution. A blanket "reduce the bundle size" is not actionable for us since we always try to reduce our footprint on the final bundle. It falls under the same category as "make components more accessible" or "make components faster" or "add more components".

While 381k 111k gzipped is not much per se, the thing is, it adds up rather quickly.

With what does it add up though? Most of the components implement base UI patterns on the web. We don't recommend that you import 3 different Autocomplete implementations in your page. So it shouldn't ever add up in your bundle.

I already do this for heavy stuff like recharts, but material-ui being something which is needed almost everywhere I find it rather hard to do this.

What makes this easier to do with recharts but not Material-UI?
Again, are you importing all of material-ui everywhere?
It would be more helpful to share the bundle you're currently shipping. That helps us finding duplicates  we can potentially eliminate. For example, maybe most of our users need a different popper library in which case we should use that instead of @popperjs/core. Or maybe there are other Autocomplete implementations that are preferred over our solution. A blanket "reduce the bundle size" is not actionable for us since we always try to reduce our footprint on the final bundle. It falls under the same category as "make components more accessible" or "make components faster" or "add more components".

I have some heavier dependencies like jodit editor (600KB) or the already mentioned recharts (645KB) - which i have now externalized using lazy loading patterns.  I never have imported all of material ui in the pages only some parts of it.
So i just noticed material-ui being a large portion of it. But i understand your point i'm not ranting i just wanted to ask if there is some room for improvement. Maybe even improvement i can personally apply for material-ui.
E.g if i never import the yellowish marked components, will they be removed from the bundle?
I know there are some other dependencies which can probably be replaced. This is what i will do next, going trough them one-by-one

I have some heavier dependencies like jodit editor (600KB) or the already mentioned recharts (645KB) - which i have now externalized using lazy loading patterns.  I never have imported all of material ui in the pages only some parts of it.
So i just noticed material-ui being a large portion of it. But i understand your point i'm not ranting i just wanted to ask if there is some room for improvement. Maybe even improvement i can personally apply for material-ui.
E.g if i never import the yellowish marked components, will they be removed from the bundle?
I know there are some other dependencies which can probably be replaced. This is what i will do next, going trough them one-by-one

I never have imported all of material ui in the pages only some parts of it.

From the the bundle screenshot you posted it looks like you do import all of Material-UI.
Other notes: material-ui-phone-number being 100kB big is suspicious. They have a dependency on lodash and are published as commonJS so I do suspect they're bundling all of lodash.

I never have imported all of material ui in the pages only some parts of it.

From the the bundle screenshot you posted it looks like you do import all of Material-UI.
Other notes: material-ui-phone-number being 100kB big is suspicious. They have a dependency on lodash and are published as commonJS so I do suspect they're bundling all of lodash.

This is how i usually do the imports where i need something in material-ui

Curious fact: I never imported SwipeableDrawer , but it is being built into the file. Any reason why this is? (I use Drawer though)

This is how i usually do the imports where i need something in material-ui

Curious fact: I never imported SwipeableDrawer , but it is being built into the file. Any reason why this is? (I use Drawer though)

Curious fact: I never imported SwipeableDrawer , but it is being built into the file. Any reason why this is? (I use Drawer though)

Something in your app is responsible for importing all of Material-UI it seems.

Curious fact: I never imported SwipeableDrawer , but it is being built into the file. Any reason why this is? (I use Drawer though)

Something in your app is responsible for importing all of Material-UI it seems.

https://github.com/material-table-core/core/issues/45 Maybe it's material-table triggering it

https://github.com/material-table-core/core/issues/45 Maybe it's material-table triggering it


Remove unused outer queue in flatmap subscriber

I've looked at the code and it seems correct. I believe I dropped the queue a few months/years ago without removing the code using that queue.

Tests pass and I think we have good coverage for the various execution paths here, so I think it's correct.

@ozangunalp Can you please rebase?

@jponge rebased

I hereby declare @ozangunalp a drain-loop expert.

ahah wait at least until the next PR :)

Ah @ozangunalp we need your commits to be GnuPG-signed


⚠ Shadow's Blogosphere has degraded performance

In c6adaaf, Shadow's Blogosphere (https://blog.everythingbagel.me) experienced degraded performance:

HTTP code: 200
Response time: 3041 ms

Resolved: Shadow's Blogosphere performance has improved in ff6f013 after 5 minutes.


[FLINK-11869] Make buffer size in checkpoint stream factory configurable

What is the purpose of the change
Currently, the default buffer size for FsCheckpointStreamFactory is only 4KB. This would case a lot of IOPS if stream is large. This PR would make that configurable.
Brief change log

Add new option state.backend.fs.buffer-size in CheckpointingOptions.
Introduce writeBufferSize in the constructor of  FsCheckpointStreamFactory and related classes.

Verifying this change
This change added tests and can be verified as follows:

Verify the writeBufferSize is configurable in StateBackendLoadingTest

Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): no
The public API, i.e., is any changed class annotated with @Public(Evolving): no
The serializers: no
The runtime per-record code paths (performance sensitive): no
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: no
The S3 file system connector: no

Documentation

Does this pull request introduce a new feature? yes
If yes, how is the feature documented? docs/ JavaDocs

@flinkbot attention @StefanRRichter

CC @tzulitai

This looks good to merge! +1
One small comment before merging @Myasuka -
what do you think about renaming the config key to state.backend.fs.write-buffer-size? Would that be clearer for what the config does than the current naming?

@tzulitai sounds reasonable, I would refactor this config key.

Merging ...


updated some doc links

I thought we might want to point people to the latest reference of MSBuild on docs. Also, removed locale and product family version from the msdn links so they go to the latest and to the locale specified by the user in their machine.

Looks good, thanks!


SSL certificate on demo page expired

Describe the bug
https://demo.stumpapp.dev/ could not be successfully viewed because the SSL certificate has expired.
Screenshots

Desktop (please complete the following information):

OS: Ubuntu 24.04, Windows 11

Thanks for reporting this! I’ll fix it once I’m by a computer again (probably tomorrow). Sorry you can’t try it out in the meantime, but I’ll close this issue once it’s back up.

Yeah so it appears the auto-renewing cert logic I had configured broke from the Google-to-Squarespace migration 😩 I don't expect to have time to fix this for bit, so the demo will be down in the meantime.


Added AI base chatbot

issue #89
https://github.com/user-attachments/assets/929d0fa7-5662-4ef4-b1a3-714fabc05425
i have added an AI-based chatbot trained on our website data! Here, you can ask anything about our site, and it will provide accurate answers. Plus, it can generate responses tailored to your inquiries.
Can i get level 3 for it ?

@Krishi1211  is there any issue why it doesn't get merged?

@Sawan-Kushwah sorry for the delay
Currently we have very limited level 3 pr allowed so level 2 is the max which we can give

@Krishi1211 okay no worry i can understand it !


Feature request: Set preferredContentSize

Hi, thanks for making this!
I was watching the WWDC sheets session and at around the 9:15 mark, Russell mentions that the sheet should respect a preferredContentSize if widthFollowsPreferredContentSizeWhenEdgeAttached = true.
I was wondering if it would be possible to automatically set preferredContentSize in this component to something like view.systemLayoutSizeFitting(UIView.layoutFittingCompressedSize) so that the sheet only takes up the width of the contentView?
Or alternatively provide a way to set a preferredContentSize?
I failed to get this to work, but I was hoping you would know how to do it.
Here's the example from the session:
Before:

After:

Thanks for the suggestion. After spending some time looking into it, SwiftUI doesn't appear to work very well with preferredContentSize and have seen others file feedback for similar issues. I'll keep looking into it to see if I can find a solution.


model load from recorder.load_object() missing _fitted variable

🐛 Bug Description
model loaded from recorder.load_object() missing _fitted variable. Not sure whether it is caused by pickle.dump or pickle.load
To Reproduce
Steps to reproduce the behavior:

model = init_instance_by_config(task["model"]), the model can be LSTM from pytorch

with R.start(experiment_name="train_model"):
    R.log_params(**flatten_dict(task))
    model.fit(dataset, save_path = ".model-pytorch")
    R.save_objects(trained_model=model)
    recorder = R.get_recorder()

with R.start(experiment_name="backtest_analysis"):
    recorder = R.get_recorder(rid, experiment_name="train_model")
    model = recorder.load_object("trained_model")

    # prediction
    recorder = R.get_recorder()
    ba_rid = recorder.id
    sr = SignalRecord(model, dataset, recorder)
    sr.generate()

It will return error saying _fitted not exist.
Expected Behavior
recorder.load_object should be able to load all variables in LSTM class
Environment
Note: User could run cd scripts && python collect_info.py all under project directory to get system information
and paste them here directly.

Qlib version:0.6.1.dev0
Python version: 3.7
OS (Windows, Linux, MacOS): Linux
Pytorch: 1.7.1+cu101

Many objects are subclasses of Serializable https://github.com/microsoft/qlib/blob/main/qlib/model/base.py#L8
So only part of data will be dumped into pickle file.
If you want to dump more data for a specific instance,  you could override  some methods in this class
Thanks

Many objects are subclasses of Serializable https://github.com/microsoft/qlib/blob/main/qlib/model/base.py#L8
So only part of data will be dumped into pickle file.
If you want to dump more data for a specific instance,  you could override  some methods in this class
Thanks


Add support for devlink trap syscalls

Before sending a pull request, please review Contribution Guidelines:
https://github.com/google/syzkaller/blob/master/docs/contributing.md

@googlebot I signed it!
From: googlebot<EMAIL_ADDRESS>Sent: Wednesday, February 19, 2020 17:57
To: google/syzkaller<EMAIL_ADDRESS>Cc: Amit Cohen<EMAIL_ADDRESS>Author<EMAIL_ADDRESS>Subject: Re: [google/syzkaller] Add support for devlink trap syscalls (#1612)
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
📝 Please visit https://cla.developers.google.com/ to sign.
Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.

What to do if you already signed the CLA
Individual signers

It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA datahttps://cla.developers.google.com/clas and verify that your email is set on your git commitshttps://help.github.com/articles/setting-your-email-in-git/.

Corporate signers

Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoothttp://go/cla#troubleshoot (Public versionhttps://opensource.google/docs/cla/#troubleshoot).
The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA datahttps://cla.developers.google.com/clas and verify that your email is set on your git commitshttps://help.github.com/articles/setting-your-email-in-git/.
The email used to register you as an authorized contributor must also be attached to your GitHub accounthttps://github.com/settings/emails.

ℹ Googlers: Go herehttps://goto.google.com/prinfo/https%3A%2F%2Fgithub.com%2Fgoogle%2Fsyzkaller%2Fpull%2F1612 for more info.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://github.com/google/syzkaller/pull/1612?email_source=notifications&email_token=AOKPKRRAHK2UTV3GBNVRYB3RDVJD3A5CNFSM4KX3VDRKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEMIJ6SY#issuecomment-588291915, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AOKPKRSQ3FP577UPJJV6K33RDVJD3ANCNFSM4KX3VDRA.

Did you get any new information re CLA? Unfortunately I can't merge with cla bot not liking it, legal things and stuff...
Jiri Pirko and Noa Osherovich from Mellanox contributed in the past.

@googlebot I signed it!

Perfect


Fix cloudkms signer is not threadsafe

Closes: #260
Description
Create a new hasher in cloudkms signer, when signing flow transactions.

For contributor use:

[x] Targeted PR against master branch
[x] Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
[x] Code follows the standards mentioned here.
[x] Updated relevant documentation
[x] Re-reviewed Files changed in the Github PR explorer
[ ] Added appropriate labels

Thank you!
Alternatively we could put a mutex around it, or maybe just document that the API is not thread-safe and requires users to handle it. I'm OK with this solution

Thanks for the quick feedback! We noticed this issue when we were trying to sign/send multiple flow transactions in parallel. We ended up with a workaround to get it working. But it will be much easier if we can support this in the upstream lib.

it seems to me that the updated code is double-hashing the message to sign (once with the hasher + once with KMS). Did I miss something?
Since there are still calls to hash on KMS (the same call that seems to cause the errors in the first place), I'm wondering if the issue is really solved from your tests?
I didn't audit this code before and this was not added by this PR, but ideally the call to sign on KMS should include the hashing (this means the request to sign should include the message and not the digest). Hopefully that would solve the thread issue too.

👍 to @tarakby's comment.
Cloud KMS actually allows you to either pass either un-hashed data or a pre-hashed digest (but not both), so I don't think this will produce the wrong signature. (ref: https://cloud.google.com/kms/docs/create-validate-signatures#data_versus_digest).
But I think we can just pass data and then just remove the hasher instance altogether.

Cloud KMS actually allows you to either pass either un-hashed data or a pre-hashed digest (but not both), so I don't think this will produce the wrong signature

Thanks @psiemens, yes the kms interface allows to include either data or digest in the signing request. The original code looks correct to me, but I might be still missing something with the code updated after this PR:
https://github.com/onflow/flow-go-sdk/blob/8fc9b5e084cf056ec09adec8004bfe33449dcc3b/crypto/cloudkms/signer.go#L63-L77
Line 67 computes the first hash with the hasher, line 69 computes the hash of the hash with KMS, line 76 includes the hash of the hash to be signed as a digest. Unless the verification is also double hashing, I guess this signature won't be valid.

In my comment I mainly mentioned 2 points:

[correctness] double hashing should be avoided, otherwise it won't be validated by a correct verification.
[best practice] if an HSM is used, it is recommended to delegate all cryptographic computations to it including hashing. Although hashing only deals with public data, it can lead to attacks in the context of signatures. An HSM is used when a the external environment isn't 100% trusted, so better to include hashing in the trusted environment too (in some designs that's not possible and that's why the kms API offers signing the digest).

I'll open a PR to update 1 (pending your confirmation that I didn't misread the code) and 2.

@tarakby The call to makeDigest doesn't actually compute a hash, it just prepares the hash data structure required by KMS. So I don't think there is any double hashing.
But I agree with your point about delegating all cryptographic computations to KMS.
https://github.com/onflow/flow-go-sdk/blob/8fc9b5e084cf056ec09adec8004bfe33449dcc3b/crypto/cloudkms/signer.go#L92-L101

@tarakby A PR to fix point 2 would be great!

double hashing should be avoided, otherwise it won't be validated by a correct verification.

I don't get the double hashing issue here. The change we made in this PR is not adding one more hash. Basically, we just replace the shared hasher, with a local hasher initialized in the Sign method.

The call to makeDigest doesn't actually compute a hash, it just prepares the hash data structure required by KMS

My bad, I thought that function was computing a hash. Sorry @psiemens and @judezhu and thanks both for your clarifications!


Normalize Sass Imports

Use Kitty Giraudel's Sass Architecture to ensure these folders don't become a mess, which they inevitably can.

Closed in #2


New release?

It seems like the 1.0 version of this action will cease working on 31st May 2023:
Warning: The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

The PR to bump @actions/core has been merged to master, and pointing to the commit makes the warning go away, so a new release will sort this out.

Hello @freemer !
You're right, I forgot to tag it. It's done now you can use the v2 (release notes).


Add Des Moines, Iowa

To<EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS>Subject: Des Moines City Resident for Defunding the Police
Dear Des Moines City Officials,
My name is [YOUR NAME], and I am a resident of [YOUR DISTRICT]. I am writing to insist that the City Council adopt a People’s Budget that prioritizes community wellbeing and redirects funding away from the police.
I am asking that the Des Moines City Council make a more overt and visible commitment to racial justice. I urge you to pressure the City Manager’s Office towards an ethical and equal reallocation of the city’s expenditures, away from DMPD, and towards sectors that facilitate the dismantling of racial and class inequality.
Research shows that a living wage, access to holistic health services and treatment, educational opportunity, and stable housing are far more successful at reducing crime than police or prisons (Source: Popular Democracy). As such, I demand more aggressive financial support to be directed to those areas.
Furthermore, I am outraged at the excessive use of force that DMPD used against protesters. Officers with the Iowa State Patrol and Iowa City Police Department used chemical munitions against protesters which is unethical and prohibited for use in warfare by many international treaties.
Thank you for your time,
[YOUR NAME] [YOUR ADDRESS] [YOUR EMAIL] [YOUR PHONE NUMBER]

Suggested edit in bold (also removed mention of reform in the last sentence):
Dear Des Moines City Officials,
My name is [YOUR NAME], and I am a resident of [YOUR DISTRICT]. I am writing to insist that the City Council adopt a People’s Budget that prioritizes community wellbeing and redirects funding away from the police.
I am asking that the Des Moines City Council make a more overt and visible commitment to racial justice. I urge you to pressure the City Manager’s Office towards an ethical and equal reallocation of the city’s expenditures, away from DMPD, and towards sectors that facilitate the dismantling of racial and class inequality.
Research shows that a living wage, access to holistic health services and treatment, educational opportunity, and stable housing are far more successful at promoting community safety than police or prisons (Source: Popular Democracy). As such, I demand more aggressive financial support to be directed to those areas.
Furthermore, I am outraged at the excessive use of force that DMPD used against protesters. Officers with the Iowa State Patrol and Iowa City Police Department used chemical munitions against protesters which is unethical and prohibited for use in warfare by many international treaties. I am calling on you to seriously reduce city funding to DMPD.
Thank you for your time,
[YOUR NAME]
[YOUR ADDRESS]
[YOUR EMAIL]
[YOUR PHONE NUMBER]

got it!


✨ Add Swiss Franc currency

Add Swiss Franc currency symbol and official abbreviation to relevant strings to enable currency in Stripe.
I would love to see this as I'd like to use Ghost for the magazine I'm currently starting ❤

Thank you for your contribution! We are planning some work that will improve our currency support in a more complete way and so I'm closing this in lieu of the proper solution.


Grab tweets from before bot was initially started

Hello! I was wondering, is there any possibility of an option for the bot to mirror over the tweets (as a one-time thing) from before it was run the first time? This way the pleroma profile could be a complete recreation of the twitter profile it's mirroring.

Hi, yeah, the first run experience isn't as smooth as I'd like.
As you mentioned, maybe the bot could try to detect if it's being executed for the first time (checking for the existence of residual files in cwd, perhaps, or if the Fediverse account has no toots/posts) and present the user the option of how it should proceed. Something along the lines of:
It seems like pleroma-bot is running for the first time.
How far back should we retrieve tweets from the Twitter account?

Enter a date (YYYY-MM-DD):
[Leave it empty to retrieve *ALL* tweets or enter 'continue' if you want the bot to execute as normal (checking date of last post in the Fediverse account)]

Would that suffice?
I need to look at Twitter's API docs again because v2 changed some things about fetching tweets older than a week.

Hi, yeah, the first run experience isn't as smooth as I'd like.
As you mentioned, maybe the bot could try to detect if it's being executed for the first time (checking for the existence of residual files in cwd, perhaps, or if the Fediverse account has no toots/posts) and present the user the option of how it should proceed. Something along the lines of:
It seems like pleroma-bot is running for the first time.
How far back should we retrieve tweets from the Twitter account?

Enter a date (YYYY-MM-DD):
[Leave it empty to retrieve *ALL* tweets or enter 'continue' if you want the bot to execute as normal (checking date of last post in the Fediverse account)]

Would that suffice?
I need to look at Twitter's API docs again because v2 changed some things about fetching tweets older than a week.

That sounds awesome tbh! Maybe a modifier to have it ask that if the bot has already been run before too!

That sounds awesome tbh! Maybe a modifier to have it ask that if the bot has already been run before too!

Absolutely, I agree.
$ pleroma-bot forceDate [twitter_username]

Or something similar. The twitter_username would be optional, in case you have multiple users on your config and you only want to force the retrieval for one of them.
It would basically print the same thing excluding the first run bit:
How far back should we retrieve tweets
from the Twitter account?

Enter a date (YYYY-MM-DD):
[Leave it empty to retrieve *ALL* tweets or
enter 'continue' if you want the bot to
execute as normal (checking date of last
post in the Fediverse account)]

Absolutely, I agree.
$ pleroma-bot forceDate [twitter_username]

Or something similar. The twitter_username would be optional, in case you have multiple users on your config and you only want to force the retrieval for one of them.
It would basically print the same thing excluding the first run bit:
How far back should we retrieve tweets
from the Twitter account?

Enter a date (YYYY-MM-DD):
[Leave it empty to retrieve *ALL* tweets or
enter 'continue' if you want the bot to
execute as normal (checking date of last
post in the Fediverse account)]

That is so awesome 😄 That would be perfect! Thank you so much 😀

That is so awesome 😄 That would be perfect! Thank you so much 😀

Hey,
I've implemented these changes here a72f888db888c8aa419333b41307f5c2b5776bdd
I have to improve the code coverage so it passes the tests (it dropped from 100% to 97%) before I integrate them into the master branch and do a proper release but in the meantime I've uploaded it as an experimental release on TestPyPI.
You can install it like this:
$ pip install --index-url https://test.pypi.org/simple/ pleroma-bot --upgrade

Version number should be 0.6.9 after the upgrade.
The usage is as follows:
optional arguments:
  -h, --help            show this help message and exit
  -n, --noProfile       skips Fediverse profile update (no background image,
                        profile image, bio text, etc.)
  --forceDate [FORCEDATE]
                        forces the tweet retrieval to start from a specific
                        date. The twitter_username value (FORCEDATE) can be
                        supplied to only force it for that particular user in
                        the config
  -s, --skipChecks      skips first run checks
  --version             show program's version number and exit

So, for example:
$ pleroma-bot --forceDate myTwitterUser

Should prompt you to enter a date when processing myTwitterUser, let me know if it works in your case.
Cheers!

Hey,
I've implemented these changes here a72f888db888c8aa419333b41307f5c2b5776bdd
I have to improve the code coverage so it passes the tests (it dropped from 100% to 97%) before I integrate them into the master branch and do a proper release but in the meantime I've uploaded it as an experimental release on TestPyPI.
You can install it like this:
$ pip install --index-url https://test.pypi.org/simple/ pleroma-bot --upgrade

Version number should be 0.6.9 after the upgrade.
The usage is as follows:
optional arguments:
  -h, --help            show this help message and exit
  -n, --noProfile       skips Fediverse profile update (no background image,
                        profile image, bio text, etc.)
  --forceDate [FORCEDATE]
                        forces the tweet retrieval to start from a specific
                        date. The twitter_username value (FORCEDATE) can be
                        supplied to only force it for that particular user in
                        the config
  -s, --skipChecks      skips first run checks
  --version             show program's version number and exit

So, for example:
$ pleroma-bot --forceDate myTwitterUser

Should prompt you to enter a date when processing myTwitterUser, let me know if it works in your case.
Cheers!

Hi,
The changes have been roll out to master and a new release has been published (v0.7.0).
You can upgrade as usual:
$ pip install pleroma-bot --upgrade

Let me know if you encounter any issues with this new version, cheers!

Hi,
The changes have been roll out to master and a new release has been published (v0.7.0).
You can upgrade as usual:
$ pip install pleroma-bot --upgrade

Let me know if you encounter any issues with this new version, cheers!


Webpack bundling

Hello,
I have tried to use webpack to bundle my angular app. I used require("angular-table") to include this package in the project after using npm to install this package (v1.0.4). However, I kept getting error of module not found. Any advice on this?
Thank you

package.json is missing the "main" field.  It needs an entry like the following:
"main": "dist/angular-table.js",
Put it above the "maintainers" line and you'll be good to go.   If necessary, you can override the main entry in your own project's package.json, although I'm not sure how to do that.

Probably they should fix package.json to enable that standard import. Anyway you can use require('angular-table/dist/angular-table.min.js').


Question: Is There A Way to Update All Snapshots Within A Project?

Hello! Not an issue per say, but a question. I just pulled down the project and i noticed there was a button to update the snapshot of an individual file. I was wondering if there was a way to update all snapshots from within the project? I know jest has a cmd to update all snaps, but I think it would be dope if Majestic had an update all button or something, if it doesnt already.
I love the software and its brillant! Great work!

We should add this as a feature. Currently, there is no way to update all snapshots.
Thank you!

You can add the -u flag to your optional Majestic config args. That's how I did it.

For now you can add the -u flag to the majestic config in your package.json.

Hey, I would like to have a go a this feature :)
Do you have a general idea as to where the button should be?
At first I thought top of the side bar but I don't think it's a good idea to have that button be very "attractive" to click because a less experienced Jest could update them all without really knowing what that means. So maybe a bit less visible would be best.
Maybe next to the little "Refresh" button on the side bar?

Thank you for taking this up.
If we show a confirmation dialog, then I'm comfortable having it next to the 'Run All' button with a descriptive tooltip like "Updates all the snapshots".
Also to show this button, we need to know if any are any snapshot failures so far. We could inspect the test results as they arrive and set a variable to indicate if there are snapshot failures and then pass the variable via the Summary so the UI would know when to show the button.
if you run into issues or blockers, feel free to ping here so I could help out.

Would this make sense as a toggle next to both the Run tests and Run buttons, so you can toggle whether snapshots should be updated when running all tests or just a single file?


added get_serialized_size_bytes()

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

7 of 7 (100.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 98.961%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
16387

Relevant Lines:
16559

💛  - Coveralls


Syndicate pAI for Nukies

About the PR

Adds a Syndicate pAI for use with Nuclear Operatives in order to grant them access to the Syndicate channel and revoke the Common channel (resolves #16802). This is a continuation of #17249.
Media

[x] I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Changelog

:cl: crazybrain

add: Added Syndicate pAI.
tweak: Syndicate pAI's can be found on the Nukie planet.

add it to pointless catgory in uplink

add it to pointless catgory in uplink

sure, how many TC? 2?

Really even 1 tc sounds good cause some pai's are uh... Pretty shitty and or metagamey

imagine 20 syndi pAIs in captain hq

do the uplink thing in another pr cuz i want to avoid bikeshedding on this one


Microsoft.AspNet.Hosting.Internal.HostingEngine

this is my log，为什么会重复执行，在微信浏览器里面，其它地方访问又不会

Why these logics are repeated when the site is visited by Wechat browser? It doesn’t repo with other user agents.
Translated by @troydai

info: Microsoft.AspNet.Hosting.Internal.HostingEngine[1]
      Request starting HTTP/1.1 GET
info: Microsoft.AspNet.Mvc.Controllers.ControllerActionInvoker[1]
      Executing action method Lmxin.Controllers.HomeController.Index with arguments () - ModelState is Valid'
info: Microsoft.AspNet.Mvc.ViewFeatures.ViewResultExecutor[1]
      Executing ViewResult, running view at path /Views/Home/Index.cshtml.
info: Microsoft.AspNet.Mvc.Infrastructure.MvcRouteHandler[2]
      Executed action Lmxin.Controllers.HomeController.Index in 0.1141ms
info: Microsoft.AspNet.Hosting.Internal.HostingEngine[2]
      Request finished in 0.1453ms 200 text/html; charset=utf-8

info: Microsoft.AspNet.Hosting.Internal.HostingEngine[1]
      Request starting HTTP/1.1 GET
info: Microsoft.AspNet.Mvc.Controllers.ControllerActionInvoker[1]
      Executing action method Lmxin.Controllers.HomeController.Index with arguments () - ModelState is Valid'
info: Microsoft.AspNet.Mvc.ViewFeatures.ViewResultExecutor[1]
      Executing ViewResult, running view at path /Views/Home/Index.cshtml.
info: Microsoft.AspNet.Mvc.Infrastructure.MvcRouteHandler[2]
      Executed action Lmxin.Controllers.HomeController.Index in 0.0015ms
info: Microsoft.AspNet.Hosting.Internal.HostingEngine[2]
      Request finished in 0.0015ms 200 text/html; charset=utf-8

info: Microsoft.AspNet.Hosting.Internal.HostingEngine[1]
      Request starting HTTP/1.1 GET
ANA-NFkhHw0bbQyy6JuCQUnqmVC95jr8HpuYLFE
info: Microsoft.AspNet.StaticFiles.StaticFileMiddleware[6]
      The file /css/site.min.css was not modified
info: Microsoft.AspNet.Hosting.Internal.HostingEngine[2]
      Request finished in 0.0016ms 304 text/css
info: Microsoft.AspNet.Hosting.Internal.HostingEngine[1]
      Request starting HTTP/1.1 GET
j8HBSa-_TImW-5JCeuQeRkm5NMpJWZG3hSuFU
info: Microsoft.AspNet.StaticFiles.StaticFileMiddleware[2]
      Sending file. Request path: '/js/site.min.js'. Physical path: 'D:\test\wwwroot\js\site.min.js'
info: Microsoft.AspNet.Hosting.Internal.HostingEngine[2]
      Request finished in 0ms 200 application/javascript

@JunTaoLuo @troydai

I added translation in the original report. @Tratcher

The browser may be sending two requests. You can use tools like Fiddler or Message Analyzer to see the raw requests as they come over the wire.

@lmxin123 需要翻译吗？

This problem happen when the project.json like this
"commands": {
"web": "Microsoft.AspNet.Server.Kestrel --server.urls http://localhost:5001",
"ef": "EntityFramework.Commands"
}
But this problem has be solve when I change the project.json like this
"commands": {
"web": "Microsoft.AspNet.Server.WebListener --server.urls http://localhost:5001",
"ef": "EntityFramework.Commands"
}
So, I don't know why.

Meaning Kestrel and WebListener responds the requests different. It will be more helpful if you can provide us the raw requests.

@Lxiamail any updates on the raw requests?

@troydai How can get the raw requests?

By using a tool like Fiddler, NetMon, WireShark, etc..

@lmxin123 If you still have the issue, please re-open or file another one with the traces.


Feat/InsertBefore_with_Separators

Mixed-up the two and did not want to lose the updates

My mistake, I had selected the specific testsuite and forgot to rerun everything. Closing and reopening when it's clean


anonymization: fix orders with patron_pid

fixes an error when anonymizing an order that does not have the patron_pid in the order lines

Closing in favour of: https://github.com/inveniosoftware/invenio-app-ils/pull/1193


Avoid repeating microbenchmark

We currently execute one of the Dart 1 microbenchmarks twice in a row, only to ignore one of the results. It appears related to recent test flakiness (see log below).
[   +1 ms] Latest build already installed.
[        ] Moto G 4 startApp
[   +2 ms] /Volumes/DevicelabAndroid/sdk/platform-tools/adb -s ZY2245H6ZS shell am start -a android.intent.action.RUN -f 0x20000000 --ez enable-background-compilation true --ez enable-dart-profiling true com.yourcompany.microbenchmarks/io.flutter.app.FlutterActivity
[ +974 ms] Starting: Intent { act=android.intent.action.RUN flg=0x20000000 cmp=com.yourcompany.microbenchmarks/io.flutter.app.FlutterActivity (has extras) }
[        ] Waiting for observatory port to be available...
[+17607 ms] I/flutter (18415): ================ RESULTS ================
[   +1 ms] I/flutter (18415): :::JSON::: {"stock_layout_iteration":3683.8005893909626}
[+27047 ms] I/flutter (18415): ================ RESULTS ================
[        ] I/flutter (18415): :::JSON::: {"stock_layout_iteration":3683.8005893909626}
[        ] I/flutter (18415): ================ FORMATTED ==============
Task failed: Bad state: Future already completed

Stack trace:
dart:async                                                   _Completer.completeError
package:flutter_devicelab/tasks/microbenchmarks.dart 135:19  _readJsonResults.
===== asynchronous gap ===========================
dart:async                                                   _BoundSinkStream.listen
package:flutter_devicelab/tasks/microbenchmarks.dart 118:8   _readJsonResults
package:flutter_devicelab/tasks/microbenchmarks.dart 53:22   createMicrobenchmarkTask.._runMicrobench._run
===== asynchronous gap ===========================
dart:async                                                   _asyncThenWrapperHelper
package:flutter_devicelab/tasks/microbenchmarks.dart 27:48   createMicrobenchmarkTask.._runMicrobench._run
package:flutter_devicelab/tasks/microbenchmarks.dart 55:18   createMicrobenchmarkTask.._runMicrobench
===== asynchronous gap ===========================
dart:async                                                   _asyncThenWrapperHelper
package:flutter_devicelab/tasks/microbenchmarks.dart 22:19   createMicrobenchmarkTask.
package:flutter_devicelab/framework/framework.dart 125:36    _TaskRunner._performTask.

[        ] I/flutter (18415): Stock layout: 3683.8 µs per iteration
[        ] I/flutter (18415): ================ FORMATTED ==============
[        ] I/flutter (18415): Stock layout: 3683.8 µs per iteration

LGTM!

Landing on red to get back to green.


Continuing to set up server :-)

First and foremost, thank you for project, it is fantastic, and I will do what I can to promote your project!
The main thing that appealed to me was the server setup and I really like the way it works, I have a couple of issues that I still need to resolve, plus I would like to explain how I have it set up now.
I created a VPS on Digital Ocean (they call it a Dropplet). Ubuntu 18.04
I created a user "joao" which will be used to configure system using sudo. It is also where I downloaded the server file, it resides in /home/joao/bin/musicalypse/bin/
I installed apache2 and added Let's Encrypt SSL.
I added a A Record on my server pointing to the VPS, the domain name is audio.machado-family.com
accessing the server at: http://audio.machado-family.com:8080 works just fine.
I then decided to setup a proxy reverse/proxy to serve port <IP_ADDRESS>:8080 to the domain https://audio.machado-family.com but all I get is a spinning loading graphic, although it looks like it is Musicalypse trying to load.
The other issue is that I can't seem to figure out a way to start Musicalypse on server boot, but right now that is secondary.
The server is up and running, the links above should be good, if it is down, I am probably restarting the server.

Hello @joaoherberto,
Thanks for your enthusiasm!
The issue here is that Musicalypse uses websockets to communicate with the server. You need to take that into account when setting up your reverse proxy.
Specifically you will need Apache's proxy_wstunnel module to be enabled.
You could try something along these lines :
<VirtualHost *:443>
  ServerName audio.machado-family.com

  RewriteEngine on
  RewriteCond ${HTTP:Upgrade} websocket [NC]
  RewriteCond ${HTTP:Connection} upgrade [NC]
  RewriteRule .* "wss:/localhost:8080/$1" [P,L]

  ProxyPass / https://localhost:8080/
  ProxyPassReverse / https://localhost:8080/
  ProxyRequests off
</VirtualHost>

I haven't tried it myself but that should give you an idea where to look.
Let me know if it works.

No go..
here is the contents of my 000-default-le-ssl.conf, which is the site that is enabled for ssl.
<IfModule mod_ssl.c>
<VirtualHost *:443>
        # The ServerName directive sets the request scheme, hostname and port that
        # the server uses to identify itself. This is used when creating
        # redirection URLs. In the context of virtual hosts, the ServerName
        # specifies what hostname must appear in the request's Host: header to
        # match this virtual host. For the default virtual host (this file) this
        # value is not decisive as it is used as a last resort host regardless.
        # However, you must set it for any further virtual host explicitly.

        #ServerName www.example.com
        ServerName audio.machado-family.com
        ServerAdmin webmaster@localhost
        #DocumentRoot /var/www/html

        RewriteEngine on
        RewriteCond ${HTTP:Upgrade} websocket [NC]
        RewriteCond ${HTTP:Connection} upgrade [NC]
        RewriteRule .* "wss:/localhost:8080/$1" [P,L]

        # Available loglevels: trace8, ..., trace1, debug, info, notice, warn,
        # error, crit, alert, emerg.
        # It is also possible to configure the loglevel for particular
        # modules, e.g.
        #LogLevel info ssl:warn

        ErrorLog ${APACHE_LOG_DIR}/error.log
        CustomLog ${APACHE_LOG_DIR}/access.log combined

       # <Directory "/var/www/html">
       # AuthType Basic
       # AuthName "Restricted Content"
       # AuthUserFile /etc/apache2/.htpasswd
       # Require valid-user
       # </Directory>

        # For most configuration files from conf-available/, which are
        # enabled or disabled at a global level, it is possible to
        # include a line for only one particular virtual host. For example the
        # following line enables the CGI configuration for this host only
        # after it has been globally disabled with "a2disconf".
        #Include conf-available/serve-cgi-bin.conf

       SSLCertificateFile /etc/letsencrypt/live/audio.machado-family.com/fullchain.pem
       SSLCertificateKeyFile /etc/letsencrypt/live/audio.machado-family.com/privkey.pem
       Include /etc/letsencrypt/options-ssl-apache.conf

    # Servers to proxy the connection, or;
    # List of application servers:
    # Usage:
    # ProxyPass / http://[IP Addr.]:[port]/
    # ProxyPassReverse / http://[IP Addr.]:[port]/
    # Example:
    ProxyPass / http://localhost:8080/
    ProxyPassReverse / http://localhost:8080/

</VirtualHost>
</IfModule>

I tried commenting and un-commenting  DocumentRoot /var/www/html, but nothing changed... Of course I always use sudo systemctl restart apache2.service every time I make changes.
What are your thoughts?
Merci,
Joao

Try changing:
RewriteRule .* "wss:/localhost:8080/$1" [P,L]
To:
RewriteRule .* "ws:/localhost:8080/$1" [P,L]

Still not working, I tried changing localhost entries to <IP_ADDRESS> and to the server ip address of <IP_ADDRESS> and still nothing..

Oops, I meant ws://localhost:8080/$1 and not ws:/localhost:8080/$1.
I know for sure that the issue comes from the websocket not going through the proxy. The rest of the config is fine.
You could also check your error.log file for more information.

On my way to Adoration, I'll update in a couple of hours and report..
Merci

OK, still not working...
 This is used when creating
        # redirection URLs. In the context of virtual hosts, the ServerName
        # specifies what hostname must appear in the request's Host: header to
        # match this virtual host. For the default virtual host (this file) this
        # value is not decisive as it is used as a last resort host regardless.
        # However, you must set it for any further virtual host explicitly.
        #ServerName www.example.com

        ServerName audio.machado-family.com
        ServerAdmin webmaster@localhost
        #DocumentRoot /var/www/html

        RewriteEngine on
        RewriteCond ${HTTP:Upgrade} websocket [NC]
        RewriteCond ${HTTP:Connection} upgrade [NC]
        RewriteRule .* "ws://localhost:8080/$1" [P,L]

        # Available loglevels: trace8, ..., trace1, debug, info, notice, warn,
        # error, crit, alert, emerg.
        # It is also possible to configure the loglevel for particular
        # modules, e.g.
        #LogLevel info ssl:warn

        ErrorLog ${APACHE_LOG_DIR}/error.log
        CustomLog ${APACHE_LOG_DIR}/access.log combined

       # <Directory "/var/www/html">
       # AuthType Basic
       # AuthName "Restricted Content"
       # AuthUserFile /etc/apache2/.htpasswd
       # Require valid-user
       # </Directory>

        # For most configuration files from conf-available/, which are
        # enabled or disabled at a global level, it is possible to
        # include a line for only one particular virtual host. For example the
        # following line enables the CGI configuration for this host only
        # after it has been globally disabled with "a2disconf".
        #Include conf-available/serve-cgi-bin.conf

SSLCertificateFile /etc/letsencrypt/live/audio.machado-family.com/fullchain.pem
SSLCertificateKeyFile /etc/letsencrypt/live/audio.machado-family.com/privkey.pem
Include /etc/letsencrypt/options-ssl-apache.conf

    # Servers to proxy the connection, or;
    # List of application servers:
    # Usage:
    # ProxyPass / http://[IP Addr.]:[port]/
    # ProxyPassReverse / http://[IP Addr.]:[port]/
    # Example:
    ProxyPass / http://localhost:8080/
    ProxyPassReverse / http://localhost:8080/

</VirtualHost>
</IfModule>

Note, no firewall enabled either.

GOT IT!!!
Use these for rewrite conditions.
        RewriteEngine On
        RewriteCond %{HTTP:Upgrade} =websocket [NC]
        RewriteRule /(.*)           ws://localhost:8080/$1 [P,L]
        RewriteCond ${HTTP:Upgrade} !=websocket [NC]
        RewriteRule /(.*) http://localhost:8080/$1 [P,L]

I added the following to the iptables so that only the localhost would have access to the port 8080, so all traffic  goes through the proxy. Seems to work well!
sudo iptables -A INPUT -p tcp -s localhost --dport 25 -j ACCEPT
sudo iptables -A INPUT -p tcp --dport 25 -j DROP

Oops, closed it by accident...

Great! Thank you for documenting your efforts.
I'll update the documentation with these findings when I have time.


Remove Deprecated members.

Coverage decreased (-1.1%) to 76.18% when pulling 77fa5ea5de27c07a409cc5c5de9db74661b617b9 on remove_deprecated_members into 6b2998d72fe8118d84df3537d809ef57d7f74b8a on master.

Hello everybody - I'd like to have this one merged soon. Unless there's any objection, I will merge this one by the end of the week.

@adriancole does this cover what you wanted removed?

Merged - if you think there's something that shouldn't have been removed or something is missing, let me know, etc.


cleanup asan odr violations

linking ts::tsutil in a plugin with create ODR violations with DbgCtl globals.
The fix in compress.cc will still leak at shutdown, but the asan complaint was in the verify plugin which doesn't call TSPluginInit.   I'm not sure how to run code at plugin "unload" to clean up.

Cherry-picked to v10.0.x


Istio - ingress not working after enabling SDS

I generated a cert from our internal CA team and then created a secret in the Istio-system ns.
Followed this document https://istio.io/docs/tasks/traffic-management/ingress/secure-ingress-sds/
I am not sure what else is missing but not able to make it work, tried redeploying  the ingress SDS pod after creating the secret and gateway.
Once I install SDS, I am not able to communicate using http as well.
Is there also a way that we can configure our cert for mutual TLS communication internally?
apiVersion: networking.istio.io/v1alpha3
kind: Gateway
metadata:
annotations:
creationTimestamp: "2019-07-31T20:37:21Z"
generation: 1
name: istio-xxx
namespace: istio-xxx
resourceVersion: "25249206"
uid: feeb9147-b3d2-11e9-81cf-5a53bd44ba40
spec:
selector:
istio: ingressgateway
servers:

hosts:

'*'
port:
name: http
number: 80
protocol: HTTP
tls:
httpsRedirect: true

hosts:

custom-domain.com
port:
name: https-catalog
number: 443
protocol: HTTPS
tls:
credentialName: istio-ingressgateway-certs
mode: SIMPLE

apiVersion: networking.istio.io/v1alpha3
kind: VirtualService
metadata:
annotations:
creationTimestamp: "2019-07-31T20:37:21Z"
generation: 1
name: istio-xxx
namespace: istio-xxx
spec:
gateways:

istio-xxx
hosts:
custom-domain.com
http:
match:

uri:
prefix: /istio-custom-pod
rewrite:
uri: ' '
route:
destination:
host: istio-custom-service
port:
number: 8080

Closing as duplicate of https://github.com/istio/istio/issues/15866

@esnible #15866 ended up being a configuration issue on my end, so we could probably reopen this issue for discussion.
What's the specific error you're encountering @srirajk? Could you drop a kubectl describe for your ingress-gateway pod, and/or provide a dump of the ingress-gateway's envoy config_dump if possible?

Please add the follow up info if you are still running into this


Add a state in cloud account config

The cloud account config contains the service configs and cloud api clients. Whenever cloud account config update fails, set the cloud account config state to invalid.
Any consumer of cloud account config which makes the cloud API calls should check the cloud account config state and proceed only if it's in a valid state.

/nephe-test-e2e-agentless

/nephe-test-e2e-agentless

/nephe-test-e2e-azure

/nephe-test-e2e-azure

/nephe-test-e2e-azure


rollup / packaging issues

Right now, when you run npm run test, it proceeds to start running the packaging process. Dunno why that's happening, but something's not right.
There are also warnings about circular dependencies and about this being rewritten to undefined, so I'm assuming that we've still got some effort to get this all buttoned up.

warnings about circular dependencies

This one is related to our use of Buffer in hash.ts, and it looks like there's not much we can do about it, short of getting rid of our use of Buffer (https://github.com/FredKSchott/rollup-plugin-polyfill-node/issues/21, https://github.com/calvinmetcalf/rollup-plugin-node-builtins/issues/39). Seems to be harmless.
Also related to this issue is removing the compile npm script which individually transpiles our typescript files. I think we need it to run bench/*.ts, but we could replace that with ts-node (blocked by an upstream packaging issue with bigint-mod-arith). Apart from that though, it seems redundant now from what I can tell.

Can we get rid of Buffer? Just use string concatenation?
bigint-mod-arith is a remarkably small package and we're only using a small part of it. We could just decide to copy that into our own code, so long as the license is compatible.

Closing in favour of #34 and #35. As far as I can tell, the builds work. We now support:

node (both import and require)
post-bigint browsers (both as an ES module and as a global named eg)
deno


The results of some stuffed toy cases

Image

Another Method

Lotus

Thank you very much for the excellent work on LOTUS and the creators for open-sourcing it!
However, when I processed stuffed toy products, I noticed that the overall values of the normal map appear to be relatively low . From the visualization, even the background seems to appear darker. Could you please explain the reason for this? Is the generated normal map accurate in this case?

Hi, sorry for my late reply. Which version of the Lotus model did you use? I tested the samples you provided using our official demo, and the results seem good, especially our Lotus-G.

I noticed that the resolution of your images is quite low. I’d recommend resizing them to a higher resolution for better results.
Thanks for your attention!

the resolution of this panda image is 1920*1080, however it seems wrong~
Do you test other stuffed toys before~


emmet.preferences support

According to the blog post about Emmet 2, the emmet.preferences was deprecated.
Is there any other way to set preferences for Emmet? Some os those preferences are essential for me (and some other devs, i think).

As suggested in the linked post, please do share which of those preferences are essential for you.

The ones I use are: css.valueSeparator css.propertyEnd sass.propertyEnd.
I think that enabling all preferences would be the perfect solution. But, if you are planning to implement them following the users requests, these are the ones I would appreciate the most.

Am curious, what are your values for  css.valueSeparator, css.propertyEnd and sass.propertyEnd.

Also, like I mentioned in the blog post, we are using the new Emmet modules written by @sergeche who is the same person who wrote the previous Emmet library.
I don't think he plans to support all the preferences.
Some of them will get integrated into syntaxProfiles. Example:

format.forceIndentationForTags
format.noIndentTags
profile.allowCompactBoolean
profile.booleanAttributes

Some of them are filter related and so will need a new setting. Example:

bem.elementSeparator
bem.modifierSeparator
filter.commentAfter
filter.commentBefore

The ones related to valueSeparator and propertyEnd can be implemented as formatters.

@ramya-rao-a these are used in stylesheet formatters and were renamed to between and after: https://github.com/emmetio/stylesheet-formatters/blob/master/index.js#L5

@ramya-rao-a my config file looks like this:
	"css.valueSeparator": ":",
	"css.propertyEnd": "; ",
	"sass.propertyEnd": "; "
}```

@sergeche Can you update the README for https://github.com/emmetio/expand-abbreviation?
It says that currently  HTML element commenting is the only supported formatter.
As per your links there are stylesheet-formatters as well that can be customized. Anything else that the format option in expand options can support?

Here is the current list I am working towards:

css.propertyEnd
css.valueSeparator
sass.propertyEnd
sass.valueSeparator
stylus.propertyEnd
stylus.valueSeparator
css.unitAliases
css.intUnit
css.floatUnit
filter.commentAfter
filter.commentBefore
filter.commentTrigger
bem.elementSeparator
bem.modifierSeparator

@ramya-rao-a How do you want to do this? Do you plan to allow to specify a path to that config file or do you want to implement those settings as "normal" settings like emmet.includeLanguages?

@jens1o I am thinking of bringing back the emmet.preferences and support just the above in it. The advantage is that the documentation for it already exists in https://docs.emmet.io/customization/preferences/
Internally, we will use the format option as described in https://github.com/emmetio/expand-abbreviation/issues/8

In tomorrow's Insiders, you would be able to use the emmet.preferences setting to customize the following

css.propertyEnd
css.valueSeparator
sass.propertyEnd
sass.valueSeparator
stylus.propertyEnd
stylus.valueSeparator
css.unitAliases
css.intUnit
css.floatUnit

There hasnt been any feedback asking for the filter.* or bem.* preferences, they will be out of scope for this milestone.

@ramya-rao-a I assumed you were brining back filter.* since it was included in your listed.
I for one use "filter.commentAfter": "\n<!-- /<%= attr('id', '#') %><%= attr('class', '.') %> -->", to add classes/ids after the closing tags.

@sjelfull it’s an option of markup formatter now and should be passed as
{
  ...
  "comment": {
    "enabled": true,
    "after": '\n<!-- /[#ID][.CLASS] -->'
  }
}

See https://github.com/emmetio/markup-formatters/blob/master/format/html.js#L8

@sergeche Could you show the example in the context of VS Code + emmet.* options?
I'm unsure where to put it. emmet.syntaxProfiles.html?

@sjelfull Glad to hear your feedback. I have actually added the filter.comment* preferences, but didn't have enough time in this milestone to test it, so didn't want to document the support (just yet)
Can you do me a favor and help out in testing it in the latest Insiders? You can get it from https://code.visualstudio.com/insiders
Set the filters as before i.e
"emmet.preferences": {
     "filter.commentAfter": ...
     "filter.commentBefore": ...
     "filter.commentTrigger": ....
}

@ramya-rao-a Thanks.
I'm on 1.16.0-insider.
I got this:
"emmet.preferences": {
        "filter.commentAfter": "\n<!-- /<%= attr('id', '#') %><%= attr('class', '.') %> -->",
        "stylus.propertyEnd": ";",
        "stylus.valueSeparator": ": "
    },
    "emmet.syntaxProfiles": {
        "html": {
            "filters": "html, c"
        }
    }

The stylus part seems to work, but the comment is not appended?

@sjelfull
Ah! I was following https://docs.emmet.io/filters/#comment-tags-c when adding support for the comment filter. The filtersoption in emmet.syntaxProfiles is not being used in Emmet 2.0 as it was before. Can you try something like ul.nav|c to test the 3 filter.comment* preferences?
I have logged #33601 for adding support for the filters in emmet.syntaxProfiles

I too am using @sjelfull's setup.
Using ul.nav|c yields ul.nav|<!--  --> without the ul actually being created.

@encryptdesigns Do you mean you also set c as a filter in emmet.syntaxProfiles or that you have customized the filter.commentAfter setting.
And what is your expected output for ul.nav|c ?
I get the below in the latest Insiders  without customizing the filter.commentAfter setting.

 The feature tracked in this issue will be part of VS Code 1.16 which hasnt released yet, but you can try it out in our Insiders build from https://code.visualstudio.com/insiders
Can you get the Insiders from the above link and try ul.nav both with and without the customization for filter.commentAfter under emmet.preferences and share your output and expected output?

@sergeche The after for the comment formatter in Emmet 2.0 seem to be using a different format compared to filter.commentAfter in the old Emmet. Can you share some information on how the before and after should be specified for the comment formatter in Emmet 2.0?

I've got the latest stable of VSC 1.16.0 and using the code that @encryptdesigns has above it almost works except that when adding the comment tag it includes the raw code of he emmet preference setting.

and my settings file has:
  "emmet.preferences":{     "filter.commentAfter": "<!-- /<%= attr('id', '#') %><%= attr('class', '.') %> -->"   },   "emmet.syntaxProfiles": { // Enable XHTML dialect for HTML syntax // “html”: “xhtml”     "html" : {       "filters" :"html, c"       }   },

Technically comments are working if I remove the filter.commetAfter in my settings. But the problem is that it adds the comment to the new line, which drives me nuts. I want my closing comment next tothe closing tag like this
</.div>
In Sublime I had this set up exactly as above I just removed the /n to generate a new line and I was happy. Is this possible in VSC?

Emmet 2 uses different syntax for commenting: https://github.com/emmetio/markup-formatters/blob/master/format/html.js#L20

Tested this just now:
    "emmet.preferences": {
        "filter.commentAfter": "\n<!-- /[#ID][.CLASS] -->",
        "stylus.propertyEnd": ";",
        "stylus.valueSeparator": ": "
    },

📈 Works!

Confirmed!
Although I prefer the closing tag on the same line:
"emmet.preferences": {         "filter.commentAfter": "<!-- /[#ID][.CLASS] -->",         "stylus.propertyEnd": ";",         "stylus.valueSeparator": ": "     },

The Release Notes: https://code.visualstudio.com/updates/v1_17#_emmet-preferences
and the Emmet docs: https://code.visualstudio.com/docs/editor/emmet#_emmet-configuration have been updated with notes on the new format for filter.commentAfter

Rock on!
On Oct 5, 2017 2:15 PM, "Ramya Rao"<EMAIL_ADDRESS>wrote:

The Release Notes: https://code.visualstudio.com/updates/v1_17#_emmet-
preferences
and the Emmet docs: https://code.visualstudio.com/
docs/editor/emmet#_emmet-configuration have been updated with notes on
the new format for filter.commentAfter
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/Microsoft/vscode/issues/32496#issuecomment-334579155,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AFcmwTzxkyWZ2m6K-tZLvIa-V5iQrszwks5spTjMgaJpZM4O2p5v
.

Hi peeps.  Sorry Im new to the conversation (and somewhat VScode - but loving it!)
Ive tried using the new preference:
"emmet.preferences": {
    "filter.commentAfter": "\n<!-- /[#ID][.CLASS] -->"
}

But still no auto complete with comments :(.  Any ides what Im doing wrong?  I am on version 1.17.0
Me trying it -> http://gph.is/2xVH9Pz
Thanks!

@kenjwho You need to use the comment filter. Use div|c instead of just c
If you are sure you want to use the comment filter all the time, then update the settings with
"emmet.syntaxProfiles": {
    "html": {
        "filter": "c"
    }
}

@ramya-rao-a thanks so much for the reply.  Im sure Im just doing it wrong.  These are the only emmet settings Im setting.  And it does work just fine when I type |c before hitting tab
    "emmet.syntaxProfiles": {
        "html": {
            "filter": "div|c"
        }
    },
    "emmet.preferences": {
        "filter.commentAfter": "\n<!-- /[#ID][.CLASS] -->"
    }

Use the below
  "emmet.syntaxProfiles": {
    "html": {
        "filters": "c"
    }
}

@ramya-rao-a you are my hero.  Thank you!!


Add results history

$scope isn't updating the front-end, which isn't completely damning, just need to figure out why that is and fix it sometime in the near future
lgtm :+1:


usdbk device prevent device usage in virtual-box

Under win7-64 (home edition)
After usb device  (maybe) used  by  usbdk  via libusb and released it may not be possible
anymore to map it in a virtual machine( virtual biox)
I'm not 100% how i reach that situation,  i noticed it after a while installing playing and  testing libusbd+usbdk  i was not able  anymore to use an device  in a  VirtualBox  , it  fail to  acquire device in host and map it on  the guest.
I had to play with registry editor and delete an entry "upfilter" that  was set as "Usdbk"  in order to get back usb device usable in virtual machine.
I came to this solution described in many virtual box forum post like here https://forums.virtualbox.org/viewtopic.php?f=2&t=37326
Is this a know issue? It's  quite annoying for  libusb based app under window if the same device is to be used in guest  os (typically my multi os test environment).

Hi,
Thanks for the report. Looks like interoperability issue between UsbDk and Virtual Box drivers.
We will check this. It would be great if your could provide exact steps to reproduce this problem.
Thanks,
Dmitry

From a fresh window say "no usbdk" (de-installed+regisrty clan manualy already) i can  attach my test dev (stm32 cdc/acm) to virtual box guest os.
After usbdk runtime get install from https://www.spice-space.org/download/windows/usbdk/UsbDk_1.0.17_x64.msi
and re-started window I can't attached my device to virtual box guest ,
The registry key mentioned is set again and seam to cause issue.
So their is not even  need to use the device with libusb  to cause the issue installing usbdk is enough to cause interoperability issue with  virtual box.
Strange things i noticed  : while de-installing and same while installing "usbdk"  caused my VIA USB 3.0 root hub to appear with exclamation mark , also running virtual box  stop to show many usb-device that were presents before install/de-install.  the mark goes away after os reboot but never usbdk  asked to restart during (de-)install?

Thanks, @diabolo38
We will check this.

I can confirm this behavior on windows 10 x64.  if usbDK is installed, cannot attach USB devices to VirtualBox Guest.

A patch which fixes the issue was sent to Vbox-devel:
https://www.virtualbox.org/pipermail/vbox-dev/2017-July/014625.html
For more info on what causes the issue you can read the cover letter:
https://www.virtualbox.org/pipermail/vbox-dev/2017-July/014624.html

I just want to say that this is STILL an issue. I just ran into it with VirtualBox 7.0.22r165102


Get users id

Hi everyone, my question:
is possible get a user id in any way? I would search a user from his name and print his recently artist played
Thanks

ya using the me function
token = util.prompt_for_user_token(username, scop, SPOTIPY_CLIENT_ID, SPOTIPY_CLIENT_SECRET, SPOTIPY_REDIRECT_URI)     if token:         sp = spotipy.client.Spotify(auth=token)         results = sp.me()
the return will be a dictionary(the python to equivalent to JSON)
in the dictionary there is more info just then user id (email , Birth-Day,profile photo etc... ) i think it depend on your scop you ask with your token

Ok thank you for my current user,
but if i want the id of my friend?
Thank you

@AlessandroMinervini If you know the username of your friend you can pass that as a string into this method. https://github.com/plamere/spotipy/blob/4c2c1d763a3653aa225c4af848409ec31286a6bf/spotipy/client.py#L346
Also see the Web Api docs for more information Get user's profile

It's unclear what you are really asking but if you are looking to search a user by display name in order to get the ID, it doesn't seem possible. Probably this is for security/privacy reasons. As @mckinly suggested, you need the user ID to find a user.


when /etc/nsswitch.conf doesn't exist , Go's DNS work like an unexpect way

What version of Go are you using (go version)?

$ go version
go version go1.13.8 linux/amd64
but the problem exist in both 1.12 1.13 1.14 ...

Does this issue reproduce with the latest release?
yes
What operating system and processor architecture are you using (go env)?
go env Output
$ go env
GOARCH="amd64"
GOBIN=""
GOCACHE="/root/.cache/go-build"
GOEXE=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="linux"
GOOS="linux"
GOPATH="/go"
GOPROXY=""
GORACE=""
GOROOT="/usr/local/go"
GOTMPDIR=""
GOTOOLDIR="/usr/local/go/pkg/tool/linux_amd64"
GCCGO="gccgo"
CC="gcc"
CXX="g++"
CGO_ENABLED="1"
GOMOD=""
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -fmessage-length=0 -fdebug-prefix-map=/tmp/go-build381088182=/tmp/go-build -gno-record-gcc-switches"

What did you do?

in remote DNS server
a.test.com reslove as   <IP_ADDRESS>
in /etc/hosts i hava a record
<IP_ADDRESS> a.test.com
golang app will reslove a.test.com as <IP_ADDRESS>
however  , ping curl php app java app and so on will resolve a.test.com as <IP_ADDRESS>
What did you expect to see?
when /etc/nsswitch.conf doesn't exist ，Go's DNS use file first
in this , golang app should resolve a.test.com as <IP_ADDRESS>
What did you see instead?
golang app will reslove a.test.com as <IP_ADDRESS>

The GNU/Linux man nsswitch.conf is clear, as is the implementation: if there is no hosts line in /etc/nsswitch.conf, the default is "dns [!UNAVAIL=return] files".  And that is what the net package implements.
The behavior you are seeing is not due to the net package handling of /etc/nsswitch.conf.  It's due to how the C getaddrinfo function works.  The C function calls inet_aton and inet_pton before checking either DNS or /etc/hosts.  In other words, the C function is not doing a DNS lookup; it's first checking whether it has an IP address.  If that's the behavior you want, call net.ParseIP.
I'm going to close this issue because it is not a bug.


Improving snapshot comments

Made a bash script  as "proof of work" and now using with fzf preview or just itself. Main reason is to get more info about installing, upgrading, deleting packages - which are they.
Idea is simple: parse strings from /var/log/pacman.log after all transactions with packages are completed and updating comment in *-meta.json file. Should work as post installation hook i guess.
Is it possible to add this feature in main python code? I'm not so good in Python, so I made a bash example how it might look like.. :)
The second question is: is it possible make a comment for snapshots with trigger S, e.g. Hourly shapshot, Weekly shapshot, etc?

Made a bash script as "proof of work" and now using with fzf preview or just itself. Main reason is to get more info about installing, upgrading, deleting packages - which are they.

Totally open to it - I will take a look and integrate it. Thank you!

The second question is: is it possible make a comment for snapshots with trigger S, e.g. Hourly shapshot, Weekly shapshot, etc?

Yes, though this will require some more changes.
The current logic does not fix the duration of a snapshot when it is taken. Instead, it scans and ensures the required number of snaps are kept every time the schedule runs. So there is no way to tell beforehand if a snap will be kept for a month, 6 months, etc.
I can see how knowing the duration can be helpful. It will require switching to a method where the duration of a snap is fixed as a TTL (time to live) when the snap is taken based on how many snaps exist. Let me think about it.

Just took a look. The script is great! Have some questions.
Btw for me the script did not work, due to the awk line.
But I get the gist, you want something like this -
[Installed: sdl2, libsoup3, enchant] [Upgraded: fwupd, electron5] [Removed: imagemagick]

Thoughts -

The above is not exactly your output, but similar.
If I am not mistaken, the action might be better to be picked up per package since one operation can do multiple things. LMK if you disagree!

This will often generate a very large comment, e.g. during pacman -Syu since a lot of packages will be changed. I think the current yabsnap list will not handle it very well.

I am thinking if I should break this off so that this part can be easily tinkered and edited. E.g. add a config parameter, that can call arbitrary binary to get the pacman summary! Or, may be for now I will put this in a separate python file so it's easy to tweak.

Finally, moving this to post-hook makes sense. But this makes re-editing the json after-the-fact unavoidable. I will need to make some changes to handle this - let me think about it!

Btw for me the script did not work, due to the awk line.

Sad to hear that.. For me its look like this:
$ ./snaplist.sh
List of snapshots: 7

2023-10-24 12:30:22    source: /, trigger: S
2023-11-06 10:09:25    source: /, trigger: S
2023-11-10 08:29:52    source: /, trigger: S
2023-11-10 10:23:33    source: /, trigger: I, comment: pacman --color=always --sync --sysupgrade

Upgrading ark 23.08.2-2 -> 23.08.3-1, baloo-widgets 23.08.2-1 -> 23.08.3-1, libkexiv2 23.08.2-1 -> 23.08.3-1, kio-extras
23.08.2-2 -> 23.08.3-1, kuserfeedback5 1.3.0-3 -> 1.3.0-4, dolphin 23.08.2-1 -> 23.08.3-1, libkdcraw 23.08.2-1 -> 23.08.3-1,
signon-kwallet-extension 23.08.2-1 -> 23.08.3-1, kaccounts-integration 23.08.2-1 -> 23.08.3-1, gwenview 23.08.2-1 ->
23.08.3-1, kate 23.08.2-1 -> 23.08.3-1, kdeconnect 23.08.2-2 -> 23.08.3-1, konsole 23.08.2-1 -> 23.08.3-1, kwalletmanager
23.08.2-1 -> 23.08.3-1, spectacle 23.08.2-1 -> 23.08.3-1, sudo 1.9.15.p1-1 -> 1.9.15.p2-1, telegram-desktop 4.11.5-1 ->
4.11.6-1, yakuake 23.08.2-1 -> 23.08.3-1

2023-11-10 12:26:18    source: /, trigger: I, comment: /usr/bin/pacman -S --asdeps wireguard-tools

Installing wireguard-tools 1.0.20210914-1, yarn 1.22.19-1, go 2:1.21.4-1

2023-11-10 16:36:56    source: /, trigger: S
2023-11-10 18:30:16    source: /, trigger: S

But I get the gist, you want something like this

Some kind of that, but with the versions. All information already is in log, we need just make squeeze of it in human readable view.

action might be better to be picked up per package since one operation can do multiple things

It will increase size of common comment of transaction. I propose take the action from line with pacman options only.  Sometimes it will be different operation, like installing or uniunstaling some packages during system update, but it not so insignificant. With the info about versions it intuitive to understand what is going on.

yabsnap list

It can be done by adding a new item, e.g. commentlong and it might show with yabsnap list --long option. By default, will be short version, like: comment: pacman -S wireguard-tools [ I: 3, U: 5, D:2 packages ]
Or just cut of long comment after 60 letters :)

Finally, moving this to post-hook makes sense. But this makes re-editing the json after-the-fact unavoidable.

I'm agree with it, will require re-editing and pacman have this opportunity by design. It’s quite strange that no one has made a parser yet. I had a look on pacman-contrib package and found only paclog-pkglist that do the same as pacman -Q.


feat: Experiment docker

feat: Add experiment docker
experiment: Harden DSP experiments
experiment: DSP script

We still need to harden the DSP code so it can handle Lean/Aesop crashes