Build failure: kicad-unstable

Steps To Reproduce
Steps to reproduce the behavior:

build kicad-unstable

Build log
kicad-unstable.log
Additional context
Updating to TOT does not fix issue.
Notify maintainers
@evils
Metadata
Please run nix-shell -p nix-info --run "nix-info -m" and paste the result.
 - system: `"x86_64-linux"`
 - host os: `Linux 6.6.44, NixOS, 24.11 (Vicuna), 24.11pre666839.c3aa7b8938b1`
 - multi-user?: `yes`
 - sandbox: `yes`
 - version: `nix-env (Nix) 2.18.5`
 - channels(root): `"nixos"`
 - channels(mpiechotka): `""`
 - nixpkgs: `/nix/var/nix/profiles/per-user/root/channels/nixos`

Add a :+1: reaction to issues you find important.

Actually the update might work but my WAR to build kicad-unstable might prevent it.

I will try to create pr if I succeeds with update directly in nixpkgs.

Unstable Kicad fails for me with the following:
sudo nixos-rebuild switch --upgrade
unpacking 4 channels...
building Nix...
building the system configuration...
error:
       … while calling the 'head' builtin
         at /nix/var/nix/profiles/per-user/root/channels/nixos/lib/attrsets.nix:1:35787:
       … while evaluating the attribute 'value'
         at /nix/var/nix/profiles/per-user/root/channels/nixos/lib/modules.nix:1:33591:
       … while evaluating the option `system.build.toplevel':

       … while evaluating definitions from `/nix/var/nix/profiles/per-user/root/channels/nixos/nixos/modules/system/activation/top-level.nix':

       … while evaluating the option `system.systemBuilderArgs':

       … while evaluating definitions from `/nix/var/nix/profiles/per-user/root/channels/nixos/nixos/modules/system/activation/activatable-system.nix':

       … while evaluating the option `system.activationScripts.etc.text':

       … while evaluating definitions from `/nix/var/nix/profiles/per-user/root/channels/nixos/nixos/modules/system/etc/etc-activation.nix':

       … while evaluating definitions from `/nix/var/nix/profiles/per-user/root/channels/nixos/nixos/modules/system/etc/etc.nix':

       … while evaluating the option `environment.etc."profiles/per-user/human".source':

       (stack trace truncated; use '--show-trace' to show the full, detailed trace)

       error: expected a Boolean but found a set: { _type = "pkgs"; AAAAAASomeThingsFailToEvaluate = «thunk»; AMB-plugins = «thunk»; ArchiSteamFarm = «thunk»; AusweisApp2 = «thunk»; BeatSaberModManager = «thunk»; CHOWTapeModel = «thunk»; ChowCentaur = «thunk»; ChowKick = «thunk»; ChowPhaser = «thunk»; «21563 attributes elided» }
       at /nix/store/jp1m4r344yhziff9kc6bjbw72mhfmjhr-nixos/nixos/pkgs/applications/science/electronics/kicad/default.nix:276:20:
          275|   meta = rec {
          276|     description = (if (stable)
             |                    ^
          277|     then "Open Source Electronics Design Automation suite"

I'm finding that this issue recently found its way into the normal kicad package.

Really strange. Adding the cmake flags doesn't help. It looks like we are building against 1.8.4, so I'm really confused.

Hardcoding the parents type to either/or causes the build to fail either way for me. (wtf?)

I think it's the other way around. The commit that added that code was only added two weeks ago:
https://gitlab.com/kicad/code/kicad/-/commit/9f579f787bc6b62ca456f87f92d8e96107b24206
We're actually taking the top branch, which was fine when libgit2 was version 1.8.3. But now that libgit2 has updated to 1.8.4 in nixpkgs, we should be taking the bottom branch, but we're still using sources older than when that commit was made, so we're still taking the top branch.
Changing the source of kicad-unstable to a version newer than that commit leads to a successful build for me. Alternatively, maybe we could add a patch that applies that commit to all of our kicad derivations.


Update onPropertyChange API docs for new notifyPropertyChange

Concerning: http://api.dartlang.org/docs/releases/latest/observe.html#onPropertyChange
Currently it shows:
    _sub = onPropertyChange(_otherModel, #value,
        () => notifyProperty(this, #prop);
But I think it should show:
     notifyPropertyChange(#prop, oldValue, newValue)

This issue has been moved to dart-lang/observe#50.


[Bug] Mount & {#}

Cross-posting from MATT.

https://github.com/ironmonk88/monks-active-tiles/issues/834
Foundry 12.331
MATT 12.02
Tagger 1.5.1
Rideable 3.0.6

I never used that part of tagger but as far as i can tell the use case for this is, that when a template is placed, all {#} are replaced in the placed template are replaced with a number so that they only reference the entities within the same placed template copy, right?
If so everything seems to work correctly on my end, i.e. the the {#} are replaced with a number when a template is placed, just as it is the case with e.g. the teleport action.


[WIP #1568]Added Tests for generator page

Partially Fixes #1568

@geekyd @Princu7 please check these tests.

@geekyd please check I have added some more tests.


validator didn't catch malformed string in "comments"

#27 fixed errors introduced in #25 where a colon in the "comments" field caused it to be parsed as a key:value pair instead of a string
however, the changes in #25 passed verification
our current schema for this field is
class Comment(ConstrainedStr):
    max_length = 300

https://github.com/chanzuckerberg/napari-hub-collections/blob/main/validation/schema.py#L10-L11
why did this pass validation?
Documentation: https://pydantic-docs.helpmanual.io/usage/models/
Todo:

edge cases (more than 300 characters, invalid data type, etc)
base cases (expected to be validated correctly, per yaml files provided in the repo)

As of now, II have fnished writing up a few test cases today per the todo list above. One of the test cases I have written up does behave the way I want to (Scanner Error from the additional : in the yaml file)! Right now, the gap I am trying to figure out is why I am able to reproduce the error in the way that I want to, but the malformed string didn’t get caught in #25, so that is my next step.

PR is here: https://github.com/chanzuckerberg/napari-hub-collections/pull/36


[WIP]Add e2e-stage directory for weekly periodic

Codecov Report

Merging #566 (3682392) into master (19b5dc3) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #566   +/-   ##
=======================================
  Coverage   38.43%   38.43%
=======================================
  Files          13       13
  Lines        2849     2849
=======================================
  Hits         1095     1095
  Misses       1673     1673
  Partials       81       81

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 19b5dc3...3682392. Read the comment docs.

Remove nitishSr, other than that.. +1

not needed anymore.. thanks!


[bug] URL Encoding to support Blob names with special characters

Blobs are allowed to have special characters in their name which will need to be encoded when they are used as part of the service URL.
Questions stand on where the encoding should happen, there are a few places where a blob name is set

Setting the endpoint in the builder (this would likely be a URL)
Setting the blob name in the builder (this could be from a URL)
Getting a blob client from the container client (this could be from a URL)

A broader discussion will need to occur given the URL encoding issues found within Files.

Plan is to add documentation to the blobName setter methods in our builders to indicate that blob names need to be encoded.
If the encoding process is more complicated add in a helper method to perform the encoding and use that in the documentation.

Documentation should also go in the ContainerClient methods that construct any form of blob client.
We've used the internal Utility method in the past to special case /+/%20 to do the right thing. It has caused problems in the past with SAS signatures in the query parameters, but I can't say off hand whether this will be strictly necessary for the blob names. I tend to think not because we didn't internally encode in v8 and just let the customer do it themselves.

I tested a few options including the Utility method Rick mentioned and that one seemed to be the best one for UTF-8 encoding while converting spaces into %20.
For testing I used all printable and extended ASCII characters. I also used a bunch of different Unicode characters for languages such as Chinese, Russian, Korean, Greek, Japanese and even more obscure ones like Esperanto. I found no issues when trying to upload or download blobs with names containing these characters while using Utility.urlEncode() to encode their names.
I also discovered a couple interesting things:

Azure Storage does not seem to encode the following ASCII characters when manually generating a SAS URL !'()*-./\_~.
Our utility method does not encode the following ASCII characters: *-._.
Forward slashes / and backslashes \ are both used for establishing virtual hierarchies by the Azure Storage service, which will finally parse them to /.
ASCII characters not allowed on blob names while using the web UI are: # and %.
Uploading files that contain a percentage symbol % is also not allowed through the Azure SDK.
However, you can use the Azure SDK to upload blob names that start with a pound/hashtag (#) with no encoding. The Azure Service would create a blob with no name in such a case.

Even though we incur in some over-encoding for 7 ASCII characters, I don't believe it should cause any issues and I think we could implicitly do the encoding for the user instead of leaving that responsibility to them. I have already discussed this possibility with @joshfree and @alzimmermsft and both seem to agree. What do you think @rickle-msft?

Thanks for doing such a thorough investigation! Since it seems quite safe to encode the names ourselves, it seems to make sense that we can just do it for the customer.

@vcolin7 can you give an update on this bug?

Hi @joshfree, I have addressed the comments and concerns raised by @rickle-msft, made sure all tests ran and added some of my own and I'm just waiting for his or @gapra-msft/@jaschrep-msft approval. In the meantime I'm just going to solve some merge conflicts. Also, I'm still not sure if we need to send this PR to adpship as well.
It would also be good if you or @alzimmermsft could review the latest changes.

Sent an email to adpship after getting Rick's approval.

Merged to master after adpship approval.

Thanks @vcolin7 for fixing this issue


Regarding reading settings

Describe your suggested feature
Upon opening the chapter if we click anywhere on the screen it should show reading settings like tachiyomi. Where we can change font size, color of background and other settings. So we don't have to go to settings to change it. It's a hassle and we can't see preview if we change something from settings for example if I increase font size i can't see it instantly how much i should increase or decrease the font size.
Other details
No response
Acknowledgements

[X] I have searched the existing issues and this is a new ticket, NOT a duplicate or related to another open or closed issue.
[X] I have written a short but informative title.
[X] If this is an issue with an extension, I should be opening an issue in the extensions repository.
[X] I have updated the app to version 0.1.28.
[X] I will fill out all of the requested information in this form.

this feature is available in app, can you tell me what is version of your android?


status hook for the container network

Extending the network plugin to include a status hook that gets the Pod's IPAddress information as decided by the network plugin. Until now, even though the network could be plumbed by a network plugin, the IPAddress of the pods was obtained from container runtime (e.g. docker inspect) only.
A 'status' API (and a corresponding hook in the exec plugin) lets the plugin give out the IPAddress as it deems fit. This feature is particularly necessary if the network plugin chose its own IPAM and not the one provided by container-runtime.
Marking this as a Work-In-Progress, feedback please.
@errordeveloper @jainvipin @mapuri @thockin @mrunalp @joeswaminathan

@jainvipin Replaced IPv4/v6 with just one field at the top level struct that represents the primary IPAddress that kube should store for the pod (docker inspect style).

@rajatchopra - LGTM!
Thanks for the important contribution. We'll use it.

@thockin I think this one is ready. Also, is there anything I have to do for my CLA under RedHat?

Assigned @thockin
v1.0 triage needed

@thockin as per today's discussion at DockerCon: please prioritise this: from an networking plugin pov we heed this status hook for checking IP address allocation / @rajatchopra @abhat @mrunalp
Kindest thanks yet again.

@thockin what's the status of this from your pov?

Sorry for latency - I've had it up on my screen for 2 weeks.  Reviewing now.

@thockin Thanks for taking a look here. Updated the PR. Handled the error messages, nil/nil case and json explicit strings for the struct. Also docker's status will be overridden only if the network plugin is valid and returns a valid IP.
Still working on a suitable way to include the api version for the json blob.

Feedback incorporated with updated PR.
One thing remains:
The fallback testcase - when plugin returns "", docker's info will be used and no test covers that yet. Will think about an e2e for this, or possibly use some of the fake docker bits.

Mostly small points left

@thockin hopefully the final review from you. Thanks.

I find nothing else to pick at.
LGTM

@k8s-bot ok to test


Add horizontal scroll support to Table widget

Is your feature request related to a problem? Please describe.

I want to show some data inside the Table widget, my data need about 30 columns, if I just add it with default table it will just expand the parent because currently table don't have any horizontal scroll... Even with expanding I still can't see all the columns, so having a horizontal scroll built-in In Table would be good.
Describe the solution you'd like

Adding support for enabling a horizontal scroll in table.
Another thing that I think worth adding is horizontal index in Table rows method (or adding a new method for it that have both) currently rows only have vertical index, having this would help in showing Data that have so many columns.
Describe alternatives you've considered

I tested putting TableBuilder in ScrollAres::horizontal and it did kinda worked, but problem was it moved vertical scroll all the way to the right side... So If I want to access it I need to scroll all the way to right... That's a problem.
One other thing that I tested was changing source of table builder to use ScrollArea::both instead of default vertical one, but result was not what I expected, an vertical scroll did appear, but when I try to scroll all the table and columns bugged (the vertical separator move incorrectly and...)
Additional context

Well I  think  having this feature is a fundamental need in a table widget, so I hope it  get aaded

A good use-case for this would be a database management app. I've been thinking about trying to make a MySQL one like HeidiSQL, however it wouldn't be possible without horizontal scrolling because tables can have any number of columns.

With the latest release of egui (0.20) this problem seems to be fixed. now the hscroll will always stick to side of Table, even if table is inside a ScrollArea.
but it have some visual glitches, like:

The horizontal lines that can be used to separate each column can clip through the hscroll.
If we go to end of hscroll we can see the scroll itself move a little, would be better for it to always stick to the sides.
Here is a video of the glitches

https://user-images.githubusercontent.com/18105381/207059542-e0bc4c03-c47f-4172-9fa1-e6c4111a1486.mp4


Not working on Windows(OS)

the issue was mentioned on discord, but i'll rewrite it here so that other can see it, it's not working on Windows(OS), the imports path are wrong, hope it could be fixed soon ^^
[vite] Internal server error: Failed to resolve import "/@fsC:/Users/UserName/Desktop/projects/javascript/test-storybook/.storybook/preview.js" from<EMAIL_ADDRESS>Does the file exist?
  Plugin: vite:import-analysis
  File<EMAIL_ADDRESS>  8  |      import { addDecorator, addParameters, addLoader, addArgTypesEnhancer } from '@storybook/client-api';
  9  |      import { logger } from '@storybook/client-logger';
  10 |      import * as config_0 from '/@fsC:/Users/UserName/Desktop/projects/javascript/test-storybook/.storybook/preview.js'
     |                                 ^
  11 |  import * as config_1 from '/<EMAIL_ADDRESS>  12 |  import * as config_2 from '/<EMAIL_ADDRESS>      at formatError (C:\Users\UserName\Desktop\projects\javascript\test-storybook\node_modules\vite\dist\node\chunks\dep-5c642f9e.js:43549:46)
      at TransformContext.error (C:\Users\UserName\Desktop\projects\javascript\test-storybook\node_modules\vite\dist\node\chunks\dep-5c642f9e.js:43545:19)
      at normalizeUrl (C:\Users\UserName\Desktop\projects\javascript\test-storybook\node_modules\vite\dist\node\chunks\dep-5c642f9e.js:45157:26)
      at async TransformContext.transform (C:\Users\UserName\Desktop\projects\javascript\test-storybook\node_modules\vite\dist\node\chunks\dep-5c642f9e.js:45285:57)
      at async Object.transform (C:\Users\UserName\Desktop\projects\javascript\test-storybook\node_modules\vite\dist\node\chunks\dep-5c642f9e.js:43747:30)
      at async transformRequest (C:\Users\UserName\Desktop\projects\javascript\test-storybook\node_modules\vite\dist\node\chunks\dep-5c642f9e.js:59401:29)
      at async C:\Users\UserName\Desktop\projects\javascript\test-storybook\node_modules\vite\dist\node\chunks\dep-5c642f9e.js:59538:32
15:18:05 [vite] Internal server error: Failed to resolve import "/@fsC:/Users/UserName/Desktop/projects/javascript/test-storybook/.storybook/preview.js" from<EMAIL_ADDRESS>Does the file exist?
  Plugin: vite:import-analysis
  File<EMAIL_ADDRESS>  8  |      import { addDecorator, addParameters, addLoader, addArgTypesEnhancer } from '@storybook/client-api';
  9  |      import { logger } from '@storybook/client-logger';
  10 |      import * as config_0 from '/@fsC:/Users/UserName/Desktop/projects/javascript/test-storybook/.storybook/preview.js'
     |                                 ^
  11 |  import * as config_1 from '/<EMAIL_ADDRESS>  12 |  import * as config_2 from '/<EMAIL_ADDRESS>      at formatError (C:\Users\UserName\Desktop\projects\javascript\test-storybook\node_modules\vite\dist\node\chunks\dep-5c642f9e.js:43549:46)
      at TransformContext.error (C:\Users\UserName\Desktop\projects\javascript\test-storybook\node_modules\vite\dist\node\chunks\dep-5c642f9e.js:43545:19)
      at normalizeUrl (C:\Users\UserName\Desktop\projects\javascript\test-storybook\node_modules\vite\dist\node\chunks\dep-5c642f9e.js:45157:26)
      at async TransformContext.transform (C:\Users\UserName\Desktop\projects\javascript\test-storybook\node_modules\vite\dist\node\chunks\dep-5c642f9e.js:45285:57)
      at async Object.transform (C:\Users\UserName\Desktop\projects\javascript\test-storybook\node_modules\vite\dist\node\chunks\dep-5c642f9e.js:43747:30)
      at async transformRequest (C:\Users\UserName\Desktop\projects\javascript\test-storybook\node_modules\vite\dist\node\chunks\dep-5c642f9e.js:59401:29)
      at async C:\Users\UserName\Desktop\projects\javascript\test-storybook\node_modules\vite\dist\node\chunks\dep-5c642f9e.js:59538:32 (x2)

original, https://discord.com/channels/486522875931656193/826188253849190450/834920582411714590
a "maybe" solution

In case it helps, there is a normalizePath exported from the vite package that should be used by plugins if there are comparisons between paths and ids. Check out Doc
source : https://discord.com/channels/486522875931656193/826188253849190450/835028585722937373

my bad, after looking at the code in the repo, i can see that normalizePath() is already being used, but it's still not fixing the issue

for windows, removing the /@fs part was enough to fix the issue, i don't know if it has an impact on other OS though

Yeah, I recently tried to fix it with normalizePath, but I don't have a Windows computer to test it on... What does the whole file URL look like in the browser when you remove /@fs? (If you pick one of your source files as an example)

this is one of the example files, compiled and shown in the browser under sources/localhost:6006
Button.vue
import { createHotContext as __vite__createHotContext } from "/@vite/client";import.meta.hot = __vite__createHotContext("/@fs/C:/Users/UserName/Desktop/projects/javascript/test-storybook/src/stories/Button.vue");
import '/@fs/C:/Users/UserName/Desktop/projects/javascript/test-storybook/src/stories/button.css';
import { reactive, computed } from '/@fs/C:/Users/UserName/Desktop/projects/javascript/test-storybook/node_modules/storybook-builder-vite/node_modules/.vite/vue_dist_vue_esm-bundler_js.js?v=ed0c4be2';

const _sfc_main = {
  name: 'my-button',

  props: {
    label: {
      type: String,
      required: true,
    },
    primary: {
      type: Boolean,
      default: false,
    },
    size: {
      type: String,
      validator: function (value) {
        return ['small', 'medium', 'large'].indexOf(value) !== -1;
      },
    },
    backgroundColor: {
      type: String,
    },
  },

  emits: ['click'],

  setup(props, { emit }) {
    props = reactive(props);
    return {
      classes: computed(() => ({
        'storybook-button': true,
        'storybook-button--primary': props.primary,
        'storybook-button--secondary': !props.primary,
        [`storybook-button--${props.size || 'medium'}`]: true,
      })),
      style: computed(() => ({
        backgroundColor: props.backgroundColor,
      })),
      onClick() {
        emit('click');
      }
    }
  },
};

import { toDisplayString as _toDisplayString, openBlock as _openBlock, createBlock as _createBlock } from "/@fs/C:/Users/UserName/Desktop/projects/javascript/test-storybook/node_modules/storybook-builder-vite/node_modules/.vite/vue_dist_vue_esm-bundler_js.js?v=ed0c4be2"

function _sfc_render(_ctx, _cache, $props, $setup, $data, $options) {
  return (_openBlock(), _createBlock("button", {
    type: "button",
    class: $setup.classes,
    onClick: _cache[1] || (_cache[1] = (...args) => ($setup.onClick && $setup.onClick(...args))),
    style: $setup.style
  }, _toDisplayString($props.label), 7 /* TEXT, CLASS, STYLE */))
}

_sfc_main.render = _sfc_render
_sfc_main.__file = "C:/Users/UserName/Desktop/projects/javascript/test-storybook/src/stories/Button.vue"
export default _sfc_main
_sfc_main.__hmrId = "ed4d51ec"
typeof __VUE_HMR_RUNTIME__ !== 'undefined' && __VUE_HMR_RUNTIME__.createRecord(_sfc_main.__hmrId, _sfc_main)
import.meta.hot.accept(({ default: updated, _rerender_only }) => {
  if (_rerender_only) {
    __VUE_HMR_RUNTIME__.rerender(updated.__hmrId, updated.render)
  } else {
    __VUE_HMR_RUNTIME__.reload(updated.__hmrId, updated)
  }
})

everything seems to works fine, at least for me, the only issue i have is that i can't import WindiCSS but it probably has nothing to do with this 😢

I'm confused now - does it work on Windows or not? Is the issue with Windows in general, or WindiCSS in specific?

To summarize,  on windows, you need to remove the /@fs from this line https://github.com/eirslett/storybook-builder-vite/blob/825b3b064541d89c78faf58aae08b91397ada232/packages/storybook-builder-vite/codegen-iframe-script.js#L38
for it to work, but it should be verified if removing it breaks something on other os

@Zenthae Does it work if you add an extra slash? }'/@fs/${normalizePath(el)}' could you try that?

@eirslett it works with the extra slash.

@Zenthae Try using version 0.0.6 of the plugin (I just published it now). I added the extra slash. Does it work?

it's working 👌


Enabled approvers and turned of cache for contrib

Looks like the http cache was responsible for the duplicate comments on contrib as ListComments() was returning an empty set of Comments on Issues where the bot had commented before.  This is not a permanent/good solution as we will hit the github rate limit on kubernetes/kubernetes but for the purposes of testing on contrib, it may be okay.
*Verified that the bot is no longer double commenting on PRs

This change is

Looking at http://contrib.submit-queue.k8s.io/#/info
The last count I saw for uncached calls to github's api was 676 and since the bot runs every 10 minutes, that will result in (60/10)*676 = 4056 calls per hour.  Not great, but under the limit

/lgtm

If rhe contrib submit queue alone makes that many Api calls, that would be undesirable. The 5k per hour limit applies across all the submit queue.

/approve

@grodrigues3 and I discussed and we'll turn the cache back on if we start seeing the limit being hit. Monitoring API token usage at velodrome.kubernetes.io/dashboard/db/monitoring
@lavalamp

I haven't looked at this yet, but turning off the cache is almost certainly wrong. We should be working with github support and getting them to fix their api...

So I removed LGTM. Can you show me the reason we are blaming the cache and the response we got from github?

That was very sloppy of me, I didn't notice the cache being turned off. I agree w/ @eparis, we shouldn't turn that off.

I think it was meant to be experimental while we figure out the cache issue; and I think the currently running contrib submit queue has its cache turned off. http://velodrome.kubernetes.io/dashboard/db/monitoring shows we didn't run close to the limits.
@grodrigues3 can confirm.

correct, it was intended to be experimental.

@eparis @lavalamp
So I need some debugging help regarding the double postings.  This log is from a run with the cache disabled and approvers running (as merged in master)
For #2289 the approvers-handler commented twice, but it seems that it only did so after the PR was merged.  Given the approvers code that handles notifications, it should only ever add a new comment when it does not find an older comment (i.e latestNotification = nil).
As implemented, if the PR is modified after approval or if someone approves, approvers only edits the existing comment (EditComment) and it should add information why it's editing the comment (either "Latest approve was after last time notified" or "PR Modified After Last Notification").    Neither of those happen in the following log
http://pastebin.com/W3wL9ydS
So I'm hypothesizing that ListComments is returning an empty list for some reason (seemingly after the PR is modified, since it's not double commenting at any other time).  I've seen it happen once before, but I can't reproduce regularly.  I'd really appreciate any debugging help, suggestions.

On another note, is anyone else in favor of creating a dummy repo for bot testing purposes?  Since I can't always reproduce the bots behavior with local runs, it'd be great if I could deploy it against a repo for experiments like these without disabling, harming the SQ.

Code I added to approval-handler when running against my repo https://github.com/grodrigues3/contrib/pull/3
glog.Infof("Found %v comments for issue %d, %d of which were written by the bot", len(comments), *obj.Issue.Number, len(notifications))
Output
`

I0112 12:35:40.298398  108848 approval-handler.go:131] Found 0 comments for issue 3, 0 of which were written by the bot

`

So that proves it's not a cache issue?  Are we using the right comment lister? I know there is a PR comments list and an issue comments list. I think both are exposed in github.go...

I'm using
https://github.com/kubernetes/contrib/blob/master/mungegithub/github/github.go#L1860

Closing because investigation showed the http cache wasn't the problem


Highlight color of search

I love your theme very much, but I have a big problem with searches in a note.
Especially if text is highlighted, it is hard to distinguish between search results and the rest of the text.
I use the dark theme.
I wish, that there could be another color for search-results. This would be very useful.

The second thing is the mark of the spaced-repetition plugin. I think it could be in a lighter color, smaller or both.

Yes it is hard to see. I've tweaked the search highlight colors to be more noticeable.

COOOL! Thank's a lot for this update! Nice Color!
Now it's much easier to work with long documents.

Well, after the update, I cannot change fontsize per mousewheel anymore, although it is activated.
It works with default theme, but not with obsidian nord.

I tried it a few times. Changed Themes. Tried other programs.
Scrolling with ctrl+mousewheel works in my browser etc., and with another obsidian-themes, but when I come back to obsidian nord nothing happens. I use Windows 10.
I'm sorry.

No problem. Maybe file a new issue on this for tracking?
Btw, are you trying to change the font size in the preview window or the editor?


Remove 'when' dependency from hellosign-nodejs-sdk

Hey Yall!
Im a developer @ Osmind. We were recently using the hellosign-sdk in a project w/ esbuild and one of the dependencies blew up on us.
Specficially we were seeing errors with when:
"error":"Cannot find module './lib/decorators/timed'\nRequire stack:\n- /var/task/getHellosignTemplate.js\n- /var/task/s_getHellosignTemplate.js\n- /var/runtime/UserFunction.js\n- /var/runtime/index.js"}

I dug into the source code and noticed that when uses some shims to allow for browser compatibility which is causing our build to fail.
I've decided to add a PR to remove when as a dependency to this lib and instead use a method for deferred promises with the native Promise api. This should be supported Node 4+.
I've ran tests against my own code and the tests from the library and they seem to pass. Let me know if there is any other work that needs to be done to get this upstream

@ejm201 following up on this

@ejm201 This jus bit me, what's the status of merging it in? 🙏


Added compatibility for Blend Mode in Light2D/PointLight2D when converting from Godot 3 to 4.

Fixes #77887
This ensures that when upgrading your project from Godot 3 to Godot 4, the Blend Mode of any Light2D (that becomes PointLight2D) will be preserved.

Thanks!


snippet and intellisense management IS TERRIBLE

in Js ..
typing for instance:  a
I get stuff i've got no clue where it's from or why..

so :( ... I do not use twiter where you guys are asking for feedback, so here's what I think.. so much great stuff, but falling at the basics and most important ones, I'm back on atom

Those are auto import suggestions. They come from all public exports in your project. Accepting one will add the correct import
You can find more information about them and how to disable them here: https://code.visualstudio.com/Docs/languages/javascript#_auto-imports


Added support for Mac OSX

Tested on Mac OSX Catalina with Visual Studio Code 1.42.0 and SDL Version 2.0.10

I don't like solution with -D APPLE_SDL. IMO that breaks advantages of PIO - cross platform work. It looks like driver.c patches should be part of lv_drivers. Let me know what do you think.

Hi, no Problem, this is a "simple and stupid" workaround for that.
I've changed it now to use following flags:
syscalls.c:
#if !defined(APPLE) && !defined(TARGET_OS_MAC) && BUILD_ENV_NAME == stm32f429_disco
driver.c:
#if defined(APPLE) && defined(TARGET_OS_MAC)
if APPLE && TARGET_OS_MAC

Let me explain my point of view. For me, "demo" is something like "good, recommended sample". Not just "something forced to run with kludges". So, it would be really great to add OSX support more clean and transparent (if technically possible).
Take a look at https://github.com/littlevgl/lv_drivers/blob/master/display/monitor.c#L112. As fas as i understand, lv_drivers already have OSX support (but poorly guarded). It seems more logical to improve flags there, instead of local patches.
About sys/syscall.c - it doesn't looks correct to disable IO redirect for OSX. Need comments.

@husky-koglhof also, take a look at https://github.com/puzrin/dispenser & https://github.com/puzrin/reflow_micro, those have more fresh samples of PIO-dependent things.
@kisvegabor could you comment what is https://github.com/littlevgl/lv_platformio/blob/master/src/syscalls.c for? Probably, it should be removed at all.

OK no problem. I will incorporate my changes into lv_drivers.
stm32f429_disco is a hardware module, such as Arduino, Raspberry Pi, ...
I changed this code (syscall.c) so that I could compile the project

Hi, news: I can't call "refresh" at monitor.c, cause there's an issue when doing this on mac os x:
Terminating app due to uncaught exception 'NSInternalInconsistencyException', reason: 'nextEventMatchingMask should only be called from the Main Thread!'
So the only way i've got it compiled und running is, to have following code within driver.c "hw_loop" method:
#if defined(__APPLE__) && defined(TARGET_OS_MAC)
#  if __APPLE__ && TARGET_OS_MAC
        SDL_Event event;

        while(SDL_PollEvent(&event)) {
#if USE_MOUSE != 0
            mouse_handler(&event);
#endif

#if USE_KEYBOARD
            keyboard_handler(&event);
#endif

#if USE_MOUSEWHEEL != 0
            mousewheel_handler(&event);
#endif
        }
#endif
#endif

If it's ok for you, i will make a new PR with the relevant changes.

No, it's not ok for me. I explained above why. It would be more correct to fix drivers (at least, report bug there).

@puzrin

Probably, it should be removed at all.

To be honest I don't know if it's required or not. It should be tried out.
@husky-koglhof
Please open an issue in lv_drivers. I have an idea for this.

https://github.com/littlevgl/lv_platformio/commit/39d096609aba1089a9fc043e1039e5911f1823c0 Dropped orphaned src/syscalls.c (reduced OS-dependent places)
Created https://github.com/littlevgl/lv_drivers/issues/91

Closing, in vavour of https://github.com/littlevgl/lv_drivers/issues/91, this should be fixed in better way.

Updated drivers to fixed ones and added instructions to readme.
@husky-koglhof let me know how it is.

@husky-koglhof i've added 32-bits build support (ref)
Could you prepare instructions for OSX 32-bits libs install?
Instructions for linux are here https://github.com/puzrin/dispenser/blob/master/doc/development.md#pc-simulator


HPACK patch broken for Nginx 1.13.10

Using @PikachuEXE patch https://github.com/cloudflare/sslconfig/pull/92
patching file auto/modules
Hunk #1 succeeded at 438 (offset 1 line).
patching file auto/options
Hunk #2 succeeded at 224 (offset 1 line).
Hunk #3 succeeded at 436 (offset 2 lines).
patching file src/core/ngx_murmurhash.c
patching file src/core/ngx_murmurhash.h
patching file src/http/v2/ngx_http_v2.c
Hunk #1 succeeded at 270 (offset -2 lines).
Hunk #2 succeeded at 2056 (offset 1 line).
patching file src/http/v2/ngx_http_v2.h
Hunk #1 succeeded at 52 (offset 1 line).
Hunk #2 succeeded at 123 (offset 1 line).
Hunk #3 succeeded at 178 (offset 1 line).
Hunk #4 succeeded at 207 (offset 1 line).
Hunk #5 succeeded at 465 with fuzz 2 (offset 53 lines).
patching file src/http/v2/ngx_http_v2_filter_module.c
Hunk #1 FAILED at 26.
Hunk #2 FAILED at 93.
Hunk #3 succeeded at 155 (offset -41 lines).
Hunk #4 succeeded at 433 (offset -41 lines).
Hunk #5 succeeded at 441 (offset -41 lines).
Hunk #6 succeeded at 449 (offset -41 lines).
Hunk #7 succeeded at 467 (offset -41 lines).
Hunk #8 succeeded at 514 (offset -41 lines).
Hunk #9 succeeded at 566 with fuzz 1 (offset -41 lines).
Hunk #10 FAILED at 1039.
Hunk #11 FAILED at 1065.
4 out of 11 hunks FAILED -- saving rejects to file src/http/v2/ngx_http_v2_filter_module.c.rej
patching file src/http/v2/ngx_http_v2_table.c
Hunk #1 succeeded at 361 (offset 14 lines).

Maybe you can try my patch, https://github.com/kn007/patch/blob/master/nginx.patch

have you tried with nginx 1.3.10 master branch you patch as huge amount of changes in src/http/v2/ngx_http_v2_filter_module.c at https://github.com/nginx/nginx/blob/master/src/http/v2/ngx_http_v2_filter_module.c

Oh, sorry. My mistake.
I do not test it on 1.13.10.

Thanks @kn007 seems your patch is 3 in one for
Add SPDY Support.
Add HTTP2 HPACK Encoding Support.
Add Dynamic TLS Record support.

Do you have HTTP HPACK patch by itself ?

@centminmod I'm off work now. I'll make patch for you when I get home.

https://github.com/kn007/patch/blob/master/nginx__1.13.10_http2_hpack.patch

Thanks @kn007 it patched perfectly in 1.13.10. Very much appreciate your help with this !
patching file auto/modules
patching file auto/options
patching file src/core/ngx_murmurhash.c
patching file src/core/ngx_murmurhash.h
patching file src/http/v2/ngx_http_v2.c
patching file src/http/v2/ngx_http_v2_encode.c
patching file src/http/v2/ngx_http_v2_filter_module.c
patching file src/http/v2/ngx_http_v2.h
patching file src/http/v2/ngx_http_v2_table.c

compiled fine

nginx -V
nginx version: nginx/1.13.10
built by gcc 8.0.1 20180318 (experimental) (GCC)
built with OpenSSL 1.1.1-pre3 (beta) 20 Mar 2018
TLS SNI support enabled

configure arguments: --with-ld-opt='-L/usr/local/lib -ljemalloc -Wl,-z,relro -Wl,-rpath,/usr/local/lib' --with-cc-opt='-I/usr/local/include -m64 -march=native -DTCP_FASTOPEN=23 -g -O3 -Wno-error=strict-aliasing -fstack-protector-strong -flto -fuse-ld=gold --param=ssp-buffer-size=4 -Wformat -Werror=format-security -Wimplicit-fallthrough=0 -fcode-hoisting -Wno-cast-function-type -Wp,-D_FORTIFY_SOURCE=2 -Wno-deprecated-declarations' --sbin-path=/usr/local/sbin/nginx --conf-path=/usr/local/nginx/conf/nginx.conf --with-compat --with-http_stub_status_module --with-http_secure_link_module --add-dynamic-module=../nginx-module-vts --with-libatomic --with-http_gzip_static_module --add-dynamic-module=../ngx_brotli --with-http_sub_module --with-http_addition_module --with-http_image_filter_module=dynamic --with-http_geoip_module --with-stream_geoip_module --with-stream_realip_module --with-stream_ssl_preread_module --with-threads --with-stream=dynamic --with-stream_ssl_module --with-http_realip_module --add-dynamic-module=../ngx-fancyindex-0.4.2 --add-module=../ngx_cache_purge-2.4.2 --add-module=../ngx_devel_kit-0.3.0 --add-dynamic-module=../set-misc-nginx-module-0.31 --add-dynamic-module=../echo-nginx-module-0.61 --add-module=../redis2-nginx-module-0.14 --add-module=../ngx_http_redis-0.3.7 --add-module=../memc-nginx-module-0.18 --add-module=../srcache-nginx-module-0.31 --add-dynamic-module=../headers-more-nginx-module-0.33 --with-pcre=../pcre-8.42 --with-pcre-jit --with-zlib=../zlib-cloudflare-1.3.0 --with-http_ssl_module --with-http_v2_module --with-http_v2_hpack_enc --with-openssl=../openssl-1.1.1-pre3 --with-openssl-opt='enable-ec_nistp_64_gcc_128 enable-tls1_3'

h2load test HTTP/2 HPACK Full Encoding = 93.7+ % header space savings and counting 👍
url=https://http2.domain.com

for i in $(seq 1 20); do echo "h2load run $i"; h2load $url -n $i | tail -6 | head -1; done
h2load run 1
traffic: 6.29KB (6444) total, 344B (344) headers (space savings 36.88%), 5.89KB (6033) data
h2load run 2
traffic: 12.22KB (12513) total, 362B (362) headers (space savings 66.79%), 11.78KB (12066) data
h2load run 3
traffic: 18.15KB (18582) total, 380B (380) headers (space savings 76.76%), 17.67KB (18099) data
h2load run 4
traffic: 24.07KB (24651) total, 398B (398) headers (space savings 81.74%), 23.57KB (24132) data
h2load run 5
traffic: 30.00KB (30720) total, 416B (416) headers (space savings 84.73%), 29.46KB (30165) data
h2load run 6
traffic: 35.93KB (36789) total, 434B (434) headers (space savings 86.73%), 35.35KB (36198) data
h2load run 7
traffic: 41.85KB (42858) total, 452B (452) headers (space savings 88.15%), 41.24KB (42231) data
h2load run 8
traffic: 47.78KB (48927) total, 470B (470) headers (space savings 89.22%), 47.13KB (48264) data
h2load run 9
traffic: 53.71KB (54996) total, 488B (488) headers (space savings 90.05%), 53.02KB (54297) data
h2load run 10
traffic: 59.63KB (61065) total, 506B (506) headers (space savings 90.72%), 58.92KB (60330) data
h2load run 11
traffic: 65.56KB (67134) total, 524B (524) headers (space savings 91.26%), 64.81KB (66363) data
h2load run 12
traffic: 71.49KB (73203) total, 542B (542) headers (space savings 91.71%), 70.70KB (72396) data
h2load run 13
traffic: 77.41KB (79272) total, 560B (560) headers (space savings 92.10%), 76.59KB (78429) data
h2load run 14
traffic: 83.34KB (85341) total, 578B (578) headers (space savings 92.42%), 82.48KB (84462) data
h2load run 15
traffic: 89.27KB (91410) total, 596B (596) headers (space savings 92.71%), 88.37KB (90495) data
h2load run 16
traffic: 95.19KB (97479) total, 614B (614) headers (space savings 92.96%), 94.27KB (96528) data
h2load run 17
traffic: 101.12KB (103548) total, 632B (632) headers (space savings 93.18%), 100.16KB (102561) data
h2load run 18
traffic: 107.05KB (109617) total, 650B (650) headers (space savings 93.37%), 106.05KB (108594) data
h2load run 19
traffic: 112.97KB (115686) total, 668B (668) headers (space savings 93.55%), 111.94KB (114627) data
h2load run 20
traffic: 118.90KB (121755) total, 686B (686) headers (space savings 93.71%), 117.83KB (120660) data

You are welcome.

I test with https://http2.domain.com with h2load but space saving is 0%
Is it reverted?
I test the patch with my own website but IE11 in win10 does not like it :P

@kn007 I installed your patch for 1.13.10 and everything looked good. However, some IOS-users complained about not being able to reach our site or that they just saw garbage characters. Looks like the benchmark tool at Pingdom.com also had some problems. Here is the output from when the patch was being used: https://tools.pingdom.com/#!/bxGjiK/https://www.car.info

@PikachuEXE what's happening in IE11 ?

It won't load after first request

I tested on IE 11 Windows 7 and worked for me.

What website do you use for testing?

I test the patch with our own website with BrowserStack IE11 on Win7 again
The status code is HTTP/1.0 503 Connect failed

OK this is our testing website: https://staging.spacious.hk/en/hong-kong/for-sale
Currently using Nginx with the HPACK patch applied
IE11 on Win7 on BrowserStack sometimes crashes, which is why I am not sure if it's working for IE 11 or not

Is it?

Using win7 system with IE 11, it was working fine.

Any idea if it works with Nginx 1.14.0?

It failed for me

patching file auto/modules
Hunk #1 succeeded at 438 (offset 1 line).
patching file auto/options
Hunk #2 succeeded at 224 (offset 1 line).
Hunk #3 succeeded at 436 (offset 2 lines).
patching file src/core/ngx_murmurhash.c
patching file src/core/ngx_murmurhash.h
patching file src/http/v2/ngx_http_v2.c
Hunk #1 succeeded at 270 (offset -2 lines).
Hunk #2 succeeded at 2056 (offset 1 line).
patching file src/http/v2/ngx_http_v2.h
Hunk #1 succeeded at 52 (offset 1 line).
Hunk #2 succeeded at 123 (offset 1 line).
Hunk #3 succeeded at 178 (offset 1 line).
Hunk #4 succeeded at 207 (offset 1 line).
Hunk #5 succeeded at 465 with fuzz 2 (offset 53 lines).
patching file src/http/v2/ngx_http_v2_filter_module.c
Hunk #1 FAILED at 26.
Hunk #2 FAILED at 93.
Hunk #3 succeeded at 155 (offset -41 lines).
Hunk #4 succeeded at 433 (offset -41 lines).
Hunk #5 succeeded at 441 (offset -41 lines).
Hunk #6 succeeded at 449 (offset -41 lines).
Hunk #7 succeeded at 467 (offset -41 lines).
Hunk #8 succeeded at 514 (offset -41 lines).
Hunk #9 succeeded at 566 with fuzz 1 (offset -41 lines).
Hunk #10 FAILED at 1039.
Hunk #11 FAILED at 1065.
4 out of 11 hunks FAILED -- saving rejects to file src/http/v2/ngx_http_v2_filter_module.c.rej
patching file src/http/v2/ngx_http_v2_table.c
Hunk #1 succeeded at 361 (offset 14 lines).

@kevin25 Even using my patch?
It seems that these hunk errors are not caused by my patch.

Yes, i did. This one seems to work. I'll test it. Thank you. Cloudflare team doesn't support this anymore?

Cloudflare is using their own server, see their blog

Cloudflare open-source the patch but don't really maintain for every Nginx version

https://github.com/kn007/patch/blob/master/nginx__1.13.10_http2_hpack.patch

I got 404 error

@kevin25 https://raw.githubusercontent.com/kn007/patch/a0a6aef4b2371205f828db41c5e64ff8a24141de/nginx__1.13.10_http2_hpack.patch

I am using https://github.com/hakasenyang/openssl-patch/blob/master/nginx_hpack_push_1.15.3.patch for nginx 1.17.0

@kevin25 https://raw.githubusercontent.com/kn007/patch/a0a6aef4b2371205f828db41c5e64ff8a24141de/nginx__1.13.10_http2_hpack.patch

Thank you. Is it still working with 1.17.1?

I am using https://github.com/hakasenyang/openssl-patch/blob/master/nginx_hpack_push_1.15.3.patch for nginx 1.17.0

Thank you. Is it still working with 1.17.1?


Documentation problem: including build artifacts in the repo

There is a problem with our current method of documentation generation: that we checkin documentation build artifacts to the repository rather than only source code. This is messy. If you want to change an ascii-art diagram in a README file then we expect you to install Java (!) so that you can regenerate the PNG file using Ditaa. I think it would be much better to include only source in the repository.
How about if we would create a separate repository for the documentation, e.g. snabbdocs, and store the documentation there? This could in principle by managed by SnabbBot: it could build the documentation for PRs/merges/releases and check that into the snabbdocs repository. Then we would simplify the build dependencies for developers and always have the documentation available in various formats (e.g. markdown, html, pdf, epub).
Hydra (Nix) may also be an easy (easier?) way to build the artifacts than extending SnabbBot but with the difference (downside?) of storing the results on a filesystem of some machine rather than in a Github repo.
cc @eugeneia @wingo @kbara @domenkozar

Separating docs from source has (a possible) big downside, separating source changes from documentation changes. It's harder to pinpoint the two. It's better to not commit build artifacts in the first place, since that makes the repository quite big.
I'd recommend using a simple Markdown builder like http://www.mkdocs.org/ and https://readthedocs.org/ (supports multiple versions and multiple formats) for hosting the documentation, they're doing an awesome job keeping that site running. We could hook readthedocs into git so it would build the docs, but if that won't be possible due to dependencies we can use Nix+Hydra to publish them. Very SaaSy, but I use this workflow for all my projects and so far it worked well.

I think that the current documentation handling is extremely simple, sophisticated and scalable. I disagree that having the artifacts in the repository or installing ditaa is a problem. I am intuitively against all suggestions in this thread so far because I expect none are thought through to the end and I expect them to complicate things and/or deprive us of valuable working features.

SaaS please no. I tried to make mkdocs and readthedocs consume Snabb Switch's markdown files and ended up trying to decipher opaque error messages from their Python/Ruby/Whatever web apps. I would have considered them an option if they managed to build something useful form the Markdown in the Snabb repository without intervention, but even that would probably have been a mistake. I will not email a SaaS support hotline, so I am against SaaS.

Split repositories: I expect this would be equivalent to just throwing all the docs away and letting them rot. I don't see the upsides to this administrative overhead, I don't see how we “simplify the build” by doing that. You only need ditaa (which is trivially easy to install on any OS, including Slackware) if you want to change a diagram

I propose to cover  https://github.com/SnabbCo/snabbswitch/pull/754#issuecomment-183353494 in this discussion as well:

I also adopted an experimental documentation style here: to write real documentation in markdown syntax but include it inline at the top of the source file. The Makefile could extract this for inclusion in a manual. I still think the key to high-quality documentation is to put it somewhere that people will see it every day. Flame on! :-)

I don't think source file headers are more prominent than README.md files. I don't think people should be tricked  into seeing the docs. If someone has the desire to read the docs I am sure they will find them. I don't think the key to high-quality documentation is to move it into source files. I think extracting documentation from source code is a waste of time and introducing pointless complexity.

@eugeneia Fine: you reject all these ideas as invalid.
However: the documentation does need more enthusiastic users and contributors. How do we make that happen?

Can also be that I simply don't understand how documentation is supposed to be consumed. Is there a canonical recommended way to consume the documentation?
I know that I can read markdown sources in Emacs, or that I can browse online via Github, or that I can manually build a HTML file and copy that somewhere my browser can access it. Which of these am I expected to do? (Or should I be doing something else?)

I'd be tempted to say "whichever you prefer of those options", assuming they all work.

@kbara None of them work to my satisfaction and I would like to know which is the most important to fix.

Fair. My preference is for the first of those, but that may well be a minority view.

(Historical note: Snabb Switch was originally a kind of literate program that formatted comments in source files as markdown and interspersed them with code.)

@lukego The reason I did not propose alternatives is because I don't really get what this issue is about. It doesn't spell out a set of requirements I want to try to satisfy, and I am not convinced there is actually a bug here. I think this issue is a junction of the numerous documentation related complaints over the past weeks. To effectively act on the complaints we need to work out requirements and separate issue topics. I see two mostly unrelated topics in this thread:

How we write documentation: I am fine with the status-quo, but given a new set of requirements I am willing to find a satisfying fix. However I have to say, I don't find the implicit requirements @lukego stated in this issue particularly compelling (“Do not require Java to render diagrams”, “Do not store artifacts in repository”). I see many benefits that depend on our use of ditaa and having the docs where they are now, and only cosmetic benefit to the stated requirements. To me that sounds like much work for little effect.

How we read documentation: I am more inclined to focus on this topic and set requirements ignoring “How we write...” because this topic should dictate most of its requirements. I still think we should provide canonical URLs to pre-rendered HTML/PDF/EPUB versions of the docs.

I can do the above on davos using a simple cronjob or hacking it into SnabbBot (I am somewhat inclined to separate CI and doc rendering but @lukego pointed out that having a link to the updated docs for PRs would be a nice thing). I am thinking of a new bot “SnabbDoc” that runs in parallel to SnabbBot and pushes links to HTML docs to GitHub PRs.

@eugeneia How about this for a more concrete plan:

Define what is the canonical manual for Snabb. This could be a local directory in the source tree, a Github URL, a HTML file, a PDF file, etc but we should decide which of those things is primary.
Define how to access it e.g. a canonical URL for finding a relevant and well-defined version.
Treat any defects in this format of the manual as bugs and fix them.

This would make me happy: I could identify the manual, I could refer to it easily, and I could contribute improvements to it.
So question for you @eugeneia: does this sound like a reasonable plan and do you see a way forward to lead us down?

@lukego Sounds perfect! I think the primary should be a standalone HTML file at doc.snabb.co/<ref|branch|tag> or similar. Packagers can include the documentation by using make docs.
I would make this happen with:

doc.snabb.co pointing to davos:80
Hack up a frugal little brother of SnabbBot that does all the documentation rendering, I think this will yield much effect with little code

Great! I can totally get on board with having a stand-alone HTML manual as the primary documentation that we give loving attention to and prioritize above all other mediums. I think you are right in your comment https://github.com/SnabbCo/snabbswitch/pull/764#issuecomment-187191216 that we can still keep the markdown sources Github-friendly anyway.
How about Github Pages for hosting? I am not in favor of using a lab server in my basement as a production webserver for the project. I also see davos as long overdue for migration to NixOS... but that is a separate topic :-)

Fixed in #805.


Remove minimum length validation for login

Some usernames are shorter than the minimum 7 characters.  It's not necessary to put a minLength(), so just make both username and password required (at least 1 character) to active the LOGIN button.

How long until it takes effect?  It looks like it's not yet updated.


fix(tile): css custom properties

What I did

Fixed --rh-tile-border-color custom prop (and all other public custom props) inheritance

Testing Instructions

Go to Custom Props demo page
Test out overriding the different public CSS custom properties listed in the docs
Read explanation on accessibility issues and preferred use of theming in CSS custom properties table

Closes: #1680

This should probably get some prose on the guidelines or code page about proper and improper use of the css props

@marionnegp, I found the bug with --rh-tile-link-text-decoration, but wasn't able to replicate any issues with --rh-tile-link-color (it worked fine for me). Maybe --rh-tile-link-color was fixed in #1692 ?
Screenshot showing the custom props working:

Do you mind retesting?


Add information how to install on ubuntu 18.04

I needed to add these commands and additions to make make work.

Naturally merged. Always happy to help UBUNTU users.


Removed redundant "Monitor" main tab node.

Removed an extra node that was causing confusion on role edit/summary screen while showing the node and it's children as selected even tho it was selected and user had an access to Monitor main tab in UI.
Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1514279
@dclarizio @martinpovolny please review.
before fix, when i unselected "Control" after saving role, role summary and role edit screens showed "Monitor" as unselected as well, even tho when logging in with the new role, i could see/access Monitor menu.

after, display correct selections:

@h-kataria I think this might conflict with the Control Alerts area, let's discuss offline.

Gaprindashvili backport details:
$ git log -1
commit 45bb4d071e666b48dd44daa0bd4549dfe2bb3ee8
Author: Dan Clarizio<EMAIL_ADDRESS>Date:   Wed Dec 13 09:42:01 2017 -0800

    Merge pull request #16648 from h-kataria/fixed_monitor_feature_node

    Removed redundant "Monitor" main tab node.
    (cherry picked from commit 5b2e1b8325a5cee14f4f3e147bba4210d52af20b)

    Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1526047


React Grid Row Pinning

https://staging.infragistics.com/products/ignite-ui-react/react/components/grids/grid/row-pinning
On select of top/bottom row, no rows are pinned

Already fixed in the product and there's an internal build with the fix<EMAIL_ADDRESS>There's no new public build yet but the fix will be included in the next public one as well.


In electron-vue, display doesn't work

Hi,
I make a electron-vue app with templates and I've a problem ( I don't know if it is from bulma or vue / electron).
So, when I goes on the page where is the Kanban template, the scroll doesn't work and it displays a random part of the template, and it's locked, and I've to refresh to get a good display. I have no errors.
The tabs and the Kanban templates make me this problem.
Thanks for helping

@DarkScientist Hi, that sounds like an issue with electron-vue.

Hi,
I fixed that by resetting the head of the web page.
I was using a lot of your templates and the modals locked the scroll. As electron vue doesn't refresh, it kept the scroll locked so by resetting the meta it worked.
Thanks!


Offline dependencies please

All of the following criteria must be met

[X] All Requirements must be installed.
[X] Full Latest.log file included. If no file exists then leave this unchecked and state so.

All of the following are optional to answer

[X] Tried reinstalling the Game.
[X] Tried reinstalling MelonLoader.
[X] Tried restarting PC.
[X] Was able to see the Start Screen.

Describe the issue.
Every time I start a game there is a prompt that looks like this appears:

Maybe an offline version that allows users to manually download could help
Latest.log
Did you attach your log file?

[X] Yes, I attached my log file to the text box above.
[ ] No, I could not find a log file at {Game_Directory}\MelonLoader\Latest.log

Try installing the x64 release build from https://nightly.link/LavaGang/MelonLoader/workflows/build/alpha-development
You can do so by using the Manual Zip tab on the installer.
See if the same issue occurs.

Well, I tried, now the game won't even open :( the command prompt windows flashes and then automatically shuts down itself

Well, I tried, now the game won't even open :( the command prompt windows flashes and then automatically shuts down itself

Apparently there was a crash issue with the Alpha branch of MelonLoader.
The crash issue should now be resolved.
Please download this MelonLoader.x64.CI.Release.zip and try again.

Well, seems like using manual zip install still leads to this situation:

Problem solved, by looking at what the console shows, I manually fill in the missing files and the game now boots  normally, thanks XD


Missing . in CNAME instructions.

I have an experimental setup of acme-dns under auth.basjes.nl
When I run this against a different domain I own I see this:
Output from acme-dns-auth.py:
Please add the following CNAME record to your main DNS zone:
_acme-challenge.somedomain.nl CNAME 963ab1da-54bc-4301-9f89-d1393729e78e.auth.basjes.nl

The subtle problem is that if I do it exactly as instructed a dns lookup for
_acme-challenge.somedomain.nl
results in
963ab1da-54bc-4301-9f89-d1393729e78e.auth.basjes.nl.somedomain.nl
The problem lies in the fact that because the '.' is missing in the CNAME dns assumes it is a subdomain of the current zone.
The simple fix for this is to add a '.' in the instructions.

Nice catch and a quick fix, thank you!


Add QueryParams middleware

First off, I'm excited to see an elixir HTTP library building on the concepts from Faraday.  Thank you for writing this library.
This PR adds a middleware for including default query params. Does the heavy
lifting of URI manipulation with URI module.
This middleware is helpful because certain APIs require access_tokens in
their query_params and it's helpful to set these as default using a
middlware.
defmodule Github.Api do
  use Tesla.Builder

  plug Tesla.Middleware.BaseUrl, "https://api.github.com"
  plug Tesla.Middleware.Headers, %{'User-Agent' => 'elixir'}

  plug Tesla.Middleware.QueryParams, %{access_token: "XXXXXXXXXXXXXXXXXXXXXXX"}
  plug Tesla.Middleware.DecodeJson

  adapter Tesla.Adapter.Ibrowse
end

Thanks a lot, and definitely sorry for the long long time with no response.
I'm going to merge this, but it got me thinking that it might be a good idea to revisit the Tesla.Env structure and url handling (maybe something better than just string.

@teamon I'd be quite happy with a non-string representation in ENV :). Thanks for merging this!


Bounded in-flight dispatch requests in unordered delivery for back-pressure

Vert.x auto-subscribe and handling of records might grow
unbounded, and it is particularly evident when the consumer
is slow to consume messages.
To apply backpressure, we need to bound the number of outbound
in-flight requests, so we need to manually poll for new records
as we dispatch them to the subscriber service.
The maximum number of outbound in-flight requests is already configurable
with the consumer parameter max.poll.records, and it's critical to
control the memory consumption of the dispatcher.
Signed-off-by: Pierangelo Di Pilato<EMAIL_ADDRESS>Part of #1732

Release Note

Apply back-pressure by limiting the number of in-flight dispatch requests in the unordered event consumption

/cherry-pick release-1.1

/cherry-pick release-1.0


Markup  and

Description of the problems or issues
Is your pull request related to a problem? Please describe.
Currently, <table/> and <td/> are not marked up with hOCR attributes.
Does your pull request fix any issue.
N/A
Description of the proposed changes
This PR adds

title="bbox X X X X" to both of them.
class_="ocr_table" to <table/>

Test plan

Use hocr-checks to check the conformity to hOCR (this check is actually very basic)
Check if table can be found by class "ocr_table"
Check if they have bbox

Checklist

[ ] I have updated the documentation accordingly.
[x] I have added tests to cover my changes.
[ ] All new and existing tests passed.
[ ] I have updated the CHANGELOG.md accordingly.

Codecov Report

Merging #84 into master will increase coverage by 0.25%.
The diff coverage is 94.28%.

@@            Coverage Diff             @@
##           master      #84      +/-   ##
==========================================
+ Coverage   65.62%   65.88%   +0.25%
==========================================
  Files          21       21
  Lines        2508     2530      +22
==========================================
+ Hits         1646     1667      +21
- Misses        862      863       +1

Flag
Coverage Δ

#unittests
65.88% <94.28%> (+0.25%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

tests/test_basic.py
95.52% <88.46%> (+0.52%)
:arrow_up:

pdftotree/TreeExtract.py
88.85% <97.61%> (+0.23%)
:arrow_up:

pdftotree/ml/features.py
63.82% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fbe6a1a...b7667c7. Read the comment docs.


Slate transform for thematic breaks

Describe the bug
The Slate transform turns thematic seems to turn thematic breaks into empty paragraphs.
To Reproduce
Here is a simple test.md:
This is a heading
----

This is a thematic break:

----

This is more paragraph

The Cicero DOM looks fine:
bash-3.2$ markus parse --sample test.md --cicero
10:38:13 - info:
{
  "$class": "org.accordproject.commonmark.Document",
  "xmlns": "http://commonmark.org/xml/1.0",
  "nodes": [
    {
      "$class": "org.accordproject.commonmark.Heading",
      "level": "2",
      "nodes": [
        {
          "$class": "org.accordproject.commonmark.Text",
          "text": "This is a heading"
        }
      ]
    },
    {
      "$class": "org.accordproject.commonmark.Paragraph",
      "nodes": [
        {
          "$class": "org.accordproject.commonmark.Text",
          "text": "This is a thematic break:"
        }
      ]
    },
    {
      "$class": "org.accordproject.commonmark.ThematicBreak"
    },
    {
      "$class": "org.accordproject.commonmark.Paragraph",
      "nodes": [
        {
          "$class": "org.accordproject.commonmark.Text",
          "text": "This is more paragraph"
        }
      ]
    }
  ]
}

But in the Slate DOM the thematic break has disappeared:
bash-3.2$ markus parse --sample test.md --slate
10:38:37 - info:
{
  "object": "value",
  "document": {
    "object": "document",
    "data": {
    },
    "nodes": [
      {
        "object": "block",
        "type": "heading_two",
        "data": {
        },
        "nodes": [
          {
            "object": "text",
            "text": "This is a heading",
            "marks": []
          }
        ]
      },
      {
        "object": "block",
        "type": "paragraph",
        "data": {
        },
        "nodes": [
          {
            "object": "text",
            "text": "This is a thematic break:",
            "marks": []
          }
        ]
      },
      {
        "object": "block",
        "type": "paragraph",
        "data": {
        },
        "nodes": []
      },
      {
        "object": "block",
        "type": "paragraph",
        "data": {
        },
        "nodes": [
          {
            "object": "text",
            "text": "This is more paragraph",
            "marks": []
          }
        ]
      }
    ]
  }
}

Does anyone working on the markdown editor know what the correct Slate DOM should be? (@irmerk @DianaLease @dselman )

There is a reverse mapping from Slate to CiceroMark which can help since it indicates the kind of Slate block is expected: https://github.com/accordproject/markdown-transform/blob/90cf0cfa38582e9a38029573ad7fddba8470f32c/packages/markdown-slate/src/slateToCiceroMarkDom.js#L70

The CiceroMark to Slate DOM transform wrongly creates a paragraph here:
https://github.com/accordproject/markdown-transform/blob/90cf0cfa38582e9a38029573ad7fddba8470f32c/packages/markdown-slate/src/ToSlateVisitor.js#L221

Fix is in, PR #102
I am leaving this issue open until the fix can be tested inside the markdown-editor.

Confirmed working in https://github.com/accordproject/markdown-editor/pull/141


InForm for Windows 10

Where can I obtain a precompiled version of InForm for Windows for use with QB64?

It's in the zip file:
https://github.com/FellippeHeitor/InForm/releases/tag/v1.3

Hi Fellppe,
Silly me for not looking! Thank you very much.
Regards,
Willem
From: visionmercer @.>
Sent: Wednesday, 04 January 2023 14:02
To: FellippeHeitor/InForm @.>
Cc: WJSwan1945 @.>; Author @.>
Subject: Re: [FellippeHeitor/InForm] InForm for Windows 10 (Issue #118)
It's in the zip file:
https://github.com/FellippeHeitor/InForm/releases/tag/v1.3
—
Reply to this email directly, view it on GitHub https://github.com/FellippeHeitor/InForm/issues/118#issuecomment-1370841873 , or unsubscribe https://github.com/notifications/unsubscribe-auth/AO4JEDRAYLM4H4UX3D46ACTWQVRCPANCNFSM6AAAAAATQWUPKY .
You are receiving this because you authored the thread.  https://github.com/notifications/beacon/AO4JEDVTC7IXFW63WV3AHUDWQVRCPA5CNFSM6AAAAAATQWUPK2WGG33NNVSW45C7OR4XAZNMJFZXG5LFINXW23LFNZ2KUY3PNVWWK3TUL5UWJTSRWVRRC.gif Message ID: @.*** @.***> >


Backup/restore app configuration

Add an option to backup/restore app configuration.

You mean the app settings? sure I will provide that in maybe the upcoming update if possible.

Could the calculation history be optionally included as well?


Document share versions

Currently we just have this cip: https://github.com/celestiaorg/CIPs/blob/main/cips/cip-21.md
But it makes sense to have the share versions clearly documented. I will need to think about where the best place for that is. We should probably have it mentioned in docs.celestia.org but perhaps we want to have a go.doc or readme.md in the code to explain it.
Originally posted by @cmwaters in https://github.com/celestiaorg/go-square/pull/80#discussion_r1647508044

I think there needs to be information in docs.celestia.org as well for the actual developers that may want to know how to use it

Sounds good, can def add to docs.celestia.org in addition to specs.


Updated tdd tutorial formatting

Fixes #506
Changes:
Edited tdd.hbs file to correct the formatting of </code></pre>.
Have verified that the page now looks correct.

thanks!


paper-item core-style reference leaking into HTML

This issue was originally filed by @rbishop-bah

The core-style that paper-item references does not seem to be handled properly by the pub transformers.  It winds up in a place where it gets directly rendered on the HTML page.
The attached image shows two things... a screenshot snippet showing the core style text showing up on my app's web page on start up... and the portion of the generated index.html that shows where the text is coming from.
What version of the product are you using?
Dart SDK 1.6.0 r39553
On what operating system?
Win 7 x64
What browser (if applicable)?
All, including Dartium.

Attachment:
paper-input-core-style-bug.png (72.52 KB)

This issue has been moved to dart-lang/polymer-dart#284.


AFL++ fuzer asn1 seems to really hang

The reproducer is attached, unpack and run:
cd ./openssl_asn1_20231111-111205_9e75a0b911ff
./asn1  ./default/hangs/id\:000000\,src\:004220+004352\,time\:156687783\,execs\:483554479\,op\:splice\,rep\:16

seems not to stop. The fuzzing system is a hardened Gentoo Linux [1]
[1] https://github.com/toralf/fuzz-utils
Uploading openssl_asn1_20231111-111205_9e75a0b911ff.tar.gz…

@toralf the link is broken.

openssl_asn1_20231111-111205_9e75a0b911ff.tar.gz

I've not used it outside of CI, but looking at that command line, I don't  think thats a valid way to run the asn1 fuzzer.
Running it under strace shows this:
strace ./asn1 ./default/hangs/id\:000000\,src\:004220+004352\,time\:156687783\,execs\:483554479\,op\:splice\,rep\:16
execve("./asn1", ["./asn1", "./default/hangs/id:000000,src:00"...], 0x7ffecffbcc88 /* 81 vars */) = 0
brk(NULL)                               = 0x561eb45fd000
arch_prctl(0x3001 /* ARCH_??? */, 0x7ffeb8411d80) = -1 EINVAL (Invalid argument)
mmap(NULL, 8192, PROT_READ|PROT_WRITE, MAP_PRIVATE|MAP_ANONYMOUS, -1, 0) = 0x7f31ef079000
...
sysinfo({uptime=82705, loads=[15840, 40768, 55008], totalram=67414962176, freeram=30763941888, sharedram=161812480, bufferram=2184712192, totalswap=8589930496, freeswap=8589930496, procs=1888, totalhigh=0, freehigh=0, mem_unit=1}) = 0
futex(0x561eb3ca1988, FUTEX_WAKE_PRIVATE,<PHONE_NUMBER>) = 0
futex(0x561eb3ca1990, FUTEX_WAKE_PRIVATE,<PHONE_NUMBER>) = 0
brk(0x561eb4647000)                     = 0x561eb4647000
read(0,

Looks like its waiting for input on stdin

You are supposed to run crash files through asn1-test

The crash file does not seem to hang for me when I run it against asn1-test.
@toralf could you please provide a backtrace from the hang?

Tried to reproduce it - cannot do it tillnow - ok, so sry, will close this is invalid.


wrong date calculation

:|
i just want to get first day of year and it returns wrong date

Same as #57. see this comment

@smmoosavi
as I see the main issue here is not with knowing the zero-index convention, but with the toISOString() method which returns wrong results.

Same as #57. see this comment
@smmoosavi
as I see the main issue here is not with overlooking the zero-index convention, but with the toISOString() method chained to newDate which returns wrong results.

@javadbat
here seems to be the correct usage for converting to ISOString:
import { newDate, formatISO } from "date-fns-jalali"

const date = newDate(1400, 0, 1);
const iso = formatISO(date);
console.log(iso); //-> "2021-03-21T00:00:00+03:30"


Expired SAML IdP metadata not refreshed

When the SAML IdP metadata contains a validUntil date, pac4j does not attempt to refresh the metadata from the metadata URL when the validUntil date is reached.  Because the metadata has expired, Pac4j ultimately throws the following error: org.pac4j.saml.exceptions.SAMLException: No idp entityId found.

Yes, we should return a better error. Would you mind submitting a PR for that?
That said, we can't refresh IdP metadata as they can be downloaded and installed by a user for example.

Re refresh:  think the metadata should be refreshed (or at least have the option to be refreshed per some property setting) if the metadata path is a URL.
Sent from my iPad

On Feb 25, 2018, at 11:12 PM, LELEU Jérôme<EMAIL_ADDRESS>wrote:
Yes, we should return a better error. Would you mind submitting a PR for that?
That said, we can't refresh IdP metadata as they can be downloaded and installed by a user for example.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.

Why not? Feel free to submit a pull request for that. Thanks.

wow... real helpful!

Will someone take a look at this?
It is a standard feature in other SAML SP Implementations, e.g. spring-security-saml or shibboleth.
If the IdP Metadata is an URL, you refresh it from that URL. If it is a file, you simply refresh it from that file (the user could change the file). The interval for refreshing should be configurable.
The interval-based refresh is necessary to capture changes to the Metadata that occur before the validUntil expires.
In addition, there should be a refresh when validUntil is over.
This behaviour is in fact implemented in opensaml, see: https://github.com/apigee/java-opensaml2/blob/master/src/main/java/org/opensaml/saml2/metadata/provider/HTTPMetadataProvider.java
So all you would have to do is expose the configuration in pac4j-saml...

As was pointed out earlier, you're most welcome to submit a pull request. The person you're waiting for, is you.

Have we added the support for IdP Metadata refresh @runger1101001 can you please provide PR link??

is this added?

See: https://github.com/pac4j/pac4j/pull/1459 and a


Feature request: enable more modular swagger.yaml and template.yaml

Goal: To have more modular code base for my AWS SAM solution
Current Reality: Definitions belonging to template.yaml  must be in a single file (e.g., template.yaml).
Problems:

If we have 50 different Lambda functions, then the template.yaml file is a huge file, so readability quickly decreases
If I want my team members to work on different categories of sub features, I can't have them work on different problems without interfering others.

Feature request (idea for discussion):
It would be great if we can have the following directory:

samdir/template.yaml
                     /action/action_logic.yaml
                     /payment/payment_logic.yaml

--- inside template.yaml -----
 ...
 ...
 - include {./action/action_logic.yaml}
 - include {./payment/payment_logic.yaml}

Actually, the above mentioned capability (to achieve composibility and modularization) is needed for the swagger.yaml file as well for a large project, I think.

The OpenAPI specification already supports this functionality, but I have not tried using it within the context of CloudFormation to see if I can make it work: https://github.com/OAI/OpenAPI-Specification/blob/master/versions/2.0.md#referenceObject

Did you checkout http://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/create-reusable-transform-function-snippets-and-add-to-your-template-with-aws-include-transform.html? Seems like something you want.

Did you have to do anything special to get the AWS::Include transform to work? I've just tried it like this:
  MyApi:
    Type: AWS::Serverless::Api
    Properties:
      StageName: Beta
      DefinitionBody:
        'Fn::Transform':
          Name: 'AWS::Include'
          Parameters:
            Location: s3://some-bucket/swagger.yml

However, that fails with:
Failed to create the changeset:
  Waiter ChangeSetCreateComplete failed:
    Waiter encountered a terminal failure state Status: FAILED.
Reason:
  Template Error: Encountered unsupported function: Fn::Transform
  Supported functions are: [Fn::Base64, Fn::GetAtt, Fn::GetAZs, Fn::ImportValue, Fn::Join, Fn::Split, Fn::FindInMap, Fn::Select, Ref, Fn::Equals, Fn::If, Fn::Not, Condition, Fn::And, Fn::Or, Fn::Contains, Fn::EachMemberEquals, Fn::EachMemberIn, Fn::ValueOf, Fn::ValueOfAll, Fn::RefAll, Fn::Sub]

wjbuys@ If all you want to do is use a swagger file from s3, you can look at the following example:
https://github.com/awslabs/serverless-application-model/blob/master/examples/2016-10-31/api_swagger_cors/template.yaml
Check the 'DefinitionUri' property.

Nope, I specifically want to be able to use Fn::Sub with CloudFormation parameters to parametrize the uri field in my swagger definition, just like @dinvlad in #8:
x-amazon-apigateway-integration:
  passthroughBehavior: "when_no_match"
  httpMethod: "POST"
  type: "aws_proxy"
  uri:
    Fn::Sub: "arn:aws:apigateway:${AWS::Region}:lambda:path/2015-03-31/functions/${FrontendHandler.Arn}/invocations"

@wjbuys, it's strange that Fn::Transform doesn't work for you. I use the exact same lines as you suggested in https://github.com/awslabs/serverless-application-model/issues/137#issuecomment-314244693, and it works just fine. Perhaps it's the version of the cli? Mine is aws-cli/1.11.68 (haven't upgraded recently though). If you're running it through CodeBuild then I believe they may use an outdated version; try upgrading the version explicitly there with pip install awscli.

@wjbuys I am trying to do the same thing, same files/lines but doing it in the console.  I get
Internal Failure. Rollback requested by user.

@wjbuys @dinvlad I'm curious if there was any resolution to the error cited below:

Failed to create the changeset:
  Waiter ChangeSetCreateComplete failed:
    Waiter encountered a terminal failure state Status: FAILED.
Reason:
  Template Error: Encountered unsupported function: Fn::Transform
  Supported functions are: [Fn::Base64, Fn::GetAtt, Fn::GetAZs, Fn::ImportValue, Fn::Join, Fn::Split, Fn::FindInMap, Fn::Select, Ref, Fn::Equals, Fn::If, Fn::Not, Condition, Fn::And, Fn::Or, Fn::Contains, Fn::EachMemberEquals, Fn::EachMemberIn, Fn::ValueOf, Fn::ValueOfAll, Fn::RefAll, Fn::Sub]

I am encountering precisely the same error. It's driving me more than a bit nuts because this is the answer given in many discussions and seems to be the only sane way I can do substitutions for the ARN references in my swagger.yaml file.
Every bit of documentation suggests the Fn::Transform is supported in this context, but I keep hitting this wall. Thoughts?


Added chötrin's wiki.

Hey! Here's my website's RSS feed. Thank you for supporting the smol internet and for building an awesome search engine. :)

Thanks. As per guidelines if submitting your own site, submit two other blogs.

Can you submit a clean PR with just the change please

Oop, my apologies. Yes!


支持洗衣机识别洗衣完成状态

我有小米的洗衣机和aqara的不支持米家的晾衣杆，我想实现洗完衣服晾衣杆自动下降，但是在家庭里无法得到洗衣完成状态，哪位大神有解决办法吗？

Sorry, i do not speak Chinese. You would need to write your question in English...

I have a Xiaomi washing machine and a non Xiaomi clothes drying pole. I want to achieve automatic descent of the clothes drying pole after washing, but in Apple's home, I cannot obtain the complete washing status. Does anyone have a solution?

Not quite sure what you mean, but it would be good if you provide the model names of the devices so at least i can have a look at the miot spec.


Transaction metadata in swagger API spec

Issue Number
ADP-307 / #2073 / #2074
Overview
Updates the swagger spec for the new metadata field when:

listing transactions (metadata field is always present but may be null)
posting a transaction (metadata field is optional)
estimating fee (as above)

Comments
Rendered spec

I found it difficult to debug swagger validation errors, so wrote this wiki doc: Swagger Development.

bors r+

@rvl I'll look at the swagger failure above, this is a bit tricky because we use OpenAPI 3.0 but the Haskell library we use expects swagger 2.0 format, so there are some subtleties...

Oh ok - I assumed it was maybe because the endpoints in the swagger file need to be added to the servant API.

bors r+

bors r+


Maria's availability

[X] Created the "communication-plan.md"
[X]  Added my availability for the week of 7/11


[loc][Query] Source text question "Select To Previous Command"

For string below community member is asking if source is correct with "Select To"? Can you please check? Thanks!
Original comments
BG ISSUE
Select To? - by lyubomirv, 2 months ago
Context
src/vs/workbench/parts/terminal/electron-browser/terminalActions:English (en):plaintext:workbench.action.terminal.selectToPreviousCommand
Resource
vs_workbench_parts_terminal
String text
Select To Previous Command

Yes that is correct, what it does is makes a select from the current start to the previous command. Say you have this output:
$ abc

$def | < cursor

Select to previous command will select from the cursor (|) to the first $.


Add link to NPM package

Add link to NPM package. So everyone can install it.

added to 'installation with npm'


Add stat by author per timezone functionality

Implements the enhancement requested in #128 . @arzzen When you get a moment, could you double-check and triple-check everything? I made a lot of changes internally, and I may have missed something. Thanks!

@tomice nice work! It works well on my side. (tested on ubuntu 18.04, 16.04, 20.10)


Temp Files remain after packing

During the packing stage, a temp directory is created containing the packed exe. After the protection, the file and directory remain, my suggestion is to make ConfuserEx delete the temp directory after everything is done.

I agree. There shouldn't be any left over file. Could you please specify the version of ConfuserEx you were using when observing this issue?

I am using the latest build from AppVeyor

Fixed the problem. The files are now properly cleaned up. Will be fixed in 1.2 and 2.0.


Django formtools is a hard dependency

Currently, the docs state that on Django 1.8 and higher, django-formtools should be installed. As Django 1.8 is the minimal version supported by django-tfa, it has been made hard dependency. All references to manual installation should be updated as well.

Fixed in 66d33ee530b9d4edddd50b849146def919c5543e


Create Free License Tier

Some ideas for the limits on free tier:

Limited number of passwords
No password generator
No password strength analyzer
No copying (just showing) of passwords
No backup

https://github.com/jakebruemmer/adamantite/pull/21
https://github.com/jakebruemmer/adamantite/pull/20


Update how-to-stake.md

Removing "vertices" since DAG is not a thing anymore
Docs PR Template
Why this should be merged
Since X-chain linearization, validators operate on blocks and not vertices anymore
How this works
tiny fix
How these changes were tested
edited from site directly, not tested needed
To prevent any errors while building

[] run vale /docs/file/path on all changed .md files to ensure all grammar rules pass
[] run markdownlint /docs/file/path on all changed .md files to ensure all linting rules pass
[] complete the above two checks and all additional rules outlined in style-checker-notes.md to
ensure all checks pass

If a document was removed/deleted

[] the path to that doc must be redirected to a valid URL via the
_redirects file
[] _redirects were manually verified with the cloudflare preview link
[] sidebars.json reflects all changes made to file path

If a document was moved

[] all files that were moved from their current directory to a new path have had their paths
redirected via the _redirects file
[] _redirects were manually verified with the cloudflare preview link
[] sidebars.json reflects all changes made to file path

ty!


Update connection.go

if the datebase characterset is ZHS16GBK, the one char must be have tow bytes.
so the "p_nls_timestamp" value is "DD-MON-RR HH.MI.SSXFF AM" need 48 bytes
the "p_nls_timestamp_tz" value is "DD-MON-RR HH.MI.SSXFF AM TZR" need 56 bytes
maybe can bigger
fixed the issue #18

thank you for your work i will merge your changes


Error loading file: Google Drive

Preflight Checklist

[x ] I agree to follow the Code of Conduct that this project adheres to.
[x ] I have searched the issue tracker for a feature request that matches the one I want to file, without success.

Describe the bug
When I save a file in Google Drive and re-open it at our co from within draw.io, I am almost always met with "Error loading file. The file does not exist or you do not have access."
To Reproduce
Steps to reproduce the behavior:

Select GDrive as save location.
Add a few elements to the blank doc
Let it save
Try and open it from Google Drive
Error dialog appears

Expected behavior
File opens without error
Screenshots
https://imgur.com/Rq9D4a7
draw.io version (In the Help->About menu of the draw.io editor):

draw.io version 22.0.6

Desktop (please complete the following information):

OS: macOS
Browser: Google Chrome
Browser Version: Has been an issue for many versions, current V is 118.0.5993.88

Smartphone (please complete the following information):

Device: NA
OS: NA
Browser NA
Version NA

I tested the problem in incognito/private mode with all browser extensions switched off, write "yes" below:

yes, issue appears there as well.

Additional context
I see the following in the console, which may be helpful:
Failed to load resource: the server responded with a status of 403 (Forbidden)
/drive/v2/files/15XAjZVxSXldNf0f9g_Vlm1a9A1N6DxFY?alt=media&source=downloadUrl:1
Failed to load resource: the server responded with a status of 404 ()
app.min.js:13041 error in loadFile: 15XAjZVxSXldNf0f9g_Vlm1a9A1N6DxFY Object

Hi,
I am not able to reproduce the issue in Chrome Version 118.0.5993.89 (Official Build) (64-bit) but on Win. Do you maybe have a possibility to test on another machine using Win?

I had another user test on Windows, and they were not able to replicate the UX.

I had another that indicated they could, so it's possible, probable this is a proxy or dlp ruleset issue that is causing the problem.

We were able to adequately confirm this was an "our network" issue rather than a product issue.


Counters are documented as u64

type-mapping.md specified counter -> u64, but when using u64 try_from_row fails. It should be documented as i64.

Hello @lewisdiamond ,
Thanks for submitting this issue.
You're right it should be i64. I've marked this as a documentation bug.
More precise with data marshaling/unmarshaling you can find in e2e tests https://github.com/AlexPikalov/cdrs/blob/master/tests/native_types.rs#L63


Bluetooth: hci_core: Fix unpairing on bt_id_reset

According to documentation, paired keys and other data associated with identity should be removed on bt_id_reset (not only if device address equals BT_ADDR_LE_ANY).

bt_addr_le_cmp() returns non-zero in the case of inequality (just like memcmp or strcmp). Maybe adding =! 0 would make this code clearer?

@jhedberg you are right, I forgot that bt_addr_le_cmp() returns non-zero in the case of inequality. Sorry for inconveniences, I think we may close the PR.

No worries, let’s close it then


StakingAccountDetails updates to support Capacity Staking for Rewards

Story
In order to be able to support Staking for Rew Provider Boosting, we'll need to add some fields to StakingAccountDetails.
Acceptance Criteria
New fields for StakingAccountDetails

pub last_rewards_claimed_at: Option<T::StakingEra>,  --  None means never rewarded, Some(Era) means last rewarded Era, defaults to None
 pub staking_type: StakingType, defaults to MaximizedStaking <-- Moved to StakingTargetDetails
pub stakeChangeUnlocking: BoundedVec<UnlockChunk<BalanceOf<T>, EraOf<T>>, T::MaxUnlockingChunks>
Ensure the defaults are correctly set when staking

This is finished


[Dropdown] Support Delimiters from Pasting

Not sure if this is intended or a bug.
When you paste a string into the dropdown it gets pasted as a whole and not separated by the delimiter.
This means a user can paste: AF, DF, CF but typing it directly in the input is impossible .

It might be complicated to support this, but it does make sense that it should be supported.

Fixed in the community fork Fomantic-UI by https://github.com/fomantic/Fomantic-UI/pull/2167


Stirling PDF

Project description
https://github.com/Stirling-Tools/Stirling-PDF

Tools to manipulate pdf files.
Metadata

homepage URL:
https://github.com/Stirling-Tools/Stirling-PDF
source URL:
https://github.com/Stirling-Tools/Stirling-PDF
license: mit, bsd, gpl2+ , ...
platforms: unix, linux, darwin, ...

Add a :+1: reaction to issues you find important.

I'll see what I can do, should be good practice working with Gradle apps

I'll see what I can do, should be good practice working with Gradle apps

Thank you Tom, much appreciated, best of luck.

By the way, I have pretty much succeeded in packaging it, and it seemed to run fine. Just forgot about it a little.
The only issue with the package currently is that jar files are created non-deterministically by default (timestamps are not set to a fixed time). After using the fixup hook made for this situation (unzip and rezip the jar file) springboot doesn't recognise its files anymore, which is really weird. So it stayed non-deterministic.
So I have two options: A) use the non-deterministic package or B) use the prebuilt jar from GitHub.
The latter one is much less complex to work with.

See if this helps you.. https://discourse.nixos.org/t/overriding-the-jdk-for-gradle-in-a-nix-flake/36541/2   or this discussion from the top... https://github.com/NixOS/nixpkgs/issues/278518

See if this helps you.. https://discourse.nixos.org/t/overriding-the-jdk-for-gradle-in-a-nix-flake/36541/2 or this discussion from the top (concerning java apps)... #278518

Thanks for the pointers, though the second thing linked is my own post :)
I finally managed to figure out how to fix the jar timestamps, so I'll open a PR adding the package

Thank you for your help @TomaSajt .  Much appreciated.. sorry for the delay. had a rough week last and it spilled into this one.   Looking forward to using stirling-pdf on nixos.


loki: Use rate() for both loki_distributor_ingester_{appends,failure}_total

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To complete the pull request process, please assign rawlingsj
You can assign the PR to them by writing /assign @rawlingsj in a comment when ready.
The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

thanks @klausenbusk! looks fine to me but will let Vincent verify
/assign @vbehar

/ok-to-test

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: vbehar
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [vbehar]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

thanks, nice catch!


DownloadCountReport need not have install counts and update counts

The download count report file can be made lot of smaller by avoiding "install" and "updates" data from warehouse.

This will be fixed with #2419

https://github.com/NuGet/NuGet.Jobs/commit/3661ee0873a4904f99911f3339e20d36a03c5dcc


eBPF does not support helper functions that modify direct packet data

Describe the bug
On Linux, several BPF helpers are documented as potentially invalidating the direct packet access pointers (e.g. data and data_end), and so the verifier checks the pointers are re-validated by the program after the helper returns.
Is this implemented for Windows helpers? Would this be provided by the reallocate_packet field in the ebpf-verifier project?
Example from the Linux man pages for the bpf_skb_pull_data function:

A call to this helper is susceptible to change the underlying packet buffer.
Therefore, at load time, all checks on pointers previously done by the
verifier are invalidated and must be performed again, if the helper is used
in combination with direct packet access.

OS information
N/A.
Steps taken to reproduce bug
Attempt to implement an extension that modifies the direct packet access pointers, and discover there is no characteristic to indicate the modification to the verifier.
Expected behavior
A helper that modifies packet data should indicate to eBPF, and the verifier should require programs revalidate data after calling the helper.
Actual outcome
There is no field that can be set to indicate this behavior to eBPF. Helpers today do not invalidate packet data by default.
Additional details
No response

Thanks for creating this issue @mtfriesen . The issue is understood. We will triage it next week and get it fixed in eBPF for Windows.

This is the .reallocate_packet member of EbpfHelperPrototype.
get_helper_prototype_windows() in libs\api_common\windows_helpers.cpp returns this struct but always leaves that member 0 (no code to ever set it to anything else).


Minor proposals on formatting

plus some syntax issues

I'm closing this PR, as changes should be made to the .Rmd file, not the .md file.


V0 4 4 release

Pull request for version 0.4.4 release.

[x] Test GUI
[x] test notebooks
[x] investigate deployment bug
[x] check sphinx documentation
[x] update requirements.txt
[x] update date of release in whatsnew
[x] more pytests?

Sweet, sweet green checkmark.  I'm merging this.


Url validation regex doesn't work for links with ports

Example: http://example.com:8000

Example of regex for http and https: ^(http(s)?://)?0-9a-zA-Z(:(0-9))(/?)([a-zA-Z0-9-.?,'/\+&%$#_])?$

Was fixed in v1.0.4


Azure Functions plugin requires Java 11

The latest release of azure functions gradle plugin requires Java 11 as the Jars compilation target is class file version 55.
Is there any specific reason for bumping the class version?

Thanks for the notification, we will release soon(today) , the next version will 1.7.0 will be able to run on Java 8.

1.7.0 is released


pear to peer programming 8-12-2022

pull request 4 is a great design with a good way of using Media queries

Peer-to-peer code review
This is the only suggestion I can think of. Maybe you can create a single class for all of these elements (lines 412 to 415 of your CSS) so you don't repeat yourself. But, other than that, everything looks great!!! 💪