Memory leak AsyncRabbitTemplate

Version 3.1.4.
I recently wrote about a bug  with a memory leak that occurred due to the fact that the internal pending map was not cleaned up after receive message.
Now everything works better, but you can see that for some reason some Messages still remain indefinitely in memory.

@tetrade ,
thank you for the report!
I'd  be happy to fix the problem, but I don't understand how to read that object tree.
Yes, I do see RabbitMessageFuture and its TimeoutTask reference. But it is not clear for me what is requestMessage and why that RabbitMessageFuture is a part of it?
Any chances to determine what you are doing in your code with this AsyncRabbitTemplate?

requestMessage - name of field in RabbitFuture.  I guess that TimeoutTask in some reason didn't deleted from memory and still have reference from Scheldued that created here org.springframework.amqp.rabbit.AsyncRabbitTemplate#timeoutTask

In short, I just use Rabbit to send a photo to a third-party service for processing and wait for a response via Direct Reply-to. When all the Future (many photos have been analyzed) are completed, I consider the project processed and upload everything to the user.
I initially thought that I was mistaken, because I have an internal ConcurrentMap in my code that takes into account the Id of the photo and stores it as the value of RabbitFuture so that when re-requesting it, I understand where to wait for a response.
However, given my implementation, there is hardly a leak there. Yes, and the profiler shows that where

As you see the logic there is like this:
	@Nullable
	private ScheduledFuture<?> timeoutTask(RabbitFuture<?> future) {
		if (this.receiveTimeout > 0) {
			this.lock.lock();
			try {
				if (!this.running) {
					this.pending.remove(future.getCorrelationId());
					throw new IllegalStateException("'AsyncRabbitTemplate' must be started.");
				}
				return this.taskScheduler.schedule(
						new TimeoutTask(future, this.pending, this.directReplyToContainer),
						Instant.now().plusMillis(this.receiveTimeout));
			}
			finally {
				this.lock.unlock();
			}
		}
		return null;
	}

So, such a timeout task is scheduled to be executed after that this.receiveTimeout (30 seconds by default).
Let's see if the problem with that ThreadPoolTaskScheduler with the default as private volatile int poolSize = 1;!
This way, it feels like "too many messages" would cause such a pool to be exhausted and therefore we see some kind of memory leak for some period of time until the queue of those TimeoutTask is cleared.
You can set an external ThreadPoolTaskScheduler with a bigger thread pool to mitigate workload.
Again: this is just an assumption since I don't see how else those TimeoutTask instances could be held in the memory if scheduling is done properly.

I also had memory leak in same scene[AsyncRabbitTemplate.sendAndReceive()], but version is 2.4.17

Maybe the bug also exists in 3.1.x  @tetrade

Causes of memory leaks

When AsyncRabbitTemplate.sendAndReceive() and receiveTimeout > 0, will startTimer() and create timeoutTask with TaskScheduler

When sendAndReceive() completed,  but timeoutTask is not clear immediately, and remains in the TaskScheduler until receiveTimeout

IF High throughput in short time scenarios，a large number of timeoutTask can cause memory leaks !!!

        // Class: AsyncRabbitTemplate
	@Override
	public RabbitMessageFuture sendAndReceive(String exchange, String routingKey, Message message) {
		String correlationId = getOrSetCorrelationIdAndSetReplyTo(message, null);
		RabbitMessageFuture future = new RabbitMessageFuture(correlationId, message);
		CorrelationData correlationData = null;
		if (this.enableConfirms) {
			correlationData = new CorrelationData(correlationId);
			future.setConfirm(new SettableListenableFuture<>());
		}
		this.pending.put(correlationId, future);
		if (this.container != null) {
			this.template.send(exchange, routingKey, message, correlationData);
		}
		else {
			ChannelHolder channelHolder = this.directReplyToContainer.getChannelHolder();
			future.setChannelHolder(channelHolder);
			sendDirect(channelHolder.getChannel(), exchange, routingKey, message, correlationData);
		}

                 // !!! Problem spot
		future.startTimer();
		return future;
	}

        // Class: RabbitFuture<T>

        void startTimer() {
	    if (AsyncRabbitTemplate.this.receiveTimeout > 0) {
		    synchronized (AsyncRabbitTemplate.this) {
			    if (!AsyncRabbitTemplate.this.running) {
				    AsyncRabbitTemplate.this.pending.remove(this.correlationId);
				    throw new IllegalStateException("'AsyncRabbitTemplate' must be started.");
			    }

                             // !!! Problem spot
			    this.timeoutTask = AsyncRabbitTemplate.this.taskScheduler.schedule(new TimeoutTask(),
					    new Date(System.currentTimeMillis() + AsyncRabbitTemplate.this.receiveTimeout));
		    }
	    }
	    else {
		    this.timeoutTask = null;
	    }
      }

Expect it to be fixed in version 2.4.x，Looking forward to your reply  @artembilan

@mailingfeng ,
Thank you for investigation!
I will into that code today.
However we are not going to back-port the fix into 2.4.x branch. That version is out of Open Source support: https://spring.io/projects/spring-amqp#support

I think this was fixed via: https://github.com/spring-projects/spring-amqp/issues/2724 and released as a part of the 3.1.6.
So, treating this as a Duplication and close respectively.
As I said: this is not going to be back-ported to the 2.4.x because no support for that branch any more.

@mailingfeng ,
Thank you for investigation!
I will into that code today.
However we are not going to back-port the fix into 2.4.x branch. That version is out of Open Source support: https://spring.io/projects/spring-amqp#support

OK, Thanks


[Gally]: master <- dev

Automatically created by Git-Ally

:tada: This PR is included in version 2.5.9 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Ranking fails to load due to CORS issue

The ranking page doesn't replace the placeholders, as it fails to load the actual data:
Cross-Origin Request Blocked: The Same Origin Policy disallows reading the remote resource at https://api.cargorocket.de/dr/data/ranking.csv. (Reason: CORS request did not succeed). Status code: (null).
Using Firefox 100.0.2.
Screenshot:

Hi Elias,
thank you for issue! This is probably due to the fact, the server is not reachable. I will look into it, but don't expect a fix too soon, since we do not develop actively work on this project anymore. :)


Suppress the Jetty server version header

@confluentinc It looks like @milosimpson just signed our Contributor License Agreement. :+1:
Always at your service,
clabot

For safety, the version information should be hidden / suppressed.

Thanks @milosimpson  LGTM


docs: bar chart with labels coloured by measured luminance

This PR adds an example that demonstrates how to change the color of text labels based on measured luminance.
The example looks as such:

Usage of luminance for the text color of the labels was created using the following code (method-based syntax):
import altair as alt
from vega_datasets import data

source = data.barley()

base = alt.Chart(source).encode(
    x=alt.X('sum(yield):Q').stack('zero'),
    y=alt.Y('site:O').sort('-x'),
    text=alt.Text('sum(yield):Q', format='.0f')
)

bars = base.mark_bar(
    tooltip=alt.expr("luminance(scale('color', datum.sum_yield))")
).encode(
    color='sum(yield):Q'
)

text = base.mark_text(
    align='right',
    dx=-3,
    color=alt.expr("luminance(scale('color', datum.sum_yield)) > 0.5 ? 'black' : 'white'")
)

bars + text

Especially this line
color=alt.expr("luminance(scale('color', datum.sum_yield)) > 0.5 ? 'black' : 'white'")

The lighter the bar, the higher the luminance. If the bar is light we like the text overlay be black.
The darker the bar, the lower the luminance. If the bar is dark, we like the text overlay be white.

In the expression above this is written as a predicate. The text appears black if the luminance is above 0.5 and white when the luminance is below 0.5. The luminance is computed using the color scale in combination with the internal computed data field datum.sum_yield. Inspecting the luminance can be done through the tooltip by hovering the bars.
Currently this expression is a str with plain Vega Expression syntax. It would be nice to use the equivalent python syntax instead.

Love this example! I have been doing similar things with a manual threshold as I didn't know there was a function in Vega to compute the luminance already!


[Proof of Concept] ServiceConfig for all required services

I had a thinker over this and thought its actually bad that we have to re-implement every required service of the framework any time we decide to use a new ContainerInterface. It feels like it defeats the purpose of having the container swappable and also I don't like the idea of the core framework being reliant on the Container.
I know this change introduces another Container per say, but I think separating internal dependencies from external dependencies is better than having everything in the same Container. It is easy enough to get the internal dependencies if necessary from the ServiceConfig which I am introducing.
I have also removed the bindTo from the Route\RouteGroup classes, this way we don't need to be passing the Container around purely for this feature, it felt a bit heavy requiring the Container in each constructor just to have access to it for bindTo.
I still need to remove the settings from the container to make it completely unaware of the App's requirements.

While I agree that it is kind of annoying to setup the defaults if you add your own container (as i did), and a benefit of your solution is that you don't have to update the defaults in your projects if those change, i feel that this is a bad idea.
The job of the container is to solve all dependencies, having two containers makes it confusing to the user, as he will expect to replace even the default dependencies through the container, and as it means for a user that he will have to look into two different places to find where a dependency is coming from.
In the end what this is causing is a duplication of logic.
In my opinion this gets even worse with the idea that a Class is used as configuration for those services, hence a change of configuration ends up being a change of logic.
I think a much better solution would be to provide an aid for people to setup their containers with the default values (for example a class that returns an array with key / default value combinations).

My initial thought is that I dislike having two containers in play as I have that in a Slim 2 application and it's a right old pain as I keep forgetting which one has which thing in it.

I had a thinker over this and thought its actually bad that we have to re-implement every required service of the framework any time we decide to use a new ContainerInterface.

I agree with you! But I agree with @ppetermann too!
The idea of 2 containers feels a bit strange.
The config service could extend the container interface and consume a real implementation of the container interface at the same time (proxy).
interface ServiceConfigInterface extends ContainerInterface
{}

class ServiceConfig implements ServiceConfigInterface
{
    public function __construct(ContainerInterface $container = null, array $settings = [])
    {
        if (null === $container) {
            // We still need a small wrapper around Pimple, because is does not
            // implement the container interface.
            $container = new Container();
        }

        $this->container = $container;
        $this->settings = $settings;
    }

    public function get($id)
    {
        return $this->container->get($id);
    }

    public function has($id)
    {
        return $this->container->has($id);
    }
}

uhm, doesn't that then completely miss the point?

Yeah, you're absolutely right!
The app class of this PR depends on both, I tried to remove the dependency on the container interface.

Whenever I see this argument come back up, I always think about using a composite container. In the Slim 3 App constructor, we accept an external ContainerInterop container. We then create a CompositeContainer instance in the constructor, pass in an instance of Slim/Container that provides default dependencies. We then pass in the user's external container into the composite container. When we invoke has or get on the composite container, it defers to its children containers (first to the external one, then to its default one). Seems like it addresses all issues, right?

Generally, I don't like having two containers in play even if one is subservient. However, if we do have to address this, then a composite container feels more workable to me.

I generally don't like having multiple containers, either. But I don't think there's anything wrong with it, either. If we were to do so, a composite container is what I'd recommend because it provides a simple, expected interface to its child containers.

I've had a play with a composite container and it's fine (though a little slower) as long as your "inner" container never needs anything from the "outer" container as the factory in the inner container doesn't have access to the outer one.
It's do-able though, even if I don't like it and think it's unnecessary :)

I just had a look at Zend Expressive and they are doing a configure it yourself kinda setup, I think if we include defaults for the Pimple container we include and write documentation for implementing any other Container you want to use. This is the current approach of Zend Expressive http://zend-expressive.readthedocs.org/en/stable/container/pimple/.
So I say leave it as is, anyone wanting to change to another Container just needs instruction on what services needs to be implemented. I will open a issue on the documentation website.
Thanks for all the comments on here, it was really good learning from you all.

The difference is Slim3 ships with Pimple bundled in its core while Expressive does not bundle any container in particular, rather provide documentation for the three they like the most (I guess), Zend ServiceManager, Aura.DI and Pimple, meaning it is container unopinionated as you have to require the dependency specifically

@juliangut not sure how that makes a difference? being able to replace the container and having the documentation seems to enable everyone to go his own way (including myself)

@juliangut we have always shipped with a Container, so this is nothing new, Pimple is not Container Interop, we could go on to create another class just to put the Pimple services in, but we don't see any value in this as it would still be only useful to Pimple. I think out approach is about ease of use for new developers, if you are a advanced developer then you can change and reconfigure you services if you wish. But we are still catering for beginners as much as we can.


Various additions

This is a collection of a lot of additions that I needed to make to support an existing, complex gitlab CI pipeline. I tried to stick to the patterns in this repo but there probably a few breaking changes sprinkled in.

Wow, this is quite an impressive bit of work. On cursory review this looks good and it produces identical output with my existing application so no objections from me. Thanks!


Hey Dubbeck here I couldn't think of any other way of contacting you

Yo man I luvvvv what you did with this mod, I'm glad you felt inspired by my project (Prismarine Automation) and I'm not here to take a piss. Aquatic Ambitions does what I could only wish my mod did, I'm blown away by the quality (and creativity).  Sorry again for littering the issues tab on your GitHub, oh and slide your discord pls...

Hey! Yeah I really think the Prismarine to copper recipes makes so much sense, and its definitely the best renewable copper concept I have seen, and really wanted to expand the idea. My discord is just davioliva


(Discuss complications) Create variable table-based step to allow testing a 'story'

And the data is
    | var | choice | value |
    | acknowledged_information_use | user_accepts | true |
    | person_answering |  | tenant |

How do we hit a 'continue' button only on appropriate pages?

The current solution is to continue whenever there aren't any variables left on the page.

Apparently I made a bunch of other issues instead of continuing to write in this one. This was closed by #92.


Webdataset sharding download

Hi, I'm using webdataset with S3 with multiple shards.
I'm using automatic sharding to avoid download the data more than once.
It's not clear from the docs if webdataset downloads all 100 tar files wds.WebDataset('pipe:s3 http://url/dataset-{001..099}.tar')or if this is done iteratively by accessing the items.
Also, when using sample caching, is the whole shard downloaded from S3?

Shards are accessed individually.
By default, all data is handled streaming, meaning nothing is cached locally.
If you use caching, each individual shard is first downloaded completely, then the local copy of the shard is used as input for further reading. (Originally, we had caching and processing happening in parallel, but that makes error handling tricky.)

Thanks for your response @tmbdev!
One more thing. I'm using the caching feature and  pipe:s3 stores the cache locally as s3. Can I change the cache name?

@itepifanio any fix for the above?

You can override the url_to_name argument to map shard names to cache file names in any way you like.
I will try to improve the default.

I noticed something related to this issue and wanted to ask if this is the correct, current behavior.
When caching is enabled, the first shard is downloaded, and the training is blocked until it is finished.
When caching is disabled, the first shard is consumed in a streaming fashion, and training starts when the first batch is preprocessed.
If this is correct, why can't we enable caching' and have the training start when the first batch is ready? I naively would have thought that the caching was implemented with tee` or something similar.


fix(spanner): support transaction tags in partition DML

Fixes: https://github.com/googleapis/java-spanner/issues/3347
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

[x] Make sure to open an issue as a bug/issue before writing your code!  That way we can discuss the change, evaluate designs, and agree on the general idea
[x] Ensure the tests and linter pass
[x] Code coverage does not decrease (if any source code was changed)
[x] Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> ☕
If you write sample code, please follow the samples format.

Closing this because sending transactionTag in partitionDML is no-op


Crash when loaded on 1.20.1

Describe the bug
Launching with VMP in my modpack seems to cause a crash. Might be related to Syntra Connector, but not sure? There was a previous issue stating that this mod was incompatible with Serene Seasons, which seemed to have been closed without a resolve, so it could also be that?

Minecraft version: 1.20.1
Mod version: Latest (Forge)

Crash reports / logs
[]
(https://mclo.gs/ZBoafKt)
Checklist

[x ] I am using the official version of the mod.
[x ] I tried the latest development version but the issue persists.
[x ] I searched for similar open issues and could not find an existing bug report on this.

not bug. the author update a fabric version to Modrith 1.20.1(Forge)
lmao


⚠ Bofrost.lu has degraded performance

In 753466e, Bofrost.lu (https://www.bofrost.lu) experienced degraded performance:

HTTP code: 200
Response time: 1550 ms

Resolved: Bofrost.lu performance has improved in 50374fa after 13 minutes.


Add fct_dbt__latest_full_model_executions back?

If you would like to see the return of this model in v1.0.0, please drop any feedback or thumbs up on this issue!
https://github.com/brooklyn-data/dbt_artifacts/blob/0.8.0/models/fct_dbt__latest_full_model_executions.sql

This model doesn't work in our current setup (because we run different marts on different schedules) - we use the dim__current_models one instead. Happy to retire it.

Agreed it doesn't really make sense


Add windows Client 8 and 10 to Concourse Windows pipeline

This enables Concourse to build Windows 8.1 and 10 Version 21h2 for internal testing only.

Messed up something big in the branch, going to rebase and open a new PR with different branch that is fixed.


Include/exclude does not work on the Resource class

✏ Describe the bug
Using include('someProp') or exclude on a DataClass that extends the Resource class does not work because Resource is missing the ContextableDataContract but has the trait
This means that this condition
https://github.com/spatie/laravel-data/blob/cf86d7abc18437a68d34c50072e5951b4a0bcf98/src/Concerns/TransformableData.php#L35-L37
Cannot pass and the transformationContext does not contain any partials
Here is a pest case that demonstrates the issue
it('can work with lazy laravel data collections', function () {
    $dataClass = new class () extends Resource {
        #[DataCollectionOf(SimpleData::class)]
        public Lazy|Collection $lazyCollection;
    };

    $dataClass->lazyCollection = Lazy::create(fn () => collect([
        SimpleData::from('A'),
        SimpleData::from('B'),
    ]));

    expect($dataClass->toArray())->toMatchArray([]);

    expect($dataClass->include('lazyCollection')->toArray())->toMatchArray([
        'lazyCollection' => [
            ['string' => 'A'],
            ['string' => 'B'],
        ],
    ]);
});

I think adding ContextableData to the base Resource class might be opinionated to your use case. I ran into the same situation but came across this section of the docs - Traits and Interfaces. Which suggests that Resource is a generic implementation - this package is designed to allow us to add our own functionality where necessary.

I really don't think so because the trait to allow include and exclude Is used on it, if that was the case, the trait should not be on it, and the doc suggests using it as an alternative to Data that doesn't have data validation and thus performs a bit better
https://spatie.be/docs/laravel-data/v4/as-a-resource/from-data-to-resource

hmm yes I see your point now. I was mixing up Resource and Dto.

I've added it to Resource, IncludeableData earlier extended ContextableData but that gave circular dependency problems when trying to analyze data for TypeScript Transformer 3. This should fix the issue.


Create debian templates for the python 3 flask templates.

The current python3-flask templates use the Alpine base python image.
Precompiled wheels for many important python libraries are not available
for Alpine, but are easily available for Debian. Using Debian makes it
much simpler and easier to use python packages like Numpy or Pillow.
Updated existing Alpine Docker files to include comments.
The template yaml file for the python-http-debian was modified to remove
unneeded libraries.
Both docker files were changed to force python 3.7. Gevent 1.4 is
incompatible with Python 3.8, and the rest of the docker files use
python 3.7.
This has been tested with a bare bones basic function and builds,
runs, and executes properly.
Change listening address for WSGI server.
Update the listening address for the WSGI server to use <IP_ADDRESS>
instead of ''. This should resolve errors about Address family
not supported by protocol (Python OSError Errno 97.
Closes #26
Signed-off-by: Alex Ellis (OpenFaaS Ltd<EMAIL_ADDRESS>Signed-off-by: Jeff Lowrey<EMAIL_ADDRESS>

@LucasRoesler @viveksyngh @Jeff-Lowrey FYI
This commit squashes all the WIP commits and reworking down into one concise commit and message.

@Jeff-Lowrey can you now send a PR to the template store for the new templates?
https://github.com/openfaas/store/blob/master/templates.json

The README also needs to be updated as per:


Implementing reduction for complex64 and complex128

This PR implements reduction for complex64 and complex128 on ROCm by casting the tensors to hipFloatComplex and hipDoubleComplex respectively.

@ekuznetsov139 It doesn't look like this PR got upstream properly. I found out while trying to resolve weekly merge conflict. Could you open a new upstream PR for this?
/cc @deven-amd

It's been submitted upstream as #40329 and I'm waiting for them to respond.

Gotcha, thanks for clarifying. It's been two months already since you submitted the upstream PR. Wow, that's really slow to upstream these days.


add jquery.checkboxes for rangeselection in upload history

add jquery.checkbores to provide a range selection via shift key in the upload history

Please change the commit subject to something more meaningful ("Support range selection on history page" maybe)

Merged to master along with some changes.


Get population by state for Germany/Poland

In EpiNow2 forecasts can be improved if populations are known. The new state level forecasts require state level population data.

@nikosbosse this might be the cause of some of the uncertainty issues you noted in the state level forecasts

@nikosbosse this might be the cause of some of the uncertainty issues you noted in the state level forecasts

Baden-Württemberg State, 11100394
Free State of Bavaria, 3124737
Berlin State, 3669491
Brandenburg State, 2521893
Free Hanseatic City of Bremen, 681202
Free Hanseatic City of Hamburg, 1847253
Hesse State, 6288080
Mecklenburg-Western Pomerania State, 1608138
Lower Saxony State, 7993608
North Rhine-Westphalia State, 17947221
Rhineland-Palatinate State, 4093903
Saarland State, 986887
Free State of Saxony, 4071971
Sachsen-Anhalt State, 2194782
Schleswig-Holstein State, 2903773
Free State of Thüringia, 2133378
Germany, 83166711

Baden-Württemberg State, 11100394
Free State of Bavaria, 3124737
Berlin State, 3669491
Brandenburg State, 2521893
Free Hanseatic City of Bremen, 681202
Free Hanseatic City of Hamburg, 1847253
Hesse State, 6288080
Mecklenburg-Western Pomerania State, 1608138
Lower Saxony State, 7993608
North Rhine-Westphalia State, 17947221
Rhineland-Palatinate State, 4093903
Saarland State, 986887
Free State of Saxony, 4071971
Sachsen-Anhalt State, 2194782
Schleswig-Holstein State, 2903773
Free State of Thüringia, 2133378
Germany, 83166711

oh - noticed that is just Germany :-D Here is where my competitive advantage ends...

oh - noticed that is just Germany :-D Here is where my competitive advantage ends...

Done for all geographies.


Pressing tilde/grave key on keyboard produces different scancode depending on keyboard layout used in Windows

Godot version
v3.5.stable.official [991bb6ac7]
System information
Windows 7
Issue description
When running a scene in Godot and pressing tilde + W or tilde + P key combinations on keyboard, running scene closes suddenly. Pressing tilde + Q maximizes/minimizes the window. There is no input key set for tilde key in the project. This occurs when using German, Spanish(traditional) or Croatian (my native language) keyboard layout. When using English US or UK, Spanish(international) or French the bug is gone. I only had time to test several layouts... When running exported application pressing tilde + Q still maximizes/minimizes the window, tilde + P closes the application and tilde + W does nothing. This makes tilde key pretty much unusable when developing or using it for input in game and causes frustration when tilde + W is hit on accident.
I printed scancodes in output when tilde key is pressed while using different layouts and noticed that depending on the layout used scancodes can oscillate between two values:

Steps to reproduce

change keyboard layout in Windows to the one of the aforementioned ones (German, Spanish (trad.) or Croatian)
create new project/run existing project
run scene
press tilde + Q to maximize/minimize
press tilde + W or tilde + P to close scene

Minimal reproduction project
N/A

Can you test this on 4.0.beta7? Input handling was reworked significantly in 4.0.

This is still an issue in 4.1.2. Or at least I am having a related issue.
I would like to be able to use tilde key to bring down a console UI like old school quake/unreal and many other games. Unfortunately pressing the traditional tilde/backquote key directly beneath esc only gives an unknown keycode on a UK Qwerty keyboard.
func _input(event):
 	print(event.to_string())

UK/British keyboard tilde/backquote keycode is unknown

InputEventKey: keycode=8388607 (Unknown)...

On an also related note, when pressing #/numbersign/hash/octothorpe (whatever you want to call it) on a UK layout keyboard, the event instead returns a keycode of apostrophe key and not numbersign.


Memory leak

Describe the bug
The docker container has a memory leak, I'm on the latest image version.
After it has reached 17gb of host's ram usage I limited the container available memory to 512mb and since then the container spit out this kernel error three/four times a day:
kernel: Memory cgroup out of memory: Killed process 3305847 (python) total-vm:1743496kB, anon-rss:364896kB, file-rss:9984kB, shmem-rss:0kB, UID:0 pgtables:1012kB oom_score_adj:0
because it now kills the memory leaking process when the memory threshold is reached, instead of occupying more ram
Version
0.45.3
Screenshots
htop inside the container
Additional context
I have 12 active watches
any clue?

It needs several tactics. BTW, this PR is not passed but you can use it to quickly restart.


make histograms easy

Not sure what the interface ought to be. Ideas:

optional argument to interactive plot
it's own function

proposed by @kmdalton

closing to keep track of this in https://github.com/ianhi/mpl-interactions/issues/59


Use golang's 1.6 vendoring schema

Since golang 1.6 has added stable support for vendoring. Are you contemplating changing godeps with the "official" vendoring mechanism? That way you can reduce boilerplate and dependencies.

go's vendoring support doesn't obviate the need for a tool like godep to actually manage the dependencies. Are you just asking whether we'll move the dependencies into vendor/ and cease fiddling with GOPATH?

Yep. I'd be interested in integrating rkt into a future project. Is that feasible? Or is the recommended way to invoke "rkt" as an external tool?

Depends on your exact needs - the recommended paths are either:
a) invoking rkt as a CLI
b) using the (not yet stable) API
c) helping to implement #1769 ;-)
Any direct use of importing rkt libs is totally caveat lector - we won't make guarantees about package APIs etc.

Thanks for the info. We will definitely take a look once we start the project. :+1:

didn't make it due to OCI/Fest activity

Moving to next milestone.

This is being addressed in #2735, currently targeted at 1.9.0 but waiting for an external PR. I'm removing the milestone from here, better tracked via PR.


correct --password arg to --pem-password

@msmbaldwin
Can you review the proposed changes?
Important: When the changes are ready for publication, adding a #sign-off comment is the best way to signal that the PR is ready for the review team to merge.
#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

@iankemp,
Thank you for contributing to this Azure documentation. Unfortunately, changes to Key Vault content can't be accepted this week. The Skilling Content group is migrating this content to a new repository: azure-security-docs.
In the meantime, we are closing this PR and tagging it so that when the content is available in the new repo, we can follow up with new location information.
#label:"migrate-followup"
#please-close

@IanKemp -
We’re happy to share that contributions to Key Vault content are once again possible at https://github.com/MicrosoftDocs/azure-security-docs/tree/main/articles/key-vault . Please open a PR in the new repo to submit your changes. We appreciated your patience during this migration.

#remove-label:"dcurwin"


Set up the React Development and installed the TailwindCSS framework

Created the React environment and installed the TailwindCSS framework for the development of the app.

Nice


[bug]: ModuleNotFoundError: No module named 'semver'

Is there an existing issue for this?

[X] I have searched the existing issues

OS
Windows
GPU
cuda
VRAM
No response
What version did you experience this issue on?
3.1
What happened?
Just updated with git pull and now i get this error:
Traceback (most recent call last):
  File "<frozen runpy>", line 198, in _run_module_as_main
  File "<frozen runpy>", line 88, in _run_code
  File "C:\Users\PuPpEt\invokeai\.venv\Scripts\invokeai-web.exe\__main__.py", line 4, in <module>
  File "C:\Users\PuPpEt\invokeai\InvokeAI\invokeai\app\api_app.py", line 35, in <module>
    from .api.dependencies import ApiDependencies
  File "C:\Users\PuPpEt\invokeai\InvokeAI\invokeai\app\api\dependencies.py", line 15, in <module>
    from invokeai.app.services.images import ImageService, ImageServiceDependencies
  File "C:\Users\PuPpEt\invokeai\InvokeAI\invokeai\app\services\images.py", line 7, in <module>
    from invokeai.app.invocations.metadata import ImageMetadata
  File "C:\Users\PuPpEt\invokeai\InvokeAI\invokeai\app\invocations\metadata.py", line 5, in <module>
    from invokeai.app.invocations.baseinvocation import (
  File "C:\Users\PuPpEt\invokeai\InvokeAI\invokeai\app\invocations\baseinvocation.py", line 29, in <module>
    import semver
ModuleNotFoundError: No module named 'semver'

Screenshots
No response
Additional context
No response
Contact Details
No response

Anyway, i've installed the package manually and now is working.

If you git pull you need to run a pip install -e .  In order to get any new packages. Sounds like you sorted it though!


Bugfixing

fixed issue when there is a struct in payload data that came from mongo but in schema there is the basic type like "INT", "TEXT" and so on

Changes Unknown when pulling 287fedf7e59d076a9bdb2b5ea758c67cc1e31c6e on VarchukVladimir:bugfixing into ** on YaroslavLitvinov:master**.


Name steps

Applied mkpr on .github/workflows/ci.yml
sed -f,name.sed

Pull Request Test Coverage Report for Build<PHONE_NUMBER>9
Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 87.135%

Totals

Change from base Build<PHONE_NUMBER>2:
0.0%

Covered Lines:
2538

Relevant Lines:
2901

💛  - Coveralls


Completed subtasks are not moved to archive file

For tasks with subtasks, only the highest level task is moved to the archive file by the action todomd.archiveCompletedTasks. The subtasks remain in the default file. I would expect subtasks to be archived as well.
Interesting, if the task with the subtasks is selected in the editor (normal text selection), archival works as expected.
Example:
Default file before archival
(A) Task with Subtasks {cm:2022-11-02T22:11:05}
    (B) Subtask 1 {cm:2022-11-02T22:11:06}
    (A) Subtask 2 {cm:2022-11-02T22:11:06}

Default file after archival
    (B) Subtask 1 {cm:2022-11-02T22:11:06}
    (A) Subtask 2 {cm:2022-11-02T22:11:06}

Archive file after archival
(A) Task with Subtasks {cm:2022-11-02T22:11:05}

That was quick, thanks!


docs: Add ghProxy docs

This PR adds ghProxy (and its related) pages to Prow website.

This PR does not add ghProxy in Prow website's 'Components' directory, because ghProxy seems to be not an component of Prow.
(Change may apply.)

[Preview]

ghProxy

ghCache
Additional throttling algorithm

[Screenshot of left navbar]

/ok-to-test

Hi @jihoon-seo, thanks for this PR. I notice that these documents are based on https://github.com/kubernetes-sigs/prow/tree/main/ghproxy. We should probably also deprecate the original ones and treat the ones you added as the new source of truth.

Hello @listx, thank you for your comment!
I reflected your comment by replacing the original ones with deprecation notices;
please see the 2nd commit fd53abf.
We might

add file deletion notice to deprecation notice, like: This file will be deleted on 2024-05-31. (Date may change)
or alternatively, just delete the original files (without leaving deprecation notice)

PTAL!

/label tide/merge-method-squash

Thanks!
/lgtm
/approve
/hold ? (maybe you want more reviews?)

@listx Thank you!
Let me unhold this. 😊
/unhold


Make the interfaces property of ObjectType and InterfaceType optional

Should resolve #41, which is caused by some schemas declaring the interfaces property  as null instead of []
The Magento demo endpoint at https://venia.magento.com/graphql exhibits this:
{
  "data": {
    "__schema": {
      ...
      "subscriptionType": null,
      "types": [
        ...
        {
          "kind": "INTERFACE",
          "name": "CartAddressInterface",
          "description": "",
          "fields": [ ... ],
          "inputFields": null,
          "interfaces": null,
          "enumValues": null,
          "possibleTypes": [ ... ]
        }
     ...

Thank you for this PR. I must have missed it in the notifications. It's great! 🚀


use script's actual name

CI gfxreconstruct build queued with queue ID 9213.

CI gfxreconstruct build # 2355 running.

CI gfxreconstruct build # 2355 passed.

CI gfxreconstruct build queued with queue ID 9295.


[camera] Allow for customization of video and audio codec format

Use case
We are developing a cross-platform social-media app based on user-created video content. We're using camera plugin for video recording and video_player for playback.
We encountered the following problem:

user records a video using camera plugin with default configuration on Android device
other user tries to play this video on iOS device using video_player plugin
video_player throws an PlatformException

Details of the video_player exception does not matter here, but after quite painful debugging session we managed to track the problem down: AMR audio codec used by Android MediaRecorder happens to be unavailable on iOS devices.
(exact error code: https://www.osstatus.com/search/results?platform=all&framework=all&search=1885696621)
We managed to hotfix this issue by forking the plugins repo and hard-coding AAC audio format in MediaRecorder configurations. Our fork: https://github.com/Utopia-USS/plugins
Fix is in MediaRecorderBuilder.java:60:
mediaRecorder.setAudioEncoder(MediaRecorder.AudioEncoder.AAC);

Proposal
camera currently allows for configuring ImageFormatGroup for taking photos. I propose a similar thing for audio: AudioFormatGroup (this also can be extended to video formats but this seems to be currently less of a problem).
Based on quick research, I can propose following initial format groups:

null - existing behavior, selected based on system preference
AAC LC - supported for recording and playback on every android device and every modern iOS device (seems to be auto-selected on iOS)
AMR - supported for recording and playback on every android device (seems to be auto-selected on Android)

All formats should be documented so that users can easily select format compatible with their use-case.
Other formats seem to be require more consideration because of either lack of wider cross-platform encoding support (like FLAC), or container support (like PCM - cannot be used in mpeg-4 container used by the plugin)
Sources:
https://developer.android.com/guide/topics/media/media-formats#audio-formats
https://stackoverflow.com/a/1761586
Usage proposal:
final controller = CameraController(
  //...
  audioFormatGroup: AudioFormatGroup.AAC,
);

What should be the default configuration? We have 2 options:

existing behavior (null):

pros:

backward compatibility
system will always choose a supported encoding format - no compatibility issues on recording side

cons:

hard to debug issues in cross-platform playback

AAC

pros:

supported for encoding and decoding basically everywhere
consistent format across all platforms

cons:

breaking change
may be unsupported in some edge cases

If you approve this feature, I'm willing to help with creating a PR for android support, but I'd need support on iOS side.

Thanks for the detailed proposal @SynSzakala.
Feel free to submit PR as you mentioned above.

Ok, I will submit a PR in few days.
What are your thoughts on default behavior?

I'm not sure I completely understand the use case here. Generally if you are vending user-created media content you re-encode it as necessary on the server side. E.g., your solution here doesn't handle user-created content that doesn't come from your app (maybe in your specific case that's not allowed, but that seems like a niche use case), nor would it scale to other platforms that don't support the specific formats you are using.
In general, in a future where camera supports Android, iOS, Linux, macOS, web, and Windows, I don't see any particularly good way for someone to use the proposed API.

Hello, I got redirected here from my originak issue.
I'm also in need of custom video and audio codec settings due to the fact that I can't use any of the new mpeg4 versions (I want to embed some metadata on user recorded videos, on device, via ffmpeg and am not kneen on paying license fees). Allowing the container format, video, and audio codec to be optionally customised would be nice. It may also be helpful for people who require a specific format.
I'm not sure if I can be of any help since my kotlin attempts are limited to my attempts to create a camera2 plugin for this case, and I've also didn't work with Swift so far. But I'll try.

I'm not sure if I can be of any help since my kotlin attempts are limited to my attempts to create a camera2 plugin for this case, and I've also didn't work with Swift so far. But I'll try.
Maybe by passing an optional class for either android and iOS or a combined settings class devs can specify their codecs without creating issues with other platforms?

The first step here would be a design document with one or more API proposals, and evaluations of how those APIs would map to each platform we support, so there can be discussion of, and agreement on, what this should even look like and how it would be used (addressing my comment above).

Ok, I'll try to write it up, following the template.

Two questions:

Would I publish it here or should I use a different issue? The docs mention both options, I'm a bit unsure which is more fitting.
Should it include platform code examples? (Bc. I'm currently trying to figure out the structure and stuff and it will probably take me a while even for the java code...)

Please make a design doc issue, as that will make it easily discoverable/searchable with other design docs, but then link to that issue here.
It doesn't need to have examples of what the actual implementation code in the plugin would look like; the important part to discuss is what the cross-platform API would be, and how that would map conceptually to platform SDKs. E.g., if there are format enums in the cross-platform API, what are the corresponding APIs that could be used to implement those enums on each platform (and if they can't be, how would that be handled)?


CONTIRIBUTING: Add note about using black via VSCode

https://code.visualstudio.com/docs/python/editing#_formatting

Hello @pdxjohnny I would like to work on this issue, please point me to the files where changes are to be made.

@sk-ip https://github.com/intel/dffml/blob/master/docs/contributing/style.rst#file-formatting


Cannot set height on any chart

Bug report
Codesandbox
Codesandbox
Explanation

What is the behavior you expect?
I expect to be able to determine the height of the stacked horizontal bar using the "height" option.
I also tried to set the height of the chart through the parent's div, by setting a fixed height, but it seems to not work.

What is happening instead?
The height of the stacked horizontal bar in the example cannot be set. Everything is always "responsive". I also tried with a Pie chart and I also cannot set the height there.

What error message are you getting?
No error message, but I can't resize the height of the chart.

Note
In this CodePen (not using the react wrapper) it seems to be working, but I am not sure if the issue is the react wrapper or something else.
Also, in your basic example trying to add a height doesn't work.
Codesandbox

I have found a solution in setting the height in the Component, so like:
          height="200px"
          options={options}
          series={series}
          type="bar"

So the problem is solved in this way, but I still don't understand if the height option in the config should work or not :)

In Vue/React, the height prop in the component overrides the height key in options.
So, the behavior is correct. Glad you solved it.


Usages slicing could reuse the existing atom file instead of recreating them

This would offer some speedup when dealing with large codebases. We need to find a better UX to communicate this since, otherwise, the user might be getting stale data.

Added --remove-atom as a CLI option to automatically remove the atom post creation. This value is set to true for usages and parsedeps alone. Reworked the usages logic to reuse an existing atom that might be present.
This way when the user creates an empty atom or uses reachables or data-flow slicing the atom file would remain intact and reusable for usages slicing.


Eliminates ast.CreateTabSim duplication.

As far as I can tell, ast.CreateTabAs handles SIMUALTE phrases just
fine. A test case is provided in tests/test_nig_normal.py

From @riastradh-probcomp prefer to abstract the code rather than factor of 2 for intermediate storage.


One Sample Module from V1 to V2

Hello I would like to know to the changes needed or recommendation on the code from a module that was build in V1 from laravel-modules to work well with V2?

Hi,
You can view examples of these modules on the AsgardCMS organisation. All modules there were upgraded from v1 to v2 of laravel-modules.


Clarify Whether Commercial Use Is Allowed In Free

Hello. I'd like to know whether commercial use of Poedit is allowed under the Free version. The website does not mention this except here:

@SylvKT This is open source version's bug tracker. It is not a place for idle questions.
If you need assistance with reading the license agreement, then you need the paid version, which includes support with such things.
And anyway, freeloading commercially would be a very immoral thing to do, so surely you wouldn't do it anyway and this entire question is moot, no?


tf_path in the english model

Hello,
I wanted to ask for the purpose of adding  tf_path = tf_path + "/variables/variables" in the english model. There's no analogous tf_path modification in the chinese version of the script. Removing this line seems to fix my issue with converting the model.
https://github.com/lonePatient/albert_pytorch/blob/3da2ebc5d71ce44be1123344d2f629fc21ffb01b/albert_english_pytorch/model/modeling_albert.py#L50
If it's indeed a bug, I've created a PR with a fix. If not, sorry for the trouble.
Thank you :)

@Porcupine96  Adding tf_path = tf_path + "/variables/variables"  is for  converting the weight of th_hub to the weight of pytorch.


Dark mode support

Some possible solutions:

https://dev.to/blacksonic/add-dark-mode-to-your-site-with-this-short-css-trick-1g7b

I would like to have automatic dark mode switch available
I would like to have manual switch available

This looks easy, but there's a lot of things to make sure things run as required. Tables/Diagrams/etc.
Not easy, unless I miss something obvious.

I'd be interested in seeing this.  what about creating a new type of child element for navigation that would be for create a new nav menu root and items (that would typically be aligned to the right?).  That new type of nav would have these special nodes that are parameterized to pass a css class to be applied to the body tag, a "name", and maybe even an icon.  These could be under functions titled something like "nav theme nodes".   The main nav link for this theme system would require providing the path to a css file that has all the styles associated with these themes (or maybe each node has its own?) Each nav link when clicked would apply the css styles from  the provided files to the end of the body to embed those styles (and being at the end, they would override most styles).  The nodes are essentially just using jQuery to swap which theme class is applied to the body which essentially give you a theming system.  Would love to provide a pull request for this myself but currently buried in a report development and tight schedules.  Would love to see this though!

So in most cases it will be <body data-bs-theme="light"> which is supported by many libraries, few of them it's just matter of fixing background, but it requires testing and slowly adding things. For others it will require some more work. I am currently busy with my other projects so this isn't a priority for me. Unless someone makes a PR starter I don't think I will pick it up.


Add content/hi/docs/home/supported-doc-versions.md

Issue -> #29356
This PR is a part of ongoing hi localization effort
/language hi

@anubha-v-ardhan , i think दस्तावेज़ीकरण was a better word to be used here!! don't you think?

@verma-kunal Both प्रलेखन and दस्तावेज़ीकरण means the same, but प्रलेखन is a more formal alternative. Last localization attempt was also using प्रलेखन as they had mention in their Google sheets file.

@verma-kunal Both प्रलेखन and दस्तावेज़ीकरण means the same, but प्रलेखन is a more formal alternative. The last localization effort was also using प्रलेखन as they had mention in their Google sheets file.

sure, understood!!! Thank you 🙂

@anubha-v-ardhan

We want to have some common words written the same way everywhere. We will soon make a Google sheet file with these words and their Hindi translations (just like the previous effort)

I've created one a long time ago, it should also be pinned in hindi slack channel for Kubernetes
https://docs.google.com/spreadsheets/d/1UmL4K0v4yaN34k4WzYDZBobLBp5OZQp4GCTi28AfwQM/edit#gid=0

@anubha-v-ardhan

We want to have some common words written the same way everywhere. We will soon make a Google sheet file with these words and their Hindi translations (just like the previous effort)

I've created one a long time ago, it should also be pinned in hindi slack channel for Kubernetes
https://docs.google.com/spreadsheets/d/1UmL4K0v4yaN34k4WzYDZBobLBp5OZQp4GCTi28AfwQM/edit#gid=0

Yeah, we can add more into this as well !! Thank you for sharing

Sorry @mittalyashu , we thought you are inactive and we didn't had edit access for that sheet. Glad to see you. We will use the existing file then : )

@anubha-v-ardhan I tried continue working on it but gradually other Hindi contributors also left and then somewhere I also lost interest 😞
Glad to see more contributors coming back.

@mittalyashu No worries, We are determined to finish the work this time. Please keep guiding us and reviewing our PRs and giving your valuable suggestions. Most of the folks in new team are newbies (including me)

@anubha-v-ardhan I tried continue working on it but gradually other Hindi contributors also left and then somewhere I also lost interest 😞
Glad to see more contributors coming back.

Glad to have you back with us @mittalyashu !! Would really look forward to your guidances & suggestions 😃✨

Done!! Thanks @mittalyashu for the review

/assign verma-kunal

@verma-kunal After commiting the suggestions, Can we squash the commits into one and rebase before merging please

/remove-approved

/remove-approve

@verma-kunal After commiting the suggestions, Can we squash the commits into one and rebase before merging please

sure!! would do that

/lgtm
/approve
Thank you @verma-kunal :)


BCReader: type safety and avoid abstarct type in struct

Purpose
This PR is a follow-up of #227 . It improves type safety and compiler optimization by removing abstract types in the BCReader struct.
Closes #250
Content
It improves type safety and compiler optimization by removing abstract types in the BCReader struct.
Review checklist
I have:

followed the codebase contribution guide: https://clima.github.io/ClimateMachine.jl/latest/Contributing/
followed the style guide: https://clima.github.io/ClimateMachine.jl/latest/DevDocs/CodeStyle/
followed the documentation policy: https://github.com/CliMA/policies/wiki/Documentation-Policy
checked that this PR does not duplicate an open PR.

In the Content, I have included

relevant unit tests, and integration tests,

appropriate docstrings on all functions, structs, and modules, and included relevant documentation.

[x] I have read and checked the items on the review checklist.

bors r+

bors r-

bors r+


[Feature]: fixing the login page logic

🚀 Feature Request
the signup page works but the login page doesnt allow you to login even after correct creentials are entered.
@param-code can you assign me this task to work on this feature.

🚀 Feature Request
the signup page works but the login page doesnt allow you to login even after correct creentials are entered. @param-code can you assign me this task to work on this feature.

Okay.All the Best!!

🚀 Feature Request
the signup page works but the login page doesnt allow you to login even after correct creentials are entered. @param-code can you assign me this task to work on this feature.

Okay.All the Best!!

This issue has got resolved.


Add VectorizedOapRecordReader for Parquet full scan

What changes were proposed in this pull request?
#536 task 4

Add VectorizedOapRecordReader as VectorizedParquetRecordReader to optimization parquet full scan

add VectorizedColumnReaderWrapper let let readBatch method can be used outside "org.apache.spark.sql.execution.datasources.parquet" package

How was this patch tested?
VectorizedOapEncodingSuite&VectorizedOapIOSuite
There is some duplicate code in SpecificOapRecordReaderBase.java, it will be  resolve after #575 merged.

one question, but not related to this question:
OapReadSupportImpl seems same to ParquetReadSupport
why not just use ParquetReadSupport

@linhong-intel ur right, OapReadSupportImpl is same to ParquetReadSupport but ParquetReadSupport is private[parquet] access permission and OapReadSupportImpl proxy ParquetReadSupport use ParquetReadSupportHelper.

Can you highlight your changes compared to VectorizedParquetRecordReader and SpecificParquetRecordReaderBase.


Unpin numpydoc dependency

This PR unpins the numpydoc version in our documentation requirements
Closes #5611

I wonder if we might, instead, pin to a more recent version.  It's nice that we haven't been surprised by doc build failures for the last few years.

I agree with Matt that we should pin numpydoc.

Sure, just pinned it to the latest release (0.9.1). And also cancelled the travis and appveyor builds I forgot to skip

LGTM. Thanks @jrbourbeau.


When returning an object via createUiDefinition.json, the tooling reports error Cannot find an overload for "Matches" and the argument count: "1".

If the output of the createUiDefintion.json contains an object instead of just a value, the tooling reports the error:
[-] Controls In Outputs Must Exist (6 ms)
Cannot find an overload for "Matches" and the argument count: "1".
Example file attached here:
createUiDefinition.json.txt

@scseely - thx for the repro...

@StartAutomating for debug


outpainting workflow

hi, im trying to outpaint this image

but i keep getting this black bar result regardless of any changes that i made in  the model and configs.
using stable-diffusion-inpainting

using powerpaint

as you can see both give same results. did i missed something crucial in the process or i picked the wrong model? whats the approach to do outpainting in my case? looking forward for any responses and help, thanks :)

Service startup parameters
If the generated result is black, you can try adding these two parameters when starting the service:

--disable-nsfw-checker
--no-half(Some graphics cards will produce black results without adding this parameter.)

outpainting workflow

I think PowerPaint and runwayml/stable-diffusion-inpainting cannot handle such high resolution, so it is recommended to switch to diffusers/stable-diffusion-xl-1.0-inpainting-0.1.

Even when using diffusers/stable-diffusion-xl-1.0-inpainting-0.1, it is recommended to only outpaint one side, as shown in the picture.

During testing your image, I found a bug in IOPaint. This has been fixed in version iopaint==1.2.2. Here are the results I obtained using the fixed version. The newly generated region has discoloration, I think it should be similar to the issue mentioned in this issue https://github.com/huggingface/diffusers/issues/5808, and there doesn't seem to be a good solution at the moment:

prompt:
detailed background, best quality, 4k, dramatic cinematic perfect light, coherent, deep, detailed, very inspirational, intricate, beautiful, highly color set, real, complex, artistic, appealing, full, symmetry, great composition, sharp, fine detail, clear, focus, inspired, epic, spectacular, breathtaking, gorgeous, stunning, infinite, futuristic, professional, awarded
Other parameters.

hey sorry for the late responses thanks for the feedback. i really appreciate it.


404 or 500 when clicking on SEO Sitemap admin tool

Hi
I have problem with loading the SEO Sitemap admin tool. Klicking on it gives me a 404 when checking the developer tool in the browser:
Geta.Optimizely.Sitemaps	https://localhost:44323/Geta.Optimizely.Sitemaps => 404
This is the source code that tries to load the resource(container):

In our opti. solution we are using /edit instead of /episerver. I wonder if that is causing the problem?
I have not set the
app.UseEndpoints(endpoints =>
{
endpoints.MapRazorPages();
});
Since it gives me a 500 error instead:
InvalidOperationException: The model item passed into the ViewDataDictionary is of type 'Geta.Optimizely.Sitemaps.Pages.Geta.Optimizely.Sitemaps.IndexModel', but this ViewDataDictionary instance requires a model item of type 'CMS.Base.Helpers.LayoutViewModel'.
Regards
Magnus

I have the same issue. It seems it was fixed by #51 but this version does not seem to be published as a nuget. Current version is 2.0.0 which was published 28th of April, before fix was merged.
Can you guys please publish latest version as Nuget?
@maer0216-star a temporary solution that worked for me was to clone the repo (which includes the fix) and reference it as a project in my solution (rather than a nuget).
Note, that in my project I have been using .MapContent() method on UseEndpoints configuration. In order for this plugin to work I had to add MapRazorPages() as well, so my config looks like this now:
app.UseEndpoints(endpoints =>
{
    endpoints.MapContent();
    endpoints.MapRazorPages();
});

@tomaszmadeyski Thanks! I might take a look at your solution then

hi,
we are waiting on https://github.com/Geta/geta-optimizely-sitemaps/pull/58 - after then we release new version.

The release should be published.


Problem With Direct Apps

Link to apps not direct to app, instead to playstore
Lets say i want to open link mega.nz to app mega, the link not direct to app mega, but instead direct to playstore ( i have install app mega on my device)
https://user-images.githubusercontent.com/88958226/129468044-856aa14d-026c-47a8-893e-e1b4b03c3e47.mp4

Device: Redmi Note 8 Pro
Android Version : A11
Kiwi Browser Version 93.0.4577.39

This problem not happen on old version.

Can you give an example link to test on?

Here;
https://mega.nz/file/5YNGyTjA#3bPFUvFQfWSSKI2OdTHj9TUPNmiDfN5HQN64x7PzP_0
This problem effect on other apps like reddit too

Ok, I can confirm that this is a bug. I'll look into it once the build a scripts work again.


Community Day - Start

@theonlymonica @Osterjour @Lock128 @hoegertn
Does any of you accept the challenge of start writing about the Community Day? Do you know good resources that we can point to? We don't expect perfection, on the contrary an organic document that starts flowing organically and multiple people can add upon.
I've created a placeholder here but feel free to do what you think best.
https://github.com/global-aws-community/aws-ug-cookbook/tree/main/community-day
Thanks a lot in advance.

PR https://github.com/global-aws-community/aws-ug-cookbook/pull/18 merged


[Feat] find_or_insert and assign APIs

[Feat]: find_or_insert and assign APIs.

/blossom-ci

Hi @jiashuy , can you collect the benchmark data for these two APIs and update it to the relative section in the Readme, thank you so much!

Hello @WonderingWJ , could you help review this PR for Jiashu, thank you~

Hi @jiashuy , can you collect the benchmark data for these two APIs and update it to the relative section in the Readme, thank you so much!

OK, no problem

/blossom-ci


libwebp: 0.6.1 -> 1.0.0

Semi-automatic update generated by https://github.com/ryantm/nixpkgs-update tools.
This update was made based on information from https://repology.org/metapackage/libwebp/versions.
These checks were done:

built on NixOS
ran ‘/nix/store/7rlf92q1g4sxv0g1gj8sf8310zm9na88-libwebp-1.0.0/bin/dwebp -h’ got 0 exit code
ran ‘/nix/store/7rlf92q1g4sxv0g1gj8sf8310zm9na88-libwebp-1.0.0/bin/cwebp -h’ got 0 exit code
ran ‘/nix/store/7rlf92q1g4sxv0g1gj8sf8310zm9na88-libwebp-1.0.0/bin/gif2webp -h’ got 0 exit code
ran ‘/nix/store/7rlf92q1g4sxv0g1gj8sf8310zm9na88-libwebp-1.0.0/bin/img2webp -h’ got 0 exit code
ran ‘/nix/store/7rlf92q1g4sxv0g1gj8sf8310zm9na88-libwebp-1.0.0/bin/img2webp --help’ got 0 exit code
ran ‘/nix/store/7rlf92q1g4sxv0g1gj8sf8310zm9na88-libwebp-1.0.0/bin/webpmux -h’ got 0 exit code
ran ‘/nix/store/7rlf92q1g4sxv0g1gj8sf8310zm9na88-libwebp-1.0.0/bin/webpinfo -h’ got 0 exit code
found 1.0.0 with grep in /nix/store/7rlf92q1g4sxv0g1gj8sf8310zm9na88-libwebp-1.0.0
directory tree listing: https://gist.github.com/a09e2cd5f3d318ac588ecdf308cc9898

cc @codyopel for review

Success on x86_64-linux (full log)
Attempted: libwebp
Partial log (click to expand)
shrinking /nix/store/7rlf92q1g4sxv0g1gj8sf8310zm9na88-libwebp-1.0.0/bin/cwebp
shrinking /nix/store/7rlf92q1g4sxv0g1gj8sf8310zm9na88-libwebp-1.0.0/bin/gif2webp
shrinking /nix/store/7rlf92q1g4sxv0g1gj8sf8310zm9na88-libwebp-1.0.0/bin/img2webp
shrinking /nix/store/7rlf92q1g4sxv0g1gj8sf8310zm9na88-libwebp-1.0.0/bin/webpmux
shrinking /nix/store/7rlf92q1g4sxv0g1gj8sf8310zm9na88-libwebp-1.0.0/bin/webpinfo
gzipping man pages under /nix/store/7rlf92q1g4sxv0g1gj8sf8310zm9na88-libwebp-1.0.0/share/man/
strip is /nix/store/j75dgadrff2d1fyc4fczmcgqkid2imdx-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/7rlf92q1g4sxv0g1gj8sf8310zm9na88-libwebp-1.0.0/lib  /nix/store/7rlf92q1g4sxv0g1gj8sf8310zm9na88-libwebp-1.0.0/bin
patching script interpreter paths in /nix/store/7rlf92q1g4sxv0g1gj8sf8310zm9na88-libwebp-1.0.0
checking for references to /build in /nix/store/7rlf92q1g4sxv0g1gj8sf8310zm9na88-libwebp-1.0.0...

Success on x86_64-darwin (full log)
Attempted: libwebp
Partial log (click to expand)
make[2]: Nothing to be done for 'install-exec-am'.
make[2]: Nothing to be done for 'install-data-am'.
make[2]: Leaving directory '/private/tmp/nix-build-libwebp-1.0.0.drv-0/libwebp-1.0.0'
make[1]: Leaving directory '/private/tmp/nix-build-libwebp-1.0.0.drv-0/libwebp-1.0.0'
post-installation fixup
gzipping man pages under /nix/store/an49c22h900i1ggbvd634iblc1r9cy0x-libwebp-1.0.0/share/man/
strip is /nix/store/kdff2gim6417493yha769kh00n63lnrw-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/an49c22h900i1ggbvd634iblc1r9cy0x-libwebp-1.0.0/lib  /nix/store/an49c22h900i1ggbvd634iblc1r9cy0x-libwebp-1.0.0/bin
patching script interpreter paths in /nix/store/an49c22h900i1ggbvd634iblc1r9cy0x-libwebp-1.0.0
/nix/store/an49c22h900i1ggbvd634iblc1r9cy0x-libwebp-1.0.0

Success on aarch64-linux (full log)
Attempted: libwebp
Partial log (click to expand)
shrinking /nix/store/bvw3g9rhw3yjsy9shpvwvkd5k3akdyjr-libwebp-1.0.0/lib/libwebpdemux.so.2.0.4
shrinking /nix/store/bvw3g9rhw3yjsy9shpvwvkd5k3akdyjr-libwebp-1.0.0/lib/libwebpmux.so.3.0.2
shrinking /nix/store/bvw3g9rhw3yjsy9shpvwvkd5k3akdyjr-libwebp-1.0.0/lib/libwebpdecoder.so.3.0.2
shrinking /nix/store/bvw3g9rhw3yjsy9shpvwvkd5k3akdyjr-libwebp-1.0.0/lib/libwebp.so.7.0.2
gzipping man pages under /nix/store/bvw3g9rhw3yjsy9shpvwvkd5k3akdyjr-libwebp-1.0.0/share/man/
strip is /nix/store/j7d4mr0ikv974ig7yzhknpsq288js4bs-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/bvw3g9rhw3yjsy9shpvwvkd5k3akdyjr-libwebp-1.0.0/lib  /nix/store/bvw3g9rhw3yjsy9shpvwvkd5k3akdyjr-libwebp-1.0.0/bin
patching script interpreter paths in /nix/store/bvw3g9rhw3yjsy9shpvwvkd5k3akdyjr-libwebp-1.0.0
checking for references to /build in /nix/store/bvw3g9rhw3yjsy9shpvwvkd5k3akdyjr-libwebp-1.0.0...
/nix/store/bvw3g9rhw3yjsy9shpvwvkd5k3akdyjr-libwebp-1.0.0

Success on x86_64-linux (full log)
Attempted: libwebp
Partial log (click to expand)
shrinking /nix/store/q6i75y9jc13k2ycfiprm8998w4l8afls-libwebp-1.0.0/bin/gif2webp
shrinking /nix/store/q6i75y9jc13k2ycfiprm8998w4l8afls-libwebp-1.0.0/bin/img2webp
shrinking /nix/store/q6i75y9jc13k2ycfiprm8998w4l8afls-libwebp-1.0.0/bin/webpmux
shrinking /nix/store/q6i75y9jc13k2ycfiprm8998w4l8afls-libwebp-1.0.0/bin/webpinfo
/nix/store/q6i75y9jc13k2ycfiprm8998w4l8afls-libwebp-1.0.0
gzipping man pages under /nix/store/q6i75y9jc13k2ycfiprm8998w4l8afls-libwebp-1.0.0/share/man/
strip is /nix/store/65ir27a74jycbnjfn1w6n5z701js27di-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/q6i75y9jc13k2ycfiprm8998w4l8afls-libwebp-1.0.0/lib  /nix/store/q6i75y9jc13k2ycfiprm8998w4l8afls-libwebp-1.0.0/bin
patching script interpreter paths in /nix/store/q6i75y9jc13k2ycfiprm8998w4l8afls-libwebp-1.0.0
checking for references to /build in /nix/store/q6i75y9jc13k2ycfiprm8998w4l8afls-libwebp-1.0.0...

Success on aarch64-linux (full log)
Attempted: libwebp
Partial log (click to expand)
shrinking /nix/store/mfnb20kx7vfil8r9ari14zb6641g3l05-libwebp-1.0.0/lib/libwebpdemux.so.2.0.4
shrinking /nix/store/mfnb20kx7vfil8r9ari14zb6641g3l05-libwebp-1.0.0/lib/libwebpmux.so.3.0.2
shrinking /nix/store/mfnb20kx7vfil8r9ari14zb6641g3l05-libwebp-1.0.0/lib/libwebpdecoder.so.3.0.2
shrinking /nix/store/mfnb20kx7vfil8r9ari14zb6641g3l05-libwebp-1.0.0/lib/libwebp.so.7.0.2
gzipping man pages under /nix/store/mfnb20kx7vfil8r9ari14zb6641g3l05-libwebp-1.0.0/share/man/
strip is /nix/store/g6ppn3cjscxg0jw5wcnc7413wwx1fn77-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/mfnb20kx7vfil8r9ari14zb6641g3l05-libwebp-1.0.0/lib  /nix/store/mfnb20kx7vfil8r9ari14zb6641g3l05-libwebp-1.0.0/bin
patching script interpreter paths in /nix/store/mfnb20kx7vfil8r9ari14zb6641g3l05-libwebp-1.0.0
checking for references to /build in /nix/store/mfnb20kx7vfil8r9ari14zb6641g3l05-libwebp-1.0.0...
/nix/store/mfnb20kx7vfil8r9ari14zb6641g3l05-libwebp-1.0.0

Failure on x86_64-darwin (full log)
Attempted: libwebp
Partial log (click to expand)
cannot build derivation '/nix/store/4w6frv51k9z39mmfd6l0dz6wcy63pmir-xnu-osx-10.11.6.drv': 8 dependencies couldn't be built
cannot build derivation '/nix/store/jj3dv3qbr9b53dypwgw2hszqcj1dgx5a-IOKit-osx-10.11.6.drv': 2 dependencies couldn't be built
cannot build derivation '/nix/store/vwwg2vxbfzrlafw1n98015rgadb8dg21-configd-osx-10.8.5.drv': 8 dependencies couldn't be built
cannot build derivation '/nix/store/d7ijs5kcrx20skw1s8b3bw091nmwk9h7-python-2.7.14.drv': 9 dependencies couldn't be built
cannot build derivation '/nix/store/pi46npb38bjzl7kc7k4vmghipq113qkl-libxml2-2.9.8.drv': 3 dependencies couldn't be built
cannot build derivation '/nix/store/hgscf1rgzz7apjybpsyg0bf26dx4s9vg-libxslt-1.1.32.drv': 4 dependencies couldn't be built
cannot build derivation '/nix/store/9vbb0bzvbi44nfmgplsvg1iq9zv4r948-xmlto-0.0.28.drv': 8 dependencies couldn't be built
cannot build derivation '/nix/store/rs80jbppimiqsdcryri1rsng83z0pwqf-giflib-5.1.4.drv': 5 dependencies couldn't be built
cannot build derivation '/nix/store/gi31ngxn6d170ihddl6jfzx9whn9fxvs-libwebp-1.0.0.drv': 6 dependencies couldn't be built
error: build of '/nix/store/gi31ngxn6d170ihddl6jfzx9whn9fxvs-libwebp-1.0.0.drv' failed


Remove plus and minus icons from zoom options

Purpose

This PR will remove plus and minus icons from zoom options container

Check List

[ ] Read the Contributing Guide
[ ] Required Balo version update
[ ] Updated Change Log
[ ] Checked Tooling Support (#)
[ ] Added necessary tests

[ ] Unit Tests
[ ] Spec Conformance Tests
[ ] Integration Tests
[ ] Ballerina By Example Tests

[ ] Increased Test Coverage
[ ] Added necessary documentation

[ ] API documentation
[ ] Module documentation in Module.md files
[ ] Ballerina By Examples

Codecov Report

Merging #17047 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #17047   +/-   ##
=======================================
  Coverage   68.85%   68.85%
=======================================
  Files           5        5
  Lines         122      122
  Branches       21       21
=======================================
  Hits           84       84
  Misses         38       38

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 27b3507...2e34787. Read the comment docs.


Introduce ImmutableAttributeSchema

Introduce ImmutableAttributeSchema, which can be compared with equality. We introduce a factory for these schemas which intern instances. Then, we introduce another factory for attribute matchers keyed on the input schema. This allows us to 'hoist' up various attribute matching caches to the build session scope.
There is still much work to be done. Artifact transform selection still requires a similar hoist. Plus, there is de-duplication to be done with the artifact type registry

Reviewing cheatsheet
Before merging the PR, comments starting with

❌ ❓must be fixed
🤔 💅 should be fixed
💭 may be fixed
🎉 celebrate happy things

@bot-gradle test this

I've triggered the following builds for you. Click here to see all build failures.

Pull Request Feedback (Trigger) (Check)

Local testing shows ~12% performance improvement on Android extra large 2000 project benchmark

I've triggered the following builds for you. Click here to see all build failures.

Pull Request Feedback (Trigger) (Check)

@bot-gradle test apt

I've triggered the following builds for you. Click here to see all build failures.

All Performance Tests (Trigger)

Based on some rudimentary memory testing, it seems this also reduces memory usage.
In the 4000 android project benchmark, we can successfully import a project the project into AS with a 24gb heap, and after the changes we can import with a 22gb heap.
Again, these tests are rudimentary, but appear to point to some improvement. We expect future changes to further improve memory usage

@bot-gradle test this

I've triggered the following builds for you. Click here to see all build failures.

Pull Request Feedback (Trigger) (Check)

@bot-gradle test this

Local testing shows ~12% performance improvement on Android extra large 2000 project benchmark

Are you also including CC hit scenarios in your local benchmarks? It would be of essence to understand the impact there as well

I have not tested CC (unless the android benchmark runs with CC by default). I'm not sure the changes here really should affect CC

Also this performance improvement was for studio sync. I'm not sure what CC's involvement is there


Items in non-bank inventories not being unlocked

I just got this plugin and was able to get what I'm wearing and bank unlocked. But I went to my PoH and opened everything, but nothing there unlocked. Are the PoH inventories not in scope? Do I need to take things out one by one to unlock them from my inventory?

To go a step further, what about items in the collection log? As a main, I could've unlocked something and sold it before I got the plugin.

Hey there! Thank you for reporting this! I had never considered this. I don't know how easy it will be to implement this, but I'll try to take a look as soon as possible!


Genshin Won't Open

Describe the bug
After I installed and I press Launch Game it says, "Game is running (DO NOT CLOSE LAUNCHER)", but the game doesn't launch. Occasionally, Wine Debugger opens up and says "Can't attach process: error 87).
Screenshots

System Information (please complete the following information):

macOS: Sonoma 14.2.1
Device: Macbook Pro 16" 2021
CPU: Apple M1 Pro
Dedicated GPU (if any): None
RAM: 16GB

Additional context
I have tried:

switching to all Wine versions including Crossover.
installing Rosetta 2
redownloading the game
redownloading YAAGL/deleting Application support>YAAGL

Logs (if any)
File not found.
592055.991:0124:err:seh:call_stack_handlers invalid frame 00006FFFFBBD0D1F<PHONE_NUMBER>022000-0000000000120000)
592055.991:0124:err:seh:NtRaiseException Exception frame is not in stack limits => unable to dispatch exception.

It's written on the main page, update your mac.


Setup new github templates

https://github.com/blog/2111-issue-and-pull-request-templates

https://github.com/jessesquires/JSQMessagesViewController/blob/develop/.github/ISSUE_TEMPLATE.md

https://github.com/jessesquires/JSQMessagesViewController/blob/develop/.github/PULL_REQUEST_TEMPLATE.md


status 401 when creating database

Using
ArangoDB 3.3.2 [linux] 64bit, using jemalloc, VPack 0.1.30, RocksDB 5.6.0, ICU 58.1, V8 5.7.492.77, OpenSSL 1.1.0f
Pyarango 1.3.0
On the tutorial page it says you can create database with
from pyArango.connection import *

conn = Connection(username='my_username',password='my_password')

conn.createDatabase(name="test_db")

even after putting the correct password and user   i get
conn.createDatabase(name=db)
 File "/usr/local/lib/python2.7/dist-packages/pyArango/connection.py", line 138, in createDatabase
   r = self.session.post(url, data = payload)
 File "/usr/local/lib/python2.7/dist-packages/pyArango/connection.py", line 42, in __call__
   raise ConnectionError("Empty server response", ret.url, ret.status_code, ret.content)
pyArango.theExceptions.ConnectionError: Empty server response. URL: http://<IP_ADDRESS>:8529/_api/database, status: 401. Errors:

but note, it works  with root user which in that case i think the documentation should be updated,  cause i thought any user should be able to create a db with all privilege assigned to the user .

OK only root user can create db