Running node from php via exec

Info:

Docker version ($ docker --version): 18.06.1-ce, build e68fc7a
Laradock commit ($ git rev-parse HEAD): 85c57a0
System info (Mac, PC, Linux): linux
System info disto/version: Ubuntu 16.04 LTS

Is it possible to run a node script from php via exec() or something?
Node is installed in the workspace container so it's not accessible from php-fpm and even if I install it there as well, I still can't access it from web php as www-data user.
I've tried installing node as www-data in php-fpm (unsuccessfully).
Maybe there's an easier way that I'm just not seeing?

@dehumanise you have said that you can't run node script, but you don't say anything about the error you had. Can you please add some stack trace or something like that so we can help you more.
Is it permissions issue? Is it an issue that php-fpm can't find node executable?
Sorry, but it's not clear for me.
Also there is a table

type
container

job (which is internally an artisan command)
php-worker

php-fpm
web

artisan command
workspace

PROBLEM:
If you get the error:
/usr/bin/env: 'node': No such file or directory
when trying to run a node script from the web app, it is due to that node is not installed in the container running the web app (php-fpm).
FIX:
Install node in the php-fpm container by copying the following slightly modified script found in the workspace/Dockerfile to the php-fpm/Dockerfile which will add a non-root user node and install node with npm. And rebuild the php-fpm image with docker-compose build php-fpm. Then recreate the container with docker-compose up -d.
###########################################################################
# Laradock non-root user:
###########################################################################

# Add a non-root user to prevent files being created with root permissions on host machine.
ARG PUID=1001
ENV PUID ${PUID}
ARG PGID=1001
ENV PGID ${PGID}

# always run apt update when start and after add new source list, then clean up at end.
RUN apt-get update -yqq && \
    pecl channel-update pecl.php.net && \
    groupadd -g ${PGID} node && \
    useradd -u ${PUID} -g node -m node && \
    usermod -p "*" node

###########################################################################
# Node / NVM:
###########################################################################

USER node

# Check if NVM needs to be installed
ARG NODE_VERSION=node
ENV NODE_VERSION ${NODE_VERSION}
ARG INSTALL_NODE=true
ARG INSTALL_NPM_GULP=false
ARG INSTALL_NPM_BOWER=false
ARG INSTALL_NPM_VUE_CLI=false
ARG NPM_REGISTRY
ENV NPM_REGISTRY ${NPM_REGISTRY}
ENV NVM_DIR /home/node/.nvm

RUN if [ ${INSTALL_NODE} = true ]; then \
    # Install nvm (A Node Version Manager)
    mkdir -p $NVM_DIR && \
    curl -o- https://raw.githubusercontent.com/creationix/nvm/v0.33.11/install.sh | bash \
        && . $NVM_DIR/nvm.sh \
        && nvm install ${NODE_VERSION} \
        && nvm use ${NODE_VERSION} \
        && nvm alias ${NODE_VERSION} \
        && if [ ${NPM_REGISTRY} ]; then \
        npm config set registry ${NPM_REGISTRY} \
        ;fi \
        && if [ ${INSTALL_NPM_GULP} = true ]; then \
        npm install -g gulp \
        ;fi \
        && if [ ${INSTALL_NPM_BOWER} = true ]; then \
        npm install -g bower \
        ;fi \
        && if [ ${INSTALL_NPM_VUE_CLI} = true ]; then \
        npm install -g @vue/cli \
        ;fi \
        && ln -s `npm bin --global` /home/node/.node-bin \
;fi

# Wouldn't execute when added to the RUN statement in the above block
# Source NVM when loading bash since ~/.profile isn't loaded on non-login shell
RUN if [ ${INSTALL_NODE} = true ]; then \
    echo "" >> ~/.bashrc && \
    echo 'export NVM_DIR="$HOME/.nvm"' >> ~/.bashrc && \
    echo '[ -s "$NVM_DIR/nvm.sh" ] && . "$NVM_DIR/nvm.sh"  # This loads nvm' >> ~/.bashrc \
;fi

# Add NVM binaries to root's .bashrc
USER root

RUN if [ ${INSTALL_NODE} = true ]; then \
    echo "" >> ~/.bashrc && \
    echo 'export NVM_DIR="/home/node/.nvm"' >> ~/.bashrc && \
    echo '[ -s "$NVM_DIR/nvm.sh" ] && . "$NVM_DIR/nvm.sh"  # This loads nvm' >> ~/.bashrc \
;fi

# Add PATH for node
ENV PATH $PATH:/home/node/.node-bin

# Make it so the node modules can be executed with 'docker-compose exec'
# We'll create symbolic links into '/usr/local/bin'.
RUN if [ ${INSTALL_NODE} = true ]; then \
    find $NVM_DIR -type f -name node -exec ln -s {} /usr/local/bin/node \; && \
    NODE_MODS_DIR="$NVM_DIR/versions/node/$(node -v)/lib/node_modules" && \
    ln -s $NODE_MODS_DIR/bower/bin/bower /usr/local/bin/bower && \
    ln -s $NODE_MODS_DIR/gulp/bin/gulp.js /usr/local/bin/gulp && \
    ln -s $NODE_MODS_DIR/npm/bin/npm-cli.js /usr/local/bin/npm && \
    ln -s $NODE_MODS_DIR/npm/bin/npx-cli.js /usr/local/bin/npx && \
    ln -s $NODE_MODS_DIR/vue-cli/bin/vue /usr/local/bin/vue && \
    ln -s $NODE_MODS_DIR/vue-cli/bin/vue-init /usr/local/bin/vue-init && \
    ln -s $NODE_MODS_DIR/vue-cli/bin/vue-list /usr/local/bin/vue-list \
;fi

RUN if [ ${NPM_REGISTRY} ]; then \
    . ~/.bashrc && npm config set registry ${NPM_REGISTRY} \
;fi

You can also disable/enable node installation via the .env file the same way as in the workspace. Just add the following to the php-fpm: build: args: in your docker-compose.yml
- INSTALL_NODE=${PHP_FPM_INSTALL_NODE}
- NODE_VERSION=${PHP_FPM_NODE_VERSION}

Note that I the docker_env group is not added to the node user because there is no such group in the php-fpm container. I do not know what consequences this may have so I would appreciate if someone would shed some light.

PROBLEM:
If you get the error:
/usr/bin/env: 'node': No such file or directory
when trying to run a node script from the web app, it is due to that node is not installed in the container running the web app (php-fpm).
FIX:
Install node in the php-fpm container by copying the following slightly modified script found in the workspace/Dockerfile to the php-fpm/Dockerfile which will add a non-root user node and install node with npm. And rebuild the php-fpm image with docker-compose build php-fpm. Then recreate the container with docker-compose up -d.
###########################################################################
# Laradock non-root user:
###########################################################################

# Add a non-root user to prevent files being created with root permissions on host machine.
ARG PUID=1001
ENV PUID ${PUID}
ARG PGID=1001
ENV PGID ${PGID}

# always run apt update when start and after add new source list, then clean up at end.
RUN apt-get update -yqq && \
    pecl channel-update pecl.php.net && \
    groupadd -g ${PGID} node && \
    useradd -u ${PUID} -g node -m node && \
    usermod -p "*" node

###########################################################################
# Node / NVM:
###########################################################################

USER node

# Check if NVM needs to be installed
ARG NODE_VERSION=node
ENV NODE_VERSION ${NODE_VERSION}
ARG INSTALL_NODE=true
ARG INSTALL_NPM_GULP=false
ARG INSTALL_NPM_BOWER=false
ARG INSTALL_NPM_VUE_CLI=false
ARG NPM_REGISTRY
ENV NPM_REGISTRY ${NPM_REGISTRY}
ENV NVM_DIR /home/node/.nvm

RUN if [ ${INSTALL_NODE} = true ]; then \
    # Install nvm (A Node Version Manager)
    mkdir -p $NVM_DIR && \
    curl -o- https://raw.githubusercontent.com/creationix/nvm/v0.33.11/install.sh | bash \
        && . $NVM_DIR/nvm.sh \
        && nvm install ${NODE_VERSION} \
        && nvm use ${NODE_VERSION} \
        && nvm alias ${NODE_VERSION} \
        && if [ ${NPM_REGISTRY} ]; then \
        npm config set registry ${NPM_REGISTRY} \
        ;fi \
        && if [ ${INSTALL_NPM_GULP} = true ]; then \
        npm install -g gulp \
        ;fi \
        && if [ ${INSTALL_NPM_BOWER} = true ]; then \
        npm install -g bower \
        ;fi \
        && if [ ${INSTALL_NPM_VUE_CLI} = true ]; then \
        npm install -g @vue/cli \
        ;fi \
        && ln -s `npm bin --global` /home/node/.node-bin \
;fi

# Wouldn't execute when added to the RUN statement in the above block
# Source NVM when loading bash since ~/.profile isn't loaded on non-login shell
RUN if [ ${INSTALL_NODE} = true ]; then \
    echo "" >> ~/.bashrc && \
    echo 'export NVM_DIR="$HOME/.nvm"' >> ~/.bashrc && \
    echo '[ -s "$NVM_DIR/nvm.sh" ] && . "$NVM_DIR/nvm.sh"  # This loads nvm' >> ~/.bashrc \
;fi

# Add NVM binaries to root's .bashrc
USER root

RUN if [ ${INSTALL_NODE} = true ]; then \
    echo "" >> ~/.bashrc && \
    echo 'export NVM_DIR="/home/node/.nvm"' >> ~/.bashrc && \
    echo '[ -s "$NVM_DIR/nvm.sh" ] && . "$NVM_DIR/nvm.sh"  # This loads nvm' >> ~/.bashrc \
;fi

# Add PATH for node
ENV PATH $PATH:/home/node/.node-bin

# Make it so the node modules can be executed with 'docker-compose exec'
# We'll create symbolic links into '/usr/local/bin'.
RUN if [ ${INSTALL_NODE} = true ]; then \
    find $NVM_DIR -type f -name node -exec ln -s {} /usr/local/bin/node \; && \
    NODE_MODS_DIR="$NVM_DIR/versions/node/$(node -v)/lib/node_modules" && \
    ln -s $NODE_MODS_DIR/bower/bin/bower /usr/local/bin/bower && \
    ln -s $NODE_MODS_DIR/gulp/bin/gulp.js /usr/local/bin/gulp && \
    ln -s $NODE_MODS_DIR/npm/bin/npm-cli.js /usr/local/bin/npm && \
    ln -s $NODE_MODS_DIR/npm/bin/npx-cli.js /usr/local/bin/npx && \
    ln -s $NODE_MODS_DIR/vue-cli/bin/vue /usr/local/bin/vue && \
    ln -s $NODE_MODS_DIR/vue-cli/bin/vue-init /usr/local/bin/vue-init && \
    ln -s $NODE_MODS_DIR/vue-cli/bin/vue-list /usr/local/bin/vue-list \
;fi

RUN if [ ${NPM_REGISTRY} ]; then \
    . ~/.bashrc && npm config set registry ${NPM_REGISTRY} \
;fi

You can also disable/enable node installation via the .env file the same way as in the workspace. Just add the following to the php-fpm: build: args: in your docker-compose.yml
- INSTALL_NODE=${PHP_FPM_INSTALL_NODE}
- NODE_VERSION=${PHP_FPM_NODE_VERSION}

Note that the docker_env group is not added to the node user because there is no such group in the php-fpm container. I do not know what consequences this may have so I would appreciate if someone would shed some light.

@sysoce I've tried this, but getting error upon php-fpm container re-building with --no-cache option.

#7 0.598 export NVM_DIR="$HOME/.nvm"
#7 0.598 [ -s "$NVM_DIR/nvm.sh" ] && . "$NVM_DIR/nvm.sh"  # This loads nvm
#7 0.598 [ -s "$NVM_DIR/bash_completion" ] && . "$NVM_DIR/bash_completion"  # This loads nvm bash_completion
#7 0.609 No .nvmrc file found
#7 0.611
#7 0.611 Node Version Manager
#7 0.611
#7 0.611 Note:  refers to any version-like string nvm understands. This includes:
#7 0.611   - full or partial version numbers, starting with an optional "v" (0.10, v0.1.2, v1)
#7 0.611   - default (built-in) aliases: node, stable, unstable, iojs, system
#7 0.611   - custom aliases you define with nvm alias foo
#7 0.611
#7 0.611  Any options that produce colorized output should respect the --no-colors option.
#7 0.611
#7 0.611 Usage:
#7 0.611   nvm --help                                Show this message
#7 0.611   nvm --version                             Print out the installed version of nvm
#7 0.611   nvm install [-s]                 Download and install a , [-s] from source. Uses .nvmrc if available
#7 0.611     --reinstall-packages-from=     When installing, reinstall packages installed in <node|iojs|node version number>
#7 0.611     --lts                                   When installing, only select from LTS (long-term support) versions
#7 0.611     --lts=                        When installing, only select from versions for a specific LTS line
#7 0.611     --skip-default-packages                 When installing, skip the default-packages file if it exists
#7 0.611     --latest-npm                            After installing, attempt to upgrade to the latest working npm on the given node version
#7 0.611   nvm uninstall                    Uninstall a version
#7 0.611   nvm uninstall --lts                       Uninstall using automatic LTS (long-term support) alias lts/*, if available.
#7 0.612   nvm uninstall --lts=            Uninstall using automatic alias for provided LTS line, if available.
#7 0.612   nvm use [--silent]               Modify PATH to use . Uses .nvmrc if available
#7 0.612     --lts                                   Uses automatic LTS (long-term support) alias lts/*, if available.
#7 0.612     --lts=                        Uses automatic alias for provided LTS line, if available.
#7 0.612   nvm exec [--silent]  [] Run  on . Uses .nvmrc if available
#7 0.612     --lts                                   Uses automatic LTS (long-term support) alias lts/*, if available.
#7 0.612     --lts=                        Uses automatic alias for provided LTS line, if available.
#7 0.612   nvm run [--silent]  []     Run node on  with  as arguments. Uses .nvmrc if available
#7 0.612     --lts                                   Uses automatic LTS (long-term support) alias lts/*, if available.
#7 0.612     --lts=                        Uses automatic alias for provided LTS line, if available.
#7 0.612   nvm current                               Display currently activated version
#7 0.612   nvm ls                                    List installed versions
#7 0.612   nvm ls                           List versions matching a given
#7 0.612   nvm ls-remote                             List remote versions available for install
#7 0.612     --lts                                   When listing, only show LTS (long-term support) versions
#7 0.612   nvm ls-remote                    List remote versions available for install, matching a given
#7 0.612     --lts                                   When listing, only show LTS (long-term support) versions
#7 0.612     --lts=                        When listing, only show versions for a specific LTS line
#7 0.612   nvm version                      Resolve the given description to a single local version
#7 0.612   nvm version-remote               Resolve the given description to a single remote version
#7 0.612     --lts                                   When listing, only select from LTS (long-term support) versions
#7 0.612     --lts=                        When listing, only select from versions for a specific LTS line
#7 0.612   nvm deactivate                            Undo effects of nvm on current shell
#7 0.612   nvm alias []                     Show all aliases beginning with
#7 0.612   nvm alias                  Set an alias named  pointing to
#7 0.612   nvm unalias                         Deletes the alias named
#7 0.612   nvm install-latest-npm                    Attempt to upgrade to the latest working npm on the current node version
#7 0.612   nvm reinstall-packages           Reinstall global npm packages contained in  to current version
#7 0.612   nvm unload                                Unload nvm from shell
#7 0.612   nvm which [current | ]           Display path to installed node version. Uses .nvmrc if available
#7 0.612   nvm cache dir                             Display path to the cache directory for nvm
#7 0.612   nvm cache clear                           Empty cache directory for nvm
#7 0.612
#7 0.612 Example:
#7 0.612   nvm install 8.0.0                     Install a specific version number
#7 0.612   nvm use 8.0                           Use the latest available 8.0.x release
#7 0.612   nvm run 6.10.3 app.js                 Run app.js using node 6.10.3
#7 0.612   nvm exec 4.8.3 node app.js            Run node app.js with the PATH pointing to node 4.8.3
#7 0.612   nvm alias default 8.1.0               Set default node version on a shell
#7 0.612   nvm alias default node                Always default to the latest available node version on a shell
#7 0.612
#7 0.612 Note:
#7 0.612   to remove, delete, or uninstall nvm - just remove the $NVM_DIR folder (usually ~/.nvm)
#7 0.612
#7 ERROR: executor failed running [/bin/sh -c if [ ${INSTALL_NODE} = true ]; then     mkdir -p $NVM_DIR &&     curl -o- https://raw.githubusercontent.com/creationix/nvm/v0.33.11/install.sh | bash         && . $NVM_DIR/nvm.sh         && nvm install ${NODE_VERSION}         && nvm use ${NODE_VERSION}         && nvm alias ${NODE_VERSION}         && if [ ${NPM_REGISTRY} ]; then         npm config set registry ${NPM_REGISTRY}         ;fi         && ln -s npm bin --global /home/node/.node-bin ;fi]: exit code: 127

[ 4/74] RUN if [ true = true ]; then     mkdir -p /home/node/.nvm &&     curl -o- https://raw.githubusercontent.com/creationix/nvm/v0.33.11/install.sh | bash         && . /home/node/.nvm/nvm.sh         && nvm install          && nvm use          && nvm alias          && if [  ]; then         npm config set registry          ;fi         && ln -s npm bin --global /home/node/.node-bin ;fi:

executor failed running [/bin/sh -c if [ ${INSTALL_NODE} = true ]; then     mkdir -p $NVM_DIR &&     curl -o- https://raw.githubusercontent.com/creationix/nvm/v0.33.11/install.sh | bash         && . $NVM_DIR/nvm.sh         && nvm install ${NODE_VERSION}         && nvm use ${NODE_VERSION}         && nvm alias ${NODE_VERSION}         && if [ ${NPM_REGISTRY} ]; then         npm config set registry ${NPM_REGISTRY}         ;fi         && ln -s npm bin --global /home/node/.node-bin ;fi]: exit code: 127
Service 'php-fpm' failed to build
Any Ideas how to resolve this ?

this helped me
docker compose <service> --build --force-recreate --no-deps

you just need to add one line making a new directory like this
&& mkdir -p /home/node/.node-bin \

after
mkdir -p $NVM_DIR \

full listing that works below
###########################################################################
# Laradock non-root user:
###########################################################################

# Add a non-root user to prevent files being created with root permissions on host machine.
ARG PUID=1001
ENV PUID ${PUID}
ARG PGID=1001
ENV PGID ${PGID}

# always run apt update when start and after add new source list, then clean up at end.
RUN apt-get update -yqq && \
    pecl channel-update pecl.php.net && \
    groupadd -g ${PGID} node && \
    useradd -u ${PUID} -g node -m node && \
    usermod -p "*" node

###########################################################################
# Node / NVM:
###########################################################################

USER node

# Check if NVM needs to be installed
ARG NODE_VERSION=node
ENV NODE_VERSION ${NODE_VERSION}
ARG INSTALL_NODE=true
ARG INSTALL_NPM_GULP=false
ARG INSTALL_NPM_BOWER=false
ARG INSTALL_NPM_VUE_CLI=false
ARG NPM_REGISTRY
ENV NPM_REGISTRY ${NPM_REGISTRY}
ENV NVM_DIR /home/node/.nvm

RUN if [ ${INSTALL_NODE} = true ]; then \
    # Install nvm (A Node Version Manager)
    mkdir -p $NVM_DIR \
	&& mkdir -p /home/node/.node-bin \
	&& curl -o- https://raw.githubusercontent.com/nvm-sh/nvm/v0.38.0/install.sh | bash \
	&& . $NVM_DIR/nvm.sh \
	&& nvm install ${NODE_VERSION} \
	&& nvm use ${NODE_VERSION} \
	&& nvm alias ${NODE_VERSION} \
	&& if [ ${NPM_REGISTRY} ]; then \
	npm config set registry ${NPM_REGISTRY} \
	;fi \
	&& if [ ${INSTALL_NPM_GULP} = true ]; then \
	npm install -g gulp \
	;fi \
	&& if [ ${INSTALL_NPM_BOWER} = true ]; then \
	npm install -g bower \
	;fi \
	&& if [ ${INSTALL_NPM_VUE_CLI} = true ]; then \
	npm install -g @vue/cli \
	;fi \
	&& ln -s `npm bin --global` /home/node/.node-bin \
;fi

RUN if [ ${NPM_REGISTRY} ]; then \
    . ~/.bashrc && npm config set registry ${NPM_REGISTRY} \
;fi

but this don't adds node to the path or /usr/bin i don't know why and you need to call it with this full string
/home/node/.node-bin/bin/node


Object spreading of primitive values is denied although it's valid JavaScript code

TypeScript Version:  3.7.x-dev.20200625

Search Terms:
Code
({ ...'' });

Expected behavior:
pass
Actual behavior:
Spread types may only be created from object types.(2698)
Playground Link:
Related Issues:

This is the intended behavior since intentionally spreading a string is extremely rare


Shellcheck tests.

Scope
Fixes #43
Changes
Improved existing Bash code to pass all Shellcheck tests.
Also tried to impose more uniform syntax everywhere.
Added automated Shellcheck tests for all shell scripts.
Drive-by fixes:

Defining default variables in pythia.conf/pythia.sh is more uniform.
Removed Choco package management on Windows.

Testing
Automated. ;-]
But please take a look at the changes, some are non-trivial, e.g. using matrices for some variables to make it possible to quote them everywhere.

I think I've addressed the issues raised in my comments and commits above.
Do let me know if there's anything still standing. Thanks!

The Shellcheck tests are not running during the "build" phase, only during the "test" phase at the end. And you can also run them manually whenever needed.

@adiroiban, I've found more minor issues during a final own review, beyond what Shellcheck was reporting.
While reviewing, I've also realized why the check_os_version() function in pythia.sh might be so hard to understand, so I've tried to improve it. Please take a look at it at https://github.com/chevah/pythia/blob/43-shellcheck-tests/pythia.sh#L537 and let me know if it's comprehensible now. Thanks!

For the record, I've had one more attempt to move BUILD_ENV_* files to $BUILD_DIR, this time without using a single file, but I don't think it's worth the trouble.


Update greet layout with basic css

Moved here from original pull request on main project repo: https://github.com/PHPixie/Project/pull/39
Adding some css to initial greet layout to make it look a bit fancier.

Thanks!


Require user to be logged in before download

See https://issues.osehra.org/browse/OTJ-90

@josephsnyder This is ready for another review.
The comments use a different log-in dialog then everywhere else. I think the easiest solution is to locally remove the link (Midas3/modules/comments/views/scripts/element/comment.phmtl)


resizable still does not work on react v17.0.2

Hey guys I've been using rbc on react v16 and it was working great, after updating my react to v17 it seems to be broken. Everything else is working, just the resizable prop does not work, I am not able to drag to resize, can't even see the handlebars to make the action, even after setting it to true.
I did read here in the issues that this has been fixed but I am not sure why I have the problem. I am sure I am using the latest version of the react-big-calendar. Any help on how I can solve this?
here's what my calendar looks like:
<DragAndDropCalendar
        selectable
        resizable
        onEventResize={resizeEvent}
        onEventDrop={onEventDrop}
        localizer={localizer}
        events={events}
        onSelectSlot={handleSelect}
        defaultView="week"
        scrollToTime={moment() .set({ h: 10, m: 0 }) .toDate()}
        timeslots={2}
        step={15}
        popup
        tooltipAccessor={(e) => e.title}
      />

I tried using this version aswell, It does not work for me.
https://github.com/jquense/react-big-calendar/pull/1857

+1


[1781] Create provider about page

Context
⚠ DRAFT ⚠
Changes proposed in this pull request
⚠ DRAFT ⚠
Guidance to review
⚠ DRAFT ⚠

 [S] Create provider 'About your organisation' (move to Rails)


clusterlogging pkg: IsReady method added to the lokistack handler

@trewest @kononovn @achuzhoy @cdvultur PTAL

We'll need a test for it too.

/lgtm


gitAndTools.stgit: 1.1 -> 1.3

Motivation for this change
Two new updates.
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
21.11 Release Notes (or backporting 21.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

/marvin opt-in
/status awaiting_reviewer

can you change your commit message to stgit: 1.1 -> 1.3?
gitAndTools.* were moved to top level in #109396

Oh, wow. I've never noticed that, and there's been several PRs updating stgit since. 😅
Yeah, can change it. One moment please.

Result of nixpkgs-review pr 139688 run on x86_64-darwin 1

1 package built:

stgit


Small Fix: Add an escape character to avoid blockquote

Objective

Fixes Bloom Docs to show ">" correctly.

Solution

Add an escape character to avoid blockquote

@alice-i-cecile @ameknite can we instead replace ">" with "Greater than"?

@alice-i-cecile @ameknite can we instead replace ">" with "Greater than"?

No obejctions to this: make a new PR?


Feature:  HBase Coprocessor -> Elasticsearch

This is an enhancement request to include HBase in our es-hadoop offering:
https://groups.google.com/forum/#!topic/elasticsearch/quUP1srwMtA

+1. Any updates?

+1

It's unclear what this exactly would entail. Are we thinking that this should be for enriching data that is being returned or for HBase to become a client proxy for Elasticsearch? HBase is a fairly powerful technology, but at the same time, can have its stability drastically compromised by use of coprocessors.
Since this is a fairly open ended request, and the development cost of building and maintaining a quality coprocessor is extremely high, I am closing this issue as it is unlikely that we will be getting to it any time soon. That said, if there is enough push from the community to support this kind of integration, then we may look into re-opening or further consideration of the request. Place your +1's on the original topic post.


Tracing API

We should work out an API that allows you to trace the execution of an Automat machine.  You should able to register with a machine an object that receives a sequence of (input, state, outputs) tuples and then unregister it.  It should help with other issues.

I've got a need for this, so I tried to dive in. I only got as far as writing a test case, but it brought up a question of what exactly the registered function should get.
For debugging my application, I want to see a series of lines like:

state1 -> INPUT1 -> state2
state2 -> INPUT2 -> state3

I'm also interested in the outputs that get called, and how they're interleaved with other events in my program. But not always: the coarsest level of logging would just be the main state transitions.
So maybe the tracing function should take (old_state, input, new_state, output_or_None). It would be called at least once (with output == None) for each state transition (when the input first arrives, before any outputs have been executed). Then it would be called again for each output (same first three args, but a new output= for each that gets run).
That way, for coarse logging, I could only print a line if output is None, and for detailed logging I'd print a line for every call to the tracing function.
Does that line up with what you were thinking? I don't know how the (input, state, outputs) signature that you mentioned would work.
The test case would look something like this:
from unittest import TestCase
from .._methodical import MethodicalMachine

class SampleObject(object):
    mm = MethodicalMachine()

    @mm.state(initial=True)
    def begin(self):
        "initial state"
    @mm.state()
    def middle(self):
        "middle state"
    @mm.state()
    def end(self):
        "end state"

    @mm.input()
    def go1(self):
        "sample input"
    @mm.input()
    def go2(self):
        "sample input"
    @mm.input()
    def back(self):
        "sample input"

    @mm.output()
    def out(self):
        "sample output"

    begin.upon(go1, middle, [out])
    middle.upon(go2, end, [out])
    end.upon(back, middle, [])
    end.upon(back, begin, [])

class TraceTests(TestCase):
    def test_trace(self):
        traces = []
        def tracer(old_state, input, new_state, output):
            traces.append((old_state, input, new_state, output))
        s = SampleObject()
        s.mm.setTrace(tracer)

        s.go1()
        self.assertEqual(traces, [(s.begin, s.go1, s.middle, None),
                                  (s.begin, s.go1, s.middle, s.out),
                                  ])
        s.go2()
        self.assertEqual(traces, [(s.begin, s.go1, s.middle, None),
                                  (s.begin, s.go1, s.middle, s.out),
                                  (s.middle, s.go2, s.end, None),
                                  (s.middle, s.go2, s.end, s.out),
                                  ])
        s.mm.setTrace(None)
        s.back()
        self.assertEqual(traces, [(s.begin, s.go1, s.middle, None),
                                  (s.begin, s.go1, s.middle, s.out),
                                  (s.middle, s.go2, s.end, None),
                                  (s.middle, s.go2, s.end, s.out),
                                  ])
        s.go2()
        self.assertEqual(traces, [(s.begin, s.go1, s.middle, None),
                                  (s.begin, s.go1, s.middle, s.out),
                                  (s.middle, s.go2, s.end, None),
                                  (s.middle, s.go2, s.end, s.out),
                                  ])

I also need to find a way to transform the MethodicalInput/etc objects into a nice printable representation, one which doesn't include all the python object IDs and attr.ib details. Ideally just a single word.
And I haven't figured out how to add a method to MethodicalMachine when it tries to hide itself as an "implementation detail": perhaps there's some decorator-ish way to add a method to the host object which can be used to activate tracing. Maybe something like:
class SampleObject(object)
    mm = MethodicalMachine()

    @mm.setTrace()
    def call_this_to_setTrace(self, tracer):
        # body is never actually called
        pass

so = SampleObject()
so.call_this_to_setTrace(my_tracer_function)

Take a look at that commit, maybe tell me if I'm headed in the right direction.

It uses the @mm.setTrace() decorator as above, which is a bit awkward. I think I now understand why MethodicalMachine is trying so heroically to hide itself, but it does make it hard to just talk to the state machine instance when you want to. I think it should be possible to do call_this_to_setTrace = mm.setTrace() instead of the decorator, but I'll have to understand how __get__ works properly to do it (I just copied/pasted the MethodicalInput decorator to achieve @mm.setTrace()), and then I wonder if seeing mm.something without the @ is going to stand out and cause confusion.
It passes strings into the tracing function, rather than decorated methods. I think this is more useful in practice: you can print them without diving into the internals to extract a method name. And the method names have to be unique anyways.
It does not yet capture the outputs (so the tracing function in my branch takes 3-tuples, not 4-tuples). I'm still trying to find a clean way to get the tracing information (the function, and the names of the states and input) into the place where the outputs are called, so the tracer can be invoked just before each output is invoked. Currently that place does not need to know about states and inputs, so it doesn't come near them.

I'm thinking about adding a spare context arg/kwarg to the setTrace call, sort of like how Defer.addDeferred(cb, "foo", bar="baz") results in cb(result, "foo", bar="baz"). For tracing, this is where you'd record which machine you're logging (and which instances of it, if you've got multiple FooMachines in the same process), so your log doesn't become an undifferentiated stream of "state=begin -> input=start -> state=started" because all your various machines have such stereotypical names.
But it might be easier/better to require the caller to capture that data in a lambda or a closure, and not pass additional args into the registration function. The tracer isn't going to be set all that often, they can afford declaring an extra function or two. (For Deferreds I can see a different argument, I call .addCallback with an extra context argument so frequently that it'd be annoying to wrap each one in a closure to get the context). Thoughts?

This generally looks like the right idea; I assume you can work through all the metaprogramming quirks yourself, but design-wise I think this is roughly going down the right track.  I think you mean Deferred.addCallback, though? :)

Closed in #56 , with a private API that you use with do_set_trace = mm._setTrace, which lets you register a function that accepts strings (old_state, input, new_state), and can optionally return a callable that lets you follow per-output invocations too. Full docs in "debugging.md".


Optimize Visuals and Information for Web Animation and Hacktoberfest

connect with me -
Github : https://github.com/Durgesh4993
LinkedIn : https://www.linkedin.com/in/durgesh4993/


As a single administrator of a small NPO, I can assign random integer IDs to each entry

... so that I can directly retrieve, modify or delete item without listing them yet.
References: #10

Not relevent


AccessControl Provider

Hey, I'm client! Test me! 'ALPHA'
Link to RBAC-PROVIDER
Test me! 'MASTER'
Link to RBAC-PROVIDER
Hey, I'm client! Test me! 'MASTER'
Link to RBAC-PROVIDER
Test me! 'MASTER'
Link to RBAC-PROVIDER
Hey, I'm client! Test me! 'MASTER'
Link to RBAC-PROVIDER
Test me! 'MASTER'
Link to RBAC-PROVIDER
Hey, I'm client! Test me! 'MASTER'
Link to RBAC-PROVIDER
Test me! 'MASTER'
Link to RBAC-PROVIDER
Hey, I'm client! Test me! 'MASTER'
Link to RBAC-PROVIDER
Test me! 'MASTER'
Link to RBAC-PROVIDER
Hey, I'm client! Test me! 'MASTER'
Link to RBAC-PROVIDER
Test me! 'MASTER'
Link to RBAC-PROVIDER
Hey, I'm client! Test me! 'MASTER'
Link to RBAC-PROVIDER
Test me! 'MASTER'
Link to RBAC-PROVIDER
Hey, I'm client! Test me! 'MASTER'
Link to RBAC-PROVIDER
Test me! 'MASTER'
Link to RBAC-PROVIDER
Hey, I'm client! Test me! 'MASTER'
Link to RBAC-PROVIDER
Test me! 'MASTER'
Link to RBAC-PROVIDER
Hey, I'm client! Test me! 'MASTER'
Link to RBAC-PROVIDER
Test me! 'MASTER'
Link to RBAC-PROVIDER
Hey, I'm client! Test me! 'MASTER'
Link to RBAC-PROVIDER
Test me! 'MASTER'
Link to RBAC-PROVIDER
Hey, I'm client! Test me! 'MASTER'
Link to RBAC-PROVIDER
Test me! 'MASTER'
Link to RBAC-PROVIDER
Closing issues
closes #743
Test documentation! 'MASTER'
Link to RBAC-PROVIDER

[ ] accessControl Provider
[ ] CanAccess component & useCan hook
[ ] nextjs-router & react-router integration
[ ] CRUD components
[ ] integrate useCan hook
[ ] sider
[ ] casbin example
[ ] unit tests
[ ] Doc
[ ] Guide

Wrapping async functions return values in Promise.resolve is unnecessary, removing all of them would be a good idea


fix reason code of pacvs v10 for rtp

Codecov Report

Merging #64 (702aa64) into master (8985c1d) will not change coverage.
The diff coverage is n/a.

:exclamation: Current head 702aa64 differs from pull request most recent head 11cd98e. Consider uploading reports for the commit 11cd98e to get more accurate results

@@           Coverage Diff           @@
##           master      #64   +/-   ##
=======================================
  Coverage   95.24%   95.24%
=======================================
  Files          75       75
  Lines       12972    12972
=======================================
  Hits        12355    12355
  Misses        586      586
  Partials       31       31

Impacted Files
Coverage Δ

pkg/pacs_v10/pacs.go
99.13% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8985c1d...11cd98e. Read the comment docs.


[BEAM-14323] Improve IDE integration of Spark cross version builds

With the current build setup, developer experience is fairly poor when working with the cross version build for Spark (but also similarly for Flink):

Sources for version specific overrides are copied to a new location and defined as Gradle sources at that location.

First of all, this is totally unnecessary. These sources are not shared and should be used in place.
Much more troublesome, the actual sources won't be resolved / checked by any IDE anymore and can't be properly worked on that way. Sadly for no reason at all ...

The actual shared resources on the other hand are referenced (added to srcDirs) in place. The IDE will randomly assign them to one Spark version module. Typically, for IntelliJ at least, that's the first (lower) one and not the one developers are actively working on.

The suggested changes in this PR are:

Don't copy version specific overrides
Only copy shared sources conditionally based on a flag. This allows developers to disable copying to pick a primary version they intend to work on.

Note: This is primary a cosmetic flag to improve IDE integration and has no impact on builds, even if all modules disable copying.

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

[ ] Choose reviewer(s) and mention them in a comment (R: @username).
[ ] Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
[ ] Update CHANGES.md with noteworthy changes.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)

See CI.md for more information about GitHub Actions CI.

R: @jbonofre
R: @echauchot
R: @aromanenko-dev

R: @lukecwik

Run Spark ValidatesRunner

CC: @ibzib


Rectangle Size of CheckBox

This point is related to the checkbox, now i have checked the checkbox in master and dev branch. In both of them, it is working fine. But when i use it on my project, its size is not big as seen on the documentation. Am i missing something?

Can you try assist:SelectionControlAssist.Size="24" ? it will affect the sizes of CheckBox.

Do not forgot to add depend xmlns:assist="clr-namespace:Material.Styles.Assists;assembly=Material.Styles" to root element parameters

Thanks it is resolved.

This did not work for me.  Any updates or other options?  Too bad NormalRectangle's Height and Width aren't set by dynamic resources I can override at the app level...

This did not work for me. Any updates or other options? Too bad NormalRectangle's Height and Width aren't set by dynamic resources I can override at the app level...

You can probably create a PR with that change. Or open another issue, i'll implement it when i have some free time.

This did not work for me. Any updates or other options? Too bad NormalRectangle's Height and Width aren't set by dynamic resources I can override at the app level...

The height and width properties are defined directly, not styles-affected since they are is in source code. Only you can do to replace them is change the whole ControlTemplate tree
Kinda traditional change but it will works


remove fs and path for shader loading

Per discussion, instead of using readFileSync(join(__dirname, ‘*.glsl'), 'utf8’) for shader source loading, change .glsl files to .glsl.js files that exports a static shader source string.
Pros:

no more fs & path dependency for shader loading.
no need to config webpack for brfs-babel and transform-loader if we were to import and debug layers from ‘../../src’.
we can simply import the shader files.

Cons:

no syntax highlighting for the .glsl file by default, we need comment out the first line for syntax highlighting

ran into an issue due to mapbox 0.32.1 + webpack, now testing against 0.33, will fix in the next diff.

I forgot those in the examples, will open another PR later today.

I forgot those in the examples, will open another PR later today.

Good catch. Also check the shaderlib folder.
The ultimate goal is to remove the static-fs, brfs-babel and transform-loader modules from all package.jsons (both in deps and scripts) and also from webpack configs. If the code still builds and runs, that means the "purge" has been successful.
Modules that are involved in shader inlining:
"babel-plugin-static-fs": "^1.1.0",
"brfs-babel": "^1.0.0",
"transform-loader": "^0.2.3",


Move the Realtime protocol documentation to this repository

It's currently:

Defined as source code in our docs repository as protocol.textile
Rendered for preview at docs.ably.com
Rendered alternatively at ably.com/docs - albeit less discoverable there, due to apparent lack of exclusion in site menus (this is probably intentional)

It should be converted to markdown format and moved to this repository, so that it can be atomically managed here as a peer-level content member.
┆Issue is synchronized with this Jira Uncategorised by Unito

I'm currently on the fence as to whether this will be moved here. I may well need to produce an ADR around this, for discussion with @SimonWoolf, @owenpearson and @lmars, plus others.


web-ui should not stack up REST calls

Type of issue

[x ] Bug
[ ] New feature
[ ] Improvement

Description
Right now controls in the UI act on a timer, executing backend calls every X seconds.  They can continue to do this but should not execute calls if a previous call is pending.  Right now if the backend is unresponsive the calls will stack up and eventually crash the browser.

Fix checked in, closing.


Tab bar does not show correct tab after being unmounted and remounted

Current behavior
https://user-images.githubusercontent.com/19638136/127634197-e403ef42-77d3-43b2-9011-60c8b368b503.mov
If you return a null in renderTabBar and then later start returning the tab bar component again it renders with the wrong tab selected
Expected behavior
The tab bar should always render with the correct tab selected
Reproduction
https://github.com/saty9/react-native-tab-view-issue-reproduction
Platform

[ ] Android
[X] iOS
[ ] Web
[ ] Windows
[ ] MacOS

Environment

package
version

react-native-tab-view
3.0.1

react-native-pager-view
5.4.0

react-native
0.64.2

expo
N/A

node
16.2.0

npm or yarn
1.22.10

Hey! Thanks for opening the issue. The issue doesn't seem to contain a link to a repro (a snack.expo.dev link or link to a GitHub repo under your username).
Can you provide a minimal repro which demonstrates the issue? A repro will help us debug the issue faster. Please try to keep the repro as small as possible and make sure that we can run it without additional setup.

would be good to allow org repos as well as personal ones

Having the same problem. I am using the tab view in a modal. When re-opening the modal, the initial index is wrong (not always, but often).

facing a similar issue. Any solution
material top bar issue

Same problem here

Facing the same issue. After changing to a different tab e.g. index 3, unmounting, and resetting navigationState index back to 0, the newly mounted Tabbar displays the tab on index 3 as selected rather than 0.

Facing the same issue. After changing to a different tab e.g. index 3, unmounting, and resetting navigationState index back to 0, the newly mounted Tabbar displays the tab on index 3 as selected rather than 0.

When I unmounted the TabBar I originally rendered a SkeletonPlaceholder instead of it and that seems to be the problem.
The workaround that is not really pretty but works for me is after unmounting the original TabBar, I render another TabBar with altered navigationState and styles that make it look like a placeholder on the screen.
I have a CustomTabBar component, which I pass to renderTabBar in TabView, and in that component a conditionally swap the 2 TabBars and it seems to work.


Add --snapshot-pkg-db generation to the README.md

Adding dockets from --snapshot-pkg-db as well; as those might be of interest too.

I have had pb with snapshot-pkg-db, things like

transformers-compat-<IP_ADDRESS>: Found existing documentation. Deleting.
transformers-compat-<IP_ADDRESS> Error: /Users/nrolland/.stack/snapshots/x86_64-osx/lts-5.5/7.10.3/doc/transformers-compat-<IP_ADDRESS>/transformers-compat.haddock: openBinaryFile: does not exist (No such file or directory)

except for many libraries. so I trashed my snapshot and recompiled some project using it.
Do you know how to :

regenerate the documentation if it's missing

generate the doc for all the packages in a LTS ? at the moment when I compile I only have the package used by my project being added to the snapshot. it would be great to have that done in one shot or better retrieved from some place..

I assume for some reason transformers-compat was built without haddocks, which seems to be more likely a stack bug if, you requested haddocks to be built with stack.
Generating for all of LTS would be great. Though it might be overkill as well, my biggest gripe I have right now, is that even with a slightly larger project, using only the packages from the snapshot database, makes Dash quite slow. I wonder what that would mean for all of LTS.
See also commercialhaskell/stack#491

for reference this mentions the solution : http://stackoverflow.com/questions/32151623/how-to-add-documentation-after-packages-have-already-been-installed

$ cd ~/.stack/snapshots/x86_64-linux/lts-3.0/7.10.2/doc
$ stack haddock *

However, those haddock have already been generated on stackage
http://haddock.stackage.org/lts-7.10/
there should be a way to get them automatically and not waste 15 minutes building them but I am unaware of it


Problem: omni_httpd looping infinitely

omni_httpd master and its workers loop infinitely when postgres max_worker_processes is 8 (the default).
This happens because:

omni_httpd.http_workers defaults to the number of cores (16 in this case).
The RegisterDynamicBackgroundWorker call fails because there are no background worker slots available (limited by max_worker_processes).
The httpd master gets stuck busy-waiting for all workers to start their loops 1.
The workers get stuck retrying the EAGAIN result of their socket 2.

Solution: handle the failed RegisterDynamicBackgroundWorker result.
This function returns false when the background worker can't start.

Would it make any sense to protect the while loop below (and perhaps similar ones around) to re-consult with background worker status if we can't get them to all come up to make sure we're expecting the right number to come up.

Looks like the status won't help. Once RegisterDynamicBackgroundWorker fails the WaitForBackgroundWorkerStartup function returns 0, which means BGWH_STARTED:
typedef enum BgwHandleStatus
{
	BGWH_STARTED,				/* worker is running */
	BGWH_NOT_YET_STARTED,		/* worker hasn't been started yet */
	BGWH_STOPPED,				/* worker has exited */
	BGWH_POSTMASTER_DIED		/* postmaster died; worker status unclear */
} BgwHandleStatus;

(Maybe that enum should have started at 1)

That is to say that it probably would make sense to ensure there are reasonable exit paths in the loops that prone to become infinite, not just before.

For avoiding the looping in accept_fds/http_worker we could check that the master worker started its socket loop, but I think just handling the failed dynamic bg worker start on the master is enough/simpler.

One thing that could be further improved is that this log can appear:
2024-07-06 13:37:34.195 -05 [656567] LOG:  omni_httpd: Established listener on 8080

And there are no http workers to serve the requests. But I think that can be fixed in another PR.


Drop GIL in c_wt calls

This PR drops the Python GIL for the computationally expensive c_wt calls in _dwt.pyx. This allows for efficient multithreading of PyWavelets code. Since the c_wt code does not modify any Python objects, dropping the GIL does not pose any risks (at least as far as I can tell).
The code passes all tests, and on my machine, computing four 2560x2560 wavedec2 calls in parallel (using concurrent.futures) takes about 1 second with this PR, and about 3 seconds using the current master. I think the approach will scale nicely up to larger numbers of cores, since the GIL will be dropped during most of the computation time.
If there is a different reason to hold on to the GIL in c_wt calls, or if you want me to add/remove/change things, please let me know.

Current coverage is 86.30% (diff: 80.00%)

Merging #188 into master will decrease coverage by <.01%

@@             master       #188   diff @@
==========================================
  Files            17         17
  Lines          2155       2191    +36
  Methods           0          0
  Messages          0          0
  Branches        242        242
==========================================
+ Hits           1860       1891    +31
- Misses          243        249     +6
+ Partials         52         51     -1

Powered by Codecov. Last update 5fc0f76...29d904f

This looks good to me and seems like a nice addition.
I see you added boundscheck(False) to some of the functions?  Is there any reason not to just declare all of them with the following?:
@cython.boundscheck(False)
@cython.wraparound(False)

(or using the equivalent global definition at the top of the file)

Also, if you are willing, it would be nice to make the same sort of modification to swt from _swt.pyx?

Thanks for looking at the PR!
I don't think there is a reason not to declare boundscheck(False) and wraparound(False) as a global definition at the top of the file, I will change it to do that. It will probably not speed up things much, since it is only relevant for the &data[0] like statements, which are only executed once. I basically added the boundscheck(False) to suppress Cython warnings about it during compilation.
I will include swt to this PR as well: I think the process of dropping the GIL will be mostly the same. I don't use swt myself at the moment, so I didn't look at it before.

Done! If it passes all the tests, I am OK with merging.

Thanks for adding SWT as well.  I will plan to merge in a few days unless there is other feedback in the meantime.
pinging @kwohlfahrt as the other dev who recently worked on the C/Cython code

Thanks @dmpelt


Update README.md

Now that 3.x is released, can change reference back to "checkout 3.x"

Yes, and we should have a 3.x branch, too.


What's New 109

Rendered page for review:
https://review.learn.microsoft.com/en-us/microsoft-edge/devtools-guide-chromium/whats-new/2023/01/devtools-109?branch=pr-en-us-2377
GitHub rendered page:
https://github.com/mikehoffms/edge-developer/blob/user/mikehoffms/whats-new-109/microsoft-edge/devtools-guide-chromium/whats-new/2023/01/devtools-109.md

Learn Build status updates of commit b42b38f:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

microsoft-edge/devtools-guide-chromium/whats-new/2023/01/devtools-109.md
:white_check_mark:Succeeded
View

microsoft-edge/devtools-guide-chromium/whats-new/2023/01/devtools-109-images/template.png
:white_check_mark:Succeeded
View

microsoft-edge/devtools-guide-chromium/whats-new/whats-new.md
:white_check_mark:Succeeded
View

microsoft-edge/toc.yml
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the learn.microsoft.com contributor guidesPost your question in the Learn support channel

Learn Build status updates of commit 2022b31:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

microsoft-edge/devtools-guide-chromium/whats-new/2023/01/devtools-109.md
:white_check_mark:Succeeded
View

microsoft-edge/devtools-guide-chromium/whats-new/2023/01/devtools-109-images/template.png
:white_check_mark:Succeeded
View

microsoft-edge/devtools-guide-chromium/whats-new/whats-new.md
:white_check_mark:Succeeded
View

microsoft-edge/toc.yml
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the learn.microsoft.com contributor guidesPost your question in the Learn support channel

Learn Build status updates of commit e35254f:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

microsoft-edge/devtools-guide-chromium/whats-new/2023/01/devtools-109.md
:white_check_mark:Succeeded
View

microsoft-edge/devtools-guide-chromium/whats-new/2023/01/devtools-109-images/template.png
:white_check_mark:Succeeded
View

microsoft-edge/devtools-guide-chromium/whats-new/whats-new.md
:white_check_mark:Succeeded
View

microsoft-edge/toc.yml
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the learn.microsoft.com contributor guidesPost your question in the Learn support channel

Learn Build status updates of commit 2675b18:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

microsoft-edge/devtools-guide-chromium/whats-new/2023/01/devtools-109.md
:white_check_mark:Succeeded
View

microsoft-edge/devtools-guide-chromium/whats-new/2023/01/devtools-109-images/add-tool-to-quick-view.png
:white_check_mark:Succeeded
View

microsoft-edge/devtools-guide-chromium/whats-new/2023/01/devtools-109-images/advanced-rendering-instrum.png
:white_check_mark:Succeeded
View

microsoft-edge/devtools-guide-chromium/whats-new/2023/01/devtools-109-images/allocation-sampling-profiling-options.png
:white_check_mark:Succeeded
View

microsoft-edge/devtools-guide-chromium/whats-new/2023/01/devtools-109-images/enhanced-trace-export.png
:white_check_mark:Succeeded
View

microsoft-edge/devtools-guide-chromium/whats-new/2023/01/devtools-109-images/enhanced-trace-import.png
:white_check_mark:Succeeded
View

microsoft-edge/devtools-guide-chromium/whats-new/2023/01/devtools-109-images/enhanced-trace-import-console.png
:white_check_mark:Succeeded
View

microsoft-edge/devtools-guide-chromium/whats-new/2023/01/devtools-109-images/enhanced-trace-settings.png
:white_check_mark:Succeeded
View

microsoft-edge/devtools-guide-chromium/whats-new/2023/01/devtools-109-images/heap-snapshot-visualizer-1.png
:white_check_mark:Succeeded
View

microsoft-edge/devtools-guide-chromium/whats-new/2023/01/devtools-109-images/heap-snapshot-visualizer-2.png
:white_check_mark:Succeeded
View

microsoft-edge/devtools-guide-chromium/whats-new/2023/01/devtools-109-images/show-styles.png
:white_check_mark:Succeeded
View

microsoft-edge/devtools-guide-chromium/whats-new/whats-new.md
:white_check_mark:Succeeded
View

microsoft-edge/toc.yml
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the learn.microsoft.com contributor guidesPost your question in the Learn support channel

Learn Build status updates of commit 04bf0b9:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

microsoft-edge/devtools-guide-chromium/whats-new/2023/01/devtools-109.md
:white_check_mark:Succeeded
View

microsoft-edge/devtools-guide-chromium/whats-new/2023/01/devtools-109-images/add-tool-to-quick-view.png
:white_check_mark:Succeeded
View

microsoft-edge/devtools-guide-chromium/whats-new/2023/01/devtools-109-images/advanced-rendering-instrum.png
:white_check_mark:Succeeded
View

microsoft-edge/devtools-guide-chromium/whats-new/2023/01/devtools-109-images/allocation-sampling-profiling-options.png
:white_check_mark:Succeeded
View

microsoft-edge/devtools-guide-chromium/whats-new/2023/01/devtools-109-images/enhanced-trace-export.png
:white_check_mark:Succeeded
View

microsoft-edge/devtools-guide-chromium/whats-new/2023/01/devtools-109-images/enhanced-trace-import.png
:white_check_mark:Succeeded
View

microsoft-edge/devtools-guide-chromium/whats-new/2023/01/devtools-109-images/enhanced-trace-import-console.png
:white_check_mark:Succeeded
View

microsoft-edge/devtools-guide-chromium/whats-new/2023/01/devtools-109-images/enhanced-trace-settings.png
:white_check_mark:Succeeded
View

microsoft-edge/devtools-guide-chromium/whats-new/2023/01/devtools-109-images/heap-snapshot-visualizer-1.png
:white_check_mark:Succeeded
View

microsoft-edge/devtools-guide-chromium/whats-new/2023/01/devtools-109-images/heap-snapshot-visualizer-2.png
:white_check_mark:Succeeded
View

microsoft-edge/devtools-guide-chromium/whats-new/2023/01/devtools-109-images/show-styles.png
:white_check_mark:Succeeded
View

microsoft-edge/devtools-guide-chromium/whats-new/whats-new.md
:white_check_mark:Succeeded
View

microsoft-edge/toc.yml
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the learn.microsoft.com contributor guidesPost your question in the Learn support channel

Learn Build status updates of commit 34c0223:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

microsoft-edge/devtools-guide-chromium/whats-new/2023/01/devtools-109.md
:white_check_mark:Succeeded
View

microsoft-edge/devtools-guide-chromium/whats-new/2023/01/devtools-109-images/add-tool-to-quick-view.png
:white_check_mark:Succeeded
View

microsoft-edge/devtools-guide-chromium/whats-new/2023/01/devtools-109-images/advanced-rendering-instrum.png
:white_check_mark:Succeeded
View

microsoft-edge/devtools-guide-chromium/whats-new/2023/01/devtools-109-images/allocation-sampling-profiling-options.png
:white_check_mark:Succeeded
View

microsoft-edge/devtools-guide-chromium/whats-new/2023/01/devtools-109-images/enhanced-trace-export.png
:white_check_mark:Succeeded
View

microsoft-edge/devtools-guide-chromium/whats-new/2023/01/devtools-109-images/enhanced-trace-import.png
:white_check_mark:Succeeded
View

microsoft-edge/devtools-guide-chromium/whats-new/2023/01/devtools-109-images/enhanced-trace-import-console.png
:white_check_mark:Succeeded
View

microsoft-edge/devtools-guide-chromium/whats-new/2023/01/devtools-109-images/enhanced-trace-settings.png
:white_check_mark:Succeeded
View

microsoft-edge/devtools-guide-chromium/whats-new/2023/01/devtools-109-images/heap-snapshot-visualizer-1.png
:white_check_mark:Succeeded
View

microsoft-edge/devtools-guide-chromium/whats-new/2023/01/devtools-109-images/heap-snapshot-visualizer-2.png
:white_check_mark:Succeeded
View

microsoft-edge/devtools-guide-chromium/whats-new/2023/01/devtools-109-images/show-styles.png
:white_check_mark:Succeeded
View

microsoft-edge/devtools-guide-chromium/whats-new/whats-new.md
:white_check_mark:Succeeded
View

microsoft-edge/toc.yml
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the learn.microsoft.com contributor guidesPost your question in the Learn support channel

Learn Build status updates of commit d2c76d4:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

microsoft-edge/devtools-guide-chromium/whats-new/2023/01/devtools-109.md
:white_check_mark:Succeeded
View

microsoft-edge/devtools-guide-chromium/whats-new/2023/01/devtools-109-images/add-tool-to-quick-view.png
:white_check_mark:Succeeded
View

microsoft-edge/devtools-guide-chromium/whats-new/2023/01/devtools-109-images/advanced-rendering-instrum.png
:white_check_mark:Succeeded
View

microsoft-edge/devtools-guide-chromium/whats-new/2023/01/devtools-109-images/allocation-sampling-profiling-options.png
:white_check_mark:Succeeded
View

microsoft-edge/devtools-guide-chromium/whats-new/2023/01/devtools-109-images/enhanced-trace-export.png
:white_check_mark:Succeeded
View

microsoft-edge/devtools-guide-chromium/whats-new/2023/01/devtools-109-images/enhanced-trace-import.png
:white_check_mark:Succeeded
View

microsoft-edge/devtools-guide-chromium/whats-new/2023/01/devtools-109-images/enhanced-trace-import-console.png
:white_check_mark:Succeeded
View

microsoft-edge/devtools-guide-chromium/whats-new/2023/01/devtools-109-images/enhanced-trace-settings.png
:white_check_mark:Succeeded
View

microsoft-edge/devtools-guide-chromium/whats-new/2023/01/devtools-109-images/heap-snapshot-visualizer-1.png
:white_check_mark:Succeeded
View

microsoft-edge/devtools-guide-chromium/whats-new/2023/01/devtools-109-images/heap-snapshot-visualizer-2.png
:white_check_mark:Succeeded
View

microsoft-edge/devtools-guide-chromium/whats-new/2023/01/devtools-109-images/show-styles.png
:white_check_mark:Succeeded
View

microsoft-edge/devtools-guide-chromium/whats-new/whats-new.md
:white_check_mark:Succeeded
View

microsoft-edge/toc.yml
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the learn.microsoft.com contributor guidesPost your question in the Learn support channel

Happy with the sections on Quick View changes and Styles navigation. LGTM

LGTM! #sign_off


"node app.js" does not properly start server locally

when running the app locally, the program hangs at the end of the app.js file, with
connect-to-mongo
as the last console.log, instead of throwing any errors

Are you able to connect to the mongo server on your local host?

yes, the mongo connection completes okay, but from what I see, it seems like starting the app with node app.js may cause an issue, since the server.listen command is in the server.js file. so the app starts, but it doesn't ever load the web server or start listening for requests

Oh I see, the package.json shows that npm start will run node server.js The README should be updated accordingly, since it is still instructing us to run node app.js

Good catch, I just updated the readme to say npm start instead.


[cli] Fixed polymer 3.x templates and updated CHANGELOG to prepare for CLI release.

Fixes https://github.com/Polymer/tools/issues/357 and when we release, will reduce download size for users by 250mb.

$ npm install polymer-cli
1.7.0 : 553M
1.7.1 : 286M


Add remote write for the aggregate-prometheus

How to categorize this issue?

/area monitoring
/kind enhancement
What would you like to be added:
It should be possible to configure the aggregate prometheus to write to a remote write endpoint. Similar to #4935
Why is this needed:
In some scenarios seeds are behind firewalls and it is not possible to scrape the aggregate-prometheus from outside of the network. In this case it is better if the prometheus can "push" its data instead.

/remove-lifecycle stale


Fix alert

Description
It complete the telemetry module
Checklist

[ ] Targeted PR against correct branch.
[ ] Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
[ ] Wrote unit tests.
[ ] Re-reviewed Files changed in the Github PR explorer.

Codecov Report

:exclamation: No coverage uploaded for pull request base (main@af7ad10). Click here to learn what that means.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #14   +/-   ##
=======================================
  Coverage        ?   41.45%
=======================================
  Files           ?       29
  Lines           ?     1749
  Branches        ?        0
=======================================
  Hits            ?      725
  Misses          ?      944
  Partials        ?       80

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update af7ad10...d6a9ea4. Read the comment docs.


Fail to compile via cargo error: failed to run custom build command for libudev-sys v0.1.4

Describe the bug
Tried to install via cargo.

To reuse those artifacts with a future compilation, set the environment variable `CARGO_TARGET_DIR` to that path.

Expected behavior
Install finishing with no errors.
Desktop (please complete the following information):
$ neofetch
             ...-:::::-...                 pato@qtpi
          .-MMMMMMMMMMMMMMM-.              ---------
      .-MMMM`..-:::::::-..`MMMM-.          OS: Linux Mint 21.3 x86_64
    .:MMMM.:MMMMMMMMMMMMMMM:.MMMM:.        Host: B660M DS3H DDR4
   -MMM-M---MMMMMMMMMMMMMMMMMMM.MMM-       Kernel: 6.5.0-35-generic
 `:MMM:MM`  :MMMM:....::-...-MMMM:MMM:`    Uptime: 14 hours, 33 mins
 :MMM:MMM`  :MM:`  ``    ``  `:MMM:MMM:    Packages: 2728 (dpkg), 22 (flatpak)
.MMM.MMMM`  :MM.  -MM.  .MM-  `MMMM.MMM.   Shell: bash 5.1.16
:MMM:MMMM`  :MM.  -MM-  .MM:  `MMMM-MMM:   Resolution: 1920x1080, 1920x1080
:MMM:MMMM`  :MM.  -MM-  .MM:  `MMMM:MMM:   DE: Cinnamon 6.0.4
:MMM:MMMM`  :MM.  -MM-  .MM:  `MMMM-MMM:   WM: Mutter (Muffin)
.MMM.MMMM`  :MM:--:MM:--:MM:  `MMMM.MMM.   WM Theme: Mint-Y-Dark-Purple (Mint-Y
 :MMM:MMM-  `-MMMMMMMMMMMM-`  -MMM-MMM:    Theme: Mint-Y-Dark-Purple [GTK2/3]
  :MMM:MMM:`                `:MMM:MMM:     Icons: Mint-Y-Purple [GTK2/3]
   .MMM.MMMM:--------------:MMMM.MMM.      Terminal: gnome-terminal
     '-MMMM.-MMMMMMMMMMMMMMM-.MMMM-'       CPU: 12th Gen Intel i5-12400F (12) @
       '.-MMMM``--:::::--``MMMM-.'         GPU: AMD ATI Radeon RX 6800/6800 XT
            '-MMMMMMMMMMMMM-'              Memory: 5960MiB / 31928MiB
               ``-:::::-``

I would like to ask you to please follow the install instructions. cargo install is not recommended (despite it still being a listed method) and won't be available starting from the next release. Please let us know if you have further issues with the documented instructions.

OK, running the suggested script solved it! Thank you.


Implement landing page functionality endpoint.

We must have an endpoint that contains all of the landing page functionality
e.g.
day1:{
    events: {
        birthday: [{name: "boo"}],
        days_off: ["boo2","foo2"],
    },
    leaves: {
        leave_excuse : [<Users>],
        annual_leaves : [<Users>],
    }
    meetings: {
        1: [<Meetings>] # based on date,
    }
}

@0oM4R
As we discussed, please create another one to the google calendar API, and explain what we have to do in the description.


Add publishing-api presenter for Guide editions

Trello: https://trello.com/c/r2gA1lxN/640-migrate-guide-format-to-rendered
Paired with @emmabeynon

Are you planning to have another PR for adding the format to MIGRATED_EDITION_CLASSES for updating the preview link?

@davidbasalla I think I must have pushed that commit at exactly the same time as your comment.

You could add a test for the migrated format to https://github.com/alphagov/publisher/blob/master/test/unit/edition_test.rb#L81-L101
Looks good otherwise! There might be a small edge case where a user could add a new part but not fill in the title. Publisher does not seem to validate the presence of title and lets you save the edition, but presumably pushing to the publishing api will fail because it expects a string (actually that depends if it gets nil or an empty string I suppose). Anyway, I had a look in Publisher in integration and couldn't find any published Guides where the title was nil, so it's probably nothing to worry about.

Yep, always getting caught out by the nil values. @davidbasalla fixed

🎉 👍


when the plugin is installed automatically create the taggers group

When the plugin is installed it should automatically create the tagger group and add the installing person (who's obviously an admin) as a member of that group.

fixed in latest pull.


The right alt-key does not work as expected on swedish keyboard on macos

What did you expect to happen?
When pressing right-alt and 2 the character "@" in expected to happen.
What actually happened?
The minibuffer shows "C-u 2-"
Additional details:
Vanilla doom emacs used.
Steps to reproduce:

Press right alt and 2 and swedish keyboard on macos.

System information:

emacs   version    27.0.91
        features   IMAGEMAGICK DBUS NOTIFY KQUEUE ACL GNUTLS LIBXML2 ZLIB TOOLKIT_SCROLL_BARS XIM MODULES THREADS JSON PDUMPER LCMS2 GMP
        build      Jul 01, 2020
        buildopts  (--prefix=/opt/local --with-mac --enable-mac-app=/Applications/MacPorts --with-modules --without-rsvg --with-gmp --with-harfbuzz --with-json --with-imagemagick 'CFLAGS=-pipe -Os -fobjc-arc -isysroot/Library/Developer/CommandLineTools/SDKs/MacOSX10.15.sdk -arch x86_64' 'CPPFLAGS=-I/opt/local/include -isysroot/Library/Developer/CommandLineTools/SDKs/MacOSX10.15.sdk' 'LDFLAGS=-L/opt/local/lib -Wl,-headerpad_max_install_names -Wl,-syslibroot,/Library/Developer/CommandLineTools/SDKs/MacOSX10.15.sdk -arch x86_64')
        windowsys  mac
        daemonp    server-running
doom    version    2.0.9
        build      grafted, HEAD -> develop, origin/develop, origin/HEAD 46d6d0b 2020-06-29 15:12:30 -0400
        dir        ~/.doom.d/
system  type       darwin
        config     x86_64-apple-darwin19.5.0
        shell      /bin/zsh
        uname      Darwin 19.5.0 Darwin Kernel Version 19.5.0: Tue May 26 20:41:44 PDT 2020; root:xnu-6153.121.2~2/RELEASE_X86_64 x86_64
        path       (~/.opam/default/bin ~/.emacs.d/bin ~/.opam/default/bin ~/bin ~/Library/Python/3.7/bin /opt/local/bin /opt/local/sbin /usr/local/bin /usr/bin /bin /usr/sbin /sbin /opt/X11/bin /Applications/MacPorts/EmacsMac.app/Contents/MacOS/libexec/)
config  envfile    envvar-file
        elc-files  1
        modules    (:completion company ivy :ui doom doom-dashboard doom-quit hl-todo modeline ophints (popup +defaults) vc-gutter vi-tilde-fringe workspaces :editor file-templates fold snippets :emacs dired electric undo vc :checkers syntax spell grammar :tools (eval +overlay) lookup lsp macos magit make pdf :lang elm emacs-lisp fstar idris json javascript latex lean lua markdown nim ocaml org python rst sh :config (default +bindings +smartparens))
        packages   (n/a)
        unpin      (n/a)
        elpa       (n/a)

Setting these variables seems to fix the problem:
(setq mac-option-modifier nil
      mac-command-modifier 'meta)


pangloss/vim-javascript: add missing links

Add links to missing highlighting groups for pangloss/vim-javascript plugin

Thank you for your patience! 🙏🏼
It‘s been a while since I had free time to focus more on Nord, and my open source projects in general, and invest time in this issue due to work-life balance.
I recently published the first “Northern Post — The state and roadmap of Nord“ announcement which includes all details about the plans and future of the Nord project, including the goal of catching up with the backlog. This issue is part of the backlog and therefore I want to triage and process it to get one step closer to a “clean state“. Read the announcement about reaching the “clean“ contribution triage state in Nord‘s discussions for more details about the goal.
Therefore it has been added to the queue in the central and single-source-of-truth project board that is also described in more detail in the roadmap announcement.

@mrvik Thanks for your contribution 🚀
The pull request has been added to the queue and the review will be planned for the next iterations!


export grammar as module string

when defining grammar that uses escaped characters as a js string
e.g.:
const grString = `
Grammar {
// ...more grammar here

lineTerminator = "\n" | "\r" | "\u2028" | "\u2029"

// ...more grammar here
}
`

ohm.grammar(grString)

with
/node_modules/ohm-js/src/main.js:283
    throw errors.grammarSyntaxError(m);
    ^

Error: Line 68, col 20:
> 68 |  lineTerminator = "
                          ^
" | "
" | "
"
Expected "\"", not "\n", or an escape sequence

Although it works as expected when :

reading the grammar from a file
grammar doesn't use escaped chars

note that lineTerminator is taken from ohm's javascript grammar example

You have to be careful when writing Ohm grammars inside of a JavaScript string literal. The \n here is an escape sequence that is replaced with a literal newline character before Ohm sees the string.
It's especially since Ohm supports many of the same escape sequences as JavaScript, so you have to be mindful of which level is interpreting your escape!
There are two solutions:

Use String.raw:const grString = String.raw`
    lineTerminator = "\n"
    ...
`

Or, use a double backslash everywhere you want a single backslash to appear in the Ohm grammar:const grString = `
    lineTerminator = "\\n"
`


Build CLI from Docker instead of source codes, add alpine and jdk17 based Docker image

I noticed 8.8.0-alphine is updated, let's make *-jdk17 available too.
https://hub.docker.com/r/apache/skywalking-java-agent/tags

Pushed


Issue 494 followup

Description
Set default dtlsRole for answer client rather than server.
This is done to change the sdp ConnectionRole to  'active' rather than 'passive' when answering, as is recommended by the RFC (details in comments).
Reference issue
Fixes #494 follow up issue

Tests failing - I'll close this until I can work out what's going on. Sorry for noise.

@jbert I am happy to fix the tests! My guess is that they are just flakes, this really shouldn't effect anything.
If we have tests that do depend on the role we can force behavior via the SettingEngine for testing.

Hi @Sean-Der  You're right, altering the DTLS role via the setting engine recreates the test failure:
`
diff --git a/e2e/e2e_test.go b/e2e/e2e_test.go
index 366bee4..a9f1f9f 100644
--- a/e2e/e2e_test.go
+++ b/e2e/e2e_test.go
@@ -345,7 +345,14 @@ func createTrack(offer webrtc.SessionDescription) (*webrtc.PeerConnection, *webr
if payloadType == 0 {
return nil, nil, nil, errors.New("Remote peer does not support VP8")
}

  api := webrtc.NewAPI(webrtc.WithMediaEngine(mediaEngine))

  settingEngine := webrtc.SettingEngine{}

  settingEngine.SetAnsweringDTLSRole(webrtc.DTLSRoleClient)

  api := webrtc.NewAPI(

          webrtc.WithMediaEngine(mediaEngine),

          webrtc.WithSettingEngine(settingEngine),

  )
  pc, errPc := api.NewPeerConnection(webrtc.Configuration{})
  if errPc != nil {
          return nil, nil, nil, errPc

$ time go test -tags=e2e -v ./e2e/
...
=== RUN   TestE2E_Audio/Chrome
TestE2E_Audio/Chrome: e2e_test.go:147: Number of OPUS packets is expected to be: 50/second, got: 0/second
--- FAIL: TestE2E_Audio (6.44s)
`
Do you have any suggestions on the best way to progress?
I could adapt the TestE2E_Audio test to run in both DTLSClient and DTLSServer mode to expose the problem (I think this would add another 6-7s to test runtime though) - that would give us a branch with broken E2E tests. Then I guess it's either a test bug, a chrome bug or a @jbert 's understanding of the RFC bug?

Hey @jbert
This turned out to be a bug in pion/dtls here! I fixed it and will be updating the default state with the RFC you cited.
Sorry for not following up on this sooner. My backlog keeps growing by the day :)

That is fantastic. Thank you!
Thank you for not minding that I didn't push this to completion. I got as far as the failing interop tests with headless chromium which shook my confidence that this change was actually correct.
One thing which might be interesting is that - in principle - this reduces the time-to-first-frame for a client calling pions. We don't need to wait for the SDP answer to traverse the signalling pathway before starting the setup.
I don't know if we have any measurements on this, but it would be cool to know if this was the case in practice. (Speedup should be of the order or "time to return SDP offer").

@jbert thanks for using Pion and contributing, it is super motivating to have people use it!

would be cool to know if this was the case i
Yea that would be amazing to know! I personally am only using Pion for testing/one-off things so I don't have that data :(

If there is anything I can do to make Pion better I would love to hear! Always looking to improve things.


podman - OracleDatabase: Operation not permitted

For some reason step 5 of the Dockerfile for creating an Oracle Database (<IP_ADDRESS>) fails due to an "operation not permitted" error. Any ideas why?
Note: using podman instead of docker, so it's probably something related to that.
docker-images/OracleDatabase/SingleInstance/dockerfiles on  master [✘]
➜ ./buildDockerImage.sh -v <IP_ADDRESS> -s -i
Error: template: image:1:9: executing "image" at <.Server.Version>: can't evaluate field Server in type define.Version
./buildDockerImage.sh: line 58: [: : integer expression expected
Ignored MD5 checksum.
==========================
DOCKER info:
host:
  BuildahVersion: 1.11.3
  CgroupVersion: v1
  Conmon:
    package: conmon-2.0.2-1.fc31.x86_64
    path: /usr/bin/conmon
    version: 'conmon version 2.0.2, commit: 186a550ba0866ce799d74006dab97969a2107979'
  Distribution:
    distribution: fedora
    version: "31"
  IDMappings:
    gidmap:
    - container_id: 0
      host_id: 1001
      size: 1
    - container_id: 1
      host_id: 100000
      size: 65536
    uidmap:
    - container_id: 0
      host_id: 1000
      size: 1
    - container_id: 1
      host_id: 100000
      size: 65536
  MemFree:<PHONE_NUMBER>4
  MemTotal:<PHONE_NUMBER>6
  OCIRuntime:
    name: crun
    package: crun-0.10.6-1.fc31.x86_64
    path: /usr/bin/crun
    version: |-
      crun version 0.10.6
      spec: 1.0.0
      +SYSTEMD +SELINUX +APPARMOR +CAP +SECCOMP +EBPF +YAJL
  SwapFree:<PHONE_NUMBER>0
  SwapTotal:<PHONE_NUMBER>0
  arch: amd64
  cpus: 8
  eventlogger: journald
  hostname: quine-p70
  kernel: 5.3.14-300.fc31.x86_64
  os: linux
  rootless: true
  slirp4netns:
    Executable: /usr/bin/slirp4netns
    Package: slirp4netns-0.4.0-20.1.dev.gitbbd6f25.fc31.x86_64
    Version: |-
      slirp4netns version 0.4.0-beta.3+dev
      commit: bbd6f25c70d5db2a1cd3bfb0416a8db99a75ed7e
  uptime: 2h 53m 18.64s (Approximately 0.08 days)
registries:
  blocked: null
  insecure: null
  search:
  - docker.io
  - registry.fedoraproject.org
  - registry.access.redhat.com
  - registry.centos.org
  - quay.io
store:
  ConfigFile: /home/gareth/.config/containers/storage.conf
  ContainerStore:
    number: 0
  GraphDriverName: overlay
  GraphOptions:
    overlay.mount_program:
      Executable: /usr/bin/fuse-overlayfs
      Package: fuse-overlayfs-0.7-1.fc31.x86_64
      Version: |-
        fusermount3 version: 3.6.2
        fuse-overlayfs: version 0.7
        FUSE library version 3.6.2
        using FUSE kernel interface version 7.29
  GraphRoot: /home/gareth/.local/share/containers/storage
  GraphStatus:
    Backing Filesystem: extfs
    Native Overlay Diff: "false"
    Supports d_type: "true"
    Using metacopy: "false"
  ImageStore:
    number: 114
  RunRoot: /run/user/1000
  VolumePath: /home/gareth/.local/share/containers/storage/volumes

==========================
Building image 'oracle/database:<IP_ADDRESS>-se2' ...
STEP 1: FROM oraclelinux:7-slim AS base
STEP 2: MAINTAINER Gerald Venzl<EMAIL_ADDRESS>c105dd2230d7079e1c395ee8040d9958a9c399292b1dba1847718b016148595c
STEP 3: ENV ORACLE_BASE=/opt/oracle     ORACLE_HOME=/opt/oracle/product/<IP_ADDRESS>/dbhome_1     INSTALL_DIR=/opt/install     INSTALL_FILE_1="linuxx64_12201_database.zip"     INSTALL_RSP="db_inst.rsp"     CONFIG_RSP="dbca.rsp.tmpl"     PWD_FILE="setPassword.sh"     RUN_FILE="runOracle.sh"     START_FILE="startDB.sh"     CREATE_DB_FILE="createDB.sh"     SETUP_LINUX_FILE="setupLinuxEnv.sh"     CHECK_SPACE_FILE="checkSpace.sh"     CHECK_DB_FILE="checkDBStatus.sh"     USER_SCRIPTS_FILE="runUserScripts.sh"     INSTALL_DB_BINARIES_FILE="installDBBinaries.sh"
44c537a755739675094c55417e9b72f22a80b622de0a30cf8a5d028f0404286b
STEP 4: ENV PATH=$ORACLE_HOME/bin:$ORACLE_HOME/OPatch/:/usr/sbin:$PATH     LD_LIBRARY_PATH=$ORACLE_HOME/lib:/usr/lib     CLASSPATH=$ORACLE_HOME/jlib:$ORACLE_HOME/rdbms/jlib
e18487ef7afd35cc12f3f27224db1dfa7348582ccd42e00fdf279c525baac1fa
STEP 5: COPY $SETUP_LINUX_FILE $CHECK_SPACE_FILE $INSTALL_DIR/
Error: error building at STEP "COPY $SETUP_LINUX_FILE $CHECK_SPACE_FILE $INSTALL_DIR/": error creating directory "/home/gareth/.local/share/containers/storage/overlay/08cc3c68a35128e801154f6b3ba48fa189e21e6d0886c1a613e063d25e99993d/merged/opt/install": mkdir /home/gareth/.local/share/containers/storage/overlay/08cc3c68a35128e801154f6b3ba48fa189e21e6d0886c1a613e063d25e99993d/merged/opt/install: operation not permitted

Seems like an overlay FS error: Error: error building at STEP "COPY $SETUP_LINUX_FILE $CHECK_SPACE_FILE $INSTALL_DIR/": error creating directory "/home/gareth/.local/share/containers/storage/overlay/08cc3c68a35128e801154f6b3ba48fa189e21e6d0886c1a613e063d25e99993d/merged/opt/install": mkdir /home/gareth/.local/share/containers/storage/overlay/08cc3c68a35128e801154f6b3ba48fa189e21e6d0886c1a613e063d25e99993d/merged/opt/install: operation not permitted

Because Podman allows non-root users to create/manage their own containers, it stores those containers in $HOME/.local/ and I'm guessing that either your $HOME is not on an XFS file system or if it is on XFS, perhaps it doesn't have the -ftype=1 option set (which unfortunately can only be set when the file system is created).

As you're on Fedora, this may also be applicable: http://chris.collins.is/2019/01/25/podman-overlay-is-not-supported-over-xfs/

Thanks @Djelibeybi , but my storage.conf looks ok and no, I'm on ext4, not XFS
I've had to move on with this, so i've reinstalled docker CE just to work around the problem for now. I'll come back to it at some point in the future as I like the ideas of podman.

Thanks, I'll close this issue. If you have an issue when you come back to it and you feel it's related to these images in particular, open up a new issue.


Deleting via a predicate doesn't delete by measurement

I expected to be able to delete some data by specifying the measurement I wanted to filter on. I then expect all of the data for series with that measurement to be deleted. I used the following tag key to specify the measurement: _measurement.
The data in my test was not deleted.
 This issue could be:

a UX/doc issue - help the user specify the predicate properly;
a CLI/API bug;
a storage engine bug.

FWIW if I specify a predicate like this: -p cpu=v then series data with the tag pair cpu=v is correctly removed.

The same problem applies with _field too.

I am very certain that the issue here is that _measurement and _field are not being converted to their storage engine representations, which are available at models.MeasurementTagKey and models.FieldTagKey respectively.

influx delete -o edd -b edd --start 2009-01-02T23:00:00Z --stop 2020-01-02T23:00:00Z


PowerToys Run - Delayed Input

Microsoft PowerToys version
0.59.1
Running as admin

[ ] Yes

Area(s) with issue?
PowerToys Run
Steps to reproduce
This is hard to take a screenshot of, but I cannot push any run commands simply by typing anymore. I don't update whenever ever there is a new version out, but updating recently has broken the input.
To reproduce, simply open the Run prompt and type the command followed by 'Enter' immediately and nothing happens. There seems to be a delay (up to one second) before it will allow you to choose an application or command.
Its extremely notificable for fast typing or startup launching when I'm going through my startup commands. I hit my run key and quickly type 'Excel', 'Calc', 'Edge', 'Firefox', 'iView', 'Photoshop'.
Unsure if this is part of it, but i notice when I type Photoshop super fast -- it opens photos instead (like the search got photos first from the partial string, but fell behind when the word was finished).
✔ Expected Behavior
Open Application that are typed into the Run GUI.
❌ Actual Behavior
Run GUI simply reflecting what type, but fails to launch.
Other Software
No response

@unDrac86
Did you try if it helps when the input delay is disabled in the settings?
Otherwise it sounds like the same problem I have too. I described it here: https://github.com/microsoft/PowerToys/issues/18696#issuecomment-1156735921

I didn't realize that was an option now... Turn it off and it works. Thank you.


How to implement tracing with opentelemetry

I've been trying to get tracing working with openTelemetry, the basic setup is as follows:
gateway -> grpc -> service
I am able to get 2 individual traces, 1 for the gateway and 1 for the service, but this should really be 1 span that can be broken into two.
Using Chi Router I should be able to do this
func (mw TracingMiddleware) Wrap(next http.Handler) http.Handler {
	return http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
		rt, _ := router.CurrentRoute(r)
		ctx, span := mw.Tracer.Start(r.Context(), r.Method + " " + rt.Route, trace.WithSpanKind(trace.SpanKindServer))
		r = r.WithContext(ctx)
		defer span.End()
		next.ServeHTTP(w, r)
	})
}

This should add a span to the context, and I can verify this happens by inspecting the context in debug mode.
However, when I pass the context to the go micro grpc endpoint, the span is lost, and instead the context contains these
micro-span-id -> 9d9bd6a0-4346-45cb-857d-a7362d1729c6
Micro-Trace-Id -> b1665b37-a529-4e6a-98db-c1b449eafa16

How should I implement this?

You should serialize the trace in the context for another service to continue adding spans on it. I did some work on it that you can peek here Essentially all services have to be on the same page on which propagation strategy to use, so the trace can be reconstructed. The rest is up to the OT interceptors.

@refs so you didn’t use the existing middleware? And instead attached the baggage to the trace and pass that around?
Do you have a simple example of this?

https://github.com/go-micro/plugins/tree/main/v4/wrapper/trace/opentelemetry


What's the preferred DataDogInterceptor sampling rate?

Question
Hi!
We've been discussing with our team what should be the preferred sampling rate for DataDogInterceptor.
We do track all of our sessions in RUM (internal const val DEFAULT_SAMPLE_RATE: Float = 100f) but noticed that the interceptor itself defaults to only 20% (internal const val DEFAULT_TRACE_SAMPLE_RATE: Float = 20f) - we currently keep it at 1% (someone set that this way without any specific reason).
Hence I wanted to ask:

is there anything to consider client-performance-wise before setting this to 100%?
are there any cost implications of tracking more requests?
last but not least - does it make sense to track all of the requests?

Hi @scana 👋

is there anything to consider client-performance-wise before setting this to 100%?
The impact on the performance of tracking more or less network requests is negligible and not noticeable in most cases, unless your app is sending billions of network requests per minute :)
However, the more things you track, the more data our SDK uploads to Datadog's backend, and this is the inherent tradeoff of observability. So we usually recommend to keep this in mind when instrumenting your application, and we don't have a "one size fits all" answer to provide I'm afraid.
We're working on our end on producing up-to-date benchmarks of the SDK footprint, but last time we computed some: uploads were around 73 KB and downloads were around 5 KB for an average 2:10 session with some browsing, taps, swipes, opening and closing views, the app sending some network requests…

are there any cost implications of tracking more requests?
Not on the RUM side, as the billing unit is the Session, regardless of whether a Session contains 1 View only, or whether it contains an insane volume of Views, Resources, Errors, Actions... However, if you use distributed tracing, the sampling decision taken client-side by the SDK will override the ones defined in your backend services monitored with APM, which can result in a surge of spans being ingested, and therefore a surge of costs.
We are working on some initiatives on this front to give you more control over client-side sampling decisions, but these are very complex projects and will take a few months if not a few quarters to be released.

does it make sense to track all of the requests?
In most cases, no, it doesn't. But we do see customers tracking all of them in some cases:

the traffic their getting is too low to get a statistically significant volume of data if sampling
the requests to a particular endpoint are critical (e.g. login or checkout) and shall all be tracked for alerting & troubleshooting

Hope this helps :)
Let me know if I answered your questions and I'll close the issue

Hello @scana! I'm closing this ticket due to inactivity. Feel free to reopen it if you have more questions regarding this topic.


Add Indonesian translation

Hi! Thank you very much for your contribution. Everything looks fine to me, merging! :)


libuv new_pipe, spawn missing arguments

Fixes issue #14

This looks great, looks like I was accidentally relying on undefined behavior that changed with an luv update.


Error while installing rocm-dkms

I am getting the below error when installing rocm-dkmsam
I am using Ubuntu 16.04 LTS
/var/lib/dkms/amdgpu/1.8-192/build/amd/amdgpu/amdgpu_atpx_handler.c:577:19: error: initialization from incompatible pointer type [-Werror=incompatible-pointer-types]
   .get_client_id = amdgpu_atpx_get_client_id,
                    ^
 /var/lib/dkms/amdgpu/1.8-192/build/amd/amdgpu/amdgpu_atpx_handler.c:577:19: note: (near initialization for ‘amdgpu_atpx_handler.get_client_id’)
   CC [M]  /var/lib/dkms/amdgpu/1.8-192/build/amd/amdgpu/../powerplay/smumgr/smumgr.o
 cc1: some warnings being treated as errors
 scripts/Makefile.build:332: recipe for target '/var/lib/dkms/amdgpu/1.8-192/build/amd/amdgpu/amdgpu_atpx_handler.o' failed
 make[2]: *** [/var/lib/dkms/amdgpu/1.8-192/build/amd/amdgpu/amdgpu_atpx_handler.o] Error 1
 make[2]: *** Waiting for unfinished jobs....
 scripts/Makefile.build:606: recipe for target '/var/lib/dkms/amdgpu/1.8-192/build/amd/amdgpu' failed
 make[1]: *** [/var/lib/dkms/amdgpu/1.8-192/build/amd/amdgpu] Error 2
 Makefile:1552: recipe for target '_module_/var/lib/dk
[error.log](https://github.com/RadeonOpenCompute/ROCm/files/2320949/error.log)
ms/amdgpu/1.8-192/build' failed
 make: *** [_module_/var/lib/dkms/amdgpu/1.8-192/build] Error 2
 make: Leaving directory '/usr/src/linux-headers-4.15.0-33-generic'
DKMSKernelVersion: 4.15.0-33-generic
Date: Sat Aug 25 23:51:42 2018
DuplicateSignature: dkms:rock-dkms:1.8-192:/var/lib/dkms/amdgpu/1.8-192/build/amd/amdgpu/amdgpu_atpx_handler.c:577:19: error: initialization from incompatible pointer type [-Werror=incompatible-pointer-ty
pes]

Attached is the full log.

Dupe of #510. We're looking into this -- sorry about the difficulties. Kernel 4.15.0-32 and below should work, if you're OK temporarily downgrading your kernel version. We will have -33 working soon.

Yea that would be good. Thanks.
Please let me know when the the Kernel is fixed


DeWi light gateway compliance audit for Radxa Zero

No it's not @marvinmarnold - not as far as I'm aware anyway.
I've sent them all the documents but haven't heard back yet

@shawaj thanks. Should we create a separate issue to track that?


Review for v1.1.0

This PR has only been created for reviewing the changes between version 1.0.0 and version 1.1.0.
@n400peanuts

This has been processed.


can't seem to subscribe to any notifications.

[Enter feedback here]
The documentation is not clear enough to me.
If I do an @Asure Repos and press space it emediatly starts searching trough the pull requests.
While I'm attempting to subscribe to a repo so we can get pull request notifications in that channel.
But I can't seem to add nor view current subscriptions or do anything else but search pull requests. Am I missing something?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 43aa8c60-c25d-535b-2166-f51fa9f171c6
Version Independent ID: 8890a537-9eda-5606-4be4-580bdc9e8269
Content: Azure Repos with Microsoft Teams - Azure Repos
Content Source: docs/repos/integrations/repos-teams.md
Product: devops
Technology: devops-code-git
GitHub Login: @divya
Microsoft Alias: divais

@thomps23 Author's GitHub alias cannot be found.


[Popup] difference from menu/menuitem elements

Sorry if the question is silly, but how would the popup proposal be different in functionality from a stylable form of menu? Wouldn't it be better to review/addapt it's definition?
One of the examples on MDN is specifically for a dropdown.

Hi @madcampos, not a silly question!
There's a couple things here. First, menu is effectively deprecated. Not having been around during its evolution in standards, I'm not exactly sure why it ended up in such a state where it is not supported. Perhaps folks would be interested in discussing that element/design again, and we could leverage that for the menu-specific use cases for popup.
That brings me to the other part of this in that we imagine popup as being useful for various different types of popover UI. We've chosen to use an action menu as a primary example, but folks use popup-esque patterns for many different types of content, such as pickers that don't follow a flat menuitem structure. So I guess the main difference here is that action menus would serve only as a subset of the element's use cases.
Hope that answers your question!

Yes, that sure answered my question.
As a more "generic" element popup could be used to (re) implement the functionality of menu.


Remove duplication for ShareX entry

There are actually 3 consecutive duplicate items. I independently removed them in #341.


Auth members refactor

Started here: https://github.com/MainfluxLabs/mainflux/pull/547

After to fix mocks add back TestListOrgsByMember


Using named profiles with "env" does not seem to work

As soon as I add the construct to my project, I get this error message: Error at /MainServiceStack/ClamAVStack] Need to perform AWS calls for account 123, but the current credentials are for 456 where 123 is the account I have configured in my profile and set up using "env" in my main cdk stack and 456 is the account that my user lives in. For all actions I have to assume a role in another account (e.g. production, staging, development) to be able to deploy to that account. It all works fine but not in combination with this construct. Has anyone seen this before or have any ideas how to fix it?
Thanks

This construct deploys assets (container images, lambda code) to the AWS account. Do you see similar issues with doing lookups or if creating other Docker images?

Closing due to inactivity


Generic-Battery Costs page does not update power units

The number for costs on the generic-battery costs page are pulled directly from the battery cell and system page, rather than being converted for DC. This appears to only affect the generic battery, not pv-battery:
From 2020.11.29:

Costs:

@cpaulgilman also suggested capitalizing "dc" on the costs page.

Closed in PR SAM 469, merged into patch and develop


Fix Docker image construction and Tox test invocation

Thanks! Sorry for delay

Been carrying around that for loop in a git stash for weeks :S


encountering non-empty plans when deploying json dashboards

Describe the bug
Terraform keeps trying to update the contents of the json dashboards even if there are no changes in the code. My observation is that the content it keeps trying to add is part of the dashboard json code but it's not stored in the state file thereby causing the non-empty plans.
To Reproduce
Steps to reproduce the behavior:
Use any of the preset dashboards from this link https://github.com/Dynatrace/snippets/tree/master/product/dashboarding/aws-metric-streaming and attach the json file to the dashboard resource similar to below
resource "dynatrace_json_dashboard" "dashboard" {
for_each = local.dashboard_files_classic
contents = each.value
link_id  = dynatrace_json_dashboard_base.dashboard_base[each.key].id
provider = dynatrace.dashboard
}
dynatrace version 1.59.1
Expected behavior
Terraform plan only shows changes when changes are made in the code as it should be.
Screenshots
screenshot showing the code

Screenshot showing the terraform plan

Screenshot showing the state file, which indicate the dashboard filter being part of the code but not part of the state file

Desktop (please complete the following information):

OS: [e.g. iOS]
Browser [e.g. chrome, safari]
Version [e.g. 22]

Smartphone (please complete the following information):

Device: [e.g. iPhone6]
OS: [e.g. iOS8.1]
Browser [e.g. stock browser, safari]
Version [e.g. 22]

Additional context
Add any other context about the problem here.

Hello @amsanmie,
You're experiencing a well known limitation we're facing with Terraform when applying Dashboards.
Unfortunately the JSON code you're getting when exporting Dashboards as JSON via WebUI and the JSON Code that's provided via REST API aren't aligned in multiple ways.
In most cases it is simply about default values vs omitting an attribute. And within these cases it is usually about additional, optional attributes that CAN get omitted.
The only bullet proof way to ensure non-empty plans at the moment is to gradually align the local JSON code within your Terraform Module until the plan remains empty.
I'm going to keep this ticket open, however. After trying out a couple of the JSON files that are available through the link you've provided I'm sure we can reduce the possibility of non-empty plans to a bare minimum - simply by suppressing the diff for a couple of edge cases we've not been aware of yet.
We will keep you posted here about the progress.
best regards,
Reinhard