Autopush broken due to conversion from master to main on some upstream repos

Cloning into bare repository 'srcs/pythondata-cpu-serv'...
fatal: ambiguous argument 'master': unknown revision or path not in the working tree.
Use '--' to separate paths from revisions, like this:
'git <command> [<revision>...] -- [<file>...]'
Traceback (most recent call last):
  File "./update.py", line 559, in <module>
    sys.exit(main(sys.argv[0], sys.argv[1:]))
  File "./update.py", line 511, in main
    get_src(m)
  File "./update.py", line 193, in get_src
    git_hash = get_hash(module_data['branch'], env)
  File "./update.py", line 125, in get_hash
    env=env).decode('utf-8').strip()
  File "/usr/lib/python3.6/subprocess.py", line 356, in check_output
    **kwargs).stdout
  File "/usr/lib/python3.6/subprocess.py", line 438, in run
    output=stdout, stderr=stderr)
subprocess.CalledProcessError: Command '['git', 'rev-parse', 'master']' returned non-zero exit status 128.
Error: Process completed with exit code 1.

@mithro Can you have a look at fixing pythondata-auto or have someone looking at it? The initial aim for it was to simplify creating/updating external data files but the fact that it's not often functional complicates maintenance. Thanks.

@kgugala - Can you get someone to look at this?

@enjoy-digital - I do apologize and agree that it isn't acceptable for this to be broken since June 9th and nobody fixing it.


Deopt Underscore methods that use arguments

To prevent issues like #3810, we can test each underscore method for the presence of arguments. If found, we explicitly deoptimize the wrapping method, so that the call arguments exactly match the wrapper's.

:-1: this is a sledgehammer solution to a minor (and currently non-existent) problem. I don't like the precedence merging this would set.

Two thumbs down so far. Root issues is fixed, so I'm fine with leaving this one alone.


Breaking changes  by adding optional parameters

We are continuously addressing and improving the SDK, if possible, make sure the problem persist in the latest SDK version.

Describe the bug
I'm not sure if this constitutes a bug or not, but somewhere along the line this commit was released ae5a60b8f482d7538bc305d91acf80d439eb0f33 which can cause issues.
To Reproduce
In my code (referencing the latest Microsoft.Azure.Cosmos package, 3.23.0) i reference another nuget dll Spinit.CosmosDb which has an older reference to Microsoft.Azure.Cosmos 3.8.0. The Spinit.CosmosDb package has code that calls the ContainerBuilder.CreateIfNotExistsAsync(int? throughput = null) method. This method have however changed by adding an extra optional parameter which breaks in runtime when calling it through Spinit.CosmosDb, i get a System.MissingMethodException : Method not found: 'System.Threading.Tasks.Task1<Microsoft.Azure.Cosmos.ContainerResponse> Microsoft.Azure.Cosmos.Fluent.ContainerBuilder.CreateIfNotExistsAsync(System.Nullable1<Int32>)' exception
Expected behavior
I would expect to not get an exception :-)
Actual behavior
MethodMissing exception
Environment summary
SDK Version: net6.0
OS Version: Windows
Additional context
Im not completely sure about what this constitutes SemVer-wise but i would think that this is a breaking change that maybe should have been a major version?

Not sure I understand, the referenced commit adds a new overload with different parameter types. Is Spinit.CosmosDb calling the method with null? Through Reflection? Otherwise, if they are passing an int, the cancellationToken variable should just default to the default value, right?

As far as i understand, and i'm surely no expert, this can be a breaking change when adding optional parameters rather than new method overloads. This article gives a better explanation than i can give: https://haacked.com/archive/2010/08/10/versioning-issues-with-optional-arguments.aspx
The Spinit.CosmosDb calls the method with (int?) null as a parameter by the way.

@carl-berg thanks for sharing. We will keep it forward with new API changes forwards.
To unblock for now can Spinit rebase to the latest version?

@kirankumarkolli, sounds good!
We have released a new version targeting a newer package that solves the problem we had


I get an error when running telegram-messages-dump

I'm trying to run telegram-messages-dump on windows 10. I usually clone and install python. But I get the error of the image when running the telegram-messages-dump command.
Any ideas of what I may be doing wrong, or is it an issue with windows?

Hi @mpgigat,
The error on the screenshot happens because you are running the tool on Python 2.7.
Instead, you should run telegram-messages-dump  on the latest stable version of Python 3.x.

thanks


Privacy Policy

What's the TrueDarkMode privacy policy?  Found no mention of it anywhere here or on your website.
Is there any data collected?  Is so, what data is collected and who is it shared with?

Sorry about the delay to answer.
No data is collected and I do need to add one privacy policy. Will put it on the roadmap for early 2019.
thansk for the feedback and for the question


Adding functionality for issue #43 and enhancing print method

2 Changes:

Allowing user to select specific device to run adb_android.shell() command and options
Cleaned up output of adb_android.devices() -> outputs into a list

Why does travis-ci build keep failing?


Force actualisation of artwork and title

Hi i'm looking in how i can force every X seconds the actualisation of the artwork and title
Thans for giving me some hints how i can do it
Have a great day

Hey @TomAvecLeVdsl
I think you will have to make the change in the FRadioPlayer.swift file, and add a Timer to handle the refresh, for example 10 sec:
let artworkRefreshTimer = Timer.scheduledTimer(timeInterval: TimeInterval(10), target: self, selector: #selector(refreshArtwork), userInfo: nil, repeats: true)

@objc func refreshArtwork() {
    timedMetadataDidChange(rawValue: playerItem?.timedMetadata?.first?.value as? String)
}

Ok, thanks for the info, have a great day :)


Add to basket inits 3 times

I have a problem with add to basket functionality.
I've built a project based on this demo repo and encountered a bug that after full page loading add to basket button has 3 event listeners:

So, by clicking on the button request is sent 3 times:

It can be reproduced via link: https://contentful-gatsby-demo-no.netlify.com/en-us/hats/grey-knit-beanie-with-pink-logo
Or go to the any other product at https://contentful-gatsby-demo-no.netlify.com/ Make sure you have reloaded a page before checking add to basket, so page are loaded fully from beginning, however when you navigating to the page through the site without full reloading, only one event listener is attached

thanks for you reply in advance, I'm really looking forward to it!

Hi @SergiiBondarchuk, thanks so much! I found the problem and I will fix it. Now we are also making the new react-components 😉 Stay tuned!
Have a beautiful day!


crcpp: <IP_ADDRESS> -> <IP_ADDRESS>

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://github.com/d-bahr/CRCpp/releases.
meta.description for crcpp is: "Easy to use and fast C++ CRC library"
meta.homepage for crcpp is: "https://github.com/d-bahr/CRCpp"
meta.changelog for crcpp is: ""
Updates performed

Version update

To inspect upstream changes

Release on GitHub

Compare changes on GitHub

Impact

Checks done (click to expand)

built on NixOS

The tests defined in passthru.tests, if any, passed

0 of 0 passed binary check by having a zero exit code.

0 of 0 passed binary check by having the new version present in output.

found <IP_ADDRESS> with grep in /nix/store/4dw5phan78czzkcc7q7592ij407p52cx-crcpp-<IP_ADDRESS>

directory tree listing: https://gist.github.com/537ebff94007c3000d3b1969a9fe9308

du listing: https://gist.github.com/91caa1de8fc9307d9c50ce076b9923c3

Rebuild report (if merged into master) (click to expand)

4 total rebuild path(s)

1 package rebuild(s)

1 x86_64-linux rebuild(s)
1 i686-linux rebuild(s)
1 x86_64-darwin rebuild(s)
1 aarch64-linux rebuild(s)

First fifty rebuilds by attrpath
crcpp

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/4dw5phan78czzkcc7q7592ij407p52cx-crcpp-<IP_ADDRESS> \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A crcpp https://github.com/r-ryantm/nixpkgs/archive/4877b08403ecf84f2bf9e2271794bbdb08cadffb.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/4dw5phan78czzkcc7q7592ij407p52cx-crcpp-<IP_ADDRESS>
ls -la /nix/store/4dw5phan78czzkcc7q7592ij407p52cx-crcpp-<IP_ADDRESS>/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

1 package built:

crcpp

Maintainer pings
cc @IvarWithoutBones for testing.

Result of nixpkgs-review pr 116842 at 4877b084 run on aarch64-linux 1

1 package built successfully:

crcpp

1 suggestion:

warning: missing-phase-hooks
installPhase should probably contain runHook preInstall and runHook postInstall.
Near pkgs/development/libraries/crcpp/default.nix:18:3:
   |
18 |   installPhase = ''
   |   ^


AB#7647: Omit CH image transforms when saving in Experience Editor

It works but would like to find a way to override the "base.Process" in order to cut down on copying and pasting the entire processor.


[ContextMenu][DropdownMenu] Fix sticky submenu trigger focus

See https://github.com/radix-ui/primitives/pull/682#issuecomment-854983610
This change resolves stuck focus when quickly leaving submenu triggers, the behaviour now matches that of normal items by simply refocusing content.

Closing as the changes we intend to make for pointer intent should supersede.


Build logs should save branch name that was used during the build instead of showing the current branch

I created an app and used the branch main.
But then I changed the branch to debug, so I looked at the build logs and saw that the name of the branch on the log was also updated.

Those should all be main and only the next build should show debug.

It will be fixed in the next version. Old build logs will show the wrong branch, but the new ones will be correct.


Add DAX pixel to cookie policy

Trello card
https://trello.com/c/IUIXxtwX
Context
Request from advertising team to add DAX pixel to the site.

@martyn-w Can you give this a quick 2i so we can merge it on the 2 Jan? Thanks!


Extra return statements required by LLVM

I've been exploring LLVM much more so I have better understanding of BasicBlocks and terminators. In my opinion, both of these should be valid Ark code, but neither currently compile to valid LLVM bitcode because both are missing terminators at the end of the function:
func main(): int {
    mut x: int = 5;
    if x == 5 {
        return 0;
    } else {
        return 1;
    }
}

func main(): int {
    mut i := 0;

    for i < 5 {
        return 0;
    }
}

Logically, there doesn't need to be an explicit return at the end of the function.
This may be easily corrected using the transform optimization -mergereturn, which is actually UnifyFunctionExitNodes, but I'm not sure yet.

Interesting, I too encountered this problem. I didn't know about the transform pass you were talking about, so I did it the old fashion way by basically going through the AST and verifying that all code paths have a return, and that they return the right type -- it's not too difficult, actually.


Basic notifications

Can add and clear notifications all using the mantine notifications system! The first notification in the example below disappears because it is set to auto-close after some time.
https://github.com/nerfstudio-project/viser/assets/42229107/9a080da8-1751-4392-9bd5-fcf794d54fd4
(Currently I'm a bit unsure on the design in accordance with the rest of the gui api.)

I think add_notification being in the gui api seems reasonable, but the clear_notification part kind of breaks the harmony of the rest of the api. There is probably a cleaner way to organize it, especially if there are future notification features.

Should be good to go now!

For clear_notifications, can we remove them on a per-message basis, Instead of having a global clear? (https://v4.mantine.dev/others/notifications/#functions)
E.g., we can track the message ID and do the following:
case "AddNotificationMessage": {
  notifications.show({
    id: message.id,
    ...
    });
  return;
}

// Clear all notifications.
case "ClearNotificationMessage": {
  notifications.hide(message.id);
  return;
}

... but this would require us to send messages from the GuiNotificationHandle. To this point, I was wondering if we could do:
@dataclasses.dataclass
class GuiNotificationHandle:
    """Handle for a notification in our visualizer."""

    id: str
    ...
    _send_msg_fn: Callable[[Message], None]

    def open(self) -> None:
        self._send_msg_fn(...

and set _send_msg_fn to self._websock_interface.queue_message.

Also curious about people's thoughts, but I feel like the mantine notifications control (autoClose seconds, loading, ) are quite low-level.
Mainly, I can only think of 3 notif types:

disappear both automatically (after 5 seconds) and manually (via click)
can be closed only manually
can be closed only programmatically, via some handle.close()

(and showing loading only makes sense for (3), assuming some "task" is blocking the notification from closing)

Also curious about people's thoughts, but I feel like the mantine notifications control (autoClose seconds, loading, ) are quite low-level.
I was also thinking about this but was kind of unsure about how to separate them, so thank you for your breakdown of the notif types! I think the abstraction makes a lot of sense and is easy to change.

(changing this pr to draft for now and also realizing that I didn't add docs yet)

Added some different types of notifications as per suggested! Can be indicated via type when declaring a notif.

"persistent" (default): user close
"timed": auto close
"controlled": code close

loading is just an additional optional argument.
I also added an individual notification clear option along with the global clear (can be renamed 'close' for clarity if needed). It has a bit of funky behavior if you open the same notification too many times and just clears all of it, but I actually don't think it's a huge issue irl use cases for now.
Still didn't add docs yet but can easily do so in the end after all design is finalized!
https://github.com/nerfstudio-project/viser/assets/42229107/5196024c-eb8a-467a-8669-85e9d46fb649

I noticed a problem with multiple clients: unless all the notifications are explicitly cleared in the backend (gui.clear_all_notification or notif.clear()), when another client connects, all the notifications will be reopened in the new client's session. This happens to both timed notifications that are auto-closed as well as the manually closed notifications. The notifications that are code-closed as mentioned earlier, will not reopen. So it looks like we need to explicitly close all the notifications in the backend regardless.

when another client connects or when you reload the window, all the notifications will be reopened. This happens to both timed notifications that are auto-closed as well as the manually closed notifications.

This seems like the result of some viser state management logic, particularly the concept of "persistent" messages, see:
https://github.com/nerfstudio-project/viser/blob/d56be1ad1602739594cb30307cd61599a696d588/src/viser/infra/_infra.py#L244-L246
as well as references to the redundancy_key() method: https://github.com/search?q=repo%3Anerfstudio-project%2Fviser redundancy_key&type=code
This is usually nice, since when we make scene or GUI updates we want them to take effect even for new clients, but it does complicate the notification logic. It shouldn't be too hard to fix, but we'd need to figure out what the expected behavior is:

if we broadcast a notification, then a new client connects, should the new client receive the notification at all?
if we broadcast a notification that autocloses in 5 seconds, then a new client connects 1 second later, is the notification shown for 4 seconds or 5 seconds?
if a notification is closed from one client, does it get closed in the others as well?
etc

Actually, would it be possible to disable the automatic synchronization between clients? Make it an opt-in feature (not default)? What do you think?

Actually, would it be possible to disable the automatic synchronization between clients?

Do you mean for everything, including both GUI elements and scene elements?
Disabling synchronization seems hard without some API changes. Notably, attributes like .value currently make sense to read when we know that they should be consistent across all clients:
text_handle = server.gui.add_text("Some text input")

while True:
    print(text_handle.value)  # Makes sense because all clients have the same value for this input.
    time.sleep(1.0)

But things become more complicated if different clients can have different values for the text input. To support this use case we do support creating separate handles for each client though, eg via client.gui.add_text().

if we broadcast a notification, then a new client connects, should the new client receive the notification at all?

I imagine in some cases, notifications would be client-specific (e.g. rendering a video, downloading things, etc), so a new client should not receive the same set of notifications. But  I can also think of some cases where everybody should receive all the notifs (e.g. training complete). Mostly speaking from a nerfstudio pov.
Does this mean that all connected clients would always receive all the broadcasted notifications though? I guess this question applies to the other things to consider. I feel like there are these two types of notifications in terms of broadcasting (global or client-specific). But I'm unsure if making this distinction between the two types of notifications will make it inconvenient for users and if client-specific messages are even possible.

I guess this question applies to the other things to consider. I feel like there are these two types of notifications in terms of broadcasting (global or client-specific). But I'm unsure if making this distinction between the two types of notifications will make it inconvenient for users and if client-specific messages are even possible.

I think this should be already supported actually, if you call client.gui.add_notification then the notification will only go to a single client. If you want to test you can get the client handle from the GUI callback like in this example: https://viser.studio/latest/examples/19_get_renders/

Ok that makes sense, for client notifications! Then I think the behavior for global broadcasting of notifications should be:

if we broadcast a notification, then a new client connects, should the new client receive the notification at all?

Yes, since the broadcasted notification isn't client specific then everybody should probably receive it.

if we broadcast a notification that autocloses in 5 seconds, then a new client connects 1 second later, is the notification shown for 4 seconds or 5 seconds?

I don't feel super strongly about this. I do think having the full temporary display of notification makes slightly more sense for users, so somebody doesn't get stuck with a 0.5 second notification that immediately disappears. But whatever makes the implementation cleaner I'm ok with.

if a notification is closed from one client, does it get closed in the others as well?

I don't think so, I think clients should control their own notification queue.
Let me know if you have any thoughts.


suggestion: ignore trashed/archived lists during config

Hi,
It would be great to reduce configuration clutter by skipping archived(/trashed) lists. (probable code pointer)
Perhaps with a toggle just in case you're using this integration as a backup towards archived lists
Thanks for considering!

Yes, seems like a reasonable change. Definitely shouldn't be showing lists that are in the trash. Not sure if anyone has a use-case for selecting archived lists.
I'm inclined to change it so it only shows unarchived/untrashed lists for selection by default. I'll see if I can get code in to fix this before the next version.

Fixed in the latest release, 0.9.8


upload hasMany - error on selecting multiple images from existing media collection

Link to reproduction
No response
Environment Info
Next.js (15.0.0-canary.132)
Payload 3 beta.94

Describe the Bug
{
name: 'gallery',
type: 'upload',
relationTo: 'media',
hasMany: true,
required: true,
},
error on select multiple images from existing images
Error msg: TypeError: Cannot read properties of undefined (reading 'id')

Reproduction Steps
New collection with upload relation and hasMany:
import type { CollectionConfig } from 'payload'
export const Test: CollectionConfig = {
slug: 'test',
fields: [
{
name: 'title',
type: 'text',
required: true,
},
{
name: 'gallery',
type: 'upload',
relationTo: 'media',
hasMany: true,
required: true,
},
],
}
Error on selecting multiple images
Adapters and Plugins
No response

Hi @l0st0 I haven't been able to reproduce this. Are you able to provide a reproduction repo please?

Hey @paulpopus :) https://github.com/garazstav/garazstav

Thanks, fixed in https://github.com/payloadcms/payload/pull/7976

After the fix now I have the following error:
This relationship field has the following invalid relationships: 766 0, 767 1
when trying to choose images from existing


Create examples and tests v2

More examples and tests plus minor refactorings

Let me know what you think...

If you agree with the changes let's merge it.


OS X: will not run from Downloads or Desktop folder

The app has to be moved to the Applications folder before it can run successfully. It would nice if I could just run it from the Downloads folder so I could delete it after I am done running it.
Steps to reproduce

Download and extract PiFinder-3.0.0-osx-x64.zip.
Run PiFinder.app from the Downloads folder.

Expected Results
Pi Finder opens and displays the IP Addresses of the Raspberry Pi devices on my network.
Actual Results

Dialog box appears:

ERROR
Pi Finder auto update failed! Are you connected to the internet?

Clicking the "OK" button results in the dialog box closing.
PiFinder appears to be running (as indicated by the "Adafruit Pi Finder" menu at the top of the screen.
However no new window appears, and the only option in that menu is "Quit".
Right clicking on the PiFinder icon in the dock and choosing "Show all windows" yields a message on the desktop stating "No available windows".

Solution

Move PiFinder.app to the Applications folder before running.

My system
Mac (Retina 5K, 27-inch, 2017)
OS X 10.13 "High Sierra"

Thanks! That fixed the issue! Maybe we should see why it wouldn't work without the move to /Applications...
Thanks,
Sid.

FWIW I just got the same error on Catalina 10.15.2 .. but moving it to /Applications hasn't helped much apart from getting rid of the "are you connected to the internet" message, now it launches but the app window doesn't appear. To be honest I'm not sure whether it'd work anyway due to the funky network restrictions we have here at the office, but it'd be nice to at least see a window that says it can't find a PI..

Thanks this worked on BigSur, I was trying everything to get rid of this error:
Pi Finder auto update failed! Are you connected to the internet?
Moving the application to my applications folder fixed it!


Add disk buffering config options to RUM conf

Currently iOS and android have different config options for enabling and configuring disk buffering.
Android
enableDiskBuffering
limitDiskUsageMegabytes
iOS
enableDiskCache
spanDiskCacheMaxSize
Also react native needs to use the same conf. After discussions it seems "buffering" makes more sense so let's use android version. Not sure where to put mobile only conf options put them into the same table.

I have read the CLA Document and I hereby sign the CLA

@signalf/gdi-ios-maintainers, FYI

@signalfx/gdi-ios-maintainers, FYI


Documentation layout and examples.

Hello!
I'm checking the link in the README.md which is https://docs.makotemplates.org/en/latest/usage.html. It looks like the API Reference side bar overflows.

Another thing is the code in the usage does not work for Python3.

There is already a discussion in https://github.com/sqlalchemy/mako/issues/234 about fixing it, basically changing StringIO to io
I can take a look at these issues, but I want to make sure that I didn't miss something.

these are going to be a little mroe difficult than usual to fix since you'd need to fix them over in Mako's sphinx extension at https://github.com/sqlalchemyorg/zzzeeksphinx/ .    For some indication of what changed in general see https://github.com/sqlalchemy/alembic/commit/edd64ea2a322049a4a536c1a9ae8e498db73be23 and https://github.com/sphinx-doc/sphinx/issues/11000

Okay, but the example should be fixed here right? Since it's part of the content.
Looking at the alembic solution, I assume you prefer to adjust the width?

oh there's an import in there too, sure that should be fixed as well, thanks!

for the CSS it's a small width adjust and also an "overflow:auto" so that it can scroll.

this is fixed


add favicon link path

Small fix for proper display your beautiful favicon in docs ;)

Isn't that just the default Astro favicon?

Thanks!

I don't mind having the default one for now, but I think I should make a custom one


#Requires -Edition (Desktop | Core)

Dear team,
please consider adding #Requires -Edition (Desktop | Core) statement for scripts that are not compatible with Core and still requires Desktop version to run.
It would be great to write
#Requires -Edition Desktop

instead of
if($PSVersionTable.PSEdition -eq 'Core')
{
    throw "Doesn't work with PowerShell Core. Please use Windows PowerShell."
}

Is this already in PowerShell? I found this documentation, and this check in the PowerShell source.

I've opened an RFC on updating the behaviour of #requires. Please feel free to comment in the PR.

Trying to figure out what #requires extensions would be meaningful, it came to me, what an additional statement could be also usefull: #testedon (or #testedfor, or just #tested).
To give you some context: my main non-Windows OS distribution is CentOS, so I'm writing scripts with CentOS-specific nuances. I wrote some scripts with Debian/Ubuntu compatibility in mind (httpd vs apache, for example), but they never been tested on it on any meaningfull extent.
While #requires prohibits running on not supported environment, the best part in it is what it could be analyzed even without running the script.
So, #tested could be used as indication if current environment is tested one for execution (maybe we will have some Test-ScriptCompatibility cmdlet someday?), without even running script.
Also PS engine could emit warning/verbose/debug message, if current environment is not supported, warning user about possible incompatibilites.
I would like to hear your opinion on this idea (especially @dronkoff), so if it is as good as I imagine - I will create separate thread for a more broad discussion.

This would be useful for something like AWS Lamda to parse out which powershell the script should be run with.

PowerShell Core (and Windows PowerShell) already support this actual feature.
#requires -PSEdition Core

Write-Output 'Hello'

See this comment as well: https://github.com/PowerShell/PowerShell/issues/5908#issuecomment-375543426
I'm guessing I left the issue open for discussion before, but closing now since the ask has been in PowerShell for a while.

@gabriel-vanca you'd need -PSEdition not `-Edition
This works for me as a simple repro in a file called req.ps1
#requires -PSEdition Desktop
param()
$PSEdition


Remove docker, docker-compose and vagrant files (#3752)

Pull request opened by the merge tool on behalf of #3752

Merged into branches iso4 in 777b6ae708dc2bf663e2817a66351e0adeaccba2


Badge "Proud sponsor of Open Source"

It would be good to have a small badge that companies can put in the footer of their website that says "Proud sponsor of Open Source", or "We are contributing to Open Source Collectives" (something along those lines), that would link to their company profile page on OpenCollective.

The cool thing would be that their profile page on open collective would not only show the open source projects that they sponsor but also the ones they contribute to (which means that we need to find a way to pull the data of who are the people who belong to the organization)

Closing this: see opencollective.com/widgets.


Finish tests for run above/below

The test for run below passes locally, but is flakey on github. (It times out)
The test for run above needs a way to select any cell other than the first one with code. (Try updating the proposed api)

Validated

Validated


Support for attrs type declarations within attr.ib() method

Although Pylance currently supports type annotations within as such declarations
@attr.s(slots=True)
class Person:
    name: str = attr.ib(default=None)
    surname: str = attr.ib(default=None)

It would be extremely useful to support the type annotations passed as parameter arguments i.e.
name = attr.ib(type=str, default=None). This is currently supported by PyCharm and since the existing project structure is built using this format,  we constantly get unrecognised construction parameter errors which we have to just ignore. Would be 🚀 feature to cover this within pylance.

Thanks for the suggestion, we don't support this because Pylance is built on Pyright, which is a standards-based type checker, and it does not embed specialized knowledge of third-party libraries like attrs. There is currently no way to specify the behavior of the attr.ib in the Python type system. The recommended approach is to use type annotations for fields rather than using the non-standard type parameter. The former is also fully supported by attrs and will work fine with Pylance.


New API routes added

Fix to Issue #4387
New API routes added
GET api/v1/admin/users/{username}/orgs
GET api/v1/admin/orgs
GET api/v1/admin/users

@lunny I have implemented the new routes as proposed by @cleverer in #4387

@lafriks I have added the appropriate comments. But the DronCI build still tends to fail the error states that I have to commit the files after executing make generate-swagger but this I have already done and have commit the files but am still receiving the same error. Could you help me with this? Thanks.

Codecov Report

Merging #5594 into master will decrease coverage by 0.05%.
The diff coverage is 5.26%.

@@            Coverage Diff            @@
##           master   #5594      +/-   ##
=========================================
- Coverage   37.56%   37.5%   -0.06%
=========================================
  Files         321     321
  Lines       47206   47263      +57
=========================================
- Hits        17731   17727       -4
- Misses      26929   26990      +61
  Partials     2546    2546

Impacted Files
Coverage Δ

models/user.go
45.6% <0%> (-0.36%)
:arrow_down:

routers/api/v1/admin/org.go
0% <0%> (ø)
:arrow_up:

routers/api/v1/admin/user.go
22.47% <0%> (-1.92%)
:arrow_down:

routers/api/v1/api.go
73.55% <100%> (+0.15%)
:arrow_up:

models/unit.go
0% <0%> (-14.29%)
:arrow_down:

modules/process/manager.go
76.81% <0%> (-4.35%)
:arrow_down:

models/repo_list.go
63.29% <0%> (-1.27%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4586ae3...734ef82. Read the comment docs.

@lafriks I have fixed it.

@kolaente I have made the changes.

@lafriks I have made the changes.

@lafriks Is there anything left to be fixed in this PR?


Auto Handling of Sign-out in Firebase Auth for all Providers

Firebase Auth should handle sign-out from each network (Google, Facebook..) automatically instead of user calling sign-out methods individually for each network.
For example, currently we should call _googleSignIn.signOut() to avoid silent re-login after the user is signed-out from Firebase. This should be taken care of the package automatically.

For google:
GoogleSignIn.channel.invokeMethod("signOut");

It's really difficult to develop an app which support multiple social login providers. This unified feature is much needed to make use of Firebase social login.

@Purus
This issue has been moved to https://github.com/FirebaseExtended/flutterfire/issues/891. Any further collaboration will be done there.


Use created time from metadata store to list multiple active tasks

Description
The web-console of getTasks API can return incorrect created times and durations afte the Overlord restarts. This is because we populate the field with the time at which the task was added to the TaskRunner for active tasks.
Fix
The method now uses the created_date field from the metadata store as should have been the case for all tasks. No additional calls have been added.
This PR has:

[x] been self-reviewed.

[ ] using the concurrency checklist (Remove this item if the PR doesn't have any relation to concurrency.)

[ ] added documentation for new or modified features or behaviors.
[ ] a release note entry in the PR description.
[ ] added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links.
[ ] added or updated version, license, or notice information in licenses.yaml
[ ] added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
[ ] added unit tests or modified existing tests to cover new code paths, ensuring the threshold for code coverage is met.
[ ] added integration tests.
[x] been tested in a test Druid cluster.

Thank you for the review @kfaraz!
Merged as the failing checks were unrelated.


Disallow returning values from Promise executor functions (no-promise-executor-return)

https://eslint.org/docs/rules/no-promise-executor-return
The new Promise constructor accepts a single argument, called an executor.
const myPromise = new Promise(function executor(resolve, reject) {
    readFile('foo.txt', function(err, result) {
        if (err) {
            reject(err);
        } else {
            resolve(result);
        }
    });
});

The executor function usually initiates some asynchronous operation. Once it is finished, the executor should call resolve with the result, or reject if an error occurred.
The return value of the executor is ignored. Returning a value from an executor function is a possible error because the returned value cannot be used and it doesn't affect the promise in any way.
Rule Details
This rule disallows returning values from Promise executor functions.
Only return without a value is allowed, as it's a control flow statement.
Examples of incorrect code for this rule:
/*eslint no-promise-executor-return: "error"*/

new Promise((resolve, reject) => {
    if (someCondition) {
        return defaultResult;
    }
    getSomething((err, result) => {
        if (err) {
            reject(err);
        } else {
            resolve(result);
        }
    });
});

new Promise((resolve, reject) => getSomething((err, data) => {
    if (err) {
        reject(err);
    } else {
        resolve(data);
    }
}));

new Promise(() => {
    return 1;
});

Examples of correct code for this rule:
/*eslint no-promise-executor-return: "error"*/

new Promise((resolve, reject) => {
    if (someCondition) {
        resolve(defaultResult);
        return;
    }
    getSomething((err, result) => {
        if (err) {
            reject(err);
        } else {
            resolve(result);
        }
    });
});

new Promise((resolve, reject) => {
    getSomething((err, data) => {
        if (err) {
            reject(err);
        } else {
            resolve(data);
        }
    });
});

Promise.resolve(1);

5 ecosystem failures:
1..216
# tests 216
# pass  211
# fail  5

Some code is improved by removed the extra return statement, like these:
      var test = new Runnable('promise', function () {
        return new Promise(function (resolve, reject) {
          return setTimeout(function () {
            return reject(new Error('You promised me'))
          }, 0)
        })
      })

  return new Promise(resolve => {
    return fs.exists(filename, resolve)
  })

Other cases, like for one-line arrow functions, I wish we could ignore:
const delay = (time) => new Promise((resolve) => setTimeout(resolve, time))

        await new Promise((resolve) => queue.push({ resolve }))

const sleep = ms => new Promise(resolve => setTimeout(resolve, ms))

I'd like to include this rule, since I think that returning from the promise executor function is a likely error or at the very least confusing, but I don't think we can do it unless there's an option to ignore single-line arrow functions.
Would someone like to champion adding an option to this rule with the ESLint team?


clean up material diagram

remove cross-theme links at toplevel
remove sections from top level
add cross-course links at course level

we've removed the diagram at top level, so just need to make sure we've got cross-course links at course level


Add screenshots of the project in the README

I think it's better to add screenshots of the project, so they know what the project looks like.

I think this issue isn't needed now.


Album button not showing on ios 13.x

Hello,
I have problem with album button... Works on ios 14.x, but not on ios 13.x. This is my code:
let imagePicker = ImagePickerController()
imagePicker.settings.fetch.assets.supportedMediaTypes = [.image, .video]
imagePicker.settings.selection.max = 10
imagePicker.settings.selection.unselectOnReachingMax = false
let options = imagePicker.settings.fetch.album.options
imagePicker.settings.fetch.album.fetchResults = [PHAssetCollection.fetchAssetCollections(with: .smartAlbum, subtype: .smartAlbumUserLibrary, options: options), PHAssetCollection.fetchAssetCollections(with: .album, subtype: .albumRegular, options: options)]
What could be the problem?
Thanks

It is only visible if there actually is multiple albums/collections on the device.
Could it be that you only have 1 on the iOS 13 device?

It is only visible if there actually is multiple albums/collections on the device.
Could it be that you only have 1 on the iOS 13 device?

Yes,thats right... I just test it...
Problem solved...
Thank you very much :)

Yes,thats right... I just test it...
Problem solved...
Thank you very much :)

I did something similar but with
"multiImgPicker.settings.fetch.album.fetchResults = [PHAssetCollection.fetchAssetCollections(with: .smartAlbum, subtype: .any, options: options)]"
But it does not display the album button either. I do have images in my smart albums like "favorite" and the fetch returns a count of 14 albums.
could you provide some guide on what else to try?


Can't add items to category with ID which is bigger or equal to 10

How to reproduce:

Create category with name and id which is 10 or higher
Try to add snippet
You will get message, that category with ID 10+ does not exist.

Can't reproduce this.


Uninstallation / Removal of inserted markers into the DB

Firstly, I wanted to say a massive thank you to you for creating this project. Like many others have experienced, this has been an amazing stop gap in the plex product offering until plex added this natively themselves, and I cannot thank you enough for that - countless hours must have gone into developing and fine tuning this for the community <3
I wanted to open a discussion around the best way to go about uninstalling plex-credits-detect, specially around how to remove the markers that were added to the DB. Im not sure if they might conflict with the new credit markers that plex will be adding in, or if they can live side by side with each other?
FWIW, I am running plex-credits-detect through your docker image, cjmanca/plex-credits-detect:main
Any guidance you can provide would be greatly appreciated!

This shouldn't be necessary. Every time Plex modifies the markers, it replaces all existing markers for that season. So when it adds it's own credit markers, it'll naturally remove the ones that this tool added when doing so.

I have some old shows that still have "Skip Intro" at the end and doesn't transition to the smaller window and show next episode like the new built in skip credits feature. Is there anyway of fixing this as Plex's own detection hasn't overridden yours as mentioned above

All the shows which have been detected as a credits section by plex for me have overwritten my markers with theirs so far in my database.
There are a couple of reasons I can think of as to why it may not have for you:

Plex hasn't gotten around to detecting credits for that show. I'm sure it'll take weeks or months for most decent sized libraries to be fully scanned.
Plex's credits detection didn't find any credits, so it didn't replace the credit markers.


[WIP] Remove IIS settings to always host ASP.Net Core apps as consoles

Marking as WIP, since running the website currently results in

Newtonsoft.Json.JsonSerializationException: Cannot deserialize the current JSON object (e.g. {"name":"value"}) into type 'System.Dynamic.ExpandoObject[]' because the type requires a JSON array (e.g. [1,2,3]) to deserialize correctly.
To fix this error either change the JSON to a JSON array (e.g. [1,2,3]) or change the deserialized type so that it is a normal .NET type (e.g. not a primitive type like integer, not a collection type like an array or List) that can be deserialized from a JSON object. JsonObjectAttribute can also be added to the type to force it to deserialize from a JSON object.`
Path 'message', line 1, position 11.

   at Newtonsoft.Json.Serialization.JsonSerializerInternalReader.CreateObject(JsonReader reader, Type objectType, JsonContract contract, JsonProperty member, JsonContainerContract containerContract, JsonProperty containerMember, Object existingValue)
   at Newtonsoft.Json.Serialization.JsonSerializerInternalReader.Deserialize(JsonReader reader, Type objectType, Boolean checkAdditionalContent)
   at Newtonsoft.Json.JsonSerializer.DeserializeInternal(JsonReader reader, Type objectType)
   at Newtonsoft.Json.JsonConvert.DeserializeObject(String value, Type type, JsonSerializerSettings settings)
   at Newtonsoft.Json.JsonConvert.DeserializeObject[T](String value, JsonSerializerSettings settings)
   at ITOps.Json.HttpContentExtensions.d__1.MoveNext() in C:\code\Particular\Workshop.Microservices\demos\asp-net-core\ITOps.Json\HttpContentExtensions.cs:line 14
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at System.Runtime.CompilerServices.ConfiguredTaskAwaitable`1.ConfiguredTaskAwaiter.GetResult()
   at Divergent.Shipping.ViewModelComposition.OrdersLoadedSubscriber.<>c.<b__1_0>d.MoveNext() in C:\code\Particular\Workshop.Microservices\demos\asp-net-core\Divergent.Shipping.ViewModelComposition\OrdersLoadedSubscriber.cs:line 37
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at CallSite.Target(Closure , CallSite , Object )
   at CallSite.Target(Closure , CallSite , Object )
   at Divergent.Sales.ViewModelComposition.OrdersListViewModelAppender.d__1.MoveNext() in C:\code\Particular\Workshop.Microservices\demos\asp-net-core\Divergent.Sales.ViewModelComposition\OrdersListViewModelAppender.cs:line 42
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at System.Runtime.CompilerServices.TaskAwaiter.GetResult()
   at ITOps.ViewModelComposition.CompositionHandler.d__0.MoveNext() in C:\code\Particular\Workshop.Microservices\demos\asp-net-core\ITOps.ViewModelComposition\CompositionHandler.cs:line 45
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at System.Runtime.CompilerServices.TaskAwaiter`1.GetResult()
   at ITOps.ViewModelComposition.Mvc.CompositionActionFilter.d__0.MoveNext() in C:\code\Particular\Workshop.Microservices\demos\asp-net-core\ITOps.ViewModelComposition.Mvc\CompositionActionFilter.cs:line 15
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at Microsoft.AspNetCore.Mvc.Internal.ControllerActionInvoker.d__28.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at Microsoft.AspNetCore.Mvc.Internal.ControllerActionInvoker.Rethrow(ResultExecutedContext context)
   at Microsoft.AspNetCore.Mvc.Internal.ControllerActionInvoker.Next(State& next, Scope& scope, Object& state, Boolean& isCompleted)
   at Microsoft.AspNetCore.Mvc.Internal.ControllerActionInvoker.d__22.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at Microsoft.AspNetCore.Mvc.Internal.ControllerActionInvoker.Rethrow(ResourceExecutedContext context)
   at Microsoft.AspNetCore.Mvc.Internal.ControllerActionInvoker.Next(State& next, Scope& scope, Object& state, Boolean& isCompleted)
   at Microsoft.AspNetCore.Mvc.Internal.ControllerActionInvoker.d__20.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at Microsoft.AspNetCore.Builder.RouterMiddleware.d__4.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at Microsoft.AspNetCore.Diagnostics.DeveloperExceptionPageMiddleware.d__7.MoveNext()

rebased on master. git clean -fxd. Run, works fine. Can you try once more?


Fix help command to display the correct URL

Fixes #144. Updated the URL shown by the help command to the URL of TutorMaster's user guide.

Codecov Report

Merging #204 (4c8d5c1) into master (9aaf647) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master     #204   +/-   ##
=========================================
  Coverage     56.14%   56.14%
  Complexity      728      728
=========================================
  Files           158      158
  Lines          3147     3147
  Branches        345      345
=========================================
  Hits           1767     1767
  Misses         1263     1263
  Partials        117      117

Impacted Files
Coverage Δ

src/main/java/seedu/address/ui/HelpWindow.java
0.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9aaf647...4c8d5c1. Read the comment docs.


passProps seem doesn't work

I call this.props.navigator.push to the next scene, and pass some props to the next scene, and caught an error, the passed prop is undefined in the next view,it seems passProps doesn't work,and code is below:
/**
 * Sample React Native App
 * https://github.com/facebook/react-native
 */
'use strict';

var React = require('react-native');
var Product = require('./product');
var Adapt = require('./adapt');

var mdskip = require('./data/mock-mdskip');
var context = require('./data/mock-context');
var NavigationBar = require('react-native-navbar');

var Detail = require("./ui/detail");
var styles = require("./ui/style");
var {
  Navigator,
  NavigatorIOS,
  AppRegistry,
  View,
  Text,
  StyleSheet,
  TouchableHighlight,
  ScrollView
} = React;

var product = new Product();
product.set("context", context.ModuleDatas);
product.set("config", context.TDetail);
product.set("mdskip", Adapt.transform(mdskip));
product.set("deviceType", "phone");

var RootComponent = React.createClass({
  getInitialState: function(){
    return {};
  },
  componentDidMount: function() {
    var self = this;
  },
  renderScene: function(route, navigator) {
    var product = this.state.product;

    var Component = route.component;
    var navBar = route.navigationBar;

    if (navBar) {
      navBar = React.addons.cloneWithProps(navBar, {
        navigator: navigator,
        route: route
      });
    }

    return (
      <View style={styles.navigator}>
        {navBar}
        <Component navigator={navigator} route={route} product={product} />
      </View>
    );
  },
  render: function() {

    if(context){
      return (
        <Navigator
        style={styles.navigator}
        renderScene={this.renderScene}
        initialRoute={{
          component: Entrance,
          navigationBar: <NavigationBar
            title="Initial View"
            onNext={this.handleNext}
          />
        }}
      />
      );
    }else{
      return (
        <View></View>
      )
    }
  }
});

var Entrance = React.createClass({
  render: function(){
    return (
      <View style={styles.clickMe}>
        <TouchableHighlight onPress={this.onPress} underlayColor="#B5B5B5">
          <Text style={styles.clickMeText}>点我看详情</Text>
        </TouchableHighlight>
      </View>
    );
  },
  componentDidMount(){
    var self = this;
    product.onLoad(["context", "config", "mdskip"], function(context, config, mdskip){
      self.setState({
        "context": context,
        "config": config,
        "mdskip": mdskip
      });
    })
  },
  onPress: function(){
    var context = this.state.context;
    var config = this.state.config;
    var mdskip = this.state.mdskip;
    var product = this.props.product;

    this.props.navigator.push({
      title: context.title.itemTitle,
      component: DetailMain,
      backButtonTitle: 'Back',
      passProps: { config: config, mdskip: mdskip, product: product, context: context}
    });
  }
});

var DetailMain = React.createClass({
  getInitialState: function(){
    return {
      loading: false
    };
  },
  render: function(){
    return (
      <Detail config={this.props.config} mdskip={this.props.mdskip} product={this.props.product} context={this.props.context} navigator={this.props.navigator}/>
    )
  }
})

AppRegistry.registerComponent('DetailNative', () => RootComponent);

So, in short, you need to pass parameters to your custom components in the navbar, right? It's not implemented yet, but I think I'll try to implement it right now, good catch!

I don't want to pass parameters to my custom components in the navbar, but I want to pass to the next route.Just like the code in navigatorIOS example:
<NavigatorIOS
      initialRoute={{
        component: MyView,
        title: 'My View Title',
        passProps: { myProp: 'foo' },
      }}
    />

and
this.props.navigator.push({
              title: NavigatorIOSExample.title,
              component: NavigatorIOSExample,
              backButtonTitle: 'Custom Back',
              passProps: {topExampleRoute: this.props.topExampleRoute || this.props.route},
            });

Navigator is a more low-level thing than NavigatorIOSand it doesn't support that feature out-of-box, but it's not hard to implement. You just need to apply your custom parameters to the NavigationBar in the renderScene. Basically, it's all about re-render NavigationBar with changed props, so you can use setProps or just call render. I'll make an example for that.

I had the same problem. Look at my last comment here: https://github.com/Kureev/react-native-navbar/issues/12

So, have you solved this issue?

No,the problem is blow，I use the navigator to go to next view, but in the next view, I found all the passed props in the next view is null!!!

@iostalk Thanks for the screenshots, but the most important part is how you renderScene. Can you show me this part? Because all data you pass to Navigator will go to this function.

My render scene:
renderScene: function(route, navigator) {
    var Component = route.component;
    var navBar = route.navigationBar;
    var product = route.product;

    if (navBar) {
      navBar = React.addons.cloneWithProps(navBar, {
        navigator: navigator,
        route: route,
        product: product
      });
    }

    console.log(product);
    return (
      <View style={styles.navigator}>
        {navBar}
        <Component navigator={navigator} route={route} product={product} />
      </View>
    );
  },

  render: function() {
    return (
      <Navigator
        style={styles.navigator}
        renderScene={this.renderScene}
        initialRoute={{
          component: Entrance,
          navigationBar: <NavigationBar title="Hello~~~"/>,
          product: product
        }}
      />
    );
  }

@iostalk ok, this code is totally fine, in your Entrance component you should get access to your product thru this.props.product. Is it Entrance component on the screenshots?

I could get the passProps in the router, I figure it out!

@iostalk strange, I don't see you passing passProps in this code.

我也遇到了同样的问题，使用navigator  的时候，好像它不跟NavigatorIOS一样会传递参数，我想问下您后来是怎么解决这个问题的呢？@iostalk

那么，它（导航栏）改变了很多，因为在这里的最后一个注释。你使用哪种版本？你能为我们提供一个代码示例？@Yidada
P.S. Google translate FTW!

You are so cool for translating my words.Do you mean my react-native version? It's 0.14. and my code seems like this:
onPress:function () {
var value = this.refs.main.refs.form.getValue();
if (value) {
this.props.navigator.push({
id:'RegPhone2',
passProps: {phonNum:value}
})
}
},

I'm not quite sure, but it could be that you have a problem with your refs. If that's not the case, then I'd like to know, where do you use your passProps? I can't find anything about it neither inside official Navigator documentation nor in my API specs.

You know, In China we don't have such a good react environment. many apis or functions need to be guess...hahaha ,sorry for my not rigorous. I'll read your API specs maybe I can found my solution.😊

May be my question is just how to pass props when we use the Navigator to route my app?

Well, I can explain it! When you use <Navigator />, you're able to specify a renderScene function which will decide how to render your scene. It accepts two arguments: route and navigator. In your particular case you're interested in a route. Every time you push a new route, you can pass any extra params to it and then use it to render your component. You can take a look on example I have here. So, in this example I use Navigator's initialRoute property, which specifies the initial route in your application. It may contain any fields you want. In my case it's a component I render inside the scene. But at the same moment you can pass foo: 'bar' and use it thru the route.foo property to inject it into your component.
Hope this helped!

It's really helpful for me! I read your example and try it in my app .It works ! Thanks again!😊

@Kureev - Thanks for the explanation! Your idea on passing 'route' as a property of a component in 'renderScene' method solved my problem too. Now I am able to access 'myInfo' value (which i passed using  'passProp' while pushing new scene) in my new scene like this: 'this.props.route.passProps.myInfo'

maybe this.props.navigator.currentRoute can solve ur problems.

Solved the Problem though if pass props worked it could have been better feature request?

I solve this problem by rendering scenes  this way
<Component {...route.passProps} navigator={navigator} route={route} />

I solve this problem by rendering scenes this way
<Component {...route.passProps} navigator={navigator} route={route} />

You can also pass the prop through this.props.navigator by creating a new property if it's within the same stack of I believe.

@windhost it work for me!thanks~ 👍 👍

It seems like really an early topic from now, current RN version is 0.43, try below
this.props.navigator.push({                     component: ProfileUpdate, args: {type: 'birth'}                 })
and get params in 'ProfileUpdate' page like:
const type = this.props.type
maybe can help some guys like me :)


RFP - msedgeredirect

Checklist

[x] The package I am requesting does not already exist on https://chocolatey.org/packages;
[x] There is no open issue for this package;
[x] The issue title starts with 'RFP - ';
[x] The download URL is public and not locked behind a paywall / login;

Package Details
Software project URL :https://github.com/rcmaehl/MSEdgeRedirect
Direct download URL for the software / installer : https://github.com/rcmaehl/MSEdgeRedirect/releases/latest/download/MSEdgeRedirect.exe
Software summary / short description:
A Tool to Redirect News, Search, Widgets, Weather and More to Your Default Browser

I will pick this up.

This has already been created.


Unicode characters are not displayed in Windows console

I have a simplest program, that writes a unicode character to cout:
boost::nowide::cout << u8"Hello, \u03A8!" << std::endl;

If I stream output to a file, I see the correct answer: "Hello, Ψ!". But if I run the program in console, I see a question mark instead: "Hello, ?!". I thought than no additional manipulations with locales is needed why I use boost.nowide. Is this a bug, or should I set up something?

This answer helped: http://stackoverflow.com/a/388500/261217
It turned out I need to set console font to Lucida Console. Seems like default font just does not know how to render unicode characters.


Create a full-stack MVP

Deployable MVP:

[ ] fully materialized table of some achievements in dbt/DuckDB file
[ ] an endpoint /achievements/{id} in FastAPI that retrieves those achievements and passes the JSON
[ ] a SpectacleJS frontend that retrieves the achievement from the endpoint
[ ] a Docker Compose that runs both frontend and backend

...though in fairness, maybe we just need (and mostly have) the following:

[x] some achievement-making process in database
[x] some endpoint-serving backend
[x] an offline example of an achievement screen on frontend

Ok, mám to rozjeté bez interakce mezi back- a frontendem, ale musím přijít na to:

[ ] jak nastylovat slidy
[ ] kam nahrát background images


Automatically append ".js" when normalizing filename

    normalized.push(parts[i]);
  }

  var file = normalized.pop();
  file += file.indexOf('.js') == -1 ? '.js' : '';
  normalized.push(file);

  return normalized.join('/');

Without that karma-cajon, the fork of this project, tries to load files without any extension. Since the author of the fork did not enabled issues -- I'll leave it here.

PR https://github.com/xdamman/karma-cajon/pull/1 created

Bump!

see https://github.com/karma-runner/karma/issues/513#issuecomment-48616784


Differentiate between a short and long click?

Is there a way to differentiate between a short and long click of a button? Could someone help me with doing this? Thank you!

it's not possible... because on the keyboard there is no such difference

Also, I don't think that it is planned for the actual console. I saw ced say that in some PR or Slack thread.

it is not because there is no availability of parts and it would be more expensive, I saw Hugo talking about it


Add a quick notebook for current implementation

Add a quick notebook that walks through the current methods through #222 alongside the upcoming kriging code refactoring/debugging update.

A Jupyter notebook providing an example workflow of echopop has been added to /docs and is available/rendered when viewing the ReadTheDocs documentation page (Example workflows and analyses).
This can therefore be closed once PR #241 is merged.


Remove condition for ENABLE_SSL_FOR_WEBHOOK

Studio by default sets ENABLE_SSL_FOR_WEBHOOK for true. Our current template were skipping setting ENABLE_SSL_FOR_WEBHOOK to False, because condition were negative 🙃

Good catch!


Drop runtime requirement for NeXus on aarch64 and ppc64le

Checklist

[x] Used a personal fork of the feedstock to propose changes
[x] Bumped the build number (if the version is unchanged)
[ ] Reset the build number to 0 (if the version changed)
[x] Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[x] Ensured the license file is being packaged.

@conda-forge-admin, please rerender

All OK, merging.


beforeRouteUpdate next() fires too early when re-visiting routes within "out-in" transition

Version
2.5.2
Reproduction link
https://jsfiddle.net/hwdearborn/y9xqgz1c/4/
Steps to reproduce

Click "to /", you will see "This is A"
Click 'to B", you will see "This is B"
Click 'to /" or use Back Button, you will see "This is"

Also note the console logs, which show how the order of the next() callback is different on the return visit (Step 3 above)
What is expected?
Without the "out-in" option on the transition, beforeRouteEnter's next() callback is fired after Component A is mounted, and its data is properly set.
What is actually happening?
With the "out-in" option on the transition, beforeRouteEnter's next() callback is fired before Component A's beforeCreate event, causing the data to get overriden with its default (empty) value

I came across this issue while trying to add an out-in transition to the Fetching Before Navigation
example from the docs.

I have the same issue, any updates on it? I would consider it a bug, in 2.2.0 it was working perfectly.

We see there is not data set the seconds time because the vm object in the next callback is actually the old view.


[Enhancement]: CHESS game

Do you want to have the enhancement of existing game ? 😀 Describe yourself..

As can be seen in the above image of the chess board, neither of the white images can be seen. It is because there is no image for White Bishop in the assets/image folder
Describe the solution you'd like
I will add images of white bishop of the same style to match with the overall game experience.
Select program in which you are contributing
GSSoC24
Code of Conduct

[X] I follow CONTRIBUTING GUIDELINE of this project.

Hey @VijaySamant4368 !
Thank you for raising an issue 💗
You can self assign the issue by commenting /assign in comment 😀
Make sure you follow CODE OF CONDUCT and CONTRIBUTING GUIDELINES 🚀
Don’t Forget to ⭐ our GameZone🎮
Make sure you join our Discord🕹

Hey @VijaySamant4368 ! Thank you so much for your raising the issue💗
It’s all yours, you can come anytime again and make some contributions! 🚀
Alone, we can do little, but together we can do so much! 😇


Issue #4: Add Shields to README

Added architecture and contributor shields to README. Could not add license shield because the license has not been specified.
Signed-off-by: Julian Chen<EMAIL_ADDRESS>

Added LICENSE and License shield.


add logging

We have basic logging needs - support for log levels and log rotation. Should we write our own based on standard "log" package or use one the popular ones like glog, etc? Any preference?

I do not have any preference. Should log rotation be done by the keyserver, or can this be delegated to whatever receives the logs (syslog, journald, etc)?


fix(gunicorn): silence healthcheck points in access logs

If DEIS_DEBUG is set then they show up again
Testing Plan:

make deploy on this branch
kubectl logs -f <controller pod> --namespace deis
See if /healtz or /readiness show up in the logs (they should not)
Do any deis CLI action and ensure those endpoints show up in the access log

If DEIS_DEBUG is set then the those requests should show
Fixes #252

[Current coverage][cc-pull] is 85.89%

Merging [#757][cc-pull] into [master][cc-base-branch] will increase coverage by <.01%

@@             master       #757   diff @@
==========================================
  Files            30         30
  Lines          2672       2672
  Methods           0          0
  Messages          0          0
  Branches        429        429
==========================================
+ Hits           2293       2295     +2
+ Misses          257        256     -1
+ Partials        122        121     -1

Powered by Codecov. Last updated by [6ac4d18...3cf431b][cc-compare]
[cc-base-branch]: https://codecov.io/gh/deis/controller/branch/master?src=pr
[cc-compare]: https://codecov.io/gh/deis/controller/compare/6ac4d1863dd1f29ee161682e8982126d9e7d9fa3...3cf431b89fe97ef06d499582a998765567c72544
[cc-pull]: https://codecov.io/gh/deis/controller/pull/757?src=pr

Removing rc2 milestone because rc2 will only contain rc1 plus:

https://github.com/deis/workflow-manager/pull/59
https://github.com/deis/workflow-manager/pull/62
https://github.com/deis/postgres/pull/104
https://github.com/deis/builder/pull/353


Refactor Spec2Vec and allow both Spectrum and SpectrumDocument input

Address #51 to make the API easier for users, and prevent issues with different decimal rounding.

Spec2Vec similarity methods now work with Spectrum and SpectrumDocument input
code examples were updated (and fixed)

SpectrumType is defined as Optional[Spectrum], so it can be None, how does your code deal with None cases? Can you add tests for when spectrum = None?

Thanks for spotting this Stefan! I think None as input should not be allowed, so I changed the input type from SpectrumType to Spectrum and added that it will raise an ValueError if the input type is not Spectrum or SpectrumDocument.

I got AssertionError: Could not find known_adduct_conversions.csv. error when I tried to run the Spec2Vec example code because ...

I added the package_data to the pypi .tar.gz and matchms 0.8.1 now works (the bioconda part still misses rdkit, but that should not be part of this PR I guess). See also https://github.com/matchms/matchms/issues/178

Thanks a lot for the review Stefan!


Deploy Client Web

Deploy the Client web page with Github Pages

Now the client web can be access in with the following link:
Guanaco Tickets


fail to generate cs file for function with union as argument

#include <stdio.h>
typedef union {
  int c;
  int d[10];
} union_t;
struct test_struct2
  int b;
  union_t u;
};
int func_union(union_t u) {
}

int func(struct test_struct2 *p) {
}

The code above failed to generate cs file for func_union.
I think CppSharp omitted functions that get union structure as an argument.
Could someone help me to resolve this issue ? or this feature is not implemented yet ?

I took a quick look and this is because we ignore the typedef declaration, the relevant code is https://github.com/mono/CppSharp/blob/master/src%2FGenerator%2FPasses%2FCleanInvalidDeclNamesPass.cs#L118.
If I remove that whole method, your example code works. @ddobrev do you know if we can safely get rid of this code?


Support microArch

update EnvDetector and MachineInfo to support microArch
add detection for skylake
add parsing logic in TKG to check microArch
update corresponding make files

related: #336
Signed-off-by: renfeiw<EMAIL_ADDRESS>

modified openj9 testExample to test tkg on skylake: Grinder/26678, not on skylake: Grinder/26679

Please add the readme with examples and how to add additional microArch support. It can be in another PR.

Please add the readme with examples and how to add additional microArch support. It can be in another PR.

Sure. I will do it in another PR in openj9 repo.


bug: Flaky test TestReadersWritersStress

Bug Report
YDB GO SDK version: 3.42.8
--- FAIL: TestReadersWritersStress (0.27s)
    --- FAIL: TestReadersWritersStress//local/stress-topic-9 (70.05s)
        topic_stress_test.go:196:

https://github.com/ydb-platform/ydb-go-sdk/actions/runs/4123815294/jobs/7122295474
https://github.com/ydb-platform/ydb-go-sdk/blob/91de13baf63f65d535709b1ec93477c74f341495/tests/topic_stress_test.go#L196-L196

Repro https://github.com/ydb-platform/ydb-go-sdk/actions/runs/4176680680/jobs/7233290384#step:5:28099

reproduced: https://github.com/ydb-platform/ydb-go-sdk/actions/runs/4323527211/jobs/7547236138


Design Homepage Ensure it is Consistent with all Other Pages

Home-page colour theme and design match with the theme and functionality of the other pages.


Analytics tracker PoC

Goal of the PoC
Investigate stream analytics tracker with all kind of content with the possibility to add custom trackers.

Load URN with Standard SRG Trackers (MediaComposition info is available) and another custom one.
Load URL with custom analytics (Should not be able to register SRG tracker)

Implementation considerations
Some analytics libraries are "singleton" designed (Comscore).
Implements dummy SRG trackers.

API Design Idea

Implement custom tracker by implementing a interface Tracker
Trackers are attached to MediaItem when they are created by MediaItemSource
Tracker are active during Player current item lifetime.

Tracker interface
/**
 * Stream tracker
 */
interface StreamTracker {
    /**
     * Called when a tracker is attached to a Player.
     *
     * @param player The player the tracker is attached
     */
    fun attachPlayer(player: ExoPlayer)

    /**
     * Called when a tracker is detach from its player.
     *
     * @param player The player the tracker have to detached.
     */
    fun detachPlayer(player: ExoPlayer)
}

MediaItemSource
class MediaCompositionMediaItemSource(private val mediaCompositionDataSource: MediaCompositionDataSource) : MediaItemSource {

    override suspend fun loadMediaItem(mediaItem: MediaItem): MediaItem {
        require(MediaUrn.isValid(mediaItem.mediaId)) { "Invalid urn=${mediaItem.mediaId}" }
        val mediaUri = mediaItem.localConfiguration?.uri
        require(!MediaUrn.isValid(mediaUri.toString())) { "Uri can't be a urn" }
        // Load MediaComposition
        when (val result = mediaCompositionDataSource.getMediaCompositionByUrn(mediaItem.mediaId)) {
            is RemoteResult.Success -> {
                val chapter = result.data.mainChapter
                val resource = resourceSelector.selectResourceFromChapter(chapter) ?: throw ResourceNotFoundException
                var uri = Uri.parse(resource.url)

                val trackerList = listOf(SRGTracker(SRGAnalyticsData(resource, chapter)), SnitchTracker())
                return mediaItem.buildUpon()
                    .setMediaMetadata(fillMetaData(mediaItem.mediaMetadata, chapter))
                    .setDrmConfiguration(fillDrmConfiguration(resource))
                    .setTag(trackerList)
                    .setUri(uri)
                    .build()
            }
            is RemoteResult.Error -> {
                throw result.throwable
            }
        }
    }
}

Sample
Lets add a custom tracker
class SRFGoogleAnalytics(val config: String)

class SRFGoogleAnalyticsTracker(val data: SRGAnalyticsData, val googleAnalytics: SRFGoogleAnalytics) : StreamTracker {

    override fun attachPlayer(player: ExoPlayer) {
        Log.d("SRFTracker", "SRF Google Analytics : start for ${data.chapter.title} with ${googleAnalytics.config}")
    }

    override fun detachPlayer(player: ExoPlayer) {
        Log.d("SRFTracker", "SRF Google Analytics : stop for ${data.chapter.title} with ${googleAnalytics.config}")
    }
}

Let's customise MediaItemSource to add the new Tracker to a MediaItem. We have to compose the 'MediaCompositionMediaItemSource' because it is not an open class.
class SRFMediaItemSourceLoader(val ilItemSourceLoader: MediaCompositionMediaItemSource) : MediaItemSource {
    private val googleAnalytics = SRFGoogleAnalytics("GoogleAnalyticsID")

    override suspend fun loadMediaItem(mediaItem: MediaItem): MediaItem {
        val ilItem = ilItemSourceLoader.loadMediaItem(mediaItem)
        val listTracker = ilItem.getListStreamTracker()!!
        // We know that the Official SRGTracker store the srg analytics data we need.
        val srgTracker = listTracker.findLast { it is SRGTracker } as SRGTracker
        // MediaItem.appendTrackers create a new MediaItem. MediaItem are immutable objects.
        return ilItem.appendTrackers(SRFGoogleAnalyticsTracker(srgTracker.data, googleAnalytics))
    }
}

Open issue and questions

Customization of MediaItemSource to only add custom trackers can be improved.
Current item detection assume MediaItem tag is a type of List<StreamTracker> a nothing else.
Current item detection is responsible of calling attach / detach player and have to correct.


chore(deps): update devdependency @types/node to ^20.17.1

This PR contains the following updates:

Package
Type
Update
Change

@types/node (source)
devDependencies
patch
^20.17.0 -> ^20.17.1

Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Enabled.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.

[ ] If you want to rebase/retry this PR, check this box

This PR has been generated by Hywax Assistant.

:warning: Please install the  to ensure uploads and comments are reliably processed by Codecov.
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 100.00%. Comparing base (0a3fc6c) to head (d697ceb).

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@            Coverage Diff            @@
##              main       #80   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files            3         3
  Lines          147       147
  Branches        25        26    +1
=========================================
  Hits           147       147

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


headscale: 0.22.1 -> 0.22.3

Description of changes
https://github.com/juanfont/headscale/releases/tag/v0.22.3

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.05 Release Notes (or backporting 22.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Damn I messed up formatting let me fix that

Fixed

@ofborg test headscale

Ah yes tests are not passing because we need https://github.com/NixOS/nixpkgs/pull/231371


Return an error instead of panicking when rate limit data is nil.

Summary by CodeRabbit

New Features

Introduced enhanced error handling for rate limit data retrieval.
Improved error reporting for HTTP requests, including detailed context for timeouts and connection resets.

Bug Fixes

Added checks to prevent nil dereference issues in error handling.

did you release a new version for this?


Update golang to 1.14.x

The attempt here is update the golang to latest version .
Its necessary as we have a failure mentioned @ https://github.com/ceph/ceph-csi/pull/917#issuecomment-609998502 . May be updating to 1.13.9 is enough.
Signed-off-by: Humble Chirammal<EMAIL_ADDRESS>

On Tue, Apr 07, 2020 at 01:49:07AM -0700, Madhu Rajanna wrote:

@Madhu-1 commented on this pull request.

@@ -1,10 +1,15 @@
FROM ceph/ceph:v15

-ENV GOPATH=/go \

GO111MODULE=on

+RUN \

mkdir -p /go && \
curl https://storage.googleapis.com/golang/go1.14.1.linux-amd64.tar.gz | tar xvzf - -C /go --strip-components=1

1.13 should be good for kube 1.18. but still, you need to install go1.13 as in ceph:v15 docker image the default installation of go is 1.12.x

In that case, the requirement should be explained in the commit message
too!
Ideally golang would get installed from an additional repository, but
unfortunately I can not find one for CentOS 8 that has a newer version
of golang.
Installing golang from a release tarball should have some
arch-independent way, or best practise. Please follow that.

Does ceph:latest has better version of go ?

On Tue, Apr 07, 2020 at 03:16:16AM -0700, Humble Devassy Chirammal wrote:

Does ceph:latest has better version of go ?

No, I doubt that. The Ceph image is based on CentOS 8, and that comes
with golang-1.12.x

hmm. CI is failng with below error :
ERRO Running error: context loading failed: failed to load program with go/packages: could not determine GOARCH and Go compiler

INFO Memory: 2 samples, avg is 68.7MB, max is 68.9MB

INFO Execution took 15.808995ms

Makefile:56: recipe for target 'static-check' failed

make: *** [static-check] Error 3

The command "make static-check" exited with 2.

0.02s$ make go-test

On Tue, Apr 07, 2020 at 04:23:44AM -0700, Humble Devassy Chirammal wrote:

hmm. CI is failng with below error :
ERRO Running error: context loading failed: failed to load program with go/packages: could not determine GOARCH and Go compiler

INFO Memory: 2 samples, avg is 68.7MB, max is 68.9MB

INFO Execution took 15.808995ms

Makefile:56: recipe for target 'static-check' failed

make: *** [static-check] Error 3

The command "make static-check" exited with 2.

0.02s$ make go-test

Because you are now installing Go from a tarball, you are probably
missing some dependencies. I expect that you need to install at least
gcc, and maybe more.

Thanks @Madhu-1 , it looks like its passing with 1.13.9.. That should be enough I believe for other PR .

@Madhu-1 @nixpanic please review to unblock other imp PRs?

The error at the end of the make containerized-build test is this:
go: inconsistent vendoring in /go/src/github.com/ceph/ceph-csi:
	go.mod requires github.com/ceph/ceph-csi  but vendor/modules.txt does not include it.
	run 'go mod tidy; go mod vendor' to sync

Maybe this points to an incorrectness in the master branch when a new version of Go is used?

@nixpanic looks like that could be the reason. I filed https://github.com/ceph/ceph-csi/pull/922 .. lets see how it goes.

@nixpanic @Madhu-1 even after vendor cleanup this is failing.. interesting..

@Madhu-1 @nixpanic the CI green! Can you please review/approve this PR in priority ?

@nixpanic @Madhu-1 with many iterations this is in good shape. Please review with priority. Thanks in advance

please update the commit message why this change is required

Its in the PR description @Madhu-1

please update the commit message why this change is required

Its in the PR description @Madhu-1

in commit message

please update the commit message why this change is required

Its in the PR description @Madhu-1

in commit message

Oh.. is it required in commit message too ? I thought PR description is enough.

@nixpanic @Madhu-1 ptal.. For some reason reordering of env and path not going well together. With the current model it works as expected. We could improve it later if needed. but for now, this is fine I believe and it could unblock other dependency update PRs.

@Madhu-1 @nixpanic one more time please.


Fix: Use recommended nonce for already executed nonce message

What it solves
Resolves #3219
How this PR fixes it
Suggests the BE-services recommended tx nonce when trying to create a tx with an already executed nonce
How to test it

Start creating a transaction
Change the "Safe nonce" to an already executed nonce
You shall see the implemented warning message

Screenshots

@francovenica shall we create a ticket to include this case in the E2E tests?

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

11 of 14 (78.57%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.06%) to 32.33%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

src/components/ReviewInfoText/index.tsx
11
14
78.57%

Totals

Change from base Build<PHONE_NUMBER>:
0.06%

Covered Lines:
3096

Relevant Lines:
8506

💛  - Coveralls

@francovenica shall we create a ticket to include this case in the E2E tests?

Ok. We can just add it to the existing adv_options test

Question regarding this scenario:
Tx 1 was the last one to be executed
Tx 2 should be next
Tx 3 already exist in queue
Trying to create a tx with nonce 1 will say that you should create one with nonce 4.
Is this correct? should we suggest the user to create a tx with the next nonce in the line, even if he won't be able to execute it? or should we recommend create a tx with the "current nonce" as it shows in advanced options?

Question regarding this scenario: Tx 1 was the last one to be executed Tx 2 should be next Tx 3 already exist in queue Trying to create a tx with nonce 1 will say that you should create one with nonce 4.
Is this correct? should we suggest the user to create a tx with the next nonce in the line, even if he won't be able to execute it? or should we recommend create a tx with the "current nonce" as it shows in advanced options?

The nonce that we are recommending now is retrieved from the BE (see https://gnosisinc.slack.com/archives/CQB729LLF/p1639999500423200)

Ok, noted. The message will suggest the same nonce that is already suggested in advanced options when the tx is being created.
Looks good to me
Tx that try to use an already executed nonce will see the warning message suggesting the nonce
Tx that are created with the suggested nonce or the next one that has to be executed won't show the message (this is correct)
Tx that try to use a future nonce will see the message that says "x amount of tx will need to be created...", so that's still working fine.


change heading

@AsfaMumtaz Image is available for testing. docker pull stakater/workshop-excercise:SNAPSHOT-PR-38-dcf4ef2c


Singeleton pattern for the task API

Currently, in AutoGluon, we will do the following, in which TabularPrediction is used as a singeleton.
from autogluon import TabularPrediction as task
predictor = task.fit(...)

A more natural design choice is to create a new class object and call fit as a method.
from autogluon import TabularPrediction
task = TabularPrediction(SOME_ARGS)
predictor = task.fit()

@Jerryzcn

I think this is reasonable, it aligns with how H2O and auto-sklearn function. It will be a major refactor in terms of user-facing API, so we should save it for a major release.
I am curious what we would gain from this outside of it being more 'natural'. I suppose we could add info/utility functions that would explain the parameters they passed in? Would .fit() still take in the data itself as a parameter?

@Innixma I think .fit() will still take the data as the input parameter. The difference is that we can pass some specific requirements like time budget and inference latency when constructing the task, e.g.
from autogluon import TabularPrediction
task = TabularPrediction(time_limit=1000, latency='low')
predictor = task.fit(train_data, label='...')

Then, we will automatically learn a predictor that obeys the budget constraint.

@jwmueller Any comments on this?

I agree the instantiating the TabularPrediction object is more natural Python, but what properties would be set when the object is instantiated to justify this extra line of code?  I don't think the object constructor should be tracking time-limits, those should be in fit() since they are never used afterward.  But the object constructor could be appropriately used for things which remain relevant to the task even after fit(), for example optional things like: the metric, problem_type.  Overall it would be significant work to refactor everything so IMO needs to bring some extra benefits beyond being seeming more natural (To me, requiring an extra line of code more or less cancels out the 'natural' benefit).

Yes, we can set some evaluation metrics bound to the learning task. We could also probably set 1) the IP address of the servers, 2) the directory that the task will use for storing temporary results. Putting the learning-related arguments inside fit() will end up with a very large fit function. Nevertheless, this is just something that would be nice to have.

In principle, I agree with including the directory since its relevant outside of fit().  However, this comes with some thorny issues. Suppose the user calls task = TabularPrediction(directory=...) and then calls a = task.fit(...), b = task.fit(...).  The second fit() will overwrite the files of the first which may be less intuitive to the user than when they explicitly have to pass the directory to fit().
I'm unsure about including the IP addresses.  Currently these servers are only used during fit(), and I think anything that's not used outside of fit() can just be kept as a fit() argument.
It's not like the servers are being created/affected by specifying their IP addresses in the proposed task constructor or any actual setup is really happening.  I'd be more interested in including IP addresses if some sort of related setup is actually happening inside the task constructor (for example, the task constructor could check that it can actually communicate with these IP addresses).
Advantages of the proposed change I see so far are:

more natural
can reduce number of fit() args
can potentially do some non-fit()-related setup inside the task object construction (e.g. checking that specified IP addresses are valid)

Disadvantages:

user has to write extra line of code to use autogluon

I find that there is actually another Learner class in AutoGluon, which behaves more similar to the model in scikit-learn.

Learner was the original user-facing API prior to open-source, however we added Predictor as a wrapper to it to conform to the API of ImageClassification and TextClassification.

Closing as resolved, we have implemented the singleton pattern for v0.1.


IEEE802154 active scan gets filtered in network stack

Describe the bug

When issuing an active scan of 802.15.4 on the shell, all response packages are dropped by the network stack.
To Reproduce
Have something, that answers to 802.15.4 active network scans, like a zigbee coordinator (here, you could use the out of scope nRF sample nrf/samples/zigbee/network_coordinator)
Compile Zephyr with:
CONFIG_SHELL=y
CONFIG_NETWORKING=y
CONFIG_NET_SHELL=y
CONFIG_NET_L2_IEEE802154=y
CONFIG_NET_L2_IEEE802154_SHELL=y
CONFIG_NET_L2_IEEE802154_RFD=y

Do an active scan on the commandline (see snippet below)
Expected behavior
The scan response packages are received and given to the network stack for further processing
Impact

Showstopper. I have to force the network interface up before I can scan.
Logs and console output

The log from my shell:
uart:~$ net iface show

Interface ieee0 (0x20000b30) (IEEE 802.15.4) [1]
========================================
Interface is down.
uart:~$ net iface up 1
Cannot take interface 1 up (-115)
uart:~$ ieee802154 scan active all 100
Active Scanning (channel set: 0xffffffff, duration 100 ms)...
Done
[00:02:23.907,348] <wrn> net_ieee802154_mgmt: Could not remove PAN ID filter
[00:02:25.347,076] <err> ieee802154_nrf5: Packet dropped by NET stack
[00:02:25.348,358] <err> ieee802154_nrf5: Packet dropped by NET stack
[00:02:25.360,168] <err> ieee802154_nrf5: Packet dropped by NET stack
[00:02:25.546,966] <wrn> net_ieee802154_mgmt: Could not remove PAN ID filter
uart:~$

The "Packet dropped by NET stack" messages are produced, because the network interface is not up. I don't want to set the interface up, because I'm currently scanning for the network.
Environment (please complete the following information):

OS: Linux
Toolchain: Zephyr current main
f2b6490dee30b38dfb0ee31902177491c35ebacb
Board: NRF52840DK

Additional context

The error starts here:
https://github.com/zephyrproject-rtos/zephyr/blob/f2b6490dee30b38dfb0ee31902177491c35ebacb/drivers/ieee802154/ieee802154_nrf5.c#L215-L218
Because:
https://github.com/zephyrproject-rtos/zephyr/blob/f2b6490dee30b38dfb0ee31902177491c35ebacb/subsys/net/ip/net_core.c#L499-L501

CC @rlubos @jukkar

@gumulka By the current standard (section 6.3.1), only beacons should be received during active or passive scan. Are you saying that currently no beacons can be received?
If we're not talking about beacons then please help me with some additional context re your expectation. What kinds of packets does the Zigbee co-ordinator send back (frame type, payload, purpose)?

@gumulka I further debugged the issue and I cannot reproduce it. We have a unit test on this. Maybe you have the KConfig variable IEEE802154_NET_IF_NO_AUTO_START set to true? In that case you'd have to call net_if_up() manually. Otherwise the interface should be brought up during initialization which in turn would set the NET_IF_UP flag and any beacons received should then be allowed in.

@gumulka Can you please try to scan from the echo sample instead, e.g.
west build samples/net/sockets/echo_server --pristine --board nrf52840dk/nrf52840 -DEXTRA_CONF_FILE=overlay-802154.conf

The shell is exposed through UART in that sample. In my case this provides me with a properly set up interface that is automatically "UP". Can you properly scan with this sample? (This doesn't mean that we don't have a bug, it just means that we can further hone in on the source of the bug.)

Are you saying that currently no beacons can be received?

yes, as seen in the logs.

@gumulka I further debugged the issue and I cannot yet reproduce it. We have a unit test on this. The interface should be brought up during initialization which in turn would set the NET_IF_UP flag and any beacons received should then be allowed in.
But I can see that you cannot bring the interface up manually in your case. I'll dig deeper because that seems to be the actual cause.

I have just seen, that I forgot the CONFIG_LOG=y parameter
How to reproduce on my side:
mkdir zephyr_76178
cd zephyr_76178
west init -m https://github.com/zephyrproject-rtos/zephyr --mr main
west update
cd zephyr
cat 76178.patch | git am
cd ..
west build -p -b nrf52840dk_nrf52840 zephyr/samples/basic/blinky
west flash

Using the nrf52840dk, obviously.
for the patch, use this git diff 76178.txt
results in:
[00:00:00.448,913] <inf> ieee802154_nrf5: nRF5 802154 radio initialized
*** Booting Zephyr OS build v3.7.0-rc3-102-g099209b7d563 ***
uart:~$ ieee802154 scan active all 500
Active Scanning (channel set: 0xffffffff, duration 500 ms)...
Done
[00:00:08.975,860] <err> ieee802154_nrf5: Packet dropped by NET stack
[00:00:13.372,528] <err> ieee802154_nrf5: Packet dropped by NET stack
[00:00:13.373,809] <err> ieee802154_nrf5: Packet dropped by NET stack
[00:00:13.377,990] <err> ieee802154_nrf5: Packet dropped by NET stack
uart:~$

@gumulka Can you please try to scan from the echo sample instead, e.g.
west build samples/net/sockets/echo_server --pristine --board nrf52840dk/nrf52840 -DEXTRA_CONF_FILE=overlay-802154.conf

The shell is exposed through UART in that sample. In my case this provides me with a properly set up interface that is automatically "UP". Can you properly scan with this sample?

Yes, I can do with this example. But here the example does the heavy lifting of putting up the network. I don't need a network that is up to scan for beacons.

I don't need a network that is up to scan for beacons.

net_if_up() brings up the link layer (MAC) - not a full network. Scanning is a link layer activity, so I'd say you need L2 up to scan. You don't need anything above L2 of course (IP, UDP, etc.).
When enabling the interface we currently switch on the receiver so you have to configure at least a channel before you can call net_if_up() (which should be optional - see below). Conceptually enabling the interface could be anything, though, therefore a disabled interface should not allow you to scan. So what you're seeing is expected behavior IMHO.
I do see, though, where the confusion might come from:

If you wanted the interface to be enabled w/o configuring a channel and switching on the receiver, then you'd have to unset the macRxOnWhenIdle flag (see IEEE 802.15.4-2020) via net_mgmt API before bringing up the interface. Unfortunately macRxOnWhenIdle was implemented w/o net_mgmt support (see the thread I created today in #ieee802154) and cannot be read by L2 right now (which is a bug IMO) - CC @rlubos @edmont
There is an unconditional call to ieee802154_radio_start() in ieee802154_scan() which dates back from 8 years ago. This should only be called if the receiver is not already on.

Both issues are unrelated to your issue, though, and should be easy to work around by setting a channel before trying to bring up the interface.

See https://github.com/zephyrproject-rtos/zephyr/pull/76265.


fast-Dreambooth not working

Getting this error tried multiple times
Progress:|████████                 | 33% 999/3000 [16:27<32:42,  1.02it/s, loss=0.0244, lr=1.37e-6] SAVING CHECKPOINT: /content/gdrive/MyDrive/Fast-Dreambooth/Sessions/shantjaldb/shantjaldb_step_1000.ckpt
Traceback (most recent call last):
File "/content/diffusers/examples/dreambooth/train_dreambooth.py", line 788, in
main()
File "/content/diffusers/examples/dreambooth/train_dreambooth.py", line 734, in main
text_encoder=accelerator.unwrap_model(text_encoder),
File "/usr/local/lib/python3.7/dist-packages/diffusers/pipeline_utils.py", line 660, in from_pretrained
f"Pipeline {pipeline_class} expected {expected_modules}, but only {passed_modules} were passed."
ValueError: Pipeline <class 'diffusers.pipelines.stable_diffusion.pipeline_stable_diffusion.StableDiffusionPipeline'> expected {'unet', 'safety_checker', 'tokenizer', 'vae', 'scheduler', 'text_encoder', 'feature_extractor'}, but only {'unet', 'tokenizer', 'vae', 'scheduler', 'text_encoder'} were passed.
Progress:|████████                 | 33% 999/3000 [16:29<33:02,  1.01it/s, loss=0.0244, lr=1.37e-6]
Traceback (most recent call last):
File "/usr/local/bin/accelerate", line 8, in
sys.exit(main())
File "/usr/local/lib/python3.7/dist-packages/accelerate/commands/accelerate_cli.py", line 43, in main
args.func(args)
File "/usr/local/lib/python3.7/dist-packages/accelerate/commands/launch.py", line 837, in launch_command
simple_launcher(args)
File "/usr/local/lib/python3.7/dist-packages/accelerate/commands/launch.py", line 354, in simple_launcher
raise subprocess.CalledProcessError(returncode=process.returncode, cmd=cmd)
subprocess.CalledProcessError: Command '['/usr/bin/python3', '/content/diffusers/examples/dreambooth/train_dreambooth.py', '--image_captions_filename', '--train_text_encoder', '--save_starting_step=1000', '--stop_text_encoder_training=3000', '--save_n_steps=1000', '--Session_dir=/content/gdrive/MyDrive/Fast-Dreambooth/Sessions/shantjaldb', '--pretrained_model_name_or_path=/content/stable-diffusion-v1-5', '--instance_data_dir=/content/gdrive/MyDrive/Fast-Dreambooth/Sessions/shantjaldb/instance_images', '--output_dir=/content/models/shantjaldb', '--instance_prompt=', '--seed=895012', '--resolution=512', '--mixed_precision=fp16', '--train_batch_size=1', '--gradient_accumulation_steps=1', '--use_8bit_adam', '--learning_rate=2e-6', '--lr_scheduler=polynomial', '--lr_warmup_steps=0', '--max_train_steps=3000']' returned non-zero exit status 1.
Something went wrong

Should work now, update your colab

Thanks, It's Working Now.


[REQUEST] add support for floating point values

Currently I am trying to sort a list of multiple constant strings that I want to sort by the Price but there is other numbers in front of it that would mess it up:

that is what it sends to discord but I want it to be sorted like this:

Not sure if when you sort it you can make it sort them by making it start at a different point in every line if that makes sense

I don't think I can add something to do this, I'll give you a piece of code that will get the job done but I'm not going to add any blocks because it would be extremely hard to do for the generic case.
https://discourse.openbullet.dev/t/sorting-a-list-of-strings-basing-on-numbers-inside-the-elements/3041


Add support for distributed diagonal block preconditioners.

This PR is the first set of PRs enabling distributed preconditioning for our distributed solvers.

As discussed, everything is in the experimental namespace and in the distributed/ folder.
An example has been added to show the usage of the preconditioner.
Some minor fixes have also been done to mpi, the run and dispatch function and also moving some things into the experimental namespace (Some contributed by @MarcelKoch) .
A distributed stream logger was also added, but this probably needs more discussion (By @MarcelKoch). Removed for now, as it is a separate thing, for which a new PR should be created.

TODO

[x] Add tests.

#1241 is a clone (with different naming) of what was there in a previous distributed preconditioner branch.
This PR takes a few initial commits from that distributed-schwarz, which adds the local block preconditioning into the Schwarz preconditioner class, which is what these general block preconditioners are called. This is also a extension of the Schwarz preconditioners from #1089, which was closed as we decided to do this directly for distributed.

format!

This has been rebased and should be ready to review again.