[native_assets] Relative path resolution with symlinks

When native assets are looked up at runtime with a 'relative' path, the path is resolved against the platform script path:
https://github.com/dart-lang/sdk/blob/be95daf4e40304dfb81eb83f1a07aa17e7731522/runtime/lib/ffi_dynamic_library.cc#L402-L423
However, if this platform script path contains symlinks, these are not resolved.
Consider the following directory structure.
* temp
  * foo
    * kernel-snapshot
    * my_asset.so
  * bar
    * baz -> ../foo/kernel-snapshot

Assuming the native assets mapping is ['relative', './my_asset.so'] for some asset, running dart /temp/bar/baz will try to look up the asset in /temp/bar/my_asset.so.
To fix this, we could resolve try to resolve symlinks in the platform script path before doing any relative path resolution.
The question is whether that is the right thing to do yes or no. Consider the following directory structure:
* temp
  * foo
    * kernel-snapshot
  * bar
    * baz -> ../foo/kernel-snapshot
    * my_asset.so

In this case, first resolving the symlinks would make the same resolution fail.
Given how common it is to symlink executables,
$ ls -lah /usr/bin/clang
lrwxrwxrwx 1 root root 24 Sep 13  2023 /usr/bin/clang -> ../lib/llvm-16/bin/clang

we should most likely not care about the latter case and resolve the symlinks eagerly.
Especially, in the case where we dart build exe, when we start building self-contained executable bundles.
To have consistency with executable bundles, and bundles with snapshots, we should do the same for snapshots.

[ ] kernel snapshot
[ ] appjit snapshot
[ ] aot snapshot
[ ] dart build (https://github.com/dart-lang/sdk/issues/55207)

Reproduction: https://dart-review.googlesource.com/c/sdk/+/361881/4
And for good measure, it should work on all operating systems:

[ ] Linux
[ ] MacOS
[ ] Windows

The resolution should be implemented in the embedder. (The flutter embedder might shell out to the Dart one for resolving symlinks, as it already does so for dart:io.)
We should address this together with making DynamicLibrary.open be resolved by the embedder:

https://github.com/dart-lang/sdk/issues/37771


fix 409 duplicate batch issue

replace deterministic default batch_id with uuid
resolves #1006
docs dbt-labs/docs.getdbt.com/#

Problem

Solution

Checklist

[ ] I have read the contributing guide and understand what's expected of me
[ ] I have run this code in development and it appears to resolve the stated issue
[ ] This PR includes tests, or tests are not required/relevant for this PR
[ ] This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX

Hello!! Any idea when this fix will get released? Or at least guidance on a version that doesn't have this issue we can downgrade to?


Benchmark enhancement

Recently, we are using benchmark code to test our cluster which deployed on DLedger mode.
I found some minor enhancement which cloud make the process of benchmark clear and convenient.

add shutdown script
more info print as a result of benchmark
add thread count option for consumer

If anyone think it make sense, I'm glad to submit a related PR.

Hi, you're welcomed to submit a PR and we will review it. Also the community is proposing a new plugin mechanism and lifecycle hook mechanism that enables developers to customize their benchmark options by integrating with these lifecycle hooks. I think the RIP is coming out soon and if you are interested feel free to join the RIP.

Hi, you're welcomed to submit a PR and we will review it. Also the community is proposing a new plugin mechanism and lifecycle hook mechanism that enables developers to customize their benchmark options by integrating with these lifecycle hooks. I think the RIP is coming out soon and if you are interested feel free to join the RIP.

Hi, I've submitted a PR and very glad to make contribution to community.


osm: disable ticker, space k8s resyncs to 5m

OSM does not hard-require periodic re-configs to guarantee state
correctness in its current form. In order to help maintain this statu quo,
we will disable ticker and increase the k8s resync period, which will
help catch issues that break on-event updates at testing/CI time.

Since we still believe periodic arbitrary resyncs could be something
that we still might want to have at later time/different circumstances, to
ensure config correctness, we will add configurability into ticker and
resync intervals in a later patch (#2103).

Control Plane          [X]

Does this change contain code from or inspired by another project? If so, did you notify the maintainers and provide attribution?
No

Codecov Report

Merging #2095 (da2917e) into main (e2ed301) will decrease coverage by 0.16%.
The diff coverage is 11.11%.

@@            Coverage Diff             @@
##             main    #2095      +/-   ##
==========================================
- Coverage   58.56%   58.39%   -0.17%
==========================================
  Files         144      144
  Lines        5906     5911       +5
==========================================
- Hits         3459     3452       -7
- Misses       2444     2456      +12
  Partials        3        3

Impacted Files
Coverage Δ

pkg/kubernetes/types.go
0.00% <ø> (ø)

pkg/catalog/catalog.go
75.00% <11.11%> (-25.00%)
:arrow_down:

pkg/kubernetes/event_handlers.go
69.38% <0.00%> (-16.33%)
:arrow_down:

pkg/kubernetes/client.go
89.81% <0.00%> (-0.93%)
:arrow_down:

pkg/envoy/lds/listener.go
26.53% <0.00%> (-0.56%)
:arrow_down:

pkg/envoy/lds/inmesh.go
85.18% <0.00%> (ø)

pkg/envoy/route/config.go
96.03% <0.00%> (+0.79%)
:arrow_up:

pkg/envoy/xdsutil.go
66.18% <0.00%> (+1.85%)
:arrow_up:

...certificate/providers/vault/certificate_manager.go
56.09% <0.00%> (+6.09%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e2ed301...a4ba021. Read the comment docs.

I plan to introduce some configurability on it next week. Not going to be dead code, no worries.


Update serverless.yml

Couple more suggestions

Thanks, good catch! Those edits would make the project much easily configurable and usable by everyone. There are some naming changes I'll add to those, for example alias vs certificate, but I'll add those changes in a separate commit directly to master.


Multi warn fixes

Fixed warnings with Release builds (see #3525)

I don't understand the rationale with FILE replacement, can you elaborate ?

@hardening that's something we have for quite a while but isn't working since some time ;). The idea is if you do a Release build that you get paths relative to the build directory instead of absolute paths on the build machine. One of the nice things about this is that the paths are always the same regardless where you built them.


Clean up: Avoid hard-coding draft numbers in protocol logic.

This came up in the implementation of taskprov: https://github.com/cloudflare/daphne/pull/152#discussion_r1014508424

Hardcoding in protocol logic has been removed as part of #171.


SFTPStream: add more error codes

A small update to add more error codes. The codes are copied straight from libssh2_sftp.h

Which RFC/standard do these come from? I've never seen these before.

Oh I see it now, these status codes are not relevant because they are for later versions of the SFTP protocol and this module only supports SFTPv3.

Ah, I didn't realise these were for different protocol versions. Thanks for taking a look


Build and push a new release

Hello,
The latest release (v1.0.0) was published on 7 Feb 2015.
Since then a few improvements were added to the lib, that would be really great to bump the minor and publish a v1.1.0 so that we can install the latest lib via Rubygems.
The workaround is to link the repo directly in the Gemfile:
gem 'sendcloud-ruby', :git => 'https://github.com/pero-ict-solutions/sendcloud.git'

Thanks you !
cc @peterberkenbosch @artyomlagun @fatboypunk

I just pushed a new release to rubygems @Pyo25. Thanks for your patience!


Failed to load config from file

Running docker with
version: "3.0"
services:
frigate-notify:
image: ghcr.io/0x2142/frigate-notify:latest
environment:
- TZ=Europe/Stockholm
volumes:
- /mnt/dietpi_userdata/config.yml:/app/config.yml
restart: unless-stopped
config.yml
frigate:
server: <IP_ADDRESS>:5000
ignoressl: false
Public / internet-facing Frigate URL, if different from above server address
public_url:
List of HTTP headers to send to Frigate, in format Header: Value
headers:
# Example:
# - Authorization: Basic abcd1234
On startup, frigate-notify will check reachability of Frigate server
startup_check:
# Max number of attempts (Default: 5)
attempts: 3
# Interval between attempts, in seconds (Default: 30)
interval: 30
webapi:
# Set to true to enable event collection via the web API
enabled:
# Interval between checking for new events, in seconds (Default: 30)
interval:
mqtt:
# Set to true to enable event collection via MQTT
enabled:true
# MQTT host IP
server: <IP_ADDRESS>
# MQTT host port. (Default: 1883)
port:
# MQTT Client ID (Default: frigate-notify)
clientid:
# MQTT Authentication. Leave both blank for anonymous
username:
password:
# Optionally set custom topic prefix (Default: frigate)
topic_prefix:
But getting error
2024/08/03 16:42:37 +0200 INF Frigate Notify - v0.3.2
2024/08/03 16:42:37 +0200 INF Starting...
2024/08/03 16:42:37 +0200 FTL Failed to load config from file! error="yaml: line 1: did not find expected key"
I have run out of ideas please could I  have same help?
Thanks

Move to node-red

Hi there -
Sorry this wasn't working. I was able to replicate your issue by using the config snip that you shared. There is a missing space for enabled:true under mqtt. If I modify the config to include the space (enabled: true), then the app started just fine.
Just wanted to note this, in case anyone else runs across this issue.

Thank you will try


Problem accessing templates directory

The documentation does not state whether the directory for the the template directory can be relative.
app.mustache = try .init(directory: "templates")

Is template relative to some other directory or is it the full path. Full path does not seem to make sense.
I have not been able to get my program to find the template directory.

Hi @brucemontegani have you set the working folder in Xcode. Set it to the same folder as your project and you should be able to use relative paths from your project.

I am not using Xcode. I am using VSCode.

OK. I figured it out. I had to put it outside the "Sources" directory but inside the project directory.
<project-dir>
   Sources
        main.swift
   templates
        index.html
   Tests

Closing as resolved


Tickets counting

Discussed in https://github.com/lnbits/lnbits/discussions/1923

Originally posted by Wlello September 10, 2023
Hey whats up? I noticed that the count of sold tickets is not being computed correctly, as the system is marking as sold tickets that were only generated but not paid for, causing the quantity to run out before they are all actually sold. I suggest that the count be done through the table that updates the balance in the collection, so only the tickets that were actually paid will be counted.
I hope I helped, and congratulations to everyone for the excellent work!

What version of events extension are you using?

Can't reproduce the issue...

I think that has been already fixed, on main, but hasn't been released as an update yet!


Best way to decode (translate) a hundred thousand files?

I'm currently looping through each text file and running t2t-decoder to translate into my target language.
It appears loading my model per each file is taking a lot more time than necessary. What is the best way to go about this?
I have considered batching all my text files into one big text file for inference, but it doesn't seem to be a good idea as some of the text files need to fail appropriately as they contain errors from pre-processing (long story, don't ask me why.)

I assume serving the model is the way to go, but running into this issue:
https://github.com/tensorflow/tensor2tensor/issues/1219


AttributeError: type object 'PFIExplainer' has no attribute 'explainable_model_type'

I'm running this code
explainer = MimicExplainer(model,
                           X_test,
                           PFIExplainer,
                           augment_data=True,
                           max_num_of_augmentations=10,
                           categorical_features=CAT_FEATURES,
                           features=USE_FEATURES)

And I am facing with this bug:
---------------------------------------------------------------------------
AttributeError                            Traceback (most recent call last)
<ipython-input-55-a93f85c89153> in <module>
----> 1 explainer = MimicExplainer(model,
      2                            X_test,
      3                            PFIExplainer,
      4                            augment_data=True,
      5                            max_num_of_augmentations=10,

/opt/anaconda3/envs/lto/lib/python3.8/site-packages/interpret_community/dataset/decorator.py in init_wrapper(self, model, initialization_examples, *args, **kwargs)
     40     @wraps(init_func)
     41     def init_wrapper(self, model, initialization_examples, *args, **kwargs):
---> 42         return init_func(self, model, wrap_dataset(initialization_examples), *args, **kwargs)
     43     return init_wrapper

/opt/anaconda3/envs/lto/lib/python3.8/site-packages/interpret_community/mimic/mimic_explainer.py in __init__(self, model, initialization_examples, explainable_model, explainable_model_args, is_function, augment_data, max_num_of_augmentations, explain_subset, features, classes, transformations, allow_all_transformations, shap_values_output, categorical_features, model_task, reset_index, **kwargs)
    286
    287         # If model is a linear model or isn't able to handle categoricals, one-hot-encode categoricals
--> 288         is_tree_model = explainable_model.explainable_model_type == ExplainableModelType.TREE_EXPLAINABLE_MODEL_TYPE
    289         if is_tree_model and self._supports_categoricals(explainable_model):
    290             # Index the categorical string columns for training data

AttributeError: type object 'PFIExplainer' has no attribute 'explainable_model_type'

hi @ibobak , the mimic explainer takes an explainable surrogate model, not another explainer.  You shouldn't pass PFIExplainer as the surrogate model to MimicExplainer.  Instead, you can pass any of these:
from interpret.ext.glassbox import LGBMExplainableModel
from interpret.ext.glassbox import LinearExplainableModel
from interpret.ext.glassbox import SGDExplainableModel
from interpret.ext.glassbox import DecisionTreeExplainableModel
please see docs for model module:
https://interpret-community.readthedocs.io/en/latest/api_reference/interpret_community.mimic.models.html

I think we can add a better exception message here though.  Also, I think there is still a bug with explainable_model_type, it's actually a static method currently not a property:
https://github.com/interpretml/interpret-community/blob/master/python/interpret_community/mimic/models/explainable_model.py#L80
let me send a PR to fix this

did you get this error when running a surrogate model as well, instead of PFIExplainer (which is not a surrogate model and shouldn't be passed into MimicExplainer)?

it looks like you wouldn't get an error but the underlying explainer might not treat the categoricals correctly even if you did pass the correct surrogate model

@ibobak did you try passing in a surrogate model instead of PFIExplainer?  If it worked, is it ok to close this issue?  Thank you!

gentle ping @ibobak

closing this issue as it was resolved


add // tslint:disable to the top of the generated file

since the generated typescript file is most likely using different style conventions than defined and tweaked in the tslint config for the various projects the generated file should be added to it makes sense to disable tslinting that file

Makes sense! Thanks for adding it!

@Kosta-Github - Published as 1.10.2


Maximum value of maxcombine changed from 6 to 8

Variable 'maxcombine', maximum number of bytes in UTF-8, default is 2, maximum 6, I want this maximum to be 8.
From 2010 by UNICODE IVS.
UTF-8 is up to 8 bytes in the current standard.
For example, the example of a person's name: There are a lot of people who cannot distinguish even Japanese people, there are font restrictions, and it is enlarged.
Isn't the example good quality?
The Japanese interpret these as personal names and have a well-organized style.
At the same time, he concluded that it was not a real person's name.
Drama for children, prevention of duplication with real names.
In Japan, a person with the same name as a drama fits a social lynching, and obituaries are buzzed on SNS.

What is important is where did the current maximum value of 6 come from?

There are many sideways in my explanation.
There are many variants in Japanese addresses and names, and if you make a mistake between Japanese people, you will be despised as a person who lacks etiquette.

Are there any composing characters in your example?

In my understanding, 'maxcombine' is the number of code units, not bytes.
In your first sample, U+7980 U+E0100 are only two code units. No need to change 'maxcombine' to 8 in this case.
IVS is supported at least on Windows GUI with DirectWrite since 8.0.1234. See #2206 (and https://github.com/vim-jp/issues/issues/1106).
If the characters are shown in the same shape even with IVS in this environment, your font doesn't support IVS. You should use a font that support IVS.

I understand the commentary, uh, my ability has deteriorated. I'm old.
Yeah, maxCOMBINE, oh ...
Don't you call me? Don't call me ... (go quietly out of the stage)

The maximum is needed to limit the amount of memory used and performance for copying text around.
The thought was that nobody would need more than 6.
I wonder how many Vim users would use more than 6, if the limit would be increased.


[Live2D] Update shaders to work with Axmol 2 and fix Live2D test

Which branch your pull-request should merge into?

dev: Current 2.x BugFixs or Features

Describe your changes
Ensure that the Live2D extension is enabled for the Live2D test project.
Move shaders to individual files and update them to work with Axmol 2.x.
Issue ticket number and link
#1403
#1400
Checklist before requesting a review

[ ] I have performed a self-review of my code.
[ ] If it is a core feature, I have added thorough tests.
[ ] I have checked readme and add important infos to this PR (if it needed).
[ ] I have added/adapted some tests too.

Re-doing this because I'm having some issues with the placement of the shader files within the extension.


Use MaxCollateralUtilization in interest rate calculation

Depends on:

https://github.com/umee-network/umee/issues/1036

Summary
In https://github.com/umee-network/umee/pull/940 we introduced MaxCollateralUtilization and decided to use it for interest rates instead for supply utilization.

update algorithm
update tests
make sure borrows are not possible if collateral utilization goes above max collateral utilization

For Admin Use

[ ] Not duplicate issue
[ ] Appropriate labels applied
[ ] Appropriate contributors tagged
[ ] Contributor assigned/self-assigned

This can be closed - interest rates will still be based on borrow utilization, not collateral utilization.
Even assets with collateral weight = 0 (cannot be collateralized) need dynamic interest rates.

Today we have supply_utilization not borrow_utilization.
I think we should consider changing interest rates base on borrow_utilization (the new model)


Expand Selection not selecting inside quotes with multiple words

Environment data

VS Code version: Code 1.60.1 (83bd43b, 2021-09-10T17:06:57.931Z)
Extension version (available under the Extensions sidebar): Didnt fint...
OS and version: Linux x64 5.11.0-34-generic snap
Python version (& distribution if applicable, e.g. Anaconda): Python 3.6.9
Type of virtual environment used (N/A | venv | virtualenv | conda | ...): venv
Relevant/affected Python packages and their versions: N/A
Relevant/affected Python-related VS Code extensions and their versions:

Extension
Author (truncated)
Version

vscode-quick-select
dba
0.2.9

go
gol
0.27.2

intellij-idea-keybindings
k--
1.4.5

expand-region
let
0.1.4

bash-ide-vscode
mad
1.11.0

python
ms-
2021.9.1230869389

vscode-pylance
ms-
2021.9.2

jupyter
ms-
2021.8.2041215044

jupyter-keymap
ms-
1.0.0

viml
Xad
1.0.1

markdown-all-in-one
yzh
3.4.0

Value of the python.languageServer setting: Pylance

[NOTE: If you suspect that your issue is related to the Microsoft Python Language Server (python.languageServer: 'Microsoft'), please download our new language server Pylance from the VS Code marketplace to see if that fixes your issue]
Expected behaviour
In python, given the following snippet:
def render_templates(self) -> None:
"""Render templates defined in templates.json."""

if one were to put the cursor inside 'defined' see following with []:
def render_templates(self) -> None:
"""Render templates def[]ined in templates.json."""

When expanding the selection I would expect that the following would be selected:
def render_templates(self) -> None:
"""Render templates [defined] in templates.json."""

And If I were to expand selection again:
def render_templates(self) -> None:
"""[Render templates defined in templates.json.]"""

Actual behaviour
Instead the selection is the following:
def render_templates(self) -> None:
["""Render templates defined in templates.json."""]

Steps to reproduce:
[NOTE: Self-contained, minimal reproducing code samples are extremely helpful and will expedite addressing your issue]
Install the above plugins and open a Python file with above content.

Logs

Output for Python in the Output panel (View→Output, change the drop-down the upper-right of the Output panel to Python)

##########Linting Output - pylint##########

--------------------------------------------------------------------
Your code has been rated at 10.00/10 (previous run: 10.00/10, +0.00)

> ~/dev/bin/python3 -m flake8 --extend-ignore=W503 --format=%(row)d,%(col)d,%(code).1s,%(code)s:%(text)s /usr/lib/python3.6/pathlib.py
cwd: /usr/lib/python3.6
> ~/dev/bin/python3 -m flake8 --extend-ignore=W503 --format=%(row)d,%(col)d,%(code).1s,%(code)s:%(text)s /usr/lib/python3.6/pathlib.py
cwd: /usr/lib/python3.6
> ~/dev/bin/python3 -m pylint --disable C0115,C0301,C0114,W0611 "--msg-template={msg_id}:{line:3d},{column}: {obj}: {msg}" --msg-template='{line},{column},{category},{symbol}:{msg}' --reports=n --output-format=text /usr/lib/python3.6/pathlib.py
cwd: /usr/lib/python3.6
> ~/dev/bin/python3 -m pylint --disable C0115,C0301,C0114,W0611 "--msg-template={msg_id}:{line:3d},{column}: {obj}: {msg}" --msg-template='{line},{column},{category},{symbol}:{msg}' --reports=n --output-format=text /usr/lib/python3.6/pathlib.py
cwd: /usr/lib/python3.6
##########Linting Output - flake8##########
10,1,F,F401:'contextlib.contextmanager' imported but unused
32,5,E,E123:closing bracket does not match indentation of opening bracket's line
45,1,D,D205:1 blank line required between summary line and description
45,1,D,D209:Multi-line docstring closing quotes should be on a separate line
45,1,D,D400:First line should end with a period
51,5,C,C901:'_Flavour.parse_parts' is too complex (15)
90,1,D,D205:1 blank line required between summary line and description
90,1,D,D400:First line should end with a period
119,60,W,W504:line break after binary operator
125,38,W,W504:line break after binary operator
126,45,W,W504:line break after binary operator
128,9,E,E123:closing bracket does not match indentation of opening bracket's line
303,5,C,C901:'_PosixFlavour.resolve' is too complex (11)
307,9,E,E306:expected 1 blank line before a nested definition, found 0
338,41,E,E261:at least two spaces before inline comment
340,41,E,E261:at least two spaces before inline comment
378,1,D,D205:1 blank line required between summary line and description
378,1,D,D209:Multi-line docstring closing quotes should be on a separate line
378,1,D,D400:First line should end with a period
463,1,E,E305:expected 2 blank lines after class or function definition, found 1
468,1,D,D205:1 blank line required between summary line and description
468,1,D,D209:Multi-line docstring closing quotes should be on a separate line
468,1,D,D400:First line should end with a period
481,1,D,D205:1 blank line required between summary line and description
481,1,D,D209:Multi-line docstring closing quotes should be on a separate line
481,1,D,D400:First line should end with a period
537,1,E,E303:too many blank lines (3)
575,1,D,D204:1 blank line required after class docstring
575,1,D,D205:1 blank line required between summary line and description
575,1,D,D209:Multi-line docstring closing quotes should be on a separate line
575,1,D,D400:First line should end with a period
603,1,D,D204:1 blank line required after class docstring
617,1,D,D205:1 blank line required between summary line and description
617,1,D,D400:First line should end with a period
626,1,D,D105:Missing docstring in magic method
692,1,D,D205:1 blank line required between summary line and description
692,1,D,D209:Multi-line docstring closing quotes should be on a separate line
692,1,D,D400:First line should end with a period
701,1,D,D105:Missing docstring in magic method
705,1,D,D205:1 blank line required between summary line and description
705,1,D,D209:Multi-line docstring closing quotes should be on a separate line
705,1,D,D400:First line should end with a period
711,1,D,D205:1 blank line required between summary line and description
711,1,D,D209:Multi-line docstring closing quotes should be on a separate line
711,1,D,D400:First line should end with a period
715,1,D,D105:Missing docstring in magic method
733,1,D,D105:Missing docstring in magic method
738,1,D,D105:Missing docstring in magic method
745,1,D,D105:Missing docstring in magic method
750,1,D,D105:Missing docstring in magic method
755,1,D,D105:Missing docstring in magic method
760,1,D,D105:Missing docstring in magic method
773,1,D,D401:First line should be in imperative mood; try rephrasing
779,1,D,D401:First line should be in imperative mood; try rephrasing
787,1,D,D401:First line should be in imperative mood; try rephrasing
797,1,D,D401:First line should be in imperative mood; try rephrasing
806,1,D,D401:First line should be in imperative mood; try rephrasing
820,13,E,E129:visually indented line with same indent as next logical line
826,1,D,D205:1 blank line required between summary line and description
826,1,D,D400:First line should end with a period
847,1,D,D205:1 blank line required between summary line and description
847,1,D,D400:First line should end with a period
880,1,D,D205:1 blank line required between summary line and description
880,1,D,D209:Multi-line docstring closing quotes should be on a separate line
880,1,D,D400:First line should end with a period
880,1,D,D401:First line should be in imperative mood; try rephrasing
891,1,D,D205:1 blank line required between summary line and description
891,1,D,D400:First line should end with a period
898,1,D,D105:Missing docstring in magic method
901,1,D,D105:Missing docstring in magic method
906,1,D,D401:First line should be in imperative mood; try rephrasing
916,1,D,D401:First line should be in imperative mood; try rephrasing
920,1,D,D205:1 blank line required between summary line and description
920,1,D,D209:Multi-line docstring closing quotes should be on a separate line
920,1,D,D400:First line should end with a period
920,1,D,D401:First line should be in imperative mood; try rephrasing
927,1,D,D205:1 blank line required between summary line and description
927,1,D,D209:Multi-line docstring closing quotes should be on a separate line
927,1,D,D400:First line should end with a period
932,1,D,D200:One-line docstring should fit on one line with quotes
958,1,E,E305:expected 2 blank lines after class or function definition, found 1
962,1,D,D204:1 blank line required after class docstring
972,1,D,D204:1 blank line required after class docstring
985,1,D,D204:1 blank line required after class docstring
998,1,D,D102:Missing docstring in public method
1024,1,D,D105:Missing docstring in magic method
1029,1,D,D105:Missing docstring in magic method
1040,1,D,D205:1 blank line required between summary line and description
1040,1,D,D400:First line should end with a period
1052,1,D,D205:1 blank line required between summary line and description
1052,1,D,D400:First line should end with a period
1059,1,D,D205:1 blank line required between summary line and description
1059,1,D,D400:First line should end with a period
1065,1,D,D205:1 blank line required between summary line and description
1065,1,D,D400:First line should end with a period
1076,1,D,D205:1 blank line required between summary line and description
1076,1,D,D400:First line should end with a period
1090,1,D,D205:1 blank line required between summary line and description
1090,1,D,D400:First line should end with a period
1104,1,D,D205:1 blank line required between summary line and description
1104,1,D,D400:First line should end with a period
1116,1,D,D205:1 blank line required between summary line and description
1116,1,D,D400:First line should end with a period
1134,1,D,D205:1 blank line required between summary line and description
1134,1,D,D400:First line should end with a period
1154,1,D,D205:1 blank line required between summary line and description
1154,1,D,D400:First line should end with a period
1154,1,D,D402:First line should not be the function's "signature"
1161,1,D,D200:One-line docstring should fit on one line with quotes
1168,1,D,D200:One-line docstring should fit on one line with quotes
1176,1,D,D205:1 blank line required between summary line and description
1176,1,D,D400:First line should end with a period
1186,1,D,D200:One-line docstring should fit on one line with quotes
1193,1,D,D200:One-line docstring should fit on one line with quotes
1200,1,D,D200:One-line docstring should fit on one line with quotes
1209,1,D,D200:One-line docstring should fit on one line with quotes
1219,1,D,D200:One-line docstring should fit on one line with quotes
1242,1,D,D200:One-line docstring should fit on one line with quotes
1261,1,D,D200:One-line docstring should fit on one line with quotes
1261,1,D,D402:First line should not be the function's "signature"
1269,1,D,D205:1 blank line required between summary line and description
1269,1,D,D400:First line should end with a period
1278,1,D,D205:1 blank line required between summary line and description
1287,1,D,D200:One-line docstring should fit on one line with quotes
1295,1,D,D205:1 blank line required between summary line and description
1295,1,D,D400:First line should end with a period
1304,1,D,D200:One-line docstring should fit on one line with quotes
1312,1,D,D205:1 blank line required between summary line and description
1312,1,D,D400:First line should end with a period
1321,1,D,D205:1 blank line required between summary line and description
1332,1,D,D200:One-line docstring should fit on one line with quotes
1344,1,D,D200:One-line docstring should fit on one line with quotes
1357,1,D,D205:1 blank line required between summary line and description
1357,1,D,D400:First line should end with a period
1371,1,D,D200:One-line docstring should fit on one line with quotes
1383,1,D,D200:One-line docstring should fit on one line with quotes
1396,1,D,D200:One-line docstring should fit on one line with quotes
1409,1,D,D200:One-line docstring should fit on one line with quotes
1422,1,D,D200:One-line docstring should fit on one line with quotes
1435,1,D,D205:1 blank line required between summary line and description
1435,1,D,D210:No whitespaces allowed surrounding docstring text
1435,1,D,D400:First line should end with a period
1438,43,W,W504:line break after binary operator
1439,13,E,E129:visually indented line with same indent as next logical line
1447,1,D,D204:1 blank line required after class docstring
1454,1,D,D204:1 blank line required after class docstring
1460,1,D,D102:Missing docstring in public method
1463,1,D,D102:Missing docstring in public method
##########Linting Output - pylint##########
************* Module pathlib
1,0,convention,too-many-lines:Too many lines in module (1464/1000)
140,13,warning,fixme:XXX extended paths should also disable the collapsing of "."
1122,9,warning,fixme:XXX untested yet!
1127,9,warning,fixme:FIXME this must defer to the specific flavour (and, under Windows,
17,0,convention,invalid-name:Constant name "supports_symlinks" doesn't conform to UPPER_CASE naming style
19,4,error,import-error:Unable to import 'nt'
20,7,error,no-member:Module 'sys' has no 'getwindowsversion' member
21,8,error,import-error:Unable to import 'nt'
23,8,convention,invalid-name:Constant name "supports_symlinks" doesn't conform to UPPER_CASE naming style
24,8,convention,invalid-name:Constant name "_getfinalpathname" doesn't conform to UPPER_CASE naming style
26,4,convention,invalid-name:Constant name "nt" doesn't conform to UPPER_CASE naming style
44,0,refactor,useless-object-inheritance:Class '_Flavour' inherits from object, can be safely removed from bases in python3
49,20,error,no-member:Instance of '_Flavour' has no 'sep' member
51,4,convention,missing-function-docstring:Missing function or method docstring
53,14,error,no-member:Instance of '_Flavour' has no 'sep' member
54,17,error,no-member:Instance of '_Flavour' has no 'altsep' member
56,8,convention,invalid-name:Variable name "it" doesn't conform to snake_case naming style
62,29,error,no-member:Instance of '_Flavour' has no 'splitroot' member
64,20,convention,invalid-name:Variable name "x" doesn't conform to snake_case naming style
75,20,warning,redefined-outer-name:Redefining name 'part' from outer scope (line 57)
80,30,error,no-member:Instance of '_Flavour' has no 'splitroot' member
51,4,refactor,too-many-branches:Too many branches (14/12)
89,4,refactor,too-many-arguments:Too many arguments (7/5)
98,30,error,no-member:Instance of '_Flavour' has no 'casefold' member
98,53,error,no-member:Instance of '_Flavour' has no 'casefold' member
136,4,convention,missing-function-docstring:Missing function or method docstring
161,20,refactor,no-else-return:Unnecessary "else" after "return"
175,4,convention,invalid-name:Argument name "s" doesn't conform to snake_case naming style
175,4,convention,missing-function-docstring:Missing function or method docstring
175,4,refactor,no-self-use:Method could be a function
178,4,convention,missing-function-docstring:Missing function or method docstring
178,4,refactor,no-self-use:Method could be a function
181,4,convention,missing-function-docstring:Missing function or method docstring
182,8,convention,invalid-name:Variable name "s" doesn't conform to snake_case naming style
187,12,refactor,no-else-return:Unnecessary "else" after "return"
193,24,convention,invalid-name:Variable name "s" doesn't conform to snake_case naming style
196,24,convention,invalid-name:Variable name "s" doesn't conform to snake_case naming style
205,4,convention,invalid-name:Argument name "s" doesn't conform to snake_case naming style
205,4,refactor,no-self-use:Method could be a function
215,4,convention,invalid-name:Argument name "s" doesn't conform to snake_case naming style
219,4,convention,missing-function-docstring:Missing function or method docstring
231,4,convention,missing-function-docstring:Missing function or method docstring
234,8,refactor,no-else-return:Unnecessary "else" after "return"
231,4,refactor,no-self-use:Method could be a function
243,4,convention,missing-function-docstring:Missing function or method docstring
282,4,convention,missing-function-docstring:Missing function or method docstring
290,12,refactor,no-else-return:Unnecessary "else" after "return"
282,4,refactor,no-self-use:Method could be a function
297,4,convention,invalid-name:Argument name "s" doesn't conform to snake_case naming style
297,4,convention,missing-function-docstring:Missing function or method docstring
297,4,refactor,no-self-use:Method could be a function
300,4,convention,missing-function-docstring:Missing function or method docstring
300,4,refactor,no-self-use:Method could be a function
303,4,convention,missing-function-docstring:Missing function or method docstring
305,19,warning,protected-access:Access to a protected member _accessor of a client class
331,16,convention,invalid-name:Variable name "e" doesn't conform to snake_case naming style
348,4,convention,missing-function-docstring:Missing function or method docstring
348,26,warning,unused-argument:Unused argument 'parts'
348,4,refactor,no-self-use:Method could be a function
351,4,convention,missing-function-docstring:Missing function or method docstring
351,4,refactor,no-self-use:Method could be a function
357,4,convention,missing-function-docstring:Missing function or method docstring
362,16,convention,import-outside-toplevel:Import outside toplevel (pwd)
365,12,convention,import-outside-toplevel:Import outside toplevel (pwd)
369,16,warning,raise-missing-from:Consider explicitly re-raising using the 'from' keyword
357,4,refactor,no-self-use:Method could be a function
377,0,refactor,too-few-public-methods:Too few public methods (0/2)
384,4,error,no-self-argument:Method should have "self" as first argument
387,19,error,not-callable:strfunc is not callable
390,4,error,no-self-argument:Method should have "self" as first argument
392,8,convention,invalid-name:Argument name "pathobjA" doesn't conform to snake_case naming style
392,8,convention,invalid-name:Argument name "pathobjB" doesn't conform to snake_case naming style
393,19,error,not-callable:strfunc is not callable
409,31,error,no-member:Module 'os' has no 'lchmod' member; maybe 'chmod'?
411,8,convention,missing-function-docstring:Missing function or method docstring
428,12,convention,invalid-name:Argument name "a" doesn't conform to snake_case naming style
428,12,convention,invalid-name:Argument name "b" doesn't conform to snake_case naming style
428,12,convention,missing-function-docstring:Missing function or method docstring
428,12,error,no-self-argument:Method should have "self" as first argument
433,8,convention,invalid-name:Argument name "a" doesn't conform to snake_case naming style
433,8,convention,invalid-name:Argument name "b" doesn't conform to snake_case naming style
433,8,convention,missing-function-docstring:Missing function or method docstring
433,26,warning,unused-argument:Unused argument 'target_is_directory'
439,4,convention,missing-function-docstring:Missing function or method docstring
439,4,refactor,no-self-use:Method could be a function
382,0,refactor,too-few-public-methods:Too few public methods (1/2)
486,18,warning,protected-access:Access to a protected member _accessor of a client class
489,15,error,no-member:Instance of '_Selector' has no '_select_from' member; maybe 'select_from'?
467,0,refactor,too-few-public-methods:Too few public methods (1/2)
494,40,warning,unused-argument:Unused argument 'is_dir'
494,48,warning,unused-argument:Unused argument 'exists'
494,56,warning,unused-argument:Unused argument 'scandir'
494,4,refactor,no-self-use:Method could be a function
492,0,refactor,too-few-public-methods:Too few public methods (0/2)
506,19,warning,protected-access:Access to a protected member _make_child_relpath of a client class
508,20,convention,invalid-name:Variable name "p" doesn't conform to snake_case naming style
508,25,warning,protected-access:Access to a protected member _select_from of a client class
498,0,refactor,too-few-public-methods:Too few public methods (1/2)
522,12,convention,invalid-name:Variable name "cf" doesn't conform to snake_case naming style
522,17,warning,protected-access:Access to a protected member _flavour of a client class
529,31,warning,protected-access:Access to a protected member _make_child_relpath of a client class
530,28,convention,invalid-name:Variable name "p" doesn't conform to snake_case naming style
530,33,warning,protected-access:Access to a protected member _select_from of a client class
514,0,refactor,too-few-public-methods:Too few public methods (1/2)
539,23,warning,unused-argument:Unused argument 'pat'
548,27,warning,protected-access:Access to a protected member _make_child_relpath of a client class
549,24,convention,invalid-name:Variable name "p" doesn't conform to snake_case naming style
558,35,warning,protected-access:Access to a protected member _select_from of a client class
560,24,convention,invalid-name:Variable name "p" doesn't conform to snake_case naming style
537,0,refactor,too-few-public-methods:Too few public methods (1/2)
587,8,refactor,no-else-return:Unnecessary "else" after "return"
602,0,refactor,useless-object-inheritance:Class 'PurePath' inherits from object, can be safely removed from bases in python3
623,12,warning,self-cls-assignment:Invalid assignment to cls in method
636,12,convention,invalid-name:Variable name "a" doesn't conform to snake_case naming style
638,25,warning,protected-access:Access to a protected member _parts of a client class
640,16,convention,invalid-name:Variable name "a" doesn't conform to snake_case naming style
649,15,error,no-member:Class 'PurePath' has no '_flavour' member
676,8,refactor,no-else-return:Unnecessary "else" after "return"
677,32,error,no-member:Class 'PurePath' has no '_flavour' member
679,19,error,no-member:Class 'PurePath' has no '_flavour' member
687,27,error,no-member:Instance of 'PurePath' has no '_flavour' member
707,8,convention,invalid-name:Variable name "f" doesn't conform to snake_case naming style
707,12,error,no-member:Instance of 'PurePath' has no '_flavour' member
722,15,error,no-member:Instance of 'PurePath' has no '_flavour' member
730,34,error,no-member:Instance of 'PurePath' has no '_flavour' member
736,49,error,no-member:Instance of 'PurePath' has no '_flavour' member
746,46,error,no-member:Instance of 'PurePath' has no '_flavour' member
751,46,error,no-member:Instance of 'PurePath' has no '_flavour' member
756,46,error,no-member:Instance of 'PurePath' has no '_flavour' member
761,46,error,no-member:Instance of 'PurePath' has no '_flavour' member
790,8,refactor,no-else-return:Unnecessary "else" after "return"
809,8,refactor,no-else-return:Unnecessary "else" after "return"
818,27,error,no-member:Instance of 'PurePath' has no '_flavour' member
819,37,error,no-member:Instance of 'PurePath' has no '_flavour' member
819,56,error,no-member:Instance of 'PurePath' has no '_flavour' member
830,8,convention,invalid-name:Variable name "f" doesn't conform to snake_case naming style
830,12,error,no-member:Instance of 'PurePath' has no '_flavour' member
869,8,convention,invalid-name:Variable name "n" doesn't conform to snake_case naming style
870,8,convention,invalid-name:Variable name "cf" doesn't conform to snake_case naming style
870,13,error,no-member:Instance of 'PurePath' has no '_flavour' member
924,19,error,no-member:Instance of 'PurePath' has no '_flavour' member
929,15,error,no-member:Instance of 'PurePath' has no '_flavour' member
935,8,convention,invalid-name:Variable name "cf" doesn't conform to snake_case naming style
935,13,error,no-member:Instance of 'PurePath' has no '_flavour' member
937,31,error,no-member:Instance of 'PurePath' has no '_flavour' member
667,8,warning,attribute-defined-outside-init:Attribute '_drv' defined outside __init__
668,8,warning,attribute-defined-outside-init:Attribute '_root' defined outside __init__
669,8,warning,attribute-defined-outside-init:Attribute '_parts' defined outside __init__
697,12,warning,attribute-defined-outside-init:Attribute '_str' defined outside __init__
730,12,warning,attribute-defined-outside-init:Attribute '_cached_cparts' defined outside __init__
742,12,warning,attribute-defined-outside-init:Attribute '_hash' defined outside __init__
887,12,warning,attribute-defined-outside-init:Attribute '_pparts' defined outside __init__
1000,12,warning,self-cls-assignment:Invalid assignment to cls in method
998,0,warning,unused-argument:Unused argument 'kwargs'
1008,4,warning,arguments-differ:Parameters differ from overridden '_init' method
1014,29,warning,protected-access:Access to a protected member _accessor of a client class
1029,4,convention,invalid-name:Argument name "t" doesn't conform to snake_case naming style
1029,4,convention,invalid-name:Argument name "v" doesn't conform to snake_case naming style
1029,4,convention,invalid-name:Argument name "tb" doesn't conform to snake_case naming style
1032,4,refactor,no-self-use:Method could be a function
1035,22,warning,unused-argument:Unused argument 'name'
1062,19,error,no-member:Instance of 'Path' has no '_flavour' member
1062,19,warning,protected-access:Access to a protected member _flavour of a client class
1068,8,convention,invalid-name:Variable name "st" doesn't conform to snake_case naming style
1095,18,error,no-member:Instance of 'Path' has no '_flavour' member
1096,35,error,no-member:Instance of 'Path' has no '_flavour' member
1100,12,convention,invalid-name:Variable name "p" doesn't conform to snake_case naming style
1107,18,error,no-member:Instance of 'Path' has no '_flavour' member
1108,35,error,no-member:Instance of 'Path' has no '_flavour' member
1112,12,convention,invalid-name:Variable name "p" doesn't conform to snake_case naming style
1130,8,warning,protected-access:Access to a protected member _init of a client class
1141,8,convention,invalid-name:Variable name "s" doesn't conform to snake_case naming style
1141,12,error,no-member:Instance of 'Path' has no '_flavour' member
1146,12,convention,invalid-name:Variable name "s" doesn't conform to snake_case naming style
1148,17,error,no-member:Instance of 'Path' has no '_flavour' member
1150,8,warning,protected-access:Access to a protected member _init of a client class
1164,8,convention,import-outside-toplevel:Import outside toplevel (pwd)
1171,8,convention,import-outside-toplevel:Import outside toplevel (grp)
1174,4,refactor,too-many-arguments:Too many arguments (6/5)
1182,8,refactor,consider-using-with:Consider using 'with' for resource-allocating operations
1189,37,convention,invalid-name:Variable name "f" doesn't conform to snake_case naming style
1196,70,convention,invalid-name:Variable name "f" doesn't conform to snake_case naming style
1205,37,convention,invalid-name:Variable name "f" doesn't conform to snake_case naming style
1215,70,convention,invalid-name:Variable name "f" doesn't conform to snake_case naming style
1238,8,convention,invalid-name:Variable name "fd" doesn't conform to snake_case naming style
1337,8,convention,invalid-name:Variable name "e" doesn't conform to snake_case naming style
1349,8,convention,invalid-name:Variable name "e" doesn't conform to snake_case naming style
1363,8,convention,invalid-name:Variable name "e" doesn't conform to snake_case naming style
1376,8,convention,invalid-name:Variable name "e" doesn't conform to snake_case naming style
1388,8,convention,invalid-name:Variable name "e" doesn't conform to snake_case naming style
1401,8,convention,invalid-name:Variable name "e" doesn't conform to snake_case naming style
1414,8,convention,invalid-name:Variable name "e" doesn't conform to snake_case naming style
1427,8,convention,invalid-name:Variable name "e" doesn't conform to snake_case naming style
1440,22,error,no-member:Instance of 'Path' has no '_flavour' member
1030,8,warning,attribute-defined-outside-init:Attribute '_closed' defined outside __init__
984,0,refactor,too-many-public-methods:Too many public methods (35/20)

------------------------------------------------------------------
Your code has been rated at 5.52/10 (previous run: 5.52/10, +0.00)

This is #266; we don't currently support this.


fix delete message

Description
relates to https://github.com/adobe/aio-cli-plugin-app/pull/268
Types of changes

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[x] I have signed the Adobe Open Source CLA.
[x] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[x] I have read the CONTRIBUTING document.
[ ] I have added tests to cover my changes.
[x] All new and existing tests passed.

This relates to adobe/aio-cli-plugin-app/pull/268


Custom domain do not work

Details
Could you please checkout whether the setup for custom domain is correct?
The following is my domain name set on readthedocs:

The following is the setup on cloudfare:

After these setup, the following error is displayed:

Thank you for your efforts in advance.

Firstly, we do not explicitly support a top level naked domain. You would need an A record for that (your first CNAME in the picture would be for bumo.io.bumo.io, BTW) and point to our IP. That will work but we don't explicitly support it in case we want to move our IP address.
Secondly, I'm not seeing those records in DNS. It's possible this is a propagation issue and it will be resolved in time.
> dig www.bumo.io CNAME +short    # returns nothing

@davidfischer
Thank you David.
Now I changed it to as the following figure, does it work?

Very odd but I'm still not seeing this DNS record

There must be some other problem with the setup here. These DNS records are not propagating at all.
Here's some info on using a naked root domain with Cloudflare: https://blog.cloudflare.com/zone-apex-naked-domain-root-domain-cname-supp/


Control causals for shared and nonshared regions

Add ability to control the proportion of causal SNPs that occur within what has already been allocated to the shared or unshared regions of the genome in the simulation process

This has been written and it runs, it has yet to be tested


Use branch-23.10 for devcontainers workflow.

https://github.com/rapidsai/shared-action-workflows/pull/122 was merged, so the devcontainers workflow should use branch-23.10 for the release.

/merge


BUG:  URGENT LOOK INTO MERGED PRs AGAINNNN

Is there an existing issue for this?

[X] I have searched the existing issues

What happened?
THE whole site is changed again in the live links as well as the deployed version cards are gone testimoniakls look bad and lot of damage
please see it asap
@Its-Aman-Yadav  @Its-Aman-Yadav  @Its-Aman-Yadav  noticed it while deleting those small mistakes
also it shows my footer to be already there have you merged it already????
review
Record

[X] I agree to follow this project's Code of Conduct
[X] I'm a GSSOC'24 contributor
[X] I want to work on this issue

Please approve the pull request after reviewing the code. The changes made to the live website were significantly different.


Consider sorting remote libraries Outside list of default libraries

Hello !
After applying robotidy on my robot files I was left with the following file:
*** Settings ***
Library     Collections
Library     DateTime
Library     Dialogs
Library     OperatingSystem
Library     Remote    http://localhost:9050/    WITH NAME    JDBCDB2    # DB2
Library     String
Library     XML
Library     Browser
Library     RequestsLibrary
Library     Keywords/MyUtilities.py
Resource    Setup_-_Teardown/Setup.robot
Resource    Setup_-_Teardown/Teardown.robot

A so called "remote" library was in between the internal Libraries.
Would it be possible to sort remote libraries after the internal and external libraries ?
I assume the sorting is now something like:

Sort all internal known libraries
Sort all unknown libraries
Sort resources

If not, I don't understand why Browser and RequestLibrary are not sorted correctly !
Thanks in advance

Current sort order is:

Built in libraries first (Collections, DateTime and such)
Any other libraries - in order it was found in file
Resources
Variables

The reason why your remote library moved to the middle is because "Remote" is also built in library. In your case:
Library     Collections
Library     DateTime
Library     Dialogs
Library     OperatingSystem
Library     Remote    http://localhost:9050/    WITH NAME    JDBCDB2    # DB2
Library     String
Library     XML  # up to there we have built in libs
Library     Browser  # it's not built in, so goes there
Library     RequestsLibrary
Library     Keywords/MyUtilities.py

I agree though it's not that fortunate - I can exclude Remote from this behaviour (so it will stay in the order you have it already, be it last of libraries).
But since people reported that Robotidy tend to break their test due to sorting imports, starting from the next release Robotidy by default with preserve the order of imports (that can be changed to work as before). From next version in order to order imports you will need to add this configuration:
--configure OrderSettingsSection:imports_order=library,resource,variables

Implemented proposal in linked PR - see source / expected file from atests.

@bhirsz
This solution is fine for me (it's only a minor issue anyway).
When do you expect a new version to be released ?

@emakaay
By tommorow latest


fix: git has two same title in status bar

This PR fixes #152477

Please paste a screenshot of the updated menu.

Please paste a screenshot of the updated menu.

Sure, I have add in PR description

@susiwen8, thank you very much for your contribution. The approach implemented in this pull request is not ideal as it uses the tooltip of the status bar command. The problem with that is that the tooltip can change as commands are being executed which would mean that the status bar item would re-appear when the tooltip changes. I will close this pull request for now, and I will try to see if I can "group" the two status bar items similarly to the language status indicator.

Fix


[flash_ctrl] ADD FIRST CODE EXCLUSIONS

Add code exclusions defined in issue #12325.
Signed-off-by: Nikola Miladinovic<EMAIL_ADDRESS>

We can do that.Please schedule meeting tomorrow. I excluded all what is writen in #12325. This can be seen from vRefine file.

alright, let me try once more to digest it..

@tjaychen @weicaiyang @jdonjdon : We would need this PR merged as soon as possible. We need to know what elements will be covered before we write a new tests (to not hit something which has been already hit).

@tjaychen @weicaiyang : Now, only prim_tl* and scan signals are excluded. Please check and merge.

thanks @nikola-miladinovic this lgtm.


Rewrite SE examples and tests to use WebClient instead of Jersey

Rewrite all SE examples and test to use new WebClient
Relates #1498

Fixed by #1646


[Suggestion] Double Tall Crops config

Harvestable plants (such as Corn from Extra Delight) have their bottom piece "harvested" when right clicking the bottom piece. Other plants (such as rice from Farmers Delight) have direct support, but it would be cool to have dynamic support, either from an automatic detection (unsure how that would work) or just by a config list that defines what crops are double tall.

Great idea. I'll do a little investigation and report back.

Ok, I will push a release out for this in a little bit here.

Auto detecting double tall crops and doing the correct thing.

Released on both CurseForge and Modrinth.

i noticed with the corn from extra delight, when you right click the bottom piece it resets the bottom piece to age 0, instead of keeping it and resetting the age of the top block like it does when you right click the top piece. Is that something that can be fixed?
i tried doing "extradelight:corn_bottom[age=3],extradelight:corn_bottom[age=3]" in the config but the top block gets removed and doesnt regrow. doing "extradelight:corn_bottom[age=3],extradelight:corn_bottom[age=2]" is slightly better, the plant continues to grow properly, but the top block is still removed on right click harvesting the bottom block.

Thanks for the feedback. I'm going to see if I can tweak a little bit to get a better result. I may have a better way to detect double tall plants.

Ok, I took a slightly different approach. Now you can't harvest the bottom block. Try removing the config options you've added and test. It will work as expected now.


Segmentation fault when filter count is zero

In the function np2srv_get_rpc_data() in file netconf.c an initialization of the pointer variable "struct ly_set set" with NULL is missing. If the parameter filter_count is zero this leads to a segmentation fault in the cleanup when the struct is freed.

Right, fixed.

Right, fixed.


Version number is unnecessary

A version 1 feed will be a valid version 2 feed, and so on. Future versions may add things, but won’t make older feeds invalid.

What about future feeds in older readers? The spec doesn't contain a detailed processing model, but chances are that the reasonable behavior when encountering the lack of version or a version from the future is to simply ignore the version.
If that's the case (I hope it is), it would make the most sense not to declare a version at all. E.g. CSS never did and HTML no longer does. Please consider dropping the top-level version key.

Even if feed readers ignore version, it's useful for anyone looking at the feed and wondering what it is, since it links to the documentation.

Could we use something like
"format": "https://jsonfeed.org"

instead?

If you find a feed-looking thing in JSON, a Google search for "JSON feed" finds the JSONFeed spec.
If baking the spec URL into each feed is still considered useful (I don't think it is useful enough since a Google search works), I think it would be good to make it clear that such a URL is not required in the format and does not participate in processing in any way.

At some point it is likely that feed readers will need to sniff the content to determine what it is (this is made more likely by not having a jsonfeed-specific MIME type, not having a jsonfeed-specific file extension, and not having a clearly specified discoverability mechanism from HTML). Given this, it is worth designing the format to be efficiently sniffable, which means including a unique identifier early in the document. The version currently serves this purpose.

https://twitter.com/fielding/status/376835835670167552

I think we're good keeping the version URL as it is. Thanks y'all.


Aerosol variables in perfmetrics

add four variables to recipe_perfmetrics_CMIP5.yml (od550aer, od870aer, abs550aer, od550lt1aer)
simplify model definition and make recipe less verbose

Maybe we could add the option to write
additional_datasets:
  - ACCESS1-0
  - ACCESS1-3
  - bcc-csm1-1
  - bcc-csm1-1-m
  - BNU-ESM
  - {dataset: ERA-Interim, project: OBS, type: reanaly, version: 1, tier: 3}
  - {dataset: ERA-Interim, project: OBS, type: reanaly, version: 1, tier: 3}

instead of
additional_datasets:
  - {dataset: ACCESS1-0}
  - {dataset: ACCESS1-3}
  - {dataset: bcc-csm1-1}
  - {dataset: bcc-csm1-1-m}
  - {dataset: BNU-ESM}
  - {dataset: ERA-Interim, project: OBS, type: reanaly, version: 1, tier: 3}
  - {dataset: ERA-Interim, project: OBS, type: reanaly, version: 1, tier: 3}

to make it even shorter?

Wouldn't that be too cryptic? :fearful:

It shows more clearly that the model name is called dataset (e.g., if one needs that in the diagnostic script via the interface file).


Fix LightGBM Bug with SHAPRelevanzLearner

…ctor due to special chars in the feature names

Huge Thanks to @smythi93 for reporting and fixing the bug 🚀


Art: Promo/Hero image for website

Making this issue to track progress on the hero image for the webaverse.com site.
Current design specs:

Something epic
Similar in style to Tokyo Machine covers
Characters posed with logo
Rectangular aspect ratio, possibly 1920x1080
Homespace used as background #1395

Current starting refboard:

Any style references you come across will be helpful too - anything showing the actual painting style you want the final to be in. Right now I'm gearing for light overpaint, so it'll look fairly 3D and close to the actual models once they are finished, but I can make it look like an anime, or an oil painting, or whatever else if that suits the vibe better.
Just figured I'd mention that; I've been doing a ton of research and setup today and it occurred to me that there's quite a range of 'overpainted' styles. I can do styletests too, if that's be more useful - similar to how I did for the early docs images.

I made this in 30 seconds to see if it would work and I think it could. It's just a big mis-proportioned mess.

I think all of the Scott Pilgrim covers are pretty good in terms of fidelity, background, props, and characters.

If we are using 3d models as a basis, it wouldn't be quite as exaggerated as this, and we can paint it rougher than this. For a first pass I was thinking we just get a decent composition going; I think painting is the easier part.

Yeah, that all makes sense - the composition definitely will come first. I'll dig more into the Scott Pilgrim design influences too.
Are you just wanting Scilly in the image, or all the characters? I think last I heard we were doing all of them, but wanted to confirm.

Are you just wanting Scilly in the image, or all the characters? I think last I heard we were doing all of them, but wanted to confirm.

The more the merrier, including pets. Rather than trying to get any particular asset in though, I see it as more of an opportunity to make a more interesting/dynamic hero image.

Spent some time messing around with this today after the Morpher stuff; I've done all the necessary research and have a refboard ready. It's essentially splash art, so I'll approach it that way.
Tried doing block-ins with Vroid-rigged mannequins, but it honestly didn't work well. Since vroids are shadeless, I'll probably have to handpaint most of the lighting information regardless, unless I'm missing something. Tomorrow, I'm going to spend the day doing thumbnails traditionally - since most of the 3D assets aren't ready yet, I think it'll actually end up being faster overall that way, then I can maybe get some help posing the assets according to the sketch once the needed ones are made.
Uploading this just for posterity; it's not going to be ultimately useful but since I made it I may as well upload it. I left it as soon as I realized that this approach wasn't going to work for now.

So, traditional thumbnails coming tomorrow assuming there's no more needed for the Morphers, then we'll probably want to just wait for the assets to be made, since a lot of the finer points of the composition will rely on character silhouettes which we don't have quite yet.

The more the merrier, including pets. Rather than trying to get any particular asset in though, I see it as more of an opportunity to make a more interesting/dynamic hero image.

I'm def noticing a trend in the ref images - lots of characters/visual interest. I'll plan to just fill the frame with motion.

Since vroids are shadeless

By default they use an emissive material, so won't be affected by lighting etc. If you want a fixed up one, let me know, won't take long. Just needs the shader swapped out and textures reassigned

https://github.com/webaverse/app/issues/1443#issuecomment-906855918

IMO the lighting is a bit too dark and muddy here. It should be either bold and bright, or bold and dark, or better yet both of those composed together (e.g. the lisk is very dark but everything else is bright). But the aim should be crispness of they key features, rather than foggy ambiance.

A brighter sky like enviro and stronger rim lighting would probably help achieve that. Depending on what lights are being used, you can effectively change the hardness of the shadows by decreasing the Specular value and upping the power of the light itself

Prioritizing this issue, in terms of creating composed/over painted scenes with our assets to establish style which can guide the other projects. We’ll be blocking out in 3D as part of the process.
I think having at least 3 complete images would be a good goal, but this issue should run until we have enough of a volume of content to that the brand and symbols are presented clearly for replication in downstream art.
All the compositional concepts presented so far look good, and we agreed this morning to try some more downtempo/single character mundane poses too, like buying something at a vket market or sleeping, while keeping the general themes of adventure, weirdness, darkness, and games/economics.
This all very experimental so it would be great to try new techniques, but let’s not get bogged down in perfecting any idea yet.

One additional idea that would be good to try is holographic ui projected by d-bugs. This ui could show the stats of an item or a person’s level, illustrating the gamelike aspects of the universe, since the characters all know they are simulations in a game.

This all makes total sense, I'll be tackling these images this week!
A few clarifying questions:

You mentioned 3 images as a goal; what deadline do you have in mind for that? I'll adjust the process accordingly.
How experimental do you want me to get with them?
For the holographic UUI, do you want that shown in one of the images specifically, or are you referring more to a separate concept sheet?

I'm really looking forward to digging into these this week; it's going to be a blast!

You mentioned 3 images as a goal; what deadline do you have in mind for that? I'll adjust the process accordingly.

At about the same time that Vian is done with all of the avatar bases (not the generative variations).

How experimental do you want me to get with them?

They don't have to be the same style as long as they are the same assets, so trying different things would be best.

For the holographic UUI, do you want that shown in one of the images specifically, or are you referring more to a separate concept sheet?

A hero image for now, we don't need to really flesh it out.

@GaladWarder - version of the Hacker char should be ready for use for posing etc.
It's using some constraints to bones for accessories so we can easily switch them out and have a rough idea of how it'll be in game, too, but you should be able to still hide them if needed.
https://drive.google.com/drive/folders/1TamnUl-qxQbaTN_PrwTbqE5qwun5yAyh

Just putting a list here of the progress this week; since there's not a standup channel anymore.
First off, I spent a day's worth of time doing research into splash art illustration workflows and approaches - specifically as it applies to 3D>2D workflows. It looks like there are two main approaches: either it's almost entirely done in 3D (More like a 3D render), or it's greyboxed in 3D and traditionally painted over.
There are a few approaches that are in-between, which use custom shaders or materials to get a sketch-like or paint-like render, which look promising.
I spent about two day's worth of time trying to get a render out which would translate easily to overpaint; using custom shaders and node groups especially. There are some really cool setups for crosshatching or dot-tone shading (manga-style) which could work depending on the end style. I think I could also render out a two-tone render, and paint into it using the black as a shadow mask and the light as a light mask. Definitely plan to try that.
I also wanted to have something to show in the Monday meeting, so I started a very traditional illustration process for a single-character splash, using Scilly since her design is mostly locked-in. I thumbnailed out the composition, blocked in in 3D, did a rough sketch, then final linework. Next will be values, lighting, color, then rendering until it hits the point we're happy with.
Here's the linework I came up with for now, as well as a few rough block-ins for approximate color/mood/lighitng.

All is on-track for the deadline, and I have this upcoming week planned out; it'll be a longer one hours-wise. Can go over it and some other stuff not mentioned here in the meeting too so this post doesn't get too long.

In case it's useful anywhere, here is the logo I've been using.

AI file here: https://github.com/webaverse/assets/blob/master/logos.ai

Just updating here with a bunch of work; this has all been shown on the Discord and is in the Git repo.

And some shots from the most recent scene, still WIP.

I spent some time today messing with toon shaders as requested, but wasn't able to get a good result out of them; I don't think my shader knowledge is strong enough. I can revisit it but didn't want to spend too long on it unless otherwise instructed.
Overpaints for these scenes will be coming as soon as I can finish the scene itself, there was a mixup with the rock and plant assets from Dream so I am currently blocked until I can get those. Starting a new scene instead, these can be updated as soon as I'm unblockarino'd.

Adding these refs for archival purposes:

Some of the renders from the past few days, again for archival purposes. All have been uploaded to the relevant repos.


flutter_web_plugins cleanup and documentation

Provide library documentation, so that there is introductory material on https://master-api.flutter.dev/flutter/package-flutter_web_plugins_flutter_web_plugins/package-flutter_web_plugins_flutter_web_plugins-library.html

Describe the API exposed by PluginEventChannel over the message channel.

Deprecate the controller setter on PluginEventChannel in favour of a method. Having only a setter violates the Dart style guide.

Avoid creating the _EventChannelHandler when it is immediately discarded.

Assert that the arguments to listen and cancel are null, and remove corresponding TODOs.

Apply the Flutter formatting style more widely (especially to avoid left margin confusion where less indented code is nested deeper in the AST).

Add additional detail to various parts of the docs.

Use the ```dart style for API doc sample code, to get analysis.

Improve the precision of some error messages.

Remove the use of ChannelBuffers, which as far as we can tell doesn't really make sense here (they are for engine->framework buffering, so using it here introduces a bunch of weird race conditions that could send messages in unexpected directions). I think it hasn't caused any problems yet because it's pretty rare to unsubscribe from channels which is when most of teh issues would manifest.

Thanks for the review! Added label so this will land on green.


Market Data not subscribed

This might be a newbie question, but I have been reading the docs for IB API and couldn't find my answer.
I am trying to run the following code from the example provided:
stk_contract = ibConn.createStockContract("AAPL")
fut_contract = ibConn.createFuturesContract("ES", expiry="201606")
csh_contract = ibConn.createCashContract("EUR", currency="USD")
opt_contract = ibConn.createOptionContract("AAPL", expiry="20160425", strike=105.0, otype="PUT")
And when running this command:
ibConn.requestMarketData() # This gives me an error
With the following message:
2018-05-17 07:48:29,469 [ERROR] ezibpy: [#354] Requested market data is not subscribed.Delayed market data is available.Error&NYSE/STK/Top
This is simulated trading currently, and I found in the docs that I have to run a command to subscribe to market data type.
# ibConn.reqMarketDataType(3) # This is what the docs say to request delayed market data?
Interactive Brokers Doc for this: https://interactivebrokers.github.io/tws-api/market_data_type.html
Is there a similar command for ezibpy? Or do I need to contact IB for delayed market data?
I appreciate any help!

@numyio  did u solve this issue? can u share the code?  Highly appreciated!

I did find an approach around this. Please reach out again and I can get it back to you soon.

@numyio I have the same issue too. Could you pls share the code?

Thank you. I'm using erdewit/ib_insync and its working pretty well!


Example data output file to produce the (acyclic) graph

In GitLab by @vioannid on Jul 14, 2015, 17:19
give an example file that contains the necessary information that will be used to produced the graph.

In GitLab by @fbastian on Jul 14, 2015, 17:54
From the example using our prototype: http://devbgee.unil.ch/bgee/bgee?page=top_anat&data=07797cbed8d25b2757a5aa985ad58269fcad869a (you need to be behind the university firewall)
Input
To generate this page, we have generated 3 files to be provided to R:

http://devbgee.unil.ch/bgee/TopOBOFiles/results/OrganRelationships_8364.tsv: the relations is_a/part_of between organs. This is used both for performing the analysis, and for generating the graph.

First column contains ID of organs that are the "child" in a relationship, second column contains the "parents". For instance:
XAO:0003074	XAO:0003073

Means that there exist a relation: XAO:0003074 is_a/part_of XAO:0003073.
This file contains all relations between all organs, we could change it to provide relations only between terms to be displayed.

http://devbgee.unil.ch/bgee/TopOBOFiles/results/OrganNames_8364.tsv: contains the association organ ID - organ name. It allows R to generate results with names, and a graph with node labels.

Currently we provide all organ names to R, but we could change this file to provide names only for terms to be displayed.

http://devbgee.unil.ch/bgee/TopOBOFiles/results/GeneToOrgan_3f4f945e95038119390de09f801e472a983f26f8.tsv: the background for the enrichment analyses. Association between organ IDs and gene IDs. For instance:

ENSXETG00000000286	XAO:0000169

Means that gene ENSXETG00000000286 is expressed in organ XAO:0000169.
Output
R produces 2 files in return:

http://devbgee.unil.ch/bgee/TopOBOFiles/results/topOBOResult_931e180764b8046c8f64dd73326cc56def213654.tsv: the results of the analysis.
http://devbgee.unil.ch/bgee/TopOBOFiles/results/topOBOResultPDF_931e180764b8046c8f64dd73326cc56def213654.pdf: the graph displaying significant nodes.

In GitLab by @fbastian on Jul 14, 2015, 17:55
My question would be more: what information will need Cytoscape to display the graph?


Debt: Clean up Context::ICON

No longer need for const to be a hash, using data-icon attr & CSS

Fixed by f66ba9b


config.md: fix typo of context

list of strings should be replaced by array of strings
Signed-off-by: Ma Shimiao<EMAIL_ADDRESS>

@opencontainers/runtime-spec-maintainers  PTAL

LGTM

LGTM


Trcl translation fix

This PR contains a fix for translations applied via the trcl keyword for cells filled with universe lattices. Several examples of such cases can be found in #40
Underlying translations for the lattice did not include this translation and therefore were being incorrectly clipped by the bounds of the universe cell after the trcl translation is applied.

Since we still don't have a solid idea of how to test... I'll accept this change as is - LGTM!


feature: delete provider api key

Fixes #238

Can you please attach a screenshot for UI-related PRs? This way I don't have to run the code to see exactly what it looks like.

I quickly cloned it and tested it. Looks good. Next time, please attach a screenshot for UI-related PRs? This way I don't have to run the code.
Well done @adityapuri75!

Sure will add screenshot for UI related PRs, Thank you @arielweinberger 😀


Add hacky approach to get docs working in Docker

Quick and hacky approach to getting docs running in Docker for those on M1 having trouble running older Ruby version. This should be cleaned up at some point.
There is also a minor issue with termination which I believe is caused by the quick fix in the Guardfile interactor :off  may need to actually kill the container.

ditto with @chrisixion , I'm neither running M1 nor docker but these changes look sensible :ok_hand:


Can you please provide the pseudocode?

Hey, your work is so well-presented! Can you please provide the supplementary material and the pseudocode?  I would be much appreciated if you could.

Hi shuangyi,
You can find the supplementary material and the pseudocode for the importance indicator training at this link.

Hi shuangyi,
You can find the supplementary material and the pseudocode for the importance indicator training at this link.

Thanks so much!


NFT ABI

Type of change

Improvement (refactoring, restructuring repository, cleaning tech debt, ...)

Changes
The following changes have been made:

Add NFT ABI
Add Supply ABI
Add Administrator ABI
Add Burn ABI
Rename metadata to token_metadata to differentiate between contract and individual token metadata

Notes

All NFT implementations should follow the same ABI, meaning we should provide this ABI in the library.

Related Issues

Closes #55

In the current implementation it looks like we can set the admin to Option::None. Is this the desired behavior? Are there use cases for this scenario? If not we might want to rethink this functionality

I think the type should be Option<Identity> to handle the case where the admin hasn't been set yet, but the function to set the owner should just take an Identity and wrap that in an option before storing.

In the current implementation it looks like we can set the admin to Option::None. Is this the desired behavior? Are there use cases for this scenario? If not we might want to rethink this functionality

I think the type should be Option<Identity> to handle the case where the admin hasn't been set yet, but the function to set the owner should just take an Identity and wrap that in an option before storing.

I've originally implemented this where the function takes an Option in order to give the ability to revoke an admin. I believe this can be a valuable feature but if it's better to only take an Identity then I can make the change.

Also why do we need an abi and trait for Burn for example?

Burn is not part of the core functionality and is an extension. The trait gives the functionality to the core struct and the ABI allows to easily implement the functionality in a developer's contract. It also defines the function definition to ensure that other contracts may call it as well. Here's an example of using the ABI: https://github.com/FuelLabs/sway-libs/blob/aff22b4c998255638998e2de7e9b89789704c2ff/tests/src/test_projects/nft_extensions/src/main.sw#L56

To revoke admin access could the user just call set admin with the zero address or something?  Although in that case we would still interpret the NFT as having an admin and it might be a source of bugs.


Override for ctrl+r conflicts with PackageDev

PackageDev provides a symbol list for ST's JSON resource files, which use the source.json.sublime scope and are thus also matched by the context of the key binding in this package. Please change the selector to source.json - source.json.sublime.
I was getting two annoying error message dialogs with no indicator as to where they were coming from when pressing ctrl+r in my settings or key bindings file, for example, because it can't handle trailing commas in collections.

Duplicate of #127.


Adds extensible file stream function that can be used for the endpoint callback hooks

Create the ConfigManager method streamFile which can be used to abstract the streaming of files for serving new endpoints
From save_config_demo.ino
void createCustomRoute(WebServer *server) {
  server->on("/settings.html", HTTPMethod::HTTP_GET, [server](){
    configManager.streamFile(settingsHTML, mimeHTML);
  });
}

Looks good, can you rebase please.


tfrobot: rename mass-deployer directory to tfrobot

Is your feature request related to a problem? Please describe
tfrobot: rename mass-deployer directory to tfrobot
Describe the solution you'd like
tfrobot: rename mass-deployer directory to tfrobot

Verified:
Binaries under release section are named tfrobot. Also, path updated in repo to be under tfrobot not mass-deployer.
https://github.com/threefoldtech/tfgrid-sdk-go/tree/development/tfrobot


fix: Updating akv cert provider to use getSecret

Description

This PR includes:

Updating akv cert provider to use getSecret to fetch certificates for the entire chain
adding clean up step for dangling aks resources
Updated documentation to configure certificate policy on cert import
Uploaded existing test cert chain in e2e integration, inline root cert is no longer needed.

What this PR does / why we need it:
Fixes #695
Which issue(s) this PR fixes (optional, using fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when the PR gets merged):
Fixes #695
Type of change
Please delete options that are not relevant.

[ X] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Helm Chart Change (any edit/addition/update that is necessary for changes merged to the main branch)
[X ] This change requires a documentation update

How Has This Been Tested?
-Uploaded existing test cert chain in e2e integration, inline root cert is no longer needed
Manual validation includes:
- Secret with non content type
- Secret disabled
- Secret that is not a a cert
- Not enough permissions for identity
    - PEM and PCKS12 formats

Checklist:

[ ] Does the affected code have corresponding tests?
[ ] Are the changes documented, not just with inline documentation, but also with conceptual documentation such as an overview of a new feature, or task-based documentation like a tutorial? Consider if this change should be announced on your project blog.
[ ] Does this introduce breaking changes that would require an announcement or bumping the major version?
[ ] Do all new files have appropriate license header?

Post Merge Requirements

[ ] MAINTAINERS: manually trigger the "Publish Package" workflow after merging any PR that indicates Helm Chart Change

@binbin-li , @akashsinghal this PR is ready to view. Please see test section for test coverage. Since the AKS test is skipped by default, please refer to AKS run from my ratify fork. https://github.com/susanshi/ratify/actions/runs/5758871157

@binbin-li , @akashsinghal this PR is ready to view. Please see test section for test coverage. Since the AKS test is skipped by default, please refer to AKS run from my ratify fork. https://github.com/susanshi/ratify/actions/runs/5758871157

Also note i will go through this PR during the PR review meeting next week


Release new version to crates.io

Can you release new version to crates.io? There's many changes since the last release.

0.12 released as the last version with OpenCL support.
0.13 released as current git master.


Crt develop

Codecov Report

Merging #186 (dd68edd) into crt (ec75ec0) will decrease coverage by 11.43%.
The diff coverage is 0.31%.

:exclamation: Current head dd68edd differs from pull request most recent head adb7d26. Consider uploading reports for the commit adb7d26 to get more accurate results

@@             Coverage Diff             @@
##              crt     #186       +/-   ##
===========================================
- Coverage   97.77%   86.33%   -11.44%
===========================================
  Files          15       16        +1
  Lines        2423     2737      +314
===========================================
- Hits         2369     2363        -6
- Misses         54      374      +320

Impacted Files
Coverage Δ

s3transfer/crt.py
0.00% <0.00%> (ø)

s3transfer/constants.py
100.00% <100.00%> (ø)

s3transfer/compat.py
69.76% <0.00%> (-13.96%)
:arrow_down:

s3transfer/tasks.py
95.83% <0.00%> (-0.84%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ec75ec0...adb7d26. Read the comment docs.


Big operator rendering problem inside \frac

Hello,
First I would like to say WpfMath is a wonderful library. I had searched something like this for a long time.
I went into a small rendering bug when using this kind of formula: \frac{1}{\sum{a}}
The "a" is not at the right place but looks like a superscript. It happens only when the sum is under a fraction.
Best regards,
Pierre

Here's how it looks:

without \frac:

-with \frac:

Obviously something's wrong on our side.

Also, it works the same for every "big operator" (\int, \prod, etc.)

NOTE FOR IMPLEMENTORS: When fixing that, be careful not to break cases such as \frac{\sum^a_bx}{2}. With current implementation, it works okay. Although, it was broken by my initial naïve fix.

@ProSimPC, looks like I was able to fix the bug. While other maintainers are reviewing my PR, could you please tell me if it's critical for you? If it is, we could release a fix version (and push it onto NuGet) right after merging the PR.

@ForNeVeR, it's nice to see you've found the source of the bug. It not critical at all for me, I will wait for the next release.


Mobile responsive property visibility

Is there any property available for show and hide depends upon the screen sizes like mobile and desktop browsers?
ex: I have menu bar in desktop browser. Instead of  display the menu bar I want to display drawer menu in mobile devices.

There is this component https://github.com/jxnblk/hidden-styled – I'd recommend either rolling your own or adding in some CSS where you need it

@jxnblk How does Hide from hidden-styled differ from Hide in rebass?
http://jxnblk.com/rebass/components/Hide
I'm having some trouble with this in both cases, but in very different ways.
Using the rebass variant, showing the Modal with a Hide causes a UI crash: Warning: React.createElement: type is invalid -- expected a string (for built-in components) or a class/function (for composite components) but got: undefined. You likely forgot to export your component from the file it's defined in, or you might have mixed up default and named imports.
Using the hidden-styled variant, I get highly unexpected results with the CSS affecting unrelated elements (I can open an issue over there, if you like.)

Hmm it looks like Hide in rebass is simply not exported as expected from the docs:
import { Hide } from 'rebass';
console.log('Hide component:', Hide);
// -> Hide component: undefined


Review MEM chip usability

I like the way the MEM chip works, but as it is now, they are quite uninteresting, and useless. I only ever used them in 3 levels after they were unlocked, before realizing they were basically useless.
Why canot they be upgraded in a game, once bought ? i'd love to make them faster by spending bits, at least they could compete in mid to high levels and act as failsafes before the core.
I think the way they work could even be changed entirely. Here are some ideas:

MEM chips would absorb attackers until their sum reaches a limit (that could be upgraded by spending bits) then it needs to cool down: at first the limit would be 1, then 11, then 111, then 1111 etc…
The way they work could be change on every upgrade, like the ACC chips do. I don't know how that would work tho.
MEM chips could be passive chips like CLK chips, that add some kind of "protection" layers to the core with each upgrade, that can reset over time. The explanation would be that it "stocks" the information before it reaches the core.
Another passive chip idea: they would highlight attackers below a certain value (that value would rise upon upgrading the chip) that would be marked for max-damage, or double-damage…

Funny that you should see it this way, because actually I thought that the MEM chips were quite _over_powered. For example, the layout ACC --> ACC --> ACC --> MEM is quite invincible, or would be, if it wasn't for the cryptocoins that go through this without damage. But you can easily win nearly every level with that, if you don't mind losing a life.
And in combination with CLK the MEMs become still more powerful. At the moment I'm experimenting with "endless" levels, where attackers get stronger and stronger. And there you have the effect that "buy lots of MEMs and have a really fast CLK" is by far the most effective strategy. It's because of MEM swallowing everything. I'm currently trying to limit the power of MEMs by introducing "heat". That wouldn't change much in the standard or even turbo levels, but would become a nuisance if there are really many attackers with a high frequency. But otherwise it would be too easy to win every game.
So don't worry, the MEM chip might not be of much use the time it is introduced, but it becomes stronger and stronger during the game.
If you want to have upgrades for MEM chips, I think the most natural way would be "can hold more than one value". So let's say a MEM 2 chip could swallow two attackers, and after its cooldown time one slot would be emtpied and could hold another one. This would help on the lower levels. On the higher levels one would still have problems with heat, which I think is ok. I'll think about how to implement this.

Oh interesting, never experimented with that setup having ACC chips-a-plenty and a MEM chip eating the rest in the end.
Both good ideas, higher levels of MEM being able to eat more values before cooldown, and having to deal with overheat.

For example, the layout ACC --> ACC --> ACC --> MEM is quite invincible, or would be, if it wasn't for the cryptocoins that go through this without damage. But you can easily win nearly every level with that, if you don't mind losing a life.

Oh i think i get it.
To me, getting coins is not an option: it becomes the main objective. In the first levels, just getting through a level could be hard, but in the later, it wasn't really a matter of "if" but rather of "how", and specifically, with how much coins.
It became important pretty quickly in the game i think, to get back to previous levels and try to get that last coin, managing a perfect game.
So losing a life point might not be important if you just want to finish the game's missions; and MEM chips might seem overpowered to you. But if your objective is to get all the coins in all the levels, then the MEM chips are really bad.
Really depends! So they aren't so useless afterall, but to someone willing to outdo themselves, they quickly are!

Just consider it as a kind of challenge, so that the game doesn't become too easy ;)


iOS webviews in Unity app don't seem to be accessible but webview on Android are with native Talkback

Do you have any documentation on use of webviews within Unity apps with the plug-in on how iOS webviews can expose accessibility with Native VoiceOver like they are supported on Android with native Talkback.

Unfortunately, because Unity renders all its UI using its own internal renderer, there's no way to expose it to any native screen reader. The UAP takes over the screen reader functionality. It only connects to other screen readers by sending them text to read out loud with their text-to-speech functions. But neither VoiceOver nor TalkBack nor NVDA are actually accessing the UI that Unity renders.


Wait for all notifications protocols to be open before reporting opening

This is the next step towards https://github.com/paritytech/substrate/issues/5670
Should also hopefully fix https://github.com/paritytech/substrate/issues/6766
Before this PR:

When we establish a connection to a node, we try to open a legacy substream and all the notifications protocols substreams.
As soon as the legacy substream is open, we report on the API level that we are "connected" to this node, even when the notifications substreams haven't been opened yet.
If the API user tries to send a notification on a notifications protocol substream while it isn't open, this notification is instead sent on the legacy substream. This is done for backwards-compatibility reasons, in the situation where the remote doesn't support notifications substreams.

After this PR:

(same as before)
We only report the connection on the API level after the legacy substream is open and that all the notifications substreams have been either opened or refused.
(same as before)

While this change is quite small, it eliminates the possibility of using the legacy substream for notifications with a remote that does support notifications substreams.
If @romanb's diagnostic is correct, this should fix https://github.com/paritytech/substrate/issues/6766
The next step, after this PR, would be to report the connection on the API level after all the notifications substreams have been either opened or refused, no matter whether the legacy substream is open. Then, afterwards, to no longer open a legacy substream.

Err... the notifications_back_pressure test just failed on CI.

bot rebase

Did the burnin on my node. Nothing unusual or suspicious happened.

Err... the notifications_back_pressure test just failed on CI.

I've rebased the PR over https://github.com/paritytech/substrate/pull/6826, which I expect to fix the test.

The next step, after this PR, would be to report the connection on the API level after all the notifications substreams have been either opened or refused, no matter whether the legacy substream is open. Then, afterwards, to no longer open a legacy substream.

At the end, isn't it desirable to report the notification protocols as open/closed individually and independent of each other? Such that the user of the API doesn't even know whether a notification protocol is implemented as a substream or connection. It shouldn't be necessary to have the notion of "reporting a connection open/closed" on the API, is it? (I didn't look at the diff yet but wanted to do that now).

At the end, isn't it desirable to report the notification protocols as open/closed individually and independently of each other? Such that the user of the API doesn't even know whether a notification protocol is implemented as a substream or connection. It shouldn't be necessary to have the notion of "reporting a connection open/closed" on the API, should it? (I didn't look at the diff yet but wanted to do that now).

It's indeed the objective.
There are unfortunately some questions concerning the handshake.
The legacy substream sends a handshake whose content is reported on the API level. The Role of the peer, in particular, is also reported to other parts of Substrate such as GrandPa.
I've made sure a while ago that we were sending this handshake when opening the block-announces/transactions notifications substream, but I don't know yet how to change the API to properly account for these changes. We might have to special-case the block-announces/transactions protocol.

To be clear: the public-facing API of sc-network already hides all the implementation details of notifications substream. A user of the API is only informed of individual susbtreams being open and has no way to know whether there exists a connection with a certain peer.
All the uncertainties and potential refactoring only concerns the internals of sc-network.

The tricky part of this PR is that we can now be in an "intermediate stage" where some substreams are open, but we haven't notified the upper layers of it yet.
It is important, in this situation, to not poll the open substreams for incoming notifications until we have notified the upper layers, otherwise we have no choice but to discard these incoming notifications.

For what it is worth while cargo test -p sc-network gossip::tests::basic_works -- --nocapture; do :; done has not timed out the last 15 minutes.


Dark theme in app

Would be nice to stay up to date with design language. Almost all OSes mobile and desktop have dark themes now so wouldn't hurt to have a uniform color scheme across OS and apps

Done. Will be part of 1.7.0


Kills desktop effects globally

Desktop effects are killed globally when an osu-framwork application is running; Some parts like disabling decorations are fine, but transparency, wobbly windows, smooth animations for actions, etc are all disabled as long as it is running.
See also https://github.com/vignette-project/vignette/issues/223

Is this an issue you're currently having? what platform is this?

We can't deal with reports like this, sorry.

Is this an issue you're currently having? what platform is this?

Yes, this is running on Arch Linux.

We can't deal with reports like this, sorry.

Why not? Is there not enough information, or is it because it's a third-party application?

"Arch Linux" doesn't tell us anything. We need to know what WM/DE you're running.
Also, sounds like you've got some setting in your compositor allowing OpenGL applications to disable it. I know there's such a setting for KWin though I can't exactly remember whether it's fullscreen only or not.

"Arch Linux" doesn't tell us anything. We need to know what WM/DE you're running.
Also, sounds like you've got some setting in your compositor allowing OpenGL applications to disable it. I know there's such a setting for KWin though I can't exactly remember whether it's fullscreen only or not.

KDE Plasma, OpenGL 3.1, happens in windowed mode. I can't see a setting in System Settings to allow/disallow programs to forcibly disable KWin rules.

It's this "allow applications to block compositing" checkbox.

That seems to fix it. A side note from the original issue though:

For Vignette though, I'd assume that there are gonna be a lot of cases where you'd want to show yourself working on something on your desktop while having your Live2D avatar be animated in the background or something, and having the compositor disabled would be indeed a pain. But then, the issue is that the osu!framework seemingly doesn't allow not to block compositing.

From our side, it looks like we may be able to set the SDL2 flag SDL_HINT_VIDEO_X11_NET_WM_BYPASS_COMPOSITOR to 0 to prevent this behaviour.
Can you test whether the environment variable SDL_VIDEO_X11_NET_WM_BYPASS_COMPOSITOR=0 works for you @martmists-gh? I'd prefer not adding such a flag to o!f (not sure if it can actually be set during runtime in the first place), so if that works then Vignette themselves could set it.

SDL_VIDEO_X11_NET_WM_BYPASS_COMPOSITOR=0 dotnet run --project Vignette.Desktop

@smoogipoo I just tested this with the latest version of Vignette, on Arch Linux + KDE Plasma: the compositor stays enabled while running!
So I would suggest to add a feature (or instructions in a wiki somewhere) to the osu!framework that lets you choose whether you want your application to disable the compositor by default or not. It is very understandable for games as they take a lot of resources and desktop effects suck up some performance, but seeing that the osu!framework can be used for other kinds of applications, I think it should be a toggleable option.