This Portal is not supported on this server

Hey, thanks for putting effort into this project.
Could you please answer what needs to be done in order to resolve this error?
This Portal is not supported on this server. Please contact your administrator for more information (14).
This occur when trying to login at https://vpn.example.com/Login/Login

hi,
The SSL VPN Web page has been disabled. You have to ask your organization for support/enabling it.
See:
https://support.checkpoint.com/results/sk/sk110272
"Some organization would like to have their users connecting to site only with Capsule Workspace applications and not through the Mobile Access web portal and have the portal login page obscured. They disable the SSL VPN with web browsers option in the Gateway object in the dashboard but once trying to browse to the portal web page they get an error: "Error: Access denied. This Portal is not supported on this server. Please contact your Administrator for more information (14) ""


Support non-tagged rebar3 versions?

As-is we're incapable of targeting the most recent non-tagged development commit, which could be useful for nightly CI as a way to preemptively detect upcoming issues. Should we do this? The only issue I haven't solved is "how" we'd fetch the version. We could go with a fixed string, eg. latest/main/... that we'd fetch if no tagged version was found (hopefully there'll never be a tag with the development branch's name).
An idea we might borrow from gleam-lang/setup-gleam is the use of ref:main as a way to "clone" from a ref and not fetch a given tagged element.

Upon thinking further, this would imply (to not have to deal with building on our side) that a version would be released for HEAD every time it would be updated, which is not the case. Gleam does it via asdf or homebrew, which is a different process than the one we're using.

Actually (re-opening) something like ref:master could pull directly from s3://rebar3-nightly which is where the edge is found.

I think being able to pull in master or nightly is a great idea. Some people run (or would run) CI builds regularly to make sure a lib, plugin, or code base works with the latest changes in rebar3. It's all around good for the community IMO.

Agree. I open and closed then thought about it and opened again. Let's see what the kind folks at Gleam say about that, too (?)


Remove sh dependency

Currently, there's only one dependency for packer - sh. I don't see a reason to keep that dependency as it can be easily replaced with subprocess.

Doing this may make it easier to grab output from stdout.


Remove step load feature now that LoadTestShape is possible?

This was mentioned by @heyman and it would clean things up a bit. But since settings for LoadTestShape are entirely in the locust file, it has these down sides:

No option to pass step-load parameters via the UI
No option to pass step-load parameters via command line

I'm +1. If you make the PR I will approve it. No need to keep it around as deprecated even, as it hasnt been in the code base for very long. But give an explanatory error message if --step-load is passed.

OK. I'll get to it sooner or later. Or if someone else wants to do it sooner, feel free.

@max-rocket-internet Do you think you'll have time to do this? I would like to make a new release soon, and would prefer to do this first.

I will have time but not for 1-2 weeks.

Ok, I'll make a note here if I start working on it. Maybe we'll do it for next release instead.


[STORM-3055] 1.1.x remove conext connection cache

worker has already cache connection use supervisor_id + port
and if context and worker both cache connection, there can be some problem describe in jira

@pczb I have the same comments that I put on the master branch version of the pull request.

port corresponding change #2669 to 1.1.x


gc: add support for multiple snapshot labels

Allows linking to multiple snapshots within the same snapshotter. Adds support for using slash to separate content as well for consistency.
Closes #2284
This should have documentation and possibly better client support in the future. Will make a separate issue for documentation of the existing feature and this change.

Codecov Report

Merging #2286 into master will increase coverage by 0.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #2286      +/-   ##
==========================================
+ Coverage   45.51%   45.52%   +0.01%
==========================================
  Files          83       83
  Lines        9188     9190       +2
==========================================
+ Hits         4182     4184       +2
  Misses       4330     4330
  Partials      676      676

Flag
Coverage Δ

#linux
50.05% <100%> (+0.01%)
:arrow_up:

#windows
41.23% <100%> (+0.01%)
:arrow_up:

Impacted Files
Coverage Δ

metadata/gc.go
61.95% <100%> (+0.27%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7f05394...f5e3e67. Read the comment docs.

How does this correlate back to a container or some other object?  How is this different from applying a gc.root label?

I owe you an example, I can add it here to show how it is used. The difference between the root label is this label would go onto the container object, so that when the container object is removed, the labels are removed causing the snapshots to be eligible for GC if nothing else references them. If you set the root label on the snapshots, then you would also have to keep track of the relationship between container and snapshots separately, and be responsible for unsetting the root label. Note the root label has no meaning on a container since a container is always considered a root.

Ok makes sense.  Now where is the code that reads these references and makes the decision on if it should gc the snapshot or not?

@crosbymichael all that code is in metadata/gc.go. That file has the logic for the GC roots (containers, images, objects labeled as root) and all the references between objects. This change is small because the container->snapshot label reference already existed and was being used, it just expands the supported format to allow specifying it multiple times per snapshotter.

LGTM


insertWithRelated validates models before interpolation

I'm not using JSONSchema, but Joi to validate my models. I was about to use insertWithRelated and then use #id and #ref(myId.id) to add the model's new id to the nested inserts.
Then I noticed that the nested models get validated before the strings get interpolated. This seems a bit odd because the validation cannot properly assert whether the values are going to be correct. Is this intended @koskimas or is there something we can do about this so that related models only get validated after interpolation/replacement took place?

The $validate method gets an options objection as a second parameter. I only now realised this is not documented anywhere 😁. Anyways you need to honour the options.skipValidation boolean which is true when the method is called before interpolation. I know it's weird that the method is called at all when validation needs to be skipped. There are also some other issues with the validation system that I intend to fix in the near future.
The real signature of $validate
  /**
   * @throws {ValidationError}
   * @param {Object=} json
   * @param {ModelOptions=} options
   * @return {Object}
   */
  $validate(json = this, options = {}) {

  }

Oh 😁 Ok great, I will give that a go, thanks!


Prolog syntax highlight request

To support Prolog syntax highlight.
See Atom syntax highlight for example.

We aren't adding new modes to the main distribution anymore—so the recommended way to go forward would be to implement it yourself and distribute it is as separate package, say codemirror-mode-prolog.


Minor fixes, matplotlib style, gtpsf and Bayesian Blocks

Fixed: do not overwrite the XML file for the energy bins (particularly affecting the energy scale, which is used to fetch the central energy for the energy bin SED plot).
Fixed: upper limit drawing (capsize=0 messing up the arrow drawing, array of 0 and 1s not interpreted as boolean array, upper limit and lower limit inverted in matplotlib ??)
Some stylish improvements for matplotlib (use tex fonts always for consistency).
Run gtpsf in any case (it is useful for DL3 exporters for instance)
Implementation of bayesian blocks (it can be triggered with the new config option

[LightCurve]
BayesianBlocks = option('yes', 'no', default='no')

Example:


162285

Issues are used to track bugs and feature requests.
Need  help or have a general question? Ask on Stack Overflow (tag sqlite.swift).

Build Information

Include the SQLite.swift version, commit or branch experiencing the issue. 0.12.2
Mention Xcode and OS X versions affected. : 12.4
How do do you integrate SQLite.swift in your project?

manual
CocoaPods
Carthage
X Swift Package manager

General guidelines

Be as descriptive as possible.

Impossible to build a project with SQlite.swift -> AS Mac M1 not resolving module for arm64 apple simulator
Compilation error - Could not find module 'SQLite' for target 'x86_64-apple-ios-simulator'; found: arm64, arm64-apple-ios-simulator

Provide as much information needed to reliably reproduce the issue.

Every time

Attach screenshots if possible.
Better yet: attach GIFs or link to video.
Even better: link to a sample project exhibiting the issue.

Thank you very much for your answer.
I will do it using directly sqlite3 API. It will be safer for me.

With the recently released 0.13.0, is this issue still happening? If not, please close this issue.


If a non-interface class is config child, there is an error if it is @Protected

Assume that some class Container has a config child setter with argument type Child. Child is not an interface and it has annotation @Protected. These classes are invalid input to the Frank!Doc doclet, because there is no XML tag allowed for the config child setter. The doclet should produce an error for this kind of input and the build should fail.

I am not convinced that this should result in an error or failure

I discussed with @gvanbrakel on the phone. If a protected class appears as the argument of a method, then that method should not be a config child setter. This feature is handy to reduce the number of annotations needed. Assume that many classes have a registerReceiver method that takes an argument of type Receiver. If we can omit the config children by annotating class Receiver with a protected annotation, then that annotation is not needed on the registerReceiver methods.


check pcars qual / prac session 'return to pit' doesn't clear player and opponent laptimes

reported by Gianfranco - pitting in pcars (and r3e?) appears to clear the app's record of previous session laptimes

moved 'justGoneGreen' so it only forces a local data clear down in a race session. Prac and qual sessions still hold state between the 'countdown' and 'green' phases (pcars only) - should work around pcars weird behaviour here

this change appears to have helped here so closing this (may have to reopen...)


Adding events dynamically

Adding a card dynamically does not follow the alternating side rule.

@soniclvr811 could you please share minimal code to regenerate the issue? However, here you'll find an example of dynamically created timeline.

`
<mzd-timeline-content
[card]="false"
class="mzd-timeline-custom"
*ngFor="let c of data"

<mat-card class="mzd-custom">
  <mat-card-header>
    <mat-card-title>
      {{ c.status }}
    </mat-card-title>
    <mat-card-subtitle>
      {{ c.date }}
    </mat-card-subtitle>
  </mat-card-header>
  <mat-card-content>
    {{ c.text }}
  </mat-card-content>
</mat-card>

<button tsl-button color="blue" filled size="medium" (click)="addEvent()">
Add Event

<button
tsl-button
color="black"
filled
size="medium"
(click)="removeEvent()"
outline

Delete Event

`

export class VerticalTimelineChartComponent implements OnInit {
  data = [];

  constructor() {
    this.data.push(
      {
        status: 'Redlining',
        text: 'hey, this is ali',
        date: moment().format('MMMM Do YYYY')
      },
      {
        status: 'Pending',
        text: 'hey, this is ali',
        date: moment().format('MMMM Do YYYY')
      }
    );
  }

  ngOnInit(): void {}

  addEvent() {
    this.data.push({
      status: 'hi',
      text: 'testing',
      date: moment().format('MMMM Do YYYY')
    });
  }

  removeEvent() {
    this.data.pop();
  }
}

@mazid1

when i add event manually with button click, it defaults to the left side and does not alternate, as seen in the photo.

I also had this problem
What i did was to manually set all the required classes like class="no-alternate content-right"
and added a div within all content
{{child info map to here}}


WIP Update VM state pre migration

@rmohr

One test is currently failing. I've changed something with respect to the original pod scheduling behavior.

Failing test was caused by erroneously passing a pointer by reference


Updates for unlimited assets

Summary
Companion updates for https://github.com/algorand/go-algorand/pull/3652
Adds new REST endpoints and "exclude" parameter for account information endpoint, similar to https://github.com/algorand/go-algorand/pull/3542.
Update endpoint: GET /v2/accounts/{address}

Supports new query parameter “exclude”, which can be a combination of all, created-apps, created-assets, apps-local-state, assets, none
Removes empty “creator” string from AssetHolding type — was not implemented (removed associated TODO)

Update endpoint: GET /v2/assets/{asset-id}/balances

Remove "round" query parameter — I noticed support is not implemented, and the parameter was being ignored

New endpoints:
GET /v2/accounts/{address}/created-apps
GET /v2/accounts/{address}/created-assets
GET /v2/accounts/{address}/assets
GET /v2/accounts/{address}/apps-local-state

Supported query parameters: asset-id / application-id (look up a single asset), include-all (include deleted), limit, next (for pagination)

Test Plan
New tests added, existing tests should pass.

Codecov Report

Merging #900 (20c5ade) into develop (df2779c) will increase coverage by 0.46%.
The diff coverage is 76.10%.

@@             Coverage Diff             @@
##           develop     #900      +/-   ##
===========================================
+ Coverage    58.60%   59.07%   +0.46%
===========================================
  Files           38       42       +4
  Lines         4559     5645    +1086
===========================================
+ Hits          2672     3335     +663
- Misses        1557     1868     +311
- Partials       330      442     +112

Impacted Files
Coverage Δ

api/generated/common/routes.go
33.33% <ø> (ø)

idb/dummy/dummy.go
0.00% <0.00%> (ø)

idb/idb.go
71.42% <0.00%> (+12.89%)
:arrow_up:

idb/postgres/internal/encoding/types.go
66.66% <ø> (ø)

api/generated/v2/routes.go
18.92% <55.78%> (ø)

idb/postgres/postgres_migrations.go
43.11% <60.00%> (+8.01%)
:arrow_up:

...gres/internal/migrations/convert_account_data/m.go
63.15% <63.15%> (ø)

api/handlers.go
74.31% <78.18%> (+5.03%)
:arrow_up:

idb/postgres/postgres.go
60.24% <78.91%> (+10.88%)
:arrow_up:

accounting/eval_preload.go
81.13% <81.13%> (ø)

... and 42 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update df2779c...20c5ade. Read the comment docs.

I would like to suggest a change in the new implementation of GET /v2/accounts/{address}: Not to return an error if the number of apps/assets is high and instead add a message/flag to the response indicating that there are more items to instruct the user to call the new endpoints. May be an extra flag in the query.
Reason:
Assuming most of users won't have a lot of opted-in assets/apps, any UI like wallets would be able to fill the whole information with just one call to the backend.
If an error is returned, the UI must call the endpoint with exclude all and then the new apis (one for each type of information they want to retrieve) in order to get the first page of assets/apps they use.

We were concerned that for backwards compatibility reasons, giving callers a "trimmed down" account for some cases, but a full one in others, would leave them with the false impression that the account was empty, especially if they were using an older SDK.
Since most users won't have a lot of opted-in assets, like you said the error case is rare, but clear. Optimizing the number of calls for the rare error case wasn't a priority when we talked this through.
One hope we had, and considered making a requirement, was that developers would adopt exclude=all everywhere, and then only pull information about assets/apps when truly necessary. This would be the most error-proof / future-proof way to look up account information and saves the indexer a lot of unnecessary work.
For those that choose not to adopt exclude=all for their initial lookup (e.g. to check counts of opted-in assets/apps) and are willing to "risk" an optimistic exclude=none, do you think it is too onerous to have them implement the 400, then re-request flow?

Oh I re-read. So an extra flag that says "give me a trimmed version if it goes over the limit." I guess that is "exclude=sometimes" :P or some better term.. that would address the backwards compatibility concern.


FIRInstallationsAPIService - register installations request

[x] sending HTTP request and handling the response
[x] unit tests for the happy path
[ ] error cases tests (next PRs)
[ ] integration with FIRInstallationsIDController (#3168)

I am going to merge this mm/fis-api into mm/fis-master manually without squashing, so the dependent PRs will be still mergeable.


Templates in template library are shifted down when Ketcher have less than 855px width

Affected Version: Remote, Standalone
Steps to Reproduce:

Launch Ketcher.
Open Templates.
Resize window to 854px width and lower.

Expected Result:
User can see templates with different size of Ketcher.
Actual Result:
Templates are shifted down under list of templates groups.

Issue is closed as fixed


question: Using OpenThread API in Zephyr application

Hello everyone!
As I understand - currently OpenThread is implemented as L2 layer in Zephyr. The provided OT samples echo_server and echo_client use Zephyr's "standard" network API for sending and receiving packets. OpenThread code and libraries are hidden from the application.
Is it possible to use OpenThread API directly in the application?
For example, I'd like to use otNetworkTimeGet function with the OT instance that is being used in the L2 layer, to check the OpenThread network time.

Hi, @szymonnnm! I've been using OT API functions like otThreadSetNetworkName and otLinkSetChannel just by adding
#include <openthread/thread.h>
#include <openthread/link.h>

Hi,
you should be able to use OpenThread APIs, the trick is you need to obtain otInstance pointer from the networking stack. The instance pointer is encapsulated within openthread_context structure inside the network interface, I think you should be able to obtain it with a combination of net_if_get_first_by_type and net_if_l2_data.
Just keep in mind, that eventually we aim to have a proper Thread management interface in Zephyr (see https://github.com/zephyrproject-rtos/zephyr/issues/3861), so it should not be needed to use OpenThread API directly - consider it more like a bypass for current limitations.

@rlubos @jcorde Thank you very much for your responses!
Following them, I've been able to obtain the openthread_contex structure and use functions from the OpenThread API such as ex. otThreadGetNetworkName.
Unfortunately, otThreadSetNetworkName didn't work, it returns OT_ERROR_INVALID_STATE so I guess it's because according to this function's docs:
This function succeeds only when Thread protocols are disabled.

I tried to use it at the very beginning of the main function in the echo_server sample, so I guess the Thread protocol initialization happens beforehand.
As for the otNetworkTimeGet - trying to use it results in compilation error:
zephyr/ext_proj/Source/ot/include/openthread/network_time.h:87:70: error: expected ';', ',' or ')' before '&' token
 otNetworkTimeStatus otNetworkTimeGet(otInstance *aInstance, uint64_t &aNetworkTime);

I've tried to add CONFIG_CPLUSPLUS=y to the sample's prj.conf file but it didn't help.
Having Thread management interface sounds like a great feature. Who knows, maybe I would be able to contribute, but obviously I need to learn a lot of stuff related to Zephyr first.

Hi @szymonnnm.
About otThreadSetNetworkName
OpenThread automatically initializes before main. So you should stop it before modifying anything.
In my project, we were able to modify the credentials by stopping the interface first.
You can how we did it at https://github.com/CESARBR/zephyr-knot-sdk/blob/master/core/src/net.c#L115.
Please, notice that we call the functions in this sequence:

ot_config_stop()
ot_config_set()
ot_config_start()
You can find the implementation of ot_config at https://github.com/CESARBR/zephyr-knot-sdk/blob/master/core/src/ot_config.c

About otNetworkTimeGet
I don't think that you can access c++ code from a c file like that.

@szymonnnm otThreadSetEnabled(instance, false) is the API function you need, it will stop the Thread network and allow reconfiguration. Once you are done, restart the network with otThreadSetEnabled(ot_context->instance, true). The code posted by @jcorde looks like a very good example on how this should be done.
Regarding otNetworkTimeGet, for me, it looks like an obvious issue with OpenThread. To my knowledge, all OT APIs were designed to be callable from C code, yet a reference operator sneaked in. I encourage you to create an OT issue for that.

Thank you very much! Following your comments, I've been able to make it work!
As for the otNetworkTimeGet, I will create an issue in the OT repository as suggested.

Hello again, I've reported the issue with otNetworkTimeGet in the OpenThread repository here - the bug has been fixed and merged into master among many other fixes since then.
I've been trying to use the master branch of the OpenThread repo in my Zephyr application but it turns out that there have been a lot of other changes that cause Zephyr to not be compliant with the fresh version of the OpenThread, one of them (or maybe the only one) being:
/home/build/zephyr/subsys/net/lib/openthread/platform/random.c:10:10: fatal error: openthread/platform/random.h: No such file or directory
 #include <openthread/platform/random.h>

It seems to me that in the master branch of the OpenThread repo this header file has removed and instead, two other header files have been added:

<openthread/random_crypto.h>
<openthread/random_noncrypto.h>

Is there a simple way to make Zephyr compliant with these changes? Are you planning to bump the OpenThread commit used in Zephyr in the near future?
I've also tried using Zephyr's "default" OpenThread commit but with additional, cherry-picked commit (the one that resolves the otNetworkTimeGet bug) but there seems to be some problem with linking:
/opt/zephyr-sdk/arm-zephyr-eabi/bin/../lib/gcc/arm-zephyr-eabi/8.3.0/../../../../arm-zephyr-eabi/bin/ld: app/libapp.a(udp.c.obj): in function `process_udp':
/home/build/zephyr/samples/net/sockets/echo_server/src/udp.c:79: undefined reference to `otNetworkTimeGet'
collect2: error: ld returned 1 exit status

I think that the source file has been compiled properly because I can see:
CXX      api/libopenthread_ftd_a-network_time_api.o

in the building logs. Perhaps the compiled object file is not being linked to the final executable but I'm struggling to find the place in the build system where I could specify that I want to link it.

Hi @szymonnnm,
Indeed the OpenThread RNG API's were redesigned recently, so in order to update OT version in Zephyr it will need to be reimplemented on the Zephyr side - I do not see a way to avoid that. Especially, that the API update was merged before the change you're interested in. So if you have time, contributions are welcome :)
The cherry-pick approach should work though, especially that the API fix was pretty simple. I'm not sure if you've noticed, but the Network Time API implementation is conditionally compiled, based on OPENTHREAD_CONFIG_ENABLE_TIME_SYNC config, see: https://github.com/openthread/openthread/blob/787184d4bb5bd6390176fe07cad868dfd4e54365/src/core/api/network_time_api.cpp#L36
Perhaps that's the reason your linker cannot find otNetworkTimeGet? If so, you might want to enable it in https://github.com/zephyrproject-rtos/zephyr/blob/master/subsys/net/lib/openthread/platform/openthread-core-zephyr-config.h
Ideally, the API header should be protected with the same config guard, so that the build would crash at the compilation level, but apparently, it was overlooked.

@rlubos Okay, thank you very much, I think it works now.
Besides defining OPENTHREAD_CONFIG_ENABLE_TIME_SYNC in subsys/net/lib/openthread/platform/openthread-core-zephyr-config.h I also had to add the following platform functions to subsys/net/lib/openthread/platform/alarm.c so the OpenThread would be able to use them:
/**
 * Get the current time (64bits width).
 *
 * @returns The current time in microseconds.
 *
 */
uint64_t otPlatTimeGet(void)
{
    return (uint64_t)(k_uptime_get() * 1000);
}

/**
 * Get the device's XTAL accuracy.
 *
 * @returns The device's XTAL accuracy, in ppm.
 *
 */
uint16_t otPlatTimeGetXtalAccuracy(void)
{
    return XTAL_ACCURACY;
}

I defined XTAL_ACCURACY as 40 because (snippet from OpenThread examples):
#define XTAL_ACCURACY       40 // The crystal used on nRF52840PDK has ±20ppm accuracy.

Anyway, after all this fight it turned out that the otNetworkGetTime is not what I was looking for. Somehow I was hoping that it will let me get current unix epoch time when connected to a border router but it's returning the network uptime.
Maybe there is some method to force the border router (I'm using nRF example - RaspPIoT Border Router Demo) to set the network time to unix epoch and broadcast time sync message to all connected childs from time to time, but I guess that I would need to ask this question in one of the OpenThread support channels.

@szymonnnm If you have internet connectivity (which I assume you have via border router) you can try to use SNTP, there's an API in Zephyr for that, see https://github.com/zephyrproject-rtos/zephyr/blob/master/samples/net/sockets/sntp_client/src/main.c and https://github.com/zephyrproject-rtos/zephyr/blob/22f1a29185bbf6b2547103967c8e725cdb51ffa6/subsys/net/lib/sntp/sntp_simple.c. The latter should allow you to easily retrieve network time from a public server.

@rlubos Thanks you! It works like a charm!


[Bug]: Making serverStarting blank causes bot to crash instead of stop the message from being sent

What happened?
Setting serverStarting to "" causes bot to not work at all. Probably happens with the other auto-messages if I had to guess.
To fix, best two options would be to check if "" and just disable, or add a dedicated true/false option for enabling these messages.
Game Version
1.19
What platform are you using?
Fabric
Platform version
2.4.5
Config File
# This message will edited in / sent when the server finished starting
serverStarted = ""
# Message to show while the server is starting
# This will be edited to SERVER_STARTED_MSG when webhook is false
serverStarting = ""
# This message will be sent when the server was stopped
serverStopped = ""
# The message to print to discord when it was possible to detect a server crash
serverCrash = "Server Crash Detected :thinking:"

if this is still an issue, than should be fixed. I haven't looked at it in a while.


[Question] .child() for SgNode in napi is zero-based or one-based ?

As the title said.

Hi! It's zero-based. zero represents the first child.


Strange behavior when url parameters are used as url key

Since the url and the key of the url config have been split up, this behavior can be avoided easily.


Missing restrictions 2

Fix #31
Depends on et require #30.
Category "Remplissage des plans d'eau" renammed 'Vidange et remplissage des plans d'eau"=> old sensors  unavailable, new on created

Hello @sebcaps , I think I'll backport your change to use matchers myself since it will allow to easily merge such changes like this until we can merge #30


Remove the unused jQplot charting provider

Since we're using C3 for charting, this library got obsolete and it can be :scissors: :scissors: :toilet: :toilet:-ed
UI part: https://github.com/ManageIQ/manageiq-ui-classic/pull/445
Pivotal story: https://www.pivotaltracker.com/story/show/140411763

@miq-bot add_label ui, technical debt, euwe/no

Tests fail and seems a valid failure.

Fixed, I adjusted the jqplot-specific tests to work with the c3 charting.

Well we can merge this to make the tests green again. But, please, follow up and reintroduce testing of the properties that you deleted.

Well, if @PanSpagetka can show me where those things went in C3 ... but I haven't found any mentioning of the :title in the c3 report formatter :disappointed:


[regression reindex_gpfastsequence] could not create unique index "gp_fastsequence_objid_objmod_index"

Cloudberry Database version
No response
What happened
diff -I HINT: -I CONTEXT: -I GP_IGNORE: -U3 /code/gpdb_src/src/test/isolation2/expected/reindex_gpfastsequence.out /code/gpdb_src/src/test/isolation2/results/reindex_gpfastsequence.out
--- /code/gpdb_src/src/test/isolation2/expected/reindex_gpfastsequence.out	2023-08-09 08:55:49.663583934 +0000
+++ /code/gpdb_src/src/test/isolation2/results/reindex_gpfastsequence.out	2023-08-09 08:55:49.665583943 +0000
@@ -16,13 +16,14 @@

 -- The reindex_relation fault should be hit
 1&: reindex table gp_fastsequence;  <waiting ...>
+FAILED:  Forked command is not blocking; got output: ERROR:  could not create unique index "gp_fastsequence_objid_objmod_index"
+DETAIL:  Key (objid, objmod)=(98317, 2) is duplicated.
 2: select gp_wait_until_triggered_fault('reindex_relation', 1, 2);
- gp_wait_until_triggered_fault
--------------------------------
- Success:
-(1 row)
+DETAIL:  Timed-out as 10 minutes max wait happens until triggered. (gp_inject_fault.c:255)
+ERROR:  failed to inject fault: ERROR:  fault not triggered, fault name:'reindex_relation' fault type:'wait_until_triggered'
 -- The insert should for reindex in session 1
 2&: insert into test_fastseqence select i , 'aa'||i from generate_series(1,100) i;  <waiting ...>
+FAILED:  Forked command is not blocking; got output: INSERT 100

 select gp_inject_fault('reindex_relation', 'reset', 2);
  gp_inject_fault
@@ -31,9 +32,9 @@
 (1 row)

 1<:  <... completed>
-REINDEX
+FAILED:  Execution failed
 2<:  <... completed>
-INSERT 100
+FAILED:  Execution failed

 -- Validate that gp_fastsequence works as expected after reindex
 SELECT 1 AS oid_same_on_all_segs from gp_dist_random('pg_class') WHERE relname = 'gp_fastsequence_objid_objmod_index' GROUP BY oid having count(*) = (SELECT count(*) FROM gp_segment_configuration WHERE role='p' AND content > -1);

What you think should happen instead
No response
How to reproduce
https://github.com/cloudberrydb/cloudberrydb/actions/runs/5805035027/job/15739091747?pr=128
Operating System
as ci
Anything else
No response
Are you willing to submit PR?

[ ] Yes, I am willing to submit a PR!

Code of Conduct

[X] I agree to follow this project's Code of Conduct.

I have see the sql, it is even not a unique index. However show a bug with unique index. Maybe a memory leak happen.
create table test_fastseqence ( a int, b char(20)) with (appendonly = true, orientation=column);
create index test_fastseqence_idx on test_fastseqence(b);
insert into test_fastseqence select i , 'aa'||i from generate_series(1,100) i;

select gp_inject_fault_infinite('reindex_relation', 'suspend', 2);

-- The reindex_relation fault should be hit
1&: reindex table gp_fastsequence;


pull request for e2e test at 11/17/2016 02:26:03

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

optest/docs/updated_at.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


ALLUXIO2590] Fix logging style in AlluxioBlockStore

https://alluxio.atlassian.net/browse/ALLUXIO-2590
Replaced
LOG.warn("Failed to open local stream for block " + blockId + ". " + e.getMessage());
with
LOG.warn("Failed to open local stream for block {}: {}", blockId, e.getMessage());

Can one of the admins verify this patch?

@Arranius Thanks for improving the code quality!


[Bug]: Move to Postgres - Error while importing apps

Is there an existing issue for this?

[X] I have searched the existing issues

Description
We encounter a 400 Bad Request error when importing apps, which prevents input fields for datasources from appearing in the reconnect datasource modal.

Steps To Reproduce

Pull abhijeetappsmith/appsmith:ee-pg locally.
In the homepage, try to import an app.

Expected: The app should get imported successfully without any errors & the user should be able to add details in the input fields.
Actual: We see a 400 Bad request error.
Public Sample App
No response
Environment
Deploy Preview
Severity
High (Blocker to building or releasing)
Issue video log
https://jam.dev/c/0e9b6e15-f052-4ecd-a90f-6d65c21b8334
Version
Self hosted

@shadabbuchh Can you share the json file?

@shadabbuchh Can you share the json file?

OldApp_DSTesting1.9.24 (1).json
try.to.covermore.2.json

Also seeing this error popping up in the Fork application flow.

Actually, most of the flows [e.g. OAuth2.0 Datasource saving / Gsheets Datasource Saving / Fork app] are erroring out with the same error

Closing as this is fixed.


Whether Pinocchio supports closed-chain robot dynamics？

Whether Pinocchio supports closed-chain robot dynamics, such as 3-dof delta robot

Thanks for your interest in Pinocchio.
Your issue duplicates #1274.

thank you very much.


Give this package another name

Give this package another name since it is not an Hasure specific GraphQL client, or if it is, split the generic part into another package and keep the Hasura specification on this one only.

Hello.
The package aims to be a customer for Hasura including the features to come.


update to latest rugged with backend support

Alternate backend support has been in master for a while :-)

Brilliant, thanks, @tpickett66!
This was always the plan, it just took a long time for Rugged to release the necessary changes and then we kinda forgot about this :)
@JoeStanton Is this ok to merge for you? Are you on a specific version or can you check this branch builds ok for you?

Closing in favour of #4 ... thanks @tpickett66


Some menu actions trigger a relayout of the nodes when it should not

Again Moose butterfly visualization, I move nodes, then when I do either "Remove node" or "Add dependencies" (this last one specific to butterfly visualization), some of the node I moved are re-layouted.
very annoying

@LABSARI this is for you


State with empty url & hashPrefix

Hi,
I have default state (showing the homepage) that uses an empty url.
.state("HOME", {
  url: "",
  templateUrl: "home.html",
  ...
})

If I link to this state e.g. via ui-sref I always get an url with hash (and hash prefix if set) like "/mysite/#!".
I would expect just "/mysite" here.
Is there a setting or sth like this to get this behaviour?
Thx

Two things. I think you need to be using html5Mode in order to get rid of the hashbang. That is done by using the location provider
configFunc.$inject = ['$locationProvider'];

function configFunc($locationProvider) {
  // sets the location provider to html5Mode
  $locationProvider.html5Mode(true);
}

Second, I might be mistake but I believe you'll need to use at least a slash there to define the url, e.g.
url: "/"

What ^^ said


PMM-11172 merge with upstream

@michal-kralik I just discussed it with Nurlan and seems our fork doesnt make sense anymore. I will create PR for PMM repo and lets see. Ping you then for review.

After changes in PMM repo we dont need our fork anymore. Closing.

@JiriCtvrtka @BupycHuk would it make sense to archive this repo and move to the upstream module in go.mod?

@michal-kralik I already using upstream one in PMM PR and once it will be tested out pg_query_go will be archived.


Latest 0.22.1 resetRoot(saveState = true, restoreState = true) loses state when using pop

Updating to newest 0.22.1 resetRoot(saveState = true, restoreState = true) restores save states correctly but after reseting to a tab with a backstack size greater than 1 calling navigator.pop() loses state on previous screens vs going back using gesture navigation which restores everything correctly.
Steps to reproduce in chrisbanes/tivi:

Go to settings in discover (profile picture -> settings)
Scroll to Open source licenses
Scroll a bit for testing
Switch to other tab
Switch back to discover (scroll state is restored correctly)
Going back using gesture navigation restores settings scroll correctly vs tapping back icon (or 2/3 system button back) which calls pop loses scroll position

I've just added a test for this in #1454 and everything seems to be working as expected. I can't reproduce this.
Are you seeing this on any particular device? Also, are you using rememberSaveable or retained?

@chrisbanes just restested on api pre 34 and 34. Pre 34 everything looks okay but 34 seems to be the problem. Commenting out decoration param on NavigableCircuitContent seems to fix the issue on 34.

I just locally converted the test to run on device instead, and seeing the same thing, everything is passing. Try 0.21.2 or 0.22.2, as there's some fixes in there pausable state. They're not directly related to saveable state, but it wouldn't surprise me if the fix some things.

Unfortunately still seeing the issue. Here is a recording of the issue if that helps. Going back via gesture navigation works, but going back using the up arrow resets the scroll position.
Screen_recording_20240604_210457.webm

Ah so this is UI state, rather than something in the Presenter. I'll tweak the test and see what it does


Cannot enter text when creating a gist

I use Mozilla Firefox 66.0.2 with the following plugins installed:

Decentraleyes
Privacy Badger
AdBlocker Ultimate
Ghostery

Now, when I try to create a new gist, I cannot  edit the main text field - It's just disabled.
I can edit the description field and the file name field though.
On Chrome it is working perfeclty.

I'm seeing the same today with Firefox 69.0.1, uBlock Origin and the DuckDuckGo Privacy Essentials add-on.

Sorry @normoes and @kthy, this isn't actually a repo for GitHub proper. This is actually just a JavaScript client library.

Fair enough 😁 I just ended up here through Google and didn't think to check where I was posting. Sorry for the noise!


V1/V2 - Email is addressed to contributor when sigantory signs CLA for the project

Sign CCLA document from V1 or V2 corporate console
Observed that email is sent to CLA Signatory after completing docusign
However email is addressed to contributor

Verified and observed that the issue is fixed in both V1 and V2
V1

V2


[Backport 24.11]: nickel: 1.8.0 -> 1.9.1

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

nixpkgs-reviewd workflow started

Extra args: ``
Free space: true
Who asked: lucasew

TARGETS

x86_64-linux: true
x86_64-darwin: true
aarch64-darwin: true

Status and logs: https://github.com/nixosbrasil/nixpkgs-reviewd/actions/runs/12454011351

nixpkgs-review result
Generated using nixpkgs-review.
Command: nixpkgs-review pr 367328

aarch64-darwin

:white_check_mark: 3 packages built:

nickel
nickel.nls
nls

nixpkgs-review result
Generated using nixpkgs-review.
Command: nixpkgs-review pr 367328

x86_64-linux

:white_check_mark: 3 packages built:

nickel
nickel.nls
nls

nixpkgs-review result
Generated using nixpkgs-review.
Command: nixpkgs-review pr 367328

x86_64-darwin

:white_check_mark: 3 packages built:

nickel
nickel.nls
nls

I really don't like this spam.

I really don't like this spam.

That's still work in progress. Not sure how can I join the messages because each message comes from a different worker.

Should this really be backported?

On one hand you're absolutely right, on the other are we not responsible for keeping backwards compatibility of upstream software.
Backporting to 24.05? Probably no. Backporting to 24.11? IMO yes.
If the software vendor cannot keep their backwards compatibility, that's not our problem, IMO,... at least not for software like this. Kernel, bootloader and such things are another topic, but this is not mission-critical software for nix/nixpkgs, so I'd say lets backport.

I don't care enough.


Craft Plugin Store release does not include latest commits

Running ./craft assetusage/default/delete-unused from the console results in an error:
Unknown command: assetusage/default/delete-unused
When I simply run ./craft and get a list of all available commands, there's nothing listed for assetusage
Cheers.

Update: for some reason, the version in the Craft Plugin Store, even though it's listed as version 2.0.1, does not include the latest commits. I downloaded straight from the master repo and installed manually and it seems to be working correctly from there.

@daltonrooney sorry about that, just released it in 2.1.0
When i wrote the commands i was hesitant about releasing them, because damage can be done when using some unsupported plugins for assets.

Thanks, I appreciate it. I've actually been modifying the query to do things like sort by date and limit the number of results before deleting, it's been really helpful. The way you wrote the console controller made it very easy to understand!

@daltonrooney, thank you! If you have any improvements let me know or make a pull-request.


Add support for LINE

Please add support for LINE, this will help lots of people especially in Japan, Taiwan and Thailand.

Currently, LINE has no web version. You can use LINE Chrome extension.


Find command fix

Codecov Report

Merging #92 (0c7539b) into master (b75711f) will increase coverage by 0.02%.
The diff coverage is 30.00%.

:exclamation: Current head 0c7539b differs from pull request most recent head 71bb762. Consider uploading reports for the commit 71bb762 to get more accurate results

@@             Coverage Diff              @@
##             master      #92      +/-   ##
============================================
+ Coverage     49.50%   49.52%   +0.02%
- Complexity      505      508       +3
============================================
  Files           124      124
  Lines          2503     2506       +3
  Branches        323      321       -2
============================================
+ Hits           1239     1241       +2
  Misses         1176     1176
- Partials         88       89       +1

Impacted Files
Coverage Δ

...java/seedu/address/logic/commands/FindCommand.java
45.07% <ø> (ø)

...del/event/EventFieldContainsKeywordsPredicate.java
0.00% <0.00%> (ø)

...nt/EventParticipantsContainsKeywordsPredicate.java
0.00% <0.00%> (ø)

...odel/person/FieldContainsKeywordsPredicateAnd.java
0.00% <0.00%> (ø)

.../model/person/TagContainsKeywordsPredicateAnd.java
0.00% <0.00%> (ø)

...s/model/person/TagContainsKeywordsPredicateOr.java
0.00% <0.00%> (ø)

...in/java/seedu/address/logic/parser/ParserUtil.java
42.38% <20.00%> (+0.71%)
:arrow_up:

.../seedu/address/logic/parser/ArgumentTokenizer.java
86.95% <44.44%> (-10.42%)
:arrow_down:

...model/person/FieldContainsKeywordsPredicateOr.java
87.50% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b75711f...71bb762. Read the comment docs.


grpc issues with alpine linux, complete incompatibility with node 7.x.x

Environment details

OS: alpine linux
Node.js version: 6.x.x, 7.x.x
npm version: 3.10.x
@google-cloud/storage version: <= 0.5.0

Steps to reproduce
This module relies on @google-cloud/common, which, in turn, relies on grpc. This causes problems for alpine linux, since it uses muslc. On 6.x.x it is possible to compile by providing glibc wrapper around muslc, so that compatible APIs are available, on node 7.x.x it just crashes during compilation (missing 7.x.x support)
Questions are:
a) why common depends on grpc? I haven't seen a single call using it in the sub-package
b) if I'm right with (a) - could somebody refactor @google-cloud/common and make grpc an optional dependency?
c) if (b) is doable, it's possible to load optional dependencies using Object.defineProperty on "demand", which, as a result, will allow google-cloud/storage API to be freely used on any system without any effort to maintain grpc module compatibility with anything
Thanks for considering this, looking forward to your feedback

My understanding of optionalDependency means if it can't install at run time, "that's okay; our code will work without it". That's not exactly the case for us. For the APIs that use GrpcService (a class in common), we absolutely need gRPC.
I haven't heard of the solution you mentioned in point number 3. Can you elaborate on that?
I would like to find a solution where our modules that don't need gRPC don't bother trying to install it. And we are actually working towards that, as we phase out GrpcService. For now, the best solution is getting this fixed in gRPC.

basically the idea looks like this:
function demandProperty(obj, name, modPath) {
    Object.defineProperty(obj, name, {
        configurable: true,
        enumerable: true,
        get: function () {
            var mod = require(modPath);
            Object.defineProperty(obj, name, {
                configurable: false,
                enumerable: true,
                value: mod
            });
            return mod;
        }
    });
}

// grpc module
demandProperty(exports, 'grpc', 'grpc');

So grpc module is not loaded when @google-cloud/common is required, instead it will only load if and only if any of the grpc functions are actually used and required.
So going back to making this an "optional" dependency - it will allow parts of the API that don't require grpc to work. However, if something that requires that API is used node will crash. But that is expected, of course.

The problem with that is runtime vs installation time warnings. If the user can't install gRPC, it should be big and bold so that they don't try to run code that doesn't have a chance.
You're definitely right that there is a problem, which is that we have a module (google-cloud/storage) that doesn't need grpc, yet we're failing the installation because it can't install something it doesn't need. I think the way around it is by getting rid of grpc from the common module entirely.
We're heading that way, as the APIs that do need gRPC (Bigtable, Datastore, more) are switched to use a dependency directly that wraps gRPC (google-gax). This means it won't need common for the GrpcService class it exposes, or the grpc dependency at all. I can't say for sure when we'll be there, but the overhead to come up with an intermediary solution is likely too much (having two separate modules; google-cloud/common and a google-cloud/common-grpc).
gRPC is working on offering better support for Node v7, which will remedy this issue in terms of the installation failure. And as mentioned earlier, the unnecessary installation part of this issue is being worked on as well.

@callmehiphop do you think we should side-load grpc? So common still exposes GrpcService, but doesn't declare the grpc dependency itself. Instead, datastore does, and provides it as an argument to the GrpcService constructor.

+1 on removing grpc dependency from common.

@stephenplusplus I think that sounds fine to me. If we are shrinkwrapping our dependencies, couldn't we just wrap the grpc require in a try/catch and go based off that?

That's more like a runtime approach than an installation time, which offers more advantages (see https://github.com/GoogleCloudPlatform/google-cloud-node/issues/1822#issuecomment-263095390). Let me know if I misunderstood.

Ah, I see. I'm not a huge fan of the sideloading. Maybe we should just make a @google-cloud/grpc dependency that services like Datastore use and remove all the grpc related items from common.

I would rather see it named @google-cloud/common-grpc so there's no confusion between that utility package and the grpc library itself.
Here's why I think we should pursue grpc as an argument:

@google-cloud/common-grpc will require @google-cloud/common as its own dependency, as GrpcService and GrpcServiceObject inherit from Service and ServiceObject. This means a minor bump in @google-cloud/common forces a minor bump in @google-cloud/common-grpc. That's more overhead and points of failure in the release cycle.
This solution will be temporary. We will soon be able to phase out grpc from common when we incorporate google-gax, which has grpc as its own dependency. Having only a couple of files (GrpcService and GrpcServiceObject) in their own module will be inconvenient and awkward to work with. We'll inevitably want them back in the common utility module.

I would rather see it named @google-cloud/common-grpc so there's no confusion between that utility package and the grpc library itself.

👍

This means a minor bump in @google-cloud/common forces a minor bump in @google-cloud/common-grpc. That's more overhead and points of failure in the release cycle

Seems like this could be remedied by doing something like "@google-cloud/common": ">=0.9.0" and only updating the version for breaking changes instead of additive changes.

This solution will be temporary. We will soon be able to phase out grpc from common when we incorporate google-gax

That is true, but it kinda feels like a moot point considering that the side-loading approach would also be a temporary fix.

Having only a couple of files (GrpcService and GrpcServiceObject) in their own module will be inconvenient and awkward to work with. We'll inevitably want them back in the common utility module.

Not sure I follow the logic here, most of our modules only contain a few files. @google-cloud/common for example is pretty small and will only get smaller once we have completely transitioned to google-gax.

Seems like this could be remedied by doing something like "@google-cloud/common": ">=0.9.0" and only updating the version for breaking changes instead of additive changes.

I don't think that's an ideal solution, because we might intentionally break something in common 0.10 that needs to be addressed by common-grpc before its users should upgrade.

That is true, but it kinda feels like a moot point considering that the side-loading approach would also be a temporary fix.

But it's a temporary fix with no lasting side effects. We won't have to maintain an additional module.

Not sure I follow the logic here, most of our modules only contain a few files. @google-cloud/common for example is pretty small and will only get smaller once we have completely transitioned to google-gax.

Yes, small modules are good, but small modules that have identical purposes and classes with identical methods are unnecessary and more difficult to work with.
What concerns you about using grpc as an argument? For a precedent, we accept promise as an argument, which is meant to be a module, right? retryRequest accepts a request argument so that it can use a custom transport library. I'm pretty sure gax is going to accept grpc as an argument as well, or at least it was brought up in a code example at one point.

For a precedent, we accept promise as an argument, which is meant to be a module, right? retryRequest accepts a request argument so that it can use a custom transport library

IMO it's not really the same. These two allow the user to opt out of the default functionality in favor of a module with the same interface. What we are currently trying to solve is how to decouple grpc from modules that don't leverage it.

What concerns you about using grpc as an argument?

It's not elegant. It would work fine, but I can't help but feel like it's just an awkward way of handling grpc that we're willing to deal with because we think our hard dependency on it is on its way out.
IMO a new module provides a cleaner separation with more predictability.

There are some very undesirable side effects that we can avoid in the short period of time before gax is widely introduced. If the separation you're siding with is more important, let's move forward with it.

@jgeewax -- this is our issue where we discussed how we can get grpc out from the common module. Basically:

create a new module called @google-cloud/common-grpc that extends common
for our APIs that don't use gRPC, just use common
for our APIs that use gRPC, depend on common-grpc

Positives:

no wasted install times on grpc for APIs that don't need them
no failed installations when grpc can't install on modules that don't need it

Negatives:

the positives above will be nullified after we cross over to gax (#1859)-- common won't depend on grpc, because the individual service modules will depend on gax. We will end up with a module (common-grpc) that doesn't need to exist, and adds to the "spending time maintaining the module" vs "spending time developing the module" imbalance.

On what kind of a timeframe do we expect #1859 to land?

There are some outstanding questions on that issue that, once resolved, will accelerate the implementation. As far as a timeframe, I cannot comment in terms of prioritization among other tasks.

any chance this issue will get some traction?

@stephenplusplus : I think the plan of splitting common into two pieces makes perfect sense. And then eventually we should deprecate common-grpc.
That said, is there an outstanding bug somewhere with the gRPC folks to fix the underlying issue ?

If something doesn't work for a specific environment, users should report over on their issue tracker so it can be sorted out.
In this case, it's mostly a matter of wasted download time and noisy compilation that affects the majority of users. Expect traction soon!

Any idea if this issue is fixed for @google-cloud/speech too?
I am still having error
webapp_1  | module.js:568
webapp_1  |   return process.dlopen(module, path._makeLong(filename));
webapp_1  |                  ^
webapp_1  |
webapp_1  | Error: Error loading shared library ld-linux-x86-64.so.2: No such file or directory (needed by /usr/src/app/node_modules/grpc/src/node/extension_binary/grpc_node.node)
web

I'm still getting the same issue as @rajiff when trying to use the monitoring package on alpine linux. Is there a workaround for this?


Supporting FreeBSD (Add more OS recognition)

I would like to say that with add one line, shell_gpt supporting FreeBSD.
I don't know how get all BSDs family, so I put a template on file

@icaksh Thank you for the PR. I think it was fixed in one of the last updates #107 Could you please confirm it works now with new sgpt version?

Great, it works with new sgpt version!

Closed, resolved with updates PR #107


The followup parameter can come from both a GET or a POST, so... getRequest - fixes #3497

That was kind of easy. :D

Codecov Report

Merging #3525 (3163a22) into development (0ba7f62) will increase coverage by 6.11%.
The diff coverage is 100.00%.

@@                Coverage Diff                @@
##             development    #3525      +/-   ##
=================================================
+ Coverage          30.38%   36.50%   +6.11%
+ Complexity         15542     6593    -8949
=================================================
  Files                415      203     -212
  Lines              73783    37676   -36107
=================================================
- Hits               22416    13752    -8664
+ Misses             51367    23924   -27443

Impacted Files
Coverage Δ

sources/ElkArte/Controller/Post.php
34.27% <100.00%> (-6.95%)
:arrow_down:

sources/ElkArte/Notifiers/Methods/Notification.php
18.75% <0.00%> (-81.25%)
:arrow_down:

sources/ElkArte/Cache/CacheMethod/Filebased.php
10.00% <0.00%> (-80.00%)
:arrow_down:

sources/ElkArte/Notifiers/Methods/Email.php
36.36% <0.00%> (-63.64%)
:arrow_down:

sources/ElkArte/BBC/BBCParser.php
11.97% <0.00%> (-62.98%)
:arrow_down:

sources/ElkArte/BBC/HtmlParser.php
11.76% <0.00%> (-62.75%)
:arrow_down:

sources/ElkArte/Cache/CacheMethod/Apc.php
20.00% <0.00%> (-57.15%)
:arrow_down:

sources/ElkArte/DataValidator.php
25.12% <0.00%> (-56.97%)
:arrow_down:

sources/ElkArte/Database/AbstractSearch.php
10.00% <0.00%> (-55.00%)
:arrow_down:

sources/ElkArte/Search/API/Standard.php
0.00% <0.00%> (-54.93%)
:arrow_down:

... and 314 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7f2f197...3163a22. Read the comment docs.

Looks like one of many issues caused by my $req implementation.  Thanks for the find!

@Spuds should I care about the maxpain tests failing?

I had pushed a fix (yesterday) that fixed the tests (or at least should have).  There were a few issues, one was pointing to the elksite which should have been easy to remedy, but it reveled a couple of other issues with our stream and fopen handlers that I fixed.

Rebased and pushed.

Yeah, I fixed this again in another PR.  Its working but the search results, for some reason, changed a bit.  I think it was some odd regional result that I've tried to stabilize in the fix (set language etc).  Anyway going to merge this as the test error here will get sorted on its own.


on-premises Active Directory Domain Services authentication over SMB for Azure file shares

[on-premises Active Directory Domain Services authentication over SMB for Azure file shares]
I am using this public article to implement and integrate the AD DS with the azure file share
https://docs.microsoft.com/en-us/azure/storage/files/storage-files-identity-auth-active-directory-enable
you can find my environment below inside this picture

I have two Forests A and B, there is an external trust between the two forest. The AD Sync connector is installed on the Forest B
and all the computers Windows 10 are joined under the forest A so when you tried to map the file share from the client, the request goes through the Forest A (NO AD SYNC INSTALLED) to the Azure file share.
Is this setup supported? it means two forests A and B with the AD sync installed on the forest B but the clients are joined under the Forest A?
Thank you

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 7a1a9f3d-5733-012a-a0d7-c00ec21b9232
Version Independent ID: 1e70ab95-9488-5aa3-b8ef-e58b3e0067bb
Content: Enable AD DS authentication to Azure file shares
Content Source: articles/storage/files/storage-files-identity-ad-ds-enable.md
Service: storage
Sub-service: files
GitHub Login: @roygara
Microsoft Alias: rogarana

@maestrigia Thanks for your question. We are checking on this and will respond to you soon.

@maestrigia  Firstly, apologies for the delay in responding here and any inconvenience this issue may have caused.
I don’t believe this would be supported today because the credentials of the user must be synced to Azure for share-level permissions. Trust between B and A does not mean the credentials from A would be synced.
I'd recommend posting your question in https://azure.microsoft.com/en-us/support/community/ since it's not directly related to the documentation. We'll follow up there. We will now proceed to close this thread. If there are further questions regarding this matter, please tag me in your reply. We will gladly continue the discussion and we will reopen the issue.

@maestrigia Thanks for your patience. If the user identities you plan to use for authentication to Azure files are not synced to Azure AD, the scenario will not work. If you register the storage account where your file share is created in Forest B and the identities you used for authentication are synced to Azure AD through Forest A, your scenario would work. The key requirements are two:

The user identity is synced to Azure AD.
The domain controller can authenticate the user identity from the domain-joined machine.
The storage account is registered to the domain controller that is the user gets the Kerberos token.

You can refer to this section for more details on the authentication path.


OOM Issue

The following strings take more than 500ms to be tokenized:

"@Bam_cos0118 실물을 봤으닊 이러죠!!!!!!!!!꺄윽ㅇㅇ썈꺅!!!!!!!!!!!!!밤님 우주최강지구최강중국최강한국최강그리스최강호주최강미국최강북한최강ㅇ일본최강홍콩최강대만최강마카오최강아프리카최강우즈베키스탄최강!!!!존예!!!존귀!!!시라구!!!"
"한국일보 6월3일자 만평 https://t.co/nnZCJovw0w"

We also run into OOM errors when tokenizing many of these in a row.
java.lang.OutOfMemoryError: GC overhead limit exceeded
VM error: GC overhead limit exceeded

Hi @gbadiali, thanks for reporting the issue. I currently lost access to this repo so I cannot merge PRs or publish new changes. And it is actually quite complicated to apply updates in this repo to Penguin as Penguin needs to support 2 separate versions. I can give you some help if you want to fix on your side or anyone at Twitter wants to own fix.


Update TI Feed - ThreatviewioDomain-High-Confidence-Feed.md

IPRegex variables are not required within the query.

Thank you sir!

Merged.


Filter out fake commits produced by git-draw

Hi, I noticed that this tool doesn't filter fake commits producted by git-draw. Some users use this for fun for drawing stuff on their contribution line, but to do so produces fake commits that can heavility alter/pollute the results of this counter.
An example:

Thanks!

@tomas is there a way of detecting such "fake" commits?


NRQL Drop Rule Getter Function

Feature Description
Function for GetNRQLDropRule by its id. Currently there is only list function and we need to search
Describe Alternatives
Currently i use the list and search it.
The list from here
https://github.com/newrelic/newrelic-client-go/blob/main/pkg/nrqldroprules/nrqldroprules_api.go
Additional context
Also list and get for nrql alert conditions would be nice :)

Hi @tamirFireFly thanks for your request.
We don't have a get function available in the API so there's no way to implement this. I think the only option is to loop the list to find the right one.

@tamirFireFly check out this for NRQL Alert conditions:

Get https://github.com/newrelic/newrelic-client-go/blob/main/pkg/alerts/nrql_conditions.go#L387
List https://github.com/newrelic/newrelic-client-go/blob/main/pkg/alerts/nrql_conditions.go#L355

Hi @tamirFireFly we have added nrql drop Rule by ID function. Please check and make use of it GetdropRuleByID.


chore: Convert component to web component and update build workflows

CONTEXT
In order to avoid further CSS conflict issues (and therefore cast a wider compatibility net for our search component), we should mount search in a web component.
CHANGES

Mount react search button in a web component
Mount react search modal contents in a web component
Update docs site build process and scripts
Update git workflows
Update tests to work with Shadow DOM
Turn off sourcemaps in production code to reduce npm size by around 60%

@cjcenizal I fixed the regression. The root cause was a gotcha in the naming convention of the web component's observable attributes- they are all internally converted to lower case. I handled this in react-chat, but forgot to here.
I put a comment in the code after fixing this issue, so future maintainers are aware of the problem.

When I run npm i and npm run docs, I see changes to both package.json and docs/package.json. Should we commit those changes?


Set junit-jupiter as default core implementation

Maybe it's time to move to junit5 as default? Junit5 exists 5 years and I think all new projects use this particular library, not the outdated junit4. The problem is that it's not possible to remove junit4 from classpath at the moment because testcontainers uses it in the core module :-(

@skotsj This ridiculously hack actually works. Thanks for sharing, as this is way better than having Junit4 and vintage engine loaded in Junit5.

Thanks for sharing the workaround @skotsj. We have plans to remove the JUnit4 dependency in the core. However, we will completely remove any test framework dependency in the core and not replace it with the JUnit Jupiter one.
I'll close this issue as a duplicate of #970.


rustc ICE: "region_obligations not empty"

On current nightly:
   Compiling deploy v0.1.0
thread 'main' panicked at 'region_obligations not empty: [
    (
        NodeId(
            17744
        ),
        RegionObligation(sub_region='_#1r, sup_type=T1)
    )
]', librustc/infer/mod.rs:1057:9
note: Run with `RUST_BACKTRACE=1` for a backtrace.

error: internal compiler error: unexpected panic

note: the compiler unexpectedly panicked. this is a bug.

note: we would appreciate a bug report: https://github.com/rust-lang/rust/blob/master/CONTRIBUTING.md#bug-reports

note: rustc 1.28.0-nightly (01cc982e9 2018-06-24) running on x86_64-unknown-linux-gnu

note: compiler flags: -C opt-level=3 --crate-type lib

note: some of the compiler flags provided by cargo are hidden

Rust issue here: https://github.com/rust-lang/rust/issues/51649.
./rust-toolchain is a known working rustc version in the interim.

Fixed in rustc, see aforelinked issue rust-lang/rust#51649


Unable to play music from yuzu browser download list using Odyssey music player

Expected behavior
I expected that if I downloaded a music I could play the music from the download list of the app.
Actual behavior
When I play a downloaded music with odyssey music player it doesn't play.
How to reproduce

download both apps yuzu browser and odyssey music player
launch both apps and allow all permissions
on the browser download a music file
opt to play the music from the download list with odyssey music player as the preferred choice to play it
it doesn't play it

Device:  Infinix Note 4
Operating system: Android 8.1
Software Version: Yuzu browser(4.0.4)
Odyssey music player(v 1.1.13)

Recording Of The Bug
https://vimeo.com/261781825
Posted on Utopian.io -  Rewarding Open Source Contributors

Can you play music in that way using other music player?

I didn't try any other player.
I mostly use odyssey music player
On Mon, Apr 2, 2018, 14:06 Hazuki<EMAIL_ADDRESS>wrote:

Can you play music in that way using other music player?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/hazuki0x0/YuzuBrowser/issues/50#issuecomment-377925262,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AhrOEjqtsiFejYXYbl8ewpkLD2XptJTgks5tkiJmgaJpZM4TBLHG
.

If you can play with other players, there is a possibility of a bug in odyssey music player.

Let me try with other players I have
On Mon, Apr 2, 2018, 14:20 Hazuki<EMAIL_ADDRESS>wrote:

If you can play with other players, there is a possibility of a bug in
odyssey music player.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/hazuki0x0/YuzuBrowser/issues/50#issuecomment-377927628,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AhrOEqGgYfmcdmH3Y0GPC0SOzQ2x6R1Aks5tkiWbgaJpZM4TBLHG
.

I tried with some other players and it didn't work..
Should I report them as bugs or 1 fix would work for all?
On Mon, Apr 2, 2018, 14:21 Otunji Favour<EMAIL_ADDRESS>wrote:

Let me try with other players I have
On Mon, Apr 2, 2018, 14:20 Hazuki<EMAIL_ADDRESS>wrote:

If you can play with other players, there is a possibility of a bug in
odyssey music player.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/hazuki0x0/YuzuBrowser/issues/50#issuecomment-377927628,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AhrOEqGgYfmcdmH3Y0GPC0SOzQ2x6R1Aks5tkiWbgaJpZM4TBLHG
.

Thank you for trying.
It seems to be a bug in this browser.

Okay so I shouldn't bother about reporting other music players the bug
affects?
On Mon, Apr 2, 2018, 14:31 Hazuki<EMAIL_ADDRESS>wrote:

Thank you for trying.
It seems to be a bug in this browser.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/hazuki0x0/YuzuBrowser/issues/50#issuecomment-377929697,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AhrOEuVl0K2r94sboY4-XUVP74dA1jfyks5tkihNgaJpZM4TBLHG
.

Yes.
You can use the beta version (4.1.0) with the downloader changed significantly. Please check it if you like.

How can I locate the beta version
On Mon, Apr 2, 2018, 15:26 Hazuki<EMAIL_ADDRESS>wrote:

Yes.
You can use the beta version (4.1.0) with the downloader changed
significantly. Please check it if you like.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/hazuki0x0/YuzuBrowser/issues/50#issuecomment-377940727,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AhrOEsMoRgHyYR1_AoofOt35uBKNkbmEks5tkjT5gaJpZM4TBLHG
.

I'm checking it out now
On Mon, Apr 2, 2018, 15:34 Otunji Favour<EMAIL_ADDRESS>wrote:

How can I locate the beta version
On Mon, Apr 2, 2018, 15:26 Hazuki<EMAIL_ADDRESS>wrote:

Yes.
You can use the beta version (4.1.0) with the downloader changed
significantly. Please check it if you like.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/hazuki0x0/YuzuBrowser/issues/50#issuecomment-377940727,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AhrOEsMoRgHyYR1_AoofOt35uBKNkbmEks5tkjT5gaJpZM4TBLHG
.

The beta version is worse.
It says acceptable application not found
On Mon, Apr 2, 2018, 15:36 Otunji Favour<EMAIL_ADDRESS>wrote:

I'm checking it out now
On Mon, Apr 2, 2018, 15:34 Otunji Favour<EMAIL_ADDRESS>wrote:

How can I locate the beta version
On Mon, Apr 2, 2018, 15:26 Hazuki<EMAIL_ADDRESS>wrote:

Yes.
You can use the beta version (4.1.0) with the downloader changed
significantly. Please check it if you like.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/hazuki0x0/YuzuBrowser/issues/50#issuecomment-377940727,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AhrOEsMoRgHyYR1_AoofOt35uBKNkbmEks5tkjT5gaJpZM4TBLHG
.

"application not found" bug is fixed.

In a new version?
On Apr 15, 2018 12:02 PM, "Hazuki"<EMAIL_ADDRESS>wrote:
"application not found" bug is fixed.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/hazuki0x0/YuzuBrowser/issues/50#issuecomment-381397649,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AhrOErCXa5D-_3s-Wk_hbAyjFZ2gI7cFks5toyixgaJpZM4TBLHG
.

Yes. In 4.1.0

Alright thanks
On Sun, Apr 15, 2018, 12:43 PM Hazuki<EMAIL_ADDRESS>wrote:

Yes. In 4.1.0
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/hazuki0x0/YuzuBrowser/issues/50#issuecomment-381399957,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AhrOEmN3IrSTLQIBrycxX0JA-ILodFaFks5tozJJgaJpZM4TBLHG
.


⚠ Jenkins Plugins Artifactory has degraded performance

In dfb4f1c, Jenkins Plugins Artifactory (https://get.jenkins.io/plugins/artifactory/) experienced degraded performance:

HTTP code: 200
Response time: 1359 ms

Resolved: Jenkins Plugins Artifactory performance has improved in 8e59a24 after 25 minutes.


Update license to be in its own file and add screenshot

This way, it's easier for github to identify the license. Also, add friendly screenshot of the interface

Add screenshot

Add dark UI as readme screenshot


Add more links from quick start pages to API docs

In the quick-start docs and other places, wherever we refer to a Langroid class, variable or method, we should make it a hyperlink to the code document-page (and section) where it is defined, e.g.
[`DocChatAgent`][langroid.agent.special.doc_chat_agent.DocChatAgent]

in
https://github.com/langroid/langroid/blob/main/docs/quick-start/chat-agent-docs.md#answer-questions-from-a-set-of-urls

for a variable use_functions_api??

We can start with linking classes and method names, then do more granular.


CPU only support?       AttributeError: /usr/local/lib/python3.10/dist-packages/bitsandbytes/libbitsandbytes_cpu.so: undefined symbol: cdequantize_blockwise_fp32

Idk I'm running into issues when trying to load it on a computer with only cpu.
WARNING:bitsandbytes.cextension:The installed version of bitsandbytes was compiled without GPU support. 8-bit optimizers, 8-bit multiplication, and GPU quantization are unavailable.
/usr/local/lib/python3.10/dist-packages/unsloth/init.py:72: UserWarning: Unsloth: Running ldconfig /usr/lib64-nvidia to link CUDA.
warnings.warn(
/usr/local/lib/python3.10/dist-packages/unsloth/init.py:103: UserWarning: Unsloth: CUDA is not linked properly.
Try running python -m bitsandbytes then python -m xformers.info
We tried running ldconfig /usr/lib64-nvidia ourselves, but it didn't work.
You need to run in your terminal sudo ldconfig /usr/lib64-nvidia yourself, then import Unsloth.
Also try sudo ldconfig /usr/local/cuda-xx.x - find the latest cuda version.
Unsloth will still run for now, but maybe it might crash - let's hope it works!
warnings.warn(
AttributeError                            Traceback (most recent call last)
 in <cell line: 1>()
----> 1 from unsloth import FastLanguageModel
2 import torch
3 max_seq_length = 4096 # Choose any! We auto support RoPE Scaling internally!
4 dtype = None # None for auto detection. Float16 for Tesla T4, V100, Bfloat16 for Ampere+
5 load_in_4bit = True # Use 4bit quantization to reduce memory usage. Can be False.
9 frames
/usr/lib/python3.10/ctypes/init.py in getitem(self, name_or_ordinal)
390
391     def getitem(self, name_or_ordinal):
--> 392         func = self._FuncPtr((name_or_ordinal, self))
393         if not isinstance(name_or_ordinal, int):
394             func.name = name_or_ordinal
AttributeError: /usr/local/lib/python3.10/dist-packages/bitsandbytes/libbitsandbytes_cpu.so: undefined symbol: cdequantize_blockwise_fp32

Try installing bitsandbytes itself then calling python -m bitsandbytes

Tried that, been doing more digging, installing cuda all that jazz, it seems that ill just need a gpu to run unsloth :/
Well there's the google colab anyway


feat(base): update base image

Description of your changes
update base image

Fixes #
I have:

[ ] Read and followed Upbound's contribution process.
[ ] Run make reviewable to ensure this PR is ready for review.
[ ] Added backport release-x.y labels to auto-backport this PR, as appropriate.

How has this code been tested
make all
docker build . --quiet --platform=linux/amd64 --tag runtime-amd64
sha256:7dece00027fa52c1317db908994d54c77a36cc2b2e4105838f4842abc7eadee3
docker build . --quiet --platform=linux/arm64 --tag runtime-arm64
sha256:247edc0d959354caac0c83930a5f682e40e3bece2ed0988b902b8a6346a288d8
crossplane xpkg build \
                                --package-root=package \
                                --embed-runtime-image=runtime-arm64 \
                                --package-file=function-arm64.xpkg
up xpkg push "xpkg.upbound.io/upbound/function-cidr":"v0.1.0" -f "function-arm64.xpkg"
xpkg pushed to xpkg.upbound.io/upbound/function-cidr:v0.1.0

The syntax notation does not seem to be universally understood with and without docker buildkit enabled.
DOCKER_BUILDKIT=1 docker buildx build .
[+] Building 0.0s (1/1) FINISHED                                  docker:desktop-linux
 => [internal] load build definition from Dockerfile                              0.0s
 => => transferring dockerfile: 988B                                              0.0s
Dockerfile:1
--------------------
   1 | >>> syntax=docker/dockerfile:1
   2 |     # Above replaces FROM golang:1.21 as build-stage
   3 |
--------------------
ERROR: failed to solve: dockerfile parse error on line 1: unknown instruction: syntax=docker/dockerfile:1

It's the dockerfile from our function templates repo

I missed this PR before. The Dockerfile update is already solved in https://github.com/upbound/function-cidr/pull/1 where I added the similar commit  + additional change to fix and test the pipelines.  Closing.


issue #178: post inspection in fastapi

[x] route
[x] tests

[!NOTE]
Tricky one because in FastAPI we can't use Body (Json) and UpdloadFile on the same endpoint. Check About form fields.
In the future we might manage label images as their own business domain, so this is a temporary solution.

The last commit is to automatically delete blob containers after tests.


Change url to Loggly Gen2, adding support to Tags, Exception handling

Deleted old repository due to lots of conflicts. Merged all the changes in the new branch.
Changes include

Updated README to add a link to Loggly docs
Updated Loggly url to Gen2 account
Added support for tags
Supports dynamic tag values. thanks @nywilken
Added Exception Handling
Retires up to five times

Nice thanks for merging these all together. Hopefully it'll make it easier for them to accept the PR.

@psquickitjayant @nywilken So can we close https://github.com/logstash-plugins/logstash-output-loggly/pull/5 in lieu of this?

@psquickitjayant @suyograo PR https://github.com/logstash-plugins/logstash-output-loggly/pull/6 does not contain all of the changes submitted in PR https://github.com/logstash-plugins/logstash-output-loggly/pull/5 so we should not close it just yet.
@psquickitjayant your updated PR does not contain the latest plugin refactor made for testing and error handling -- see c561f069
@suyograo If PR 5 is merged would it be easier to have @psquickitjayant sync his fork with the updated upstream then update PR 6? Or should I submit my PR to @psquickitjayant and close PR 5?
thanks

@psquickitjayant can you explain the use case for the exception handling and retry logic; More specifically, could you explain which exceptions you are interested in retrying on? I think the scope of the begin/rescue is a bit too broad.
The rescue will catch and retry on any exception that is thrown within the receive method. For exceptions that indicate a hard failure (Net::HTTPBadRequest, Net::HTTPBadGateway, etc.) a retry should not be executed as they will result in the same exception. Is it possible to explicitly specify the exceptions you wish to catch?
As for the retry logic I agree with @suyograo that it should be a config option. I would also request that the retry only be executed on the post request to Loggly--unless you have a different use case. Do you know if the Loggly API has any documentation on client retries?
For exception handling I generally try to follow the practices outlined on the [Ruby-Style Guide] (https://www.relishapp.com/womply/ruby-style-guide/docs/exceptions).
Let me know if there is anything I can do to help with getting the changes from PR 5 merged into your changes or with the exception handling logic.

+1 on making it configurable. Here is a comment from a customer on two types of exceptions. We should rescue and retry on these if we can "two things I've noticed from cases is that the plugin will crash after a 502 "Bad Gateway" or Logstash will throw Timeout::Error: execution expired resulting in a crash as well."

@suyograo @nywilken  I am updating plugin to make it configurable. Retry mode will work by default unless user explicitly configures it to No / false
I think we need to add rescue for both Bad Gateway and Bad Request to prevent Logstash from crashing as mentioned by @mostlyjason
Closing this PR for now.

@psquickitjayant thanks for your work on updating the the exception handling logic. The proposed changes sound good. While you refactor the logic in this PR can we ask that PR https://github.com/logstash-plugins/logstash-output-loggly/pull/5 be merged?

@nywilken Sure, if @suyograo is fine with that. Then I can take the latest changes and update my code accordingly.


⚠ Bofrost.de has degraded performance

In 16ad864, Bofrost.de (https://www.bofrost.de) experienced degraded performance:

HTTP code: 200
Response time: 1231 ms

Resolved: Bofrost.de performance has improved in b1bc9df after 13 minutes.


WebView Bug Report

I found WebView has a bug which will affect both iOS and Android. It might be important because I believe this is the reason why we cannot use it to login to neither Google nor Live account.
Here is the detail.
If there is an onNavigationStateChange function, which is similar to the following, then we will get redundant rendering call and http request.
  onNavigationStateChange: function(navState) {
    this.setState({
      backButtonEnabled: navState.canGoBack,
      forwardButtonEnabled: navState.canGoForward,
      url: navState.url,
      status: navState.title,
      loading: navState.loading,
      scalesPageToFit: true
    });
  },

I created a test website by using NetBeans. the Following code is from index.html:

        <title>Simple Post</title>
        <meta charset="UTF-8">
        <meta name="viewport" content="width=device-width, initial-scale=1.0">

        <form action = "Confirm" method = "GET">
            <input type ="text" name="info" value="GET information">
            <input type="submit" value="Submit">
        </form>
        <form action = "Confirm" method = "POST">
            <input type ="text" name="info" value="POST information">
            <input type="submit" value="Submit">
        </form>

And the following code is from Confirm.java:
    protected void processRequest(HttpServletRequest request, HttpServletResponse response)
            throws ServletException, IOException {
        response.setContentType("text/html;charset=UTF-8");
        System.out.println("Servlet was called! Information: " + request.getParameter("info"));
        try (PrintWriter out = response.getWriter()) {
            out.println("<!DOCTYPE html>");
            out.println("");
            out.println("");
            out.println("<title>Servlet Confirm</title>");
            out.println("");
            out.println("");
            out.println("
The Information: " + request.getParameter("info") + "
");
            out.println("");
            out.println("");
        }
    }

    @Override
    protected void doGet(HttpServletRequest request, HttpServletResponse response)
            throws ServletException, IOException {
        System.out.println("Method: Get");
        processRequest(request, response);
    }

    @Override
    protected void doPost(HttpServletRequest request, HttpServletResponse response)
            throws ServletException, IOException {
        System.out.println("Method: Post");
        processRequest(request, response);
    }

If I submit the form which is using GET method, then the page will be redirect with no problem.
Console output:
-Info:   Method: Get
-Info:   Servlet was called! Information: GET information
But when submitting the form which is using POST method, then WebView will firstly send a correct Post request and then followed by a weird Get request.
Console output:
-Info:   Method: Post
-Info:   Servlet was called! Information: POST information
-Info:   Method: Get
-Info:   Servlet was called! Information: null
A quick and temporary fix for this bug is to delete onNavigationStateChange function. But I hope React Native can fix that redundant call officially on the next update.

I found WebView has a bug which will affect both iOS and Android. It might be important because I believe this is the reason why we cannot use it to login to neither Google nor Live account.
Here is the detail.
If there is an onNavigationStateChange function, which is similar to the following, then we will get redundant rendering call and http request.
  onNavigationStateChange: function(navState) {
    this.setState({
      backButtonEnabled: navState.canGoBack,
      forwardButtonEnabled: navState.canGoForward,
      url: navState.url,
      status: navState.title,
      loading: navState.loading,
      scalesPageToFit: true
    });
  },

I created a test website by using NetBeans. the Following code is from index.html:

        <title>Simple Post</title>
        <meta charset="UTF-8">
        <meta name="viewport" content="width=device-width, initial-scale=1.0">

        <form action = "Confirm" method = "GET">
            <input type ="text" name="info" value="GET information">
            <input type="submit" value="Submit">
        </form>
        <form action = "Confirm" method = "POST">
            <input type ="text" name="info" value="POST information">
            <input type="submit" value="Submit">
        </form>

And the following code is from Confirm.java:
    protected void processRequest(HttpServletRequest request, HttpServletResponse response)
            throws ServletException, IOException {
        response.setContentType("text/html;charset=UTF-8");
        System.out.println("Servlet was called! Information: " + request.getParameter("info"));
        try (PrintWriter out = response.getWriter()) {
            out.println("<!DOCTYPE html>");
            out.println("");
            out.println("");
            out.println("<title>Servlet Confirm</title>");
            out.println("");
            out.println("");
            out.println("
The Information: " + request.getParameter("info") + "
");
            out.println("");
            out.println("");
        }
    }

    @Override
    protected void doGet(HttpServletRequest request, HttpServletResponse response)
            throws ServletException, IOException {
        System.out.println("Method: Get");
        processRequest(request, response);
    }

    @Override
    protected void doPost(HttpServletRequest request, HttpServletResponse response)
            throws ServletException, IOException {
        System.out.println("Method: Post");
        processRequest(request, response);
    }

If I submit the form which is using GET method, then the page will be redirect with no problem.
Console output:
-Info:   Method: Get
-Info:   Servlet was called! Information: GET information
But when submitting the form which is using POST method, then WebView will firstly send a correct Post request and then followed by a weird Get request.
Console output:
-Info:   Method: Post
-Info:   Servlet was called! Information: POST information
-Info:   Method: Get
-Info:   Servlet was called! Information: null
A quick and temporary fix for this bug is to delete onNavigationStateChange function. But I hope React Native can fix that redundant call officially on the next update.

Would be awesome if you can send a PR to fix this

any update on this? I'm having an issue with following server redirects for an oauth2 login flow. I keep getting an issue with ssl errors however im hitting the endpoint with ssl enabled on heroku.

Couldn't find anything online to help me out either

I think this issue is stale + a dupe so I am going to close it.

Why the F??? It does work now.. at least :)


[4.x] Add viewport content scale

This PR should make it possible to scale up content with the content scale factor when the stretch mode is set to viewport. This should fix #60801.
I am fairly certain that I had a reason why I didn't include this in #52170, but really can't remember what it was. Did some quick testing and couldn't find any obvious major problems with this. 🤷
Test project: https://github.com/Calinou/godot-demo-projects/tree/multiple-resolutions-update-to-4.0/gui/multiple_resolutions?rgh-link-date=2022-05-05T17%3A37%3A13Z

Also tested it and found no issues.
Here is my MRP: WindowsTestbed.zip
According to https://docs.godotengine.org/en/latest/tutorials/rendering/multiple_resolutions.html, the Stretch Mode = Viewport  should take the "Stretch Aspect setting into account".

Thanks!


Remove deprecated use of wait. functions

Proposed Changes
The following functions have been deprecated (along with their replacements)
PollImmediateUntilWithContext is now PollUntilContextCancel
PollImmediateInfiniteWithContext is now PollUntilContextCancel
PollImmediateWithContext is now PollUntilContextTimeout
PollImmediate is now PollUntilContextTimeout
Since all of these functions that are being replaced as Immediate the immediate flag is being set as true.
Types of Changes

Verification

Testing

Linked Issues
https://github.com/k3s-io/k3s/issues/9321
User-Facing Change

Further Comments

Thank you! lgtm, one minor nit!

Ah good catch. Committed!

There is an error in the split role cluster config on this PR.


Rubocop: Show cop name

This commit adds "cop name" to the formatted output of Rubocop handler. I find it useful when I want to suppress a subset of Rubocop warnings with magic comments, e.g. # rubocop:disable Metrics/MethodLength. When the cop name is included in the output, I don't have to search for the name that corresponds to the message.

Actually I wasn't sure about how I should format the message, so I followed the style of shellcheck.
Double quote to prevent globbing and word splitting. [SC2086]

I have no particular preference.

Cheers! :beers:

Thanks!


Add username validation feature

This commit introduces a new validation rule in the service layer to ensure that usernames do not contain any special characters, enhancing the system's security and data integrity. It also includes comprehensive unit tests for the new validation logic, covering various edge cases to ensure robustness and reliability.

Enhancements are needed in error handling as the message 'Username is not valid' lacks specificity, potentially confusing users about the rules and necessary corrections.

There are the definitions of the Error variables in, domain package.
        ErrorUserUsernameIsEmpty                            error = errors.New(smodel.ErrBase + smodel.ErrSep + ErrUser + smodel.ErrSep + ErrUserName + smodel.ErrSep + ErrEmpty)
	ErrorUserUsernameIsExists                           error = errors.New(smodel.ErrBase + smodel.ErrSep + ErrUser + smodel.ErrSep + ErrUserName + smodel.ErrSep + ErrAlreadyExists)
	ErrorUserUsernameIsTooShort                         error = errors.New(smodel.ErrBase + smodel.ErrSep + ErrUser + smodel.ErrSep + ErrUserName + smodel.ErrSep + ErrTooShort)
	ErrorUserUsernameIsTooLong                          error = errors.New(smodel.ErrBase + smodel.ErrSep + ErrUser + smodel.ErrSep + ErrUserName + smodel.ErrSep + ErrTooLong)
	ErrorUserUsernameIsNotValid                         error = errors.New(smodel.ErrBase + smodel.ErrSep + ErrUser + smodel.ErrSep + ErrUserName + smodel.ErrSep + ErrNotValid)

"Username cannot contain special characters" needs to be implemented in this way too. You can find the smdol.Errbase or other declarations in model package of the shared library

Please remove;
var (
ErrorUserUsernameIsEmpty            = errors.New("username is empty")
ErrorUserUsernameIsTooShort         = errors.New("username is too short")
ErrorUserUsernameIsTooLong          = errors.New("username is too long")
ErrorUserUsernameContainsSpace      = errors.New("username contains space")
ErrorUserUsernameContainsSpecialChars = errors.New("username contains special characters")
ErrorUserUsernameContainsInvalidChars = errors.New("username contains invalid characters")
)

As in Godev's example, the name of the test suite should be the same as the name of the source package (the name of the package containing the function under test).
Also, such things should not be changed :)

Let's start fresh with a new branch and close this pull request, as the current branch and PR are causing some confusion.


[terra-avatar] Add way to convey patient is deceased to assistive technologies

Summary
Terra Avatar currently relies on color alone to convey a deceased patient avatar. This PR contains changes that adds a way for assistive technologies to convey deceased patient for non sighted users.

Closes #
Deployment Link

https://terra-core-deployed-pr-#.herokuapp.com/
Testing

Additional Details

Thank you for contributing to Terra.
@cerner/terra

Fails

:no_entry_sign:
Please include a CHANGELOG entry for each changed package this PR. Looks like a CHANGELOG is missing for:

terra-avatar

  Generated by :no_entry_sign: dangerJS against f79a5a531c655b543e85db73b1621a5c8f1584ba

@saket2403 @udaymattam @sugan2416 Please review this PR again.


No Accessories

Whilst this can be run as child bridge, there doesn't seem to be any ability to add accessories. It needs a temperature sensor/thermo stats, switches for pump, airjets etc.

Hey, sorry for the late response.
I‘m currently checking if I can reproduce the issue and provide a fix for it.

I reinstalled the plugin after moving house, and with version 1.2.0 I have no accessories. The plugin is correctly installed, it doesn't give any errors, but it doesn't show any accessories in the "Homebridge Accessories" page.
The bridge is also added to HomeKit correctly, and no accessories are even there.


fix link in docs

There is also a deprecated link here (however not in docs): https://github.com/FAIRmat-NFDI/pynxtools/blob/bda1ed33e637c3616ad4f899fb3831f04924fbe5/examples/mpes/README.md?plain=1#L33

There is also a deprecated link here (however not in docs):
https://github.com/FAIRmat-NFDI/pynxtools/blob/bda1ed33e637c3616ad4f899fb3831f04924fbe5/examples/mpes/README.md?plain=1#L33

I was anyway wondering if it makes sense to remove these READMEs for the individual plugin or at least move the content to the plugin repos. What do you think?

Probably makes sense. There are also links in the docs to the plugins. Then these could rather point to the readme, than just the repo.

Probably makes sense. There are also links in the docs to the plugins. Then these could rather point to the readme, than just the repo.

Let's remove it then. We can also start setting up rudimentary docs for pynxtools-mpes and add the content there.


:sparkles: Added error handling when inverter is not replying with success

Hey @ccmatrix coould you be so kind and test this new version as I won't be able to do that before next week?

I'll try to somehow test it tomorrow. I hope to just patch the init.py in my Home Assistant docker container. I don't have a dedicated debugging environment setup yet. I'll let you know

Yea, I mean there's no handling of the error in the HA integration, but if you get this error instead of the TypeError, it's working. Thank you already for your effort!

The error is thrown as expected:
This error originated from a custom integration.

Logger: custom_components.apsystemsapi_local
Source: custom_components/apsystemsapi_local/__init__.py:103
integration: APsystems Local API
First occurred: 12:40:53 (4 occurrences)
Last logged: 15:15:53

Unexpected error fetching APSystems Data data
Traceback (most recent call last):
  File "/config/custom_components/apsystemsapi_local/__init__.py", line 103, in _async_refresh
    self.data = await self._async_update_data()
                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/config/custom_components/apsystemsapi_local/__init__.py", line 77, in _async_update_data
    data = await self.api.get_output_data()
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.12/site-packages/APsystemsEZ1/__init__.py", line 168, in get_output_data
    response = await self._request("getOutputData")
               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.12/site-packages/APsystemsEZ1/__init__.py", line 79, in _request
    raise InverterReturnedError
APsystemsEZ1.InverterReturnedError

I did check some other custom components and how they handle something like this and one pattern I liked was this:

The request method has a parameter retry that is set to True or not set (default value)
If the request fails and retry is True the method does one recursive call to itself with the same request parameters and retry set to false.
If the request fails again then retry is false and the error is raised.

This way, there is always a single retry for an error and since the error happens infrequently it would recover without crashing through. If you want I can try to refactor the request method for this pattern and test it out.

I'm testing this code for _request to see how that goes:
    async def _request(self, endpoint: str, retry: bool = True) -> dict | None:
        """
        A private method to send HTTP requests to the specified endpoint of the microinverter.
        This method is used internally by other class methods to perform GET or POST requests.

        :param endpoint: The API endpoint to make the request to.

        :return: The JSON response from the microinverter as a dictionary.
        :raises: Prints an error message if the HTTP request fails for any reason.
        """
        url = f"{self.base_url}/{endpoint}"
        async with ClientSession() as ses, ses.get(url, timeout=self.timeout) as resp:
            if resp.status != 200:
                raise HttpBadRequest(f"HTTP Error: {resp.status}")
            data = await resp.json()
            if data["message"] == "SUCCESS":
                return data
            if retry:
                return await self._request(endpoint, retry=False)
            raise InverterReturnedError

That sounds like a good idea. Will add that and thanks for taking your time helping me!