Toggle Buttons do not stack well on small screen

I did a couple of @media #{phone} {} overrides
.button-group {
  &.button--smooth {
    .button--radio:first-of-type label {
      @media #{$phone} {
        border-radius: 5px 5px 0 0;
        margin: 0;
      }
    }
    .button--radio:last-of-type label {
      @media #{$phone} {
        border-radius: 0 0 5px 5px;
        margin: 0;
      }
    }
  }

  .button--radio {
    @media #{$phone} {
      display: block;
    }
  }
  &.button-group--border {
    @mixin button-group($color) {
      .button {
        @media #{$phone} {
          display: block;
        }
      }
    }

    &.button-group--green { .button--radio { @include button-group($green); } }
  }
}

Thanks for this, Jonathan. I’ll add this in our list of feature enhancements for dashing. We should hopefully be able to get this in soon.
Jared Rauh
Senior Product Designer · Team Lead
Samaritan Ministries International
(309) 253-7700
From: Jonathan Worent<EMAIL_ADDRESS>Reply-To: dashframework/dashing<EMAIL_ADDRESS>Date: Thursday, March 30, 2017 at 7:54 AM
To: dashframework/dashing<EMAIL_ADDRESS>Cc: Subscribed<EMAIL_ADDRESS>Subject: Re: [dashframework/dashing] Toggle Buttons do not stack well on small screen (#14)
I did a couple of @media #{phone} {} overrides
.button-group {
&.button--smooth {
.button--radio:first-of-type label {

  @media #{$phone} {

    border-radius: 5px 5px 0 0;

    margin: 0;

  }

}

.button--radio:last-of-type label {

  @media #{$phone} {

    border-radius: 0 0 5px 5px;

    margin: 0;

  }

}

}
.button--radio {
@media #{$phone} {

  display: block;

}

}
&.button-group--border {
@mixin button-group($color) {

  .button {

    @media #{$phone} {

      display: block;

    }

  }

}

&.button-group--green { .button--radio { @include button-group($green); } }

}
}
[mage]https://cloud.githubusercontent.com/assets/613574/24505048/1f4bb87a-151e-11e7-9e53-4d4e3f224644.png
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHubhttps://github.com/dashframework/dashing/issues/14#issuecomment-290401852, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AGzIIlzGESMK36SRekOOT8w4Qnyc3_Gfks5rq6YggaJpZM4Mtjp2.

This issue has been resolved with v1.1.6.
We have implemented a class called .button-group--vertical which will stack your button-group. If you want your buttons to only stack on a mobile phone size, add the class button-group--vertical_phone in place of the previously mentioned class to only apply the styles to the phone size.
https://github.com/dashframework/dashing/blob/master/sass/modules/actions/_toggle-button.scss#L96-L137


Attempt fix for macos artifacts build

Attempt to resolve https://github.com/grpc/grpc/issues/23047

obsolete


Auto start application on device boot

The application should have an option to start on device boot.   This way if there is a power outage or device crash, the alarm is restarted automatically.

You can use application like AutomateIt to do this.
I agree with you better solution is to have this future integrated.

+1


Separator between options is | instead of space

This PR is made by me based on some trusted code like:

https://github.com/dktapps-pm-pl/pmforms-demo/blob/master/plugin.yml#L12
https://github.com/poggit-orphanage/EconomyS/blob/master/EconomyAuction/plugin.yml#L11
https://github.com/PMPLS/simple-plugins/blob/master/SimplePermissions/plugin.yml#L9
https://github.com/poggit-orphanage/EconomyS/blob/master/EconomyCasino/plugin.yml#L40
https://github.com/poggit-orphanage/EconomyS/blob/master/EconomySell/plugin.yml#L12

Anyway. Thanks for reviewing the pull request. Wish you a good day.

Sorry, my bad I read it wrong.

No problem. Good thing it was merged!


Suggestion: Allow upload to repository

By @shanalikhan
Before starting this feature, Settings Sync required code requires refactoring. You can take https://github.com/shanalikhan/code-settings-sync/pull/937 as a baseline for refactoring to start working.
Following are the feature i see for git sync.
1. It should ask either backup needs to be saved on Github Gist or simple Git Repository.
2. Once the User select the Git Repo, it should setup accordingly.
3. Provide user option to either use Github or GitLab and create a repository from there by their profile tokens.
4. By Download means, user can do `git pull` forcefully.
5. By Upload means, user can do `git push` forcefully.
6. Allow user to setup branches or profiles like `master` and `office` and keep the selected profile / branch in Sync Global Settings and download/ upload to that branch.
7. When user is switched to Gist, it should not upload the Git folder there.
8. Support Github and Gitlab Enterprise versions
9. Complete New UI with integrated with above features to allow users to change via UI

Originally by @smbkr
It would be useful to be able to upload the settings to a repo instead of a gist, the way that JetBrains IDEs sync, so that the changes could be versioned and rolled back as desired.

IssueHunt Summary

Backers (Total: $200.00)

 boostio ($200.00)

Become a backer now!
Or submit a pull request to get the deposits!
Tips

Checkout the Issuehunt explorer to discover more funded issues.
Need some help from other developers? Add your repositories on IssueHunt to raise funds.

IssueHunt has been backed by the following sponsors. Become a sponsor

https://github.com/shanalikhan/code-settings-sync/issues/396#issuecomment-330372658
Thanks, will look into this later on.

Also like this idea.

I thought gists were repos.

Is this feature on the roadmap for this project?
Yes, but not in short time. Will work on it later on.
Would you consider a pull request?
Definitely, I will more happy to accept PR. But anyone wants to send PR it would be great to discuss as its currently tightly coupled with GIST logics.

Following are the feature i see for github sync.

It should ask either backup needs to be saved on Github Gist or simple Git Repository.
Once the User select the Git Repo, it should setup accordingly.
By Download means, user can do git pull forcefully.
By Upload means, user can do git push forcefully.
Allow user to setup branches or profiles like master and office and keep the selected profile / branch in Sync Global Settings and download/ upload to that branch.

@boostio funded this issue with $200. Visit this issue on Issuehunt

@shanalikhan funded this issue with $230. Visit this issue on Issuehunt

This feature is funded, anyone is welcome to work and get the money :smile:

@mortezaprk has started working. Visit this issue on Issuehunt

@mortezaPRK
any update on this ? i can assist you if need any help

Thanks. I already do about 80% of the work. There are some bugs. It should be done by the end of next week :)
Sent from ProtonMail mobile
-------- Original Message --------
On Oct 11, 2018, 19:08, Shan Khan wrote:

@mortezaPRK
any update on this ? i can assist you if need any help
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

Thats great, make sure you write the test cases.
We need to decouple modules in order to implement repo sync rather then writing complete other logic for it.
It would be great you have send me PR with work in progress so i can see and evaluate it mean while you are doing else once all work is completed it would be difficult to change at end.

Sure, I'll send a PR tomorrow.
Sent from ProtonMail mobile
-------- Original Message --------
On Oct 11, 2018, 20:23, Shan Khan wrote:

Thats great, make sure you write the test cases.
We need to decouple modules in order to implement repo sync rather then writing complete other logic for it.
It would be great you have send me PR with work in progress so i can see and evaluate it mean while you are doing else once all work is completed it would be difficult to change at end.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

I already do about 80% of the work

@mortezaPRK its been almost a month. It would be great if you can send work in progress PR so i can evaluate at least.

@shanalikhan cancelled funding, $130, of this issue. Visit this issue on Issuehunt

If i don't get the PR in a week. I will have to assign the issue to someone else.

I might be interested to looking into this

@shanalikhan cancelled funding, $230, of this issue. See it on IssueHunt

Anyone feel free to start working on it, this issue or any other.
Currently the bounties for 4 issues are above 500$.
See the article here.
https://dev.to/shanalikhan/settings-sync-paid-issues---fix--earn---nov-18-1ooj

Is someone working on it? I can finish first version tomorrow. I have support for detection of gist vs repo url. For now only github, but gitlab API is not so hard to integrate.

@wasikuss  no you can start working on it.

I can finish first version tomorrow. I have support for detection of gist vs repo url

How do you intend to do it, Have a look on steps mentioned in first post - We need to just create git init and stage entire user folder.

git init isn't required. Both Github and Gitlab APIs allows to publish commits with files directly.

We would want to git init locally at least though, right? This would allow rolling back the user config to a specific commit, which is one of the main advantages of putting the config in a repo instead of a gist.

The main goal for repository is to create Git Repo, not tightly coupled with github.
Once the repo with git init or creating locally will provide user to connect with any git client.
If you look on the steps, it main focus to create git repository and do pull / push to that repo and then provide some interface options to connect to github.

So sync with local repo only wraps credentials and git push/pull for local repository allowing upload/download sittings but reverting will be done manually?
@shanalikhan ok, using any client/server convince me to use local repo. but I see upload/download actions acts only as alias for regular git commands and it's only for convenience ( to not enter manually to local repo )?

but reverting will be done manually?

Yes, branch switching will be done if you have multiple environments in single repository.

only as alias for regular git commands and it's only for convenience

Exactly !

Ok, now it's more clear how it should work. I'll do PR in 1 or 2 days and then we can discuss required changes for local git support.

I had some problems with testing (especially with --user-data-dir, yes I saw vscode/issues#49306 ) so one more day is needed. First time usage, committing settings, a pushing it (with opt-out) to remote repository and switching between gits and repo already works. Currently I'm working on downloading settings and resolving egde cases (conflicts, etc).

I saw similar behavior while using gists (manual change + download).

@wasikuss has submitted pull request. See it on IssueHunt

Issue is available for bounty.

If nobody’s working on this, I’ll start on it when I get home in a few hours.

Is this still relevant. I can do this!

Is this still relevant. I can do this!

@DeveloperBen
To implement this feature, we need to Refactor the complete extension. @arnohovhannisyan and other users have attempted the refactoring thing before.
You can use this PR for reference.
https://github.com/shanalikhan/code-settings-sync/pull/937

I would just like note that there is already a similar extension that implements this feature. Maybe someone can take an inspiration: https://github.com/arnohovhannisyan/vscode-syncify

OPEN FOR PR!

OPEN FOR PR!

This feature would be awesome. Our development environment doesn't have any Internet connection and we have a self-hosted BitBucket server without any snippet add-on.

I've made a trick workaround to get this, using a python script to sync extensions
This workaround uses no extension at all, but requires python, git and code (vscode cli)
I'm sharing if someone is interested, in this gist

FWIW, your gist is a fully-fledged repository.
You can clone it from the URL, e.g.
git clone https://gist.github.com/kiprasmel/de9160a0602463fb752f2d84d7aa4fd8

and from here, you can do all your standard git stuff - amend, reset, force push, etc.
e.g. if i sometimes override between syncs, i cd into the repo, pull, reset, and undo the deletions, then commit & push to the gist, and then sync the gist back into vscode. cheers.


[ArPow Tarball] Unpacking intermediate packages duplication

Intermediate packages are created from the inner build and then copied and unzipped into the blob-feed.  This is good separation between repo builds, but takes up more space.  If space becomes an issue, alternatives should be considered.
Discussions when initially planning ArPow were to isolate repo builds more in the tarball build by only providing required packages to a given repo build.  This would include SBRP, Previously source-built and any intermediate packages on which the repo was dependent.  Instead of a steadily growing blob-feed for subsequent repo builds, source-build would supply only the required packages in the cache and clean them up between repo builds.  This would make the intermediate packages the source of truth for packages that are built and would eliminate the direct duplication of packages in the blob-feed directory.

[Triage] The intermediates have been removed from the artifacts tarball but are still produced as part of the tarball build.  The production is not necessary and consumes a lot of disk space.

Closing as intermediate packages are no longer created in the product source-build (https://github.com/dotnet/arcade/pull/14348).


Select a version for rand in the examples.

Proposed Changes
Explicitly specify the version of rand in the example crate.

Without this, when building the workspace I get the following error:
error: failed to select a version for `rand`.
    ... required by package `ockam_get_started v0.1.0 (/Users/thom/src/ockam/examples/rust/get_started)`
versions that meet the requirements `=0.7.3` are: 0.7.3

the package `ockam_get_started` depends on `rand`, with features: `std_rng` but `rand` does not have these features.

failed to select a version for `rand` which could resolve this conflict

Specifying the rand version fixes the error, and makes it clear which version of rand this is coded against. It also future-proofs it, in the case where rand has breaking changes in the 0.9 release (or some later semver-major release).

Great find. A couple of things before we can merge this:

Could you head over to our contributors repo and PR a row for yourself in CONTRIBUTORS.csv?
We also require signed commits for all commits, with the same key that signed the CLA

Great, thanks! One very small detail left. We have fairly strict lint rules for commit messages. Would you mind revising the message to be something like fix(rust): select a version for rand in the examples?

Is that good? I can also delete the description text as well, if you meant for me to only include that text in the message.

Perfect, thank you!

I've deleted the other parts of the commit message, as reproducing the error text exceeded 100 columns, which caused your commitlint to fail.
Wrapping the line feels weird since it's an exact quote of the error text, so I've opted just to remove it.
It was identical to the PR submission comment anyway.

I went ahead and merged it in this PR after doing one more fixup that I forgot to mention earlier (100 character limit on messages).
Thanks again!

Ah, sorry that was necessary!


Gradle Exception: Buildfile: build-nusmv-languages.xml does not exist

On commit:
8167cf2
When running:
./gradlew build_smv_languages
Full Exception:
> Task :build_smv_languages FAILED
Buildfile: /home/boakes/Projects/FASTEN/build/scripts/build-nusmv-languages.xml does not exist!
Build failed
Relevant code:
task build_smv_languages(type: BuildLanguages, dependsOn: [build_allScripts]) {
    script new File("$buildDir/scripts/build-nusmv-languages.xml")
}
Gradle Version:
Gradle 5.5
Build time:   2019-06-28 17:36:05 UTC
Revision:     83820928f3ada1a3a1dbd9a6c0d47eb3f199378f
Kotlin:       1.3.31
Groovy:       2.5.4
Ant:          Apache Ant(TM) version 1.9.14 compiled on March 12 2019
JVM:          11.0.5-ea (Ubuntu 11.0.5-ea+10-post-Ubuntu-0ubuntu1)
OS:           Linux 5.3.0-23-generic amd64
Please let me know any other information you require.

gradle generates this automatically by running a bootstrap script called "build_all_scripts.xml" which is under the version control.
Have you set the variables in "gradle.properties" ?

There is no gradle.properties file in the repo. What parameters are needed?
And from a look at build_all_scripts.xml, I don't see where the build-nusmv-languages.xml file is built. Is it created from within MPS code?

there is a gradle.properties.example file in the root - please rename it into gradle.properties and set the variables.
build-nusmv-languages.xml is generated from MPS by the build-allScripts script
(you can generate them manually and build everything my opening the nusmv project)
@BentleyJOakes  please let me know if it works ...

I've opened the code/languages/com.mbeddr.formal.nusmv project in MPS.
As a note to anyone trying this, the path variable mbeddr.formal.home must be set in Settings->Appearance & Behavior->Path Variables.
Most of the Languages and Solutions in the nusmv project have build errors.
When I try to run model check on all the languages, I receive the following Exception:

java.lang.IllegalArgumentException : Illegal parameter : com.mbeddr.mpsutil.blutil.structure.SafeReadAction is not a subconcept of jetbrains.mps.baseLanguage.structure.ILocalVariableElement [node r:6e82d8d0-32f5-4302-ba79-fcd365c09c01(com.mbeddr.formal.base.operatorspanel.editor)/2707707741267927230]

Another issue:
When I rebuild com.mbeddr.formal.base (just as a starting point), I get the error

Can't find imported model: de.itemis.mps.editor.celllayout.runtime.cells

A third issue:
When I try to rebuild the build script (com.mbeddr.formal.allScripts) I get the error

Can't find imported model: com.mbeddr.mpsutil.dev.build

Am I missing a dependency?

@BentleyJOakes thank you for this feedback!
Most likely you are missing the mbeddr.platform plugins. I have updated the readme description about how to build FASTEN from within MPS.
https://github.com/mbeddr/mbeddr.formal/blob/master/README.md
Please let me know if it works.

Thank you!
Issues found:

I had an error marked by MPS in com.mbeddr.formal.allScripts.build.allScripts.com.mbeddr.formal.allScripts
I had to add the last three lines here.

solution com.mbeddr.formal.nusmv.build (7125ed76-a460-4b0f-b95b-a899f99488d6)
  load from $mbeddr.formal.nusmv.code/solutions/com.mbeddr.formal.nusmv.build/com.mbeddr.formal.nusmv.build.msd
  content:
    (with sources)
    resources files from $mbeddr.formal.home/code/languages/com.mbeddr.formal.nusmv/solutions/com.mbeddr.formal.nusmv.build
      includes icons/**
  dependencies:
    (extracted) jetbrains.mps.ide.build
    (extracted) JDK
    (extracted) de.itemis.mps.extensions.build
    (extracted) org.apache.commons
    (extracted) com.mbeddr.platform

In com.mbeddr.formal.nusmv.build.com.mbeddr.formal.nusmvTests, I had to add two macro lines
folder dependencies.root = $mbeddr.formal.home/build/dependencies
folder dependencies.mbeddr.platform = $dependencies.root/com.mbeddr.platform

In com.mbeddr.formal.nusmv.build.com.mbeddr.formal.nusmv, I had to add two dependencies (the last two lines):
idea plugin com.mbeddr.formal.nusmv from generated by default 'plugin.xml' descriptor file
  name com.mbeddr.formal.nusmv
  short (folder) name com.mbeddr.formal.nusmv
  version ${version}
  content:
    com.mbeddr.formal.nusmv
    com.mbeddr.formal.nusmv.devkit
  dependencies:
    jetbrains.mps.core
    de.slisson.mps.tables
    org.apache.commons
    com.mbeddr.mpsutil

Your path to mps.home is hard-coded in these files. Perhaps it should also be a path variable?

com.mbeddr.formal.allScripts.build.allScripts.com.mbeddr.formal.allScripts
com.mbeddr.formal.nusmv.build.com.mbeddr.formal.nusmv
com.mbeddr.formal.nusmv.build.com.mbeddr.formal.nusmvDistribution
com.mbeddr.formal.nusmv.build.com.mbeddr.formal.nusmvTests

On my machine these dependencies are in place. Only the path to "mps_home" should differ from a machine to another.
Does the gradlew based build work on your machine?

Yes, now the gradlew build is working. I've just opened my built version of FASTEN and am testing it.

Thank you for reporting these ... if it works, please close the issue :-)
On Tue, Nov 26, 2019 at 8:56 PM BentleyJOakes<EMAIL_ADDRESS>wrote:

Yes, now the gradlew build is working. I've just opened my built version
of FASTEN and am testing it.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/mbeddr/mbeddr.formal/issues/17?email_source=notifications&email_token=AAK63VPEXYQOPUSELBWZ27TQVV5QHA5CNFSM4JQ3YKJ2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEFHIDPQ#issuecomment-558793150,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAK63VK2JG63VNTNSKU4PX3QVV5QHANCNFSM4JQ3YKJQ
.


Introduce VmStatus component

The component and related getVmStatusDetail(), getVmStatus() functions provide visualization and mapping of a VM to it's status information.
Features:

Error status renders with a link to pod/vm event page (based on error context)
text status info rendered along its icon

Pull Request Test Coverage Report for Build 391

40 of 41 (97.56%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+1.4%) to 73.066%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

src/components/VmStatus/VmStatus.js
40
41
97.56%

Totals

Change from base Build 380:
1.4%

Covered Lines:
539

Relevant Lines:
688

💛  - Coveralls

Can we also display migration status in this component? It needs to be aware of Migration object.
Or maybe another column? VM could be running(scheduling) and also migrating at the same time.
related issue: https://github.com/kubevirt/web-ui-components/issues/111

We can reflect that in the single Status.

Failed importer flow:

in Create VM Wizard, the user selects URL as Provision Source and provides incorrect value
once the VM is started, the VM gets to VM Error state and the user can be navigated to the VM Events page for additional details

With https://github.com/kubevirt/web-ui/issues/85, the user gets adequate information for this state as the issue is listed among in VM events.
I think we do not need to go in farther detail in the VmStatus, especially we do not need to analyze the importer pod.
@rawagner , wdyt?

I've added extra handling of the importer pod.


DNS resolution is broken for some addresses in master/2.0-pre

Steps to reproduce: Apply following patch:
diff --git a/samples/net/sockets/http_get/src/http_get.c b/samples/net/sockets/http_get/src/http_get.c
index 4c2ebd2962..016014e45c 100644
--- a/samples/net/sockets/http_get/src/http_get.c
+++ b/samples/net/sockets/http_get/src/http_get.c
@@ -28,7 +28,7 @@
 #endif

 /* HTTP server to connect to */
-#define HTTP_HOST "google.com"
+#define HTTP_HOST "mqtt.2030.ltsapis.goog"
 /* Port to connect to, as string */
 #if defined(CONFIG_NET_SOCKETS_SOCKOPT_TLS)
 #define HTTP_PORT "443"

And run the sample above. In other words, try to resolve address "mqtt.2030.ltsapis.goog" (this is valid address, used by Google's https://github.com/GoogleCloudPlatform/iot-device-sdk-embedded-c)
The culprit, from bisecting, is ef1093755328e7ecab2965b273110d57b4d76931:
ef1093755328e7ecab2965b273110d57b4d76931 is the first bad commit
commit ef1093755328e7ecab2965b273110d57b4d76931
Author: Jukka Rissanen<EMAIL_ADDRESS>Date:   Tue Jun 25 10:01:54 2019 +0300

    net: dns: Make dns_unpack_answer() to check non-compressed answers

    Modify dns_unpack_answer() function to check if the answer is
    compressed or not, and return correct values regardless.

    Fixes #16594

    Signed-off-by: Jukka Rissanen<EMAIL_ADDRESS>

Specific output from that sample is:
Booting from ROM..***** Booting Zephyr OS build zephyr-v1.14.0-1931-gef1093755328 *****
[00:00:00.010,000] <inf> net_config: Initializing network
[00:00:00.010,000] <inf> net_config: IPv4 address: <IP_ADDRESS>
Preparing HTTP GET request for http://mqtt.2030.ltsapis.goog:80/
getaddrinfo status: -4
Unable to resolve address, quitting

The expected output is getaddrinfo status: 0.

Ok, confirmed that git revert ef1093755328e7ecab2965b273110d57b4d76931 succeeds and fixes this issue.

Analysis of ef1093755328e7ecab2965b273110d57b4d76931, which introduced regression: https://github.com/zephyrproject-rtos/zephyr/commit/ef1093755328e7ecab2965b273110d57b4d76931#r34743268
Summary: this processing needs to be rewritten from scratch.


no such file or directory:'/data/sets/nuscenes/nuscenes_infos_train.10.pkl'

Thanks for the great work and release the codes.
When I trying to train with a single GPU and run the command “python tools/train.py configs/lasermix/lasermix_cy3d_semi_nuscenes_10.py”, got a KeyError: no such file or directory:'/data/sets/nuscenes/nuscenes_infos_train.10.pkl'What should I do to deal this problem?
Thank you very much.

Did I put the file in the wrong path？
I put the file in this path"data/sets/nuScenes/nuscenes_info_train.10.pkl"

Hi @Borddy0, you can directly specify the absolute file path for the .pkl file at this line: https://github.com/ldkong1205/LaserMix/blob/main/configs/lasermix/lasermix_cy3d_semi_nuscenes_10.py#L147.

Thank you very much, I've fixed this issue!


Tutorial docs

Update tutorial in docs with new image/video processing features as well as batch processing.

Incorporated @lostanlen's change from #27

Pull Request Test Coverage Report for Build 206

392 of 392 (100.0%)  changed or added relevant lines in 3 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 100.0%

Totals

Change from base Build 169:
0.0%

Covered Lines:
655

Relevant Lines:
655

💛  - Coveralls

In this PR we need to add clarification in the tutorial about lack of alignment between image and audio embeddings.

Replaced by #37


Suggestion: include hint about helm repo update when charts cannot be located

I recently tried to install seomthing from stable/*, and the chart failed to install. It turns out I just needed to update the local cache, but until this point I didn't event know there was a local cache. It may help people like me to include the name of the command helm repo update in the error message so we can immediately see  it.
This is a dumb PoC:
diff --git a/cmd/helm/install.go b/cmd/helm/install.go
index da1ee52d..6d8d68c6 100644
--- a/cmd/helm/install.go
+++ b/cmd/helm/install.go
@@ -443,7 +443,7 @@ func locateChartPath(repoURL, name, version string, verify bool, keyring,
                return filename, err
        }

-       return filename, fmt.Errorf("failed to download %q", name)
+       return filename, fmt.Errorf("failed to download %q (hint: running `helm repo update` may help)", name)
 }

 func generateName(nameTemplate string) (string, error) {

I think that "dumb" PoC might actually be a great feature to have. More actionable errors in pkg cmd is good! If you want to PR that, we would be very appreciative!

@bacongobbler Thanks! Made the PR #3716.


Pre-round messages equivocation

How equivocation is handled for pre-round messages?

We shouldn't ignore extra pre-round messages
We can't pick the lower one because it affects the status messages that we have already sent (provable values may become non-provable and vice versa)
Should consider union of the messages
Waiting for input from Julian

The issue seems to me to be more of an implementation related issue, because on paper, one would always consider the entire view of the network.
So, here is what we need to do, concretely:

If you are verifying the correctness of a SVP in any step, use your entire view of the network state, i.e., don't disregard messages from sender that obviously cheated in your view.

If you are forming an SVP at any step, it is fine to disregard such messages and just use messages that appear to you as "honest values".

@jlspacemesh , what do you mean by "use your entire view of the network state". Does it mean that if a participant received two PreRound messages from the same sender it should use the union of the messages when validating an SVP?

Yes, but not necessarily when forming the SVP, which was, I think, the main point of confusion...


ESP32 version is untested

ESP8266 works great, but ESP32 has some differences in code. Please check how it works on ESP32 if you have this board.

So, it works great :D


Some small cleanups.

Since the secmem size is not growable, we need to be able to monitor its use.  Instead of removing the variable, I'll add an API to get the value.  Touching assembler scares me, I'll leave that to Andy.  The static thing makes sense.

I removed the secmem size commit.

The first patch can be dropped now, since that's fixed in master (the patch was also not correct, since those variables are supposed to be extern not static).
Don't know about the other one though.

I removed the first patch according to ghedo's suggestion.
Thus, only the assembly patch is left.
The assembly computes the following:
eax |= 0xf;
eax &= 0xfff;
bl = eax == 0x06ff ? 1 : 0;
// followed by eax = 0xC0000001, which means the value of eax is not important afterwards
After the first two statements eax looks like this:
0...0 xxxx xxxx 1111 and we check whether it is equal to
0...0 0110 1111 1111.
The patch changes the code to
eax &= 0xff0;
bl = eax == 0x06f0 ? 1 : 0;
Thus, eax looks like
0...0 xxxx xxxx 0000 and check whether it is equal to
0...0 0110 1111 0000.

@dot-asm: Want to take a look at this?  Looks good to me.

As I recall it, question at that point was what it takes to identify Nano. Does one look at family/model/stepping or family/model is sufficient. 0xfff mask so to say reserves for worst case scenario, i.e. family/model/stepping, in which case one would check for a range of values. And or-ing with 0x0f, which effectively takes stepping out of equation is a hypothesis that needs to be proved. This is why it looks the way it does. Initially trouble was that while pre-Nano processors are documented down to stepping, there is no explicit documentation about Nano-family. One can argue that the fact that no problem were reported means that hypothesis is effectively proved, and one can implement check for family/model alone. Yes, one can. At the same time we have to recognize that current code is correct and its outcome is indistinguishable from suggested modification. Don't fix ain't broken, so it's a zero vote, i.e. neither in favour or against.

Based on @dot-asm's comment, closing this.


Eslint Rule Update: @typescript-eslint/require-await

eslint rule: @typescript-eslint/require-await
severity: warn or error

Instructions:

If rule override exists, start with deleting the rule(s) associated with it, and then make code changes to get the linter to be happy.

duplicate #55


cmd/fillstruct: Cannot fill struct: fillstruct: no struct literal found at selection when filling slice of references

take this code for example:
// test.go

type ContainsSlice struct {
	Slice []*Nested
}

type Nested struct {
	ID    int
	Value string
}

func do() {
	c := ContainsSlice{
		Slice: []*Nested{
			{
				// invoke fillstruct here
			},
		},
	}
	fmt.Print(c)
}

When I invoke fillstruct on the line I referenced, VSCode shows me the following error:
Cannot fill struct: fillstruct: no struct literal found at selection

if I add the type of the slice entry like this:
c := ContainsSlice{
    Slice: []*Nested{
        &Nested{
            // invoke fillstruct here
        },
    },
}

then it works and the fields are filled. However, in that case I get error from literalsimplifycompositelit: redundant type from array, slice, or map composite and have to remove the type manually after that.
Also, if in this case Slice is of type []Nested, not []*Nested then fillstruct works in both cases.
@davidrjenni  I haven't spend much time to look in the code about what may be causing this bug and inconsistency between when the slice is of references vs. values, but am willing to spend the time to troubleshoot it and contribute a fix, if you'll be willing to accept a PR for it.

Debugging this further I found out that:
If I invoke fillstruct manually with line I get the following:
➜  bin fillstruct -line 18 -file /home/asankov/git/asankov/reftools/test.go
[{"start":147,"end":205,"code":"ContainsSlice{\n\tSlice: []*Nested{\n\t\t{},\n\t},\n}"}]

however, the VS Code go extension sends the offset, not the line. like this:
➜  bin fillstruct -offset 191 -file /home/asankov/git/asankov/reftools/test.go
fillstruct: no struct literal found at selection

so 2 weird things here:

the tool behaves differently when invoked via line and offset. (I would investigate this further)
when called by line, it executes successfully without returning an error, but the output is still not what we want -  the element in the []*Nested array is empty (fields are not populated)

NOTE: in this example, test.go contains the sample code I used to illustrate the issue


:bug: fix --stdin CLI option

Description of changes
WIP
Relevant Issues
#56

Thank you @amtoine ! With your help I could solve the issue 😄

Hello! I break the API and forgot to tell you 😆 . Thank you for listing every case.
Reading it one more time today, I realized I made a mistake on the assignment. Let's see if I can fix it 😄

superseded by #61


⚠ Bofrost.de has degraded performance

In 37616ca, Bofrost.de (https://www.bofrost.de) experienced degraded performance:

HTTP code: 200
Response time: 1513 ms

Resolved: Bofrost.de performance has improved in 65d7364 after 9 minutes.


Small update to button styles

What does the pull request do?

To make overriding the default Button template easier, this PR adjusts the pseudoclass selectors to target the ContentPresenter defined in the default fluent template instead of generically using ContentPresenter, i.e. changing
/template/ ContentPresenter"
to
/template/ ContentPresenter#PART_ContentPresenter"
Also applies to ToggleButton and RepeatButton

Probably you need to make same changes in RepeatButton.xaml and ToggleButton.xaml.

I really think this should be pointed out somewhere in the documentation. Something like that:
If you want to override the BackgroundColor of a button on pointerover, use this:
<Button.Styles>
  <Style Selector="Button:pointerover /template/ ContentPresenter#PART_ContentPresenter">
      <Setter Property="Background" Value="Red"/>
  </Style>
  <Style Selector="Button:not(:pointerover) /template/ ContentPresenter#PART_ContentPresenter">
      <Setter Property="Background" Value="Transparent"/>
  </Style>
</Button.Styles>


[Bug report] Custom circuit with no inductances

Describe the bug
I was trying to make circuits with only JJ ands capacitances using the Custom circuit.  As there is no harmonic basis in that case i used the discretized version but i couldn't get the eigenvalues of the circuit.
Expected behavior
To minimize misunderstandings, please state briefly what you expected to happen.
To Reproduce
transmon_circuit =  """# Transmon Circuit
branches:
- ["JJ", 0,1, EJ={0},EC ={1}]
""".format(EJ,EC0)
transmon = Circuit.from_yaml(transmon_circuit, from_file=False, ext_basis="discretized")

transmon.sym_hamiltonian()

$\displaystyle 4.0 EC Q_{1}^{2} + - EJ \cos{\left(θ_{1} \right)}$
transmon_circuit =  """# Transmon Circuit
branches:
- ["JJ", 0,1, EJ={0},EC =0]
- ["C", 0,1,{1}]
""".format(EJ,EC0)
transmon = Circuit.from_yaml(transmon_circuit, from_file=False, ext_basis="discretized")

transmon.sym_hamiltonian()

$\displaystyle 4.0 EC Q_{1}^{2} + - EJ \cos{\left(θ_{1} \right)}$
The second circuit gives me am error as :

File ~\AppData\Roaming\Python\Python39\site-packages\scqubits\core\circuit.py:1424, in Subsystem._replace_mat_mul_operator(self, term)
   1422 def _replace_mat_mul_operator(self, term):
-> 1424     if not self._is_mat_mul_replacement_necessary(term):
   1425         return str(term)
   1427     if self.ext_basis == "discretized":

File ~\AppData\Roaming\Python\Python39\site-packages\scqubits\core\circuit.py:1419, in Subsystem._is_mat_mul_replacement_necessary(self, term)
   1416 def _is_mat_mul_replacement_necessary(self, term):
   1417     return (
   1418         set(self.var_categories["extended"])
-> 1419         & set([get_trailing_number(str(i)) for i in term.free_symbols])
   1420     ) and "*" in str(term)

AttributeError: 'int' object has no attribute 'free_symbols'

OS and version used (please complete the following information):

OS:  windows
scqubits version 3.0.0
Python version 3.9.12

Additional context
Any additional information you would like to provide to aid us.
I tried adding a spurious inductance of very low energy for example as :
transmon_circuit =  """# Transmon Circuit
branches:
- ["JJ", 0,1, EJ={0},EC =0]
- ["C", 1,0,{1}]
- ["L", 0,1,Eeps]

but this creates two issues. it adds a flux and also the frequencies do not match even as the added term to the hamiltonian at zero flux becomes negligible.

Thanks for posting this!
For part 1: The default for circuits without linear inductances is charge basis. @saipavanc Is discretization even expected to work in that case? If not, then we should issue an exception
For part 2: are you saying you are inductively shunting a Cooper pair box / transmon? The L->0 limit is highly singular and should not yield the CPB/transmon spectrum, see https://journals.aps.org/prl/abstract/10.1103/PhysRevLett.103.217004. If I am misunderstanding your point, please follow up with some more clarification.

For part 2: I meant that i added a negligible inductive energy and not a negligible inductance.
(sorry for the wrong manipulation with the issue closing)

For part 2: my bad, I meant to write L -> \infty and went wrong. It is the L-> \infty limit that is discussed in the paper I quoted. As I said, the limit is singular (you cannot go continuously from L2-integrability boundary conditions to periodic boundary conditions), and the spectrum will not converge to that of a CPB/transmon.

@MFMFMFMFMF I have a few questions about the following input file that you have written.
transmon_circuit =  """# Transmon Circuit
branches:
- ["JJ", 0,1, EJ={0},EC =0]
- ["C", 0,1,{1}]
""".format(EJ,EC0)
transmon = Circuit.from_yaml(transmon_circuit, from_file=False, ext_basis="discretized")

Here, you are setting EC, which is the capacitance energy, to zero. But, this would imply that the capacitance is basically set to infinity, and no matter how big or small a capacitor you add in parallel, it would only give you infinite capacitance. Thus, there is not kinetic energy term in the resultant Hamiltonian. This is what is causing trouble, as one of the strings which corresponds to the kinetic energy is rendered to be an empty string, which should not cause any trouble as such and I will fix it in the very next commit.
But, I am guessing that this is not what you were trying to do. If you want to set the capacitance in the junction to be zero, then you should set its capacitance energy to a very high value,  like in this input file.
transmon_circuit =  """# Transmon Circuit
branches:
- ["JJ", 0,1, EJ={0},EC =1e15]
- ["C", 0,1,{1}]
""".format(EJ,EC0)
transmon = Circuit.from_yaml(transmon_circuit, from_file=False, ext_basis="discretized")

And the above code gives me results as I would expect. Let me know if this is what you were trying to do. Also, we have updated scqubits to a new version 3.0.3 which changes the way symbolic expressions are printed. I recommend that you upgrade to the latest release.
Also regarding the parameter ext_basis, as @jkochNU was referring to, the parameter is used to set the basis for the extended variables in the Circuit. Since, there are no extended variables in the Circuit that setting would not affect any of the numerical calculations.

yes perfect thank you so much for your answer


Have some extra option ?

Hi,
Thank you for this slider. I have a question about the slider. I'm using "Silder Syncing" and I want when I will click on arrows of bottoms small slider then not will change automatically of top big slider but when I will select the small slider then will change of big slide. it's possible?

Yep.
This is a JS and Project question, not an issue with the slider.
Simon.


HBASE-26422 Support priority select reference files in StripeCompactionPolicy

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m  1s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ HBASE-25302 Compile Tests _

+1 :green_heart:
mvninstall
4m 33s
HBASE-25302 passed

+1 :green_heart:
compile
3m 22s
HBASE-25302 passed

+1 :green_heart:
checkstyle
1m 13s
HBASE-25302 passed

+1 :green_heart:
spotbugs
2m 13s
HBASE-25302 passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
4m 14s
the patch passed

+1 :green_heart:
compile
3m 19s
the patch passed

+1 :green_heart:
javac
3m 19s
the patch passed

-0 :warning:
checkstyle
1m 13s
hbase-server: The patch generated 1 new + 23 unchanged - 1 fixed = 24 total (was 24)

-0 :warning:
whitespace
0m  0s
The patch has 3 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply

+1 :green_heart:
hadoopcheck
21m 27s
Patch does not cause any errors with Hadoop 3.1.2 3.2.2 3.3.1.

+1 :green_heart:
spotbugs
2m 23s
the patch passed

_ Other Tests _

+1 :green_heart:
asflicense
0m 14s
The patch does not generate ASF License warnings.

54m  2s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3855/1/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/3855

Optional Tests
dupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile

uname
Linux 02011bae5376 4.15.0-147-generic #151-Ubuntu SMP Fri Jun 18 19:21:19 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
HBASE-25302 / b2571df7ae

Default Java
AdoptOpenJDK-1.8.0_282-b08

checkstyle
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3855/1/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt

whitespace
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3855/1/artifact/yetus-general-check/output/whitespace-eol.txt

Max. process+thread count
85 (vs. ulimit of 30000)

modules
C: hbase-server U: hbase-server

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3855/1/console

versions
git=2.17.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 28s
Docker mode activated.

-0 :warning:
yetus
0m  3s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ HBASE-25302 Compile Tests _

+1 :green_heart:
mvninstall
4m 43s
HBASE-25302 passed

+1 :green_heart:
compile
1m 14s
HBASE-25302 passed

+1 :green_heart:
shadedjars
8m 21s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 43s
HBASE-25302 passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
4m 28s
the patch passed

+1 :green_heart:
compile
1m 13s
the patch passed

+1 :green_heart:
javac
1m 13s
the patch passed

+1 :green_heart:
shadedjars
8m 21s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 41s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
142m 12s
hbase-server in the patch passed.

174m 47s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3855/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/3855

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux bbf65cda8971 4.15.0-156-generic #163-Ubuntu SMP Thu Aug 19 23:31:58 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
HBASE-25302 / b2571df7ae

Default Java
AdoptOpenJDK-11.0.10+9

Test Results
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3855/1/testReport/

Max. process+thread count
3971 (vs. ulimit of 30000)

modules
C: hbase-server U: hbase-server

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3855/1/console

versions
git=2.17.1 maven=3.6.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
6m 49s
Docker mode activated.

-0 :warning:
yetus
0m  3s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ HBASE-25302 Compile Tests _

+1 :green_heart:
mvninstall
4m 37s
HBASE-25302 passed

+1 :green_heart:
compile
1m  6s
HBASE-25302 passed

+1 :green_heart:
shadedjars
9m 10s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 41s
HBASE-25302 passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
4m 20s
the patch passed

+1 :green_heart:
compile
1m  5s
the patch passed

+1 :green_heart:
javac
1m  5s
the patch passed

+1 :green_heart:
shadedjars
9m 11s
patch has no errors when building our shaded downstream artifacts.

-0 :warning:
javadoc
0m 39s
hbase-server generated 1 new + 21 unchanged - 0 fixed = 22 total (was 21)

_ Other Tests _

-1 :x:
unit
220m 58s
hbase-server in the patch failed.

260m 33s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3855/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/3855

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 202c5626ac57 4.15.0-143-generic #147-Ubuntu SMP Wed Apr 14 16:10:11 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
HBASE-25302 / b2571df7ae

Default Java
AdoptOpenJDK-1.8.0_282-b08

javadoc
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3855/1/artifact/yetus-jdk8-hadoop3-check/output/diff-javadoc-javadoc-hbase-server.txt

unit
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3855/1/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-server.txt

Test Results
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3855/1/testReport/

Max. process+thread count
3342 (vs. ulimit of 30000)

modules
C: hbase-server U: hbase-server

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3855/1/console

versions
git=2.17.1 maven=3.6.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m 37s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ HBASE-25302 Compile Tests _

+1 :green_heart:
mvninstall
4m 45s
HBASE-25302 passed

+1 :green_heart:
compile
3m 34s
HBASE-25302 passed

+1 :green_heart:
checkstyle
1m 11s
HBASE-25302 passed

+1 :green_heart:
spotbugs
2m 18s
HBASE-25302 passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
4m 20s
the patch passed

+1 :green_heart:
compile
3m 35s
the patch passed

+1 :green_heart:
javac
3m 35s
the patch passed

-0 :warning:
checkstyle
1m 12s
hbase-server: The patch generated 1 new + 23 unchanged - 1 fixed = 24 total (was 24)

-0 :warning:
whitespace
0m  0s
The patch has 3 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply

+1 :green_heart:
hadoopcheck
23m 30s
Patch does not cause any errors with Hadoop 3.1.2 3.2.2 3.3.1.

+1 :green_heart:
spotbugs
2m 57s
the patch passed

_ Other Tests _

+1 :green_heart:
asflicense
0m 15s
The patch does not generate ASF License warnings.

59m 40s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3855/2/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/3855

Optional Tests
dupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile

uname
Linux 242f09a2f4d0 4.15.0-147-generic #151-Ubuntu SMP Fri Jun 18 19:21:19 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
HBASE-25302 / b2571df7ae

Default Java
AdoptOpenJDK-1.8.0_282-b08

checkstyle
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3855/2/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt

whitespace
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3855/2/artifact/yetus-general-check/output/whitespace-eol.txt

Max. process+thread count
86 (vs. ulimit of 30000)

modules
C: hbase-server U: hbase-server

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3855/2/console

versions
git=2.17.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m 36s
Docker mode activated.

-0 :warning:
yetus
0m  3s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ HBASE-25302 Compile Tests _

+1 :green_heart:
mvninstall
5m 36s
HBASE-25302 passed

+1 :green_heart:
compile
1m 26s
HBASE-25302 passed

+1 :green_heart:
shadedjars
9m 27s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 51s
HBASE-25302 passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
5m 15s
the patch passed

+1 :green_heart:
compile
1m 24s
the patch passed

+1 :green_heart:
javac
1m 24s
the patch passed

+1 :green_heart:
shadedjars
9m 10s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 43s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
211m 39s
hbase-server in the patch passed.

249m  7s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3855/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/3855

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 758973177dea 4.15.0-147-generic #151-Ubuntu SMP Fri Jun 18 19:21:19 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
HBASE-25302 / b2571df7ae

Default Java
AdoptOpenJDK-11.0.10+9

Test Results
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3855/2/testReport/

Max. process+thread count
3460 (vs. ulimit of 30000)

modules
C: hbase-server U: hbase-server

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3855/2/console

versions
git=2.17.1 maven=3.6.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m  2s
Docker mode activated.

-0 :warning:
yetus
0m  3s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ HBASE-25302 Compile Tests _

+1 :green_heart:
mvninstall
4m 27s
HBASE-25302 passed

+1 :green_heart:
compile
1m  3s
HBASE-25302 passed

+1 :green_heart:
shadedjars
9m  8s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 39s
HBASE-25302 passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
4m 15s
the patch passed

+1 :green_heart:
compile
1m  4s
the patch passed

+1 :green_heart:
javac
1m  4s
the patch passed

+1 :green_heart:
shadedjars
9m  6s
patch has no errors when building our shaded downstream artifacts.

-0 :warning:
javadoc
0m 38s
hbase-server generated 1 new + 21 unchanged - 0 fixed = 22 total (was 21)

_ Other Tests _

+1 :green_heart:
unit
216m 32s
hbase-server in the patch passed.

251m 17s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3855/2/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/3855

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 9191a9b41411 4.15.0-143-generic #147-Ubuntu SMP Wed Apr 14 16:10:11 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
HBASE-25302 / b2571df7ae

Default Java
AdoptOpenJDK-1.8.0_282-b08

javadoc
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3855/2/artifact/yetus-jdk8-hadoop3-check/output/diff-javadoc-javadoc-hbase-server.txt

Test Results
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3855/2/testReport/

Max. process+thread count
3518 (vs. ulimit of 30000)

modules
C: hbase-server U: hbase-server

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3855/2/console

versions
git=2.17.1 maven=3.6.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

The failed TestReplicationValueCompressedWAL is not relevant to this PR.

Hi, @Apache9 , can you help review this PR at your convenience? Thanks.

Hi, @Apache9 , can you help review this PR in your convenience? Thanks.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
2m 54s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ HBASE-25302 Compile Tests _

+1 :green_heart:
mvninstall
5m  4s
HBASE-25302 passed

+1 :green_heart:
compile
3m 55s
HBASE-25302 passed

+1 :green_heart:
checkstyle
1m 21s
HBASE-25302 passed

+1 :green_heart:
spotbugs
2m 36s
HBASE-25302 passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
4m 41s
the patch passed

+1 :green_heart:
compile
3m 53s
the patch passed

+1 :green_heart:
javac
3m 53s
the patch passed

-0 :warning:
checkstyle
1m 17s
hbase-server: The patch generated 1 new + 23 unchanged - 1 fixed = 24 total (was 24)

-0 :warning:
whitespace
0m  1s
The patch has 3 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply

+1 :green_heart:
hadoopcheck
23m 36s
Patch does not cause any errors with Hadoop 3.1.2 3.2.2 3.3.1.

+1 :green_heart:
spotbugs
2m 45s
the patch passed

_ Other Tests _

+1 :green_heart:
asflicense
0m 15s
The patch does not generate ASF License warnings.

61m 44s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3855/1/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/3855

Optional Tests
dupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile

uname
Linux 06ebdd905433 4.15.0-163-generic #171-Ubuntu SMP Fri Nov 5 11:55:11 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
HBASE-25302 / b2571df7ae

Default Java
AdoptOpenJDK-1.8.0_282-b08

checkstyle
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3855/1/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt

whitespace
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3855/1/artifact/yetus-general-check/output/whitespace-eol.txt

Max. process+thread count
86 (vs. ulimit of 30000)

modules
C: hbase-server U: hbase-server

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3855/1/console

versions
git=2.17.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m  9s
Docker mode activated.

-0 :warning:
yetus
0m  4s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ HBASE-25302 Compile Tests _

+1 :green_heart:
mvninstall
4m 10s
HBASE-25302 passed

+1 :green_heart:
compile
1m  1s
HBASE-25302 passed

+1 :green_heart:
shadedjars
8m 34s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 41s
HBASE-25302 passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
3m 58s
the patch passed

+1 :green_heart:
compile
1m  5s
the patch passed

+1 :green_heart:
javac
1m  5s
the patch passed

+1 :green_heart:
shadedjars
8m 18s
patch has no errors when building our shaded downstream artifacts.

-0 :warning:
javadoc
0m 37s
hbase-server generated 1 new + 21 unchanged - 0 fixed = 22 total (was 21)

_ Other Tests _

-1 :x:
unit
180m  8s
hbase-server in the patch failed.

211m 37s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3855/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/3855

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 63e922b1b4bc 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
HBASE-25302 / b2571df7ae

Default Java
AdoptOpenJDK-1.8.0_282-b08

javadoc
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3855/1/artifact/yetus-jdk8-hadoop3-check/output/diff-javadoc-javadoc-hbase-server.txt

unit
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3855/1/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-server.txt

Test Results
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3855/1/testReport/

Max. process+thread count
3660 (vs. ulimit of 30000)

modules
C: hbase-server U: hbase-server

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3855/1/console

versions
git=2.17.1 maven=3.6.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m  8s
Docker mode activated.

-0 :warning:
yetus
0m  4s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ HBASE-25302 Compile Tests _

+1 :green_heart:
mvninstall
4m 50s
HBASE-25302 passed

+1 :green_heart:
compile
1m 13s
HBASE-25302 passed

+1 :green_heart:
shadedjars
8m 31s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 45s
HBASE-25302 passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
5m 21s
the patch passed

+1 :green_heart:
compile
1m 40s
the patch passed

+1 :green_heart:
javac
1m 40s
the patch passed

+1 :green_heart:
shadedjars
11m 13s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 50s
the patch passed

_ Other Tests _

-1 :x:
unit
170m 28s
hbase-server in the patch failed.

208m  1s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3855/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/3855

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 6bff70d24e57 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
HBASE-25302 / b2571df7ae

Default Java
AdoptOpenJDK-11.0.10+9

unit
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3855/1/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt

Test Results
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3855/1/testReport/

Max. process+thread count
3729 (vs. ulimit of 30000)

modules
C: hbase-server U: hbase-server

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3855/1/console

versions
git=2.17.1 maven=3.6.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.


[BUG] VM with unschedule disks doesn't show clear warning message

Describe the bug
VM with unschedule disks doesn't show clear warning message
To Reproduce
Steps to reproduce the behavior:

Create a VM that exceed the storage capacity, e.g. 100T
VM failed to start, but no error message giving to the user
The only available information in the event is

Reason
Resource
Date

FailedMount
Pod virt-launcher-test-nzg65Unable to attach or mount volumes: unmounted volumes=[disk-0], unattached volumes=[container-disks sockets disk-0 cloudinitdisk-ndata public ephemeral-disks hotplug-disks libvirt-runtime cloudinitdisk-udata private]: timed out waiting for the condition
1.3 mins ago

FailedAttachVolume
Pod virt-launcher-test-nzg65AttachVolume.Attach failed for volume "pvc-db775cbb-a5a2-4479-83f6-d7d9af85bfb7" : rpc error: code = Aborted desc = volume pvc-db775cbb-a5a2-4479-83f6-d7d9af85bfb7 is not ready for workloads
1.3 mins ago

FailedMount
Pod virt-launcher-test-nzg65Unable to attach or mount volumes: unmounted volumes=[disk-0], unattached volumes=[ephemeral-disks private libvirt-runtime cloudinitdisk-udata public container-disks hotplug-disks cloudinitdisk-ndata disk-0 sockets]: timed out waiting for the condition

Expected behavior
VM should show similar warning information to the user like insufficent storage
Support bundle

Environment:

Harvester ISO version: v1.0.0
Underlying Infrastructure (e.g. Baremetal with Dell PowerEdge R630): any

Additional context
Add any other context about the problem here.

There is no obvious message currently showing on the Harvester side due to complicated resource mapping, will make an enhancement on the next version, with the current version you can visit the Longhorn UI and check the detailed volume issues accordingly.

reproduced:

volume with massive size

vm is in "Starting"

events reports failure

embedded longhorn-ui doesn´t give enough error message

it needs knowledge to know from following info that the pvc is in "unknown" state, but is still lack of straightforward info like "insufficient storage"

harv2:~ # kubectl get volumes.longhorn.io -A
NAMESPACE         NAME                                       STATE      ROBUSTNESS   SCHEDULED   SIZE            NODE    AGE
longhorn-system   pvc-15cc2e31-9ae2-46e8-8d9d-405c77826d53   attached   degraded     False<PHONE_NUMBER>0     harv2   5d1h
longhorn-system   pvc-2c5f506a-b75c-4028-987b-feaa0a49c58b   attached   degraded     False       10485760        harv2   5d1h

longhorn-system   pvc-3a99612e-7fee-46e2-8b56-df8f88b189ec   detached   unknown      False<PHONE_NUMBER>000           9m1s

longhorn-system   pvc-49d2a05a-0c02-4fab-ada3-e3793850bc81   detached   unknown      True<PHONE_NUMBER>              17h

harv2:~ # kubectl get volumes.longhorn.io pvc-3a99612e-7fee-46e2-8b56-df8f88b189ec -n longhorn-system
NAME                                       STATE      ROBUSTNESS   SCHEDULED   SIZE            NODE   AGE
pvc-3a99612e-7fee-46e2-8b56-df8f88b189ec   detached   unknown      False<PHONE_NUMBER>000          10m

harv2:~ #
harv2:~ # kubectl get volumes.longhorn.io pvc-3a99612e-7fee-46e2-8b56-df8f88b189ec -n longhorn-system -o JSON
{
    "apiVersion": "longhorn.io/v1beta1",
    "kind": "Volume",
    "metadata": {
        "creationTimestamp": "2022-01-12T14:47:09Z",
        "finalizers": [
            "longhorn.io"
        ],
        "generation": 1,
        "labels": {
            "longhornvolume": "pvc-3a99612e-7fee-46e2-8b56-df8f88b189ec",
            "recurring-job-group.longhorn.io/default": "enabled"
        },
        "name": "pvc-3a99612e-7fee-46e2-8b56-df8f88b189ec",
        "namespace": "longhorn-system",
        "resourceVersion": "4848310",
        "uid": "1066af41-21b3-4605-a8c2-b94966ee71b7"
    },
    "spec": {
        "Standby": false,
        "accessMode": "rwx",
        "backingImage": "default-image-mxcmj",
        "baseImage": "",
        "dataLocality": "disabled",
        "dataSource": "",
        "disableFrontend": false,
        "diskSelector": null,
        "encrypted": false,
        "engineImage": "longhornio/longhorn-engine:v1.2.3",
        "fromBackup": "",
        "frontend": "blockdev",
        "lastAttachedBy": "",
        "migratable": true,
        "migrationNodeID": "",
        "nodeID": "",
        "nodeSelector": null,
        "numberOfReplicas": 3,
        "replicaAutoBalance": "ignored",
        "revisionCounterDisabled": false,
        "size": "1073741824000",
        "staleReplicaTimeout": 30
    },
    "status": {
        "actualSize": 0,
        "cloneStatus": {
            "snapshot": "",
            "sourceVolume": "",
            "state": ""
        },
        "conditions": {
            "restore": {
                "lastProbeTime": "",
                "lastTransitionTime": "2022-01-12T14:47:10Z",
                "message": "",
                "reason": "",
                "status": "False",
                "type": "restore"
            },
            "scheduled": {
                "lastProbeTime": "",
                "lastTransitionTime": "2022-01-12T14:47:10Z",
                "message": "",
                "reason": "ReplicaSchedulingFailure",
                "status": "False",
                "type": "scheduled"
            },
            "toomanysnapshots": {
                "lastProbeTime": "",
                "lastTransitionTime": "2022-01-12T14:47:10Z",
                "message": "",
                "reason": "",
                "status": "False",
                "type": "toomanysnapshots"
            }
        },
        "currentImage": "longhornio/longhorn-engine:v1.2.3",
        "currentNodeID": "",
        "expansionRequired": false,
        "frontendDisabled": false,
        "isStandby": false,
        "kubernetesStatus": {
            "lastPVCRefAt": "",
            "lastPodRefAt": "",
            "namespace": "default",
            "pvName": "pvc-3a99612e-7fee-46e2-8b56-df8f88b189ec",
            "pvStatus": "Bound",
            "pvcName": "cirros-5-massive-storage-disk-0-gqgzl",
            "workloadsStatus": [
                {
                    "podName": "virt-launcher-cirros-5-massive-storage-mgslr",
                    "podStatus": "Pending",
                    "workloadName": "cirros-5-massive-storage",
                    "workloadType": "VirtualMachineInstance"
                }
            ]
        },
        "lastBackup": "",
        "lastBackupAt": "",
        "lastDegradedAt": "",
        "ownerID": "harv2012",
        "pendingNodeID": "",
        "remountRequestedAt": "",
        "restoreInitiated": false,
        "restoreRequired": false,
        "robustness": "unknown",
        "shareEndpoint": "",
        "shareState": "",
        "state": "detached"
    }
}

harv2:~ #

@yasker @guangbochen   :
Any idea about how to deduce the straightforward error message like "insufficient storage" ?

On the longhorn side we should prevent the volume creation, if there is no node capable of hosting it during the api volume creation call. We could return the Out of Range error, for this case during the CreateVolume csi call.
This evaluation should be done by the backend api creation call.
ref: https://github.com/container-storage-interface/spec/blob/master/spec.md#createvolume-errors

We shouldn't need to wait for this change. Today Longhorn UI knows if a volume cannot be scheduled according to the conditions of the object. We can just use those conditions to determine.

We shouldn't need to wait for this change. Today Longhorn UI knows if a volume cannot be scheduled according to the conditions of the object. We can just use those conditions to determine.

@yasker :
based on current implementation,
the longhorn pvc has scheduled  field, which shows status False and reason ReplicaSchedulingFailure, with it, we can deduce a general error message like pvc is not successfully scheduled, VM can not start, but not insufficient storage
is this general error message OK to be shown in VM page, to give the users further information?
cc @guangbochen
volumes.longhorn.io pvc-3a99612e-7fee-46e2-8b56-df8f88b189ec
            "scheduled": {
                "lastProbeTime": "",
                "lastTransitionTime": "2022-01-12T14:47:10Z",
                "message": "",
                "reason": "ReplicaSchedulingFailure",
                "status": "False",
                "type": "scheduled"
            },

@joshimoo I remember that condition also indicates we cannot create more replicas with one node. Do you remember how did we tell the two cases apart? Depends on if the volume is attached or not?

New experiment:
create 2 volumes, but not attaching them to any VM
@yasker @guangbochen @joshimoo
The first enhancement point with current implementation:
From PVC  to PV  to volume (longhorn), when it is not schedulable, the first available information can be taken from volume (longhorn), filed Scheduled, when its status is "False", we can try to map it into Harvester UI "Volume", to stop the further using of them when creating VM.
Your idea?
And, what is the better way to get this status, harvester controller query longhorn, or longhorn update upstream pvc/pv ?

they seem to be fine in Harvester->Volumes

pvc shows OK:

pv shows OK:

volume shows "Scheduled False" for the massive-size pv

Scheduled:
Last Probe Time:
Last Transition Time:  2022-01-17T16:21:14Z
Message:
Reason:                ReplicaSchedulingFailure
Status:                False
Type:                  scheduled

harv2:~ # kubectl describe volume -n longhorn-system pvc-38813022-51ac-4cd0-982d-2f249ccc6e55
Name:         pvc-38813022-51ac-4cd0-982d-2f249ccc6e55
Namespace:    longhorn-system
Labels:       longhornvolume=pvc-38813022-51ac-4cd0-982d-2f249ccc6e55
              recurring-job-group.longhorn.io/default=enabled
Annotations:  <none>
API Version:  longhorn.io/v1beta1
Kind:         Volume
Metadata:
  Creation Timestamp:  2022-01-17T16:21:12Z
  Finalizers:
    longhorn.io
  Generation:  1
  Managed Fields:
    API Version:  longhorn.io/v1beta1
    Fields Type:  FieldsV1
    fieldsV1:
      f:metadata:
        f:finalizers:
          .:
          v:"longhorn.io":
        f:labels:
          .:
          f:longhornvolume:
          f:recurring-job-group.longhorn.io/default:
      f:spec:
      f:status:
    Manager:         longhorn-manager
    Operation:       Update
    Time:            2022-01-17T16:21:12Z
  Resource Version:  9629988
  UID:               5dc2535b-436a-4ee3-83d7-52ab3f8eac00
Spec:
  Standby:                    false
  Access Mode:                rwx
  Backing Image:
  Base Image:
  Data Locality:              disabled
  Data Source:
  Disable Frontend:           false
  Disk Selector:              <nil>
  Encrypted:                  false
  Engine Image:               longhornio/longhorn-engine:v1.2.3
  From Backup:
  Frontend:                   blockdev
  Last Attached By:
  Migratable:                 true
  Migration Node ID:
  Node ID:
  Node Selector:              <nil>
  Number Of Replicas:         3
  Replica Auto Balance:       ignored
  Revision Counter Disabled:  false
  Size:<PHONE_NUMBER>176
  Stale Replica Timeout:      30
Status:
  Actual Size:  0
  Clone Status:
    Snapshot:
    Source Volume:
    State:
  Conditions:
    Restore:
      Last Probe Time:
      Last Transition Time:  2022-01-17T16:21:14Z
      Message:
      Reason:
      Status:                False
      Type:                  restore
    Scheduled:
      Last Probe Time:
      Last Transition Time:  2022-01-17T16:21:14Z
      Message:
      Reason:                ReplicaSchedulingFailure
      Status:                False
      Type:                  scheduled
    Toomanysnapshots:
      Last Probe Time:
      Last Transition Time:  2022-01-17T16:21:14Z
      Message:
      Reason:
      Status:                False
      Type:                  toomanysnapshots
  Current Image:             longhornio/longhorn-engine:v1.2.3
  Current Node ID:
  Expansion Required:        false
  Frontend Disabled:         false
  Is Standby:                false
  Kubernetes Status:
    Last PVC Ref At:
    Last Pod Ref At:
    Namespace:           default
    Pv Name:             pvc-38813022-51ac-4cd0-982d-2f249ccc6e55
    Pv Status:           Bound
    Pvc Name:            disk-massive-size
    Workloads Status:    <nil>
  Last Backup:
  Last Backup At:
  Last Degraded At:
  Owner ID:              harv2
  Pending Node ID:
  Remount Requested At:
  Restore Initiated:     false
  Restore Required:      false
  Robustness:            unknown
  Share Endpoint:
  Share State:
  State:                 detached
Events:
  Type    Reason    Age   From                               Message
  ----    ------    ----  ----                               -------
  Normal  Detached  17m   longhorn-volume-controller         volume pvc-38813022-51ac-4cd0-982d-2f249ccc6e55 has been detached
  Normal  Start     17m   longhorn-kubernetes-pv-controller  Persistent Volume pvc-38813022-51ac-4cd0-982d-2f249ccc6e55 started to use/reuse Longhorn volume pvc-38813022-51ac-4cd0-982d-2f249ccc6e55
harv2:~ #

Another related issue
https://github.com/harvester/harvester/issues/1346
It looks, we need to add kind of enhancement to reflect the real status of PVC/PV, and control the usage from UI.
@johnliu55tw @WuJun2016 please also take a look of 1#695

Place holder: The second enhancement:
When Harvester Volume is created via VM creating, in case the Volume is not provisioned by longhorn in certain stage, we need to figure it out and show some useful information in the Web UI.

A proto-type:
One VM has 2 massive-sized disk, we can try to map the related state from LH volume, to VM annotations (only when there are errors)
Next step, it would need the help of UI team, to display this annotation to proper place.
@yasker @guangbochen @WuJun2016

I am fine with using the annotation. Though we need to follow camel-camel for the keys, e.g. it should be vm.harvesterhci.io/volume-status instead of volumeStatus.

There are two places the annotation could be displayed.
Volume tab on VM detail page

State column on Volume list

Mock data

@w13915984028 Dose it make sense?

The test cases:
to make sure the state is updated with the LH state change, and also with the PVC  attached/detached to/from the VM.

How to pop up & clear status in a series top down objects:

The frontend has merged, waiting for the backend code to merge.

Update:
Harvester will wait for a solution from Longhorn, then re-adapt. Move back to design now.
@DaiYuzeng @WuJun2016 @guangbochen

According to https://github.com/longhorn/longhorn/issues/3529#issuecomment-1120670106
I did two tests:

Create a volume exceeded maximum storage.
Create a volume and then resizie it to exceed maximum storage.

situation of test 1
There is no related pv and longhorn volume
situation of test 2
There are related pv and longhorn volume, but there is no error message at the annotation  longhorn.io/volume-scheduling-error of pv.
@guangbochen ^^

Tentatively move this to v1.1.1 for now and need to wait for the upstream fix from the LH team, thanks.

Verified fixed on master-b0d883ce-head (11/22). Close this issue.
Result
Case 1 (PASS)

When we create volume exceed the max acceptable size, will block and prompt message
Exceed maximum size 999999999 Gi!

Case 2 (PASS)

When we create a volume did not exceed but larger than the total disk capability (plus overcommit),
We can create the volume but the status of the volume is NotReady
The error message should be insufficient storage

The link on the top of the page will be visible

Click the link to open a new tab with embedded longhorn UI

Case 3 single node (PASS)
When we create a vm have os image volume with replica scheduling failed and another volume with insufficient disk

The status of the volume should be Degraded and Not ready
The error message of the volume should be replica scheduling failed and insufficient disk

The link in the volume section will be visible

Case 4 multiple nodes (PASS)
Same result as single node but in multi nodes cluster

Test Information

Test Environment: 3 nodes harvester on bare machines and 1 nodes local kvm machine
Harvester version:master-b0d883ce-head (11/22)

Verify Steps
Case 1

Go to create a volume with<PHONE_NUMBER> Gi storage size in both harvester-longhorn and longhorn storage class
The volume should not be created successfully.
The error message should be Exceed maximum size 999999999 Gi!

Case 2

Go to create a volume with 99999999 Gi storage size in both harvester-longhorn and longhorn storage class
Back to volume list
The status of the volume should be NotReady
The error message should be insufficient storage
Go to preference page and enable DEV mode
Go to volume detail page
The link on the top of the page will be visible
Click the link to open a new tab with embedded longhorn UI

Case 3 (Single node)

Go to create a vm
Give os image volume 30Gi and add another volume 1600Gi of harvester-longhorn storage class

Go to vm detail or vm edit page
Switch to volume tab
The status of the volume should be Degraded and Not ready
The error message of the volume should be replica scheduling failed and insufficient disk

The link in the volume section will be visible

Case 4 (multi nodes)

Disable Node scheduling on node 3 in Longhorn UI

Give os image volume 30Gi and add another volume 1600Gi of harvester-longhorn storage class

OS image disk display degraded while another disk display Not ready with corresponding error


Option to parse CID

It would be nice to have an option to parse CIDs like this https://github.com/multiformats/js-multiformats/blob/139b3c2fa0d1afcba9f0aafde929fcf69f4d7804/src/cid.js#L485

The documentation for CID.decode had a refuse from a previous implementation. It still said:

Decodes a CID from a bytestring or a hex string (which will be converted to bytes using bytes.fromhex). Note: the hex string is not multibase encoded.

While it should have said:

Decodes a CID from a bytestring or a multibase-encoded string.

I have pushed the change and the documentation has been updated. Does this answer your question?

yes. Thanks. Also I was wondering if you would like to upgrade to pyproject.toml & change pysha3 to safe-pysha3 to support python3.11 & above ? Actually my fork is doing all of these already

Pull Request https://github.com/hashberg-io/multiformats/pull/16 yesterday removed the pysha3 dependency for keccak, in favour of pycryptodomex (which is already a dependency for other hash functions). Would you like to make one or more pull requests, so I can integrate other changes you've made?

Cool. I can make it use pyproject.toml & black + ruff

Happy to start with a migration to pyproject.toml. I am not used to black or ruff, but I am certainly open to consider a case in their favour. Perhaps the best way to proceed is to close this issue and open 3 new issues, one for each proposed upgrade, so we can tackle them incrementally?

cool. I'll open 2 issues then & closing this one


Upgrade Java version existing to Java 11

Update Java version to Java 11 for the project and raise PR

[ ]  first create branch "dev"
[ ] Open pom.xml file
[ ] add new xml tag "properties" with "maven.compiler.source" and "maven.compiler.target" set to 11
[ ] push the "dev" branch
[ ] Raise the pull request to review and merge in the "main" branch

Closing the issue.


Raise TypeError when kwargs are not dict.

This fixes a panic when a function receives kwargs which are not a dict: addresses #1780

Thanks for contributing!


Fix viewbox size of svg.

Fixes issue #56
Increasing the viewBox of the svg gives it room to be fully visible.
Also renamed the func to be more appropriate for what the icon is.

Thanks, @tripplybrand!


Discussion: Use  Bad Request instead of Not Found

⭐ 🌟 ⭐ This PR includes break change⭐ 🌟 ⭐

Break change

404 (Not Found) response changes to 400 (Bad Request). update, delete and recover.

Use 400 instead of 404
Use 400(Bad Request) instead of 404 (Not Found) responses that can confuse the requester.
If entity not found in service, throw Bad Request instead of Not Found

Close this PR because it is out of date. This can be discussed again if necessary.


behind backdrop of modal/flyout

When using with FluxUI, when you open a flyout, wire-spy is not on top anymore - it's behind the backdrop of the dialog and so it is not useable. I have added a backdrop-blur to the flyout, so I can't see anything from wire-spy ;-)

Hey @ultimateBusiness
Could you take a look and see what the z-index is that flux is using? WireSpy is set to 99999999

The problem with this is the dialog itself - it has an own stacking order and is on top of everything when it's open, so your high z-index has no effect.
Would be great if you can find a workaround to show wire-spy within a dialog as well.


Add config option to control whether tooltips are displayed for linter decorations

In some circumstances, it would be useful to suppress tooltips for linter decorations within the editor content and rely instead on tooltips for gutter markers. This adds a configuration option to do that.

Reading the patch, I realized it might be clearer to pass separate filters options the config to linter and the config to lintGutter, and do away with the second argument  to the filters. Also, I'd prefer shorter option names like markerFilter and tooltipFilter.

Thanks! I've merged this as 79aee39555d851f473a9d3995ecd94fe7ca93dc8


Error on opening the file

Hello, i've just downloaded your program, and got an error right at the beginning. might be an "recent update" thing.
Here is the log:
Traceback (most recent call last):
File "main.py", line 66, in open_file_name_dialog
File "models\save_file.py", line 40, in from_file
File "models\raw_save_file.py", line 28, in from_file
Exception: Unsupported version 15
I am on Windows 10, and used te initial release main.exe file
Edit: by downloading the sources on the main page, installing the libs and running the main.py it worked with no problems. thanks !

Should work now, give it a try


Add image label to container metrics

Can one of the admins verify this patch?

cc: @piosz

Just a few comments. Otherwise LGTM

ok to test

LGTM. Thanks for the PR @mwielgus


Support for comma first

I would like to reformat code to have comma-first styling for json objects.
Case in point:
var a = ({
     Hello: "hi"
    ,World: "there"
});

Preceeding Hello ideally would be 1 tab and 1 space

This is a parser. You probably meant to open this issue on a different project.

Right, this seems like an issue for ESLint, JSCS, or similar. Thanks for contributing!

Your site does this: http://esprima.org/demo/rewrite.html

http://esprima.org/demo/rewrite.html is actually only a demo. It's not meant for a full-featured tool.


Performance of Connect vs gRPC

I have just read the following article: https://kmcd.dev/posts/benchmarking-go-grpc/
It seems like connect performance is considerably slow compare to standard gRPC. Is there a specific reason for this?
Can it be improved ?

@singh-hovr, most of the difference is due to the fact that connect-go is based on net/http, whereas grpc-go includes a bespoke HTTP/2 implementation (for both client and server). We wanted Connect to be a lighter-weight dependency that interoperates with the rest of the Go server ecosystem (including things like HTTP/3 support, HTTP middleware, etc), and it's performance will improve as the performance of net/http improves over time in future Go releases.

Thank you for the response, I have a another question around syntax. When writing clients we usually have to do something
res, err := client.Greet(
		context.Background(),
		connect.NewRequest(&greetv1.GreetRequest{Name: "Jane"}),
	)

Why don't create a wrapper for methods to convert the request to connect.NewRequest so final syntax looks user friendly:
res, err := client.Greet(
		context.Background(),
		&greetv1.GreetRequest{Name: "Jane"},
	)

Or we can provide the opt to create these wrappers. You thoughts?

@singh-hovr, there is already a discussion on that topic: https://github.com/connectrpc/connect-go/discussions/421. The connect-go maintainers have discussed this somewhat recently, but we still don't have any concrete plans on how to address this ergonomics issue (and thus no timeline yet either).

I can create a PR for wrapping the request and response in the generate code and provide option to create in same Dir? Would you be open to that?

I have created the wrapper and it works. While trying to put the file in same directory, I am getting the following error:
panic: runtime error: invalid memory address or nil pointer dereference:  segmentation violation
for exampleServiceServiceDescriptor. What think might be the issue?

@jhump has already indicated there is another issue open for this. It's unrealistic to ask anyone to debug your code without reproduction steps. We likely are not open for PR on this issue at this time, however.


Removed duplicate dependencies

Resolves #6243

@rickle-msft Should this PR be updated and merged, or closed now? Thanks!


HTML optimization during build process

Hello, I was wondering if there is a way to optimize the HTML templates during the build process. Right now the HTML are sent as-is.
Thanks

Is there any particular area you think you need to optimise? Compiling with aot changes the html until it is unrecognisable so I don’t know what you are targeting

Once the app is build and deployed (not in development), all the HTML templates are imported as-is, see screenshot below:

This is how I build the meteor/angular app:
meteor build ../output --architecture os.linux.x86_64
and I deploy on a linux server.
Am I missing something?
Thanks

I don't think you are building with AOT. Try this for your build command:
AOT=1 meteor build ../output --architecture os.linux.x86_64
Look in the build folder and you should not find any html files as they should all have been compiled by AOT to ngfactory.js files. They are unreadable by humans but browsers can read them much faster than having to compile angular for each component. The benefit is you angular app is much faster to load.
I'm pretty sure the compiler mentions that it does AOT stuff when it is turned on and it takes a lot longer than a normal build because of this. I can't remember as I'm using a modified version of the compiler with extra logging turned on.

Looks like it did solve my problem. Thanks a lot.
I looked again here https://github.com/Urigo/angular-meteor/tree/master/atmosphere-packages/angular-compilers and it does mention that AOT mode is enabled by default as opposed to Three-shaking mode. Anyways I'm glad it's fixed.


docs: update supported bee

Updates supported Bee version as it is specified in bee-js

🐝 PR preview in Swarm
Preview URL: https://bah5acgzanccdgk5hsjb3zbhqnhoyp6py4vzx3lfm34naxk4vnlzmbg24zxea.bzz.link
Swarm Hash: 6884332ba79243bc84f069dd87f9f8e5737dacacdf1a0bab956af2c09b5ccdc8
Commit Hash: a27abbdebac7f4fcba636c799c6676704b24c758
Commit Message: docs: update supported bee


line, line_begin and line_end variables

Hi!
This PR adds $line, $line_begin and $line_end variables. They could be useful, for example, if someone needs a command to open gitlab/github/etc blame view in browser, with lines highlighted.
Take a look, please.

Hi
Thanks for your pull request. As you may have noticed I'm a bit overloaded at the moment, but I expect things to calm down after next week. So first of all I'm sorry for the late reply. I'll take a look as soon as I can and let you know.
Thanks

Totally not a problem :) Your own time. Thanks for the reply


How do i reload the whole table?

I have the content for the CollapsibleTableSectionViewController coming from an API and i have tried using several methods like the following:
DispatchQueue.main.async{
       self.tableView.reloadData()
       self.tableView.reloadSectionIndexTitles()
       self.tableView.reloadSections(NSIndexSet(index: 1) as IndexSet, with: .automatic)
}

None of these methods calls the CollapsibleTableSectionDelegate methods to reload everything so how can i reload everything?

seriously, how's _tableView not exposed to deriving classes dude??

reloadData

I can't see reloadData function. Can you help?


Slow menu updates; should be able to browse the menu without loading the page

Problem
Example page (any page should do): https://coq.inria.fr/distrib/current/refman/language/gallina-specification-language.html
When browsing the left-hand menu, clicking on a new top-level section can be slow (a couple seconds) because it loads the full document.  This is a long while just to see a few subentries in the menu. The user should be able to browse the menu without so much delay.
For example: I'm looking at the "Gallina specification language" chapter. I want to see the subentries of "Extensions of Gallina" in the short (on-screen) table of contents. Clicking on "Extensions of Gallina" takes a couple seconds before its subentries are visible because that loads the entire chapter as well.

Environment Info

Python Version: 3.6.5
Sphinx Version: 1.7.7
RTD Theme Version: not sure but recent

Hope this is enough info and that this is the right project.  I'm not the one who set up Sphinx and RTD, I'm just updating documentation today.

Try setting collapse_navigation to False. In your conf.py:
html_theme_options = {
    'collapse_navigation': False
}

Perfect, thanks!


Page - Subscriptions Overview

The Subscriptions Overview page (https://developer.nhs.uk/apis/ems-beta/explore_subscriptions.html) could do with some additional information.

The page ecould do with an introduction as to what subscription is and who is going to be using this api.

Agree - I'll take an action to do this.

Something else we could add to this page which would be useful for a subscriber to know would be: if two subscriptions were create by the same organization, for example a explicit subscription for a paitent and a rule based subscription for an event type, if an event came into NEMS which conformed to both subscriptions would the consumer get one or two event messages to their MESH mailbox.

During a meeting yesterday, it was discussed that rule based subscription needs more work and is not going to be relased in bundle 1A and is currently not planned to be released within bundle 1B. Additional work needs to be done before it is estimate and planned for relase. This should be reflected in the spec so that there is no confusion by consumers as to what they can acutually subscribe to. We could either remove it from the spec people are going to build against for Bundle 1A or we can add a note to say that rule based subscriptions will not be available for bundle 1A.

Made changes for for the points raised on this github issue. Changes on the "develop" branch.

Something went wrong with github and my commit has disappeared. I have made changes on the "develop" branch for the points in this github issue.

Somthing went wrong with my github comment, it has vanished. I have made the changes for this github issue on the "develop" branch.

Reviewed and merged so closing issue.


[WIP] contrib/kube-prometheus: Use mixtool to build manifests

With the initial release of the mixtool we can start replacing some of the scripts with a much simpler CLI UX.
This is just the beginning of this PR.

really awesome!

This is blocked at the moment, until we figure out the way forward with the mixtool.


REF_CACHE retains StateRefs created for components that have been unmounted

Reproduction Steps
Please see my demo repository and follow the steps in the README.md.
Description
The memory used by an application that uses useSwrv() with the default time-to-live of 0 will increase as components that call useSwrv() are created. This memory is never recovered because REF_CACHE retains every StateRef created during the life of an application. The retained StateRefs are individually small, but retaining them forever causes a noticeable memory leak in long lived applications. As far as I can tell, it is not necessary to keep StateRefs after the component that consumes them is destroyed.

Closing as fixed by release 0.9.5.


SPUserServiceApp not retrieving all instances

If the environment has multiple User Profile Service Applications, the script crashes because it only expects one. We need to modify the logic so that we loop across each instances of the Service App and capture the info for each one.

Fixed in release <IP_ADDRESS> of ReverseDSC


Display authentication status for all endpoints on provider summary

The containers team added a row to the status section of the provider summary page that shows the status of the Hawkular connection (for metrics).  See #9785.
All providers should show the status of all of their endpoints on the provider summary page.
Example of Containers Provider summary page with status of multiple endpoints:

@blomquisg is this still something that we need to do?


[Feature]: Adding Tutorial for Decision Tree to the Project Page

Is your feature request related to a problem? Please describe.
We need to add a detailed tutorial to the project page that demonstrates how to build a Decision Tree model using the Iris Flower dataset. This will be a step-by-step guide aimed at helping users understand the fundamentals of Decision Tree classification and how to apply it to a real-world dataset.
Describe the solution you'd like.

Introduction:

Brief explanation of the Decision Tree algorithm.
Overview of the Iris Flower dataset.

Dataset Preparation:

Instructions on loading and exploring the Iris dataset.
Explanation of features and target variables.

Building the Decision Tree Model:

Step-by-step code walkthrough to build the model using scikit-learn.
Explanation of key parameters like criterion, max_depth, and splitter.

Model Evaluation:

Instructions for evaluating the model using metrics like accuracy, precision, and recall.
Visualize the Decision Tree using libraries like matplotlib.

Conclusion:

Summarize key takeaways and encourage further experimentation.

Describe alternatives you've considered.
No response
Additional context.
No response
Show us the magic with screenshots
No response
Checklist

[X] I have checked the Existing Issues
[X] I have read the Contributing Guidelines
[X] I want to work on this issue. (optional)

@IkkiOcean assigning this issue to you.
Make sure to complete this issue within 2 days.


Added twig extension for preg_match and preg_split

I added a twig extension for the PHP methods preg_split and preg_match (including code documentation) to cover those aspects not only within Gantry but also in Grav as well. For more information please also check this FR (gantry/gantry5#2586) and this PR (gantry/gantry5#2590).

Merged but renamed the methods to match the other two.


Kudu full process dumps are not as complete as 'procdump -ma'

From some email thread:

KUDU dump generation through Process Explorer does NOT generate full user mode dump with all necessary dump streams (heap information, thread information, and managed heap information which you get with -ma)

Would be nice if we could change it to be more like procdump -ma. @suwatch are we spawning procdump, or doing our own thing?

Hi
If the problem persists and is related to running it on Azure App Service, please open a support incident in Azure:
https://learn.microsoft.com/en-us/azure/azure-portal/supportability/how-to-create-azure-support-request
This way we can better track and assist you on this case
Thanks,
Joaquin Vano
Azure App Service


Get om from release page instead

Installs om from releases page instead of through go, this way om is always pinned to a specific (latest) version. If this can be achieved using go get please educate me :)
With that the base image no longer requires golang, hence the switch to ubuntu:16.04.

Also wanted to add that if debian isn't required, an alpine base would get the image size down to ~60MB compared to ~180MB here (decompressed images).
FROM alpine:3.7
RUN apk --update --no-cache add bash jq python py2-pip curl wget \
    && pip install sshuttle  \
    && apk del py2-pip \
    && curl -s https://api.github.com/repos/pivotal-cf/om/releases/latest \
    | grep "browser_download_url.*linux" \
    | cut -d : -f 2,3 | tr -d \" \
    | tr -d \" \
    |  wget -qi - -O /bin/om \
    && chmod +x /bin/om

Hi @JukieWalsh
Thanks for your PR. We agree that we use the latest release of om instead of building the latest commit on master. We also agree that we can use the alpine image to reduce the ci image size.
Please could you use jq to parse the github api response json? We believe it is a more readable syntax. For example:
curl -s https://api.github.com/repos/pivotal-cf/om/releases/latest \
| jq -r '.assets[] | select(.name=="om-linux") | .browser_download_url' \
| wget -qi - -O /bin/om

Best,
Emmanouil & @jamesjoshuahill

Thank you for helping out reducing the image size 😄
Best,
Mirah & @jamesjoshuahill