Consider submitting this to the Boost Library Incubator

www.blincubator.com
Robert Ramey

I tried to submit the library, but the form at http://rrsd.com/blincubator.com/submit-your-library/ kept showing "Failed Validation - Library Submission".
Maybe @robertramey knows what could be the issue.

I'll look into it

please try again.  also please make sure you're registered on the site
before you submit a library.  If it still fails, send me a screen shot
of the form before you submit it.
Robert Ramey
On 12/28/15 2:59 PM, Niels wrote:

I tried to submit the library, but the form at
http://rrsd.com/blincubator.com/submit-your-library/ kept showing
"Failed Validation - Library Submission".
Maybe @robertramey https://github.com/robertramey knows what could
be the issue.
—
Reply to this email directly or view it on GitHub
https://github.com/nlohmann/json/issues/66#issuecomment-167675296.

--
Robert Ramey
www.rrsd.com
(805)569-3793

I forgot to register... I shall try again later today.

The submission worked now. Let's see what comes out of it!


Request for supporting new website Missav.com

DO NOT REMOVE OR SKIP THE ISSUE TEMPLATE

[X] I understand that I will be blocked if I intentionally remove or skip any mandatory* field

Checklist

[X] I'm reporting a new site support request
[X] I've verified that I have updated yt-dlp to nightly or master (update instructions)
[X] I've checked that all provided URLs are playable in a browser with the same IP and same login details
[X] I've checked that none of provided URLs violate any copyrights or contain any DRM to the best of my knowledge
[X] I've searched known issues and the bugtracker for similar issues including closed ones. DO NOT post duplicates
[X] I've read the guidelines for opening an issue
[X] I've read about sharing account credentials and am willing to share it if required

Region
Australia
Example URLs
"https://missav.com/en/dvdms-981-uncensored-leak"
Provide a description that is worded well enough to be understood
If possible, I hope you can add this JAV website to your support list. I really love it.
Provide verbose output that clearly demonstrates the problem

[X] Run your yt-dlp command with -vU flag added (yt-dlp -vU <your command line>)
[X] If using API, add 'verbose': True to YoutubeDL params instead
[X] Copy the WHOLE output (starting with [debug] Command-line config) and insert it below

Complete Verbose Output
what is this?

https://github.com/yt-dlp/yt-dlp/issues/6544#issuecomment-1469828382


RENAME: Add Circle CI step that fails if branch name is master

Descriptive summary
This repository’s default branch has already been renamed to main using GitHub’s renaming tool.  In order to preserve automatic redirection of links that reference the old branch name master to the new default main branch, a branch with the old name should not be recreated.
CircleCI can be used to prevent the recreation of the old default branch name by preventing PRs with a branch named master from being merged by causing a test failure during continuous integration.
Rationale
Git's default "master" branch derives from "master/slave" jargon which perpetuates systemic racist language and systems (see email Replacing "master" reference in git branch names). To uphold our Code of Conduct, we must move away from the term "master" in our technical language (as well as words like blacklist or whitelist).
Expected behavior
If a PR is submitted with a branch named master, the continuous integration tests should fail.
Actual behavior
If a PR is submitted with a branch named master, the continuous integration tests will not fail because of the branch name.
Related work
Background on the renaming effort is available in the working group notes.

@kelynch at the moment Bulkrax uses Github actions for its CI. but we did add the requested task to CI and confirm it fails if the branch is reintroduced. Is that sufficient for the working group?


Instantiating a large Jacobian at every loop

I am trying to use the jax package to build a Jacobian to solve for nonlinear equations via Newton's method. See here for the code. I explicitly instantiate Jacobian of size ~5000X5000 at every Newton iteration, and I'm looking for a faster way to speed up the computation. The program uses about 3640+MB of memory (197% of my CPU) and 5 Newton iterations takes around 252 seconds.
I create jacobian functions outside the loop,
jac_fn = jax.jit(jacfwd(fn))
fn = jax.jit(fn)

where fn takes a vector of size ~5000. Inside newton's method,
 while(count < maxit and  res > tol):
        start1 =timeit.default_timer()
        J =  jac_fn(U, Uold)
        y = fn(U,Uold)
        res = norm(y/norm(U,np.inf),np.inf)
        delta = solve(J,y)
        U = U - delta
        count = count + 1
        end1 =timeit.default_timer()
        print(count, res)

My biggest concern is that the large matrix at every iteration is a dense matrix so it takes up a lot of memory (and possibly the linear solve is slower than the sparse version?) I believe that Jax doesn't have implementations for something like scipy.sparse. Could this be the issue? When I print out the time taken in each loop, they're less than a second except the first loop. I don't quite understand how this can add up to couple of minutes.
I'm using jacfwd instead of jacrev as  the process is automatically killed with jacrev ( I think because of memory issues) and my function does not have more arguments than outputs.
Issue #2302 has a similar problem I believe.

Something you could consider doing is using the JAX conjugate gradients solver.
The idea is that you can solve a system Ax = b without needing to instantiate A, you just need a function that gives x computes Ax. You want to solve the system J @ delta = y for Newton's method.
The function
jac_x_prod = lambda x: jvp(fn, y, x)

is exactly this function that compute J @ x given x, where J is the Jacobian of fn evaluated at y.
I think you might be able to use linearize here too, but I'm not too familiar with that.
So in summary, if you replace delta = solve(J,y) with
jac_x_prod = lambda x: jvp(fn, y, x)
delta = jax.scipy.sparse.linalg.cg(jax_x_prod, y)[0]

This should drastically cut down your memory usage.
As for whether it would be in general faster, I'm not too sure.

Indeed, jax.scipy.sparse.linalg.cg is a matrix-free solver that we have available today. Any matrix-free solver would allow you to use jax.jvp ("Jacobian-vector product") rather than necessarily instantiating a full Jacobian matrix.
I'm going to close this issue since "instantiating a large Jacobian" should be addressed. Feel free to re-open if you continue to encounter something more.
In case CG is not the right algorithm for this application somehow, we'd welcome contributions of other matrix-free solvers in scipy.linalg!


Improved Hovering Effect

While Hovering at "follow us on" section at footer ,icons turns bluish with underline and in navbar hovering is not proper.

I want to fix this issue.Please assign this to me.

Please assign this task to me. I can fix this issue properly.

please assign this task to me

Go ahead guys

Could you assign this to me @arghadipmanna101

Hi, I want to fix this issue because it needs  hovering effect on the footer section and header section properly. Please assign the task to me.

can you please assign this issue to me?

I'm looking forward to work on this issue @arghadipmanna101  under GSSoC'24. It would be a pleasure for me to contribute to this issue. Kindly assign this issue to me.

I can resolve this issue. Kindly assign me this task.
Thankyou.

That pull request is for this issue.

#155

@arghadipmanna101  you can close this issue as it has been fixed


Enhance Music:Stop

Enhance Stop so not anyone can stop a queue but it is instead handled the same was as skip
Stop should get a vote similar implemented similar to the skip command. Along with that it should also allow for a forced stop by staff as well as by the person who issues the currently playing song, all similar to the Music:Skip command

https://github.com/Favna/Ribbon/blob/9a981fd4bf380e9b251b0a107f86bfb19aac2373/src/commands/music/stop.js#L54-L84

This issue should've been auto generated by todo based on a @todo comment in e332632c64c7f735a2ceadc29d0cbe5300ed8e86. It's been assigned to @Favna because they committed the code.

 Issue #22: Enhance Music:Stop


Improve docs related to the Accept-Version Header

This is related to issue #1413
It's not clear by reading the docs that when using the Accept-Version header a 406 will only be returned IF :cascade is set to false.This PR aims to make that behavior more visible in the docs.

I'll take it.


Introduce different loggers for different purposes

I've recently come across this library, and am in the process of implementing some tools using it. However, I find the logging a bit too verbose for production use:
2021-01-29 19:32:04,061 importer.cli [INFO] server listening on ::1:8025
2021-01-29 19:32:06,811 mail.log [INFO] Available AUTH mechanisms: LOGIN(builtin) PLAIN(builtin)
2021-01-29 19:32:06,813 mail.log [INFO] Peer: ('::1', 57254, 0, 0)
2021-01-29 19:32:06,817 mail.log [INFO] ('::1', 57254, 0, 0) handling connection
2021-01-29 19:32:06,818 mail.log [INFO] ('::1', 57254, 0, 0) Data: b'lhlo [<IP_ADDRESS>]'
2021-01-29 19:32:06,820 mail.log [INFO] ('::1', 57254, 0, 0) Data: b'mail<EMAIL_ADDRESS>2021-01-29 19:32:06,821 mail.log [INFO] ('::1', 57254, 0, 0) sender<EMAIL_ADDRESS>2021-01-29 19:32:06,822 mail.log [INFO] ('::1', 57254, 0, 0) Data: b'rcpt<EMAIL_ADDRESS>2021-01-29 19:32:06,823 mail.log [INFO] ('::1', 57254, 0, 0) recip<EMAIL_ADDRESS>2021-01-29 19:32:06,824 mail.log [INFO] ('::1', 57254, 0, 0) Data: b'data'
2021-01-29 19:32:06,833 importer.cli [INFO] Handling mail
[... my own two messages ...]
2021-01-29 19:32:06,927 mail.log [INFO] ('::1', 57254, 0, 0) EOF received
2021-01-29 19:32:06,928 mail.log [INFO] Connection lost during _handle_client()
2021-01-29 19:32:06,928 mail.log [INFO] ('::1', 57254, 0, 0) connection lost

All I'm interested in is basically "client connected" and "client disconnected". The rest is logged in my handler anyway. However, I have no chance of filtering these messages.
In Python, we have two dimensions that can be used to filter log messages: logger name and loglevel. Now, one can argue very much about what kind of log level to choose for different types of messages. I personally think these "info" messages that print every single message sent and received would better suit a "verbose" (which doesn't exist in Python by default) or "debug" level, as the average user doesn't usually need to see them unless they're debugging.
However, I'd rather not start a discussion on log levels but suggest to use different loggers for different purposes. Instead of a mail.log that shall fit all purposes, one could have mail.smtp logger for the SMTP class that prints the connection made and connection lost messages, etc. See https://docs.python.org/3/library/logging.html#logger-objects and https://docs.python.org/3/library/logging.html#logging.Logger.getChild for more information on logger hierarchy.
Right now, it's not really viable to implement such a change by just adding class-specific loggers, as the majority of the logic is contained in SMTP. Therefore, it might make more sense to just add purpose-specific loggers like mail.connection or mail.auth.
I think this might also be a chance to refactor the (very large and complex) SMTP class, e.g., by extracting _handle_client into something like a ClientHandler to implement separation of concerns and split responsibilities better. This eliminates the need for SMTP to know about any of these implementations, and maybe even swap the implementations via DOI to also make testing easier. In fact, there are already some classes like Session into which the algorithms might be moved, but right now they're merely used to track state, whereas the business logic remains in SMTP. I guess this discussion should be moved into another issue, though.

However, I'd rather not start a discussion on log levels but suggest to use different loggers for different purposes. Instead of a mail.log that shall fit all purposes, one could have mail.smtp logger for the SMTP class that prints the connection made and connection lost messages, etc.

Makes sense. In all actuality, the whole library actually is already using 2 loggers: mail.log and mail.debug. Splitting the "verbose" logging might be a good idea, say into a mail.verbose logger. (We'll need to think of the name).
That said, such changes will definitely not go into the 1.x series, as it will be breaking. I'll mark the idea in #229 for inclusion in 2.x
As for the other suggestion you have, namely separating _handle_client, might be a good idea to start a different issue.

However, I'd rather not start a discussion on log levels but suggest to use different loggers for different purposes. Instead of a mail.log that shall fit all purposes, one could have mail.smtp logger for the SMTP class that prints the connection made and connection lost messages, etc.

Makes sense. In all actuality, the whole library actually is already using 2 loggers: mail.log and mail.debug. Splitting the "verbose" logging might be a good idea, say into a mail.verbose logger. (We'll need to think of the name).
That said, such changes will definitely not go into the 1.x series, as it will be breaking. I'll mark the idea in #229 for inclusion in 2.x
As for the other suggestion you have, namely separating _handle_client, might be a good idea to start a different issue.

Sorry to actually start the log level discussion, but I feel like having a logger literally called .debug with the existence of the .debug log level seems kinda redundant.
Usually it makes more sense to split logger names by part of the library, most of the times import name aiosmtpd.controller etc.
That's just my two €0.02 though, as I just stumbled over this library.

Sorry to actually start the log level discussion, but I feel like having a logger literally called .debug with the existence of the .debug log level seems kinda redundant.
Usually it makes more sense to split logger names by part of the library, most of the times import name aiosmtpd.controller etc.
That's just my two €0.02 though, as I just stumbled over this library.

Sorry to actually start the log level discussion, but I feel like having a logger literally called .debug with the existence of the .debug log level seems kinda redundant.
Usually it makes more sense to split logger names by part of the library, most of the times import name aiosmtpd.handlers, aiosmtpd.server etc.
That's just my two €0.02 though, as I just stumbled over this library.

For SMTP related stuff, traditionally we go with at least the "mail" part as it will mail to syslog facility of "mail" (though practically whatever the log is named, Python can map it to any syslog facility.)
The current name of "mail.log" and "mail.debug" is currently considered legacy and not changeable due to the possibility of breaking with users of this library.
We'll rethink how best to tidy up the logging problems in 2.0.

Sorry to actually start the log level discussion, but I feel like having a logger literally called .debug with the existence of the .debug log level seems kinda redundant.
Usually it makes more sense to split logger names by part of the library, most of the times import name aiosmtpd.handlers, aiosmtpd.server etc.
That's just my two €0.02 though, as I just stumbled over this library.

For SMTP related stuff, traditionally we go with at least the "mail" part as it will mail to syslog facility of "mail" (though practically whatever the log is named, Python can map it to any syslog facility.)
The current name of "mail.log" and "mail.debug" is currently considered legacy and not changeable due to the possibility of breaking with users of this library.
We'll rethink how best to tidy up the logging problems in 2.0.


Add config checks before initialisation

The bot should crash and or inform the user about wrong config lines, or ignored config lines.
It would be also good, to warn the user on startup about depreciated features.

First part working in 1.4.
Parameter checks have to be yet implemented


feat: port Data.Sign

This is now done, but had some difficulties.

A lot of theorems used to be proved by decide!, which is not yet implemented.
deriving FinType does not work yet, manually inserted that instance
Many proofs relied on casesm and casesm*, which appear to work differently than they did in lean3 (see also this zulip thread).
Lean 4 was unable to infer DecidableEq for SignType, manually inserted that instance as well.

bors merge


Remove timex dependency

We currently use timex to format dates as the support in elixir 1.9 wasn't good enough.
We now only support to elixir 1.11 as that is the oldest maintained version, so we should remove the timex dependency.

Resloved in #34


SWDEV-193778 - Device side support for Cooperative Group feature

Implements device side data types and related APIs for following Cooperative Groups feature

Inter-Device CG (also called multi-grid-group)
Inter-Workgroup CG (also called grid-group)
Intra-Workgroup CG (thread-block, coalesced-group, etc)

Current Status:

Inter-Device CG:   Supported
Inter-Workgroup CG:   Supported
Intra-Workgroup CG:
** coalesced_group:   Supported
** thread_block:   Supported
** coalesced (dynamic) tiled partition:   Supported
** templated (static) tiled partition:   Supported
Unit Testing: The unit testcase file - hipCGDevice.cpp is added.

TODO Items:

tiled partitioning (both static and dynamic) of existing coalesced parent type: This requires some thinking since the size of coalesced type could be anywhere in the range [0, 64) as it is computed based on the current active waves within the wavefront.
additional APIs support like shfl() need to be added: This probably seems to be straightforward to support.
grid_group::is_valid() API at present simply returns "true". We assume that there is nothing to check any API constraint here since otherwise kernel launch could not have happened. However we need to discuss it.

Overview of Implementation:

the header hip/hip_cooperative_groups.h implements the CG data types, and the functions defined within this header (both member and non-member functions) call wrappers implemented within the header hcc_detail/hip_cooperative_groups_helper.h in order to get the needed functionalities.
the wrappers in hcc_detail/hip_cooperative_groups_helper.h make use of device library functions implemented in the header hcc_detail/device_functions.h

@yxsamliu, @b-sumner, @gargrahul, @scchan, @mangupta,  @jlgreathouse, @arsenm
I kindly request you to review this pull request.

I have taken care of all the review comments by Brian. If this PR looks good, then, we should plan to merge it as it has to for 2.9

@b-sumner, If this PR is fine with you, please approve it so that Maneesh can merge it.


Change settings save to themechange

Change settings save-button to be a theme change button

This was linked to the wrong PR...


[Blogs] - Author Bio block for all pages under /blogs/news

[Blogs] - authorbio block for all pages under /blogs/news
See https://www.zemax.com/blogs/news/cto-industry-insights-august-2021
Data to be fetched from page metadata when #69  is complete

@kmurugulla  Let's put this in on hold for now as I feel if we are not fetching it via page metadata and not using it anywhere (via the index), let this be default content and styled as default content like it is for now.
If team would like us to revisit this, can be done quickly by adding a section to style this anyway we want.
Please reopen incase any concerns.


SwiftLint Github action appears abandoned

Description
Our SwiftLint CI action is treating an actor declaration as a function, i.e.:
Check warning on line 14 in Packages/ClientRuntime/Sources/Networking/Http/CRT/CRTClientEngine.swift

Function Body Length Violation: Function body should span 40 lines or less excluding comments and whitespace: currently spans 42 lines (function_body_length)

On further investigation, it appears that the cause is that the version of SwiftLint that is used is out-of-date.
The Github action used to run SwiftLint ( https://github.com/norio-nomura/action-swiftlint ) is not using a recent version of SwiftLint.  The latest Docker container used by this action appears to be six months old and runs Swift 5.5.3 & SwiftLint 0.46.5.  Meanwhile, latest Swift is 5.7.0 & latest SwiftLint is 0.49.1 .
Action: use or create a maintained action for performing Swift linting.

Closed as a duplicate of https://github.com/awslabs/aws-sdk-swift/issues/677


ci: enable pre-commit stage within the Jenkins pipeline

Highlights

Use pre-commit as the single source of truth.

Enable pre-commit stage in the CI pipeline.

Enable GitHub check

Update docs.

Fix .pre-commit.yml file (<unknown>): found unknown escape character while parsing a quoted scalar at line 27 column 18

https://github.com/elastic/apm-agent-python/pull/534/commits/0b69921bcf3b1762795c3f4b053bc7358adfab6d in conjunction with https://github.com/elastic/apm-agent-python/pull/534/commits/dd9f5ae0ecda81ac66359c36b797751c9e142716 does provide the pre-commit to junit transformation. So the output will be shown in the tests tab and will simplify the use case to debug what sanity checks failed if any.


After the Nuke goes off debris should be cleared for lag

Description

currently, after the nuke goes off it leaves behind all the pieces of wire and disposals and other entities that don't get full blow up and slings them around, thus causing the server to lag a ton. I think that we should either clear them or kill all their momentum.
Reproduction
RIP fishops
Arm nuke
blow up station
server suffers after bomb

This should probably be a CVar if some specific server wants it

as is, the nuke is the round's finale so the lag isn't a huge deal.

plowing through all the debris on a shittle is the best part


Can not add the MapMarker inside the MapView.

Summary
Can not add the markers to the MapView. I am using React Native Map 1.20.0.
Reproducible sample code
import MapView, {Marker} from 'react-native-maps';

<MapView
        style={styles.map}
        region={{
          latitude: -34.397,
          longitude: 150.644,
          latitudeDelta: 0.015,
          longitudeDelta: 0.0121,
        }}
        showsUserLocation={true}
        followsUserLocation={true}>
        <Marker
          description="Destination"
          coordinate={{latitude: -34.397, longitude: 150.644}}
        />
      </MapView>

Steps to reproduce
I define the MapView, it works well, but when I add the Marker inside I got the error TypeError: this.getNativeComponent is not a function (it is undefined) in MapMarker.js in node_modules.
Expected result
It must show the map with the markers on it
Actual result
I got this error:
TypeError: this.getNativeComponent is not a function (it is undefined)  This error is located at:     in MapMarker (created by ProjectDetailScreen)     in AIRMap (created by MapView)     in MapView (created by ProjectDetailScreen)     in RCTView (created by View)     in View (created by ProjectDetailScreen)     in RCTScrollContentView (created by ScrollView)     in RCTScrollView (created by ScrollView)     in ScrollView (created by ScrollView)     in ScrollView (created by ProjectDetailScreen)     in RCTView (created by View)     in View (created by ProjectDetailScreen)     in ProjectDetailScreen (created by SceneView)     in StaticContainer     in EnsureSingleNavigator (created by SceneView)     in SceneView (created by SceneView)     in RCTView (created by View)     in View (created by DebugContainer)     in DebugContainer (created by MaybeNestedStack)     in MaybeNestedStack (created by SceneView)     in RCTView (created by View)     in View (created by SceneView)     in RNSScreen (created by Animated(Anonymous))     in Animated(Anonymous)     in Suspender (created by Freeze)     in Suspense (created by Freeze)     in Freeze (created by DelayedFreeze)     in DelayedFreeze     in InnerScreen (created by Screen)     in Screen (created by SceneView)     in SceneView (created by NativeStackViewInner)     in Suspender (created by Freeze)     in Suspense (created by Freeze)     in Freeze (created by DelayedFreeze)     in DelayedFreeze (created by ScreenStack)     in RNSScreenStack (created by ScreenStack)     in ScreenStack (created by NativeStackViewInner)     in NativeStackViewInner (created by NativeStackView)     in RNCSafeAreaProvider (created by SafeAreaProvider)     in SafeAreaProvider (created by SafeAreaProviderCompat)     in SafeAreaProviderCompat (created by NativeStackView)     in NativeStackView (created by NativeStackNavigator)     in PreventRemoveProvider (created by NavigationContent)     in NavigationContent     in Unknown (created by NativeStackNavigator)     in NativeStackNavigator (created by App)     in EnsureSingleNavigator     in BaseNavigationContainer     in ThemeProvider     in NavigationContainerInner (created by App)     in PortalProviderComponent (created by BottomSheetModalProviderWrapper)     in BottomSheetModalProviderWrapper (created by App)     in PersistGate (created by StoreProvider)     in Provider (created by StoreProvider)     in StoreProvider (created by App)     in App (created by RootComponent)     in RCTView (created by View)     in View (created by GestureHandlerRootView)     in GestureHandlerRootView (created by RootComponent)     in RootComponent     in RCTView (created by View)     in View (created by AppContainer)     in RCTView (created by View)     in View (created by AppContainer)     in AppContainer     in VNRealeStates(RootComponent), js engine: hermes
React Native Maps Version
1.20.0
What platforms are you seeing the problem on?
iOS (Google Maps)
React Native Version
0.74.3
What version of Expo are you using?
Not using Expo
Device(s)
iPhone 16 Pro, ios 18.0
Additional information
No response

Same problem for me.
This works, but I don't like it....

The code checks if the fileName does not include the string 'node_modules/react-native-maps'. If this condition is true, it will apply the specified plugins to transform the module. Note that the plugins are placed inside the overrides section to ensure they only apply to specific files that pass this test. If you add these plugins outside of overrides, they will be applied globally, including to react-native-maps, potentially causing the same error again.
`module.exports = {
presets: ['module:@react-native/babel-preset'],
plugins: [
'react-native-reanimated/plugin',
],
overrides: [
{
test: (fileName) => !fileName.includes('node_modules/react-native-maps'),
plugins: [
['@babel/plugin-transform-class-properties', { loose: true }],
['@babel/plugin-transform-private-methods', { loose: true }],
['@babel/plugin-transform-private-property-in-object', { loose: true }],
],
},
],
};`


[BUG] Search form reset does not invalidate a table

Describe the bug
I want to add a Reset button for my filter form. But, in return, only the visuals of the form are getting cleared. If you try to trigger the refetch/submit manually, you will see that the request is sent with the previous values.
Steps To Reproduce

Get the example: https://refine.dev/docs/examples/table/antd/tableFilter/
Add the <Button htmlType="reset" type="default" danger>Reset</Button> button
See that on click only form is cleared, the result is not refetched

Expected behavior
Clicking the reset button for the form filter triggers request invalidation as it is with the form filter submit button
Screenshot
No response
Desktop
No response
Mobile
No response
Additional Context
No response

Hello @elsiniestra, could you provide us a minimal reproducible example?

@BatuhanW Hi, as I've mentioned in the description, you can take the code example provided in the docs and just add the reset button <Button htmlType="reset" type="default" danger>Reset</Button> into the filter to get that behaviour

Hello @elsiniestra, yes htmlType="reset" resets form but useTable still doesn't know. you need to reset filter state by setFilters
const { tableProps, searchFormProps, setFilters } = useTable()

const resetFilters = () => {
    setFilters([], "replace");
};


fail to open .env

hi,
get issue now when running locally:
  Error --------------------------------------------------

  ENOENT: no such file or directory, open '.env'

     For debugging logs, run again after setting the "SLS_DEBUG=*" environment variable.

  Stack Trace --------------------------------------------

Error: ENOENT: no such file or directory, open '.env'
    at Object.fs.openSync (fs.js:663:18)
    at Object.fs.readFileSync (fs.js:568:33)
    at readEnvFile (/Users/slee/projects/adv-invoice/node_modules/serverless-offline-ssm/dist/index.js:6:43)
    at bluebird.Promise.resolve (/Users/slee/projects/adv-invoice/node_modules/serverless-offline-ssm/dist/index.js:17:19)
    at start (/Users/slee/projects/adv-invoice/node_modules/serverless-offline-ssm/dist/index.js:16:29)

script command is
DEBUG=jwks SLS_DEBUG=*  sls invoke local --watch --function xxx --path fixtures/xxx.json --stage dev

deps
serverless-offline-ssm: 1.0.4

The plugin looks for a .env file in the project root directory that lists the SSM params that you are looking to replace. The error states that it cannot find that file.

i have .env file at root dir. ill close for now as it seems to be working this morning.
thanks.


Annotations and ignore logic not working on Linux

For some reason I haven't yet worked out, neither annotations or the ignoring of build/linkage/test failures for unbottled formulae isn't working on Linux.
As best I can tell, the Linux runner seems to exit with an error immediately upon encountering one around here:
https://github.com/Homebrew/homebrew-test-bot/blob/96edbe66a23e103a54187e671e97daea8e615281/lib/step.rb#L104-L107
The ignore logic and annotations come after that, so this would explain why neither is working. I don't know why this is happening specifically on Linux, though.
For examples of this behaviour: Homebrew/homebrew-core#89550 (annotations and ignore), Homebrew/homebrew-core#89042 (annotations and ignore), Homebrew/homebrew-core#89445 (annotations only)
We don't have this problem on macOS. See Homebrew/homebrew-core#89518.

No idea here. I wonder if it's something else about the environment rather than the OS i.e. the Linux runner/GitHub Actions runner has some environment variables set that are interfering?

Yea, I'm pretty stumped as well. However, I think my hypothesis about what's going on is correct, judging from what's happening on the Linux runner in this PR: Homebrew/homebrew-core#89567
It has a whole bunch of formulae to test, but it tests bison first. The test fails and test-bot exits. What it should be doing is logging the failure and moving on to test other formulae.

CC @Homebrew/brew for ideas.

This is your problem:

Error: No such file or directory @ realpath_rec - /home/runner

This is because of https://github.com/Homebrew/homebrew-core/blob/master/.github/workflows/tests.yml#L182-L190. We would need to change GITHUB_WORKSPACE going into this.
I can fix this but I wonder if we can just make it use GitHub's container system somehow (where it'll work out of the box). @dawidd6 I assume you've tried that already and the answer is it doesn't work? Does setting container to a blank value on macOS error?

This is your problem:

Error: No such file or directory @ realpath_rec - /home/runner

Probably from:
https://github.com/Homebrew/brew/blob/07f14c32e9996196661bdc20830f48797079c463/Library/Homebrew/utils/github/actions.rb#L29

I suspected that too, but IIRC I've seen that error on CI runs well before I started using GitHub::Actions::Annotation.

I suspected that too, but IIRC I've seen that error on CI runs well before I started using GitHub::Actions::Annotation.

I'll need to see an example run of this to tell. I've not seen that error until recently and GITHUB_WORKSPACE being set to a directory that won't exist in the Docker container makes sense as a cause.

Does setting container to a blank value on macOS error?

Yep

Does setting container to a blank value on macOS error?

Yep

This works for me: https://github.com/Bo98/workflow-test/blob/main/.github/workflows/test.yml

Interesting. Looks like it was changed a year ago:
https://github.com/actions/runner/issues/265
So I guess we can drop a lot of code in our workflows now.

I'll need to see an example run of this to tell.

Here's an example: https://github.com/Homebrew/homebrew-core/runs/4120630533?check_suite_focus=true#step:7:33
The ENOENT seems to happen on an audit failure, which probably means that this is triggered by the annotations code.
On the other hand, it also didn't kill the test-bot run, unlike what's happening now.

We'll want to remove
https://github.com/Homebrew/homebrew-test-bot/blob/7e3c529bd62f6bffd1297ebec51b915b208a6351/lib/step.rb#L79-L81
when this is sorted.


Add docs for all plugins

http://sematext.com/docs/logagent table lists more plugins than I see in the docs under http://sematext.com/docs/logagent/plugins/ , so it looks like some plugins are missing docs.

Updated documentation, having an overview of all plugins and related detail pages: http://sematext.com/docs/logagent/#plugins


Index Operator Improvements

The Index operator is also a good target for CollectionIterator and ListIterator performance improvements.

i'll tackle this one next week


cannot overload forall method

module A
  def self.func(c : Array(String).class)
    puts "xxxx"
  end
  def self.func(c : T.class) forall T
    puts "yyyy"
  end
  def self.func(c : Int32.class)
    puts "zzzz"
  end
end

module A
  def self.func(c : Array(Int32).class)
    puts "override"
  end
end
A.func Array(String) # xxxx
A.func Array(Int32) # yyyy, should be override
A.func Int32 # yyyy should be zzzz

Minimised example:
module Foo
  def self.bar(a : T) forall T
    puts "Hello from T"
  end

  def self.bar(a : Int32)
    puts "Hello from Int32"
  end
end

Foo.bar(2) # => "Hello from Int32"

Pretty sure forall methods don't overload by design - you could circumvent this for now by using different argument names and manually placing the argument name in there:
def self.bar(b : Int32)

Foo.bar(b: 2) # instead of Foo.bar(2)

@Qwerp-Derp Doesn't "Hello from Int32" show the supposed method with the stricter type restriction was called?
It just doesn't seem to work with .class:
module Foo
  def self.bar(a : T.class) forall T
    puts "Hello from T"
  end

  def self.bar(a : Int32.class)
    puts "Hello from Int32"
  end
end

Foo.bar(Int32) # "Hello from T"

@straight-shoota Yes it does, thanks for noticing. Removing example.

I tried to take a look at this, I've managed to find that T.class & Int32.class are Crystal::Metaclass, using the spec:
assert_type(%(
  def bar(a : T.class) forall T
    1
  end

  def bar(a : Int32.class)
    true
  end

  bar(Int32)
  )) { bool }

And some output in DefWithMetadata#restriction_of?:
diff --git a/src/compiler/crystal/semantic/restrictions.cr b/src/compiler/crystal/semantic/restrictions.cr
index 48004c850..efff1ead9 100644
--- a/src/compiler/crystal/semantic/restrictions.cr
+++ b/src/compiler/crystal/semantic/restrictions.cr
@@ -108,6 +108,14 @@ module Crystal
           # If this is a splat arg and the other not, this is not stricter than the other
           return false if index == self.def.splat_index

+          if self.def.name == "bar"
+            puts ">>> DefWithMetadata#restriction_of?(other : DefWithMetadata, ...)"
+            p! self_type
+            p! self_type.class
+            p! other_type
+            p! other_type.class
+          end
+
           return false unless self_type.restriction_of?(other_type, owner)
         end
       end

For the record, I get:
>>> DefWithMetadata#restriction_of?(other : DefWithMetadata, ...)
self_type # => Int32.class
self_type.class # => Crystal::Metaclass
other_type # => T.class
other_type.class # => Crystal::Metaclass

But adding the following code to Crystal::Metaclass#restriction_of? does't output anything and I don't understand why:
diff --git a/src/compiler/crystal/semantic/restrictions.cr b/src/compiler/crystal/semantic/restrictions.cr
index 48004c850..d04512d1a 100644
--- a/src/compiler/crystal/semantic/restrictions.cr
+++ b/src/compiler/crystal/semantic/restrictions.cr
@@ -307,8 +366,14 @@ <---- the lines are wrong sorry I have a lot of other modifications in that file
   class Metaclass
     def restriction_of?(other : Metaclass, owner)
       self_type = owner.lookup_type?(self)
       other_type = owner.lookup_type?(other)
       if self_type && other_type
+        puts ">>> Metaclass#restriction_of?(other : Metaclass, ...)"
+        p! self_type
+        p! self_type.class
+        p! other_type
+        p! other_type.class
+
         self_type.restriction_of?(other_type, owner)
       else
         self == other

Note: since Crystal::Metaclass is a direct child of ASTNode and doesn't include other modules, it's not another overload of restriction_of? that is called..
Am I missing something obvious?
Or maybe the restrictions of free vars are handled elsewhere?


Make telemetry objects non-optional

Codecov Report

Merging #157 into master will increase coverage by 0.73%.
The diff coverage is 90.47%.

@@            Coverage Diff             @@
##           master     #157      +/-   ##
==========================================
+ Coverage    92.6%   93.34%   +0.73%
==========================================
  Files          22       22
  Lines         933      931       -2
==========================================
+ Hits          864      869       +5
+ Misses         69       62       -7

Impacted Files
Coverage Δ

opwen_email_server/utils/log.py
94.18% <90.47%> (+7.82%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f2cec55...8808c5b. Read the comment docs.


StreamBuilder hangs when listening to Firestore snapshot

Steps to Reproduce
I am trying to use the bloc pattern with firebase and having hard time since there is no good tutorial out there which uses firebase and bloc pattern.
I've faced strange thing while doing this and worked hard to find out the problem but couldn't.
I've created UserBloc and tried to set UserModel after listening to Firestore snapshot.
class UserBloc extends Object {
  final _user = StreamController<UserModel>.broadcast();
  final _uid = StreamController<String>.broadcast();

  Stream<UserModel> get user => _user.stream;
  Stream<String> get uid => _uid.stream;

  Function(UserModel) get setUser => _user.sink.add;
  Function(String) get setUID => _uid.sink.add;

  Stream<DocumentSnapshot> userStream;

  UserBloc() {
    uid.listen((uid) {
      print('user : $uid');
      if (uid != null) {
        fromUID(uid);
      }
    });
  }

  fromUID(String uid) {
    print('fromUID');
    userStream = Firestore.instance.collection('users').document(uid).snapshots();

   /// works ok when I delete below subscription
    userStream.listen((data) {
    });
  }

  dispose() {
    _user.close();
    _uid.close();
  }
}

Then I used the StreamBuilder inside my widget like below.
  StreamBuilder(
    stream: userBloc.userStream,
    builder: (context, snapshot) {
      print(snapshot.connectionState);
      print(snapshot.data);
      return Text('testing');
    },
  );

The problem is the snapshot.connectionState is always waiting. However, when I delete the subscription code which is  userStream.listen((data) {, I was able to get this working. All the example do the listen and set the data in the constructor of bloc. I have no idea why this is happening.
Logs
...
[  +12 ms] [DEVICE LOG] 2018-10-22 22:58:48.521384+0900  localhost Runner[27014]: (Flutter) flutter: isHost: false
[        ] flutter: isHost: false
[  +46 ms] [DEVICE LOG] 2018-10-22 22:58:48.567490+0900  localhost Runner[27014]: (Flutter) flutter: ConnectionState.waiting
[        ] [DEVICE LOG] 2018-10-22 22:58:48.567584+0900  localhost Runner[27014]: (Flutter) flutter: null
[        ] flutter: ConnectionState.waiting
[        ] flutter: null
[  +69 ms] [DEVICE LOG] 2018-10-22 22:58:48.636881+0900  localhost Runner[27014]: (Flutter) flutter: userId: 9xqbCzwstrOI7MVXW7cLG2KMP0u1
[        ] flutter: userId: 9xqbCzwstrOI7MVXW7cLG2KMP0u1
[   +1 ms] [DEVICE LOG] 2018-10-22 22:58:48.638997+0900  localhost Runner[27014]: (Flutter) flutter: documents: 1
[        ] [DEVICE LOG] 2018-10-22 22:58:48.639076+0900  localhost Runner[27014]: (Flutter) flutter: docChanges: 1
[        ] flutter: documents: 1
[        ] flutter: docChanges: 1
[   +2 ms] [DEVICE LOG] 2018-10-22 22:58:48.641936+0900  localhost Runner[27014]: (Flutter) flutter: change
[        ] [DEVICE LOG] {hostId: JtaSMOrZNlOlKQLPLCfDgWCglF93, guestId: 9xqbCzwstrOI7MVXW7cLG2KMP0u1, marketId: 9xqbCzwstrOI7MVXW7cLG2KMP0u1, title: My Market, lastMessage: test, updatedAt: 2018-10-10 10:29:24.710, createdAt: 2018-10-10 10:29:24.710}
[        ] flutter: change
[        ] {hostId: JtaSMOrZNlOlKQLPLCfDgWCglF93, guestId: 9xqbCzwstrOI7MVXW7cLG2KMP0u1, marketId: 9xqbCzwstrOI7MVXW7cLG2KMP0u1, title: My Market, lastMessage: test, updatedAt: 2018-10-10 10:29:24.710, createdAt: 2018-10-10 10:29:24.710}
[        ] [DEVICE LOG] 2018-10-22 22:58:48.643003+0900  localhost Runner[27014]: (Flutter) flutter: init
[        ] flutter: init
[  +12 ms] [DEVICE LOG] 2018-10-22 22:58:48.655261+0900  localhost Runner[27014]: (Flutter) flutter: ConnectionState.waiting
[        ] [DEVICE LOG] 2018-10-22 22:58:48.655327+0900  localhost Runner[27014]: (Flutter) flutter: null
[        ] flutter: ConnectionState.waiting
...

[✓] Flutter (Channel beta, v0.8.2, on Mac OS X 10.14 18A391, locale en-KR)
    • Flutter version 0.8.2 at /Users/hyochan/flutter/sdk
    • Framework revision 5ab9e70727 (6 weeks ago), 2018-09-07 12:33:05 -0700
    • Engine revision 58a1894a1c
    • Dart version 2.1.0-dev.3.1.flutter-760a9690c2

[✓] Android toolchain - develop for Android devices (Android SDK 27.0.3)
    • Android SDK at /Users/hyochan/Library/Android/sdk
    • Android NDK location not configured (optional; useful for native profiling support)
    • Platform android-27, build-tools 27.0.3
    • ANDROID_HOME = /Users/hyochan/Library/Android/sdk
    • Java binary at: /Applications/Android Studio.app/Contents/jre/jdk/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 1.8.0_152-release-1024-b01)
    • All Android licenses accepted.

[✓] iOS toolchain - develop for iOS devices (Xcode 10.0)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Xcode 10.0, Build version 10A255
    • ios-deploy 1.9.2
    • CocoaPods version 1.5.3

[✓] Android Studio (version 3.1)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin version 27.1.1
    • Dart plugin version 173.4700
    • Java version OpenJDK Runtime Environment (build 1.8.0_152-release-1024-b01)

[!] VS Code (version 1.28.2)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension not installed; install from
      https://marketplace.visualstudio.com/items?itemName=Dart-Code.flutter

[✓] Connected devices (1 available)
    • iPhone 6 • 1D1C8F6D-7C5E-46FC-B9E2-A9B69968979F • ios • iOS 12.0 (simulator)

! Doctor found issues in 1 category.

This looks like a support request.
Did you try asking on StackOverflow?

@zoechi Ok. I will. But this looks really weird to me.

@zoechi Yes. But then I am listening to userBloc.userStream which is stream from firestorm DocumentSnapshot.

@zoechi Thanks for the reply. I've done the firestorm subscription like below, then still the same.
userStream = Firestore.instance.collection('users').document(uid).snapshots().asBroadcastStream();

userStream.listen((snap) {
})l

The funny thing is that it works fine if I remove `userStream.listen`.

What if you remove asBroadcastStream().
You shouldn't need that and it probably leads to behavior you don't expect.

@zoechi I've tried that too. I have added asBroadcastStream to try out for your answer. I've looked in the code in firestore plugin. There was already StreamController with Broadcast.
controller = StreamController<DocumentSnapshot>.broadcast(

I almost give up using firestore stream in my custom bloc object. No article helps to solve this problem. Is there any good tutorial that uses custom bloc listening to firestore's stream? I want to fetch the data from firestore` first then assign to my custom model class.
Also I've posted this to stackoverflow.

@zoechi I feel like this could be reopened because when I try to listen on my own stream object, it works fine. It hangs only when I try to listen to firestore stream. So I mean it works when I try to
final _user = StreamController<UserModel>.broadcast();
Stream<UserModel> get user => _user.stream;
Function(UserModel) get setUser => _user.sink.add;

Stream<DocumentSnapshot> userStream = Firestore.instance.collection('users').document(uid).snapshots();

user.listen((data) {
});

instead
userStream.listen((data) {
});

It probably "hangs" because it waits for an event that is never emitted.
I think this needs to be tracked down to something more concrete.
I don't see how the Flutter team could reproduce your current issue without your whole Firebase setup.
If it's an issue with bloc it shouldn't be hard to reproduce without Firebase.
If it's an issue with Firebase it shouldn't be easy to reproduce without bloc.

@zoechi Thank you. I will try to dig this more. One last question.
I want to prevent flutter from dropping broadcast stream event when no widget is listening. Because I want to listen to this in other page routes.
I have bloc object like below.
    class UserBloc extends Object {
        final _user = StreamController<UserModel>.broadcast();
        final _uid = StreamController<String>.broadcast();

        Stream<UserModel> get user => _user.stream;
        Stream<String> get uid => _uid.stream;

        Function(UserModel) get setUser => _user.sink.add;
        Function(String) get setUID => _uid.sink.add;

I am listening to those streams in my sub page route
    StreamBuilder(
        stream: userBloc.user,
        builder: (context, snapshot) {
        print(snapshot.connectionState);
        print(snapshot.data);
        return Text('hi');
        },
    ),

It works without using broadcast stream. However, no luck when I changed to broadcast.
The problem is broadcast streams drop events when no one is listening as you described but I want my widget to start listening when my other MaterialPage pops up.
Using broadcast stream, data is always null in stream when my widget started listening.
How can I achieve this?

What if you remove asBroadcastStream().
You shouldn't need that and it probably leads to behavior you don't expect.

As I said, broadcast stream is probably not what you want.
A BroadcastStream is for events like mousemove where you don't care events being dropped when nobody is listening.
If you don't want to lose events, don't use BroadcastStream.

@zoechi Thanks again for clarifying this. Ok, then I may restructure my app to create bloc instance right after the Widget in my page route creates. I was trying to create one global bloc and subscribe them in multiple widgets.

I ran into this exact issue. I'm sharing my solution in hopes that some poor soul who stumbles upon this same thread may glean some insight from my findings.
My issue was this: I didn't want to have two streams listening to Firestore. I only wanted one stream to reduce Firebase costs. Here is how I solved the issue.
Basically, create a new StreamController and pass every event received from your original stream to your stream controller
This is an example of my class that retrieves Firebase content and sets up the streams.
class FirebaseStreams {
  StreamController<QuerySnapshot> _streamController = StreamController<QuerySnapshot>();

  // StreamBuilder widget will listen to this
  Stream<QuerySnapshot> get stream => _streamController.stream;

  StreamSubscription<QuerySnapshot> _streamSubscription;

  // This is the Firestore query that is built to retrieve a stream of documents
  Stream<QuerySnapshot> get allUsers {} // TODO

  init() {
    _streamSubscription = allUsers.listen((event) {
      // Pass the event from the stream to your streamController so that you can listen to its own stream in your StreamBuilder widget
      _streamController.sink.add(event);

      // TODO do whatever else you would like with the event
    });
  }

  dispose() {
    _streamController.close();
    _streamSubscription.cancel();
  }
}

This is the StreamBuilder widget.
return StreamBuilder<QuerySnapshot>(
  stream: firebaseStreams.stream,
  builder: (context, snapshot) {
    /// TODO
  }
);

After doing this, I was able to listen to my stream and do what I please with that data, and then set up a StreamBuilder to show the data to the user.


Merchant name got modified to "none" after smartscanning

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number:
Reproducible in staging?: Needs reproduction
Reproducible in production?: Needs reproduction
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @puneetlath
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1702933304718039
Action Performed:

Open chat
Add an expense by smartscan process

Expected Result:
Merchant name should remail as in the receipt
Actual Result:
Merchant name changed to none for some reason
Workaround:
unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android: Native
[ ] Android: mWeb Chrome
[ ] iOS: Native
[ ] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[ ] MacOS: Desktop

Screenshots/Videos
Add any screenshot/video evidence

View all open jobs on GitHub

Nov 29 20:51 - Expense is created with a merchant value of "none", as expected because it hasn't been smartscanned (logs)
Nov 29 20:53 - Smartscan agent correctly enters "Kaigo Steak House" (logs)
Nov 29 21:01 - Onyx does something(?) and the merchant is registered as (none)  (logs)

Noting that I'm on leave from tomorrow until Jan 8th and will check in on my return.

I suspect that the merchant is getting cleared out when we set the category of the expense.

It looks like we sent a request here that cleared out the merchant to "(none").

Here's what I see happening via the logs:

The Scan money request is created here
7 seconds afterwards, the category is updated here
The SmartScan job runs after, and updates the merchant to KAIGO COFFEE ROOM here

The expense seems to have all the expected fields when SmartScan finishes. I'm seeing that it was merged with a card transaction a few weeks afterwards, so I'm wondering if this is what caused the merchant to get cleared.

Here we send out the updated transaction via Pusher and save it correctly into the Onyx store

I'm not seeing any subsequent Onyx updates where the merchant is being reset to (none)

I can't reproduce the bug either, and there's no evidence of the merchant being cleared in the DB or in Onyx 😨

I've posted some questions/notes here–hopefully @puneetlath can help me take a look 🙇

Not overdue, @puneetlath would love your thoughts on this! Unfortunately this example is too far back to find good logs in Logsearch anymore.

Not overdue, was OOO and looking into this today

It's been a while since this has happened, so either the bug was fixed or it'll happen again. The logs when this last happened happened too long ago, so I'm going to demote the priority to weekly cc @puneetlath

Let's just close it and I'll reopen if I see it again. Thanks!


[Misc] benchmark: Add option to set max concurrency

Add a new flag to benchmark_serving.py that allows you to specify
the maximum number of concurrent requests. If not specified, it
defaults to the current behavior of unbounded concurrency.
Closes #3127
Signed-off-by: Russell Bryant<EMAIL_ADDRESS>

In general LGTM. One question I have is how should this be used together with request rate (QPS)? Are we expecting only one of them being set at a time?

For me, maximum concurrency is mainly used to avoid request buffer overflow at inference engine side (IIRC if we send >1000 requests to vLLM, TGI or other inference engines, there will be request failure due to request buffer overflow). This should always be set when benchmarking many request under very high QPS to prevent request failure.

The message looks good to me. In addition, please also update other parts such as logging and dumped file name. Please search request_rate in this file and make sure max_concurrency is reflected to these places as well.

The message looks good to me. In addition, please also update other parts such as logging and dumped file name. Please search request_rate in this file and make sure max_concurrency is reflected to these places as well.

I added some logging and added max_concurrency to the output json data.
I wasn't sure about the default filename, though. request-rate always has a value (defaults to inf), while max-concurrency defaults to None. At some point, it seems reasonable to just fall back to the ability to set custom filenames. If you feel strongly about this though, I'll update this to conditionally include the concurrency setting when it is set.

The message looks good to me. In addition, please also update other parts such as logging and dumped file name. Please search request_rate in this file and make sure max_concurrency is reflected to these places as well.

I added some logging and added max_concurrency to the output json data.
I wasn't sure about the default filename, though. request-rate always has a value (defaults to inf), while max-concurrency defaults to None. At some point, it seems reasonable to just fall back to the ability to set custom filenames. If you feel strongly about this though, I'll update this to conditionally include the concurrency setting when it is set.

Just make it simple like the following?
max_concurrency_str = f"-concurrency{args.max_concurrency}" if args.max_concurrency is not None else ""
file_name = f"{backend}-{args.request_rate}qps{max_concurrency_str}-{base_model_id}-{current_dt}.json"  #noqa

Just make it simple like the following?

sure, that works.  done!

CI is currently failing on the use of contextlib.nullcontext(). It looks like it worked for me because I was using a newer version of Python, while it's failing with 3.9 in CI.
asyncio support was added to nullcontext in 3.10: https://github.com/python/cpython/issues/85715


feat/1243-Smooth Scrollbar Implementation

PR Fixes:

1 #1243

Resolves #1243

Checklist before requesting a review

[x] I have performed a self-review of my code
[x] I assure there is no similar/duplicate pull request regarding same issue

@hkirat @devsargam sir, please review this code

There's a lot of noise for such a small pr. Closing reopen with minimal changes

it will do changes automatically.


Typo ?

In the "Registering Azure Stack with the guest directory" section it says "they must register Azure Stack".  Who are "they" ?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 27974ff6-00a9-4ed4-94ab-6b7dd1e2325e
Version Independent ID: ffbe2e63-9cd2-327b-759c-6663517d7132
Content: Enable multi-tenancy in Azure Stack
Content Source: articles/azure-stack/azure-stack-enable-multitenancy.md
Service: azure-stack
GitHub Login: @mattbriggs
Microsoft Alias: mabrigg

@cenkersoy Thanks for your feedback! We will investigate and update as appropriate.


parse_metric not taking all data

Is there a reason why on prese metric the for of the series values taking only the mins_to_check?
Because the datapoint are second so basically, if the default is 5 the function has 5 min of data - 300 datapoints, but on the series it will save only 5 seconds.
https://github.com/arachnys/cabot/blob/master/cabot/cabotapp/graphite.py#L81

There is a PR in there to address this: https://github.com/arachnys/cabot/pull/366
I'm waiting on @JeanFred for review.

Great!
I fixed it localy but wanted to make sure if there is a reason or I should open a pull request here, thanks!


Make a Spool Grid Summary in Home page

This is just a suggestion, to be able to see all the spools at once. Perhaps just show the spool image with the color and then a tooltip on every spool indicating the name. This way we could see 50 or 100 spools at a glance without going thru the grid pages.
As I said, this is a suggestion. I find the app very interesting and honestly the only one that I could use to catalog my spools, but a quick glance of the colors would be very appreciated.

I am new to Spoolman (just testing the docker) and I was surprised this colour-grid feature was not included, and duplicate spools are shown.
Other (off-topic) features I am missing, that make me think this software is not for me:

If I would want to do book keeping, i would use spreadsheets instead. On this note, import/export are missing.
Many spools I buy are refills, so no spool. But the page does not allow entering explicitly 0 (zero) weight to indicate this.
Nearly 99% of all filaments is 1.75mm but why is this a text input, and why do we have to enter it every time again when adding kinds of filaments.


Refactor code for bill management

This edit bill feature doesn't work with this branch because the route for edit bill on the frontend is the old route

Added fix by changing route on client side


Carousel Slider fix

Carousel Slider fix - removed second scroll-bar while switching items.

LGTM, thanks! :-)


MarkerClusterGroup very low performance with large number of markers

Hello!
In  my environment, I am using:

"leaflet": "1.7.1"
"react-leaflet": "2.7.0"
"react-leaflet-markercluster": "2.0.0"

Tried to load around 1000 markers but the performance is very very low. Did some debugging and it looks like the clusters are being recalculated unnecessarily for some reason.
I found a sandbox to test this from this comment https://github.com/yuzhva/react-leaflet-markercluster/issues/21#issuecomment-610924137:
https://codesandbox.io/s/gallant-leakey-qqupl?file=/src/App.js
Sandbox env:

"leaflet": "1.7.1"
"leaflet.markercluster": "1.4.1"
"react-leaflet": "3.0.2"
"react-leaflet-markercluster": "3.0.0-rc1"

Does the sandbox need leaflet.markercluster package? I am not using it on my local env.

Same here, totally useless with 10k markers.

Same here, totally useless with 10k markers.

I have just 600 markers. I'm using custom functions for both the marker icon and the cluster icon, (although these just return an svg, or an svg with a number inside, so should be a pretty low performance impact.)
As an example, on a fairly wide zoom on my map, I see three clusters of 80, 450, and 20. One zoom step out, and they all collapse to a single cluster.
Looking in Chrome performance tools, I can see that switching between these two zoom levels is generating hundreds of function calls, creating and destroying individual markers, taking up to 3 seconds to redraw, and the whole page is unresponsive while it does this.
I'd love to figure out how to improve the performance - Even just doing this in the background would help. If it's struggling on my 600 point sample data, there's no way I can scale this to the 20,000 points I need to. Any pointers please?

I have just 600 markers. I'm using custom functions for both the marker icon and the cluster icon, (although these just return an svg, or an svg with a number inside, so should be a pretty low performance impact.)
As an example, on a fairly wide zoom on my map, I see three clusters of 80, 450, and 20. One zoom step out, and they all collapse to a single cluster.
Looking in Chrome performance tools, I can see that switching between these two zoom levels is generating hundreds of function calls, creating and destroying individual markers, taking up to 3 seconds to redraw, and the whole page is unresponsive while it does this.
I'd love to figure out how to improve the performance - Even just doing this in the background would help. If it's struggling on my 600 point sample data, there's no way I can scale this to the 20,000 points I need to. Any pointers please?

To me the codesandbox works just fine, I can move the map and zoom in/out without problems. Is this issue resolved then?

To me the codesandbox works just fine, I can move the map and zoom in/out without problems. Is this issue resolved then?

To me the codesandbox works just fine, I can move the map and zoom in/out without problems. Is this issue resolved then?

It is working fine for me as well now. Not sure how the performance was improved since there were any commits...

To me the codesandbox works just fine, I can move the map and zoom in/out without problems. Is this issue resolved then?

It is working fine for me as well now. Not sure how the performance was improved since there were any commits...

This issue was resolved years ago in #86 has finally been merged into #211. This will be included in the 4.1.0 release very soon!


Fix typo in Microsoft on Line 21

Fix typo in Microsoft on Line 21, missing "M"

Fix typo in line 21 for "Microsoft" missing an "M"


PLFM-6766: Restore file handles job

Depends on https://github.com/Sage-Bionetworks/Synapse-Stack-Builder/pull/415


Problem with volume on /etc/localtime and SELinux

Hi all
It seems that we cannot map /etc/localtime  as a volume anymore.
When using -v /etc/localtime:/etc/localtime:ro
I get the message Relabeling content in /usr is not allowed.
$ docker --version
Docker version 1.6.0, build 3eac457/1.6.0

$ docker run -ti busybox echo hello
hello

$ docker run -ti -v /etc/localtime:/etc/localtime:ro busybox echo hello
Timestamp: 2015-04-27 13:49:44.183916212 +0000 UTC
Code: System error

Message: Relabeling content in /usr is not allowed.

Frames:
---
0: setupRootfs
Package: github.com/docker/libcontainer
File: rootfs_linux.go@34
---
1: Init
Package: github.com/docker/libcontainer.(*linuxStandardInit)
File: standard_init_linux.go@52
---
2: StartInitialization
Package: github.com/docker/libcontainer.(*LinuxFactory)
File: factory_linux.go@223
---
3: initializer
Package: github.com/docker/docker/daemon/execdriver/native
File: init.go@35
---
4: Init
Package: github.com/docker/docker/pkg/reexec
File: reexec.go@26
---
5: main
Package: main
File: docker.go@29
---
6: main
Package: runtime
File: proc.go@63
---
7: goexit
Package: runtime
File: asm_amd64.s@2232
FATA[0000] Error response from daemon: Cannot start container b1f47bc498357ae6cc086641620999597cbc243c9eee1bab9f81690ed0781072: [8] System error: Relabeling content in /usr is not allowed.

$ cat /etc/redhat-release
Fedora release 21 (Twenty One)

$ uname -srvmpio
Linux 3.19.5-200.fc21.x86_64 #1 SMP Mon Apr 20 19:51:56 UTC 2015 x86_64 x86_64 x86_64 GNU/Linux

$ sestatus
SELinux status:                 enabled
SELinuxfs mount:                /sys/fs/selinux
SELinux root directory:         /etc/selinux
Loaded policy name:             targeted
Current mode:                   enforcing
Mode from config file:          enforcing
Policy MLS status:              enabled
Policy deny_unknown status:     allowed
Max kernel policy version:      29

$ ls -alF /etc/localtime
lrwxrwxrwx. 1 root root 23 27 avril 12:27 /etc/localtime -> /usr/share/zoneinfo/UTC

It was supported on earlier version of Docker.
Am I doing it wrong?

ping @rhatdan

What version of docker are you using
rpm -q docker

$ rpm -q docker-io
docker-io-1.6.0-2.git3eac457.fc21.x86_64

Also noted that mounting the file as read-only volume fails
$ docker run -ti -v /etc/localtime:/etc/localtime:ro busybox echo hello
Timestamp: 2015-04-27 21:34:58.625118144 +0000 UTC
Code: System error

Message: Relabeling content in /usr is not allowed.

Frames:
---
0: setupRootfs
Package: github.com/docker/libcontainer
File: rootfs_linux.go@34
---
1: Init
Package: github.com/docker/libcontainer.(*linuxStandardInit)
File: FATA[0000] Error response from daemon: Cannot start container 35feaf749f688a34571c2e1ac3126e0613a2da428f9b12f6c7cef1d8861261f9: [8] System error: Relabeling content in /usr is not allowed.

but mounting it without any specification succeed
$ docker run -ti -v /etc/localtime:/etc/localtime busybox echo hello
hello

Not sure if it's related, but I am getting the same error message. My code is at https://github.com/beeradb/webdrupal-docker (see bootstrap.sh and containers/docker-compose.yml)
In my case, it appears to only happen when I try to mount vagrant sync_folders, i.e. /usr/share/webdrupal  mounting into  /usr/share/webdrupal in my container.
My docker version is "Docker version 1.6.0, build 3eac457/1.6.0". Let me know if I can provide more info.

I should also note it only seems to happen if you include a filemode (which docker-compose does)...
[vagrant@localhost ~]$ sudo docker run -ti -v /usr/share/webdrupal:/usr/share/webdrupal busybox echo hello
hello
[vagrant@localhost ~]$ sudo docker run -ti -v /usr/share/webdrupal:/usr/share/webdrupal:ro busybox echo hello
FATA[0000] Error response from daemon: Cannot start container 50122753f10686b779af1a0a674240e9064cb5e082d679ce69b8ee85dc942c9e: [8] System error: Relabeling content in /usr is not allowed.
[vagrant@localhost ~]$ sudo docker run -ti -v /usr/share/webdrupal:/usr/share/webdrupal:rw busybox echo hello
Timestamp: 2015-04-28 00:06:48.50426352 +0000 UTC
Code: System error

Message: Relabeling content in /usr is not allowed.

Frames:
---
0: setupRootfs
Package: github.com/docker/libcontainer
File: rootfs_linux.go@34
---
1FATA[0000] Error response from daemon: Cannot start container 7db5ba68b77eb216623483196f0f3f202ac6b69a9076f479ad30216c9d81722c: [8] System error: Relabeling content in /usr is not allowed.

Does this work fine with the docker-io package shipped with fedora 21?

@rhatdan no it does not work precisely with that package, please see my previous comment [https://github.com/docker/docker/issues/12811#issuecomment-96827810] providing the name of the offending package.
You can reproduce in 3 minutes on Digital Ocean by creating a fresh fedora 21 machine and just yum install -y docker-io && service docker restart && docker run -ti -v /etc/localtime:/etc/localtime:ro busybox echo hello

Yann, I  think I have seen it, please open a Bugzilla on this package.  Working with the latest docker-1.6 packages I am not seeing it, and working with master branch it seems to work fine.
rpm -q docker
docker-1.7.0-2.git50ef691.fc23.x86_64
If you open a bugzilla I will get the packager to push an update to Fedora 21.

Thank you Dan
I reported the problem in bugzilla as you suggested
https://bugzilla.redhat.com/show_bug.cgi?id=1216151

Great.  Thanks.

I'm still seeing this problem with this version:
$ rpm -q docker-io
docker-io-1.6.0-2.git3eac457.fc21.x86_64

And it looks like volume-mounting my host directories don't work either.

@ksylvan I answered in the bugzillas on the volume mount.  Lets carry on the discussion in the bugzillas.

I am looking to move the Kubernetes Vagrant cluster to Fedora 21 in order to pick up Docker 1.6+ and I am seeing a similar error when trying to run any pod.
Is there a work-around?
Code: System error

Message: Relabeling content in /usr is not allowed.

Frames:
---
0: setupRootfs
Package: github.com/docker/libcontainer
File: rootfs_linux.go@34
---
1: Init
Package: github.com/docker/libcontainer.(*linuxStandardInit)
File: standard_init_linux.go@52
---
2: StartInitialization
Package: github.com/docker/libcontainer.(*LinuxFactory)
File: factory_linux.go@223
---
3: initializer
Package: github.com/docker/docker/daemon/execdriver/native
File: init.go@35
---
4: Init
Package: github.com/docker/docker/pkg/reexec
File: reexec.go@26
---
5: main
Package: main
File: docker.go@29
---
6: main
Package: runtime
File: proc.go@63
---
7: goexit
Package: runtime
File: asm_amd64.s@2232

$ rpm -q docker-io
docker-io-1.6.0-4.git350a636.fc21.x86_64

@derekwaynecarr according to this comment https://bugzilla.redhat.com/show_bug.cgi?id=1216151#c5 this should be fixed in the docker 1.6.2 packaged by Red Hat.
I'm going to close this issue, because this is an issue in docker as packaged by Red Hat and according to https://bugzilla.redhat.com/show_bug.cgi?id=1216151#c5 this should be resolved in 1.6.2.
Feel free to comment here if you think I closed this by mistake


add hostdir e2e test

test passed on my own repo dalanlan/host-dir-mounttest
Signed-off-by: He Simei<EMAIL_ADDRESS>

/cc @thockin

Doesn't this change touch secrets e2e too?
On Mon, May 4, 2015 at 11:42 PM Robert Bailey<EMAIL_ADDRESS>wrote:

/cc @thockin https://github.com/thockin
—
Reply to this email directly or view it on GitHub
https://github.com/GoogleCloudPlatform/kubernetes/pull/7756#issuecomment-98932258
.

I could use some advice.
When i conducted local test, i would run make manually under the contrib/for-tests/mount-host-dir-tester to generate available binary and image, where occurred as a problem here.
Any help would be appreciated.

I really appreciate getting this test!  I wonder if there is an easier attack, though?
Would it be sufficient to simply schedule a pod onto a known node, where the pod is simply a busybox script that writes the hostname to a fixed path and sleeps forever?  verification becomes simply ssh to node, ensure that the correct file was written on the host,
container: busybox sh -c "hostname > /host/hostname; sleep 3600"
verify: ssh to node & read /tmp/host-dir-volume-test
Maybe I am nuts - I just get worried that we have a growing number of containers floating around that we have to build and push and pull...

Would it make any sense to you if i just use my own repo dalanlan/host-dir-mounttest as the image of the containers? Then we could save the build and push work, sacrificing transparency may harm though. @thockin
Or i'll take your advice with pleasure:)

The mount tester image can write a file for you.
On Tue, May 5, 2015 at 8:26 PM Emma He<EMAIL_ADDRESS>wrote:

Would it make any sense to you if i just use my own repo
dalanlan/host-dir-mounttest as the image of the containers? Then we could
save the build and push work, sacrificing transparency may harm though.
@thockin https://github.com/thockin
Or i'll take your advice with pleasure:)
—
Reply to this email directly or view it on GitHub
https://github.com/GoogleCloudPlatform/kubernetes/pull/7756#issuecomment-99271185
.

We don't want to rely on images we can't control and change as needed, so
ideally we use either a very generic one like busybox or one we control
like you have proposed.  I'm OK with either, I guess.
On Tue, May 5, 2015 at 5:50 PM, Paul Morie<EMAIL_ADDRESS>wrote:

The mount tester image can write a file for you.
On Tue, May 5, 2015 at 8:26 PM Emma He<EMAIL_ADDRESS>wrote:

Would it make any sense to you if i just use my own repo
dalanlan/host-dir-mounttest as the image of the containers? Then we could
save the build and push work, sacrificing transparency may harm though.
@thockin https://github.com/thockin
Or i'll take your advice with pleasure:)
—
Reply to this email directly or view it on GitHub
<
https://github.com/GoogleCloudPlatform/kubernetes/pull/7756#issuecomment-99271185

.

—
Reply to this email directly or view it on GitHub
https://github.com/GoogleCloudPlatform/kubernetes/pull/7756#issuecomment-99277329
.

I use the existing image kubernetes/mounttest:0.1 instead. I doubt whether it makes sense at the beginning since it was built from scratch.
Travis-cli passed. plz kindly have a check:)
@pmorie @thockin

Fixed:)
@quinton-hoole

Other than the two minor comment, LGTM.
My apologies for not spotting those in my first review.

@dalanlan Please let me know when you've addressed the remaining feedback.  Thanks.

I did that part the day before yesterday, but travis-ci seemed to hang there.
I'll see what I can do. @quinton-hoole

WHAT A SHAME!
e2e/host_path.go has already been there. You could simply close this pr:(
@quinton-hoole

Ahhhh, i had a problem with host_path.go here.
Is it gorgeous enough to test write & read with a single container? I thought the writing test should be checked by another container so that we can make sure the volume is shared between pod.
https://github.com/GoogleCloudPlatform/kubernetes/blob/master/test/e2e/host_path.go#L90

@pmorie I don't know much about secrets.  What did you have in mind in your comment above.
cc: @erictune FYI
@dalanlan Yes, I think that we should test writing and reading from different containers. I hope to complete this review soon :-)

status: awaiting review.

It's not clear whether @dalanlan still want's this PR merged?  Her comment on May 17, 5:54pm ("OH WHAT A SHAME... You could simply close this pr:("  indicates perhaps not.  Closing.  Please re-open if you still require it to be reviewed and merged.

Oops...
i still want it to be reviewed (volumes shared among different containers would be better), yet i guess it would be better to open another pr to finish this job for it may cost a lot to rebase:)
Will do it later.

@quinton-hoole


Apply validator even if matching data attribute is empty or 0

Html:
<input type="text" data-pizza="0" />

Js:
$form.validator({
    custom: {
        pizza: function($el) {
            return true;
        }
    },
    errors: {
        pizza: '[Pizza] Error'
    }
});

This validator wont be applied because js treats 0 as falsy.

Yes! I just need it!
I think this feature is interesting, because some validation doesn't need an argument. In this case, the html line will be refined, ie <input type="text" data-foo /> , instead of <input type="text" data-foo="fake-value-to-make-it-work" /> .


Tooltips/Popups are more sticky than before

Type: Bug
Since the upgrade to 1.91.1, the tooltips/popups (that show function documentation on mouseover, for example) have become a hinder, because they seem to get sticky, being in the way when I want to select/click something on the lines that the tooltip/popup is overlaying.
I'm not 100% sure how to explain this, or what exactly changed, but I know this wasn't a problem in the version before. Something definitely changed in version 1.91.1.
I'm not sure if it's because they're appearing faster, or taking longer to disappear, or...
Thank you!
 Last iteration I have refactored the editor hover code so this could be the source of the new issue you are seeing. For me to understand better the situation, next time you see the issue you described, could you post a screen recording here and an example of the code where you are seeing the issue?

Thank you.
I cannot show much of the code, but here's a short video which I hope helps. (I tried to "exaggerate/force" a bit, but it should show what I mean)
These editor hovers have been annoying me all day, since the update. They just keep being in the way.
In previous versions, wasn't the hover disappearing when the mouse leaves the tooltip?
Or when the user is selecting text?
Thanks.
https://github.com/user-attachments/assets/b935bcc6-ca47-4ff7-9a8d-3648acf78798

What version were you previously on?

Hi @ghnp5 the hover should still disappear if you keep your mouse outside of the hover for long enough. Perhaps you could change the value of the setting editor.hover.hidingDelay. This setting controls how quickly the hover disappears. The default is 300 ms, meaning that after 300 ms outside of the hover it disappears. Similarly you could tweak the setting editor.hover.delay - this setting controls how quickly the hover shows, ie how long the cursor needs to be on a word before the hover is shown.

What version were you previously on?

I believe I was on 1.91.0, but maybe I didn't use it enough between upgrading to that one, and 1.91.1, to find this issue.
Before that, I was on last month's iteration, which definitely didn't have this problem.

Perhaps you could change the value of the setting editor.hover.hidingDelay.

Thank you. I was going to change that option, and then I saw a hint about editor.hover.sticky having to be enabled. So, what I did is I actually disabled that one.
Seems to have improved a bit. It seems to be still remaining sticky if I do put the mouse over it, so I'm not sure what exactly that option does (its description says the hover will remain visible when mouse is moved over it), but somehow, disabling this option makes the hover disappear if I move the mouse outside the code that triggered the hover, which is similar to the behavior I had before, I think. And if I click on the hover, it remains sticky, which is good/expected.

Similarly you could tweak the setting editor.hover.delay

Great. I changed from 300 to 600, so it doesn't appear so quickly.
--
Thank you for the tips.
I think there's still one question left -- what about when I'm selecting text (like shown in the video above) ? Wasn't the hover supposed to disappear, once I'm selecting text, and therefore the user is not interested in having a hover in the way of the selection? :)
Many thanks, again!

Hi @ghnp5 thank you for the comment. When the cursor has some text selected, and you hover on a word long enough, the editor hover will appear. Here the editor selection does not affect the appearance of the editor hover, currently what matters is that the mouse is on or outside of the hover long enough for it to appear/disappear. The idea you put forth is interesting however, and I will open an issue about it. If the community votes sufficiently for it, I can make this change.

I am having an issue with this as well since updating versions.  I attached some images.
attempting to drag selected text into the object

once selected tooltip stays in place permanently blocking destination

I think once you hold down left click on a selection to start moving, the tooltip should always disappear.  At least that is the behavior that you would expect in most applications.

+1 to this, also experiencing the same issue after updating versions

Also having this issue. The Hover Hide Delay is using the Hover Delay instead, so if you have a long delay before the tooltip appears, you will have a long delay before it disappears.
If you set the Hover Delay to 0 and the Hover Hide Delay to 1000, should see the tooltip appear and disappear instantly

Hi @ghnp5 thank you for the comment. I believe the way the editor hover works is that when you click outside of the hover, the hover disappears. Meaning when you start a selection it disappears.

I have noticed and issue when using VS Code, in which the clicking outside of a tooltip will no longer dismiss hover. This occurs after leaving VS Code open for a while, including after a sleep/hibernate cycle. When this happens I have to restart VS Code, otherwise, clicking anywhere, including to initiate text selection does not dismiss any existing tooltip and the tool tip then interferes with the selection process.
Perhaps there is a bug that is causing the described tooltip/click behavior to break after leaving VS Code open for some time. It might be related to this issue of tooltips being more sticky than intended.
--
Version: 1.92.1 (user setup)
Commit: eaa41d57266683296de7d118f574d0c2652e1fc4
Date: 2024-08-07T20:16:39.455Z
Electron: 30.1.2
ElectronBuildId: 9870757
Chromium: 124.0.6367.243
Node.js: 20.14.0
V8: <IP_ADDRESS>-electron.0
OS: Windows_NT x64 10.0.22621

@MohenjoDaro https://github.com/microsoft/vscode/issues/221607#issuecomment-2267397977 supports your theory.

Hi @MohenjoDaro thanks a lot for finding this error in the code. If you would like you can make a PR containing this finding, so we can merge your fix and you can participate as a community member into the project. If not I will make the fix that you write :). Thanks for the catch.

@aiday-mar If you could make the fix, that'd be great, I'm not very familiar with git

Sounds good thanks again

Hi the PR that fixes this issue is here https://github.com/microsoft/vscode/pull/225687. When this is merged, you should see the correct behavior in tomorrow's insiders release or next month's stable release. Please let me know if this is not the case and you continue seeing this issue.


Address many long-standing LGTM complaints

Describe the bug
LGTM calls out many things that it sees as problems, which we have never addressed.
To Reproduce
Submit a pull request, and watch LGTM report more than 150 issues that have nothing to do with your changes.
Expected behavior
LGTM should have little or (preferably) nothing to point out.

Thanks for starting this @mwoodiupui !  I'm definitely supportive of getting things cleaned up more.  Pulling this over onto the 7.4 board, so that we can try to fit this into that next release.

Initial PR #8321 was merged into 7.4

Closing this as LGTM is no more & the original work was already merged.  Now, these "complaints" have moved over into GitHub Code Scanning, where they appear as their own "ticket".  So, they can be addressed one by one or in bulk as folks see fit.  See https://github.com/DSpace/DSpace/security/code-scanning


Add Asset resource

This adds the Asset resource.
Closes #17.
Tests fails, but they should pass once #65 is merged.

Tests still fail https://travis-ci.org/microapps/Nodify-Shopify

Yes, noticed, I'll fix it in a bit.


Can't run brew style and audit: incompatible library version - jaro_winkler-1.5.2

[ ] are reporting a bug others will be able to reproduce and not asking a question. If you're not sure or want to ask a question do so on our Discourse: https://discourse.brew.sh
[x] ran a brew command and reproduced the problem with multiple formulae? If it's a problem with a single, official formula (not cask) please file this issue at Homebrew/homebrew-core: https://github.com/Homebrew/homebrew-core/issues/new/choose. If it's a brew cask problem please file this issue at https://github.com/Homebrew/homebrew-cask/issues/new/choose. If it's a tap (e.g. Homebrew/homebrew-php) problem please file this issue at the tap.
[X] ran brew update and can still reproduce the problem?
[X] ran brew doctor, fixed all issues and can still reproduce the problem?
[X] ran brew config and brew doctor and included their output with your issue?

What you were trying to do (and why)
Run brew styleor brew audit
What happened (include command output)
It tried to update Homebrew's gems?
brew style git
Fetching gem metadata from https://rubygems.org/.........
Using concurrent-ruby 1.1.5
Using minitest 5.11.3
Using thread_safe 0.3.6
Using ast 2.4.0
Using backports 3.14.0
Using bundler 2.0.1
Using connection_pool 2.2.2
Fetching json 2.2.0
Using docile 1.3.1
Using simplecov-html 0.10.2
Using tins 1.20.2
Using thor 0.19.4
Using diff-lcs 1.3
Fetching unf_ext <IP_ADDRESS>
Fetching hpricot 0.8.6
Installing json 2.2.0 with native extensions
Installing hpricot 0.8.6 with native extensions
Installing unf_ext <IP_ADDRESS> with native extensions
Fetching jaro_winkler 1.5.2
Installing jaro_winkler 1.5.2 with native extensions
Using mime-types-data 3.2019.0331
Using net-http-digest_auth 1.4.1
Using mini_portile2 2.4.0
Using ntlm-http 0.1.1
Using webrobots 0.1.2
Using mustache 1.1.0
Using parallel 1.17.0
Using plist 3.5.0
Using rainbow 3.0.0
Fetching rdiscount <IP_ADDRESS>
Installing rdiscount <IP_ADDRESS> with native extensions
Using rspec-support 3.8.0
Using ruby-progressbar 1.10.0
Using unicode-display_width 1.5.0
Using ruby-macho 2.2.0
Using i18n 1.6.0
Using tzinfo 1.2.5
Using parser <IP_ADDRESS>
Using net-http-persistent 3.0.1
Using term-ansicolor 1.7.1
Using unf 0.1.4
Using mime-types 3.2.2
Fetching nokogiri 1.10.3
Using parallel_tests 2.28.0
Using activesupport 5.2.3
Using domain_name 0.5.20180417
Using rspec-core 3.8.0
Using rspec-expectations 3.8.3
Using rspec-mocks 3.8.0
Using rubocop 0.68.0
Using simplecov 0.16.1
Using http-cookie 1.0.3
Using rspec 3.8.0
Using rspec-its 1.3.0
Using rspec-retry 0.6.1
Using rubocop-performance 1.1.0
Using rubocop-rspec 1.32.0
Using coveralls 0.8.22
Using rspec-wait 0.0.9
Using simplecov-cobertura 1.3.1
Installing nokogiri 1.10.3 with native extensions
Using ronn 0.7.3
Using mechanize 2.7.6
Bundle complete! 18 Gemfile dependencies, 57 gems now installed.
Bundled gems are installed into `/usr/local/Homebrew/Library/Homebrew/vendor/bundle`
/usr/local/Homebrew/Library/Homebrew/vendor/portable-ruby/2.3.7/lib/ruby/2.3.0/rubygems/core_ext/kernel_require.rb:55:in `require': cannot load such file -- jaro_winkler (LoadError)
       from /usr/local/Homebrew/Library/Homebrew/vendor/portable-ruby/2.3.7/lib/ruby/2.3.0/rubygems/core_ext/kernel_require.rb:55:in `require'
       from /usr/local/Homebrew/Library/Homebrew/vendor/bundle/ruby/2.3.0/gems/rubocop-0.68.0/lib/rubocop/string_util.rb:3:in `<top (required)>'
       from /usr/local/Homebrew/Library/Homebrew/vendor/bundle/ruby/2.3.0/gems/rubocop-0.68.0/lib/rubocop.rb:17:in `require_relative'
       from /usr/local/Homebrew/Library/Homebrew/vendor/bundle/ruby/2.3.0/gems/rubocop-0.68.0/lib/rubocop.rb:17:in `<top (required)>'
       from /usr/local/Homebrew/Library/Homebrew/vendor/portable-ruby/2.3.7/lib/ruby/2.3.0/rubygems/core_ext/kernel_require.rb:55:in `require'
       from /usr/local/Homebrew/Library/Homebrew/vendor/portable-ruby/2.3.7/lib/ruby/2.3.0/rubygems/core_ext/kernel_require.rb:55:in `require'
       from /usr/local/Homebrew/Library/Homebrew/vendor/bundle/ruby/2.3.0/gems/rubocop-0.68.0/exe/rubocop:6:in `<top (required)>'
       from /usr/local/Homebrew/Library/Homebrew/vendor/bundle/ruby/2.3.0/bin/rubocop:22:in `load'
       from /usr/local/Homebrew/Library/Homebrew/vendor/bundle/ruby/2.3.0/bin/rubocop:22:in `<main>'
Error: style check failed

What you expected to happen
Run style
Step-by-step reproduction instructions (by running brew commands)
brew style wget
Error: incompatible library version - /usr/local/Homebrew/Library/Homebrew/vendor/bundle/ruby/2.3.0/gems/jaro_winkler-1.5.2/lib/jaro_winkler/jaro_winkler_ext.bundle
Please report this bug:
  https://docs.brew.sh/Troubleshooting
/usr/local/Homebrew/Library/Homebrew/vendor/portable-ruby/2.3.7/lib/ruby/2.3.0/rubygems/core_ext/kernel_require.rb:55:in `require'
/usr/local/Homebrew/Library/Homebrew/vendor/portable-ruby/2.3.7/lib/ruby/2.3.0/rubygems/core_ext/kernel_require.rb:55:in `require'
/usr/local/Homebrew/Library/Homebrew/vendor/bundle/ruby/2.3.0/gems/jaro_winkler-1.5.2/lib/jaro_winkler.rb:6:in `<top (required)>'
/usr/local/Homebrew/Library/Homebrew/vendor/portable-ruby/2.3.7/lib/ruby/2.3.0/rubygems/core_ext/kernel_require.rb:55:in `require'
/usr/local/Homebrew/Library/Homebrew/vendor/portable-ruby/2.3.7/lib/ruby/2.3.0/rubygems/core_ext/kernel_require.rb:55:in `require'
/usr/local/Homebrew/Library/Homebrew/vendor/bundle/ruby/2.3.0/gems/rubocop-0.68.0/lib/rubocop/string_util.rb:3:in `<top (required)>'
/usr/local/Homebrew/Library/Homebrew/vendor/bundle/ruby/2.3.0/gems/rubocop-0.68.0/lib/rubocop.rb:17:in `require_relative'
/usr/local/Homebrew/Library/Homebrew/vendor/bundle/ruby/2.3.0/gems/rubocop-0.68.0/lib/rubocop.rb:17:in `<top (required)>'
/usr/local/Homebrew/Library/Homebrew/vendor/portable-ruby/2.3.7/lib/ruby/2.3.0/rubygems/core_ext/kernel_require.rb:127:in `require'
/usr/local/Homebrew/Library/Homebrew/vendor/portable-ruby/2.3.7/lib/ruby/2.3.0/rubygems/core_ext/kernel_require.rb:127:in `rescue in require'
/usr/local/Homebrew/Library/Homebrew/vendor/portable-ruby/2.3.7/lib/ruby/2.3.0/rubygems/core_ext/kernel_require.rb:39:in `require'
/usr/local/Homebrew/Library/Homebrew/style.rb:23:in `check_style_impl'
/usr/local/Homebrew/Library/Homebrew/style.rb:10:in `check_style_and_print'
/usr/local/Homebrew/Library/Homebrew/cmd/style.rb:65:in `style'
/usr/local/Homebrew/Library/Homebrew/brew.rb:102:in `<main>'

brew style git
Error: incompatible library version - /usr/local/Homebrew/Library/Homebrew/vendor/bundle/ruby/2.3.0/gems/jaro_winkler-1.5.2/lib/jaro_winkler/jaro_winkler_ext.bundle
Please report this bug:
  https://docs.brew.sh/Troubleshooting
/usr/local/Homebrew/Library/Homebrew/vendor/portable-ruby/2.3.7/lib/ruby/2.3.0/rubygems/core_ext/kernel_require.rb:55:in `require'
/usr/local/Homebrew/Library/Homebrew/vendor/portable-ruby/2.3.7/lib/ruby/2.3.0/rubygems/core_ext/kernel_require.rb:55:in `require'
/usr/local/Homebrew/Library/Homebrew/vendor/bundle/ruby/2.3.0/gems/jaro_winkler-1.5.2/lib/jaro_winkler.rb:6:in `<top (required)>'
/usr/local/Homebrew/Library/Homebrew/vendor/portable-ruby/2.3.7/lib/ruby/2.3.0/rubygems/core_ext/kernel_require.rb:55:in `require'
/usr/local/Homebrew/Library/Homebrew/vendor/portable-ruby/2.3.7/lib/ruby/2.3.0/rubygems/core_ext/kernel_require.rb:55:in `require'
/usr/local/Homebrew/Library/Homebrew/vendor/bundle/ruby/2.3.0/gems/rubocop-0.68.0/lib/rubocop/string_util.rb:3:in `<top (required)>'
/usr/local/Homebrew/Library/Homebrew/vendor/bundle/ruby/2.3.0/gems/rubocop-0.68.0/lib/rubocop.rb:17:in `require_relative'
/usr/local/Homebrew/Library/Homebrew/vendor/bundle/ruby/2.3.0/gems/rubocop-0.68.0/lib/rubocop.rb:17:in `<top (required)>'
/usr/local/Homebrew/Library/Homebrew/vendor/portable-ruby/2.3.7/lib/ruby/2.3.0/rubygems/core_ext/kernel_require.rb:127:in `require'
/usr/local/Homebrew/Library/Homebrew/vendor/portable-ruby/2.3.7/lib/ruby/2.3.0/rubygems/core_ext/kernel_require.rb:127:in `rescue in require'
/usr/local/Homebrew/Library/Homebrew/vendor/portable-ruby/2.3.7/lib/ruby/2.3.0/rubygems/core_ext/kernel_require.rb:39:in `require'
/usr/local/Homebrew/Library/Homebrew/style.rb:23:in `check_style_impl'
/usr/local/Homebrew/Library/Homebrew/style.rb:10:in `check_style_and_print'
/usr/local/Homebrew/Library/Homebrew/cmd/style.rb:65:in `style'
/usr/local/Homebrew/Library/Homebrew/brew.rb:102:in `<main>'

brew audit git
Error: incompatible library version - /usr/local/Homebrew/Library/Homebrew/vendor/bundle/ruby/2.3.0/gems/jaro_winkler-1.5.2/lib/jaro_winkler/jaro_winkler_ext.bundle
Please report this bug:
  https://docs.brew.sh/Troubleshooting
/usr/local/Homebrew/Library/Homebrew/vendor/portable-ruby/2.3.7/lib/ruby/2.3.0/rubygems/core_ext/kernel_require.rb:55:in `require'
/usr/local/Homebrew/Library/Homebrew/vendor/portable-ruby/2.3.7/lib/ruby/2.3.0/rubygems/core_ext/kernel_require.rb:55:in `require'
/usr/local/Homebrew/Library/Homebrew/vendor/bundle/ruby/2.3.0/gems/jaro_winkler-1.5.2/lib/jaro_winkler.rb:6:in `<top (required)>'
/usr/local/Homebrew/Library/Homebrew/vendor/portable-ruby/2.3.7/lib/ruby/2.3.0/rubygems/core_ext/kernel_require.rb:55:in `require'
/usr/local/Homebrew/Library/Homebrew/vendor/portable-ruby/2.3.7/lib/ruby/2.3.0/rubygems/core_ext/kernel_require.rb:55:in `require'
/usr/local/Homebrew/Library/Homebrew/vendor/bundle/ruby/2.3.0/gems/rubocop-0.68.0/lib/rubocop/string_util.rb:3:in `<top (required)>'
/usr/local/Homebrew/Library/Homebrew/vendor/bundle/ruby/2.3.0/gems/rubocop-0.68.0/lib/rubocop.rb:17:in `require_relative'
/usr/local/Homebrew/Library/Homebrew/vendor/bundle/ruby/2.3.0/gems/rubocop-0.68.0/lib/rubocop.rb:17:in `<top (required)>'
/usr/local/Homebrew/Library/Homebrew/vendor/portable-ruby/2.3.7/lib/ruby/2.3.0/rubygems/core_ext/kernel_require.rb:127:in `require'
/usr/local/Homebrew/Library/Homebrew/vendor/portable-ruby/2.3.7/lib/ruby/2.3.0/rubygems/core_ext/kernel_require.rb:127:in `rescue in require'
/usr/local/Homebrew/Library/Homebrew/vendor/portable-ruby/2.3.7/lib/ruby/2.3.0/rubygems/core_ext/kernel_require.rb:39:in `require'
/usr/local/Homebrew/Library/Homebrew/style.rb:23:in `check_style_impl'
/usr/local/Homebrew/Library/Homebrew/style.rb:16:in `check_style_json'
/usr/local/Homebrew/Library/Homebrew/dev-cmd/audit.rb:114:in `audit'
/usr/local/Homebrew/Library/Homebrew/brew.rb:102:in `<main>'

brew config
HOMEBREW_VERSION: 2.1.1-95-g2aefcb3
ORIGIN: https://github.com/Homebrew/brew
HEAD: 2aefcb37c412438e7b2fac479b0a8f26a7c86c4c
Last commit: 7 hours ago
Core tap ORIGIN: https://github.com/Homebrew/homebrew-core
Core tap HEAD: 422ef941c0a2b69e9e1ab93612cfbb2ead581bf6
Core tap last commit: 8 hours ago
HOMEBREW_PREFIX: /usr/local
HOMEBREW_DEV_CMD_RUN: 1
Homebrew Ruby: 2.3.7 => /usr/local/Homebrew/Library/Homebrew/vendor/portable-ruby/2.3.7/bin/ruby
Clang: 10.0 build 1000
Git: 2.21.0 => /usr/local/bin/git
Curl: 7.54.0 => /usr/bin/curl
macOS: 10.13.6-x86_64
CLT: <IP_ADDRESS>.1.1539992718
Xcode: 10.1

Duplicate of https://github.com/Homebrew/brew/issues/5561

@MikeMcQuaid Thanks 👏 I thought it might be related.


Feature/generate documentation file

This generates the xml documentation file in release mode.
As warnings are errors it supresses warning CS1591 which warns about missing xml comments for public members
The comments from the gir files are not generated into the wrapper code if in release mode. In this way we can create a public documentation based on our own comments.
In debug mode the gir comments are still generated into the wrapper code.

Yes it is better to be conservative with the comments.
We should probably make the generation of the documentation file opt in, too. This gives us the maximum flexiblity to enable / disable the comments, documentation file in any combination with debug / release mode.
I'm going to try a commandline parser to improve the Build commandline interface as currently everything is a target. There is the very promising looking dragon fruit commandline parser which is part of the dotnet organisation and pretty easy to use in our case: https://github.com/adamralph/bullseye/blob/master/BullseyeSmokeTester.DragonFruit/Program.cs

I updated the code to use the DragonFruit commandline parser and restructured it to better separate the concerns and prepare for unit tests.
@firox263 @na2axl What do you think?


Fixes issue where password are logged with Audit events.

When updating Trusted forest, the bind_pwd gets logged in clear text.
The faulty logic was in build_audit_msg, where config data of array
type wasn't being traversed.  Leveraging the Rails ParameterFilter
to do the magic for us.
https://bugzilla.redhat.com/show_bug.cgi?id=1174458

Please add a spec for this.


[Enhancement] Store the user data to Cloud Firestore

Is it possible to add the data that we get back from  User user = context.getSignedInUser(); to Cloud Firestore. So If we able to get this package to do this automatically without the separate setup from the user, we can make this packing even more LIT 🔥 .
Some basic data can be added to the Firestore such as

Name
Email
FCM token (for in-app messaging )
Profile picture

Is it something in development roadmap?

Not sure I understand fully. But if I do then probably no, the reason being that not everyone who uses this package would want to opt in to all of the Firebase features. I do not want to depend on extra packages, or force certain behaviours if not necessary. But open to suggestions, or maybe there can be an example showing how to do this.

I'd also argue against these features. While it would be really convenient for myself it seems to be out of the scope of this project


Allow SPI access within the same module in checkAccess

SPI decls were not considered as visible from the same module when searched with checkAccess. This affected the search for protocol conformances leading the compiler to complain wrongly about conformances or to synthesize == for an SPI type when there was already an implementation. The later caused an assert in SILGen.
rdar://problem/61043406
rdar://problem/61987739

@swift-ci Please smoke test

Sorry I missed this because I was on vacation. LGTM!


sanitize sensitive variables

You have that variable that contain private data. Also sometime you use the log.exception method.
In this case you can cause situation where private data could be compromated in your logs.
https://github.com/lbryio/lbry-sdk/blob/bce299ccc725bebb353d57efe50228e0f8cc8f1e/lbry/wallet/transaction.py#L880
will be better to sanitize logs and tracebacks by some dictonary with sensitive variables.

Thank you for filing. I don't think there's any cases of this being logged.
If you want to take a shot at making this more full proof, we'd appreciate it!


Matches and Config:

Hi, thanks for this great repo. I was wondring from where i can change max number of features and matches that model will detect and try to match, similarly where is the threshold value for detected feature and match.
As i was testing i refered to "matches" from:
matches, certainty = roma_model.sample(warp, certainty)
As correct matches but if two images are totally different i.e i can manually verify there is not a single match in between them, len(matches) is still 10000.
What i want to acheive is only true matches even though they are less in number.
Any plan to launch onnx/TRT model in future?

I would look at the average certainty of the warp before sampling as indicating the overlap, rather than after sampling.
You can set the number of samples in roma_model.sample(warp, certainty, num=5_000)

Regarding ONNX, no plans from my end currently.


[WIP] Display Miner Vesting Table

Summary of changes
Changes introduced in this pull request:

Retrieve MinerState and display vesting table and display in a user-friendly format.

Reference issue to close (if applicable)

N/A
Other information and links

View vesting table by executing forest state vesting-table <miner address> CLI command with a valid <miner address> (e.g. f01001)

Update branch with changes from main


send_to_port and mirror_packet arguments should be in direction

I noticed this while testing a front-end change for compile time known-constants fix.
These arguments should not be directionless and not required to be a compile time known constants.
Signed-off-by: Andrew Pinski<EMAIL_ADDRESS>

LGTM. Sorry I had not noticed this much earlier!

We all missed it before the release in December. Also the examples only use send_to_port/mirror_packet from an action where the argument was from the table/control plane (and p4c has a bug there which allows it) which allowed this to missed by the examples also. Basically I am saying things slip through everyone's eyes even.