Create a template for new library creation that includes the common components required

Checklist of things required:

[ ] Basic package structure
[ ] Test directory
[ ] Starter version of a Merlin requirements.txt and requirements-dev.txt
[ ] Versioneer
[x] Pre-commit hooks
[x] docstrings preview
[ ] Github Actions for testing
[ ] Jenkins/Blossom testing setup
[ ] Release tag auto-publishing
[x] LICENSE
[x] README
[ ] CONTRIBUTING
[ ] CLA
[ ] Release notes or changelog

Aha! Link: https://nvaiinfa.aha.io/features/MERLIN-811

I think we could use either a Github repo template, or cookiecutter for this. Have used both, don't have a strong preference. Github repo template might be easier for people to use though.

This is my personal Github repo template for Python packages: https://github.com/karlhigley/py-pkg-template
(Not saying we should use this, just sharing as an example of how they look)

@karlhigley , @benfred , can we close this ticket?

AFAIK, the template repo hasn't ever been completed, so if we intend to drop the work then we can close it, but otherwise it should stay open


Version minecraft

Describe the Suggestion
you can put it in 1.16.5 please
Screenshots and Videos
No response
Additional Context
No response

No


Rendering Issues

Hi! Loving the Bodymovin extension but having some real difficulties exporting...
Sometimes they work and other times they render out static, out of position and out of scale! I can't seem to get any consistency out of it...
I've attached my most recent render and the .AEP file.
Please help me crack this!! Got deadlines...
Lovemoney.zip

Hi, there seem to be some files missing, can you share them too?

Thanks for getting back to me!
I've attached the files with all the assets in.
728x90 Leaderboard.zip

728x90 Leaderboard.zip

Same with this, can't figure out the method to the madness!

Please I just can't figure out the method to the madness! What am I doing wrong?
TotalJobs.zip

No matter what variants I try
TotalJobs 2.zip

Hi Hernan,
Are you able to shed any light on the problems?
Thanks

Hi, there seems to be a problem mixing 3d layers and 2d layers, but I'm not sure yet.
I need to investigate some more.


Fix for #72

Probably will work for only 1st page, so maybe you can improve the code

I found better way


[SPARK-20161][CORE] Default log4j properties file should print thread-id in ConversionPattern

What changes were proposed in this pull request?
Change the default log4j properties files so that they display the thread name in the log output.
How was this patch tested?
No testing done yet

I'm not sure how the community feels about adding this to the default log4j files, so posting this as a reference for now. Some more details are in the JIRA, but this can improve debugabbility, especially for Spark-on-YARN.

Can one of the admins verify this patch?

CC maybe @vanzin or @squito who might comment on whether this is disruptive for apps that parse the logs?

The bug is short on details about what exactly this helps with. Do you have a specific situation where you found that knowing the thread helped debug something?
I'm a little wary of adding more clutter to the default configuration. The goal of having something like log4j is that you can customize it if you want, and it's pretty easy to change the log4j configuration when you run Spark. Spark-on-YARN will even ship the driver's log4j.properties to executors so you only need to change it in one place.
So from my end I don't see a benefit in this. So far we've done a pretty good job debugging things with the existing configs, and you can always customize things when needed.

Thanks for taking look everyone. The original motivation for this PR comes HIVE-13517. It was said to be useful for debugging HoS applications that run on YARN. I personally can't point to a specific example where knowing the thread-id has helped debugging Spark applications. The HIVE JIRA mentions that the logs from different threads get mixed, which makes it difficult to debug. The idea is that adding the thread-id to the logs will help other Spark applications too, but if thats not the case then I think we can close this. I've tagged some HoS experts in SPARK-20161 to see if they can provide more details.
As Marcelo said, there is still a workaround on the Hive side for this issue, a custom log4j.properties file can always be provided.

Maybe Hive can do it in Hive.

Sounds like we agree that if this should be done, it should be done in Hive. We have an open JIRA (HIVE-13517) to address this.
If there are no other comments, I'll close this PR and the corresponding JIRA.

Great - please close this. Thanks!


Do not assume that pub is the first command run by "flutter create"

The "flutter create" command on macOS may run other commands such as openssl when it calls _getCodeSigningIdentityDevelopmentTeam

Updated the test - PTAL


When you hit an item on the ignore list, you don't loot items below it until you re-loot the corpse

Occasionally you have to click mobs twice to loot all the non-ignored items on a corpse.
A - Non-ignored Item
B - Ignored Item
C - Non-ignored Item
When this happens, it would loot A, but leave B and C. Clicking the corpse again loots the items.
Probably needs a bit more investigation; not consistently a problem but happens periodically.

Looks good!


[chip-test, entropy_src] chip_sw_entropy_src_csrng

Test point name
chip_sw_entropy_src_csrng
Host side component
Rust?
Opentitantool infrastructure implemented
Yes
Silicon Validation (SiVal)
Yes
Emulation targets

[ ] None
[ ] CW310
[ ] Hyperdebug + CW310

Contact person
Checklist
Please fill out this checklist as items are completed. Link to PRs and issues as appropriate.

[ ] Check if existing test covers most or all of this testpoint (if so, either extend said test to cover all points, or skip the next 3 checkboxes)
[ ] Device-side (C) component developed
[ ] Bazel build rules developed
[ ] Host-side component developed
[ ] Test added to dvsim nightly regression (and passing at time of checking)
[ ] For SiVal test cases, test is running relevant FPGA or silicon regression

Possible duplicate of https://github.com/lowRISC/opentitan/issues/20143

@vogelpi / @h-filali - this test exists already but the test is not linked to Bazel field of testplan. Please link that in and then close this issue.

@vogelpi / @h-filali - this test exists already but the test is not linked to Bazel field of testplan. Please link that in and then close this issue.

Done as part of #21529


fix: Include UMD in NPM package

Context
Since umd/ is ignored, it's not included in the NPM package, so unpkg.com cannot find it.
Objective

Un-ignore umd/ so the instructions in the installation guide are correct

:tada: This PR is included in version 2.0.5 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


kubefed2 unjoin --force

What would you like to be added:
kubefed2 unjoin --force clusterthatnolongerexists
Why is this needed:
Currently a cluster that does not exist cluster config can not be unjoined.

/kind feature

What is your kubefed2 version? Unjoin has a --force option in 0.0.4 (possibly 0.0.3 as well, I haven't looked when it was added...)

Strange, I just checked using master and force was missing

On 12 Feb 2019, at 19.58, Chandler Wilkerson<EMAIL_ADDRESS>wrote:
What is your kubefed2 version? Unjoin has a --force option in 0.0.4 (possibly 0.0.3 as well, I haven't looked when it was added...)
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.

I recently ran into the same problem, I'd updated the federation-v2 repo, but had an old (alpha 0.0.1) version of kubefed2 in my ~/bin
Try kubefed2 version to check.

Hmm, actually my scripts compile it every time - I don't have it in any "bin"
https://github.com/kubernetes-sigs/federation-v2/issues/582
have to recheck

@matti --force is indeed an option to unjoin and has been for some time.  Please close this issue once you've verified this for yourself.

@matti please refer to https://github.com/kubernetes-sigs/federation-v2/issues/188 and https://github.com/kubernetes-sigs/federation-v2/pull/431 for detail.

--force cannot handle if a member cluster context does not exists or the member cluster cannot be accessed.
This is not good to me because we cannot sure if there has any admin operations break a member cluster assumptions in these ways.
@marun @gyliu513

@xunpan I think you're correct that unjoin --force should be able to remove all trace of a member cluster from the host cluster even in the absence of the member cluster context.  The code at present will fail as soon as the cluster config can't be retrieved, which is not ideal.  --force should likely ignore that error.


chore(weave): Calls Page Refactor 2/x: Merge RunsTable into CallsTable

Builds off of https://github.com/wandb/weave/pull/1638
This PR merges the RunsTable into the CallsTable in prep for larger refactor - also, extracts CallsTable into it's own component

Closing in favor of jumping straight to https://github.com/wandb/weave/pull/1640


Reset frame streams on each request (#1028).

Fix going into 1.0.1.
#1028
cc @halter73 @mikeharder @pranavkm @muratg

:shipit:

:rocket:


Implement ZeroCopyInputStream for file section

This implementation is intended to be used for reading protos from
capture file sections.
Test: run CaptureFileTests

LGTM. Nit: Maybe one more test for BackUp, see:
https://storage.googleapis.com/orbitprofiler-build/unit-test-coverage/prod/orbitprofiler/builds/linux/coverage_clang9/presubmit/1221/20210503-014658/coverage_CaptureFile/coverage/mnt/github/orbitprofiler/src/CaptureFile/FileFragmentInputStream.cpp.html

done


chore(store): better code structure

it seems index.js is useless in the store folder. On the one hand, vue-persist plugin has been added in plugin/vuex-persist.js. And the other hand, nuxt can process state.js and mutations.js correctly.

Hey @jameslahm,
Your changes look good to me!
View build log
TravisBuddy Request Identifier: a200e970-8bbd-11ea-83cf-d10851dce6c4

Hey @jameslahm,
Your changes look good to me!
View build log
TravisBuddy Request Identifier: f9026bb0-8c4c-11ea-bf8a-61073f267ac6


external= option doesn't apply on imports with / e.g. external=css-in-js-utils/*

Repro:

https://esm.sh/v99/inline-style-prefixer@5.1.2?dev&external=css-in-js-utils%2F*
Follow import to<EMAIL_ADDRESS>
Expect:
css-in-js module to be imported as an external.
Actual:
// esm-build-0efbdc249b7c8359f5afc7af9c495c986c375902-46c791ab/node_modules/inline-style-prefixer/es/plugins/crossFade.js
import isPrefixedValue from<EMAIL_ADDRESS>var prefixes2 = ["-webkit-", ""];
function crossFade(property, value) {

Ah, the external= doesn't apply when the import is css-in-js-utils/…

thanks for reporting, i will look into it


stdin is a file not a directory

make deploy fails without this change, on Linux anyway.
/cc @n3wscott

/lgtm
the command works on mac...

Does it still work on mac with this change?


Getting actual urls of page components on getInitialProps on client

It seems there is no way to do that, since ctx.pathname and ctx.query are of file based route ones, and location.href is of previous page. Do we need this ?

I think it's great if we can have ctx.as and ctx.href both.

ctx.as sounds good to me. I need as as an entire url string for now. I don't know if we need an object like as.pathname and as.query.

I don't know if we need an object like as.pathname and as.query.
Yeah! We don't need that.


Tickers don't seem to work.

Most things I try seem to work fine.  For example:

^GSPC
DX-Y.NYB
EUR=X
BTC-USD
TSLA

So I am a little puzzled why VUSTX doesn't. Is there something special about this specific ticker or how Yahoo handles it? I am currently using curl  terminal-stocks version.

Hi @andriy-git, looks to be some issue with a null reference. I'll look into it.

Hi @andriy-git, I fixed the issue and created a new release. It looks like not all tickers provide the same data. VUSTX for example does not provide data on "Day Range", which was unaccounted for.

Should be find now.
Cheers,
Christopher

There for it would of not picked up mutual funds before. Mutual funds only post price end of day and do not have day range. Thank you very much for the fix.

Hey @chris-hmmr , it seems like VUSTX is again not showing anything.

Hi @andriy-git, thanks for reaching out. I am aware of the issue. I am currently rewriting the code because Yahoo is changing their encryption algorithm on the data every other week. Looking into a more permanent solution.
I will let you know when I have a fix ready.
Cheers,
Christopher

Hi @andriy-git, I just updated the website for the fix. Should be good now, please have a look for yourself.
curl https://terminal-stocks.dev/VUSTX
Cheers,
Christopher

Was fixed in https://github.com/shweshi/terminal-stocks/commit/5405d9c937490596a84532f1a073fe9f010f83aa


NameError: name 'alchemyjsonschema' is not defined

Traceback (most recent call last):
  File "main.py", line 50, in <module>
    main()
  File "main.py", line 42, in main
    Post, Session))
  File "/Users/zrgorak/.pyenv/versions/3.7.3/lib/python3.7/site-packages/tornado_jsonapi/resource.py", line 112, in __init__
    factory = alchemyjsonschema.SchemaFactory(
NameError: name 'alchemyjsonschema' is not defined

Running the sqla.py demo
If I manually pip install alchemyjsonschema I then get
Traceback (most recent call last):
  File "main.py", line 50, in <module>
    main()
  File "main.py", line 42, in main
    Post, Session))
  File "/Users/zrgorak/.pyenv/versions/3.7.3/lib/python3.7/site-packages/tornado_jsonapi/resource.py", line 113, in __init__
    alchemyjsonschema.AlsoChildrenWalker)
AttributeError: module 'alchemyjsonschema' has no attribute 'AlsoChildrenWalker'

Needs to be renamed to StructuralWalker. See issue #11 for name change reference.

You'll need to install the package with the corresponding extra:
pip install tornado_jsonapi[sqlalchemy]

it will pull the required versions of the packages.


Create experimental test optics_thresholds_test.go

Validate optics high and low thresholds for input power, output power, temperature and bias-current.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 71.374%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
1314

Relevant Lines:
1841

💛  - Coveralls


Check pinned status in hipMemcpyAsync

This should help to take optimal path of sync copies when host buffer is unpinned for H2D and D2H copies.

This makes everything that is unpinned synchronous. This does not meet the contract of the API and leads to surprising behaviour (my supposedly non-blocking API blocking). Even if this is pre-existing behaviour, it is ghastly and should be fixed, as opposed to reinforced. We should not piggyback on unrelated work in order to claim volatile, brittle wins.

Seconded that. It's been a recurring meme in analyzing PyTorch performance that this unexpected behavior is, well, unexpected and wastes cycles of developers. While I appreciate that the improvements originating from #1673 can be trivially used here, hipMemcpyAsync being truly async is the right thing to do.
For the use case that hipMemcpyAsync is followed by a stream synchronize, we now have hipMemcpyWithStream to correctly and efficiently target it.

Closing all existing pull requests that do not target the develop branch. In case this pull request is still valid, please rebase your changes against develop branch and resubmit.


Add list variants

Adds list variants to guards that take parameter lists to avoid extremely large register allocations which can cause large unions & similar to error.
Caveat with literalList due to how tables work, undefined/nil isn't a supported literal value.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

12 of 12 (100.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.02%) to 98.907%

Totals

Change from base Build<PHONE_NUMBER>:
0.02%

Covered Lines:
362

Relevant Lines:
366

💛  - Coveralls


Add difficulty indicator

Basic indicator of the current difficulty score on an item, or "?" if there's none set:

deploy_block :+1: on #12

Connects #7

Rebased onto base pull after merging master and fixing it.

This looks good to me. CR :fire:

Rebased (no conflicts) this to update the commit list and diff.

CR :fire:

dev_block :hand: on merge conflicts

I think I resolved the merge conflict properly, please take a look

We typically don't have scores on pulls... we'd need a tool to copy them over or something...

un_dev_block 💯

If story points are now more of an issue thing than a pull request thing, is it worth adding info about it on the page?

I agree with @copperwall. Aren't story points more useful for milestone planning, not CR/QA?

CR 👙

dev_block :-1: on deciding if we want this.

It looks like it might not be that hard to support grabbing the size score from the issue when the pull first shows up (at least for pulls that only close one issue). But when the size on an issue is updated, it will likely require a manual refresh on each related pull to show up on them, because the issue doesn't necessarily know which pulls depend on it.


Fix issues 20991 and 20930

Problem
https://github.com/project-chip/connectedhomeip/issues/20991 https://github.com/project-chip/connectedhomeip/issues/20930
Change overview

Fix issue where get credential status command  returns INVALID_COMMAND when it's supposed to send a response with null values.

Fix issue where set credential command returns userIndex as null instead of the actual user index.

Testing
EFR32 platform, manual testing. Hoping to get this run against a test harness as soon as possible.

@mykrupp Now the DL_UsersAndCredentials test is failing, presumably because it's wrong....

I tracked down the test that's failing. It's expecting that the reading of a "ProgrammingPin" credential fails.
- label: "Reading PIN credential with index 0 fails"
  command: "GetCredentialStatus"
  arguments:
      values:
          - name: "credential"
            value: { CredentialType: 1, CredentialIndex: 0 }
  response:
      error: INVALID_COMMAND

I don't see this implemented in getCredentialStatusCommandHandler. @Morozov-5F what is going on here?

I guess it shouldn't be expecting INVALID_COMMAND

Right, in the new setup wouldn't this respond with a success, with a "Get Credential Status Response" that has CredentialExists set to false?

Fast tracking, given comments are resolved, and we need to either approve, or deny this tonight.


add pam-bw conveter

Adds "Baden-Württemberg: Park und Mitfahren" converter

Can you explain what "PAM" means, e.g. in a comment on the converter's class?

German-english mixup (a = and). Changed it to German name and added it to the README.


Tags categorization and additions

Brian, we should recognize & differentiate all tags and categorize them. Then we can let user choose which criteria they are looking at.
I have one more suggestion:
in team.html tag section, we can have some selection drop down to select the category, then we can add a drop down list and in this list, we add a search function like this:
http://www.w3schools.com/howto/tryit.asp?filename=tryhow_css_js_dropdown_filter
Then the team leaders can easily add their tags they want.

OK I will try. However, there are not much tags we can have, so maybe I will just do the category part, but not too necessary for the search function part.

I think we don't have enough tags available because we are not only helping online user to form teams for university students or CS major students. So we need to find as more tags as possible


Document Upload is not working

Hi. First of all thanks for the great app.
Everything works except for the document upload.
If I try to upload PDF document I always get error 500 Failed to load resources
I have created all services and configured the env.local, unfortunately I am not getting this part to work.

@error505 could you please check which step the error throws?

Upload
Extract content using document intelligence
Embeddings
Index using Azure Cognitive Search

All these steps are within this file https://github.com/microsoft/azurechatgpt/blob/main/src/features/chat/chat-services/chat-document-service.ts

@leslyarun I added this setting after pulling main and it works now.
https://github.com/microsoft/azurechatgpt/blob/main/docs/6-chat-over-file.md#azure-openai-embeddings
AZURE_OPENAI_API_EMBEDDINGS_DEPLOYMENT_NAME=
I hope this is helpful.

Thanks for your answers,
Now with the AZURE_OPENAI_API_EMBEDDINGS_DEPLOYMENT_NAME= property and deployment of the text-embeding model in the OpenAI studio it works.


Windows alacritty :) 256-colors not working on WSL

Which operating system does the issue occur on? WINDOWS 10 on Windows Subsystem Linux
Using this script: https://gist.github.com/HaleTom/89ffe32783f89f403bba96bd7bcd1263
But basically the problem occurs on any program that wants to use the 256 colors.

(btw, what are the dependencies on Visual Studio to compile? It's complaining about a missing "clang.dll/libclang.dll")
thread 'main' panicked at 'Unable to find libclang: "couldn\'t find any of [\'clang.dll\', \'libclang.dll\'], set the LIBCLANG_PATH environment variable to a path where one of these files can be found (skipped: [])"', libcore\result.rs:1009:5

This is a duplicate of https://github.com/jwilm/alacritty/issues/1662.
The full comments should explain how this will be resolved.


Using the Module's spec.moduleLoader.container.imagePullPolicy.

When we moved to the worker-pod implementation in v2 we started to pull kmod images via HTTP from teh worker-pod directly and we ignored this field.
Now that we moved to pulling using the cluster's container-runtime, the imagePullPolicy can be passed to the init-container definition.

Fixes https://github.com/rh-ecosystem-edge/kernel-module-management/issues/1202
/assign @yevgeny-shnaidman

/lgtm

/retest

/retest

/retest

/retest

/retest

/retest

/retest

/retest

/retest

/lgtm


Release 1.5.2

Test phase

[ ] Setup regression test
[ ] Run manual autobahn testsuite against the server

Pre-Release

[ ] All closed issues have a label and a correct milestone
[ ] All merged pull requests have a label and a correct milestone
[ ] Ensure that the documentation (readme) is up to date

Release

[ ] Push to maven central

After the release

[ ] Update Changelog.md
[ ] Tag everything and create a branch
[ ] Setup the Github release with the pushed jars from maven
[ ] Force an update for the javadoc view
[ ] Update pom.xml version to the next snapshot version
[ ] Close milestone and create a new one

is there a release date ?

Did not yet get around to setup the regression test

Release is halted until severity of #1132 is determined.


Error when loading OpenEphys .continuous files, but only in some recording sessions

Hey!
I’m In the process of analysing data recorded with the Open Ephys system (v0.4.6) using 16 tetrode shuttle drives (64ch). I've used the Spikeinterface toolbox and I’m having problems loading .continuous files in some recordings (while other sessions have no issues loading at all). The error exists within the neo site-package, so I was hoping someone here would have some advice for how I can solve this.
When I execute “recordings.append(si.read_openephys(recording_path[i], stream_name='Signals CH'))” I get the following error:
Traceback (most recent call last):
  File "C:\Users\joach\anaconda3\envs\si_env\lib\site-packages\IPython\core\interactiveshell.py", line 3433, in run_code
    exec(code_obj, self.user_global_ns, self.user_ns)
  File "<ipython-input-3-314ef08b03de>", line 53, in <module>
    recordings.append(si.read_openephys(recording_path[i], stream_name='Signals CH'))
  File "C:\Users\joach\anaconda3\envs\si_env\lib\site-packages\spikeinterface\extractors\neoextractors\openephys.py", line 220, in read_openephys
    recording = OpenEphysLegacyRecordingExtractor(folder_path, **kwargs)
  File "C:\Users\joach\anaconda3\envs\si_env\lib\site-packages\spikeinterface\extractors\neoextractors\openephys.py", line 56, in __init__
    NeoBaseRecordingExtractor.__init__(self, stream_id=stream_id,
  File "C:\Users\joach\anaconda3\envs\si_env\lib\site-packages\spikeinterface\extractors\neoextractors\neobaseextractor.py", line 43, in __init__
    _NeoBaseExtractor.__init__(self, block_index, **neo_kwargs)
  File "C:\Users\joach\anaconda3\envs\si_env\lib\site-packages\spikeinterface\extractors\neoextractors\neobaseextractor.py", line 25, in __init__
    self.neo_reader = get_reader(self.NeoRawIOClass, **neo_kwargs)
  File "C:\Users\joach\anaconda3\envs\si_env\lib\site-packages\spikeinterface\extractors\neoextractors\neobaseextractor.py", line 15, in get_reader
    neo_reader.parse_header()
  File "C:\Users\joach\anaconda3\envs\si_env\lib\site-packages\neo\rawio\baserawio.py", line 179, in parse_header
    self._parse_header()
  File "C:\Users\joach\anaconda3\envs\si_env\lib\site-packages\neo\rawio\openephysrawio.py", line 117, in _parse_header
    assert np.all(diff == RECORD_SIZE), \
AssertionError: Not continuous timestamps for 100_CH1.continuous. Maybe because recording was paused/stopped.

I don’t remember pausing or stopping this recording, so I don’t think this is the reason for the error. I also don’t think the data is corrupted, as I am able to read it in my Matlab pipieline using OpenEphys’ own loading function “[data, timestamps, info] = load_open_ephys_data(inputdata)”.
I get this error with a handful of recording sessions in my dataset, and I really need to get it to work but I have no clue how to fix this error. Any insight as to how it could be fixed would be very much appreciated.
I've uploaded one of my .continuous files that elicits this error, along with the respective settings file here:
https://drive.google.com/drive/folders/1LR4zth7zluBofwv2QDiPo2ArugkyF5x9?usp=sharing
Environment:

OS: Windows 11
Python version 3.9.15
Neo version 0.11.1
NumPy version 1.21.6

Best regards
Jo

Hi @ThePuppetShow
Sorry for the delay in replying to this!
I pushed a fix in this PR (#1213). Note that I couldn't test the full io because all other files are needed.
Can you test the PR and let us know if that works for you?
Do you know how to install from an open PR?
Cheers
Alessio

Dear Alessio, thank you so much for looking into this : )
I have uploaded an entire session to this drive https://drive.google.com/drive/folders/18EPl6bJDsZCbRzFYPrtfrM6xJUCTCrNp?usp=sharing
Will this make it possible for you to recreate my issue?
I'm afraid that I don't understand how to install from an open PR (pull request?). I opened your link, and found the area of the code that shows the error I got, but I'm quite new to github and python so I don't know what to do from there.
Thanks again for helping me with this!
Best
Joachim

Small update on this issue.
I used the official loading function from OpenEphys (Matlab) to load "100_CH1.continuous" from this session, and looked at the amplitude and timestamp values.
The timestamps are not discontinuous

and the LFP value for the whole session (7 minutes) looks normal to me

The only thing I could think of is that the timestamps don't start at 0, but after 1.536 seconds. Could this be why the code thinks that there is a pause in the data?

I can also note, that when I first got this error message, it referenced the "100_ADC1.continuous" file (an unused digital input channel). I then tried to move out all files that were not channel data, and only kept the 64 "100_CH*" files. This gave the same error, but with 100_CH1.continuous at the end of the error message. In other words, it seems that the error occurs with whatever the first .continuous file is in the folder. I can read the ADC files as well with the OpenEphys code, and they start at the same timestamp and have the same number of elements.
Not sure if this helps, but its what I could figure out.
Best
J

Another update to this issue.
I managed to run the script from the pull request you made, and the files are loaded, giving the following Warning message:
C:\Users\joach\anaconda3\envs\si_env\lib\site-packages\neo\rawio\openephysrawio.py:120: UserWarning: Not continuous timestamps for 100_AUX1.continuous. Maybe because recording was paused/stopped.
  warnings.warn(

The code does however manage to process all the 64 .continuous files in what seems to be a correct way.
However, the code breaks down later when I try to run spike sorters (mountainsort4 and spykingcircus) I think because it runs through the online Docker. I run the sorters as such with spikeinterface:
si.run_mountainsort4(recording=recording, output_folder=sortingPath, docker_image=True)
I believe that this executes the neo package from the main branch, rather than the pull request.
In other words. The pull request seems to have fixed my issue, but I get the same error once the code enters the docker image, with an error similar to the original one:
Traceback (most recent call last):
  File "C:\Users\joach\anaconda3\envs\si_env\lib\site-packages\IPython\core\interactiveshell.py", line 3433, in run_code
    exec(code_obj, self.user_global_ns, self.user_ns)
  File "<ipython-input-5-eb711a9fc7b4>", line 1, in <module>
    sorting_SC = si.run_spykingcircus(recording=recording_tt, output_folder=sortingPath, docker_image=True)
  File "C:\Users\joach\anaconda3\envs\si_env\lib\site-packages\spikeinterface\sorters\runsorter.py", line 698, in run_spykingcircus
    return run_sorter('spykingcircus', *args, **kwargs)
  File "C:\Users\joach\anaconda3\envs\si_env\lib\site-packages\spikeinterface\sorters\runsorter.py", line 137, in run_sorter
    return run_sorter_container(
  File "C:\Users\joach\anaconda3\envs\si_env\lib\site-packages\spikeinterface\sorters\runsorter.py", line 578, in run_sorter_container
    raise SpikeSortingError(
spikeinterface.sorters.utils.misc.SpikeSortingError: Spike sorting in docker failed with the following error:
b'Traceback (most recent call last):\n  File "/TempAnalysisFolder/GilesS10Final/2022-11-12_13-31-30_JSG_GilesS10_Stim1/in_container_sorter_script.py", line 9, in <module>\n    recording = load_extractor(\'/TempAnalysisFolder/GilesS10Final/2022-11-12_13-31-30_JSG_GilesS10_Stim1/in_container_recording.json\')\n  File "/usr/local/lib/python3.8/site-packages/spikeinterface/core/base.py", line 906, in load_extractor\n    return BaseExtractor.load(file_or_folder_or_dict, base_folder=base_folder)\n  File "/usr/local/lib/python3.8/site-packages/spikeinterface/core/base.py", line 545, in load\n    extractor = BaseExtractor.from_dict(d, base_folder=base_folder)\n  File "/usr/local/lib/python3.8/site-packages/spikeinterface/core/base.py", line 372, in from_dict\n    extractor = _load_extractor_from_dict(d)\n  File "/usr/local/lib/python3.8/site-packages/spikeinterface/core/base.py", line 832, in _load_extractor_from_dict\n    kwargs[k] = _load_extractor_from_dict(v)\n  File "/usr/local/lib/python3.8/site-packages/spikeinterface/core/base.py", line 832, in _load_extractor_from_dict\n    kwargs[k] = _load_extractor_from_dict(v)\n  File "/usr/local/lib/python3.8/site-packages/spikeinterface/core/base.py", line 832, in _load_extractor_from_dict\n    kwargs[k] = _load_extractor_from_dict(v)\n  File "/usr/local/lib/python3.8/site-packages/spikeinterface/core/base.py", line 849, in _load_extractor_from_dict\n    extractor = cls(**kwargs)\n  File "/usr/local/lib/python3.8/site-packages/spikeinterface/extractors/neoextractors/openephys.py", line 56, in __init__\n    NeoBaseRecordingExtractor.__init__(self, stream_id=stream_id,\n  File "/usr/local/lib/python3.8/site-packages/spikeinterface/extractors/neoextractors/neobaseextractor.py", line 43, in __init__\n    _NeoBaseExtractor.__init__(self, block_index, **neo_kwargs)\n  File "/usr/local/lib/python3.8/site-packages/spikeinterface/extractors/neoextractors/neobaseextractor.py", line 25, in __init__\n    self.neo_reader = get_reader(self.NeoRawIOClass, **neo_kwargs)\n  File "/usr/local/lib/python3.8/site-packages/spikeinterface/extractors/neoextractors/neobaseextractor.py", line 15, in get_reader\n    neo_reader.parse_header()\n  File "/usr/local/lib/python3.8/site-packages/neo/rawio/baserawio.py", line 179, in parse_header\n    self._parse_header()\n  File "/usr/local/lib/python3.8/site-packages/neo/rawio/openephysrawio.py", line 117, in _parse_header\n    assert np.all(diff == RECORD_SIZE), \\\nAssertionError: Not continuous timestamps for 100_AUX1.continuous. Maybe because recording was paused/stopped.\n'

Would it be possible to unify the PR with the main branch to have the docker load the same workaround?
Best
Joachim

@ThePuppetShow  a workaround for running spike sorting in docker is to save the data in binary format (which is much more efficient than the legacy open ephys format):
recording = se.read_openephys("...")

recording_saved = recording.save(fodler="my-binary-folder", n_jobs=8, progress_bar=True)

# continue analysis with recording_saved (which is now a binary recording)

Hey, and thanks for getting back to me : )
Indeed. This would be a workaround, but unfortunately I do not have the opportunity to make new recordings. I was only physically present in the lab to perform these recordings until last year. Following a pipeline where the legacy format was used.

You wouldn't need to make new recordings. You can just load the legacy format with the NEO PR, and save it to binary in SpikeInterface.
recording = se.read_openephys("...")

recording_saved = recording.save(fodler="my-binary-folder", n_jobs=8, progress_bar=True)

# continue analysis with recording_saved (which is now a binary recording)

Hi, I'm having the same problem as this user while trying to read an OE recording on Spike Interface. I want to read a open ephys legacy recording (one continuous file per channel), but the following error occurs: "AssertionError: Not continuous timestamps for 122_CH2.continuous. Maybe because recording was paused/stopped." I am using the "ignore_timestamps_errors" option on the read_openephys function, and I have the latest version of SpikeInterface. I cannot load the recording and save it in binary format either given that it is impossible to read this files. They should be ok, I already did a sorting on this session with an old version of mountainsort and also checked the timestamps using NeuroExplorer and I don't seem to find particular "gaps".


Donate organisation UI and responsive

Fixes:  #2807
Description
Improved UI of page, added submission message and also made the page responsive for all screen size.
Type of PR

[ ] Bug fix
[X]  Feature enhancement
[ ] Documentation update
[ ] Other (specify): _______________

Screenshots / videos (if applicable)
https://github.com/user-attachments/assets/f7242af4-dfc3-4986-89d9-3f2126ee3ce5

Checklist:

[X] I have made this change from my own.
[X]  I have taken help from some online resources.
[X] My code follows the style guidelines of this project.
[X]  I have performed a self-review of my own code.
[X] I have commented my code, particularly in hard-to-understand areas.
[X] My changes generate no new warnings.
[X] I have tested the changes thoroughly before submitting this pull request.
[X] I have provided relevant issue numbers and screenshots after making the changes.

@huamanraj @anuragverma108 Sir,
Please review this PR as soon as possible because GSSoC'24 is closing soon.

Niceee🚀

@huamanraj Sir , Can you please assign it with level 2 for my work.

@huamanraj Sir , Can you please assign it with level 2 for my work.

done ✅


Use md5 for fingerprint hash.

This replaces the Python hash used for the fingerprint with an md5 hash and removes the need to specify PYTHONHASHSEED=0 when calling mypy-gitlab-code-quality.
Note that this change will cause a one break in the continuity of fingerprints for existing users. I don't know how much of a concern this is -- the Python hash was never guaranteed to return any stable value, and indeed varies across architectures (32-bit vs 64-bit) and has varied in the past across Python versions.
P.S. There is also a question of whether just line is a sufficient or the correct input to the fingerprint. Should any other issue information be included?

I believe you should also bump version to 1.1.0 (bump minor since it's more than a bug fix)

Thank you for opening pull request!
Indeed, using the built-in hash function was a bad idea.
Can you also delete setting of environment variable in yaml example in README?
As for including additional information to fingerprint, I have no ideas. If you have, feel free to suggest.

Thank you for fixing linters warnings
I will push changes to PyPi in next 30 minutes

Pleasure, and thank you for reviewing.


Avoid expensive String.format for non-double values.

For group-by responses with > 20k groups it seems upto 25% of the query
latency is just spent formatting doubles while generating response.
This can be avoided in cases where we know that the result is a whole
number (especially when column data type was short/int/long).
A cleaner change would be for servers to send response in appropriate
data type, and broker to upcast to the most appropriat data type. But
that needs quite a bit of changes. This PR is a band-aid until we have a
clean fix.

Codecov Report

Merging #1667 into master will increase coverage by 8.93%.
The diff coverage is 100%.

@@            Coverage Diff            @@
##           master   #1667      +/-   ##
=========================================
+ Coverage   59.06%     68%   +8.93%
=========================================
  Files         829     829
  Lines       40320   40323       +3
  Branches     5303    5304       +1
=========================================
+ Hits        23817   27423    +3606
+ Misses      14749   11052    -3697
- Partials     1754    1848      +94

Impacted Files
Coverage Δ

...aggregation/function/AggregationFunctionUtils.java
91.3% <100%> (+1.3%)
:arrow_up:

...nsport/netty/PooledNettyClientResourceManager.java
87.23% <0%> (-2.13%)
:arrow_down:

...not/transport/scattergather/ScatterGatherImpl.java
67.75% <0%> (-0.47%)
:arrow_down:

.../resources/BasePinotControllerRestletResource.java
87.75% <0%> (ø)
:arrow_up:

...regation/function/customobject/QuantileDigest.java
49.57% <0%> (+0.42%)
:arrow_up:

...linkedin/pinot/common/utils/helix/HelixHelper.java
52% <0%> (+0.66%)
:arrow_up:

...com/linkedin/pinot/core/common/DataBlockCache.java
76.51% <0%> (+0.67%)
:arrow_up:

...t/creator/impl/SegmentIndexCreationDriverImpl.java
86.94% <0%> (+0.68%)
:arrow_up:

.../helix/core/realtime/SegmentCompletionManager.java
70.33% <0%> (+0.71%)
:arrow_up:

...kedin/pinot/broker/broker/BrokerServerBuilder.java
87.73% <0%> (+0.94%)
:arrow_up:

... and 248 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8619d40...02644e7. Read the comment docs.


training on own dataset

How i train this model on own dataset ? is it possible for training ? my dataset is breeds of dogs.

Absolutely you can. These are parameters you should pay attention:

--data_dir: you own training dir with the same structure as LFW
--lfw_pairs and --lfw_dir for testing.

Then you can train this without making any changes to the code.

Thanks
Please put the walk-through for training and evaluation.

Thanks
Please put the step by step for training and evaluation.

@zeynali Yes you can train this for any type data. Just run train_tripletloss.py with required parameters

@huangbiubiu
hi,thanks for your reply
i got a error when i run train_tripletloss.py
InvalidArgumentError (see above for traceback): Input to reshape is a tensor with 640 values, but the requested shape requires a multiple of 384
sometimes 640 values could chenge to 1280 when i change batch_size
Do you have any idea of this?

hi mr. @huangbiubiu , I want train facenet model with Casia Web Face dataset, and then to test it on LFW dataset.Its possible?
I will try to do augmentation techniques on Casia Web dataset, If I will do good augmentation on the data it will give better accuracy?

@erdalalim
Your first question. Yes. Certainly, it's possible.
Your second question, yes. If the augmentation technic is good it will definitely give a good result on the testing set.

@huangbiubiu  thanks for reply.
You Run facenet before?
I wanna run facenet according to :https://github.com/TessFerrandez/research-papers/blob/master/facenet/FaceNet.ipynb   because there is video explanation : https://www.youtube.com/watch?v=w--c0qG9MCc
the link with .ipynb is the same one like the code in this repository?


removing section_type

Removing references to Section_Type in line with issue #143

New issue #192 created for removing comparisons with release 4


Error: UserFacingError

Unexpected error text:
➜ pnpx prisma migrate deploy
Environment variables loaded from .env
Prisma schema loaded from schema.prisma
Datasource "db": PostgreSQL database "***", schema "public" at "***:5432"
Response: Can't reach database server at `***`:`5432`

Please make sure your database server is running at `***`:`5432`.
Error: UserFacingError

Version 2.23.0
via https://github.com/prisma/prisma/issues/8212
Might only have happened in 2.23.0, could already be fixed in 2.26.0

Hmm, I can't reproduce the timeout hence this error :|


Run on OpenShift Online

Updated with a deployable solution. WIP.
In order to run on OpenShift Online, do the following:
Replace acme-example with your project name (namespace):
oc project acme-example
oc policy add-role-to-group edit system:serviceaccounts:acme-example -n acme-example

Then deploy the following template, specify your project name in OPENSHIFT_ACME_SELFSERVICENAMESPACE and OPENSHIFT_ACME_WATCH_NAMESPACE (or add default values for them to the template)
apiVersion: v1
kind: Template
metadata:
  name: acme-controller
parameters:
- description: ACME Endpoint URL
  name: OPENSHIFT_ACME_ACMEURL
  value: https://acme-staging.api.letsencrypt.org/directory
- description: Controller loglevel
  name: OPENSHIFT_ACME_LOGLEVEL
  value: "8"
- description: Name of the service pointing to ACME controller
  name: OPENSHIFT_ACME_SELFSERVICENAME
  value: acme-controller
- description: Namespace of the service pointing to a pod with this program. Defaults to current or default namespace
  name: OPENSHIFT_ACME_SELFSERVICENAMESPACE
- description: Restrics controller to namespace. If not specified controller watches for routes accross namespaces.
  name: OPENSHIFT_ACME_WATCH_NAMESPACE
- description: Docker Image of ACME controller
  name: DOCKER_IMAGE
  value: docker.io/appuio/openshift-acme
- description: Docker Image Tag of ACME controller
  name: DOCKER_IMAGE_TAG
  value: latest
objects:
- apiVersion: v1
  kind: ServiceAccount
  metadata:
    name: acme-controller
- apiVersion: v1
  kind: ImageStream
  metadata:
    name: acme-controller
    labels:
      type: acme-controller
  spec:
    lookupPolicy:
      local: false
    tags:
    - annotations:
        openshift.io/imported-from: ${DOCKER_IMAGE}:${DOCKER_IMAGE_TAG}
      from:
        kind: DockerImage
        name: ${DOCKER_IMAGE}:${DOCKER_IMAGE_TAG}
      importPolicy:
        scheduled: true
      name: latest
      referencePolicy:
        type: Source
- apiVersion: v1
  kind: DeploymentConfig
  metadata:
    labels:
      app: acme-controller
    name: acme-controller
  spec:
    replicas: 1
    selector:
      app: acme-controller
    strategy:
      activeDeadlineSeconds: 21600
      recreateParams:
        timeoutSeconds: 600
      resources: {}
      type: Recreate
    template:
      metadata:
        labels:
          app: acme-controller
      spec:
        containers:
        - env:
          - name: OPENSHIFT_ACME_ACMEURL
            value: ${OPENSHIFT_ACME_ACMEURL}
          - name: OPENSHIFT_ACME_LOGLEVEL
            value: ${OPENSHIFT_ACME_LOGLEVEL}
          - name: OPENSHIFT_ACME_SELFSERVICENAME
            value: ${OPENSHIFT_ACME_SELFSERVICENAME}
          - name: OPENSHIFT_ACME_SELFSERVICENAMESPACE
            value: ${OPENSHIFT_ACME_SELFSERVICENAMESPACE}
          - name: OPENSHIFT_ACME_WATCH_NAMESPACE
            value: ${OPENSHIFT_ACME_WATCH_NAMESPACE}
          image: acme-controller:latest
          imagePullPolicy: IfNotPresent
          name: acme-controller
          ports:
          - containerPort: 80
            protocol: TCP
          resources:
            limits:
              cpu: '500m'
              memory: '512Mi'
            requests:
              cpu: '500m'
              memory: '512Mi'
          livenessProbe:
            tcpSocket:
              port: 5000
            initialDelaySeconds: 10
            timeoutSeconds: 2
            periodSeconds: 10
            successThreshold: 1
            failureThreshold: 3
          readinessProbe:
            tcpSocket:
              port: 5000
            initialDelaySeconds: 10
            timeoutSeconds: 2
            periodSeconds: 10
            successThreshold: 1
            failureThreshold: 3
          terminationMessagePath: /dev/termination-log
          terminationMessagePolicy: File
        dnsPolicy: ClusterFirst
        restartPolicy: Always
        schedulerName: default-scheduler
        securityContext: {}
        terminationGracePeriodSeconds: 30
        serviceAccountName: acme-controller
    test: false
    triggers:
    - type: ImageChange
      imageChangeParams:
        automatic: true
        containerNames:
        - acme-controller
        from:
          kind: ImageStreamTag
          name: acme-controller:latest
    - type: ConfigChange
- apiVersion: v1
  kind: Service
  metadata:
    name: acme-controller
  spec:
    ports:
    - name: http
      port: 80
      protocol: TCP
      targetPort: 5000
    selector:
      app: acme-controller

OPENSHIFT_ACME_WATCHNAMESPACE should be OPENSHIFT_ACME_WATCH_NAMESPACE
see:
https://github.com/tnozicka/openshift-acme/blob/master/pkg/cmd/cmd.go#L34
https://github.com/tnozicka/openshift-acme/blob/master/pkg/cmd/cmd.go#L51

Oh yea, totally missed that :roll_eyes:  Thanks.
But still my serviceaccount user doesn't have the privileges to list the secrets even in just my namespace, as I'm now getting:
ERROR cmd.go:138 Unable to bootstrap certificate database: 'User "system:serviceaccount:acme-example:acme-controller" cannot list secrets in project "acme-example"'

The same is happening when I don't create a new serviceaccount user but use serviceaccount:acme-example:default.
Is there a way to add the permission to list secrets to my serviceaccount users?

It is something like:
oc adm policy add-role-to-user edit -z system:serviceaccount:acme-example:acme-controller

hmm..
Error from server (Forbidden): rolebindings "edit" is forbidden: rolebindings to SystemUser "system:serviceaccount:acme-example:system:serviceaccount:acme-example:acme-controller" are not allowed in project "acme-example"

But oohh, this seemed to have worked :smiley::
oc policy add-role-to-group edit system:serviceaccounts:acme-example -n acme-example

Ok on to the next round of errors: When I now create a route that then tries to obtain a new cert, it errors:
2017-09-05T19:24:16.543254991Z   INFO Obtaining certificate start
2017-09-05T19:24:16.543291920Z   INFO Obtaining certificate
2017-09-05T19:24:16.875302247Z  ERROR route.go:83 route challenge exposer: creating endpoints acme-7qmvo9p4tl/acme-example failed: endpoints "acme-7qmvo9p4tl" is forbidden: endpoint address <IP_ADDRESS> is not allowed
2017-09-05T19:24:28.219099119Z  ERROR client.go:161 Authorization failed: acme: authorization error for freeipa-server-https-acme-example.1d35.starter-us-east-1.openshiftapps.com: 403 urn:acme:error:unauthorized: Invalid response from http://freeipa-server-https-acme-example.1d35.starter-us-east-1.openshiftapps.com/.well-known/acme-challenge/HpDyWwWjuHz6TCChThxpY7cOafvbd9TBJqA28rBqS44: "<html>
  <head>
    <meta name="viewport" content="width=device-width, initial-scale=1">

  <style type="text/css">
  /*!
   * B"
2017-09-05T19:24:28.219172951Z   INFO finished validating domains

@LorbusChris - can you open a PR to this repo to add docs for this?

Sure will do once I get this to work in some useful way :)
Deploying the controller now works, however I can't yet get it to obtain certs, because of some error creating endpoints (see above).

endpoints are Kubernetes objects like services (actually backing them) - you need a next round of  oc adm policy

@tnozicka I tried to use the same acme-controller serviceaccount user, but it didn't work.
Any idea what user needs what permissions for the endpoints?

the serviceaccount which is used for running openshift-acme or the default one needs permissions to modify endpoints
for setting authorization policies please refer to this https://docs.openshift.org/latest/admin_guide/manage_authorization_policy.html

@tnozicka thanks for dealing with this at this hour :smile:
What's strange is oc policy add-role-to-group edit system:serviceaccounts:acme-example -n acme-example should have given all serviceaccount users the ability to create/update endpoints

Apparantely it hasn't. oc policy who-can edit endpoints yields:
Namespace: acme-example
Verb:      edit
Resource:  endpoints

Users:  system:admin

Groups: system:cluster-admins
        system:masters

I got the permissions out of the way by renaming ClusterRole to Role and applying that to my SA:
oc policy add-role-to-user admin -z acme-controller -n xtest
where acme-controller is your SA and xtest is your namespace
unfortunately Online forbids setting endpoint to clusterIP like this:
ERROR route.go:83 route challenge exposer: creating endpoints acme-bhs7hj0bsi/xtest failed: endpoints "acme-bhs7hj0bsi" is forbidden: endpoint address <IP_ADDRESS> is not allowed

this needs fixing the code probably here:
https://github.com/tnozicka/openshift-acme/blob/da3caf917b43582dce8853b6e456c93b3c1026a6/pkg/openshift/controllers/route/route.go#L241-L256
PRs are welcome otherwise its in my queue which is unfortunately quite long at the moment

I made a step forward also, with:
oc policy add-role-to-group admin system:serviceaccounts:acme-example -n acme-example
However now I'm getting
ERROR route.go:192 RouteController: doWatchIteration failed: RouteController ResultChannel closed

@tnozicka How would you solve that? Create a dedicated route for the controller? or a simpler way maybe?

this ever get worked out?

@dustymabe see #34 for the approach that was thought to work out, but unfortunately doesn't. So this is still a valid issue. I'll make sure to add some documentation once we work this out, though.

I think there is a workaround but I haven't tried it yet. Set the main acme-controller service to be a headless service with selectors. Should be fairly easy and work. doc is here https://kubernetes.io/docs/concepts/services-networking/service/#with-selectors
but it's mainly about changing clusterIP to None.

I don't think the workaround resolves the issue, assuming I am doing this right:
[online@ose3x-master ~]$ oc get service acme-controller -o yaml
apiVersion: v1
kind: Service
metadata:
creationTimestamp: 2017-11-14T21:04:10Z
name: acme-controller
namespace: hackathon-demo
resourceVersion: "1680786234"
selfLink: /api/v1/namespaces/hackathon-demo/services/acme-controller
uid: 5c628681-c97f-11e7-88ee-0ab8769191d3
spec:
clusterIP: None
ports:

name: http
port: 80
protocol: TCP
targetPort: 5000
selector:
app: acme-controller
sessionAffinity: None
type: ClusterIP
status:
loadBalancer: {}

[online@ose3x-master ~]$ oc logs acme-controller-1-s1zr1
2017-11-14T21:20:20.280041856Z   INFO Starting controller
2017-11-14T21:20:20.280231938Z   INFO ACME server url is 'https://acme-staging.api.letsencrypt.org/directory'
ERROR: logging before flag.Parse: W1114 21:20:20.280273       1 client_config.go:481] Neither --kubeconfig nor --master was specified.  Using the inClusterConfig.  This might not work.
2017-11-14T21:20:20.290679294Z   INFO AcmeController bootstraping DB
2017-11-14T21:20:20.290719747Z  TRACE AcmeController bootstraping DB finished duration=683.938678ms start=2017-11-14T21:20:20.290720184Z end=2017-11-14T21:20:20.974658862Z
2017-11-14T21:20:20.974714274Z   INFO AcmeController initializing
2017-11-14T21:20:20.974745980Z   INFO AcmeController started
2017-11-14T21:20:20.975199341Z   INFO Http-01: server listening on http://[::]:5000/
2017-11-14T21:20:21.020627270Z   INFO RouteController initializing
2017-11-14T21:20:21.020670333Z   INFO RouteController started
2017-11-14T21:20:21.020719039Z   INFO RouteController: watching namespace 'hackathon-demo'
2017-11-14T21:20:21.086886271Z   INFO Obtaining certificate start
2017-11-14T21:20:21.086927069Z   INFO Obtaining certificate
2017-11-14T21:20:21.294764679Z  ERROR route.go:230 route challenge exposer: creating route acme-rn1deo28k1/hackathon-demo failed: the server rejected our request due to an error in our request; raw: {"kind":"Status","apiVersion":"v1","metadata":{},"status":"Failure","message":"Route "acme-rn1deo28k1" is invalid: spec.host: Forbidden: you do not have permission to set the host field of the route","reason":"Invalid","details":{"name":"acme-rn1deo28k1","kind":"Route","causes":[{"reason":"FieldValueForbidden","message":"Forbidden: you do not have permission to set the host field of the route","field":"spec.host"}]},"code":422}

But assuming you can't set host manually in free tier and you get only the generated host that is a subdomain of what the router has wildcard cert for there is no need to run openshift-acme.

https://docs.openshift.com/online/dev_guide/routes.html#custom-route-and-hosts-and-certificates-restrictions

should be possible now that https://github.com/tnozicka/openshift-acme/pull/48 is merged

This needs https://github.com/openshift/origin/pull/18312 so OpenShift 3.9 that is already deployed on starter cluster so it shouldn't be long to make it to the paid ones where you can have custom domains.


Limit reached

Hi !
I just tried your code but; it seems to be limited to only 600 images per scrapper, is it normal ?
var Scraper = require('images-scraper'), google = new Scraper.Google();
['banana', 'apple', 'cherry'].map(category => {
    google
        .list({
            keyword: category,
            num: 5000,
            detail: true,
            nightmare: {
                show: true
            }
        }).then(function (res) {
        console.log('first 10000 results from google', res.length);
    })
        .catch(function (err) {
            console.log('err', err);
        })
});

Hi @Mwea , it is possible because Google will not always show 1000 results I believe. The scraper will scroll through the page and fetch as much results as possible.

Hi !  @pevers
I just saw that the scrapper stop to get data when it sees the "show more results" link of google,
this could be great if the code was able to "click" on this button and keep downloading.
:+1:

It is doing that. Closing it.


fix(lib): change order when getting definition to works with inherited #61

PR Checklist
Please check if your PR fulfills the following requirements:

[x] The commit message follows our guidelines: https://github.com/ngneat/until-destroy/blob/master/CONTRIBUTING.md#commit
[ ] Tests for the changes have been added (for bug fixes / features)
[ ] Docs have been added / updated (for bug fixes / features)

PR Type
What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: 61
What is the new behavior?
Does this PR introduce a breaking change?
[ ] Yes
[x] No

Other information

It's a must :)

@arturovt resolved this issue in #69


Add hidden --hvm flag

Get hvm encryptor amis from the hvm_amis.json file in the S3
bucket when --hvm is specified.

lgtm, nice

Don't we need to handle the 'update-ami' sub-command also?

@jimvoll I did update that subcommand as well in this review. Are there other places I need to change as well?


Better API errors messages

Updated the error messages for API so it is easier to track down the what is actually failing.

@alastairhm - Thanks a ton for the PR.  I think in my head I was over-engineering how to pass along more detailed errors but this helps greatly!  LGTM!


Raise exceptions rather than collect errors

Trello: https://trello.com/c/fIY7Oy1L
What?
Preparatory step to adding transactions to the controller methods. Transactions will automatically rollback if something inside them throws an exception. At the moment all of the exceptions are being swallowed and instead we're returning a list of errors, and have to manually raise an ActiveRecord::Rollback exception to get the transaction to rollback.
Before adding transactions to all of the remaining coronavirus pages we need to change how we handle exceptions and start surfacing them in the controller.
To that end ContentBuilder and parts of DraftUpdater have been updated to start raising their own exceptions. Before I tackle the send method (and have to update all of the controllers to catch exceptions), I want to make sure that the approach I'm taking to error handling is the correct one.
The change to use transactions in the controllers will happen in a later PR. This one is just focused on getting the exceptions up to the controllers.
⚠ This repo is Continuously Deployed: make sure you follow the guidance ⚠

@kevindew Thanks! That was really helpful 😃

@kevindew thanks for the advice. I've made changes based on your suggestions to what I have so far. The only thing I haven't done is log the error with Sentry where the error originates. I'll do that when I remove the error_handler method from DraftUpdater.

@kevindew thanks for the advice. I've made changes based on your suggestions to what I have so far. The only thing I haven't done is log the error with Sentry where the error originates. I'll do that when I remove the error_handler method from DraftUpdater.

Super thanks, I haven't had time to look yet but your Sentry comment caught my eye so I thought I'd reply before you start the work.
I'd wonder whether we should be raising these errors with Sentry (or at least some of them), since they don't represent a bug in the code and are handled situations. Given we don't have Sentry alerts configured I'm not sure we gain much from them and already rely on people to tell us when they need dev support.

@kevindew Thanks for your review and comments. This PR is ready for a re-review.
A couple of things to mention. The number of commits has increased because, after the addition of controller tests, I felt that the "controller" commits were too large to easily review so they have been split up my "method".
Also, I'm not terribly convinced about how I've done the stubbing in the DraftUpdater tests, so some feedback on that will be greatly appreciated. On the bright-side the structure of the tests is in place now. Thanks for reminding me to add them 🤦.

@kevindew I've made the suggested tweaks and the PR is ready for a re-review. Thanks!


Info on using local camera

I see a checkbooks for 'cameras' under 'Devices & Audio', but there is no mention of requirements to use it or why it might be greyed out.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 0517ea6a-9417-31a8-39a5-f6128387fee5
Version Independent ID: 7636ec70-e1dd-8c6b-516c-8af324d9f645
Content: Get started with the macOS client
Content Source: WindowsServerDocs/remote/remote-desktop-services/clients/remote-desktop-mac.md
Product: windows-server
Technology: remote-desktop-services
GitHub Login: @lizap
Microsoft Alias: elizapo

By the way, resolution is to enable RDP access to camera under settings>privacy and restart the Remote Desktop app.

We hugely appreciate your contribution, feedback, and support to our technical documentation.
We’ve phased out GitHub Issues on this repository as the feedback mechanism for content and have replaced it with a new feedback system. For more information see, Content User Feedback. As part of this rollout, we are migrating your issue where our team will use your comments to improve the documentation experience. Unfortunately, this does mean you won't be able to access this issue after the migration is complete.
All issues will be migrated by Thursday 29th August 2024.
Once again, thank you for your valuable feedback, we hope you’ll continue to contribute using our new feedback system.


[Feature]deploy workflow don't support inputs/outputs

Is your feature request related to a problem? Please describe.
i want use inputs/outputs with deploy workflow, bug when run the application，it run faild. the vela version is 1.6.2，and fluxcd is 2.1.7

Describe the solution you'd like
the deploy workflow support inputs/outputs

ref #4339

It's supported in https://github.com/kubevela/kubevela/pull/5161 and released in v1.7.0. Check the doc https://kubevela.io/docs/end-user/workflow/component-dependency-parameter#multi-cluster-orchestration


Can't add Disks in VIRTUAL MACHINES

I use the VIRUAL MACHINES in rancher v 0.56.0 ,
I have a StoragePool,
but when I add new vm, i can't add any disk, because the Driver show nothings, what should i do?

The stack where convoy-gluster is deployed currently has to be called convoy-gluster, because that becomes the driverName on the pool and the UI only shows drivers it knows are supported.  This will be fixed with a separate field to explicitly identify which pools can be used.

@vincent99 @ibuildthecloud this could be revisited once @ibuildthecloud's volume driver changes are merged.

But beyond my last comment, this is convoy-gluster specific. Can we move out of 1.2.0?

@xrain0610 Please note that we have removed GlusterFS and Convoy Gluster from the catalog as users were expecting a robust tool as an alternative persistent storage for Docker volumes.  However, due to lack of active maintenance, we cannot recommend this solution going forward.
Instead, we recommend and certify Convoy NFS, which is actively maintained by Rancher. As a user, you can get GlusterFS support directly from Red Hat and use it in Rancher using Rancher's NFS plugin.
Due to these changes regarding glusterfs and convoy gluster, we will not be addressing this bug for 1.2.0

We have removed away from convoy gluster and I believe the VM driver has also switched to being a text box. Closing for now.


Fix double-0 hotkey bug

Double-0 hotkey has two bugs. It adds space before action, so space between word and dot looks strange. Second - double-0 action repeats after every single 0 press until another button pressed.
Maybe it's better to add Double-click timer for this function?

It is supposed to insert the selecter character when pressed more than once. I guess it is bad wording and it should be renamed to Character for 0-key Multiple Press instead of ... Double Press.
However, I didn't get the first one. What do you mean "it adds space before action"? What action? And what do you mean by strange space?

While typing in T9 mode double press 0 first adds " " and only then add symbol specified in settings "." or "\n". So text looks like this: "Text ."
Or like this: "Text_
"
(I put underline here instead of " " to show where it is.)

I see. Short answer is: it is working as intended.
Explanation: You see, this setting is for the character when you press 0-key more than once, not once. If you press it once, you are presented with a list of suggestions and it will type the one you pick. Repeated pressing will type the character selected in the settings.
I hope this makes it clear.

OK. Thanks for the explanation.

I'd agree that the expected usage [because old TT9 by Clam did it this way.  Also, standard touch keyboards from Apple, Samsung, and Google do it this way] is that double pressing zero would insert
1.Backspace
2.[Selected character] (i.e. the newline or period]
3. A space
This makes properly ending a sentence or paragraph a much quicker, easier set of keystrokes [keeps your fingers on the lower 12 keys rather than having to reach up to the DPAD] which is why I thought the setting was added to Old Skool TT9.


dev(indexer): verify event origin

Describe the enhancement request
Currently, we do not verify that origin of an event (present in the fromAddress field of events) is equal to the KakarotAddress. We should verify this as it could pose an issue if we ever allow arbitrary calls to Cairo contracts from Kakarot.
Time: 20 min

Can I take this up ?

Hello @greged93 , my name is Dilan. I´ve worked with rust a lot of times so i think I should be able to complete this issue approximately in a week. I would like to investigate more and try to solve it. ¿Could i take this issue? I´m a responsible person.

Hey sorry @DilanHern but I will assign this to Sweta as she commented first


Update Dependence

Hi developers, thank you for your great work.
I noticed that the HTTP version in this package is quite old and may not be compatible with some of the latest packages.
Therefore, I have upgraded the HTTP version from ^0.13.5 to ^1.1.0. After testing it on my own website, it works perfectly.

FYI resolves https://github.com/hrvojecukman/image_downloader_web/issues/8 - close on merge
Thanks for PR!

Thank you for the PR!


pugixml: 1.10 -> 1.11

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/pugixml/versions.
meta.description for pugixml is: "Light-weight, simple and fast XML parser for C++ with XPath support"
meta.homepage for pugixml is: "https://pugixml.org"
meta.changelog for pugixml is: ""
Updates performed

Version update

To inspect upstream changes

Release on GitHub

Compare changes on GitHub

Impact

Checks done (click to expand)

built on NixOS

The tests defined in passthru.tests, if any, passed

0 of 0 passed binary check by having a zero exit code.

0 of 0 passed binary check by having the new version present in output.

found 1.11 with grep in /nix/store/596jqchlhxa7x2q4v72xpk9king710mh-pugixml-1.11

directory tree listing: https://gist.github.com/3098e1e20771a0ec068f886ba4d49527

du listing: https://gist.github.com/5cdd2bfd84d65bce6c488c996be9458a

Rebuild report (if merged into master) (click to expand)

52 total rebuild path(s)

17 package rebuild(s)

16 x86_64-linux rebuild(s)
15 i686-linux rebuild(s)
6 x86_64-darwin rebuild(s)
15 aarch64-linux rebuild(s)

First fifty rebuilds by attrpath
PlistCpp
appleseed
blender
darktable
filezilla
gerbera
gnss-sdr
kodi-wayland
kodiPlainWayland
mudlet
osl
photoflow
poedit
pugixml
python27Packages.appleseed
waylandpp
xib2nib

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/596jqchlhxa7x2q4v72xpk9king710mh-pugixml-1.11 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A pugixml https://github.com/r-ryantm/nixpkgs/archive/3779b44ae2bce638fda63989806b13e5b3d43037.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/596jqchlhxa7x2q4v72xpk9king710mh-pugixml-1.11
ls -la /nix/store/596jqchlhxa7x2q4v72xpk9king710mh-pugixml-1.11/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review 1

2 packages failed to build:

appleseed (python27Packages.appleseed)
gerbera

12 packages built:

PlistCpp
darktable
filezilla
kodi-wayland
kodiPlainWayland
mudlet
osl
photoflow
poedit
pugixml
waylandpp
xib2nib

Maintainer pings
cc @pSub for testing.

Result of nixpkgs-review pr 105344 run on x86_64-darwin 1

1 package marked as broken and skipped:

poedit

5 packages built:

PlistCpp
blender
darktable
pugixml
xib2nib


Make it possible to build HopsanGUI even when QtWebKit is not available

In Qt 5.6 QtWebKit has been removed and QWebEngine wont build with MinGW, so there is no longer a webview.
It might be possible to build QtWebKit manually but for now lets fall back to opening html in external browser.

this is a test comment


Feat/optimize image ratio

What's the purpose of this pull request?
We had some problems in mobile banners/carousel resolutions when optimizing them.
How it works?
This PR adds an extra parameter in optimize function, so we can increase the width/height ratio.
How to test it?
Carrefour PR

TIp: @Gmantiqueira , you don't need to release alphas anymore. Now we have codesandbox exactly for this 👍

@Gmantiqueira can u create a test for that?

Done.

Just destroyed this branch with a very bad rebase. Gonna continue on this one


TOC of index is wanted

https://qiita.com/technote-space/items/59520dfa47504c558805

TOC is not needed anymore


Stream running build's log into VS Code

Basically mirror the website's behavior that shows a "real-time" view of the running build's log output.
After initial investigation, it appears that is not possible with the current set of VSTS's public APIs. Might be worth filing a feature request with them?

I will look into a way of doing this - if all things fail, a solution could be to continuously get the logs until the build is finished

I just pushed 0.5.0 which supports this. I will work on optimizing it a bit, but the feature itself works.

Woah, nice! Thanks you ☺


add options to use custom struct tag name instead of structs:"..."

I would like to use json:"..." instead of structs:"..", for now I am forced to use both when a struct is used by encoding/json and fatih/structs with converting structs to map[string]interface{}.
type ErrorResponse struct {
	Error string `json:"error" structs:"error"`
}

Specifically, I need this in the structs.Map() function, but I guess it would be good if this would be added as to other places in the code as well.

Actually you can do it already http://godoc.org/github.com/fatih/structs#Struct :) By default it's "structs" but you can change it to "json".

Change the TagnName field.

Or change the global variable name "DefaultTagName"

@fatih hey cool! thanks. you're quick :)

You're welcome :)


[Bug] [Klaviyo DOC] Fix 404 link

At present, the reference link provided by Klaviyo connector is 404 inaccessible and needs to be modified, otherwise it will hinder the operation of ST project CI

Please update to right related link.

Please update to right related link.

ok,done
please review again


key vault draft

add key vault dependency
create a credential client class to init key vault secret client
add redis sample in credential util which can replace current _construct_redis_client()
will add more functions and tests if above change is acceptable.

Please follow https://github.com/linkedin/feathr/blob/main/docs/dev_guide/pull_request_guideline.md.

What changes to make and why you are making these changes:

Add akv_client to support reading secrets from Azure Key Vault.
Key vault logic will be triggered only when environment variable is not set and KEY_VAULT__NAME is given. (envutil)
Update ARM Template to store REDIS_PASSWORD rather than CONN for better akv usage

How are you going to achieve your goal Describe what testings you have done, for example, performance testing etc.

So far it will perform exactly the same as it was unless and secret variables are removed and "KEY_VAULT__NAME" is set.

@Yuqing-cat let's talk a bit about the scope of this work (probably need a bit bigger scope to cover the spark runtime as well)

Is KV only storing Redis  Credetials for Online store?  Can we store other credentials too in KV that will unify the implementation when other environment variables are not set.


Compare only part of the image

Solves #100
This PR makes it possible to define a bounding box that the comparison will be limited to;
It also updates README and demo page with info about new feature.

Thank you!  I made some small changes


Add maxSelectedItems and reverseActions support for MultiSelectDialogField

Overview:
Users may want to limit the selected items for some fields without using other package.
By default maxSelectedItems is null which means there is not selection limit.
This only add support for MultiSelectDialogField because is the field I use for my personal project.
Also some users may want to change the OK and CANCEL button order for the multi select dialog, so I introduced reverseActions which is false by default.
Example:
MultiSelectDialogField<T>(
    title: Text(title),
    buttonText: Text(
      buttonText,
      style: TextStyle(
        color: Colors.black54,
      ),
    ),
    initialValue: initialValue,
    items: items,
    listType: MultiSelectListType.CHIP,
    onConfirm: onConfirm,
    selectedItemsTextStyle: const TextStyle(
      color: kWhiteColor,
    ),
    selectedColor: kHempColor,
    buttonIcon: const Icon(
      Icons.edit,
      color: Colors.black54,
    ),
    maxSelectedItems: 1,
    reverseActions: true,
  )

How to test before is merge
Add to your pubspec.yaml
dependencies:
  flutter:
    sdk: flutter

  multi_select_flutter:
      git:
        url: https://github.com/ingmferrer/multi_select_flutter.git
        ref: master

👍
Would be an expected feature !
Thanks.


TypeScript and JavaScript Features Dies Repeatedly

Issue Type: Bug
Be connected to an ubuntu server via SSH, do stuff, watch error message occur.
VS Code version: Code 1.59.0 (379476f0e13988d90fab105c5c19e7abc8b1dea8, 2021-08-04T23:14:40.191Z)
OS version: Darwin x64 20.6.0
Restricted Mode: No
Remote OS version: Linux x64 5.4.0-80-generic

System Info

Item
Value

CPUs
Intel(R) Core(TM) i5-1038NG7 CPU @ 2.00GHz (8 x 2000)

GPU Status
2d_canvas: enabledgpu_compositing: enabledmetal: disabled_offmultiple_raster_threads: enabled_onoop_rasterization: enabledopengl: enabled_onrasterization: enabledskia_renderer: disabled_off_okvideo_decode: enabledwebgl: enabledwebgl2: enabled

Load (avg)
2, 2, 2

Memory (System)
16.00GB (3.55GB free)

Process Argv
--crash-reporter-id 170d6994-19c0-40f9-a648-d999c070e3fb

Screen Reader
no

VM
0%

Item
Value

Remote
SSH: [any-ssh-server-will-do.com]

OS
Linux x64 5.4.0-80-generic

CPUs
DO-Regular (1 x 2294)

Memory (System)
1.94GB (0.48GB free)

VM
0%

Extensions (2)

Extension
Author (truncated)
Version

remote-ssh
ms-
0.65.7

remote-ssh-edit
ms-
0.65.7

Does this reproduce in the latest VS Code insiders build with all extensions disabled?

Downloaded insiders - crashed but seemingly for a different reason, and only after I walked away from it for about 2.5 hours and returned. Restarted my MBP, opened up VSC insiders again, and left it running. Same result.
This is wholly unrelated to the other issue though, so I'm not sure what to do at this point.
Also, when I came back to it, I got an Apple bug dump report - not one from VSC. I'm assuming that's because it crashed hard? No idea.
I'm working on your suggestion to turn off all extensions. I don't have many as it stands - and only a few of them were enabled for the project, with the SSH stuff being the largest of them, I believe.

If the server still seems to be crashing, you can also try collecting the TS Server log:

Set "typescript.tsserver.log": "verbose",
Restart VS Code and reproduce the problem
In VS Code, run the TypeScript: Open TS Server log command
This should open a large log file called tsserver.log

Look through that log file for errors or stack traces. If you can share the log, I can also take a look to see if anything stands out

⚠Warning: The TypeScript log may include information from your workspace, including file paths and source code. If you have any concerns about posting this publicly on Github, just let me know and we can arrange something else. On our side, we only use these logs to investigate issues like this


Test arm64 ISO on rpi

Now that we have merged #676, we need to test if the iso above is working on native hardware.
Action Items

[ ]  test installation
[ ] test upgrade
[ ] test reset
[ ] test deploy raw disk image
[ ] File new issues if new bugs are found and are not easily fixable

Blocked by #930

We don't have ISO but a boot image.
Closing.


[auth] Allow roles to be configured

A new shared input should be introduced to allow users to specify the roles (comma separated) to be used for certificates generated.
At the moment, the behaviour is to use all roles associated with the bot, which may not be conducive to following the principle of least privilege.

This should apply to the entire auth- family of actions


Example project?

Hey, could you provide a description?

Is possible to have an example project?

This project itself is a simple example project on how to use UVC camera + stream, do you need any extra functionality?


chore(deps): update go to 1.22.0

As requested bumped go 1.22.0.
Notes:

I had to use 1.22.0, because of: https://github.com/golang/go/issues/65568, also see: https://go.dev/doc/toolchain#version
scripts/docker_install.sh changed tohttps://dl.google.com/go/go1.22.4.linux-amd64.tar.gz (the latest from https://go.dev/dl/)
AppVeyor Go 1.22 uses a differen PATH Go 1.22.1 x64 (C:\go - default in PATH), see: https://www.appveyor.com/docs/windows-images-software/

TIL that Go simply downloads a new toolchain (1.22) if not available. I don't really like that, the Go dep, like the vendored deps, should be fixed and local. Seem like GOTOOLCHAIN=local would avoid this. We should add this to the CI and to the make ... targets for all platforms. Do you want to try or should I open a separate PR for that?
The CI here will then fail, but I'll upload a new image with the updated Go version as discussed.

Yeah, I'll integrate it, you can then review it.

Thanks.

I had to use 1.22.0, [...]

This will also not be needed then anymore. The AppVeyor comment would be nice to have in the commit message body.

OK, all error msg are now go: ..\..\..\go.mod requires go >= 1.22 (running go 1.21.8; GOTOOLCHAIN=local)

Could You upload a shiftcrypto/bitbox-wallet-app:24 Docker Image with go 1.22.x. I'll try so solve the issue.
I tried to build it locally and had a success, but want to check if it also works within the pipeline. Thanks in advance.

Could You provide a shiftcrypto/bitbox-wallet-app:24 Docker Image with go 1.22.5. I'll take a deeper look into this issue. Thanks in advance.

I wouldn't push an image until we know if/how it will work, as we may need to push other image updates until then. You can simply build it locally though using make dockerinit, would that work?

I've solved https://github.com/golang/go/issues/67927
Now I'm having the issue that go 1.22 is missing:
cd ../../backend/mobileserver && make build-android
make[3]: Entering directory '/opt/go/src/github.com/BitBoxSwiss/bitbox-wallet-app/backend/mobileserver'
ANDROID_HOME=/opt/android-sdk gomobile bind -x -a -glflags="-mod=mod" -ldflags="-s -w" -target android .
gomobile: 'go version' failed: exit status 1, go: downloading go1.22 (linux/amd64)
go: download go1.22: open<EMAIL_ADDRESS>permission denied

make[3]: *** [Makefile:7: build-android] Error 1
make[3]: Leaving directory '/opt/go/src/github.com/BitBoxSwiss/bitbox-wallet-app/backend/mobileserver'
make[2]: *** [Makefile:14: prepare-android] Error 2
make[2]: Leaving directory '/opt/go/src/github.com/BitBoxSwiss/bitbox-wallet-app/frontends/android'
make[1]: *** [Makefile:4: apk-debug] Error 2
make[1]: Leaving directory '/opt/go/src/github.com/BitBoxSwiss/bitbox-wallet-app/frontends/android'
make: *** [Makefile:75: android] Error 2
dockeruser@82594f0709f3:/opt/go/src/github.com/BitBoxSwiss/bitbox-wallet-app$ go version
go: downloading go1.22 (linux/amd64)
go: download go1.22: open<EMAIL_ADDRESS>permission denied

This is amazing work, thanks @baizon.
What exactly didn't work? gomobile is also installed here:
https://github.com/BitBoxSwiss/bitbox-wallet-app/blob/c221fca603b8a45012ca7a8279efbc197621c4a3/Makefile#L28-L32
So maybe you'd need to change that path instead?
You may also need to do this to vendor the related packages? https://github.com/golang/go/issues/67927#issuecomment-2188356041

Sorry, wasn't very specific. My steps:

Set replace within the go.mod, like this:
replace golang.org/x/mobile => github.com/baizon/mobile v0.0.0-20240721071641-1d3b1e5c533f
Changed within the Makefile you mentioned
go install github.com/baizon/mobile/cmd/gomobile@latest
Run make dockerinit, the result is:

go install github.com/baizon/mobile/cmd/gomobile@latest
go: downloading github.com/baizon/mobile v0.0.0-20240721071641-1d3b1e5c533f
go: github.com/baizon/mobile/cmd/gomobile@latest: version constraints conflict:
<EMAIL_ADDRESS>parsing go.mod:
        module declares its path as: golang.org/x/mobile
                but was required as: github.com/baizon/mobile
make: Leaving directory '/tmp'
make: *** [Makefile:28: envinit] Error 1

@baizon try also replacing the module name in your fork at https://github.com/baizon/mobile/blob/1d3b1e5c533f3e2b92f8cdde1921d96b618eb361/go.mod#L1

That was a nice challenge. Thanks for the support.
BUILD SUCCESSFUL in 3s
75 actionable tasks: 10 executed, 65 up-to-date
make[1]: Leaving directory '/opt/go/src/github.com/BitBoxSwiss/bitbox-wallet-app/frontends/android'

Now the 23 (go1.22) docker image?

export GOMODCACHE_ROOT := /tmp/gomodcache/pkg/mod is set, because gomobile runs a go mod tidy and tries to create cache within /opt/go/pkg/mod/cache/download/. This fails, because there is no write access.
go: writing go.mod cache: mkdir /opt/go/pkg/mod/cache/download/github.com/!bit!box!swiss: permission denied
go: writing go.mod cache: mkdir /opt/go/pkg/mod/cache/download/github.com/!azure: permission denied
go: writing go.mod cache: mkdir /opt/go/pkg/mod/cache/download/github.com/!bit!box!swiss: permission denied
...

I choose the /tmp folder, but it can be changed, or a different solution can be implemented.

@baizon I pushed the :24 image.
I noticed that while the android build works, it does not seem to be using the vendor folder - I can change deps in it or remove the whole folder, and the android build still works.
Granted, before we also didn't (couldn't) use the vendor lib, but since you went into the gomobile internals, maybe you have a clue why or how to fix it? Ideally it behaves like the normal build with -mod=vendor.

Image :24 is reporting an error:
+ docker pull ghcr.io/bitboxswiss/bitbox-wallet-app-ci:24
Error response from daemon: manifest unknown

Tomorrow I'll take a look at the go mod behavior with mobile and report back.

@baizon

Image :24 is reporting an error:

I had a typo in the image name, should be fixed now.

The reason why go list fails:

Sorry I am confused, what does this relate to? The original issue to build the Android app with a vendor folder present works with -mod=mod with your patch, without errors, but my question was about why the Android Go build does not use the vendor folder at all now. It's possible however I am misreading your message :innocent:

So, while building the android app gomobile is running go list (see: https://github.com/golang/mobile/blob/master/cmd/gomobile/bind.go#L229) and go mod tidy. While running go list the issue the vendor issue occurs. See: https://github.com/golang/go/blob/master/src/cmd/go/internal/list/list.go#L545
Indeed, I'll add the lint exceptions.

So, while building the android app gomobile is running go list (see: https://github.com/golang/mobile/blob/master/cmd/gomobile/bind.go#L229) and go mod tidy. While running go list the issue the vendor issue occurs. See: https://github.com/golang/go/blob/master/src/cmd/go/internal/list/list.go#L545

This is the issue you fixed in your fork of gomobile, right?
But even with your fork, the vendor module does not seem to be used when building the android app. I checked by modifying a dep in the vendor module (added some syntax error) but the build finished fine anyway, suggesting that the vendor folder was ignored when building the android app. Any idea how one would fix that? As I mentioned before, it is not a high prio as even before 1.22, the vendor module was not used for the android app, but it would be nice to solve this too if you know how.
When building the Windows/macOS/linux apps, the vendor folder is used as expected.

Done.
To fix the mobile vendor issue needs a bigger fix. Rewriting the go list code. When I have more time I will look into it.

@baizon I made a PR to your branch to fix the appveyor CI at https://github.com/baizon/bitbox-wallet-app/pull/3 - please apply the commit :smile:

Sorry, much to do at work at the moment. Thank You for the fix. I did merge your PR and did a rebase.


Unknown provider: $cookieStoreProvider <- $cookieStore <- sessionService <- authInterceptor <- $http <- $templateRequest <- $route

HI ,
Just now I have started working on it.I have installed all the modules which you have mentioned in Redme Docs.But Started of the project It show this run Time Error at my browser.

Hi there, can you send an email to us with more info or a URL we can test? I don't think that has anything to do with Prerender.io<EMAIL_ADDRESS>


Implement gulp for assets

That could improve everything. If you want can i make a PR

This has been discussed during the early days of this project. I chose connect-assets over Grunt or Gulp in favor of simplicity.


feat: support basic typescript transformations via esbuild

Adds support for relative importing of dependencies require('./nearby-file.js')
Adds support for typescript (transpilation, without strict type checking)

Make sure to update the readme with the new functionality as well


Updated dockerfile, changelog and added template

Changes ADD to COPY as mentioned in both the docker best practices page and codacy.
Also added PR template at the same time as it is a small change.

Codecov Report

Merging #62 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #62   +/-   ##
=======================================
  Coverage   91.15%   91.15%
=======================================
  Files           5        5
  Lines         226      226
=======================================
  Hits          206      206
  Misses         20       20

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bb61446...e90e643. Read the comment docs.


fix typo in cshtml bootstrap razor

@mrbullwinkle looks like a small character change.  Please review and confirm this is ready to merge.

#sign-off


NSLocationAlwaysUsageDescription - Deprecated

https://capacitorjs.com/docs/apis/geolocation
The URL at which the content is missing or inaccurate
What is missing or inaccurate about the content on this page?
It is indicating to add NSLocationAlwaysUsageDescription (Privacy - Location Always Usage Description) to Info.plist but NSLocationAlwaysUsageDescription is deprecated since ios 11 as stated here https://developer.apple.com/documentation/bundleresources/information_property_list/nslocationalwaysusagedescription and at the same Apple page it is suggesting to use NSLocationAlwaysAndWhenInUseUsageDescription. The same suggestion is made at the related cordova location plugin NSLocationAlwaysUsageDescription describes the reason that the app is requesting access to the user's location at all times. Use this key if your app accesses location information in the background and you deploy to a target earlier than iOS 11. For iOS 11 and later, add both NSLocationAlwaysUsageDescription and NSLocationAlwaysAndWhenInUseUsageDescription to your app’s Info.plist file with the same message..
NSLocationAlwaysUsageDescription is deprecated since ios 11 and Capacitor minimum required iOS version is 13.
Am I missing something?
Thanks.

...by the way the same applies to the documentation for @capacitor/google-maps plugin at the following link https://capacitorjs.com/docs/apis/google-maps#ios. Here the relevant excerpt: NSLocationAlwaysUsageDescription (Privacy - Location Always Usage Description).

Apis docs come directly from the plugins README, it's been fixed there already, but for Capacitor 6 docs only.

Thanks @jcesarmobile.
Is it also safe to only have NSLocationWhenInUseUsageDescription in Info.plist for @capacitor/geolocation and @capacitor/google-maps in the case of Capacitor 5? I mean, can we omit NSLocationAlwaysUsageDescription and NSLocationAlwaysAndWhenInUseUsageDescription and only have NSLocationWhenInUseUsageDescription in Info.plist for these plugins?
Thanks!

Yes, it's also possible, we marked it as "breaking" just to document it in the upgrade guide so all users who update from Capacitor 5 to Capacitor 6 can know about it, but you can do it now.


vxe Table Filter Fields

（必填）这个需求解决了什么问题：
The possibility to change the default filter fields in a header of a filter, if you have different fields (not value/label) coming from a database. In my case id/value
截图或在线链接：
https://codesandbox.io/s/vxe-table-wentiyanshi-forked-7tn5r?file=/src/views/Demo1.vue
建议的 API 是什么样的：
The possibility to choose a id field and a label field value
是否已有其他不错的替代方案：
Can't find in the docs.

Currently, other fields names are not supported. Only label/value is supported


Compatibility with Typhoon

I'd be great if there's a documented example that shows how RBStoryboardLink works with Typhoon: i.e. show that the initialViewController becomes the destinationController, whose properties have a chance of being injected with dependencies.
Has any one tried using this?

To keep RBStoryboardLink simple, I'll leave the Typhoon dependency in @papcio28's fork.


Cache fixpoint queries

This PR caches the safe fixpoint queries for each DefId  in log/cache.json and then on subsequent runs, skips queries that are already in the "safe" cache, makes it possible to work with flux-wave rather interactively.

One question is whether we want flags for this or caching to be the default?
At any rate, one must be careful to do rm flux-tests/**/cache.json before running cargo test!

yikes occurs to me that we should compute the hash AFTER "closing" with constants...

One question is whether we want flags for this or caching to be the default?
At any rate, one must be careful to do rm flux-tests/**/cache.json before running cargo test!

We should probably add a flag to turn caching on an off and disabled it for testing. What prusti does is define one flag to set the path for the cache directory and if it is empty then  it disables the cache.

Ok I like that I'll add a LR_CACHE=file flag and only do the caching if that is set. (Maybe that's related to the failed test? do you know if those are persisted across CI?)

Oh, I know what it is! We are not adding the qualifiers to the cache, so the cached query for the pos case which contains the local qualifier wins over the neg one.

Maybe we should hash the flux-fixpoint::Task

@nilehmann I made all the edits except the bincode (which threw some scary SIGABORT run-time error!)

LR_CACHE=file switches it on

Might I suggest that instead we have two env vars

LR_CACHE=1 enables caching
LR_CACHE_FILE=/some/file is the absolute path to a file to cache to (defaults to ~/.flux/cache)

This suggestion doesn't need to block this PR though.

Hmm I like this - @nico any thoughts?
On Wed, Jan 11, 2023 at 2:22 PM cole @.***> wrote:

Might I suggest that instead we have two env vars

LR_CACHE=1 enables caching
LR_CACHE_FILE=/some/file is the absolute path to a file to cache to
(defaults to ~/.flux/cache.json)

This suggestion doesn't need to block this PR though.
—
Reply to this email directly, view it on GitHub
https://urldefense.com/v3/__https://github.com/liquid-rust/flux/pull/316*issuecomment-1379561410__;Iw!!Mih3wA!FUhVKwC2yqt6v-qlWNGbHBJg2cIDyMA23TT1dT-gkIRdsadOD1xX5Abu2owbMT2XSBs_7ltfKpLv6sUwFUQULigm$,
or unsubscribe
https://urldefense.com/v3/__https://github.com/notifications/unsubscribe-auth/AAMS4OCT2TUA33FMRQHTR5LWR4XCRANCNFSM6AAAAAATXRGEHM__;!!Mih3wA!FUhVKwC2yqt6v-qlWNGbHBJg2cIDyMA23TT1dT-gkIRdsadOD1xX5Abu2owbMT2XSBs_7ltfKpLv6sUwFe7XLfiU$
.
You are receiving this because you were mentioned.Message ID:
@.***>

I implemented @cole-k 's suggestion...

I would either have the two env variables as @cole-k suggests or make LR_CACHE mean the path to the file and not just the name (with empty meaning disabled). Both options sound good. But the default CANNOT be ~/.flux/cache.json as the cache should be per project.
Also @ranjitjhala you haven't considered these changes https://github.com/liquid-rust/flux/pull/316/files#r1067353829.

I would either have the two env variables as @cole-k suggests or make LR_CACHE mean the path to the file and not just the name (with empty meaning disabled). Both options sound good. But the default CANNOT be ~/.flux/cache.json as the cache should be per project.

Whoops, yeah I meant ./.flux/cache.json!

Odd I totally didn’t even see those changes - some UI glitch . Let me take
a look…
On Wed, Jan 11, 2023 at 2:57 PM Nico Lehmann @.***>
wrote:

I would either have the two env variables as @cole-k
https://urldefense.com/v3/__https://github.com/cole-k__;!!Mih3wA!H6fCTo1ZfRUdrpZuC4VqOdfd-Wfp1o576zDCkXN070SvuCqji9t8W9HtAEboye9Mw6eKybKwsq_a28lng3aPxubj$
suggests or make LR_CACHE mean the path to the file and not just the name
(with empty meaning disabled). Both options sound good. But the default
CANNOT be ~/.flux/cache.json as the cache should be per project.
Also @ranjitjhala
https://urldefense.com/v3/__https://github.com/ranjitjhala__;!!Mih3wA!H6fCTo1ZfRUdrpZuC4VqOdfd-Wfp1o576zDCkXN070SvuCqji9t8W9HtAEboye9Mw6eKybKwsq_a28lng9nCwASg$
you haven't considered these changes
https://github.com/liquid-rust/flux/pull/316/files#r1067353829
https://urldefense.com/v3/__https://github.com/liquid-rust/flux/pull/316/files*r1067353829__;Iw!!Mih3wA!H6fCTo1ZfRUdrpZuC4VqOdfd-Wfp1o576zDCkXN070SvuCqji9t8W9HtAEboye9Mw6eKybKwsq_a28lngwCRPvc2$
.
—
Reply to this email directly, view it on GitHub
https://urldefense.com/v3/__https://github.com/liquid-rust/flux/pull/316*issuecomment-1379588156__;Iw!!Mih3wA!H6fCTo1ZfRUdrpZuC4VqOdfd-Wfp1o576zDCkXN070SvuCqji9t8W9HtAEboye9Mw6eKybKwsq_a28lng5y_BwtL$,
or unsubscribe
https://urldefense.com/v3/__https://github.com/notifications/unsubscribe-auth/AAMS4OBCVBDGMZ32IXIBBB3WR43GRANCNFSM6AAAAAATXRGEHM__;!!Mih3wA!H6fCTo1ZfRUdrpZuC4VqOdfd-Wfp1o576zDCkXN070SvuCqji9t8W9HtAEboye9Mw6eKybKwsq_a28lng8JTmx9q$
.
You are receiving this because you were mentioned.Message ID:
@.***>

Just updated the hash for constraints @nilehmann
On Wed, Jan 11, 2023 at 3:23 PM Ranjit Jhala @.***> wrote:

Odd I totally didn’t even see those changes - some UI glitch . Let me take
a look…
On Wed, Jan 11, 2023 at 2:57 PM Nico Lehmann @.***>
wrote:

I would either have the two env variables as @cole-k
https://urldefense.com/v3/__https://github.com/cole-k__;!!Mih3wA!H6fCTo1ZfRUdrpZuC4VqOdfd-Wfp1o576zDCkXN070SvuCqji9t8W9HtAEboye9Mw6eKybKwsq_a28lng3aPxubj$
suggests or make LR_CACHE mean the path to the file and not just the
name (with empty meaning disabled). Both options sound good. But the
default CANNOT be ~/.flux/cache.json as the cache should be per project
.
Also @ranjitjhala
https://urldefense.com/v3/__https://github.com/ranjitjhala__;!!Mih3wA!H6fCTo1ZfRUdrpZuC4VqOdfd-Wfp1o576zDCkXN070SvuCqji9t8W9HtAEboye9Mw6eKybKwsq_a28lng9nCwASg$
you haven't considered these changes
https://github.com/liquid-rust/flux/pull/316/files#r1067353829
https://urldefense.com/v3/__https://github.com/liquid-rust/flux/pull/316/files*r1067353829__;Iw!!Mih3wA!H6fCTo1ZfRUdrpZuC4VqOdfd-Wfp1o576zDCkXN070SvuCqji9t8W9HtAEboye9Mw6eKybKwsq_a28lngwCRPvc2$
.
—
Reply to this email directly, view it on GitHub
https://urldefense.com/v3/__https://github.com/liquid-rust/flux/pull/316*issuecomment-1379588156__;Iw!!Mih3wA!H6fCTo1ZfRUdrpZuC4VqOdfd-Wfp1o576zDCkXN070SvuCqji9t8W9HtAEboye9Mw6eKybKwsq_a28lng5y_BwtL$,
or unsubscribe
https://urldefense.com/v3/__https://github.com/notifications/unsubscribe-auth/AAMS4OBCVBDGMZ32IXIBBB3WR43GRANCNFSM6AAAAAATXRGEHM__;!!Mih3wA!H6fCTo1ZfRUdrpZuC4VqOdfd-Wfp1o576zDCkXN070SvuCqji9t8W9HtAEboye9Mw6eKybKwsq_a28lng8JTmx9q$
.
You are receiving this because you were mentioned.Message ID:
@.***>

@nilehmann any idea why the check-fmt and check-tests seem blocked?

looks like some odd gh glitch (the actions seem to be  "green" ...)


Make -beta count as -current.

Avoids trying getting stuck trying to update to release files while tracking -current through a bump.

Thanks! Good fix!


Please do not require Gsuite Super Admin for installation

The docs at [1] say that forseti 2.0 requires a Gsuite super admin account.  At [2], it was confirmed that the only purpose is to enable readonly access to Gsuite users and groups.
We would like to use Forseti in compliance-heavy environments where providing super admin will be unacceptable.  Please make this automated step optional.
[1] - https://docs.google.com/document/d/1RDw8QLhJVd-EAwIAviaboXwLoHPehteRGLCOXzEHBoc/preview
[2] - https://groups.google.com/a/forsetisecurity.org/d/msg/beta-testers/8gdeWG1oVSA/uyVIsctoDwAJ

@joecheuk feels that this can be done without any code changes.  Will test and update documentation, and installer if necessary with new prompt to user if they want to integrate with gsuite.

Since FS 2.0 release is coming out soon, it's safer to leave changes like these to post 2.0, will update the label to future milestone instead.

This will be updated in issue #1898

#1898 clarifies that this is optional.