Enhancement : muting threads should not affect view of starred messages

muting a topic removes the ability to see any message in that topic/thread which I've already starred, when I go to my starred messages. I wish muting wouldn't affect what I see in my starred messages - after all, the message is still starred
Use case: I'm interested to come back to a message later, but don't want to be alerted to all the activity now
@kracekumar maybe this would be of interest to u, and a narrow development https://github.com/zulip/zulip/issues/4271

@danlaudk can you provide a bit more detail on exactly what you're doing?  Does the message not show up in the "starred messages" view, or does it not show up after you click on the stream title to narrow to the stream (in which case you'd have left the "starred messages" view and gone to that stream)?
I would expect the current behavior to be that the message will appear in the stream+topic narrow (if you click in the topic), but not if you just click on the stream heading.  In either case, clicking on the heading leaves the "starred messages" view.
I feel like the current behavior is probably not right for clicking on the stream heading of a message in a muted topic that you found via "starred messages" or search (you should always see the message whose heading you clicked on), but I'm not sure what a reasonable solution is (possibly it should take you to a special stream narrow where topic muting is disabled).

Given that I: have subscribed to (and not muted) a stream, have starred a message, and then muted the topic that the message is in
When I: click on my "starred messages"
I should be able to: see the starred message when i scroll up/down (without having to enter any more keywords)
i missed office hours but will come to next one bc i can't follow

You could also just stop by chat.zulip.org and we can chat about it.

It sounds like this was a bug report, rather than a feature request. We should have this behavior:

Given that I: have subscribed to (and not muted) a stream, have starred a message, and then muted the topic that the message is in
When I: click on my "starred messages" just below "private messages" (ie the starred messages view)
I should be able to: see the starred message somewhere if i scroll up/down (without having to enter any more keywords)

and if we don't, then that seems like a bug.
It'd be good for someone to try to reproduce this. That will help us either fix the issue, or close it.

I see starred messages in muted streams and topics in the Starred message view. Closing this as resolved.


Add auto hide softkeyboard for mobile

Resolve #398
This PR add function listen for user touch events and determine the position relative to the editor. If position outside the editor, will close the keyboard

the hint isn't displaying properly

fixed


Fix inference of indexing argument (partly)

We need to add the T: Index<Arg> obligation to be resolved later as well, otherwise we can't make inferences about Arg later based on the Index impls.
This still doesn't fix indexing with integer variables though; there's a further problem with Chalk floundering because of the variable, I think.

cargo fmt fails

bors r+


[FEATURE]: Dynamic prefixes for volumes and snapshots

Describe the solution you'd like
As of date, the volume and snapshot prefixes are statically defined as a singular entry in the helm values. We need a better method to accomodate dynamic prefixes, e.g. appending the volume name with the PVC name. This helps in identifying the volumes in alignment with their corresponding workloads as seen in kubectl.
Example:
If I have a cluster with a distributed app leveraging three PVCs as an example.
PVC name:

ordering-mysql-1
billing-postgresql-1
shipping-redis-1

And if I provide a prefix name in the helm chart, e.g. myapp, then the resulting volume names as seen in the respective storage GUI will be

myapp-
myapp-
myapp-

Imagine if I have 30 PVCs it becomes cumbersome to identify the volumes with their workloads.
Requested feature is to provide a way to render dynamic prefixes which can concatenate PVC name with volume-id, such that the resulting volume name would be a meaningful reference. In such a case, the resulting list would be
PVC name:

ordering-mysql-1
billing-postgresql-1
shipping-redis-1

Volume names

ordering-mysql-1-
billing-postgresql-1-
shipping-redis-1-

thanks,
Ambar
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
Additional context
Add any other context or screenshots about the feature request here.

Hi @thecloudgarage, We are evaluating this feature request.

Hi @thecloudgarage, is this request for a specific platform ?

Similar request & PR were raised in external-provisioner. However, both were closed because of concerns related to naming collision and limit enforced by K8S on length of PV/PCV name.
If the request is for csi-powerstore, then Configurable Volume Attributes could provide a viable solution. This feature allows for the setting of optional volume attributes as labels in PVC.
Hope this answers your query. Please feel free to reopen the ticket in case of further queries.


New version seems to ignore ZopfliPNG filters on macOS

I recently upgraded to 1.0.2 and it's only generating PNGs larger than the originals I'm trying to optimize. On the output it looks like filters are being ignored.
Optimizing image.png
Input size: 6196 (6K)
Result size: 7294 (7K). Percentage of original: 117.721%
Preserving original PNG since it was smaller

I'm running it like this:
zopflipng --iterations=500 --filters=01234mepb --lossy_8bit --lossy_transparent --prefix *.png

I used git bisect to locate the problematic commit:
0aa547494212ae4d3911c9a4fc4be038fc966f05 is the first bad commit
commit 0aa547494212ae4d3911c9a4fc4be038fc966f05
Author: Lode Vandevenne<EMAIL_ADDRESS>Date:   Mon Jan 25 14:54:55 2016 +0100

    update zopflipng to use latest lodepng and fix png related bugs


Wednesday 06-09-2023 roll call

Roll Call!
Leave a comment with these two things:

A summary of your study using only emojis
Something you'd like to share, anything goes! (within respect)

emoji cheat sheet

Good morning

Good morning 🌻

Present!!

Good morning

Present

Good Morning

Present

:wave:

hi

Morning!

Morning

present

Present


resolve_request function and implementation

@pkdash let me know your thoughts on this

@aphelionz +1. Merge after Jenkins checks are successful.


I added my name

Please I am sorry for all the trouble we have caused you but count it all joy. Your PR is about to be merged and you will be able to see your name on this url.
To enable me to do this, READ the README again carefully, update your code with the latest and push the update. I am here for you for the next 6 hours before I close the PR so you can initiate a fresh PR which will be easier to merge.

Hello Meshioye Enoch!
Please open a new PR! Remember to make a branch as you work on your changes!
We look forward to merging your next PR! :partying_face:


ModelCIF output

I think outputting natively ModelCIF instead of PDB format would be a very nice feature for openfold.
I've been working on it for some time, see draft PR: https://github.com/aqlaboratory/openfold/pull/283
I'm opening the issue to see what's the interest on this and to see what metadata people would deem important to be written into the ModelCIF file. Currently the metadata I write is global pLDDT and local pLDDT per residue (using _ma_qa_metric ModelCIF categories)
What's missing in my PR is writing out the relaxed protein as ModelCIF. There's a few conversions between the protein object and PDB format strings during that process. I'm trying to find a solution that minimises the number of round trips protein -> pdb string -> protein.
Also one related question: the docs say that protein.from_pdb_string() is not able to read multi-chain files. However, the amber relaxation process does seem to use protein.from_pdb_string(): see https://github.com/aqlaboratory/openfold/blob/main/openfold/np/relax/amber_minimize.py#L551
That would imply that multi-chain predictions are lost in the relaxation process. Is that intended? Note I couldn't test it because I'm having trouble building flash attention.

Also one related question: the docs say that protein.from_pdb_string() is not able to read multi-chain files. However, the amber relaxation process does seem to use protein.from_pdb_string(): see https://github.com/aqlaboratory/openfold/blob/main/openfold/np/relax/amber_minimize.py#L551
That would imply that multi-chain predictions are lost in the relaxation process. Is that intended? Note I couldn't test it because I'm having trouble building flash attention.

Replying to myself: it looks like the docs of protein.from_pdb_string() are actually not right and multi-chain reading does work fine. Multi-chain predictions are not lost in the relaxation process. I'll fix the docs in my PR too.

I'll close this as complete now that the PR is merged.
As mentioned in #287 some headers are missing in ModelCIF. But they can be brought in later if that's deemed as important.

I fixed the Colab notebook in #285 which got merged the same day as #287 and it seems that #287 immediately broke the Colab notebook again. The problem is that Colab notebook has its own list of dependencies which was not updated to include modelcif. I'll try to fix the Colab again. But it is of cause bad to have dependencies specified at two places, this underlying problem should be fixed as well.

Yes, ideally dependencies should be defined in environment.yml only. Does Colab not use the dependencies from there?

No, it has its own (sub)set of dependencies and a bit tricky install, likely trying to speed things up doing only the minimum needed. But it complicates things of course. I am just running test of an immediate fix (adding one dependency) but unifying dependencies is worth some thought.


Add a toString method to class JsType

Error messages in Java Selenium tests are not very helpful because JsType objects have no toString method.
E.g.:
Expected condition failed: waiting for visibility of Proxy element for:
DefaultElementLocator 'ByText(text=seleniumtestinglib.queries.JsType$JsString@5488b5c5, selector=null, exact=null, ignore=null, normalizer=null)'

can you give me the code that generated that so I can encode it in a test and not lose it again?

solved here
Thanks for helping make the library better!


[4.0] Fix file drag-drop on M1 Macs.

Fixes file drag-drop not working on M1 (builds with min. target macOS version >= 10.14) - part of #39698.

Thanks!


Add support for Node 16.x

Many tests are failing with type-errors using Node 16.4.0.

Ah, this isn't Node. It's NPM v7.x+ which came bundled with my Node 16.4.0 install.
NPM v7.x has a breaking change for the outdated command with how the exit codes work. Prior to this an exit code of 0 indicated you had no outdated dependencies and a 1 indicated you had a command error or outdated dependencies.
https://github.com/ominestre/rotten-deps/blob/main/src/lib/npm-interactions.ts#L41
The linked code had to reverse the scenarios for older versions but I'm thinking that with this change I'm going to completely ditch branching functionality off of the exit codes.


Update links and use Partner Center name.

Note: The UWP docs refer to it as "Partner Center" rather than "the Partner Center".

Thanks @kmgallahan ! @winnieli1208 Can you review these changes? thanks!


Trouble installing using Mamba

Issue description
I am having trouble installing DataSAIL through mamba. It is unable to find the package datasail because it "does not exist".
I run the command
mamba create -n sail -c conda-forge -c kalininalab -c bioconda DataSAIL
Which yields the following
[... output regarding channels ...]
Could not solve for environment specs
The following package could not be installed
└─ datasail does not exist (perhaps a typo or a missing channel).

The problem persists whether or not I run the create command with the additional -c mosek or not.
System specifications
mamba 1.5.5
conda 23.11.0
python 3.10.13
Running on a Debian Bullseye (Debian 11.8) Docker image, with a MacOS Sonoma (M2 chip) as the underlying system.
It is not possible to install the package on the MacOS system directly due to the package cd-hit being unavailable on such a system.

Hey @cwinsnes,
please excuse the late response.
The problem is that all clustering algorithms (mmseqs, cd-hit, foldseek, and mash) only have builds for osx and linux-64. Which is funny, because to my knowlegde, they can be installed from source on M2 chips. I'm working on a solution to provide datasail without the clustering algorithms (at least for win-64 and m2 chips.
In the mean time, there are two solutions: Either switch to osx (or disable the M2 chip somehow, there's a way to get this done, but I'm not a Mac-User so, I don't know how) or install datasail from source by cloning the repo, removing the problematic dependencies from the meta.yaml and building it locally.

I thought working within the Docker container would alleviate that issue as it's Linux x64.
If compiling from source is the way, I'll try compiling that

The problem unfortunately persists when I run the command with python=3.10.
The version I used in the first post was Python 3.10.13, and I have tried with 3.11.2 as well, so it doesn't seem to me that it's the Python version.

This has been solved with commit 5fe4768 and in PR #22.


REST service to delete an existing Rasa story

AS AN Architect
I WANT to have a REST service to delete an existing Rasa story
SO THAT there wouldn't be duplicate services for it
Acceptance Criteria

Temporary list of endpoints - https://github.com/buerokratt/Buerokratt-onboarding/issues/8
Proto

[ ] Use POST endpoint /rasa/stories/delete
[ ] Apply changes on Rasa stories.yml
[ ] If #106 responds with HTTP 200, #108 is applied
[ ] When deleting a rule, all of its sub-content gets deleted as well
[ ] Changes apply only in case a story with an input name provided (story_name) already exists

In relation to https://github.com/buerokratt/Training-Module/issues/85 <------ CORRECT THIS ONE

Example
Initial input
version: "3.0"
stories:
- story: andmekaitse_küsimused
  steps:
  - intent: andmekaitse_küsimused
  - action: utter_andmekaitse_küsimused

- story: Deactivate custom fallback form
  steps:
  - action: custom_fallback_form
  - slot_was_set:
    - asukoht: Tallinn
  - action: action_react_to_affirm_deny_in_custom_fallback_form

Output after a request to delete andmekaitse_küsimused
version: "3.0"
stories:
- story: Deactivate custom fallback form
  steps:
  - action: custom_fallback_form
  - slot_was_set:
    - asukoht: Tallinn
  - action: action_react_to_affirm_deny_in_custom_fallback_form

sample input for /rasa/stories/delete
{
  "story": "tervitamine"
}

@RaulAltmae please link this issue with an appropriate pull request.

Pull request https://github.com/buerokratt/Training-Module/pull/161

Delete button is not functional.

BUG - Unable to delete existing rasa story. "Delete" button is not functional.

PR to fix story deletion on table page: https://github.com/buerokratt/Training-Module/pull/373

Works as intended.


separate cronjob for hiera; r10k cache; indentation fixes

Using separate cronjobs for code (control+modules) and hiera allows more frequent updates for the things that change more frequently (hopefully hiera).
Using r10k cache should speed up code deploys that make heavy use of forge modules.  Unfortunately, r10k seems to ignore cache for git based repos.
Indentation and git_sync cleanup was just because I was there and wanted to make that more consistent.

@slconley Thank you very much for the PR! Looks very promising!
Will take a look soon.

@slconley Closing in favour of: https://github.com/Xtigyro/puppetserver-helm-chart/pull/10
Thank you for the nice work!


Added New Script to #1

I have added a new script to the fancy folder. It is an animation of a progress bar.
Please review it.😀

Screen seems to be flickering with the two animations running in parallel on the stdout, is there something I'm missing?

I believe this phenomenon is occurring due to the alterations in the words preceding the commencement of the progress bar animation.

Nope, its clearly two outputs being written simultaneously because of a job spawned in parallel with &. Check if its really the intended behavior.

I have implemented the recommended modification, and I hope that it now functions correctly. I kindly request your review and feedback on the changes. Thank you for your assistance.

@Animeshz
I have rectified the width issue. Kindly request your formal review of the changes at your earliest convenience. Thank you for your time and consideration. :)


tag being specified incorrectly

Request type

[ ] Please close this issue, I accidentally submitted it without adding any details
[ ] New documentation
[x] Correction or update

Details

I think your first example of a
 is incorrect.

The spec for
 states:

Attribution for the quotation, if any, must be placed outside the blockquote element.

They have an example of how you can correctly use an attribution with a
 by using a
:

The truth may be puzzling. It may take some work to grapple with.
  It may be counterintuitive. It may contradict deeply held
  prejudices. It may not be consonant with what we desperately want to
  be true. But our preferences do not determine what's true. We have a
  method, and that method helps us to reach not absolute truth, only
  asymptotic approaches to the truth — never there, just closer
  and closer, always finding vast new oceans of undiscovered
  possibilities. Cleverly designed experiments are the key.

Carl Sagan, in "Wonder and Skepticism", from
 the Skeptical Inquirer Volume 19, Issue 1 (January-February
 1995)

To be clear, the  element can be used inside a
, but not for the purpose of attribution.

@chrisdavidmills Could you assign me to this issue? I'm interested in contributing to the interactive example. I think it would be best to update the interactive example to reflect the semantics of the spec example as quoted by @Glenn-Domin. Any thoughts?

@mikoMK yeah, I think this makes sense.
I'll assign you; thanks for all the help!


Import vue

Except changes in package.json, this should be OK. Resolves #24, #28, and implements suggestion in #42 .

Unfortunately, this change increases the ES5 package size from 26kb to 92kb due to including the Vue Library. We will need to investigate a different way to resolve #24 and #28.


Replace unbounded queues with bounded

Downsides: breaks API
Upsides: doesn't OOM

@harporoeder ping

@polachok Pardon the delay. LGTM.


Use kebab case event names

You can't listen to the events if you camel case.

Sorry for the delay @farooqaaa, It should be fixed from v2.2.5, included the backward-compatibility support as well.


Feature/add user input 3

Hey what's the overview of your PR, there's a lot of features being added here. Cheers

Hey what's the overview of your PR, there's a lot of features being added here. Cheers

Hey sorry PR is for wrong repo, I'll close it. Thanks for creating this repo, it is very helpful.


docs(ga): initialization

Overview

GA initialization to replace Vercel Analytics
PR Checklist

[x] I did below actions if need

I read the Contributing Guide
I added documents and tests.

I merge this Pull Request to initialize GA quickly


Add support for additional middleware

Adds support for additional middleware.
I am using this to add another middleware that'll wrap the body hash in a Hashie::Mash.

:+1:


[avisynthplus] Update to 3.7.2

Describe the pull request

What does your PR fix?
Updates avisynthplus to 3.7.2

Which triplets are supported/not supported? Have you updated the CI baseline?
As before, Yes

Does your PR follow the maintainer guide?

Yes

Thanks!


Update cache fails when metar contains a special character

Hi again :)
I noticed an exception when the metar contains the $ sign:
Updating cache : {'data': {'Remarks': 'RMK AO2 SLP247 T00611089 $', 'Runway-Vis-List': [], 'Station': 'KNYL', 'Time': '241057Z', 'Cloud-List': [], 'Wind-Direction': '350', 'Wind-Speed': '03', 'Wind-Gust': '', 'Wind-Variable-Dir': [], 'Altimeter': '3026', 'Visibility': '10', 'Other-List': [], 'Temperature': '06', 'Dewpoint': 'M09', 'Units': {'Wind-Speed': 'kt', 'Visibility': 'sm', 'Altitude': 'ft', 'Temperature': 'C', 'Altimeter': 'inHg'}, 'Flight-Rules': 'VFR', 'Remarks-Info': {'Temp-Decimal': '6.1', 'Dew-Decimal': '-8.9'}, 'Raw-Report': 'KNYL 241057Z AUTO 35003KT 10SM CLR 06/M09 A3026 RMK AO2 SLP247 T00611089 $'}, 'translate': {'Visibility': '10sm (16.1km)', 'Altimeter': '30.26inHg (1025hPa)', 'Clouds': 'Sky clear', 'Other': '', 'Wind': 'N-350 at 03kt', 'Temperature': '06C (43F)', 'Dewpoint': '-09C (16F)', 'Remarks': {'AO2': 'Automated with precipitation sensor', 'SLP247': 'Sea level pressure: 1024.7 hPa', 'T00611089': 'Temperature 6.1°C and dewpoint -8.9°C', '$': 'ASOS requires maintenance'}}, 'summary': 'Winds N-350 at 03kt, Vis 10sm, Temp 06C, Dew -09C, Alt 30.26inHg, Sky clear', 'speech': 'Winds three five zero at 3kt. Visibility one zero miles. Temperature six degrees Celsius. Dew point minus nine degrees Celsius. Altimeter three zero point two six. Sky clear'}
[2018-02-24 12:04:14,995] ERROR in app: Exception on /api/metar/KNYL [GET]
Traceback (most recent call last):
  File "/usr/local/lib/python3.6/site-packages/flask/app.py", line 1612, in full_dispatch_request
    rv = self.dispatch_request()
  File "/usr/local/lib/python3.6/site-packages/flask/app.py", line 1598, in dispatch_request
    return self.view_functions[rule.endpoint](**req.view_args)
  File "/usr/local/lib/python3.6/site-packages/flask_restful/__init__.py", line 480, in wrapper
    resp = resource(*args, **kwargs)
  File "/usr/local/lib/python3.6/site-packages/flask/views.py", line 84, in view
    return self.dispatch_request(*args, **kwargs)
  File "/usr/local/lib/python3.6/site-packages/flask_restful/__init__.py", line 595, in dispatch_request
    resp = meth(*args, **kwargs)
  File "/Volumes/MySamsung/xworkspace/aviation/AVWX-API/avwx_api/api.py", line 101, in get
    return self.get_report(rtype, station)
  File "/Volumes/MySamsung/xworkspace/aviation/AVWX-API/avwx_api/api.py", line 91, in get_report
    resp = handle_report(rtype, station, options, nofail)
  File "/Volumes/MySamsung/xworkspace/aviation/AVWX-API/avwx_api/handling.py", line 114, in handle_report
    data = CACHE.get(rtype, station) or new_report(rtype, station, report)
  File "/Volumes/MySamsung/xworkspace/aviation/AVWX-API/avwx_api/handling.py", line 78, in new_report
    CACHE.update(rtype, data)
  File "/Volumes/MySamsung/xworkspace/aviation/AVWX-API/avwx_api/cache.py", line 48, in update
    self.tables[rtype].update({'_id': data['data']['Station']}, data, upsert=True)
  File "/usr/local/lib/python3.6/site-packages/pymongo/collection.py", line 2968, in update
    write_concern, collation=collation)
  File "/usr/local/lib/python3.6/site-packages/pymongo/collection.py", line 835, in _update_retryable
    _update, session)
  File "/usr/local/lib/python3.6/site-packages/pymongo/mongo_client.py", line 1099, in _retryable_write
    return self._retry_with_session(retryable, func, s, None)
  File "/usr/local/lib/python3.6/site-packages/pymongo/mongo_client.py", line 1076, in _retry_with_session
    return func(session, sock_info, retryable)
  File "/usr/local/lib/python3.6/site-packages/pymongo/collection.py", line 831, in _update
    retryable_write=retryable_write)
  File "/usr/local/lib/python3.6/site-packages/pymongo/collection.py", line 797, in _update
    _check_write_command_response(result)
  File "/usr/local/lib/python3.6/site-packages/pymongo/helpers.py", line 208, in _check_write_command_response
    _raise_last_write_error(write_errors)
  File "/usr/local/lib/python3.6/site-packages/pymongo/helpers.py", line 190, in _raise_last_write_error
    raise WriteError(error.get("errmsg"), error.get("code"), error)
pymongo.errors.WriteError: The dollar ($) prefixed field '$' in 'translate.Remarks.$' is not valid for storage.

I believe the the data should be encoded before inserting them at
https://github.com/flyinactor91/AVWX-API/blob/bed76e4960d46420d2fdcfe424fa814182c2760c/avwx_api/cache.py#L48

it is actually because of the key in the Remarks being $
    "Remarks": {
      "AO2": "Automated with precipitation sensor",
      "SLP247": "Sea level pressure: 1024.7 hPa",
      "T00611089": "Temperature 6.1°C and dewpoint -8.9°C",
      "$": "ASOS requires maintenance"
    }


runs build-portal and commits the results

Which issue this PR addresses:

Fixes
What this PR does / why we need it:

Test plan for issue:

Is there any documentation that needs to be updated for this PR?

Failing checks are explained by python dependencies.
Change did not touch any python code


IndexError: index 5000 is out of bounds for axis 1 with size 5000

Worldengine - a world generator (v. 0.19.0)
-----------------------
 operation              : ancient_map generation
 resize factor          : 1
 world file             : worldofethos.world
 sea color              : brown
 draw biome             : True
 draw rivers            : True
 draw mountains         : True
 draw land outer border : False

starting (it could take a few minutes) ...
Traceback (most recent call last):
  File "<string>", line 619, in <module>
  File "<string>", line 586, in main
  File "<string>", line 143, in operation_ancient_map
  File "/media/workspace/WorldEngine/worldengine/worldengine/draw.py", line 804, in draw_ancientmap_on_file
  File "/media/workspace/WorldEngine/worldengine/worldengine/drawing_functions.py", line 833, in draw_ancientmap
  File "/media/workspace/WorldEngine/worldengine/worldengine/drawing_functions.py", line 215, in _draw_temperate_forest1
  File "/media/workspace/WorldEngine/worldengine/worldengine/image_io.py", line 224, in __setitem__
IndexError: index 5000 is out of bounds for axis 1 with size 5000
main returned -1

While most my errors have be from just running out of memory while generating worlds, this happened after I was able to successfully generate a world using
worldengine --not-fade-borders world -r -s 51293 -n worldofethos -q 80 -x 5000 -y 5000
But trying to generate an ancient_map caused the above error. This is on Debian 8.5 jessie, using a build from the release page.
CPU: Intel Xeon CPU E3-1245 v3 @ 3.8GHz
32171MB of Ram
x86_64 Linux 3.16.0-4-amd64
if that should matter.
(note I was able to generate a world and a map with the same argument, except with 4,000 instead of 5,000)

I'll have a look when I have time. Thanks for bringing this to our attention. :)


[ENH] introduce GeneratedBy to "core" BIDS

#439 is a WIP ENH to introduce standardized provenance capture/expression for BIDS datasets.  This PR just follows the idea of #371 (small atomic ENHs), and is based on current state (as of v1.2.2-189-g4550458) of #265 (common derivatives), which introduced PipelineDescription to describe how a BIDS derivative dataset came to its existence.
Rationale
As I had  previously stated in many (face-to-face when it was still possible ;)) conversations, in my view, any BIDS dataset is a derivative dataset.  Even if it contains "raw" data, it is never given by gods, but is a result of some process (let's call it pipeline for consistency) which produced it out of some other data. That is why there is 1) sourcedata/ to provide placement for such original (as "raw" in terms of processing, but "raw"er in terms of its relation to actual data acquired by equipment), and 2) code/ to provide placement for scripts used to produce or "tune" the dataset.  Typically "sourcedata" is either a collection of DICOMs or a collection of data in some other formats (e.g. nifti) which is then either converted or just renamed into BIDS layout. When encountering a new BIDS dataset ATM it requires forensics and/or data archaeology to discover how this BIDS dataset came about, to e.g. possibly figure out the source of the buggy (meta)data it contains.
At the level of individual files, some tools already add ad-hoc fields during conversion into side car .json files they produce,

e.g. dcm2niix adds ConversionSoftware and ConversionSoftwareVersion
(git-annex)lena:~/datalad/dbic/QA[master]git
$> git grep ConversionSoftware | head -n 2
sub-amit/ses-20180508/anat/sub-amit_ses-20180508_acq-MPRAGE_T1w.json:  "ConversionSoftware": "dcm2niix",
sub-amit/ses-20180508/anat/sub-amit_ses-20180508_acq-MPRAGE_T1w.json:  "ConversionSoftwareVersion": "v1.0.20170923 (OpenJPEG build) GCC6.3.0",

ATM I need to add such metadata to datasets produced by heudiconv to make sure that in case of incremental conversions there is no switch in versions of the software.
TODOs:

[x] consider/discuss replacing PipelineDescription with Pipeline (or ProducedBy)
[x] consider/discuss making it not a single dictionary but a list (order is irrelevant) to account for possibly multiple tools (or multiple versions of the same tool) being used to produce dataset
decide on how to point to included scripts (under code/) where applicable (I think it is OOS for this PR)
[x] decide if/how to annotate "manual conversion", where files literally were manually renamed
contribute to bids-validator to recommend adding this field to dataset_description.json (will file separate issue with validator whenever merged)
adjust common derivatives PR to account for this addition (it is part of the spec already)

I think this is a good idea.
One issue I can foresee is that we may need to easily identify raw vs derived datasets, where the rules differ (I believe derivatives describes itself as a "subclass", with some rules overriding raw rules). I had been thinking of the "PipelineDescription" field as an easy discriminating feature. I think your argument is good, and my vague plans don't reach the level or a reasonable objection. But we should think about how to manage that.

[ ] consider/discuss replacing PipelineDescription with Pipeline (or ProducedBy)

I think "PipelineDescription" might be too derivatives oriented. We would probably want something that can reasonably describe manual curation, a single tool, or a series of tools. "ProducedBy", "GeneratedBy" seem reasonable.

[ ] consider/discuss making it not a single dictionary but a list (order is irrelevant) to account for possibly multiple tools being used to produce dataset

I would be okay with this.

[ ] decide on how to point to included scripts (under code/) where applicable

I think we currently use stim_file entries in events.tsv files as paths relative to <bids-root>/stimuli. Perhaps relative paths are to be interpreted relative to <bids-root>/code?

[ ] decide if/how to annotate "manual conversion", where files literally were manually renamed

Even if a tool generates my dataset, there's nothing stopping me from making changes after the fact without adding an entry to PipelineDescription.
If we list multiple tools, it's probably not a bad idea to define an explicit manual curation entry to enable a curator to distinguish an automatically produced dataset from one that is additionally curated, but I also think it would be unwise for a downstream tool to interpret its absence as meaningful.

Generally, I am in favor of this addition. Thanks for the proposal @yarikoptic

consider/discuss replacing PipelineDescription with Pipeline (or ProducedBy)

I like ProducedBy better.

consider/discuss making it not a single dictionary but a list (order is irrelevant) to account for possibly multiple tools (or multiple versions of the same tool) being used to produce dataset

Yes, accounting for multiple tools INCLUDING manual (really manual, not even a script) curation would be better. I think many dataset curation processes require more than a single tool.
We should also add an explicit request that IF truly manual fiddling with the data has been done for conversion, this should be described in a specific README file, possibly placed in /code. So to say, a "poor man's script".

decide on how to point to included scripts (under code/) where applicable

yes, I find this important and it would enhance the present implementation of the /code directory

decide if/how to annotate "manual conversion", where files literally were manually renamed

see what I wrote above

decide if/how to annotate "manual conversion", where files literally were manually renamed

yes, and preferably also editing an example dataset under bids-standard/bids-examples for ilustration and testing purposes.

Thank you @effigies and @sappelhoff for the feedback!  Very much appreciated. It seems that we are very much "in line" ;)
I (or someone who beats me to it, unlikely we would overlap in time) will adjust this PR accordingly in upcoming days.

ATM I need to add such metadata to datasets produced by heudiconv to make sure that in case of incremental conversions there is no switch in versions of the software.

i would expect for long running studies the details may vary over time, unless the group decides to stick with a particular containerized release. i think there should be a distinction between best practices and what actually happened.
i would recommend aligning with #439 as much as possible. otherwise the keys you introduce are going to overlap with that. already "generatedBy" and perhaps given the goals are similar to focus on a common discussion there.
further different parts of a dataset may be generated by different pipelines. for example, for "raw" datasets:

MRI conversion (e.g., dcm2niix followed by gradient nonlinearity correction, or e.g., some pieces of bep001 are generated by postprocessing software)
stimulus information conversion (e.g. uses both eprime and psychopy)
assessment information (e.g., from redcap, nih toolbox, pavlovia, etc.,.)

i agree that at a basic level it would be useful to add "wasGeneratedBy" (or some such key) to each json file, but the value of this key could potentially be a list of the number of things directly editing/transforming the file (for example the gradient nonlinearity corrected nifti files).

Thank you @satra !

i would expect for long running studies the details may vary over time, unless the group decides to stick with a particular containerized release. i think there should be a distinction between best practices and what actually happened.

I think it should be STRONGLY ( ;-) ) RECOMMENDED to use particular release, and containers as the best way ATM to make that happen.  Tools could provide easy ways to "reconvert" happen change is desired interim.

i would recommend aligning with #439 as much as possible
yes -- aligning with #439 should be in mind, so I will need you
r reviews/fixes ;)

further different parts of a dataset may be generated by different pipelines...

that is what eventually we might arrive at here, that dataset_description.json would contain a "summary" over detailed provenance descriptions #439 arrives with. Meanwhile, I will aim at somewhat "high level" description of the dataset producer... may be later we should indeed allow similar record in any side car .json file to describe particulars of the associated data (.nii.gz, .tsv, etc) file.

@yarikoptic this is a good proposal. I am wondering how PipelineDescription with Pipeline (or ProducedBy) will handle products that are generated by multiple Pipelines. Another way to say this, is this mean to only track 1-back pipeline but not further beyond the latest processing step?

I would leave proper provenance/graph for PROV BEP, and here just keep a list as a set (so no particular order) of tools which had produced anything in this dataset.

Notes from BEP 003:

PipelineDescription => GeneratedBy
Value is always a list.

See https://bids-specification.readthedocs.io/en/common-derivatives/03-modality-agnostic-files.html#derived-dataset-and-pipeline-description.

ok, am I re-reading it right that there are no changes to do for this PR?
Re DatasetType, we have
DatasetType:
  name: DatasetType
  description: |
    The interpretation of the dataset.
    MUST be one of `"raw"` or `"derivative"`.
    For backwards compatibility, the default value is `"raw"`.

I wonder -- why is it "for backwards compatibility" only?  if it was not, then we could assume that it is mandatory for "derivative" datasets to be specified. With such wording it kinda suggests -- I should not even bother specifying it for derivatives?  or my reading is incorrect?

@effigies - ping on the above

ok, am I re-reading it right that there are no changes to do for this PR?
Re DatasetType, we have
DatasetType:
  name: DatasetType
  description: |
    The interpretation of the dataset.
    MUST be one of `"raw"` or `"derivative"`.
    For backwards compatibility, the default value is `"raw"`.

I wonder -- why is it "for backwards compatibility" only? if it was not, then we could assume that it is mandatory for "derivative" datasets to be specified. With such wording it kinda suggests -- I should not even bother specifying it for derivatives? or my reading is incorrect?

A derivative dataset that does not declare it will be interpreted as raw. In effect it's optional for raw and mandatory for derivative, but we can make it recommended so people know to add it and be explicit.

@tsalo I think your change requests have been addressed.

I think it is blessed for a merge? ;)

Thanks @yarikoptic


Feature Request: Select 'not in tree'

Thanks for the program, it looks great! Sadly, my random use case that popped up right after I saw it isn't covered.
I'd like to be able to compare duplicates as is, but then, on the selection, have the option to select (and delete) all of the files that are  in a selected directory tree. I have multiple copies of the same folder that have diverged and I essentially want to keep one tree as is, and then only keep the files that are different in the second tree.

This is probably issue with Czkawka, not a Szyszka, but feel free to reopen this


Enabling code scanning

Enable Code Scanning

I don't want to add a ton of sample files to this repo because they'll get out of date quickly. Thanks for your contribution!


Wrong path for CSS injection

I downloaded the project and built it, and right out of the box the main.css file is included with the wrong path.
Build the project and in index.html you will find:
  <!-- inject:css -->
  <link rel="stylesheet" href="/dist/dev/css/main.css?1470054810731">
  <!-- endinject -->

The desired path should be:
  <!-- inject:css -->
  <link rel="stylesheet" href="/css/main.css?1470054810731">
  <!-- endinject -->

I tried changing the CSS_DEST variable but it didn't seem to change anything.

I guess you did a dev build. If so then the path is correct (/dist/dev/css/main.css)

The root of the website is the /dev folder, so the path should be relative to that. This way the css file isn't found.

The root of the website is the /dev folder
Not so, in the dev environment, the root directory is by default the 'top' folder of the project, i.e, where package.json lives. This is because (one reason at least) the application needs to reference files from the node_modules folder, which lives at the top level. There would be no way to get at them if /dev were the root.  The production build works more like you are expecting, with dist/prod being the root.

I was using the dev folder as the root with node_modules as a virtual directory. It is all working fine except for the css folder.
I tried to set the root in the main folder and access the site using something like http://localhost/dist/dev, but now routing is messed up and so are plenty other .js references.
How can i change the include path of the css file for the dev build?

It sounds like you are trying to run the dev build using an external server? That may be possible, but not worth the effort. Just run "npm start" in the root directory and everything will run correctly out of the 'box'.

@carol-braileanu, @ckapilla has a point here. In development I'd recommend you to use your API by using CORS. You can deploy the production build (which is standalone and doesn't have any dependencies outside dist/prod) to any environment.


Help requested to understand a stack overflow for a sane code used within imgui-rs context

Hello,
I have a code that is executed when clicking on a button of an imgui interface.
If this same code is launched within unit-tests it works perfectly.
But when launched from imgui, it raise a stack overflow issue.
The diff at the end of the message allows me to get ride of this problem by creating threads with their own stack.
However, is this behavior standard ? I have found no documentation related to such kind of issue and I suppose they are common in imgui-rs contexts ?. Isn't it ?
Have I another way to implement that more properly ?
Thanks

                 if ui.small_button(im_str!("Send to CPCWIFI")) {
-                    let save = state.magic_rasters.snapshot()
+                    let copy_state = state.clone();
+                    let child = std::thread::spawn(move || {
+                        copy_state.magic_rasters.snapshot()
                                 .and_then(|sna| {
                                     match sna.save(
-                                        state.sna_filename.to_str(),
+                                        copy_state.sna_filename.to_str(),
                                         cpclib::sna::SnapshotVersion::V2) {
                                             Ok(_) => Ok(()),
                                             Err(io) => Err(io.to_string())
                                         }
-                                });
+                                })
+                    });
+                    let save = child.join().unwrap();

                     if save.is_err() {

Closing old issue (at a complete guess, it might be something similar to https://github.com/imgui-rs/imgui-rs/pull/688#issuecomment-1363471031 where if the types of the snapshot are large, they can occupy a lot of stack space in the function, moving it to a thread with its own stack avoids this)


Remove Sass in favor of CSS

As recommended by @ctwhome :
Because the plugin CSS is fairly simple and no variables, functions or other Sass features are used, using CSS directly removes a layer of complexity from the Vite configuration and compiling process.
This pull request converts the SCSS file back to CSS and removes the sass package dependency.

Bravo @vtwigt !


ShareX Video Recording issue

Describe the bug
The Shell completely disappears when you try to make a video with ShareX
Steps to reproduce

Open ShareX
Make a Video

System information:

Windows version: Windows 10 1909 - 18363.592
Cairo version: 0.364.2.0
32-bit or 64-bit: 64
In Cairo Settings > Advanced, is Cairo set as shell?: Yes

I'm not able to reproduce. How are you taking the video, and what other applications are running?

Seems to be a issue only when you have just installed Cairo after restarting it works without issues.


Could I PR for SliverClipRRect?

Also, I propose to rename SliverClip to SliverClipRect to align with Flutter naming for Box-based widgets.

Hi @AlexanderFarkas yeah sure that would be very welcome
I do want SliverClip to stay though at least for now, but feel free to add an alias SliverClipRect as well.
Perhaps all of them can be statelesswidgets that give different paths to SliverClip or something like that

@AlexanderFarkas did you manage to make some progress?
Feel free to open a Draft PR if you need any help/advice


MatSortHeaderRow not compatible with MatTable

Hi
I am just trying this for the first time, but I would like to use the sort row with the table, or have this built into the the table like the paging.
Is this already possible?
Thanks
Paul

@paulc1983 ,
There have been some MatTable development progress. Can you confirm if this is still an issue in 2.8.0?


[FLINK-29969][checkpoint] Show the root cause when exceeded checkpoint tolerable failure threshold

What is the purpose of the change
Add the root cause when exceeded checkpoint tolerable failure threshold, it's helpful during troubleshooting.
After change:

Brief change log
Add the root cause when exceeded checkpoint tolerable failure threshold.
Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): no
The public API, i.e., is any changed class annotated with @Public(Evolving): no
The serializers: no
The runtime per-record code paths (performance sensitive): no
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
The S3 file system connector: no

Documentation

Does this pull request introduce a new feature? no
If yes, how is the feature documented? not documented

@Myasuka  Please help take a look in your free time, thanks~

@flinkbot run azure

@flinkbot run azure

@flinkbot run azure

@flinkbot run azure


⚠ ClamAV has degraded performance

In 5ec07b7, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 78 ms

Resolved: ClamAV performance has improved in cb7d6a3 after 7 minutes.


Typescript rewrite

Does any other open PR do the same thing?
No
What issue is this PR fixing?
None
How did you test this PR?
Source code evaluation and manual testing.
Misc comments
A full transition to TS.
This took a quite a while to do, so reviewing probably will as well.
This fixes numerous (I stopped counting) TS errors, mostly in callback types, and probably also introduces some (I did rigorous examination of every component, but I surely missed something), and as such, this might introduce new errors.
Regardless, this should lead the way for a new code base which doesn't require manual examination of the d.ts file and proptypes each time the source code is changed.
We could also look into generating docs from JSDoc, to further reduce the sources of documentation? I have no personal experience with this, but reducing the different parts of documentation that needs manual work would be great.
The documentation currently uses @platform iOS and @platform Android without further description, but as iOS supports both Google Maps and Apple Maps, this isn't enough. This pull request seeks to address this as well, adding a thorough platform description to each component prop.
Please feel free to chime in regarding type placement and so on. This probably needs some refactoring.
I still need to do some testing on this as well, but the more the merrier, so I decided to push this now.
Testing:

Clone this pull request
Run the newly added build script, eg: yarn build
copy and replace dist/index.js, dist/index.d.ts, dist/types.js, dist/types.d.ts & dist/components folder into your node_modules/react-native-maps

BREAKING CHANGES:

drops supports for react-native < 0.63.4
Remove animateToNavigation, animateToCoordinate, animateToViewingAngle and animateToBearing.
Removes legacy iOS snapshot method
Components are no longer re-exported under MapView.

Still need to handle #1132 somehow.
On iOS, every event can basically be of any event type.

I get what you are trying to achieve, but I don't really think it's possible. As soon as you rename the files from .js to .ts, git(hub) will track it as though you deleted all the .js files and added all the .ts files.

This might of been a thing in the past but Github now tracks the file change and shows the diff as normal. Take a look at this diff on a quick test I did. https://github.com/react-native-maps/react-native-maps/compare/test-ts?expand=1

@Simon-TechForm Any updates here? I think another reason for updating the existing files is that it would reduce the number of steps to test. Ideally, we could just check out your branch and run the example or test existing applications by referencing your branch instead of the latest release.

@Simon-TechForm Any updates here? I think another reason for updating the existing files is that it would reduce the number of steps to test. Ideally, we could just check out your branch and run the example or test existing applications by referencing your branch instead of the latest release.

I had a couple of busy weeks that didn't allow me to work on this, but I'm expecting to be able to look at this again within this week. I will get back to you.

@christopherdro can you specify how you would like to handle gitIgnore, ts outDir etc.? I've added a crude solution for now, but I'm not at all accustomed to having .ts files in the lib/dist folder.

See #4057


:reg command should also show register types

Getting the type of a register is cumbersome with :call getregtype('a'). Instead,
:reg command should also show whether the register is linewise or characterwise since the paste behavior is directly dependent to this and it's not clear just from register content. ^J at the and only gives an hint but not explanatory.
For example, the behavior of these apparently identical registers would be vastly different when it comes to pasting.
:reg
"a foo
"b foo
Instead, it should show
:reg
"a foo (V)
"b foo (v)
or for terseness, only linewise registers can be shown with extra mark (V).
:reg
"a foo (V)
"b foo

Make a custom command called :Reg that does getregtype on its argument.

Make a custom command called :Reg that does getregtype on its argument.

or it can show registers contents with types.

So I suppose, this can be achieved by a custom plugin. Closing therefore.

Hmm, I think it's worth doing this with :reg, since it's generally useful.
We could add one character to indicate the type.  And leave it out for the most common type.  Would that be characterwise or linewise?
"1     deleted line
"2 c  deleted text
"3 b  deleted block

^J at the and only gives an hint but not explanatory.

If ^J is not "explanatory", then neither will be some other single character.

^J at the and only gives an hint but not explanatory.

If ^J is not "explanatory", then neither will be some other single character.

What I mean is, ^J does not tell you about (character/line)wiseness of a register. You can just fill a characterwise register with ^J at the end of it.

Hmm, I think it's worth doing this with :reg, since it's generally useful.
We could add one character to indicate the type. And leave it out for the most common type. Would that be characterwise or linewise?
"1 deleted line
"2 c deleted text
"3 b deleted block

I think characterwise would be the most common type. Not sure, though.


Fix warnings

Rake runs ruby with warnings enabled by default now (ruby/rake#97)

thanks for the PR ひろき。Most of those classes/files are trash now, after the refactor, I will clean it up today, and ping you to rebase after that.
ありがとうございます

I guess, you will release v2.0. ( it is after refactoring version )
I'm looking forward to it.
Thank you, a message in Japanese.


Bug: Ambient Light Level

Describe The Bug:

Hi, I am getting this error:
[9. 1. 2022 17:28:50] [homebridge-electrolux-wellbeing] This plugin generated a warning from the characteristic 'Current Ambient Light Level': characteristic value expected valid finite number and received "undefined" (undefined). See https://git.io/JtMGR for more info.
To Reproduce:

Expected behavior:

Logs:
Show the Homebridge logs here, remove any sensitive information.

Plugin Config:
Show your Homebridge config.json here, remove any sensitive information.

Screenshots:

Environment:

Plugin Version:
Homebridge Version:
Node.js Version:
NPM Version:
Operating System:

HomeKit shows:
0 LUX inside the round icon
0,0001 lux under the “Current Light Level” parameter in the Light Sensor Detail

Have same issue. Have Pure A9 form friday 7th January.
[1/13/2022, 5:02:19 PM] [ElectroluxWellbeing] Could not fetch appliances data
(node:3844) UnhandledPromiseRejectionWarning: TypeError: Cannot read property 'temp' of undefined
at /homebridge/node_modules/homebridge-electrolux-wellbeing/src/index.ts:185:72
at Array.map ()
at ElectroluxWellbeingPlatform.updateValues (/homebridge/node_modules/homebridge-electrolux-wellbeing/src/index.ts:179:22)
at ElectroluxWellbeingPlatform.checkAppliances (/homebridge/node_modules/homebridge-electrolux-wellbeing/src/index.ts:101:10)
at processTicksAndRejections (internal/process/task_queues.js:95:5)
(Use node --trace-warnings ... to show where the warning was created)
(node:3844) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). To terminate the node process on unhandled promise rejection, use the CLI flag --unhandled-rejections=strict (see https://nodejs.org/api/cli.html#cli_unhandled_rejections_mode). (rejection id: 3)
(node:3844) [DEP0018] DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js process with a non-zero exit code.

Same issue; however I'm using the AEG XA9 air purifier.
Electrolux Wellbeing BridgeERROR[Electrolux Wellbeing Bridge 3DB8@Airy@@Current Ambient Light Level] characteristic value expected valid finite number and received "undefined" (undefined)
Plugin Version: 0.1.0
Hoobs 4.0.110
Homebridge Version: 1.3.4
Node.js Version: 14.18.2
NPM Version:
Operating System: PI

A classic instance of "bug fixed" but no new release.
Open a Terminal in Homebridge UI (from the "kebab" menu, top right) and in the terminal install the latest version from github:
cd /homebridge
npm install git+https://github.com/baboons/homebridge-electrolux-wellbeing.git#b41d7770c435c4a792151ba78cefcf728e00eec6

Then restart Homebridge.

As I have the AEG version, I’ve taken the fixed version, removed the light sensor, updated the dependencies and published it as homebridge-aeg-wellbe8ng. It should work with both AEG and Electrolux versions.


Add pushOrPop action - it will pop if scene exists in the stack, push…

… otherwise

@aksonov how does one make use of this? I understand the concept of calling the action, but is there a type that I can add to the component to allow this to action to be called, instead of the default push?


Use docker instead of rkt for regular etcdadm tasks (#4)

Motivation is to avoid serious memory leak on etcd nodes as in

https://github.com/coreos/bugs/issues/1927

Also it potentially mitigates issues https://github.com/kubernetes-incubator/kube-aws/issues/691 and https://github.com/kubernetes-incubator/kube-aws/issues/660 as the symptoms looks similar to our case.

Codecov Report

Merging #705 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #705   +/-   ##
=======================================
  Coverage   35.31%   35.31%
=======================================
  Files          53       53
  Lines        3047     3047
=======================================
  Hits         1076     1076
  Misses       1802     1802
  Partials      169      169

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4637d39...062ea37. Read the comment docs.

@ytsarev Thank you very much for your effort on this 👍 I've read through/connected all the referenced links in mind and this change looks good to me.

@mumoshu is the issue also exists in v0.9.6?

Yes, I believe so, unfortunately.
2017年6月21日(水) 18:25 billy ray teves<EMAIL_ADDRESS>
@mumoshu https://github.com/mumoshu is the issue also exists in v0.9.6?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/kubernetes-incubator/kube-aws/pull/705#issuecomment-310022666,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AABV-feIAmUOMrv_DV-M6bmc4tawhXBoks5sGOGVgaJpZM4N8NX9
.

If I select containerRuntime: docker in cluster.yml, is that supposed to use docker for etcd setup? or this cluster.yml option is only used for Workers? What about Controllers?

@VinceMD It is supposed to use docker only for containers managed by kubelets when containerRuntime: docker is set. Both controllers and workers runs kubelets for scheduling various pods, so controllers do get affected by the option.
On the other hand, etcd isn't managed by k8s/kubelets hence it is always run by rkt.


Add A Working Loop Song Button.

A button which can be used to play one song on loop.

[ ] Added A Working Loop Button in the Bottom Bar in the left of previous button.
[ ] This button is working properly.
[ ] The current song must start playing again after getting finished.

Kindly assign this to me.

I've made a pull request. Kindly review it.


CIP-100 | Re-canonicalize example

Addresses #781
Where the hashAlgorithm field was missed in the canonized example, I believe this to be a mistake.
I used this JSON-LD playground to produce the canonized versions of the metadata plain text to be used to hash.
I am unsure if JSON-LD playground complies strictly with the RDF Dataset Canonicalization, so I am unsure on the correctness.
@Quantumplation what tool did you use to create the example originally?

So, according to the spec, I believe my original values to be correct, but incomplete.
There are two different hashes to compute:

the hash of the body field that gets signed by the participants
the hash of the whole document, including the signatures and the hash algorithm, that gets published in the anchor field.

The example provided in the document and via the example files is the former, and my document is missing examples for the latter.
The chain of reasoning here is:

the signatories can't sign the hash of the whole document, because of chicken-and-egg: we don't have the signatures needed to produce the whole document to produce the final hash
it's not particularly important for the authors to sign off on which authors are going to sign the document (i.e. in order for me to sign, I don't need to know that you are also going to sign); similarly, it's not super important that, as an author, I sign off on what hash algorithm is going to be used to publish it on-chain.
So, rather than trying to cherry pick which fields to exclude (i.e. the signatures), we instead define a single field to include, i.e. the body
It is also not sufficient to publish the hash of the body on-chain, because it is important that the on chain commitment capture that, at the time of submission, it had all of the valid signatures, and they weren't added after the fact.

So I think the correct thing to do here is to either re-evaluate this decision, or make this distinction clearer and add the test vectors / example hash for the canonicalization of the full document, along side the hash of the body field.

In particular, this section describes the process used:

Canonicalize the whole document according to this specification.

Identify the node-ID of the body node
Filter the canonicalized document to include the body node, and all its descendents
Ensure the file ends in a newline
Hash the resulting file with blake2b-256

The tool you used is indeed the one I used as well, and I believe it follows the canonicalization spec.

Thank you for the explanation @Quantumplation

make this distinction clearer and add the test vectors / example hash for the canonicalization of the full document, along side the hash of the body field.

I will do this within this PR.
I have made a similar effort for CIP-108 already here.

I don't fully understand how the example.canonical is generated. It seems to have less fields than the canonical form and more than the canonical body. Is it properly defined and if not should we delete the file?

I don't fully understand how the example.canonical is generated. It seems to have less fields than the canonical form and more than the canonical body. Is it properly defined and if not should we delete the file?

It is the canonicalized version that is used for signing, see the comment above and in particular the highlighted section from the spec. As far as I can tell, it is correctly generated.

the highlighted section from the spec

I thought this generates example.body.canonical which differs from example.canonical.
The author name is not part of the body, so it shouldn't be used used for signing right?

Ah ok, I guess I did include both examples, my bad. I'm trying to figure out where example.canonical became incorrect, because I for sure wouldn't have stripped it out by hand or anything...
Regardless, this PR makes a bit more sense. Let me try to reproduce independently to confirm.

Damn, yea, it looks like it was inaccurate as of my commit here:
https://github.com/cardano-foundation/CIPs/pull/556/commits/93999e0e436e6de962862190014d0363a2d327e0#diff-57ee612f4824a274191cfea80c0ae926f7e128c42a2b6d8ba5187065d63f28b9
Not sure what happened, because I remember being very meticulous about generating it exactly because it would be used as a reference 🤔

@Quantumplation @kderme
I have added a test vector file with explanation on how to recreate as well as missing intermediate file.
Please let me know what you think.
When I have time I think I will redo the example with a proper signature as the abcd is getting to me 😆.

When I have time I think I will redo the example with a proper signature as the abcd is getting to me 😆.

If you'd like, I can do that this weekend with my actual keys, since I'm the one listed in the authors :)

If you'd like, I can do that this weekend with my actual keys, since I'm the one listed in the authors :)

That would be great, thank you

Possibly there is a bigger issue of circular dependencies when trying to create signatures. I've opened a different issue https://github.com/cardano-foundation/CIPs/issues/783

@Ryun1 @Quantumplation @kderme I've classified this as an Update rather than just a Correction because of the significant content that is being added as well as fixing whatever inaccuracies may have existed originally.

Just a quick note here for @Ryun1 and @Quantumplation but I noticed that the canonical file is not using "permalinks" that reference a specific pull request, which means that the canonicalization may fail and break hashing if the context of a field ever changes between generation and publication...

@Crypto2099 the URLs in the context should never change. The URLs are more unique identifiers than anything, and aren't used by computers to pull in any data. They're only meant to uniquely identify and disambiguate between fields. They're URI's for a humans sake, as a convenience, so they can go read about what those fields mean if they want. Even if Github disappeared, and the spec was hosted elsewhere, the URLs should stay the same so that computer consumers continue to know the fields means the same thing.
Thus, it's important to have a stable URL that points at the "latest" version of the spec, in case it's updated with any clarifications / corrections, but also for the spec to not change. Any substantial changes to the meaning of these fields should be a new CIP, which would result in new URLs, to disambiguate.

@Ryun1 I think you should remove example.body.json; this could be confusing, as it implies you create the canonical format through an intermediate json document, but that's not correct (at least according to the current spec). The path is json -> canonical form -> body subset rather than json -> body subset -> canonical form.

In fact, looking into this more, it looks like the canonicalization algorithm is particularly bad for this purpose, in that it depends on the actual content stored in the fields, not just the fields themselves. This is frustrating, as most canonicalization algorithms are content agnostic (see, for example, the CBOR canonicalization, which just specifies map keys are in alphabetical order, use of definite vs indefinite containers, etc.)
So we will need to revise the signing process regardless.
I would suggest something like the following then:

start from the json document that everyone wishes to sign
Remove from this document any top-level field that is not @context or body
NOTE: Extensions to the spec MUST emphasize that anything outside of body is NOT covered by the authors signature. Alternatively, extensions to the spec MUST not add fields outside of body.
compute the canonical form of this document
Hash it
sign it
insert the signatures in the appropriate places in the original document

This way is equivalent to what it's described on this branch, but to me is a bit confusingly worded. i.e. it talks about "adding in" the body, and makes reference to cip-0100.common.jsonld... but other documents have have a different context, that's the whole point.

@Quantumplation
I have refactored, and fixed wording as pointed out in #782 comment.
Changes

Emphasised that the intermediate files are not necessary
Renamed from using .canonical to the correct .nq
Added in keys to produce a author witness
Improved wording

I think this is everything that is needed.

@Quantumplation
We will put this on the CIP editors agenda for Tuesday 30th.
cc @Quantumplation


Document tile maps

Greetings,
Currently the documentation only says that KorGE supports tile maps, but not how to use them. One thing I'm interested in in particular is, does KorGE support maps generated with mapeditor?

It supports tiled tilemaps indeed. You have an example here: https://github.com/korlibs/korge-samples/blob/5a259513363945d6edcc5909154e43b484b0b89e/samples/tilemap/src/commonMain/kotlin/main.kt#L11
Documentation indeed is lacky right now, and will be improved


Add style on TextField

Maybe someone wants to customize style on textfield. Also, I need it.

@CCJY Thanks for the PR and sorry about my late reply.
LGTM, I will confirm it, merge and release new version asap

Could you please merge that, I need that too :)

Just released to 0.0.5. Thanks!


introduce a way to configure a preston data dir

right now, the preston tool expects a directory with name "data" to exists. This folder contains the files organized by their hashes.
proposed is to make the name/location of the data directory configurable.

introduced parameter --data-dir to set local data dir with "data" as default.

example:
preston clone --data-dir=bhl https://archive.org/download/preston-bhl
would clone a snapshot of BHL into local dir bhl .


Create hello-git.md

hello my order

Hi @pyaphonlin!
Thanks for wanting to contribute to Bootstrap by sending this pull request!
Unfortunately, your pull request seems to have some problems:

The title of this pull request strongly suggests that you were using Bootstrap to test out Git or GitHub, rather than proposing a legitimate change. If that's accurate, please DON'T do that again! Instead, use your own personal repositories to experiment with how to use Git or GitHub. Using the repos of public projects (such as Bootstrap) for such experiments wastes the time of those projects' maintainers and is thus considered rude.

You'll need to fix these mistakes and revise your pull request before we can proceed further.
Once you've fixed these problems, you can either ask the maintainers to re-open this pull request, or you can create a new pull request.
Thanks!
(Please note that this is a fully automated comment.)

I don't think you have done a good job.

@pyaphonlin please do not use public repository to test Github thank you


Email Signup Survey Broken

A recent change to the email signup survey has caused it to stop working, due to a missing hidden field (survey_source). After reading through the PR, I can't work out why this field was removed, as it doesn't seem to be related to the overall change and the value is still available to use.

@benthorner I'll take a look, this seems fairly urgent.


Can the debug package be upgraded to 4.3.3?

Hello,
Your package depends on the<EMAIL_ADDRESS>and it have vulnerabilities.
How about upgrading it to 4.3.3?

Hello, and thank you for your report. We are not aware of any known vulnerabilities against the version we are using, and none are showing on the standard public scanners like Synk and npm. Please contact me following https://github.com/expressjs/express/blob/master/Security.md with the details of the vulnerabilities that are present in the debug version we are using and we can work on a plan to change.


[4953] - backfill manchester hesa student degrees

Context
Manchester University is having several problems with their degrees on trainees. I asked them to recommit as we've done some work which we thought would fix the issue, but it seems these issues are still there.
Changes proposed in this pull request

generic hesa degree backfilling service
migration for the 4 students raised in the ticket

Guidance to review

check migration and service logic
if testing, download latest copy of prod data and run migration remove the guard clause in migration
the Hesa::Backfilling service includes logic for writing to disk, as it's useful to do this if debugging hesa records locally. By default the hesa xml is not written to disk.

Important business

[ ] ~Does this PR introduce any PII fields that need to be overwritten or deleted in db/scripts/sanitise.sql?~
[ ] ~Does this PR change the database schema? If so, have you updated the config/analytics.yml file and considered whether you need to send 'import_entity' events?~

NB: Please notify the #twd_data_insights team and ask for a review if new fields are being added to analytics.yml

 Manchester University's issues with degrees on their trainee records


The Max Tokens shows the same info that Max Output Tokens

In my opinion, merging fields that consistently display the same data would be beneficial. It'll tidy things up and improve usability.

fixed :)


ZAPD should support text decompilation to C files.

ZAPD should also support PAL and NTSC message systems.

We can probably backport ZText from ZAPDTR for this.

I have this started at:
https://github.com/louist103/ZAPD/tree/text

This isn't required of ZAPD as far as the oot decomp is concerned, there's already different tooling in place to extract the text
And MM afaik the relevant code isn't (fully) decompiled yet?

I understand we have tooling in place for text extraction, but as I understand it's written in Python and currently takes around ten seconds to extract. I feel we can improve upon that extraction time, given Python isn't the best language for this kind of thing. If decomp doesn't want to use it that's fine but I still want the option to be available.

For the record it takes ~1.5 seconds for me to extract both text files (regular and credits)


Alphabetical sorting regardless of capitalization

Hi there ! First off thanks for you work, this tool is awesome, using it has made my life pure bliss 👌
My issue is th following:
I am currently using isort with the following flags, in order to replicate the appnexus import style:
isort  --line-width=100 \
         --force-single-line-imports \
         --force-sort-within-sections \
         --lines-after-imports=2 \
         --lines-between-types=0

I've been unable to find a way to sort imports alphabetically within a section ignoring capitalization , e.g. in this example I would like LSTM to be put after Dense, instead of before:
from pathlib import Path

from tensorflow.keras.layers import LSTM
from tensorflow.keras.layers import Dense

from my_company_package import something

...

I would like to know if it's possible and I'm overlooking something or if it would need to be added. the reason I ask is because I use isort with the flake8-import-order extension, which raises a warning here.
Nothing pressing about this obviously, I was just wondering if something could be done.
Cheers !

Hi @r0mainK,
Thanks for reaching out! I'm so glad you find isort helpful!
I think you are looking for order_by_type: https://timothycrosley.github.io/isort/docs/configuration/options/#order-by-type if this is set to False, the automatic type inference from capitalization will no longer be included. The CLI flag for the False value is --dont-order-by-type: https://timothycrosley.github.io/isort/docs/configuration/options/#dont-order-by-type.
Hope this is helpful!
~Timothy


Fix authentication of query page

When trying to get the information for the IQData and Metadata, an error was being thrown because the token was returning a bad request.
This was because an 'undefined' scope was being passed to it.
I have updated the code to pass the correct configuration in.

Waiting to merge till I verify the other modes work, like using files local to backend

Waiting to merge till I verify the other modes work, like using files local to backend

Okay no worries, I can't imagine it affecting anything because all it does it retrieve the token if the user is logged in.
But famous last words 😃


Add docker image creation date

The images the operator creates are created without a date:
$ docker inspect 69cdd648323b
[
...
        "RepoDigests": [
            "<IP_ADDRESS>/default/camel-k-kit-cogif7of9h2c73aouqu0@sha256:95a9182e20446cc6b8ea387365348bf7e9712a95bc59d848263e3b9e7d82366f"
        ],
...
        "Created": "1970-01-01T00:00:00Z",

This is not a strong requirement, but I think that, in order to have a better image management and a clear audit when the images where really created, we should add the real creation date.

Related to #3645 - if any development, we can bundle it together.

The 1970 date is intentional for reproducibility reasons. It may be investigated if setting the date may interfere with the container build cache.

The 1970 date is intentional for reproducibility reasons. It may be investigated if setting the date may interfere with the container build cache.

I think in our case we don't need to care of this kind of container reproducibility. I mean, we already reuse a container that present the same characteristics, so, whenever we build we'd always do it from scratch with a brand new container (which always changes the name and digest anyway). Layering caching should not be affected if we introduce this change.

We could add those information as a label but I would really recommend not to change this in particular given the fact that we are moving to the direction to delegate the build part to external entities as much as possible so we should reduce camel-k specific behavior.


[identity] MSALClient support for Azure Region

Port over support for azureRegion to MSALClient

Closing as this is not a supported scenario


Directory restructuring causes styles not to be generated

Describe the bug
I'm using vite + electron, so there are some adjustments to the directory structure. src/render is the vite directory, and I have added root: 'src/render' in the vite.config.ts. I found the style  not to be generated when I started the project (Only start vite)
Minimal Reproductions
This is an example
Versions

vite-plugin-windicss: ^1.2.4
vite: ^2.3.0
framework(vue/react/svelte/etc): vue^3.0.5

Additonal Context
In src/render/components/HelloWorld.vue I have added
{{ msg }}
. It works well when the directory structure is not adjusted

I tried to manually specify the directory in the configuration file, but it still can't work.
I also tried to add extract.include in vite-plugin-windicss , still not working.
// windi.config.ts

import { defineConfig } from 'windicss/helpers';

export default defineConfig({
    extract: {
        include: [
            'src/render/index.html',
            'src/render/**/*.{vue,html,ts,js,jsx,tsx}',
        ],
        exclude: [
            'node_modules/**/*',
            '.git/**/*',
        ],
    },
    darkMode: 'class',
});

When I add join(__dirname, 'src/render/index.html') in vite.config.js,  it works.
//vite.config.js
WindiCSS({
    preflight: {
        enableAll: true,
    },
    scan: {
        include: [
            join(__dirname, 'src/render/index.html'),
            join(__dirname, 'src/render/**/*.{vue,html,ts,js,jsx,tsx}'),
        ],
    }
}),


Route jump failed in a single sub-application

If the application is in this configuration, I jumped to testPage without responding.

If I add '/app2' to useValue, I can jump to testPage. But you can't jump to other sub-applications.

is there any update on this?

How are you jumping to test page? See related https://github.com/CanopyTax/single-spa-angular/issues/64. My hope is that #64 can be resolved by setting the APP_BASE_HREF to / and then doing <a routerLink="/app2/test">.
I do not have time to look at this deeply right now, but will hopefully have time in the next week or two.

Hi joeldenning,
Routing is working within app but when we are trying to move from one sub-app to other having route configuration then it is not working. It try to find the route with in the current app routing module.

See my other comment that is related to APP_BASE_HREF. I would recommend setting the base href to / instead of /.
I'm closing this because of inactivity, but feel free to reopen if there's more to discuss.


ERROR: When running PlottingUtils.plot_track() an 'index <index#> is out of bounds for axis <axis #>

When playing around in the loganalysis container with deep racer I was trying to create the heatmap.
I kept getting this error.
---------------------------------------------------------------------------
IndexError                                Traceback (most recent call last)
/tmp/ipykernel_11268/422798774.py in <module>
      3 # pu.plot_track(df, track)
      4 # pu.plot_track(df[:10000], track)
----> 5 pu.plot_track(df[1000:], track)
      6 # pu.plot_track(df[df['unique_episode'] == complete_ones['unique_episode']], track)
      7 # pu.plot_track(df, track)

/usr/local/lib/python3.7/site-packages/deepracer/logs/log_utils.py in plot_track(df, track, value_field, margin, cmap)
    705                 x = track_size[x_coord] - 1
    706
--> 707             track_img[y, x] = row[value_field]
    708
    709         fig = plt.figure(1, figsize=(12, 16))

IndexError: index -2320 is out of bounds for axis 1 with size 1000

I added my own print statement on line 706 of the 'log_utils.py' file to print out all the values again.
            if x >= track_size[x_coord]:
                x = track_size[x_coord] - 1
            print('X is', x, 'y is', y, 'row["x"]', row["x"] ,'x_compensation',x_compensation, 'y_compensation', y_compensation, 'margin', margin)
            track_img[y, x] = row[value_field]

        fig = plt.figure(1, figsize=(12, 16))
        ax = fig.add_subplot(111)

and it seems that the 'x' has one value that is wildly out of range. here is a short section of the print out. You can see that the x value increments slowly until the last moment when it jumps to -2320.
X is 214 y is 653 row["x"] -3.259742267097602 x_compensation -4.402667999267578 y_compensation -4.396105766296387 margin 1
X is 215 y is 638 row["x"] -3.246992642728024 x_compensation -4.402667999267578 y_compensation -4.396105766296387 margin 1
X is 215 y is 632 row["x"] -3.248504387802482 x_compensation -4.402667999267578 y_compensation -4.396105766296387 margin 1
X is 213 y is 616 row["x"] -3.266910068950707 x_compensation -4.402667999267578 y_compensation -4.396105766296387 margin 1
X is 213 y is 613 row["x"] -3.2721989091670225 x_compensation -4.402667999267578 y_compensation -4.396105766296387 margin 1
X is 209 y is 601 row["x"] -3.306889782500916 x_compensation -4.402667999267578 y_compensation -4.396105766296387 margin 1
X is 204 y is 588 row["x"] -3.361250827192417 x_compensation -4.402667999267578 y_compensation -4.396105766296387 margin 1
X is 198 y is 577 row["x"] -3.4224409800187376 x_compensation -4.402667999267578 y_compensation -4.396105766296387 margin 1
X is 192 y is 569 row["x"] -3.477698964346552 x_compensation -4.402667999267578 y_compensation -4.396105766296387 margin 1
X is -2320 y is 689 row["x"] -28.612064787546966 x_compensation -4.402667999267578 y_compensation -4.396105766296387 margin 1

I don't think that it is a bad calculation in the code but maybe a bad reading from the simulation or something. Nonetheless I think it needs to be handled.
In my case I just added the code in a try catch block which prints an error log but continues anyway as one lost data point for me is not such a big deal.
            if x >= track_size[x_coord]:
                x = track_size[x_coord] - 1
            try:
                track_img[y, x] = row[value_field]
            except Exception as ex:
                logging.error('An Error was thrown when tring to calulate a coordinate', ex)

        fig = plt.figure(1, figsize=(12, 16))

Would you be willing to push a PR for this change?

Ok I will make one with my changes soon. I'm Just not sure that my solution is the best solution, as it is basically masking a underlying problem rather than fixing it.
Anyways I will make the PR soon when I get time and I guess you can have a look and play and edit if needs be.

@anjrew - version 1.0.2 released; please check if works as desired.


Permission denied when downloading log file

This is autogenerated. Please review and update as needed.
Describe the bug
Command Name
az webapp log download
Errors:
[Errno 13] Permission denied: 'webapp_logs.zip'
Traceback (most recent call last):
Temp\pip-install-p8t_6awn\knack\knack\cli.py, ln 206, in invoke
azure\cli\core\commands\__init__.py, ln 603, in execute
azure\cli\core\commands\__init__.py, ln 661, in _run_jobs_serially
azure\cli\core\commands\__init__.py, ln 654, in _run_job
Local\Temp\pip-install-p8t_6awn\six\six.py, ln 693, in reraise
azure\cli\core\commands\__init__.py, ln 631, in _run_job
azure\cli\core\commands\__init__.py, ln 306, in __call__
azure-cli-core\azure\cli\core\__init__.py, ln 485, in default_command_handler
azure\cli\command_modules\appservice\custom.py, ln 1810, in download_historical_logs
azure\cli\command_modules\appservice\custom.py, ln 1841, in _get_log
PermissionError: [Errno 13] Permission denied: 'webapp_logs.zip'

To Reproduce:
Steps to reproduce the behavior. Note that argument values have been redacted, as they may contain sensitive information.

Put any pre-requisite steps here...
az webapp log download --id {} --debug

Expected Behavior
Environment Summary
Windows-10-10.0.18362-SP0
Python 3.6.6
Shell: cmd.exe

azure-cli 2.0.75 *

Additional Context

make the user has permissions to write to the folder since we try to zip the contents and save locally.


issue: typia + source-map-support + simple typescript project

Bug Report
Hi!
I've noticed that setting up typia with simple typescript project breaks proper work of source-map-support plugin.
Stack traces are broken.
Looks like it modifies source after source map is generated by tsc/ttsc (i've tried both ts-patch and ttsc).
Detals and reproducing
Simple environment I created to reproduce the issue together with README file
https://github.com/roman-shpp/typia-sourcemap-issue

No way yet. About this issue, I'm waiting for ts-patch v2 update:
https://github.com/nonara/ts-patch/issues/84

To exact source map tracing, only #509 can be answer at now.


Optionally Enforce SLA Remediation Days

This PR adds functionality to optionally enforce SLA remediation days for all severities.

Add BooleanFields to the SLA_Configuration model that specify if a given severity will enforce the specified SLA days (default=True, to match existing SLA Configuration functionality)
Add logic to the finding model's set_sla_expiration_date to set the finding sla_expiration_date to None if its severity is not enforce on the SLA_Configuration
Update templates displaying SLA configuration information to display Not Enforced for any non-enforced SLA days fields

Addition of new "Enforce (Severity) Finding SLA Days" fields:

Viewing all SLAs with Critical Finding SLA Days not enforced:

After disabling Critical Finding SLA Days enforcement, critical findings no longer have an SLA expiration date or SLA days remaining:

When viewing a Product, severities that do not enforce a given SLA remediation period will show Not Enforced:

[sc-3361]

@blakeaowens After updating from 2.34.5 to 2.35.4, I'm seeing this error...it looks like the migration never ran? Do you know how I can handle this error:
[19/Jul/2024 12:44:25] ERROR [django.request:241] Internal Server Error: /product/4278
Traceback (most recent call last):
  File "/usr/local/lib/python3.11/site-packages/django/db/backends/utils.py", line 89, in _execute
    return self.cursor.execute(sql, params)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
psycopg2.errors.UndefinedColumn: column dojo_sla_configuration.enforce_critical does not exist


v1.3 backports 2019-04-12

#7657 -- Don't use local remote in check-stable script (@nebril)

Once this PR is merged, you can update the PR labels via:
$ for pr in 7657; do contrib/backporting/set-labels.py $pr done 1.3; done

This change is

test-me-please

test-missed-k8s

test-docs-please


Pfe-band doesn't work correctly with Angular

Hi guys,
I am working with Patternfly Elements and I having some issues with Angular integration.
pfe-band doesn't work correctly with Angular

Impacted component(s)

pfe-band

Steps to reproduce
I created on Sandbox an Angular project with the pfe-band, you can find on this link:
https://codesandbox.io/s/pfe-band-patternfly-o8emc
Expected behavior
We should see the patternfly band.

Hi @grandemayta, thank you again for opening this issue.  There is already an issue that covers this so I'm going to link them and close this one out.  The sandbox you provided will be very helpful as we continue to upgrade this component.  Would you mind adding any additional information you want to share in this issue instead? https://github.com/patternfly/patternfly-elements/issues/587


Doesn't work with engines

Hi,
I have been a happy user of ember-get-config for a while now. I am now working on a new app based on engines, and in the process I found out that ember-get-config doesn't work there.
After looking into it, I found out it is because there are now multiple modules that match const CONFIG_REGEX = /^[^/]+\/config\/environment$/;, because the engines also have their own configs.
I ended up using an adaption of your code with a more specific regex (e.g. my-app/config/environment). I am not quite sure how this could be generalized , but it would be very neat to be able to do this.

Thanks for reporting this. Along with @BrianSipple, I've been exploring possible ways to grab the config in the index.js include hook. Since ember-get-config was working well enough, I wasn't taking those explorations very seriously, but this gives me reason to reconsider this approach.

@mydea This may be fixed with 0.1.0. Would you mind confirming?

It works fine now for me - thanks! (tested in 0.1.3)

Good to hear!


Kanban Board Setup

We are a group of three
Bruk
Gideon
Victor
We created the Kanban board for House Rental Application Project
Link to kanbanboard

Here is our kanban board sceenshoot

Hi @efoosag
While you made a great effort in this project, unfortunately, I cannot proceed to review your code.
Invalid Code Review Request
You have submitted a project, that contains a link to kanban board that does not work.

Your Code Review Request will be marked as invalid in your Dashboard, so please submit a new one once you are ready 🙏
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.

Invalid Code Review Request does not count into the code reviews limit.

Hi @efoosag,,
Wow, you did it 🎉

Thank you for implementing the changes requested by the previous reviewer 💪 🥇 ㊗
Well done!
To highlight
Optional suggestions
Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will really improve your application.
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.

As described in the Code reviews limits policy  you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.


Compiling on Windows

Compiling on windows doesn't work.. Attempting to fix that.
Added language annotations to code-blocks.

I think this package by dirkschumacher should be used for inspiration
atleast: https://github.com/dirkschumacher/blake3
I had hoped that dirk had managed to put it on CRAN, but that does not seem
to be the case.
Claus Wilke halso have a package that uses rust, but isn't on CRAN either;
see https://clauswilke.com/sinab/#installation
We'll see how all of this turns out...
On Sun, 23 Aug 2020 at 16:08, Andy Thomson<EMAIL_ADDRESS>wrote:

Good luck. Building on windows is definitely a challenge, it seems. We
will also need a way to install Rust in the CRAN package.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/extendr/extendr/pull/10#issuecomment-678778901, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AAIDVSEH7D3Y62K4RHY3EL3SCEPELANCNFSM4QF3DUTA
.

Those do look promising. There is an AppVeyor script in Dirk's package.
I know quite a few people (mostly at pharmas) who use R on windows, so this is quite important.

It is also incredibly important to me.
I just have to wait for the weekend as I have a tremendous amount of rust
code to write for a paper.
Do we have a discord or similar to just share these small tidbits?
On Mon, 31 Aug 2020 at 18:59, Andy Thomson<EMAIL_ADDRESS>wrote:

Those do look promising. There is an AppVeyor script in Dirk's package.
I know quite a few people (mostly at pharmas) who use R on windows, so
this is quite important.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/extendr/extendr/pull/10#issuecomment-683904767, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AAIDVSAJ46KSZHXVAHR2ERDSDPJI3ANCNFSM4QF3DUTA
.

Discord channel now open:
https://discord.gg/gNegZu
On Wed, Sep 2, 2020 at 11:55 AM CGMossa<EMAIL_ADDRESS>wrote:

It is also incredibly important to me.
I just have to wait for the weekend as I have a tremendous amount of rust
code to write for a paper.
Do we have a discord or similar to just share these small tidbits?
On Mon, 31 Aug 2020 at 18:59, Andy Thomson<EMAIL_ADDRESS>wrote:

Those do look promising. There is an AppVeyor script in Dirk's package.
I know quite a few people (mostly at pharmas) who use R on windows, so
this is quite important.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/extendr/extendr/pull/10#issuecomment-683904767, or
unsubscribe
<
https://github.com/notifications/unsubscribe-auth/AAIDVSAJ46KSZHXVAHR2ERDSDPJI3ANCNFSM4QF3DUTA
.

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/extendr/extendr/pull/10#issuecomment-685615950, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AAL36XHZGRBEV3MIJI34GQDSDYQDHANCNFSM4QF3DUTA
.

Hello, I only just saw this project and this issue/PR. Not sure what the status is, but I'm very excited about any additional effort bringing R and Rust together. Further development of my sinab package depends on this, and I'd rather not have to do everything by myself.
To compile on Windows, the installation instructions that come with sinab have worked for a number of people:
https://clauswilke.com/sinab/
I also have a working appveyor setup: https://github.com/clauswilke/sinab/blob/master/appveyor.yml
You need an appropriate Makevars.win file in your R package: https://github.com/clauswilke/sinab/blob/master/src/Makevars.win
To get a package containing Rust onto CRAN, you need to precompile the Windows library and download on the fly as you build the package on Windows on CRAN. See the discussion here and see an example here:
https://github.com/cran/gifski/blob/master/src/Makevars.win
https://github.com/cran/gifski/blob/master/tools/winlibs.R
Note: The gifski package is entirely written in Rust and it's available on CRAN, so this is definitely possible: https://cran.r-project.org/web/packages/gifski/index.html

Hi @clauswilke I was hoping to avoid the two-stage gifski approach of building a
static library and linking to a DLL by using a Makefile directly, reducing the file count in
examples. Ultimately we should only need a single rust file in addition to the R
package skeleton. But for convenience we may need to do it. The current file count is 11
files.
I don't currently have a windows or mac machine to try a windows build
and hence this has stalled.
I am working (rather slowly at the moment) on a Rust package skeleton generator
that will do this and would appreciate some help.
If anyone can contribute a simple example (less than 20 files) of a windows build on Appveyor,
it would be useful and act as a starting point. Likewise for the Mac.

Keep in mind though that the two-stage approach is only needed for CRAN submission, because their servers currently lack the cargo toolchain. Otherwise installation from source is pretty straightforward.
A minimal example with a working appveyor build is available here: https://github.com/r-rust/hellorust
One other issue I realized is that there are two distinct compilation scenarios and we need to be clear which one we're talking about: 1. Build an R package that calls Rust code. 2. Build a standalone Rust binary that calls R code. The second scenario is substantially more complex than the first. I'm only talking about the first at this time.

@CGMossa I'm closing this PR since things now compile on Windows (as far as I understand). If you want to merge the changes to the README, I suggest you make a new PR with a corresponding title. There's other fixes the README needs (e.g., somewhere code and regular text blocks get switched), so such a PR would make a lot of sense.


Error unexpected keyword argument 'request' when visit your-orders page

Error If user is not authntificate and tries visit page http://localhost:8000/info/your-orders/ :
Traceback (most recent call last):
  File "/home/vivazzi/.virtualenvs/django-shop-2/local/lib/python2.7/site-packages/django/core/handlers/exception.py", line 42, in inner
    response = get_response(request)
  File "/home/vivazzi/.virtualenvs/django-shop-2/local/lib/python2.7/site-packages/django/core/handlers/base.py", line 249, in _legacy_get_response
    response = self._get_response(request)
  File "/home/vivazzi/.virtualenvs/django-shop-2/local/lib/python2.7/site-packages/django/core/handlers/base.py", line 217, in _get_response
    response = self.process_exception_by_middleware(e, request)
  File "/home/vivazzi/.virtualenvs/django-shop-2/local/lib/python2.7/site-packages/django/core/handlers/base.py", line 215, in _get_response
    response = response.render()
  File "/home/vivazzi/.virtualenvs/django-shop-2/local/lib/python2.7/site-packages/django/template/response.py", line 109, in render
    self.content = self.rendered_content
  File "/home/vivazzi/.virtualenvs/django-shop-2/local/lib/python2.7/site-packages/rest_framework/response.py", line 72, in rendered_content
    ret = renderer.render(self.data, accepted_media_type, context)
  File "/home/vivazzi/projects/OTHERS/django-shop-2/django-shop/shop/rest/renderers.py", line 35, in render
    return template.render(template_context, request=request)
TypeError: render() got an unexpected keyword argument 'request'

do you use version 0.10.1?

I check version 0.10.rc4
I can check version 0.10.1

Excuse me, I miss this fix. For version 0.10.1 it work without bug. I close this issue


chore(mixed): renamed unsafe lifecycle methods

Executed via npx react-codemod rename-unsafe-lifecycles --parser babel
Disabled lint issues for updated lines.
The changes should mitigate the "Unsafe lifecycle" warnings.
Closes #3741
Related to #2732

Codecov Report

Merging #3747 into master will not change coverage.
The diff coverage is 100%.

@@           Coverage Diff           @@
##           master    #3747   +/-   ##
=======================================
  Coverage   99.84%   99.84%
=======================================
  Files         175      175
  Lines        3125     3125
=======================================
  Hits         3120     3120
  Misses          5        5

Impacted Files
Coverage Δ

src/modules/Sticky/Sticky.js
99.09% <ø> (ø)
:arrow_up:

src/modules/Transition/TransitionGroup.js
100% <ø> (ø)
:arrow_up:

src/behaviors/Visibility/Visibility.js
100% <ø> (ø)
:arrow_up:

...ddons/TransitionablePortal/TransitionablePortal.js
100% <ø> (ø)
:arrow_up:

src/modules/Transition/Transition.js
100% <ø> (ø)
:arrow_up:

src/modules/Search/Search.js
99.54% <100%> (ø)
:arrow_up:

src/modules/Dropdown/Dropdown.js
100% <100%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9bcc76a...5bb3e90. Read the comment docs.

Additional info: only the src folder has been affected by this change.
Also, most of the files were skipped (asuming they did not need a change).

@jmyrland thank you for taking this ❤
I updated PR with react package bump to ensure that we don't have any issues, but CI failed on two tests. Trying to understand why 🤔

Nice @layershifter 👍 Kudos for all the effort in making condributions "newb-friendly" 😁 Really easy to get up and running with the project & ready to contribute 👌
As for the failing tests - I'm not sure whats causing this, but I see you "fixed" it by disabling some of the tests.
Let me know if you need anything else from my end 👍

Nice @layershifter 👍 Kudos for all the effort in making condributions "newb-friendly" 😁 Really easy to get up and running with the project & ready to contribute 👌

😍

As for the failing tests - I'm not sure whats causing this, but I see you "fixed" it by disabling some of the tests.

Yea, I don't have any idea why they fails