Format on Save not triggering

Hi! Appreciate you putting this plugin together. Manual formatting/linting works perfectly, but I can't seem to get format on save working.
Config
This is all within ST 4180
I have biome installed as a dev dependency:
 "@biomejs/biome": "1.8.3",

I have a biome.json config in my project root that looks like this:
{
	"$schema": "https://biomejs.dev/schemas/1.8.3/schema.json",
	"organizeImports": {
		"enabled": true
	},
	"linter": {
		"enabled": true,
		"rules": {
			"recommended": true
		}
	},
	"formatter": {
		"enabled": true
	}
}

I've stripped down my LSP.sublime-settings to this, and have disabled all other LSP servers:
{
	"lsp_format_on_save": true,
	"lsp_code_actions_on_save": {
		"source.organizeImports.biome": true,
		"quickfix.biome": true,
	},
}

Issue
Unfortunately, even with all of the above I'm not getting formatting on save.  I do see LSP-Biome (1.8.3) in the status bar on TypeScript files, so it's definitely running. And if I manually call LSP: Format File then Biome does format the code. But when I save, all I'm getting in the LSP log is this single line:
 -> LSP-biome textDocument/didSave: {'textDocument': {'uri': 'file:///Users/{user}/code/biome-test/foo.ts'}}

Any thoughts on what could be going on?

Configuration error on my end. Completely forgot that I'd created a syntax config for Typescript ages ago. That was interfering with Biome. Closing.


Bagpipes m1 delivery

Grant link:
https://github.com/OAK-Foundation/Grants-Program/blob/main/applications/bagpipes_integration.md
Milestone nr: m1
Project name:
Bagpipes
Extra documentation:
https://docs.bagpipes.io/docs/xtransfer/turing

Issue #1 - The Wallet Selection page doesn’t close and block the rest of page after Sign-in with Polkadot.js wallet.

I figured that by clicking on the left navbar button it can go to another page, but the process is not really intuitive.

Question - for the Turing -> Moonriver workflow I will need to load Ethereum wallet address, but how does the page load Talisman?
The Talisman is connected for the page but I got the below screenshot. What does "Add example metadata" mean? Clicking on it results in "Failed to add metadata" error.

I’m blocked by this step to choose a correct target wallet on Moonriver. The Moonriver EVM address cannot be converted from Polkadot address, so an xToken transfer always needs manual selection of target wallet.

In Turing to Mangata scenario, after I approve the workflow how to sign the transaction? Only polkadot.js is connected and there is no prompt for signature from the Chrome plugin.

Question - I do not understand the setting of the target amount function. For example, I am sending 100 TUR from Turing to Managata for 50 TUR. This scenario doesn’t really make sense, since if the token is the same they should be 1:1 mapped. Besides, since the unit per second is set in chain configs, for xToken transfer, there’s no way for users to specify the target amount to whatever they want.

That said, the composed XCM message is different from the UI, in a sense that it doesn’t contain a targeted amount.
I’m curious, is there any pallet call that would allow user to set target amount?

In very rare cases, that chain A’s asset to be transferred into chain B’s other asset via XCM. Is there a feature already to whitelist target assets and grey out those unavailable?
For example, in Turing -> Mangata case, only TUR is available, and if you could combined the XCM transfer with swap, KSM, TUR, MGX would be available too.

Is "Lab" for transaction or scenario histories? So far the name Lab sounds obscure to me.

Also a nitpick - since Contracts and Settings pages are blank, I think we should either add a few line to explain the planned features, or not show them on the left nav bar.

Question - I do not understand the setting of the target amount function. For example, I am sending 100 TUR from Turing to Managata for 50 TUR. This scenario doesn’t really make sense, since if the token is the same they should be 1:1 mapped. Besides, since the unit per second is set in chain configs, for xToken transfer, there’s no way for users to specify the target amount to whatever they want.
That said, the composed XCM message is different from the UI, in a sense that it doesn’t contain a targeted amount.
I’m curious, is there any pallet call that would allow user to set target amount?

This is due to multiple hops, you will always see the sending amount in the action bar,  for example if you have a multi hop scenario like this:

The action node in the middle displays the action, you only need to set the amount in the chain node your sending from

I’m blocked by this step to choose a correct target wallet on Moonriver. The Moonriver EVM address cannot be converted from Polkadot address, so an xToken transfer always needs manual selection of target wallet.

We have investigated this and we have added support for converting substrate accountid32 to evm addresses, however this is not universially stable, therefor we recommend to follow the video and manually select ur evm address(The problem is that the acocunt key generation for evm accounts/accountid20 types is not always working, so only some wallets lets you export your private key and convert it to a eth address, resulting in it being very hard for most polkadot account users to convert there ss58 seed to an eth address, resulting in problems accessing funds, this is the most stable way right now, we might add a filter moonriver nodes).
Resources:
https://github.com/polkadot-js/common/blob/f23f0944a85a6ddff72a8cd5866e85fd88edea39/packages/util-crypto/src/address/addressToEvm.ts#L9
unique is converting using the above functionality: https://github.com/UniqueNetwork/ts_api/blob/0d44ee0fdabd72a7c2225f32ab483a4eb8af4b05/src/utils/address/substrate.ts#L156C1-L157C1
astar mentions this: https://medium.com/astar-network/using-astar-network-account-between-substrate-and-evm-656643df22a0

In very rare cases, that chain A’s asset to be transferred into chain B’s other asset via XCM. Is there a feature already to whitelist target assets and grey out those unavailable?
For example, in Turing -> Mangata case, only TUR is available, and if you could combined the XCM transfer with swap, KSM, TUR, MGX would be available too.

hey chris,

Is "Lab" for transaction or scenario histories? So far the name Lab sounds obscure to me.

Also a nitpick - since Contracts and Settings pages are blank, I think we should either add a few line to explain the planned features, or not show them on the left nav bar.

hey chris, yes we can hide contacts and settings until they are ready.
Do you prefer Scenarios than Lab? that is a fair point. Scenarios is more obvious.

Issue - In Turing to Mangata scenario, after I approve the workflow how to sign the transaction? Only polkadot.js is connected and there is no prompt for signature from the Chrome plugin.

there should be a red notification in the polkadot js plugin, like below, do you have that? if so just click it and then the extension should pop up.

btw, thanks for the feedback!
We are also working on the next larger release of bagpipes UI, which will include a new look similar to the UI mockups you received; and the ability for users to persist scenarios, which is going to be a game changer; also the ability to use logic pills to make condition based data flows... so a bunch of stuff will also be improved the OAK integrations will naturally benefit from those releases too.

@chrisli30 Video turing 2 moonriver:
https://drive.google.com/file/d/1-dr8exA8TqwbuhJlqnkFnS-RkBGOm8YN/view?usp=sharing
Moonriver > Turing Video demo:
https://drive.google.com/file/d/1Jrl5DQzu_2t4iuBKVu_hyQqzdJ8HeL9B/view?usp=sharing

@chrisli30 /lab section docs: https://docs.bagpipes.io/docs/intro/concepts#scenario can we make these docs clearer?

Regarding the changes @chrisli30 and @flipchan:

Builder button is added to the Wallets area to send the user, (and dummy data removed)

"Scenarios" replaced "Lab" for ease of understanding.

Contacts and Settings hidden until ready.

These are temporary minor changes in the current release, and will be much better in next major release.

Question - I do not understand the setting of the target amount function. For example, I am sending 100 TUR from Turing to Managata for 50 TUR. This scenario doesn’t really make sense, since if the token is the same they should be 1:1 mapped. Besides, since the unit per second is set in chain configs, for xToken transfer, there’s no way for users to specify the target amount to whatever they want.
That said, the composed XCM message is different from the UI, in a sense that it doesn’t contain a targeted amount.
I’m curious, is there any pallet call that would allow user to set target amount?

This is due to multiple hops, you will always see the sending amount in the action bar, for example if you have a multi hop scenario like this:
The action node in the middle displays the action, you only need to set the amount in the chain node your sending from

@chrisli30 in the next version if the target node is the last node in the flow then the amount will be hidden.

I’m blocked by this step to choose a correct target wallet on Moonriver. The Moonriver EVM address cannot be converted from Polkadot address, so an xToken transfer always needs manual selection of target wallet.

We have investigated this and we have added support for converting substrate accountid32 to evm addresses, however this is not universially stable, therefor we recommend to follow the video and manually select ur evm address(The problem is that the acocunt key generation for evm accounts/accountid20 types is not always working, so only some wallets lets you export your private key and convert it to a eth address, resulting in it being very hard for most polkadot account users to convert there ss58 seed to an eth address, resulting in problems accessing funds, this is the most stable way right now, we might add a filter moonriver nodes). Resources: https://github.com/polkadot-js/common/blob/f23f0944a85a6ddff72a8cd5866e85fd88edea39/packages/util-crypto/src/address/addressToEvm.ts#L9 unique is converting using the above functionality: https://github.com/UniqueNetwork/ts_api/blob/0d44ee0fdabd72a7c2225f32ab483a4eb8af4b05/src/utils/address/substrate.ts#L156C1-L157C1 astar mentions this: https://medium.com/astar-network/using-astar-network-account-between-substrate-and-evm-656643df22a0 same conversion in bagpipes: https://github.com/XcmSend/app/blob/1062a0f9e911f9930c2d9c18358d0a6528f9f484/src/Chains/Helpers/txHelper.ts#L19

@flipchan yes, we are on the same page. For Moonbeam, there is no way to auto-convert from a Substrate address to EVM one due to different key generations, so UI always needs to handle reading two wallets. Astar allows address conversion.
Let me re-test the flows and see if I could successfully make the transfer.

btw, thanks for the feedback!
We are also working on the next larger release of bagpipes UI, which will include a new look similar to the UI mockups you received; and the ability for users to persist scenarios, which is going to be a game changer; also the ability to use logic pills to make condition based data flows... so a bunch of stuff will also be improved the OAK integrations will naturally benefit from those releases too.

I believe the persist scenarios, or scenario history would be very helpful to users, as they can see and re-use the ones from the past. Will this change be included in M1, or will any future UI changes affect the page?

The M1 documentation mentions an HRMP channel check, but the chain selection of the target list doesn’t filter chains that are connected to the source. In our case, we should hide any chains that are not connected to Turing Network. Users wouldn’t have any idea what are available and what not.

I’m blocked by this step to choose a correct target wallet on Moonriver. The Moonriver EVM address cannot be converted from Polkadot address, so an xToken transfer always needs manual selection of target wallet.

We have investigated this and we have added support for converting substrate accountid32 to evm addresses, however this is not universially stable, therefor we recommend to follow the video and manually select ur evm address(The problem is that the acocunt key generation for evm accounts/accountid20 types is not always working, so only some wallets lets you export your private key and convert it to a eth address, resulting in it being very hard for most polkadot account users to convert there ss58 seed to an eth address, resulting in problems accessing funds, this is the most stable way right now, we might add a filter moonriver nodes). Resources: https://github.com/polkadot-js/common/blob/f23f0944a85a6ddff72a8cd5866e85fd88edea39/packages/util-crypto/src/address/addressToEvm.ts#L9 unique is converting using the above functionality: https://github.com/UniqueNetwork/ts_api/blob/0d44ee0fdabd72a7c2225f32ab483a4eb8af4b05/src/utils/address/substrate.ts#L156C1-L157C1 astar mentions this: https://medium.com/astar-network/using-astar-network-account-between-substrate-and-evm-656643df22a0 same conversion in bagpipes: https://github.com/XcmSend/app/blob/1062a0f9e911f9930c2d9c18358d0a6528f9f484/src/Chains/Helpers/txHelper.ts#L19

@flipchan yes, we are on the same page. For Moonbeam, there is no way to auto-convert from a Substrate address to EVM one due to different key generations, so UI always needs to handle reading two wallets. Astar allows address conversion.
Let me re-test the flows and see if I could successfully make the transfer.

I’m blocked by this step to choose a correct target wallet on Moonriver. The Moonriver EVM address cannot be converted from Polkadot address, so an xToken transfer always needs manual selection of target wallet.

We have investigated this and we have added support for converting substrate accountid32 to evm addresses, however this is not universially stable, therefor we recommend to follow the video and manually select ur evm address(The problem is that the acocunt key generation for evm accounts/accountid20 types is not always working, so only some wallets lets you export your private key and convert it to a eth address, resulting in it being very hard for most polkadot account users to convert there ss58 seed to an eth address, resulting in problems accessing funds, this is the most stable way right now, we might add a filter moonriver nodes). Resources: https://github.com/polkadot-js/common/blob/f23f0944a85a6ddff72a8cd5866e85fd88edea39/packages/util-crypto/src/address/addressToEvm.ts#L9 unique is converting using the above functionality: https://github.com/UniqueNetwork/ts_api/blob/0d44ee0fdabd72a7c2225f32ab483a4eb8af4b05/src/utils/address/substrate.ts#L156C1-L157C1 astar mentions this: https://medium.com/astar-network/using-astar-network-account-between-substrate-and-evm-656643df22a0 same conversion in bagpipes: https://github.com/XcmSend/app/blob/1062a0f9e911f9930c2d9c18358d0a6528f9f484/src/Chains/Helpers/txHelper.ts#L19

@flipchan yes, we are on the same page. For Moonbeam, there is no way to auto-convert from a Substrate address to EVM one due to different key generations, so UI always needs to handle reading two wallets. Astar allows address conversion.
Let me re-test the flows and see if I could successfully make the transfer.

Alright, I managed to execute the xTransfer. The issue lies within Talisman, which failed to prompt for wallet selection. Therefore, I couldn't select my EVM wallet address on the Moonriver chain. The XCM message works fine for xToken transferMutiasset.

UI Issue: The 'from' and 'to' chains in the middle operator remain unchanged when different chains are selected.

You need to click fetch button again to refresh the workflow.
We won’t automate this until next release this is outside the scope of this milestone.

persist scenarios

persist scenarios are out of scope for this milestone but we are working hard to get that feature alive, as we are testing and improving Bagpipes persistence execution environment(github.com/xcmsend/threadbag) Threadbag.

@chrisli30 i have made the sending to moonriver more safe where it checks if the user has select an evm wallet so that users do not send to regular substrate accounts and burn there funds, left a video here:
https://drive.google.com/file/d/18-Qk6s6_9QpNwYn980hdPei7e_UNAX0y/view

Nice job on the M1 delivery! Funds have been sent: https://etherscan.io/tx/0x82cd2ea6d03881acdfcdc1877f9275c791f45b8527fce92f103051aa0b3dd3f4
Keep up the fantastic work, team! 👏


GridSample appears to sample on a line

It looks like GridSample is generating points in a line. I would expect the points to form a grid.
> using QuasiMonteCarlo
> QuasiMonteCarlo.sample(5, [-6.0, -6.0], [6.0, 6.0], GridSample())
2×5 Matrix{Float64}:
 -4.8  -2.4  0.0  2.4  4.8
 -4.8  -2.4  0.0  2.4  4.8

Solved and tested better in https://github.com/SciML/QuasiMonteCarlo.jl/pull/94. It was somewhat ill-defined what it's behavior truly was, so that was clarified as well:

A simple rectangular grid lattice. Samples n random samples from a grid with `dx = (ub -lb)/n``


Function OneRiskFunctionPerCell

Hello everybody, I have tried to implement XLRisk for a project and it's fastastic. The only downside is that I'm not allowed to use the IFS function that basically use a specific prob. function depending on the the type of distribution I choose.
I know that its not a big of a deal writing directly the risk function in the cell but i need to make it as easier  and "automated" as possible.
I tried to add a new function in the macro library  with the help of chat gpt since i'm not used to write in VBA...this strategy was not a success i must say.
Is there a way to avoid this issue?

XLRisk only allows one risk function per cell.   However, you can achieve the desired result, similar to IF and IFS, by using multiple cells, e.g.
A1: =RiskNormal(100, 20)
A2: =RiskTriang(80,100,120)
A3: =If(condition, A1, A2)

Thank you for the suggestion. I've tried to implement this but the error still pops up.

thank you for the suggestion, I implemented it but the last limitation is that the function gives an errror when calculating, in this case the function RiskTriang but the inputs are just to use RiskUniform.

The error comes from the function "Public Function SortedTable", specifically in the line ColVals(I) = Abs(Table.Cells(I, Col).Value)
because, as I imagine, it has to collect from the selected cell a value that is a positive number, not a text or a negative number.
Is there a way to modify this function?
Thank you again for your support.

Can you post your model here, so that I have a look?

feedback_GitHub.xlsx

There are no XLRisk functions in this worksheet.  And cell S1 has an error value.   No idea what you are trying to do.

Can you post instead a minimal excel model that demonstrates the issue you are facing?

I'm sorry the functions got removed when I created the copy. I managed to solve the problem. Thank you again for your time and help!


Create directory for image infomation files?

Can I create a folder like "jsons" or "info" and export image information files to there?
i'd like to change to different location from image directory.

set the filenameinfoformat or filenameSeriesJSON with \ as the path separator, e.g. info\%member_id% %member_token%\%R-18% %urlFilename% - %title% in the config.ini

Thank you, it worked!


CLI does not work for IKS

CLI does not correctly create client for IKS (IBM Kubernetes Service) and perhaps others.
$ iter8 k get
panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0xa0 pc=0x5740e41]

goroutine 1 [running]:
k8s.io/client-go/kubernetes.(*Clientset).CoreV1(...)
        /Users/kalantar@us.ibm.com/projects/go.workspace/pkg/mod/k8s.io/client-go@v0.22.4/kubernetes/clientset.go:265

It is necessary to import the needed authentication libraries:
_ "k8s.io/client-go/plugin/pkg/client/auth"


Move as many parameters as possible to Manifest Level

Description of the new feature/enhancement
Currently the installer type, scope, upgrade behavior, etc. are always placed at the Installer Level. When these values are the same for all installers, they can be moved to the Manifest Level
Proposed technical implementation details (optional)
Any parameters which are the same across all installers and are valid at both the manifest level and the installer level should be moved to the manifest level during creation or update

I wonder if this should be enforced in a hypothetical schema 2.0. There aren't a ton of circumstances where putting InstallerType or others globally doesn't just turn into a headache later when you want to add a new installer entry.

I wonder if this should be enforced in a hypothetical schema 2.0. There aren't a ton of circumstances where putting InstallerType or others globally doesn't just turn into a headache later when you want to add a new installer entry.

I think that is an interesting point. I think this is mostly a concern when you manually modify the installer entries for new manifests. If you use a tool or a script like the YamlCreate script, then it should handle it automatically. It certainly is something to consider as to whether or not this would be a good thing

We've had some discussions around this with the feature team. Some of the optimizations like the singleton format and "root" level nodes that can be overridden in a child node were mostly made for humans crafting manifests. As we're getting closer to solid tooling support, these may be deprecated in favor of a tool generated manifest. It would certainly be a breaking change so the 2.0 schema was a good call out by @jedieaston.

Resolved in #409

The fix (PR #409) is available now in WinGet-Create <IP_ADDRESS>
cc @denelon / @Trenly if this can be marked as completed


Add readonly attribute to text editor element

This PR allows for the use of a readonly attribute which disables the input for text editor elements:
<atom-text-editor readonly />
The read-only state is stored on the TextEditor model. As of now this state merely prevents text from being input into the editor. Future considerations include using the state to determine modified status, preventing saving, etc.
/cc @maxbrunsfeld @damieng for 💭s

I might have missed some discussion here - why does saving the buffer clear the readonly status?

I might have missed some discussion here - why does saving the buffer clear the readonly status?
Other than that question, this looks great to me.

I want to ask this too.
I'm maintainor of vim-mode-plus.
In vim-mode-plus,

normal-mode is achieved by calling this.editor.element.component.setInputEnabled(false).

So editor.component.isInputEnalbed() return false
But once I save buffer by cmd-s, editor.component.isInputEnalbed() return true

This fundamental editor.component's capability( input enabled or not ) should be not affected by irrelevant action like cmd-s.

One of our scenarios for use of a read-only text editor is when we want to show you and editor but you can't edit the content because of where the text comes from - e.g. source that lives on a https:// url or inside a .jar file.  If however they chose to save that content to disk then by the very nature it is now editable as it lives somewhere the content can be changed.

Sorry, I was really nervous for now, I know I should not write any comment with such mental state.
I won't respond for a while.

No code is perfect :)   We did consider whether saving should clear the flag or not after @maxbrunsfeld also brought it up.  If it causes you difficulty we can remove that.

We should remove it. We need to not break vim-mode-plus, and they are orthogonal concepts anyway.
Same thing with isModified. We can address the issue of opening files from .jars in another way that doesn’t bake assumptions into core.

Removed the isModified/clear-on-save code ca53cf9ec1aed43edc05681029a23d379791586c

I need is-focused breaking recerted  too.
This is direct breaking where style based in is-focused scope.
Readonly state and focus state is completely irrelevant.
Should not be coupled and should not break existing style just becausr of one single new feature.

Basically want revert whole this PR and rethink to achieve it without breaking existing setInputEnabled capability.
I’m not insisting to not break existing feature ib every case of new enhancements, but I say should not break existing feature this time, since readonly feature should not be coupled/blended to these feature.
This is very fundamental feature vim-mode-plus depends on.
And original vim-mode was created by GitHub.
Please communicate each other if your team conside vmp as part of Atom’s goodness(I want say so).

Yes we're investigating and seeing what we can do. We've been able to
reverse out party of this but some of what remains it's needed elsewhere.
One of our team who worked on this is traveling and we needed some more
time to consider our options.
On Wed, Dec 13, 2017, 9:41 PM t9md<EMAIL_ADDRESS>wrote:

@t9md commented on this pull request.
In src/text-editor.js
https://github.com/atom/atom/pull/16294#discussion_r156858525:

@@ -400,6 +401,16 @@ class TextEditor {
}
break

   case 'readOnly':

     if (value !== this.readOnly) {

       this.readOnly = value

       if (this.component != null) {

         this.component.scheduleUpdate()

       }

       this.buffer.emitModifiedStatusChanged(this.isModified())

I noticed this part is reverted in ca53cf9
https://github.com/atom/atom/commit/ca53cf9ec1aed43edc05681029a23d379791586c.
sorry.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/atom/atom/pull/16294#discussion_r156858525, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAHQp2AZnTN4Hqoy9TW6jApydMNsJgqtks5tALTtgaJpZM4QucSS
.

@damieng

it's needed elsewhere.

I want to know where.

@damieng @maxbrunsfeld
Confirmed with current master that I can maintain vmp if is-focused meaning is reverted to original.
diff --git a/src/text-editor-component.js b/src/text-editor-component.js
index 08af5ada1..263556ee0 100644
--- a/src/text-editor-component.js
+++ b/src/text-editor-component.js
@@ -823,7 +823,7 @@ class TextEditorComponent {

     const oldClassList = this.classList
     const newClassList = ['editor']
-    if (this.focused && this.isInputEnabled()) newClassList.push('is-focused')
+    if (this.focused) newClassList.push('is-focused')
     if (model.isMini()) newClassList.push('mini')
     for (var i = 0; i < model.selections.length; i++) {
       if (!model.selections[i].isEmpty()) {

I think this request is reasonable, in vmp's normal-mode, it's readonly as long as it's focused.
The is-focused and readonly states should not be mutually exclusive.

@t9md the change has been reverted in 853b9a4e24502af82efaba289f7e0e3fcdf0bc19. We'll get beta hotfixed later today.

@kuychaco Thank you for hearing.


Show all trains from station on click

Click on any terminal station and see all the trains that start or end at that station

Closed 3eaf9e4


remove feature gates

[ ] I added an entry to CHANGELOG.md if knowledge of this change could be valuable to users.

Here is a brief summary of what I did:

 Update Backend

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 1 (0.0%)  changed or added relevant line in 1 file are covered.
33 unchanged lines in 10 files lost coverage.
Overall coverage increased (+0.01%) to 89.801%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

services/src/pro/server.rs
0
1
0.0%

Files with Coverage Reduction
New Missed Lines
%

datatypes/src/raster/data_type.rs
1
23.14%

services/src/datasets/external/aruna/mock_grpc_server.rs
1
89.02%

services/src/error.rs
1
30.19%

services/src/handlers/projects.rs
1
99.1%

services/src/handlers/wcs.rs
1
88.45%

services/src/layers/layer.rs
1
66.35%

services/src/pro/users/postgres_userdb.rs
1
99.03%

services/src/util/config.rs
1
80.62%

services/src/datasets/add_from_directory.rs
2
0%

services/src/util/parsing.rs
23
82.59%

Totals

Change from base Build<PHONE_NUMBER>:
0.01%

Covered Lines:
105610

Relevant Lines:
117604

💛  - Coveralls


WMS layer symbols all black dots

Attempted in beta3 Editor:
Created a new site, added all WMS layers with 'franco' n their name + workbc centres.
Noticed that all layers have a black dot as their symbol, not the colorful symbols as expected.


integration docs

Proposed changes
Pushwoosh integration docs
Merge timing

ASAP once approved

I created #5407 to deploy these docs.


Rate limit reached

i am receiving this error when trying to run with modal:
openai.error.RateLimitError: Rate limit reached for default-gpt-3.5-turbo in organization org-o8pnXYMZiNBFvGP0dQH0exyg on requests per min. Limit: 3 / min. Please try again in 20s.

I am getting a similar error

I reached this error as well, but using GPT4 with 4000 tokens/min rate limit reached

I got the same issue, fixed it by minor code adjustment
+import time

-           for filename, filecode in generate_file.map(
-                list_actual, order_outputs=False, kwargs=dict(filepaths_string=filepaths_string, shared_dependencies=shared_dependencies, prompt=prompt)
-            ):
-                write_file(filename, filecode, directory)

+            for actual in list_actual:
+              filename, filecode = generate_file(actual, filepaths_string=filepaths_string, shared_dependencies=shared_dependencies, prompt=prompt)
+              write_file(filename, filecode, directory)
+              time.sleep(30)  # wait for 30 seconds

so it just wait 30 seconds between API calls

Got the issue as well. Would be good with some config parameter as a measure against this.

+import time

      for filename, filecode in generate_file.map(

           list_actual, order_outputs=False, kwargs=dict(filepaths_string=filepaths_string, shared_dependencies=shared_dependencies, prompt=prompt)

       ):

           write_file(filename, filecode, directory)

       for actual in list_actual:

         filename, filecode = generate_file(actual, filepaths_string=filepaths_string, shared_dependencies=shared_dependencies, prompt=prompt)

         write_file(filename, filecode, directory)

         time.sleep(30)  # wait for 30 seconds

Where exactly did you put this?

line 175 in main.py

Awesome I can confirm that adding this delay made the rate limit error disappear.  I am using gpt4

thanks guys, i will try to solve this rate limit issue at the library level


Automated cherry pick of #9104: fix(notify): return the result of the second attempt to execute the rpc call

Cherry pick of #9104 on release/3.4.
#9104: fix(notify): return the result of the second attempt to execute the rpc call

Codecov Report

Merging #9107 (90bd0cd) into release/3.4 (fc16c37) will decrease coverage by 2.61%.
The diff coverage is 1.80%.

@@              Coverage Diff               @@
##           release/3.4   #9107      +/-   ##
==============================================
- Coverage         6.19%   3.57%   -2.62%
==============================================
  Files              761     304     -457
  Lines           118405   62735   -55670
==============================================
- Hits              7330    2242    -5088
+ Misses          110412   60337   -50075
+ Partials           663     156     -507

Flag
Coverage Δ

aFlag
3.57% <1.80%> (-2.62%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

pkg/cloudcommon/notifyclient/notify.go
1.78% <0.00%> (-0.03%)
:arrow_down:

pkg/compute/models/cloudaccounts.go
0.47% <0.00%> (-0.02%)
:arrow_down:

pkg/compute/models/guestnetworks.go
0.00% <0.00%> (ø)

pkg/compute/models/guests.go
0.51% <0.00%> (-0.01%)
:arrow_down:

pkg/compute/models/initdb.go
0.00% <0.00%> (ø)

pkg/compute/models/networks.go
0.47% <0.00%> (+<0.01%)
:arrow_up:

pkg/compute/models/secgrouprules.go
3.18% <0.00%> (-0.02%)
:arrow_down:

pkg/compute/models/storagecachedimages.go
0.00% <0.00%> (ø)

pkg/compute/models/vpcresource.go
0.00% <0.00%> (ø)

pkg/compute/models/vpcs.go
1.02% <0.00%> (-0.01%)
:arrow_down:

... and 456 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 639e1f0...90bd0cd. Read the comment docs.


lmdb db storage adapter request

https://github.com/LMDB/lmdb
https://github.com/kriszyp/lmdb-js
Symas LMDB is an extraordinarily fast, memory-efficient database we developed for the OpenLDAP Project

@gyn7561  - thanks for the request and we will keep this open for upvotes 👍 for people to add to for the next 60 days. Based on the interest we will consider it.
Also, if you want to do a third party version we are happy to list that here: https://github.com/jaredwray/keyv#third-party-storage-adapters

@gyn7561 - there was not enough demand to do this at this time. Going to close this down.


Summary issue for backwards incompatible changes

Please comment here with a link to an issue that would be backwards incompatible in some way and should be slated for a major release.
Some issues may be completed (in a backwards compatible way), but there are backwards incompatible aspects that should be adjusted.

API for retrieving query plan: https://github.com/eclipse/rdf4j/issues/2104
Will be implemented with no-op default implementations, but at some point these should be be removed to mandate implementation.

Remove temporary default methods introduced by #2143.

Consider removing temporary default method introduced by #2362 (we may decide to postpone to the next major as it would be break all existing custom function implementations).

Consider moving to a unified begin method. Eg. one that only takes transaction settings.

Consider removing ISOLATION_LEVEL_PARAM_NAME and instead only use transaction settings between the client and server.

Consider removing temporary default method introduced by #2675

Some other (already fixed) issues:
#1841
#2392
#3127
#3441
#3140
#3142
#3144

Perhaps the queryrender builder could be removed #3610, since it is deprecated in favor of the sparqlbuilder

Don't check for unsupported Windows versions: #3614

Given that we have this mostly covered in individual tickets (labeled) as well as the upgrade notes, I think we can close this.


Unzip should be preinstalled

OS X VM,  have unzip shipped installed in them.
Others VM should have the unzip command as well, so steps like Resource Archive could be shared across platforms.

I believe zip is installed on Ubuntu as well by default, which environment do you refer to?

actually, just tested and zip is not available, good catch!

PR merged, will be available later today on bitrise.io - probably in a couple of hours


SECURITY: vulnerable to zip-slip (possible remote code execution/file overwrite)

Background
https://github.com/snyk/zip-slip-vulnerability
Steps to reproduce

get a malicious zip file, i.e. https://gist.github.com/grnd/61e3244bfff85cbe025f5bd4c60ba842
unpack with new<EMAIL_ADDRESS>@"c:\target", null);
profit

Expected behavior
either the whole extraction should be stopped, or the files that are being extracted outside of the destination folder should not be extracted.
Actual behavior
All files are extracted.
Version of SharpZipLib
All
Obtained from (place an x between the brackets for all that apply)

[x] Compiled from source
branch: all
commit: any
[x] Downloaded DLL from GitHub
[x] Downloaded DLL from SourceForge
[x] Downloaded DLL from _______
[x] DLL included as part of
Package installed using:
[x] NuGet
[x] MyGet
[x] Chocolatey

I am well aware of "Zip Snip" as it's an exploit as old as the zip format.
The behaviour is currently as intended, although one might argue that disallowing parent directory references in paths and symlinks should be disallowed by default since it prevents (some) misuse.
The root issue is still:
If you do not trust the file source, you should not be blindly extracting it in the first place.

Hey @piksel - indeed this is a feature of the zip format, that has security implications.
As you wrote, it is widely accepted by many zip extraction implementation and libraries that this behaviour should be limited, a partial list of them is in snyk/zip-slip-vulnerability and many others are already limiting this behaviour and are therefore not listed there.
Of course, all of these do not mean this library has to have the same view. However, my opinion is that limiting this dangerous feature is the norm, and so any design choice that is significantly different should be clearly communicated to users. Having corresponded with @christophwille - he suggested I open this issue so users are aware of it.
Personally, I would also suggest re-considering the decision to have this as the intended behaviour, since many users do extract zip files from untrusted sources, and some are using this library to do so. In many cases, this vulnerability could lead to remote code execution. A less extreme decision might be to include this either as a warning or a clarification in the README.

Although the library in the end can't protect users from themselves it
might be a good idea to make some steps to make it harder for them to
mangle things.
This would probably complicate things internally as the likely thing is to
have another setting that by default stops this behaviour.
At a minimum testing archives should warn of absolute paths, paths with
device/drive names in them and relative paths that point to higher level
directories so people who check are provided with suitable information
before they extract the files.
On Mon, 11 Jun 2018 at 23:23 aviadatsnyk<EMAIL_ADDRESS>wrote:

Hey @piksel https://github.com/piksel - indeed this is a feature of the
zip format, that has security implications.
As you wrote, it is widely accepted by many zip extraction implementation
and libraries that this behaviour should be limited, a partial list of them
is in snyk/zip-slip-vulnerability
https://github.com/snyk/zip-slip-vulnerability#affected-libraries and
many others are already limiting this behaviour and are therefore not
listed there.
Of course, all of these do not mean this library has to have the same
view. However, my opinion is that limiting this dangerous feature is the
norm, and so any design choice that is significantly different should be
clearly communicated to users. Having corresponded with @christophwille
https://github.com/christophwille - he suggested I open this issue so
users are aware of it.
Personally, I would also suggest re-considering the decision to have this
as the intended behaviour, since many users do extract zip files from
untrusted sources, and some are using this library to do so. In many cases,
this vulnerability could lead to remote code execution. A less extreme
decision might be to include this either as a warning or a clarification in
the README.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/icsharpcode/SharpZipLib/issues/232#issuecomment-396210231,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAVbBlfTxiVRtqRXg9bILWqn8uI-g5Khks5t7lMhgaJpZM4Uib19
.


azure: rerun the flaky tests automatically

Just added the build flag to enable rerunning the failed flaky tests as brought up by https://github.com/envoyproxy/envoy/issues/12358. This is separated from the additional logic to post-process the test output to prevent rollbacks and improve quality of life of envoy devs.
By adding this, everything except the format build should be building with this option.

Thanks for adding this, but I would prefer not to turn this on until we figure out notification of some type.

Thanks for adding this, but I would prefer not to turn this on until we figure out notification of some type.

oh okay. In that case, I will just try to make the post processing script function on azure now.

@lizan do you mind taking a look when you are available?

should be all set @lizan


Click-disabling event listener remains attached to document after sort finishes

PLEASE READ THE CONTRIBUTION GUIDELINES HERE!
Failure to comply may have your issue automatically closed.
Reproduction

Scenario
https://codesandbox.io/s/green-water-dq651?file=/src/index.js
Steps to Reproduce
Summary of steps if applicable.

Make sure to test in Chrome or Edge. (For reasons I don't understand, the bug does not occur in Firefox.)

Drag the lowest item ("eight") QUICKLY downward and release it.

Click the "Click Me" button. Nothing will happen. (This is the bug.)

Click the "Click Me" button again. This time, clicking the button will trigger an alert as it should.

Describe the bug

Your fix for Issue 1184 has an unintended consequence. In Line 1138, you add an event listener to the document that stops propagation on any click event if the variable "ignoreNextClick" holds the value "true."
In theory, the "ignoreNextClick" variable will get set to "false" the first time the _onDragStart event fires. However, it's possible for this event NEVER TO FIRE if the user drags a sortable item quickly out of the sortable area and releases it. In that case, the event listener is still attached to the document, and the first time the user clicks anything in the DOM, it won't respond.
It took me a couple of hours to figure out that it was Sortable JS causing this problem and not something else in my code. I hope you can spare other developers this pain!
Expected behavior

When I click a button (or anything else) in the DOM after performing a drag-and-drop, it should behave normally. I shouldn't have to click it twice thanks to the "ignoreNextClick" event listener getting left attached to the document. (Remember, this only happens in the circumstances described above, and when "forceFallback" is set to "true.")
Version

package
version

sortablejs
^1.10.2-?

@types/sortablejs
^x.x.x-? || N/A

Additional Context
Let me know if anything isn't clear!

Dan

#1184

Workaround https://github.com/donmbelembe/vue-dragscroll/issues/61#issuecomment-1058266843

A related issue: the disableNextClick listener persists after a destroy() call.


Change in variations specification (doc or Rasa X bug)

Rasa version: 1.0.1
Python version: 3.6.7
Operating system (windows, osx, ...): OS X
Issue: Before Rasa 1.0, a domain.yml file could contain:
intents:
  - greet

actions:
  - utter_hi

templates:
  utter_hi:
    - "Hi"
    - "Hello"
    - "Greetings"

With the introduction of Rasa 1.0, the docs no longer include any example of this kind of usage of variations. Additionally, Rasa X raises the following error when this kind of domain.yml file is used:
Starting Rasa X in local mode... 🚀
Traceback (most recent call last):
  File "/.../.venv/bin/rasa", line 12, in <module>
    sys.exit(main())
  File "/.../.venv/lib/python3.6/site-packages/rasa/__main__.py", line 70, in main
    cmdline_arguments.func(cmdline_arguments)
  File "/.../.venv/lib/python3.6/site-packages/rasa/cli/x.py", line 243, in rasa_x
    local.main(args, project_path, args.data, token=rasa_x_token)
  File "/.../.venv/lib/python3.6/site-packages/rasax/community/local.py", line 194, in main
    session)
  File "/.../.venv/lib/python3.6/site-packages/rasax/community/local.py", line 144, in _initialize_with_local_data
    LOCAL_PROJECT_NAME,
  File "/.../.venv/lib/python3.6/site-packages/rasax/community/api/initialise.py", line 170, in inject_domain
    username=username)
  File "/.../.venv/lib/python3.6/site-packages/rasax/community/services/projects_service.py", line 48, in store_domain
    templates = _templates(domain, username, project_id)
  File "/.../.venv/lib/python3.6/site-packages/rasax/community/services/projects_service.py", line 259, in _templates
    for template, responses in templates.items() for response in responses
  File "/.../.venv/lib/python3.6/site-packages/rasax/community/services/projects_service.py", line 259, in <listcomp>
    for template, responses in templates.items() for response in responses
AttributeError: 'str' object has no attribute 'get'

Changing the domain file to the following allows Rasa X to successfully start:
intents:
  - greet

actions:
  - utter_hi

templates:
  utter_hi:
    - text: "Hi"
    - text: "Hello"
    - text: "Greetings"

I believe that this is either:

An omission from the changelog and migration guide or
A bug in Rasa X

Since 1.0 has already been released, I don't think it's terribly important to update the changelog or migration guide, but if it is a bug in Rasa X, getting it fixed would be nice :)
Alternatively, an explanatory error message from starting Rasa X with this type of configuration file would be nice.
Thanks for all the hard work on Rasa!

Yep, you're totally right, currently Rasa allows this but Rasa X doesn't, we're already on top of getting it fixed! Thanks for pointing it out and showing a fix :)

@erohmensing can you reference the issue where this is being worked on?

It is actually a rasa x issue, but here is the related rasa issue:
https://github.com/RasaHQ/rasa/issues/3544


[Android] Activity not disposed after onDestroy when playing

🐛 Bug Report
Hi. For Android, I want to destroy the app when the user clear it (when he drag it to remove it from the app in memory), but if the player is running, I can't.
If when in foreground, he press a button that call CrossMediaManager.Current.Stop(); the clear works, but if the player is running, the notif if there so it keeps the app in backgroud.
If I press the "stop" btn in the notif or try to call CrossMediaManager.Current.Stop(); in onDestroy or onStop, it remove the notif but the app is still in background. This cause problem when I reopen the app then, it's not a real restart so some data are missing.
I noticed that when debugging, in VS, the debug process is still running.
Expected behavior
Like iOS, we should be able to force the app to stop when remove it from the apps in memory.
Reproduction steps
Run the app in debug, start playing a song, remove the app from running. Stop the song from the notif. The process is still running.
Repo to reproduce : https://github.com/valentin-debris/XamarinMediaDebug/tree/0.6.7-app_running
Configuration
Version: 0.6.7
Platform:

[ ] :iphone: iOS
[x] :robot: Android
[ ] :checkered_flag: WPF
[ ] :earth_americas: UWP
[ ] :apple: MacOS
[ ] :tv: tvOS
[ ] :monkey: Xamarin.Forms

I've tried this in the sample in this repo, but not sure what you mean. When calling stop the Foreground service is stopped and things are disposed. Where is the problem?

@martijn00 I made a quick commit to the repo to help you tu understand. I added a static property in App.xaml.cs (nbLaunch = 1) which I update every time the MainPage is called and display it "Instance number : VALUE_HERE)
If the app is fully destroyed, nbLaunch should be =1 when start the app. But if you follow the process, when you restart the app, the value is now 2. (I'm currently trying to make a record of my screen to show you).

@martijn00 here the quick demo :
As you can see, the "instance number" increase, meaning the app is not fully destroyed. But if I then restart and close it again without starting a song, it is reset to 1, meaning fully destroyed.

@martijn00 , did you take I look ?
A tried to debug and when I comment this line https://github.com/martijn00/XamarinMediaManager/blob/develop/MediaManager/Platforms/Android/MediaSession/MediaBrowserService.cs#L78, the app is fully destroyed. So my assumption is when the StopForeground is called, it may try to use references that have been cleared and so, it can't stop the service.

@valentin-debris See https://github.com/martijn00/XamarinMediaManager/issues/517#issuecomment-507771685
Does that help you when you call that onDestroy of the activity?

@martijn00 , no still not working.
I tried differents thing in MainActivity.cs as the following but the OnDestroy is never call.
protected override void OnDestroy()
        {
            base.OnDestroy();
            //CrossMediaManager.Current.Stop();
            var intent = new Intent(ApplicationContext, Java.Lang.Class.FromType(typeof(MediaManager.Platforms.Android.MediaSession.MediaBrowserService)));
            StopService(intent);
            //intent.Dispose();// Tried too, not working
        }

Do I miss something ?!

Try onPause then. If destroy is not called something else might also be wrong in your app.

@martijn00 , it's the onDestroy() in MediaBrowserService that is never call, the one in MainActivity.cs is call every time I kill the app.

The onDestroy of the MediaBrowserService is not supposed to be called at that moment. It is a foreground service, otherwise the music would stop playing when you go out the app.

@martijn00 , this is what I'm trying to do.
Like Spotify, when you kill the app, even if the song is playing, it stop and close the app. This is not possible with the MediaPlayer, because calling "CrossMediaManager.Current.Stop();" in the onDestroy of the MainActivity keep somehow the app running somewhere.

With this change: https://github.com/martijn00/XamarinMediaManager/commit/fc7f309ffa33bf3cf61fb3e4b56db914239c92a7#diff-744ab47974856b1e866d6b4a1c23f92fR80
You should be able to call stop and make the service stop. I am looking to see if i can pick up the destroy from within the service, but no luck there yet.

Can you try with 0.7.0?

@martijn00 , I'm not abble to compile. I added d8 but when a try to generate the solution, I have the error

Compilation can't be completed because some library classes are missing.	RadioPerfecto.Android	C:\Users\Valentin\Sites\RadioPerfectoApp\RadioPerfecto\RadioPerfecto.Android\R8

But I don't use R8, either  Proguard.
Here is my config for Android

@valentin-debris Yes you need to add d8, and then do a full clean build. Also you need to make sure to have the latest Visual Studio update, and have recent Android SDK installed.

@martijn00 , still the same... I have VS 16.1.3 and the latest SDK.

Can you post the full build output?

I found this in the log "Missing class: org.apache.http.client.methods.HttpEntityEnclosingRequestBase" and somes issues on Google related to this (like https://github.com/xamarin/xamarin-android/issues/2670).
I will try tomorrow with an empty project if it's related to a nugget or not.

@martijn00 I was abble to compile with the fix explain in the link.
But the solution still doesn't work, when I kill the app, it's still there...

0.7.2 should contain a fix for this. Can you test?

@martijn00 just try it and the app is still running after closing it..
The only way for now I have found is using directly your source code and remove the NotificationListener from the PlayerNotificationManager by commented this line https://github.com/martijn00/XamarinMediaManager/blob/df4a6852e86017ddabd37226e7c9684aad36b7d0/MediaManager/Platforms/Android/MediaSession/MediaBrowserService.cs#L134

Right, that means the PlayerNotificationManager probably needs to be destroyed from the service. I have a look at that for the next fix release.

Can you test again with 0.7.3?

@martijn00, nope, still the same. Also, I wasn't abble to find any new commit on github, is it normal ?
Thanks

@valentin-debris I forgot to push, but here it is: https://github.com/martijn00/XamarinMediaManager/commit/2507ca7b0df6369e967086a4bab05bd5bec23fca#diff-744ab47974856b1e866d6b4a1c23f92fR163

I've tested and it comes down to this line: https://github.com/martijn00/XamarinMediaManager/blob/develop/MediaManager/Platforms/Android/MediaSession/MediaBrowserService.cs#L121
When calling StartForeground(notificationId, notification); the service somehow keeps a foreground connection open and won't let the app die. I couldn't find out why yet, so any tips would be welcome.

@valentin-debris Did you solve this issue in the end?

@OdetteP , I have to check with latest version but I think not, I have to kill to process in the onDestroy.

Did you read the last comment of Martijn? This is what he found. "When calling StartForeground(notificationId, notification); the service somehow keeps a foreground connection open and won't let the app die. I couldn't find out why yet, so any tips would be welcome".  Do you know why it keeps the foreground connection open?


[REG2.068.1-b2] Issue 15017 - assigning a Variant to be value in a hashmap

https://issues.dlang.org/show_bug.cgi?id=15017
Request TypeInfo generation where the corresponding glue layer code needs it.

Thanks!


Fix: Test adding bin to binary image

Which problem is this PR solving?
Test adding bin to binary image and artifact path to match other k8s agents repos.
Short description of the changes
Type of change
Please delete options that are not relevant.

[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Security fix
[ ] New feature / enhancement (non-breaking change which adds functionality)
[ ] Bug fix (non-breaking change which fixes an issue)
[ ] This change requires a documentation update

New Tests?
Please describe the new tests that were added (if applicable).

[ ] This change requires changes in testing:

[ ] unit tests
[ ] e2e tests

Checklist:

[ ] Add changelog entry following the contributing guide
[ ] Tests have been added
[ ] Documentation has been updated

No longer needed


Feature Request: Add Mish Activation

Mish is a new novel activation function proposed in - https://arxiv.org/abs/1908.08681
It has shown promising results so far and has been adopted in several packages including:

TensorFlow Addons
FastAI-dev
SpaCy
Thinc
DarkNet

All benchmarks, analysis and links to official package implementations can be found in this repository - https://github.com/digantamisra98/Mish
It would be nice to have Mish along with both Swish and GELU activation functions.

Hi,
Thats a good recommendation. At present Monk supports only a certain version of pytorch, keras and mxnet.
We are creating a community soon to discuss and implement future goals.
We can add Mish and alike algorithms using two ways:
a) Integrate pytoch, mxnet and tensorflow's latest versions with contrib modules.
b) Integrate 3rd party libraries such as https://echo-ai.readthedocs.io/en/latest/#.
Once we release the community page then we can streamline and quickly integrate the mentioned algorithms.
Thanks again for the suggestions, let us know your thoughts on the experience with the library and comments on the same.

Hi
Thanks for the response. That sounds good, thanks for considering the proposal. Mish can be also directly integrated for TensorFlow using TensorFlow-Addons. Echo can be a good addition. We are planning to release the next set of activations and optimizers so integrating it along with Monk would be fantastic.
I will give Monk a run this week hopefully and provide my feedback.
Keep up the good work.


No maximum recursion depth

Hi, I just stumbled across this project, and this looks very interesting.
I was playing around with it a bit and noticed that there is no maximum recursion depth.
When calling a recursive function with no stop condition, it just loops forever:
function recursive(a) { recursive(a); }

It could be a good idea to set a hard limit like PHP, especially since this language targets clients.

Hi, this is an interesting proposition. I will think about it.

@smuuf I have a working attempt on a fork if you want (along with other changes).
https://github.com/smuuf/primi/compare/master...Morebec:master


Fix issue with Python 3.6

@duburcqa Could you check this fix on your side?

@duburcqa : could you confirm that robotpkg-py36-eigenpy 2.9.1 still present issues on your side ?

Yes I will.

Could you check this fix on your side?

It was not working but it was before your last commit, so it was not checking the right Python version. Trying again now.

@jcarpent It works!

@duburcqa : could you confirm if robotpkg-py36-eigenpy 2.9.1 still present issues on your side ?

Still crashing.

You patch is not relevant for all Python versions ? Why only apply it to Python 3.6.9 ?

No, as you can see, the CI is fine for the other Ubuntu versions.

In general, I'm trying to fix what should be fixed and not apply a patch if it is not necessary elsewhere.
PS: the issue really seems to be coming from Boost.Python + Python 3.6

Ok no problem I'm fine with it ! Thank you for the patch !


[Question] Inliner without minification?

Is there a way to npm run build so we get inline styles, BUT not minify the HTML?
It would be great if this were an option so that, if you're coding a template that others will develop on/customize, you don't need to resort to online tools to prettify your HTML.
More, at least for me, the minified HTML is actually broken, I always need to prettify it online in order to get usable code.
Thanks!

In the GulpFile you have these options:
.pipe($.htmlmin, {
      collapseWhitespace: false,
      minifyCSS: false
    });

Once you make the changes and save - make sure to re-run npm start
We'd actually like to have this documented. Is that something you can help with?

Coolio, would love to get involved. What do I need to do? (don't know how to Git, but willing to learn if that's required)

Awesome - for docs you can jump into the page by clicking the edit button at the top of the page:

I would title a new section below the descriptions with an <h2> and maybe call it "Build Options"
Or through GitHub, clone this repo, make changes on a branch, then in github you will see a Pull Request option next to your branch name.

I took it @rafibomb 👍
https://github.com/zurb/foundation-emails/pull/458

Like @hellocosmin the html minification was also breaking my code builds. I actually only noticed it when try to inline using litmus online inliner just to double check if I wasn't crazy.
 When I actually send the email, not the web preview, the primary button had no background (using default foundation styles here, only changed variables values). button text color is white background was white so they "disappeared".
I'm not sure how can I test this, because secondary button styles were preserved.
¯\_(ツ)_/¯
Final and paradoxal solution to keep everything right: keep foundation for emails defaults, with htmlmin options true and then beautify using gulp-prettify
¯\_(ツ)_/¯ * 2

@renatodeleao How does gulp-prettify help in this case?
If you have any specific example of code that is being changed, please share it in a new issue so it can be investigated! Thanks!
Thanks to @zxhadow for the PR on this!

@rafibomb Oddly enough if I remove the HTML minification it seems to also skip any CSS inlining.  I've kept my gulp file unchanged other than setting those two flags to false (and I also tried just removing that final .pipe() method, but they both produced the same result.  The HTML is not minified, but there's also not any CSS inlining.  Gulp is reporting that the inlining is happening too.
Will keep looking into it, but interest if you or anybody else has run into this?
Thanks!


armadillo: 9.100.5 -> 9.200.4

Semi-automatic update generated by https://github.com/ryantm/nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/armadillo/versions.
meta.description for armadillo is: '"C++ linear algebra library"'.

Checks done (click to expand)

built on NixOS

0 of 0 passed binary check by having a zero exit code.

0 of 0 passed binary check by having the new version present in output.

found 9.200.4 with grep in /nix/store/fxcrmlhhs2xcymslgn7lx0bkbq275206-armadillo-9.200.4

directory tree listing: https://gist.github.com/3dd3898f44b7d84568d2401b8ee2a199

du listing: https://gist.github.com/2540fd5c7c047eb84b03e89287b000bd

Outpath report (click to expand)

Outpath difference report
10 total rebuild paths
3 package rebuilds
3 x86_64-linux rebuilds
3 i686-linux rebuilds
1 x86_64-darwin rebuilds
3 aarch64-linux rebuilds
First ten rebuilds by attrpath
armadillo
gnss-sdr
openmolcas

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/fxcrmlhhs2xcymslgn7lx0bkbq275206-armadillo-9.200.4 \
  --option binary-caches 'https://cache.nixos.org/ https://r-ryantm.cachix.org/' \
  --option trusted-public-keys '
  r-ryantm.cachix.org-1:gkUbLkouDAyvBdpBX0JOdIiD2/DP1ldF3Z3Y6Gqcc4c=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(r-ryantm's Cachix cache is only trusted for this store-path realization.)
Or, build yourself:
nix-build -A armadillo https://github.com/r-ryantm/nixpkgs/archive/67c7685280a15a4fb00489ffdff9486b3c743644.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/fxcrmlhhs2xcymslgn7lx0bkbq275206-armadillo-9.200.4
ls -la /nix/store/fxcrmlhhs2xcymslgn7lx0bkbq275206-armadillo-9.200.4/bin

cc @juliendehos @knedlsepp for testing.

Success on x86_64-darwin (full log)
Attempted: armadillo
Partial log (click to expand)
-- Installing: /nix/store/5xbla01ilyv1vmqg9nmsvrzba8svxqs8-armadillo-9.200.4/lib/libarmadillo.dylib
-- Installing: /nix/store/5xbla01ilyv1vmqg9nmsvrzba8svxqs8-armadillo-9.200.4/share/Armadillo/CMake/ArmadilloLibraryDepends.cmake
-- Installing: /nix/store/5xbla01ilyv1vmqg9nmsvrzba8svxqs8-armadillo-9.200.4/share/Armadillo/CMake/ArmadilloLibraryDepends-release.cmake
-- Installing: /nix/store/5xbla01ilyv1vmqg9nmsvrzba8svxqs8-armadillo-9.200.4/share/Armadillo/CMake/ArmadilloConfig.cmake
-- Installing: /nix/store/5xbla01ilyv1vmqg9nmsvrzba8svxqs8-armadillo-9.200.4/share/Armadillo/CMake/ArmadilloConfigVersion.cmake
-- Installing: /nix/store/5xbla01ilyv1vmqg9nmsvrzba8svxqs8-armadillo-9.200.4/lib/pkgconfig/armadillo.pc
post-installation fixup
strip is /nix/store/g5r4apl0za012ffs6ladinwa5w0m1l3k-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/5xbla01ilyv1vmqg9nmsvrzba8svxqs8-armadillo-9.200.4/lib
patching script interpreter paths in /nix/store/5xbla01ilyv1vmqg9nmsvrzba8svxqs8-armadillo-9.200.4

Success on aarch64-linux (full log)
Attempted: armadillo
Partial log (click to expand)
-- Installing: /nix/store/rlg4ddci0anx99fn9q3rqc93fcswnnrz-armadillo-9.200.4/share/Armadillo/CMake/ArmadilloConfig.cmake
-- Installing: /nix/store/rlg4ddci0anx99fn9q3rqc93fcswnnrz-armadillo-9.200.4/share/Armadillo/CMake/ArmadilloConfigVersion.cmake
-- Installing: /nix/store/rlg4ddci0anx99fn9q3rqc93fcswnnrz-armadillo-9.200.4/lib/pkgconfig/armadillo.pc
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/rlg4ddci0anx99fn9q3rqc93fcswnnrz-armadillo-9.200.4
shrinking /nix/store/rlg4ddci0anx99fn9q3rqc93fcswnnrz-armadillo-9.200.4/lib/libarmadillo.so.9.200.4
strip is /nix/store/p9akxn2sfy4wkhqdqa3li97pc6jaz3r1-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/rlg4ddci0anx99fn9q3rqc93fcswnnrz-armadillo-9.200.4/lib
patching script interpreter paths in /nix/store/rlg4ddci0anx99fn9q3rqc93fcswnnrz-armadillo-9.200.4
checking for references to /build in /nix/store/rlg4ddci0anx99fn9q3rqc93fcswnnrz-armadillo-9.200.4...

Success on x86_64-linux (full log)
Attempted: armadillo
Partial log (click to expand)
-- Installing: /nix/store/fxcrmlhhs2xcymslgn7lx0bkbq275206-armadillo-9.200.4/share/Armadillo/CMake/ArmadilloConfig.cmake
-- Installing: /nix/store/fxcrmlhhs2xcymslgn7lx0bkbq275206-armadillo-9.200.4/share/Armadillo/CMake/ArmadilloConfigVersion.cmake
-- Installing: /nix/store/fxcrmlhhs2xcymslgn7lx0bkbq275206-armadillo-9.200.4/lib/pkgconfig/armadillo.pc
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/fxcrmlhhs2xcymslgn7lx0bkbq275206-armadillo-9.200.4
shrinking /nix/store/fxcrmlhhs2xcymslgn7lx0bkbq275206-armadillo-9.200.4/lib/libarmadillo.so.9.200.4
strip is /nix/store/vcc4svb8gy29g4pam2zja6llkbcwsyiq-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/fxcrmlhhs2xcymslgn7lx0bkbq275206-armadillo-9.200.4/lib
patching script interpreter paths in /nix/store/fxcrmlhhs2xcymslgn7lx0bkbq275206-armadillo-9.200.4
checking for references to /build in /nix/store/fxcrmlhhs2xcymslgn7lx0bkbq275206-armadillo-9.200.4...

@GrahamcOfBorg build gnss-sdr openmolcas

No attempt on x86_64-darwin (full log)
The following builds were skipped because they don't evaluate on x86_64-darwin: gnss-sdr, openmolcas
Partial log (click to expand)

a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

Failure on x86_64-linux (full log)
Attempted: gnss-sdr, openmolcas
Partial log (click to expand)
   used as include directory in directory /build/source/src/tests
   used as include directory in directory /build/source/src/tests
   used as include directory in directory /build/source/src/tests
   used as include directory in directory /build/source/src/tests

-- Configuring incomplete, errors occurred!
See also "/build/source/build/CMakeFiles/CMakeOutput.log".
See also "/build/source/build/CMakeFiles/CMakeError.log".
builder for '/nix/store/8b0vq4rcxsljazfbw76raw8jw5xh42mr-gnss-sdr-0.0.9.drv' failed with exit code 1
error: build of '/nix/store/8b0vq4rcxsljazfbw76raw8jw5xh42mr-gnss-sdr-0.0.9.drv' failed

Failure on aarch64-linux (full log)
Attempted: gnss-sdr, openmolcas
Partial log (click to expand)
cannot build derivation '/nix/store/q3pv07v48jyh8qzgpm1r8wjv6yc5va57-tls-1.4.1.drv': 17 dependencies couldn't be built
cannot build derivation '/nix/store/x94qhdgjjn6pi5zhcnbxp6csmndvyvrh-connection-0.2.8.drv': 11 dependencies couldn't be built
cannot build derivation '/nix/store/793ymrxpa1nmc0h9qbyb705hzaqpc6aa-yaml-0.8.32.drv': 15 dependencies couldn't be built
cannot build derivation '/nix/store/qcpay92v35qx4jgpckq7krz513ah3sdv-http-client-tls-<IP_ADDRESS>.drv': 13 dependencies couldn't be built
cannot build derivation '/nix/store/a1snaj0bpwzl00skil0a6xz97i0mkilf-pandoc-2.2.1.drv': 40 dependencies couldn't be built
cannot build derivation '/nix/store/2r6n4ij8p62869sx23fkhd6w9jy9nmap-rdma-core-20.1.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/lbbwcz4vcny5s1byc5r3q09078ww6db6-openmpi-3.1.2.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/nwffaipvaa2na21pb2mx7hphfwsv66cw-globalarrays-5.7.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/pm3zz9aqgsv2325h56qzhicl6p8qbssl-openmolcas-18.09.drv': 2 dependencies couldn't be built
error: build of '/nix/store/27y28fvzb7zxr7qgzr6bjp9l643jjply-gnss-sdr-0.0.9.drv', '/nix/store/pm3zz9aqgsv2325h56qzhicl6p8qbssl-openmolcas-18.09.drv' failed

gnss-sdr started to look for gtest in https://hydra.nixos.org/build/83283377 and fails to find it (has never been an input to the package?).

@GrahamcOfBorg build gnss-sdr openmolcas

No attempt on x86_64-darwin (full log)
The following builds were skipped because they don't evaluate on x86_64-darwin: gnss-sdr, openmolcas
Partial log (click to expand)

a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

Success on x86_64-linux (full log)
Attempted: armadillo, gnss-sdr
Partial log (click to expand)
shrinking /nix/store/j0a08jwlvmw4s3s9km7sshnbrqlr0zif-gnss-sdr-0.0.9/bin/gnss-sdr
shrinking /nix/store/j0a08jwlvmw4s3s9km7sshnbrqlr0zif-gnss-sdr-0.0.9/bin/volk_gnsssdr-config-info
shrinking /nix/store/j0a08jwlvmw4s3s9km7sshnbrqlr0zif-gnss-sdr-0.0.9/bin/volk_gnsssdr_profile
gzipping man pages under /nix/store/j0a08jwlvmw4s3s9km7sshnbrqlr0zif-gnss-sdr-0.0.9/share/man/
strip is /nix/store/vcc4svb8gy29g4pam2zja6llkbcwsyiq-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/j0a08jwlvmw4s3s9km7sshnbrqlr0zif-gnss-sdr-0.0.9/bin
patching script interpreter paths in /nix/store/j0a08jwlvmw4s3s9km7sshnbrqlr0zif-gnss-sdr-0.0.9
checking for references to /build in /nix/store/j0a08jwlvmw4s3s9km7sshnbrqlr0zif-gnss-sdr-0.0.9...
/nix/store/fxcrmlhhs2xcymslgn7lx0bkbq275206-armadillo-9.200.4
/nix/store/j0a08jwlvmw4s3s9km7sshnbrqlr0zif-gnss-sdr-0.0.9

Success on x86_64-linux (full log)
Attempted: gnss-sdr, openmolcas
Partial log (click to expand)
shrinking /nix/store/j0a08jwlvmw4s3s9km7sshnbrqlr0zif-gnss-sdr-0.0.9/bin/volk_gnsssdr-config-info
shrinking /nix/store/j0a08jwlvmw4s3s9km7sshnbrqlr0zif-gnss-sdr-0.0.9/bin/gnss-sdr
shrinking /nix/store/j0a08jwlvmw4s3s9km7sshnbrqlr0zif-gnss-sdr-0.0.9/bin/front-end-cal
gzipping man pages under /nix/store/j0a08jwlvmw4s3s9km7sshnbrqlr0zif-gnss-sdr-0.0.9/share/man/
strip is /nix/store/vcc4svb8gy29g4pam2zja6llkbcwsyiq-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/j0a08jwlvmw4s3s9km7sshnbrqlr0zif-gnss-sdr-0.0.9/bin
patching script interpreter paths in /nix/store/j0a08jwlvmw4s3s9km7sshnbrqlr0zif-gnss-sdr-0.0.9
checking for references to /build in /nix/store/j0a08jwlvmw4s3s9km7sshnbrqlr0zif-gnss-sdr-0.0.9...
/nix/store/j0a08jwlvmw4s3s9km7sshnbrqlr0zif-gnss-sdr-0.0.9
/nix/store/1v3zmck3fr8j17lilsdv4c6sxah051c9-openmolcas-18.09

Timed out, unknown build status on aarch64-linux (full log)
Attempted: gnss-sdr, openmolcas
Partial log (click to expand)
cannot build derivation '/nix/store/q3pv07v48jyh8qzgpm1r8wjv6yc5va57-tls-1.4.1.drv': 17 dependencies couldn't be built
cannot build derivation '/nix/store/x94qhdgjjn6pi5zhcnbxp6csmndvyvrh-connection-0.2.8.drv': 11 dependencies couldn't be built
cannot build derivation '/nix/store/793ymrxpa1nmc0h9qbyb705hzaqpc6aa-yaml-0.8.32.drv': 15 dependencies couldn't be built
cannot build derivation '/nix/store/qcpay92v35qx4jgpckq7krz513ah3sdv-http-client-tls-<IP_ADDRESS>.drv': 13 dependencies couldn't be built
cannot build derivation '/nix/store/a1snaj0bpwzl00skil0a6xz97i0mkilf-pandoc-2.2.1.drv': 40 dependencies couldn't be built
cannot build derivation '/nix/store/2r6n4ij8p62869sx23fkhd6w9jy9nmap-rdma-core-20.1.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/lbbwcz4vcny5s1byc5r3q09078ww6db6-openmpi-3.1.2.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/nwffaipvaa2na21pb2mx7hphfwsv66cw-globalarrays-5.7.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/pm3zz9aqgsv2325h56qzhicl6p8qbssl-openmolcas-18.09.drv': 2 dependencies couldn't be built
error: build of '/nix/store/pm3zz9aqgsv2325h56qzhicl6p8qbssl-openmolcas-18.09.drv' failed


pmbootstrap: 2.3.1 > 3.0.0

Updated pmbootstrap to 3.0.0: changelog

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Result of nixpkgs-review pr 355579 run on x86_64-linux 1

2 packages built:

pmbootstrap
pmbootstrap.dist

nixpkgs-review result
Generated using nixpkgs-review.
Command: nixpkgs-review pr 355579

x86_64-linux

:white_check_mark: 2 packages built:

pmbootstrap
pmbootstrap.dist


[REQUEST] Comparable models

What is the feature you're proposing?
Currently, it's hard to check if two objects (e.g. Members) refer to the same item on discord. I would like a way to easily check if two objects are the same, and preferably also be able to store those objects in places that need hashes (sets and dict keys)
One simpler way to do this would be to create a mixin which has methods for __eq__ and __hash__, and compare/hash the ids of the objects
Additional Information

[ ] My feature request is related to an existing Issue.

Issue (if referenceable):

We could add this, but a simple way of doing this (internally at least) is checking the JSON attribute of the model and comparing it to another, or checking if the one you currently have has been cached. Either solution works, but I would need to see more use cases to provide a worthy case for implementing these magics.


Consider inverting the messages dependency

Currently everything depends on messages.

This happens partially because messages contains the entire domain.
And partially because we use messages as the Gherkin AST.

This is not great because:

We have a serialization format at the core of our domain rather then in an adaptor.
Because the Gherkin AST is the serialized format we can not utilize any patterns that make working with ASTs easier.
When anything in the domain changes, everything has to be updated.
Messages depends on Jackson. Due to it's nature as a de-serialization library Jackson gets frequent security updates.

As a visual aid (note note quite accurate, I was sketching out something else):

As such I would propose inverting the dependency and splitting messages into several smaller submodules. The modules are already hinted at by the comments in the proto file.
https://github.com/cucumber/common/blob/f96daddbedd679969bee1609ac9a71e857752720/messages/messages.proto#L13-L43
By inverting the dependency:

We push the serialization format out to the edges of the architecture. This allows for proper ports and adaptors design. Only root dependents (e.g. the Cucumber CLI) would have a dependency on messages.
The impact of updating external dependency changes is limited to the root dependents (e.g. the Cucumber CLI).
Changes that impact Gherkin won't impact execution related code.and vice-versa.

Now I imagine the biggest perceived obstacle will be additional copying the domain objects into messages. However for example if the Gherkin AST was modelled as a tree of nodes using the visitor pattern it would be relatively straightforward to convert it to a message object.

But isn't it the idea of Jackson and similar frameworks to have domain objects that could be (optionally) be serialized, just to prevent creating additional domain objects for serialization?
The consequence of your proposal would be that we have some kind of layer above messages? I'm just asking because Cucumber Plugins already has such a layer but it does not contains all information there and changes seem to be hard because of the discussion about what should be API or not, so in the end I ended up using the raw messages as they are offering the greatest flexibility.
This leads me to another point where I think if this is done and should be useful for different consumers (IDE, CLI, ...) the parsers and converter has all to be public accessible.

Ah. Yes you are definitely right that the messages are filling in a gap of domain objects. However we should not introduce a monolithic domain. Rather each module has it's own public API and only uses another modules public API. The domain objects can be part of this public API. For example:

In this case we have two modules. A compiler and parser module. The Parser, Compiler, AST and Pickle classes are all part of it's public API.
Internally each module can use patterns such as "Ports and Adapters" but I don't think this pattern is efficient for small libraries that do not have any input/output. Rather this is something you'd apply to utilities that use these libraries such as the Gherkin CLI because these have to deal with input and output where as the parser and compiler modules do not.
For example:

Now this brings us to the next problem. The current implementation has to deal with input and output just to pass the shared test suite. This was a pragmatic choice, but it also means that as a module gherkin drags in more then needed.


Support Wifi-Calling

Some EE smartphones in UK come with Wifi calling - it falls back to wifi if no/weak cell signal.
When in this mode the green phone handset dial icon in contacts has an addition "HD" symbol on it.
These calls appear in the call log on the phone but the entries show an icon like the the normal incoming/outgoing/missed icon but with the handset on its back rather than 45 degrees and "wifi" style signal burst as well.
These items are not backed up by SMS Backup+.
Jan - I'd be happy to contribute with additional debug or any other tasks to get this implemented in your excellent app (I'm a software dev though not mobile apps).

Not sure how to work on this without access to the specific software

It's an android feature, but only enabled if the carrier supports it, but perhaps can be enabled in dev android simulator?:

https://www.androidcentral.com/tag/wifi-calling.

How to enable it does seem to vary from phone to phone though.

https://ee.co.uk/help/help-new/getting-started-and-upgrading/using-your-phone-features/how-do-i-use-wifi-calling
https://help.ting.com/hc/en-us/articles/205421898-Wi-Fi-Calling-Setup-on-Android
http://www.tech-recipes.com/rx/60544/enable-use-wi-fi-calling-android/

Happy to run a debug of some kind to collect data if it would help?

I don't think the emulator supports this option. Looking at the code, they should get logged as normal calls. There is a new feature flag for FEATURES_WIFI and FEATURES_HD_CALL but the call type should be the same (incoming, outgoing etc).
I would have to build a special version to collect some data, to see how the calls are stored on your device. Are the calls made with the same app? (i.e. the stock phone app?)

Yes, it was using the stock phone app.
Since it was a while ago since I raised it (I'm not "having a go" about that! :-) ) I'll try to recheck it's still the case that they aren't logged - I've had a couple of software updates and I guess it might have been an android bug now fixed?

@Kolossi please do! what's your current android version? the flags I mentioned where added in Android Oreo (8.0).

Ok, ahem, so, it's working now, so I guess the sofware updates at some stage fixed it.
The call log on the phone now doesn't show them as different icons (this was in the original report).
FYI, my android version 7.0 (UK EE Galaxy S6), but like I say it's working fine now, so this one's a "Can't reproduce".
Thanks for your dedication in going through older issues, and for your time today @jberkel


RFC: set_pipeline step

Rendered
Please comment on individual lines, not at the top-level.

@vito Please consider to support pipeline self set. For example, for the set_pipeline step, if configure pipeline-name: self, where self is a reserved word, the it just do self set. With self set, pipeline name and team are known from the current pipeline.
I see you have create issue #4254 to track implementation of set_pipeline. Once this step is in place, it will simplify a lot of our use cases. I think set_pipeline step could be done on ATC, just call same function as current set-pipeline API, no need to start any container. If that's true and you are ok, I can contribute a PR, as we eager for this feature.

Weird error...
unknown artifact source: '.' in file path './repo/ci/pipeline.yml'
changing the file path to repo/ci/pipeline.yml' fixes it.

Works so far, but I would like to see the team name to be able to be changed. Right now I have four teams which all have their own auto-setting pipeline, which I would like to merge into one.

Please comment on individual lines, not at the top-level.

Err, that guidance aside...
The old pipeline resource accepted globs in its vars_files elements. The new step doesn't. I'm not sure I can make a compelling case for accepting more generic input instead of specific input, but it is a bit more hassle if you've got a versioned file being used as a vars file. In our use case we have to use Minio rather than S3, so we have to have a version number in the file name of assets we track.
I thought I'd flag it in case this is an unintentional reduction in functionality.

@DanielJonesEB Interesting, definitely not intended. Good call! That worked previously because the resource itself performed glob expansion against its local filesystem. For the set_pipeline step that will be a bit more challenging, as we don't have access to a local filesystem. Hmmm. 🤔 I'm going to record that as an open question.
@TheDevMinerTV That's a tricky one. Configuring within the team is somewhat easy because we can assume someone set the configuring pipeline within that team and therefore they have authority to set other pipelines. But once you go cross-team, that same assumption is no longer valid - only if you're the main team, which feels like a pretty limited use case.
I think this touches on a larger goal of full-stack automation, which might involve things like a set_team step and perhaps even a set_project step (assuming #32) in the future. I think for now it's best that we leave that out of scope of this issue, but it'd be a super interesting discussion to hold elsewhere. Until we hash that out I don't think we can/should have a set_pipeline step that can configure in other teams.

Sounds fair :smile:

Coming from https://github.com/concourse/concourse-pipeline-resource/issues/10, is set_pipeline step gonna support destroy or there will be a destroy_pipeline step in the roadmap?

@xtremerui I don't think we'll need destroying with the advent of pipeline archiving, where you can just remove the step from you config.

Is it planned to implement a get_pipeline step in the future, to do what the concourse-pipeline-resource was doing as "in"?

@gid0 There are no plans for this at the moment. If you've got a use case for this, feel free to open a new discussion!


[Docs] using WorkflowEditor as a library

We're looking into using WorkflowEditor in another project, however per #141 there's not much documentation on doing so yet.
It sounds like the Canvas is what's exported by the NPM package.  Would the best path forward to re-use the WorkflowEditor component be to fork that part of the project?

@hauntingEcho
It is best to download the ReactDesignEditor package and directly modify and use the WorkflowEditor using the Canvas component.

that makes sense - thanks!


pre-commit improvements

#3497 will switch around the order of pre-commit checks (pyi generation will happens before pyright checks)
You can base your change on that.


Update to near-sdk-as

Remove gulp and update imports to use the new name.

Damn these flaky tests!!
 FAIL  src/App.test.js

  ● Test suite failed to run

    send_tx_commit has timed out

      at JsonRpcProvider.sendJsonRpc (node_modules/nearlib/lib/providers/json-rpc-provider.js:57:27)

      at Account.retryTxResult (node_modules/nearlib/lib/account.js:53:22)

      at Account.signAndSendTransaction (node_modules/nearlib/lib/account.js:79:26)

      at Account.createAndDeployContract (node_modules/nearlib/lib/account.js:119:9)

      at LocalTestEnvironment.setup (node_modules/near-shell/test_environment.js:33:9)`

I think we want to keep the gulpfile.js in the projects for now, actually, because near-shell's command build runs gulp
https://github.com/nearprotocol/near-shell/blob/master/bin/near-cli.js#L122
This is a stop-gap and we need to land on the future of near build but not right now imo

Okay, but the instructions for this doesn't say to use near build so I don't think it will confuse new people.
Plus we've already removed gulp from most examples.

Okay, but the instructions for this doesn't say to use near build so I don't think it will confuse new people.
Plus we've already removed gulp from most examples.

okay you're right, I thought the individual readmes had near build but I was wrong. I'm good, just gotta figure out what's up with the node version and if we're cool with bumping this to node 12


AppsMeet Package Permission denied on resource Space error

Environment details

OS: Microsoft 10 Xampp
PHP version: 8.0
Package name and version: AppsMeet 0.2.1

Steps to reproduce

I have just configured everything in google cloud console, i am using service account as auth method and i download key file as json. But i am getting this error
"Call failed with message: { "message": "Permission denied on resource Space (or it might not exist)", "code": 7, "status": "PERMISSION_DENIED", "details": [] }"

Code example
 public function index()
    {
        $spacesServiceClient  = new SpacesServiceClient([
            'credentials' => storage_path('app\google-calendar\key.json')
        ]);

        $request = new CreateSpaceRequest();

        try {
            $response = $spacesServiceClient->createSpace($request);
            printf('Response data: %s' . PHP_EOL, $response->serializeToJsonString());
        } catch (ApiException $ex) {
            printf('Call failed with message: %s' . PHP_EOL, $ex->getMessage());
        }
    }

Anyone can help, i tried adding domain wide delegation with specified oauth scopes which stated in documentation but i am still getting same error ?

@ajupazhamayil

For adding using domain wide delegation i updated my code to this which is for impersonate my main user from service account but it's not working since SpacesServiceClient not accepting Client object but $options i started to think that this package not allowing you impersonate yet.
    public function index(){
         putenv('GOOGLE_APPLICATION_CREDENTIALS=' . base_path("key.json"));

         $client = new Client();
         $client->useApplicationDefaultCredentials();
         $client->addScope('https://www.googleapis.com/auth/meetings.space.readonly');
         $client->addScope('https://www.googleapis.com/auth/meetings.space.created');
         $client->setSubject('test@test.com');
         $options = [
             'credentials' => $client,
         ];

        // Create a client.
        $spacesServiceClient = new SpacesServiceClient($options);

        // Prepare the request message.
        $request = new CreateSpaceRequest();

        // Call the API and handle any network failures.
        try {
            /** @var Space $response */
            $response = $spacesServiceClient->createSpace($request);
            printf('Response data: %s' . PHP_EOL, $response->serializeToJsonString());
        } catch (ApiException $ex) {
            printf('Call failed with message: %s' . PHP_EOL, $ex->getMessage());
        }
    }

See this comment for how to set the subject (e.g. enable domain-wide delegation)
https://github.com/googleapis/google-cloud-php/issues/5842#issuecomment-1474486244

after setting up domain wide delegation and other related configurations on google cloud console this code worked for me
`     public function index(){
     $credentials = (new ServiceAccountCredentials(['https://www.googleapis.com/auth/meetings.space.readonly','https://www.googleapis.com/auth/meetings.space.created']
         ,base_path("key.json"),
<EMAIL_ADDRESS>     ));
    // Create a client.
    $spacesServiceClient = new SpacesServiceClient(['credentials' => $credentials]);

    // Prepare the request message.
    $request = new CreateSpaceRequest();

    // Call the API and handle any network failures.
    try {
        /** @var Space $response */
        $response = $spacesServiceClient->createSpace($request);
        printf('Response data: %s' . PHP_EOL, $response->serializeToJsonString());
    } catch (ApiException $ex) {
        printf('Call failed with message: %s' . PHP_EOL, $ex->getMessage());
    }
}`

Whats the "Other related configurations on google cloud console" configurations you did @erensertkaya ?

For what it's worth, the relevant configuration for domain-wide delegation is NOT in the google cloud console, but in the google workspace admin.
Here, you can enter the user account to be impersonated by the service account in this screen:

Then you authorize the Oauth scopes.
Important
If you authorize only https://www.googleapis.com/auth/meetings.space.created, you will get the following error:
google.auth.exceptions.RefreshError: ('unauthorized_client: Client is unauthorized to retrieve access tokens using this method, or client not authorized for any of the scopes requested.', {'error': 'unauthorized_client', 'error_description': 'Client is unauthorized to retrieve access tokens using this method, or client not authorized for any of the scopes requested.'})

To get rid of it, you must add the following Oauth scope:
https://www.googleapis.com/auth/meetings.space.readonly

@erensertkaya Hi, I have a similar issue regarding integrating Google Meet using PHP. Would you be able to share the source code for the part where you handled the Google Meet integration?
During my integration process, I encountered an error:
{ "message": "Permission denied on resource Space (or it might not exist)", "code": 7, "status": "PERMISSION_DENIED", "details": [] }
Additionally, I ran into other issues that have delayed my progress. I would deeply appreciate your help.
If possible, could you also provide an email address where I could reach you? Thank you so much!
<EMAIL_ADDRESS>


[BUG] Task sort order: desktop and mobile difference

Describe the bug
Dataview sorts tasks arbitrarily with differences between desktop and mobile. SORT and GROUP BY do not work on any version.
From a simple syntax:
```dataview
task from #active
where !completed
```

On mobile, Dataview returns the note list with tasks as:

Project A
Project B
Project C
Project D
Project E

On desktop, the note list with tasks is returned as:

Project C
Project B
Project A
Project E
Project D

Moreover, all SORT or GROUP BY options do not work. E.g. setting a sort to:
SORT file.name ASC does nothing.
GROUP BY brings up a list of all tasks under a — heading without any grouping.
Expected behavior
Note and tasks are ordered identically on every device. SORT and GROUP BY work as intended.
Desktop (please complete the following information):

OS: macOS
Obsidian Version: 0.12.15
Dataview Version: 0.4.10

Smartphone (please complete the following information):

Device: iPhone 12 Mini
OS: iOS 15
Obsidian Version: 0.12.15
Dataview Version: 0.4.10

In case it helps, I've found an easy way to reproduce this on a single desktop machine.
(I came here to report that I could not get SORT file.name to work with tasks. But after seeing this issue, I tried some simpler things...)
These two snippets differ only in the sort order - one ascends, and the other descends.
```dataview
TASK
FROM #current
WHERE !completed
SORT file.mtime ASC
```

---

```dataview
TASK
FROM #current
WHERE !completed
SORT file.mtime DESC
```

And for, me they consistently both give the exact same order.
Environment:

macOS 10.15.7
Obsidian 0.12.15
dataview 0.4.10

Thanks for chiming in. However, this too does not work. If I use the snippets above I get the following the same sort order as above:
iOS:

Project A
Project B
Project C
Project D
Project E

macOS:

Project C
Project B
Project A
Project E
Project D

So it appears that sort does nothing, at least for me.

@bartderuyck  Oh, sorry, I was unclear - I was agreeing with you, and just providing a simpler reproduction, as the problem can be demoed on a single machine: specifying an opposite sort order generates the same output.
(It's always easier to fix bugs if you can first reproduce them on one machine, rather than have to test on two different machines, I find.)
I think I would summarise it as:

The documented sort order for tasks is ignored - on any given machine, tasks are printed on a random order
And as per the first post, that random order differs across machines.

From looking at the code that displays tasks, I cannot (yet) see any reference to sorting at all, but I'm new to JS and TS, so could be missing something obvious.

Apologies, I clearly misread your response! You're absolutely right: both snippets produce identical output on the same device. I've just tested it on macOS and even with different sort options.
Fully agree with your summary: SORT is ignored everywhere.

Thanks!
I'm just experimenting with dataviewjs - and think I might be able to come up with some code that can be used as a workaround, and can be customised for other people's needs...

I'm just experimenting with dataviewjs - and think I might be able to come up with some code that can be used as a workaround, and can be customised for other people's needs...

Close but no cigar.. I'm going to put it down for now...

It's worth noting the reason referencing file.name and similar do nothing is because file metadata is not added to tasks (just yet) - I am resolving this in the upcoming release (0.4.11).

It's worth noting the reason referencing file.name and similar do nothing is because file metadata is not added to tasks (just yet) - I am resolving this in the upcoming release (0.4.11).

Thanks! As an interim measure, might you accept a PR for the current docs being updated to note that the sorting doesn't work, please? To save others from also spending time working out what they had done wrong?
Unless the release is super imminent, of course...

I've found a workaround for now...
Suppose I wanted this effect:
```dataview
TASK
FROM #current
WHERE !completed
SORT file.name ASC
```

This gives the same output, except the filenames in the headings are in alphabetical order
```dataviewjs

let pages = dv.pages('#current')    // FROM #current
  .sort(p => p.file.name, 'asc');   // SORT file.name asc

// Loop over each page, and print its tasks
for (let page of pages)
{
   // Awful hack to get the individual page,
   // so we can later ask for its tasks
   let this_page = pages.where(p => p.file.path === page.file.path);

   dv.taskList(this_page.file.tasks.
      where(t => !t.completed));    // WHERE !completed
}
```

The fix is happening today, so a docs update is probably not required unless I have it push it back further.

This is awesome - huge thanks for fixing it!!!

Thank you so much for fixing this in the latest release!

Still seeing this issue on iOS 15.5 device. The following code does not order the tasks:
TASK
FROM "tasks"
WHERE !completed & important = true
SORT due DESC