failed non-null assertion on MaterialAccentColor.shade50

With MaterialAccentColor, the shade50 getter throws.  None of the 16 predefined accent colors actually define a 50 key.  :scream:
Example: limeAccent
Relevant(?) test
Its API docs indicate there shouldn't be a shade50: There are four valid indices: 100, 200, 400, and 700.  This aligns with the 2014 Material spec (scroll to bottom for palettes).
@willlarche

Looked into this a little, it isn't quite clear to me why there is a shade50 getter since there is no shade50 for accent color anywhere.
@HansMuller do you happen to have some more context on this?

Looks like the shade50 getter was added in https://github.com/flutter/flutter/pull/9174 PR 4 years ago, but I suppose no one used it. Maybe it is as simple as just removing the getter.

I think this is the origin of the shade50 getter: https://github.com/flutter/flutter/pull/10505. Not that it matters much. The accent colors are missing many of the 10 shadeNN getters; redAccent (defines 4 out of 10) is typical:
  static const MaterialAccentColor redAccent = MaterialAccentColor(
    _redAccentValue,
    <int, Color>{
      100: Color(0xFFFF8A80),
      200: Color(_redAccentValue),
      400: Color(0xFFFF1744),
      700: Color(0xFFD50000),
    },
  );

As @mockturtl  points out, this is in line with what was in the early Material Design spec the code was based on. I don't think it's essential to fix this now.

I tested this on the latest master and stable channel and the issue is reproducible

logs
Launching lib/main.dart on iPhone 12 Pro Max in debug mode...
Xcode build done.                                           25.7s
Connecting to VM Service at ws://<IP_ADDRESS>:55913/n-gy43Wj6XI=/ws
Reloaded 1 of 771 libraries in 2,150ms.

════════ Exception caught by widgets library ═══════════════════════════════════
The following _CastError was thrown building App(dirty):
Null check operator used on a null value

The relevant error-causing widget was
App
When the exception was thrown, this was the stack
#0      MaterialAccentColor.shade50
#1      App.build
#2      StatelessElement.build
#3      ComponentElement.performRebuild
#4      Element.rebuild
#5      BuildOwner.buildScope
#6      WidgetsBinding.drawFrame
#7      RendererBinding._handlePersistentFrameCallback
#8      SchedulerBinding._invokeFrameCallback
#9      SchedulerBinding.handleDrawFrame
#10     SchedulerBinding.scheduleWarmUpFrame.<anonymous closure>
(elided 4 frames from class _RawReceivePortImpl, class _Timer, and dart:async-patch)
════════════════════════════════════════════════════════════════════════════════
Application finished.
Exited (sigterm)

flutter doctor -v
[✓] Flutter (Channel stable, 2.5.3, on macOS 11.6.1 20G224 darwin-x64, locale en-US)
    • Flutter version 2.5.3 at /Users/flo/development/flutter
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 18116933e7 (3 weeks ago), 2021-10-15 10:46:35 -0700
    • Engine revision d3ea636dc5
    • Dart version 2.14.4

[!] Android toolchain - develop for Android devices (Android SDK version 31.0.0)
    • Android SDK at /Users/flo/Library/Android/sdk
    • Platform android-31, build-tools 31.0.0
    • Java binary at: /Applications/Android Studio.app/Contents/jre/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 11.0.10+0-b96-7281165)
    ! Some Android licenses not accepted.  To resolve this, run: flutter doctor --android-licenses

[✓] Xcode - develop for iOS and macOS
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Xcode 13.0, Build version 13A5212g
    • CocoaPods version 1.11.0

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 2020.3)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 11.0.10+0-b96-7281165)

[✓] VS Code (version 1.60.0)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.27.0

[✓] Connected device (4 available)
    • sdk gphone x86 (mobile)    • emulator-5554                        • android-x86    • Android 11 (API 30) (emulator)
    • iPhone 12 Pro Max (mobile) • 98CBBFB1-4069-4A28-B7F7-138911ACBE72 • ios            •
      com.apple.CoreSimulator.SimRuntime.iOS-15-0 (simulator)
    • macOS (desktop)            • macos                                • darwin-x64     • macOS 11.6.1 20G224 darwin-x64
    • Chrome (web)               • chrome                               • web-javascript • Google Chrome 93.0.4577.63

! Doctor found issues in 1 category.

[✓] Flutter (Channel master, 2.6.0-12.0.pre.657, on macOS 11.6.1 20G224 darwin-x64, locale en-US)
    • Flutter version 2.6.0-12.0.pre.657 at /Users/flo/fvm/versions/master
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision a61c57add6 (3 hours ago), 2021-11-08 21:37:48 -0800
    • Engine revision 162d8508f8
    • Dart version 2.15.0 (build 2.15.0-285.0.dev)

[!] Android toolchain - develop for Android devices (Android SDK version 31.0.0)
    • Android SDK at /Users/flo/Library/Android/sdk
    • Platform android-31, build-tools 31.0.0
    • Java binary at: /Applications/Android Studio.app/Contents/jre/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 11.0.10+0-b96-7281165)
    ! Some Android licenses not accepted.  To resolve this, run: flutter doctor --android-licenses

[✓] Xcode - develop for iOS and macOS (Xcode 13.0)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • CocoaPods version 1.11.0

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 2020.3)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 11.0.10+0-b96-7281165)

[✓] VS Code (version 1.60.0)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.27.0

[✓] Connected device (4 available)
    • sdk gphone x86 (mobile)    • emulator-5554                        • android-x86    • Android 11 (API 30) (emulator)
    • iPhone 12 Pro Max (mobile) • 98CBBFB1-4069-4A28-B7F7-138911ACBE72 • ios            • com.apple.CoreSimulator.SimRuntime.iOS-15-0 (simulator)
    • macOS (desktop)            • macos                                • darwin-x64     • macOS 11.6.1 20G224 darwin-x64
    • Chrome (web)               • chrome                               • web-javascript • Google Chrome 93.0.4577.63

! Doctor found issues in 1 category.

Thank you

I understand the logic behind the error but what does this mean from the Material design domain POV?  does this mean that shade50  should have been deprecated in a proper way long time ago?,  or the shade50 is yet to be added in the new versions and missing ?
if the first case I can submit a PR if yet to be added where I can find the new specs for MaterialAccentColor?

These colors are part of the 2014 (Material 1) spec and therefore won't be updated. I believe adding the shade50 getter was a bug and it should be deprecated/removed (assuming it doesn't cause any major breakages).
@Reekoooo feel free to create a PR that removes shade50


Steelseries Rival 650 Wireless Support

The Steelseries Rival 650 has yet to be supported beyond basic functionality on linux. I have one and would be willing to do any packet capturing necessary to get this device supported.

I agree, I have a 650 Rival and I'm happy to help out however I can

Fixed by #1420.


Error when using mhlo.dot with f64 tensors

The following matmul test fails to run with iree-run-mlir:
func @main(%a: tensor<1024x1024xf64>, %b: tensor<1024x1024xf64>) -> tensor<1024x1024xf64> attributes { llvm.emit_c_interface } {
  %c = "mhlo.dot"(%a, %b) : (tensor<1024x1024xf64>, tensor<1024x1024xf64>) -> tensor<1024x1024xf64>
  return %c : tensor<1024x1024xf64>
}

Error:
$ iree-run-mlir -iree-input-type=mhlo -iree-hal-target-backends=dylib-llvm-aot test.mlir -function-input=1024x1024xf64 -function-input=1024x1024xf64
I /iree/iree/tools/iree-run-mlir-main.cc:205] Compiling for target backend 'dylib-llvm-aot*'...
I /iree/iree/tools/iree-run-mlir-main.cc:308] Evaluating all functions in module for driver 'dylib'...
I /iree/iree/tools/utils/vm_util.cc:154] Creating driver and device for 'dylib'...
EXEC @main
E /iree/iree/tools/iree-run-mlir-main.cc:466] Failure for split at line #1: /iree/iree/modules/hal/module.c:683: INVALID_ARGUMENT; tensor element type mismatch; expected f32 (21000020) but have f64 (21000040); while invoking native function hal.buffer_view.assert; while calling import;
[ 1]   native hal.buffer_view.assert:0 -
[ 0] bytecode module.main:164 research/mlir/matmul.mlir split at line #1:1:1; Evaluating export function 0; Evaluating functions
ERROR running file (research/mlir/matmul.mlir): /iree/iree/modules/hal/module.c:683: INVALID_ARGUMENT; tensor element type mismatch; expected f32 (21000020) but have f64 (21000040); while invoking native function hal.buffer_view.assert; while calling import;
[ 1]   native hal.buffer_view.assert:0 -
[ 0] bytecode module.main:164 research/mlir/matmul.mlir split at line #1:1:1; Evaluating export function 0; Evaluating functions

The issue goes away when using f32 instead of f64. Seems like some assert is using f32 while all operations above uses f64. I've tried other backends, seems like to fail on all of them. This was tested using latest commit on main branch.

I think we have ways to demote from f64 to f32 now. So closing this for now. Please reopen if there is something more to follow up on these.


mne.SourceEstimate.data array

Hi, I really really hate to post general questions on GitHub Issues, but I don't know where else to go. Is there an MNE Python forum? I tried to join the mailing list but I don't think it was successful.
My current question is, what exactly is stc.data?
I know that it's a 2D array of vertices x time and that vertices could be voxels. But I'm not sure if the float values in that array are current density, and what are the XYZ coordinates for each of the 8000+ vertices if they really are voxels. If they are not voxels, then what are they? What units are the values found in stc.data?
We're working on processing EEG data using sLORETA method. We would like to move to MNE Python since using LORETA-KEY and EEGLAB is a pretty slow and manual process. What we’re interested in is getting the xyz coordinates and current density data as well as lobe location, just like the sLORETA Viewer shows, in an automated way. Is there any way we can do this in MNE?
Thanks,
Corey

As I mentioned on the mailing list, maybe a good start would be plot_object_sourceestimate.py that talks about:

what .data includes
what .vertices are
how these index a high-res surface
how to get the corresponding coordinates in Freesurfer RAS, MRI RAS, etc.
example of upsampling from these to the high-res surface

@corscheid would that help? Are there other things that would be good to add?
Then once this is in, eventually we could expand it to include VolSourceEstimate and finally MixedSourceEstimate.

@larsoner Yes, I think that would be very helpful. I'm not 100% sure what else would be good to add off the top of my head right now, but the more EEG-specific documentation (particularly from raw EEG data to source localization data and plotting) there is, the better, I think. I also spent a good bit of time wondering what a .fif file is, where they are expected to come from, and how all that works, coming from an EEGLAB/ERPLAB/sLORETA Viewer workflow.
Outside of using the sample data set and following the available MEG tutorials on the website, I'm a little bit lost in trial and error piecing everything together. Our workflow currently includes .cnt files and .set/.fdt and .txt files from EEGLAB and ERPLAB. My curiosity has been how to implement and automate all of these same steps in MNE Python for EEG data of a somewhat large set of subjects.
Thank you so much for your quick replies and patience!

maybe add these info here http://martinos.org/mne/stable/faq.html ?

I think there is too much information to cover for it the be appropriate for the FAQ

then add a page in section on "data structures and containers" in the
documentation.

My preference would be a plot_object_sourceestimate.py like we have for raw/epochs/evoked, or a plot_background_freesurfer.py. I fear "data structures and containers" is too general / broad.

@TommyClausner I think you have now all the knowledge to explain this.
can you take a stab at this? while you wait for us to review the other PR...

Hey @agramfort I appreciate your optimism ("all the knowledge to explain this") ;)
What I would do now is:

making plot_object_sourceestimate.py (guess this might work)
making plot_background_freesurfer.py - I know and used FreeSurfer a bit outside mne, however I have to dive a bit more into how exactly the steps in mne are - or are you really just interested in FreeSurfer and only FreeSurfer (like using "recon-all" and stuff) - and where which relevant data come from? (e.g. surf folder, labels folder, etc)

For FS just the parts we use, like high res mesh, decimated mesh, downsampling, upsampling, labels, annotations.

for plot_object_sourceestimate i imagine you explaining the logic of
stc.vertices and stc.data and how it relates to src[0]['rr'] to have
locations.

Thanks everyone for your efforts and replies. My colleague @deepagupta would be happy to reply here in the event of further questions or discussion regarding documentation or related MNE functions or structures we are using.

We have a bit of this in master now so I'm moving this to 0.18. @jasmainak if you feel like improving the plot_object_stc tutorial this issue has other concepts in it that should be included

@drammock is this one taken care of? If not, let's add to the documentation TODO list

I would say that this is not yet fully resolved.  But I'll cross-link it to #5944, add a note to the roadmap there, and close this one.


Context cancellation ignored causing heavy CPU usage

Bug Description
I believe I found an issue with how the cloud-sql-go-connector instance refresh functionality handles errors, or more specifically, cancelled context errors.
I have a process that runs as a long-running web server and uses the cloud-sql-go-connector to connect to postgres Cloud SQL instances. I noticed extremely high CPU usage after running a few tests and then deleting the Cloud SQL instance that it was connecting to. After doing some profiling and looking through the cloud sql connector code, I think I have a decent understanding of the issue (please correct anything that is wrong).
The fetchMetadata function attempts to Get the instance details using the sqladmin library here. Which as expected, if the instance has been deleted, returns an error here. Tracing that back a few more functions, I believe it is called from scheduleRefresh in this section of code. It appears if there is any error returned from the refresh, it immediately tries to schedule another one, but since the instance is deleted, it will just enter into an endless refresh loop and attempts to hold on to the last known good connection. Should this be able to handle unrecoverable errors (like deleted instances) and return more gracefully? At first I thought this was the primary issue, but to me it raised a larger question: why was the connector still refreshing in the background at all since I closed the dialer and connection (see example code below)?
The dialer looked to be cancelled properly here which propagated to the instance close and would cancel the internal context.
However, this line returns an error if the context was cancelled. And this code always treats all errors the same (by scheduling another refresh).
I believe this needs to check if the returned error is context.Cancelled, and if it is, just return. If this is accurate, I would love to submit a PR!
Example code (or command)
package main

import (
	"context"
	"fmt"
	"log"
	"net"
	"net/http"
	"time"

	"cloud.google.com/go/cloudsqlconn"
	"github.com/jackc/pgx/v4/pgxpool"
)

const (
	username = "postgres"
	password = "TODO"
	project  = "TODO"
	region   = "TODO" // e.g. us-central1
	instance = "TODO"
)

func main() {
	handler := func(w http.ResponseWriter, req *http.Request) {
		msg := "success"
		if err := selectOne(); err != nil {
			msg = err.Error()
		}
		w.Write([]byte(msg))
	}

	http.HandleFunc("/", handler)
	log.Fatal(http.ListenAndServe(":8080", nil))
}

func selectOne() error {
	ctx, cancel := context.WithTimeout(context.Background(), time.Minute*2)
	defer cancel()

	dsn := fmt.Sprintf("user=%s password=%s dbname=postgres sslmode=disable", username, password)
	config, err := pgxpool.ParseConfig(dsn)
	if err != nil {
		return fmt.Errorf("failed to parse pgx config: %v", err)
	}

	dialer, err := cloudsqlconn.NewDialer(ctx)
	if err != nil {
		return fmt.Errorf("failed to initialize dialer: %v", err)
	}
	defer dialer.Close()

	connectionName := fmt.Sprintf("%s:%s:%s", project, region, instance)

	config.ConnConfig.DialFunc = func(ctx context.Context, _ string, instance string) (net.Conn, error) {
		return dialer.Dial(ctx, connectionName)
	}

	conn, err := pgxpool.ConnectConfig(context.Background(), config)
	if err != nil {
		return fmt.Errorf("failed to connect: %w", err)
	}
	defer conn.Close()

	if _, err = conn.Exec(ctx, "select 1"); err != nil {
		return err
	}

	return nil
}

Stacktrace
n/a
How to reproduce

Create a Cloud SQL postgres instance in the GCP console
Run the above example code go run main.go (replacing the const values appropriately)
Run curl -XPOST localhost:8080 to trigger the db connection
Delete the Cloud SQL instance in the GCP console
Wait some amount of time (when the ephemeral cert expires, which I believe is 1 hour) and monitor CPU usage of the program

Environment

OS type and version: macOS 13.0 (this same issue occurs in a linux container deployed to a GKE cluster)
Go version: go version go1.19.2 darwin/amd64
Connector version: cloud.google.com/go/cloudsqlconn v1.0.1

@enocom and I chatted about this a bit and decided that this section:
https://github.com/GoogleCloudPlatform/cloud-sql-go-connector/blob/62a8c11073c2bdf1cfc09ec492c0a30bc54ce170/internal/cloudsql/instance.go#L303-L311
needs to be moved up ahead of the "immediate" reschedule (as of right now it only exits the "normal" reschedule path). We wanted to give you first crack at it @jault3 if you'd like.
It would be great to have a test for this as well if possible.

Awesome! I'll get started on a fix with a test

On our cloudrun application we saw this error once in a while.

rpc error: code = Internal desc = database read error: failed to connect to host=localhost<EMAIL_ADDRESS>database=vehicle: dial error (timeout: refresh failed: context deadline exceeded)

Perhaps related to this?

@liufuyang Cloud Run uses v1 of the proxy, so I think this is unrelated.
If you have a support contract, I'd recommend opening a case and asking them to look into those errors - sounds like a network connectivity problem.

@kurtisvg Thank you. Just to be clear, we didn't use the cloudrun's proxy, what we used is a db with external ip and run the go code in cloudrun with this repo's package to open proxy onto the db with IAM user.
Before creating support tickets, we are also thinking about doing these actions to help solving the dail/refresh error:

move the cloudrun application from us-west to us-east, as our db is in europe
switch from "external ip + proxy" setup to an "internal ip + proxy" setup (as we use IAM user so need the proxy to help with IAM user auth)

Do you see these actions could potentially help resolve this error on our side?
And do you think it is possible to use internal ip without any proxy but still uses IAM user login? (I am not sure if there is an easy way to get the IAM user password if we don't use proxy and connect to DB directly)

@liufuyang If you are using the go connector directly and not the /cloudsql unix socket, you can open a new issue here with as much detail as possible to help us diagnose.
I would need to peruse the code again to confirm, but context cancellation means that either you passed a context that timed out, or the default internal context for refreshes timed out.

Thanks a lot. We will try to perform some mitigation on our side such as connecting via private ip to see if it can help with the problem. If needed we can write it up on another issue page. Sorry for bringing some noise here.


Standardize all copyright/license headers

The SR source code has at least 3 different kinds of copyright messages. Ensure these are all uniform.

Closed since headers don't need to be updated, it turns out.


Application page for refresh

#70
Some more original writing from the previous post #77 .
It is barely working because I am not sure how I should use, or maybe should do, the async stuff because data returned from the server is empty until that happens. And right now, it is still empty. But I have made sure that everything has to work beside that.
One small problem is I was really trying to fix the compiler error so maybe there is some weird thing there but let's continue after this.
Checklist for completion:

[x] The add/edit flow needs to have full functional parity with current web app
[x] The list view also needs to include the accounts filter functionality using new AccountFilter component
[x] When deleting an application you must first verify that the app is not being used by an Account or MS Teams Tenant

#70
Some more original writing from the previous post #77 .
It is barely working because I am not sure how I should use, or maybe should do, the async stuff because data returned from the server is empty until that happens. And right now, it is still empty. But I have made sure that everything has to work beside that.
One small problem is I was really trying to fix the compiler error so maybe there is some weird thing there but let's continue after this.

Cool cool. I'll take a look and provide feedback/help :)

Thanks. Some page will be blank because the return is blank, so no methods like .map() for array, thus nothing shows up. But it works if that is.

Thanks. Some page will be blank because the return is blank, so no methods like .map() for array, thus nothing shows up. But it works if that is.

Yep—I can point you in the right direction, no worries. Hang tight. I'll submit a review on this PR with notes etc on how to get moving again.

@khanghugo if you’re using vscode the extensions config has a list of recommended plugins for linting, prettier and typescript 👍. Definitely make sure you have all these installed for the best dev workflow.

This looks like it is what I really want now, unless I forgot something or you see something.
I was spending half an hour fixing implicit cast, it is getting tiresome. Compilers are simply my enemies. But at least I have a good laugh out of it.

if you’re using vscode the extensions config has a list of recommended plugins for linting, prettier and typescript

I was using VSCodium for a while but I cannot get LSP to work on my hobby project (this is entirely my fault as I am using a non standard system). Then I realize that VSCode is unable to find function definitions natively. That is when I just put it off and use something else that just works, which is Sublime Text, and I am comfortable with using ST for simple text editing for a while already. I will definitely give VSCode another chance if those extensions are cool enough.

https://github.com/jambonz/jambonz-webapp/blob/da0d2fe171606a6ac23283c14bb122d165d77837/src/containers/internal/views/applications/form.tsx#L173-L179
This is not what I want, let me fix that.

This looks like it is what I really want now, unless I forgot something or you see something.
I was spending half an hour fixing implicit cast, it is getting tiresome. Compilers are simply my enemies. But at least I have a good laugh out of it.

if you’re using vscode the extensions config has a list of recommended plugins for linting, prettier and typescript

I was using VSCodium for a while but I cannot get LSP to work on my hobby project (this is entirely my fault as I am using a non standard system). Then I realize that VSCode is unable to find function definitions natively. That is when I just put it off and use something else that just works, which is Sublime Text, and I am comfortable with using ST for simple text editing for a while already. I will definitely give VSCode another chance if those extensions are cool enough.

Cool cool. I’ve found vscode to be good as long as you install the plugins. Typically it’s good about suggesting them too.
I’ll be able to give you another proper review here maybe tomorrow. If not then Monday for sure. Hang tight. Once this one is in you’ll breeze through the rest 🙂.
How do you like typescript? This is my first time really giving it a proper implementation 🤔.

How do you like typescript?

My problem with Typescript right now is I have yet to have a proper IDE for it. It is just a pain for me right now just go back and forth between definition to know what I am dealing with. With that, I am all in for any kind of safety as it enforces me to always check things.

This is my first time really giving it a proper implementation thinking.

Your implementations are great. For the most part, I just mirror what you did. There wasn't any problem working with what is given.

How do you like typescript?

My problem with Typescript right now is I have yet to have a proper IDE for it. It is just a pain for me right now just go back and forth between definition to know what I am dealing with. With that, I am all in for any kind of safety as it enforces me to always check things.

This is my first time really giving it a proper implementation thinking.

Your implementations are great. For the most part, I just mirror what you did. There wasn't any problem working with what is given.

VS Code is pretty great with typescript 🙂.

@khanghugo I also just added a new little html structure so we can compact the webhook fieldsets a bit. Once this PR is merged we can go back in and make the change on this form as well 👍 . Looks like this:

Commit on my PR branch is here: https://github.com/jambonz/jambonz-webapp/pull/80/commits/0de64ac23983cc7bd19474c3076deb1b6eb3427b

Thanks for the feedback. Let me rebase this first then see.

Thanks for the feedback. Let me rebase this first then see.

There's nothing to rebase since the base refresh branch hasn't been updated yet. I just updated that screenshot though because I made some more UI changes to the forms for grouping of fieldset elements. I think it's more clear now.

@khanghugo Another thing we will need for parity is the account filter selector on the applications list view. I'm going to make this out of scope for this PR and I'll add an issue specifically for this to be tackled after this add/edit flow is complete 👍

@khanghugo I merged my PR branch. Whenever you end up rebasing just take all your changes on the conflicted applications index file and you should be good 👍

@khanghugo The reusable account filter looks like this. I have a PR open for it so when you're ready we can merge that and then you can rebase again and slot it into your work here. The implementation is straight forward so hopefully it makes sense when you add it. If not, just ping me and I can help 👍
https://github.com/jambonz/jambonz-webapp/pull/82

@khanghugo I have a working list of feedback for the latest on this branch but I will wait until you request another review. But I did want to pose one change in particular now regarding the application list index and how to handle the state between fetch and delete. Check this diff here which has one commit of changes I made on top of the latest from this branch you are working on here. This is the approach I'd like to see here:
https://github.com/jambonz/jambonz-webapp/compare/refresh-application...refresh-application-index-example

@khanghugo Your last commit is off base. We don't want any of those changes to the account-filter component—it should not use the selector component. Do you have time to catch up on a chat?

Sure, I can revert that change on Account Filter.
Where do you want to start a chat? I have Slack. The email is<EMAIL_ADDRESS>

<EMAIL_ADDRESS>
I'll send a google meet if that works :)

<EMAIL_ADDRESS>
I'll send a google meet if that works :)

Invite sent hop on duder :)

It says Getting ready for the past 2 minutes already. Let me try again.

This commit has all the requested changes. Let me probe around a bit and see if there is anything wrong.

This commit has all the requested changes. Let me probe around a bit and see if there is anything wrong.

Cool I'll take a look. I have another idea brewing I'll run by you in a different thread/PR or something as well :)

Hey looks like that api server update was merged. I think Dave mentioned to
hold off on that until we're ready with the webapp refresh so I'm not sure
what we want to do from here? I suppose I should not have approved the PR
so I might have given the wrong implication there.
—BK

Brandon Lee Kitajchuk*
kitajchuk.com https://kitajchuk.com

On Wed, Aug 17, 2022 at 3:48 PM Lê Hàn Minh Khang @.***>
wrote:

@.**** commented on this pull request.
In src/containers/internal/views/applications/form.tsx
https://github.com/jambonz/jambonz-webapp/pull/79#discussion_r948506865:

} else {

 postApplication(payload)

   .then(() => {

     toastSuccess("Application created successfully");

     navigate(`${ROUTE_INTERNAL_APPLICATIONS}`);

   })

   .catch((error) => {

     toastError(error.msg);

   });

}
};

useEffect(() => {
let ignore = false;

if (accounts && !accountSid) setAccountSid(accounts[0].account_sid);

Yea I can have it with brackets for consistency sake.
—
Reply to this email directly, view it on GitHub
https://github.com/jambonz/jambonz-webapp/pull/79#discussion_r948506865,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AADLDN534RJZ2VEUJDSNHTTVZVT47ANCNFSM56MFRMUQ
.
You are receiving this because you commented.Message ID:
@.***>

Sorry for that. I have made a PR to revert the change.

Heh, we'll see what Dave says about it. Easy enough to revert I suppose
even if it's an admin force push to main to reset the timeline—which this
might be preferential if we don't want the extra cruft in the timeline of
the main branch.
—BK

Brandon Lee Kitajchuk*
kitajchuk.com https://kitajchuk.com

On Wed, Aug 17, 2022 at 3:57 PM Lê Hàn Minh Khang @.***>
wrote:

Sorry for that. I have made a PR to revert the change.
—
Reply to this email directly, view it on GitHub
https://github.com/jambonz/jambonz-webapp/pull/79#issuecomment-1218581065,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AADLDN7SPN5DPGZB67OPZYTVZVU6LANCNFSM56MFRMUQ
.
You are receiving this because you commented.Message ID:
@.***>

@khanghugo Here's a diff that shows decoupling the effects. I did some other stuff like moving the fetches for applications and accounts up to the edit component. I've been preferring this approach (I did this with the account edit form as well to pass applications down) but honestly it's not necessary and maybe just a preference.
https://github.com/jambonz/jambonz-webapp/compare/refresh-application...refresh-application-effects-decouple

That is a nice addition. The add page will now look less empty and form will do less stuffs.

I really like this change. It makes it clear what is expected rather than spitting out only if things happen. Also, the page looks less empty.

I really like this change. It makes it clear what is expected rather than spitting out only if things happen. Also, the page looks less empty.

Killer! If you’re ready I’ll give this a final review tomorrow and hopefully we’re ready to merge after that 🙂🤘

It should be ready. I don't think I can really eye the small details that good since I am the one making it and thinking it is okay to go.

@khanghugo I'm going to go ahead and merge this one because I made some changes locally on the refresh branch that will require adding a couple classNames to the form here. This way I can merge, rebase and apply then push all latest up to the base refresh branch 👍

@khanghugo I'm going to go ahead and merge this one because I made some changes locally on the refresh branch that will require adding a couple classNames to the form here. This way I can merge, rebase and apply then push all latest up to the base refresh branch 👍

@khanghugo Alrighty all merged and rebased so all the latest and greatest is on the base refresh branch for when you're ready to tackle your next issue 👍

Thanks for rallying all the back-and-forth with me

I am hoping that you are the one that doesn't mind the back and forth. I am all in for suggestions but it always come from you and that is what I hope you won't mind.

I would recommend the Speech form next :)

Noted

I'm going to go ahead and merge this one

Yea, I wasn't online earlier to do this. It is alright. I will catch up and smash it myself next time.

Thanks for rallying all the back-and-forth with me

I am hoping that you are the one that doesn't mind the back and forth. I am all in for suggestions but it always come from you and that is what I hope you won't mind.

I would recommend the Speech form next :)

Noted

I'm going to go ahead and merge this one

Yea, I wasn't online earlier to do this. It is alright. I will catch up and smash it myself next time.

Ha, I don't mind at all. I enjoy the collaboration and as we can see we get the results: we ended up with some great improvements to how we handle forms for the app which is great :)


New theme

Simple Blox

update Issue title

Hello @okabrionz and thanks for your theme submission.
On first look I have identified the following issues:

Your screenshots do not have the correct dimensions. See here
Please use a JPG in your theme's README and not a webp since that will not show up in browsers that do not support this format without a special plugin.
Your README is a bit confusing. Parts of it appear to be copy-pasted from the README of  the Hugo Artists theme. You need to make the README descriptive of your Simple Box theme.

Please look into the above so that I can review your theme further.

Hello @okabrionz and thanks for your theme submission.
On first look I have identified the following issues:

Your screenshots do not have the correct dimensions. See here
Please use a JPG in your theme's README and not a webp since that will not show up in browsers that do not support this format without a special plugin.
Your README is a bit confusing. Parts of it appear to be copy-pasted from the README of  the Hugo Artists theme. You need to make the README descriptive of your Simple Box theme.

Please look into the above so that I can review your theme further.

Screenshot dimensions done! :thumbsup:
Screenshot on README done! :thumbsup:
I only can write like that. :satisfied:

I only can write like that. 😆

Ok. Then in this section of your README please replace the phrase Artists Theme with Simple Box, to avoid confusing users.
Other than that your Example Site generates fine when I test it with the Hugo Themes Site Build Script. 👍
So please do the above correction in the README and I will mark your theme as ready to be added to the website.
Thanks!

Ok. Then in this section of your README please replace the phrase Artists Theme with Simple Blox Theme, to avoid confusing users.

Well done, Mate!
This is only the beginning. I want to develop more theme for hugo.

@okabrionz Thanks for making the change.
@digitalcraftsman This theme looks ready for adding it to the website.

Hello @okabrionz,
thank you for sharing this theme with the Hugo community. I was about to add the new themes (including yours) to this repository. Is there any reason why you closed issue?

Is there any reason why you closed issue?

I think it was added. Then, I close the issue. I will reopen then 👍

Hey Oka,
Your theme should be listed soon on the themes site. Furthermore, I'll promote your theme on Hugo's official Twitter account.


Warning when using animate_nodal_displacement

C:\Users\USER\.conda\envs\pymapdl\lib\site-packages\ansys\mapdl\reader\rst.py:906: UserWarning: The ``nangles`` kwarg is depreciated and ``n_frames`` should be used instead.
  warnings.warn('The ``nangles`` kwarg is depreciated and ``n_frames`` '

Related to #904

This should be moved over to ansys-mapdl-reader

I agree.


Direct app exec

The DirectAppExec command was copied directly from AppCommand.m. The only difference in this command is that the RequestRouter.m executes it on the HTTP thread rather than on the main UI thread. This is required in my application because running some commands on the UI thread can cause deadlocks.

It sounds like DirectAppExecCommand is a total copy-and-paste of AppCommand. In that case why not just use AppCommand?

As I say in the code comments for DirectAppExecCommand:
//  NOTE: This code was copied directly from AppCommand.m. The only difference in this command is that the
//        RequestRouter.m executes it on the HTTP thread rather than on the main UI thread.
There are certain situations in my app where executing a command on the main UI thread can cause a thread deadlock. In these situations I need to execute the command on “some other thread”, and the HTTP thread seemed easy and convenient. If you don’t think others need this kind of functionality, then you can skip this pull request. I’ve just been trying to get ALL my Frank modifications pushed into the main project on GitHub.
Thanks,
Martin
From: Pete Hodgson<EMAIL_ADDRESS>Sent: Monday, January 26, 2015 12:19 PM
To: TestingWithFrank/Frank
Cc: Taylor, Martin
Subject: Re: [Frank] Direct app exec (#38)
It sounds like DirectAppExecCommand is a total copy-and-paste of AppCommand. In that case why not just use AppCommand?
—
Reply to this email directly or view it on GitHubhttps://github.com/TestingWithFrank/Frank/pull/38#issuecomment-71509128.

What I was getting at is if it's the same implementation, why not just ditch DirectAppExecCommand and do the following in FrankServer.m:
[frankCommandRoute registerCommand:[[[AppCommand alloc] init]autorelease] withName:@"direct_app_exec"];

Either way, I'm not really happy with the hard-coding in RequestRouter. If you can move the thread-jumping into AppCommand and make it configurable via params (rather than on a separate API endpoint) then I'd be happy to pull it in.


How to support HMR with Pothos

I couldn't find any examples of this, so testing the waters a bit. We have a pretty huge module graph, to the point that process starts/restarts take a long time. So I started looking into using chokidar to purge modules from the import cache, it was working pretty well but I hit a wall with Pothos.
It seems the builder pattern is a little at odds with what I'm trying to achieve, because if a module with some gql types in is re-executed, Pothos will error.
I can't see a current workaround, but I'm wondering how viable it is to somehow support putting the builder into a mode which allows redefinition of types in a robust way.

Yeah, this is definitely not easy with the builder pattern.  I don't know how your invalidation works, but the pattern used here: https://github.com/hayes/svelekit-graphql-test/blob/main/src/graphql/builder.ts. would be a good place to start.
Basically, if you dynamically import the file that generates the schema into the builder class (this creates a circular dependency).
The effect if this is that, the file that build the schema generally needs to import every file that makes up the schema, so it will become invalidated when anything in the schema changes.  Normally the file that creates the builder would not be invalidated, but if it has a dynamic import of the build schema, it should also be invalidated, which should end up re-building the entire schema on every change.   Obviously this isn't perfect, but its the best option I have come up with for this sort of builder pattern

Interesting, I'll give that a try


Push workflow for macOS update/upgrade via MDM failed

I seem to be having an issue where the MDM workflow is failing on all clients I spot check (macOS 13.5, 13.6, 14.0). Failover to user authentication is working as expected.
We are using super 4.0.1 and Jamf Pro 11.0.1 with the new software update experience. I've attached a (slightly sanitized) verbose super.log and TXT of our configuration profile. I'm at a loss at the moment, so any guidance/help is greatly appreciated.
super.log
super.txt

Unfortunately Slack isn't an option for me while at work, but I completely understand. I'll review what you sent and will see if I can get help elsewhere.

Saw this was re-opened, so I'll share this update. I set up a new API role for the legacy SU and reverted back to the old SU in Jamf. super is now working without issue. We will likely wait for the new SU to lose the Beta tag before trying it again.

As long as you plan on using super for your updates/upgrades, there is no benefit for using the new Beta method.


Consider not using callback_mutex_ in VsyncWaiter if possible.

In the current implementation, callback_mutex_ is used to ensure thread safety when accessing callback_ or secondary_callbacks_ in VsyncWaiter. However, in most platform implementations, VsyncWaiter::FireCallback is called on the UI thread, which means that callback_ and secondary_callbacks_ will only be accessed on the UI thread. It seems that we can ignore callback_mutex_ in this case.

The linked issue was moved to WIP status because we didn't have enough evidence that the mutex was actually causing an issue. If the mutex is not necessary, let's remove it instead of conditionally avoiding acquiring it. But, we should still gather evidence that this mutex is causing an issue. And, if it is, figuring out the source of the contention.


Datalist_file link broken in tutorial notebook auto_runner.ipynb

Describe the bug
bug found in
https://github.com/Project-MONAI/tutorials/blob/main/auto3dseg/notebooks/auto_runner.ipynb
After the Hippocampus dataset is downloaded, the datalist_file is defined as:
datalist_file = os.path.join("..", "tasks", "msd", msd_task, "msd_" + msd_task.lower() + "_folds.json")
This is supposed to be located here:
'../tasks/msd/Task04_Hippocampus/msd_task04_hippocampus_folds.json'
however the file is never created and the path with the dataset paths is not dumpt in there as in other example notebooks. As a consequence, autorunner fails to run and generates the following error:
ValueError: Datalist file is not found ../tasks/msd/Task04_Hippocampus/msd_task04_hippocampus_folds.json

Hi @alessando-guida, did you clone the whole repo? I think the "datalist_file" is located here instead of automatically downloading.
Hope it helps, thanks!


Failed when trying to create Security Policy with basic auth

Description:
I can't create a SecurityPolicy for testing with basic auth.
Repro steps:
I'm following the https://gateway.envoyproxy.io/latest/user/basic-auth/ script and I can't apply the Create a SecurityPolicy step.
I tested with versions v1.0.0-rc.1, latest and v0.6.0.
Environment:
Kubernetes version: 1.27.8 - GKE
Chart: gateway-helm-v0.6.0
APP Version: v0.6.0
Logs:
Error from server (BadRequest): error when creating "STDIN": SecurityPolicy in version "v1alpha1" cannot be handled as a SecurityPolicy: strict decoding error: unknown field "spec.basicAuth"

cc @zhaohuabing

kubectl explain SecurityPolicy --recursive
explain.txt

@wlopes39 this feature was implemented later, please use helm install eg oci://docker.io/envoyproxy/gateway-helm --version v0.0.0-latest -n envoy-gateway-system --create-namespace
to test this

I tested this out and it works, the issue you are most likely hitting is that you may have installed v0.6.0 using helm, and then installed v0.0.0-latest using helm again.  helm unfortunately doesnt update CRDs so we were left with older CRDs

Hello,
That's exactly what I did. I will redo the tests tomorrow.
Thank you very much for your attention.

It worked to install the v0.0.0-latest version directly. Thanks


[ToolbarTitle] inconsistency

I'am willing to improve ToolbarTitle, I need your help to know what to do.
Issues:

ToolbarTitle used outside a ToolbarGroup is not of the same color as in a ToolbarGroup. Is that supported? What should be the behavior.
ToolbarTitle is not aligned correctly when put in ToolbarGroup. Should I add padding-left to it, or padding-right to the other elements?
Would it be acceptable to have a way to center the title?

@cgestes:

ToolbarTitle used outside a ToolbarGroup is not of the same color as in a ToolbarGroup. Is that supported? What should be the behavior.

Not sure what you mean. It makes sense for ToolbarTitle to inherit the styles of the ToolbarGroup when it is declared inside a ToolbarGroup. That should be the expected behavior, right?

ToolbarTitle is not aligned correctly when put in ToolbarGroup. Should I add padding-left to it, or padding-right to the other elements?

If it's only a matter of moving it over by a few pixels, then I would say let's leave that up to the developer as to how they wish to style (by overriding the inline-style of ToolbarTitle).

Would it be acceptable to have a way to center the title?

I don't see why not. But I'm wondering if it's unfeasible to provide a standard way to do this -- considering the large variety of layouts a toolbar can possibly have. As a developer, if I know the dimensions of my toolbar and the items that I'm putting inside it, then I should be able to center the title easily right?
Closing this issue for now as it's been sitting for quite a while. Feel free to comment!


[druid] Updating refresh logic

Though the term "refresh" is somewhat vague from a Druid metadata perspective I sense this translates to create or update. Previously we were creating or updates Druid columns but only creating Druid metrics when the Druid metadata was synced/refreshed.
This PR ensures that refreshing is consistent for both Druid columns and metrics and specifically addresses the following:

Removes redundancy by only controlling metric specifications within the DruidMetric class. Previously there was somewhat duplicate logic for both the DruidColumn and DruidMetric class.
Renames generate_metrics with refresh_metrics to imply that we're both creating and updating.
Updates the SQL filters to use IN rather than a series of ORs.
Added metric creation for float types.
Adds the missing migration for creating Druid uniqueness constraints to the columns and metrics tables which were added in https://github.com/apache/incubator-superset/pull/3978. Note to avoid this MySQL issue the metric_name column was reduced from 512 to 255 characters.
Corrects the --merge options for the refresh_druid command, which should be a flag (true/false) rather than an option.
Note I didn't want to change the structure of get_metrics in terms of checking whether said metric already exists to ensure consistency with SQLA, hence why the merging logic is handled in refresh_metrics.

@fabianmenges I only added the missing Druid migrations however I believe there are additional migrations from your PR (https://github.com/apache/incubator-superset/pull/3978) which are missing for the following tables:

table_columns
tables

to: @mistercrunch @Mogball

Codecov Report

Merging #4655 into master will increase coverage by 0.11%.
The diff coverage is 89.47%.

@@            Coverage Diff             @@
##           master    #4655      +/-   ##
==========================================
+ Coverage   71.25%   71.37%   +0.11%
==========================================
  Files         190      190
  Lines       14916    14907       -9
  Branches     1102     1102
==========================================
+ Hits        10629    10640      +11
+ Misses       4284     4264      -20
  Partials        3        3

Impacted Files
Coverage Δ

superset/cli.py
48.38% <ø> (ø)
:arrow_up:

superset/connectors/druid/views.py
68.02% <0%> (ø)
:arrow_up:

superset/connectors/druid/models.py
78.79% <100%> (+2.44%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fc47729...36bccde. Read the comment docs.

@mistercrunch so you recall if the constraint which existed previously was added manually? As far as I can tell this constraint never existed and thus the upgrade/downgrade logic should be sound.

Can't recall creating it. Could also be that it failed half way through before or timed out and got this error the next time around... Dunno.


Remove M from config file

M should be calculated from Pressure and Temperature.
Remove setting in modelConfiguration/environmentVariables.config and calculate immediately after Pressure and Temperature are set or constrained. It should still be output as one of the environment variables (if possible).

ROOFOPEN should have two values only ON or OFF. Now it is NOTUSED or 0, which is a bit strange.

#227 fixes the ROOFOPEN part of this issue.


I tried to change the camera resolution, but the mediapipe window appear to be same. Are there any settings in the code where I can change the input resolution, frame rate?

I tried to change the camera resolution, but the mediapipe window appear to be same. Are there any settings in the code where I can change the input resolution, frame rate?
Originally posted by @PinkMediaGroup in https://github.com/wongfei/ue4-mediapipe-plugin/issues/2#issuecomment-888657918

Plugin uses cv::VideoCapture inside (see https://github.com/wongfei/mediapipe/blob/unreal/mediapipe/unreal/ump_pipeline.cc#L188)
When setting ResX/ResY/Fps ensure your camera actually supports that resolution
Also try different CaptureApi values (same as cv::VideoCaptureAPIs https://docs.opencv.org/3.4/dc/d3d/videoio_8hpp.html)
cv::CAP_DSHOW -> 700
cv::CAP_MSMF -> 1400


doc: improve context doc

What type of PR is this?

Check the PR title.

[x] This PR title match the format: <type>(optional scope): <description>
[x] The description of this PR title is user-oriented and clear enough for others to understand.

(Optional) Translate the PR title into Chinese.
(Optional) More detailed description for this PR(en: English/zh: Chinese).

en: improve context doc
zh(optional): 完善 context 的文档
(Optional) Which issue(s) this PR fixes:

PATL @GuangmingLuo


Added instruction for forcefully starting the tour every time

As a developer, I have faced this issue first hand. I wasn't able to see the popups no matter what I do!
I think for debugging purpose, developer will need to see the tour every time on page load. Setting this both params to true does the job.

@ousram please can you port these changes to develop?


Reference organisms and BCOs for their proteomes, genomes

These are the reference proteomes and their genomes we are bringing into data.argosdb.org for HIV, Salmonella, Marburg, SARS-CoV-2, Influenza A.  We will add more references under this node within the next 3 months based on input from Sergei and Keith. I just wanted to get started. So in a week if you go to beta-data.argosdb.org you will find downloads for these with a README in form of a BCO where you can see why they were chosen. We can always replace them with something else if there is a better option.
I used https://proteininformationresource.org/rps/data/current/75/rpg-75.txt to find the reference Salmonella from the largest group and we can bring in representatives from the smaller groups also into argos later to show any assembled genomes in a phylogenetic tree with them. For viruses we are using https://proteininformationresource.org/rps/viruses/data/current/95/rpg-95.txt . The proteome clusters are updated every couple of months by PIR and UniProt. For algorithm see https://pubmed.ncbi.nlm.nih.gov/27153712/ and https://pubmed.ncbi.nlm.nih.gov/21556138/.

UP000002241	11706	HV1H2	Human immunodeficiency virus type 1 group M subtype B (isolate HXB2) (HIV-1)
UP000001014 Salmonella typhimurium (strain LT2 / SGSC1412 / ATCC 700720) also known as Salmonella enterica subsp. enterica serovar typhimurium strain LT2.
UP000464024 2697049	 SARS2	Severe acute respiratory syndrome coronavirus 2 (2019-nCoV) (SARS-CoV-2)
UP000180448	33727	MABVM	Lake Victoria marburgvirus (strain Musoke-80) (MARV)
UP000009255	211044	I34A1	Influenza A virus (strain A/Puerto Rico/8/1934 H1N1)

I have intentionally left out HCV for now.

For SARS we need to do this one also https://www.fda.gov/medical-devices/database-reference-grade-microbial-sequences-fda-argos/fda-argos-sars-cov-2-reference-grade-sequence-data

Flu reference NGS file email to Joe, Pond team etc- can you please show James how to do QC on HIVE? He can start with Influenza A example. I am cc-ing Sergei to let them know what we are trying out. If they are also doing anything similar with Flu A then we can compare results. Ccing Robert as he mentioned Flu A should be there in Feb release.
Influenza A virus (A/Puerto Rico/8/1934(H1N1)) NGS data: https://www.ncbi.nlm.nih.gov/sra/ERX2154267[accn]
README/BCO text that James will need: List of SRA IDs were retrieved using search string in SRA "txid211044[Organism:exp] ". The SRA ID was selected based on NCBI search filters Source: RNA, Type: genome, Library layout: paired, Platform: Illumina.
File is in cram format and needs to be changed to bam or fastq to use in HIVE.
This project might help us get additional NGS files that ARGOS can use. "This project aims to sequence the genomes of RNA viruses in the National Collection of The NCPV preserves well-characterised, authenticated human pathogenic viruses in a secure facility, and supplies the agents or nucleic acids derived from them to the scientific community. The genomes sequenced within this project will be a valuable additional resource that will also be made available to the scientific community."

Complete - Closed


Fix service promise serialization (resolves #844)

Resolves #844

@benedictpaten can you squash down? For some reason this shows two commits.

Yeah, not sure what happened.. fixing now.

Commit message is wrong. Should be
Fix service promise serialization (resolves #844)

Adds a test in toil.test.jobServiceTest.testServiceSerialization which now passes
illustrating the issues.

Ideally we'd have two commits pushed independently. First commit adds test. Jenkins build fails. Second commit fixes tests. Build succeeds. @cket has this down to an art.

And while you are at it, rebase on master since branch is now out of date.

Don't understand this failure. @hannes-ucsc - is this flappy?

I personally think this is good to go.

This is the test @benedictpaten was referring to:
http://jenkins.cgcloud.info/job/toil-pull-requests/1233/testReport/junit/src.toil.test.sort.sortTest/SortTest/testAwsMesos/

Tracked here: https://github.com/BD2KGenomics/toil/issues/845

Continued in #846


I really love your work, however

I really love your work, as I said earlier but why don't you add the other layers, (Batch Normalization, Activation, Dropout, Zero Padding 2D, Max Pooling 2D), or at least package your code?
I am ready and willing to contribute with you, if you want..

Thank you for your suggestion. Max Pooling 2D is implemented.
I think the other layers are somewhat annoying if they are visualized.
One solution is to add these information (e.g. activation or bn) to the text under each layer.
I had this idea before but not implemented. I'll try later.

My bad, for mentioning something that was already implemented 😄
Seems like you know that it easy, do it man and package. You are hindering your work this way


removed 5 from network status

I'm using your next branch
I noticed there is no network status of 5.
https://github.com/apollographql/apollo-client/blob/main/docs/shared/query-result.mdx
A number from 1-8 (1 = loading, 2 = setVariables, 3 = fetchMore, 4 = refetch, 6 = poll, 7 = ready, 8 = error) corresponding to the detailed state of your network request. Includes information about refetching and polling status. Used in conjunction with the notifyOnNetworkStatusChange prop.
Thanks for your work

Excellent. Thank you!


Scollify with angular2

Hi,
This is more of a question then an issues, but is scrollify available for angular2? Like is there a ts or js package that I can go ahead and import into my project?
Thank you,
Filipe

I haven't tried Scrollify with angular2 but you can import and use Scrollify in a standard commonJS way. Like this:
var $ = require('jquery');
var scrollify = require('jquery.scrollify');

$(function() {
	scrollify({
		section:".panel"
	});
});

Let me know if that helps.

@lukehaas Thank you that seems to work, just another quick question, when the width of a section to be higher the the browser is there a way to preventing it from snapping onto the next section before you can see the end of the this bigger section?

Guessing you mean height rather than width?
Scrollify will allow you to scroll to the bottom of long section as long as scrollbars is not set to false.


[Feature][st-engine] Support for transform-v2 API

Purpose of this pull request
Reference #2678
Release binary package:
- Move engine starter jar from lib/ to starter/ dir
- Outpout seatunnel-transforms-v2.jar to lib/ dir
Maven modules:
- Add seatunnel-transforms-v2 module
- Add seatunnel-transforms-v2-e2e module
Engine Starter:
- Add lib/ to task execute classpath
ST-Engine:
- Support for Split、Replace、Filter transform
E2E:
- Copy seatunnel-transforms-v2.jar into container lib/ dir
- Improve get project root path for e2e test module
Check list

[x] Code changed are covered with tests, or it does not need tests for reason:
[ ] If any new Jar binary package adding in your PR, please add License Notice according
New License Guide
[ ] If necessary, please update the documentation to describe the new feature. https://github.com/apache/incubator-seatunnel/tree/dev/docs

@EricJoy2048 @ashulin @Hisoka-X @ic4y @CalvinKirs tx. PTAL

@TaoZex @TyrantLucifer @liugddx   th.  PTAL

@EricJoy2048 Are we should support repartition type transform in this version?

@EricJoy2048 Are we should support repartition type transform in this version?

I suggest to add the support of repartition transform in the subsequent plans.


Markdown code block does not render jsx properly

In the wiki of Azure DevOps, if I create a block of code and label it jsx, the jsx content does not render properly.
In the example below you may see that Github renders it properly, meaning the keywords are colored appropriately. With Azure DevOps starting from the fourth line (return ;) the text is all colored black even the last const keyword.
export const getStatusImage = status => {
  switch (status) {
    case Status.GOOD:
      return ;
      break;
    default:
      return ;
      break;
  }
};
const dummy = "DUMMY";

From Azure DevOps:

@DavidHenri008 Thank you for reporting this. Do you believe it is a documentation error? If so can you let me know the URL of the article so I can forward this feedback to the author? Is it this one?
If you are reporting a bug or issue with the product (sounds like an issue in the syntax highlighting?), please file an issue here: https://developercommunity.visualstudio.com/spaces/21/index.html
Thank you.

@DavidHenri008 Thank you very much for the feedback.


Feature Request: Open today's daily note

Could you please describe what you mean with opening todays daily note?
How am I supposed to find the daily note, does it have a special name format (different from the other notes)?
The same thing for #12.

That's a great question.
The location/name of daily notes can be customized, but Obsidian has a built-in command called Daily notes: Open today's daily note
Maybe the better approach would be to allow folks to define custom commands that point to an obsidian:// URI. That way folks can add custom obsidian commands to Raycast using one/more of:

obsidian's official URI scheme: https://help.obsidian.md/Advanced+topics/Using+obsidian+URI
https://github.com/deathau/command-uri-obsidian
https://github.com/Vinzent03/obsidian-advanced-uri

Thank you for the detailed answers.
I will try to think of a nice way to implement this and will let you know when I came up with a solution. The details your provided will definitely help.


[#548] Add Authentication tests into the Test Scenarios pipeline

Addresses # 548
Note: The following variables are required for these new Authentication tests.

BffnEchoSkillBotDotNetSTAppId (AppId used for the SingleTenant DotNet EchoSkill bot)
BffnEchoSkillBotJSSTAppId (AppId used for the SingleTenant JS EchoSkill bot)

Description
This PR updates the Test Scenarios pipeline, adding support for the new Authentication tests.
Note: The configureConsumers.yml has been moved into a powershell script file, due to the number of characters exceeding supported the length of the Task.

Detailed Changes

Updated the configureConsumers.yml file, moving the script functionality into a separated file, parameterizing the required values, and also adding the functionality to retrieve the AppId from an MSI resource.
Added new Authentication stage, targeting all tests that have the Authentication TestCategory.

Testing
The following images show the Test Scenarios pipeline and test project working as expected.

I'll change the comment in the PR's description to make clear that those variables need to be set in the Test pipeline.

Done, thanks!

/promoted 588


Changing the .testing domain/TLD to another private domain

After a previous CRC install, I realized the dashboard will not be reachable on a private domain .testing. I followed this document: CRC_doc and made the changes in the file(/etc/NetworkManager/dispatcher.d/99-crc.sh) to the required private domain that will be resolvable in the org but the domain name .testing is not changing after I tried to reinstall with crc setup.
Changing https://console-openshift-console.apps-crc.testing would need to be  https://console-openshift-console.apps-crc.<private-tld>
Do I need to manually change this:
/etc/NetworkManager/dnsmasq.d/crc.conf:
server=/crc.testing/<IP_ADDRESS>
server=/apps-crc.testing/<IP_ADDRESS>
Thank you!

https://github.com/code-ready/crc/wiki/Change-the-domain-for-CRC Also if your use case is just to access registry as you created issue #3359 then I don't think you need to change these settings.


Added null-checkings for fast fail

cc #190

Released.

Added null-checkings for fast fail
Updated support library to 27.0.2

dependencies {
    implementation 'me.drakeet.multitype:multitype:3.4.1'
}


Add option to export secrets as environment variables.

This adds an option to export the secrets as environment variables.
We need this, because we are migrating from using our own custom action for fetching secrets and our old action would directly export the secrets as environment variables, so to be able to maintain API compatibility, we need this action to be able to do the same. Otherwise we would have to make significant changes to our workflows to enable the migration.
For others, this will be convenient, as most secrets you fetch will end up in an environment variable anyway. This removes the need for the manual step of putting the output from this action as an environment variable in the step where it is used.
As per my implementation, the feature is disabled by default and needs to be enabled to be used, which means that it is fully backwards compatible and will not affect users that don't want to use this feature.
I've tested it in one of our pipelines and it is working fine. I've also run linting and tests locally, without any errors or failures.

@sethvargo
Thank you for your review. I signed the CLA and addressed the review comments, except the one about logDebug, as I'm not sure what you are after.


Implement function to get the ports from a service

Contributes to #240.

Codecov Report
Attention: Patch coverage is 44.44444% with 5 lines in your changes missing coverage. Please review.

Project coverage is 55.46%. Comparing base (e9d5e8f) to head (0c6ac33).

Files with missing lines
Patch %
Lines

kele.el
44.44%
5 Missing :warning:

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #245      +/-   ##
==========================================
- Coverage   55.58%   55.46%   -0.12%
==========================================
  Files           1        1
  Lines         869      878       +9
==========================================
+ Hits          483      487       +4
- Misses        386      391       +5

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Fix navigation issues

A few left over items I noticed in testing. There was always a flash from submenus on page load (CLS) and the mobile menu. There was an issue with resized windows (especially with dev tools responsive mode) and the submenu out of viewport measurement. Mobile menu was wider than screen at some device sizes. This fixes all of that. Also removed erroneous nav toggle height in the JS since it was no longer used by the CSS.
Opinionated: I moved some styles around and prefixed with .js and .no-js for a little better control over how the desktop menu works. Whilst having JS disabled is not conducive to accessibility, I still wanted a functional menu. This PR achieves that.

Thanks a lot for the effort @michaelbourne! I'll test it out next week. 👍

@michaelbourne Had a quick test. Are you sure this is right? I fetched your changes and rebased them with the current master. Console log shows now errors, but the nav looks like this, even after rebuilding JS and CSS:

I suspect the .js class is the cause, because we no longer use no-js/js at all. In some point we decided to stop supporting browsers without JavaScript for the reasons we stopped IE support - the market share for them is so small.
Can you re-add js/no-js to this PR?
Also could you make sure that the JS build succeedes. This means using our .eslintrc (VSCode has an autoformat plugin for Eslint as well) or have our packages installed with npm/npx and to test with eslint . in the theme directory. Thanks!

Hi @ronilaukkarinen
Good catch, I still use the js and no-js classes. Not really to support JS disabled browsers explicitly, but for things like this nav change. My browserslist is actually more limited than yours now due to the types of sites I'm building, I don't have any old browser support.
If you're 100% adamant against having it, there's probably another angle of attack here. I just know something needed tweaking to remove the initial CLS of those nav menus.

Tested that build on a new install and it seems to work as intended. You can test the progressive enhancement by disabling JS.
When we have sites audits by 3rd party vendors like https://accessibleweb.com/ , having a working menu with JS disabled is a criteria they check for. It's obviously an enhanced qualification, not your basic AA level, but for the little effort it takes, seems worthwhile. Not sure it would be possible (cleanly) without the js classes but we can talk bout it.


persoanl spelling issue

personal is spelled incorrectly in "For Azure DevOps, use a persoanl access token when prompt for credentials, see Authenticate access with personal access tokens"

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 9a10a409-5468-9532-f0dc-5a28cdd566d8
Version Independent ID: 2ef20266-bc45-448b-27f5-e5c3bffed2ef
Content: Get started with NuGet packages in Azure DevOps Services and TFS
Content Source: docs/artifacts/get-started-nuget.md
Product: devops
Technology: devops-artifacts
GitHub Login: @chasewilson
Microsoft Alias: phwilson

Updated documentation with https://dev.azure.com/mseng/TechnicalContent/_git/vsts-docs-pr/pullrequest/491312

@daweim0 -- David, thank you for your feedback.  I have updated the documentation and it should be live by tomorrow.


Any chance you can fix the new github feed?

So github decided to remove the following feed as you probably noticed.
Is there anything that can be done about it within the scope of this project?

A good start would be by stating what's wrong with it. It's best to open dedicated issues around what changes you'd like.
The good part is that there's a filter now"


SSH hangs on Java 7

JSch asks for Kerberos username and password when running on Java 7:
http://stackoverflow.com/questions/10881981/sftp-connection-through-java-asking-for-weird-authentication

Bitbucket: https://bitbucket.org/nskvortsov/deployer/issue/34
Originally reported by: Ondřej Kmoch
Originally created at: 2014-07-22T23:10:00.262

Fixing #34 when SSH hangs on Java 7
→ <<cset 5c1d3a2a0ab3>>

Original comment by: Nikita Skvortsov

Issue #25 was marked as a duplicate of this issue.

Original comment by: Nikita Skvortsov

Merged in kmoco2am/deployer (pull request #10)
Fixing #34 when SSH hangs on Java 7
→ <<cset 2c603a8ee099>>

Original comment by: Nikita Skvortsov


Moves Bio to Correct Location

Whose bio tho? Unclear from the commit message.

Mine!

Awesome, thanks so much!

👍


Use yapf in addition to pylint

Most of the time, yapf and pylint don't conflict. In the case that they do, prefer yapf since it's automated.
Dev flow would just include a make yapf before committing/pull requests.

Turned off squash/rebase merging since otherwise it defaults to those.


HIP/hip_prof_gen.py Warning: implementation not found: hipMemcpyToSymbolAsync

Building on top of hcc commit 98ee9f34945d3b5f572d7a4c15cbffa506487734 and ROCR-Runtime commit e252867906dcc289b03efe6c38c9241f02b55557, I received the following warning while I build HIP on top of commit 17862812b4378b8fd6fb7cadb3c32f2075713934:
HIP/build$  cmake -DCMAKE_BUILD_TYPE=Release -DCMAKE_INSTALL_PREFIX=/opt/rocm ../ -G Ninja
-- Generating profiling promitives: /home/4nt/HIP/include/hip/hcc_detail/hip_prof_str.h
/home/4nt/HIP/hip_prof_gen.py Warning: implementation not found: hipMemcpyToSymbolAsync
/home/4nt/HIP/hip_prof_gen.py Warning: implementation not found: hipMemcpyFromSymbolAsync
/home/4nt/HIP/hip_prof_gen.py Warning: implementation not found: hipLaunchCooperativeKernel
/home/4nt/HIP/hip_prof_gen.py Warning: implementation not found: hipLaunchCooperativeKernelMultiDevice
/home/4nt/HIP/hip_prof_gen.py Warning: implementation not found: hipMemcpyFromSymbol
/home/4nt/HIP/hip_prof_gen.py Warning: implementation not found: __hipPushCallConfiguration
/home/4nt/HIP/hip_prof_gen.py Warning: implementation not found: hipGetSymbolAddress
/home/4nt/HIP/hip_prof_gen.py Warning: implementation not found: hipGetSymbolSize
/home/4nt/HIP/hip_prof_gen.py Warning: implementation not found: hipExtLaunchMultiKernelMultiDevice
/home/4nt/HIP/hip_prof_gen.py Warning: implementation not found: hipMemcpyToSymbol
/home/4nt/HIP/hip_prof_gen.py Warning: implementation not found: __hipPopCallConfiguration
/home/4nt/HIP/hip_prof_gen.py Warning: 11 API calls missing in interception layer
-- Code Object Manager found at /opt/rocm/lib/cmake/amd_comgr.

Have these implementations not been written? If not, how can I get hip_prof_gen.py to find them?

@NAThompson Sorry for the lack of response. Please try latest ROCm 6.0.2 (HIP 6.0.32831) to see if your issue still exists? If resolved, please close the ticket. Thanks.


add AcceptEx

Note  The function pointer for the AcceptEx function must be obtained at run time by making a call to the WSAIoctl function with the SIO_GET_EXTENSION_FUNCTION_POINTER opcode specified. The input buffer passed to the WSAIoctl function must contain WSAID_ACCEPTEX, a globally unique identifier (GUID) whose value identifies the AcceptEx extension function. On success, the output returned by the WSAIoctl function contains a pointer to the AcceptEx function. The WSAID_ACCEPTEX GUID is defined in the Mswsock.h header file.
i wanna know the way to use acceptex

Sorry for the delayed response. I've been busy doing other work and have stopped developing this repository. Windows never disappoints when it comes to make something rather simple very complex, but fortunately it has pretty decent documentation. My best advice would be to look at an existing implementation (libuv, mio (Rust) or Boost.Asio (C++) that migh show you how how it's done.


fastApprox match always gives same feedback as bruteForce() match

Not quite sure if I'm misunderstanding the threshold settings, so at https://github.com/dgtlmoon/ORB_LATCH_K2NN I have a pipeline of ORB / LATCH / K2NN, my results are that when I --search using fast-approx I was expecting that I would get more (or atleast some) descriptors that match that are not in the same set that I searched for.
My app scans images in a directory and appends all of their descriptors to a training.dat file for a K2NN search
I'm seeing that ONLY the same collection of descriptors in my query exists in the training and nothing else... even tho a lot of the images should have atleast a couple of similar descriptors.
also suspicious is that with fastApprox() all of the .t's (training vector index) is contiguous.. I would have expected that atleast some might be partial (threshold) matches
so hmm.. not sure how I would rank images by "similarity" (or by their K2NN ranking) here

Hmm. tho in another case fast-approx gives no results whilst brute-force gives the kind of results im expecting.. so something i'm not understanding here

Hi,
I don't currently have time to examine external code-bases, but I can say that fastApproxMatch is an experimental attempt to do just a single twiddle pass of multi-index hashing. It will only return guaranteed matches, but it will only find such matches if the query and training differ by less than (32 - threshold), so it could work well in a high-frame-rate VO application where each frame differs very little, but is not intended, and not likely to work, for a SfM application like yours, where thresholds must be high as matches will still differ a lot.
I suggest sticking to bruteMatch for your application.
If even bruteMatch causes problems, check things like degrees and radians. Do a simple test and confirm the pipeline is working on two images, like I did with this gentleman for CLATCH:
https://github.com/komrad36/CLATCH/issues/1
That way you can test rotation invariance, scale invariance, etc.
Also note that the CPU version necessarily handles scale sort of imperfectly; as I think I mentioned previously somewhere, it's great at handling various scales, i.e. at matching small scale features, or matching large scale features, but not good at matching small scales to large ones.
The CUDA version is a little better, but not great.
A really good solution is planned by tightly coupling the upcoming KORB to CLATCH such that they generate and share pre-computed interpolated scale spaces. That'll work great. Probably take a couple more weeks.
Thanks,
Kareem


Unable to find @pulumi/aws during sst install with 0.1.77

Running a fresh sst install fails with the following error:
time=2024-08-02T11:16:00.241-05:00 level=ERROR msg="exited with error" err="Error evaluating config: exit status 1
node:internal/modules/run_main:129
    triggerUncaughtException(
Error [ERR_MODULE_NOT_FOUND]: Cannot find package '@pulumi/aws' imported from /Users/jeremy.jongsma/dev/web/victualler/packages/craft-svelte/.sst/platform/sst.config.1722615360202.mjs
Did you mean to import<EMAIL_ADDRESS>    at packageResolve (node:internal/modules/esm/resolve:854:9)
    at moduleResolve (node:internal/modules/esm/resolve:927:18)
    at defaultResolve (node:internal/modules/esm/resolve:1157:11)
    at ModuleLoader.defaultResolve (node:internal/modules/esm/loader:383:12)
    at ModuleLoader.resolve (node:internal/modules/esm/loader:352:25)
    at ModuleLoader.getModuleJob (node:internal/modules/esm/loader:227:38)
    at ModuleWrap.<anonymous> (node:internal/modules/esm/module_job:87:39)
    at link (node:internal/modules/esm/module_job:86:36) {
      code: 'ERR_MODULE_NOT_FOUND'
    }

Node.js v20.14.0\n"
✕  Unexpected error occurred. Please check the logs or run with --verbose for more details.

I couldn't replicate this, what's in your sst.config.ts?

if you delete .sst folder does this work?

It looks like the issue happens when I import a local package with helper macros that depends on pulumi in sst.config.ts. It appears that it doesn't find nested dependencies? I had to explicitly depend on pulumi in the project to resolve this.
I'm not totally clear on why the library needs to be downloaded into .sst rather than using local package resolution, but I'm guessing there's some non-standard module resolution going on because of this? Seems odd that I have to explicitly specify a dependency's dependencies in the current project if I want to use it in sst.config.ts.

Can you share what you were doing in your sst.config.ts?
But yeah SST manages these dependencies because internally we don't rely on npm. The CLI binary works for any environment, not just Node projects.

I've got this in the top of my sst.config.ts:
/// <reference path="./.sst/platform/config.d.ts" />
import { DeployConfig, getStageEnv } from '@getprovi/pulumi-util';

pulumi-util is a local workspace package ("@getprovi/pulumi-util": "workspace:*" in package.json) which subsequently depends on @pulumi/pulumi and @pulumi/aws, which it can't find unless I add them as a direct dependency of the package SST is installed in. So it's resolving dependencies in the current package's node_modules, but not following through to sub-dependencies.


submissions: make lit form accesiable to all users

INSPIR-2609

Shouldn't you also update the link for the submission from the header menu?

@monaawi it's for later


CB-7618: Eliminate hdf and hdp from image management

HDP and HDF images are not supported therefore we have eliminated them and their all references from image catalog service, unit tests and the related test json files.

retest it please

retest this please


Write wiki article about dev meetings

Description of the issue
We decided about some improvements of the dev meeting process:

2 people prepare meeting (initiate and lead compromise meetings, choose dev meeting issues)
use of whiteboard
break-out groups
positive example: wind farm discussion

Ideas of solution
We should write a wiki article detailing these changes as well as the other important aspects like choosing a meeting protocol person etc
Workflow checklist

[ ] I am aware of the workflow for this repository

Wiki Article to write: https://github.com/OpenEnergyPlatform/ontology/wiki/Meeting-workflow

There is also already this article: https://github.com/OpenEnergyPlatform/ontology/wiki/oeo-dev-meeting-plan
The contents of these two article should be merged.

I inserted the meeting workflow into the dev meeting plan.

I inserted the meeting workflow into the dev meeting plan.

I deleted my article then and replaced all links to it with the other. This issue can be closed then

I deleted my article then and replaced all links to it with the other. This issue can be closed then


Update to more recent cardano-ledger-specs.

This re-enables the PBFT VRF checks. These now seem to be passing
consensus tests.
Note that currently this references an unmerged branch - I want to verify the changes here before re-enabling this back in the ledger specs.

It seems @dcoutts got to it first (in our absence): https://github.com/input-output-hk/ouroboros-network/pull/2324

Oops, I hadn't realised https://github.com/input-output-hk/cardano-ledger-specs/pull/1590 hadn't been merged yet. Reopening, but this PR will need updating.

OK, this has been rebased and repointed to the latest c-l-s. VRF checks are enabled, and we pick up some bug fixes along the way :-)

CI fails with: VRFKeyBadNonce in the ThreadNet tests.

Urgh, I ran the tests before and thought they worked...

bors merge


[ruby] Can't provide list of interrupt strings with frozen_string_literals enabled

What version of gRPC and what language are you using?
1.24
What operating system (Linux, Windows,...) and version?
Linux & osX
What runtime / compiler are you using (e.g. python version or version of gcc)
Ruby 2.6
What did you do?
#!/usr/bin/env ruby
# frozen_string_literal: true

require 'grpc'

server = GRPC::RpcServer.new()
server.add_http2_port('<IP_ADDRESS>:80', :this_port_is_insecure)
GRPC.logger.info "Server started"
server.run_till_terminated_or_interrupted(%w[EXIT INT QUIT KILL])
GRPC.logger.info "Server terminated"

What did you expect to see?
A running server, that would terminate without segmentation faults when receiving on the provided interrupt signals
What did you see instead?
While running the server I received this in the logs;
grpc-7bf5cdf9dc-pclw9 grpc FrozenError: can't modify frozen String
grpc-7bf5cdf9dc-pclw9 grpc   /usr/local/bundle/gems/grpc-1.24.0-x86_64-linux/src/ruby/lib/grpc/generic/rpc_server.rb:395:in `upcase!'
grpc-7bf5cdf9dc-pclw9 grpc   /usr/local/bundle/gems/grpc-1.24.0-x86_64-linux/src/ruby/lib/grpc/generic/rpc_server.rb:395:in `block in run_till_terminated_or_interrupted'
grpc-7bf5cdf9dc-pclw9 grpc   /usr/local/bundle/gems/grpc-1.24.0-x86_64-linux/src/ruby/lib/grpc/generic/rpc_server.rb:392:in `each'
grpc-7bf5cdf9dc-pclw9 grpc   /usr/local/bundle/gems/grpc-1.24.0-x86_64-linux/src/ruby/lib/grpc/generic/rpc_server.rb:392:in `run_till_terminated_or_interrupted'
grpc-7bf5cdf9dc-pclw9 grpc   /app/config/grpc_server.rb:34:in `<top (required)>'

The error is triggered by this code snippet: https://github.com/grpc/grpc/blob/398be272878825ede60a5b32c4f98a865ff62ec4/src/ruby/lib/grpc/generic/rpc_server.rb#L395
If you follow the code snippet, you'll see the code tries to upcase the string in place, which is forbidden when enabling frozen string literals. Enabling this has become the default in our codebase, and for what I know isn't a strange default to have.
See TROUBLESHOOTING.md for how to diagnose problems better.
Anything else we should know about your project / environment?
Our application is running in kubernetes, so we rely on signals to terminate our application. This is why we've chosen to use run_till_terminated_or_interrupted instead of the default run_till_terminated

Two PRs, both #20867 and the considerably simpler #21740, provide fixes for this issue.
It is a well established best practice to run Ruby with frozen string literals by now - gRPC would benefit from staying compatible with the respective implementation language's paradigms / established best practices as far as painlessly possible.
Can we get this reviewed, merged, and ultimately included in an upcoming release please?

This is still an issue and #21740 provides the necessary fix

sorry, this was merged yesterday: https://github.com/grpc/grpc/pull/20867, which I believe obsoletes #21740

@apolcyn Yup looks like that will do it thanks!


How to use this LSP with the KDE Kate text editor

I have searched the issues of this repo and believe that this is not a duplicate.
I have searched the discussions and believe that my question is not already covered.

Feature Request

Dear Folks,
Thank your for creating this LSP.
I am a long time user of the KDE kate text editor and would like to use the typst-lsp server with kate.
I have installed the AUR package typst-lsp-bin from https://aur.archlinux.org/packages/typst-lsp-bin.
I am trying to get kate to recognize and use typst-lsp-bin but have not been able to do so thus far.
The recommended syntaxes to add a new language server for kate are shown here.
I added the following JSON block to my settings.json for kate as shown below:
{
    "servers": {
        "typst": {
            "command": ["/usr/bin/typst-lsp"],
            "url": "https://github.com/nvarner/typst-lsp",
            "highlightingModeRegex": "^Typst$"
        }
    }
}

However, I ended up with the following error:
[08:50:41 ￼ LSP Client Warning] Failed to find server binary: vscode-json-languageserver
Please check your PATH for the binary
See also https://github.com/microsoft/vscode/tree/main/extensions/json-language-features/server for installation or details

Does typst-lsp only support VSCode?
It would be great if typst-lsp could support other text editors as well.
Kindly make it usable with kate or let me know the correct JSON syntax.
Many thanks.

I installed typst-lsp from nixpkgs and managed to use it within Kate with the following configuration:
{
	"servers": {
		"typ": {
			"command": ["/nix/store/ax813pfbcg9sjzyasam9paw432bakfjf-typst-lsp-0.12.0/bin/typst-lsp"],
			"highlightingModeRegex": "^Typst$"
		}
	}
}

Could be a problem with the specific package you're using, but either way the above worked for me. You might have to create a Typst filetype by going to Kate's settings, Open / Save, Modes & Filetypes, naming it "Typst" and assigning the typ file extension. I also assigned Rust's syntax highlighting, although that didn't seem to affect anything.

@PgBiel: Thank you for your reply. I have now set up a new Filetype for Typst. But there is no syntax highlighting for Typst-specific keywords. Punctuation, brackets and strings are highlighted, but that is all.
I expected the typst-lsp to give me syntax highlighting, but it does not, even though it does on VSCode/VSCodium via an extension from the marketplace, but by the same author.
Do you get Typst-specific syntax highlighting with kate? From the KDE kate website, it does not seem to have it. Please see:
https://kate-editor.org/syntax/

In short, there's no good way to provide syntax highlighting to every editor. This extension has the best support for VS Code(ium), so other editors will usually be worse for now.
Kate seems to use its own custom format for syntax highlighting, which means writing and maintaining a syntax highlighting file just for Kate. However, from what you've said and some brief research, Kate seems to support semantic highlighting. It would require some code changes, but it would be an easier way to get Typst syntax highlighting in Kate.
Ultimately, this means there's probably no quick fix right now.

I put some time into investigating this. It looks like Kate in particular has only very limited support for semantic tokens. This probably means Typst won't have very good syntax highlighting in Kate unless someone writes a Kate-specific grammar for the language.
You'll also need to update your LSP configuration so that typst-lsp actually attempts to use semantic tokens.
{
    "servers": {
        "typst": {
            "command": ["/your/path/to/typst-lsp"],
            "url": "https://github.com/nvarner/typst-lsp",
            "highlightingModeRegex": "^Typst$",
            "initializationOptions": {
                "semanticTokens": "enable"
            }
        }
    }
}

Choosing Rust syntax highlighting is technically wrong, since that just tells Kate to imagine your Typst code is really just Rust. That means it will probably highlight many things incorrectly. However, it's possible that this will give better results than semantic tokens alone, just because of the limitations of Kate's implementation.

(Extremely) relevant Kate MR: https://invent.kde.org/utilities/kate/-/merge_requests/1247

You'll also need to update your LSP configuration so that typst-lsp actually attempts to use semantic tokens.

I have done so, and the typst-lsp server is well and truly recognized in kate but the syntax highlighting is limited. Rust provides more "color" but might be wrong as you have suggested.
I have a few questions on which I will get back to you.

I have tryed all these things from kate flatpack and nothing works. Lsp even starts.


Fix promise error handling order

As it is currently, any errors that are thrown in any middleware after the body parser are caught and passed through the onError config option. This pull request fixes the order so that only body parsing errors are passed to the onError function, not all errors from other middleware.

Hi thanks for the pr. I'll look at this over the weekend.

@dlau Could you publish a release when you get a chance?

published in 2.3.0


pip install -r requirements.txt runs forever (or takes longer than I bothered to wait)

It seems there's a conflict somewhere in the version requirements. Installing the requirements/*.txt separately works fine, which explains why there's no failure during CI. We should (1) find/fix the version conflict and (2) add a CI step that installs from this requirements file.

It looks like one of jupyter-book's  dependencies (markdown-it-py) wants an older version of attrs. There's a newer version of markdown-it-py that relaxes the requirement for attrs<21, but that version is not installed because other dependencies of jupyter-book (jupytext and myst-parser) pin to an older version of markdown-it-py. The docs build just fine if you force pip to install the latest attrs and the old version of markdown-it-py.
I might just leave this as it is and see if it gets resolved with the next batch of dependabot updates next month.

This one is biting me right now, too.  I'm using pip-compile to explicitly pin everything.  It all came crashing down because of this.

Are you suggesting that the demes' requirements.txt is confusing your use of pip-compile in fwdpy11, or that you're getting the same problem (coincidentally) because of also depending on jupyter-book and attrs?
A workaround would be to pin to attrs==20.3.0. Maybe we should do that for a while? This version of attrs gives a deprecation warning with demes (specifically for attr.ib(..., cmp=False)), but otherwise works fine. Attrs 21.x has "undeprecated" the cmp option.

I managed to show (I think) that it isn't due to anything in demes.  It seems to be this mess w/jupyter-book.  I just bumped all the attrs down to 20.3.0 and am running tests for that now.

One irritation, which I think you may also have noted, is that pip check fails to find any conflicts once I semi-manually get a working environment in place.

executablebooks/jupyter-book#1351

Fixed by #321.


don't import schemas as they are individually exported to keep processSchemas schema-import order independent

don't try to import as they are exported to keep processSchemas schema-import order independent
add a test that will fail if they are exported out of order

@scsewall could you make sure this merges? rush-cover on the linux CI is being flaky, and the integration test is also being flaky...

@khanaffan please check logs for core-full-stack-tests. @grigasp please check logs for presentation-full-stack-tests.
2021-06-17T15:32:05.4362058Z   ECSql Query
2021-06-17T15:32:05.4362400Z Segmentation fault (core dumped)
https://dev.azure.com/bentleycs/iModelTechnologies/_build/results?buildId=942390&view=logs&j=0e716e2d-52f9-5be6-7c39-1d54fa1d7b01&t=9c57987f-b8b9-5a71-d78c-c72c8dbbbcd7

@Mergifyio backport release/2.17.x


Libraries should be compiled before distribution

Normally, people prevent typescript from compiling their node_modules folder, with good reason.
Unfortunately, your package.json points towards ng1-to-ng2.ts, which is a typescript file.
This means that anyone using your library must compile it. Ensure you build your library first, to JS, in a dist folder, and then point your package.json to that file.
The issue may very well be https://github.com/ui-router/ng1-to-ng2/blob/master/.gitignore#L3

I'm compiling before publishing to npm.  Are you fetching the git repo or something?
http://npmcdn.com/ui-router-ng1-to-ng2

A possible issue is that in package.json you have
"main": "ng1-to-ng2",

instead of
"main": "ng1-to-ng2.js",

I did obtain the compiled js file with npm but somehow typescript was picking up the ts version. The above should fix this problem. Also, is there a way to make it webpack friendly as well? Using your compiled version uses System which is not defined when I build. For now I'm having to copy your file into my project to try it out.

I was unaware that you can throw a different version on npm than on github
https://github.com/ui-router/ng1-to-ng2/pull/7

Also the System.register() in the compiled JS file is a very valid point, it would be problematic to get it to work with something like webpack.

Totally agree, thanks for pointing that out.

Version 1.0.10 now points to main: 'ng1-to-ng2.js', and is a UMD bundle using webpack.


Additional parameters for registering assets

After some discussion on the forums about loading scripts with async or defer attributes, @mnakalay suggested an additional attributes parameter for attributes when registering an asset. This would provide a general purpose solution to asnyc, defer and any other attributes for script or link/css tags that may be desired in the future.
See https://www.concrete5.org/community/forums/customizing_c5/requireasset-with-async-or-defer/#964441
and https://developer.mozilla.org/en-US/docs/Web/HTML/Element/script

Keeping the interface extensible, this could either be an 'attributes' nested array for the current 'additional parameters', or a further optional parameter dedicated to attributes.
( And I would love to know what the other asset types still TBD in the docs actually do, whether they are fully implemented and whether they have ever been used and tested https://documentation.concrete5.org/developers/assets/registering-an-asset)

Bump

Bump again. Lack of async or defer are a constant criticism of c5 sites on PageSpeed reports and the kind of thing SEO hawkers are using to argue for migrating to Wordpress.

Bump again. Lack of async or defer are a constant criticism of c5 sites on PageSpeed reports and the kind of thing SEO hawkers are using to argue for migrating to Wordpress.

@aembler, this seems to have never been tagged. Can you review this please and promote it to a proposal / enhancement?

@aembler, this seems to have never been tagged. Can you review this please and promote it to a proposal / enhancement?


Output stored in data container

Output from containers is no longer stored locally, but rather written
to a data container. This is to facilitate sharing of data between
containers, and running tests on container output.
A test container is also committed. A test suite called test/foo.py is
intended to test the output of container foo.

lgtm


PuzzleContainer: entryBuilder should fail if implementation does not support one of the contracts

Related to #134

cannot be safely checked, especially when using factories


Enable app usage while in debug mode

This is to discuss how we can allow people to use the app to contribute to development.
This was the proposal:

People can enter the app w/o a subscription
They can only watch free videos (pro & beginner are locked)
They can't use downloads (not sure if we discussed this)
This would work only while in DEBUG mode. RELEASE automatically strips users of this feature.

@sammyd Let me know if this makes sense or not. I'm not sure if we should enable downloads too if the user is in DEBUG. I think with a bit of hotwiring we could do that too.
I've built a prototype already that I'll link in a PR and I'll ping you there with the progress so we can discuss further steps.

This sounds perfect—thanks @filbabic
Regarding downloads—they're currently gated on the backend, so we can't make that change in the app alone. Developers need an API_TOKEN to have access to the download endpoints. The current approach is that if a contributor really wants to work on downloads, then we'll issue a unique download key so they can work on it. It's not ideal, but I think it's ok for now.
If/when we switch to HLS downloads, this will no longer be the case, at which point downloads can be opened up for free videos in the same way as the streams.

@sammyd Yeah, my thoughts exactly, I know we have special keys to access that API, but once HLS is used, we'll be able to railroad the experience of free vs locked content.
I've attached you to the PR to explain what I did and show some images of how it looks. I tested the thing and it seems to be working fine, all according to what we had planned.
Even if the contributor tries hardcoding the flags to open up videos in the app, they'll be blocked through the DL/stream API, so we're all good there.
The only thing that's missing now is for me to write up the guide/change the readme to explain how to set up Emitron, which should require only creating a basic empty Firebase project & adding the google-services.json file.