chore(vendor): update dependencies

Which issue(s) this PR fixes:

Issue #
What this PR does / why we need it:
Special notes for your reviewer:
Additional documentation or context

Summary by CodeRabbit

New Features

Upgraded Go version to 1.23.0, enhancing performance and compatibility.
Updated dependencies for improved functionality and security.

Bug Fixes

Refined error handling in the mountedByOpenat2 function for better reliability.

Chores

Routine updates to module dependencies and their versions.

cc @innobead


Refactor lastAttackedBy to hurtBy

Replaced the 'lastAttackedBy' attribute of a Pokemon with an array of attacks that the Pokemon has recently received. This corrects a bug in double battles arising from lastAttackedBy always getting replaced by the most recent attack, which caused Avalanche and Revenge to not double in power when they otherwise should have (e.g. see https://replay.pokemonshowdown.com/gen7doublescustomgame-796785834). This also addresses the corresponding task in #2444.

Closing to address mocha test

bump

Hi, very sorry about the delay, I didn't get any of these alerts.
This looks pretty good! Would you mind creating a lastHurtBy() function as a shortcut for hurtBy[target.hurtBy.length - 1]? Makes uses of it much more readable. This is otherwise a great improvement, thanks!

Yep, can do. And no worries about the delay.


Add count of rentals for items and customers

I've added a functionality that counts how often an item has been rented, or how many rentals a customer has. it's loading lazily, so not slowing down the UI :)
It's added to the keyValueStore["currentDoc"]["number_of_rentals"] - that probably means that it's also written to the db. However, as there is no change no new shard will be created, right, and anyway only if save is clicked? Else let me know how I can display it without it being automatically saved to the doc, could not find out how to without creating a new Input field like InputLabel or so, so without bindings. Should I do it with a new Input Element that just displays things without binding?
For items

For customers

Nice idea :) Yes, it is written to the database when "save" is clicked (see https://github.com/leih-lokal/LeihLokalVerwaltung/blob/689e1bd4043ab03a0743e348861ad33202255b1b/Frontend/src/components/TableEditors/Items/ItemPopupFormular.svelte#L249).
Wouldn't it be better to display the count in the table or in a separate tab for statistics? I think it might not be so good to display it as an input in the formular since it's not something the user can / should change. If we want to show more statistics later, maybe even some graphs, a separate tab for statistics (next to "Kunden" "Gegenstände" "Leihvorgänge") might be good?

Wouldn't it be better to display the count in the table or in a separate tab for statistics? I think it might not be so good to display it as an input in the formular since it's not something the user can / should change. If we want to show more statistics later, maybe even some graphs, a separate tab for statistics (next to "Kunden" "Gegenstände" "Leihvorgänge") might be good?

This is a good idea, however, that would but quite a load on the database, right, to query it individually for each item. We could however only query it for the currently displayed items, and/or find a way to only have one run through the db und sum up for the items, and keep that in memory? I don't really know how much of a strain this is, and what would be the most feasable solution. what do you suggest?
I could imagine having a separate tab for statistics! I wanted to do that anyway at some point :) but let's discuss soon what's the most urgent on our list, i guess statistics is rather a nice-to-have

Wouldn't it be better to display the count in the table or in a separate tab for statistics?

This is a good idea, however, that would but quite a load on the database, to query it individually for each item? We could however only query it for the currently displayed items, and/or find a way to only have one run through the db und sum up for the rentals-per-item, and keep that in local storage, or similar things? I don't really know how much of a strain this is, and what would be the most feasable solution. what do you suggest?

If we want to show more statistics later, maybe even some graphs, a separate tab for statistics (next to "Kunden" "Gegenstände" "Leihvorgänge") might be good?
I could imagine having a separate tab for statistics! I wanted to do that anyway at some point :) but let's discuss soon what's the most urgent on our list, i guess statistics is rather a nice-to-have.

I think it might not be so good to display it as an input in the formular since it's not something the user can / should change.

Mhh, I do agree that it's not an input, however it could be nice to link this to the individual pages, and not only in a summary tab.

I suggest we implement one of these solutions:

We could query the count for each item on the current page in the background and display it in the table. This could be implemented like the cellBackgroundColorsFunction which is also executed asynchronously for each row on the current page. I think this would be the least effort but might decrease performance a bit, e.g. if the user already performs another action while the background tasks are still running.
We could implement a python script that runs periodically, queries the counts for all items and stores them in the database. Then in the frontend we could just display the count. If we add more statistics later we might need this anyway because creating statistics might take too long to do it in the frontend.

Wouldn't it be better to display the count in the table or in a separate tab for statistics?

This is a good idea, however, that would but quite a load on the database, to query it individually for each item? We could however only query it for the currently displayed items, and/or find a way to only have one run through the db und sum up for the rentals-per-item, and keep that in local storage, or similar things? I don't really know how much of a strain this is, and what would be the most feasable solution. what do you suggest?

If we want to show more statistics later, maybe even some graphs, a separate tab for statistics (next to "Kunden" "Gegenstände" "Leihvorgänge") might be good?
I could imagine having a separate tab for statistics! I wanted to do that anyway at some point :) but let's discuss soon what's the most urgent on our list, i guess statistics is rather a nice-to-have.

I think it might not be so good to display it as an input in the formular since it's not something the user can / should change.

Mhh, I do agree that it's not an input, however it could be nice to link this to the individual pages, and not only in a summary tab.

I suggest we implement one of these solutions:

We could query the count for each item on the current page in the background and display it in the table. This could be implemented like the cellBackgroundColorsFunction which is also executed asynchronously for each row on the current page. I think this would be the least effort but might decrease performance a bit, e.g. if the user already performs another action while the background tasks are still running.
We could implement a python script that runs periodically, queries the counts for all items and stores them in the database. Then anywhere in the frontend we could just display the count. If we add more statistics later we might need this anyway because creating statistics might take too long to do it in the frontend.

I'd vote for this solution. It should also not be too straining if it's only for the currently displayed items, right? However, it would not be possible to do sorting...

that would probably make it a bit harder to port it to other locations, as they have to be knowledable enough to setup a python environment? I'd prefer to keep things without a backend, and just let the statistics only load on demand (even if it takes a few seconds to load, that should not infer with the general performance of the app, unless triggered to run).

How do we want to handle this PR?
Do you want to merge it for now, or should we add another category "Statistik/Information/[..]" within the popup (I could imagine other information placed there: Which item was rented last, last interaction, etc etc)

How do we want to handle this PR?
Do you want to merge it for now, or should we add another category "Statistik/Information/[..]" within the popup where we place this as new Input method that only displays/a label (I could imagine other information placed there: Which item was rented last, last interaction, etc etc) or do you want to discard it altogether?

I would prefer to update and then merge this PR, I'm sure we can use parts of your current implementation.
I still don't like displaying statistics in the popup formular that much since it's original purpose was editing items and it already is quite large. Moving it to a separate section as you suggested would be better. I would still prefer to show statistics in the table or in a separate tab.
But since you implement this you can decide. Showing statistics in the popup formular might still be better than not showing statistics at all.


pybind11 missing header inside conda

The pybind11 compilation fails because the pybind11.h include path is missing from the compiler invocation when installing inside a conda environment (first noticed this while debugging #7).  When installing inside a venv, there doesn't seem to be any problem. The error message is:
(nufft-ls-py39) lgarrison@ccalin008:~/nufft-ls$ pip install -e .
[...]
src/nufft_ls/cpu.cpp:1:31: fatal error: pybind11/pybind11.h: No such file or directory
 #include <pybind11/pybind11.h>
                               ^
compilation terminated.
error: command '/usr/lib64/ccache/gcc' failed with exit code 1

Full details:

lgarrison@ccalin008:~/nufft-ls$ rm -rf build/ src/nufft_ls.egg-info/ src/nufft_ls/*.so
lgarrison@ccalin008:~/nufft-ls$ conda create -n nufft-ls-py39 'python<3.10'
Collecting package metadata (current_repodata.json): done
Solving environment: done

## Package Plan ##

  environment location: /mnt/home/lgarrison/miniconda3/envs/nufft-ls-py39

  added / updated specs:
    - python[version='<3.10']

The following NEW packages will be INSTALLED:

  _libgcc_mutex      conda-forge/linux-64::_libgcc_mutex-0.1-conda_forge
  _openmp_mutex      conda-forge/linux-64::_openmp_mutex-4.5-1_gnu
  bzip2              conda-forge/linux-64::bzip2-1.0.8-h7f98852_4
  ca-certificates    conda-forge/linux-64::ca-certificates-2021.10.8-ha878542_0
  ld_impl_linux-64   conda-forge/linux-64::ld_impl_linux-64-2.36.1-hea4e1c9_2
  libffi             conda-forge/linux-64::libffi-3.4.2-h7f98852_5
  libgcc-ng          conda-forge/linux-64::libgcc-ng-11.2.0-h1d223b6_12
  libgomp            conda-forge/linux-64::libgomp-11.2.0-h1d223b6_12
  libnsl             conda-forge/linux-64::libnsl-2.0.0-h7f98852_0
  libuuid            conda-forge/linux-64::libuuid-2.32.1-h7f98852_1000
  libzlib            conda-forge/linux-64::libzlib-1.2.11-h36c2ea0_1013
  ncurses            conda-forge/linux-64::ncurses-6.3-h9c3ff4c_0
  openssl            conda-forge/linux-64::openssl-3.0.0-h7f98852_2
  pip                conda-forge/noarch::pip-22.0.3-pyhd8ed1ab_0
  python             conda-forge/linux-64::python-3.9.10-hc74c709_2_cpython
  python_abi         conda-forge/linux-64::python_abi-3.9-2_cp39
  readline           conda-forge/linux-64::readline-8.1-h46c0cb4_0
  setuptools         conda-forge/linux-64::setuptools-60.8.1-py39hf3d152e_0
  sqlite             conda-forge/linux-64::sqlite-3.37.0-h9cd32fc_0
  tk                 conda-forge/linux-64::tk-8.6.11-h27826a3_1
  tzdata             conda-forge/noarch::tzdata-2021e-he74cb21_0
  wheel              conda-forge/noarch::wheel-0.37.1-pyhd8ed1ab_0
  xz                 conda-forge/linux-64::xz-5.2.5-h516909a_1
  zlib               conda-forge/linux-64::zlib-1.2.11-h36c2ea0_1013

Proceed ([y]/n)? y

Preparing transaction: done
Verifying transaction: done
Executing transaction: done
#
# To activate this environment, use
#
#     $ conda activate nufft-ls-py39
#
# To deactivate an active environment, use
#
#     $ conda deactivate

lgarrison@ccalin008:~/nufft-ls$ conda activate nufft-ls-py39
(nufft-ls-py39) lgarrison@ccalin008:~/nufft-ls$ which python
~/miniconda3/envs/nufft-ls-py39/bin/python
(nufft-ls-py39) lgarrison@ccalin008:~/nufft-ls$ python -m pip install -U pip
python -Requirement already satisfied: pip in /mnt/home/lgarrison/miniconda3/envs/nufft-ls-py39/lib/python3.9/site-packages (22.0.3)
m (nufft-ls-py39) lgarrison@ccalin008:~/nufft-ls$ python -m pip install -e . -v
Using pip 22.0.3 from /mnt/home/lgarrison/miniconda3/envs/nufft-ls-py39/lib/python3.9/site-packages/pip (python 3.9)
Obtaining file:///mnt/home/lgarrison/nufft-ls
  Running command pip subprocess to install build dependencies
  Collecting setuptools<60.6,>=42
    Using cached setuptools-60.5.0-py3-none-any.whl (958 kB)
  Collecting wheel
    Using cached wheel-0.37.1-py2.py3-none-any.whl (35 kB)
  Collecting pybind11~=2.9
    Using cached pybind11-2.9.1-py2.py3-none-any.whl (211 kB)
  Installing collected packages: wheel, setuptools, pybind11
  Successfully installed pybind11-2.9.1 setuptools-60.5.0 wheel-0.37.1
  Installing build dependencies ... done
  Running command Checking if build backend supports build_editable
  Checking if build backend supports build_editable ... done
  Running command Getting requirements to build wheel
  running egg_info
  creating src/nufft_ls.egg-info
  writing manifest file 'src/nufft_ls.egg-info/SOURCES.txt'
  writing manifest file 'src/nufft_ls.egg-info/SOURCES.txt'
  Getting requirements to build wheel ... done
  Running command Preparing metadata (pyproject.toml)
  running dist_info
  creating /tmp/pip-modern-metadata-6lxhv1u5/nufft_ls.egg-info
  writing manifest file '/tmp/pip-modern-metadata-6lxhv1u5/nufft_ls.egg-info/SOURCES.txt'
  writing manifest file '/tmp/pip-modern-metadata-6lxhv1u5/nufft_ls.egg-info/SOURCES.txt'
  Preparing metadata (pyproject.toml) ... done
Collecting numpy
  Using cached numpy-1.22.2-cp39-cp39-manylinux_2_17_x86_64.manylinux2014_x86_64.whl (16.8 MB)
Collecting astropy
  Using cached astropy-5.0.1-cp39-cp39-manylinux_2_12_x86_64.manylinux2010_x86_64.whl (11.1 MB)
Collecting threadpoolctl
  Using cached threadpoolctl-3.1.0-py3-none-any.whl (14 kB)
Collecting PyYAML>=3.13
  Using cached PyYAML-6.0-cp39-cp39-manylinux_2_5_x86_64.manylinux1_x86_64.manylinux_2_12_x86_64.manylinux2010_x86_64.whl (661 kB)
Collecting pyerfa>=2.0
  Using cached pyerfa-<IP_ADDRESS>-cp39-cp39-manylinux_2_5_x86_64.manylinux1_x86_64.manylinux_2_12_x86_64.manylinux2010_x86_64.whl (742 kB)
Collecting packaging>=19.0
  Using cached packaging-21.3-py3-none-any.whl (40 kB)
Collecting pyparsing!=3.0.5,>=2.0.2
  Using cached pyparsing-3.0.7-py3-none-any.whl (98 kB)
Installing collected packages: threadpoolctl, PyYAML, pyparsing, numpy, pyerfa, packaging, astropy, nufft-ls
  changing mode of /mnt/home/lgarrison/miniconda3/envs/nufft-ls-py39/bin/f2py to 775
  changing mode of /mnt/home/lgarrison/miniconda3/envs/nufft-ls-py39/bin/f2py3 to 775
  changing mode of /mnt/home/lgarrison/miniconda3/envs/nufft-ls-py39/bin/f2py3.9 to 775
  changing mode of /mnt/home/lgarrison/miniconda3/envs/nufft-ls-py39/bin/fits2bitmap to 775
  changing mode of /mnt/home/lgarrison/miniconda3/envs/nufft-ls-py39/bin/fitscheck to 775
  changing mode of /mnt/home/lgarrison/miniconda3/envs/nufft-ls-py39/bin/fitsdiff to 775
  changing mode of /mnt/home/lgarrison/miniconda3/envs/nufft-ls-py39/bin/fitsheader to 775
  changing mode of /mnt/home/lgarrison/miniconda3/envs/nufft-ls-py39/bin/fitsinfo to 775
  changing mode of /mnt/home/lgarrison/miniconda3/envs/nufft-ls-py39/bin/samp_hub to 775
  changing mode of /mnt/home/lgarrison/miniconda3/envs/nufft-ls-py39/bin/showtable to 775
  changing mode of /mnt/home/lgarrison/miniconda3/envs/nufft-ls-py39/bin/volint to 775
  changing mode of /mnt/home/lgarrison/miniconda3/envs/nufft-ls-py39/bin/wcslint to 775
  Running setup.py develop for nufft-ls
    Running command python setup.py develop
    running develop
    /tmp/pip-build-env-b_r8zry7/overlay/lib/python3.9/site-packages/setuptools/command/easy_install.py:156: EasyInstallDeprecationWarning: easy_install command is deprecated. Use build and pip and other standards-based tools.
      warnings.warn(
    /tmp/pip-build-env-b_r8zry7/overlay/lib/python3.9/site-packages/setuptools/command/install.py:34: SetuptoolsDeprecationWarning: setup.py install is deprecated. Use build and pip and other standards-based tools.
      warnings.warn(
    running egg_info
    writing manifest file 'src/nufft_ls.egg-info/SOURCES.txt'
    running build_ext
    gcc -pthread -B /mnt/home/lgarrison/miniconda3/envs/nufft-ls-py39/compiler_compat -Wno-unused-result -Wsign-compare -DNDEBUG -fwrapv -O2 -Wall -fPIC -O2 -isystem /mnt/home/lgarrison/miniconda3/envs/nufft-ls-py39/include -fPIC -O2 -isystem /mnt/home/lgarrison/miniconda3/envs/nufft-ls-py39/include -fPIC -I/mnt/home/lgarrison/miniconda3/envs/nufft-ls-py39/include/python3.9 -c flagcheck.cpp -o flagcheck.o -march=native
    gcc -pthread -B /mnt/home/lgarrison/miniconda3/envs/nufft-ls-py39/compiler_compat -Wno-unused-result -Wsign-compare -DNDEBUG -fwrapv -O2 -Wall -fPIC -O2 -isystem /mnt/home/lgarrison/miniconda3/envs/nufft-ls-py39/include -fPIC -O2 -isystem /mnt/home/lgarrison/miniconda3/envs/nufft-ls-py39/include -fPIC -I/mnt/home/lgarrison/miniconda3/envs/nufft-ls-py39/include/python3.9 -c flagcheck.cpp -o flagcheck.o -Ofast
    gcc -pthread -B /mnt/home/lgarrison/miniconda3/envs/nufft-ls-py39/compiler_compat -Wno-unused-result -Wsign-compare -DNDEBUG -fwrapv -O2 -Wall -fPIC -O2 -isystem /mnt/home/lgarrison/miniconda3/envs/nufft-ls-py39/include -fPIC -O2 -isystem /mnt/home/lgarrison/miniconda3/envs/nufft-ls-py39/include -fPIC -I/mnt/home/lgarrison/miniconda3/envs/nufft-ls-py39/include/python3.9 -c flagcheck.cpp -o flagcheck.o -fopenmp
    gcc -pthread -B /mnt/home/lgarrison/miniconda3/envs/nufft-ls-py39/compiler_compat -Wno-unused-result -Wsign-compare -DNDEBUG -fwrapv -O2 -Wall -fPIC -O2 -isystem /mnt/home/lgarrison/miniconda3/envs/nufft-ls-py39/include -fPIC -O2 -isystem /mnt/home/lgarrison/miniconda3/envs/nufft-ls-py39/include -fPIC -I/mnt/home/lgarrison/miniconda3/envs/nufft-ls-py39/include/python3.9 -c flagcheck.cpp -o flagcheck.o -funroll-loops
    gcc -pthread -B /mnt/home/lgarrison/miniconda3/envs/nufft-ls-py39/compiler_compat -Wno-unused-result -Wsign-compare -DNDEBUG -fwrapv -O2 -Wall -fPIC -O2 -isystem /mnt/home/lgarrison/miniconda3/envs/nufft-ls-py39/include -fPIC -O2 -isystem /mnt/home/lgarrison/miniconda3/envs/nufft-ls-py39/include -fPIC -I/mnt/home/lgarrison/miniconda3/envs/nufft-ls-py39/include/python3.9 -c flagcheck.cpp -o flagcheck.o -ffast-math
    gcc -pthread -B /mnt/home/lgarrison/miniconda3/envs/nufft-ls-py39/compiler_compat -Wno-unused-result -Wsign-compare -DNDEBUG -fwrapv -O2 -Wall -fPIC -O2 -isystem /mnt/home/lgarrison/miniconda3/envs/nufft-ls-py39/include -fPIC -O2 -isystem /mnt/home/lgarrison/miniconda3/envs/nufft-ls-py39/include -fPIC -I/mnt/home/lgarrison/miniconda3/envs/nufft-ls-py39/include/python3.9 -c flagcheck.cpp -o flagcheck.o -std=c++17
    gcc: error: unrecognized command line option ‘-std=c++17’
    gcc -pthread -B /mnt/home/lgarrison/miniconda3/envs/nufft-ls-py39/compiler_compat -Wno-unused-result -Wsign-compare -DNDEBUG -fwrapv -O2 -Wall -fPIC -O2 -isystem /mnt/home/lgarrison/miniconda3/envs/nufft-ls-py39/include -fPIC -O2 -isystem /mnt/home/lgarrison/miniconda3/envs/nufft-ls-py39/include -fPIC -I/mnt/home/lgarrison/miniconda3/envs/nufft-ls-py39/include/python3.9 -c flagcheck.cpp -o flagcheck.o -std=c++14
    gcc: error: unrecognized command line option ‘-std=c++14’
    gcc -pthread -B /mnt/home/lgarrison/miniconda3/envs/nufft-ls-py39/compiler_compat -Wno-unused-result -Wsign-compare -DNDEBUG -fwrapv -O2 -Wall -fPIC -O2 -isystem /mnt/home/lgarrison/miniconda3/envs/nufft-ls-py39/include -fPIC -O2 -isystem /mnt/home/lgarrison/miniconda3/envs/nufft-ls-py39/include -fPIC -I/mnt/home/lgarrison/miniconda3/envs/nufft-ls-py39/include/python3.9 -c flagcheck.cpp -o flagcheck.o -std=c++11
    creating build
    creating build/temp.linux-x86_64-3.9
    creating build/temp.linux-x86_64-3.9/src
    creating build/temp.linux-x86_64-3.9/src/nufft_ls
    gcc -pthread -B /mnt/home/lgarrison/miniconda3/envs/nufft-ls-py39/compiler_compat -Wno-unused-result -Wsign-compare -DNDEBUG -fwrapv -O2 -Wall -fPIC -O2 -isystem /mnt/home/lgarrison/miniconda3/envs/nufft-ls-py39/include -fPIC -O2 -isystem /mnt/home/lgarrison/miniconda3/envs/nufft-ls-py39/include -fPIC -Iinclude/ -I/mnt/home/lgarrison/miniconda3/envs/nufft-ls-py39/include/python3.9 -c src/nufft_ls/cpu.cpp -o build/temp.linux-x86_64-3.9/src/nufft_ls/cpu.o -std=c++11 -fvisibility=hidden -g0 -march=native -Ofast -fopenmp -funroll-loops -ffast-math
    src/nufft_ls/cpu.cpp:1:31: fatal error: pybind11/pybind11.h: No such file or directory
     #include <pybind11/pybind11.h>
                                   ^
    compilation terminated.
    error: command '/usr/lib64/ccache/gcc' failed with exit code 1
    error: subprocess-exited-with-error

    × python setup.py develop did not run successfully.
    │ exit code: 1
    ╰─> See above for output.

    note: This error originates from a subprocess, and is likely not a problem with pip.
    full command: /mnt/home/lgarrison/miniconda3/envs/nufft-ls-py39/bin/python -c '
    exec(compile('"'"''"'"''"'"'
    # This is <pip-setuptools-caller> -- a caller that pip uses to run setup.py
    #
    # - It imports setuptools before invoking setup.py, to enable projects that directly
    #   import from `distutils.core` to work with newer packaging standards.
    # - It provides a clear error message when setuptools is not installed.
    # - It sets `sys.argv[0]` to the underlying `setup.py`, when invoking `setup.py` so
    #   setuptools doesn'"'"'t think the script is `-c`. This avoids the following warning:
    #     manifest_maker: standard file '"'"'-c'"'"' not found".
    # - It generates a shim setup.py, for handling setup.cfg-only projects.
    import os, sys, tokenize

    try:
        import setuptools
    except ImportError as error:
        print(
            "ERROR: Can not execute `setup.py` since setuptools is not available in "
            "the build environment.",
            file=sys.stderr,
        )
        sys.exit(1)

    __file__ = %r
    sys.argv[0] = __file__

    if os.path.exists(__file__):
        filename = __file__
        with tokenize.open(__file__) as f:
            setup_py_code = f.read()
    else:
        filename = "<auto-generated setuptools caller>"
        setup_py_code = "from setuptools import setup; setup()"

    exec(compile(setup_py_code, filename, "exec"))
    '"'"''"'"''"'"' % ('"'"'/mnt/home/lgarrison/nufft-ls/setup.py'"'"',), "<pip-setuptools-caller>", "exec"))' develop --no-deps
    cwd: /mnt/home/lgarrison/nufft-ls/
error: subprocess-exited-with-error

× python setup.py develop did not run successfully.
│ exit code: 1
╰─> See above for output.

note: This error originates from a subprocess, and is likely not a problem with pip.
(nufft-ls-py39) lgarrison@ccalin008:~/nufft-ls$

@dfm any ideas? I've looked around for similar issue reports but can't find any. I'll try again from scratch with a dummy pybind11 project and see if the error persists...
Interestingly, pip install pybind11, which solved #7, does not solve the problem for me, nor does --no-build-isolation.

I'll take a look!

@lgarrison: any reason why you switched to using intree_extensions? The following diff (reverting a change you made) fixes it for me:
- ext_modules = intree_extensions(["src/nufft_ls/cpu.cpp"])
- ext_modules[0].include_dirs = ['include/']
- ext_modules[0].language = 'c++'
+ ext_modules = [
+     Pybind11Extension(
+         "nufft_ls.cpu", ["src/nufft_ls/cpu.cpp"], include_dirs=["include"]
+     )
+ ]

No particular reason! I was mostly just trying it because the docs suggested it was an option when you want to lay out your source files this way.  (And I know I tried reverting that change while debugging this... will confirm the fix asap!)
And I guess I thought that those two formulations were supposed to be equivalent! Any idea why one would work and the other not?

Yeah the docs make it sound like they should be but perhaps the issue is with manually setting the include_dirs or something?


support composition api natively with vue 2.7

It will be great!

Did https://github.com/nuxt/bridge/pull/378 close this issue?

you are quite right - it did!


Hotel list item UI

Steps to reproduce

Select Travel
Select Hotel Booking
The following screen opens up:

Expected behaviour

Change the list item UI to grid view, where each item looks like this:

There should be 2 elements in each row

On selecting Top for more details, this should come up:

We won't be needing grid view. We will show the items in a RecyclerView with a Horizontal LinearLayoutManager

Would like to work on this.


Fix the cache metrics

They are fluctuating. Maybe due to terminated uvicorn workers (see https://github.com/huggingface/datasets-server/issues/889)? Or to how we aggregate the metrics in Grafana (we take the median of all reports: quantile by(kind) (0.5, sum by (pid, kind) (responses_in_cache_total)))
We should have about the same number of entries for each split-level step, config-level step, and dataset-level step, but that's not the case.

Maybe the admin service has issues. I could see it being recreated:

It didn't appear again since we changed the EFS parameter (throughput) in the infra. See https://huggingface.slack.com/archives/C04L6P8KNQ5/p1699627835715149 (internal).
Let's keep open a bit, to be sure the problem has gone

We did not observe for three days now. Closing.

We have the issue again, just after sync'ing a new version to prod:

See https://github.com/huggingface/infra/pull/863 (internal). It was an issue with the query I put in Grafana! Everything is right in the code...


Does this work with Kotlin native?

This notice here is a bit confusing: https://github.com/SalomonBrys/Kodein/tree/master/demo-native

Not yet, it will be as soon as Kotlin Native implements these: https://github.com/SalomonBrys/Kodein/tree/master/kodein-native

@SalomonBrys thanks


feature/ccls-1974_proceedings_and_costs

Added 15 additional endpoints to the api, to manage prior authorities, scope limitations, proceedings, cost structures and clients.
Includes:

CCLS-1976
CCLS-1977
CCLS-1978
CCLS-1979
CCLS-1980
CCLS-1981
CCLS-1982
CCLS-1983
CCLS-1984
CCLS-1985
CCLS-1986
CCLS-1987
CCLS-1988
CCLS-1989
CCLS-1957 (bug fix)

Just need cost limitations integration test


Upgrade several build dependencies.

This is mostly taken from what @risdenk did on the Solr side of the build.

Not sure what's failing here, will take a look later. I suspect errorprone.

Looks like error-prone fails saying that PublicConstructorForAbstractClass is not a valid checker name.
We explicitly disable it currently:
gradle/validation/error-prone.gradle:            '-Xep:PublicConstructorForAbstractClass:OFF'

Yeah, thanks, Robert. I'll be looking into this - have an hour to spare at the airport anyway.

Right - this check was removed here: https://github.com/google/error-prone/commit/b4c6a03168102026bb6540627b21b356804250e4

Another check was removed here: https://github.com/google/error-prone/pull/2809

oh, one question @dweiss, since javacc is upgraded, should we force a gradlew regenerate?

oh, one question @dweiss, since javacc is upgraded, should we force a gradlew regenerate?

Hmmm.. isn't javacc part of the checksum? It should regenerate itself when javacc is upgraded. If it's not then it's something that should be corrected there. I did run regenerate after updating stuff and it returns cleanly.

I re-ran javacc and the generated files just seem to be identical.

Sorry, I was wrong about javacc and possibly other tasks - I'll do a follow-up.


reactFX memory leak

When I use GenericStyledArea in tabPane and remove it from content.
After usage for a long time, the areas will never get gc;
Because it holds by ALWAYS_TRUE.

I read the richtext code long time, and I find that
the CaretNode.java has static field "ALWAYS_TRUE", and it extends ObservableBase with list field "ListHelper observers";

Every time create GenericStyledArea.class will get
caretSelectionBind = new CaretSelectionBindImpl<>("main-caret", "main-selection",this);
or
new CaretNode

EventStream<Boolean> blinkCaret = showCaret.values()
                .flatMap(mode -> { //this lamda stands for next code 'f'
                    switch (mode) {
                        case ON:   return ALWAYS_TRUE;
                        case OFF:  return ALWAYS_FALSE;
                        default:
                        case AUTO: return area.autoCaretBlink();
                    }
                });

    default <U> EventStream<U> flatMap(Function<? super T, ? extends EventStream<U>> f) {
        return new FlatMapStream<>(this, f); //
    }

while, the lamda is hold the out object GenericStyledArea.class
At last, call the ALWAYS_TRUE 's parent function (ObservableBase.java ), addObserver,
 private ListHelper<O> observers = null;
this lamda f will hold the out object area, in the list observers; but never removeObserver from observers list.
So the ALWAYS_TRUE  is a static field, will hold all created GenericStyledArea.
Hope for your comment. Maybe I'm wrong but tell me how to gc area after I have remove it from tab or other parent.

Finally, I figure out that
        try {
            CaretNode node = (CaretNode) ReflectionUtils.getPrivateField(getCaretSelectionBind(), "delegateCaret");
            //    private CaretSelectionBind<PS, SEG, S> caretSelectionBind;  //GenericStyledArea.java 's member
            node.dispose();
        } catch (NoSuchFieldException | IllegalAccessException e) {
            e.printStackTrace();
        }


AMD ROCm Card can not use flash attention

What is the issue?
My cards is w7900, and rocm driver is 6.3 , I found the llama-cpp server started by Ollama  always without -fa flag.
I check the code , found :
           // only cuda (compute capability 7+) and metal support flash attention
	if g.Library != "metal" && (g.Library != "cuda" || g.DriverMajor < 7) {
		flashAttnEnabled = false
	}

This code sames wrong.
Ref:  https://github.com/Dao-AILab/flash-attention/pull/1010   Support for RoCM has been added tk flash attention 2
OS
Linux
GPU
AMD
CPU
Intel
Ollama version
No response

It looks like support may be limited to the MI200 and MI300 GPUs - https://github.com/ROCm/flash-attention?tab=readme-ov-file#amd-rocm-support

I would love to see this work with multiple w7900s.  I have 3x w7900 + 1x 6800 working without flash attention.  I want 4x w7900 working with flash attention.

May be fixed when/if https://github.com/Dao-AILab/flash-attention/pull/1203 gets merged.

May be fixed when/if Dao-AILab/flash-attention#1203 gets merged.

It was merged. Would it be possible to have it in Ollama?


md-select-options don't inherit width from md-select

What is affected?
Component
Description
When changing the width of a mdc-select the options menu do not inherit the same width.

Reproduction
https://stackblitz.com/edit/au2-conventions-testrq?file=src%2Fmy-app.html
Workaround
None known at this time
Is this a regression?
No or unsure. This never worked, or I haven't tried before.
Affected versions
1.0.1
Browser/OS/Node environment
Chrome
MacOS
Node 20
PNPM Package Manager v8

please use min-width. This needs documenting


Bug fixes for integration with TreeSaplings-Redux

To avoid trees getting lost, and to avoid Noxys_Trees spawning saplings.

Alright and released. Thanks!


traffic shaper: add a ! for negated fields

probably not the cleanest solution but it works. -> ticket #2004

@fabianfrz not bad at all, thanks!

@AdSchellevis not sure if I can get the json out of it.

@fabianfrz I see what you mean, let me try something

@fabianfrz here you are https://github.com/opnsense/core/commit/78686814a472df4a9cce69ee15b7f31d9cf1ffa2 , you can easily ditch the json conversion because the object is send to the conversion function.

@AdSchellevis this will be probably a requirement for the firewall sections too when the migration will start.

@fabianfrz I'm not sure bootgrid will be good enough to restructure the firewall section, but we'll see


Common DB interface?

Hi, first of all, awesome project. This kind of things are always needed for UI-like app.
Would you consider writing a common interface so that a different database can be used? for example Cassandra (via gocql)?

Thanks for this issue!
Currently casbin adopts an adapter model for policy persistence. It already supports file, RDBMS, but not NoSQL yet.
After googling around NoSQL, I found Cassandra, MongoDB, HBase, etc. They have different clients in Go, so they can't be supported by the same code. Which NoSQL DB do you think is better or are you using? Of course, if there's a general client for all NoSQL DBs, it would be best.

I am currently at an all 100% Cassandra shop :)
I think you can support multiple databases by structuring them under separate directory (package).
In each package you can then expose the DB handler factory by using init() so that user can pick and choose which one to load during runtime.
With a common interface, you can just pick a few of the most popular ones and let contributors add their favorite databases themselves.
Just my 2 cents.

Hi. I have downloaded the tar ball of Cassandra and run bin/cassandra -f -R in my Ubuntu. But I failed to connect to it via DBeaver (a GUI client that supports Cassandra DB) as the below picture.
I don't know what is the keyspace, and the default user password?

default installation should provide an admin user called cassandra/cassandra for username and password.
From there, you can create a new keyspace.

Hi.
Cassandra support has been added to casbin since 0.0.5. It uses a plugin design to keep the main code light-weight.
Please see details at: https://github.com/hsluoyz/casbin#persistence

I will close it for now since it has been solved.


pyubx2 stop processing when there is a broken data in the ubx file.

May I ask for your assistance with regard to an issue I am encountering?
It appears that when there is broken data in the UBX file, the program Pyubx2 raises an exception and stops processing.
The error message associated with this exception is "'str' object has no attribute 'dict'".
I have noticed that this issue persists even with the latest version 1.2.23.
I kindly request your help in addressing this issue.
Would it be possible to continue the procedure despite the error data by simply displaying some messages?
For your information, my operating system is Windows 10 and I am recording logs via U-center v22.05.
The device model I am using is the u-blox NEO-9M, and the protocol in use is UBX_PROTOCOL.
Thank you for your attention to this matter. I sincerely appreciate any response or assistance you can provide.

HI @yang-neu
Please provide the FULL TRACEBACK of the error message you're getting and, if possible, a copy of the UBX file you're trying to process. Thank you.

No worries. More than happy to consider any enhancements that may make life easier.


find_package feature

For now I used StackOverFlow to write the cmake and reorder the project tree in feature/shared_labrary branch.
Currently there is a pkg conf file that I don't know if it is right.
Intended to write EXPORTS and installing rules in order to make find_package available for the library.

Looking at this might help to write a better cmake.

It's a screenshot from Deep CMake for Library Authors - Craig Scott - CppCon 2019 .
It says, with this code snippet cmake will generate the ConfigVersion.cmake file.

Definitely look at the presentation file  of Deep CMake for Library Authors - Craig Scott - CppCon 2019


Add .gitignore and .npmignore files

...so other developers won't see node_modules/*files as changes!

Fixed in e0e2117b1ed231351a27630621c40c3f551d3d63. I've excluded the image directories from npm as it makes the package quite large because of the screenshots that are not used in the actual code.

i would not exclude the images/ directory... if the readme.md files references them (and it should!)

It's excluded only from the npm package. Do you think someone reads the raw readme.md and views the images in the node_modules/ directory?
I think that people use either github or the npm package page to read the documentation since it's nicely formatted and "clickable" HTML.

in truth, i think that some people do actually that; however, no harm in excluding it and see if you get feedback that confirms my thinking...

Okay. I'm new to the whole npm ecosystem, so I might be easily wrong. I'll be happy to fix it later, but for now I prefer small package over complete documentation. The repo contains 6 MB of images and 15 kB of code.

+1


AWSLambda - Error when removing unknown permission

Fixes #4227
Test was verified against AWS

Codecov Report

Merging #4846 (97812fd) into master (a94f72c) will increase coverage by 0.06%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #4846      +/-   ##
==========================================
+ Coverage   95.06%   95.13%   +0.06%
==========================================
  Files         589      594       +5
  Lines       62879    64088    +1209
==========================================
+ Hits        59779    60970    +1191
- Misses       3100     3118      +18

Flag
Coverage Δ

servertests
35.93% <23.80%> (-0.23%)
:arrow_down:

unittests
95.07% <100.00%> (+0.07%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

moto/awslambda/exceptions.py
95.65% <100.00%> (+0.41%)
:arrow_up:

moto/awslambda/policy.py
94.87% <100.00%> (+0.13%)
:arrow_up:

moto/awslambda/responses.py
92.09% <100.00%> (+0.47%)
:arrow_up:

moto/resourcegroupstaggingapi/models.py
83.66% <0.00%> (-0.58%)
:arrow_down:

moto/route53/responses.py
97.18% <0.00%> (-0.41%)
:arrow_down:

moto/sns/models.py
96.82% <0.00%> (-0.40%)
:arrow_down:

moto/sqs/models.py
96.75% <0.00%> (-0.18%)
:arrow_down:

moto/config/models.py
99.21% <0.00%> (-0.14%)
:arrow_down:

moto/ses/models.py
96.84% <0.00%> (-0.12%)
:arrow_down:

moto/ssm/models.py
94.21% <0.00%> (-0.12%)
:arrow_down:

... and 14 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a94f72c...97812fd. Read the comment docs.


Crashes on search

What steps will reproduce the problem?
Search Werewolf
What is the expected behavior? What do you get instead?
Should come up with results in either Merged or non-merged view, instead I crash
What version of the program are you using? On what operating system?
v5.0.1 win7
Please provide any additional information below
I search with 25 set for images.
Here' s my crash log.
https://volafile.io/r/9662agx8
If there's anything else you need, please ask me to upload it.

If there's anything else you need, please ask me to upload it.

The main.log file right after a crash (before restarting Grabber) would be of great help!
Because I couldn't reproduce said crashes, even with the crash dumps.

resposted

I believe I may have had this crash as well, however I cannot reproduce it.. I wonder if it's related to the Sankaku issue that was fixed... Sorry that I can't provide a log.. What I had problems with is merged view was not loading so I turned merged view off, reloaded, then changed it back and as soon as I ticked the box I got a crash.

@SultrySamthepennanceman @Drakonas still happening?

I just tested and it did not crash. It may have been related to my reported issue where searching and then changing from non-merged to merged or vice versa while it is searching would cause a crash, but the developer fixed that issue already. But of course I'm not sure if that was the issue with this submission. The OP is a bit vague here.

In that case, I'm guessing this can be closed then.


Sort filtered statuses

Dicts have arbitrary ordering, so we utilize a list
Addresses #1

Awesome, thanks!


Ability to add a loading message below Spinner

Would it be possible to add the ability to add a loading message to the spinner? I understand this is just a spinner, but it also a valid use case to use this for loading certain pages, and the ability to display a message could be useful as well. Not sure if this is a feature request at this point, or if it is more of a question as to if this should even happen.
My thought was that this could just be another option to set when initializing the spinner, such as loadingMessage, if it is set we would append it to the bottom of the spinner. I think we would need to get somewhat creative on the font size also, as the size of the spinner can differ also.
The problem is that with the positioning of the spinner it is difficult to mimic the same behavior of determining the absolute positioning, if we are trying to just append a message. Thoughts?

Check out this tutorial. Good way to add a loading message.
http://jigneshpatel-dotnet.blogspot.com/2013/03/waiting-spinner-for-long-running-form.html

This would likely be a useful feature, but I don't think it makes sense to be part of the core spin.js library. Feel free to create a new wrapper module that implements it.


Expose registration options?

Currently you cannot inspect the registration. So in your code you need to keep track of what options belong to what ID. Oftentimes I think we reach the conclusion that we would like to be able to inspect those values which would argue for a slightly different design here.
E.g. we could introduce a SyncRegistration object that you construct with an ID and options and you would register that object (and getRegistrations would return copies of them).

Agreed. We do this for the Push API. This also makes the API easier to extend in future.

Sounds good to me.

annevk: can you create a patch?


tests: Try to fix flaky testKillSelectSysTableJobById

Due to the change in 89d8ed5463455952fd841322d09566b13b3b6156 it takes a
bit longer for the sys.jobs entry to appear.

@matriv please review

assertBusy is not an option?

Igtm


update notices_url and message

The "notification_notices" url name no longer exists.
Since only "notification_notice_settings" is provided with the project now,
I added it to the default email template and changed the text in the template
to remove an indication of viewing the notices when changing the notification
settings

Still having this error, even with the rename fix.  Trying to track down the culprit.

@Cgeist7: Are you including urls.py in your project?
From the docs

Add entry to your urls.py:

url(r"^notifications/", include("pinax.notifications.urls"))

Hello,
Yes. I followed the docs instructions. I stopped getting the error after migrating the database for notifications. This should probably go in the docs for simple folks like me. I am running Django 1.8.1 and Python 3.4.2.
After the update, however, the emails still were not being sent (functions were called properly).
Also, the Admin panel a) would not accept email as a valid option for notification type and b) requests a default for which the purpose isn't entirely clear.
It was late, so I rolled back my changes, but I'll try again tonight.
Chris
Sent from my iPhone

On May 22, 2015, at 1:11 AM, Jacob Wegner<EMAIL_ADDRESS>wrote:
@Cgeist7: Are you including urls.py in your project?
From the docs
Add entry to your urls.py:
url(r"^notifications/", include("pinax.notifications.urls"))
—
Reply to this email directly or view it on GitHub.


Making a Highchart object

I was thinking about refactoring your code a little bit by making a Highchart object as in class Highchart(object): and would make the serialize function use this object and behave the exact same way it does at the moment.
I want to do that to be able to generate the object (without using the serialize function), alter the data structure at will, and then render it my way.
Would you review / accept such a PR?

Hello,
Sorry for the late answer. If i understood correctly, you want an Highchart class so that you can inherit from it and implement your own rendering?
If yes it would be nice

I ended up building my own class and reused some of your code along the way:
https://github.com/mistercrunch/panoramix/blob/master/app/highchart.py


Build process failing on autodoc

Details

Project URL: http://openpyxl.readthedocs.io/en/latest/index.html
Build URL (if applicable): https://readthedocs.org/projects/openpyxl/builds/6944717/
Read the Docs username (if applicable):

Expected Result
The docs to be be buildt
Actual Result
A description of what actually happened
Exception occurred:
  File "conf.py", line 272, in run_apidoc
    from sphinx.ext.apidoc import main
ImportError: No module named 'sphinx.ext.apidoc'

The full traceback is available at the build. I don't know why the exception is being raised. I can't replicate it locally and I have a dedicated tox environment for building docs, though the configuration is slightly different. It looks like this is an RTD-specific failure but if it's something to do with the way I've set things up I'd love to know.

Did you tested it with sphinx==1.6.5? That is the sphinx version that rtd uses. You can use a mayor version by putting it on a requirements file.

Incompatible changes
1.7.0b1
...
#3929: apidoc: Move sphinx.apidoc to sphinx.ext.apidoc

From the changelog
https://github.com/sphinx-doc/sphinx/pull/3929/

When testing locally with the same setup as RTD I get Sphinx 1.6.5 but I don't get the exception. This isn't surprising seeing as the import already reflects the change in packaging.

@Themanwithoutaplan This is from a virtualenv with sphinx 1.6.5
>>> import sphinx
>>> import sphinx.ext.apidoc
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
ModuleNotFoundError: No module named 'sphinx.ext.apidoc'
>>> sphinx.__version__
'1.6.5'
>>> import sphinx.apidoc
>>>

It seems the import is the problem. Adding a try…except resolves it.

Thanks for letting us know, @Themanwithoutaplan!

Of course, it would be really nice if we didn't have to shoehorn APIDOC support into RTD like this.


Thermal Comfort -- Mean Radiant Temperature

I think we should avoid referring to projects that contribute data to the CDS, such as ERA5-HEAT.
To define the percentiles, there has to be a reference period. I believe this is 1971-2000, although the documentation is ambiguous. We could ask Sam to check.
I think it is worth mentioning in the page text that a 30year running mean is being shown.

I've removed references to ERA5-HEAT.


[Release] Bumped postgres version to 9.0.0

What does this PR do?
Bumped postgres version to 9.0.0
Motivation

Additional Notes

Review checklist (to be filled by reviewers)

[ ] Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
[ ] PR title must be written as a CHANGELOG entry (see why)
[ ] Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
[ ] PR must have changelog/ and integration/ labels attached

See https://github.com/DataDog/integrations-core/pull/9771/s


hg_test* hangs using verbs;ofi_rxm with concurrent handles

Examples include hg_test_rpc, hg_test_rpc_lat, and hg_test_write_bw, all of which work correctly until the phase of the test that uses multiple handles or concurrent RPCs.  This is with libfabric 1.6 and the mlx5_0 interface.
They still hang when #231 is applied.

Current Mercury origin/master runs all of these tests to completion when built against current libfabric origin/master (without applying any additional PRs).
Need to test this further.  What about 1.6.1?  What do we do with #231 (maybe we should clean up in the other direction and remove some special cases?).

Since support for verbs RDM has been dropped, I'd be inclined to keep only one of them...

Agreed re: eliminating the extra verbs path.  I just opened #236 to track that separately and closed #231 since that isn't that right approach.
We can continue to use this issue to track the deadlock specifically.

I get the same deadlock when using libfabric 1.6.1 built from a spack package.  I'll try creating a spack package that pulls from libfabric master to see if that makes a difference of there was some other difference in my manual of libfabric build that accounted for the change.

That observation about the libfabric version was a false alarm; I also get the hangs if I build libfabric with a modified spack package that pulls from origin master.
The difference was probably an unrelated coincidence, like my manual build being built with debugging symbols.
Need to go back and debug properly.

I was able to trigger the hang while running the example (in particular, the hg_test_read_bw example with #237 applied) with debugging symbols.
The server has one thread running a progress loop while the rest wait on a condition variable.  This is probably normal unless an operation has gotten lost and didn't signal completion.
The client is in an HG_Progress() call with an unusually long timeout, which stems from test_read_bw.c calling hg_request_wait() with HG_MAX_IDLE_TIME.  I tried recompiling with smaller values ranging from 0 to 1000 in the hg_request_wait() timeout argument so that I could observe data structures while it re-enters the HG_Progress call.  Lower timeout values cause the test program to hit this error, though:
# HG -- Error -- /home/carns/working/src/mochi/mercury/src/mercury_core.c:4717
 # HG_Core_forward(): Not safe to use HG core handle, handle is still in use, refcount: 2

Are there any test programs that stress concurrency without using the hg_request api?  I'd like to narrow it down to something simpler.  If not, I can set up margo runs with multiple OS threads (the benchmarks are capable of this, I just don't normally run it that way) to try a different but not necessarily simpler code path.

Actually the margo version of this (using margo-p2p-bw and varying the -c (concurrency) and -T (number of os threads)) is fairly easy to run.  I can't reproduce the hang with it, though. I tried 3 cases, where the concurrency is less than, equal to, or greater than the number of os threads, and none of them exhibited a problem.
I'm marking this as a "minor" issue now, because as best I can tell it is only triggered with the hg_request api.  Not sure how widely used that is outside of the test programs right now.

Hmm ok thanks, I will have a look at the hg_request stuff. No all the tests use that for now...


Please provide support for tf SavedModel format

I was trying to integrate Keras Core into my existing model development pipeline. My pipeline uses the TF saved model format for inference since it is the easiest to load in another application without worrying about custom objects.
I am getting the following error when trying to save the trained model in tf saved model format: model.save(model_folder,save_format="tf")
ValueError: 'h5'and't5'formats are no longer supported via thesave_formatoption. Please use the new'keras' format. Received: save_format=tf
If I can't save in saved model format, it is difficult to use Keras Core in the existing pipeline. Could you suggest a workaround?

You should be able to do tf.saved_model.save(model, ...) right now.
We are in fact adding limited support for SavedModel in Keras Core, which will be included in Keras 3.

Thanks for the suggestion, @fchollet. I can save using tf.saved_model.save. But I can only use tf.saved_model.load to load the saved model.  Both keras_core.models.load_model and tf.keras.models.load_model doesn't work when loading models saved using tf.saved_model.save. So I cannot use model.predict or model.evaluate. Support for SavedModel in Keras Core would be highly appreciated.

You should really be using a .keras file you intend to be able to reload the model as a Keras model. SavedModel is for inference-only export.


Verify Merge Restate Behavior

Expected Behavior:

When a restatement is issued against a merge model then it will restate the data with a start date of the earliest of the restatement dates and an end date of the latest cadence.
Merge needs to run sequentially when both run locally and in Airflow
Merge needs to understand and implement batch sizes

@eakmanrq is this still necessary?


Add functionality to destroy a node

See https://jira.mesosphere.com/browse/DCOS_OSS-3516

Codecov Report

Merging #986 into master will decrease coverage by 79.25%.
The diff coverage is 28.57%.

@@             Coverage Diff             @@
##           master     #986       +/-   ##
===========================================
- Coverage     100%   20.74%   -79.26%
===========================================
  Files          28       28
  Lines        1683     1702       +19
  Branches       61       61
===========================================
- Hits         1683      353     -1330
- Misses          0     1348     +1348
- Partials        0        1        +1

Impacted Files
Coverage Δ

tests/test_dcos_e2e/test_cluster.py
0% <0%> (-100%)
:arrow_down:

src/dcos_e2e/backends/_base_classes.py
100% <100%> (ø)
:arrow_up:

tests/test_dcos_e2e/backends/aws/test_aws.py
40.5% <20%> (-59.5%)
:arrow_down:

src/dcos_e2e/backends/_aws/__init__.py
37.11% <50%> (-62.89%)
:arrow_down:

src/dcos_e2e/backends/_docker/__init__.py
28.31% <50%> (-71.69%)
:arrow_down:

src/dcos_e2e/cluster.py
41.11% <50%> (-58.89%)
:arrow_down:

...est_dcos_e2e/backends/docker/test_distributions.py
0% <0%> (-100%)
:arrow_down:

tests/test_dcos_e2e/backends/docker/test_docker.py
0% <0%> (-100%)
:arrow_down:

tests/test_dcos_e2e/test_enterprise.py
0% <0%> (-100%)
:arrow_down:

... and 16 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5ee6951...591684f. Read the comment docs.


Add audio speed setting at project level.

As a user, I want audio speed setting at project level so I and adjust it on project level.

This feature has been implemented.


IO.e, IO.d, IO.f are not searchable

SEE: https://docs.perl6.org/language/io#Checking_files_and_directories

they are defined but not doced in IO::Path and IO::Handle. As soon as those methods are doced they will be searchable automatically (for small values of searchable, a single "e" gets tons of hits that are not sorted by length).

@gfldex
Thanks! I added the "docs" tag.
SEE ALSO:
https://github.com/rakudo/rakudo/blob/nom/src/core/IO/Path.pm#L541-L554
https://github.com/rakudo/rakudo/blob/nom/src/core/IO/Handle.pm#L749-L751

fixed with 027db9e


[BREAK] Refactor okhttp-clients: handle all custom behavior by wrapping calls in RemotingOkHttpCall

In particular, removes all non-local behavior from interceptors

@nziebart @iamdanfox ready for you again.

The overall approach looks like it'll be a huge improvement in maintainability - I can't speak for the exact QOS handling that's been rewritten, but everything I understood looks great :)

cool, thanks for taking the time to review, Dan.

now, the big question: do we need to call this 4.0.0?


ci: add body to ui report

add body to ui screenshots:

Loving all the tests we're getting in before the refactors!

This would be super helpful to have too: https://github.com/commaai/openpilot/issues/33430


Auto Formatting Doesn't work

Type: Bug
I can't seem to find the reason that is causing my visual studio code to not auto formatting on save.
VS Code version: Code 1.84.2 (1a5daa3a0231a0fbba4f14db7ec463cf99d7768e, 2023-11-09T10:51:52.184Z)
OS version: Windows_NT x64 10.0.19045
Modes:

System Info

Item
Value

CPUs
Intel(R) Celeron(R) CPU  N2840  @ 2.16GHz (2 x 2167)

GPU Status
2d_canvas: enabledcanvas_oop_rasterization: enabled_ondirect_rendering_display_compositor: disabled_off_okgpu_compositing: enabledmultiple_raster_threads: disabled_offopengl: enabled_onrasterization: enabledraw_draw: disabled_off_okvideo_decode: enabledvideo_encode: unavailable_offvulkan: disabled_offwebgl: enabledwebgl2: enabledwebgpu: enabled

Load (avg)
undefined

Memory (System)
3.88GB (0.96GB free)

Process Argv
--crash-reporter-id 0b448e51-fae9-4229-9adb-b9e231de8580

Screen Reader
no

VM
0%

Extensions (9)

Extension
Author (truncated)
Version

htmltagwrap
bra
1.0.0

prettier-vscode
esb
10.1.0

vscode-docker
ms-
1.28.0

indent-rainbow
ode
8.3.1

LiveServer
rit
5.7.9

errorlens
use
3.15.0

intellicode-api-usage-examples
Vis
0.2.8

vscodeintellicode
Vis
1.2.30

vscode-icons
vsc
12.6.0

(1 theme extensions excluded)

A/B Experiments
vsliv368:30146709
vsreu685:30147344
python383cf:30185419
vspor879:30202332
vspor708:30202333
vspor363:30204092
vswsl492:30256859
vslsvsres303:30308271
vserr242cf:30382550
pythontb:30283811
vsjup518:30340749
pythonptprofiler:30281270
vshan820:30294714
vstes263:30335439
vscod805cf:30301675
binariesv615:30325510
bridge0708:30335490
bridge0723:30353136
vsaa593:30376534
pythonvs932:30410667
py29gd2263cf:30880073
vsclangdc:30486549
c4g48928:30535728
dsvsc012:30540252
pynewext54:30695312
azure-dev_surveyone:30548225
3biah626:30602489
f6dab269:30613381
a9j8j154:30646983
showlangstatbar:30737416
pythonfmttext:30731395
fixshowwlkth:30771522
showindicator:30805244
pythongtdpath:30769146
i26e3531:30792625
welcomedialogc:30887144
pythonnosmt12:30797651
pythonidxpt:30866567
pythonnoceb:30805159
asynctok:30869155
dsvsc013:30795093
dsvsc014:30804076
dsvsc015:30845448
pythontestfixt:30871694
pythonregdiag2:30871582
pyreplss1:30897532
pythonmypyd1:30879173
pythoncet0:30885854
h48ei257:30885898
pythontbext0:30879054
accentitlementsc:30887149
dsvsc016cf:30886111
dsvsc017cf:30886113
dsvsc018:30886114
aa_t_chat:30882232

I had the same problem
版本: 1.84.2 (Universal)
提交: 1a5daa3a0231a0fbba4f14db7ec463cf99d7768e
日期: 2023-11-09T10:52:33.687Z
Electron: 25.9.2
ElectronBuildId: 24603566
Chromium: 114.0.5735.289
Node.js: 18.15.0
V8: <IP_ADDRESS>-electron.0
OS: Darwin arm64 23.1.0

/needsMoreInfo
You need to at least specify what, language, code, ans formatting related settings you have.

Thanks for creating this issue! We figured it's missing some basic information or in some other way doesn't follow our issue reporting guidelines. Please take the time to review these and update the issue.
Happy Coding!

Same issue for me!

Hey @jrieken, this issue might need further attention.
@Esporto, you can help us out by closing this issue if the problem no longer exists, or adding more information.

This issue is caused by an extension, please file it with the repository (or contact) the extension has linked in its overview in VS Code or the marketplace for VS Code. See also our issue reporting guidelines. If you don't know which extension is causing the problem, you can run Help: Start extension bisect from the command palette (F1) to help identify the problem extension.
Happy Coding!


toogle not working well on RTL page

On RTL  page, clicking the white area doesn't toggle the switch from left to right
(every thing else is OK)
thanks

It is not related to RTL

duplicate of #481


[Designer] Bug 40020188: [ProductVideo.json-Video Slider.]: Screen reader is not announcing instant feedback when change values with the help of slider.

Problem Description
Bug 40020188: [ProductVideo.json-Video Slider.]: Screen reader is not announcing instant feedback when change values with the help of slider.
Card JSON
[Bug 40020188](https://microsoft.visualstudio.com/OS/_workitems/edit/40020188): [ProductVideo.json-Video Slider.]: Screen reader is not announcing instant feedback when change values with the help of slider.

Screenshot
No response

Closing this issue as of now this issue is repro'ing intermittent at our end.


Issue with rubocop linter

Please see here - https://github.com/AtomLinter/linter-rubocop/issues/145#issuecomment-235737672
In haml files that use String Interpolation '#{}', it seems to be using an incorrect scope.

I will check this out later this week. In the meantime, pull requests are always welcome!

Hey, I'd love to get some help here. I've tried modifying the scopes, but it breaks the Ruby syntax highlighting for some reason. I'll try to dig in more when I have time, but I'm pretty busy atm.

I believe this is now resolved with #60. Let me know if it is still an issue.


Xcode 11.3.1 Compatibility

This pod is causing Xcode to constantly crash after I've added it to the project. Now I can't access my project anymore it seems. Any advice?

Managed to get the project stable again by removing it from the storyboard and just adding a container view instead and adding the StartWars text view in code. However it is off-center and animating from the middle. Any advice?

Got it working by only adding a container view in the storyboard and adding the StarWarsTextView in code. Scrolling to the top and starting the animation again does not seem to work though..

This pod is poorly made and hard to configure properly. I will replace or remove it some day when get more time
Sorry for high hopes

On Feb 28, 2020, at 2:28 PM, anroswart<EMAIL_ADDRESS>wrote:
Got it working by only adding a container view in the storyboard and adding the StarWarsTextView in code. Scrolling to the top and starting the animation again does not seem to work though..
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub https://github.com/PauliusVindzigelskis/StarWarsTextView/issues/1?email_source=notifications&email_token=AASGAHIR6PJZDJBK32JZL7TRFFXXZA5CNFSM4K5K7ZCKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOENKBSDY#issuecomment-592713999, or unsubscribe https://github.com/notifications/unsubscribe-auth/AASGAHL5R3C4MKRIHMUQC7DRFFXXZANCNFSM4K5K7ZCA.


Import records from source buttons are missing in Django admin

The missing page is accessible via URL: https://prosody.princeton.edu/admin/archive/digitizedwork/import/
But the buttons are missing from the Digitized Works page.
RSK says we should be able to write a simple unit test that checks the rendered page and confirms the button and url are present and suspects the bug is due to a django admin change that we missed.

"Import" button now appears on admin page but first round of testing yielded 500 error upon attempted import. @rlskoeser said that updating to the newer version of pymarc was resulting in an error instead of an empty value for a missing marc field. After she reverted to an earlier pymarc version, I retested with several HathiTrust and also Gale IDs. Behaved as expected with new IDs, IDs already in database, and invalid IDs.


I don't see the option to generate the classes

Linux, Android studio 3.0.1, JSONToKotlinClass 1.5.1
I don't see the option to generate the classes when I rightclick on a package.
However, it available on Alt+K inside a file.

@joshdaquino, Hi! I thing you are using another plugin for json. You can download my at https://plugins.jetbrains.com/plugin/10054-generate-kotlin-data-classes-from-json. The latest version is 0.8.4. And you say you are using JSONToKotlinClass 1.5.1. Maybe you missed github page))


[Feature] Please add a checkbox to select files for git commit

Please make files selectable when we commit files so we can decide which files are committed and which are not.

I suggest you only stage the files that you want to commit. Leave the other changed files unstaged.

Yes, this is true. The whole idea behind is... I have to use other IDE in my daily routine, which have this feature. And I started to miss this from VSCode

This feature request is now a candidate for our backlog. The community has 60 days to upvote the issue. If it receives 20 upvotes we will move it to our backlog. If not, we will close it. To learn more about how we handle feature requests, please see our documentation.
Happy Coding!

This feature request has not yet received the 20 community upvotes it takes to make to our backlog. 10 days to go. To learn more about how we handle feature requests, please see our documentation.
Happy Coding!

:slightly_frowning_face: In the last 60 days, this feature request has received less than 20 community upvotes and we closed it. Still a big Thank You to you for taking the time to create this issue! To learn more about how we handle feature requests, please see our documentation.
Happy Coding!


Java 9 compatibility

Since Java 9 JDKs show versions numers like "9...." instead of "1.9....", we have to adjust jdk version detection.
For now, this version ist java 9 compatible but in the future we have to accept even more naming schemes (like "18.04", "18.10"...)

How about parsing version as a number and comparing with < 1.8? That might be less brittle, as long as there's never more than one dot in there.

I haven't even used Java 9 or even 10, so I don't know what's the version string there.
Nor if vnu.jar works there at all...

I haven't even used Java 9 or even 10, so I don't know what's the version string there.
Nor if vnu.jar works there at all...

vnu.jar works under Java9. Haven’t tested under 10 yet

The proposed solution won't work for OSX as it reports tje Java version without the 1.x
I created a patch in #120
That said, I don't think grunt-html should be responsible to test the Java version. With composer it's possible to test for the php/java version perhaps a similar approach exists for npm?

Closing this in favor of #120


Feature: allow to add blank spaces to passwords when generating a new one

when creating password is now possible to add blank spaces for "extra entropy" as requested on issue 755

Hello, can you please run spotlessApply gradle.command


fix docs combineActions, add missing : and =>

The syntax is actually correct and is method definition on objects: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Functions/Method_definitions
I understand that it's not widely known and can cause confusion. I'm happy to merge it if you could resolve the CI errors @Isaddo.

@timche  Thanks for your information and understanding
I agree with what you said, Even if the syntax is correct, it can be confusing, and it used computed key at the same time. ~But It's fine If you just close this PR without merge.~ (you have done it before I leave this comment :p)


Chef 12 opscode-reporting bootstrap is failing behind a proxy

On a fresh Chef 12 server (12.2.0-1 on OEL 6.5 x64) I've installed the opscode-reporting package and I'm trying to configure it. The host that's running the Chef server only has access to the net via a web proxy and $no_proxy is properly set to <IP_ADDRESS>,localhost on the environment and on /opt/opscode-reporting/embedded/cookbooks/solo.rb.
Running opscode-reporting-ctl reconfigure seems to break because it cant connect to chef zero. For the duration of the converge (for opscode-reporting-ctl reconfigure) I was able to see that chef-zero is indeed up and listening on localhost:8889. However the client is not able to connect to it (my guess is because it's ignoring $no_proxy and my proxy server is blocking it). Any ideas?
Here's a snippet of the output of opscode-reporting-ctl reconfigure

configure service runit_service[opscode-reporting]
Recipe: opscode-reporting::oc-reporting-pedant

template[/etc/opscode-reporting/pedant_config.rb] action create (up to date)
Recipe: opscode-reporting::default
file[/etc/opscode-reporting/opscode-reporting-running.json] action create (up to date)
[2015-10-29T13:25:53-07:00] ERROR: Timeout connecting to http://<IP_ADDRESS>:8889/nodes/den00qcw.local.com, retry 1/5
http://<IP_ADDRESS>:8889/nodes/den00qcw.local.com, retry 2/5
http://<IP_ADDRESS>:8889/nodes/den00qcw.local.com, retry 3/5
http://<IP_ADDRESS>:8889/nodes/den00qcw.local.com, retry 4/5
http://<IP_ADDRESS>:8889/nodes/den00qcw.local.com, retry 5/5
^Running handlers:
[2015-10-29T14:22:01-07:00] ERROR: Running exception handlers
Running handlers complete

[2015-10-29T14:22:01-07:00] ERROR: Exception handlers complete
[2015-10-29T14:22:01-07:00] FATAL: Stacktrace dumped to /opt/opscode-reporting/embedded/cookbooks/cache/chef-stacktrace.out
Chef Client failed. 5 resources updated in 2677.812041135 seconds
[2015-10-29T14:22:01-07:00] ERROR: Timeout connecting to http://<IP_ADDRESS>:8889/nodes/den00qcw.local.com, giving up

@metadave Looks like we might want something like: https://github.com/chef/chef-server/commit/b6e804108a041e9dd650ef2fd8f756e433f0a521 in the config that opscode-reporting-ctl is using.

ok, we'll take a look. logged as IN-89 internally

I don't think this has anything to do with proxies. I have two other users reporting the same issue and one for sure isn't using proxies.
The user I worked with was seeing this as a result of their Linux system being configured for LDAP or Active Directory authentication. Ohai's Passwd plugin gathers all of the LDAP/AD users and groups which results in a large enough node data to cause problems when ffi-yajl parses the JSON.
The embedded chef 11.12.2 uses chef-zero 2.1.2 for --local-mode. The chef-zero instance parses JSON using the embedded ffi-yajl 1.4.0 which has performance issues that weren't fixed until ffi-yajl 2.1.0.
Large node data is causing chef-zero to spend a significant time parsing JSON which means it can't send its HTTP response fast enough which results in the timeouts seen.
I've been able to reproduce this on a clean install of opscode-reporting 1.5.1 by simply creating node data larger than 1.5 megabytes using the following script, which creates a large number of linux users and groups, and then running the reconfigure command.
for i in {2000..8999}; do echo "tester-$i:x:$i:$i:::" >> /etc/passwd; echo "tester-$i:x:$i:" >> /etc/group; done
opscode-reporting-ctl reconfigure

You can run the following command as a simple test to see if your system has large node data. It uses ohai to collect the node data and then counts the number of bytes in the output.
ohai | wc --bytes

A quick workaround that works for me is to downgrade chef-zero to version 2.2 which uses the standard json library instead of ffi-yajl. Running the following commands exactly as given below will properly downgrade chef-zero.
/opt/opscode-reporting/embedded/bin/gem install chef-zero -v 2.2 --no-ri --no-rdoc
/opt/opscode-reporting/embedded/bin/gem uninstall chef-zero -v 2.2.1

A long term solution should be configuring opscode-reporting to use the latest versions of chef which in turn will use fixed versions of chef-zero and ffi-yajl.

Thanks, this fixed it. Is there a plan to include the newer version of chef-zero on a future version of the chef server?

I know this is closed - but if there are others with this ... What we faced is that in a large organization under Active Directory, the number of credentials information is ginormous so in
/opt/opscode-reporting/embedded/cookbooks/solo.rb

add
Ohai::Config[:disabled_plugins] = [ :Passwd ]
then re-ren reconfigure


Right click option to add exclusion js comment (from #1)

Not sure if right clicking the indicator is the best way to handle this, but essentially the ability to add the required comment to get jshint to ignore a particular instance of a rule violation.

Closing as this project is deprecated. 🌵


sanitize abstract

Why was this change made? 🤔
Potential suggestion to deal with https://app.honeybadger.io/projects/77112/faults/85827019, user pasted in text from a PDF into the abstract field, which breaks in postgres upon submission.  Seems like there should be a more uniform way of doing this.
How was this change tested? 🤨
Localhost

Added inline comment referencing HB and why we are sanitizing.
Added rails log when strip occurs


Documentation precision

Hello,
The document installation steps doesn't precise the file we have to modify in the /etc/pam.d. Bellow you will find the contents of this folder:

Bellow, the part of the document that is concerned by my request.

The position of the line depend on the way you want to use it.
If you use common-session, the module will be called at any opening session (gdbm, login, ssh, (x)terminal start, etc.). If that case, the module will have to be smart enough to differenciate:

local from remote sessions (typically ssh)
currently already opened sessions from new ones (using utmp for example)

To reduce the number of false positive, it is possible to set the line only to specific files in /etc/pam.d, such as
/etc/pam.d/gdm and /etc/pam.d/login. In that case, only a gdm or login (getty) session init will call the module. The counterpart is that any as the file is called only for the associated binary (gdb or login), it is easy to avoid the check (using xdm, startx or any other binary able to start a session).

Thank you for the precision.
Le jeu. 5 oct. 2017 à 17:00, Philippe Thierry<EMAIL_ADDRESS>a
écrit :

The position of the line depend on the way you want to use it.
If you use common-session, the module will be called at any opening
session (gdbm, login, ssh, (x)terminal start, etc.). If that case, the
module will have to be smart enough to differenciate:

local from remote sessions (typically ssh)
currently already opened sessions from new ones (using utmp for
example)

To reduce the number of false positive, it is possible to set the line
only to specific files in /etc/pam.d, such as
/etc/pam.d/gdm and /etc/pam.d/login. In that case, only a gdm or login
(getty) session init will call the module. The counterpart is that any as
the file is called only for the associated binary (gdb or login), it is
easy to avoid the check (using xdm, startx or any other binary able to
start a session).
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/usbwall/usbwall/issues/2#issuecomment-334492173, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AecvdmlkNsHYPB2oMRSYxaP30rQuRiv5ks5spO7rgaJpZM4Pph01
.

--
Cordialement,
Audrey MUCRET


Implementing mint Traits to add interoperability

It could probably be a great idea to implement mint Traits on most of the rlsl types defined in the rlsl-math crate. Many other crates implement it.

rlsl-math is only really for experimentation atm. In the future I intent to port something like cgmath or nalgebra to rlsl.

Noticed rlsl's libstd is #![no_std]. nalgebra now supports compiling without the standard library http://nalgebra.org/wasm_and_embedded_programming/

@memoryruins I still support the std, it is just my own version of core and std with a lot of stuff ripped out.
I am not going to lie, porting nalgebra is to rlsl is probably very hard. I still want to try to port a subset of it in the future. I looked a bit through the source code and it looks very reasonable for a 1:1 port in a lot of cases.
I still need to figure out a good way to map types to built in SPIR-V types in a non invasive manner.
At the moment I will focus on my own math library rlsl-math, because it is much easier to  develop a math library incrementally with the compiler. But it is not necessary for rlsl.
Anyone can then port their own math library to rlsl by just looking at the reference implementation rlsl-math.

Seems like the most sensible choice. First make it work well with SPIR-V types, then trait implementations (nalgebra has a “mint” trait feature flag) and crate support can come later and especially from others :)


DefaultStatisticsService removed between 3.9.0 and 3.9.6

I'm trying to upgrade from 3.9.0 to 3.9.6 and I've found that org.ehcache.core.statistics.DefaultStatisticsService has been removed.  Leaving aside the the fact that this type of change should not have been made in a patch release, how do I need to change my code to accommodate this?
    StatisticsService statsService = new DefaultStatisticsService();
    cacheManager = CacheManagerBuilder.newCacheManagerBuilder()
        .withCache(ALIAS, CacheConfigurationBuilder
            .newCacheConfigurationBuilder(String.class, CacheEntry.class,
                ResourcePoolsBuilder.heap(maxCacheEntries)
            )
            .withLoaderWriter(new PhotoCacheLoader(new StatIncrementer(loads)))
            .build()
        )
        .using(statsService)
        .build(true);

I fixed my compilation error by changing the import from org.ehcache.core.statistics.DefaultStatisticsService to org.ehcache.core.internal.statistics.DefaultStatisticsService.  But assuming internal classes shouldn't be used, what is the supported way to do this?

Started writing the following before you're second comment:
DefaultStatisticsService has moved from org.ehcache.core.statistics to org.ehcache.core.internal.statistics because it's an internal implementation class. This is why that package is not (and was not) included in the published API javadoc.
That said if you want to retrieve statistics for a cache the best way to do that right now is probably the following:
StatisticsRetrieval statsRetrievalService = new StatisticsRetrieval();

try (CacheManager cacheManager = newCacheManagerBuilder()
  .withCache("foo", newCacheConfigurationBuilder(String.class, String.class, heap(1000)))
  .using(statsRetrievalService)
  .build(true)) {

  StatisticsService statisticsService = statsRetrievalService.getStatisticsService();

  Cache<String, String> cache = cacheManager.getCache("foo", String.class, String.class);
  cache.put("foo", "bar");
  cache.get("foo");

  CacheStatistics foobar = statisticsService.getCacheStatistics("foo");
  System.out.println(foobar.getCachePuts());
  System.out.println(foobar.getCacheGets());
}

where StatisticsRetrieval looks like this:
@ServiceDependencies(StatisticsService.class)
public class StatisticsRetrieval implements Service {

  private StatisticsService statisticsService;

  @Override
  public void start(ServiceProvider<Service> serviceProvider) {
    this.statisticsService = serviceProvider.getService(StatisticsService.class);
  }

  @Override
  public void stop() {
    this.statisticsService = null;
  }

  public StatisticsService getStatisticsService() {
    return requireNonNull(statisticsService);
  }
}

This will get you a reference to the manager's statistics service of choice without imposing a specific implementation. This is also more likely to survive without needing modification on upgrades. Note however that StatisticsService is an SPI class and so is also not guaranteed to be stable under the semantic versioning scheme used by Ehcache.

Thanks for the explanation, and I take your point about the class not being officially documented, however, I still think that this change should have waited till 3.10.  Patch releases are supposed to be drop-in replacements for the same minor release that don't require any code changes.  Changing the package hierarchy of an internal class that wasn't clearly labeled as internal, and which is talked about in numerous posts online, doesn't fit with that pattern.


Fix IPIP env var for changes coming

Doc update for the change in
https://github.com/projectcalico/calicoctl/pull/1542

Addresses #526

LGTM


Expose spacing property for adjustContainerViewOrigin

It would be really nice if the spacing property used in adjustContainerViewOrigin were exposed as something users could set.
Right now, its hard-coded to 5pt, but that doesn't really mesh well with our design, where the default spacing unit is 8pt (or where we'd be using it, 16pt).
I can make a PR for this if it would help.

I made a PR for this. Its #77. Would be nice to get it merged!

@jedmund Sorry for late reply. The behavior of adjustContainerViewOrigin will be slightly different in the upcoming version(containerView will be vertically centered if there is enough space). So will not merge it for now.

1.8.2: Popup view will be vertical-centered if there is enough space when keyboard shows up.


Update dependencies for ruby 3 and fix broken specs

Hey @dNitza, not sure if you're still maintaining this gem but figured I'd send a pull request just incase.
I've completely removed the version restrictions on dependencies to ease the maintenance burden going forward.
I've also added some sensitive data filters to the VCR config to remove the PIN_SECRET key from the cassettes, perhaps they can be checked in and some Github actions CI could be setup.
I've updated any failing specs and it's all green (tested on ruby 2.7.5p203, ruby 3.0.2p107 and ruby 3.2.2).
I'm happy to help out with maintaining this if you want to give me repo access and push access to https://rubygems.org/gems/pin_up

Hey @AMHOL ! I'm not actively maintaining this anymore, but this PR is incredibly welcome, and I am more than happy to give you access to help maintain this project :)

Thanks @dNitza, hope you're well.
Is there any way I could get access to Travis CI too? Or, failing that, could you approve the build. I can't approve it and would like to make the switch to Github actions in a separate PR if possible.

Hey @AMHOL — it looks like the project has been removed from Travis CI. I've removed the reliance on the check here so you should be good to go now :)


BlockFetch test failure

The branch contains a counter example with a simple fix.
I think the test fails because block-fetch cannot be terminated when its
downloading a batch. We need to first wait for receiving all blocks and then we
it can be interrupted.

How's this looking?

I haven't worked on that.


Environments contain bindings

Another refactoring PR on top of #16; this one does a larger change to the API so that the visibility handling is moved to one place.

Thanks for the refactoring!


Update command summary of UG

@yyccbb Do you mean changes included in our current master branch only include changes from this pr? In that case should we just close this pr?


chore(deps): update dependency @glint/environment-ember-loose to v1.5.0

This PR contains the following updates:

Package
Type
Update
Change

@glint/environment-ember-loose
devDependencies
minor
1.4.0 -> 1.5.0

Release Notes

typed-ember/glint (@glint/environment-ember-loose)
v1.5.0
Compare Source
:rocket: Enhancement

core

#748 check if template is in heritage clause  (@patricklx)

Committers: 1

Patrick Pircher (@patricklx)

Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Enabled.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.

[ ] If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot.

⚠ Artifact update problem
Renovate failed to update an artifact related to this branch. You probably do not want to merge this PR as-is.
♻ Renovate will retry this branch, including artifacts, only when one of the following happens:

any of the package files in this branch needs updating, or
the branch becomes conflicted, or
you click the rebase/retry checkbox if found above, or
you rename this PR's title to start with "rebase!" to trigger it manually

The artifact failure details are included below:
File name: pnpm-lock.yaml
Scope: all 3 workspace projects
Progress: resolved 1, reused 0, downloaded 0, added 0
Progress: resolved 573, reused 0, downloaded 0, added 0
Progress: resolved 1360, reused 0, downloaded 0, added 0
 WARN  32 deprecated subdependencies found<EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS>Progress: resolved 1908, reused 0, downloaded 0, added 0, done
 ERR_PNPM_PEER_DEP_ISSUES  Unmet peer dependencies

shoelace-ember
└─┬ @glint/environment-ember-loose 1.5.0
  └── ✕ unmet peer<EMAIL_ADDRESS>found 1.4.0

test-app
└─┬ @glint/environment-ember-loose 1.5.0
  └── ✕ unmet peer<EMAIL_ADDRESS>found 1.4.0

hint: If you don't want pnpm to fail on peer dependency issues, add "strict-peer-dependencies=false" to an .npmrc file at the root of your project.


PROD SUPPORT: Complainant Address Details should be able to editable

Describe the bug
Complainant details should be edit address details

we discussed the approach - submit. FSO passes to the judge and the Judge reverts it back for update. That is when the other fields will be editable and address can be updated. If any other error is there, let it be shared offline

Discussed with @manimaarans. the case will be sent back by the Judge and then we will fix from backend. @Susmitabe let us know when the case is sent back. For completness, do provide the correct address here, which we need to use
@suresh12 @FYI
@Taherabharmal @mehulseg24 @aditiphadnis93 something to think about - while this may be a one off case, but not allowing complainant address to be modified - is this something we want to review?

Ok @manimaarans
@Susmitabe can you close the ticket?


Cdn action urls

Support for actions to use same domain as static content to support cookies
Description

Related Issue

Motivation and Context
To support auth workflows
How Has This Been Tested?
unit tests
manual testing with aio:app deploy command
Screenshots (if appropriate):
Types of changes

[ x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[x ] I have signed the Adobe Open Source CLA.
[ x] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[x ] I have read the CONTRIBUTING document.
[x ] I have added tests to cover my changes.
[ x] All new and existing tests passed.

@sandeep-paliwal could you rebase/merge to the latest master and/modify tests? I have added full test coverage + fixed some bugs.


(test) Write unit tests for each ase component

For future reference, I think it would be great to include continuous integration facilities with our unit tests. Travis CI has a Building a Go Project article that could be interesting to use while working on this issue.


Make New Version

Hi
Am i allowed to recreate this game with a different twist using a different game engine and publish?

Yes you're allowed to do this, as per the license attached to the source code.
Please let us know when it's released, we'd love to see (and play) it!


remove metrics tracker in app

this change is related to the metrics tracker which is now retired see https://www.npmjs.com/package/metrics-tracker-client

removed metrics tracker (require("metrics-tracker-client").track()) from server.js and app.js per PR 7.


Warnings from ruby 2.7

Steps to reproduce

Run nanoc on a site using ruby 2.7, released December 2019

Expected behavior
No change from Ruby 2.6.
Actual behavior
Deprecation warnings from Ruby 2.7, most about other packages but a couple about nanoc itself.
This is far from a serious problem (I don't even plan to migrate to 2.7 soon) but I thought putting the issues in record would be useful.
Details
/Volumes/Cased/git/iay/iay/site/vendor/ruby/2.7.0/gems/cri-2.15.9/lib/cri/command_dsl.rb:243: warning: Using the last argument as keyword parameters is deprecated; maybe ** should be added to the call
/Volumes/Cased/git/iay/iay/site/vendor/ruby/2.7.0/gems/cri-2.15.9/lib/cri/command_dsl.rb:155: warning: The called method `option' is defined here
/Volumes/Cased/git/iay/iay/site/vendor/ruby/2.7.0/gems/cri-2.15.9/lib/cri/command_dsl.rb:220: warning: Using the last argument as keyword parameters is deprecated; maybe ** should be added to the call
/Volumes/Cased/git/iay/iay/site/vendor/ruby/2.7.0/gems/cri-2.15.9/lib/cri/command_dsl.rb:155: warning: The called method `option' is defined here
/Volumes/Cased/git/iay/iay/site/vendor/ruby/2.7.0/gems/json-2.1.0/lib/json/common.rb:156: warning: Using the last argument as keyword parameters is deprecated
/Volumes/Cased/git/iay/iay/site/vendor/ruby/2.7.0/gems/json-2.1.0/lib/json/common.rb:156: warning: Using the last argument as keyword parameters is deprecated
Loading site… /Volumes/Cased/git/iay/iay/site/vendor/ruby/2.7.0/gems/json-2.1.0/lib/json/common.rb:156: warning: Using the last argument as keyword parameters is deprecated
/Volumes/Cased/git/iay/iay/site/vendor/ruby/2.7.0/gems/json-2.1.0/lib/json/common.rb:156: warning: Using the last argument as keyword parameters is deprecated
done
/Volumes/Cased/git/iay/iay/site/vendor/ruby/2.7.0/gems/nanoc-core-4.11.14/lib/nanoc/core/compiler_loader.rb:35: warning: Using the last argument as keyword parameters is deprecated; maybe ** should be added to the call
/Volumes/Cased/git/iay/iay/site/vendor/ruby/2.7.0/gems/nanoc-core-4.11.14/lib/nanoc/core/compiler.rb:8: warning: The called method `initialize' is defined here

The ones for Cri are fixed, but the ones for Nanoc are still pending — they are fixed on master, but not yet released.

A release is coming up soon.

Was this supposed to be fixed in 4.11.15? I am (I think) still seeing some of these:
/builds/iay/site/vendor/ruby/2.7.0/gems/nanoc-core-4.11.15/lib/nanoc/core/compiler_loader.rb:35: warning: Using the last argument as keyword parameters is deprecated; maybe ** should be added to the call
/builds/iay/site/vendor/ruby/2.7.0/gems/nanoc-core-4.11.15/lib/nanoc/core/compiler.rb:8: warning: The called method `initialize' is defined here

@iay There were indeed still some issues — a fix is in #1498.


Proposing packages upgrade

From [CHANGELOG.md]:
Unreleased - 1.3.0
Minor Changes

b0ce46d: Add support for wagmi 0.10.x

Patch Changes

Updated dependencies [b0ce46d]

<EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS>

This PR will allow the latest WAGMI and Web3modal apps to utilize SafeApps. Those changes were tested locally and in production on: https://defioracles.org/

I have read the CLA Document and I hereby sign the CLA

Hey sir, I've iterated on your PR here: https://github.com/safe-global/safe-apps-sdk/pull/441. I'm sorry but I have to close this because we need to get the fix released


Add scrollEnabledDivisor prop

Motivation
The current implementation when scrollEnabled is set to true creates a width of each tab to be 40% the width of the screen. Adding this additional prop scrollEnabledDivisor allows the user to define the divisor so that they can have more control over the width of each tab.

Hey, I just released a new alpha 2.0.0-alpha.0 of the library. It's rewritten using react-native-gesture-handler and react-native-reanimated addresses a many platform specific bugs and performance problems. It's gone through a major refactor and there will be conflicts with your PR.
Please try the new version and see if it addresses your issue. If not, please open a new PR with the change.


T-Rex does not emit vendor extensions for Logic Flows in Power Apps

There are new vendor extensions designed to support the designer in Logic Flows for Power Apps. These are not yet emitted by T-Rex.
More information can be found: https://azure.microsoft.com/en-us/documentation/articles/powerapps-develop-api/

Implemented new visibility type, and cleaned things up to get ready for Power Apps updates as part of f382055.

This is fully closed out as of commit a63227e. Examples of usage can be seen here until I am able to put together more formal documentation.


[SYSTEMML-573] Frame write

Its showing changes from earlier commit though those are push but not reflected in git repo yet.

thanks @asurve; this is a good start - couple of comments though:

Binary Block Writer: The method writePartitionedBinaryBlockFrameToHDFS is not required and can be removed. Also please put a comment in there that this write uses fixed size blocks with block-encoded keys. In the future, we might change that, especially the keys (e.g., starting offset).
CSV File Merge: the methods  mergeCSVPartFiles and addHeaderToCSV work on bytes. Hence there is no need to replicate them here for frames.
Null Checks: Keep in mind that frames might contain sparse cells (w/ null objects). You need to handle this when trying to convert them to strings. Also, for textcell, sparse cells should not be materialized into the output (it's a sparse format).
String Conversions: The cast to string for CSV and textcell would crash for any schema other than ValueType.STRING. Please, use UtilFunctions.objectToString() here.

I'm sorry for the wrong direction, but instead of UtilFunctions.objectToString, we should just call toString for objects !=null. Thanks.

LGTM


Text: resetted

(bug) While manipulating blocks, the input text is resetted from time to time.

Thank's for reporting this issue. Would you elaborate on how the text views reset? Is it possible to reproduce it?


Change prop type checking to use instanceof instead of typeof

What problem does this feature solve?
Currently prop type checking fails when passing in an object that extends the expected type.
This would allow anything inheriting from the expected type to pass the check.
What does the proposed API look like?
https://github.com/vuejs/vue/blob/8d66691ee264969447390822971b8caa029cac3e/src/core/util/props.js#L148
If this line were
valid = value instanceof expectedType.toLowerCase()

Then child classes would also pass. In my mind if a component is checking for String and I pass in an object that extends string this should pass the typecheck.
This was born out of an issue that one of my users has passing an String castable object which extends string as a prop into a Vue component.
If you're interested you can check that out here:
https://github.com/tightenco/ziggy/pull/64

Actually this could already be done with custom prop validator, in your case:
Vue.component('custom', {
  props: {
    foo: {
      default: '',
      validator: value => value instanceof String
    }
  }
})

@jkzing this would absolutely work for the use-case where I am creating a component. The use case I'm interested in, however is when using components from vendor code. If a vendor component checks for String type there is nothing I can do but manually call toString on my object, which is a little janky.
There are only two good reasons for a vendor package to check for a type:

They want to use methods on that type's prototype, like String().replace() (all parent prototype methods are available on wrapper objects so this shouldn't be an issue)
They want to use the argument as that type (printing a string, iterating an array, etc.)

Neither of these use-cases is broken by allowing users to pass in wrapper objects, so there is no inherent value to strictly checking for type literals. Checking that something is strictly a String gains you nothing over checking that something has all the properties of a String.
I think this is akin to failing a test for Animal when a user provides Dog which extends Animal

I'd rather argue mixing primitive values and their wrapper objects is code smell in JavaScript.
e.g. https://eslint.org/docs/rules/no-new-wrappers
Supporting this checking in API means Vue, implicitly or indirectly, encourages code smell.

Could you give an example of a situation where your example would apply? I'm having a hard time understanding. There is no situation where you could pass two wrapper objects into a single prop, so I don't see the issue.
As far as this being a "code smell", I believe that code smell is an indication that something MIGHT be wrong, not an guarantee that something IS wrong.
I don't buy the argument that by allowing people to use a language feature like wrappers, Vue is somehow endorsing or encouraging it, and I also don't buy that wrappers are a moral evil on which a framework like Vue must take a stand.
This is a language feature and there are good and bad reasons to use it. If you decide to design a framework to prevent people from using wrappers badly, you also prevent people from using them well. I think programmers can be trusted.

Consider:
<my-comp :prop="Route(route)"/>

If route is updated to same value, say this.route = oldRoute. The above code will trigger my-comp re-render because Route is an object. But it should not because route value is the same.
Also, if String allows wrapper object, how users can check if prop is primitive? Using validator. But you can use validator in current api, too.

I understand what you're saying and that would not be good. To me it seems like:
On the one hand –
By switching to instanceOf you run the risk of a developer writing bad code which triggers unnecessary renders. It seems to me that passing in an object which needlessly resets its value unnecessarily would ALWAYS cause a re-render, not just on a String typed prop, so the onus is on the developer of the Route object (in this case, me) to deal with those issues.
On the other hand –
You prevent developers from using wrappers in their code, even if that is the best solution. This doesn't just apply to my code, but also to large commonly used libraries like Lodash, which uses wrappers for its commonly used _.chain() method.
It is obvious that in this case I (partly selfishly, but also out of principle) prefer the scenario that gives developers the freedom to use wrappers (and more generally: whatever language feature fits their problem best) but also saddles them with the responsibility of dealing with the fallout in the edge-cases.
"With great power comes great responsibility" and all that 😄
Like I said above, I think that developers can handle the responsibility, and I think that adding this feature is the right move. But I also understand that this is open source and my opinion is not the only one that matters. I leave it up to the community to decide.
Thanks for a fun discussion 😄 👍