Revoke 3.3.1, it's a mistake

Never modify existing errors! You don't know which props are already set, JavaScript error can be subclassed fyi.
The API is super inconsistent now. And you added a circular dependency.
Use semantic versioning please, this was clearly a big breaking change. Don't lie and increment X from X.Y.Z. Thank you.

Anyway, thank you for your work. The open source is hard.

Use https://github.com/JsCommunity/make-error for custom redux-promise-middleware error with action and reason props.

Never ever mutate existing object. http://henrikeichenhardt.blogspot.cz/2013/06/why-shared-mutable-state-is-root-of-all.html

An inspiration https://github.com/este/este/blob/master/src/common/lib/validation/ValidationError.js

I hope this is constructive enough. Feel free to ask.

Never modify existing errors!

Let's take a step back. In issue #70, we changed the middleware to reject with an instance of Error. This request is reasonable, but also problematic because constructing a new error renders Error.prototype.stack — as well as the other properties from the original error — useless. Thus, the goal of version 3.3.1 was to preserve the original error object while adding the properties from the middleware. See issue #93.
This is the solution implemented version 3.3.1, as I am sure you are aware.
const error = reason instanceof Error ? reason : new Error();
error.reason = reason;
error.action = rejectedAction;
throw error;

Yes, it is not ideal to mutate objects; I am aware. Personally, in order to resolve this issue, I’d like to revert the changes made as a result of #70. Another option would be to subclass the error, e.g., class FooError extends Error, but you would still end up mutating the original object to account for issue #93. What would you suggest?

Use semantic versioning please, this was clearly a big breaking change. Don't lie and increment X from X.Y.Z. Thank you.

Unrelated, but important: you should reconsider how you engage with open source contributors.
First, issue #99 was entirely uncalled for and not constructive. I get it: it is frustrating when code does not work as expected and it turns out to be someone's library. I'm sorry you had trouble with the versioning; frankly, I was not expecting this to break anything. However, it makes me bitter to be engaged with in this manner. I'm not paid to do open source work and I am here to help you. You should remember to be constructive and kind.
Second, your engagement on issues suggests arrogance. Your description/comments on issues are short/curt and do not include context.

"The API is super inconsistent now": Why is it inconsistent?
"And you added a circular dependency": What is the circular dependency?
You have mentioned several times this was a breaking change for you, but never mentioned what the breaking change is! What did you experience? Can you provide context? The issue template explicitly asks for “Expected Behavior” and “Actual Behavior.” This is important information.
"JavaScript error can be subclassed": Do you think I don't know this?
 Really?

Third, I might suggest making a pull request if you have a solution in mind. I would be happy to accept your contributions, especially as more people are using the project. I do not have a lot of time to resolve issues and review code. I work full-time and have other commitments.
Fourth, remember issues are considered contributions. How are your issues contributing to the project? You open issues, but don't propose any applicable solutions. In issue #70, I asked for an example to demonstrate the change you requested. You responded with “That's the only code I can provide you right now.” and a link. Today, you opened several issues, but I still don't know why version 3.3.1 is a mistake.

I am marking as invalid until I have more context around the expected and actual behavior.

@steida you can still use v2 of this middleware. It doesn't modify errors - they just pass through to both the consumer and the dispatch.

Sorry for being rude and thank you for the thoughtful answer.
The problem with recent change is, that it makes a circular dependency. Look:
const error = reason instanceof Error ? reason : new Error();
error.reason = reason;

Now reason has a property reason, which has a property reason, which... brokes JSON.stringify, which is often used in redux-logger or redux storage. This is why mutation can be so tricky.
What I suggest is to always create a new Error. Maybe stack can be preserved. If not, then we have to change the current API to be more idiomatic promise-like. I mean _SUCCESS and _ERROR getting result or rejection object without any wrapper. Then to figure out how to pass original action, not sure how yet.
I will try something.

I feel it's the responsibility of the consumer to make sure their payload is a real error instance in the rejected case and we shouldn't be mutating or creating anything. Smaller API surface's always seem to work out better.
I don't really get the need for this object with a reason property... surely the reason is the payload already. If anyone needs to know the full "rejected action" then they can just use some logging middleware...

I think the reason for the reason (haha) is having an action so a handler can do something with it for an optimistic update I guess. Not needed in Este, still some people can leverage it. It allows reducer to know what caused the change. But it also gibberish an API with an additional level of the abstraction. I think it can be removed entirely in version 4.

Hmm, it seems we can use this to pass preserve stack.
But I would rather remove the whole wrapping. It's confusing I suppose.
defineProperty(error, 'stack', {
  configurable: true,
  get: function getStack() {
    var stack = reason.stack;
    // Replace property with value for faster future accesses.
    defineProperty(this, 'stack', {
      value: stack
    });
    return stack;
  },
  set: function setStack (stack) {
    defineProperty(error, 'stack', {
      configurable: true,
      value: stack,
      writable: true
    })
  }
})

Anyone could wrap their catched payload before it dispatches in the action creator if they needed to optimistic update their reject flow... if that's even a thing? Surely the reducer just needs to rollback and maybe store some 'error' state from the rejection payload. Anyway it's still a pretty obscure use case to have baked into a middleware - especially as anyone can just create it themselves with a bit of composition.

MVP
const promiseMiddleware = config => ({ dispatch }) => next => action => {
  const {
    suffixes = ['PENDING', 'FULFILLED', 'REJECTED']
  } = config || {};
  const [PENDING, FULFILLED, REJECTED] = suffixes;
  const { type, payload: promise } = action;
  const isPromise = promise && typeof promise.then === 'function';
  if (!isPromise) {
    return next(action);
  }
  next({ type: `${type}_${PENDING}`, payload: action });
  const handleFulfilled = value => {
    dispatch({ type: `${type}_${FULFILLED}`, payload: value });
    return result;
  };
  const handleRejected = error => {
    dispatch({ type: `${type}_${REJECTED}`, payload: error });
    throw error;
  };
  return promise.then(handleFulfilled, handleRejected);
}

I think this is what I need in the Este
// Like redux-promise-middleware but without the noise.
const promiseMiddleware = ({ dispatch }) => next => action => {
  const { type, payload: promise } = action;
  const isPromise = promise && typeof promise.then === 'function';
  if (!isPromise) return next(action);
  const createAction = (suffix, payload) => ({
    type: `${type}_${suffix}`, meta: { action }, payload
  });
  next(createAction('START'));
  const handleFulfilled = value => {
    dispatch(createAction('SUCCESS', value));
    return value;
  };
  const handleRejected = error => {
    dispatch(createAction('ERROR', error));
    throw error;
  };
  return promise.then(handleFulfilled, handleRejected);
};

There is a related PR open to remove the circular reference for this:  #101. I explained in a comment there what my thoughts are for this. TL;DR: don't construct a new error and release v4.
As far as simplifying the rest of the code, I don't think it is productive. Yeah, it is easier to explain with a MVP, but it is just that: an MVP. As this project has grown from the first release to now, we have received a number of feature requests. If there are ways to make the code cleaner while maintaining the present API, I am open to this; however, I don't want to depreciate any of the API.

What exactly is omitted in my suggested implementation?

What exactly is omitted in my suggested implementation?

There is no config for custom type suffixes
There is no support for optimistic updates via the pending action
Can only dispatch promises via payload and not payload.promise (current middleware supports both)

There is no config for custom type suffixes
I'm pretty sure it's unnecessary abstraction, but you probably overlooked, that first example https://github.com/pburtchaell/redux-promise-middleware/issues/100#issuecomment-231883107 supports it.

const {
  suffixes = ['PENDING', 'FULFILLED', 'REJECTED']
} = config || {};
const [PENDING, FULFILLED, REJECTED] = suffixes;

There is no support for optimistic updates via the pending action
There is. Instead of misusing payload which really belongs to promise value only, the whole action is always passed into the meta, where it belongs. Again you probably overlooked it.

const createAction = (suffix, payload) => ({
  type: `${type}_${suffix}`, meta: { action }, payload
});

Can only dispatch via payload and not payload.promise (v3 supports both)
And what? Version 4 can simply API and version 4 means breaking change so there is no reason to support obsolete API.

Remember, the API developer should always provide only the one way to do stuff.

@tomatau WDYT?

I like v2 that I maintain, it's essentially what you're asking for but also lets you modify the meta on each action type which is an important use case for me when working with sockets.

So revisiting this after a busy month, @steida.
Your response to "There is no config for custom type suffixes"

I'm pretty sure it's unnecessary abstraction.

It is a reasonable objection. This was a requested feature in the early days of the middleware, but I have not used it myself. I'd consider removing it for a v4 release.
Your response to "There is no support for optimistic updates via the pending action":

There is. Instead of misusing payload which really belongs to promise value only, the whole action is always passed into the meta, where it belongs. Again you probably overlooked it.

Yes, I noticed your example dispatches the optimistic update in the meta, however, I disagree with this design. The payload of the pending action should not be a promise value. It can't be, since the promise is not settled yet. The pending action payload should be optimistic update.
As we all know, Redux actions describe change(s) to state. The dispatched pending action describes an change to state which is not fulfilled or rejected; thus, it makes sense for the optimistic update will remain in the payload of such an action. It is a pending change to state.
Your response to: "Can only dispatch via payload and not payload.promise (v3 supports both)"

And what? Version 4 can simplify API and version 4 means breaking change so there is no reason to support obsolete API. Remember, the API developer should always provide only the one way to do stuff. http://semver.org/

payload.promise is needed to support optimistic updates
You could put the value of the optimistic update in the meta — however, I would prefer to keep the middleware agnostic and allow both.
It is too prescriptive to require payloadto  always be a promise.

I don't find this issue is going in any particular direction, so I am closing. Further changes can be discussed in #103 and #101 is open to track the circular reference bug.


Conform MacAddress to Sendable

Required to avoid compiler errors:
warning: static property 'appStoreCompatible' is not concurrency-safe because it is not either conforming to 'Sendable' or isolated to a global actor; this is an error in Swift 6
static let appStoreCompatible = (
^

https://github.com/ivanmoskalev/macos-mac-address/releases/tag/1.2.0 release live


Add Ruby language support using rbspy

Description
Adds a profiler for ruby runtime using the rbspy project.
Currently, a static executable of rbspy is built from granulate's fork using the same  x86_64-unknown-linux-musl target as pyspy. Our fork has added the ability to create ON CPU samples.
Related Issue

Motivation and Context

How Has This Been Tested?

unit testing
Created a blank ruby on rails app and run it via docker.  generate some load on the server and run gprofiler.
Also ensured our rbspy record --on-cpu work as intended by making sure we don't see any ruby when the server is running with no load.

Screenshots

Checklist:

[X] I have read the CONTRIBUTING document.
[X] I have updated the relevant documentation.
[X] I have added tests for new logic.

https://github.com/Granulate/gprofiler/pull/107 for the CI error (lint)


FlowItemTappedCommand not firing

This is my XAML code
<controls:FlowListView x:Name="Board"
                  HasUnevenRows="true"
                  FlowColumnCount="3"
                  FlowItemTappedCommand="ExecuteActionCommand"
                  FlowColumnMinWidth="110">
...
 </controls:FlowListView>

This is some code of my view model
   public CardsExhibitViewModel()
    {
        ExecuteActionCommand = new Command<Card>(ExecuteAction);
    }

    public ICommand ExecuteActionCommand { get; private set; }

    private void ExecuteAction(Card card)
    {
        card.Action.ExecuteAction();
    }

What am I doing wrong ?

Did you find a solution to this problem?

Yes friend, it was a silly mistake. If you notice this line "FlowItemTappedCommand="ExecuteActionCommand" there's no binding expression, so I just added the "{Binding ExecuteActionCommand}" part and it worked out fine

If this was not your problem I'll just leave you with my complete XAML of this part. Hope it helps
`
<controls:FlowListView x:Name="Board" HasUnevenRows="True"
BackgroundColor="Black"
FlowColumnCount="2"
FlowItemTappedCommand="{Binding ExecuteActionCommand}"
FlowColumnMinWidth="110"
IsPullToRefreshEnabled="True"
IsRefreshing="{Binding IsRefreshing}"
RefreshCommand="{Binding RefreshViewCommand}"
FlowItemsSource="{Binding Cards}">
            <controls:FlowListView.FlowColumnTemplate>
                <DataTemplate>
                    <Grid Padding="5">
                        <Grid.RowDefinitions>
                            <RowDefinition Height="*" />
                        </Grid.RowDefinitions>
                        <Grid.ColumnDefinitions>
                            <ColumnDefinition Width="*" />
                        </Grid.ColumnDefinitions>
                        <ffimageloading:CachedImage HeightRequest="150" Aspect="AspectFill"
                                                    DownsampleHeight="150" DownsampleUseDipUnits="false"
                                                    Source="{Binding Representation}" />
                    </Grid>
                </DataTemplate>
            </controls:FlowListView.FlowColumnTemplate>
        </controls:FlowListView>
    </ScrollView>`


split up autoload/netrw.vim

Is your feature request about something that is currently impossible or hard to do? Please describe the problem.
It is hard to load autoload/netrw.vim on a slow single-core computer and maneuver it afterwards due to its size.
Describe the solution you'd like
split it up sensibly, maybe starting by moving some of the level one fold marker sections into separate files where the Shared Browsing Support section needs to be split up according to the other sections' dependencies.
Describe alternatives you've considered
make netrw optional, replace it by some other Vim file manager plug-in using more intuitive Vim UI similar to oil.vim / https://github.com/qpkorr/vim-renamer or completely rewrite it in more modern syntax.
The last option seems Herculean (and maybe this requested task already is);
the former two would throw away much functionality people have grown accustomed to.
Additional context
The pull request https://github.com/vim/vim/pull/16248 reformats its indents and observed thatin  legacy viml the function names bound to the file name was only a convention, ... so moving some netrw#... functions in another file it should be fine.

I don't like this. How will splitting things up into additional files speed up loading files on a slow single-core pc? In contrast, splitting up into several files may hurt loading performance, especially if this is on a shared drive and a potential anti-virus is called several times. I have seen exactly this issue with vim-airline.

The idea is that one usually looks at an exerpt. I just found that I am almost unwilling to open this file due to its delay on loading.


Using exit in a module's function prematurely exits the PowerShell session.

Prerequisites

[X] Write a descriptive title.
[X] Make sure you are able to repro it on the latest released version
[X] Search the existing issues.
[X] Refer to the FAQ.
[X] Refer to Differences between Windows PowerShell 5.1 and PowerShell.

Steps to reproduce
Calling PowerShell from another shell, it is necessary to report exit codes to the other shell (which is a requirement for, e.g., git hooks).
Doing this from an advanced function declared in a PowerShell module, prematurely exits the function – and even the current PowerShell session – without returning the exit code.
See this Question at StackOverflow for an MRE.
Expected behavior
PowerShell should return the exit code.

Actual behavior
No exit code is returned. The PowerShell session ends prematurely.

Error details
No response
Environment data
Name                           Value
----                           -----
PSVersion                      7.4.1
PSEdition                      Core
GitCommitId                    7.4.1
OS                             Microsoft Windows 10.0.19045
Platform                       Win32NT
PSCompatibleVersions           {1.0, 2.0, 3.0, 4.0…}
PSRemotingProtocolVersion      2.3
SerializationVersion           <IP_ADDRESS>
WSManStackVersion              3.0

Visuals
No response

System.Environment.Exit works on both Linux and Windows
$ cat exit.ps1
#!/usr/bin/env pwsh

[System.Environment]::Exit(42)
$ ./exit.ps1
$ echo $?
42

or
D:\tmp>type exit.ps1
#!/usr/bin/env pwsh

[System.Environment]::Exit(42)

D:\tmp>pwsh exit.ps1

D:\tmp>echo %ERRORLEVEL%
42

or
D:\tmp>pwsh
PowerShell 7.4.1
PS D:\tmp> pwsh exit.ps1
PS D:\tmp> $LastExitCode
42

You might want to read the later part of this
https://jhoneill.github.io/powershell/2019/08/21/ExitThrowReturnEtc.html
Exit is no better understood now than when I wrote that, but depending on how launch the script you can send an exit code back to PowerShell which then says "OK I've run all the commands I was told to run, I'm exiting normally"

Thanks, @rhubarb-geek-nz and @jhoneill, for clarifying! 👍
@jhoneill, I found your article very enlightening on what happens when using exit.
So, to have my script run according to PowerShell paradigm and using it from within Bash, I decided to return $true and $false, resp. in order to avoid the exception output. In Bash, I'll convert that return value to the PowerShell session's exit code then:
pwsh -Command "Import-Module 'C:\Temp\Test-Exit.psm1; exit (Text-Exit '') ? 0 : 1'"


setContent of an textarea with tinyMCE #113

There is a modification in master now where the view value is updated appropriately, and when the model value changes, a formatter converts it to the appropriate view value.


[video_player] [iOS] Audio is overlapping intermittently for multiple videos

Description
The app has multiple videos in a page, however there is only one VideoPlayerController to control the videos.
Whenever one video is played and moved to next, the audio is overlapping.
This happens only on iOS. In android, it works fine.
This issue occurs intermittently.
Steps to Reproduce
VideoPlayerController _controller;

Play a video using _controller.play()
Change video using _controller = VideoPlayerController.network(url);
And play the new video using _controller.play()

Expected results:
Stop the former video and play the current one
Actual results:
The current one is playing and the former one audio is overlapping.
Video is playing only for current one but the audio is playing for the former one.

Logs
[✓] Flutter (Channel stable, 1.22.2, on Mac OS X 10.15.5 19F101, locale en-US)
    • Flutter version 1.22.2 at /Users/niteshpundra/Documents/flutter
    • Framework revision 84f3d28555 (6 weeks ago), 2020-10-15 16:26:19 -0700
    • Engine revision b8752bbfff
    • Dart version 2.10.2
[✓] Android toolchain - develop for Android devices (Android SDK version 29.0.2)
• Android SDK at /Users/niteshpundra/Library/Android/sdk
• Platform android-30, build-tools 29.0.2
• Java binary at: /Applications/Android
Studio.app/Contents/jre/jdk/Contents/Home/bin/java
• Java version OpenJDK Runtime Environment (build
1.8.0_242-release-1644-b3-6222593)
• All Android licenses accepted.
[✓] Xcode - develop for iOS and macOS (Xcode 12.0.1)
• Xcode at /Applications/Xcode.app/Contents/Developer
• Xcode 12.0.1, Build version 12A7300
• CocoaPods version 1.10.0
[✓] Android Studio (version 4.0)
• Android Studio at /Applications/Android Studio.app/Contents
• Flutter plugin version 46.0.2
• Dart plugin version 193.7361
• Java version OpenJDK Runtime Environment (build
1.8.0_242-release-1644-b3-6222593)
[!] IntelliJ IDEA Community Edition (version 2018.2.3)
• IntelliJ at /Applications/IntelliJ IDEA CE.app
✗ Flutter plugin not installed; this adds Flutter specific functionality.
✗ Dart plugin not installed; this adds Dart specific functionality.
• For information about installing plugins, see
https://flutter.dev/intellij-setup/#installing-the-plugins
[✓] Connected device (1 available)
• SM G935V (mobile) • a7821b10 • android-arm64 • Android 6.0.1 (API 23)
! Doctor found issues in 1 category.

@reverie-ss
Please provide a complete minimal reproducible code sample. Also I see that you are on stable 1.22.2, while the current stable is 1.22.4. You may try to upgrade to latest and check again if issue persists.
Thanks.

I have the same issue.
Description
I am using gridview populated with a combination of images and videos (similar to what Instagram looks like when you selecting media to post)
Issue
click onto video, then click onto an image the audio from the video is still playing, the audio doesn't stop until the end of the video, i can click onto every image but the video doesn't dispose
Code Snippet
This determines what type of file is clicked
       file = await mediaList[index].file;         assetType = mediaList[index].type.toString();         setState(() {           if (assetType == 'AssetType.video') {             _videoController = VideoPlayerController.file(file);             _videoController.setLooping(true);             _videoController.setVolume(100);             _videoController.play();             _initializeVideoPlayerFuture = _videoController.initialize();           }         });
This displays the video
    FutureBuilder(      future: _initializeVideoPlayerFuture,      builder: (context, snapshot) {      if (snapshot.connectionState ==ConnectionState.done) {      return GestureDetector(      onTap: () {      setState(() {      if (_videoController .value.isPlaying) {                                                       _videoController .pause();      } else {       _videoController.play();      }});},
 void dispose() {  _videoController.dispose(); }
logs
Doctor summary (to see all details, run flutter doctor -v):
[√] Flutter (Channel stable, 1.22.4, on Microsoft Windows [Version 10.0.18362.356], locale en-ZA)
[√] Android toolchain - develop for Android devices (Android SDK version 29.0.2)
[!] Android Studio (version 3.5)
X Flutter plugin not installed; this adds Flutter specific functionality.
X Dart plugin not installed; this adds Dart specific functionality.
[√] VS Code (version 1.51.1)
[√] Connected device (1 available)
I am not sure if I've missed anything

Without additional information, we are unfortunately not sure how to resolve this issue.
We are therefore reluctantly going to close this bug for now.
Please don't hesitate to comment on the bug if you have any more information for us; we will reopen it right away!
Thanks for your contribution.
Could everyone who still has this problem please file a new issue with the exact description of what happens, logs, and the output of flutter doctor -v.
All system setups can be slightly different, so it's always better to open new issues and reference related issues.


Vsphere Windows image updates

Sysprep with unattend file
Adds resource pool option
Use guestInfoService instead of OVF service
moves cloudbase conf into templates
fixes issue with parsing kubelet flags

LGTM


Edited index.qmd - removed capital N from the middle of Keynote, adde…

…d to bios for keynote speakers from info they sent.

Added improvements to gt tables for program


[BUG] Savify crashes when attempting to download a track whose title, author or album ends with an ellipsis.

Describe the bug
Savify is unable to process Spotify tracks that end with an ellipsis (...) in either the track's name, album or artist, when grouping by track and album name. This seems to originate from the code to save the downloaded file. This would make sense, as Windows doesn't allow for folders to end with periods; "Folder names cannot end with a period in Windows, though the name can end with a period followed by a whitespace character such as a non-breaking space."
The following error is given:
Traceback (most recent call last):
  File "c:\users\admin\downloads\youtube dl\venv\lib\site-packages\savify\savify.py", line 250, in _download
    ffmpeg.run()
  File "c:\users\admin\downloads\youtube dl\venv\lib\site-packages\ffmpy.py", line 106, in run
    raise FFRuntimeError(self.cmd, self.process.returncode, out[0], out[1])
ffmpy.FFRuntimeError: `ffmpeg -i C:\Users\Admin\AppData\Roaming\Savify\temp/5w5vw9cokQ9s8dHQmQqLX4.mp3 -i C:\Users\Admin\AppData\Roaming\Savify\temp\29eea82c-708f-11eb-9af5-309c2344e680.jpg -loglevel quiet -hide_banner -y -map 0:0 -map 1:0 -c copy -id3v2_version 3 -metadata:s:v "title=Album cover" -metadata:s:v "comment=Cover (front)" "C:\Users\Admin\AppData\Roaming\Savify\downloads\Lyrics Born\Later That Day...\Lyrics Born - Bad Dreams.mp3"` exited with status 1

STDOUT:

STDERR:

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "c:\users\admin\appdata\local\programs\python\python38\lib\shutil.py", line 788, in move
    os.rename(src, real_dst)
FileNotFoundError: [WinError 3] The system cannot find the path specified: 'C:\\Users\\Admin\\AppData\\Roaming\\Savify\\temp/5w5vw9cokQ9s8dHQmQqLX4.mp3' -> 'C:\\Users\\Admin\\AppData\\Roaming\\Savify\\downloads\\Lyrics Born\\Later That Day...\\Lyrics Born - Bad Dreams.mp3'

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "c:\users\admin\appdata\local\programs\python\python38\lib\runpy.py", line 194, in _run_module_as_main
    return _run_code(code, main_globals, None,
  File "c:\users\admin\appdata\local\programs\python\python38\lib\runpy.py", line 87, in _run_code
    exec(code, run_globals)
  File "C:\Users\Admin\Downloads\YouTube DL\venv\Scripts\savify.exe\__main__.py", line 7, in <module>
  File "c:\users\admin\downloads\youtube dl\venv\lib\site-packages\click\core.py", line 829, in __call__
    return self.main(*args, **kwargs)
  File "c:\users\admin\downloads\youtube dl\venv\lib\site-packages\click\core.py", line 782, in main
    rv = self.invoke(ctx)
  File "c:\users\admin\downloads\youtube dl\venv\lib\site-packages\click\core.py", line 1066, in invoke
    return ctx.invoke(self.callback, **ctx.params)
  File "c:\users\admin\downloads\youtube dl\venv\lib\site-packages\click\core.py", line 610, in invoke
    return callback(*args, **kwargs)
  File "c:\users\admin\downloads\youtube dl\venv\lib\site-packages\savify\cli.py", line 110, in main
    s.download(query, query_type=query_type)
  File "c:\users\admin\downloads\youtube dl\venv\lib\site-packages\savify\savify.py", line 109, in download
    jobs = pool.map(self._download, queue)
  File "c:\users\admin\appdata\local\programs\python\python38\lib\multiprocessing\pool.py", line 364, in map
    return self._map_async(func, iterable, mapstar, chunksize).get()
  File "c:\users\admin\appdata\local\programs\python\python38\lib\multiprocessing\pool.py", line 771, in get
    raise self._value
  File "c:\users\admin\appdata\local\programs\python\python38\lib\multiprocessing\pool.py", line 125, in worker
    result = (True, func(*args, **kwds))
  File "c:\users\admin\appdata\local\programs\python\python38\lib\multiprocessing\pool.py", line 48, in mapstar
    return list(map(*args))
  File "c:\users\admin\downloads\youtube dl\venv\lib\site-packages\savify\savify.py", line 255, in _download
    move(output_temp, output)
  File "c:\users\admin\appdata\local\programs\python\python38\lib\shutil.py", line 802, in move
    copy_function(src, real_dst)
  File "c:\users\admin\appdata\local\programs\python\python38\lib\shutil.py", line 432, in copy2
    copyfile(src, dst, follow_symlinks=follow_symlinks)
  File "c:\users\admin\appdata\local\programs\python\python38\lib\shutil.py", line 261, in copyfile
    with open(src, 'rb') as fsrc, open(dst, 'wb') as fdst:
FileNotFoundError: [Errno 2] No such file or directory: 'C:\\Users\\Admin\\AppData\\Roaming\\Savify\\downloads\\Lyrics Born\\Later That Day...\\Lyrics Born - Bad Dreams.mp3'

To Reproduce
Enter the following command:
savify [redacted; playlist share link] -g "%artist%/%album%"
Expected behaviour
Savify works as intended, downloading missing tracks, grouping them into folders according to the track's title and album. However, when a track's title or album ends with an ellipsis, Savify crashes.
Desktop (please complete the following information):

OS Name: Microsoft Windows 10 Pro
Version: 10.0.19041 Build 19041

Additional context
As is shown, one such track that Savify cannot process is Bad Dreams by Lyrics Born, on their album Later That Day..., found here.
A second track that also fails is One Step Beyond... by Madness, on their album One Step Beyond. Whilst the Spotify track doesn't contain an ellipsis, it would appear that the YouTube equivalent does.
I imagine the solution is to either re-encode any suffix full-stops/periods with an alternative character or instead simply remove them. Folder names could also be appended with whitespace, although I feel this isn't a great long-term solution.

Thanks for your work on this :)


Find a vanilla BPMN diagram to use as a demo foundation for our stories

About bpmn diagram examples, we could use resources from the from BPMN Model Interchange Working Group (BPMN MIWG)

https://github.com/bpmn-miwg/bpmn-miwg-test-suite
https://github.com/bpmn-miwg/bpmn-miwg-demos


Add text manipulation capabilities

Allows editing of text as user types.
Enables features such as:

[x] Close tag when typing /
[x] Switch tag to self-closing when typing / in opening tag, i.e. <Grid></Grid> -> <Grid/>
[x] Edit end tag when typing into start tag

@kekekeks this is ready. Published the PR.

Was text change/manipulation API designed from scratch or does it mirror some API from Visual Studio?

It mirrors visual studio API

VScode API is a bit different but we do not have VScode extension?
This PR assumes that we have both text before and after change. If another editor does not provide this it may be impossible to do this kind of manipulations, as extension need to check if start and end tags were matching before the change.
VS provides us with full text after modification, and list of modifications, each containing deleted text, and inserted text.


[Bug Report] Ghost Button presses

Bug Report
Describe the bug
This could potentially be a problem with the hardware or perhaps the firmware button debounce method.
On some occasions a b(n).handler_falling interrupt can be triggered without a physical press of a button. However, it is quite difficult to reproduce and seems to happen mostly randomly. The bug was identified after logging was added to the CVecorder script.
To Reproduce
In some cases this can be produced by starting the module with nothing connected, then connecting CV to ain followed by a clock into din. However, this problem does not happen all the time and appears to happen rather randomly.
Expected behavior
A b(n).handler_falling interrupt should not be triggered unless a button is pressed and then released.
Images

Additional context
This bug has been identified so far only when using the CVecorder script - as a button press can trigger the deletion of recorded CV, so it is therefore obvious when it happens. However, I believe this issue could manifest in all scripts.

Confirmed to appear in probapoly and consequencer too.
Placing an upper time limit on a long button press detection dramatically reduces the chance of a phantom button press like the snippet below (3000 is used as an upper limit in this example).
if ticks_diff(ticks_ms(), b1.last_pressed()) >  500 and ticks_diff(ticks_ms(), b1.last_pressed()) < 3000:

This is great! How do you feel about raising a PR for a change to the europi.py firmware?Kind Regards,Nik(Sent from a mobile device)On 14 Nov 2022, at 17:19, redoxcode @.***> wrote:
I noticed these as well working on my own script. I know there are pullup resistors on the europi board, but also enabling the internal pullups of the pi pico seams to resolve these issues for me. I think my header pins on the pico are not the best and it only happens on some eurorack PSUs.
To test this you can enable the pullups in your script like this:
b1 = Button(4)
b1.pin=Pin(4, Pin.IN,Pin.PULL_UP)
b2 = Button(5)
b2.pin=Pin(5, Pin.IN,Pin.PULL_UP)
or directly change this line in europi.py
self.pin = Pin(pin, Pin.IN)
to
self.pin = Pin(pin, Pin.IN,Pin.PULL_UP)
There are some other things I want to optimize in the DigitalReader class, that might resolve or at least reduce this issue as well.
I will propose a PR for these when I got time.
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you authored the thread.Message ID: @.***>

I can confirm the suggested code change seems to avoid the phantom button presses

Unfortunately, this change prevents the ability to long-press both buttons to return to the menu.

Is this still present? There was some minor fix to the logic in https://github.com/Allen-Synthesis/EuroPi/pull/212

Unfortunately, this change prevents the ability to long-press both buttons to return to the menu.
I guess you lost the irq handler for the both action by redefining the buttons.
That handler gets set in bootloader.py.
You should try to change europi.py to include the PULL_UP.


Set Swift as the default language in the Info.plist of the docc bundles

Set Swift as the default language in the Info.plist of the docc bundles.
This is so that code listings use Swift syntax highlighting by default.

Is this about setting the CDDefaultCodeListingLanguage key to swift in the plist?
If so, can we add the CDAppleDefaultAvailability to the plist as well?

@denil-ct Yup, that default listing language key is what we need.
Default availability is trickier, we don't want to have to update it in multiple places, ideally docc would pick it up from the Package.swift platforms key. But you can file a separate issue tracking this, we don't want to broaden this issue.


[App Request] Pi.Alert

App Information

Name: Pi.Alert
Short Description:  WIFI / LAN intruder detector. Scans for devices connected to your network.
Official Website: No website / GitHub repo only
GitHub Repository: https://github.com/jokob-sk/Pi.Alert
Docker Image: jokobsk/pi.alert:latest

Why do you want this app?
It's a very neat app to keep an eye on the devices connected to your network and get alerted when new devices and/or intruders are detected.
Additional information?

It's a fork of the original (original is abandoned : https://github.com/pucherot/Pi.Alert)
Docker Compose : https://raw.githubusercontent.com/jokob-sk/Pi.Alert/main/docker-compose.yml
.env : https://raw.githubusercontent.com/jokob-sk/Pi.Alert/main/.env

The project got rebranded as NetAlertX now.
Docker Image: jokobsk/netalertx:latest
New GitHub repo : https://github.com/jokob-sk/NetAlertX
Docker Compose : https://github.com/jokob-sk/NetAlertX/blob/main/docker-compose.yml
.env : https://github.com/jokob-sk/NetAlertX/blob/main/.env

NetAlertX has been added to BigBearCasaOS: https://github.com/bigbeartechworld/big-bear-casaos


Add ReadMe with installation instructions to Jypyter project

Expected Behavior
Find installation instructions for Jupyter project at readme.md.
Actual Behavior
Installation instructions for Jupyter project does not exist.
Checklist

[x] I have completely filled out this template
[x] I have confirmed that this issue exists on the current master branch
[x] I have confirmed that this is not a duplicate issue by searching issues

PR #1801 has only addressed the Windows case.
This issue should remain open until macOS and linux are covered.


Is it possible to add APIs that load files from array buffer?

Hi, this project is excellent and when I am using it, I think I need some APIs that load files from ArrayBuffer. Right now I think only URL is supported for loading drawings. When the user wants to upload a local drawing file, there is no simple way to do it since the path is not accessible. Thank you

Hi @YuxiangChai,
There is a loadFromFile method that is part of NVImage.
You should be able to import it as use it like:
myImage = NVImage.loadFromFile(SomeFileObject) // files can be from dialogs or drag and drop

If you want users to add drawings to a scene, Niivue also readily supports drag and drop onto the canvas. You can drop an image onto the canvas and it will reset the scene, with only that image being shown, or you can drop an image on the canvas while holding SHIFT and the image will be added to the scene as an overlay.

Yes I saw that API but the thing is that if I directly drag and drop the drawing file to the canvas, the canvas won't display the drawings in the color I drew them (I guess it's because the drawing file is another .nii which is considered an ordinary 3D image). If I use loadDrawing to load a drawing file from a cloud URL, this drawing can be displayed in the correct color. Thank you


Preset for generating md-like tables

It's something like:
    style: { compact: true },
    chars: {
        'top': '' ,    'top-mid': '' ,    'top-left': '' ,    'top-right': '',
        'bottom': '' , 'bottom-mid': '' , 'bottom-left': '' , 'bottom-right': '',
        'left': '|' ,  'left-mid': '|' ,   'mid': '-' ,         'mid-mid': '|',
        'right': '|' , 'right-mid': '|' ,  'middle': '|'
    },

I guess it's a common case and would be very nice to have this preset as build-in one to use as simple as:
    preset: 'md'

Any luck with getting this to happen?   I can't figure out how to have the header styled differently from the body.

@zxqfox - we got this figured out (not the cleanest) but we'll be using our solution for our lib.  I was going to cheat and just do 3 dashes, required by markdown, but our CTO jumped in and did it 100%.
Was added here:   https://github.com/infinitered/gluegun/pull/284


Subsequent history entry selection not copied to prompt

[x] I have read through the manual page (man fzf)
[x] I have the latest version of fzf
[x] I have searched through the existing issues

Info

OS

[ ] Linux
[x] Mac OS X
[ ] Windows
[ ] Etc.

Shell

[ ] bash
[x] zsh
[ ] fish

Problem / Steps to reproduce
When I use Ctrl-R to search the history, if I select an entry, delete it from the prompt, and then search to select the same entry again, the string never appears in the prompt. I've also seen this happen when using Ctrl-T.
Here is a screencast:
https://user-images.githubusercontent.com/81891/124520317-f9037480-dde3-11eb-8675-bfe40114393a.mp4
I've tried to reproduce the issue in a clean environment but please let me know if there is a better way to debug this. Here are the steps I used:
# Start clean zsh shell
> zsh -d -f -i
# In the new shell, unset inherited FZF env vars
% unset FZF_DEFAULT_OPTS FZF_DEFAULT_COMMAND FZF_CTRL_T_COMMAND FZF_ALT_C_COMMAND
# Use a new history file
% HISTFILE="/tmp/bugzhistory"
# Load fzf
% [[ $- == *i* ]] && source "$BREW_PREFIX/opt/fzf/shell/completion.zsh" 2> /dev/null
source "$BREW_PREFIX/opt/fzf/shell/key-bindings.zsh"
% ls
# Ctrl-R & select ls
# Delete `ls` from the prompt
# Ctrl-R & select the same `ls` entry
# Observe that the entry is not copied to the prompt

I see why this is happening now and will close the issue. If anyone doesn't like this behaviour, please read on.
Years ago, #272 migrated from using history expansion to using zle's vi-fetch-history. The author wanted to be able to navigate up and down the history around the selected history entry, among other things.
My understanding is that vi-fetch-history fetches the selected history item and effectively makes it the current history entry for the duration of the line editor's lifetime (that is, until it exits by calling accept-line, for example). This is why Ctrl-N and Ctrl-P work relative to that entry.
Another consequence of setting the selection as the current history entry is that zle stores any edits to the entry's command text in memory. If you don't end up calling accept-line by pressing enter, for example, and instead press Ctrl-R again in the same editing session and select the same history entry, any outstanding edits end up shadowing the original command. In my screencast above, this is what happens. When I select the entry and then delete the text, I am editing a copy of the original command and this is saved. When I select the same entry, the widget checks if there any edits and uses that instead of the original if there are. In this case, my deletion is applied.
I'd prefer if the widget inserted the history entry's command text and didn't change the line editor's history-related state. To do this, replace the line in shell/key-bindings.zsh fzf-history-widget that contains zle vi-fetch-history -n $num with LBUFFER+="$(fc -ln $num $num)".


[0.7.1] Query page is not returning query data, but instead an empty JSON object

Describe the bug
Try and run a query against a WF that has a registered query handler.

should be fixed in v0.8.0 with https://github.com/temporalio/ui/pull/384


missing fingerprint feature when processing the SLO

see comment: https://github.com/onelogin/php-saml/commit/2e0ba98d98afb697d66e25f4420a2ac73c33015c#commitcomment-12905730
You should either update the README or add the missing feature.

When the signature of the IdP is embedded (HTTP-POST binding), then the "fingerprint trick" works, since I can validate the certificate associated with the signature using the fingerprint, and then use the whole certificate in order to validate the signature.
On HTTP-Redirect, the IdP certificate is not provide in the SAML Message so as you mention, the "fingerprint trick" does not work in this case.
I will update the README now.


Don't capitalize npm

npm is never supposed to be capitalized (according to the npm folks themselves), so fix an instance where that wasn't the case.

:thumbsup: sure thing :-)


Android support

In theory we should be able to port from Linux to Android without much trouble.  We'd have to add OpenAL ES support and create a JNI wrapper.

Looking at it a bit closer, it seems we might have to use the Android NDK, a C application framework for Android designed as an "effective way to reuse a large corpus of existing C/C++ code."


Show correct Trip Details times for 'scheduled arrival' buses.

Fixes #359
It appears that for scheduled arrivals—I guess not surprisingly—there's no trip status object on the tripDetails object in OBATripScheduleListViewController.m (specifically relevant on line 313 of that file). When _tripDetails.status is nil, the date that is loaded into the schedule list view controller is actually in 1970, not 2015. When status is represented by an object, the date is correctly in 2015.
This commit fixes that issue by properly setting a base date (now) for cases where there isn't a status object. Also adds some debug info to OBATripStopTimeV2.
@icecrystal23 - this fixes the bug you reported.

@icecrystal23 - can I get you to check out this branch and verify that it fixes the problem you reported?

Is there a TestFlight app or similar that I can download to test on a device?

@caitbonnar what would be the best way to get an ad hoc build our for someone at the moment? Old testflight still?

@aaronbrethorst Yep, or emailing them the IPA if they know how to install through iTunes.

Oh I'm guessing @icecrystal23 does know how to install through iTunes. :) So whatever's easiest for you! (I just looked at the context of Aaron's question, haha.)

@caitbonnar I don't think I have the necessary certificate to do ad hoc signing. This will require me to be added to the iTC account for OBA, right?

I wouldn't be able to install an ad hoc build unless my device was on the developer portal. I'd need an enterprise or TestFlight build.
Sent from my iPhone

On Feb 23, 2015, at 10:19 PM, Aaron Brethorst<EMAIL_ADDRESS>wrote:
@caitbonnar I don't think I have the necessary certificate to do ad hoc signing. This will require me to be added to the iTC account for OBA, right?
—
Reply to this email directly or view it on GitHub.

ok. I'm just going to go ahead and merge this, then, unless anyone has strong objections, and—hopefully—we can validate on-device soon. Thanks again!

@aaronbrethorst Ah, I see -- yeah, you don't yet have the credentials. :( Since you just merged this in, I will sign the build and upload the current dev branch to TestFlight. @icecrystal23 Here is the link for you to request to be a beta tester. (I'll add you to the iTunes connect list as well for the future.)

tyvm :) it'll be good to land all of the changes in the past few days in a new beta build, anyway.

@aaronbrethorst Should I release it to all beta testers, then?

I think that would be terrific. The networking stack changes that hit develop recently are pretty far-reaching, and I’d love to get as much feedback as possible.

On Feb 23, 2015, at 10:38 PM, Caitlin Bonnar<EMAIL_ADDRESS>wrote:
@aaronbrethorst https://github.com/aaronbrethorst Should I release it to all beta testers, then?
—
Reply to this email directly or view it on GitHub https://github.com/OneBusAway/onebusaway-iphone/pull/360#issuecomment-75707165.

Ok, sounds good! I'm going to see if I can figure out how to release with the new prelease module in iTC, could you summarize the changes for this beta to include in release notes (if it has em)?

Show correct Trip Details times for 'scheduled arrival' buses.
Searches with ampersands (&) and slashes (/) now work correctly.
Provide more debugging information in 'Contact Us'.
Rewrite of much of the core networking stack of the application.

(and thanks!)

Thanks! Will let you know when it's out.

:+1:

Hmm. So I just installed the TestFlight app and it seems that the issue still exists (and potentially even made it worse). I will attach a screenshot demonstrating the issue. The arrival at the stop was at 9:33pm, so the time at the next stop should've been like 9:38 or something.

@caitbonnar has a new build been published on TF?

So it has. I checked the same stop and the data is showing up correctly on my installation. Not sure what might be going on :-/

The first arrival at the stop tends to works better, remember? (Although that's not always true; I tried another stop somewhere and the first one was all wrong too.)
Sent from my iPhone

On Feb 25, 2015, at 10:14 PM, Aaron Brethorst<EMAIL_ADDRESS>wrote:
So it has. I checked the same stop and the data is showing up correctly on my installation. Not sure what might be going on :-/
—
Reply to this email directly or view it on GitHub.

Assuming this is pulling data from trip-details endpoint - it's possible that this is a server-side error.  We don't use trip-details endpoint on OBA Android, so this wouldn't have been visible in that app.  Furthermore, Sound Transit uses several instances of OBA servers behind a load balancer.  It's very possible that you're actually hitting different servers and getting different responses.  What makes this even more difficult is that the load balancers are configured for "sticky routes", which means that if your public-facing IP is stable, you'll always hit the same server.  So, if you get a bad response the first time, you're likely to always get a bad response from the same server - vice versa for good responses.
I think the best way to eliminate this as a possible error source is for @icecrystal23 to try and capture the server response that's resulting in the bad times, and @aaronbrethorst to do the same (when seeing good times), and compare.

I actually was able to reproduce this in the simulator tonight.  I have a new change to try (seemed to work for the stop in the simulator anyway).  I will see if I can get it into a pull request.

It looks like the latest TestFlight build was pushed as 2.4 and I think Google Analytics is reporting it as 2.4. In the future I think it'd be best to make sure test builds have unique versions from release versions so we don't blurr the analytics. I believe at one point we were using the Git SHA1 as part of the version number. It might even be worth looking in to using a seperate tracker for test builds.


no-std fork stack overflow fatal errors on some tests

Not really your problem, but would appreciate some 👁  on a stack overflow error that occurs when running tests that expects a panic.

is this still relevant?

Closing, was related to incorrect implementation of Display trait and fixed in the same no-std contribution PR.


github-actions user despite custom token

Since late July/early August, using a custom token: $MYBOT_TOKEN no longer results in "mybot released this X days ago." Instead, it incorrectly says "github-actions released this X days ago." Example: https://github.com/iterative/shtab/releases
Is there a problem with action-gh-release? Or is it another accidental breaking change GH made (to be reported at https://github.community)?

Hi there. I see your last release was 4 days ago and your using an env var for the token
You were likely caught in a breaking change that was fixed just yesterday
https://github.com/softprops/action-gh-release/releases/tag/v0.1.8
the breaking change was a merge of a pr that introduced resolving the token from an input falling back on an env var. the breaking change was that the input was declared with a default of the actions provided token which always exists meaning the env var would never get used. The fix for backwards compat was to swap the resolution order to look for the env var and then the input

Ah related #132, fixed by #133


IP Pool usage probability

Adding a chance/probability to the IP addresses in an IP pool would allow you to manage the amount of traffic an IP handles. Currently it's completely random (literally RAND()).
Adding a probability would allow you to warm up IPs (gradually increase the probability over time).

It would be nice to have something to allow new IPs to be introduced slowly into a pool. As you say, right now it is totally random.

In case you still need it, i needed it and build something very quick myself. #833


Parameters that affect GPU RAM usage

Thanks for the wrok. I tried to reproduce the results of this paper, however I encountered the problem of insufficient GPU RAM.
The python file I am trying: mm-shap_albef_dataset.py
DATA I used: existence
number of sample: all
The basic setting I used:
# num_samples = sys.argv[1] # "all" or number
num_samples = "all" # "all" or number
if num_samples != "all":
    num_samples = int(num_samples)
# checkp = sys.argv[2] #  refcoco, mscoco, vqa, flickr30k
checkp = "mscoco" #  refcoco, mscoco, vqa, flickr30k
# write_res = sys.argv[3] # "yes" or "no"
write_res = "yes" # "yes" or "no"
task = "image_sentence_alignment"  # image_sentence_alignment, vqa, gqa
other_tasks_than_valse = ['mscoco', 'vqa', 'gqa', 'gqa_balanced', 'nlvr2']
use_cuda = True

The problem I encounter:
RuntimeError: CUDA out of memory. Tried to allocate 16.00 MiB (GPU 0; 2.00 GiB total capacity; 1008.19 MiB already allocated; 11.44 MiB free; 1.04 GiB reserved in total by PyTorch)

I am wondering if I cannot scale my GPU RAM right now, which Parameters I should pay attention to?
following few option on my mind now:

[x] num_samples

[x] patch_size (?)
I try this today, but it will affect the shape torch.Size. I only change it from 16 to 32

RuntimeError: Error(s) in loading state_dict for VL_Transformer_ITM:
        size mismatch for visual_encoder.pos_embed: copying a param with shape torch.Size([1, 577, 768]) from checkpoint, the shape in current model is torch.Size([1, 145, 768]).
        size mismatch for visual_encoder.patch_embed.proj.weight: copying a param with shape torch.Size([768, 3, 16, 16]) from checkpoint, the shape in current model is torch.Size([768, 3, 32, 32]).

Thanks for your reading and time in advance.

Hello @ChengYuChuan , thanks for the question!
Unfortunately, none of the MM-SHAP script parameter reduce VRAM utilization.

The num_samples determine on how many examples you want to evaluate, but this evaluation is sequential (all samples are dona after the other) so no reduction here. It seems like you do not have enough VRAM for even one sample interpretation.
You should not change the patch_size because otherwise you will have too different sequence lengths for text and image, negatively affecting the interpretation.

Proposed Solution:
So the only thing I can imagine is that you should reduce the batch size of the shap.Explainer which is defined here. I think all you need to do to affect this parameter there, is change this line to shap.Explainer(                     get_model_prediction, custom_masker, silent=True, batch_size=1) or tot he maximum batch_size that fits in your VRAM.
Hope this helps!

hello @LetiP , thanks for you quick reply.
I am trying to reduce the batch size as you said, but the weird thing is Tried to allocate 16.00 MiB the number of this did not change when I decreased the batch size.
May I ask what's your computer spec. ?
I am considering to try the whole program on a Mac M1 chip with 16 RAM or deploy it on google colab, but the Cuda part seems to me that only support the NVIDIA GPU. However, this project is based on python 3.6 I am worried that python 3.8 would not colabrate with the env setting.... (Since if I make it run on Mac M1, I need to use the latest PyTorch 1.12 wiht python 3.8)
Have you ever heard someone run the project on MAC system or colab? (sorry,I know this question may not be in your experience. :/)

Where exactly the code throws OOM errors? Because from what you just said, it might be even at the level of the model loading and it does not get into the SHAP analysis where the decrease of the batch size might help.
I used a GPU with a 24GB VRAM. I see no reason for why the code would not work with python 3.8. Definitely worth a try. I did use Linux on the local cluster so sorry, I have no experience with mac and colab for this project.
Just thinking that maybe you could also try to:

load the model in float.16 and see if it supports half precision?
load the model here with torch.no_grad() around it.

Sorry, I should have described the problem more specifically in the beginning.
In the beginning, I thought it was only an evaluation between different metrics, therefore I thought a normal PC could handle this.
I only have an Nvidia GeForce MX150 GPU with 2 VRAM...
Here is my error message.
(shap) C:\Users\Louis\PycharmProjects\NLP\MM-SHAP>python mm-shap_albef_dataset.py
Argument interpolation should be of type InterpolationMode instead of int. Please, use InterpolationMode enum.
  0%|                                                                                | 0/534 [00:03<?, ?it/s]
Traceback (most recent call last):
  File "mm-shap_albef_dataset.py", line 280, in <module>
    model_prediction = model(image, text_input)
  File "C:\Users\Louis\anaconda3\envs\shap\lib\site-packages\torch\nn\modules\module.py", line 1051, in _call_impl
    return forward_call(*input, **kwargs)
  File "mm-shap_albef_dataset.py", line 84, in forward
    image_embeds = self.visual_encoder(image)
  File "C:\Users\Louis\anaconda3\envs\shap\lib\site-packages\torch\nn\modules\module.py", line 1051, in _call_impl
    return forward_call(*input, **kwargs)
  File "C:\Users\Louis\PycharmProjects\NLP\MM-SHAP\ALBEF\models\vit.py", line 171, in forward
    x = blk(x, register_blk==i)
  File "C:\Users\Louis\anaconda3\envs\shap\lib\site-packages\torch\nn\modules\module.py", line 1051, in _call_impl
    return forward_call(*input, **kwargs)
  File "C:\Users\Louis\PycharmProjects\NLP\MM-SHAP\ALBEF\models\vit.py", line 92, in forward
    x = x + self.drop_path(self.attn(self.norm1(x), register_hook=register_hook))
  File "C:\Users\Louis\anaconda3\envs\shap\lib\site-packages\torch\nn\modules\module.py", line 1051, in _call_impl
    return forward_call(*input, **kwargs)
  File "C:\Users\Louis\PycharmProjects\NLP\MM-SHAP\ALBEF\models\vit.py", line 63, in forward
    attn = (q @ k.transpose(-2, -1)) * self.scale
RuntimeError: CUDA out of memory. Tried to allocate 16.00 MiB (GPU 0; 2.00 GiB total capacity; 1008.19 MiB already allocated; 11.44 MiB free; 1.04 GiB reserved in total by PyTorch)

Do you mean to change the model path here? (checkp = "mscoco" #  refcoco, mscoco, vqa, flickr30k this is my current pick. )
https://github.com/Heidelberg-NLP/MM-SHAP/blob/00a66bf932315d88be1e33c5bf39b0d8dc507d55/mm-shap_albef_dataset.py#L202

the original code is:

# create an explainer with model and image masker
# change here to overcome GPU our of memory
explainer = shap.Explainer(get_model_prediction, custom_masker, silent=True, batch_size = 32)
shap_values = explainer(X)
mm_score = compute_mm_score(nb_text_tokens, shap_values)

when I want to activate torch.no_grad(), how should I manage this?
here is my first thought:
with torch.no_grad():
    explainer = shap.Explainer(get_model_prediction, custom_masker, silent=True, batch_size = 32)
shap_values = explainer(X)
mm_score = compute_mm_score(nb_text_tokens, shap_values)

Ok, so it is clear that your problem is not the shap (interpretability code), but just plain model inferencing. Given your hardware, you cannot load the ALBEF model. The code does not even get to the interpretation.
Since this script is about interpreting a model, you need enough space to run the model, which you apparently do not have.
I think you need to edit this, to
    with torch.no_grad():
        checkpoint = torch.load(model_path, map_location='cpu')
        msg = model.load_state_dict(checkpoint, strict=False)

Also, it is best to put that also around the line that throws the error message for you, just in case.
    model_prediction = model(image, text_input)

@LetiP Thank you so much.
After I talk to my lecturer, I switch the task to cluster.
I would like to implement the project there.
Therefore, I won't encounter this issue anymore.
Thank you again. :D

Great! Best of luck and may the cluster be with you. 🤞


trilium: init at 0.26.1

Motivation for this change
Closes #51355.
Building from source would be better,
but looks to require significant effort at best.
Until a brave hero overcomes this fearsome challenge
patching up the binary isn't too bad
and has worked well enough for at least
light use by myself and another user
over the past few weeks.
Aspiring heroes should note this is low-glory
and are encouraged to apply themselves elsewhere instead.
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Assured whether relevant documentation is up to date
[ ] Fits CONTRIBUTING.md.

Works with Nixpkgs on Xubuntu as well :+1:


Osh dev patcher with support for building suse openstack service images

I have added another PR#43 so closing this one.


MachinePool: Allow Platform edits via override

Normally we forbid updates to MachinePool.Spec.Platform via an admission hook because, while we would roll out the changes to the MachineSets on the target cluster, MCO ignores those changes.
With this commit, you can add an annotation to a MachinePool
hive.openshift.io/override-machinepool-platform: "true"

to bypass this check. By doing so, you are taking responsibility for forcing rollout of any changes, e.g. by deleting the Machines on the target cluster.
HIVE-2024

/assign @abutcher

/lgtm


Bumped branch alias

i think you are right, #20 should have bumped the alias as its not an urgent fix, more of a DX fix and making features work that previously where not useable as intended.

It's a new feature, so per semver, the next release should be minor, not patch.

its an edge case, as one could argue it was meant to work like this but never did work.


Don't create an invalid CertificateRequest (1.0.2)

We should validate that the various fields we put into the
CertificateRequest are not too long. Otherwise we will construct an
invalid message.
Fixes #6609
This is the 1.0.2 version of #6628.

Pushed. Thanks.


(PDB-1932) deprecate catalog-hash-debug

This documents the deprecation of catalog-hash-debugging.

Refer to this link for build results (access rights to CI server needed):
http://jenkins-enterprise.delivery.puppetlabs.net/job/enterprise_puppetdb_init-multijob_githubpr-master/45/
Test PASSed.


Load balancers not appearing on Hosts in Infrastructure

Rancher Version:
1.1.2
Docker Version:
1.12.0
OS and where are the hosts located? (cloud, bare metal, etc):
Ubuntu 14.04 / AWS
Setup Details: (single node rancher vs. HA rancher, internal DB vs. external DB)
Single node, external DB
Environment Type: (Cattle/Kubernetes/Swarm/Mesos)
Cattle
Steps to Reproduce:

Create a stack with a service and a load balancer
Globally schedule both the load balancer and service

Results:

In the Infrastructure tab, examine the Hosts. The Load Balancer is not appearing in the Stack.
the number of load balancer containers is still correct, if getting the "info" on the LB service from the Stacks page.
confirmed by SSHing into the host that the LB is in fact running on that host

Expected:

Load Balancers should appear on their respective hosts on the Infrastructure page.

Another observation to add: if the service of the stack is NOT globally scheduled (but the LB is), then the hosts that don't have any containers for the service running, don't even have this Stack displayed on them either. The hosts that DO have the service running, show the Stack, the container for the service, but not the LB.
Not sure if this is related to #5332

OMG. nevermind...

I ❤  you guys, but sometimes the UI changes you introduce are frustratingly non-obvious. :)

Glad you found it. :-)


Option to calculate percentages according to requests/limits

Hi, first of all for this super useful plugin, it's exactly what I was missing for some time!
In order to reduce the memory footprint of apps on my cluster I'd like to tune memory requests and like to propose an option that calculates the mem metrics not according to the total node memory, but according to the requests/limits (same should be possible with CPU metrics, but my focus is on memory).
Right now kube-capacity shows 2% mem usage of the total node memory:
❯ kubectl resource-capacity --pods --util --sort mem.util | grep -E '(NODE|kustom)'
NODE        NAMESPACE      POD                                        CPU REQUESTS   CPU LIMITS   CPU UTIL    MEMORY REQUESTS   MEMORY LIMITS   MEMORY UTIL
bitrigger   flux-system    kustomize-controller-7dd58878b8-7jmnb      100m (2%)      0Mi (0%)     3m (0%)     64Mi (3%)         1024Mi (51%)    49Mi (2%)

What I'd be interested in is the percentage of i.e. the mem requests (which is what k9s shows in the default pod list), which is actually 77%:
│ NAMESPACE↑     NAME                                     PF   READY     RESTARTS STATUS       CPU   MEM   %CPU/R    %CPU/L    %MEM/R    %MEM/L IP             NODE          AGE       │
│ flux-system    kustomize-controller-7dd58878b8-7jmnb    ●    1/1              0 Running        3    50        3       n/a        78         4 <IP_ADDRESS>     bitrigger     3h4m

So a flag could be --percentage=[node|req|limit] which could apply to both CPU and mem metrics.

This would be beneficial


Introduce ClusterEnvironment.detect()

What does this PR do?
Part of #6303
Also addresses https://github.com/PyTorchLightning/pytorch-lightning/issues/10107#issuecomment-950848971
Introduces an interface for detecting the cluster environment. Previously, each enironment had a custom method:
TorchElasticEnvironment.is_using_torch_elastic
LSFEnvironment.is_using_lsf
KubeflowEnvironment.is_using_kubeflow

Now these implementations will be under the static method detect() inherited from the base environment.
Before submitting

[x] Was this discussed/approved via a GitHub issue? (not for typos and docs)
[x] Did you read the contributor guideline, Pull Request section?
[x] Did you make sure your PR does only one thing, instead of bundling different changes together?
[x] Did you make sure to update the documentation with your changes? (if necessary)
[x] Did you write any new necessary tests? (not for typos and docs)
[x] Did you verify new and existing tests pass locally with your changes?
[ ] Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review
Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

[x] Is this pull request ready for review? (if not, please submit in draft mode)
[x] Check that all items from Before submitting are resolved
[x] Make sure the title is self-explanatory and the description concisely explains the PR
[x] Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?
I made sure I had fun coding 🙃
Part of #1 (it's a lie, this is just here to avoid noisy GitHub bot)
cc @borda @justusschock @awaelchli @akihironitta @tchaton @kaushikb11

Let's introduce a generic environment label instead


Cython-generated unbound class methods cannot be pickled

Building the following module (src/module.py)
class MyClass:

    def __init__(self, a):
        self.a = a

    def my_method(self, b):
        return self.a + b

Using cython with the following setup script:
from distutils.core import setup
from Cython.Build import cythonize

setup(ext_modules=cythonize("src/module.py"))

Generates a class (MyClass), whose unbound methods cannot be pickled:
In [1]: from module import MyClass

In [2]: import pickle

In [3]: pickle.dumps(MyClass.my_method)
---------------------------------------------------------------------------
PicklingError                             Traceback (most recent call last)
<ipython-input-3-cf09bde7c7ba> in <module>
----> 1 pickle.dumps(MyClass.my_method)

PicklingError: Can't pickle <cyfunction MyClass.my_method at 0x7f8d130e9ea8>: attribute lookup
my_method on module failed

Note that if this class is defined as an extension type (using cdef) then MyClass.my_method becomes a method_descriptor, which is picklable by default. So this bug affects only non-extension cython classes (in this case, MyClass.my_method is a cyfunction, with an invalid __reduce__ method).


[GDExtension] Implement support for typed arrays.

Exposes missing Array methods, and add typed arrays to the GDExtension JSON.
godot-cpp part - https://github.com/godotengine/godot-cpp/pull/841

Does this supersede https://github.com/godotengine/godot/pull/64249?

As usual, it will need rebase after https://github.com/godotengine/godot-cpp/pull/841 merge to pass CI.

This also the discussion on #64249 on how to handle this kind of generics in different languages.

Looks fine, but I don't see what are the TypedArray related changes in TextServers?

TextServer already was using TypedArrays (and was unbuildable for this reason), TS changes are to make it buildable as an extension again, but not directly related to TypedArray.

This also the discussion on https://github.com/godotengine/godot/pull/64249 on how to handle this kind of generics in different languages.

TypedArrays are its own subtype in the engine, so for godot-cpp method binds should have it as an independent type as well.
The generics, like Dictionary content or more specific contents of the generic Array, are used only for properties, and irrelevant for C++ bindings. So I guess it's better to have it as extra info (like in #64469) for other language bindings, if they need it.

I'll merge even though the CI build with godot-cpp hasn't completed yet, to unblock other PRs (as the counterpart merged in godot-cpp breaks building against current Godot code until this is merged).

Thanks!


Use JSON version of group_overview

Use .json version of group_overview page to prevent having to parse the HTML page and improve performance
Update the test date: Create json files
Remove obsolete after_61b4db60 test

The commit message just states the obvious and it could have a bit more details, e.g. what issue is fixed, why this needs to change, to which versions of which product it applies, link to a bug or a fate entry, the choices you made, etc. Also see http://chris.beams.io/posts/git-commit/ as a helpful guide how to write good commit messages.

Updated commit msg.


Can't open files

Testing #226399
This is on mac. When I try to open any file in any folder, I see this.

Weirdly, I can't find anything interesting in any log. Here's the trace-level window output. I opend id.ts from the quick pick
2024-08-27 15:22:15.296 [trace] SearchService#search: 43ms
2024-08-27 15:22:15.296 [trace] QuickAccess fileSearch 45ms
2024-08-27 15:22:16.143 [trace] [text file model] resolve() - enter file:///Users/roblou/code/vscode/src/vs/base/node/id.ts
2024-08-27 15:22:16.144 [trace] [text file model] resolveFromFile() file:///Users/roblou/code/vscode/src/vs/base/node/id.ts
2024-08-27 15:22:16.171 [trace] [text file model] dispose() file:///Users/roblou/code/vscode/src/vs/base/node/id.ts
2024-08-27 15:22:16.171 [trace] [backup tracker] discarding backup file:///Users/roblou/code/vscode/src/vs/base/node/id.ts
2024-08-27 15:22:16.171 [error] {"isTrusted":true}
2024-08-27 15:22:16.171 [trace] [History stack global-default]: notifyNavigation() (editor: file:///Users/roblou/code/vscode/src/vs/base/node/id.ts, event: <none>)
2024-08-27 15:22:16.171 [trace] [History stack global-default]: notifyNavigation() not ignoring (editor: file:///Users/roblou/code/vscode/src/vs/base/node/id.ts, event: <none>)
2024-08-27 15:22:16.171 [trace] [History stack global-default]: onNonSelectionAwareEditorNavigation() (editor: file:///Users/roblou/code/vscode/src/vs/base/node/id.ts, event: <none>)
2024-08-27 15:22:16.171 [trace] [History stack global-default]: add() (editor: file:///Users/roblou/code/vscode/src/vs/base/node/id.ts, event: <none>)
2024-08-27 15:22:16.171 [trace] [History stack global-default]: index: 1, navigating: false
- group: 0, editor: walkThrough://vscode_getting_started_page, selection: <none>
- group: 0, editor: file:///Users/roblou/code/vscode/src/vs/base/node/id.ts, selection: <none>

2024-08-27 15:22:16.173 [trace] [History stack global-default]: index: 0, navigating: false
- group: 0, editor: walkThrough://vscode_getting_started_page, selection: <none>

2024-08-27 15:22:16.711 [trace] CommandService#executeCommand _setContext
2024-08-27 15:22:16.741 [trace] CommandService#executeCommand _setContext

Works on Linux though!

@roblourens does this reproduce from a fresh profile or fresh user data dir?
So you were never able to open any editor during testing exploration?

It works with a fresh user data dir, and a fresh profile. I'm pretty sure I installed it from scratch yesterday, but I did enable setting sync, and it probably synced ui state.
I did do the testing, I was assigned Linux and it worked there. I was just trying it on my mac too where I see this issue.

Happy to do some debugging if you can suggest a place to set a breakpoint, I don't know where to start.  Do you have encoding related settings?

Nevermind, I can reproduce!

@bpasero, is the an ESM exploration build that contains the fix that can be used to verify this?

@lszomoru yes https://builds.code.visualstudio.com/builds/exploration?commit=1cc150cf084519b0fe8745a0925b8f1db8f28a3f

Steps:

configure files.autoGuessEncoding to true
close all files
open any file from explorer, it should show the contents


Question about dataset

Dear authors, I'd like to ask how to access the OS_scan dataset of the kitsune model.

Thanks for your interest in our work!
For the access to Kitsune dataset, please check the link here: https://www.kaggle.com/datasets/ymirsky/network-attack-dataset-kitsune.


Improve LintDiff error in case an OpenAPI spec file path mentioned in README does not exist (related to Avocado)

Bug reported in Teams by Suhas Rao here
Affected PR:

https://github.com/Azure/azure-rest-api-specs-pr/pull/17455
https://github.com/Azure/azure-rest-api-specs-pr/pull/17455/checks?check_run_id=22637797388

Root-cause
The file https://github.com/Azure/azure-rest-api-specs/blob/main/specification/monitor/resource-manager/Microsoft.Monitor/stable/2023-04-03/monitoringAccounts_API.json
is missing from the RPSaaSMaster branch but it is mentioned in the processed README resulting in error of:

Could not read 'file:///mnt/vss/_work/1/lint-c93b354fd9c14905bb574a8834c4d69b/specification/monitor/resource-manager/Microsoft.Monitor/stable/2023-04-03/monitoringAccounts_API.json

Root-cause analysis
From the build log:
[
  {
    "type": "AutoRest exception",
    "message": "Process() cancelled due to failure",
    "readmeUrl": "[https://github.com/Azure/azure-rest-api-specs-pr/blob/RPSaaSMaster/specification/monitor/resource-manager/readme.md",](https://github.com/Azure/azure-rest-api-specs-pr/blob/RPSaaSMaster/specification/monitor/resource-manager/readme.md%22,)
    "tag": "default",
    "context": "before"
  },
  {
    "type": "AutoRest exception",
    "message": "!Error: Could not read 'file:///mnt/vss/_work/1/lint-c93b354fd9c14905bb574a8834c4d69b/specification/monitor/resource-manager/Microsoft.Monitor/stable/2023-04-03/monitoringAccounts_API.json'.",
    "readmeUrl": "[https://github.com/Azure/azure-rest-api-specs-pr/blob/RPSaaSMaster/specification/monitor/resource-manager/readme.md",](https://github.com/Azure/azure-rest-api-specs-pr/blob/RPSaaSMaster/specification/monitor/resource-manager/readme.md%22,)
    "tag": "default",
    "context": "before"
  },
  {
    "type": "AutoRest exception",
    "message": "Autorest completed with an error. If you think the error message is unclear, or is a bug, please declare an issues at https://github.com/Azure/autorest/issues with the error message you are seeing.",
    "readmeUrl": "[https://github.com/Azure/azure-rest-api-specs-pr/blob/RPSaaSMaster/specification/monitor/resource-manager/readme.md",](https://github.com/Azure/azure-rest-api-specs-pr/blob/RPSaaSMaster/specification/monitor/resource-manager/readme.md%22,)
    "tag": "default",
    "context": "before"
  }
]

We can see:

Could not read 'file:///mnt/vss/_work/1/lint-c93b354fd9c14905bb574a8834c4d69b/specification/monitor/resource-manager/Microsoft.Monitor/stable/2023-04-03/monitoringAccounts_API.json

From the check run we can get link to README.md:

base / RPSaaSMaster README.md
new README.md

In both cases we can see that Tag: package-2023-04 has input files:

Microsoft.Monitor/stable/2023-04-03/monitoringAccounts_API.json

At the same time we can see that specification/monitor/resource-manager/Microsoft.Monitor does not even have stable directory, in both RPSaaSMaster and the "new" commit.
However, it is present in public main:

https://github.com/Azure/azure-rest-api-specs/blob/main/specification/monitor/resource-manager/Microsoft.Monitor/stable/2023-04-03/monitoringAccounts_API.json

As well as private main:

https://github.com/Azure/azure-rest-api-specs-pr/blob/main/specification/monitor/resource-manager/Microsoft.Monitor/stable/2023-04-03/monitoringAccounts_API.json

Hence the issue is that the file is missing from RPSaaSMaster
Related work

https://github.com/Azure/azure-sdk-tools/issues/7761

In general, we should nicely wrap relevant AutoRest exceptions. Another, different case:
{
    "type": "AutoRest exception",
    "message": "!Error: There are multiple operations defined for   'get: /providers/Microsoft.PortalServices/operations'.  You are probably trying to use an input with multiple API versions with an autorest V2 generator, and that will not work.",
    "readmeUrl": "[https://github.com/Azure/azure-rest-api-specs-pr/blob/RPSaaSDev/specification/portalservices/resource-manager/readme.md",](https://github.com/Azure/azure-rest-api-specs-pr/blob/RPSaaSDev/specification/portalservices/resource-manager/readme.md%22,)
    "tag": "package-2023-08-01-preview",
    "context": "before"
  },


Added time dilation calculator

Issue Id you have worked upon -
Time Dilation Calculator #404
Briefly explain your program logic -
This calculator takes input of time interval and observer velocity and returns the output as relative time.
Screenshots(Attach 2 screenshots of your own input and output) -

By raising this PR I affirm that -

[x] My code follows the guidelines of this project.

[x] I have performed a self-review of my own code.

[x] I have commented my code.

[x] My code gives the correct output.

[x] I affirm that I strictly follow contributing guidelines and code of conduct.

Congratulations 🎉 @aditya962 on your contribution.
Thanks for adding value to this repository. 😊
Let's celebrate this fest 😃 by providing more developers 👨💻👩💻 an opportunity to contribute. Help us make this repository reach far and more by sharing this to your friends and colleagues.
Your efforts can make difference.

Hey 👋, may you also encourage us by clicking the star icon on the repository main page. ⭐

@aditya962,
Thanks again, for putting in an extra effort to add Info file.


It is not possible to wrap a column in the Widget StickyGroupedListView.

I tried to wrap StickyGroupedListView with Column... but it didnt work.

I solve the problem by wrapping StickyGroupedListView with Flexible. Column(       children: [         Text('Here'),         Flexible(           child: StickyGroupedListView<SinoElemento, DateTime>(

@rdurelli seems like you found a solution yourself. Another option is to use the Expanded-Widget instead of the Flexible-Widget.
 Column(
   children: <Widget>[
     Expanded(
       child: GroupedListView<dynamic, String>(),
      ),
    ],
  },


ROUTE TO CREATE MISSION

Has this been a signed  ?

This Route should be a POST method, to allow those with Admin privilege create Mission Statement

Has this been assigned?


add: db index docs

Related to: https://github.com/frmscoe/postman/pull/42

It might be worth explaining how the document relates to the Postman collection with some kind of introduction.
Context would be helpful to understand where the application of the indexes fits into the overall deployment process as well.
I'd at least add a reference to the /postman repository and the specific test collection that contains the indexes.


fix: retry unexpected curl errors

We were sometimes seeing CURLE_HTTP2 "Error in the HTTP2 framing
layer" errors when downloading large (20G) files using HTTP2. Details
captured in b/171350177.
Retying these errors works around the problem. Changed the default
behavior to retry all curl errors that aren't explicitly handled
separately in the switch statement.

This change is

google/cloud/storage/internal/curl_handle_test.cc, line 50 at r1 (raw file):

      {CURLE_GOT_NOTHING, StatusCode::kUnavailable},
      {CURLE_AGAIN, StatusCode::kUnknown},
      {CURLE_HTTP2, StatusCode::kUnavailable},

nit: if this compiles everywhere then the comment saying it is not defined in some versions of libcurl is no longer applicable, remove the comment?

Well, in the curl header it says:
https://github.com/curl/curl/blob/ede125b7b7ca8fc5a1fe3d7c1aee6bff2ea0bf24/include/curl/curl.h#L504-L506
  CURLE_HTTP2,                   /* 16 - A problem in the http2 framing layer.
                                    [was obsoleted in August 2007 for 7.17.0,
                                    reused in July 2014 for 7.38.0] */

So there are some old versions of curl where this define won't be available. I don't think we test w/ any of those old versions, so our tests will likely not break. I'm not even sure if our code supports any of those old versions. So I removed the comment anyway.

google/cloud/storage/internal/curl_handle_test.cc, line 50 at r1 (raw file):
Previously, devjgm (Greg Miller) wrote…
Well, in the curl header it says:
https://github.com/curl/curl/blob/ede125b7b7ca8fc5a1fe3d7c1aee6bff2ea0bf24/include/curl/curl.h#L504-L506
  CURLE_HTTP2,                   /* 16 - A problem in the http2 framing layer.
                                    [was obsoleted in August 2007 for 7.17.0,
                                    reused in July 2014 for 7.38.0] */

So there are some old versions of curl where this define won't be available. I don't think we test w/ any of those old versions, so our tests will likely not break. I'm not even sure if our code supports any of those old versions. So I removed the comment anyway.

Removing the comment SGTM.


Pre-commit hook to run a linter & fail the commit if lint error are there

When someone tries to commit the code, it should run a linter and fail if lint errors are there.

Let's add this setting up the pre-commit hook into the repo using the Makefile's setup command

Closed


Add new Lazy Queue package to allow components to defer loading

Jira
http://vjira2:8080/browse/BDS-2104
Summary
Packages up the core work to help us significantly boost our client-side web performance in the design system.
Details
In a nutshell, this package allows any web component to register a custom element tag (or HTML tags) with a callback that runs once one of those tags is on the page.
To put it another way: this lets us have a very small JS bundle that loads on every page and defer loading almost all of the component-specific code in Bolt except for those elements that are originally present + dynamically load any additional code for new components that get added later on.
Beyond adding this new lazyQueue helper, this PR also minimally wires it up to the Video and Chip components to demonstrate actual usage + give us a few data points to start to measure against.
Internally this uses the Idle Until Urgent pattern to prioritize the UI that's already there and more lazily handle any UI that isn't.
How to test

Review code updates in this PR
Confirm that the two components wired up here load up and work exactly as expected (meaning, when they don't exist on the page, the JS bundles for these never load and if they do end up getting added later on, the JS bundles get loaded dynamically)

Note: while this PR setups up the core functionality used under the hood, the most exciting changes (and largest perceived impact with this) is combining this work with the other related perf updates.

Per comment from @sghoweri on Slack, this PR must ship with #1831 and #1842, or we will see unwanted FOUC.
If for some reason #1831 and #1842 cannot ship, we must disable lazy queue.

Thanks @danielamorse! 🙏

PR was released with v2.23.0


Admin user

Issues fixed:
#21 user able to create new organisation and edit
#20 user able to delete an organisation from database
#19 a table listing all organisations available with buttons to edit and delete

@auxfuse I have updated Materialize's cdn to Bootstrap5 and Bootstrap icons. Classes on all three templates for organisation's CRUD are also updated accordingly with bootstrap :)

Hi @thanh-cao thank you for the updates 😀We've just merged another PR that has unfortunately now given your's some conflicts in the app.py file. Can you resolve, push and then we can merge 💯

@auxfuse I have fixed the conflicts in the app.py. Reason for conflict was that both John and I created same functionality to create new organisation BUT for 2 different user roles: admin and normal user. I have kept John's code and adjusted a mine accordingly to keep name consistency. I have left a todo note there for some discussion if we should define permission here for admin and user to be implemented later.
Made some adjustments to the templates to keep the styling consistent in both create and edit templates.
I didn't make any adjustments to company_web_scraper.py but for some reason it says on my branch that I have to commit the file so. I have checked with the content of the file on this repo and there isn't any difference between the two.


Idle Inhibitor Keybind?

Is there any way to have the idle inhibitor be toggled via a command or keybinding?

This concerns sway more so than waybar, see sway(5) manpage, you're looking for the inhibit_idle option.

The idle_inhibitor module uses a normal Wayland protocol to achieve this. So it is in-fact not related to Sway.
See: https://github.com/Alexays/Waybar/blob/4e256cf3f0df8a404b4f40724a41dca1ad1c5cea/src/modules/idle_inhibitor.cpp#L49 (zwp_ means that it's a staging Wayland protocol, wp_ are stable protocols).
If you were to change Sway's inihbit_idle with a keybind, it wouldn't reflect in Waybar.
Apart from writing a daemon that would handle persistent inhibition I don't see an easy way to achieve this currently.

Oh sorry, I didn't this was the case.

Related to #690?
This doesn't seem possible currently.


Updates to 12-SNAPSHOT

I have intentionally left distinct commits
Some plugins where not updated due to Java 7 constraint
Duplicate lines to ASF parent have been removed
Obsolete config has been removed too

This change will require also changes to Core 5 and Client 5 POMs, but they need streamlining anyway. I have parts of the changes already locally and both build fine (master and 5.1.x.).

@garydgregory I have reverted the protocol change. See also: https://issues.apache.org/jira/projects/LEGAL/issues/LEGAL-457
Is there anything else or do you approve too?

@michael-o Please go ahead, merge this change-set and put the new release on a lazy vote. @garydgregory will have a chance to object to any of those changes during the release vote if it comes to that.

I don't make legal policies at Apache.

https://www.apache.org/legal/src-headers.html

All in.


Drop suffix from protected value trait

And prepare the changelog for release.
Refs #13

@elazar CR this one too? I should have included this with the other PR. :fearful:

Never mind, I was looking at the wrong file.


transform_condition allow for null

A transform_condition that operates on a nullable field has 3 states rather than two.
The existing 2 query system can leave one of the states out of the dump.
Have the NOT version of the query perform an IS NULL check.
✓ Checklist:

[ ] This PR has been added to CHANGELOG.md (at the top of the list);
[x] Tests for the changes have been added (for bug fixes / features);
[ ] Docs have been added / updated (for bug fixes / features).

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (b23d99e) 87.06% compared to head (545bc8f) 87.58%.

:exclamation: Current head 545bc8f differs from pull request most recent head 09619e7. Consider uploading reports for the commit 09619e7 to get more accurate results

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #203      +/-   ##
==========================================
+ Coverage   87.06%   87.58%   +0.51%
==========================================
  Files          60       60
  Lines        4191     4156      -35
==========================================
- Hits         3649     3640       -9
+ Misses        542      516      -26

Files
Coverage Δ

datanymizer_dumper/src/postgres/table.rs
92.04% <100.00%> (ø)

... and 30 files with indirect coverage changes

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

@evgeniy-r please review


Issues building example

There are several issues with the example folder:

Executing bower install inside ./example installs libs to ./example/bower_components but ./example/app/index.html expects them to be in ./example/app/bower_components
bower install fails because of some dependency it can't resolve ("citylife_styles_and_components")
bower.json doesn't actually list material-date-picker as a dependency; the example doesn't work unless installed manually.

I fixed these issues, out of date documentation and removed the faulty example. You can find an example in the docs for now


Specify path for nyc module

Description
I'm currently getting the following error as a popup in vscode when I try enable the extension:
side-bar: cant find nyc locally and there is no setting for other path,
Error: get-installed-path: module not found "nyc" in path
/Users/me/Repositories/thisRepo/src/node_modules/nyc

I have nyc at /Users/me/Repositories/thisRepo/src/tests/node_modules/nyc
I have already set mocha.path to point to this node_modules directory yet I still get the error. It would be nice to either be able to set the path specifically for nyc, or have one place to set all node modules.
Settings file
{
	"mocha.options": { "compilers": "ts-node/register" },
	"mocha.requires": ["ts-node/register"],
	"mocha.files.glob": "test/*.test.ts",
	"mocha.path": "tests/node_modules/mocha"
}

Versions

VScode: v1.38.1
Mocha SideBar: v0.22.2
Node Version: v10.15.0

OS version

[ ] Linux
[X] Mac
[ ] Windows

Yes, this is much-needed feature. I am not able to use the mocha sidebar plugin because of this as my node_modules folder is not located at the root of the project so the plugin is not able to find nyc.

Any news?
I have a VSCode workspace with 2 projects (for backend and frontend), it seems that it's impossible to use Moch sidebar in such a configuration :(

Any news?
I have a VSCode workspace with 2 projects (for backend and frontend), it seems that it's impossible to use Moch sidebar in such a configuration :(

Having same problem, no fix yet?

Same issue, no workarounds?

Any news?