feat: add ask for help button

Checklist:

[X] I have read freeCodeCamp's contribution guidelines.
[X] My pull request has a descriptive title (not a vague title like Update index.md)
[X] My pull request targets the main branch of freeCodeCamp.
[X] I have tested these changes either locally on my machine, or GitPod.

Closes #XXXXX

This was brought up again, and we haven't really done anything to implement it, so...
This PR aims to add the Ask for Help button (which automatically creates the forum post template for a camper to get assistance with their code) to the multifile editor layout.
I've left this in a draft so we can discuss and spike on the implementation, but hopefully this gives us a starting point. Feel free to push commits as desired.

Thanks for looking into this, Naomi.
How about displaying it in the lower jaw only after the user has attempted passing the step a few times?

The approach for rendering the jaws isn't very React-like, it seems - I had to take a bit of a hacky approach to get the JSX to play well.

@nhcarrigan This PR is going to conflict mightily with my PR 45579 which addresses a bunch of accessibility issues with the status message in the lower jaw. Since this one is relatively simple, should I just add the button to mine?

Hey Bruce, thanks for the heads up. Currently this is more of a proof-of-concept, so we can spike on the implementation and decide what approach works best. That is, I'm not sure if we're keeping it in the lower jaw or not - once we land on an approach, if #45579 is still open we can revisit including this in that PR. 😁

@nhcarrigan at some point we discussed just showing the correct answer to the user after a few attempts. If that fails, then we would show them the ask for help button. Do you think that approach is feasible here?

@ahmadabdolsaheb I'm not sure about showing them the solution, however:
I've added a ref to track the number of attempts the camper has made to solve the challenge. If the number of attempts they have made exceeds the number of tests the challenge has, the Ask for Help button will display.
My thought process here was that campers may try to solve the challenge one test at a time, and we don't want to show the button until we know they are stuck.

Cool, I'll sort out the layout.

Here are a few thoughts about organizing the buttons in the lower jaw:

Remove the ( Ctrl + Enter )  from the button and show it as a tooltip on hover.  That info is not relevant for mobile users or experienced users. We could even hide the tooltip after a users completes a certain number of challenges assuming they have seen it by now.
Now that the button is narrower, we could show the Ask for help and Check your code buttons side by side and stack them for narrower panes.
Introduce a new button color that help users identify the primary button on each group.

Finally, I am not sure if we should show the ask for help by default and disable it. Thoughts?

Remove the ( Ctrl + Enter )  from the button

@ahmadabdolsaheb I agree with you completely on this. It is quite repetitive to have to listen to it when using a screen reader. There are some things to consider when replacing it with a tooltip though. They are notoriously hard to make accessible (you can't just use the title attribute because keyboard focus doesn't trigger them) and a truly accessible implementation will pretty much add the repetition back in for screen reader users. I see that we are using react-tooltip in the user's profile activity map. I checked out that repo and their demo and I'm not confident it is fully accessible (but will do more testing). I'm not saying "don't" use a tooltip here, I'm just warning that it may not be as simple as it seems to implement correctly.
Another option might be to create a separate page that has all of this type of information on it (keyboard shortcuts, other accessibility enhancements, known accessibility issues and possible workarounds, etc...).

I decided to exact the LowerJaw logic and make it its own component.
The lower jaw looks objectively better on all states. Once the following issues are resolved, this pr should be ready to go.

[ ] - Translations should be added for buttons and texts
[ ] - Lower jaw should not flash on every test and every editor pane resize.
[ ] - The Gap between the editor lines does not update to account for lowerjaw size changes.
[ ] - The gap between the editor lines collapses when resetting the editor.
[ ] - When challenge is completed, submit button should become focused and test button's aria-hidden should be set to true after 500 milliseconds( we could double check with bbsmooth if setTimeout is still needed.

double check with bbsmooth if setTimeout is still needed

The timeout was added to ensure that screen readers announce the congrats message before the submit button and I think this would still be needed. The other important thing here is that the focus must be placed on the submit button before the check your code button is hidden, otherwise focus will be temporarily lost and screen readers may add in extra unnecessary announcements. Basically, timing is everything here.

One small thought - how many clicks do we want it to take to get the Ask for Help button? Right now it seems kind of high to me?

It's tied to the number of tests the step has. The thought process being that a camper should be able to complete the step test by test.

Do we want to set a min number of attempts before the prompt shows up, like 2 or 3?

Do we want to set a min number of attempts before the prompt shows up, like 2 or 3?

Certainly yes, but we should push this out the door, discuss the number of ideal steps, and implement the feature.

I've tested this new lower jaw component with several screen readers and we'll need to make some adjustments. The #test-feedback div that wraps the test results/hint is acting as an aria live region which will cause screen readers to automatically announce the content in that div. The first time the user checks their code, that div is empty and so whatever is put in there will be announced. It's the subsequent checks that currently have an issue since there is already content in the div.
By default, screen readers will only announce the content that has changed in an aria live region, so if the hint remains the same then it won't get announced each time the user checks their code. At first I thought that adding aria-atomic="true" to the div would solve this issue since it will tell the screen reader to read all content in the live region, even if only a part of it has changed. And it does have this effect, only too well. Because there are multiple renders of this div each time the check code button is clicked then NVDA will announce the content in the div for each of those renders, thus announcing the same thing over and over multiple times. So I don't think we should use aria-atomic here and approach this from a different angle.
My suggestion would be that each time the user clicks the code check button we wipe away whatever is in the #test-feedback div and replace it with some visually hidden text like "Running tests". My testing shows that we need to ensure it stays there for just a bit to make sure screen readers see the change (as low as 100 ms seems to work fine for me). Then after the delay we can put the results/hint back in the div as usual and screen readers should announce the entire div again, even if it is exactly the same as the previous code check.

It would be great if we could lock the desired a11y behaviour down with Cypress tests. Even with Ahmad's improvements, the editor is a complicated beast and I don't want to silently break any of Bruce's a11y fixes later down the line.

Given that this feature is being requested almost daily on the forum, are we considering these to be blocking or can we land and continue iterating in future PRs?

My suggestion would be that each time the user clicks the code check button we wipe away whatever is in the #test-feedback div and replace it with some visually hidden text like "Running tests". My testing shows that we need to ensure it stays there for just a bit to make sure screen readers see the change (as low as 100 ms seems to work fine for me). Then after the delay we can put the results/hint back in the div as usual and screen readers should announce the entire div again, even if it is exactly the same as the previous code check.

To address the accessibility concerns and to allow the editor to pick up the height of the lower jaw and calculate the gap between the code lines correctly, here are three steps that the last commit adds after each attempt.

The lower jaw first renders the test feedback contents and aria hide them;
100ms later, the test feedback will display "Running tests" without changing the height of the test feedback div.
100ms after that, "Running tests" will be removed and test feedback contents are displayed to the screen and SRs.

let me know if that works.

@ahmadabdolsaheb This is great, NVDA/JAWS/Orca are all announcing the code check results perfectly  now!
I think my only remaining suggestion is that perhaps we change the "Test" heading to "Results" since I think that more accurately reflects the content and then screen readers will here "Running tests... Results, etc...". Regardless, this heading needs to be translated as well.

Since the users who are not using screen readers don't know about the tests, I would prefer using "Test" for now.
We could use "Test Results" or hide "Test" for screen readers and show them "Results" instead down the road.


feat: add password Item forcibly

Signed-off-by: wasabi<EMAIL_ADDRESS>

replace by: #132

demo link: http://test.rescld.cn/applications/app-built-in

add password signup-Item forcibly when enabled password
set password Item can not be deleted

@Kininaru plz review.

thanks,I will fix it.

done

@hsluoyz Why not merge it, is there a problem❓


Update http4s-blaze-client to 0.18.19

Updates

org.http4s:http4s-blaze-client
org.http4s:http4s-blaze-server
org.http4s:http4s-circe
org.http4s:http4s-dsl

from 0.18.16 to 0.18.19.
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention @scala-steward in the comments below.
Have a nice day!

Codecov Report

Merging #32 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #32   +/-   ##
=======================================
  Coverage   44.63%   44.63%
=======================================
  Files          31       31
  Lines         289      289
=======================================
  Hits          129      129
  Misses        160      160

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 634d2cb...de9b4b3. Read the comment docs.


Remote access over Tor

I wanted to set up remote access according to the instructions in the FAQ: "How to SSH over Tor?".
But I got the following error message.
And when I enter the Onion address in Tor, I got the "unable to connect" message (below).
It can't be the network, I can load all pages and I also have access to another fullnode via an onion address through Tor.
Thank you for any help.
admin@raspberrypi:~ $ bash /home/admin/config.scripts/internet.hiddenservice.sh ssh 22 22
Hidden Service for ssh
HiddenServiceDir /mnt/hdd/tor/ssh
HiddenServiceVersion 3
HiddenServicePort 22 <IP_ADDRESS>:22
Reloading Tor to activate the Hidden Service...
The Tor Hidden Service address for ssh is:
avvk4r6i55yvvfs6ag74uywjrkh555wp4r43jdr3fz7imgnbu5uxakyd.onion
use with the port: 22
admin@raspberrypi:~ $ torsocks ssh<EMAIL_ADDRESS>1640632590 ERROR torsocks[29509]: General SOCKS server failure (in socks5_recv_connect_reply() at socks5.c:527)
ssh: connect to host hiddenserviceaddress.onion port 22: Connection refused
admin@raspberrypi:~ $ sudo cat /mnt/hdd/tor/ssh/hostname
avvk4r6i55yvvfs6ag74uywjrkh555wp4r43jdr3fz7imgnbu5uxakyd.onion
admin@raspberrypi:~ $
Unable to connect
Firefox can’t establish a connection to the server at avvk4r6i55yvvfs6ag74uywjrkh555wp4r43jdr3fz7imgnbu5uxakyd.onion.
The site could be temporarily unavailable or too busy. Try again in a few moments.
If you are unable to load any pages, check your computer’s network connection.
If your computer or network is protected by a firewall or proxy, make sure that Tor Browser is permitted to access the Web.

Never share you unique hidden service for your ssh connection - so change it in this case by:
# deleting the keys;
sudo rm -rf /mnt/hdd/tor/ssh/
# reload tor
sudo systemctl reload tor@default

It is likely a local Tor issue and might resolved with a restart.

@jugi01 is this still relevant? Closing for now, if it's still relevant, please re-open


Parametrize HasRateLimitStrategy by key

Fixes https://github.com/mbg/wai-rate-limit/issues/6#issuecomment-1146368235

I think the CI failure is some flakiness unrelated to your changes. I will merge it. Thank you for opening the issue about this on Friday to let me know that this was an issue for you and thanks for making the changes here! 👍🏻


Error when changing 3 words in example workflow : Error occurred when executing KSampler:  shape '[2, -1, 640]' is invalid for input of size 3976320

Hi
Can anyone help.
The example workflow from this repo (cute girl, red hair..) works perfectly when I changed the checkpoint to Juggernaught XL.
Then when I changed ONLY the prompt to "a cute girl, 26-year old, mexican, dirty brown hair, skinny" (only a few words different), I get this error:
"Error occurred when executing KSampler:
shape '[2, -1, 640]' is invalid for input of size 3976320"
Remember - I haven't changed anything else?
I've tried less words and still the same error, but with different numbers.
Can anyone help?

Are you running in the dual role mode of txt2img? Currently, there is a bug in this mode and it does not support repeated use of pipes. If you want to use it again, you must change any parameters of the model loading node, such as the scheduler.
If there are other causes of errors, in the character prompt, there are" \n "line breaks after the punctuation (comfyUI cannot display). If the punctuation is removed when changing the character prompt, it may cause an error in the input tensor. To avoid this error, try not to remove the punctuation in the example or use the "split prompt" function


buildbot-nix access control for private repos

In some settings, we only want to show the builds to users with access to the repos.
Is it possible to map the repo access control to the authenticated users?
If not, create a "private" mode where only logged-in users can see the builds and builders.

It's possible. We already limit certain builder endpoints for projects: https://github.com/Mic92/buildbot-nix/blob/b0526ceab2ec89bed5e194a206391a7d85a833e7/buildbot_nix/init.py#L663
This can be also extended to limit logs visible of project itself.

Could it also be extended to the builder activity?

Ill look into it tomorrow, should be done with a prototype by the evening

Very briefly looking into this, I instrumented buildbots authentication with the following code:
    any_endpoint_matcher = util.AnyEndpointMatcher(role="admin", defaultDeny=False)
    old_match = any_endpoint_matcher.match

    def match(self: util.AnyEndpointMatcher, ep: Any, action: Any, options: Any) -> Any:
        import inspect

        if options is None:
            options = {}
        try:
            epobject, epdict = self.master.data.getEndpoint(ep)
            for klass in inspect.getmro(epobject.__class__):
                log.info(
                    "matching on {klass} with action: {action}",
                    klass=klass.__name__,
                    action=action,
                )
        except:
            pass
        old_match(ep, action, options)

    import types

    any_endpoint_matcher.match = types.MethodType(match, any_endpoint_matcher)

    allow_rules.append(any_endpoint_matcher)

Which then prints me a list of endpoints that buildbot is looking for auth for, said list reveals:

ProjectsEndpoint
ProjectEndpoint

ProjectsEndpoint comes into play on the /#/projects URL. Interestingly at /#/projects/3 where I would expect ProjectEndpoint to show up, (also according to the patterns it matches) it doesn't actually show up. The endpoints that do show up are: [ProjectsEndpoint, MasterEndpoint, WorkersEndpoint, BuildRequestsEndpoint, BuildersEndpoint, ChangesEndpoint, BuildsEndpoint] but that doesn't help us much as far as I can tell. ProjectEndpoint only appears at #/builders/19 which makes no sense to me. But I'm probably misunderstanding something.
All of this testing has been done on the github_app branch as I didn't really want to change my nix config from developing that :) and while not logged into buildbot at all. But assuming that the correct endpoints would show up, we have a problem anyway as ProjectsEndpoint does not do any filtering whatsoever and does not allow for it. It directly calls up the DB right here, that function if followed directly executes the equivalent of select * from projects; with no room for any filtering either. So this either calls for upstream changes or a mixin. Not sure what's the correct path forward here and I would appreciate some input as to what to do here. (this little foray into buildbots endpoint handling also tells me that custom UI is possible with mixins and custom endpoints probably :tada:)

But also this only comes into play if we want to limit access to projects, for builds its quite simple, namely BuildsEndpoint

Ok. I suspected something like this since Buildbot was designed for open-source use.
Since this requires a major refactor, a better short-term solution is to shield the installation. Users can decide to make their instance private, and then only logged-in users can see build information. Webhooks need to be sent through still.

I'm pushing this to the future milestone then

Is this addressed by https://github.com/nix-community/buildbot-nix/pull/251

Noy really, what #251 gets us is a all or nothing support for access control. Ideally one wouldn't have to run 2 instances for public and provate repositories.


Highlights

Is it possible to set highlights for insert/select floating windows borders and text messages?

You can customize the window border highlights by setting FloatBorder (by default it links to VertSplit, see :help nvim_open_win). I just made a commit that adds the FloatTitle highlight group that will highlight the window title for the input and the built-in select windows. By default it links to FloatBorder. There's another commit that highlights the text in the built-in vim.ui.select window with DressingSelectText, which links to Normal by default. Does that cover everything you wanted?

Yeap. Now I can dress in to match my colorscheme. Thank you =)

What about the input text area?

Added a DressingInputText highlight group as well. Note that if the caller of vim.ui.input supplies a highlight function in the opts we will use that instead.

It seems that the highlight group doesn't affect the background.

Any way to make the gray area disappear?

I believe that the background of windows is typically set via winhighlight (e.g. set winhighlight=Normal:MyNewGroup). You can already do this with a FileType autocmd, but I'll expose a config option as well.

Thx.


nixpkgs / steam / steam-run can't run 32-bit game

I run
NIXPKGS_ALLOW_UNFREE=1 nix-shell -p steam-run --impure
and then run
steam-run ./hl2.sh
It wrote
SDL video target is 'x11'
Failed to create GL context: Could not create GL context

What do I need to do to solve this problem?
When I run another 32-bit game `steam-run ./lc.sh' it wrote
libGL error: MESA-LOADER: failed to open radeonsi: /home/max/max_arch/Prospekt/steam-runtime/i386/lib/i386-linux-gnu/libgcc_s.so.1: version `GCC_7.0.0' not found (required by /run/opengl-driver-32/lib/dri/radeonsi_dri.so) (search paths /run/opengl-driver-32/lib/dri, suffix _dri)
libGL error: failed to load driver: radeonsi
libGL error: MESA-LOADER: failed to open swrast: /home/max/max_arch/Prospekt/steam-runtime/i386/lib/i386-linux-gnu/libgcc_s.so.1: version `GCC_7.0.0' not found (required by /run/opengl-driver-32/lib/dri/swrast_dri.so) (search paths /run/opengl-driver-32/lib/dri, suffix _dri)
libGL error: failed to load driver: swrast
X Error of failed request:  BadValue (integer parameter out of range for operation)
  Major opcode of failed request:  149 (GLX)
  Minor opcode of failed request:  3 (X_GLXCreateContext)
  Value in failed request:  0x0
  Serial number of failed request:  100
  Current serial number in output stream:  101
/home/max/max_arch/Prospekt/lc.sh: строка 50: 25826 Segmentation fault      (стек памяти сброшен на диск) ${GAME_DEBUGGER} "${GAMEROOT}"/${GAMEEXE} "$@"

You should install steam by adding programs.steam.enable=true; as that option enable also 32-bits OpenGL libraries

It doesn't work at all for me. I tried to run it with Steam as "non-steam game" but nothing changed. The game writes
SDL video target is 'x11'
SDL video target is 'x11'
Failed to create SDL window: Couldn't find matching GLX visual

I think I didn't give you enough information.
This is the game that I try to run: https://drive.google.com/file/d/1E5pxf_8UxrHNbJHP6yPlJ6DhKhggjAnh/view?usp=sharing
This is my pc configuration: https://drive.google.com/file/d/1qused7qt35_CfEKdf4sDGL4TOTQgLH0y/view?usp=sharing
This it my nixos configuration: https://drive.google.com/file/d/1HeW7mz1hvIr5mhjPZNoYCh2QO3XCdZz-/view?usp=sharing

I have an issue with running the original Half-Life that seems related.
Using either the native build or the Proton one fails with a "Failed to create SDL Window" popup.
I have already enabled 32-bit OpenGL libraries in my configuration.

I can't run move or die too and I have enabled 32 bits opengl


Provide a sample url value for TokenEndPointAlias parameter in JWT client authentication

Suggested Labels
Type/Docs
Priority/High
Affected/5.5.0-Alpha3
Description
Refer to document link [1]. In step 4 under Deploying and configuring JWT client-handler artifacts please provide a example for sample url value in TokenEndPointAlias parameter.
[1]. https://docs.wso2.com/display/IS550/Private+Key+JWT+Client+Authentication+for+OIDC

Thank you for your contribution!
We are closing this issue since it has not been prioritized for a long time. Chances are that it has already been solved in more recent versions. If not, we will be re-evaluating this when it becomes a priority.


explore.ipld.io unavailable - wrong certificate domain

https://explore.ipld.io is currently unavailable as it's using a wildcard SSL cert for *.ipfs.io but this is an ipld.io subdomain.

fixed by super @VictorBjelkholm


Tests do not pass

Repro:
Mac M1, fresh from main
Execute:
make test

Result:
===========================

[2207] INF bacalhau/submit.go:147 > Submitted Job Id: 06b7779c-87fe-4c0c-b4a0-6e399f92e58e

[2207] INF internal/compute_node.go:138 > CID ([{ipfs QmRyDNzrxwcL4ENNGyKLr9bf1FAs2unLKyngCb5tqaUpsX}]) found on this server. Accepting job.
[2207] INF internal/compute_node.go:192 > Results directory for job id (06b7779c-87fe-4c0c-b4a0-6e399f92e58e) exists: /Users/daaronch/.bacalhau/results/06b7779c/QmRhnE4qG72UGxXV9TLQ5g1vDRwbS3ZaHd7YjhaDPedsGx
[2207] ERR internal/compute_node.go:95 > ERROR running the job: Error connecting host ipfs into container:
        Error: exit status 1
        Output: Error: connect 12D3KooWDTMfZuHVaYRGRbHmgS6AMeoDKWCiMDDekcBBPSVbWuBx failure: failed to dial 12D3KooWDTMfZuHVaYRGRbHmgS6AMeoDKWCiMDDekcBBPSVbWuBx:
  * [/ip4/<IP_ADDRESS>/tcp/4001] dial tcp4 <IP_ADDRESS>:4001: connect: connection refused

&{Id:06b7779c-87fe-4c0c-b4a0-6e399f92e58e Owner:QmRhnE4qG72UGxXV9TLQ5g1vDRwbS3ZaHd7YjhaDPedsGx Spec:0x1400299b7a0 Deal:0x1400306b2c0 State:map[QmRhnE4qG72UGxXV9TLQ5g1vDRwbS3ZaHd7YjhaDPedsGx:0x14000a528c0]}

    devstack_test.go:233:
                Error Trace:    devstack_test.go:233
                Error:          Received unexpected error:
                                open /Users/daaronch/.bacalhau/results/06b7779c/QmRhnE4qG72UGxXV9TLQ5g1vDRwbS3ZaHd7YjhaDPedsGx/stdout.log: no such file or directory
                Test:           TestCommands/grep
    devstack_test.go:235:
                Error Trace:    devstack_test.go:235
                Error:          Should be true
                Test:           TestCommands/grep
    devstack_test.go:237:
                Error Trace:    devstack_test.go:237
                Error:          Not equal:
                                expected: 1
                                actual  : 4
                Test:           TestCommands/grep
                Messages:       Count mismatch:
                                Expected: 4
                                Actual: 1

Arm is not yet a supported ISA. Do the tests fail on x86_64?

the issue is not ARM - it's in this line.
https://github.com/filecoin-project/bacalhau/blob/main/internal/runtime/runtime.go#L264
The Docker client on Macs returns <IP_ADDRESS> which is not routable (i think)? No idea lol

FYI, checked in, and reproable (on a mac anyway - not on linux, sigh).
Could this line in the logs be the problem?
[2207] DBG internal/dev_stack.go:68 > bacalhau multiaddress: /ip4/<IP_ADDRESS>/tcp/52646/p2p/QmapnLpuzvSozX1n6veb3hWNej6tnWfBTztBgdC7PjACb8

FYI, with @binocarlos's check in - still failing - same problem. The docker client is reporting the wrong IP (or is not routable in some other way).
?       github.com/filecoin-project/bacalhau    [no test files]
=== RUN   TestDevStack
[2207] INF bacalhau/submit.go:147 > Submitted Job Id: 94d937c7-8250-4b93-814f-8c593ab9211c

[2207] INF internal/compute_node.go:138 > CID ([{ipfs QmZtGx2sS6XC7BNkhoCW7TV4k7QikS743q3BkuH7krEvfK}]) found on this server. Accepting job.
[2207] WRN internal/compute_node.go:170 > Could not execute job - execution engine is 'docker' and the Docker daemon does not appear to be running.
[2207] ERR internal/compute_node.go:95 > ERROR running the job: Could not execute job - execution engine is 'docker' and the Docker daemon does not appear to be running.
&{Id:94d937c7-8250-4b93-814f-8c593ab9211c Owner:QmRierpqixXKqHQpNydpAcTpUPaZ3WNQQq6tvnh2U28Azi Spec:0x140002edab0 Deal:0x140021d8de0 State:map[QmRierpqixXKqHQpNydpAcTpUPaZ3WNQQq6tvnh2U28Azi:0x140015b2c40]}

    devstack_test.go:187:
                Error Trace:    devstack_test.go:187
                Error:          Received unexpected error:
                                open /Users/daaronch/.bacalhau/results/94d937c7/QmRierpqixXKqHQpNydpAcTpUPaZ3WNQQq6tvnh2U28Azi/stdout.log: no such file or directory
                Test:           TestDevStack
    devstack_test.go:189:
                Error Trace:    devstack_test.go:189
                Error:          Should be true
                Test:           TestDevStack
--- FAIL: TestDevStack (108.94s)
=== RUN   TestCommands
=== RUN   TestCommands/grep
[2207] INF bacalhau/devstack_test.go:225 >
========================================
Starting new job:
  name: grep
   cmd: timeout 2000 grep kiwi /ipfs/%s || echo "ipfs read timed out"
  file: ../../testdata/grep_file.txt
========================================

[2207] INF bacalhau/submit.go:147 > Submitted Job Id: f34a353f-7451-4de0-a020-80f843ac4745

[2207] INF internal/compute_node.go:138 > CID ([{ipfs QmTPyNQvmtvngy2VPA81QN8ceEWig6AcD7F2UF8BFdy4nK}]) found on this server. Accepting job.
[2207] INF internal/compute_node.go:192 > Results directory for job id (f34a353f-7451-4de0-a020-80f843ac4745) exists: /Users/daaronch/.bacalhau/results/f34a353f/QmcoqSJHEunG1MSWLmCo9Tby4KSt4uaVcwaTfX5DD7zkTD
[2207] ERR internal/compute_node.go:95 > ERROR running the job: Error connecting host ipfs into container:
        Error: exit status 1
        Output: Error: connect 12D3KooWMWY9Rcx8x4pfXCADQQSbjsrgAwvnonNxG8u7N3NRje3t failure: failed to dial 12D3KooWMWY9Rcx8x4pfXCADQQSbjsrgAwvnonNxG8u7N3NRje3t:
  * [/ip4/<IP_ADDRESS>/tcp/4001] dial tcp4 <IP_ADDRESS>:4001: connect: connection refused

&{Id:f34a353f-7451-4de0-a020-80f843ac4745 Owner:QmcoqSJHEunG1MSWLmCo9Tby4KSt4uaVcwaTfX5DD7zkTD Spec:0x14002f83260 Deal:0x140032f8e40 State:map[QmcoqSJHEunG1MSWLmCo9Tby4KSt4uaVcwaTfX5DD7zkTD:0x14001ab6780]}

    devstack_test.go:247:
                Error Trace:    devstack_test.go:247
                Error:          Received unexpected error:
                                open /Users/daaronch/.bacalhau/results/f34a353f/QmcoqSJHEunG1MSWLmCo9Tby4KSt4uaVcwaTfX5DD7zkTD/stdout.log: no such file or directory
                Test:           TestCommands/grep
    devstack_test.go:249:
                Error Trace:    devstack_test.go:249
                Error:          Should be true
                Test:           TestCommands/grep
    devstack_test.go:252:
                Error Trace:    devstack_test.go:252
                Error:          Not equal:
                                expected: 4
                                actual  : 1
                Test:           TestCommands/grep
                Messages:       Count mismatch:
                                Expected: 4
                                Actual: 1
=== RUN   TestCommands/sed
[2207] INF bacalhau/devstack_test.go:225 >
========================================
Starting new job:
  name: sed
   cmd: sed -n '/38.7[2-4]..,-9.1[3-7]../p' /ipfs/%s
  file: ../../testdata/sed_file.txt
========================================

[2207] INF bacalhau/submit.go:147 > Submitted Job Id: 88eac1ee-1228-4969-98a2-0a4360cf91a9

[2207] INF internal/compute_node.go:138 > CID ([{ipfs QmfNxptvVcr9R5X3KqxENWieFzRCKvncezkhf2WddMqhiG}]) found on this server. Accepting job.
[2207] INF internal/compute_node.go:192 > Results directory for job id (88eac1ee-1228-4969-98a2-0a4360cf91a9) exists: /Users/daaronch/.bacalhau/results/88eac1ee/QmcoqSJHEunG1MSWLmCo9Tby4KSt4uaVcwaTfX5DD7zkTD
[2207] ERR internal/compute_node.go:95 > ERROR running the job: Error connecting host ipfs into container:
        Error: exit status 1
        Output: Error: connect 12D3KooWG4esT74Fk9Pjnxpi17jDfobUTtvve5uXP3QPJ9rD6UoX failure: failed to dial 12D3KooWG4esT74Fk9Pjnxpi17jDfobUTtvve5uXP3QPJ9rD6UoX:
  * [/ip4/<IP_ADDRESS>/tcp/4001] dial tcp4 <IP_ADDRESS>:4001: connect: connection refused

&{Id:88eac1ee-1228-4969-98a2-0a4360cf91a9 Owner:QmcoqSJHEunG1MSWLmCo9Tby4KSt4uaVcwaTfX5DD7zkTD Spec:0x140044ca1c0 Deal:0x14002fa1470 State:map[QmcoqSJHEunG1MSWLmCo9Tby4KSt4uaVcwaTfX5DD7zkTD:0x14004242ac0]}

    devstack_test.go:247:
                Error Trace:    devstack_test.go:247
                Error:          Received unexpected error:
                                open /Users/daaronch/.bacalhau/results/88eac1ee/QmcoqSJHEunG1MSWLmCo9Tby4KSt4uaVcwaTfX5DD7zkTD/stdout.log: no such file or directory
                Test:           TestCommands/sed
    devstack_test.go:249:
                Error Trace:    devstack_test.go:249
                Error:          Should be true
                Test:           TestCommands/sed
    devstack_test.go:252:
                Error Trace:    devstack_test.go:252
                Error:          Not equal:
                                expected: 7
                                actual  : 1
                Test:           TestCommands/sed
                Messages:       Count mismatch:
                                Expected: 7
                                Actual: 1
=== RUN   TestCommands/awk
[2207] INF bacalhau/devstack_test.go:225 >
========================================
Starting new job:
  name: awk
   cmd: awk -F',' '{x=38.7077507-$3; y=-9.1365919-$4; if(x^2+y^2<0.3^2) print}' /ipfs/%s
  file: ../../testdata/awk_file.txt
========================================

[2207] INF bacalhau/submit.go:147 > Submitted Job Id: e32d9921-c352-49b8-9d6a-faf2b5edb3fa

[2207] INF internal/compute_node.go:138 > CID ([{ipfs QmfNxptvVcr9R5X3KqxENWieFzRCKvncezkhf2WddMqhiG}]) found on this server. Accepting job.
[2207] INF internal/compute_node.go:192 > Results directory for job id (e32d9921-c352-49b8-9d6a-faf2b5edb3fa) exists: /Users/daaronch/.bacalhau/results/e32d9921/QmcoqSJHEunG1MSWLmCo9Tby4KSt4uaVcwaTfX5DD7zkTD
[2207] ERR internal/compute_node.go:95 > ERROR running the job: Error connecting host ipfs into container:
        Error: exit status 1
        Output: Error: connect 12D3KooWAJbtr9aQxvVzUm1yDrFAeQekBKwgMNF3iuSBSdoWGbZc failure: failed to dial 12D3KooWAJbtr9aQxvVzUm1yDrFAeQekBKwgMNF3iuSBSdoWGbZc:
  * [/ip4/<IP_ADDRESS>/tcp/4001] dial tcp4 <IP_ADDRESS>:4001: connect: connection refused

&{Id:e32d9921-c352-49b8-9d6a-faf2b5edb3fa Owner:QmcoqSJHEunG1MSWLmCo9Tby4KSt4uaVcwaTfX5DD7zkTD Spec:0x1400332dc00 Deal:0x1400396c960 State:map[QmcoqSJHEunG1MSWLmCo9Tby4KSt4uaVcwaTfX5DD7zkTD:0x14004243c80]}

    devstack_test.go:247:
                Error Trace:    devstack_test.go:247
                Error:          Received unexpected error:
                                open /Users/daaronch/.bacalhau/results/e32d9921/QmcoqSJHEunG1MSWLmCo9Tby4KSt4uaVcwaTfX5DD7zkTD/stdout.log: no such file or directory
                Test:           TestCommands/awk
    devstack_test.go:249:
                Error Trace:    devstack_test.go:249
                Error:          Should be true
                Test:           TestCommands/awk
    devstack_test.go:252:
                Error Trace:    devstack_test.go:252
                Error:          Not equal:
                                expected: 503
                                actual  : 1
                Test:           TestCommands/awk
                Messages:       Count mismatch:
                                Expected: 503
                                Actual: 1
--- FAIL: TestCommands (330.68s)
    --- FAIL: TestCommands/grep (101.69s)
    --- FAIL: TestCommands/sed (101.73s)
    --- FAIL: TestCommands/awk (101.52s)
=== RUN   TestCatchBadActors
    devstack_test.go:363:
--- SKIP: TestCatchBadActors (0.00s)
=== RUN   TestRootSuite
=== RUN   TestRootSuite/Test_RootHelloWorld
    logger.go:130: 2022-04-01T14:31:02.246-0700 DEBUG   Command to execute: bacalhau
--- PASS: TestRootSuite (0.01s)
    --- PASS: TestRootSuite/Test_RootHelloWorld (0.00s)
=== RUN   TestSubmitSyntaxErrors
=== RUN   TestSubmitSyntaxErrors/good_bash
=== RUN   TestSubmitSyntaxErrors/missing_quote
=== RUN   TestSubmitSyntaxErrors/unescaped_find
--- PASS: TestSubmitSyntaxErrors (0.00s)
    --- PASS: TestSubmitSyntaxErrors/good_bash (0.00s)
    --- PASS: TestSubmitSyntaxErrors/missing_quote (0.00s)
    --- PASS: TestSubmitSyntaxErrors/unescaped_find (0.00s)
FAIL
FAIL    github.com/filecoin-project/bacalhau/cmd/bacalhau       439.889s
?       github.com/filecoin-project/bacalhau/experimental       [no test files]
?       github.com/filecoin-project/bacalhau/internal   [no test files]
=== RUN   TestIpfsUtilsTestSuite
=== RUN   TestIpfsUtilsTestSuite/Test_IpfsNotSnap
    utils_test.go:40: ipfs not installed with snap, skipping test
=== RUN   TestIpfsUtilsTestSuite/Test_NoDocker
    utils_test.go:57: docker is installed, cannot test abscence
--- PASS: TestIpfsUtilsTestSuite (0.00s)
    --- SKIP: TestIpfsUtilsTestSuite/Test_IpfsNotSnap (0.00s)
    --- SKIP: TestIpfsUtilsTestSuite/Test_NoDocker (0.00s)
PASS
ok      github.com/filecoin-project/bacalhau/internal/ipfs      (cached)
=== RUN   TestColorFormatting
--- PASS: TestColorFormatting (0.00s)
PASS
ok      github.com/filecoin-project/bacalhau/internal/logger    (cached)
?       github.com/filecoin-project/bacalhau/internal/runtime   [no test files]
?       github.com/filecoin-project/bacalhau/internal/scheduler [no test files]
?       github.com/filecoin-project/bacalhau/internal/scheduler/libp2p  [no test files]
?       github.com/filecoin-project/bacalhau/internal/system    [no test files]
?       github.com/filecoin-project/bacalhau/internal/test      [no test files]
=== RUN   TestFixtureMetrics
--- PASS: TestFixtureMetrics (0.01s)
PASS
ok      github.com/filecoin-project/bacalhau/internal/traces    (cached)
?       github.com/filecoin-project/bacalhau/internal/types     [no test files]
FAIL
make: *** [test] Error 1

FYI - FAIRLY certain this is the issue - https://stackoverflow.com/questions/52555007/docker-mac-alternative-to-net-host
TLDR, you can't host network with Docker on a mac. Should we inject a network (when running on a mac only? or maybe everywhere?)

@DhashS suggested this - https://github.com/elghazal-a/autowire - which looks awesome

Since u mentioned me,
bunch of dumb suggestions

weave + ip link via
WireGuard and vpn (not really with autowire since it requires a consul cluster, more like https://www.eisfunke.com/article/docker-wireguard-systemd.html where there’s a WireGuard interface + docker IPAM bound to that interface
—net=host

Hope this helps!

@binocarlos think this is dead, right?


opensta failing on user_project_example

Following the readme for user_project_example does not appear to work in the current 4cb1d55 commit. In particular I ran
mkdir dependencies
export OPENLANE_ROOT=$(pwd)/dependencies/openlane_src
export PDK_ROOT=$(pwd)/dependencies/pdks
export PDK=sky130A
make setup
make user_proj_example
make user_project_wrapper
make extract-parasitics
make create-spef-mapping
make caravel-sta

and achieved the error
Error: timing_top.tcl line 47, path instance 'chip_core/mprj/mprj' not found.
make[1]: *** [/home/perl/efabless/caravel_user_project/dependencies/timing-scripts/timing.mk:244: caravel-timing-typ-max] Error 1
make[1]: *** Waiting for unfinished jobs....
make[1]: *** [/home/perl/efabless/caravel_user_project/dependencies/timing-scripts/timing.mk:244: caravel-timing-typ-min] Error 1
make[1]: *** [/home/perl/efabless/caravel_user_project/dependencies/timing-scripts/timing.mk:244: caravel-timing-typ-nom] Error 1
make[1]: Leaving directory '/home/perl/efabless/caravel_user_project/dependencies/timing-scripts'
make: *** [Makefile:334: caravel-sta] Error 2

which seems to me to suggest that it caravel-sta is looking inside the user_proj_example mprj instance for another user_proj_example mprj instance.
caravel-sta_out.txt
My environment is as follows
OS: Ubuntu 22.04 jammy
Kernel: x86_64 Linux 5.19.0-38-generic
CPU: 12th Gen Intel Core i7-12700 @ 20x 4.8GHz
RAM: 96286MiB

I experienced the same error when trying to nun caravel-sta on my own design as well. I apologize if I did something incorrectly on my end.

@champfish This should be fixed now.


refactor(charts): move registry secret from renku repo

Note that this change allows non-root admin tokens to be used. This should make it easier to rotate them periodically.
gitlab:
  registry:
    username: a_user
    token: 12345

closes #167

I tested this on my dev environment using my own token and launching a project from one of my private repos - seems to work as intended.


Add Polish localization - Tutorials hello-minikube

This is a part of the initial Polish localization - see: https://github.com/kubernetes/website/pull/18419

/milestone 1.17-pl.1

/hold
pending approval & merge for #18419. Once that merges, it's OK to /unhold
People can /lgtm (for localization review) and /approve, even whilst this is held.

@mfilocha I've noticed one big chunk of the text is left as-is, especially section about ## CI/CD Pipeline - I believe we should discuss this on slack?

Thanks @mfilocha & @nvtkaszpir
/approve

Approved based on @sftim being an sig-docs approver (however, the dev-1.17-pl.1 branch is a bit behind master)

/hold cancel

/lgtm


Recipe removal with crafttweaker not working?

I was trying to use the follow script to tweak the recipe a bit
mods.nuclearcraft.chemical_reactor.removeRecipeWithOutput(<liquid:ammonia>, <liquid:ammonia>); mods.nuclearcraft.chemical_reactor.removeRecipeWithOutput(<liquid:sulfuric_acid>, <liquid:sulfuric_acid>); mods.nuclearcraft.chemical_reactor.removeRecipeWithOutput(<liquid:oxygen_difluoride>, <liquid:oxygen_difluoride>); mods.nuclearcraft.chemical_reactor.removeRecipeWithOutput(<liquid:sulfur_trioxide>, <liquid:fluorine>); mods.nuclearcraft.chemical_reactor.removeRecipeWithOutput(<liquid:hydrofluoric_acid>, <liquid:fluorine>); mods.nuclearcraft.chemical_reactor.removeRecipeWithOutput(<liquid:oxygen>, <liquid:hydrofluoric_acid>); mods.nuclearcraft.chemical_reactor.removeRecipeWithOutput(<liquid:potassium_hydroxide_solution>, <liquid:hydrofluoric_acid>); mods.nuclearcraft.chemical_reactor.removeRecipeWithOutput(<liquid:sodium_hydroxide_solution>, <liquid:hydrofluoric_acid>); mods.nuclearcraft.chemical_reactor.removeRecipeWithOutput(<liquid:hydrofluoric_acid>, <liquid:calcium_sulfate_solution>);
However in ct log it shows that it has errored
[INITIALIZATION][CLIENT][INFO] Error: Failed to remove nuclearcraft_chemical_reactor recipe with [1 x fluid:ammonia, 1 x fluid:ammonia] as the output [INITIALIZATION][CLIENT][ERROR] Some NuclearCraft CraftTweaker recipe removal methods have errored - check the CraftTweaker log for more details [INITIALIZATION][CLIENT][INFO] Error: Failed to remove nuclearcraft_chemical_reactor recipe with [1 x fluid:sulfuric_acid, 1 x fluid:sulfuric_acid] as the output [INITIALIZATION][CLIENT][INFO] Error: Failed to remove nuclearcraft_chemical_reactor recipe with [1 x fluid:oxygen_difluoride, 1 x fluid:oxygen_difluoride] as the output [INITIALIZATION][CLIENT][INFO] Error: Failed to remove nuclearcraft_chemical_reactor recipe with [1 x fluid:sulfur_trioxide, 1 x fluid:fluorine] as the output [INITIALIZATION][CLIENT][INFO] Error: Failed to remove nuclearcraft_chemical_reactor recipe with [1 x fluid:hydrofluoric_acid, 1 x fluid:fluorine] as the output [INITIALIZATION][CLIENT][INFO] Error: Failed to remove nuclearcraft_chemical_reactor recipe with [1 x fluid:oxygen, 1 x fluid:hydrofluoric_acid] as the output [INITIALIZATION][CLIENT][INFO] Error: Failed to remove nuclearcraft_chemical_reactor recipe with [1 x fluid:potassium_hydroxide_solution, 1 x fluid:hydrofluoric_acid] as the output [INITIALIZATION][CLIENT][INFO] Error: Failed to remove nuclearcraft_chemical_reactor recipe with [1 x fluid:sodium_hydroxide_solution, 1 x fluid:hydrofluoric_acid] as the output [INITIALIZATION][CLIENT][INFO] Error: Failed to remove nuclearcraft_chemical_reactor recipe with [1 x fluid:hydrofluoric_acid, 1 x fluid:calcium_sulfate_solution] as the output [INITIALIZATION][CLIENT][INFO] Error: Failed to remove nuclearcraft_electrolyser recipe with [1 x fluid:koh] as the input [INITIALIZATION][CLIENT][INFO] Error: Failed to remove nuclearcraft_dissolver recipe with [1 x fluid:fluorite_water] as the output

Ok seems that I need to add the amount of fluid then, this can be a bit confusing...

Looks like I need to fix the logging, but yeh, fluid stacks are like item stacks and need the size of the stack also... perhaps I could add a boolean to not check stack sizes.


Tailwind cleanup

From Slack...
https://tailwindcss.com/docs/controlling-file-size seems to be the ticket

We should also:

opt into breaking changes early (I can handle this since it'll require checking on compatibility, but I think we should be okay)
break the CSS file into smaller chunks (I can handle the breaking it into logical chunks, but I had troubles getting the build system to actually import them)

I can probably get a PR started here, but I may need some help making everything work properly—build systems are not my area of strength!

I can probably provide builds support 😄

This issue isn't quite so pressing now - I have enabled compression in Apache, and the CSS is now down to 140KB, rather than 1.4MB.


Cooking UI not working properly

Description of the bug
The area where the UI is clickable is moved to the left from where it is displayed, causing the cook button to be unclickable normally, and having to mauver blindly to find where the clickable are actually is.
Expected behaviour
The area registered as the are of the UI should be in the same place as what is drawn to screen.
How to reproduce

Place the Crockpot tile
Open its UI
Try clicking the cook button
Go to the left from the top left corner until you see the "HOVERING!" text
Move around until the button is lighter
Click -> Message in chat appears "Cookerd"

Possible solutions
No answer

Solution provided by Direwolf here (TModLoader Discord server)

make it InterfaceScaleType.UI, then
position = Vector2.Transform(position - Main.screenPosition, Main.GameViewMatrix.ZoomMatrix) / Main.UIScale;where position is a world position of the tile for example
that requires manually drawing the entire UI though, I'm not sure how to do that with the UIElements


Scala3 -language compiler option issues

First discussed on Scala Contributors
Compiler version
All Scala3 versions v3.0.0 through v3.4.1
Minimized code
The -language compiler option does not behave as expected:

-language:help does not provide available choices:
% scala-cli compile -S 3.4.1 -O -language:help -- empty.scala

(no available choices returned)

-language with an incorrect choice does not fail compilation:
% scala-cli compile -S 3.4.1 -O -language:WRONG -- empty.scala

(no errors reported, the file compiles successfully)

Expectation
The behavior should look similar to Scala2 compilers, e.g.:
% scala-cli compile -S 2.13.13 -O -language:help -- empty.scala
Enable or disable language features
  dynamics             Allow direct or indirect subclasses of scala.Dynamic
  existentials         Existential types (besides wildcard types) can be written and inferred
  higherKinds          Allow higher-kinded types
  implicitConversions  Allow definition of implicit functions called views
  postfixOps           Allow postfix operator notation, such as `1 to 10 toList` (not recommended)
  reflectiveCalls      Allow reflective access to members of structural types
  experimental.macros  Allow macro definition (besides implementation and application)

% scala-cli compile -S 2.13.13 -O -language:WRONG -- empty.scala
scalac error: 'WRONG' is not a valid choice for '-language'
  scalac -help  gives more information
Compilation failed

Especially as there is no -language:all equivalent to -language:_, which is what you reach for when doing a quick test and can't be bothered with spelling it out. There is no indicator at all.
No doubt, when the dust settles around other important features and people begin to miss -language:_, there will be a general mutiny.
An alternative would be a -language:test environment that relaxes all sorts of restrictions but just for testing. I can't think of one, but could imagine "empty package" available only under this test regime, or empty packages from arbitrary sources (directories or binary artifacts).


Modify VRG processing as primary

To handle the following,

Prepare PVC by protecting it with a finalizer
Ensure PVC has the Retain reclaim policy
Update protection finazlier for PVC once protected

Signed-off-by: Shyamsundar Ranganathan<EMAIL_ADDRESS>

Removed WIP, as we are addressing unit tests separately.

@BenamarMk @raghavendrabhat @vdeenadh I am closing this one, all comments here are addressed or approariately carried over to the PR #43


Performance test could be another record in the MBDB

Many times, the performance test will be just another record in the MDBD, that option should be given in the interface by giving the recordID of the performance test

Good point, we will consider how to implement it best.

In order to simplify the schema performance test was removed, hence this well no longer be possible to use. This will take effect in schema version 0.9.17


cool mods for openhack you should add

here are some:

autoclicker
show hitboxes
jump hack
layout mode (shows the layout of the level)
suicide
start mode (what mode can you start with e.g: i want to start the level with ufo mode)
close geometry dash
go to the menu screen
re-launch the game (can work in case somethings bugged)
RGB icons

hope you add them, happy dashing

It would actually be so nice if this came true,
loving the concept!

what about a shortcut to the gd appdata folder

what about a shortcut to the gd appdata folder

it already exists

how do i get it

That actually sounds good and I don't think it'll be that hard

how do i get it

You find appdata button

jump hack and autoclicker are the ones im looking forward too tho the jump hack would be SUPER EAZY and GREAT

what about a shortcut to the gd appdata folder

it already exists

i think at the time of writing that i hadn't updated it seems
also i don't think i was notified abt you saying this

k


Package version is set '0'

The package version metadata for those release that exist (2.0 is missing a package, #55) is set to '0.' This not only confuse tools that rely on that metadata, such as autopkg or Installomator, but might confuse the macOS installation system, which might decide that since the package version has not changed, it doesn't need to re-install the package and change no files on the system.
You should set the package version with pkgbuild's --version option to the release version.

This was addressed in 2.2.1.


Rasterio Development

Had to remake this branch from scratch. Be careful with push -f.
At least we now have git-lfs enabled.
Checklist:

[ ] select the internal representation of a contour (ie shapely polygon)
[ ] io function converting shapefiles and WFS, WKT into internal representation.
[ ] select an internal representation for the DEM/land use arrays
[ ] io function reading DEM/land use and returning internal representation.
[x] function that takes the internal representation of the polygon and returns area
[x] function that takes the internal rep. of DEM and returns mean elevation
[x] function that takes the land use and returns a dict or namedtuple of land fraction

Finally cleaned this up (again). git-lfs seemed to be a bit more trouble than it was worth. Abandoning it for now and continuing with the development of generic tools. In the future, we can probably write a script linking to the data housed on our servers if we want to seriously test this out.

@huard
I've made a lot of changes and could use some comments if you have the time. Processes now return addresses to temprorary (but persistent, ie: garbage collection might be worth looking into) valid geojson or tiff files and I simply need to add some better tests for edge cases. I also need to remove the remaining git-lfs files but everything seems to be working fine. Are you free to chat tomorrow about next steps?

@huard
Still a work in progress but I've dealt with most of the jarring problems and I would argue it can be safely merged. I'm aiming to spend a few hours writing tests throughout the coming week but everything seems to be working well enough to give functionality to raven. Perhaps once the tests are written, we can consider refactoring/restructuring some of the utilities and processes to make them more modular/readable and standardize their outputs.
If you decide to merge the branch, please squash the commits. This will garbage collect the undesirable files that I introduced and later removed. Cheers!

@Zeitsperre Are you planning other changes or may I continue the review ?

@huard Please feel free to continue. The only major changes I was considering was to refactor the GIS-specific utilities into their own file and leave the generic file-handling function in the utills.py. Functions seem to be stable and returning appropriate outputs from my tests.

Just to confirm, I'll be moving along to other projects while you review this PR. Do you think you could investigate the XML error involved in passing zip files instead of JSON output. I'm not sure how that's handled.
Also, I've noticed that there are a lot of warnings arising in the post-testing debug information. Are they worth looking into?


Macros accessing global variables

Both macros and procedures generate Go functions in PGo. In other words, after parsing, there are not many differences between PlusCal's macro and procedure. However, I believe there should be (PlusCal created the distinction for a reason.)
The issue (that I observed as the result of one of the failing tests at the time) is that macros that attempt to access global state break PGo. Consider the following macro, extracted from test/pluscal/TwoPhaseCommit.tla:
--algorithm TwoPhaseCommit
variables stage = [mgr \in managers |-> "start"];

macro SetAll(state, kmgrs) {
    with (km \in kmgrs) {
        stage[km] := state
    };
}

When generating source code, PGo attempts to create a function SetAll which does what the macro is supposed to do. However, PlusCal expands macros at translation time -- as such, labels (as well as a set of other constructs) are not allowed in macros. When PGo is generating source code for the macro above, it notices the global variable assignment and tries to find the label to which it belongs (as part of the "atomicity" stage.) This breaks since this is a macro and therefore there are no labels.
I don't think there's an immediate fix for this problem (and it is a recurring pattern to have macros accessing global state, from a few other specs I analyzed). Perhaps what we could do is literally expand macros in the Go source code as well, since it's the only place where we will have labeling/atomicity context. This may lead to duplication, but since the set of things you can do in a macro is a lot more limited (no while, function call, labels, etc), it might not be too bad.

as of merge e2a09aec8ae706313ddc28607b6779f1d121f51e we expand macros the same way the PlusCal to TLA+ translator does. This is no longer an issue.


Upgrade deprecated runtime nodejs4.3

CloudFormation templates in aws-cfn-windows-hpc-template have been found to include a deprecated Lambda function runtime (nodejs4.3). The affected templates have been updated to a supported runtime (nodejs10.x).
Please note, this pull request has been generated by a bot; please check the base branch and files changed before merging.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

We've updated the solution to no longer require the lambda function, which resolves the issue that this PR fixes.


SecurityException

Your library file cannot open password protected file.if i  open password protected file its through
java.lang.SecurityException: password required or incorrect password (Exception).
Add the function or method to open password protected file

Hello man,
do you have sample code on how to open a password protected file?
Once the file is open, you should be able to pass it to the library.

Hello man,
do you have sample code on how to open a password protected file?
Once the file is open, you should be able to pass it to the library.

hi voghDev , i don't have any code...i found some other library have function to pass password to their library but your library file don't have that method or function.. even i am not interested to use other library because your quite simple and lite weight....can you help me  how to pass password in your library....

Ok!
I think that opening a password-protected file is not PdfViewPager's responsibility. PdfViewPager is just a document renderer, and the PDF file you pass to it should be available for reading.
So if the PDF file needs to disable some password protection before reading it, I think an external actor should be responsible for that :)
Feel free to fork the repository, clone the code, and modify anything you need for your own requirements

Hi there i need some assistance regarding this password protected problem, how would i unlock the file, before i pass it to get rendered in to view?


find a way to keep track of cached images (SPA)

once the images are loaded and user navigates from one route to another, cached images should have src attribute right away (no lazy loading).
localStorage or applicationCache

I'll send a PR tomorrow.


Add Windows Firewall support

This PR adds support for managing your Windows Firewall.

Perfect timing. I'll review this on Monday. Thank you!!

:+1: Thanks!


[DISAPPEARED FEATURE] Window Focus

Hello,
I'm missing a feature in the newer versions of staxrip that was very useful.
When staxrip finishes its jobs, it automatically fetches the focus - this is sometimes annoying if you work in other programs / windows and for example mark many items or write text in an input box - when the focus is gone the input text or the many markers are gone and you can start over again!
In previous versions of staxrip there was an option in settings where one could enter windows- or program-names - if one of these have the focus, staxrip doesn't fetch focus after the jobs are finished.
Please re-enable this very useful feature.
(Or if I'm too stupid to find the option, please tell me where it is ;) )

This area is complex or problematic, one thing you can do is choose 'Close' instead of Shutdown or Standby. I don't remember why it was removed and will take a look how this was implemented.

one improvement available in the next build is:

new: the main window don't get activated after processing in case the active window is borderless which is the case when a player is in fullscreen mode


Back out enforced signature verification by default

I think the ostree/container attempt to enforce signature verification is strongly motivated (and this is all covered in https://github.com/containers/skopeo/issues/1829 ) but ultimately I feel we're also kind of fighting against the current ecosystem.  And our implementation is suboptimal.
In this proposal we behave the same as podman/docker.  I do still think we should have e.g. podman pull --require-signatures or so...and once that happens we handle it too.

In this proposal we behave the same as podman/docker. I do still think we should have e.g. podman pull --require-signatures or so...and once that happens we handle it too.

To elaborate on this I think what we ultimately want is to try to slowly force into the ecosystem at least a minimum bar where privileged containers must be signed, and we think of the bootc OS as just another privileged container.  Truly enforcing it may never happen in podman upstream but we could emit increasing warnings over time (e.g. start with just printing, maybe a year or two from now we add in my favorite mechanism, a sleep(5) that makes it just annoying enough to force).  And some OS vendors would probably be very happy with a trivial drop-in to /etc/containers/policy/01-force.json or so.


Niloofar / Bug - Fix Typescript errors in careers

Changes:

...

Type of change

[x] Bug fix
[ ] New feature
[ ] Update feature
[ ] Refactor code
[ ] Translation to code
[ ] Translation to crowdin
[ ] Script configuration
[ ] Improve performance
[ ] Style only
[ ] Dependency update
[ ] Documentation update
[ ] Release

LGTM! 🙏


Installation fails in OSX: error: use of undeclared identifier 'NSEventModifierFlagCommand'

Hello,
Thanks for the work and effort you have placed on developing this.
I am trying to use the software, but the installation fails.
$ go get github.com/murlokswarm/mac
github.com/murlokswarm/mac
../github.com/murlokswarm/mac/menu.m:138:41: error: use of undeclared identifier 'NSEventModifierFlagCommand'
../github.com/murlokswarm/mac/menu.m:140:41: error: use of undeclared identifier 'NSEventModifierFlagControl'
../github.com/murlokswarm/mac/menu.m:142:41: error: use of undeclared identifier 'NSEventModifierFlagOption'
../github.com/murlokswarm/mac/menu.m:144:41: error: use of undeclared identifier 'NSEventModifierFlagShift'
../github.com/murlokswarm/mac/menu.m:146:41: error: use of undeclared identifier 'NSEventModifierFlagFunction'
I do have OSX Version 10.11.6 (15G1421)
and Xcode Version 8.2.1 (8C1002)

Hi @pakalvoltan
Can you copy past your env?

Hi,
here the ouput of my env (with login name obfuscated :) )
$ env
TERM_PROGRAM=Apple_Terminal
TERM=xterm-256color
SHELL=/bin/bash
TMPDIR=/var/folders/m7/4gjm2kqd2kz3vnp0pqdzjf_w0000gn/T/
Apple_PubSub_Socket_Render=/private/tmp/com.apple.launchd.w92QsXtf5F/Render
TERM_PROGRAM_VERSION=361.1
TERM_SESSION_ID=DAE67F77-91E3-41B6-8D6C-2B217DCFEC31
USER=xxxxx
SSH_AUTH_SOCK=/private/tmp/com.apple.launchd.RyaFSEV3xo/Listeners
__CF_USER_TEXT_ENCODING=0x1F5:0x0:0x0
PATH=/usr/local/sbin:/Library/Frameworks/Python.framework/Versions/2.7/bin:/usr/local/bin:/usr/bin:/bin:/usr/sbin:/sbin
PWD=/data/code/gows/src/
XPC_FLAGS=0x0
XPC_SERVICE_NAME=0
HOME=/Users/xxxxx
SHLVL=1
LOGNAME=xxxxx
LC_CTYPE=UTF-8
GOPATH=/data/code/gows
SECURITYSESSIONID=186a6
_=/usr/bin/env

Oh problem come from MacOS version.
I developed it on Sierra and look like Apple did a lot of deprecation in their API.
See https://developer.apple.com/reference/appkit/nseventmodifierflags
The easy way to go is update to MacOS Sierra.

Thanks for the reply. For reasons not under my control, I can not upgrade/use it for MacOS Sierra.
It would be good to add the OSX requirement  in the README  as a heads up.
Cheers

Disregard my comment, I see it is described in the requirements, that it needs Sierra
Cheers


Internet Explorer 11 - rotate doesn't work

Hey.
I've notice that rotate class doesn't work on IE 11.
You can simply test your website with IE 11 https://tailwindcss.com/docs/rotate/
I had to add custom class to IE fix "-ms-transform:"

Shouldn't this be handled by Autoprefixer? What does your browserlist look like, in either the .browserslistrc or the browserslist property in your package.json?

Yep this is intentional and in the documentation.


samples: dfu: override esp_clk_init() with empty definition

There is an issue when booting new firmware for the first time. This
results in boot hang. It seems that the reason is esp_clk_init().
Fortunately this function definition is flagged as weak, so override it in
sample to make DFU functional.

Already merged as part of #352


fixed reading time

This closes https://github.com/fastai/fastpages/issues/43

/preview

/preview


Simultaneously multiple column filter with 3 types of input: a simple input, a datepicker or a dynamic dropdown menu.

Interesting! This will be very useful for other people looking for this feature.
I just wish there is a better way to make this pluggable.


Sampling

Description
Provide a brief description of the PR's purpose here.
Todos
Notable points that this PR has either accomplished or will accomplish.

[ ] TODO 1

Questions

[ ] Question1

Status

[ ] Ready to go

Codecov Report

Merging #4 (c8b7088) into main (2ed3743) will decrease coverage by 7.01%.
The diff coverage is 73.90%.