Handle NullPointerException on ImageActivity.loadImage

Caused by: java.lang.NullPointerException:
  at link.standen.michael.slideshow.ImageActivity.loadImage (ImageActivity.java:548)
  at link.standen.michael.slideshow.ImageActivity.onCreate (ImageActivity.java:330)
  at android.app.Activity.performCreate (Activity.java:7090)

Untested but this error could possibly occur when the user selects "Play From Here" when there is nothing in the folder. Would be nice if this NullPointerException was caught and the user was bounced back to the list view with a toast saying:

No images found

or similar

Hi, can i take it ?

@patm22 Yes please! I haven't had the chance to properly debug this so you might have trouble testing it.

Check for empty list is properly done. I believe that bug is somewhere else however I was not able to reproduce it.
All I can do is put try catch and check whether NullPointerException occur and if yes show error toast. I already implemented this and I can create pull request, is it going to be okay?

Sure. Submit a pull request and I'll have a look at the implementation. I wasn't able to replicate the error either. Are you bouncing the user back to the list activity as well as toasting? That would be good enough for this one I think.

Yeah that'll do. Thanks for this! One of those things that needs to be done but I don't have the time. I'll be sure to add a thanks to the change log when I deploy this one.
Thanks again!


WIP: Duplicate Issue.Index stress test

This is a stress test for the models.newIssue() function, which is expected to fail under big server loads. The problem is a duplicate key error due to the way the function calculates the value for the Index column. See #7887 and #7898.
The test only compiles when the stress tag is specified because it always fails (as expected). EDIT: except for SQLite with sqlite_unlock_notify.
Note: I know the code needs refactoring. I'd like some help with that, as I couldn't figure out the proper way to do it.
The code is meant to be run under integrations/ so one day, when the duplicate key is resolved, the test can be run for every database in the CI (AFAIK the CI does not run tests in the models package for all databases; only for SQLite).
What the test does
First the test creates a relatively large number of rows in the Issues table (default=1000) to make the table grow by at least two blocks.
Then, the test spawns several goroutines (default=8) to simulate multiple users attempting to create issues on the server at the same time.
The goroutines keep calling models.newIssue() as quickly as they can, and stop when any of the following is true:

A predetermined time has passed (default=60 seconds).
It gets an error when attempting to insert.
Any other goroutine gets an error.

So, the test should take at most ~60 seconds if successful, or less if it fails.
The reason the code attempts with 8 goroutines and not -say- 1000 is because it's not realistic to expect the database to have a connection pool that big. As long as the goroutines keep inserting continuously, this test is equivalent and gets the server to spend more time doing database stuff and less time doing process synchronization.

This research is indeed stalled. It was partially fixed elsewhere, anyway.


This is actually jorge's pull request: fixes file upload

I have no idea what you're talking about @floofydoug.


Add kubernetes probes

It is currently not possible to configure a readiness/liveness probe in the helm chart for backstage. I can work on this if we are okay with the addition of readiness/liveness probe configuration

I think this makes great sense. 🙂 Do it please! 👍
Unfortunately backstage doesn't provide any useful endpoint like /readyz or /livez endpoints out of the box, so we need to make sure users are aware they need to add those themselves. 🙂

Agree with @tumido!

readiness / liveness probes would be great. A basic health check can be added to
backstage. https://backstage.io/docs/plugins/observability/#health-checks


InvalidOperationException("You must attach an event handler to the event signal within a reasonable amount of time.")

hi there,
I'm using the library and test in Unity3D player is fine. But once I deployed to my Windows Phone, the problem occur. Any idea?
thank you
from
Walter

Hi,
I never had a chance to run it under WP. Can you provide a stacktrace?
Thanks.

looks like it went into maximum try to connect and failed..... do you have any idea in your mind? Below is the Debug log I able to grab
(Filename: C:/buildslave/unity/build/artifacts/generated/WP8/runtime/UnityEngineDebug.gen.cpp Line: 62)
¡@
6
(Filename: C:/buildslave/unity/build/artifacts/generated/WP8/runtime/UnityEngineDebug.gen.cpp Line: 62)
¡@
GetResponseCallback: error occurred - You must attach an event handler to the event signal within a reasonable amount of time.
OnFinish
(Filename: C:/buildslave/unity/build/artifacts/generated/WP8/runtime/UnityEngineDebug.gen.cpp Line: 62)
¡@
OnFinish
(Filename: C:/buildslave/unity/build/artifacts/generated/WP8/runtime/UnityEngineDebug.gen.cpp Line: 62)
¡@
Failed to read response: System.NullReferenceException: Object reference not set to an instance of an object.
at SignalR.Client._20.Http.HttpHelper.ReadAsString(HttpWebResponse response)
6
thank you
from
Walter
Date: Thu, 26 Mar 2015 00:28:15 -0700
From<EMAIL_ADDRESS>To<EMAIL_ADDRESS>CC<EMAIL_ADDRESS>Subject: Re: [SignalR.Client.20] InvalidOperationException("You must attach an event handler to the event signal within a reasonable amount of time.") (#3)
Hi,
I never had a chance to run it under WP. Can you provide a stacktrace?
Thanks.
¡X
Reply to this email directly or view it on GitHub.

Based on your callstack the problem is that HttpWebResponse is null. If I remember right, on WP you are running not on Mono, you are targeting PCL. Can you debug DefaultHttpClient and see which parameters are passed when Finished event raised?

hi there
Can I know what I should look for? I know the line which it instantiate the object - Connection.cs.
refer the attachment
Date: Mon, 30 Mar 2015 10:32:10 -0700
From<EMAIL_ADDRESS>To<EMAIL_ADDRESS>CC<EMAIL_ADDRESS>Subject: Re: [SignalR.Client.20] InvalidOperationException("You must attach an event handler to the event signal within a reasonable amount of time.") (#3)
Based on your callstack the problem is that HttpWebResponse is null. If I remember right, on WP you are running not on Mono, you are targeting PCL. Can you debug DefaultHttpClient and see which parameters are passed when Finished event raised?
—
Reply to this email directly or view it on GitHub.

There is no attachment.
Add breakpoint in [DefaultHttpClient] (https://github.com/jenyayel/SignalR.Client.20/blob/master/source/SignalR.Client.20/Http/DefaultHttpClient.cs) at line 14 and 18. See what happens and let me know.

hi there,
Below is the value I got when I got.  Is there any specific property you want me to check?
UnityEngine.Debug.Log(string.Format("EventSignal: {0}", _signal.GetType().ToString()));
EventSignal: SignalR.Client._20.Transports.EventSignal1[SignalR.Client._20.Http.CallbackDetail1[System.Net.HttpWebResponse]]
UnityEngine.Debug.Log(string.Format("EventSignal: {0}", _returnSignal.GetType().ToString()));
EventSignal: SignalR.Client._20.Transports.EventSignal`1[SignalR.Client._20.Http.IResponse]
thank you
from
Walter
Date: Wed, 1 Apr 2015 13:08:43 -0700
From<EMAIL_ADDRESS>To<EMAIL_ADDRESS>CC<EMAIL_ADDRESS>Subject: Re: [SignalR.Client.20] InvalidOperationException("You must attach an event handler to the event signal within a reasonable amount of time.") (#3)
There is no attachment.
Add breakpoint in DefaultHttpClient at line 14 and 18. See what happens and let me know.
—
Reply to this email directly or view it on GitHub.

Are you still having troubles with it or we can close this issue?


[Security Assessment] PURIS

Security Assessment Request for Eclipse Tractus-X
Component/Feature
Hi, we would like to do the security assesment for the puris  application.
Reason
We're planning to do the quality gate (R24.03) for one standard.
Scope
full application. There will be parts, that will be removed - these must not be covered.
Timeline
We would like to intially start fast and get done before Christmas with the initial checkup.

FYI @pablosec

@tom-rm-meyer-ISST Unfortunately, Pablo is still on vacation. So will take over. I am free next week Wednesday morning, please send me an invitation for a meeting. If you have a current architecture diagram, please include the link to the diagram in the invitation. Sorry for the late reply, I didn't realize Pablo was on vacation.

Hi @scherersebastian,
I already had a meeting today with szymon and will have one again next monday 8.00 o'clock (with @pablosec and Kristian). The meeting coordination has been performed via mail.

perfect


feat: Collector Metric Exporter for Node

Summary
This PR addresses Issue #1109.
Currently, the Collector Exporter only sends traces to the collector. In Python, Java, and Go, for example, metric exporting already exists for the collector. This PR adds that feature. I created two versions, one for Node and the other for browser. The node version uses gRPC, and the browser uses Beacon or XHR. It's up to date with all previous collector exporter commits.
What this PR does
This is the 7th part of this long PR.
This PR creates a CollectorMetricExporter.ts file that is almost identical to the CollectorTraceExporter.ts. It also moves functions to UtilWithGrpc.ts and UtilWithJson.ts.
Testing
I created unit tests and I E2E tested exporting metrics with a sample application connected to Google Cloud Monitoring.
Next Steps
Once this PR and the browser PR are merged, I will add documentation and submit my collector exporter example.

@obecny Yeah, the issue is the CollectorMetricExporter inherits from MetricExporter and CollectorTraceExporter inherits form SpanExporter. They have to be derived from those classes, otherwise, they wouldn't be compatible with MeterProvider and TracerProvider.
I don't think we could change the class hierarchy, and it seems that JS doesn't support multiple inheritance, so I don't know how to get around that issue.

@obecny Yeah, the issue is the CollectorMetricExporter inherits from MetricExporter and CollectorTraceExporter inherits form SpanExporter. They have to be derived from those classes, otherwise, they wouldn't be compatible with MeterProvider and TracerProvider.
I don't think we could change the class hierarchy, and it seems that JS doesn't support multiple inheritance, so I don't know how to get around that issue.
EDIT: Ahh yeah maybe we could get around that with template classes/functions

You will implement SpanExporter or  MetricExporter in final class

More less like this:
abstract class MainBase<Config, ExportType, ItemType> {
  export(
    items: ExportType[],
    resultCallback: (result: ExportResult) => void
  ) {

    this._exportItems(items)
      .then(() => {
        resultCallback(ExportResult.SUCCESS);
      })
      .catch((error: ExportServiceError) => {
        if (error.message) {
          this.logger.error(error.message);
        }
        if (error.code && error.code < 500) {
          resultCallback(ExportResult.FAILED_NOT_RETRYABLE);
        } else {
          resultCallback(ExportResult.FAILED_RETRYABLE);
        }
      });
  }
  private _exportItems(items: ExportType[]): Promise<unknown> {
    return new Promise((resolve, reject) => {
      try {
        this.logger.debug('items to be sent', items);
        this.send(items, resolve, reject);
      } catch (e) {
        reject(e);
      }
    });
  }
  abstract send(item: ExportType[], onSuccess, onFailure): void;
}

abstract class NodeBase<ExportType, ItemType> extends MainBase<CollectorExporterConfigBase, ExportType, ItemType> {
  send(items: ExportType[], resolve, reject){
    const body = this.convert(items);
    .....
    sendUsingBeacon(body, resolve, reject);
    ...
    sendUsingJson(body, resolve, reject);
  }
  abstact convert(items:ExportType[], onSuccess, onFailure): string;
  shutdown
}

class NodeMetricExporter extends NodeBase<MetricRecord, GRPCMetricQueueItem> implements MetricExporter  {
  convert(items: MetricRecord[], onSuccess, onFailure ) {
    const data = toCollectorExportTraceServiceRequest(
      items,
      this
    );
    return JSON.stringify(data);
  }
  shutdown(): void {
    if (this._isShutdown) {
      this.logger.debug('shutdown already started');
      return;
    }
    this._isShutdown = true;
    this.logger.debug('shutdown started');

    // platform dependent
    this.onShutdown();
  }
}

class NodeSpanExporter extends NodeBase<ReadableSpan, GRPCSpanQueueItem> implements SpanExporter  {
  convert(items: ReadableSpan[], onSuccess, onFailure ) {
    const data = toCollectorExportTraceServiceRequest(
      items,
      this
    );
    return JSON.stringify(data);
  }
}

so summarizing

MainBase - main implementation, main config, headers, logger etc., shutdown
NodeBase  and BrowserBase - sending data - platform specific etc., abstract convert, generic export
NodeMetricExporter, NodeSpanExporter, BrowserMetricExporter, BrowserSpanExporter. final classes that call implements either span exporter or metric exporter and has just one method convert
`

@davidwitten this is first part of refactoring what I was talking about ->
https://github.com/obecny/opentelemetry-js/pull/1

Just made a major refactoring change, thanks @obecny for the help!

Would it be possible to merge this so I can update the Web Exporter PR?


InvalidFileURI "cannot have a host" on Windows

This code works on Mac:
path = File.join(File.dirname(__dir__),'rsmp.json')
schema = JSONSchemer.schema( Pathname.new(path) )

But fails on Windows with:
JSONSchemer::InvalidFileURI:
  cannot have a host (use `file:///`)
# ./vendor/bundle/ruby/2.6.0/gems/json_schemer-0.2.17/lib/json_schemer.rb:42:in `block in <module:JSONSchemer>'
# ./vendor/bundle/ruby/2.6.0/gems/json_schemer-0.2.17/lib/json_schemer/cached_ref_resolver.rb:10:in `call'
# ./vendor/bundle/ruby/2.6.0/gems/json_schemer-0.2.17/lib/json_schemer.rb:57:in `schema'
# ./vendor/bundle/ruby/2.6.0/bundler/gems/rsmp-9383b3296fb7/lib/rsmp/message.rb:16:in `load_schemas'
# ./vendor/bundle/ruby/2.6.0/bundler/gems/rsmp-9383b3296fb7/lib/rsmp/message.rb:30:in `<class:Message>'
# ./vendor/bundle/ruby/2.6.0/bundler/gems/rsmp-9383b3296fb7/lib/rsmp/message.rb:3:in `<module:RSMP>'
# ./vendor/bundle/ruby/2.6.0/bundler/gems/rsmp-9383b3296fb7/lib/rsmp/message.rb:2:in `<top (required)>'
# ./vendor/bundle/ruby/2.6.0/bundler/gems/rsmp-9383b3296fb7/lib/rsmp.rb:30:in `require'
# ./vendor/bundle/ruby/2.6.0/bundler/gems/rsmp-9383b3296fb7/lib/rsmp.rb:30:in `<top (required)>'
# ./spec/support/spec_helper.rb:2:in `require'
# ./spec/support/spec_helper.rb:2:in `<top (required)>'

Thanks for the report @emiltin! Does https://github.com/davishmcclurg/json_schemer/pull/88 resolve the issue for you (specifically 106bfc27c031ea73132759f6d82c94b5676f216a)?

Thank you @davishmcclurg, we will test it as soon as possible.

It works for us

Fix released in 0.2.18.
Thanks @emiltin!


SILFunction::removeDifferentiableAttr does not remove attributes.

The current implementation only moves the matching entries to the end of the attributes vector. DifferentiableAttrs.erase(std::remove(...)) deletes the attributes for real. e.g., https://en.cppreference.com/w/cpp/algorithm/remove

@swift-ci please test tensorflow

Aha. Thanks!


Add missing UserID key in openstack keypairs configuration

/retest

proposed an update at https://github.com/openstack-k8s-operators/octavia-operator/pull/276/files

superseded by #276


compatibility with Hyprbars

sadly, the invertion also gets applied to added window decorations by the Hyprbars plugin:

any way to add an exception for those? :D

Thanks for your research, but sadly it isn't that easy. Since decorations are a Hyprland feature and are not separate Windows. Instead they are drawn right before or after  the Window itself, with just a few lines of code in between them, and i haven't seen an easy way to hook into the code between the 2 draw calls:
https://github.com/hyprwm/Hyprland/blob/6e0aadc585c6d9fdaaebfa5853adbf9610897c82/src/render/Renderer.cpp#L644-L674
It would be easy if we could hook into IHyprWindowDecoration::draw using Hyprlands hook system, but hooking a pure virtual function seems to not be possible.
If you have know of a way I would be happy to hear!

I ended up finding a not too hacky way: Create a Class thats wraps IHyprDecorations and then wrap all decorations everytime the window is rendered.
https://github.com/micha4w/Hypr-DarkWindow/blob/264130cb07d40cc20e791d68cd1811ec822bf401/src/DecorationsWrapper.h#L5-L35
https://github.com/micha4w/Hypr-DarkWindow/blob/264130cb07d40cc20e791d68cd1811ec822bf401/src/WindowInverter.cpp#L18-L24
It worked quite well in my testing, i pushed it to tag v0.44.1

I'll be closing this issue since you seem to be happy!

Reopening this because if you are using window rules and decoration::drop_shadow = true it will segfault, working on a fix, but for now the easiest fix is to just turn off drop_shadows

Should be fixed now, i moved the v0.44.1 tag to the new version


[format-tags-in-yaml] Accented letters in a tag's name seem to prevent the recognition of the tags that follows

For example,
tags: #test1 #test2 #test3
returns after linting with format-tags-in-yaml activated:
tags: test1, test2, test3
while the following:
tags: #tést1 #test2 #test3
returns:
tags: tést1 #test2 #test3
The same behaviour seems consistent: every time a tag contains an accented letter (like tést1 above), it is properly treated; but all of the over tags on the same line are not considered.
Sadly, I have no idea as to where the problem might come from.

fixed in #148

Just downloaded v1.2.8, and I can confirm that everything is working perfectly. Thank you so much !


Request for workbox-background-sync not making it into the queue

Welcome! Please use this template for reporting bugs or requesting features. For questions about using Workbox, the best place to ask is Stack Overflow, tagged with [workbox]: https://stackoverflow.com/questions/ask?tags=workbox
Library Affected:
workbox-background-sync
Browser & Platform:
iOS Safari 14.3
Issue or Feature Request Description:
I have the following code in my service worker for workbox background sync.
// Background sync failed image upload requests
const bgSyncPlugin = new BackgroundSyncPlugin("photoUploadQueue", {
  maxRetentionTime: 72 * 60 // Retry for max of 72 Hours (specified in minutes)
});

registerRoute(
  new RegExp(/^.*(s3.us-east-2.amazonaws.com\/protected\/).*$/),
  new NetworkOnly({
    plugins: [bgSyncPlugin]
  }),
  "PUT"
);

When testing offline support in Chrome requests are cached and then replayed without issue, in Safari the queue is created but requests never make it in there and therefore never get replayed.

When reporting bugs, please include relevant JavaScript Console logs and links to public URLs at which the issue could be reproduced.

Hello @patrickcze,
First off, there's a bug in iOS Safari that affects certain form-based upload flows which you might be running into. It's described in https://github.com/GoogleChrome/workbox/issues/2428, and the underlying Apple bug is https://bugs.webkit.org/show_bug.cgi?id=212858
But it's not clear from your original post whether you're doing form-based uploads, and I was curious about how recent versions of Safari behave, so I wanted to see if I could reproduce this issue just using a basic fetch() call to POST image data to a remote URL. I put together https://glitch.com/edit/#!/amber-generated-cave to try out an end-to-end flow.
Both on desktop Safari 14.0.2 and on the iOS Safari emulator, I was able to observe images that were being POSTed properly queued to IndexedDB if I were to go offline and then click on the "Upload" button in that sample app. Getting the queued requests to replay is a little trickier on browsers that don't support native Background Sync (which Safari doesn't), as replays are only triggered if the service worker thread stops running, and then starts back up again. This happens as a matter of course when you're "normally" using a web app, but when you're explicitly trying to debug an issue like this, it can be tough to know how long to wait.
Here's how I was able to do it:

Visiting https://amber-generated-cave.glitch.me/
Going into airplane mode
Clicking "Upload"
Going back online
Navigating to a brand new site, like https://example.com
Waiting a few minutes
Navigating back to https://amber-generated-cave.glitch.me/

When I did all that, I was able to observe workbox-background-sync automatically replaying the queued request, as confirmed by the https://requestbin.com/ endpoint logging.
So, if you're doing something form-based, #2428 probably describes what you're seeing. If you're not, though, let us know and we can investigate further.

Hello @patrickcze,
First off, there's a bug in iOS Safari that affects certain form-based upload flows which you might be running into. It's described in https://github.com/GoogleChrome/workbox/issues/2428, and the underlying Apple bug is https://bugs.webkit.org/show_bug.cgi?id=212858
But it's not clear from your original post whether you're doing form-based uploads, and I was curious about how recent versions of Safari behave, so I wanted to see if I could reproduce this issue just using a basic fetch() call to POST image data to a remote URL. I put together https://glitch.com/edit/#!/amber-generated-cave to try out an end-to-end flow.
Both on desktop Safari 14.0.2 and on the iOS Safari emulator, I was able to observe images that were being POSTed properly queued to IndexedDB if I were to go offline and then click on the "Upload" button in that sample app. Getting the queued requests to replay is a little trickier on browsers that don't support native Background Sync (which Safari doesn't), as replays are only triggered if the service worker thread stops running, and then starts back up again. This happens as a matter of course when you're "normally" using a web app, but when you're explicitly trying to debug an issue like this, it can be tough to know how long to wait.
Here's how I was able to do it:

Visiting https://amber-generated-cave.glitch.me/
Going into airplane mode
Clicking "Upload"
Going back online
Navigating to a brand new site, like https://example.com
Waiting a few minutes
Navigating back to https://amber-generated-cave.glitch.me/

When I did all that, I was able to observe workbox-background-sync automatically replaying the queued request, as confirmed by the https://requestbin.com/ endpoint logging.
So, if you're doing something form-based, #2428 probably describes what you're seeing. If you're not, though, let us know and we can investigate further.

@jeffposnick thanks for all of your work confirming this. I am currently using the AWS Amplify JS SDK for storing files in S3 (https://docs.amplify.aws/lib/storage/getting-started/q/platform/js) and it looks like based on the source code they are using an old S3 js SDK which seems to be using a form based upload.
Any suggestions on how to work around #2428 ?

Hello @patrickcze—I don't have a good workaround for the underlying Safari issue. Based on my understanding of the problem, the body can't be accessed due to the bug, so it's not possible for Workbox to, e.g. read the body and then serialize it in a different format.
Here's the relevant issues that I'm aware of. Your best bet would be to watch them for updates.

https://bugs.webkit.org/show_bug.cgi?id=212858
https://bugs.webkit.org/show_bug.cgi?id=215671 (updated today, by marking another issue as a duplicate, so that implies this is at least on Apple's radar)
https://github.com/mdn/browser-compat-data/pull/6616

If you're able to use something other than FormData in your client-side code, that be another possible workaround.

(We should move this conversation over to https://github.com/GoogleChrome/workbox/issues/2428 now that it's confirmed to be the same underlying issue.)


New/renaming repos

Renaming

[x] bcgov/Build_USA_BEC -> bcgov/BGC_USA_Build

New:

[ ] bcgov/BGC_WNA_Assemble  (part of the code currently in bcgov/Build_WNA_BGC_model)
[x] bcgov/BGC_WNA_model (currently in https://github.com/bcgov/CCISS/tree/spadesfying/CCISS_BGCworkflow/modules/BGCprojections_fit)
[x] bcgov/BGC_WNA_predict (currently https://github.com/bcgov/CCISS/tree/spadesfying/CCISS_BGCworkflow/modules/BGCprojections_predict)
[x] bcgov/BGCprojections - groups the BGC projection-specific repos/modules to make a BGC projections workflow that can be run separately.
[x] bcgov/BGC_novelty  -- contents still being developed (code currently in https://github.com/bcgov/CCISS/tree/spadesfying/Novelty/Novelty_Mahony2017_DemoCode)
[x] bcgov/SS_quantSppFeas --  quantitative analyses on current species/site feasibility (@cour10eygrace)
[x] bcgov/CCISS_Review -- blank repo that will hold issues related to species feasibility review
[ ] bcgov/CCISS_spatialApp -- new repo for tool that is currently in the CCISS_shinyApp repo
[ ] bcgov/FFEC-actions -- new repo to host our GH actions (e.g. data QC actions, data uploading actions)

New "data repos":

see https://github.com/bcgov/CCISS/issues/51

Have all the necessary repos above been created? can links be provided where missing?
@whmacken, this one:

bcgov/BGC_WNA_Assemble (part of the code currently in bcgov/Build_WNA_BGC_model)

was for you to take care of, right?

@cour10eygrace can you check whether the list above needs to be updated following conversations about the *feasTables repos

updated!!


Hot fix for autocomplete not getting a@user

Fixes a bug pointed out by @mo-nathan where autocomplete location doesn't show the user's format.
Test adjusted to log in "Roy Halling" when autocompleting a location where the expectation is scientific.

coverage: 93.656%. remained the same when pulling 376b3834c9ff5b1fdad1f0e58f0e8641805ca2c5 on nimmo-autocomplte-@user into 90c20dd24043ec966238dba6d51edbe215ac82d9 on main.


Need help with prediction codes

Hi, I am working on using a pretrained model to do video classifications and I'm a beginner. I borrowed codes from extract.py in cli and other sources. Following codes did produce some results, but seemed not correct. In addition, for some videos, there were indices larger than 400 in max_indices. Appreciate if anyone could help with the codes!
classes.json is from here.
import sys

import torch
import torch.nn as nn
from torch.utils.data import DataLoader
from torch.autograd import Variable

from torchvision.transforms import Compose

import numpy as np
from einops.layers.torch import Rearrange, Reduce
from tqdm import tqdm

from ig65m.models import r2plus1d_34_32_kinetics
from ig65m.datasets import VideoDataset
from ig65m.transforms import ToTensor, Resize, Normalize
from pathlib import Path
import json

class VideoModel(nn.Module):
    def __init__(self, pool_spatial="mean", pool_temporal="mean"):
        super().__init__()

        self.model = r2plus1d_34_32_kinetics(num_classes=400, pretrained=True, progress=True)

        self.pool_spatial = Reduce("n c t h w -> n c t", reduction=pool_spatial)
        self.pool_temporal = Reduce("n c t -> n c", reduction=pool_temporal)

    def forward(self, x):
        x = self.model.stem(x)
        x = self.model.layer1(x)
        x = self.model.layer2(x)
        x = self.model.layer3(x)
        x = self.model.layer4(x)

        x = self.pool_spatial(x)
        x = self.pool_temporal(x)

        return x

if __name__ == "__main__":
    if torch.cuda.is_available():
        print("🐎 Running on GPU(s)", file=sys.stderr)
        device = torch.device("cuda")
        torch.backends.cudnn.benchmark = True
    else:
        print("🐌 Running on CPU(s)", file=sys.stderr)
        device = torch.device("cpu")

    model = VideoModel(pool_spatial="mean",
                       pool_temporal="mean")

    model.eval()

    for params in model.parameters():
        params.requires_grad = False

    model = model.to(device)
    model = nn.DataParallel(model)
    with open('classes.json','r') as load_f:
        load_dict = json.load(load_f)
    class_names = np.array(load_dict)

    transform = Compose([
        ToTensor(),
        Rearrange("t h w c -> c t h w"),
        Resize(128),
        Normalize(mean=[0.43216, 0.394666, 0.37645], std=[0.22803, 0.22145, 0.216989]),
    ])

    dataset = VideoDataset(Path("./Yoga3.mp4"), clip=32, transform=transform)
    loader = DataLoader(dataset, batch_size=1, num_workers=0, shuffle=False, pin_memory=True)

    video_outputs = []

    with torch.no_grad():
        for inputs in tqdm(loader, total=len(dataset) // 1):
            inputs = inputs.to(device)
            outputs = model(inputs)

            video_outputs.append(outputs.cpu().data)

    video_outputs = torch.cat(video_outputs)

    results = {
        'video': "Yoga-3.mp4",
        'clips': []
    }

    _, max_indices = video_outputs.max(dim=1)

    for i in range(video_outputs.size(0)):
        clip_results = {}
        clip_results['label'] = class_names[max_indices[i]]
        results['clips'].append(clip_results)

    print(results)

The extract tool writes out .npy files with clip features pooled in space and time.
https://github.com/moabitcoin/ig65m-pytorch/blob/fc749e2ee354c3e4ddbb144cf511bb868b008f61/ig65m/cli/extract.py#L18-L37
The VideoModel class you copied chops off the classification head, so that we get the clip features and not just a single class index. You can use the models directly and don't need the VideoModel class on top of it. Then you will also get the classification layer at the end:
https://github.com/moabitcoin/ig65m-pytorch/blob/fc749e2ee354c3e4ddbb144cf511bb868b008f61/ig65m/models.py#L73


Compare Parameters also on path level

Is your feature request related to a problem? Please describe.
When comparing two paths paramaters are checked only when thay are placed directly in operation. When we have common set placed in path then diff don't detect any change.
Describe the solution you'd like
When comparing two operations list of parameters is merged from "parent" path and given operation so we can detect changes.
Describe alternatives you've considered
Other solution can be to leave current operation to operation parameters comparison but also compare parameters between paths.

Hi @tomaszhrem and thanks for reporting the issue.
It would be very helpful if you could provide an example demonstrating this behavior.

Hey, while preparing files I noticed that most probably I incorrectly understood output from diff. E.g. No endpoint changes doesn't mean there are no changes as there is also No changes result.
For now its seems that diff detects difference in paths but I was checking only if endpoints are the same. Need to dig more on how also check paths result.
For sure if base file have parameters and in revision we move it to operation then in fact API stays the same but diff detects it as endpoint modification (New path param).

In mean time - should text output print No endpoint changes if parent path is changed?
Example below when path params are removed in revision:
path_base.txt
path_revision.txt
% oasdiff diff path_base.txt path_revision.txt -f yaml
info:
    contact:
        url:
            from: https://test.com
            to: https://test.com22
paths:
    modified:
        /admin/v0/abc/{id}:
            parameters:
                deleted:
                    header:
                        - tenant-id
                    path:
                        - id

VS
% oasdiff diff path_base.txt path_revision.txt -f text
No endpoint changes

Thx.
I update description to point that its text  output which misses path parameters diff.
Also like you mentioned combination of path and operations params would solve false positive problem when in base we have param in path and in revision its moved to operation (or other way).


Updates associated with OL App Stack Intro changes

What type of PR is this?

Uncomment only one  /kind line, and delete the rest.
For example, > /kind bug would simply become: /kind bug

/kind api-change
/kind bug
/kind cleanup
/kind deprecation
/kind design
/kind failing-test
/kind feature
/kind flake
/kind code-refactoring
Documentation changes: CI will automatically skip test runs if it is a doc related change.

/kind documentation
What does this PR do / why we need it:
This PR updates the documentation that references the Open Liberty stack intro application (https://github.com/OpenLiberty/application-stack-intro.git). There was a recent change to the mentioned application that affects how an odo component is created.
Which issue(s) this PR fixes:
Fixes #?
There is no issue for this PR. Please let me know if one is needed for this small doc update.
PR acceptance criteria:

[ ] Unit test

[ ] Integration test

[x] Documentation

[ ] Update changelog

[x] I have read the test guidelines

How to test changes / Special notes to the reviewer:
N/A

FYI @scottkurz

@mezarin @scottkurz

Just mentioning my #4720 includes this same change basically and also a change to use the endpoint in the devfile.

In that case, which one should we prioritize? If we merge your PR, the same changes proposed in this PR also get in along with more changes. Should we get only #4720 in and close this?

@mezarin @scottkurz

Just mentioning my #4720 includes this same change basically and also a change to use the endpoint in the devfile.

In that case, which one should we prioritize? If we merge your PR, the same changes proposed in this PR also get in along with more changes. Should we get only #4720 in and close this?

@dharmit  we can close this and focus on #4720.  Thanks


Giulio/update default theme

@stvstnfrd - here's the default theme cleanup!

@caesar2164 Can you add a content attributions for the images to the README?

done!

eh +1 for parity.


API: expose screenshot params in save_image()

To allow saving image with alpha channel

Coverage increased (+0.01%) to 77.101% when pulling<PHONE_NUMBER>6e4ef1f61ad319e03f1a03e7a00291 on christianbrodbeck:save_image into cd2c11cf6a4ec1c2cfd84af7d2b91991df4a8cc3 on nipy:master.

Can you update the changes file too? :)

:) updated

Coverage increased (+0.01%) to 77.101% when pulling e5bcee4f81a7fa078dd1feee78df6236dd6590ed on christianbrodbeck:save_image into cd2c11cf6a4ec1c2cfd84af7d2b91991df4a8cc3 on nipy:master.

Coverage increased (+0.01%) to 77.101% when pulling e5bcee4f81a7fa078dd1feee78df6236dd6590ed on christianbrodbeck:save_image into cd2c11cf6a4ec1c2cfd84af7d2b91991df4a8cc3 on nipy:master.

Nice, thanks


(Android) Implement remaning debug methods

Description:

Implement functionality for these debug buttons:

Submit debug log
Show local diagnosis keys
Force App Crash
Reset Exposures

These buttons cannot be implemented on Android because we are don't store Exposures in our database (we always take that information from the API)

Simulate Exposure
Simulate Exposure Detection Error

Linked issues:

https://trello.com/c/ij8EtDKQ/305-add-remaining-debug-functionality
How to test:

Submit Debug Log -> Should send AppId, Version, VersionName, LastProcessedFileName & LastDetectionProcessDate
Show local diagnosis keys -> Displays your diagnosis keys in a new screen
Force App Crash -> Forces a crash in the app
Reset Exposures -> Wipes the database, you should see the exposure notification again if you tap on "Detect exposures now"

@octohub The button has been fixed in this PR https://github.com/Path-Check/gaen-mobile/pull/164
I'll do a rebase

Removed fetchDebugLog since it will be removed from RN here https://github.com/Path-Check/gaen-mobile/pull/175


Runserver hardcoded to use 2 Gunicorn workers instead of default 4

Make sure these boxes are checked before submitting your issue - thank you!

[ * ] I have checked the superset logs for python stacktraces and included it here as text if any
[ * ] I have reproduced the issue with at least the latest released version of superset
[ * ] I have checked the issue tracker for the same issue and I haven't found one similar

Superset version
0.14.1
Expected results
At least 4 workers should start as per the defaults in config.py and the Superset CLI python:
def run_server():
    parser = argparse.ArgumentParser(description='Run gunicorn for superset')
    subparsers = parser.add_subparsers()
    gunicorn_parser = subparsers.add_parser('runserver')

    gunicorn_parser.add_argument(
        '-d', '--debug', action='store_true',
        help='Start the web server in debug mode')
    gunicorn_parser.add_argument(
        '-a', '--address', type=str, default='<IP_ADDRESS>',
        help='Specify the address to which to bind the web server')
    gunicorn_parser.add_argument(
        '-p', '--port', type=int, default=8088,
        help='Specify the port on which to run the web server')
    gunicorn_parser.add_argument(
        '-w', '--workers', type=int, default=4,
        help='Number of gunicorn web server workers to fire up')
    gunicorn_parser.add_argument(
        '-t', '--timeout', type=int, default=30,
        help='Specify the timeout (seconds) for the gunicorn web server')

Actual results
After running "runserver", the Unix 'ps' command indicates we're passing '2' to the workers parameter on Gunicorn rather than 4.
This results in slower load times for large dashboards.
 4351 ttys001    0:03.04 /Users/robertkingston/superset/venv/bin/python3 /Users/robertkingston/superset/venv/bin/superset runserver -p 8088
 4364 ttys001    0:00.29 /Users/robertkingston/superset/venv/bin/python3 /Users/robertkingston/superset/venv/bin/gunicorn -w 2 --timeout 60 -b <IP_ADDRESS>:8088
 4367 ttys001    0:02.92 /Users/robertkingston/superset/venv/bin/python3 /Users/robertkingston/superset/venv/bin/gunicorn -w 2 --timeout 60 -b <IP_ADDRESS>:8088
 4368 ttys001    0:02.89 /Users/robertkingston/superset/venv/bin/python3 /Users/robertkingston/superset/venv/bin/gunicorn -w 2 --timeout 60 -b <IP_ADDRESS>:8088

Steps to reproduce
Run the latest version of Caravel out of the box.

Yeah, regressions from 50da4f8c0708f91ff24c0abd7189a137a1415bf6 as it stopped reading default from the config

@xrmx - Yep - definitely on 0.14.1 installed it via pip to my local machine.
Will try installing via master a bit later to see if I can confirm for you. Note - I'm also seeing it on an older docker image by @amancevice which I'm running on a VPS.

@xrmx - sorry my mistake... I had master installed via pip and 0.14.1 installed via docker. I'm living in the future.
Regardless, we'll need to update the documentation / docker image to add the config path to the environment.


Recursive Ternary search in c

💥 Proposal
(A clear and concise description of what the proposal is.)
Implementation of  Ternary search in c
Have you read the Contributing Guidelines on Pull Requests?
(Write your answer here.)
Yes

/assign


Do not delete machine class secrets for newly created machine classes

With the integration of the cluster-autoscaler (#200) we accidentally made the Gardener deleting the machine class secrets for machine classes that are newly created immediately.
This PR fixes the behaviour.
Thanks for finding the issue @prashanth26.

Thanks for reviewing @mvladev and @prashanth26


Search Results component in React

As we've built many features to justify the one-liner description of this project i.e. a go-to networking tool, now it's time to revamp the existing UI.
Add a new component Results.js which willdisplay the result of the current scan.  Refer the image attached below for design.
As of now, create Results.js which takes input from  results.json(create a json file with hardcoded results) and display them according to the UI
P.S. : The basic frontend on react is available on feature/frontend-react branch in the folder network-scanner. Add your components in the same branch. Do not make any changes in App.js / index.js.

kindly add level3 label here too. @ishika1727

Hi, I would like to work on this issue. Kindly assign this to me

I would like to work on this issue

please assign me

@subhangi2731 Assigning you this issue.

@vinitshahdeo @ishika1727  After giving the request and getting that json I have to parse and print the json in UI right by using Bootstrap with react ??

@vinitshahdeo @ishika1727 After giving the request and getting that json I have to parse and print the json in UI right by using Bootstrap with react ??

Yes. You can go ahead!


How to realize OIDC in JavaScript

(JavaScriptでのOICDの実現)
List any relevant URLs
https://slack.dev/java-slack-sdk/guides/ja/sign-in-with-slack
Requirements
I would like to realize the OICD authorization in JavaScript.
In JAVA, there was an explanation page for OICD.
However, there was no similar explanation page in JavaScript.
Please let me know how to realize this in JavaScript.

Hi @tak0303, thanks for reaching out with your question.
Unfortunately, bolt-js does not currently support OIDC, unlike the Java SDK. We also don't have any short-term plans to enhance bolt-js for this particular use case. Therefore, you'll need to implement your own web application to handle it. For guidance, you can refer to this example code.
I hope this was helpful to you!

Kazuhiro Sera
Thank you for your response.
Kazuhiro Seraさん
回答ありがとうございます


open /usr/local/bin/jamf: permission denied

I can install and run whalebrew commands with no problem. When I run whalebrew list, however, I get open /usr/local/bin/jamf: permission denied. I'm running macOS Sierra 10.12.2 (Darwin Kernel Version 16.3.0) and Docker for Mac 1.13.0.

Thanks for the report! Dupe of #7.

Thanks for the quick fix, @bfirsh! You are awesome! (and sorry for the dupe!)


Docker shouldn't prevent --dns from being used with --net=host

Currently, using Docker 1.4.0, I get:
$ docker run --net=host --dns=<IP_ADDRESS> ubuntu
FATA[0000] Conflicting options: --net=host can't be used with --dns. This configuration is invalid.

I can see that this would be an unusual combination, but I don't see that it is invalid.  It seems I can achieve the effect by creating a file and bind-mounting it - -v /tmp/myresolv:/etc/resolv.conf, so don't see why Docker refuses to do this for me.

@bboreham --net=host means that the host's networking stack is being used. There were problems and bugs with other setups and this is why it was changed.

Can you remember any more about what happened?  I tried searching the old issues, but didn't come up with anything.
Looks like someone else had the same thought, although perhaps attached it to the wrong commit.

@bboreham There were a lot of problems around this. I recall that some users reported some problems with this and it didn't really seem like it was Docker's fault.

The original PR that started ignoring DNS settings when --net=host is #5129 just for reference.  The warning about conflicting options was added later.  Of course, prior to that PR it would have been ugly to modify resolv.conf in --net=host mode as it would have edited the host's resolver config!  After that PR, just like all other containers, each container received a private copy, so now I'm tempted to consider why it makes sense to prevent.  @vieux given you wrote the original PR, any thoughts on this other than a potentially reasonable effort to protect users from doing something silly after they have effectively declared "I want to use the host's network settings/stack as-is"?

There are some applications, like for example Asterisk (open source SIP server) which send their IP addresses in SIP packets depending on IP of the network interface it owns. Sending private IP in SIP packet in SDP part can cause deaf connections. There is a way to overcome this:

change the configuration of Asterisk saying which IP address should be stated in those packets
However, the problem begins when you have multiple IP addresses depending on the network, than such configuration is not possible.
The way to overcome this obstacle is to state --net="host", but then Asterisk has no access to docker containers by dns name provided by DNS server (skydns for example).
You can change the resolv.conf on your host machine stating the first dns to <IP_ADDRESS> and then running your docker dns service with exposed ports but it is much more "dirty" than the option of defining the dns server during the start of container with host option.

Asterisk of course is one example, I'm sure there are much more of them...

this is working as intended

@jfrazelle You mean that the intended behavior is to disallow --dns with --net=host ?
I understand why it was originally introduced (--net=host meant the host's /etc/resolv.conf was bind-mounted), but this is no longer the case.
I too suffer from this restriction.
Will appreciate your response. Thanks

+1

+1 would like to see the ability of using --add-host to containers that need to talk on user-defined networks but use the --net=host stack

+1

Fixed in #22408


Artefacts on RTSP stream from rpiCamera

Which version are you using?
v0.23.6
Which operating system are you using?

[ ] Linux amd64 standard
[ ] Linux amd64 Docker
[x] Linux arm64 standard
[ ] Linux arm64 Docker
[ ] Linux arm7 standard
[ ] Linux arm7 Docker
[ ] Linux arm6 standard
[ ] Linux arm6 Docker
[ ] Windows amd64 standard
[ ] Windows amd64 Docker (WSL backend)
[ ] macOS amd64 standard
[ ] macOS amd64 Docker
[ ] Other (please describe)

Describe the issue
Description
Running mediamtx on Raspberry Pi Zero W 2 with Raspberry Pi Camera V3 - Wide angle (Tested both RTSP and WebRTC feeds)
Where the feed is normal when camera and the objects in the frame are still.
As soon as the objects in the frame or the camera is moved, the artefacts start appearing (see sample recording attached).
Describe how to replicate the issue

start the server
publish with RTSP or WebRTC
read with VLC on MacOS or reach with datarhei/restreamer

Did you attach the server logs?
yes: mediamtx.log
Did you attach a network dump?
no
https://github.com/bluenviron/mediamtx/assets/53529055/8897c568-484c-43ea-9a1d-4da6adf3cda6

short answer: decrease the camera bitrate since your network is not able to handle it. Otherwise you can try to switch to TCP. There's a section in the README about corrupted frames: https://github.com/bluenviron/mediamtx#corrupted-frames


Cursor now looks as if it is picking up the object and moving it.

Shouldn't this be up to the lib consumer?

Yes, and they can totally change it. I'd think it would make more sense to put it here due to the fact many people will try and add it. I think having the cursor show it is grabbing and moving the object is quite convenient.

Fair enough :)

Deployed to gh-pages


Feature/Madsim simulation

Described in #282
Currently, the simulation is only implemented for curp.
I plan to complete this task in 2 pull requests, this is the first PR.
This PR is based on #310
Please briefly answer these questions:

what problem are you trying to solve? (or if there's no problem, what's the motivation for this change?)

what changes does this pull request make?

are there any non-obvious implications of these changes? (does it break compatibility with previous versions, etc)

These commits do not affect the original code. Also simulation is a test crate so no coverage for the code.

We need to rebase to #334 to resolve the clippy lint issue.


Set to 0 the margin and the padding on body to avoid appear the scroll bar

The default's margin and padding of the body makes the content to be scrollable. This change fixes it

Thanks!


emerald_import* & emerald_export* doesn't embedded JSON objects as plain string values

https://stackoverflow.com/questions/7750399/how-to-encode-json-embedded-within-json
Like "abi": "[{\"constant\":false,\"inputs\":[{\"name\":\"receiver\",\"type\":\"address\"},{\"name\":\"amount\",\"type\":\"uint256\"}],\"name\":\"sendLoyaltyPoints\",\"outputs\":[],\"payable\":false,\"type\":\"function\"},{\"constant\":false,\"inputs\":[{\"name\":\"familyMember\",\"type\":\"address\"}],\"name\":\"registerFamilyMember\",\"outputs\":[],\"payable\":false,\"type\":\"function\"},{\"constant\":false,\"inputs\":[],\"name\":\"EmiratesLoyaltyPoints\",\"outputs\":[],\"payable\":false,\"type\":\"function\"},{\"constant\":false,\"inputs\":[{\"name\":\"addr\",\"type\":\"address\"}],\"name\":\"getBalance\",\"outputs\":[{\"name\":\"\",\"type\":\"uint256\"}],\"payable\":false,\"type\":\"function\"},{\"anonymous\":false,\"inputs\":[{\"indexed\":true,\"name\":\"from\",\"type\":\"address\"},{\"indexed\":true,\"name\":\"to\",\"type\":\"address\"},{\"indexed\":false,\"name\":\"value\",\"type\":\"uint256\"}],\"name\":\"Transfer\",\"type\":\"event\"}]".

I think it's more straightforward  way always use JSON embeddable string representation for embedded big objects, that's very usual for import & export sort of stuff. @elaineo what do you think about it?

what's wrong with embedding nested JSON objects?
as long as the encoders/decoders can handle it, either way is fine with me.

For me not fully consistent, for example, abi should be just single string field, because it can be several different incompatible versions, better just to separate JSON-RPC method parameters from import & export JSON objects, not to mix them with each other.

ok, makes sense 👍


Delta already implements Vacuum command for data path garbage collection in the latest version, but I can't find any collection mechanism for log path (default value is _delta_log).
otherwise, the delta log file will grow fast in an append Structured Streaming program.
I think is a batter idea to collect these log file when we run Vaccum command.

Log cleanup happens automatically on every commit. By default the retention period is 30 days.
You can find the code in MetadataCleanup.

hi, @marmbrus
MetadataCleanup.doLogCleanup() never been invoke by DeltaLog in current open source version.
and another question is: if we do log clean up on every commit, and do data clean up on run Vaccum command, we maybe got commit info without data or data without commit info, do these operations confuse the user?

should we put log clean up operation and data clean up operation together?

@cfmcgrady It's called here: https://github.com/delta-io/delta/blob/v0.3.0/src/main/scala/org/apache/spark/sql/delta/Checkpoints.scala#L124


Error on script load

Hey,
I was checking out the script you've written, and on load I was getting the following error:
[OBS-Stats-on-Stream.lua] Error running file: ...udio/data/scripts/OBS-Stats-on-Stream-main//ljsocket.lua:837: table index is nil

I do need to add that I'm on Linux, and us the flatpack version of obs-studio

This error is related to socket library I use, not to my script: https://github.com/CapsAdmin/luajitsocket/issues/2.

Implemented the suggested fix in 6b21fb5db9f569676fd5fef6f75fd1a1dccd10de. Let me know if that works so I can close the issue.

First changed it to:
    errno = {}
    errno.EAGAIN = 11,
    errno.EWOULDBLOCK = errno.EAGAIN
    errno.ENOTSOCK = 88
    errno.ECONNRESET = 104
    errno.EINPROGRESS = 115

Which still caused an error:
[OBS-Stats-on-Stream.lua] Error running file: error loading module 'ljsocket' from file '/path/to/OBS-Stats-on-Stream-main//ljsocket.lua':
	/path/to/OBS-Stats-on-Stream-main//ljsocket.lua:691: unexpected symbol near '='

Looks like the following worked:
    errno = {
        EAGAIN = 11,
        ENOTSOCK = 88,
        ECONNRESET = 104,
        EINPROGRESS = 115,
    }
    errno.EWOULDBLOCK = errno.EAGAIN

I don't know LUA enough so my bad if I copied something wrong. Just wanted to make sure its known something was broken.

If anybody reads this - no need to edit anything manually, it has been fixed here. Thanks for your feedback, ianwijma! Closing the issue.


np.empty fails with TypingError when dtype is provided using a keyword argument

This function doesn't work (I'm running master here):
@jit(nopython=True)
def empty():
    return np.empty(10, dtype=np.float64)

It took me a little while to figure out that I could simply remove dtype= to make this expression work. Given that this is a common way to provide these arguments, it would be nice to support this.

Yes, we currently don't support keyword arguments when calling into builtin or library functions. That's something we should figure out; I briefly took a look some time ago and it's bit more complicated than I assumed...

A simple alternative ( for now) would be a more informative error message. TypingError is pretty unhelpful.

This should now work, at least for the common cases.


Replace config.py with home folder .ini + handler functions

Supersedes #73, so we don't have to write to protected folders.
If environment variable key is not specified, check home_folder/soccer-cli.ini for key.
If file exists with key, load key from file and use that every time afterward.
If file does not exist, record key from stdin, write that to file and use that every time afterward.
cc @Saturn @ueg1990

Added the --apikey command, and moved all print() to click.secho().


Jest-resolve does not resolve dependencies correctly

Do you want to request a feature or report a bug?
Bug
What is the current behavior?
By default, when Node.js loads a module from a path that is symbolically linked to a different on-disk location, Node.js will dereference the link and use the actual on-disk "real path" of the module as both an identifier and as a root path to locate other dependency modules. In most cases, this default behavior is acceptable. However, when using symbolically linked peer dependencies, as illustrated in the example below, the default behavior causes an exception to be thrown if moduleA attempts to require moduleB as a peer dependency:
Jest-resolve does not do this, it acts as if the --preserve-symlinks flag was always on.
What is the expected behavior?
Jest-resolve should not preserve symlinks unless the flag is present.

Related to #5852 ?

@nickpape-msft this is closed by #5085, isn't it?


Improve AWS kfctl

What change we make:

Deleted legacy code in aws.go

Since github.com/kubernetes-sigs/application deleted tag v0.8.0 (https://github.com/kubernetes-sigs/application/tags), upgrade to v0.8.1.

What test we run:
Run make build and it succeeded, then use new-built kfctl to deploy kubeflow and passed.

/cc @Jeffwan

/lgtm
/approve


Flaky test in SiteSidebar.test.tsx

Steps to Reproduce
This test failed once on CI, so may fail again:
FAIL static/js/components/SiteSidebar.test.tsx
  ● Console

    console.error
      Warning: Encountered two children with the same key, `foobar`. Keys should be unique so that components maintain their identity across updates. Non-unique keys may cause children to be duplicated and/or omitted — the behavior is unsupported and could change in a future version.
          in div (created by SidebarSection)
          in SidebarSection (created by SiteSidebar)
          in div (created by SiteSidebar)
          in SiteSidebar
          in Router
          in Provider
          in Provider (created by WrapperComponent)
          in WrapperComponent

      at printWarning (node_modules/react-dom/cjs/react-dom.development.js:88:30)
      at error (node_modules/react-dom/cjs/react-dom.development.js:60:5)
      at warnOnInvalidKey (node_modules/react-dom/cjs/react-dom.development.js:13801:11)
      at reconcileChildrenArray (node_modules/react-dom/cjs/react-dom.development.js:13832:21)
      at reconcileChildFibers (node_modules/react-dom/cjs/react-dom.development.js:14305:14)
      at reconcileChildren (node_modules/react-dom/cjs/react-dom.development.js:16762:28)
      at updateFragment (node_modules/react-dom/cjs/react-dom.development.js:16977:3)
      at beginWork (node_modules/react-dom/cjs/react-dom.development.js:18649:14)

  ● SiteSidebar › should pad all .config-sections excepting the last one

    expect(received).toEqual(expected) // deep equality

    - Expected  - 1
    + Received  + 0

      Array [
        "sidebar-section pb-4",
        "sidebar-section pb-4",
        "sidebar-section pb-4",
    -   "sidebar-section pb-4",
        "sidebar-section",
      ]

      75 |         .find("SidebarSection")
      76 |         .map(wrapper => wrapper.find("div").prop("className"))
    > 77 |     ).toEqual([
         |       ^
      78 |       "sidebar-section pb-4",
      79 |       "sidebar-section pb-4",
      80 |       "sidebar-section pb-4",

      at static/js/components/SiteSidebar.test.tsx:77:7
      at fulfilled (static/js/components/SiteSidebar.test.tsx:5:58)

I made a fix in a commit in #164

I think this can be closed.


Enable the new model serialization for networkanalysis

Contributing to the Azure SDK
Please see our CONTRIBUTING.md if you are not familiar with contributing to this repository or have questions.
For specific information about pull request etiquette and best practices, see this section.

API change check
API changes are not detected in this pull request.


Larger size video files are not playing smoothly in Asset share Details page

Describe the bug
When we are playing large size video files in details page for example 50MB, 100MB & more than that, it’s not playing smoothly in details page. Please let us know Is there any limitations and recommendation for best video playback experience in details page.
Environment

AEM Version: ? AEM <IP_ADDRESS> & AEM 6.5.1
Asset Share Commons Version: ? 1.5.2 & 1.8.0
Author, Publish or both? Publish

To Reproduce
Steps to reproduce the behavior:

Upload large size videos in DAM and publish it (50MB, 100MB and above)
Go and check the playback of the video in publisher details page.

Expected behavior
Video should play smoothly in details page.
Screenshots
NA
Additional context
NA

Do these videos play smoothly from AEM Publish in general? For example, copy the Video URL and past it in a new browser tab, and open it in the browser's native player .. does it play smoothly?
Does this issue occur locally or only on hosted environments?
Im trying to ascertain if the issue is with ASC or with AEM's ability to stream out these video files in a performant manner.

Hi David,
Apologies for delay in response and appreciate your response!
We are facing this issue in hosted environments (pre prod & prod). And I could see same playback issue in Publish DAM.

@assetshare2018 if there is an issue playing back directly from the Asset URL provided by AEM, then it sounds like the issue is with AEM itself. Have you logged a Support ticket?

Hi David,
Yes we created the daycare ticket also for this issue, in general any framework mechanism or video player plugin will help to resolve this issue?


HowTo for building Pumpa on OS X - dependency update

I followed these OSX instructions on a new iMac (OSX 10.10.1), and encountered the following build error:
In file included from src/main.cpp:25:
In file included from src/pumpapp.h:52:
In file included from src/messagewindow.h:35:
In file included from src/messageedit.h:29:
src/qaspell.h:32:10: fatal error: 'aspell.h' file not found
#include <aspell.h>
         ^
1 error generated.
make: *** [obj/main.o] Error 1

homebrew installs aspell.h into /usr/local/include.
I edited the pumpa Makefile and added
-I/usr/local/include

to the "INCPATH" and executed a successful build.
Perhaps adding /usr/local/include to the pumpa Makefile INCPATH a good enough solution.

I suppose you can close this issue, since it's related to Pumpa and it's solved as you say in your last comment :)

Hmmm .... A better solution is to update the wiki page. I will attempt this.

Closing per the above: this doesn't have to do with pump.io core and can be fixed by OP in the wiki.


CoreTemp support in CPU Meter

Really should have been here from the beginning. Users will be able to use CoreTemp or SpeedFan to monitor CPU temperatures if HWiNFO is unavailable. Users will be able to select which service to use in the CPU Settings skin, with radio buttons (a new venture for me).
To-do

[ ] Implement alternate measures
[ ] Implement measure switching based on setting
[x] Implement setting switches in settings skin

So this will be done automagically, not by the user clicking a switch. This allows for the most possible information to be retrieved depending on which programs the user is running. HWiNFO is always preferred, and it will dynamically switch the measures depending on the combination of CoreTemp and SpeedFan running the user has.


Edit Outdated Screen?

What is your question?
Is there any way to edit the screen where it says that your Psych Engine is outdated, like the text and github link?

just edit the source for it

just edit the source for it

YOU GOTTA BE KI-


Pop up window to grant permission for the location does not show.

when toggling the toggle button for location, nothing pops up to grant permission for location access.
here's a screen record.
https://user-images.githubusercontent.com/121883478/234477849-381be7b3-80a6-4883-8beb-b4cd3430bc0e.mp4

It will appear when the main page is updated.

oh, my bad. i tried to turn it and refresh the main page, and now it shows up! thanks again, @Leonavichus!


Merging this repo with oldDderivations?

I believe, from reading Dlang foundation monthly meeting summary 2022-Nov, that this project has a common goal with me and my project.
I suggest we combine our efforts. I'm happy to give you maintainer rights to OldDDerivations, or alternatively to commit what I've done there to here instead. I haven't familiarised myself with Nix flakes yet, but I'm happy to learn and start using them. What do you think?

Hi @dukc thanks for reaching out! I have replied via email. In summary, I'd also be very happy to join forces with you!


Adding warning for Ubuntu 16.10 and mawk

Signed-off-by: David McKay<EMAIL_ADDRESS>

Hi! To make it easier for everyone, I've opted to make gawk a hard dependency and add some documetnation. Check this PR
Thanks for pointing it out!


Different behaviour when specifying scheduler == 'threads'

Hi, I am using dask to parallelise a feature extraction pipeline - part of the feature extraction pipeline uses the output of a keras model. For everything so far I am using bag and df; so (based on the docs) the default scheduler is threads.  Weird enough if I explicitly specify the scheduler to be threads I run into an exception; specifically an exception irrelevant to dask but one that is frequently discussed as an issue when invoking  keras models in a multithread environment. Does that make sense? Is threads not the default scheduler and how could the behaviour change when explicitly asking for this scheduler.
Unfortunately I cannot share the feature extraction code or the model that when loaded with threads causes the exception :/

Threads is the default scheduler for dask dataframe, but multiprocessing is
the default scheduler for dask bag
On Wed, Nov 14, 2018 at 5:14 AM Gryllos Prokopis<EMAIL_ADDRESS>wrote:

Hi, I am using dask to parallelise a feature extraction pipeline - part of
the feature extraction pipeline uses the output of a keras model. For
everything so far I am using bag and df; so (based on the docs) the default
scheduler is threads. Weird enough if I explicitly specify the scheduler
to be threads I run into an exception; specifically an exception irrelevant
to dask but one that is frequently discussed as an issue when invoking
keras models in a multithread environment. Does that make sense? Is
threads not the default scheduler and how could the behaviour change when
explicitly asking for this scheduler.
Unfortunately I cannot share the feature extraction code or the model that
when loaded with threads cases the exception :/
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/dask/dask/issues/4205, or mute the thread
https://github.com/notifications/unsubscribe-auth/AASszO6s70ZcHz73zpidnHciSN_cwzkxks5uu-z3gaJpZM4YdbHM
.

@mrocklin sorry misread the doc. I noticed that specifying the 'processes' scheduler gives a measurable improvement in execution time; Is this expected or could happen as a side-effect of something?

https://docs.dask.org/en/latest/scheduling.html

For different computations you may find better performance with
particular scheduler settings

On Wed, Nov 14, 2018 at 8:49 AM Gryllos Prokopis<EMAIL_ADDRESS>wrote:

@mrocklin https://github.com/mrocklin sorry misread the doc. I noticed
that specifying the 'processes' scheduler gives a measurable improvement in
execution time; Is this expected or could happen as a side-effect of
something?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/dask/dask/issues/4205#issuecomment-438667744, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AASszMz8AeCktrDBDK1ScSaQFUsxNmAvks5uvB9lgaJpZM4YdbHM
.

I thought that specifying the same scheduler as the default should result in the same settings

Yes, it should
On Wed, Nov 14, 2018 at 8:59 AM Gryllos Prokopis<EMAIL_ADDRESS>wrote:

I thought that specifying the same scheduler as the default should result
in the same settings
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/dask/dask/issues/4205#issuecomment-438670975, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AASszKl0dOEevgZD249EKlDwvUMAWAO3ks5uvCHDgaJpZM4YdbHM
.

I recommend providing a minimal example.  It's quite difficult to provide meaningful assistance otherwise.

okay makes sense; I think it's clear now, I don't have anything more concrete than the following question. When your computation graph includes both dataframes and bags, can I know which scheduler is used by default?

it is defined by the final object from which you call compute.

okay, that's clear. thx a lot


Added Cake Interview link at the bottom of Coding Practice Sites

Hello
I added a link at the end of Coding practice sites. Interview cake has amazing step by step break down on how to solve and approach problems. I thought this should be on this list.

Not sure about the quality of the proposition, but yeah, adding it.
Thanks for you contribution! ❤


MonteCarlo Simulation

Team, is there a plan to implement MonteCarlo simulation? I can contribute to one if it is in the works or contribute to any other higher priority items on your list.
Krishna

Hi!
Could you please clarify what the exact issue is? We have generic
Euler/Milstein samplers as well as a bunch of models with specialized
samplers implemented.
Best,
Cyril
On Sat, Dec 11, 2021 at 5:09 AM DhinNeGeNe @.***> wrote:

Team, is there a plan to implement MonteCarlo simulation?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/google/tf-quant-finance/issues/63, or unsubscribe
https://github.com/notifications/unsubscribe-auth/ADMX3DR4YX4JWP37ZXBQQ2LUQLMJTANCNFSM5J2SWLZA
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.


Is there a nowrap option?

I am using rtichoke with neovim terminal and it would be great to have a way to let DataFrame output write beyond the border of the terminal without wrapping so all variables stay in their own columns.  I am hoping for something similar to the output of dbext if you have ever used that vim plugin.
Thanks so much for building rtichoke btw.  I can't believe it has taken me this long to find it.

It is always tricky to display tables in a terminal. You may want to play with the settings rtichoke.auto_width and width. However, I doubt if they will provide any useful results.


Anime isn't syncing between my computer and my TV

I'm not sure if it's something on my end but only anime I watch on my computer shows in my computer history and anime I watch on my TV shows on my TV history

sure. because it only save anything offline, Animetv don't collect and save any of your activity, and don't have any online service to do something like that. only saved it locally. everything is between your device and source server (no middle man, no AnimeTV server, no analytic, telemetry etc).
If you want to track it in multiple device, just login with AniList or MAL.

that makes sense thanks for the quick responce


Numpy 2.0 incompatibility

Edu notebooks run on binder are currently not working due to a change in numpy 2.0: np.NaN was removed in the NumPy 2.0 release. Use np.nan instead. This is thrown in the flowline model, so needs to be fixed in OGGM, but this is a larger change.  An easy fix here would be to pin numpy < 2.0.

I'm amazed the notebooks run on Binder at all. How about classroom?

1.6.2 we should fix.
Numpy 2.0 support will need more time, probably until end of year (cc @pat-schmitt in case he is not listening here)


Enrich Mist Prometheus Metrics

Add user_id label to playback-related metrics. We can add more stream-related labels if needed.
Additional comments:

Adding labels is done on-the-fly (if we see some performance issues, then we can include some caching)
Mist metrics are exposed under a separate endpoint /mistmetrics (we can consider merging them with the catalyst metrics under /metrics)
Adding labels is done by a simple string replacement, I considered using some Prometheus metrics parsing, but it seemed to be more code and more works, so ended up with this solution

Related PRs:

https://github.com/livepeer/catalyst/pull/835
https://github.com/livepeer/livepeer-infra/pull/1931

fix https://linear.app/livepeer/issue/ENG-1581/whitelist-usersaccounts-so-they-never-raise-viewers-by-stream-alert

Merging it with existing /metrics would simplify prometheus config as it wouldn't need to set it up to scrape this additional endpoint.

Merging it with existing /metrics would simplify prometheus config as it wouldn't need to set it up to scrape this additional endpoint.

Yeah, the reason I didn't merge it together is that if, for some reason, this /mistmetrics does not perform well, then it's simpler to (temporarily) stop using it. Otherwise, if we have any issues with this, we would need to stop fetching all metrics.

I think we should aim to avoid blacklisting/whitelisting on the grafana-side... but rather have it on the studio-side.... so we'd need to pull another information from studio - is_whitelisted flag... But that's a longer story, I guess

I think that having two endpoints might require being served at two different ports. I can't find a simple way to extract prometheus metrics from two endpoints on the single port.... not sure

I think that having two endpoints might require being served at two different ports. I can't find a simple way to extract prometheus metrics from two endpoints on the single port.... not sure

Ok, merged everything into /metrics


RSO, Cal Coord, Privileges Combining

Sent this to Marc Steinacker 02 50 24:
It seems that when we try to add one new feature we create a bug somewhere else. A special case; an RSO, A Calendar Coordinator, and a Chairman. These privileges are causing a conflict of sorts. The RSO privilege allows you to see all the events. The Calendar Coordinator allows you to add/edit/delete Walk-Thru calendar events. The privileges are combining and you can now edit all events!

fixed


Additional constraints

Currently, only IKBallConstraint is implemented, limiting the joint in by X degrees from its origin state. The FABRIK paper describes ways to implement more complex constraints with irregular cone areas and hinge constraints, but a bit stumped on how to implement that.

Pole Vector constraints are pretty common for constraining the rotation plane of elbows and knees, etc. https://knowledge.autodesk.com/support/maya/learn-explore/caas/CloudHelp/cloudhelp/2015/ENU/Maya/files/CSCo-Pole-Vector-constraints-htm.html

I've only used them as constraints. Don't honestly know enough about the details of the rest of the things you mentioned.

The naive way to implement "pole constraints"/attractors in FABRIK is to simply pull the joints toward the attractor a little bit before doing an IK solve.   The joints preserve their "pulled" state even after the IK solve is run.   The same thing can be done for a facsimile of gravity (where each joint is just offset downward a little bit every frame, in between solves).
CCDIK might do it by rotating all of the joints to face toward the attractor (well, in the direction of the base joint to the attractor) before doing a solve.   The "pulled" state will still get preserved somewhat in CCDIK, but perhaps not as cleanly as it is in FABRIK.

hey -- so I am using this library to procedurally animate a quadruped, and since the BallConstraint isn't really suitable for limb joints, I started to add a HingeConstraint.
Seems like it's working so far, I can post more details later in a PR, but just wanted to let you know~


fix: connection typo

:tada: This PR is included in version 1.2.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Сheck for empty string

Hi guys, can't figure out how to check with vue-validator model to an empty string
<validator name="validation">
  <input type="text" v-model="name" v-validate:name="{ required: {rule: true}}">
  {{$validation.name | json}}
</validator>

If you enter only spaces, //valid": true
I can do it manual check using .trim(), but I would like to know how to do vue-validator
Is there any way to do this?
vue-validator: 2.1.3

You can use the pattern validator.
see the below url
http://jsfiddle.net/kazupon/5um0mjta/1/

Sorry, but the pattern validates only the letter 's', аnd do not miss anything else.
In your example, it is also seen http://jsfiddle.net/kazupon/5um0mjta/1/
Maybe there is a different pattern, but I can not find the right

http://jsfiddle.net/5um0mjta/2/
Now if the input is whitespace, it will be valid.
Is that what you need?

No. Sorry if I incorrectly asked the question.
I need to see if the user entered only whitespace and no other characters then valid = false

http://jsfiddle.net/5um0mjta/3/
pattern: '/\\S/' }"
Actually I think the main point is the pattern validator is worked.

Yes, this pattern works as I need. Thank you


Do not make workshop sign up pulbic

https://carpentry-uio-docs.readthedocs.io/en/latest/intro.html#contributing: The site should probably not link to the google sheet where we organise workshop, but have som text 'contact us' instead.

I agree. This link and probably the sentence should be changed to something like;
"If you wish to teach or help at upcoming workshops, please reply to the call sent to organizers @ swcarpentry dot uio dot no mailing list or contact carpadmin @ swcarpentry dot uio dot no. For more information, please refer to Carpentry@UiO onboarding checklist"

Sorry, I misunderstood and pressed "close and comment"!

Your proposed solution is very good. Could you submit a PR to that effect?

I went ahead and am preparing a PR now.

Thank you, Lex, and sorry for being behind!


packit actions should support more actions.

Packit should be able to execute more actions then one.
Like:
actions:
   pre-sync:
     - "action 1"
     - "action 2"

Feel free to take it as a good-first-issue...

this one has an easy work-around: create a script and put all the commands in there
but it's true this looks really convenient, since travis.yaml has the same thing

this one has an easy work-around: create a script and put all the commands in there

Yes, something like sh -c "one && two" should do the work as well, but this syntax looks better.
The only downside is the action that needs to return something. We can maybe get the output from the last one.

The only downside is the action that needs to return something. We can maybe get the output from the last one.

Pretty good point. Let's hold on for a bit and get some feedback on this from our users.

Here are ActionsName usage: https://github.com/packit-service/packit/blob/5ab44788e8cc999af353967e92af0e188dc96ddd/packit/api.py#L88 https://github.com/packit-service/packit/blob/f4a60ca7b4ae79ab88f77b7fe366159c5c3d1fd6/packit/base_git.py#L192

This is gonna be solved by @lbarcziova  PR #363


Binding not working on popup

I launch a modal (bootstrap) but the binding does not work.
If I put the binding in a div, I can see it is passed into modal however for the angular-trix component it does not appear.
My code is:
     $scope.editCommentDialog = function (comment) {
        var modalInstance = $modal.open({
            templateUrl: 'editCommentDialog.html',
            windowClass : 'edit-comment-modal-dialog',
            controller: function ($scope, $modalInstance, editedComment) {
                $scope.editedComment = editedComment;

                $scope.ok = function () {
                    $modalInstance.close(editedComment);
                };

                $scope.cancel = function () {
                    $modalInstance.dismiss('cancel');
                };
            },
            resolve: {
                editedComment: function () {
                   return { id : comment.id,  text : comment.text};
                }
            }
        });

        modalInstance.result.then(function (editedComment) {
            $scope.editedComment = editedComment;
            $scope.updateComment();
        }, function () {
            $log.info('Modal dismissed at: ' + new Date());
        });
    };

and

I have the exact same issue, I dont see the value specified in ng-model.

I have seen others mention this issue on other groups. Please can we get this resolved, it is the only blocker I have before my app goes live.

I have experienced a similar issue (although not the exact same one). I was able to resolve it in my case by adding ng-if="true" to the <trix-editor> element. It might help in this scenario as well.
This repo seems dead.

Thank you so much. That worked. Not sure how you found that solution but thanks once again.

ng-if="true" works perect

For me, ng-if="true" works only one way.. If I define a value in the controller for the model, it gets displayed in AngularTrix, but if I write something in trix, it doesn't update the model..

Not sure why, but ng-if="true" worked perfectly for me too! Thank you!!! (if you're still around and can explain why that works I'd LOVE to know!)


CRPS improvements: fast and unbiased kernel implementations

Modulus Pull Request
Description
Implements the unbiased (fair) versions of the CRPS formula.
This also harmonizes the CRPS implementations. Following Zamo and Naveau, the "kernel" and "sort" methods give identical answers. Also, there is a fast sort-based algorithm for the kernel formula (see the derivation in _kernel_crps_implementation). This is also used by weather bench.
I could leave the existing kcrps and _crps_from_empirical_crps formulas, but seems worthwhile to harmonize the implementations.
Zamo, M., & Naveau, P. (2018). Estimation of the Continuous Ranked Probability Score with Limited Information and Applications to Ensemble Weather Forecasts. Mathematical Geosciences, 50(2), 209–234. https://doi.org/10.1007/s11004-017-9709-7
Checklist

[x] I am familiar with the Contributing Guidelines.
[x] New or existing tests cover these changes.
[x] The documentation is up to date with these changes.
[ ] The CHANGELOG.md is up to date with these changes.
[ ] An issue is linked to this pull request.

Dependencies

@dallasfoster Will the existing tests catch an error in the numerical value of kcrps---as opposed to its asymptotic value for large ensemble size? I want to ensure this hasn't change, so may add a regression test if there isn't one already.

Thanks @nbren12, I added a regression and another finite ensemble accuracy test. LGTM.

/blossom-ci

/blossom-ci


Investigate profilers

For PaddlePaddle, we use REGISTER_TIMER_INFO to set a timer for performance tuning.
For instance, the timer in BilinearInterpLayer.cpp to statistics:
  {
    REGISTER_TIMER_INFO("FwBilinearInterpTimer", getName().c_str());
    outV->bilinearForward(*inV, inImgH_, inImgW_, outImgH_, outImgW_,
      numChannels_);
  }

But, there exist some state of the art profilers to tune performance more intuitively.
for instance, nvvp[performance analysis GUI] and nvprof [command line tools].
I will add a doc section about how to use profiler on PaddlePaddle for our teams and developers before Milestone 0.8.2.

@gangliao 是已经决定了要改用用哪个 profiler 了吗？如果已经决定过了，比如用 nvprof，那么标题可以改成 "Document Paddle profiling using nvprof"。如果还没有，标题应该是 "Investigate profilers"，然后列出你准别调研的profilers，以及对应的 URL。

@wangkuiyi
Since Paddle is heavily dependent on GPU hardwares, it's better to use NV related profilers.
nvvp and nvprof:
https://developer.nvidia.com/nvidia-visual-profiler
http://people.maths.ox.ac.uk/gilesm/cuda/lecs/NV_Profiling_lowres.pdf
http://www.robots.ox.ac.uk/~seminars/seminars/Extra/2015_10_08_JeremyAppleyard.pdf


remove redundant /v3

Thank you @jrsteele23!!

Prior to this change the URL path generated in the output docs was https://api.sendgrid.com/v3/v3/asm/suppressions/global


Customise faces using theme colours

I'd like to customise a few faces. Is it possible to access the themes' colours? For example, with the solarized theme there is a macro called solarized-with-color-variables that allows you to do this:
(solarized-with-color-variables 'dark
    (custom-theme-set-faces
      `(ivy-subdir ((,class (:foreground ,blue))))
      `(ivy-virtual ((,class (:foreground ,cyan))))))

Thanks for the great theme.

Certainly. There's (doom-color COLOR-NAME &optional TYPE):

COLOR-NAME is a symbol; any of these letvars, e.g. 'red or 'highlight.
TYPE, a symbol, tells it which version of the color to get, e.g. '256 or '16.

Examples:
(doom-color 'red)      ; => "#ff6c6b" (16-bit)
(doom-color 'red '256) ; => "#ff6655" (8-bit)
(doom-color 'red '16)  ; => "red" (4-bit)

Hope that helps!

Excellent! Thanks for the quick response. I missed that when looking through the code.

If anyone sees this issue, I created the below macro to help override some variables. It uses doom-themes--build-face which proved to be very useful. I think the -- convention means it's supposed to be private so this might break.
(defmacro my-doom-theme-set-faces (theme-name &rest faces)
  `(custom-theme-set-faces
    ,theme-name
    ,@(mapcar #'doom-themes--build-face faces)))

and then I used it like this:
(defun my-doom-one-theme-customise ()
  (my-doom-theme-set-faces
   'doom-one
   ;; base
   (cursor :background fg)
   (minibuffer-prompt :foreground fg)
   (font-lock-variable-name-face :foreground fg)
   ;; dired
   (dired-directory :foreground blue)
   ;; ivy
   (ivy-current-match :weight 'bold :background base4)
   (ivy-minibuffer-match-face-2 :foreground magenta)
   (ivy-minibuffer-match-face-3 :foreground green)
   (ivy-minibuffer-match-face-4 :foreground yellow)
   (ivy-subdir :foreground blue)
   (ivy-virtual :foreground (doom-darken fg 0.2))))

@ryankask I like that macro so much I added doom-theme-set-faces to doom-themes proper! Thanks for sharing it!


Ensure quoted fields when formatting to cue.Instance

This is basically working around an upstream CUE issue with this:
foo: {
  bar: number
  number: string
}

This is valid CUE, with the LHS number being interpreted as a label. But currently, the OpenAPI encoder in CUE stdlib behaves as though the label shadows the type keyword number. That is, it interprets the value of bar as a reference to the field labeled number, rather than as a primitive type. (TODO: open an issue on this)
Now, using number as a field name is kind of an antipattern anyway - it's good practice to quote such a label field:
foo: {
  bar: number
  "number": string
}

And, when exporting to openapi (cue def -o openapi: with whatever params), this is fine, because cue stdlib still can actually work with instances directly. We can't, though, and we have to rely on the hack of calling cue.Value.Syntax() to get what we want - and the output of that method does not preserve label quotes (TODO: open an issue on this).
So, this introduces a short term hacky hack hack to just always ensure certain keyword fields are quoted.

The actual name for things like number is "predeclared identifiers"
which kinda explains why shadowing is a thing here


Use yq to add nullables to bundle CRD

remove placeholder deployment previously used to get operator-sdk to honor the service accounts roles.
Now using operator-sdk --extra-service-accounts flag feature instead.
Nullables that we override from make manifests are now added to make bundle by default.
The format changes are a side effect of yq processing.
manifests generated from kustomize has 2 spaces for indents except for lists where it has 0 indents.
yq forces 2 spaces on lists and turn multi-line description into a single line.
file now affected by yq formatting

dpa crd

file no longer affected by yq formatting

csv

Codecov Report

Merging #796 (284df8e) into master (4c1c497) will decrease coverage by 0.29%.
The diff coverage is 36.36%.

@@            Coverage Diff             @@
##           master     #796      +/-   ##
==========================================
- Coverage   31.98%   31.68%   -0.30%
==========================================
  Files          16       16
  Lines        3064     3080      +16
==========================================
- Hits          980      976       -4
- Misses       1993     2012      +19
- Partials       91       92       +1

Impacted Files
Coverage Δ

controllers/validator.go
55.26% <0.00%> (-5.61%)
:arrow_down:

controllers/velero.go
47.98% <11.11%> (-0.64%)
:arrow_down:

pkg/credentials/credentials.go
21.68% <58.33%> (-2.01%)
:arrow_down:

controllers/datamover.go
12.99% <75.00%> (+0.45%)
:arrow_up:

controllers/restic.go
48.71% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

/retest

/test 4.9-operator-e2e-aws

Checked https://yamldiff.com/

/test 4.8-operator-e2e-azure
/test 4.9-operator-e2e-gcp

/retest

@kaovilai is there an issue associated w/ this?

@weshayutin Nullable was manually added to CustomResourceDefinition for https://issues.redhat.com/browse/OADP-535.
It has to be constantly overridden after running make bundle because it is not a default expected output from the generated CustomResourceDefinition.
This PR automates and preserves the desired nullable overrides in the CRD.

Locally tested the PR w/ make deploy-olm
WFM :)

/LGTM

/cherrypick oadp-1.1


Symplify\CodingStandard\Fixer\Commenting\ParamReturnAndVarTagMalformsFixer generate wrong phpdoc

Fixer convert @param $b string|null to @param string $b|null
-    /**
-     * @param $a string
-     * @param $b string|null
-     * @return string
-     */
-    public function test($a, string $b = null): string
-    {
-        return $a . $b;
+    }
+
+    /**
+     * @param string $a
+     * @param string $b|null
+     */
+    public function test($a, string $b = null): string
+    {
+        return $a . $b;
     }

Hi, thanks for reporting.
We'll need a failing fixture in ParamReturnAndVarTagMalformsFixerTest

@TomasVotruba  sorry, i never used fixtures in my tests - can't help :(

No worries, it's pretty easy - copy one of these files and add your content: https://github.com/symplify/symplify/tree/d116783307b4e0d3746c75a647c71ad59506c6ca/packages/coding-standard/tests/Fixer/Commenting/ParamReturnAndVarTagMalformsFixer/Fixture

@TomasVotruba is "before" ----- "after"? why wrong5.php.inc is wrong test?

That's very old fixture. It should be split into 4 smaller one to be more readable.
-/** @var $variable int */
+/** @var int $variable */
 $variable = 5;

Type must be before variable name, or some IDEs/analyzers won't get it.


Card components

Takes care of the following Card issue #14

Coverage remained the same at 100.0% when pulling c739971d0392ec3029a400b6827cc9375af6ae25 on card-components into ff09c6457ddeb0e0877a2a20c5dd0cf8e8c8c304 on master.

Coverage remained the same at 100.0% when pulling c739971d0392ec3029a400b6827cc9375af6ae25 on card-components into ff09c6457ddeb0e0877a2a20c5dd0cf8e8c8c304 on master.


Update README.md - Added  GTK dependency instruction for Fedora

Description
Just added the gtk  dependency instruction for fedora
Checklist

[ ] All tests are passing
[ ] New tests were created to address changes in pr (and tests are passing)
[x] Updated README and/or documentation, if necessary

Thanks for contributing!

Thank you :slightly_smiling_face:


Remove SetWrapForced from AdaptDispatch::_WriteToBuffer

From what I understand, a row should only be marked as force-wrapped if we actually wrote past the last column, which naturally occurs already in the AdaptDispatch::_DoLineFeed call.
Removing the SetWrapForced call however breaks these unit tests:
ConptyOutputTests::InvalidateUntilOneBeforeEnd
TerminalCoreUnitTests::ConptyRoundtripTests::BreakLinesOnCursorMovement#metadataSet0
TerminalCoreUnitTests::ConptyRoundtripTests::BreakLinesOnCursorMovement#metadataSet1
TerminalCoreUnitTests::ConptyRoundtripTests::BreakLinesOnCursorMovement#metadataSet2
TerminalCoreUnitTests::ConptyRoundtripTests::BreakLinesOnCursorMovement#metadataSet3
TerminalCoreUnitTests::ConptyRoundtripTests::BreakLinesOnCursorMovement#metadataSet4
TerminalCoreUnitTests::ConptyRoundtripTests::BreakLinesOnCursorMovement#metadataSet5
TerminalCoreUnitTests::ConptyRoundtripTests::BreakLinesOnCursorMovement#metadataSet6
TerminalCoreUnitTests::ConptyRoundtripTests::ResizeRepaintVimExeBuffer
TerminalCoreUnitTests::ConptyRoundtripTests::WrapNewLineAtBottom#metadataSet6
TerminalCoreUnitTests::ConptyRoundtripTests::WrapNewLineAtBottom#metadataSet7
TerminalCoreUnitTests::ConptyRoundtripTests::WrapNewLineAtBottom#metadataSet8
TerminalCoreUnitTests::ConptyRoundtripTests::WrapNewLineAtBottomLikeMSYS#metadataSet6
TerminalCoreUnitTests::ConptyRoundtripTests::WrapNewLineAtBottomLikeMSYS#metadataSet7
TerminalCoreUnitTests::ConptyRoundtripTests::WrapNewLineAtBottomLikeMSYS#metadataSet8

They break because when a ROW is not marked as force-wrapped the output behavior of the VtEngine and its output changes. We need to investigate why they break, what the correct behavior should be and how we can fix it. Presumably most unit tests simply assert the wrong behavior, but it's also possible that VtEngine::_PaintUtf8BufferLine and its removeSpaces variable may have to be updated.

/dup #17225


[stable/distributed-jmeter] Improve upgrade instructions in NOTES.txt

Signed-off-by: govargo<EMAIL_ADDRESS>What this PR does / why we need it:
This PR improves the upgrade instructions in NOTES.txt
Fix label selector in NOTES.txt
This is useful and awesome Chart.
This enable to use distributed jmeter easily.
When I install this chart to K8s Cluster, It show usage jmeter.
I found bug. due to unmatch label selector.
This PR fix it.
Which issue this PR fixes
(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)

fixes #

Special notes for your reviewer:
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

[x] DCO signed
[x] Chart Version bumped

/assign @pedrocesar-ti

cc @pedrocesar-ti
/ok-to-test

/lgtm


Update readme for Microsofr.Security - separate Vulnerability Assessment API changes in a different tag

ARM API Information (Control Plane)
MSFT employees can try out our new experience at OpenAPI Hub  - one location for using our validation tools and finding your workflow.

Azure 1st Party Service can try out the Shift Left experience to initiate API design review from ADO code repo.  If you are interested, may request engineering support by filling in with the form https://aka.ms/ShiftLeftSupportForm.
Changelog
Add a changelog entry for this PR by answering the following questions:

What's the purpose of the update?

[ ] new service onboarding
[ ] new API version
[ ] update existing version for new feature
[ ] update existing version to fix swagger quality issue in s360
[x] Other, please clarify
Update the readme in order to create a new .NET SDK for vulnerability assessment changes only.

When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.

When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.

By default, Azure SDKs of all languages (.NET/Python/Java/JavaScript for both management-plane SDK and data-plane SDK, Go for management-plane SDK only ) MUST be refreshed with/after swagger of new version is published. If you prefer NOT to refresh any specific SDK language upon swagger updates in the current PR, please leave details with justification here.

Contribution checklist (MS Employees Only):

[ ] I commit to follow the Breaking Change Policy of "no breaking changes"
[ ] I have reviewed the documentation for the workflow.
[ ] Validation tools were run on swagger spec(s) and errors have all been fixed in this PR. How to fix?

If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist

Applicability: :warning:
If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

Change to data plane APIs
Adding new properties
All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

[ ] Check this box if any of the following apply to the PR so that the label "ARMReview" and "WaitForARMFeedback" will be added by bot to kick off ARM API Review.  Missing to check this box in the following scenario may result in delays to the ARM manifest review and deployment.

Adding a new service
Adding new API(s)
Adding a new API version
-[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits. You can use OpenAPIHub to initialize the PR for adding a new version. For more details refer to the wiki.

[x] Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

[ ] If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist
If you have any breaking changes as defined in the Breaking Change Policy, request approval from the Breaking Change Review Board.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Additional details on the process and office hours are on the Breaking Change Wiki.
NOTE: To update API(s) in public preview for over 1 year (refer to Retirement of Previews)
Please follow the link to find more details on PR review process.

@GalGoldi72 - Is the PR created with all the files modified? I only see the readme.md file chnaging. Please confirm

@GalGoldi72 - Is the PR created with all the files modified? I only see the readme.md file chnaging. Please confirm

Yes,
I wanted to generate .NET SDK that includes just my API changes.
I was told that I can do that If I'll create a new "tag" that includes just my changes.


Minor improvements to contributors guide

Fixed a couple markdown links and trimmed a few more words
to make things a bit less wordy.

Codecov Report

Merging #946 into topic/contributing-refactor will increase coverage by 3.84%.
The diff coverage is n/a.

@@                       Coverage Diff                       @@
##           topic/contributing-refactor     #946      +/-   ##
===============================================================
+ Coverage                        65.08%   68.93%   +3.84%
===============================================================
  Files                              243      243
  Lines                             5806     5460     -346
  Branches                           624      593      -31
===============================================================
- Hits                              3779     3764      -15
+ Misses                            2027     1696     -331

Impacted Files
Coverage Δ

.../scala/org/http4s/testing/ArbitraryInstances.scala
53.33% <ø> (-40.01%)
:x:

core/src/main/scala/org/http4s/Uri.scala
83.63% <ø> (-3.64%)
:x:

...la/org/http4s/client/blaze/BlazeClientConfig.scala
100% <ø> (+4.54%)
:white_check_mark:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7c5e5e1...d08ccef. Read the comment docs.


[Doc] Added instruction to README

Description
Hi! I recently went through the build process described in the README, and found that telling the user to change into the swift directory could be helpful.
The build instructions start by putting the user in a swift-source directory (and has the user run a script where the path goes into the swift directory, in the Via HTTPS and Via SSH section), but the next section for Building Swift has the user using scripts from the utils folder without telling them to switch into the swift directory (or prefixing swift/ to the commands).
This is a tiny bit of documentation change for hopefully a bit more clear instructions.

Sure, changing directories or prefixing swift/ to the invocation should be fine.  It is pretty likely that most people will want to work on Swift rather than the core libraries, so this isn't particularly bad.

@swift-ci please smoke test and merge

@srcmake can you instead prefix ./swift to the lines? That is how people generally work?

@gottesmm Sure, I'll make another PR that undoes this change and instead appends ./sift in the places that require them if you think it's more appropriate.

@srcmake Thank! I appreciate it = ). That is what we have been standardizing upon for a minute.