Cannot find module react-scripts

Description
Fail to run create-react-app.cmd.
Expected behavior
create-react-app.cmd should create a react project without errors.
Actual behavior
PS D:\git> create-react-app.cmd r
Creating a new React app in D:\git\r.
Installing packages. This might take a couple minutes.
Installing react-scripts...
Error: Could not find or load main class add
module.js:472
throw err;
^
Error: Cannot find module 'D:\git\r\node_modules\react-scripts\package.json'
at Function.Module._resolveFilename (module.js:470:15)
at Function.Module._load (module.js:418:25)
at Module.require (module.js:498:17)
at require (internal/module.js:20:19)
at checkNodeVersion (C:\Users\myh\AppData\Roaming\npm\node_modules\create-react-app\index.js:225:21)
at C:\Users\myh\AppData\Roaming\npm\node_modules\create-react-app\index.js:179:5
at ChildProcess. (C:\Users\myh\AppData\Roaming\npm\node_modules\create-react-app\index.js:165:5)
at emitTwo (events.js:106:13)
at ChildProcess.emit (events.js:191:7)
at ChildProcess.cp.emit (C:\Users\myh\AppData\Roaming\npm\node_modules\create-react-app\node_modules\cross-spawn\lib\enoent.js:40:29)
Environment

npm ls react-scripts:
D:\git
-- (empty)
node -v:  v7.4.0
npm -v: 4.1.1
Operating system: Windows 10 Enterprise 64-bit build 14393.576
Browser and version: Firefox 50.1.0
create-react-app: 1.0.2

Run npm install in D:\git\r\.
It seems that npm failed for some reason.

Hi gaearon,
I tried. Unfortunately, I got nothing useful information.
This is the package.json generated by the failed run of  create-react-app.cmd r
{
"name": "r",
"version": "0.1.0",
"private": true
}

I see, that’s frustrating. We need to add better error handling for npm failures.
In the meantime please copy and paste this into your package.json:
{
  "name": "r",
  "version": "0.1.0",
  "private": true,
  "devDependencies": {
    "react-scripts": "0.8.4"
  },
  "dependencies": {
    "react": "^15.4.2",
    "react-dom": "^15.4.2"
  },
  "scripts": {
    "start": "react-scripts start",
    "build": "react-scripts build",
    "test": "react-scripts test --env=jsdom",
    "eject": "react-scripts eject"
  }
}

Sorry for the trouble.

Hi gaearon,
npm install run well with the fixed package.json. However, npm start failed:

<EMAIL_ADDRESS>start D:\git\r
react-scripts start

Could not find a required file.
Name: index.html
Searched in: D:\git\r\public
npm ERR! Windows_NT 10.0.14393
npm ERR! argv "L:\nodejs\node.exe" "C:\Users\myh\AppData\Roaming\npm\node_modules\npm\bin\npm-cli.js" "start"
npm ERR! node v7.4.0
npm ERR! npm  v4.1.1
npm ERR! code ELIFECYCLE
npm ERR<EMAIL_ADDRESS>start: react-scripts start
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>start script 'react-scripts start'.
npm ERR! Make sure you have the latest version of node.js and npm installed.
npm ERR! If you do, this is most likely a problem with the r package,
npm ERR! not with npm itself.
npm ERR! Tell the author that this fails on your system:
npm ERR!     react-scripts start
npm ERR! You can get information on how to open an issue for this project with:
npm ERR!     npm bugs r
npm ERR! Or if that isn't available, you can get their info via:
npm ERR!     npm owner ls r
npm ERR! There is likely additional logging output above.
npm ERR! Please include the following file with any support request:
npm ERR!     D:\git\r\npm-debug.log

Right, my fault. I forgot it also calls an initialization script.
Really, the easiest way to fix it would be to run create-react-app again with a different folder. If npm exits successfully then it should work fine.

Hi gaearon,
I run create-react-app.cmd r2, but I still got "Cannot find module ... react-scripts."

OK, I think I understand the issue now.
You have something called yarn on your system which is a Java program.
Create React App detects it as Yarn package manager and attempts to use its add command.
This is the same issue as https://github.com/facebookincubator/create-react-app/issues/1257. As a temporary workaround you can remove yarn from your path. I understand it’s inconvenient. Would you like to submit a PR for detection code to use yarnpkg instead as described here?
cc @fson

Hi gaearon,
You are right. There is a yarn of Hadoop in my path. Thank you.
Additionally, unfortunately, I have no idea at this time about how to differentiate yarn of yarnpkg from yarn of Hadoop.

Additionally, unfortunately, I have no idea at this time about how to differentiate yarn of yarnpkg from yarn of Hadoop.

We should just use yarnpkg alias instead of yarn when feature detecting. This should be unambiguous enough.

I can make a PR with the change to yarnpkg in a moment.

This should be fixed now.
Please update the global command:
npm install -g<EMAIL_ADDRESS>
This will fix the issue in newly created projects.

Thanks.

When I just installed the latest react-global-app, I also saw this issue... had to specify<EMAIL_ADDRESS>exactly to get past it. (Strangely, there is no yarn in my PATH, though I did install it on this machine at some point.)

I was able to run "npm install" by using it on the Power Shell. When I was running in the atom Terminal it was no installing all the dependencies

what i did was edit my package.json file:
"scripts": {
    "start": "node node_modules/react-scripts/scripts/start.js",
    "build": "node node_modules/react-scripts/scripts/build.js",
    "test": "node node_modules/react-scripts/scripts/test.js",
    "eject": "node node_modules/react-scripts/scripts/eject.js"
  }


Rationalize colours and document them

It seems we have quite a lot of colours in here that may not be in use or are repeated: https://www.figma.com/design/qr8jQnxqJkRJFQnVC5PmrB/ILO-Foundations?node-id=1406-438&t=BAOv58LZKk9go8Bw-0
We should:

Review all the colours in the ILO Foundations and check whether they're used
Remove the ones that are not used or are duplicates
Come up with better names and document how they should be used
Ensure what we have in ILO Foundations is reflected here:
https://twig.ui.ilo.org/?path=/docs/tokens-colors--page

cc @justintemps

@justintemps do you know if we use them all on code? Because we might not be using them on design, but maybe on dev side we are. I'll put the ones we use on design as well

Hey @justintemps just a follow up, I checked that we are not using these colors. Is this right in dev as well?

@justintemps Please see Beatriz's question above.

Hi @justintemps @Shashika6 Could you please get back to Beatriz on the question above?

@justintemps Hey Justin is there a way to know if these colors are being used on the product? We don't have them listed here but there's a few colors missing anyway so don't know where to look for a source of truth

Hi there @beatrizmartinmartins,
These are the only colors that the Design System should be using.
  --ilo-color-white: rgba(255, 255, 255, 1);
  --ilo-color-blue: rgba(30, 45, 190, 1);
  --ilo-color-blue-lighter: rgba(235, 245, 253, 1);
  --ilo-color-blue-light: rgba(190, 220, 250, 1);
  --ilo-color-blue-dark: rgba(35, 0, 80, 1);
  --ilo-color-blue-medium: rgba(210, 213, 242, 1);
  --ilo-color-blue-ramp: rgba(30, 45, 190, 0.4);
  --ilo-color-blue-dark-ramp: rgba(35, 0, 80, 0.5);
  --ilo-color-gray-charcoal: rgba(45, 45, 45, 1);
  --ilo-color-gray-accessible: rgba(109, 109, 109, 1);
  --ilo-color-gray-light: rgba(237, 240, 242, 1);
  --ilo-color-gray-base: rgba(184, 196, 204, 1);
  --ilo-color-red: rgba(250, 60, 75, 1);
  --ilo-color-red-light: rgba(254, 216, 219, 1);
  --ilo-color-red-dark: rgba(200, 48, 60, 1);
  --ilo-color-red-ramp: rgba(250, 60, 75, 0.2);
  --ilo-color-yellow: rgba(255, 205, 45, 1);
  --ilo-color-yellow-light: rgba(255, 245, 200, 1);
  --ilo-color-yellow-ramp: rgba(255, 205, 45, 0.2);
  --ilo-color-green: rgba(140, 225, 100, 1);
  --ilo-color-green-light: rgba(232, 249, 224, 1);
  --ilo-color-green-ramp: rgba(140, 225, 100, 0.2);
  --ilo-color-turquoise: rgba(5, 210, 210, 1);
  --ilo-color-purple: rgba(150, 10, 85, 1);

There may be some other used in other places, but we're getting rid of them bit by bit and replacing them with these.

@beatrizmartinmartins I think we don't need all the colours that Justin listed above. Some of them are too similar. Also, the names need to be improved. Feel free to make suggestions for improvements.

@inesdgomes you can check here some adjustments that I have been making this week for the colors palettes

As part of our discussion, we agreed to use semantic tokens, and make sure that all the decisions we make are implemented on the components. I will be making a test for all the colors we should use from now on on a new branch


Support "keep_label" URL parameter

See https://github.com/cldf/cldfviz/blob/main/docs/text.md#references

The functionality is already there - at least in a more general way - via setting['clld_markdown_plugin'] = {'keep_link_labels': True}.


Add gcc4.9 job to CI

What I've done
Added gcc4.9 job to CircleCI.
How to test

[x] check that all jobs in CI pass

LGTM!!


nimble: Some fixes for scheduling aux tx/rx

We were few usecs off when sheduling aux on both tx and rx - now it is almost perfect.

looks good to me!


error when use the tinyvit

model = model_cls(**kwargs) if model_cfg is None else model_cls(cfg=model_cfg, **kwargs)
TypeError: init() got an unexpected keyword argument 'default_cfg'
Hi, I have met the error when I try to use the code:
from tiny_vit import tiny_vit_21m_224
model = tiny_vit_21m_224(pretrained=True)
output = model(image)

I wonder do I miss something?

Hi @AmberCheng , thanks for your attention tou our work!
It seems to be related to timm version.
Could you please upgrade timm (version>=0.4.12) by the following command?
pip install timm==0.4.12

Check the version of timm
python -c "import timm; print(timm.__version__)"

Actually, I found that the version of my timm is timm-0.6.11. And I tried the 0.4.12, it works! I appreciate for your help!

Thanks for pointing the bug out! I will make it compatible with timm-0.6.11.

The latest code supports timm>=0.6.11 now.
Close the issue. Feel free to reopen it if any problem.


Triplanar mapping breaks refraction on SpatialMaterial

Godot version:
3.0
OS/device including version:
Kubuntu 14.04
NVidia GTX 1060
Issue description:
When triplanar mapping is enabled on a material that uses refraction, the refraction disappears.
Steps to reproduce:

Create a MeshInstance and assign a refractive material to it, also turn down the albedo transparency so you can see the world behind it refracted
Turn on triplanar mapping under the UV1 panel
Notice the refraction disappears

Minimal reproduction project:
refractionbug.zip
Notice how the refraction is visible on the mesh called "works", but not the one called "broken", even though they use the same material, except for triplanar mapping turned on for the "broken" mesh.

Working refraction on the left, broken refraction on the right.

Note the line
https://github.com/godotengine/godot/blob/133942cfeb0279ca03ab9943459c5140ab1f1725/scene/resources/material.cpp#L740


Pulling pixel data from Camera class

Is there a way to access the raw pixel data from the Camera class? I know the class is just using libcamera-vid and libcaamera-still, but I'd love to be able to pull the pixel data and handle that directly. Is that way out of the scope of this library? Is there some wacky piping I can do to access that data? I don't need a live preview, just a 1D array of pixel values.

Hi @SWSpratlin that won't be possible, as, if you look at the implementation, the class only calls external commands using bash, so there is no data in Java's memory space which we could expose.

Thanks for the reply! Turns out pulling camera pixel data via Java is a bigger ask than I had initially imagined, especially after Pi moved to libcamera for their camera handling.
Is this a feature that Pi4J would be interested in pursuing?

@SWSpratlin Pi4J focuses on the GPIO-pins, so I don't think we should expand the functionality to the camera. But it still is a good idea for a separate project ;-)


Fix RTPReceiver Stop race

I saw panics like this, when an RTPTransceiver is stopped.
[signal SIGSEGV: segmentation violation code=0x1 addr=0x0 pc=0x9479b2]
goroutine 37117 [running]:
github.com/pion/srtp.(*ReadStreamSRTCP).Close(0x0, 0x0, 0x0)
        github.com/pion/srtp@v1.2.7/stream_srtcp.go:66 +0x42
github.com/pion/webrtc/v2.(*RTPReceiver).Stop(0xc011d4f3e0, 0x0, 0x0)
        github.com/pion/webrtc/v2@v2.2.4-0.20200310073244-be9fde1fd3cf/rtpreceiver.go:139 +0xfb
github.com/pion/webrtc/v2.(*RTPTransceiver).Stop(0xc000ced300, 0x1137798, 0x10)
        github.com/pion/webrtc/v2@v2.2.4-0.20200310073244-be9fde1fd3cf/rtptransceiver.go:55 +0x15a
github.com/pion/webrtc/v2.(*PeerConnection).Close(0xc0395a1d40, 0xc04a5cbbc0, 0xc7f200)

If a RTPReceiver is stopped before it ever receivers, no streams are
attached to it which can be closed. This change does adds a check
to ensure that the RTPReceivers's streams are not nil before trying to
close them.

@Sean-Der The commit message linter is too strict imo. It is often nice to include stack traces in commit messages for the purpose of people searching for the same/similar stack traces and it is impossible to format them in a way which would make the linter ok.

oh fantastic catch!

I am totally in support of moving over towards https://www.conventionalcommits.org! We have talked about it a few times, just haven't put the efforts in. You would only have to make the change in one place also, this file is deployed.
In the short term I would put a bracktrace in a new github issue.
I think the root issue is that we close received to early. Instead of here should we do it at the end of the function? We also don't have to worry about stuff piling up either because we take the lock at the start of the function.

I think the root issue is that we close received to early. Instead of here should we do it at the end of the function? We also don't have to worry about stuff piling up either because we take the lock at the start of the function.

Oh yeah that might prevent the issue - will try and update this PR accordingly.

Oh yeah that might prevent the issue - will try and update this PR accordingly.

@Sean-Der added a defer - the checks for nil are still needed, since the first open could have succeeded while only the second has failed (So technically only the check for the second stream is needed, but i guess its better to check for both to prevent bugs for potential future changes).

@longsleep fantastic work :) Yea that is perfect.
go ahead and hit the 'Rebase and merge' button when you are happy!


Add Figure Title color attribute

@rmenegaux @ssunkara1

@rmenegaux Can you review this?

Okay, so now there are two attributes, title_style and background_style. I'm open to a single dictionary, but in general, we try to keep people away from doing Javascript/CSS, so the disadvantage with a Dict is that they have to know the names and types of the attributes they want to change.

@rmenegaux @ssunkara1 Made the requested changes.

@rmenegaux Good to go

Hey, I found a small issue post-merge re: side default values, which should be the serialized form of the python default values.

Okay, will do and merge
----- Original Message -----
From: Sylvain Corlay<EMAIL_ADDRESS>To<EMAIL_ADDRESS>CC: DHRUV MADEKA<EMAIL_ADDRESS>At: 09-Jul-2016 08:41:50
Hey, I found a small issue post-merge re: side default values, which should be the serialized form of the python default values.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.


I have an article of tens of thousands of words and need to find the information I need. Can I ask questions directly after uploading the knowledge base to the workspace? Or do you add the article to the question and let the model answer it? My model supports 100k context

What would you like to see?
I have an article of tens of thousands of words and need to find the information I need. Can I ask questions directly after uploading the knowledge base to the workspace? Or do you add the article to the question and let the model answer it? My model supports 100k context

You can just ask a question. If you are not getting the answers you expect you can refer to this article:
https://docs.useanything.com/llm-not-using-my-docs


Add release number in CLI, tell you when to update.

It would be neat if the release number was added to the CLI and a way to check for the latest release and tell you if you should update.

Related issue https://github.com/codercom/code-server/issues/131


Create the server side framework.

Build the basic framework of the server side with Node.js

[x] Implement the main listening function.

[x] Return requested page\file by url.

Done. Added server.js with the main listening function.


Allow for /conf to not exist when building genesis

Because of set -e, find on a missing directory will return a non-zero exit code.  This prevents genesis from building.  Adding a || true to the command allows it to work.

Thank you for submitting this pull request, however I do not see a valid CLA on file for you. Before we can merge this request please visit https://yahoocla.herokuapp.com/ and agree to the terms. Thanks! :smile:

CLA should be ok now - I signed it.


fixed error with invalid regex

The invalid regex
string.match(/ChromeDriver (\d\.\d+)/)[1]

was causing the following error
NoMethodError - undefined method `[]' for nil:NilClass

at the following line of code
gems/webdrivers-3.2.2/lib/webdrivers/chromedriver.rb:12:in `current'

The actual reproduction in memory
string = "ChromeDriver 70.0.3538.16 (16ed95b41bb05e565b11fb66ac33c660b721f778)\n"

The modified regex below will support for when versions of the chrome driver has more than 1 digit in its first section.
string.match(/ChromeDriver (\d+\.\d+)/)[1]

I'm seeing the same issue, and this change fixes it for me as well.

@titusfortner could this and/or #20 get reviewed? Anything people can do to help?

@shepmaster 3.4.1 should be working just fine.
I should merge #20 to use latest_release, though. I forget why I moved away from that, I think it went a while without being updated a few times. Still probably the better option going forward.

So should this issue be closed?


New CLI config file

Coverage decreased (-0.08%) to 95.162% when pulling 2d4b0679d8940270a28ba4a32663fa901881f595 on cody-cli-bot-config-file into c3c000fb252459a28370760eec69697d8ace3691 on main.


Fix typo in normalized-caching.md

Summary
Fixes a small typo in normalized-caching.md

Set of changes
Only affects normalized-caching.md

Cheers! 🙌


Lack of negative testing for session resumption

Issue: There are no tests exercising the behaviour of client and server when an attempted session resumption fails. Note that such a failure is not fatal, but instead a normal handshake should be performed - this must be tested.
A simple way to forcefully trigger a graceful failure would be to modify the session ID before reconnecting in ssl_client2.c.

ARM Internal Ref: IOTSSL-2766


Consolidate configuration macros

The engine's code base has lots of macro guards, making it well-configurable. However, these macros grew somewhat organically and got named as CONFIG_{EN,DIS}ABLE_xxx, CONFIG_xxx, {EN,DIS}ABLE_xxx, JERRY_{EN,DIS}ABLE_xxx, JERRY_xxx, or modulename_xxx. Quite a mix. Moreover, right now it is encoded in some of the names of the macros whether they are enabled/disabled by default (but not in all of the names). And boolean configuration macros make their effect based on whether they are defined or not, while the rest carry their meaning via their content.
I propose to consolidate the configuration macros name and value wise, as shown in the table below:

Current macro
Proposed macro
Proposed value

ES5.1 features

CONFIG_DISABLE_BUILTINS
JERRY_BUILTINS
{0,1}

CONFIG_DISABLE_ANNEXB_BUILTIN
JERRY_ANNEXB_BUILTIN
{0,1}

CONFIG_DISABLE_ARRAY_BUILTIN
JERRY_ARRAY_BUILTIN
{0,1}

CONFIG_DISABLE_BOOLEAN_BUILTIN
JERRY_BOOLEAN_BUILTIN
{0,1}

CONFIG_DISABLE_DATE_BUILTIN
JERRY_DATE_BUILTIN
{0,1}

CONFIG_DISABLE_ERROR_BUILTINS
JERRY_ERROR_BUILTINS
{0,1}

CONFIG_DISABLE_JSON_BUILTIN
JERRY_JSON_BUILTIN
{0,1}

CONFIG_DISABLE_MATH_BUILTIN
JERRY_MATH_BUILTIN
{0,1}

CONFIG_DISABLE_NUMBER_BUILTIN
JERRY_NUMBER_BUILTIN
{0,1}

CONFIG_DISABLE_REGEXP_BUILTIN
JERRY_REGEXP_BUILTIN
{0,1}

CONFIG_DISABLE_STRING_BUILTIN
JERRY_STRING_BUILTIN
{0,1}

ES2015 features

CONFIG_DISABLE_ES2015
JERRY_ES2015
{0,1}

CONFIG_DISABLE_ES2015_ARROW_FUNCTION
JERRY_ES2015_ARROW_FUNCTION
{0,1}

CONFIG_DISABLE_ES2015_BUILTIN
JERRY_ES2015_BUILTIN
{0,1}

CONFIG_DISABLE_ES2015_CLASS
JERRY_ES2015_CLASS
{0,1}

CONFIG_DISABLE_ES2015_MAP_BUILTIN
JERRY_ES2015_MAP_BUILTIN
{0,1}

CONFIG_DISABLE_ES2015_OBJECT_INITIALIZER
JERRY_ES2015_OBJECT_INITIALIZER
{0,1}

CONFIG_DISABLE_ES2015_PROMISE_BUILTIN
JERRY_ES2015_PROMISE_BUILTIN
{0,1}

CONFIG_DISABLE_ES2015_TEMPLATE_STRINGS
JERRY_ES2015_TEMPLATE_STRINGS
{0,1}

CONFIG_DISABLE_ES2015_TYPEDARRAY_BUILTIN
JERRY_ES2015_TYPEDARRAY_BUILTIN
{0,1}

ES compatibility options

CONFIG_DISABLE_UNICODE_CASE_CONVERSION
JERRY_UNICODE_CASE_CONVERSION
{0,1}

ENABLE_REGEXP_STRICT_MODE
JERRY_REGEXP_STRICT_MODE
{0,1}

Engine features

CONFIG_ECMA_NUMBER_TYPE
JERRY_NUMBER_TYPE
{float32,float64,float,double} (was: {1,2})

JERRY_CPOINTER_32_BIT
JERRY_CPOINTER_32_BIT
{0,1}

JERRY_DEBUGGER
JERRY_DEBUGGER
{0,1}

JERRY_DISABLE_JS_PARSER
JERRY_PARSER
{0,1}

JERRY_ENABLE_ERROR_MESSAGES
JERRY_ERROR_MESSAGES
{0,1}

JERRY_ENABLE_EXTERNAL_CONTEXT
JERRY_EXTERNAL_CONTEXT
{0,1}

JERRY_ENABLE_LINE_INFO
JERRY_LINE_INFO
{0,1}

JERRY_ENABLE_LOGGING
JERRY_LOGGING
{0,1}

JERRY_ENABLE_SNAPSHOT_EXEC
JERRY_SNAPSHOT_EXEC
{0,1}

JERRY_ENABLE_SNAPSHOT_SAVE
JERRY_SNAPSHOT_SAVE
{0,1}

JERRY_SYSTEM_ALLOCATOR
JERRY_SYSTEM_ALLOCATOR
{0,1}

JERRY_VM_EXEC_STOP
JERRY_VM_EXEC_STOP
{0,1}

Engine optimizations

CONFIG_ECMA_LCACHE_DISABLE
JERRY_LCACHE
{0,1}

CONFIG_ECMA_PROPERTY_HASHMAP_DISABLE
JERRY_PROPERTY_HASHMAP
{0,1}

Data placement

JERRY_CONST_DATA
JERRY_ATTR_CONST_DATA
anything

JERRY_HEAP_SECTION_ATTR
JERRY_ATTR_GLOBAL_HEAP
anything (was: a section name)

Parser configuration

PARSER_MAXIMUM_CODE_SIZE
JERRY_PARSER_MAXIMUM_CODE_SIZE
number

PARSER_MAXIMUM_IDENT_LENGTH
JERRY_PARSER_MAXIMUM_IDENT_LENGTH
number

PARSER_MAXIMUM_NUMBER_OF_LITERALS
JERRY_PARSER_MAXIMUM_NUMBER_OF_LITERALS
number

PARSER_MAXIMUM_NUMBER_OF_REGISTERS
JERRY_PARSER_MAXIMUM_NUMBER_OF_REGISTERS
number

PARSER_MAXIMUM_STACK_LIMIT
JERRY_PARSER_MAXIMUM_STACK_LIMIT
number

PARSER_MAXIMUM_STRING_LENGTH
JERRY_PARSER_MAXIMUM_STRING_LENGTH
number

Allocator configuration

CONFIG_MEM_HEAP_AREA_SIZE
JERRY_GLOBAL_HEAP_SIZE
number (in KB)

Developer options

JERRY_VALGRIND
JERRY_VALGRIND
{0,1}

JMEM_GC_BEFORE_EACH_ALLOC
JERRY_MEM_GC_BEFORE_EACH_ALLOC
{0,1}

JMEM_STATS
JERRY_MEM_STATS
{0,1}

PARSER_DUMP_BYTE_CODE
JERRY_PARSER_DUMP_BYTE_CODE
{0,1}

REGEXP_DUMP_BYTE_CODE
JERRY_REGEXP_DUMP_BYTE_CODE
{0,1}

Notes:

Alternatively, the prefix of all configuration macros might be JERRY_CONFIG_ instead of JERRY_.
There is one 'boolean' config macro that cannot/shouldn't be rewritten to 0/1: JERRY_NDEBUG. Traditionally, the semantics of an NDEBUG that macro is defined/not-defined everywhere.
I haven't listed JERRY_GET_CURRENT_CONTEXT above as I hope it goes away soon (see #2512).
I find the value set of the existing CONFIG_ECMA_NUMBER_TYPE (1/2) somewhat counterintuitive. Thus, I've proposed to enable string values (float32,float64,float,double). I think that approach could be managed by some preprocessor magic (using ## concatenation).

Some additionally observed problems:

Not all of the above configuration options are available via the python build script and/or cmake options (i.e., they have to be passed as compiler arguments).
Not all of the above configuration options are available as feature enum labels of the engine, so they are not queryable at run-time. (Among others,) this leads to leaking macro usage into users of the engine (e.g., jerry-main, jerry-ext, or jerry-port using jerry-core macros in #ifs).
Not all of the above macros are documented at all.
Configuration macro names and cmake option names are quite unaligned, which adds one more layer to the naming mix.

Foreseen work items:

Refactoring of the jerry-core code base to rename the macros and guard code blocks based on macro values.
Follow up in the cmake build system to pass macros with values to the compiler.
Follow up in the python build tool to pass the right cmake options.
Follow up in the lit-magic-strings.inc.h generator tool (gen-magic-strings.py).
Follow up in jerry-main, jerry-port, and jerry-ext, to ensure that 'leaked' macros are used according to the new semantics.
Follow up in targets to adapt the builds (mostly: with which options cmake is called).

I think such a rework would help code quality, clarity, and maintainability. I'm also volunteering to work on this, but I'd like to get some feedback first so that it's not done in vain. So, please, let me know what you think about this in general, or about any of the details (e.g., preferred config macro names, values, etc.)
PS: I know that we have had quite some discussion about config macros before, even heated ones. I'm not afraid of putting the topic on the table again, believing that it may make the project better.

I think this is a good idea as long as we finish it completely.
One more thing: we need an easy way to enable group of features excluding some of them. E.g. I want an ES 5.1 engine except regular expressions.

@galpeter #2793 and #2903 got merged. Is follow-up planned still or did these two PR address all aspects of this issue?

The PR's merged related to this issue reworked the macro names.
So all visible and configurable macros are now have a common format. I'll close this issue.


Does this perform filename sanitation?

I'm looking for filename sanitation. For example, Windows cannot correctly handle filenames containing <, >, :, ", /, \, |, ? or *, ASCII control characters or the null byte. In addition, Windows reserves some filenames, including CON, PRN, AUX, NUL and others. Filenames in Windows cannot end in a space or a dot. macOS and Linux have their own restrictions too.
Right now, the setting "keep_original_filename" can only be set to True or False. I propose these values instead:

"filenames": "keep" that behaves like "keep_original_filename": True
"filenames": "random" that behaves like "keep_original_filename": False
"filenames": "sanitize" that will sanitize the filenames using a library like pathvalidate

Does django-middleware-fileuploadvalidation provide this functionality already? Maybe I missed it.

Hey Flimm,
thank you for reaching out!
Right now, DMF does not support filename sanitization as you describe it.
I will add it to my backlog. However, I am not sure if I will be able to integrate that feature in the near future.
You are more than welcome to open a PR and I will take a look at the changes.
Cheers


request help: How can i modify the request body with java plugin？

Issue description
How can i modify the request body with java plugin?
Environment

your apisix-java-plugin-runner version：0.4.0

request.setBody(bodyStr)，this method is not effective。
can you help me see? thank you very much

you can try the solution here:  https://github.com/gaoxingliang/apisix-java-plugin-runner/blob/encrypt-response/runner-starter/src/main/java/org/apache/apisix/plugin/runner/filter/DecryptRequestFilter.java#L78
This depends on the source code change by adding a new method changeBody to make it work.
and the readme: https://github.com/gaoxingliang/apisix-java-plugin-runner/blob/encrypt-response/readme-new.md


When the locked bundler is under 2.0, allow any version < 2

What was the end-user problem that led to this PR?
The problem was the bin stub would lock to a specific version even for a 1.x version, which was an incompatible change.
See @indirect's comment in https://github.com/rubygems/rubygems/pull/1977#issuecomment-322852799
What was your diagnosis of the problem?
My diagnosis was we needed to only pin to a specific version for 2.0+.
What is your fix for the problem, implemented in this PR?
My fix transforms any 1.x bundler version to a "< 2" constraint.

Perfect. @bundlerbot r+


x/mobile/cmd/gobind: doesn't work if vendored because the .java files are not vendored

What version of Go are you using (go version)?

$ go version
go version go1.15.6 linux/amd64

Also happens with 1.14
Does this issue reproduce with the latest release?
Yes.
What operating system and processor architecture are you using (go env)?
go env Output
$ go env
GO111MODULE=""
GOARCH="amd64"
GOBIN="/home/vaka/go/bin"
GOCACHE="/home/vaka/.cache/go-build"
GOENV="/home/vaka/.config/go/env"
GOEXE=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="linux"
GOINSECURE=""
GOMODCACHE="/home/vaka/go/pkg/mod"
GONOPROXY=""
GONOSUMDB=""
GOOS="linux"
GOPATH="/home/vaka/go"
GOPRIVATE=""
GOPROXY="https://proxy.golang.org,direct"
GOROOT="/usr/lib/go"
GOSUMDB="sum.golang.org"
GOTMPDIR=""
GOTOOLDIR="/usr/lib/go/pkg/tool/linux_amd64"
GCCGO="gccgo"
AR="ar"
CC="/usr/bin/clang"
CXX="/usr/bin/clang++"
CGO_ENABLED="1"
GOMOD="/home/vaka/go/src/github.com/datadog/datadog-agent/go.mod"
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -fno-caret-diagnostics -Qunused-arguments -fmessage-length=0 -fdebug-prefix-map=/tmp/go-build230484147=/tmp/go-build -gno-record-gcc-switches"

What did you do?

$ gobind -lang=go,java -outdir=/tmp/gomobile-work-326180131 -tags=android github.com/DataDog/datadog-agent/cmd/agent/android failed: exit status 1
failed to open Java support file: open /home/vaka/go/src/github.com/DataDog/datadog-agent/vendor/golang.org/x/mobile/bind/java/Seq.java: no such file or directory
failed to copy Java support file: invalid argument

gobind is the last version: v0.0.0-20201217150744-e6ae53a27f4f. Also fails if I use go run golang.org/x/mobile/cmd/gobind instead of using the installed version.

False alarm: I didn't vendor golang.org/x/mobile/bind

False alarm: I didn't vendor golang.org/x/mobile/bind

I don't think the root cause is #26366 (related but not the direct cause).
The go mod vendor vendors only packages the go command identifies during the build process, and golang.org/x/mobile/bind/java is a dependency added in the generated code, which the go command doesn't understand.
Can you please show us how github.com/DataDog/datadog-agent specifies dependency on golang.org/x/mobile currently?

I sent a cl that spells out the implicit dependencies in the tools' source code (cl/377754), but the current best practice (especially for gobind) is to check in the generated source code to the repository - does that work for your workflows?

This should be fixed at<EMAIL_ADDRESS>% cat main.go
package doc

import (
        _ "golang.org/x/mobile/cmd/gobind"
)
% go mod vendor
% tree vendor/golang.org/x/mobile/bind
vendor/golang.org/x/mobile/bind
├── bind.go
├── gen.go
├── genclasses.go
├── gengo.go
├── genjava.go
├── genobjc.go
├── genobjcw.go
├── implicit.go
├── java
│   ├── ClassesTest.java
│   ├── CustomPkgTest.java
│   ├── Seq.java
│   ├── SeqBench.java
....


Make OpenMTP installable by Homebrew

Many people use Homebrew and Casks to install and update software on MacOS devices. Will OpenMTP be available in homebrew?

It is available as a cask and can be installed via brew cask install openmtp.


Include selector for tree-sitter language scope

👋 Hello!
Atom recently introduced an alternative parsing engine called tree-sitter (atom/atom#16299). As a side effect of this, language grammar names will be changing. Tree-sitter grammars are currently behind a feature flag which is disabled by default.
I've added the new JavaScript grammar name to your completion provider's selector arrays to work with the new names, because I'm dogfooding tree-sitter for our team and I use this heavily 😄
With this in place I'm able to autocomplete modules with tree-sitter enabled:

Thanks for the PR!
I'll merge it in a day or so.

Hi. :smile:
The latest seem to just override the previous. Is that intended?
If it is could we squash those commits? Or I can do that on your behalf.

Sure thing 😄 Commits squashed and re-pushed.


chore: use stable firefox release in browser tests

Motivation
Closes https://github.com/ChainSafe/lodestar/issues/7307
Description
Use stable firefox release in browser tests
Their latest tag seems to refer to nightly builds (works on mac as confirmed by @nazarhussain)
❯ npx @puppeteer/browsers install firefox@latest --path /tmp
Need to install the following packages:
<EMAIL_ADDRESS>Ok to proceed? (y) y

Downloading firefox nightly_135.0a1 - 148.3 MB [====================] 100% 0.0s

but the specific version is missing for Linux which causes the CI to fail

This requires more changes, CI is still failing https://github.com/ChainSafe/lodestar/actions/runs/12416331817/job/34664977579?pr=7318#step:6:64
@lodestar/params: Vitest caught 1 unhandled error during the test run.
@lodestar/params: This might cause false positive tests. Resolve unhandled errors to make sure your tests are not affected.
@lodestar/params: ⎯⎯⎯⎯⎯⎯ Unhandled Error ⎯⎯⎯⎯⎯⎯⎯
@lodestar/params: Error: Couldn't find a matching firefox browser for tag "nightly_135.0a1" on platform "linux"
@lodestar/params:  ❯ setupPuppeteerBrowser ../../node_modules/@wdio/utils/build/node/utils.js:202:15
@lodestar/params:  ❯ process.processTicksAndRejections node:internal/process/task_queues:95:5
@lodestar/params:  ❯ startWebDriver ../../node_modules/@wdio/utils/build/node/startWebDriver.js:80:36
@lodestar/params:  ❯ WebDriver.newSession ../../node_modules/webdriver/build/index.js:18:31


Creating new story from template crashes editor

Bug Description
Creating a new story by using one of the templates completely breaks the editor.
At first glance, it appears to be due to some broken state, since the error message is Cannot read property 'elements' of undefined, where undefined is the currentPage` from the story state.
I believe we got two reports about this exact bug from testers, see #2930 and #2935.
Expected Behaviour
Creating a new story from a template should work without issues.
Steps to Reproduce

Go to "Explore Templates" in the Dashboard
Click on "Use template" on any template.
Notice how story editor is broken.

Screenshots

Additional Context

Plugin Version: 1.0.0-beta.1
Operating System: macOS
Browser: Chrome

Do not alter or remove anything below. The following sections will be managed by moderators only.
Acceptance Criteria

Implementation Brief

It might have been broken by 500cdb7854b6f32bf2c7abcfa6fbb36222a7c47e, #3094.

Assigning myself to add an E2E test for this.

Moved this to "Ready for Sprint" as I hope we can just work on it soon? Thanks @swissspidy for monitoring and filing.

@o-fernandez Well sort of, I already fixed it :-) Gonna add tests tomorrow to verify the fix and prevent future regressions.


@ifsection directive

Added @ifsection directive related to [#39]

After seeing this pull request, i checked the Illuminate\View\Factory code and noticed this method for all the laravel > 5.0 versions. This should indeed be included by the SectionsTrait.
Since for some reason i failed to notice this, i'll be going over all the code again and see if there's anything else that needs attention.
About the blade directive @ifsection . I'm not that eager to add it. I'll have some thoughts about it when i have the time next weekend. I'll get back on that topic by then.
Thanks a lot :+1:

In my haste to submit the pull request, I forgot to post the explanation to go with it. :sweat_smile:
@ifsection allows patterns like this:
panel.blade.php

    @ifsection('header')

        @yield('header')

    @endifsection

        @yield('content')

    @ifsection('footer')

        @yield('footer')

    @endifsection

example-without-footer.blade.php
@extends('panel')

@section('header')
    This is the header
@endsection

@section('content')
    This is some content
@endsection

example-without-header.blade.php
@extends('panel')

@section('content')
    This is some content
@endsection

@section('footer')
    This is the footer
@endsection

It becomes much more useful when combined with @embed
page.blade.php
@embed('panel')
    @section('header')
        This is the header
    @endsection

    @section('content')
        This is some content
    @endsection
@endembed

I agree @ifsection is probably not the ideal solution to this specific problem. A helper function would be much better as it could be used as a param within other directives. I was unable to figure out how to make one that accomplished the same thing. Do you have any alternative ideas for implementing this pattern? or how it could be done with a helper function?

My reluctance to add the directive is mostly because i don't want the package to include an X amount of directives that:

the majority will never use
can cause conflicts with existing directives for peoples application

The @minify and @markdown directives for example. But i can't remove them now anymore.
I have been considering a 'Optional directives' kind of thing. Where you need to specifically enable those optional directives in the configuration file. By doing so it's no problem to add even a 100 more directives, no matter how usefull or useless they are.

Sounds like it is time to work on a new point release.
Is there something about @ifsection you think will cause conflicts with other directives?
Do you have any alternative ideas for implementing this pattern? or how it could be done with a helper function?

Similair to the @foreach its $loop variable, i could expose something like a $embed variable, giving you access to the EmbedStack. Also its possible then to implement ArrayAccess on it and maby some __get __set magic to get stuff out of the 'EmbedStack->vars` property. At least you would be able to do something like:

    @if($embed->hasSection('header'))

        @yield('header')

    @endif

That seems like an ok solution. There are some problems with injecting variables though. Collision etc. It is also harder to read.
Is there a way to define global functions only for view rendering?

Not sure, il get back on that once i checked up on that.
Right now the $embed actually already exists, as $__env.
I'd say it should be rather easy for any developer to create a @ifsection directive that replaces with <?php if($__env->hasSection('header'): ?>
At this moment, i'm mostly in favour of adding it as 'optional directive' as mentioned previously.

@unstoppablecarl added as optional directive since 7.0.2 config/blade-extensions.php


Mistake in meta tag

--
  |

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 921295a2-2503-881a-e1a5-271f4a361053
Version Independent ID: 536665af-b365-4b16-03b6-999826ac2185
Content: Em dashes - Microsoft Style Guide
Content Source: styleguide/punctuation/dashes-hyphens/emes.md
Product: non-product-specific
GitHub Login: @pallep
Microsoft Alias: pallep

@ivancheban Thanks for flagging this! I've just fixed the meta text.


Add combined locking support for MMContainer

through withEvictionIterator function.
Also, expose the config option to enable and disable combined locking.
withEvictionIterator is implemented as an extra function, getEvictionIterator() is still there and it's behavior hasn't changed.
This is a subset of changes from: https://github.com/facebook/CacheLib/pull/172

I was reading your comment in https://github.com/facebook/CacheLib/pull/172#issuecomment-1349758485. In single-tier version, without the further change, would using combined_locking for iterator cause reduction in eviction success rate and why?

I was reading your comment in #172 (comment). In single-tier version, without the further change, would using combined_locking for iterator cause reduction in eviction success rate and why?

There are two issues with using withEvictionIterator with current design:

Current implementation of findEviction makes it pretty tricky to use withEvictionIterator - the iterator is passed from one function to another.
The length of the critical section (under MMContainer lock) inside findEviction  is pretty big. Combined locking makes the p99 latency very high (especially for readers).

The second issue is actually what started our efforts to optimize findEviction and shorten the Critical Section. We observed a very big performance drop in our initial multi-tier implementation (that followed the current findEviction logic). Our first attempt to shorten the Critical Section was this PR: https://github.com/facebook/CacheLib/pull/132 where we just wanted to mark the item as exclusive under the lock and do all other operations outside. The problem there was that the eviction success rate suffered leading us to https://github.com/facebook/CacheLib/pull/172 where performance is much better (for both single and multi-tier).
Lower eviction rate in PR 132 was due to higher chance of collision: after we marked the item and exited the critical section, someone else could have increased the ref count on that item causing us to fail. In the new design, this cannot happen because after item is marked, it's inaccessible by others.


Add FsDeviceFull and FsInsufficientPermissions to FsError

These are based on the IO error/exception types permissionErrorType and
fullErrorType from System.IO.Error. These errors seem very likely to occur
in practice. It would therefore be good to be able to distinguish these from
other IOExceptions.

The failing test on Travis CI is unrelated to this PR.

If #119 gets merged, I will update this PR.

Superseded by https://github.com/input-output-hk/ouroboros-network/pull/129 .


[V2] Drag to close Popup

This is a (multiple allowed):

[ ] bug
[x] enhancement
[ ] feature-discussion (RFC)

This is starting be a widely used UX feature in iOS. Technically what you're doing is panning. You can even exit full screen on videos like that as well on iOS 11. Here's a simple demo of what I'm talking about. This is only for horizontal movements. I couldn't find a good gif for more than that. However, you can see a much cooler version of this if you just play a video. You'll see that it follows your finger movement when you try to exit full screen. I'll take video screenshot of me doing it if necessary.

I could do something like this using animate.css library and set a popup overlay when the popup is and drag and go ... I like to call it drag and go...

The modal on Photo Browser actually has a little bit of the functionality i'm describing. I should have used a better gif though

:) 👍

Added in latest commits


OUD Backup script does not work

OUD Backup script oud_backup.sh does not work. it does remove old backups
oracle@eusoud:/u00/app/oracle/local/oudbase/bin/ [oud_eus] ./oud_backup_old.sh -v
2020-02-24_20:17:54  INFO : Load list of OUD instances
2020-02-24_20:17:54  INFO : Initiate backup for OUD instances oud_eus
./oud_backup_old.sh: line 252: 08: value too great for base (error token is "08")
./oud_backup_old.sh: line 253: 08: value too great for base (error token is "08")
./oud_backup_old.sh: line 254: % (4+1): syntax error: operand expected (error token is "% (4+1)")
2020-02-24_20:17:54  INFO : Define backup set for week 08 as

remove of old backup have to check variables to make sure the are defined korrekt.

It seems that there was an issue with date and NEW_WEEK
NEW_WEEKNO=$(date "+%U")
OLD_WEEKNO=$((${NEW_WEEKNO}-${KEEP}))
NEW_BACKUP_SET="backup_set$(( ${NEW_WEEKNO} % (${KEEP}+1)))"
OLD_BACKUP_SET="backup_set$(( ${OLD_WEEKNO} % (${KEEP}+1)))"

Date does create a number with zero prefix. Bash identified this as octal. Further calculation does not work. Make sure, that NEW_WEEKNO does not get a zero by adding a sed command
NEW_WEEKNO=$(date "+%U"|sed "s/^0*//g")
OLD_WEEKNO=$((${NEW_WEEKNO}-${KEEP}))
NEW_BACKUP_SET="backup_set$(( ${NEW_WEEKNO} % (${KEEP}+1)))"
OLD_BACKUP_SET="backup_set$(( ${OLD_WEEKNO} % (${KEEP}+1)))"

Beside this I've add a check to make sure, that nothing is deleted when OLD_BACKUP_SET is undefined.


Fix various small doxygen comments

Doxygen Updates
Description
Fix various small doxygen comments
Checklist:

[x] I have tested my changes. No regression in existing tests.
[x] My code is Linted.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Just need to format iot_logging_task.h

Since you have to fix the code style checks anyways: My one comment.
You could add "." to the end of the sentence so it looks consistent everywhere.


Implement Save and Save As

Hello, I'd like to start trying to contribute to this Windows API based frontend. I am a novice to both Rust and Windows API (I do have experience with interoping with it from .NET so it shouldn't be too bad), so if you prefer my experiments stick to my fork, I will totally understand that.
In this PR I have introduced a Save menu item. Currently it behaves as a Save as… because I was not able to make pulling out the filename from the state work yet. I will keep trying (and figure out how to use a debugger etc.), so I opened the PR already in case it would be okay to do that in two PRs, otherwise I'll push the fix to this PR as well.

Thanks for the review @raphlinus. I'll take a fresh look at the problem I had with the option fallback and post the error I'm getting here if I can't fix it. Please hold off on merging for now, I think I'll be able to resolve it.

Hey @raphlinus. I made some further changes, but it will still need more work. I've split the buttons into Save and Save As…. I implemented the correct behavior of either saving or doing Save As… if no file is open, but saving currently crashes. The JSON looks fine, I debugged it with MessageBox, but clearly there must be some difference between the filename as seen in file_save and file_save_as, because it only crashes with file_save and the JSON is otherwise identical.
I set upMSVC debugging, so now I am able to visualize some values, but it didn't really help with zeroing in on the issue. I'll keep digging to see if I can find the problem and fix it.

Hey @raphlinus, I've split the buttons into Save and Save As…. I implemented the correct behavior for Save of either saving directly or doing Save As… if no file is open.
I set upMSVC debugging and contributed the debugger setup for VS Code as well. Let me know if you want me to move that to a separate PR perhaps.
That said, this PR should be now good to review as final.

@raphlinus Do you think this can be merged?

Oops, sorry about that, and thanks for the contribution!


Windows rootfs.size-gb label is not expanding volume to specified size

Description
We are using containerd 1.6.1 as a CRI for our windows kubernetes nodes (using RKE2).
Our workload needs a rather large C:\ drive and thus in the past when we used docker we used the storage-opts to increase the size to 100GB as described here.
With containerd the only equivalent that I found was this:
https://github.com/containerd/containerd/blob/46598b8b1485a3023b548e15f1d1a7950ce4ba06/snapshots/windows/windows.go#L64
and the possibility to label a namespace through https://github.com/containerd/containerd/issues/2285.
After labeling the namespace the container still only has a 20GB root disk.
> ctr ns ls
NAME   LABELS
k8s.io
> ctr ns label k8s.io containerd.io/snapshot/io.microsoft.container.storage.rootfs.size-gb=100
> ctr ns ls
NAME   LABELS
k8s.io containerd.io/snapshot/io.microsoft.container.storage.rootfs.size-gb=100

Steps to reproduce the issue

Label k8s containerd namespace:

> ctr ns ls
NAME   LABELS
k8s.io
> ctr ns label k8s.io containerd.io/snapshot/io.microsoft.container.storage.rootfs.size-gb=100
> ctr ns ls
NAME   LABELS
k8s.io containerd.io/snapshot/io.microsoft.container.storage.rootfs.size-gb=100

Start k8s pod

cat <<EOF | kubectl apply -f -
apiVersion: v1
kind: Pod
metadata:
  name: debug-test
spec:
  containers:
  - name: debug-test
    image: mcr.microsoft.com/windows/servercore:1809
    command: ["powershell.exe"]
    args:
      - -c
      - Start-Sleep
      - -s
      - "10000"
EOF

4.Check size of C: drive:
kubectl exec -it pod/debug-test -- powershell.exe -c Get-PSDrive C
Name           Used (GB)     Free (GB) Provider      Root                                                                                CurrentLocation
----           ---------     --------- --------      ----                                                                                ---------------
Alias                                  Alias
C                   0.12         19.75 FileSystem    C:\
Cert                                   Certificate   \
Env                                    Environment
Function                               Function
HKCU                                   Registry      HKEY_CURRENT_USER
HKLM                                   Registry      HKEY_LOCAL_MACHINE
Variable                               Variable
WSMan                                  WSMan

Describe the results you received and expected
I would expect containerd to expand the default 20G disk layer to 100G as specified through the label
What version of containerd are you using?
containerd github.com/containerd/containerd v1.6.1 10f428dac7cec44c864e1b830a4623af27a9fc70
Any other relevant information
> C:\var\lib\rancher\rke2\bin\crictl.exe --runtime-endpoint npipe:////./pipe/containerd-containerd-1.6.1 info
{
  "status": {
    "conditions": [
      {
        "type": "RuntimeReady",
        "status": true,
        "reason": "",
        "message": ""
      },
      {
        "type": "NetworkReady",
        "status": true,
        "reason": "",
        "message": ""
      }
    ]
  },
  "cniconfig": {
    "PluginDirs": [
      "c:\\var\\lib\\rancher\\rke2\\bin"
    ],
    "PluginConfDir": "c:\\var\\lib\\rancher\\rke2\\agent\\etc\\cni",
    "PluginMaxConfNum": 1,
    "Prefix": "eth",
    "Networks": [
      {
        "Config": {
          "Name": "Calico",
          "CNIVersion": "0.3.1",
          "Plugins": [
            {
              "Network": {
                "cniVersion": "0.3.1",
                "name": "Calico",
                "type": "calico",
                "capabilities": {
                  "dns": true
                },
                "ipam": {
                  "type": "calico-ipam"
                },
                "dns": {
                  "nameservers": [
                    "<IP_ADDRESS>"
                  ],
                  "search": [
                    "svc.cluster.local"
                  ]
                }
              },
              "Source": "{\"DNS\":{\"Nameservers\":[\"<IP_ADDRESS>\"],\"Search\":[\"svc.cluster.local\"]},\"capabilities\":{\"dns\":true},\"cniVersion\":\"0.3.1\",\"datastore_type\":\"kubernetes\",\"etcd_ca_cert_file\":\"\",\"etcd_cert_file\":\"\",\"etcd_endpoints\":\"\",\"etcd_key_file\":\"\",\"ipam\":{\"subnet\":\"usePodCidr\",\"type\":\"calico-ipam\"},\"kubernetes\":{\"kubeconfig\":\"c:\\\\var\\\\lib\\\\rancher\\\\rke2\\\\agent\\\\calico.kubeconfig\"},\"log_level\":\"info\",\"mode\":\"vxlan\",\"name\":\"Calico\",\"nodename_file\":\"c:\\\\var\\\\lib\\\\rancher\\\\rke2\\\\agent\\\\calico_node_name\",\"policies\":[{\"Name\":\"EndpointPolicy\",\"Value\":{\"ExceptionList\":[\"<IP_ADDRESS>/16\"],\"Type\":\"OutBoundNAT\"}},{\"Name\":\"EndpointPolicy\",\"Value\":{\"DestinationPrefix\":\"<IP_ADDRESS>/16\",\"NeedEncap\":true,\"Type\":\"SDNROUTE\"}}],\"policy\":{\"type\":\"k8s\"},\"type\":\"calico\",\"vxlan_mac_prefix\":\"0E-2A\",\"vxlan_vni\":4096,\"windows_use_single_network\":true}"
            }
          ],
          "Source": "{\"cniVersion\":\"0.3.1\",\"name\":\"Calico\",\"plugins\":[{\"DNS\":{\"Nameservers\":[\"<IP_ADDRESS>\"],\"Search\":[\"svc.cluster.local\"]},\"capabilities\":{\"dns\":true},\"cniVersion\":\"0.3.1\",\"datastore_type\":\"kubernetes\",\"etcd_ca_cert_file\":\"\",\"etcd_cert_file\":\"\",\"etcd_endpoints\":\"\",\"etcd_key_file\":\"\",\"ipam\":{\"subnet\":\"usePodCidr\",\"type\":\"calico-ipam\"},\"kubernetes\":{\"kubeconfig\":\"c:\\\\var\\\\lib\\\\rancher\\\\rke2\\\\agent\\\\calico.kubeconfig\"},\"log_level\":\"info\",\"mode\":\"vxlan\",\"name\":\"Calico\",\"nodename_file\":\"c:\\\\var\\\\lib\\\\rancher\\\\rke2\\\\agent\\\\calico_node_name\",\"policies\":[{\"Name\":\"EndpointPolicy\",\"Value\":{\"ExceptionList\":[\"<IP_ADDRESS>/16\"],\"Type\":\"OutBoundNAT\"}},{\"Name\":\"EndpointPolicy\",\"Value\":{\"DestinationPrefix\":\"<IP_ADDRESS>/16\",\"NeedEncap\":true,\"Type\":\"SDNROUTE\"}}],\"policy\":{\"type\":\"k8s\"},\"type\":\"calico\",\"vxlan_mac_prefix\":\"0E-2A\",\"vxlan_vni\":4096,\"windows_use_single_network\":true}]}"
        },
        "IFName": "eth0"
      }
    ]
  },
  "config": {
    "containerd": {
      "snapshotter": "windows",
      "defaultRuntimeName": "runhcs-wcow-process",
      "defaultRuntime": {
        "runtimeType": "",
        "runtimePath": "",
        "runtimeEngine": "",
        "PodAnnotations": [],
        "ContainerAnnotations": [],
        "runtimeRoot": "",
        "options": {},
        "privileged_without_host_devices": false,
        "baseRuntimeSpec": "",
        "cniConfDir": "c:\\var\\lib\\rancher\\rke2\\agent\\etc\\cni",
        "cniMaxConfNum": 0
      },
      "untrustedWorkloadRuntime": {
        "runtimeType": "",
        "runtimePath": "",
        "runtimeEngine": "",
        "PodAnnotations": [],
        "ContainerAnnotations": [],
        "runtimeRoot": "",
        "options": {},
        "privileged_without_host_devices": false,
        "baseRuntimeSpec": "",
        "cniConfDir": "c:\\var\\lib\\rancher\\rke2\\agent\\etc\\cni",
        "cniMaxConfNum": 0
      },
      "runtimes": {
        "runhcs-wcow-process": {
          "runtimeType": "io.containerd.runhcs.v1",
          "runtimePath": "",
          "runtimeEngine": "",
          "PodAnnotations": [],
          "ContainerAnnotations": [],
          "runtimeRoot": "",
          "options": {},
          "privileged_without_host_devices": false,
          "baseRuntimeSpec": "",
          "cniConfDir": "c:\\var\\lib\\rancher\\rke2\\agent\\etc\\cni",
          "cniMaxConfNum": 0
        }
      },
      "noPivot": false,
      "disableSnapshotAnnotations": false,
      "discardUnpackedLayers": false,
      "ignoreRdtNotEnabledErrors": false
    },
    "cni": {
      "binDir": "c:\\var\\lib\\rancher\\rke2\\bin",
      "confDir": "c:\\var\\lib\\rancher\\rke2\\agent\\etc\\cni",
      "maxConfNum": 1,
      "confTemplate": "",
      "ipPref": ""
    },
    "registry": {
      "configPath": "",
      "mirrors": {
        "docker.io": {
          "endpoint": [
            "https://<removed>"
          ]
        }
      },
      "configs": {},
      "auths": {},
      "headers": {
        "User-Agent": [
          "containerd/v1.6.1"
        ]
      }
    },
    "imageDecryption": {
      "keyModel": "node"
    },
    "disableTCPService": true,
    "streamServerAddress": "<IP_ADDRESS>",
    "streamServerPort": "0",
    "streamIdleTimeout": "4h0m0s",
    "enableSelinux": false,
    "selinuxCategoryRange": 0,
    "sandboxImage": "index.docker.io/rancher/pause:3.6",
    "statsCollectPeriod": 10,
    "systemdCgroup": false,
    "enableTLSStreaming": false,
    "x509KeyPairStreaming": {
      "tlsCertFile": "",
      "tlsKeyFile": ""
    },
    "maxContainerLogSize": 16384,
    "disableCgroup": false,
    "disableApparmor": false,
    "restrictOOMScoreAdj": false,
    "maxConcurrentDownloads": 3,
    "disableProcMount": false,
    "unsetSeccompProfile": "",
    "tolerateMissingHugetlbController": false,
    "disableHugetlbController": false,
    "device_ownership_from_security_context": false,
    "ignoreImageDefinedVolumes": false,
    "netnsMountsUnderStateDir": false,
    "enableUnprivilegedPorts": false,
    "enableUnprivilegedICMP": false,
    "containerdRootDir": "C:\\ProgramData\\containerd\\root",
    "containerdEndpoint": "\\\\.\\pipe\\containerd-containerd-1.6.1",
    "rootDir": "C:\\ProgramData\\containerd\\root\\io.containerd.grpc.v1.cri",
    "stateDir": "C:\\ProgramData\\containerd\\state\\io.containerd.grpc.v1.cri"
  },
  "golang": "go1.17.2",
  "lastCNILoadStatus": "OK",
  "lastCNILoadStatus.default": "OK",
  "lastCNILoadStatus.runhcs-wcow-process": "OK"
}

Show configuration if it is related to CRI plugin.
imports = []
version = 2
root = "C:\\ProgramData\\containerd\\root"
state = "C:\\ProgramData\\containerd\\state"
plugin_dir = ""
disabled_plugins = []
required_plugins = []
oom_score = 0
temp = ""

[grpc]
  address = "\\\\.\\pipe\\containerd-containerd-1.6.1"
  tcp_address = ""
  tcp_tls_ca = ""
  tcp_tls_cert = ""
  tcp_tls_key = ""
  uid = 0
  gid = 0
  max_recv_message_size = 16777216
  max_send_message_size = 16777216

[ttrpc]
  address = ""
  uid = 0
  gid = 0

[debug]
  address = ""
  format = ""
  uid = 0
  gid = 0
  level = ""

[metrics]
  address = ""
  grpc_histogram = false

[cgroup]
  path = ""

[plugins]

  [plugins."io.containerd.gc.v1.scheduler"]
    pause_threshold = 0.02
    deletion_threshold = 0
    mutation_threshold = 100
    schedule_delay = "0s"
    startup_delay = "100ms"
  [plugins."io.containerd.grpc.v1.cri"]
    disable_tcp_service = true
    stream_server_address = "<IP_ADDRESS>"
    stream_server_port = "0"
    stream_idle_timeout = "4h0m0s"
    enable_selinux = false
    selinux_category_range = 0
    sandbox_image = "index.docker.io/rancher/pause:3.6"
    stats_collect_period = 10
    systemd_cgroup = false
    enable_tls_streaming = false
    max_container_log_line_size = 16384
    disable_cgroup = false
    disable_apparmor = false
    restrict_oom_score_adj = false
    max_concurrent_downloads = 3
    disable_proc_mount = false
    unset_seccomp_profile = ""
    tolerate_missing_hugetlb_controller = false
    disable_hugetlb_controller = false
    ignore_image_defined_volumes = false
    device_ownership_from_security_context = false
    enable_unprivileged_icmp = false
    enable_unprivileged_ports = false
    netns_mounts_under_state_dir = false
    [plugins."io.containerd.grpc.v1.cri".containerd]
      snapshotter = "windows"
      default_runtime_name = "runhcs-wcow-process"
      no_pivot = false
      disable_snapshot_annotations = false
      discard_unpacked_layers = false
      ignore_rdt_not_enabled_errors = false
      [plugins."io.containerd.grpc.v1.cri".containerd.default_runtime]
        runtime_type = ""
        runtime_path = ""
        base_runtime_spec = ""
        cni_conf_dir = "c:\\var\\lib\\rancher\\rke2\\agent\\etc\\cni"
        cni_max_conf_num = 0
        container_annotations = []
        privileged_without_host_devices = false
        pod_annotations = []
        [plugins."io.containerd.grpc.v1.cri".containerd.default_runtime.options]
      [plugins."io.containerd.grpc.v1.cri".containerd.untrusted_workload_runtime]
        runtime_type = ""
        runtime_engine = ""
        runtime_path = ""
        runtime_root = ""
        privileged_without_host_devices = false
        base_runtime_spec = ""
        cni_conf_dir = "c:\\var\\lib\\rancher\\rke2\\agent\\etc\\cni"
        cni_max_conf_num = 0
        container_annotations = []
        pod_annotations = []
        [plugins."io.containerd.grpc.v1.cri".containerd.untrusted_workload_runtime.options]
      [plugins."io.containerd.grpc.v1.cri".containerd.runtimes]
        [plugins."io.containerd.grpc.v1.cri".containerd.runtimes.runhcs-wcow-process]
          runtime_type = "io.containerd.runhcs.v1"
          runtime_engine = ""
          runtime_path = ""
          runtime_root = ""
          base_runtime_spec = ""
          privileged_without_host_devices = false
          cni_conf_dir = "c:\\var\\lib\\rancher\\rke2\\agent\\etc\\cni"
          cni_max_conf_num = 0
          container_annotations = []
          pod_annotations = []
          [plugins."io.containerd.grpc.v1.cri".containerd.runtimes.runhcs-wcow-process.options]
    [plugins."io.containerd.grpc.v1.cri".cni]
      bin_dir = "c:\\var\\lib\\rancher\\rke2\\bin"
      conf_dir = "c:\\var\\lib\\rancher\\rke2\\agent\\etc\\cni"
      max_conf_num = 1
      conf_template = ""
      ip_pref = ""
    [plugins."io.containerd.grpc.v1.cri".registry]
      config_path = ""
      [plugins."io.containerd.grpc.v1.cri".registry.mirrors]

        [plugins."io.containerd.grpc.v1.cri".registry.mirrors."docker.io"]
	        endpoint = ["<removed>"]

      [plugins."io.containerd.grpc.v1.cri".registry.auths]
      [plugins."io.containerd.grpc.v1.cri".registry.configs]
      [plugins."io.containerd.grpc.v1.cri".registry.headers]
    [plugins."io.containerd.grpc.v1.cri".image_decryption]
      key_model = "node"

    [plugins."io.containerd.grpc.v1.cri".x509_key_pair_streaming]
      tls_cert_file = ""
      tls_key_file = ""

  [plugins."io.containerd.internal.v1.opt"]
    path = "C:\\ProgramData\\containerd\\root\\opt"

  [plugins."io.containerd.internal.v1.restart"]
    interval = "10s"
  [plugins."io.containerd.internal.v1.tracing"]
    sampling_ratio = 1.0
    service_name = "containerd"

  [plugins."io.containerd.metadata.v1.bolt"]
    content_sharing_policy = "shared"

  [plugins."io.containerd.runtime.v2.task"]
    platforms = ["windows/amd64", "linux/amd64"]
    sched_core = false

  [plugins."io.containerd.service.v1.diff-service"]
    default = ["windows", "windows-lcow"]

  [plugins."io.containerd.service.v1.tasks-service"]
    rdt_config_file = ""

  [plugins."io.containerd.tracing.processor.v1.otlp"]
    endpoint = ""
    insecure = false
    protocol = ""

[proxy_plugins]

[stream_processors]

  [stream_processors."io.containerd.ocicrypt.decoder.v1.tar"]
    accepts = ["application/vnd.oci.image.layer.v1.tar+encrypted"]
    args = ["--decryption-keys-path", "C:\\Program Files\\containerd\\ocicrypt\\keys"]
    env = ["OCICRYPT_KEYPROVIDER_CONFIG=C:\\Program Files\\containerd\\ocicrypt\\ocicrypt_keyprovider.conf"]
    path = "ctd-decoder"
    returns = "application/vnd.oci.image.layer.v1.tar"

  [stream_processors."io.containerd.ocicrypt.decoder.v1.tar.gzip"]
    accepts = ["application/vnd.oci.image.layer.v1.tar+gzip+encrypted"]
    args = ["--decryption-keys-path", "C:\\Program Files\\containerd\\ocicrypt\\keys"]
    env = ["OCICRYPT_KEYPROVIDER_CONFIG=C:\\Program Files\\containerd\\ocicrypt\\ocicrypt_keyprovider.conf"]
    path = "ctd-decoder"
    returns = "application/vnd.oci.image.layer.v1.tar+gzip"

[timeouts]
  "io.containerd.timeout.bolt.open" = "0s"
  "io.containerd.timeout.shim.cleanup" = "5s"
  "io.containerd.timeout.shim.load" = "5s"
  "io.containerd.timeout.shim.shutdown" = "3s"
  "io.containerd.timeout.task.state" = "2s"

@dcantah - There are tests for no default storage size right? I'm surprised to see that this didn't work

Afaik yes, won't be home for most of today but can verify later/Monday!

Hi, thanks for the update.
Unfortunately it seems like this is not a valid annotation for a kubernetes pod:
 cat <<EOF | kubectl apply -f -
apiVersion: v1
kind: Pod
metadata:
  name: debug-test
  annotations:
    containerd.io/snapshot/io.microsoft.container.storage.rootfs.size-gb: "100"
spec:
  nodeSelector:
    kubernetes.io/os: windows
  containers:
  - name: debug-test
    image: mcr.microsoft.com/windows/servercore:1809
    command: ["powershell.exe"]
    args:
      - -c
      - Start-Sleep
      - -s
      - "10000"
EOF
The Pod "debug-test" is invalid: metadata.annotations: Invalid value: "containerd.io/snapshot/io.microsoft.container.storage.rootfs.size-gb": a qualified name must consist of alphanumeric characters, '-', '_' or '.', and must start and end with an alphanumeric character (e.g. 'MyName',  or 'my.name',  or '123-abc', regex used for validation is '([A-Za-z0-9][-A-Za-z0-9_.]*)?[A-Za-z0-9]') with an optional DNS subdomain prefix and '/' (e.g. 'example.com/MyName')

I cant really find an issue with the annotation when reading the error message but according to k8s documentation https://kubernetes.io/docs/concepts/overview/working-with-objects/annotations/ the format of an annotation has to be example.com/keyname: value which the containerd.io/snapshot/io... breaks.
Am I missing something here?

Am I missing something here?

No I don't think you are.. This was probably an oversight of just expecting the looseness of containerds label format to "just work" for k8s annotations. Looking here if after splitting by a forward slash you end up with > 2 sections of the annotation (which in this case we'd end up with 3) it will fail validation https://github.com/kubernetes/kubernetes/blob/0b8a665d508a861713398d0480e4789802c70607/staging/src/k8s.io/apimachinery/pkg/util/validation/validation.go#L43.
Using --validate=false also doesn't do the trick here (and wouldn't be recommended either). We'll probably need to swap to actually using the containerd labels concept here instead of inheriting from the cri annotations, as they would've never made it that far

I think the problem here stems from how we test our cri interactions for this https://github.com/microsoft/hcsshim/blob/51aee6bd9e4da920dd6473137929370606402ad1/test/cri-containerd/runpodsandbox_test.go#L783. We just call the cri entry point to Containerd directly and don't go through k8s, so the annotation validation is skipped entirely.

Truthfully, this might make sense as a new cri field on the WindowsContainerConfig, but in the meantime we'll need to think about how we can get this to work here

Facing the same issue, Is there a workaround available for this?

Truthfully, this might make sense as a new cri field on the WindowsContainerConfig, but in the meantime we'll need to think about how we can get this to work here

I added a new field with https://github.com/kubernetes/kubernetes/pull/108894 which will be in k8s v1.24.0 cri-api

This change adds support to use Mark's new field added to CRI https://github.com/containerd/containerd/pull/6918

@dcantah Merged the PR above. Can we close this issue now?

Thanks for taking care of this.

hi, can someone please explain, how we can set this in kubernetes? We have windows containers, that need more than 20gb root-fs size, but im unable to find out, what kubernetes label or annotation to set. thanks @dcantah

hi, can someone please explain, how we can set this in kubernetes? We have windows containers, that need more than 20gb root-fs size, but im unable to find out, what kubernetes label or annotation to set. thanks @dcantah

Currently this cannot be set in Kubernetes. There is a discussion in https://github.com/kubernetes/kubernetes/pull/109702 about this.
For now - can you try using EmptyDir volume mounts for your workloads in K8s?

hi, can someone please explain, how we can set this in kubernetes? We have windows containers, that need more than 20gb root-fs size, but im unable to find out, what kubernetes label or annotation to set. thanks @dcantah

Currently this cannot be set in Kubernetes. There is a discussion in kubernetes/kubernetes#109702 about this.
For now - can you try using EmptyDir volume mounts for your workloads in K8s?

Using an emptyDir works great, thank you!

@philipp1992 How can we increase C: drive space with emptydir , Can you please help me understand


create a local sandbox transit gateway

An issue has been identified due to the process of testing Transit Gateway peering using the Sandbox account.
details:
Transit Gateway peering of two Transit Gateways in the same region is not supported yet in London (eu-west-2).

Reviewed Transit Gateway peering workaround using a routing VPC with two routing subnets.
The solution worked but had several reasons to justify it's use

Complex routing due to the fact that the default route on Mod Plaformform is used for NAT gateway
Increased cost of Transit Gateway connections
Increased cost of Transit Gateway traffic
This solution will have to be undone when AWS implement the Same Region Peering in Q4 2021

For the above reasons this solution has been parked for now, this can be implement if Transit Gateway Peering is urgently required.


Support additional include paths for kernels

Allow users to pass additional shader include search paths when creating mesh, compute, graphics or raytracing kernels.
Parameters are optional, same as with defines.

Would it make sense to add the include paths in at the program level instead of kernel? Programs already have the shader path so include paths may make more sense there. This also reduces the number of places that include paths need to be added as its just in one location. This is more of a design decision so @gboisse what do you think?

Discussed it with @gboisse and we decided to pass additional shader include paths to programs instead of kernels.


Update to use melange.emit and library

This PR updates the template to use dune melange.emit and libraries, leveraging the improvements added to Dune & Melange integration, as well as Melange stdlib, during last months 🎉

We will have to update melange-re/melange pipeline after merging this PR, so these commands reflect what we do in CI now in the template:
https://github.com/melange-re/melange/blob/main/.github/workflows/opam-build.yml#L70-L80
Will prepare a PR for that.


Add option to change backpack equipment behavior

Default: Like it is now
Instant: One left-click will equip it (how Charset did it)
Rightclick: Like Instant, but a right-click

This may be useful on servers with protection plugins / mods that disallow block breaking.

Additionally, changing the unequip behavior should be considered as well:

Just wish there was an option to remove the bag that wasn't bound to sneak. The amount of times I placed my bag without wanting to induced painful levels of facepalm.

So perhaps a second keybind (that defaults to Shift + B) or reusing the existing one (Sneak + ) to place the backpack instead of sneak + right click would be useful.


Netflix play title not working correctly

Preconditions

[X] Requirements fulfilled
[X] The known issues did not answer my question
[X] The question has not been asked in the past or the answer does not satisfy me
[X] There is currently no other opened issue that matches my question
[X] I cannot find any answer to my question in GitHub discussions

Current Situation
Hello! When trying to use the custom input URIs i try to play https://www.netflix.com/watch/81232320, however it just opens the netflix app but does not play the show
Logs
n/a

Configuration
{
            "name": "Apple TV Enhanced",
            "deviceStateDelay": 0,
            "remoteKeysAsSwitch": [
                "down",
                "home",
                "left",
                "play",
                "right",
                "select",
                "turn_off",
                "turn_on",
                "up"
            ],
            "avadaKedavraAppAmount": 15,
            "customInputURIs": [
                "https://www.netflix.com/watch/81232320",
                "https://www.netflix.com/watch/81001554"
            ],
            "disableVolumeControlRemote": false,
            "absoluteVolumeControl": true,
            "setTopBox": false,
            "discover": {
                "multicast": true
            },
            "forceVenvRecreate": false,
            "logLevel": 3,
            "updateCheckLevel": "stable",
            "updateCheckTime": 3,
            "deviceSpecificOverrides": [
                {
                    "overrideMediaTypes": false,
                    "overrideDeviceStates": false,
                    "overrideDeviceStateDelay": false,
                    "deviceStateDelay": 0,
                    "overrideRemoteKeysAsSwitch": false,
                    "overrideAvadaKedavraAppAmount": false,
                    "avadaKedavraAppAmount": 15,
                    "overrideCustomInputURIs": false,
                    "overrideDisableVolumeControlRemote": false,
                    "disableVolumeControlRemote": false,
                    "overrideAbsoluteVolumeControl": false,
                    "absoluteVolumeControl": false,
                    "overrideSetTopBox": false,
                    "setTopBox": false
                }
            ],
            "platform": "AppleTVEnhanced"
        }
    ]
}

Operating System
Linux
Operating System: Bits
64-bit
Operating System: Distribution
Raspbian GNU/Linux Bullseye (11)
Operating System: Distribution Version
Raspbian GNU/Linux Bullseye (11)
Docker
no
Docker Image
None
Docker Image Tag
No response
Homebridge Version
1.8.4
Homebridge Config UI Version
4.56.4
Homebridge Storage Path
/var/home
Homebridge Apple TV Enhanced Version
v1.5.0
Node Version
v20.16.0
NPM Version
10.8.1
Python Version
Python 3.9.2
PIP Version
pip 20.3.4
HDMI Hops
No response
Audio Output
no
Same Subnet
yes
Additional Context
No response

Provide debug logs.


local npm fixes

Signed-off-by: jetzlstorfer<EMAIL_ADDRESS>

Reverting some changes as the dropdown was broken. now working again.
Preview: https://deploy-preview-171--keptn-tutorials.netlify.app/


Bug: Workspace/User settings has a GUI

Description
It appears some bug was added in a recent release that introduced a GUI to the settings.json editor.
VS Code version: Code 1.27.1 (5944e81f3c46a3938a82c701f96d7a59b074cfdc, 2018-09-06T09:21:18.328Z)
OS version: Windows_NT x64 10.0.15063
Steps to Reproduce:
Ctr + ,
Expected Behavior:
Settings.json opens
Actual Behavior:
Some ridiculously convoluted GUI appears when I could just be editing a .json file

If you click the 3 dots to the right side of the settings GUI you have the ability to edit the .json file.
I agree though, why have a super easy and simple gui for changing settings when you could be manually editing a text file... /s

@davec21 I’m glad you agree

You can still use the JSON editor any time you want, and if you prefer, you can change the default by setting "workbench.settings.editor": "json"

I wasn’t aware you can change the default. Thanks for the info 🤗


MSFT_xIisHandler: Moving strings to localization file

Pull Request (PR) description
MSFT_xIisHandler: Moving strings to localization file
This Pull Request (PR) fixes the following issues

Fixes #463

Task list

[ ] Added an entry under the Unreleased section of the change log in the CHANGELOG.md.
Entry should say what was changed, and how that affects users (if applicable).
[ ] Resource documentation added/updated in README.md.
[ ] Resource parameter descriptions added/updated in README.md, schema.mof
and comment-based help.
[ ] Comment-based help added/updated.
[x] Localization strings added/updated in all localization files as appropriate.
[ ] Examples appropriately added/updated.
[ ] Unit tests added/updated. See DSC Resource Testing Guidelines.
[ ] Integration tests added/updated (where possible). See DSC Resource Testing Guidelines.
[ ] New/changed code adheres to DSC Resource Style Guidelines and Best Practices.

This change is

Please update this PR similar to https://github.com/PowerShell/xWebAdministration/pull/510.

Codecov Report

Merging #511 into dev will not change coverage.
The diff coverage is 100%.

@@           Coverage Diff           @@
##              dev     #511   +/-   ##
=======================================
  Coverage   91.39%   91.39%
=======================================
  Files          17       17
  Lines        2661     2661
=======================================
  Hits         2432     2432
  Misses        229      229

Impacted Files
Coverage Δ

...SCResources/MSFT_xIIsHandler/MSFT_xIisHandler.psm1
100% <100%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 22802e7...6f398c4. Read the comment docs.


Integration Test - Release - 2021/11/02 04:43:39

Auto create for integration test. IssueCommandFlow

#pri1

Just type '#pri3'

#pri2

#pri3

#assign PRMergerTest1

#assign NonAllowedUser

The following users don't have valid GitHub IDs, or are not collaborators on this repo: nonalloweduser

#reassign PRMergerTest2

#reassign NonAllowedUser

The following users don't have valid GitHub IDs, or are not collaborators on this repo: nonalloweduser

#please-close

GitHub user PRMergerTest2 has been removed from the MicrosoftDocs organization, so they were automatically removed as an assignee.

#unassign NonAllowedUser

#unassign PRMergerTest1


docs: improve specification clarity

@JonnyKong can you review this change?
If you cannot merge it right away, can you add a hacktoberfest-accepted tag so that it counts toward my participation?


Added kernel module compilation results

Adds Kernel modules compilation results to the ignore list.

@aarian93p do you have any supporting links that discuss why these changes are beneficial?

Yep @shiftkey
While compiling a kernel module, for each ".ko" file, a ".mod.c" and a ".mod.o" file are made which are made which will finally compile the .ko file and are useless for us cause they are made in the middle of build proccess and used for the rest of it. Thus we should ignore them, for the very same reason that we ignore .o and .ko files. Also .cmd files are temporary too (just like the previous ones). Also the last four are generated in the middle of compilation process and not useful for the developer cause it is mainly depending on the platform blah blah blah.
Hope I could express what I meant to (Bad English :D )

@aarian93p thanks!


edits and typos in fundamental_types.rst

@arnavs Also I was wondering if it's standard to do list comprehensions with spaces around the brackets? I haven't seen that before

Looks good to me. Will probably need to reset the capitalization on the comments but that's minor. @natashawatkins Not sure about the spacing, we can standardize that stuff in the later releases.


[feature request] filter orphans

Hi,
First: Thank you for your time giving us this great tool.
I would like to suggest the following feature: A filter option to filter orphan elements. I consider a element an orphan when it is not used in a view. These are already visible in the model by it's italic font, but filtering would make maintaining the model a lot easier. If it is not to much of a trouble, I would like to request also a filter option for elements that have no relations to other elements.
Thank you for taking this into consideration.
Matthijs

filtering would make maintaining the model a lot easier.

If the aim is to maintain the model by removing "orphan" elements or elements that have no relations to other elements then the following jArchi script is even easier than filtering and manually deleting them.
// jArchi script to delete orphan elements (not in a view) or elements that have no incoming or outgoing relations
$("element").forEach(element => {
    if($(element).viewRefs().isEmpty() || $(element).rels().isEmpty()) {
        element.delete();
        console.log("Deleted: " + element);
    }
});


Map H parameters through in an algorithmic rather than hand crafted way

Instead of manually mapping params through we now expect them to have a name which corresponds to the location they will end-up in in h's config.
For example:
via.h.some_option.subValue=foo
Will become:
{
    'some_option': {
        'subValue': 'foo
    }
}

We no longer attempt to cast values to the correct types. This will require a change in the client to handle that for us. We also don't attempt to interpret the case in anyway, we pass what we get.

Requires: https://github.com/hypothesis/client/issues/1957 as we have stopped casting values

I think there might be some missing context which is making this more difficult to review.

The major idea is to have a direct automated mapping from the param name and the final config location

This will require the parameters LMS is sending to change
We will not be sending via.config_frame_ancestor_level any more
There's no ticket for that yet, but the general plan is here: https://github.com/hypothesis/client/issues/1958

The second aim is to prevent us from having to update Via and Via 3 for every new parameter we add that we just want to pass through to H

If we have to cast values to different types with different defaults in Via / Via 3, this won't happen
The plan is therefore for the client to cast and apply defaults for a few reasons
It's the clients parameters, so it knows what type and default should be applied (why should Via choose the clients defaults?)
The client should really be applying it's own cleaning when reading these values anyway. If it's a problem to read a string where an int should be, the client should enforce/coerce the type

Oops. Wrong button

I've made some changes based on feedback from @seanh and @LMS007 :

It's not even H config, it's client config so that's been renamed
More doc strings
I've removed the case mapping. If we want it to be "blahBlahBlah" we can just put that in the param name too. This also means weird edge cases and exceptions don't cause us any bother

@jon-betts , I think we're ready to move forward with this, was there anything blocking this anymore? Client should be ready now.


Update 6.5.8.yaml update to make it more consistent with other Microsoft .yaml files

[✔] Have you signed the Contributor License Agreement?
[✔] Have you checked that there aren't other open pull requests for the same manifest update/change?
[✔] Have you validated your manifest locally with winget validate <manifest>, where <manifest> is the name of the manifest you're submitting?
[ ✔] Have you tested your manifest locally with winget install -m <manifest>?

Microsoft Reviewers: Open in CodeFlow

The publisher seems fine: Microsoft Corporation.


confusion between sessionUser and User.

Hello and thank you very much for this super accomplished stack !
I'm a bit confused about user object stored in session for authentication.
// app/modules/auth/auth.server.ts

import type { User } from '@prisma/client'
/**
type User = {
    id: string;
    createdAt: Date | null;
    updatedAt: Date | null;
    email: string;
    username: string | null;
    customerId: string | null;
}
*/
export const authenticator = new Authenticator<User>(authSessionStorage)

but in fact our strategies return  a more complete user
let user: {
    roles: {
        name: string;
    }[];
    image: {
        id: string;
    } | null;
} & {
    id: string;
    createdAt: Date | null;
    updatedAt: Date | null;
    email: string;
    username: string | null;
    customerId: string | null;
}

so I wonder if the distinctions requireSessionUser, requireUser are useful because they can bring confusion. and need to be perfectly synchronized.
for example following a first TOTP connection a user is created in session, he doesn't have username and customerId.
{
  "user": {
    "id": "cm3g6iqp80000yviqelw9kpil",
    "email"<EMAIL_ADDRESS>    "username": null,
    "customerId": null,
    "createdAt": "2024-11-13T17:52:48.044Z",
    "updatedAt": "2024-11-13T17:52:48.044Z",
    "image": null,
    "roles": [
      {
        "name": "user"
      }
    ]
  }
}

the user is redirected to the onboarding page and is prompted to enter a username.
after that user is updated in database.
{
  "user": {
    "id": "cm3g6iqp80000yviqelw9kpil",
    "email"<EMAIL_ADDRESS>    "username": "admin1",
    "customerId": "cus_RDB6YRIZlaar1e",
    "createdAt": "2024-11-13T17:52:48.044Z",
    "updatedAt": "2024-11-13T17:52:52.753Z",
    "image": null,
    "roles": [
      {
        "name": "user"
      }
    ]
  }
}

but user in session remain out of sync with
{
  "user": {
    "id": "cm3g6iqp80000yviqelw9kpil",
    "email"<EMAIL_ADDRESS>    "username": null,
    "customerId": null,
    "createdAt": "2024-11-13T17:52:48.044Z",
    "updatedAt": "2024-11-13T17:52:48.044Z",
    "image": null,
    "roles": [
      {
        "name": "user"
      }
    ]
  }
}

what do you think about it?
looking forward to reading you !

Hello again @lhapaipai.
As mentioned before, some of the code is from a previous Stack, and although everything works as expected, a few situations could be managed differently or in a better way.
I can't say much more right now, as it's been some time since I properly looked into the code, but as far as I remember, the user model will be updated after Onboarding, so some properties may not be there yet, as you showed in the authentication file.
Again, I plan to update the stack (improving it with the release of Remix v3), so for now, feel free to apply patches or even open a PR for the issue you mentioned (out-of-sync properties for User in session).

as you said, everything works as expected, if you plan to update the stack with the arrival of Remix v3. I will wait for that to discuss it again and apply a PR.
thanks again

Yep! In any case, if you find some areas we could improve or update before the release of Remix v3 and the stack rebuild, feel free to open an issue or even submit a PR!
Again, thanks for the care and the great messages, @lhapaipai!


nuxt build doesn't minify css

Hello
I'm a beginner in nuxt. I'm using vuetify+express out of the box setup. running nuxt build and nuxt start, my output css is not minified.
Any hint with that?
my production site https://shiru.me
Thanks

@amitgur Could you please provide more details about which part of css is not minified, because I can see minified in the link you provided.

This is the source for production as seen from the client side

and it goes like this till line 643. I'm not using postcss.
Thank you @clarkdo

This style is from vuetify, you can refer its doc for minification

Thank you @clarkdo


Cannot allocated multiple devices to pod

I was working with afxdp-plugins-for-kubernetes
For my use case i needed to attach 2 device to the pod.
I used the following deploy
apiVersion: v1
kind: Pod
metadata: name: afxdp-pod
annotations:
k8s.v1.cni.cncf.io/networks: cndp-cni-afxdp0 spec:
containers:
- name: afxdp1
image: ubuntu:latest
command: ["tail", "-f", "/dev/null"]
resources:
requests:
afxdp/mypool: '2'
limits:
afxdp/mypool: '2'
I expected that 2 devices will available for use in the pod. But inside the container, I could only see one device.
Events:
  Type    Reason          Age   From               Message
  ----    ------          ----  ----               -------
  Normal  Scheduled       13s   default-scheduler  Successfully assigned default/afxdp-pod to turing-04
  Normal  AddedInterface  10s   multus             Add eth0 [<IP_ADDRESS>/24] from cbr0
  Normal  AddedInterface  10s   multus             Add net1 [<IP_ADDRESS>/24] from default/cndp-cni-afxdp0
  Normal  Pulling         9s    kubelet            Pulling image "ubuntu:latest"
  Normal  Pulled          7s    kubelet            Successfully pulled image "ubuntu:latest" in 2.386145893s (2.386155184s including waiting)
  Normal  Created         7s    kubelet            Created container afxdp1
  Normal  Started         7s    kubelet            Started container afxdp1
This kubectl describe for the pod.
root@cndp-0-0:~# ip link
1: lo: <LOOPBACK,UP,LOWER_UP> mtu 65536 qdisc noqueue state UNKNOWN mode DEFAULT group default qlen 1000
    link/loopback 00:00:00:00:00:00 brd 00:00:00:00:00:00
2: eth0@if145: <BROADCAST,MULTICAST,UP,LOWER_UP> mtu 1450 qdisc noqueue state UP mode DEFAULT group default
    link/ether ce:0f:94:1a:d2:fc brd ff:ff:ff:ff:ff:ff link-netnsid 0
6: ens259f0: <BROADCAST,MULTICAST,UP,LOWER_UP> mtu 1500 xdp qdisc mq state UP mode DEFAULT group default qlen 1000
    link/ether 3c:fd:fe:9e:7b:5c brd ff:ff:ff:ff:ff:ff
    prog/xdp id 325 tag 992d9ddc835e5629 jited
Running ip link inside the container shows only one device
The afxdp-plugin logs show that 3 device were allocated and added to the container
DEBU[2023-07-17 06:37:47] [poolManager.go:233] [Allocate] Container environment variables: {
  "AFXDP_DEVICES": "ens259f1 ens259f0 enp7s0f0"
}
The bpf program is loaded on both the interface but the other device is still in the host namespace.

Hi Lakshyagour,
I think your issue is line ~6 of your pod spec. You need to add a second cndp-cni-afxdp0
apiVersion: v1
kind: Pod
metadata:
name: afxdp-pod
annotations:
k8s.v1.cni.cncf.io/networks: cndp-cni-afxdp0, cndp-cni-afxdp0 <<<<<<<<<<<<<<<<<<<<<<
spec:
containers:
- name: afxdp1
image: ubuntu:latest
command: ["tail", "-f", "/dev/null"]
resources:
requests:
afxdp/mypool: '2'
limits:
afxdp/mypool: '2'
restartPolicy: Never

The resource request down the bottom ultimately determines how many times the device plugin is called.
Unfortunately the cni is a completely different plugin and k8s api, so the number of times this is called is determined by the list of network attachment definitions provided to k8s.v1.cni.cncf.io/networks.
It's a little bit clunky, but it's just how we have to use DP and CNIs together.
KR,
Gary

Thank you Gary.


Microsoft auth provider manages tokens for multiple resources

Hey, I just made a Pull Request!
Highlights
Backend (auth-backend plugin):

Converted the tests for the MicrosoftAuthProvider to exercise a wider boundary, integrating with OAuthAdapter.
When the /frame/handler endpoint is called with an authorization code for a non-Microsoft Graph scope, the user profile will not be fetched. Similarly no user profile or photo data will be fetched by the backend if the /refresh endpoint is called where the scope query parameter is missing the User.Read scope from Microsoft Graph.

Frontend (core-app-api package):

when its getAccessToken method is called, MicrosoftAuth parses scopes to determine the audience of the token that azure will provision. Then it maintains a map of (audience, OAuth2) pairs so that each audience has its own notion of the current session.
MicrosoftAuth always appends an offline_access scope to any token requests, so that tokens are always refreshable.

Concern
The function MicrosoftAuth.expectedClaims is very nearly a copy-paste of the allClaimsForScope method on FakeMicrosoftAPI in the auth-backend plugin. It would be nice to store this logic in a common location shared between @backstage/core-app-api and @backstage/plugin-auth-backend, but it felt hard to justify introducing a whole @backstage/plugin-auth-common (or similar) purely for this little piece of code for parsing Azure scopes.
:heavy_check_mark: Checklist

[x] A changeset describing the change and affected packages. (more info)
[ ] Added or updated documentation
[x] Tests for new functionality and regression tests for bug fixes
[x] ~Screenshots attached (for UI changes)~ n/a
[x] All your commits have a Signed-off-by line in the message. (more info)

It's been closed for staleness, but I believe this PR actually resolves #7040

@Rugvip politely pinging for review or reassignment on this one, which is depended upon by #16627 in order to solve #13685.

@Rugvip I'm done for the week and want to push the changes I have, but I haven't finished addressing all your feedback. I'll ping again when it's truly ready


fastlane env

New Issue Checklist

[ ] Updated fastlane to the latest version
[ ] I read the Contribution Guidelines
[ ] I read docs.fastlane.tools
[ ] I searched for existing GitHub issues

Issue Description
Complete output when running fastlane, including the stack trace and command used

[INSERT OUTPUT HERE]

Environment

[INSERT OUTPUT HERE]

Huh? This seems to be pretty empty, did you file the issue by accident?

Going to close this for now 😇


Sensu plugin install fails when using URLs

The define sensu::plugin is broken at line 90 within the URL case statement.The remote_file definition is missing the source parameter. I was able to fix this with pending merge request #505.
I am little unclear why this is not breaking everyone else code. Most people not using url maybe?

This is closed with the merge of #486


tsconfig.json is not loaded properly when definitions in 'typescript' package is imported explicitly

Bug Report
🔎 Search Terms
tsconfig doesn't work
🕗 Version & Regression Information
4.1.2

This is the behavior in every version I tried, and I reviewed the FAQ for entries about 4.0 ~ 4.1.2

⏯ Playground Link
bug-demo.zip
💻 Code
tsconfig.json
{
  "compilerOptions": {
    "target": "ES2020"
  }
}

scene A
// Some third-party packages would install @types/node with it.
// if @types/node is installed,the primary definition of setTimeout would be the one in @types/node,
// which returns NodeJS.Timeout and therefore can't be assigned to a number type

let timerId: number | undefined;
timerId = setTimeout(() => {}, 0); // ❌  Type 'Timeout' is not assignable to type 'number'.ts(2322)

// At the time, the tsconfig is loaded, so flatMap (ES 2019 feature) works perfectly.
[].flatMap((item) => item); // ✅

scene B
import { setTimeout as WindowSetTimeout } from "typescript/lib/lib.dom";

let timerId: number | undefined;

//  So I'd import the window.setTimeout definition directly from typescript package, to avoid the error in assignment.
timerId = (setTimeout as WindowSetTimeout)(() => {}, 0); // ✅

//  However flatMap then reports an Error, seems tsconfig is not loaded properly.
[].flatMap((item) => item); // ❌ Property 'flatMap' does not exist on type 'never[]'. Do you need to change your target library? Try changing the `lib` compiler option to 'es2019' or later.ts(2550)

🙁 Actual behavior
tsconfig.json is not loaded properly, because flatMap is not enabled.
🙂 Expected behavior
tsconfig loaded successfully

You don’t import lib files, you add them to the "lib" array in your tsconfig.

I know I could use lib to import definitions and types to include only what I need.
However my situation, it is:

@types/node would add an overload to setTimeout
the import-from-node setTimeont is always the default choice of overload
@types/node is necessary so I can't use types to omit it
I don't feel like to change my code from setTimeout to window.setTimeout

Therefore I can only import the browser version setTimeout definition from lib file and force assign it, which makes the tsconfig not working properly.

I use ReturnType<typeof setTimeout>. Works well with dom types, node types, or the two together.

I use ReturnType<typeof setTimeout>. Works well with dom types, node types, or the two together.

It's a good idea, but it doesn't work in React.useRef, which needs a initial value. I usually write something like const refTimerId = useRef(0);

If you have "dom" in your "lib", the DOM setTimeout should be the first (and therefore default, with no context) overload. If you are referencing lib.dom.d.ts some other way (which you shouldn’t), the order might be reversed.

Whether I add dom in lib or not, import lib.dom.d.ts or not, default setTimeout is always the node one.
By the way, if this problem is cause by misuse, it'll not be given a solution?

Ok, so the flatMap thing looks weird but it’s caused by improperly referencing lib.dom.d.ts. The only way you’re supposed to reference it is via lib in your tsconfig or /// <reference lib="dom" />. Anything else will cause problems.
You’re right though, that the NodeJS setTimeout is the first overload once you actually add a second argument. The DOM one’s second argument is defined as optional while Node’s is required, so if you leave it off, you get the DOM definition. This seems slightly unfortunate to me, but it seems like people have just been working around it—see #842.
This would be fixed by the Strict Environments proposal.

I would add that the best solution is to get @types/node out of your browser compilation if at all possible. You shouldn’t need it for anything actually running in the browser, so maybe you could split your project into multiple configs, one for browser code that has "types": [] and one for Node code. The feasibility of doing that varies case by case.

I would add that the best solution is to get @types/node out of your browser compilation if at all possible. You shouldn’t need it for anything actually running in the browser, so maybe you could split your project into multiple configs, one for browser code that has "types": [] and one for Node code. The feasibility of doing that varies case by case.


#0: Watcher interval to not include polling time

This helps in cases where polling is slow (application uses links heavily), so watcher doesn't dominate the link.
CI: https://github.com/tenstorrent/tt-metal/actions/runs/9325281605
Closes #8184

I marked this as closes #8184

Same CI status as main, so should be all good: https://github.com/tenstorrent/tt-metal/actions/runs/9370799357


Store stats of scraping

After scraping, we should store stats in s3 in a stats.json file that we will be used in display on a HTML page. This should include:

Count of each data scraped.
Dates of last successfully scraped for each and date of last successful scrape as a whole.
How long each scrape took and all the scrapers.

For Debate: This info should also be pushed to Google Analytics at a later stage.

Are there any stats services / API / storage that we can benchmark off of?


Grab symbol name via API (ticker plugin)

Some suggestions from Digerati:
https://docs.quandl.com/
https://www.worldtradingdata.com/documentation

This is done through the TwelveData API already.


Re-tidy secret-generators after lint auto-correct

What
In the secret generates, we should have each secret definition on a line by itself to make it easier to read. The rubocop autocorrect went a bit OTT on these (in e24e653), which made
them a little harder to read.
How to review
Review the changes and marvel at the magnificence of the new version.
Who can review
Anyone but myself.

Looks mag-ni-fi-cent! It will also make diffs easier to read as we add more items.