Test copay

Every assignee must test and ok this before COB of Aug 5.
Please add you tOK to this issue when completed.

At least on testnet all the major features (create wallets, restore from seed, send funds, receive funds, output csv, generate QR code, change units) work for me on Firefox.
I did create a mainnet wallet but didn't do much beyond that for that one.
Couple of minor ui issues #24, #25, #26 but otherwise tACK from me.

Network fee policy in settings doesn't have any settings to actually change.  Was something supposed to be there, or can we remove it?

I went to the send view and clicked "send max" at the top to send everything, minus fees, to another wallet.  After entering the address, the "send" button lit up but when i clicked it, a "not valid" error was shown over the amount textbox and the entire screen was greyed as if there was supposed to be a modal error message shown, but there is no message.  Can't click on anything now since there's no way to hide the missing error message.  When I tested this, i had my settings set to use dbits instead of DCR, in case that matters.

After sending a transaction, the "success" message is not centered vertically and part of the "okay" button is hidden because of it.

Looks like the rendering issue is due to the scaling from the horizontal window width.  If i make my window less wide, the message slides up vertically.

So I retested (same set of things I did before) after @alexlyp's fixes and they look good.  So a real
OK
from me this time.

Everything (except for a tx item in my activity that went missing, but that seems to be due to insight bugs and is unrelated to the copay update) appears to be functional or addressed now. ok

Found an issue with Chrome which was promptly fixed.
Everything else that I tested like sending/receiving, restoring from seed, trying various options, etc. worked fine.
tACK

tok

Sync PR merged


Remove a couple of unnecessary "assert is None" statements

Those are no longer necessary

Merged as eda396376cfac603a521468c1023ff4dc265937e, after fixing the typo.  Thanks @mateuszmandera!


ci: revert concurrency group change

Description
This pull request changes the following:

the concurrency group change did not work as intended, reverting to prior changes

Related Issues

Closes #

:tada: This PR is included in version 0.25.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


CLOUDSTACK-9132: API createVolume takes empty string for name parameter

Steps to Reproduce:
Create a volume using createVolume API where parameter name is empty.
It creates a volume with empty name.
But the name parameter is mandatory.(Issue)
Expected Behaviour:
It shouldn't create a volume with an empty name. Error should be returned.
Solution:
Added a condition to check in case of empty string. If the name is an empty string, it generates a random name for the volume. Made the name field optional in UI as well as in API.

Reference PR #1273 (Against master) with 3 LGTMs. This PR (against 4.7) contains the same code change.

Hi @remibergsma, I created all my pending PRs against 4.7. Can you please review once. Thanks.

@remibergsma : Any updates on this. Thanks

Just curious. If this is the expected behavior (mentioned above):
It shouldn't create a volume with an empty name. Error should be returned.
Then it doesn't sound like this PR solves that issue as it generates a random name.
Did we decide at some point that a random name was the preferred solution?
Thanks!

@mike-tutkowski : Yes, we decided to make random name as a preferred solution. You can refer the detail conversation on this PR #1273 . Thanks for reviewing.

@remibergsma @DaanHoogland : It has got 4 LGTMs. Is it going to be merged? Should it be reviewed by some more people? Thanks.

@nitin-maharana I see two LGTM in the other PR based on code review. One without explanation and none based on testing. I can queue this but you don't want to wait on my backlog in this perspect :(
So if I missed a forth LGTM please point @remibergsma to it. He is sole RM at the moment.

@nitin-maharana We can merge this once the integration tests have run. Will put it on my list.

Sure @remi

At leaseweb we noticed the same behavior for networks. I propose we use the uuid as the name there as well. Will create a PR.

LGTM, the one error in the files below is a known error in the test environment and unrelated. This has been reviewed extensively.
1319.network.results.txt
1319.vpc.results.txt


Automatic Dimboosts - Off by one error

https://github.com/IvarK/IvarK.github.io/blob/b5d736110b5f6be8cfd29ec493c7cdd102435ada/javascripts/game.js#L6403
Function maxBuyDimBoosts() has an off-by-one error. First, it adjusts players.resets directly to perform these soft resets, and does so to the correct value. It then calls softReset(0), which autoconverts the parameter to 1, triggering an additional dim boost.
Easiest fix is calling softReset(r), rather than adjusting player.resets.

resolved with my update

as noted above


compilerOptions moduleResoluton Node16

ZodiosApp (or router) isn't properly typed when using modern module resolution strategies. When setting typescript's module resolution to "Node16" (which seems increasingly required as libraries adopt mjs), the app methods (app.get, app.post, etc) are of type any, and consequently so are the response and request parameters.
Here is a minimally reproductible example: https://gist.github.com/QuentinRoy/0f129f6e0e087b7188db0441af854e91.

Hello,
this is definitly not a bug in zodios but a bug with typescript since zodios types are perfectly exported and compatible with mjs.
For now it seems to be an issue with types not getting fully inferred accros imports.

Hi,
If I may, I believe you discarded this issue a bit too promptly. I was skeptical so I took the liberty to do some quick digging.
import { IfEquals, Narrow } from<EMAIL_ADDRESS>from index.d.ts is not exported from @zodio/core.
Adding the following in @zodios/core's package.json solves the issue. I am not sure this is what you want to do, but I am going to make the PR.
  "./lib/*": {
    "types": "./lib/*",
    "import": "./lib/*.mjs",
    "require": "./lib/*.js"
  }

Cordialement
PS : I thought "types" always had to come last in exports, but it does not seem like TS cares anymore. I am not sure if that's an awkward limitation that has been removed since, or if there might be some hidden incompatibilities somewhere.

thank you for diging this up. that was bad conclusion on my side. PR is welcomed.

This is now fixed on @zodios/core v10.7.5, thank you again for taking the time to investigate further. really appreciate the effort and kind the way you handled me closing this too fast.
To evoid it to happen again, i let you close if you confirm v10.7.5 fixes it (worked on my side)

It does seem fixed on my side. Thanks!


Update Read.me

Description
Extended the README / documentation
you had limit and it should have been the variable should be slice. Also added a start variable and added that call to the slice funciton
Checklist

[x ] Code compiles correctly
[x ] Created tests which fail without the change (if possible)
[ x] All tests passing
[ X] Extended the README / documentation, if necessary
[x ] Added myself / the copyright holder to the AUTHORS file

Coverage remained the same at 96.199% when pulling 58695856f1f4ef5cc118d9864c0d08f17c2e2371 on GeoffreyEmery:patch-1 into 06e1785def63f87e112b73b6bcd02d0a39f9ebfd on lapwinglabs:master.

Coverage remained the same at 96.199% when pulling 6be99bcf3567635573a2b1b3fad6c896f9161c2d on GeoffreyEmery:patch-1 into 06e1785def63f87e112b73b6bcd02d0a39f9ebfd on lapwinglabs:master.

Coverage remained the same at 96.199% when pulling 6be99bcf3567635573a2b1b3fad6c896f9161c2d on GeoffreyEmery:patch-1 into 06e1785def63f87e112b73b6bcd02d0a39f9ebfd on lapwinglabs:master.

thanks!


fixing lr_scheduler prepare issue when using pytorch nightly

What does this PR do?

In torch 1.14.0.dev, LR Scheduler never gets prepared. PyTorch PR that will be impacting the LR schedulers: #61232 (2 weeks ago change)
This PR fixes the above issue

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.

FYI, for anyone getting this error:
File /usr/local/lib/python3.8/dist-packages/accelerate/accelerator.py:102
    100     from torch.optim.lr_scheduler import _LRScheduler as LRScheduler
    101 else:
--> 102     from torch.optim.lr_scheduler import LRScheduler as LRScheduler
    104 logger = get_logger(__name__)
    107 class Accelerator:

ImportError: cannot import name 'LRScheduler' from 'torch.optim.lr_scheduler' (/usr/local/lib/python3.8/dist-packages/torch/optim/lr_scheduler.py)

you are likely using the latest NVIDIA NGC PyTorch release nvcr.io/nvidia/pytorch:22.12-py3 which is based on 1.14.0a0+410ce96 which was committed 4 days before the commit mentioned above.
So this currently breaks import accelerate but you can work around it like this:
import torch
torch.optim.lr_scheduler.LRScheduler = torch.optim.lr_scheduler._LRScheduler

import accelerate

Looks like we might have to add some more checks... I wish they decided on a class name and stuck to it 😅


Update wfd services to the v1 APIs

About
do not merge

Updates the wfd services to use v1 of the services.tanzu.vmware.com API
I am assuming we don't want to merge this into the wfd-spaces-beta3 branch as the v1 API is not available in beta3
I am opening this MR in draft to ready the changes that will be required for the wfd services config for GA

Beta 3 is locked down.  There will be a new branch for GA that will use the new service APIs.


Can I drag new items into SortableTree?

Hi, thank you for saving me many hours with this mini library of sorts.
So onto my question. Can I use two different SortableTrees and drag like in the example?
I think I should be able to since no major code is changed but I'm not quite sure since I'm a novice coder at best.
Cheers!

Yeah no worries. I think a way would be to expose some sort of wrapper for the general dropzones or something like that but I'm not sure at all.

Hi! Have you had any chance to look at this yet? No worries if you have not. Cheers!

yep, I checked an example in dnd-kit and it turns out it's a bit more complex.
There needs to be a <DndContext> wrapping all columns, but in this project every <SortableTree> has it's own <DndContext>.
Personally I don't see an easy way to abstract the <SortableTree> so that it could be put into a common context, sorry.
Seems like it'd be easier for you to go with dnd-kit directly


Tweaks on events page

What changed? Why?
This PR improves on the events page map component by changing markers coordinates
How has it been tested?

[x] Locally
[ ] Vercel Preview Branch
[ ] Unit test
[ ] Functional test

@lucasrmp-cb I had to create a new coords const because the markers where not being correctly centered in a lot of states. I checked every coordinate for every state to make sure that it will render correctly and with good spacing.

@lucasrmp-cb I had to create a new coords const because the markers where not being correctly centered in a lot of states. I checked every coordinate for every state to make sure that it will render correctly and with good spacing.

 Also, changing it in the original breaks anything?
And finally, can we add all this context (maybe some screenshots even) to the PR description and create an issue to have this tracked?

@lucasrmp-cb I had to create a new coords const because the markers where not being correctly centered in a lot of states. I checked every coordinate for every state to make sure that it will render correctly and with good spacing.

 Also, changing it in the original breaks anything? And finally, can we add all this context (maybe some screenshots even) to the PR description and create an issue to have this tracked?

On the Activity Map, the user doesn't have any interaction with each state, so it doesn't really matter if it not centered on the state perimeter or not. I checked with Olavo and if I understood correctly, the original coordinates points to the capital coordinates on each state, while on the events page I changed it to be more visually pleasing.


[1.x/2.x] Cannot import sbt to IDE

[error] Couldn't run bloopGenerate. The issue could be caused by failing to compile the project.
[error] java.lang.RuntimeException: found version conflict(s) in library dependencies; some are suspected to be binary incompatible:
[error]
[error] 	* com.eed3si9n:shaded-jawn-parser_2.12:1.3.2 (early-semver) is selected over 0.9.0
[error] 	    +- com.eed3si9n:sjson-new-scalajson_2.12:0.10.1       (depends on 1.3.2)
[error] 	    +- com.eed3si9n:sjson-new-scalajson_2.12:0.9.0        (depends on 0.9.0)
[error]
[error]
[error] this can be overridden using libraryDependencySchemes or evictionErrorLevel

Happens with both IntelliJ import & Metals import. Changing Metals BSP to sbt yields same error.

Oh it is sbt-bloop introducing the classic com.eed3si9n:sjson-new-scalajson_2.12:0.9.0 dependency...
Deleting all metals.sbt resolved the issue.
I guess this is truly an edge case with no good solution other than... not using bloop?

Posted an issue on Scalameta discord channel. Shall see if they can figure out some solution to this. After all importing project should just work...

Hey Metals/Bloop folks. I am trying to use bloop to import sbt build when contributing to https://github.com/sbt/sbt.
However I got hit with the following error. It seems like sbt-bloop and sbt depends on different version of sjson-new-scalajson and hence bloopGenerate crashes.
[error] Couldn't run bloopGenerate. The issue could be caused by failing to compile the project.
[error] java.lang.RuntimeException: found version conflict(s) in library dependencies; some are suspected to be binary incompatible:
[error]
[error]     * com.eed3si9n:shaded-jawn-parser_2.12:1.3.2 (early-semver) is selected over 0.9.0
[error]         +- com.eed3si9n:sjson-new-scalajson_2.12:0.10.1       (depends on 1.3.2)
[error]         +- com.eed3si9n:sjson-new-scalajson_2.12:0.9.0        (depends on 0.9.0)
[error]
[error]
[error] this can be overridden using libraryDependencySchemes or evictionErrorLevel
It was easily worked around by manually deleting all metals.sbt file and then use alternative BSP (just switching to alternative BSP in Metals setting didn't work for me, needed to manually delete). However I want to ask whether it is possible to make the UX better when sbt-bloop introduces conflicting dependency (either at Bloop side or Metals side). As, it was not obvious from the stacktrace what is the problem nor how to resolve the problem.

(https://discord.com/channels/632642981228314653/632652693013528589/1297651711036493945)


Is the timer deterministic based on code length or does it completely rely on how fast your hardware is?

The timer is real time. I'm not sure I understand your question.

It's just delta time, so completely up to how optimised your code and how fast your hardware is. Since it will probably all be ran on the same hardware, which I'm guessing will be quite powerful, there shouldn't be an issue.

It's just delta time, so completely up to how optimised your code and how fast your hardware is. Since it will probably all be ran on the same hardware, which I'm guessing will be quite powerful, there shouldn't be an issue.

alright that makes sense. i was mainly just wondering if the time per move was purely based on how much code was ran before a move was determined.


Include Brazilian breakdown per state

Brazil is a big country with many different hotspots. Including a breakdown per state (as per US, Canada, Australia) would help visualize what's happening. This should be fairly easy from the Health Ministry data (https://covid.saude.gov.br/)

problem is they don't provide no direct download link, at least not on the linked page. if you click the download csv file you get a generated temporal dl link. :/

I noticed that too... I've actually been trying to scrape their website for that CSV link for the past week, and I think I finally managed. Or until they change something again...
Scraping and final data is here:
https://github.com/felipequintella/covid19-brazil-scraper
https://raw.githubusercontent.com/felipequintella/covid19-brazil-scraper/master/brazil.csv
I've also forked covidtrends and included the breakdown there as well. If you think it is worth it, let me know and I can try a pull request.
https://github.com/felipequintella/covidtrends
Final product here:
https://covid19.felipequintella.com/

hm basically at the end it is @aatishb choice how to handle things. on one hand its cool that you provide the opportunity with scraping the existing data from the government page. but imho i would be careful never the less about any further step for data aggregation for any country. but i've searched on google for "covid saude.gov.br csv" which lead me in here: https://brasil.io/dataset/covid19/boletim/  You found that too already?
i dont speak, i guess it is portuguese in brazil, so unsure if i understand everything correctly. i've only utilized translate.google.com a little. but Leia a documentação dessa tabela lead to the following repo here: https://github.com/turicas/covid19-br/blob/master/api.md#boletim . suppose from there a query string might be crafted for their api? i guess the complete download there https://data.brasil.io/dataset/covid19/caso.csv.gz would be a little bit too extensive ;))) goes down even to the city level data wise it looks. the csv is 2,2mb in size. ;))) might be easier for a native speaker to find his or her way around there.

But tried the examples on the Github repo in Paw and I got a 301 for querying https://brasil.io/api/dataset/covid19/caso/data?is_last=True&state=AL :/

guess the caso.csv.gz is the smallest but most complete at the same time available. it is also listed here alongside other versions, all provided sha512 checksums: https://data.brasil.io/dataset/covid19/_meta/list.html
@felipequintella the only thing i have issues understanding just with google translate. is that dataset aggregated by brazilian offcials/government employees? meaning is that a official data source or is that aggregation based on voluntary work?

Hey @rpkoller , I'll take a look at these and see how they are collecting/compiling and verifying the data. I had not found it before, looks good though! I'll revert later.

@rpkoller as per this link: https://brasil.io/dataset/covid19/caso_full/ they say all the data comes from each state health department, so yes, I would say it's aggregated by the authorities and brasil.io just compiles them in one big csv. Filtering the caso_full.csv by place_type == state would yield the result Felipe is talking about.


adding challenge_lab3 writeup

ChallengeLab_2

Writeups for challenge lab 3 and 4 have been added. Please check once @itssingh :)


✨ add Flag Timeout

Add a timeout flag to not have a cancel flag when the event is of type timeout.
This would add a new "commandTimeout" event which would take the same parameters as the "commandCancel" event but would add "time" of type number.
Example for the event
const { Listener } = require("discord-akairo");

class CommandTimeout extends Listener {
	constructor() {
		super("commandTimeout", {
			emitter: "commandHandler",
			event: "commandTimeout",
			category: "command",
		});
	}

    /**
   * @param time {number}
   */
	times(time) {
		const date = new Date(time);
		const minutes = date.getMinutes();
		const seconds = date.getSeconds();
		if (minutes > 1) {
			return `**${minutes}** minutes`;
		}
		return `**${seconds}** seconds`;
	}

	/**
     * @param message {import("discord.js").Message}
     * @param command {import("discord-akairo").Command}
     * @param time {number}
     */
	async exec(message, command, time) {

		message.channel.send({ embeds: [
			{
				color: "YELLOW",
				description: `💡 The ${this.times(time)} are up!`,
			},
		] });
	}
}

module.exports = CommandTimeout;

Can be very handy to do a default integration like below

Add new flag on gh-page in html compressed here


fix: Stops error message when disabling simple dialog plugin

You'll see this error if disabling the simple dialog plugin.
 core/project_settings.cpp:961 - Condition "!p_info.has("type")" is true.

For every time an empty dictionary is passed to clear a setting from Godot's project settings in simple dialog
	ESCProjectSettingsManager.register_setting(
		ESCProjectSettingsManager.MAX_TIME_TO_DISAPPEAR,
		null,
		{}
	)

PR updated
The project_settings_manager function for creating Godot settings has been split into explicit set_setting and remove_setting functions as using set_setting to unset a setting was a code smell.
Error checking was added to the functions which then highlighted that the DEFAULT_DIALOG_TYPE was being set outside the simple_dialog plugin.
@StraToN my removal of the code that sets a default value for the setting from escoria-core/plugin.gd might cause issues with the code that is expecting to find the setting (in say.gd and esc_dialog_player.gd). If you don't have a dialog plugin active however, things aren't going to work anyway, so it seemed right to me to not be configuring the simple dialog plugin from plugin.gd. Alternatively I put it back in plugin.gd and remove it being created from simple dialog?

Damn. Realised the set_setting function needs to be able to change settings as well as create them, so the does-it-already-exist check is wrong (#showerthoughts). I'll remove it when I'm on the computer tomorrow.
The question as to whether we should set the default dialogue type from plugin.gd is still valid though.


chore: fix CI

@Aslemammad It seems like CI is broken, because we're now testing against all supported esbuild versions (as of #14)
But the snapshot appears to be different with each esbuild version
Any idea on how to fix this?
This will break each time esbuild updates I'm afraid 🤔
So honestly I would just delete the snapshot tests, as I can't come up with a better solution tbh 🤔

I see, we cannot do that! Where it fails exactly? disable it there, but with snapshots, it's better to keep them.

@Aslemammad The test itself doesn't fail, but the output for polyfillContent is different for different esbuild versions
These tests are run with<EMAIL_ADDRESS>which appears to be different from 0.14.0, slightly different from 0.16.0, a bit more different from 0.16.x & 0.17.0, and even more different from 0.17.x, 0.18.0 & 0.18.x

That's a funny case :)
How about testing with 'string.includes' instead snapshotting?

@Aslemammad I can definitely do that.
What string would you test against?

I meant testing against the polyfills in the functions, for instance checking if a global object gets polyfilled or a node module, exactly  like the current tests.

@Aslemammad Can you help out on that one please?
The snapshot contains minified code, so it's really hard to see what's actually polyfilled for me

@MichaelDeBoey can we test with esbuild 18 only?

@Aslemammad Fixed


Improvement (8 pts):Add functions to run algorithms on only random portion of input

An if rand()%n==0: return should work, but you'll need to pass in time and global id, and make sure the rest  of the program now handles partial updates well.

You also might want to try setting a texture and giving a sparse map as an input


Add file_create endpoint

fixes #111

Please make sure that all the checks pass. Please add here any additional information regarding this pull request. It's highly recommended that you link this PR to an issue (please create one if it doesn't exist for this PR)

Thank you @roll!. It is ready for the review.


Fix random error in cli events test

---> Making bundle: test-integration-cli (in bundles/1.5.0-dev/test-integration-cli)
+++ exec docker --daemon --debug --host unix:///go/src/github.com/docker/docker/bundles/1.5.0-dev/test-integration-cli/docker.sock --storage-driver vfs --exec-driver native --pidfile /go/src/github.com/docker/docker/bundles/1.5.0-dev/test-integration-cli/docker.pid
+++ tar -cC /docker-frozen-images .
+++ docker load
+++ tar -cC /go/src/github.com/docker/docker/bundles/1.5.0-dev/test-integration-cli/emptyfs .
+++ docker load

go test -test.timeout=30m github.com/docker/docker/integration-cli
[PASSED]: events - untags are logged
[PASSED]: events - container unwilling to start logs die
[PASSED]: events - limited to 64 entries
[PASSED]: events - container create, start, die, destroy is logged
[PASSED]: events - image untag, delete is logged
[PASSED]: events - image pull is logged
[PASSED]: events - image import is logged
[PASSED]: events - filters
[PASSED]: events - filters using image
--- FAIL: TestEventsFilterContainerID (1.19s)
docker_cli_events_test.go:357: Expected 3 events, got 2: [2015-03-31T03:17:31.000000000Z 838ef58f451674f4ae4625823a7aeb14d2a29f5a10e8d1261f20cf25f380f61f: (from busybox:latest) create 2015-03-31T03:17:31.000000000Z 838ef58f451674f4ae4625823a7aeb14d2a29f5a10e8d1261f20cf25f380f61f: (from busybox:latest) start]
[PASSED]: events - filters using container name
FAIL
coverage: 15.2% of statements
exit status 1
FAIL	github.com/docker/docker/integration-cli	43.925s
++++ cat /go/src/github.com/docker/docker/bundles/1.5.0-dev/test-integration-cli/docker.pid
+++ kill 673
make: *** [test-integration-cli] 错误 1

need to take a sleep to wait the container is end of run.

Just wondering if removing the -d would be better, then we would block until the container is done.

LGTM

@duglin Actually I think you're right. It is better to use names instead of ids then.
Sleep is pretty weak fix which works for one machine and doesn't for another.

@LK4D4  I was going to suggest using docker inspect to make sure the container is really done, but I wasn't sure if it was worth it.  As for using names vs IDs, the next test in that file uses names, this one is specifically trying to make sure it works by IDs so I don't think we can/should remove that part of it.

@duglin There is even special function for waiting container with inspect: waitRun. And I think it always worth to use something more precise than sleep, because tests are long enough already.

this will close #11959

but unsure if sleep is the right way to do it

@duglin @LK4D4 @jfrazelle Nice suggestion,I have updated the codes,use waitInspect instead of sleep(I think we can not use waitRun because containers would exit automaticly). Please help me to review the codes,Thanks:-)

Assuming janky is happy, it LGTM.  thanks!
Just hoping 5 seconds is long enough but I'm sure we'll notice it if its not.

LGTM


Get the line where the carret is

Hi,
I am currently working on a IDE and i need to get the line where the carret is, is there a way to do this in a codearea ?

Try getCurrentParagraph()

It works well ! Thanks for your answer ;)

Great! Can you close this issue?


Kustomization validation can't be specified in tf

There's currently no way to specify validation (server or client) when creating the git source and kustomization.
data "flux_sync" "main" {
  name                   = var.flux_resource_name
  count                   = var.flux_applied
  target_path        = var.target_path
  url                = var.url
  branch             = var.branch_name
  namespace          = var.flux_namespace
  interval           = var.sync_interval
  git_implementation = "libgit2"
  secret             = var.flux_secret_name
}

Let me know if I'm missing something, I looked in the code and don't think that is exposed.

We are currently limited to parameters exposed by the options in Fluxv2. If we want to expose the parameter in this provider it first needs to be added here.
https://github.com/fluxcd/flux2/blob/main/pkg/manifestgen/sync/options.go

I have added a new guide in #178 which should cover this issue.


Document turning off VPN before authenticating Terraform Service Account impersonation and billing api calls

I'll add some RCA shortly - holder for now

20240406: Closing issue during retrofit/rebase of this TEF V1 based/modified repo to TEF V4 standards
This issue may participate in the LZ refactor after rebase
Query on all issues related to the older V1 version via the tag
https://github.com/GoogleCloudPlatform/pbmm-on-gcp-onboarding/labels/2024-pre-tef-v4


Incorrect logs directory

The logs directory is set as
this.loggingFilesPath = Path.join((extraResourcesPath != null ? Path.join(extraResourcesPath) : Path.join(__dirname, '..', '..')), 'data', 'logging')

This is not correct. I should point to app.getPath('logs') as this is not working at least for Mac. I haven't tested others yet.
The correct paths are:
on Linux: ~/. config/{app name}/logs/main.log.
on macOS: ~/Library/Logs/{app name}/main.log.
on Windows: %USERPROFILE%\AppData\Roaming{app name}\logs\main.log.

Tested on Mac where it looks good

@digiserg @mhmdkrmabd can we close this now?


Removed calls to deprecated items, other small updates.

Hey, I made some small changes to your library and updated some of the code to use non-deprecated items. Here's a run down of what I did:

Stemmer uses bytes instead of ascii - gets rid of all the conversions (to_char, as_ascii, etc.), and makes the code more readable in my opinion.
Updated tests to make them use assertions, added benchmarks.
Attempted to make code more idiomatic rust (probably still needs work though).
Replaced calls to deprecated items -- removed all warnings compiling with the most recent nightly build.
Removed public visibility on Stemmer (made more sense to not expose it publicly to me)
Attempted to add inline directive to some functions to improve performance.

Running the newly added bench marks, there seems to be a slight improvement in performance:
Old code:
running 3 tests
test test_stem::lexicon ... ignored
test test_stem::lexicon_bench ... bench:   4680445 ns/iter (+/- 88446)
test test_stem::single_bench  ... bench:       180 ns/iter (+/- 7)

My pull:
running 3 tests
test test_stem::lexicon ... ignored
test test_stem::lexicon_bench ... bench:   4170162 ns/iter (+/- 82477)
test test_stem::single_bench  ... bench:       132 ns/iter (+/- 7)

@ferristseng Sorry I forgot about this PR.


Trivial issue with "Workflow Expressions" section in specification.md

At line 1610, example data is defined as:
{
    "applicant": {
      "name": "John Doe",
      "age"      : 26,
      "address"  : {
        "streetAddress": "Naist street",
        "city"         : "Nara",
        "postalCode"   : "630-0192"
      },
      "phoneNumbers": [
        {
          "type"  : "iPhone",
          "number": "0123-4567-8888"
        },
        {
          "type"  : "home",
          "number": "0123-4567-8910"
        }
      ]
    }
}

At line 1672, this data is used in the example inline expression:
```json
{
   "stateDataFilter": {
       "output": "${ .applicant | {applicant: .name, contactInfo: { email: .email, phone: .phoneNumbers }} }"
   }
}

This would set the data output of the particular state to:

json
{
  "applicant": "John Doe",
  "contactInfo": {
    "email"<EMAIL_ADDRESS>    "phone": [
      {
        "type": "iPhone",
        "number": "0123-4567-8888"
      },
      {
        "type": "home",
        "number": "0123-4567-8910"
      }
    ]
  }
}

Unless I am misunderstanding something, the email field is missing from the example json: { "email"<EMAIL_ADDRESS>}
Thanks.
Environment:

Specification version used: v0.7

@DoisKoh Thanks! Will fix asap ;)


make sure that "PSM Count (unambiguous, <0.01 q-value)" is updated after PEP disambiguation

I haven't pinpointed what the problem is yet but @kbhenke reports that there are some PrSMs that have a 0 for PSM count, are targets, are unambiguous, and have q-values <0.01 and notch qvalues <0.01. this is just a guess but they may have been ambiguous originally, and then shortreed's PEP algorithm removed some ambiguity and the PSM count wasn't updated accordingly. need to check. maybe same as #2055

i don't recall but I think another problem is that the accessions assigned to psms/peptides is not changed after protein inference. is that true?

While this topic is being discussed, another (possibly related?) issue I’d like to report is that when I search multiple files together and then want to see how many PrSMs there were for a given prfm in a particular raw file, my instinct is to open the individual search results for that file and look at the number of PrSMs reported.  However, I'm pretty sure that when you search multiple files together, the same number of PrSMs is reported for all the raw files (I think this number is the TOTAL PrSMs observed in ALL raw files searched).  I don't find this number particularly helpful.  I've run into this issue a couple of times (both in BU and TD) and I think we/you all decided it was a bug, but I'm not sure that it was ever fixed.

this was actually a parsimony issue, sort of. parsimony removes some ambiguity, and the "PSM Count (unambiguous, <0.01 q-value)" field had to be updated post-parsimony.
@trishorts protein inference does/should change the accessions assigned to the PSMs/peptides.
https://github.com/smith-chem-wisc/MetaMorpheus/blob/4944681aeab7c8ac100b474a2b080c5c9e228b20/EngineLayer/ProteinParsimony/ProteinParsimonyEngine.cs#L422
@kbhenke yeah this is an issue. I might be able to fix these both in one go. i'll check it out


Cant swipe to watch previous stories

if i clicked on second story , i can only see second and third and soon ... stories not the first one using swipe left.

It's normal for it to work this way. Instagram uses it in the same way, we tried to emulate it. You cannot go back to before the story you clicked on, it is now your start story.

It's normal for it to work this way. Instagram uses it in the same way, we tried to emulate it. You cannot go back to before the story you clicked on, it is now your start story.

But in instagram you can go back to before story you clicked on it. Can you please try to add this in upcoming commit of yours, it will be very helpful. Thanks for the library and all the efforts you have put to make this good one.

Have you found a way to implement this


tools don't follow the version restrictions

In https://github.com/input-output-hk/cardano-sl/pull/1737/files happy was bumped, although the stack.yaml has the version pinned.
We have to check if stack2nix master has the same kind of bug.

https://github.com/input-output-hk/stack2nix/issues/52 might help here, but happy could still be pinned according to stackage LTS.

It seems to be due to tools hardcoded for old stack2nix, which should be fixed now.
However two tools are still hardcoded:
src/Stack2nix/External/Stack.hs:  void $ liftIO $ mapM_ (\pkg -> cabal2nix ("cabal://" ++ pkg) Nothing Nothing (Just outDir) hSnapshot) $ words "hscolour stringbuilder"

Those two might be needed by nix generic builder itself.

I've removed stringbuilder in https://github.com/input-output-hk/stack2nix/pull/80
hscolour removal still depends on https://github.com/NixOS/nixpkgs/issues/32609, so this is not fixed yet.

Going forward, we need to generate packages that any ghc depends on. Union is: hscolour, alex, happy.
We should add those before computing stack plan.


Using jQuery addClass not working with uppercase characters

I'm using the following code:
$('.block-facetapi').hover(
    function(){ $(this).addClass('expanded animated fadeInDown') },
    function(){ $(this).removeClass('expanded animated fadeInDown') }
);

The result is that none of the classes is added (Chrome v50.0.2661.102 [64-bit], Mac). However, when I change fadeInDown to fadeindown (all lowercase) they all get added as they should. But currently the class should be written with uppercase characters, or the animation won't work.
Wouldn't it be better to abandon the uppercase characters in class names altogether, to guarantee compatibility? The use of uppercase characters for code is generally discouraged anyway, and since about 90% of the animate.css selectors consist of class names with one or more uppercase characters, it's a huge drawback to use it.

I think you should check your code, as classes are case insensitive. Maybe a pen with the issue could help?


Add two new functions

From node v10.0.0, node assert add two new function,  assert.doesNotReject and assert.rejects
Can we add this two function in power-assert ?

Duplicate of #107
We will support these in power-assert v2.


[environment]::OSVersion.Version returns a wrong result of the OS

Steps to reproduce
[environment]::OSVersion.Version
Expected behavior
Should be return the OS Version
Actual behavior

Windows 10 with PowerShell 5 : 10.0.10536.0
Windows 10 with PowerShell 6 : 6.2.9200.0
Ubuntu : throw an error

Potential error of the problem
The method used by PowerShell must be GetVersionInfoEX (depreciated since Windows 8.1) instead of GetVersionInfo
Environment data
PS C:\> $PSVersionTable

Name                           Value
----                           -----
CLRVersion
SerializationVersion           <IP_ADDRESS>
WSManStackVersion              3.0
PSVersion                      6.0.0-alpha
PSCompatibleVersions           {1.0, 2.0, 3.0, 4.0...}
PSRemotingProtocolVersion      2.3
PSEdition                      Core
GitCommitId                    v6.0.0-alpha.9
BuildVersion                   <IP_ADDRESS>

Nah the reason is NOT using GetVersionEx. It works fine in Windows 10. You're referring to a right documentation though. The exe of that PowerShell lacks manifestation, as you can see it is reporting Windows 8.1.
GetVersionInfo seems not to be a Win32 API, can you find a documentation on it? As far as I know, Microsoft only recommends using version helper functions (hmmm I'd have to say many programmers aren't logical enough to correctly check version numbers so MS is providing helper functions haha). And for getting the native system information, use GetFileVersionInfo. GetVersionEx returns the compatibility mode version number and if the app is not manifested for Windows 8.1/10, VersionLie shim gets in.

[environment]::OSVersion.Version is actually calling .NET Core code:
PS C:\> [environment]::OSVersion.GetType().Assembly

GAC    Version        Location
---    -------        --------
       v4.0.30319     C:\Users\dongbow\Downloads\powershell-6.0.0-alpha.9\System.Private.CoreLib.ni.dll

PS C:\>
PS C:\> [environment].Assembly

GAC    Version        Location
---    -------        --------
       v4.0.30319     C:\Users\dongbow\Downloads\powershell-6.0.0-alpha.9\System.Private.CoreLib.ni.dll

System.Environment::OSVersion is not exposed in .NET Core contract, but it's obviously still preserved in the runtime assembly.
.NET Core team will bring back OSVersion and other public surface from System.Private.Corelib in .NET Core 1.1 release, see dotnet-core#6006

we are doing work to expose OS info in psversiontable #1635 , this is already tracked in dotnet repo

Just a heads-up that, at least as of this writing, while dotnet-core#6006 does intend to bring System.Environment's OSVersion back:

its implementation is not cross-platform yet,

and is furthermore currently based on calls to the deprecated-since-Windows-8.1 GetVersion and GetVersionEx Windows API functions, which as has been pointed out, do not report the true OS version.

@GeeLaw: The Core powershell.exe does have an (embedded) manifest too, but one without entries targeting specific Windows version, hence it is "stuck" at reporting Windows 8 (6.2), as you state.
That said, even the Windows PowerShell powershell.exe, with its Windows-version-targeting entries would be lied to in the future, if it used GetVersion(Ex) directly:

"Once an application is manifested for a given operating system version, GetVersionEx will always return the version that the application is manifested for in future releases." -

However, it seems that the .NET Framework (I presume) works around this:

/*

SystemNative::GetOSVersion - Fcall corresponding to System.Environment.GetVersion
It calls clr!GetOSVersion to get the real OS version even when running in
app compat. Calling kernel32!GetVersionEx() directly will be shimmed and will return the
fake OS version. In order to avoid this the call to getVersionEx is made via mscoree.dll.
Mscoree.dll resides in system32 dir and is never lied about OS version.
*/

It sounds like .NET Core, which I presume doesn't use mscoree.dll, cannot take advantage of this, which is why the Core edition reports the fake version.

It is hard to believe, but the method that the official docs recommend for determining the true Windows version number is:

call the GetFileVersionInfo function on one of the system DLLs, such as Kernel32.dll, then call VerQueryValue to obtain the \StringFileInfo\\ProductVersion sub-block of the file version information."

To put it in PowerShell terms (Windows-only):
(Get-FileVersionInfo $env:SystemRoot\System32\kernel32.dll).ProductVersion


Optmize refreshing SriovNetworkNodeState

There is a SriovNetworkNodeState watcher running.
It should be used to keep updated state of the object. Requesting latest state of the object very often
overloads the kube-apiserver in big clusters.
Signed-of-by: Alan Kutniewski<EMAIL_ADDRESS>

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

0 of 9 (100.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.1%) to 30.325%

Totals

Change from base Build<PHONE_NUMBER>:
0.1%

Covered Lines:
3565

Relevant Lines:
11756

💛  - Coveralls

/test-all


chore(ci): Improve CI / CD build times

Runs release asset builds simultaneously with deploy-staging. Those don't depend on each other.
Prevents running some build workflows in CD because they're run already in the PR and in the merge group, and the risk of semantic conflict is negligible
Move tauri builds to its own workflow so we can trigger Linux and Windows builds manually on an adhoc basis like we do for the Swift and Kotlin builds

Refs #3995

After this gets in, I would be tempted to do manual mutation tests to validate it, e.g.:

Open a draft PR with an obvious performance regression, see if the perf tests fail
PR with compatibility break, see if integration can catch it

It's also been difficult to make any changes to CD since running CD updates the draft release and does a bunch of stuff. So if this means that we can do almost all of CD, such as building the release MSI and AppImage, without the destructive steps from merging into main and deploying to prod, that would be cool.

Open a draft PR with an obvious performance regression, see if the perf tests fail

We don't automatically verify the performance results (yet).

It's also been difficult to make any changes to CD since running CD updates the draft release and does a bunch of stuff. So if this means that we can do almost all of CD, such as building the release MSI and AppImage, without the destructive steps from merging into main and deploying to prod, that would be cool.

This should be simple to do with this refactoring, however some things like cache writing only happen on main and can't be tested unless run there. I will see if I can update those jobs to write cache on CD and not main so we can trigger them with a manual run.
Otherwise, CI and CD are essentially the same now except for building --debug and building --release.

Performing a bit more fixup / cleanup, will mark for review again in a bit

@firezone/engineering Ready for review. This is likely to break main because the CD workflow dispatch trigger isn't available until merged to main, so it's a bit hard to test. After this PR "settles" though, we'll be able to do that in the future.

@firezone/engineering -- I'll need to update the required checks before this gets merged in. After merge, there's guaranteed to be some issues I'll need to work through. I'll prioritize that today to minimize disruption.
This will block merges until you rebase.

@ReactorScram Close!

CI took over the role of building release artifacts from CD, so the duplication between, e.g. Tauri MSI builds, is gone, everything for the Clients builds in CI now. CI still does all the tests. CD and Publish run CI. Hotfix requires CI to have succeeded in the past but never runs CI on its own.

Publish just checks for CI green now too, and doesn't re-run those tests (it uses the same logic for Hotfix, but publishes data plane images to ghcr.io too.)

Publish is the formal release process that does everything, asks CI to build release assets, puts those in a new public release, updates staging, updates prod, etc.

Publish doesn't do all that -- by the time it runs, we should have already verified everything in the CI workflow for the same SHA that's being published. It simply makes public our new gateway and client Docker images, and deploys production. This is triggered when we publish the drafted release that's been accumulating the artifacts from CD.


feat: add support for cp4d auth

Add support for cp4d authentication

Let's try this again @haodeqi, thanks!


iOS build failed using version 3.2.0

It gives the following error.
Error: Method 'addPostFrameCallback' cannot be called on 'WidgetsBinding?' because it is potentially null.
../…/ui/paged_sliver_builder.dart:254
- 'WidgetsBinding' is from 'package:flutter/src/widgets/binding.dart' ('../../../../../../fvm/versions/stable/packages/flutter/lib/src/widgets/binding.dart').
package:flutter/…/widgets/binding.dart:1
    Try calling using ?. instead.
            WidgetsBinding.instance.addPostFrameCallback((_) {
                                    ^^^^^^^^^^^^^^^^^^^^
    Failed to package /Users/localadmin/Desktop/PGA/PGA_App/PGA_mobile_app/pocketdrive-mobile-app/pocketdrive.
    Command PhaseScriptExecution failed with a nonzero exit code

I have used the following version in pubspec file.
infinite_scroll_pagination: ^3.1.0
Flutter doctor
[✓] Flutter (Channel stable, 2.8.1, on macOS 12.3.1 21E258 darwin-x64, locale en-IN)
[!] Android toolchain - develop for Android devices (Android SDK version 30.0.3)
    ✗ cmdline-tools component is missing
      Run `path/to/sdkmanager --install "cmdline-tools;latest"`
      See https://developer.android.com/studio/command-line for more details.
    ✗ Android license status unknown.
      Run `flutter doctor --android-licenses` to accept the SDK licenses.
      See https://flutter.dev/docs/get-started/install/macos#android-setup for more details.
[✓] Xcode - develop for iOS and macOS (Xcode 13.1)
[✓] Chrome - develop for the web
[✓] Android Studio (version 2020.3)
[✓] VS Code (version 1.67.2)
[✓] Connected device (2 available)
    ! Error: iPhone 12 is not connected. Xcode will continue when iPhone 12 is connected. (code -13)

! Doctor found issues in 1 category.

Seems like the package is updated recently and it has the above mentioned error.

Hey, this is fixed on version 3.2.0

Which version of the package are you using?
In the title, you mentioned 3.2.0, but then your description says 3.1.0.
This shouldn't happen on 3.2.0. I'm closing the issue for now but feel free to reopen if you get the same error on 3.2.0.

Same problem, also with this code official repo


setting identificationAttributeName not respected

Hi!
ENV['simple-auth'] = {
  authorizer: 'simple-auth-authorizer:devise',
  identificationAttributeName: 'user_name'
}

When trying to override the identificationAttributeName in my environment.js file it won't be respect and it keeps defaulting to 'user_email', am I missing something here?

/* jshint node: true */

module.exports = function(environment) {
  var ENV = {
    modulePrefix: 'frontend',
    environment: environment,
    baseURL: '/',
    locationType: 'hash',
    contentSecurityPolicy: {
      'default-src': "'none'",
      'script-src': "'self' 'unsafe-inline' 'unsafe-eval' use.typekit.net *.googleapis.com maps.gstatic.com",
      'font-src': "'self' data: use.typekit.net fonts.gstatic.com",
        'connect-src': "'self'",
        'img-src': "'self' www.facebook.com p.typekit.net *.gstatic.com *.googleapis.com *.google.com mapicons.nicolasmollet.com",
          'style-src': "'self' 'unsafe-inline' *.gstatic.com *.googleapis.com",
          'frame-src': "s-static.ak.facebook.com static.ak.facebook.com www.facebook.com"
    },
    EmberENV: {
      FEATURES: {
        // Here you can enable experimental features on an ember canary build
        // e.g. 'with-controller': true
      }
    },

    APP: {
      // Here you can pass flags/options to your application instance
      // when it is created
    }
  };

  ENV['simple-auth'] = {
    authorizer: 'simple-auth-authorizer:devise'
  };

  ENV['simple-auth-devise'] = {
    resourceName: 'user',
    identificationAttributeName: 'user_name'
  };

  if (environment === 'development') {
    // ENV.APP.LOG_RESOLVER = true;
    ENV.APP.LOG_ACTIVE_GENERATION = true;
    // ENV.APP.LOG_TRANSITIONS = true;
    // ENV.APP.LOG_TRANSITIONS_INTERNAL = true;
    ENV.APP.LOG_VIEW_LOOKUPS = true;
  },

if (environment === 'test') {
  // Testem prefers this...
  ENV.baseURL = '/';
  ENV.locationType = 'none';

  // keep test console output quieter
  ENV.APP.LOG_ACTIVE_GENERATION = false;
  ENV.APP.LOG_VIEW_LOOKUPS = false;

  ENV.APP.rootElement = '#ember-testing';
}

if (environment === 'production') {

}

return ENV;
}

Hm, looks ok. Are you sure you're on the latest version of Ember Simple Auth?

This is fixed and will be released with the next version: https://github.com/simplabs/ember-simple-auth/pull/403

Hi Marcoow,
Thanks for the merge, awesome!

Marco when do you anticipate releasing the next version? I ran into this bug today.

I'm using "ember-simple-auth": "1.0.1", and have the necessary configs:
ENV['simple-auth'] = {
        authorizer: 'simple-auth-authorizer:devise'
    };

    ENV['simple-auth-devise'] = {
        resourceName: 'user',
        identificationAttributeName: 'email'
    };

however the login details are sent the usual way, username, password.
I have checked the source code and looks like the code is the old one. Isn't this patch applied to 1.0.1 version?

@teckays when you're using ESA 1.0 the Devise functionality is already built in to the ember-simple-auth addon. There's no need to install this package anymore (in fact it won't to anything and is deprecated anyways). See the docs for ember-simple-auth for info on how to configure the Devise authenticator.


Add workbox 3.6.1 docs

Add generated docs for workbox 3.6.1.
Target Live Date: 2018-09-19

[ ] This has been reviewed and approved by (NAME)
[x] I have run npm test locally and all tests pass.
[x] I have added the appropriate type-something label.
[x] I've staged the site and manually verified that my content displays correctly.

CC: @petele

Whoops!
There were 22 warnings that will prevent this PR from being merged. Please take a look, and either fix, or provide a justification for why they can't be fixed.
WARNINGS
src/content/en/tools/workbox/reference-docs/latest/module-workbox-build.html#L241 - Common typo found: 'node' Should it be 'Node'?
src/content/en/tools/workbox/reference-docs/latest/workbox-strategies_CacheFirst.mjs.html#L69 - Common typo found: 'ServiceWorker' Should it be 'service worker'? Capitalize Service if it's the first word in the sentence.
src/content/en/tools/workbox/reference-docs/latest/workbox-strategies_CacheOnly.mjs.html#L64 - Common typo found: 'ServiceWorker' Should it be 'service worker'? Capitalize Service if it's the first word in the sentence.
src/content/en/tools/workbox/reference-docs/latest/workbox-strategies_NetworkFirst.mjs.html#L72 - Common typo found: 'ServiceWorker' Should it be 'service worker'? Capitalize Service if it's the first word in the sentence.
src/content/en/tools/workbox/reference-docs/latest/workbox-strategies_StaleWhileRevalidate.mjs.html#L77 - Common typo found: 'ServiceWorker' Should it be 'service worker'? Capitalize Service if it's the first word in the sentence.
src/content/en/tools/workbox/reference-docs/latest/workbox.strategies.CacheFirst.html#L90 - Common typo found: 'ServiceWorker' Should it be 'service worker'? Capitalize Service if it's the first word in the sentence.
src/content/en/tools/workbox/reference-docs/latest/workbox.strategies.CacheOnly.html#L81 - Common typo found: 'ServiceWorker' Should it be 'service worker'? Capitalize Service if it's the first word in the sentence.
src/content/en/tools/workbox/reference-docs/latest/workbox.strategies.NetworkFirst.html#L92 - Common typo found: 'ServiceWorker' Should it be 'service worker'? Capitalize Service if it's the first word in the sentence.
src/content/en/tools/workbox/reference-docs/latest/workbox.strategies.StaleWhileRevalidate.html#L94 - Common typo found: 'ServiceWorker' Should it be 'service worker'? Capitalize Service if it's the first word in the sentence.
src/content/en/tools/workbox/reference-docs/v3.6.1/module-workbox-build.html#L241 - Common typo found: 'node' Should it be 'Node'?
src/content/en/tools/workbox/reference-docs/v3.6.1/workbox-build_src__types.js.html#L45 - Common typo found: 'node' Should it be 'Node'?
src/content/en/tools/workbox/reference-docs/v3.6.1/workbox-build_src_entry-points_generate-sw.js.html#L46 - Common typo found: 'ServiceWorker' Should it be 'service worker'? Capitalize Service if it's the first word in the sentence.
src/content/en/tools/workbox/reference-docs/v3.6.1/workbox-build_src_entry-points_generate-sw.js.html#L99 - Common typo found: 'ServiceWorker' Should it be 'service worker'? Capitalize Service if it's the first word in the sentence.
src/content/en/tools/workbox/reference-docs/v3.6.1/workbox-build_src_index.js.html#L87 - Common typo found: 'homescreen' Should it be 'home screen'? See: https://developers.google.com/style/word-list#home-screen
src/content/en/tools/workbox/reference-docs/v3.6.1/workbox-strategies_CacheFirst.mjs.html#L69 - Common typo found: 'ServiceWorker' Should it be 'service worker'? Capitalize Service if it's the first word in the sentence.
src/content/en/tools/workbox/reference-docs/v3.6.1/workbox-strategies_CacheOnly.mjs.html#L64 - Common typo found: 'ServiceWorker' Should it be 'service worker'? Capitalize Service if it's the first word in the sentence.
src/content/en/tools/workbox/reference-docs/v3.6.1/workbox-strategies_NetworkFirst.mjs.html#L72 - Common typo found: 'ServiceWorker' Should it be 'service worker'? Capitalize Service if it's the first word in the sentence.
src/content/en/tools/workbox/reference-docs/v3.6.1/workbox-strategies_StaleWhileRevalidate.mjs.html#L77 - Common typo found: 'ServiceWorker' Should it be 'service worker'? Capitalize Service if it's the first word in the sentence.
src/content/en/tools/workbox/reference-docs/v3.6.1/workbox.strategies.CacheFirst.html#L90 - Common typo found: 'ServiceWorker' Should it be 'service worker'? Capitalize Service if it's the first word in the sentence.
src/content/en/tools/workbox/reference-docs/v3.6.1/workbox.strategies.CacheOnly.html#L81 - Common typo found: 'ServiceWorker' Should it be 'service worker'? Capitalize Service if it's the first word in the sentence.
src/content/en/tools/workbox/reference-docs/v3.6.1/workbox.strategies.NetworkFirst.html#L92 - Common typo found: 'ServiceWorker' Should it be 'service worker'? Capitalize Service if it's the first word in the sentence.
src/content/en/tools/workbox/reference-docs/v3.6.1/workbox.strategies.StaleWhileRevalidate.html#L94 - Common typo found: 'ServiceWorker' Should it be 'service worker'? Capitalize Service if it's the first word in the sentence.

:tada: This has been pushed live to https://developers.google.com/web/


--help displays multiple outputs for the -h flag

code-server version: 1.1119-vsc1.33.1
OS Version: Ubuntu 16.04

Description
-h flag is displayed as shorthand for both --host and --help
Steps to Reproduce

code-server --help

CC @coadler

The shorthand for --host should be changed to -H as I've seen other tools do in the past.

Which one currently takes precedence?

-h does --host:
$ code-server -h
error: option `-h, --host <value>' argument missing


Updated dependencies of Circle;Akka;Specs2

Circle -> 0.8
AKKA_HTTP -> 10.0.7
AKKA -> 2.5.2
Specs2 -> 3.8.9

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@cd95eeb). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master      #13   +/-   ##
=========================================
  Coverage          ?   85.71%
=========================================
  Files             ?        4
  Lines             ?       63
  Branches          ?        4
=========================================
  Hits              ?       54
  Misses            ?        9
  Partials          ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cd95eeb...d08f85d. Read the comment docs.

Hi, thanks for the updates. One note though, Akka HTTP 10.0.7 depends on Akka 2.4.18, not 2.5.x.. I'd much rather keep the Akka version and not pull in 2.4.x and 2.5.x together.

The master is already ahead of these proposed versions, so I think this PR can be closed.


Unable to add networked printer from Windows

Cups set up correctly on Dietpi. Can print OK from android but trying to connect from windows shows printer available but hangs forever on "connecting". Tried turning firewall off still not connecting.

Same here.  Frustrating.  Browses immediately to samba shared printer but won't accept configuration.  Errors with failure to connect even though it found it nearly instantly.  Also seems to not like spaces in printer name.


Ubuntu Backport and Version Bump v0.36.x

Fixes #N/A
Description

Backports https://github.com/aws/karpenter-provider-aws/pull/6699 and bumps sigs.k8s.io/karpenter

How was this change tested?

make presubmit

Does this change impact docs?

[ ] Yes, PR includes docs updates
[ ] Yes, issue opened: #
[x] No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>3
Details

12 of 14 (85.71%)  changed or added relevant lines in 2 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.004%) to 77.649%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

pkg/apis/v1/ec2nodeclass_conversion.go
9
11
81.82%

Totals

Change from base Build<PHONE_NUMBER>2:
0.004%

Covered Lines:
5607

Relevant Lines:
7221

💛  - Coveralls


Enable Production Endpoint for Product Telemetry

As an NGF maintainer
I want to enable and test the production telemetry endpoint
So that I can collect and verify that data is exported properly
Acceptance

Production endpoint for product telemetry is enabled for exporting data
A manual verification is done to ensure that data is received as intended

blocked by #1377

Closed by https://github.com/nginxinc/nginx-gateway-fabric/pull/1699


[SQLite] Support for UNIQUE constraints

Support for table unique constraints would be nice, e.g.:
CREATE TABLE table_name
(
  _id INTEGER PRIMARY KEY AUTOINCREMENT,
  record_id INTEGER NOT NULL,
  ...
  , UNIQUE ( record_id ) ON CONFLICT REPLACE
)

Unique Constraint can be single or multiple columns.
Would also include ON CONFLICT clause:

ROLLBACK
ABORT
FAIL
IGNORE
REPLACE

Isn't this already available?
https://github.com/Kotlin/anko/blob/master/anko/library/static/sqlite/src/sqlTypes.kt

Yes, UNIQUE is already available. This is to support conflict clauses.

A simpler version of the example can also be written like so:
CREATE TABLE table_name
(
  _id INTEGER PRIMARY KEY AUTOINCREMENT,
  record_id INTEGER NOT NULL UNIQUE ON CONFLICT REPLACE,
  ...
)


Insufficient Permission when writing in Google Storage

I am not able to write data in Google Storage when using gcsfs, I get insufficient permission error. However, I am able to write data using gsutil cp.
I am running (btw, DEBUG is not showing anything)
import gcsfs
import os

DEBUG = os.environ.get('GCSFS_DEBUG', True)

fs = gcsfs.GCSFileSystem()
f = fs.open("merlin-datasets/test.txt", 'wb')
f.write(2*2**20 * b'a')
f.close()

And I am getting this error
Traceback (most recent call last):
  File "test.py", line 11, in <module>
    f.close()
  File "/opt/conda/envs/rapids/lib/python3.7/site-packages/fsspec/spec.py", line 1483, in close
    self.flush(force=True)
  File "/opt/conda/envs/rapids/lib/python3.7/site-packages/fsspec/spec.py", line 1354, in flush
    self._initiate_upload()
  File "/opt/conda/envs/rapids/lib/python3.7/site-packages/gcsfs/core.py", line 1409, in _initiate_upload
    self.metadata,
  File "/opt/conda/envs/rapids/lib/python3.7/site-packages/fsspec/asyn.py", line 71, in sync
    raise exc.with_traceback(tb)
  File "/opt/conda/envs/rapids/lib/python3.7/site-packages/fsspec/asyn.py", line 55, in f
    result[0] = await future
  File "/opt/conda/envs/rapids/lib/python3.7/site-packages/gcsfs/core.py", line 1492, in initiate_upload
    headers={"X-Upload-Content-Type": content_type},
  File "/opt/conda/envs/rapids/lib/python3.7/site-packages/gcsfs/core.py", line 507, in _call
    self.validate_response(status, contents, json, path, headers)
  File "/opt/conda/envs/rapids/lib/python3.7/site-packages/gcsfs/core.py", line 1222, in validate_response
    raise IOError("Forbidden: %s\n%s" % (path, msg))
OSError: Forbidden: https://www.googleapis.com/upload/storage/v1/b/merlin-datasets/o
Insufficient Permission

I should have both reading and writing permissions, as I can see in the IAM policy.
(rapids) root@b737df9c8ee2:/# gsutil iam get gs://merlin-datasets
{
  "bindings": [
    {
      "members": [
        "projectEditor:merlin-295819",
        "projectOwner:merlin-295819",
<EMAIL_ADDRESS>      ],
      "role": "roles/storage.legacyBucketOwner"
    },
    {
      "members": [
        "projectViewer:merlin-295819"
      ],
      "role": "roles/storage.legacyBucketReader"
    },
    {
      "members": [
        "projectEditor:merlin-295819"
      ],
      "role": "roles/storage.legacyBucketWriter"
    },
    {
      "members": [
        "projectOwner:merlin-295819"
      ],
      "role": "roles/storage.legacyObjectOwner"
    },
    {
      "members": [
        "projectViewer:merlin-295819"
      ],
      "role": "roles/storage.legacyObjectReader"
    }
  ],
  "etag": "CAM="
}

I can actually upload a file to the bucket using gsutil
(rapids) root@b737df9c8ee2:/# gsutil cp test.py gs://merlin-datasets
Copying file://test.py [Content-Type=text/x-python]...
/ [1 files][  190.0 B/  190.0 B]
Operation completed over 1 objects/190.0 B.

It actually works from my machine. It does not work within the GCP Instance, I have to check permissions for the VM.

You might want to try explicitly passing token="cloud" on the VM, if you want permissions to be picked up from the instance metadata - things may be getting confused about which is your "default" credentials. Also, it's useful to explicitly pass your project.


disable preselection

I have 1 entry in a data-live-search="true" dropdown menu. When I open the dropdown menu, the first item is already preselected. How to disable that behaviour? I would like to have no preselection. I need this because I have a "onChange"-method that will execute some code. If the only option is preselected, there is no way to reselect it and trigger the "onChange"-method.
<select class="selectpicker" data-live-search="true">
 <option data-tokens="ketchup mustard">Hot Dog, Fries and a Soda</option>
</select>

This should work by setting the title attribute in v1.10.0, but looks like that functionality was broken in 5a7d0f32220a4d09f0cadc0f569d27b970bb1065. For now, your best option would be to either add the multiple attribute, or add <option data-hidden="true"></option> as the first option.

This is now fixed in the master branch.


realsense_camera: 1.2.0-9 in 'indigo/distribution.yaml' [bloom]

Increasing version of package(s) in repository realsense_camera to 1.2.0-9:

upstream repository: https://github.com/intel-ros/realsense.git
release repository: https://github.com/intel-ros/realsense-release.git
distro file: indigo/distribution.yaml
bloom version: 0.5.21
previous version for package: 1.2.0-0

realsense_camera
* Update for ROS librealsense Package Release
* Added navigation package changes related to camera package refactor
* Updated artifacts to disable native pointcloud by default
* Refactored R200 code into derived class
* Added polling for camera
* Refactored launch and test files
* Contributors: Mark D Horn, Matthew Hansen, Reagan Lopez, Rajvi Jingar

Test of update bloom tool without a firewall.


Something happened to the text entry

City lookup and Notes now bring you to a one line box when adding a new team. . The Notes box also shows one line even though it's using the whole screen.
This is Android.

This may be a side-effect of the keyboard hiding view.

@johnneed See this comment: https://github.com/johnneed/GreenUpVermont/commit/e727f298296ca94a4f7565ea3ddf43b4816f98d0

The docs suggest that the offending prop be added on a platform-specific basis, so that's what I did.  Seems ok on my Android device and the ios simulator.  https://facebook.github.io/react-native/docs/keyboardavoidingview.html#behavior


[BUG] Hardcoded Endpoint for OpenAI

Library name and version
Azure.AI.OpenAI_1.0.0-beta.6
Describe the bug
Hi Team!
Companies create internal API proxies to avoid direct calls to https://api.openai.com/ . But  Azure has OpenAI endpoint hardcoded https://github.com/Azure/azure-sdk-for-net/blob/c8b27f9fca17384a481a1debf565052ffc97b2b9/sdk/openai/Azure.AI.OpenAI/src/Custom/OpenAIClient.cs#L28
without possibility to specify custom endpoint. Constructors use only hardcoded PublicOpenAIEndpoint property
https://github.com/Azure/azure-sdk-for-net/blob/c8b27f9fca17384a481a1debf565052ffc97b2b9/sdk/openai/Azure.AI.OpenAI/src/Custom/OpenAIClient.cs#L120-L131
Expected behavior
It should be possible to specify a custom endpoint. Maybe add one more constructor with _nonAzureOpenAIApiKey = openAIApiKey; code. See
https://github.com/Azure/azure-sdk-for-net/blob/c8b27f9fca17384a481a1debf565052ffc97b2b9/sdk/openai/Azure.AI.OpenAI/src/Custom/OpenAIClient.cs#L120-L131
Actual behavior
Constructors use only hardcoded PublicOpenAIEndpoint property
https://github.com/Azure/azure-sdk-for-net/blob/c8b27f9fca17384a481a1debf565052ffc97b2b9/sdk/openai/Azure.AI.OpenAI/src/Custom/OpenAIClient.cs#L120-L131
Reproduction Steps
OpenAIClient client = new OpenAIClient("your-api-key-from-platform.openai.com");

Response<Completions> response = await client.GetCompletionsAsync(
    "text-davinci-003", // assumes a matching model deployment or model name
    "Hello, world!");

foreach (Choice choice in response.Value.Choices)
{
    Console.WriteLine(choice.Text);
}

Environment
No response

Just to second that, if you want to use i.e. Semantic Kernel to enrich your Blazor WebAssembly application with AI capabilities, you for sure don't want to provide your API key to the browser ;)
It's easy to add a Yarp.ReverseProxy to your server that authenticatces your users based on your normal auth mode (Cookies, Tokens etc.) and then redirects all calls to /openai to your Azure OpenAI endpoints and add the secret Api Key to these requests on the server side, but since you can't set the base url for the pure OpenAI endpoint it's sadly not possible to use these from your web application atm.

Thank you for getting in touch!
There's a generalized mechanism for Azure SDK libraries to configure proxy server use that Azure.AI.OpenAI shares as part of the SDK family; you can see the documentation and an example here:

https://learn.microsoft.com/en-us/dotnet/azure/sdk/azure-sdk-configure-proxy
https://github.com/Azure/azure-sdk-for-net/blob/main/sdk/core/Azure.Core/samples/Configuration.md#configuring-a-proxy

When enterprise and other secured networks limit access to external service endpoints via such a mechanism, this proxy configuration is the preferred way to enable proxied access.
Is this proxy configuration mechanism a viable path for your use case? If it isn't, I'd like to ensure we forward and address the gap holistically, as this situation with operations using static URL bases is shared across many of the Azure SDK libraries.
Thanks again!

Hi,
no, that sadly is not sufficient for our use case.
We use Semantic Kernel, building upon this SDK, in a Blazor WebAssembly application.
With SK and this SDK running directly in the Browser the API Key to Access OpenAI would be unprotected in the open. The OpenAI endpoint should be accessed through the server hosting the web application which can inject an API key. As such we would need to set the Base URL to OpenAI to something like "./api/openai".
It is not possible to create a "system wide" proxy configuration in the Browser. So we need a way to override the Base URI.

@trrwilson Thank you for sharing the proxy configuration. It works for me.

@gingters -- fully understood about environment-variable-based configuration not being viable.
From that second link I shared, there's also a programmatic mechanism to configure a proxy server via client options; pulling that page together with the OpenAI code, it'd be along the lines of:
var httpClientHandler = new HttpClientHandler()
{
    Proxy = new WebProxy("http://my-enterprise.proxy-server.com"),
};
var httpClientWithProxy = new HttpClient(httpClientHandler);
var openAIClientOptions = new OpenAIClientOptions()
{
    Transport = new HttpClientTransport(httpClientWithProxy),
};
var client = new OpenAIClient(
    endpoint: new Uri("https://destination-aoai-resource.openai.azure.com"),
    new AzureKeyCredential("fake-key-to-be-replaced-by-proxy"),
    openAIClientOptions);

This will configure the OpenAIClient instance to use the underlying HttpClient provided, which has in turn been configured (in code, sans environment variable involvement) to use a proxy.
I've scheduled some work for us to add better documentation and test automation coverage to clarify this, but in the interim I've validated by hand that this does indeed invoke a proxy request.


[RFC] [python] prefix all internal object names with "_"

Short Description
I'm opening this RFC to propose the following:

all objects in the Python package which are intended to be internal should have names beginning with _

The convention "anything starting with _ is internal" is common in Python programming. If LightGBM's Python package followed that convention consistently, it would simplify LightGBM's position on which parts of the Python package are considered "internal" and subject to breaking changes in any release.
Detailed Description
In pursuit of the v4.0.0 release (#5153), we have been accepting breaking changes which simplify the project and reduce its maintenance burden, so that limited maintainer time can be focused on providing a good experience with LightGBM's main functionality.
I think "all internal objects should begin with _" is one such type of change. Making it clearer which parts of the Python package are considered internal reduces the surface area of the public API which users need to consider, and increases contributors' flexibility to change implementations without breaking user code.
R packages support a "namespace" concept (see "Writing R extensions"), which clearly separates exported and internal objects, and I think that mechanism has been really helpful. The closest thing that Python has, to my knowledge, is the __all__ member for modules (https://docs.python.org/3/tutorial/modules.html#importing-from-a-package). __all__ controls the behavior of "star imports".
For example, if you run the following:
from lightgbm import *
dir()

the only LightGBM objects you'll see are those in the package's __all__.
This mechanism is a good start, but prefixing all internal objects with _ would be and even stronger signal about which things are internal. It would also improve the consistency of the Python package's code.
Specific Proposal
I am proposing that the following be prefixed with a _ and treated as internal:

https://github.com/microsoft/LightGBM/blob/ff947bfac5148a9b94d045f2879aee183e02e174/python-package/lightgbm/basic.py#L128
https://github.com/microsoft/LightGBM/blob/ff947bfac5148a9b94d045f2879aee183e02e174/python-package/lightgbm/basic.py#L144
https://github.com/microsoft/LightGBM/blob/ff947bfac5148a9b94d045f2879aee183e02e174/python-package/lightgbm/basic.py#L155
https://github.com/microsoft/LightGBM/blob/ff947bfac5148a9b94d045f2879aee183e02e174/python-package/lightgbm/basic.py#L160
https://github.com/microsoft/LightGBM/blob/ff947bfac5148a9b94d045f2879aee183e02e174/python-package/lightgbm/basic.py#L168
https://github.com/microsoft/LightGBM/blob/ff947bfac5148a9b94d045f2879aee183e02e174/python-package/lightgbm/basic.py#L175
https://github.com/microsoft/LightGBM/blob/ff947bfac5148a9b94d045f2879aee183e02e174/python-package/lightgbm/basic.py#L190
https://github.com/microsoft/LightGBM/blob/ff947bfac5148a9b94d045f2879aee183e02e174/python-package/lightgbm/basic.py#L240
https://github.com/microsoft/LightGBM/blob/ff947bfac5148a9b94d045f2879aee183e02e174/python-package/lightgbm/basic.py#L248
https://github.com/microsoft/LightGBM/blob/ff947bfac5148a9b94d045f2879aee183e02e174/python-package/lightgbm/basic.py#L256
https://github.com/microsoft/LightGBM/blob/ff947bfac5148a9b94d045f2879aee183e02e174/python-package/lightgbm/basic.py#L264
https://github.com/microsoft/LightGBM/blob/ff947bfac5148a9b94d045f2879aee183e02e174/python-package/lightgbm/basic.py#L272
https://github.com/microsoft/LightGBM/blob/ff947bfac5148a9b94d045f2879aee183e02e174/python-package/lightgbm/basic.py#L277
https://github.com/microsoft/LightGBM/blob/ff947bfac5148a9b94d045f2879aee183e02e174/python-package/lightgbm/basic.py#L282
https://github.com/microsoft/LightGBM/blob/ff947bfac5148a9b94d045f2879aee183e02e174/python-package/lightgbm/basic.py#L292
https://github.com/microsoft/LightGBM/blob/ff947bfac5148a9b94d045f2879aee183e02e174/python-package/lightgbm/basic.py#L436-L470
https://github.com/microsoft/LightGBM/blob/ff947bfac5148a9b94d045f2879aee183e02e174/python-package/lightgbm/basic.py#L472
https://github.com/microsoft/LightGBM/blob/ff947bfac5148a9b94d045f2879aee183e02e174/python-package/lightgbm/basic.py#L482
https://github.com/microsoft/LightGBM/blob/ff947bfac5148a9b94d045f2879aee183e02e174/python-package/lightgbm/basic.py#L502
https://github.com/microsoft/LightGBM/blob/ff947bfac5148a9b94d045f2879aee183e02e174/python-package/lightgbm/libpath.py#L9

Considerations for Implementation
Check that any name being modified is only used at runtime and not part of the state for objects like Booster or LGBMClassifier which might be pickled (since pickle only stores references to imports and expects to be able to reference them when running load()).
Request for Comment
@StrikerRUS @jmoralez @shiyu1994 @guolinke Whenever you have time, will you please comment here on whether or not you support this proposal? Thank you for your time and consideration.

Thanks for writing this up, I support it. Are we also adding the __all__? I think it's good having both.

Are we also adding the __all__? I think it's good having both.

There is already a __all__ controlling what happens when you from lightgbm import *.
https://github.com/microsoft/LightGBM/blob/1b43214f72e2f42c262f0c79eb35cd185a8654af/python-package/lightgbm/__init__.py#L30-L36
Are you talking about also adding a __all__ to each module, for example one in python-package/lightgbm/sklearn.py that would limit what gets imported by from lightgbm.sklearn import *?
I don't know enough about this to know whether or not that would work. Like I'm not sure if __all__ as a concept is specific to __init__.py files. But I'd be interested in trying it!

Ok nice! I hadn't thought of that. Totally support that idea. I think that new public classes and functions are rare enough in this project that the communication benefit of doing that is worth the slight additional maintenance burden.

I'm +1 for

all objects in the Python package which are intended to be internal should have names beginning with _

Also I'm proposing rethinking which properties of Dataset, Booster and other public classes should be public.
For example, I don't think that pandas_categorical or handle properties should be public.
https://github.com/microsoft/LightGBM/blob/1b43214f72e2f42c262f0c79eb35cd185a8654af/python-package/lightgbm/basic.py#L1200
https://github.com/microsoft/LightGBM/blob/1b43214f72e2f42c262f0c79eb35cd185a8654af/python-package/lightgbm/basic.py#L2581

I'm +1

I'm +1 for this proposal! Thanks.

I'm glad we originally opened this as a good first issue and that some contributors made their first PRs into the project working on it!
But I'm going to take this over and finish it. It's been open for 6 months, and I'd like to get these changes in for v4.0.0 (#5153).

The last piece of this is @StrikerRUS 's proposal to also make some more of the class attributes for public classes private.
Here's my proposal for which class attributes I think we should make private in the v4.0.0 release:

[ ] Booster.handle

ctypes pointer to the Booster object on the C++ side. Keeping this private would allow changing the implementation for how that reference is managed

[ ] Booster.network

used to keep track of whether or not this Booster is actively participating in distributed training, users should only be modifying this via public method Booster.free_network()

[ ] Dataset.handle

ctypes pointer to the Dataset object on the C++ side. Keeping this private would allow changing the implementation for how that reference is managed

[ ] Dataset.params_back_up

implementation detail for parameter-updating, users shouldn't ever think about this

[ ] Dataset.need_slice

used to defer when slicing actually happens when used_indices is modified (including by Dataset.subset()). Users should never be modifying this directly

no changes to lightgbm.dask classes
no changes to lightgbm.sklearn classes
no changes to lightgbm.basic.CVBooster

@jmoralez @guolinke @StrikerRUS @shiyu1994 @btrotta what do you think?


Pull request for information on the timestamp in python

added more information on python timestamp

Something is up with our checks that aren't passing on this PR and the best way I knew how to get this in was to copy into my own PR and credit you, sorry! https://github.com/statsig-io/docs/pull/1496


Use Offender case notes service instead of Prison API

Draft until the client_credentials have been setup in dev

 Migrate to Case Notes service for prison case notes


Profile: Other Organization Widget

Reproduce:

Go to Profile e.g. https://dao.hypha.earth/hypha/@leonieherma1
Check "Other Organizations" Widget

Expected behaviour:
See correct logo and correct Organization name
Experienced behaviour:
Old Hypha logo and "hypha" instead of "Hypha"

@arsenijesavic please make sure the Organization name is cut off if too long with ....
Otherwise the widget gets super long:

@leonieherma1 fixed, when you put mouse on top it shows full name


Bc-feat-draft-package

This PR adds a manifest project.yml to the repository. This allows easier deployment and pip installable routines from a github repo:
pip install git+https://github.com/AllenNeuralDynamics/Aind.Behavior.VrForaging.Analysis

or
pip install git+https://github.com/AllenNeuralDynamics/Aind.Behavior.VrForaging.Analysis@{sha_commit}

or (from the root of the repo)
pip install .

Hey @bruno-f-cruz, while reviewing your PR, I'd suggest the following code changes:
👉 Code Suggestion for #28

https://github.com/AllenNeuralDynamics/Aind.Behavior.VrForaging.Analysis/pull/28

You can also review and apply these suggestions locally on your machine.
Learn more about GitKraken Code Suggest

Code Suggest liberates your code reviews from GitHub's restrictive, comment-only feedback style. As simple as suggesting changes in a Google-doc, provide real code suggestions from where you code, e.g. your IDE, and on anything in your project — not just on the lines of code changed in the PR.

Join your team on GitKraken to speed up PR review.


[zh-cn] sync concepts/extend-kubernetes/api-extension/custom-resources.md

PR Summary

EN upstream: content/en/docs/concepts/extend-kubernetes/api-extension/custom-resources.md
Sync to: content/zh-cn/docs/concepts/extend-kubernetes/api-extension/custom-resources.md

Sync check byscripts/lsync.sh on main branch:
$ scripts/lsync.sh content/zh-cn/docs/concepts/extend-kubernetes/api-extension/custom-resources.md
diff --git a/content/en/docs/concepts/extend-kubernetes/api-extension/custom-resources.md b/content/en/docs/concepts/extend-kubernetes/api-extension/custom-resources.md
index 3979c89d32..2907d2f0fd 100644
--- a/content/en/docs/concepts/extend-kubernetes/api-extension/custom-resources.md
+++ b/content/en/docs/concepts/extend-kubernetes/api-extension/custom-resources.md
@@ -17,7 +17,7 @@ methods for adding custom resources and how to choose between them.
 ## Custom resources

 A *resource* is an endpoint in the [Kubernetes API](/docs/concepts/overview/kubernetes-api/) that
-stores a collection of [API objects](/docs/concepts/overview/working-with-objects/kubernetes-objects/)
+stores a collection of {{< glossary_tooltip text="API objects" term_id="object" >}}
 of a certain kind; for example, the built-in *pods* resource contains a collection of Pod objects.

 A *custom resource* is an extension of the Kubernetes API that is not necessarily available in a default

Sync check byscripts/lsync.sh on sync/custom-resources branch:
$ scripts/lsync.sh content/zh-cn/docs/concepts/extend-kubernetes/api-extension/custom-resources.md
content/zh-cn/docs/concepts/extend-kubernetes/api-extension/custom-resources.md is still in sync

Thanks to the reviewers in advance.
Best Regards,
Kivinsae Fang

The 2 commits were been squashed.
Thanks so much for your review, Michael!


Manually discarding cards with attachments/dupes loses cards

If a card has attachments or dupes when it is discarded or put in the dead pile, the cards that were attached are removed from the game instead of being placed in the correct location

Moved a character to the dead pile after crown of gold attached and crown of gold disappeared


Model training: ignore process metrics that are -1

We purposely put -1 to process metrics in rare cases, where we can't detect the process metrics of that file before a refactoring has happened.
We still store it in the database, so that we can use that data point for models that rely solely on structural metrics.

Tip: Do not do it in the SQL queries, but later in Pandas (and only if PROCESS_METRICS are taken into account)

I will write some tests for the data collection, to identify and understand these cases.


[Dropdown] [Menu] Updates to Dropdown

As a consumer, I want Dropdown to look correct, so that similar components look similar.
AC:

Dropdown matches latest spec

Closing in favor of #382


Surprising difference in validation between collections.abc.Sequence and typing.Sequence

Initial Checks

[X] I confirm that I'm using Pydantic V2

Description
I was upgrading some code to drop python 3.9 support and ran into a validation error when replacing typing.Sequence with collections.abc.Sequence in the example below the basemodel fail to validate without arbitrary_types_allowed if collections.abc.Sequence is used without subscript (which normally would be equivalent to collections.abc.Sequence[Any]
PydanticSchemaGenerationError: Unable to generate pydantic-core schema for <class 'collections.abc.Sequence'>. Set `arbitrary_types_allowed=True` in the model_config to ignore this error or implement `__get_pydantic_core_schema__` on your type to fully support it.

If you got this error by calling handler(<some type>) within `__get_pydantic_core_schema__` then you likely need to call `handler.generate_schema(<some type>)` since we do not call `__get_pydantic_core_schema__` on `<some type>` otherwise to avoid infinite recursion.

For further information visit https://errors.pydantic.dev/2.5/u/schema-for-unknown-type

The same issue (with a slightly different error message) happens in v1
Example Code
from collections.abc import Sequence
from typing import Sequence as TSequence
from pydantic import BaseModel

class DoesNotWork(BaseModel):
    bar: Sequence = [1,2,3]

class Works1(BaseModel):
   bar: TSequence = [1,2,3]

class Works2(BaseModel):
   bar: Sequence[Any] = [1,2,3]

Python, Pydantic & OS Version
pydantic version: 2.5.2
        pydantic-core version: 2.14.5
          pydantic-core build: profile=release pgo=true
                 install path: C:\Users\jenielse\Miniconda3\envs\qcodespip311\Lib\site-packages\pydantic
               python version: 3.11.5 | packaged by Anaconda, Inc. | (main, Sep 11 2023, 13:26:23) [MSC v.1916 64 bit (AMD64)]
                     platform: Windows-10-10.0.22621-SP0
             related packages: mypy-1.7.1 typing_extensions-4.8.

Yes, at least the error message should be more precise. But I think collections.abc.Sequence should just work.

Indeed, this is not the behavior that one would expect. I recently fixed a bug with respect to Sequence validation.
When this issue is addressed, I think we should revisit the refactor I've suggested in this PR: https://github.com/pydantic/pydantic/pull/8614


npm version of deepstream server cannot start

I'm following this tutorial have deepstream installed.
https://deepstream.io/install/npm/
But when I try starting the server, I got the following error:
   __| | ___  ___ _ __  ___| |_ _ __ ___  __ _ _ __ ____
  / _` |/ _ \/ _ \ '_ \/ __| __| '__/ _ \/ _` | '_ ` _  \
 | (_| |  __/  __/ |_) \__ \ |_| | |  __/ (_| | | | | | |
  \__,_|\___|\___| .__/|___/\__|_|  \___|\__,_|_| |_| |_|
                 |_|
 =====================   starting   ======================
INFO | state transition (start): Stopped -> LoggerInit
INFO | logger ready: std out/err
INFO | state transition (logger-started): LoggerInit -> PluginInit
INFO | deepstream version: 3.0.0
INFO | storage ready: no storage connector specified
INFO | cache ready: local cache
INFO | authenticationHandler ready: none
INFO | permissionHandler ready: none
INFO | state transition (plugins-started): PluginInit -> ServiceInit
INFO | state transition (services-started): ServiceInit -> ConnectionEndpointInit
CONNECTION_ERROR | Error: listen EADDRINUSE <IP_ADDRESS>:6020
CONNECTION_ERROR | Error: listen EADDRINUSE <IP_ADDRESS>:6020
PLUGIN_ERROR | connectionEndpoint wasn't initialised in time
/home/junshen/paipai_server/node_modules/deepstream.io/src/utils/dependency-initialiser.js:96
  throw error
  ^

Error: connectionEndpoint wasn't initialised in time
    at DependencyInitialiser._onTimeout (/home/junshen/paipai_server/node_modules/deepstream.io/src/utils/dependency-initialiser.js:94:17)
    at ontimeout (timers.js:488:11)
    at tryOnTimeout (timers.js:323:5)
    at Timer.listOnTimeout (timers.js:283:5)

I've checked the port, there's no process occupying the port 6020. I also tried changing the port, but it still doesn't work!!

I've also been having the same issues as well! Nothing is occupying the port yet I have no issues. I am on Node v6.10.3 and NPM v5.3.0

Thanks for raising, certainly odd! Will take a look at it today

Thanks for raising, certainly odd! Will take a look at it today

Hey, this issue is based on the invalid configuration inside of the npm install.
const DeepstreamServer = require('deepstream.io')
const C = DeepstreamServer.constants
/*
The server can take
1) a configuration file path
2) null to explicitly use defaults to be overriden by server.set()
3) left empty to load the base configuration from the config file located within the conf directory.
4) pass some options, missing options will be merged with the base configuration
*/
const server = new DeepstreamServer('./path/to/config.yml')

// start the server
server.start()

I would recommend pointing to a config path, but http as a top level parameter is generally no longer supported in 3.0, since it is ambiguous to which connection endpoint you are pointing towards. Sorry for the confusion


 Likely due to timelord issues.
Recommend resetting timelords.

stuck 5597

stuck again in 5649

stuck again in 5649

The chain will get stuck periodically until difficulty adjust enough.
The chain should not get stuck for more than 10 minutes at a time.

Stuck again at 5829 for an hour

Idem, Stucked at 5829.

me too ，stop on 5981,long time

There's a chance it can be resolved by someone running the fastest timelord setting higher rate limits -> 10000

stop on 6085

Found Proof but not get the rewards

me too,Found Proof but not get the rewards

Found Proof but not get the rewards

me too

difficulty go down and more people come cause timelord overload, restart many time but still not help. We need to looking for new timelord server to keep running until new difficult got calculated.

Hi
Do you have link for your Road map or Discord
so that we can follow information on that

From: devxeq @.>
Sent: Monday, July 5, 2021 3:18 PM
To: Equality-Network/equality-blockchain @.>
Cc: Akkarawat0510 @.>; Comment @.>
Subject: Re: [Equality-Network/equality-blockchain] [BUG] Chain getting stuck for hours on multiple different heights (#1)
difficulty go down and more people come cause timelord overload, restart many time but still not help. We need to looking for new timelord server to keep running until new difficult got calculated.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHubhttps://github.com/Equality-Network/equality-blockchain/issues/1#issuecomment-873907913, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AUBJMUNFVQ5DTUGG2IN3O4DTWFTF5ANCNFSM47ZPGFDQ.

Hi Do you have link for your Road map or Discord so that we can follow information on that
…
________________________________ From: devxeq @.> Sent: Monday, July 5, 2021 3:18 PM To: Equality-Network/equality-blockchain @.> Cc: Akkarawat0510 @.>; Comment @.> Subject: Re: [Equality-Network/equality-blockchain] [BUG] Chain getting stuck for hours on multiple different heights (#1) difficulty go down and more people come cause timelord overload, restart many time but still not help. We need to looking for new timelord server to keep running until new difficult got calculated. — You are receiving this because you commented. Reply to this email directly, view it on GitHub<#1 (comment)>, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AUBJMUNFVQ5DTUGG2IN3O4DTWFTF5ANCNFSM47ZPGFDQ.

Website equalitychain.org just start develop, coming for detail soon.

There's a chance it can be resolved by someone running the fastest timelord setting higher rate limits in the config.yaml-> 10000

How to set?


[core] Use of 0 instead of null (type inference failed)

Hi, class com.apptentive.android.sdk.comm.ApptentiveClient
    public static java.lang.String getErrorResponse(java.net.HttpURLConnection httpURLConnection, boolean z) throws java.io.IOException {
        java.io.InputStream inputStream = 0; // <<<<<
        if (httpURLConnection == null) {
            return inputStream; // <<<<<
        }
        try {
            java.io.InputStream errorStream = httpURLConnection.getErrorStream();
            if (errorStream != null && z) {
                errorStream = new java.util.zip.GZIPInputStream(errorStream);
            }
            return com.apptentive.android.sdk.util.Util.readStringFromInputStream(inputStream, "UTF-8");
        } finally {
            com.apptentive.android.sdk.util.Util.ensureClosed(inputStream);
        }
    }

APK: https://drive.google.com/file/d/1ICfL4A22K-KhVkw5RwvWdLJA8111iYvG/view?usp=sharing

Short problem description:
Now for some try/catch cases constructed incorrect CFG so variables from catch or finally have incorrect scope.
As soon as to fix that CFG need heavy transformation this break lots of other try/catch cases.

Fixed in 7c0671c81b1512bf5b56fc4962f89be72d413f27. Although be careful, these changes are big, and definitely break something 🙄

Thanks, @skylot!
I see that they're only a few issues left!


MQTT error when starting up

Hello,
I found this in my HA log:
2024-01-03 19:43:50.554 ERROR (MainThread) [homeassistant.util.logging] Exception in message_received when handling msg on 'EVSE1/MainsCurrentL1': 'verride1'
I think it should mean override?

Are you sure your wifi connection is not crippled?

Just a quick update. I fixed the wifi issue (both the EVSEs have now a wired AP 1m away from them instead of 8m). and i redid the modbus wiring to make sure everything is ok.
Unfortunately i still get either:

(you can see in the second block of bouncing values there was actually some charging, so it doesnt bounce to zero but to the Wattage it is charging at (solar mode)
or:

It doesn't matter if i request this data via REST or MQTT, they both see this kind of behaviour, on both the EVSEs.
Running the last update you send me in our previous conversation. I'll update to 3.5 later today to see if the issue persists.


Fine-tune using x2 scale

Hello, can you please provide the following model RealESRNet_x2plus.pth ? What are the models used to fine-tune the super-resolution model x2?

same question

same question

The same question.

I made some changes to the finetune_realesrgan_x4plus.yml file and used the RealESRGAN_x2plus.pth model instead of RealESRNet_x2plus.pth for fine-tuning the x2 model. Here is my .yml file for this work.
finetune_realesrgan_x2plus.zip

have you solved the problem？

have you solved the problem？

Yes, I solved the problem by the last comment that I wrote above.

@xinntao the same question


Upgrade to kamboja 0.0.1-31

Coverage remained the same at 100.0% when pulling 981f0d4ec759ff1a86cdad2265c4e821e67a75cd on ktutnik:master into 148aec57fb92f62d95c6c95dac1242da51d5276f on kambojajs:master.


macOS Intel 64-bit 2.1.0 release!

Here's 2.1.0 for you 😄 https://github.com/webdev03/webdev03/releases/download/v1/Ninetails-darwin-x64-2.1.0.zip

Too many tabs can make Ninetails crash by the way

Thank you for your build!

Too many tabs can make Ninetails crash by the way

That would probably happen with any browser. 😸

No, I mean, the firefox installation I am using right now can handle more than 30 tabs, while a similar amount on Ninetails just makes Ninetails quit and crash.


consumer may receive stale acks from subscriber

in some cases brod_consumer may receive stale 'ack' messages.
e.g. when a subscriber delegates 'ack's to other processes, and itself re-subscribe with a new begin_offset (which cause a buffer reset in brod_consumer).
example:
when pending-acks = [4,5,6]
the subscriber delegate the messages to another process, while the messages are being processed,
the subscriber does a new subscribe call with new begin_offset, which causes buffer reset in brod_consumer.
brod_consumer quickly consumed messages [1, 2, 3] and put to pending-acks.
if the 'ack' message for 4, 5 or 6 is received after the reset,
all newly consumed messages will be removed from pending list.

a second thought: this should not do any harm except for the consumer may fetch more messages than configured in prefetch_count into the buffer.


updates to your LSH

I found your implementation of LSH and started using it.  As I fixed a few bugs, I started refactoring and adding some additional features (such as pluggable minhash algorithms, a multiply hash algorithm alongside xor algorithm).
I created some tests as well, and finally a small utility to see how the implementation of lsh compares to theoretical expectations.
There have been some big changes, so I'm not sure you'll want to roll them in, but since I found your code useful as a jumping off point, wanted to let you evaluate if you like the changes.
Thanks

The MIT license you included is fine with me.


Gw newmodel phptests

Updated for new model. Testing authorize-credit-card, charge-credit-card, capture-previously-authed-amount, void transaction and capture-only

Updated and tested charge-credit-card, void-transaction and refund-transaction with new model

Added debit-bank-account and credit-bank-account tests to PaymentTransactions. Tested. Getting a DECLINED error. Working on


how to create an async client use python

I want to create an async client with python, how could I do it, I can not find any example about it

The response-streaming calls are inherently asynchronous in Python, so the routeguide example should demonstrate the overall mechanics of it.
To make a response-unary call asynchronous, instead of making the call like: response = stub.SayHello(...), you can call the future method of the callable:
call_future = stub.SayHello.future(...)
call_future.add_done_callback(function_to_be_called_when_response_is_received)

for example, the adaptation of the helloworld example would be like:
from __future__ import print_function

import grpc
import time

import helloworld_pb2
import helloworld_pb2_grpc

def run():
  def process_response(call_future):
    print(call_future.result())

  channel = grpc.insecure_channel('localhost:50051')
  stub = helloworld_pb2_grpc.GreeterStub(channel)
  call_future = stub.SayHello.future(helloworld_pb2.HelloRequest(name='you'))
  call_future.add_done_callback(process_response)

if __name__ == '__main__':
    run()
    while True:
        time.sleep(100000)

How does the server code implemented for this example ? Would be helpful if an example of that is posted as well.