[full-ci] Prepare Release 4.0.0

prepares 4.0.0 release

@kobergj @JammingBen @JanAckermann is the web version already the final 7.1.0? Or do we need another bump?

There was no web bump mentioned in the release next step (https://github.com/owncloud/ocis/issues/6838#issuecomment-1675000741) . If we need one then the release will probably be delayed.

That is true. That was overlooked or already done.

Web still needs the final 7.1.0 bump, I was waiting for the final go. I briefed @fschade so he can do releases during my absence.

@kobergj @fschade that gives us two options:

if ocis master has no new changes, we could bump on master and rebase the release branch
bump web on the release branch

We anyway need to rebase to master because of deprecations and other fixes. So the web bump can target master directly


Raspberry grub loading broken

The current Dev build of Raspberry raw images fails to load the grub configuration. Grub falls back to the grub> prompt.
Manually entering the EFI/BOOT/grub.cfg and boot/grub2/grub.cfg commands fails at the first line of the latter cfg file:
search --no-floppy --file --set=root /boot/arm64/loader/linux

because there is no /boot "device"

see #1151


Add relevant titles to pages, fix #330

Fixes #330
I would welcome feedback if any.
It adds better title (as in the ) to pages.

Site path
page title

/
Rust programming language

/lean
Learn - Rust programming language

/learn/get-started
Get started - Rust programming language

/what/cli
Cli - Rust programming language

/what/wasm
Wasm - Rust programming language

/what/networking
Networking - Rust programming language

/what/embedded
Embedded - Rust programming language

/tools
Tools - Rust programming language

/community
Community - Rust programming language

/governance
Governance - Rust programming language

/governance/teams/moderation
Moderation team - Rust programming language

/governance/teams/crates-io
Crates.io team - Rust programming language

/governance/wgs/wasm
Wasm team - Rust programming language

/policies/code-of-conduct
Code of conduct - Rust programming language

/policies/licenses
Licenses - Rust programming language

/production
Production - Rust programming language

/production/users
Users - Rust programming language

I did not follow exactly https://github.com/rust-lang/beta.rust-lang.org/issues/330#issuecomment-440026473
I followed a pattern similar to the Rust book for instance https://doc.rust-lang.org/book/2018-edition/ch03-03-how-functions-work.html
In the browser tab we see the relevant part even when the tab has a narrow width but we still keep some context.
Capitalization could need a change, or a "The" before "Rust programming language" could be relevant.

hi @meven! im curious why you closed this? i simply havent had time to review all PRs, if u reopen i think we‘d be happy to accept- maybe with a few tweaks?

I did not mean to close it, I think I removed the commit by accident from github. I will have to reopen a new PR unfortunately.
I thought it would need some feedback, whether we want a "The" before "Rust Programming language" and then whatever code nitpick it may need.

Reopened at https://github.com/rust-lang/beta.rust-lang.org/pull/531


Update AccessKit-related dependencies.

I beat you with a couple of hours: https://github.com/emilk/egui/pull/3012 :)


InternalError when applying namespace yaml from inside the cluster

I'm attempting to create a namespace via a Jenkins agent running inside the cluster.
Problem:
Error from server (InternalError): error when creating "some-namespace.yaml": Internal error occurred: failed calling webhook "namespaces.hnc.x-k8s.io": Post https://hnc-webhook-service.hnc-system.svc:443/validate-v1-namespace?timeout=30s: dial tcp <IP_ADDRESS>:443: connect: connection refused
However, if I apply the same namespace yaml configuration from outside the cluster, it gets created without issue and with the correct annotations.
I have seen this in a minikube cluster and a KIND cluster. In both, it works when applied from outside.

Hi @nishanacharya what does it mean to apply the namespace from outside the cluster?
From what you described, it seemed you may apply the namespace manifest too fast after installing HNC that the webhooks may not be ready yet. Could you please try applying the namespace manifest 30 seconds after HNC is installed on your failed case?

We can reopen this issue if @nishanacharya or anyone else still have this issue.


Unit test for end-to-end delivery of extra credentials

Need to add unit tests to verify the end-to-end delivery of extra credentials (from client to connector) in case there are future changes that break the path (e.g., changes to Session, Identity, ConnectorIdentity or TaskUpdateRequest).

I was thinking we could add a test-only system table that would return the credentials as an easy way to test this.

I am working on a TestHiveExtraCredential that creates a DistributedQueryRunner with a special DynamicConfigurationProvider that verifies the extra credential in hdfsContext.connectoIdentity.extraCredentials. DistributedQueryRunner::execute takes a Session object with the credentials in Identity and sends it to the testing Presto cluster. This makes sure the credentials are delivered all the way to Hive connector, which has a bit more coverage.

Explored both ways of verifying extraCredentials at connector level:

verify extra credentials in HdfsContext (99f112c7e12f00cd8fc3f1dcfdfdc01fbe37b00d): need fair amount of changes to HivePlugin and HiveConnectorFactory, and it looks nasty which I don't like.
verify extra credentials through a testing SystemTable(#199): it looks cleaner and more elegant. But it does not cover code inside Hive connector.

I pick the second approach and submitted #199.


ListUsers

Description
Defining protobufs to facilitate OpenFGA's upcoming ListUsers functionality which answers the question of "what users relate to a specific resource?". The definitions themselves are not final and are subject to change. Please refer to the ListUsers RFC for more specifics about the API's functionality as well as technical changes that can be expected.
Note: This PR is a draft to enable ListUsers development in the main OpenFGA repo until the ListUsers feature is ready to be released.
References

ListUsers RFC

Review Checklist

[x] I have clicked on "allow edits by maintainers".
[x] I have added documentation for new/changed functionality in this PR or in a PR to openfga.dev [Provide a link to any relevant PRs in the references section above]
[x] The correct base branch is being used, if not main
[x] I have added tests to validate that the change in functionality is working as expected

@willvedd are we introducing StreamedListUsers after an initial sprint on the unary ListUsers? Or should we introduce those protobuf definitions in the scope of this PR?


ember-infinity demo as Ember Twiddle for presenting issues

ember-infinity forever!
Here is the ember-infinity demo as an Ember Twiddle.  People could fork this to mock up their issues.  This could be something for the docs? https://ember-twiddle.com/c08988c41ef999bc0ef34bb0d92c17e5
Ember Twiddle is a great JS Bin sort of thing which lets you use addons in an ember-cli style layout.
I made this on my way to mocking up an issue I'm having (HeroicEric/ember-group-by#12).  I want to group items from an infinityModel.  But it seems that using ember-group-by causes the DOM for whole list to redraw whenever ember-infinity adds new items to the model.  This slows with each page.  Any tips on how to group infinityModel items would be appreciated!
j a m i e

yo @openhouse !  this is a little tricky.  In a situation like this, I'd try keeping the infinityModel array privately, and then creating the groups based on the data in the infinityModel, via the afterInfinityModel hook.
Check it out:
https://github.com/hhff/ember-infinity#afterinfinitymodel
Not sure this approach would work out of the box with ember-group-by, but looking at the logic there, it shouldnt be all that hard to replicate & modify for a data source that's getting larger & larger over time.
Please re-open if this doesn't quite solve your problem!

@hhff  I will try this, thanks!


image do not show up , some times

Sometimes images do not render at all, there is a OBJ image appearing there, what can be done and  how to use a place holder for images

Hello @utkarshGithub !
Let me start with the placeholder. It's possible, for example like this (please note that this is for upcoming 3.0.0 release, but 2.x.x should be almost the same, the only difference is that you have to create own instance SpannableFactory and override image method):
final Markwon markwon = Markwon.builder(context)
        .usePlugin(ImagesPlugin.createWithAssets(context))
        .usePlugin(new AbstractMarkwonPlugin() {
            @Override
            public void configureSpansFactory(@NonNull MarkwonSpansFactory.Builder builder) {
                builder.setFactory(Image.class, new SpanFactory() {
                    @Override
                    public Object getSpans(
                            @NonNull MarkwonConfiguration configuration,
                            @NonNull RenderProps props) {

                        // create an instance of AsyncDrawable
                        final AsyncDrawable drawable = new AsyncDrawable(
                                ImageProps.DESTINATION.require(props),
                                configuration.asyncDrawableLoader(),
                                configuration.imageSizeResolver(),
                                ImageProps.IMAGE_SIZE.get(props));

                        // setResult immediately, this result will be treated as a placeholder
                        // and will be displayed whilst image is loading
                        drawable.setResult(new PlaceholderDrawable(
                                context.getResources().getDrawable(R.drawable.ic_play_circle_filled_18dp_white),
                                Color.RED));

                        return new AsyncDrawableSpan(
                                configuration.theme(),
                                drawable,
                                AsyncDrawableSpan.ALIGN_BOTTOM,
                                ImageProps.REPLACEMENT_TEXT_IS_LINK.get(props, false)
                        );
                    }
                });
            }
        })
        .build();

Although you can use whatever Drawable as a placeholder, including one bundled with your application in resources, I would advice to create an own instance of it. The main reason is: different images will have different sizes, so your raw drawable asset will be scaled to fit the available Canvas. But if you would use something like this:
public class PlaceholderDrawable extends Drawable {

    private final Drawable icon;
    private final Paint paint;

    public PlaceholderDrawable(@NonNull Drawable icon, @ColorInt int backgroundColor) {
        this.icon = icon;

        final Rect rect = new Rect(0, 0, icon.getIntrinsicWidth(), icon.getIntrinsicHeight());

        // do not forget to init with intrinsic width & height
        this.icon.setBounds(rect);

        // also, do not forget to set own bounds to be at least like the icon ones
        setBounds(rect);

        this.paint = new Paint(Paint.ANTI_ALIAS_FLAG);
        this.paint.setStyle(Paint.Style.FILL);
        this.paint.setColor(backgroundColor);
    }

    @Override
    public void draw(@NonNull Canvas canvas) {
        final int save = canvas.save();
        try {

            final Rect iconBounds = icon.getBounds();
            final Rect bounds = getBounds();

            // calculate translation values to center our icon
            // NB this calculations expect icon to be always smaller than actual bounds,
            // which _might_ not always be the case
            final float left = ((float) bounds.width() - iconBounds.width()) / 2.F;
            final float top = ((float) bounds.height() - iconBounds.height()) / 2.F;

            canvas.drawRect(bounds, paint);

            canvas.translate(left, top);
            icon.draw(canvas);

        } finally {
            canvas.restoreToCount(save);
        }
    }

    @Override
    public void setAlpha(int alpha) {
        // no op
    }

    @Override
    public void setColorFilter(@Nullable ColorFilter colorFilter) {
        // no op
    }

    @Override
    public int getOpacity() {
        return PixelFormat.OPAQUE;
    }
}

Then your placeholder will fit the available Canvas and draw a proper background plus centering actual placeholder icon (keeping the image ratio).
Now, you see the ￼(obj) when image is loading or failed loading because for an image to have a proper span, it must have at least one character. I've used ￼(obj) because it is what Android uses in Html.fromHtml, although I do agree that it's not the best option. Actually, I'm going to add a placeholder option to image loading functionality for the next 3.0.0 release. Meanwhile, you still can use errorDrawable when configuring AsyncDrawable.Loader to display when loading had failed.
So. Why some images fail? It's hard to tell. And there could be a million of reasons. The bad part is, current implementation gives no clue what had happened (no error logs, nothing). I'm going to work on that and hope that this change will land in the next release.
🙌

And actually, applying placeholder currently can be achieved in a bit different way (omitting some image handling details):
.usePlugin(new AbstractMarkwonPlugin() {
    @Override
    public void configureSpansFactory(@NonNull MarkwonSpansFactory.Builder builder) {
        final SpanFactory original = builder.getFactory(Image.class);
        if (original != null) {
            builder.setFactory(Image.class, new SpanFactory() {
                @Nullable
                @Override
                public Object getSpans(@NonNull MarkwonConfiguration configuration, @NonNull RenderProps props) {
                    final Object span = original.getSpans(configuration, props);
                    if (span instanceof AsyncDrawableSpan) {
                        ((AsyncDrawableSpan) span).getDrawable()
                                .setResult(/*YOU PLACEHOLDER DRAWABLE*/);
                    }
                    return span;
                }
            });
        }
    }
})

Released in 3.0.0 version. Now it's possible to customize placeholder via image loading configuration


Highlights of character matches get reset when matched twice

Info

Operating System: Pop!_OS 22.04 LTS
Shell: zsh
Terminal: kitty
nvim --version: v0.10.0-dev-2133+g5a8fe0769
fzf --version: 0.29 (devel)

[x] The issue is reproducible with mini.sh

Description
When typing a word twice, the characters matched in the second word will clear the matches from the first one.
To reproduce:

Go to the main neovim repo

Run sh -c "$(curl -s https://raw.githubusercontent.com/ibhagwan/fzf-lua/main/scripts/mini.sh)"

Enter find files with <C-p>

Type "funcs" into the prompt. The first two files will be the correctly matched files funcs.h and funcs.c, with only the "funcs' characters highlighted as matches.

Type an additional " funcs", such that the full prompt now reads "funcs funcs". The order of the files won't change, but now all the highlights of the matched characters will disappear.

The behavior doesn't appear to be the same with just the fzf cli:

Great job with the plugin btw.

This is an upstream bug, apparently when ansi colors are used in the entries it bugs out the second match.
As a workaround you can disable coloring until this gets solved upstream:
:FzfLua files color_icons=false

Huh, interesting. Thank you for the quick response!

Huh, interesting. Thank you for the quick response!

Interesting bug, this only happens to entries that contain an ansi color escape sequence.
Run this in the shell:
echo "\x1b[0;34mblue\x1b[0m\n\x1b[0;34mblue\x1b[0m\n\x1b[0;34mblue\x1b[0m" | fzf --ansi

Now, input bl bl and the match is cleared:

Now run this (last entry isn't color coded):
echo "\x1b[0;34mblue\x1b[0m\n\x1b[0;34mblue\x1b[0m\n\x1b[0;34mblue\x1b[0m\nblue" | fzf --ansi

If you input bl bl again, the entries that have an ansi escape sequence have the bug, but the clear entry does not:

Reported upstream: https://github.com/junegunn/fzf/issues/3596

Thanks! I was just looking for an issue upstream that mentioned something about this.

Thanks! I was just looking for an issue upstream that mentioned something about this.

You're obviously onto some serious edge case here :-)

@jbarap, fixed on upstream master via https://github.com/junegunn/fzf/commit/2a8b65e105ec1a1a9d4cecf947b7267f04453b7c, closing.


<EMAIL_ADDRESS>/ tor@service failing

There is a failed service:
₿ systemctl --type=service | grep tor@
<EMAIL_ADDRESS>                                                                             loaded active     running      Anonymizing overlay network for TCP
●<EMAIL_ADDRESS>                                                                             loaded failed     failed       Anonymizing overlay network for TCP (instance service)

fixed by:
sudo systemctl disable tor@service
sudo systemctl reset-failed tor@service

I wonder it should not be enabled in https://github.com/rootzoll/raspiblitz/blob/2bb53ceb9626c3d4c43c4cf7f76574db9dc7f6e9/home.admin/config.scripts/tor.install.sh#L221
what do you think @nyxnor ?

Yes, reset-failed is a good idea, ACK
  # enable tor services
  sudo systemctl unmask tor@default
  sudo systemctl reset-failed tor@*
  sudo systemctl daemon-reload
  sudo systemctl enable --now tor@ tor@service
  sudo systemctl restart tor@default

reset-failed [PATTERN...]
so tor* would work

that is just  a temporary fix until restart. I think  tor@ should not be enabled at all as it is not part of the default Tor installation either.

no problem, remove it pls.
just discoverede now it is for instances.

On a test recovery on LIT its exiting because of an torsocks error @nyxnor @openoms has anyone of you seen this before?
Jan 17 09:27:38 raspberrypi torsocks[4109977]: could not load config: could not read UI password: mandatory password for UI not configured. specify either a password directly or a file or environment variable that contains the password

@rootzoll this is a litd error just appears with torsocks because the binary is run with tor because of the Lightning Terminal OCnnect would leak the IP otherwise.
Looks like the config does not have the PasswordB placed as the password for the GUI.

OK LIT looks good now.

still there on recovery with latest ceommit on dev:
sudo systemctl list-units --failed
  UNIT                LOAD   ACTIVE SUB    DESCRIPTION
●<EMAIL_ADDRESS>loaded failed failed Anonymizing overlay network for TCP (instance service)

LOAD   = Reflects whether the unit definition was properly loaded.
ACTIVE = The high-level unit activation state, i.e. generalization of SUB.
SUB    = The low-level unit activation state, values depend on unit type.
1 loaded units listed.

₿ sudo systemctl list-units --failed
  UNIT LOAD ACTIVE SUB DESCRIPTION
0 loaded units listed.


Adding images html and css

In this Milestone I implemented all the features for the [Portfolio}(https://github.com/tatouroberto/portfolio)project, including:
Built the layout and styles for the Toolbar (header) section.
Developed the layout and styles for the Headline section.
Most elements were positioned using flexbox.

Hi @tatouroberto,
Invalid Code Review Request :heavy_multiplication_x:
Unfortunately, I cannot proceed to review your code.
You have submitted a project, with the following issues:
Your project's linters are not working

It is a requirement for every project you work on, that your linters work appropriately
https://github.com/microverseinc/linters-config/tree/master/html-css
I suggest you go through the setup documentation in detail to make them work on your repo

Your Code Review Request will be marked as invalid in your Dashboard, so please submit a new one once you are ready 🙏
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.

Invalid Code Review Request does not count into the code reviews limit.


reactor traceId does not relate to non-reactor traceId

Please answer these questions before submitting your issue.

Why do you submit this issue?
[ ] Question or discussion

Question
I have a gateway service based on Spring-WebFlux and a demo service based on Spring-Web.
I found traceIds on skywalking-UI web, but these traces can't be correlated, they are indepent.
Here are my screen shots:
gateway

demo

You can see two traces on the screen shots above. Is there anything I missed?

If there is across threads happens, you need to propagate the Context. Read the plugin dev doc. We can't guarantee your private gateway. The Spring Gateway(the official one) works well.

If there is across threads happens, you need to propagate the Context. Read the plugin dev doc. We can't guarantee your private gateway. The Spring Gateway(the official one) works well.

My gateway is Spring Cloud Gateway (2.1.12). Anyway I will check the doc first and then reply, thanks.

If there is across threads happens, you need to propagate the Context. Read the plugin dev doc. We can't guarantee your private gateway. The Spring Gateway(the official one) works well.

My gateway is Spring Cloud Gateway (2.1.12). Anyway I will check the doc first and then reply, thanks.

Hi, I'm facing the same problem, have you fixed it finally?

If there is across threads happens, you need to propagate the Context. Read the plugin dev doc. We can't guarantee your private gateway. The Spring Gateway(the official one) works well.

My gateway is Spring Cloud Gateway (2.1.12). Anyway I will check the doc first and then reply, thanks.

Hi, I'm facing the same problem, have you fixed it finally?

yes，use the plugin。


Overwriting $dir_dist will cause generated setup.py to fail.

related #508

@margru for reference

@margru question for you, what pip version are you running?

@margru question for you, what pip version are you running?

@arcivanov I am not sure if I remember it but I think it actually didn't matter. In one project it was like 10, in another one like 20. However, I can see that you were able to solve it even without that information. Looking forward to give it a try once it is released.
Thanks.


Twitter Three-legged OAuth Example has a flaw

As currently shown the example will always fail after the pincode is given with a 401 error.  The reason is that oAuth v1.0a requires that the oauth_verifier parameter be present in the POST that is making the access token request.
The fix is to add the it as part of the body parameter:
resp, content = client.request(access_token_url, "POST", body="oauth_verifier=%s" % oauth_verifier)

@joestump doc  has been updated for this right?

It has not.


Update New-TransportRule.md

Docs are incorect.
This works in the Exchange Online as well, as we can see in the internal Wiki documentation. Check the ADO WI.
Work Item in the ADO: 3286802

@m-nestorovic, you and @MithunRathinam need to get together and work this thing out.
Even before Mithun's PR there was longstanding language in the description about [ExceptIf]SCLOver not working in ExO.
No question that the parameters are AVAILABLE in ExO PowerShell, but that doesn't mean much.


MM-47097 :  Migrate "components/message_with_additional_content.jsx" to Typescript

Summary
Migrate message with additional content component to typescript
Ticket Link
Fixes https://github.com/mattermost/mattermost-server/issues/21072
Fixes https://mattermost.atlassian.net/browse/MM-47097
Related Pull Requests
NA
Screenshots
NA
Release Note

Hello @VishakhaPoonia,
Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here.

E2E tests not automatically triggered, because PR has no approval yet. Please ask a developer to review and then try again to attach the QA label.

/release-note-none

Good job overall, thanks for the effort. There are just small comments to clean the code more

/e2e-test

Successfully triggered e2e testing!
https://git.internal.mattermost.com/qa/cypress-ui-automation/-/pipelines/246206

@vi

@jgilliam17 this is ready for Testing

@AshishDhama there is still one item to be completed. Please see my comment above related to unused props

@AshishDhama there is still one item to be completed. Please see my comment above related to unused props

@sinansonmez I don’t see any unused props could you please point them out

After changes, these 2 props are not used anywhere in rhs_comment.tsx
https://github.com/mattermost/mattermost-webapp/blob/8000c99e258281b2f0c673f2078e6ea344adc27d/components/rhs_comment/rhs_comment.tsx#L57-L58

This PR has been automatically labelled "stale" because it hasn't had recent activity.
A core team member will check in on the status of the PR to help with questions.
Thank you for your contribution!

/update-branch

@VishakhaPoonia only @sinansonmez review is remaining, can we get this across :)

@sinansonmez Could you please take another look?

Successfully triggered e2e testing!
https://git.internal.mattermost.com/qa/cypress-ui-automation/-/pipelines/252480

Thanks @VishakhaPoonia
Tested, looks good to merge.
E2E report - no PR related failures.
@M-ZubairAhmed can you please approve the last workflow and merge? thanks 🙂


Async operation invoked prior to backoff delay

Thanks for this useful crate!
I ran into some unexpected behavior around the timing of retries and finally got to the bottom of it. When a transient error occurs, backoff::future::Retry sets the sleeper delay but then immediately invokes the operation function, without waiting for the delay to elapse:
https://github.com/ihrwein/backoff/blob/587e2da8fb2dcfc65ca544cb9249022c51f1406e/src/future.rs#L189-L192
The future returned by the operation doesn't get polled until after the delay has elapsed, but simply invoking the operation function may be sufficient for the relevant operation (e.g., a DB query) to be initiated. In my case, I observed that a DB operation was completing prior to the backoff delay elapsing, when it shouldn't have even been initiated at that point.
Whether this causes a problem depends on the structure of the operation function. If the whole thing is wrapped in an async { ... } block, then it appears that the code doesn't get executed until the first poll, which is after the backoff delay. However, if the function executes some code and then returns a future, the operation will start immediately, in parallel with the backoff delay.
My suggestion is to defer the invocation of this.operation until after the backoff delay elapses, or at least to document this nuance :-)

Here's a visual illustration of the issue from a Honeycomb trace:

Notice the delay of about 17s following the final attempt (which returned Error::Permanent). The timing bar at the top represents the span of the entire call to retry().


[RFC] Defining PR roles

Proposal:
Specify responsibilities for PR reviewers/assignees.
I propose that the following guidelines apply to all PRs created in the Artsy org:
Reviewers
All people designated to review a PR must submit a review before the PR can be merged. They should make a good-faith effort to review within 24 hours of being assigned, unless the PR's author specifies otherwise in the body of the PR. If they require more time for any reason, they should communicate with the author of the PR so that the author can designate a different reviewer if need be.
Assignees
The person assigned to the PR is responsible for doing a final review and merging the PR after other reviews and edits have been completed. It is still the responsibility of the PR's author to get the PR to the point where it is ready to be merged. It is also the author's responsibility to notify the assignee when they believe the PR is ready to be merged, at which point the assignee should make a good-faith effort to merge or request changes within 24 hours.
Major PRs should not be self-assigned. This ensures that there is a final check from a fresh pair of eyes on before the PR is merged. Other "levels" of PR can be self- or other-assigned based on the author's judgement.
Reasoning
Different engineers have different practices when it comes to PRs. Some ask 3 - 4 people to review, some only 1 person. Some self-assign their PRs, while others assign them to teammates.
This can create a lot of confusion, especially when engineers transition between teams and have to adjust to the styles of their new collaborators. It also slows the pace of progress, as it maybe be unclear who is responsible for making sure a PR is merged as fast as safely possible.
Exceptions:
Ideally, this would be applied across teams and individual engineers so that everyone has the same expectations for what happens when they create a PR and designate reviewers and assignees. This would require close to 100% agreement on what these roles are and mean, so I'll do my best to make sure that everyone has a chance to voice their opinions or concerns.
The timelines may also change depending on the urgency of the PR. Ideally, authors will note things like "this is a high-priority PR and would ideally be merged within the next few hours" or "this is a low-priority PR and as such could wait until so-and-so gets back from vacation to review, since they're the most familiar with this system." Could be a good case for a peril rule + auto-tagging, actually.
How is this RFC resolved?
If we're able to agree on guidelines, those guidelines would become part of Artsy's README and would be surfaced to new hires. They would also be raised in Engineering standups and in the #dev channel to ensure that the whole team is aware and onboard.

Awesome write up! A couple thoughts:
First, I think the assignee should be able to merge even if all the reviewers haven't chimed in. My experience has been that some reviewers struggle to get feedback in time and some never do!
Second, implicit in the proposal is an assumption that there is only one person assigned to a PR - might be worth calling that out? I've seen some PRs with multiple assignees so this might be a change for some! Could also be an opportunity for a Peril warning? Something like:

Oops, looks like you assigned more than one person the PR, link to docs here.

Overall, I think there's a lot of value in striving for a consistent approach to PRs even if there are sometimes exceptions. Thanks again for raising this! ❤

Thanks for writing this up! Still need to read through it, but pasting previous discussion for reference.

Just noting that, however this is resolved, it should be integrated with the existing recommendations around pull requests: https://github.com/artsy/README/blob/master/playbooks/engineer-workflow.md#pull-requests
And here are some personal reactions:

All people designated to review a PR must...

Clarity around review requests would be helpful. Currently we seem to use them as FYIs while the assignee is "required," so I would not want to require reviewers' responses before merging. However we could agree to use them more strictly (and just @-mention those that need FYIs in the PR bodies instead).

The person assigned to the PR is responsible...

I agree with most of this. I'd just add that assignees can be modified over the course of changes and reviews. E.g., instead of the assignee saying "feel free to merge once X is complete..." s/he can simply un-assign themselves and assign the contributor or another reviewer it's waiting on.
P.S. I like making the 24-hour expectation explicit even if it's not enforced. I.e., if you need any action before this time period, you need to ask explicitly.

Major PRs should not be self-assigned...

I'd go further than this. Code review is one of the most fundamental quality tools we have, so I'd recommend assigning others even when changes seem trivial. Occasionally when a merge is needed urgently it's forgiven to self-merge, but that doesn't mean it shouldn't still be reviewed by the assignee [later].

(wrong button sorry)

+1 against forcing all reviewers to leave a review
Everything else looks solid

Ok, made some updates to the original.
Key changes:

Changed "reviews completed before merge" to be recommended and added some language around cc'ing folks (thanks @jonallured, @alloy, @joeyAghion, and @orta!)
Added block about assigning to a single person (thanks @jonallured!)
Added block about the assignee's options after they've reviewed (thanks @joeyAghion!)
More strongly recommended assigning someone to ALL PRs and not just major ones (thanks @joeyAghion!)

Let me know if you have more comments! I'll also solicit other feedback throughout the week in the hopes of getting to something the whole team is happy with

In my personal experience I sometimes make self assigned small PRs and merge them if it is relatively trivial and I need those changes to be in very fast. But in this case I also assign somebody as reviewer and assume that it's helpful as a sanity check even after the fact.

@mdole super stoked that you opened up an RFC on this topic. I have been thinking about doing the same for a while now, but you beat me too it! I'd love to riff off of the conversation already present and provide a few other recommended changes while this topic is fresh on some peoples' minds.

Punchline (TL;DR)
From an operational perspective, I propose that we:

Always have 1 Reviewer, even if this reviewer is the sole Assignee.

this will allow us to potentially require that an approving review is submitted before merging PRs to Tier 3 (Critical) systems (see @joeyAghion's open relevant RFC https://github.com/artsy/README/issues/176).

Enforce a 24 hour window from first PR review requested to  first PR review request submitted via Peril/relevant automation.
Reframe Assignee field values from the "required reviewer" to the "person who should take the next step for a PR".

If a non-assigned reviewer (Person A) reviews the PR first and would like some follow-up action from another individual, which may or may not be the PR author, (Person B), then Person A should be at liberty to re-assign to Person B.

RFC responses / Motivation

People assigned to review a PR should ideally review before merge. It is not required that all reviewers complete reviews, but it is recommended. Authors should also do their best to limit the number of reviewers in order to keep PRs moving quickly. Developers who should be notified of the PR but whose review is not required before merge should be cc'd in the PR body instead of assigned to review.

In my experience at Artsy, often times one of the PR's requested reviewers provides timely and relevant PR review before the assignee does. While, at one level, the ambiguity of this workflow bothers me, taking a step back, I think often this non-assigned reviewer is usually more excited to review the code and/or perhaps has more context/capacity to review.
This is all to say that while the assignee workflow step might be in attempt to avoid some form of a "bystander" effect / general lack of ownership problem, I think that isn't something to solution around ATM.

Reviewers should make a good-faith effort to review within 24 hours of being assigned, unless the PR's author specifies otherwise in the body of the PR. If a reviewer requires more time for any reason, they should communicate with the author of the PR so that the author can designate a different reviewer if need be.

I am extremely pro setting an expectation for PR review response time. I think setting this value to an aggressive but reasonable value (and one that is enforced) is super high-leverage as it sets an upper bound in a long and blocking step in the software development lifecycle (SDLC). I think resolution of this PR should include a task to enforce this time via Peril/relevant automation (and I will gladly pair with anyone to make this happen).

I'd go further than this. Code review is one of the most fundamental quality tools we have, so I'd recommend assigning others even when changes seem trivial. Occasionally when a merge is needed urgently it's forgiven to self-merge, but that doesn't mean it shouldn't still be reviewed by the assignee [later].

Strongly agree with @joeyAghion here. In fact, I'd recommend changing this issue's description from "Major PRs should not be self-assigned." to "PRs should not start off as self-assigned". Yes, there are always exceptions to this rule, but that can be included in the exceptions section of this RFC. The "start off" language is to provide clarity that there are some times that the author might be assigned (for example, if they are making changes due to PR feedback)
Acknowledging that this might "stretch" the scope of the @mdole's original RFC, I would like to propose that always a PR have a Reviewer. Github has a lot of features that Artsy could decide to use with regards to Code Review rule setting (i.e. requiring reviews before merging) – so I think moving to a SDLC that is rooted around a GH Reviewer would, from a infrastructural perspective, set us up for success and future iteration on our SDLC. Moreover, I think there is a lot of value in the clarity provided by Approved and Changes Requested statuses on the GH review object.

Oh yes, I would love for there to be a shared understanding that we use the “Changes Requested” feature of GH reviews when you want really do want changes to be made.

Between email and Jasper I've got a number of filters set up to try to make sure I see the notifications I need to see and don't see the others, but it's still not always 100%. I broadly agree with everything in this RFC, the only thing I'd maybe want to add is some standardization around notifications?
Could we have peril send a slack message whenever we get assigned to a PR? Or if it's our PR, whenever someone submits a review? I find that the feedback loop via slack tends to be a lot tighter than checking for notifications across other apps.

I'm a 👍 @mdole The feedback applied to the RFC looks good, one thing I'd change, though, is this:

should be cc'd in the PR body instead of assigned to review

This is a pretty big departure from some of our workflows, could we highlight this somehow by moving it into its own paragraph or making it bold or something?

@mbilokonsky We used to have a "no slacking on PRs" slack bot that would DM you if you were assigned to an open PR after so long, might be useful to bring back.

Note: if we're going to do any sort of Slack integration, I'd hope that it would be opt-in or at least a way to opt-out. I'm not a fan of that workflow and have something that works for me. Getting Slack messages about PR lifecycle events would be noisy for me.

Reviewers should make a good-faith effort to review within 24 hours of being assigned

How do you feel about rephrasing this to "within one business day" of being assigned to account for pull requests opened on Friday? I assume that we would expect an assignee to review by Monday in that case and not by Saturday.

Major PRs should not be self-assigned...

I wonder if we can further tease this apart. Maybe if we agreed to avoid review requests for FYIs (and instead encourage CCing in the PR description), we could further lean into review requests to signal "I'd like you to review this diff" and assigning or self-assigning simply shifts the power to merge.
I think this also gets at a discussion of what makes a pull request ready to merge? Some potential guidelines:

All CI status checks should be green
Peril/Danger status checks should be green
At least one review approval submitted

The role of the assignee might then become:
The PR assignee is responsible for merging this PR once the ReadyToMerge:tm: guidelines are satisfied.
If no assignee is specified, I think that should mean the author is on the hook to merge.
One question I have with that approach is if the author would have to request a review and assign the same person to signal 1. Please review this diff and 2. Please merge if all is :heavy_check_mark:.

@dblandin @dleve123 thanks for the thoughtful feedback! I agree with much of what you've laid out—here are the updates I propose making to this RFC before resolution:

Change language around time guidelines to "one business day" (Devon)
Update assignment section to specify that:

PR is ready to merge when CI is green, Peril/Danger is green, and 1+ reviews have been submitted (Devon)
PRs should not initially be self-assigned (Daniel)
If the same person is both asked to review and assigned, they should review thoroughly and then move the PR forward by requesting changes/merging/re-assigning, as discussed elsewhere in that section (Devon)
Clearly split out the responsibilities of assignees and reviewers - reviewers review, assignees move the PR forward and need only review if they are also specified as reviewers (Daniel + Devon)

If this sounds good to you, I'll make these updates tomorrow and get this RFC on the road to resolution.

Resolution
We have resolved to adopt this RFC.
Level of Support
2: Positive feedback. There were suggestions for improvement, but no one raised objections to the content of the proposal.
Additional Context:
Responses were pretty favorable across the board. Some things that could become follow-up RFCs:

@mbilokonsky's suggestion to add Peril/Slack messages notifying assignees when assigned, and/or notifying authors when someone has submitted a review

Next Steps
I will submit a PR to the README documentation, both covering this change in a document and adding it to the required reading for new team members. That PR will also include an update to the Engineering workflow documentation on PRs, since this RFC impacts that document.
Once that PR is merged, I will share the final document in the #dev channel.
I will also implement Peril rules (going to shoot for this week) for the following:

Ping reviewers if they have not submitted a review after one business day of being requested - @dleve123 thank you for the suggestion!
Notify an author if they assign more than one developer to a PR (thanks @jonallured!)

Exceptions
None that I can think of!


Create chosen-es6

Hi @Kepro, thanks for your PR.
Is this only a new file with the Coffescript compiled in es6?
If it is, I'd rather leave the coffeescript at bower, so you can make this build depending on your project.


DPO evaluation error---tensors on two devices

Hi!
Thanks for the awesome codebase. I ran the DPO example trl/examples/dpo.py but encountered an error at the evaluation step: Expected all tensors to be on the same device, but found at least two devices, cuda:0 and cpu!
Here is a colab notebook that shows this problem. To expose the problem faster, I set training_args.eval_steps = 1.
To solve it, a hotfix can be adding .to(self.accelerator.device) at a few places in concatenated_forward:
all_logits = model(
    concatenated_batch["concatenated_input_ids"].to(self.accelerator.device),
    attention_mask=concatenated_batch["concatenated_attention_mask"].to(self.accelerator.device),
).logits.to(torch.float32)
all_logps = self._get_batch_logps(
    all_logits,
    concatenated_batch["concatenated_labels"].to(self.accelerator.device),
    average_log_prob=False,
)

However, I am not sure why the trainer does not handle the device change automatically. If this hotfix is fine, I can submit a pull request. Otherwise, I'm also happy to learn how to address this problem more generically.
Tianlin

Hi @liutianlin0121
Thanks very much for the clean reproducer, this sounds like definitely the right fix. Would you mind contributing and opening a PR so that the community can benefit from the fix🙏
Thanks very much!

also cc @kashif

Thanks @younesbelkada @lvwerra for the response and @kashif for the fix! Closing the issue.

@liutianlin0121  i never tested it on multiple gpus.... so lesson learned! thanks for the report.
BTW as an aside, I love your optimal transport paper, the code is only in jax or also in pytorch?

@kashif Thank you! The implementation of the sparsity-constrained OT is in both Pytorch and Jax. This repo contains colab notebook demos of both :-)

Hi @kashif,
I am trying to run dpo with fsdp and getting similar error again
File "/pkg/modal/_container_entrypoint.py", line 349, in handle_input_exception
yield
File "/pkg/modal/_container_entrypoint.py", line 467, in run_inputs
res = imp_fun.fun(*args, **kwargs)
File "/root/train.py", line 237, in main
trainer.train()
File "/opt/conda/lib/python3.10/site-packages/transformers/trainer.py", line 1537, in train
return inner_training_loop(
File "/opt/conda/lib/python3.10/site-packages/transformers/trainer.py", line 1864, in _inner_training_loop
tr_loss += tr_loss_step
RuntimeError: Expected all tensors to be on the same device, but found at least two devices, cuda:0 and cpu!
Can you please help?

Hi @kashif,
I am trying to run dpo with fsdp and getting similar error again File "/pkg/modal/_container_entrypoint.py", line 349, in handle_input_exception yield File "/pkg/modal/_container_entrypoint.py", line 467, in run_inputs res = imp_fun.fun(*args, **kwargs) File "/root/train.py", line 237, in main trainer.train() File "/opt/conda/lib/python3.10/site-packages/transformers/trainer.py", line 1537, in train return inner_training_loop( File "/opt/conda/lib/python3.10/site-packages/transformers/trainer.py", line 1864, in _inner_training_loop tr_loss += tr_loss_step RuntimeError: Expected all tensors to be on the same device, but found at least two devices, cuda:0 and cpu!
Can you please help?

Hi did you find the soltuion?


feat: highlight active heading in sticky toc

Enhances the table of contents component on the right to show the active headline
https://github.com/user-attachments/assets/fe81e186-9201-45db-a719-1a393b08bcc8

I think this can probably be closed now; thanks for letting me ape your JS for #699 !


I can`t edit and write anything there

Type: Feature Request
I open my projest and I cant edit anything here. I create new vue.js app and I opened it next day and I cant do anything with it. Can you please help me find solution to this problem. I have very important project to do till next week and I can`t remake it every time.
VS Code version: Code 1.84.2 (Universal) (1a5daa3a0231a0fbba4f14db7ec463cf99d7768e, 2023-11-09T10:52:33.687Z)
OS version: Darwin arm64 22.2.0
Modes:

We closed this issue because it is a question about using VS Code rather than an issue or feature request. Please search for help on StackOverflow, where the community has already answered thousands of similar questions. You may find their guide on asking a new question helpful if your question has not already been asked. See also our issue reporting guidelines.
Happy Coding!


fixed model parameter defined but not used

Hi Nick, I'm using the ChatGPT extension. I've checked the project configuration, but the model parameter doesn't appear in the code. This means that users will always be using gpt-3.5 even if they choose gpt4.

Brilliant, thanks for this!


Cannot read property 'route' of null

Router.getLangCode = function () {

    var langCode = null;
    var url = this.current().route.path(); //Cannot read property 'route' of null

    if (this.options.i18n.getLangCode) {
        langCode = this.options.i18n.getLangCode.call(this, url);
    }

    return langCode;

};

I am using Router.getLangCode as below:
getUserLanguage = function () {
 	return Router.getLangCode();
};

if (Meteor.isClient) {
  Meteor.startup(function () {
    Session.set("showLoadingIndicator", true);

    TAPi18n.setLanguage(getUserLanguage())
      .done(function () {
        Session.set("showLoadingIndicator", false);
      })
      .fail(function (error_message) {
        console.log(error_message);
      });
  });
}

The problem is that during startup phase the current controller has not yet been set so {{{this.current()}}} is null. I think the method can be rewritten to just use current url.

Ok, this patch should solve your problem and improve a bit other edge cases.
By the way my suggestion is to use I18NConf.getLanguage to get current language, Router.getLangCode is just a utility method to extract the language code from the url (if any!).

Had change my code yesterday to use I18NConf.getLanguage. Thx


[DOC] - Panel apps occasionally no longer visible in JupyterLab

Preliminary Checks

[X] This issue is not a question, feature request, RFC, or anything other than a bug report. Please post those things in GitHub Discussions: https://github.com/nebari-dev/nebari/discussions

Summary
I've had a situation happen a few times where I was working with Panel one day and I come back the next day and the app will no longer display in a jupyter notebook. This happens with no changes to the notebook, or the environment.
Looking in the java console, at the beginning of the traceback there is a statement Bokeh: BokehJS was loaded multiple times but one version failed to initialize. Then, every time you try to visualize a panel object the java console shows ERROR: Unable to run Panel code because Bokeh or Panel library is missing.
I've spent loads of time trying to figure out how it got in this state and I've gotten nowhere. The workaround I've been using for a while is to shut down my server, and open an incognito window and restart the server there. So I'm fairly certain this is a caching issue of some sort.
Today I discovered a better solution - if you shutdown ALL your open kernels, restart and clear all in the notebook, save the notebook, then REFRESH the whole browser page... it will start working again. Note - if you simple restart and clear all on just one notebook, it will not fix it.
I'm not sure why this is happening, but I've had to deal with this enough times and have spent enough time being baffled, that I think its worth an FAQ mention on how to fix.
Steps to Resolve this Issue

Shutdown all kernels
Restart and clear all in the notebook of interest ()
Save the notebook
Refresh the browser.

If this happens again, I'd first want to check if a browser refresh alone would work, then I'd add these other steps in one by one. Since I can't reproduce the error, I'm not sure what is the minimal required.

This happened to me again today. Here is what I tried:

browser refresh alone - didn't fix
browser refresh and kernel restart clear all - didn't fix
kernel restart clear all, save, and then browser refresh - fixed it

This happened again this afternoon. A few more data points:

browser refresh and save - didn't fix
browser refresh and kernel restart clear all AND save - didn't fix
kernel restart clear all and then browser refresh - fixed it (no save)


fixed currency position for nl-NL

for locale nl-NL, I think the currency symbol should come before the value
the browser's Internationalization API seems to agree
Intl.NumberFormat(‘nl-NL’, {style: ‘currency’, currency: ‘EUR’}).format(123.567)

Could you fix tests as well?

sure, sorry about that

Could you squash your commits and add yourself in the AUTHORS file? 😄
Your PR looks good otherwise 👍

why closing it?


Input component's InputProps interface gives no-empty-interface ESLint error

Hi! I have a NextJS project using TypeScript, and I just installed the Input component. ESLint flags the following line of the generated input.tsx component:
export interface InputProps
  extends React.InputHTMLAttributes<HTMLInputElement> {}

With the following error: "An interface declaring no members is equivalent to its supertype."
As the error message states, the InputProps interface has no members, which is causing the problem.
**Steps to Reproduce: **

Install shadcn with all the default options suggested by the installer.
Run npx shadcn-ui@latest add input
See the ESLint error on the InputProps interface inside the generated Input component

I'm using npm as my package manager, if it helps. Thanks!

I have the same error for textArea component.

Same for TextArea - Even though they improve readability, it would be better to strip these off to avoid these issues. This errors breaks Vercel's build.

This issue has been automatically closed because it received no activity for a while. If you think it was closed by accident, please leave a comment. Thank you.

I don't think this should be closed - this issue causes errors on deploying into Vercel (Next 14 - App Router - t3 stack). There should be at least a solution proposed for this (either bypassing Vercel or not causing it at all).

Agreed, still got this issue

This is still an issue shound't be closed yet

Still happening.
**_Failed to compile._**

./src/components/ui/input.tsx
5:18  Error: An interface declaring no members is equivalent to its supertype.  @typescript-eslint/no-empty-interface

Replacing the empty interface with this snippet works for me.
export type InputProps = React.InputHTMLAttributes<HTMLInputElement>

Same error.

I am getting the same issue and I feel it should be fixed

Hola, el problema se debe a que InputProps se encuentra vacio por lo que el compilador marca el error, ya que no encuentra sentido usarlo. Pueden sustituir el código del componente input por el siguiente
import * as React from "react"
import { cn } from "@/lib/utils"
const Input = React.forwardRef<HTMLInputElement, React.InputHTMLAttributes>(
({ className, type, ...props }, ref) => {
return (
<input
type={type}
className={cn(
"flex h-9 w-full rounded-md border border-input bg-transparent px-3 py-1 text-sm shadow-sm transition-colors file:border-0 file:bg-transparent file:text-sm file:font-medium file:text-foreground placeholder:text-muted-foreground focus-visible:outline-none focus-visible:ring-1 focus-visible:ring-ring disabled:cursor-not-allowed disabled:opacity-50",
className
)}
ref={ref}
{...props}
/>
)
}
)
Input.displayName = "Input"
export { Input }

Having the same issue here.
Maybe that's because I installed from @shadcn and not @shadcn-ui in my Next project?
It's what is recommended in the docs.
https://ui.shadcn.com/docs/installation/next

Hey there,
You can disable the check temporally on .eslintrc.json:
"rules": {
    "@typescript-eslint/no-empty-object-type": "off"
  }

Learn more here: https://nextjs.org/docs/basic-features/eslint#disabling-rules

Hey there,
You can disable the check temporally on .eslintrc.json:
"rules": {
    "@typescript-eslint/no-empty-object-type": "off"
  }

Learn more here: https://nextjs.org/docs/basic-features/eslint#disabling-rules

thats now working

I use .eslintignore instead:
/src/components/ui/**.tsx
/src/types/nav.ts

This method may be better than off the whole rule.

I use .eslintignore instead:
/src/components/ui/**.tsx
/src/types/nav.ts

This method may be better than off the whole rule.


ISPN-14601 SSCAN resp command

https://issues.redhat.com/browse/ISPN-14601
Based on HSCAN, the content set is turned into a map to respect the iterator framwrk style

@rigazilla please rebase


It needs to be clearer what will be auto-run

Testing #199158
For this line, presumably there is only one AI action available.

But I have no idea what that action is... and what will be executed when I open inline chat.
It opens with /doc:

I think this should be more clear that this will happen as it's a bit jarring.
Also https://github.com/microsoft/vscode/issues/199425 will help here I think

Yes that's a very good point, if an action is auto-ran I will put the action title in the hover message.

@aiday-mar Is there a way to override the autorun from the code action?

I am working on changing the arguments if the command ID is inlineChat.start. I will create a new args object but set autoSend to false

So I have one PR to show the action title in the sparkle hover: https://github.com/microsoft/vscode/pull/199521
And one PR which disables autoSend when invoking inlineChat.start : https://github.com/microsoft/vscode/pull/199680


install.sh doesn't work

It looks like the install.sh script should copy the twistlock_authz_broker directory into /usr/bin/ but for some reason that directory doesn't exist in the repo:
[root@docker04 authz]# pwd
/var/tmp/authz
[root@docker04 authz]# ls -l
total 32
drwxr-xr-x 2 root root    72 Jul 11 07:21 authz
drwxr-xr-x 2 root root    20 Jul 11 07:21 broker
drwxr-xr-x 2 root root   119 Jul 11 07:21 core
-rwxr-xr-x 1 root root   409 Jul 11 07:21 Dockerfile
drwxr-xr-x 3 root root    54 Jul 11 07:21 Godeps
-rwxr-xr-x 1 root root   389 Jul 11 07:21 install.sh
-rwxr-xr-x 1 root root 11358 Jul 11 07:21 LICENSE
-rwxr-xr-x 1 root root   607 Jul 11 07:21 Makefile
-rwxr-xr-x 1 root root  7489 Jul 11 07:21 README.md
[root@docker04 authz]# cat install.sh
#
#!/usr/bin/env bash

name=twistlock_authz_broker
cp ./twistlock_authz_broker /usr/bin/

cat <<SERVICE > "/lib/systemd/system/twistlock-authz.service"
[Unit]
Description=Twistlock docker authorization plugin
After=syslog.target
[Service]
Type=simple
ExecStart=/usr/bin/authz-broker
[Install]
WantedBy=multi-user.target
SERVICE

# sudo systemctl enable my-app
# sudo systemctl start my-app[root@docker04 authz]#
[root@docker04 authz]# ./install.sh
cp: cannot stat ‘./twistlock_authz_broker’: No such file or directory
[root@docker04 authz]#

same issue (on centOS 7)

thanks @royeectu @ahmed-bacha you need to build the authz service before running install.sh.
You should also validate you have the twistlock_authz_broker in the folder from which you run the install script.
Thanks,
Liron

@liron-l thanks for your prompt answer, I think that it should be added to the documentation.

Thanks @royeectu for the suggestion,
I updated the documentation, see the setting up local dev environment section for more details

Thanks @eranyanay


Fix secondary navbar dropdown

https://github.com/grayjay-sources/grayjay-sources.github.io/blob/main/index.html#L139-L143

It just looks super ugly right now.

can't pull request, here try to review this      Css  .dropdown-menu {
display: none;
}
.dropdown-menu.show {
display: block;
}
.dropdown-item {
display: block;
padding: 0.5rem 1rem;
clear: both;
font-weight: normal;
color: #f5f5f6;
text-align: inherit;
white-space: nowrap;
background-color: transparent;
border: 0;
transition: transform 0.3s, background-color 0.3s;
transform-origin: center;
}
.dropdown-item:hover {
background-color: #777778;
transform: scale(1.05);
padding: 0.6rem 1rem;
}

Doesn't Bootstrap have a native way to add secondary navbar items?

Bootstrap does not have a dedicated, native "secondary navbar" component directly built into its core library. However, you can create secondary items in a navbar by using Bootstrap's flexible layout utilities and component combinations.

do you want to work with only native or costum css? hook me up, i can work on the backend too


Some questions about the index page

superset==0.17.0
May i can ask some questions about the homepage that i would like to go directly to a default dashboard instead of showing a list of dashboards when i landed an account, is it more reasonable?

Same question about it, or it's better can redesign the landing index page.

Notice: this issue has been closed because it has been inactive for 403 days. Feel free to comment and request for this issue to be reopened.


Nested element in element#id selector gives parse error.

Hi,
`section#prosjekter {
article {
}

}
`
Gives me an unexpected parse error: "Unexpected parse error in fileat line 1 col 1".
Removing the article block removes the parse error and shows the actual linter mistakes.
Using https://github.com/AtomLinter/linter-sass-lint 1.1.1 on atom 1.5.3 on linux.

Hey @vhaarr,
linter-sass-lint does not use SCSS-Lint, as mentioned in its documentation.
Please file your issue with the sass-lint project.


couldn't find file 'jquery.ui.all'

Facing this issue on fresh install

Gemfile
source 'https://rubygems.org'
gem 'rails', '4.1.6'
gem 'sqlite3'
gem 'sass-rails', '~> 4.0.3'
gem 'uglifier', '>= 1.3.0'
gem 'coffee-rails', '~> 4.0.0'
gem 'jquery-rails'
gem 'turbolinks'
gem 'jbuilder', '~> 2.0'
gem 'sdoc', '~> 0.4.0',          group: :doc
gem 'spring',        group: :development
gem 'spree', github: 'spree/spree', branch: '2-3-stable'
gem 'spree_auth_devise', github: 'spree/spree_auth_devise', branch: '2-3-stable'
gem 'spree_drop_ship', github: 'jdutil/spree_drop_ship', branch: '2-3-stable'
gem 'spree_marketplace', github: 'jdutil/spree_marketplace'
gem 'spree_fancy', :github => 'spree/spree_fancy', :branch => '2-3-stable'
gem 'quiet_assets'

Any have a fix to this?

@jaiwil1221 I have made a PR for this for 2-3-stable branch it fixes error #135

It has been fixed now with #135 for 2-3-stable branch.

Sorry? How is this fixed -- I get this error on a fresh install as well ??


feat(plugins/pagerduty): support pagerduty.com/service-id annotation

Resolves #11667
Hey, I just made a Pull Request!
Introduces a new annotation pagerduty.com/service-id that can be used instead of the pagerduty.com/integration-key annotation.
Note: If both annotations are specified on a given Entity, then the pagerduty.com/integration-key annotation will be prefered
In addition, various enhancements/bug fixes were introduced:

The PagerDutyCard component now wraps error and loading messages with an InfoCard to contain errors/messages. This enforces a consistent experience on the EntityPage
If no service can be found for the provided integration key, a new Error Message Empty State component will be shown instead of an error alert
Introduces the fetchApi to replace standard window.fetch

ensures that Identity Authorization is respected and provided in API requests

There is also more context in the linked issue #11667
Screen Shots
Missing API Token
Before

After

Entity Not Found
Before

After

Component Annotated with pagerduty.com/service-id

:heavy_check_mark: Checklist

[x] A changeset describing the change and affected packages. (more info)
[x] Added or updated documentation
[x] Tests for new functionality and regression tests for bug fixes
[x] Screenshots attached (for UI changes)
[x] All your commits have a Signed-off-by line in the message. (more info)

@benjdlambert Thanks for the review! Adjusted to use @backstage/errors based on feedback and ensured that yarn lint is successful

@benjdlambert Appreciate your reviews here!
Pushed up the fix to make this a minor change bump over patch. Also rebased at your suggestion.
Let me know if anything else jumps out at you!

@Rugvip @benjdlambert @jhaals
Thanks for the reviews everyone!
The last round of changes, I may have gone overboard to make the API Client consistent with the feedback provided by @Rugvip here
I believe that I addressed all of the comments there, I know it isn't exactly the same as what was suggested, but I think its a good next step.
Open to all other feedback! Please let me know if I can/should change anything else.

@Rugvip @benjdlambert @jhaals
Bumping another review of this PR - thanks in advance!

Thanks for letting the workflows run!
I took a look at the failing E2E Text for Linux and it looks like it failed during
yarn tsc:full

but I wasn't able to reproduce the failure locally on my end (probably because I'm not running linux).
Any advice there?

@alecjacobs5401 it's now fixed so a rebase/merge should do the trick!

@Rugvip rebased as requested. Thanks!

@Rugvip I believe I have addressed your comments.
Thanks in advance!

Awesome, thanks!


Allow fetch to run without a remote configured

For newly initialized local repositories that are configured to track
existing LFS objects by manually creating pointer files via
git-lfs-pointer, there might be no remote configured yet. Still it should
be possible to fetch the LFS objects. Allow this by postponing the check
for a remote until it is really required.

@sschuberth -- thanks for another contribution. I think there are a few test failures that I'm seeing happening:
commands/command_fetch.go:45: cannot use nil as type string in assignment
commands/command_fetch.go:160: invalid operation: cfg.CurrentRemote == nil (mismatched types string and nil)

This is because the CurrentRemote field on the *config.Configuration type is a string, meaning you should assign empty string ("") to it when emptying it out, or check if the len(str) > 0) when checking if it has value.
Once you fix those up, however, I think this looks 👍.

@ttaylorr Thanks, fixed.

@sschuberth thanks for getting back to me so quickly. The good news is that LFS compiles now. The bad news is that now the tests are failing for a legitimate reason.
The output of the test failures that I'm looking at can be found: here.
I'm seeing the following:
+git remote rename origin something
+git lfs fetch
http: Post objects/batch: unsupported protocol scheme ""

which means that after the remote is renamed to something other than origin, LFS tries to preform a fetch, but fails due to trying to parse an unsupported protocol: empty-string. This makes me think that the an empty string was returned from config.CurrentRemote, and the default remote was missing. The order of execution that would cause this to happen is as follows:

The fetch command calls the api.Batch function, and a new batch request is generated here.
Upon trying to generate that new batch request, an SSH authentication is preformed here.
That SSH authentication attempts to grab the correct server-side endpoint for the given operation here.
And when resolving that endpoint, the config package picks either the cfg.CurrentRemote (if not empty), or the default remote, here.

We can't rely on the default remote in this test-case, because there is no origin, anymore. Instead, we have to rely on the cfg.CurrentRemote, which I have a hunch is being set in the wrong place.
In the commands/command_fetch.go file, you can see there are many paths that the fetch command can take. Not all of them, however, lead to fetchRecent, which is where you have the current remote check. All of the paths do, however, lead to fetchAndReportToChan, which is where I would make the current remote check.
Would you mind trying that one out and seeing if it resolves these test failures?

Thanks for the detailed analysis! Let's see how my update goes...

@sschuberth Nice! I think we fixed it. Travis reported all green except for one build which failed with a message about unresponsive output, making me think that the worker had died.
I went ahead and restarted that build here. Once it passes, I think we're ready to merge.
Thanks again for a great contribution!


RSDK-3591 Update Workflows for Stable/RC/Latest Appimage

This PR updates the RC/Latest and Stable tagging workflows for viam-cartographer.
Action Run: https://github.com/viamrobotics/viam-cartographer/actions/runs/5394881378/jobs/9796778179
JIRA Ticket: https://viam.atlassian.net/browse/RSDK-3591

taking myself off the list of reviewers as I can't review it by EOD today


DS-3632 DSpace 5 Correct update handle prefix script

This is the DSpace 5 port of https://github.com/DSpace/DSpace/pull/1790

This code looks reasonable to me, but I'd really like to see it tested prior to merger.  It is quite a bit different from the #1790 PR that it's based on (as this area of the codebase changed between 5.x and 6.x). The other option is that we simply resolve this in 6.1 (via #1790) and leave it as a "known" issue in 5.x.

Closing as outdated. Was fixed in 6.1


Persist STRICT_APPLE_COMPATIBILITY in objc-config.h

On Windows, the value of STRICT_APPLE_COMPATIBILITY determines whether BOOL is a char or an int.  This value must be consistent across all libraries that use libobjc2.  Rather than requiring all libraries to explicitly define STRICT_APPLE_COMPATIBILITY, persist the value of STRICT_APPLE_COMPATIBILITY in objc-config.h and include that in runtime.h.

Might be good to propagate the other build-time configuration things there.

@davidchisnall Sure, which ones would you like?  Some of them have generic names (e.g. LEGACY_COMPAT) so perhaps we should prefix them with OBJC_?

I'll merge as is but we can always add more configuration changes later.


Documentation site does not redeploy on merge to master

This is increasingly important as we want to do blog posts. I am however not sure how to square it with merging changes that are not yet released, but update documentation.

I thought about this and I would suggest that we introduce a dev branch. The dev branch will be used for active development and the main branch represents the current release.
This way we could deploy regularly the blog and merge separately.

Sure, that would work.


comments_moderation view requires styling

The dashboard for comments moderation requires styling.

@jMyles hi, what page are you talking about?
As far as I know there are no comments on RTD.

Hey @humitos - awesome to meet you at PyCon! :-)
This is a project we were working on back in 2014; I think it is basically dead-ended right now and can be closed.

@jMyles oh... you are YOU.
I've been taking a look at old issues and there are a couple that can be closed. I will probably bothering your inbox with more of this ones.


Code formatting fixes & missing code bracket

Fixed misformatted description text 'Now you should be able to F12...' It was wrongly formatted as a code block.
Fixed code formatting (indents + csharp/powershell markdown)
Fixed missing ending class bracket in the section 'Next, the presentation form'
Removed the reference to 'add the items in Italic below', as none of the text below was marked in italic. Updated to "add the following".
Removed "PS C:>" for consistency in the flow of the document, it is not required for the reader to specify the directory the PS command was executed in.
<fsname> was missing due to missing escape characters. Added the markdown escape characters around <>
Removed number 6 in 'Prepare the test AD FS machine' which had no text

Checking with engineering

#sign-off

Yes. looks good.  Please merge.
#sign-off


Search should include not only estimator parameters but also possible estimators

When using GridSearchCV we can, through the use of a pipe, cover also different estimators and not only the parameters of a single one.
I have tried to use the same concept through GASearchCV but without success.
Any ideas/workarounds?
Any plans to expand this?

Hi @lbrito2023 can you provide a snippet of what you're trying to achieve using GridSearchCV?
Maybe something like this is what you are looking for: example

This behavior is not currently supported since you're using more than one estimator at the time, the current workaround would be to fit three independent GASearchCV estimators
The way the solver works under the hood is by creating combinations of the param grid, which in general can't be done if you mix estimators that don't share the same parameters


add secondary content to patch/content/secondary

Add secondary content to a newly created patch/content/secondary (based on feature/body) branch.

successfully added secondary content to patch/content/secondary


undefined reference to `hi_malloc(unsigned long)'

I recently used hiredis in a project and made it into a docker image, the docker image was used in the project and worked fine, this was 2 months ago 17th of December. I recently changed a flag for OpenCV in the original Dockerfile and recreated a new image, I now seem to have a error as seen, below. I believe this may be because my Dockerfile clones the current hiredis repo with the new changes, and a new change may have caused this bug/error. Please note I get this error when just importing redis and not even using it.
/tmp/ccd0E4XK.o: In function `redisLibevAttach(ev_loop*, redisAsyncContext*)':
/usr/local/include/hiredis/adapters/libev.h:122: undefined reference to `hi_malloc(unsigned long)'

Can you try again?  I merged a few housekeeping fixes that are likely related to your issue.

Hi Michael thanks for the reply and changes although, I am still having the issue with the latest commit. Thanks.

Perhaps it's attempting to link to an older version of hiredis?  I bumped the version to 0.15.0 in this repo as we'll need to do that before any official release.
It's hard to say for sure without a Dockerfile that lets me replicate the problem, but this error is exactly what I would expect when attempting to link to an older version of libhiredis.so.0.14.
If you can provide a Dockerfile to replicate the issue I'm happy to help.

@DoctorUSB Are you still having issues?

I'm going to close the issue because there hasn't been any activity but if you're still running into problems please reopen and let me know.

@michael-grunder
Hey, Just to help out whoever runs into this -- We're running into this issue, as well.  We encountered it, while doing an OS upgrade.   Is there any plans to pushed the
From (works)
Ubuntu 16.04.6, GCC 5.4.0, CMake 3.5.1, libhiredis 0.13 (via apt get)
To (broken)
Ubuntu 20.04.0, GCC 9.3.0, CMake 3.16.3, libhiredis 0.14.0 (via apt get)
To (broken)
Ubuntu 20.04.0, GCC 9.3.0, CMake 3.16.3, libhiredis 0.14.1 (manual install)

$ git clone https://github.com/redis/hiredis.git
$ cd hiredis
$ git co v0.14.0
$make
# make install
(link in our application)

3. `$ git co v0.14.0`

`$ git checkout v0.14.1

my temporary fix:
// wsl2 you suck...
void *hi_malloc(unsigned long size){
return malloc(size);
}


Add generator for Java

Sending files method is not provided.

This is a big contribution! I'll get it in this weekend.


Check Address is existing before sending

The Issue
issue comes about when trying to send funds to a non legit account like "aaaaaaaa"
Steps to reproduce
1.enter address aaaaaaaaaa
2.enter amount
3.send
Expected behaviour
i would expect this to do an api call to see if this address is existence and has funds linked to it or if it does not have a public or private key don't send the funds, and have error pop up if it doesnt work
Actual behaviour
it claims it sent the funds to the non existence account
System Configuration

LBRY Daemon version: 0.14.2
LBRY App version: 0.14.3
LBRY Installation ID: 9JKT6nrdGYoFKshVLmjnbfUdqNvHRkzWmsLXk5xNdbXzGEwpraZ6MVg1KoD5jrBrf2
Operating system: Windows 10

Anything Else

Screenshots

We may be able to do some semantic checks on the address (length, etc) but checking if the address exists or if it has public / private keys is impossible.

even just an error saying it didnt send would be nice at this point even if it doesn exist and it doesnt send it says it sent and its in my queue

This issue exists in the daemon as well, and there are likely changes required for both. Here's the daemon ticket: https://github.com/lbryio/lbry/issues/828

On the app side of this, the proper solution is probably one of:

Create a component, FormFieldWalletAddress, that verifies the value is a valid address on blur/submit
Modify FormField to take a regexp parameter, that matches on blur/submit, and submit the proper regexp as defined in lbryuri.

I think we can run a base58 address validation check at the very least. Perhaps, something like https://github.com/wzbg/base58check/blob/master/index.js#L30-L47 which would require the use of an external module.

Per discussion in meeting, the correct resolution for this is still https://github.com/lbryio/lbry-app/issues/445#issuecomment-320525524

Merged, will be released in 0.15.1.


Improve DB creation from local sqlite file

Changes the spinner to inform which task the turso db create command currently is doing.
Waits for the database to load the seed, which can take a while as well.
Also adds a --wait or -w flag to both turso db create and turso db replicate, which makes the command wait until the new instance is ready to receive requests.

Example of creating a database with a local SQlite file of 43MB:
https://user-images.githubusercontent.com/7853668/236575684-676500cb-ab05-46b2-8cfd-75392c3bebbf.mov

How to generate a similar file locally:
echo "CREATE TABLE blobs (blob BLOB NOT NULL);" > dump.sql
for i in {1..1000}; do echo "INSERT INTO t VALUES (zeroblob(32768));" >> dump.sql; done;
sqlite3 db.sqlite < dump.sql

Then just:
turso db create --from-file db.sqlite

Looks good to me! @CodingDoug please have a look

It looks like the wait flag, as a standalone CLI function, is kind of orthogonal to loading from a file, since specifying a file forces it to wait anyway.  Should we just require the wait flag in all cases where the CLI should wait for readiness, in order to keep its behavior consistent? So the default behavior would be for the CLI to always terminate as quickly as possible, unless it's told to wait.
Also I wonder (and this is very speculative) if waiting should actually be its own operation for the entire database, not just a flag for certain instance operations.  It could work in any circumstance: turso db wait $DB_NAME.  That would extend its potential utility to other operations that might cause some downtime (like a database version update), and allows the user to do a followup wait if they didn't think to put the flag in the command in the first place.

Should we just require the wait flag in all cases where the CLI should wait for readiness, in order to keep its behavior consistent?

I don't think so, the CLI should feel snappy. The usual DB startup time after creation should be small most of the time (< 5s), so most users won't even query the DB until it is ready.

So the default behavior would be for the CLI to always terminate as quickly as possible, unless it's told to wait.

Yes, but the problem with creating the DB from a file is that it can take a while. Minutes in some cases. And if we don't wait the user may think their database is broken.

Also I wonder (and this is very speculative) if waiting should actually be its own operation for the entire database, not just a flag for certain instance operations.

I don't think so, because it waiting by itself doesn't achieve anything for the user.
I'd rather add the flag to the create and replicate operations than have another command.
For other long operations, like update, it should be the other way around: the default is waiting but you could also use a flag to detach yourself from the execution.

I think I was unclear. I'm saying that the CLI should always end as fast as possible unless the wait flag is specified. I'm not saying the CLI should always wait.

You were clear, I mixed things up though.

That can be addressed with messaging, especially providing a command to run (below) to make sure the database is ready.

Messaging is very good on command descriptions and on docs.
I don't like it on command outputs very much for two reasons:

The more unstructured text, the harder it is to automate things and reuse commands.
The CLI feels cluttered, especially if already know your way around it.

We'll soon have a status endpoint that users can use to check if the DB is ready, up, down, broken, etc.
I'm still not convinced about the wait command though.

In this case, I'd rather there be consistency in behavior across the board rather than special-casing guesses at what the user probably wants, or how the system will probably behave, or timing on what the user will probably do in response. It's easier to explain the behavior of systems in this way and set expectations accordingly, and accounts for those times when these "probably" statements aren't all satisfied.

I agree with the principle of valuing consistency. We should also be pragmatic about UX.
I don't see the downside in this specific case of making --from-file trigger --wait.
The lack of --wait though is making people confused.
We should totally revisit it once we have a better story around getting database status/state though.

Let's work on the DX in tree.

I have no objections to turso db wait, but on the other hand I am perfectly happy with --wait flag too.

It seems that for creation from a file it would be better to always wait. Just to avoid confusion.


chart.getCSV() is not a function

I have loaded the exporting module and it works properly. I'm able to export to pdf, svg etc.. but can't export to csv

You need:

npm install highcharts-export-csv

It works for me:
import React, { Component } from 'react'

import Highcharts from "highcharts";
import ReactHighcharts from 'react-highcharts'

const HighchartsExporting = require('highcharts-exporting')
HighchartsExporting(ReactHighcharts.Highcharts)

require('highcharts-export-csv')(ReactHighcharts.Highcharts)

class superChart extends Component {

    componentDidMount(){
        let chart = this.refs.chart.getChart();
        console.log(chart.getCSV())
    }

    render() {
        let config = {
            chart: {
                zoomType: 'x'
            },
            title: {
                text: 'USD to EUR exchange rate over time'
            },
            subtitle: {
                text: document.ontouchstart === undefined ?
                    'Click and drag in the plot area to zoom in' : 'Pinch the chart to zoom in'
            },
            xAxis: {
                type: 'datetime'
            },
            yAxis: {
                title: {
                    text: 'Exchange rate'
                }
            },
            legend: {
                enabled: false
            },
            plotOptions: {
                area: {
                    fillColor: {
                        linearGradient: {
                            x1: 0,
                            y1: 0,
                            x2: 0,
                            y2: 1
                        },
                        stops: [
                            [0, Highcharts.getOptions().colors[0]],
                            [1, Highcharts.Color(Highcharts.getOptions().colors[0]).setOpacity(0).get('rgba')]
                        ]
                    },
                    marker: {
                        radius: 2
                    },
                    lineWidth: 1,
                    states: {
                        hover: {
                            lineWidth: 1
                        }
                    },
                    threshold: null
                }
            },

            series: [{
                type: 'area',
                name: 'Us',
                data: [[Date.UTC(2013,5,3),0.7648],
                    [Date.UTC(2013,5,4),0.7645],
                    [Date.UTC(2013,5,5),0.7638],
                    [Date.UTC(2013,5,6),0.7549],
                    [Date.UTC(2013,5,7),0.7562],
                    [Date.UTC(2013,5,9),0.7574],
                    [Date.UTC(2013,5,10),0.7543],
                    [Date.UTC(2013,5,11),0.7510],
                    [Date.UTC(2013,5,12),0.7498],
                    [Date.UTC(2013,5,13),0.7477],
                    [Date.UTC(2013,5,14),0.7492],
                    [Date.UTC(2013,5,16),0.7487],
                    [Date.UTC(2013,5,17),0.7480],
                    [Date.UTC(2013,5,18),0.7466],
                    [Date.UTC(2013,5,19),0.7521],
                    [Date.UTC(2013,5,20),0.7564],
                    [Date.UTC(2013,5,21),0.7621],
                    [Date.UTC(2013,5,23),0.7630],
                    [Date.UTC(2013,5,24),0.7623],
                    [Date.UTC(2013,5,25),0.7644],
                    [Date.UTC(2013,5,26),0.7685],
                    [Date.UTC(2013,5,27),0.7671],
                    [Date.UTC(2013,5,28),0.7687],
                    [Date.UTC(2013,5,30),0.7687],
                    [Date.UTC(2013,6,1),0.7654],
                    [Date.UTC(2013,6,2),0.7705],
                    [Date.UTC(2013,6,3),0.7687],
                    [Date.UTC(2013,6,4),0.7744],
                    [Date.UTC(2013,6,5),0.7793],
                    [Date.UTC(2013,6,7),0.7804],
                    [Date.UTC(2013,6,8),0.7770],
                    [Date.UTC(2013,6,9),0.7824],
                    [Date.UTC(2013,6,10),0.7705],
                    [Date.UTC(2013,6,11),0.7635],
                    [Date.UTC(2013,6,12),0.7652],
                    [Date.UTC(2013,6,14),0.7656],
                    [Date.UTC(2013,6,15),0.7655],
                    [Date.UTC(2013,6,16),0.7598],
                    [Date.UTC(2013,6,17),0.7619],
                    [Date.UTC(2013,6,18),0.7628],
                ]
            }]
        }

        return(
            <div id='main' style={{padding:20,}}>

                <ReactHighcharts  config={config} ref="chart"> </ReactHighcharts>
            </div>
        )

    }

}

export default superChart

Thanks, worked like a charm :)


Improve og Images for members to be shared on Linkedin

link:
https://www.linkedin.com/post-inspector/inspect/https:%2F%2Fcoderbunker.ca%2Ffr%2Fmembers%2Fangdi_chu

https://ogp.me/

not sure how feasible this is or when to insert it, but instead of trying to optimize the profile image, make the card an image and turn that into the og:image.
Maybe render all the cards at the build step with PhantomJS?
from html to the card:

create a card with a layout that has width 1200 and height 627. tag the highest card level div as id="card"
after page load, use https://html2canvas.hertzen.com/ on the element id card
append the newly created canvas to body (maybe turn canvas into img ?)

looks like this:
var node = document.getElementById('card');
html2canvas(node).then(function(canvas) {
    document.body.appendChild(canvas);
});

(in any case, being able to click and download a easy to reshare version of the card as a single image is useful)


Cutting Edge Alpha builds

I want some unlisted alpha builds published allowing consumers to work against the latest myget feeds (CLI RC2)

This still relevant or close?

Relevant, have updated OP.


λ serialization/deserialization

Current coverage is 100.00%

Merging #38 into master will not affect coverage as of 15cfa05

@@            master     #38   diff @@
======================================
  Files           20      22     +2
  Stmts          208     227    +19
  Branches        47      49     +2
  Methods          0       0
======================================
+ Hit            208     227    +19
  Partial          0       0
  Missed           0       0

Review entire Coverage Diff as of 15cfa05

Powered by Codecov. Updated on successful CI builds.


[AAP-23625] Fix WF visualizer/job output dark mode

Issue: AAP-23625
before:

after:

before:

after:

+ remove legend in empty screen

@kialam good suggestion :+1:, reworked to use global variables instead


No border on linux mint

Issue Type: Bug
In recent versions of vscode-insiders I've noticed that code-insiders windows no longer have a border.
Tested with empty settings.json on Linux Mint 18.3.

This shows two vscode-insiders windows that blend into each other with no border. At the bottom of this screenshot is a normal window with the usual border. Vscode does not have this and it can be difficult to tell where the window ends.
VS Code version: Code - Insiders 1.30.0-insider (6ef7e81ec086ced5fb20e904ea405075be474023, 2018-11-14T18:15:46.706Z)
OS version: Linux x64 4.13.0-43-generic

System Info

Item
Value

CPUs
Intel(R) Core(TM) i7-6700HQ CPU @ 2.60GHz (8 x 910)

GPU Status
2d_canvas: enabledchecker_imaging: disabled_offflash_3d: enabledflash_stage3d: enabledflash_stage3d_baseline: enabledgpu_compositing: enabledmultiple_raster_threads: enabled_onnative_gpu_memory_buffers: disabled_softwarerasterization: disabled_softwarevideo_decode: unavailable_softwarevideo_encode: unavailable_softwarewebgl: enabledwebgl2: enabled

Load (avg)
1, 1, 1

Memory (System)
7.63GB (3.57GB free)

Process Argv
.

Screen Reader
no

VM
0%

Extensions: none

@bpasero other distros will still render shadows, I tried ubuntu 16.04. Should we provide an optional border around frameless windows?

@sbatten possibly, if you want to. Duplicate of https://github.com/Microsoft/vscode/issues/54507

Thanks for recalling


fix(hotspot): i18n need to pass through all props downstream to components

Closes #
Summary

This PR prereqs the HotspotModal integrated into the ImageCard so make sure to check the changes after integrating

Change List (commits, features, bugs, etc)

need to pass through all i18n props (refactor them to be i18n children) and send them all the way out to the DashboardEditor component so they can be easily overridden

Acceptance Test (how to verify the PR)

Verify that the DashboardEditor i18n story under Image Card with Hotspots never shows any default PII

:tada: This PR is included in version 2.143.0-next.2 :tada:
The release is available on:

npm package (@next dist-tag)
GitHub release

Your semantic-release bot :package::rocket:

:tada: This PR is included in version 2.143.0-next.2 :tada:
The release is available on:

npm package (@next dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


[5.8] tsan-ignores-arc-locks.swift: post process test binary on Darwin

This allows the DYLD_LIBRARY_PATH override to work as expected and avoid crashes when running.
Scope: change in a Swift validation test
Issue: rdar://110272889
Risk: Low -- other standard library tests are using the same post process test
Testing: execute the toolchain PR job to exercise this test
(cherry picked from commit 44a40979e52be8e9344b8ca6069614a29aeff6cd,
#66308)

@swift-ci please test

@swift-ci please build toolchain


regenerate

Almost all the changes are blank lines (change in gofmt behavior?).
One significant change is spanner DML.


Add Variables to Text Tile

Updated version of https://github.com/concord-consortium/collaborative-learning/pull/1236
This adds a plugin registration mechanism for the text tile.
And it is used by the the shared variables model so variable chips can be added to the text tile.
In this case the registration of the plugin is triggered when the diagram-tile is loaded. The loading of diagram-tile, loads/registers the shared-variables model. The shared-variables-registration now calls registerTextPluginInfo.
A text plugin currently needs several fields:

iconName: this is used both to identify the plugin and should match the slate type of blocks or marks added to the slate content
Icon: this is the icon used in the text tool toolbar. Currently all plugins are added to the toolbar.
toolTip: hover text of the icon in the toolbar
createSlatePlugin: this is a function called with the text content model when the text tool is mounted, it should return a slate plugin. This plugin will be passed to the slate-editor component.
command: this is the command that is run when the toolbar button is clicked on. Currently all commands are passed a dialogController argument so they can bring up a dialog
updateTextContentAfterSharedModelChanges: this is optional. If provided, it will be called by the text content model if one of the shared model linked with the text content model changes.  The text content model does not link any shared models itself, it is the job of the plugin to link these shared models. In the current code the shared model is first linked when the user clicks on the variable toolbar button.

This PR also includes code which adds dialog support to the text tool. This support is still using the older slate-editor before the dialog was broken up. It should be updated now that the dialog is broken up in multiple components.
One tangential change in the PR is to move the handleToolBarButtonClick click from text-tool.tsx to text-toolbar.tsx. I don't remember exactly why I made this change, but it does mean one less handler is being passed as a prop to TextToolbar
TODO:

[ ] cover text plugin code with tests
[ ] review some of the TODOs and FIXMEs
[ ] add doc about how text plugins can be added
[ ] verify that this doesn't trigger the loading of the diagram-view library with default CLUE
[ ] release new slate-editor dependency and update dependency
[ ] update the text-tool-dialog to use the new slate code.

@kswenson this isn't ready to merge, but I wanted to get your opinion on the text plugin registration approach before I continued revising this.

@tejal-shah can you take a look the cypress tests in this PR, and let me know if you want me to change anything?  I'll add you as a reviewer.  There is more work on the PR itself, but I think I won't have to change the tests.

@tejal-shah can you take a look the cypress tests in this PR, and let me know if you want me to change anything? I'll add you as a reviewer. There is more work on the PR itself, but I think I won't have to change the tests.

👍 The cypress tests look good @scytacki

@kswenson this is ready for review now.
The only thing it is missing (as far as I know) is a production release of slate-editor which is waiting on this PR: https://github.com/concord-consortium/slate-editor/pull/68


feat: using Honk in the rollup

Please read contributing guidelines and remove this line.

Replaced by https://github.com/AztecProtocol/aztec-packages/pull/6975

Incorporated into https://github.com/AztecProtocol/aztec-packages/pull/6971


Remove version: TechPowerUp.GPU-Z version 2.58.0

All InstallerUrls returned 404 Not Found

https://us2-dl.techpowerup.com/files/GPU-Z.2.58.0.exe

Microsoft Reviewers: Open in CodeFlow

Close with reason: Accessible with WinGet user agent only;


Closes: #1

Updated validations.py python script.
Fixed the behavior of validate_user function in validations.py.
Fixes #<issue_number_goes_here>

It's a good idea to open an issue first for discussion.

[ ] Tests pass
[ ] Appropriate changes to README are included in PR

Improved user name behavior by returning false for username starting with a dot, underscore or numeric @google-admin .


Fixed paths for MoltenVK changes

Minor changes to cmake files for macOS only builds. Changes to MoltenVK required some simple path changes to locate the dynamic library.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

known_good.json updated.


How to apply 4x4 matrix using SVG path commander

I have a 4x4 matrix for use with CSS matrix3d but I'm not sure how this translates to the 3d transformation in SVG path commander:
matrix3d(
  1.2198581560283686, 0, 0, 0.00042118420695089805,
  0, 1, 0, 0,
  0, 0, 1, 0,
  0, 0, 0, 1
)

The documentation shows this:
let transformObject = {
  origin: [205,205,205], // transform origin assumes the shape bounding box is 410 wide and 410 tall
  scale: [0.3,0.3,0.3],  // all axes scale
  translate: [20,0,0],   // translateX
  rotate:[0,0,45],       // rotateZ
  skew:[20,0]            // skewX
}

let myPathString = new SVGPathCommander('M0 0L0 0')
                      .transform(transformObject)
                      .toString()

The final column of the matrix3d matrix appears to be perspective, is this input compatible with svg-path-commander?

To apply a matrix instance directly to a path you can try and reverse engineer transformPath or create your own utility.
I plan to have SVGPathCommander with full TypeScript source in the near future, this workaround won't be difficult to implement.

Closing due to no activity.


ServiceMonitor should default to release namespace

Signed-off-by: Dan Sexton<EMAIL_ADDRESS>

This change is

Coverage increased (+0.02%) to 44.665% when pulling 93a8ce0a40680040f0c2eefb7bd764b23bb91137 on dsexton:bugfix/helm-servicemonitor-namespace into e6f8c65082f2bbaca230fae10d4cf9d636798d94 on cilium:master.

test-me-please

@aanm can we backport this to 1.7 & 1.6?

I don't see why not, is there any particular inherent risk in the backport? Seems like @dsexton has specifically hit an issue with it and is submitting the fix to address an issue on the older versions too.

test-me-please

@joestringer no risk, this just ensures that the service monitors render to the release namespace if you do not specify an override.


Parsing --help needs to return something other than an error

The way the --help text is parsed the message is returned in the same field as an actual parsing error, and the return code is the same as if it was a failure case. However a user actually passing --help explicitly should be considered a success.
The only way I came up with to work around this was to test the error string for :match("^Usage:") and switch gears from error handling to closing with a success status after the message. There really should be a more ergonomic way to do this. As it is most lua apps that implement CLIs with this library return a failure code when they should not.
c.f. https://github.com/orhun/halp/issues/20
c.f. https://github.com/sile-typesetter/sile/pull/1737/files

This issue should be resolved by https://github.com/lunarmodules/lua_cliargs/pull/78.


How to set body parameter when method is 'POST' and 'GET'?

I use fetch in my project , when I set method is 'POST' , the body how to set ? in README, i find the body set like this:
  body: JSON.stringify({
    name: 'Hubot',
    login: 'hubot',
  })

but some article say the body need parameter like this:
body: "firstName=Nikhil&favColor=blue&password=easytoguess"

I have a question ,when the method set 'POST', body can set in two type like these ?
Moreover, when method set 'GET', how to set body ?

Hello, this is a usage question and, as such, not appropriate to open issues about. Please use issues for bug reports.
GET requests can't have a body. POST requests can have a body which is either a string (such as the result of JSON.stringify), a URLSearchParams instance, a FormData instance, or some of the other types documented in https://github.github.io/fetch/#request-body.
When supplying a string body, you must also set an appropriate content-type header.

how can we set the value in body ?
body: 'firstName=Nikhil&favColor=blue&password=easytoguess',
if i want to show Nikhil from a variable how can we do that?

let payload = {
username: this.state.username,
password: this.state.Password,
type: "Login",
AppVersion: "1.7"
};
let data = new FormData();
data.append( "json", JSON.stringify( payload ) );
fetch("https://concore.retailistan.com/app/teamlead/?",
{
method: 'post',
body: JSON.stringify(data),
headers: { 'Content-type': 'application/json' }
})
.then(function(res){ return res.json(); })
.then(function(data){ alert( JSON.stringify( data ) )
console.warn(data)
})
}

let payload = {
username: this.state.username,
password: this.state.Password,
type: "Login",
AppVersion: "1.7"
};
let data = new FormData();
data.append( "json", JSON.stringify( payload ) );
fetch("YOUR URL",
{
method: 'post',
body: JSON.stringify(data),
headers: { 'Content-type': 'application/json' }
})
.then(function(res){ return res.json(); })
.then(function(data){ alert( JSON.stringify( data ) )
console.warn(data)
})
}

how we send data in form without passing in input field


Pub: No such method: 'printUsage',

$ ./xcodebuild/ReleaseIA32/dart-sdk/bin/pub --help -v
Unhandled exception:
No such method: 'printUsage', url 'file:///Users/ahe/Dart/all/dart/xcodebuild/ReleaseIA32/dart-sdk/util/pub/pub.dart' line 62 pos 5
    printUsage(description: e.message);
#0      NoSuchMethodErrorImplementation._throwNew (dart:core-patch:623:3)
#1      main (file:///Users/ahe/Dart/all/dart/xcodebuild/ReleaseIA32/dart-sdk/util/pub/pub.dart:62:5)

This issue has been moved to dart-lang/pub#276.