FactoryRegistry and MemberInjectorRegistry are not generated for module

Hi! I use this guide for setup multi module project.
I have two module: auth and app:
module auth has  dependencies
api "com.github.stephanenicolas.toothpick:toothpick-runtime:$versions.toothpik"
kapt "com.github.stephanenicolas.toothpick:toothpick-compiler:$versions.toothpik"

and module app has configurations for kapt
kapt {
    generateStubs true
    arguments {
        arg("toothpick_registry_package_name", appId)
        arg('toothpick_registry_children_package_names', "ru.rm.auth")
    }
}

and dependencies
implementation project(':auth')
kapt "com.github.stephanenicolas.toothpick:toothpick-compiler:$versions.toothpik"

But after clean/rebuild I have build exceptions
error: cannot find symbol addChildRegistry(new ru.rm.auth.FactoryRegistry()); and
error: cannot find symbol addChildRegistry(new ru.skblab.rm.auth.MemberInjectorRegistry());
I try it with android gradle plugin version 3.1.2 and 3.2.0-alpha15 and gradle version 4.4.1 and 4.7 respectively

You also need the auth module to have some configuration for TP:
api "com.github.stephanenicolas.toothpick:toothpick-runtime:$versions.toothpik"
kapt "com.github.stephanenicolas.toothpick:toothpick-compiler:$versions.toothpik"
and
kapt {
generateStubs true
arguments {
arg("toothpick_registry_package_name", 'ru.rm.auth')
}
}
This will generate a registry for the auth module that your app will be
able to use.
2018-05-22 1:02 GMT-07:00 Max<EMAIL_ADDRESS>
Hi! I use this guide
https://github.com/stephanenicolas/toothpick/wiki/Factory-and-Member-Injector-registries#example--application-with-3-librariesfor
setup multi module project.
I have two module: auth and app:
module auth has dependencies
api "com.github.stephanenicolas.toothpick:toothpick-runtime:$versions.toothpik"
kapt "com.github.stephanenicolas.toothpick:toothpick-compiler:$versions.toothpik"
and module app has configurations for kapt
kapt {
generateStubs true
arguments {
arg("toothpick_registry_package_name", appId)
arg('toothpick_registry_children_package_names', "ru.rm.auth")
}
}
and dependencies
implementation project(':auth')
kapt "com.github.stephanenicolas.toothpick:toothpick-compiler:$versions.toothpik"
But after clean/rebuild I have build exceptions
error: cannot find symbol addChildRegistry(new
ru.rm.auth.FactoryRegistry()); and
error: cannot find symbol addChildRegistry(new ru.skblab.rm.auth.
MemberInjectorRegistry());
I try it with android gradle plugin version 3.1.2 and 3.2.0-alpha15 and
gradle version 4.4.1 and 4.7 respectively
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/stephanenicolas/toothpick/issues/293, or mute the
thread
https://github.com/notifications/unsubscribe-auth/ABv33X1JxVmlJ8i4bTdhBDkrItHaL9k7ks5t08YGgaJpZM4UIJ69
.

This could also be a duplicate of #264. Do you use any @Inject in your auth module?

Hi! I've read this guide too. It says that:
The only problem with the registries approach (beyond the extra configuration steps) is that every library using DI and that will be used by Toothpick needs to be compiled with Toothpick.
So I thought that I don't need to include TP dependency in every project module if I will use reflection feature. But it TP library still should be included into each module in order to generate MemberInjectorFactories. If I will not include it, than nothing will be injected at runtime in modules classes. Did I missed something? Must TP library be included in every module in multi module projects regardless is reflection enabled or disabled? Or maybe there is some configuration option, that allows to generate all MemberInjectorFactories in one module?

Hi, I'm facing the same issue .. the
I've added the dependencies with the version 1.1.3
    implementation "com.github.stephanenicolas.toothpick:smoothie:$TOOTHPICK_VERSION"
    kapt "com.github.stephanenicolas.toothpick:toothpick-compiler:$TOOTHPICK_VERSION"```

Then I've filled the arguments of the kapt inside android block in `build.gradle` of the app module, as shown below

```    kapt {
        arguments {
            arg("toothpick_registry_package_name", "com.github.elghrabi.myapplication")
            arg("toothpick_registry_children_package_names", "com.dev.elghrabi.mylib")
        }
    }```

My application class contains these lines

```        Toothpick.setConfiguration(Configuration.forProduction().disableReflection());
        MemberInjectorRegistryLocator.setRootRegistry(new com.github.elghrabi.myapplication.MemberInjectorRegistry());
        FactoryRegistryLocator.setRootRegistry(new com.github.elghrabi.myapplication.FactoryRegistry());

        Scope appScope = Toothpick.openScope(this);
        appScope.installModules(
                new SmoothieApplicationModule(this),
                new MyApplicationModule()
        );```

But both the classes cannot be generated. Am I missing something?

NOTE: I've also included `toothpick_registry_package_name` argument in the dependency library (mylib)

Hi, I'm facing the same issue .. the
I've added the dependencies with the version 1.1.3
implementation "com.github.stephanenicolas.toothpick:toothpick-runtime:$TOOTHPICK_VERSION"
    implementation "com.github.stephanenicolas.toothpick:smoothie:$TOOTHPICK_VERSION"
    kapt "com.github.stephanenicolas.toothpick:toothpick-compiler:$TOOTHPICK_VERSION"

Then I've filled the arguments of the kapt inside android block in build.gradle of the app module, as shown below
kapt {
        arguments {
            arg("toothpick_registry_package_name", "com.github.elghrabi.myapplication")
            arg("toothpick_registry_children_package_names", "com.dev.elghrabi.mylib")
        }
    }

My application class contains these lines
Toothpick.setConfiguration(Configuration.forProduction().disableReflection());
        MemberInjectorRegistryLocator.setRootRegistry(new com.github.elghrabi.myapplication.MemberInjectorRegistry());
        FactoryRegistryLocator.setRootRegistry(new com.github.elghrabi.myapplication.FactoryRegistry());

        Scope appScope = Toothpick.openScope(this);
        appScope.installModules(
                new SmoothieApplicationModule(this),
                new MyApplicationModule()
        );

But both the classes cannot be generated. Am I missing something?
NOTE: I've also included toothpick_registry_package_name argument in the dependency library (mylib)

Hi, I'm facing the same issue
I've added the dependencies with the version 1.1.3
    implementation "com.github.stephanenicolas.toothpick:toothpick-runtime:1.1.3"
    implementation "com.github.stephanenicolas.toothpick:smoothie:1.1.3"
    kapt "com.github.stephanenicolas.toothpick:toothpick-compiler:1.1.3"

Then I've filled the arguments of the kapt inside android block in build.gradle of the app module, as shown below
kapt {
        arguments {
            arg("toothpick_registry_package_name", "com.github.elghrabi.myapplication")
            arg("toothpick_registry_children_package_names", "com.dev.elghrabi.mylib")
        }
}

My application class contains these lines
        Toothpick.setConfiguration(Configuration.forProduction().disableReflection());
        MemberInjectorRegistryLocator.setRootRegistry(new com.github.elghrabi.myapplication.MemberInjectorRegistry());
        FactoryRegistryLocator.setRootRegistry(new com.github.elghrabi.myapplication.FactoryRegistry());

        Scope appScope = Toothpick.openScope(this);
        appScope.installModules(
                new SmoothieApplicationModule(this),
                new MyApplicationModule()
        );

But both classes cannot be generated. Am I missing something?
NOTE: I've also included toothpick_registry_package_name argument in the dependency library (mylib)

try to add injection for some field, for example, in fragment or activity

FactoryRegistry and MemberInjectorRegistry
But the problem is solved. I had no @Inject used yet in my code
Thank you guys!


SwayNotificationCenter: init at 0.3

Motivation for this change
Package https://github.com/ErikReider/SwayNotificationCenter.
I have been using this notification daemon for few weeks now.
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
22.05 Release Notes (or backporting 21.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

I think it's also preferred to have one package per line.

I think it's also preferred to have one package per line.

Fixed

gui should be uppercase "GUI"

Fixed
Thanks for the reviews!

LGTM on the package. To get it to work I have to add it to 3 lines to get dbus to register and without it installed to systemPackages I get the error COULD NOT FIND CSS FILE! REINSTALL THE PACKAGE! Can you add a module in nixos/modules/programs/?
{
    environment.systemPackages = [ swaynotificationcenter ];
    services.dbus.packages = [ swaynotificationcenter ];
    systemd.packages = [ swaynotificationcenter ];
}

I get the error COULD NOT FIND CSS FILE! REINSTALL THE PACKAGE!

$ strace -e openat,open,stat swaync |& swaync
<snip>
openat(AT_FDCWD, "/etc/profiles/per-user/nicolas/etc/xdg/swaync/style.css", O_RDONLY) = 9
openat(AT_FDCWD, "/etc/profiles/per-user/nicolas/etc/xdg/swaync/config.json", O_RDONLY) = 9

This is the log I have with the package in my home.packages (under Home Manager).
It does the same thing as environment.systemPackages in terms of linking files and folders.
I could wrap the swaync binary and append the package's $out/etc/xdg to $XDG_DATA_DIRS.
It would probably resolve your error.

Can you add a module in nixos/modules/programs/?

I already have a working module for Home Manager (that I have not yet contributed).
I don't intend to create a module for NixOS because I personally don't manage tools like this with NixOS, so feel free to submit one.

I don't have /etc/profiles/per-user. Is that from home manager nixos module? I am using home-manager too, so it would be okay if it works that way, but I don't use the home manager nixos module.


service should be able to start, even when backing store is unreachable or down

Our internal S3-compatible API service was recently changed to resemble being unavailable.
This caused docker-registry to stop (separate issue #tbd)
While trying to restart docker-registry, while the S3 service was still down, it was discovered that docker-registry is unable to start while the storage backend service is down.
File "/usr/lib/python2.6/site-packages/gunicorn/arbiter.py", line 419, in reap_workers
raise HaltServer(reason, self.WORKER_BOOT_ERROR)
docker-registry is issuing valid "HEAD /" requests, but our internal S3 service is temporarily (and incorrectly) returning 405 codes.
docker-registry workers, at startup, should be able to deal with this situation and initiate an exponentia- backoff/retry behavior.

Superseded by docker/distribution#54.


Having null values in generated Json

hi there i wanted to handle my generated json to automatically ignore null jsons like
this the generated json for now

}
  "teacherId": null,
  "name": "string",
  "minimum": 0,
  "maximum": 0,
  "percentage": 0,
  "description": "string",
  "scoringType": "Attendance",
  "id":null
{

but i want it like
this
}
  "name": "string",
  "minimum": 0,
  "maximum": 0,
  "percentage": 0,
  "description": "string",
  "scoringType": "Attendance",
{

how to make the toJson factory automatically recognize nulls and ignore them from being generated in the request json?

Yes perfect but i saw deafault value was null and not false . Now i did set it to false and its working .
But u are saying it should be true?

@kawmy  if it's true - null values will be added to your json. If false - they will not. If it's null - the same as for true.
About default value - it was mistake. By default it's null.

@kawmy any other questions?

No thanks.


[[Fix]] validthis checks do not apply to module or class bodies

ES6 class syntax creates a strict-mode-by-default boundary, which means that all code within the ClassBody is implicitly strict. This is also true of ModuleBody and all things therein.
Closes gh-2217

Coverage increased (+0.03%) to 96.33% when pulling d5689fe845152d6b56b9fdf2292b75ae924e8d2f on rwaldron:2217 into d82cf19916ea35079dc239f32b950dfc0767b795 on jshint:master.

Coverage increased (+0.03%) to 96.33% when pulling d5689fe845152d6b56b9fdf2292b75ae924e8d2f on rwaldron:2217 into d82cf19916ea35079dc239f32b950dfc0767b795 on jshint:master.


How to contribute to wiki?

I just tried forking the wiki to add a page and do a PR. Somehow I cant find how to do that. I wrote a small introduction how to use CAPS from within a maven project with IntelliJ. Ill just attach the md file here, maybe you can add it!
HtH Martin
CAPS-from-maven-project.txt

As far as I'm aware, GitHub does not support PRs to the wiki, and not even branches. One can do direct pushes or use GitHub directly for editing.
We haven't yet sorted out our CLA (Contributor's License Agreement) so we can not yet accept contributions, unfortunately. But you are free to spell out the instructions in this issue for example, enabling people to read it. We'll be adding documentation covering the topics covered in your text when we've shipped our first public release.


doc: install

after install, add a test to make sure install worked.

resolved in commits 4d7e0ee9540921587bc8c0132a912ed62a1c96c1 and 6c7d20a2fa3a19b323b3c1e87ded2c943a7e344e.
Notes: added basic integrity test script that can be launched after installation to see if the installation succeded. The test launches basic axondeepseg operations on a test dataset.
Test dataset was also added on setup.py to be included in all future wheels.

reopened, see:
https://github.com/neuropoly/axondeepseg/commit/6c7d20a2fa3a19b323b3c1e87ded2c943a7e344e#r26399752


With nvim-treesitter delay in opening cmake files

I am using:

neovim 0.8
nvim-treesitter main
tree-sitter-cmake main

When opening any cmake file with this treesitter parse installed and highlight enabled, I notice that there is a large delay of >1.5s before file contents are visible. Normally, a file is displayed within ~150 ms.

If I uninstall cmake treesitter parser problem no longer occurs
If I disable treesitter highlight module the problem no long occurs
If I downgrade treesitter the problem remains
If I downgrade cmake treesitter parser, the delay is less long, but still significant

can you share your nvim config and the CMake file you're opening?

My config is basically LazyNvim with the cmake parser, so I was planning on creating a simplified version. On another machine of mine it's a little less noticeable.
I noticed there are some other issues that may be related:

https://github.com/nvim-treesitter/nvim-treesitter/issues/2913

But I haven't been able to look into it yet.

So how does this work? I somehow thought all the CMake stuff is here but apparently not, if you need to make a PR to nvim-treesitter. Do you have a link to documentation or care to give me the quick rundown – what's in this repo and what's in nvim-treesitter?

Ah, is it that this is just the grammar for the syntax tree, but then for actually doing anything in nvim like highlighting we have everything in nvim-treesitter.

yes, you can checkout the queries here.

welp, I updated the queries, but it doesn't seem to improve the startup time much. Not sure there's anything I can do more for now.

There must be some exponential parse problem in the grammar. I use this grammar for other purposes and have the following expression to match commands with two parameters (e.g. option(NAME ON/OFF)):
(normal_command
  (identifier) @command
  (argument (unquoted_argument) @name)
  (argument (unquoted_argument) @state)
) @whole

without the @state some 1000 options are parsed in ~ 100ms with the @state it takes 6000ms.

I'm not sure how tree-sitter works under the hood, but now that I think about it, I am guessing that the grammar only produces the tree, and then the queries will be done on that tree. So if changing a query changes the performance, it may not be the grammar fault, but I will investiagte some more.

Interestingly if I run the query above using tree-sitter query query.scm CMakeLists.txt it's quick. It's just when I use the generated Rust parser API that it slows down to a crawl. I will try to investigate more as well.

Not sure if it's really the grammar or the query but given
import argparse

parser = argparse.ArgumentParser()
parser.add_argument("-n", required=True, type=int)
args = parser.parse_args()

print("list(APPEND FOO")

for i in range(args.n):
    print(f"BAR{i}")

print(")")

highlights like this
(normal_command
  (identifier) @command
  (argument (unquoted_argument) @one)
  (argument (unquoted_argument) @two)
  (argument (unquoted_argument) @three)
)

with varying numbers of matched arguments and a command like
python3 gen.py -n N > CMakeLists.txt && time tree-sitter query query.scm CMakeLists.txt

one can quickly see times like

N
one arg
two args
three args

10
0.003
0.015
0.022

40
0.003
0.019
0.431

80
0.003
0.034
11.158

100
0.003
0.027

200
0.003
0.109

400
0.003
0.785

800
0.004
6.153

But the real kicker and reason for that behaviour is that it returns a match for each and every argument, i.e. for the one arg case you see output like
CMakeLists.txt
  pattern: 0
    capture: 0 - command, start: (0, 0), end: (0, 4), text: `list`
    capture: 1 - one, start: (0, 5), end: (0, 11), text: `APPEND`
  pattern: 0
    capture: 0 - command, start: (0, 0), end: (0, 4), text: `list`
    capture: 1 - one, start: (0, 12), end: (0, 15), text: `FOO`
  pattern: 0
    capture: 0 - command, start: (0, 0), end: (0, 4), text: `list`
    capture: 1 - one, start: (1, 0), end: (1, 4), text: `BAR0`
  pattern: 0
    capture: 0 - command, start: (0, 0), end: (0, 4), text: `list`
    capture: 1 - one, start: (2, 0), end: (2, 4), text: `BAR1`
  pattern: 0
    capture: 0 - command, start: (0, 0), end: (0, 4), text: `list`
    capture: 1 - one, start: (3, 0), end: (3, 4), text: `BAR2`
…

instead of just a single list APPEND. It's certainly unexpected from what I can tell.

thank you for doing the investigation, it's very useful. For the query with 3 args that you've written, I think it's the expected behaviour for a query written like that. For the spike at the 800 statements with 2 args, I have no idea why that's the case, but 800 statements is also a big number of statements. Could you create an issue to the tree-sitter repo to ask about this problem?

For the spike at the 800 statements with 2 args, I have no idea why that's the case, but 800 statements is also a big number of statements.

We do have long lists of sources, maybe not 800 but certainly in the hundreds. I will look a bit deeper into the parser generator but yes, will open something over there if I have more understanding.


Print link cards with non-utf8 charset url incorrectly

Non-utf8 charset urls make link cards shown incorrectly (so-called MOJIBAKE).

Closable?


SpringBoot test as a service ?

Hi
i can across your 'spring-cucumber-serenity-test-harness' project and find it very helpful in understanding what I am trying to achieve.
I have recently started a role as an automation engineer.
What my developers want is to create end to end tests as a service. What I mean is write end to end api tests in cucumber bdd using serenity and restassured and write them as a service and deploy them as a webservice.
Tests will run when I will deploy this service and it will have a schedule which will also run the test.
As well as we can trigger the tests from Postman by hitting the 'POST' request.
I have already written a  simple test and deployed it as a service. Now I want to convert this test into cucumber and serenity bdd so that there is feature file and serenity report
Is this doable you recon and is there any help/suggestion you can give me ?

HI @SpringBootTestAsAService ,
I'm glad you found my code useful. Yes, it's doable.
I would recommend creating a REST web service which would allow you to make a POST request to trigger your tests, something like this would work.
One your web service is in place I'd create an executable jar file based the Serneity or TestNG tests. The jar file would read in the parameters/payload of your POST request.


When multiple screens are displayed, using fancyZones to move the window will display the extra part on other screens

Microsoft PowerToys version
0.80.0
Installation method
PowerToys auto-update
Running as admin
None
Area(s) with issue?
FancyZones Editor
Steps to reproduce
When using multiple monitors, use FancyZones to move to the edge of the first monitor. This will cause the remaining area to be displayed on the other monitors.
✔ Expected Behavior
fix bug.
❌ Actual Behavior
null
Other Software
No response

Would you mind sharing what your layouts look like in your editor? /needinfo

After uninstalling, I installed it using the installation package released by GitHub and it worked fine. I may have used winget to install it originally.


Alternative summary-title

Description
Today the title on the summary-component is the title from the component that is summarized. Would like the option to have a alternative title on summary-component. An example is if the component does not have any title but you want to show a title in the summary page and pdf to make it easier for the user to know what the field was about.
If you just add an paragraph above the the summary component it looks weird. Here is an example of an summary-component where the component does not have a title. One of the pictures is without a paragraf and one is with a paragraph(look at the top row).

Link to slack thread about the issue: https://altinn.slack.com/archives/C02FK32SFA4/p1678275843560759
Additional Information
No response

Is this solved now, as summaryTitle arrived in #1278? 🤔 Closing this issue as I expect this now has a valid solution, but please correct me if I'm wrong, @johlie.


WIP Handle publish error

Handle the publish close in the same way how the consumer does

Codecov Report

Merging #39 (acc6300) into main (b01bac2) will increase coverage by 0.13%.
The diff coverage is 73.33%.

@@            Coverage Diff             @@
##             main      #39      +/-   ##
==========================================
+ Coverage   80.36%   80.49%   +0.13%
==========================================
  Files          14       14
  Lines        1207     1205       -2
==========================================
  Hits          970      970
+ Misses        169      166       -3
- Partials       68       69       +1

Impacted Files
Coverage Δ

pkg/stream/producer.go
70.90% <ø> (ø)

pkg/stream/server_frame.go
75.62% <0.00%> (+1.47%)
:arrow_up:

pkg/stream/enviroment.go
75.73% <72.72%> (-0.54%)
:arrow_down:

pkg/stream/client.go
80.49% <100.00%> (ø)

pkg/stream/coordinator.go
93.51% <100.00%> (-0.06%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b01bac2...acc6300. Read the comment docs.


Add jsdom.nodeLocation

Fixes #1194, pending further parse5 updates to make it even better: https://github.com/inikulin/parse5/issues/67
/cc @bterlson. Should meet your needs for now.

LGTM.

:+1:


Automatic content negotiation (for browsers with WebP and JPEG XR support)

Hello,
Both Cloudinary and Imgix have an auto format option that does automatic content negotiation.
Is it in Glide's roadmap ?

At this point no, mostly because I know very little about this. Can you tell me more about it?

Sure, here are some resources from Imgix blog:
http://blog.imgix.com/2015/10/13/next-generation-responsive-images-with-client.html
http://blog.imgix.com/2014/08/20/webp-jpeg-xr-progressive-jpg-support-w-auto.html
User agent detection is ugly but Client Hints is a viable option, Chrome only though.
Another approach using Service Workers: http://www.deanhume.com/Home/BlogPost/service-workers--dynamic-responsive-images-using-webp-images/10132
That would solve our issue on the client side but Glide does not seem to provide WebP format because of Intervention Image not supporting it (https://github.com/Intervention/image/issues/233), right ?

I just stumbled over this issue while researching Client Hints. Here are few points to consider if Glide wants to support Client Hints:

Since Client Hints are sent as HTTP headers, Glide must support some kind of Request handling (maybe similar to the Reponses).
If the DPR header is used, the reponse must include a Content-DPR header, i think this is also not possible at the moment. This header should probably be set from inside Size manipulator.
Since Glide sends far future expiration and cache-control headers, also a Vary header must be set.
If a Width header overwrites the w query parameter and a hparameter is present, the value of h must be recalculated.

At the current state, i think it is not possible to support Client Hints easily. There must be some kind of middleware system to pre-process requests and responses and the parameters passed to the Glide server.
I've hacked a little package together to help enabling Client Hints in Glide (though it's still a little rough at the moment).
It contains a Resolver class which can used like:
$resolved = (new Jsor\HttpClientHints\Resolver())
    ->withWhitelist([
        // Process only Width and DPR headers
        'Width',
        'DPR',
    ])
    ->withMapping([
        // Map Width header to w key required for Glide
        'width'  => 'w',
        // Needed to extract the height from the query params for recalculation depending on Width if present
        'height' => 'h',
    ])
    ->resolve($_SERVER, $_GET)
;

if (isset($resolved['dpr'])) {
    header('Content-DPR: ' . $resolved['dpr']);
    header('Vary: DPR', false);
}

if (isset($resolved['w'])) {
    header('Vary: Width', false);
}

$server = League\Glide\ServerFactory::create([
    'source' => 'path/to/source/folder',
    'cache' => 'path/to/cache/folder',
]);
$server->outputImage($path, array_merge($_GET, $resolved));

Hope that helps.

+1 any news for this

pulling up an old issue I know haha so forgive me but I may have so information that may help on the content negotiation front.
As of right now you don't need to use Client Hints (or service workers though both are valid uses) as mentioned above by @ifox since Webp images are currently supported in blink based browsers and can use the Accept header checking for image/webp mime type.
This is how Google's Mod_PageSpeed (this is c++) currently does it and how Thumbor currently supports Webp Images. Eventually, possibly(?), webp will also be in Firefox (https://bugzilla.mozilla.org/show_bug.cgi?id=1294490). They too are debating/looking into using the Accept Header.
Jpeg XR (jxr) Images are currently supported in Microsoft Edge and they also advertise in the Accept header with vendor prefixed mime type of image/vnd.ms-photo
Right now you can use Nginx/Apache et all and use content negotiation to deliver these images. Here's some examples:

Ilya Grigorik: Deploying New Image Formats on the Web - webp
Eugene Lazutkin: Serve files with nginx conditionally - webp
Webp Detect - WebP with Accept negotiation
my post on conditionally serving webp and jxr with nginx

Now the only issue, which is out of the control of this package, with supporting Webp is Intervention is php 5.4 + and Jpeg XR (jxr) support in Imagemagick is a bag of snakes haha. It's not exactly "plug and play" to create / convert to jxr at least when I tested out using JXR images in the above linked post.

Soooo bit of a bump, but it seems that the Accept header is properly supported now, as well as WebP in PHP and most browsers. So what about an option 'auto=format' which checks of the browser supports WebP (Accept header contains image/webp) and then uses the WebP format? In the case of auto format, it should also add a Vary header and store the cache differently.
But it could also be handled at the project / framework level to just add the Vary header and change the format, before passing to glide.

Would be great if something like that would be implemented


Unit test this dog

Now that we already have a stable design we can cover it with unit tests.
Well, sorry TDD for being a little bit late on this :-)

Working hard to get everything under unit tests, so we can start using TDD in a smoother way.


hey i am new in this feild and i am facing this while testing

please help me i want this project badely

remove that loadfirebase

I removed

i also removed

I removed
hey do you know how to solve it
when i click sign in google button it opens sign in tab and i choose the account and the tab closes after the tab closes it must goto the chat screen but it is not going it is opening the same google auth tab please solve fast

hello there sorry for not replying check this out this closed issue https://github.com/aladinyo/WhatsappyApp/issues/4
if you need help reply to this and don't forget to check all closed issues

thanks for the help


F1: Function to Create User Accounts

Create a function to create user accounts

"Create Function:
Funtion createUserWithEmailAndPassword should create user account in database
Checks:

Ensure database response is correct to the user details
Success: User is created within the database containing (Name, userId, saved books array, book listings array)
Un-Successful: User is not created in the database"


[[Power-Fx]] Localization hand-back [CTAS - RunID=20230705-173205-vbkn7wqzp]

Translation handback check-in (PR Created by automation).

✅ No public API change.

✅ No public API change.


[Spyder 3.0.0dev, python3] TypeError: decorated slot has no signature compatible with triggered(bool)

Description of your problem
When starting spyder with python bootstrap.py, splash screen appears and then spyder crashes.
What steps will reproduce the problem?

git clone https://github.com/spyder-ide/spyder && cd spyder
python3 bootstrap.py

What is the expected output? What do you see instead?
Spyder is expected to open. Instead, it crashes.
Please provide any additional information below
Maybe can be related to https://github.com/spyder-ide/spyder/issues/3145, since I had this problem after upgrading Debian yesterday.
In python2.7, it runs fine. In python3.5:
$ python3.5 bootstrap.py
Executing Spyder from source checkout
Revision 1e85743, Branch: master
01. Patched sys.path with /home/cerebro/Malfatti/Software/spyder
02. PyQt5 is detected, selecting
03. Imported Spyder 3.0.0dev
    [Python 3.5.1+ 64bits, Qt 5.6.0, PyQt5 5.6 on Linux]
04. Running Spyder
Bootstrap completed in 00:00:00.4381
Traceback (most recent call last):
  File "/home/cerebro/Malfatti/Software/spyder/spyderlib/app/spyder.py", line 3128, in main
    mainwindow = run_spyder(app, options, args)
  File "/home/cerebro/Malfatti/Software/spyder/spyderlib/app/spyder.py", line 3014, in run_spyder
    main.setup()
  File "/home/cerebro/Malfatti/Software/spyder/spyderlib/app/spyder.py", line 854, in setup
    self.editor = Editor(self)
  File "/home/cerebro/Malfatti/Software/spyder/spyderlib/plugins/editor.py", line 400, in __init__
    self.initialize_plugin()
  File "/home/cerebro/Malfatti/Software/spyder/spyderlib/plugins/__init__.py", line 299, in initialize_plugin
    self.plugin_actions = self.get_plugin_actions()
  File "/home/cerebro/Malfatti/Software/spyder/spyderlib/plugins/editor.py", line 639, in get_plugin_actions
    triggered=self.load)
  File "/home/cerebro/Malfatti/Software/spyder/spyderlib/utils/qthelpers.py", line 242, in create_action
    action.triggered.connect(triggered)
TypeError: decorated slot has no signature compatible with triggered(bool)

Versions and main components

Spyder Version: clone from master
Python Version: 3.5
Operating system: Debian

Dependencies
I cannot open it, but here is a list:
$ dpkg -l python3 python3-jedi python3-jupyter-c* python3-matplotlib python3-numpy python3-pandas pep8 python3-pickleshare python3-psutil pyflakes python3-pygments pylint pyqt* ipython3* python3-sphinx | grep ii

ii  ipython3                   2.4.1-1            all
ii  ipython3-qtconsole         2.4.1-1            all
ii  pep8                       1.7.0-2            all
ii  pyflakes                   1.2.2-1            all
ii  pylint                     1.5.5-1            all
ii  pyqt5-dev                  5.6+dfsg-1         all
ii  python3                    3.5.1-3            amd64
ii  python3-jedi               0.9.0-1            all
ii  python3-jupyter-client     4.2.2-1            all
ii  python3-jupyter-core       4.1.0-1            all
ii  python3-matplotlib         1.5.1-1+b2         amd64
ii  python3-numpy              1:1.11.0-1         amd64
ii  python3-pandas             0.18.0+git114-g6c6 all
ii  python3-pickleshare        0.5-1              all
ii  python3-psutil             4.1.0-1            amd64
ii  python3-pygments           2.1.3+dfsg-1       all
ii  python3-sphinx             1.3.6-2            all

This is a general problem with Qt 5.6. I'm closing this one as a duplicate of issue #3145.


mas: init at 1.8.1

Motivation for this change
mas is a command line interface to the Mac App store, and having this package available will allow automation of interactions with the App Store
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[ ] NixOS
[x] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[x] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 99608 run on x86_64-darwin 1

1 package built:

mas

@SuperSandro2000 Thanks for the feedback! Somehow I didn't see this until now

This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.
Result of nixpkgs-review pr 99608 run on x86_64-darwin 1

1 package built:

mas


Feature request: start/stop with arguments from other extensions

I was wondering if it could be possible to invoke the start/stop commands provided by this extension with arguments from other extensions.
I'm currently developing an extension for starting local Kubernetes clusters with the help of K3D. I think vscode.commands.executeCommand("ngrok-for-vscode.start") could be used for invoking the start command, but I would like to pass the local IP and port as arguments. I was wondering if this could be possible now or if it could be possible to add this feature in the future...

Sorry for the delay in getting back to you on this. I think #23 should implement this. I don't know if you can try it out yourself or if you just need me to merge and release a version to test this with.
Let me know what you think.

Sorry for the delay in getting back to you on this. I think #23 should implement this. I don't know if you can try it out yourself or if you just need me to merge and release a version to test this with.
Let me know what you think.

I have merged #23, so I consider this closed. Please let me know if it works from another extension!


The actions in the kebab menu on plans page are not identical to the items in the Actions dropdown list on plan details page

The actions in the kebab menu of a plan on plans page are:

The actions in the Actions dropdown list on the plan details page are:

As you can see, they are different. The edit/delete actions can be executed on plan details page when they are not allowed on plans page.
The actions for the same plan on different pages should keep the same.

This is a known limitation.
As of 4.13 the kebab actions are not exposed via dynamic extension - they are only part of static extension SDK.
Note also that by design the contributed actions are merged into the list.  Overriding is possible only if you provide a custom details page which is still proof of concept - see PR #69

It looks like a bug in upstream console, we will not be able to fix in 2.4.0, moving to next release

@rszwajko hi, adding a backlog label so we know not to start working on that before working on the detail pages.

moving milestones to "next" due to 2.5.0 capacity

moving to next - pending plans pages re-design in 2.6

addressed by https://github.com/kubev2v/forklift-console-plugin/pull/963


NSQConsumer - cleaner shutdown

NSQConsumer: shutdown message processing on close
Executor does not have a shutdown method, only ExecutorService.
The close() method now does the following:

Shutdown executor first so no new message processing can start.
Shutdown scheduler
Tell NSQD we are closing down so stop sending messages.

Not 100% sure this is the desired order in a shutdown. Any suggestions
would be nice.
A caveat here is that new tasks submitted to executor will be rejected
after executor is shutdown. Maybe this is not desirable. At least it
will give the opportunity to specifically reject messages queued after
shutdown has been started. It also gives us the chance to cleanly finish already processing messages (with a timeout).

Imho you need to manage the Executor yourself anyway in any real world application. Currently the consumer provides a default Executor but I think this is the real problem here. This is great for the tests but pretty much fails in any real world application. I'm not sure want to change that now.
Stopping the Executor first is the way to go because then backoff will kick in and stops the message flow.
Maybe we should provide a method stop the message flow manually.
Shutting down the Executor inside the Consumer will not work because you could share a Executer between several Consumers.

Why would you manage the executor separately?
I am leaning towards requiring an Executor in the NSQConsumer constructor, or initialize with a fixedThreadPool(1). I think this would put the library more in line with the Go client that by default runs one goroutine per handler.


fix connection_id() should return bigint type

Proposed changes
Issue Number: close #28168

Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

run buildall


Experiments and Results

Nice implementation!
Could you please share the results and performances of your implementation on some popular datasets? For example, the total training time, the hardware requirement, and the FID in cifar10, imagenet64, and the LSUN dataset. Does the performance meet the performance reported in the original paper?

Hello.
The repo only contains code for the consistency models algorithm. To perform a performance comparison, you would have to implement the neural network that the authors used.


Cleanup, tests and minor improvements

Q
A

Is bugfix?
❌

New feature?
❌

Breaks BC?
❌

Fixed issues
-

👍


change dead pycurl package download link

Hi!
This is now a dead link and an image can no longer be built from this Dockerfile.
https://dl.bintray.com/pycurl/pycurl/pycurl-<IP_ADDRESS>.tar.gz
(JFrog is ending hosting resources in their bintray platform)
looks like something similar to this would work instead but still testing
pip download pycurl==<IP_ADDRESS>

After it seems like a dead-end for a temporary workaround replacing the package link to this worked.
https://files.pythonhosted.org/packages/e8/e4/0dbb8735407189f00b33d84122b9be52c790c7c3b25286826f4e1bdb7bde/pycurl-<IP_ADDRESS>.tar.gz


feat: added new landing page with separate sections and guidelines.

This PR replaces the default route /new-deployment with a customizable landing page at /landing. The landing page's content is now driven by a metadata.
This PR solves #100

@jtary check this out


Update Quiz Rules

Rule 4 says 'You can't exit from the quiz while you're playing.'
However, a 'Quit Quiz' button is present once we start answering. This rule needs to be modified in order to deliver an appropriate meaning.

This contribution is GSSOC'24.

Please assign it to me
Thanks.

hey its not required!


binary: 0.3.1 -> 4.0

Automatic update generated by nixpkgs-update tools. This update was made based on information from passthru.updateScript.
meta.description for binary is: Small and simple app to convert numbers to a different base
meta.homepage for binary is: https://github.com/fizzyizzy05/binary
meta.changelog for binary is: https://github.com/fizzyizzy05/binary/releases/tag/4.0
Updates performed

Ran passthru.UpdateScript

To inspect upstream changes
Impact
Checks done

built on NixOS
The tests defined in passthru.tests, if any, passed
found 4.0 with grep in /nix/store/imcmb4vf3ixcha36rifyr2cd0pafkx3a-binary-4.0
found 4.0 in filename of file in /nix/store/imcmb4vf3ixcha36rifyr2cd0pafkx3a-binary-4.0

Rebuild report (if merged into master) (click to expand)

2 total rebuild path(s)

2 package rebuild(s)

First fifty rebuilds by attrpath

binary

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/imcmb4vf3ixcha36rifyr2cd0pafkx3a-binary-4.0 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A binary https://github.com/r-ryantm/nixpkgs/archive/078cde86333c0d507d976ef8e82a16583671332c.tar.gz

Or:
nix build github:r-ryantm/nixpkgs/078cde86333c0d507d976ef8e82a16583671332c#binary

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/imcmb4vf3ixcha36rifyr2cd0pafkx3a-binary-4.0
ls -la /nix/store/imcmb4vf3ixcha36rifyr2cd0pafkx3a-binary-4.0/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

1 package built:

binary

Maintainer pings
cc @getchoo for testing.

Add a :+1: reaction to pull requests you find important.

@NixOS/nixpkgs-merge-bot merge


Improve bus stop path

buses follow the red path in the image above. and tend to block the road while stopping particularly when there are multiple buses.
it would be better if they followed the black path to get out of the way as fast as possible.
if Articulated bus turns too sharp it may block the inner lane so the path should not be too sharp.

related: https://github.com/CitiesSkylinesMods/TMPE/issues/1020#issuecomment-716743962

overlay rendered by this mod : https://steamcommunity.com/sharedfiles/filedetails/?id=2883351966
the code will look like something line this:
public static bool Prefix(ref NetLane __instance, float laneOffset, float stopOffset, out Vector3 position, out Vector3 direction) {
    ref Bezier3 bezier = ref __instance.m_bezier;
    position = bezier.Position(laneOffset);
    direction = bezier.Tangent(laneOffset);
    Vector3 sideDir = Vector3.Cross(Vector3.up, direction).normalized;

// NON STOCK CODE START
    const float t1 = .12f;
    const float t2_0 = 0.20f;
    float t2 = t1 + 0.7f / __instance.m_length;
    t2 = Mathf.Max(t2, t2_0);

    float t = laneOffset <= 0.5f ? laneOffset : 1 - laneOffset;
    float d;
    if (t < t1) {
        d = 0;
    } else if(t > t2) {
        d = 1;
    } else {
        d = (t - t1) / (t2 - t1); // from 0 to 1
    }
// NON STOCK CODE END

    position += sideDir * stopOffset * d;
    return false;
}


Address NullPointerException FindBugs warning instances

#241.
Here is my take on addressing NPE warnings that FindBugs reports.

I learned that I can use 'assert' to mute a warning case. Some cases were muted simply this way.
Some warnings can be avoided by simple syntactic restructuring of code.
For a couple of cases, I really inserted a null check.

For 1 and 2, it is my own logical conclusion that those cases don't need an explicit null check. I can't say I am 100% confident though. I also believe that the simple syntactic substitution doesn't change the semantics (i.e., I assume function calls are 'const').
After this PR, we would have exactly one FindBug warning instance and one PMD warning instance, which we need to look into together.

Note: some method calls are @NotNull, so those are easy cases to confirm that they don't return null. However, some other methods are @Nullable.

Disappointing to hear that asserts are not allowed. I guess I have to fall back to add bunch of elements into the FindBugs XML config file to mute many warnings.

assertions are allowed
https://engdoc.corp.google.com/eng/doc/devguide/java/practices/assertions.md?cl=head
But they should really be seen as simply documentation. We have a habbit of
using asserts in our code today because it gets rid of some IJ warnings
about null.
I haven't looked at this PR yet, but will shortly.
On Wed, Mar 16, 2016 at 9:55 AM, Chanseok Oh<EMAIL_ADDRESS>wrote:

Disappointing to hear that asserts are not allowed. I guess I have to fall
back to add bunch of elements into the FindBugs XML config file to mute
many warnings.
—
You are receiving this because you were assigned.
Reply to this email directly or view it on GitHub
https://github.com/GoogleCloudPlatform/gcloud-intellij/pull/504#issuecomment-197342469

Hmm... using those Preconditions and Verify runtime checks in these cases makes sense. Unfortunately, muting FindBugs warnings is an orthogonal matter, and those Google checks cannot mute the warnings.
In this PR, I think I would focus on knocking out the FindBugs warnings. We are back to ground zero.

That's odd. If it works on bytecode I would expect it to see the null
checks in the preconditions.
On Wed, Mar 16, 2016 at 10:54 AM, Chanseok Oh<EMAIL_ADDRESS>wrote:

Hmm... using those Preconditions and Verify runtime checks in these cases
makes sense. Unfortunately, muting FindBugs warnings is an orthogonal
matter, and those Google checks cannot mute the warnings.
In this PR, I think I would focus on knocking out the FindBugs warnings.
We are back to ground zero.
—
You are receiving this because you were assigned.
Reply to this email directly or view it on GitHub
https://github.com/GoogleCloudPlatform/gcloud-intellij/pull/504#issuecomment-197365671

My guess is that it's because those checks are not macro expansion but a function call. The null check will be done outside of the current context (i.e., inside checkNotNull), and FindBugs simply cannot assume that an outside function call has done a null check for a caller.

Closing this per our discussion. #508 opened.


Orphan Preprint-Nodes show up when using filter[preprint]=false on /v2/nodes/ [PREP-129]

Purpose
Allow finding all non-preprint nodes (/v2/nodes?filter[preprint]=false), which includes orphaned preprints (preprints without a file, so no longer actual preprints).
Changes
Change the behavior of filter[preprint] to more accurately find preprints when its value is true, and to include orphaned preprints when its value is false.
Testing
To test, create some orphan preprints, then check that when the value of the filter is false on the nodes list endpoint (/v2/nodes?filter[preprint]=false), it includes those, and that the total number of nodes found with /v2/nodes?filter[preprint]=false + /v2/nodes?filter[preprint]=true is equal to /v2/nodes
Ticket
https://openscience.atlassian.net/browse/PREP-129

This is obviated by https://github.com/CenterForOpenScience/osf.io/pull/6346/commits/4208aadbac565b27815d9b6145bace64a33df5cd in #6346, closing. 🐼


Swift code-generation

Summary
Extends https://github.com/novifinancial/serde-reflection/pull/109 :

CI under Linux
code generation module should be mostly done
several fixes in the runtime

Caveats and TODOs:

It looks like the "Reader" runtime still crashes ("illegal instruction 4") in case of underflow.
BCS maps are not yet supported
Not sure how to solve the warning BinaryReader.swift:83:63: note: condition always evaluates to true. Perhaps we should give up on testing endianness (which itself does not seem very portable) and just use the simpler (mildly slower) arithmetics as in other languages.
We still need to port the more complicated runtime tests to confirm that serialization and deserialization work as intended for all supported types.
I personally gave up on using Swift tuples
The current generated code marks everything as "indirect". We could probably do much better in the future but this should not be blocking.
The "installer" for swift is not finished

Test Plan
CI

Also, there is this suspicious warning:
serde-generate/runtime/swift/Sources/Serde/BigInt.swift:130:24: warning: function call causes an infinite recursion
                self = _BigInt(sourceMag)


Issue in Chrome

I've found an SVG I've created and exported using this plugin doesn't work in Chrome because it is not imported with the namespace attribute.

what version of the plugin and sketch are you using?
did you change the config of the plugin?
could you share the file used to export the svg so that we can repro the bug?


OP Past Airdrop Addresses CSVs

Adding 4 csvs as seeds from this repo and combining user addresses across multiple airdrops.

@chuxinh thank you!!


The way we are thinking of doing this is by writing the job id of the MR job in a file mapReduceJobId.json which will be stored under the taskBaseDir
A separate file will be required as the MR job is executed in different JVM and there is no way it could communicate with kill task snippet, so writing the required info in a file was the only option
Currently, this file will only store the running JobID, this way when some one wishes to kill the ingestion task it can read the current running MR job (if any) and issue a yarn kill command
Phase II: Implement the resume ability for Hadoop ingestion tasks
The above file will now store the job Id of each intermediate MR task so that we can track till what step the ingestion was completed and can resume from the following step instead of executing from the beginning

Phase I sounds pretty useful, what entity would issue the yarn kill command? Do you have more details on the interfaces/code areas you plan to change for that?
For Phase II, can you describe the use case in more detail? When would a task resume occur? What happens if the input to the ingestion task changes between retries (e.g. the task is reading from some s3 bucket which gets some new files)?

@jon-wei HadoopIndexTask will issue the kill command using the ToolRunner util class
We do have a working implementation ready for 0.12.2 and have been testing it for quite some time now
for phase II will share a detailed use case soon

@jihoonson so you are suggesting to go for phaseII first and then make a unified kill task support?

@ankit0811 I'm also not sure what restoring means for Hadoop indexTask and how it's useful. I just mean, you may need to make Hadoop indexTask restorable no matter what it does on restore(). Or, maybe it's better to extend stopGracefully() to be called for non-restorable tasks as well.


Updated CHANGELOG for a 3.0.0 polymer-bundler release.

[x] CHANGELOG.md has been updated.
[x] README.md has been updated.
The reason this is a major release to 3.0.0 is due to the breaking change of defaulting to polymer 2.x behavior and mapping all old polymer 1.x vulcanize-style url rewriting preferences to the rewriteUrlsInTemplates option.

@katejeffreys and @arthurevans wrt docs: I am unaware of places where polymer-bundler library itself is specifically documented other than its own README.  Are you aware of any?

Plan is to release this 3.0.0 version with the breaking change and then update the 2.x version of polymer-cli to either:

Default rewriteUrlsInTemplates to true, maintaining CLI support for polymer 1.x mirroring old vulcanize behavior.
Default rewriteUrlsInTemplates to true if CLI can identify the version of Polymer in the project is 1.x.  That could be done statically by looking at bower.json (which may be unreliable if install-time resolution made user choose a 2.x version) or by checking the version key of the bower.json within the installed polymer component folder.

Still working that out.

Pretty sure we don't reference the polymer-bundler library anywhere in the docs—certainly not more than a passing mention.  We'll update docs when CLI 2.0 comes out. (That we'll need to coordinate on.)


Pull out code that could be reused for building blocks of our own solver

We need to take jsonpath expressions and traverse scala Maps without losing the scala type information (handleAny type and don't cast to Json).
I pulled out the code that could be re-used with our own solver into an abstract class.
To see how we plan to make use of this, see the commit here where I removed the solver we would implement in our own repo making use of the shared code building blocks:
https://github.com/filosganga/jsonpath/commit/40e146527d2a3638ebf852fe6bc7cc9931dba78c
Tests already exist to ensure the refactor did not change any behaviour.

@filosganga

the tests pass but looks like there's an issue with uploading the artifact,  workflow configuration issue?

That's great, this was one of the idea I had but I wasn't sure if it was worth the effort, it looks like so. Thank you


Title: Weather App

Which pre-existing JavaScript project will you be working on?
I'm making a weather app for hacktoberfest.
Describe your enhancement/improvement
This project uses openweather-api and fetch to seamlessly load the data we search for.
Anything you need to say to the Reviewers
No response
Add any other context or relevant screenshots about the enhancement here.
No response

@manmohanhunjan This project is already there, you can check out here


ci: fix PR comment publish

Fix publish action by commenting a pull request:
The project is forked so that it's possible to dev on main branch and test the action.
Test with fix/ci-publish branch pull request:
https://github.com/ad2ien/ui/actions/runs/2504934920
Tries to push ghcr.io/ad2ien/ui:fix-ci-publish docker image and tries for npm package:
🚀 Publishing npm package with following command line: yarn publish --no-git-tag-version --non-interactive --prerelease --preid fix-ci-publish.20220615202551 --tag fix-ci-publish

Codecov Report

Merging #281 (011ac10) into main (7d7ab2a) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #281   +/-   ##
=======================================
  Coverage   97.57%   97.57%
=======================================
  Files          55       55
  Lines         535      535
  Branches       74       74
=======================================
  Hits          522      522
  Misses         12       12
  Partials        1        1

:mega: Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

Some failing test due to missing tokens are not relevant, I don't know if it's possible to bypass...

@ad2ien Can you please rebase your branch ? We'll see if https://github.com/okp4/ui/pull/282 make it green 💚.

:tada: This PR is included in version 1.7.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


core 0.7.9 compatibility

Resolves #24
Foundry Core v0.7.9 removes the devicePixelRatio game setting, which makes this setting getter throw an error instead of return a value. Wrapping that setting getter in a try catch prevents the thrown error from causing perfectVision to fail on startup pretty catastrophically.

Thanks! I had already started to restructured some code in this area so I added in there. Fixed in 04193bc53ae902dcdf901268ebcf5fa45a67278d.


RequestDenied leads to an invalid reponse error

samlp:Status
<samlp:StatusCode Value="urn:oasis:names:tc:SAML:2.0:status:Responder">
<samlp:StatusCode Value="urn:oasis:names:tc:SAML:2.0:status:RequestDenied" />
</samlp:StatusCode>
</samlp:Status>
Leads to an "Error - Invalid Identity Provider response"
This should probably lead to a more descriptive error...
In my specific case, the IdP (ADFS) refuses to authenticate a user because a pre-condition (Issuance auth rule) has not been met.

This is #61 and has/will be fixed in 5.2.

Ah crap, I scanned the issues but missed that one.. Sorry!


Unicode Version

Requesting a unicode version of this plugin.

This has been added a while ago by Fredrik Pettersson.


typo: Latitiude -> Latitude

@nschonni : Thanks for your contribution! The author, @dominicbetts, has been notified to review your proposed change.

Hi @nschonni - thanks for this.
#sign-off


my code is not deployed in my salesforce org

Type: Feature Request
there is no option of deploy the code .
extension was not start .
i cant push the code into my salesforce org.
VS Code version: Code 1.73.0 (8fa188b2b301d36553cbc9ce1b0a146ccb93351f, 2022-11-01T15:34:06.111Z)
OS version: Windows_NT x64 10.0.19045
Modes:
Sandboxed: No

/causedByExtension

This issue is caused by an extension, please file it with the repository (or contact) the extension has linked in its overview in VS Code or the marketplace for VS Code. See also our issue reporting guidelines. If you don't know which extension is causing the problem, you can run Help: Start extension bisect from the command palette (F1) to help identify the problem extension.
Happy Coding!


How about supporting Bitcoin Core's derivation paths?

The forthcoming 0.13 release of Bitcoin Core introduces elementary support for BIP32. I've been using a modified version of your site to test the addresses it generates.
I needed to modify it because Core uses "hardened" derivation for the index of each address as well as for each part of the path.
So the first address it generates is m/0'/0'/0', the 2nd is m/0'/0'/1', etc.
The change I made is to simply generate an address from each of $path/$index and $path/$index' (note the trailing quote) for each index:
     function TableRow(index) {

         function init() {
-            calculateValues();
+            calculateValues(false);
+            calculateValues(true);
         }

-        function calculateValues() {
+        function calculateValues(hardenedIndex) {
             setTimeout(function() {
-                var key = bip32ExtendedKey.derive(index);
+                var key = hardenedIndex ? bip32ExtendedKey.deriveHardened(index) : bip32ExtendedKey.derive(index);
                 var address = key.getAddress().toString();
                 var privkey = key.privKey.toWIF(network);
-                addAddressToList(index, address, privkey);
+                addAddressToList(index + (hardenedIndex ? "'" : ""), address, privkey);
             }, 50)
         }

It's ugly and probably not how you want to do it (if at all). But maybe my clumsy implementation is helpful.

Great idea, I will implement this feature in the next release.

Implemented in https://github.com/dcpos/bip39/commit/146e089e28fbda936955ce74fc1f2214418633c5 Hardened Addresses checkbox and https://github.com/dcpos/bip39/commit/8786746ba4b11e6d459e80868cbb2ac5bde4114a Bitcoin Core derivation path information
Thanks for the idea.


Debug-output with tree of included files

Make an option for printing some kind of tree showing the order of included files.
filea.cjson
  ` fileb.cjson
     ` fileb-1.cjson
     ` fileb-2.cjson
  ` filec.cjson
  ` ...

I haven't had the need for this when working with oconf. Could you add some motivation for this feature, and comment on wether or not you still feel this is needed?

I had the need after digging around the include-tree in one of the services that had a chain of configs that came from SCM, generated files, the packaging system and some chef-thingie.
If it still applies, there is a branch at https://github.com/One-com/node-oconf/tree/tree-resolver

It sounds sane enough to me. I'll probably not invest any time in it unfortunately. But I don't see any harm in landing it :-)


"Unable to initialize 3D output" after installing anything with Addon Manager

Like the title says, no matter what I install, not just the DirectX 12 proxy, I get this:

My GPU supports DirectX 12, my drivers are up to date, and I reinstalled the GPU drivers and DirectX 12 just to be safe. Nothing changes.
The only way I've found to fix the issue once I get that error is to delete my bin64 folder. None of the actions available in the manager fix it.

Update, I do not need to delete the entire bin64. Just deleting the d3d9.dll works

To be clear, by "fix the issue" I mean once again be able to successfully run GW2. No addons work with this manager for me.

I have the same issue. did you ever get a fix for this?

Why was this closed? This has not been fixed.


The input keywords for QBMM are missing in the documentation

There is no mention in the documentation of the following input keywords:
- qbmm
- dist_type
- poly_sigma
- R0_type
- sigR
- sigV
- rhoRV

Assigning to @anandrdbz since he will know what these are.

Added in the latest PR


Possible improvements for template and converter

Taken over from https://github.com/nfdi4cat/VocExcel/issues/2
Template
This is for discussing possible future structural changes. This is not urgent but may serve as a checklist to review before the next big template-version step (in descending priority):

[ ] Get rid of "Additional Concept Features" sheet. The columns can be moved to the Concepts sheet.
[ ] The size of a collection is currently constrained by the maximum number of characters in xlsx cells (32767 chars). Depending on the IRI-length this may correspond to a few thousand concepts per collection (which is probably large enough for most applications). However, the UX how the membership in a collection is added or edited is rather poor. It would be much nicer, if membership could be marked in the concept sheet. This could be done by adding one column per collection to the sheet "Concepts". Then Excel filters could also be used efficiently to edit/review membership of Concepts in Collections. If we change the template like this, we will have a tighter limit on the number of collections since xlsx columns are limited to max. 16 384. However, more than 16 000 collections should be even less problematic than the current limit of a few thousand concepts per collection.
[ ] support for skos:altLabel in multiple languages. Currently it is assumed that all (comma-separated) altLabels are always given in the default language "en".
[ ] Support different languages for collection prefLabel.
[ ] Make multi-language data entry easier by specifying just one language per line in the concept sheet.
[ ] Put version of template to a better place and add information about min. version of voc4cat required.
[ ] Use a different separator than comma in xlsx cells. Users often use a comma as part of the text and/or use a semicolon as separator because they are used to semicolons from Excel formulas. It is suggested to separate urls from other urls or text by space (and/or) newline. For pure text fields (alternate label), we should consider to use a vertical bar | as separator.
[ ] Add a feedback column that has no fixed semantic interpretation and that will not show-up in turtle. It could be used by tools (or humans) to add notes which are only relevant while editing the Excel-file. This may be for example used by checking tools. The advantage of having such column is that Excel-filters could be used to quickly search through the information.
[ ] Add a status column with states proposed/accepted/obsolete and information about obsoletion (deprecated/replaced/removed - same column?). We may also think about adding pre-defined reasons for obsoletion (inspired by https://wiki.geneontology.org/index.php/Obsoleting_an_Existing_Ontology_Term)

The term is not clearly defined and usage has been inconsistent.
This term was added in error.
More specific terms were created.
This term was converted to a collection.
The meaning of the term is ambiguous.
There is no evidence that this function/process/component exists.
...

[ ] (maybe) Use tables instead of hard-coded cell-positions and sheet names. Tables can be found independently of their cell position and "home" sheet. This would give users more flexibility to adjust the layout. (previously suggested here)

Converter

[ ] (maybe) Output SKOS-XL. Then a unique ID for each translation allows to make statements on the translated concept, e.g. about provenance of the translation.
[ ] (maybe) Support not-yet supported SKOS relations like skos:broaderTransitive, skos:narrowerTransitive

Profile

[ ] Allow prefLabel in multiple languages (see vocexcel#1). We probably need our own SHACL vocabulary profile.

Here is a draft for a new xlsx template structure that includes all of the changes proposed above except for the last one (use of tables). Note that the help sheet has not yet been adapted.
photocatalysis_example_Template-0.5-r2023-08-04.xlsx

The proposed new template (2nd draft) cannot handle that skos:collections may have not only concepts but also other collectionns as skos:member.

I like esp. the first three items on the list, @dalito :)

Hi @dalito,
regarding the collection item in the checklist above:
I would suggest the following process:

collections (IRI and name) are registered in the "collections" tab
in the "concept" tab each collection gets its own column (column name must match the collection name)
to add a concept to a collection, simply a cross ("X") needs to be set in the corresponding column

Like the green column Q of the example file? There would be one column per collection in concept sheet. I just added one to show the idea.

Collection in collection would be modelled in collections sheet. This is not yet in the template draft IIRC.

Like the green column Q of the example file (2nd draft)? There would be one column per collection in concept sheet. I only added a single column to show the idea.

yes, @dalito, and then in the cells the user just adds an "X" (small or capital should be allowed) - boolean would be nicer, but most non-programmers are not so familiar with this concept of True and False ;)

Hi @dalito,
here some further usability improvement suggestions:
Children IRIs should be referenced by preferred Label (this is more readable and less error prone).
If possible, I would omit the Concept IRI from the Concept tab, completely. The Concept IRIs with the right padding could be automatically generated by the CI-pipeline. As numbering for the IRIs one could then just use the line numbers of the excel sheet. That would simplify the sheet.

Children IRIs should be referenced by preferred Label"

This easily breaks if a label is changed at one place but another is forgotten. In the past there were many problems with misspellings, case, white space or separator use. IDs are the solution to this.
It is possible to use in indentation for hierarchy as alternative when using voc4cat-tool locally (pip / pipx installed).

@markdoerr In the childrenIRI field we could perhaps append the preferred label after each IRI. The label would just be present for convenience but would be stripped off when reading.
https://example.org/0000105 (infrared)
https://example.org/0000106 (visible)
https://example.org/0000107 (ultraviolet)

I have updated the first message and put a new (3rd) draft for the template "1.0" to the 2nd message which addresses all issue/ideas that came up until now.

Thanks @dalito,
sounds good, I will have a look ...


Supporting clarification that Uris should fit within the bits and bytes allocated for Micro Form when serializing

Howdy folks :wave:
Left a comment over on this in-flight PR updating to support 1.5.7, but surfacing as an issue as well for the attention :slightly_smiling_face:

As Peter reported, there are still a few issues with the micro URI. Given that we are going to drop the id and ip from uAuthority, I'll fix up the rest of the micro issues then.


Define/implement standard parsl executors for fractal

Merging https://github.com/fractal-analytics-platform/fractal/pull/172 will close #157, so that we now can specify a given executor for a task (in the manifest, or by modifying the task later on). The list of allowed executors is currently a trivial one, only including cpu and cpu-2 (which are actually identical).
We should discuss on:

Which list of standard executors would we include? There could be four combination of {high,low}-{mem,cpu}-cpu, and at least one gpu one. There can be also a couple of gpu executors, like gpu-single (limited to a single gpu node) and gpu-many.. or something like this.
Where will this information on standard executors be stored (as an hard-coded list of parameters)? There are simple answers to this question, but we should first understand how many of these standards should exist: a unique one? one per lab?
How could a user define a fully-custom executor? This is currently not implemented. We should probably move it to another issue, after an assessment of how important it is.

Great summary. I'd suggest we go with a subset of what you describe in 1, e.g.:
high mem, high cpu
high mem, low cpu
low mem, low cpu
a gpu (with high cpu mem & decent cpu count)
These 4 should cover many basic use cases. And then we collect feedback on how they are used, what else would be required. They may vary quite a bit between the two labs, but there should be some good defaults for each lab :)


Operator doesn't update vmagent config if additionalScrapeConfigs secret was changed

Operator (since v0.22.0) doesn't update vmagent config when secret with additional scrape config was changed.
Config describe as
additionalScrapeConfigs:
    name: additional-scrape-config
    key: additional-config.yaml

Operator v0.21.0 writes log messages when secret was updated
{"level":"info","ts":1649238529.6811318,"logger":"controllers.VMAgent","msg":"Reconciling","vmagent":"monitoring/vmagent-ha"}
{"level":"info","ts":1649238529.9882824,"logger":"factory","msg":"current VMAgent configuration has changed"}
{"level":"info","ts":1649238529.988304,"logger":"factory","msg":"updating VMAgent configuration secret"}

but operator v0.22.0 and higher doesn't

additional scrape config secret metadata:
finalizers:
  - apps.victoriametrics.com/finalizer
  name: additional-scrape-config
  namespace: monitoring
  ownerReferences:
  - apiVersion: operator.victoriametrics.com/v1beta1
    blockOwnerDeletion: false
    controller: true
    kind: VMAgent
    name: vmagent-ha
    uid: 938da2ae-a9a6-4ba3-85c6-ece7e5d7b380

I think, it should be fixed at the next release. Operator will resync configuration with configured interval. It's more reliable then watching for ownership.  Related PR https://github.com/VictoriaMetrics/operator/commit/18031e310c8f3e582257ccbbba6890f59c1d32b6

Changes was included to the v0.24.0 release. Feel free to re-open the issue if it doesn't help.

It did work, thanks


aaryav_pad

Ready to make a PR? Great! Make sure your directory structure looks like this:
├── CAD
│   ├── case.stl
│   └── plate.dxf
├── firmware
│   └── rp2040.bin
└── PCB
├── macropad.pro
└── macropad.sch
(The file names do not matter, just the folders)

If it is possible black pcb with white silkscreen would be lovely.

I have made some changes. Let me know if something is still left, and I will fix it immediately. I am using KMK firmware, so it cannot be compiled into a .uf2 file, so I have uploaded the Python code.
For the case, I'm trying to get a bumper case to protect the edges, but the PCB can be viewed from the bottom and top view because it has a lot of details. PLAN B: if this does not work, I will make a handmade wooden case because that is what I originally wanted.

I also have no idea why all the checks have failed :(

So would the case snap-in? or would you have another way of attaching it

Yeh the case is a snap in

I'll approve this for now, let me know how it goes!
https://forms.hackclub.com/hackpad

I filled the form!!
Thank you so much :)

Also can I get it with just the hotswap thing soldered into it ? I would like to solder the rest of the components by myself.


call finalize_block when finalized block changes

Describe the bug
Blockchaintree has a function
https://github.com/paradigmxyz/reth/blob/1763b5ea7a936c0deff36380838bee4858ee7758/crates/blockchain-tree/src/blockchain_tree.rs#L726-L727
that should be called when we know a new block was finalized
we need to call this when we update the finalized block from inside the engine
Steps to reproduce

Node logs
No response
Platform(s)
No response
What version/commit are you on?
No response
What database version are you on?
No response
If you've built Reth from source, provide the full command you used
No response
Code of Conduct

[X] I agree to follow the Code of Conduct

Would like to take this one, please.

now that we have:
https://github.com/paradigmxyz/reth/pull/3725
we need to call the function mentioned above with the new finalized block, to clear outdated side chains that we keep in memory
so basically tree.finalize_block in the update finalize block added in #3725


Release Notes for Edge WebDriver?

I'm probably missing something, but please could I have a link to Edge WebDriver's release notes page?
E.g. here's the analogous ChromeDriver release notes page, (also as individual text files). I assume this exists for Edge WebDriver, however I've not been able to find it.
Thank you!

Hi @pdvcs we don't currently publish release notes for Edge WebDriver, but I've added this request to our internal backlog for consideration. Edge WebDriver is based on ChromeDriver and we contribute bug fixes to ChromeDriver whenever possible, so the ChromeDriver release notes are the most comprehensive source of information at the moment.


Occasional rate limit error when retrieving modules from CodeCommit

I'm occasionally seeing rate limit errors when retrieving modules that are hosted in CodeCommit. I think this could be addressed by adding a regex for this error to the list of retryable errors.
The error is of the form:
Error: Failed to download module
Could not download module "<MODULE_NAME>" (<FILENAME>:<LINENO>) source code from "<SOURCE URL>":
error downloading '<SOURCE_URL>':
/usr/bin/git exited with 128: Cloning into '<CLONE DIR>'...
fatal: unable to access '<REPO_URL>':
The requested URL returned error: 429

I think this regex would work: "(?s).*Error: Failed to download module.*The requested URL returned error: 429.*"

Released in https://github.com/gruntwork-io/terragrunt/releases/tag/v0.38.12


inline anonymous abstract objects

Let's make it possible to write abstract objects in line, for example:
[x] /a-z/.matches x

is the same as
[x]
  /a-z/.matches x > @

Good issue. Thought of it many times.

@rultor release, tag is 0.1.22

@rultor release, tag is 0.1.22

@yegor256 OK, I will release it now. Please check the progress here

@rultor release, tag is 0.1.22

@yegor256 Done! FYI, the full log is here (took me 11min)

Job gh:cqfn/eo#266 is not assigned, can't get performer


Duplicate field in forum post tsv

As per title, TIMESTAMP is duplicated in the forum post spec:
https://github.com/jiscdev/xapi/blob/1.0.1/recipes/vle/uxapi/vle-forum-input.md

Also on the quiz completed page:
https://github.com/jiscdev/xapi/blob/1.0.1/recipes/vle/uxapi/vle-quiz-completed-input.md


Replacing uses of portalIP by clusterIP

Replacing uses of portalIP by clusterIP

This PR does not replace all portalIP uses, e.g., cluster/ubuntu/skydns-svc.yaml.template.
By the way, services.sh seems to have been fixed by #10819.

That is still a beta1 config file.
Thanks for pointing me to that PR. Closing this.

I'm not sure why github didn't ask you to rebase. I tried re-opening the PR but the status was the same :(


add jobs support

retest this please

retest this please

retest this please

shakedown has a dependency on dcos-cli which provides access for functions and features like this.  https://github.com/dcos/dcos-cli/blob/master/dcos/metronome.py is the way to enable this behavior.

the dcos-cli will be released this week and scott will provide an update in shakedown when the release happens.  That makes this PR redundant.

examples of how to use are here: https://github.com/dcos/metronome/blob/master/tests/system/test_root_metronome.py
it currently uses a local copy of metronome prior to the PR being merged into dcos-cli.

Any opposition to making shakedown depend on dcos master, so we don't have
to wait weeks for functionality to support tests?  I think sacrificing
repeatable builds is worth the productivity tradeoff for a testing tool
like this
On Dec 5, 2016 09:43, "Ken Sipe"<EMAIL_ADDRESS>wrote:

@kensipe requested changes on this pull request.
This is redundant and isn't the recommended approach.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/dcos/shakedown/pull/95#pullrequestreview-11430300,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAJYhqD6A3UnOrWWCPrjlzzxPxov_hVvks5rFE0xgaJpZM4LC3dY
.


⚠ Processors has degraded performance

In b67223a, Processors ($STATUS_URL) experienced degraded performance:

HTTP code: 200
Response time: 128 ms

Resolved: Processors performance has improved in 9a3d220.


OU-561: Use AlertsRulesDetailPage from monitoring-plugin

/hold
https://github.com/openshift/console/pull/14596
https://github.com/openshift/monitoring-plugin/pull/286
Fixes:

https://issues.redhat.com/browse/CONSOLE-4380
https://issues.redhat.com/browse/OU-561
Solution Description:

Remove AlertRulesDetailsPage from console
Add a route in monitoring-plugin to enable it
Remove code related to routes that are no longer provided by console repo

Screen shots / Gifs for design review:

The only change to the AlertsRulesDetailPage in the developer perspective is that it will no longer have a namespace selector. Since the selected alert is already namespaced, it didn't make sense to swap namespaces while focused on a specific AlertRule.
Unit test coverage report:

n/a
Test setup:

Host the monitoring dynamic plugin locally by running
./bin/bridge -plugins monitoring-plugin=http://localhost:9001 -i18n-namespaces=plugin__monitoring-plugin -branding openshift  # console backend
yarn dev  # console/frontend and monitoring-plugin/web

Browser conformance:

[x] Chrome
[x] Firefox
[ ] Safari

/cc @juzhao
Can you test this with https://github.com/openshift/console/pull/14596?
All the functionality of the Alert Details Page should be the same. We're just migrating the code from openshift/console to the monitoring-plugin.
This PR in the console removes the Alert Details Page https://github.com/openshift/console/pull/14596.
While this PR adds the code for the Alert Details Page for the monitoring-plugin.

/retest

/retest

/retest

Once QE reviews it. I'll mark it with LGTM.

/retest

tested with cluster-bot
launch 4.19,openshift/monitoring-plugin#286,openshift/console#14596 aws
found 3 regression bugs, not related to these 2 PRs
https://issues.redhat.com/browse/OCPBUGS-37547
https://issues.redhat.com/browse/OCPBUGS-45892
https://issues.redhat.com/browse/OCPBUGS-45896

/lgtm

/unhold


Activate API compatibility check automatically on JDK8+

Merged by https://github.com/droolsjbpm/droolsjbpm-knowledge/commit/0e273f0c8

@psiroky Thanks!


Add support for adding alerts using amtool

Closes #1417
cc @stuartnelson3

:+1: thanks for doing this!


When can we support the gpt-4o model?

The requested model 'gpt-4o' cannot be used with the Assistants API in v1. Follow the migration guide to upgrade to v2: https://platform.openai.com/docs/assistants/migration.

openai4j This is a fork in this library. The latest version supports the assistant API v2. Welcome to use it


Add test cases that is left commented out

Update the test cases of ModelManagerTest.java, UserPrefsTest.java

Codecov Report

Merging #284 (97b687d) into master (34924f3) will increase coverage by 0.99%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master     #284      +/-   ##
============================================
+ Coverage     60.51%   61.50%   +0.99%
- Complexity      462      472      +10
============================================
  Files            89       89
  Lines          1712     1712
  Branches        194      194
============================================
+ Hits           1036     1053      +17
+ Misses          584      574      -10
+ Partials         92       85       -7

Impacted Files
Coverage Δ

...edu/trackermon/logic/parser/SortCommandParser.java
77.63% <0.00%> (-1.32%)
:arrow_down:

...va/seedu/trackermon/model/show/UniqueShowList.java
92.68% <0.00%> (+2.43%)
:arrow_up:

...rc/main/java/seedu/trackermon/model/UserPrefs.java
75.00% <0.00%> (+3.12%)
:arrow_up:

src/main/java/seedu/trackermon/model/ShowList.java
91.66% <0.00%> (+4.16%)
:arrow_up:

...main/java/seedu/trackermon/model/ModelManager.java
98.36% <0.00%> (+24.59%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 34924f3...97b687d. Read the comment docs.


Validatable behavior should take session into consideration, if any

It does now. While I love Validatable behavior I discourage its use because most of the times the model in your database is simple and you can easily use "validatable inputs" instead of resorting to such a barbaric way of doing validation.

You are thinking of a software where data is mostly input-ed from a client view. In our case, we've got a big bunch of autonomous server work, webhooks, third party dependencies, etc. and we are therefore dealing with tthe DB a lot without going through GraphQL with sometimes quite sensitive data that we must ensure are properly valid at all time


Typo "Azure Blob storage"→"Azure Blob Storage"

https://docs.microsoft.com/en-us/sql/t-sql/statements/create-external-table-as-select-transact-sql?view=aps-pdw-2016-au7

@hyoshioka0128 : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@hyoshioka0128 : Thanks for your contribution! The author(s) have been notified to review your proposed change.


edit recipes

As a user
I want to edit the recipes
so that I can correct mistakes.
Description
Entries on the detail page should be editable.
AC

[ ] when clicking on edit (icon) the entries can be edited
[ ] there is a save-button that can be clicked to save the changes

Tasks

[ ] create new branch
[ ] create edit-function
[ ] integrate edit-icon and add logic to it
[ ] add save button

Complexity
small

You should consider if there should be a second button to come back if you decide not to make any changes :)

You should consider if there should be a second button to come back if you decide not to make any changes :)
it would be useful to include a wireframe here to better introduce yourself or for you to orientate yourself as to what is desired.
But all in all it looks good to me ❤


RNN=None causes error at line 171 in snli_rnn.py (Theano)

Verified on Mac OSX and Ubuntu. Running Keras 1.0.8 with Theano backend. RNN=recurrent.GRU works fine, but with RNN=None I get the following:
$ python snli_rnn.py
Using Theano backend.
82
62
59
55
57
30
RNN / Embed / Sent = None, 300, 300
GloVe / Trainable Word Embeddings = True, False
Build model...
Vocab size = 42391
Loading GloVe
Total number of null word embeddings:
4043
Traceback (most recent call last):
File "snli_rnn.py", line 171, in
prem = BatchNormalization()(prem)
File "/Users/bradleyallen/anaconda/envs/dlnotebook/lib/python2.7/site-packages/Keras-1.0.8-py2.7.egg/keras/engine/topology.py", line 494, in call
self.assert_input_compatibility(x)
File "/Users/bradleyallen/anaconda/envs/dlnotebook/lib/python2.7/site-packages/Keras-1.0.8-py2.7.egg/keras/engine/topology.py", line 411, in assert_input_compatibility
str(K.ndim(x)))
Exception: Input 0 is incompatible with layer batchnormalization_1: expected ndim=3, found ndim=2

Odd. I use the TensorFlow backend for Keras and whilst it shouldn't matter I was able to reproduce your exception using the Theano backend. Given that the actual RNNs (GRU / LSTM) work, this suggests the issues lies with:
SumEmbeddings = keras.layers.core.Lambda(lambda x: K.sum(x, axis=1))
Turns out that Theano requires output_shape be provided by the Lambda layer whilst TensorFlow can infer it.
I'd also note to try both backends. I may have a buggy setup but the Theano backend is far slower for the summation of word embeddings, which is strange given the relative simplicity.

Confirmed working now on my setup. Will try both backends as you suggest. Thanks so much for the quick turnaround; this example is very useful (to me at least) from a pedagogical point of view and would be great merged into Keras.

Just to follow up, FWIW I ran both Sum and GRU on my setup (AWS EC2 g2.2xlarge, Bitfusion Ubuntu 14 Theano AMI, Theano 0.8.2, TensorFlow 0.10.0rc0, Keras 1.0.8) using both backends. Results were:

Metric
sum(word vectors) using Theano
sum(word vectors) using TensorFlow
GRU using Theano
GRU using TensorFlow

average secs/epoch
86
47.5
547
442.5

test accuracy
0.8313
0.8243
0.8165
0.8118

... which is consistent with your observation, with the caveat that, due to an incompatibility between Keras 1.0.8 and the package structure of TensorFlow 0.7.1, I had to use the bleeding edge TensorFlow build (0.10.0rc0) in comparison with the current but older Theano 0.8.2 release.

Thanks for the follow up! I'd be curious where the slowdown comes from. For sum(word vectors) I could easily imagine that they way Keras's Lambda is implemented between backends is the difference. Also, +1 for the 83.1 test accuracy! I got some higher numbers like that for sum(word vectors) on a few runs but decided to report 82.4 as that was the consistent average over runs.


Styling: Assess borders and box shadows in visualizations

Related to the work in this issue, a border and a background color was added to the BirdsEyeView such that it matches the look of the VariableCoverageTable. During our Wednesday EDA developers meeting, I brought up whether or not we'd like the borders and box shadows to be consistent. It was decided that I'd create an issue so that we could bring it up during a UX/styling meeting.
The screenshot below shows the updated look via the work mentioned above. Notice how the PlotLegend and the visualization both have box shadows whereas the BirdsEyeView and VariableCoverageTable do not.

@chowington and i had an interesting case in the subset download modal table where having a gray background created some accessibility issues (see comment and other comment).
This made me realize that many parts of our tables when we have gray backgrounds do not pass accessibility rules. Even the variable coverage table has text that is technically inaccessible. To help alleviate these issues, i'd suggest we at least make the backgrounds of tables and plots white.
If we accept the above and make the backgrounds white, then we have (at least!) the options of no border, border, or drop shadow. I'm personally between the drop shadow and no border. The elevation suggests importance, but the birds eye and variable completeness table are of less importance than the main plot, which draws me towards the no border option. I also think putting both the birds eye and var coverage table within the same drop shadow box and giving that box a title ("Data completeness information"?) could be cool.

i think over slack we decided to go with the drop shadows version. Related issue #1286


Error: No active provider set. Please select a provider for this project.

Hello,
Struggling to get the latest (0.5.6) version to sync.
~/c/myproject % claudesync project create
Enter a title for your new project [myproject]:
Enter the project description [Project created with ClaudeSync]:
Enter the absolute path to your local project directory [/Users/raine/code/myproject]:
Pick the provider to use for this project (claude.ai) [claude.ai]:
Project 'myproject' (uuid: xxx) has been created successfully.

Project setup complete. You can now start syncing files with this project. URL: https://claude.ai/project/xxx
~/c/myproject % claudesync push
Error: No active provider set. Please select a provider for this project.

Not sure why it complains about provider not being set when the claudesync project create command set the provider presumably.
Any ideas? Thanks.
Btw, README appears outdated. References the command claudesync project sync which no longer exists.

Please create a bug report and fill out the entire form.

same issue in the latest version of claudesync. It just appears when we are trying to sync a files for a project. I ran claudesync push after selecting organization and project.
@jahwag Maybe the docs are outdated, could you please check if you have time? We will fill out a proper bug report later.


Clean source

What type of PR is this?

What this PR does / why we need it:
Which issue(s) this PR fixes:

Fixes #

@quyenhoang96 please do not submit PR like this too much.

@quyenhoang96 please do not submit PR like this too much.
Sorry, I'll pay attention.


slashes in admin token username shows wrong username

Due to the simplistic parsing of username from the subject of the JWT token, it will display the username incorrectly in vault read /artifactory/config/admin if the username has a forward slash (/) in it. This does not affect anything, but should probably be fixed. I ran into this when I was using ${VAULT_NAMESPACE}-vault-admin for a "learning-center/tommy-mcneely" namespace, and I got "tommy-mcneely" as the username.
NOTE: The Artifactory Tokens UI also shows the same bug.

fixed with #78


Use Docker-based Travis CI tests for multi-platform support

I realised that we probably can't integrate these for a while due to stuff like https://github.com/geerlingguy/ansible-role-php-xhprof/issues/8, but I thought I'd send it over for some brainstorming.

I came up with at least a temporary solution for moving the drush_makefile to the VM before running it, instead of relying on it being a vagrant environment. If https://github.com/geerlingguy/drupal-vm/pull/378 gets merged, we should pass the host_project_root var to ansible and use that instead. This issue was identified earlier in #84.
Also re-arranged the order of how drush files are generated so if run locally at least the local alias will be kept instead of overridden by an invalid remote alias.
Besides that I added some basic sanity checks to see that some of the stuff in the example.config.yml works out of the box. If we can get travis provisioned correctly, maybe we should create a tests/ directory and move the tests there instead (so you could also run them locally). One rather nice test framework that could fit is bats. I've used it on a couple of projects before.

If you don't think we can run the entire playbook on travis (maybe just the test duration is too annoying already), I can cherry pick the other commits to separate PRs if you want. I guess even without the added tests, this would be a good step forward to solving #84.

@oxyc - I'm currently running every individual role in Travis (it's an Ubuntu 12.04 environment by default), and that works well enough.
I definitely would like to add a 'tests' directory in the root, and put in whatever extra testing stuff we need there.
My super-amazing-moonshot-endgoal would be to set up tests like: https://github.com/geerlingguy/ansible-role-apache/blob/master/.travis.yml
It would bootstrap one Docker environment for each of the supported OSes, and inside those Docker environments, run playbook.yml. We can't test Vagrant inside Travis' infrastructure, but we can test all the Ansible bits, and treat Docker as an additional destination besides Vagrant VMs.

The docker setup you have for the apache role is pretty impressive for sure. You said you were ironing out some kinks still?
Even if the individual roles have tests, I feel the project could benefit from some integration tests to catch regressions. The tests added in this commit would have caught https://github.com/geerlingguy/drupal-vm/pull/411 for example. Would also verify that drush aliases work. Probably a few other slightly fragile pieces that we could test.

Adminer test passes on travis already!
Any idea what causes the failing test, something travis specific?
TASK: [Ensure MySQL AppArmor profile is disabled (for slow query log).] *******
failed: [localhost] => {"failed": true, "path": "/etc/apparmor.d/disable/usr.sbin.mysqld", "state": "absent"}
msg: Error while linking: [Errno 2] No such file or directory

@oxyc - This is the main reason I'd like to isolate inside Docker—these kinds of errors pop up all the time because Travis does some insane stuff to their environments. Not to mention they have about a jillion different things installed that break every preconceived notion you can make about a default Ubuntu 12.04 install :)
And yes, I have some kinks to work out for my Ansible roles, but if we can lift what's there for Drupal VM, I have a feeling it'll be very helpful here, and since this use case is different than my individual roles, I wouldn't wait until I work out the rest of the kinks to use the same setup.

Even if the individual roles have tests, I feel the project could still benefit from some integration tests to catch regressions.

Yes, 100%—I think I was a little unclear in my post. I would really like some Drupal VM integration tests! Can't get perfect, since I don't have a spare Mac and Windows laptop laying around to do end-to-end testing with Vagrant... but we can get pretty close by testing all the Ansible bits inside Docker containers.

Ah makes sense. Okay will mostly hold off on this then. Now I'm just curious to see how far it can go before bailing so I might push a few changes.

@oxyc - Sounds good—it's Travis' infrastructure, so feel free to hit it hard with more tests :)

Well that was surprising, just ignoring one error and it passes.

Some subtasks related to this:

To get CentOS 7 working we either need to A) provide a secondary playbook (difficult to maintain) B) Fix upstream ansible-role-mysql to set the default required packages for mariadb https://github.com/geerlingguy/ansible-role-mysql/issues/55.
Figure out how to get upstart or even systemd working on Ubuntu 12.04 and 14.04 https://github.com/geerlingguy/ansible-role-mysql/pull/84#issuecomment-179952919

Aha https://github.com/geerlingguy/drupal-vm/issues/346#issuecomment-171869866! That explains why my CentOS6 build kept failing!
So I modified the test so nginx is tested on CentOS 6 as apache doesn't work out of the box anyways.
So with this we're testing:

CentOS 7 with apache
CentOS 6 with nginx

Let's hope the tests pass :) @geerlingguy what do you think about my build_makefile change? Will probably cause a lot of invalid bug reports but it would also help solve #84.
Making sure the AppArmor disabled/ directory exist is something worth checking right? It failed on the ubuntu containers and I noticed I usually verified conf-directory existence in other roles.

If this passes, I think the only change I'd request for now is to update the path for the makefile to include the ../../

Fixed the path, it's definitely better that way.
An earlier build already passed :) https://travis-ci.org/geerlingguy/drupal-vm/jobs/107331207

@oxyc - So is the only holdup to getting ubuntu12/14 tests going the mysql tests? I'd like to focus on getting those fixed asap so we can unblock a whole chain of different tests and make this the most automatedly-tested awesome project ever :)

Currently that's what's failing yes. And any other role that relies on upstart

Builds are pretty slow though hehe. Wonder why it's specifically CentOS 6 every time. And more specifically: Ensure PHP packages are installed.

I wonder if the 6.x PHP repos are just really slow or something :/

@oxyc - I'm going to merge this now, just because it gives a heck of a lot better coverage than we're currently providing. We will continue to work on the Ubuntu support for MySQL and here, thanks so much for the help on the geerlingguy.security role and for this. This is awesome. Mind-blowingly awesome!

Hmmm https://travis-ci.org/geerlingguy/drupal-vm/builds/108702338

So seems it's just unstable. The tests for https://github.com/geerlingguy/drupal-vm/pull/404 passed.

@oxyc - That earlier build was due to a mailhog test gone bad; I updated a path in the upstream daemonize role, but forgot to update the default in mailhog as well.

@oxyc @geerlingguy
Hi. I also get trapped in this problem on Travis this week and found that docker run -d --privileged /sbin/init makes CPU 100% and lead to death. You should use such like docker run -d -it /bin/bash instead.
https://bugzilla.redhat.com/show_bug.cgi?id=1046469

lead to death

Welcome back from the dead then! 😄
Thanks for posting this tidbit.


GHC final milestone : Create a database based on a diagram

Hello reviewer(s) :wave: :wave:
:sunglasses: This is @steveWDamesJr 's and @Nemwel-Boniface 's team. :sunglasses:
In this milestone we were able to:

[x] Work on remote pair programming to accomplish this milestone
[x] Create a file named schema_based_on_diagram.sql where we included the implementation of the database from the new ERD we created
[x] Join tables from many-to-many relationships that did not appear in the diagram. (prescribed_treatments table)
[x] Create indexes for our tables
[x] Document our project by updating the README.md file
[x] Include the schema of the database that we created which included the JOIN table

Thank you for taking the time to review our project :pray:

Thank you @mikethreels . We'll make the change and update it.