Is there any solution to restore 'Control Panel'?

I set Files UWP as my default by using old method. Editing Registry Editor 'Computer\HKEY_LOCAL_MACHINE\SOFTWARE\Classes\Folder\shell\open\command'.
And I noticed that my control panel won't work.
I changed the (Default)'s Value data to  %LOCALAPPDATA%\Microsoft\WindowsApps\files.exe -Directory %1
and deleted DelegateExecute Key.
Can I restore Control Panel by changing the value data to it's default?
If that is possible can I get default key value?
Stupidly, I didn't backed up my registry editor before changing the values...

@XPoppyX Thank you so much! Control Panel got back...

@XPoppyX Thank you so much! Control Panel got back...


use sync.Once instead of chan

sync.Once is more clear and faster than chan.

"import sorting" is a completely incorrect comment


Rollout scorer using MI to access azure storage table

https://github.com/dotnet/dnceng/issues/2867
https://dev.azure.com/dnceng/internal/_workitems/edit/6811
We already have a MI installed on the azure function that is used around the code, so I took advantage of that.
Created ScorecardEntity : ITableEntity because I need to update to ITableEntity, the model lives in other repo: https://github.com/dotnet/dnceng-shared/blob/77fb751f40c92262450af10314e965a1a708857b/src/Microsoft.DotNet.Services.Utility/AzureStorageTableEntities.cs#L44
but is not used in any other place, so it doesn't need to be in other place, I will triple check this and remove the model for the other repository

There's also RolloutScorerFunction, which has some SAS uri usage


Use codecov api for coverage

Add 1 decimal to both codecov and coveralls.

I don’t know what you think about the 1 decimal, but it will explain the difference in color between these too:

This also fixes an issue where the default branch is not master.
https://codecov.io/api/bb/ignitionrobotics/ign-math/branch/master
vs
https://codecov.io/api/bb/ignitionrobotics/ign-math (default branch is default)

Great! Thanks @tusbar


SSH handler

Description of the new feature/enhancement
I'd like to do something like
WinR wt<EMAIL_ADDRESS>Enter
and it will start up or open an new tab in an existing Windows Terminal that will perform an SSH connection.

Proposed technical implementation details (optional)

Note this request is NOT to embed SSH itself to Windows Terminal, but provide some sort of generic handler for command lines with a username@host pattern along with ://@:/ pattern the protocol and ports should be defaultable (in my case if I had the configuration I would default to ssh since I generally work with that.
I was thinking it will be a profile that if not hidden will ask for a URL if selected and the "command" allows for extra fields that would be used to pass in the components
{
    "defaultUriProtocol": "ssh",

    "defaultUriProtocolHandlers":
    {
       "ssh": "{00000000-0000-0000-ba54-000000000001}"
    },

    "profiles":
    [

        {
            "guid": "{00000000-0000-0000-ba54-000000000001}",
            "commandline" : "%UserProfile%/scoop/apps/git/current/usr/bin/ssh.exe -p ${uri.port}<EMAIL_ADDRESS>            "startingDirectory": "%UserProfile%",
            "background": "#000000",
            "fontFace": "Source Code Pro",
            "icon" : "c:\\opt\\icons8-console-96.png",
            "backgroundImage": "C:\\Users\\trajano\\OneDrive\\app-background\\terminal.png",
            "backgroundImageOpacity": 0.1,
            "name" : "SSH",
            "handlesUriProtocol" : "ssh"
        },

Note I used uri. to prefix it so we don't pollute the default namespace.

I mean it seems a lot easier to just do win+rwt ssh<EMAIL_ADDRESS>then hook all that up, right?

@zadjii-msft except it seems less seamless
If Terminal had this capability then it can probably register itself as a protocol handler for Windows as well so if we click on a link that looks like<EMAIL_ADDRESS>it will start up terminal

I created a small launcher script and protocol registry entries to do exactly this.
https://github.com/vbyrd/windows-terminal-ssh-protocol-handler

Thanks @vbyrd! Yeah -- in general, I think this is something the community is better-equipped to handle than us. Registering a protocol handler, especially by default like that, is something that I'd like the user to explicitly opt into.
At the same time, I'm not liable to put too many ssh-specific features into Terminal itself. If anything, it would be part of the extension that /dup #1280 turns into.


[Question] Post-processing

Hi @mibaumgartner, I'm running experiments to compare nnDetection with the original nnUNet. I've analyzed nnDetection predictions against the volumetric ROIs generated based on nnUNet segmentations and I have some questions. There is a huge discrepancy between the smallest object detected by nnUNet and nnDetection - do you perform any type of post-processing? Do you remove the smallest blobs?
I've calculated blob-based statistics for both sets of results and the smallest blob found by nnDetection is 18mm3, smallest blob found by nnUNet is 0.12mm3 (it's probably a single voxel), so the difference is significant. Maybe it's a result of resampling of predicted bounding boxes/resolution of data? Also we already talked about the bounding box indices in other issue, so may it's related as well. Do you have any advise?

Yes, nnDetection performs some postprocessing to discard very small predictions, the exact threshold is determined during the post-processing sweep and can be found in the plan_inference.pkl file in the training folder. A similar post-processing sweep for parameters (including a minimal size) was also performed for the nnU-Net predictions in our paper.

It looks like the post-processing is the major culprit here. Unfortunately 25% of lesion instances in our dataset are smaller than 10mm3. I don't see an easy way to disable all postprocessing from the command-line though. Is there a workaround for predict.py, e.g., by overriding some steps using "-o" parameter? What would you advise?
I've analyzed the inference_plan.pkl and for the "inference_plan" label there is "remove_small_boxes": 3.0. If it's in mm3, it's suprising that the smallest predicted bounding box is 18mm3. I would still expect some boxes between 3mm3 and 18mm3, but I guess it's a starting point for further investigation.

print(pkl["postprocessing"])
{}

print(pkl["inference_plan"])
{'model_iou': 1e-05, 'model_nms_fn': <function batched_weighted_nms_model at 0x14bb5ddc6af0>, 'model_score_thresh': 0.0, 'model_topk': 1000, 'model_detections_per_image': 100, 'ensemble_iou': 0.30000000000000004, 'ensemble_nms_fn': <function batched_wbc_ensemble at 0x14bb5d1b5790>, 'ensemble_topk': 1000, 'remove_small_boxes': 3.0, 'ensemble_score_thresh': 0.0}

I think setting remove_small_boxes=0 would be a great starting point.
The value is currently performed in pixel space (which is probably suboptimal), meaning that the minimal size of boxes in pixel space needs to be 3 -> given the nnDetection convention, this results in the smallest predictable object size of 2x2x2 pixels which might result in the 18mm3?

Thanks for your detailed update, I'll give it another thought as well and try to build a replica with a toy dataset with tiny objects.
The filtering is only applied during the post-processing of the detections, no filtering is done of the ground truth labels or during pre-processing.
The parameter sweep simply tries a set of different parameters on the validation set and selects the best value (in Terms of the AP metric) for test-set inference. So, it is interesting that it looks like removing the small predictions seems to benefit the AP value.
One thing I was wondering about: Are there many objects which have a size of one pixel? This might become a problem during resampling, both during preprocessing and online data augmentation, where single pixel objects can get lost. While nnU-Net might tolerate this behaviour (since during its loss computation only a single pixel is missing) it has quite a large influence on nnDetection where an entire object is missing.

Thanks @mibaumgartner, it would be great to double-check the sweeping.
Great point about the resampling, I'm gonna check which blobs were removed during that step. Now I recall that I've seen the warnings about the lost instances in the logs.
From my side I'm going to look closely at the bounding box removal in the code. I suspect that I disabled the post-processing, but the 2^3 boxes were removed anyway. All statistics I've generated are volume-based, I will regenerate them into voxel-based metrics to track the nnDetection thresholds easier. Thanks!

I stumbled upon the following pre-processing step:

It looks like something that will affects the training, the results are as follows:
2023-02-15 13:58:54.993 | INFO     | nndet.planning.architecture.boxes.c002:_plan_anchors:258 - Filtered 46 boxes, 1805 boxes remaining for anchor planning.
It's especially tricky for us since we are aware that we have outliers in the dataset, but we made sure to distribute them evenly between training set and test set. Do you remember why such a step? Was it just a precaution?

The function is only used to determine the anchors of the network (i.e. the "templates" which are regressed and classified). Since we want the anchors to ignore outliers we filter them before running the planning. The network is still trained on all the data/objects irrespective of that function, so it should still be able to detect all objects, irrespective of their size.

Ok, thanks for the explanation. I think I understand now what going on with our predictions. The nnDetection calculated the following anchors:
nndet.planning.architecture.boxes.c002:_plan_anchors:272 - Determined Anchors: {'width': [3.0, 2.0, 5.0], 'height': [3.0, 2.0, 5.0], 'depth': [2.0, 3.0, 5.0]}; Results in params: {'width': [(3.0, 2.0, 5.0), (6.0, 4.0, 10.0), (12.0, 8.0, 20.0), (12.0, 8.0, 20.0)], 'height': [(3.0, 2.0, 5.0), (6.0, 4.0, 10.0), (12.0, 8.0, 20.0), (24.0, 16.0, 40.0)], 'depth': [(2.0, 3.0, 5.0), (4.0, 6.0, 10.0), (8.0, 12.0, 20.0), (8.0, 12.0, 20.0)]}
The target spacing is:
nndet.planning.experiment.base:plan_base:166 - Base target spacing is [1.        0.9765625 1.       ]
As I understand correctly the smallest bounding boxes may be of size 12mm3 and 18mm3 in this case? That's concise with our results. I did a mistake of comparing template-based bounding boxes of nnDetection with boxes generated artificially from segmentation masks.

I've analyzed my issue further and it looks like nnDetection does predict a lot of bounding boxes that are much smaller than the smallest anchors (initially I though that this was an issue), but almost all of them are false positives with really low prediction scores. From what I've observed the automatic post-processing step has had only positive impact on the our results.
There might be some areas in nnDetection architecture to fine-tune this, but I'm afraid that smaller blobs are simply under-represented in our dataset in comparison to the big ones (maybe the quantities are similar, but the overall appearances differ a lot) and they are the main issue.
@mibaumgartner I think you may close this issue. Thank you for your time..

Hi @machur ,
thank you for the detailed update! Indeed, nnDetection performs a regression of the anchors and thus it can predict arbitrary sized bounding boxes, they are only intended as an initial "template". While nnDetection also performs some balancing on object level, it is really hard to counteract inbalances, especially if "object difficulty" plays an additional role (I would assume that single pixel objects are really difficult to detect anyway). Potentially, adjusting the sampling of the dataloader to prefer smaller objects might be one way to counteract this even more.
Best,
Michael


Package project using the build module

This is the proper way to package as using setup.py directly is depreciated.

That was fixed by df15a0dff8af2d6ec242c4646b788c39f325b177.


DO NOT MERGE: bisecting for fetch failed errors

This is a branch I'm using to run CI to bisect our PR merge commits to find where the fetch failures started

PR 1503 does not seen to have this error. the Error is probably between the merge of 1503 and 1505

nevermind--rerunning PR 1503 merge reveals the fetch errors

1497 does not seem to have this specific fetch error after re-running host tests twice

1496 has the failed fetch message

1500 has the failed message

re-running 1497, as otherwise it seems the issue started to appear in 1500

actually the 3rd time running 1497 reveals the fetch error--going back farther in time...

done with investigation


Disable Add button after clicking submitting changes [PLAT-1320]

Purpose
We've been seeing DB deadlocks happening due to the v1 contributor endpoint.  While we're not sure of the root of issue, we can probably prevent mitigate it by preventing clickmashing on the add contrib modal.
Changes

Disable the "Add" button after adding contributors in the add contributor modal
Use the canSubmit KO variable

QA Notes

Start on the "Contributors" page of a node
Click the "+Add" button
Search for some new contributors
Choose a contributor to add
Click the "Add" button

Documentation
Frontend, none needed

Side Effects
None anticipated

Ticket
https://openscience.atlassian.net/browse/PLAT-1320

replaced by https://github.com/CenterForOpenScience/osf.io/pull/8995


[feature] update configuration and version

:tada: This PR is included in version 1.0.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Many Various changes and improvements

added "with" after verbs (e.g. attack with)
added "read" as verb
fixed minor bugs (which might have been already fixed by Aidan)
Pull request for BRANCH NAME
This fixes issue: #ISSUE
NOTES ABOUT CHANGES

do NOT TRUST he is missing a bunch of brackets because of trashy formatting
I am helping just wait before merging


Failed to fetch ........... Hash Sum mismatch

Environment

OS: Windows 10
Docker Version: <IP_ADDRESS> Stable Desktop Community
Docker Compose Version: 1.24.1

Dockerfile
FROM postgres:11

COPY ./99fixbadproxy /etc/apt/apt.conf.d/99fixbadproxy

RUN apt-get -y update \
  && apt-get install -y \
    build-essential \
    python3-dev \
    python-gdal \
    libxml2 \
    libgeos-dev \
    libproj12 \
    postgresql-server-dev-11 \
    postgresql-11-postgis-2.5 \
    postgresql-11-postgis-scripts \
  && apt-get clean \
  && rm -rf /var/lib/apt/lists/*

ADD ./init /docker-entrypoint-initdb.d/

99fixbadproxy
Acquire::http::Pipeline-Depth 0;
Acquire::http::No-Cache true;
Acquire::BrokenProxy    true;

Docker commands that I executed
docker-compose build db
Actual result
Building db
Step 1/4 : FROM postgres:11
 ---> e2d75d1c1264
Step 2/4 : COPY ./99fixbadproxy /etc/apt/apt.conf.d/99fixbadproxy
 ---> Using cache
 ---> 5448c38eae1c
Step 3/4 : RUN apt-get -y update   && apt-get install -y     build-essential     python3-dev     python-gdal     libxml2     libgeos-dev     libproj12     postgresql-server-dev-11     postgresql-11-postgis-2.5     postgresql-11-postgis-scripts   && apt-get clean   && rm -rf /var/lib/apt/lists/*
 ---> Running in d930ce46b46e
Ign:1 http://deb.debian.org/debian stretch InRelease
Get:2 http://apt.postgresql.org/pub/repos/apt stretch-pgdg InRelease [51.4 kB]
Get:3 http://security.debian.org/debian-security stretch/updates InRelease [94.3 kB]
Get:4 http://deb.debian.org/debian stretch-updates InRelease [91.0 kB]
Get:5 http://deb.debian.org/debian stretch Release [118 kB]
Get:6 http://apt.postgresql.org/pub/repos/apt stretch-pgdg/main amd64 Packages [184 kB]
Get:7 http://deb.debian.org/debian stretch-updates/main amd64 Packages [27.4 kB]
Get:8 http://deb.debian.org/debian stretch Release.gpg [2,365 B]
Get:9 http://deb.debian.org/debian stretch/main amd64 Packages [7,086 kB]
Get:10 http://security.debian.org/debian-security stretch/updates/main amd64 Packages [497 kB]
Err:10 http://security.debian.org/debian-security stretch/updates/main amd64 Packages
  Hash Sum mismatch
  Hashes of expected file:
   - Filesize:497208 [weak]
   - SHA256:2c51a7b9197719053220fc1d4c38453a48582d0190953481c0cd9620b8844a00
   - SHA1:6599fb50a02b4f3abe280b0bbfd42ba6227ae7d4 [weak]
   - MD5Sum:23a00a02efd96accdf62f7e6d27ee44b [weak]
  Hashes of received file:
   - SHA256:e8bb756eb3dae9f84b1ff2623bc3ff058e02775f60082cf1583ef789214a4a53
   - SHA1:b8fa8ff140603cb7b64f8f214957f35d1f85b987 [weak]
   - MD5Sum:fbb52af7168bde493aa4d9e6b65c6e34 [weak]
   - Filesize:497208 [weak]
  Last modification reported: Wed, 25 Sep 2019 06:37:02 +0000
  Release file created at: Thu, 26 Sep 2019 04:11:51 +0000
Fetched 8,151 kB in 7s (1,106 kB/s)
Reading package lists...
E: Failed to fetch http://security.debian.org/debian-security/dists/stretch/updates/main/binary-amd64/by-hash/SHA256/2c51a7b9197719053220fc1d4c38453a48582d0190953481c0cd9620b8844a00  Hash Sum mismatch
   Hashes of expected file:
    - Filesize:497208 [weak]
    - SHA256:2c51a7b9197719053220fc1d4c38453a48582d0190953481c0cd9620b8844a00
    - SHA1:6599fb50a02b4f3abe280b0bbfd42ba6227ae7d4 [weak]
    - MD5Sum:23a00a02efd96accdf62f7e6d27ee44b [weak]
   Hashes of received file:
    - SHA256:e8bb756eb3dae9f84b1ff2623bc3ff058e02775f60082cf1583ef789214a4a53
    - SHA1:b8fa8ff140603cb7b64f8f214957f35d1f85b987 [weak]
    - MD5Sum:fbb52af7168bde493aa4d9e6b65c6e34 [weak]
    - Filesize:497208 [weak]
   Last modification reported: Wed, 25 Sep 2019 06:37:02 +0000
   Release file created at: Thu, 26 Sep 2019 04:11:51 +0000
E: Some index files failed to download. They have been ignored, or old ones used instead.
ERROR: Service 'db' failed to build: The command '/bin/sh -c apt-get -y update   && apt-get install -y     build-essential     python3-dev     python-gdal     libxml2     libgeos-dev     libproj12     postgresql-server-dev-11     postgresql-11-postgis-2.5     postgresql-11-postgis-scripts
&& apt-get clean   && rm -rf /var/lib/apt/lists/*' returned a non-zero code: 100

Expected outcome
Successfully built

This image perfectly work fine in any distro of Linux, I have tested in Ubuntu, Debian, Arch Linux. And I didn't even included Step 2.
I added step 2 according to following link but unfortunately it didn't work for me.
https://github.com/jenkinsci/docker/issues/543
Output of docker version
Client: Docker Engine - Community
Version:           19.03.2
API version:       1.40
Go version:        go1.12.8
Git commit:        6a30dfc
Built:             Thu Aug 29 05:26:49 2019
OS/Arch:           windows/amd64
Experimental:      false
Server: Docker Engine - Community
Engine:
Version:          19.03.2
API version:      1.40 (minimum version 1.12)
Go version:       go1.12.8
Git commit:       6a30dfc
Built:            Thu Aug 29 05:32:21 2019
OS/Arch:          linux/amd64
Experimental:     false
containerd:
Version:          v1.2.6
GitCommit:        894b81a4b802e4eb2a91d1ce216b8817763c29fb
runc:
Version:          1.0.0-rc8
GitCommit:        425e105d5a03fabd737a126ad93d62a9eeede87f
docker-init:
Version:          0.18.0
GitCommit:        fec3683
Other relevant information

I tried both automatic and fixed DNS Server settings.
I tried exposing daemon on tcp without TLS checked and unchecked, thinking could be the issue of networking.
My proxies is disabled.
I tried with other debian based image and added apt-get update line. However, it doesn't seem s to work anywhere.

Please close this issue.  It is unrelated to Jenkins and unrelated to the Jenkins docker image.

agreed

Oh no I submitted in wrong repo. Sorry to bother you guys.


@docs macros to fix makedocs

Try to fix CI documentation check.

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (1b236ff) 74.00% compared to head (2ed609c) 73.46%.
Report is 2 commits behind head on main.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@            Coverage Diff             @@
##             main       #5      +/-   ##
==========================================
- Coverage   74.00%   73.46%   -0.54%
==========================================
  Files           4        3       -1
  Lines          50       49       -1
==========================================
- Hits           37       36       -1
  Misses         13       13

Files
Coverage Δ

src/functions.jl
100.00% <ø> (ø)

src/methods.jl
92.59% <ø> (ø)

src/structs.jl
45.00% <ø> (ø)

... and 1 file with indirect coverage changes

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Upgrade Keycloak to 16.1.X

A new version of Keycloak was released last week which fix a critical vulnerability in 12.X-15.X versions. This change updates the keycloak dependencies to 16.1.X.

Thanks for the contribution!


Updated french translations

Some french translations don't even make sense. Crop has been translated as in a field crop. Usually prefer to use English than a bad French translation

merged, thx!


Control Plane deployment crash with no access to Key Vault

Describe the bug
Region prep script is crashing with following errors:
odule.sap_deployer.azurerm_key_vault.kv_user[0]: Still creating... [40s elapsed]
module.sap_deployer.azurerm_key_vault.kv_user[0]: Still creating... [50s elapsed]
module.sap_deployer.azurerm_key_vault.kv_user[0]: Still creating... [1m0s elapsed]
module.sap_deployer.azurerm_key_vault.kv_user[0]: Still creating... [1m10s elapsed]
module.sap_deployer.azurerm_key_vault.kv_user[0]: Still creating... [1m20s elapsed]
module.sap_deployer.azurerm_key_vault.kv_user[0]: Still creating... [1m30s elapsed]
module.sap_deployer.azurerm_key_vault.kv_user[0]: Still creating... [1m40s elapsed]
module.sap_deployer.azurerm_key_vault.kv_user[0]: Still creating... [1m50s elapsed]
module.sap_deployer.azurerm_key_vault.kv_user[0]: Still creating... [2m0s elapsed]
module.sap_deployer.azurerm_key_vault.kv_user[0]: Still creating... [2m10s elapsed]
module.sap_deployer.azurerm_key_vault.kv_user[0]: Creation complete after 2m11s [id=/subscriptions/1d032958-7678-44b8-82ad-3cd6fdb1f9a9/resourceGroups/SAP-AFCP-TEST/providers/Microsoft.KeyVault/vaults/MGMTWEEUDEP00user1A2]
module.sap_deployer.azurerm_key_vault_access_policy.kv_user_msi[0]: Creating...
module.sap_deployer.azurerm_key_vault_access_policy.kv_user_pre_deployer[0]: Creating...
module.sap_deployer.azurerm_key_vault_access_policy.kv_user_pre_deployer[0]: Creation complete after 9s [id=/subscriptions/1d032958-7678-44b8-82ad-3cd6fdb1f9a9/resourceGroups/SAP-AFCP-TEST/providers/Microsoft.KeyVault/vaults/MGMTWEEUDEP00user1A2/objectId/70000000-0000-0000-0000-000000000000]
module.sap_deployer.azurerm_key_vault_access_policy.kv_user_msi[0]: Still creating... [10s elapsed]
module.sap_deployer.azurerm_key_vault_access_policy.kv_user_msi[0]: Creation complete after 17s [id=/subscriptions/1d032958-7678-44b8-82ad-3cd6fdb1f9a9/resourceGroups/SAP-AFCP-TEST/providers/Microsoft.KeyVault/vaults/MGMTWEEUDEP00user1A2/objectId/c9e19a85-c394-4fc4-965d-eabfe715ae62]
module.sap_deployer.azurerm_key_vault_secret.username[0]: Creating...
module.sap_deployer.azurerm_key_vault_secret.pk[0]: Creating...
module.sap_deployer.azurerm_key_vault_secret.ppk[0]: Creating...
╷
│ Error: checking for presence of existing Secret "SAP-AFCP-TEST-sshkey" (Key Vault "https://mgmtweeudep00user1a2.vault.azure.net/"): keyvault.BaseClient#GetSecret: Failure responding to request: StatusCode=403 -- Original Error:autorest/azure: Service returned an error. Status=403 Code="Forbidden" Message="The user, group or application 'appid=b677c290-cf4b-4a8e-a60e-91ba650a4abe;oid=ea425602-a18d-4912-9375-78ee23dc2bac;numgroups=1;iss=https://sts.windows.net/1f6c67d4-7e4c-4119-8ad9-435710ee4b29/' does not have secrets get permission on key vault 'MGMTWEEUDEP00user1A2;location=westeurope'. For help resolving this issue, please see https://go.microsoft.com/fwlink/?linkid=2125287"InnerError={"code":"AccessDenied"}
│
│   with module.sap_deployer.azurerm_key_vault_secret.ppk[0],
│   on ../../terraform-units/modules/sap_deployer/key_vault.tf line 168, in resource "azurerm_key_vault_secret" "ppk":
│  168: resource "azurerm_key_vault_secret" "ppk" {
│
╵
╷
│ Error: checking for presence of existing Secret "SAP-AFCP-TEST-sshkey-pub" (Key Vault "https://mgmtweeudep00user1a2.vault.azure.net/"): keyvault.BaseClient#GetSecret: Failure responding to request: StatusCode=403 -- Original Error: autorest/azure: Service returned an error. Status=403 Code="Forbidden" Message="The user, group or application 'appid=b677c290-cf4b-4a8e-a60e-91ba650a4abe;oid=ea425602-a18d-4912-9375-78ee23dc2bac;numgroups=1;iss=https://sts.windows.net/1f6c67d4-7e4c-4119-8ad9-435710ee4b29/' does not have secrets get permission on key vault 'MGMTWEEUDEP00user1A2;location=westeurope'. For help resolving this issue, please see https://go.microsoft.com/fwlink/?linkid=2125287" InnerError={"code":"AccessDenied"}
│
│   with module.sap_deployer.azurerm_key_vault_secret.pk[0],
│   on ../../terraform-units/modules/sap_deployer/key_vault.tf line 179, in resource "azurerm_key_vault_secret" "pk":
│  179: resource "azurerm_key_vault_secret" "pk" {
│
╵
╷
│ Error: checking for presence of existing Secret "SAP-AFCP-TEST-username" (Key Vault "https://mgmtweeudep00user1a2.vault.azure.net/"): keyvault.BaseClient#GetSecret: Failure responding to request: StatusCode=403 -- Original Error: autorest/azure: Service returned an error. Status=403 Code="Forbidden" Message="The user, group or application 'appid=b677c290-cf4b-4a8e-a60e-91ba650a4abe;oid=ea425602-a18d-4912-9375-78ee23dc2bac;numgroups=1;iss=https://sts.windows.net/1f6c67d4-7e4c-4119-8ad9-435710ee4b29/' does not have secrets get permission on key vault 'MGMTWEEUDEP00user1A2;location=westeurope'. For help resolving this issue, please see https://go.microsoft.com/fwlink/?linkid=2125287" InnerError={"code":"AccessDenied"}
│
│   with module.sap_deployer.azurerm_key_vault_secret.username[0],
│   on ../../terraform-units/modules/sap_deployer/key_vault.tf line 190, in resource "azurerm_key_vault_secret" "username":
│  190: resource "azurerm_key_vault_secret" "username" {
│
╵
To reproduce
Steps to reproduce the behavior:
just run hands-on lab commands as on https://docs.microsoft.com/en-us/azure/virtual-machines/workloads/sap/automation-tutorial - Deploy control plane, step 1's script
Expected behavior
Deploy region as expected
Additional context
Tested on 3 different environments/6 regions with same error
error says that my user account has no permissions to have the access to KV but scripts is ran with SPN as parameter (should it be SPN app_id there?).

Hi, sorry to hear this.
Are you running this from Cloud shell?
Have you tried to run az logout and then az login so that you are logged on as you and not the cloudshell managed ID?

Yes, I tried to do troubleshooting as it is recommended in documentation - https://docs.microsoft.com/en-us/azure/virtual-machines/workloads/sap/automation-tutorial - "If you run into authentication issues, run az logout to log out and clear the token-cache, then run az login to reauthenticate."
What account have I to use for that az login? It is not clear in documentation what credentials have to be used.

Has this been resolved?
On initial Control Plane Deployment from the Cloud Shell the credentials that are used are your own credentials, and you must have "Contributor with Authorization or Owner" RBAC for the subscription.

Still getting the error, having tried with two different accounts/tenancies/subscriptions. Running from CloudShell and owner role in both cases.

@jkirkmannz : Thanks for the tip, worked for me

@iwalker2000  - I see this issue is resolved, I am closing this issue.


URLConfig in peak_s1_position_cnn.py

straxen.URLConfig is not working properly in peak_s1_position_cnn.py https://github.com/XENONnT/straxen/blob/9e8126e67554575c66d89322e33c8354df88fc3d/straxen/plugins/peaks/peak_s1_position_cnn.py#L19 can be seen running https://github.com/XENONnT/analysiscode/blob/master/s1_pos_rec/test_s1_cnn_peak_level.py. Instead uncommenting the line https://github.com/XENONnT/straxen/blob/9e8126e67554575c66d89322e33c8354df88fc3d/straxen/plugins/peaks/peak_s1_position_cnn.py#L18 commenting L19-L31 it should run.

Would you please demo the detailed error message? @matteoguida It is helpful to probe whether the error originates from different environments and also can help other people to get involved. : )

This was due to a bug in frame.
It is fixed in rframe version 0.2.8, xedocs version 0.2.16 uses the fixed version of rframe.


Swizzles for vector2, vector2i, vector3, and vector3i

Swizzles for Vector2, Vector2i, Vector3, and Vector3i
One case that this is useful is a top down 3D game that does not need the Y axis to be taken into consideration.
You can get and set arbitrary vec2 and vec3 components like so:
var character : Node3D = $Node
var location : Vector2 = character.position.xz
...
character.position.xz = location
Because these are properties, they can be accessed similarly by animations and tweens.

Bugsquad edit: Closes godotengine/godot-proposals#727.

See https://github.com/godotengine/godot-proposals/issues/727 and existing PRs: https://github.com/godotengine/godot/pull/55220 https://github.com/godotengine/godot/pull/51165 https://github.com/godotengine/godot/pull/39674

any reason for no Vector4? would be surprising to be able to do this on Vector3 but no Vector4, no?

any reason for no Vector4? would be surprising to be able to do this on Vector3 but no Vector4, no?

Vector4 will have more than 256 permutations of swizzle access. I didn't want to hand write that like I did for Vector3 at the moment. I'll make a quick code generator at some point to deal with that.
I don't want to flood the Vec4 docs with all that new information that doesn't need to be there. I'd like to see if there's a way to hide the massive amount of get_xxxx/set_xxxx functions and properties that will be added.

I think the swizzles should be handled in a more intrinsic nature where the document states that they are available without needing to list every single permutation of them.

I don't think that swizzling must be hard-coded as properties and flood the documentation with unnecessary members. I think this should be implemented as special processing on the GDScript side, like in shading language currently.

I agree, swizzling has little use on the c++ side IMO and the generation as macros makes it very hard to use and discover in c++ anyway, so if we're going to add this it should be handled internally and documented in the description of the classes instead

See godotengine/godot-proposals#727 and existing PRs: #55220 #51165 #39674
Note that this currently does not pass the CI checks. This needs to pass CI before it can be reviewed.

I fixed some formatting issues so it would pass CI checks. Should I wait for review before rebasing incase more changes need to be made?

I agree, swizzling has little use on the c++ side IMO and the generation as macros makes it very hard to use and discover in c++ anyway, so if we're going to add this it should be handled internally and documented in the description of the classes instead

This implementation is primarily for gdscript users. C++ users can still access the swizzles via the get/set_xxx() methods if need be.


Both user and admin landing pages can currently lead to either user form or dashboard

Make it specific:
user landing page -> user form
admin landing page -> dashboard
One way to do this is by using two Yoti apps...

Flow at the moment:
https://github.com/lucy-marko/centrepoint/blob/master/wireframes/app-flow.png


Cruft update

Failed deploy was due to incorrectly set up credential, I've changed it to cruft/update now:


Change default order of summary widgets and detail views on drug profile page

To prepare for the alpha release, can we please change the default order of the summary widgets and detail views on the drug profile page?

Indications
Mechanisms of Action
Known Drugs
Clinical Precedence
Bibliography

@LucaFumis can you please also look into this?

Ticket closed as work merged into alpha


No rabbitmq queues/exchanges are created with version 8.03 of masstransit

Is this a bug report?
Yes
Can you also reproduce the problem with the latest version?
Yes, version 8.03
Environment

Dotnet version: .Net 6.0
Operating system: Windows 10 Pro
IDE (Rider, VS Code, Visual Studio): Visual Studio

Steps to Reproduce

Delete an existing queue (in my case a durable SyncOs queue), via the management console port 15672.
Start your windows service with a package of  masstransit version 8.03
The queue which was removed is not recreated (same with the exchanges if you removed them too).
Rollback your package of masstansit to version 8.02 in the windows sevice
Start the windows service again
The queue is created again.

Expected Behavior
Create the queue when it is deleted.
Actual Behavior
8.03 - Not creating queue
8.02 - Creating the queue
WireUp code for masstransit/rabbitmq in the program file, where services is een IServiceCollection:
services.AddMassTransit(x =>
{
x.AddConsumersFromNamespaceContaining();
            x.UsingRabbitMq((context, cfg) =>
                   {
                       var configurationProvider = context.GetService<Library.Configuration.Shared.IConfigurationProvider>(); var receiveEndpointConfigurator = new ReceiveEndpointConfiguratorDecorator(new ReceiveEndpointConfigurator(configurationProvider), ep =>
                              {
                                  ep.Consumer<AcceptatieEventHandler>(context);
                                  ep.Consumer<MutatieCommandHandler>(context);
                              });
                       var busFactoryConfigurator = new BusFactoryConfigurator(configurationProvider, receiveEndpointConfigurator);

                       busFactoryConfigurator.ConfigureBusFactory(cfg);
                       cfg.UseDelayedMessageScheduler();
                   });
        });
        services.AddMassTransitHostedService();

Wow, that never popped my mind... but you're absolutely fabulously right, tnx a lot! Our library was still using 8.01, I am sorry that I didn't think of that my self :(


fix: hardening coordinated syncfl

Description
The current implementation of the coordinated syncfl has some corner cases.

Channel property for round is not specified; this causes the default selector to ignore ends (peers in the other end of channel) who join late.
There exists a synchronization issue; the coordinator returns peer information so that middle aggregators and trainers can talk to each other. However, the peer information may not be up to date yet because the actual joining process to the channel between middle aggregators and trainers are not completely.

These are handled in this change.
Type of Change

[x] Bug Fix
[ ] New Feature
[ ] Breaking Change
[ ] Refactor
[ ] Documentation
[ ] Other (please describe)

Checklist

[ ] I have read the contributing guidelines
[ ] Existing issues have been referenced (where applicable)
[ ] I have verified this change is not present in other open pull requests
[ ] Functionality is documented
[ ] All code style checks pass
[ ] New code contribution is covered by automated tests
[ ] All new and existing tests pass

Codecov Report

Merging #385 (1c384b3) into main (f6c291e) will not change coverage.
The diff coverage is n/a.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
@@           Coverage Diff           @@
##             main     #385   +/-   ##
=======================================
  Coverage   15.13%   15.13%
=======================================
  Files          48       48
  Lines        2775     2775
=======================================
  Hits          420      420
  Misses       2327     2327
  Partials       28       28

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


Align Isomorphous MTZs

Many space groups have degenerate choices of origins. Some have only a small number (ie 2) possible origins. Whereas others have a continuum of origins along one or more axis. These are called polar space groups. Given two isomorphous sets of structure factors with different origins, it is possible to align the resulting electron density maps by altering the phases to be consistent. It turns out this is equivalent to the image registration problem in computer vision which can be efficiently solved in fourier space (see: https://scikit-image.org/docs/stable/api/skimage.registration.html#skimage.registration.phase_cross_correlation). Other solutions to this problem rely on protein structures which is undesirable for some applications.
A detailed discussion of this is including some example implementations is in https://github.com/Hekstra-Lab/reciprocalspaceship/issues/31#issuecomment-1225061578. In the issue on rs, we decided this problem was out of scope for rs and should reside in rs-booster. The last two comments are the most relevant.
I think this project requires

an api level function which accepts two data sets and returns the optimal phase shifts to align them
a command line script that accepts a pair of mtzs along with column keys and outputs a translated version of one mtz

My question is whether anyone wants to tackle this? I'm looking at you,

@minhuanli
@apeck12
@dennisbrookner

Sounds like something I can do. Similar to the translational search in molecular replacement, but with a smaller searching space (discrete or continuum)?
I saw the discussion in the rs issue. The function find_equivalent_origins works for both polar and non-polar case?

Here's a template I had put together from before we identified that skimage.registration.phase_cross_correlation worked well: https://github.com/Hekstra-Lab/reciprocalspaceship/pull/174
I think the NonPolarTranslator case is pretty good for the brute force search of discrete cases, but the PolarTranslator should be changed to use the skimage rather than a global optimizer. Also, rs.utils.is_polar() can be used to determine which case to use.

Got it. I can think about the phase_cross_correlation(). And it would be great if you know some examples about that.
One question, by 64 possible discrete case you mean the following two lines in your PR before?
cases = np.array([0.0, 1.0 / 3.0, 0.5, 2.0 / 3.0])
t_cases = np.vstack(np.meshgrid(cases, cases, cases)).reshape((3, -1)).T

I feel the find_equivalent_origins function might not be useful for this case, but should also exist as a function in rs.utils, like the rs.utils.polar_axes.

yeah -- I recall finding some examples where the find_equivalent_origins did not match the ccp4 table.  It might be useful, but we didn't have a use case so we didn't figure out the right way to call it.
If have a 3D reciprocal grid of complex structure factors,  you can callphase_cross_correlation as:
phase_cross_correlation(complex1, complex2, space="fourier")[0]

you can then divide by your grid size to get the desired translation in fractional coordinates.


provide example of using update with promises.

Perhaps I'm not as smart as I'd like to be, so I'm not immediately groking how an update query using promises would look.
This is how I think it might work (since the callback based approach requires two dictionaries arguments before the callback :
...

Model
    .update user: token.user
    .with valid: false
    .then (model)->
        # get our boats and hoes and have a great time.

...

Or does the .update method still take a query and the fields:values dictionaries?

Model.update(...).then(...)
But also I can't read coffeescript (or whatever that is) so it's hard for me to know if that's right or wrong

Coffeescript is actually really simple: indentation matters, don't need to use braces, don't use semi-colons, functions are written as (parameter1, parameter2)->
Anyway, you didn't really answer the question:
When using promises, where does the update dictionary/object/hash/associative-array/thingthathasstuff go? in the update method? in another method afterwards (because find and findBlahLol  can use .where) ... ?

Well it's not as simple as Javascript, in that every web developer on the planet already knows Javascript. But anyway:
I don't really know what your question actually is. Your update parameters go in the update() call, per usual. Nothing about the waterline API changes, except you call .then() instead of done() or passing a callback. For general info about promises, read through the Bluebird docs (https://github.com/petkaantonov/bluebird/blob/master/API.md). (btw, with find() you can just put the where clause inside the find() arguments. you don't need a separate .where call. more on this in the sails.js docs)

Haha wow. you got up on the wrong side of the bed today... lol.
Well it's not as simple as Javascript
No. really it is actually. :)
... I don't really know what your question actually is. ...
Your reply says otherwise. :)
Hope you find something to make your day better because taking it out on other people won't do that.
:)

Ok you're done trolling here. I spent time trying to help you, but the real solution is for you to RTFM.

Model.update({ name: 'fido', age: 25 })
.then(function(model) {
   // handle code here
});


Use Builtin compile_unet of stable-fast

Hey, gameltb.
Thanks for the recent improvements of this plugin.
I have migrated the compile_unet function to be a builtin function of stable-fast.
It is better to use this to avoid hijacking too much, which might cause many backwards compatibility issues.
I tried to rewrite the model offloading logic, but don't know if it really works.
Other parts should work fine except that even if the user remove the loader after compiling,
it will still take effect. To make compiled TorchScript Graphs visible to the outside, I have add an attribute called _traced_modules in the return value of lazy_trace to expose it.
But I don't know how to integrate it with unet_function_wrapper and am still not sure if I do the right things. Maybe there could be other better solutions to avoid hijacking too much.

Hello, thank you for the PR.
I don't like the idea of changing the diffusion_model permanently, in some cases there are closures that will be passed in as arguments, and changing them permanently will result in an error, even if the user disables the node.
I'm still looking for a suitable way to manage resources and I think it's better for nodes to use function -> ScriptModule and ScriptModule -> CUDAGraph api and let it manage them on a case-by-case basis.

Hello, thank you for the PR.
I don't like the idea of changing the diffusion_model permanently, in some cases there are closures that will be passed in as arguments, and changing them permanently will result in an error, even if the user disables the node.
I'm still looking for a suitable way to manage resources and I think it's better for nodes to use function -> ScriptModule and ScriptModule -> CUDAGraph api and let it manage them on a case-by-case basis.

Could the unet_function be wrapper into a torch.nn.Module? Then compile_unet should work on that.

You can try it with the FreeU node in ComfyUI.

Now I have optimized the compilation time in the nightly version.
I think in some circumstances it should be OK to trigger recompile, or model offloading logic would be really complex to implement.


[XR] Implement WebXR's secondary views feature

See - https://www.w3.org/TR/webxr/#secondary-view
This should technically replace spectator mode (or be used under the hood)

Here's a link to the related BabylonJS forum bug report for recording AR experiences on Hololens 2
https://forum.babylonjs.com/t/recording-babylonjs-scene-on-hololens-2/34325


Compatibility with API v5  ? Status 0

Is the code using API v4 or V5 ? Does the new 0 status can be use in Home Assistant ?
Thanks for the work you did on that integration and thanks for sharing !

Hi,
It's not my work, but I checked the prévious relase and found that the code works with V4 and V5 API from EcoWatt since the release 0.7.0 . The link lead to the related changelog.

Thanks @Ekomak for giving all these details.
It’s true, the integration currently supports v4 and v5 and should continue to do this until the v4 is removed at the end of June.
I strongly recommend to migrate to a v5 api key before that date.


Fix model repository error message for incorrect version

Old Error Message:
Missing/Incorrect model_name/model_version: "Request for unknown model 'graphdef_float32_float32_float32'"
New Error Message:
Missing/Incorrect model_name: "Request for unknown model: 'graphdef_float32_float32_float32' is not found"
Model name correct but version=-1 and no version is available anymore: "Request for unknown model: 'graphdef_float32_float32_float32' has no available versions"
Missing/Incorrect model_version: "Request for unknown model: 'graphdef_float32_float32_float32' version 1 is not found"

Fix test failure in cases where model version is not passed no model versions are present. Missing model version is represented by version = -1. The error message earlier returned was 'model_name' version -1 is not found which did not make sense. Now it returns an error that the model has no available versions.


terraform version constraint is wrong

the new added TF version constraint is wrong.
Initializing modules...
  Downloading registry.terraform.io/lgallard/secrets-manager/aws 0.11.3 for secrets_unmanaged...
  - secrets_unmanaged in .terraform/modules/secrets_unmanaged
  ╷
  │ Error: Unsupported Terraform Core version
  │
  │   on .terraform/modules/secrets_unmanaged/versions.tf line 2, in terraform:
  │    2:   required_version = "~> v0.13.7"
  │
  │ Module module.secrets_unmanaged (from
  │ registry.terraform.io/lgallard/secrets-manager/aws) does not support
  │ Terraform version 1.5.7. To proceed, either choose another supported
  │ Terraform version or update this version constraint. Version constraints
  │ are normally set for good reason, so updating the constraint may lead to
  │ other errors or unexpected behavior.

Better just set minium version and not limit to only patch in a module.
Also Dependabot doesn't check which verison is the minimum to be accepted and always suggest the latest version as minimum.
this shouldn't be done in a module.
Suggestion:
required_version = ">= 1.0"

@stevie- Thanks for the head-up. You are right. The latest release changes the constraints as suggested.


fix: Use starkbank/ecdsa 2.1.0

Fixes
This PR bumps the starkbank/ecdsa version to ^2.1.0 so we get rid of deprecations.

fixes https://github.com/sendgrid/sendgrid-php/issues/1108

Checklist

[x] I acknowledge that all my contributions will be made under the project's license
[x] I have made a material change to the repo (functionality, testing, spelling, grammar)
[x] I have read the Contribution Guidelines and my PR follows them
[x] I have titled the PR appropriately
[x] I have updated my branch with the main branch
[x] I have added tests that prove my fix is effective or that my feature works
[x] I have added the necessary documentation about the functionality in the appropriate .md file
[x] I have added inline documentation to the code I modified

If you have questions, please file a support ticket.

Can someone please take a look at this PR? Current sendgrid-php is not working with the latest version of starkbank/ecdsa-php library.
See: https://github.com/starkbank/ecdsa-php/issues/23

No reviews? Hmm, I think you should email support.

Let me check

@simoheinonen some tests seem to fail. Can you check once?

Looks good now. Merging

Thanks guys!

This should've been at least a minor release change.
This package now suddenly requires gmp extension and that change definitely came unexpected.


cannot use play in audio player 1.0.1 version

["one liner" - concisely describe your bug with one very brief paragraph, preferably between 1-3 lines, in clear, correct and acceptable English]
Full Description
Describe in  what the bug is, exactly how, what and when it happens. In particular specifying what you thought should happen and what did happen, and how they differ, in detail. Unless the bug is abundantly clear by the "one liner" (rarely is), this is mandatory. Try to be concise but it's better to write too much than too little.
Code to Reproduce
A minimal reproducible example, i.e., code that allows us to replicate the bug. This is mandatory. It can be one line, if it already is enough to reproduce (rarely is), or a bigger example with all your relevant code. You must use code blocks to put your code in. Don't send your whole project repo, please read the article linked and extract a minimal example, but feel free to link a newly created sample repo reproducing the issue instead of pasting code if necessary (rarely is). If you do link a repo, you must put in at least a little bit of the relevant code and where to find it in the repo.
Log Errors
If your problem involves log errors or messages, please put them here, in full, but feel free to highlight the parts that are relevant. You must use code blocks (or gists) to paste in log lines. An absolutely outstanding example would be to add a code block with 2-3 relevant log lines, followed by a link to a gist with the whole log from which the relevant lines were extracted.
Files/URLs/Sources
If your issue or bug involves specific files, you must provide them. If they are URLs they should already be somewhere in the code provided but please replicate those here. If they are private URLs or actual files, please upload them somewhere accessible and add them here. If your issue is with a stream, for example, provide the stream link or if the stream is private, create a similar stream that also causes the problem and is public, and add that. If you don't know if your issue involves specific resources, please download a few of the mp3 sample files present in the example app and test with those instead of whatever you are doing currently. If the issue persists, it does not involve specific files. Otherwise, this section is mandatory.
Screenshots
If applicable, add screenshots or video recordings to help explain your problem. This is totally optional.
Platforms
List in detail here all the platforms that you have tested, indicating which platforms the error occurs on. Please try to test on as many different platforms as possible to make our lives easier (this is optional). You must add at least one platform in which the problem occurs (evidently). For each platform listed, you must specify:

OS: web, android, ios, macos, etc. if web, which browser was used.
OS version: the android version, ios/macos versions or browser version used.
Device: whether it was a physical device or emulator/simulator. If running on a physical device, what brand/model/kind of device was used. If running on an emulator, what host desktop was used. For web/desktop, what desktop OS and version was used.
flutter version: what exact flutter version you used. If you think it might be a configuration/setup issue, feel free to add a link to a gist with the output of flutter doctor -v (this is optional).
audioplayers version: what version on pub you used, or if you built it yourself what branch and was the latest commit hash
release or not release: specify if you ran the app in release, profile or debug modes. Also specify here any additional flags or conditions that might be relevant (for example, if you ran flutter web with the skia use canvas flag set to true, please mention that here).
does the error occur and does it have any peculiarities: of course if you only tested in one platform, clearly the error occurred there. But if you happened to test on several platforms, please include all of your tests, even the ones that succeeded here, as that info is super valuable. Add details of what was the result in each platform to the extent to which they differed.

See #1152 #1142
Also you re supposed to replace the issue description with your own...


[FEATURE] issue-44: Add support for file_encoding in sources

Description
Allow users to define custom encoding for files.
Changes Made
Add file_encoding support in sources.
Definition of Done
Before submitting this pull request, please ensure that the following criteria have been met:

[x] All automated tests have passed successfully.
[x] All manual tests have passed successfully.
[x] Code has been reviewed by at least one other team member.
[x] Code has been properly documented and commented as needed.
[x] All new and existing code adheres to our project's coding standards.
[x] All dependencies have been added or removed from the project's README or other documentation as needed.
[x] Any relevant documentation or help files have been updated to reflect the changes made in this pull request.
[x] Any necessary database migrations have been run.
[x] Any relevant UI changes have been reviewed and approved by the UI/UX team.

Additional Notes
closes #44

Thanks for your contribution Anand. I tried running the code in my local but ran into an error. It'd be great if you could fix those.

Thanks, @shpiyu
I have updated the code to resolve the issues.


Integrate twitter

LIke #19

Done in https://github.com/macterra/artx-market/commit/d708095ffc2d1640a2837e9bafd578ef40a2886d


[Feature Request] Support Tray Launch Options

Aetron — Today at 3:42 PM
can doubbleklick on the server task icon, may loadup the client and autoconnect to localhost ?

Fixed with 3.6.0


[UI][AKS] Use region to filter VNet list in /meta/aksVirtualNetworks

Followup from https://github.com/rancher/rancher/issues/33517
Currently, /meta/aksVirtualNetworks lists all VNets available to the user. Once this change is merged, it will accept region as a query parameter which will filter the list by ResourceLocation. UI should use the Region selected by the user for this parameter.

The UI already sent the region so I don't think any further change is needed now that the server is filtering based on it.

got fixed from backend ^. No changes were required in UI.


chore: Add code fence langs for syntax highlighting

@nschonni : Thanks for your contribution! The author, @douglaslMS, has been notified to review your proposed change.

#sign-off


Kubernetes:Error: no Jaeger pods found

see  https://istio.io/docs/tasks/observability/distributed-tracing/jaeger/#before-you-begin
Is there Jaeger  Pods?
a production environment by referencing an existing Jaeger instance, e.g. created with the operator, and then setting the --set values.global.tracer.zipkin.address=<jaeger-collector-service>.<jaeger-collector-namespace>:9411 install option.

How to define the jaeger-collector-service 、jaeger-collector-namespace

Hi @tanjunchen , you will need to create an issue in the istio repo, as this may be a configuration issue with their installer.


Modal/Modal.js : requireNativeComponent is not defined

🐛 Bug Report
Requiring module "node_modules/react-native/Libraries/Modal/Modal.js", which threw an exception: ReferenceError: requireNativeComponent is not defined
Warning: React.createElement: type is invalid -- expected a string (for built-in components) or a class/function (for composite components) but got: undefined. You likely forgot to export your component from the file it's defined in, or you might have mixed up default and named imports.
To Reproduce
Create and empty project with react-native init
Import Modal from react-native
Expected Behavior
App can run normally
Code Example
import { Modal } from 'react-native'
render() {
return
}
Environment
React Native Environment Info:
System:
OS: macOS 10.14.3
CPU: (8) x64 Intel(R) Core(TM) i7-7700HQ CPU @ 2.80GHz
Memory: 1.95 GB / 16.00 GB
Shell: 3.2.57 - /bin/bash
Binaries:
Node: 10.12.0 - /usr/local/bin/node
Yarn: 1.13.0 - ~/.yarn/bin/yarn
npm: 6.4.1 - /usr/local/bin/npm
Watchman: 4.9.0 - /usr/local/bin/watchman
SDKs:
iOS SDK:
Platforms: iOS 12.2, macOS 10.14, tvOS 12.2, watchOS 5.2
Android SDK:
API Levels: 23, 25, 26, 27, 28
Build Tools: 23.0.1, 25.0.0, 25.0.2, 26.0.1, 26.0.2, 27.0.3, 28.0.3
System Images: android-28 | Google APIs Intel x86 Atom, android-28 | Google Play Intel x86 Atom
IDEs:
Android Studio: 3.3 AI-182.5<IP_ADDRESS>99772
Xcode: 10.2/10E125 - /usr/bin/xcodebuild
npmPackages:
react: ^16.8.4 => 16.8.6
react-native: ^0.59.3 => 0.59.3
npmGlobalPackages:
create-react-native-app: 1.0.0
react-native-cli: 2.0.1
react-native-git-upgrade: 0.2.7
react-native: 0.57.3

please provide workable demo code

This seems to be a bug in yarn or react-native's build system or something. I tried clearing the yarn cache and it still persists so I suspect it is something on rn's side.
The online source is correct and if I copy/paste it into node_modules/react-native/Libraries/Modal/Modal.js it works fine but if I use yarn at any version > 0.59, it gives the wrong code which doesn't include the right import so it fails. (line 23)
const RCTModalHostView = Platform.OS === 'ios' ? requireNativeComponent('RCTModalHostView') : requireNativeComponent('TranslucentModalHostView');
should be:
const RCTModalHostView = require('RCTModalHostViewNativeComponent');
or even works.
const requireNativeComponent = require('requireNativeComponent'); const RCTModalHostView = Platform.OS === 'ios' ? requireNativeComponent('RCTModalHostView') : requireNativeComponent('TranslucentModalHostView');
I gave more detail here: https://github.com/facebook/react-native/issues/24161#issuecomment-487142031
I think this is the same issue.
https://github.com/react-native-community/react-native-modal/issues/276
Please fix this. It's currently preventing us from being able to upgrade our version of RN.

RCTModalHostView

In my case this was caused by the react-native-modal-translucent library. You can try to upgrade/remove it.


Ballerina Performance Tests on AWS ECS

Description:
Feasibility study and background research on Ballerina performance tests on ECS.
Resources:
https://aws.amazon.com/ecs/
https://github.com/ballerina-platform/ballerina-performance/
https://github.com/wso2/performance-common
https://github.com/ballerina-platform/ballerina-lang/tree/master/performance/benchmarks
https://wso2.org/jenkins/job/ballerina-platform/job/ballerina-performance-execution/
Sample log: sample-log.txt

The first phase of the project is completed. The repository can be found at [1]. The instructions can be found in the README.md of the project. Closing the issue with this.
[1] https://github.com/ldclakmal/ballerina-performance-aws-ecs


"You know what this is... "

I have no idea.
What is this?

Thanks for getting in touch. This video should explain everything:
https://youtu.be/CqkEuUuQQWs
-- Andy

For some reason Github's recommendation algorithm really likes this repository; I see this show up probably at least once a week:

If the CMU db group is interested in sharing its work with the public, that's pretty cool. But here I get the sense that any actual interest from the public will be flippantly discouraged.

@brianfay We're getting closer to announcing this and changing the name. I agree that the current situation is not ideal.


remote-support: Expand push notification data.

Adds the following information to the remote support view:

For the remote server:

Shows the last audit log update date/time, which is also displayed in the remote activity chart.
Shows the date/time that the mobile pushes forwarded count was updated for the server.
If there are remote realms, shows the count of mobile users that have not yet been associated with a remote realm. This helps to account for the potential discrepancy between the total mobile user count for the server and the sum of the mobile user counts for the remote realms associated with the server.

For the remote realm:

Shows the date/time that the mobile pushes forwarded count was updated for the realm.

Notes:

The formatting for optional date/times in the activity views was setting the timezone to be eastern US, but that wasn't indicated anywhere in the charts. Updated this to now show the date/times in UTC, which is what we store on the server, and to have the columns in the charts (or field in the support view) labeled as such.
Adds a couple more queries when building the data for the support view. As this page is still very much in development, it seemed like these additional queries would be pretty cheap and that we can look at optimization when the page is a bit more stable.
Manually reviewed, but did not include screenshots of the various activity chart changes.

Screenshots and screen captures:

Remote server information in remote support view

Remote realm information in remote support view

Self-review checklist

[ ] Self-reviewed the changes for clarity and maintainability
(variable names, code reuse, readability, etc.).

Communicate decisions, questions, and potential concerns.

[ ] Explains differences from previous plans (e.g., issue description).
[ ] Highlights technical choices and bugs encountered.
[ ] Calls out remaining decisions and concerns.
[ ] Automated tests verify logic where appropriate.

Individual commits are ready for review (see commit discipline).

[ ] Each commit is a coherent idea.
[ ] Commit message(s) explain reasoning and motivation for changes.

Completed manual review and testing of the following:

[ ] Visual appearance of the changes.
[ ] Responsiveness and internationalization.
[ ] Strings and tooltips.
[ ] End-to-end functionality of buttons, interactions and flows.
[ ] Corner cases, error conditions, and easily imagined bugs.

Lgtm aside from the typo noted above; I guess tools/run-codespell doesn't catch that one.

Merged; the test failure was a known puppeteer failure that we're debugging.


List references: transition from history to results is not smooth

Steps to Reproduce:

have a history of references
find references again

=> 🐛 the transition from history to results is not very smooth, in the video you can see how the history partially still shows after running "Find References"

@sandy081 This is really cumbersome to implement with the tree. I think the message should be provided by the data source so that the "manual" sync step for extensions becomes obsolete. Then, I don't know of a good way to clear and populate the tree without it feeling sluggish...

Does it looks like a need for clear API that clears everything?

I group refresh calls now by waiting for some time. This could be causing the delay between message and refresh calls.  May be I would try to group updating message and refreshes together and see how it behaves.

@sandy081 This is still pretty bad. I need the tree to refresh without showing the old nodes


add read more to description in Session Detail Screen

Idea Description
add read more to description in Session Detail Screen
Reference images and links

Design Kit
https://www.figma.com/file/XsVzpDZSkEQANgCZLRTDDy/DroidKaigi-2022-Material-3-Design-Kit?node-id=11%3A1833
App Design
https://www.figma.com/file/NcSMs6dMsD88d4wOY0g3rK/DroidKaigi-2022-Conference-App?node-id=0%3A1

I want to try this issue

Thanks! Assigned


Fix path-alias in monorepo

I needed to make this change to make it work in a NX monorepo.
/ - tsconfig.base.json with rootDir: '.' and baseDir: '.'
apps/cool-backend - tsconfig.json extends tsconfig.base.json
libs/cool-library - accessible via typescript path from tsconfig.base.json
Before this change, the cool-backend wasnt able to import from cool-library because the tsconfig was getting baseDir: '.' and rootDir: '.' from tsconfig.base.json. This was generating the incorrect path for the libary, it was looking for apps/cool-backend/libs/cool-library instead of libs/cool-library.
I take the relative path to the extending tsconfig and add that relative path to all paths found in the tsconfig.

Hi, I need to reproduce your escenario to test the package prior to merge the pull request. I only need a simple app with NX and a few modules. Put on every package a few functions (with a simple console.log() or whatever you want), using path alias.
With this i can check if your change doesn't broke the single package applicacion execution, and if this works in a more monorepo escenarios, I will can launch an update with an ifficial monorepo support.

@sleep-written added nx monorepo example 😄

I'm testing your example project, and making these tests:
examples/path alias:

[x] Works with ./start.sh ./src/index.ts.
[x] Works with ./start.sh ./dist/index.js.
[x] Works with ./start.sh ./dist/src/index.js (when "rootDir": ".").

examples/path-alias-monorepo:

[x] Works with npx nx start monorepo-app).
[x] Works with ./start.sh ./src/index.ts (cwd is ./apps/monorepo-app).
[ ] Works with the transpiled project*.

My question is: How can I transpile your project?
Using npx tsc in your example project folder doesn't generate any transpiled code. And I don't see any script inside of any package.json to transpile your project. To merge your pull request I must check that your transpiled projects works too.

Added transpile example

About testing the functionality
I check if your change brokes the targeted escenarios, so here's the result:
/examples/path alias:

[x] ts-node:

[x] Works with ./start.sh ./src/index.ts.
[x] Works with ./start.sh ./src/index.ts (when "rootDir": ".").
[x] Works with ./start.sh ./src/index.ts (when "rootDir": "." and "baseUrl": ".").

[x] tsc:

[x] Works with ./start.sh ./dist/index.js.
[x] Works with ./start.sh ./dist/src/index.js (when "rootDir": ".").
[x] Works with ./start.sh ./dist/src/index.js (when "rootDir": "." and "baseUrl": ".").

[x] swc:

[x] Works with node ./dist/index.js.
[x] Works with node ./dist/src/index.js (when "baseUrl": ".").

/examples/path-alias-monorepo:

[x] Works with npx nx start monorepo-app).
[x] Works with node --loader @bleed-believer/path-alias/esm ./src/main.mts (cwd is ./apps/monorepo-app).
[x] Works with node ./dist/apps/monorepo-app/src/main.mjs (transpiled, using tsc-alias after building).

Suggestions for your monorepo
As a protip, in your ./apps/monorepo-app/project.json, in your commands:

You don't need to use the full path of the loader, instead just put the library path like this:"node --no-warnings --loader @bleed-believer/path-alias/esm ./src/main.mts"

As you are using tsc-alias, you don't need to use @bleed-believer/path-alias to execute your transpiled project:"node ../../dist/apps/monorepo-app/src/main.mjs"

So your ./apps/monorepo-app/project.json should be like this:
{
  "name": "monorepo-app",
  "$schema": "../../node_modules/nx/schemas/project-schema.json",
  "sourceRoot": "apps/monorepo-app",
  "projectType": "application",
  "tags": [],
  "targets": {
    "start": {
      "executor": "nx:run-commands",
      "options": {
        "cwd": "apps/monorepo-app",
        "commands": [
          "node --no-warnings --loader @bleed-believer/path-alias/esm ./src/main.mts"
        ]
      }
    },
    "build": {
      "executor": "nx:run-commands",
      "options": {
        "cwd": "apps/monorepo-app",
        "commands": [
          "tsc",
          "tsc-alias",
          "node ../../dist/apps/monorepo-app/src/main.mjs"
        ],
        "parallel": false
      }
    }
  }
}

Final thoughts
Thanks for working in this PR! your work will improve the funcionality of this library.

Hi @arjunyel, your PR is done and the package has been updated in npm. To implement the new functions, just install the latest version:
npm i --save @bleed-believer/path-alias

@sleep-written thank you for creating the library and your help friend!


Allow jaeger client configuration in query service

Resolves #1044
Which problem is this PR solving?
The query service shall now be configured using the environmental variables to configure the tracer.

Hi @subashiniganesh, Do you have time to continue working on this PR? :)

I'm closing this, as there hasn't been movement for almost two years now.


Add the feed tests.

@ldko, @damonkelley, this is ready for review. Fixes #6

Current coverage is 70.31%

Merging #46 into master will increase coverage by +3.62% as of 2da116c

Powered by Codecov. Updated on successful CI builds.

ping @ldko, @damonkelley
The discussed changes have been made to the tests

:+1:

Something else you may want to consider is adding some whitespace. I like to use it to seperate the setup from the SUT and the assertions.

Yeah I forgot the whitespace, but it has been added in. I only add it to separate the assertions from the rest of the test on tests as small as these.

:+1:


Iox 1394 fix duration warnings

Pre-Review Checklist for the PR Author

[ ] Code follows the coding style of CONTRIBUTING.md
[ ] Tests follow the best practice for testing
[ ] Changelog updated in the unreleased section including API breaking changes
[ ] Branch follows the naming format (iox-123-this-is-a-branch)
[ ] Commits messages are according to this guideline

[ ] Commit messages have the issue ID (iox-#123 commit text)
[ ] Commit author matches Eclipse Contributor Agreement (and ECA is signed)

[ ] Update the PR title

Follow the same conventions as for commit messages
Link to the relevant issue

[ ] Relevant issues are linked
[ ] Add sensible notes for the reviewer
[ ] All checks have passed (except task-list-completed)
[ ] All touched (C/C++) source code files from iceoryx_hoofs are added to ./clang-tidy-diff-scans.txt
[ ] Assign PR to reviewer

Notes for Reviewer

Checklist for the PR Reviewer

[ ] Commits are properly organized and messages are according to the guideline
[ ] Code according to our coding style and naming conventions
[ ] Unit tests have been written for new behavior
[ ] Public API changes are documented via doxygen
[ ] Copyright owner are updated in the changed files
[ ] All touched (C/C++) source code files from iceoryx_hoofs have been added to ./clang-tidy-diff-scans.txt
[ ] PR title describes the changes

Post-review Checklist for the PR Author

[ ] All open points are addressed and tracked via issues

References

Closes TBD

Codecov Report

Merging #3 (81ccb8a) into master (ac127fe) will decrease coverage by 0.02%.
The diff coverage is 94.54%.

Additional details and impacted files

@@            Coverage Diff             @@
##           master       #3      +/-   ##
==========================================
- Coverage   75.71%   75.69%   -0.03%
==========================================
  Files         375      376       +1
  Lines       14566    14572       +6
  Branches     2067     2067
==========================================
+ Hits        11029    11030       +1
- Misses       2908     2911       +3
- Partials      629      631       +2

Flag
Coverage Δ

unittests
75.35% <94.54%> (-0.03%)
:arrow_down:

unittests_timing
15.37% <43.63%> (+0.01%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

.../include/iceoryx_hoofs/internal/units/duration.inl
93.71% <92.50%> (-0.91%)
:arrow_down:

.../include/iceoryx_hoofs/internal/units/duration.hpp
100.00% <100.00%> (ø)

iceoryx_hoofs/source/units/duration.cpp
92.00% <100.00%> (ø)

iceoryx_hoofs/source/concurrent/loffli.cpp
74.28% <0.00%> (-11.43%)
:arrow_down:


tsdx silently fails parsing of tsconfig files containing comments, trailing commas, etc. that TSC accepts

Current Behavior
tsc supports tsconfig.json files that contain comments, trailing commas, and other features beyond standard JSON.
Current tsdx, however, parses tsconfig.json using fs.readJson which ends up calling JSON.parse which will throw an exception if faced with comments, extra comments, and other non-standard JSON content. Making things worse, the exception is silently ignored, which makes it really hard to figure out why config settings are being ignored.  I had to step through tsdx code to figure out what was going on.
https://github.com/jaredpalmer/tsdx/blob/4f6de1083393057903a1837fb6658f8058ee832f/src/createRollupConfig.ts#L46-L49
Luckily this JSON is only used once in tsdx (only in createRollupConfig.ts) and that JSON is only currently used for one setting: esModuleInterop. But #468 is about to use it too for processing declarationDir.
BTW, tsdx is in good company with this problem: Create React App had the same problem.
There's also an extends feature in tsconfig which allows configuration inheritance across multiple tsconfig files. This isn't supported by tsdx either. See #484.
Expected behavior

tsdx should accept the same tsconfig.json syntax that does.
Syntax errors (or other unexpected errors) reading tsconfig.json should not be silently ignored.

Suggested solution(s)
For 1) Luckily, the nice people in TypeScript-land have exported their tsconfig parser.  From https://github.com/facebook/create-react-app/issues/6865#issuecomment-485962203:

Unfortunately it looks like typescript uses a hand-written parser. I traced it down to parseJsonText which is defined in src/compiler/parser.ts. Ahahaha.
If we're allowed to hook into the typescript package, it looks like they provide public access to their parse function.

Note that there are a whole set of parse functions defined. Hopefully one of those would meet tsdx's needs. Ideally it'd also support the extends keyword in tsconfig.json which is also currently unsupported by tsdx.
for 2) I'd suggest white-listing ignorable exceptions (e.g. file not found?) and reporting the rest to the user. In particular, any syntax errors should be reported to the user and should fail the build.

I haven't read through the CRA issues/code (don't have time right now, will check later), but your reasoning and that solution according to it make sense to me. Would you like to add a PR for this and #484 ?
It will merge conflict with #436 unfortunately as that has yet to be reviewed/merged by Jared 😕

I actually wrote that tsconfig.json parsing as my first PR to fix #165 , per that I just copied the same logic in for parsing package.json. This would definitely improve that naive tsconfig parsing, which is a lot more complex than package.json. The error handling is also the same as there, and that silent catch is probably problematic there too.

Hi @agilgur5 - Thanks!  I don't think I'll have time to PR this problem in the near future-- very busy month ahead for me and I was lucky to have time over this weekend to report some issues.  Sorry I can't help more, but at least I wanted to record the problem before I got sucked into other tasks on Monday.

No worries -- figured I'd ask since you've done a lot of the investigation toward the solution already! And always good to encourage contributors in general in OSS 🙂 I'll make sure to add you to allcontributors for bugs and ideas if somebody else (probably me) PRs that

Merged in #489 as I'm now a collaborator. Turns out that ts.parseJsonConfigFileContent is needed to parse extends, but ts.readConfigFile is enough for comments and commas. These are not remotely well documented, so I had to search around other repos to figure out how to do this simply and properly

@allcontributors please add @justingrant for bugs, ideas


Scrollbar with max-height: 100%

Hello,
previously I used the perfectscrollbar but since it is not IE8 compatible I gave jquery.scrollbar a try. Unfortunately I have problems with it.
I have a overlay with a navigation. This navigation should be 100% height. Unfortunately:
				.scroll-wrapper{
					max-height:100%;
					height:auto;
				}

and also
				.scroll-wrapper{
					height:100%;
				}

will not work.
@gromo What can I do to have a scrollbar with 100% height?

Well yes, you are right it is not a issue of the scrollbar. For all those who have the same problem: use overflow:auto; and do not initialize the plugin too see the default browser scrollbar. Than you will see what causes the problem!
Thanks for help!


Majority_Element_2 problem added

@Jimmy290901  Please review the problem code and merge it. Thanks!

Thanks for the PR. Happy Contributing. ✌


Value for an address is the exact amount of REV at snapshot

It appears that no calculations were done for this particular address.
https://github.com/r-publishing/mainnet-genesis/blob/69cda0c37c14b45e67ba87e31c2dc90055de1942/wallets.txt#L13439
https://revdefine.io/#/revaccounts/1111x8CVeC6ioNXgZwRTJAH3A1b6spKaKAME2J7eahHfyWeU2b1k7

This is the correct figure.
https://github.com/r-publishing/mainnet-genesis/blob/69cda0c37c14b45e67ba87e31c2dc90055de1942/wallets.txt#L13439 contains the contents of the snapshot from the RChain mainnet rounded to 6-digit precision (used by RPC)  instead of 8-digit precision (used by RChain).
If you are looking for the amount of the expected RPC airdrop, the number will be in https://github.com/r-publishing/mainnet-genesis/blob/master/rpc.wallets.txt (also in 6-digit precision)

I was looking for the amount of the airdrop in the wrong file.


imagesLoaded not being called

Hey Eirik!
Am upgrading code after way too long. Running into some glitches with a cold cache. In versions 0.5.7 and up, imagesloaded does not fire-- this never logs:
imagesLoaded: function() {
    imagesloaded(this.refs[reference].getDOMNode(), function(instance) {
        console.log(">> Images were Loaded!");
        this.masonry.layout();
    }.bind(this));
},

0.5.5 looks fine, so I'll probably stick with that...

Thanks for the heads up @winkler1. Will look into it :-)

@winkler1 could you try 1.0.2? And which version of React are you using?

Issue is still present. Using "react": "^0.13.0". It's not a problem with getDOMNode, the node was being set... traced through the imageLoader code a bit and found that it was finding the child s, but for some reason the callback is never invoked.

That's strange.. I can

If you find any more clues be sure to post it :-)

I was having this issue as well. I fixed it by adding this.imagesLoaded(); to componentDidMount because componentDidUpdate is not called for the initial render.

Thanks @FelipeMarcos! Will release a fix.

released as 1.0.3


Windows10 lib123out issue

This simple code here
from mpg123 import Mpg123, Out123

# load an mp3 file
mp3 = Mpg123('D:/mpg123/test.mp3', library_path = 'D:/mpg123/libmpg123-0.dll')

# use libout123 to access the sound device
out = Out123(library_path = 'D:/mpg123/libout123-0.dll')

# decode mp3 frames and send them to the sound device
for frame in mp3.iter_frames(out.start):
    out.play(frame)

Gives this error:
C:\Data\Anaconda3\python.exe "C:/Users/$Username$/IdeaProjects/ESP_1/sound2.py"
Traceback (most recent call last):
  File "C:/Users/$Username$/IdeaProjects/ESP_1/sound2.py", line 7, in <module>
    out = Out123(library_path = 'D:/mpg123/libout123-0.dll')
  File "C:\Data\Anaconda3\lib\site-packages\mpg123.py", line 282, in __init__
    raise self.OpenException(self.plain_strerror(errcode))
mpg123.OpenException: invalid error code
[src/libout123/module.c:185] error: Failure getting module directory! (Perhaps set MPG123_MODDIR?)
[src/libout123/module.c:185] error: Failure getting module directory! (Perhaps set MPG123_MODDIR?)
[src/libout123/libout123.c:451] error: Found no driver out of [win32,win32_wasapi] working with device <default>.

How to get it working with windows.. I am thinking the drivers in mpg123/plugin are not getting loaded?

Hi, libout123 requires access to a plugins/ directory in which to find the related dll.
You can put the plugins directory into the same directory of the py script, or specify it via the MPG123_MODDIR environment directory

Hi, how to specify the MPG123_MODDIR environment?
I have put the plugins folder in the same directory as the py script, but it's get same error.


Typos

I am constantly making typos, so if something catches your eye, don't be shy and create a pull  request.

I can help you with that.


Bot encodes second slash to 2F%

I have Jenkins multibranch pipeline job. My jenkinsfile contains the following line:
slackSend "Build Started - ${env.JOB_NAME} ${env.BUILD_NUMBER} (<${env.BUILD_URL}|Open>)"
There are several git branches with name feature/smth.
So, when I trigger build - I have the following message in slack:
Build Started - wallet-github/feature%2Fsmth 1
I want to see branch name without encoded slash.

Seems that this issue is related to Jenkins, not Slack sender


Moment deprecation warnings

This prints out every time I require and use this library:
Deprecation warning: moment().zone is deprecated, use moment().utcOffset instead. https://github.com/moment/moment/issues/1779

Thanks. I'll take care of it.

Bump - has this been taken care of yet?

Nevermind, opened https://github.com/ncb000gt/node-cron/pull/148.


System tray icon not there

Microsoft PowerToys version
v0.43.0
Running as admin

[X] Yes

Area(s) with issue?
System tray interaction
Steps to reproduce
Install PowerToys Log on and wait.
✔ Expected Behavior
The system tray icon for Power Toys to be there.
❌ Actual Behavior
The system tray icon is only there for a small period of time after you log in, the other icons are. Eg Awake. just not the Power Toys settings one.
Other Software
No response

Hi @Tiggy-Tiger
It looks like a duplicate of #12557
Can you please run the bug report tool?
Open a command prompt and run "%PROGRAMFILES%\PowerToys\Tools\BugReportTool.exe" (double quotes are important)
A zip file will be created on you desktop
Drag and drop the zip into a GitHub comment

Do you by any chance use TaskBarX like in this issue?
https://github.com/microsoft/PowerToys/issues/12557#issuecomment-897436538


Changes in tasks.json aren't reflected when building the program

VSCode Version: 1.33.1
OS Version: Ubuntu 19.04

Steps to Reproduce:

Press Ctrl+Shift+B to open the build options
Click on the gear icon to edit the task file
Add for example "-lpthread", as an argument

The change isn't reflected by the terminal input reported when selecting the same task nor is there and additional option for the modified task

There is however and additional option when using Ctrl+Shift+P, typing in "tasks" and selecting "Tasks: Configure task"

Does this issue occur when all extensions are disabled?: The problem is kinda fixed when run with --disable-extentions. This forces VSCode to display an error message that no build tasks found, asks if you want to create one and after that gives you an option to use the user generated one.

Only tasks with "group": "build" show in the build task picker.

Then why isn't "group": "build" in the autogenerated file? If I choose the cog to edit a task, I expect the edits to be reflected without additional modification.

By changing the arguments for the existing task you have actually created a new task. The original task is still marked as a build task, which is why it shows up. If you had added a property to the task in tasks.json that didn't cause the task to become a new task (such as the presentation properties), then it would still be the same task and still be a build task.


runs at startup but runs in its full glory

Hi Toni,
I installed your plugin on ionic and it does work and work as expectedly. However, I think there is one side-effect that the end users may not like.
When the phone reboots, users are greeted with my app ( as soon as they pass the lock screen ). That's because your plug in kicks in and starts running my app. The problem is now the user has to do something ( such as pressing on the home button ) si that they can see their normal home/desktop view. And this is something they have to go thru, every single time, the phone is shutdown and reboots.
Is there a way to modify the plug in so that the associated app starts running in the background at startup, rather than running it in the foreground like this?

Hi,
It might be possible. Anyway a cordova app needs to be in active state (visible) at least once. After that your app could use functions of "de.appplant.cordova.plugin.background-mode" and "cordova-plugin-backbutton" plugins to automatically move your app to the background.
But in addition it is needed  a status about if the start-up is initiated by this plugin or user (see https://github.com/ToniKorin/cordova-plugin-autostart/issues/7). If you have time feel free improve this plugin.

why the need for "cordova-plugin-backbutton"? I can see the need for the "de.appplant.cordova.plugin.background-mode" presense but don't get the point on the "cordova-plugin-backbutton"

It hides your app and brings the home view in front.

got you... does that mean we will end up with no ios support?
cause as you know, ios does not have a dedicated-and-always available-backbutton functionality? it sure has back/forward in some apps as safari but always. for example, from desktop/home view, i can open say, gmail on an android device and then press the backbutton, and this would send the gmail to background while placing me back on the desktop/home view. I cannot do this on ios.

The backbutton is not the reason. The iOS itself limits and controls background tasks much more than  Android. E.g. the iOS implementation of "de.appplant.cordova.plugin.background-mode" prevents the acceptance of Apple appstore.  Your app needs to be a native VoIP app to get a full background support with the automatic start-up. See more details at
http://stackoverflow.com/questions/9300815/can-iphone-apps-start-on-start-up

Hi.I am using the plugin and it works well when the phone reboot.I want to auto start the app in background and do something such as connecting the bluetooth when the phone reboot. I have added plugin 'cordova-plugin-background-mode' but it still run foreground when phone reboot. Would give me some help .Thanks a lot.

So your app won't start at all?
Maybe because of the installation to the SD card will prevent it?

Yes. the app does't start at all. How can i know where the app is installed ? I only used 'ionic run android ' to install the app to the phone.

I am interested in auto launching my app at boot. However I cannot seem to get this plugin to work with my Ionic app. Can you give me specifics on how you installed the plugin & what you added to the config.html file or the app.js file to get this to work?

Have you checked the android logs?

The requested enhancement "run at startup in to the background" added to the TODO list...

Is there any way to make the application always running, ignoring the buttons of: Home, Back, Recentapps? that is, block those buttons so that the app is always running?


Unreliable test PointerBehaviorTests.TestGrab

Overview
PointerBehaviorTests.TestGrab failed from unrelated changes in PR
#6168. The failure was: https://github.com/microsoft/MixedRealityToolkit-Unity/pull/6186/checks?check_run_id=245737592
Error was:
 Incorrect state for Left Line Pointer.IsInteractionEnabled
  Expected: False
  But was:  True

Could not repro test failure after running TestGrab 1000 times.  Closing this issue.


Make components headless for Indicator component

Description
Migrate styles from components to themes.
Since component styles in themes inherit styles from other components using mergeStyle etc., duplicate styles should be removed.
Problem Statement/Justification
Move static styles from indicator component to theme.
Proposed Solution or API
No response
Alternatives
No response
Are you willing to participate in implementing this feature and create a pull request include the implementation?
Yes
Additional Information
No response

Closed due to no migration required.


Code reorganization to separate files

Overview
I think the code needs major reorganization to be able to add new functionality easier and keep the code readable for everyone. Having logic for different parts of the game in the main.lua or having one file containing all draw functions to me doesn't feel like a future proof concept.
I"m a OOP guy myself, but having separate files for stuff like different kinds of objects or categories like hud, menus etc. doesn't mean we have to follow the OOP paradigm with classes, inheritance, etc. It's just a different way to store the code to keep stuff together that is closely related.
I think this issue could be used to discuss further changes before working on it and going into a direction not everyone is cool with.
PRs

#137
#149

Every suggestion you've had so far is a winner so keep going.  :)

I made a new post in the love forums regarding a assetloader-tool.
Assetloader-tool.love
I've no idea why I've chosen to tackle this first, but I started cleaning-up some code and ended up with coding something to load assets :sweat_smile: .
What I actually tried to do is find a good directory structure to keep things organized.
I think using the file names in the directory directly as name for the asset in the code makes sense to save some tedious work and having different names for each which can be confusing. We'd just need to make sure that we stick to one naming convention for the files to keep everything clean.
What do you think? Too much? Not helpful?

I like the idea but won't be in front of a computer for a day or too (I have access to mobile).
I assume this will help with frame rate, speed and memory efficiency?

I like the idea but won't be in front of a computer for a day or too (I have access to mobile).
I assume this will help with frame rate, speed and memory efficiency?

In it's current form I'd say no, except for it to providing an easy way to create fonts and use them everywhere else, instead of creating a new font in the draw functions which is not really nessecary and potentially is bad for memory consumption and performance.
It also can be used to load directories of files one at a time e.g to just load menu assets first (ingame assets not needed yet) and when the player starts a new game the directory with in-game assets can be loaded.
But it's not really meant to be used like this atm.
It's currently just to make our lifes easier and keep the code a bit cleaner. No fancy multi-threaded asset loading or anything like that. You'll know whenever you have time to look at the code. 👍
btw today I'll be back at work, so progress on my end will likely be a bit slower.

Okay. I took a look. I see what you're doing now. I like it.  :) I thought this might be a just-in-time asset loader/unloader so that's where my questioning was but this is good. I like the way you 'buried' the anim8 stuff so the coder (us) doesn't need to know.
How do we progress? Is Assetloader.lua read as is?

How do we progress? Is Assetloader.lua read as is? I'm happy for you to do a PR into main branch and we can all transition to it over time. It can make a large refactor a little more tolerable.

Im currently refactoring lander.lua and also made some adjustments to the file directory to get ready for implementing the assetloader. But I've also already seen that there are some tricky things to resolve before being able to implement it, e.g the ids used for selecting which basetype is spawned and more.
I'll likely sent a draft PR today after work for you to be able to see what has been changed already.

On a different topic - I just fixed some stuff with the sockets and committed that to main branch with no conflicts.
Tomorrow I will refactor the same socket stuff (socketstuff.lua) and apply our style guide and see how we go. I look forward to nice clean and consistent code.  :)

I look forward to nice clean and consistent code. :)

Me too. I believe it might even be faster to rewrite large portions of the code rather then refactoring it, but from an educational perspective I'd say refactoring is a good idea.

Ok, I'd like to share some thoughts I have - mostly on how the source code refactoring is going imo.
But first of all I want to say - Even though it felt like all of us were pretty new with using git and Github in it's full potential, we managed to get used to our own little workflow almost in an instant (with some hiccups :roll_eyes: :smile: ).
It's great fun to work on the project with you guys, especially because for me it feels like it's the first time such a collaboration just works "out of the box". Everyone seems to have their own small or big priorities and can work almost freely, everyone reviews PRs and gives feedback as much as the time allows - & we even got something like an unintentional 24 hour shift because when you guys sleep I'm mostly doing something (like writing stuff like this :see_no_evil:) - & vise versa :stuck_out_tongue_closed_eyes:
Okay, but now back to the project.
I'd say the situation with the code got way more manageable. We got many objects and functions separated out to their own files, we added luacheck to our workflow and Github Actions which helps to find nasty stuff, we cleaned up most of the code and in our style guide, we defined how we want to write the code in future to keep it nice and shiny :star2: - all this in just a little over a week!
That said, I see more opportunities for improvements to some files. Here are some things I have in mind:
functions.lua:
- GetDistanceToClosestBase can be moved to the base.lua module
- CalculateScore might be better in lander.lua since the score is saved in the lander object itself currently
- HandleSockets might be better in enumstuff.lua
- Load/Save related functions could be moved to something like a filesystem.lua module.
- The gamestate / SwapScreen stuff also could be in their own file like gamestate.lua
- having all things moved out, then the file could be removed
createobjects.lua
- currently it's used for creating the base and building objects, but later on (with more objects coming) we might need to move some of the code to the objects like having them creating their own variables like in Lander.create which currently happens in here. And giving the objects their positions seems like a task for terrain.lua. so, after changing that - the file also could be removed.
enum.lua
- The file might should be restructured to the same format as scripts/modules.lua (just data blocks) and loaded locally like the lander modules in lander.lua.
main.lua
If we decide we can use a new file for gamestate things, we could move many snippets handling the game's state like
	if strCurrentScreen == "MainMenu" then
		menus.DrawMainMenu()
	end

	if strCurrentScreen == "World" then
		drawWorld()
	end

from main.lua to the new gamestate.lua as well.
That should be pretty much all I can think of at the moment. :+1:
Can't wait to see how the game will look in a couple more weeks :wink:
& in retrospect I'd like to say:
how did this post get sOoo long?! Sry!

Thanks for the post and thanks for your contribution so far. @Doc and @Philbywhizz have of course contributed in ways that are just great. I think soon we'll settle into our own corner of the project (enet for me) and the PR's will become less painful. But I think we're getting better at the PR's.

HandleSockets might be better in enetstuff.lua

I'll do this as a part of the enet upgrades and will make all that stuff isolated and immune to PR's (hopefully). Happy with the other suggestions but is it really possible to not have a 'generic' functions module that has things that are simply generic? We can try and see!
I'd love to get rid of createobjects.lua. That one is bugging me - lol.
All of this is great stuff and as we incrementally refactor it will only get better.  :)

Happy with the other suggestions but is it really possible to not have a 'generic' functions module that has things that are simply generic?

Sure, without any issues. We just need to get used to call modules locally in the files where those generic functions are used. That's the cleanest approach I can think of.

Noting that handle sockets isn't even called anymore. Feel free to completely delete it in your next PR.


Update: Allow dev server to be accessed externally

Current coverage is 100.00%

Merging #83 into master will not affect coverage as of 2b666f6

@@            master     #83   diff @@
======================================
  Files           14      14
  Stmts          119     119
  Branches         0       0
  Methods          0       0
======================================
  Hit            119     119
  Partial          0       0
  Missed           0       0

Review entire Coverage Diff as of 2b666f6

Powered by Codecov. Updated on successful CI builds.

@camjc merge?

Merging!


How can i use syncUniqueId method?

Ok, i know when a ios device moved to restored b ios device. This can be same unique id.
So how can i call this syncUniqueId  function when this was restored device?

Unsure - if you can dig in to the related PR for the functionality and tag in the author they might know? I haven't exercised this use case and have no special / helpful knowledge in the area, sorry

@yoojeen126 Hello, I'm fronted developer and I added syncUniqueId.
In my app: backend somehow detecting it and returns error code on which I should to log out user. On that error I calling syncUniqueId. That helped for my case.
Also we thought about add the button for it in the settings.
Maybe you can to call syncUniqueId once and store flag in AsyncStrage.
Then if user will have problem, you can ask him to press the button or reinstall app.
There are many options. Depends on your goals and imagination:)


Catch-up handover review with missing features and review comments

Apply review comments.

This change is

@igorbernstein2 @vermas2012
We have applied most of the comments from https://github.com/googleapis/java-bigtable-hbase/pull/3322 in this review.
The comments which we left without an answer are either simply applied or concern integration tests, which we thought is not the highest priority to fix given the budgetary constraints.
When https://github.com/googleapis/java-bigtable-hbase/pull/3322 was created, it was still missing some features (e.g. mode with concurrent writes to both DBs). Before and while it was reviewed, we implemented the missing features, significantly diverging from the review branch, which is why we applied the review fixes on to top of our new changes rather than rebasing the giant PR.
Splitting the review fixes now from the feature work would mean lots of rebasing and conflict resolutions, so we figured it would be easiest to review the review fixes together with the missing features (commit-by-commit should be much easier than as a whole).


border and fill dropdowns are disabled (and their tooltips) when a us…

…er hasn't actively selected an existing shape or drawing a new shape. Update the fill color of an annotation as a user is dragging.  also make sure a user can draw multiple of the same shape without having to re-select it.  better cursor feedback as well during annotation drawing and editing.
closes #1066, addresses part of #1067

Coverage decreased (-0.1%) to 47.417% when pulling 408c82d8f524f14aebef203a2753a9a76a6ca8ac on 1066-annotation-ux into dd86d1a14ccf2db65bc2871baac16e19a029a3c2 on release2.1.


fix: incorrect window size before/after setTitleBarStyle

Fixes issue where setting both size and setTitleBarStyle using WindowOptions in waitUntilReadyToShow causes incorrect window size.

This is fixed by putting titleBarStyle handling before all other options so the OS calculates the window size and position correctly,

This commit introduced a new issue: https://github.com/leanflutter/window_manager/issues/504