Support setting table and column comments to NULL

Allow for a literal NULL to be passed as a comment string to remove a comment from a column or table.
The comment string is now passed as-is to the SQL query, without quoting it. Migration authors will need to ensure that the comment string is properly quoted, as is already the case for column default values.
Without this change it becomes impossible to remove a comment from a column using the 'set comment' 'alter column' sub-operation (https://github.com/xataio/pgroll/pull/344).

uhm, I think the need for quotes is quite unexpected as a user. Wouldn't be enough to pass a "comment": null JSON value?

Wouldn't be enough to pass a "comment": null JSON value?

Passing "comment": null would mean that we can't easily distinguish between a comment field that is unset vs one that is explicitly set to NULL.  In an 'alter column' operation therefore, we wouldn't know whether to set the comment to NULL or leave it unchanged. This is a common problem with Go JSON unnmarshalling (see eg here).
pgroll already requires quoted literal strings when setting column DEFAULT values; here the user may set the column DEFAULT to some function call (eg now() for timestamp columns)  so pgroll can't assume that all DEFAULTs should be quoted so it is left to the user to do so.
In the case of comments, the only two values allowed are literal strings or NULL.
We have some options:

Accept the changes in this PR and require comment fields to be single-quoted strings or a bare NULL.
Close this PR and accept that comments can't be removed by alter column statements, only set to the empty string (removal of a comment could still be done with a raw SQL migration)
Invest more time in coming up with a solution to allow distinguishing explicitly set to NULL comments vs missing fields (eg using the nulllable package). This might be complicated by the fact that our operation types are generated from the JSON schema so doesn't allow us much control over the type of the comment field in an OpAlterColumn.

After some more experimentation, allowing "comment": null to remove a comment field will work as long as we can specify the type of the OpAlterColumn.Comment field as Nullable[string] (using the nullable package).
It requires an upstream change to go-jsonschema in order to emit the nullable.Nullable type correctly from the schema.json file.
This would mean users could specify either:
comment: null

or
comment: "some string"

without having to enclose "some string" in single quotes. This makes it inconsistent with how string literals are specified with DEFAULT values, but perhaps less surprising.

I like this one! Wondering if we could do the same for others. roping @eemmiillyy @SferaDev for thoughts on the json schema

I think this is ready now. The upstream change to go-jsonschema has landed https://github.com/omissis/go-jsonschema/pull/220.
I've updated the PR description:

Build on #344 to allow removing column comments by setting them to null.
Make use of https://github.com/omissis/go-jsonschema/pull/220 and use the nullable package so that it's possible to distingush between a missing comment field and one that is explicitly set to null.
With https://github.com/omissis/go-jsonschema/pull/220 not being part of a release yet, use a custom build of go-jsonschema. It should be possible to switch back to the official release images once that PR is part of a release.
Without this change it becomes impossible to remove a comment from a column using the 'set comment' 'alter column' sub-operation (https://github.com/xataio/pgroll/pull/344).

Wondering if we could do the same for others

What do you mean by this @exekias? I don't think the same approach makes sense for setting default values for the reasons described in https://github.com/xataio/pgroll/pull/345#issuecomment-2071930676.
It makes sense for comment because there are only two allowed values: string literals or null.

We also need to approve the PR on which this one is based: https://github.com/xataio/pgroll/pull/344


Terraform: Unable to get latest version: using 1.1.6

TerraformV1 failing to find the most recent version of terraform. Below is an included log identifying that its now pivoted back to 1.1.6 with the current release being 1.8.0.
Would it be possible to investigate and resolve the issue.
It may be worth increasing the v1.1.6, luckly we had minimum version checks in the pipeline to defend against falling 6 minor versions back.
==============================================================================
Task         : Terraform tool installer
Description  : Find in cache or download a specific version of Terraform and prepend it to the PATH
Version      : 0.203.0
Author       : Microsoft Corporation
Help         : [Learn more about this task](https://aka.ms/AAf1a0p)
==============================================================================
Getting latest Terraform version.
Unable to get latest version: using 1.1.6
Downloading: https://releases.hashicorp.com/terraform/1.1.6/terraform_1.1.6_linux_amd64.zip

I can see in the code base below, that the default is set to 1.1.6, which correlates to the pipeline above.
https://github.com/microsoft/azure-pipelines-terraform/blob/648beac95fde31be0f57ea6e872a5261a60a38a6/Tasks/TerraformInstaller/TerraformInstallerV1/src/terraform-installer.ts#L27

Hi, I will see if Hashicorp changed something on their end, but I think I will remove that fallback as it quickly gets outdated. I think it will be better to fail it no versions is found and state to check the version manually on terraform page.

Hi, Checked code and Hashicorps endpoint. everything seems to be working. If you are behind a proxy I would check if https://checkpoint-api.hashicorp.com/v1/check/terraform is allowed through the proxy.

We had the same issue this morning on one pipeline run. Probably a temporary issue on the hashicorp API because all other runs installed latest version successfully. The init failed right away thankfully.
I think it would make more sense to remove that default version as well as it is very outdated.

hey, there might be something fishy with the API.
A call to https://checkpoint-api.hashicorp.com/v1/check/terraform returns 1.9.3 while a new 1.9.4 is there.

hey, there might be something fishy with the API. A call to https://checkpoint-api.hashicorp.com/v1/check/terraform returns 1.9.3 while a new 1.9.4 is there.

It was released yesterday, perhaps they have a small internal delay before publishing it to the version API

The error that you mentioned is temporary and may have many causes (Terraform endpoint is unavailable, issues with internal MS network...).
I created a PR, that was approved, to update the fallback version, used when the API fails. Hopefully this will reduce the issues when the API fails again.
@SuperP4rks , could we close this issue?

Hi @peruzzof ,
Happy to close, i think there was an issue with the egress on the Managed Agents. As the Endpoint was live and contactable, but the library was struggling to reach out. But also the 1.1.6 was also super low.
Lets put this down to network issue. An close the ticket.
Thanks all for the help


Remove residual uses of Compat

Still needed for xor, take! changes (Compat v0.9.5)

Current coverage is 87.95% (diff: 89.83%)

No coverage report found for master at 6b5f4ec.

Powered by Codecov. Last update 6b5f4ec...e95f40f

Changes Unknown when pulling e95f40fb9afea8ada0bbb9b4d2cc811e523a0a9f on kms/compat_updates into ** on master**.

Changes Unknown when pulling e95f40fb9afea8ada0bbb9b4d2cc811e523a0a9f on kms/compat_updates into ** on master**.


cancel requireTaskPool process

Hi,
After executing a function via requireTaskPool, is it possible to kill this process somehow?
Thanks,
Jeroen

@JeroenVinke They get cleaned up automatically, do you mean that you want to abort a running process?

do you mean that you want to abort a running process?

Yes

any hints where to look? do you think that it is possible?

@JeroenVinke It's definitely possible, though I don't know what the current sitch with cancelable promises is at the moment. You can always do this today manually though (i.e. create a second exported method called "CancelThisThing")

@paulcbetts Hey paulcbetts, could you please explain with an example how to stop manually a process in the task pool, I need this solution to workaround the issue #22


pull request for e2e test at 11/08/2016 12:15:10

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

optest/docs/updated_at.md
:white_check_mark:Succeeded

Details

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Codepen Playground

The codepen playground doesn't seem to work, so I set up a JSFiddle to play around with vuikit:
https://jsfiddle.net/fabiandev/cuz6qs43/
Feel free to fork, and thanks for this great package :)

You are welcome @fabiandev :)
We have updated the pen with latest changes. Now should work. Thanks!


[Feature request] - Make search non-blocking for the UI

When running a search for a large folder with lots of sub-folders/files, the UI drags quite a bit. It's possible that search is on a non-blocking thread, but is injecting markup at a rate that's causing thrashing. Is Atom managing inserts with a virtual DOM or is it just inserting markup whenever a result is returned?
When performing a large search, it's more valuable to have a smooth interface than to have an immediate result inserted for each match.

Please report this on the find-and-replace package instead.  Thanks!


Add Pictogrammers icons

https://pictogrammers.com/library/mdi/
There are a lot of useful material icons, including standard google ones, so seeing them in this repo will be good, also knowing that material-icons-extended stripped off in compose 1.8.0

Also i don't understand why in repo only lycide icons

Where do the icons you linked originate from? The site you linked hosts the icons but doesn't seem to be the ones creating it. I need the original author so that I can link to them and also download the icons.
Are those different to Google's material symbols? Material symbols are already on composeicons.com

Also i don't understand why in repo only lycide icons

Because that's the one I needed for my projects :) will add more asap

People draw icons and send them to this site, it's free to use, you can download all icons as i remember


Bug: Unexpected segmentation fault on empty table

Kùzu version
v0.4.2
What operating system are you using?
Ubuntu 22.04
What happened?
Hi! I found that when the table is empty, directly running MATCH (n) DETACH DELETE n; will cause an immediate segmentation fault and core dump without any notification.

After compiling with debug info, I found that this query triggered an assertion error Assertion failed in file "/home/auroraeth/Project/1/kuzu/kuzu/src/binder/expression/node_rel_expression.cpp" on line 18: tableIDs.size() == 1.
Perhaps it would be better to do some exception handling? Thank you!
Are there known steps to reproduce?
No response

This should be fixed in #4038


Nod size can not be zero or negative.

This resolves #61.

[Current coverage][cc-pull] is 91.13%

Merging [#68][cc-pull] into [master][cc-base-branch] will increase coverage by 0.01%

@@             master        #68   diff @@
==========================================
  Files            77         77
  Lines           946        948     +2
  Methods           0          0
  Messages          0          0
  Branches        179        180     +1
==========================================
+ Hits            862        864     +2
  Misses           48         48
  Partials         36         36

Powered by Codecov. Last updated by [c30e767...ec3dd4d][cc-compare]
[cc-base-branch]: https://codecov.io/gh/parsingdata/metal/branch/master?src=pr
[cc-compare]: https://codecov.io/gh/parsingdata/metal/compare/c30e7676688020afb0058e36847170d8f9ee9753...ec3dd4d4db41a48ace1a4f8180540742ec3dc072?src=pr
[cc-pull]: https://codecov.io/gh/parsingdata/metal/pull/68?src=pr


[Error] Commands/ Plugin not working properly

Server version:
UniverseSpigot version 1.21.1-DEV-ver/1.21.1@9bef923 (2024-10-24T11:51:48Z) (Implementing API version 1.21.1-R0.1-SNAPSHOT)
Universe-1.21.1-DEV-9bef923 (MC: 1.21.1)
Plugin Version: 1.2.7
Description: Plugin starts and seems as functioning but when using the GUI/ Commands it doesnt work and throws the error bellow
Error: https://mclo.gs/SH9DlIZ
Log: https://mclo.gs/k5pe4AC

Hey @TH3N3WN00B,
the issue should be resolved by now! We have released a new version with full 1.21 support!
If there is anything else, feeld free to open a ticket!


Add AbstractLoadBalancerAwareClient examples/tests under ribbon-loadbalancer/src/test

I am trying to implement AbstractLoadBalancerAwareClient but there is no documentation or code samples to learn from.
Would it be possible to ask for a few examples and passing unit tests of an AbstractLoadBalancerAwareClient impl added to source? Or perhaps code examples added to the wiki?

+1


Missing Locale

I

created  new locale de_DE + de_DE_du
modified Plugin.php so that it will accept locale

New branch or what shell we do?
I also can deliver Spanish and French locale.

yeah, you can open a pull request if you like

I created this fork for adding my LOCALE changes.
First tests with download of that version all successful.
Before Pull request I would like to integrate Translations for Tooltipps of  Missing Tooltipps #9


Image for Tic Tac Toe Game not visible

Give a brief about the bug ✍
The image for the game tic tac toe is not visible.
What is the expected behavior? 🤔
I would want to add an image for the same including these games too which do not have any image.
Provide step by step information reproduce the bug 📄

Select program in which you are contributing
GSSoC24
Code of Conduct

[X] I follow CONTRIBUTING GUIDELINE of this project.

Hey @riya-rjha !
Thank you for raising an issue 💗
You can self assign the issue by commenting /assign in comment 😀
Make sure you follow CODE OF CONDUCT and CONTRIBUTING GUIDELINES 🚀
Don’t Forget to ⭐ our GameZone🎮
Make sure you join our Discord🕹

Hey @riya-rjha! 🙂
It seems like you are not following proper guidelines !! 👀
Read documentation properly !!🙏
If you have any queries reach out to us on Discord🕹 .

Hey @riya-rjha ! Thank you so much for your raising the issue💗
It’s all yours, you can come anytime again and make some contributions! 🚀
Alone, we can do little, but together we can do so much! 😇


Update the route pattern for compendia file downloads

Context
Currently, we pass the compendia url value (links to files on S3) as a URL query for downloading files on the download page.
We want to create a clean URL by removing this query value from the route path.
Problem or idea
We should update the route pattern to compendia/[type]/download/[organism_name] and create a dynamic route file that matches this new pattern.
This new page route should handle user-selected compendia computed file downloads.
Solution or next step

Update the navigateToFileDownload method to align with the new route pattern
Update the handleFileDownload in Download:

Adjust the arguments for the navigateToFileDownload call
Remove the downloadCompendia / gtag.trackCompendiaDownload calls

Create a dynamic route for the download page in pages/compendia

Handle compendia computed file downloads and GA tracking

-- Update --
Based on the 1:1 review, we'll also address the following items as part of this process:

Add a context for useCompendia hook to store compendia and type
Return the computed file's download url via useCompendia (no id query)
Use getServerSideProps in the page routes, including[type] and the new [organism_name] route (which will be added in this issue)
Replace the click event for tab change with query.type to update pass active tab to tabs component.


Add Applite to Homebrew

allow installation with homebrew

I opened a pull request: Homebrew/homebrew-cask#152475. The project needs at least 75 stars to be accepted, because it is not notable enough to be on hombebrew.

you need 8 more stars :)

Pull request merged. Applite is now added to Homebrew.


MAINT: add a CODEOWNERS file

As discussed initially in https://mail.python.org/pipermail/scipy-dev/2021-February/024582.html
Note that testing this on a fork is difficult, because review requests aren't triggered for the person who opened the PR, and reviewers must have commit rights (which they typically don't have on a fork). Here is a useful trick to test whether the syntax is correct, by using .gitignore (which obeys the same syntax) instead:
http://www.benjaminoakes.com/git/2018/08/10/Testing-changes-to-GitHub-CODEOWNERS/
I propose that everyone who wants to be added to some file(s) or submodule(s) adds a comment here, and I'll incorporate them all at once, before merging this PR to avoid some churn. We can leave this open for a week or so.
[ci skip]

You can add me for scipy/sparse

Added some categories and my name in https://github.com/rgommers/scipy/pull/18/files, feel free to incorporate via merge or manually

Since I worked on the doc lately, you can add me there I guess.
Also a filter on: scipy/stats/*sobol*

@andyfaff
scipy/optimize    (well a subset of, but there are a lot of files in there).
scipy/stats/_distn_infrastructure
scipy/stats/_continuous_distns
ci/*
.github/*

Can add me for special (limited time recently, but hopefully not a permanent condition).

I'd also appreciate if you can add
scipy/signal/* @ilayn
scipy/linalg/* @ilayn

I should also send the Github forms PR asap.

Addressed all comments made till now.

You can add me for interpolate, stats.distributions and refguide_check

Okay, let's give this a try - merging now so I have time later in the weekend to fix things if there's a hiccup. Thanks everyone.


Is there any way to find out each completion comes from which libs or plugin?

Inspecting tern_ensureCompletionCached() function, its data just contains type, doc and url of each completions so is there any way to get the lib (or plugin) that this completions come from. In defs and plugin files its specified by !name( i.e : ecma5, ecma6, jQuery, node, ... ). is there any way to retrieve it? may you add a function to do so?

Set the query.origins property to true, and you'll get an origin string (the file or definition from which a completion comes)

Could you explain where to find query.origins? @marijnh


Infinite

Thanks for submitting an issue to RGL!
Please mark the type of this issue:

[ ] Bug
[ ] Feature Request
[ ] Question

If you have a question or bug report, please use the WebpackBin Template
to demonstrate. It is much easier for us to help you if you do.

?
On Aug 2, 2017 2:37 PM, "Justin Ramers"<EMAIL_ADDRESS>wrote:

Thanks for submitting an issue to RGL!
Please mark the type of this issue:

Bug
Feature Request
Question

If you have a question or bug report, please use the WebpackBin Template
http://www.webpackbin.com/EJF48h_rz
to demonstrate. It is much easier for us to help you if you do.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/STRML/react-grid-layout/issues/598, or mute the
thread
https://github.com/notifications/unsubscribe-auth/ABJFP9jgFjbCD9HEvN7JGlOJTe0dns29ks5sUNAAgaJpZM4Orjst
.

Sorry didn't mean to submit. Feel free to delete.


opensc: add patch for CVE-2023-2977

Description of changes
https://nvd.nist.gov/vuln/detail/CVE-2023-2977
Change really only affects local function which hasn't been updated since 0.23.0.
Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

@risicle Thanks! I've tested the patch and my smartcard still works, so I'd say mark this pull request as ready and we should get this merged.


User can't register peer by using his username

Here is written login, but I tried with login and it can't register. we can use only e-mail.
Please change this "login" word to "email", or add function to register peer by username:

Blocked by https://github.com/optdyn/hub/issues/6873

How to test:
Enter username rather than email and try to register peer with BZR.
Peer should get registered successfully

Fixed.


use-hooks.org is for sale

thanks for the awesome list

+1, use-hook.org is abandoned

+1, it now redirects to sketchy stuff 🤷♂

Let's merge this 😄


kCGEventOtherMouseUp triggers mousedown, not mouseup

Could be a bug when processing kCGEventOtherMouseUp event.
Current Behavior
mouse down triggered twice on click for other buttons.
Expected Behavior
mouseup triggered
Possible solution
https://github.com/wilix-team/iohook/blob/master/libuiohook/src/darwin/input_hook.c#L1043
		case kCGEventOtherMouseUp:
			// Extra mouse buttons.
			if (CGEventGetIntegerValueField(event_ref, kCGMouseEventButtonNumber) < UINT16_MAX) {
				uint16_t button = (uint16_t) CGEventGetIntegerValueField(event_ref, kCGMouseEventButtonNumber) + 1;

				// Add support for mouse 4 & 5.
				if (button == 4) {
					unset_modifier_mask(MOUSE_BUTTON4);
				}
				else if (button == 5) {
					unset_modifier_mask(MOUSE_BUTTON5);
				}

				process_button_pressed(timestamp, event_ref, button); // should be process_button_released probably
			}
			break;

Your Environment

Version used:
Environment name and version: any
Operating System and version (desktop or mobile): mac

Not really sure if this is a current issue but if I understand correctly, this triggers mousedown when mouseup is clicked? I haven't been able to repro this so closing. If still an issue please provide env details to repro.


basic-java-programs

this file contains basic levels programs of java that help students and a clear concept of aggregation composition etc

Thanks for your contribution!✨


minor cleanups

just starting to use your library, and i found some minor issues, so I thought I'd quickly shoot them over your way.  haven't actually used the library yet, but looks good so far :)
these should be straight forward changes, happy to explain further if needed.

Coverage remained the same at ?% when pulling 002f05646364c1a293458863500f9837788b149c on toppk:master into 2a48803e6e7954813dc1b28e3f826b4a4ef52bc9 on paulokuong:master.

@toppk thanks will take a look

okay.  just switch the import to absolute to the style used elsewhere.

@toppk thanks

@paulokuong @pkuong the tar.gz contents available on pypi for version 0.1.17 of this package (https://pypi.org/project/noaa-sdk/0.1.17/#files) do not match those of the master branch that resulted from merging this pull-request. Do you have plans to release that soon? In python 3.73 envs I get dependency errors that relate to requests 2.21 (which was changed in this branch).
Also, it looks like Requests 2.22.0 dropped support for python 3.4 (https://2.python-requests.org/en/master/community/updates/#id1), so if you need help when it comes to supporting 3.73, let me know.


Optimize README.md to make it more friendly for beginners.

Current issues.
I personally feel that the current documentation quickstart section is not simple enough and not clear enough.
git clone to local, and then build the image locally. The threshold for this operation is high. Not "quick" enough
Solution.
We've done a lot of things to optimize deployment. But we don't reflect it in the documentation. A possible solution.
## Deployment
- [Docker Compose](./doc/compose.md)
- [Helm](./doc/deployment/helm.md)
- [Kubernetes YAML](. /doc/deployment/kubernetes.md)

Also, in the docker compose scenario, it is recommended to use pre-built images instead of local builds

I like the idea of reducing the readme content. It feels like a block of content today.
The kubernetes section in my pr is fairly simple. If we match the docket instructions then that might be one potential improvement.
I’m open to standalone docs too

I agree the README is a bit long and complex, and the Kubernetes part makes it even longer&more complex. The Kubernetes description also has the limitation that it currently doesn’t cover even the basic option (port-forward) to expose the frontend. ⇒ The deployment part can get even longer in the future.
I think splitting the deployment options into separate sub-pages would be a great improvement. I can help with this if needed.

@wph95 do you still have the time to work on this?

Readme is cleaned up


Release 3.1.0

Is there any plans/date to make a stable release of version 3?

Beta versions are giving errors when I'm creating release builds.


Orderbook

I apologize for the question:) Does any of the strategy which analyze the number of orders for purchasing and saling? This information is available via API (ex. https://bittrex.com/api/v1.1/public/getorderbook?market=BTC-LTC&type=both ).   Could this information be used to determine the growth or fall in prices?

I think order graph compared with other strategy like trend ema will be killass

This issue was moved to highvelocityspace/zenbot#50

Dear issue reporter,
We have slightly changed our github issue policy and would now kindly request folks that have questions that they ask them in our zenbot subreddit.
You can find it here: https://reddit.com/r/zenbot
This issue will be closed, but if you disagree with your ticket being marked as a question feel free to leave a comment defending your case.
Thanks for contributing time and effort!
Greetings,
🤖

@kazdimenator I think you want to implement this as a strategy: https://github.com/H-Gomez/btc-books-depth/blob/master/ticker.js


Add Dockerfile, .dockerignore and nginx config for production deployment

Summary
This makes us able to setup CI and actually deploy the website in production.
Testing
docker build . -t imesec/website
docker run -p 5000:5000 imesec/website

We neet to think if we're going to reimplement the /public thingy, and in that case we should probably use nginx-php-fpm.
Othre than that: 🛩

We definitely must reimplement it when we have it ready. This is just a stub of it for now.

Related to #2


Error when trying to export supported markdown

Hi,
I am using the as slides.md and getting a #comment error:
# This is a title slide
## Your name here
---
# This is a section title
---
# Section title & body slide
## This is a subtitle
This is the body
---
# Title & body slide
This is the slide body.
---
# This is the main point {.big}
---
# 100% {.big}
This is the body
---
# Two column layout
This is the left column
{.column}
This is the right column
---
# Slides can have images
![](https://placekitten.com/900/900)
---
# Slides can have background images
![](https://placekitten.com/1600/900){.background}
---
# Slides can have videos
@[youtube](MG8KADiRbOU)
---
# Slide title
![](https://placekitten.com/1600/900){.background}
<!--
These are speaker notes.
-->
---
**Bold**, *italics*, and ~~strikethrough~~ may be used.

Ordered lists:
1. Item 1
1. Item 2
  1. Item 2.1

Unordered lists:
* Item 1
* Item 2
  * Item 2.1
---
### I :heart: cats
:heart_eyes_cat:
---
### Hello World
```javascript
console.log('Hello world');

Error:
Unable to generate slides: Error: Unsupported inline HTML element: #comment
    at inlineTokenRules.html_inline (/usr/lib/node_modules/md2gslides/lib/extract_slides.js:274:23)
    at processMarkdownToken (/usr/lib/node_modules/md2gslides/lib/extract_slides.js:84:9)
    at inlineTokenRules.inline (/usr/lib/node_modules/md2gslides/lib/extract_slides.js:229:13)
    at processMarkdownToken (/usr/lib/node_modules/md2gslides/lib/extract_slides.js:84:9)
    at processTokens (/usr/lib/node_modules/md2gslides/lib/extract_slides.js:73:9)
    at extractSlides (/usr/lib/node_modules/md2gslides/lib/extract_slides.js:61:5)
    at SlideGenerator.generateFromMarkdown (/usr/lib/node_modules/md2gslides/lib/slide_generator.js:86:27)
    at generateSlides (/usr/lib/node_modules/md2gslides/bin/md2gslides.js:179:27)
    at tryCallOne (/usr/lib/node_modules/md2gslides/node_modules/promise/lib/core.js:37:12)
    at /usr/lib/node_modules/md2gslides/node_modules/promise/lib/core.js:123:15
    at flush (/usr/lib/node_modules/md2gslides/node_modules/asap/raw.js:50:29)
    at process._tickCallback (internal/process/next_tick.js:61:11)
Error: Unsupported inline HTML element: #comment
    at inlineTokenRules.html_inline (/usr/lib/node_modules/md2gslides/lib/extract_slides.js:274:23)
    at processMarkdownToken (/usr/lib/node_modules/md2gslides/lib/extract_slides.js:84:9)
    at inlineTokenRules.inline (/usr/lib/node_modules/md2gslides/lib/extract_slides.js:229:13)
    at processMarkdownToken (/usr/lib/node_modules/md2gslides/lib/extract_slides.js:84:9)
    at processTokens (/usr/lib/node_modules/md2gslides/lib/extract_slides.js:73:9)
    at extractSlides (/usr/lib/node_modules/md2gslides/lib/extract_slides.js:61:5)
    at SlideGenerator.generateFromMarkdown (/usr/lib/node_modules/md2gslides/lib/slide_generator.js:86:27)
    at generateSlides (/usr/lib/node_modules/md2gslides/bin/md2gslides.js:179:27)
    at tryCallOne (/usr/lib/node_modules/md2gslides/node_modules/promise/lib/core.js:37:12)
    at /usr/lib/node_modules/md2gslides/node_modules/promise/lib/core.js:123:15
    at flush (/usr/lib/node_modules/md2gslides/node_modules/asap/raw.js:50:29)
    at process._tickCallback (internal/process/next_tick.js:61:11)
{}

Just trying to see everything md2googleslides supports in markdown.
Thanks

I had this same issue and it turned out that it was due to a lack of newline between the comment and the --- that designates the slide break. In general it seems like the markdown lexer is sensitive to newlines being put between a slide break and content that needs to be parsed. Hope this helps.

I had this same issue and it turned out that it was due to a lack of newline between the comment and the --- that designates the slide break. In general it seems like the markdown lexer is sensitive to newlines being put between a slide break and content that needs to be parsed. Hope this helps.

Cheers while1malloc0 - that was it!


line highlighting in vimoutliner changes only every 2nd

Expected Behavior
in a vimoutliner file, line color changes every level of indentation
Current Behavior
it changes only every 2 levels
Context
see here:
https://github.com/vimoutliner/vimoutliner/issues/166
My Environment

MacVim current

VIM - Vi IMproved 8.1 (2018 May 18, compiled Oct 30 2019 11:57:56)
macOS version
Included patches: 1-2234

I can't fix that because it will break a lot of the syntax highlighting. Maybe you can try changing the color of the statements when you are using the plugin
hi Statement guifg=#f43753 ctermfg=153 guibg=NONE ctermbg=NONE gui=NONE cterm=NONE


a problem arise when i create gateway and virutalservice

below is my configuration:

when  i  acccess http://<IP_ADDRESS>/php/ (request default index.php)  is ok below:

but when i access http://<IP_ADDRESS>/php/phpinfo.php  it is back 404 below

how i can resolve this problem

Could you please upload a simple screenshot about the configuration of your pod "nginx-php"  ?

below is my configuration of “nginx-php”

under the web document, phpinfo.php and index.php avalaiable but i can only access index.php when i config gateway and virtualservice

who can help me i will appreaction for you helping

below is my configuration of “nginx-php”

I don't even understand how the image of ngnix-php looks like. Whatever all my instinct tell me that
http://<IP_ADDRESS>/php/phpinfo.php is unknown from your ngnix-php Pod.
Please try to complete the process of treatment when a request comes in.
In other words, how to make your application ngnix-php to apply the page phpinfo.php when it receives  http://<IP_ADDRESS>/php/phpinfo.php from others ?

@bruse-peng Are you able to perform the request from inside the Nginx-php container? Calling localhost/php/ and localhost/php/phpinfo.php?


blairmorite, grumblesome

This pull request was generated by the 'mq' tool
[test]
flake rate: 0.4
logical conflict every: 100
sleep for: 300s
[pullrequest]
requests per hour: 30
deps=[b,g]

/trunk merge


ion-split-pane center issue for date, toast etc.

Ionic version:  (check one with "x")
[X] 3.x
I'm submitting a ...  (check one with "x")
[X] bug report
Current behavior:
date (ion-picker-cmp), toast (ion-toast) etc. show at the center of the screen and not at the center of the main content.
Expected behavior:
@mhartington said in the slack channel that it should be in the center
Steps to reproduce:

Ionic info:

Hello! Thank you for opening an issue with us! Would you be able to provide a sample application via GitHub that demonstrates the issue you are having?
It would help greatly for verification and testing when we look into this.
Thanks for using Ionic!

Hi @kensodemann

https://github.com/yoffe/ionsplitpanecenter

Excellent! Thank you very much!

I don't think this is an issue at all. Modals, actionsheets, alerts, toast etc. are screen wide components that are designed to disrupt the user interaction so all the user focus goes to the component.
cc @mhartington have you seen the opposite behavior in natives apps or documented by Apple?
From a technical point of view, it would not be easy to do that.

Same can be applied to datetime and toast. This issue is a "won't fix" to me


Fix #84, Add GIT SHA

Describe the contribution
Adds GIT SHA's to Travis log.
Testing performed
Checked the travis log for this branch.
Contributor Info - All information REQUIRED for consideration of pull request
<EMAIL_ADDRESS>

CCB 20200520 - APPROVED


Is it possible to define locally referenced components in external schema objects?

Can an externally $ref'd Schema Object have its own locally defined set of #/components (or #/definitions)?
For example:
File: openapi.yml
openapi: 3.0.2
...
paths:
  /Foo:
    $ref: './endpoints/Foo/paths.yml'

File: ./endpoints/Foo/paths.yml
post:
  operationId: PostFoo
  ...
  requestBody:
    content:
      application/vnd.api+json:
        schema:
           $ref: './post/requestBody.yml'

File: ./endpoints/Foo/post/requestBody.yml
type: object
properties:
  data:
    oneOf:
      - $ref: "#/definitions/SimpleRequest" # Locally defined below
      - $ref: "#/definitions/ExtendedRequest" # Locally defined below
definitions:
  SimpleRequest:
    type: object
    properties:
      type:
        type: string
        enum:
          - SimpleRequest
      attributes:
        type: object
        properties:
          ...

I've searched and searched but so far have found no information on the subject.

My understanding is yes, you can ansolutely do this. There is no requirement that externally referenced documents comply with any specific schema, so components , definitions or portrezeebie are all fine.
When it comes to scope and fragment ids, the rule appears to be that the whole of the included document is in scope for local $ref resolution, then it is constrained by the fragment id prior to inclusion.

I also wrote a blog post which touched on this https://dev.to/mikeralphson/defining-reusable-components-with-the-openapi-specification-4077

@MikeRalphson, thanks for the response. I did come across your blog post in my research.
What prompted my post is errors I'm receiving trying to validate using the tool swagger-cli validate openapi.yml.
I assume it's validating against an OpenAPI schema that says you can't have additional properties defined for Schema Objects.
Swagger schema validation failed.
  Data does not match any schemas from 'oneOf' at #/paths//Foo/post/requestBody
    Data does not match any schemas from 'oneOf' at #/paths//Foo/post/requestBody/content/application/vnd.api+json/schema

      **Additional properties not allowed: definitions at #/content/application/vnd.api+json/schema**

      Missing required property: $ref at #/content/application/vnd.api+json/schema
    Missing required property: $ref at #/paths//Foo/post/requestBody

Your post got me thinking and I believe I've found a solution to my problem.
If I rework things a bit, so that my $ref targets a parent element inside the external document, the validation tool is happy. I called it schema for lack of a better word.
File: openapi.yml
openapi: 3.0.2
...
paths:
  /Foo:
    $ref: './endpoints/Foo/paths.yml'

File: ./endpoints/Foo/paths.yml
post:
  operationId: PostFoo
  ...
  requestBody:
    content:
      application/vnd.api+json:
        schema:
           $ref: './post/requestBody.yml#/schema' # <-- Target the schema element in the external doc.

File: ./endpoints/Foo/post/requestBody.yml
schema: # <-- Schema object is now under a parent element. The $ref targets this element.
  type: object
  properties:
    data:
      oneOf:
        - $ref: "#/definitions/SimpleRequest" # Locally defined below
        - $ref: "#/definitions/ExtendedRequest" # Locally defined below
definitions: # <-- We get to keep definitions, it doesn't get included into the parent document.

The validation tool is happy:
swagger-cli validate openapi.yml
openapi.yml is valid

Their bundle tool that creates a single openapi.yml file after resolving references works as expected too.
This makes perfect sense to me now that I've worked it out, but the road to get here was a bit rough.

Yes, wrapping your schema to keep definitions out of the scope of what's actually included is the way to go. Glad you got it sorted. Some things may be in the pipeline which will help others hitting this problem going forward.


IconLayer not rendering

I am trying to render png icons over a map, but the IconLayer isn't rendering.
I have tried rendering other types of layers, and they render fine.
My code is as follows:
`const ICON_MAPPING = {
marker: {x: 0, y: 0, width: 32, height: 32, mask: false}
};
const layer = new IconLayer({
    id: 'icon-layer',
    data: this.props.data,
    iconAtlas: planeImg,
    iconMapping: ICON_MAPPING,
    getPosition: d => d.position,
    getAngle: d => d.angle,
    getIcon: d => d.icon,
    getColor: d => d.color || [0, 0, 0, 255],
    getSize: d => d.size || 24,
    sizeScale: 1,
    opacity: 1,
    pickable: true,
    radiusMinPixels: 2,
    radiusMaxPixels: 30,
    visible: true,
})`

Any help people could give would be greatly appreciated!

For icon layer you don't need radiusMinPixels and radiusMaxPixels, but other props look ok to me, unless the data you are providing has some issue. Can you enable logging as below and see if any errors/warning are logged ?
"luma.log.priority=2" and "deck.log.priority=2" in browser console

How big is the iconAtlas texture planeImg? You are basically showing a 32x32 pixel section, maybe that part is transparent?
How are you specifying/loading the texture?
Any warnings in the console?

Thanks for your help. You were right, I was showing a transparent section of the image


Action space clarification

Hi,
I wanted to confirm that the action space consists of the end-effector position and orientation displacement (along with the gripper state). Are these displacements/delta values in the world frame or the end-effector frame? Also, is there some way to know what the initial position of the robot arm is (from the datasets)?
Thanks!

Did you ever figure this out? I think knowing this is very important, and the original octo paper does not state the coordinate frame clearly.

I have looked at some of the datasets comprising OXE and I'm not convinced they are all the same... but yes I agree that most of them are deltas in the "base frame" (which will be different for every robot of course)


Atom sometimes doesn't load the project on window reload in dev mode

I haven't found solid reproduction steps for this, but sometimes when I'm working on an Atom package, Atom doesn't reload the project after a window reload. It makes working on packages a real pain, because I have to open the project folder from Atom again and again.
Here's what I do:

cd to project dir, e.g. cd ~/projects/atom/minimap-codeglance
apm link -d
atom -d
Make some edits to some files
Run window:reload command with keybinding ctrl-alt-r (haven't tested running it from the command palette or the menu)
BUG (doesn't happen all the time) Atom opens an empty window, no tree view, no open files, nothing. I can open the project I was working on with ctrl-shift-o and all is fine. Expected Atom opens the project folder I was working on, shows it in the tree view and opens files that were open when I hit reload.

This is using Atom 1.0.8-a8e80a2 on Debian 9
I'll let you know if I find 100% reproduction steps.

Does this happen if you run Atom in safe mode? When it happens, it may mean that an exception was thrown during the window's teardown process. Can you check the Preserve log box in the javascript console and report if you see any errors?

Doesn't happen right now, but I'll keep Preserve log on for now (never noticed it, so thanks!) and check if it's something in the window teardown process.

Ok, I'm going to close this out for now, but I'll reopen if you find that something's happening in safe mode. Thanks!


Include RPC endpoints in OpenAPI output

I still have to add more details to the OpenAPI response but the majority of the work is done. Thought I'd share the code at this stage for your feedback.
One big problem is there are no tests for what I've done. I've been testing the results by hand in Swagger UI. It's challenging to write the tests because we load a huge database fixture for all tests and it generates a big OpenAPI description. I would/will have to write tests that dig into that JSON structure.
The huge fixture has been a pain for testing for a long time. I would prefer to have each test create the necessary structure in a database transaction and then roll back afterwards. The big problem here is that PostgREST caches the db structure on start, and I'm not sure how to reload the server (or send it SIGHUP) on every test to refresh that cache.
Fixes #694
Big thanks to @LogvinovLeon who helped me kick off this PR at our local SF Haskell hack night.

Could you post here some of the responses you get back from a GET and OPTIONS request for the docroot? I could send you a ddl for a db with the authentication functions setup similar to the examples, permissions, as well as some crazy views.

@rkoberg thanks, I figured out how to use aeson-lens to pick apart the openapi response in a test. I'll add a few more tests and this PR should be good to go. We'll save the fixture refactor for later.

Able to parse more complicated proc args now. However it will fail for args with spaces or escaped quotes in their names. Any suggestions for a more robust way to parse this?

As discussed in Gitter room we'll just file an issue about arguments with names containing spaces or escape sequences. It's an edge case and we'll see if it causes any problems.
Tomorrow I'll probably finish this PR by adding OpenAPI information about the headers that RPC calls accept and any other relevant info.

Actually the headers reported by swagger need an update across the board. I'll do that in a separate PR and include headers for RPC there as well.


Replace SHA1 with bcrypt for local authentication

I've made some simple changes to my fork to use bcrypt-nodejs to provide more secure, salted password hashes.  I've verified that I can successfully create passwords and subsequently log in using this code, but haven't extensively tested it (or, indeed, know what testing needs to be done apart from simply verifying that I can log in).
The bcrypt-nodejs project uses a 3-clause BSD license, which I believe is compatible with jingo's MIT license, but I'd like to get confirmation from someone who understands these things better than I.
Any comments or suggestions for improvement before this is ready for a pull request?

Hi,
I don't see any particular problem for that to happen, unless of course it could pose a backward compatibility problem. I try to maintain Jingo as simple as possible, for the user to install and maintain and for me to maintain it. Do you think that this would be a drop-in replacement for an existing (possibly 2 or 3 years old) installation or would it be a breaking change? Would we need to add a specific condition in the configuration file, something like "useCrypt: bcrypt" (defaulting to the previous one?)
Looking at your code it seems that this is the case (old password won't work anymore if you just update jingo).

You're right, this is the case.  It would work fine for new installations, but break all the passwords for an existing one.
I could add the config option.  Another possibility is to default to bcrypt for creating new passwords, but when verifying an existing password, try the old SHA1 hashing if bcrypt doesn't verify.  That way, everyone's current password continues to work, but if/when they change their password, it will use the more secure hash.  From the end user's standpoint it would be completely transparent.


feat(points): Reduce trackPointsEvent usage

Description
Taking another crack at #5631. Updated following a discussion with @kathaypacific. Now, events that are already emitted simply have properties required by the point system added on, without encoding any points semantics explicitly.
Test plan
Unit and manual tested; points are still earned for performing expected tasks.
Related issues

Fixes #[issue number here]

Backwards compatibility

Network scalability
If a new NetworkId and/or Network are added in the future, the changes in this PR will:

[x] Continue to work without code changes, OR trigger a compilation error (guaranteeing we find it when a new network is added)

@kathaypacific We actually do still use trackPointsEvent in one place atm, when fetching transaction receipts when watching pending transactions. We do this since we don't already emit an event here. We could of course avoid this by emitting a new different event, under e.g., src/transactions/actions.ts that has no knowledge of points semantics. We'd have to do this for every such case however, so I don't know if it would necessarily be better than the current solution.


Added Obafemi Awolowo University Domain

Addition of Obafemi Awolowo University Ile-Ife, Nigeria. Domain

School Website - http://www.oauife.edu.ng
Emails are of the form -<EMAIL_ADDRESS>Thanks in advance

@zweizwei Please merge this.
Thanks

@goke-epapa sorry for the delay, merging the request

Thanks @zweizwei  :)


boxpctiles does not draw boxes

Description
I think there's a minor bug when adding on-the-fly box plots to scatter, line, and bar charts. boxpctile works as expected, but the equivalent boxpctiles has no effect.
Steps to reproduce
import proplot as pplt
import numpy as np
import pandas as pd

data = np.full((100,10),fill_value=np.nan)

np.random.seed(1999)
mu = np.random.randint(10,21,10)
sigma = np.random.randint(1,5,10)

for i in range(0,10):
    data[:,i] = np.random.normal(mu[i],sigma[i],100)

data = pd.DataFrame(data)

fig, axs = pplt.subplots(ncols=2, aspect=(1.5,1))

axs[0].bar(data, medians=True, barpctile=(5,95), boxpctile=True, ec='k', c='yellow5')
axs[1].bar(data, medians=True, barpctile=(5,95), boxpctiles=True, ec='k', c='yellow5') #No boxes appear here

Proplot version
matplotlib=3.5.2
proplot=0.9.5.post332

Thanks for the report. This was indeed a bug -- just a typo (fixed by f6cc8b9).


CStoppableSGObject class

[WIP] This simply takes all premature stopping code and places it in a new class. Most of the python legacy examples broke locally. I am struggling with the swig part.

@vigsterkr see CMachineEvaluation and CMachine. There is some duplicate code. (also CMachineEvaluation can be a non machine use case too)

Great! :+1: I've added some comments, but it seems okay already. I guess that for fix the errors on Travis you should add this new file "StoppableSGObject.h" to SWIG (since here https://travis-ci.org/shogun-toolbox/shogun/jobs/377448506#L1715 CStoppableSGObject is ignored). Please have a look at SGBase.i to see how it's done for other base classes

Nice one!


External data store and composable architecture?

I have a question regarding external data stores (e.g. a database) that could potentially contain a large amount of data and how to reconcile that with TCA.
Assuming that ALL data cannot be loaded into the app state (into memory), what best practices can be recommended for managing this?
For example, querying the database for subsets of data for things like paging. How does this reconcile with reducers and pullbacks, or at least, how do you recommend it reconcile?
Thanks.

@pcolton I'll let others weigh in with more ideas, but I think one common approach is optionalize portions of your app's state and nil them out when they're not needed. This could be done by sending actions at onAppear and onDisappear that load and unload the view's data, or during navigation.

Thanks. I'd love to hear how people are managing loading of data as well as persisting mutations of their data (for example, do you save to your database right at mutation time or some other time later, like a global save of state).

In my case I treat the Database as any other dependencies and database operations happen in Effects, the result of that operation then emits an action that updates the state. Alternatively I've considered other two other approaches:

Do state updates optimistically and then fire the effect to update the database. In the improbable case that there's an error I should be able to roll back the state change.
Fire the effect and then with a subscription to the Database update the state somewhere else when the DB operation succeeds.

I'm using the first approach because it's the simpler to implement. I'm still not really sure which one is the best.
When it comes to loading there's an action that triggers it, and then state would update one way or the other depending on what of the above methods you are using.
Pagination could be done by adding the current page and limit to the state and have a reducer handle the database request appropriately. But I haven't done anything like that yet.


New collision mesh results in additional occupied space in the costmap

Hi PAL team,
After applying the following change, the laser sensor will produce extra noises (two blue squares) under the robot base.
https://github.com/pal-robotics/pmb2_robot/commit/6f2f482804f174457056a6f1d323dbd6d1d5b2b3#diff-ad08db4e382cb0e728defe237a9f3c1e5182555d33df65e413a7b74289504ce6R60

These noises will cause additional occupied space in the costmap.

Once I rollback this change, the noise will disappear, like the following image.

I don’t know if this is a bug or a new feature for TIAGO. :sweat_smile:

@v-lopez

Hi @kyouma9s I apologise for not seeing this earlier, thanks for the ping.
I'm trying to reproduce this locallly but can't. Can you share how are you launching the simulation?
Also could you enable collision view in gazebo window, and send me a screenshot of where the laser intersects with the base?
For me it doesn't

Hi @v-lopez
This problem can be reproduced in Rviz.
1. Follow this tutorial http://wiki.ros.org/Robots/TIAGo/Tutorials/Navigation/Localization
2. Start the navigation demo by
roslaunch tiago_2dnav_gazebo tiago_navigation.launch public_sim:=true

Try to use the nav tool of Rviz to make robot reach somewhere, you will see occupied costmap behind the robot.


Investigate copy out via AWS transfer family

https://docs.aws.amazon.com/transfer/latest/userguide/what-is-aws-transfer-family.html

I think this one would only be needed when interfacing with more legacy destinations like SFTP.

We will get most of this functionality with #261

I'm not sure we haven't already built most of the equivalence to this service.


Slow push against private registry for already uploaded images (due to manifests)

docker push in master is painfully slow. Pushing an image that is already pushed to the registry takes 42 seconds!
web605 ~ # time docker push docker.core.tf/topface-prod-app:20150122009
The push refers to a repository [docker.core.tf/topface-prod-app] (len: 1)
Sending image list
Pushing repository docker.core.tf/topface-prod-app (1 tags)
Image b18d0a2076a1 already pushed, skipping
Image 25c4824a5268 already pushed, skipping
Image 67b66f26d423 already pushed, skipping
Image 8b1c48305638 already pushed, skipping
Image 511136ea3c5a already pushed, skipping
Image c900195dcbf3 already pushed, skipping
Image 9d9561782335 already pushed, skipping
Image 6b4e8a7373fe already pushed, skipping
Image c27763e1f3e5 already pushed, skipping
Image d5199f68b2fe already pushed, skipping
Image bad562ead0dc already pushed, skipping
Image cf39b476aeec already pushed, skipping
Image 64463062ff22 already pushed, skipping
Image f3529e909ef6 already pushed, skipping
Image fc98f0324f03 already pushed, skipping
Image c44ba4e6e179 already pushed, skipping
Image da662fffdcfc already pushed, skipping
Image 9430c1ba71ec already pushed, skipping
Image 16f0d302f2a1 already pushed, skipping
Image 61cadf3f1b21 already pushed, skipping
Image b729d5ec6bc7 already pushed, skipping
Image faf76117ea89 already pushed, skipping
Image 9bce9f428093 already pushed, skipping
Image 250777f42f02 already pushed, skipping
Pushing tag for rev [9bce9f428093] on {https://docker.core.tf/v1/repositories/topface-prod-app/tags/20150122009}

real	0m42.665s
user	0m0.010s
sys	0m0.010s

Manifests are to blame:
web605 ~ # time curl -s http://web605:2375/v1.17/images/docker.core.tf/topface-prod-app/manifest?tag=20150122009 > /dev/null

real	0m56.246s
user	0m0.000s
sys	0m0.000s

I'm using devicemapper, unfortunately, and a lot of mounts/unmounts happen to calculate manifest. After looking at perf report it seems that sha sums are calculated too.
@dmcgowan, any ideas? #9784 introduced manifests.

Can't say I have seen a manifest calculation take this long.  For some of the bigger images locally I have only seen a few seconds.  What is your daemon running on and how large is the image you are pushing.  Our plan to improve performance is to calculate the checksum earlier and save the result with the layer since calculating the checksum before pushing the layer cannot be avoided.

I'm on Intel(R) Xeon(R) CPU E5-1650 v3 @ 3.50GHz x 8, 64Gb ram, 2 x 4tb disks in mirror raid on ext4.
Containers: 1
Images: 95
Storage Driver: devicemapper
 Pool Name: docker-9:127-216399942-pool
 Pool Blocksize: 65.54 kB
 Data file: /var/lib/docker/devicemapper/devicemapper/data
 Metadata file: /var/lib/docker/devicemapper/devicemapper/metadata
 Data Space Used: 36.35 GB
 Data Space Total: 107.4 GB
 Metadata Space Used: 28.14 MB
 Metadata Space Total: 2.147 GB
 Library Version: 1.02.82-git (2013-10-04)
Execution Driver: native-0.2
Kernel Version: 3.14.18-gentoo
Operating System: Gentoo/Linux
CPUs: 12
Total Memory: 62.88 GiB
Name: web605
ID: PX6Q:WUI3:WVTL:YTYF:GD33:MRKV:DGW3:GJZX:N4R3:SQNK:D3LV:KVVF
Debug mode (server): true
Debug mode (client): false
Fds: 12
Goroutines: 13
EventsListeners: 0
Init Path: /usr/bin/docker
Docker Root Dir: /var/lib/docker

web605 ~ # docker images | fgrep docker.core.tf/topface-prod-app | fgrep<PHONE_NUMBER>2
docker.core.tf/topface-prod-app<PHONE_NUMBER>2         3c6a94c3d67b        4 hours ago         1.781 GB

web605 ~ # docker history docker.core.tf/topface-prod-app:20150122032 | awk '{ print $1, $(NF-1), $NF }'
IMAGE BY SIZE
3c6a94c3d67b 493.1 MB
ccfd8bd6fb37 170.4 MB
59276f963b65 1.052 kB
61cadf3f1b21 0 B
b729d5ec6bc7 147.5 MB
16f0d302f2a1 0 B
da662fffdcfc 0 B
9430c1ba71ec 0 B
fc98f0324f03 589.5 MB
c44ba4e6e179 91.26 MB
f3529e909ef6 0 B
cf39b476aeec 0 B
64463062ff22 94.11 MB
d5199f68b2fe 25.01 kB
bad562ead0dc 0 B
9d9561782335 0 B
c27763e1f3e5 0 B
6b4e8a7373fe 0 B
c900195dcbf3 2.073 MB
8b1c48305638 1.895 kB
25c4824a5268 0 B
67b66f26d423 194.5 kB
b18d0a2076a1 192.5 MB
511136ea3c5a 0 B

The last layer has 65k files and can be compressed to 70mb.
Looks like currently docker does checksum calculation for all layers, even for those that are in the registry already.

Here are a simple test I made with the docker-registry image:
Docker 1.4, image already pushed:
root@loft:~# time docker push dmp42/testthing

real	0m27.386s
user	0m0.020s
sys	0m0.020s

Details about that image:

root@loft:~# ./docker-1.5.0 history dmp42/testthing | awk '{ print $1, $(NF-1), $NF }'
IMAGE BY SIZE
ef52bca44f4a 0 B
5814bb80d082 0 B
e076a4d2c1ff 0 B
1b5e0b6575ab 0 B
d60b4cb7bfc6 20.14 MB
f72a12be5076 8.437 MB
d7787bddb957 73 B
80ad7b347d51 460.2 kB
2224b5741b7d 40.79 MB
b0701ca82036 134.9 MB
b9d6482cb980 1.765 MB
f9504ebf2ccf 20.28 MB
9bd07e480c5b 0 B
e1cdf371fbde 1.895 kB
30541f8f3062 194.8 kB
01bf15a18638 192.5 MB
511136ea3c5a 0 B

I have to setup docker-1.5 to obtain a comparison.
Bottom-line:

we certainly need to work on caching tarsums between runs to avoid repeated computation and can expect a good speed boost with that
more comparison datapoints are necessary to properly evaluate the current behavior impact, given docker <= 1.4 using v1 was quite slow (for other reasons)

@dmp42 hey, that's not fair! You used docker hub, but I used local registry. My local registry is <1ms and 1Gbps away.
Here's what I see on 1.4.1 over shitty vpn on Intel(R) Pentium(R) Dual  CPU  T3400  @ 2.16GHz:
time docker push docker.core.tf/topface-prod-app:20150122032
The push refers to a repository [docker.core.tf/topface-prod-app] (len: 1)
Sending image list
Pushing repository docker.core.tf/topface-prod-app (1 tags)
Image 511136ea3c5a already pushed, skipping
Image b18d0a2076a1 already pushed, skipping
Image 67b66f26d423 already pushed, skipping
Image 25c4824a5268 already pushed, skipping
Image 8b1c48305638 already pushed, skipping
Image c900195dcbf3 already pushed, skipping
Image 6b4e8a7373fe already pushed, skipping
Image c27763e1f3e5 already pushed, skipping
Image 9d9561782335 already pushed, skipping
Image bad562ead0dc already pushed, skipping
Image d5199f68b2fe already pushed, skipping
Image 64463062ff22 already pushed, skipping
Image cf39b476aeec already pushed, skipping
Image f3529e909ef6 already pushed, skipping
Image c44ba4e6e179 already pushed, skipping
Image fc98f0324f03 already pushed, skipping
Image 9430c1ba71ec already pushed, skipping
Image da662fffdcfc already pushed, skipping
Image 16f0d302f2a1 already pushed, skipping
Image b729d5ec6bc7 already pushed, skipping
Image 61cadf3f1b21 already pushed, skipping
Image 59276f963b65 already pushed, skipping
Image ccfd8bd6fb37 already pushed, skipping
Image 3c6a94c3d67b already pushed, skipping
Pushing tag for rev [3c6a94c3d67b] on {https://docker.core.tf/v1/repositories/topface-prod-app/tags/20150122032}

real	0m4.342s
user	0m0.029s
sys	0m0.016s

And the same on production machine described above, 1.4.1 too:
time docker push docker.core.tf/topface-prod-app:20150122032
The push refers to a repository [docker.core.tf/topface-prod-app] (len: 1)
Sending image list
Pushing repository docker.core.tf/topface-prod-app (1 tags)
Image 511136ea3c5a already pushed, skipping
Image b18d0a2076a1 already pushed, skipping
Image 67b66f26d423 already pushed, skipping
Image 25c4824a5268 already pushed, skipping
Image 8b1c48305638 already pushed, skipping
Image c900195dcbf3 already pushed, skipping
Image 6b4e8a7373fe already pushed, skipping
Image c27763e1f3e5 already pushed, skipping
Image 9d9561782335 already pushed, skipping
Image bad562ead0dc already pushed, skipping
Image d5199f68b2fe already pushed, skipping
Image 64463062ff22 already pushed, skipping
Image cf39b476aeec already pushed, skipping
Image f3529e909ef6 already pushed, skipping
Image c44ba4e6e179 already pushed, skipping
Image fc98f0324f03 already pushed, skipping
Image 9430c1ba71ec already pushed, skipping
Image da662fffdcfc already pushed, skipping
Image 16f0d302f2a1 already pushed, skipping
Image b729d5ec6bc7 already pushed, skipping
Image 61cadf3f1b21 already pushed, skipping
Image 59276f963b65 already pushed, skipping
Image ccfd8bd6fb37 already pushed, skipping
Image 3c6a94c3d67b already pushed, skipping
Pushing tag for rev [3c6a94c3d67b] on {https://docker.core.tf/v1/repositories/topface-prod-app/tags/20150122032}

real	0m2.309s
user	0m0.010s
sys	0m0.000s

This is 10-20x faster than with manifests. 1.4 is fast enough for already pushed images (can be much faster of course) and 1.5 is slow. I can push 2 final layers of my main image in 50s on 1.4.1 with cgzip. With 1.5 I need the same time to only start thinking about pushing something.

@bobrik Ahhhh, I see :-) - this is why we need to make the data-points very clear.
Sorry for I failed to figure the "private registry" part.
Indeed, there, you certainly are impacted heavily by this.
Definitely, caching tarsums are certainly the best optimization road here.

@dmcgowan, @crosbymichael, it is still very bad.  Compare to 1.4.1:
web605 ~ # time docker push docker.core.tf/topface-prod-app:20150127001
The push refers to a repository [docker.core.tf/topface-prod-app] (len: 1)
Sending image list
Pushing repository docker.core.tf/topface-prod-app (1 tags)
Image 511136ea3c5a already pushed, skipping
Image 53f858aaaf03 already pushed, skipping
Image 837339b91538 already pushed, skipping
Image 615c102e2290 already pushed, skipping
Image b39b81afc8ca already pushed, skipping
Image 8254ff58b098 already pushed, skipping
Image ec5f59360a64 already pushed, skipping
Image 2ce4ac388730 already pushed, skipping
Image 2eccda511755 already pushed, skipping
Image 5a14c1498ff4 already pushed, skipping
Image 019d29f39bf6 already pushed, skipping
Image 136b52dd44bf already pushed, skipping
Image 7e5f27d8ce8c already pushed, skipping
Image f9a69b5faaa2 already pushed, skipping
Image 31e2ed1ba38e already pushed, skipping
Image b3b3def7d4fb already pushed, skipping
Image e7f288f51f9c already pushed, skipping
Image a63599c49dcf already pushed, skipping
Pushing tag for rev [a63599c49dcf] on {https://docker.core.tf/v1/repositories/topface-prod-app/tags/20150127001}

real	0m1.701s
user	0m0.000s
sys	0m0.010s

Is this with the latest version of docker/distribution for the private
registry too?
On Wednesday, January 28, 2015, Ian Babrou<EMAIL_ADDRESS>wrote:

@dmcgowan https://github.com/dmcgowan, @crosbymichael
https://github.com/crosbymichael, it is still very bad.  Compare to
1.4.1:
web605 ~ # time docker push docker.core.tf/topface-prod-app:20150127001
The push refers to a repository [docker.core.tf/topface-prod-app] (len: 1)
Sending image list
Pushing repository docker.core.tf/topface-prod-app (1 tags)
Image 511136ea3c5a already pushed, skipping
Image 53f858aaaf03 already pushed, skipping
Image 837339b91538 already pushed, skipping
Image 615c102e2290 already pushed, skipping
Image b39b81afc8ca already pushed, skipping
Image 8254ff58b098 already pushed, skipping
Image ec5f59360a64 already pushed, skipping
Image 2ce4ac388730 already pushed, skipping
Image 2eccda511755 already pushed, skipping
Image 5a14c1498ff4 already pushed, skipping
Image 019d29f39bf6 already pushed, skipping
Image 136b52dd44bf already pushed, skipping
Image 7e5f27d8ce8c already pushed, skipping
Image f9a69b5faaa2 already pushed, skipping
Image 31e2ed1ba38e already pushed, skipping
Image b3b3def7d4fb already pushed, skipping
Image e7f288f51f9c already pushed, skipping
Image a63599c49dcf already pushed, skipping
Pushing tag for rev [a63599c49dcf] on {https://docker.core.tf/v1/repositories/topface-prod-app/tags/20150127001}
real    0m1.701s
user    0m0.000s
sys 0m0.010s
—
Reply to this email directly or view it on GitHub
https://github.com/docker/docker/issues/10269#issuecomment-71796383.

Nope, I'm using registry 0.9. In fact, it doesn't matter:
web605 ~ # docker tag docker.core.tf/topface-prod-app:20150127001 aint-nobody-got-that-domain.be.sure/topface-prod-app:20150127001
web605 ~ # time docker push aint-nobody-got-that-domain.be.sure/topface-prod-app:20150127001
FATA[0031] Error: v1 ping attempt failed with error: Get https://aint-nobody-got-that-domain.be.sure/v1/_ping: dial tcp: lookup aint-nobody-got-that-domain.be.sure: no such host. If this private registry supports only HTTP or HTTPS with an unknown CA certificate, please add `--insecure-registry aint-nobody-got-that-domain.be.sure` to the daemon's arguments. In the case of HTTPS, if you have access to the registry's CA certificate, no need for the flag; simply place the CA certificate at /etc/docker/certs.d/aint-nobody-got-that-domain.be.sure/ca.crt

real	0m31.848s
user	0m0.020s
sys	0m0.000s

Damn ya that's pretty slow, I'll try to run a few test tomorrow
On Wednesday, January 28, 2015, Ian Babrou<EMAIL_ADDRESS>wrote:

Nope, I'm using registry 0.9. In fact, it doesn't matter:
web605 ~ # docker tag docker.core.tf/topface-prod-app:20150127001 aint-nobody-got-that-domain.be.sure/topface-prod-app:20150127001
web605 ~ # time docker push aint-nobody-got-that-domain.be.sure/topface-prod-app:20150127001
FATA[0031] Error: v1 ping attempt failed with error: Get https://aint-nobody-got-that-domain.be.sure/v1/_ping: dial tcp: lookup aint-nobody-got-that-domain.be.sure: no such host. If this private registry supports only HTTP or HTTPS with an unknown CA certificate, please add --insecure-registry aint-nobody-got-that-domain.be.sure to the daemon's arguments. In the case of HTTPS, if you have access to the registry's CA certificate, no need for the flag; simply place the CA certificate at /etc/docker/certs.d/aint-nobody-got-that-domain.be.sure/ca.crt
real    0m31.848s
user    0m0.020s
sys 0m0.000s
—
Reply to this email directly or view it on GitHub
https://github.com/docker/docker/issues/10269#issuecomment-71798325.

cc @dmcgowan

As mentioned in the other issue, the performance increase will only be seen for images built on master. The optimization for pre-1.5 builds is still being reviewed.

@dmcgowan please reopen the issue if it's not fixed yet.
I've rebuilt an image (2 top layers) on 1.5 and docker push to unknown host still takes 20-30s.

Should require #10394 to be considered fixed
@icecrime can we move this into the 1.5.1 milestone?

Much better now!


Battle View

I think there is one problem left. When a player gets disconnected from the server while battling, I think then the battle viewer should get reset. It should get reset like when it gets reset after a battle. I think that is the one thing missed. It can be crashed that time if the battle view doesn't get reset.


Bump leveldb

Faster build, no other changes

broken on Linux, don't merge yet

don't merge yet
You can mark a PR as a draft which physically prevents it from getting merged

ready, the clippy errors are not from the world crate

Yippue


Error when when trying to go to "quick sign in"

At this point in the Hello Blockstack tutorial, the developer has not installed Blockstack and is supposed to be navigated to the quick sign in page after clicking "Sign In with Blockstack"
An error pops up..

cc @larrysalibra @shea256
This is important because otherwise it will be nearly impossible for a user to complete the tutorial.

@pstan26 This is because on safari (and edge AFAIK), there's no way for us to detect whether or not the user has installed blockstack by checking for the blockstack: protocol.
On these browsers, we could check to see if the user has a blockstack core node configured on the default port (by attempting to get http://localhost:6270/v1/node/ping), if they do, we could try blockstack: and if not, we could send to the "quick login` page. cc @shea256


Using htmlAttrs on a page breaks this module

Version
"@nuxtjs/color-mode": "^2.0.0", installed at version: '2.0.0'
"nuxt": "^2.14.6", installed at version: '2.14.7'
Reproduction Link
Here is a link to the sandbox found in the examples section, I've replaced the light page with a page that breaks it.
Sandbox
Change mode to dark and then click through to that inner page, you can also inspect the markup.
Steps to reproduce
Add the htmlAttrs to any page like so
head: {
    htmlAttrs: {
      class: 'test'
    }
}

What is Expected?
That the light or dark class is still added to the HTML element when changing pages.
What is actually happening?
The light or dark class is not added, only the "test" class. If the htmlAttrs is removed, then the module works again.

@Atinux Is there a way to detect in client plugin that vue-meta is loaded and export head object in that case? I can try it, but not sure if it's possible.


AppRTC with ofmeet

Hi,
Thanks for lib. Is this works with ofmeet plugin of Openfire. If yes please guide me how to do so.
I am able to connect to jabber but when i tries to have video chat blank page appears .
Thank you

Sorry,I did not try ofmeet. And what a pity, I think it won't work with ofmeet.


"Invariant Violation: requireNativeComponent: "RNCWebView" was not found in the UIManager."

Hi Felipe Rosas👋
I am Abhinandan, the author and maintainer of the library - react-native-gifted-charts Thanks for using this library.
Your project log-finance-react-native is awesome!
When I open the Reports tab, the app crashes with this error - "Invariant Violation: requireNativeComponent: "RNCWebView" was not found in the UIManager."
Solution -
Upon inspection, I found that the react-native-webview library was not installed. react-native-webview is required for rendering the Pie charts. Installing this library solved the issue! 🤗

Hi @Abhinandan-Kushwaha 😃
I am pleased by your message, thank you very much =)
I have followed the lib docs by the book and it was working perfectly. But when I generated a new version and cleaned up the package.json, I ended up wrongly removing react-native-webview.
I was asking myself “why did I installed this?” 🤣 🤣 🤣 🤣
This weekend I will generate a new version correcting this 🙃
Thank you very much

Cool @eufelipe
Feels good to know I solved an issue 😂


CAN

can beta study faster？ when I use adapool2d， it is too slow that I must make the learning rate very small, I want it faster, do you have any idea? Please help,  thank you very very much.

Hi @1zsw123 ,
If you want to focus on optimizing convergence time, you can switch to a single-valued beta instead of a matrix (for each pooling window). However, throughout all experiments, I did not notice any convergence issues w.r.t. speed.


Add a basic implementation of XCTIssue.

This PR adds a basic implementation of XCTIssue and record(_:). The implementation is not as complex as the one in the XCTest framework that ships in Xcode. The interface is equivalent.
Resolves #348.

@swift-ci please test

@swift-ci please test

@swift-ci please test

@swift-ci please test

@swift-ci please test Windows

@swift-ci please test

@swift-ci please test Windows

@swift-ci please test Windows


Too easy to click the link to the code page when attempting to expand sidebar

Let's reduce the click target to the left/right of the face. Take care not to have a gap when expanded.


store: call callback on socket error.

Hello,
When a socket error happens during an STOR or APPE, this error doesn't seem to propagate to the callback passed to put() or append(). I believe a single call to cb should be added in the socket error handler. At least, it solves the issue I have at hand.
Can you verify this?
Thanks.

True. It behaves correctly. Perhaps there was an issue before, but it's gone now.


Install instructions in older doc versions will install latest Citus

Our Debian package cannot currently be pinned at a specific (older) version so we can't have the 5.0 docs' install instructions specify a way to get the version of the program they document.
We could

Work on improving our Debian package structure (if it's possible) or
Change the install instructions to tell the user that we no longer recommend installing the old version

@jasonmp85 any opinion on this one?

Not possible in PGDG, possible with packagecloud. I should have something for you in the near (weekish) future.

Are we planning to switch to using packagecloud or should I close this issue?

@sumedhpathak ? 😁

We have not discussed moving to package cloud, so its not on the horizon.

Wait, so why does that mean we close this issue? It's still an issue, right (i.e. old instructions will install the latest Citus, not the old versions)?
I think this issue has to stay open until we decide whether this is a WONTFIX or something we will fix, just not yet (i.e. prioritize it).

Didn't we make some progress on this issue recently? Or no?


Add covid-clade-counts

Covid-clade-counts isn't a hub, but we're onboarding it as such so that repo can push files to an S3 bucket via the GitHub action/OIDC we have set up in the Hubverse AWS

Decided to target the reichlab AWS account instead, so we no longer need this change.


Cannot remove <IP_ADDRESS>/0 from public_access_cidrs

Description
To restrict access to the EKS API, we have added our VPN endpoints to the public_access_cidrs. But when we apply the code, the resource still has the <IP_ADDRESS>/0 entry, in addition to our VPN endpoints. If we delete the <IP_ADDRESS>/0 entry manually, Terraform wants to add it back.  Our CIDRs are not touched.

[X ] ✋ I have searched the open/closed issues and my issue is not listed.

Versions

Module version [Required]:

Terraform version:
Terraform v1.0.11
on darwin_arm64

provider registry.terraform.io/hashicorp/aws v4.50.0
provider registry.terraform.io/hashicorp/null v3.2.1

Reproduction Code [Required]
resource "aws_eks_cluster" "eks_cluster" {
name     = var.eks_name
role_arn = var.eks_role
version  = var.eks_version
enabled_cluster_log_types = var.log_types
vpc_config {
security_group_ids = [module.eks_cluster_sg.security_group_id]
subnet_ids = "redacted subnet ids"
public_access_cidrs     = ['redacted Cidr 1', 'redacted Cidr 2']
endpoint_private_access = true
endpoint_public_access = true
}
}
Steps to reproduce the behavior:

no workspaces

local cache cleared

normal maintenance
Expected behavior
The Cidrs I specify should REPLACE the existing Cidrs
Actual behavior
After applying code,  only the cirds I specify should exist but <IP_ADDRESS>/0 is still listed

this is not a restriction implemented by the module, we did try to remove this when v19 was released but its not supported by upstream at this time - https://github.com/terraform-aws-modules/terraform-aws-eks/pull/2320


Mac: Delete button removes selected breakpoint

Description
It's a small pain point that removing a specific breakpoint during a debugging session requires right clicking the breakpoint and selecting the context option Remove Breakpoint. It would be a more pleasant development experience if I could left click to select the breakpoint in question, press either of the Delete keyboard buttons, and the breakpoint is removed.
Platform information
VS Code
$ code --version
1.40.1
8795a9889db74563ddd43eb0a897a2384129a619
x64

Operating System
macOS Catalina version 10.15.1

You can use cmd + backspace to delete the breakpoint
If you do not like this keybinding you can customise it here


encoding/prototext: parser should allow whitespace between minus sign and number in negative numeric literal

The text format specification explicitly states that whitespace and comments are allowed between the minus sign and the subsequent numeric component of a negative numeric literal. I can confirm that the C++ implementation correctly adheres to this. But the Go implementation in prototext does not.
Here's a trivial example.
// test.proto
syntax = "proto3";

message Foo {
  int32 id = 1;
}

Compile the above to Go via command like so:
protoc --go_out=paths=source_relative,Mtest.proto=foo.com/test/main:. test.proto

Here's the rest of the Go program
// main.go (in same directory as test.pb.go generated from above)
package main

import (
  "fmt"
  "google.golang.org/protobuf/encoding/prototext"
)

func main() {
  data := "id : - 23"
  var msg Foo
  err := prototext.Unmarshal([]byte(data), &msg)
  if err != nil {
    panic(err)
  }
  fmt.Println(&msg)
}

The above program panics with the following error:
proto: syntax error (line 1:6): invalid scalar value: -

I would instead expect this to echo back the message data with output like so:
id:-23

Unexpected standards esotericisms. This reminds me a whole lot about how technically you can embed comments into email addresses as well, except that no one actually supports that.

Iirc, they didn't have the textproto spec publicized yet at the time this was written and no compliance test for it too...
https://github.com/protocolbuffers/protobuf-go/blob/master/internal/encoding/text/decode_number.go#L79-L81
Here's a possible solution. parseNumber func needs to account for the extra whitespace and/or comments.  It may also need to produce the bytes/string for properly setting Token.str field in parseNumberValue.
I currently don't have the bandwidth to work on this.  If anyone has, feel free to send CL.

I currently don't have the bandwidth to work on this. If anyone has, feel free to send CL.

@cybrcodr, I got ya. https://go-review.googlesource.com/c/protobuf/+/473015
Thanks for the pointer!


fix(theme-default): fix full GitHub repo link parsed to 'Source'

The repo option should also be modified.
https://github.com/vuepress/vuepress-next/blob/5cad664bd7224a08e679dc06f61f17af6c790b97/packages/%40vuepress/theme-default/src/client/components/NavbarLinks.vue#L102-L107

The corresponding docs should be updated, too.

Ummmm, what I mean is this part:
https://github.com/vuepress/vuepress-next/blob/a38f2a246cffeab3ba78a9f728303c430b9fae5d/docs/reference/default-theme/config.md#L149

I'll update it


when run sile it failed

/usr/local/bin/lua: /usr/local/share/sile/lua-libraries/cassowary.lua:653: attempt to call a nil value (global 'unpack')
stack traceback:
	/usr/local/share/sile/lua-libraries/cassowary.lua:653: in field '_init'
	/usr/local/share/sile/lua-libraries/std/container.lua:172: in field 'SimplexSolver'
	/usr/local/share/sile/core/frame.lua:3: in main chunk
	[C]: in function 'require'
	/usr/local/share/sile/core/sile.lua:33: in main chunk
	[C]: in function 'require'
	/usr/local/bin/sile:5: in main chunk
	[C]: in ?

 lsb_release -a
No LSB modules are available.
Distributor ID:	Ubuntu
Description:	Ubuntu 15.04
Release:	15.04
Codename:	vivid

lua -v
Lua 5.3.0  Copyright (C) 1994-2015 Lua.org, PUC-Rio

Thanks for the bug report. This looks like a problem with the cassowary module. I have not yet tested either SILE or cassowary on Lua 5.3.0 yet, but I wonder if that is the problem. I think Lua's concept of number changed in 5.3, so I would expect some problems. I don't have a 5.3 set up here for testing at the moment, so will do some investigation on this next week.

@simoncozens Thanks for your quick response.  I have just re-compiled and installed lua with https://github.com/lua/lua git checkout 5.1.x. And now, sile works well :+1:

I've just added some commits (b1aa7bd, 8dc4b65, 5593b00) for Lua 5.3 support.

I have just updated it to Lua5.3 , it works well. Nice ~~


Add method overloads with specific options instead of generic options type

Because of the addition of Actions, there are new xxOption types that we should also use in the non LRO endpoints.
Similar to what Java is doing here => https://github.com/Azure/azure-sdk-for-java/pull/18984/files#r571145846
.NET can use the approach we did for AnalyzeSentiment on how to "hide" the old method from the user in order to expose the new ones
Endpoints affected:

[ ] EntityLinking
[x] RecognizeEntities
[x] RecognizeLinkedEntities

Note that RecognizePiiEntities already uses RecognizePiiEntitiesOptions

I can't find anything related to an EntityLinking class or the like, though I do see a ExtractKeyPhraseOptions that's not used as a parameter type currently - nor in Java, comparatively.

Per offline discussion, "EntityLinking" was added in error, but we should also do this for ExtractKeyPhrases (but don't need to for DetectLanguages). I've updated the description accordingly.


Optimize attributes diff in elementOpen

This optimizes the attributes diffing to only use j redundant accesses.
If a change is detected in the beginning (or near), then j is small
(possibly 0) and we get the largest gains. If the change is detected at
the end, then j is equal to the number of attribute name-values (so we
end up doing a second full iteration).
That's still better than the code before, which always guaranteed 2 full
iterations. Now we just do 1 full iteration, plus j (which may be
another full).
Supersedes #252 (notice we iterate attrsArr for those j redundant accesses).
Time for bed. :sleeping::zzz::zzz:

Deferring to #256.


Use es6 extends

It would be lovely to see this PR merged someday :)

@yokuze Is it possible to get this merged?

news?

@yokuze / @ Can this be merged, as it is crashing for me with videojs 8.3.0 .
"videojs.extend is not a function"

@yokuze Is it possible to tag releases more often? The same would go for silvermine/videojs-chromecast ?

@yokuze ^


Reposition directories

Fixed this issue: https://github.com/sudz123/Happy_Hacking/issues/112

Great!


Date picker control similar to file picker

A new date picker control.
Ready to use like in the example:
import flet as ft
from flet_core.date_picker import DatePickerMode, DatePickerEntryMode

def main(page: ft.Page):
    def change_date(e):
        page.add(ft.Checkbox(label=f"Current date {date_picker.value}"))
        date_button.text = f"{date_picker.value}"
        page.update()

    date_picker = ft.DatePicker(
        on_change=change_date,
        date_picker_mode=DatePickerMode.YEAR,
        date_picker_entry_mode=DatePickerEntryMode.INPUT,
        hint_text="Say hello?",
    )

    page.overlay.append(date_picker)

    date_button = ft.ElevatedButton(
        "Pick date",
        icon=ft.icons.CALENDAR_MONTH,
        on_click=lambda _: date_picker.pick_date(),
    )

    page.add(date_button)

ft.app(target=main)

I've just merged https://github.com/flet-dev/flet/pull/913 into main. Could you update your branch with the latest from main and merge potential conflicts please? Thank you for your time working on that!

Of course, the pleasure is mine.

Is there anything we could do to have this PR for only changed files? I don't understand what happened to it when you merged main, but going through 70 files?... :)


Fix target reference secrets and container secret store

This addresses the comments https://github.com/docker/docker/pull/27794#discussion_r88158137 and https://github.com/docker/docker/pull/27794#issuecomment-260479792 in #27794.
Refs #28516

/cc @diogomonica @stevvooe

LGTM

Ping @diogomonica

correct me if I'm wrong @ehazlett, but I don't think this is needed anymore

I believe it is.  These are the follow up requests from the PR.


Does it work for all items?

I have the impression that sometimes the sorter stops. Happened for me with critical photons

I had this problem too. Sorter couldn't feed Accumulators to the dust bin.


Crash Upon Starting download

Usage
import SpInAppUpdates, {
  AndroidInstallStatus,
  IAUUpdateKind,
  StartUpdateOptions,
} from 'sp-react-native-in-app-updates'

...
      InAppUpdates.addStatusUpdateListener((event) => {
        if (event.status === AndroidInstallStatus.DOWNLOADED) {
          InAppUpdates.installUpdate()
          InAppUpdates.removeStatusUpdateListener((status) => console.log(status))
        }
      })

Error from Playstore:
com.facebook.react.common.JavascriptException: TypeError: Cannot read property 'DOWNLOADED' of undefined, js engine: hermes, stack:
anonymous@1:852125
value@1:856681
anonymous@1:853884
value@1:93197
value@1:102582
anonymous@1:101065
value@1:102028
value@1:101023
at com.facebook.react.modules.core.ExceptionsManagerModule.reportException(ExceptionsManagerModule.java
at java.lang.reflect.Method.invoke (Native Method)
at com.facebook.react.bridge.JavaMethodWrapper.invoke (JavaMethodWrapper.java:372)
at com.facebook.react.bridge.JavaModuleWrapper.invoke (JavaModuleWrapper.java:151)
at com.facebook.react.bridge.queue.NativeRunnable.run (Native Method)
at android.os.Handler.handleCallback (Handler.java:739)
at android.os.Handler.dispatchMessage (Handler.java:95)
at com.facebook.react.bridge.queue.MessageQueueThreadHandler.dispatchMessage (MessageQueueThreadHandler.java:27)
at android.os.Looper.loop (Looper.java:148)
at com.facebook.react.bridge.queue.MessageQueueThreadImpl$4.run (MessageQueueThreadImpl.java:226)
at java.lang.Thread.run (Thread.java:818)

same issue here

same issue here

@dibyopra  I'm using the codes manually instead of importing them from AndroidInstallStatus as a workaround for now

@dibyopra  Yes exactly, should do the trick, haven't tested it yet though

Yes exactly, should do the trick, haven't tested it yet though

I have tried it, its working

AndroidInstallStatus is exported from the library as IAUInstallStatus. So you can use IAUInstallStatus.DOWNLOADED instead.
console.log(AndroidInstallStatus?.DOWNLOADED, IAUInstallStatus.DOWNLOADED);

I was running into the same issue, I suppose it's because they are passed through by index.d.ts, but not by index.js?
https://github.com/SudoPlz/sp-react-native-in-app-updates/blob/154057630d77f437d6edbd74fcc2009c83981ab6/src/index.d.ts#L9-L16
https://github.com/SudoPlz/sp-react-native-in-app-updates/blob/154057630d77f437d6edbd74fcc2009c83981ab6/src/index.js#L1-L6
My suggestion would be to remove export * from './types'; from index.d.ts (may seem like a breaking change, but in fact it's not because the stuff exported by this is not available in compiled code, I think). Or update index.js to be typescript and remove the .d.ts file altogether so they can not diverge anymore.


docs: remove module-metadata.json and commitlint.config.js

/run pipeline

This module may be getting deprecated in favour of the fully supported KMS modules so holding off on merge until we discuss later today