Timeout argument on 'New Browser'

Describe the bug
The timeout argument of the New Browser keyword seems to be broken.
To Reproduce
Steps to reproduce the behavior:

Use New Browser    browser=chromium    headless=False    timeout=0s
Error is thrown
Variantes like timeout=0 do not work as well

Expected behavior
Error is thrown:
Error: browserType.launch: timeout: expected number, got string [[-]](vscode-webview://1v30vc43hfdiemc74gulcl3244gg5isefsrn8nq2vlc7lvvmpsv6/index.html?id=11fd3aa1-5851-4930-9eb6-d1c68c79cbb2&swVersion=4&extensionId=robocorp.robotframework-lsp&platform=electron&vscode-resource-base-authority=vscode-resource.vscode-cdn.net&parentOrigin=vscode-file%3A%2F%2Fvscode-app#)
Traceback (most recent call last):
  File "c:\Users\vinic\.vscode\extensions\robocorp.robotframework-lsp-0.47.2\src\robotframework_ls\vendored\robotframework_interactive\interpreter.py", line 375, in evaluate
    return self._evaluate(code)
  File "c:\Users\vinic\.vscode\extensions\robocorp.robotframework-lsp-0.47.2\src\robotframework_ls\vendored\robotframework_interactive\interpreter.py", line 482, in _evaluate
    facade.run_test_body(context, test)
  File "c:\Users\vinic\.vscode\extensions\robocorp.robotframework-lsp-0.47.2\src\robotframework_ls\vendored\robotframework_interactive\robotfacade.py", line 67, in run_test_body
    BodyRunner(context, templated=False).run(test.body)
  File "C:\Users\vinic\AppData\Local\robocorp\holotree\b1f3c244e_6cd60f16\lib\site-packages\robot\running\bodyrunner.py", line 61, in run
    raise ExecutionFailures(errors)
robot.errors.ExecutionFailures: Error: browserType.launch: timeout: expected number, got string

Desktop (please complete the following information):

OS: Windows
Browser: Chromium
robotframework-browser==13.0.0
rpaframework==14.2.0

This seems to happen outside of the Browser library code, because Browser library relies on the Robot Framework to perform argument conversion. Which version of Robot Framework you are using and if you are not using the latest could you try with the latest Robot Framework version?

I am using Robot Framework 5.0.1, so I guess it is the latest already. Were you able to execute step 1 in the "To Reproduce" topic without an issue?

@allcontributors please add @vinismarques for bugs.

I can reproduce the issue only when the timeout is 0:

PR 2108 fixes this issue.

Fixed in #2108


LiteLLM incompatibility

[x ] This is actually a bug report.
[ ] I am not getting good LLM Results
[ ] I have tried asking for help in the community on discord or discussions and have not received a response.
[ ] I have tried searching the documentation and have not found an answer.

What Model are you using?

[ ] gpt-3.5-turbo
[ ] gpt-4-turbo
[ ] gpt-4
[x ] Other (please specify)

Environment
Instructor 1.4.0
LiteLLM 1.44.4
Describe the bug
While trying to extend our LLM applications with LiteLLM on top of Instructor for AWS Bedrock Anthropic models, I've come across 2 problems

While using Mode.ANTHROPIC_JSON, an assertion error is raised as LiteLLM returns a ModelResponse type (https://github.com/BerriAI/litellm/blob/main/litellm/types/utils.py#L538), which in the instructor library is checked with an assertion to be of kind Message (https://github.com/jxnl/instructor/blob/main/instructor/function_calls.py#L205)
While using Mode.MD_JSON, together with a predefined system message, this line https://github.com/jxnl/instructor/blob/main/instructor/process_response.py#L312 tries to extend the predefined system message assuming it is a string. However, LiteLLM seems to force the content of each message into a list, which causes that line to extend the list with a list entry per character in the Mode.MD_JSON system message, which leads to an error further down the line in LiteLLM This only appears to happens if one of the messages has a list as content, but as I understand it, the list is necessary when sending an image to a vLLM.

{'role': 'system', 'content': [{'type': 'text', 'text': 'You are a financial analyst. You have been given a chart to analyze. Extract the data from this chart.'}, '\n', '\n', '\n', ' ', ' ', ' ', ' ', ' ', ' ', ' ', ' ', ' ', ' ', ' ', ' ', ' ', ' ', ' ', ' ', 'A', 's', ' ', 'a', ' ', 'g', 'e', 'n', 'i', 'u', 's', ' ', 'e', 'x', 'p', 'e', 'r', 't', ',', ' ', 'y', 'o', 'u', 'r', ' ', 't', 'a', 's', 'k', ' ', 'i', 's', ' ', 't', 'o', ' ', 'u', 'n', 'd', 'e', 'r', 's', 't', 'a', 'n', 'd',  ... etc

To Reproduce
You can take a random image to reproduce. Both issues can be reproduced with this snippet, just switch out the Mode.
import asyncio
import base64
import os
from typing import Dict

import instructor
from dotenv import load_dotenv
from instructor import AsyncInstructor
from litellm import Router
from pydantic import BaseModel, Field

load_dotenv()

class ChartData(BaseModel):
    """Extracted data from a financial chart"""

    chart_type: str = Field("", description="The type of chart")
    data: Dict[str, list[float]] = Field({}, description="The extracted data")

def get_instructor():
    router = Router(
        model_list=[
            {
                "model_name": "claude-sonnet-3.5",
                "litellm_params": {
                    "model": "bedrock/anthropic.claude-3-5-sonnet-20240620-v1:0",
                    "aws_access_key_id": os.getenv("AWS_ACCESS_KEY_ID"),
                    "aws_secret_access_key": os.getenv("AWS_SECRET_ACCESS_KEY"),
                    "aws_region_name": os.getenv("AWS_DEFAULT_REGION"),
                },
            },
            # Add more models if needed
        ],
    )
    return instructor.from_litellm(
        router.acompletion,
        # mode=instructor.Mode.MD_JSON,  # For issue #2
        mode=instructor.Mode.ANTHROPIC_JSON,  # For issue #1
    )

async def call_llm(llm: AsyncInstructor, encoded_image: str):
    response = await llm.chat.completions.create(
        model="claude-sonnet-3.5",
        response_model=ChartData,
        messages=[
            {
                "role": "system",
                "content": "You are a financial analyst. You have been given a chart to analyze. Extract the data from this chart.",
            },
            {
                "role": "user",
                "content": [
                    {"type": "text", "text": "Extract data from this image."},
                    {
                        "type": "image_url",
                        "image_url": {"url": "data:image/jpeg;base64," + encoded_image},
                    },
                ],
            },
        ],
    )
    return response

def load_and_encode_image(image_path: str) -> str:
    with open(image_path, "rb") as image_file:
        encoded_image = base64.b64encode(image_file.read()).decode("utf-8")
    return encoded_image

async def extract_chart_data():
    image = load_and_encode_image("testchart.jpg")
    instructor = get_instructor()
    chart_data = await call_llm(instructor, image)

    return chart_data

if __name__ == "__main__":
    response = asyncio.run(extract_chart_data())

Expected behavior
I expect LiteLLM to work with Instructor for Bedrock Anthropic models, for both LLM and vLLM use cases.
Error log
Issue 1:
Traceback (most recent call last):
  File "/home/jbekker/miniconda3/envs/zenith/lib/python3.11/site-packages/instructor/retry.py", line 242, in retry_async
    return await process_response_async(
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/jbekker/miniconda3/envs/zenith/lib/python3.11/site-packages/instructor/process_response.py", line 77, in process_response_async
    model = response_model.from_response(
            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/jbekker/miniconda3/envs/zenith/lib/python3.11/site-packages/instructor/function_calls.py", line 124, in from_response
    return cls.parse_anthropic_json(completion, validation_context, strict)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/jbekker/miniconda3/envs/zenith/lib/python3.11/site-packages/instructor/function_calls.py", line 205, in parse_anthropic_json
    assert isinstance(completion, Message)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
AssertionError

Issue 2:
litellm.exceptions.APIConnectionError: litellm.APIConnectionError: 'str' object has no attribute 'get'
Traceback (most recent call last):
  File "/home/jbekker/miniconda3/envs/zenith/lib/python3.11/site-packages/litellm/main.py", line 2303, in completion
    response = bedrock_converse_chat_completion.completion(
               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/jbekker/miniconda3/envs/zenith/lib/python3.11/site-packages/litellm/llms/bedrock_httpx.py", line 1586, in completion
    if m.get("type", "") == "text" and len(m["text"]) > 0:
       ^^^^^
AttributeError: 'str' object has no attribute 'get'

Happy to contribute if necessary.

open to take a PR that replaces the isinstance check with some hasattr checks

open to take a PR that replaces the isinstance check with some hasattr checks

Hey, could you find some time to look at the PR I opened 3 weeks ago? It would be great to get instructor to work with LiteLLM and Anthropic.


Remove support for avr-libcpp injection

Remove support for avr-libcpp injection.

picolibrary is a tightly coupled dependency for picolibrary-microchip-megaavr so it makes sense to remove support for picolibrary injection. This is not the case for avr-libcpp. Abandoning.


Fixes local cypress test failures due to DB user re-use

Description
When running the Cypress e2e tests locally (through Docker, like CircleCI does), six tests currently consistently fail. These failure are due to sharing user accounts between tests, while expecting that the tests will be run independently.
CircleCI parallelizes tests and databases in a way that gets around these failures, but when make e2e_test_docker is run locally, they're single-threaded and in a predictable order, causing the failures.
This pull request adds several new database users to the e2e dataset, and reworks those failing tests to use the fresh users.
Reviewer Notes
... I'm a novice at golang, please make sure I didn't break anything. 🙃
Additionally, ensure that integration tests are still passing on CircleCI.
Setup
make e2e_test_docker

and then wait for, like, a half hour. Ensure that the modified tests pass. (Note that are a flaky test or two outside of the tests changed in this pull request, which fail on both local and CircleCI runs maybe 10-20% of the time. Those will be looked at and probably addressed in a future PR.)
Code Review Verification Steps

[ ] Request review from a member of a different team.
[ ] Have the Jira acceptance criteria been met for this change?

References
Closes MB-8377.

Merging this PR, as those failing tests when running yarn test:e2e are A) also happening in master right now, and B) outside the scope of this ticket.

@eamahanna The reason we have 2 separate files is because they are meant for different things. e2ebasic.go should ONLY be used for e2e tests. Changes that we make to e2ebasic.go shouldn't have anything to do with devseed.go.
devseed is meant for local development and should have nothing to do with e2e tests. devseed allows us to populate the DB with data that makes it easy to run the app locally and jump straight into some functionality we want to test while developing, as opposed to having to manually create a move from scratch by signing in as a customer, going through onboarding, etc..
The fact that we have a yarn test:e2e command that uses the development database doesn't make any sense to me. If we're running e2e tests, we should be using the test DB.


Cleanup

gam,py:
In show sakays, only mark USER-MANAGED keys as current: true/false
gapi/init.py:
pylint cleanup: import order, indentation
gapi/errors.py:
pylint cleanup: import order, unused import, indentation
Recognize 502 Bad Gateway/Gateway Timeout: treat as retryable errors
This last change does not directly handle the refresh problem in Issue #1063 but in my version this seems to be the right solution to the 502 gateway errors

This command already exists:
gam delete sakey|sakeys + [doit]


Fixing sidebar overflowing main section

This PR adds a minimum height to main section of forms, so that smaller sections like the E section, when no document/link is added, the sidebar doesn't overflow into the footer

to

 [QAE17] In section E 'Add Website Address/Documents' the new submission deadline doesn't fit in the left menu properly


Moved brew install instructions up as this is easiest method imo

Trivial change but I thought it may help as I was about to use the curl method until I scrolled & saw brew option.

I don't think that's a good idea since it may be outdated despite we file a PR every new release to them. I see it very rational to put the original links on the very to as the most relevant and new version.

@dstftw ok, now worries... I wasn't aware it may not be the latest on brew... thanks anyway & keep up the good work :)


Proposed 2.8.0

Includes

#2674
#2567
#2523
#2706
Bump for urllib3

Reminder to look at http://ci.kennethreitz.org/job/requests-pr/ for build status

So http://ci.kennethreitz.org/job/requests-pr/714/PYTHON=3.3/console is an interesting error. I'll work on tracking it down

Here's hoping http://ci.sigmavir.us/job/requests-real/ picks up on this. @kennethreitz's CI is not picking up on the new commits.

Ah, here we go: http://ci.kennethreitz.org/job/requests-pr/

Let's be extra cautious of #2567

We are. That's why we're shipping it in 2.8.0: it should avoid us immediately breaking a ton of production software. =)

@kennethreitz #2567 is already running on Debian (and maybe ubuntu?) against Requests 2.7.0 and has yet to produce any bug reports there. It's been running there for at least a month. Also it, Cramer signed off on it and pip has been using something similar to #2567 for a while now.

what does @mitsuhiko think?

Replied to #2567.

Any traction on this release? Would love to see https://github.com/shazow/urllib3/issues/556 fixed :)

Any traction on this release? Would love to see shazow/urllib3#556 fixed :)

+1

Sorry Laurent. What are you trying to add 1 to? This isn't JavaScript so we don't do auto type coercion and that comment doesn't parse.
Sent from my Android device with K-9 Mail. Please excuse my brevity.

Heh, sorry, was just trying to add my vote as we just hit the problem, in case this PR needs some love ;)

Comments aren't for voting though. We have this planned we just don't have it entirely ready. This was also just to have a branch to have all the open PRs merged into one place so we can test all of them together. This isn't necessarily the PR that will actually merge to create 2.8.0

@sigmavirus24 IIRC Ubuntu either pulls from Debian testing or unstable during a new OS release cycle, so if #2567 was put in to one of those branches it will be in Ubuntu by now. Also you would be able to check the patches that are in the source for packaging as well. just my 2 cents

Ok, in preparation for releasing 2.8.0 I am going to merge this now. I'm aiming to get 2.8.0 out the door by the middle of this week, and merging this will help force me to do that.


Kernel with zswap support

Is your feature request related to a problem? Please describe.
Zswap support is currently not availble.
$ cat /sys/module/zswap/parameters/enabled
cat: /sys/module/zswap/parameters/enabled: No such file or directory

Describe the solution you'd like
I'd like to use zswap in WSL2 to use memory more efficiently or run more apps / services when e.g. the host machine itself owns only little memory.
Additional context
WSL2 with Ubuntu is currently in use.
> wsl --version
WSL version: <IP_ADDRESS>
Kernel version: <IP_ADDRESS>
WSLg version: 1.0.51
MSRDC version: 1.2.3770
Direct3D version: 1.608.2-61064218
DXCore version: 10.0.25131.1002-220531-1700.rs-onecore-base2-hyp
Windows version: 10.0.22621.1702

Sounds like a good idea. Maybe include zram as well.

+1 particularly for zram #9417. This could alleviate the constraints of splitting limited resources between windows and linux.

enabling it in the default config shouldn't hurt anyone, should it?

I tried to enable zswap via a custom kernel with the following:
CONFIG_ZSWAP=y
CONFIG_ZSWAP_DEFAULT_ON=y
CONFIG_ZSWAP_COMPRESSOR_DEFAULT_ZSTD=y
CONFIG_ZSWAP_COMPRESSOR_DEFAULT="zstd"

and I got  a page fault error:
0.387401] hv_balloon: Cold memory discard hint enabled with order 9
[    0.387896] BUG: unable to handle page fault for address: fffffffffffffff1
[    0.388107] #PF: supervisor read access in kernel mode
[    0.388255] #PF: error_code(0x0000) - not-present page


CPR-294 Added future flag to stop processing libra messages.

Decided to remove LIBRA stuff completely so closing this PR.


Update http4s-client, http4s-dsl to 0.23.0

Updates

org.http4s:http4s-client
org.http4s:http4s-dsl

from 0.23.0-M1 to 0.23.0.
GitHub Release Notes - Version Diff
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "org.http4s" } ]

labels: library-update, semver-pre-release

Superseded by #398.


Move ctapipe-extras submodule.

Hi,
right now the ctapipe-extras folder is a git submodule which is entirely non-optional for users.
I'd like to discuss whether it makes sense to move the ctapipe-extras thing into an external python dependency installable by pip. Or simply add the required files to a resources folder.
I think the latter solution is even simpler to handle.

See https://github.com/cta-observatory/ctapipe-extra/pull/3

ctapipe-extras is now a python module.

Now that ctapipe-extras is a module, you just need to clean up where it is used in ctapipe and make it a dependency, and that should be ok.

I agree. 👍


Improve user account code and related API calls

There should be a Java interface for accounts, and all API calls should be in an IntentService that runs in the background.

No idea what this was about. Closing.


Evaluator Review: EVMNS_Milestone_3

Review, approve, or deny https://github.com/eosnetworkfoundation/grant-milestones/pull/111

Closed per approval from @DenisCarriere for https://github.com/eosnetworkfoundation/grant-milestones/pull/111.


Integration with Azure DNS Zone

There is guidance available to automate DNS updates. However, from that guidance it is not clear if the domain delegation is a pre-requisite for it to work.
HTTP Application routing for AKS currently supports configuring Azure DNS Zone out of the box including domain delegation configuration.
Is AGIC going to implement out-of-the-box configuration for Azure DNS Zone just like HTTP Application routing?
Or is it already supported and I am missing a trick?

use external-dns for dns updates

Duplicate https://github.com/Azure/application-gateway-kubernetes-ingress/issues/615


[ISSUE #3329]Optimize RegistryService implments init,start,shutdown method

Fixes #3329
Motivation
Explain the content here.
Explain why you want to make the changes and what problem you're trying to solve.
Modifications
Describe the modifications you've done.
Documentation

Does this pull request introduce a new feature? (yes / no)
If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
If a feature is not applicable for documentation, explain why?
If a feature is not documented yet in this PR, please create a followup issue for adding the documentation

I will fix CI and resubmit later


Getting SQL80001: Incorrect syntax near '[CredentialName]'.  Expecting '='.

Using SSDT:
CREATE DATABASE SCOPED CREDENTIAL [CredentialName] WITH IDENTITY = 'Something',
SECRET = '<EnterStrongPasswordHere>';
GO
I get error: "SQL80001: Incorrect syntax near '[CredentialName]'.  Expecting '='."
Intellisence in SSMS shows the same syntax issue but then executes the command successfully.
Environment:

Microsoft SQL Azure (RTM) - 12.0.2000.8
Microsoft Visual Studio Professional 2017 Version 15.9.14
SQL Server Data Tools  15.1.61906.03120

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 140d7c84-acc3-f722-99af-867be1f8752a
Version Independent ID: 6bb40855-9644-1b18-3c4f-cec734cdc169
Content: CREATE DATABASE SCOPED CREDENTIAL (Transact-SQL) - SQL Server
Content Source: docs/t-sql/statements/create-database-scoped-credential-transact-sql.md
Product: sql
Technology: t-sql
GitHub Login: @VanMSFT
Microsoft Alias: vanto

Probably no issue with the docs. It's a VS issue. Upgraded to latest 2019 but having the same issue. I can see people have been reporting that same issue since 2016...

@tomas-weir - Thanks for bringing this issue up! Yes, this is a Product/Support issue and I would advise that you look through the following channels for support if you haven't already done so. Thanks!

UserVoice - Suggestion to improve SQL Server?
Setup and Upgrade -  MSDN Forum
SQL Server Data Tools - MSDN forum
Transact-SQL - MSDN forum
SQL Server Security -  MSDN Forum
DBA Stack Exchange (tag sql-server) - ask SQL Server questions
Stack Overflow (tag sql-server) - also has some answers about SQL development
Reddit - general discussion about SQL Server
Microsoft SQL Server License Terms and Information
Support options for business users
Contact Microsoft
All the ways to get help

This being closed and not being answered is lazy on MS part. If common errors are not addressed in documentation then this documentation is useless.

Same problem here

This bug is still present in Visual Studio 2019

This is still a problem in Visual Studio 2022. Not sure how were are expected to keep using tools that do not work. That link above claims it is an intellisense issue that does not prevent compiling. However it does prevent building in both 2019 and 2022

Hi All,
working on Visual 2022, and keep on seeing this issues for SQL Azure scripts. The script works without any issues in sql studio.
SQL46010: Incorrect syntax near CATALOG_COLLATION , SQL80001: Incorrect syntax near ','. We need to compile and clear all syntax errors on Visual studio 2022 to build a pipeline on Azure portal. Do we have any resolution to resolve the errors and compile to get a scripty with out any errors on visual studio.

Any help on this will be appreciated!

On Visual , change your .sql file from .sln project as Build=NOne.

I have the same issue. Getting a syntax warning in Visual Studio 2022, Management Studio and when I try to build it via a Pipeline in DevOps. But I can run the command manually through Management Studio successfully.

I have the same issue. Getting a syntax warning in Visual Studio 2022, Management Studio and when I try to build it via a Pipeline in DevOps. But I can run the command manually through Management Studio successfully.

Yes, these scripts will be successfully execute on management studio as well as in visual studio but on the Pipeline release you will see these errrors. As a work around ,we had to change the property of .sql file on visual studio project as "Build=none" and published to devops repository, in repo for sql project->ItemGroup->Build Include and triggered the release to get it worked. you can try .

Hi, thanks for the reply. I don't really get what you have done.
I've tried to set is a Build=none locally, but that means the External Data Source I've defined gets pissed and don't have a Credential to use => More build errors.
Are you saying I should set all files cascading down from the Credential to Build=None, and then with some settings in the pipeline, get the release to include these files anyway?

Hi, thanks for the reply. I don't really get what you have done.
I've tried to set is a Build=none locally, but that means the External Data Source I've defined gets pissed and don't have a Credential to use => More build errors.
Are you saying I should set all files cascading down from the Credential to Build=None, and then with some settings in the pipeline, get the release to include these files anyway?

yes, set all files to Build=None and if you are using SQL project check in your SQL project properties in visual studio is using the latest Azure SQL verson and then do a rebuild.

Hi, thanks for the reply. I don't really get what you have done.
I've tried to set is a Build=none locally, but that means the External Data Source I've defined gets pissed and don't have a Credential to use => More build errors.
Are you saying I should set all files cascading down from the Credential to Build=None, and then with some settings in the pipeline, get the release to include these files anyway?

yes, set all files to Build=None and if you are using SQL project check in your SQL project properties in visual studio is using the latest Azure SQL verson and then do a rebuild.

I understand the part up until I'm checking it into the repo.
What I didn't understand is how you "reverse" it when building it in DevOps? Because, I guess that if you set build=none, it won't be included in the final product that is deployed, or am I missing something?

Hi, thanks for the reply. I don't really get what you have done.
I've tried to set is a Build=none locally, but that means the External Data Source I've defined gets pissed and don't have a Credential to use => More build errors.
Are you saying I should set all files cascading down from the Credential to Build=None, and then with some settings in the pipeline, get the release to include these files anyway?

yes, set all files to Build=None and if you are using SQL project check in your SQL project properties in visual studio is using the latest Azure SQL verson and then do a rebuild.

I understand the part up until I'm checking it into the repo.
What I didn't understand is how you "reverse" it when building it in DevOps? Because, I guess that if you set build=none, it won't be included in the final product that is deployed, or am I missing something?

Once you rebuild and checkedin to the repo, from repo edit the .sqlproj ItemGroup file to  this will work

Issue still live in VS 2022. Can't build a DB Project. How is this even closed with not even a viable workaround????

@VanMSFT clearly since you closed the issue, you must know of a workaround or fix for it—could you give us a more direct link or description of the workaround?
If not, why is this issue closed?


Replace some asserts in PeerFinder::Logic with LogicError

High Level Overview of Change
It was discovered that it might be possible for the rippled server code to indirect through certain end() iterators.  This problem is caught by assert()s in a debug build, but a release build would simply crash.
If we see problems in this area in the future, we'd like to get a definitive indication of the nature of the error regardless of whether it's a debug or release build.  To accomplish this, these asserts are converted into LogicErrors that will produce a reasonable error message when they fire.
Type of Change

[x] Breaking change (fix or feature that would cause existing functionality to not work as expected)

Can you explain how this is a breaking change?
I think I would consider it a Refactor, if we believe the following to be accurate:
Before
In a release build, in certain situations, the server would crash and not definitively indicate the nature of the error.
After
In a release build, in those same certain situations, the server would crash and definitively indicate the nature of the error, including a reasonable error message.
Reasoning against "Breaking change"
There is no situation in which

with this PR merged, the server would crash, but
without this PR, the server would continue operating.

After writing the Before / After above, I think one could even argue for "New feature", since it adds the "functionality" of a potentially better error message for certain crashes.

@intelliot, that's a fair description.  I very much agree that what would have been a puzzling crash before will now become a crash with an informative error message.  I'm happy to call this a refactor.

  I believe this probably just needs to be brought up to boost 1.82, but I'm not positive.  My build system has been somewhat in flux over the past week.

Hi @HowardHinnant.  My best guess for the problems you're experiencing is that the branch is really stale.  So I just applied a merge commit.  With luck that will help the situation.

@scottschurr : at your convenience, can you confirm whether this PR is ready to merge?
(If you have permission - I'm not sure if you do - you can put the Passed label on)

I will do it


Migrate to node v12

Migrate to Nodejs v12, oldest LTS still getting security patches.

blocks #4


Tests are not passing

On a fresh clone:
~/code/cli-lambda-deploy $ npm i
npm notice created a lockfile as package-lock.json. You should commit this file.
added 46 packages from 507 contributors and audited 46 packages in 2.365s
found 1 low severity vulnerability
  run `npm audit fix` to fix them, or `npm audit` for details
~/code/cli-lambda-deploy $ npm test

><EMAIL_ADDRESS>test /Users/gmauer/code/cli-lambda-deploy
> mocha --timeout 100000 -S -R spec --exit

  new-function JSON config
Lambda config not found (./test/res/new-function-json-v14.lambda )

/Users/gmauer/code/cli-lambda-deploy/node_modules/mocha/lib/runner.js:726
  err.uncaught = true;
               ^

TypeError: Cannot create property 'uncaught' on string 'process exit code 255'
    at Runner.uncaught (/Users/gmauer/code/cli-lambda-deploy/node_modules/mocha/lib/runner.js:726:16)
    at process.uncaught (/Users/gmauer/code/cli-lambda-deploy/node_modules/mocha/lib/runner.js:839:10)
    at process.emit (events.js:314:20)
    at process._fatalException (internal/process/execution.js:163:25)
npm ERR! Test failed.  See above for more details.
~/code/cli-lambda-deploy $

Hi,
tests in the repository need credentials in the environment
you would need to add your own access keys and npm test against your own aws account


Shrinkwrap vlists in table-like CSS.

This PR is not ready to merge, but I'd appreciate feedback on the approach. @ronkok @kevinbarabash
Relevant commit message:
TeX and CSS treat line heights in fundamentally different ways. In
TeX, every character is treated as a box of its precise height and
depth; the line height (\baselineskip) applies after characters have
been assembled into lines. In CSS, in contrast, every character
creates a "line box" corresponding to the accompanying font. When
characters of different fonts and sizes are placed into the same
span, the resulting line box contains the line boxes of all children.
This is unfortunate because, for example, we want \frac{1}{2} to
behave in vertical spacing contexts like it is exactly as tall and
deep as the visible fraction (which is the TeX behavior). Given CSS
constraints, though, in most contexts the fraction has extra vertical
space: the line boxes for the numerator and denominator create
padding. For small boxes, this isn't so bad. To really see the
problem put a tall rule in the denominator of a fraction, or check
out the VerticalSpacing screenshotter test, which has way more space
than it should.
Solving this problem in CSS is difficult. There is no easy way to get
rid of the extra line boxes.
But there is a way, namely tables. A table-cell with vertical-align
top, bottom, or middle is ignored for the purposes of line height
calculation.
So in this commit, makeVList puts its contents into a
vertical-align:top table-cell (to clear unwanted line boxes), with
an extra vertical-align:baseline table-cell used to set the baseline
precisely.
Sadly, this changes many screenshotter tests, mostly by a pixel or
two.

Wow.  Enormously impressive.
Of course this needs lots of cross-browser testing, so I'll help with that. This solves a tough problem.
Now I have a question. There are couple of lines that contain a constant of 0.91:
child.style.top = (-child.strutSize * 0.91 + totalSize - child.bottom) + "em";

    vtable.style.top = (0.91 - vlist.height) + "em";

I expected that value to be 0.9, not 0.91, because the KaTeX fonts have an ascend value of 0.9. Is there any particular reason you used 0.91?
I'm glad you mentioned the extra space in the VerticalSpacing screenshotter test. When I was testing PR #670, I repeatedly saw this kind of extra space, and I'm glad that someone else has noticed it.
In an earlier thread, @gagern mentioned that any use of tables should be careful that the CSS resets table style. I don't think your CSS would conflict, but it is a good thing to keep in mind.

The 0.91—which I've tweaked to 0.9125—was determined empirically.
I also added some comments, and thanks, added the table-layout: fixed I expect @gagern was referring to.
Compatibility could be an issue here. In particular, the vertical positioning in this checkin makes assumptions about (1) the ascender of a particular font, (2) the way line-boxes are calculated. These assumptions are new: the old code did produce different results on different browsers, but only in terms of the extra whitespace around KaTeX math, rather than within the math itself.
According to CSS 2.1 the ascender “should” be calculated using particular font metrics: sTypoAscender, sTypoDescender. But there might be differences on different platforms. So curious what happens on modern, KaTeX-supported browsers.

Sounds very cool!  I've always been confused/annoyed by line boxes, so it's great to see a possible fix in this context.
Regarding @gagern's table comment, he may have also been referring to CSS code like this (taken from my own project), which changes the default style of all tables in a certain context.  Both Markdown tables and KaTeX output could appear in this context (of a Markdown + LaTeX formatted message).  But these rules are relevant only to tags like <table>, <tr>, <td>, not CSS-style tables.  So I think no issue here either.

I've tested this code on my box, on my phone. and on BrowserStack with various styles, sizes, and images. It works great on Edge, IE 9-11, iOS Safari, Mac Safari, Windows Chrome, Android Chrome, Opera, and Firefox.
Terrific stuff.

Thanks @ronkok!!
I had, though, an idea to make the mechanism less sensitive to font ascender dimensions, namely a tall overflow:hidden strut. That makes many Firefox images match the screenshotter versions exactly and seems more robust.
However, Chrome versions don't match—in the horizontal direction. This was a surprise to me. It appears that Chrome rounds table-cell dimensions up to integral numbers of pixels, but does not do this for divs. Example diff attached. Maybe this is a blocker, maybe it's not.

Annoying.  Here's the Chrome issue.

Personally, I think this approach is still worth persuing.  It's not a huge loss, and Chrome will hopefully eventually fix, while we gain... a lot, I think?  Can you show some examples where this new approach to vlists is a significant improvement over the current one?

Oh, I think this PR is a big win. The problem is inherent anytime a tall element is passed as an argument to makeVList. Below are two screen shots of the same HTML.  The first screenshot is from the existing KaTeX master, and the second shot is from the current PR.

That gap in the first shot is the problem. My work used a hack to mitigate it only only for \fbox and \cancel. This PR resolves the problem entirely.

@edemaine thanks for digging up that issue.  It sounds like they want to fix it and are prioritizing it so that's promising.
@kohler since it looks like this bug is going to be fixed in Chrome and it doesn't exist in other browsers the rounding issues probably shouldn't be a block, but it'd be good to do some testing at smaller font sizes to see how much of an impact this has on layouts at those sizes.

@kevinbarabash I've done some tests with 16px fonts, and the rounding issues are present, but not dramatically worse. Three examples from screenshotter tests:

I further updated the CSS. By using two table-rows, and a table-cell with vertical-align: bottom, all reliance on line-height and font ascent can be avoided, and the code is simpler.
Only a small number of firefox test cases change. Most chrome test cases change, because of the rounding issue.
Assuming that the updated CSS works on other browsers—it appears to, but @ronkok, if you could help check that would be amazing—this PR is in my opinion ready to merge.

I am now seeing problems in Safari, on both iOS and Mac. All other browsers (IE, Edge, Chrome, Firefox, Opera) look good. I do my Safari testing on BrowserStack, so it should be checked by someone with native equipment.  Here's a sample of the problems:

Thanks @ronkok! That was a real problem: Safari needed an extra table-cell to position the table correctly. I've fixed that problem and things display well on local Safari, at least.

But wait, accent placement is still off on Safari. Looking.

@ronkok, did you know that accent placement was off on Safari? The \vec’s are rightwards-displaced even on master. The commit I just pushed is correct vertically though.

Yes, the \vec horizontal problem is issue #735. It will need its own solution.

@kohler, That last commit did the trick. This PR now works in Chrome, Firefox, Edge, IE 9-11, Safari, and Opera.
This problem has caused me many hours of frustration, so I'm very glad that you have solved it.

Ping—can a girl get a review? @kevinbarabash

@kohler sorry for the delay.  I'll review this this weekend.

These assumptions are new: the old code did produce different results on different browsers, but only in terms of the extra whitespace around KaTeX math, rather than within the math itself.

I noticed this when reviewing the screenshots.  It seems like there is generally less extra padding which is a good thing imo.

But there might be differences on different platforms.

Awesome article.

Three examples from screenshotter tests:

I was concerned about vertical/horizontal rules getting too close to numbers/letters.  The examples in the screenshot look alright.

Inspired by your question, I changed the PR slightly to produce negative heights and depths when appropriate. Screenshotter tests OK.

@kohler thanks for the PR.  I believe this unblocks https://github.com/Khan/KaTeX/pull/685 and changes to \sqrt previewed in https://github.com/Khan/KaTeX/issues/60.  Is that right @edemaine and @ronkok?

It certainly unblocks the \sqrt changes. I'll work up a PR today.

I'm finding a problem on Safari. It occurs in iOS only, not Mac. The screenshot below is from BrowserStack's rendition of an iPad Pro, iOS 10.3

That is trying to render: \( \color{blue} \sqrt{\frac{\frac{\frac{c}{c}}{c}}{\frac{c}{c}} } + \sqrt{\frac{\frac{\frac{\frac{c}{c}}{\frac{c}{c}} }{c}}{\frac{c}{c}} } \, \sqrt{\frac{\frac{\frac{\frac{c}{c}}{\frac{c}{c}} }{c}}{\frac{c}{\frac{\frac{c}{c}}{\frac{c}{c}}}} } \)

Do you pay for BrowserStack? I looked briefly and it looked painful to get free access.

On Jul 30, 2017, at 12:48 PM, Ron Kok<EMAIL_ADDRESS>wrote:
I'm finding a problem on Safari. It occurs in iOS only, not Mac. The screenshot below is from BrowserStack's rendition of an iPad Pro, iOS 10.3
That is trying to render: ( \color{blue} \sqrt{\frac{\frac{\frac{c}{c}}{c}}{\frac{c}{c}} } + \sqrt{\frac{\frac{\frac{\frac{c}{c}}{\frac{c}{c}} }{c}}{\frac{c}{c}} } , \sqrt{\frac{\frac{\frac{\frac{c}{c}}{\frac{c}{c}} }{c}}{\frac{c}{\frac{\frac{c}{c}}{\frac{c}{c}}}} } )
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

I do pay for BrowserStack. For the short term, at least.

Another way to test on iOS is use the simulator that comes with Xcode.

This appears fine on master (which now has this PR).

I still see the problems. I see them only when the iPad is in portrait orientation, not landscape. That opens up a line of investigation. The page I'm looking at contains some CSS media queries for screen width. Among these are:
@media all {body {font-size: 20px;}}
@media (max-width:830px){body {font-size: 18px;}}
@media (max-width:740px){body {font-size: 16px;}}
@media (max-width:670px){body {font-size: 14px;}}

I'll investigate some more and let you know if I can pin this down further. Maybe not today, though.

@kohler, I've prepared another test page here. This page has CSS body {font-size: 18px;} regardless of screen orientation. This page also shows makeVList problems on Safari - iOS.

Interestingly that test page looks good at 72px and then falls apart as the font size is decreased.

Just wanted to say thank you for this change. I'm working on a canvas renderer implementation, and this is a huge life safer.


file: allocation size adjustment

alloc_size may need to reflect the true size of the file here, not the size rounded up. Trying to append to file does not write through when alloc_size misrepresents the true filesize because file resize not detected.
File resize needed on chunk_down -> chunk_up -> append because chunk_down truncates file extra space, chunk_up restores file with alloc_size misrepresenting true filesize (rounded non-truncated filesize) and append expects the file to be non-truncated size and the write fails.
There are several solution options I tried which all work (the tests fail if none of the following are implemented)

Round up only mmap (implemented)

alloc_size not rounded up and represents true file size
Move alloc_size = size above round up. This keeps mmap length still a multiple of page size, but larger than true filesize

Don't round up alloc_size or mmap (another option -- Preferred but needs confirmation)

Just delete the following ROUND_UP(size, ctx->page_size). mmap length is now the true length of the file.
This seems the most straightforward but I don't know if you want mmap to always allocate in increments of page size for some reason.

Actually resize the file (another option)

A file resize needed at least once before append since file truncated on let down.
Not needed if alloc_size is set since append would detect resize needed and will resize and remap.
Lazy may be better for cases with only read and no append

        /* add the following to the if (fs_size > 0) { ... } block */
        /* Round up filesize to allow for appends */
        size = ROUND_UP(size, ctx->page_size);
        ret = cio_file_fs_size_change(cf, size);

@matthewfala we always need to keep a parity of mmap size and real file size, they should not differ. Looks like this patch makes unsync this consistency

Are you opting for option 2?
This seems the most straightforward but I don't know if you want mmap to always allocate in increments of page size for some reason.

Don't round up alloc_size or mmap (another option -- Preferred but needs confirmation)
Just delete the following ROUND_UP(size, ctx->page_size). mmap length is now the true length of the file.
This seems the most straightforward but I don't know if you want mmap to always allocate in increments of page size for some reason.

round up alloc_size to page_size, both for mmap and file size

So option 3? - Actually resize the file
Avoided because I thought resizing the truncated file up front (since file_down truncates the actual file) might have a performance hit for read only operations where resize can be avoided.
https://github.com/edsiper/chunkio/blob/b2bd14b52ddf60f23d53cc151b4c2e314b139dac/src/cio_file.c#L806-L845
I thought it would be best to allow for the resize to occur when the file_write is called (option 1 or 2)

Actually resize the file (another option)
A file resize needed at least once before append since file truncated on let down.
Not needed if alloc_size is set since append would detect resize needed and will resize and remap.
Lazy may be better for cases with only read and no append
/* add the following to the if (fs_size > 0) { ... } block /
/ Round up filesize to allow for appends */
size = ROUND_UP(size, ctx->page_size);
ret = cio_file_fs_size_change(cf, size);

ahh yeah, you are right, if write is needed we can resize

So, to confirm, you would like to switch from option 1 to option 2?

Don't round up alloc_size or mmap (another option -- Preferred but needs confirmation)

Just delete the following ROUND_UP(size, ctx->page_size). mmap length is now the true length of the file.
This seems the most straightforward but I don't know if you want mmap to always allocate in increments of page size for some reason.

This seems the most straightforward but I don't know if you want mmap to always allocate in increments of page size for some reason.

@edsiper any update on the goal of this pr?
to summarize, implemented option 1. You don't want option 3, and you're not sure if option 2 has performance issues.

@matthewfala looks line this line now is unnecessary:
https://github.com/edsiper/chunkio/blob/bf198da139b02b671742233683a3b7df40d80169/src/cio_file.c#L364
and the mmap operation after that should use alloc_size


Error while resolving modules by name using index.ts file

Expected behavior:
I'm trying to import module with index.ts file by its folder path. For example I have a module testModule with file index.ts in it. I'm importing this module with import testModule from 'testModule'.
Actual behavior:
When I'm trying to import this module by import testModule from 'testModule' I get an error: "Cannot find module testModule". Works fine when I write import testModule from 'testModule/index'.
gulp task
gulp.task 'native:build-ts', ->
  gulp.src paths.nativeTs, base: 'src'
    .pipe ts(ts.createProject 'tsconfig.json')
    .pipe gulp.dest(path.resolve(nativeBuildDir, 'node_modules'))

My tsconfig.json
{
  "compilerOptions": {
    "target": "es6",
    "noImplicitAny": true,
    "jsx": "react",
    "moduleResolution": "classic",
    "experimentalDecorators": true,
    "sourceMap": true
  },
  "files": [
    "./typings/app.d.ts"
  ]
}

These files are only resolved when you set moduleResolution to node.

Holy heck, after several hours, this issue finally helped me with errors I was getting regarding module resolution. I was only getting errors when using ES2016 module type. Changing module resolution to 'node' fixed it.
Seems obvious now, but I'll attach some of the errors in case someone else goes looking.
server/server.ts(9,19): error TS2305: Module '"/Users/jdstewar/gitRepo/prontto/node_modules/@types/graphql/index"' has no exported member 'subscribe'.
server/server.ts(9,30): error TS2305: Module '"/Users/jdstewar/gitRepo/prontto/node_modules/@types/graphql/index"' has no exported member 'GraphQLSchema'.
server/server.ts(10,38): error TS2307: Cannot find module 'graphql-tools'.
server/server.ts(15,36): error TS2307: Cannot find module 'subscriptions-transport-ws/dist'.
server/server.ts(16,25): error TS2307: Cannot find module '../config'.
server/server.ts(17,31): error TS2307: Cannot find module './Application/ProNTTO'.
server/server.ts(18,66): error TS2307: Cannot find module './CoreServices'.
typescript/graphql-iso-date.d.ts(2,12): error TS2305: Module '"/Users/jdstewar/gitRepo/prontto/node_modules/@types/graphql/index"' has no exported member 'GraphQLScalarType'.
typescript/graphql-scalar-types.d.ts(3,12): error TS2305: Module '"/Users/jdstewar/gitRepo/prontto/node_modules/@types/graphql/index"' has no exported member 'ValueNode'.


ragas.evaluate() throws "AttributeError: 'TestDataset' object has no attribute 'rename_columns'."

Having used both https://docs.ragas.io/en/latest/getstarted/testset_generation.html and https://docs.ragas.io/en/latest/getstarted/evaluation.html as the source, I created the following code fragment (distributed among distinct sections in a Jupyter notebook):
`from langchain_openai import (
ChatOpenAI
, OpenAIEmbeddings
)
from ragas.testset.generator import TestsetGenerator
from ragas import evaluate
from ragas.metrics import (
answer_relevancy,
faithfulness,
context_recall,
context_precision,
)
from random import sample
docs = sample(docs,200)
generator_llm = ChatOpenAI(model="gpt-3.5-turbo-16k")
critic_llm = ChatOpenAI(model="gpt-4")
embeddings = OpenAIEmbeddings()
generator = TestsetGenerator.from_langchain(
generator_llm,
critic_llm,
embeddings
)
testset = generator.generate_with_langchain_docs(docs, test_size=10, distributions={simple: 0.5, reasoning: 0.25, multi_context: 0.25})
testset.to_pandas()
score = evaluate(testset,metrics=[answer_relevancy,faithfulness,context_recall,context_precision,])
score.to_pandas()`
The call to "evaluate()" throws, however:
`---------------------------------------------------------------------------
AttributeError                            Traceback (most recent call last)
Cell In[5], line 13
10 testset.to_pandas()
11 # testsetset = Dataset.from_dict(testset)
12 #testset
---> 13 score = evaluate(testset,metrics=[answer_relevancy,faithfulness,context_recall,context_precision,])
14 score.to_pandas()
File C:\Project\explosionPower\ChatGPT\Lib\site-packages\ragas\evaluation.py:153, in evaluate(dataset, metrics, llm, embeddings, callbacks, in_ci, is_async, run_config, raise_exceptions, column_map)
150     metrics = [answer_relevancy, context_precision, faithfulness, context_recall]
152 # remap column names from the dataset
--> 153 dataset = remap_column_names(dataset, column_map)
154 # validation
155 dataset = handle_deprecated_ground_truths(dataset)
File C:\Project\explosionPower\ChatGPT\Lib\site-packages\ragas\validation.py:19, in remap_column_names(dataset, column_map)
14 """
15 Remap the column names in case dataset uses different column names
16 """
18 inverse_column_map = {v: k for k, v in column_map.items()}
---> 19 return dataset.rename_columns(inverse_column_map)
AttributeError: 'TestDataset' object has no attribute 'rename_columns'`
So, is there anything I missed?
The Python version used is 3.11.6, and my requirements are as attached.
requirements.txt

Closed, because probably the wrong GitHub repo to report this...


[$1000] Task - Assignee name disappears when assigned user edits the description

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Action Performed:

Open the testing app by user a
Open the chat with user b
Create a task with a description and assign it to user b
From user b, open the chat with user a
Open the task report that was assigned to you
Click on the description field and edit it, then save
Observe the assignee name (result 1)
Edit the description once again (result 2)

Expected Result:
Result 1: the assignee name should not disappear when user b edits the description
Result 2: changes of the description entered by user b should be saved and should not revert back to old description
Actual Result:
Result 1: the assignee name disappears when user b edits the description
Result 2: changes of the description entered by user b is not saved, and it reverts back to the previous description
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android / native
[ ] Android / Chrome
[ ] iOS / native
[x] iOS / Safari
[x] MacOS / Chrome / Safari
[ ] MacOS / Desktop

Version Number: 1.3.45-1
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
https://github.com/Expensify/App/assets/93399543/646a3459-3964-41f3-af5c-a7d1d1598b59

Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:
View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01f9580c9c3b53638d
Upwork Job ID:<PHONE_NUMBER>883134464
Last Price Increase: 2023-07-25

Proposal
Please re-state the problem that we are trying to solve in this issue.
What is the root cause of that problem?
When we edit the task description we call - editTaskAndNavigate.
In that we use -
https://github.com/Expensify/App/blob/0e2f74289b02912ff4eb2f0fafd7f8c9c389ace6/src/libs/actions/Task.js#L452-L464
In case of managerEmail undefined, we set assignee as undefined.
What changes do you think we should make in order to solve the problem?
We can create a new variable assigneeEmail that we will set as following -
and use it in the API call.
const assigneeEmail = assignee || report.managerEmail || <get email from personaldetails>

API.write(
        'EditTask',
        {
            taskReportID: report.reportID,
            title: reportName,
            description: reportDescription,
            assignee: assigneeEmail,
            assigneeAccountID: assigneeAccountID || report.managerID,
            editedTaskReportActionID: editTaskReportAction.reportActionID,
            assigneeChatReportActionID: optimisticAssigneeAddComment ? optimisticAssigneeAddComment.reportAction.reportActionID : 0,
        },
        {optimisticData, successData, failureData},
    );

What alternative solutions did you explore? (Optional)

@kbecciv are you able to reproduce?

I was able to reproduce.
https://github.com/Expensify/App/assets/27822551/bbb9332d-d192-418b-836c-d0d605773e30

https://github.com/Expensify/App/blob/0fec944de6f8014f6a4586c7d4b988ffdf8ea495/src/libs/BootSplash/index.native.js#L1C1-L12

https://github.com/Expensify/App/blob/0fec944de6f8014f6a4586c7d4b988ffdf8ea495/src/libs/BootSplash/index.native.js#L1C1-L12

test
https://github.com/Expensify/App/blob/0fec944de6f8014f6a4586c7d4b988ffdf8ea495/src/libs/BootSplash/index.native.js#L1C1-L12

This is a permalink
https://github.com/priyankrawat/shoppingList/blob/494da137768814d5070bf960d8196a514f2054fe/babel.config.js#L2

this is a perma
https://github.com/Expensify/App/blob/0fec944de6f8014f6a4586c7d4b988ffdf8ea495/src/libs/BootSplash/index.native.js#L6

I tried reproducing this, in case of old tasks, it is happening.
https://github.com/Expensify/App/assets/27822551/aa011602-1c7d-4c9a-a129-a8829f5938b9

@BhuvaneshPatil you're saying this is only affecting tasks that were created before some specific date, is that right? If so, I think it's not worth fixing and we can just move on. Let me know if I've misunderstood though!


Refactoring several array buffer and typed array functions.

Binary size unchanged (148056 bytes) but .text is reduced from 133088 -> 132936 = 152 bytes.

@jiangzidong


RVIZ hangs on 6.1.2/6.1.3

Hi,
I launch default ros2 run rviz2 rviz2 and it just hangs. Eventually when I control+c I get
Do not call canTransform or lookupTransform with a timeout unless you are using another thread for populating data. Without a dedicated thread it will always timeout.  If you have a seperate thread servicing tf messages, call setUsingDedicatedThread(true) on your Buffer instance.Do not call canTransform or lookupTransform with a timeout unless you are using another thread for populating data. Without a dedicated thread it will always timeout.  If you have a seperate thread servicing tf messages, call setUsingDedicatedThread(true) on your Buffer instance.Do not call canTransform or lookupTransform with a timeout unless you are using another thread for populating data. Without a dedicated thread it will always timeout.  If you have a seperate thread servicing tf messages, call setUsingDedicatedThread(true) on your Buffer instance.

ubuntu 18.04, built from 6.1.2, 6.1.3 tags on dashing

Can you clarify what exactly you built?
I tried building rviz 6.1.3 on top of dashing debs, but am unable to reproduce.

I built a clean workspace of just ros2 repo file packages, then I see this issue with no additional changes.

I built a clean workspace of just ros2 repo file packages, then I see this issue with no additional changes.

Of the master branches or dashing branches? I wouldn't expect RViz 6.1.X to work with the master branches.

On master, got it, thanks!


Add test matrix for running tests under Go 1.10.2

Go 1.10 release notes

Pull Request Test Coverage Report for Build 732

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 68.097%

Totals

Change from base Build 730:
0.0%

Covered Lines:
476

Relevant Lines:
699

💛  - Coveralls

Pull Request Test Coverage Report for Build 732

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 68.097%

Totals

Change from base Build 730:
0.0%

Covered Lines:
476

Relevant Lines:
699

💛  - Coveralls

Pull Request Test Coverage Report for Build 732

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 68.097%

Totals

Change from base Build 730:
0.0%

Covered Lines:
476

Relevant Lines:
699

💛  - Coveralls

Arg. Something seems flaky with the UI tests.


Add last modified date to posts

When writing a blog post, I thought it would be a nice feature to have readers informed of when the post was first published and/or modified.
I would like a small text above the header of the post saying 'Last updated : date' whenever the original post is modified. If it is not modified, it should not post anything. At the bottom of the post, I would like a small text saying 'Originally published : date'. Atleast that is what I think I want :)
Since it is not possible to do in Github Pages yet; https://github.com/github/pages-gem/pull/119 - it is possible to hardcode it: https://tomkadwill.com/adding-last-modified-date-to-jekyll
But I do not know where to put this code.  Not yet, atleast. So thought I could post a feature request here. I'll chime in if I figure this one out.
https://github.com/tomkadwill/tomkadwill.github.io/tree/master/_layouts

Hey @pmarsceill, noticed this was on the release tracker - do you want me to take a crack at this? Looks like just a simple liquid if statement based on a page's front matter.

@malsf21 that'd be great, thank you!

Sounds good! Just forked it, and added a little "Page last modified" to the footer - this is what it looks like.
Before I submit the PR, any feedback? And how would you like me to document this change?

I am partial to the footer -- any chance you can update the time format to be more human readable?

Perhaps the time format could be configurable in _config.yml? Different sites may have different requirements, and hard-coding the format in html makes it difficult to change.

@pmarsceill sure, I can update the time format, it's a date pipe right now. I could add a bit of customization in the _config.yml on the format, though I'm not sure how much customization people would like? I think it'd be just a bunch of if statements based on some key-value pair.

Here's an image of the typical American date/time string:

Good to use the same format strings as Liquid: https://shopify.github.io/liquid/filters/date/
In _config.yml:
date_format: "%Y-%m-%d %H:%M"

In the footer html:
{{ "now" | date: site.date_format }}

Footer could also show other metadata -- such as a link to edit on GitHub. Perhaps all of this could be configurable / toggle-able from _config.yml
# Footer metadata
show_last_edit_time: true
last_edit_time_format: "%Y-%m-%d %H:%M"
show_gh_edit_link: true
edit_link_text: "Edit this page on GitHub"

Thats a great feature, thanks for the implementation

This enhancement is implemented in PR #217, which is already merged into the next minor release.


Could you please add BIOS settings?

Hi! I have problem with your EFI, I'm not able to boot at all. Could you please add your BIOS configuration?
Thank you

hi!, I'll do that over the weekend along with an update.


Policyfixes

Made some changes to the burn/freeze policy logic.
Redemption transactions don't need fees.
Fixed bug in IsPolicy()
Changes to some tests.

Replaced freecoins (CBT) with issued asset in whitelisting.py (freecoins are a policyAsset which is not checked for whitelisting).

IsBurn() has been split into IsAllBurn() and IsAnyBurn().
 Is used to exempt from fees and whitelist check, and to complete the redemption process (i.e. burn frozen outputs).
IsAnyBurn() checks for any non-zero value sent to any null outputs (OP_RETURN or OP_REGISTER address). Used to stop people from destroying tokens (for the benefit of the inflation schedule).

I think the logic needs to be changed. My suggestion is below.
We need to be careful about what happens if one of the outputs is unsolved because an attack could be to manipulate the results of these functions by including an unsolvable output.
Also, sending a non-zero amount to TX_REGISTERADDRESS would constitute a burn, hence the change to IsAllBurn
bool IsAllBurn(const CTransaction &tx, bool defaultForUnsolved=false) {
txnouttype whichType;
vector<vector<uint8_t>> vSolutions;
for (CTxOut const &txout : tx.vout){
if (!Solver(txout.scriptPubKey, whichType, vSolutions)) return defaultForUnsolved;
if (whichType != TX_NULL_DATA || whichType != TX_REGISTERADDRESS) {
return false;
}else if(txout.nValue.GetAmount() == 0) return false;
}
return true;
}
bool IsAnyBurn(const CTransaction &tx, bool defaultForUnsolved=true) {
txnouttype whichType;
vector<vector<uint8_t>> vSolutions;
for (CTxOut const &txout : tx.vout) {
if (!Solver(txout.scriptPubKey, whichType, vSolutions)) return defaultForUnsolved;
if ((whichType == TX_NULL_DATA || whichType == TX_REGISTERADDRESS) && txout.nValue.GetAmount() != 0) return true;
}
return false;
}

Unsolved outputs should be rejected by IsWhitelisted() I think.

Buildkite failure for policytransactions.py. Travis should be failing too, but it isn't for some reason. Same as for whitelisting.py, need to use issued asset for a freezelist test instead of freecoins.

IsAnyBurn() now returns true if any output is burning something, or any output is not solvable.
policytransactions.py now has correct behaviour (freezing an issued asset).


Add Digital Clock Project #914

🛠 Issue (914)

Closes #914
Description
Please include a summary of the change. Please also include relevant motivation and context. List any dependencies that are required for this change.
Type of change
digital clock

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

Checklist:

[ ] I have made this from my own
[ ] I have taken help from some online resourses
[ ] My code follows the style guidelines of this project
[ ] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] My changes generate no new warnings
[ ] The title of my pull request is a short description of the requested changes.

ATTACH SCREEN-SHOTS / DEPLOYMENT LINK

Add Digital Clock Project #914
#914 issue fixed

3D Rotating Cube #1098
#1098 fixed


Wait for document to load

I may have missed this, but it doesn't appear to wait until the document has fully loaded. This means it might not grab all content.

This is probably causing the difference in results here:
~/code 09:19:30
➤ glyphhanger https://pixelambacht.nl --spider --spider-limit=10

 !"#$%&'()*+,-./0123456789:;<=>?@ABCDEFGHIJKLMNOPQRSTUVWXYZ[\]_abcdefghijklmnopqrstuvwxyz{|}×–—‘’“”…™↩✓

~/code 10:05:09
➤ glyphhanger https://pixelambacht.nl --spider --spider-limit=10

 !"#$%&'()*+,-./0123456789:;<=>?@ABCDEFGHIJKLMNOPQRSTUVWXYZ[\]_abcdefghijklmnopqrstuvwxyz{|}×ü‑–—‘’“”…™↩◻✓

Both missing characters (ü and ◻) appear on the homepage from which spidering starts.

Thanks!

Please retest with v1.0.2, if you could!

It still seems to happen with 1.0.2. It's always with the same two characters in my case, both on the homepage (the URL I feed glyphhanger).
You can test for yourself: glyphhanger https://pixelambacht.nl --spider --spider-limit=10
It sometimes misses the ü (in "...#Dynfntday 2016 in München") and the box character (in "I ◻ webfonts – Introduction to fonts...")


Storyboard Required for iOS Submission

Describe the bug
I just created a new app using ignite however I got an error when submitting to Apple. They are requiring a storyboard file. I am wondering if this is something that ignite handles which I may have configured incorrectly. I actually was able to submit my app once without an issue, but my second build for some reason triggered this error from Apple.
I am also using Expo fully. One fix is to open Xcode and make the app "require full screen" but this feels like the wrong solution given I am building within Expo.
[logs] ERROR: Asset validation failed (90476) Invalid bundle. Because your app supports Multitasking on iPad, you need to include the SplashScreen launch storyboard file in your app-name bundle. Use UILaunchScreen instead if the app’s MinimumOSVersion is 14 or higher and you prefer to configure the launch screen without storyboards. For details, see: https://developer.apple.com/documentation/bundleresources/information_property_list/uilaunchstoryboardname (ID: f2bc540e-6148-4983-9691-a9a3997a0ea6)
Ignite version
8.2.10
Additional info
System
platform           darwin
arch               arm64
cpu                8 cores      Apple M1
directory          myAppName     /Users/username/workspace/myAppName
JavaScript (and globally-installed packages)
node                    17.5.0       /Users/username/.nvm/versions/node/v17.5.0/bin/node
npm                     8.19.2       /opt/homebrew/bin/npm
@tmcw/togeojson-cli   2.0.1
eas-cli               2.6.0
expo-cli              6.0.6
firebase-tools        11.14.1
nodemon               2.0.20
npm                   8.19.2
nvm                   0.0.4
serve                 14.0.1
sharp                 0.31.1
yarn                  1.22.19
yarn                    1.22.19      /opt/homebrew/bin/yarn
patch-package         6.4.7
pod-install           0.1.32
pnpm                    -            not installed
expo                    -            not installed
Ignite
ignite-cli         8.2.10       /Users/username/.npm/_npx/e31027f3785124a8/node_modules/.bin/ignite
ignite src         build        /Users/username/.npm/_npx/e31027f3785124a8/node_modules/ignite-cli/build
Android
java               -            not installed
android home       -            undefined
iOS
xcode              13.2.1
cocoapods          1.11.3       /opt/homebrew/bin/pod
Tools
git                git version 2.32.0 (Apple Git-132)   /usr/bin/git

@objectiveSee have you removed the native android/ios directories?

@frankcalise no, they are still there. Should I remove them?

@frankcalise thanks for the quick reply! I tried the steps listed in that link, but now I get a warning when running eas build --platform ios.
First, I made a fresh RN ignite app and ran eas build --platform ios successfully. Then I made the changes per the "pristine" method. Does anything jump out to you as incorrect here?
The actions I took were:

Start with a fresh RN Ignite project
eas build --platform ios works fine! ✅
rm -rf ios/
rm -rf android/
rm index.js
yarn remove react-native-bootsplash
finally, I ran eas build --platform ios

Warning:
It looks like that you are using a custom metro.config.js that does not extend @expo/metro-config.
This can result in unexpected and hard to debug issues, like missing assets in the production bundle.
We recommend you to abort, fix the metro.config.js, and try again.
Learn more on customizing Metro

@objectiveSee mind pasting me the contents of your metro config?

Here is metro.config.js. I haven't touch it since initializing the project:
const { getDefaultConfig } = require("metro-config")
const { getDefaultConfig: getDefaultExpoConfig } = require("@expo/metro-config")

let metroConfig
let isExpo = false
try {
  const Constants = require("expo-constants")
  // True if the app is running in an `expo build` app or if it's running in Expo Go.
  isExpo =
    Constants.executionEnvironment === "standalone" ||
    Constants.executionEnvironment === "storeClient"
} catch {}

if (isExpo) {
  /**
   *  Expo metro config
   * Learn more https://docs.expo.io/guides/customizing-metro

   * For one idea on how to support symlinks in Expo, see:
   * https://github.com/infinitered/ignite/issues/1904#issuecomment-1054535068
   */
  metroConfig = getDefaultExpoConfig(__dirname)
} else {
  /**
   * Vanilla metro config - we're using a custom metro config because we want to support symlinks
   * out of the box. This allows you to use pnpm and/or play better in a monorepo.
   *
   * You can safely delete this file and remove @rnx-kit/metro-* if you're not
   * using PNPM or monorepo or symlinks at all.
   *
   * However, it doesn't hurt to have it either.
   */
  const { makeMetroConfig } = require("@rnx-kit/metro-config")
  const MetroSymlinksResolver = require("@rnx-kit/metro-resolver-symlinks")

  metroConfig = (async () => {
    const defaultConfig = await getDefaultConfig()
    return makeMetroConfig({
      projectRoot: __dirname,
      // watchFolders: [`${__dirname}/../..`], // for monorepos
      resolver: {
        /**
         * This custom resolver is for if you're using symlinks.
         *
         * You can disable it if you're not using pnpm or a monorepo or symlinks.
         */
        resolveRequest: MetroSymlinksResolver(),
        assetExts: [...defaultConfig.resolver.assetExts, "bin"],
      },
    })
  })()
}

module.exports = metroConfig

@objectiveSee understood, can you try something like the following, I'm curious if the expo / vanilla config switching isn't happening properly
const { getDefaultConfig: getDefaultExpoConfig } = require("@expo/metro-config")

let metroConfig = getDefaultExpoConfig(__dirname)

module.exports = metroConfig

@frankcalise I was able to get everything working by doing another fresh app using Ignite and removing the ios and android directories. I am not 100% sure why the metro stuff was not working, but now that is also working fine. Perhaps I ran some incorrect command along the way. I can close this one for now but will re-open if I experience the same issue again.
Appreciate the help!


Ratelimiter Error during clean up

I have a project that is constantly making requests using pulsefire and its ratelimiter, I just looked into the logs of the ratelimiter, and it seems like in very rare cases it throws an error like once every few days.
Error handling request
Traceback (most recent call last):
  File "/usr/local/lib/python3.12/site-packages/aiohttp/web_protocol.py", line 452, in _handle_request
    resp = await request_handler(request)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.12/site-packages/aiohttp/web_app.py", line 543, in _handle
    resp = await handler(request)
           ^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.12/site-packages/pulsefire/ratelimiters.py", line 195, in synchronize
    await self.synchronize(Invocation(**data["invocation"]), data["headers"])
  File "/usr/local/lib/python3.12/site-packages/pulsefire/ratelimiters.py", line 137, in synchronize
    for prev_uid, (prev_request_time, _) in self._track_syncs.items():
RuntimeError: dictionary changed size during iteration

The problem seems to be poping from the dict that is currently iterated over:
        if random.random() < 0.1:
            for prev_uid in list(self._track_syncs.keys()):
                prev_request_time, _ = self._track_syncs[prev_uid]
                if response_time - prev_request_time > 600:
                    self._track_syncs.pop(prev_uid, None) # <-- This

line 139
If you want to see how I use pulsefire here is the repo

@renja-g Will send a fix shortly.

@renja-g fixed with v2.0.10, reopen if issue persist


[help]python client 2.7.2:Send message to another borker

I use python client, use negative_acknowledge to delay consumption several times after, and last time I found  the ack message send  to other brokers

I have three broker.


As a user, I can read an AboutUs page

... so that I can know the people behind the product.

Reopening issue to rectify discrepancies in roles and responsibilities for team members


Only add trait (not lifetime) bounds from methods to T (and update tests)

Fixes #65

@KodrAus in case you find some time to take a look, this comment has another explanation for this change. If you don't have time, don't worry. I would try to release this and all the other stuff as 0.4 soon after merging.
(Oh and, congratulations from me too :wink:)

No worries about not having time to review. But I will just merge this now :)

Thanks for all the good work, @LukasKalbertodt!

@ebkalderon This should also now be released as 0.4.0.


Support Microsoft.Spatial unconditionally in Search

Fixes #13165 and fixes #15299. I'll bifurcate the existing FieldBuilder tests to always test Microsoft.Spatial, but figured this would give a head start on reviewing the implementation.

Is supporting Microsoft.Spatial with System.Text.Json a scenario?

Is supporting Microsoft.Spatial with System.Text.Json a scenario?

For now, no. This is just to enable migration from track 1, which all uses Newtonsoft.Json. This was partly why I was over-complicating matters. But it may be at some point, in which case the encoding and FieldBuilder discovery support should just work, but we'll need to decide where to put JsonConverters for STJ + Microsoft.Spatial.
/cc @tg-msft @AlexGhiondea


Declerative schema

@emicha  , Please change this to AltaPay

@emicha , We need to change this to 'AltaPay for Magento2 Community', Can you do that?

Done:


Swift Package Manager support for iOS

What problem does this feature solve?
iOS Developers cannot use SwiftPM for installing BitcoinKit.
Describe what you've considered?
For now, the difference between apple platforms and Linux are
Apple platforms

Swift flag BitcoinKitXcode

#if BitcoinKitXcode
// code for apple platforms
#else
// code for Linux
#endif

Xcode
Carthage/CocoaPods
dependencies via Xcode()
(Libraries/openssl)
(Libraries/secp256k1)

Build Phase
if [ ! -d "$SRCROOT/Libraries/secp256k1/lib" ] || [ ! -d "$SRCROOT/Libraries/openssl/lib" ]; then
  env -i PATH=$PATH sh "$SRCROOT/setup/build_libraries.sh"
fi

modulemap
BitcoinKit
├── BitcoinKit.h
├── BitcoinKit.modulemap
├── BitcoinKitPrivate.h
├── BitcoinKitPrivate.m
└── Info.plist
Linux

SwiftPM
Sources/BitcoinKitPrivate/BitcoinKit.Private.swift
dependencies via SwiftPM

        .package(url: "https://github.com/vapor-community/copenssl.git", .exact("1.0.0-rc.1")),
        .package(url: "https://github.com/Boilertalk/secp256k1.swift", .upToNextMinor(from: "0.1.0")),
        .package(url: "https://github.com/vapor-community/random.git", .upToNextMinor(from: "1.2.0"))

If I install BitcoinKit to an app via SwiftPM on Xcode11 and run the app now, this error is thrown.
dyld: Library not loaded: /usr/local/opt/openssl/lib/libssl.1.0.0.dylib
  Referenced from: /Users/shunusami/Library/Developer/CoreSimulator/Devices/F835204C-1ACF-4026-BDB3-80A21C0C1F1E/data/Containers/Bundle/Application/706D4A0F-56F9-4618-B7AD-16504D2D262C/Xcode11SandBox.app/Xcode11SandBox
  Reason: no suitable image found.  Did find:
	/usr/local/opt/openssl/lib/libssl.1.0.0.dylib: mach-o, but not built for iOS simulator

I've never created an SPM package before, so I do not know.... but just adding some comments... (that might be confusing or may be helpful)
So the error says that the reference to openssl is not working, as in OpenSSL binary is not embedded (SO answer to similar issue).
So currently Package.swift file contains:
    dependencies: [
        .package(url: "https://github.com/vapor-community/copenssl.git", .exact("1.0.0-rc.1")),
        .package(url: "https://github.com/Boilertalk/secp256k1.swift", .upToNextMinor(from: "0.1.0")),
        .package(url: "https://github.com/vapor-community/random.git", .upToNextMinor(from: "1.2.0"))
    ]

I thought that we, in general, were moving more towards just using C library libsecp256k1, and moving away from OpenSSL all together? If not, maybe we should? And if so, then we can remove the dependency vapor-community/copenssl.git and possibly also  vapor-community/random.git?

Also, hmm... do we need to, or should we do a PR into Boilertalk/secp256k1.swift github repo, adding SPM support? As I said I'm not entirely up to speed on how SPM resolves dependencies of swift projects which does not themselves contain any Package.swift file....

So far (before Xcode11), SPM was almost only for Linux platforms.
In other words, xcodebuild build is for apple platforms, and swift build command is for Linux.
Xcode build phase is dependent on shell files in setup directory. These files are written for apple platforms. So we need to re-write them.
Package.swift dependencies are for Linux. For example, vapor-community/copenssl is a wrapper library of Linux's builtin COpenSSL system library.

@usatie what is the status of SPM? :) does it work on macOS for iOS dev? :)

I tried SPM a couple of days and got the same error as you wrote about above @usatie
dyld: Library not loaded: /usr/local/opt/openssl/lib/libssl.1.0.0.dylib

I wonder if packaging BitcoinKit using brand new XCFramework (XFWK) could resolve the issue? Apple documents it here, WWDC2019 video here

That doesn't help it. I think currently BitcoinKit's SPM only works for Linux.

A little bit late, but possibly useful for everyone stumbling here for the same problem: BitcoinKit integrated with Swift Package Manager (and the problem with OpenSSL).
The problem
Due to a refactor I decided to import BitcoinKit with SPM and not as pod anymore.
Build phase fail due to
Building for iOS-simulator ... but linking in dylib libssl built for macOS

In particular, the error log refers to<EMAIL_ADDRESS>This is due to the fact that OpenSSL is built for macOS but I'm using it in an iOS project.
(Here some reference to similar problems).
The possible solutions
Out of the box solution: forked BitcoinKit, removed  copenssl SPM dependency and changed with OpenSSL. There'll be some deprecation warnings in BitcoinKit.Private but everything is building and working.
Alternatives:

Integrate inside BitcoinKit project OpenSSL built for iOS (Here a good tutorial and here a good scripts sets to compile everything auto-magically)
Try to think about the fact that maybe it should be better to remove OpenSSL, as suggested by @Sajjon in one of his replies, in favor of something else.

Hope this helps!

A little bit late, but possibly useful for everyone stumbling here for the same problem: BitcoinKit integrated with Swift Package Manager (and the problem with OpenSSL).
The problem
Due to a refactor I decided to import BitcoinKit with SPM and not as pod anymore.
Build phase fail due to

Building for iOS-simulator ... but linking in dylib libssl built for macOS

In particular, the error log refers to<EMAIL_ADDRESS>This is due to the fact that OpenSSL is built for macOS but I'm using it in an iOS project.
(Here some reference to similar problems).
The possible solutions
Out of the box solution: forked BitcoinKit, removed  copenssl SPM dependency and changed with OpenSSL. There'll be some deprecation warnings in BitcoinKit.Private but everything is building and working.
Alternatives:

Integrate inside BitcoinKit project OpenSSL built for iOS (Here a good tutorial and here a good scripts sets to compile everything auto-magically)

Try to think about the fact that maybe it should be better to remove OpenSSL, as suggested by @Sajjon in one of his replies, in favor of something else.

Hope this helps!

What do you use BitcoinKit for? This project is obsolete and should have been archived long time ago.
Have a look at my package K1: https://github.com/Sajjon/K1

Still using in one of our project but the idea is to pass to something else.
Thanks for your suggestion


Face Distortion

Hi,
when the face region is relatively small, it tends to become distorted. Is this due to the high compression ratio of dc-ae? Is there a solution to this problem? Would using a 2K image better?
Thank you very much for your wonderful work!!

 This problem will be mitigated in Sana-1.5 with DC-AE 1.5 later this year.

Thanks for your response! Could it be addressed by training facial dataset at a 2K resolution?

Thanks for your response! Could it be addressed by training facial dataset at a 2K resolution?

It will help if you try to fine-tune on some facial datasets with smaller faces.

Thanks for your response! Could it be addressed by training facial dataset at a 2K resolution?

It will help if you try to fine-tune on some facial datasets with smaller faces.

I tried fine-tuning 200k+ facial datasets at 1.5K resolution, which resulted in a slight improvement, but it's still not a perfect solution. Looking forward to SANA-1.5 and new DC-AE!

wow 200k OMG

----- 原始邮件 -----
@.***>
@.***>等3人
主题：Re: [NVlabs/Sana] Face Distortion (Issue #52)
日期：2024年12月04日 14:21:29
Thanks for your response! Could it be addressed by training facial dataset at a 2K resolution?
It will help if you try to fine-tune on some facial datasets with smaller faces.
I tried fine-tuning 200k+ facial datasets at 1.5K resolution, which resulted in a slight improvement, but it's still not a perfect solution. Looking forward to SANA-1.5 and new DC-AE!
A.candid.snapshot.of.travelers.boarding.a.train.at.a.busy.station.with.luggage.in.hand.and.exciteme.jpg (view on web)
—
Reply to this email directly, view it on GitHub, or unsubscribe.
 This problem will be mitigated in Sana-1.5 with DC-AE 1.5 later this year.

@lawrence-cj will DC-AE remain an AE or switch to a VAE?

Impossible to convert to VAE

why?

I think it's because the feature dimensions are different

Impossible to convert to VAE

why?

If you think about it, this is interesting. They went to so much trouble (and published a paper) to switch from VAE to AE and achieve 32x compression.
Now, if you ask them to go back to VAE, they will punch the screen when they hear this.

It is estimated that training such a model costs 200 US dollars, in terms of renting computing power.


Fix reply toggle placement in notes

How it works
After you leave a reply note, reply toggle placement is broken:

How it should work
Reply toggle should be in the same place as for already existing reply note:

Duplicated https://github.com/freeats/freeats/issues/150


Feature idea: delete directory

It would be really useful to be able to delete just one directory.
Maybe a new command or a parameter could be supplied to "clear" eg. "clear /logs"?

Thanks for the idea, In your opinion it is better to delete files inside of the directory or delete directory too?

I think it would be good to mimic the linux rm command, for example
Deletes directory
mpbridge clear dir

Deletes files in directory
mpbridge clear dir/*

I don't know how hard this would be to implement.

It's not hard at all but I'll be glad to hear @Wind-stormger opinion too about this change

I don't think we can keep reinventing the wheel any longer.
Let me be straightforward, if you must use commands, mpremote connect [RPOT] fs rmdir [remote dir] will do it.
The current method of mpbridge deleting files and folders is much simpler and easier than using commands.
Run mpbridge bridge <PORT>, delete files or folders you don't need, end.
So convenient, because it can be operated in the graphical file management interface of your operating system, this is what makes mpbridge unique, at least in my opinion.
If you can only operate in the terminal, mpremote is your best choice.
Have a nice day.

In fact, the one who reinvented the wheel was me.
mpbridge list is completely copied from mpremote connect list. #16  (this is more like copying the wheel)
I have been struggling with this for a long time, but I think that listing available devices is the most basic function that a micropython auxiliary development tool should have, even if this function comes from mpremote, and mpbridge is developed based on mpremote.
To continue reinventing, or copying the wheel, I don't think it's appropriate anymore, this is my personal opinion.

@Wind-stormger I've had the exact idea in my head and that was why I've asked your opinion. Some low level functionalities must be implemented in mpremote itself. Deleting a full directory should be nothing further and more than an empty directory. I think it is better to focus on features that mpremote is not going to have in future. So I will close this issue but feel free to open another one if you have other ideas.


Git must be installed and in your PATH!

Feature suggestion
Please note we will close your issue without comment if you delete, do not read or do not fill out the issue checklist below and provide ALL the requested information. If you repeatedly fail to use the issue template, we will block you from ever submitting issues to Homebrew again.

A detailed description of the proposed feature
I've been trying to update ruby from 2.0.0 to 2.5.0 so I have to update brew. I tried several methods but none work because it says "git: no bottle available!" and "Git must be installed and in your PATH!", even though i have it installed. When I type "which git" I get /usr/bin/git.
I'm getting the following log with this error.
[2021-01-05 16:13:59] requirements_osx_brew_update_system
requirements_osx_brew_update_system ()
{
if __rvm_version_compare "${_system_version}" -ge 10.7; then
__rvm_detect_xcode_version_at_least 4.6.2 || __CLT_version_at_least 4.6.0 || {
\typeset ret=$?;
rvm_error "
Xcode version older than 4.6.2 installed, download and install newer version from:
http://connect.apple.com

After installation open Xcode, go to Downloads and install Command Line Tools.
";
return $ret
};
fi;
brew update || {
\typeset ret=$?;
rvm_error "Failed to update Homebrew, follow instructions at
https://docs.brew.sh/Common-Issues

and make sure `brew update` works before continuing.";
return $ret
}
}
current path: /Users/franciscobouchon
PATH=/Library/Frameworks/Python.framework/Versions/3.7/bin:/Library/Frameworks/Python.framework/Versions/3.4/bin:/Library/Frameworks/Python.framework/Versions/3.7/bin:/usr/local/bin:/usr/bin:/bin:/usr/sbin:/sbin:/opt/X11/bin:/Users/franciscobouchon/.rvm/bin
command(2): requirements_osx_brew_update_system ruby-3.0.0
++ __rvm_version_compare 10.10 -ge 10.7
++ typeset first
+++ command printf %b '10.10\n10.7\n'
+++ printf %b '10.10\n10.7\n'
+++ __rvm_version_sort
+++ command head -n1
+++ head -n1
+++ command awk '-F[.-]' -v OFS=. '{                   # split on "." and "-", merge back with "."
original=$0                                        # save original to preserve it before the line is changed
for (n=1; n<10; n++) {                             # iterate through max 9 components of version
$n=tolower($n)                                   # ignore case for sorting
if ($n == "")                 $n="0"             # treat non existing parts as 0
if ($n ~ /^p[0-9]/)           $n=substr($n, 2)   # old ruby -p notation
if ($n ~ /^0-9/)      $n=substr($n, 1, 1)". "substr($n, 2)   # old jruby 0RC1 notation
if (n == 1 && $n ~ /^[0-9]/)  $n="zzz."$n        # first group must be a string
if (n > 1 && $n ~ /^[a-z]/)   $n=" "$n           # names go before numbers thanks to space
}
print $0"\t"original                               # print the transformed version and original separated by \t
# so we can extract original after sorting
}'
+++ awk '-F[.-]' -v OFS=. '{                   # split on "." and "-", merge back with "."
original=$0                                        # save original to preserve it before the line is changed
for (n=1; n<10; n++) {                             # iterate through max 9 components of version
$n=tolower($n)                                   # ignore case for sorting
if ($n == "")                 $n="0"             # treat non existing parts as 0
if ($n ~ /^p[0-9]/)           $n=substr($n, 2)   # old ruby -p notation
if ($n ~ /^0-9/)      $n=substr($n, 1, 1)". "substr($n, 2)   # old jruby 0RC1 notation
if (n == 1 && $n ~ /^[0-9]/)  $n="zzz."$n        # first group must be a string
if (n > 1 && $n ~ /^[a-z]/)   $n=" "$n           # names go before numbers thanks to space
}
print $0"\t"original                               # print the transformed version and original separated by \t
# so we can extract original after sorting
}'
+++ LC_ALL=C
+++ sort -t. -k 1,1d -k 2,2n -k 3,3n -k 4,4n -k 5,5n -k 6,6n -k 7,7n -k 8,8n -k 9,9n
+++ awk '-F\t' '{print $2}'
++ first=10.7
++ case "$2" in
++ [[ 10.7 == \h\e\a\d ]]
++ [[ 10.7 == \1\0.\7 ]]
++ return 0
++ __rvm_detect_xcode_version_at_least 4.6.2
+++ __rvm_detect_xcode_version
+++ typeset version_file
+++ for version_file in /Applications/Xcode.app/Contents/version.plist /Developer/Applications/Xcode.app/Contents/version.plist
+++ [[ -f /Applications/Xcode.app/Contents/version.plist ]]
+++ [[ -x /usr/libexec/PlistBuddy ]]
+++ /usr/libexec/PlistBuddy -c 'Print CFBundleShortVersionString' /Applications/Xcode.app/Contents/version.plist
+++ return 0
++ typeset __xcode_version=6.3
++ [[ -n 6.3 ]]
++ __rvm_version_compare 6.3 -ge 4.6.2
++ typeset first
+++ command printf %b '6.3\n4.6.2\n'
+++ printf %b '6.3\n4.6.2\n'
+++ __rvm_version_sort
+++ command head -n1
+++ head -n1
+++ command awk '-F[.-]' -v OFS=. '{                   # split on "." and "-", merge back with "."
original=$0                                        # save original to preserve it before the line is changed
for (n=1; n<10; n++) {                             # iterate through max 9 components of version
$n=tolower($n)                                   # ignore case for sorting
if ($n == "")                 $n="0"             # treat non existing parts as 0
if ($n ~ /^p[0-9]/)           $n=substr($n, 2)   # old ruby -p notation
if ($n ~ /^0-9/)      $n=substr($n, 1, 1)". "substr($n, 2)   # old jruby 0RC1 notation
if (n == 1 && $n ~ /^[0-9]/)  $n="zzz."$n        # first group must be a string
if (n > 1 && $n ~ /^[a-z]/)   $n=" "$n           # names go before numbers thanks to space
}
print $0"\t"original                               # print the transformed version and original separated by \t
# so we can extract original after sorting
}'
+++ awk '-F[.-]' -v OFS=. '{                   # split on "." and "-", merge back with "."
original=$0                                        # save original to preserve it before the line is changed
for (n=1; n<10; n++) {                             # iterate through max 9 components of version
$n=tolower($n)                                   # ignore case for sorting
if ($n == "")                 $n="0"             # treat non existing parts as 0
if ($n ~ /^p[0-9]/)           $n=substr($n, 2)   # old ruby -p notation
if ($n ~ /^0-9/)      $n=substr($n, 1, 1)". "substr($n, 2)   # old jruby 0RC1 notation
if (n == 1 && $n ~ /^[0-9]/)  $n="zzz."$n        # first group must be a string
if (n > 1 && $n ~ /^[a-z]/)   $n=" "$n           # names go before numbers thanks to space
}
print $0"\t"original                               # print the transformed version and original separated by \t
# so we can extract original after sorting
}'
+++ LC_ALL=C
+++ sort -t. -k 1,1d -k 2,2n -k 3,3n -k 4,4n -k 5,5n -k 6,6n -k 7,7n -k 8,8n -k 9,9n
+++ awk '-F\t' '{print $2}'
++ first=4.6.2
++ case "$2" in
++ [[ 4.6.2 == \h\e\a\d ]]
++ [[ 4.6.2 == \4.\6.\2 ]]
++ return 0
++ true
++ brew update
Warning: You are using macOS 10.10.
We (and Apple) do not provide support for this old version.
You will encounter build failures with some formulae.
Please create pull requests instead of asking for help on Homebrew's GitHub,
Twitter or any other official channels. You are responsible for resolving
any issues you experience while you are running this
old version.
Error: git: no bottle available!
You can try to install from source with:
brew install --build-from-source git
Please note building from source is unsupported. You will encounter build
failures with some formulae. If you experience any issues please create pull
requests instead of asking for help on Homebrew's GitHub, Twitter or any other
official channels.
Error: Git must be installed and in your PATH!
++ typeset ret=1
++ rvm_error 'Failed to update Homebrew, follow instructions at
https://docs.brew.sh/Common-Issues

and make sure brew update works before continuing.'
++ rvm_pretty_print stderr
++ case "${rvm_pretty_print_flag:=auto}" in
++ case "${TERM:-dumb}" in
++ case "$1" in
++ [[ -t 2 ]]
++ return 1
++ printf %b 'Failed to update Homebrew, follow instructions at
https://docs.brew.sh/Common-Issues

and make sure brew update works before continuing.\n'
++ return 1
The motivation for the feature
All of this is for installing Ruby on Rails. I'm using mac os yosemite, so if anyone had a similar problem I would be so greatful if you could help me.
Thank you so much.
How the feature would be relevant to at least 90% of Homebrew users

What alternatives to the feature have been considered
I've tried different types of installation methods, but none of those work.

Warning: You are using macOS 10.10.

WARNING: You're way outside the Homebrew OS support window, so all installations going forward will be from source (hence the "no bottle available" error), may well fail miserably, and you'll be lucky to get help from anyone at that point.
All that said, what is the output of brew config on your system?

Warning: You are using macOS 10.10.

WARNING: You're way outside the Homebrew OS support window, so all installations going forward will be from source (hence the "no bottle available" error), may well fail miserably, and you'll be lucky to get help from anyone at that point.
All that said, what is the output of brew config on your system?

I'm getting this in brew config
HOMEBREW_VERSION: 2.7.1-143-gb678af3-dirty
ORIGIN: https://github.com/Homebrew/brew
HEAD: b678af3fa33a6faaf8645ca8c1064e58fc2458b5
Last commit: 22 hours ago
Core tap ORIGIN: https://github.com/Homebrew/homebrew-core
Core tap HEAD: eb3250c061f1bb6764be295902541529d8e807df
Core tap last commit: 22 hours ago
Core tap branch: master
HOMEBREW_PREFIX: /usr/local
HOMEBREW_CASK_OPTS: []
HOMEBREW_DISPLAY: /private/tmp/com.apple.launchd.8jdBoFypQf/org.macosforge.xquartz:0
HOMEBREW_MAKE_JOBS: 2
Homebrew Ruby: 2.6.3 => /usr/local/Homebrew/Library/Homebrew/vendor/portable-ruby/2.6.3_2/bin/ruby
CPU: dual-core 64-bit penryn
Clang: 6.1 build 602
Git: 2.3.2 => /Applications/Xcode.app/Contents/Developer/usr/bin/git
Curl: 7.43.0 => /usr/bin/curl
Java: 1.8.0_202, 1.6.0_65-b14-468
macOS: 10.10.5-x86_64
CLT: <IP_ADDRESS>.1.1447826929
Xcode: 6.3
XQuartz: 2.7.11 => /opt/X11

I'm getting this in brew config
HOMEBREW_VERSION: 2.7.1-143-gb678af3-dirty
ORIGIN: https://github.com/Homebrew/brew
HEAD: b678af3fa33a6faaf8645ca8c1064e58fc2458b5
Last commit: 22 hours ago
Core tap ORIGIN: https://github.com/Homebrew/homebrew-core
Core tap HEAD: eb3250c061f1bb6764be295902541529d8e807df
Core tap last commit: 22 hours ago
Core tap branch: master
HOMEBREW_PREFIX: /usr/local
HOMEBREW_CASK_OPTS: []
HOMEBREW_DISPLAY: /private/tmp/com.apple.launchd.8jdBoFypQf/org.macosforge.xquartz:0
HOMEBREW_MAKE_JOBS: 2
Homebrew Ruby: 2.6.3 => /usr/local/Homebrew/Library/Homebrew/vendor/portable-ruby/2.6.3_2/bin/ruby
CPU: dual-core 64-bit penryn
Clang: 6.1 build 602
Git: 2.3.2 => /Applications/Xcode.app/Contents/Developer/usr/bin/git
Curl: 7.43.0 => /usr/bin/curl
Java: 1.8.0_202, 1.6.0_65-b14-468
macOS: 10.10.5-x86_64
CLT: <IP_ADDRESS>.1.1447826929
Xcode: 6.3
XQuartz: 2.7.11 => /opt/X11


Adding ColorPicker widget

Using the native browser color picker.

Travis is showing a SyntaxError. Typos?

I see the same error on master.

Thanks. Seems strange that a commit that changes no javascript would introduce a Javascript SyntaxError, but I will investigate. @jdfreder any hints for finding where the SyntaxError occurs, or what the error actually is?

Darn, just looked at the Travis output, that's weird.  My guess is that it's a problem with one of the requirejs imports.  @minrk printing the error correctly is one of those N-contexts issues, somewhere I'm probably doing String(Error instance) which is not providing enough information.  The best way to go about this one is to reproduce the error as a user.  With so many asynchronous things happening at once the order of events isn't always reliable; however, it does look like the error is getting thrown at the beginningish of page/widgets load.

jupyter/notebook#472 is not related, since these tests are running on Travis with current stable of the notebook (4.0.5), prior to that change. I can also verify that the tests pass when using current master of the notebook. The problem is that one of the patches on 4.0.5 was incomplete. I just cut 4.0.6 with the fixed patch and everything's green here.

Sorry for being misleading here - and thanks for solving the issue.

This is ready.

Thanks!


Configure shoulda-matchers

Since v3.0.0, shoulda-matchers no longer detects the test framework
in use or mixes itself into that framework automatically.
It now requires a configuration block to be included in spec_helper
to specify the frameworks and libraries in use.
See https://github.com/thoughtbot/shoulda-matchers/blob/master/NEWS.md#backward-incompatible-changes

Thanks!