RuntimeError when using dataset cifar

Describe the bug
The following RuntimeError appears when I am trying to run run.py on cifar dataset.
To Reproduce
Steps to reproduce the behavior:

Set up your environment: conda activate pt
Run experiment with python -m mt.examples.run --dataset="cifar" --model="e2,h2,s2" --fixed_curvature=False --epochs=200
See error: Running on: cuda
VAE Model: e2,h2,s2; Epochs: 200; Time: 2021-01-26T16:19:41.074145; Fixed curvature: False; Dataset: cifar
TrainEpoch 0:   Traceback (most recent call last):
File "/home/chaopan2/miniconda3/envs/pt/lib/python3.7/runpy.py", line 193, in _run_module_as_main
"main", mod_spec)
File "/home/chaopan2/miniconda3/envs/pt/lib/python3.7/runpy.py", line 85, in _run_code
exec(code, run_globals)
File "/home/chaopan2/simulations/Py/p3/mvae/mt/examples/run.py", line 169, in
main()
File "/home/chaopan2/simulations/Py/p3/mvae/mt/examples/run.py", line 162, in main
max_epochs=args.epochs)
File "/home/chaopan2/simulations/Py/p3/mvae/mt/mvae/models/train.py", line 118, in train_stopping
train_results[self.epoch] = self._train_epoch(optimizer, train_data, beta=beta)
File "/home/chaopan2/simulations/Py/p3/mvae/mt/mvae/models/train.py", line 188, in _train_epoch
stats, (reparametrized, _, ) = self.model.train_step(optimizer, x_mb, beta=beta)
File "/home/chaopan2/simulations/Py/p3/mvae/mt/mvae/models/vae.py", line 154, in train_step
reparametrized, concat_z, x_mb = self(x_mb)
File "/home/chaopan2/miniconda3/envs/pt/lib/python3.7/site-packages/torch/nn/modules/module.py", line 493, in call
result = self.forward(*input, **kwargs)
File "/home/chaopan2/simulations/Py/p3/mvae/mt/mvae/models/vae.py", line 74, in forward
q_z, p_z, _ = component(x_encoded)
File "/home/chaopan2/miniconda3/envs/pt/lib/python3.7/site-packages/torch/nn/modules/module.py", line 493, in call
result = self.forward(*input, **kwargs)
File "/home/chaopan2/simulations/Py/p3/mvae/mt/mvae/components/component.py", line 33, in forward
z_params = self.encode(x)
File "/home/chaopan2/simulations/Py/p3/mvae/mt/mvae/components/component.py", line 64, in encode
z_mean = self.fc_mean(x)
File "/home/chaopan2/miniconda3/envs/pt/lib/python3.7/site-packages/torch/nn/modules/module.py", line 493, in call
result = self.forward(*input, **kwargs)
File "/home/chaopan2/miniconda3/envs/pt/lib/python3.7/site-packages/torch/nn/modules/linear.py", line 92, in forward
return F.linear(input, self.weight, self.bias)
File "/home/chaopan2/miniconda3/envs/pt/lib/python3.7/site-packages/torch/nn/functional.py", line 1406, in linear
ret = torch.addmm(bias, input, weight.t())
RuntimeError: size mismatch, m1: [100 x 8192], m2: [400 x 2] at /opt/conda/conda-bld/pytorch_1556653215914/work/aten/src/THC/generic/THCTensorMathBlas.cu:268

Desktop (please complete the following information):

OS: CentOS 7.7.1908
PyTorch version 1.1.0
Python version 3.7.3
other additional Python packages installed by requirements

Sorry for the delay, will take a look at this this evening.
On Tue, Jan 26, 2021 at 5:35 PM thupchnsky<EMAIL_ADDRESS>wrote:

Assigned #7 https://github.com/oskopek/mvae/issues/7 to @oskopek
https://github.com/oskopek.
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub
https://github.com/oskopek/mvae/issues/7#event-4251604508, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AAN2KBGEIHKDEMIRBUAZFS3S33VODANCNFSM4WTXVUVA
.

Sorry for the delay, will take a look at this this evening.
On Tue, Jan 26, 2021 at 5:35 PM thupchnsky<EMAIL_ADDRESS>wrote:

Assigned #7 https://github.com/oskopek/mvae/issues/7 to @oskopek
https://github.com/oskopek.
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub
https://github.com/oskopek/mvae/issues/7#event-4251604508, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AAN2KBGEIHKDEMIRBUAZFS3S33VODANCNFSM4WTXVUVA
.

This should be fixed in 28654a91079b95162cbe8139c3c8f9f0ec9f921e. Please let me know if it still doesn't work. To use the ConvVAE with CIFAR, you'll have to additionally specify --h_dim:
python -m mt.examples.run --dataset="cifar" --model="e2,h2,s2" --fixed_curvature=False --epochs=200 --architecture="conv" --h_dim=8192

This should be fixed in 28654a91079b95162cbe8139c3c8f9f0ec9f921e. Please let me know if it still doesn't work. To use the ConvVAE with CIFAR, you'll have to additionally specify --h_dim:
python -m mt.examples.run --dataset="cifar" --model="e2,h2,s2" --fixed_curvature=False --epochs=200 --architecture="conv" --h_dim=8192


Can't install through the dalamud pluginlist

After clicking install it gets stuck for a min and then nothing happens

In-game, if you open the plugin log with /xllog then try to install the plugin, do you get an error in the log?

xxllogs.txt
Here

Dalamud issue. Possibly related to specific AV not wanting to let Dalamud download the code.


support alt server certs in Linux and Docker deployments

done - this is already a feature of ziti create config controller, and the controller deployments for Linux and Docker support the same env vars with prefix ZITI_. These are passed-through blindly with a few exceptions that are necessary to simplify the user experience, e.g., single port operation with ALPN means that discrete port's respective vars are synonymous.


500 upon authentik OAuth2/OpenID: login

Description
I configured Authentik and Gitea as described in this manual. When trying to login via this OAuth-Flow I encounter a http 500 error and cannot log in via this flow. Reloading does not solve the problem (#5005).
The server log says:
oauth2: error decoding JWT token: jws: invalid token received, not all parts available

Callback that fails with 500: https://git.hyteck.de/user/oauth2/QZT Authentik/callback?code=c26c5f75c939524d98f5f67e3d58c6b6&state=08176cae-79d6-46a3-04c7-36670db77079 (not  the real code or state).
I specifically configured
samesite: Lax as per https://github.com/go-gitea/gitea/issues/25542, same for GITEA__server__ROOT_URL=https://git.hyteck.de (I also tried including a backslash at the end)
I also set GITEA__oauth2_client__ENABLE_AUTO_REGISTRATION=true
I'm looking for ways to debug this further. Feel free to ask for more information.
Gitea Version
1.22.3
Can you reproduce the bug on the Gitea demo site?
No
Log Gist
https://gist.github.com/moan0s/6e214403d9f1cd15265259455529b3fb
Screenshots
No response
Git Version
No response
Operating System
docker (running on ubuntu)
How are you running Gitea?
Gitea is run as docker container started by a systemd service as deployed by the mash-playbook, same for authentik.
Both run behind Traefik.
Database
PostgreSQL

Works for me by following the linked tutorial. I even tried to use a name with a space like you did but that worked too.

@KN4CK3R Okay, well I guess I check again if I really followed every step of the tutorial. Either way, the error message should be more clear IMHO.
Yeah, in my setup everything is publicly reachable

Same problem for me
Maybe it would help, I'm using those configs:
DISABLE_REGISTRATION = true
REQUIRE_SIGNIN_VIEW = true

The idea is that the SSO will only let users to link their Authentik account with their existing gitea one
(no registration are allowed to let me control who can access to my instance)

It seems gitea cannot use JWE.
It is necessary to disable token encryption in the authentik provider.

Thank you so much, that was it!


[Image] Cannot load the photo on the Windows

I use react-native start the server,
on Linux ,it's work
on Windows, The pictures don't show.
for android

Duplicate of #3980


Add ikea rodret

Proposed change
Added signature to match Ikea's Rodret dimmer button.
Additional information
Rodret is basically same as Tradfri without alarm input cluster and without window covering output cluster. Tested as a standalone quirk
Checklist

[ ] The changes are tested and work correctly
[ ] pre-commit checks pass / the code has been formatted using Black
[ ] Tests have been added to verify that the new code works

You need putting one more empty line between the old last class and the new one (shall being 2 lines is only one) (Line 198) then the test shall working OK.


Remove toastr as a global and import missing toastr css

Toastr messages do not display properly because the css associated with
the package is not being imported. This change removes Toastr as a
global (it is only used in the logger module) and imports the missing
css.
Before:

After:

Also modify the eslintrc.json file to support ES6 module import/export
syntax.
Finally remove the Toasts factory as it is not used anywhere.

https://www.pivotaltracker.com/story/show/137965363
@miq_bot add_label euwe/no, bug

@jjlangholtz Why not remove toastr all together and use EventNotifications?  Do we really need to have two notification libs?

@AllenBW Totally on board with that option as well, actually we have three notification libs: toastr, EventNotifications (SUI exclusive), and Notifications from angular patternfly. I'll put some feelers out to what the level of effort is to consolidate on one option.

EventNotifications ties in with the nav bar and I believe the one we would want to keep
Roping in @jeff-phillips-18 as he is da 🏄 on this

@miq-bot add_label euwe/no, bug


TEIIDTOOLS-718 directly wiring the connection synchronization logic

@rareddy see if this seems ok to you.  This removes the service layer from the syncronizer calls - which allows us to remove a couple more service methods.  The only real difference is the removal of the retry logic, that I don't think that is needed with this change.

Great, I see you converted to them to method calls from service calls, that make it no need to re-try logic.


List Spot Markets in the Market Switcher

Story
As a Console user
I want to be able to view a list of active spot markets in the Market Switcher panel
So that I know they exist and can choose to view one
Acceptance Criteria

[ ] I can view a list of all Spot markets in the 'Spot' tab of the Market Switcher (ordered however we order normal markets)
[ ] They obey all the normal rules of that selector in terms of filters / sorts etc

Tasks

[ ] UX (if needed)
[ ] Design (if needed)
[ ] Team and stakeholder review
[ ] Specs reviewed and created or adjusted
[ ] Implementation
[ ] Testing (unit and/or e2e)
[ ] Code review
[ ] QA review

Sketch
Additional details / background info

This is done

This already worked ...


syb-0.6

syb-0.6 depended on by:

ChasingBottoms-<IP_ADDRESS> (>=<IP_ADDRESS> && < 0.6). No maintainer.
aeson-schema-<IP_ADDRESS> (>=0.4.4 && < 0.6). Mateusz Kowalczyk<EMAIL_ADDRESS>@Fuuzetsu. @Fuuzetsu
fay-<IP_ADDRESS> (< 0.6). Adam Bergmark<EMAIL_ADDRESS>@bergmark
haskell-src-meta-<IP_ADDRESS> (>=0.1 && < 0.6). No maintainer. @bmillwood
language-c-quote-0.11 (>=0.3 && < 0.6). Francesco Mazzoli<EMAIL_ADDRESS>@bitonic. @mainland
pandoc-<IP_ADDRESS> (>=0.1 && < 0.6). No maintainer. @jgm
pandoc-types-<IP_ADDRESS> (>=0.1 && < 0.6). No maintainer. @jgm
stylish-haskell-<IP_ADDRESS> (>=0.3 && < 0.6). Jasper Van der Jeugt. @jaspervdj

Due to large number of authors involved here: no need to ping the issue as packages are updated

Update: only 2 to go.
syb-0.6 depended on by:

ChasingBottoms-<IP_ADDRESS> (>=<IP_ADDRESS> && < 0.6). No maintainer.
aeson-schema-<IP_ADDRESS> (>=0.4.4 && < 0.6). Mateusz Kowalczyk<EMAIL_ADDRESS>@Fuuzetsu. @Fuuzetsu

ChasingBottom got new revision. Only aeson-schema left. Ping @Fuuzetsu

We decided to start the new year and the upcoming LTS 4 with a
clean slate. We'll be disabling most packages that block
upgrades. Please send a pull request to re-enable your package if
you update it. If you do so before new years you'll be included
in LTS 4.


[Test] Adding delay for serial port initialization.

I'm working on a new target and the serial port is taking some extra time to initialize. Without any delay I get the following exception when the test tries to read from the CDC_ACM class.

serial.serialutil.SerialException: device reports readiness to read but returned no data (device disconnected or multiple access on port?

The tests executing before the serial test are resetting the device and the serial test is executing before the HIC serial port is ready.

What target/board is this for? Could you provide steps so I can reproduce this problem?

I'm working on the MAX32625MBED, MAX32625HSP, and MAX32625NEXPAQ. Not sure if we've sent any to you guys yet.

Ended up being a problem with my computer.


SDK-2033 Update README

Linear Ticket: SDK-2033
Changes:

Update main README with information about the organization of the repository and notes about how to run the example/workbench apps

Notes:

Checklist:

[x] I have verified that this change works in the relevant demo app, or N/A
[x] I have added or updated any tests relevant to this change, or N/A
[x] I have updated any relevant README files for this change, or N/A

Approved, great job! One question I have that I may have never asked before is: does android have the equivalent of a bundle id you need to add to the dashboard or no? I don't see it in this write up but I have never asked before so maybe its not an oversight?

It does, yeah, it's an "application ID". It's covered in the "Getting Started" section of the README!


Explain how to compute balance of a single address

see https://github.com/square/beancounter/issues/44

Pull Request Test Coverage Report for Build 212

0 of 0   changed or added relevant lines in 0 files are covered.
3 unchanged lines in 1 file lost coverage.
Overall coverage decreased (-0.2%) to 41.208%

Files with Coverage Reduction
New Missed Lines
%

backend/fixture_backend.go
3
75.35%

Totals

Change from base Build 210:
-0.2%

Covered Lines:
532

Relevant Lines:
1291

💛  - Coveralls

Pull Request Test Coverage Report for Build 212

0 of 0   changed or added relevant lines in 0 files are covered.
3 unchanged lines in 1 file lost coverage.
Overall coverage decreased (-0.2%) to 41.208%

Files with Coverage Reduction
New Missed Lines
%

backend/fixture_backend.go
3
75.35%

Totals

Change from base Build 210:
-0.2%

Covered Lines:
532

Relevant Lines:
1291

💛  - Coveralls


Retrieve policies to table and get policy

get policies should print the results as a table instead of a list
The table should have 3 columns: ID, Name, and Description
The ID should be the first 5 chars of the Event ID where the policy is saved.
get policy <policy_id> should print the entire policy, which includes the TapTree and bitcoin balances

get policy would render print the default handler that is already done, although we should probably add the Event ID to it as well, like I've shown below.
Coinstr Policy
ID                 : <event_id>
Name           : Board Members 3 of 5
Description    : Vault for first funding round in 2021

Board Members 3 of 5
└── id -> kcktanuq
    └── 🤝 MultiSig  :  3 of 5
        ├── <pk:022ba604a35bdde296bff3076393684b6f1cb24bb2bf71b4c16b2bffc447d40b59>
        ├── <pk:0234721bbe87462cd2b488cf959e76f84f7acb37ad49b0d73bb5ac15cd09a87be6>
        ├── <pk:023e5e307c0209af16a17c6f5447ccdeac4d55715139469e47e5af712b7ec41053>
        ├── <pk:02a7f409833739e7aa7ca082015c46a7160068093e488223989efae9094704bfda>
        └── <pk:022ad388345f36e22ca8226ffd6e6863d0278b581ff7167ce4c6d12d9712afed72>

Bitcoin Balances (sats)
  Immature              : 0
  Trusted Pending       : 0
  Untrusted Pending     : 0
  Confirmed             : 0


let g:nerdtree_tabs_open_on_gui_startup=0 does not persist between tabs

If you set let g:nerdtree_tabs_open_on_gui_startup=0 in your .vimrc and then open NERDTree and press t on a file, it opens a new tab, but the tree is closed in the new tab. I don't want it to open on startup, but I do want it to open when creating a tab from nerdtree. Is this possible?

I do not want to implement exactly the behavior you proposed as a part of the plugin, at least not right now, because I feel like this demand is specific for your particular vim workflow and would not appeal to many others.
I can implement :NERDTreeMirrorOpen command, which would work similar to NERDTreeMirrorToggle, but would only perform opening, not toggling. This function might come in handy other times as well. You could then map it to TabEnter event and it would make sure that NERDTree is open every time you switch a tab.
Would this be an OK solution?

I just want nerdtree to feel like an actual sticky sidebar regardless of what tab i'm in. Isn't that part of the goal of this plugin? But it's very annoying to have it open in every new tab I make even if it's closed in my current one. Especially when I start up macvim and nerdtree is open, but the root isn't the directory I want it to be. Normally inside vim I :cd dir then open nerdtree so it knows the right root.

And are you using :NERDTreeTabsToggle to open the tree?
Try this:

Open MacVim.
:cd where you want.
Do :NERDTreeTabsToggle (This tells the plugin to toggle NERDTree on for all tabs, including new ones, simple :NERDTree won't do, because I didn't want to make the plugin too invasive. Maybe I'll rethink that in the future, though.)
Open a new tab, NERDTree should be open and synchronized.

Is it ok now?

Aw man, that's exactly what I wanted. I was using :NERDTreeToggle . I changed it to yours and now it seems to be working great.

This is super helpful, that wasn't apparent to me either. Thanks for the help and awesome plugin @jistr!
For a little extra context, in ~/.vimrc you've likely set a binding to open/close NERDTree, mine looked something like this:
map nt :NERDTreeToggle<CR>

Update that to:
map nt :NERDTreeTabsToggle<CR>

Now I can toggle NERDTree open by pressing "nt" and it will be open in all tabs, then toggle it close again across all tabs by pressing "nt" another time.


ClickHouseResultSet.getObject() works incorrectly for Nullable data types.

ResultSet incorrectly returns 0.0 instead of null for my Nullable(Float32) column. Looking into the sources I have found that getObject() returns default column value, which is taken from nested data type in case of Nullable.
https://github.com/housepower/ClickHouse-Native-JDBC/blob/fa6b1d3b543da9bd9934948f45ff984e61c8bf31/src/main/java/com/github/housepower/jdbc/ClickHouseResultSet.java#L185

As some work-around I'm checking rs.wasNull() after calling rs.getDataType(columnNum) to check if the returned value is actually a null.

Yes, when you are using getXXX()  for nullable column, always call rs.wasNull() method to check.


Add field set component

Description
I have separated the fieldset component from the CheckboxGroup, so that it can be used other places, like in the future radio button group. It will also be useful in the data modelling part of Altinn Studio. Ideally there would be designated Figma tokens for this, but for now I have just reused the checkbox-related tokens that were used on the CheckboxGroup. At the moment checkboxes are the only thing it's used for anyways.
Related Issue(s)

#155

Verification

[x] Your code builds clean without any errors or warnings
[x] Manual testing done (required)
[x] Relevant automated test added (if you find this hard, leave it and we'll help out)
[x] All tests run green

Documentation

[ ] User documentation is updated with a separate linked PR in altinn-studio-docs. (if applicable)

Codecov Report
Base: 97.52% // Head: 97.58% // Increases project coverage by +0.05% :tada:

Coverage data is based on head (94bb5a5) compared to base (190e190).
Patch coverage: 100.00% of modified lines in pull request are covered.

:exclamation: Current head 94bb5a5 differs from pull request most recent head 8990aee. Consider uploading reports for the commit 8990aee to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #161      +/-   ##
==========================================
+ Coverage   97.52%   97.58%   +0.05%
==========================================
  Files          50       52       +2
  Lines         526      538      +12
  Branches      136      136
==========================================
+ Hits          513      525      +12
  Misses         13       13

Impacted Files
Coverage Δ

src/components/CheckboxGroup/CheckboxGroup.tsx
100.00% <100.00%> (ø)

src/components/FieldSet/FieldSet.tsx
100.00% <100.00%> (ø)

src/components/FieldSet/index.ts
100.00% <100.00%> (ø)

src/components/index.ts
100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


fix: Remove docs test for now

This change removes the docs test which is blocking other PRs for the time being.

Add this later if docs tests block again.


stacked barplot: hovertool info does not appears, if only one kind of the stacked types is in the bar.

see html below. this seems to be a bug

<!DOCTYPE html>

      <meta charset="utf-8">
      <title>Bokeh Plot</title>

Hi @spfeifer222,
I can reproduce the error. Could you provide me a minimal code example for debugging please?
Thanks for reporting the bug
Best Patrik

Dear @PatrikHlobil ,
today I took time to have a closer look the problem.
My observations:

The datatype of the columns is float64, where any of the integer datatypes should be used. But however, this should not lead to fail printing the data correctly. I guess this is not problem, but I added this for your information.
There are NaN values in the data, which seems to be completely ignored instead of concidering  as 0 (zero). I don't now if this would be the same in the original bokeh module. Could you tell me, if this is the case? The problem seems to be worse, if the first column contains a NaN value. In this case the hole row is completely ignored.

From these observations I constructed the following minimal example:
import numpy as np
import pandas as pd
import pandas_bokeh

df_test = pd.DataFrame([[np.nan, 1.0], [2.0, np.nan], [2.0, 1.0]], columns=['Handelsname', 'anderer'])
df_test.plot_bokeh.bar(ylabel='Anzahl', xlabel='Länge', vertical_xlabel=True, stacked=True, title='Produktnamen', fill_alpha=0.7)

Of course this problem could be solved by proper datatype handling, but vor convenience it would be great, if pandas_bokeh would be robust in such cases.


Get rid of deprecated SslContext methods in handler-proxy tests

Motivation:
ProxyHandlerTest package uses deprecated methods SslContext.newServerContext and
SslContext.newClientContext.
Modifications:
SslContextBuilder is used to build a server and client SslContext.
Result:
Reduced the usage of deprecated methods in the code.

@kachayev <3 Thanks a lot!


Finding clang+llvm the right way

I have been trying (and failing) for hours to figure out how to properly call vswhere.exe to find the clang+llvm install path corresponding to the Microsoft.VisualStudio.Component.VC.Lllvm.Clang component.
Here is what I want to query for: find the latest clang+llvm installation path, with a preference for a specific host architecture (x64 over x86). I do not desire anything beyond finding this installation path, I just want to use it the same way I would with the llvm.org clang+llvm distribution for Windows that is installed in "C:\Program Files\LLVM" by default. From that install path I should be able to find clang.exe and other tools under the bin directory for manual invocation outside of MSVC. My first use case is to find clang.exe in a Rust build script to compile Windows ARM64 assembly files, which is much easier than trying to use the limited armasm64.exe MSVC tool.
The best query I could come up with is not very satisfying and returns both the x86 and x64 builds of clang+llvm:
vswhere.exe -latest -requires Microsoft.VisualStudio.Component.VC.Llvm.Clang -find 'VC\Tools\Llvm\**\bin\clang.exe'
Here is a screenshot showing the location of clang.exe in both x86 and x64 visual studio command prompts:

The ideal output for the query should be:
C:\Program Files (x86)\Microsoft Visual Studio\2019\Professional\VC\Tools\Llvm\x64
The x86 clang+llvm is less desirable, but would still be useful on Windows 10 on ARM where x64 emulation is not available:
C:\Program Files (x86)\Microsoft Visual Studio\2019\Professional\VC\Tools\Llvm
I haven't found a way to query just the clang+llvm install path for a given host architecture. The visual studio command prompt is actually much easier in that regard, but I don't feel like wrapping vcvarsall.bat to obtain PATH modifications and then figuring out the install path from the detection location of clang.exe.
Surely vswhere.exe can solve this in a much cleaner manner? Something like "find latest clang+llvm install path, x64". Thanks a lot!

vswhere is for finding VS - not individual components, for which we do not store enough information. If you want to find a particular architecture for LLVM you can pass that as part of the path, e.g. -find VC\Tools\LLVM\bin\clang.exe. But if you already know the path, why bother? Get the root installation path and just concatenate either path. -find was meant for some tools that have frequently-changing paths like the VC compiler, though they did add a better way that requires a few steps but helps you find the version you want. Our wiki has more information.

Does that mean vswhere.exe is not really a modern vcvarsall.bat replacement, but really just a command-line tool to find the Visual Studio installation root path (VSINSTALLDIR) from which the other MSVC environment variables and paths can be derived? In other words, vswhere is to MSVC what xcode-select is to Xcode, nothing more?
The example showing a rather complex command to find msbuild using vswhere gives the impression that it could (and should) be used for more than just the root installation path. I figured, why would it not simply give me the root installation path of MSVC clang+llvm?
vswhere is commonly used in a lot of build scripts now, and I have mostly seen it used to find VSINSTALLDIR and msbuild.exe, not much beyond that. I have used it myself to reconstruct what vcvarsall.bat does inside a cmake toolchain file: https://github.com/Devolutions/CBake/blob/master/windows-msvc.toolchain.cmake
Now that I know, I will keep my vswhere usage to the bare minimum and build my own detection code on top of it - it's not a vcvarsall.bat replacement at all.

It always was a way to find the root installation - never as a replacement for vcvars. It's used in a lot of build tools, yes, to find the root from which to build on. You can use it to find vcvars, which we have a sample in our wiki.
Dev15 uses a completely different install that enables installing multiple instances of the same version (or minor/patch updates) to different directories, useful for trying out new features or upgrading a toolset without affecting other project requirements. vswhere is useful to help find an instance that meets your needs, like a release (default) or prerelease with components X, Y, and Z.

Thanks for the clarification. May I suggest that the vswhere readme make its purpose clearer? Yes, it does state it is a Visual Studio locator, but the part about finding specific tools like msbuild may give the impression that it's more than that - a simple mention that vswhere is not a vcvarsall.bat replacement would suffice in my mind. I understand it may look like I'm probably the only one who got confused, but it wouldn't hurt just to state what it isn't with one sentence.

I came up with a clean-enough MSVC clang detection technique that only relies on locating the Visual Studio root to then reconstruct the same environment variables normally provided by vcvarsall.bat, and end up with the proper LLVM_ROOT. Feel free to add it to your vswhere samples if you wish, it can be useful to other people:
$VSINSTALLDIR = $(vswhere.exe -latest -requires Microsoft.VisualStudio.Component.VC.Llvm.Clang -property installationPath)
$VCINSTALLDIR = Join-Path $VSINSTALLDIR "VC"
$LLVM_ROOT = Join-Path $VCINSTALLDIR "Tools\Llvm\x64"
$Env:PATH += ";$LLVM_ROOT\bin"


Implement SqlSerializer for IsTrue

Backgrounds

In Kotlin JDSL 3.0.0, the SQL Query objects no longer know how to draw themselves as SQL String
The SQL Query object is drawn in SQL String by com.linecorp.kotlinjdsl.render.sql.serializer.SqlSerializer.

Requirements

Please implement  SqlSerializer that draws com.linecorp.kotlinjdsl.querymodel.sql.impl.IsTrue as a SQL String.
Please implement a unit test for the implemented class.

Samples

com.linecorp.kotlinjdsl.render.sql.serializer.impl.NormalInsertQuerySerializer in develop/3.0.0 branch
com.linecorp.kotlinjdsl.render.sql.serializer.impl.ColumnSerializer in develop/3.0.0 branch
com.linecorp.kotlinjdsl.render.sql.serializer.impl.AliasedTableSerializer in develop/3.0.0 branch

Contribution

Please check if there is an assignee in this issue. And if it don't have an assignee, please change the assignee to yourself.
Please check the commit convention through the commitlint.config.js file. The commit  convention also described in the PR template.
When you use intellij, please set the code style through the .editorconfig file.
Please create the PR for develop/3.0.0 as the base branch.
If you have any questions, please leave comment in Kotlin-JDSL Discord Channel in LINE Open Source

assignee로 할당 부탁드립니다!


Adding new programs and fixing CMakeLists.txt version

This PR back to main also creates new programs.

longdiv.cpp : Does long division
resistance.c : Calculates series and paralell resistance
Fixes version in CMakeLists.txt

No conflicts found, merging this PR back to main.


Ft docs

Description

Motivation and Context
 This change enables users working with cwlviewer and running the application with docker-compose to be able to connect the application to a java debugger on the local, inspect the containers and debug their application.
#319
How Has This Been Tested?
 N/A
N/A
N/A
Screenshots (if appropriate):
Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[x ] My change requires a change to the documentation.
[x ] I have updated the documentation accordingly.
[ ] I have added tests to cover my changes.
[ ] All new and existing tests passed.

Hey @mr-c , @tetron, @stain  I have raised a PR for the documentation on connecting a java debugger to the cwlviewer application while running with docker-compose. Please review.

Hey @mr-c I just figured the images are not showing in this link that you pasted on gitter https://github.com/common-workflow-language/cwlviewer/pull/327/files?short_path=b335630#diff-b335630551682c19a781afebcf4d07bf978fb1f8ac04c6bf87428ed5106870f5
And I don't really know what to call those buttons for cases where the image doesn't show

I think this can be closed. It's easier to debug it with the IDE locally, starting the DB & Fuseki only with docker compose. The readme contains information about docker compose already, and using that to debug should be straightforward to a Java developer (the IDE steps will vary a bit, but I think we shouldn't document it in our readme).


Worker: Execute contract execution got akka exception

Configure parallel akka testing with lighthouse, workers. During execute contracts throw akka exception, message details in below:
[ERROR][9/29/18 4:43:26 AM][Thread 0011][[akka://AElfSystem/system/endpointManager/reliableEndpointWriter-akka.tcp%3A%2F%2FAElfSystem%40<IP_ADDRESS>%3A44209-5/endpointWriter#1872245061]] AssociationError [akka.tcp://AElfSystem@<IP_ADDRESS>:32554] -> akka.tcp://AElfSystem@<IP_ADDRESS>:44209: Error [Index was outside the bounds of the array.] [   at Hyperion.Serializer.GetDeserializerByManifest(Stream stream, DeserializerSession session)
at lambda_method(Closure , Stream , DeserializerSession )
at Hyperion.Serializer.Deserialize[T](Stream stream)
at Akka.Serialization.HyperionSerializer.FromBinary(Byte[] bytes, Type type)
at Akka.Serialization.Serialization.Deserialize(Byte[] bytes, Int32 serializerId, String manifest)
at Akka.Remote.Serialization.MessageContainerSerializer.FromBinary(Byte[] bytes, Type type)
at Akka.Serialization.Serialization.Deserialize(Byte[] bytes, Int32 serializerId, String manifest)
at Akka.Remote.DefaultMessageDispatcher.Dispatch(IInternalActorRef recipient, Address recipientAddress, Payload message, IActorRef senderOption)
at Akka.Remote.EndpointReader.b__11_1(InboundPayload inbound)
at lambda_method(Closure , Object , Action1 , Action1 , Action1 )    at Akka.Actor.ReceiveActor.ExecutePartialMessageHandler(Object message, PartialAction1 partialAction)
at Akka.Actor.UntypedActor.Receive(Object message)
at Akka.Actor.ActorBase.AroundReceive(Receive receive, Object message)
at Akka.Actor.ActorCell.ReceiveMessage(Object message)
at Akka.Actor.ActorCell.Invoke(Envelope envelope)]
Cause: Unknown
[WARNING][9/29/18 4:43:26 AM][Thread 0011][[akka://AElfSystem/system/endpointManager/reliableEndpointWriter-akka.tcp%3A%2F%2FAElfSystem%40<IP_ADDRESS>%3A44209-5#1579801971]] Association with remote system akka.tcp://AElfSystem@<IP_ADDRESS>:44209 has failed; address is now gated for 5000 ms. Reason is: [System.IndexOutOfRangeException: Index was outside the bounds of the array.
at Hyperion.Serializer.GetDeserializerByManifest(Stream stream, DeserializerSession session)
at lambda_method(Closure , Stream , DeserializerSession )
at Hyperion.Serializer.Deserialize[T](Stream stream)
at Akka.Serialization.HyperionSerializer.FromBinary(Byte[] bytes, Type type)
at Akka.Serialization.Serialization.Deserialize(Byte[] bytes, Int32 serializerId, String manifest)
at Akka.Remote.Serialization.MessageContainerSerializer.FromBinary(Byte[] bytes, Type type)
at Akka.Serialization.Serialization.Deserialize(Byte[] bytes, Int32 serializerId, String manifest)
at Akka.Remote.DefaultMessageDispatcher.Dispatch(IInternalActorRef recipient, Address recipientAddress, Payload message, IActorRef senderOption)
at Akka.Remote.EndpointReader.b__11_1(InboundPayload inbound)
at lambda_method(Closure , Object , Action1 , Action1 , Action1 )    at Akka.Actor.ReceiveActor.ExecutePartialMessageHandler(Object message, PartialAction1 partialAction)
at Akka.Actor.UntypedActor.Receive(Object message)
at Akka.Actor.ActorBase.AroundReceive(Receive receive, Object message)
at Akka.Actor.ActorCell.ReceiveMessage(Object message)
at Akka.Actor.ActorCell.Invoke(Envelope envelope)
--- End of stack trace from previous location where exception was thrown ---
at Akka.Actor.ActorCell.HandleFailed(Failed f)
at Akka.Actor.ActorCell.SysMsgInvokeAll(EarliestFirstSystemMessageList messages, Int32 currentState)
--- End of stack trace from previous location where exception was thrown ---
at Akka.Actor.ActorCell.HandleFailed(Failed f)
at Akka.Actor.ActorCell.SysMsgInvokeAll(EarliestFirstSystemMessageList messages, Int32 currentState)]

[ERROR][9/29/18 9:51:47 PM][Thread 0011][[akka://AElfSystem/system/endpointManager/endpointWriter-akka.tcp%3A%2F%2FAElfSystem%40<IP_ADDRESS>%3A32551-158#349162692]] AssociationError [akka.tcp://AElfSystem@<IP_ADDRESS>:32552] <- akka.tcp://AElfSystem@<IP_ADDRESS>:32551: Error [While parsing a protocol message, the input ended unexpectedly in the middle of a field.  This could mean either that the input has been truncated or that an embedded message misreported its own length.] [   at Google.Protobuf.CodedInputStream.RefillBuffer(Boolean mustSucceed)
at Google.Protobuf.CodedInputStream.ReadRawByte()
at Google.Protobuf.CodedInputStream.ReadRawLittleEndian64()
at Google.Protobuf.CodedInputStream.SkipLastField()
at Akka.Cluster.Serialization.Proto.Msg.UniqueAddress.MergeFrom(CodedInputStream input)
at Google.Protobuf.CodedInputStream.ReadMessage(IMessage builder)
at Akka.Cluster.Serialization.Proto.Msg.GossipStatus.MergeFrom(CodedInputStream input)
at Google.Protobuf.MessageExtensions.MergeFrom(IMessage message, Byte[] data, Boolean discardUnknownFields)
at Google.Protobuf.MessageParser1.ParseFrom(Byte[] data)    at Akka.Cluster.Serialization.ClusterMessageSerializer.GossipStatusFrom(Byte[] bytes)    at Akka.Cluster.Serialization.ClusterMessageSerializer.FromBinary(Byte[] bytes, Type type)    at Akka.Serialization.Serialization.Deserialize(Byte[] bytes, Int32 serializerId, String manifest)    at Akka.Remote.Serialization.MessageContainerSerializer.FromBinary(Byte[] bytes, Type type)    at Akka.Serialization.Serialization.Deserialize(Byte[] bytes, Int32 serializerId, String manifest)    at Akka.Remote.DefaultMessageDispatcher.Dispatch(IInternalActorRef recipient, Address recipientAddress, Payload message, IActorRef senderOption)    at Akka.Remote.EndpointReader.<Reading>b__11_1(InboundPayload inbound)    at lambda_method(Closure , Object , Action1 , Action1 , Action1 )
at Akka.Actor.ReceiveActor.ExecutePartialMessageHandler(Object message, PartialAction1 partialAction)    at Akka.Actor.UntypedActor.Receive(Object message)    at Akka.Actor.ActorBase.AroundReceive(Receive receive, Object message)    at Akka.Actor.ActorCell.ReceiveMessage(Object message)    at Akka.Actor.ActorCell.Invoke(Envelope envelope)] Cause: Unknown [ERROR][9/29/18 9:51:47 PM][Thread 0011][remoting] While parsing a protocol message, the input ended unexpectedly in the middle of a field.  This could mean either that the input has been truncated or that an embedded message misreported its own length. Cause: Google.Protobuf.InvalidProtocolBufferException: While parsing a protocol message, the input ended unexpectedly in the middle of a field.  This could mean either that the input has been truncated or that an embedded message misreported its own length.    at Google.Protobuf.CodedInputStream.RefillBuffer(Boolean mustSucceed)    at Google.Protobuf.CodedInputStream.ReadRawByte()    at Google.Protobuf.CodedInputStream.ReadRawLittleEndian64()    at Google.Protobuf.CodedInputStream.SkipLastField()    at Akka.Cluster.Serialization.Proto.Msg.UniqueAddress.MergeFrom(CodedInputStream input)    at Google.Protobuf.CodedInputStream.ReadMessage(IMessage builder)    at Akka.Cluster.Serialization.Proto.Msg.GossipStatus.MergeFrom(CodedInputStream input)    at Google.Protobuf.MessageExtensions.MergeFrom(IMessage message, Byte[] data, Boolean discardUnknownFields)    at Google.Protobuf.MessageParser1.ParseFrom(Byte[] data)
at Akka.Cluster.Serialization.ClusterMessageSerializer.GossipStatusFrom(Byte[] bytes)
at Akka.Cluster.Serialization.ClusterMessageSerializer.FromBinary(Byte[] bytes, Type type)
at Akka.Serialization.Serialization.Deserialize(Byte[] bytes, Int32 serializerId, String manifest)
at Akka.Remote.Serialization.MessageContainerSerializer.FromBinary(Byte[] bytes, Type type)
at Akka.Serialization.Serialization.Deserialize(Byte[] bytes, Int32 serializerId, String manifest)
at Akka.Remote.DefaultMessageDispatcher.Dispatch(IInternalActorRef recipient, Address recipientAddress, Payload message, IActorRef senderOption)
at Akka.Remote.EndpointReader.b__11_1(InboundPayload inbound)
at lambda_method(Closure , Object , Action1 , Action1 , Action1 )    at Akka.Actor.ReceiveActor.ExecutePartialMessageHandler(Object message, PartialAction1 partialAction)
at Akka.Actor.UntypedActor.Receive(Object message)
at Akka.Actor.ActorBase.AroundReceive(Receive receive, Object message)
at Akka.Actor.ActorCell.ReceiveMessage(Object message)
at Akka.Actor.ActorCell.Invoke(Envelope envelope)
--- End of stack trace from previous location where exception was thrown ---
at Akka.Actor.ActorCell.HandleFailed(Failed f)
at Akka.Actor.ActorCell.SysMsgInvokeAll(EarliestFirstSystemMessageList messages, Int32 currentState)

out of date, close.


Add precise Lat/Lon selection to Request Add/Edit

This PR takes care of the Request Add/Edit screen for #1501.  If everything looks OK I can continue with the Itinerary screen either as part of this PR or in a separate one.

@stevejgordon can you take a look at this

@dchristensen Sure - I'll try to take a look later today

@dchristensen - Thanks for working on this. I've pulled it an had a look through. I'm a little unsure of the logic around the edit request. At the moment, if the request has Lat/Long and then the address is changed, the lat/long are not updated (no geocoding happens).
This makes sense in some scenarios but I can foresee occasional requirements to completely change an address. In the case of changing (rather than tweaking) an address we might want to geocoding to occur.
This is a little tricky to determine so we might need to consider something in the UI to determine if lat/long should be updated or not. We need to figure that out I think.
I also noticed that you had some js for the mapping. Some of that looks to repeat code we have in site.js. It would be nice to try and reuse/update site.js code so that any mapping code is centralised. Could you take a look at if that could work here? Obviously we need to be vary of breaking the pages using site.js currently!

@stevejgordon Thanks for looking at this.  I agree this is tricky trying to figure out how to handle these changes.
Currently, when any of the address fields change I do a geocode lookup on client side:
      $("#Address, #City, #State, #Zip").on("change", function () {
            var address = getAddress();
            if (!isAddressEmpty(address)) {
                lookupAddress(address);
            }
        });

   function lookupAddress(address) {
        getGeoCoordinates(address.address1, address.address2, address.city, address.state, address
            .postalCode, address.country, function(l) {
                var location = setLocation(l.latitude, l.longitude);
                if (location !== null) {
                    setMapCenterAndZoom(map, [location], 15);
                }
            });
    }

This should update the Latitude & Longitude fields any time the address is changed, but there are no guarantees that request succeeds.  I could add code to the change handler function to set the Latitude & Longitude fields to zero before issuing the request to lookup the address, that way if the geocode fails the request will be geocoded by the back end.
As far as the mapping code, was there any specific code you saw? I have been trying to use what's in site.js when it makes sense (creating the map, center and zoom, geocoding).  Most of the mapping code is to handle manipulating the pushpin.  I could possible try to make it so it could be shared in site.js, but I don't think there is anything in there currently that would provide the control need to handle the movements.

@stevejgordon any more thoughts on this PR?

@dchristensen @tonysurma - I'm not great with JS so will defer to anyone who is a bit more experienced with it. I'd suggest, if we can, we put anything around the ping that might be reusable into the site.js file.
When I tested locally the address change didn't seem to result in the lat/long updating, but I might have been unlucky. I can try and pull later and check again.

@dpaquette can you take a review?

Sure, I will review either tonight or tomorrow


panic with inference_session split_at

When presenting / feeding certain tokens I'm getting:
thread 'main' panicked at 'assertion failed: mid <= self.len()',
  /home/spion/.cargo/git/checkouts/llm-d8a8bbe144aa0546/e52a102/crates/llm-base/src/inference_session.rs:101:51

Steps to reproduce:
Feed the following string using feed_prompt
да гледам ќе идев

to any model that has llama like tokens.
Commit: latest master (e52a102)

Ah yea - I forgot to meniton it. I'm using the HuggingFace tokenizer.

Okay, took a bit of time, but I managed to find the root cause. The end of the UTF-8 decoding of the tokens with the Hugging Face tokenizer can actually change as more tokens are added (including being a shorter string!), leading to panics when what's already been decoded doesn't match what the new decoding has provided.
I've requested help here: https://github.com/huggingface/tokenizers/issues/1141#issuecomment-1612186716 - hoping that we can get to the bottom of this soon!


Enforce sqlite connection string must contain binary guid = false.

Fix #506

You get a YSOD because the error handler has problems with non http exceptions.

I think we can merge this?

Yes, go for it.


Infinite loop/hang in LRU cache under some circumstances

Can get browser to hang with stack:
trim [Line: 306, Col: 1], lru-cache.js
LRUCache.prototype.set [Line: 214, Col: 1], lru-cache.js
Anonymous function [Line: 76, Col: 1], compiler-service.js
fire [Line: 3317, Col: 1], jquery.js
self.fireWith [Line: 3447, Col: 1], jquery.js
done [Line: 9272, Col: 1], jquery.js
Anonymous function [Line: 9514, Col: 1], jquery.js
wrapped [Line: 474, Col: 1], raven.js
[Worker#1 workerMain.js#editorWorkerService ()]

By playing around with errors etc, something like:

go to https://godbolt.org/g/YL9ES9
change it to return std::move(s + "rawr;" (with the error) and wait for the result
fix the syntax error and it freezes

(though hard to repro)

Can only reproduce with this specific link https://godbolt.org/g/MrukAn

We've hit anothe rissue in updating this: the library we use is no longer compatible with our archaic build process. We're looking to fix that too. Thanks for your patience

@RabsRincon I have tried to get this to hang. It looks like it is now fixed. Any objections to closing this one out?

None at all :)


Issue: Scanning QR code not working

Hi,
I can’t scan any QR codes, with either of my devices, but it’s working with the NUX Mighty Amp app.
On the Tab A, Mightier Amp simply shuts down with a pop up window to report this error.
On the Galaxy A52s, the camera function opens, but when scanning the QR code, nothing happens.
As far as I can see, permissions for both apps are granted.
Regards
TullyMore
Devices and versions:
Android 13 on Samsung Galaxy A52s 5G
Android 8.1.0 on Samsung Galaxy Tab A (2016)
Mightier Amp v0.9.6 with all permissions granted
Mighty Amp v2.3

Casued by "Do not keep activites" set to on in developer settings.


Add back the ability to build Whisper from Transformers checkpoints

Can be tested with TP=1, PP=1 with the example in examples/automatic-speech-recognition/:
CUDA_VISIBLE_DEVICES=0 python3 whisper.py openai/whisper-tiny.en tiny_whisper

There remains warning logs from TRT-LLM as
[03/22/2024-03:31:19] [TRT-LLM] [W] Parameter dtype is None, using default dtype: DataType.FLOAT, it is recommended to always specify dtype explicitly

since dtype is sometimes not passed in TRT-LLM codebase: https://github.com/NVIDIA/TensorRT-LLM/blob/66ca3378c61efa3154ed34a48cfc362351405eef/tensorrt_llm/models/enc_dec/model.py#L1644-L1645
TRT-LLM handles Whisper with two different Module subclasses: WhisperEncoder and DecoderModel. We save their engines two subfolders encoder/engines and decoder/engines, hence some refactors in hub.py and runtime.py to accomodate multiple-engines models

One test runner OOM at build


Use the latest EBS CSI driver addon

Get the latest versions of AWS EKS addons using:
aws eks describe-addon-versions > eks_addons.json

and check for "aws-ebs-csi-driver".
The current version of this driver is "v1.18.0-eksbuild.1". It supports Kubernetes v1.17+ through the current EKS version.
Repository:
https://github.com/kubernetes-sigs/aws-ebs-csi-driver

Thanks for the PR!


Handler can not have an Spring injected attribute

MyBatis version

3.4.4

First Ibatis set its configuration
At the end, Spring load the app context
That means that a Spring bean can not be injected in the handler because the bean is created after.
Is there any way to make this possible?
Thanks

@marnavleo Please provide more detail information ....

I am trying to inject a spring bean into my ibatis handler (that trasforms values between data base types and java types). The problem is that Spring context is uploaded after the Ibatis context, so that null value is setted in the Ibatis Handler. I am using a patch to get this but i don't like it at all... Is there a cleaner way to solve this?
My Handler
@mappedtypes({ ClavesCargo.class, ClavesZona.class })
public class ConstantTranslationHandler<E extends Enum & HasValue> extends BaseTypeHandler {
//Patch to inyect spring bean
private ClavesSingleton clavesSingleton = null;
private ClavesSingleton getClavesSingleton() {
if(clavesSingleton==null){
this.clavesSingleton=(ClavesSingleton)
ParcheIbatisSpring.getBean(ClavesSingleton.class);
}
return clavesSingleton;
}
private Class type;
private final E[] enums;
//Constructor
public ConstantTranslationHandler(Class type) {
if (type == null)
throw new IllegalArgumentException("Type argument cannot be null");
this.type = type;
this.enums = type.getEnumConstants();
if (this.enums == null)
throw new IllegalArgumentException(type.getSimpleName()
+ " does not represent an enum type.");
}
@Override
public void setNonNullParameter(PreparedStatement ps, int i, E parameter, JdbcType jdbcType) throws SQLException {
ps.setString(i, parameter.value());
}
@SuppressWarnings("unchecked")
@Override
public E getNullableResult(ResultSet rs, String columna) throws SQLException {
String dato = rs.getString(columna);
ClavesC clave = getClavesSingleton().getClaveBy(KeyEnumDictionary.getClave(type), dato);
E output = null;
if(clave!=null){
output =(E) EnumFactory.getInstanceOf(type, clave.getClaveC());
}
return output;
}
@Override
public E getNullableResult(ResultSet rs, int columnIndex) throws SQLException {
return null;
}
@Override
public E getNullableResult(CallableStatement cs, int columnIndex) throws SQLException {
return null;
}

I seem this same with mybatis/spring#218.

Thank you @kazuki43zoo
I will try with this!


How to use uninitialized BytesMut?

Hi!
When using a plain Vec<_> I can create it with Vec::with_capacity, initialize the memory externally and then use Vec::set_len as shown by this example.
Is the same pattern valid for BytesMut? It seems so, but I could not find any guarantee in the documentation.
Thanks.

Yes, this is possible. If you use the advance_mut and chunk_mut methods from the BufMut trait, then you get the desired behavior.

Is using as_mut_ptr followed by set_len from BytesMut also valid?

Is using as_mut_ptr followed by set_len from BytesMut also valid?

Yes.


Invalid target on build

Instructions on https://github.com/lyft/envoy/tree/master/bazel suggests the following for the fastbuild target.
./ci/run_envoy_docker.sh ./ci/do_ci.sh bazel.fastbuild

$ ./ci/run_envoy_docker.sh "./ci/do_ci.sh bazel.fastbuild"
M	WORKSPACE
M	bazel/get_workspace_status
M	tools/bazel.rc
HEAD is now at 8442ed7... Improve CI testing. (#13)
building using 1 CPUs
Invalid do_ci.sh target, see ci/README.md for valid targets.

The command fails with Invalid do_ci.sh target.

Sorry docs are out of date. See here: https://github.com/lyft/envoy/tree/master/ci#building-and-running-tests-as-a-developer
Feel free to do PR to fix the docs or we can get to it in a bit.


Feature home page

Implement a homepage that gathers all the posts of followed users.

Can not run server got this message error.

It redirect to Tricks-Hub when use filter.

The feature Home page is work correctly. You can merge into 'main'
(Don't forget to resolve conflicts)


[CSGen] Clarify locators for some of the patterns

optional object type of .some pattern ends with OptionalPayload
type of sub-pattern used in a cast points to underlying sub-pattern declaration
Enum element:

parent type locator ends with ParentType
member lookup constraint locator ends at Member

@swift-ci please smoke test

@DougGregor Does it make sense to you?

@swift-ci please smoke test Windows platform

@swift-ci please smoke test Windows platform

@swift-ci please smoke test Windows platform

@swift-ci please smoke test Windows platform


Explorer does full recursive refresh when a file system is registered

have an extension that contributes a file system provider
profile startup
🐌 when the fs provider is registered the explorer does a full recursive (expensive) refresh even though it doesn't show anything of that provider

e.g. the file system provider is gitlens

Good catch. We refresh the explorer in this case since the file system provider might unregister and register itself to make itself readonly. This requires that all the file stats are refreshed.
To optimaze that I changed that I only refresh the explorer if the file system provider got re-registered. I know that by rembering the schemes of the register providers thus far.

👏

Due to https://github.com/Microsoft/vscode/issues/71423 I will push a revert for this.
I still want to do this fix, howevere due to timing I decided to do them in debt week when we can get more details why this optimisation broke live share.
Reopening and moving to april

Reverted the revert since it is not the cause of the Live Share issue. Thus closing this.
More details here https://github.com/Microsoft/vscode/issues/71423


fix(firebase): csp connect-src and prefetch-src udpate

:tada: This PR is included in version 1.0.0-alpha.175 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


set rx/tx timeout after connect, to avoid it being reset

It appears that setting a timeout before connecting just gets reset. So setting the timeout after connecting fixes the problem.
This fix depends on https://github.com/azonenberg/xptools/pull/12

Please fix to comply with the coding style. Curly braces aren't used on single-line if statements.


Feature/handler extractor

Codecov Report

Merging #8 into master will increase coverage by 0.66%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master       #8      +/-   ##
==========================================
+ Coverage   97.57%   98.23%   +0.66%
==========================================
  Files          26       29       +3
  Lines         370      452      +82
==========================================
+ Hits          361      444      +83
+ Misses          9        8       -1

Impacted Files
Coverage Δ

app/utilities/imgop.h
100% <ø> (ø)
:arrow_up:

app/handlers/filter.cpp
100% <ø> (ø)
:arrow_up:

app/controllers/chain.cpp
100% <ø> (ø)
:arrow_up:

app/handlers/extractor.h
100% <100%> (ø)

app/common/palm.h
100% <100%> (ø)
:arrow_up:

app/utilities/imgop.cpp
100% <100%> (ø)
:arrow_up:

app/handlers/extractor.cpp
100% <100%> (ø)

tests/test_handlers/test_extractor.cpp
100% <100%> (ø)

app/handlers/detector.cpp
91.8% <100%> (ø)
:arrow_up:

tests/test_controllers/test_chain.cpp
100% <100%> (ø)
:arrow_up:

... and 4 more

Handler
EffectiveIncircleExtractor


Do not trigger chromatic with changeset pr

Self Checklist

[x] I wrote a PR title in English and added an appropriate label to the PR.
[x] I wrote the commit message in English and to follow the Conventional Commits specification.
[x] I added the changeset about the changes that needed to be released. (or didn't have to)
[x] I wrote or updated documentation related to the changes. (or didn't have to)
[x] I wrote or updated tests related to the changes. (or didn't have to)
[x] I tested the changes in various browsers. (or didn't have to)

Windows: Chrome, Edge, (Optional) Firefox
macOS: Chrome, Edge, Safari, (Optional) Firefox

Related Issue

Summary

changeset PR에서 CI가 잘 작동하도록 PAT를 활용했는데, 사이드 이펙트로 불필요하게 크로마틱이 돌기 시작해서 이를 수정합니다. Codecov나 Codeql 등은 사용량 제한이 없기 때문에 그대로 두어도 괜찮을 것 같습니다.

Details

actor 에 github-actions[bot] 필터를 추가합니다.

Breaking change? (Yes/No)

No

References

https://github.com/channel-io/bezier-react/pull/2188

여전히 changeset pr 에서 돌고 있어서 수정이 필요할듯


Supporting reverse proxy scenarios

I'm really struggling to make swagger work when using it behind nginx. In my scenario nginx will listen on:
http://localhost:80/ => http://localhost:8080
http://localhost:80/bar => http://localhost:81

Such that a request going to http://localhost:80/bar/swagger/ will go to http:/localhost:81/swagger/
Now I have swagger enabled on http://localhost:81 but return addresses do not respect the original address. Which makes my browser redirect to http://localhost:8080. I need a way to specify that all the links should be prefixed with bar so that the browser is interacting with the correct server.

A bit of additional information. X-Forwarded-* are present and look something like:
X-Forwarded-For: <IP_ADDRESS>
X-Forwarded-Proto: http
X-Forwarded-Host: localhost:80/bar/swagger/

Using the UseForwardedHeaders middleware the Request.Host property is correctly updated to reflect this. But it doesn't look like the swagger middleware is respecting that.

After investigating the source code and the UseForwardedHeaders middleware I have come to the conclusion that the problem is not as simple as one might think.
For starters, localhost:80/bar/ is not a valid value for X-Forwarded-Host, although there is not a specification for that header it is expected that it will only contain the host portion of the server that forwarded the request. You can find for more information about it here.
Taking that into consideration a possible workaround to generate the correct Swagger JSON is to send another header named X-Forwarded-Path with the path it is proxying, and setting the Request's PathBase to the that value in a middleware:
app.Use((context, next) =>
{
    if (context.Request.Headers.TryGetValue("X-Forwarded-Path", out StringValues values)
        && values.Count > 0)
    {
        context.Request.PathBase = values[0];
    }
    return next();
});

To setup NGINX to send the custom header all you have to do is add the following line to your location configuration:
proxy_set_header X-Forwarded-Path /<your nginx location>/;
If you are not using Swagger UI this should be enough for you as you will be serving the Swagger JSON with the correct endpoints.
If you are using the Swagger UI you will need to set an additional Swagger endpoint when adding the SwaggerUi middleware, unfortunately this is not ideal since it is set at compile time, this is due to Swashbuckle using a static file middleware to serve the SwaggerUi html file.
To set the additional Swagger endpoint you use the method SwaggerEndpoint of the SwaggerUiOptions instance passed to the UseSwaggerUi action. E.g.:
app.UseSwaggerUi(c =>
{
    c.SwaggerEndpoint("/swagger/v1/swagger.json", "NAME");
    c.SwaggerEndpoint("/name/swagger/v1/swagger.json", "NAME Reverse proxy");
});

This will leave you with two options in the select box of the Swagger Ui upper right corner.

No workaround ?

The best way to deal with reverse proxies is to use relative URLs in your configuration.
app.UseSwaggerUi(c =>
{
    c.SwaggerEndpoint("v1/swagger.json", "NAME");
}

NOTE the lack of a leading slash. This means that the requested path will be relative to the swagger-ui page itself. So, if you're serving the swagger-ui at example.com:80/bar/swagger, then it will request the Swagger JSON at example.com:80/bar/swagger/v1/swagger.json

Hi @domaindrivendev, thanks for reply, relative end point is the trick.

I am using a relative path but when I load Swagger UI, it tries to load the JSON, it seems to add an additional /swagger to the beginning of the JSON url. So I end up with a path like
https://api-staging.mydomain.com/users/swagger/swagger/v1/swagger.json

if I navigate to
https://api-staging.mydomain.com/users/swagger

Admittedly I came across my fix by trial and error, but in the Configure method of Startup.cs I had to add use the following:
    app.UseSwagger(c => {
        //change the path to include /api
        c.RouteTemplate = "/api/swagger/{documentName}/swagger.json";
    });

    app.UseSwaggerUI(c =>
    {
        //Notice the lack of / making it relative
        c.SwaggerEndpoint("swagger/v1/swagger.json", "My API V1");
        //This is the reverse proxy address
        c.RoutePrefix = "api";
    });

Obviously my reverse proxy forwards /api to this service. I had to adjust the RouteTemplate for the json file as well as add the RouteTemplate for the UI. If there is a better solution I'd love to see it. I have a bare minimum example at https://github.com/lukerogers/swashbuckle-nginx

The best way to deal with reverse proxies is to use relative URLs in your configuration.
app.UseSwaggerUi(c =>
{
    c.SwaggerEndpoint("v1/swagger.json", "NAME");
}

NOTE the lack of a leading slash. This means that the requested path will be relative to the swagger-ui page itself. So, if you're serving the swagger-ui at example.com:80/bar/swagger, then it will request the Swagger JSON at example.com:80/bar/swagger/v1/swagger.json

Hi, I use nginx for proxy like this
{nginxurl}/api1 => {webapiurl}
After using relative url ,the swagger doc can be seen.
But when I call the api, the url routing is still not right.
The url it use :  http://<IP_ADDRESS>:5011/WeatherForecast
What I need to call is : http://<IP_ADDRESS>:5011/api1/WeatherForecast

How can I fix this?
            app.UseSwagger();
            app.UseSwaggerUI(c =>
            {
                c.SwaggerEndpoint("v1/swagger.json", "My API V1");
            });


fix: Minor html 5 tag rules, consistent with blank.html

Just what the title says.
Not that important, but for consistency with blank.html.
Could it be I have OCD?

Fixed the merge conflict from commit 130c652346cc7f1f822a5b907e826a16b88c57ee


Sign Up: Add children protection

Ask for the year of birth - before y-18 (so for example before 2014 means user is 18+ old) or after y-18, that means an user should not use the app.
With this trick children has to think more about this select (defaults to children, so adults must switch); and the thing is, what to do:

add site something like "playground" or "sandbox" or something, where will be some kind of message the app is not currently available (fake error)
the problem is if an adult is not observant enough to check the right age

The benefit: The app will not save the year or an age of an user, so GDPR yahoo. Just sets the "right" app from the start.

Obsolete as there is now next-auth.


How can I use smartcard for client certificate ?

Hello,
I am trying to access a URL which requires client authentication.
But, the certificate/private key are stored on a smart card.
I have no idea how to proceed !?

This issue is not relevant to the current project.


Fix possible buffer overrun in options find_match

If a match_type is not MATCH_LONG then the match_name
pointer points to p->short_opt which is a single char.
This is passed to strlen a few lines later. This will be
a buffer overrun if short_opt is not the null char.
The fix I'm doing here is to use strnlen and pass the
match_length, which is set to 1 for the case of
a short option.
Bug found using coverity.

Thanks for the fix

I've had to undo this change as it broke handling of options which are a substring of other options, eg --antlr which is a substring of --antlrraw.
Slightly embarrassingly the comment immediately following the "fix" line points this out, which I didn't notice. Also the unit tests for the option parser should have picked this up, but it turns out we haven't got any unit tests for this (I thought we did).
The buffer overrun spotted can never actually go far enough to cause a crash (since the field following the single character is a flags field that always has at least 3 bytes as 0), but it is definitely a bug and needs fixing.


Fix dayofweek and dayofyear attributes from dates generated by cftime_range

[x] Tests added

It turns out there was a remaining bug in cftime (https://github.com/Unidata/cftime/issues/106) that impacted the results of the dayofwk and dayofyr attributes of cftime objects generated by their replace method, which we use when parsing dates from strings, and in some offset arithmetic.
A workaround is to add a dayofwk=-1 argument to each replace call where the dayofwk or dayofyr would be expected to change.  I've fixed this bug upstream in cftime (https://github.com/Unidata/cftime/pull/108), but it will only be available in a future version.  Would it be appropriate to use this workaround in xarray?
This would fix this doc page for instance:

Hello @spencerkclark! Thanks for updating the PR.

In the file xarray/coding/cftimeindex.py, following are the PEP8 issues :

Line 164:1: W293 blank line contains whitespace

agreed, thanks!


Uncaught TypeError: Cannot read property 'alias' of undefined

[Enter steps to reproduce below:]

update to latest version
try to add new host sftp

Atom Version: 1.5.3
System: Mac OS X 10.11.3
Thrown From: remote-edit package, v1.8.24
Stack Trace
Uncaught TypeError: Cannot read property 'alias' of undefined
At /Users/<USERNAME>/.atom/packages/remote-edit/lib/model/host.coffee:34

TypeError: Cannot read property 'alias' of undefined
    at SftpHost.module.exports.Host.getSearchKey (/Users/<USERNAME>/.atom/packages/remote-edit/lib/model/host.coffee:34:63)
    at /Users/<USERNAME>/.atom/packages/remote-edit/lib/model/host.coffee:18:9
    at Config.module.exports.Config.observeKeyPath (/Applications/Atom.app/Contents/Resources/app.asar/src/config.js:612:7)
    at Config.module.exports.Config.observe (/Applications/Atom.app/Contents/Resources/app.asar/src/config.js:141:21)
    at SftpHost.Host (/Users/<USERNAME>/.atom/packages/remote-edit/lib/model/host.coffee:17:19)
    at new SftpHost (/Users/<USERNAME>/.atom/packages/remote-edit/lib/model/sftp-host.coffee:32:7)
    at Object.module.exports.newHostSftp (/Users/<USERNAME>/.atom/packages/remote-edit/lib/main.coffee:93:70)
    at atom-workspace.<anonymous> (/Users/<USERNAME>/.atom/packages/remote-edit/lib/main.coffee:83:17)
    at CommandRegistry.module.exports.CommandRegistry.handleCommandEvent (/Applications/Atom.app/Contents/Resources/app.asar/src/command-registry.js:260:29)
    at CommandRegistry.handleCommandEvent (/Applications/Atom.app/Contents/Resources/app.asar/src/command-registry.js:3:61)
    at CommandRegistry.module.exports.CommandRegistry.dispatch (/Applications/Atom.app/Contents/Resources/app.asar/src/command-registry.js:160:19)
    at AtomEnvironment.module.exports.AtomEnvironment.dispatchApplicationMenuCommand (/Applications/Atom.app/Contents/Resources/app.asar/src/atom-environment.js:1013:28)
    at emitOne (events.js:77:13)
    at EventEmitter.emit (events.js:169:7)

Commands
     -0:11.5.0 remote-edit:browse (atom-workspace.workspace.scrollbars-visible-when-scrolling.theme-atom-material-syntax.theme-atom-material-ui)
  3x -0:08.1.0 core:backspace (atom-text-editor.editor.mini.is-focused)
     -0:00.7.0 remote-edit:new-host-sftp (atom-text-editor.editor.mini.is-focused)

Config
{
  "core": {
    "themes": [
      "atom-material-ui",
      "atom-material-syntax"
    ]
  }
}

Installed Packages
# User
angularjs, v0.3.3
atom-material-syntax, v0.2.4
atom-material-ui, v0.6.1
autocomplete-angular-material, v0.4.0
autocomplete-ionic-framework, v0.2.1
color-picker, v2.0.13
css-color-underline, v1.0.1
file-icons, v1.6.13
remote-edit, v1.8.24

# Dev
No dev packages

I'm seeing the same or similar error, but getting to it a different way.
Steps to reproduce:

Open a remote file via remote-edit.
Close Atom.
Open Atom. (Throws error)
Close Atom.
Open Atom. (Works fine)

Atom version: 1.5.4
System: Windows 8.1
remote-edit version: 1.8.24
Stack Trace
TypeError: Cannot read property 'alias' of undefined
at SftpHost.module.exports.Host.getSearchKey (file:///C:/Users/Josh/.atom/packages/remote-edit/lib/model/host.coffee:34:63)
at file:///C:/Users/Josh/.atom/packages/remote-edit/lib/model/host.coffee:18:9
at Config.module.exports.Config.observeKeyPath (C:\Users\Josh\AppData\Local\atom\app-1.5.4\resources\app.asar\src\config.js:612:7)
at Config.module.exports.Config.observe (C:\Users\Josh\AppData\Local\atom\app-1.5.4\resources\app.asar\src\config.js:141:21)
at SftpHost.Host (file:///C:/Users/Josh/.atom/packages/remote-edit/lib/model/host.coffee:17:19)
at new SftpHost (file:///C:/Users/Josh/.atom/packages/remote-edit/lib/model/sftp-host.coffee:32:7)
at Function.module.exports.Serializable.deserialize (C:\Users\Josh\AppData\Local\atom\app-1.5.4\resources\app.asar\node_modules\text-buffer\node_modules\serializable\lib\serializable.js:70:27)
at Function.module.exports.RemoteEditEditor.deserialize (file:///C:/Users/Josh/.atom/packages/remote-edit/lib/model/remote-edit-editor.coffee:156:27)
at DeserializerManager.module.exports.DeserializerManager.deserialize (C:\Users\Josh\AppData\Local\atom\app-1.5.4\resources\app.asar\src\deserializer-manager.js:45:29)
at C:\Users\Josh\AppData\Local\atom\app-1.5.4\resources\app.asar\src\pane.js:34:30
at Array.map (native)
at Function.module.exports.Pane.deserialize (C:\Users\Josh\AppData\Local\atom\app-1.5.4\resources\app.asar\src\pane.js:33:35)
at DeserializerManager.module.exports.DeserializerManager.deserialize (C:\Users\Josh\AppData\Local\atom\app-1.5.4\resources\app.asar\src\deserializer-manager.js:45:29)
at PaneContainer.module.exports.PaneContainer.deserialize (C:\Users\Josh\AppData\Local\atom\app-1.5.4\resources\app.asar\src\pane-container.js:64:40)
at Workspace.module.exports.Workspace.deserialize (C:\Users\Josh\AppData\Local\atom\app-1.5.4\resources\app.asar\src\workspace.js:155:33)
at AtomEnvironment.module.exports.AtomEnvironment.loadStateSync (C:\Users\Josh\AppData\Local\atom\app-1.5.4\resources\app.asar\src\atom-environment.js:940:24)
at AtomEnvironment.module.exports.AtomEnvironment.startEditorWindow (C:\Users\Josh\AppData\Local\atom\app-1.5.4\resources\app.asar\src\atom-environment.js:685:12)
at module.exports (C:\Users\Josh\AppData\Local\atom\app-1.5.4\resources\app.asar\src\initialize-application-window.js:28:10)
at setupWindow (file:///C:/Users/Josh/AppData/Local/atom/app-1.5.4/resources/app.asar/static/index.js:86:5)
at window.onload (file:///C:/Users/Josh/AppData/Local/atom/app-1.5.4/resources/app.asar/static/index.js:41:9)handleSetupError @ index.js:62

I'm confirming bug, same (buggy) behavior, different environment:
Steps to reproduce:

Open a remote file via remote-edit.
Close Atom.
Open Atom. (Throws error)
Close Atom.
Open Atom. (Works fine)

Atom version: 1.5.4
System: Linux
remote-edit version: 1.8.24
Stack trace omitted as not needed (same as above, just replace file:///C:/Users/Josh/ with /home/user).

Just updated to new version of Atom:
Atom version: 1.6.0
Error still present. Just to let you know, recent Atom changes broke also some other packages, which give almost the same error (TypeError: Cannot read property 'something' of undefined).
Backwards compatibility is hard to achieve.

Same here

Same
[Enter steps to reproduce below:]

Open Atom
Try to add new host

Atom Version: 1.6.0
System: Unknown Windows Version
Thrown From: remote-edit package, v1.8.24
Stack Trace
Uncaught TypeError: Cannot read property 'alias' of undefined
At /C:/Users/User/.atom/packages/remote-edit/lib/model/host.coffee:62

TypeError: Cannot read property 'alias' of undefined
    at SftpHost.module.exports.Host.getSearchKey (file:///C:/Users/User/.atom/packages/remote-edit/lib/model/host.coffee:34:63)
    at file:///C:/Users/User/.atom/packages/remote-edit/lib/model/host.coffee:18:9
    at Config.module.exports.Config.observeKeyPath (C:\Users\User\AppData\Local\atom\app-1.6.0\resources\app.asar\src\config.js:612:7)
    at Config.module.exports.Config.observe (C:\Users\User\AppData\Local\atom\app-1.6.0\resources\app.asar\src\config.js:141:21)
    at SftpHost.Host (file:///C:/Users/User/.atom/packages/remote-edit/lib/model/host.coffee:17:19)
    at new SftpHost (file:///C:/Users/User/.atom/packages/remote-edit/lib/model/sftp-host.coffee:32:7)
    at Object.module.exports.newHostSftp (file:///C:/Users/User/.atom/packages/remote-edit/lib/main.coffee:93:70)
    at atom-workspace.<anonymous> (file:///C:/Users/User/.atom/packages/remote-edit/lib/main.coffee:83:17)
    at CommandRegistry.module.exports.CommandRegistry.handleCommandEvent (C:\Users\User\AppData\Local\atom\app-1.6.0\resources\app.asar\src\command-registry.js:260:29)
    at CommandRegistry.handleCommandEvent (C:\Users\User\AppData\Local\atom\app-1.6.0\resources\app.asar\src\command-registry.js:3:61)
    at CommandRegistry.module.exports.CommandRegistry.dispatch (C:\Users\User\AppData\Local\atom\app-1.6.0\resources\app.asar\src\command-registry.js:160:19)
    at AtomEnvironment.module.exports.AtomEnvironment.dispatchApplicationMenuCommand (C:\Users\User\AppData\Local\atom\app-1.6.0\resources\app.asar\src\atom-environment.js:1013:28)
    at emitOne (events.js:77:13)
    at EventEmitter.emit (events.js:169:7)

Commands
     -6:57.2.0 remote-edit:new-host-sftp (atom-text-editor.editor.is-focused)
     -6:48.2.0 about:view-release-notes (atom-workspace.workspace.scrollbars-visible-always.theme-one-dark-syntax.theme-one-dark-ui)
     -6:37.1.0 release-notes:show (atom-text-editor.editor.is-focused)
     -4:09.7.0 remote-edit:browse (div.panels-item)
     -4:03.2.0 remote-edit:new-host-sftp (atom-text-editor.editor.mini.is-focused)
     -3:19.9.0 remote-edit:show-open-files (atom-workspace.workspace.scrollbars-visible-always.theme-one-dark-syntax.theme-one-dark-ui)
     -3:18.1.0 core:confirm (atom-text-editor.editor.mini.is-focused)
     -2:25 remote-edit:show-open-files (input#remote-edit.showHiddenFiles.)
     -2:20 core:backspace (atom-text-editor.editor.mini.is-focused)
     -2:10.8.0 core:confirm (atom-text-editor.editor.mini.is-focused)
     -1:56.8.0 remote-edit:new-host-sftp (atom-workspace.workspace.scrollbars-visible-always.theme-one-dark-syntax.theme-one-dark-ui)

Config
{
  "core": {
    "disabledPackages": [
      "preview-plus",
      "angularjs"
    ]
  },
  "remote-edit": {
    "showHiddenFiles": true
  }
}

Installed Packages
# User
angularjs, v0.3.4
atom-html-preview, v0.1.19
atom-jade, v0.3.0
autocomplete-sass, v0.1.0
coffee-compile, v0.21.1
color-picker, v2.1.1
emmet, v2.4.3
language-matlab, v0.2.1
open-recent, v5.0.0
release-notes, v0.53.0
remote-edit, v1.8.24
sass-autocompile, v0.12.6
save-session, v0.16.0
sync-settings, v0.7.2

# Dev
No dev packages

In Atom 1.7.2 if you leave open remote file on closing Atom, on next open you'll see only main menu of Atom window and everything inside it is black.

Your only solution is to close Atom and reopen it, Alt+Ctrl+R is doing nothing, you can do "Open in dev mode" (View->Developer->Open in dev mode), from where you can see that problem is still the same:
"Cannot read property 'alias' of undefined".
Workaround exist, close all remote windows before closing Atom, but that can be quite inconvenient when working on lot of remote files.
This bug SHOULD be addressed, as it persists from Atom 1.5.3 onward to at this moment  Atom 1.7.2, and now behavior is even worse than before.

My CoffeeScript debugging skills suck, but I got following:

Cannot read property 'alias' of undefined is referencing following line (in file host.coffee):
toReturn = "#{toReturn} #{@alias}" if searchKeySettings["alias"]
which means that searchKeySettings object (probably hashtable) is undefined.

This object is initialized with this line:
atom.config.observe "remote-edit.filterHostsUsing", (settings) =>
@searchKey = @getSearchKey(settings) ? @searchKey

In JS notation:
atom.config.observe("remote-edit.filterHostsUsing", (function(_this) {
return function(settings) {
var ref;
return _this.searchKey = (ref = _this.getSearchKey(settings)) != null ? ref : _this.searchKey;
};

Either atom.config.observe is broken or called to early or something similar.

Workaround: I changed in file .atom/packages/remote-edit/lib/model/host.coffee in line 17 method
atom.config.observe for atom.config.get  and now atom is opening fine, after you closed it with open remote files.
As observe method is meant to load new settings when they occur, this change means that for any changes in existing remote-edit settings you probably need to reload atom window (or close-open atom), but I can live with it. :)


Fix -inspector- remote debug view not changing to current scene a…

…fter exiting game - Fixes #20075

Thanks!


fix: stop relying on vm2 (via proxy agent)

Originally, we hoped to support all proxy kinds by integrating the proxy-agent module. It turns out that pac file proxy implementation relies on the vm2 module that recently became deprecated due to security problems. The recommended replacement requires a compiler installed which would lead to extra friction for many users. It looks like the best would be to drop the pac proxy support (which we never announced publicly) and stop relying on the proxy-agent module that has vm2 as a dependency.
Closes #10547
P.S. before landing let's wait if there will be alternative solutions following the vm2 deprecation.

proxy-agent was specifically added to fix this bug:
https://github.com/puppeteer/puppeteer/issues/10124
This change has re-introduced it.

Well, what else can we do?  As I understand it, vm2 was introduced so that proxy config could be picked up from the system pac file.  Can we have some other way to provide that information?  I'd be satisfied if I could pass a flag into the install script to have it pull the proxy information the HTTP_PROXY/HTTPS_PROXY environment variables, and that feels straight forward.
(I apologize for not being able to provide a PR, but I REALLY HATE JavaScript)

@mscott3 you can still use other proxy types. For PAC file proxies, there is no solution currently.

Oh!  So, my users problem is that when they:
npm install -g puppeteer ...

they see this
npm ERR! code 1
npm ERR! path /opt/app-root/src/.npm-global/lib/node_modules/puppeteer
npm ERR! command failed
npm ERR! **command sh -c -- node install.js**
npm ERR! ERROR: Failed to set up Chrome r114.0.5735.133! Set "PUPPETEER_SKIP_DOWNLOAD" env variable to skip download.
npm ERR! Error: Download failed: server returned code 503. URL: https://edgedl.me.gvt1.com/edgedl/chrome/chrome-for-testing/114.0.5735.133/linux64/chrome-linux64.zip
npm ERR!     at /opt/app-root/src/.npm-global/lib/node_modules/puppeteer/node_modules/@puppeteer/browsers/lib/cjs/httpUtil.js:117:31
npm ERR!     at ClientRequest.requestCallback (/opt/app-root/src/.npm-global/lib/node_modules/puppeteer/node_modules/@puppeteer/browsers/lib/cjs/httpUtil.js:94:13)
npm ERR!     at Object.onceWrapper (node:events:628:26)
npm ERR!     at ClientRequest.emit (node:events:513:28)
npm ERR!     at HTTPParser.parserOnIncomingClient (node:_http_client:693:27)
npm ERR!     at HTTPParser.parserOnHeadersComplete (node:_http_common:128:17)
npm ERR!     at Socket.socketOnData (node:_http_client:534:22)
npm ERR!     at Socket.emit (node:events:513:28)
npm ERR!     at addChunk (node:internal/streams/readable:315:12)
npm ERR!     at readableAddChunk (node:internal/streams/readable:289:9)

whcih I think is consistent with the original bug report.  I interpret this to mean that install.js is not respecting the HTTP_PROXY and HTTPS_PROXY environment variables.  Is there something I can pass on install to indicate what proxy to use?

thank you for looking at this.  For open source dev tool stacks, we use a proxy that performs integrated auth with Kerberous, which is implemented in many open source HTTP stacks.  All of the downloads of components via npm work just fine.
When we get to downloading the browser bits, we start to get these 'ERR_SOCKET_CLOSED' notices.  This does not explicitly say "we could not auth you to the proxy" (that  would be a 407), but it would be consistent with the HTTP library getting a 407, swallowing it, and reporting that the socket closed.
I put px-proxy (https://pypi.org/project/px-proxy/) between me and our corporate proxy, and my problem went away.
I'll be pursing that as a solution.
Again, thanks for looking into this.


Direct link to github

Please add a link to github in weppy.org

Thanks, I think weppy.org has several links to github.
I invite you to use the weppy users group for these suggestions instead of opening up an issue.


Update VMI status with latest Pod network IP

What this PR does / why we need it:
This adds a way to update VMI Status with latest Pod network IP for Masquerade bindings
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #
https://bugzilla.redhat.com/show_bug.cgi?id=1686208
Special notes for your reviewer:
Discussion for the same: https://groups.google.com/forum/#!topic/kubevirt-dev/rUPRsG4CqqU
Release note:

Add a way to update VMI Status with latest Pod IP for Masquerade bindings

@davidvossel this should be good to review

/retest

/hold

/hold

AFAIU, the approach on this PR (updating the ip via the virt-handler) was chosen (and not via the virt-controller as PR https://github.com/kubevirt/kubevirt/pull/2963 suggests). When I started reviewing the PR I wasn't familiar with all the ifs and internal logic of when virt-handler is updating the vmi status and when virt-controller. For me it made sense that the same place that updates the ip on the vmi status in the first place will do it after migration, using the exact same logic to get the ip.
The virt-handler is updating the status with domain specific information (correct me if I'm wrong, but isn't the only reason that we are updating the vmi status in the virt handler is the domain information?). For masquerade we don't read the ip from the domain so I don't see any reason why the new logic should be added there.
The claim that virt-handler owns the ip when the vm is in Running phase is not accurate for masquerade. The virt-handler owns the fields that may be updated by the domain, the masquerade ip is not such a field.
Anyway, if we still decide to go with this approach and update the ip via the virt-handler. We should at least move the code that updates the ip in the status in the Scheduling phase to virt-handler as well.
Having two different methods to calculate the ip is bug prune IMO.

@AlonaKaplan good thoughts, I'll reply inline with the conclusions I've been working with.

The claim that virt-handler owns the ip when the vm is in Running phase is not accurate for masquerade. The virt-handler owns the fields that may be updated by the domain, the masquerade ip is not such a field.

right, virt-handler doesn't own the ip, it merely observes the ip. Virt-handler does own the entire vmi including all the status fields once the hand off from virt-controller occurs. So, once the vmi is moved to scheduled, the general rule is virt-controller should only observe the vmi, not modify it.
We made two exceptions to this rule in virt-controller in order to modify a couple conditions and some info related to active pods. These exceptions have been a pain point. Dual ownership of the VMI in any capacity has proven very tricky and error prone. When we get it wrong, it results in a reconcile loop storm where both virt-handler and virt-controller attempt to overwrite each other on the VMI.

Anyway, if we still decide to go with this approach and update the ip via the virt-handler. We should at least move the code that updates the ip in the status in the Scheduling phase to virt-handler as well.
Having two different methods to calculate the ip is bug prune IMO.

yup, this makes sense to me.
@vatsalparekh what @AlonaKaplan proposes here should just entail removing the section below from virt-controller, and ensuring we update the pod interface IP in virt-handler regardless if masquerade is in use or not. I think this will give us the most consistent results, and make it immediately obvious if problems arise. Otherwise we'll be in a situation where virt-controller might set an IP that a functional tests verifies, only to have virt-handler overwrite it a few seconds later to an IP we don't expect. We'd want to catch that if there's a bug somewhere in our code.
Make sense?
                                        // vmi is still owned by the controller but pod is already ready,
                                        // so let's hand over the vmi too
                                        interfaces := make([]virtv1.VirtualMachineInstanceNetworkInterface, 0)
                                        for _, network := range vmi.Spec.Networks {
                                                if network.NetworkSource.Pod != nil {
                                                        ifc := virtv1.VirtualMachineInstanceNetworkInterface{
                                                                Name: network.Name,
                                                                IP:   pod.Status.PodIP,
                                                                IPs:  []string{pod.Status.PodIP},
                                                        }
                                                        interfaces = append(interfaces, ifc)
                                                }
                                        }
                                        vmiCopy.Status.Interfaces = interfaces

@AlonaKaplan did you want to look at anything else here? I left the hold on just to make sure you're happy with the changes.

slirp tests are failing.
Slirp Networking should be able to VirtualMachineInstance with slirp interface

/lgtm

/hold cancel
yay! hopefully this is ready to go now, lets see how CI does. I bet it will pass this time

/hold

@davidvossel please remove the hold in you're ok with the PR.

/hold cancel

This had to be reverted back due to a CI issue, new fix with the same changes #3642

vmi stop ,  VmiIp cam be used by other pod?

vmi stop , VmiIp cam be used by other pod?

The VMI status would get the IP from the PodIP, so if the VMI was stopped, the old pod would be deleted and the IP can be obtained by other Pods
Also, #3642 is the PR with the latest changes from this PR. This PR had to be reverted.


Is it possible to set rust-analyzer options to match git-hooks options ?

My workspace is in a compilation battle between rust-analyzer and my git-hooks.  Every time I run a git hook it recompiles the binary, I assume because of an options mismatch with rust-analyzer.
An example from my git hook is
RUSTFLAGS="-D warnings" cargo check --tests --features="mock" || exit 1
Can I set the rust-analyzer defaults to be the same and avoid these needless recompilations ?
Thanks,
Nick

We should provide an option to do this, but it's not possible at the moment. The current work-arounds are:

disable rust-analyzer watching ("rust-analyzer.cargo-watch.enable": false in config)
run rust-analyzer with CARGO_TARGET_DIR environment set to something like ./target/rust-analyzer

I've turned on the the 'disable rust-analyzer watching' work-around.  That does the trick.
Thanks ( + thanks for rust-analyzer, my cpu has never been so happy....)

Hi,
I'm still running with rust-analyzer watching turned off.  Is there an option yet to set the compilation options rust-analyzer will use ?
Thanks,
Nick

Hi,
I'm still running with rust-analyzer watching turned off.  Is there an option yet to set the compilation options rust-analyzer will use ?
Thanks,
Nick

That's now possible, see the rust-analyzer.server.extraEnv config option in VS Code.

That's now possible, see the rust-analyzer.server.extraEnv config option in VS Code.

Adding this to vscode Code>User>settings.json has fixed this problem, Thanks.
"rust-analyzer.server.extraEnv": {
"RUSTFLAGS": "-D warnings"
},

Adding this to vscode Code>User>settings.json has fixed this problem, Thanks.
"rust-analyzer.server.extraEnv": {
"RUSTFLAGS": "-D warnings"
},