Move CI to Linux once Cosmos Emulator for Linux is ready. (hive and hadoop are not windows friendly)

Some spark framework (hive and hadoop) are not windows friendly, require additional setup, etc.
Ideally we should move to Linux for spark CI and use Cosmos Linux Emulator
@milismsft FYI

Updating the issue - still in our backlog.

We have fixed those issues and no longer plan to move to linux for emulator.


Rename OAuthAuthentication* to OAuth* and Authenticated to AccessTokenReceived.

#98
@HaoK @PinpointTownes @Eilon @brockallen
Note I did not rename the Handler, Middleware, or Options classes because A) the type names are not referenced directly in user code, and B) I didn't want to confuse the inheritance heirarchy for derived classes: FacebookAuthenticationOptions -> OAuthAuthenticationOptions -> AuthenticationOptions
I also cleaned out some obsolete Context classes.

Semantically, this naming change is totally appropriate: OAuth2 is an authorization protocol (though we use it for pseudo-authentication).
Technically, I'm not sure it's really pertinent: OAuthAuthenticationMiddleware is an authentication middleware, no matter what we think. It's derived from AuthenticationMiddleware, it calls SignInAsync during the callback process and the user is considered as authenticated after a complete "authorization flow", even if you don't provide an explicit AccessTokenReceived notification.
IMHO, removing Authentication from the extension name will just make things less clear.

Or Maybe we should shorten everything to auth?
UseGoogleAuth
UseFacebookAuth

Or app.UseOAuthAuthenrization :trollface:

:shipit:

So just close this and leave everything as is?

Aborted


NewInstance failed: expected 8 imports, found 43 on wasmtime-go v0.37.0

When NewInstance prompts an error ：expected 8 imports, found 43 ...

When using NewInstance the precise list of imports that matches up with the module's list of imports must be provided. It's recommended to use Linker if you can since it's a more natural interface to instantiation.
If you'd like some more information I'd recommend reading the Rust documentation which is what all the Go APIs are based on.


Remove automatic map selection feature

In EX & Board screen, boxes will be automatically picked / banned when song information has updated through ipc.
Remove this for better stability.

I've just removed the automatic selection feature for Board view.
Seemingly this goes fine with the EX Stage view, so I'm closing this issue.

The test match revealed the issue again, temporarily reopening.

所以可能的问题是
我们需不需要这个功能
基于gameplay已经不在这里实现，我们还是否需要ipc来获取beatmap
最好明确一下

所以可能的问题是 我们需不需要这个功能 基于gameplay已经不在这里实现，我们还是否需要ipc来获取beatmap
最好明确一下

大概率是不需要了
经过测试赛发现这个功能会自动向下一张被选的图添加状态，而被添加的状态不会根据逻辑自动轮换。也就是说，如果使用ipc自动获取beatmap来做选择会导致所有图施加同一个效果 （测试下来好像都是Red Pick）。手动设定格子后，自动选图会覆盖刚才手动设定好的正确状态。
由于我们删除了右边按钮的轮换逻辑，因此这里也大概率是出现问题的
从导播的角度来看，除非能够将下一张图自动轮换逻辑重新写好，建议还是移除这个功能。
选图/Ban图轮换逻辑可以来 这里 参考一下。

我们需不需要这个功能

No need. Compared to manually switching, we are unsure about these parts:

Whether or not all states of a block is overriden by IPC (even we've chosen to store them separately)
If so, whether controllers can quickly restore the last correct of a block (especially with two teams of traps, in the worst scenario)

This feature will most probably mess the whole board up, enforcing us staffs to inhale large amounts of smoke during the normal match, not to mention we know little about this.

不需要（激寒。与手动选图相比，自动选图的行为有不确定性：

是否会清除格子已有的所有状态（即使我们把不同状态分开存储了）
发生此情况后，导播能否迅速将格子恢复到正确的状态（最坏的情况是，需要重新布置保图+2个陷阱）

可以想见，多数情况下这个功能会让棋盘阿米诺斯，强迫全体staff在直播间吸芙蓉王，更不用说我们对一得阁拉米所知甚少了。

Have just:

Add token verification for Board view maps (blocked automatic actions)
Allow for EX automatic map selecting (we use an individual list for this)
Unchanged for Mappool view maps

We can have a test sometime and then close the issue when everything about this goes as intended.

Pinging @CloneWith for update on this issue.
Tested and everything is looking good, changing map in the matchroom will no longer trigger the automatic map-selection feature in lazer.
I believe that the automatic map-selection feature in EX Screen is intended to left in the code, however the default status of the selected map is incorrect. It uses a status similar to "Red Pick" in board screen as default:

this unknown status
Red win status

When "Pick" is selected on the control panel, applied status will be correct when performing auto-selection. This bug can be recreated by following these steps:

Do a fresh launch of the lazer
Go straight into EX screen, without selecting status on the control panel
Change the map in the match room to trigger automatic map selection

Setting the default status to "Pick" once we enter the EX screen should be a viable solution.

It uses a status similar to "Red Pick" in board screen as default.

Yes it's true, since in all views using BeatmapChoice, it starts with a "Red Pick".
Some solutions I suppose:

[ ] Set the default button status (-> Neutral Pick)
[ ] Rule out illegal choices (e.g. Pick with colors in this case)

For now much of the issue should be complete.
If everything is OK then this can be closed as completed.

测？等回

New issue where
Seems this problem have not fixed for the new intro for map picks. Do you like Smoke team picked?


Pumpkin does support more

Saw you have a comparison between some Server softwares

Wanted to note that Pumpkin does in fact support more features than listed

Please feel free to PR if something is missing/incorrect.

ok let's go over it. If you update your README I can update this repo better https://github.com/Snowiiii/Pumpkin

Above is pumpkin when I join the server.

has been tested with thousands of player connects. I have not seen this. if you have evidence it can run 5k bot connections at 20TPS all where they can see each other (or similar) I will change this. However, joining in your server with multiple clients I do not even see the other players!
proximity voice chat quite sure you do not have this
lighting based on the image does not appear to work
placing blocks I cannot seem to find out how to get blocks. destroying blocks is not putting them in my inventory
destroying blocks likewise having issues here too. the blocks do not go in my inventory. I'm unsure if the server is even handling the packets
...

unsure if these worked at some point. However, most of these do not work now. I do see I got the Minecraft version wrong so I will change that.

I am closing this, but if I see any big changes in your server, I will make sure to update where appropriate—good job on your project.


Errors uploading dashboard to Openshift 3.11

I am trying to upload the kibana5_traffic.json to OCP 3.11 but getting errors
In openshift the index pattern is project., I changed logstash- to project.* in the json and uploaded the file. In OCP we have EFK stack and Kibana version is 5.6.16.
In  liberty(<IP_ADDRESS>) server.xml added below lines
<accessLogging logFormat='%R{W} %u %{my_cookie}C %s'/>
 <logging consoleSource="message,trace,accessLog,audit" consoleFormat="json" jsonAccessLogFields="logFormat"/>

In Kibana, on refresh in Management->Index Patterns -> project.* I see only below fields
ibm_datetime
ibm_datetime.raw
ibm_messageId
ibm_messageId.raw
ibm_sequence
ibm_sequence.raw
ibm_serverName
ibm_serverName.raw
ibm_threadId
ibm_threadId.raw
ibm_userDir
ibm_userDir.raw

When I upload the json dashboard, I see below errors in Kibana
Saved Objects: Importing Liberty Message (liberty_messageGraph) failed: Could not locate that index-pattern-field (id: loglevel.keyword)
Saved Objects: Importing Liberty Access Log Response Code (liberty_accessLogResponseCodeGraph) failed: Could not locate that index-pattern-field (id: ibm_responseCode)
Saved Objects: Importing Liberty Access Log Elapsed Time (liberty_accessLogElapsedTimeGraph) failed: Could not locate that index-pattern-field (id: ibm_elapsedTime)
Saved Objects: Importing Liberty Access Log Average Elapsed Time (liberty_accessLogAverageElapsedTimeGraph) failed: Could not locate that index-pattern-field (id: ibm_elapsedTime)
Saved Objects: Importing Liberty Slow Hits (liberty_slowHits) failed: Could not locate that index-pattern-field (id: ibm_elapsedTime)
Saved Objects: Importing Liberty Slowest URLs (liberty_slowestURLs) failed: Could not locate that index-pattern-field (id: ibm_uriPath.keyword)
Saved Objects: Importing Liberty Trace (liberty_traceGraph) failed: Could not locate that index-pattern-field (id: loglevel.keyword)
Saved Objects: Importing Liberty Top URLs (liberty_topURLs) failed: Could not locate that index-pattern-field (id: ibm_uriPath.keyword)
Saved Objects: Importing Liberty Servers (Traffic) (AWYhv5KDN1XQo0uIQwxD) failed: Could not locate that index-pattern-field (id: ibm_serverName.keyword)
Saved Objects: Importing Liberty User Directories (Traffic) (AWYhvzNUN1XQo0uIQwwV) failed: Could not locate that index-pattern-field (id: ibm_userDir.keyword)
Saved Objects: Importing Liberty Access Log Metrics (liberty_accessLogMetrics) failed: Could not locate that index-pattern-field (id: ibm_elapsedTime)
Saved Objects: Importing Liberty Hosts Table (Traffic) (AWYhvu0tN1XQo0uIQwv4) failed: Could not locate that index-pattern-field (id: host.keyword)

Hi @MastanaGuru ,
If you're setting jsonAccessLogFields="logFormat" the JSON access log fields will only include the properties you specify in the accessLogging logFormat attribute. To make it work with our existing dashboards, you can either change jsonAccessLogFields="default" to only include, or change your logFormat to:
<accessLogging logFormat='%h %H %A%B %m %p %q %{R}W %s %U'/>.
For more info about jsonAccessLogFields:
https://openliberty.io/blog/2020/07/30/json-logging-open-liberty-20008.html
Information about accessLogFormat:
https://openliberty.io/docs/<IP_ADDRESS>/access-logging.html
Let me know if you still have questions

@MastanaGuru , I think you may 3 problems.

based on fact your dashboard json refers to logstash-* and not project-* , and the fact you're posting this issue in WASdev/sample.dashboards, I think you're using our standalone (non Kubernetes) dashboard.  For OKD/OCP you should use the dashboards at https://github.com/OpenLiberty/open-liberty-operator/blob/master/deploy/dashboards/logging .
if after refresh of your index pattern you don't see the fields related to the access log json it likely means you haven't yet generated any access log events on the Liberty side.  That means Elasticsearch hasn't seen/mapped those fields yet, so Kibana doesn't know about them.  Try hitting a url and check to see if you have records in your access.log file
as @Yushan-Lin says, even if you had created access log fields you'd be missing the default ones that the traffic dashboard depends on.  You could create at least one access log record with the default set of fields included, or remove the visualizations that rely on those fields from the dashboard.

@donbourne , @Yushan-Lin , Thanks that works, I used the RHOCP dashboards. But accesslogs is really filling up the storage, wondering if there is a way we can exclude some urls in accesslog setting, specifically health check and readiness probe.

@MastanaGuru , I don't have a simple answer for how to filter the access logs.  My first thought would be to set a grep filter in the Fluentd configuration, but cluster logging doesn't expose that in its configuration.
One thing you could do, which I know will sound like a hack, is to filter the output from Liberty's stdout itself.  This would probably need to be a change to your Open Liberty image's command that starts the server and would look something like this:
./server run server1 | grep --line-buffered -v "/metrics" | grep --line-buffered -v "/health"

This should work because Liberty's JSON log is output to console with each JSON event on a separate line.


[SPARK-19342][SPARKR] bug fixed in collect method for collecting timestamp column

What changes were proposed in this pull request?
Fix a bug in collect method for collecting timestamp column, the bug can be reproduced as shown in the following codes and outputs:
library(SparkR)
sparkR.session(master = "local")
df <- data.frame(col1 = c(0, 1, 2),
                 col2 = c(as.POSIXct("2017-01-01 00:00:01"), NA, as.POSIXct("2017-01-01 12:00:01")))

sdf1 <- createDataFrame(df)
print(dtypes(sdf1))
df1 <- collect(sdf1)
print(lapply(df1, class))

sdf2 <- filter(sdf1, "col1 > 0")
print(dtypes(sdf2))
df2 <- collect(sdf2)
print(lapply(df2, class))

As we can see from the printed output, the column type of col2 in df2 is converted to numeric unexpectedly, when NA exists at the top of the column.
This is caused by method do.call(c, list), if we convert a list, i.e. do.call(c, list(NA, as.POSIXct("2017-01-01 12:00:01")), the class of the result is numeric instead of POSIXct.
Therefore, we need to cast the data type of the vector explicitly.
How was this patch tested?
The patch can be tested manually with the same code above.

Can one of the admins verify this patch?

Thanks! I can verify this case and the fix.
Could you please add some tests for this?

Oh @felixcheung , I was writing a comment but I just saw you. I was looking into this for my curiosity.
Isn't this due to R type coercion rule with POSIXlt?
> str(data.frame(col1 = c(as.POSIXct("2017-01-01 12:00:01"), NA)))
'data.frame':	2 obs. of  1 variable:
 $ col1: POSIXct, format: "2017-01-01 12:00:01" NA

> str(data.frame(col1 = c(NA, as.POSIXct("2017-01-01 12:00:01"))))
'data.frame':	2 obs. of  1 variable:
 $ col1: num  NA 1.48e+09

(I might be wrong but was suspecting that it returns NA first as logical when we collect via SerDe.scala and then it ends up numeric due to the type coercion when NA is located first as above.)

Oh. it was all written in the PR description... I removed my uesless comments.

Sure. Shall I add the tests in pkg/inst/tests/testthat/test_sparkSQL.R?

yes. but please see my other comment

Sorry for the late reply. I figured out that the tests failed because if a vector is with only NAs, the type is logical, therefore we cannot cast the type in that case. I have updated the codes and added some tests for that. Thank you for the advice.

great! @shivaram could you get Jenkins to test this fix please? I don't seem to have the power to command it :)

Jenkins, retest this please

Jenkins, ok to test

Test build #71969 has started for PR 16689 at commit 6a0eb3f.

Test build #71969 has finished for PR 16689 at commit 6a0eb3f.

This patch fails R style tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/71969/
Test FAILed.

Test build #71982 has started for PR 16689 at commit 43e334a.

Test build #71982 has finished for PR 16689 at commit 43e334a.

This patch fails R style tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/71982/
Test FAILed.

I have modified the codes and tests, including the existed tests @test_sparkSQL.R#1280 and @test_sparkSQL.R#1282.
Like in local R,  now NA column of the SparkDataFrame will also be collected as its corresponding type instead of logical NA.

Just to make sure you see this: https://github.com/apache/spark/pull/16689#issuecomment-275063425

Test build #72182 has started for PR 16689 at commit 7903bb3.

Test build #72182 has finished for PR 16689 at commit 7903bb3.

This patch fails R style tests.
This patch merges cleanly.
This patch adds no public classes.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/72182/
Test FAILed.

Merged build finished. Test FAILed.

Test build #72186 has started for PR 16689 at commit 8379c38.

Test build #72186 has finished for PR 16689 at commit 8379c38.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/72186/
Test PASSed.

Test build #72250 has started for PR 16689 at commit 407c625.

Test build #72250 has finished for PR 16689 at commit 407c625.

This patch fails SparkR unit tests.
This patch merges cleanly.
This patch adds no public classes.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/72250/
Test FAILed.

Merged build finished. Test FAILed.

I tried to modify the PRIMITIVE_TYPES for timestamp, but it had a side effect on coltypes method.
In test_sparkSQL.R#2262, expect_equal(coltypes(DF), c("integer", "logical", "POSIXct")), coltypes return a list instead of a vector because of the convertion from timestamp to c(POSIXct, POSIXt)

hmm, that's not a super big issue since vector and list is more or less the same in R.
I think it might be better if we are treating the type consistently, although it might be a concerning if this is changing in a non-backward compatible manner.
let me try to find some time to test this out? thanks!

Test build #72378 has started for PR 16689 at commit d6d454e.

Test build #72378 has finished for PR 16689 at commit d6d454e.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/72378/
Test PASSed.

Thanks. I tried to fix the method coltypes for the modification of the timestamp, and it can pass all the tests now.

hmm, this seems like a reasonable approach. With these changes:

collect on timestamp would get c("POSIXct", "POSIXt")
coltypes output will not change

@shivaram what do you think?

@felixcheung @titicaca Just to make sure I understand, collect on timestamp was getting c("POSIXct", "POSIXt") even before this change ?

Yes, collect on timestamp was getting c("POSIXct", "POSIXt"). But when NA exists at the top of the timetamp column, it was getting numeric as I described in the PR description.

Ok - I think this sounds good then ! @felixcheung Let me know if you want me to take a look at the code as well or if not feel free to merge when you think its ready

great, this is a good catch and thank you for fixing this @titicaca
merging to master, branch-2.1

@titicaca do you have a JIRA id on https://issues.apache.org? We would resolve the bug to you.

Yes. The JIRA id is SPARK-19342. Thank you for the help and advices :)

@titicaca he means, what is your user ID on JIRA? so we can credit you. It's clear what the JIRA is.

Thanks for the reminder. I may have forgotten to mention that I am the reporter of this JIRA bug. My JIRA ID is also titicaca. Thank you!

Great, done!
Looking forward to more contributions from you :)


Make tickless kernel the default mode

Move to tickless kernel by default.
Should address the issues below as well as set the default to tickless kernel

[ ] #3651: add tickless idle and kernel support to RISCV32 pulpino
[ ] #7048: Tickless Kernel Timekeeping Problem
[ ] #7193: tickless and timeslicing don't play well together
[ ] #8257: Unify KERNEL_TICKLESS and KERNEL_IDLE
[ ] #9627: Clean up timeout handling
[ ] #9904: nRF system timer handling

CC @pizi-nordic @cvinayak

Refactoring in preparation up at #10160 -- that shrinks the driver interface (a lot) and cleans up the intent of the behavior.  It doesn't actually change the way the kernel or drivers work, but it enables a simpler rewrite of both.


Update requests dependency

Pins requests dependency to version 2.4.0.

Coverage remained the same at 98.824% when pulling ecaa89ba569bbd757ba2687e4110849acb5a93d4 on Markus00000:master into c379ed6e1540b434d6657c9f3bc6e949c1c40a58 on avinassh:master.

Thank you! I have made a new release :)


Add Waypoints for 2023 Iditarod

This adds new waypoints for the 2023 Iditarod Race from Code for Anchorage.

Thank you, and welcome to Takotna in 2023! I'm not sure why the check-formatting failed, the GeoJSON shouldn't be tested at all. Never mind, I merged it. Thank you for your contribution again!


Sudden Typescript Inference Error

Issue Type: Bug
What happened

typescript throwing errors for certain parameters whose types were previously inferred

so far, only seen for react-redux and headless-ui packages
ts unable to infer the proper type instead they have an implicit type of 'any'

at some point, this problem occurred when nothing was done that could have possibly triggered any change

no packages installed, settings changed, configurations changed, etc

for a while, when switched to a previous project using near identical set-up, this previous project was working fine, but after 30 minutes or so the same problem occurred
all other aspects of typescript seem to be working fine

In the example, below, state, the parameter of reducer1 incorrectly has an implicit type of any.
import { createSlice, createEntityAdapter } from "@reduxjs/toolkit";

const exampleAdapter = createEntityAdapter<{id: string, text: string}>()
const exampleInitialState = exampleAdapter.getInitialState()

const exampleSlice = createSlice({
  name: 'example',
  initialState: exampleInitialState,
  reducers: {
    reducer1(state) => {
      //...
    }
  }
})

Attempted solutions

reinstalled packages for typescript and typescript packages of react-redux
went over another project that was previously working fine and checked any differences

stopped doing this when the previous project showed the same error after a bit

disabled all extensions

VS Code version: Code 1.67.1 (da15b6fd3ef856477bf6f4fb29ba1b7af717770d, 2022-05-06T12:39:22.915Z)
OS version: Linux x64 5.15.38-1-MANJARO
Restricted Mode: No

System Info

Item
Value

CPUs
Intel(R) Core(TM) i5-7400 CPU @ 3.00GHz (4 x 3371)

GPU Status
2d_canvas: enabledcanvas_oop_rasterization: disabled_offdirect_rendering_display_compositor: disabled_off_okgpu_compositing: enabledmultiple_raster_threads: enabled_onoop_rasterization: disabled_offopengl: enabled_onrasterization: disabled_softwareraw_draw: disabled_off_okskia_renderer: enabled_onvideo_decode: disabled_softwarevideo_encode: disabled_softwarevulkan: disabled_offwebgl: enabledwebgl2: enabled

Load (avg)
1, 1, 1

Memory (System)
7.71GB (0.96GB free)

Process Argv
--unity-launch --crash-reporter-id dbfba643-ce8b-41b2-a55b-b818de6618c6

Screen Reader
no

VM
0%

DESKTOP_SESSION
gnome

XDG_CURRENT_DESKTOP
GNOME

XDG_SESSION_DESKTOP
gnome

XDG_SESSION_TYPE
wayland

Extensions (22)

Extension
Author (truncated)
Version

better-comments
aar
3.0.0

shift-shift
ahg
0.0.5

All-Autocomplete
Ati
0.0.23

vscode-tailwindcss
bra
0.8.3

vscode-eslint
dba
2.2.2

prettier-vscode
esb
9.5.0

auto-close-tag
for
0.5.14

auto-complete-tag
for
0.1.0

auto-rename-tag
for
0.1.10

tailwindcss-intellisense-twin
lig
0.12.3

vscode-typescript-next
ms-
4.8.20220512

impsorter-vscode
nui
1.2.3

material-icon-theme
PKi
4.17.0

alphabetical-sorter
ue
2.0.1

learn-vim
vin
0.0.27

vim
vsc
1.22.2

vscode-js-console-utils
wht
0.7.0

vscode-import-cost
wix
3.3.0

glean-react-refactor
Woo
4.8.4

vscode-surround
yat
1.3.0

copy-hover-type
You
0.0.6

sort-js-object-keys
zen
1.0.6

(3 theme extensions excluded)

A/B Experiments
vsliv368cf:30146710
vsreu685:30147344
python383:30185418
vspor879:30202332
vspor708:30202333
vspor363:30204092
pythonvspyl392:30443607
pythontb:30283811
pythonvspyt551:30345470
pythonptprofiler:30281270
vsdfh931:30280409
vshan820:30294714
vstes263:30335439
pythondataviewer:30285071
vscod805:30301674
pythonvspyt200:30340761
binariesv615:30325510
bridge0708:30335490
bridge0723:30353136
vsaa593:30376534
vsc1dst:30438360
pythonvs932:30410667
wslgetstarted:30449410
pythonvsnew555:30457759
vscscmwlcmt:30465135
cppdebug:30475216
vsclangdc:30486549

Does this reproduce in the latest VS Code insiders build with all extensions disabled?

This issue has been closed automatically because it needs more information and has not had recent activity. See also our issue reporting guidelines.
Happy Coding!

Apologies for the delay in writing again.
It appears it wasn't an error with VSCode. I disabled all extensions again and it appears it was a problem with eslint. I'm still not sure exactly what happened but reinstalling eslint globally somehow resolved the issue.


Can't select top-most containing in the navigation menu when it has contents

I very much like the approach of this addon. I can't tell if I'm using it right.

When I have a page that has subpages, the menu header indicates that it does with the downward pointing caret character.

That's what I would expect.

When I click on the name of the containing page, a dropdown menu opens showing the immediate contents of the page.

This is a problem. I am therefore not able to use the navigation bar to visit the containing page.

Either:

Clicking on the page name should visit the page, and you would have to click the downward pointing caret to open the dropdown menu, or
You can click anywhere to open the dropdown menu, and the menu includes an entry for the containing page which you can clicke to visit it.

I think option 1 is a better approach.
Please clarify if I'm missing the right way to use this addon. I've explored the Navigation options in the control panel, but didn't see a way to enable navigating to the top-most container.
Here are some pertinent versions:

@codesyntax/volto-menu-customization 0.2.0
Volto 16.4.1
Plone 6.0.0
plone.restapi 8.32.6

This is the usual problem of dropdown menus in Plone like CMSs where the top page needs to be rendered to build the dropdown and is in itself a click...
I like your solution, but we need some testing because sometimes making just the caret clickable is not obvious for the end user.


Fix python unit tests, fix #677

Related to #673. The error on explog.py was actually due to the binding of SE3.isIdentity() which was crashing. I do not understand why there was this problem and why only in Debug mode, but I fixed it.
The error on bindings_com.py and bindings_dynamics.py was just a trivial error in the unit test itself (wrong vector size). I corrected it. Which makes me think, wouldn't it be better to enable assertions the Python library? If yes, is there any way to treat a failing assertion as an exception instead of having Python crash completely when one fails?

@gabrielebndn Cool. Nice fix of the overloading.
I'm waiting for Travis and will merge afterward.

@gabrielebndn Thanks for your contribution.

Which makes me think, wouldn't it be better to enable assertions the Python library?

During the tests, yes. I'll add that to #673 .


test(buffer): ensure emojis are rendered

They are not rendered as expected but not completely wrong either so that's a win?

Just to be clear - these are characterization tests right? The purpose is to document existing behavior even if it's wrong(-ish)?

Yeah. I suspected my change in #1226 might have broken something because of the way more complex emojis are joined together so I wanted to make sure it still renders them.


Update main bot (app.js) to work with v13.

Rewrite all core code with full working solutions.

[x] Rewrite main code in index.js / app.js
[x] Rewrite bootloader.js script - This handles config handling.

Completed all tasks for now. Closing as complete.


Test Array storing different endian and attributes

Pulled from PR ( https://github.com/zarr-developers/zarr/pull/309 ) and added to StoreTests so that it can be applied to multiple storage classes. Credits to @funkey for adding these tests.
TODO:

[ ] Add unit tests and/or doctests in docstrings
[ ] Add docstrings and API docs for any new/modified user-facing classes and functions
[ ] New/modified features documented in docs/tutorial.rst
[ ] Changes documented in docs/release.rst
[ ] Docs build locally (e.g., run tox -e docs)
[ ] AppVeyor and Travis CI passes
[ ] Test coverage is 100% (Coveralls passes)

Hello @jakirkham! Thanks for submitting the PR.

In the file zarr/tests/test_storage.py, following are the PEP8 issues :

Line 24:80: E501 line too long (82 > 79 characters)
Line 25:80: E501 line too long (81 > 79 characters)
Line 152:80: E501 line too long (85 > 79 characters)
Line 763:80: E501 line too long (82 > 79 characters)
Line 925:80: E501 line too long (83 > 79 characters)
Line 952:80: E501 line too long (80 > 79 characters)
Line 1210:80: E501 line too long (81 > 79 characters)
Line 1331:80: E501 line too long (85 > 79 characters)
Line 1332:80: E501 line too long (89 > 79 characters)
Line 1364:80: E501 line too long (84 > 79 characters)
Line 1365:80: E501 line too long (84 > 79 characters)
Line 1366:80: E501 line too long (89 > 79 characters)
Line 1367:80: E501 line too long (89 > 79 characters)

Planning on merging end of day Friday if no comments.


Remove unsupported hashing methods.

Support of Whirlpool and RIPEMD160 hashing methods was removed in
cryptography.hazmat.primitives.
https://github.com/pyca/cryptography/commit/0d6aaf49c1890378ce7ecf741a3a40c859d3b9fb

Thanks @jomunoz! I merged and released #174 to get credstash usable again. I'll look at pulling your changes in.

Thanks @wayne-luminal, I think this pr might be the proper solution. In the other solution, by locking to a particular version of the cryptography library, we will be missing bugs fixes that will be made for that library.

@jomunoz You're right. When I looked at both PRs, I see this one is failing but haven't had time to dig into what the issue is yet. I figured to get a workable credstash again I'd add temporarily add the <2.1 to cryptography.

I guess I duped this without noticing https://github.com/fugue/credstash/pull/178 :(
There are some additional bits in my PR that I think might be important.


A bug when running dodrio-data-gen.py

May I ask why I encount this problem, I had no changes about the codes.

Hi, thanks for experimenting with customizing Dodrio!
This issue is most likely an issue with the version of the transformers library you are using. As you can see, the add_pooling_layer argument is not present in all versions of the library. (v4.7.0 vs. v2.11.0). Try changing the version of the library that you are using to see if this resolves your problems. We will upload an environment.yml file with all the necessary dependencies soon!

Let us know if https://github.com/poloclub/dodrio/issues/2#issuecomment-866262279 didn't fix the problem. I will close the issue now, feel free to re-open it :)


Fix391

Fixes #391
When user adds additional module plugin search paths the editor will check to see if the current configuration is loaded with any "missing modules" (default modules substituted for any classes which could not be loaded). If the repository is loaded with these default modules, it will send a self-addressed message to reload the current configuration.

Bleep bloop!
LabVIEW Diff Robot here with some diffs served up hot for your pull request.
Notice something funny? Help fix me on my GitHub repo.
PL Framework Configuration Tool.lvlib--SystemConfigRepo.lvclass--Check for Missing Modules.vi.png:
Standard Editor.lvlib--Open PCFG.vi.png:

Bleep bloop!
LabVIEW Diff Robot here with some diffs served up hot for your pull request.
Notice something funny? Help fix me on my GitHub repo.
PL Framework Configuration Tool.lvlib--SystemConfigRepo.lvclass--Check for Missing Modules.vi.png:
Standard Editor.lvlib--Open PCFG.vi.png:

Bleep bloop!
LabVIEW Diff Robot here with some diffs served up hot for your pull request.
Notice something funny? Help fix me on my GitHub repo.
PL Framework Configuration Tool.lvlib--SystemConfigRepo.lvclass--Check for Missing Modules.vi.png:
Standard Editor.lvlib--Open PCFG.vi.png:

Bleep bloop!
LabVIEW Diff Robot here with some diffs served up hot for your pull request.
Notice something funny? Help fix me on my GitHub repo.
About Screen Library.lvlib--About Screen.vi.png:
About Screen Library.lvlib--Unflatten Config.vi.png:
PL Framework Configuration Tool.lvlib--Engine Parent Editor Node.lvclass--AddChildtoNode.vi.png:
PL Framework Configuration Tool.lvlib--module editor node.lvclass--CleanUpNode.vi.png:
PL Framework Configuration Tool.lvlib--SystemConfigRepo.lvclass--Check for Missing Modules.vi.png:
PL Framework Configuration Tool.lvlib--view deploy screen.vi.png:
Standard Editor.lvlib--Open PCFG.vi.png:

@becega Finally passing all of the build stages. Can you review this when you have the chance?


Can't access some pages

I am Timotei Satmarean on codewars and I can't acces https://www.codewars.com/trainer/setup, https://www.codewars.com/kumite, https://www.codewars.com/trainer/setup, https://www.codewars.com/dashboard. Every time I try to access one of these I get "Aw, snap! Something went wrong while displaying this webpage."

@timoteius Consider including the following information in your Issue Report:

The browser in which you are encountering this Issue in
A suitable screenshot, ideally containing any error logs from the browser (e.g. use "Inspect Element" on Safari)

view-source:https://www.codewars.com/trainer/setup
I use only Google Chrome, but I downloaded Opera to try it.

In Chrome 58.0.3029.110 (64-bit) and Firefox 54 same trouble.

Has this been resolved already?

Just now checked, all work correctly!
Thanks.

It works! Thanks dmz9


Cloud undelete Implementation for VCR

Note that this is Phase 1 of undelete support in cloud, for VCR and DR cases only.
Support for frontend related cases coming soon with other cloud blob store changes for supporting serving data in azure.

Codecov Report

Merging #1497 into master will increase coverage by 0.31%.
The diff coverage is 69.23%.

@@             Coverage Diff              @@
##             master    #1497      +/-   ##
============================================
+ Coverage     73.38%   73.70%   +0.31%
- Complexity     7917     8010      +93
============================================
  Files           561      562       +1
  Lines         43840    44057     +217
  Branches       5523     5553      +30
============================================
+ Hits          32171    32471     +300
+ Misses        10060     9956     -104
- Partials       1609     1630      +21

Impacted Files
Coverage Δ
Complexity Δ

...n/java/com/github/ambry/store/PersistentIndex.java
91.22% <ø> (+0.10%)
253.00 <0.00> (+1.00)

...ithub/ambry/cloud/azure/AzureCloudDestination.java
71.27% <53.33%> (-1.99%)
37.00 <2.00> (+2.00)
:arrow_down:

...m/github/ambry/cloud/azure/CosmosDataAccessor.java
64.06% <57.14%> (+0.23%)
30.00 <3.00> (+3.00)

...java/com/github/ambry/cloud/CloudBlobMetadata.java
89.76% <70.00%> (-1.00%)
44.00 <5.00> (+3.00)
:arrow_down:

...ithub/ambry/cloud/azure/AzureBlobDataAccessor.java
79.42% <75.00%> (-0.23%)
26.00 <4.00> (+4.00)
:arrow_down:

...in/java/com/github/ambry/cloud/CloudBlobStore.java
83.44% <91.66%> (+0.55%)
91.00 <2.00> (+2.00)

...n/java/com/github/ambry/clustermap/MockDiskId.java
80.00% <0.00%> (-5.72%)
12.00% <0.00%> (-1.00%)

...a/com/github/ambry/network/SSLBlockingChannel.java
75.67% <0.00%> (-5.41%)
4.00% <0.00%> (ø%)

...in/java/com/github/ambry/clustermap/Partition.java
76.92% <0.00%> (-3.30%)
28.00% <0.00%> (-1.00%)

.../com/github/ambry/network/BlockingChannelInfo.java
76.98% <0.00%> (-3.18%)
15.00% <0.00%> (ø%)

... and 22 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e81244d...e206d6e. Read the comment docs.


Fix and rename rgba16_to_rgba32

This fixes the conversion from rgba16 to rgba32.
I also renamed the function because according to the GS User Manual, Section 2.3.1 that Color Data Format it's called rgba16 and not rgba15 hope you don't mind.

Pull Request Test Coverage Report for Build 389360218

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 81.104%

Totals

Change from base Build 389050095:
0.0%

Covered Lines:
16804

Relevant Lines:
20719

💛  - Coveralls

This is perfect, thanks!  The name change is a good idea too.


cli: check for the presence of required executables

The assert_executable_exists(cmd) function checks for the presence of an executable in the environment where the workflow is executed.
So, we can utilize this function to check for the presence of the required binaries/executables through the __init__() method(constructor) of the concerned runner classes, like runner_slurm.SlurmRunner, etc defined in runner_host.py and runner_slurm.py. This would block a runner from getting initialized and fail if it does not meet its required software dependencies.
For example, we need to check for sbatch executable in runner_slurm.SlurmRunner, singularity executable in runner_host.SingularityRunner,  podman in runner_host.PodmanRunner, etc.

Hello again! My teammate and I also commented on issue #913. We would also like to work on this issue.

Hi @abbycriswell. Thanks a lot for looking into this issue. Please go ahead. Feel free to ask any questions you might have. You can start by looking into the contribution guidelines and the development environment setup guides. Also, feel free to join our slack channel (join here) for any discussion regarding the issue.


Add a check to fail if "soft" anti-affinity and external enabled

With fixed NodePort ports, two pods cannot reside on the same node. If a user has external listeners enabled and sets the anti-affinity to soft, we should fail.
JIRA Link: K8S-21

Closing due to age and inactivity. Feel free to re-open.


update readme with renaming aws region

What did you implement:
Closes #16

How did you implement it:

Updated README
How can we verify it:
Look at the README lol

Todos:

[ ] Write tests
[x] Write documentation
[ ] Fix linting errors
[ ] Make sure code coverage hasn't dropped
[ ] Provide verification config / commands / resources
[ ] Enable "Allow edits from maintainers" for this PR
[ ] Update the messages below

Is this ready for review?: YES
Is it a breaking change?: NO

gonna cut v0.1.2 after this gets merged


Module build failed: SyntaxError: Unexpected token Error in my App.js

I have recently upgraded from webpack v1 to v2. I have worked hard on resolving on this issue and finally here to find a solution. I'm using the latest available build of webpack 2.1.0-beta.28
Here is my Error:
ERROR in ./Src/Scripts/App.js
Module build failed: SyntaxError: Unexpected token (42:2)

  40 |
  41 | ReactDOM.render(
> 42 |   <Router history={browserHistory} onUpdate={() => window.scrollTo(0, 0)}>
     |   ^
  43 |     <Route path="/" component={Layout}>
  44 |       <IndexRoute component={Login} />
  45 |       <Route path="/login" component={Login} />

 @ multi js

ERROR in chunk js [initial]
raj.bundle.js
Conflict: Multiple assets emit to the same filename 'raj.bundle.js'

Can you please point me right direction to where my config went wrong while setting up the new webpack.config.js?
Here is my webpack.config.js
const webpack = require('webpack');
const path = require('path');

const isProd = false;

const sourcePath = path.join(__dirname, 'Src');
const staticsPath = path.join(__dirname, 'Src/Bundles');

const plugins = [
  new webpack.optimize.CommonsChunkPlugin({
    name: 'raj',
    minChunks: Infinity,
    filename: 'raj.bundle.js'
  }),
  new webpack.DefinePlugin({
    'process.env': { NODE_ENV: JSON.stringify('production') }
  }),
  new webpack.NamedModulesPlugin(),
];

module.exports = {
  devtool: isProd ? 'source-map' : 'eval',
  context: sourcePath,
  entry: {
    js: './Scripts/App.js',
    html: './index.html'
  },
  output: {
    path: staticsPath,
    filename: '[name].bundle.js'
  },
  module: {
    rules: [
      {
        test: /\.html$/,
        exclude: /node_modules/,
        use: 'file-loader',
        query: {
          name: '[name].[ext]'
        }
      },
      {
        test: /\.css$/,
        exclude: /node_modules/,
        use: [
          'style-loader',
          {
            loader: 'css-loader',
            options: { modules: true }
          }
        ]
      },
      {
        test: /\.(js|jsx)$/,
        exclude: /node_modules/,
        use: [
          {
            loader: 'babel-loader',
            options: {
              presets: [
                ['es2015', { modules: false }]
              ]
            }
          }
        ],
      },
    ],
  },
  resolve: {
    extensions: ['.webpack-loader.js', '.web-loader.js', '.loader.js', '.js', '.jsx'],
    modules: [
      path.resolve(__dirname, 'node_modules'),
      sourcePath
    ]
  },
  plugins,
  devServer: {
    contentBase: sourcePath,
    historyApiFallback: true,
    port: 3000,
    compress: isProd,
    inline: !isProd,
    hot: !isProd,
  }
};

Thanks in advance

there is no react preset.
Please submit support requests and questions to StackOverflow using the tag [webpack]. StackOverflow is better suited for this kind of support. The issue tracker is for bug reports and feature discussions. See also our CONTRIBUTING guidelines.

Thanks @sokra that was silly of me.. :)  I will do that from next time.. Now, I'm facing some compilation Errors iin few files, may be i have to add some extra preset options or resolve to get rid of them.


feat(core): Add endpoint to get current pipeline definition

There's currently no endpoint in front50 to get the current pipeline definition; consumers need to call the history endpoint with a limit of 1 and take the single returned element.
Let's make the API simpler for consumers who just want the current definition by giving them an endpoint to return it.
Forcing consumers to call the /history endpoint has led to performance issues, as that endpoint is often much slower than a call to get the current definition. Some backing stores have optimized to short-circuit the limit=1 case (s3 in #316), but others (including GCS) are still very slow even in the limit=1 case.
We could (and potentially should) make the same optimization to other backing stores. But I think the fundamental issue here is that we have rare, slow history-type requests and frequent (ideally) fast
current-state requests going to the same endpoint. This PR creates that distinction, and consumers can elect to use the new endpoint going forward.

This is a first step in solving the general performance problem noted in this comment.  Once this is in place, calls to front50 that don't need history can use this new endpoint.

Thanks @ezimanyi, I ❤ this


Migrate controllers to seperate API project

[x] Create API project
[ ] Migrate Experience Level Controller
[ ] Migrate Listing Controller
[ ] Migrate Company Controller
[ ] Migrate Inquiry Controller
[ ] Migrate Auth Controller

 Dev - Listing API

 Dev - Auth API

 Dev - Experience Level API

 US4005: Dev - Company API


ServerStream closure issue

We are using ServerStream to get response from Google Ads API call. Is there any way to close the server stream to avoid memory leaks  as we are getting below error while running the reports in server.
Java HotSpot(TM) 64-Bit Server VM warning: INFO: os::commit_memory(0x00007f6a71cb2000, 12288, 0) failed; error='Cannot allocate memory' (errno=12)
[thread<PHONE_NUMBER>48704 also had an error]
Exception in thread "Gax-30410" java.lang.OutOfMemoryError: unable to create new native thread
at java.lang.Thread.start0(Native Method)
at java.lang.Thread.start(Thread.java:717)
at java.util.concurrent.ThreadPoolExecutor.addWorker(ThreadPoolExecutor.java:957)
at java.util.concurrent.ThreadPoolExecutor.processWorkerExit(ThreadPoolExecutor.java:1025)
at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1167)
at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
at java.lang.Thread.run(Thread.java:748)

Hi,
Please see my response to a similar issue. In addition, make sure that you are closing your service client (GoogleAdsServiceClient) as mentioned in the second paragraph of our guide.
If those don't resolve the memory issues, let me know.
Thanks,
Josh

Please see my response in #612 as well.
Thanks


Updates for example data

The test/example data Example Data (A) needs a few updates.

q5, q6 and q7 columns should use mapped meta sitting in lib.
Add a values object to all the q5, q6 and q7 masks
Add text object to masks

Resolved by #391.


ci: dry run publish on rc tags for python & nodejs binding

pypa/gh-action-pypi-publish dose not have a dryrun option, so we just list package files.

Part of: #3603

cc @suyanhanx

Thans for your work! But I'm sorry.  I'm working on the nodejs part.  Could you please remove them?

Maybe we could try to publish python bindng to here https://test.pypi.org/ as dry run?


Overwrite top menu bar shortcuts

Currently, Alt+ opens the top menu bar, for example, Alt+D opens the debug menu.
Would like to be able to remap Alt+ to something more useful than opening the menu bar.

Use window.customMenuBarAltFocus and window.enableMenuBarMnemonics and configure Alt keybindings to your hearts content.

@sbatten Is there a way to stop the toggling of the menu entirely?


update workspace

https://yarnpkg.com/features/workspaces#workspace-ranges-workspace
I had some build issues where yarn was looking for package names in npm registry, when it should have been pulling a workspace.
using workspaces:* fixed the issue of npm checking a registry and 404'ing
Steps

yarn in root dir
yarn watch in root dir
yarn native in root dir
yarn web in root dir

both native:ios and web compile and run w/o issue.

tests are failing, seems like it unrelated to the change (many PRs have failing tests)

I forgot to run yarn 🤦♂.

I'm ok with the change but want to know why it errored, because in the tamagui monorepo we don't use this pattern and it works totally well. Only time you see errors if is you haven't built I think, or if the version doesn't match.

Granted this isn't published anywhere so it can get away with the looser workspace:, so i'll merge.


fix: for potential nil response object from schematics

Description
Fixes a bug where the schematics SDK returns an error and also has a nil response object, so that the HTTP response code cannot be retrieved. Checking for nil was not previously implemented and would cause a golang panic.
Release required?

[ ] No release
[x] Patch release (x.x.X)
[ ] Minor release (x.X.x)
[ ] Major release (X.x.x)

Release notes content

Run the pipeline
If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.
Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:
/run pipeline

Checklist for reviewers

[ ] If relevant, a test for the change is included or updated with this PR.
[ ] If relevant, documentation for the change is included or updated with this PR.

For mergers

Use a conventional commit message to set the release level. Follow the guidelines.
Include information that users need to know about the PR in the commit message. The commit message becomes part of the GitHub release notes.
Use the Squash and merge option.

/run pipeline

:tada: This PR is included in version 1.38.4 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Re-Enable HTML data URLs

The current code blacklists text/html data URLs. They are very useful and there is no security problem with them because they execute in their own dom context. Can they be enabled again?

It is dangerous in Firefox. I'll disable it when it is not in escape option.

@lepture i cannot reproduce that. Firefox creates a new DOM context.


accelerate>0.19.0 not support multi-node training?

System Info
accelerate==0.21.0
transformers==4.35.0
torch==2.1.0
numpy==1.22.4
peft=0.6.2

"default_config.yaml":

compute_environment: LOCAL_MACHINE
distributed_type: MULTI_GPU
downcast_bf16: 'no'
main_process_ip: null
main_process_port: null
main_training_function: main
mixed_precision: bf16
num_machines: null
num_processes: null
# rdzv_backend: static  # 1 node
rdzv_backend: c10d # multi-nodes
same_network: true
tpu_env: []
tpu_use_cluster: false
tpu_use_sudo: false
use_cpu: false

Information

[ ] The official example scripts
[X] My own modified scripts

Tasks

[ ] One of the scripts in the examples/ folder of Accelerate or an officially supported no_trainer script in the examples folder of the transformers repo (such as run_no_trainer_glue.py)
[X] My own task or dataset (give details below)

Reproduction
MASTER_ADDR=xx.xx.xx.xx
MASTER_PORT=11332
JOB_ID=228
NNODES=2
GPUS_PER_NODE=8
WORLD_SIZE=$(($GPUS_PER_NODE*$NNODES))
DISTRIBUTED_ARGS="--num_machines $NNODES --num_processes $WORLD_SIZE --main_process_ip $MASTER_ADDR --main_process_port $MASTER_PORT"
MODEL_DIR=stable-diffusion-v1-5
OUTPUT_DIR=""
accelerate launch --config_file "text_to_image/default_config.yaml" $DISTRIBUTED_ARGS  --gpu_ids='all' --mixed_precision="bf16"
text_to_image/train_lcm_lora.py
--pretrained_teacher_model=$MODEL_DIR
--output_dir=$OUTPUT_DIR
--mixed_precision=bf16
--resolution=512
--learning_rate=1e-6 --loss_type="huber" --adam_weight_decay=0.0
--max_train_steps=1000000
--max_train_samples=4000000
--dataloader_num_workers=8
--validation_steps=200
--checkpointing_steps=1000 --checkpoints_total_limit=10
--train_batch_size=12
--gradient_checkpointing --enable_xformers_memory_efficient_attention
--gradient_accumulation_steps=1
--resume_from_checkpoint=latest
--report_to=tensorboard
--seed=453645634 \
Expected behavior
When NNODES>=2, the program does not run after executing the script, indicating a lack of communication between multiple machines.

If node=1, the program can run normally.
When accelerate==0.19.0 and transformers==4.26.1, the program can run normally and can be executed on multiple nodes when NNODES>=2.

Reset by peer means that the port you are trying to connect to isn't reachable between the machines. Ensure you've opened the port properly and each machine can ping each other

@muellerzr  thanks, I am sure that each machine can ping each other, and the port is ok.
If I downgrade the accelerate package to version 0.19.0 without making any other changes, the multi-node training can run smoothly.


mac-44 is dead.

Type of Request
bug
Infrastructure Environment
LUCI, Github, Cocoon scheduler, Autosubmit, etc...
What is happening?
mac-44 is dead.

Steps to reproduce
Step 1:
Step 2:
..
Step n:
Expected results
I expect to see X when Y is finished.

Ethernet port from network switch bad, moved network cable to different new port.


move temporary password from CI to secret

CI defines directly as an environment variable a temporary password for deploying Kubeflow.
This PR moves it to a secret, which has already been added to the repo.

Thanks @ca-scribner, LGTM. Your branch seems to have conflicts, do you mind resolving them so we can merge?


az webapp config appsettings set --settings from file path

i'm trying to use following command to update settings:
az webapp config appsettings set --name $app --settings "c:\my\full\path\to\appsetting.json"

and got bunch of py errors.
does this command support settings from any arbitrary json file other than @file-from-current-folder.json ? and if true, how to get this work?
please help. thank you

@rick-hayek I have another issue open just like this.
https://github.com/Azure/azure-cli/issues/11600

Yes this command does support passing a valid JSON to the --settings parameter. Can you validate that the JSON object you have in the json file I valid? if not share the settings you have in the file & I can help you investigate further. Thanks!

Hey @panchagnula please take a look at #11600 I believe @rick-hayek is basically having the same issue described in my issue. The problem seems to be when the JSON file in a different directory than the working directory of powershell. So if you attempt to use a path to the JSON, it fails. If the JSON file is referenced in the same path, everything works fine.

@ajklotz thanks for the update wanted to clarify something - are you using PowerShell to run these commands instead of Bash window? I have run these from different DIR than working DIR & has worked for me - I never used PowerShell for this though.

Yes, I'm using Powershell. @panchagnula

@ajklotz  thanks for confirming @rick-hayek is your issue also because of the use of PowerShell?

@rick-hayek @panchagnula My issue was closed. I was given a solution and it works using a relative path. I had to remove a slash after the @ symbol.
https://github.com/Azure/azure-cli/issues/11600#issuecomment-569865850

thanks for confirming @ajklotz . Closing this @rick-hayek please re-activate or file a new issue if this doesn't solve the issue you filed. Thanks!


When you choose Generate Report the date is not pulled from the time server

We have decided not to implement this. Thank you for the submission.


Reporting unused variable when it is used in clearTimeout

function bunction() {
    var hey = setTimeout(function(){alert("hey")}, 250);}
}
clearTimeout(hey)

JShint reports that "hey" is a unused variable, even though it's clearly used in clearTimeout.

It is not used: that variable isn't accessible outside of the bunction function

@nicolo-ribaudo has it right: JSHint is correctly detecting a variable that is not used.


GMP frontend becomes unresponsive ~once/week, probable memory leak?

I think GMP frontend has a memory leak?  Our GMP frontend pods become unresponsive about once per week, get connection errors/timeouts trying to call them.  Is fixed by us restarting the pods.  And also memory just rises steadily, and when we restart the pods, it drops:

Thanks for the report!  We are probably going to need a profile to figure out what the leak is. @pintohutch are there any other debugging steps we should take first

FWIW the frontend container is no longer recommended; we recommend using the datasource syncer method instead to authenticate to Grafana.

Thanks for reporting @yasha-spare. This is good to know.
For now, we are recommending people use the datasource-syncer, per the comment above.

Sounds good, will look into this, ty all!


DBZ-2794: No viable alternative at input 'optimize tables' on MySQL

optimize table is not documented but a valid mysql statement.

Contains https://github.com/debezium/debezium/pull/1978

Thx @ramanenka for the PR and also for the upstream antlr PR


feat: Groth16 Solidity contract with commitments

Description

This PR adds commitment verification to groth16 solidity verifier contract. Contract does not do foldings so uses first commitment for pairing check and uses sha256 hash as hash to field function. I added warning logs about these assumptions
Type of change

[x] New feature (non-breaking change which adds functionality)

How has this been tested?

[ ] Test case added under internal/backend/circuits/commit.go. Tests depends on changes at https://github.com/Consensys/gnark-solidity-checker/pull/2

How has this been benchmarked?

Checklist:

[x] I have performed a self-review of my code
[x] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[x] I have added tests that prove my fix is effective or that my feature works
[x] I did not modify files generated from templates
[x] golangci-lint does not output errors locally
[x] New and existing unit tests pass locally with my changes
[ ] Any dependent changes have been merged and published in downstream modules

@ivokub I tried to address some comments you left. Thanks for the review

I created new issues for tracking improvements: https://github.com/Consensys/gnark/issues/1094 and https://github.com/Consensys/gnark/issues/1095.


Configure routes

Description

Modularize all routes and export in controllers/index.js

Description

Ensure that all routes are working in insomnia


Fix comments on blender running instructions

Found two minor errors in comments I wrote about calling Blender. The comments weren't reflecting the exact syntax used in the code so I fixed the comments.

I see there's commit 379fd39 included in this pull request, where I brought my fork up to date with NASA's repo. Let me know if that would cause issues in accepting this pull request.

Hi, Nitzan! As we discussed in email, unfortunately, we realized we can't open source code that depends on the Blender Python API due to licensing issues. So we had to switch to a different texture repacking library (xatlas). Now that we've switched, these documentation updates are no longer needed. We do appreciate that you took the time to work on fixes even after the internship period was technically over. Hope your studies are going well!


[SPARK-8060] Improve DataFrame Python reader/writer interface doc and testing.

cc @davies

Merged build triggered.

Merged build started.

Test build #34044 has started for   PR 6601 at commit c9902fa.

Test build #34044 has finished for   PR 6601 at commit c9902fa.

This patch fails RAT tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Merged build triggered.

Merged build started.

Test build #34049 has started for   PR 6601 at commit f081d47.

Test build #34049 has finished for   PR 6601 at commit f081d47.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Merged build triggered.

Merged build started.

Test build #34064 has started for   PR 6601 at commit baa8ad5.

LGTM

Test build #34064 has finished for   PR 6601 at commit baa8ad5.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.


fix: revert "feat: rework trace (#1062)"

This reverts commit 47c4292b367a7c1dc920070eff194642a6b8db7b.
See #1067

The trace changes are improvements... I don't think reverting is the right move vs. addressing what's broken. @tjjfvi please prioritize #1067.


python3Packages.asysocks: 0.1.1 -> 0.1.2

Motivation for this change
Update to latest upstream release 0.1.2
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
21.11 Release Notes (or backporting 21.05 Relase notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 131430 run on x86_64-linux 1

14 packages built:

python38Packages.aiosmb
python38Packages.asysocks
python38Packages.lsassy
python38Packages.minikerberos
python38Packages.msldap
python38Packages.pypykatz
python38Packages.winsspi
python39Packages.aiosmb
python39Packages.asysocks
python39Packages.lsassy
python39Packages.minikerberos
python39Packages.msldap
python39Packages.pypykatz
python39Packages.winsspi


Should Vary be set to Set-Cookie instead of Cookie?

https://github.com/onatm/Owin.Antiforgery/blob/master/src/Owin.Antiforgery/AntiforgeryMiddleware.cs#L30

Hey @huysentruitw, do you think Vary should be Set-Cookie?


No hardware reset

Your code is great and well-structured. However, i couldnt get it to work with my TFT screen at first. Only after reading the datasheet did i realize that a hardware reset was missing i.e. making the RESET pin go low for at least 1ms. After this, and after i mapped my board pins correctly to your code, it worked, though the characters were reversed. Did your screen not require a hardware reset to work? Or perhaps you sent all unused pins low, eh?

I'll take a look at schematics to be sure, but I think, I have common hardware reset for controller and lcd (RC-chain that gives low nRESET signal until it charges). So, code works fine on devboard I have.
Also, there's required delay after writing 0x0001 to reg 0x00 (start osc) -- minimum 10ms, see http://www.densitron.com/uploadedFiles/Displays/Support/ILI9320DS_V0.51.pdf. AppNote (http://www.densitron.com/uploadedFiles/Displays/Support/ILI9320AN_V0.92.pdf) doesn't mention it at all. It can be a cause of some issues with this lcd controller.
If you have characters reversed take a look at these lines. 3 in 0x1030 means vertical and horizontal address increment when writting to GRAM. You have to change it to value depends on your display layout. Try 0x1020 at first. Also see page 55 of datasheet mentioned above.

thanks...i already fixed the 'reverse' problem by changing the register you mentioned and since my screen's origin is at the bottom left (unlike yours which is top left) and seems to be designed for landscape view, i had to swap the x, y positions in the arguments to your low-level functions o i could use it in landscape view. I'm currently trying to use SPI for it instead to save pins. I keep seeing IM[3:0] controller pins in the datasheet and i need to set them to 010x to use SPI. Unfortunately, i dont have access to the controller for the screen; i didnt even know the controller was 9328 until i tried your code and made it return the controller type. I get that all i have to change are the low-level functions to use SPI instead of the parallel mode, but i'm a bit hazy about how to initialize the LCD in this mode. Any suggestions would be appreciated.


[Bloc] Extract Element's visual properties in a separate object

In the following scene we have 748 elements, 419 of which have default visual properties. 329 elements have 1 to 3 visual properties that differ from the default.

BlElement has the following visual properties:
geometry border background outskirts effect visibility opacity clipChildren compositingMode focusability elevation focused mouseCursor most of which are never changed. Having all of them in BlElement increases the memory consumption of each BlElement and slows down element creation. We should extract them in a separate object and provide a a unique instance for the default visual properties.

After extraction the amount of inst.vars decreased from 29 to 18, size in memory from 240 to 152 and instantiation time reduced by ~30%


CrossViT does not handle other than three channel images

Code to reproduce error (adapted from the README)
import torch
from vit_pytorch.cross_vit import CrossViT

v = CrossViT(
    image_size = 256,
    num_classes = 1000,
    depth = 4,               # number of multi-scale encoding blocks
    sm_dim = 192,            # high res dimension
    sm_patch_size = 16,      # high res patch size (should be smaller than lg_patch_size)
    sm_enc_depth = 2,        # high res depth
    sm_enc_heads = 8,        # high res heads
    sm_enc_mlp_dim = 2048,   # high res feedforward dimension
    lg_dim = 384,            # low res dimension
    lg_patch_size = 64,      # low res patch size
    lg_enc_depth = 3,        # low res depth
    lg_enc_heads = 8,        # low res heads
    lg_enc_mlp_dim = 2048,   # low res feedforward dimensions
    cross_attn_depth = 2,    # cross attention rounds
    cross_attn_heads = 8,    # cross attention heads
    dropout = 0.1,
    emb_dropout = 0.1
)

img = torch.randn(1, 1, 256, 256)  # Using 1 channel
pred = v(img) # (1, 1000)

Traceback

Error

---------------------------------------------------------------------------
RuntimeError                              Traceback (most recent call last)
Cell In[27], line 26
      4 v = CrossViT(
      5     image_size = 256,
      6     num_classes = 1000,
   (...)
     21     emb_dropout = 0.1
     22 )
     24 img = torch.randn(1, 1, 256, 256)
---> 26 pred = v(img) # (1, 1000)

File /opt/conda/lib/python3.10/site-packages/torch/nn/modules/module.py:1518, in Module._wrapped_call_impl(self, *args, **kwargs)
   1516     return self._compiled_call_impl(*args, **kwargs)  # type: ignore[misc]
   1517 else:
-> 1518     return self._call_impl(*args, **kwargs)

File /opt/conda/lib/python3.10/site-packages/torch/nn/modules/module.py:1527, in Module._call_impl(self, *args, **kwargs)
   1522 # If we don't have any hooks, we want to skip the rest of the logic in
   1523 # this function, and just call forward.
   1524 if not (self._backward_hooks or self._backward_pre_hooks or self._forward_hooks or self._forward_pre_hooks
   1525         or _global_backward_pre_hooks or _global_backward_hooks
   1526         or _global_forward_hooks or _global_forward_pre_hooks):
-> 1527     return forward_call(*args, **kwargs)
   1529 try:
   1530     result = None

File /opt/conda/lib/python3.10/site-packages/vit_pytorch/cross_vit.py:258, in CrossViT.forward(self, img)
    257 def forward(self, img):
--> 258     sm_tokens = self.sm_image_embedder(img)
    259     lg_tokens = self.lg_image_embedder(img)
    261     sm_tokens, lg_tokens = self.multi_scale_encoder(sm_tokens, lg_tokens)

File /opt/conda/lib/python3.10/site-packages/torch/nn/modules/module.py:1518, in Module._wrapped_call_impl(self, *args, **kwargs)
   1516     return self._compiled_call_impl(*args, **kwargs)  # type: ignore[misc]
   1517 else:
-> 1518     return self._call_impl(*args, **kwargs)

File /opt/conda/lib/python3.10/site-packages/torch/nn/modules/module.py:1527, in Module._call_impl(self, *args, **kwargs)
   1522 # If we don't have any hooks, we want to skip the rest of the logic in
   1523 # this function, and just call forward.
   1524 if not (self._backward_hooks or self._backward_pre_hooks or self._forward_hooks or self._forward_pre_hooks
   1525         or _global_backward_pre_hooks or _global_backward_hooks
   1526         or _global_forward_hooks or _global_forward_pre_hooks):
-> 1527     return forward_call(*args, **kwargs)
   1529 try:
   1530     result = None

File /opt/conda/lib/python3.10/site-packages/vit_pytorch/cross_vit.py:192, in ImageEmbedder.forward(self, img)
    191 def forward(self, img):
--> 192     x = self.to_patch_embedding(img)
    193     b, n, _ = x.shape
    195     cls_tokens = repeat(self.cls_token, '() n d -> b n d', b = b)

File /opt/conda/lib/python3.10/site-packages/torch/nn/modules/module.py:1518, in Module._wrapped_call_impl(self, *args, **kwargs)
   1516     return self._compiled_call_impl(*args, **kwargs)  # type: ignore[misc]
   1517 else:
-> 1518     return self._call_impl(*args, **kwargs)

File /opt/conda/lib/python3.10/site-packages/torch/nn/modules/module.py:1527, in Module._call_impl(self, *args, **kwargs)
   1522 # If we don't have any hooks, we want to skip the rest of the logic in
   1523 # this function, and just call forward.
   1524 if not (self._backward_hooks or self._backward_pre_hooks or self._forward_hooks or self._forward_pre_hooks
   1525         or _global_backward_pre_hooks or _global_backward_hooks
   1526         or _global_forward_hooks or _global_forward_pre_hooks):
-> 1527     return forward_call(*args, **kwargs)
   1529 try:
   1530     result = None

File /opt/conda/lib/python3.10/site-packages/torch/nn/modules/container.py:215, in Sequential.forward(self, input)
    213 def forward(self, input):
    214     for module in self:
--> 215         input = module(input)
    216     return input

File /opt/conda/lib/python3.10/site-packages/torch/nn/modules/module.py:1518, in Module._wrapped_call_impl(self, *args, **kwargs)
   1516     return self._compiled_call_impl(*args, **kwargs)  # type: ignore[misc]
   1517 else:
-> 1518     return self._call_impl(*args, **kwargs)

File /opt/conda/lib/python3.10/site-packages/torch/nn/modules/module.py:1527, in Module._call_impl(self, *args, **kwargs)
   1522 # If we don't have any hooks, we want to skip the rest of the logic in
   1523 # this function, and just call forward.
   1524 if not (self._backward_hooks or self._backward_pre_hooks or self._forward_hooks or self._forward_pre_hooks
   1525         or _global_backward_pre_hooks or _global_backward_hooks
   1526         or _global_forward_hooks or _global_forward_pre_hooks):
-> 1527     return forward_call(*args, **kwargs)
   1529 try:
   1530     result = None

File /opt/conda/lib/python3.10/site-packages/torch/nn/modules/normalization.py:196, in LayerNorm.forward(self, input)
    195 def forward(self, input: Tensor) -> Tensor:
--> 196     return F.layer_norm(
    197         input, self.normalized_shape, self.weight, self.bias, self.eps)

File /opt/conda/lib/python3.10/site-packages/torch/nn/functional.py:2543, in layer_norm(input, normalized_shape, weight, bias, eps)
   2539 if has_torch_function_variadic(input, weight, bias):
   2540     return handle_torch_function(
   2541         layer_norm, (input, weight, bias), input, normalized_shape, weight=weight, bias=bias, eps=eps
   2542     )
-> 2543 return torch.layer_norm(input, normalized_shape, weight, bias, eps, torch.backends.cudnn.enabled)

RuntimeError: Given normalized_shape=[768], expected input with shape [*, 768], but got input of size[1, 256, 256]

Possible solution
Perhaps the only change required is to generalize the below line to handle any no, of channels, but not yet sure.
https://github.com/lucidrains/vit-pytorch/blob/5578ac472faf3903d4739ba783f3875b77177e57/vit_pytorch/cross_vit.py#L178

@Yash-10 hey Yash, thanks for your interest in the library
try adding channels = 1 on the latest version when instantiating CrossViT?

Hi @lucidrains, yes, it works now with any number of channels. Thanks for the fix and this great library! We can close this if you wish.


Adding docstring to weibull_min and weibull_max based on issue #10014

Added docstring about weibull_min and weibull_max based on   https://github.com/scipy/scipy/issues/10014.

I would suggest to expand the description, it should at least mention the extreme value theorem, the relation between weibull_min and _max and add references.

The issue was closed by #11527, closing this PR.


fix getattr bug

What does this PR do?
Fixes # (issue)
the config object is an instance of <class 'transformers.models.qwen2.configuration_qwen2.Qwen2Config'>.
When applying getattr(config, "architectures", []), it always returns a None, not []. Here we have to convert it into a dict to make getattr generate default result.
Before submitting

[ ] Did you read the contributor guideline?
[ ] Did you write any new necessary tests?

We cannot reproduce your results


Gun changes

Stuff I'm open to trying:

Damage mods on guns to separate them slightly more, though nothing significant. Will need a design doc backing it.

Armour-piercing ammo where it does less damage but goes through resistances (either all or some).

If anything i think we should be looking for ways to nerf guns. In most cases their TTK is so low that you are dead before you have a chance to react.
Bumping fire rates and decreasing damage sounds like an interesting change. Would reward those with better aim and strategy. If we also increase ammo to compensate it sounds like it would be more fun too. More shooting = more fun. More interaction with changing mags in mid fight as well!


docs: Better promote required components link

We shouldn't assume new developers need to install the UWP workload anymore when building Windows App SDK apps. The current wording heavily implies that the UWP workload is somehow required to build Windows App SDK applications. This is also inconsistent with the other Windows App SDK documentation.
We now link to that documentation instead and tidy up bullet point punctuation

@lukeblevins : Thanks for your contribution! The author(s) have been notified to review your proposed change. @whims

Tagging @stevewhims and @asklar

@lukeblevins : Thanks for your contribution! The author(s) have been notified to review your proposed change. @whims

@lukeblevins : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@asklar It seems the author username was incorrect, so I went ahead and updated that too.


Update readme

Moves the development instructions to DEVELOPMENT.md updates the readme to include installation and usage instructions.

I added everyone to review in case there is anything glaringly wrong or missing

@marySalvi This content looks good. I've just pushed an additional commit to clean up the style a bit more, to make it publication quality.


Run examples on CI

In the future, we probably want a Real Way™ to run tests and give them input automatically without adding them to the run-examples.swift file.

definitely! I just wanted something we can use to quickly sanity-check changes. and maybe so CI can be useful?

Do we have to explicitly link libdispatch or something? I have no idea why this is working locally but failing on CI

This is now passing on CI!

Then are we good to merge????

Yup!


Voting

Hi,
is it possible that Up and Downvoting is currently not working?
The API seems to be unable to locate the Post:
(200, {'post': None, 'vote_count': 0})
When I´m getting the details of the jodel specified everything seems to be working

Yep, I see this behaviour for new accounts. Voting is still working on all my old ones though. So maybe new accounts are only able to vote after a certain time.
Btw:

(200, {'post': None, 'vote_count': 0})

This is the usual answer, if you've already voted on a post, or if the post doesn't exist anymore.

Good to know, thanks man ;)
Might be possible that they created a minimum amount of karma and/or a time limit.
One of my accounts created yesterday got about 2500 karma and is working pretty good.


Error Edge-case

Background: We are currently running PyTerraBackTyl with the git backend, using Atlantis as a front end.
There appears to be an edge-case where we are hitting your error message here:
https://github.com/dev-dull/PyTerraBackTyl/blob/025a73c90ea55b4be2626060e0e5369aaa34ba1a/pyterrabacktyl.py#L55-L58
My testing shows that usually what happens in that PyTerraBackTyl has the specific project LOCKED in its own internal memory, but the git repo that PyTerra saves state into has the project unlocked. I'm not sure yet what causes this mismatch, but a service restart is usually enough to correct the issue (hence why my thinking it's saved in memory incorrectly).
It also seems that when PyTerra is trying to write the git commit message, it can fail on the defaultdict portion of this line:
https://github.com/dev-dull/PyTerraBackTyl/blob/025a73c90ea55b4be2626060e0e5369aaa34ba1a/backends/git_backend.py#L87
It gives a KeyError against Who, with our GIT_COMMIT_MESSAGE_FORMAT set to "{Who}, {Operation} - {ID}". I'm not sure if this is something that's also saved in memory and is perhaps also getting messed up, or if it's entirely unrelated to the LOCKED/UNLOCKED issue.
I will submit shortly a PR shortly that makes the error referenced first in this issue a bit more descriptive.

Actually, I have one of our projects that is currently in this exact error state right now.
Terraform attempts to call PyTerraBackTyl via a LOCK request to /lock?env=repo-name_project-name, and PyTerra returns a HTTP 423 with your Something is really fucked` response, and terraform informs the user that it is already locked.
Looking at the git backend's committed code, it's not locked. Looking on-server in /opt/pyterrabacktyl/data/repo-name_project-name, it's not LOCKED.
Running curl -X LOCK http://localhost:2442/lock?env=repo-name_project-name gives me the error I don't know, man.  If i run an UNLOCK against the unlock endpoint for the same env, it gives the same issue. So at this point I can neither lock or unlock via curl.
Restarting the service is confirmed to fix the issue. As soon as it's restarted I can run terraform and it correctly determines it to be unlocked.

Hey Josh, I've got a guess on what's happening here and I believe this is related to Issue #36. What is GIT_WORKING_PATH set to in config.yaml? If it is set to the default of null (None) or the setting is commented out (again, defaulting the value to None), then PyTerraBackTYL is using an OS temporary directory. I've ran into cases where OSes are good at leaving things untouched there, but I've also ran into cases where the OS will "clean up" files that git is expecting to be present causing commits to fail.
Next time you run into this issue, navigate or curl /state endpoint on your PyTerraBackTYL instance. In there, you should be able to find the temporary directory being used for the repo/branch where you can perform a git status and discover if any files are missing that should be present.
The work-arounds are to do scheduled restarts of the service, or to set GIT_WORKING_PATH to a specific path (I have been using /opt/pyterrabacktyl/data or /opt/pyterrabacktyl/PyTerraBackTyl/data on my instances).
side notes: I've got a mild cold atm and I'm notorious for misreading things when I'm not 100%, so let me know if I've wildly misunderstood the issue here.

We're using /opt/pyterrabacktyl/data for the GIT_WORKING_PATH, with the application residing in /opt/pyterrabacktyl/PyTerraBackTyl.

Hm. Very strange. Do you happen to know if you're getting a lock state of INIT, or lock state of LOCKED?
What version of terraform are you using? My company refuses to budge from 0.11.x, so if you're using 0.12, we might be running into an unexpected compatibility issue.
Also, just a quick note to mention that I just did a PR to correct a 'c' to a 'C' on line 61 of pyterrabacktyl.py

I haven't been able to get the expected lock state yet, I'm waiting for the next time it happens to see what gets output in the debug logging.
We're currently running 0.12.8, though we've also had this issue on 0.12.5 I believe.

While we wait for the bad state to show up again, could you double check the following for me? Given the symptoms, I don't expect any will be the case, but I thought of couple scenarios that might cause one or more of the below.

Take a look at the branch names and double check that they all have the expected names (no typo'd doup).
grep the logs for a warnings that looks like:

'Failed to release lock for ENV %s, already unlocked'
'Failed to obtain lock for ENV %s, already locked: %s'

Take a look at the directory names in /opt/pyterrabacktyl/data and double check that there's nothing strange going on there (e.g. a directory with a name that starts or ends with a space)

Sorry for the late response, I was out of the office and away from my computer for almost 2 weeks.
To respond to your questions:

There are no obvious branch name issues, but we have more than 400 branches so it's difficult to check every character of every branch.
We output all logs to journalctl, but I can find no instance of the string "Failed to" in the logs.
None that I can see. Names are all generated programatically as {repo-name}_{atlantis project name} so that shouldn't be an issue.
The call looks like this in our running version of PyTerra: backend_service.run(host=C.BACKEND_SERVICE_IP, port=C.BACKEND_SERVICE_PORT, ssl_context=ssl_context)

We're running into this issue again. It looks like sometime yesterday a build didn't quite finish properly (not a PyTerraBackTyl issue). So within the actual git repo for the branch (we'll call it dc-abc_user-project) the LOCKED file still exists even though the terraform job is long done.
The local git repo at /opt/pyterrabacktyl/data/dc-abc_user-project/ shows the LOCKED file is present, and that the local repo has not diverged from the remote repo in Bitbucket.
Interestingly, when I attempt to manually unlock the file (via curl command), debugging code shows:
Oct 23 11:58:20 us01vltrrfrm003 pyterrabacktyl[1322]: 2019-10-23 11:58:20,547 - root - INFO - Memory state: INIT
Oct 23 11:58:20 us01vltrrfrm003 pyterrabacktyl[1322]: 2019-10-23 11:58:20,547 - root - INFO - Accepted states: ['LOCKED', 'INIT']
Oct 23 11:58:20 us01vltrrfrm003 pyterrabacktyl[1322]: 2019-10-23 11:58:20,547 - root - INFO - Old State: INIT
Oct 23 11:58:20 us01vltrrfrm003 pyterrabacktyl[1322]: 2019-10-23 11:58:20,547 - root - INFO - New State: UNLOCKED
...
Oct 23 11:58:20 us01vltrrfrm003 pyterrabacktyl[1322]: 2019-10-23 11:58:20,914 - root - DEBUG - Lock state set to UNLOCKED

So i'm not sure why PyTerraBackTyl thought that the repo was INIT, since by all accounts it was locked. The curl call to UNLOCK did unlock it, and it's functional again.

So after spending quite a bit of thought on this, I think some additional logging might shed some more insight on this problem. I'll try to make some additions to the code sometime this week.

Log what happens with request.data.decode() or '{}' (line 46 of _set_lock_state) which could be failing and leaving us stuck in an INIT lock state (although I would expect such an unhandled exception to be automatically logged).
json.loads(lock_text) (line 47 of _set_lock_state) could be failing and leaving us in an INIT lock state (this would indicate a bug with Terraform, I would expect this error would automatically be logged).
Better logging around what the GitPython library is seeing (exit code an any output messages); the library depends on the local installation of git on the host and if the program exits with a status code of 0 even though it encountered an error, it may be telling us that it successfully unlocked when no action has actually happened.

Hi Josh,
I just commited some changes to the 'beta' branch that should help us pin down the exact cause here. Just a heads up that this also includes changes that should fix some of the output issues with the PyTerraBackTYL /state endpoint as well as the Slack post-processor.
FYI, I was unable to get the .decode() function (as outlined in my first bullet point in my previous) to fail on a binary string, so I skipped adding any additional error handling/logging there.

Closing due to age


Revert to building the project using JDK 18

Gradle doesn't support JDK 19 yet, which seems to be the cause of the build error.
This mirrors https://github.com/avisi-cloud/structurizr-site-generatr/commit/bc857e9df623c741fad576a486d1afcb2061dfaf but now also for the release workflow.

Sorry for the noise, this PR contains the opposite of what I wanted to do ;)
Superseded by next PR.


Set app's name and icon for the launcher

Fixes #390.
The launch icons are lightly adapted from what we have in zulip-mobile for debug builds, along the lines described in #390: they're the Zulip logo like we use for the main app, plus a red banner reading "BETA".
This design isn't beautiful, and I'd love something better. (I'll file a follow-up issue for that. → #415) It hasn't really mattered for a debug-only thing that only us who are working on the app ever see, but will matter more for the beta. But this will be good enough for Beta 1, which the status quo wouldn't so much be.
The script that generates them is also lightly adapted from the tools/generate-logos in zulip-mobile.
We also edit the user-facing name of the app, in hopefully all the remaining places: it's now "Zulip beta" for Android and iOS (where we currently plan to distribute to users in general, so that there's a risk of confusion if we just said "Zulip"), and just "Zulip" on the miscellaneous other platforms.

Cool, thanks! Merged.


Improve load times on slow connections

The load time is far too slow when testing with a throttled connection, up to minutes before first paint.
Individual load times for VRM assets is also slow.
Proposed improvements

[ ] https://github.com/webaverse-studios/CharacterCreator/issues/267
[ ] https://github.com/webaverse-studios/CharacterCreator/issues/268
[ ] https://github.com/webaverse-studios/CharacterCreator/issues/269

Resulting files could be 5x smaller too by using sparse accessors properly:

[ ] https://github.com/webaverse-studios/CharacterCreator/issues/378


Quake mode doesn't preserve window size nor position when minimize to tray is enabled

Basically what title says, I'm using latest release (0.40.0) on Windows 1809

Related to #120

I'm not sure if I should comment on this or open new issue but it's heavily related:
currently it may seem that maximized size is preserved but actually restored size is shown first and only then maximized back, it's clearly visible if full terminal app is running as it renders in smaller size first and then accommodates to maximized window

I tried that out today on Windows and it seemed fine. I'll test it a bit more and also try out Linux/macOS. thanks


Cannot resolve symbols

I added this lib to build.gradle of app by your guideline like the attached below:

Now only it recognize uz.paycom.payment.PaymentActivity of all imports which is required to implementation.
Because the lib doesn't expose constants like EXTRA_AMOUNT, EXTRA_LANG and EXTRA_RESULT, there are errors like the attached below:

And also there is no model, utils in the payment lib like the attached below:

@JeongJun-Lee This has been fixed in #5


Consider using ManifestStaticFilesStorage to avoid having old assets (CSS, JS) cached by clients

It's not the first time I had to hard refresh my browser after an update. This can be confusing and annoying for end-users.
ManifestStaticFilesStorage exists just for that, we should check if it works fine with our own npm-based assets management.
See https://docs.djangoproject.com/en/4.0/ref/contrib/staticfiles/#django.contrib.staticfiles.storage.ManifestStaticFilesStorage

There are issues when running tests with this settings: see https://stackoverflow.com/a/51060143


Add note on installing latest pyhon-driver for Cassandra 3.x

Had to spend some time to figure out why tests failed with an NoHostAvailable: "unconfigured table schema_keyspaces" with Cassandra 3. Looks like you need to use the latest python driver alpha release to make the tests work. Would be nice to have that actually documented somewhere.

For now actually, the cassandra-test branch of the python-driver is the most up to date. @mambocab should we document that, or leave @spodkowinski's changes?

Good question. My initial reaction is to document using the cassandra-test branch, since it was branched off for the dtest use case. I don't know what kinds of guarantees we have w.r.t. that branch sticking around forever/being the most up-to-date version forever, though.
Would it be reasonable to document the cassandra-test branch as a first choice and --pre as a fallback?

+1 to that. Furthermore, once 3.0 goes GA, the appropriate driver version should go GA, and we shouldn't have this issue again, given the pace of tick-tock.

Added some changes on top of this and filed as #598; discussion should move there.


Move pg_stat_statements query jumbling to core

Moving of jumbling logic to core part gives the opportunity to reuse this logic in extensions without code duplication. This patch is a partial backport of https://github.com/postgres/postgres/commit/5fd9dfa5f50e4906c35133a414ebec5b6d518493
The differences between this patch and the original one are:

add release of JumbleState memory;
there is no compute_query_id GUC;
queryId computation algorithm is not changed, so the CleanQuerytext() function and the querytext argument of JumbleQuery() are not created;
the JumbleQuery() function is called from pg_stat_statements.c, so no changes to the hook arguments are required.

The original patch author is Julien Rouhaud, its reviewers are Alvaro Herrera, Nitin Jadhav and Zhihong Yu.
(cherry picked from commit f7ff7c8)

This is not a pure backport, as structs and functions moved from pg_stat_statements.c were changed. However, the main idea is the same - move some extension functions to core.


v2.0.5 create file returns AUTORENEW_DURATION_NOT_IN_RANGE

const transaction12 = await new FileCreateTransaction()
    .setKeys([accountPublicKey]) //A different key then the client operator key
    .setContents("the file contents")
    .setMaxTransactionFee(new Hbar(2))
    .freezeWith(client);

const signTx12 = await transaction12.sign(accountKey);

const submitTx12 = await signTx12.execute(client);

const receipt12 = await submitTx12.getReceipt(client);

const newFileId = receipt12.fileId;

console.log("The new file ID is: " + newFileId);

Error:
(node:95935) UnhandledPromiseRejectionWarning: StatusError: transaction<EMAIL_ADDRESS>failed precheck with status AUTORENEW_DURATION_NOT_IN_RANGE
    at new PrecheckStatusError (/Users/simihunjan/Desktop/JS2.0.4/node_modules/@hashgraph/sdk/lib/PrecheckStatusError.cjs:23:5)
    at FileCreateTransaction.execute (/Users/simihunjan/Desktop/JS2.0.4/node_modules/@hashgraph/sdk/lib/Executable.cjs:210:15)
    at processTicksAndRejections (internal/process/next_tick.js:81:5)
(node:95935) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). (rejection id: 1)
(node:95935) [DEP0018] DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js process with a non-zero exit code.
Simis-MacBook-Pro-2:JS2.0.4 simihunjan$

Confirmed working in v2.0.7. Thank you!


Just a thought

It would be neat in a future release to update Lifecyle to be a kotlin sealed class which would allow the CREATE event to contain a nullable bundle.

You might want to check out https://github.com/trello/navi.

Oh cool thanks


ImageCache not accepting options array...or so it seems.

Hi there!
Thanks for the awesome package; Image works very well for me.The problem I am having is with ImageCache. I don't use Laravel, though it seems that IC should work without it -- am I mistaken?
What I think should happen is that IC should check if the processed image is currently stored in cache and then process the input if not. Then, return a link to the cached item.
Am I mistaken? Any assistance would be greatly appreciated!
This is the code I am working with currently.
  use Intervention\Image\ImageCache as IC;
  use Intervention\Image\ImageManager as IM;

  function wm($rel_path_to_image) {
      global $install_path;

      $imgPath = $install_path . $rel_path_to_image;
      $watermarkPath = $install_path . "assets/img/watermark.png";

      $manager = new IM(array('driver' => 'imagick'));
      //
      $cacher  = new IC();

      $img = $cacher->cache(function($manager) use ($imgPath,$watermarkPath) {
          $manager->make($imgPath)
                  ->insert($manager->make($watermarkPath)->rotate(45), 'center');
      },10, true);

  }

Yes, it works without Laravel. If you want customize your storage settings, you have to pass a Illuminate\Cache\Repository to the ImageCache instance. See constructor.
The return value of the cache() method is either the raw image data or an Intervention Image object.

Thanks for the response @olivervogel . I'm gonna try that now and report back later.

Hey @olivervogel
Sorry about all the postings.
I finally got Image and ImageCache creating cache files (got some help from some of your answers to older questions)! The problem though is that the cache folder is being populated by what seems to be corrupted image files. These files are created without extensions. I did try manually adding an extension, but that did not help (cache files are still corrupt).
Thoughts appreciated.
use Intervention\Image\ImageManager as ImageManager;
use Illuminate\Filesystem\Filesystem as FileSystem;
use Illuminate\Cache\FileStore as FileStore;
use Illuminate\Cache\Repository as Repository;
use Intervention\Image\ImageCache as ImageCache;

function wm($rel_path_to_image) {
    global $install_path;

    //
    $imgPath = $install_path . $rel_path_to_image;
    $watermarkPath = $install_path . "assets/img/watermark.png";
    $cachePath = $install_path . "cache";

    //
    $manager = new ImageManager(array("driver" => "imagick"));

    $filestore = new FileStore(
        new Filesystem(),
        $install_path . "cache");

    $repository = new Repository($filestore);
    $cache = new ImageCache($manager,$repository);

    $cache->lifetime = 10;

    $watermarkedImage = $cache->make($imgPath)->get(0,true);

}

No, the files in the cache folder are not corrupted images. The are just fine. The cache storage just works this way, storing every data (no matter what it is) in a file. I think you are misunderstanding the concept of the ImageCache. You don't have to pay attention to any filenames.  If this actions has been executed already and the result is in cache, the image data comes directly from cache and any performance intensive GD or Imagick processing is skipped.

@paxperscientiam Thanks for the code!
what are those parameters for ->get()?
$watermarkedImage = $cache->make($imgPath)->get(0,true);


re-edit text

hello
re-edit text

[x] Have you followed the contributing guidelines?
[x] Have you explained what your changes do, and why they add value to the Guides?

Please note: we will close your PR without comment if you do not check the boxes above and provide ALL requested information.

Thanks again @ciminbinazadeh!

Thanks again @ciminbinazadeh!

🙏🏻🙏🏻🙏🏻🌸


[Bug]: bcr presubmit is red on windows

What happened?
(23:01:44) ERROR: An error occurred during the fetch of repository 'aspect_rules_esbuild~override~esbuild~esbuild_windows-x64':
| Traceback (most recent call last):
  | File "C:/b/nvszoz5g/external/aspect_rules_esbuild~override/esbuild/repositories.bzl", line 24, column 24, in _esbuild_repo_impl
  | integrity = esbuild[repository_ctx.attr.platform]
  | Error: key "windows-x64" not found in dictionary
Version
0.14.0
How to reproduce
https://buildkite.com/bazel/bcr-presubmit/builds/942#0185e0c6-425b-4dba-8e22-d7bf64593a3e

Any other information?
No response
Fund our work

[ ] Sponsor our open source work by donating a bug bounty

Windows is here now https://github.com/bazelbuild/bazel-central-registry/blob/main/modules/aspect_rules_esbuild/0.14.4/presubmit.yml#L4


Update k8s registry references

Describe the feature

Per https://github.com/kubernetes/k8s.io/issues/4780, Kubernetes is migrating its image registry to registry.k8s.io, and this repository is impacted.
We have to update the references of k8s.gcr.io to registry.k8s.io by April 3rd to remain up-to-date.
Here's a quick search for k8s.gcr.io on this repo. [search result]. Note that there may be other valid references (like, in the form of generated code, etc) which we have to be aware of.
Release Note

RELEASE NOTE:

Update k8s registry from k8s.gcr.io to registry.k8s.io

@yaron2 can you PTAL?


Temporarily disable "validation errors no longer occur" warnings

Removes annoying warnings while we figure out https://github.com/godotengine/godot/issues/95858

Thanks!