GPII-1675:  Initial implementation of gpii-location-bar-relay....

See GPII-1675 for details.

@amb26, as you may already have testem installed for use with infusion, I wanted to point out that the tests in this package require a new enough version of testem to allow multiple test pages.  I used 1.5.0.

From a chat yesterday:
@amb26 > Your tests are execrable though
@the-t-in-rtf > you mean all the timeouts?
@the-t-in-rtf > I put a note there to talk about it with you.
@amb26 > yes
@amb26 > Plus the mere fact it is written 5 closures deep
@the-t-in-rtf > Can we use Fluid IoC tests on the client side?
@amb26 > Yes
@amb26 > As its own test cases demonstrate
After some digging, the DataBinding tests helped me figure out the necessary client-side dependencies.
I made a first pass at converting the navigation tests, which had the most nesting.  The first test (going back once) is fine, but I am encountering problems with going back, then forward in the second test.  Committing the work in progress for our next pairing session.  You can see the error by launching testem and then opening this page, but with your own port and testem ID:
http://localhost://tests/static/tests-locationBar-navigation.html

In our recent discussion, we have agreed that this back and forth navigation can only reasonably be tested with something like Nightmare.  The remaining tests can be tested with testem and QUnit.

Anything that uses "back" is problematic, it seems like we also need to convert the "simple" navigation tests.  Given that only the initial query parsing can be safely tested using QUnit and testem, this should be converted to use Nightmare.

I have converted all tests to use gpii-test-browser and stripped out cruft from the previous approach.


Prevent reparsing of function parameters socket in JavaScript mode

From @dabbler0:

I think the best way to fix this bug would be to set a flag on that parameter socket saying always to bubble up reparses to its parent (never reparse it by itself). In javascript.coffee, set the flag on that socket through the "parseContext" property of the socket (make it something like "NO_REPARSE"). Then, in Editor::reparse in controller.coffee, look for that value of "parseContext", and always bubble up when you see it.

Sockets didn't have a parseContext so I added it to the model and to @addSocket.  When parseContext == 'NO_REPARSE' the reparse of the socket contents is skipped, and the parent is reparsed as a whole.
'NO_REPARSE' context is set for the JavaScript FunctionDeclaration parameters socket.

I need to fix the unit test.
The other part I don't fully understand is why reparsing the parent succeeded before when the socket is wrapped in parentheses.  The following should fail to reparse (triggering a fallback to originalText), but doesn't:
function ((a)) {}

See https://github.com/droplet-editor/droplet/pull/131 for a better root-cause fix.  Closing this PR.


Possibility to control (activate) scenes?

Is there a possibility to activate the scenes created in the Tradfri app through tradfri-mqtt?
They are under mqtt-topic "tradfri-raw/15005". I have an example from my home "tradfri-raw/15005/131073/196608". This turns off all lighting in one room (group).

It should be possible to send something like this:
{
  "method": "put",
  "url": "15005/131073",
  "payload": {
    "5850": 1,
    "9039": 196608
  }
}

I have tried this but it doesn't give any response. I have also tried to add a reply url but no reply.
I tried:
{
"method": "put",
"url": "15005/131073",
"payload": {
"5850": 1,
"9039": 196608
}
}
on topic: tradfri-cmd

sorry, the url should be 15004/131073, not 15005/...

And thats works. Thanks for the help.


How can I improve face recognition accuracy

Sir, how can I improve the accuracy of the faces being recognized. My dataset contains only 5 images of people in masks and 5 images of the same people without mask. When I run the program people are recognized by a different name. I trained the program with the same Mask_Data as yours. Should I add my dataset as well into the dataset for training?
Originally posted by @JonJoy in https://github.com/MohamedMohana/Face-Mask-Detection-and-Recognition/issues/2#issuecomment-1129567755

Fine images are not enough. Add as much as you can of data.

Ok thanks

May I know how many images you used for your dataset? Because now I increased the number of images to 60 total with and without mask but still it isn't accurate.


WER-01-001 Crypto: Minor improvements to key derivation logic (Low)

From Cure53 audit:
WEaR’s key derivation logic employs PBKDF2 in order to generate credential keys. The passphrase input of PBKDF2 is calculated by concatenating the user’s username and password together with a null byte as a separator.
While this is not likely to be the source of any problems, it may be sounder to fully separate the input of the username and the password instead. It would be advisable to avoid the use of an arbitrary concatenation byte.
The proposed change may be accomplished by concatenating the username as part of the PBKDF2 salt instead of part of the PBKDF2 passphrase. The password (or an unkeyed hash of the password) could simply be used as the basis for the PBKDF2
passphrase.
Affected file: src/keyGen.ts

Fixed in 1.0.0.


Added tasks 177-180

@Mihir3009, wondering if you can help reviewing this task?

General Comments:

Keep the category at the end of the filename.
For example:
task177_xlwic_true_or_false_answer_generation

The name of task-178 does not include the name of the dataset, add that.

Include a separator between different elements of the input.
For example:
Word: dust \n Sentence1: Another one bites the dust. \n Sentence2: The maid used a handkerchief to remove dust off the table.
Do these for all 4 tasks, if there is more than 1 element in the input.

Include dataset link the source field, like this
XL-WiC (Dataset - Link)

In the README, don't need to mention (based on XL-WiC).

Task-178:

In the definition, write that

You should respond with a valid sentence that contains the given word.

Task-179:

In the definition, instead of writing insect and vert in the bracket change it something like this -

For example, if the given sentence refers to a 'fly' as the insect, you should not respond with a sentence that uses 'fly' as the verb.
or change accordingly.

Here,

For example, you may use the word 'ended' in a sentence where the given word is 'end'.
change it something like this -
For example, you can use the word 'ended' in the output where the given input word is 'end'.
The above sounds a bit clear.
(Apply this change to Task-178 and 180 also)

Correct the summary in the README:
Instead of generating sentences, write a sentence (because there is only 1 sentence will be generated in the output) and instead of the original sentence, write an input sentence
(Apply this change to Task180 as well )

Task-180:

In the definition, mention clearly that if the output sentence with a different context than the input sentence is allowed or not because the below sentence indicates that it is allowed.

You should respond with a valid sentence which contains the word used with a different meaning than in the given sentence. For example, if the given sentence refers to a 'fly' (the insect), you may respond with a sentence which uses 'fly' (the verb).

In the examples, instead of writing the first sentence, latter sentence or both sentences, write the input sentence and output.

Change category to "Sentence Generation" for the task 178-180. Change Readme accordingly.
Update Readme:

For Task 177 - write this as a summary:
Determine whether both the sentences use the aforementioned word with the same meaning
For Task 177 - remove '_' from the category (currently you have written Answer_Genertion (see there))

Please update.

Looks good to me now.

Your HW2 is complete.
Would you like to submit the same tasks to our big project repo https://github.com/allenai/natural-instructions-expansion/pulls? You just need to fork that repo, rename tasks starting from the latest number in the repo (which at this point is 591) and create PR there. This way, you can be part of our research on "learning from instructions instead of learning from examples (conventional machine learning)". This is purely optional and your HW2 grade does not depend on this @ananth-duggirala ?

Just saw your comment. I'll add it to the repo.


[plugins.json] Add cocoapods-mix-frameworks

Please add the following entry to the plugins.json file:
{
  "gem": "cocoapods-mix-frameworks",
  "name": "CocoaPods Mix Frameworks",
  "author": "Florent Vilmart",
  "url": "https://github.com/flovilmart/cocoapods-mix-frameworks",
  "description": "Mix use_framework! targets with static targets through a surrogate Framework target."
}

👍 wanna PR this to https://github.com/CocoaPods/cocoapods-plugins/blob/master/plugins.json and I'll merge it

@orta thanks! Closing


Proposal: Add translated list or contribution note about translation

I know it won't be a big interest for you but this doc has a lot of demands across the world and it is not only for those who understand English.
As one of the people who translated this doc into another language, it'd be nice to be able to see if this is already available in one's language or not.
I hope you add a list of multiple languages at the bottom of README.md, but if it's not your bussiness, at least adding what you should do when you want to translate this doc in CONTRIBUTING.md would be nicer 🙏

This is a good idea. I need to think through how to ensure those translations are of quality and i'm not linking to something I would not approve of.

And it is also difficult to keep translations up2date.

IMHO, it’s not necessarily important to keep it up to date. It is much more to important that you can know which one is the best maintained and where to contribute if necessary.


[Question] Can one also extract the segmentations?

:question: Segmentation outputs available?
Does the model outputs also the learned segmentations? or the anchor boxes only?
I do not see the segmentations in the outputs.
Thanks :)

Dear @dalbis ,
it is theoretically possible to export the learned segmentations (during inference) as well but this is considered a highly experimental feature since we neither evaluated nor tested it ->  i.e. it is not supported officially. Nevertheless, the segmentations will be exported by nndet_predict by passing +inference_kwargs.do_seg=True.
Best,
Michael

Hi,
Dear @mibaumgartner,
Thanks a lot for your reply. I have tried the option suggested and I often got out sensible segmentations. However in some cases the code crashes because there is a problem of dimensions. I noted that this happens only when also the warning WARNING Found patch size which is bigger than data is issued. So maybe there is a problem with the padding. I understand that this feature is not tested/supported, but in case you have any clue how to solve it I would appreciate :)
Thanks a gain.
Tiziano
INFO Predicting case 1 of 1. WARNING This feature (SegmentationEnsembler.__init__) is experimental! It might not implement all features or is only a simplification! WARNING Found patch size which is bigger than data: data (18, 92, 123) patch [ 20 112 112] WARNING Path size is bigger than whole case, padding case to match patch size WARNING Path size is bigger than whole case, padding case to match patch size WARNING Path size is bigger than whole case, padding case to match patch size INFO Predicting model 1 of 5 with weight 1.0. Transform:   0%|          | 0/8 [00:00<?, ?INFO Creating new gaussian weight matrix for crop size (20, 112, 112) Crop:   0%|          | 0/1 [00:05<?, ?it/s] Transform:   0%|          | 0/8 [00:05<?, ?it/s] Traceback (most recent call last):   File "/opt/conda/bin/nndet_predict", line 33, in <module>     sys.exit(load_entry_point('nndet', 'console_scripts', 'nndet_predict')())   File "/opt/code/nndet/nndet/utils/check.py", line 58, in wrapper     return func(*args, **kwargs)   File "/opt/code/nndet/scripts/predict.py", line 231, in main     run(OmegaConf.to_container(cfg, resolve=True),   File "/opt/code/nndet/scripts/predict.py", line 91, in run     predict_dir(source_dir=source_dir,   File "/opt/code/nndet/nndet/inference/helper.py", line 103, in predict_dir     result = predictor.predict_case({"data": case},   File "/opt/code/nndet/nndet/inference/predictor.py", line 177, in predict_case     self.predict_tiles(tiles)   File "/opt/conda/lib/python3.8/site-packages/torch/autograd/grad_mode.py", line 26, in decorate_context     return func(*args, **kwargs)   File "/opt/code/nndet/nndet/inference/predictor.py", line 267, in predict_tiles     self.predict_with_transformation(   File "/opt/code/nndet/nndet/inference/predictor.py", line 313, in predict_with_transformation     ensembler.process_batch(result=result, batch=batch)   File "/opt/conda/lib/python3.8/site-packages/torch/autograd/grad_mode.py", line 26, in decorate_context     return func(*args, **kwargs)   File "/opt/code/nndet/nndet/inference/ensembler/segmentation.py", line 176, in process_batch     self.model_results[case_crop] += seg RuntimeError: The size of tensor a (61) must match the size of tensor b (112) at non-singleton dimension 3

inference_kwargs

Generate seg.pkl split file. What are the instructions you use? Thank you very much

Hi, Dear @mibaumgartner,
Thanks a lot for your reply. I have tried the option suggested and I often got out sensible segmentations. However in some cases the code crashes because there is a problem of dimensions. I noted that this happens only when also the warning WARNING Found patch size which is bigger than data is issued. So maybe there is a problem with the padding. I understand that this feature is not tested/supported, but in case you have any clue how to solve it I would appreciate :)
Thanks a gain. Tiziano
INFO Predicting case 1 of 1. WARNING This feature (SegmentationEnsembler.__init__) is experimental! It might not implement all features or is only a simplification! WARNING Found patch size which is bigger than data: data (18, 92, 123) patch [ 20 112 112] WARNING Path size is bigger than whole case, padding case to match patch size WARNING Path size is bigger than whole case, padding case to match patch size WARNING Path size is bigger than whole case, padding case to match patch size INFO Predicting model 1 of 5 with weight 1.0. Transform: 0%| | 0/8 [00:00<?, ?INFO Creating new gaussian weight matrix for crop size (20, 112, 112) Crop: 0%| | 0/1 [00:05<?, ?it/s] Transform: 0%| | 0/8 [00:05<?, ?it/s] Traceback (most recent call last): File "/opt/conda/bin/nndet_predict", line 33, in <module> sys.exit(load_entry_point('nndet', 'console_scripts', 'nndet_predict')()) File "/opt/code/nndet/nndet/utils/check.py", line 58, in wrapper return func(*args, **kwargs) File "/opt/code/nndet/scripts/predict.py", line 231, in main run(OmegaConf.to_container(cfg, resolve=True), File "/opt/code/nndet/scripts/predict.py", line 91, in run predict_dir(source_dir=source_dir, File "/opt/code/nndet/nndet/inference/helper.py", line 103, in predict_dir result = predictor.predict_case({"data": case}, File "/opt/code/nndet/nndet/inference/predictor.py", line 177, in predict_case self.predict_tiles(tiles) File "/opt/conda/lib/python3.8/site-packages/torch/autograd/grad_mode.py", line 26, in decorate_context return func(*args, **kwargs) File "/opt/code/nndet/nndet/inference/predictor.py", line 267, in predict_tiles self.predict_with_transformation( File "/opt/code/nndet/nndet/inference/predictor.py", line 313, in predict_with_transformation ensembler.process_batch(result=result, batch=batch) File "/opt/conda/lib/python3.8/site-packages/torch/autograd/grad_mode.py", line 26, in decorate_context return func(*args, **kwargs) File "/opt/code/nndet/nndet/inference/ensembler/segmentation.py", line 176, in process_batch self.model_results[case_crop] += seg RuntimeError: The size of tensor a (61) must match the size of tensor b (112) at non-singleton dimension 3

Generate seg.pkl split file. What are the instructions you use? Thank you very much


"Extract selection to new note, content only" dialog should show full note path

I have notes with same name in different folder. I think it's common. Without full path I cannot know which is which. The dialog should show full path in the note list. This would be consistent with standard Obsidian Ctrl+O dialog too.

There is a fix for this included as part of the fix for #45.


transactor/status_test: Add application/user_id existence testing

Add unit tests that cover application_id and user_id existence in responses

bors r=@unleashed,@davidor,@eguzki


LoadError libicudata.64.dylib with 0.7.7

Installed as described in readme on latest OSX, installation passed without errors, but now rails does not work any more.
LoadError: dlopen(/Users/xxx/Projects/DTAG/td-wowi-shop-backend/vendor/bundle/ruby/2.5.0/gems/charlock_holmes-0.7.7/lib/charlock_holmes/charlock_holmes.bundle, 9): Library not loaded: /usr/local/opt/icu4c/lib/libicudata.64.dylib
Referenced from: /Users/xxx/Projects/DTAG/td-wowi-shop-backend/vendor/bundle/ruby/2.5.0/gems/charlock_holmes-0.7.7/lib/charlock_holmes/charlock_holmes.bundle
Reason: image not found - /Users/xxx/Projects/DTAG/td-wowi-shop-backend/vendor/bundle/ruby/2.5.0/gems/charlock_holmes-0.7.7/lib/charlock_holmes/charlock_holmes.bundle

This might happen after you upgrade your icu4c. For example after brew upgrade. To fix it run bundle pristine charlock_holmes

This happens quite frequently to us. https://github.com/brianmario/charlock_holmes/pull/164 would add an --enable-static option so that icu4c upgrades don't break charlock_holmes.

I think we can close this issue now that charlock_holmes 0.7.9 supports the --enable-static option:
gem install charlock_holmes -- --enable-static

This will work for macOS, but not for Debian/Ubuntu since they don't ship a static library compiled with -fPIC.

If you’re having trouble installing charlock_holmes on an M3 Mac, try this:
Install a compatible ICU version:
brew install icu4c@74
Install the gem with the ICU path specified:
gem install charlock_holmes -v 0.7.7 -- --with-icu-dir=$(brew --prefix icu4c@74)
This will work for mac m3.

Just ran into these issues after running brew upgrade. It installed icu4c@76, which evidently is not supported. Downgrading to @74 as per @MurapureddiNag  comment above worked well. Thanks.

I've had no issues building charlock_holmes with icu4c@75 or icu4c@76 on Ruby 3.2.5. --enable-static also works fine.
What errors are you seeing?

It's entirely possible the issue I ran into with Go in https://github.com/golang/go/issues/70209 is applicable here. The change in https://github.com/unicode-org/icu/commit/199bc827021ffdb43b6579d68e5eecf54c7f6f56 caused icu-uc to be in the Requires.private for libicu-i18n.pc:
Requires.private: icu-uc

We might need to add --static to the pkg-config command to pick up icu-uc.

Actually, it seems charlock_holmes already adds all the required libraries here: https://github.com/brianmario/charlock_holmes/blob/1c14a3fd5b08f629bba7ba478f8644a5296932bc/ext/charlock_holmes/extconf.rb#L33-L35
That explains the latest version works fine for me. I don't know what errors people are getting.


Add support for DID query

https://github.com/w3c-ccg/did-spec/issues/85

Added in query parsing in https://github.com/ockam-network/did/issues/5


Closes #115: Atom no longer mandatory

Clarify that the chunk in which atoms are stored is either Atom or AtU8, depending
on the source file encoding.

Yes, Thanks. The code example should also be updated at some point.


i18n(it): add 2.mdx translation

What kind of changes does this PR include?

Translated content

Description
Translated src/content/docs/en/tutorial/1-setup/2.mdx

Fixed problems / errors indicated by itsmatteomanf

Overall a very good job.
I left a few comments, some of them are "preferential", so feel free to ignore those suggestions (e.g. "vuoi" instead of "pianifichi di").


It is not possible to install Riemann from a locally hosted package (TAR,RPM)

For many organizations it is not an option to download software from external sources upon host setup.
We'd like to be able to install Riemann from a locally hosted, reviewed, known-good version.
I could provide a PR to either parametrize the path to the TAR to be installed (simple) or provide an installation from proper RPMs (more intrusive).
Would anyone be interested in any of these?

As a side note the quickstart guide says:
You can also install Riemann via the Debian or RPM packages, through Puppet, Vagrant, or Chef.


hacktober-pull

What the program do ?

In what programming language it is written?

This pull request do not contains files in specific folders. Please fix it and reopen


fix path error in cross section warehouse test

Fixes incorrect paths in the cross section warehouse test

fixed in #174


noto-font: fix some fonts being outdate, also rename the files

Description of changes
They changed the directory of variable font from variable-ttf to variable also cleaned up the file names

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Maybe you should also bump the version to noto-monthly-release-24.2.1?

It's already on 24.2.1   https://github.com/NixOS/nixpkgs/blob/1e1efbcf8c211b8a5f6019116da8aef597f58642/pkgs/by-name/no/noto-fonts/package.nix#L21

Oh I see, so the issue is that the build script nixpkgs-unstable is broken (at least, it uses the old variable-ttf directory - if Google had deleted that directory, then there would have actually been an error). Maybe add some form of testing then, like that all the font file in the repo are either packaged or have a valid reason to be ignored.

I don't think that we can realistically test for this, as we work a lot with fallbacks in this script due to the inconsistency in what variation fonts exits.

https://github.com/notofonts/notofonts.github.io/releases/tag/noto-monthly-release-24.3.1 is now out

Updating is done in #294119


Remove resources property from listChains and listPeers response

Codecov Report

Merging #371 into dev will increase coverage by 0.00%.
The diff coverage is 0.00%.

@@            Coverage Diff            @@
##                dev     #371   +/-   ##
=========================================
  Coverage     15.86%   15.86%
  Complexity      379      379
=========================================
  Files           173      173
  Lines          7023     7021    -2
  Branches        543      543
=========================================
  Hits           1114     1114
+ Misses         5821     5819    -2
  Partials         88       88

Impacted Files
Coverage Δ
Complexity Δ

...ross/network/rpc/handler/ConnectionURIHandler.java
9.37% <ø> (+0.80%)
4.00 <0.00> (ø)

...main/java/com/webank/wecross/peer/PeerManager.java
33.33% <0.00%> (-3.96%)
10.00 <0.00> (ø)


Update assistant selection menu

According to section Screens/inputbar here
Including:

The Assistant selection menu needs to be updated with right wording and iconography.
Add a "more" button that opens Assistant Detail View
(note: use the newly updated dropdown component that can do all that's in the figma)

Figma link: https://www.figma.com/file/QOxHwppG64GtPocpDhS6Y7/Product?type=design&node-id=4050-22255&mode=design&t=675WBPvIgubbwQiv-4

Fixed by https://github.com/dust-tt/dust/pull/3410#event-11586453965


Houdini: Farm publishing/rendering

Feature
Publishing to/on farm - Deadline and RoyalRender
🛠 Description work in progress
[cuID:25xn6hn]

We have rendered on the farm with Deadline in both Redshift and Arnold before. Let me know what you need specifically from our end and I might be able to contribute. 👍

Well exactly this - rendering and publishing of redshift renders, along with arnold and matra. Karma probably to if we solve usd resolver. And we'll need to do it for Deadline and RoyalRender, so something nice, abstract and extendable 💎


[Bugfix][Core] Fix tekken edge case for mistral tokenizer

Fix leading non-utf unicode tokens for tekken
FIX #8627
Generally, decoding id by id is dangerous for unicode tokenizers such as tekken (see: https://github.com/openai/tiktoken/issues/202#issuecomment-1749969932)
This PR makes sure that invalid tokens are instead passed as valid unicode code bytes and then later correctly decoded

@ywang96 I should probably add a test here no? Should we change one of the existing tests to take a symbolic language as an input?

Confirmed this indeed fixes the issue!
vllm: 图片展示了一幅壮丽的自然景观，主要是一条蜿蜒的河流穿过一片宁静的草地，周围环绕着高耸的岩石峭壁和树木。河流清澈见底，水面平静，周围散布着岩石和绿色植被。河流两岸的草地上点缀着各种植物和树木，营造出宁静的氛围。背景中的岩石峭壁高大险峻，直插云霄，增添了场景的宏伟感。天空晴朗，点缀着几朵云彩，暗示着一个明亮、晴朗的日子。图片中没有明显的文字或人造物品，突出了自然的美丽。整体氛围宁静而壮丽，突显了大自然的宏伟和宁静。
河流清澈见底，水面平静，周围散布着岩石和绿色植被。河流两岸的草地上点缀着各种植物和树木，营造出宁静的氛围。背景中的岩石峭壁高大险峻，直插云霄，增添了场景的宏伟感。天空晴朗，点缀着几朵云彩，暗示着一个明亮、晴朗的日子。图片中没有明显的文字或人造物品，突出了自然的美丽。整体氛围宁静而壮丽，突显了大自然的宏伟和宁静。

Let me push a change to add a non-utf language prompt to the test too!

Test is added for both Japanese and Chinese (Mistral-Nemo doesn't really support other symbol languages by now, but they should at least also not throw an error! Think it's ok to just test for Japanese and Chinese for now).
Pixtral uses Nemo so think we don't have to test it additionally?

Some HF Hub errors in the failing CI it seems - should I trigger CI again or ok to merge anyways?

We actually haven't enabled the full CI build yet, let me do that as good practice and then we can force merge based on that state

Quite certain that the failing test is unrelated here @mgoin - you think we can merge or should I trigger again?

Hi, could you help take a look at the following issue?
https://github.com/vllm-project/vllm/issues/9907


Make appimage script.

Maybe move make_appimage.sh to appimage/make.sh?

ok

Moved make_appimage.sh to appimage/generate.sh?


Cannot attach images in new Teams client

[Enter feedback here]  I have multiple users with the new Teams client saying they cant attach images in chat.  They get the 'Something went wrong...." message.  Attachments still work fine in "classic" Teams client

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 19ddf42e-0a47-7717-52d4-e549155480a2
Version Independent ID: 4bbe9beb-233f-cfd5-097b-f280aab5fde8
Content: Microsoft Teams developer community support and feedback - Teams
Content Source: msteams-platform/feedback.md
Service: msteams
GitHub Login: @surbhigupta
Microsoft Alias: lajanuar

Your issue seems to be related to Microsoft Teams product. We are adding the teams product tag so that right team can look into it.

We are mainly responsible for Microsoft Teams app development related issues.
For Microsoft Teams product issues/failures your tenant Admin can reach out to Microsoft 365 Product Support.
For general questions about Microsoft Teams please post your question on Microsoft Teams Community.

We are closing this issue for now, please feel free to reopen it, if required.


JSON Schema support for Policy, Definition YAML files

This PR adds JSON Schema definition files for Policy, Policy Include, and Definition YAML files.
This first pass targets editor and validation scenarios. We would like users to be able to get immediate inline errors in their editors when viewing non-conforming YAML files. These schema files should also be useful in validation workflows, either for manual validation or CI/CD, git pre-commit, or automation scenario.
This PR does NOT integrate the JSON Schemas into the actual application. This might be an interesting topic of discussion - on one hand using the schema in the application helps ensure the schema never drifts from the application behavior, but a tight clamp on the performance characteristics of the validation code (startup and per-file) would be key.

Status of this PR
Seeking input.
I would like to look at providing some kind of editor config files (e.g. settings.json or example.settings.json) that would help users to map these schemas to their input files correctly. The mapping problem might require some discussion - on one hand we could re-introduce multi-part names like ".policy.yaml" so that VSCode (specifically this YAML extension) can pick up mappings directly from JSON Schema Store . Alternatively just including the files in the repo with an example file might be pretty good.

A standard file extension would be nice for policy files  but even documenting how to add a yaml.schemas and or # yaml-language-server: $schema=https://raw.githubusercontent.com/aerleon/aerleon/master/schemas/aerleon-definition-yaml.schema.json to a file may be good as well.
I wonder if policy.yaml is too generic though.  Maybe not?

I'm beginning to think that JSON Schema Store with a positional selector is the way to go. I poked around at the current state of the tooling ecosystem and I found that PyCharm searches JSON Schema Store and there is even a VIM extension ^1 that will do so. GitHub registers schemas for its various YAML file formats in JSON Schema Store.
What I like about Schema Store is it has pretty flexible targeting rules, for example we could have a rule that says any *.yaml/*.yml file appearing in the policies/ directory is a Policy or Policy Include file, and files in defs/ are Network and Service Definition files. It might be a little presumptuous of us to claim a very generic path like "defs", but I suspect we have users who keep their definition files in that path so it seems worth a shot.
I did look at the modeline option. It seems to only apply to the VSCode YAML extension and the associated yaml-language-server project. But it's otherwise very flexible and it might be a good Plan B.

Quick status update: the JSON Schema files in this PR are decent and it might even make sense to merge as is. The ultimate goal of this work will be getting our schemas merged into JSON Schema store, and to do that there are guidelines they have published in terms of schema quality that I would like to implement before submitting to them.

https://github.com/SchemaStore/schemastore/blob/master/CONTRIBUTING.md

The following VSCode setting is how I configured these schemas. It might make sense to place this in some kind of example VSCode settings.json file for the time being (until we can submit to JSON Schema Store).
    "yaml.schemas": {

        "schemas/aerleon-policy-yaml.schema.json": ["*.policy.yaml", "policies/**/*.yaml"],
        "schemas/aerleon-definition-yaml.schema.json": ["*.definition.yaml", "def/**/*.yaml"],
    },

Update: Aerleon's schemas are now included in schemastore.org's catalog. VSCode users (and users of many supporting IDEs) will automatically pick up these schemas and apply them to Aerleon config, policy, and definition files.


ENABLE_yarpcar_bayer_carrier, set to ON

Hi all,
I am compiling the yarp and I following all the steps described in icub-wiki and yarp-wiki.
After this step:
CREATE_OPTIONAL_CARRIERS, set to ON
I should be able to do
ENABLE_yarpcar_bayer_carrier, set to ON
however the closest thing to this is:
ENABLE_yarpcar_bayer
Is this the equivalent thing? If so it is probably better to update the wiki.
Best wishes
Pedro

Issue moved to robotology/yarp #1126 via ZenHub


override git plugin config in package.py

What is the proper way of overriding allow_no_upstream config property in package.py?
I found this code
And tried various ways with no success:
with scope("config") as c:
    c.plugins.release_vcs.git.allow_no_upstream = True

# found this in some of the test files, it fails with an error
with scope("config") as c:
    c.override("plugins.release_vcs.git.allow_no_upstream", True)

with scope("plugins"):
  with scope("release_vcs"):
    with scope("git"):
      allow_no_upstream = True

Hey, I can't repro this unfortunately, it's working for me (using the first form listed). What os/rez-version? What was the specific error message you got?

Hi Allan,
I'm getting this error:
ReleaseVCSError: command failed: /usr/bin/git rev-parse --abbrev-ref --symbolic-full-name '@{u}'
fatal: HEAD does not point to a branch

rez-release --skip-repo-errors works, I thought I keep the settings within the package.py
This is needed for a release with a gitlab CI job, it checks out a tag, and therefore the HEAD is missing.
>> rez --version
Rez 2.53.1
>>python --version
Python 2.7.5

CentoOS 7

We have REZ_CONFIG_FILE point to our studio config, and there is a plugins dictionary with just the emailer plugin configured, I tried this too, but got the same error.
env REZ_CONFIG_FILE="" rez-release

# -*- coding: utf-8 -*-
name = '...'
version = '1.6.12'
authors = ['arusev<EMAIL_ADDRESS>
requires = []
variants = [['houdini-18.0', 'python-2']]
private_build_requires = ['fxBuildTools-4']

with scope("config") as c:
    c.release_packages_path = "/shots/fx/home/software/packages"
    c.plugins.release_hook.emailer.recipients = []
    c.plugins.release_vcs.git.allow_no_upstream = True

def commands():
    env.HOUDINI_PATH.prepend("{root}/houdini")
    env.PATH.prepend("{root}/bin")
    env.PYTHONPATH.prepend("{root}/python")

uuid = '173c976d-43f4-460f-924b-0abbb41a04e1'

Also this:
with scope("config") as c:
    print(c.plugins)

{'release_hook': {'emailer': {'recipients'<EMAIL_ADDRESS>

So I think you're hitting an error earlier than the code that's checking
the allow_upstream config setting.
See:
https://github.com/nerdvegas/rez/blob/master/src/rezplugins/release_vcs/git.py#L78
This is getting called before L98, and causes the error you've given here
if a tag is checked out. I'm a bit puzzled as to how this hasn't come up
before though.
The fix seems straightforward - just add a check for 'does not point to a
branch' substring on L85. Are you able to build a local rez instance and
try this out?
This ticket also makes me think we should add a PKG option to the
rez-config tool so you can see a config dump wrt a given developer package.
Thx
A
On Fri, Apr 3, 2020 at 3:33 AM alexxbb<EMAIL_ADDRESS>wrote:

Also this:
with scope("config") as c:
print(c.plugins)
{'release_hook': {'emailer': {'recipients'<EMAIL_ADDRESS>—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/nerdvegas/rez/issues/871#issuecomment-607954198, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AAMOUSSLLFXYBFF4LMXCF33RKS44FANCNFSM4LZY5H2A
.


Huge Memory Usage (AfoListObservable)

New to Angular, AngularFire2, and AngularFire2 Offline, so please forgive my ignorance 😃
The Issue
When using Reference.update() on a an AfoListObservable with even a modestly sized object the memory usage gets huge.
Using update() with a 1500 key object uses 1+ GB of memory (based on the Chrome Task Manager). Users of my application will frequently upload lists of easily 10,000 items, so I hope I'm doing something really wrong.
I found it while experimenting with the best way to store long lists of items. (Even made a stackoverflow question about it.)
Code to Reproduce
this.bigList = this.afoDatabase.list(`big_list/${uid}`);

const listRef = this.fbApp
  .database()
  .ref(`big_list/${uid}`);

for (var i = 0; i < 1500; ++i) {
  updates[listRef.push().key] = `${i}teststring`;
}

listRef
  .update(updates)
  .then(_ => {
    console.log("Finished updates");
  })
  .catch(function(error) {
    console.log("Updates failed: " + error.message);
  });

Workaround
Using afoDatabase.object() instead of afoDatabase.list() seems to work fine. The update() operation happens quickly and the memory barely jumps.

Oh, and big thanks to @adriancarriger for this library. It's looking very promising and sooo easy to use.
P.S. I'm really hoping I'm not missing something super obvious

Hi @trenthm, thanks for reporting this! I'll be looking into it soon! 👍

Code updates
Hi @trenthm, I noticed a few things in your code that might improve things
Changes

You only need to call either push or update, but not both
It might be more efficient to make a single call to Firebase instead of several small changes. In the examples links below, both update and set show how to make bulk updates, but I've experienced better performance with set while using Afo

Code examples

push
update
set

Performance
I made a change in Afo version 4.2.4 that should reduce the memory usage. There are still potential areas for performance improvements, but with this change I'm able add 5000 items without an issue, while beforehand the operation wouldn't complete.
Demos
Here are some demos you can try to compare performance (it might help to only run one demo at a time)

Demo (code) using Afo version 4.2.3 (without change)
Demo (code) without Afo (just using plain AngularFire2)
Demo (code) using Afo version 4.2.4 (with change)

Next steps
Let me know if this significantly reduces the memory consumption for your use case. Thanks! 👍

I was under the impression that the following code (from my OP) generated unique keys on the client side, without making multiple server calls (stackoverflow link – see second comment on answer):
for (var i = 0; i < 1500; ++i) {
  updates[listRef.push().key] = `${i}teststring`;
}

Is that incorrect? I notice that all of your demo code uses push(value) (with a value), not push() (without value). https://firebase.google.com/docs/reference/js/firebase.database.Reference#push
For my use case, I've decided to store the list of items as a JSON.stringify'd array, so I can't really test it any better than you have.
If you think it's solved, then this is closed as far as I can tell.

btw, awesome response. I have big hope for this library's future! It's already saved me so many hours. (Why not get a donation link on the projects front page... I'd be happy to throw a few :beer:'s your way)

Hi @trenthm, I didn't realize you were using the base Firebase Javascript SDK.. I was actually thinking you were using AngularFire2 which this library wraps. You're certainly right that you can call .push() without any arguments using the base SDK.
If you need Firebase access for parts of your app that you don't want data stored offline, you can use AngularFire2 alongside AngularFire2 Offline and the methods are mostly the same.
I'm glad this helped resolve your issue and it's great to hear that this library is saving you time! 🎉 👍


Use Late Static Bindings to instantiate the IP

With the static keyword child classes can be instantiated by methods like getNetworkIp and getBroadcastIp

Thanks for all the pull requests! :smile:

Hehe, no problem. I have two more ready! :dancer:


Add API endpoint to get list of available Singularity images and their tags and hashes

Currently, its hard to figure out whether an image for a simulator has been refreshed and what version/hash is currently available for simulation. It would be helpful to have an endpoint which reads out some information about this.

Hash information is now included in the simulator specifications.


Connect AOI front-end to API

Overview
This PR connects most of the AOI front-end to the API.
A user can now:

create an AOI project from the 'Create Project' modal
adjust various parameters of an AOI project (update frequency, start-time)
approve, reject, or do nothing with pending scenes

This PR also cleans up some parts of the UI:

adds new header style to color correction portions of UI
removes the scene detail overlay in favor of the scene detail modal
adds event propagation halting to buttons within scene items so that click 'Remove from project' does not delete the scene from the project AND show the scene detail modal
adds a scene count to the project scene list

Things this PR doesn't do but you might find yourself thinking it should:

allow drawing your AOI area (this is required to create an AOI object)
allow persisting of the AOI filters...because of 1
allow creating the actual AOI that would be referenced by your AOI project...because of 1.

That being said, for points 2 and 3 once the AOI area can be drawn in, all that would need to happen is to uncomment some code that is indicated by a TODO and these things would be sent to the API.

set a project as needing approval for scene addition - we will be making this the default for now, but it needs to be handled on the backend (see testing instructions for getting around this)

Checklist
~- [ ] Styleguide updated, if necessary~
~- [ ] Swagger specification updated, if necessary~
~- [ ] Symlinks from new migrations present or corrected for any new migrations~
Testing Instructions
(Prepare yourself)

Create a new project but this time select 'Area of Interest Project'!
Select 'Add public imagery'
You'll be taken to the add imagery page of the editor, as expected, but click back (using the arrow in the sidebar pane) which will take you to the project scene list.
You shouldn't have any scenes in your project at this point, and the scene list should have a message indicating that
Click back once more to the main editor area. There should be an 'AOI PROJECT' tag in the header bar along with a link to 'AOI Parameters'. Click into the parameters.
You can adjust both the update frequency and the start date. Remember what values you set them to. After you click 'Start Monitoring AOI', you should be taken back to the main editor.
Go back into the AOI parameters and ensure the params are the same as the ones you set
Test that the filter pane opens as expected (filter values will not be persisted until we can draw and create valid AOI objects)
Go back to the main editor page and then proceed to the imagery browser to add some 5-10 scenes to your project
If you go back a step to the project scenes list, you should see the scenes you just added (as usual)
Copy your project id and then open a psql shell (./scripts/psql) and then update the scenes_to_projects table so that scenes within the project (project_id is the column) have accepted=false.
In the UI, if you reload (and you're on the project scenes list page), the scenes should disappear, but you should see a banner indicating that you have scenes to approve.
Click the 'Review' button and then start accepting or rejecting scenes and see that it all works as you'd expect
Try some other combinations of things and make sure nothing breaks

Closes #1667
Closes #1668
Closes #1748
Closes #1726

It seems to be a backend issue. Will make a new issue for that.


Set default CPU model in VMI spec, even if not defined in KubevirtCR

What this PR does / why we need it:
Today if a CPU model is defined by KubevirtCR it is the default CPU mode for every VMI. If it no model is defined in KubevirtCR we keep CPU model empty.
While we do set the underlying domain to host-model as a default if no model is defined in KubevirtCR (as documented in our user-guide) it is not reflected in the VMI manifest, making it harder for other components to identify VMI's actual CPU model.
Without this change components across our code-base would have to implicitly assume that vmi.Domain.CPU == nil means model is host-model which is error-prone and less maintainable.
P.S. This fixes a bug that already exists in migration.go's code where a condition checks if the VMI has host-model CPU type defined. The condition is false although it is actually true simple because it is not reflected at the VMI spec level.
Release note:

Set default CPU model in VMI spec, even if not defined in KubevirtCR

cc @vladikr

/test pull-kubevirt-unit-test

/retest

/retest

/retest

/retest

/retest

/retest

/retest

I think that we need to backport this PR to 0.44
@stu-gott @iholder-redhat


conflicting dvc script -- typo?

The latest release renamed the cli from dvc-data to dvc, conflicting with https://github.com/iterative/dvc. Assuming that was just a typo?
https://github.com/iterative/dvc-data/blob/4ccb4208800e7fc608f81014ce4c4e25ab2dafe7/pyproject.toml#L62

@branchvincent Thanks a lot for this bug report! Indeed, that was a typo that I've introduced in https://github.com/iterative/dvc-data/pull/460 . 2.22.2 is out with the fix.

ah, wait, still wrong. Let me check closely.

2.22.3 is out. Thanks again!

@efiop thanks for the super quick fix!


 I was just hoping for a browser tab favicon, but the app icons are a nice bonus!

@abettermap
haha I just used a tool that practically does it for you. Easy peasy. It's responsive so I figured we might as well have the mobile icons.


Python 3 Support

Fixes #63.  In theory.
Currently, tests pass, but haven't really played with it yet.  This is a preview.

Codecov Report

Merging #234 into master will increase coverage by 0.24%.
The diff coverage is 79.16%.

@@            Coverage Diff             @@
##           master     #234      +/-   ##
==========================================
+ Coverage   68.51%   68.76%   +0.24%
==========================================
  Files          27       27
  Lines        2147     2180      +33
  Branches      264      270       +6
==========================================
+ Hits         1471     1499      +28
- Misses        582      585       +3
- Partials       94       96       +2


.NET Core 2.0 EXE is rebuilt every time in VS until project references are changed

Steps to reproduce
CoreBuildTest.zip
Open the solution in VS 2017. Make any change to Program.cs (e.g. add a space) and build the solution. Build the solution a second time.
Expected  behavior
The second time all projects are considered up to date and not rebuilt. Build Output window shows
========== Build: 0 succeeded, 0 failed, 2 up-to-date, 0 skipped ==========

Actual behavior
ConsoleApp1 is rebuilt every time:
========== Build: 1 succeeded, 0 failed, 1 up-to-date, 0 skipped ==========

Environment data
msbuild /version output:
Microsoft (R) Build Engine version <IP_ADDRESS>428 for .NET Framework
Copyright (C) Microsoft Corporation. All rights reserved.

<IP_ADDRESS>428

OS info: Visual Studio 15.5.2 on Windows 7 x64 SP1
Note
If I either add or remove a project reference in ConsoleApp1 and build then the project is considered up-to-date from then on (further builds do not rebuild) until I modify a source file again.

Looking at the logging of the subsequent build, it is incremental (the compiler doesn't run, for instance), indicating that this is a problem with the project system's fast up-to-date check. Moving to that repo.

This issue was moved to dotnet/project-system#3070


Do you can finish this project ?

Do you can finish this project someday ?

Yes, i could finish it, but i got no motivation for doing it.

What features do you miss?

Moderation options and wars

Could you take screenshots of the war pages? i do not longer have erepublik account

Do you have discord ?

OpenHogwarts (id: 2920)


Issue with linking account.

Account linking issue
If the API key is older than 3 weeks it wont link.

You have to make an new api-key for the setup


GSD Request

--- GSD JSON ---
{
  "vendor_name": "Linux",
  "product_name": "Kernel",
  "product_version": "versions from v5.16 to before v5.16.8",
  "vulnerability_type": "unspecified",
  "affected_component": "unspecified",
  "attack_vector": "unspecified",
  "impact": "unspecified",
  "credit": "",
  "references": [
    "https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/?id=7482e3841d520a368426ac196720601687e2dc47",
    "https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/?id=203a35ebb49cdce377416b0690215d3ce090d364"
  ],
  "extended_references": [
    {
      "type": "commit",
      "value": "7482e3841d520a368426ac196720601687e2dc47",
      "note": "introduced"
    },
    {
      "type": "commit",
      "value": "203a35ebb49cdce377416b0690215d3ce090d364",
      "note": "fixed"
    }
  ],
  "reporter": "joshbressers",
  "reporter_id": 1692786,
  "notes": "",
  "description": "net, neigh: Do not trigger immediate probes on NUD_FAILED from neigh_managed_work\n\nThis is an automated ID intended to aid in discovery of potential security vulnerabilities. The actual impact and attack plausibility have not yet been proven.\nThis ID is fixed in Linux Kernel version v5.16.8 by commit 203a35ebb49cdce377416b0690215d3ce090d364, it was introduced in version v5.16 by commit 7482e3841d520a368426ac196720601687e2dc47. For more details please see the references link."
}
--- GSD JSON ---

This issue has been assigned GSD-2022-1000674


cli session / login seemed not be persistent or not used

Currently I'm observing the following issue:
$ jira-cli version
1.0.20
$ jira-cli login
? Jira Password [khmarbaise]:  **********
OK Found session for khmarbaise
$ jira-cli session
errorMessages:
- You are not authenticated. Authentication required to perform this operation.

Also If do a jira-cli login first and afterwards I would like to do a jira view XY it always prompts with the login...which looks like it does not reuse the stored session?
Environment:

Linux OS (CentOS 7.5)
Jira 7.6.7
Configured endpoint and login in .jira.d/config.yml.

Update:

Also Tested with go-jira version 1.0.17 same behaviour.

Is there something I need to configure in JIRA itself to allow this?

There were issues with 1.0.18 and 1.0.19, but 1.0.20 should be fine to use with cookies.  I wonder if there is a "bad" cookie in your jarfile that is potentially confusing things, try removing the file at $HOME/.jira.d/cookies.js and try again.

Interesting, do you know if your current setup ever worked with go-jira? I believe Jira can be configured to not allow session based cookies, so maybe that is what you are seeing.  I can't think of any linux vs osx issues that might cause this, so I suspect the issue is in the different Jira versions (or jira configurations) you are authenticating against.  Newer versions of Jira might require api-token authentication (ie no cookies).  For that configuration to work you will need to be able to provide a consistent password, so something like pass.  There is more documentation about authentication options here: https://github.com/Netflix-Skunkworks/go-jira#authentication


[Task] add AOP for almost all examples

Description
you need to add some aspects in example module that forcing spring container to create AOP Proxy, so we can make sure that all proxy client sdk works fine when users use AOP.
you can find some useful informations in https://github.com/apache/incubator-shenyu/pull/2834.
if you find some bug, PRs are welcomed.
Task List

[x] add AOP test for shenyu-client-alibaba-dubbo; @weihubeats

[ ] add AOP test for shenyu-client-apache-dubbo; @weihubeats

[x] add AOP test for shenyu-client-grpc; @MichaelDeSteven

[ ] add AOP test for shenyu-client-springcloud; @renzhuyan

[ ] add AOP test for shenyu-client-springmvc; @gaochuang98

[ ] add AOP test for shenyu-client-motan;

[ ] add AOP test for shenyu-client-sofa; @ShawnSiao

[ ] add AOP test for shenyu-client-websocket; @Albertsirius

Please give me tasks 1 and 2, thank you

plz asign task3 to me, thx.

plz asign task  5 to me, thx.

please asign task 7 to me, thank you.

please asign task 4 to me, thank you.

please assign task 8 to me, thanks

please assign task 6 to me, thanks


More on private cloud options — Openstack, Eucalyptus, others?

Openstack is mentioned most explicitly in Related Topics as a private cloud alternative, which has traditionally been its deployment.
Openstack Omni aims to "provide a standard OpenStack API for managing hybrid and multi-cloud environments" and starts with AWS. I'm not sure how it compares to, say, Eucalyptus. It's value may be mostly in the eyes of the proponents, but seems worth a mention.
This issue can track other Openstack developments in relation to AWS.

I'm not sure of how much Openstack Omni is used, but perhaps deserves a mention. We should have a private cloud expert help review/write a small addition on private cloud open source solutions, and maybe title that section better, e.g. "AWS-compatible Clouds".
This should be broadened to include Eucalyptus too.
https://github.com/eucalyptus/eucalyptus

I'm going to carve out just the Openstack on AWS part, since I'm not clear ewhy one would want to do it. I expect to work on:

what it is,
utility (if any),
relation to previous work like Eucalyptus,
pros/cons

Others are welcome to work on the rest of the private cloud content, but IMO it often seems to degrade into political ranting.


---@aliases don't work in v3.x as they did in v2.6.8

Describe the bug
In v3.x fields defined in ---@alias with '' get converted to string literals (inside ""). That wasn't the behavior of the older versions.
To Reproduce
Steps to reproduce the behavior, use the following code:
local ngx = {}

ngx.DEBUG  = 8
ngx.INFO   = 7
ngx.NOTICE = 6
ngx.WARN   = 5
ngx.ERR    = 4
ngx.CRIT   = 3
ngx.ALERT  = 2
ngx.EMERG  = 1
ngx.STDERR = 0

--- NGINX log level constants
--- https://github.com/openresty/lua-nginx-module/#nginx-log-level-constants
---@alias ngx.log.level
---| 'ngx.DEBUG'  # debug
---| 'ngx.INFO'   # info
---| 'ngx.NOTICE' # notice
---| 'ngx.WARN'   # warning
---| 'ngx.ERR'    # error
---| 'ngx.ALERT'  # alert
---| 'ngx.CRIT'   # critical
---| 'ngx.EMERG'  # emergency
---| 'ngx.STDERR' # standard error
---@param level ngx.log.level
---@param ... string|number|'nil'|'ngx.null'
function ngx.log(level, ...) end

ngx.log

Start typing (
See the error

Expected behavior
The expected behavior is the behavior from v2.6.8. The alias entries enclosed in single '' shouldn't be converted to string literals (enclosed with "").
Screenshots

v3.0.2:

The autocomplete suggestion.

What the autocomplete expands to.

v2.6.8:

The autocomplete suggestion.

What the autocomplete expands to.

Environment:

OS: Windows
Client: VSCode

Additional context
If there is a reason why this is changed, could you instruct me on how to achieve the same result with a different approach?

see #980
Dose not support this behavior after 3.X

Such a shame. This allowed providing autocomplete for functions with enumeration constants in a separate table. That also means that there are some ---@meta files here, that don't work anymore. Actually, that was the place I took the above example from.

The new syntax will be used to implement this function in the plan:
---@alias ngx.log.level
---| `ngx.DEBUG`  # debug
---| `ngx.INFO`   # info
---| `ngx.NOTICE` # notice

Nice. Also, it does make sense to treat the values inside '' or "" as strings. Another benefit is that moving to `` quotes won't be hard to update in the existing code.

Thanks for responding quickly. Your project is so good!

Hi @flrgh!
According to the commit that implements this feature, it is now supposed to be written as:
---@type `CONST.X` | `CONST.Y`

Thanks for implementing this!


Use isinstance(x, Mapping) to check for dict-like types

Using the collections ABC is better than listing possible types.

:+1: this looks good to me. Waiting for Travis to get green.


chore(deps): :arrow_up: update storybook monorepo to v7 (major)

This PR contains the following updates:

Package
Change
Age
Adoption
Passing
Confidence

@storybook/addon-essentials (source)
6.5.16 -> 7.0.4

@storybook/angular (source)
6.5.16 -> 7.0.4

@storybook/builder-webpack5 (source)
6.5.16 -> 7.0.4

@storybook/core-server (source)
6.5.16 -> 7.0.4

Release Notes

storybookjs/storybook
v7.0.4
Compare Source
Storybook 7.0 is here! 🎉

⚡ First-class Vite
🔼 Zero-config NextJS
🇸 Zero-config SvelteKit
🏗 Frameworks API
3⃣ Component Story Format v3
🛡 Improved type safety
📚 Docs overhaul with MDx2 support
☂ Code coverage for interaction testing
🖼 UI design refresh
🏛 Improved stability

7.0 contains hundreds more fixes, features, and tweaks. Browse the changelogs matching 7.0.0-alpha.*, 7.0.0-beta.*, and 7.0.0-rc.* for the full list of changes.
See our Migration guide to upgrade from earlier versions of Storybook.
Bug Fixes

CLI: Catch errors thrown on sanity check of SB installs #22039

Dependency Upgrades

Addon-docs: Remove mdx1-csf as optional peer dep #22038

v7.0.3
Compare Source
Bug Fixes

React: Fix default export docgen for React.FC and forwardRef #22024
Viewport: Remove transitions when switching viewports #21963
CLI: Fix JsPackageManager typo #22006
Viewport: Fix the defaultOrientation config option #21962
UI: Fix story data access for broken About page #21951
Angular: Fix components disappearing on docs page on property change #21944
React: Don't show decorators in JSX snippets #21907
Addon-docs: Include decorators by default in source decorators #21902
CLI: Fix npm list command #21947
Core: Revert Emotion :first-child (etc) workarounds #21213

Maintenance

UI: Add remount story shortcut #21401
Telemetry: Add CLI version to context #21999
CLI: Update template code references to 7.0 #21845
Addon-actions: Fix non-included type file #21922
Addon GFM: Fix node-logger dependency #21938

Dependency Upgrades

React-vite: Fix perf regression by pinning vite-plugin-react-docgen-ts #22013
Update @emotion/cache version #21941

v7.0.2
Compare Source
Storybook 7.0 is here! 🎉

⚡ First-class Vite
🔼 Zero-config NextJS
🇸 Zero-config SvelteKit
🏗 Frameworks API
3⃣ Component Story Format v3
🛡 Improved type safety
📚 Docs overhaul with MDx2 support
☂ Code coverage for interaction testing
🖼 UI design refresh
🏛 Improved stability

7.0 contains hundreds more fixes, features, and tweaks. Browse the changelogs matching 7.0.0-alpha.*, 7.0.0-beta.*, and 7.0.0-rc.* for the full list of changes.
See our Migration guide to upgrade from earlier versions of Storybook.
Bug Fixes

CLI: Improve incompatible addons logic #21883

v7.0.1
Compare Source
Bug Fixes

CLI: Always send error events if init doesn't succeed #21879
CLI: Warn when community addons are incompatible with Storybook 7 #21863
CLI: Fix migration summary message #21862
CLI: Fix link to new framework API migrations #21875

Maintenance

Angular: Remove deprecated component/propsMeta from story #21807
Remove deprecated flags and properties #21852

Dependencies

Fix codemod dependency conflict #21876
Upgrade satellite repos for 7.0 #21881

v7.0.0
Compare Source
Storybook 7.0 is here! 🎉

⚡ First-class Vite
🔼 Zero-config NextJS
🇸 Zero-config SvelteKit
🏗 Frameworks API
3⃣ Component Story Format v3
🛡 Improved type safety
📚 Docs overhaul with MDx2 support
☂ Code coverage for interaction testing
🖼 UI design refresh
🏛 Improved stability

7.0 contains hundreds more fixes, features, and tweaks. Browse the changelogs matching 7.0.0-alpha.*, 7.0.0-beta.*, and 7.0.0-rc.* for the full list of changes.
See our Migration guide to upgrade from earlier versions of Storybook.
Full announcement and proper release to the latest npm tag coming soon. 😘

Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Enabled.
♻ Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about these updates again.

[ ] If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot.

Edited/Blocked Notification
Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.
You can manually request rebase by checking the rebase/retry box above.
⚠ Warning: custom changes will be lost.


External table datasource from Google Sheets should autodetect schema when not supplied

Bigquery external table API supports auto schema detection for external table source by a boolean property - ref.
If the target field names are the same as the source fields in the Google Spreadsheet, it should be better not to supply any schema rather than specifying the same column names one by one.

Spec with explicitly stated schema (AutoDetect = False)
name: project.dataset.table
type: external_table
version: 1
spec:
  schema:
  - name: column_name
    type: STRING
  source:
    type: google_sheets
    uris:
    - https://docs.google.com/spreadsheets/d/spreadsheet_id
    config:
      range: Sheet1!A1:B4
      skip_leading_rows: 1

Spec without schema autodetect (AutoDetect = True)
name: project.dataset.table
type: external_table
version: 1
spec:
  source:
    type: google_sheets
    uris:
    - https://docs.google.com/spreadsheets/d/spreadsheet_id
    config:
      range: Sheet1!A1:B4
      skip_leading_rows: 1

This looks neat, so it's like if the user has explicitly provided a schema, we will assume auto-detect is disabled?


Fix/fix dupe libs in bundle

Description

In feature/template-extensibility-algo-refactor there was a bundle size increase because both my-extended-retail-app and also retail-react-app would import common npm modules like @chakra-ui this PR attempts to resolve that.
I'm looking for help in validating that the new (slimmer) bundle doesn't omit anything we need

Original bundle:

New bundle:

Types of Changes

[ ] Bug fix (non-breaking change that fixes an issue)
[ ] New feature (non-breaking change that adds functionality)
[ ] Documentation update
[ ] Breaking change (could cause existing functionality to not work as expected)
[ ] Other changes (non-breaking changes that does not fit any of the above)

Breaking changes include:

Removing a public function or component or prop
Adding a required argument to a function
Changing the data type of a function parameter or return value
Adding a new peer dependency to package.json

Changes

(change1)

How to Test-Drive This PR

(step1)

Checklists

General

[ ] Changes are covered by test cases
[ ] CHANGELOG.md updated with a short description of changes (not required for documentation updates)

Accessibility Compliance
You must check off all items in one of the follow two lists:

[ ] There are no changes to UI

or...

[ ] Changes were tested with a Screen Reader (iOS VoiceOver or Android Talkback) and had no issues
[ ] Changes comply with WCAG 2.0 guidelines levels A and AA
[ ] Changes to common UI patterns and interactions comply with WAI-ARIA best practices

Localization

[ ] Changes include a UI text update in the Retail React App (which requires translation)

Wow! The bundle size seems a lot slimmer and I noticed framer-motion is gone. Great! This is a library that we don't use, but it is a transitive dependency of Chakra that we weren't able to get rid of previsouly.


Patch 1

update the readme with links

@camsctt,
Thanks for your contribution.
To ensure that the project team has proper rights to use your work, please complete the Contribution License Agreement at https://cla.microsoft.com.
It will cover your contributions to all Microsoft-managed open source projects.
Thanks,
Microsoft Pull Request Bot


Aravis Detector: Warmup HDF Writer During Stage

Changes:

Make ADAravis detector pass a frame through the HDF5 writer on staging to ensure that the ROIs are synced
Make this frame as short as possible for maximum efficiency

@DominicOram
On unit tests: I would very much like to write some, unsure what the best strategy is though. The logic is fairly tightly coupled to I/O and the behaviour of an AreaDetector driver. Not sure what the nicest way to test it is. Any insight you have would be great.

@DominicOram On unit tests: I would very much like to write some, unsure what the best strategy is though. The logic is fairly tightly coupled to I/O and the behaviour of an AreaDetector driver. Not sure what the nicest way to test it is. Any insight you have would be great.

You're right testing this stuff is a pain, I think it's a limitation in ophyd. Ideally we would be able to do something like:
from unittest.mock import MagicMock

from ophyd.sim import make_fake_device

from dodal.devices.areadetector.adaravis import AdAravisDetector

def test_priming_returns_settings_to_previous():
    det = make_fake_device(AdAravisDetector)(name="")
    det.hdf.enable.sim_put(0)
    det.stage()
    assert det.enable.get() == 0

def test_priming_triggers():
    det = make_fake_device(AdAravisDetector)(name="")
    det.cam.aquire = MagicMock()
    det.stage()
    assert det.cam.aquire.set.has_calls == [0, 1]

But the make_fake_device mixed with set().wait() and the inability to set mocks like det.cam = MagicMock() really doesn't like you doing this. Let's leave for now, hopefully better in v2, @coretl?

But the make_fake_device mixed with set().wait() and the inability to set mocks like det.cam = MagicMock() really doesn't like you doing this. Let's leave for now, hopefully better in v2, @coretl?

We should be able to do something like this in v2:
from ophyd.v2.core import set_sim_value

async def test_priming_returns_settings_to_previous():
    det = AdAravisDetector(name="")
    await det.connect(sim=True)
    set_sim_value(det.hdf.enable, 0)
    det.stage()
    assert det.enable.get() == 0

There is also set_sim_put_proceeds to allow you to make a sim signal block on put with wait=True so you can simulate a long running caput callback


Just add a missing single quotation mark

Describe this PR

Changes

What issue does this fix?

Any other relevant information

Thanks for spotting, @tungvn!


tag feed afterwards

hi
I d´like to add tags to every news of a feed, a while after having them fetched.
what is the way for this ?
thanks !

https://github.com/skeeto/elfeed#autotagging

You took the words right out of my mouth, @alphapapa!

autotagging doc says:

Tags can automatically be applied to entries discovered in specific
feeds through extra syntax in elfeed-feeds

If I add tags, this only apply to new entries - not all the feeds´
entries.

@parisni You'll have to write some Lisp code to iterate over entries in the elfeed-db-entries and set their tags.  It's not too hard using maphash and e.g. (setf (elfeed-entry-tags....  I happened to do this yesterday and it worked, but unfortunately I didn't save the code.
I think it's not necessary to also modify elfeed-db-index, because it seemed to work without doing so, but Chris will know for sure.

You'll have to write some Lisp code to iterate over entries in the
elfeed-db-entries and set their tags

@alphapapa thanks for the staters !

There are commands, elfeed-apply-autotags-now and elfeed-apply-hooks-now,
that run existing entries through the hooks as if they were new.


.github/CODEOWNERS: remove non-committer users/teams

these didn't work anyway and now github warns if they don't have commit access
https://github.com/NixOS/nixpkgs/blob/b71ebb32cedef576181e519380f42d1e2fc5d312/.github/CODEOWNERS

can't we instead setup the teams so that they have write access ? gnome team implies triage for now for instance.

can't we instead setup the teams so that they have write access ?

Not with the way we currently use teams as they have members who don't already have write access.

it's sad that we can use only teams with write access (it is normal according to docs https://docs.github.com/en/repositories/managing-your-repositorys-settings-and-features/customizing-your-repository/about-code-owners)
Have you looked for any github ticket to allow teams with RO access  ?
Maybe we could create a team with write access instead ? like gnome-RW

Have you looked for any github ticket to allow teams with RO access ?

No.

Maybe we could create a team with write access instead ? like gnome-RW

Out of scope of this PR, creating new teams (and new types of teams) can be discussed elsewhere.

Now we have another team with commit access definitely seems simpler to just limit this file to users/teams with commit access so we can benefit from the github warnings and avoid any confusion.

What do you think about pinging the teams so that they know they need to fix this?

What do you think about pinging the teams so that they know they need to fix this?

There isn't anything to be fixed here, this is basically just cleaning up dead code. The members of the gnome, php and podman teams that that have commit access are already listed here alongside the team. The darwin team has ~45 people, mostly non-committers. I think asking people to add themselves as new darwin codeowners is out of scope for this PR.


Feature/drive api

Allow us to save the google drive cred file in the repo encrypted.

Yes, I'll merge the other PR first.


Run tests in browser

Tests should be run in both a browser (like Headless Chrome) and Node.  Currently they are only run in Node.
CC: @bterlson

Assuming this is for track2, I believe we do this for all packages. Feel free to re-open if I am mistaken.


Remove Publish with beta tag step on publish.yml

The publish.yml file is supposed to publish the version on NPM after doing some checks.
For the first version, we wanted to give ourselves the possibility to publish a beta in case of problems.
In the end, we don't use this beta step so we can remove it from this file.

After discussion, we are keeping the possibility to create a beta version. Closing this issue


adding windows build action

build for windows
add a short doc point linking to Windows build instructions
rename linux build

@brettmc I think you chosen wrong settings ...
PHP8 still is builded with vs16 (VS 2019) so in matrix setup need to use 'windows-2019' because extension will can not be loaded by php.net builds ....

PHP8 still is builded with vs16 (VS 2019) so in matrix setup need to use 'windows-2019' because extension will can not be loaded by php.net builds

ok, changed to 2019.

Also i suppose want to upload windows build artifact to pecl.php.net ..... if not then it's not a problem

I didn't know you could even do that. It looks like windows.php.net provides builds of many extensions, is that how it's usually done? I couldn't see anything relevant in the package upload section of pecl, which is the only bit I'm familiar with.

@brettmc If remember you can also upload artifact build using 'actions/upload-artifact' from 'https://github.com/cmb69' .... but im not 💯 sure ....

you can also upload artifact build using 'actions/upload-artifact'

I'll create an issue to look at this. Upload artifact action will store it in the github run, but that's something.


Terms of Use and Privacy Statements

[x] Write Terms of Use
[x] Write Privacy statements
[x] Home page links to both documents

@daniel-slaugh - I have drafted terms of use and privacy statements for HydroServer:
Terms of Use: https://docs.google.com/document/d/1bCv7y3mZOIWCS6AcaCidpZ3Xsr71sItIZ-AbfX7M3GY/edit
Privacy Policy: https://docs.google.com/document/d/1nC_R5_wbghyG29qlF1CbT0gN2crhAYYmoajql0dI8_0/edit
It would be nice if these were implemented in such a way that they could be easily replaced. For example, could they be markdown documents that can just be swapped out by anyone who wants to run their own instance of HydroServer?

@horsburgh - Awesome. I can convert these to markdown and put them in our main HydroServer repo, then point the frontend to those markdown files. As far as allowing user to swap out their own, maybe that could be added as a user preference? (hydroserver2/hydroserver#101)

@daniel-slaugh - it's not so much a user preference as it would be a configuration issue. Could this be a deployment configuration setting?


Stops "ack!"ing after 10 messages

Im having some strange behavior,
I installed sneakers on a ruby app, I have about 10 other apps with the same code which are not experiencing this issue
an ack! should be sent under all circumstances, but after around 10 messages it appears my worker is not even receiving anything to work off. The message just sits "ready" forever

## Boot Script
Sneakers.configure(
  heartbeat: 60,
  amqp: "amqp://#{ENV['RABBITMQ_USER']}:#{ENV['RABBITMQ_PASS']}@#{ENV['RABBITMQ_HOST']}",
  daemonize: ENV['RACK_ENV'] == 'production',
  pid_path: './sneakers.pid',
  vhost: '/',
  exchange: 'sneakers',
  exchange_type: :direct,
  timeout_job_after: 2.minutes,
  workers: 1,
  properties: {
    connection_name: 'worker'
  }
)
Sneakers.logger.level = Logger::DEBUG
workers = Sneakers::Runner.new([Workers::BB])
workers.run

## Worker
module Workers
  ##
  class BB
    include Sneakers::Worker

    from_queue :backbone

    def work(msg)
      start_time = Time.now
      status = 'green'
      log :debug, 'start'

      obj = JSON.parse(msg)
      log :debug, "#{obj['cmd']} ... start"

      case obj['cmd'].to_sym
      when :EVENT_INTERFACE
        BACKBONE::EventInterface.process_received(obj['payload'])
      end
      ack!
      log :info, "finished #{status}, took #{Time.now - start_time}"
    rescue StandardError => e
      status = 'red'
      log :fatal, e.message
      log :fatal, e.backtrace
      ack!
      log :fatal, "finished #{status}, took #{Time.now - start_time}"
    end
  end
end

According to the screenshot, there are 10 delivered but unacknowledged messages. Most likely the prefetch value used is 10 and no deliveries were acknowledged.
That's the best hypothesis I have without a traffic capture and RabbitMQ logs.

Could it be the problem that ack! should be the last call in the work method? Because ack! just returns a symbol that is used later to decide if the processing was successful 🤔
https://github.com/jondot/sneakers/blob/v2.12.0/lib/sneakers/worker.rb#L33
https://github.com/jondot/sneakers/blob/v2.12.0/lib/sneakers/worker.rb#L84


Nested coordinator can't open more than one screen

Hi, I found another bug with nested coordinators. A nested coordinator can't open more than one screen, when trying to call a transition - nothing happens, and if you close the open screen after that - navigation will be broken.

iOS 17.5
0.6.2

Example code that reproduces the behavior:
import SwiftUI
import FlowStacks

enum Path: Hashable {
    case sport(Int, SecondCoordinator)
}

enum NewPath: Hashable {
    case challenge(String, SecondCoordinator)
}

class FirstCoordinator: ObservableObject {
    @Published var path: Routes<Path> = []

    func push() {
        path.push(.sport(1, .init(self)))
    }
}

struct ContentView: View {
    @ObservedObject var coordinator: FirstCoordinator

    var body: some View {
        FlowStack($coordinator.path, withNavigation: true) {
            VStack {
                Button {
                    coordinator.push()
                } label: {
                    Text("Push")
                }
            }
            .navigationTitle("ROOT")
            .flowDestination(for: Path.self) { screen in
                switch screen {
                case let .sport(value, coordinator):
                    SportView(coordinator: coordinator, value: value)
                }
            }

        }
    }
}

class SecondCoordinator: ObservableObject {
    private let parent: FirstCoordinator
    private let id = UUID()

    @Published var path: Routes<NewPath> = []

    init(_ parent: FirstCoordinator) {
        self.parent = parent
    }

    func push() {
        path.push(.challenge("2", self))
    }
}

extension SecondCoordinator: Hashable, Equatable {
    static func == (lhs: SecondCoordinator, rhs: SecondCoordinator) -> Bool {
        lhs.id == rhs.id
    }

    func hash(into hasher: inout Hasher) {
        hasher.combine(id)
    }
}

struct SportView: View {
    @ObservedObject var coordinator: SecondCoordinator

    let value: Int

    var body: some View {
        FlowStack($coordinator.path) {
            VStack {
                Button {
                    coordinator.push()
                } label: {
                    Text("push")
                }
                Text(value.description)
            }
            .navigationTitle("Sport")
            .flowDestination(for: NewPath.self) { screen in
                switch screen {
                case let .challenge(value, coordinator):
                    ChallengeView(coordinator: coordinator, value: value)
                }
            }
        }
    }
}

struct ChallengeView: View {
    @ObservedObject var coordinator: SecondCoordinator

    let value: String
    var body: some View {
        VStack {
            Text(value)
            Button {
                coordinator.push()
            } label: {
                Text("challenge")
            }
        }
        .navigationTitle("Challenge")
    }
}

I also attach a recording of the behavior
https://github.com/johnpatrickmorgan/FlowStacks/assets/43087859/557012be-0619-4838-af8f-a4bf5d63121b

@johnpatrickmorgan hi, do you have any ideas or suggestions?)

Hi @lisindima, thanks for raising this. Sorry for the delay - I've been looking into it, and I'm a bit puzzled so far. I'll give more info about my findings so far on Monday. Thanks!

Hi, here's a quick update:
FlowStack holds onto the binding passed in to its initialiser (in its externalTypedPath property) and ensures any changes made to it get propagated to its own internal source of truth - its  path property. It does so via a call to onChange(of: ). The issue seems to arise because changes to the externalTypedPath are triggering the FlowStack to recompute its body, but the onChange closure is for some reason not getting called. Adding _printChanges shows that the mutation causes the FlowStack's body to be recomputed (@self, _externalTypedPath changed is printed), but the onChange(of: _externalTypedPath) closure is not called. I've been trying to figure out why but I haven't found anything concrete so far.
Along the way I did notice a simpler issue that was causing FlowLinks not to work within a nested FlowStack, so I put in a fix for that in v0.6.3.

Thanks for your investigation, I also found one rather dirty hack, but it works well so far.
Use withNavigation: true in the nested coordinator. This will result in duplication of the NavigationBar, but this can be fixed with navigationViewModifier and we get this code:
struct SportView: View {
    @ObservedObject var coordinator: SecondCoordinator

    let value: Int

    var body: some View {
        FlowStack($coordinator.path, withNavigation: true, navigationViewModifier: NavigationBarHidden()) {
            VStack {
                Button {
                    coordinator.push()
                } label: {
                    Text("push")
                }
                Text(value.description)
            }
            .navigationTitle("Sport")
            .flowDestination(for: NewPath.self) { screen in
                switch screen {
                case let .challenge(value, coordinator):
                    ChallengeView(coordinator: coordinator, value: value)
                }
            }
        }
    }
}

struct NavigationBarHidden: ViewModifier {
   func body(content: Content) -> some View {
        content
            .navigationBarHidden(true)
    }
}

Maybe this will help you)

with this hack there was a problem, on iOS 15 onAppear is called twice, without this hack the problem is similar - the nested coordinater is not able to open more than one screen.
@johnpatrickmorgan hi, is there any progress on this issue?

@johnpatrickmorgan I don't want to seem intrusive, but my team is very much blocked by this bug, we encountered this after almost completely rewriting the application to this library, perhaps there is some progress with fixing this error?

@lisindima Sorry for the slow progress; I'm struggling to find a solution. In the meantime, some workarounds would be:

Use FlowLinks for navigation in the child FlowStack.
Use a FlowPath in both FlowStacks and use FlowPathNavigator for navigation in the child FlowStack.
Don't nest FlowStacks at all, use just one.

I imagine that none of these are quite what you're hoping for, but they might help you for the time being. Thanks!

Thanks for your patience. I now understand the problem at least: the onChange in the child FlowStack doesn't fire if it's no longer onscreen. The solution will require a bit of refactoring.

@johnpatrickmorgan I encountered this problem while creating a child FlowStack. I hope you resolve this issue quickly.

Thanks for your patience. I believe this issue should now be resolved in v0.7.0, but I'd appreciate your feedback. I had to amend the way nesting FlowStacks works, but it shouldn't affect your use case - please see the amended docs.

@johnpatrickmorgan In v0.7.0, use withNavigation: true in presenting child FlowStack was not working. It only works if called routes.presentCover(.child, withNavigation: true)

@johnpatrickmorgan In v0.7.0, use withNavigation: true in presenting child FlowStack was not working. It only works if called routes.presentCover(.child, withNavigation: true)

Thanks @phamdinhduc795397 - if I understand correctly, that's the intended behaviour. When nesting FlowStacks, the parent FlowStack determines whether the child FlowStack is presented with navigation, and the withNavigation parameter passed to the child FlowStack is ignored. I'll clarify that in the docs, thanks!

`struct ParentCoordinator: View {
enum Screen: Hashable {
case child
}
@State private var routes: Routes<Screen> = []

var body: some View {
    FlowStack($routes, withNavigation: true) {
        rootView()
        .flowDestination(for: Screen.self) { screen in
            switch screen {
            case .child:
                ChildCoordinator()
            }
        }
    }
}

@ViewBuilder
func rootView() -> some View {
    Button("present child") {
        routes.presentCover(.child)
    }
}

}
struct ChildCoordinator: View {
enum Screen: Hashable {}
@State private var routes: Routes = []
var body: some View {
    FlowStack($routes, withNavigation: true) {
        Text("ChildCoordinator")
            .navigationTitle("ChildCoordinator")
    }
}

}`
Use FlowStack($routes, withNavigation: true) in child ChildCoordinator, withNavigation: true will be ignored, except you pass withNavigation: true with routes.presentCover(.child, withNavigation: true)

`struct ParentCoordinator: View {
enum Screen: Hashable {
case child
}
@State private var routes: Routes<Screen> = []

var body: some View {
    FlowStack($routes, withNavigation: true) {
        rootView()
        .flowDestination(for: Screen.self) { screen in
            switch screen {
            case .child:
                ChildCoordinator()
            }
        }
    }
}

@ViewBuilder
func rootView() -> some View {
    Button("present child") {
        routes.presentCover(.child)
    }
}

}
struct ChildCoordinator: View {
enum Screen: Hashable {}
@State private var routes: Routes = []
var body: some View {
    FlowStack($routes, withNavigation: true) {
        Text("ChildCoordinator")
            .navigationTitle("ChildCoordinator")
    }
}

}`
Use FlowStack($routes, withNavigation: true) in child ChildCoordinator, withNavigation: true will be ignored, except you pass withNavigation: true with routes.presentCover(.child, withNavigation: true). In v0.6.4, it works well.

Спасибо за ваше терпение. Я считаю, что эта проблема должна быть решена в v0.7.0, но я был бы признателен за ваш отзыв@lisindima @phamdinhduc795397Мне пришлось изменить способ работы вложенных FlowStacks, но это не должно повлиять на ваш вариант использования — см. измененную документацию .

Hi, the error with which I opened this problem is fixed in the new version, thank you


Update PDFs

[ ] Update outdated Git cheat sheet PDFs

[ ] Fix typo: #810
[ ] Update commands: #791

[ ] Look into automating PDF generation based on markdown files

Okay okay thanks for the work and love world love more love for world too world thanks bay bay bey bey okay @@&$)(;:-125788888


Can I control the scroll position of an individual component with overflow: scroll?

Hi Ryan and maybe other people that I do not know about XD
I have a GatsbyJS app I'm developing and I'm using a design pattern where the window.scroll position is locked to [0,0] but I have components that do indeed scroll using the overflow: scroll css property. There are a bunch of reasons for this, but the TLDR is that I need to do this and cannot use position: fixed or position: sticky due to project/browser/usability/bosses-yelling-at-me(not really, but kind-a/sort-a) constraints. Using this design approach I am able to bypass mobile browser decisions that I(we/company) consider to be user hostile, and I am then able to create a more app-like, fluid and enjoyable experience for my users.
This design pattern works great until I navigate to new routes, where I want the scroll position of the <MainContent> container to be reset to [0,0], but since this component is not the window element, Gatsby does not seem to know how to do that out of the box.
I have a another app that I have developed using VueJS where I ran into the same problem, but the fix was pretty easy, simply adding a method to the main.js Vue file using the element.scrollTo() DOM API and resetting the scroll position of an individual component using that Vue method, like so:
methods: {
  mainContentScroll () {
    document.getElementById('main-content').scrollTop = 0
  }
}

So I would like to know if this is possible using reach router with or without Gatsby, and how I might be able to go about doing it. I already created an issue with the Gatsby team, but they suggested I NOT use this design pattern, which is completely and totally not an option for me. So it's either I figure it out, or switch back to Vue, which I would rather not do at this point, cuz Gatsby is rad, for the most part. Here is a link to that issue with my very long winded explanations and rebuttals, if it is of interest to you and your team:
https://github.com/gatsbyjs/gatsby/issues/14690
Anyhoooo, if there is any way to do this kind of thing in the react world and with reach router and/or gatsby, please let me know. I don't care HOW it's done, I just need some way to do it :-)
Thank you in advance :-)

Hey @rchrdnsh! Stepping outside of the virtual DOM is typically a red flag, but not explicitly disallowed--especially when dealing with scrolling.  So I'm not sure why element.scrollTo wouldn't work in your use case.
Unfortunately, however, this your solution would be outside of what Reach Router supports, so I'll go ahead and close the issue, but for reference, there are other forums that cover this very topic


Preperation needed for new release

At this point its probably getting very close, but there may be some things I haven't thought of.
The only thing left I can conjure is tests that use include_bytes!() output from OpenBSD signfiy and run through signing and verifying, and then again with embedded signatures. This would make it easier to run a "probably ok" test suite locally and then just rely on CI to do a live test against OpenBSD signify's current version.
@badboy anything else you can think of?

One thing for sure: to_file_encoding needs to return a Result and properly validate the comment length. Its problematic now since it lets you create signatures that we and OpenBSSD signify will reject verifying since the comment line could be too long.

Another point, which was brought up by @thomcc over Discord, is that the Codeable trait is currently a bit of a footgun. It works great for the provided CLI, but may let people more easily mess-up if they use libsignify themselves. Once again quoting, consider this:
send_key_over_net(public_key: impl Codeable) { ... }

There's no typesafety at all and the compiler will happily let you beam your signing keys to the other side of the web if you give it the wrong field :p
Given that this trait is also the reason we need to unconditionally depend on liballoc, it might not be worth keeping around in libsignify and just moving it to signify so the base64 helper methods can keep working.

Which discord is that?

Erm, "private correspondence" -- BHF and I go way back. Anyway, I don't feel that strongly about this — at work I spend a lot of time worrying about unnecessary alloc deps (our code runs on microcontrollers), so it was surprising to see one here.

Erm, "private correspondence" -- BHF and I go way back. Anyway, I don't feel that strongly about this — at work I spend a lot of time worrying about unnecessary alloc deps (our code runs on microcontrollers), so it was surprising to see one here.

ehehe, fine!
Yeah, it's certainly a thing we can change and it sounds very sensible for me to move that out of the lib.

I need to re-read the code once again to see what we do there and if I have a good understanding of my own.

Somewhere here tells me that the code isn't clear enough as is?
I've bee poking at how to remove the footgun of the trait on and off the last few days but so far ive ended up with either a lot of duplication or AnotherGun:tm: The duplication of the code isnt what annoys me most though tbh, its the duplication of the doc comments for all the as_bytes(&self), etc methods.

fyi: current cargo release 0.4.1 contains an incompatible ring version (I think it already got removed in the latest build). I had built it locally on my m1, and it seems stable to me, anything crucial needed for 0.5.0 to be released?
; cargo install signify
    Updating crates.io index
  Installing signify v0.4.1
error: failed to compile `signify v0.4.1`, intermediate artifacts can be found at `/var/folders/p_/k06bmy8s1jb7nqrdwy7r_9qc0000gn/T/cargo-install6atkpq`

Caused by:
  failed to select a version for the requirement `ring = "^0.12"`
  candidate versions found which didn't match: 0.16.20, 0.16.19, 0.16.18, ...
  location searched: crates.io index
  required by package `signify v0.4.1`

I'll put it on my list for this weekend. We should be able to get something out by then.
We can fix up some of the bigger things mentioned above in followups if we don't get that by the weekend.

Cool! No hurry have a great weekend and stay safe! I am here for testing if you need an ARM M1 test. Not very familar with Rust but I am open to help where I can :)

Well, took one weekend longer than planned but there's now a v0.5.0 published (well, also a v0.5.1 because I want the release workflow to properly run).
That shouldn't stop us from the mentioned changes though for a 0.6 release

Oh, one note: Releasing should now be as easy as cargo release -x minor and CI takes care of building binaries as well.

@badboy Tried to run that locally to release 0.5.3 with the type inference fix + new examples but it turns out cargo release needs a token by default but I have no publishing perms. I could do --no-publish and put a PR up with just the git stuff if that works for you?

@badboy Tried to run that locally to release 0.5.3 with the type inference fix + new examples but it turns out cargo release needs a token by default and I have no publishing perms. I could do --no-publish and put a PR up with just the git stuff if that works for you?

I sent you an invite on crates.io, you should have emails about that just now.

Yep, they came through, thanks.
0.5.3 has just been published. Weirdly cargo release didn't do a dry-run first so hopefully nothing was wrong :rip:

Yep, they came through, thanks.
0.5.3 has just been published. Weirdly cargo release didn't do a dry-run first so hopefully nothing was wrong :rip: Hopefully next time I'm more used to it.

Hm, I know that was a change in some recent version. It should be fine now, but you might want to update your cargo-release.


Update azure-stack-manage-storage-accounts.md

The actual default value of retention period is 0 days now. Update the document to reflect the reality.

@GeorgeH-MS : Thanks for your contribution! The author, @mattbriggs, has been notified to review your proposed change.

#sign-off

@Brenduns: I'm sorry - only the author of this article, @mattbriggs, can sign off on your changes. But we do have an exception process - if you are on the Microsoft content or product team for this product area, you can ask the PR review team to review and merge it by sending mail to the techdocprs alias.


image_picker 0.7.4 - should it save to a temporary location?

Hi all, should image_picker 0.7.4 getImage() save to a temp location or the appdir?
It appears to using my appdir, which is filling up quick. Anyway for it to save to a temp location and let me manually copy to my appdir if I want to keep the image?

Hi @Lee-Fixter
This issue doesn't seem to describe a bug or a feature request. Please see https://flutter.dev/community for resources and asking questions like this, you may also get some help if you post it on Stack Overflow and if you need help with your code, please see https://www.reddit.com/r/flutterhelp/
See https://github.com/flutter/flutter/issues/70335 which is a related issue.
Closing, as this isn't an issue with Flutter itself.
Thank you


Prevent modals breaking swiper w/ recovery attempt

Solution to issue #2

how do you run tests locally?
are they failing because this code gets ran in situations that break currentSlideModified

this.notifyPropertyChange('currentSlide');

Just for the record: The failing tests were my fault. Travis used Phantom 1.9 which does not support some of the features I was using (like .bind(this)).
Anyway thanks for your efforts. I really appreciate them and hope not to seem rude, but the same problem was tackled in #4, which is why I am closing this now.


Can't download 6.1.5 dmg file for MacOS

System information:

MacOS Mojave 10.14.6
6.1.5

Describe the problem you're observing:
I can't download .dmg installer file. Mainly because that file is not exists in /files/6.1.5/ path.
Steps to reproduce, if exist:

Same issue, and only found 6.1.4 file in Release 6.1.5 assets.

Yep, there were some problems in automatic Mac build publishing. Now fixed.
Thanks for the bug report.


Output file name is not what I expected

Checklist

[ ] I'm reporting a broken site support issue
[x] I've verified that I'm running youtube-dl version 2019.11.28
[x] I've checked that all provided URLs are alive and playable in a browser
[x] I've checked that all URLs and arguments with special characters are properly quoted or escaped
[x] I've searched the bugtracker for similar bug reports including closed ones
[x] I've read bugs section in FAQ

Verbose log

[youtube] gYO1uk7vIcc: Downloading webpage
[youtube] gYO1uk7vIcc: Downloading video info webpage
WARNING: Requested formats are incompatible for merge and will be merged into mkv.
[download] Destination: D:\cloudhiback\main\hibackcloud\data\25\video.mkv.f137
[download] 100% of 85.29MiB in 02:14
[download] Destination: D:\cloudhiback\main\hibackcloud\data\25\video.mkv.f251
[download] 100% of 3.16MiB in 00:03
[ffmpeg] Merging formats into "D:\cloudhiback\main\hibackcloud\data\25\video.mkv.mkv"
Deleting original file D:\cloudhiback\main\hibackcloud\data\25\video.mkv.f137 (pass -k to keep)
Deleting original file D:\cloudhiback\main\hibackcloud\data\25\video.mkv.f251 (pass -k to keep)

Description

def downloadvideo(vpath, proxy='',id=-1):
    ydl_opts = {
        'proxy': proxy,
        'outtmpl':getdatapath('/'+str(id)+'/video.mkv'),
        'format':'bestvideo[height<=?1080,ext=mp4]+bestaudio/best',
        'ffmpeg_location':getffmpegpath(),
    }
    # print ('test.')
    with youtube_dl.YoutubeDL(ydl_opts) as ydl:

        ydl.download([vpath])

Problem:
1.when my code is 'outtmpl':getdatapath('/'+str(id)+'/video.mp4'), ,ffmpeg merge will output video.mkv
2.I changed .mp4 to .mkv ,still cause a problem,it will output video.mkv.mkv
I hope it does not check the file suffix and writes the file name directly.
The file name change is not convenient for me to write code to handle these videos.
Hope you can fix it,thank you very much.

WARNING: Requested formats are incompatible for merge and will be merged into mkv.

But I can't know if this video needs to be merged, if not then what file name will it output?
video.mp4?
video.mkv?
video.mkv.mkv?


[VS Code] [Audio] HTTPS request failed for SkypeToken: Parse Error: JS Exception

Error:
HTTPS request failed for SkypeToken: Parse Error: JS Exception
Steps to Reproduce:

Organiser share link (collaborative work) with participant.

Messages popups to join meeting, when click on accept button shows error.

Version Data

extensionName
VSLS-Audio

extensionVersion
0.1.84

applicationName
VSCode

applicationVersion
1.44.2

platformName
MacOS

platformVersion
18.7.0

We released a fix for this issue. Now available in the Marketplace Live Share Audio v 0.1.85. Please let us know if you're still hitting this after an update. Thanks for the help!


Refactor endpoint

Pulling specific self.endpoint methods out of all the subclasses and standardize it from the base_model

@miq-bot assign @bdunne
@miq-bot add_label refactor

@miq-bot add_label enhancement


Run loop stopping early due to streams regression

I recently updated the version of libuv my application is using and immediately noticed it was unexpectedly quitting. I used git bisect to trace the problem to commit 05a003a3f78d07185b7137601fe8e93561855a8d. I'm not sure why but setting stream->flags |= UV_STREAM_DISCONNECT causes the run loop to think there are no ref'd handles left.
The only thing that should be ref'd in my application is a bound TCP socket. The disconnected stream is an HTTP stream that is unref'd while it is in keep-alive (between requests) and ref'd once a new request comes in.
Commenting out https://github.com/libuv/libuv/commit/05a003a3f78d07185b7137601fe8e93561855a8d#diff-c9c9805d800eb132a191a9e40da6d813R1236 src/unix/stream.c lines 1236 and 1237 fixes the problem. Line 1146 (uv__stream_eof()) never gets hit.
This is on Fedora.

Is your read callback executed with an error status? Any chance you can write a libuv test case exhibiting the problem?

I don't believe it is, but I'd double check. Even so, there's no reason for the run loop to stop.
I'll look into writing a test case. Thanks.

Even so, there's no reason for the run loop to stop.

A bound socket doesn't keep the loop alive because it's not active, a listening socket is active and keeps the loop alive, though. And if a socket gets a read error it becomes inactive, so it also doesn't prevent the loop from exiting.
http://docs.libuv.org/en/v1.x/handle.html?highlight=active#c.uv_is_active

Sorry, you're right, the socket is bound and listening. The same application was working up until that commit, so I don't think I'm doing anything wrong, although I might be. I haven't had a chance to put together a test case yet.

I created a test case: https://gist.github.com/btrask/d3a2e5629ccf49706fe0
It behaves as I originally described. It's triggered by the combination of uv_unref and UV_STREAM_DISCONNECT.

@btrask can you try the patch in #474 ? It fixes the problem for me.

We reverted that in https://github.com/libuv/libuv/pull/475#issuecomment-128684848