on multiple screens the menu appears only on one screen

A strange effect I've noticed which I think comes from having multiple screens attached.
On one of the screens, in chrome, the menu appears normal. In the others, it only partially appears or does not appear at all. e.g.

Usually there is one master screen where everything works fine. However, to use the extension would require moving the chrome tab over to that screen which take away from the convenience of the plugin.
Is this issue know and are there any workarounds?

This seem similar to #91, are you running OSX?

Never noticed reply before. FYI, I was running windows 10.


[Bug]: Create a lock on datasource context cache to avoid multiple parallel connections from being created

Is there an existing issue for this?

[X] I have searched the existing issues

Current Behavior
A single datasource on the server is expected to have a long-running connection that is reused till it expires. This connection context is retained in a map that acts as a cache between different execution calls. However, this cache is not synchronized and can hence create multiple connections that remain unused, and occupy the connection pool.
Steps To Reproduce
Unsure of how this can be done so far, will need to mock parallel calls to server.
Environment
Production
Version
Cloud

@nidhi-nair can you please explain this line ? : However, this cache is not synchronized and can hence create multiple connections that remain unused, and occupy the connection pool.

@sumitsum Since Hashmap does not handle concurrent connections inherently, we'd need to create a synchronized lock around the cache. Multiple APIs access this map at the same time, and even though in terms of consumption we'll always get a valid connection, the cration of connections happens multiple times, and are possibly only closed the one time. Does this address your question?

Closed via https://github.com/appsmithorg/appsmith/pull/14348


How to assign a self-signed certificate for Azure Stack

Azure Stack development kit uses a self-signed certificate. How to assign it when using azure-sdk-for-go?
If not specified, I got the following error:
Get https://management.local.azurestack.external/subscriptions/xxx/resourcegroups/xxx/providers/Microsoft.Resources/deployments/xxx?api-version=2017-05-10: x509: certificate signed by unknown authority"

@bingosummer can you please clarify what you mean ? (i.e. give a sample code of what you are trying to do ? ) Are you referring to using a self signed client certificate for auth  ?

Closing as stale, feel free to mention us and have it re-opened.

I figured it out. I need to put the self-signed certificate in /etc/ssl/certs/ca-certificates.crt.


Insufficient mobile user interface

In particular,
unable to zoom in/out the map on mobile devices,
the node info box is too large,
the debug info can appear off the screen,
and panning the view causes the window to attempt to scroll

Window scrolling should be fixed by 07f51ce, but it seems the panning doesn't work properly since on touch screens there's never a pointermove event where no buttons are pressed; we should utilize pointerdown and pointerup to remedy this.

a61687d fixes most of these issues.
Note both zooming in/out and rotating the map is still not possible on mobile devices

rotating on mobile should now be possible thanks to f211dac

gotta figure out zooming; I'd like a slider that changes directions depending if 100vh > 100vw, or if vice versa, but also have to figure out how to factor in screen orientation, since idk if vh and vw are affected by screen orientation. Could just add buttons to zoom in/out instead?


include/posix: incorporate toolchain-provided time.h header

Some of what's supposed to be in <time.h> was lost because this header attempts to define everything using more primitive include files. Instead incorporate the contents from the toolchain-provided header. Any gaps should be picked up by the legacy content present in this file, which should not conflict with the toolchain header.
An updated test confirms the problematic API is now available to Zephyr.
Closes #24730.
(This solution, which addresses a blocking problem for a Nordic-based project, has been discussed in https://github.com/zephyrproject-rtos/zephyr/issues/24730#issuecomment-620653206.  The potential follow-up cleanup is not being addressed here.)

Thanks @pabigot! #24730 is a blocker for me currently when porting a posix based app on top of zephyr posix api. But not with this, confirming that this would solve compilation issues that I faced and would unblock me to concentrate to the actual beef.
Hopefully this could be merged!

I indeed wasn't able to look into that issue myself - started with first issues in backlog for POSIX subsys (syscalls for fd primitives), and never got out of that swamp.
My only question (beyond a couple of code comment requests) is - how this was tested? (Any more or less big 3rd-party software build with it or whatever.)

Review comments addressed.  It's been compile-tested via sanitycheck, and externally tested by @jhirsi.


add beacon to V2 API

Adds a beacon to the V2 API to test load performance.
Add a defaultToggleValues to S3 so we can change them within 30 seconds in case it all goes belly up. There's a bit of an edge case here where the values will be overridden on deploy, but it allows us to turn things off and then fix them.

TODO:

[x] add a beacon on the work page

Is the v1 API currently only pinged on componentDidMount and componentDidUpdate?

This is to replicate something similar to getinitialprops, and seems to be aligned as we re-render on every search.

And is it always pinged when those lifecycle methods fire?

Yip, including not firing when we update the UI with the viewer.


dump biosample, study and omics processing Mongo collections inot an NMDC "Database"

Since we don't have any visual explorer yet, at least people can do manual, one-stop, cross-collection searching in a document like this

@turbomam this issue looks like its related to the linkml one you created: https://github.com/linkml/linkml/pull/1609?

Can this be closed now that we have the data in graphdb?


Name change in sidebar? :)

I love this gadget; right now RTRC is the only acronym in my sidebar.  Could this be updated to "Real-time RC"?  That would help clarify it's one of two sidebar links, and would have a more useful translation.

Exported to https://phabricator.wikimedia.org/T361303.


bug: MS SQL Timestamp (Rowversion) data type is being seen as DateTime type

The timestamp or rowversion data type in MS SQL which a special type of varbinay(8) or binary(8) is being seen as a date time type since that is the name of a date time type in postgres.  I will need to update this in the org_to_jsonchema_type and hd_to_jsonschema_type.  This is the error that occurs when a value of the data type is encoutered during a meltano run
dateutil.parser._parser.ParserError: Unknown string format: 000000000d5e8a32
ValueError: Could not parse value '000000000d5e8a32' for field 'Version'.

MS documentation about this data type:
https://learn.microsoft.com/en-us/sql/t-sql/data-types/rowversion-transact-sql?view=sql-server-ver16

I think will be the add to hd_to_jsonschema_type:
if sql_type_name in ['ROWVERSION', 'TIMESTAMP']:
	return {
		"type": ["string"],
		"contentEncoding": "base64",
		"maxLength": 12
	}

Found this entry in the SQLA documentation.

The ROWVERSION datatype does not reflect (e.g. introspect) from the database as itself; the returned datatype will be TIMESTAMP.
This is a read-only datatype that does not support INSERT of values.

Since column is a readonly and you are not able to insert into it.  I think it is when copying it over to utilize the base equivalent which is varbinary(8) .  This will also be easier to handle this data in other SQL databases like Postgres.
SQLA documentation:
https://docs.sqlalchemy.org/en/20/dialects/mssql.html#sqlalchemy.dialects.mssql.ROWVERSION

In org_to_jsonschema_type I think it would be best to convert this to a string:
if str(sql_type) in ["'ROWVERSION', 'TIMESTAMP']:
	sql_type = "string"


Laravel 8.x Shift

This pull request includes the changes for upgrading to Laravel 8.x. Feel free to commit any additional changes to the shift-38065 branch.
Before merging, you need to:

Checkout the shift-38065 branch
Review all pull request comments for additional changes
Update your dependencies for Laravel 8
Run composer update (if the scripts fail, add --no-scripts)
Thoroughly test your application (no tests?)

If you need help with your upgrade, check out the Human Shifts. You may also join the Shifty Coders Slack workspace to level-up your Laravel skills.

:x: Shift could not upgrade the following files since they differed from the default Laravel version. You will need to compare these files against the default Laravel 8 versions and merge any changes:

[ ] public/index.php

:information_source: Laravel 8 streamlined the Exception Handler into a single register method to make it easier to add custom logic around rendering or reporting errors within your application.
While this change is not required, Shift recommends comparing yours against the Laravel 8.x version as an opportunity to reduce code and be fully up-to-date.

:x: Laravel 8 condenses the RouteServiceProvider as well as configured the new rate limiters. Shift was unable to automate this change. You should compare yours against the Laravel 8.x version and merge any changes.

:information_source: The RouteServiceProvider no longer prefixes the controller namespace by default in Laravel 8. While you may still set this property, you are encouraged to register your routes using static ::class references.
You may automate the conversion to static class references using the Shift Workbench.

:information_source: Laravel 8 introduced class based factories. Shift automated this change. However, if you were using a community package for factories or other custom code, you should review your factories for additional changes.
If you encounter an issue, you may revert this commit and temporarily install the laravel/legacy-factories package. You may then automate the conversion to class based factories using the Shift Workbench.

:information_source: Laravel 8 added a uuid column to the failed_jobs table to support the new job batching features.
If your application is currently using the failed_jobs table, you may generate a custom migration for this command by running:
php artisan make:migration AddUuidToFailedJobsTable

Then copy and paste the contents from Shift's AddUuidToFailedJobsTable class to add the uuid column and generate UUIDs for your existing failed jobs.

:information_source: Laravel 8 added a new ENV variable of LOG_LEVEL. While the log level is defaulted in the configuration, you may take this opportunity to set it accordingly in your environments.

:warning: Shift upgraded your configuration files by defaulting them and merging your true customizations. These include values which are not changeable through core ENV variables. This should make maintaining your config files easier.
You should review this commit for any additional customizations. If you have a lot of customizations, you may wish to undo this commit with git revert and make these config file changes manually.

:information_source: Shift updated your dependencies for Laravel 8. While many of the popular packages are reviewed, you may have to update additional packages in order for your application to be compatible with Laravel 8.
Watch dealing with dependencies for tips on handling package incompatibilities.

:warning: Laravel 8 now requires PHPUnit 9 which made some configuration changes to its config file. You may automate these changes by running vendor/bin/phpunit --migrate-configuration or comparing your phpunit.xml to the Laravel 8 version and merging any changes.

:information_source: Laravel 8 reintroduced the app/Models folder by default. This is an optional change. Laravel and the artisan commands will automatically detect if you are using the app/Models folder or not.
If you wish to modernize your application to use the app/Models folder, you may run the Namespace Models Shift for free.

:tada: Congratulations, you're now running the latest version of Laravel.
The following Shifts may be used ensure your application is fully upgraded and easier to maintain in the future:

Upgrade Checker ensures your application is fully upgraded by detecting any outdated code.
Laravel Fixer automates many of the suggestions found by the Laravel Linter and other Shifts.
Tests Generator intelligently generates model factories, HTTP Tests, and unit tests for your application to give you a head start on testing.

You may run these Shifts and stay upgraded forever as well by subscribing to a Shifty Plans.

:warning: Shift detected you are using a Laravel package like Horizon or Nova which may need to have its published assets regenerated after upgrading. Be sure to use artisan to republish these assets as well as php artisan view:clear to avoid any errors.


Automatically create RBAC rules for users to create claims when defining XRDs

Context
Currently, pkg.appcat.composite.objectstorage defines explicitly 2 cluster roles so that users can create claims in namespaces.
In the component via jsonnet, we could create those rules automatically, removing the need to maintain these roles separately.
Alternatives

Keep it as of v0.1.1
Use Crossplane's RBAC management policy = All, but that completely changes how RBAC is done, see #12

Isn't this implemented with https://github.com/vshn/component-appcat/pull/7/commits/85b99cc64e5d7fa8bba522c2dd9bd10b2c4555fc ?

yes


DIGITAL-144: Add and configure Tome, S3, and Samlauth

Jira ticket

DIGITAL-144
Purpose

Deployment and testings
We will need to integrate with the deployment PR which will enable / disable the proper splits.
Local Setup

lando rebuild -y && lando si
QA/Testing instructions
settings.lando.php will enable you to turn on the non-prod split, which will enable s3 fuse.
The other splits, if enabled, will turn on Samlauth.
You must ./drush.sh cim after enabling a split.
Tome is always on. You can export the site with ./drush.sh tome:static

Checklist for the Developer

[x] A link to the JIRA ticket has been included above.
[x] No merge conflicts exist with the target branch.
[ ] Automated tests have passed on this PR.
[x] A reviewer has been designated.
[x] Deployment and testing steps have been documented above, if applicable.

Checklist for the Peer Reviewers

[ ] The file changes are relevant to the task objective.
[ ] Code is readable and includes appropriate commenting.
[ ] Code standards and best practices are followed.
[ ] QA/Test steps were successfully completed, if applicable.
[ ] Applicable logs are free of errors.

SAML will be configured later.
s3fuse will be configured via settings overrides by @casey-rapnicki-bixal

Let's leave this one open until we have all of the config for SAML Auth.

Let's leave this one open until we have all of the config for SAML Auth.

Let's leave this one open until we have all of the config for SAML Auth.

We need the other configuration in here right now so we can test tome and s3 integration. The Samlauth should not hurt anything if it's not configured right now.

@jlfranklin ready to review again.


x/tools/cmd/goimports: removes import of gopkg.in/pipe.v2

What version of Go are you using (go version)?
go version go1.10.3 darwin/amd64
Does this issue reproduce with the latest release?
It reproduces with the tip version of goimports.
What operating system and processor architecture are you using (go env)?
GOARCH="amd64"
GOBIN=""
GOCACHE="/Users/issactrotts/Library/Caches/go-build"
GOEXE=""
GOHOSTARCH="amd64"
GOHOSTOS="darwin"
GOOS="darwin"
GOPATH="/Users/issactrotts/gopath"
GORACE=""
GOROOT="/Users/issactrotts/homebrew/Cellar/go/1.10.3/libexec"
GOTMPDIR=""
GOTOOLDIR="/Users/issactrotts/homebrew/Cellar/go/1.10.3/libexec/pkg/tool/darwin_amd64"
GCCGO="gccgo"
CC="clang"
CXX="clang++"
CGO_ENABLED="1"
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -fno-caret-diagnostics -Qunused-arguments -fmessage-length=0 -fdebug-prefix-map=/var/folders/9z/3vhqmj_j18v6vsk1q2jr486r001n0v/T/go-build789719517=/tmp/go-build -gno-record-gcc-switches -fno-common"
What did you do?
ijt:~/gopath/src/gibug$ go get -u golang.org/x/tools/cmd/goimports
ijt:~/gopath/src/gibug$ cat p.go
package main

import (
        "fmt"
        "gopkg.in/pipe.v2"
)

func main() {
        fmt.Println("vim-go")
        p := pipe.Line()
}
ijt:~/gopath/src/gibug$ goimports p.go

What did you expect to see?
package main

import (
        "fmt"
        "gopkg.in/pipe.v2"
)

func main() {
        fmt.Println("vim-go")
        p := pipe.Line()
}

What did you see instead?
package main

import (
        "fmt"
)

func main() {
        fmt.Println("vim-go")
        p := pipe.Line()
}

A workaround is to import "github.com/go-pipe/pipe" instead.

Works for me. Using 1.10.3 and latest goimports on Linux.
vim, vscode, atom and goimports all added the gopkg.in/pipe.v2 line.

I tried it again on a Linux system and got the same incorrect output.
~/src/gi$ go get golang.org/x/tools/cmd/goimports

~/src/gi$ cat > p.go
package main

import (
        "fmt"
        "gopkg.in/pipe.v2"
)

func main() {
        fmt.Println("vim-go")
        p := pipe.Line()
}

~/src/gi$ goimports p.go
package main

import (
        "fmt"
)

func main() {
        fmt.Println("vim-go")
        p := pipe.Line()
}

~/src/gi$ go version
go version devel +b8669ef1ce linux/amd64

~/src/gi$ go env
GOARCH="amd64"
GOBIN=""
GOCACHE="/home/issactrotts/.cache/go-build"
GOEXE=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="linux"
GOOS="linux"
GOPATH="/home/issactrotts"
GOPROXY=""
GORACE=""
GOROOT="/usr/lib/google-golang"
GOTMPDIR=""
GOTOOLDIR="/usr/lib/google-golang/pkg/tool/linux_amd64"
GCCGO="gccgo"
CC="clang"
CXX="third_party/crosstool/v18/stable/toolchain/bin/x86_64-grtev4-linux-gnu-llvm_driver_is_not_gcc"
CGO_ENABLED="1"
GOMOD=""
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -fno-caret-diagnostics -Qunused-arguments -fmessage-length=0 -fdebug-prefix-map=/tmp/go-build911829805=/tmp/go-build -gno-record-gcc-switches"

I'm having the same issue, but with gopkg.in/yaml.v2. It's happening to me ever since I updated to Go 1.11.
It's actually sort of related to this issue: https://github.com/golang/go/issues/7942 (which isn't actually an issue).
Basically, for me, the reason is because I'm using Go modules for dependency management, gopkg.in/yaml.v2 isn't in my GOPATH and therefore goimports will remove it.
Running this:
go get gopkg.in/yaml.v2

seems to fix it as a workaround but the real fix should be for goimports to consider Go modules as well as GOPATH.

Same issue with paths like this: "github.com/labstack/echo/v4"
Extremely annoying as goimports is the default in VSC when using modules.

In general, goimports may remove a package when it's not found locally and its package name isn't the last segment of the path, or the next-to-last segment of a path that ends in /vNNN. As of about six months ago, goimports adds explicit names to those cases, so that once it's run successfully (with all relevant packages available locally) it should never make that mistake again.
Because it's been a while, and I think this should be fixed by now, I'm going to close this bug. If you run into it with a modern version of goimports, please file a new bug, ideally with a reproducer. Sorry for any trouble.


Fix for goroutine leak

#5 Should fix the issue of goroutine leak due to deadlock on the unlocker channel while releasing lock.

Closing this as opened this via my work Github account.


Don't move jar to local mvn repo

Since dask-sql does not rely on the mvn repository during runtime but instead adds the jar to the project installation dir and modifies the classpath by reading from pkg_resources it shouldn't be necessary to run mvn install here. mvn package should suffice.

Can one of the admins verify this patch?

ok to test

Thanks for this PR @ksonj.
I'm not too familiar with the maven packaging process but it looks like package creates a jar while install also installed it in the local repository for other maven packages to pick it up.
Dask-sql (python) doesn't use the maven repository and just relies on the jar, and I don't think there are other libraries just relying on our dask-sql jar so I think we should be good here.
Also tagging @jdye64 since you're more familiar with this and might have thoughts.


Pull requirements.txt from specific release

The released version requirements.txt differs from master now therefore the download is also versioned.

/cc @DoriftoShoes @jfryman @Kami

LGTM.
IIRC there was some debate about this in the past (I can't recall now why we merged the change to pull requirements.txt from master), but I was always against pulling requirements from master anyway.

I found a commit where we made this change - c210a7163b56b4e984e5ad13bd6340c6cf9071d7, but the message doesn't really include the context for it.
/cc @m4dcoder

Yeah will wait on @DoriftoShoes and @m4dcoder to respond.

I'm not sure why we did this.  I agree that we should be pulling from the downloads server though.

We also need to cherry pick this into v0.13.1 branch once it's merged into master.

@m4dcoder Can you look at this PR and https://github.com/StackStorm/st2/commit/c210a7163b56b4e984e5ad13bd6340c6cf9071d7 .
LMK if this is going to be an issue.

I suspect at some point we dropped publishing requirements.txt to the build server; that has since been fixed with https://github.com/StackStorm/st2cd/commit/b0cf6e6e6649ae20bc375f7685f518bfb8e80b79

LGTM. I'm not sure why I made the change before. It must have been trying to get around an environment issue.

merging. What could possibly go wrong :P


Fix issue where included test suites were not being expanded out

Fixes Issue #149 by not making a mutable copy and updating the configuration itself to expand out the testsuite into it's individual tests.

@oliverhu can you review this, and if it is okay, merge it?

Note: I made sure that this works by running bluepill with a testsuite as the include parameter and observed the output stating that it was testing only tests in that testsuite.

Travis does run and succeed the tests

I closed this PR so that I can try to find a way to not modify the original config


Vulcan client-side code as npm packages

An issue to track our progress in using Vulcan client side tooling in other Node frameworks, like Next, Gatsby, React Native etc.
This means GraphQL client, but also JS components like the SmartForm and Datatable.
This issue only concerns client side code, so an existing Vulcan backend can be consumed by any kind of js application. It does not concern server side code, which is still a bit more dependant on Meteor (Mongo collection system and a few other specific setups).
Steps:

[ ] demeteorize client side code. It's almost done, only blocker is https://github.com/VulcanJS/Vulcan/issues/1896. A few references to Meteor will have to be changed elsewhere too, eg in the Apollo client.
[ ] allow distant connection to the graphql server with CORS setup
[ ] allow to build Vulcan code with Webpack, at least for client. Storybook was a first step toward this, since we can already build most components correctly
[ ] create a Lerna monorepo and publish packages on npm

See https://github.com/VulcanJS/vulcan-next-starter/issues/1


[dataform]: com.google.auth.oauth2.GoogleAuthException: Error getting access token for service account

Thanks for stopping by to let us know something could be better!
PLEASE READ: If you have a support contract with Google, please create an issue in the support console instead of filing on GitHub. This will ensure a timely response.
Please run down the following list and make sure you've tried the usual "quick fixes":

Search the issues already opened: https://github.com/googleapis/google-cloud-java/issues
Check for answers on StackOverflow: http://stackoverflow.com/questions/tagged/google-cloud-platform

If you are still having issues, please include as much information as possible:
Environment details

google-cloud-java
OS type and version: Google App Engine
Java version: Java 8
Version(s): https://mvnrepository.com/artifact/com.google.cloud/google-cloud-dataform-bom/0.22.0

Steps to reproduce

Create a Google Cloud Task
Within the Task a function is called that creates a DataformClient with the credentials by your service account of the AppEngine
The IAM permissions of the AppEngine service account is Owner
The dataform client requests a list of all repositories.

Code example
ArrayList<String> scopes; // contains "https://www.googleapis.com/auth/cloud-platform"
GoogleCredentials credentials = ServiceAccountCredentials.fromStream(this.getClass().getResourceAsStream(fileCredentialName));
credentials = credentials.createScoped(scopes);
FixedCredentialsProvider fixedCredentialsProvider = FixedCredentialsProvider.create(credentials);

DataformSettings dataformSettings = DataformSettings.newBuilder().setCredentialsProvider(fixedCredentialsProvider).setQuotaProjectId(AppengineEnv.APP_ID).build();

try (DataformClient dataformClient = DataformClient.create(dataformSettings)) {
            ListWorkspacesPagedResponse listWorkspacesPagedResponse = dataformClient.listWorkspaces(repositoryName);
} catch (IOException e) {
      log.error("An exception is thrown!", e);
}

Stack trace
Caused by: com.google.auth.oauth2.GoogleAuthException: Error getting access token for service account: com.google.apphosting.api.ApiProxy$CallNotFoundException: Can't make API call urlfetch.Fetch in a thread that is neither the original request thread nor a thread created by ThreadManager, iss<EMAIL_ADDRESS>at com.google.auth.oauth2.GoogleAuthException.createWithTokenEndpointIOException(GoogleAuthException.java:164) 	at com.google.auth.oauth2.ServiceAccountCredentials.refreshAccessToken(ServiceAccountCredentials.java:543) 	at com.google.auth.oauth2.OAuth2Credentials$1.call(OAuth2Credentials.java:269) 	at com.google.auth.oauth2.OAuth2Credentials$1.call(OAuth2Credentials.java:266)
External references such as API reference guides
https://github.com/googleapis/google-cloud-java/tree/main/java-dataform
Any additional information below
Scope in Google Credential Provider: "https://www.googleapis.com/auth/cloud-platform"

Hi @Siraachenbach, thanks for reporting this. Is this the only code of your application? Would you mind sharing a reproducer project so we can work it out on our end? Thanks!

@diegomarquezp I think I have explained how to reproduce the issue. Unfortunately, I cannot share the code.

Can't make API call urlfetch.Fetch in a thread that is neither the original request thread nor a thread created by ThreadManager

@Siraachenbach Does this error message makes sense? Would you write down threads that make "original request" and "urlfetch.Fetch"?


Add tests in pipeline

We need to write some tests to validate that everything is properly deployed.
A naive approche would be to juste run curl on deployed ingresses.

Issue migrated to Jira.


Fix unittest and setup codecov

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@6566032). Click here to learn what that means.
Patch has no changes to coverable lines.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
Additional details and impacted files
@@            Coverage Diff            @@
##             master       #2   +/-   ##
=========================================
  Coverage          ?   95.26%
=========================================
  Files             ?       12
  Lines             ?      909
  Branches          ?      225
=========================================
  Hits              ?      866
  Misses            ?       42
  Partials          ?        1

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Find the Odd Integer

Resolves: #4
This is used to find the integer which is occurring for odd number of times.
Xor of a number with itself is 0 and xor of a number with 0 is the number itself. So, doing xor of all the numbers in the array gives the number occurring odd number of times.
a ^ a = 0
a ^ 0 = a

Thanks for making PR, Don't forget to give a star on Repository.
You can also create new issue for problem task for others from Edabit.


Test verbose not printing logs

There seems to be a problem with using
gopm test -v

The logs from .Log() do not show up.
Any help would be appreciated.
Thank you

I'd like to take a look at this.
Can you provide the file you are testing?
Is the test passing or failing?

Example of Problem
foo_test.go
package foo

import (
    "fmt"
    "testing"
)

func TestFoo(t *testing.T) {
    fmt.Println("Hello")
    t.Log("World")
}

Using go:
$ go test -v

Output:
=== RUN   TestFoo
Hello
--- PASS: TestFoo (0.00s)
	foo_test.go:10: World
PASS
ok  	_/.../.../Desktop	0.010s

Using gopm:
$ gopm test -v

Output:
[GOPM] 15-10-20 15:32:05 [ INFO] App Version: <IP_ADDRESS>8 Beta
[GOPM] 15-10-20 15:32:05 [ INFO] Local repository path: /Users/.../.gopm/repos
[GOPM] 15-10-20 15:32:05 [ INFO] Indicated GOPATH: /Users/.../.go
[GOPM] 15-10-20 15:32:05 [DEBUG] Linking Desktop...
[GOPM] 15-10-20 15:32:05 [DEBUG] Loading dependencies...
[GOPM] 15-10-20 15:32:05 [ INFO] Testing...
[GOPM] 15-10-20 15:32:05 [ INFO] Setting GOPATH to /Users/.../Desktop/.vendor
[GOPM] 15-10-20 15:32:05 [ INFO] ===== application outputs start =====

Hello
PASS
ok  	_/Users/.../Desktop	0.009s
[GOPM] 15-10-20 15:32:05 [ INFO] ====== application outputs end ======
[GOPM] 15-10-20 15:32:05 [ INFO] Setting GOPATH back to /Users/.../.go
[GOPM] 15-10-20 15:32:05 [ INFO] Command executed successfully!

@Unknwon any chance you can look into this?

The logs are only printed when you pass the -v flag to `go test

Hi all, I've pushed a quick fix to pass -v flag to go test command.

This seems to be fixed, however running gopm update doesn't seem to update gopm... I ended up using go get -u github.com/gpmgo/gopm to force update. You can mark this issue as closed @Unknwon and thanks for the support.

@abelino oh! right, I haven't updated the version on the web for gopm.
PS: I can't believe gopm is still working...

@Unknwon shouldn't this be closed?

Yes please close!

:blush:


Upgrade: osinfo-db version to 20240701

Merge Checklist

All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)

[x] The toolchain has been rebuilt successfully (or no changes were made to it)
[x] The toolchain/worker package manifests are up-to-date
[x] Any updated packages successfully build (or no packages were changed)
[x] Packages depending on static components modified in this PR (Golang, *-static subpackages, etc.) have had their Release tag incremented.
[ ] Package tests (%check section) have been verified with RUN_CHECK=y for existing SPEC files, or added to new SPEC files
[x] All package sources are available
[x] cgmanifest files are up-to-date and sorted (./cgmanifest.json, ./toolkit/scripts/toolchain/cgmanifest.json, .github/workflows/cgmanifest.json)
[x] LICENSE-MAP files are up-to-date (./LICENSES-AND-NOTICES/SPECS/data/licenses.json, ./LICENSES-AND-NOTICES/SPECS/LICENSES-MAP.md, ./LICENSES-AND-NOTICES/SPECS/LICENSE-EXCEPTIONS.PHOTON)
[x] All source files have up-to-date hashes in the *.signatures.json files
[x] sudo make go-tidy-all and sudo make go-test-coverage pass
[x] Documentation has been updated to match any changes to the build system
[x] Ready to merge

Summary

Upgrade: osinfo-db version to 20240701
Build/Dependency Information
osinfo-db-tools
Change Log

SPECS-EXTENDED/osinfo-db/osinfo-db.signatures.json
SPECS-EXTENDED/osinfo-db/osinfo-db.spec
cgmanifest.json

Does this affect the toolchain?

NO
Associated issues

#xxxx

Links to CVEs

https://nvd.nist.gov/vuln/detail/CVE-YYYY-XXXX

Test Methodology

Pipeline build id: xxxx

Updated the changes

@jykanase, Unified buddy build is failing. Can you please look into it and fix the issue.

It is not leaf PR, I will look it after all leaf PR get merged


[FilledInput] WIP, Removed unnecessary paddingTop when there is no label.

This PR is for #13032 (I realized It wasn't related to TextField but instead FilledInput)
I managed to make it work but I used !important. Looking into doing it without !important right now.
update: I won't be able to look at this until next week. Should I close the PR? I'm new to GitHub.

Also probably should've run the tests. whoops

I solved it in a different way. Trying to update the PR right now.

@Manivela You need to change the size limit in ./.size-limit for test_build to pass. Check the CI failure report for more information.

I noticed but wasn't sure if it's okay to change it.

I noticed but wasn't sure if it was okay to change it. Seems like it's there to prevent increasing package size.

We can't just reject changes because they increase the bundle size. But this does help keep track of changes and encourages contributors to rethink their solution to some extent regarding bundle size.

I see, I will update the PR when I get home.


owncloud: update minor versions, init 9.1.1

Motivation for this change
Updated minor Owncloud releases 7 to 9 and added 9.1. Fixes security issues, related to #18856.
I did not test the output files, I just updated the hashes and confirmed that the build does not fail.
Things done

[ ] Tested using sandboxing
(nix.useSandbox on NixOS,
or option build-use-sandbox in nix.conf
on non-NixOS)
Built on platform(s)

[ ] NixOS
[ ] OS X
[x] Linux

[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Fits CONTRIBUTING.md.

Is there good reason to keep all these version of owncloud in our repo?

@grahamc yes, they are sometimes changing compatibility.


Enable golint on the code base

Description
We want to enable golint on our codebase for several reasons:

We want to improve code quality
We need objective filters on quality to help us discriminate bad pull requests

How to
Following is the list of all github.com/docker/docker subpackages. For each we need to:

Submit a PR cleaning all existing golint warnings. One thing to keep in mind is that golint will require that every exported symbol has a comment: favor making symbols private where possible before documenting.
Enable golint on this package as part of the Jenkins CI jobs to make sure we don't diverge (something that individual contributors can do, but @jfrazelle who owns the testing infrastructure will help with that).

We also need to make it easy for contributors to easily give golint a local run before submitting the PR. We should probably have that script only cover a hardcoded list of packages that we can augment over time.
Packages:

[ ] api
[X] api/client (@brahmaroutu - #pending)
[X] api/server (@brahmaroutu - #pending)
[ ] api/types
[ ] builder
[ ] builder/command
[ ] builder/parser
[ ] builder/parser/dumper
[X] cliconfig (@MHBauer - #pending)
[ ] daemon
[X] daemon/events
[ ] daemon/execdriver
[ ] daemon/execdriver/execdrivers
[ ] daemon/execdriver/lxc
[ ] daemon/execdriver/native
[X] daemon/execdriver/native/template
[ ] daemon/execdriver/windows
[ ] daemon/graphdriver
[ ] daemon/graphdriver/aufs
[ ] daemon/graphdriver/btrfs
[ ] daemon/graphdriver/devmapper
[ ] daemon/graphdriver/graphtest
[ ] daemon/graphdriver/overlay
[ ] daemon/graphdriver/vfs
[ ] daemon/graphdriver/zfs
[ ] daemon/logger
[ ] daemon/logger/fluentd
[ ] daemon/logger/gelf
[ ] daemon/logger/journald
[ ] daemon/logger/jsonfilelog
[ ] daemon/logger/syslog
[ ] daemon/network
[X] docker (@sevki - #14764)
[ ] dockerinit
[ ] graph
[ ] graph/tags
[ ] image
[ ] integration-cli
[X] links (@runcom - #14773)
[X] opts (@sevki - #pending)
[X] pkg/archive (@coolljt0725 - #pending)
[X] pkg/broadcastwriter (@coolljt0725 - #pending)
[X] pkg/chrootarchive
[x] pkg/devicemapper
[X] pkg/directory
[X] pkg/fileutils
[X] pkg/graphdb (@coolljt0725 - #pending)
[X] pkg/homedir
[X] pkg/httputils (@coolljt0725 - #pending)
[X] pkg/ioutils (@coolljt0725 - #pending)
[X] pkg/jsonlog (@coolljt0725 - #pending)
[X] pkg/jsonmessage (@coolljt0725 - #pending)
[X] pkg/listenbuffer
[ ] pkg/mflag
[X] pkg/mflag/example
[ ] pkg/mount
[ ] pkg/namesgenerator
[ ] pkg/nat
[X] pkg/parsers (@vdemeester - #14759)
[X] pkg/parsers/filters (@vdemeester - #14759)
[X] pkg/parsers/kernel (@vdemeester - #14759)
[X] pkg/parsers/operatingsystem (@vdemeester - #14759)
[X] pkg/pidfile (@vdemeester - #14759)
[X] pkg/plugins (@vdemeester - #14759)
[X] pkg/pools (@vdemeester - #14759)
[X] pkg/progressreader (@vdemeester - #14759)
[X] pkg/promise
[X] pkg/proxy (@vdemeester - #14759)
[X] pkg/pubsub
[X] pkg/random
[X] pkg/reexec (@LK4D4 - #14762)
[X] pkg/signal (@vdemeester - #14759)
[X] pkg/sockets (@vdemeester - #14759)
[ ] pkg/stdcopy
[X] pkg/streamformatter (@vdemeester - #14759)
[X] pkg/stringid (@vdemeester - #14759)
[X] pkg/stringutils (@vdemeester - #14759)
[X] pkg/symlink
[ ] pkg/sysinfo
[ ] pkg/system
[X] pkg/systemd (@vdemeester - #14759)
[X] pkg/tailfile (@vdemeester - #14759)
[X] pkg/tarsum (@vdemeester - #14759)
[X] pkg/term (@vdemeester - #14759)
[ ] pkg/term/winconsole
[X] pkg/timeoutconn (@vdemeester - #14759)
[X] pkg/timeutils
[X] pkg/tlsconfig
[X] pkg/truncindex (@vdemeester - #14759)
[X] pkg/ulimit (@vdemeester - #14759)
[X] pkg/units (@vdemeester - #14759)
[X] pkg/urlutil
[X] pkg/useragent (@vdemeester - #14759)
[X] pkg/version
[ ] registry
[X] runconfig (@vdemeester - #14751)
[ ] trust
[ ] utils
[ ] volume
[ ] volume/drivers
[ ] volume/local

Hi!
Please read this important information about creating issues.
If you are reporting a new issue, make sure that we do not have any duplicates already open. You can ensure this by searching the issue list for this repository. If there is a duplicate, please close your issue and add a comment to the existing issue instead.
If you suspect your issue is a bug, please edit your issue description to include the BUG REPORT INFORMATION shown below. If you fail to provide this information within 7 days, we cannot debug your issue and will close it. We will, however, reopen it if you later provide the information.
This is an automated, informational response.
Thank you.
For more information about reporting issues, see https://github.com/docker/docker/blob/master/CONTRIBUTING.md#reporting-other-issues

BUG REPORT INFORMATION
Use the commands below to provide key information from your environment:
docker version:
docker info:
uname -a:
Provide additional environment details (AWS, VirtualBox, physical, etc.):
List the steps to reproduce the issue:
1.
2.
3.
Describe the results you received:
Describe the results you expected:
Provide additional info you think is important:
----------END REPORT ---------
#ENEEDMOREINFO

+10k

Oh, I have some work on almost all the pkg. But yeah agree with @runcom, it would be cool (and I think it's already on some other docker project isn't it ?)

@vdemeester Yes, it's enabled on many other docker projects.

This is gonna solve #13782 as well (and there's a comment about updating the contribution guide with a note about how we document fields/funs etc etc)

List of package that already are already linted :

pkg/version
pkg/urlutil
pkg/tlsconfig
pkg/timeutils
pkg/symlink
pkg/random
pkg/pubsub
pkg/promise
pkg/listenbuffer
pkg/homedir
pkg/fileutils
pkg/directory
pkg/chrootarchive

I'm taking pkg/reexec for today.

I'm on these in https://github.com/docker/docker/pull/14759 :

pkg/useragent
pkg/units
pkg/ulimit
pkg/truncindex
pkg/timeoutconn
pkg/term
pkg/tarsum
pkg/tailfile
pkg/systemd
pkg/stringutils
pkg/stringid
pkg/streamformatter
pkg/sockets
pkg/signals
pkg/proxy
pkg/progressreader
pkg/pools
pkg/plugins
pkg/pidfile
pkg/parsers
pkg/parsers/filters
pkg/parsers/kernel
pkg/parsers/operatingsystem

:stuck_out_tongue_closed_eyes:

List updated

taking cliconfig

doing links

doing opts

taking api/client api/server

Listed updated :+1: Thanks!

taking
pkg/archive
pkg/broadcastwriter
pkg/graphdb
pkg/httputils
pkg/ioutils
pkg/jsonlog
pkg/jsonmessage

Thanks all! I just submitted #14780: when this is in we will be able to update the hardcoded list of cleaned up packages as we progress.

doing:

builder
builder/command
builder/parser
builder/parser/dumper

and

daemon/execdriver*

@icecrime I am new to the codebase, would golint integration-cli be a bad place to start?

taking image, graph, graph/tag

would golint integration-cli be a bad place to start?

That is going to be ALOT of work

On Jul 20, 2015, at 22:38, Sergio Botero<EMAIL_ADDRESS>wrote:
@icecrime I am new to the codebase, would golint integration-cli be a bad place to start?
—
Reply to this email directly or view it on GitHub.

@sergiobuj I think integration-cli is a good place to start.
I checked there are not much golint warnings in integration-cli, and for golint warnings, I think the most difficult part is to add comments, because you need to understand how these methods and structs work and why we need them. For integration-cli, you don't need to understand much Docker codebase, just need to know this test framework, so I think new comings can work on that.

@icecrime dockerinit and daemon/events are already linted too (missed them yesterday).

I am learning golang. Using docker since a while. Would this be a good issue to start with to start contributing to docker?

taking  daemon/graphdriver/*
:)

And also want to try api/ and api/types :)

take utils/

taking pkg/nat

and pkg/namesgenerator

Taking volume/* to start the day.

Woah that's impressive :-) I think the list is up to date, thanks all!

doing pkg/mount

:+1: Obviously, I'm definitely in favor of this.
How do you want us to handle golint failures that will cause symbol changes? The following are few that can't be reconciled without changing package interfaces:

Stuttering names (ie. archive.Archive)
Initialisms (use of ID instead of Id, using URL instead of Url)

For the distribution project, we've recommended that people only vendor the package, since the API is not considered stable. I am not sure if docker/docker has made this same recommendation.
I'm in favor of applying the recommendations of golint across the board, even if we have to break interfaces. They make for a cleaner and more consistent code base.

I'll claim the registry package.

I'll take trust 200 alex

took pkg/mflag

daemon/logger and subfriends

We merged #14780 so feel free to add packages to this list as part of your PR to include it naturally in future test runs!

:+1:

taking daemon/graphdriver, daemon/graphdriver/aufs daemon/graphdriver/btrfs

@icecrime Sorry, I said daemon/execdriver*, meant:

daemon/execdriver (@hqhq - #pending)
daemon/execdriver/execdrivers
daemon/execdriver/lxc
daemon/execdriver/native
daemon/execdriver/native/template
daemon/execdriver/windows

Seems daemon/execdriver/native/template is already taken? I'll take the rest, can you update?

taking pkg/sysinfo/

this is awesome everyone, super cool the enthusiasm to help!

One thing to keep in mind is that golint will require that every exported symbol has a comment: favor making symbols private where possible before documenting.

@icecrime Isn't this potentially "backwards-compatible" in that other code outside of Docker might be using exported symbols and break when they're made private? Not sure if this is a legitimate concern or just an overabundance of caution.

Looking at https://godoc.org/github.com/docker/docker we need to add package documentation as well (at least for pkg/* packages).
In #14759 I'll add pkg/term/winconsole

integration-cli: https://github.com/docker/docker/pull/14851
ping @sergiobuj

@peggyl There's not such thing as overabundance of caution :p My take on this is that the Golang dependency model assumes that changes happen on master, and that downstream should vendor and update at their own pace, so I don't think we should bother. Also if those symbols can be made private to Docker itself, then they most likely shouldn't be part of the package interface anyway.

Thank you all! List updated: I'll update the linted list in CI next.

@icecrime well, in the end not doing pkg/term/winconsole, see https://github.com/docker/docker/pull/14759#issuecomment-123843604. We'll wait a bit on this one :stuck_out_tongue_closed_eyes:.

Finished aufs and btrfs I can take the rest as they look similar issues with lint?
daemon/graphdriver/devmapper
daemon/graphdriver/graphtest
daemon/graphdriver/overlay
daemon/graphdriver/vfs
daemon/graphdriver/zfs

@brahmaroutu Please prioritize getting any of your outstanding PR merged, otherwise sure.

@icecrime I am waiting on review atm.

Is there anyone doing graph/tags,pkg/stdcopy and pkg/system, if nobody is handling these, I would like to have a try.
So taking graph/tags,pkg/stdcopy and pkg/system

@WeiZhang555  graph/tag is already picked up by me.

@brahmaroutu OK, then I'll pick pkg/stdcopy and pkg/system, if someone has declared one of these already, please tell me. :smile:

@icecrime What's left? Looks like daemon and graph/tags. I can give those a shot. daemon should be very instructive to document, as a new guy. (I can leave it if that is a better idea).

@MHBauer graph/tags is picked up by @brahmaroutu, so it looks like only daemon is left.

#dibs daemon then

I updated the list, feel free to ping me for any questions

Anything left in this list that I can take up?

@icecrime #15310 daemon complete and merged.

@icecrime a PR will be coming soon (probably this week end) with what is left to be linted and an update on validate-lint too :wink:.


Fix API keys list for certain table names

Fix: Cartodb/support#2165
As the code was before, if a dataset had the same name as any of the lower-cased array methods of JS (https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Array#Methods_2) it would crash.
CC @rubenmoya because we did this together and I'm sure he'll find it funny :joy:

Retest this please

The funny thing is that I was talking to a coworker yesterday about this 😂 I told her there is no need to use hasOwnProperty everywhere... the timing 👌


Updated Unity and Unity.Abstractions version

This is just an update of Unity and Unity.Abstractions references, so there's no conflict when using it along with the latest version of Unity.

Thank you!

Glad to contribute. 😀


added docker-compose support

with this one can use docker and docker-compose to set up a simple dev-environment, means not having nodejs on his computer.
docker-compose run --rm node npm install

calls npm install inside the docker container
docker-compose run --rm node

calls npm test - the default command - and runs all gulp-tasks.
docker-compose run --rm --service-ports node node --debug-brk node_modules/.bin/gulp

calls the gulp-script with node's debug-option. connect your debug-client to localhost:5858.
The option --rm ensures that the container is thrown away after command exits.

Thanks for your help.

Good point, I didn't pay attention.  We should use the alpine-node or official node image.  If @smoebody doesnt submit a follow-up PR, I'll fix it.

im not using the official node image because all commands are run as root. my image creates a user dev which inherits the uid and gid of the user the owner of the project folder. by running all scripts as this user ensures that the project owner is able to delete files created by the docker-process, e.g. node_modules*
my image uses the official node-images though. right now im on it to publish the sources and set up automated docker-builds as well as a proper documentation. if thats the problem of using a non-official image just give me a minute.

How about using --user like and you will be able to delete files created in container?
docker run --user `id -u`

docs: https://docs.docker.com/engine/reference/run/#/user

ok, i wasn't aware of that. i will provide a follow-up PR to fix that

@imZack do you know how to use that within the docker-compose.yml? i cannot get it to work.
if not, i suggest to remove the docker-compse.yml

Updated docker-compose.yml
version: '2'
services:
  node:
    image: node:alpine
    user: ${UID}
    working_dir: /usr/src/app
    volumes:
      - ./:/usr/src/app:z
      - ./npm-cache:/.npm:z
    ports:
      - <IP_ADDRESS>:5858:5858
    environment:
      - NODE_ENV=development
    command:
      - npm test

And commands like below:
UID=`id -u` docker-compose run --rm node npm install
UID=`id -u` docker-compose run --rm node npm test

I think this should work.

Do you mind creating a PR for this?  Also, why Docker Compose and not just a Dockerfile?

i can't get it to run with the docker-compose.yml above.
$ UID=`id -u` docker-compose run --rm node npm install
-bash: UID: readonly variable
WARNING: The UID variable is not set. Defaulting to a blank string.

which leads to the script run as root
when i change the variable name to something like ${USER_ID} i can start the script but npm install tries to create the cache-folder in the containers root-folder because of the absence of an user-folder. he obviously has no rights to write, only way is to create the npm-cache-folder in advance as project owner, which leads to having this folder checked in to the repository which i think is not a good idea.
if we cannot use the practices docker provides we should consider not using it.
so there are three options right now:

use my image
use the official image and run the scripts as root, which leads to files in project-folder you need sudo for
don't use docker at all

@whitlockjc: what do you mean by using a Dockerfile? in my understanding you only need a Dockerfile if you want to create your own image, which you should only do if no other images satisfy your needs or if you want to provide something other images don't.

So you're basically just using Docker Compose to run swagger-tools but not for building an image to distribute?  I'm beginning to think that the Docker Compose support in swagger-tools might not make sense.

I use docker to set up a development testing environment. It is meant to provide nodejs and npm to run the tests and build script in a constant environment.
I do not have all the nodejs versions on my machine. In fact i only have the version distibuted by my linux distro. Docker enables me to instantly switch environments.
Thats my purpose to provide a docker-compose.yml. Yes, Im a docker fanboy :-)
Am 12. Dezember 2016 18:44:27 MEZ, schrieb Jeremy Whitlock<EMAIL_ADDRESS>
So you're basically just using Docker Compose to run swagger-tools
but not for building an image to distribute?  I'm beginning to think
that the Docker Compose support in swagger-tools might not make
sense.
--
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub:
https://github.com/apigee-127/swagger-tools/pull/458#issuecomment-266499057

free art - free mind

I use nvm for that myself but Docker could just as easily be used to do the same.  My concern is that if our Docker support is not generic, we probably shouldn't have it.  If the plan is just to be able to run gulp test or what not within Docker, you could just use the mainstream node images and mount your swagger-tools source directory in the container and run whatever node/npm command you need in it.
I think I'm going to delete the Docker Compose support and instead document how to run tests within Docker.  Would that work?

Im fine with that.
Am 12. Dezember 2016 19:15:01 MEZ, schrieb Jeremy Whitlock<EMAIL_ADDRESS>
I use nvm for that myself but
Docker could just as easily be used to do the same.  My concern is that
if our Docker support is not generic, we probably shouldn't have it.
If the plan is just to be able to run gulp test or what not within
Docker, you could just use the mainstream node images and mount your
swagger-tools source directory in the container and run whatever
node/npm command you need in it.
I think I'm going to delete the Docker Compose support and instead
document how to run tests within Docker.  Would that work?
--
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub:
https://github.com/apigee-127/swagger-tools/pull/458#issuecomment-266507085

free art - free mind


Remove hardcoding in DSP with fileinfo.

Closees #670

@Maria I've created a different ticket for the follow-up: https://github.com/oceanprotocol/ocean.py/issues/680


fix: some install(FILES..) assumed GLFW_BINARY_DIR

The install(FILES ...) command at line#587 mistakenly assumes the default path prefix is CMAKE_CURRENT_BINARY_DIR (where the source files are actually are) while it's CMAKE_CURRENT_SOURCE_DIR.
Before this commit the installation fails with this error message (CMake 3.2.1):
CMake Error at cmake_install.cmake:35 (file):
  file INSTALL cannot find
  "<GLFW_SOURCE_DIR>/lib/cmake/glfw3/glfw3Config.cmake".

As a sidenote, this is the first time I see this separate-build-and-install-config-module feature in action. I'm curious, what is your use case which makes it worth the additional complexity? I mean:

If you're actively working on GLFW (using it in another project), isn't it better to add it as a subdirectory instead of using build-tree config + user package registry?
If you're just using GLFW without modifying it, it's a cleaner approach to use what is installed.

Hi Tomas,
The use case for build tree is project adding dependencies via
externalproject_add, then the targets can be refered to without installing.
Even for relatively simple projects like glfw install times are non-zero ;-)
Regards,
Zibi
On Mon, 8 Jun 2015 at 21:46 Tamas Kenez<EMAIL_ADDRESS>wrote:

As a sidenote, this is the first time I see this
separate-build-and-install-config-module feature in action. I'm curious,
what is your use case which makes it worth the additional complexity? I
mean:

If you're actively working on GLFW (using it in another project),
isn't it better to add it as a subdirectory instead of using build-tree
config + user package registry?
If you're just using GLFW without modifying it, it's a cleaner
approach to use what is installed.

—
Reply to this email directly or view it on GitHub
https://github.com/shaxbee/glfw/pull/4#issuecomment-110001270.

Okay, I removed the check.

shall I squash the two commits into one and issue a new pull-request?

No need. I'll cheery pick and squash them  tomorrow :-)
On Tue, Jun 9, 2015, 16:56 Tamas Kenez<EMAIL_ADDRESS>wrote:

shall I squash the two commits into one and issue a new pull-request?
—
Reply to this email directly or view it on GitHub
https://github.com/shaxbee/glfw/pull/4#issuecomment-110281670.

Cherry picked #4


Kiosk Mode incl Tabs

Hi,
Would be nice to have Kiosk Mode include the tabs.
Then you can switch tabs but nothing else.
Cheers

You can do this. Hide all the buttons and disable the sidebar.


Fix example

This PR fixes the simple_torrent example. It now compiles with 7 warnings and 0 errors. I had to update a few references and function signatures to reflect the latest state of the library.
This change also adds the example to the workspace members in the root Cargo.toml. I don't know if this is appropriate, but it was the only way I could get cargo to build and run (and also get tooling to work in VSCode).

Given the following:

A locally running qBittorrent seeding an Ubuntu ISO
A .torrent file exported from qBittorrent for this torrent

Executing cargo run --release -- -d $DOWNLOAD_DIR -f ubuntu-22.04.1-live-server-amd64.iso.torrent -p <IP_ADDRESS>:14239 results in the torrent being successfully downloaded from qBittorrent.
This does not use the DHT in any shape or form, and only has the ability to connect to a single, specified peer. There's a long way to go before this becomes useful to us, but this changeset is the first step.


is there any method to auto print pdf when pdf file is loaded without click the print button

Attach (recommended) or Link to PDF file here:
Configuration:

Web browser and its version:  firefox v68.0.1
Operating system and its version: mac Mojave
PDF.js version: v2.1.266
Is a browser extension:no

What is the expected behavior? (add screenshot)
auto print pdf when pdf file is loaded
What went wrong? (add screenshot)
I want to use pdf.js to load pdf file and auto print it when the window and pdf file is loaded.
Because there is bugs in firefox to get contentwindow in iframe and then print the window in iframe.
So I use pdf.js to display the pdf file directly, but I encounter a puzzle to auto print the pdf file when it is loaded without click the print button.
If I use <script>window.onload = function() {window.print();}</script> , the chrome popup a print dialog with a blank page, and the firefox do nothing with no warning/error message in console.

    <script>
      (function () {
        function printWhenReady() {
            if (window.PDFViewerApplication && window.PDFViewerApplication.initialized) {
                window.print();
            }
            else {
                setTimeout(printWhenReady, 3000);
            }
        };
        printWhenReady();
      })();
    </script>


Fix Nightly NuGet Feed URL

README seems to show URLs for other NuGet Feed.
I confirmed the url that I changed by the following way.
 nuget search -Source https://pkgs.clangsharp.dev/index.json -PreRelease
====================
Source: https://pkgs.clangsharp.dev/index.json
--------------------
> ClangSharp | 13.0.0-beta2.1545445207 | Downloads: N/A
  ClangSharp are strongly-typed safe Clang bindings written in C# for .NET and Mono, tested on Linux a...
--------------------
> ClangSharp.Interop | 13.0.0-beta2.1545445207 | Downloads: N/A
  ClangSharp are strongly-typed safe Clang bindings written in C# for .NET and Mono, tested on Linux a...
--------------------
> ClangSharp.PInvokeGenerator | 13.0.0-beta2.1545445207 | Downloads: N/A
  ClangSharp are strongly-typed safe Clang bindings written in C# for .NET and Mono, tested on Linux a...
--------------------
> ClangSharpPInvokeGenerator | 13.0.0-beta2.1545445207 | Downloads: N/A
  ClangSharp are strongly-typed safe Clang bindings written in C# for .NET and Mono, tested on Linux a...
--------------------
> LLVMSharp | 12.0.0-beta2.1545446078 | Downloads: N/A
  LLVMSharp is a multi-platform .NET Standard library for accessing the LLVM infrastructure.
--------------------
> LLVMSharp.Interop | 12.0.0-beta2.1545446078 | Downloads: N/A
  LLVMSharp is a multi-platform .NET Standard library for accessing the LLVM infrastructure.
--------------------

I'm glad Nightly Feed has been added, thanks.

Ah yeah, I maintain a few projects and copied the wrong root URL here. My mistake 😄
Thanks for the fix!


Need to shift off of Travis CI by Jun 28, 2019

Switch to running our CI off of Azure DevOps.

I think @tjprescott has actually been working on this. Not sure of current status.


Use of highlight in selectable mouseover is not consistant.

When your mouse is over the back button in the selector, the text and button turns gray to indicate that you can select, and the mouse curser changes.
However, we don't see the same behavior when the mouse is over one of the check boxes.  I would think we would want this to shade gray as well to indicate that you can click, and to be consistant with other selector.

@crisaless do we still have this problem, if not, can we close it?

It's fixed in dev but hasn't been released to staging/production yet.

@crisaless What dev? Is this a common across all projects?

Right, at the time this was opened, it was just facebase - I've looked at other apps and it's working as expected.


Buildcraft Incompatibility

Hello!
The Miner robots from Buildcraft are not recognizing Osmium ore, though they will happily mine Copper and Tin. I was advised to post this here, as the BC team may not be able to fix everything on their end.
https://github.com/BuildCraft/BuildCraft/issues/3189
Thank you very much for your time and energy.

I'm sorry, but I'm fairly certain this is not on my end- Mekanism's osmium ore is registered with the "ore" prefix, otherwise my Digital Miner wouldn't be able to mine it.  Let me know if I can help in any other way.


Code crashes / slows down after a period of time

After using VS Code for a while, it gets slower and slower. I notice it particularly when it attempts to auto-complete.
It will then sometimes crash. It may crash whilst I'm using it. It may crash when I haven't used it for sometime but using another window. It may crash if I leave the PC overnight. It may crash if I only used it for a very short amount of time and the slowdown above hadn't occurred.
Looking at the Windows Task Manager does not show it using any more memory at this time (it peaks at around 38MB and never goes above 1% CPU although is usually at 0%). The PC has plenty of resources/memory free.
Unfortunately I can't find a pattern. It is worse now though than it was when it first started occurring several releases ago.
I just get a dialog "Visual Studio has crashed. We are sorry for the inconvenience! Please restart Visual Studio Code." and no other indication as to the cause.
Code v0.10.6, issue has occurred since around v0.3
Windows 8.1, i7-4770 with 16GB RAM. SSD disk.
Git repository contains over 39,000 files across folders at various levels deep. These are mostly HP BASIC .BAS (OpenVMS files which we maintain on Windows) plus bespoke 4GL files.
I don't use any of the git functionality within Code, I do commits etc externally.
I use Ctrl+E frequently to find/open files.
Shift+Ctrl+B runs a windows .bat file to transfer and compile the code
settings.json:  "editor.insertSpaces": true, "files.trimTrailingWhitespace": true

Probably a duplicate of https://github.com/Microsoft/vscode/issues/508

Looking at the Windows Task Manager does not show it using any more memory at this time (it peaks at around 38MB

Add the "Commit Size" column and check that. The default memory column is only private working set.

Yeah, #508

I see this is now marked as a duplicate, but just to follow up from @Elusive138, I've now added the commit size to the task manager and I see it does increase over time (regardless of whether I'm using Code or not).
It's currently at 300MB and rising. Code has only had a little use this morning.


Errors when trying to build label_image neural net with bazel

Environment info
Operating System: El Capitan, 10.11.1
I'm doing this tutorial: https://petewarden.com/2016/09/27/tensorflow-for-mobile-poets/
Trying to classify images using tensorflow on iOS app.
When I try to build my net using bazel:
bazel build tensorflow/examples/label_image:label_image
I get these errors:
https://gist.github.com/galharth/36b8f6eeb12f847ab120b2642083a732

Any help 🙏 ?

@petewarden
When I run it on the docker machine (tensorflow/tensorflow:nightly-devel) this is what I get:
gcc (Ubuntu 4.8.4-2ubuntu1~14.04.3) 4.8.4
Copyright (C) 2013 Free Software Foundation, Inc.
This is free software; see the source for copying conditions.  There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.

On my machine I get:
Configured with: --prefix=/Applications/Xcode.app/Contents/Developer/usr --with-gxx-include-dir=/usr/include/c++/4.2.1
Apple LLVM version 7.3.0 (clang-703.0.31)
Target: x86_64-apple-darwin15.6.0
Thread model: posix
InstalledDir: /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin

Ah, I missed that the step was within the docker container, gcc makes sense there. Have you made sure that the virtual machine has enough memory assigned to it?

How much memory the virtual machine needs? this is my current docker preferences: http://d.pr/i/YCUl
(2 cpus, 2 GB RAm)

2GB is tight for Bazel unfortunately. As a start, I would try ramping that up, and there are also some options to make Bazel only build one source file at a time, which helps, but I don't have those handy.

Closing due to lack of activity but please reopen if this isn't a memory issue.


Added correct exception handling for discovery of Metadata apis

Description
Following #486
There seems to be an exception risen when requesting AWS metadata server when running under GKE clusters.
For some reason exception handling there was lacking, and caught only connection timeout Exceptions.
Now added general except  for all metadata api discoveries.
Fixed Issues
Fixes #486
Contribution checklist

[ ] I have read the Contributing Guidelines.
[ ] The commits refer to an active issue in the repository.
[ ] I have added automated testing to cover this case.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Synchronous hash counter access from request registry.

Fixes https://github.com/bblimke/webmock/issues/606
We had the same
can't add a new key into hash during iteration

issue in our specs, and I think the issue above did capture the cause.
My naive try here seemed to fix the problem for us, but as I don't fully understand the details, this may not be a good solution. Still thought I would PR it and get feedback. Happy to iterate on this and add some specs.

@starsirius Thank you!
The solution looks fine to me.
Are you able to provide a deterministic spec to reproduce the problem?
It would be best to hide the mutex logic inside the Hashcounter,
and not expose that to request_registry.
Perhaps instead of .hash.select there should be a safe select method defined on Hashcounter,
or some kind of safe Enumerator exposed.

Thanks for the comments, @bblimke! I will find some time add a spec and better encapsulate the mutex logic in Hashcounter.

Great! The spec failed with expected can't add a new key into hash during iteration runtime error on Travis. Going to work on the fixes next!

@bblimke Apologies for the delay. I updated the PR with your comments. Let me know how you think about this or want me to clarify anything. Thanks!

@starsirius Thank you! Well done. I can see it has been very tricky to reproduce it.

Hi @bblimke Looks like we have some good stuff for a new version. Do you think it's safe to release v2.3.3 soon? Thanks!


Fix bugs

There was an error in how QuestionList pydantic model was working
Generated tokens were not being extracted correctly
Integration tests were commented out
Integration tests needs to have default model set

Note to self:
The Interview example seems to be using the test model but isn't having answers over-ridden by the direct response method of the agent:
421         >>> i = Interview.example(throw_exception = True)
422         >>> result, _ = asyncio.run(i.async_conduct_interview())
Expected nothing
Got:
    QuestionAnswerValidationError(1 validation error for ChoiceResponse
    answer
      Input should be 'yes' or 'no' [type=literal_error, input_value='Hello world', input_type=str]
        For further information visit https://errors.pydantic.dev/2.8/v/literal_error)
            Data being validated: {'answer': 'Hello world', 'generated_tokens': 'Hello world', 'comment': None}
            Pydnantic Model: <class 'edsl.questions.QuestionMultipleChoice.create_response_model.<locals>.ChoiceResponse'>.
            Reported error: 1 validation error for ChoiceResponse
    answer


Setting precedence on jobs

We are trying to model our dispatching problem to use the vehicle routing paradigm. We have two kinds of jobs: pickups and returns. Returns are orders where we return objects to customers. Pickups are orders where we pickup objects from customers.
On a given day, we want to dispatch orders that are mix of these two types. Ideally, we want service the returns first and only get do the pickups. Most of the time, the time window constraints are specified in this manner, i.e Returns can be scheduled between 7am to 9am. Pickups can be scheduled from 9am to 11am. Only rare occasions to meet supply, we do  returns at 11am as well.
I want to the following constraint: for every route, return orders should performed before the pickup orders. I tried adding a PickupAndDelivery constraint, to each of the return and pickup order pairs, but that seems wrong, and expectedly the solver isn't able to solve.
Is there a way to specify the above constraint ?
Here is a snippet of our code:
def get_google_distance(locations):
  distance_matrix = {}
  drive_times_matrix = {}
  num_locations = len(locations)

  google_key = os.environ['GOOGLE_DISTANCE_MATRIX_API_KEY']
  client = googlemaps.Client(google_key)
  for from_node in xrange(num_locations):
    distance_matrix[from_node] = {}
    drive_times_matrix[from_node] = {}
    for to_node in xrange(num_locations):
      result = client.distance_matrix(locations[from_node], locations[to_node])
      distance_matrix[from_node][to_node] = result['rows'][0]['elements'][0]['distance']['value']
      drive_times_matrix[from_node][to_node] = result['rows'][0]['elements'][0]['duration']['value']
  return [distance_matrix, drive_times_matrix]

class CreateDistanceCallback(object):
  """Create callback to calculate distances and travel times between points."""
  def __init__(self, distance_matrix):
    self.matrix = distance_matrix

  def Distance(self, from_node, to_node):
    return int(self.matrix[from_node][to_node])

# Service time (proportional to demand) callback.
class CreateServiceTimeCallback(object):
  """Create callback to get time windows at each location."""

  def __init__(self, demands, time_per_demand_unit):
    self.matrix = demands
    self.time_per_demand_unit = time_per_demand_unit

  def ServiceTime(self, from_node, to_node):
    # print self.matrix[from_node] * self.time_per_demand_unit
    return self.matrix[from_node] * self.time_per_demand_unit

class CreateTravelTimeCallback(object):
  """Create callback to get travel times."""

  def __init__(self, travel_times_matrix):
    self.matrix = travel_times_matrix

  def TravelTime(self, from_node, to_node):
    return (self.matrix[from_node][to_node] * 1.3)

# Create total_time callback (equals service time plus travel time).
class CreateTotalTimeCallback(object):
  def __init__(self, service_time_callback, travel_time_callback, parking_overhead):
    self.service_time_callback = service_time_callback
    self.travel_time_callback = travel_time_callback
    self.parking_overhead = parking_overhead

  def TotalTime(self, from_node, to_node):
    service_time = self.service_time_callback(from_node, to_node)
    travel_time = self.travel_time_callback(from_node, to_node)
    return float(service_time) + float(travel_time) + self.parking_overhead

def get_solution(data, date, region_name):
  begin = datetime.datetime.now()
  order_ids = data[0]
  demands = data[1]
  start_times = data[2]
  complete_locations = data[3]
  num_locations = len(order_ids)

  # Assume number of vehicles is not a problem
  depot_locations = data[8]
  num_vehicles_per_depot = 10
  num_vehicles = num_vehicles_per_depot * len(depot_locations)
  depot = []
  for i in xrange(len(depot_locations)):
    for j in xrange(num_vehicles_per_depot):
      depot.append(i)

  parking_duration = 15 * 60
  if (region_name == "New York"):
    parking_duration = 20 * 60
  wrap_up_duration = 10 * 60
  parking_overhead = parking_duration + wrap_up_duration

  # Subtract the parking duration time from an order's start time
  for order_start_time in start_times:
    order_start_time = order_start_time - parking_duration

  print "Number of orders", num_locations

  [distance_matrix, drive_times_matrix] = get_google_distance(complete_locations)

  # Create routing model.
  if num_locations > 0:

    # The number of nodes of the VRP is num_locations.
    # Nodes are indexed from 0 to num_locations - 1. By default the start of
    # a route is node 0.
    routing = pywrapcp.RoutingModel(num_locations, num_vehicles, depot, depot)

    # Setting first solution heuristic: the
    # method for finding a first solution to the problem.
    # The 'PATH_CHEAPEST_ARC' method does the following:
    # Starting from a route "start" node, connect it to the node which produces the
    # cheapest route segment, then extend the route by iterating on the last
    # node added to the route.
    search_parameters = pywrapcp.RoutingModel.DefaultSearchParameters()
    search_parameters.first_solution_strategy = (
      routing_enums_pb2.FirstSolutionStrategy.PATH_CHEAPEST_ARC)

    # Put callbacks to the distance function and travel time functions here.

    # Callback to the distance function.
    dist_between_locations = CreateDistanceCallback(distance_matrix)
    dist_callback = dist_between_locations.Distance
    routing.SetArcCostEvaluatorOfAllVehicles(dist_callback)

    time_per_demand_unit = 1
    service_times = CreateServiceTimeCallback(demands, time_per_demand_unit)
    service_time_callback = service_times.ServiceTime

    travel_times = CreateTravelTimeCallback(drive_times_matrix)
    travel_time_callback = travel_times.TravelTime

    total_times = CreateTotalTimeCallback(service_time_callback, travel_time_callback, parking_overhead)
    total_time_callback = total_times.TotalTime

    # Adding capacity dimension constraints.
    capacities = []
    for i in xrange(num_vehicles):
      capacities.append(10*3600)

    capacity_string = "Capacity"
    routing.AddDimensionWithVehicleCapacity(
      total_time_callback,
      0, # null capacity slack
      capacities, # vehicle maximum capacities
      True, # start cumul to zero
      capacity_string)

    # Adding time dimension constraints.
    horizon = 17 * 3600
    time_string = "Time"

    # SLA window
    tw_duration = 3 * 3600

    # Add a dimension for time-window constraints and limits on the start times and end times.
    fix_start_cumul_to_zero = False
    routing.AddDimension(total_time_callback,  # total time function callback
                         horizon,
                         horizon,
                         fix_start_cumul_to_zero,
                         time_string)

    # Add limit on size of the time windows.
    time_dimension = routing.GetDimensionOrDie(time_string)

    for order_idx in xrange(1, num_locations):
      start = start_times[order_idx]
      time_dimension.CumulVar(routing.NodeToIndex(order_idx)).SetRange(start, start + tw_duration)

    # Solve displays a solution if any.
    assignment = routing.SolveWithParameters(search_parameters)
   print(assignment, routing, data)

Thanks!

try to add
solver=routing.solver()
and
solver.Add(time_dimension.CumulVar(returnnodeindex) <= time_dimension.CumulVar(pickupnodeindex))
in nested loops on your pickup/return nodes
also capacity dimension can be helpful

Thanks for the help. I added that exactly but the solver wasn't able to find a solution.
Is there a way to add a constraint to indicate that we need the returns before pickups only when they are in a route together ?

please look at https://github.com/google/or-tools/issues/847#issuecomment-420608114


[Bug]: Dataflow Example Java11/17 PreCommits actually running on Java 8 container

What happened?
It has puzzled me when doing #28967, after compiling the example with Java11/17, Dataflow gives unsupported Java version error. Digging into the log one can see
Downloaded container image us-central1-artifactregistry.gcr.io/google.com/dataflow-containers/worker/v1beta3/beam-java-streaming:20231008-20-rc00 checksummed successfully.

which means a Java 8 container is used, even though the test is running on Java17 and the latest dev container version is 20231026
It has been working so far because currently the examples are still compiled on Java8, and the test (compile and submitted by Java17) is only a thin wrapper of the former
Issue Priority
Priority: 2 (default / most bugs should be filed as P2)
Issue Components

[ ] Component: Python SDK
[X] Component: Java SDK
[ ] Component: Go SDK
[ ] Component: Typescript SDK
[ ] Component: IO connector
[ ] Component: Beam YAML
[ ] Component: Beam examples
[ ] Component: Beam playground
[ ] Component: Beam katas
[ ] Component: Website
[ ] Component: Spark Runner
[ ] Component: Flink Runner
[ ] Component: Samza Runner
[ ] Component: Twister2 Runner
[ ] Component: Hazelcast Jet Runner
[ ] Component: Google Cloud Dataflow Runner

Found that the cause is here:
https://github.com/apache/beam/blob/7b38f743f78812fd240e2245abc490e6cb8997ed/runners/google-cloud-dataflow-java/examples/build.gradle#L102
It assigns an empty string to workerHarnessContainerImage pipeline option. This has caused Dataflow to use an old container in us-central1-docker.pkg.dev/google.com/dataflow-containers/worker/v1beta3/beam-java-streaming
This might be an internal bug. Removing this line, the tag for container is determined by


feat(origin-ui-core): UI Feature Flags

Restrict navigating to URLs for non-enabled features
Show links in menus and sub-menus depending on the enabled features

Rebasing it to clean up commit historyl.

Rebase done. Can be reviewed.


New _put_object_stream_with_content_type doesn't work for larger files.

Describe the bug
The new implementation of _put_object_stream_with_content_type introduced in 0.33.0 creates various issues for larger files. The implementation now loads all chunks and then tries to upload them in parallel, this means:

the whole file now gets loaded into memory, which is undesirable for large files and defeats the purpose of having a put_object_stream funtion in the first place
uploads for large files straight up fail with the following error: An error occurred connecting to S3: reqwest: error sending request for url (...): connection error: An existing connection was forcibly closed by the remote host. (os error 10054), I didn't look into this enough yet to determine the exact error, but my assumption is that trying to upload too many parts at once might cause certain uploads to starve and stay inactive for too long, causing S3 to drop the connection. For me this is consistently reproducible with files over 2-3 GB though it might depend on bandwidth

I rolled back to 0.32 for now, which immediately fixes both of these issues.
To Reproduce
Upload a large file (2GB or larger)
Expected behavior
put_object_stream should not load the entire file into memory (or it should at least offer a separate function or parameter that doesn't) and should not fail for larger files
Environment

Rust version: 1.69.0
lib version: 0.33.0

Should be fixed in 0.34

@durch I'm not OP, but also affected by this issue. Are you sure that it's fixed? From a first look, the code still seems to load all chunks into memory and send unlimited requests in parallel to S3. Will do some more thorough testing when upgrading the dependency.

Haven't tried it yet, but the linked commit does change it so that it waits for a previous chunk to be uploaded when there are three or more chunks being uploaded at the same time. If there are 3 or more upload handles, it will wait for an upload to complete before starting the next one (and before reading the next chunk). It should kinda fix this, but it seems like a weird solution. If the reader is very slow, it would probably still result in the same problem where the second upload does not receive any data for too long and time out.
I don't really understand the point of collecting multiple chunks to upload them in parallel to begin with. In almost all cases, the bottleneck is upload bandwidth. Uploading multiple chunks at once doesn't make it faster, just like downloading all files at once isn't faster than downloading one after the other, provided that the bandwidth is bottlenecked on your end. You'll just split bandwidth between chunks instead of uploading each one at full bandwidth.
Why not just upload each chunk as soon as it is read, just like before? When uploading a file from disk, reading each chunk is much faster than uploading it, so I can kinda see the idea behind reading several chunk quickly and uploading them at same time (though again, I doubt there is much benefit to that because it will just make each individual upload slower). But in my use case, the reader is a file upload to my server which is then streamed to S3. That uploader might be on terrible internet, in which case reading the chunk would be much slower than uploading them. In this case this approach makes even less sense. In my mind, the only way uploading chunks in parallel makes sense, is if they are also read in parallel, which they are not and my case can't be.
If there is a use case for uploading chunks in parallel that I'm not seeing, I at least think there should be a separate function that goes back to the original behaviour and simply uploads each chunk after reading it to avoid unnecessary complexity that isn't needed and may even break other use cases.
Another thing I noticed, what happens if the file size is a multiple of CHUNK_SIZE? chunk.len() < CHUNK_SIZE would be false for the last chunk, so done = false and the loop would not terminate. Will the next iteration read and upload 0 bytes? Would that cause an error?

@robinfriedli Note that the linked commit isn't in master, it's my attempt to fix this bug, and still located in a separate repo.
Re uploading sequentially or in parallel: For a sufficiently fast connection, there is probably no benefit in uploading in parallel. I'm not sure if there is a benefit for slow connections (e.g., when TCP ACKs are delayed it might impact speed?), thats why I kept the logic in there for now. But you're right, if it isn't actually necessary for performance reasons, the whole function can be simplified quite a bit.
You're also right that the logic regarding chunk.len() < CHUNK_SIZE is probably incorrect. I'm not sure if it will fail or just do an unnecessary 0 byte upload, but I'll check that and update my branch if necessary.

@lackner-codefy oh true, I didn't even check if it was merged. That makes no sense then, I see no change that would fix this.


Small typo correction

:)

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.


Auto reloading new versions of captive core relies on last modified timestamp which may be faulty

In https://github.com/stellar/go/issues/3602 we implemented a feature in horizon which restarts captive core when a new version of captive core is detected on disk. The feature relied on last modified file timestamps to determine if the captive core binary was updated. However, when stellar core is installed via the debian packages the last modified timestamp of the binary is determined from the debian package changelog which is set to Nov 2018 for all versions of stellar core since 9.2.0-9.
Since the last modified timestamp is the same, horizon is not able to detect that captive core should be restarted. To make Horizon more robust to last modified timestamps we can instead use file hashes as the heuristic for determining if the captive core binary has been modified.

Fixed in https://github.com/stellar/go/pull/4050


Added shortcut re-designation ui feature

Can you add a function to reassign those shortcuts?

I'll see what I can do

Thank you for your efforts.
If it's a long or difficult skill, you don't have to do it.


goose keeps remembering old file content

Even though it knows file has changed, it is unable to "forget" the old content of the file from its context.
Result: often old unwanted changes make their way back into a file, if you have edited it outside of the goose session.
Solution: probably need to prune past content of the file in the current session once it is detected to have changed, if at all possible.

I think this may be able to be addressed with a moderator: a moderator which drops old content smartly especially if it knows there is a new version of the file.

Agree! pruning reads from the history based on path probably improves performance and should also drop context naturally quite a bit


Mount repo server token

This adds the ability to specify mounting the serviceaccount token to the repo-server pod as well as specifying the serviceaccount it should run as. This can be done by adding the following to the ArgoCD CR:
...
spec:
  repo:
    mountsatoken: true
    serviceaccount: argocd-application-controller
...

Resolves #110

LGTM

These are not working for me.  It never updates the corresponding deployment with either value.  Any ideas?
repo:     mountsatoken: true     serviceaccount: vault-secret-read ...     ... ...
Openshift: v4.10
Openshift Gitops Operator: v1.5.5
ArgoCD Vault Plugin: v1.12

securityContext:
  runAsUser: 999

is also not configurable from argocd CR


Export appvars

Can we please fix appvar exportation and add something to the toolchain to make it easy to read things? Thanks.

Looks good :+1:


auto-execute jupyter notebooks on change

github actions should execute the notebooks newly. or even RTD itself. but essentially want to actually BUILD the few notebooks I do have. this would also let me not leave executed notebooks in the repo, which currently bloats repo size.

this is somewhat working. can't quite get the conf.py to import cortecs. and i don't want it pip installed!

almost done — now just have weird progress bars.


How to execute the code

hi,
i read the blog but i am still trying to understand how to execute the code. I get this error when i hit f5 on visual studio

I need to migrate workitems only. Can you please help/

You need to specify the processor to run. For the work item processor you'd use
TfsMigrate -processor WorkItemTracking

Note that work items by definition need the areas and iterations to be imported as well (or already defined) so either ensure the area/iterations are already defined or configure them to be migrated as well.


Compiling ASP.NET Core 2.x application while targeting .NET Core 3.0

As the question says, is it possible to Target .NET Core 3.0 while still using ASP.NET Core 2.x? It looks like libraries in ASP.NET Core 2.x is compiled using .NET Standard 2.0. So far i cannot figure out how to get this to work. I have tried explicitly setting the version of "Microsoft.AspNetCore.App" package to 2.x but it still was using ASP.NET Core 3.0

Possible? Yes. Difficult? Yes. Tested? No.
Why?

I read that there are a lot of performance improvements in .NET Core 3.0 + improved docker images for container workloads. For me, we have a dependency on OData, which is currently only available in ASP.NET Core 2.1, or 2.2 with backwards compatibility flag enabled.
From my understanding, several of the perf improvements are low level APIs, which means that we can reap those benefits by just moving to the .NET 3.0 runtime. Or would it be possible to run a .NET Core 2.x application in .NET Core 3.0 runtime and get those benefits?


Doesn't appear to work anymore

Posted on the thread on Home-Assistant.io thread but raising it here too.
Long story short.
fauxapi works fine from my MacBook, can pull the config through, rules etc so the key and secret are correct.
HomeAssistant pulls the rule through as a switch OK even though there are loads of errors in the log showing
Problem retrieving rule set from pfSense host: X.X.X.X. Likely due to API key or secret.

The switch doesn't work though, soon as you toggle it you get an error which is as follows;
'tracker'
Traceback (most recent call last):
  File "/usr/src/homeassistant/homeassistant/components/websocket_api/commands.py", line 130, in handle_call_service
    connection.context(msg),
  File "/usr/src/homeassistant/homeassistant/core.py", line 1260, in async_call
    task.result()
  File "/usr/src/homeassistant/homeassistant/core.py", line 1295, in _execute_service
    await handler.func(service_call)
  File "/usr/src/homeassistant/homeassistant/helpers/entity_component.py", line 209, in handle_service
    self._platforms.values(), func, call, required_features
  File "/usr/src/homeassistant/homeassistant/helpers/service.py", line 454, in entity_service_call
    future.result()  # pop exception if have
  File "/usr/src/homeassistant/homeassistant/helpers/entity.py", line 595, in async_request_call
    await coro
  File "/usr/src/homeassistant/homeassistant/helpers/service.py", line 485, in _handle_entity_call
    await result
  File "/usr/src/homeassistant/homeassistant/helpers/entity.py", line 621, in async_turn_on
    await self.hass.async_add_executor_job(ft.partial(self.turn_on, **kwargs))
  File "/usr/local/lib/python3.7/concurrent/futures/thread.py", line 57, in run
    result = self.fn(*self.args, **self.kwargs)
  File "/config/custom_components/pfsense_rule/switch.py", line 126, in turn_on
    self.set_rule_state(True)
  File "/config/custom_components/pfsense_rule/switch.py", line 171, in set_rule_state
    if (rule['tracker'] == self._tracker_id):
KeyError: 'tracker'

Am I missing something obvious?
No error logs on the pfSense host either.
Running the following;
Home Assistant 0.112.4
pfSense 2.4.5-RELEASE-p1

There's some info here that may help you get it working again.  It fixed my issue after mine stopped working.


fix: getresource with wrong kbs uri

The port field will be ignored when parse a kbs uri before. This will make the kbc fail to connect to a kbs. As it only receives ip rather than ip:port socket address.

By default we use kbs:///... now and the uri here does not have a kbs-addr field. But in get_resource API, image-rs will automatically fill kbs-addr field and send to attestation-agent https://github.com/confidential-containers/image-rs/blob/main/src/resource/kbs/mod.rs#L152. Although this process is transparent to the user, attestation-agent should also parse the port field of the resource uri, which is ignored before. As a bug, this PR fixes to include the port field if a resource uri has.


docs: tutorials are moved on the top-level of docs

Added Tutorials section on the top-level of documentation
Problem Statement: the Tutorials section in the documentation is top-priority. Not every project has resources to make tutorials. We have such a privilege. Community experts created several tutorials on YouTube.
But the tutorial links are now hidden on the YouTube page and not easily discovered by first-time visitors.
PR: I've created the Tutorials page (from the Additional Resources/YouTube page) and moved it to the top level of documentation in the Getting Started section.
Who can review?
    @dev2049

NOTE:
PR checks are randomly failing
https://github.com/hwchase17/langchain/pull/4464/commits/3aefaafcdbb6312f2963163a69874e77d84c63dd
https://github.com/hwchase17/langchain/pull/4464/commits/258819eadfbc45cb0959b187132bd51321ca7370
https://github.com/hwchase17/langchain/pull/4464/commits/514d81b5b3aa12eeed1e8a6eca8d86126697781c

@dev2049  Davis, could you, please, review it? TNX!

@hwchase17
@dev2049
@vowelparrot
Gentle remainder. Can you, please, review it? Thanks


Apparent Divergence of View-Only Link File Downloads

This is a problem that a user found.

Make a view-only link
Try to download files from "Files" tab
Try to download files from the individual file's page

We expect to be able to download files from both the "Files" tab and the individual file's page.
We found that we could only download files from the "Files" tab, and that trying from the individual file's page leads to:

Michael is on this -- TY @icereval !

:+1:

@KatyCain526 This should now be fixed. Can you verify?

ping @KatyCain526

@KatyCain526 -- H

@KatyCain526 -- Hey, can you double check this is no longer an issue? TY

Jah. This is no longer a problem :D


multipart/form-data field names are changed after I set them :-(

Why are you adding a counter to the field name of the multipart/form-data object?
https://github.com/kittinunf/Fuel/blob/d29f5f61223b073553655b20e65b2aa69bb619e4/fuel/src/main/kotlin/com/github/kittinunf/fuel/core/requests/UploadTaskRequest.kt#L20
It's perfectly valid to have multiple field names with the same value: https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Content-Disposition
It's even so that libraries like node-multer use that name to create an array of incoming files.

Never mind, found a way to get around it:
"http://<IP_ADDRESS>:3000/api/pictures".httpUpload(Method.POST, bodyParameters).blobs { request, url ->
            for (blob in blobs) {
                request.names.add("pictures")
            }
            blobs
        }


copyBinaries: use struct{} and isDir

Please provide a description of this PR:
use struct{}{} and determine whether it is a folder in advance

Hi @helen-frank. Thanks for your PR.
I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test label.
I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.


[Bug]: Design token themed folder cannot be published out of the box.

Package version
^3.0.74
node-versions
16.13.2
npm-versions
8.1.2
Description
In the documentation (https://cloudscape.design/foundation/visual-foundation/theming/) at the bottom it states the following:
After building the themed version of the artifacts, you will have two options:

Publish the /components and /design-tokens folders as new packages (recommended)
Use the output as a local NPM dependency: extend the dependencies section in your package.json file by "@cloudscape-design/components-themed": "file:/components and "@cloudscape-design/design-tokens-themed": "file:/design-tokens". Run the npm install command afterwards.

Regardless of either option you cannot simply publish the packages I think there is a gap in the documentation that needs to explicitly state there is more work required to publish or use the packages.
Ultimately, the design tokens are my focus here and there is no package.json file created in the design-tokens folder to even publish a package once you have run the buildThemedComponents function.  In addition everything is named visual-refresh.xxx.  By convention it would be my recommendation to name the .d.ts, .scss and .js files to index.xxx and follow the same convention you do for the standard design-tokens library.
Source code
No response
Code of Conduct

[X] I agree to follow this project's Code of Conduct
[X] I checked the current issues for duplicate problems

Hi @jwwheeleriv, thanks for reporting! I was able to reproduce the issue locally. We'll investigate and keep this issue updated about findings.


Error on import of treetrace in with python 3.12.3

Importing treetrace (directly or via importing interlab) on Python 3.12.3 (Ubuntu 24.04) raises the following error.
Interlab version is interlab 0.4.1, installed via poetry in a virtual environment.
Importing interlab and treetrace work fine in Python 3.10.14 and Python 3.11.9.
Python 3.12.3 (main, Apr 10 2024, 05:33:47) [GCC 13.2.0] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> import treetrace
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/home/gavento/proj/ai-ai-bias/.venv/lib/python3.12/site-packages/treetrace/__init__.py", line 12, in <module>
    from .ui.console_server import ConsoleServer
  File "/home/gavento/proj/ai-ai-bias/.venv/lib/python3.12/site-packages/treetrace/ui/console_server.py", line 13, in <module>
    from .server_handle import PATH_TO_STATIC_FILES, ServerHandle
  File "/home/gavento/proj/ai-ai-bias/.venv/lib/python3.12/site-packages/treetrace/ui/server_handle.py", line 8, in <module>
    from .staticfiles import PATH_TO_STATIC_FILES
  File "/home/gavento/proj/ai-ai-bias/.venv/lib/python3.12/site-packages/treetrace/ui/staticfiles.py", line 6, in <module>
    with resources.path(browser, ".") as static_path:
         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/lib/python3.12/importlib/resources/_legacy.py", line 25, in wrapper
    return func(*args, **kwargs)
           ^^^^^^^^^^^^^^^^^^^^^
  File "/usr/lib/python3.12/importlib/resources/_legacy.py", line 120, in path
    return _common.as_file(_common.files(package) / normalize_path(resource))
                           ~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~
  File "/usr/lib/python3.12/importlib/resources/abc.py", line 133, in __truediv__
    return self.joinpath(child)
           ^^^^^^^^^^^^^^^^^^^^
  File "/usr/lib/python3.12/importlib/resources/readers.py", line 92, in joinpath
    return super().joinpath(*descendants)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/lib/python3.12/importlib/resources/abc.py", line 117, in joinpath
    target = next(names)
             ^^^^^^^^^^^
StopIteration
>>>

@spirali Would you know what is up with this bug? It is quite serious, as it is a blocker for even importing any part of interlab.


delete a illegal code in fr/docs.

I found the illegal code in fr/docs. The character code is 0x1c.
When I saw it Chrome browser or Microsoft Edge browser, the character was displayed as rectangle.
I checked all files in fr/docs and I couldn't find the other.
Update files:
fr/docs/concepts/cluster-administration/logging.md

Thank you for your PR. Looks good to me.

/assign @jygastaud
Could you please review?

/assign @remyleone
Could you please review?

/lgtm
/approve


[suggestion] ContentTweaker support

contenttweaker lets you manually add in brand new chickens, which are automatically picked up by roost, but they all lack textures and any attempt to hack them in manually via resourcepacks/loaders seems to be failing

Fixed.


Random missing body Ada appeared in place of RE3R Carlos in a cutscene

Version
3.1.8 (2f583cd)
Seed
R720-3JVR-ZXHH20N559YV007JVKXTM5JMCTJGGQZPZZQZXZZTEYYZZZZZZ
Scenario
RE 2 (Leon A)
Player Character
Lott
What happened?
Like 3 rooms into the seed I got to the area in the lab where Ada's fall death happens. I placed the fuse, and headed down the red bridge, cutscene starts, all of RE3R Carlos's voices are playing, and a bodyless Ada appeared. Note I had both Ada's turned off as NPC's so it was pretty bizarre. Didn't include a save since it was pretty much right at the start of the rando.

I wasn't able to reproduce this. Carlos was there, not Ada and the cutscene played correctly.