[SPARK-34610][PYTHON][TEST] Fix Python UDF used in GroupedAggPandasUDFTests.

What changes were proposed in this pull request?
Fixes a Python UDF plus_one used in GroupedAggPandasUDFTests to always return float (double) values.
Why are the changes needed?
The Python UDF plus_one used in GroupedAggPandasUDFTests is always returning v + 1 regardless of its type. The return type of the UDF is 'double', so if the input is int, the result will be null.
>>> df = spark.range(10).toDF('id') \
...             .withColumn("vs", array([lit(i * 1.0) + col('id') for i in range(20, 30)])) \
...             .withColumn("v", explode(col('vs'))) \
...             .drop('vs') \
...             .withColumn('w', lit(1.0))
>>> @udf('double')
... def plus_one(v):
...   assert isinstance(v, (int, float))
...   return v + 1
...
>>> @pandas_udf('double', PandasUDFType.GROUPED_AGG)
... def sum_udf(v):
...   return v.sum()
...
>>> df.groupby(plus_one(df.id)).agg(sum_udf(df.v)).show()
+------------+----------+
|plus_one(id)|sum_udf(v)|
+------------+----------+
|        null|    2900.0|
+------------+----------+

This is meaningless and should be:
>>> @udf('double')
... def plus_one(v):
...   assert isinstance(v, (int, float))
...   return float(v + 1)
...
>>> df.groupby(plus_one(df.id)).agg(sum_udf(df.v)).sort('plus_one(id)').show()
+------------+----------+
|plus_one(id)|sum_udf(v)|
+------------+----------+
|         1.0|     245.0|
|         2.0|     255.0|
|         3.0|     265.0|
|         4.0|     275.0|
|         5.0|     285.0|
|         6.0|     295.0|
|         7.0|     305.0|
|         8.0|     315.0|
|         9.0|     325.0|
|        10.0|     335.0|
+------------+----------+

Does this PR introduce any user-facing change?
No, test-only.
How was this patch tested?
Fixed the test.

Test build #135724 has started for PR 31730 at commit 0a4b4d4.

Test build #135724 has finished for PR 31730 at commit 0a4b4d4.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/135724/

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/40306/

Merged to master, branch-3.1 and branch-3.0.

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/40306/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/40306/


Enumerate created backup task to enable, disable and remove

Add GUI to confirm, enable, disable and remove created backup tasks.

Close by ff4504fddbd788e07f6d39f1c5aae2433c590bd9


Cherry pick patches from master to 1.0.x

Codecov Report

Merging #1889 into 1.0.x will decrease coverage by 0.04%.
The diff coverage is 44.44%.

@@            Coverage Diff            @@
##            1.0.x   #1889      +/-   ##
=========================================
- Coverage   66.34%   66.3%   -0.05%
=========================================
  Files          56      56
  Lines        6597    6603       +6
  Branches     1317    1318       +1
=========================================
+ Hits         4377    4378       +1
- Misses       1997    2002       +5
  Partials      223     223

Impacted Files
Coverage Δ

webapp/graphite/storage.py
56.55% <0%> (-0.8%)
:arrow_down:

webapp/graphite/settings.py
75.15% <100%> (ø)
:arrow_up:

webapp/graphite/readers.py
40.98% <40%> (-0.27%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 422acce...67c1860. Read the comment docs.


Small features added

Ability to call
$RpcClient->initClient()->addRequest()->getReplies()
multiple times correctly.
RpcClient::setTimeout()

I think your workaround solves the issue, but, isn't the actual issue that getReplies() doesn't reset the requests and replies variables?

Hello.
Sorry for the long delay in replying.

If we use RpcClient multiple times in long-playing script, original behavior produces memory leaks and difficulties with debugging.
I am going to extend "setTimeout" feature. Are you interested in merging it to your lib?

yes, are you going with two PRs or everything into this one?

Let's working here.

Hello.
It is another small fix about lib behavior while callback passed to BaseConsumer::setCallback. is invalid (for example it is protected function of some object).
Origin code returns NULL silently in RpcServer.php:72.
New code throw exception before server start.

Thanks!


CORS issue

I change the Admin URL on public/config.json to my domain admin.example.com:4434 and public to public.example.com:4433 and also edit the cors-proxy.js but still got a cors error.

Your webservers (admin.example.com, public.example.com) have to send the cors headers.
Have a look here: https://www.google.com/amp/s/auth0.com/blog/amp/cors-tutorial-a-guide-to-cross-origin-resource-sharing/

@dfoxg thank you i solved it by using wildcard *. but i dont want to use wildcard domain how can i add more domains on cors-proxy.js file ? when i do it i get an error has been blocked by CORS policy: The 'Access-Control-Allow-Origin' header contains multiple values 'http://IP, http://IP2', but only one is allowed. or how can i add authorization header check on apis

The cors-proxy.js is only for local development, don't use it in production!
As I mentioned before, you have to set the cors headers on your webservers.


Add support for the new Fabric renderer

Was wondering if you had plans to add support for the new Fabric renderer

@capezzbr Thanks for your interest, we will be discussing this internally.
Within next two/three weeks we will have everything planned.
I will open an issue with adding the Fabric support once we'll plan to start it, so I will close this one.
Thank you!


Disallow magic numbers

Summary of changes
In order to improve readability of our code, magic numbers are now forbidden by the linter. Current errors are fixed. Many are just ignored and have to be fixed successively.
Context and reason for change
Improve readability of our code.
How can the changes be tested
yarn lint

My thoughts are: There are some places where this has a huge benefit, and some where its a small detriment. So overall, I think it's a good change. I would just like to mitigate as much weird stuff as possible (see review comments). It might be nice to get more opinions.


Fix core dump config file creation when core dumps are disabled

It seems that something went wrong when PR #146 was merged to master.
When variable os_security_kernel_enable_core_dump is set to false the core dump configuration file /etc/security/limits.d/10.hardcore.conf will always be removed by the following task:
https://github.com/dev-sec/ansible-os-hardening/blob/30aa3fef3fb47c620369b617a78b0644b69e0082/tasks/limits.yml#L30
In addition, if os_security_kernel_enable_core_dump is set to true, a core dump config file will be created by mistake:
https://github.com/dev-sec/ansible-os-hardening/blob/30aa3fef3fb47c620369b617a78b0644b69e0082/tasks/limits.yml#L35

@rndmh3ro

Can you also please change the setting here from false to true? false is the default so its not making any sense here.

:white_check_mark: DONE

Thank you! :)


Enabling JMX ports causes test failures.

Mac OS X -Sierra
Docker CE
Version 17.09.1-ce-mac42 (21090)
Channel: stable
3176a6af01
Container: 2 CPUs, 6G RAM
Running a container with JMX ports enabled results in only 9.5% of the Coyote tests passing. Plus there is no JMX connectivity.
When I run this command:
docker run --rm  \
           -p 2181:2181 -p 3030:3030 -p 8081:8081 \
           -p 8082:8082 -p 8083:8083 -p 9092:9092 \
           -e ADV_HOST=<IP_ADDRESS> \
           landoop/fast-data-dev

Everything starts and Coyote tests are %100.
When I run this command to enable JMX access:
docker run --rm -p 2181:2181 -p 3030:3030 -p 8081-8083:8081-8083 \
           -p 9581-9585:9581-9585 -p 9092:9092 -e ADV_HOST=<IP_ADDRESS> \
           landoop/fast-data-dev:latest

Coyote only reports 9.5 % tests passing. Only 4 out of the 13 Connect test passed. All other tests fail, Brokers, Rest, SchemaRegistry.
I will be happy to send any logs required.

Sorry for the late response. I think in the second case the error may be due to -e ADV_HOST=<IP_ADDRESS> as in the first example you used -e ADV_HOST=<IP_ADDRESS>.
When you set the ADV_HOST, all the services and kafka apps (producers and consumers) try to find Kafka at the ADV_HOST address —this is the way Kafka works, the brokers indicate the address the clients should connect to, the bootstrap servers are there only for the clients to get this address.


Certificate Password

This script is fantastic, appriciate the hard work!
This script is fine as it is for everyone else but...
I would like to add a certificate password as well, so that there is a prompt for clients to have to type in their own set password on the server, This is so that when connecting to the VPN they have to unlock their certificate in order to connect to the server. Can you point me in the right direction?
Thanks.

Hmm, you self-closed this issue it seems. Did you figure it out?
That being said, I'd rather not include functionality to customize this in the script, as the purpose of the script is to be opinionated and allow only as much customization as is strictly necessary. Adding passwords to certificates is a pretty obscure customization in my opinion.

Yes don't worry, I used something else instead.


A few more details and explanations to the bayesian arguments in the docu.

It would be nice to have a bit more info on these. Including some hint on what can be accomplished by manipulating it. See @param obs_df for an example.
#' @param trans_prior prior matrix for B in the transition equation. Default is
#'   zeros.
#' @param trans_shrink prior tightness on B matrix in trasition equation
#' @param trans_df prior degree of freedom for transition equation
#' @param obs_prior prior matrix for H (loadings) in the observation equation
#'  Default is zeros.
#' @param obs_shrink prior tightness on H (loadings) in the observation equation
#' @param obs_df named vector (see details). prior degree of freedom
#'   for observables. This is useful to give specific series a larger weight,
#'   e.g. 1. (default 0, method `bayesian` only).

@christophsax, let me know if this looks OK and we can close this issue.

I will do another turn and may have some more question. So let's keep it open and assign to me.

matrix dimensions
It would be good if the object is specified in the beginning. E.g.,:
#' @param trans_prior m x n matrix; m: number of factors, n: number of lags.

I currently have no idea how to construct these matrices.
orthogonal_shocks
What is this good for?
#' @param orthogonal_shocks return a rotation of the model with orthogonal
#'   shocks and factors. This is useful ....

OK... see updates on arguments.

Ok for now


Type-safe Keys

I ran across this FR for the GAE Java libraries. Basically, they want Keys to use generics so that a Key referencing an Entity with kind K is actually a Key.
I wanted to see what y'all thought about this.

Wait this doesn't make sense unless you also write your own classes.... Sorry for the spam.


Async Runner

What is wrong?

We have added thaw.js but we don't run the network async.
Where does it happen?

NeuralNetwork
How do we replicate the issue?

Train the network the run the network, there is an async way to train it but no async way to run it.
How important is this (1-5)?

2
Expected behavior (i.e. solution)

The user should be able to run it async in a similar way to training async.
Other Comments
the 5th

@freddyC is this completed for the NeuralNetwork class as of now?

The training is Async but actually running is not.  I am not certain how important this is as a priority but it seems like thematically if we have a train async we would also want to be able to run async.  I think it might be a good approach to have steam for running the network, then wrap the stream in a promise to allow async running.

fairly sure this is completed?

Any update on this?

I am closing this issue, please re-open if required.


Follow-ups to object property hash rework

Keep probe step as 1?
16-bit hash part (works well with slot cache)?
Drop hash parts on emergency GC?

Not merged, moved to future work.


Move to blocklists and allowlists

NOTE: This is backwards compatibility breaking.
proxy.config.http.proxy_protocol_whitelist renamed to proxy.config.http.proxy_protocol_allowlist

Related to #6913 ,  #6918 and #6940

Cherry-picked to v9.0.x branch.


ModulePool pilot commit

IMPORTANT: All PRs must be linked to an issue (except for extremely trivial and straightforward changes).
Fixes #172
Description
Precise description of the changes in this pull request
Alternative(s) considered
Have you considered any alternatives? And if so, why have you chosen the approach in this PR?
Type
Feature
Screenshots (if applicable)
Checklist

[x] I have read the Contribution Guidelines
[x] I have written Unit Tests
[x] I have discussed my proposed solution with code owners in the linked issue(s) and we have agreed upon the general approach

Akshay thanks for submitting the PR. Highly appreciated
On Tue, Jun 20, 2023, 8:23 AM AkshayPS12 @.***> wrote:

IMPORTANT: All PRs must be linked to an issue (except for extremely
trivial and straightforward changes).
Fixes #172 https://github.com/Apra-Labs/ApraPipes/issues/172
Description
Precise description of the changes in this pull request
Alternative(s) considered
Have you considered any alternatives? And if so, why have you chosen the
approach in this PR?
Type
Feature
Screenshots (if applicable)
Checklist

I have read the Contribution Guidelines
https://github.com/Apra-Labs/ApraPipes/wiki/Contribution-Guidelines
I have written Unit Tests
I have discussed my proposed solution with code owners in the linked
issue(s) and we have agreed upon the general approach

You can view, comment on, or merge this pull request online at:
https://github.com/Apra-Labs/ApraPipes/pull/238
Commit Summary

7fce5c0
https://github.com/Apra-Labs/ApraPipes/pull/238/commits/7fce5c0695dab9a96aa88bcd73c6fff053fa44c6
ModulePool pilot commit

File Changes
(2 files https://github.com/Apra-Labs/ApraPipes/pull/238/files)

A base/include/ModulePool.h
https://github.com/Apra-Labs/ApraPipes/pull/238/files#diff-5a99bfb57fc9ad21a3bb63fa66942fb13d6f1bd8734c134d5131ed609255889f
(20)
A base/src/ModulePool.cpp
https://github.com/Apra-Labs/ApraPipes/pull/238/files#diff-953ea870179b00ff280b7f5c313bb1bd6f2ce71c658e52529b2c4c2e92d8d081
(34)

Patch Links:

https://github.com/Apra-Labs/ApraPipes/pull/238.patch
https://github.com/Apra-Labs/ApraPipes/pull/238.diff

—
Reply to this email directly, view it on GitHub
https://github.com/Apra-Labs/ApraPipes/pull/238, or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABWFNAQV7TNZ724GNP5ZPQTXME6VHANCNFSM6AAAAAAZMZAQR4
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>


#150918512 Update git ignore file

What does this PR do?
Fix git ignore
Description of Task to be completed?
Removing ignore unnecessary files in project through git ignore

Coverage increased (+1.3%) to 81.526% when pulling ee1f54cb0e0a8988a45f24f0a4624a05dc03cf80 on ch-remove-unnecessary-files-on-git-150918512 into df137bfdad57cb53bcf31bdc92056cb4f316f921 on master.

Coverage increased (+1.3%) to 81.526% when pulling ee1f54cb0e0a8988a45f24f0a4624a05dc03cf80 on ch-remove-unnecessary-files-on-git-150918512 into df137bfdad57cb53bcf31bdc92056cb4f316f921 on master.


Text Combinations

Feature Description

Do not alter or remove anything below. The following sections will be managed by moderators only.
Acceptance Criteria
QA Instructions

@jauyong Can you add some details to this?

@swissspidy @pbakaus @samitron7
I don't see a brief for text combinations written yet. (Nor for Font Presets #353)
I only see the section included in designs, but couldn't find any UX details.

Text combinations being developed by design agency, adding to UX backlog, but need to manage through agency.

@jauyong Work for this will start in possibly 1-2 weeks. Will update this ticket once things get rolling. We'll try to get the curated list first then work on the combinations. Considered blocked till then.

update - @samitron7  to bring into the new design system and share the Figma files

This ticket should probably be broken into smaller pieces:

Text sets (there are ~125 of them) Figma
Implementation of the harmonic type scale Figma
Filter text set Figma
Add text to page Figma

This ticket requires further breakdown by @carlos-kelly and estimation on those tix

The first three tickets of work are #3965, #3966, #3967.

@o-fernandez I think that this ticket should be transformed to an epic called Text Sets / Combinations where we can effectively track the related work, LMK if you are okay with this.

@o-fernandez I think that this ticket should be transformed to an epic called Text Sets / Combinations where we can effectively track the related work, LMK if you are okay with this.

Agreed! Just updated to be an Epic. Will link the subtickets that @carlos-kelly mentioned above.

Let's add this to 1.1, based on @barklund and @carlos-kelly input we can split this work between sprints 37 and 38.

@o-fernandez @barklund Has internationalization been considered for text sets? I suppose they should be translatable..?

I don't think so, but:

translating them would probably also require design review and updates per language to fit text properly, sizing, etc.
the content of the text set itself is not important/critical IMO, it's the layout.

Given that, I think that translating the text in the text sets is probably lower priority and not blocking to launching the feature. But, LMK if it is low efforts/we can still fit it in when building it. @samitron7 for thoughts.

Not something I'd consider a blocker either. I just wanted to raise awareness for it :-)
It's not a straightforward to implement as internationalization also means support for languages like Arabic or Japanese, and for this feature it has to be well thought out it seems.

@o-fernandez do you want to still do translation? If so, can we create a separate ticket and prioritize. Considering everything else we have, translation seems low on the list of to-do.

@samitron7 no text sets translation needed for this ticket. Just filed a new ticket for the i18n part. #4767 We can tackle that at a future time.


Add Russian locale [WIP]

Feel free to double check in Google Translate; it struggles with technical/computer terms a lot with things like "custom", etc. Generally Russians are familiar with English terminology, and a lot of English words have entered the Russian language.
Would be best to get it vetted by a native speaker who is familiar with Zcash and crypto. There should be a source of truth for locale terminology in a Zcash repo, terms like “Shielded” should be translated the same consistently. Maybe a locale word dictionary repo could be made based on i18next schema?


Unable to kill all python threads after nnictl stop in async dispatcher mode

Problem
User is running multi-thread, when the trial end, not all the python threads are killed.
How to reproduce
@leckie-chn can always reproduce -_-|||...


Customizable Redesign

Advantages

This redesign allows us to remove duplicate protocols (e.g. CustomFont and CustomLabelFont) while still maintaining compile time check.
This redesign allows third party views to support Overlay.

CI failure seems unrelated.


disconnect() is not a function

when trying to call GoogleFit.disconnect(), it says _reactNativeGoogleFit.default.disconnect is not a function

do you use the last version of the lib?
Can you pls share your code?

yeah, i have upgraded to 0.7.1. Every other functionalities works as expected. I tried to call  GoogleFit.disconnect(); in another function.

I'd expect that there is a problem with correct import. But in this case, it's strange that others are work.
Try to console.log(GoogleFit) - to see what's the object there.

It was my bad. I have done ./gradlew clean, uninstalled and rebuild the app. Now it works fine


grin-miner cores shortly after loading plugin; pthread implicated

Ubuntu 18.04.1 server, running in a VM. This crashed with rust 1.28 and rust 1.30; lldb testing done with 1.30. I can crash it reliably on this machine, but it works on my desktop. Difference is this is 2nd gen Intel, desktop is 3rd gen ... not sure what else might be different as it's a VM, so it should behave nearly identically. Using the lean solver here to rule out "running out of memory" issues, but this could happen with any solver. Building the solvers from cuckoo and running them works fine, likely not an issue with the solver itself.
I'm no lldb wizard. Please advise as to what further data I can gather to help narrow this down.
yorick@grin-lap:~/grin-miner$ lldb-6.0 target/debug/grin-miner
(lldb) target create "target/debug/grin-miner"
Current executable set to 'target/debug/grin-miner' (x86_64).
(lldb) image list
[  0] 20516FEB-63D9-9988-B601-4EB4C99783CD-641B2DBE                    /home/yorick/grin-miner/target/debug/grin-miner
(lldb) run
Process 1993 launched: '/home/yorick/grin-miner/target/debug/grin-miner' (x86_64)
Starting Grin-Miner from config file at: /home/yorick/grin-miner/grin-miner.toml
Aug 11 12:59:33.623 INFO This is Grin-Miner version 0.3.0 (git cebe226), built for x86_64-unknown-linux-gnu by rustc 1.30.0-nightly (73c78734b 2018-08-05).
Aug 11 12:59:34.627 WARN Connection Status: Connected to Grin server at <IP_ADDRESS>:13416.
Aug 11 12:59:35.034 INFO Got a new job: JobTemplate { height: 46905, job_id: 0, difficulty: 1, pre_pow: "0001000000000000b7390adb4a93e0355ca670823bebebc9f2d2ae0d9743fd1210c699dc1dd821ffa49e000000005b6eddb60000000000f65a34fcf706bb6228d7fb60c9f8843d004123586a339689b1c7d8f65e0bbfdb785e0e47abc9f517dcf1d28caacd32f63e66c5661ef87688c78b8fc77ef1b2999dcacb20bad8ad7c037f5a7db31f690443b84356e849c1cb4a62ae897b1b48ea3d0e30a7232410790d9ae81007ad4bfee18ee1f555ddc19c880a303c011223150831aa09ebef9909688d3395ad5c023cc0fcde55b45c3cac6909e6053526b219e4e285c2000000000001ba390000000000019322" }
Aug 11 12:59:35.035 INFO Got a job at height 46905 and difficulty 1
Aug 11 12:59:35.593 INFO Cuckoo plugin 0 - /home/yorick/grin-miner/target/debug/plugins/lean_cpu_30.cuckooplugin
Process 1993 stopped
* thread #6, name = 'mining_controll', stop reason = signal SIGSEGV: invalid address (fault address: 0x0)
    frame #0: 0x00007ffff7359008 libpthread.so.0`__pthread_create_2_1 + 1624
libpthread.so.0`__pthread_create_2_1:
->  0x7ffff7359008 <+1624>: movaps %xmm0, -0x70(%rbp)
    0x7ffff735900c <+1628>: testq  %rbx, %rbx
    0x7ffff735900f <+1631>: movdqu 0x216419(%rip), %xmm0     ; __default_pthread_attr + 16
    0x7ffff7359017 <+1639>: movq   %rbx, -0x40(%rbp)
(lldb) run
There is a running process, kill it and restart?: [Y/n]
Process 1993 exited with status = 9 (0x00000009)
Process 2052 launched: '/home/yorick/grin-miner/target/debug/grin-miner' (x86_64)
Starting Grin-Miner from config file at: /home/yorick/grin-miner/grin-miner.toml
Aug 11 12:59:38.879 INFO This is Grin-Miner version 0.3.0 (git cebe226), built for x86_64-unknown-linux-gnu by rustc 1.30.0-nightly (73c78734b 2018-08-05).
Aug 11 12:59:39.885 WARN Connection Status: Connected to Grin server at <IP_ADDRESS>:13416.
Aug 11 12:59:40.102 INFO Got a job at height 46905 and difficulty 1
Aug 11 12:59:40.417 INFO Cuckoo plugin 0 - /home/yorick/grin-miner/target/debug/plugins/lean_cpu_30.cuckooplugin
Aug 11 12:59:41.010 INFO Mining: Cuckoo30 at 0 gps (graphs per second)
Aug 11 12:59:44.095 INFO Mining: Cuckoo30 at 0 gps (graphs per second)
Aug 11 12:59:47.085 INFO Mining: Cuckoo30 at 0 gps (graphs per second)
Aug 11 12:59:50.032 INFO Got a new job: JobTemplate { height: 46905, job_id: 1, difficulty: 1, pre_pow: "0001000000000000b7390adb4a93e0355ca670823bebebc9f2d2ae0d9743fd1210c699dc1dd821ffa49e000000005b6eddc50000000000f65a34fcf706bb6228d7fb60c9f8843d004123586a339689b1c7d8f65e0bbfdb785e0e47abc9f517dcf1d28caacd32f63e66c5661ef87688c78b8fc77ef1b2999dcacb3dbd46dbac5336a25427af5c99cb1a3b37fdcd0721379c3d6d59be0576b1be69a7232410790d9ae81007ad4bfee18ee1f555ddc19c880a303c011223150831aa09ebef9909688d3395ad5c023cc0fcde55b45c3cac6909e6053526b219e4e285c2000000000001ba390000000000019322" }
Process 2052 stopped
* thread #6, name = 'mining_controll', stop reason = signal SIGSEGV: invalid address (fault address: 0x0)
    frame #0: 0x00007ffff7359008 libpthread.so.0`__pthread_create_2_1 + 1624
libpthread.so.0`__pthread_create_2_1:
->  0x7ffff7359008 <+1624>: movaps %xmm0, -0x70(%rbp)
    0x7ffff735900c <+1628>: testq  %rbx, %rbx
    0x7ffff735900f <+1631>: movdqu 0x216419(%rip), %xmm0     ; __default_pthread_attr + 16
    0x7ffff7359017 <+1639>: movq   %rbx, -0x40(%rbp)
(lldb) run
There is a running process, kill it and restart?: [Y/n]
Process 2052 exited with status = 9 (0x00000009)
Process 2071 launched: '/home/yorick/grin-miner/target/debug/grin-miner' (x86_64)
Starting Grin-Miner from config file at: /home/yorick/grin-miner/grin-miner.toml
Aug 11 12:59:52.433 INFO This is Grin-Miner version 0.3.0 (git cebe226), built for x86_64-unknown-linux-gnu by rustc 1.30.0-nightly (73c78734b 2018-08-05).
Aug 11 12:59:53.438 WARN Connection Status: Connected to Grin server at <IP_ADDRESS>:13416.
Aug 11 12:59:54.051 INFO Got a job at height 46905 and difficulty 1
Aug 11 12:59:54.265 INFO Cuckoo plugin 0 - /home/yorick/grin-miner/target/debug/plugins/lean_cpu_30.cuckooplugin
Aug 11 12:59:55.058 INFO Mining: Cuckoo30 at 0 gps (graphs per second)
Aug 11 12:59:58.061 INFO Mining: Cuckoo30 at 0 gps (graphs per second)
Aug 11 13:00:01.061 INFO Mining: Cuckoo30 at 0 gps (graphs per second)
Aug 11 13:00:04.061 INFO Mining: Cuckoo30 at 0 gps (graphs per second)
Aug 11 13:00:06.017 INFO Got a new job: JobTemplate { height: 46905, job_id: 2, difficulty: 1, pre_pow: "0001000000000000b7390adb4a93e0355ca670823bebebc9f2d2ae0d9743fd1210c699dc1dd821ffa49e000000005b6eddd40000000000f65a34fcf706bb6228d7fb60c9f8843d004123586a339689b1c7d8f65e0bbfdb785e0e47abc9f517dcf1d28caacd32f63e66c5661ef87688c78b8fc77ef1b2999dcacb89031a85797bfce7be02eb7dbc84db9264395223a1145067c69154571538625ea7232410790d9ae81007ad4bfee18ee1f555ddc19c880a303c011223150831aa09ebef9909688d3395ad5c023cc0fcde55b45c3cac6909e6053526b219e4e285c2000000000001ba390000000000019322" }
Process 2071 stopped
* thread #6, name = 'mining_controll', stop reason = signal SIGSEGV: invalid address (fault address: 0x0)
    frame #0: 0x00007ffff7359008 libpthread.so.0`__pthread_create_2_1 + 1624
libpthread.so.0`__pthread_create_2_1:
->  0x7ffff7359008 <+1624>: movaps %xmm0, -0x70(%rbp)
    0x7ffff735900c <+1628>: testq  %rbx, %rbx
    0x7ffff735900f <+1631>: movdqu 0x216419(%rip), %xmm0     ; __default_pthread_attr + 16
    0x7ffff7359017 <+1639>: movq   %rbx, -0x40(%rbp)
  thread #9, name = 'mining_controll', stop reason = shared-library-event
    frame #0: 0x00007ffff7de5da0 ld-linux-x86-64.so.2`_dl_debug_state
ld-linux-x86-64.so.2`_dl_debug_state:
->  0x7ffff7de5da0 <+0>: rep    retq
    0x7ffff7de5da2:      nopl   (%rax)
    0x7ffff7de5da6:      nopw   %cs:(%rax,%rax)
ld-linux-x86-64.so.2`___lldb_unnamed_symbol52$$ld-linux-x86-64.so.2:
    0x7ffff7de5db0 <+0>: testq  %rsi, %rsi
(lldb) run
There is a running process, kill it and restart?: [Y/n]
Process 2071 exited with status = 9 (0x00000009)
Process 2088 launched: '/home/yorick/grin-miner/target/debug/grin-miner' (x86_64)
Starting Grin-Miner from config file at: /home/yorick/grin-miner/grin-miner.toml
Aug 11 13:00:09.627 INFO This is Grin-Miner version 0.3.0 (git cebe226), built for x86_64-unknown-linux-gnu by rustc 1.30.0-nightly (73c78734b 2018-08-05).
Aug 11 13:00:10.631 WARN Connection Status: Connected to Grin server at <IP_ADDRESS>:13416.
Aug 11 13:00:11.035 INFO Got a job at height 46905 and difficulty 1
Aug 11 13:00:11.317 INFO Cuckoo plugin 0 - /home/yorick/grin-miner/target/debug/plugins/lean_cpu_30.cuckooplugin
Aug 11 13:00:12.005 INFO Mining: Cuckoo30 at 0 gps (graphs per second)
Aug 11 13:00:15.006 INFO Mining: Cuckoo30 at 0 gps (graphs per second)
Aug 11 13:00:18.007 INFO Mining: Cuckoo30 at 0 gps (graphs per second)
Aug 11 13:00:21.014 INFO Mining: Cuckoo30 at 0 gps (graphs per second)
Aug 11 13:00:21.019 INFO Got a new job: JobTemplate { height: 46905, job_id: 3, difficulty: 1, pre_pow: "0001000000000000b7390adb4a93e0355ca670823bebebc9f2d2ae0d9743fd1210c699dc1dd821ffa49e000000005b6edde30000000000f65a34fcf706bb6228d7fb60c9f8843d004123586a339689b1c7d8f65e0bbfdb785e0e47abc9f517dcf1d28caacd32f63e66c5661ef87688c78b8fc77ef1b2999dcacb48fed9096dfd081a6fecbb1a8dd528dd87645a1bd4bf2d7e3a1d35d72032b768a7232410790d9ae81007ad4bfee18ee1f555ddc19c880a303c011223150831aa09ebef9909688d3395ad5c023cc0fcde55b45c3cac6909e6053526b219e4e285c2000000000001ba390000000000019322" }
Process 2088 stopped
* thread #6, name = 'mining_controll', stop reason = signal SIGSEGV: invalid address (fault address: 0x0)
    frame #0: 0x00007ffff7359008 libpthread.so.0`__pthread_create_2_1 + 1624
libpthread.so.0`__pthread_create_2_1:
->  0x7ffff7359008 <+1624>: movaps %xmm0, -0x70(%rbp)
    0x7ffff735900c <+1628>: testq  %rbx, %rbx
    0x7ffff735900f <+1631>: movdqu 0x216419(%rip), %xmm0     ; __default_pthread_attr + 16
    0x7ffff7359017 <+1639>: movq   %rbx, -0x40(%rbp)

all solvers rewritten since, no longer applies


Update request: add Name and Remove attributes for Document Sets

Please add the optional attributes Name of type xsd:string and Remove of type xsd:bool to:

ContentType\DocumentSetTemplate\AllowedContentTypes\AllowedContentType
ContentType\DocumentSetTemplate\SharedFields\SharedField
ContentType\DocumentSetTemplate\WelcomePageFields\WelcomePageField

Sample updated XML template which makes use of these attributes would look like:
        <pnp:ContentType ID="0x0120D52000633285944A99674FAFB784B02F6BAF10" Name="Custom Docset" Description="" Group="Custom Content Types" NewFormUrl="_layouts/15/NewDocSet.aspx" EditFormUrl="" DisplayFormUrl="">
          <pnp:FieldRefs>
            <pnp:FieldRef ID="b234d423-1f9a-47a9-a9da-7d7811578b5d" Name="PnP_x0020_Rocks" UpdateChildren="true" />
          </pnp:FieldRefs>
          <pnp:DocumentSetTemplate>
            <pnp:AllowedContentTypes>
              <pnp:AllowedContentType Name="test" ContentTypeID="0x0101" Remove="false" />
            </pnp:AllowedContentTypes>
            <pnp:SharedFields>
              <pnp:SharedField ID="cbb92da4-fd46-4c7d-af6c-3128c2a5576e" Name="DocumentSetDescription" Remove="false" />
              <pnp:SharedField ID="01af4761-a672-40b6-9148-f39150490e7e" Name="Another_x0020_field" Remove="true" />
            </pnp:SharedFields>
            <pnp:WelcomePageFields>
                <pnp:WelcomePageField Remove="false" ID="437fb870-cc28-40eb-8498-2a108c580e53" Name="Second_x0020_column" />
		<pnp:WelcomePageField Remove="true" ID="01af4761-a672-40b6-9148-f39150490e7e" Name="Another_x0020_field" />
		<pnp:WelcomePageField ID="b234d423-1f9a-47a9-a9da-7d7811578b5d" Name="PnP_x0020_Rocks" />
            </pnp:WelcomePageFields>
          </pnp:DocumentSetTemplate>
        </pnp:ContentType>

PR that will work with these new attributes has been submitted here: https://github.com/pnp/PnP-Sites-Core/pull/2624
The PR contains the requested schema changes already in the current latest schema, so these would need to be transferred to the new to be created schema:
https://github.com/pnp/PnP-Sites-Core/pull/2624/files#diff-8eef80de0298b0821deb0423cf9b4528

These changes are now defined in schema version 202103 and when the schema will be sealed and included in PnP Framework, we will be more than happy to see a PR to implement the corresponding provisioning behavior. Thanks.

Thanks @PaoloPia. I'll see if I can find time to port the PR for the actual implementation to the current code. I remember it took me 4 days to build it all :)


showDialog doesn't have "builder" property

Steps to Reproduce
showDialog<Null>(
      context: context,
      builder: (BuildContext context) {
        return new AlertDialog(
          content: const Text('You tapped the floating action button.'),
          actions: <Widget>[
            new FlatButton(
              onPressed: () {
                Navigator.pop(context);
              },
              child: const Text('OK')
            )
          ],
        );

  },
);

Logs
flutter run
Launching lib/main.dart on SM N750 in debug mode...
Initializing gradle...                                2.5s
Resolving dependencies...                             6.1s
Running 'gradlew assembleDebug'...                   23.1s
Built build\app\outputs\apk\debug\app-debug.apk (24.6MB).
I/FlutterActivityDelegate(20280): onResume setting current activity to this
E/flutter (20280): [ERROR:topaz/lib/tonic/logging/dart_error.cc(16)] Unhandled exception:
E/flutter (20280): NoSuchMethodError: The method 'call' was called on null.
E/flutter (20280): Receiver: null
E/flutter (20280): Tried calling: call()
E/flutter (20280): #0      Object.noSuchMethod (dart:core-patch/dart:core/object_patch.dart:46)
E/flutter (20280): #1      _startIsolate. (dart:isolate-patch/dart:isolate/isolate_patch.dart:279)
E/flutter (20280): #2      _RawReceivePortImpl._handleMessage (dart:isolate-patch/dart:isolate/isolate_patch.dart:165)
Syncing files to device SM N750...                    6.4s
🔥  To hot reload your app on the fly, press "r". To restart the app entirely, press "R".
An Observatory debugger and profiler on SM N750 is available at: http://<IP_ADDRESS>:8101/
For a more detailed help message, press "h". To quit, press "q".
D/mali_winsys(20280): new_window_surface returns 0x3000,  [720x1280]-format:1
D/SRIB_DBQ(20280): SurfaceView:updateWindow: viewRoot.sSVBufferCount=-1 mSVBufferCount=-1
I/FlutterActivityDelegate(20280): onResume setting current activity to this
I/Timeline(20280): Timeline: Activity_idle id: android.os.BinderProxy@207b0d7a time:6227739
flutter analyze
Analyzing M:\Work\Projects\FlutterTestApp\startup_namer...
error - The named parameter 'builder' isn't defined at lib\main.dart:68:7 - undefined_named_parameter
error - The constructor returns type 'dynamic' that isn't of expected type 'Widget' at test\widget_test.dart:15:29 - strong_mode_invalid_cast_new_expr
error - Undefined class 'MyApp' at test\widget_test.dart:15:33 - undefined_class
warning - The parameter 'child' is required at lib\main.dart:66:5 - missing_required_param
hint - Unused import: 'package:startup_namer/main.dart' at test\widget_test.dart:10:8 - unused_import
5 issues found.
(Ran in 14.9s)
Flutter Doctor
[√] Flutter (Channel beta, v0.1.5, on Microsoft Windows [Version 10.0.16299.309], locale en-US)
• Flutter version 0.1.5 at M:\Work\flutter
• Framework revision 3ea4d06340 (3 weeks ago), 2018-02-22 11:12:39 -0800
• Engine revision ead227f118
• Dart version 2.0.0-dev.28.0.flutter-0b4f01f759
[√] Android toolchain - develop for Android devices (Android SDK 27.0.3)
• Android SDK at M:\Work\Android\sdk
• Android NDK location not configured (optional; useful for native profiling support)
• Platform android-27, build-tools 27.0.3
• ANDROID_HOME = M:\Work\Android\sdk
• Java binary at: M:\Work\Android\Android Studio\jre\bin\java
• Java version OpenJDK Runtime Environment (build 1.8.0_152-release-915-b01)
[√] Android Studio (version 3.0)
• Android Studio at M:\Work\Android\Android Studio
• Java version OpenJDK Runtime Environment (build 1.8.0_152-release-915-b01)
[!] IntelliJ IDEA Community Edition (version 2017.3)
X Flutter plugin not installed; this adds Flutter specific functionality.
X Dart plugin not installed; this adds Dart specific functionality.
• For information about installing plugins, see
https://flutter.io/intellij-setup/#installing-the-plugins
[√] Connected devices (1 available)
• SM N750 • <IP_ADDRESS>:5555 • android-arm • Android 5.1.1 (API 22)
! Doctor found issues in 1 category.
So yeah, both in demo and doc has builder property in the AlertDialog, which I have none. The code on the top is copied from the docs / demo. How to fix it?

@moseskarunia the builder property exists on version 0.2.2 and greater.  You are currently on the beta branch version 0.1.5 which doesn't have this update.
Instead of builder, use the child parameter.
showDialog(child: new MyWidget(), context: context);

Also see the changelog for major breaking changes and updates at each version.

Any plan on when it will be rolled to beta?

@moseskarunia No announced dates yet, stay tuned.

This has been rolled to beta now.


[turborepo] ERROR  run failed: Failed to add workspace ""

What version of Turborepo are you using?
1.7.0
What package manager are you using / does the bug impact?
pnpm
What operating system are you using?
Mac
Describe the Bug
Following upgrading from 1.6.3 to 1.7.0 I have noticed that turbo now consistently fails to run my deployment command giving the following error:
><EMAIL_ADDRESS>deploy:dev /home/runner/work/monorepo/monorepo
> turbo run deploy:dev --continue --ignore="pnpm-lock.yaml"

 ERROR  run failed: Failed to add workspace "" from apps/website/.next, it already exists at apps/customer-portal/.next
Turbo error: Failed to add workspace "" from apps/website/.next, it already exists at apps/customer-portal/.next
 ELIFECYCLE  Command failed with exit code 1.
Error: Process completed with exit code 1.

This is being run in GitHubActions on a standard ubuntu image. The build command runs ok (which runs this script in the two affected workspaces: "build:export": "next build && next export",.
The turbo command which is failing is supposed to run this script command in the workspaces: "deploy": "cdk deploy --all --require-approval never --outputs-file ./cdk-outputs.json -c env=production && ts-node cdk/helpers/upload-source-maps.ts",
Expected Behavior
The command should execute successfully, as it was doing in 1.6.3.
To Reproduce
I'm unsure as I am not clear on the cause. I did notice that some changes were made in 1.7.0 which affect how workspaces are parsed, perhaps this has introduced a problem when using pnpm?
Reproduction Repo
No response

Hey @g-farrow, sorry for the issue here. It looks like it's related to this: https://github.com/vercel/turbo/pull/2659 (cc @mehulkar)

Not to hijack this issue, but I was also getting this error and it forced me to downgrade to 1.6.3. In my case, we have a @workspace/ui and another workspace called @workspace/reporting-ui.

Not at all, thanks for the extra info @c-kirkeby. I'll take a look at getting a reproduction together tomorrow.

I have the same issue using pnpm 7.19.0 and turbo 1.7.0: Failed to add workspace "" from apps/dashboard/.next, it already exists at apps/kwstriping/.next

Hey all! Apologies for the inconvenient. Can you confirm that in each of your cases, the two workspaces mentioned int he error message are both missing the name field in their respective package.json files?
I'm submitting a "fix" in #3375, but it actually feels like creating a worse bug to fix this. As you may be able to tell, our WorkspaceGraph uses the name of the workspace to keep track of it. Workspaces with the same name (even if they are "" will overwrite each other in the graph). I'm surprised this hasn't manifested as a much worse bug for you in some other way.
In any case, it seems like things were "working" for you before. IF you could confirm that

my understanding of the issue is correct
adding unique name keys to each workspace "fixes" the issue
you really don't want to add names to each workspace

If the last one is true, I'd love to hear why as well. We may need to consider using switching to paths instead of names, if that's the case.

In my case at least, they don't have missing names. They each have unique name fields in package.json with the format "@workspace/ui" and "@workspace/reporting-ui". If I get some time tonight I can try to create a minimal reproduction.

@c-kirkeby a repro would be very helpful, thank you! (Also feel free to try the patch in #3375 just to see if it solves your issue, even though we may not have found the cause.

@mehulkar I also have names set in each package.json, so I don't think that's the cause. The two affected projects (in my case) are both NextJS projects in the apps/ workspace. This is my pnpm-workspace.yaml contents:
packages:
  - "apps/**"
  - "packages/**"
  - "services/**"

Rolling back to v1.6.3 resolves the problem for me as well, so it looks like a problem released in v1.7.0?

so it looks like a problem released in v1.7.0?

It definitely looks like an issue with 1.7, just trying to narrow down the problem, since I can't think of a scenario where this error would come into play other than missing names. Not to say I don't believe you, but any chance I can get my hands on your repo so I can do some good old debugging? Happy to pair / get a private drop of the codebase as well, if a minimal repro is not easy to make.

I wasn't able to reproduce this one either. I was suspicious of turbo picking up the package.json from .next after a build when running your build command - but it doesn't look like that's the case.
A simple reproduction would be awesome!

Please find the repo here: https://github.com/c-kirkeby/turbo-next-reproduction
This was created simply by using pnpm create turbo command, picking pnpm as the package manager. I noticed it seems to only be happening when I change the pnpm-workspace.yaml pattern from - "apps/* to - "apps/**". I hope that helps!

That was really helpful @c-kirkeby, thank you!

I noticed it seems to only be happening when I change the pnpm-workspace.yaml pattern from - "apps/* to - "apps/**". I hope that helps!

You solved the bug! (at least yours, that is).
As mentioned in the pnpm docs, packages/** means "all subdirectories". Once an app has built, your workspace declaration is picking up apps/docs/.next as a workspace.
#2659 exposed the bug that all these workspaces are being added into Turbo's graph. However, since they don't define any scripts and are not dependencies of anything, they are always skipped over during all execution. Our new check for duplicate workspaces is inadvertently catching this issue.
There are a few things we can do:

Ignore declared "workspaces" that are in .gitignore directories.
I need to dig into pnpm itself to see how (and if) it does this, but our implementation
is just expanding the globs at the moment:
https://github.com/vercel/turbo/blob/552768bae0f92d716c3b6ea927502251be2992a3/cli/internal/packagemanager/packagemanager.go#L154

#3375.
We can simply add a check for missing names. I think this is the wrong fix, because we shouldn't have any of these in the first place. Based on this bug, I'm also concerned that large monorepos with a lot of Next.js apps that are misconfigured like this are bloating the graph unnecessarily.

We could revert the check for duplicate names.
I also believe this is the wrong solution, as duplicate workspace names will overwrite each other, and it's valuable to check against that.

I'll float this to the rest of the team, but in the meantime, this should fix your issue:
packages:
-  - "apps/**"
-  - "packages/**"
+  - "apps/*"
+  - "packages/*"

I think we should warn on a detected package with a missing name, exclude it from the graph, and continue (don't panic).

I think we should warn on a detected package with a missing name, exclude it from the graph, and continue (don't panic).

Spoke about this internally and came to the conclusion that:

Excluding packages without names is a bit extreme, because name are not required by package.json, so disallowing that could cause more trouble for other people's legitimate configurations.
Reverting #2659 would not be good, because workspaces getting overwritten due to the same name is a real bug.
Making an exception for "" in the check is not a good idea because of (1) ^.

IMO, some good options going forward are:

Exclude git-ignored paths when getting the list of workspaces
Log a bigger warning when a workspace path is discovered with a missing name (this doesn't fix the problem, but could help debug the issue if the config is unintentional)

Thanks for the workaround options. I can confirm that @c-kirkeby you workaround works for me (changing pnpm-workspace.yaml from apps/** to apps/* for example). It's worth noting that depending on your implementation there may be undesired effects of doing this - but for me it's a good solution.
@mehulkar I think both of the options you've suggested are good. Improving error messaging is always helpful. But ignoring git ignored paths makes a lot of sense to me and is, I think, fairly intuitive as well.

It's worth noting that depending on your implementation there may be undesired effects of doing this

just so I understand, what do you mean by this? “Your implementation” refers to turborepo’s solution for this problem? Or a consuming monorepo’s setup? In either case, what are the undesirable effects of changing to a single star?

As an extension to this problem:
I ran into the following error npm: must not have multiple workspaces with the same nam & yarn: error There are more than one workspace with name (checked 2 package managers to make sure it was not related to one of the two), as we make a copy of the package.json into the dist folder for publishing. So I tried to exclude all dist folders as workspaces with the following:
  "workspaces": [
    "apps/**",
    "packages/**/!(dist)/*"
  ],

However, Turbo stopped recognizing all workspaces in the packages directory at all, while yarn and npm now worked as expected.

It's worth noting that depending on your implementation there may be undesired effects of doing this

just so I understand, what do you mean by this? “Your implementation” refers to turborepo’s solution for this problem? Or a consuming monorepo’s setup? In either case, what are the undesirable effects of changing to a single star?

I meant the monorepo's setup. PNPM config allows both ** and * because they do different things. In my use case switching from ** to * was fine. But in a different monorepo setup, it may not be appropriate.

I've solved this issue by adding the following ignore rules to my pnpm-workspace.yaml file, according to PNPM docs:
packages:
  - "apps/**"
  - "packages/**"
  - "!**/.next/**" # NEW
  - "!**/dist/**" # NEW

Sadly does not work with yarn or npm

It's worth noting that depending on your implementation there may be undesired effects of doing this

just so I understand, what do you mean by this? “Your implementation” refers to turborepo’s solution for this problem? Or a consuming monorepo’s setup? In either case, what are the undesirable effects of changing to a single star?

I meant the monorepo's setup. PNPM config allows both ** and * because they do different things. In my use case switching from ** to * was fine. But in a different monorepo setup, it may not be appropriate.

Sadly does not work yarn or npm

@mehulkar In response for your request for feedback on this issue:
I just spent a couple hours bewildered why turbo wouldn't run my tasks with a bare bones setup. Then I stumbled on this issue – only then did I realize omitting name from package.json will cause turbo to skip that project.
My opinion is all package.json should have a name. But in this case I was missing name inadvertently. All my other tools work, npm works, turbo works from the root dir. But turbo doesn't recognize the package and says Running dev in 0 packages. I can imagine many others will encounter the same issue inadvertently, and be completely confused, and waste time like I did.
Two possible ways I think the turbo experience could be improved here:

Use the directory name/path as a fallback
Validate the package.json so turbo throws an error when it does not conform to expected schema (has name)

I definitely think libraries must have name in package.json, but I think some applications can be developed/run without a name. There's no obvious way to know what went wrong when turbo doesn't recognize the project.

@leontastic can you open a new issue? I think it's worth revisiting, especially since we're gearing up for 2.0 which has the luxury of including breaking changes, but I'd like to look at it with fresh eyes instead of as part of this issue.


Update scala-java-time to 2.2.0

Updates io.github.cquiroz:scala-java-time from 2.1.0 to 2.2.0.
GitHub Release Notes - Changelog - Version Diff
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Files still referring to the old version number
The following files still refer to the old version number (2.1.0).
You might want to review and update them manually.
build.sbt

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "io.github.cquiroz", artifactId = "scala-java-time" } ]

labels: test-library-update, semver-minor, old-version-remains

Superseded by #170.


Rendering Kino.nothing in a frame or layout prints :"do not show this result in output"

Kino version: 0.9.4
Livebook version: 0.9.2
To reproduce:
frame = Kino.Frame.new()
Kino.Frame.render(frame, Kino.nothing())
frame

I'm currently using nothing = Kino.Markdown.new("") as a workaround

Hey @mat-hek, this is expected, Kino.nothing() is specifically for cases where the cell evaluation result shouldn't be added as a final inspect output. The magic atom it returns matches IEx for consistency.
A frame is already empty by default and you can remove its contents with Kino.Frame.clear/1. I assume you want to get rid of the "Nothing here..." placeholder, correct? With the current APIs I would use Kino.Frame.render(frame, Kino.Layout.grid([])).
@josevalim we could have a :placeholder option to disable the default box, wdyt?

An option sounds great to me.

I wonder if it should be placeholder: true | false (defaults to true) or placeholder: String.t() | nil (defaults to "Nothing here..."). The latter is more flexible, but it is kinda weird to allow nil and default to string at the same time.

I assume you want to get rid of the "Nothing here..." placeholder, correct?

Yeah, that's the primary case, but it's also handy when I have a function like
def generate_some_kino(params) do
  if ... do
    # create some actual kino
  else
    # return nothing
  end
end

as I can simply call Kino.Frame.render(generate_some_kino(params)).
It also allows having an empty cell in a layout.

as I can simply call Kino.Frame.render(generate_some_kino(params)).

You could define:
defp update_frame(frame, nil), do: Kino.Frame.clear(frame)
defp update_frame(frame, kino), do: Kino.Frame.render(frame, kino)

Then use it to update the frame; this way you could skip the else branch in generate_some_kino.

It also allows having an empty cell in a layout.

Semantically Kino.nothing() is not empty output, but no output. In case of layout the cell needs to be something, so I would do defp blank(), do: Kino.Layout.grid([]) and use that instead.

Got it.

defp blank(), do: Kino.Layout.grid([])

WDYT about Kino.blank()? :P

WDYT about Kino.blank()? :P

I considered that, but I'm not sure, so I would defer until there are more use cases. @josevalim if you have preference let me know, alternatively we could add Kino.blank() and kill Kino.nothing() (or change the behaviour of Kino.nothing()).

The reason we have nothing() is to mirror IEx. So given we have to support it forever, I don’t think it is worth changing. I am fine with checking nothing() inside frame though and then rendering nothing.

I added support for Kino.Frame.new(placeholder: false) in #297.
As for Kino.nothing() I really don't think we should special case the atom, and either way it's really about skipping output, not an empty space (e.g. in a grid).
We can always revisit if there are more use cases :)


Forward slash is not escaped

igornovikov1@~/Documents/Code/wtf-test:$ npm i escape-string-regexp
npm notice created a lockfile as package-lock.json. You should commit this file.
npm WARN<EMAIL_ADDRESS>No description
npm WARN<EMAIL_ADDRESS>No repository field.

+<EMAIL_ADDRESS>added 1 package from 1 contributor and audited 1 package in 2.12s
found 0 vulnerabilities

igornovikov1@~/Documents/Code/wtf-test:$ node
> const escape = require('escape-string-regexp')
undefined
> escape ('^test/test$')
'\\^test/test\\$'

Why should it? Running new RegExp('\\^test/test\\$') works fine.

I suppose this is reasonable, but I'd appreciate highlighting it in the docs. My case is a little unusual, I'm passing the regexp into the DefinePlugin in order to use the regexp as a require.context argument -- otherwise non-matching files would be compiled anyway. So, I wrongly expected the slashes to be escaped and ended up with an incredibly arcane error a few weeks later.

Package description:

Escape RegExp special characters

It would be both surprising and incorrect if we escaped other characters.

I guess we could make it clearer in the readme that only the minimal amount of escaping is done.

Thanks, that would work :)


crypto/x509: add new FreeBSD root store path [freeze exception]

FreeBSD added a system root store that doesn't require installing a package. We should use that when it's available.
https://svnweb.freebsd.org/base?view=revision&revision=357082
There is a CL available already: https://golang.org/cl/321190
@golang/release, can I get a freeze exception for this? It's a very small change, platform specific, and lets us be more in sync with the trust policy of the platform.

Thanks for requesting a freeze exception and letting us know. This certainly looks very reasonable for Go 1.17. Moving from NeedsDecision to NeedsFix.


npm run test:i18n fails on the monorepo

Issue:
running npm run test:i18n stop failing on missing locals after moving to monorepo
Cause:
the test script is looking for locals on the old path instead of the plugin package.

cc:// @rszwajko


CPC+: DateTimeParseException in the latest version but success in an earlier version

Information

OS & version:
-- macOS Sierra
-- Whatever the production QPP utility's OS is
Java version:

java version "1.8.0_151"
Java(TM) SE Runtime Environment (build 1.8.0_151-b12)
Java HotSpot(TM) 64-Bit Server VM (build 25.151-b12, mixed mode)

Docker version:

Docker version 17.12.0-ce, build c97c6d6

Expected behavior
A successful conversion. See attached JSON:
success.json.txt
Actual behavior
This results in a DateTimeParseException. See attached log:
error.log
Steps to reproduce

Download this file (remove .txt extension added for github):
CPC_PLUS_FAILURE.xml.txt

Checkout the commit c18f8f976 (latest version at the time of writing this issue)

Run qpp conversion tool with headers specified in the documentation.

POST the file downloaded in step 1

See that the response is CT-unexpected exception occurred during conversion

See that the qpp conversion tool logged an exception

Other details

This is also happening for a production qpp submission (same file but with real info)

Expected behavior can be achieved if you repeat the above steps but in step 2 checkout the commit 66510dba instead

The file works if you change the intendedRecipient extension to MIPS_GROUP (line 103 of the document), which suggests this error is unique to the CPC+ code

Looks like the issue is a missing env var CPC_END_DATE, CpcClinicalDocumentValidator.java has this line LocalDate.parse(EnvironmentHelper.getOrDefault(END_DATE_VARIABLE, NEVER_ENDING)) but looks like it's returning an empty string instead null so it tries to parse '' and not NEVER_ENDING value.
You can fix it locally if you se the env var in the docker-compose.test.yaml
...
environment:
  - CPC_END_DATE=3000-01-01
...

Update: Don't need to update the docker-compose file .env file has CPC_END_DATE= so that's why var is ''

We'll double check the documentation to ensure that this is called out in the docs as an env var to modify.  We can also just provide a default value in the .env file.

Maybe the EnvironmentHelper should validate that value is not null and is not a empty string, What do you think?

Nice catch!  And yeah, I think that changing EnvironmentHelper to also return the default on an empty string is appropriate, @aaroalan.

@aaroalan @nathandonato: We have added this issue to our backlog and it will be prioritized today.  We will let you know via this issue when changes have been made.

Thanks @sfradkin! I'm sure you're aware and will factor this into the priority, but it's probably worth overstating: CPC+ submissions are due in one week (2018-02-28).

@nathandonato Yes we are aware of this.  However, since there is a stated solution in this thread as to how to set the environment variable, and there is a publicly available sandbox at https://qpp.cms.gov/developers/conversion-tool-sandbox that uses our production code, that lowers the priority of this a bit.

That makes sense, thanks for the follow up.  But we are getting this error when doing QRDA III XML submissions (we assume this is the error; the response is error code 3, and this is the actual exception we get locally for the same file).
So we can use the environment variable solution in our testing, but is there any chance you guys will set the environment variable in production?

Ah, sorry.  I missed the part that you tried this as a real submission and got the same error.  I can confirm that I am seeing that error with your file.  We'll take a look at this to see what's going on as it's unrelated to the CPC_END_DATE.

Sorry, that's my fault. I should have been more clear. Thanks for looking into it.

@nathandonato Looking at this further it appears that you have a missing code in one of your supplemental data elements.  We are already working on a fix for this situation so that it correctly outputs an error with the xpath rather than returning an "unexpected error".  It's tough to eyeball the QRDA document to find the missing code, but that's where you can look.
We're going to work on getting this fix out as a hotfix to production by the end of the day tomorrow.

@sfradkin We believe we found the issue. Thanks for pointing us in the right direction!

@nathandonato We have deployed a new version of the converter to production.  Please try it out and see if that gets your file converted and submitted.

With no response for over a week, I'm going to go ahead and close this issue as fixed.


Support Specification Extensions

Do you support or have plans to support Specification Extensions?
For example, I need to include the x-ms-openai-data internal property to help Power Platform do its required processing:

I was able to implement support for info and operations extensions via the IDocumentFilter.
public class DocumentFilter : IDocumentFilter
{
    public void Apply(IHttpRequestDataObject request, OpenApiDocument document)
    {
        if (!document.Info.Extensions.ContainsKey("x-ms-keywords"))
        {
            document.Info.Extensions.Add(
                "x-ms-keywords",
                new OpenApiArray { new OpenApiString("Acme") }
            );
        }

        var paths = document.Paths;
        foreach (var path in paths)
        {
            var pathItem = path.Value;
            foreach (var operation in pathItem.Operations)
            {
                var operationItem = operation.Value;
                if (!operationItem.Extensions.ContainsKey("x-ms-openai-data"))
                {
                    operationItem.Extensions.Add(
                        "x-ms-openai-data",
                        new OpenApiObject { { "openai-enabled", new OpenApiBoolean(true) } }
                    );
                }
            }
        }
    }
}
` ``


Need to copy twice to paste in Rider

The Jetbrains Rider IDE acts weird when using clipmenud. Here is how to reproduce:

start clipmenud
open rider
open gedit
write something with gedit, select it, and Ctrl+c
go to rider, type Ctrl+v

Expected: the copied text appears
Actual: nothing appears

Go back to gedit
press  Ctrl+c again on the same text
go to rider, type Ctrl+v, the text correctly appears

I always have to copy something twice for it to be pastable inside Rider. Pasting anywhere else works as expected. I haven't found any other application which acts the same.

Yes, this is weird.

At a guess, Rider tries to take ownership of the clipboard or something (although I didn't install it to test). The second copy works because it bypasses clipmenu because of duplicate detection.
If this guess is right, then I suppose running clipmenud with CM_OWN_CLIPBOARD=0 works?
I'm wondering if we should go back and make this the default again.

Yeah for me this problem started showing up again as well. Lots of web apps and quite a few applications seem to take ownership and require a second copy since the last time i updated

I suppose running clipmenud with CM_OWN_CLIPBOARD=0 works?

this works for me!

Release 6.0.0 has CM_OWN_CLIPBOARD=0 by default and a whole bunch of other fixes. Let me know if you still experience issues. Thanks for the report! :-)

Thank you


tests/eas: Delete empty 'rfc' test file

This test is still something we want to keep on hand, I've just fixed it to match the new executor interface with a patch in #295


Throughput Drop Seemingly After Plugins Installed, Toggling Hardware Offload Solves It - But Won't Survive a Reboot

This happened to me on the last major release and this new one.  I have Xfinity 1.2 service, Opnsense connected to the modem at 2.5.  Opnsense to LAN at 10Gbps fiber.  LAN to testing host ist 10Ggbps plus testing directly on Opnsense terminal via speedtest cli.
If I install out of the box Opnsense the throughput it as expected - no problems, and it survives reboots.
If I browse and install the plugins I'd like, boom, the throughput will not exceed 1 Gbps.
Last major release I was forced to reload from scratch with no plugins to preserve throughput.
This new major release I tried again, but ended up with the same result.  Through troubleshooting and a bit of luck I decided to try enabling hardware offload just to see the results - as I have Intel chipsets in the mainlines.
https://x.x.x.x/system_advanced_network.php
To my surprise and joy - the throughput came back to normal.  I then disabled and re-enabled and the throughput stayed correct.  It does not matter if it is enabled or disabled, the act of toggling fixes it.  However, if I reboot Opnsense I am again restricted to a 1 Gbps ceiling - never exceeding this threshold.
But if I simply go toggle the hardware offload - either on or off, doesn't matter, the throughput again returns to normal... until reboot that is...
This is my first post, I didn't know about templates.  Happy to find them and edit re-post.

Here is the hardware info:
https://bsd-hardware.info/?probe=3e96602a8f

So 2 things I have noticed, 1 you are not running 23.1.1 is there any improvements using that? Second remove ad guard home and use either unbound DNSBL to block ad’s etc or dns crypt-proxy to do that as well and does that make a difference? As my hunch says it will.
On 17 Feb 2023, at 00:16, Mike Liotus @.***> wrote:

Here is the hardware info:
https://bsd-hardware.info/?probe=3e96602a8f
—
Reply to this email directly, view it on GitHubhttps://github.com/opnsense/plugins/issues/3310#issuecomment-1433916491, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AA3V2QWE6Y34JTIMGWJYXCDWX27NRANCNFSM6AAAAAAU5W6OCQ.
You are receiving this because you commented.Message ID: @.***>

I upgraded to 23.1.1 after submitting this - no difference.
I will test changing the ad filtering.
Thank you.
On Thu, Feb 16, 2023 at 6:52 PM J.Townsend @.***> wrote:

So 2 things I have noticed, 1 you are not running 23.1.1 is there any
improvements using that? Second remove ad guard home and use either unbound
DNSBL to block ad’s etc or dns crypt-proxy to do that as well and does that
make a difference? As my hunch says it will.
On 17 Feb 2023, at 00:16, Mike Liotus @.***> wrote:

Here is the hardware info:
https://bsd-hardware.info/?probe=3e96602a8f
—
Reply to this email directly, view it on GitHub<
https://github.com/opnsense/plugins/issues/3310#issuecomment-1433916491>,
or unsubscribe<
https://github.com/notifications/unsubscribe-auth/AA3V2QWE6Y34JTIMGWJYXCDWX27NRANCNFSM6AAAAAAU5W6OCQ>.
You are receiving this because you commented.Message ID: @.***>
—
Reply to this email directly, view it on GitHub
https://github.com/opnsense/plugins/issues/3310#issuecomment-1433940597,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AHOPVAGAJ773BMJQPAXMAVTWX3DWPANCNFSM6AAAAAAU5W6OCQ
.
You are receiving this because you authored the thread.Message ID:
@.***>

This issue continues to this day.
I am running the latest OS / Opnsense / Firmware.
No ad software loaded anymore.
Would you like to pick this back up?
Michael
On Fri, Aug 11, 2023 at 9:05 PM OPNsense-bot @.***>
wrote:

Closed #3310 https://github.com/opnsense/plugins/issues/3310 as not
planned.
—
Reply to this email directly, view it on GitHub
https://github.com/opnsense/plugins/issues/3310#event-10075126849, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AHOPVADUVSV7ETJZS66PATDXU3QILANCNFSM6AAAAAAU5W6OCQ
.
You are receiving this because you authored the thread.Message ID:
@.***>


The variable "self._response" seems not to be a json object.

When I tried to deploy the project on my own PC with openai apikey ,I encountered the following problems.

Traceback (most recent call last):
File "D:\code\Anaconda3\envs\UFO\lib\runpy.py", line 196, in _run_module_as_main
return _run_code(code, main_globals, None,
File "D:\code\Anaconda3\envs\UFO\lib\runpy.py", line 86, in run_code
exec(code, run_globals)
File "E:\homework\PHD-00\UFO\ufo_main.py", line 7, in
ufo.main()
File "E:\homework\PHD-00\UFO\ufo\ufo.py", line 56, in main
clients.run_all()
File "E:\homework\PHD-00\UFO\ufo\module\client.py", line 28, in run_all
session.run()
File "E:\homework\PHD-00\UFO\ufo\module\sessions\session.py", line 103, in run
super().run()
File "E:\homework\PHD-00\UFO\ufo\module\basic.py", line 355, in run
round.run()
File "E:\homework\PHD-00\UFO\ufo\module\basic.py", line 104, in run
self.agent.handle(self.context)
File "E:\homework\PHD-00\UFO\ufo\agents\agent\basic.py", line 224, in handle
self.state.handle(self, context)
File "E:\homework\PHD-00\UFO\ufo\agents\states\host_agent_state.py", line 132, in handle
agent.process(context)
File "E:\homework\PHD-00\UFO\ufo\agents\agent\host_agent.py", line 241, in process
self.processor.process()
File "E:\homework\PHD-00\UFO\ufo\agents\processors\basic.py", line 99, in process
self.parse_response()
File "E:\homework\PHD-00\UFO\ufo\agents\processors\host_agent_processor.py", line 154, in parse_response
self.host_agent.print_response(self._response_json)
File "E:\homework\PHD-00\UFO\ufo\agents\agent\host_agent.py", line 264, in print_response
message = list(response_dict.get("Message"))
TypeError: 'NoneType' object is not iterable

The error appears to have originated from the variable "self._response" in file "ufo\agents\processors\host_agent_processor.py", line 135.  The variable "self._response" is not a json object.

Hi @pursuingf .Thanks for raising this. For quick fix, please change to code from
message = list(response_dict.get("Message"))

to
message = list(response_dict.get("Message", ""))

We will update it in the future version.


Error while adding second OSD host.

Hi,
I tried to deploy ceph cluster on Ubuntu20.04 LTS and ceph version Quincy. I created a cluster and added mon, mgr and OSD. While adding OSDs, first OSD was successfully added, but during addition of  second OSD I faced errors.
Used this command to add OSD: sudo ceph orch daemon add osd st04:/dev/nvme1n1
Can you please help me with the same.
Thanking you in anticipation.

Please contact ceph for this one as cephcsi will not handle ceph cluster deployment.


Support Different Source Paths

Right now, there's a dependency on /var/lib/apt/lists/ which means a dependency on the system apt. When I run apt-get on the system, I have to pull down a lot of sources that I probably don't need at the time... unless I'm running "sudo apt-get update" just so I can run ratt without builds failing because sources can't be found.
I can understand why the design decision was made in the first place, but it'd nice if we would extend ratt to read a custom sources.list and maintain (and optionally update) it. If nothing else, an option top point at a separate directory for these files so that I can write a script to maintain them separately.. that also makes sense. :)

Also, for the life o' me, I can't figure out how the heck to make it build for testing/stretch, but it keeps complaining about not finding sources for unstable. I don't have any for unstable... I want to run this for testing. I'm not sure if it's related, something silly I'm doing, or something else entirely.

I think you can tell apt via environment variables where to look. The burden of setting that environment variable and maintaining a separate lists directory would fall on to you; I don’t think we should build that into ratt.
Does that make sense?

Creating the sources my be a job for the calling script, but ratt is hard coded to only look at system paths:
https://github.com/Debian/ratt/blob/master/ratt.go#L161 & 182 & 187
I guess if apt can do the rest using environment variables, then turning the directory into another option would be quite easy. If so, then it'd be nice to have some example setup documentation. I might be able to take a look into a PR for that.

You’re looking at the fallback branch. Take a look at https://github.com/Debian/ratt/blob/master/ratt.go#L134 instead. No changes to the code should be necessary.

I ended up using a work-around, but see what you're referring to. When I get some time, I'll plan on writing some documentation that I'm hoping you'd like to include about that that setup looks like. It at least falls like it's within scope to document how that can be done, ya? :)

Sure, documentation improvements are always welcome.


Added HyphenNameMapperNoDigits - it maps e.g. "implS3" to "impl-s3"

I use ficus and at work, we often have config classes like
case class MyConfig(impl: StorageImpl, local: Option[LocalStorageConfig], s3: Option[S3StorageConfig])

and we use hyphens in configs. So this maps to
impl = "S3"
s-3 = {
...
}

It would look much better if it was s3 instead of s-3
This PR makes it possible

Coverage decreased (-1.2%) to 94.737% when pulling fd863d0530c7be75c1499b586e23aa48229ec1c9 on amorfis:hyphen-no-numbers into cc542fa6a0c118677a94867c631cfd3799170ec5 on iheartradio:master.

Is anyone looking at this PRs? Or is the project dead? I need the change in ficus, but I don't want to fork another project of it if there is still one alive.

Can you just place the instance in your own project and use it? You don't
need it to live in ficus to be able to use it.
On Fri, Sep 3, 2021, 8:08 AM Paweł Stawicki @.***>
wrote:

Is anyone looking at this PRs? Or is the project dead? I need the change
in ficus, but I don't want to fork another project of it if there is still
one alive.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/iheartradio/ficus/pull/140#issuecomment-912488436,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAAUKOOUZ4VPOIFR3JEHH5LUAC3DHANCNFSM4XK27UTA
.

@kailuowang I have many projects and I don't want to copy code. I can of course add this to some utils library and use in my projects. Or I can release my own version of ficus. I thought it might be useful also for others. However, I fully respect your opinion if it is different.
Thanks for the ficus library!

@amorfis thanks!
Right now the PR still needs a scalafmt but I think once that's fixed I can merge and release.
Going forward though, full transparency, I am not using ficus myself. Will you be interested in help maintaining this library?

@amorfis thanks!
Right now the PR still needs a scalafmt but I think once that's fixed I can merge and release.
Going forward though, full transparency, I am not using ficus myself. Will you be interested in help maintaining this library?

Yes!

Is it possible to check why scalafmt test doesn't pass? When I run scalafmtCheckAll on my machine there are no errors at all.

Is it possible to check why scalafmt test doesn't pass? When I run scalafmtCheckAll on my machine there are no errors at all.

Cc @mdedetrich who set it up

So I actually cloned https://github.com/amorfis/ficus/tree/hyphen-no-numbers and manually downloaded the scalafmt-native-musl release from https://github.com/scalameta/scalafmt/releases/tag/v2.7.5 and when I run scalafmt locally it passed without any problems.
I have no idea why the github action is failing since its also just downloading the same binary from the release and running it, there might be some weird git interaction I am not aware of? You can try dropping the Formatting commit and instead doing a rebase against https://github.com/iheartradio/ficus master, then running scalafmt + git commit ammend and then force pushing to see if it works.
Alternately @kailuowang can just merge this PR ignoring the failure.

Alternately @kailuowang can just merge this PR ignoring the failure.

But then the check is going to fail on master isn't it? And on all the future PRs.

I propose we replace native with sbt-scalafmt cmd on CI
On Tue, Sep 7, 2021, 8:10 AM Paweł Stawicki @.***>
wrote:

Alternately @kailuowang https://github.com/kailuowang can just merge
this PR ignoring the failure.
But then the check is going to fail on master isn't it? And on all the
future PRs.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/iheartradio/ficus/pull/140#issuecomment-914250164,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAAUKOMVWO7P5FX2IQFX33TUAX6KJANCNFSM4XK27UTA
.

TBH I am not sure what this problem is because I have already integrated this precise solution in around 10 other Scala open source projects and this is the first time such a problem has happened.
Rationally speaking it leaves 2 possibilities

Simply put the contents of the git clone in the CI machine for w/e reason are different (this is why I suggested doing the rebase)
There is some weird error with this specific version of scalafmt

Something specifically being wrong with scalafmt-native looks highly unlikely. When I checked out @amorfis branch locally I also tried scalafmt via sbt cli and it reported the exact same result as scalafmt-native. In other words irrespective of what type of scalafmt I was using (native or sbt) I am unable to reproduce whats going on
I would prefer to diagnose this problem rather than ripping everything out. @amorfis if you are open to this, can you temporarily add
WorkflowStep.Sbt(List("scalafmtCheckAll"), name = Some("check format project"))

After this line https://github.com/iheartradio/ficus/blob/master/build.sbt#L11
Then make sure you run sbt githubWorkflowGenerate, this will update the https://github.com/iheartradio/ficus/blob/master/.github/workflows/ci.yml file.
Commit these changes (ideally as an ammend to your https://github.com/iheartradio/ficus/pull/140/commits/c3f020b073ba572e19f41ab5893e12dfcf0b4ee9 commit with a force push) and lets see what happens.

Will do tomorrow as I gotta go already today 👍

I rebased on master and looks like there are no errors now, but it also looks like actions did not run?

Closing and reopen to trigger GH action

Awesome, it seems that scalafmt is working without problems now. Not sure what happened but it appears that rebase solve the issue.

Osm! Thanks!
Do you plan to release new version anytime soon?

If https://github.com/iheartradio/ficus/pull/166 can get merged before the release that would be great!

I'd love to merge #139 too


reverse --(no-)dev logic for composer install just like composer upda…

…te --dev is the default behaviour

Don't know if I made it clear but this fixes dev: false option. You simply can't get composer NOT to install dev dependencies unless you pass --no-dev as --dev is the default behavior.


variables: load_events level='run' loads participants

Does the following look like intended behavior?
When I use load_variables to get run level variables:
load_variables(layout, level='run', **entities)
I get back a list of two "Nodes". One is a RunNode, but I also get back a node with dataset level information (e.g. gender). Presumably, I should only be received the run level information, right?

That's odd, you should be getting back a single NodeIndex object, which you can then call get_collections on. Are you working with the latest master?
I'll investigate when I'm back in town.

yeah. given that it seems like a bug ill look into it as well.

It looks like if I call get_collections('run') I get back the correct information, but other dataset level variables are also being ingested. This is not a huge deal, but it's not what I'd expect, and causes some issues with DataLad, since I have to prefetch those files.
Since I need those later though, Ill just use this to ingest all the variables I need.

Which variables are showing up for you? That doesn't appear to happen in the tests, as far as I can tell. I can imagine a case in which it would happen given the way the code is set up, but it would require you to have dataset-level variables that have a value set for the run entity, which in principle shouldn't happen (since variables that exist past the run level shouldn't be tied to a particular run). Can you describe or paste the result you're seeing?

In test dataset ds005 I'm getting many run nodes and a single Node with variables age and sex.
As far as I'm concerned, I just prefetched participants.tsv as a workaround, so this is not at all urgent.

NodeIndex.get_collections should be returning BIDSVariableCollections, not Nodes... what call is giving you back Nodes?
I can't replicate the problem with ds005... the tests check what's returned by get_collections('run') for ds005, and it doesn't include age or sex... Can you paste your code?

Sorry, I wasn't being clear. This is a very minor point so sorry for the distraction.
load_variables(layout, level='run').get_collections('run')

That's what I'm calling and it returns the correct output.
The issue is that the NodeIndex also contains Nodes related to dataset level variables, even though I specified level=run to the function load_variables.
So if I do:
load_variables(layout, level='run').get_collections('dataset')

I get back 'age' and 'sex', which is odd to me that it's available, and it causes a minor issue because participants.tsv is not prefetched and load_variables will crash unless I fetch that file.

Ah, got it. Yeah, that's a bug. Thanks!
(It may be minor, but I'm trying to get this to a stable point as quickly as possible, so it's helpful.)

get_collections('run') returns the correct thing.
But when I do the following:

Turns out this isn't a bug: the argument to load_variables is levels, not level. It's inconsistent with get_collections, but I don't want to rename it to level because you can pass a list with more than one level in this case. (And we can't raise an exception on the extra arg because we have to accept unknown kwargs to pass onto the internal methods.)

d'oh. that makes sense.


Mute audio

Hello @shogo4405 and thank you for an awesome framework.
Is there any why to mute audio while streaming? (sending silence AAC packets)

I didn't mean to mute audio.
Tell me details.

@shogo4405 the audio is fine, I want to know if I can mute the audio manually.

@tomerhatav
OK. I understand. No feature.
But I think it is necessary. I will try to implement.

I implemented it. https://github.com/shogo4405/lf.swift/commit/1634bdee97b971fed8f970ef1ea517c972aaaec8
rtmpStream.audioSettings = [
    "muted": true, // if you want a mute audio.
]

I will release 0.3.2 soon.

Thank you for your hard work @shogo4405 you are awesome!

Thank you for your hard work @shogo4405 you are awesome!

released 0.3.2


fix: deleted unwanted code segment

What type of PR is this? (check all applicable)

[ ] 🍕 Feature
[x] 🐛 Bug Fix
[ ] 📝 Documentation Update
[ ] 🎨 Style
[ ] 🧑💻 Code Refactor
[ ] 🔥 Performance Improvements
[ ] ✅ Test
[ ] 🤖 Build
[ ] 🔁 CI
[ ] 📦 Chore (Release)
[ ] ⏩ Revert

Description

Fixed issue #236 - Deleted code segment in PrimaryNav.tsx causing an unwanted "My Votes" text. Followed solution instructions and removed lines 83 through 97 from src/components/PrimaryNav.tsx.
Related Tickets & Documents

Fixes #236
Mobile & Desktop Screenshots/Recordings

Added tests?

[ ] 👍 yes
[x] 🙅 no, because they aren't needed
[ ] 🙋 no, because I need help

Added to documentation?

[ ] 📜 README.md
[ ] 📓 docs.opensauced.pizza
[ ] 🍕 dev.to/opensauced
[ ] 📕 storybook
[x] 🙅 no documentation needed

[optional] Are there any post-deployment tasks we need to perform?
[optional] What gif best describes this PR or how it makes you feel?

Please also remove this dead link from the collapsible hamburger menu on mobile:

Please also remove this dead link from the collapsible hamburger menu on mobile:

Opened an issue on that, just to avoid scope creep. https://github.com/open-sauced/hot/issues/247. Also seems like #239 is also touch the dropdown. Probably to get that in main before too.

We can merge this in now if so, #239 needs a small anchor change and the PRs should not need rebasing unless they touch package locks! 🍕


FLC is now RRAM

Tis time to bring the RRAM branch into master.
@sleitner

Did a quick re-review :+1:


AquariusOne: Blacklist this-is-a-test-gotta-get-deploy-not-master-after-pr.io

AquariusOne requests the blacklist of the following website(s):

this-is-a-test-gotta-get-deploy-not-master-after-pr.io - MS search

this-is-a-test-gotta-get-deploy-not-master-after-pr.io has been seen in 0 true positives, 0 false positives, and 0 NAAs.

Also another test, disregard.


Question about arguments

Hi,
your code is exactly what I am looking for but I have an issue using it.
I am brand new in python and I have very basics object programming knowledge so sorry if this is a stupid question.
First, I modified the credential file using cam's IP and login and password of my two cameras
When I launch the code :
python -m joyptz --config credentials.json cam1
I obtain the error :
usage: __main__.py [-h] [--config CONFIG] [--output] camname control
__main__.py: error: the following arguments are required: control

So I understand there is a missing argument, but when I had "joystick" in the arg (seen that in the code), I have this result :
py -m joyptz --config credentials.json cam1 joystick
Traceback (most recent call last):
  File "C:\Users\obs\AppData\Local\Programs\Python\Python310\lib\runpy.py", line 196, in _run_module_as_main
    return _run_code(code, main_globals, None,
  File "C:\Users\obs\AppData\Local\Programs\Python\Python310\lib\runpy.py", line 86, in _run_code
    exec(code, run_globals)
  File "C:\python\joy-ptz-cam-main\env\lib\site-packages\joyptz-0.1-py3.10.egg\joyptz\__main__.py", line 27, in <module>
    camera = cam.Camera(config[args.camname])
  File "C:\python\joy-ptz-cam-main\env\lib\site-packages\joyptz-0.1-py3.10.egg\joyptz\cam.py", line 36, in __init__
    self.init_camera(config)
  File "C:\python\joy-ptz-cam-main\env\lib\site-packages\joyptz-0.1-py3.10.egg\joyptz\cam.py", line 41, in init_camera
    mycam = ONVIFCamera(
  File "C:\python\joy-ptz-cam-main\env\lib\site-packages\onvif_zeep-0.2.12-py3.10.egg\onvif\client.py", line 216, in __init__
    self.update_xaddrs()
  File "C:\python\joy-ptz-cam-main\env\lib\site-packages\onvif_zeep-0.2.12-py3.10.egg\onvif\client.py", line 223, in update_xaddrs
    self.devicemgmt  = self.create_devicemgmt_service()
  File "C:\python\joy-ptz-cam-main\env\lib\site-packages\onvif_zeep-0.2.12-py3.10.egg\onvif\client.py", line 333, in create_devicemgmt_service
    return self.create_onvif_service('devicemgmt', from_template)
  File "C:\python\joy-ptz-cam-main\env\lib\site-packages\onvif_zeep-0.2.12-py3.10.egg\onvif\client.py", line 312, in create_onvif_service
    xaddr, wsdl_file, binding_name = self.get_definition(name, portType)
  File "C:\python\joy-ptz-cam-main\env\lib\site-packages\onvif_zeep-0.2.12-py3.10.egg\onvif\client.py", line 292, in get_definition
    raise ONVIFError('No such file: %s' % wsdlpath)
onvif.exceptions.ONVIFError: Unknown error: No such file: C:\python\joy-ptz-cam-main\env\lib\site-packages\onvif_zeep-0.2.12-py3.10.egg\wsdl\devicemgmt.wsdl

Can you give examples of possible arguments?
Is this wrigth to replace "camera1.local" by the cam's IP?
Thanks for your help

Sounds like you're doing it right, and yes camera1.local with cam's IP is right. I think what's happening here is that there's a missing ONVIF definition file that's part of the underlying onvif-zeep library that my code uses as a dependency.
The missing file is the one in here but I'm not sure why your system isn't finding it. It should have been installed when you installed the library. You may have to adjust the directory it's looking in based on where those files got installed to.
Similar to https://github.com/FalkTannhaeuser/python-onvif-zeep/issues/13

Hi,
thanks for your quick answer!
Found the problem with your clue : the problem was the address of the file. It is located in [...]onvif_zeep-0.2.12-py3.10.egg\Lib\site-packages\wsdl
I corrected the "def init" line and it starts.
But with an other error about axes-vals... I am looking for an explanation and will open another question if necessary
(Just for keeping me searching for nothing : I want to use a gamepad - with 2 joysticks - not a 'simple' joystick, is the script theoricaly compatible?)
Thanks


[WIP] ci: Use cross-platform container for arm jobs

Commit Message:
Additional Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]

cc @ravenblackx

sadly this doesnt work given the constraints of universal heat death etc
i think we will need instead to create a small arm pool for these jobs that dont need to build/test a lot https://github.com/envoyproxy/ci-infra/pull/66

there is an issue with the arm bazel cache i need to figure out


fix: correct minor typos

Fixes some minor spelling typos:
Congradulations -> Congratulations
explicitely -> explicitly
supprting -> supporting

Thanks!

@swcurran Thanks for the merge.
Question: In two places where it's raising exceptions saying:
"Unable to get retrieve verification method for did {issuer_id}"
should those instead say:
"Unable to retrieve verification method for did {issuer_id}"
(ie. "get" is redundant when saying "retrieve")

Yup… :-(


Add examples of usage in the doc

Codecov Report

Merging #33 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #33   +/-   ##
=======================================
  Coverage   81.02%   81.02%
=======================================
  Files           3        3
  Lines         469      469
=======================================
  Hits          380      380
  Misses         89       89

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 94e28b1...9203bcd. Read the comment docs.


Unable to use colon in tag name for CDN profile

Describe the bug
When adding a tag to a CDN profile resource, if the tag name contains a colon, the error Tag cannot contain special characters. is returned.
To Reproduce
Pick a CDN profile resource (Microsoft.Cdn/profiles), try to run az resource tag with a tag containing a colon.
Expected behavior
The tag should be added to the resource, or the documentation should note this limitation.
Environment summary
azure-cli 2.1.0 on Ubuntu 18.04
Additional context
Here's an example:
$ az resource tag --ids xxx --tags foo:bar=baz
Tag cannot contain special characters.

This is distinct from the "reserved characters" error message, which is documented clearly:
$ az resource tag --ids xxx --tags foo%bar=baz
The tag names 'foo%bar' have reserved characters '<,>,%,&,\,?,/' or control characters. These characters are only allowed for tags that start with the prefix 'hidden, link'.

Trying to save a tag with a colon in the Azure Portal results in a 400 error from the batch API, which sometimes leads to a silent failure to save the tags and sometimes results in a visible error message, Could not save the tags for the resource....
This error seems to have surfaced for other resource types in the past:

https://github.com/MicrosoftDocs/azure-docs/issues/20850
https://github.com/MicrosoftDocs/azure-docs/issues/11340

add to S167.

I can't do extensive testing on it right now, but I believe the same problem exists with CDN endpoints. I'll just quote the error that Terraform is giving me:
Error: Error updating CDN Endpoint "nccrtxcdntest" (Profile "xxx" / Resource Group "xxx"):
    cdn.EndpointsClient#Update: Failure sending request: StatusCode=400 --
    Original Error: Code="BadRequest" Message="Tag cannot contain special characters."

@nachakra Hi, when we call this Service (Profiles - Create), if the tag in the parameter contains a colon, Service will return the following error:
{
  "error": {
    "code": "BadRequest",
    "message": "Tag cannot contain special characters."
  }
}

Could you please take a look~

@nachakra any update?

CDN has unique limitations on keys and only allows the following characters (per regex):
^([a-zA-Z0-9-_\s]+)$
We don't have a timeline when this limitation will ultimately be lifted. In the meantime, we will update our tag documentation for CDNs.
Our goal is to make tags consistent across all resource providers, including acceptable key characters.

@sseveringhaus-newclassrooms Apologies for the late reply. I was able to run the AzCLI command and set the tags with colon on CDN resource. Could you please test the same and get back to me if you face any issues ?
Also this issue is open for quite sometime. Please let me know if you need any further assistance on this. Awaiting your reply.

Thanks for following up, but we're no longer using Azure CDN, so I don't have a way to test this. Please feel free to close the issue.

@sseveringhaus-newclassrooms Thanks for getting back. We will now proceed with closure of this github issue. If you need any further assistance on this issue in future, please feel free to reopen this thread. We would be happy to help.


Videos rotated -90 degrees scaled too much

I had a video with a rotation of -90 degrees, the preferredTransform is  (a = 0, b = -1, c = 1, d = 0, tx = 0, ty = 720).  The video was being scaled too much. Looking in to the code, videoAngleInDegree in buildDefaultVideoComposition gets assigned a value between -180 and 180 which becomes -90 for my video. However, the following comparison checks for 90 or 270 and my video doesn't match, resulting in a video that is scaled incorrectly.
	CGAffineTransform transform = videoTrack.preferredTransform;
	CGFloat videoAngleInDegree  = atan2(transform.b, transform.a) * 180 / M_PI;
	if (videoAngleInDegree == 90 || videoAngleInDegree == 270) {
		CGFloat width = naturalSize.width;
		naturalSize.width = naturalSize.height;
		naturalSize.height = width;
	}

Problem in above code seems to be that videoAngleInDegree can be -90 but not 270. Seems odd that this hasn't come up so I am probably missing something!
I've created a fork and will submit a pull request in case. Thanks!

This is fixed in the commit below. Thank you!
https://github.com/rs/SDAVAssetExportSession/commit/4327f4a5fce5c253bc28b6a093422bd91ace1aae


Support SSR in the edge runtime with Vite dev server

Is your feature request related to a problem?
Currently, qwik (or Qwik City) uses Vite, where the dev server expects the SSR code will be run within the node runtime so it loads the code "in-place" in the dev server.
However, SSR may happen in the edge runtime (e.g., Cloudflare Workers). This causes problems when using Qwik City with the dev server. I raised the issue at https://github.com/vitejs/vite/issues/10770 which contains more details.
While there is no support on the Vite side yet, I'm thinking about the compatibility between qwik and the edge runtime when Vite provides some type of support for this.
It seems like in dev mode, qwik expects we can load the script by import (https://github.com/BuilderIO/qwik/blob/main/packages/qwik/src/core/platform/platform.ts#L15) which is generally not available in the edge runtime.
Describe the solution you'd like
I don't know what is a good way to support the edge runtime in this case, or we can also use @qwik-city-plan in dev?
Anyway, since qwik is designed "for the edge", I think it's important that we can SSR in the dev server with local edge runtime emulator (e.g., workerd).
Describe alternatives you've considered
There is no ideal workaround for this. One possible solution is to run build in watch mode and run the edge emulator with the production build, which is not only slow, but we'll lose all nice DX features.
Additional context
No response

Qwik should support all enviroments already, i am not sure i understand the issue. Qwik does not depend on any node API, when you build in production, we have integrations that configure correctly the build output to support this platforms
https://qwik.builder.io/qwikcity/adaptors/overview/

Yes, for the production deployment it should work.
This is not an issue about the compatibility of qwik codebase itself but the user's code. Currently, we can only test our website in the edge runtime using the production build. However, during development, we may want to work with a faster feedback loop, something like next dev that provides better DX support. My understanding is that currently qwik officially uses vite --mode ssr as a dev server where SSR is done in node runtime.
The issue is, how do we, during development, do SSR in edge runtime (e.g., workerd) without creating a production build, so website developers can:

use edge runtime API (e.g., Cloudflare KV) during development and ensure they are not accidentally using node API
have all features provided by (future) qwik dev server such as quick on-the-fly compilation, HMR

Vite will soon run in Deno, or it already does. So this should help! Agreed with the general problem though, but it's a bit outside the scope of Qwik, happy to have a Deno + Vite starter! would you like trying to put it together!?

This is harder than developing with dyno since edge runtime is too limited so we cannot run vite inside of it. A possible solution would be to only run SSR code in the edge runtime local sandbox (which we currently don't have a good way to load the script into yet) and do everything else with vite in node/dyno as we are doing now.
As you mentioned, this is not really the scope of Qwik. I'm creating this issue before things are ready on vite side to see if there would be some suggestions or requirements from here.
In the meanwhile, I created issues for vite and workerd at their repos to see how to solve these issues.
When things are ready, I'll try to create a PR to integrate this for Qwik

For Cloudflare bindings to work in local development, I think we can polyfill the platform params like how ppl doing it in SvelteKit here. But I'm not sure if Qwik has corresponding request hook like the one in SvelteKit.

Solid Start include's a dev server hook in the platform adaptors which allows you to set up the dev environment.
For example the cloudflare pages adaptor spins up miniflare to process requests so you can use KV, D1, R2 bindings etc... https://github.com/solidjs/solid-start/blob/main/packages/start-cloudflare-pages/dev-server.js
I'm not sure if Qwik could provide a way to do this, but would be happy to work on the adaptor if it did

Currently, the context (the platform) will be recreated for every request.
https://github.com/BuilderIO/qwik/blob/59ef8e9c6212c9f648de00b5a5d83fbdb5a1583a/packages/qwik-city/buildtime/vite/dev-server.ts#L67

we now have the vercel-edge adapter and the vite issue is fixed so presumably this is fixed.


Add support for Rocky Linux

Rocky Linux is the spiritual successor to CentOS now that CentOS 8's lifetime was cut short and only CentOS Stream will continue.

Please see #321. Thanks :bow:


Add table of contents in readme

Description
I would like to propose to add table of contents section in the readme file for easier navigation and enhance the user experience.
@mdazfar2 I want to work on it.
Please assign it to me.
Screenshots
No response
Checklist

[X] I have checked the existing issues
[X] I have read the Contributing Guidelines
[X] I'm a GSSoC'24-Extd contributor
[X] I'm a Hacktoberfest'24 contributor
[X] I am willing to work on this issue (optional)

@T-Fathima you raise the same issue many times on this repo please don't do that


feat(ui): allow to fetch OTA pre-releases

Fixes #2768

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 7 (0.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.007%) to 24.415%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

lib/ZwaveClient.ts
0
7
0.0%

Totals

Change from base Build<PHONE_NUMBER>:
-0.007%

Covered Lines:
3733

Relevant Lines:
16144

💛  - Coveralls