pkg-config file broken in beta3

In Tesseract 3 and also Tesseract 4 up till beta2 we would see:
pkg-config --cflags tesseract
# -I/usr/local/opt/tesseract/include/tesseract -I/usr/local/opt/leptonica/include/leptonica

However as of Tesseract beta 3 we get:
pkg-config --cflags tesseract
#-I/usr/local/opt/tesseract/include -I/usr/local/opt/leptonica/include/leptonica

As a result existing applications that rely on this fail to find the headers:
In file included from RcppExports.cpp:4:
./tesseract_types.h:1:10: fatal error: 'baseapi.h' file not found
#include <baseapi.h>
         ^~~~~~~~~~~
1 error generated.

Is this intended?

It is intended: You now have to write #include <tesseract/baseapi.h>.
This change was required to get unique names for the include statements.

Oh no that will break everything 🙈
Is there a trick to write an application that will compile both with the previous and new structure?

Typically the new variant will also work with old Tesseract.

Hmm the file params.h also has disapppeared?

It's still there:
https://github.com/tesseract-ocr/tesseract/blob/master/src/ccutil/params.h

Is there a trick to write an application that will compile both with the previous and new structure?

Pass an additional include dir to compiler. -Iusr/local/opt/tesseract/include/tesseract or somthing like this.

@egorpugin it's hard to automate that because the include dir is generated by pkg-config...

@amitdo the params.h header is no longer installed with Tesseract 4 beta.3:
Jeroens-MacBook-Pro:~ jeroen$ ls -l /usr/local/Cellar/tesseract/HEAD-ba757a4/include/tesseract/
total 1176
-rw-r--r--  1 jeroen  admin    1356 Jul 10 11:43 apitypes.h
-rw-r--r--  1 jeroen  admin   36681 Jul 10 11:43 baseapi.h
-rw-r--r--  1 jeroen  admin   23598 Jul 10 11:43 capi.h
-rw-r--r--  1 jeroen  admin   37193 Jul 10 11:42 genericvector.h
-rw-r--r--  1 jeroen  admin    6700 Jul 10 11:42 helpers.h
-rw-r--r--  1 jeroen  admin    1711 Jul 10 11:42 host.h
-rw-r--r--  1 jeroen  admin    9643 Jul 10 11:43 ltrresultiterator.h
-rw-r--r--  1 jeroen  admin    8363 Jul 10 11:42 ocrclass.h
-rw-r--r--  1 jeroen  admin   15187 Jul 10 11:43 pageiterator.h
-rw-r--r--  1 jeroen  admin    2162 Jul 10 11:42 platform.h
-rw-r--r--  1 jeroen  admin   12379 Jul 10 11:42 publictypes.h
-rw-r--r--  1 jeroen  admin    9061 Jul 10 11:43 renderer.h
-rw-r--r--  1 jeroen  admin    9399 Jul 10 11:43 resultiterator.h
-rw-r--r--  1 jeroen  admin    4146 Jul 10 11:42 serialis.h
-rw-r--r--  1 jeroen  admin    6807 Jul 10 11:42 strngs.h
-rw-r--r--  1 jeroen  admin    1173 Jul 10 11:43 tess_version.h
-rw-r--r--  1 jeroen  admin  360256 Jul 10 11:42 tesscallback.h
-rw-r--r--  1 jeroen  admin    7877 Jul 10 11:43 thresholder.h
-rw-r--r--  1 jeroen  admin    6508 Jul 10 11:42 unichar.h

If params.h is used by third party code like R, I'll have to add it again, so this is a regression which needs a fix.

Do you need it?

No I think I can just take it out, and publish a new release of the bindings. However users won't be able to use the current versions of the bindings with Tesseract >= 4.0.0 beta.3, but that's alright.


environmentSetupScript doesn't work

Brief Issue Summary
I'm trying to use environmentSetupScript in my defined cmake tool kit (see below) to run a script before configuring the project that prepares the environment and sets the necessary values. However, it seems this is completely ignored and the script doesn't get executed at all. In the output/log I also do not see it being mentioned before the execution of cmake.
Can you please help me with this issue?
{
    "name": "devtoolset-11",
    "environmentSetupScript": "/path/to/script",
    "compilers": {
      "C": "/opt/rh/devtoolset-11/root/usr/bin/gcc",
      "CXX": "/opt/rh/devtoolset-11/root/usr/bin/g++"
    }
}

CMake Tools Diagnostics
{
  "os": "linux",
  "vscodeVersion": "1.74.3",
  "cmtVersion": "1.14.2",
  "configurations": [
    {
      "folder": "/hidden/path",
      "cmakeVersion": "3.17.5",
      "configured": true,
      "generator": "Unix Makefiles",
      "usesPresets": false,
      "compilers": {}
    }
  ],
  "cpptoolsIntegration": {
    "isReady": true,
    "hasCodeModel": false,
    "activeBuildType": "",
    "buildTypesSeen": [],
    "requests": [],
    "responses": [],
    "partialMatches": [],
    "targetCount": 0,
    "executablesCount": 0,
    "librariesCount": 0,
    "targets": []
  },
  "settings": [
    {
      "communicationMode": "automatic",
      "useCMakePresets": "auto",
      "configureOnOpen": false
    }
  ]
}

Debug Log
No response
Additional Information
No response

Please set "Cmake: Logging Level" in settings to "debug", reload the window, run the configure again, and then share the output log here.


SQL commands WebJob in Azure App Service using SDK + System.Data.Entity

List of NuGet packages and version that you are using:

  <package id="Microsoft.ApplicationInsights" version="2.14.0" targetFramework="net472" />
  <package id="Microsoft.ApplicationInsights.Agent.Intercept" version="2.4.0" targetFramework="net472" />
  <package id="Microsoft.ApplicationInsights.DependencyCollector" version="2.14.0" targetFramework="net472" />
  <package id="Microsoft.ApplicationInsights.PerfCounterCollector" version="2.14.0" targetFramework="net472" />
  <package id="Microsoft.ApplicationInsights.WindowsServer" version="2.14.0" targetFramework="net472" />
  <package id="Microsoft.ApplicationInsights.WindowsServer.TelemetryChannel" version="2.14.0" targetFramework="net472" />

Runtime version (e.g. net461, net48, netcoreapp2.1, netcoreapp3.1, etc. You can find this information from the *.csproj file): net472
Hosting environment (e.g. Azure Web App, App Service on Linux, Windows, Ubuntu, etc.): Azure App Service - WebJob

What are you trying to achieve?
Include SQL query with dependency telemetry and record profile traces. "SQL Commands" and "Profiler" are enabled on the Application Insights pane of my App Service. This is working for the Web application (code-less).  However I also have a WebJob that's run on an interval for which I want to track SQL commands. I've installed the SDK to track custom events and include default dependency tracking.
What have you tried so far?
I've installed the SDK and opt-in to SQL commands:
        <Add Type="Microsoft.ApplicationInsights.DependencyCollector.DependencyTrackingTelemetryModule, Microsoft.AI.DependencyCollector">
            <EnableSqlCommandTextInstrumentation>true</EnableSqlCommandTextInstrumentation>
        </Add>

The SDK version for the SQL dependencies is listed as: rddf:2.14.0-17971. I'm using System.Data.SqlClient as I'm using System.Data.Entity which (afaik) doesn't support Microsoft.Data.SqlClient.
I would expect that when running on Azure App Service, with Application Insights enabled, and SQL Commands + Profiler enabled would fulfil the requirements. Those requirements mention "StatusMonitor", but how would one install such a thing on Azure App Service -- is it even required? In my Kudo dashboard I can see that the Application Insights extension is enabled. It is also running a background process named "ApplicationInsightsProfiler.exe", is StatusMonitor complementary to that, do I need both? Or is ApplicationInsightsProfiler.exe sufficient?
However the list of sources (https://XXX.scm.azurewebsites.net/ApplicationInsights) doesn't include the PID of my WebJob.

Webjobs is not in supported list when using System.Data.SqlClient.

So that means what with WebJobs it would only work with Microsoft.Data.SqlClient? As I'm using System.Data.Entity, that's doesn't work for me. So that means no SQL tracking for me?

Yes. You are right. (Sql tracking yes, but full sql query - no)

Ok, not the answer I was hoping for, but at least a definitive answer. Thank you!

I made a doc change to make it obvious that Web Jobs is not supported for full sql text. It'll go live in few days.

@cijothomas and what about profiler tracing? Is that also not supported for WebJobs?

Not supported based on my knowledge. There is no option to install a profiler in the sandbox environment of App Service in general. WebApp is special case with what is called "extensions", hence it works in Web Apps.

@cijothomas I have double checked and I am running nearly the exact scenario as @Bouke only I am using  Microsoft.Data.SqlClient but I am still unable to see the SQL commands in application insights dependency events. Is there still a bug that needs to be worked out?
Dotnet Core 3.1
Webjobs SDK 3.x
using Microsoft.Data.SqlClient
Configuration:
cfg.AddApplicationInsightsWebJobs(opts =>   {       opts.InstrumentationKey = ConfigurationResolver.Configuration["APPINSIGHTS_INSTRUMENTATIONKEY"];       opts.SamplingSettings = new SamplingPercentageEstimatorSettings       {           MaxSamplingPercentage = 70       };   });
 cfg.ConfigureTelemetryModule<DependencyTrackingTelemetryModule>((module, o) => module.EnableSqlCommandTextInstrumentation = true);


[Barcode] Support array buffer

Can be supported image type array buffer return from sources like camera?

@a7medev hello, Is it impossible?

Hi @maxinminax and @microinginer! I haven't actually tried this, but I might investigate the possibility of supporting it with the current setup whenever I have time.


npm install fails after installing in NX project using angular 12.2.0

🐞 Bug report
Description
npm fails to install after running ng add @scullyio/init in a single app nx angular project.
🔬 Minimal Reproduction
💻Your Environment
Angular Version:
12.10.0

Scully Version:
    "@angular/animations": "^12.2.0",
    "@angular/cdk": "^12.2.13",
    "@angular/common": "^12.2.0",
    "@angular/compiler": "^12.2.0",
    "@angular/core": "^12.2.0",
    "@angular/forms": "^12.2.0",
    "@angular/platform-browser": "^12.2.0",
    "@angular/platform-browser-dynamic": "^12.2.0",
    "@angular/router": "^12.2.0",
    "@nrwl/angular": "12.10.0",
    "@scullyio/init": "^2.0.2",
    "@scullyio/ng-lib": "^2.0.0",
    "@scullyio/scully": "^2.0.0",
    "angular-animations": "^0.11.0",
    "lodash": "^4.17.21",
    "message-format": "^6.2.3",
    "rxjs": "~6.6.0",
    "tailwindcss": "^2.2.19",
    "tslib": "^2.0.0",
    "zone.js": "~0.11.4"

🔥 Exception or Error

npm ERR! node_modules/@angular/common
npm ERR<EMAIL_ADDRESS>from the root project
npm ERR!
npm ERR! Could not resolve dependency:
npm ERR! peer<EMAIL_ADDRESS>from<EMAIL_ADDRESS>npm ERR! node_modules/@scullyio/ng-lib
npm ERR<EMAIL_ADDRESS>from the root project

Would you try the following steps as described in the docs:
npm/ yarn install @scullyio/init
nx g @scullyio/init:install -- --project=<projectName>

Do you still see this error then?

Yep, same error.
$ nx g @scullyio/init:install -- --project=website
    ⚠  Skipping polyfills.ts
    Install ng-lib
    ✅ Added dependency
⠼ Installing packages (npm)...npm ERR! code ERESOLVE
npm ERR! ERESOLVE unable to resolve dependency tree
npm ERR!
npm ERR! While resolving<EMAIL_ADDRESS>npm ERR! Found<EMAIL_ADDRESS>npm ERR! node_modules/@angular/common
npm ERR<EMAIL_ADDRESS>from the root project
npm ERR!
npm ERR! Could not resolve dependency:
npm ERR! peer<EMAIL_ADDRESS>from<EMAIL_ADDRESS>npm ERR! node_modules/@scullyio/ng-lib
npm ERR<EMAIL_ADDRESS>from the root project
npm ERR!
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force, or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution.

@pietschy I pushed an updated @scullyio/ng-lib' to npm, with a different version number notation in the package.json`
can you give that a try?


CANape 15

I'm trying to use the CANape api to talk to CANape version 15. I've noticed that you do not support 15, is this because it's just not a target or because something is different about the dll? I've tried windll and WinDLL (as used in this project). Initially I was going to use this library but found that CANape 15 was unsupported.
Thanks for any information

I cannot test with CANape 15, but it might work. I'd say just try and report back.

Thanks, I'll test it on current python with CANape15 monday, I don't have the software at home.
I'm currently writing a python lib in rust for this but if I'd just be replicating work then I'll scrap it in a heartbeat.
We use a handful of different CANape versions at work with more to come, and other tools. I was
going to make a universal multipurpose library, been having trouble with python and the dll but rust is working (I don't like the borrow checker, I like that the package manager and the build system are built in and tied together so there aren't issues handling libraries).

@zariiii9003 It appears that canape 15 is at least trying to work with errors about functions not being found.

Running more tests, will confirm

Yeah, I think this is working but I'm going to have a couple pull requests from going over the initial documentation, thinking about adding enter and exit so that canape can just be called as a context manager so you don't have to worry about whether exit is called. I'll also submit a pr with canape15 to add to the documentation if this ends up fully working

Also if you don't mind, I'd like to add a pdf target for the documentation so I can just download that instead of having use a web browser.

Sounds good 👍


Add rate limiting decorator for client

Currently there is a rate limiting service, but the implementation should be simple enough to share with a client in cases where clients connect to external services and therefore want to be extra careful with rate limiting.

Sounds like a good idea. What would be an expected behavior when rate limit is exceeded?


Make lambda permission statement id unique across rest/http gateway

Pulumi doesn't destroy the permission before creating when swapping from REST to HTTP.
Standard checks

Unit tests: Any special considerations?
Docs: Do we need to update any docs, internal or public?
Backwards compatibility: Will this break existing apps? If so, what would be the extra work required to keep them working?

My name is Ala Shiban, I'm the founder of Klotho and used to lead the platform team at Riot Games (League of Legends, Valorant).
We recently launched the open-source version - it's a pure-code tool for AWS that understands normal code and transforms it to cloud code that runs natively on AWS.
I was wondering if you would be willing to try the getting started tutorial and share your personal impressions? (Not for work). The team and I look at these, and it would help us iterate better. I'd be happy to publicly thank you on our web site or social media.
Would that work for you?
P.S a ⭐ github star would mean a lot <3

Disregard previous comment please


fix: preserve heights order when adding new toasts

PR Checklist
Please check if your PR fulfills the following requirements:

[X] The commit message follows our
guidelines: https://github.com/tutkli/ngx-sonner/blob/main/CONTRIBUTING.md#-commit-message-guidelines
[ ] Tests for the changes have been added (for bug fixes / features)
[ ] Docs have been added / updated (for bug fixes / features)

PR Type
What kind of change does this PR introduce?

[X] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Closes #7
What is the new behavior?
Heights are sorted according to toasts order.
Does this PR introduce a breaking change?

[ ] Yes
[X] No

Other information

:tada: This PR is included in version 0.4.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


support underscore as digits delimeter

Coverage increased (+1.1%) to 93.103% when pulling 489c7e2135f42030f3c247d005d11bbe474adea6 on underscore into b939cf5c7c6e7d944d1a09c1adac105acef57153 on master.


Does not work with Obsidian 1.6.7

After installing and enabling the extension, there is no "trash" button on the ribbon and there is no "show trash explorer" in the command menu.

Sorry to say I can't reproduce this in Obsidian 1.6.7. I followed this procedure:

Created a new local vault in desktop Obsidian 1.6.7
Opened settings and enabled community plugins
Clicked "Browse"
Searched for Trash Explorer
Clicked "Install"
Clicked "Enable"

The "Open trash explorer" icon then appeared as the last item in the ribbon and the two plugin commands became available. Can you share more information about your setup?

It works in Obsidian 1.6.7. It appeared in the left sidebar, and the command palette actions became available.
Then after I ran its "Open Trash" command, an extra trash button appeared in the top bar.
It's definitely working.

Thank you for the info @Arcitec. I'm closing this issue.

Seems like the problem was there was a symbolic link in my trash folder. It was preventing the extension to load.

@malaybasu @proog Interesting. Was the symbolic link broken, or leading to a location that Flatpak Obsidian cannot reach?
Maybe the trash extension should gracefully skip files that it doesn't have permission to open.

Very interesting, that does sound like a bug. I'll try to take a look at this soon unless someone beats me to it :)

@Arcitec Not sure about broken link. I deleted the link. But this can be easily tested. I will test it and let you know.
Skipping file gracefully is a good idea.

The issue does seem to be related to broken links. Obsidian's internal file system adapter throws an error when listing the files during this call (assuming a broken symlink inside .trash):
https://github.com/proog/obsidian-trash-explorer/blob/4d9bc2c4977d79af116b369904c8f68d1c164b28/src/models.ts#L28
There's no obvious workaround to add to the plugin, so I've reported the bug on the Obsidian forum.
As for valid symlinks, it's probably a good idea to ignore them for consistency with Obsidian's own file explorer. Symlinks are currently treated as any other file and can be deleted and restored, but symlinks won't be visible after restoring them.


Cherry pick backcompat stuff (2.1)

Cherry-pick three commits (two about enhanced GDScript) and one about new methods for Node2D.
All of them are back-compatible with 2.1 so it should be safe to merge this.

@RandomShaper I think it should be merged into 2.2, not sure though.

@RandomShaper I think it should be merged into 2.2, not sure though.

All this is already in 2.2 :)
As for what should be done in the 2.2 branch, that's up for discussion, but it was not really created to be worked on, just for people who need to stay on a stable-ish devel commit. Now, if there's a strong community interest to develop it further, we could name a branch maintainer like they do for the kernel - as for myself I don't want to work on it, master and 2.1 is enough work :)


Binaries are causing failures

After compiling, the binaries are causing failures when transferred to the board.  Working with Russ, he said that the application offset in ROM is incorrectly set.

Fixed by https://github.com/ARMmbed/mbed-os/pull/4496/files

Can confirm the patch works!


C API example

can be useful for #4240

Maybe just add a test to make sure we dont break it.. In our jenkins we could add a script test_demos.sh and start adding the other demos eventually too.

After looking at the build system, I think we need to wait for refactoring and add tests for the demos in a later PR with a little more thought.


chore: release notes for 7.1.0

Overview
Adds release notes for 7.1.0.
Test Plan

Check the markdown preview on GitHub.
Post-merge, check how these appear in the app and robot update flows.

Changelog

Updates to the usual two release-notes.md files.
Added some trailing periods in 7.0.2 notes. 🧐

Review requests
Any features that I missed or miscategorized (app vs. API)?
Risk assessment
Low. No code, but high-visibility text once we reach stable.

also swapped a couple characters in the pr title

also swapped a couple characters in the pr title

lol thx. merging now, will open new PRs for later alphas if needed.


regimen editor bulk days selection

Coverage increased (+0.2%) to 16.651% when pulling a411fcfebfe0520e271b6f21b0908dbf453e4484 on gabrielburnworth:master into 24f43c695a1590bda56acc92478d634c99feaac1 on FarmBot:master.

Coverage increased (+0.2%) to 16.651% when pulling db908604d3ceec8cfbb3871e495a8b06944834ef on gabrielburnworth:master into 24f43c695a1590bda56acc92478d634c99feaac1 on FarmBot:master.


validation depending on status of other field

I'm trying to implement form validation via a component, which receives it's model from the route.
This is working fine for most fields, but there are 2 fields that only need to be validated when one of the other fields, a checkbox, is set to true.
How can I do this?
I tried via an action which is triggered whenever the checkbox is toggled, but I don't see how I can access the validate() or validateSync() method from within that action.
This is the code in route.js:
import Ember from 'ember';

var registration = {
    company: false,
    companyName: '',
    vat: '',
    username: '',
    email: ''
};

export default Ember.Route.extend({
  ,model: function() {
    return registration;
  }
});

And this is the code in component.js:
import Ember from 'ember';
import { validator, buildValidations } from 'ember-cp-validations';

var validations = buildValidations({
    companyName: [
        validator(function(value, options, model/*, attribute*/) {
            // In case of company account, the company name should not be empty
            if (model.company) {
                return (value);
            }
            else {
                return true;
            }
        }, {
            message: 'company name required'
        })
    ],
    vat: [
        validator(function(value, options, model/*, attribute*/) {
            // In case of company account, the VAT number should not be empty
            if (model.company) {
                return (value);
            }
            else {
                return true;
            }
        }, {
            message: 'vat number required'
        })
    ],
    username: [
        validator('presence', {
            presence: true,
            message: ' '
        }),
        validator('length', {
            min: 3,
            message: ' '
        })
    ],
    email: [
        validator('presence', {
            presence: true,
            message: ' '
        }),
        validator('format', {
            type: 'email',
            message: 'invalid email address'
        })
    ]
});

export default Ember.Component.extend(validations, {
    registration: function() {
        return this.get('model');
    },
    actions: {
        // Explicit validation when checkbox is toggled:
        toggleCompany() {
            this.get('validateSync')();
        }
    }
});

This results in the following error:
Uncaught Error: Assertion Failed: Cannot call get with 'validations' on an undefined object

So how can I trigger a manual validation from within a component action?
Or is there a better way to do this?

What you actually want is to validate the registration object but you are instead validating the component which doesnt have any of the fields you are validating. Currently, in your component, you are validating username, email, etc. which acutally exist on the registration attribute.
In this case, I would suggest placing your validations on the model.
import Ember from 'ember';
import { validator, buildValidations } from 'ember-cp-validations';

var validations = buildValidations({
    companyName: [
        validator(function(value, options, model/*, attribute*/) {
            // In case of company account, the company name should not be empty
            if (model.company) {
                return (value);
            }
            else {
                return true;
            }
        }, {
            message: 'company name required'
        })
    ],
    vat: [
        validator(function(value, options, model/*, attribute*/) {
            // In case of company account, the VAT number should not be empty
            if (model.company) {
                return (value);
            }
            else {
                return true;
            }
        }, {
            message: 'vat number required'
        })
    ],
    username: [
        validator('presence', {
            presence: true,
            message: ' '
        }),
        validator('length', {
            min: 3,
            message: ' '
        })
    ],
    email: [
        validator('presence', {
            presence: true,
            message: ' '
        }),
        validator('format', {
            type: 'email',
            message: 'invalid email address'
        })
    ]
});

var registration = Ember.Object.Extend(validations, {
    company: false,
    companyName: '',
    vat: '',
    username: '',
    email: ''
});

export default Ember.Route.extend({
 model: function() {
    return registration.create();
  }
});

And in your component
export default Ember.Component.extend({
    registration: null
    actions: {
        // Explicit validation when checkbox is toggled:
        toggleCompany() {
            this.get('registration').validateSync();
        }
    }
});

On that note, I do like the idea of being able to enable/disable validations
validator('presence', {
  presence: true,
  enabled() { return this.get('model.validateFoo'); }
})

A more useful case for this would be
{
  'username': {
    enabled() { return this.get('model.shouldValidate'); },
    validators: [ validator('presence', true)]
  }
}

@stefanpenner @rwjblue what do you guys think of this feature? Implementing this is fairly simple but a couple question arise.

Do we treat a disabled validation as a validator that just returns true?
If an attribute is in an invalid state and enabled is switched from true to false, should that attribute (or the specific validation of that attribute) be changed to valid?

Thanks for the explanation, but I don't fully understand what's wrong with my initial approach.
According to the docs, I should be able to do the validation on the component, which is what I was doing and it worked great, apart from the checkbox issue.
Nevertheless, I tried to refactor my code to what you suggested.
Initially I got some errors, but after some extra refactoring (using separate model.js file, injecting container, etc) it works, but not any better than before.
Actually it's worse, because now my fields are all dirty on initial load, which wasn't the case before.
Explicitly calling the validateSync() action doesn't seem to have any positive effect either.
More specifically, after toggling the 'company' checkbox the validators for companyName and vat don't get called until I explicitly enter some text in the corresponding input fields.
Any other ideas how I might get this working?

@santo74 my apologies, I guess I didnt fully understand your original implementation. Unfortunately as of right now, I cant really think of a good way to do this without implementation of the suggested enabled option feature specified up top. One other possibility of doing this is to have two different components (one with full validations, one without the 2 field validations).
{{#if hasCompany}}
  {{foo model=model}}
{{else}}
  {{bar model=model}}
{{/if}}

// components/foo.js

const Validations = buildValidations({...});
export default Ember.Component.extend(Validations, {...});

// components/bar.js
import Foo from './foo';
const Validations = buildValidations({...});
export default Foo.extend(Validations, {...});

Although this is a bit dirty, I believe it should work. If not, ill try to speed up the process on the enabled option :smile:

Ok, thanks for the suggestion, I might try the workaround with 2 components, although it is definitely a hack ;-)
The enabled option would be a nice solution indeed.
On the other hand I don't understand why the explicit call to validateSync() doesn't trigger a new validation of the fields.
What I noticed is that the model field returned by validateSync() is "undefined":
const { model, validations } = this.get('model').validateSync();
console.log('model: ', model);

results in
model: undefined

Not sure why that would be, but maybe this is an indication for why the validation isn't performed?
FYI: The problem with the fields being dirty was because they were initialized with "" instead of null.

Can you provide your current implementation? If you have switched over to validating over a model instead of a component, having two components wouldn't make sense. You would instead have to have two separate model definitions with the different validations.

Yes, I switched to validation over a model as you suggested, but I'm not sure if/how I can switch a route's model on the fly.
Also this would affect the 'company' flag, which is used for the condition in the template.
However, I was able to solve it by setting up an observer for the company checkbox, which touches the companyName and vat fields on change:
component.js:
export default Ember.Component.extend({
    watchCompany: function() {
        if (this.get('model.company')) {
            this.set('model.companyName', '');
            this.set('model.vat', '');
        }
        else {
            this.set('model.companyName', null);
            this.set('model.vat', null);
        }
    }.observes('model.company')
});

This forces validation of the companyName and vat fields whenever the company checkbox is toggled.
Probably not the cleanest solution, but at least it's solving the problem until the enabled/disabled option gets implemented.

:+1: okay cool! I'm glad you have a temporary working version in place for now. Im just waiting on a review for #106 and that should replace the need for this :smile_cat:

@santo74 v2.3.0 has been released with the ability to enable/disable validations. See docs here

Thanks, exactly what I needed!


SQLSTATE[HY000] [1045] Access denied for user 'user'@'host' (using password: YES)

Hi,
I am getting this issue while install of 3.10 (git v3.10.4-3-g176ec48) ( Downloaded from https://xerte.org.uk/index.php/en/downloads-1/category/3-xerte-online-toolkits )
SQLSTATE[HY000] [1045] Access denied for user 'user'@'host' (using password: YES)
MySQL 5.5.62
OS Centos 6
Browser FireFox 91.0b6
PHP 5.3

@GaneshKandu I downloaded the same zip file and installed it on xampp. That works fine.
So, in principle, it works. There are 3 locations where you need to supply a username and password. Two of those are related to MySQL, one is not.
The first username/password needs to be a mysql user that is allowed to create a database. It is on the age where you specify the mysql server (localhost y default) and the name of the database.
Then, tyou get a page where you can supply a (potentially) different mysql user that will be used when running the software. This mysql user does not need to have the permissions to create a database but needs to have the rights to create/alter table (to be able to install upgrades) and write to the database.
The last username/password is for Xerte's management.php page. So, one of the first two combinations is wrong. You can check the second in database.php. Those users already need to exist.

Thanks !


Add ERC: Solana Storage Router

The following standard is an extension to the Cross-chain Storage Router Protocol (EIP-7700; #404) introducing storage router for Solana.

Hi @SamWilsn,
Thanks for your review! I've fixed and merged some of your comments.

From a quick skim, this doesn't appear to have enough information to be a complete standard.

Could you please elaborate the crucial aspects that are yet missing. We'll add them right away! If the missing parts are in the text and explanation, some/all of them will be fixed in the next commit.

Hi @SamWilsn,

If the missing parts are in the text and explanation, some/all of them will be fixed in the next commit.

I have added what I think is sufficient detail in the abstract. If you find more sections needing explanation, please let me know!

Not sure why, but the Label Bot is throwing an error out nowhere. I only updated the branch.


Slider to update playback speed

Description
Currently we have two dcc.Interval objects (data_interval and figure_interval), in charge of updating the data and figures. The time-interval of these two objects is specified manually in the code, and fixed to 7 seconds for both. This way we get data and figure updates at the same rate, but the interval objects are not linked in any way so updates don't necessarily occur on the same cycle (i.e. the figures may wait several seconds after the data has updated before updating themselves). Also, since the time-interval is fixed in the code it can't be changed from the app.
I have three main goals with this pull request:

Synchronise figure updates with data updates (i.e. have figures detect when the data changes and update accordingly, rather than running on their own interval)
Terminate updates once the pre-set data has reached the end
Add a slider to the control page so the time-interval can be adjusted from the app

The overall approach is fairly convoluted but the simplest I could come up with and seems to work. The main steps can be summarised as follows:

I have changed figure_interval to a dcc.Store object which just contains a value and doesn't increment on its own. The update_figure_interval callback runs in the background and is responsible for synchronising figure_interval with data_interval (via the N_INTERVALS_DATA global variable).
The update_figures callback on each of the figure pages then responds whenever figure_interval changes and triggers the figures to update
Once the pre-set data has reached the end, the update_data callback will switch the disabled property of data_interval to True. This prevents data_interval from incrementing any further, therefore terminating data and figure updates.
The time-interval for updates is now set from the control app. I've added a slider on the middle of the page (ranging from 2s to 10s, with a default value of 7s). This is linked to a callback (update_data_interval) which updates the interval attribute of data_interval.

Note: When the live model is being used this will only change the rate at which the data is pulled in and the figures updated, it  doesn't interact with the model in any way so won't change the speed of the simulation or anything like that. When using the pre-set data, we add one new timepoint each interval, so this does change the rate at which new data appears.
Control app:

Close #97
Type of change

[x] New feature (non-breaking change which adds functionality)
[ ] Optimization (non-breaking, back-end change that speeds up the code)
[ ] Bug fix (non-breaking change which fixes an issue)
[ ] Breaking change (whatever its nature)

Key checklist

[x] All tests pass (python -m pytest)
[x] Pre-commit hooks run successfully (pre-commit run --all-files)

BUT, when working with data produced by the models live, there might be issues if requesting data too fast as there might not be new data. I seem to remember that the agents model produces data and pushes it to Gridlington precisely every 7 seconds, and that's where that number is coming from. I am not entirely sure how this changes in the visualisation side of things will get along with slow data ingestion in the data hub.

If the model has a fixed interval of 7 seconds then it probably makes sense to hide the slider when using the live model, as it won't really do anything apart from changing how quickly the plots update. If the model interval is something that can be configured, then we could get the controller to send signals to the model to update the interval (similar to what I'm doing in #109 for start/stop signals), but not sure if this is desired.
Maybe something to discuss with Yue/Phil, but for now I think we should just hide the slider when using the live model and keep the interval fixed to 7 seconds.


Per-band unscaling works with indexes

This updates the per-band unscaling to support when indexes=[...] are passed. I didn't account for that in the PR a couple days ago, sorry about that!
Fortunately a quick fix to select from the scales/offsets arrays so that they continue to match the shape of the image data. I've been testing this with files we make containing dozens of bands with different (or no) scale/offset rules and I haven't noticed any issues with mismatching or incorrect shapes.
You also should be able to edit this forked repo now. Not sure what I'm missing in the settings, but it is part of my work org and maybe there's something I can't see getting in the way by default. I added you with write permission on the repo to hopefully get around that.

oohhh thanks for catching this 😅 🙏

BTW @jddeal I don't need to be added to aerisweather/rio-tiler repo. Usually when creating a PR from fork you can allow maintainers to push directly in the fork https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/allowing-changes-to-a-pull-request-branch-created-from-a-fork

finished in #710


Webpack 3.7.0 and above slow build

Short description of the problem:
When webpack is updated to 3.7.0 and above, webpack build step takes much longer time and more memory.
What behavior are you expecting?
Webpack build step should be almost identical after update.
Debug mode ionic serve log. Identical project codes and npm packages except webpack.
Webpack 3.7.1
Webpack step is 1 minute slower and use ~200MB more memory compared to webpack 3.6.0
[22:52:22]  watch started ... MEM: 158.6MB
[22:52:22]  build dev started ... MEM: 158.7MB
[22:52:22]  clean started ... MEM: 158.5MB
[22:52:22]  clean finished in 25 ms MEM: 159.1MB
[22:52:22]  copy started ... MEM: 159.1MB
[22:52:23]  deeplinks started ... MEM: 174.3MB
[22:52:23]  deeplinks finished in 608 ms MEM: 209.4MB
[22:52:23]  transpile started ... MEM: 209.4MB
[22:52:29]  transpile finished in 5.86 s MEM: 438.2MB
[22:52:29]  preprocess started ... MEM: 438.2MB
[22:52:29]  copy finished in 6.81 s MEM: 439.9MB
[22:52:29]  preprocess finished in 125 ms MEM: 443.7MB
[22:52:29]  webpack started ... MEM: 443.7MB
[22:53:48]  webpack finished in 79.33 s MEM: 1206.0MB
[22:53:48]  sass started ... MEM: 1206.0MB
[22:53:51]  sass finished in 2.11 s MEM: 1205.2MB
[22:53:51]  postprocess started ... MEM: 1205.2MB
[22:53:51]  postprocess finished in 46 ms MEM: 1209.8MB
[22:53:51]  lint started ... MEM: 1209.8MB
[22:53:51]  build dev finished in 88.51 s MEM: 1209.9MB ```

Webpack 3.6.0
[22:47:08]  watch started ... MEM: 159.4MB
[22:47:08]  build dev started ... MEM: 159.5MB
[22:47:08]  clean started ... MEM: 160.4MB
[22:47:08]  clean finished in 35 ms MEM: 160.9MB
[22:47:08]  copy started ... MEM: 160.9MB
[22:47:09]  deeplinks started ... MEM: 175.4MB
[22:47:09]  deeplinks finished in 578 ms MEM: 188.9MB
[22:47:09]  transpile started ... MEM: 188.9MB
[22:47:15]  transpile finished in 5.50 s MEM: 429.2MB
[22:47:15]  preprocess started ... MEM: 429.2MB
[22:47:15]  copy finished in 6.42 s MEM: 429.4MB
[22:47:15]  preprocess finished in 126 ms MEM: 434.3MB
[22:47:15]  webpack started ... MEM: 434.3MB
[22:47:30]  webpack finished in 15.24 s MEM: 1042.8MB
[22:47:30]  sass started ... MEM: 1042.8MB
[22:47:32]  sass finished in 1.97 s MEM: 1041.7MB
[22:47:32]  postprocess started ... MEM: 1041.7MB
[22:47:32]  postprocess finished in 47 ms MEM: 1045.7MB
[22:47:32]  lint started ... MEM: 1045.7MB
[22:47:32]  build dev finished in 23.90 s MEM: 1045.7MB

Which @ionic/app-scripts version are you using?
3.0.0

I have the same issue. Do you know how can I revert to Webpack 3.6.0?

I have the same problem. My production build went from 12 minutes to 26 minutes after upgrading to the new webpack that I got from<EMAIL_ADDRESS>

I have the same problem, with a 70+ module ionic app my build time is around 70s.
But I tried to use Webpack 3.8.1 directly in my dev dependencies, which cuts the build time in half using `ionic serve'. This is at least better, than before.
Webpack 3.7.1 as transitive dependency.
$ ionic serve
Starting app-scripts server: --address <IP_ADDRESS> --port 8100 --livereload-port 35729 --dev-logger-port 53703 - Ctrl+C to cancel
[18:52:02]  watch started ...
[18:52:02]  build dev started ...
[18:52:03]  clean started ...
[18:52:03]  clean finished in 3 ms
[18:52:03]  copy started ...
[18:52:03]  deeplinks started ...
[18:52:03]  deeplinks finished in 393 ms
[18:52:03]  transpile started ...
[18:52:08]  transpile finished in 4.94 s
[18:52:08]  preprocess started ...
[18:52:08]  preprocess finished in 1 ms
[18:52:08]  webpack started ...
[18:52:08]  copy finished in 5.59 s
[18:53:14]  webpack finished in 66.34 s
[18:53:14]  sass started ...
[18:53:15]  sass finished in 995 ms
[18:53:15]  postprocess started ...
[18:53:15]  postprocess finished in 104 ms
[18:53:15]  lint started ...
[18:53:15]  build dev finished in 73.01 s
[18:53:16]  watch ready in 73.58 s
[18:53:16]  dev server running: http://localhost:8100/

3.8.1
Starting app-scripts server: --address <IP_ADDRESS> --port 8100 --livereload-port 35729 --dev-logger-port 53703 - Ctrl+C to cancel
[19:22:28]  watch started ...
[19:22:28]  build dev started ...
[19:22:29]  clean started ...
[19:22:29]  clean finished in 4 ms
[19:22:29]  copy started ...
[19:22:29]  deeplinks started ...
[19:22:29]  deeplinks finished in 395 ms
[19:22:29]  transpile started ...
[19:22:34]  transpile finished in 4.78 s
[19:22:34]  preprocess started ...
[19:22:34]  preprocess finished in 1 ms
[19:22:34]  webpack started ...
[19:22:34]  copy finished in 5.43 s
[19:22:58]  webpack finished in 24.40 s
[19:22:58]  sass started ...
[19:22:59]  sass finished in 946 ms
[19:22:59]  postprocess started ...
[19:22:59]  postprocess finished in 82 ms
[19:22:59]  lint started ...
[19:22:59]  build dev finished in 30.83 s
[19:23:00]  watch ready in 31.30 s
[19:23:00]  dev server running: http://localhost:8100/

ionic info
cli packages: (C:\Users\moberwasserlechner\Development\git\team-conductor-go\node_modules)

    @ionic/cli-utils  : 1.14.0
    ionic (Ionic CLI) : 3.14.0

local packages:

    @ionic/app-scripts : 3.0.1
    Ionic Framework    : ionic-angular 3.7.1

System:

    Node : v6.9.5
    npm  : 3.10.10
    OS   : Windows 10

A fix for me was using<EMAIL_ADDRESS>But since today when updating to ionic-app-script 3.1.0 this is not working anymore, and production build time went from 12 minutes to 30 minutes.
Also I can't do the ionic serve

I see, since<EMAIL_ADDRESS>is dependent on webpack 3.8.1 so adding webpack 3.6.0 separate will not help anymore

Hi @danbucholtz, would like to check whether this issue has to wait to be resolved at webpack's end since it is not resolved in the recent app script update? The long build time makes app script unusable.

@tanzl88 I also opened an issue at the webpack repo
https://github.com/webpack/webpack/issues/5876
They are asking for a repo that has the problem for them to check, but I am sadly not able to reproduce on a new ionic app and can't send my company's app. Do you have a sample repo that you can give them to check?

@tanzl88,
We'll take a look. This is sort of strange. I wonder why that would be. Worst case, I don't see any reason we couldn't go back to 3.6.0 potentially (not sure if that support ModuleConatenationPlugin or not).
Thanks,
Dan

@dmastag are you usingmax_old_space_size? How much memory do you see used during the build process?
I am only asking because, I was using max_old_space_size in my package.json scripts for ionic:build and server but then was building using ionic cordova build, to which max_old_space_size was not being applied (I realised after looking to mem usage during build) and was having the same behaviour. Running ionic cordova build with a larger max_old_space_size than the used memory, returned my build process to its previous acceptable performance levels.

@dmastag your build was 12 minutes? How?!

@masimplo yes, actually I am
Here is an excerpt from https://github.com/webpack/webpack/issues/5876#issuecomment-339993516

ionic serve takes a long time and in windows Task manager the amount of memory does not go above 750MB

But on 3.6.0 it can go up to 1.3GB and is working in 2 minutes to load my app.

So are you suggesting that I set the --max-old-space-size=4096 to a higher value?
But this would only be for production builds, any advice on ionic serve?
@mlynch correct
The following are the builds using gitlab-ci
Using<EMAIL_ADDRESS>

Using<EMAIL_ADDRESS>

That's crazy. Are you doing anything special? What does your app look like (i.e. anything that would cause builds to be that slow)?

Not sure, I have 238 lazy loaded IonicPages
and the packages and app.modules that I use have nothing special
Though this app has been using ionic since angular 2.0.0-rc.4 and ionic-angular 2.0.0-beta.11
But I am sure to upgrade every time based on the release notes

@dmastag okay that explains it 😅  Why so many pages? Could probably cut down on it if you generalize them somehow, but I don't know your app

@dmastag do you have any entries in your package.json scripts looking like these?
    "ionic:build": "node --max_old_space_size=4096 ./node_modules/.bin/ionic-app-scripts build",
    "ionic:serve": "node --max_old_space_size=4096 ./node_modules/.bin/ionic-app-scripts serve",

these should address both build and ionic serve.

@masimplo Yes I do, because I get a exceed memory error if I don't use that

I had 2048 on these two and was getting a really slow build and sometimes out of memory exceptions. I raised them to 4096 and builds are back to normal build times. Did you try setting it to something like 8GB? You have a large project so it wouldn't be the weirdest thing to use a lot of memory.

@masimplo, @dmastag,
If you want to use those commands to increase memory, make sure you call the npm scripts directly. So npm run ionic:build or npm run ionic:serve. The ionic cli doesn't call the npm scripts anymore.
Thanks,
Dan

@dmastag For our app, I needed to allocate 8GBs for node to get a successful build after updating to 3.0.1, and that still took 30 mins to build with ngc. We also have a pretty large app, but we never encountered any issues until the update (We were using app-scripts 1.3.7 previously). Maybe increasing your node memory limit would also help for you?
But either way, upgrading webpack/ionic-app-scripts shouldn't yield such drastic build time difference, and I believe many others with similarly non-trivial size apps have been facing the same issue. I can't help but think upping the node memory limit as the app size inevitably increases is just putting a band-aid to the problem. We are currently stuck on<EMAIL_ADDRESS>that uses<EMAIL_ADDRESS>because the new version of ionic-app-script is practically unusable for our app unless we allocate like 10GBs to node. Reverting app-scripts back to an older version immediately reduces our AOT build time back to a reasonable amount of time (2GBs memory limit on node. Build time takes about 3-5 mins on AOT)

I have the same problem with @dmastag , my app have nearly 300 lazy loaded IonicPages, after upgrading to<EMAIL_ADDRESS>is dependent on webpack 3.8.1, and production build time went from 10 minutes to 30 minutes.

Do you have any preformance improvement ?

Hello everybody. I know I am late to the convo... BUT, my slow webpacks came from upgrading "@ionic/app-scripts": "2.1.4" to "3.1.7-201801172029".... So, by uninstalling app-scripts and reinstalling version 2.1.4, I was able to go from 70 second build times to 13 second build times and, best of all, 7 second incremental build times. So, try the following and see if it helps!!!
npm uninstall @ionic/app-scripts
npm install<EMAIL_ADDRESS>Hope it helps!

I totally confirm that downgrading from<EMAIL_ADDRESS>to<EMAIL_ADDRESS>makes incremental builds go from ~30 sec to ~5 sec
would be good to understand why :)

Hey all. We're aware of this, but we don't have a solution right now. If 2.1.4 works for you, awesome. With Ionic 4's angular support, we don't need app scripts anymore, we will use the ng cli toolchain. I'm not saying that will solve these problems because some are inherent to the Angular build process, but it should help.
Stay tuned for that, we're getting close to the alpha release this Spring.

@mlynch do you know what we lose in using<EMAIL_ADDRESS>I must admit I don't exactly understand what these scripts do, and how they relate with webpack. I'm currently using<EMAIL_ADDRESS>with latest<EMAIL_ADDRESS>it seems to work, but maybe I miss something.
I'm so glad that you decided to use ng cli in next version. Good choice, IMHO 👍
Good luck for Ionic 4. We really wait for it, as Ionic 3 is stuck with annoying bugs :(

On the choice: yea, and it's much less for us to have to maintain, so we can focus more on the components!
You shouldn't lose much, at this point ng cli has overlapped with app scripts pretty well

I confirm that with version 3.1.2 of @ionic/app-scripts also works correctly. With that version webpack phase runs for 12 seconds (my project has ~50 IonicPage() lazy pages with its own @NgModule).
If I try one of [3.1.3 - 3.1.8] then webpack runs for almost 70 seconds (in both first start and each update on live reload).

I've got about 170 modules and moving to version 3.1.2 of @ionic/app-scripts cut my build time down from about 5 minutes to 3 and a half minutes. Still not great but better...

any one please tell me the working @ionic/app-scripts which doesn't take too much of time

Any news on when app-scripts will look into this (or if it's confirmed that it's instead a webpack's compatibility issue)? I can confirm that using 3.1.2 makes webpack work approx. 30x faster for both builds and live reloads (live reload average time of 60s down to 2s).  Will not be upgrading app-scripts beyond 3.1.2 until that is fixed.

I upgraded ionic cli to 4.3.0 yesterday, and use ionic-app-scripts 3.2.0, webpack 4.24.0.  Webpack took 180 seconds in --prod build mode, that took about 20 minutes before.  I am pretty happy with the latest version.

@zheng17 awesome
Could you explain step by step how you managed to get ionic-app-scripts 3.2.0 to work with webpack 4.24.0?
I want to try it out too

@zheng17 awesome
Could you explain step by step how you managed to get ionic-app-scripts 3.2.0 to work with webpack 4.24.0?
I want to try it out too

Hi @dmastag , sorry for confusing you.  I check the package version of webpack again on my local, the version is 3.8.1.  I used wrong commnad 'npm view webpack version'.
But it did faster than before.

Thanks @zheng17
Sadly not working for me. My build usually take 35 minutes using 3.1.2 and when upgrading to 3.2.0 haven't finished after 120 minutes.

i toke 30min using --prod, too slow

It's nearly 2020 and the problem still show up. I have an app with more than 100 pages, and I am not using lazyloading. I've managed to solve this issue by running
ionic cordova build android --aot --minifyjs --minifycss

For more information #1426


Make pause image configurable

Make pause image configurable, intent to resolve issues like #176 #263 #131 #282 . It is a workaround as everyone knows that there is a Great Firewall in China.  It also works for any one who wants to  use their own pause image from a private registry.

Hi @erikwilson @galal-hussein , I've merged changes from master, and did some new changes to make pause image configurable in the template way, and removed redundant code like getPauseImage.


fix(CSI-260): lookup of NFS interface group fails when empty name provided

TL;DR
Improved NFS interface group handling and error reporting in the WekaFS API client.
What changed?

Refactored the fetchNfsInterfaceGroup function to handle default and named interface groups more efficiently.
Added more specific error messages for different scenarios.
Implemented sorting of IP addresses for consistency.
Updated the GetNfsInterfaceGroup function to use a useDefault flag for better control.

How to test?

Test fetching a default NFS interface group without specifying a name.
Test fetching a specific NFS interface group by name.
Verify error handling for non-existent interface groups.

Why make this change?
This change fixes a situation where empty interface group name did not return ANY interface group rather than first matching criteria

#340
#341  👈
dev

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @sergeyberezansky and the rest of your teammates on  Graphite

Merge activity

Sep 27, 8:57 AM EDT: @sergeyberezansky started a stack merge that includes this pull request via Graphite.


Add Empty state components and use them

How it looks so far:

TODO:

[x] add EmptyState component for "filter", "unauthorised" and "no data yet"
[x] make them fully functional

[x] Clear all filters - removed based on UX feedback
[x] Add button

[x] replace code with components

[x] filter
[x] unauthorised
[x] no data yet

[x] add check for filter/no data
[x] src/containers/collection-detail/collection-docs.tsx -> Use EmptyState with red ! icon - followup PR
[x] EmptyStateNoData -> if possible to add data use "add" icon + primary button else use "search" icon
[x] "No stuff yet" -> no headers, no footer, no pagination, just title
[x] fix redirect as it's not always not-found
[x] Exe. Env. needs to use the new nes too.

List of all pages:
Empty state - No data yet:

Collections
Namespaces
My namespaces
Users (it's there but it shouldn't happen)
Groups
Groups - select a group - click on Users tab
Repo management - Remote tab (it's there but it shouldn't happen)
Approval

Empty state - No data for filter:

Collections
Namespaces
My namespaces
Users
Groups
Groups - select a group - click on User tab
Approval

Empty state - Unauthorised:

Groups (view and add/edit)
Users (view and add/edit)
Approval

Custom "errror" state:

Collections - select a collection - click documentation tab (it's there but it shouldn't happen)

@sbuenafe-rh @fionayhlin does it look to be heading the right way?

@sbuenafe-rh @fionayhlin does it look to be heading the right way?

@ZitaNemeckova for the No users added to this group, you can shorten that title to No users

@ZitaNemeckova for the No users added to this group, you can shorten that title to No users

@ZitaNemeckova @sbuenafe-rh Should that be No users yet to match the other titles?

@ZitaNemeckova @sbuenafe-rh Should that be No users yet to match the other titles?

@fionayhlin @ZitaNemeckova yes! good catch.

@fionayhlin @ZitaNemeckova yes! good catch.

Container Registry:

Groups:

Collection documentation:

Group detail - users:

@sbuenafe-rh @fionayhlin here's new Container Registry empty pages and fixed ones. WDYT?

@himdel please have a look code-wise, thanks :)

Sure, thanks for the help getting it working :), some testing...
Repo Management > Remote tab - always shows empty state, on master there are 2 items
My namespaces - Create button doesn't work (the empty state one, the filter one does, but shouldn't be there)
Namespace & My namespaces - filter still there on empty state
(I have yet to go through the code, next comment :))
(I also noticed the UI doesn't stop me from removing the current user, which is probably a bug too, though unrelated :))
And do we have a list of all the screens with an EmptyState?

@himdel Thanks for reviewing our code! Appreciate the comments. I think @alikins is working on the issue regarding users deleting their own account. View the issue here.

@sbuenafe-rh @fionayhlin some more Empty State pages. WDYT?

@fionayhlin We agreed with @sbuenafe-rh that filter handling should stay in filter component only for this case
 I assume it included all searches. WDYT?

@himdel It's ready for another round of review. Thanks :)

I think EmptyStateUnauthorised is currently missing a screenshot, and unless it's supposed to be different..
diff --git a/src/components/empty-state/empty-state-unauthorised.tsx b/src/components/empty-state/empty-state-unauthorised.tsx
index a205ca6..bef7e2e 100644
--- a/src/components/empty-state/empty-state-unauthorised.tsx
+++ b/src/components/empty-state/empty-state-unauthorised.tsx
@@ -15,9 +15,9 @@ interface IProps {}
 export class EmptyStateUnauthorised extends React.Component<IProps> {
   render() {
     return (
-      <EmptyState variant={EmptyStateVariant.xs}>
+      <EmptyState variant={EmptyStateVariant.small}>
         <EmptyStateIcon icon={LockIcon} />
-        <Title headingLevel='h4'>
+        <Title headingLevel='h4' size='lg'>
           You do not have have access to Automation Hub
         </Title>
         <EmptyStateBody>

(And I still think Unauthorized is the proper spelling, unless Ansible is using non-US spellings?)

Would it make sense to DRY it up by implementing the other empty states on top of EmptyStateCustom?
If we move the {this.props.button && (... logic there, all the other empty states could just be built on top of it, like..
export const EmptyStateFilter = ({}) => (<EmptyStateCustom
  title="No resuls found"
  description="No results match the filter criteria. Remove all filters or clear all filters to show results."
  icon={SearchIcon}
/>);

export const EmptyStateNoData = ({ title, description, button }) => (<EmptyStateCustom
  title={title}
  description={description}
  icon={button ? PlusCircleIcon : SearchIcon}
  button={button}
/>);

export const EmptyStateUnauthorized = ({}) => (<EmptyStateCustom
  title="You do not have have access to Automation Hub"
  description="Contact you organization administrator for more information."
  icon={LockIcon}
/>);

(+- typescript and the component syntax anyway)

I'm seeing some icon changes, InfoIcon -> SearchIcon, WarningTriangleIcon -> SearchIcon, but those are all intentional, right? :)
And I'll continue tomorrow :)

@himdel Icon changes are intentional based on UX requirements. s/z is fixed. I'll do the DRY you suggested as it's really cool!
Unathorised:

@himdel last review addressed. Ready for another round. Thanks :)

Thanks, looks great :)

Is redirect ever set from outside the component, or can I assume setState({ redirect: ... only happens in the component itself?
If it's local only, would it make sense to split redirect from 404 and use a separate state param? It looks like some components (edit-namespace) still need to Redirect after update, so you're catching Paths.notFound as a special case and dealing with it differently, while others (certification-dashboard) only used Paths.notFound so the Redirect is removed and redirect is used to just mean "not there".
I'm not seeing any logic errors in the conversion :+1: , but if it's safe to split, I'd keep redirect just for Redirect and use something like setState({ notFound: true }) instead for the unauthorized empty state.
EDIT: or unauthorized like in user-edit

I do notice that filterIsSet needs to know the list of params that could be filters while AppliedFilters seems to need a list of params to ignore.. sounds like the 2 lists could get out of sync fairly quickly, new params would get ignored by filterIsSet but not by AppliedFilters, we may want to fix that by having a per screen list of filers, used by both.
And perhaps the meta params could be app global, enforcing page_size, id etc. can never be treated as a filter, regardles of whether the screen is using it or not (and we could drop the ignoredParams list). But that's probably a separate refactoring as that's not really related to this change?

I can't seem to be able to rebuild now (pkg_resources.VersionConflict: (pulp-container 2.1.0 (/venv/lib/python3.6/site-packages), Requirement.parse('pulp-container==2.3.1')), possibly related to https://github.com/ansible/galaxy_ng/pull/650 ?), so I have not tested the new changes yet.

@himdel
redirect shouldn't be set from outside. I'll fix it as suggested.
Params refactoring sounds like good idea but it's out of scope for this PR.
How to rebuild:  galaxy_ng must be on latest master, LOCK_REQUIREMENTS=1 added  in .compose.env then build and run migration (to be safe).

Ah, managed to rebuild, docker system prune -a --volumes helped, seems like the build doesn't notice changes to requirements :).

Trying to load /ui/namespaces or /ui/my-namespaces (with a fresh db):
 Cannot read property 'length' of undefined
    at NamespaceList../src/containers/namespace-list/namespace-list.tsx.NamespaceList.render (App.js:12364)

(https://github.com/ansible/ansible-hub-ui/pull/285#discussion_r578834943)

src/containers/certification-dashboard/certification-dashboard.tsx is still using the redirect: Paths.notFound pattern to display EmptyStateUnauthorized
src/containers/namespace-detail/namespace-detail.tsx is still redirecting (actual redirect) to Paths.notFound, should it be doing that?

@himdel

src/containers/namespace-detail/namespace-detail.tsx is still redirecting (actual redirect) to Paths.notFound, should it be doing that?

Yes, it gets all http://localhost:8002/ui/<ramdom stuff> calls. This my be worth refactoring later.


[feature](inverted index)WIP inverted index api: SQL syntax and metadata

Proposed changes
Issue Number: Step1.1 of DSIP-023: Add inverted index for full text search
Problem summary
Introduce a SQL syntax for creating inverted index and related metadata changes.
-- create table with INVERTED index

CREATE TABLE httplogs (
  ts datetime,
  clientip varchar(20),
  request string,
  status smallint,
  size int,
  INDEX idx_size (size) USING INVERTED,
  INDEX idx_status (status) USING INVERTED,
  INDEX idx_clientip (clientip) USING INVERTED PROPERTIES("parser"="none")
)
DUPLICATE KEY(ts)
DISTRIBUTED BY RANDOM BUCKETS 10

-- add an INVERTED index  to a table

CREATE INDEX idx_request ON httplogs(request) USING INVERTED PROPERTIES("parser"="english");

Checklist(Required)

Does it affect the original behavior:

[ ] Yes
[x] No
[ ] I don't know

Has unit tests been added:

[ ] Yes
[x] No
[ ] No Need

Has document been added or modified:

[ ] Yes
[x] No
[ ] No Need

Does it need to update dependencies:

[ ] Yes
[x] No

Are there any changes that cannot be rolled back:

[ ] Yes (If Yes, please explain WHY)
[x] No

Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 38.2 seconds
load time: 572 seconds
storage size:<PHONE_NUMBER>7 Bytes
https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20221031174821_clickbench_pr_36671.html


Turn the Vircadia Web SDK into a module.

To test...
npm i <insert path to the vircadia-web-sdk folder here>
In your project, try each:
import DomainServer from '@vircadia/web-sdk';
import DomainServer from '@vircadia/web-sdk/DomainServer';
With this test function:
DomainServer.HelloWorld('world!');

Closed in favor of #19.


homebridge-camera-ui install succeeds, but it does not work, does not follow homebridge directory structure

I have been trying to install homebridge-camera-ui via hombridge, using the plugin search and via the terminal, and the install location is not consistent with other plugins.  The install works, but you cannot access the UI or get anything to show up via the Homebridge UI.
For example, installing via Plugins...
[1/22/2022, 7:40:01 AM] [Homebridge UI] [homebridge-camera-ui] ENOENT: no such file or directory, open '/homebridge/node_modules/homebridge-camera-ui/homebridge-ui/public/index.html'
I have no /homebridge/node_modules/homebridge-camera-ui/ directory.  But the plugin shows that it is installed.

When I install via the terminal, it fails with:
3123 verbose stack Error: process terminated 3123 verbose stack     at /usr/local/lib/node_modules/npm/node_modules/@npmcli/arborist/lib/arborist/reify.js:194:39 3123 verbose stack     at process.<anonymous> (/usr/local/lib/node_modules/npm/node_modules/@npmcli/arborist/lib/signal-handling.js:51:5) 3123 verbose stack     at process.emit (node:events:402:35) 3124 verbose cwd /homebridge 3125 verbose Linux 5.10.63-v7+ 3126 verbose argv "/usr/local/bin/node" "/usr/local/bin/npm" "install" "--save" "homebridge-camera-ui@latest" 3127 verbose node v16.13.2 3128 verbose npm  v8.1.2 3129 error process terminated 3130 error signal SIGTERM 3131 verbose exit 1
But yet in Plugins I see it installed but no options to configure anything.

Ideally, I would like to install and manage camera.ui via Homebridge, but I cannot get an installation to work or when it does, it is not exposed via Homebridge.

Am I fundamentally missing something?

@chrisswanda
weird, i dont think that this is related to camera ui, maybe a npm issue or related to homebridge-config-ui-x ?
Try reinstalling via homebridge config ui x or
sudo npm i -g homebridge-camera-ui@latest

Strange, I tried all morning with no success.
Walked away from things for a while and came back to it.  I tore down my docker container, did a fresh pull.
Installation via Homebridge fails, so pulled via the command line inside of Homebridge terminal, and now I can configure it via Homebridge-UI.
Funny thing is I had done this numerous times prior to opening this issue.  Dunno.  Thanks for responding, closing out.

Same happened to me, after two restart from homebridge server the configuration settled


Injecting everything in ControllerGroup

Summary:
Injecting everything in ControllerGroup.
Screenshots:

@jaydeetay Can you elaborate more on this. Like what more can be injected here in the Controller group?

@jaydeetay Once I understand more I will be working on this issue, (Affirmation)

@jaydeetay @barbeau


Pretrained model not available

I try to use the link for pretrained model but showed 404. Is there any updated link or I missed something?

Thanks for your reminder,
I have fixed these links. Could you please check them again?
Best,
Yinyu

Hello, have you downloaded the pre-trained weights？I still can't open this link.


Can not get @query to work, think its broken

Description
@query is broken
I tried several notations, read the queried property in different callbacks, but no avail.
The example shows query the div, and reading it in the connectedCallback
Steps to Reproduce
import {customElement, property, query} from 'lit/decorators.js';

@query('#tree', true)
private tree!: HTMLDivElement;

Live Reproduction Link
playground link
Expected Results
query should deliver the tree object
Actual Results
Uncaught TypeError: Cannot read properties of null (reading 'innerText')
at SimpleGreeting.connectedCallback
Browsers Affected

[x] Chrome

connectedCallback runs before the first render, so in your example this.tree is null at that time. If you use firstUpdated instead of connectedCallback, then it will run after first render, and should work.


Command line parsing fail with 'Can't find the custom report class: ' when using options

PHPMD version: 2.14.0
PHP Version: 8.1.22
Installation type: composer
Operating System / Distribution & Version: alpine 3.16.4 on docker

Current Behavior
When running phpmd with an option (tested with --help and --exclude), the command fail with the following message :
Can't find the custom report class: cleancode
The command that was used was /root/.composer/vendor/bin/phpmd index.php json cleancode --exclude=*/vendor/*
Expected Behavior
The scan run on index.php with cleancode and output the result as json.
Downgrading to 2.13.0 work as expected
Steps To Reproduce:

install phpmd : composer global require --dev phpmd/phpmd:2.14
scan a php file without arguments to confirm that it work : /root/.composer/vendor/bin/phpmd index.php json cleancode
scan a php file with any arguments : /root/.composer/vendor/bin/phpmd index.php json cleancode --help or /root/.composer/vendor/bin/phpmd index.php json cleancode --exclude

Checks before submitting

[X] Be sure that there isn't already an issue about this. See: Issues list
[X] Be sure that there isn't already a pull request about this. See: Pull requests
[X] I have added every step to reproduce the bug.
[X] If possible I added relevant code examples.
[X] This issue is about 1 bug and nothing more.
[X] The issue has a descriptive title. For example:  "JSON rendering failed on Windows for filenames with space".

Hello, I'll fix that. Note that you can use phpmd index.php json cleancode --exclude */vendor/* (space instead of equal before the value) meanwhile.

As a side note, --exclude=*/vendor/* syntax was never supported, this part was just silently ignored in PHPMD 2.13.0 if I'm not mistaken. So it's was not actually "working".
Also can you show how you get similar issue with --help?

Hello, thank for the quick feedback, i confirm that using the space instead of equal sign make the command work as expected.
For the --help case, i'm doing this command :
/root/.composer/vendor/bin/phpmd /web/html/web/index.php json cleancode --help
On 2.14, i have Can't find the custom report class: cleancode as an output
On 2.13, i have as an output :
{
    "version": "@package_version@",
    "package": "phpmd",
    "timestamp": "2023-09-27T12:15:03+00:00",
    "files": []
}

Something that i just saw, it seem like there is no --help command, so it would seem that unknown argument was just ignored previously as you said, and now trigger this error instead of saying that the option is not allowed

To add on the previous comment :
$ /root/.composer/vendor/bin/phpmd /web/html/web/index.php json cleancode --cache
{
    "version": "@package_version@",
    "package": "phpmd",
    "timestamp": "2023-09-27T12:20:55+00:00",
    "files": []
}

$ /root/.composer/vendor/bin/phpmd /web/html/web/index.php json cleancode --help
Can't find the custom report class: cleancode

$ /root/.composer/vendor/bin/phpmd /web/html/web/index.php json cleancode --thisDoesntExist
Can't find the custom report class: cleancode

The behavior about --cache seem ok, with --help or --thisDoesntExist i would expect more an error about the argument that about the report class (but i understand that it may be a report class with argument)

Issue there is that we'll now consider the 2 last arguments as output type and ruleset, and all other arguments before that to be a list of paths to scan.
And anything not being a known option is considered an argument.

Ok, so it's more an usage issue with the wrong syntax for argument than a bug, so i'm closing the ticket
Thank for the help

From one side, supporting syntax --exclude=*/vendor/* would be possible and is quite a common usage and should not conflict with current usages (I doubt someone has filenames starting with --exclude= as = is generally avoided in file names) so we could implement support for it.
On the other side, making better error message for non existing option is tricky because this might be valid:
phpmd --aa --bb --cc --dd

If --aa and --bb are files/folders, --cc is a custom format and --dd a path to ruleset XML file. It's unlikely but it's technically possible.

In this case, you could still run the command like that :
phpmd ./--aa ./--bb --cc ./--dd

If you want to remove a file that start with a -, you'll have to use this syntax, otherwise rm say that the argument are not correct
Another thing that i've seen is to use the special -- argument to specify the end of the arguments (for example php does that : https://www.php.net/manual/en/features.commandline.options.php)
In this case, your command would look like  :
phpmd -- --aa --bb --cc --dd
phpmd --exclude=*/vendor/* -- --aa --bb --cc --dd

Note: It's only from my experience of command line to try to help, i don't know if/how it could break current usage and if it's adapted to this project.

Yep, that's a great idea.
I added the -- syntax and so the validation to disallow arguments starting with - unless -- separator is used which will also be explicitly suggested by the error message:
Unknown option --help.
If you intend to use "--help" as a value for ruleset argument, use the explicit argument separator:
phpmd --exclude=*/vendor/* -- foo/test.php text foo/phpmd.xml --help


DOC: Improve the itk-module.cmake file documentation.

Improve the itk-module.cmake file documentation.

README.rst does not yet exist (#2 ), so itk-module.cmake not finding it seems "acceptable" as a failure.


Failure to get feed list (Status 400 Invalid Request: "Error: Params must have the property "feeds"") across both website and Android app

Describe the bug
The list of feeds does not load at all, either the pinned ones or the broader list. This happens on my main account (which has a custom domain handle), but not on a new account created using a spare invite code.
Error message proper is as follows:
{     "error": "InvalidRequest",     "message": "Error: Params must have the property \"feeds\"" }
To Reproduce
Steps to reproduce the behaviour (at least with my main account and browser):

Open the website on Firefox or Android.
No tabs of feeds display.
Click or tap on the "My Feeds" label/button

Steps to reproduce on Edge after initially being able to see at least one custom feed with my main account:

Go to the My Feeds page
Add and pin a custom feed
Go back to home page
Now only the Following feed shows up, same behaviour as previous

Expected behaviour
Expected behaviour is to display my list of feeds in the top tabs and to show me my followed feeds on the My Feeds screen. GraySky does display them, as did Edge, initially (though only some of the pinned feeds), so the data is there. If
Screenshots
Initial Firefox (and Android) issue:

Recreation of issue in Edge:

Feeds still visible (and show when followed) when in Discover screen:

Also shows that I am following the feed on the feed page itself:

Details

Platform: Desktop Firefox, Desktop Edge, Android (Samsung Z Fold 4)
Platform version: Windows 10 with latest Edge and Firefox, Arch Linux with latest Firefox,
App version: 1.31.0

This started happening about a week ago, finally got around to creating a bug report for it, after submitting something in the feedback form.

 It seems one of the feeds I was following was at fault in some way. I've added some back, but haven't run into the problem yet, so I'm unsure which feed specifically was the culprit, or if it was a more complex interaction. Close this if needed, but IMO it's worth looking into how this occurred. If I can reproduce again, I'll update further with additional information.

This is really useful. thank you for all the steps you took to create such a detailed bug report.
We are aware of this issue and working on resolving it as soon as possible.

I think this got fixed, yeah?

Yes! It was fixed.


API rejects large request entities

Information

Qiskit Terra version: 0.8.0
Python version: 3.7
Operating system: Fedora (GNU/Linux)

What is the current behavior?
The API rejects to receive a code throwing the following error: 413 request entity too large. We were trying to send a circuit to the ibmq_qasm_simulator server.
Steps to reproduce the problem
Execute the code on https://gist.github.com/amartinfer/fd877e394bb3dafd5a133de8a5aa561b with an inputs that has to be at least a 4X4 matrix and two 4X1 vectors, on one of your servers.
(In case you cannot reproduce with this setup, try to send 16 calls in parallel, that was the heaviest case we tried)
What is the expected behavior?
That the API accepts the circuit code in order to be executed on one of the machines, as the code can be run in the simulator (we manage to run it on a laptop).
Suggested solutions
Revise the API limits so it allows large codes to be executed.

I also frequently run into this problem with pulse experiments.

We have right now a limitation of 8MB per request in the Cloud API... so if you try to send Job with more that 8MB it is not allowed yet... In the near future we will allow it.

Since @pacomf is tracking this issue in the API codebase, I'll close it as not related to Qiskit Terra.


Add 108 token to eth mainnet balancer whitelist

@zekraken-bot Just one more addition, we would also like to add the 108 mainnet token address to the balancer ethereum token whitelist as well.
The 108 project

@zekraken-bot contract verified below
https://etherscan.io/address/0x2D7fA140eC620Db445CdE5A25C44Ae6FbeE96CF9#code


Test message drop once re-broadcast is integrated

Once the re-broadcast is integrated, F3 should be resilient to message drop, where some messages are never delivered. Update the simulation to have a configuration parameter for percentage of message drop and assert that consensus is achieved eventually, i.e. the instance should still result in a decision but may take longer.

Done as part of https://github.com/filecoin-project/go-f3/pull/414


awesome tutorial

Great stuff!
Btw. I noticed that I can 'fake' a standalone application by create a .bat or .sh file (windows/linux) with:
path/to/pd.exe -open mypatch.pd -nogui
This will for instance, open a a GEM-window, but not the patch- and console-window.
My question is:

Did you find a similar way for displaying just the patch-window, but not the console-window?
That would easify shipping a one-window-patch-app to customers.

Thanks!
I don't know of a way to launch pd without the console window, unfortunately.
I took a quick look through all of the launch args for pd and didn't see an argument for it either.
https://github.com/pure-data/pure-data/blob/master/src/s_main.c
If you figure it out, let me know!

Thanks! Likewise!


app not run in android simulator

i have create my first react native app and run that in to android simulator
i have use this react-native run-android command for run app
then after display this " Jetifier found 914 file(s) to forward-jetify. Using 4 workers..."
then after nothing happens
i am not found any error in my terminal
this is my config :
react-native-cli: 2.0.1
react-native: 0.60.5
npm version : 6.11.2
node version : v10.16.3
React native info
System:
OS: Linux 4.4 Ubuntu 16.04.5 LTS (Xenial Xerus)
CPU: (4) x64 Intel(R) Core(TM) i3-4030U CPU @ 1.90GHz
Memory: 720.95 MB / 7.71 GB
Shell: 4.3.48 - /bin/bash
Binaries:
Node: 10.16.3 - /usr/bin/node
npm: 6.11.2 - /usr/bin/npm
IDEs:
Android Studio: 3.4 AI-183.54<IP_ADDRESS>00832
npmPackages:
react: 16.8.6 => 16.8.6
react-native: 0.60.5 => 0.60.5
npmGlobalPackages:
react-native-cli: 2.0.1

This is my react-native info
System:
OS: Linux 4.4 Ubuntu 16.04.5 LTS (Xenial Xerus)
CPU: (4) x64 Intel(R) Core(TM) i3-4030U CPU @ 1.90GHz
Memory: 720.95 MB / 7.71 GB
Shell: 4.3.48 - /bin/bash
Binaries:
Node: 10.16.3 - /usr/bin/node
npm: 6.11.2 - /usr/bin/npm
IDEs:
Android Studio: 3.4 AI-183.54<IP_ADDRESS>00832
npmPackages:
react: 16.8.6 => 16.8.6
react-native: 0.60.5 => 0.60.5
npmGlobalPackages:
react-native-cli: 2.0.1

@Bhagirath123 Have you tried to open up your android project in android-studio? After studio builds success, you may try the script again.

i am fraser in react native so i don't no how to run react native project in android studio
can you explain step for run in android studio


Oxa/oxa tools

What does this PR do? Please provide some context
Where should the reviewer start?
How can this be manually tested? (brief repro steps and corpnet-URL with change)
What are the relevant TFS items? (list id numbers)
Definition of done:

[ ] Title of the pull request is clear and informative
[ ] Add pull request hyperlink to relevant TFS items
[ ] For large or complex change: schedule an in-person review session
[ ] This change has appropriate test coverage
[ ] Get at least two approvals

Reminders DURING merge

If you're merging from a short-term (feature) branch into a long-term branch (like dev, release, or master) then "Squash and merge" to keep our history clean.
If merging from two longterm branches (like cherry picks from upstream, dev to release, etc) then "Create merge commit" to preserve individual commits.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: RepoCloudSwyft sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.

Are these changes still viable, @prabhanshu ?

No, these changes are specific to their configuration.
For e.g:
LMS_URL=mytest_lms.$BASE_URL
CMS_URL=mytest_cms.$BASE_URL
PREVIEW_URL=mytest_preview.$BASE_URL


Case sensitivity in dependency identifier

Case sensitivity with the identifier for the Scatterer mod was preventing AVP from installing. I changed it in my local registry, and AVP upgraded without issue. This should allow others to upgrade.

Looks good to me. Merging with thanks!


embeddings dependency

I discovered a dependency on the embeddings crate, which seems to be an empty placeholder: https://github.com/getgrit/gritql/blob/main/crates/core/Cargo.toml#L17
Is this something that is still supposed to be initialized, or something that should be cleaned up?

It's a placeholder for some internal experiments we’re running for retrieving from an embedding database. We have a few similar crates, but they're all optional dependencies.


Fancy Zones Editor Crashed while splitting zones

ℹ Computer information

PowerToys version: 0.33.1
PowerToy Utility: FancyZones Editor
Running PowerToys as Admin: True
Windows build number: 1909 (my computer fails to update))

📝 Provide detailed reproduction steps (if any)

Launch FancyZones Editor.
Edit column layout then click create custom layout.
Rename it to 2 Column Layout.
Edit zone layout and split to 4 squares.

✔ Expected result
Doubles the zone / Splits the zones
❌ Actual result
crashes
📷 Screenshots

I split the 3rd in half and then it crashed.
📃 Logfiles
Pastebin
Password: 1842 (bot protection)

1 day still nothing

@ChrisDev8
the root cause is the same as https://github.com/microsoft/PowerToys/issues/9540
https://github.com/microsoft/PowerToys/pull/10116 should fix it.


VaultConfiguration - Class Loading Issue

Getting what appears to be a class loading issue when using the latest spring cloud + boot + spring-cloud-starter-vault-config versions:

***************************\nAPPLICATION FAILED TO START\n***************************\n\nDescription:\n\nAn attempt
 was made to call a method that does not exist. The attempt was made from the following location:\n\n
 org.springframework.cloud.vault.config.VaultConfiguration.createSslConfiguration(VaultConfiguration.java:101)\n\nThe
 following method did not exist:

 'void org.springframework.vault.support.SslConfiguration.<init>(org.springframework.vault.support.SslConfiguration$KeyStoreConfiguration,org.springframework.vault.support.SslConfiguration$KeyStoreConfiguration, java.util.List, java.util.List)'

 The method's class, org.springframework.vault.support.SslConfiguration, is available from the following locations:

 jar:file:/app.jar!/BOOT-INF/lib/spring-vault-core-2.3.0.jar!/org/springframework/vault/support/SslConfiguration.class

 The class hierarchy was loaded from the following locations:

 org.springframework.vault.support.SslConfiguration:
 jar:file:/app.jar!/BOOT-INF/lib/spring-vault-core-2.3.0.jar!/\n\n\nAction:\n\nCorrect the classpath of your application
 so that it contains a single, compatible version of org.springframework.vault.support.SslConfiguration

Spring Cloud:  2020.0.2
Spring Boot:  2.4.4
Gradle config for vault (org.springframework.cloud:spring-cloud-vault-config:3.0.2 right now):
    runtimeOnly 'org.springframework.cloud:spring-cloud-starter-vault-config'
I cannot provide our application, unfortunately.  I am confused as to why this constructor is being called, since I am unable to find a version of org.springframework.vault.support.SslConfiguration that has this constructor.

Okay, looks like I need to manually bump up spring-vault-core from 2.3.0 to 2.3.2

Using Spring Vault 2.3.2 solves the issue. We added additional API to support cipher suites/protocols configuration. I'm not sure what component pulls in an older Spring Vault version. As per Spring Cloud Vault, we refer to the correct version:
https://github.com/spring-cloud/spring-cloud-vault/blob/v3.0.2/spring-cloud-vault-dependencies/pom.xml#L23

d'oh, looks like one of our internal shared libraries is somehow forcing the downgrade. sorry about that. closing

Thanks a lot for the update.

Hi,
I just ran into the same issue, and it turns out the spring-cloud-config-dependencies BOM (version 3.0.3) defines the version of the spring-vault-core as 2.3.0.
That BOM is imported in the spring-cloud-dependencies BOM (version 2020.0.2) before the spring-cloud-vault-dependencies BOM (version 3.0.2), and seems to take precedence.
Is this worth reporting in the spring cloud config repository, or at the spring cloud dependencies level ?


Allow negative integer for offsetX/offsetY options

In my test I need to drag an element (source) to the right side of another element (target). So, I use this code:
await t.dragToElement(source, target, { offsetX: -10 });
but this exception occurs: "The "offsetX" option is expected to be a positive integer, but it was -10.".
Provide the capability to set offsetX/offsetY options with negative number.

Offset options define a point inside source element. Now we don't have offset options to target element, so may be we should implement it.


FileView shows a link to download the file instead of downloading the file like in Classic UI

Describe the bug
Add a File in Classic UI, say /Plone/file1.pdf both logged-in and anonymous users get the file download (or rendered in the browser if it's a PDF)
In Volto we get the FileView with a link to download the file. To get this functionality in ClassicUI one needs to add /view in the URL, ex: /Plone/file1.pdf/view
Should this functionality be the same in both UIs?

Closing this because #6060 has more discussion of the nuances of this question.


Support waitable objects on Windows 10

There is an (undocumented) NtAssociateWaitCompletionPacket syscall that can be used for the purpose.

This would resolve issue https://github.com/stjepang/smol/issues/24


Automate available dependency updates reports

The important thing with this change is the addition of the rulefile to specify "allowed" updates.
Without this we would get something like this:
The following dependencies in Dependencies have newer versions:
  ch.qos.logback:logback-classic ................. 1.2.3 -> 1.3.0-alpha4
  org.slf4j:jcl-over-slf4j ...................... 1.7.26 -> 2.0.0-alpha0
  org.slf4j:log4j-over-slf4j .................... 1.7.26 -> 2.0.0-alpha0
  org.slf4j:slf4j-api ........................... 1.7.26 -> 2.0.0-alpha0
  org.testng:testng .............................. 6.14.3 -> 7.0.0-beta4

In Jenkins two things change:

Archiving a file with report of the available changes

The same reports are also printed to the build log duing the mvn commands

We might (later?) want to put the commands in Jenkinsfile into a method in https://github.com/capralifecycle/jenkins-pipeline-library and also output zero bytes files if there are no available updates (so it can be seen without opening the files)

I removed a rule that was specific for graphql-java that shouldn't be needed in the baseline.


bamtobed -ed and -tag fail to find tags

When using bamtobed -ed, bedtools (2.28.0) exits with The requested tag (NM) was not found in the BAM file. Similarly, bamtobed -tag AS exits with The requested tag (AS) was not found in the BAM file.
Both tags are present in the BAM file, which was produced by Bowtie2 (v<IP_ADDRESS>). Here is the start of the file:
@HD	VN:1.0	SO:unsorted
@SQ	SN:NC_002505.1	LN:2961149
@SQ	SN:NC_002506.1	LN:1072315
@RG	ID:MG1706_MR
@PG	ID:bowtie2	PN:bowtie2	VN:<IP_ADDRESS>	CL:"/usr/bin/bowtie2-align-s --wrapper basic-0 -p 8 --rg-id MG1706_MR --local -D 10 -R 2 -N 0 -L 22 -i S,1,1.75 -x ./ref --passthrough -1 ../00-reads/MG1706_MR_R1.fastq.gz -2 ../00-reads/MG1706_MR_R2.fastq.gz"
A00197:28:H5N3GDMXX:1:1101:21233:1063	83	NC_002505.1	2677402	0	3S113M7D2M2D32M	=	2677311	-282	AGTGTGGCCATCGTTACGCCATTCGTGCAGGTCGGAACTTACCCGACAAGGAATTTCGCTACCTTAGGACCGTTATAGTTACGGCCGCCGTTTACTGGGACTTCAATCAAGAGCTTGCACCCCATCATTTAATCTTCCAGCACCGGGCAG	FFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFF	AS:i:208	XS:i:208	XN:i:0	XM:i:7	XO:i:2	XG:i:9	NM:i:16	MD:Z:9A82C3G4G11^CGCTTGC2^TA9A4C5G11	YS:i:114	YT:Z:CP	RG:Z:MG1706_MR
A00197:28:H5N3GDMXX:1:1101:21233:1063	163	NC_002505.1	2677311	0	35S115M	=	2677402	282	TACACAGATCCGTTCAAAGTCCAATACAAAGCTACAGTAAAGGTTCATGGGGTCTTTCCGTCTTTCCGCGGGGAGATTGCATCATCACAAACATTTCAACTTCGCTGAGTCTGCGGAGGAGACAGTGTGGCCATCGTTACGCCATTCGTG	FFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFF-FFF8FFFFFFFFF-FFFFFFFFFFFFFF	AS:i:114	XS:i:114	XN:i:0	XM:i:17	XO:i:0	XG:i:0	NM:i:17	MD:Z:12C15A0G7T1C1C6T5G0C0G7T3A8C0G2T8C9A14	YS:i:208	YT:Z:CP	RG:Z:MG1706_MR

The AS and NM tags are detected e.g. by samtools sort -t AS mapping.bam, which correctly sorts the BAM file on the AS tag.

This is now fixed in master. Thanks for reporting!

@arq5x could we get a new point release with this fix?
Thanks.

will do in the next couple of weeks - waiting on a few other updates.


i18n(zh-cn): update content-collections.mdx

Description (required)
update content-collections.mdx
Related issues & labels (optional)

https://github.com/withastro/docs/pull/8967

Lunaria Status Overview
🌕 This pull request will trigger status changes.

Learn more
By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.
You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

Locale
File
Note

zh-cn
guides/content-collections.mdx
Localization changed, will be marked as complete.

Warnings reference

Icon
Description

🔄
The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.


Merge pull request #1 from madcowswe/master

Update 17/08/2020

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Merge master

Given that this PR is empty I assume it was unintentional so I'm closing it.


Npm run dev not registering changes

I've created new vue component and for some reason it's not registering. It's weird because I already got like 5-6 components working just fine and I can use them but whenever I try to register this new one it's useless.
Just checked , its not only new components, Its not registering change to any of them including app.js for some reason

Having the same issue.  I'm on Ubuntu 16.04 using Vagrant/Homestead for local environment.  Can you post your resources/assets/js/app.js and resources/assets/js/bootstrap.jsand the new component?

I'd need you to fill out the issue template to help.

@lukaisailovic Could your application be cached? Clearing the cache or opening app.js to manually refresh might solve the problem

happens here too

Just npm run prod
Then npm run dev
Lähetetty Huawei-matkapuhelimestani
-------- Alkuperäinen viesti --------
Aihe: Re: [JeffreyWay/laravel-mix] Npm run dev not registering changes (#806)
Lähettäjä: Mubashir Abbas
Vastaanottaja: JeffreyWay/laravel-mix
Kopio: Omar Benchbana ,Comment
I am having the same problem.. No change is being recongnized. It was working and suddenly it stopped. I removed everything from app.js and it still shows the same app. changing the file does trigger the watcher to rebuild but it keeps on building an older state of code.
Even if I deliberately make an error, it compiles successfully because it is not compiling my current code.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHubhttps://github.com/JeffreyWay/laravel-mix/issues/806#issuecomment-394152100, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AIMfhO_I-cUo8WPm8hivHg9F75xo56vGks5t47jmgaJpZM4NaHvM.


Filtering based on unique values of dynamic properties of the model

What would be the most efficient/appropriate way to achieve a model based on the contents of the model itself.
To give an example what I try to achieve: https://www.amazon.com/s?i=electronics-intl-ship&bbn=16225009011&rh=n%3A!16225009011%2Cn%3A1266092011%2Cn%3A172659&dc&fst=as%3Aoff&qid=1563278627&rnid=1266092011&ref=sr_nr_n_13
Eg: Having a list of "products" which have properties like: "brand", "type", "size" , ...
I would like to be able to filter them based on the contents of these properties.
This should be performed dynamically, as I am not aware of all possible values/categories available.
Also, values may change as filters are being applied dynamically.
Do you have a suggestion on how to achieve this?
I can iterate through the resulting Proxy Model, making a list per property containing all its unique values (and count, to sort).
With this list I could generate QML CheckBoxes, and create ValueFilter's on the fly?
Not sure though if this is the most memory efficient/performant though.
Thanks!

Answer from @oKcerG via email:
There are two problems to solve for your usage that are not supported by the SFPM lib
The first one is getting unique values for the different fields of your model. I've already thought about this one but I believe it is out of scope of my lib.
The solution would need to listen for changes in the model (rowInserted/Removed, dataChanged, ...) and either iterate through the model each time or maintain a local representation of the role it should track.
A possible api would look like:
UniqueModel {
id: uniqueBrandModel
sourceModel: productModel
roleName: "brand"
}
With UniqueModel being a QAbstractListModel (making it a QAbstractProxyModel doesn't make much sense from my perspective, there won't be any mapping) exposing a single role (value, it could also alias the passed roleName to it) with a row for each unique value.
You could alternatively make it a single object, exposing a list or model for each role of the sourceModel, but I feel that it is less flexible.
The other problem is adding ValueFilters dynamically to the SFPM.
That's a solution I plan to support (although I don't have much time now to work on the lib).
If you want to implement it, I don't mind a PR :)
The way I see it, there are 4 possibles API:
1.
Instantiator {
    model: roleNames
    ValueFiter {
        roleName: modelData
        container: filterContainer // new property; should work with proxyModel and any other filter containers like AnyOf or SwitchRole; maybe limit writing to this property to Filters created outside a SFPM to avoid edge cases?
    }
}

Instantiator {
    model: roleNames
    ValueFiter {
        roleName: modelData
        FilterContainer.container: filterContainer // new attaching type with attached property. similar behaviour to the above property. Can maybe ease the coding logic and has the advantage of not adding container logic in the Filter
    }
}

Instantiator {
    model: roleNames
    ValueFiter {
        roleName: modelData
    }
    onObjectAdded: filterContainer.appendFilter(object) // new to expose this method
    onObjectRemoved: filterContainer.removeFilter(object)
}

SortFilterProxyModel {
    // ...
    FilterRepeater { // too complex to implement, not flexible enough I believe
        model: roleNames
        ValueFiter {
            roleName: modelData
        }
    }
    // ...
}

From a theroical point of view, I prefer solution 2 with the attached property. It doesn't make the filter aware of its container.
It has some drawbacks compared to 1, attached property vs normal property syntax and it instantiates another QObject.
3 is maybe the simplest to do, if you want to do this internally (not contributing it), and don't care about supporting edge cases, I guess that's what I would recommend.
I'm not a fan of the imperative API though.
4 is too hard and not flexible enough.
In your use case you might want to have a Repeater of ComboBox, and instantiate a ValueFilter in each ComboBox, 1, 2, 3 can do that (3 with ugly Component.onCompleted/onDestruction). With 4 you can't. You'd have to have a Repeater of ComboBox and a FilterRepeater of ValueFilter, and somehow link them.
If your list of roles is not know in advance, you can use my QmlModelHelper lib to query it : https://github.com/oKcerG/QmlModelHelper (look at the tests to figure out what it does, or read this unfinished readme : https://gist.github.com/oKcerG/eeea734bdacc51b3ae58650de5f05943 )