feat(programme): update programme listing mv

Description
Music year: 1990
ACs

[x]  new mv is used in query: published_mv_synthetic_unitvariant_lessons_by_keystage_13_0_0
[x]  schema is updated
[x]  overrides and exceptions are implemented
[x]  navigation is uneffected by changes

Issue(s)
Fixes #
How to test

Go to {owa_deployment_url}/teachers/key-stages/ks4/subjects/maths/programmes
Click on other programme pages
You should see no chnges to

Screenshots
How it used to look (delete if n/a):
{screenshots}
How it should now look:
{screenshots}
Checklist

[ ] Added or updated tests where appropriate
[ ] Manually tested across browsers / devices
[ ] Considered impact on accessibility
[ ] Design sign-off
[ ] Approved by product owner
[ ] Does this PR update a package with a breaking change

:tada: This PR is included in version 1.643.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Debugging test failures due to row response not returned as expected

The failed tests are :

queryLogsBatch with types
queryLogs (last day)

Happening bcz the row values of the table are returned as below instead of "string"
[
  [
    { '0': 'h', '1': 'e', '2': 'l', '3': 'l', '4': 'o' },
    {},
    Invalid Date,
    {},
    {},
    {},
    {
      '0': '{',
      '1': '"',
      '2': 'h',
      '3': 'e',
      '4': 'l',
      '5': 'l',
      '6': 'o',
      '7': '"',
      '8': ':',
      '9': '"',
      '10': 'w',
      '11': 'o',
      '12': 'r',
      '13': 'l',
      '14': 'd',
      '15': '"',
      '16': '}'
    }
  ]
]

The service response seems reasonable -
{"tables":[{"name":"PrimaryResult","columns":[{"name":"stringcolumn","type":"string"},{"name":"boolcolumn","type":"bool"},{"name":"datecolumn","type":"datetime"},{"name":"intcolumn","type":"int"},{"name":"longcolumn","type":"long"},{"name":"realcolumn","type":"real"},{"name":"dynamiccolumn","type":"dynamic"}],"rows":[["hello",true,"2000-01-02T03:04:05Z",100,101,102.1,"{\"hello\":\"world\"}"]]}]}

Needs more investigation into why the code returns row in the above matter. Start from playing with - the function - convertGeneratedTable in modelConverters.ts

Added the fix in this PR - https://github.com/Azure/azure-sdk-for-js/pull/16606/files#diff-8aa12c8ea26880f18219cc56e10d023efb3833cacbcd3ef2c8d72ef6ca71067aR126


Add git support

Right now, diffing two git versions of the same file is really cumbersome (git show $rev1:./foo.brd > old.brd ; git show $rev2:./foo.brd > new.brd ; eagle-diff old.brd new.brd).

Should be just a matter of telling git how to use diff right? like done here: https://github.com/jotux/eagle-diff/blob/master/readme.md#add-this-to-your-gitconfig

Nice, I didn't know about that.
I guess it'd have to create a temporary directory somewhere, put the images there, display the images somehow (I don't think there's a good portable way to display multiple images), and remove the directory when whatever image viewer was used exits.

so, what I've got working is...
in ~/.gitconfig
[difftool "eagle"]
	cmd = eagle-diff -f -d 100 --eagle /home/karlp/tools/eagle-tastic/bin/eagle $LOCAL $REMOTE

then
git difftool -t eagle rev1 rev2 filename.{brd,sch}

That works.  It's not as nice as straight git diff.  Using the .gitattributes from the other repo works, but we'd need to make a wrapper script that takes a fixed set of 7 parameters.  I couldn't work out a neat way around that.


Fix invalid HTML

I think this was invalid HTML and Firefox marked it as invalid as well. I think according to the HTML5 spec, only tags that cannot have any contents (known as void elements) can be self-closing.

Oh yes, indeed! Great catch, thank you so much 🙏


Redirect the Hybrid Compute requests through a proxy service.

:clipboard: Add associated issues, tickets, docs URL here.
Overview
This routes hybrid compute requests through a new proxy service, allowing those requests to be firewalled away from any internal network destinations. This implementation uses an unmodified SOCKS5 docker image which I found, but we may want to use a different protocol or develop a custom proxy with additional features (such as adding logging and analytics for the requests).
Changes
Changes to be committed:
modified:   core/vm/evm.go
modified:   rpc/client.go
modified:   ../ops/docker-compose.yml
Testing
The existing Turing tests should still run and should be able to access the same AWS endpoints when this change is applied to a local system. Other test environments will likely need additional changes to support the new Docker service.

Codecov Report
Base: 47.12% // Head: 77.71% // Increases project coverage by +30.59% :tada:

Coverage data is based on head (bc7f67b) compared to base (454eaa4).
Patch has no changes to coverable lines.

Additional details and impacted files
@@             Coverage Diff              @@
##           develop     #328       +/-   ##
============================================
+ Coverage    47.12%   77.71%   +30.59%
============================================
  Files           99       39       -60
  Lines         3875     1324     -2551
  Branches       765      202      -563
============================================
- Hits          1826     1029      -797
+ Misses        2049      295     -1754

Flag
Coverage Δ

boba-contracts
?

contracts
77.71% <ø> (ø)

core-utils
?

data-transport-layer
?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

...boba/contracts/contracts/DiscretionaryExitBurn.sol

...racts/contracts/oracle/SimplePriceFeedRegistry.sol

packages/boba/contracts/contracts/ERC2470.sol

packages/core-utils/src/optimism/index.ts

...cts/contracts/libraries/CrossDomainEnabledFast.sol

.../boba/contracts/contracts/DiscretionaryExitFee.sol

...ontracts/contracts/oracle/payment/Subscription.sol

...s/boba/contracts/contracts/bridges/L2NFTBridge.sol

.../src/services/l2-ingestion/handlers/transaction.ts

.../contracts/libraries/Lib_ResolvedDelegateProxy.sol

... and 50 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

Can we put env in l2geth/cmd/utils/flags.go and import that in evm.go?

Yes, it should be possible to add the proxy string to l2geth/cmd/utils/flags.go.

After Bedrock.


exits without any error

The plan goes without an issue , but when trying to apply it just dies without any exception
{code}
Error: Error applying plan:
1 error(s) occurred:

module.cluster_bootstrap.sumologic_collector.collector: 1 error(s) occurred:

sumologic_collector.collector:

Terraform does not automatically rollback in the face of errors.
Instead, your Terraform state file has been partially updated with
any resources that successfully completed. Please address the error
above and apply again to incrementally change your infrastructure.
{code}
config is pretty standard as per the readme
Thanks
NIro

Sumologic recently released their own, officially supported provider. As such, I am not actively maintaining this one. Their efforts can be found on their github pages: https://github.com/SumoLogic/sumologic-terraform-provider


[Potential Conflict] Biome Makeover

Here's another potential conflict similar to the one I raised back in #45
[00:25:30] [main/WARN]: Method overwrite conflict for setSlimeSize in biomemakeover.mixins.json:SlimeEntityMixin, previously written by ru.betterend.mixin.common.SlimeEntityMixin. Skipping method.

Method overwrite conflict for method_8132 in betternether.mixins.common.json:RecipeManagerMixin, previously written by ru.betterend.mixin.common.RecipeManagerMixin. Skipping method.
This looks like more of the same.

Method overwrite conflict for method_8132 in betternether.mixins.common.json:RecipeManagerMixin, previously written by ru.betterend.mixin.common.RecipeManagerMixin. Skipping method.
This looks like more of the same.

This methods both set slime size and are probably are similar. I will add suffix to method, this will prevent possible conflict

This methods both set slime size and are probably are similar. I will add suffix to method, this will prevent possible conflict

Fixed in 0.8.6

Fixed in 0.8.6


Update Rekor to v1.0.0

Updates #959
Related https://github.com/sigstore/rekor/issues/1115
Signed-off-by: Ian Lewis<EMAIL_ADDRESS>

QQ: Can you update this line https://github.com/slsa-framework/slsa-github-generator/blob/dfea9e3a4de9e3aa7babf15f3553a73994a797b8/signing/sigstore/rekor.go#L63
to pull client.GetRekorClient instead? Otherwise cosign hasn't necessarily updated with the retryable client. And we might as well get rid of the cosign dep and use it directly.
https://github.com/sigstore/rekor/blob/7807d1e5a3fbc9b8fdd17053da8163463e87a5ae/pkg/client/rekor_client.go#L28

Oops, didn't realize auto-merge was enabled. Will submit a follow up PR.


Fix - Parameterize config to accept connection names.

Closes: https://github.com/stackkit/laravel-google-cloud-tasks-queue/issues/22
@marickvantuil - The one thing I could use your input on is how to update the calls to Config in TaskHandler. I've made a first attempt at it and tested it locally with a payload and it checks out!

Thanks for this fix! I've fixed one test that was failing.
Locally something was still breaking for me. When I push to the default queue that has a different connection name than cloudtasks, and then later get the connection name from the payload, it seemed to be null (think thats default Laravel behavior?):

Fixed that by using the default connection name in that case, instead of cloudtasks.
Also did a pass to clean up the config, what do you think?

It might depend on the connection being explicitly specified on the job itself, which is a property that laravel defines that jobs can set/override.


Please add one more example in Fallback routes section

About "Fallback routes", we may be confused if we read concrete examples.
Though final example says any other file outside the /images or /css folders will return as "The /index.html file", request won't return index.html file in case we access deployed files.
It is true that above section says, "The following example returns /index.html for all static file requests that don't match a deployed file.", but I consider some readers may confuse by reading following concrete examples.

Thus, I suggest using below example to understand more clearly.
├── images
│   ├── logo.png
│   ├── headshot.jpg
│   └── screenshot.gif
│
├── css
│   └── global.css
│
├── readme.txt
└── index.html

Requests to...
returns...
with the status...

/about/
The /index.html file
200

/images/logo.png
The image file
200

/images/icon.svg
The /index.html file - since the svg file extension isn't listed in the /images/*.{png,jpg,gif} filter
200

/images/unknown.png
File not found error
404

/css/unknown.css
File not found error
404

/css/global.css
The stylesheet file
200

/readme.txt
The /readme.txt file
200

Any other file outside the /images or /css folders which don't match a deployed file
The /index.html file
200

Regards,
Kohei

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: ac225b59-6d75-1c98-3bd5-9483a818c8d4
Version Independent ID: 40e9a5f6-4461-b926-427b-ee889b2c3754
Content: Configure Azure Static Web Apps
Content Source: articles/static-web-apps/configuration.md
Service: static-web-apps
GitHub Login: @craigshoemaker
Microsoft Alias: cshoe

@kohei-miyoshi
Thanks for your feedback! We will investigate and update as appropriate.

Thanks, @kohei-miyoshi!
The doc is now updated with your suggestion.
#please-close


Fix CheatsMenu.netkan

Added missing dependency ShadowUtilityLIB

Requires #20

You should mention this on SpaceDock so users know they need to install it.
https://spacedock.info/mod/3266/Cheats Menu

You should also mention it on the forum thread.
https://forum.kerbalspaceprogram.com/index.php?/topic/214242-cheat-menu/

You should also mention it in the README on GitHub and/or in the download.
https://github.com/Bit-Studios/CheatMenu

Hi @NathanPeake, thanks for letting us know about this. For what it's worth, we set the dependencies of CKAN by looking in the same places users would...
You should mention this on SpaceDock so users know they need to install it.
https://spacedock.info/mod/3266/Cheats Menu

Thanks @HebaruSan for reminding me to update them areas.


Document - API Specifications

Description of Changes:

Add Documentation for API

Type of Changes:

[x] Documentation (Add Documentation to Existing Code)
[ ] Bug Fix (Non-Breaking Changes Which Fixes an Issue)
[ ] New Feature (Non-Breaking Changes Which Adds Functionality)
[x] Improvement (Non-Breaking Changes Which Improves the Structures, Performance, etc...)
[ ] Breaking Change (Breaking Changes that Would Cause Existing Functionality to NOT Work as Expected)

To-Do or Other Concerns:

(NONE)

Closing Issues:

ISSUE #XXXX

Great job! Detailed update.


Pydantic v2 support

Is your feature request related to a problem? Please describe.
The problem is that you're using red-bird for logging which is large code base, and also rocketry is dependent on v1.
Describe the solution you'd like

Either create new version of rocketry that matches both pydantic versions, like fastapi did (some dirty trick, but works)
Refactor red bird and rocketry to pin pydantic to v2

Describe alternatives you've considered
None
Additional context
None

Alternative, and quickest fix:

pin Pydantic dependency to 1.10.10

Same problem here, this issue is blocking me heavily since June 30th.
If it's relevant and could help, I can submit a PR to add the pydantic v2 support to red-bird
@Miksus

Same problem here, this issue is blocking me heavily since June 30th. If it's relevant and could help, I can submit a PR to add the pydantic v2 support to red-bird @Miksus

I didn't notice that red-bird is also maintained by maintainer of this repo,
that's a good news then.
I'll open a PR there, working on Pydantic V2, so hopefully it'll be merged, if not then it should be enough for my own use case at least, to fork rocketry and go with a forked version that supports v2 which uses my own red-bird that supports v2.

I think it's up to @Miksus to decide if red-bird is "alive" or not
Simply pin your pydantic version with pydantic==1.10.10. Fixed.

I have the same problem, the fix is ok, but for my project I loose all the benefit of pedantic 2.x

I've started a PR to begin the work integrating pydantic V2 https://github.com/Miksus/rocketry/pull/212
Happy for anybody to contribute with it, I think its going to require a lot of work.
Running locally with a basic 'hello_world' task at the moment, with pydantic 2.0.3 and I've installed @ManiMozaffar red-bird branch where .v1 has been appended to the pydantic imports for now. With Rocketry's dependence on that module, I think that is going to need migrating as well for this to work properly.

I've started a PR to begin the work integrating pydantic V2 #212 Happy for anybody to contribute with it, I think its going to require a lot of work.
Running locally with a basic 'hello_world' task at the moment, with pydantic 2.0.3 and I've installed @ManiMozaffar red-bird branch where .v1 has been appended to the pydantic imports for now. With Rocketry's dependence on that module, I think that is going to need migrating as well for this to work properly.

Heads up: use pydantic migration module, so it’ll replace v1 codes with v2. Then 70 tests will fail and you need to start debugging them. Lots works as you mentioned, that’s why i decided to use it with .v1 because internally it doesn’t use pydantic alot, just as passing by arguments to tasks and etc so I didn’t see a great performance boost.

I've started a PR to begin the work integrating pydantic V2 #212 Happy for anybody to contribute with it, I think its going to require a lot of work.
Running locally with a basic 'hello_world' task at the moment, with pydantic 2.0.3 and I've installed @ManiMozaffar red-bird branch where .v1 has been appended to the pydantic imports for now. With Rocketry's dependence on that module, I think that is going to need migrating as well for this to work properly.

Heads up: use pydantic migration module, so it’ll replace v1 codes with v2. Then 70 tests will fail and you need to start debugging them. Lots works as you mentioned, that’s why i decided to use it with .v1 because internally it doesn’t use pydantic alot, just as passing by arguments to tasks and etc so I didn’t see a great performance boost.

Thanks for the heads up.
Bump script was ran today but it didn't seem to do a whole much. Still working on it, tests are running now atleast.

Sorry for taking eternity to answer: I should upgrade my machine as developing Rocketry on it is painfully slow with it and have had too busy free time. I'll try to visit this in the week end (and hopefully purchase a new machine).

Thanks @Miksus
I've been working on this the past couple of nights and seem to have it working (for the most part) on v2 apart from one weird bug (probably not a bug, bug).
The way pydantic has changed has caused some odd class inheritance issues, One of the first things I've had to do is comment out creating the null session in the RedBase class in _base.py (Not an ideal solution)
If we don't then we get a clash issue:
Exception has occurred: NameError
Field name "session" shadows an attribute in parent "RedBase"; you might want to use a different field name with "alias='session'".

This issue was also appearing with other classes further down but I managed to get around it by typing those variables to ClassVar based on a issue I found on the pydantic repo https://github.com/pydantic/pydantic/discussions/2410#discussioncomment-408613
This has been fine for getting the application running but when it comes to the test, because it uses DummyTask which inherits Task/FuncTask and then session is passed into it. This seemed to raise the exact same error as above.
I've tried to get around this by setting ClassVar in  the dummy class:
class DummyTask(BaseTask):

    session: ClassVar
    def execute(self, *args, **kwargs):
        return

This then causes another error, where when it then tries to run the validation (on name inside the parse_name function) it doesn't seem to pass this attribute up the inheritance into the validation function. So you just end up getting a key error on the test.
FAILED rocketry/test/condition/test_meta.py::test_taskcond_true[main] - KeyError: 'session'

    @field_validator('name', mode="before")
    def parse_name(cls, value, values):
>       session = values.data['session']
E       KeyError: 'session'

# example test that fails

class DummyTask(BaseTask):

    session: ClassVar
    def execute(self, *args, **kwargs):
        return

def test_defaults(session):
    task = DummyTask(name="mytest", session=session)
    assert task.name == "mytest"
    assert isinstance(task.start_cond, AlwaysFalse)
    assert isinstance(task.end_cond, AlwaysFalse)

All in all, I'm not sure what's changed in pydantic to cause that inheritance issue, but if anyone doesn't find a solution it's probably the last main issue with the PR and I can also reimplement the base class into the class structure. It would just need the rest of the warnings working through (But I think on the tests its inheriting a lot of those from RedBird).

Any progress on this?

Thank you for the update.
It's not the end of the world atm (for me at least).  The only think it's holding up for me is an upgrade of a site from Flask to FastAPI (with pydantic 2.0 / beanie).  Site still runs great, and I can wait.
Cheers!

In the meantime I'm leaning towards Celery.

pydantic 2 will cause following bug:
Traceback (most recent call last):
  File "/", line 5, in <module>
    from rocketry import Rocketry
  File "/root/miniconda3/lib/python3.10/site-packages/rocketry/__init__.py", line 1, in <module>
    from .session import Session
  File "/root/miniconda3/lib/python3.10/site-packages/rocketry/session.py", line 18, in <module>
    from rocketry.log.defaults import create_default_handler
  File "/root/miniconda3/lib/python3.10/site-packages/rocketry/log/defaults.py", line 1, in <module>
    from redbird.logging import RepoHandler
  File "/root/miniconda3/lib/python3.10/site-packages/redbird/__init__.py", line 2, in <module>
    from .base import BaseRepo, BaseResult
  File "/root/miniconda3/lib/python3.10/site-packages/redbird/base.py", line 116, in <module>
    class BaseRepo(ABC, BaseModel):
  File "/root/miniconda3/lib/python3.10/site-packages/redbird/base.py", line 153, in BaseRepo
    ordered: bool = Field(default=False, const=True)
  File "/root/miniconda3/lib/python3.10/site-packages/pydantic/fields.py", line 763, in Field
    raise PydanticUserError('`const` is removed, use `Literal` instead', code='removed-kwargs')
pydantic.errors.PydanticUserError: `const` is removed, use `Literal` instead

thanks so much @Jypear i've cloned rocketry #212 and redbird #49 and integrated it at git+https://github.com/tekumara/rocketry@pydantic-v2 and it works well! hoping your PRs can be merged soon 🙏

The only thing to be aware of in that fork is pickling isn't quite working yet. Pydanticv2 seems to have completely borked it.
Please feel free to have a go at a solution though! I can try and get to it when I have time.

Any progress..?

@Yangeok It's waiting on maintainer still.

+1 here. I just looked at this library and wanted to use it in my FastAPI application (depends on Pydantic v2.0). What a bummer. It looked quite nice...

this project seems inactive now

Update to everyone: Rocketry seems to not be maintained anymore.
So I ended up writing one from scratch.
If you're looking for an alternative with supporting pydantic v2, try out AioClock.
https://github.com/ManiMozaffar/aioclock


WIP: Deploy v0.1.0

Add conda environment

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@f3cd6ea). Click here to learn what that means.
The diff coverage is 45.45%.

@@            Coverage Diff            @@
##             master       #7   +/-   ##
=========================================
  Coverage          ?   45.45%
=========================================
  Files             ?        3
  Lines             ?       44
  Branches          ?        0
=========================================
  Hits              ?       20
  Misses            ?       24
  Partials          ?        0

Impacted Files
Coverage Δ

jugc/run.py
0% <0%> (ø)

jugc/subprocess.py
0% <0%> (ø)

jugc/__init__.py
100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f3cd6ea...22dd81c. Read the comment docs.


[FR] More strict business processes needed

Please verify that this feature request has NOT been suggested before.

[X] I checked and didn't find a similar feature request

Problem statement
In short, the problem is - the staff is not always so responsible or\and well-intentioned, how is want to be.
Some steps can easily be sabotaged, ignored by mistake or evil will, it really doesnt matter.
The software must be able to handle these situations and\or provide minimum tools for detection and restoration.
Some steps can easy be sabotaged or ignored.
Examples:

Worker has assembled part in fact, but been too lazy or just forgot to allocate all stock, due substitute issues or conflicts as example. He can easily set "Allow incomplete" and you have no real way to track it.
Incomplete build order or stock from it, have no really any signs of its incompleteness.
Proposal: Restrict dangerous actions with special permission per account.

There is no consistent way to track the reason for stock status changes. Like, you can make it from a stock list with reason or from "edit item" with no ability to set reason.
Proposal: Add ability to restrict status change without comment with special setting or permission per account.

There is no strict way to handle NOTES. Notes is a very nice and flexible way to handle any additional information, except... it can easily be erased in one click and you have no chance to check if there was some.
Proposal: Save full notes changes history or atleast track change events .

Sales\Build orders\Purchaes completeon.
Some actions cant be easily reverted after the completion. The BO as example never reverts his allocation status.
But there is many obivious reasons why some not prepared personel may interact with it and make mistakes sometime.
Proposal: Divide rights needed for BO\SO\PO(ant etc) edition and completion. Allow accountsto edit but not complete orders.

Do you want to develop this?

[ ] I want to develop this.

Not sure a feature request (FR) is the right format for this, I can see at least 7 or 8 different FR's in the text right now, some of them are already filed.

@alxrMironov each of these request is a significant task to implement and should be best tracked as separate issues. As @matmair calls out, please:

Check if each issue is already filed and you can add comments to that issue if so
If not already existing, create a new specific issue for each one.

It is too hard to track multiple large issues in a single discussion!

@alxrMironov each of these request is a significant task to implement and should be best tracked as separate issues. As @matmair calls out, please:

Check if each issue is already filed and you can add comments to that issue if so
If not already existing, create a new specific issue for each one.

It is too hard to track multiple large issues in a single discussion!

It is not FR as it is (you just have not "discussion" type of issue).
Im want to know developers opinion and explain my.

It is not FR as it is (you just have no "discussion" type of issue).

There are discussions, but they are separate from issues. You can find them on the repository page where code, issues, pull requests, ... are under the name discussions


Cache authorizer to avoid IO end

Google::Auth::ServiceAccountCredentials.make_creds each call will read json_key_io. Since it cached, second time it read empty string and can't parse JSON.
This caching avoid read each time

Thanks @rkyrychuk merging now


Latest version of k8s.ts produced by the import command breaks usage of Lazy in resources

To reproduce:

yarn upgrade cdk8s-cli json2jsii
rm -rf src/imports
yarn run import
yarn test

You should see many errors saying that:
secrets can be added to the service account

    TypeError: _b.map is not a function

      11038 |     'imagePullSecrets': obj.imagePullSecrets?.map(y => toJson_LocalObjectReference(y)),
      11039 |     'metadata': toJson_ObjectMeta(obj.metadata),
    > 11040 |     'secrets': obj.secrets?.map(y => toJson_ObjectReference(y)),
            |                             ^
      11041 |   };

The problem here is that the toJson methods added by https://github.com/cdk8s-team/cdk8s-cli/pull/43 doesn't seem to handle tokens correctly.

Derived from https://github.com/cdklabs/json2jsii/pull/480

We should probably call resolve (from cdk8s/lib/_resolve) on every property before or call resolve on the entire object before invoking the toJson methods.

I spent a couple hours looking into potential fixes. I don't think we can just simply call resolve on properties before invoking toJson_xxx() methods because this would resolve the dynamic references immediately, instead of at synthesis time, defeating the point of tokens.

I also couldn't think of any ways to change how objects are resolved and synthesized in cdk8s-core to fix this.
The only fixes I could think of center around supporting Lazy values in the toJson_xxx() or manifest() methods. For example, if we could change how manifest() is generated to support Lazy's, that would be great since it means we don't have to make changes to json2jsii. Here is an example of something I came up with, though unfortunately it does not work:

// old
  public static manifest(props: KubeServiceAccountProps = {}): any {
    return {
      ...KubeServiceAccount.GVK,
      ...toJson_KubeServiceAccountProps(props),
    };
}

// new
  public static manifest(props: KubeServiceAccountProps = {}): any {
    return Lazy.any({
      produce: () => {
        props = resolve(props) as KubeServiceAccountProps;
        const result = {
          ...KubeServiceAccount.GVK,
          ...toJson_KubeServiceAccountProps(props),
        };
        return Object.entries(result).reduce((r, i) => (i[1] === undefined) ? r : ({ ...r, [i[0]]: i[1] }), {});
      },
    });
  }

In principle it might do what we want: it returns an object that, when resolved, will have the correct property names and values. resolve has to be called within the Lazy so that toJson_xxx() can call methods like .map and so on. The problem is this implementation causes us to pass an entire Lazy value to ApiObject's props argument, which isn't valid (and I don't see a way to support this).
We could try the a similar approach with toJson_xxx where we wrap its entire method body in a Lazy, but then the ...toJson_xxx() spread operation in manifest() will not be valid (see the code above). (What does it mean to spread a Lazy value?)
An alternative that I think will work is to process the fields individually like this:

// old
export function toJson_KubeServiceAccountProps(obj: KubeServiceAccountProps | undefined): Record<string, any> | undefined {
  if (obj === undefined) { return undefined; }
  const result = {
    'automountServiceAccountToken': obj.automountServiceAccountToken,
    'imagePullSecrets': obj.imagePullSecrets?.map(y => toJson_LocalObjectReference(y)),
    'metadata': toJson_ObjectMeta(obj.metadata),
    'secrets': obj.secrets?.map(y => toJson_ObjectReference(y)),
  };
  // filter undefined values
  return Object.entries(result).reduce((r, i) => (i[1] === undefined) ? r : ({ ...r, [i[0]]: i[1] }), {});
}

// new
export function toJson_KubeServiceAccountProps(obj: KubeServiceAccountProps | undefined): Record<string, any> | undefined {
  if (obj === undefined) { return undefined; }
  const result = {
    'automountServiceAccountToken': Lazy.any({ produce: () => resolve(obj.automountServiceAccountToken) }),
    'imagePullSecrets': Lazy.any({ produce: () => resolve(obj.imagePullSecrets)?.map((y: any) => toJson_LocalObjectReference(y)) }),
    'metadata': Lazy.any({ produce: () => toJson_ObjectMeta(resolve(obj.metadata)) }),
    'secrets': Lazy.any({ produce: () => resolve(obj.secrets)?.map((y: any) => toJson_ObjectReference(y)) }),
  };
  // filter undefined values
  return Object.entries(result).reduce((r, i) => (i[1] === undefined) ? r : ({ ...r, [i[0]]: i[1] }), {});
}

If we wanted, we could even write the method in a more verbose way where the each values is only wrapped in an additional Lazy if the passed value was an instance of Lazy or not. (I think this should even work for edge cases where only nested values are Lazy, but I have to double check this).
So I believe this approach will fix the bug, but it still requires a full POC (I've only tried it on a few examples by hand). There are also some edge cases I noticed, like right now metadata does not support Lazy values (this unit test fails):
new ApiObject(chart, 'Pod', {
  apiVersion: 'v1',
  kind: 'Pod',
  metadata: Lazy.any({ produce: () => ({ name: 'my-pod' }) }),
});

If we went with this approach, I think we would want this behavior to be behind a flag in json2jsii so that others can disable the Lazy-injections if they want to.
@iliapolo WDYT? Are there any other approaches that come to mind? Open to ideas. 🙂

Update:
Eli and I brainstormed one more idea together offline. We liked the first solution, but the issue was there's no easy way to pass an entire lazy object into the ApiObject's props. So what if we just "made it so", by adding a field to ApiObject as an escape hatch to provide lazy values, and using it like this:
public static manifest(props: KubeServiceProps): any {
  return {
    ...KubeService.GVK,
    lazySpec: Lazy.any({ produce: () => toJson_KubeServiceProps(resolve(props)) }),
  };
}

This would avoid the need to modify json2jsii with all of the extra options needed to support Lazy fields.
I started building this solution and made decent progress, but there's at least one more (small) gotcha with it. The strategy of converting toJson_xxx(props) to Lazy.any({ produce: () => toJson_xxx(resolve(props)) }) fails on union-like values. Why? Because as an example, the inner resolve will convert an IntOrString into a primitive value, so when toJson_xxx is called, lines like obj.targetPort?.value will produced undefined.
I think the "proper" solution is just to define a resolveLazy function that only resolves Lazy's values so that the full IntOrString instances are still preserved when toJson_xxx is called.
@eladb Any thoughts on the issue or solutions in general?

Downgraded priority to p1 since this isn't technically blocking us. We can currently choose to stay with the older version json2jsii. One thing to note is that does have the potential to break customers using Lazy in the resources regardless of cdk8s-plus.

Discussed with @iliapolo and here's a proposal.
The generated code should look like this:
export class FooCronTab extends ApiObject {
  public static readonly GVK: GroupVersionKind = {
    apiVersion: 'stable.example.com/v1',
    kind: 'CronTab',
  }

  public static manifest(props: FooCronTabProps = {}): any {
    return {
      ...FooCronTab.GVK,
      ...toJson_FooCronTabProps(props),
    };
  }

  public constructor(scope: Construct, id: string, props: FooCronTabProps = {}) {

    // do not call `manifest()` here
    super(scope, id, {
      ...FooCronTab.GVK,
      ...props,
    });
  }

  // add this
  public toJson() {
    const resolved = super.toJson();

    return {
      ...FooCronTab.GVK,
      ...toJson_FooCronTabProps(resolved);
    };
  }
}

Thanks for the proposal. This is the best solution so far, and definitely requires the fewest changes to existing APIs.
I've noticed just one issue preventing this from working out-of-the-box, which is that toJson() on any union-like fields (namely IntOrString) fails. To see why, consider when super.toJson() is called, any IntOrString value will be resolved to a string or number. Meanwhile the toJson_xxx code generated by json2jsii looks like this:
const result = {
  'name': obj.name,
  'nodePort': obj.nodePort,
  'port': obj.port,
  'protocol': obj.protocol,
  'targetPort': obj.targetPort?.value, // !!!
};

Strings and numbers don't have ".value" fields.
(I think this issue also comes up with some of the solutions I proposed.)
My planned workaround is to modify json2jsii and add toJson() fields to the union-like structs as well. This way the toJson_xxx method works both when the raw primitive is passed in and when the union struct are passed in.

@Chriscbr What if we just get rid of the resolve method on union types in json2jsii?
i.e get rid of https://github.com/cdklabs/json2jsii/blob/f891f67ee833bbde81d8f8e29bb43079c69b6773/src/type-generator.ts#L373
It seems like the toJson_xxx methods are effectively serving the same purpose since they return .value. If the resolve method won't exist, then super.toJson() will leave union types as is, allowing for toJson_xxx to resolve them.

I think that's the right direction. The resolve method is a leak from another dimension.

This has been resolved by https://github.com/cdk8s-team/cdk8s-cli/pull/55.
The updated imports will be added in #59.


Project Versioning

Intentionally leaving out the published-version part of this, so that I can get this merged and used for the translation work.
Review checklist

[ ] First, the most important one: is this PR small enough that you can actually review it? Feel free to just reject a branch if the changes are hard to review due to the length of the diff.
[ ] If there are any migrations, will they the previous version of the app work correctly after they've been run (e.g. the don't remove columns still known about by ActiveRecord).
[ ] If anything changed with regards to the public API, are those changes also documented in the apiary.apib file?
[ ] Are all the changes covered by tests? Think about any possible edge cases that might be left untested.

Any suggestions? Happy to run it out of office hours

Any suggestions? Happy to run it out of office hours

Probably just early morning UK time (6-10 GMT) will be ok as that is normally a low activity period.

:+1:


No audio in RTSP stream with WebRTC

I have an RTSP stream working, but there is no audio in Lovelace, nor DashCast. This RTSP stream has audio when opening elsewhere like VLC etc. How can I get the audio with the stream?
Thanks

Read docs carefully
https://github.com/AlexxIT/WebRTC


⚠ Bofrost.at has degraded performance

In 001e9fa, Bofrost.at (https://www.bofrost.at) experienced degraded performance:

HTTP code: 200
Response time: 2181 ms

Resolved: Bofrost.at performance has improved in 32e770a.


Update README.md

Updated ´Tests.fsproj´ + ´Test.fs´ examples (now compiling)
Added small hints emphasising things I stumbled upon

Thank you very much for your great work.

Thank you!


Using more unique ActivityEventListener requestCode to prevent collis…

Using a large random int for requestCode to prevent collisions with other modules
References #9 & #10

Looks good. Thanks!


Error to build docker.

Hi, Thank you for your opensource.
I have a problem with docker build.
Please watch my log.
E:\HDOC>git clone https://github.com/dangvansam/viet-tts.git
Cloning into 'viet-tts'...
remote: Enumerating objects: 91, done.
remote: Counting objects: 100% (91/91), done.
remote: Compressing objects: 100% (79/79), done.
remote: Total 91 (delta 11), reused 86 (delta 9), pack-reused 0 (from 0)
Receiving objects: 100% (91/91), 18.18 MiB | 2.78 MiB/s, done.
Resolving deltas: 100% (11/11), done.

E:\HDOC>cd viet-tts

E:\HDOC\viet-tts>docker compose build
[+] Building 7.5s (12/15)                                                                          docker:desktop-linux
 => [api internal] load build definition from Dockerfile                                                           0.1s
 => => transferring dockerfile: 845B                                                                               0.0s
 => [api internal] load metadata for docker.io/pytorch/pytorch:2.0.1-cuda11.7-cudnn8-runtime                       5.9s
 => [api internal] load .dockerignore                                                                              0.0s
 => => transferring context: 2B                                                                                0.0s
 => CANCELED [api  1/11] FROM docker.io/pytorch/pytorch:2.0.1-cuda11.7-cudnn8-runtime@sha256:82e0d379a5dedd6303c8  0.9s
 => => resolve docker.io/pytorch/pytorch:2.0.1-cuda11.7-cudnn8-runtime@sha256:82e0d379a5dedd6303c89eda57bcc434c40  0.0s
 => => sha256:82e0d379a5dedd6303c89eda57bcc434c40be11f249ddfadfd5673b84351e806 1.37kB / 1.37kB                     0.0s
 => => sha256:26551f1051e710ecfc62bf6396fc67722f2ae0489be5e8cc6b7fc8de0926866e 4.85kB / 4.85kB                     0.0s
 => => sha256:99803d4b97f3db529ae9ca4174b0951afac6b309e7deaa8ec3214c584e02b3a8 2.10MB / 28.58MB                    1.4s
 => => sha256:4ade0a4bc5d597c845bc3c27c47453522019ee188adbc4110029bbea11e5adec 0B / 9.99MB                         1.4s
 => => sha256:035a286326d65b413051a4c52e7df0037d89f1075f7be98c9586d1c856ace994 0B / 3.11GB                         1.4s
 => [api internal] load build context                                                                              0.8s
 => => transferring context: 25.04MB                                                                               0.8s
 => CACHED [api  2/11] WORKDIR /app                                                                                0.0s
 => CACHED [api  3/11] RUN pip install --no-cache-dir poetry==1.8.3                                                0.0s
 => CACHED [api  4/11] RUN apt-get update && apt-get install -y --no-install-recommends     build-essential     g  0.0s
 => CACHED [api  5/11] RUN apt clean && rm -rf /var/lib/apt/lists/* /tmp/* /var/tmp/*                              0.0s
 => CACHED [api  6/11] COPY ./viettts /app/viettts                                                                 0.0s
 => CACHED [api  7/11] COPY ./samples /app/samples                                                                 0.0s
 => ERROR [api  8/11] COPY ./web /app/web                                                                          0.0s
------
 > [api  8/11] COPY ./web /app/web:
------
failed to solve: failed to compute cache key: failed to calculate checksum of ref 82aef0ba-fabd-42f7-a4ae-a3773c146c07::xzauz65gjv3ukprdde614faq7: "/web": not found

Thank you.

You can switch to the branch and rebuild the project. I will merge it into the main branch soon :smile:


Add support to retrieve repo information from environment variable

For CI / automated system, adding support to retrieve repo information, such as repo path, username and password if that was set in the environment can help simplifying  CI complexity.

Going to implement this like so:

Enable environment variable interpolation within .gitp_manifest by adding a variables section that specifies default values for said variables which are overridden by environment variables, if they are set).
Add optional user/password (or token) entries. Parse repo urls to automatically extract this info if it is supplied.

Implemented in 20220727 release.

Note that env var interpolation will be slightly more restrictive after this release -- suggest explicitly listing out all interpolated env vars in the manifest to support this future behavior (https://github.com/gitparent/gitparent/commit/fb92ca91cb8145b376db028b927a4b2839520dce)


Performance tweak of ScrollBar

The _ScrollbarState implements the TickerProviderStateMixin, however it uses only 1 AnimationController , that is, _fadeoutAnimationController. In cases where there is only one AnimationController, a SingleTickerProviderStateMixin is more efficient.
I would like to submit a PR for making this change, if it's an acceptable change.

Hi @chinmoy12c
Thank you for looking out for this issue,
Can you please provide your flutter doctor -v your flutter run --verbose and a complete reproducible minimal code sample
Feel create PR as well and mention this issue
Thank you

Here is the flutter doctor output

[✓] Flutter (Channel master, 1.22.0-10.0.pre.340, on Linux, locale en_US.utf8)
    • Flutter version 1.22.0-10.0.pre.340 at /home/Chinmoy/MasterFiles/openSource/flutter
    • Framework revision 1fef5912cf (4 hours ago), 2020-09-23 21:37:08 -0700
    • Engine revision dd35b5b659
    • Dart version 2.10.0 (build 2.10.0-156.0.dev)
[✓] Android toolchain - develop for Android devices (Android SDK version 29.0.3)
• Android SDK at /home/Chinmoy/Android/Sdk
• Platform android-29, build-tools 29.0.3
• Java binary at: /opt/android-studio/jre/bin/java
• Java version openjdk version "1.8.0_242-release"
• All Android licenses accepted.
[!] Android Studio (version 3.4)
• Android Studio at /home/Chinmoy/Downloads/android-studio
✗ Flutter plugin not installed; this adds Flutter specific functionality.
✗ Dart plugin not installed; this adds Dart specific functionality.
• Java version openjdk version "1.8.0_152-release"
[✓] Android Studio (version 4.0)
• Android Studio at /opt/android-studio
• Flutter plugin version 49.0.2
• Dart plugin version 193.7547
• Java version openjdk version "1.8.0_242-release"
[✓] VS Code (version 1.48.0)
• VS Code at /usr/share/code
• Flutter extension version 3.14.1
[✓] Connected device (1 available)
• SM M215F (mobile) • RZ8N501AW9E • android-arm64 • Android 10 (API 29)
! Doctor found issues in 1 category.

Here is the minimal code for ScrollBar:

import 'package:flutter/material.dart';

void main() {
  runApp(SampleWidget());
}

class SampleWidget extends StatelessWidget {
  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      home: Scaffold(
        body: Center(
          child: Scrollbar(
            child: ListView.builder(
              itemCount: 100,
              itemBuilder: (context, index) {
                return ListTile(
                  title: Text('Item $index'),
                );
              },
            ),
          ),
        ),
      ),
    );
  }
}

CC @Piinks

code sample
import 'package:flutter/material.dart';

void main() {
  runApp(SampleWidget());
}

class SampleWidget extends StatelessWidget {
  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      home: Scaffold(
        body: Center(
          child: Scrollbar(
            child: ListView.builder(
              itemCount: 100,
              itemBuilder: (context, index) {
                return ListTile(
                  title: Text('Item $index'),
                );
              },
            ),
          ),
        ),
      ),
    );
  }
}

flutter doctor -v
[✓] Flutter (Channel master, 1.22.0-10.0.pre.355, on Microsoft Windows [Version 10.0.19041.508], locale en-US)
    • Flutter version 1.22.0-10.0.pre.355 at C:\Code\flutter_master
    • Framework revision da1a42b577 (55 minutes ago), 2020-09-25 00:57:03 -0400
    • Engine revision 435db234e4
    • Dart version 2.11.0 (build 2.11.0-161.0.dev)

[✓] Android toolchain - develop for Android devices (Android SDK version 30.0.2)
    • Android SDK at C:\Code\sdk
    • Platform android-30, build-tools 30.0.2
    • ANDROID_HOME = C:\Code\sdk
    • Java binary at: C:\Code\android-studio\jre\bin\java
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b01)
    • All Android licenses accepted.

[✓] Chrome - develop for the web
    • Chrome at C:\Program Files\Google\Chrome\Application\chrome.exe

[✓] Visual Studio - develop for Windows (Visual Studio Community 2019 16.7.3)
    • Visual Studio at C:\Program Files (x86)\Microsoft Visual Studio\2019\Community
    • Visual Studio Community 2019 version 16.7.30503.244
    • Windows 10 SDK version 10.0.18362.0

[✓] Android Studio (version 4.0)
    • Android Studio at C:\Code\android-studio
    • Flutter plugin version 49.0.2
    • Dart plugin version 193.7547
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b01)

[✓] VS Code (version 1.49.1)
    • VS Code at C:\Users\Taha\AppData\Local\Programs\Microsoft VS Code
    • Flutter extension version 3.14.1

[✓] Connected device (4 available)
    • Android SDK built for x86 (mobile) • emulator-5554 • android-x86    • Android 10 (API 29) (emulator)
    • Windows (desktop)                  • windows       • windows-x64    • Microsoft Windows [Version 10.0.19041.508]
    • Web Server (web)                   • web-server    • web-javascript • Flutter Tools
    • Chrome (web)                       • chrome        • web-javascript • Google Chrome 85.0.4183.121

• No issues found!

Would any additional tests be necessary or just changing it to SingleTickerProviderStateMixin be enough?

If the fix is just using SingleTickerProviderStateMixin instead, then yes the existing tests should be proof enough. It's like fixing a typo :-).

PR waiting for review :)


Create fails in browser

When I try to run GeoPackage.GeoPackageAPI.create() in the browser it fails with Error: Unable to create GeoPackage.. The root error seems to be Failed to create adapter TypeError: Cannot read properties of undefined (reading 'startsWith'). Any ideas what I'm doing wrong? According to the API docs the argument to create is ignored/not necessary when running in the browser.

Never mind, I didn't initialize the setSqljsWasmLocateFile properly.


Improve performance graph

Closes #12

Move graph generation to separate function in overlay class.

Move graph generation to separate function in overlay class.


Store Details page not working

Hello!
Firstly thank you for such a wonderful module! It is extremely useful!
I am trying to use it on magento CE 2.2.6 php 7.1
Admin portion works fine, frontend shows map correctly, search working great, just that I am not been able to figure out how to go to the store details page. If I am setting custom external link, that is working perfectly, but if not set, there is no url to go to the store details page.
Kindly advise what I am missing.
Thank you,
Best Regards,
Nir Banerjee

hi
you must set a custom external link. why wouldn't you?
Sent from Yahoo Mail on Android
On Sun, 24 Feb 2019 at 13:33, Nirjhareswar<EMAIL_ADDRESS>wrote:
Hello!
Firstly thank you for such a wonderful module! It is extremely useful!
I am trying to use it on magento CE 2.2.6 php 7.1
Admin portion works fine, frontend shows map correctly, search working great, just that I am not been able to figure out how to go to the store details page. If I am setting custom external link, that is working perfectly, but if not set, there is no url to go to the store details page.
Kindly advise what I am missing.
Thank you,
Best Regards,
Nir Banerjee
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.


Fix bugs in example of EstimatorV2

Summary
Fix #12324
Details and comments
hamiltonian* are not defined the example. Instead, H* are used in this fix.
Also, this PR deletes a odd closed bracket in this example.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

0 of 0   changed or added relevant lines in 0 files are covered.
3 unchanged lines in 1 file lost coverage.
Overall coverage increased (+0.007%) to 89.548%

Files with Coverage Reduction
New Missed Lines
%

crates/qasm2/src/lex.rs
3
91.6%

Totals

Change from base Build<PHONE_NUMBER>:
0.007%

Covered Lines:
61608

Relevant Lines:
68799

💛  - Coveralls


Update CHANGELOG.md

[ ] 2.0.0: v1.0.5...2.0.0
[ ] 2.0.1: 2.0.0...2.0.1
[x] Add CHANGELOG link to Hex metadata

and add changelog link to hex package links...

Can we get one for 3.0.0? I'd like to upgrade but it unclear what has changed.

2.1.2...3.0.0 adds scheme, host, and port to #req{}

So we can close this?  ￼https://github.com/elli-lib/elli/issues/28 ? :)

Closing this. We can open a new one if we want to add more detail to CHANGLOG.md.


settings gear can delay heavily

needs to be more reactive. Might be an issue w/ the timing of the event talking to the modal to open and styles being reapplied.

fixed.


Image umount delets image if the mountpoint is busy

We found a bug with the disklessset tool.
Scenario:

You mount an image via disklessset to (/var/tmp/diskless/workdir/imagename/mnt)
Exit disklessset or use another terminal and change directory to /var/tmp/diskless/workdir/imagename/mnt for chroot or whatever
You then start again disklessset to umount the image (and still have a bash in the mountpoint)

In this scenario the disklessset tool failed to umount the image, because the mountpoint is busy, but it still proceed with the umount process. So it will still do an "rm -rf /var/tmp/diskless/workdir/imagename/mnt " which will delete the content of the image. Afterwards disklessset will crash, but the image is already lost.
Solution would be just to check if the umount was successfully before executing the rm -rf command.
There is also typo in the menu for umounting:
3 - Unount an existing livenet image ->  3 - Umount an existing livenet image

Dear @michaelhoehl
Thanks a lot for reporting this issue ! 🙂
I will investigate this issue asap !

Issue has been solved in latest release :-)


Update flyway-core to 7.8.0

Updates org.flywaydb:flyway-core from 6.5.7 to 7.8.0.
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "org.flywaydb", artifactId = "flyway-core" } ]

labels: library-update, semver-major

CI fails. A simple bump is not enough.

Superseded by #1280.


Orientation problem labels-disc M12 subjects

I identified an orientation problem in the sub-van111_ses-M12_PSIR_lesion-manual_label.nii.gz.
The dimension is : (16, 336, 336) instead of (336, 336,16)
→ Currently investigating how to solve and if other files have the same problems
The files come from "Discs labelling Hourglass"
tagging @NathanMolinier @valosekj

Good catch!
The original PSIR image looks good (it has 336, 336, 16 dimensions; which also corresponds with M0):
valosek@macbook-pro:~/data/data.neuro.polymtl.ca/canproco/sub-van111$ sct_image -i ses-M12/anat/sub-van111_ses-M12_PSIR.nii.gz -header | grep "dim"
dim		[3, 336, 336, 16, 1, 1, 1, 1]

valosek@macbook-pro:~/data/data.neuro.polymtl.ca/canproco/sub-van111$ sct_image -i ses-M0/anat/sub-van111_ses-M0_PSIR.nii.gz -header | grep "dim"
dim		[3, 336, 336, 16, 1, 1, 1, 1]

Maybe the disc labeling was done on the reoriented image? If so, try to reorient sub-van111_ses-M12_PSIR_lesion-manual_label.nii.gz to the PSIR native orientation (AIL).

Indeed the images were reoriented before creating the labels and I forgot to reuse the original orientation of the image.
However, it is a good reminder that we always need to make sure that we check the orientation before treating an image. The class Image (from SCT) is suited for this task.

Okay, I see! Could you please reorient the disc labels back to the original orientation and push them to git-annex?

This was solved during the re-orientation of all derivatives file in this issue : https://github.com/ivadomed/ms-lesion-agnostic/issues/1#issuecomment-1949222474


Routing in client

I have configured the express app to send the template HTML when the root is accessed
app.get('/', (req, res) => {     res.status(200).send(template()); })
However, when I try to access routes such as '/users', '/profile' it goes to the backend and I get the error 'cannot GET/users' because this isn't a backend route.
In the first few chapters of the book, while building the social media app this is how it was indicated to go about it.  Why isn't the router working with the given information in the book.
Currently I cannot render the specific pages by directly entering the URL or reloading. I have to go to the root and click a linked button

Closing this because Ive seen it is explained later in the book


Test running optimization

Currently the tests take quite a bit of time to run. We need to optimize how this work.

duplicate of #367


CAS Client upgrade to 3.4.x

Closes https://github.com/pac4j/pac4j/issues/213 and https://github.com/pac4j/pac4j/issues/242 and https://github.com/pac4j/pac4j/issues/222

Excellent!
+1 with a few comments

Updated pull

Great! Thanks


JSX Components

Can I please work on fixing some JSX components that don't have closing tags like the  tags? They should be <img ...... />

Hi,
Yea absolutely! I'm not that familiar with React so any help finding/fixing those bugs is more than welcome.
Just to make sure that I understood the problem, plain HTML uses this syntax
<img ... >
and React needs the closing slash at the end?
<img ... />

If that's the case then looks like I'm just missing the handling for that in useReactSyntax() method in src/app/shared/services/formatter.service.ts
You can add that if you'd like (and please add a test case for it as well) or I can take a look during the weekend.

Okay, will start working on it.


[BUG] image width and height reversed.

Describe the bug

Get the image from CameraPicker.pickFromCamera(context); the orientatedWidth and orientatedHeight are reversed.
How to reproduce

Steps to reproduce the behavior:

add the following line to HomePage.dart L31 in example code.
print('swifty:${result.orientation} ${result.orientatedWidth} ${result.orientatedHeight}');
press Taking photos to take a vertical photo.
from the log it shows swifty:0 3840 2160 which means a horizontal photo.

Expected behavior

the orientatedWidth should be 2160. orientatedHeight should be 3840
Screenshots (If contains)

Version information

Device: Sumsung, Xiaomi
OS: Android 11,Android 13
Package Version: master branch.
Flutter Version: 3.16.9, 3.22.1

Additional context

Offline discussed with related developers that the Samsung phone always produces invalid orientation in the EXIF. Solving particular brand devices is out of the scope of the plugin.

Offline discussed with related developers that the Samsung phone always produces invalid orientation in the EXIF. Solving particular brand devices is out of the scope of the plugin.

Also reproduced in Xiaomi 10 pro~


[FX-4783] Add integration builder how-to guide for GitHub

Changelog
Added

Page
Deploy Preview
Comment

GitHub
https://deploy-preview-543--cobalt-docs.netlify.app/integrations/integrationbuilder/how-to-guides/github/
How-to guide for setting up a GitHub recipe using Integration Builder

Preview This Change
To see how this change looks in production, scroll down to Deploy Preview. Select the link that looks like https://deploy-preview-<num>--cobalt-docs.netlify.app/
Variables
Help us support a “Write once, publish everywhere” single source of truth. If you see a line that looks like:
{{% asset-categories %}}
You’ve found a shortcode that we include in multiple documents.
You’ll find the content of the shortcode in the following directory:
https://github.com/cobalthq/cobalt-product-public-docs/tree/main/layouts/shortcodes
That shortcode has the same base name as what you see in the PR, such as asset-categories.html.
Checklist for PR Author
[ ] Did you check for broken links and alt text?
Be sure to check for broken links and Alt Text issues. We have a partially automated process,
as described in this section of our repository README:
Test Links and Alt Attributes.

@mahmoudadly-cobalt @wolfgangbecker I made a folder for How to Guides under IntegrationBuilder thinking that the pages we're working on would all go there. We don't have to do it that way, I just thought it would make it more organized. Let me know what you think of that approach.

@mahmoudadly-cobalt @wolfgangbecker I made a folder for How to Guides under IntegrationBuilder thinking that the pages we're working on would all go there. We don't have to do it that way, I just thought it would make it more organized. Let me know what you think of that approach.

Yes, I saw that and applied it to https://github.com/cobalthq/cobalt-product-public-docs/pull/544 as well. I agree this is better to keep things organized.


fix(sec): upgrade org.apache.kafka:kafka-clients to 3.4.0

What happened？
There are 1 security vulnerabilities found in org.apache.kafka:kafka-clients 3.1.0

CVE-2023-25194

What did I do？
Upgrade org.apache.kafka:kafka-clients from 3.1.0 to 3.4.0 for vulnerability fix
What did you expect to happen？
Ideally, no insecure libs should be used.
The specification of the pull request
PR Specification from OSCS

Plugin dependencies only affect tests. There is no security impact.


implement(#764): Add eslint-plugin-redux-saga

React Boilerplate
Adds eslint-plugin-redux-saga linting rules. Closes #764. CC: @mxstbr
Thank you for contributing! Please take a moment to review our contributing guidelines
to make the process easy and effective for everyone involved.
Please open an issue before embarking on any significant pull request, especially those that
add a new library or change existing tests, otherwise you risk spending a lot of time working
on something that might not end up being merged into the project.
Before opening a pull request, please ensure:

[X] You have followed our contributing guidelines
[X] Pull request has tests (we are going for 100% coverage!)
[X] Code is well-commented, linted and follows project conventions
[X] Documentation is updated (if necessary)
[X] Internal code generators and templates are updated (if necessary)
[X] Description explains the issue/use-case resolved and auto-closes related issues

Be kind to code reviewers, please try to keep pull requests as small and focused as possible :)
IMPORTANT: By submitting a patch, you agree to allow the project
owners to license your work under the terms of the MIT License.

Coverage remained the same at 98.953% when pulling 28250d83b1f1679a10b48d5a2d7fcacea91391e6 on jstockwin:eslint-plugin-redux-saga into 8693af3708e31f25fc0883256da605b3ccc03c9a on mxstbr:master.

Coverage remained the same at 98.953% when pulling 28250d83b1f1679a10b48d5a2d7fcacea91391e6 on jstockwin:eslint-plugin-redux-saga into 8693af3708e31f25fc0883256da605b3ccc03c9a on mxstbr:master.

Would you mind rebasing and fixing conflicts against the dev branch? Thanks!

Every time. Yeah will do :)

@mxstbr That should do it.

Coverage remained the same at 98.953% when pulling f8b1148932a93fa7bfe114478cd60e0893176869 on jstockwin:eslint-plugin-redux-saga into b908e8601793cbe1552d7fce5aaed05dd402deaf on mxstbr:dev.

Awesome, thanks!


WIP: Customizing secret and manifestwork event sources

Signed-off-by: liuwei<EMAIL_ADDRESS>

refer to https://github.com/open-cluster-management/backlog/issues/16595

/assign @zhiweiyin318

Can we hold this PR temporarily?
I find it seems there is a simpler way to implement this. I will try it and discuss it with @skeeey later.

/lgtm

Can we hold this PR temporarily? I find it seems there is a simpler way to implement this. I will try it and discuss it with @skeeey later.

Yesterday I found the SelectorsByObject option to cache feature of the controller-runtime, I think we can set the label/field selector for Secret by overriding the SelectorsByObject while creating controller runtime manager.
...
	// Create controller-runtime manager
	mgr, err := ctrl.NewManager(cfg, manager.Options{
		Scheme:             scheme,
		MetricsBindAddress: fmt.Sprintf(":%d", metricsPort),
		LeaderElection:     true,
		LeaderElectionID:   "managedcluster-import-controller.open-cluster-management.io",
		NewCache:           newCache,
	})
...
// newCache initializes and returns a new Cache.
func newCache(config *rest.Config, opts cache.Options) (cache.Cache, error) {
	labelSelector := labels.NewSelector()
	requirement, err := labels.NewRequirement(constants.ClusterImportSecretLabel, selection.Exists, nil)
	if err != nil {
		return nil, err
	}
	labelSelector = labelSelector.Add(*requirement)

	fieldSelector := fields.OneTermEqualSelector("metadata.name", constants.AutoImportSecretName)

	opts.SelectorsByObject = cache.SelectorsByObject{
		&corev1.Secret{}: {
			// Label and Field selector should be OR relationship instead of AND.
			Label: labelSelector,
			Field: fieldSelector,
		},
	}
	return cache.New(config, opts)
}

But we need the auto import secret(field selector, result A) and the import secret(label selector, result B), union of A and B. But SelectorsByObject feature gets the intersection of A and B.
It is close to code freeze I think we can merge this PR now. And in the future, we can

add a specific label to the auto import secret and make all secrets we are interested in could be selected by labels, then we can use SelectorsByObject to filter the Secret cache.

OR

push the upstream controller-runtime to support union label selector and field selector of SelectorsByObject option to cache

/hold cancel


continue.vsix Support airgapped networks?

Before submitting your bug report

[X] I believe this is a bug. I'll try to join the Continue Discord for questions
[X] I'm not able to find an open issue that reports the same bug
[X] I've seen the troubleshooting guide on the Continue Docs

Relevant environment info
- OS:windows
- Continue version:0.9.215
- IDE version:1.74.3
- Model:
- config.json:

Description
Unable to install the Continue vsix plug-in in a completely offline environment, like it needs to download something or verify online?

To reproduce
No response
Log output

No response

The above issue looks a lot more like you installed the incorrect architecture version for your operating system. In the past, when I have seen architecture mismatches, the errors looked very similar to yours.
Could you verify that you've install the correct version? If you're on an arm windows, double check you have the arm .vsix, if you're on an x64 windows, double check you have the x64 vsix.


Add Release on GitHub

These GitHub releases aren't super useful, but a user glancing at the Releases section of the GitHub page for the project might get the mistaken impression that there hasn't been a release since February.

This happened, and also for 0.15! Thanks.


Add Huawei Web Cat Bot

A new Huawei bot hitting our test servers - coming from their servers!
Their link is a 301 - 302 - 404
Link: https://isecurity.huawei.com/sec/web/urlClassification.do
Probably linked to their spamming PetalBot.

Coverage remained the same at 100.0% when pulling c477b5a08338d478d8d0b5341c19bec8425dd3b1 on ayumi-cloud:HuaweiWebCatBot into c65ad41ee66cc126a7740d929aab706dd7304c1c on WhichBrowser:master.


fixed paddy light path

fixes #1

@a5hk Thank you for the pull request! Will publish a patch soon. And happy New Year!

@a5hk Thank you for the pull request! Will publish a patch soon. And happy New Year!


Controller::distToSegmentSquared() does not do what the documentation suggests

While working on unit tests for Controller::distToSegmentSquared() I noticed the following.
The documentation suggests that the pose it returns is the point on the segment PV (start, end) that is closest to W (point). It does not do this.
I had the following test case:
TEST(PathTrackingPidCalculations, ClosestPointOnSegment_CloseToStart)
{
  const auto start = create_transform(2, 2, 0);
  const auto end = create_transform(4, 4, 0);
  const auto point = create_transform(0, 1, 0);
  const auto ref = start;

  EXPECT_EQ(ref, closestPointOnSegment(start, end, point, false));
}

point is closest to start of any point on start-end but the following is returned: [1.759, 2.319, 0].

Looks like a nice catch to me.
@cesar-lopez-mar is this expected behavior?

Oops. Might be false alarm. We messed up the documentation and because of that I messed up the order of the arguments in my unit tests. Will fix the documentation and tests and see what happens tomorrow.

Ah, I did the math by hand for this test case. It should be exactly [1.760, 2.320, 0], so that checks out.

It's just a documentation "bug". I fixed it in PR #133 .


add checkbox

solving issue #3

the code is ok, but you need to do changes in another branch named "hacktoberfest" please, NOT in the master branch.

the code is ok, but you need to do changes in another branch named "hacktoberfest" please, NOT in the master branch.

let see at #17


Refactor companystep to use Form

Details

Refactor companyStep in to use Form.js component.
Fixed Issues

$ #9580
Tests

Add a new workspace
Navigate to Settings > [Workspace] > Connect bank account > Connect manually.
Fill information on connect bank account page then navigate to company information page.
Fill company step form and validate changes.

[x] Verify that no errors appear in the JS console

PR Review Checklist

Contributor (PR Author) Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[ ] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] iOS / native
[x] Android / native
[x] iOS / Safari
[x] Android / Chrome
[x] MacOS / Chrome
[x] MacOS / Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product was added in all src/languages/* files
[x] I verified any copy / text that was added to the app is correct English and approved by marketing by tagging the marketing team on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[ ] If a new component is created I verified that:

[ ] A similar component doesn't exist in the codebase
[ ] All props are defined accurately and each prop has a /** comment above it */
[ ] Any functional components have the displayName property
[ ] The file is named correctly
[ ] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[ ] The only data being stored in the state is data necessary for rendering and nothing else
[ ] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[ ] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[ ] All JSX used for rendering exists in the render method
[ ] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[ ] If a new CSS style is added I verified that:

[ ] A similar style doesn't already exist
[ ] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)

[ ] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[ ] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

PR Reviewer Checklist
The Contributor+ will copy/paste it into a new comment and complete it after the author checklist is completed

[ ] I have verified the author checklist is complete (all boxes are checked off).
[ ] I verified the correct issue is linked in the ### Fixed Issues section above
[ ] I verified testing steps are clear and they cover the changes made in this PR

[ ] I verified the steps for local testing are in the Tests section
[ ] I verified the steps for Staging and/or Production testing are in the QA steps section
[ ] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[ ] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[ ] I checked that screenshots or videos are included for tests on all platforms
[ ] I verified tests pass on all platforms & I tested again on:

[ ] iOS / native
[ ] Android / native
[ ] iOS / Safari
[ ] Android / Chrome
[ ] MacOS / Chrome
[ ] MacOS / Desktop

[ ] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[ ] I verified proper code patterns were followed (see Reviewing the code)

[ ] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[ ] I verified that comments were added to code that is not self explanatory
[ ] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[ ] I verified any copy / text shown in the product was added in all src/languages/* files
[ ] I verified any copy / text that was added to the app is correct English and approved by marketing by tagging the marketing team on the original GH to get the correct copy.
[ ] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[ ] I verified the JSDocs style guidelines (in STYLE.md) were followed

[ ] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[ ] I verified that this PR follows the guidelines as stated in the Review Guidelines
[ ] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
[ ] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[ ] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[ ] If a new component is created I verified that:

[ ] A similar component doesn't exist in the codebase
[ ] All props are defined accurately and each prop has a /** comment above it */
[ ] Any functional components have the displayName property
[ ] The file is named correctly
[ ] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[ ] The only data being stored in the state is data necessary for rendering and nothing else
[ ] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[ ] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[ ] All JSX used for rendering exists in the render method
[ ] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[ ] If a new CSS style is added I verified that:

[ ] A similar style doesn't already exist
[ ] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)

[ ] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[ ] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[ ] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

QA Steps

[ ] Verify that no errors appear in the JS console

Screenshots

Web

https://user-images.githubusercontent.com/35763921/187890158-74dbde2a-e651-475f-8881-d3db1f43a17a.mov
Mobile Web

Desktop

https://user-images.githubusercontent.com/35763921/187885205-de6fb00d-ecb5-45fe-8f8d-9b96bd394cec.mov
iOS

https://user-images.githubusercontent.com/35763921/187890279-ddd0bd70-f38e-4529-995c-29a797e1ce7b.mov
Android

https://user-images.githubusercontent.com/35763921/187890400-acb0237d-2b11-476e-ac05-c1e5de582c75.mov

I'll review and test this by tomorrow.
@ravindra-encoresky You need to mark every item in the checklist to confirm you've gone through it even if it doesn't apply to the PR. Also I hope you've gone through the guidelines mentioned in the issue GH body.

@mananjadhav checked all items in review checklist

@ravindra-encoresky The changes look fine, but can you please take the latest main pull for this one?
Also mWeb screencast is missing. can you please update it? Once done ping me and I'll get to testing it.

hey @mananjadhav I have uploaded mWeb  screen recording. Also merged main branch into this one.

@ravindra-encoresky Changes look fine but I see one test failing. I am unable to select the correct address and it seems due to this validation on the city also fails. Attached is the screencast for the same. Can you please fix this? Also for all the platforms can you please add success (movement to the next step) as well as failure scenario?
https://user-images.githubusercontent.com/3069065/188514394-613966c2-6311-4738-a0cf-4f98c6333051.mov

okay, I am making necessary changes. will push once done.

@mananjadhav I have facing issue in selecting company address, It is a searchable input so on selecting suggested address it should fill up city, state, zip code also. But in current Form implementation I am unable to do so.

Generally we don't pass any value to inputs within Form component, but In this case I have to values to city, state and zip code so these value fill up after selecting address.
When I am passing values in defaultValue  prop, it does not work.
When I am passing values in value prop, in this case value filling up is working but It failed form validation if we go and come back to page again.
Last option I have to exclude address files from Form component and manage their validation manually otherwise we have to make changes in our form component

@ravindra-encoresky I've posted a comment here wrt to AddressForm component

@ravindra-encoresky any updates? 😄

@ravindra-encoresky any updates? 😄

please check this  : https://github.com/Expensify/App/issues/9580#issuecomment-1241055886

Sorry @ravindra-encoresky I look at the PRs more often than I look at the GHs, just updated the GH

I'm adding the hold title to this PR as it's easier to know while looking at the list of PRs I need to review

@mananjadhav @sketchydroide I have used the updated AddressForm component and made the necessary change. PR is ready for review.

@ravindra-encoresky Thanks for the update on the PR Can you follow this template for the checklist and the screenshots?
We now have two test platforms for mWeb - Android Chrome and iOS Safari. Also your Web URL seems to be broken and hence the preview is not loaded.

Did a quick review and changes seem to be looking good. @ravindra-encoresky Can you please resolve conflict? and address the earlier comment  ?

@mananjadhav sure, I am working on it, I will let you know when done.

@mananjadhav I have made the necessary changes

Used new PR template.
Attached video for mobile safari
Merged main branch and resolved conflicts

@mananjadhav I have made the necessary changes

Used new PR template.
Attached video for mobile safari
Merged main branch and resolved conflicts

@mananjadhav

Also, I think that we can remove the hold on this PR.

@ravindra-encoresky Did you get a chance to look at @luacmartins's comments?

@ravindra-encoresky Did you get a chance to look at @luacmartins's comments?

Will check.

@luacmartins I have fixed above mentioned changes. Please check

@luacmartins I have fixed above mentioned changes. Please check

@mananjadhav @sketchydroide

Looking good. Just a few more comments:

Let's make reimbursmeentAccountDraft prop optional, since the user could be on the CompanyStep, login and not have any draft values saved. We can default it to an empty object.
Fix the errors doesn't seem to work on iOS:

fix-error.mov

I have checked it, on first click it works as expected but on second click input is already focused so it's do nothing.
On web on second click it scroll up to make focused input visible but in iOS it's not.
If we consider it a bug then it require to modify Form.js

I have checked it, on first click it works as expected but on second click input is already focused so it's do nothing.
On web on second click it scroll up to make focused input visible but in iOS it's not.

I would say it should scroll up as well here for all the platforms where the input is not visible.
but maybe this is a bug that goes beyond this PR, @luacmartins you know more about Forms than me, what do you think?

Sorry about the late reply - I’m ooo until Nov 22 so I’m checking these messages sporadically. I think it’s fine to fix the “fix the errors” behavior in a separate PR since that seems to be broken on other flows as well.

Is this PR ready for another round of reviews? Or more generally, where are we at?

@ravindra-encoresky do you need any more information?

No, since the requested change has already been done from my side already.
@JmillsExpensify @luacmartins

so you are just waiting for the review to be completed, is that correct?

@JmillsExpensify I think once Carlos is back on Monday he can give the ok if he's happy with the changes, in the mean time I can go over the PR and see if I can find anything else.
@mananjadhav can also check if there is something that he feels need some change, but not sure if it's worth him testing until Carlos gives the 👍🏼

I'll go through this by tomorrow.

@JmillsExpensify I think once Carlos is back on Monday he can give the ok if he's happy with the changes, in the mean time I can go over the PR and see if I can find anything else.

Sounds good. We can test in the meantime.

The code changes are fine so far, and the form validation etc. works fine, but I have two issues.

Company Website field is defaulted to https:// in the staging, but in the current form is it blank. I am trying to find a conversation, where we decided to remove it. @ravindra-encoresky Can you please confirm if this was intentional?

After submitting the iOS mobile app form, intermittently I am getting an error for incorporationDate. I am not able to reproduce it every time.

Rest of the testing worked fine.

@mananjadhav

It is not intentional, it was a mistake. As you said you had decided to remove it. Should I fix push the fix or keep as it is.

As you said you had decided to remove it

I meant I was checking if we decided to remove. I think I would recommend to add it back, because if the URLs don't have http:// or https://, they throw an error.
What about the other two pointers @ravindra-encoresky ?

@mananjadhav I have added back https://. Also updating you about last two pointers in some time.

@mananjadhav
2. We have taken incorporationDate as string in reimbursementAccountDraftPropTypes but on selecting date from date picker it return Date object. That's why it is giving error. It is an existing issue which is also in the old implementation. To address this issue we need to refactor reimbursementAccountDraftPropTypes which I think is out of scope of this PR

This is related to Form.js implementation. I have checked on other screens where CheckboxWithLabel is child of Form.js, same issue everywhere. So I think it is also out of scope of this PR.

Thanks for the comments @ravindra-encoresky I'll test once again today with the default value for website and update the screencasts. Appreciate your patience on this one.

@ravindra-encoresky I am not able to test on iOS for some reason. My simulator isn't starting up. I tested this in other platforms. Can you post an updated screencast for iOS and @luacmartins can you help here?
For the times it loads sometimes I get this error: Are you getting the same by any chance @ravindra-encoresky ?

Just came back from ooo, I'll review this in a moment.
@mananjadhav ios is working for me. I'd recommend clearing node_modules and npm cache and running npm install again.

I was able to get it working.

I'd recommend clearing node_modules and npm cache and running npm install again.

This worked. Thanks @luacmartins. Been switching between multiple PRs today ;)
Reviewer Checklist

[x] I have verified the author checklist is complete (all boxes are checked off).
[x] I verified the correct issue is linked in the ### Fixed Issues section above
[x] I verified testing steps are clear and they cover the changes made in this PR

[x] I verified the steps for local testing are in the Tests section
[x] I verified the steps for Staging and/or Production testing are in the QA steps section
[x] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[x] I checked that screenshots or videos are included for tests on all platforms
[x] I included screenshots or videos for tests on all platforms
[ ] I verified tests pass on all platforms & I tested again on:

[ ] iOS / native
[x] Android / native
[x] iOS / Safari
[x] Android / Chrome
[x] MacOS / Chrome
[x] MacOS / Desktop

[x] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
[x] I verified proper code patterns were followed (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product was added in all src/languages/* files
[x] I verified any copy / text that was added to the app is correct English and approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I verified that this PR follows the guidelines as stated in the Review Guidelines
[x] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)

[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots

Web

https://user-images.githubusercontent.com/3069065/203396479-38d87b87-6877-4b63-94e0-3b2b7f176722.mov
Mobile Web - Chrome

https://user-images.githubusercontent.com/3069065/203396583-1e124b3f-6755-401a-9485-b1792e36bd42.mov
Mobile Web - Safari

https://user-images.githubusercontent.com/3069065/203397869-c1d1ac28-bdc7-4673-a489-9f64f226311a.mov
Desktop

https://user-images.githubusercontent.com/3069065/203396709-a60450cf-1423-4cb6-81c7-148146dfdffc.mov
iOS

https://user-images.githubusercontent.com/3069065/203399559-c9f30258-6397-42cd-8c25-34bf094c9481.mov
Android

https://user-images.githubusercontent.com/3069065/203396758-5e9cd100-3866-4339-bbde-e2a5d713838d.mov

@ravindra-encoresky I left a few comments above. We are really close, let's try to get this merged today!

@mananjadhav I've pushed the changes, not sure - not intended to close the PR. Please let me know if I need to do something.
thanks. Looking forward.

@mananjadhav @luacmartins I had changed my system few days ago and due to this I have pushed one commit with the different account. I think some details is lost now, commits are showing unverified and CLA is not signed. Please guide me what step to take next.
P.S. All the code related changed are done. You can continue review

@mananjadhav @luacmartins I had changed my system few days ago and due to this I have pushed one commit with the different account. I think some details is lost now, commits are showing unverified and CLA is not signed. Please guide me what step to take next.

You need to open a new PR and add all the commits you added to this one with the user that is approved. I think that should fix it.

@ravindra-encoresky you can try the following instructions:

git reset 0b554e73c73cd7acaba4eb881bf210c841072350 this will reset your branch to before the commit with your other account
Force push your changes
Merge main again and create a new commit with the changes from your latest commit
Run git -c core.editor=true rebase --exec 'git commit --amend --no-edit -n -S' -i $COMMIT_HASH replacing $COMMIT_HASH with the first commit that needs to be signed, in this case 6c9c88517df4a9dc6b26665be61d7a7f8167b44b
Force push your changes

If that fails, then @sketchydroide steps above sound fine to me.

Thanks @luacmartins Your solution seems way better than mine.
@ravindra-encoresky let us know if that helped

Let’s see if it works 😬 🤞

@luacmartins Thanks for solution. I am on it. GPG key sign in is not working in my m2 macbook, I am currently resolving it. will update you once done.

@luacmartins @mananjadhav @sketchydroide I have opened a new PR https://github.com/Expensify/App/pull/13076.
I have put all changes in just single commit because i was also getting issues in singing previous commits.
Please have a look.

thanks @mananjadhav let's move there, we can close this PR


[BUG] Dashy is unable to finishing signing with Keycloak

Environment
Self-Hosted (Docker)
System
Arch based Chromium version 129.0.6668.101
Version
3.1.1
Describe the problem
When attempting to authenticate via Keycloak I get passed the sign in screen and then a 401 error is thrown blocking me from Keycloak
Additional info
Dashy Auth Config
  auth:
    enableKeycloak: true
    keycloak:
      serverUrl: 'https://account.flench.me'
      realm: 'Nebulee'
      clientId: 'keycloak-d'

Console Logs
Error with Permissions-Policy header: Origin trial controlled feature not enabled: 'private-state-token-redemption'.
Error with Permissions-Policy header: Origin trial controlled feature not enabled: 'private-state-token-issuance'.
Error with Permissions-Policy header: Unrecognized feature: 'browsing-topics'.
Error with Permissions-Policy header: Origin trial controlled feature not enabled: 'private-state-token-redemption'.
Error with Permissions-Policy header: Origin trial controlled feature not enabled: 'private-state-token-issuance'.
Error with Permissions-Policy header: Unrecognized feature: 'browsing-topics'.
Error with Permissions-Policy header: Origin trial controlled feature not enabled: 'private-state-token-redemption'.
Error with Permissions-Policy header: Origin trial controlled feature not enabled: 'private-state-token-issuance'.
Error with Permissions-Policy header: Unrecognized feature: 'browsing-topics'.
Error with Permissions-Policy header: Origin trial controlled feature not enabled: 'private-state-token-redemption'.
Error with Permissions-Policy header: Origin trial controlled feature not enabled: 'private-state-token-issuance'.
Error with Permissions-Policy header: Unrecognized feature: 'browsing-topics'.
KeycloakAuth.js:28

       POST https://account.flench.me/realms/Nebulee/protocol/openid-connect/token 401 (Unauthorized)
C @ keycloak.mjs:776
(anonymous) @ keycloak.mjs:255
Promise.then
h @ keycloak.mjs:254
Promise.then
(anonymous) @ keycloak.mjs:319
Promise.then
(anonymous) @ keycloak.mjs:316
(anonymous) @ KeycloakAuth.js:28
value @ KeycloakAuth.js:27
f @ KeycloakAuth.js:87
(anonymous) @ main.js:73
Promise.then
56d7 @ main.js:65
l @ bootstrap:89
0 @ dashy.432463d9.js:1
l @ bootstrap:89
a @ bootstrap:45
(anonymous) @ bootstrap:267
(anonymous) @ dashy.432463d9.js:1
Show 5 more frames
Show less
CoolConsole.js:11
⚠ Warning ⚠ Failed to authenticate with Keycloak This is likely not an issue with Dashy, but rather your configuration.If you think it is a bug, please open a ticket on GitHub: https://git.io/JukXk

Please tick the boxes

[X] You have explained the issue clearly, and included all relevant info
[X] You are using a supported version of Dashy
[X] You've checked that this issue hasn't already been raised
[X] You've checked the docs and troubleshooting guide
[X] You agree to the code of conduct

Not sure if this is 100% related but I also have issues getting Keycloak to work. Keycloak works fine with other services but it just won't work with Dashy. However in my case there is just one (browser) console entry with "Failed to authenticate with Keycloak", the POST to the token endpoint returns 200 and Keycloak lists an active session.
I can also see IDENTITY/SESSION cookies for the auth domain Keycloak runs behind but no cookies for the domain pointing to Dashy, is this intended?

https://github.com/Lissy93/dashy/issues/1625
Seems like keycloak has been broken since some longer time.
Honestly I wouln't think this will get fixed in any near future, looking at the state of this project behind the curtains and the owner of this repo.

One solution is to use OIDC auth which (for now) still works, please see take a look at my answers to this issue.


Unit Test: Pop folder

[x] Check agent population name
[x] Check setting and getting variable functions

[x] the variable type is correct?
[x] accessing a wrong variable

[x] maximum population size
[x] accessing agents more than population size
[x] access population data with multiple states for the same agent
[x] accessing agent population that is not set


moved update out of draw area

Moved the update stuff out of the drawing area. Can close PR if not necessary
Discussion from https://github.com/raysan5/raylib/pull/4401

@CrackedPixel Excellent! That's how I like the code organized! 😄


Fix broken example in Korean docs

Changes:
Fix broken example in Korean docs - drawing-continuous-lines
Example is not working.
https://p5js.org/ko/examples/drawing-continuous-lines.html
Screenshots of the change:

Looks good. Thanks!

@all-contributors please add @taejs for #1142


Improve errors if user forgets to use jsonnet to write yaml

Current error is cryptic:
RUNTIME ERROR: expected string result, got: object

Options:

Change the error to suggest using std.manifestYamlDoc()
Ignore the error and generate yaml based on the json output. (Requires setting vm.StringOutput to false, so may require a config step.)

Option 2 might improve the readability of yaml output, given that jsonnet quotes every key.

Note: the error can be improved in either case, so perhaps do that first and create a new issue to allow configuration options for serialization.

Fixed with #127