react-router v4 && react-hot-loader@3 && Code Splitting

@choonkending @slavab89

@GGAlanSmithee #841

#908

I'll do a fresh pull to night and check this out! <-- excited 😄

@ZeroCho Thanks for the ping! Very exciting, I will take a look at it as soon as I get some free time. Without having looked at it - does this PR do server-side rendering + code splitting with react-router@4? If so, that's very nice, I have struggled with it a lot. Been a bit intrigued by https://github.com/faceyspacey/redux-first-router, wanting to test it out, have you come across it?

@GGAlanSmithee Yes. SSR + Code splitting with react-router@4
I didn't have time to comment on my code, and didn't test it, so errors may happen

@ZeroCho This is an excellent!
I like the fact that we are no longer relying on react-router-redux any longer. Decoupling our navigation from redux was one of the aims I had in mind.
I would like to spend some time this weekend playing around further with this branch in order to have an understanding of what's changed. Perhaps some modules can be split into more, mainly because they seemed to be doing too many things. But I would have to try it out in order to give a better comment!

@choonkending Decoupling react-router-redux is quite easy. If you want me to decouple it. I will.
However, I like react-router-redux because it dispatches LOCATION_CHANGE action everytime url changes. By listening to the action, I can simulate onUpdate of react-router@3, which is in app/client.js

So i've started to play around with it on my side and i'm getting
Warning: setState(...): Can only update a mounting component. This usually means you called setState() outside componentWillMount() on the server. This is a no-op. Please check the code for the AsyncComponent component.

I presume that this happens because of the promise there.. componentWillMount exists and when the promise returns setState is called.
How would it be possible to disable the async component loading on the server side? Doesnt seem to be necessary anyway, no? Maybe with something like https://github.com/thejameskyle/react-loadable ?

@slavab89 Changing from componentWillMount to componentDidMount will resolve that problem.

Been testing this a bit and it seems to be working fine, with the small aside mentioned by @slavab89. I definitely agree that code splitting on the server should be avoided if possible. I have no idea how to do this with AsyncComponent though. Using webpacks chunk plugin, i managed it with a hack;
new webpack.optimize.MinChunkSizePlugin({minChunkSize: browser ? 10000 : Infinity})
@ZeroCho

And it is for Search Engine Optimization.

Care to elaborate on this? Not sure what you are reffering to exactly.

@GGAlanSmithee Ah, I now got what @slavab89 means. I did some misunderstanding. I think I can change some code of app/routes.js to avoid code splitting on the server.
component: isServer ? Home : asyncComponent(...)

So i've just discovered something that might bring us the solution..?
First of all, the article: https://medium.com/faceyspacey/code-cracked-for-code-splitting-ssr-in-reactlandia-react-loadable-webpack-flush-chunks-and-1a6b0112a8b8
It is actually pretty interesting.
And the module itself (Pretty much react-loadable successor) https://github.com/faceyspacey/react-universal-component
And they've create a demo as an example: https://github.com/faceyspacey/universal-demo
Did anyone of you heard about this?

Took a brief look at the code. Not too much to add unfortunatley, it looks fine too me.
The only real issue discovered so far is the server-side code splitting if I understand it correctly? It might be inconveniant, but it's not really a bug. This PR seems like the way to go. rr4 and react-hot-loader 3 is :+1:. Maybe if it's merged, we can iterate on it? Is there anything besides time blocking it? :smile:

Hey peeps, just an update,  Ive been working on a branch inspired by @ZeroCho 's work here. It's still in WIP (lots to cover) https://github.com/reactGo/reactGo/compare/master...choonkending:react-router-4-clean.
I thought there might be a better way around our server side and client side data fetching, so I was experimenting around with that.
Just to let you peeps know that I'm not ignoring this awesome PR!

So i've recently tried to use https://github.com/faceyspacey/react-universal-component to achieve SSR + Code Split. I can say that its really easy to do it with it. Just follow their demo.
The thing is that it still doesnt play super nice with RR4 (Which seems to be the standard 🤔 ) because of store and history syncing, but they also have https://github.com/faceyspacey/redux-first-router which works with it.
Basically they have a whole stack of projects intended for all of this.
What do you guys think? Or do we have some progress on this?

@slavab89 I'm still on my spike branch based off this one https://github.com/reactGo/reactGo/compare/master...choonkending:react-router-4-clean which I think has an acceptable solution to rr4, but without code splitting yet. I was thinking that could be tackled once we have a solution for this first! :D


Add a check for stabby lambda parameters parentheses.

Adds in a cop to catch cases like ->x,y,z { z + x + y } and correct them to ->(x,y,z) { z + x + y }. It can also be configured to perform the reverse, catch ->(x,y,z) { z + x + y } and correct to  ->x,y,z { z + x + y }.  Resolves issue #2036.

Rebased and updated.

You should also squash the two commits together, drop the . from the commit message's title and prefix the message with [Fix #2036] (as noted in CONTRIBUTING.md).

Squashed and updated.

:+1: Thanks!


DROP Benchmark metrics seem low

Hi, I ran
python3 tasks/drop_final.py \
  --run_zeroshot 1 \
  --run_fewshot 1 \
  --run_decomp 1 \
  --num_boost 3 \
  --k_shot 3 \
  --output_metrics_file ../ama_logs/metrics.json \
  --cache_connection ../ama_logs/manifest_cache.sqlite \
  --save_dir ../ama_logs/ama_final_runs

and I see:
Accuracy Zero Shot 0.10691393700228803
Accuracy Few Shot 0.21785939533525883
Accuracy by Boost Set Decomposed [0.1622917936425949, 0.16476214293285982, 0.17488727059013848]
Accuracy by Boost Set Decomposed Average 0.1673137357218644
Accuracy Boost Decomposed 0.16522288996755874
Saved metrics to ../ama_logs/metrics.json
Saved final data to ../ama_logs/ama_final_runs/drop

This seems lower than the numbers in the paper, is that expected?

We have updated the datasets version to 1.4.0 in the requirements. Please see if this fixes your issue. Thanks!


Confirm scale and gain factor compensation bit depths for Neuropixels headstage

@jonnew I found the following notes on an old repo clone and just wanted to make sure we ended up doing this correctly. Feel free to close if these have all been addressed.
// we want to read the config file
// - S16 (signed) word truncation after applying scale / gain factors (should we just truncate?)
// - we will try to preserve some significant
// bit-depths:
//   - NPX v1: 10-bit AP and LP streams
//   - NPX v2 beta: 14-bit
//   - NPX v2 final: 12-bit

@bparks13 Can you have a look at these scale factors when you have a moment and compare to those in the OE gui to ensure we are doing the same thing?

One other thing to note is that 2.0 beta probes have a fixed gain of 80, versus 100 for the commercial probes.

@jonnew @glopesdev  I found a few discrepancies between the OE GUI implementation and the refactor.
Neuropixels V1

OE GUI

10-bit scaling (dividing by 1024)
Per channel gain correction

Onix-refactor

No bit scaling is applied that I can see
No gain correction applied, but ap/lfp gain are available in the method call

Neuropixels V2 Beta

OE GUI

14 bit scaling
Gain correction of 80

Onix-refactor

Bit scaling is 14 bits
Gain correction is read from a file

Neuropixels V2

OE GUI

12 bit scaling
Gain correction of 100

Onix-refactor

Bit scaling is set to 14 bits
Gain correction is read from a file

Thanks Brandon. Yeah -- the gain correction is done on the hardware (fixed point multiplication) in the IMEC system.
This is helpful, thank you.


Support multiprocessing for backgrounditerable to mitigate TensorStore crash

Both @Helw150 and I have observed a crash when resuming from a checkpoint. I'm pretty sure it's a race or similar in tensorstore b/c checkpointing and dataloader use TS.


Update URL for FCC Geocoding

The FCC geocoding API has changed. The old URL is not working. This PR updates to the new URL. Here are the new API docs:
https://geo.fcc.gov/api/census/#!/block/get_block_find

Coverage decreased (-0.9%) to 95.455% when pulling f693d5c7848dda10d37c1ff12a9ce0ea1c4dd173 on bedsider-org:new-fcc-api-url into 4c4276be011a9817ff643eec8ec295d40d9b88ab on geokit:master.

Thanks @winstonwolff - You'll need to delete the VCR cassettes (they "record" the web transactions from the code which will be the previous API) and run them again to get the tests working.
Basically delete any ".yml" files with the url URL in them and run the tests again, commit the changed ".yml" cassette files and it should all be good for me to merge.

I assume you mean I need to delete fixtures/vcr_cassettes/fcc_reverse_geocode.yml and re-run the tests to regenerate a YML file?
How do I run tests locally?
—Winston
[ Winston Wolff  •<PHONE_NUMBER>  •  www.stratolab.com ]

On Jun 6, 2018, at 15:55, Michael Noack<EMAIL_ADDRESS>wrote:
Thanks @winstonwolff - You'll need to delete the VCR cassettes (they "record" the web transactions from the code which will be the previous API) and run them again to get the tests working.
Basically delete any ".yml" files with the url URL in them and run the tests again, commit the changed ".yml" cassette files and it should all be good for me to merge.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

Yes. bundle exec rake test

Awesome @winstonwolff


Update README.md

Fix the Full workflow with uploading binaries to branch example. Add the 4th argument to run command in the Push binary to data branch step. If copied as it is, it causes the IndexOutOfRange Error.

Thank you for your contribution!


ERROR deprecated: data.GetJSON was deprecated in Hugo v0.123.0 and will be removed in Hugo 0.136.0. use resources .Get or resources.GetRemote with transform.Unmarshal.

Describe the bug
Unable to start the website locally due to this error
ERROR deprecated: data.GetJSON was deprecated in Hugo v0.123.0 and will be removed in Hugo 0.136.0. use resources
.Get or resources.GetRemote with transform.Unmarshal.
To Reproduce
Steps to reproduce the behavior:
Execute this command - hugo server
Expected behavior
Run the website
Desktop (please complete the following information):

OS: Arch Linux
Browser: Firefox

Hugo & Blowfish versions
Hugo v0.135.0+extended
Blowfish v2.77.1
Additional context
Add any other context about the problem here.

Do you have any additional themes/shortcodes that use getJSON? Blowfish hasn't used getJSON in a good while

No, I am not using additional themes or shortcodes, only from Blowfish documentation.


same test called twice?

Hielo Josh, please verify:
the getPort() method internally calls ::hasStandardPort(). It returns null for standard port/scheme combination. I think we just need to check for non null port values here.

Correct, the check is left from an earlier version of the psr-7 I guess.

I think not want add the port if the port is standard, in your case you add in any case the port.

@namaless I agree the port should not be included if default, as also stated in the psr-7 specs, but the default port check happens withing the getPort() method now.


Compile for browser and use RequireJS

Hi there,
I had a go at issue https://github.com/buzz-js/lsdb/issues/11. Compiling with module: amd and use RequireJS seems to work. I tested the example page on Safari and Chrome – seems to be working fine, no errors in the console.
Hope this helps. Cheers!

@dekpient  Hey, thank you very much for your contribution I have tried it and it works

@all-contributors please add @dekpient for infrastructure and code


Issue 567

@gruppin @tomers  can you please approve?

@yaelal - can you please next time add a label for the branch name and PR? for example issue_567_hod_hasharon_trees. Thank you so much


ONNX Runtime Session Defaults Discrepancy

In the definition of get_onnx_runtime_sessions, we have n_threads: int = 4,. In the docstring, it says n_threads (int) :  Sets the number of threads used to parallelize the execution within nodes. Default is 0 to let onnxruntime choose
Is there a reason that n_threads defaults to 4?

sorry for the late response,
if we set it to 0, we let onnxruntime choose the number of threads.
while testing, I found in some cases I got good results with n_threads=4. you can experiment with this number if you get better results keep it or you can let onnxruntime choose.


Log progress of operations

There are several scenarios when it's useful to log the progress of an operation:

In CLI mode, for long operations it's useful to show a progress bar so the user understand what he is waiting for and how much time it's expected to take. For this scenario it would help to integrate with something like tqdm.
For some very long operations like model training or data processing jobs that can last even few days, it can be helpful to be able to checkout the progress of an operation while it's still running. This can be achieved by having an operation per batch of work, but it might be better to have this baked into the framework somehow

Solved by linked PR #6 .
For docs:
https://oribarilan.github.io/oplog/tutorial/progressable_operations/


Fixed bug in PolyAnnotator

[x] Fixed https://github.com/pyviz/EarthSim/issues/192

I'll add fix this in a cleaner way eventually but for now this is ready to merge.


Add Assignees automatically when someone creates PR

Description
Currently in the gluesql when the PR is created by someone - let say Bob, then gluesql maintainers manually assign the Bob as Assignees section - which is quite cumbersome. So it is good to let bot add assignees. I remember there was a github action which exactly supports this.

yes i have idea on this we can do this in settings in codeowners part .
in project setting we can add codeowners and in branch setting we tick that codeowners

yes i have idea on this we can do this in settings in codeowners part . in project setting we can add codeowners and in branch setting we tick that codeowners. As i can't able to see settings near repo because i don't have access

Ah, thank you for the comment. As I understand what you are talking about is CODEOWNER. When we set the CODEOWNER then the person who has a responsibility about specified path in CODEOWNER file will be added as reviewer automatically.
What I want to do is to add pr writer automatically as Assignees - see the image below. So it's quite different I think

Can I work on this issue? Kindly assign it to me!


Add fields sections

Idea for improvement: Add the possibility to group fields into differents sections with description which would allow us to give a more presentable display to the final customer. Depending on the blocks created, there may be quite a few fields to create and the configuration panel gradually becomes unreadable. The differents sections would have a visual distinction like larger margins, top and bottom borders, larger size for the section title
Ex:
Group 1 : Image
Description : This section allow you to configure the image and all attributes related.

Field 1 : Image
Field 2 : Legend
Field 3 : Loading
Field 4 : Size

Group 2 : Link
Description : This section allow you to configure the link below the image.

Field 1 : Link name
Field 2 : Link
Field 3 : Target
Field 4 : Color
Field 5 : Size

etc.

Hi, we will do that for the V 4


[improvement] Move Waypoint to a higher order component approach

Hello.
I fork Waypoint and reimplemented it like a higher order component.
Now I cant use this way, Ex.
const Comp = (props) => (

     <Child1/>
     <Child2/>
     <Child3/>

);

const Scroller = waypoint(Comp);

const ScrollerPage  = () => (

      <Scroller
        onEnter={() => console.log('enter Comp')}
        onLeave={() => console.log('leave Comp')}
      />

);

I add only:
      const nodeHeight = this._DOMNode.getBoundingClientRect().height;
      .
      .
      if (contextScrollTop <= waypointTop + nodeHeight + thresholdPx &&
        waypointTop - thresholdPx <= contextBottom) {
        return Waypoint.inside;
      }

to _currentPosition()
Is working good on a internal project.
Please tell me if looks good and will make a PR.
Fork repo on this link: https://github.com/bySabi/react-waypoint
Thanks for your hard works on this.

Interesting approach @bySabi. Just to see if I'm understanding correctly, would this be equivalent to placing the waypoint after all children in the Comp example?
const Comp = (props) => (

     <Child1/>
     <Child2/>
     <Child3/>
    <Waypoint ... />

);

While I'm personally a fan of HOC, I'm not sure it's the right tool for the job here. Personally, I think that allowing a waypoint to take children is a more straight-forward approach to solving what you are trying to do with the HOC.
const Comp = (props) => (
  <Waypoint ...>
     <Child1/>
     <Child2/>
     <Child3/>
 </Waypoint>
);

This is discussed in length over at https://github.com/brigade/react-waypoint/pull/41. Basically, I'm open to such an addition, but only if we change callback triggering to take the height into account. I.e. onEnter should only fire once the entire element is visible, and onLeave should only fire once the entire component has left the viewport. Taking an arbitrary tall element into account opens up for some tricky edge-cases that we've been avoiding so far. For instance, what happens if the wrapped content is taller than the screen? Should the onEnter callback get fired or not?

In this case HOC and children aproach bring a similar solution for same "issue?".
I agree on all the points you mentioned. At what point fire Enter/Leave on wrapped components don´t have a clear answer.
Make waypoint 0px is a salomonic decision. But put two Waypoint listeners at component edge could have performance penalty, don´t you think?

Performance might be an issue, but it's just speculation. We would have to profile the code in order to answer that question. At brigade.com, we have 20+ waypoints on some pages, and there's little to no experienced lag there.
Can you explain what you mean by salomonic? (It's a word I don't understand, and English isn't my first language).

Sorry! is a typo, is solomonic from Solomon (https://en.wikipedia.org/wiki/Judgment_of_Solomon) :-)
Right!, modern browser probably handle many event listeners without hastle.
Even so IMO waypoint must have a more room for developer experimentation. I like HOC cause Waypoint component remain the same and now have a functional scroll spy behaviour to attach to any component.
We only need figure out the correct API for express at what point on the ancestor-component relation we must fire callbacks.
Any  suggestion about?
Maybe fire callbacks must be parameterized relate to Wrapped Component center line. I working on this right now :-)
Any  suggestion about?
Maybe fire callbacks must be parameterized relate to Wrapped Component center line. I working on this right now :-)

Most HOC that I've seen pass in some prop to the child they're wrapping. In your example the child isn't benefitting from being wrapped, that's why I think a regular children approach is more straightforward.
I think the power of Waypoint in its current form is that it's simple enough while still allowing it to be flexible enough to support a multitude of use-cases.
As for when callbacks need to be fired when wrapping children is up to you to figure out based on your use-case. The center line is an interesting idea, and maybe that's what we should aim for!

Hi @trotzig actually this is my only one HOC that no pass nothig. Probably I thought, if children are not 0px anymore wayPOINT semantically not fit at all.
I make a new PR to my fork on function _currentPosition.
This change take into account the 'children' height and determine where is it above, inside or below of "visible area" comparing agains children height middle point.
If waypoint children height is less than half of "visible area" all full children must be inside this area to return Waypoint.inside
If waypoint children height is greater than half of "visible are" children will be 'inside' when her top point (waypointTop) reach the center point of "visible are". This cover the case when children size it is bigger than container.
This need a future refactor but it is working.
Just want to know is _currentPosition changes are ok for waypoint team before make a PR.

Just to better understand why you need this, can you explain your use-case a little?

I have multiple components of this type:
import React from "react";
import classNames from "classnames";
import { mediaQuery } from "react-media-query";
import { mdUp } from "react-media-query/lib/bootstrap4-media-query";
import { waypoint } from "react-waypoint";

...
const Code = waypoint(props => (

    {sampleCode}

));
...
const SampleCode = mediaQuery(class SampleCode extends React.Component {
   onEnter = () => {/* onEnter code */};
   onLeave = () => {/* onLeave code */};

   render() {
     const mediumUp = this.props.md.mdUp ? 'hidden' : 'show';
     const _className = classNames(this.props.className, mediumUp);

     return
   }
}, { mdUp });

...
const App = props => {
  ...

  <SampleCode className="main app sample1" />

  ...

  <SampleCode className="main app sample2" />

  ...

  <SampleCode className="main app sample3" />

  ...
}

If I were to build this module with current Waypoint component it will look like this.
const waypoint = C => {
  return function _waypoint(props) {
    const { onEnter, onLeave, ..._props } = props;
    return (

        <Waypoint onEnter={onEnter}/>
        <C {..._props}/>
        <Waypoint onLeave={onLeave}/>

    );
  }
}

...
const Code = waypoint(props => (

    {sampleCode}

);
...

With current Waypoint component, waypoint hoc:

Will need 2 additional tags "span" and one container "div"
Each Waypoint need custom threashold´s for callback fire when wrapped component enter on viewport zone.

I agree that Waypoint is powerful on his simplicity and cover a majority of use cases but sometimes many developers feel a little more is needed, #41, #87
Proposed HOC don´t touch current Waypoint behaviour, just make it more composable and component aware.
Before this I was looking for a scrollSpy solution and even wrote my self that create a only one event listener with function throttle, but eventually I move to Waypoint due to his simple, clean and tested code.
I take quite some time looking at Waypoint code just to make sure if this really add some improvement.

Thanks for providing that example. I'm a little confused though, because the HOC you've implemented doesn't seem to support your use-case where you have two waypoints (one above and one below).
I've seen the issue of allowing children come up a few times, and I think the most useful addition we could make to waypoint at this time is to allow children to be passed in, and take the height of the element into account when calculating its position. That seems like it would help the use-case your explaining as well (with the two waypoints surrounding an element). The centering-approach you've taken in the HOC is interesting as well but I don't think that behavior is what most people would expect from a children-aware waypoint. And I still don't see a strong use-case for it.

children approach is fine too :-)
How you will handle the case when element height is more bigger than scrollable ancestor?

Yeah, I don't know, it's tricky. I don't have a clear use-case in mind, but here's what I think we could do:

Trigger onEnter when the bottom edge is visible (when scrolling down) or the top edge is visible (when scrolling up).
Trigger onLeave when the bottom edge leaves the screen (when scrolling up) or the top edge leaves the screen (when scrolling down)

With this approach, we don't have to worry about how tall the waypoint element is. Though I don't know if it satisfies your needs. We could also consider this approach:

Trigger onEnter when the both edges (top, bottom) are on screen
Trigger onLeave when the both edges are off-screen

With this approach, there's a chance that the waypoint never fires onEnter, despite being clearly visible on the screen (because it's too tall).
A third approach is the one you explored with your HOC: making the waypoint trigger on the center point of the element. This approach doesn't suffer from the height issue either.
Again, you're in best position to decide what approach will fit your use-case best. We can perhaps ask @khankuan and @Sicria for input, since they've shown an interest in the children-approach too.

Hi @trotzig
Actually my implementation don´t trigger on center point of element, it just use element middle point for recalculate context scroll area.
Is like second approach you describe, onEnter only will fire if both edges are on screen.
But if element height is more bigger than half of the context height:

onEnter will fire when element top reach context center point
onLeave will fire when element bottom is leave context center point.

Behaviour on big elements is a litte 'cosmetic', visually speaking.
My use-case is, probably, avoid where ever I can adjust fire callbacks with threshold hardcoded values.
I´m with you," is really tricky!"
Lets see what others developers think.
Thanks for take time to anwser here.

Hope i can contribute some thoughts :) I like the idea of thinking about the problem as having 2 waypoints. Thus, the permutations of events are essentially { enter/leave, above/below, top-edge/bottom-edge }. The library current has onEnter and onLeave callbacks.

We could add more params to the callbacks, perhaps something like topEdge=true, bottomEdge=true and for Waypoints that does not have height, we can set both values to true.

We can add new props onTopEnter, onBottomEnter, onTopLeave, onBottomLeave. These are triggered together with onEnter and onLeave and it is the choice of user to decide to go with something broader like onEnter or something more specific like onTopEnter.

Personally i feel that 2) is nicer so that the jsx itself is more declarative and the reader do not have to dig into the handler method to figure out both cases.
In reference to the children method, i'm assuming that topEdge refers to the top of first child while bottomEdge refers to the bottom of the last child.

@trotzig @khankuan I revert _currentPosition function  to original. Not more tricky behaviour based on element height size, is 0px again. But I think is useful know some DOM info like waypointTop and contextScroll top and height.
This way I can customize components behaviour based on this DOM values, Ex:

trigger animations when waypointTop is on the middle  of  viewport .

Is this changes fit on waypoint 'way' I will make a PR, please review it.
https://github.com/bySabi/react-waypoint/blob/master/src/waypoint-hoc.jsx#L178
Probably function name and vars need a litte refactoring

commited another change to my fork. HOC pass prop _scrolled to wrapped components. This become react-waypoint a real scrollspy.
Maybe this time HOC approach is justified :-)

I'm not sure I'm following along now... Can you point me to a few commits so that it's easier to see the changes you are introducing?

OK.

Latest commit https://github.com/bySabi/react-waypoint/commit/142c63baa9abbeed63c4cd6905aa185e3e27541e  seens works fine.
But need some 'specs' changes to reflex new API. Example of test fails ...
Expected spy onEnter to have been called with [ Object({ currentPosition: 'inside', previousPosition: null, event: null }) ] but actual calls were [ Object({ waypointTop: 98, contextHeight: 100, contextScrollTop: 8, currentPosition: 'inside', previousPosition: null, event: null }) ].
	    at Object.<anonymous> (/Users/flx/Dropbox/WIP/react-waypoint/tests.webpack.js:155:36)

Latest commit https://github.com/bySabi/react-waypoint/commit/50edd4545cba519445d54693e1f1d8bc9f507007#diff-159cb00bc1cbdf438aa0985561f6d9c1R1 add throttle handleScroll options. Recommended for performace tweaks.

Latest commit bySabi@50edd45#diff-159cb00bc1cbdf438aa0985561f6d9c1R1 add throttle handleScroll options. Recommended for performace tweaks.

@bySabi rather than referencing commits here, it might be easier for folks to follow along if you open a PR, and we track the progress there.
I'm :+1: to the idea of allowing a Waypoint to have children, and taking the height of the element into consideration. If there's anything I can do to help out with that effort, let me know.

@jmeas my fork is almost ready but I can´t make a PR cause 'test' are not finnished, not time and Jasmine knowledge. Maybe you can helpe me in that apart.
I don´t think take height into account is a good idea after all. Is not a good idea on Waypoint code but is a must on some use-case, that´s why my current fork encourage waypoint higher-order component. This way ensure waypoint remain 'generic' but some use-case build on top of it.
I have been working on a scrollspy HOC build on top of waypoint HOC for easy build use-cases: sticky header, sticky footer, animate on reach viewport center, any behaviour you could imagine. Is not published yet but I can if someone request it.
I found a use-case that I think is tricky to solved with current Waypoint without a bit of hacky:
A Waypoint below a component with a big background image that push sibling components out of viewport. In that case you must scroll to reach Waypoint onEnter point, this´s expected behaviour but on initial render sibling top component background is not take into account then Waypoint sit on viewport and onEnter get fired. Already mentioned scrollspy HOC eat this undesired case transparently to wrapped component.
If anyone have any question about this proposal and implementation don´t hesitate to ask.

Created PR: https://github.com/brigade/react-waypoint/pull/92

@trotzig what you think about my current fork: https://github.com/bySabi/react-waypoint-hoc ?
I´m planning a PR with it but I not sure is react-waypoint team want  follow the path of  the generic scroll handler and make Waypoint a use-case of it.
If the team decide follow this path would be with HOC or children approach??

created v3 branch PR https://github.com/brigade/react-waypoint/pull/105


Reduce flake8 max-line-length 152-151

Description
I reduced flake8 max-line-length from 152  to 151.
Changed Behaviour
Which existing user workflows or functionality will behave differently after this PR?
Fixes
Fixes # (issue)
Type of change
Choose which options apply, and delete the ones which do not apply.

Bug fix
New feature
Update to human readable text: Documentation/error messages/comments
Code maintenance/cleanup

This failed in testing with this error:
parsl/monitoring/db_manager.py:522:93: E999 SyntaxError: EOL while scanning string literal

I think you should also get that error in your development environment when you run make flake8 there.
Its basically saying you've got something wrong with the syntax in the change you made in db_manager.py

make: *** No rule to make target 'flake8'.  Stop.
this is the error message i get when i run make flake8

This error is happening in CI:
parsl/monitoring/db_manager.py:524:45: E123 closing bracket does not match indentation of opening bracket's line
Do you get that on your local make flake8 too?

This error is happening in CI:
parsl/monitoring/db_manager.py:524:45: E123 closing bracket does not match indentation of opening bracket's line
Do you get that on your local make flake8 too?

This is the output I get when I run make flake 8
output flake8 parsl/

I think I may have broken things here, I am unsure. I created another PR with the current repository on another branch just in case. Thank you for the reviews


Allow multiple search results to be shown on map at once

Is your feature request related to a problem? Please describe.
Currently, only one search result is shown on the map at a time.
Describe the solution you'd like
Allow a configurable way to allow multiple search results to be shown

Closed in #90


Remove :expr from placeholders

Reasoning discussed at https://github.com/rust-analyzer/rust-analyzer/issues/3186#issuecomment-644069324

bors r+


fix: TypeError when pushing

Keep in mind that I have never wrote a single line of JavaScript/TypeScript. Not sure if this is a viable solution, but it works for me.
nix path-info --all --json returns a JSON object, with the keys being Nix store paths and the values being extra information associated with that Nix store path. I replaced the .map (on an object instead of an array, hence the error) with Object.keys() to get the store paths only.
Closes #17.

see my comment in the issue. this breaks the action when running the current stable nix from nixpkgs-unstable, so i would recommend keeping the current implementation for backwards compatibility sake

Added a check to see if it is an array (old Nix 2.18 output) and use the old method

@getchoo could we get this merged please?

thanks


How to customize and expand the ControlBar

I would like to know if there is an API for customizing ControlBar and its deletion events?

The pro version supports the external control bar: https://nocode-js.com/docs/sequential-workflow-designer/features/external-control-bar So basically you may hide the default one and create your own.


Clean up the test code of substring kernel.

Signed-off-by: remzi<EMAIL_ADDRESS>Which issue does this PR close?
Closes #1801.
Rationale for this change
Avoid repeated code.
More readable.
Less code is better.
What changes are included in this PR?
Use macros.
Better format.
Are there any user-facing changes?
No.

Blocked by #1852

Codecov Report

Merging #1853 (68ce0bc) into master (c08e532) will decrease coverage by 0.04%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #1853      +/-   ##
==========================================
- Coverage   83.49%   83.45%   -0.05%
==========================================
  Files         201      201
  Lines       56903    56745     -158
==========================================
- Hits        47511    47354     -157
+ Misses       9392     9391       -1

Impacted Files
Coverage Δ

arrow/src/compute/kernels/substring.rs
99.37% <100.00%> (-0.16%)
:arrow_down:

arrow/src/buffer/ops.rs
96.77% <0.00%> (ø)

parquet/src/arrow/mod.rs
44.44% <0.00%> (ø)

parquet_derive/src/parquet_field.rs
65.75% <0.00%> (ø)

parquet/src/arrow/array_reader.rs

...arquet/src/arrow/array_reader/dictionary_buffer.rs

parquet/src/arrow/converter.rs

parquet/src/arrow/record_reader.rs

parquet/src/arrow/array_reader/offset_buffer.rs

parquet/src/arrow/levels.rs

... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c08e532...68ce0bc. Read the comment docs.

Sorry for the delay, I'll try to get to this later today if nobody else does, I'm currently on holiday and reviewing large PRs like this on a phone is challenging 😅

Never mind. Have a good holiday! 🏝


(feat) 003: React module content

How about adding other features like context, portal, refs etc.?

How about adding other features like context, portal, refs etc.?

@unfalse  I think we don't need to cover such topics in basic react module, we can leave links to resources in materials


Not able to produce good quality reconstructions when enforcing normal loss on RGBD data

Hello!
Thank you for releasing this amazing codebase!
I wanted to try enforcing normal loss on an RGB-D dataset. To do this, I did the following:

I generated normals from the Omnidata model, and prepared the .npy files as necessary.
Since we have depth from the dataset, I discarded the predicted depth from the Omnidata model and only used the sensor depth for enforcing depth consistency in the loss ( I therefore set --pipeline.model.mono-depth-loss-mult 0).
I resized the depth images to be the same size as the output of the OmniData model. I got a shape mismatch after about 4800 training steps if I didn't do this.
I used the NeuS backbone with RGB-D data from synthetic neural-RGBD dataset - similar to the example provided in the docs
I trained this with 2048 rays / batch. The full command I used was as follows:

ns-train neus --pipeline.model.sdf-field.use-grid-feature True --trainer.steps_per_save=10000 --pipeline.model.sdf-field.hidden-dim 256 --pipeline.model.sdf-field.num-layers 2 --pipeline.model.sdf-field.num-layers-color 2 --pipeline.model.sdf-field.use-appearance-embedding True --pipeline.model.sdf-field.geometric-init True --pipeline.model.sdf-field.inside-outside True  --pipeline.model.sdf-field.bias 0.8 --pipeline.model.sdf-field.beta-init 0.3 --pipeline.datamanager.train-num-images-to-sample-from -1 --trainer.steps-per-eval-image 5000 --pipeline.model.background-model none --vis wandb --experiment-name with_normals_depth --pipeline.model.sensor-depth-l1-loss-mult 0.1 --pipeline.model.sensor-depth-freespace-loss-mult 10.0 --pipeline.model.sensor-depth-sdf-loss-mult 6000.0 --pipeline.model.mono-normal-loss-mult 0.05 --pipeline.model.mono-depth-loss-mult 0 --pipeline.datamanager.train-num-rays-per-batch 2048 --machine.num-gpus 1 sdfstudio-data --data data/custom/neural_rgbd_normals --include_sensor_depth True --include_mono_prior True --skip_every_for_val_split 30

The training curves are as follows:

I thought that enforcing normal consistency might improve results in large regions with less texture. However, the results I got without it looks much better. Here is an example for the kitchen scene - on the left is an image with normal loss enforced and on the right is without it. All other parameters are the same.

Any thoughts on what I could be doing wrong?

@kaushikbalasundar Maybe the normal from omnidata is noise? Could you try to set different weights for the normal loss and check what happens? And maybe also disable sensor depth loss and compare it to using normal loss only?

Hi, guys, can I ask that why I cannot find the rgbd dataset given that I have already downloaded it?

ns-download-data sdfstudio --dataset-name neural-rgbd-data

Hi, guys, can I ask that why I cannot find the rgbd dataset given that I have already downloaded it?

ns-download-data sdfstudio --dataset-name neural-rgbd-data

My bad, I forgot to convert the downloaded dataset to SDFStudio format


Introduce micrometer metrics

This allows us to record metrics like execution durations for certain methods during runtime simply by attaching a @Timed annotation to the method. To achieve this, AspectJ is introduced which, when loaded as a java agent, modifies the byte code of such methods to enable the recording of timing data. The recorded data can then be accessed via the /prometheusMetricsendpoint on the admin port.
This can be used to identify bottlenecks in our application and also to track how much certain changes affect our performance.
Currently, the execution duration of all endpoints and some additional methods (where slow durations are suspected) are recorded.
How to use
To enable this functionality, the java agent aspectjweaver, which is included in the org.aspectj.aspectjweaver.<version> dependency, needs to be attached when starting Velcom. The java agent has to be specified as a vm argument like so:
-javaagent:"../.m2/repository/org/aspectj/aspectjweaver/1.9.6/aspectjweaver-1.9.6.jar"
Potential problems
Since AspectJ is modifying byte code during runtime, exception stack traces are no longer accurate. To identify the exact line that caused an exception, the java agent must be ommited from the vm arguments.
TODO

[x] Check every changed file if the old codehale metrics are still used somewhere
[x] Merge main into metrics to resolve merge conflicts
[x] Also record micrometer metrics like

ClassLoaderMetrics
JvmMemoryMetrics
JvmGcMetrics
ProcessorMetrics
JvmThreadMetrics
ExecutorServiceMetrics
JvmCompilationMetrics (maybe?)
JvmHeapPressureMetrics

We should also figure out how to properly bundle and attach the agent in the Docker image that the velcom CI instance runs. I will have a stab at that.


Update build.gradle with reactivx dependency.

For some reason I needed to add this reactivex dependency to get compilation to succeed. Perhaps a downstream dependency changed?

It's not on the main branch: https://github.com/TheoKanning/openai-java/blob/main/example/build.gradle

Ahh, sorry, I see it's getting loaded as a dependency now. BTW ./gradlew javadoc fails because example/src/main/java/example/OpenAiApiExample.java isn't public, so javadoc has nothing to do. Dunno if you care, I made it public so I could generate javadoc without the error message.


"jboss.module.resolve.phase.\"deployment.as1605-usecase2.war\".main.1 is missing [jboss.module.spec.service.\"deployment.arquillian-service\".main]"
    ]

org.jboss.as.test.integration.ws.ejb.EJBWebServicesTestCase: 	at org.jboss.as.arquillian.container.ArchiveDeployer.deployInternal(ArchiveDeployer.java:184)
	at org.jboss.as.arquillian.container.ArchiveDeployer.deployInternal(ArchiveDeployer.java:162)
	at org.jboss.as.arquillian.container.ArchiveDeployer.deploy(ArchiveDeployer.java:91)
	at org.jboss.as.arquillian.container.CommonDeployableContainer.deploy(CommonDeployableContainer.java:255)
------- Stdout: -------
 [0m09:12:40,814 INFO  [org.jboss.as.repository] (management-handler-thread - 1) WFLYDR0001: Content added at location /store/work/tc-work/37b47ae8b9c60325/full/testsuite/integration/ws/target/wildfly/standalone/data/content/6a/69ca26b6d83e2f449d30b3e18a56d91975c44e/content
 [0m [0m09:12:40,816 INFO  [org.jboss.as.server.deployment] (MSC service thread 1-5) WFLYSRV0027: Starting deployment of "arquillian-service" (runtime-name: "arquillian-service")
 [0m [31m09:12:40,879 ERROR [org.jboss.msc.service.fail] (MSC service thread 1-2) MSC000001: Failed to start service jboss.deployment.unit.arquillian-service.PARSE: org.jboss.msc.service.StartException in service jboss.deployment.unit.arquillian-service.PARSE: WFLYSRV0153: Failed to process phase PARSE of deployment "arquillian-service"
	at org.jboss.as.server.deployment.DeploymentUnitPhaseService.start(DeploymentUnitPhaseService.java:189)
	at org.jboss.msc.service.ServiceControllerImpl$StartTask.startService(ServiceControllerImpl.java:1739)
	at org.jboss.msc.service.ServiceControllerImpl$StartTask.execute(ServiceControllerImpl.java:1701)
	at org.jboss.msc.service.ServiceControllerImpl$ControllerTask.run(ServiceControllerImpl.java:1559)
	at org.jboss.threads.ContextClassLoaderSavingRunnable.run(ContextClassLoaderSavingRunnable.java:35)
	at org.jboss.threads.EnhancedQueueExecutor.safeRun(EnhancedQueueExecutor.java:1990)
	at org.jboss.threads.EnhancedQueueExecutor$ThreadBody.doRunTask(EnhancedQueueExecutor.java:1486)
	at org.jboss.threads.EnhancedQueueExecutor$ThreadBody.run(EnhancedQueueExecutor.java:1377)
	at java.lang.Thread.run(Thread.java:748)
Caused by: java.lang.NoClassDefFoundError: org/xnio/IoUtils
	at org.wildfly.extension.security.manager.deployment.PermissionsParserProcessor.parsePermissions(PermissionsParserProcessor.java:173)
	at org.wildfly.extension.security.manager.deployment.PermissionsParserProcessor.deploy(PermissionsParserProcessor.java:119)
	at org.jboss.as.server.deployment.DeploymentUnitPhaseService.start(DeploymentUnitPhaseService.java:182)
	... 8 more

 [0m [31m09:12:40,880 ERROR [org.jboss.as.controller.management-operation] (management-handler-thread - 1) WFLYCTL0013: Operation ("add") failed - address: ([("deployment" => "arquillian-service")]) - failure description: {"WFLYCTL0080: Failed services" => {"jboss.deployment.unit.arquillian-service.PARSE" => "WFLYSRV0153: Failed to process phase PARSE of deployment \"arquillian-service\"
    Caused by: java.lang.NoClassDefFoundError: org/xnio/IoUtils"}}
 [0m [31m09:12:40,881 ERROR [org.jboss.as.controller.management-operation] (management-handler-thread - 1) WFLYCTL0013: Operation ("add") failed - address: ([("deployment" => "arquillian-service")]) - failure description: {"WFLYCTL0080: Failed services" => {"jboss.deployment.unit.arquillian-service.PARSE" => "WFLYSRV0153: Failed to process phase PARSE of deployment \"arquillian-service\"
    Caused by: java.lang.NoClassDefFoundError: org/xnio/IoUtils"}}
 [0m [31m09:12:40,881 ERROR [org.jboss.as.server] (management-handler-thread - 1) WFLYSRV0021: Deploy of deployment "arquillian-service" was rolled back with the following failure message:
{"WFLYCTL0080: Failed services" => {"jboss.deployment.unit.arquillian-service.PARSE" => "WFLYSRV0153: Failed to process phase PARSE of deployment \"arquillian-service\"
    Caused by: java.lang.NoClassDefFoundError: org/xnio/IoUtils"}}
 [0m [0m09:12:40,882 INFO  [org.jboss.as.server.deployment] (MSC service thread 1-7) WFLYSRV0028: Stopped deployment arquillian-service (runtime-name: arquillian-service) in 0ms
 [0m [0m09:12:40,892 INFO  [org.jboss.as.repository] (management-handler-thread - 1) WFLYDR0001: Content added at location /store/work/tc-work/37b47ae8b9c60325/full/testsuite/integration/ws/target/wildfly/standalone/data/content/53/1ade3194a61e433185edb00d20e05db0307cb0/content
 [0m [0m09:12:40,893 INFO  [org.jboss.as.server.deployment] (MSC service thread 1-5) WFLYSRV0027: Starting deployment of "ejbws-example.jar" (runtime-name: "ejbws-example.jar")
 [0m [31m09:12:40,911 ERROR [org.jboss.as.controller.management-operation] (management-handler-thread - 1) WFLYCTL0013: Operation ("add") failed - address: ([("deployment" => "ejbws-example.jar")]) - failure description: {
    "WFLYCTL0412: Required services that are not installed:" => [
        "jboss.module.spec.service.\"deployment.arquillian-service\".main",
        "module.resolved.service.\"deployment.ejbws-example.jar\".main"
    ],
    "WFLYCTL0180: Services with missing/unavailable dependencies" => [
        "jboss.module.resolve.phase.\"deployment.ejbws-example.jar\".main.1 is missing [jboss.module.spec.service.\"deployment.arquillian-service\".main]",
        "jboss.module.service.\"deployment.ejbws-example.jar\".main is missing [module.resolved.service.\"deployment.ejbws-example.jar\".main]"
    ]
}
 [0m [31m09:12:40,913 ERROR [org.jboss.as.controller.management-operation] (management-handler-thread - 1) WFLYCTL0013: Operation ("add") failed - address: ([("deployment" => "ejbws-example.jar")]) - failure description: {
    "WFLYCTL0412: Required services that are not installed:" => [
        "jboss.module.spec.service.\"deployment.arquillian-service\".main",
        "module.resolved.service.\"deployment.ejbws-example.jar\".main"
    ],
    "WFLYCTL0180: Services with missing/unavailable dependencies" => [
        "jboss.module.resolve.phase.\"deployment.ejbws-example.jar\".main.1 is missing [jboss.module.spec.service.\"deployment.arquillian-service\".main]",
        "jboss.module.service.\"deployment.ejbws-example.jar\".main is missing [module.resolved.service.\"deployment.ejbws-example.jar\".main]"

org.jboss.as.test.integration.ws.injection.ejb.as1675.AS1675TestCase: 	at org.jboss.as.arquillian.container.ArchiveDeployer.deployInternal(ArchiveDeployer.java:184)
	at org.jboss.as.arquillian.container.ArchiveDeployer.deployInternal(ArchiveDeployer.java:162)
	at org.jboss.as.arquillian.container.ArchiveDeployer.deploy(ArchiveDeployer.java:91)
	at org.jboss.as.arquillian.container.CommonDeployableContainer.deploy(CommonDeployableContainer.java:255)
------- Stdout: -------
 [0m09:12:42,002 INFO  [org.jboss.as.server.deployment] (MSC service thread 1-1) WFLYSRV0027: Starting deployment of "arquillian-service" (runtime-name: "arquillian-service")
 [0m [31m09:12:42,061 ERROR [org.jboss.msc.service.fail] (MSC service thread 1-3) MSC000001: Failed to start service jboss.deployment.unit.arquillian-service.PARSE: org.jboss.msc.service.StartException in service jboss.deployment.unit.arquillian-service.PARSE: WFLYSRV0153: Failed to process phase PARSE of deployment "arquillian-service"
	at org.jboss.as.server.deployment.DeploymentUnitPhaseService.start(DeploymentUnitPhaseService.java:189)
	at org.jboss.msc.service.ServiceControllerImpl$StartTask.startService(ServiceControllerImpl.java:1739)
	at org.jboss.msc.service.ServiceControllerImpl$StartTask.execute(ServiceControllerImpl.java:1701)
	at org.jboss.msc.service.ServiceControllerImpl$ControllerTask.run(ServiceControllerImpl.java:1559)
	at org.jboss.threads.ContextClassLoaderSavingRunnable.run(ContextClassLoaderSavingRunnable.java:35)
	at org.jboss.threads.EnhancedQueueExecutor.safeRun(EnhancedQueueExecutor.java:1990)
	at org.jboss.threads.EnhancedQueueExecutor$ThreadBody.doRunTask(EnhancedQueueExecutor.java:1486)
	at org.jboss.threads.EnhancedQueueExecutor$ThreadBody.run(EnhancedQueueExecutor.java:1377)
	at java.lang.Thread.run(Thread.java:748)
Caused by: java.lang.NoClassDefFoundError: org/xnio/IoUtils
	at org.wildfly.extension.security.manager.deployment.PermissionsParserProcessor.parsePermissions(PermissionsParserProcessor.java:173)
	at org.wildfly.extension.security.manager.deployment.PermissionsParserProcessor.deploy(PermissionsParserProcessor.java:119)
	at org.jboss.as.server.deployment.DeploymentUnitPhaseService.start(DeploymentUnitPhaseService.java:182)
	... 8 more

 [0m [31m09:12:42,062 ERROR [org.jboss.as.controller.management-operation] (management-handler-thread - 1) WFLYCTL0013: Operation ("add") failed - address: ([("deployment" => "arquillian-service")]) - failure description: {"WFLYCTL0080: Failed services" => {"jboss.deployment.unit.arquillian-service.PARSE" => "WFLYSRV0153: Failed to process phase PARSE of deployment \"arquillian-service\"
    Caused by: java.lang.NoClassDefFoundError: org/xnio/IoUtils"}}
 [0m [31m09:12:42,062 ERROR [org.jboss.as.controller.management-operation] (management-handler-thread - 1) WFLYCTL0013: Operation ("add") failed - address: ([("deployment" => "arquillian-service")]) - failure description: {"WFLYCTL0080: Failed services" => {"jboss.deployment.unit.arquillian-service.PARSE" => "WFLYSRV0153: Failed to process phase PARSE of deployment \"arquillian-service\"
    Caused by: java.lang.NoClassDefFoundError: org/xnio/IoUtils"}}
 [0m [31m09:12:42,062 ERROR [org.jboss.as.server] (management-handler-thread - 1) WFLYSRV0021: Deploy of deployment "arquillian-service" was rolled back with the following failure message:
{"WFLYCTL0080: Failed services" => {"jboss.deployment.unit.arquillian-service.PARSE" => "WFLYSRV0153: Failed to process phase PARSE of deployment \"arquillian-service\"
    Caused by: java.lang.NoClassDefFoundError: org/xnio/IoUtils"}}
 [0m [0m09:12:42,063 INFO  [org.jboss.as.server.deployment] (MSC service thread 1-6) WFLYSRV0028: Stopped deployment arquillian-service (runtime-name: arquillian-service) in 0ms
 [0m [0m09:12:42,070 INFO  [org.jboss.as.repository] (management-handler-thread - 1) WFLYDR0001: Content added at location /store/work/tc-work/37b47ae8b9c60325/full/testsuite/integration/ws/target/wildfly/standalone/data/content/d9/0b57ef4a492c5e0218151dda5c7443ff059854/content
 [0m [0m09:12:42,071 INFO  [org.jboss.as.server.deployment] (MSC service thread 1-3) WFLYSRV0027: Starting deployment of "as1675.ear" (runtime-name: "as1675.ear")
 [0m [0m09:12:42,074 INFO  [org.jboss.as.server.deployment] (MSC service thread 1-1) WFLYSRV0207: Starting subdeployment (runtime-name: "shared.jar")
 [0m [0m09:12:42,075 INFO  [org.jboss.as.server.deployment] (MSC service thread 1-3) WFLYSRV0207: Starting subdeployment (runtime-name: "ejb3.jar")
 [0m [31m09:12:42,115 ERROR [org.jboss.as.controller.management-operation] (management-handler-thread - 1) WFLYCTL0013: Operation ("add") failed - address: ([("deployment" => "as1675.ear")]) - failure description: {
    "WFLYCTL0412: Required services that are not installed:" => [
        "module.resolved.service.\"deployment.as1675.ear\".main",
        "jboss.module.spec.service.\"deployment.arquillian-service\".main",
        "module.resolved.service.\"deployment.as1675.ear.ejb3.jar\".main",
        "module.resolved.service.\"deployment.as1675.ear.shared.jar\".main"
    ],
    "WFLYCTL0180: Services with missing/unavailable dependencies" => [
        "jboss.module.resolve.phase.\"deployment.as1675.ear.ejb3.jar\".main.1 is missing [jboss.module.spec.service.\"deployment.arquillian-service\".main]",
        "jboss.module.resolve.phase.\"deployment.as1675.ear\".main.1 is missing [jboss.module.spec.service.\"deployment.arquillian-service\".main]",
        "jboss.module.resolve.phase.\"deployment.as1675.ear.shared.jar\".main.1 is missing [jboss.module.spec.service.\"deployment.arquillian-service\".main]",
        "jboss.module.service.\"deployment.as1675.ear.shared.jar\".main is missing [module.resolved.service.\"deployment.as1675.ear.shared.jar\".main]",
        "jboss.module.service.\"deployment.as1675.ear.ejb3.jar\".main is missing [module.resolved.service.\"deployment.as1675.ear.ejb3.jar\".main]",
        "jboss.module.service.\"deployment.as1675.ear\".main is missing [module.resolved.service.\"deployment.as1675.ear\".main]"
    ]
}
 [0m [31m09:12:42,116 ERROR [org.jboss.as.controller.management-operation] (management-handler-thread - 1) WFLYCTL0013: Operation ("add") failed - address: ([("deployment" => "as1675.ear")]) - failure description: {

##### there are 1367 more failed tests, see build details


Update copy on new.html.erb

Removed copy from new.html.erb, because it is being relocated to home.html.erb.

We never got this copy onto home.html.erb right?

It should be, there is a PR open for it. I put it in there this weekend; hopefully I did it right.

Oh - I see it - it's in #350 - I'll rename that so it's a bit clearer


materialgram: Add version <IP_ADDRESS>

materialgram is a Telegram Desktop fork with Material Design and other improvements.
Closes #13331

[x] I have read the Contributing Guide.

/verify

Hey @aliesbelik, have I done something wrong ?

/verify


test: fix flaking e2e test (DRAFT)

- What I did

Haven't done it yet, but will fix the flakiness of the npt_to_port_22 test. Having difficulty reproducing the issue locally so, to begin with, adding scaffolding so can see daemon log file fragments if a test fails; hopefully will give a clue as to what the problem is.
Will resolve #900

- How I did it

fix: tests: added cleanup of test-generated ssh keys
test: Added some scaffolding to capture daemon log file fragments for reporting in the event of a test failure
chore: added some cleanup into e2e_all.yaml

- How to verify it

Tests should not fail unless there is a genuine problem

By wrapping the srv in a shell script and having the client execute that shell script instead of the srv binary, I have determined that there is indeed an unhandled exception somewhere. What I don't understand yet is why the runZonedGuarded error handler does not appear to be handling that exception

I've finally got a smoking gun after making some substantial changes to how the logging works in the srv process.
The core problem is that the parent process (sshnp or npt) reads what it needs from the child process's stderr and then exits but somehow, sometimes, this happens before the child process has finished using stderr.
SHOUT|2024-03-27 14:55:40.236002| srv.main |Unhandled exception FileSystemException: writeFrom failed, path = '' (OS Error: Broken pipe, errno = 32); stackTrace follows
#0      _RandomAccessFile.writeFromSync (dart:io/file_impl.dart:905)
#1      _StdConsumer.addStream.<anonymous closure> (dart:io/stdio.dart:309)
#2      _rootRunUnary (dart:async/zone.dart:1407)
#3      _CustomZone.runUnary (dart:async/zone.dart:1308)
#4      _CustomZone.runUnaryGuarded (dart:async/zone.dart:1217)
#5      _BufferingStreamSubscription._sendData (dart:async/stream_impl.dart:339)
#6      _BufferingStreamSubscription._add (dart:async/stream_impl.dart:271)
#7      _SyncStreamControllerDispatch._sendData (dart:async/stream_controller.dart:784)
#8      _StreamController._add (dart:async/stream_controller.dart:658)
#9      _StreamController.add (dart:async/stream_controller.dart:606)
#10     _StreamSinkImpl.add (dart:io/io_sink.dart:154)
#11     _IOSinkImpl.write (dart:io/io_sink.dart:287)
#12     _IOSinkImpl.writeln (dart:io/io_sink.dart:308)
#13     _StdSink.writeln (dart:io/stdio.dart:342)
#14     SrvImplDart.run (package:noports_core/src/srv/srv_impl.dart:421)

srv_impl.dart line 421 is : stderr.writeln(Srv.startedString);


Fix config file path for Windows

This was incorrectly reported in the README and the config file itself.
Fixes #15

LGTM though @pabogdan, would you double check :).

Seems ok


Error in select(): ! :1:7: unexpected symbol 1: Using an

Hi!
I am using repExplore() function and it is working ok, except when I try to do exp_len <- repExplore(allData$data, .method = "len"). In that case I get the following error:
Error in `select()`:
! <text>:1:7: unexpected symbol
1: Using an
          ^

If I do:  rlang::last_error(), I get:
<simpleError in select(., seq_col): <text>:1:7: unexpected symbol
1: Using an
          ^>

I get a similar error when I try to visualize results from other similar functions, such as:
exp_vol <- repExplore(allData$data, .method = "volume")
p1 <- vis(exp_vol, .by = c("Group"), .meta = allData$meta)

Error in `select()`:
! <text>:1:7: unexpected symbol
1: Using an
          ^

rlang::last_error()
<simpleError in select(.metadata, .by): <text>:1:7: unexpected symbol
1: Using an
          ^>

I've checked the colnames of the dataframes and I didn't find any weird symbol.
allData was generated by allData<-repLoad('Data', .coding = F) and this is an example of a particular sample inside this object:

Clones | Proportion | CDR3.nt | CDR3.aa | V.name | D.name | J.name | V.end | D.start | D.end | J.start | VJ.ins | VD.ins | DJ.ins | Sequence | CDR1.nt | CDR1.aa | CDR2.nt | CDR2.aa
2 | 0.0465116279069767 | TGCATGCAAACTCTACAAACTTCCCCGATCATGCAGACTCGACAAATTTCCCCGATCATTTTC | CMQTLQTSPIMQTRQISPIIF | IGKV2-28, IGKV2D-28 | NA | IGKJ5 | 21 | NA | NA | 52 | 30 | NA | NA | TGCATGCAAACTCTACAAACTTCCCCGATCATGCAGACTCGACAAATTTCCCCGATCATTTTC | NA | NA | NA | NA
2 | 0.0465116279069767 | TGTGCCACCTGGGACGGGCTCTGGATTAATTATTATAAGAAACTCTTT | CATWDGLWINYYKKLF | TRGV2 | NA | TRGJ1, TRGJ2 | 19 | NA | NA | 27 | 7 | NA | NA | TGTGCCACCTGGGACGGGCTCTGGATTAATTATTATAAGAAACTCTTT | NA | NA | NA | NA
2 | 0.0465116279069767 | TGCCAGTCCTATGACAGCAGCCTGAGTGCCCTTTATGTCTTC | CQSYDSSLSALYVF | IGLV1-40 | NA | IGLJ1 | 28 | NA | NA | 32 | 3 | NA | NA | TGCCAGTCCTATGACAGCAGCCTGAGTGCCCTTTATGTCTTC | NA | NA | NA | NA

This is my session info:
R version 4.0.4 (2021-02-15)
Platform: x86_64-w64-mingw32/x64 (64-bit)
Running under: Windows 10 x64 (build 19044)

Matrix products: default

locale:
[1] LC_COLLATE=Spanish_Spain.1252  LC_CTYPE=Spanish_Spain.1252    LC_MONETARY=Spanish_Spain.1252 LC_NUMERIC=C
[5] LC_TIME=Spanish_Spain.1252

attached base packages:
[1] stats     graphics  grDevices utils     datasets  methods   base

other attached packages:
[1] immunarch_0.6.7   patchwork_1.1.1   data.table_1.14.2 dtplyr_1.2.1      dplyr_1.0.9       ggplot2_3.3.6

loaded via a namespace (and not attached):
 [1] tidyr_1.2.0         bit64_4.0.5         vroom_1.5.7         jsonlite_1.8.0      carData_3.0-5       shiny_1.7.1
 [7] assertthat_0.2.1    stats4_4.0.4        cellranger_1.1.0    robustbase_0.95-0   ggrepel_0.9.1       factoextra_1.0.7
[13] pillar_1.7.0        backports_1.4.1     lattice_0.20-45     glue_1.6.2          digest_0.6.29       promises_<IP_ADDRESS>
[19] RColorBrewer_1.1-3  ggsignif_0.6.3      colorspace_2.0-3    htmltools_0.5.2     httpuv_1.6.5        plyr_1.8.7
[25] pkgconfig_2.0.3     pheatmap_1.0.12     broom_1.0.0         ggseqlogo_0.1       xtable_1.8-4        purrr_0.3.4
[31] scales_1.2.0        ggalluvial_0.12.3   later_1.3.0         tzdb_0.3.0          tibble_3.1.7        generics_0.1.3
[37] car_3.1-0           ellipsis_0.3.2      ggpubr_0.4.0        UpSetR_1.4.0        withr_2.5.0         nnet_7.3-15
[43] cli_3.3.0           mime_0.12           magrittr_2.0.3      crayon_1.5.1        readxl_1.4.0        mclust_5.4.9
[49] fansi_1.0.3         MASS_7.3-53         rstatix_0.7.0       class_7.3-18        tools_4.0.4         hms_1.1.1
[55] GlobalOptions_0.1.2 lifecycle_1.0.1     stringr_1.4.0       kernlab_0.9-30      munsell_0.5.0       cluster_2.1.0
[61] fpc_2.2-9           compiler_4.0.4      rlang_1.0.4         grid_4.0.4          rstudioapi_0.13     circlize_0.4.15
[67] gtable_0.3.0        abind_1.4-5         flexmix_2.3-18      DBI_1.1.3           reshape2_1.4.4      R6_2.5.1
[73] gridExtra_2.3       prabclus_2.3-2      bit_4.0.4           fastmap_1.1.0       utf8_1.2.2          shinythemes_1.2.0
[79] shape_1.4.6         readr_2.1.2         modeltools_0.2-23   stringi_1.7.8       parallel_4.0.4      Rcpp_1.0.9
[85] vctrs_0.4.1         DEoptimR_1.0-11     tidyselect_1.2.0    diptest_0.76-0

Do you know how can I solve this?

Hello! I had similar errors.

p1 <- vis(exp_vol, .by = c("Position"), .meta = immhccdata_mixcr$meta)
Error in select():
! :1:7: unexpected symbol
1: Using an
^
Run rlang::last_error() to see where the error occurred.

However, it is ok when using two parameters

p2 <- vis(exp_vol, .by = c("Position", "Overall_Survial_Group"), .meta = immhccdata_mixcr$meta)
Warning message:
Ignoring unknown aesthetics: xmin, xmax, annotations, y_position

Have you solved this problem?
I'm really at a loss as to how to proceed, and any guidance would be much appreciated!
Thank you for your kind help!

Hi, @Biojenifer and @QianhuiXu!
I'm Aleksandr Popov, a developer of Immunarch package. Thank you for using our software!
@Biojenifer, I've tried to reproduce the error with your example data: first saved it to the file
example.zip
Then loaded it with commands:
immdata <- repLoad('example.tsv', .coding = F)
exp_len <- repExplore(immdata$data, .method = "len")

And these commands worked successfully. From your environment, it's visible that you are using an old version of immunarch package. Please update it and try again with the latest version. To install the latest release version, use the commands:
install.packages("immunarch")
library("immunarch")

And for the latest development version:
install.packages(c("devtools", "pkgload"))
devtools::install_github("immunomind/immunarch", ref="dev")
devtools::reload(pkgload::inst("immunarch"))
library("immunarch")

@QianhuiXu, if the bug still persists with the latest version of immunarch, can you, please, attach an example data for which the bug can be reproduced?
Best regards,
Aleksandr


可以双击么。为什么我的doubleclick为true双击没反应

Hello,
I see you closed this, and I assume you saw the other issue but if not #25 has code that will allow double click support - I will enable it back in the base control as soon as I've got time to test why it was disabled originally.
Regards;
Richard Moss


estimateGas returns error

i would suggest to just use fixed gas limits for our transactions

we should test if this still happens with different blockchain clients.

Working now


Automated Package Upgrade

:tada: This PR is included in version 25.3.495 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Command service improvements

ApplicationService renamed to CommandService breaking change
Enable contract mapping to domain commands

For controllers it's possible using the CommandMap
For generated endpoints, it should be done in MapCommand

First version of FunctionalCommandService

Fixes #153
Fixes #158


In memory database for testing

created a in memory database and made tests for all the methods we have so far within our repositories

I looks good. We'll pick it up tomorrow again. Nice work boys.


Issue with Levels module enabled: square boxes around tokens of size greater than one

fvtt 0.8.8
Hex Size Support 1.1.10
Levels <IP_ADDRESS> (and required dependencies)
With Levels enabled the box around tokens of size greater than one is square.
with Levels:

without Levels:

No errors in console

I will look into it a bit in the future, though I'm tired after getting 0.8.6 support in general. If I had to guess it's because Levels seems to mess around pretty heavily with the rendering of stuff and it's probably just overwriting the borders I draw. Maybe there will be a good solution, maybe not.

i'm not overriding any borders so not sure what's happening there (levels dev here)

Not sure then. Will have to look at some point. I'm busy at the moment but I'll try to test it out a little later tonight and see if I can figure out what's going on. The fact that the config is showing, and the token's art is extending outsize the bounding box of the token implies that my module is actually running and the border is getting replaced somehow or something is causing it to not draw it.
I'll admit I've never actually gotten around to using Levels, so I'm just guessing why. I really need to sit down with both modules and see why mine's unhappy. I'm betting it's something that I will see very quickly when using the module.

Figured it out. This is because Levels overrides the default Token.refresh() method(via libwrapper) which I also do(via shenanigans and debatably bad coding practices). It's probably my fault for never getting around to integrating libwrapper and I believe that overridden method was one of the first parts of my library so it's probably not handled the best way. In my defense, libwrapper didn't exist when I first wrote this library, but I've definitely put it off for waaaay too long.
I'll look into my code to see if I need to be overriding refresh or can just wrap it and if I can just get away wrapping it, I'll work on integrating libwrapper which should let the two modules play nice(assuming nothing else goes wrong)

I can't say if it's a recent change in Levels that caused the change, but it seems the issue is gone

ye i switched the token refresh from override to wrapped and accidentally fixed the issue


Let's add some functionality for convinience of our users

Provide a method to concatenate data from multiple ConstBuffers into one char buffer.
int gather(char* buffer, size_t length, const ConstBuffer* buffers, size_t numBuffers)

Provide methods to append all ntsa buffer types to bdlbb::Blob, now there is only DataUtil::append(bdlbb::Blob *destination, const ntsa::Data& source) (which requires construction of ntsa::Data in advance)

Add ability to specify size of ConstBufferArray at construction (add ConstBufferArray(size_t initialSize, bslma::Allocator* basicAllocator = 0) constructor)

This has been done.


[Touchable] Preventing a touch area from overflowing?

I am using a navigation bar with a button inside of it. The navigation bar has a fixed height, and the button is a TouchableOpacity that wraps a View. When I give the View some large bottom padding (like 200pt) it is visually clipped by the navigation bar (overflow: hidden) but still responds to touches below the bar, where the overflowing content would be.
+----------------------------------------+
|                           +------------|
|  Navigation Bar           |   Button  ||
|                           |           ||
+----------------------------------------+
                            |           |
Region is clipped but       |           |
still responds to     +---> |           |
touches                     |           |
                            |           |
                            +-----------+

Thank you for reporting this issue and appreciate your patience. We've  notified the core team for an update on this issue. We're looking for a response within the next 30 days or the issue may be closed.

Did you ever find a way around this @Ide?

I don't think so.

No worries, thanks for getting back to me :) :+1:  I'll reply here if I find a workable solution or workaround.

Hi there! This issue is being closed because it has been inactive for a while.
But don't worry, it will live on with ProductPains! Check out its new home: https://productpains.com/post/react-native/touchable-preventing-a-touch-area-from-overflowing
ProductPains helps the community prioritize the most important issues thanks to its voting feature.
It is easy to use - just login with GitHub.
Also, if this issue is a bug, please consider sending a PR with a fix. We rely on the community to provide
bugfixes as the core team is focused on performance.

I have a similar issue, where I tried to create touchable area with icon + text, acting like borderless button. The workaround I use is to instead of having TouchableOpacity that wraps a view, we wrap it inside a view, in that way, the touchable area will get confined to the parent view.
This is how it looks in the screenshot, only blue area responds to touch event. If we put TouchableOpacity as root element wrapping the view, the entire row is touchable.

Not sure it's a proper way to do it, but works for me now.


Fix orc read data mess up for the schema can't be pruned

This PR first fixes the orc data reading mess up for the schema which can't be pruned
second, adds the dis-order read schema unit tests for both Parquet and Orc.
Please refer to issue #3060.
With this PR, GPU can produce the correct result but The CPU itself has produced the wrong result. So this PR will bring the in-compatible behavior between GPU and CPU.

build

build


DEP: stats: improve deprecation of private but present modules

Reference issue

Part of https://github.com/scipy/scipy/issues/18279
What does this implement/fix?

Finishes #18835 for the rest of stats
Additional information

Thanks @mdhaber, I have addressed points 1 & 3. I agree in principle that import scipy.stats.morestats should raise a warning. The obvious way to do this is just to add a warning.warn to the file but then from scipy.stats.morestats import  brunnermunzel would end up with two warnings (one from executing the file at import time and the other from the __getattr__). It looks like there is some magic you can do to detect what type of import is being used but I am not sure if that would be a good idea.

I think the inconvenience would be ok vs trying to craft some magic. Whether it's one or two warnings, on the user side the resolution should be the same with a filter which should catch both.


fix: sync cookie when setting locale

🔗 Linked issue

#2829

❓ Type of change

[ ] 📖 Documentation (updates to the documentation, readme or JSdoc annotations)
[x] 🐞 Bug fix (a non-breaking change that fixes an issue)
[ ] 👌 Enhancement (improving an existing functionality like performance)
[ ] ✨ New feature (a non-breaking change that adds functionality)
[ ] 🧹 Chore (updates to the build process or auxiliary tools and libraries)
[ ] ⚠ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description
Resolves #2829
Please note that this actually changes the cookie behavior slightly, this is why I set this RP to draft status.
These changes ensure that the cookie is always set and up to date (if configured of course), even when no redirection takes place necessarily. I feel like this would only ensure the correct locale is used even if the user has not been redirected (e.g. entering the website on a page in which redirection would occur anyways), are there any downsides to this change?
If we want to keep this change we may need to adjust the documentation a bit, I haven't looked into this yet.

📝 Checklist

[x] I have linked an issue or discussion.
[x] I have added tests (if possible).
[x] I have updated the documentation accordingly.

These changes ensure that the cookie is always set and up to date (if configured of course), even when no redirection takes place necessarily. I feel like this would only ensure the correct locale is used even if the user has not been redirected (e.g. entering the website on a page in which redirection would occur anyways), are there any downsides to this change?

Thanks for your fixing!
I believe that your fix is no downside.
In fact, your change has passed testing and has not caused any regression.
Let’s merge this PR!

It looks like this PR has broken the package with infinity redirects in some browsers like Opera or Yandex.

It looks like this PR has broken the package with infinity redirects in some browsers like Opera or Yandex.

Can you open an issue with a minimal reproduction? 🙏


Fix HealthCheckResponseValidationTest TCK to support JDK8 datatype mo…

…dules
Signed-off-by: Prashanth G<EMAIL_ADDRESS>

@xstefank The TCK uses ObjectMapper from Jackson-databind 2.x module, to deserialize the JSON Response string, however, it does not contain the JDK8-specific datatypes, such as Optionals. Hence, when the TCK is ran using JDK14 (at least in OpenLiberty), the following exception is thrown com.fasterxml.jackson.databind.JsonMappingException: No suitable constructor found for type [simple type class java.util.Optional<java.util.Map<java.lang.Stringjava.lang.Object>>]:, since it can't find the Optional datatype in the provided Jackson-core module. By adding the mapper.findAndRegisterModules(), it would automatically discover the jackson-datatype-jdk8 module to provide support for the jdk8-specific datatypes.
I verified this PR in OL with JDK 8, 11, and 14 as well, and they pass.

@pgunapal ok, when it helps you in your impl then we can include this change.


Crashes during finetuning

I am trying to do a 30B finetune on 2x3090 using data parallel and the process will always crash before 3 steps is completed. I run the finetune script in a screen session on a remote computer, and the screen session is gone when i reestablish the SSH connection after the crash.
 Try using a batch size of 1.

I think you should keep the ssh session, or running the task in background


Resulting recipe ingredients incomplete - importing only words from  links

Hello,
First of all, I have to congratulate you for the library, it is really awesome!
I found an issue today with some recipes.
I try to parse this webpage: http://www.foodista.com/recipe/H5M86RVB/breakfast-casseroles
The preparation instructions are:
Grease a 9 x 13 inch casserole dish. Line dish with unbaked crescent rolls. Spread cooked meat evenly over rolls. Pour beaten eggs over meat. Place cheese over layer of eggs. Bake at 350 degrees for 45 minutes or until firm. Cool 10 minutes before cutting into squares and serve.
But the library returns in the 'Instructions' response:
                        [0] => dish.
                        [1] => dish
                        [2] => rolls.
                        [3] => Bake
                        [4] => Cool
                        [5] => cutting
                        [6] => serve

which corresponds to words from content that have links attached to them.
Thank you for your time checking on this.
Regards,
Szabi.

I just checked on this and it seems that the issue is in the MicrodataSchema.php file.
It tries to get the instructions from the html file using this xpath:
$nodes = $xpath->query('//[@itemprop="recipeInstructions"]/');
This matches only the  links in the recipe's instructions. I solved this, by modifying your code like this:
            ```

if (!$found) {
$nodes = $xpath->query('//[@itemprop="recipeInstructions"]/');
if ($nodes->length) {
$only_a = true;
for ($i = 0; $i < $nodes->length; $i++) {
if($nodes->item($i)->tagName != 'a')
{
$only_a = false;
}
}
if($only_a == false)
{
RecipeParser_Text::parseInstructionsFromNodes($nodes, $recipe);
$found = true;
// Recipe.com gets caught up in here, but doesn't have well-formed nodes wrapping each ingredient.
}
}
}

In this case, the parser will check if it found only links and will continue in this unfortunate case. :)

If you like this solution, feel free to include it in your code.

Please let me know your opinion on this.

Regards.


Build and Publish Docs

The docs need to be built in some regular fashion, perhaps by TravisCI, and published somewhere (the gh-pages branch of this repo, or along with the public Anidata.org website).

I say we stick to gh-pages as the anidata website should probably be used as an outreach/organizational tool moreso than host any code/docs.  We can always link the projects on the site anyway.

this seems like a good starting point

Great idea!

This may be a simpler approach, but probably needs to be done by someone with access to the travis acct (so an anidata org member).

Wow that's a much better option let's go with @wdm0006 suggestion.


Gem conflicts issue on fastlane update with terminal_table gem

New Issue Checklist

[x] Updated fastlane to the latest version
[x] I have read the Contribution Guidelines

Issue Description
Complete output when running fastlane, including the stack trace and command used

You can use: --capture_output as the last commandline argument to get that collected for you

After updating to the latest fastlane (2.1.1), i am seeing gem conflicts error for terminal_table gem. It used to work fine like an hour ago, after update i cant make any new builds.
Heres the screenshot of the error

Environment
Please run fastlane env and copy the output below. This will help us help you :+1:
If you used --capture_output option please remove this block - as it is already included there.
✅ fastlane environment ✅
Stack

Key
Value

OS
10.11.6

Ruby
2.2.5

Bundler?
false

Git
git version 2.6.4

Installation Source
~/.rvm/gems/ruby-2.2.5/bin/fastlane

Host
Mac OS X 10.11.6 (15G31)

Ruby Lib Dir
~/.rvm/rubies/ruby-2.2.5/lib

OpenSSL Version
OpenSSL 1.0.2e 3 Dec 2015

Is contained
false

Xcode Path
/Applications/Xcode.app/Contents/Developer//

Xcode Version
8.0

System Locale

Variable
Value

LANG
en_US.UTF-8
✅

LC_ALL

LANGUAGE

fastlane files:
`./fastlane/Fastfile`
# Customise this file, documentation can be found here:
# https://github.com/fastlane/fastlane/tree/master/fastlane/docs
# All available actions: https://github.com/fastlane/fastlane/blob/master/fastlane/docs/Actions.md
# can also be listed using the `fastlane actions` command

# Change the syntax highlighting to Ruby
# All lines starting with a # are ignored when running `fastlane`

# If you want to automatically update fastlane if a new version is available:
# update_fastlane

# This is the minimum version number required.
# Update this, if you use features of a newer version
fastlane_version "1.95.0"

default_platform :ios

platform :ios do
  before_all do |lane, options|
    ENV["SLACK_URL"] = "https://hooks.slack.com/services/"
    cocoapods
    increment_build_number_using_Shenzhen(options) unless options[:skipVersionNo]
    ENV['DEVELOPER_DIR'] = options[:xcodeDir] if options[:xcodeDir]
    ENV['MATCH_PASSWORD'] = options[:matchPass] if options[:matchPass]
  end

  # desc "Runs all the tests"
  # lane :test do
  #   scan
  # end

  desc "This lane updates the CFBundleShortVersionString & CFBundleVersion using Shenzhen::PlistBuddy"
  lane :increment_build_number_using_Shenzhen do |options|
    require 'Shenzhen'
    puts 'incrementing build number'
    short_version = options[:version]
    bundle_version = 1
    if options[:build_number]
      bundle_version = options[:build_number]
    else
      old_version = Shenzhen::PlistBuddy.print(ENV['PLIST_PATH'], 'CFBundleVersion')
      bundle_version = old_version.to_i + 1
    end
    puts "short version:: #{short_version}"
    puts "bundle version:: #{bundle_version}"
    Shenzhen::PlistBuddy.set(ENV['PLIST_PATH'], 'CFBundleShortVersionString', short_version)
    Shenzhen::PlistBuddy.set(ENV['PLIST_PATH'], 'CFBundleVersion', bundle_version)
  end

  desc "Match lane to download certificates from veezu-certs github repo"
  lane :download_certs do |options|
    cert_type = getFastlaneBuildType options
    puts " APP_IDENTIFIER :: #{ENV["APP_IDENTIFIER"]}"
    match(git_url: ENV["MATCH_URL"],
           type: cert_type,
           app_identifier: ENV["APP_IDENTIFIER"],
           username:  ENV["APPLE_ID"],
           force:true)
  end

  desc "This will add new UDIDs to the given profile and calls `download_certs` to get the veezu-certs match repo upto date"
  desc "Also this will download and install the new profile with the added UDIDs"
  lane :add_devices do |options|
    if options[:udids]
      devices = options[:udids].split '+'
      devices.each do |device|
        register_devices(
          username:ENV['APPLE_ID'],
          devices:{
            "Fastlane Added Device" =>  device
          }
        )
      end

    end
  end

  desc "Submit a new Beta Build to Apple TestFlight"
  desc "This will also make sure the profile is up to date"
  lane :beta do |options|
    add_devices options

    ENV["PROFILE_UDID"] = lane_context[SharedValues::SIGH_UDID]
    if (options[:configuration])
      build_type =  options[:releaseType]#ad-hoc/app-store
      build_configuration = options[:configuration] # StagingServer/LiveServer/DevelopmentCloudServer
    else
      build_type = "ad-hoc" #ad-hoc/app-store
      build_configuration = "StagingServer" # StagingServer/LiveServer/DevelopmentCloudServer
    end

    unlock_keychain(path: "login.keychain", password: options[:systemPass] || ENV["SYSTEM_PASSWORD"])

    gym(
      scheme: ENV["SCHEME_NAME"],
      export_method: build_type,
      configuration: build_configuration,
      verbose: true,
      output_directory: "./build",
      use_legacy_build_api: true,
      toolchain: 'swift_2_3'
    )

    ENV['FASTLANE_PASSWORD'] =  ENV['ITUNES_PASSWORD']

    notes = changelog_from_git_commits

    # Upload the build to HockeyApp.
    hockey(
      api_token: ENV['HOCKEYAPP_TOKEN'],
      public_identifier: ENV['HOCKEYAPP_ID'],
      notes: notes,
      notes_type: "2",
      commit_sha: `git rev-parse HEAD`.strip,
      status: "2",
      repository_url:"https://github.com/xxxx"
    )

    uploaded_version = Actions.lane_context[Actions::SharedValues::HOCKEY_BUILD_INFORMATION]["id"]
    hockey_link = "https://rink.hockeyapp.net/apps/#{ENV['HOCKEYAPP_ID']}/app_versions/#{uploaded_version}"
    puts Actions.lane_context[Actions::SharedValues::HOCKEY_BUILD_INFORMATION]
    puts "Hockey version link #{hockey_link}"

  if build_type == 'app-store'
   pilot(skip_submission: true, username: ENV['APPLE_ID'])
  end

  clean_build_artifacts

    after_all do |lane|
      slack(
        message: "New #{ENV['SCHEME_NAME']} app is availabe here #{hockey_link}",
        channel: ENV["SLACK_CHANNEL"]
      )
    end

    # sh "your_script.sh"
    # You can also use other beta testing services here (run `fastlane actions`)
  end

  # You can define as many lanes as you want

  error do |lane, exception|
    slack(
      message: exception.message,
      success: false,
      channel: ENV["SLACK_CHANNEL"]
    )
  end
end

def getFastlaneBuildType(options)
   cert_type = "adhoc"
    if (options[:releaseType])
      if options[:releaseType] == "ad-hoc"
        cert_type = "adhoc"
      elsif options[:releaseType] == "app-store"
        cert_type = "appstore"
      else
        cert_type = "development"
      end
    end
    cert_type
end

# More information about multiple platforms in fastlane: https://github.com/fastlane/fastlane/blob/master/fastlane/docs/Platforms.md
# All available actions: https://github.com/fastlane/fastlane/blob/master/fastlane/docs/Actions.md

# fastlane reports which actions are used
# No personal data is recorded. Learn more at https://github.com/fastlane/enhancer

`./fastlane/Appfile`
app_identifier ENV["APP_IDENTIFIER"] # The bundle identifier of your app
apple_id ENV["APPLE_ID"] # Your developer account email address
itunes_connect_id ENV["ITUNES_CONNECT_ID"] # Your itunes connect email address
team_id ENV["TEAM_ID"]  # Developer Portal Team ID
itc_provider ENV["TEAM_ID"]
username ENV["APPLE_ID"]
# you can even provide different app identifiers, Apple IDs and team names per lane:
# More information: https://github.com/fastlane/fastlane/blob/master/fastlane/docs/Appfile.md

fastlane gems

Gem
Version
Update-Status

fastlane
2.1.1
✅ Up-To-Date

Loaded fastlane plugins:
No plugins Loaded
Loaded gems

Gem
Version

slack-notifier
1.5.1

rouge
1.11.1

xcpretty
0.2.4

terminal-notifier
1.6.3

unicode-display_width
1.1.1

terminal-table
1.7.3

plist
3.1.0

multipart-post
2.0.0

word_wrap
1.0.0

babosa
1.0.2

colored
1.2

commander
4.4.0

excon
0.45.4

faraday
0.9.2

faraday-cookie_jar
0.0.6

fastimage
1.6.8

gh_inspector
1.0.2

uber
0.0.15

representable
2.3.0

retriable
2.1.0

hurley
0.2

little-plugger
1.1.4

logging
2.1.0

jwt
1.5.4

memoist
0.14.0

os
0.9.6

signet
0.7.3

googleauth
0.5.1

thor
0.19.1

httpclient
2.8.0

google-api-client
0.9.11

mini_magick
4.5.1

security
0.1.3

xcpretty-travis-formatter
0.0.4

dotenv
2.1.1

bundler
1.12.5

faraday_middleware
0.10.0

json
1.8.3

highline
1.7.8

rubyzip
1.2.0

xcodeproj
1.2.0

claide
1.0.1

generated on: 2016-12-20

@Rameshv Are you running your comands with bundle exec? ie: bundle exec fastlane <lane name>? If not, can you try that? It looks like you have multiple terminal_table  gems installed and the system does not know which one to grab. bundle exec will make sure it fastlane will only use the one that is specified in the Gemfile
If that does not work for you, can you try updating to 2.2.0? That was just released recently.
Thanks 😊

Thanks @joshdholtz for the reply
Unfortunately fastlane with bundle exec also not working.. For some funny reasons it started working after removing 1.7.3 version and restarting. :)


Is it possible to record the audio at the same time?

Hi,
I'm wondering if it's possible to record audio at the same time the model is running?
Basically, I want to build something that saves snippets of the audio when specific things are detected.
Thanks,
Jonas

hi @joknjokn,
Its possible for a model to output the starting and ending time when it detects a specific sound. However, this is based on how you train your model, not on this plugin.
As for saving the audio file, I have yet to implement this feature on this plugin, but its doable. You can splice the audio once you have saved the file.


Feature request - support symlink to GGUF in custom model instead of GGUF 1:1 copy

Hello there,
maybe I'm missing something from the documentation. I am working with lots of custom models where the only difference is in System prompts but the custom models are always based on the same GGUF file. So, having ollama to always copy/duplicate it again and again when I create new model is

time-consuming
eats disk-space very quickly

Now, after model is created, I delete the duplicate blob and manually symlink it to the source GGUF, which is a little bit inconvenient.
Would it be possible to implement this? Something like a parameter called SYMLINK (besides FROM).
Thanks!

You only need to specify the GGUF once, for the first model you create. Any time you create a new model, reference that model by name, rather than the location of the GGUF.
For example, say you first ollama create my-base .... If you want to create another model based on the same GGUF, use FROM my-base, not the path to the GGUF.
Beyond that, Ollama tracks the uploaded weights using a hash of the actual data. If you upload the same file twice, they'll have the same hash and so only a single copy of the data will be stored.

@mirekjany as @easp was saying, Ollama does de-duplication automatically for any layer. If a layer is the same between models, only one copy will be saved. It does this using content addressability; the layers are stored by their sha256 hashes in the models/blobs/ directory, and the manifest for the model always references the data by that hash.

Appreciate the clarification, works as expected, closing the issue.

Appreciate the clarification, works as expected, closing the issue.


Getting error when playing AWS cloudfront URL in Flutter web

Error: PlatformException(MEDIA_ERR_SRC_NOT_SUPPORTED, No further diagnostic information can be determined or provided., The video has been found to be unsuitable (missing or in a format not supported by your browser)., null)

same here

@rahulvyas based on the fact that it's a PlatformException, this error is definitely coming from video_player, since chewie is merely a UI wrapper around that library.
Please bring up this issue with a reproducible example to the Flutter GitHub repo, since that's where you can raise issues related to first party plugins.

@diegotori Thanks for the heads up. I'll add the same issue in the official repo.


ci: Revert docker publishing changes to fix CI

Commit Message:
Additional Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]

/retest

the problem with the upstream build image has been fixed so this shouldnt be necessary


No Objects to add

Hi,
This looks very nice and promising.
I have an issue. I can't add any objects. It is grayed out...
Any ideas or troubleshooting advice?
Thanks,
Alex

same here, can't add anything

You first need to create a Section or a Scenes View. Then you'll be able to add objects to them.


Add support for linux-ppc64le target

This PR consists of the changes to support ppc64le target.

Adding some context to this request -- in .NET7 announced today by Microsoft, we now have support for the ppc64le ( Linux on IBM Power) . We would like to enable the .NET applications on ppc64le to talk to Database back ends and this PR is part of that work.
Appreciate consideration of this PR.

Thank for merging this PR so quickly. What is the cadence of your releases - when is the next release scheduled for? Is there a publicly available daily build that we can use to test with?

I plan to do a test release yet this week, and probably a full release next week.

@janani66 Version 2.1.3-pre20221111222311 on nuget should contain your pull requests for linux-ppc64le support.  Have you by chance had an opportunity to test that release and verify that it works?
Thanks!

@ericsink
We will test this today and confirm you once it works.

Hi @ericsink
Thanks for providing the nuget package version. I tried testing this on Intel and Power machines. It worked on Intel machine but I am getting below exception on Power machine.
Below are the steps that I used for testing this with IdentityServer4 repository.

Clone dotnet/efcore repo and checkout release/7.0 branch.
Add 2.1.3-pre20221111222311 in eng/Versions.props file
Build efcore repo with command "./build.sh -c Release -pack"
The .nupkg files gets generated in efcore/artifiacts/packages/Release/Shipping
Clone IdentityServer4 repo (Done lot of dotnet version related changes and added some code fixes to work this with dotnet version 7.0.0)
Add local path "efcore/artifiacts/packages/Release/Shipping" in NuGet.config of IdentityServer4 repo
Change version "7.0.1" to 7.0.1 which is built in efcore in src/Directory.Build.targets file.
./build.sh

The IdentityServer4 build and tests works on Intel machine but on Power machine exception occurrs saying that e_sqlite3 DLL is not found. I am trying to check whats there in nuget package but Can you please have a look at the package whether it is there or not?
Below is the exception log:
[xUnit.net 00:00:04.94]     IdentityServer4.EntityFramework.IntegrationTests.Stores.ScopeStoreTests.GetAllResources_WhenAllResourcesRequested_ExpectAllResourcesIncludingHidden(options: DbContextOptions1 { ContextType = typeof(IdentityServer4.EntityFramework.DbContexts.ConfigurationDbContext), Extensions = [CoreOptionsExtension { ... }, InMemoryOptionsExtension { ... }], IsFrozen = False }) [FAIL] [[xUnit.net](http://xunit.net/) 00:00:05.00]     IdentityServer4.EntityFramework.IntegrationTests.Stores.ScopeStoreTests.GetAllResources_WhenAllResourcesRequested_ExpectAllResourcesIncludingHidden(options: DbContextOptions1 { ContextType = typeof(IdentityServer4.EntityFramework.DbContexts.ConfigurationDbContext), Extensions = [SqliteOptionsExtension { ... }, CoreOptionsExtension { ... }], IsFrozen = False }) [FAIL]
Failed IdentityServer4.EntityFramework.IntegrationTests.Stores.ScopeStoreTests.GetAllResources_WhenAllResourcesRequested_ExpectAllResourcesIncludingHidden(options: DbContextOptions`1 { ContextType = typeof(IdentityServer4.EntityFramework.DbContexts.ConfigurationDbContext), Extensions = [CoreOptionsExtension { ... }, InMemoryOptionsExtension { ... }], IsFrozen = False }) [1 ms]
Error Message:
System.TypeInitializationException : The type initializer for 'Microsoft.Data.Sqlite.SqliteConnection' threw an exception.
---- System.Reflection.TargetInvocationException : Exception has been thrown by the target of an invocation.
-------- System.DllNotFoundException : e_sqlite3

The file is present in the package.
$ unzip -l sqlitepclraw.lib.e_sqlite<IP_ADDRESS>-pre20221111222311.nupkg
Archive:  sqlitepclraw.lib.e_sqlite<IP_ADDRESS>-pre20221111222311.nupkg
  Length      Date    Time    Name
---------  ---------- -----   ----
      520  2022-11-11 22:25   _rels/.rels
     1102  2022-11-11 22:25   SQLitePCLRaw.lib.e_sqlite3.nuspec
...
  1382760  2022-11-11 22:20   runtimes/linux-ppc64le/native/libe_sqlite3.so
...
---------                     -------
 34417858                     38 files

Possibly useful (or not) diagnostic questions:

Is linux-ppc64le the correct RID?
Is that libe_sqlite3.so file valid?  What are its dynamic dependencies, and are those deps present on your test system?  If you write a minimal C program to load the library and get an entry point like int sqlite3_libversion_number(void);, does it work?

Thanks @ericsink for the response. I will try sample program suggested by you and also trying other solutions to check what's going wrong on Power machine. I will get back to you once I get something.

@ericsink
I have figured out the issue. The problem was with the changes made in efcore repo before building on Intel machine. I had added previously only "2.1.3-pre20221111222311" in eng/Versions.props file but that is not sufficient. I have also updated versions for each instance of SQLitePCLRaw.<package_name> in all .csproj files in efcore repo and also added below key in NuGet.config.

I have built efcore on Intel machine after making above changes and then used the generated nuget packages on Power machine. After using these packages it refers to correct version 2.1.3-pre20221111222311 for each package and installs it correctly and DLL Not Found exception got resolved. The build and test suites passed on Power.
@ericsink
One question is - What can be the next steps to make this as a release version instead of pre release version and do we need to make any changes in efcore repo for that?

I can't answer anything about what needs to happen for the efcore repo.  You'd have to ask them.
One further thing you could verify would be to create a test project that uses efcore packages from nuget instead of using your own build of the efcore repo, but with an additional PackageReference to update SQLitePCLRaw to 2.1.3-pre20221111222311.  It seems like such a test should work on Power, assuming that efcore itself did not need any changes.
Something like this:
  <ItemGroup>
    <PackageReference Include="microsoft.entityframeworkcore" Version="7.0.0" />
    <PackageReference Include="sqlitepclraw.bundle_e_sqlite3" Version="2.1.3-pre20221111222311" />
  </ItemGroup>

In any case, based on what you said above, it sounds like the ppc64le builds of e_sqlite3 are working okay, so I should be able to do a release version with no further changes to SQLitePCLRaw.

@ericsink  -- yes the ppc64le builds of e_sqlite3 ( 2.1.3-pre20221111222311) are working okay. Do let us know when you do a release version of this.

@ericsink
Kindly let us know once you do the release version with ppc64le support.

@alhad-deshpande I have not forgotten.  I have been waiting because there is a bug fix that seemed imminent, but I had hoped that would be done by now.  I may need to just go ahead and do the release.

@alhad-deshpande Version 2.1.3 (with ppc64le) has been published to nuget.org.

Thanks @ericsink


Handle inconsistent user input / output directories

If input and output directories aren't properly matched with trailing slashes, the replace function doesn't work properly.

Thank you!


Compatibility with Sanic 19.6.2

Hi,
Describe the bug
I just bumped into an error when upgrading to newest version of Sanic using ASGI interface.
Since ASGI lifespan protocol has support for only two server events, we no longer can make usage of before_server_start and after_server_stop server events.
Sanic OpenAPI uses before_server_start server event and this give us the following warning:
UserWarning: You have set a listener for "before_server_start" in ASGI mode. It will be executed as early as possible, but not before the ASGI server is started.

To Reproduce
Run Sanic using an ASGI interface
Expected behavior
Make sure this warning doesn't happen.
Environment:

ubuntu 18.04
Version [0.5.3]

On the decorator of the method build_spec at the file swagger.py I suggest the following change:
before
@blueprint.listener('before_server_start')

after
@blueprint.listener('after_server_start')

What do you think about it?

Sounds good. Would you wanna submit a PR for this?

Yes, I'll do it.

@chenjr0719 I just created PR #130 for it

:+1:  Nice catch.