BatchAI. SDK for 2018-03-01 Rest API

added support for job level mounting
added support for environment variables with secret values
added support for performance counters reporting in Azure Application Insights
added support for custom images
added support for pyTorch deep learning framework
added API for usage and limits reporting
added API for listing job files in subdirectories
now user can choose caching type during NFS creation
get cluster now reports a path segment generated for storing start task output logs
get job now reports a path segment generated for job's output directories
renamed EnvironmentSetting to EnvironmentVariable

Can one of the admins verify this patch?

@AutorestCI rebuild https://github.com/Azure/azure-rest-api-specs/tree/master/specification/batchai/resource-manager/readme.md

Working on generating https://github.com/azure/azure-rest-api-specs/tree/master/specification/batchai/resource-manager/readme.md for you!!!

Encountered an unknown error
Traceback (most recent call last):
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/github_tools.py", line 32, in exception_to_github
    yield context
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/bot_framework.py", line 104, in manage_comment
    response = getattr(self.handler, orderstr)(webhook_data.issue, *split_text)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/sdkbot.py", line 113, in rebuild
    link = link.as_raw_link()  # Ensure this is a raw link.
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/github_tools.py", line 317, in as_raw_link
    raise ValueError("Cannot get a download link from a tree link")
ValueError: Cannot get a download link from a tree link

@AutorestCI rebuild https://github.com/Azure/azure-rest-api-specs/blob/master/specification/batchai/resource-manager/readme.md

Working on generating https://github.com/azure/azure-rest-api-specs/blob/master/specification/batchai/resource-manager/readme.md for you!!!

Build SDK finished and cleaned

Codecov Report

Merging #2211 into master will increase coverage by 0.06%.
The diff coverage is 85.97%.

@@            Coverage Diff             @@
##           master    #2211      +/-   ##
==========================================
+ Coverage   52.06%   52.12%   +0.06%
==========================================
  Files        5567     5575       +8
  Lines      133508   133752     +244
==========================================
+ Hits        69510    69720     +210
- Misses      63998    64032      +34

Impacted Files
Coverage Δ

...-mgmt-batchai/azure/mgmt/batchai/models/cluster.py
100% <ø> (ø)
:arrow_up:

...t-batchai/azure/mgmt/batchai/models/file_server.py
100% <ø> (ø)
:arrow_up:

...ure/mgmt/batchai/models/key_vault_key_reference.py
62.5% <0%> (-8.93%)
:arrow_down:

...atchai/azure/mgmt/batchai/models/caffe_settings.py
40% <0%> (-4.45%)
:arrow_down:

...hai/azure/mgmt/batchai/models/jobs_list_options.py
42.85% <0%> (-7.15%)
:arrow_down:

...tchai/azure/mgmt/batchai/models/caffe2_settings.py
55.55% <0%> (-6.95%)
:arrow_down:

...tchai/azure/mgmt/batchai/models/name_value_pair.py
57.14% <0%> (-9.53%)
:arrow_down:

...e/mgmt/batchai/models/file_servers_list_options.py
42.85% <0%> (-7.15%)
:arrow_down:

...chai/azure/mgmt/batchai/models/chainer_settings.py
50% <0%> (-5.56%)
:arrow_down:

...hai/azure/mgmt/batchai/models/operation_display.py
44.44% <0%> (-5.56%)
:arrow_down:

... and 74 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7d68689...b312a06. Read the comment docs.


Change  #ifdef QT_NO_OPENSSL to #ifdef QT_NO_SSL ?

I tried enabling SSL in your examples on OSX. It seems you should test for SSL availability with :
#ifdef  QT_NO_SSL instead of  #ifdef  QT_NO_OPENSSL in:
sslloader.cpp
and
httpreadrequest.cpp
Otherwise, SSL is not detected on OSX. I don't know for other platforms though.
I did the change and everything works for me.
Thanks for this nice project!
Dominic

@doumdi Can you please mention the method how you created and applied the SSL certificate in CPPWebFramework? I am absolutely new to this so sorry if it feels a dumb question.

https://www.ibm.com/support/knowledgecenter/en/SSWHYP_4.0.0/com.ibm.apimgmt.cmc.doc/task_apionprem_gernerate_self_signed_openSSL.html

Many thanks for your information, I will check it.


'Cluster-dump' feature to export Kubernetes Resources to S3

A new kube-system Deployment has been created which takes and uploads snapshots of all Kubernetes resources within the cluster to S3.
There are two containers:
cluster-dump-dumper:

Uses kubectl to snapshot all Kubernetes resources (interval of 24 hours).
Each snapshot resides in a timestamped folder
The resources have several fields omitted such as status , uid, etc ... this is to allow the possibility of restoring resources inside a fresh cluster
Resources that reside within namespaces are grouped inside folders labeled with the namespace name
Resources outside namespaces are grouped at the same directory level as the namespace folders

cluster-dump-pusher

Uses aws to upload snapshots to S3
The S3 path is constructed from the S3URI passed into kube-aws binary; a string "/clusterDump/"; and the timestamped folder

Notes:

We decided to use bash as arguments to the containers to avoid any additional docker image dependencies - it makes use of the aws and hyperkube images already defined in cluster.yaml. Also, as the Deployment definition resides on controller nodes but the pods themselves are on worker nodes, storing the bash as separate files did not fell appropriate.

We intend to create a 'restore' script that will deploy resources from snapshot folder into a new cluster. Use Case: We destroy a cluster and recreate it (maybe with new features) but also restore the Kubernetes resources we had originally.

Codecov Report

Merging #507 into master will increase coverage by 0.03%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #507      +/-   ##
==========================================
+ Coverage   38.12%   38.16%   +0.03%
==========================================
  Files          44       44
  Lines        3108     3110       +2
==========================================
+ Hits         1185     1187       +2
  Misses       1729     1729
  Partials      194      194

Impacted Files
Coverage Δ

core/controlplane/cluster/cluster.go
44.03% <100%> (+0.23%)
:arrow_up:

core/controlplane/config/config.go
55.52% <100%> (+0.05%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b0614a8...f95b6cb. Read the comment docs.

Oh, interesting. We're running roughly the same sort of thing but external to the cluster. It's in a pipeline to do blue-green cluster switchovers. It seems like everyone has their own solution to this problem. One relevant issue is at https://github.com/kubernetes/kubernetes/issues/24229.

I'm sorry to go out of topic but,
@c-knowles Btw, how do you treat background-job workers in your blue-green cluster switch-over process?
If your background-job workers are tied to a shared work queue backed by e.g. kafka or sqs, running desired num of background-job workers on BOTH a blue and a green cluster would temporarily increase loads by read requests from 2x background-job workers.
Do you have enough extra capacity on your work queue, or you don't have such services, or else?

So I have never assumed a simple dump&restore would work when you're running long-running jobs involving work queues.
Perhaps, you're willing to use this feature to dump&restore k8s clusters for running periodic(e.g. hourly, daily, weekly, etc) batch jobs so that you can cut your infrastructure cost?

FYI @pieterlange Does this relate to kube-backup?
Would you guys like to work together on this, if your use-cases are similar enough?

@jollinshead Finished reviewing. Perhaps are you willing to add some comments/documentations  according to my review?
If so, please feel free to notify me when you're done and want this to be reviewed again!

@mumoshu You are correct that switchover can increase load on some backend systems such as databases and queues. We're not fully up to speed on all that yet since the systems we use scale well so it's not too big of an issue. The main parts we are actively working on are around "draining" background workers on the older cluster. In cases where the jobs do not need to be complex right away, we can drain the old cluster before we bring up the new cluster. In cases where the jobs need to complete as soon as possible, we generally leave the workers fully running in the old cluster and only turn them off once the new cluster is fully operational. Important to this is that we do not change worker software versions at the same time as cluster switchover (or any software versions actually).

@mumoshu i'd say these efforts are highly related indeed. :+1:
Some general nits:

This is using a deployment that just sleeps for 24h, so you have no real control over when the backups actually happens (as you do with a CronJob, but those have other problems.)
Lots of hardcoding, it's not very configurable which resource types to configure
Exports & stores secrets in plaintext
Strips a lot of metadata & podspec. The metadata is OK to strip as it's mostly cluster generated, but stripping the podspec will affect the application behavior.

In general, if this is how @jollinshead likes to run his backups that's fine but i don't see why this is specific to kube-aws or why it should be included as a default cluster backup option.

This is using a deployment that just sleeps for 24h, so you have no real control over when the backups actually happens (as you do with a CronJob, but those have other problems.)
just delete the pod :) backup happens on first start

Lots of hardcoding, it's not very configurable which resource types to configure
IMHO it is better approach to backup ALL and then have flexibility on a restore side. Thats where you can configure individual namespaces/resources to be restored

i don't see why this is specific to kube-aws or why it should be included as a default cluster backup option.
it makes use of S3 bucket +paths already "dedicated" to cluster so it is just natural to add it to kube-aws. Besides with recent changes to kube-aws clusters often need to be recreated and making a tool to support "recreate cluster, but bring it back as it used to be" makes sense

Can we at least make sure to use KMS to encrypt the secrets in this case?
Looks OK otherwise.

@mumoshu Done

@jollinshead Sorry for the delay in reviewing!
I've read through your work. Though it looks good overall, I've added some nits around the naming - I believe the naming helps us maintain this feature in longer term.
Your thoughts?

Your proposed changes look good to me - I'll notify you once they're implemented.

@mumoshu Done 👍

@pieterlange I believe it will be good to do! As I think it would affect how the "restore" side of this feature works, maybe we can revisit it once the restore side is implemented?

@jollinshead Thanks for the quick turnaround. LGTM 👍


Update process-explorer.md

add help on use of symbol server with procexp.

Docs Build status updates of commit 9bbbc37:
:warning: Validation status: warnings

File
Status
Preview URL
Details

sysinternals/downloads/process-explorer.md
:warning:Warning
View
Details

sysinternals/downloads/process-explorer.md

Line 75, Column 1: [Warning-hard-coded-locale] Link 'https://docs.microsoft.com/en-us/windows-hardware/drivers/debugger/symsrv' contains locale code 'en-us'. For localizability, remove 'en-us' from links to most Microsoft sites.

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel

Docs Build status updates of commit 880df28:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

sysinternals/downloads/process-explorer.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel


demo: adding redis standalone & cluster

Provides 2 deployment flavours:
standalone
single server, with AOF
redis endpoint: redis-standalone:6379
cluster
a master with multiple (3x) replicas.
redis endpoints:

master: redis-master:6379
any of the replicas: redis-replica:6379

This PR fixes #536

@yudaykiran addressed changes 👍

Thanks for the PR @lxfontes :+1: Hope to see more contributions from you.

@lxfontes Thank you so much for your PR contribution! We would like to mention you in our tweets, thanking you for your contribution. Can you please send me your twitter handle on this mail ID<EMAIL_ADDRESS>?


Conversion aborted

I get this error during conversion of xlsx file:
root@server:/storage/source/document2html-master/src# ./document2html -f ./data/7.xlsx -o ./testData document2html: libs/fileext/excel/../../pugixml/pugixml.cpp:6718: pugi::xml_node& pugi::xml_named_node_iterator::operator*() const: Assertion _wrap._root' failed.
Aborted`
Is there any way to handle this?
OS: Ubuntu 14.04
GCC: 5.4.1

File which causes the exception
Таблица расчета Н(М)ЦК.xlsx

Please check this patch: 6f90b6404cd4833827059ad505dbe32140503f62

Thank you for paying attention to this problem, but conversion still crashes on the same file (with different error).
root@file2:/storage/source/document2html/src# ./document2html -f ./data/Таблица\ расчета\ Н\(М\)ЦК.xlsx  -o test document2html: libs/fileext/excel/../../pugixml/pugixml.cpp:6730: const pugi::xml_named_node_iterator& pugi::xml_named_node_iterator::operator++(): Assertion _wrap._root' failed.
Aborted`
Sometimes conversion crashes with this error:
document2html: libs/fileext/excel/../../pugixml/pugixml.cpp:6718: pugi::xml_node& pugi::xml_named_node_iterator::operator*() const: Assertion _wrap._root' failed.
Aborted`
But unfortunately I could not determine which file caused.

Confirmed. My mistake - i shouldn't put variable childrenCount out of the loop. Please check 9c24aa05e9c80fd5a4379e00f9a67d8d336990c9. Your file was successfully converted on two my machines

Thank you very much for your help! Everything works now, I shall reopen this issue if we encounter this sort of exception again.


pgfutter gets killed when uploading large csv file

Hi,
When trying to upload a 1.87GB csv file with a few million rows through pgfutter, around 40% in of the upload it fails without much information:
 756.80 MB / 1.87 GB [==============================================================================================================================================================================>-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------]  39.62% 45s    74 Killed                  pgfutter --pw $dbpw --schema public --table my_upload_table csv upload.csv

Is there something like a verbose option to better troubleshoot and see why it is failing?
I think it could be a wrong formatted row in my csv file and/or OOM. Help appreciated.
Best,
FB

think i'm hitting a similar issue https://github.com/lukasmartinelli/pgfutter/issues/42

I think I have hit a similar issue, the csv file itself is not huge, its only 55MB, it does have 84 columns though. The end result after the run is that is just lists the names of all 84 columns (without the next two lines of size of data and % of completion missing)


add simple javascript matrix

simple code to generate javascript matrix 2D

What a great code :smile: !
Thank you for contributing! :rocket:


Other asset operating dependencies (fuel, electricity, etc) – C/T

Part of Asset Inventory: Asset Data Requirements


cdn2.editmysite.com

This is just a CDN for editmysite.com

Whitelisted, thanks for reporting it. Sorry for causing so many false postives

No problems!


SuperFamily Link

After talking to Arun from SuperFamily, he suggested using this URL. Based on issue #121

npm will need to be started to update binary

Cheers!


Being maintained?

Is this project being maintained or is it now left by the wayside.
I am trying to choose between https://github.com/jpoirier/rust-rtlsdr, https://github.com/adamgreig/rtlsdr-rs and https://github.com/kchmck/rtlsdr_sys.rs as a possible choice for a Rust rewrite of some C code that uses librtlsdr.

Hey @russel
No, sorry, I'm not doing any Rust development at the moment but pull requests are always appreciated.
Note that if you go with the @adamreig wrapper (I recommend that you do) and want to use async IQ data streaming you'll need to add it to the wrapper, which should be a trivial update-you're welcome to copy and paste any code you'd like to from my wrapper.
On a side note, the original rtlsdr c lib is here http://cgit.osmocom.org/rtl-sdr/ but it's rarely updated and I'd encourage you to use and contribute to the updated and maintained fork here https://github.com/librtlsdr/librtlsdr
cheers,
joe

@jpoirier Thanks for replying. Quite rare that people suggest using competitor products. ;-)
Debian and Fedora both seem to package the original from OsMoCom. It is a pity that the OsMoCom repository is not seeming to take things from the maintained fork. May they are or can be persuaded to. More investigation needed.

Hi @russel
I have a Go rtl-sdr wrapper that I actively maintain and the rust and nim wrappers were put together mainly for learning purposes.
Best of luck on the osmocom endeavor.

Bug report posted about the Debian librtlsdr https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=854378
Are you wrapping https://github.com/librtlsdr/librtlsdr ?

Thanks for doing the bug report. The librtlsdr/librtlsdr library and the one at osmocom are interchangeable and I wrap just the original API at the moment. Disclaimer - I created the https://github.com/librtlsdr/librtlsdr fork.

Clearly this is a "not inactive" project ;-) so original question answered, answer "yes". So I will close this issue. It is not certain which of the Rust bindings will be used as all three are effectively active and maintained.


wp-content/plugins/ directory is created when installing birgire/geo-query via Composer

I'd like to use geo-query as a dependency for a plugin that I develop, but if birgire/geo-query is installed via Composer then wp-content/plugins/ directory is created. Is it intentional? I would expect the dependency to be downloaded to the composer vendor/geo-query - this is a standard approach.

Hi @wujekbogdan
Where is wp-content/plugins created in your case?
I wonder if it's because I've "type":"wordpress-plugin" in the composer.json ?

Where is wp-content/plugins created in your case?

wp-content/plugins is created in the same directory where composer install command is executed.
├─── composer.json
├─── vendor
└─── wp-content
    └─── plugins
        └─── geo-query

I wonder if it's because I've "type":"wordpress-plugin" in the composer.json?

You are probably right, this is a composer/installers feature.  Here's an article on this topic.

Thanks for the links.
I already require composer/installer, so maybe you could change the installer-paths, in the extra section, in your main  composer.json file? Something like:
{
    "extra": {
        "installer-paths": {
            "your/custom/path/{$name}/": ["birgir/geo_query"]
        }
    }
}

https://getcomposer.org/doc/faqs/how-do-i-install-a-package-to-a-custom-path-for-my-framework.md

I already require composer/installers

Yes, I know. But maybe you shouldn't use it? What's the benefit of using it? It looks like the installer causes that "issue".

I have now added birgir/geo-query as a package on packagist.com:
https://packagist.org/packages/birgir/geo-query
I just did a tried a test plugin, that uses birgir/geo-query as a dependency.
The test plugin has the following composer.json file:
{
  "name": "birgir/test-plugin",
  "require": {
    "birgir/geo-query": "~0.0.5"
  },
  "extra": {
        "installer-paths": {
            "vendor/{$name}/": ["birgir/geo-query"]
        }
    }
}

This seems to work as expected and generates:
composer.json
composer.lock
vendor/
   autoload.php
   composer/
       birgir/
           geo-query/

instead of
composer.json
composer.lock
vendor/
   autoload.php
   composer/
wp-content/
    plugins/
        geo-query/

If I would not use the "wordpress-plugin" type and the composer/installers, what options would we have to install it to wp-content/plugins from a main site composer.json?
Maybe I should try and look for a WordPress plugin that is used both as a vendor library and a plugin, to see how it's usually done. (don't remember such a plugin at the moment)
ps: I'm just trying to understand the limitations and avoid "burning" any bridges ;-)

Thank you very much. I'll add an extra entry to my composer.json file for now. It's a workaround, but I can live with that :)

If I would not use the "wordpress-plugin" type and the composer/installers, what options would we have to install it to wp-content/plugins from a main site composer.json?

Sadly I have no idea and I'm afraid I can't help you. I'm just a Composer user. I never made a composer public package.
You can try to have a look at Timber (a great tool by the way), they have a composer-compatible version and a WordPress plugin too.

great, thanks @wujekbogdan  I've heard about Timeber but not used it.
I will checkout Timber and try to learn how they do it.
I will mark this thread as resolved in the meanwhile ;-)
Thanks for the heads up, I learned from it ;-)


Location.GetMappedLineSpan returns file path with forward slash as directory separator

Version Used: 4.6.0
Steps to Reproduce:

Call Location.GetMappedLineSpan for a SyntaxNode that will map back to a different file.
Even if the original file on disk has backslashes as a directory separator (windows environment) the returned path will contain forward slashes.

Why this is a problem?
When an issue is reported with this path containing forward slashes, Visual Studio will not show the path correctly. It will instead point to the project file.
Expected Behavior:
The directory separator matches the one of the operating system.
Actual Behavior:
The directory separator is not matching the one on the operating system.
This behaviour was reproduced while analyzing razor generated files.

@csaba-sagi-sonarsource Thanks for the additional information. The question is what caused the razor source generator to produce different outputs in design-time vs. build-time scenarios.
Tagging @jasonmalinowski in case he can advise on how to capture binary logs to figure this one out.

I'd definitely not expect this. The paths should be exactly the same. Seems like a bug.

If this is the design-time build then a binlog won't happen anyways since those files never hit disk (or exist in the command line build in the first place!) But razor repo is right for this.

Hmm, this is interesting, because the compiler isn't actually controlling those paths. We just print out whatever the syntax tree path is.
For the source generator, the compiler 'owns' the project items, and we use the file system path, which is passed into the syntax tree. For design time the project items are 'owned' by the tooling. For reasons unclear to me they are normalized to use forward slashes.
@davidwengier Do you have any insight into why the file paths are normalized in the razor project system? I could feasibly un-normalize the file paths in design time, but want to understand it a little more before we do that. Are the paths actually used for anything? I would have assumed they were an opaque identifier?

Not sure I know the full story of "why" I'm afraid, normalizing paths is just something Razor does and sometimes it causes issues, and there are a couple of places where we un-normalize them to "work around issues" too.
The file paths are definitely used though, as the unique identifier for a document. I wonder if its related to the fact that at design time there are two worlds that are competing: for open documents, the language server is in charge and all talk of documents is done via Uri, and for closed documents, in VS at least, the VS-side components are in charge so would naturally use file system paths. Or alternatively, maybe its to allow LiveShare to work, where server and client could be on different OSes? Either way, I wouldn't be surprised if there aren't better approaches, I don't think its been looked at.

Ok, thanks for the heads up. As we're late in a few cycles, and I am a chicken, I'm going to just unnormalize the paths in design time, but I'll open an issue to track us resolving this correctly across everything. We're going to have to fix it whether we like it or not if we get rid of runtime/design time split.

Closed via https://github.com/dotnet/razor/pull/9354


BIDS 2.0

Title
BIDS 2.0
Short description and the goals for the OHBM BrainHack

triage more issues from https://github.com/bids-standard/bids-2-devel/issues : categorize into ToDo, Punted (close), BIDS 3.0
progress forward on "ToDo" or "In Progress" items of the BIDS 2.0 project: https://github.com/orgs/bids-standard/projects/10, in particular (but not limited to)

https://github.com/bids-standard/bids-specification/pull/1775
https://github.com/bids-standard/bids-specification/pull/1809

Link to the Project
https://bids.neuroimaging.io
Image/Logo for the OHBM brainhack website
https://github.com/bids-standard/animated-bids-logo/blob/master/bids-animated.gif
Project lead
Yaroslav O. Halchenko @yarikoptic discord: yarikoptic
Main Hub
Seoul
Link to the Project pitch
No response
Other hubs covered by the leaders

[X] Seoul
[ ] Hybrid (Asia / Pacific)
[ ] Hybrid (Europe / Middle East / Africa)
[ ] Hybrid (Americas)

Skills

BIDS and  BIDS schema to help triaging issues, deciding on the direction to proceed, and implementing the changes
Tech writing to ensure best language to express ideas
Python programming for https://github.com/bids-standard/bids-specification/tree/master/tools/schemacode tune ups

adjustments to schema handling
improving migration code
extending testing

TypeScript programming  for https://github.com/bids-standard/bids-validator tune ups to deno flavor of the validator

Recommended tutorials for new contributors

https://bids-standard.github.io/bids-starter-kit/

Good first issues
No response
Twitter summary
No response
Short name for the Discord chat channel (~15 chars)
bids-2.0
Please read and follow the OHBM Code of Conduct

[X] I agree to follow the OHBM Code of Conduct during the hackathon

@yarikoptic Thanks for submitting this amazing project. We encourage including a short Twitter summary along with your project submission for us to be able to promote the project during the brainhack. Apart from that, all is good to go!
Looking forward to seeing you in Seoul.


Problem with long strings

Hi. Thanks again for this app.
On spanish translation some strings are longer than on english that causes that some strings doesn't fit correctly like on the image:

I don't know if some wrapping text mode could solve this problems...

Hey, thanks for the feedback. I can add word wrapping, but if possible I would like to avoid it. Maybe we can make the text shorter? E.g. something like "Actualizar los pases al iniciar la aplication"?
Let me check how it looks with word wrapping enabled. Maybe it doesn't look that bad.

Ok @patrickjane let me know the results and if it doesn't looks fine I'll try to change the translation ;-)

Okay I think its okay with word wrap mode. I have just published an update. Can you install it and check if it works well for you?


TODO Task: SHORT TERM Check and fix potential vulnerabilities:

Check and fix potential vulnerabilities: Link is non-existent, so please clarify whether or not is a Active Task or Not.

Hi @iamhardikat11
https://github.com/karask/python-bitcoin-utils/security/dependabot/2
I just did a quick investigation and the library will not solve minerva timing attacks. This is a difficult task and I will update the TODO accordingly.


Delete user via settings UI

At present, it's possible to delete a user via the manage.py command). It would be helpful to have this functionality available from the webapp UI as well.
Previous issue for this request: #10533

Hi folks,
Any update with this feature?

No updates.
Can you say a bit why you're interested in using this feature, as opposed to deactivating users?

@alya
Should we add another check box to confirm if admin wants to delete the user?
If the checkbox is checked, the button changes from deactivate to delete. Is this UI appropriate?

Hm, that could work. If done this way, we'd need to update the buttons for getting to this UI to indicate that it's also a way to delete the user (on the button or in tooltips).
We'd also need to update the modal to briefly explain the difference, and link to the help center.
I'm not sure what's best -- this approach vs. offering a separate button/menu item/modal. It should be discussed in #design prior to implementation.


could you tell me how to run your source code ?

i use "electron .", but just show a blank window, could you tell me how to run your source code ?

Hi!
Do you have Node installed on your computer? Have you seen this section for running it locally?
https://github.com/jlord/git-it-electron/blob/master/CONTRIBUTING.md#building-locally

thank you so much for your answer!
now could i ask you another question?
Is electron able to setup a suspension window? such as a little square window on top of all windows to show downloading progress. usually used by some download software

Yep, you could do that with Electron.
Since this isn't a question about git-it in particular, I'll close this issue. Good luck!


Prosit Download showing server issues

{"error":"Error: HttpClient.getResponse: Can't get the response from the server: IPCon error: "Connection to <IP_ADDRESS> lost while reading response.""}

Greetings @tkschmidt,
I am also facing a similar issue - {"error":"Error: HttpClient.getResponse: Can't get the response from the server: IPCon error: "Connection to <IP_ADDRESS> lost while reading response.""}
Please do advise me on how to download my data. Lastly, thank you in advance for your assistance.
Regards,
Ben

Hey Ben and Subina,
This is usually due to issues with the size of the downloadable file if it's bigger than 2 GB, this process would fail.
Try splitting your input this should help with this issue.
Best,
Wassim


Question about the preprocess of LSMDC-FiB dataset

Hi, I have read your paper "FrozenBiLM". I have several question about the preprocess of LSMDC-FiB dataset. Since I noticed that there are some blanks only contains a part of the word. For example "I went to the place w___e I live." The answer would be "her". Therefore, there exists a problem that the semantic meaning of the question have been destroyed. I am wondering how do you treat these type of questions?
Thanks.

Yes.

Thanks.


Add a license to the repository

I recently came across your project QVNE and I noticed that the repository github.com/yasamanparhizkar/QVNE currently does not have a license specified.
Why Adding a License is Important?
As GitHub documents

Public repositories on GitHub are often used to share open source software. For your repository to truly be open source, you'll need to license it so that others are free to use, change, and distribute the software.

Would be possible to add a valid license to this repository? Probably something really OpenSource such as the Apache 2.0 license would fit really well.
Thanks!

Hi,
Added the Apache 2.0 license.
Thanks for your comment!

Thanks!


Allow custom data attributes

Our project required passing custom data-* values to the html node (instead of id and value).
This update attaches all values to the element dataset and allows you to select which of these to filter these via the dataAttributes options.

Thanks, I have updated the readme with the suggested changes.
Wasn't sure on the naming of the option dataAttributes, but if you're happy with it I will leave it as is.

+1

It would be great if we could have custom html instead.

Can you give me an example of what you would like to do? I can take a look

It would be great if we could have custom html instead.

Can you give me an example of what you would like to do? I can take a look

It would be great if we could have custom html instead.

Can you give me an example of what you would like to do? I can take a look

It would be great if we could have custom html instead.

Can you give me an example of what you would like to do? I can take a look

@10chars something where the pasted html can be a template or a passed string liked
item.value

Thanks for the example @shyamal890
Just a quick note item_id is invalid html. Data should be held in standard html data-attributes.
Do you have a specific use case in mind when wanting custom html?  e.g non inline etc
With the changes in this PR included, users already have the following options available for customization.

Override styles using the mention class for custom styling
Specify whether or not to wrap mentions in an a tag by providing the link field in the data.
Specify any number of custom attributes

One addition I can see that might be useful is to give users a custom on-click option. custom html maybe a little overkill unless you would like people to use this plugin for something other than standard mentions.
Any thoughts?

My point is custom html would just open up the possibilities for developers. Think in Angular/React having something like Something<custom-element></custom-element>

I think having custom html opens up possibilities for developers to do what they want. Apply their own classes, create custom elements, etc.

@shyamal890 I'm happy to look at add templating option, but I think you have to consider the plugin objectives, i.e - mentioning users
For me, the expected functionality for a mentions/hashtags plugin is fairly straight forward, select one string value from a list of options and insert that content into the content as inline text.
If people want to create "custom elements", they don't need a mention plugin, they need an insert html element plugin.

I agree with you @10chars. I will try to merge this tomorrow. Thank you for your contribution!


missing get_comment function, code below

def get_comment(self, resource: str):
params = {"apikey": self.API_KEY, "resource": resource}
resp = self.make_request(
f"{self.BASEURL}comments/get", params=params, method="GET", proxies=self.PROXIES
return resp

Hello @18thirtysix
In the previous update I was planning on adding this endpoint however, with the standard API key I cannot get the endpoint to return a successful 200 response. I receive a 403 which is a forbidden permissions error.
Are you using a standard API key with no special privileges?

I have an Enterprise API Key (Must have the private key for the function to return a 200 response), I needed the get_comment function for what I am doing. Great Job on the module btw!

get_comment('www.google.com')
{'json_resp': {'comments': [{'comment': 'Has a policy of stealing personal and '
'confidential information. Treat with '
'caution. F*** Google.',
'date': '20190530033222'},
{'comment': 'Joe Sandbox Analysis: \n'
'\n'
'Detection: CLEAN\n'
'Score: 1/100\n'
'Classification: '
'clean1.win@3/537@20/6\n'
'Domains: pagead46.l.doubleclick.net '
'dart.l.doubleclick.net '
'partnerad.l.doubleclick.net '
'stats.l.doubleclick.net '
'photos-ugc.l.googleusercontent.com '
'www.google.ch '
'googlehosted.l.googleusercontent.com '
'about.google '
'securepubads.g.doubleclick.net '
'yt3.ggpht.com i.ytimg.com '
'ad.doubleclick.net '
'lh6.googleusercontent.com '
'adservice.google.ch '
'pubads.g.doubleclick.net '
'lh3.googleusercontent.com '
'static.doubleclick.net '
'stats.g.doubleclick.net '
'lh5.googleusercontent.com '
'googleads.g.doubleclick.net '
'accounts.youtube.com www.youtube.com '
'news.google.ch '
'lh4.googleusercontent.com '
'maps.google.ch s.ytimg.com \n'
'Hosts: <IP_ADDRESS> <IP_ADDRESS> '
'<IP_ADDRESS> <IP_ADDRESS> '
'<IP_ADDRESS> <IP_ADDRESS> \n'
'\n'
'HTML Report: '
'https://www.joesandbox.com/analysis/118110/0/html\t\n'
'PDF Report: '
'https://www.joesandbox.com/analysis/118110/0/pdf\n'
'Executive Report: '
'https://www.joesandbox.com/analysis/118110/0/executive\n'
'Incident Report: '
'https://www.joesandbox.com/analysis/118110/0/irxml\n'
'IOCs: '
'https://www.joesandbox.com/analysis/118110?idtype=analysisid\n'
'\t',
'date': '20190321014646'},
{'comment': 'somehow i dont know how google\n'
'\n'
'have some people that say its unsafe '
'lol',
'date': '20181221091849'},
{'comment': 'Safe url!', 'date': '20180923082158'},
{'comment': '[b]Safe Link[/b]\n'
'\n'
'[u]google.com[/u]\n'
'\n'
'Anyone who has problems has to only '
'download an antivirus (AVG, '
'BitDefender, Avast,  etc) to their '
'computer. The antiviruses I '
'recommended either have their own '
'safe browser or block bad webpages in '
'realtime (BitDefender is both).',
'date': '20180909145045'},
{'comment': 'Have seen phishing campaign '
'with URL\n'
'http://www.google.com/#btnI=1h8uq2z-60ydl2b-my7q00ue&q=txjkorkepq\n'
'Redirects to\n'
'http://txjkorkepq.ml/\n'
'Something nefarious going on here.',
'date': '20180730060655'},
{'comment': 'This webpage is safe.\n'
'\n'
'Possible explanations for CleanMX '
'detection:\n'
'\n'
'1) False Positive detection\n'
'\n'
'2) CleanMX found that the website '
'collects data. This is true. In a way '
'Google [b]IS [/b]Phising. However, '
'google uses this information to '
'personalize ads.\n'
'\n'
' \n'
'\n'
'I personally believe that CleanMX is '
'scanning very sensitively. In fact, '
'most search engines do this as they '
'can collect data for ads. The only '
'problem is that this information '
'could be sent to 3rd parties without '
'end-to-endencryption, which can be '
'very unsafe as it can easily be '
'hacked.',
'date': '20180728031146'},
{'comment': 'Google is safe, so [b]THE CREATORS OF '
'CLEAN MX ARE DUMB[/b]',
'date': '20180722054733'},
{'comment': 'Joe Sandbox Analysis: \n'
'\n'
'Detection: CLEAN\n'
'Score: 1/100\n'
'Classification: '
'clean1.win@5/501@42/21\n'
'Domains: googleapis.l.google.com '
'partnerad.l.doubleclick.net '
'googlemail.l.google.com '
'cs9.wac.phicdn.net '
'pagead46.l.doubleclick.net '
'news-cctld.l.google.com '
'plus.l.google.com www.google.com '
'stats.l.doubleclick.net '
'googlehosted.l.googleusercontent.com '
'ssl-google-analytics.l.google.com '
'cs9.wpc.v0cdn.net '
'gstaticadssl.l.google.com '
'static-doubleclick-net.l.google.com '
'a767.dspw65.akamai.net '
'play.google.com news.l.google.com '
'consent.google.com ssl.gstatic.com '
'payments.google.com maps.gstatic.com '
'www3.l.google.com '
'a1363.dscg.akamai.net '
'ytimg-edge-static.l.google.com '
'maps-cctld.l.google.com '
'accounts.google.com '
'photos-ugc.l.googleusercontent.com '
'a1621.g.akamai.net www.gstatic.com '
'www-google-analytics.l.google.com '
'r4.sn-1gi7znes.googlevideo.com '
'www-googletagmanager.l.google.com '
'googleadapis.l.google.com '
'clients.l.google.com '
'ytstatic.l.google.com '
'youtube-ui.l.google.com www.google.ch '
'clients2.google.com news.google.com '
'i.ytimg.com stats.g.doubleclick.net '
'www.youtube.com '
'r4---sn-1gi7znes.googlevideo.com '
'myaccount.google.com mail.google.com '
'lh4.googleusercontent.com '
'apis.google.com '
'googleads.g.doubleclick.net '
'crl.pki.goog books.google.com '
'lh3.googleusercontent.com '
'yt3.ggpht.com news.google.ch '
'ocsp.pki.goog fonts.googleapis.com '
'maps.google.ch ajax.googleapis.com '
's.ytimg.com lh6.googleusercontent.com '
'adservice.google.ch '
'lh5.googleusercontent.com '
'static.doubleclick.net '
'fonts.gstatic.com '
'securepubads.g.doubleclick.net '
'pubads.g.doubleclick.net '
'adservice.google.com \n'
'Hosts: <IP_ADDRESS> <IP_ADDRESS> '
'<IP_ADDRESS> <IP_ADDRESS> '
'<IP_ADDRESS> <IP_ADDRESS> '
'<IP_ADDRESS> <IP_ADDRESS> '
'<IP_ADDRESS> <IP_ADDRESS> '
'<IP_ADDRESS> <IP_ADDRESS> '
'<IP_ADDRESS> <IP_ADDRESS> '
'<IP_ADDRESS> <IP_ADDRESS> '
'<IP_ADDRESS> <IP_ADDRESS> '
'<IP_ADDRESS> <IP_ADDRESS> '
'<IP_ADDRESS> \n'
'\n'
'HTML Report: '
'https://www.joesandbox.com/analysis/66924/0/html\t\n'
'PDF Report: '
'https://www.joesandbox.com/analysis/66924/0/pdf\n'
'Executive Report: '
'https://www.joesandbox.com/analysis/66924/0/executive\n'
'Incident Report: '
'https://www.joesandbox.com/analysis/66924/0/irxml\n'
'IOCs: '
'https://www.joesandbox.com/analysis/66924?idtype=analysisid\n'
'\t',
'date': '20180705170822'},
{'comment': 'Probably one of the most popular '
'search engines. While Google itself '
'is safe, some of the sites that '
'appear in results might not be the '
'safest. Safe!',
'date': '20180426203004'},
{'comment': '[b]Google LLC[/b]<sup id="cite_ref-5" '
'class="reference">[url=https://en.wikipedia.org/wiki/Google#cite_note-5][5][/url] '
'is an American multinational '
'technology company that specializes '
'in Internet-related services and '
'products, which include online '
'advertising technologies, search '
'engine, cloud computing, software, '
'and hardware. Google was founded in '
'1998 by '
'[url=https://en.wikipedia.org/wiki/Larry_Page]Larry '
'Page[/url] and '
'[url=https://en.wikipedia.org/wiki/Sergey_Brin]Sergey '
'Brin[/url] while they were Ph.D. '
'students at '
'[url=https://en.wikipedia.org/wiki/Stanford_University]Stanford '
'University[/url], '
'[url=https://en.wikipedia.org/wiki/California]California[/url]. '
'Together, they own about 14 percent '
'of its shares and control 56 percent '
'of the stockholder voting power '
'through supervoting stock. They '
'incorporated Google as a privately '
'held company on September 4, 1998. An '
'Initial public offering (IPO) took '
'place on August 19, 2004, and Google '
'moved to its new headquarters in '
'Mountain View, California, nicknamed '
'the '
'[url=https://en.wikipedia.org/wiki/Googleplex]Googleplex[/url]. '
'In August 2015, Google announced '
'plans to reorganize its various '
'interests as a conglomerate called '
'[url=https://en.wikipedia.org/wiki/Alphabet_Inc.]Alphabet '
"Inc.[/url] Google, Alphabet's leading "
'subsidiary, will continue to be the '
"umbrella company for Alphabet's "
'Internet interests. Upon completion '
'of the restructure, '
'[url=https://en.wikipedia.org/wiki/Sundar_Pichai]Sundar '
'Pichai[/url] was appointed '
'[url=https://en.wikipedia.org/wiki/Chief_executive_officer]CEO[/url] '
'of Google, replacing Larry Page, who '
'became the CEO of Alphabet.\n'
'\n'
"The company's rapid growth since "
'incorporation has triggered a chain '
'of products, acquisitions, and '
"partnerships beyond Google's core "
'search engine '
'([url=https://en.wikipedia.org/wiki/Google_Search]Google '
'Search[/url]). It offers services '
'designed for work and productivity '
'([url=https://en.wikipedia.org/wiki/Google_Docs,Sheets,and_Slides]Google '
'Docs, Sheets, and Slides[/url]), '
'email '
'([url=https://en.wikipedia.org/wiki/Gmail]Gmail[/url]/[url=https://en.wikipedia.org/wiki/Inbox_by_Gmail]Inbox[/url]), '
'scheduling and time management '
'([url=https://en.wikipedia.org/wiki/Google_Calendar]Google '
'Calendar[/url]), cloud storage '
'([url=https://en.wikipedia.org/wiki/Google_Drive]Google '
'Drive[/url]), social networking '
'([url=https://en.wikipedia.org/wiki/Google%2B]Google+[/url]), '
'instant messaging and video chat '
'([url=https://en.wikipedia.org/wiki/Google_Allo]Google '
'Allo[/url]/[url=https://en.wikipedia.org/wiki/Google_Duo]Duo[/url]/[url=https://en.wikipedia.org/wiki/Hangouts]Hangouts[/url]), '
'language translation '
'([url=https://en.wikipedia.org/wiki/Google_Translate]Google '
'Translate[/url]), mapping and '
'turn-by-turn navigation '
'([url=https://en.wikipedia.org/wiki/Google_Maps]Google '
'Maps[/url]/[url=https://en.wikipedia.org/wiki/Waze]Waze[/url]/[url=https://en.wikipedia.org/wiki/Google_Earth]Earth[/url]/[url=https://en.wikipedia.org/wiki/Street_View]Street '
'View[/url]), video sharing '
'([url=https://en.wikipedia.org/wiki/YouTube]YouTube[/url]), '
'note-taking '
'([url=https://en.wikipedia.org/wiki/Google_Keep]Google '
'Keep[/url]), and photo organizing and '
'editing '
'([url=https://en.wikipedia.org/wiki/Google_Photos]Google '
'Photos[/url]). The company leads the '
'development of the '
'[url=https://en.wikipedia.org/wiki/Android(operating_system)]Android[/url] '
'mobile operating system, the '
'[url=https://en.wikipedia.org/wiki/Google_Chrome]Google '
'Chrome[/url] web browser, and '
'[url=https://en.wikipedia.org/wiki/Chrome_OS]Chrome '
'OS[/url], a lightweight operating '
'system based on the Chrome browser. '
'Google has moved increasingly into '
'hardware; from 2010 to 2015, it '
'partnered with major electronics '
'manufacturers in the production of '
'its '
'[url=https://en.wikipedia.org/wiki/Google_Nexus]Nexus[/url] '
'devices, and in October 2016, it '
'released multiple hardware products '
'(including the '
'[url=https://en.wikipedia.org/wiki/Pixel(smartphone)]Google '
'Pixel[/url] smartphone, '
'[url=https://en.wikipedia.org/wiki/Google_Home]Home[/url] '
'smart speaker, '
'[url=https://en.wikipedia.org/wiki/Google_Wifi]Wifi[/url] '
'mesh wireless router, and '
'[url=https://en.wikipedia.org/wiki/Google_Daydream#Headset]Daydream '
'View[/url] virtual reality headset). '
'The new hardware chief, Rick '
'Osterloh, stated: "a lot of the '
'innovation that we want to do now '
'ends up requiring controlling the '
'end-to-end user experience". Google '
'has also experimented with becoming '
'an Internet carrier. In February '
'2010, it announced '
'[url=https://en.wikipedia.org/wiki/Google_Fiber]Google '
'Fiber[/url], a fiber-optic '
'infrastructure that was installed in '
'Kansas City; in April 2015, it '
'launched '
'[url=https://en.wikipedia.org/wiki/Project_Fi]Project '
'Fi[/url] in the United States, '
'combining Wi-Fi and cellular networks '
'from different providers; and in '
'2016, it announced the Google Station '
'initiative to make public Wi-Fi '
'available around the world, with '
'initial deployment in India.\n'
'\n'
'[url=https://en.wikipedia.org/wiki/Alexa_Internet]Alexa[/url], '
'a company that monitors commercial '
'web traffic, lists Google.com as the '
'most visited website in the world. '
'Several other Google services also '
'figure in the top 100 most visited '
'websites, including '
'[url=https://en.wikipedia.org/wiki/YouTube]YouTube[/url] '
'and '
'[url=https://en.wikipedia.org/wiki/Blogger_(service)]Blogger[/url]. '
'Google is the most valuable brand in '
'the world as of 2017,<sup '
'id="cite_ref-6" '
'class="reference">[url=https://en.wikipedia.org/wiki/Google#cite_note-6][6][/url] '
'but has received significant '
'[url=https://en.wikipedia.org/wiki/Criticism_of_Google]criticism[/url] '
'involving issues such as '
'[url=https://en.wikipedia.org/wiki/Privacy_concerns_regarding_Google]privacy '
'concerns[/url], '
'[url=https://en.wikipedia.org/wiki/Criticism_of_Google#Aggressive_tax_avoidance]tax '
'avoidance[/url], '
'[url=https://en.wikipedia.org/wiki/Criticism_of_Google#Antitrust]antitrust[/url], '
'[url=https://en.wikipedia.org/wiki/Censorship_by_Google]censorship[/url], '
'and '
'[url=https://en.wikipedia.org/wiki/Criticism_of_Google#Page_Rank]search '
"neutrality[/url]. Google's "
'[url=https://en.wikipedia.org/wiki/Mission_statement]mission '
'statement[/url], from the outset, was '
'"to organize the world's information '
'and make it universally accessible '
'and useful", and its unofficial '
'slogan was '
'"[url=https://en.wikipedia.org/wiki/Don%27t_be_evil]Don't '
'be evil[/url]". In October 2015, the '
'motto was replaced in the Alphabet '
'corporate code of conduct by the '
'phrase [i]"Do the right thing"[/i], '
'while the original one was retained '
'in the code of conduct of Google.',
'date': '20180310112800'},
{'comment': 'THE TROLLS ARE OVER 9000! \n'
'\n'
' \n'
'\n'
'the website is safe.',
'date': '20171224030646'},
{'comment': 'Totally a [u][b][i]VIRUS[/i][/b][/u]\n'
'\n'
' \n'
'\n'
' \n'
'\n'
' \n'
'\n'
' \n'
'\n'
' \n'
'\n'
' \n'
'\n'
'JK [u][i][b]LOL[/b][/i][/u]',
'date': '20171130213045'},
{'comment': 'This is not a virus. To the people '
'who voted virus just kill '
'yourself.[b] REALLY[/b]',
'date': '20170920140305'},
{'comment': 'Google is a popular search engine, in '
'their own words:\n'
'\n'
"[i]Search the world's information, "
'including webpages, images, videos '
'and more. Google has many special '
'features to help you find exactly '
"what you're looking ...[/i]\n"
'\n'
'You may learn more about the company '
'behind it at: '
'http://en.wikipedia.org/wiki/Google\n'
'\n'
'#goodware #benign',
'date': '20141202174219'}],
'resource': 'www.google.com',
'response_code': 1,
'verbose_msg': 'Resource found, comments, if any, returned '
'here'},
'status_code': 200}

Hmmm 🤔 , I'm not sure about implementing the endpoint. Currently, the wrappers primary design philosophy is to cover only the Public API endpoints.

No problem, just thought I would share.
If you wanted to you could add it and comment above """...Private API ONLY...""" It may not be used, but if someone needs it, its at least available.

No problem, just thought I would share.
If you wanted to you could add it and comment above """...Private API ONLY...""" It may not be used, but if someone needs it, its at least available.

Thanks for you're understanding. I will definitely take this into consideration. The usage of Private API only could be added to the docstring and examples. Furthermore, implementing this endpoint would mean implementing the other Private API endpoints as well making the wrapper for Public & Private API consumption (Cover the entire API).

You will have the ultimate Python3 VT API Module, good job again!

Last thing, if you need me to test any of the private api features let me know.

Cool will do. Also, I feel there are still a few issues with the API documentation which I may wait for VT to fix. For example, on the url_report page it doesn't discuss how the API accepts 4 urls (per standard rate) separated by \n. Whereas, the previous documentation highlighted this.


Provide the Che tenant migration tool as a dsaas service

Can one of the admins verify this patch?

Thanks for this information @ibuziuk. I wasn't aware of this requirement

yeah, if saas_service_name is not specified git_repo must match dsaas service name https://github.com/openshiftio/saas-openshiftio

lgtm

@l0rd  could you help in merging this PR please ?

Great ! Thanks @l0rd !


Shelly testnet block sync suddenly slows down at epoch 22

any idea what could cause that?
I have reproduced the problem 5 or 6 times.
Every time the node starts downloading blocks very fast
then at epoch 22 it suddenly slows down.

@willcbanks sounds like you're confusing somethinf. If you're using STN network we're in epoch 25 and when you raised the issue we'd have been in epoch 22.
So you see blocks as they're made :)

From what is said, this is normal behaviour.  Historic blocks will be synced quickly, then new blocks will be recorded as they are created in real time.  When you start the node having run it before, it will use its local database of historic blocks before attaching to the network to obtain the newly created blocks.


pipenv subshell doesn't instantiate if output framing is active

If frames are active, when trying to activate a pipenv subshell the system pauses for around 30 seconds, then prompts a success-frame but never activates the (pipenv) subshell.

If frames are turned off everything works fine

I'm on Ubuntu 18.04 with extraterm 0.48

This looks like some kind of "bash running inside bash" type compatibility problem.

I remember the shell integration being fixed to be more careful about when it runs, i.e. only for interactive shells. I suspect this fixes the problem.


Full screen (chromeless)

Can we get webview to go full screen? From the issue below, it seems the SetFullScreen method was removed. But is there an alternative you know of?
https://github.com/webview/webview/issues/458
I'd love to use this library, but my app needs to support kiosk mode.

Okay, that's what I expected. I will look into it to see if I can make it work. Thanks for the quick reply!


[Errno 1] Operation not permitted: '/Volumes/jamf/Packages/ApE-3.1.2.pkg'

I don't know exactly when this changed but JamfPackageUploader quit working for me a while ago and I'm finally getting around to figuring it out. It's because of macOS Mandatory Access Controls. I've discovered you can tell when it's MAC vs Unix permissions by the exact error. Permission denied is Unix permissions. "Operation not permitted" is MAC. It turned out this was affecting me because I was running autopkg over ssh and, as I said earlier, I don't know when it changed but "sshd-keygen-wrapper" quit being selected by default in "Full Disk Access" in the Security & Privacy pref pane. I'm using ssh because this is being run as part of a CI/CD workflow (using Tart).
I guess I'm filing this issue to suggest better error reporting. This is the error right now.
JamfPackageUploader: Copying ApE-3.1.2.pkg to /Volumes/jamf/Packages/ApE-3.1.2.pkg
Traceback (most recent call last):
File "/Library/AutoPkg/autopkglib/init.py", line 840, in process
self.env = processor.process()
File "/Library/AutoPkg/autopkglib/init.py", line 626, in process
self.main()
File "/Users/admin/Library/AutoPkg/RecipeRepos/com.github.autopkg.grahampugh-recipes/JamfUploaderProcessors/JamfPackageUploader.py", line 738, in main
self.copy_pkg(self.smb_url, self.pkg_path, self.pkg_name)
File "/Users/admin/Library/AutoPkg/RecipeRepos/com.github.autopkg.grahampugh-recipes/JamfUploaderProcessors/JamfPackageUploader.py", line 264, in copy_pkg
copyfile(pkg_path, destination_pkg_path)
File "/Library/AutoPkg/Python3/Python.framework/Versions/3.10/lib/python3.10/shutil.py", line 256, in copyfile
with open(dst, 'wb') as fdst:
PermissionError: [Errno 1] Operation not permitted: '/Volumes/jamf/Packages/ApE-3.1.2.pkg'
File "/Library/AutoPkg/autopkglib/init.py", line 840, in process
self.env = processor.process()
[Errno 1] Operation not permitted: '/Volumes/jamf/Packages/ApE-3.1.2.pkg'
I'd check for this error and print out that it's probably MAC and tell the user to check System Prefs, Security & Privacy.
I'm glad to have this working again.

I don't fully follow the workflow here, but it says Operation Not Permitted, rather than Permission Denied.
I don't have any experience of running AutoPkg over ssh. I also use CI/CD, but use a Runner on the client. Maybe you need to adjust the ssh permissions? Just a guess.
Also I'm not really sure what you're asking for, but feel free to make a PR with the desired changes to the error reporting, if that's what you're asking for. I can't really guess what those changes would be.

I think you also answered your own question in #72 ?


Suggestion: extract to function expression

Search Terms

function expression declaration extract method refactoring code fixes
Suggestion
"Extract to function" is very useful, but it only supports generating function declarations. Some people (such as me) prefer to use function expressions instead of declarations.
For example:
const fn = () => {
    const foo = 1;
    const bar = foo + 2
}

If I select line 3 and extract to function, I get
const fn = () => {
    const foo = 1;
    const bar = newFunction(foo)
}

function newFunction(foo: number) {
    return foo + 2;
}

I want:
const newFunction = (foo: number) => foo + 2;

const fn = () => {
    const foo = 1;
    const bar = newFunction(foo)
}

Some ideas:

An option to toggle between expressions/declarations
Separate refactorings for both expressions and declarations

Use Cases

Examples

Checklist
My suggestion meets these guidelines:

[x] This wouldn't be a breaking change in existing TypeScript/JavaScript code
[x] This wouldn't change the runtime behavior of existing JavaScript code
[x] This could be implemented without emitting different JS based on the types of the expressions
[x] This isn't a runtime feature (e.g. library functionality, non-ECMAScript syntax with JavaScript output, etc.)
[x] This feature would agree with the rest of TypeScript's Design Goals.

For me:

Inner (not-top-level) function?

Yes: const clickHandler = () => { ... }
No: Need to annotate with predefined function type?

Yes: const Component: React.FC = () => { ... }
No: function someExpensiveLogic() { ... }

I'm afraid that too many choices of refactoring would be shown.
I prefer arrow function for inner function, as it's this binding is just for that.
For top level functions, I vote on function declaration. But it might be helpful to have "convert to arrow function" refactoring.

But it might be helpful to have "convert to arrow function" refactoring.

Here's a start https://github.com/nicoespeon/abracadabra/pull/114

This idea also applies to the forthcoming "declare function" code fix: https://github.com/microsoft/TypeScript/pull/41215. That is, we need a way to let users choose what type of function they want TS to create for them: an expression or a declaration. /cc @a-tarasyuk


ValueError: Length mismatch with added/missing columns

Hi folks,
I'm having trouble using dask if the CSV files contain an equal amount of columns (either added or missing). Couldn't find any solutions in the API docs, the issues or on SO.
code
import pandas as pd
import numpy as np
import dask.dataframe as dd

nobs=3
df5=pd.DataFrame({'t':['2016-12-05']*nobs,'a':np.arange(nobs)*1}) # starting format
df6=pd.DataFrame({'t':['2016-12-06']*nobs,'a':np.arange(nobs)*1,'b':np.arange(nobs)*2}) # column added

# save data
df5.to_csv('data-2-5.csv',index=False)
df6.to_csv('data-2-6.csv',index=False) # new columns

print(pd.concat([df5,df6]))

# dask fails to show missing columns as NANs
ddf = dd.read_csv('data-2-*.csv',assume_missing=True)
print(ddf.compute()) # error
print(ddf.loc[:,['a','b','t']].compute()) # error

** stack trace**
File "", line 17, in
print(ddf.compute()) # error
File "C:\Anaconda3\lib\site-packages\dask\base.py", line 99, in compute
(result,) = compute(self, traverse=False, **kwargs)
File "C:\Anaconda3\lib\site-packages\dask\base.py", line 206, in compute
results = get(dsk, keys, **kwargs)
File "C:\Anaconda3\lib\site-packages\dask\local.py", line 562, in get_sync
return get_async(apply_sync, 1, dsk, keys, **kwargs)
File "C:\Anaconda3\lib\site-packages\dask\local.py", line 529, in get_async
fire_task()
File "C:\Anaconda3\lib\site-packages\dask\local.py", line 504, in fire_task
callback=queue.put)
File "C:\Anaconda3\lib\site-packages\dask\local.py", line 551, in apply_sync
res = func(*args, **kwds)
File "C:\Anaconda3\lib\site-packages\dask\local.py", line 295, in execute_task
result = pack_exception(e, dumps)
File "C:\Anaconda3\lib\site-packages\dask\local.py", line 290, in execute_task
result = _execute_task(task, data)
File "C:\Anaconda3\lib\site-packages\dask\local.py", line 271, in _execute_task
return func(*args2)
File "C:\Anaconda3\lib\site-packages\dask\compatibility.py", line 47, in apply
return func(*args, **kwargs)
File "C:\Anaconda3\lib\site-packages\dask\dataframe\io\csv.py", line 67, in pandas_read_text
df.columns = columns
File "C:\Anaconda3\lib\site-packages\pandas\core\generic.py", line 2983, in setattr
return object.setattr(self, name, value)
File "pandas_libs\src\properties.pyx", line 65, in pandas._libs.lib.AxisProperty.set (pandas_libs\lib.c:45103)
File "C:\Anaconda3\lib\site-packages\pandas\core\generic.py", line 471, in _set_axis
self._data.set_axis(axis, labels)
File "C:\Anaconda3\lib\site-packages\pandas\core\internals.py", line 2836, in set_axis
(old_len, new_len))
ValueError: Length mismatch: Expected axis has 3 elements, new values have 2 elements
** setup **
dask.version
Out[87]: '0.15.3'
Python 3.6.1 |Anaconda custom (64-bit)| (default, May 11 2017, 13:25:24) [MSC v.1900 64 bit (AMD64)] on win32

Dask.dataframe expects all CSV files to have the same structure.  In more custom situations you might consider using dask.delayed instead.  Here are some pointers to documentation:

http://dask.pydata.org/en/latest/delayed.html
http://dask.pydata.org/en/latest/delayed-collections.html
https://gist.github.com/mrocklin/e7b7b3a65f2835cda813096332ec73ca

Ok thanks @mrocklin, I'll check those out. Btw it also fails if the number of columns are the same but the order is swapped... Delayed potentially the solution again I guess?
import pandas as pd
import numpy as np
import dask.dataframe as dd

nobs=3
df5=pd.DataFrame({'t':['2016-12-05']*nobs,'a':np.arange(nobs)*1,'b':np.arange(nobs)*2}) # starting format
df6=pd.DataFrame({'t':['2016-12-06']*nobs,'a':np.arange(nobs)*1,'b':np.arange(nobs)*2}) # column added

# save data
df5.to_csv('data-3-5.csv',index=False)
df6[['b','a','t']].to_csv('data-3-6.csv',index=False) # new columns

print('*pandas*')
print(pd.concat([df5,df6]))

# dask fails to show missing columns as NANs
ddf = dd.read_csv('data-3-*.csv')
print('*dask*')
print(ddf.compute()) # wrong column content for t=='2016-12-06'

I may have a similar issue where the CSV (read_csv) works correctly, however when I use parquet files (read_parquet) I get a stack trace.
(Pdb) df=df.compute()
*** ValueError: Length mismatch: Expected axis has 8 elements, new values have 3 elements.

The input data only has 3 columns, with CSV that is what is read, with read_parquet I am picking 'dir0' to 'dir4'
(Pdb) df.columns
Index(['a', 'b', 'c', 'dir4', 'dir2', 'dir1', 'dir3', 'dir0'], dtype='object')

You can use d6stack library to deal with this problem. See https://github.com/d6t/d6tstack/blob/master/examples-dask.ipynb

I think I'm going to close this.  Dask dataframe read_csv today expects data to be uniform.  If this is not the case then you should handle things with external processing (like the library mentioned above) or perhaps by converting to an easier to manage format, like Parquet.


Synthesize memberwise initializers despite member functions

Previously unimportable member functions inhibited the synthesis of
memberwise initializers.
Resolves SR-12730.

@swift-ci Please test

Build failed
Swift Test Linux Platform
Git Sha -<PHONE_NUMBER>0ca654095d3584b06514fe7d07f24e

@swift-ci Please test Linux


Allow definition of custom prompts in yaml file

aider/coders/*_prompts.py files conditionally use values defined under their class names with an associated key 'main_system' in a ~/.aiderprompts.yaml for their "main_system" prompts or fall back to the existing hardcoded prompt value

Example ~/.aiderprompts.yaml entry:

EditBlockFunctionPrompts:
  main_system: | """Act as an expert software developer. Take requests for changes to the supplied code. If the request is ambiguous, ask questions.

    Some custom instructions..
    """

For this to work well prompts should probably generally defined in some kind of file, also to allow creation of a prepopulated custom-prompt file for users to modify.
The logic could be extended to also check for a custom prompt file in the current working directory, which would superseed the global one, to allow custom prompts per project.

Current ~/.aiderprompts.yaml with default entries:
UnifiedDiffPrompts:
  main_system: |
    """Act as an expert software developer.
    You are diligent and tireless!

    You always COMPLETELY IMPLEMENT the needed code!
    Always use best practices when coding.
    Respect and use existing conventions, libraries, etc that are already present in the code base.

    Take requests for changes to the supplied code.
    If the request is ambiguous, ask questions.

    For each file that needs to be changed, write out the changes similar to a unified diff like `diff -U0` would produce. For example:

    # Example conversation 1

    ## USER: Replace is_prime with a call to sympy.

    ## ASSISTANT: Ok, I will:

    1. Add an imports of sympy.
    2. Remove the is_prime() function.
    3. Replace the existing call to is_prime() with a call to sympy.isprime().

    Here are the diffs for those changes:

    ```diff
    --- mathweb/flask/app.py
    +++ mathweb/flask/app.py
    @@ ... @@
    -class MathWeb:
    +import sympy
    +
    +class MathWeb:
    @@ ... @@
    -def is_prime(x):
    -    if x < 2:
    -        return False
    -    for i in range(2, int(math.sqrt(x)) + 1):
    -        if x % i == 0:
    -            return False
    -    return True
    @@ ... @@
    -@app.route('/prime/<int:n>')
    -def nth_prime(n):
    -    count = 0
    -    num = 1
    -    while count < n:
    -        num += 1
    -        if is_prime(num):
    -            count += 1
    -    return str(num)
    +@app.route('/prime/<int:n>')
    +def nth_prime(n):
    +    count = 0
    +    num = 1
    +    while count < n:
    +        num += 1
    +        if sympy.isprime(num):
    +            count += 1
    +    return str(num)
    ```
    """

EditBlockPrompts:
  main_system: |
    """Act as an expert software developer.
    You are diligent and tireless!

    You always COMPLETELY IMPLEMENT the needed code!
    Always use best practices when coding.
    Respect and use existing conventions, libraries, etc that are already present in the code base.

    Take requests for changes to the supplied code.
    If the request is ambiguous, ask questions.

    Once you understand the request you MUST:
    1. List the files you need to modify. Only suggest changes to a *read-write* files. Before changing *read-only* files you *MUST* tell the user their full path names and ask them to *add the files to the chat*. End your reply and wait for their approval.
    2. Think step-by-step and explain the needed changes with a numbered list of short sentences.
    3. Describe each change with a *SEARCH/REPLACE block* per the examples below.

    All changes to files must use this *SEARCH/REPLACE block* format.

    # Example conversation 1:

    ## USER: These are the *read-write* files:

    mathweb/flask/app.py
    {fence[0]}python
    from flask import Flask

    app = Flask(__name__)

    @app.route('/div/<int:n>/<int:d>')
    def divide(n, d):
        if d == 0:
            return 'Error: Division by zero'
        else:
            result = n / d
            return str(result)

    def factorial(n):
        "compute factorial"

        if n == 0:
            return 1
        else:
            return n * factorial(n-1)

    @app.route('/factorial/<int:n>')
    def get_factorial(n):
        return str(factorial(n))

    if __name__ == '__main__':
        print("Starting...")
        app.run()
    {fence[1]}

    ## ASSISTANT: Ok.

    ## USER: Change get_factorial() to use math.factorial

    ## ASSISTANT:

    Do make this change we need to modify `mathweb/flask/app.py` to:

    1. Import the math package.
    2. Remove the existing factorial() function.
    3. Update get_factorial() to call math.factorial instead.

    Here are the *SEARCH/REPLACE* blocks:

    mathweb/flask/app.py
    {fence[0]}python
    <<<<<<< SEARCH
    from flask import Flask
    =======
    import math
    from flask import Flask
    >>>>>>> REPLACE
    {fence[1]}

    mathweb/flask/app.py
    {fence[0]}python
    <<<<<<< SEARCH
    def factorial(n):
        "compute factorial"

        if n == 0:
            return 1
        else:
            return n * factorial(n-1)

    =======
    >>>>>>> REPLACE
    {fence[1]}

    mathweb/flask/app.py
    {fence[0]}python
    <<<<<<< SEARCH
        return str(factorial(n))
    =======
        return str(math.factorial(n))
    >>>>>>> REPLACE
    {fence[1]}

    # Example conversation 2:

    ## USER: These are the *read-write* files:

    main.py
    {fence[0]}python
    def hello():
        "print a greeting"

        print("hello")

    if __name__ == '__main__':
        hello()
    {fence[1]}

    ## ASSISTANT: Ok.

    ## USER: Refactor hello() into its own file.

    ## ASSISTANT:

    Do make this change we need to modify `main.py` and make a new file `hello.py`:

    1. Make a new hello.py file with hello() in it.
    2. Remove hello() from main.py and replace it with an import.

    Here are the *SEARCH/REPLACE* blocks:

    hello.py
    {fence[0]}python
    <<<<<<< SEARCH
    =======
    def hello():
        "print a greeting"

        print("hello")
    >>>>>>> REPLACE
    {fence[1]}

    main.py
    {fence[0]}python
    <<<<<<< SEARCH
    def hello():
        "print a greeting"

        print("hello")
    =======
    from hello import hello
    >>>>>>> REPLACE
    {fence[1]}

    # Rules
    """
EditBlockFunctionPrompts:
  main_system: |
    """Act as an expert software developer.
    Take requests for changes to the supplied code.
    If the request is ambiguous, ask questions.

    Once you understand the request you MUST use the `replace_lines` function to edit the files to make the needed changes.
    """

WholeFilePrompts:
  main_system: |
    """Act as an expert software developer.
    Take requests for changes to the supplied code.
    If the request is ambiguous, ask questions.

    Once you understand the request you MUST:
    1. Determine if any code changes are needed.
    2. Explain any needed changes.
    3. If changes are needed, output a copy of each file that needs changes.
    """<details>

        system_reminder = """To suggest changes to a file you MUST return the entire content of the updated file.
    You MUST use this *file listing* format:

    path/to/filename.js
    {fence[0]}
    // entire file content ...
    // ... goes in between
    {fence[1]}

    Every *file listing* MUST use this format:
    - First line: the filename with any originally provided path
    - Second line: opening {fence[0]}
    - ... entire content of the file ...
    - Final line: closing {fence[1]}

    To suggest changes to a file you MUST return a *file listing* that contains the entire content of the file.
    *NEVER* skip, omit or elide content from a *file listing* using "..." or by adding comments like "... rest of code..."!
    Create a new file you MUST return a *file listing* which includes an appropriate filename, including any appropriate path.
    """
WholeFileFunctionPrompts:
  main_system: |
    """Act as an expert software developer.
    Take requests for changes to the supplied code.
    If the request is ambiguous, ask questions.

    Once you understand the request you MUST use the `write_file` function to edit the files to make the needed changes.
    """
SingleWholeFileFunctionPrompts:
  main_system: |
    """Act as an expert software developer.
    Take requests for changes to the supplied code.
    If the request is ambiguous, ask questions.

    Once you understand the request you MUST use the `write_file` function to update the file to make the changes.
    """

+1 to this.
just a concern -- would it be also possible to leave capability for "prompt variations" that is, if one prompt fails somehow, try a different one (for the same task)

What are the benefits of using a YAML file over a directory structure of plain text prompt files?

Example ~/.aiderprompts.yaml entry:

EditBlockFunctionPrompts:
  main_system: | """Act as an expert software developer. Take requests for changes to the supplied code. If the request is ambiguous, ask questions.

    Some custom instructions..
    """

I believe you'll get triple double quotes in your prompt strings if you include them in the YAML file. The result will be equivalent to:
main_system = """\"\"\"Act as an expert software developer. Take requests for changes to the supplied code. If the request is ambiguous, ask questions.

Some custom instructions..
\"\"\""""

So I think your entries need to be written as:

EditBlockFunctionPrompts:
  main_system: |
      Act as an expert software developer. Take requests for changes to the supplied code. If the request is ambiguous, ask questions.

      Some custom instructions..

paul-gauthier closed this 4 days ago

@paul-gauthier, does this mean customizable prompts are definitely not on the roadmap?


DateInput: Remove default hint

Fixes: #647

I'm no longer sure this is a good idea. See: https://github.com/daniel-ac-martin/NotGovUK/issues/647#issuecomment-1326538369


Set explicitly packages for setuptools

Closes #1778
Contributor checklist

[ ] Provided the tests for the changes.
[x] Assure PR title is short, clear, and good to be included in the user-oriented changelog

Maintainer checklist

[x] Assure one of these labels is present: backwards incompatible, feature, enhancement, deprecation, bug, dependency, docs or skip-changelog as they determine changelog listing.
[x] Assign the PR to an existing or new milestone for the target version (following Semantic Versioning).

@q0w https://github.com/jazzband/pip-tools/actions/runs/3716280054/jobs/6302430284#step:6:177
/tmp/build-env-l170qp45/lib/python3.9/site-packages/setuptools/command/build_py.py:202: SetuptoolsDeprecationWarning:     Installing 'piptools._compat' as data is deprecated, please list it in `packages`.
[220](https://github.com/jazzband/pip-tools/actions/runs/3716280054/jobs/6302430284#step:6:221)
    !!
[221](https://github.com/jazzband/pip-tools/actions/runs/3716280054/jobs/6302430284#step:6:222)

[222](https://github.com/jazzband/pip-tools/actions/runs/3716280054/jobs/6302430284#step:6:223)

[223](https://github.com/jazzband/pip-tools/actions/runs/3716280054/jobs/6302430284#step:6:224)
    ############################
[224](https://github.com/jazzband/pip-tools/actions/runs/3716280054/jobs/6302430284#step:6:225)
    # Package would be ignored #
[225](https://github.com/jazzband/pip-tools/actions/runs/3716280054/jobs/6302430284#step:6:226)
    ############################
[226](https://github.com/jazzband/pip-tools/actions/runs/3716280054/jobs/6302430284#step:6:227)
    Python recognizes 'piptools._compat' as an importable package,
[227](https://github.com/jazzband/pip-tools/actions/runs/3716280054/jobs/6302430284#step:6:228)
    but it is not listed in the `packages` configuration of setuptools.
[228](https://github.com/jazzband/pip-tools/actions/runs/3716280054/jobs/6302430284#step:6:229)

[229](https://github.com/jazzband/pip-tools/actions/runs/3716280054/jobs/6302430284#step:6:230)
    'piptools._compat' has been automatically added to the distribution only
[230](https://github.com/jazzband/pip-tools/actions/runs/3716280054/jobs/6302430284#step:6:231)
    because it may contain data files, but this behavior is likely to change
[231](https://github.com/jazzband/pip-tools/actions/runs/3716280054/jobs/6302430284#step:6:232)
    in future versions of setuptools (and therefore is considered deprecated).
[232](https://github.com/jazzband/pip-tools/actions/runs/3716280054/jobs/6302430284#step:6:233)

[233](https://github.com/jazzband/pip-tools/actions/runs/3716280054/jobs/6302430284#step:6:234)
    Please make sure that 'piptools._compat' is included as a package by using
[234](https://github.com/jazzband/pip-tools/actions/runs/3716280054/jobs/6302430284#step:6:235)
    the `packages` configuration field or the proper discovery methods
[235](https://github.com/jazzband/pip-tools/actions/runs/3716280054/jobs/6302430284#step:6:236)
    (for example by using `find_namespace_packages(...)`/`find_namespace:`
[236](https://github.com/jazzband/pip-tools/actions/runs/3716280054/jobs/6302430284#step:6:237)
    instead of `find_packages(...)`/`find:`).
[237](https://github.com/jazzband/pip-tools/actions/runs/3716280054/jobs/6302430284#step:6:238)

[238](https://github.com/jazzband/pip-tools/actions/runs/3716280054/jobs/6302430284#step:6:239)
    You can read more about "package discovery" and "data files" on setuptools
[239](https://github.com/jazzband/pip-tools/actions/runs/3716280054/jobs/6302430284#step:6:240)
    documentation page.
[240](https://github.com/jazzband/pip-tools/actions/runs/3716280054/jobs/6302430284#step:6:241)

@atugushev https://github.com/jazzband/pip-tools/pull/1784


docker.io/nvidia/cuda:11.7.0-devel-ubuntu22.04 not available anymore

Seems cuda:11.7.0-devel-ubuntu22.04 is not available anymore on docker hub, but 11.7.1 is. I updated my Dockerfile and that seems to work.

Thanks! I've changed 11.7.0 to 11.7.1


Its not working with CS API <IP_ADDRESS>

The login to the API was changed on 4.19,  and the module doesn't support it yet.
'errorcode': 401, 'errortext': 'unable to verify user credentials and/or request signature'

hi @sefimlog - we no longer have interest in maintaining this library and would be open to handing it over to other parties interested.

Thanks for the offer, @resmo!
I tried to initiate the repository transfer to @ngine-io but Github doesn't let me -- I'd need to have repository creation permissions on the destination org.
Could I get this permission temporarily, for the duration of the transfer?
You should have received an invite for PyPI in the meantime.

Hello from cs's new home!

@resmo Really appreciate you taking this on and for both you and @brutasse for moving so quickly to get this transitioned.
Now we just need to figure out how to fix the actual issue in this Issue.  Really need to get this working so it can be used with newer Cloudstack versions 4.19.x :smile:

@CodeBleu I need a little more details what are you experiencing:

Which exact version do you experience this? What was the last working version?
Is there a release note which points to the breaking change?
Have you already been in contact with the cloudstack community about it? e.g. via the mailinglist?

I am aware of security fixes in cloudstack which may be related:

https://cloudstack.apache.org/blog/security-release-advisory-<IP_ADDRESS>-<IP_ADDRESS>#cve-2024-45461-access-checks-not-enforced-in-quota
https://cloudstack.apache.org/blog/security-release-advisory-<IP_ADDRESS>-<IP_ADDRESS>#cve-2024-42062-user-key-exposure-to-domain-admins
...

I am currently building a test container for 4.19 to reproduce this issue.

@resmo

Which exact version do you experience this?
<IP_ADDRESS>
What was the last working version?
4.18.x
Is there a release note which points to the breaking change?
Not that I'm aware of.
Have you already been in contact with the cloudstack community about it? e.g. via the mailinglist?
Only the Github issue where I asked them if they wanted to take over this CS repo.

Thanks @resmo for stepping up! And @brutasse for helping with the transition.

@resmo if you're looking to setup CI/Github actions support, feel free to look at https://github.com/apache/cloudstack-terraform-provider/blob/main/.github/workflows/setup-cloudstack/action.yml which is basically running CloudStack+Simulator in a container & then calling APIs to validate some basic checks.

@resmo  FYI, incase you didn't follow this issue.
https://github.com/apache/cloudstack-go/issues/92#issuecomment-2508880636

Thanks for the hint, but I think we are fine to work on and maintain it since we heavily depend on this library, but maybe it would be a good idea to add another person to the pypi project just "in case" I somehow managed to loose access.
@rohityadavcloud do you have a pypi account? https://pypi.org/user/Rohit.Yadav? would you be okay to be added to https://pypi.org/project/cs/ just as a "backup"?

So back to the issue, I was able to add an integration test for <IP_ADDRESS> which turned out green https://github.com/ngine-io/cs/actions/runs/12100100185/job/33738343600?pr=137

Since @sefimlog was the creator of this issue, I'm wondering if you are still having issues and what version of Cloudstack and CS module you are using @sefimlog ?
@resmo I originally added you to this because of needing support for this module going forward and I had done a quick test myself with a 4.19 and 4.18 environment.  I originally was getting the 401 error as well in the 4.19 environment, but I just now went back to test again since you said it workd and marked it ias 'invalid'.  When I went to test again, it is actually working for me as well.  There is a chance I tested on a version of 4.19.x and didn't pay close attention to what the 'x' was and it might have been updated since.  But my current test was on <IP_ADDRESS> and it seemed to work.

Hi @resmo happy to be added as a backup on pypi, my username is indeed https://pypi.org/user/Rohit.Yadav/

@CodeBleu I somehow missed, you were not the reporter...
@sefimlog could you provide more infos, about which cloudstack version you experiencing that?
I marked the issue as "invalid" as I was not able to reproduce with latest 4.19, which should be a upgrade target anyway in case you run a outdated (security issue related) 4.19 but haven't upgraded yet.


screen resize problem in royale

controls should be arranged according to browser size when maximize or restore down.
page resolution is required according to screen resolution.

Resizing appears to be working for Product/Groups.  I don't know which form is shown in the image so I can't debug further


[Bug]: Template Phase 2 issues

Is there an existing issue for this?

[X] I have searched the existing issues

Description
Following are the issues found in DP https://appsmith-git-feature-templates-phase-2-get-appsmith.vercel.app :

[ ] #15920

[x] On selecting filters in template modal, closing it and again opening the modal, shows count of the filters although no filters are selected

[x] On adding new page Page2, the start from template and generate crud card disappears from Page1, ideally until any page level action is performed we should show the cards

[ ] #15921

[x] In filters list we use Widgets and in templates description page it's Widgets Used,we should make them consistent

[x] Icon size for Create a blank page seems little smaller then the other two

Steps To Reproduce

Go to https://appsmith-git-feature-templates-phase-2-get-appsmith.vercel.app/
Create new app

Public Sample App
No response
Version
https://appsmith-git-feature-templates-phase-2-get-appsmith.vercel.app/

On selecting filters in template modal, closing it and again opening the modal, shows count of the filters although no filters are selected this is working fine verified it on release.
On adding new page Page2, the start from template and generate crud card disappears from Page1, ideally until any page level action is performed we should show the cards this is fixed verified it on release.
In filters list we use Widgets and in templates description page it's Widgets Used, we should make them consistent this is also fixed verified it on release.
Icon size for Create a blank page seems little smaller then the other two fixed verified it on release.

@akash-codemonk

[ ] On switching to child branch and forking any template it is throwing error. Please refer to the attached video :-
https://user-images.githubusercontent.com/93259714/193246764-b70a620c-4587-438e-8621-c921517b5410.mov

@akash-codemonk can you please look into this issue:

[ ]  On switching to child branch and forking any template it is throwing error. Please refer to the attached video :-
https://user-images.githubusercontent.com/93259714/193246764-b70a620c-4587-438e-8621-c921517b5410.mov

@Richarex Is this happening with all templates?

@akash-codemonk can you please look into this issue:

[ ]  On switching to child branch and forking any template it is throwing error. Please refer to the attached video :-
https://user-images.githubusercontent.com/93259714/193246764-b70a620c-4587-438e-8621-c921517b5410.mov

First one seems like an issue with errors template actions of multiple pages which are just piled up. This happens on release as well. The number of toasts depends on the number of failing actions on page load. If you have fewer actions failing in the templates you have fewer errors.
Not considering this as a bug it's more of an issue with the templates themselves.

On switching from child branch to Master the data is not getting displayed and the user sees "Page Not Found" error. Please refer to the SS attached.

The second issue is a bug I can repro on release. Will create an issue for this.
Not considering as a bug since it isn't related to templates and can be replicated on release.

@akash-codemonk this issue is still reproducible

[ ] On switching from child branch to Master the data is not getting displayed and the user sees "Page Not Found" error. Please refer to the attached video:- https://www.loom.com/share/5ab72c0268a04dca8c2293f520de83c9

On switching from child branch to Master the data is not getting displayed and the user sees "Page Not Found" error. Please refer to the SS attached.

The second issue is a bug related to git without templates I can repro on release. Will create an issue for this. Not considering as a bug since it isn't related to templates and can be replicated on release. Created an issue for this at #17234

As mentioned in https://github.com/appsmithorg/appsmith/issues/15879#issuecomment-1263426095 is not an issue with templates. So we will not be taking it up as part of template fixes.
@Richarex


For mutiinvoke

Description 描述

Linked Issues 关联的 Issues
Additional context 额外上下文

Summary by CodeRabbit

New Features

Introduced a status tracking feature for database operations to enhance synchronization during initialization and operation completion.

@ISafive 麻烦解决一下冲突，谢谢！


Investigate removing the installation of 'resources' for MaterialXGenShader module

Introduced here, it appears resources are installed for MaterialXGenShaders.
We think they are only needed for MaterialXRender modules - see here

Thanks for this report, @ld-kerley, and this has been addressed in #1927


Make sequence ports selectable on all VisualScriptNodes (FAILD)

I tried implementing the first approach of proposal 3544.
And wanted to post the code for prosperity and guidance.

The sequenced option already available must be removed.

[X] VisualScriptFunction
[X] VisualScriptLists
[X]  VisualScriptComposeArray
[ ]  VisualScriptExpresion

VisualScriptNode must support sequenced.
VisualScriptEditor must be able to intersept exceptions and the new sequenced.

It is this last one I think that breaks the actual running of logic.

Closing as we just removed VisualScript for 4.0, so this can no longer be evaluated as is.
The VisualScript module has been moved to https://github.com/godotengine/godot-visual-script with the aim that it might be ported to a GDExtension if there are interested contributors to do so. Further work to improve the features could be done on that repository too (so currently there isn't anyone dedicated to maintain this repository, it will depend again on whether some contributors step up to do so).


Support VBA projects!

Well, it might seem like a big project.
If you could make VBA projects editable here, no one would use the default VBA editor!

This extension only supports parsing data, VBA is not supported.


Matthew/functional docstrings update

Addresses #533.

SeqLengthWarmup now has example code.
More info about functional form of ALiBi and augmentations
Minor docstring example import cleanup (consistently use import composer.functional as cf)

@jfrankle would you be able to review this one?


vicuna33b not executing on GPU

I am using Debian with an A4000. Vicuna13b will execute on GPU just fine but Vicuna33b will not.
Is this a bug or am I misunderstanding something in the documentation or configuration?

Vicuna-33b is too big to entirely offload to an A4000 GPU (quick Google search says that its got 16GB of VRAM) so the load will be shared between CPU and GPU. If you are only seeing CPU usage try checking the ollama service logs:
sudo journalctl -u ollama.service > ollama_logs.txt
Happy to help with any errors you may see in there.


_routes.json file generated with overlapping rules when serving for Cloudflare Pages

Qwik Version
v0.13.3
Operating System (or Browser)
OSX/Cloudflare Pages
Node Version (if applicable)
No response
Which component is affected?
Qwik City
Expected Behaviour
_routes generates with rules that are acceptable for Cloudflare pages.
Actual Behaviour
When building the _routes file for Cloudflare Pages, overlapping rules are created. This only occurs when there are index.tsx files at routes/user/ and routes/user/a/, and not when just at /routes/user/.
This is using all default settings on the latest version of Qwik.
File structure:

_routes.json
{
  "version": 1,
  "include": [
    "/*"
  ],
  "exclude": [
    "/_headers",
    "/_redirects",
    "/build/*",
    "/cashDisplayWave.svg",
    "/favicon.svg",
    "/index.html",
    "/manifest.json",
    "/q-data.json",
    "/q-manifest.json",
    "/robots.txt",
    "/service-worker.js",
    "/sitemap.xml",
    "/user/*",
    "/",
    "/user",
    "/user/a",
    "/user/b"
  ]
}

Error:
Overlapping rules found. Please make sure that rules ending with a splat (eg. "/api/*") don't
overlap any other rules (eg. "/api/foo"). This applies to both include and exclude rules
individually.
Additional Information
No response

Fixed in #2185


Column filters

How can I do filters like this?

https://visactor.io/vtable/demo/list-table-data-analysis/list-table-data-filter
now, you can develop it like this demo @rakucmr


Images are not caching after app restarts

I'm using ionic-image-loader for caching images, first time it loads all images and cached images, if i close app and restart it then all images will load again, caching images are not loading, I have given caching age is 7 days. Inside app if I navigate to some other page and come back then images will be cached. Only app restarts or close app then only images not caching loading again.
Please help me regarding this.
I need all loaded images should be cached after app killed / restart

Yes, I also meet that problem.. Have you found a solution for this?

What can we do to progress on that issue ?

Same problem !

Actually I figure out that the spinner that appears after having restarted the app is just to load the picture from the cache. You can check like this: remove the API that fetches thumbnails before you restart your app, then the picture would still be shown after the app is restarted.

@pierresh so you are saying after app restarts also images are loading from cache ? then why do they too time to load if they are loading from cache?

I did the following tests and both failed:

I checked network tab for the hit to image URL's and even after caching, the actual URL's are again called. So i don't really understand the use of this plugin.

I loaded images in first run. Then closed the app. Before relaunching the app, I disabled the internet on my device. Then I launched the app again. This time the images did not load from cache so i believe they were not cached at all


Create release by a user

Is it possible to create a release via the action from my github account? Using a PAT?

Yes, you can use a PAT to create a release


feat: configure bridge provider via env variable

What was wrong?
We need a better way to switch between pandaops provider endpoints. For example, the erigon nodes went down the other day, breaking our bridge. The only way to change this would be to update the hardcoded BASE_*_ENDPOINT variables, then cut a new release, and then deploy the new release. With this change, we can simply change the env variable in the deployment scripts and re-run the deployments.
Note - These env variables will override the default values for pandaops endpoints. If the user selects a non-pandaops provider via the cli flag, the env variables will be ignored.
How was it fixed?

Added the feature to select the pandaops provider endpoint via env variable

To-Do

[ ] Clean up commit history and use conventional commits.

@KolbyML tracking in #1123


cargo run --example false positive "is a library and cannot be executed"

https://github.com/rust-dsp/rust-vst/issues/71
In rust-vst's Cargo.toml, there is the following definition:
[[example]]
name = "simple_host"
crate-type = ["bin"]

among other example declarations which are crate-type = ["cdylib"] instead.
Trying to run it:
cargo run --example simple_host
error: example target `simple_host` is a library and cannot be executed

However, if you simply remove the line crate-type = ["bin"], it starts working.

<&mbrubeck> Walther: I think the bug is here https://github.com/rust-lang/cargo/blob/master/src/cargo/core/manifest.rs#L654-L658
<&mbrubeck> Any non-empty list is treated as ExampleLib, which triggers https://github.com/rust-lang/cargo/blob/master/src/cargo/ops/cargo_run.rs#L40-L45

Looking at https://github.com/rust-lang/cargo/blob/5dbac98885199bbd7c0f189d7405b5523434d1e3/src/cargo/core/manifest.rs#L647-L658 it seems there's a heavy assumption that examples will only ever be libraries.
If one changes the type signature to Vec<TargetKind>, line 655 TargetKind::ExampleLib(crate_targets) errors because ExampleLib cannot take TargetKind as an input. Additionally, there's a new error in line 355 https://github.com/rust-lang/cargo/blob/90fc9f620190d5fa3c80b0c8c65a1e1361e6b8ae/src/cargo/util/toml/targets.rs#L328-L371 caused by the .into() call:
the trait `std::convert::From<&std::string::String>` is not implemented for `core::manifest::TargetKind`

How should this be handled?

Should we change the type of crate_targets in fn example_target(), and implement the conversion from string to TargetKind as well? How could that be done cleanly, with minimal repetition ref. LibKind's conversion method?
Should we instead create some sort of an ExampleKind wrapper so that within fn clean_examples() method in targets.rs the into() call can be more restricted?
Should we just keep the type as crate_targets: Vec<LibKind>, and blindly rely on the LibKind::Other -catch-all in the conversion, and parse for an Other-type and see if it contains a "bin" value? This would feel a bit dirty. On the other hand, that's exactly the codepath that is happening right now for examples with "bin" declared as the type
On an even broader scope, how should we handle these crate_targets being Vec's - is it valid to have an example with both "lib" and "bin" target? What should happen then? What about possible other lists of targets?

Thanks for the report, this definitely sounds like a bug! I agree that we should do some actual parsing here and realize that the string bin is a binary, not actually a library.
I'd be down for basically any fix that works here, feel free to refactor as necessary!


Implement Newton's method

Newton's method to find roots of a function is a numerical method which is used in many other algorithms.
For example implicit Methods to solve ode's use this method to approximate a value to a given time, or to optimize step-width and therefore reduce the number function evaluations.

Matlab implementation
newton.m.txt
gaussPivot.m.txt
Test Examples:
KreisTest.m.txt
gen_J_f_HyperbelKreis.m.txt
HyperbelKreis.m.txt

closed in #26


target not working on modal

Using the following code, I try to open the modal next to a div
	if( $('.callback_request').length) {
		new jBox('Modal', {
		  attach: '#openCallback',
		  title: '',
		  content: $('#callbackInfo'),
		  width: 320,
		  onOpen: function() {
			this.content.parent().find('.jBox-title').css({display: 'none'});
		  },
		  outside: 'x',
		  target: $('.callback_content'),
		  animation: 'flip'
		});
	}

The modal opens but the content is not in the viewport

Not sure how to reproduce this issue. See this fiddle: https://jsfiddle.net/StephanWagner/9472nwub/
That's how I set it up and it seems to work fine. Feel free to edit the fiddle to reproduce the issue.
Also, see comment here: https://github.com/StephanWagner/jBox/issues/143#issuecomment-611154993
You need to use null to not set an title. An empty string '' will set an empty title.
And I'm also not quite sure what you are trying to achieve with outside: 'x'. Modals are by default positioned in the center, horizontally and vertically.

Thx outside: 'x' was left from the experiment with position. But as soon as I use a target, the modal wont show up, only the overlay background.
This is the output:

Popup content

The position values of a modal are by default center. When you want it outside of the target element along the x axis you need to set the position to:
position: {
  x: 'right',
  y: 'center'
},
outside: 'x'

See updated this fiddle: https://jsfiddle.net/StephanWagner/9472nwub/8/

Cool fiddle (also with the missing overlay). But it's not working on our live page.
This is the code. It loads, but the modal is not in the viewport/visible
		new jBox('Modal', {
		  attach: '#openCallback',
		  title: null,
		  content: $('#callbackInfo'),
		  width: 320,
		  animation: 'flip',
		  position: {
		  	x: 'right',
		    y: 'center'
		  },
		  outside: 'x',
		  target: $('.callback_content'),
		  overlay: false,
		  offset: {
			x: 15
		  }
		});

Then the only explanation I have would be that the target div stretches over the whole page. Like that: https://jsfiddle.net/StephanWagner/9472nwub/9/
When there is not enough space available for the modal to show, jBox does some calculations to where position it best, but when the target element fills the whole page it won't work.

I wish it would be like that.

Hmm, very strange. I'm also confused why it would set inset: 94.5px auto auto 680px;. I can't really help though without being able to reproduce the issue.
I'll close this one for now, but if you want, you can send me an email with the HTML and then I'll have a more detailed look<EMAIL_ADDRESS>


Improve CoreObserver code coverage

Depends on the CoreObserver mocking tasks #1154 -> #1158

Create a testing CoreObserver using the mocked attributes.

Identify the methods that require higher coverage

Implement the tests with the mocking functionalities

Closing in favor of more atomic issues