Files with incorrect reported size/md5…

Completely rewriting it for easier referencing:
Some files have mismatch sizes reported in the Library page on HB and actual size after downloading it.
Currently I skip downloading them at all.
Currently I found following files with mismatch sizes, excluding files from other issues:

bundle name
file name
library name
size in library
download size
match md5sum

Humble Book Bundle: Python presented by No Starch Press
doingmathwithpython.pdf
Doing Math with Python: Use Programming to Explore Algebra, Statistics, Calculus, and More!
6978480
8101684
True

Humble Book Bundle: Cookbooks by Chronicle Books
legendsoftexasbarbecuecookbook.epub
Legends of Texas Barbecue Cookbook
19078920
19078918
False

Humble Book Bundle: Fantastic Science Fiction & Fantasy by JABberwocky Literary Agency
witch.mobi
Witch by Marie Brennan
2663506
5129137
False

Humble Book Bundle: Fantastic Science Fiction & Fantasy by JABberwocky Literary Agency
witch.epub
Witch by Marie Brennan
1092511
1998426
False

Humble Book Bundle: Data Science by No Starch Press
pythoncrashcourse2ndedition.pdf
Python Crash Course, 2nd Edition: A Hands-On, Project-Based Introduction to Programming
7248294
7101762
True

Humble Book Bundle: Cybersecurity 2020 by Wiley
threat_modeling_designing_for_security.pdf
Threat Modeling: Designing for Security
22762425
22787336
False

Humble Book Bundle: Cybersecurity 2020 by Wiley
threat_modeling_designing_for_security.epub
Threat Modeling: Designing for Security
6730700
6730838
False

Humble Book Bundle: Circuits & Electronics by Morgan & Claypool
arduinomicrocontrollerprocessingforeveryonethirdedition.pdf
Arduino Microcontroller Processing for Everyone! Third Edition
7917110
12366309
False

Humble Book Bundle: Circuits & Electronics by Morgan & Claypool
engineeringprinciplesineverydaylifefornonengineers.pdf
Engineering Principles in Everyday Life for Non-Engineers
6292371
8725081
False

Humble Book Bundle: Circuits & Electronics by Morgan & Claypool
microchipatmelavrmicrocontrollerprimer_programmingandinterfacingth.pdf
Microchip (ATMEL) AVR® Microcontroller Primer: Programming and Interfacing, Third Edition
49507557
20955035
False

Humble Book Bundle: Circuits & Electronics by Morgan & Claypool
smartphone-basedreal-timedigitalsignalprocessingsecondedition.pdf
Smartphone-Based Real-Time Digital Signal Processing, Second Edition
8777491
10723169
False

Humble Book Bundle: Data & AI by O'Reilly
streamingsystems.mobi
Streaming Systems
31903339
31905171
False

Humble Book Bundle: Data & AI by O'Reilly
streamingsystems.pdf
Streaming Systems
58473880
57083229
False

Humble Book Bundle: Data & AI by O'Reilly
streamingsystems.epub
Streaming Systems
33125480
16094225
False

Humble eBook Bundle: Warhammer 40,000 Stories 2021 by Black Library
cadianhonour.epub
Cadian Honour
2915117
2915103
False

Humble eBook Bundle: Warhammer 40,000 Stories 2021 by Black Library
cadianhonour.mobi
Cadian Honour
7016390
7016376
False

Dad’s Book of Awesome Science Experiments was fine before update in march or april…

Update:

bundle name
file name
library name
size in library
download size
match md5sum

Humble Book Bundle: Python presented by No Starch Press
doingmathwithpython.pdf
Doing Math with Python: Use Programming to Explore Algebra, Statistics, Calculus, and More!
6978480
8101684
True

Humble Book Bundle: Data Science by No Starch Press
pythoncrashcourse2ndedition.pdf
Python Crash Course, 2nd Edition: A Hands-On, Project-Based Introduction to Programming
7248294
7101762
True

Humble Book Bundle: Programming & Productivity by Mercury
angularandmachinelearningpocketprimer.epub
Angular and Machine Learning Pocket Primer
1705291
1701592
False

Humble Book Bundle: Programming & Productivity by Mercury
angularandmachinelearningpocketprimer.mobi
Angular and Machine Learning Pocket Primer
3777825
3773046
False

Humble Book Bundle: Programming & Productivity by Mercury
datasciencetools.mobi
Data Science Tools
35837755
35837751
False

Humble Book Bundle: Programming & Productivity by Mercury
datastructuresandprogramdesignusingjava.mobi
Data Structures and Program Design Using Java
86157767
13847904
False

Humble Book Bundle: Programming & Productivity by Mercury
datastructuresandprogramdesignusingjava.epub
Data Structures and Program Design Using Java
68748205
69046623
False

Humble Book Bundle: Programming & Productivity by Mercury
msexcel2019programmingpocketprimer.mobi
MS Excel 2019 Programming Pocket Primer
8931753
8922016
False

Humble Book Bundle: Programming & Productivity by Mercury
msexcel2019programmingpocketprimer.epub
MS Excel 2019 Programming Pocket Primer
5478257
5468420
False

Humble Book Bundle: Programming & Productivity by Mercury
python3formachinelearning.mobi
Python 3 for Machine Learning
12968693
12906609
False

Humble Book Bundle: Programming & Productivity by Mercury
python3formachinelearning.epub
Python 3 for Machine Learning
6279560
6202022
False

Humble Book Bundle: Programming & Productivity by Mercury
tensorflow2pocketprimer.epub
TensorFlow 2 Pocket Primer
5289679
5290018
False

Humble Book Bundle: Programming & Productivity by Mercury
tensorflow2pocketprimer.mobi
TensorFlow 2 Pocket Primer
11107711
11134738
False

Humble Book Bundle: Let's Cook Together by Sasquatch Books
homemadedoughnuts.epub
Doughnuts: 90 Simple and Delicious Recipes to Make at Home
7610099
216569073
True

Humble Manga Bundle: Spring 2021 Anime Season
thattimeigotreincarnatedasaslime_vol1.cbz
That Time I Got Reincarnated as a Slime Vol. 1
162505561
302856977
False

Humble Manga Bundle: Spring 2021 Anime Season
thattimeigotreincarnatedasaslime_vol1.pdf
That Time I Got Reincarnated as a Slime Vol. 1
187798976
307738192
False

new books:

bundle name
file name
library name
size in library
download size
match md5sum

Humble Book Bundle: Python presented by No Starch Press
doingmathwithpython.pdf
Doing Math with Python: Use Programming to Explore Algebra, Statistics, Calculus, and More!
6978480
8101684
1

Humble Book Bundle: Data Science by No Starch Press
pythoncrashcourse2ndedition.pdf
Python Crash Course, 2nd Edition: A Hands-On, Project-Based Introduction to Programming
7248294
7101762
1

Humble Book Bundle: Let's Cook Together by Sasquatch Books
homemadedoughnuts.epub
Doughnuts: 90 Simple and Delicious Recipes to Make at Home
7610099
216569073
1

Humble Manga Bundle: Spring 2021 Anime Season
thattimeigotreincarnatedasaslime_vol1.pdf
That Time I Got Reincarnated as a Slime Vol. 1
187798976
307738192
0

Humble Manga Bundle: Spring 2021 Anime Season
thattimeigotreincarnatedasaslime_vol1.cbz
That Time I Got Reincarnated as a Slime Vol. 1
162505561
302856977
0

Humble Book Bundle: Infrastructure and Ops by O'Reilly
prometheus_upandrunning.mobi
Prometheus: Up and Running
14164813
14167849
0

Humble Book Bundle: Infrastructure and Ops by O'Reilly
prometheus_upandrunning.pdf
Prometheus: Up and Running
9089973
8143145
0

Humble Book Bundle: Infrastructure and Ops by O'Reilly
prometheus_upandrunning.epub
Prometheus: Up and Running
5399551
5399663
0

update:

bundle name
file name
library name
size in library
download size
match md5sum

Humble Book Bundle: Python presented by No Starch Press
doingmathwithpython.mobi
Doing Math with Python: Use Programming to Explore Algebra, Statistics, Calculus, and More!
50789228
41214331
False

Humble Book Bundle: Python presented by No Starch Press
doingmathwithpython.epub
Doing Math with Python: Use Programming to Explore Algebra, Statistics, Calculus, and More!
31942890
20191633
False

Humble Book Bundle: Python presented by No Starch Press
doingmathwithpython.pdf
Doing Math with Python: Use Programming to Explore Algebra, Statistics, Calculus, and More!
6978480
6998952
False

Humble Book Bundle: Cookbooks by Chronicle Books
legendsoftexasbarbecuecookbook.epub
Legends of Texas Barbecue Cookbook
19078920
19078918
False

Humble Book Bundle: Trivia Champion
howartcanmakeyouhappy.mobi
How Art Can Make You Happy
838341
822020
False

Humble Book Bundle: Trivia Champion
howartcanmakeyouhappy.epub
How Art Can Make You Happy
330645
328340
False

Humble Book Bundle: Fantastic Science Fiction & Fantasy by JABberwocky Literary Agency
witch.epub
Witch by Marie Brennan
1092511
1998426
False

Humble Book Bundle: Fantastic Science Fiction & Fantasy by JABberwocky Literary Agency
witch.mobi
Witch by Marie Brennan
2663506
5129137
False

Humble Book Bundle: Data Science by No Starch Press
impracticalpythonprojects.pdf
Impractical Python Projects
13039822
9922184
False

Humble Book Bundle: Data Science by No Starch Press
impracticalpythonprojects.mobi
Impractical Python Projects
56466698
56435757
False

Humble Book Bundle: Data Science by No Starch Press
impracticalpythonprojects.epub
Impractical Python Projects
26140213
26131797
False

Humble Book Bundle: Data Science by No Starch Press
pythoncrashcourse2ndedition.mobi
Python Crash Course, 2nd Edition: A Hands-On, Project-Based Introduction to Programming
43180085
46432798
False

Humble Book Bundle: Data Science by No Starch Press
pythoncrashcourse2ndedition.epub
Python Crash Course, 2nd Edition: A Hands-On, Project-Based Introduction to Programming
21475350
21475476
False

Humble Book Bundle: Data Science by No Starch Press
pythoncrashcourse2ndedition.pdf
Python Crash Course, 2nd Edition: A Hands-On, Project-Based Introduction to Programming
7248294
7238584
False

Humble Book Bundle: Cybersecurity 2020 by Wiley
threat_modeling_designing_for_security.pdf
Threat Modeling: Designing for Security
22762425
22787336
False

Humble Book Bundle: Cybersecurity 2020 by Wiley
threat_modeling_designing_for_security.epub
Threat Modeling: Designing for Security
6730700
6730838
False

Humble Book Bundle: Circuits & Electronics by Morgan & Claypool
arduinomicrocontrollerprocessingforeveryonethirdedition.pdf
Arduino Microcontroller Processing for Everyone! Third Edition
7917110
12366309
False

Humble Book Bundle: Circuits & Electronics by Morgan & Claypool
engineeringprinciplesineverydaylifefornonengineers.pdf
Engineering Principles in Everyday Life for Non-Engineers
6292371
8725081
False

Humble Book Bundle: Circuits & Electronics by Morgan & Claypool
microchipatmelavrmicrocontrollerprimer_programmingandinterfacingth.pdf
Microchip (ATMEL) AVR® Microcontroller Primer: Programming and Interfacing, Third Edition
49507557
20955035
False

Humble Book Bundle: Circuits & Electronics by Morgan & Claypool
smartphone-basedreal-timedigitalsignalprocessingsecondedition.pdf
Smartphone-Based Real-Time Digital Signal Processing, Second Edition
8777491
10723169
False

Humble Book Bundle: Data & AI by O'Reilly
streamingsystems.pdf
Streaming Systems
58473880
57083229
False

Humble Book Bundle: Data & AI by O'Reilly
streamingsystems.epub
Streaming Systems
33125480
16094225
False

Humble Book Bundle: Data & AI by O'Reilly
streamingsystems.mobi
Streaming Systems
31903339
31905171
False

Humble Book Bundle: Stars of Sci-fi & Fantasy by Open Road Media
reconciliation.epub
Reconciliation
598304
610941
False

Humble eBook Bundle: Warhammer 40,000 Stories 2021 by Black Library
cadianhonour.epub
Cadian Honour
2915117
2915103
False

Humble eBook Bundle: Warhammer 40,000 Stories 2021 by Black Library
cadianhonour.mobi
Cadian Honour
7016390
7016376
False

Humble Book Bundle: Data Engineering by O'Reilly
architectingmoderndataplatforms.mobi
Architecting Modern Data Platforms
48584830
48208111
False

Humble Book Bundle: Data Engineering by O'Reilly
architectingmoderndataplatforms.epub
Architecting Modern Data Platforms
13868439
13621405
False

Humble Book Bundle: Tales of the Space Marine Chapters 2022 by Black Library
tomeoffire_bookone_salamander.mobi
Salamander
3375666
5343416
False

Humble Book Bundle: Tales of the Space Marine Chapters 2022 by Black Library
tomeoffire_bookone_salamander.epub
Salamander
1155761
2034093
False


Fixes numerical domain issue in get_euler_angles

The value zz can be slightly outside the interval [-1,1] due to finite precision, causing numpy.arccos(zz) to return nan.
This fixes this issue.

Fixed in b6682d1
@bogdanoff Sorry, I didn't see you already had PR #1456 for this


change .txt format of questions to .md

Fix format of questions from .txt to .md
Remove exports redundancy in the codebase

Closes #12


Use USWDS icons with badge component

🛠 Summary of changes
Updates Badge component to use USWDS icons.
This works toward removing our custom alert icons.
Related: #439, #441
📜 Testing Plan

Run locally as npm start
Go to http://localhost:4000/badges/
Observe badge icons

👀 Screenshots

Before
After

Visual regression failure is expected due to icon and markup changes:


Fix currency converter by changing data provider

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.izubkov seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.


doc(quickstart): use local minIO instead of remote minIO service

What would you like to be added:
Change MinIO's demo to:

use docker to deploy MinIO by default
Layotto invoke local MinIO by default

Why is this needed:
Currently, the demo uses the MinIO official demo service by default, but the service is unstable.

For example , someone might modify some configuration, which leads to demo failure.
So we want to use docker to deploy MinIO and make the demo more stable.

/assign

@ZLBer


Custom http headers

What
This pull request adds the ability to specify custom HTTP headers when integrating with OpenAI via proxy APIs such as Helicone. It also refactors OpenAi's performRequest() by encapsulating the logic for handling the session data task in its own class, URLSessionDataTaskManager. This should simplify the OpenAI class and make the code easier to manage. This pull request simplifies JSONRequest and MultipartFormDataRequest by abstracting out common code to remove repetition that previously existed in these structs. Finally, it simplifies the protocol URLRequestBuildable, moving configuration-driven parameter setting to the constructors of these struct instances, rather than in the call to that protocol's build() function.
Why
The motivation for this change was to allow users to integrate with OpenAI via the Helicone proxy. To do so, they not only need to point the OpenAI client at the Helicone host, but they also have to set an additional HTTP header on the requests. This pull request makes that possible.
Affected Areas
The affected areas of the library include:

The OpenAI class within the OpenAI.swift file.
The client configuration within the constructor of the OpenAI class.
The construction of requests in the following methods: completions(), completionsStream(), images(), embeddings(), chats(), chatsStream(), edits(), model(), models(), moderations(), audioTranscriptions(), and audioTranslations().

Hi! Is there anything more I need to do in order to get this merged?

Hey, @benvolioT!
Thanks a lot for the contribution!
Please fix build and merge conflicts 🙏


slash

In node-serialport / serialport_native / serialport_native.cc
#include <node.h> /* Includes for JS, node.js and v8 *//
please delete 2 slash
#include <node.h> /* Includes for JS, node.js and v8 */

Merged. Thanks.


Import from a HF model directly?

Is it possible to import from a huggingface model (given a huggingface card ID) directly?
I don't want to converting it to GGUF.

Would be nice if the Modelfile supported remote GGUFs:
FROM https://huggingface.co/MaziyarPanahi/Meta-Llama-3-8B-Instruct-GGUF/blob/main/Meta-Llama-3-8B-Instruct.Q2_K.gguf

@adrienbrault agree, if you could just put a .gguf in the FROM statement and it just got pulled it would be ideal.

I added this feature in another form:
https://github.com/ericcurtin/podman-ollama
podman-ollama -m https://huggingface.co/TheBloke/Mistral-7B-Instruct-v0.2-GGUF/resolve/main/mistral-7b-instruct-v0.2.Q2_K.gguf "Tell a joke"
uses ollama as a backend.

It's implemented here now, see bottom of README for usage:
https://github.com/ericcurtin/podman-ollama

This is now possible for a small set of architectures:

MistralForCausalLM
MixtralForCausalLM
GemmaForCausalLM

With support for more models (including Llama 3) coming soon!

To, use FROM <model directory> in the Modelfile

I am running ollama on docker . Trying to run HF model with MistralForCausalLM. Modelfile contains FROM <model directory>
It throws
transferring model data
unpacking model metadata
processing tensors
Error: open /root/.ollama/models/blobs/411433471/tokenizer.model: no such file or directory
The model which I pulled doesn't have tokenizer.model file.

Update
I downloaded and moved tokenizer.model file from base model Mistral 7B to the finetuned model directory. It seems to be converting. Will test it.
I am running ollama on docker . Trying to run HF model with MistralForCausalLM. Modelfile contains FROM <model directory>
It throws
transferring model data unpacking model metadata processing tensors Error: open /root/.ollama/models/blobs/411433471/tokenizer.model: no such file or directory
The model which I pulled doesn't have tokenizer.model file.

I've got the same issue.

The above solution worked for me. You need the original model's tokenizer.model file.

Just copy it directly inside downloaded finetuned model directory.
And then try to import.

Make sure to match architecture of the finetuned model and the original model. They should be same. You can find it inside config.json file of those models.


[BUG] SubscriptionResource.GetLocationsAsync fails with System.FormatException

Library name and version
Azure.ResourceManager 1.11.0
Describe the bug
I'm trying to query Azure for the list of locations to work around another bug and I'm getting an error.
Expected behavior
Return a list of deserialized Azure.ResourceManager.Resources.Models.LocationExpanded
Actual behavior
System.FormatException: The input string '-79.8164' was not in a correct format.
   at System.Number.ThrowFormatException[TChar](ReadOnlySpan`1 value)
   at System.Double.Parse(String s)
   at Azure.ResourceManager.Resources.Models.LocationMetadata.ReadLongitude(JsonProperty property, Nullable`1& longitude)
   at Azure.ResourceManager.Resources.Models.LocationMetadata.DeserializeLocationMetadata(JsonElement element, ModelReaderWriterOptions options)
   at Azure.ResourceManager.Resources.Models.LocationExpanded.DeserializeLocationExpanded(JsonElement element, ModelReaderWriterOptions options)
   at Azure.ResourceManager.Resources.SubscriptionResource.<>c.<GetLocationsAsync>b__47_1(JsonElement e)
   at Azure.Core.PageableHelpers.PageableImplementation`1.<GetAsyncEnumerator>d__15.MoveNext()
   at Azure.Core.PageableHelpers.PageableImplementation`1.<GetAsyncEnumerator>d__15.System.Threading.Tasks.Sources.IValueTaskSource<System.Boolean>.GetResult(Int16 token)

Reproduction Steps
var armClient = new ArmClient(new DefaultAzureCredential());
SubscriptionResource subscription = _armClient.GetSubscriptionResource("xxxxxxxxxxxxxxxxxxxxx");
var response = subscription.GetLocationsAsync();
var result = await response.ToListAsync(); // <- System.FormatException: 'The input string '-79.8164' was not in a correct format.

Environment

dotnet 8
VS 17.9.5

https://github.com/Azure/azure-sdk-for-net/blob/b423a6907354e85db2abf1adfb7c3c4bd7b97197/sdk/resourcemanager/Azure.ResourceManager/src/Resources/Custom/Models/LocationMetadata.cs#L34
It's missing the "CultureInfo.InvariantCulture"

My bad, I should have specified this. I'm on fr-fr:

cache-control: no-cache
content-length: 41473
content-type: application/json; charset=utf-8
expires: -1
pragma: no-cache
x-ms-correlation-request-id: 90e241b4-b9fb-4f2e-9e70-e43ab9af11f3
x-ms-ratelimit-remaining-subscription-reads: 11999
x-ms-request-id: 90e241b4-b9fb-4f2e-9e70-e43ab9af11f3
x-ms-routing-request-id: FRANCECENTRAL:20240410T101956Z:90e241b4-b9fb-4f2e-9e70-e43ab9af11f3

I was able to move around this issue by forcing the current culture to invariant as every other SDK call.

Duplicated with https://github.com/Azure/azure-sdk-for-net/issues/35365.
CultureInfo is not supported for now. We're going to close this issue.
You could track for the latest update here: https://github.com/Azure/autorest.csharp/issues/3651.


Building dependencies takes an aeon on slow connections.

Due to the need to download the chromium container during building deps, development becomes problematic on slow connections.
It would be great to add the option to not have to download the image every time i npm i.
Perhaps there is a workaround? If so, please do let me know!

Hey there!
are you talking about the development of bee-js itself? Or with bee-js as a dependency?
The problem is that npm install install both dependencies and devDependencies, so if you want to install only dependencies then you can run npm install --only=prod, that said it won't install also your root devDependencies which might be needed for your development.
I guess the goal would be here to install devDependencies for your root package and not devDependencies of your dependencies which is something that I don't know how to do.

Hmm, other people were already exploring this problem with the reinstallation of Chromium with puppeteer, it is possible to avoid it but will require a bit of work.
References:

https://github.com/puppeteer/puppeteer/issues/244
https://github.com/puppeteer/puppeteer/blob/main/docs/api.md#environment-variables

This is no longer the case.


Correct unescaped left brace error

Error occurs on OSX, on usage of Ctrl+T.
Makes marker essentially useless.

There is also another reference of that command that needs to get update as well (Line 118)


Snowflake 5.0 is not supported. Warning in the logs.

Which version and edition of Flyway are you using?
7.5.0 which is the latest version when writing this issue
Which client are you using? (Command-line, Java API, Maven plugin, Gradle plugin)
Java API
Which database are you using? (Type & version)
Snowflake 5.0
Which operating system are you using?
MacOS
What did you do? (Please include the content causing the issue, any relevant configuration settings, the SQL statement(s) that failed (if any), and the command you ran)
Running migrations against Snowflake.
Using Snowflake JDBC driver net.snowflake/snowflake-jdbc "3.12.15"
What did you expect to see?
No warnings
What did you see instead?
I see warning about Snowflake 5.0 beeing newer than tested & supported version.
21-01-21 14:36:22 MacBook-Pro-92.local INFO [org.flywaydb.core.internal.license.VersionPrinter:49] - Flyway Community Edition 7.5.0 by Redgate
21-01-21 14:36:22 MacBook-Pro-92.local INFO [org.flywaydb.core.internal.database.base.DatabaseType:49] - Database: jdbc:snowflake://xxx.xxx.snowflakecomputing.com:443/ (Snowflake 5.0)
21-01-21 14:36:22 MacBook-Pro-92.local WARN [org.flywaydb.core.internal.database.base.Database:53] - Flyway upgrade recommended: org.flywaydb.core.internal.database.snowflake.SnowflakeDatabaseType@2168ed92 5.0 is newer than this version of Flyway and support has not been tested. The latest supported version of org.flywaydb.core.internal.database.snowflake.SnowflakeDatabaseType@2168ed92 is 4.2.

Everything has worked as expected with Snowflake and Flyway. The only thing "wrong" is the warning in the logs.
Seems to be similar to this issue https://github.com/flyway/flyway/issues/2645

This is just a warning and indicates that we last tested against a previous version of Snowflake. I've verified all the tests pass with 7.5.0, and the warning will disappear in Flyway 7.5.2

This is just a warning and indicates that we last tested against a previous version of Snowflake. I've verified all the tests pass with 7.5.0, and the warning will disappear in Flyway 7.5.2

This has been merged and will be available from the next release

This has been merged and will be available from the next release


Added home anchor tag to the page.hbs template

You the bomb! Thank you for the contribution :)

No problem! Happy to help! :)


Player Files API

Implementation of the Server API to manage player files.

Closing this PR as I have incorporated the work into this PR: https://github.com/LootLocker/unreal-server-sdk/pull/12


Extract axis components

I wanted to lend a helping hand to this project, but I find the 1000-line Editor.tsx file pretty hard to work with. I suggest splitting it up to smaller components.
Here's a start.

This is great @nene !
Yes indeed the file kept growing and needed some refactoring (testing as well).
I will check the PR tomorrow and merge if everything is fine.
Thank you for you contribution!


[Core] Allow query differences

Why means a better detailed explanation than yes or no.
But it could be does for sake of simplicity.
Action walk = new Action();
walk.is(move);

Action run = new Action ();
run.is(walk);
run.set("pace", new Concept ("fast"));

Map<String, Concept> result = why(run).isDifferentThan(walk);

Related to #79

This can be very useful to determine what and/or when something changed in an instance, like: "started to rain" or "became the king of France".

This can be very useful to determine what and/or when something changed in an instance, like: "started to rain" or "became the king of France".


Community Request: Design a logo for the Angular CLI

The CLI is a really important part of the Angular platform, and loved by many developers in the community. It would be great if the project had a logo consistent with the rest of Angular!
The CLI team is busy building out the CLI and the Angular DevKit, and so it would be awesome to see the community come up with ideas, proposals, and recommendations to help the process along.
Reply to this issue and let's get this process started!

I have e proposal or maybe just an Idea:

Like a console

It is like two consoles and upside down angular.
(≧∀≦)

I created these two proposal keeping in mind:

Consistency
Recognizability even in icon size
Eye-candy factor

Please vote:

"Classic" terminal

"Styled" terminal

1.1

Great initative and great responses.  Here is my recomendation.
Thinking behind the logo: Since angular cli is core to angular development for many developers like us, thought CLI should be at core, bounded by the angular. (The edges of cli should match that of angular logo)

Some animations to support my proposal #1 (just for fun):

Angular logo with CLI look.

Angular CLI Logo

Angular CLI Logo Black

Keeping it simple, This allows for a consistent format if other officially supported tools want to have their own logos.

My two cents.

It is similar to anein's Design...

I don't really see the need for an actual logo for the CLI to be honest. Now in that matter.. we all know Angular has a red logo, Universal has a green one, Material is blueish, I would go with just a color like some of you already suggested and just stick with the A of Angular.. because we all know.. "It's just Angular".

Angular CLi.pdf

let me know what you guys thinking! cheers!

@violetdama I like that, nice work... also thanks for joining github to be able to contribute! Welcome!

definitly the 1.1 from @webmaxru !

Someone just pointed me to this for inspiration: https://www.behance.net/gallery/53773741/Logo-trend-report-2017

Could contributors provide small (favicon sized) versions of the logo when posting? It would be good to see whether the design holds up with limited space, and whether it could be easily differentiated from and also be associated with the angular logo at the most minimum scale.

We also might post only one logo version per comment. I very much like seeing alternates, but I'm finding it hard to use reactions to vote for my specific favorites when one comment has multiples.

not that it does really matter, but @shprink is a nice guy, and he makes blinking logos, so ... yeah ... whatever

@thisgeek here is the demo of how https://github.com/angular/angular-cli/issues/6791#issuecomment-311630815 could look as an icon. Click the image to see non-scaled version (it's important to see actual pixels):

Some experiments with logo looks really cool, but they do not survive under different resolutions. Logo should be recognizable and readable (if applicable) in different image sizes.

@webmaxru Beautiful context. (And I dig the icon.) Thank you.

@tytskyi I strongly agree and I think the one I shared here is legible enough in different sizes.

For a youtube video, I created this photo. Maybe you guys can use it to take inspiration for something if you want, Or not.

I really like the look of it, hope you guys will too.

video link -- ClickME!
Ps This isn't me pitching my video, if you think it is, then it is. Happy Coding 💯 😄

@webmaxru the logo with > _ looking awesome, gonna use in my presentation.

Hi, thank you all for pitching in. Some of these were truly inspiring.

For completeness sake, this is the logo now:

And you can get it and the other logos from https://angular.io/presskit


CI test for dump existence check

This is not getting caught in CI https://github.com/openbmc/openbmc/issues/3028
So something a simple test needs to be added which does

[x] DeleteAll dumps
[x] Check No dump should exist

In review https://gerrit.openbmc-project.xyz/#/c/9728/


Add OpenCover support to Bozo

Add ability to generate code coverage reports using OpenCover.
http://youtrack.zopa.local/issue/PT-6
To enable change the nunit section of  the bozorc.rb of C# project from
test_with :nunit do |n|
  n.platform 'x86'
  n.project 'TEST_PROJECT_NAME_GOES_HERE'
end

to
test_with :open_cover do |d|
  d.runner :nunit do |n|
    n.platform 'x86'
    n.project 'TEST_PROJECT_NAME_GOES_HERE'
  end
end

Can we also add a tools configuration similar to what we do for nuget? https://github.com/zopaUK/bozo-scripts/blob/master/lib/bozo/tools/nuget.rb

Nice!
I wonder if we can integrate with Jenkins and show badges on Github like so?

@slavo we've planning on using this with sonarqube to produce these reports which can be integrated somewhat http://docs.sonarqube.org/display/PLUG/GitHub+Plugin

@stephenbinns SonarQube is GPL (the code we use it in has to be public domain). Does this affect us?

No. GPL pertains to changes made to the tool/library itself

@lavapatch Yes, but it's copyleft (https://en.wikipedia.org/wiki/Copyleft).
"with the stipulation that the same rights be preserved in derivative works down the line".
This means our code has to be licensed under GPL, too.

@slavo We are using the tool As Is. We don't need to worry about GPL is were are not redistributing the tool nor are we modifying or deriving anything from it.

LGTM :+1:


Overlap with OneGet (Aka PackageManagement) & Chocolatey

I feel like we've been here before it seems with Windows Package Management using the OneGet Project (https://docs.microsoft.com/en-us/archive/blogs/packagemanagement/introducing-packagemanagement-in-windows-10) & https://github.com/OneGet & the well used and maintained Chocolatey application that has been in use for over 4 years now & already has tremendous experience with package management on windows and have a decent trajectory going forward.
So considering that there is a product well used out there, what benefit do I as a user of Chocolatey get moving over to winget?
What is the incentive to be invested in this going forward as opposed to Chocolatey?
Also as a wider query with this did anyone reach out to any of the contributors/original authors on OneGet like @fearthecowboy @jianyunt, Chocolatey like @ferventcoder or the PowerShell team like @joeyaiello @SteveL-MSFT about this to gain some direction on where they have had pain points with this in the past? If not I'd recommend you look at involving them (if they can find the time) as a steering group if you really want this to be a real long term success.

I'm all behind where they're heading. I've talked briefly to Rich Turner about it, and I'm really quite excited.
I think they're going to be able to succeed where I was not able to.
Had I not been extremely involved in where I am now, I heavily considered going to work on this. Very very excited

did anyone reach out to any of the contributors/original authors

Per: https://devblogs.microsoft.com/commandline/windows-package-manager-preview:

We have already talked with a few of the well-known package manager teams. Chocolatey has a vibrant community with a massive collection of applications, and a rich history supporting both open source and enterprise customers. Scoop provides a convenient way to allow software to be installed without the UAC popups. Ninite keeps an eye on updates for all the apps it installed. There are many others like AppGet, Npackd and the PowerShell based OneGet package manager-manager.

what benefit do I as a user of Chocolatey get moving over to winget?
What is the incentive to be invested in this going forward as opposed to Chocolatey?

https://chocolatey.org/pricing
Of course, advanced features would take time to implement.

did anyone reach out to any of the contributors/original authors

Looks like they reached out to them https://keivan.io/the-day-appget-died/


Remove ResponseResult from UpgradeTimeout response, channel-id from UpgradeTry response.

Description

closes: #XXXX
Commit Message / Changelog Entry
chore: remove resp type from UpgradeTimeout response, channel-id from TryUpgrade response.

see the guidelines for commit messages. (view raw markdown for examples)

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

[ ] Targeted PR against correct branch (see CONTRIBUTING.md).
[ ] Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
[ ] Code follows the module structure standards and Go style guide.
[ ] Wrote unit and integration tests.
[ ] Updated relevant documentation (docs/) or specification (x/<module>/spec/).
[ ] Added relevant godoc comments.
[ ] Provide a commit message to be used for the changelog entry in the PR description for review.
[ ] Re-reviewed Files changed in the Github PR explorer.
[ ] Review Codecov Report in the comment section below once CI passes.

Codecov Report

Merging #5407 (03dcdc5) into 04-channel-upgrades (baa0318) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Additional details and impacted files

@@                   Coverage Diff                   @@
##           04-channel-upgrades    #5407      +/-   ##
=======================================================
- Coverage                80.39%   80.38%   -0.01%
=======================================================
  Files                      197      197
  Lines                    14985    14982       -3
=======================================================
- Hits                     12047    12044       -3
  Misses                    2474     2474
  Partials                   464      464

Files
Coverage Δ

modules/core/keeper/msg_server.go
62.08% <100.00%> (-0.14%)
:arrow_down:


implement load_weights for cached_transforers.get()

Fixed the load_weights arg in cached_transformers.get() which was documented but not implemented
Resolves #63
Simple testing shows that with and without load_weights cache seperately:
>>> m1 = cached_transformers.get(transformers.AutoModel, 'bert-base-cased', False)
Some weights of the model checkpoint at bert-base-cased were not used when initializing BertModel: ['cls.predictions.transform.dense.weight', 'cls.predictions.bias', 'cls.seq_relationship.weight', 'cls.predictions.transform.dense.bias', 'cls.seq_relationship.bias', 'cls.predictions.decoder.weight', 'cls.predictions.transform.LayerNorm.weight', 'cls.predictions.transform.LayerNorm.bias']
- This IS expected if you are initializing BertModel from the checkpoint of a model trained on another task or with another architecture (e.g. initializing a BertForSequenceClassification model from a BertForPreTraining model).
- This IS NOT expected if you are initializing BertModel from the checkpoint of a model that you expect to be exactly identical (initializing a BertForSequenceClassification model from a BertForSequenceClassification model).
>>> m2 = cached_transformers.get(transformers.AutoModel, 'bert-base-cased', False)
>>> m3 = cached_transformers.get(transformers.AutoModel, 'bert-base-cased', False, load_weights=False)
Some weights of the model checkpoint at bert-base-cased were not used when initializing BertModel: ['cls.predictions.transform.dense.weight', 'cls.predictions.bias', 'cls.seq_relationship.weight', 'cls.predictions.transform.dense.bias', 'cls.seq_relationship.bias', 'cls.predictions.decoder.weight', 'cls.predictions.transform.LayerNorm.weight', 'cls.predictions.transform.LayerNorm.bias']
- This IS expected if you are initializing BertModel from the checkpoint of a model trained on another task or with another architecture (e.g. initializing a BertForSequenceClassification model from a BertForPreTraining model).
- This IS NOT expected if you are initializing BertModel from the checkpoint of a model that you expect to be exactly identical (initializing a BertForSequenceClassification model from a BertForSequenceClassification model).
>>> m4 = cached_transformers.get(transformers.AutoModel, 'bert-base-cased', False, load_weights=False)
>>> def model_eq(a,b):
...         return all(torch.allclose(p1 ,p2) for p1, p2 in zip(a.parameters(), b.parameters()))
>>> model_eq(m1,m2)
True
>>> model_eq(m1,m3)
False
>>> model_eq(m3,m4)
True

Hmm, it looks like this implementation would still involve loading the pre-trained weights for each model (at least the first time cached_transformers(..., load_weights=False) is called for a given model) since cls.from_pretrained() is called in every branch before cls.from_config(). I think we want to avoid that.

Hmm good point, I'll look into a way to recover the equivalent AutoConfig* class from the AutoModel* class that we have as cls.


Workfront integration broken

OS version:
Browser version:
Extension version:

Relevant integration (if any):
Workfront https://www.workfront.com/
🐛 Describe the bug
Workfront have made an update and the button is no longer initiating a timer as it should
Expected behaviour
Toggl button use should start a timer from workfront
Steps to reproduce
Haven't replicated, but the user has sent a screenshot to show an example of the problem
Case reference
Other details or context
"Yes the UI has been updated as has the URL from the screenshot/spec you sent me. I will send you an updated screenshot below. Note the new UI might be getting rolled out progressively so not all organisations might yet have this updated UI."

Case reference

Case reference

Another user complaint.


Interaction needed for returning cards from the "Search" on meld effect

Currently there isn't a way to have an interaction during a meld, but the "Search" icon needs to allow the user to determine the order in which cards are returned if they don't match the searched icon.
Also, if the state diagram needs to be updated, probably should consider the effect of Promotion (from Forecast and also an on meld effect) and the endorse action.

For now, the cards will be returned in the order they were drawn for the Search action.

I'm planning to find a way to re-use the existing card selection engine, so that we can take advantage of the existing interactions and automations. I believe this will just require some clever fiddling of the game state engine.


Implement entities

Entities are a necessity for a minecraft-like client, which is why we should implement them

The base for this is implemented, now we only need all the individual mobs


missing boolean value

Issue

Hi, just ran into some problems with 14.4., maybe it has to do with the homebridge 2.0 beta? going back to 14.3 solves the issue for now.
Log Messages

[11.11.2024, 13:18:48] [homebridge-hue] TypeError: stealth: missing boolean value
at newTypeError (file:///var/lib/homebridge/node_modules/homebridge-hue/node_modules/hb-lib-tools/lib/OptionParser.js:31:52)
at Function.toBool (file:///var/lib/homebridge/node_modules/homebridge-hue/node_modules/hb-lib-tools/lib/OptionParser.js:98:13)
at Object._callbacks. [as stealth] (file:///var/lib/homebridge/node_modules/homebridge-hue/node_modules/hb-lib-tools/lib/OptionParser.js:604:40)
at OptionParser.parse (file:///var/lib/homebridge/node_modules/homebridge-hue/node_modules/hb-lib-tools/lib/OptionParser.js:876:29)
at HueDiscovery.discover (file:///var/lib/homebridge/node_modules/homebridge-hue/node_modules/hb-hue-tools/lib/HueDiscovery.js:142:8)
at HuePlatform.findBridges (file:///var/lib/homebridge/node_modules/homebridge-hue/lib/HuePlatform.js:424:43)
at HuePlatform.accessories (file:///var/lib/homebridge/node_modules/homebridge-hue/lib/HuePlatform.js:202:39)
at file:///var/lib/homebridge/node_modules/homebridge/src/bridgeService.ts:495:24
at new Promise ()
at BridgeService.loadPlatformAccessories (file:///var/lib/homebridge/node_modules/homebridge/src/bridgeService.ts:489:12)```

#### Debug Files
<!-- Please attach homebridge-hue.json.gz, see https://github.com/ebaauw/homebridge-hue#debug-dump-file -->

<!-- Please attach homebridge.log.gz here, see https://github.com/ebaauw/homebridge-hue#debug-log-file -->

I think there's a problem with your config.json.  What's the value for the stealth key?

Should be fixed in v0.14.5.

thanks! 👍


Possible Performance improvements

Hello, Thank you very much for writing this very useful tool.
I noticed that exabgp_conf.py can be generate very large configuration files which will most often will then take ages to load. A faster way to do would be to send the routes using the API. The process has been documented by another ExaBGP user here: https://github.com/FastVPSEestiOu/fastnetmon/blob/master/docs/EXABGP_INTEGRATION.md
or more elegantly https://github.com/job/irrexplorer/blob/master/exabgp.conf
Also, I added an "undocumented" (i.e.: needing some improvement but working) command to the API allowing to reduce parsing by grouping updates with the same attributes. From memory it is something like "announce attribute ... route ... ". I would need to double check if this is of interest.
Good continuation.

Thank you for your advice!
We added the option using the API.
Option of grouping updates with the same attributes also added.
Please check "mrt2exabgp.py".

Thank you very much for adding this feature :+1:

Now I close this case.

Sorry!
I have forgot to describe performance...
Here is a comparison of the results.
Config format(Previous method)  -> 5:23
$ /usr/bin/time /usr/bin/pypy ~/mrtparse/examples/mrt2exabgp.py -r <IP_ADDRESS> -l 64512 -p 65000 -L <IP_ADDRESS> -n <IP_ADDRESS> -4 <IP_ADDRESS> ~/Downloads/bview.20150601.0000.gz > ~/mrtparse/examples/static.conf
66.03user 0.30system 1:06.39elapsed 99%CPU (0avgtext+0avgdata 110352maxresident)k
0inputs+166472outputs (0major+17068minor)pagefaults 0swaps

$ /usr/bin/exabgp ~/mrtparse/examples/static.conf 1>~/mrtparse/examples/static.log 2>&1
==> static.log <==
Sun, 21 Jun 2015 02:38:23 | INFO     | 21988  | configuration | environment file missing
Sun, 21 Jun 2015 02:41:53 | INFO     | 21988  | network       | Connected to peer neighbor <IP_ADDRESS> local-ip <IP_ADDRESS> local-as 64512 peer-as 65000 router-id <IP_ADDRESS> family-allowed in-open (out)

$ tshark -q -i lo -w ~/mrtparse/examples/static.pcap tcp port 179 1>/dev/null 2>&1 &
==> static.pcap <==
16  2015-06-21 02:41:53.528978000   <IP_ADDRESS>   <IP_ADDRESS>   BGP 132 UPDATE Message
1080422 2015-06-21 02:42:46.563973000   <IP_ADDRESS>   <IP_ADDRESS>   BGP 77  UPDATE Message

Using API without grouping format -> 4:33
$ /usr/bin/exabgp ~/mrtparse/examples/api.conf 1>~mrtparse/examples/api.log 2>&1
==> api.log <==
Sun, 21 Jun 2015 03:00:05 | INFO     | 22364  | configuration | environment file missing
Sun, 21 Jun 2015 03:04:37 | INFO     | 22364  | reactor       | Updated peers dynamic routes successfully

$ tshark -q -i lo -w ~/mrtparse/examples/api.pcap tcp port 179 1>/dev/null 2>&1 &
==> api.pcap <==
1   2015-06-21 03:00:11.397807000   <IP_ADDRESS>   <IP_ADDRESS>   BGP 136 UPDATE Message
1095912 2015-06-21 03:04:38.086106000   <IP_ADDRESS>   <IP_ADDRESS>   BGP 77  UPDATE Message

Using API with grouping format  -> 03:36
$ /usr/bin/exabgp ~/mrtparse/exabgp/group.conf 1>~mrtparse/exabgp/group.log 2>&1
==> group.log <==
Sun, 21 Jun 2015 03:05:52 | INFO     | 22479  | configuration | environment file missing
Sun, 21 Jun 2015 03:09:28 | INFO     | 22479  | reactor       | Updated peers dynamic routes successfully

$ tshark -q -i lo -w ~/mrtparse/exabgp/group.pcap tcp port 179 1>/dev/null 2>&1 &
==> group.pcap <==
5   2015-06-21 03:07:13.192208000   <IP_ADDRESS>   <IP_ADDRESS>   BGP 128 UPDATE Message
1103865 2015-06-21 03:09:28.597166000   <IP_ADDRESS>   <IP_ADDRESS>   BGP 132 UPDATE Message

Using API with grouping format(10,000 prefix units)  -> 2:57
$ /usr/bin/exabgp ~/mrtparse/examples/group100000.conf 1>~mrtparse/examples/group100000.log 2>&1
==> group100000.log <==
Sun, 21 Jun 2015 03:21:30 | INFO     | 22750  | configuration | environment file missing
Sun, 21 Jun 2015 03:24:26 | INFO     | 22750  | reactor       | Updated peers dynamic routes successfully

$ tshark -q -i lo -w ~/mrtparse/examples/group100000.pcap tcp port 179 1>/dev/null 2>&1 &
==> group100000.pcap <==
1   2015-06-21 03:21:44.925858000   <IP_ADDRESS>   <IP_ADDRESS>   BGP 128 UPDATE Message
1093828 2015-06-21 03:24:27.302069000   <IP_ADDRESS>   <IP_ADDRESS>   BGP 113 UPDATE Message

Please let us know what you think if you like.

Thank you very much for taking the time to put these numbers together. The change does seems to improve things :v:
The API way should also use much less memory.
It may be possible to improve the performance even more using the following neighbor options:
group-updates enable;
auto-flush disable;
And them only flushing the routes when you have some grouped enough NLRI to fill your NLRI.
The command to do so "route flush" ( from memory ).
something like :
announce attribute...
[... a few hundred ...]
announce attribute ...
flush route;

I forgot to say that in this way the initial update will be regrouped so it would be a like for like replay.

OK, Thank you for the info.


Accuracy metric with optional num_classes argument

🚀 Feature
The fixed num_classes parameter in the Multiclass Accuracy calculation should be made Optional.
Motivation
Classification problems can have a dynamic number of output classes. E.g. ordering problems, like predicting the correct word order in a shuffled sentence, depend on the number of words per sentence. Since each sentence is likely to have a different number of words, the number of "classes" differs between samples.
For example, given 2 sentences with radnomly shuffled words, the ground truth word ordering ids could look like:
Sentence 1 (6 words): 3, 5, 1, 0, 2, 4
Sentence 2 (3 words): 2, 0, 1
As a first performance proxy i want to calculate accuracy scores, by simply checking the overlap of correctly predicted positions. However, the non-optional num_classes argument makes it difficult to instantiate the accuracy metric in such a scenario with no fixed num_classes. Of course I could select a very high number of classes, hoping that I never encounter a sentence with more words, but this seems like an ugly hack.
Imho the accuracy calulation should be independent of num_classes in such a case.
Is there a particular reason, why the number of classes is always needed?
A simple accuracy implementation like the following wouldn't need it for sure:
def masked_accuracy(output: torch.Tensor, target: torch.Tensor, mask: torch.Tensor) -> float:
    """Compute accuracy of softmax output with mask applied over values.
    """

    with torch.no_grad():
        masked_output = torch.masked_select(output, mask)
        masked_target = torch.masked_select(target, mask)
        accuracy = masked_output.eq(masked_target).float().mean()
        return accuracy

I get that you handle way more cases and different averaging options, but I still feel the above case is not properly covered in your implementation...
Pitch
Make num_classes optional and in cases where it is really needed, raise a custom Exception, telling the user that this argument is needed in this specific accuracy configuration.

Hi @LarsHill, thanks for raising this issue.
There are a multiple reason that after the classification refactor in v0.10 of torchmetrics, the num_classes argument has been required:

Consistency: regardless of classification metric the interface and the arguments are the same now. While it is correct that num_classes are not needed in this case for accuracy, for other metrics it is always needed
Scope: computing MulticlassAccuracy with anything else than average="micro" (which is the value you refer to) requires that the user provides num_classes because we need to aggregate statistics per class. Therefore, since we only could make num_classes optional in a single case, it seemed limited in scope.
Verification: by forcing the user to provide the num_classes we can verify that data fulfils a number of constrains making sure that everything is as expected.

Finally, there is the question if such aggregation over samples with different number of classes is correct based on a theoretically point of view. If I have 3 balanced classes and random guess I have a baseline accuracy value of 33%. If I increase to 4 classes, that number becomes 25%. Thus, conclusions on metric values should always be done in relation to a base level, which I think is harder to do when that base level is dynamic.
All that said, if you are just interested in the accuracy value per batch, then I see no problem using the functional version:
acc = torchmetrics.functional.classification.multiclass_accuracy(
    preds,
    target,
    num_classes=max(max(preds), max(target)),
    average="micro"
)

where the num_classes argument is set dynamically.


Replace team info footer with a placeholder message for users with no teams

Stories: 🖥 , 📱

@keybase/react-hackers


Use CryptographicOperations.FixedTimeEquals

Use CryptographicOperations.FixedTimeEquals in PasswordHasher as suggested in #9795

@aspnet-hello triage https://dev.azure.com/dnceng/public/_build/results?buildId=171207

This comment was made automatically. If there is a problem contact<EMAIL_ADDRESS>I've triaged the above build. I've created/commented on the following issue(s)
https://github.com/aspnet/AspNetCore-Internal/issues/2408


error with custom_components/sonoff

i have version 0.104.3
home assistant bug

how to fix it?

@guyyar89 doesn’t look like my code 😅
can you drop a link from where you’ve got it? i’m curious
Sent with GitHawk

its install from hacs
where is the code?

wrong project, here's the one that you're looking for https://github.com/AlexxIT/SonoffLAN (this dude did some pretty good job) follow up there (+next time read better the description from HACS, pretty sure there's some reference there)


tape with global strict mode

I'm running all projects in strict mode and haven't found another solution yet than adding --use_strict directly to the tape script. Maybe a second bin safe-tape?
https://github.com/PatrickHeneise/tape/blob/master/bin/tape#L1

You do not want to use the v8 "use_strict" flag - that is NOT the same as strict mode, and behaves differently.
If you want your projects in strict mode, include the "use strict" directive at the top of each file.

I do want strict mode but I'm kind of tired to put "use strict"; on the top of every single js file. There must be another way?

You could use babel, which assumes all your code is an ES6 module, and automatically puts "use strict" at the top?
Either way this is out of scope for tape :-)

I created a fork with the flag until there's a better solution.

Sure, but the flag is a much worse solution than putting "use strict" at the top of every single file - and babel is also a better solution.

I've been running it for a week and haven't discovered any issues. What's so bad about the --use_strict flag?

https://github.com/nodejs/node-v0.x-archive/issues/7479 talks about it in depth.

awesome, thanks!


neomutt: 20180716 -> 2019-10-25

Motivation for this change
https://github.com/neomutt/neomutt/releases/tag/2019-10-25
Please note that this is a release with a lot of changes (according to upstream), so we should have this tested by several people before merging :)
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

Notify maintainers
cc @

nix-review WFM macos 10.13

Works for me as well.


fix: unsubscribe the page subscription onDestroy to avoid memory leak

This PR fixes a memory leak on the client side.
If you navigate away from a page that uses the "initFlash" function, the page subscription will never finish and for every form action with the "use:enhance" it will throw an error:

I created a repro: https://github.com/stLmpp/flash-svelte-page-subscription

Install the dependencies
Run npm run dev
Use the anchor to navigate to the "other" route
Click the button to submit the form
Check the console to see the errors

Thank you! Will merge and release a patch soon.


Allow ModelStateDictionary to mark as invalid without having to explicitly add things to the dictionary

@sebastienros has a scenario for this which seems semi-interesting.

Closing because we are not planning to implement this.


Update silencer-lib, silencer-lib_2.13.6, ... to 1.7.9

Updates

com.github.ghik:silencer-lib
com.github.ghik:silencer-lib_2.13.6
com.github.ghik:silencer-plugin

from 1.7.6 to 1.7.9.
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Adjust future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "com.github.ghik" } ]

Or, add this to slow down future updates of this dependency:
dependencyOverrides = [{
  pullRequests = { frequency = "@monthly" },
  dependency = { groupId = "com.github.ghik" }
}]

labels: library-update, early-semver-patch, semver-spec-patch, commit-count:1

Superseded by #178.


Build wheel for mysqlclient on MacOS

I hope someone who use and know Mac can help :D

Nice, thank you.

We went looking everywhere, but couldn’t find those commits.

You don't have to squash the commits and force-push.

Oh right, should have checked the doc first :sweat_smile:


HTTP/1 flow control

#150
This does codec and connection flow control for HTTP/1, bringing it to feature parity with HTTP/2
I also seriously considered rewriting the codec to only have transient buffers, but I think that's higher risk so opted to go this route.

@alyssawilk just merged the other change. If you want to merge master I think this change will now be pretty controversial. I would love to land this and then we can deploy at Lyft and try to make sure everything is working for flow control outside of the filter level stuff.

It's not too bad.  I took out the explanation of unwinding that Harvey
rightly had me add over there and I'd already docced up and fixed HTTP1
unwinding which I think I found the right place for :-)
On Wed, Aug 16, 2017 at 2:02 PM, Matt Klein<EMAIL_ADDRESS>wrote:

@alyssawilk https://github.com/alyssawilk just merged the other change.
If you want to merge master I think this change will now be pretty
controversial. I would love to land this and then we can deploy at Lyft and
try to make sure everything is working for flow control outside of the
filter level stuff.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/lyft/envoy/pull/1435#issuecomment-322851888, or mute
the thread
https://github.com/notifications/unsubscribe-auth/ARYFvbypQLYzusnRg5mBbOaJs9ilOG3pks5sYy6sgaJpZM4OztZu
.

Sorry "controversial" was a typo. I edited the comment. I meant "non-controversial." :)

I'll take a look


algunos cambios a reto6 y reto 7 finalizado

Hello @rcccort! Thanks for opening this PR.


_.includes is not a function

I'm submitting a ...

[X] Bug report
[ ] Feature request
[ ] Question / Support request

For bug report please include this information:

Grafana Version 3.1.1 (commit: a4d2708)
Zabbix version 3.0.4
zabbix plugin version 3.1.0
OS Ubuntu
What did you do? Trying to open previously saved graphs and dashboards
What was the expected result? Graphs should works as well as on previous version
What happened instead? Graphs are empty. Browser console full of following errors:

boot.1649cbaa.js:36 TypeError: _.includes is not a function
at eval (datasource.js:427)
at Function.Va (boot.1649cbaa.js:41)
at bindFunctionDefs (datasource.js:426)
at eval (datasource.js:186)
at h (boot.1649cbaa.js:36)
at boot.1649cbaa.js:36
at n.$eval (boot.1649cbaa.js:36)
at n.$digest (boot.1649cbaa.js:36)
at n.$apply (boot.1649cbaa.js:36)
at boot.1649cbaa.js:36

I am experiencing the same, I believe this is related to Functions in general, if all functions are removed, graph loads fine.
Ubuntu: 14.04
Grafana: 3.1.0/3.1.1
Zabbix plugin version 3.1.0

Seems, it works only in grafana 4.0.0-pre builds. Lodash version was upgraded from 2.4 to 4.x so seems, this function has't backward compatibility.

Hi, so for use, we need do downgrade?

I've pushed fix to grafana.net, so upgrade to 3.1.1.

Work 100% , tks!!! ;)


How to disconnect?

Hi!
Is there any way to disconnect from redis when I'm finish?
i.e:
const ioEmitter = require('socket.io-emitter')

const io = ioEmitter({ host: 'localhost', port: 6379 })
io.emit('test')

// io.close() or something?

this may be useful for cli tools, or in CI

Actually, I need this only for auto-disconnect after tests running, so I've made this: https://github.com/socketio/socket.io-emitter/pull/69

@josser I think you should rather provide your own redis client:
const redisClient = createRedisClient();
const io = require('socket.io-emitter')(redisClient);

Yes, I've tried this but I'm using babel / es6 modules and node_redis doesn't work if I'm using import.
So, I've used approach of express-session - they added 'unref' option.
(sorry, my english is probably not good)

Well, in that case, I think the best would be to open an issue in node_redis repository. What do you think?

@darrachequesne sure, will do, but having 'unref' option also very useful. take a look at https://github.com/tj/connect-redis

Still, I'm not convinced we should use a "experimental" feature when there is a much cleaner solution..

@darrachequesne I agree that 'experimental' features is not good
but it has been experimental for about 4 years. it has been added in node_redis v0.8.6 - October 2, 2013

Closed due to inactivity, please reopen if needed.


v2.5.0-rc2 HTTP3 "QUIC is not supported"

Welcome!

[X] Yes, I've searched similar issues on GitHub and didn't find any.
[X] Yes, I've searched similar issues on the Traefik community forum and didn't find any.

What did you do?
enable the experimental http3 on entryPoint 443 and use it on http router
What did you see instead?
I'm using https://http3check.net/ to check my website, but it show me
QUIC is not supported

HTTP/3 Check failed to establish a QUIC connection for all attempts made with the given endpoint. See the connection errors below for more information.

Attempted 4 connection(s).
Received packets for 4 connection(s).
Successful handshake for 2 connection(s).

I already check the response header, it had Alt-Svc: h3-29=":443"; ma=2592000,h3-34=":443"; ma=2592000,h3-32=":443"; ma=2592000.
Besides enable the experimental http3 in traefik.yml, what should I do anything else?
What version of Traefik are you using?
v2.5.0-rc2
What is your environment & configuration?
traefik.yml
experimental:
  http3: true

entryPoints:
  http:
    address: ":80"
  https:
    address: ":443"
    enableHTTP3: true

api:
  dashboard: true

accessLog:
  fields:
    names:
      StartUTC: drop

providers:
  file:
    directory: /etc/traefik/dynamic_conf
    watch: true

dynamic_conf/main.yml
http:
  routers:
    www-http:
      entryPoints:
        - http
      rule: "Host(`ctf.example.com`)"
      middlewares:
        - redirect-to-https
      service: ctfd

    www-https:
      entryPoints:
        - https
      rule: "Host(`ctf.example.com`)"
      service: ctfd
      tls: {}

  services:
    ctfd:
      loadBalancer:
        servers:
          - url: "http://ctfd:8000/"

  middlewares:
    redirect-to-https:
      redirectScheme:
        scheme: https
        permanent: true

tls:
  certificates:
    - certFile: /ca/fullchain.pem
      keyFile: /ca/privkey.pem

If applicable, please paste the log output in DEBUG level
No response

Hi @chesskuo,
We tested your website to check http3 with Traefik and the result is that we support http3 but not QUIC.
If you don't have the sentence that says HTTP3 is supported, you probably need to open port 443 with UDP.
As the tool you mentioned is not very explicit, we can't know exactly what part is needed to be "QUIC compliant".
We may suppose it checks the Google QUIC compatibility without being sure.
Could you give more information?

@jbdoumenjou
Sir, thx for your reply.
At the first, in my docker-compose.yml, I already open TCP and UDP for 443 port at the same time, so the connection can upgrade to HTTP/3 correctly.
According the tool checking my website (https://http3check.net/?host=ctf.nisra.net), it returned my website already have HTTP/3, but doesn't support QUIC and showed some error msg about connection failed (QLog is at bottom).
And then I use this tool to check google.com, it doesn't show any error, so I think traefik maybe has something bug when creating QUIC connection. (But HTTP/3 is working perfectly, so I really have no idea about it...)

Hi everybody 🖖🏼
I tested the v2.5.0-rc2 as well and can confirm that the HTTP3Check will report that HTTP/3 is supported but shows no compatibility for QUIC.
@chesskuo how did you manage your TCP und UPD Port in your docker-compose.yml? I came across the following in the traefik documentation:

hey @thematchless
this is my docker-compose.yml:
version: '3.8'

services:
  traefik:
    image: traefik:v2.5.0-rc2
    container_name: traefik
    restart: always
    environment:
      - TZ=Asia/Taipei
    ports:
      - "80:80"
      - "443:443/tcp"
      - "443:443/udp"
    volumes:
      - ./conf:/etc/traefik
      - ./log:/var/log/traefik
      - ./ca:/ca
    networks:
      traefik:
        ipv4_address: <IP_ADDRESS>

networks:
  traefik:
    name: traefik
    attachable: true
    ipam:
      config:
        - subnet: <IP_ADDRESS>/24
          gateway: <IP_ADDRESS>

It is not especially at all.
I just forwarding TCP and UDP 443 to let http3 works.
According the docs you mentioned, I think it just talk about how is http3 working on traefik.
Setting enableHTTP3 in a TCP entrypoint, and then this TCP entrypoint will open a UDP at the same time.
So you cannot set this port for UDP, it will show you the port is been used.

Thanks for the reply @chesskuo 🙇🏼♂
That's exactly how I configured my system. But to be clear, that's just the Docker port mapping.
I was just wondering if you have made some more adjustments to traefik itself.
My understanding was that i have to configure multiple entrypoints:

my old one for TCP Connections (like 443)
one new explicit TCP Connection for UDP
map both entrypoints two your router

Now with your docker-compose file i understand that the explicit enableHTTP3 flag is enabling 443/udp for traefik. I tried multiple configurations even with a different UDP Port than 443, but it traefik seems to use only 443 for HTTP/3 as you can see in the HTTP headers.
Would be nice to have the possibility to configure the HTTP/3 Port as mentioned in https://github.com/traefik/traefik/issues/8130

@thematchless
But on my setting, http3 could work besides the port 443.
This is a example for my site.
I opened port 8443 to enable http3 and worked perfectly.
You can also check it by yourself, my site is still online now.

I provide some my configs, maybe it can help you.

docker-compose.yml
ports:
  - "80:80"
  - "443:443/tcp"
  - "443:443/udp"
  - "8443:8443/tcp"
  - "8443:8443/udp"

traefik.yml
entryPoints:
  http:
    address: ":80"
  https:
    address: ":443"
    enableHTTP3: true
  https2:
    address: ":8443"
    enableHTTP3: true

dynamic.yml
http:
  www-https:
    entryPoints:
      - https
      - https2
    rule: "Host(`ctf.nisra.net`)"
    service: ctfd
    tls: {}

I can confirm this.
tested with curl -v https://http3check.net
header for https://http3check.net has:
alt-svc: quic=":443"; ma=2592000; v="43,46", h3-Q043=":443"; ma=2592000, h3-Q046=":443"; ma=2592000, h3-Q050=":443"; ma=2592000, h3-25=":443"; ma=2592000, h3-27=":443"; ma=2592000
header for my site with traefik has:
alt-svc: h3=":443"; ma=2592000,h3-29=":443"; ma=2592000

I have this issue as well, for me browsers attempt to use HTTP/3 but fail with a HTTP 421 "Misdirected Request" error.
HTTP3Check:
HTTP/3 Check failed to establish a QUIC connection for all attempts made with the given endpoint. See the  connection errors below for more information.

Attempted 4 connection(s).

Received packets for 4 connection(s).
Successful handshake for 2 connection(s).

Same issue here. Firefox seems to load traefik dashboard by HTTP3 just fine:

yet http3check.net reports missing QUIC:

It's interesting that handshake isn't done in the first RTT. But maybe it's my misunderstanding.

@mradalbert what's the response code on those requests? for me it shows http/3 even when it returns a 421 response, but the page is actually loaded over http/2 (as far as I can tell)

200 OK over HTTP3 on all requests

I'm seeing some dodgy stuff on https://http3check.net/ atm (it seems to ignore the port I give it on the advanced tab), so I don't fully trust it.
@chesskuo  out of curiosity, what do you see when you test with https://geekflare.com/tools/http3-test ?

Same result, H3-29

Hello @mpl ,
When I used https://geekflare.com/tools/http3-test, I got the result same as @mradalbert.

 Same result, H3-29

@mradalbert I don't get it. You're saying same result, but https://geekflare.com/tools/http3-test does not report any problem, it does not say that "QUIC is not supported", right? So to me it's not exactly the same result, wrt to what an innocent user might conclude when comparing the results from both these websites.
I am starting to suspect that the only reason that https://http3check.net/ is showing this (badly explained on their part) warning, is because they expect the server to implement higher (than 29) drafts of HTTP/3 (I think the latest is 34 as of now).
And seeing as traefik relies on https://github.com/lucas-clemente/quic-go (which indeed is at h3-29 atm) , I think it might just be a matter of waiting for quic-go to implement more recent versions of the drafts for the "warning" to go away from https://http3check.net/
But there's a couple more things I'm going to test before moving on.

Geekflare only tests for the presence of the alt-svc header, not whether a QUIC connection cam actually be made. Tested this by disabling the udp port mapping in my docker compose, it still showed a successful test result.

Geekflare only tests for the presence of the alt-svc header, not whether a QUIC connection can actually be made. Tested this by disabling the udp port mapping in my docker compose, it still showed a successful test result.

That does not invalidate my suspicion, but good to know, thanks.

Caddy web server uses quic-go as well. Testing it against http3check.net would be valuable in narrowing down the issue.

@mradalbert or even simpler :-) :
I've just tested against a trivial Go server using quic-go , and I get results similar to what you all are observing.
package main

import (
	"net/http"

	"github.com/lucas-clemente/quic-go/http3"
)

type myhandler struct{}

func (mh myhandler) ServeHTTP(w http.ResponseWriter, r *http.Request) {
	w.Write([]byte("HELLO"))
}

func main() {
	http.Handle("/", myhandler{})
	http3.ListenAndServe(":443", "./cert.pem", "./key.pem", nil)
}

FYI to all, to sum up:

I'm not really worried about this being a traefik issue per-se, since we completely rely on quic-go
quic-go thinks it's just http3check.net being weird. And given that http3check is neither clear about what the problem is/are, nor do they have a public repo/bug tracker where we can give feedback, I'm inclined to rather give quic-go the benefit of the doubt for now.


Change password - Extra gap under validation button - Reported by: @parasharrajat

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Action Performed:
Navigate to Settings
Click on profile
Click on add phone number (secondary log in)
Check the button with dev tools
Expected Result:
Button area should only be consistent all around the button
Actual Result:
There's a empty gap below the button.

Workaround:
None needed.
Platform:

Where is this issue occurring?

Web
iOS
Android
Desktop App
Mobile Web

Version Number: 1.1.16-10
Reproducible in staging?: Yes
Reproducible in production?: Yes
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
Expensify/Expensify Issue URL:
Issue reported by: @parasharrajat
Slack conversation: https://expensify.slack.com/archives/C01GTK53T8Q/p1637865439012200
View all open jobs on GitHub

Triggered auto assignment to @MariaHCD (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

Looks like it's the same issue for this button as - https://github.com/Expensify/App/issues/6460. Created this issue separately but according to @parasharrajat it can be fixed in the same PR fix as the issue mentioned in this comment.

Proposal

Remove the extra margin from the button https://github.com/Expensify/App/blob/85d9a21850ef8583a0ab6fb937b60751b9311385/src/pages/settings/PasswordPage.js#L239

FixedFooter already handles the correct gapping.
From the @isagoico Comment,
I think I can solve this into the same PR for #6460 but I asked her to create a separate ticket as this was not known to us when 6460 was found. and As I come to know of this later while fixing some other issue. So this should be considered separate (Looking at the history of issues we have).

@MariaHCD Whoops! This issue is 2 days overdue. Let's get this updated quick!

@MariaHCD Huh... This is 4 days overdue. Who can take care of this?

@MariaHCD Still overdue 6 days?! Let's take care of this!

@mallenexpensify Could you please triage this? Maria seems to be OOO.

Triggered auto assignment to @adelekennedy (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

I'm going to go out on a limb and say this can be worked on by a contributor...
@adelekennedy I posted for ya cuz it's 5pm on a Friday and I wanted to get a CME assigned to review Rajat's proposal above

Triggered auto assignment to @parasharrajat (Exported)

Triggered auto assignment to @stitesExpensify (Exported), see https://stackoverflow.com/c/expensify/questions/7972 for more details.

Proposal

Remove margin bottom to remove the unnecessary space below the button

https://github.com/Expensify/App/blob/85d9a21850ef8583a0ab6fb937b60751b9311385/src/pages/settings/PasswordPage.js#L239

We have a similar issue for the secondary login page, and the fix for it is the same as the fix for this that @parasharrajat had already suggested. Let's have him fix both.

@parasharrajat and @deetergp I can open and hire Rajat for this job, or, we can add a bonus to the other issue - thoughts?

If the end amount is the same for @parasharrajat, then I'm in favor of whichever has less administrative overhead, but Rajat may have different thoughts.

I think opening a job for this is fine. In the end, it becomes confusing to manage multiple issues in one. Also, I will be submitting a new PR for this. The other one is already merged. @adelekennedy

Submitted the proposal on https://www.upwork.com/jobs/~01478dd14ed4b583ec

@parasharrajat Hired herein this case I assume we'd still pay out the reporting bonus for this job as well?

The solution for this issue has been :rocket: deployed to production :rocket: in version 1.1.18-3 and is now subject to a 7-day regression period :calendar:. Here is the list of pull requests that resolve this issue:

https://github.com/Expensify/App/pull/6600

If no regressions arise, payment will be issued on 2021-12-15. :confetti_ball:

Paid!

@adelekennedy Will there by a reporting bonus as well?


Doc command line doesn't much help

There doesn't seem to be command lines in your current release, depsite the docs referring to them?
Can you make a new release if things have changed. Needed for packaging in brew/conda.
%  squeakr-count  -h
./squeakr-count [OPTIONS]
file format   : 0 - plain fastq, 1 - gzip compressed fastq, 2 - bzip2 compressed fastq
CQF size      : the log of the number of slots in the CQF
num of threads: number of threads to count
file(s)       : "filename" or "dirname/*" for all the files in a directory

I've done one for 0.5 here: https://github.com/brewsci/homebrew-bio/pull/68
Ping me here when you make a new release.

Hi @tseemann , we have now integrated a command-line interface in Squeakr in the latest release.
Thanks,
Prashant

Thanks @prashantpandey  - trying to update package for 0.6 now.


Score is always submitted, even outside of Competitive Mode

Need a condition to check for competitive mode before submitting. Should be a one-line fix or less.

Added a check for competitive mode: 8917dd1f4c72d6a67ea79ebc808a3997324ec627
This should work properly now.


add example workload (with syn attack)

The workload is based on GoogleCloudPlatform/microservices-demo
Syn attack is based on docker and an example from https://github.com/bilalcaliskan/syn-flood

is that something where you can leverage netobserv to spot the attack? how would you demo that? (I'm interested if I can reuse that use-case in demo/talk :) )

Maybe this syn attack traffic is not "seen" by OVS/N ... I need to check more

@jpinsonneau I see strange amount of packets (on the edges) when I change the view to show the number of packets::

I was expecting a very small amount. And BTW; I see the same in the table ... so something is not making sense here:

maybe with sampling = 1?


Revert "fix for #4534, find xcode without spotlight"

Reverts realm/realm-cocoa#4536
This was causing issues both when running on CI and locally. See https://ci.realm.io/job/objc_osx/1875/console and https://ci.realm.io/job/objc_ios/1857/console for examples.
Fails with the following error message:
Check dependencies
2017-01-18 13:07:51.435 xcodebuild[41326:920235] Error Domain=IDETestOperationsObserverErrorDomain Code=3 "Test operation was canceled. If you believe this error represents a bug, please attach the log file at /Users/jp/Projects/realm-cocoa/build/DerivedData/Realm/Logs/Test/F22480B2-1F81-4DD6-A0B4-FE5625567132/Session-ObjectServerTests-2017-01-18_130617-oP0uDI.log" UserInfo={NSLocalizedDescription=Test operation was canceled. If you believe this error represents a bug, please attach the log file at /Users/jp/Projects/realm-cocoa/build/DerivedData/Realm/Logs/Test/F22480B2-1F81-4DD6-A0B4-FE5625567132/Session-ObjectServerTests-2017-01-18_130617-oP0uDI.log}
“Use Legacy Swift Language Version” (SWIFT_VERSION) is required to be configured correctly for targets which use Swift. Use the [Edit > Convert > To Current Swift Syntax…] menu to choose a Swift version or use the Build Settings editor to configure the build setting directly.
warning: no umbrella header found for target 'RealmSwift', module map will not be generated

FYI @larkost


Log Exporter - don't use a static id for fileprovider

Today, our log export tool uses a static ID for the content provider (fileprovider) in the Log Exporter tool, with no references to the host application. Because of this, you can't install 2 different apps on the same device that both include the Log Exporter tool.
Instead, we should make the ID dynamic based on the app the tool is used in, like something like $hostAppId + live.ditto.dittotoolsapp.fileprovider

Using the host app id is a suggestion, but one that makes the most sense (to me, open to more suggestions).
The particular entry in the AndroidManifest.xml is android:authorities="live.ditto.dittotoolsapp.fileprovider" - would have to look into how we can make that dynamic.


fixed and issue of calc with the latest postcss upgrade

Coverage remained the same at 62.069% when pulling 8085bd0c029d42c1e41d1d8b279759bffa92e634 on release/1.1.5 into c0fdeac10b257e85ca013a22677b15bc28097a62 on master.


Error updating to Ghost 5.80 from 5.23, blog down, please help

Issue Summary
Hello, I just updated my Ghost blog from 5.23 to 5.80.
After the update, I tried to restart Ghost, but it fails with this message:
Ghost instance is not running! Starting...
✖ Starting Ghost
A GhostError occurred.
Message: Ghost was able to start, but errored during boot with: insert into `collections_posts` (`collection_id`, `id`, `post_id`, `sort_order`) select '65f02f0dafb7eeb96c4c90a6' as `collection_id`, '65f02f0dafb7eeb96c4c90a8' as `id`, '637a812a81cfb759fad27265' as `post_id`, 0 as `sort_order` union all select '65f02f0dafb7eeb96c4c90a6' as `collection_id`,
... (many more rows) ...
, '65314decb0c970c6a6eca545' as `post_id`, 0 as `sort_order` - SQLITE_ERROR: too many terms in compound SELECT
Context: [object Object]
Help: Error occurred while executing the following migration: 2023-07-10-05-16-55-add-built-in-collection-posts.js

Debug Information:
OS: Debian GNU/Linux, v11
Node Version: v18.19.1
Ghost Version: 5.80.2
Ghost-CLI Version: 1.25.3
Environment: development
Command: 'ghost restart'
mysql Ver 8.0.27 for Linux on x86_64 (MySQL Community Server - GPL)
Steps to Reproduce
Start with an install of v5.23 or below 5.80
Apparently the number of posts can be a cause, so get more than 500 posts.
Run ghost update and ghost restart
Ghost Version
5.80.2
Node.js Version
v18.19.1
How did you install Ghost?
Command line
Database type
MySQL 5.7
Browser & OS version
Chrome, MacOS
Relevant log / error output
Ghost instance is not running! Starting...
✖ Starting Ghost
A GhostError occurred.

Message: Ghost was able to start, but errored during boot with: insert into `collections_posts` (`collection_id`, `id`, `post_id`, `sort_order`) select '65f03420dd3af6bb83e5ad3d' as `collection_id`, '65f03420dd3af6bb83e5ad3f' as `id`, '637a812a81cfb759fad27265' as `post_id`, 0 as `sort_order` union all select '65f03420dd3af6bb83e5ad3d' as `collection_id`, '65f03420dd3af6bb83e5ad40' as `id`, '637a812a81cfb759fad27266' as `post_id`, 0 as `sort_order` union all select '65f03420dd3af6bb83e5ad3d' as `collection_id`, '65f03420dd3af6bb83e5ad41' as `id`, '637a812a81cfb759fad27267'
... (rows ommited)...
, '65f03420dd3af6bb83e5afe3' as `id`, '65314decb0c970c6a6eca545' as `post_id`, 0 as `sort_order` - SQLITE_ERROR: too many terms in compound SELECT
Context: [object Object]
Help: Error occurred while executing the following migration: 2023-07-10-05-16-55-add-built-in-collection-posts.js

Code of Conduct

[X] I agree to be friendly and polite to people in this repository

Ok, I managed to solve it manually. The issue is in the script 2023-07-10-05-16-55-add-built-in-collection-posts.js.
Specifically, in this function:
const insertPostCollections = async (knex, collectionId, postIds) => {
    logging.warn(`Batch inserting ${postIds.length} collection posts for collection ${collectionId}`);

    const collectionPosts = postIds.map((postId) => {
        return {
            id: (new ObjectID()).toHexString(),
            collection_id: collectionId,
            post_id: postId,
            sort_order: 0
        };
    });

    await knex.batchInsert('collections_posts', collectionPosts, 1000);
};

The problem is the batch size. I guess it does not make sense to have it set to 1000 if the maximum size for batch inserts in MySQL is 500. So lowering to 100 for example does the trick.
Now, can you kindly confirm that even by reducing the batch size to 100, all posts would be updated in the database as per the new Ghost 5.80 requirements? (looking at the code, it seems that is the case, but just want to be sure).
Thank you. A PR here would be quite easy I guess, just decreasing the limit to 100.

In order to fix this issue we need a few things:

A replication of the error
A batchSize which fixes the error
A new helper which wraps knex.batchInsert and forces it to use our safe batch size
Updating all uses of the knex.batchInsert to use the new helper

@allouis It's possible to take a "good now, better later" approach here.
If the PR https://github.com/TryGhost/Ghost/pull/21063 is adjusted down to use a value of 100, it will solve some known, reported case were people are running into this SQLite limit and the code quality will be no worse than the current code which hardcodes a limit of 1,000 rather than 100. That's a good solution that can help now. Per above, the value of 100 has been tested.
What you describe here is a more ideal solution with a test-suite-ready replication and a helper method. Although, the helper method will only help if people remember to use it instead of knex.batchInsert.
An alternate path forward is to merge the PR adjusted to a batch size of 100 while also leaving this issue open for a more ideal approach later.

@markstos Absolutely! If this is still an issue for people and we have a PR that solves it - I'm happy to merge 😁
FWIW I wasn't asking for a test suite replication - a manual one would have been fine - the problem is that the original PR didn't fix the issue - so I'd like to be sure that anything we merge does fix an issue!
I'll reopen that PR for you now - thank you for coming back and taking an interest - it's appreciated!

This can be closed, it was resolved by #21063 in the next release after 5.99.

Closed by 2d5230e


fix(LICENSE): Updating date

:tada: This PR is included in version 1.0.1 :tada:
The release is available on npm package (@latest dist-tag)
Your semantic-release bot :package::rocket:


Box2D: World.destroyBody doesn't check if body is already destroyed

Issue details
I have noticed, that World object from gdx-box2d extention doesn't check if Body is already destroyed. This leads to the issue when one Body is stored in freeBodies Pool twice (freeBodies.free(body);). So, next time createBody is requested, the same object will be returned twice (like it's a new one). This leads for the world.step() to enter endless-loop (I assume).
Reproduction steps/code
final Body body = world.createBody(bodyDef);
// ...
world.destroyBody(body);
world.destroyBody(body); // the same body

final Body body1 = world.createBody(bodyDef);
final Body body2 = world.createBody(bodyDef); // the same as `body1`

Version of LibGDX and/or relevant dependencies
Tested with 1.9.6 & 1.9.7
Please select the affected platforms

[x] Android
[ ] iOS (robovm)
[ ] iOS (MOE)
[ ] HTML/GWT
[ ] Windows
[ ] Linux
[x] MacOS
(most likely all, but I haven't tested on all platforms)

Box2D does not check if a body has already been destroyed, and it is never something you should do. LibGDX side we simply follow suite in our thin wrapper.
There are probably a lot of occasions where we could add safety checks, but I'm against these and would rather just stick to having the thinnest wrapper and delegate to the Box2D api.


Add and update Dutch translations

Fixed inconsistencies and errors, added a couple of missing translations.

Thank you!


Error when creating document type within a document type folder

An error of "object reference not set to an instance" occurs in the back-office.

Thanks a lot. I added a unit-test for the entity helper while waiting. Should def. eat my own medicine and up the coverage in general. :D


I updated the ReadMe and Added the Build Directory to Gitignore.

I updated the ReadMe to help provide the missing commands I had to use to compile the library and example program on the Raspberry Pi 3. I haven't tested encryption yet, so I may still have to tweak it later, but I was able to connect to my own MQTT server running on the RPi.
Also, I added the build directory to .gitignore as I don't believe the autogenerated build folder should be stored in a git repo.
For future notes, I am working on compiling this on my Mac, so I can then wrap this library with a Godot Module for my game. So, I'll update the ReadMe for OSX users and eventually Windows.


Animation not playing on XF Android platform

🐛 Bug Report
Animation not playing
Expected behavior
It should play on both platform in a XF project
Configuration
Set the animation to isPlaying=true
Version: 3.0.2
Platform:

[ ] :iphone: iOS
[x] :robot: Android
[ ] :checkered_flag: WPF
[ ] :earth_americas: UWP
[ ] :apple: MacOS
[ ] :tv: tvOS
[x] :monkey: Xamarin.Forms

Please provide better information or a reproduction case