Operation system vulnerabilities summary is too generic

Hi, it seems like the summary field of every OS ecosystem is "{pacakgeName} - security update".
Example:
curl --location 'https://api.osv.dev/v1/query' \
--header 'Content-Type: application/json' \
--data '{
       "package": {
       "purl":"pkg:deb/debian/openssl"
      }
    }'

Expected:
A short description of the vulnerability.

Hi @fingeromer (/cc @another-rex for visibility)
The summary is generated by this code:
https://github.com/ossf/osv-schema/blob/b3ae8f157b7487cdd7fddd63f2e2af7d1760cfa6/tools/debian/convert_debian.py#L232
Looking at the source data, and a sample record, namely:

DLA-0003-1

sourced from https://security-tracker.debian.org/tracker/CVE-2014-0195

I'm not sure of a better strategy we can use to generate these records?

@andrewpollock what do you think about showing the CWE name of the CVE?
for example for  https://security-tracker.debian.org/tracker/CVE-2014-0195
the CWE is https://cwe.mitre.org/data/definitions/120.html
so the summary can be 'Buffer Copy without Checking Size of Input ('Classic Buffer Overflow')'

what do you think about showing the CWE name of the CVE?

I agree that this would provide additional context. This would require a CVE to CWE lookup table or trip through the NVD API to determine the CWE for a CVE. I also think there's a 1:many relationship between CVEs and CWEs, so we'd also have to determine which CWE to use (or just pick the first one when there's more than one).

@andrewpollock what do you think about showing the CWE name of the CVE? for example for https://security-tracker.debian.org/tracker/CVE-2014-0195 the CWE is https://cwe.mitre.org/data/definitions/120.html so the summary can be 'Buffer Copy without Checking Size of Input ('Classic Buffer Overflow')'

Eyeballing the output of:
curl --location 'https://api.osv.dev/v1/query' --header 'Content-Type: application/json' --data '{
       "package": {
       "purl":"pkg:deb/debian/openssl"
      }
    }' | jq '.vulns | map(select(.id | startswith("CVE-") | not) | {id, related: .related | length, summary})'

I don't think this approach is going to work reliably because I can see many of these advisories aggregate multiple CVEs, so there would be no good way to identify which CWEs were most appropriate put into the summary.
I note that not all of the summaries are as pathologically bad as you quote, too.


linter: react/rule-of-hooks false positives

https://github.com/oxc-project/oxlint-ecosystem-ci/actions/runs/9061291729/job/24892841948?pr=2
I haven't checked the details, but I temporary moved the rule nursery https://github.com/oxc-project/oxc/commit/6edcae86cda8922ea8f9e5eae91290018e1b1637 and is making a new release.

I ran it in our product repo just now and it reported 232 false positives 😬. Will try to come up with a short repro when I have time. All the cases I saw were reporting

eslint-plugin-react-hooks(rules-of-hooks): React Hook "useEffect" may be executed more than once. Possibly because it is called in a loop. React Hooks must be called in the exact same order in every component render

The components do not have any loops

export const FalsePositive = ({ editor, anchorElem, isLink, linkNodeUrl, close }: Props) => {
  // This custom hook invocation seems to trigger false positives below
  const [state, setState] = useCustomHook<State>({
    inputLinkUrl: linkNodeUrl ?? '',
    editable: !isLink,
    lastLinkUrl: '',
    lastSelection: null
  });

  const [someThing, setSomeThing] = useState(true);

  const onEdit = useCallback(() => setSomeThing(false), [inputLinkUrl, setSomeThing]);

  const updateLinkEditor = useCallback(() => {
    const rootElement = editor.getRootElement();

    if (nativeSelection.anchorNode === rootElement) {
      let inner = rootElement;
      while (inner.firstElementChild !== null) {
        inner = inner.firstElementChild as HTMLElement;
      }
    }
  }, [anchorElem, editor, setSomeThing]);

  return
test
;
};

  × eslint-plugin-react-hooks(rules-of-hooks): React Hook "useState" may be executed more than once. Possibly because it is called in a loop. React Hooks must be called in the exact same order in every component render.
    ╭─[imports/ui/client/components/compose/lexical/plugins/FloatingLinkPlugin/components/FloatingLinkEditor/FloatingLinkEditor.tsx:53:37]
 52 │
 53 │   const [someThing, setSomeThing] = useState(true);
    ·                                     ──────────────
 54 │
    ╰────

  × eslint-plugin-react-hooks(rules-of-hooks): React Hook "useCallback" may be executed more than once. Possibly because it is called in a loop. React Hooks must be called in the exact same order in every component render.
    ╭─[imports/ui/client/components/compose/lexical/plugins/FloatingLinkPlugin/components/FloatingLinkEditor/FloatingLinkEditor.tsx:55:18]
 54 │
 55 │   const onEdit = useCallback(() => setSomeThing, [inputLinkUrl, setSomeThing]);
    ·                  ─────────────────────────────────────────────────────────────
 56 │
    ╰────

  × eslint-plugin-react-hooks(rules-of-hooks): React Hook "useCallback" may be executed more than once. Possibly because it is called in a loop. React Hooks must be called in the exact same order in every component render.
    ╭─[imports/ui/client/components/compose/lexical/plugins/FloatingLinkPlugin/components/FloatingLinkEditor/FloatingLinkEditor.tsx:57:28]
 56 │
 57 │ ╭─▶   const updateLinkEditor = useCallback(() => {
 58 │ │       const rootElement = editor.getRootElement();
 59 │ │
 60 │ │       if (nativeSelection.anchorNode === rootElement) {
 61 │ │         let inner = rootElement;
 62 │ │         while (inner.firstElementChild !== null) {
 63 │ │           inner = inner.firstElementChild as HTMLElement;
 64 │ │         }
 65 │ │       }
 66 │ ╰─▶   }, [anchorElem, editor, setSomeThing]);
 67 │
    ╰────

Thanks for providing these examples, The ones without any loop inside of them are really weird to me. I check back edges for detecting cyclic flows and I already know some issues with the current cfg implementation that I'm going to fix while working on #3238.
None of these seems to have a back edge at first glance, I have an idea of how to fix the last one but I have to investigate others that don't have any loop while reporting it.
If there is any other weird situation please make sure to dump them here. I can use them as test cases while working on an improved cfg and follow-up PR for this rule.

After upgrade to 0.4.1 all false positives are gone except 1 scenario. The rule does not seem to handle higher order components correctly:
const Test = withCreatedModals(({ children, createdModals }: Props) => {
  const params = useParams<{ workspaceId: string; postId: string }>();

  return
hello
;
});

  × eslint-plugin-react-hooks(rules-of-hooks): React Hook "useParams" cannot be called inside a callback. React Hooks must be called in a React function component or a custom React Hook function.
     ╭─[imports/ui/client/context/SplitLayoutContext/index.tsx:142:18]
 141 │ const Test = withCreatedModals(({ children, createdModals }: Props) => {
 142 │   const params = useParams<{ workspaceId: string; postId: string }>();
     ·                  ────────────────────────────────────────────────────
 143 │
     ╰────

After upgrade to 0.4.1 all false positives are gone except 1 scenario. The rule does not seem to handle high order components correctly:
const Test = withCreatedModals(({ children, createdModals }: Props) => {
  const params = useParams<{ workspaceId: string; postId: string }>();

  return
hello
;
});

  × eslint-plugin-react-hooks(rules-of-hooks): React Hook "useParams" cannot be called inside a callback. React Hooks must be called in a React function component or a custom React Hook function.
     ╭─[imports/ui/client/context/SplitLayoutContext/index.tsx:142:18]
 141 │ const Test = withCreatedModals(({ children, createdModals }: Props) => {
 142 │   const params = useParams<{ workspaceId: string; postId: string }>();
     ·                  ────────────────────────────────────────────────────
 143 │
     ╰────

Well, those errors are intentional, But we may want to change it to a warning. I'm not sure how large of an impact this change is going to have, Tell me about your experience; How many false positives are out there in your project? and how many higher-order components do you guys have? do you think a whitelist for those function names can be more sufficient here?
Looking forward to your feedback.

Happy to hear that!


Documentation + examples

More examples.

Work on documentation, that includes also examples, is in progress. Current state is available on https://epsylabs.github.io/serverless-builder/


Add HikariCP metrics

Inject misk.metrics.Metrics which is bound as a singleton, and we can expose its CollectorRegistry - that way you are using the same registry instance as the rest of the system

Inject misk.metrics.Metrics which is bound as a singleton, and we can expose its CollectorRegistry - that way you are using the same registry instance as the rest of the system

@mmihic the CollectorRegistry is also bound as a singleton. I can still update though so we have the higher-level interface available?

@mmihic should we just HibernateModule require a binding to misk.metrics.Metrics? That would let us avoid having to fuddle around with optional injection or data source decorators. It wouldn't really impact internal use since Skim would bind it, but seems not so great for open source use.

@mmihic should we just HibernateModule require a binding to misk.metrics.Metrics? That would let us avoid having to fuddle around with optional injection or data source decorators. It wouldn't really impact internal use since Skim would bind it, but seems not so great for open source use.

I think that's reasonable. Most other "upper level components" require a binding to this for their own metrics, so having HibernateModule do the same is imo fine. misk.metrics.Metrics is the mechanism for accessing metrics

Ended up making it optional, since it was a simple change.
Updated it to use Metrics rather than CollectorRegistry directly.


Mega 2560 - 0.28.4 - The distance diffirent after change speed

Hi gin66, thank you so much for your lib.
But i have issue when using mega 2560, first it maximum 1000hz if i using your 30.4 library, So i must using 28.4
On 28.4, I don't know why when i change speed the distance will diffirent. When the speed is slow the distance go longer.  The code using Zero like this and moveto:
bool zeroservo(FastAccelStepper *servo, ServoMM *servodata, byte zerosensor,
float speed) {
bool done;
if (!servo->isRunning()) {
if (digitalRead(zerosensor)) {
servo->setSpeedInHz(speed);
servo->move(-1000000);
onzero = true;
} else
goto d;
	while (digitalRead(zerosensor)) {

		if (!servo->isRunning())
			goto a;
		if (stopnow == 1)
			goto b;
		loop();

	}
	d:
	//servo->stopMove();
	servo->forceStopAndNewPosition(0);
	while (servo->isRunning())
		;
	//Serial.println(servodata->zeropoint_offset);
	servo->move(servodata->zeropoint_offset);

	while (servo->isRunning()) {

		loop();
	}
	servo->setPositionAfterCommandsCompleted(0);
	servodata->homed = 1;
}
onzero = false;
return 1;
b: stopnow = 0;
servodata->homed = 1;
onzero = false;
a:

return 0;

}
Pls support me

For better understanding: Where is zeroservo() called ? Inside loop() or in setup() ?

I call it throught serial.

not clear. Could you please provide more of your code ?
There are calls to loop() within this function. This smells like a recursive use of loop(), which may cause all sorts offside effects.


Filter execution probelm

From @cmarkello on April 13, 2016 19:49
Filters on both the Default and Research facing sides of the website are properly querying the server for data, but are not updating what is shown on the website until another interaction that changes a state variable is made.
This causes a lag were when a filter is made, only the results of the previous filter is shown. Afterwards, when you click on a hide/show button, the website then displays the correctly filtered dataset.
This is likely an issue with how the React component lifecycle functions were implemented in the DataTable component.
Copied from original issue: BD2KGenomics/brca#154

From @cmarkello on April 13, 2016 20:51
More specifically it's an issue with how the shouldComponentUpdate function was implemented.

Moving to brca-website

From @benedictpaten on April 15, 2016 16:48
Is this fixed?


Add dropdown filter to show rooms, languages, session types. Ensure it works in mobile view.

The previous eventyay version had different kinds of filters. Implement filters for the following as well on
a) the Schedule page and
b) the Sessions page.
Ensure this also works on mobile views. Compare to https://eventyay.com/e/55d2a466/schedule

Rename current "Filter" to "Tracks" and make it into a dropdown list.

Add more dropdown filters as follows:

Rooms
Languages
Session types

Also add an option to clear the filters

Ensure it works on mobile similarly to the previous version.

The dropdown menu works, but there is an issue with the types filter @lcduong


Alfred 4 incompatible

Hi there,
I am getting the following error when I want to install this as an Alfred 4 Workflow:
error /Users/mbroder/.config/yarn/global/node_modules/alfred-npms: Command failed.
Exit code: 1
Command: alfy-init
Arguments:
Directory: /Users/mbroder/.config/yarn/global/node_modules/alfred-npms
Output:
{ Error: Command failed: alfred-link
Error: `Alfred.alfredpreferences` package does not exist
    at resolveAlfredPrefs.then.then.prefsExists (/Users/mbroder/.config/yarn/global/node_modules/alfred-link/index.js:27:12)

    at makeError (/Users/mbroder/.config/yarn/global/node_modules/execa/index.js:174:9)
    at Promise.all.then.arr (/Users/mbroder/.config/yarn/global/node_modules/execa/index.js:278:16)
    at processTicksAndRejections (internal/process/task_queues.js:86:5)
  code: 1,
  stdout: '',
  stderr:
   'Error: `Alfred.alfredpreferences` package does not exist\n    at resolveAlfredPrefs.then.then.prefsExists (/Users/mbroder/.config/yarn/global/node_modules/alfred-link/index.js:27:12)\n',
  failed: true,
  signal: null,
  cmd: 'alfred-link',
  timedOut: false,
  killed: false }
info Visit https://yarnpkg.com/en/docs/cli/global for documentation about this command.

Would be great if we can get it to work with Alfred 4

Upstream dependencies have problems and are being resolved. Detail: https://github.com/sindresorhus/alfy/issues/110

Check out this comment for a temp fix: https://github.com/sindresorhus/alfy/issues/110#issuecomment-499289678

We released a patch update to fix this bug. You could rerun npm i -g alfred-npms to get it to work. 😄


is ipapi csv's conversion supported?

i want to use the csv DB file from https://ipapi.is/developers.html#geolocation-database  but when i try to convert it with:
mmdbctl import --in geolocationDatabaseIPv4.csv --out data.mmdb
i get error:
err: couldn't parse cidr "4/32": invalid CIDR address: 4/32
Why is it giving this error?
Is it possible you can see if you can make this conversion for ipapi csv's compatible with mmdbctl?
thanks in advance
ps: surprised no-one has mentioned ipapi.is db's

Hi, I took a closer look at the database and found some inconsistencies that make it difficult to import an MMDB dataset.
ipapi_is_convert $ mmdbctl import --in data.csv --out data.mmdb

warn: couldn't insert line '<IP_ADDRESS>,<IP_ADDRESS>,EU,PL,Poland,Mazovia,Warsaw,05-077,Europe/Warsaw,52.22977,21.01178,1'
warn: couldn't insert line '<IP_ADDRESS>,<IP_ADDRESS>,EU,FR,France,Île-de-France,Paris,75998 CEDEX 14,Europe/Paris,48.85341,2.3488,1'
warn: couldn't insert line '<IP_ADDRESS>,<IP_ADDRESS>,AS,MY,Malaysia,Selangor,Putra Heights,47130,Asia/Kuala_Lumpur,2.9679,101.653,1'
warn: couldn't insert line '<IP_ADDRESS>,<IP_ADDRESS>,AS,MY,Malaysia,Selangor,Putra Heights,47130,Asia/Kuala_Lumpur,2.9679,101.653,1'
writing to data.mmdb (1317771 entries)

<IP_ADDRESS>

This is a not valid IPv4 address. Notice the 9.

<IP_ADDRESS>,<IP_ADDRESS>

The end_ip is greater than the start_ip.
The database was downloaded: Feb 27, 2024

Hi, I took a look at the database and it seems that the CSV database is not consistent.
mmdbctl import --in data.csv --out data.mmdb

Output
warn: couldn't insert line '<IP_ADDRESS>,<IP_ADDRESS>,EU,PL,Poland,Mazovia,Warsaw,05-077,Europe/Warsaw,52.22977,21.01178,1'
warn: couldn't insert line '<IP_ADDRESS>,<IP_ADDRESS>,EU,FR,France,Île-de-France,Paris,75998 CEDEX 14,Europe/Paris,48.85341,2.3488,1'
warn: couldn't insert line '<IP_ADDRESS>,<IP_ADDRESS>,AS,MY,Malaysia,Selangor,Putra Heights,47130,Asia/Kuala_Lumpur,2.9679,101.653,1'
warn: couldn't insert line '<IP_ADDRESS>,<IP_ADDRESS>,AS,MY,Malaysia,Selangor,Putra Heights,47130,Asia/Kuala_Lumpur,2.9679,101.653,1'

Please note the following:

<IP_ADDRESS>

The 024 contains the starting digit of 0, which results in the mmdbctl database declaring it to be an invalid IP address. This should be <IP_ADDRESS>.
IPapi.is recognizes IP address to be valid: https://api.ipapi.is/?q=<IP_ADDRESS>
But IPinfo does not: https://ipinfo.io/<IP_ADDRESS>/json

<IP_ADDRESS>,<IP_ADDRESS>

This is not a valid IP range as the end_ip value precedes the start_ip value.
If the IP database can return consistent and valid rows, there should be no problem using mmdbctl to convert the CSV dataset to the MMDB dataset.
In the meanwhile, feel free to check out IPinfo's free IP database: https://ipinfo.io/products/free-ip-database
Let me know what you think. Thanks!

@jkuj6
I noticed that you are trying to set up NGINX with a geolocation database. You can check out IPinfo's free IP to Country database for that. Here are the instructions: https://ipinfo.io/blog/nginx-for-access-control-and-privacy-policies/

Fixed in commit https://github.com/ipapi-is/ipapi/commit/ec751295c80e502ae8b67cba7f6b7d53e9a71346
You should be able to convert it now.

How does my CSV file need to be structured in order to read it into MMDB format?
mmdbctl import --in geolocationDatabaseIPv4.csv --out data.mmdb

fails with
err: couldn't parse cidr "4/32": invalid CIDR address: 4/32

My file does not contain CIDR ranges. That's a strange error.
My file looks like this:
ip_version,start_ip,end_ip,continent,country_code,country,state,city,zip,timezone,latitude,longitude,accuracy
4,<IP_ADDRESS>,<IP_ADDRESS>,EU,RU,Russia,Свердловская Область,Yekaterinburg,901079,Asia/Yekaterinburg,56.8519,60.6122,2
4,<IP_ADDRESS>,<IP_ADDRESS>,EU,NO,Norway,Nordland,Bodø,8108,Europe/Oslo,67.2981512081068,14.399771690368652,2
4,<IP_ADDRESS>,<IP_ADDRESS>,NA,US,United States,Noord-Holland,Amsterdam,1109,Europe/Amsterdam,52.36889170602552,4.8944091796875,2
4,<IP_ADDRESS>,<IP_ADDRESS>,NA,US,United States,Noord-Holland,Amsterdam,1109,Europe/Amsterdam,52.36889170602552,4.8944091796875,2
4,<IP_ADDRESS>,<IP_ADDRESS>,NA,US,United States,Noord-Holland,Amsterdam,1109,Europe/Amsterdam,52.36889170602552,4.8944091796875,2

Hi,
The mmdbctl tool accepts files in a CSV format that begin with start_ip and end_ip columns. The first column of the IPapi.is IP database is ip. If you remove that column and try again, it will work. Can you please check? Thanks.

Remove first column from the database:
cut -d, -f2- geolocationDatabaseIPv4.csv > data.csv

Then convert:
mmdbctl import --in data.csv --out data.mmdb

that works like a charm and yields:
writing to data.mmdb (1347178 entries)

Looks like the issue has been resolved. Feel free to reopen if the problem persists. Thank you.


🐛 Data should be consistent for "When is Jake on client work"

Cc: @jimmidier

Describe the Bug

When asking "When is Jake on client work", SophieBot gives inconsistent data.
To Reproduce
Steps to reproduce the behavior:

Go to 'Teams'
Type 'When is Jake on client work'
See inconsistent data.

Expected Behavior

SophieBot should give the same data as the PowerBI reports indicate.
Tasks

[x] Investigate
[x] Fix

Screenshots

Figure: SophieBot returns a date 24th Jan.

Figure: PowerBI report shows Jake is booked today.
Thanks!

Fixed by separating next unavailability calculation from "next 4 weeks" and "starting today"

Figure: In this case we do a "next unavailability starting today"


Separate Asp.Net Core

The Asp.Net Core sample should be updated after publishing a stable version of the package

Thanks, much appreciated


replace memmove in attribute-size.cpp and related code with memcpy

Problem
This arose in discussions in #7325.  We have a lot of code calling memmove like this in and around attribute-size.cpp:
void copyListMember(uint8_t * dest, uint8_t * src, bool write, uint16_t * offset, uint16_t length)
{
    if (write)
    {
        memmove(dest + *offset, src, length);
    }
    else
    {
        memmove(dest, src + *offset, length);
    }

    *offset = static_cast<uint16_t>(*offset + length);
}

This implies that callers may be able to support in-place manipulation of src/dest buffers.  That's misleading though because if many separate memmove operations occur on the src/dest buffers (as will usually be the case), then in-place manipulation is actually not safe except for the narrow case where src and dest are the same address and there is no macro reorganization of src as it is moved to the destination buffer.
Consider:
void macro_memmove(uint8_t *src, uint8_t *dst)
{
    memmove(dst, src, 2);
    memmove(dst + 2, src + 2, 2);
    // oops; if dst == src + 2, this breaks
}
```

So in fact, we actually cannot support overlapping src/dst buffers like a single memmove call can.  And, we don't use overlapping buffers anyway.  Thus, it makes sense to refactor this code to use memcpy throughout instead of memmove.

This will be slightly more performant and will reduce the likelihood that this code could be misconstrued to support overlapping buffers, when it actually does not.

 #### Proposed Solution

Refactor attribute-size.cpp and related code to call memcpy instead of memmove.

It appears none of this code exists any longer.


kestrel memory consumption is very high, it eats all the available memory in the machine !!

In the production, I'm trying to use Kestrel as the only hosting web server for my asp.net core application without using IIS as a reverse proxy, but i have a problem with this as the consumed memory by my asp.net core application process is keep growing until it eats all the available memory in the machine!!
However, this issue is not exist when i use IIS
Why is this happening? and why it is fixed when i use IIS?

IIS encapsulates certain types of requests that can cause this. This is why we say don't expose kestrel on untrusted networks. While we're working on Kestrel to mitigate this, that work is not complete yet. Your only fix is to use a reverse proxy for now.

Thanks. but could you please share with me what those kind of requests that might cause such issue?

No, I can't because it's hard to tell which one of the conditions you hit, and other people that ignore the always use a proxy are going to be at risk of the same problem.

@akramayasrah If you can capture a memory dump that would be great. As @blowdart says, you shouldn't be using kestrel on the internet until we have the proper mitigations in place but it would be good to know what your memory profile looks like to see if there are just general problems with the server.

My memory dump is too huge, but let me see if i can share it with you. However, if i have to use iis with kestrel, then i have always to carry the overhead of IIS (http.sys....etc) and in this case i will not take the advantage of kestrel performance & high throughput and kestrel will not add a real value for me.
To prove this, I ran a simple benchmark tool to compare the performance of kestrel alone versus kestrel with iis and the results were as below:

With kestrel alone: I got around 400000 r/s with 1.5 ms latency (which is fair enough)
With kestrel & iis : I got just 32000 r/s with 14 ms latency (which is bad)

Please advice.

@akramayasrah If you can host your memory dump on skydrive/dropbox or something like that, that would be very helpful. It's not unusual for dumps to be many GBs, especially when there's some sort of memory leak.
If that's not possible, creating a gist with the output of !dumpheap -stat from windbg's sos extension, might point us in the right direction.

OK i have shut down my asp.net app because by time it eats all my server memory, however let me run it again and once it start to consume big memory I will create a dump file for you.
Now, can anyone please advice on my performance comparison between (kestrel alone) vs (kestrel with iis as a proxy)?
And how I should proceed with my deployment if (kestrel alone) will lead to a memory leak and (kestrel with iis) is performing very bad comparing to kestrel alone?!!

@halter73 you can download the memory dump from below link:
https://www.dropbox.com/s/gzhmmrauudfv7fw/AspNetCore.DMP?dl=0

@akramayasrah Your download link now 404s, can you double check it to make sure it works?
It isn't too surprising that running Kestrel behind IIS would be slower in microbenchmarks. When the application be benchmarked isn't doing anything expensive, the overhead of the proxy can be relatively large.
I can't really explain the high memory usage of Kestrel alone without more details. The memory dump will probably be a good start.

@halter73 please send me on my private email to share the link with you.
i understand that hosting behind a proxy would be slower a little bit

@halter73 i have shared the dump file with you on google docs (an invitation email has been sent to you)
I can understand that deploying behind a proxy would be slower a little bit, but in our case the overhead of IIS is very large (from 400000 r/s to 32000 r/s), is it expected that IIS will drop the performance to this limit?!
How to take the advantage of kestrel performance if i have to run it always behind iis? in other words, what is the added value for me in term of performance if i want to migrate from asp.net to asp.net core?

@akramayasrah Looking at your dump, I noticed that you have over 100,000 active HTTP connections established to the server. I looked over a small sample these connections, and all of the ones I looked at were in the "RequestPending" state meaning the connection is idle.
There are a couple of issues at play here. The first, most obvious is that Kestrel does not timeout idle keep alive connections. Right now, we rely on the reverse proxy like IIS or nginx to do that instead. @cesarbs is currently working on #1066 which will add a configurable keep-alive timeout that will kill these idle connections. Once this is merged, using the nightlies from https://dotnet.myget.org/gallery/aspnetcore-dev should bring memory consumption in line with what you see behind IIS.
The other issue is that while Kestrel has been very optimized to allocate extremely little per request, there is still relatively low hanging fruit in terms of lowering memory utilization per idle connection. E.g.: #1005, #699.
We plan to address the issues I mentioned above by the 1.1 release, but in the meantime you can try to work around this by limiting the number of idle connections at any given time. Ideally this would be done by the server with the idle timeout that is being introduced by #1066. But if you have some control over the clients (say it's being accessed by a mobile app or library you control), you can close the HTTP connection from the client when you are done making requests for a period time.
If you don't control the clients (e.g. browsers), you can have your app on the server set the Connection: close header on its response. The downside of this is that any subsequent requests made by the client receiving the Connection: close response will have to be made over a new connection which obviously is less efficient than using an existing connection.

@halter73 when it is expected for the release 1.1 to be released? are we talking about a few weeks or few months?
And after 1.1 release, can we run kestrel on production without iis as a proxy?

@halter73 I appreciate if you answer my above questions

@akramayasrah I'm not sure that we've publicly announced any timelines for a 1.1 release more specific than Fall 2016. Not saying we haven't, just that I'm not sure. I believe that it will be closer to a few months than a few weeks.
As far as supporting kestrel in production without IIS or nginx after 1.1 goes, you'd have to ask @blowdart. We are currently working on hardening Kestrel so it can be used as an edge server at some point. The keep-alive timeouts are part of that work.

It's unlikely our hosting recommendations will change in 1.1.

@blowdart can we say that the high memory consumption issue willl be fixed in 1.1 release?

Stephen said yes in https://github.com/aspnet/KestrelHttpServer/issues/1053#issuecomment-242813947 - that precise issue will get resolved.

Identified issues are addressed.


B 18059 int - download link for AOA packet office user

B-18059
Summary
As a service counselor when you approve an Advance request a link is displayed on the PPM shipment card for downloading the AOA packet. The link doesn't work with this story but will be created and downloaded as part of a future story. This is to verify the
Verification Steps for the Author
These are to be checked by the author.

[ ] Tested in the Experimental environment (for changes to containers, app startup, or connection to data stores)
[ ] Have the Agility acceptance criteria been met for this change?

Verification Steps for Reviewers
These are to be checked by a reviewer.

[ ] Has the branch been pulled in and checked out?
[ ] Have the BL acceptance criteria been met for this change?
[ ] Was the CircleCI build successful?
[ ] Has the code been reviewed from a standards and best practices point of view?

Setup to Run the Code

Instructions for starting storybook
Instructions for starting the MilMove application
Instructions for running tests

How to test

Create a PPM shipment as a customer and ask for an advance
Login as the service counselor and approve the advance
There should be a link to download the advance on the PPM shipment card

Frontend

[ ] There are no aXe warnings for UI.
[ ] This works in Supported Browsers and their phone views (Chrome, Firefox, Edge).
[ ] There are no new console errors in the browser devtools.
[ ] There are no new console errors in the test output.
[ ] If this PR adds a new component to Storybook, it ensures the component is fully responsive, OR if it is intentionally not, a wrapping div using the officeApp class or custom min-width styling is used to hide any states the would not be visible to the user.
[ ] This change meets the standards for Section 508 compliance.

Screenshots

Warnings

:warning:

Files located in legacy directories (src/shared or src/scenes) have
been edited. Are you sure you don’t want to also relocate them to the new file structure?
View the frontend file org ADR for more information

  Generated by :no_entry_sign: dangerJS against 12264f6f087884bcffb96918a62dbc9e9b461f5c


Automator: update istio/api@master dependency in istio/istio@master

Generated by Automator - 2020-09-22T14:01:09+00:00

@istio-testing: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
a2b5ed9d64b325977b9423da511cbfb1d8c5ff49
link
/test unit-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test unit-tests_istio

@istio-testing: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
a2b5ed9d64b325977b9423da511cbfb1d8c5ff49
link
/test unit-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test unit-tests_istio


In V9 Test 3 module fails to load with error

Module fails to load on start up with the following error:
index.js:4 Uncaught TypeError: Cannot redefine property: localTransform
[Detected 1 package: unknown:perfect-vision]
at Function.defineProperties ()
at index.js:4
This is with PV 3.0.9

Fixed in 3.0.10.


Fixed the voc2007 link in README

Replaced the broken link with the working mirror by Oxford.

Thanks for the pull request.


feat: port algebra.ring.basic

mathlib SHA: 70d50ecfd4900dd6d328da39ab7ebd516abe4025
Changes:

I've removed a bit0 lemma.

I've removed a bit0 lemma.

I believe the current advice is to keep it with
set_option linter.deprecated false in
@[deprecated] lemma my_lemma ...

see https://github.com/leanprover-community/mathlib4/pull/771#issuecomment-1329704126

bors merge

bors r+


fix(version): allowPeerDependenciesUpdate should work w/workspace:^, fix #590

Description
The peerDependencies is a special case and will only be bumped when the flag --allow-peer-dependencies-update is enabled. A package set as workspace:^ (without any semver number) should be able to be bumped and it wasn't before this PR.
Motivation and Context
The --allow-peer-dependencies-update implementation was only tested with workspace: and semver, but it wasn't tested with just workspace:^ (or ~) and the end result was actually producing an invalid version ^ (which is obviously wrong).
This PR fixes 2 problems with peerDependencies identified in #587 and #590:
the example below is assuming that the version is at 1.0.0 and we are processing a minor bump

when version is workspace:^ and --allow-peer-dependencies-update is enabled, the version in package.json should remain as workspace:^ but the version that will be published should be bumped to "1.1.0"

this issue was caused by a very small RegEx that wasn't being match when using workspace:^ without a semver number

when version is workspace:^ and we do not provide --allow-peer-dependencies-update, it was previously trying to publish as ^ (which is an invalid version). In this case we now fallback to the previously resolved version when publishing (in this case "1.0.0")

How Has This Been Tested?

Types of changes

[ ] Chore (change that has absolutely no effect on users)
[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[x] My code follows the code style of this project.
[x] My change requires a change to the documentation.
[x] I have updated the documentation accordingly.
[x] I have added tests to cover my changes.
[x] All new and existing tests passed.

This looks great! What might be confusing is the inconsistency to yarn pack - not sure how pnpm is currently handling this. When using workspace:* it would be bumped to the locally resolved version as exact version (no range operator) and with this change it will resolve "*", this is a huge difference to the native handling. Might be sufficient to document this.

The workspace: protocol documentation is separate and can be found under both version#workspace-protocol and publish#workspace-protocol which is literally a copy of pnpm workspace:. I don't really want to add more docs than what I have now for peer deps, since workspace: docs already covers that. in pnpm workspace:* resolves to the exact version (ie 1.2.0) and looking at Yarn workspace: documentation, it is also doing the same thing and using workspace:* in a peer dependencies will also resolve to the current exact version (I found a comment to be wrong in the PR which is related to workspace:* and its output is correct)

The workspace: protocol documentation is separate and can be found under both version#workspace-protocol and publish#workspace-protocol which is literally a copy of pnpm workspace:. I don't really want to add more docs than what I have now for peer deps (maybe just a link to point to these other docs), since workspace: docs already covers that info. in pnpm workspace:* resolves to the exact version (ie 1.2.0) and looking at Yarn workspace: documentation, it is also doing the same thing and using workspace:* in a peer dependencies will also resolve to the current exact version (I found a comment to be wrong in my PR which is related to workspace:* and its output is correct)

I see. I just checked again, made a mistake reading the PR before. Looks good.

@ma-multipla fixed under the new v2.2.0 release. Thanks for the feedback and contributions


v18.1.1 cover 'empty' coordinates case

[Current coverage][cc-pull] is 99.26%

Merging [#452][cc-pull] into [master][cc-base-branch] will not change coverage

@@             master       #452   diff @@
==========================================
  Files            27         27
  Lines           406        406
  Methods          99         99
  Messages          0          0
  Branches          0          0
==========================================
  Hits            403        403
  Misses            3          3
  Partials          0          0

Powered by Codecov. Last updated by [5e7555f...4750242][cc-compare]
[cc-base-branch]: https://codecov.io/gh/eugene-matvejev/battleship-game-api/branch/master?src=pr
[cc-compare]: https://codecov.io/gh/eugene-matvejev/battleship-game-api/compare/5e7555f8189cdd6acbcb4ea5d3925e95d902d180...4750242bd336ac683b538b21bea2944d42488d31
[cc-pull]: https://codecov.io/gh/eugene-matvejev/battleship-game-api/pull/452?src=pr


adding possibility to verify requests

Motivation
Issue #1696
Changes
Added curl format to ongoing requests
Workflow

⚠ Create your PR as draft ⚠
Work on you PR until the CI passes (if something not related to your task is failing, you can ignore it)
Mark it as ready for review

Test logic is modified? -> Get a review from RFC owner. We're working on refining the codeowners file quickly.
Framework is modified, or non obvious usage of it -> get a review from R&P team

:rocket: Once your PR is reviewed, you can merge it!
🛟 #apm-shared-testing 🛟
Reviewer checklist

[ ] Relevant label (run-parametric-scenario, run-profiling-scenario...) are presents
[ ] If PR title starts with [<language>], double-check that only <language> is impacted by the change
[ ] No system-tests internal is modified. Otherwise, I have the approval from R&P team
[ ] CI is green, or failing jobs are not related to this change (and you are 100% sure about this statement)
[ ] A docker base image is modified?

[ ] the relevant build-XXX-image label is present

[ ] A scenario is added (or removed)?

[ ] Get a review from R&P team

Hi @faydef  , do you still plan to work on this?


Single-double precision is not distinguished at the coverpoint FP_SPECIAL_VALUE_CP

Although in file riscv_instr_cover_group.sv, the definition of FP_SPECIAL_VALUE_CP distinguishes between single and double precision cases, both types of coverpoints exist in the covergroup of floating-point instruction when making coverage statistics.

Although in file riscv_instr_cover_group.sv, the definition of FP_SPECIAL_VALUE_CP distinguishes between single and double precision cases, both types of coverpoints exist in the covergroup of floating-point instruction when making coverage statistics.

@blackcatruri
yes, it's shown in coverage statistics, but since the weight is 0, it doesn't contribute to overall coverage. In below example, fd is unsigned, cp_fd_sign has 0 weight, so it doesn't affect the overall coverage even this coverpoint is not 100%.

ok，i see，thanks


Add a license to the repo

Hi @everpeace, could you please add an explicit LICENSE file to this repo as well, so that it's clear under what terms you're providing this code?
Thanks!

@mbrukman I really appreciate your opening multiple identical issues :-) Thanks!


💡[Feature]: Bird Species Identification using Deep Learning Streamlit

Is there an existing issue for this?

[X] I have searched the existing issues

Feature Description
Current bird species identification processes can be time-consuming and error-prone. There is a need for an efficient and accurate method to identify bird species from images.
Use Case
Step 1: Determine Context and Gather Information
Are there specific details or requirements you have in mind for the Bird Species Identification project using Deep Learning and Streamlit?
Let me check if there are any existing discussions, issues, or documentation related to this topic in the given repository.
I will look for repositories or sources on GitHub that involve similar use cases.
Step 2: Compile and Provide a Detailed Use Case
Based on gathered information, I will draft a detailed use case scenario for Bird Species Identification using Deep Learning and Streamlit.
Provide links to examples, papers, or projects that have successfully implemented similar use cases.
Suggest a step-by-step guide or workflow that can help in achieving Bird Species Identification using Deep Learning and Streamlit.
Follow-Up Steps
Verify and validate the use case with you to ensure it meets your requirements.
Offer further assistance or resources based on your feedback.
Let's start with Step 1. Are there any specific details you can provide about your Bird Species Identification project using Deep Learning and Streamlit?
Benefits
Accurate Identification: Leverages deep learning models to accurately identify bird species from images, providing high precision and recall.
Real-time Processing: Streamlit allows for real-time data processing and visualization, making it easy to deploy the model and get instant results.
User-friendly Interface: Streamlit provides an interactive web-based interface that can be easily used by non-technical users for bird identification.
Educational Tool: Can be used in educational settings to teach students about bird species and machine learning applications.
Conservation Efforts: Assists in monitoring bird populations and biodiversity, aiding conservationists in their efforts to protect endangered species.
Community Engagement: Encourages citizen scientists and bird enthusiasts to contribute to data collection and species identification.
Add ScreenShots

Priority
High
Record

[X] I have read the Contributing Guidelines
[X] I'm a GSSOC'24 contributor
[X] I want to work on this issue

assign me and give me labels

https://github.com/recodehive/machine-learning-repos/issues/1367

If by adding  proper vedio and Readme file for this issue is there any chance you can assign


Upgrade dependencies

Direct:
golang.org/x/exp v0.0.0-20230425010034-47ecfdc1ba53 golang.org/x/net v0.9.0
Indirect:
github.com/pion/transport/v2 v2.2.0
golang.org/x/crypto v0.8.0
golang.org/x/sys v0.7.0

Codecov Report

Merging #445 (2b9de35) into master (f211f55) will decrease coverage by 0.13%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #445      +/-   ##
==========================================
- Coverage   72.27%   72.14%   -0.13%
==========================================
  Files          70       70
  Lines        5428     5428
==========================================
- Hits         3923     3916       -7
- Misses       1116     1121       +5
- Partials      389      391       +2

see 4 files with indirect coverage changes


Change Colab plotting backend from folium to ipyleaflet

Now Colab supports the installation of custom widgets (e.g., ipyleaflet), it is time to switch geemap's default plotting backend on Colab from folium to ipyleaflet. This will allow users to enjoy the full interactive functionality of geemap on Colab.
https://github.com/googlecolab/colabtools/issues/498#issuecomment-916996133

This feature has been implemented. Check out the Colab example https://gishub.org/geemap_colab. Note that the toolbar icons are too big on Colab. There is no easy fix for now. Will look into it in the next release.


Allow setting custom db table name from config

Can you merge the changes to main into your PR and make sure the tests pass?


Virtual Spaces

Has anyone considered using what I would call a "virtual" space instead of using the built in feature?
I was impressed with the way Aerospace handled spaces by moving windows to the bottom right corner and having hotkeys redistribute the windows based on what "virtual" space you were on.
I'm curiuos why they didn't simply hide windows instead of moving them to a corner, but has Yabai considered doing something similar with spaces to avoid the SIP issue?

People have asked for this before, and the short answer is that the goal of this project is to enhance the macOS experience, not replace it.
If I wanted to build a completely different desktop experience for macOS (disabling menubar, dock, gestures, mission control, app switcher, etc.), that can be done.
It would be a lot of work to recreate all this/similar functionality and build a new polished experience though.
From what I know about AeroSpace, it is sort trying to create a different macOS by employing very specific workarounds, and «not playing nicely» with macOS features. I understand the motivation, but personally think it is the wrong approach.

I quickly switched back to yabai to get real spaces back fwiw. The transitions were too slow and it seems macOS can optimize away drawing content in other spaces.

That is fine by me. I have never once tried to market yabai to users or told people that they should use this software. It was developed for my own personal use (and still is to this day).

IMO, as a twm, yabai is massively overhyped compared to AeroSpace, and I think AeroSpace will dethrone yabai in the long term, because of yabai's SIP shenanigans and the UX of built in spaces. I think you're over-estimating how much people actually care about "playing nicely with macOS features". I'd posit that the majority of users are searching for a fast-workspace-switching i3 experience on mac, not i3-if-you-disable-SIP-but-at-least-you-can-swipe-the-trackpad on mac. I get that yabai has already gone down this path though and it's not going to change, but as far as long term project prospects go, I do think that AeroSpace has made the better tradeoffs that really matter to most users.

It doesn't support transparency, the author finds that useless, so for me it's neither on option or alternative.
YMMV. Without Yabai I'd have switched back to Linux since years.


Create methods to handle InstallPlans

Add function or method to read install plan status and progress and wait for completion.

close by #39


Added Nested List in python

This PR adds a solution to the challenge to find the runners' up score  and print in alphabetical order

Thank you for your contribution!
Regards,
Gantavya Malviya ( https://linktr.ee/gantavyamalviya )


Upgrade airflow to 2.8.0, upgrade other dependencies

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (a39675d) 96.77% compared to head (a4666d1) 96.77%.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@           Coverage Diff           @@
##             main      #63   +/-   ##
=======================================
  Coverage   96.77%   96.77%
=======================================
  Files          39       39
  Lines        1334     1334
=======================================
  Hits         1291     1291
  Misses         43       43

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


[Snyk] Upgrade org.slf4j:slf4j-simple from 2.0.13 to 2.0.14

Snyk has created this PR to upgrade org.slf4j:slf4j-simple from 2.0.13 to 2.0.14.
:information_source: Keep your dependencies up-to-date. This makes it easier to fix existing vulnerabilities and to more quickly identify and fix newly disclosed vulnerabilities when they affect your project.

The recommended version is 1 version ahead of your current version.

The recommended version was released on 24 days ago.

[!IMPORTANT]

Check the changes in this PR to ensure they won't cause issues with your project.
This PR was automatically created by Snyk using the credentials of a real user.

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open upgrade PRs.
For more information:

🧐 View latest project report
📜 Customise PR templates
🛠 Adjust upgrade PR settings
🔕 Ignore this dependency or unsubscribe from future upgrade PRs

/ok-to-test


Upgrade redis pip package to latest version

The backend tests are failing after upgrading redis to  3.0.1
Running zerver.tests.test_archive.GlobalPublicStreamTest.test_non_existant_stream_id
Running zerver.tests.test_archive.GlobalPublicStreamTest.test_non_existant_topic
Running zerver.tests.test_archive.GlobalPublicStreamTest.test_non_web_public_stream
Running zerver.tests.test_archive.GlobalPublicStreamTest.test_web_public_stream_topic
Running zerver.tests.test_archive.WebPublicTopicHistoryTest.test_non_existant_stream_id
Running zerver.tests.test_archive.WebPublicTopicHistoryTest.test_non_web_public_stream
Running zerver.tests.test_archive.WebPublicTopicHistoryTest.test_web_public_stream
Running zerver.tests.test_attachments.AttachmentsTests.test_delete_unauthenticated
  File "/home/zulipdev/zulip/zerver/tests/test_external.py", line 72, in test_headers
    self.assertTrue('X-RateLimit-Remaining' in result)
  File "/usr/lib/python3.5/unittest/case.py", line 677, in assertTrue
    raise self.failureException(msg)
AssertionError: False is not true

----------------------------------------------------------------------
Ran 550 tests in 21.522s

FAILED (failures=1)

@zulipbot label "area: dependencies"

@mateuszmandera you may be a good person to work on this, since our main uses for redis are rate-limiting and the email gateway.

I'll look into it! :+1:

Posted a PR, the problem was that the way to use zadd(...) changed from 2.x to 3.0 - and we have zadd in rate_limiter code.


Use slf4j

remove direct usage of commons-logging
use slf4j

[ ] Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
[ ] Ensure that the pull request title represents the desired changelog entry
[ ] Please describe what you did
[ ] Link to relevant issues in GitHub or Jira
[ ] Link to relevant pull requests, esp. upstream and downstream changes
[ ] Ensure you have provided tests - that demonstrates feature works or fixes the issue

@dependabot merge


etcdserver: improve Lease http path naming for gRPC gateway

This PR looks to normalize some of the lease api paths for the gRPC gateway. Using  additional_bindings supported by grpc-gateway we can accept both old and new paths. Current plan is to support in 3.4 and deprecate all additional_bindings in 3.5. I will work on notifying existing clients of the change as well.
fixes #9430
/cc @akashbaid

I have no excuse to not add curl leases tests here ...

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@c22afc2). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master    #9450   +/-   ##
=========================================
  Coverage          ?   72.33%
=========================================
  Files             ?      363
  Lines             ?    30849
  Branches          ?        0
=========================================
  Hits              ?    22316
  Misses            ?     6906
  Partials          ?     1627

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c22afc2...61577d6. Read the comment docs.

@hexfusion Can we also update changelogs?

@gyuho sure would you mind reviewing #9460 we need to address semaphore timeouts. Also I have experienced this same code above, passing and then failing Lease tests so more review is required before merge. #9460 will help this effort, thanks!

@akashbaid, I find the below to be stable and produce proper Swagger. WIll update PR and tests once https://github.com/coreos/etcd/pull/9460 gets merged.
  // LeaseLeases lists all existing leases.
  rpc LeaseLeases(LeaseLeasesRequest) returns (LeaseLeasesResponse) {
      option (google.api.http) = {
        post: "/v3/lease/leases"
        body: "*"
        additional_bindings {
            post: "/v3/kv/lease/leases"
            body: "*"
        }
    };
  }

That's great! Thanks for looking into it.

@gyuho updated release notes and tweaked lease tests for coverage. Should be good on greens.


add nuxtjs proxy to enable cors

A solution for isssue: https://github.com/zernonia/tweetic/issues/34

Hey @prasannamestha ! Thank you for the issue and PR. Unfortunately using Nuxt proxy doesn't fix the CORS issue.
look at https://vue-rjwccz.stackblitz.io
Since Nuxt 3 server is using h3, could you try setHeader using h3?


feat: Added full_override_name override to disable adding domain name to record names

…efix to the record name
Description
add full_override_name override to disable adding domain name as a prefix to the record name
Motivation and Context
add possibility to read the exported dns file taht contains full names.
Breaking Changes

How Has This Been Tested?

[X] I have updated at least one of the examples/* to demonstrate and validate my change(s)
[X] I have tested and validated these changes using one or more of the provided examples/* projects

[X] I have executed pre-commit run -a on my pull request

I would rather ask a user to prepare the valid records instead of adding a global flag. This is a bit unnecessary for this module.

After small thinking, I think that having this flag on a per-record basis and making it backward-compatible may be a good option. Please make the changes in the example to show both options.

OK, will do, thank you for understanding!

@antonbabenko can somebody review, please?

Yes, I will do it later this week. Too busy with countless other tasks at the moment.

This PR is included in version 2.7.0 :tada:

I have updated the example a bit.
It is working but there is still issue #59 that prevents examples from being 100% working.

You can try. Keep in mind backward compatibility or at least a decent migration path for existing use-cases for terraform and terragrunt users.


Remove grpc_httpcli_context

grpc_httpcli_context currently has just a grpc_pollset_set field, which seems to only be necessary in order to wrap the grpc_httpcli_{get,post} pollent parameter in the case that pollent is a grpc_pollset. We can remove the need for callers to manage this and manage it within the requests themselves.
Motivation: I'm trying to add cancellation support to grpc_httpcli_{get,post}. My first idea was to leverage grpc_httpcli_context to do the cancellation with something along the lines of grpc_httpcli_cancel(context), but that doesn't work out well because grpc_httpcli_context can be used across multiple requests. So we'd need to instead return something from grpc_httpcli_{get,post} which tracks the request and can do cancellation, but it seems odd for something like that to co-exist with grpc_httpcli_context.

I'd like @ctiller to weigh in on this to confirm my understanding and reasoning here.  However, I'm not sure that this PR is the right approach, for two reasons.
First, I believe that the reason grpc_httpcli_context exists and contains a grpc_pollset_set is that we want multiple gRPC calls to be able to poll the same HTTP request.  For example, in a case like oauth creds, the first gRPC call might trigger an HTTP request to get the oauth token, but then a second call might be started that is also blocked on waiting for the oauth token, and then the first request might be cancelled before the HTTP request completes.  In that case, we need the CQ polling for the second request to be able to make forward progress on the HTTP request.  But if the two calls are on different CQs and we don't combine their pollsets, then nothing will be doing polling on the HTTP request, and it will never make forward progress.  (To be fair, this is a short-term problem, since all of the pollset stuff will go away when we migrate to EventEngine, but I think we still need it until then.)
Second, even if grpc_httpcli_context weren't needed for polling reasons, it's not clear to me why we need to get rid of it in order to add cancellation.  I think the right way to think about the structure here is that grpc_httpcli_context is analogous to a channel and grpc_httpcli_request is analogous to an RPC call.  The existence of the channel in the API does not prevent us from cancelling a call, so I don't see why the presence of grpc_httpcli_context should prevent us from cancelling an individual grpc_httpcli_request.  The cancellation should be an operation on grpc_httpcli_request, and the semantics of that operation shouldn't be affected by the presence of grpc_httpcli_context.

First, I believe that the reason grpc_httpcli_context exists and contains a grpc_pollset_set is that we want multiple gRPC calls to be able to poll the same HTTP request. For example, in a case like oauth creds, the first gRPC call might trigger an HTTP request to get the oauth token, but then a second call might be started that is also blocked on waiting for the oauth token, and then the first request might be cancelled before the HTTP request completes. In that case, we need the CQ polling for the second request to be able to make forward progress on the HTTP request. But if the two calls are on different CQs and we don't combine their pollsets, then nothing will be doing polling on the HTTP request, and it will never make forward progress. (To be fair, this is a short-term problem, since all of the pollset stuff will go away when we migrate to EventEngine, but I think we still need it until then.)

Right, I also initially thought that this polling problem necessitated shared context object, but it looks like all callers are actually already solving this problem by merging interested parties into grpc_httpcli_{get,post}'s pollent parameter themselves. I.e., the grpc_httpcli_context is object is still redundant.
Here's my audit of all non-test usages of grpc_httpcli_{get,post} in the codebase:

Multiple usages of grpc_httpcli_{get,post} within oauth2_credentials.cc, example: interested parties have already been merged into the pollent parameter in the parent class's get_request_metadata.

In google_default_credentials: there is only one interested party which is the local method.

Multiple usages of grpc_httpcli_{get,post} in child classes of ExternalAccountCredentials: the pollent parameter is passed down from ExternalAccountCredentials::fetch_oauth2 method, and that pollent parameter has already merged all interested in parties in get_request_metadata

I also see one usage of grpc_httpcli_get internally, but that is a synchronous usage and there is not shared pollset set there.

Second, even if grpc_httpcli_context weren't needed for polling reasons, it's not clear to me why we need to get rid of it in order to add cancellation. I think the right way to think about the structure here is that grpc_httpcli_context is analogous to a channel and grpc_httpcli_request is analogous to an RPC call. The existence of the channel in the API does not prevent us from cancelling a call, so I don't see why the presence of grpc_httpcli_context should prevent us from cancelling an individual grpc_httpcli_request. The cancellation should be an operation on grpc_httpcli_request, and the semantics of that operation shouldn't be affected by the presence of grpc_httpcli_context.

Indeed the presence of the grpc_httpcli_context object doesn't prevent us from adding cancellation, but I do think it make the API more cumbersome than it needs to be. So I just figured we might as well delete it as a part of the API changes to add cancellation.

Note, there is also one more usage of grpc_httpcli_get in the google c2p resolver.
But again, the pollent parameter in use there is the resolver's pollset set, and interested parties must have already been merged into that, otherwise the polling problem referred to would exist for resolvers on all other I/O.

Mark's right on the original intent (to share polling context between requests), and I think Alex is right on the current status (we just don't actually)... and that status is going to become unchangeable soon as we remove pollset_set anyway. I also agree with Alex on the thinking that we'll want to return some handle to cancel with from get/post. I also agree with Mark on the reasoning that it needn't be awkward.
That said, we're asking clients to carry state that we don't use, and I think enough time has passed since I wrote this thing that we can safely say that we probably won't add another use for it in the near term, so I think my vote lands on let's delete the thing and simplify calling code.

artifact and distrib linux tests are known issue: https://github.com/grpc/grpc/issues/28483
basic tests objc ios looks like https://github.com/grpc/grpc/issues/23933


Pod doesn't start when forward plugin is configured

I had the forward plugin configured like thist:
extraZonePlugins:
  - name: forward
    parameters: . 192 168 178.2

This lead to the pod not starting anymore. The issue seems to be existing since Chart version 2.0.0.
Am I doing something wrong or is there an issue wit the service?

what is the error you're seeing? I can see you've misspelled the IP "<IP_ADDRESS>", could this be the issue?

Hello I just confirmed the missplelled IP is not in my configuration. The error I am seeing is that the pod never reaches the ready state and starts to ansewer to DNS Requests. Unfortunatley there is no error message. The log outout of the pod is like this:
[INFO] plugin/k8s_gateway: Building k8s_gateway controller [INFO] plugin/k8s_gateway: GatewayAPI CRDs are not found. Not syncing GatewayAPI resources. [INFO] plugin/k8s_gateway: VirtualServer CRDs are not found. Not syncing VirtualServer resources. [INFO] plugin/k8s_gateway: Starting k8s_gateway controller [INFO] plugin/k8s_gateway: Waiting for controllers to sync .:1053 CoreDNS-1.10.0+k8s_gateway-0.3.3 linux/arm64, go1.19.5, bce972a [INFO] plugin/k8s_gateway: Synced all required resources

ok, got it. can you please include your values file? I'll test it today/tomorrow

Hi sorry for the late reply. Here is the content of my values file:

domain: "sfenzke-home.de"

extraZonePlugins:
  - name: forward
    parameters: . <IP_ADDRESS>

service:
  type: LoadBalancer
  port: 53
  annotations: {metallb.universe.tf/address-pool: dns-pool}
  externalIPs:
    - <IP_ADDRESS>

cool, will test in a couple of days and push the fix

I think i've found the issue. Can you retest with the following values file:
domain: "sfenzke-home.de"

extraZonePlugins:
  - name: forward
    parameters: . <IP_ADDRESS>
  - name: ready

service:
  type: LoadBalancer
  port: 53
  annotations: {metallb.universe.tf/address-pool: dns-pool}
  externalIPs:
    - <IP_ADDRESS>

This worked. I wasn't awre you need to specify the ready plugin in coreDNS. Thank you very much.


Add unhandledRejection and uncaughtException handlers to scripts

This is to prevent false-positives like this from occurring, and fixes the warning from node:
$ ts-node ./scripts/build.ts
Creating builders tarball with: @now/build-utils@canary, @now/go@canary, @now/next@canary, @now/node@canary, @now/php@canary, @now/static-build@canary
(node:156) UnhandledPromiseRejectionWarning: Error: ENOENT: no such file or directory, open '/home/circleci/repo/assets/builders.tar.gz'
    at ReadStream.evt.error.err (/home/circleci/repo/node_modules/promisepipe/index.js:30:23)
    at ReadStream.emit (events.js:198:13)
    at ReadStream.EventEmitter.emit (domain.js:448:20)
    at /home/circleci/repo/node_modules/graceful-fs/graceful-fs.js:207:14
    at /home/circleci/repo/node_modules/graceful-fs/graceful-fs.js:258:16
    at FSReqWrap.args [as oncomplete] (fs.js:140:20)
(node:156) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). (rejection id: 1)
(node:156) [DEP0018] DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js process with a non-zero exit code.

Codecov Report

Merging #2709 into canary will increase coverage by 0.06%.
The diff coverage is 75%.

@@            Coverage Diff            @@
##           canary   #2709      +/-   ##
=========================================
+ Coverage    8.21%   8.28%   +0.06%
=========================================
  Files         260     261       +1
  Lines       10513   10530      +17
  Branches     1341    1342       +1
=========================================
+ Hits          864     872       +8
- Misses       9591    9599       +8
- Partials       58      59       +1

Impacted Files
Coverage Δ

src/util/dev/builder-cache.ts
39.69% <100%> (-0.21%)
:arrow_down:

src/util/get-dist-tag.ts
66.66% <71.42%> (ø)

src/util/dev/builder.ts
12.23% <0%> (-0.27%)
:arrow_down:

src/util/dev/server.ts
12.33% <0%> (+0.22%)
:arrow_up:

src/util/dev/yarn-installer.ts
38.09% <0%> (+0.8%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b31ab03...f3de7b8. Read the comment docs.


[Backport 2.11] [Remote Store] Using hash of node id in metadata file names

Backports https://github.com/opensearch-project/OpenSearch/commit/98defa595cc83369fa863d50057d518133b81540 from https://github.com/opensearch-project/OpenSearch/pull/10480.
Backports https://github.com/opensearch-project/OpenSearch/commit/22ddcf19c7a0ceb8998cdc6344ba132b547cef1c from https://github.com/opensearch-project/OpenSearch/pull/10490

Gradle Check (Jenkins) Run Completed with:

RESULT: FAILURE ❌
URL: https://build.ci.opensearch.org/job/gradle-check/27398/
CommitID: a9d0ac5
Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green.
Is the failure a flaky test unrelated to your change?

Flaky tests - https://github.com/opensearch-project/OpenSearch/issues/10046, https://github.com/opensearch-project/OpenSearch/issues/9946

Gradle Check (Jenkins) Run Completed with:

RESULT: FAILURE ❌
URL: https://build.ci.opensearch.org/job/gradle-check/27400/
CommitID: fb10d4a
Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green.
Is the failure a flaky test unrelated to your change?

Flay test - https://github.com/opensearch-project/OpenSearch/issues/10079


Bump hot-shots for @Shopify/koa-metrics

After debugging why statsd events are not getting firing with @Shopify/koa-metrics, I've narrowed it down to hot-shots. My assumption is that the socket is getting closed before the data is sent.
https://github.com/brightcove/hot-shots/commit/c49197c2adb451bbd8e62641c1918c1b4ee97009

The brightcove/hot-shots@c49197c changeset looks like it was shipped for v6.1.1 and v6.1.0. /web seems to be using 5.9.1. Are we able to test this to verify that the bump fixes the issue?


Terminal keeps starting with sh instead of bash

Hi,
Every time I open a new terminal, it uses the sh instead of bash (which is what I have selected as shell. I am using Ubuntu 17.04
The following error is shown in the developer tools, though it does not seem to be directly related:
errors.ts:42 ERROR Error: Uncaught (in promise): TypeError: Cannot read property 'recoveryId' of null
TypeError: Cannot read property 'recoveryId' of null
    at TerminalTabComponent.getRecoveryToken (/opt/Terminus/resources/builtin-plugins/terminus-terminal/dist/index.js:271:44)
    at window.localStorage.tabsRecovery.JSON.stringify.tabs.map (/opt/Terminus/resources/builtin-plugins/terminus-core/dist/index.js:2975:31)
    at Array.map (native)
    at TabRecoveryService.saveTabs (/opt/Terminus/resources/builtin-plugins/terminus-core/dist/index.js:2975:14)
    at SafeSubscriber.TabRecoveryService.app.tabsChanged$.subscribe [as _next] (/opt/Terminus/resources/builtin-plugins/terminus-core/dist/index.js:2970:18)
    at SafeSubscriber.__tryOrUnsub (/opt/Terminus/resources/app.asar/node_modules/rxjs/Subscriber.js:236:16)
    at SafeSubscriber.next (/opt/Terminus/resources/app.asar/node_modules/rxjs/Subscriber.js:185:22)
    at Subscriber._next (/opt/Terminus/resources/app.asar/node_modules/rxjs/Subscriber.js:125:26)
    at Subscriber.next (/opt/Terminus/resources/app.asar/node_modules/rxjs/Subscriber.js:89:18)
    at Subject.next (/opt/Terminus/resources/app.asar/node_modules/rxjs/Subject.js:55:25)
    at TerminalTabComponent.getRecoveryToken (/opt/Terminus/resources/builtin-plugins/terminus-terminal/dist/index.js:271:44)
    at window.localStorage.tabsRecovery.JSON.stringify.tabs.map (/opt/Terminus/resources/builtin-plugins/terminus-core/dist/index.js:2975:31)
    at Array.map (native)
    at TabRecoveryService.saveTabs (/opt/Terminus/resources/builtin-plugins/terminus-core/dist/index.js:2975:14)
    at SafeSubscriber.TabRecoveryService.app.tabsChanged$.subscribe [as _next] (/opt/Terminus/resources/builtin-plugins/terminus-core/dist/index.js:2970:18)
    at SafeSubscriber.__tryOrUnsub (/opt/Terminus/resources/app.asar/node_modules/rxjs/Subscriber.js:236:16)
    at SafeSubscriber.next (/opt/Terminus/resources/app.asar/node_modules/rxjs/Subscriber.js:185:22)
    at Subscriber._next (/opt/Terminus/resources/app.asar/node_modules/rxjs/Subscriber.js:125:26)
    at Subscriber.next (/opt/Terminus/resources/app.asar/node_modules/rxjs/Subscriber.js:89:18)
    at Subject.next (/opt/Terminus/resources/app.asar/node_modules/rxjs/Subject.js:55:25)
    at resolvePromise (/opt/Terminus/resources/app.asar/node_modules/zone.js/dist/zone.js:770:31)
    at /opt/Terminus/resources/app.asar/node_modules/zone.js/dist/zone.js:696:17
    at fulfilled (/opt/Terminus/resources/builtin-plugins/terminus-terminal/dist/index.js:997:86)
    at ZoneDelegate.invoke (/opt/Terminus/resources/app.asar/node_modules/zone.js/dist/zone.js:391:26)
    at Object.onInvoke (/opt/Terminus/resources/app.asar/node_modules/@angular/core/bundles/core.umd.js:3922:33)
    at ZoneDelegate.invoke (/opt/Terminus/resources/app.asar/node_modules/zone.js/dist/zone.js:390:32)
    at Zone.run (/opt/Terminus/resources/app.asar/node_modules/zone.js/dist/zone.js:141:43)
    at /opt/Terminus/resources/app.asar/node_modules/zone.js/dist/zone.js:818:57
    at ZoneDelegate.invokeTask (/opt/Terminus/resources/app.asar/node_modules/zone.js/dist/zone.js:424:31)
    at Object.onInvokeTask (/opt/Terminus/resources/app.asar/node_modules/@angular/core/bundles/core.umd.js:3913:33)
defaultErrorLogger @ errors.ts:42

Same on ubuntu 16.04
The error wasn't there in alpha 34

I can confirm this as well. Seems to only happen when using Tmux for session persistence. Works with GNU Screen.

I can confirm that this is not fixed in alpha 36.

@Eugeny, if you could provide me with any pointers for where to look, I'd happily try to find a solution

Hi, I could reproduce the issue in Ubuntu 16.04.
Another workaround for it is to go to Settings > Terminal > Shell > Custom and then write /bin/bash in the "Custom shell" textbox.
I have been browsing through the code, the error that @Vinno97 mentioned seems related though, but not the main cause. In the end that error caused because sessionOptions is null in this line: https://github.com/Eugeny/terminus/blob/0420b2dbb91f9729dec5250d148a83de12b5e14f/terminus-terminal/src/components/terminalTab.component.ts#L114
However, if I change the Custom shell to /bin/bash --login (which would be the same as if you select /bin/bash in the dropdown), then the error is gone and still the shell doesn't work.
I hope this helps :)


Groupby aggregation of date/datetime columns returns datetime64 rather than numeric type

import pandas as pd
import datetime
u = [datetime.datetime(2015, x, 1) for x in range(12)]
v = list('aaabbbbbbccd')
df = pd.DataFrame('X':v, 'Y':u)
df.groupby('X')['Y'].agg(len)
## Returns the following:
X
a   1970-01-01 00:00:00.000000003
b   1970-01-01 00:00:00.000000006
c   1970-01-01 00:00:00.000000002
d   1970-01-01 00:00:00.000000001

You can fix the problem by casting the dates to strings before groupby/agg, but if you try to cast the returned datetimes to ints, errors go off in some versions of pandas. Either way, aggregating by length should always return an int. Also, this may be similar to #11442, which was just posted.

Also, this

this is a dupe of #10972
thanks for the report


Add packages workflow to build and push images

Adds a workflow for GitHub Actions to build and push the images to the GitHub container Registry and Docker Hub.
Please review and merge the PR #79 first. This PR already includes the new image.
You have to set up the secrets DOCKERHUB_USERNAME and DOCKERHUB_TOKEN that the action can log in to your Docker Hub account.
Currently, only the tags 7.3, 7.4, 8.0 and 8.1 will be pushed.

Okay I've added the DOCKERHUB_* secrets on the repository so let's see if it works. 😊

Looks awesome. :)


[Macros] Properly compute the innermost declaration context of a macro.

How did we go this long without having the right context? Who knows. The fix is trivial and obvious.
The failure mode here is that we wouldn't get an appropriate generic context in the result type of a macro, so we would complain about generic parameters not meeting their own generic requirements.

@swift-ci please smoke test and merge

@swift-ci please smoke test macOS


envoy.reloadable_features.allow_response_for_timeout deprecation

Your change #12178 (gRPC-Web: Fix failing HTTP/2 requests on some browsers due to empty trailers) introduced a runtime guarded feature. It has been 6 months since the new code has been exercised by default, so it's time to remove the old code path. This issue tracks source code cleanup so we don't forget.

Could I take it if possible?


Google Cloud Shell installation - redirect URL for GCP project

Hi,
The installation was a breeze on the Google CLoud shell instance. After adding the credential (JSON) file, I need to Oauth it via the generated (using alfa acquire) link that features the Please visit this URL to authorize this application text: https://accounts*. After visiting the URL, I get page not found, as http://localhost:8089/ is not reachable. Any suggestions on how to install it in Cloud Shell environment/?
Note. I tried to set HTTP://localhost as a redirect on the GVP, but it seems the app is hardcoded.
Thank you!

The returned URL is localhost:8089/?state=xTs6GTvSI8ynhIK7EhBv*, which I imagine causing trouble for macOS system

Quick update.
I have installed this on macOS (had to use sudo, as otherwise alfa never appeared as an executable). The alfa acquire authorisation worked. Great!
Now, it seems command hangs after the access_transparency:      xx activities line

I have copied the credentials.json and token.json files to Google cloud config/folder, which is a Linux (Debian-based Linux) box. The alfa acquire works in general, but also hangs on the same line. It seems the issue is not macOS related at this stage.

Wow so sorry I didn't get a notification for this issue. Will do some testing, but we don't support it outside Linux distributions officially. Will test it on Ubuntu where it should work if not we have more issues.

Coming back to this issue, sometimes it seems like it hangs. Could you try for instance changing the config file and only acquire let's say drive logs and see if it successfully completes?

No update/activity, if still an issue please update.


Improve webpack config

https://doppelmutzi.github.io/webpack-performance-optimization/

https://github.com/Markkos89/react-webpack5-boilerplate

https://github.com/altafino/react-webpack-5-tailwind-2

https://github.com/iamakulov/awesome-webpack-perf


Locked incorrectly

You locked my post incorrectly.
My post relates to not being able to resume a download that I instigated today. It's totally different to the one you linked to.
If you're not clear about this please unlock the original post and I'd be happy to point out the differences to you.
Lux

Your issue is exactly the same captcha. Stop posting duplicates.


Unable to enable systemd service

Ubuntu 20.04 LTS. Code server v3.9.1
Trying sudo systemctl enable --now code-server@root and sudo systemctl enable --now code-server@USER
Having error
Failed to enable unit: Unit file<EMAIL_ADDRESS>does not exist.
UPDATE
Please, fix docs. After this command user need to run "curl -fsSL https://code-server.dev/install.sh | sh" but command line instructions says that user need to run sudo systemctl enable --now code-server@USER
Originally posted by @olegKusov in https://github.com/cdr/code-server/issues/1845#issuecomment-799232609

@code-asher The doc says:
curl -fOL https://github.com/cdr/code-server/releases/download/v3.9.1/code-server_3.9.1_amd64.deb
sudo dpkg -i code-server_3.9.1_amd64.deb
sudo systemctl enable --now code-server@$USER
# Now visit http://<IP_ADDRESS>:8080. Your password is in ~/.config/code-server/config.yaml

From what I can tell based on their comment they used the install script (see the curl -fsSL https://code-server.dev/install.sh | sh command).
I haven't actually tested any of this myself, I just opened a new issue for them since they posted in a closed issue.

Actually I think I misread the comment. I think they're saying the install script needs to be ran before you can enable the service and that the docs don't mention this? But as far as I can tell they do.
@olegKusov I'm going to close this issue but if you have any insight on where the docs need to be updated please comment! Thank you!


[AutoPR sql/resource-manager] [Don't Merge, Service Rolling out ~Jan/28/18] Adding API Specs for Long Term Retention V2

Created to sync https://github.com/Azure/azure-rest-api-specs/pull/2256

Codecov Report

Merging #2089 into restapi_auto_sql/resource-manager will decrease coverage by 0.03%.
The diff coverage is 27%.

@@                          Coverage Diff                          @@
##           restapi_auto_sql/resource-manager    #2089      +/-   ##
=====================================================================
- Coverage                              53.02%   52.98%   -0.04%
=====================================================================
  Files                                   4781     4783       +2
  Lines                                 120153   120303     +150
=====================================================================
+ Hits                                   63712    63747      +35
- Misses                                 56441    56556     +115

Impacted Files
Coverage Δ

...e-mgmt-sql/azure/mgmt/sql/sql_management_client.py
100% <100%> (ø)
:arrow_up:

...ure/mgmt/sql/models/sql_management_client_enums.py
100% <100%> (ø)
:arrow_up:

azure-mgmt-sql/azure/mgmt/sql/models/__init__.py
100% <100%> (ø)
:arrow_up:

...ure-mgmt-sql/azure/mgmt/sql/operations/__init__.py
100% <100%> (ø)
:arrow_up:

...erations/long_term_retention_backups_operations.py
18.11% <18.11%> (ø)

...rations/long_term_retention_policies_operations.py
25.28% <20%> (ø)

...zure/mgmt/sql/models/long_term_retention_backup.py
41.66% <41.66%> (ø)

...zure/mgmt/sql/models/long_term_retention_policy.py
50% <50%> (ø)

...gmt/sql/models/long_term_retention_backup_paged.py
80% <50%> (ø)

... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e92a084...5186a0d. Read the comment docs.

@AutorestCI rebase

Rebase done and pushed to the branch

(message created by the CI based on PR content)

Will regenerate from main PR


Minor typo in example file

(I didn't see a way to simply leave a comment on the file itself, hence this issue that can be quickly resolved and closed.)
https://github.com/LesFerch/WinSetView/blob/c14a4bbaef2402820950df066e631c33084f9b02/AppData/WinSetViewCustom.txt#L11
Minor typo, should say "first". Also, the following comment can perhaps be added right below this one:

; See https://docs.microsoft.com/windows/win32/properties/props for a complete list of Windows Properties

Thanks. fist already corrected to first. :)
I wonder if there's a better reference out there. Unless I
missed something, that link doesn't seem to help much with the FolderTypes
registry key format. Everything I've learned about that key has been from a
combination of trial and error and reading posts by Keith Miller (mainly on
TenFormus.com).
On Fri, Apr 23, 2021 at 1:04 PM Peter @.***> wrote:

(I didn't see a way to simply leave a comment on the file itself, hence
this issue that can be quickly resolved and closed.)
https://github.com/LesFerch/WinSetView/blob/c14a4bbaef2402820950df066e631c33084f9b02/AppData/WinSetViewCustom.txt#L11
Minor typo, should say "first". Also, the following comment can perhaps be
added right below this one:
; See https://docs.microsoft.com/windows/win32/properties/props for a
complete list of Windows Properties
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/LesFerch/WinSetView/issues/13, or unsubscribe
https://github.com/notifications/unsubscribe-auth/AS25QOYLCE5DJ4Z2DVFUEDDTKGSBPANCNFSM43PABQXA
.

Not the FolderTypes reg key format but as mentioned a complete list of all supported properties (for columns) like "prop:System.ItemType;System.ItemNameDisplay" etc.


Add environment variables for assisted digital survey to feedback

These will hold the key of the spreadsheet to write survey results to and
the email and private key credentials of the service account to use to
perform the write.  Each environment will have their own values for this
and it'll come from the encrypted puppet hieradata.
To provide config for https://github.com/alphagov/feedback/pull/179/ (which is in service of https://trello.com/c/kZCX6dGB/53-assisted-digital-support-on-done-page-survey)

I added another commit to allow writing multiline values into envvars in a form that envdir supports. We probably need another approval before merging. /cc @surminus


Installation error

ERROR: No matching distribution found for torch==1.2.0 (from biobert-embedding==0.1.2).
Below are the pytorch versions installed
torch = 1.5.0+cpu
torchvision = 0.6.0+cpu
How do I proceed with the installation.

Anyone happen to find a solution to this?

Yes, I encountered the same problem, torch==1.2.0 is no longer supported


Cfg dependencies are still required on excluded platforms

A simple use case:
Cargo.toml
[package]
name = "test"
version = "0.1.0"

[target.'cfg(windows)'.dependencies]
does_not_exist = 1

and
main.rs
fn main() {}

Will fail with this error on my linux machine:
    Updating registry `https://github.com/rust-lang/crates.io-index`
error: no matching package named `does_not_exist` found (required by `test`)
location searched: registry https://github.com/rust-lang/crates.io-index
version required: ^1

From what I gathered on the dependencies page is that it should be ignored as I did not run it on a linux machine.
Additional Info:
neikos@work ~> rustc -V
rustc 1.14.0-nightly (3caf63cc0 2016-10-24)
neikos@work ~> cargo -V
cargo 0.13.0-nightly (9a0801d 2016-10-20)

This was a question on SO, and it bugged me.

This might be related to #3195

Thanks for the report! For this sort of dependency it's actually expected behavior. Cargo, when generating a lock file, contains information for all platforms to ensure the lock file doesn't change across platforms.

Alright! Thanks for clearing that up


window.onerror in /updates

Error in ClashLeaders
window.onerror in /updates
Unable to get property 'fromNow' of undefined or null reference
View on Bugsnag
Stacktrace
js/common.js:44 -

View full stacktrace
Created automatically via Bugsnag

An error linked to this issue has been marked as fixed in Bugsnag
window.onerror in /updates


frame_ids where all 3D bounding boxes do not contain a single LiDAR point

There is an issue with frame_id 2018-02-04_10-02-19_00000 in the validation_day split.
The LiDAR scan misses many points and the ground truth 3D boxes do not contain any points.

I will exclude this frame in my LiDAR only 3D object detection pipeline.

I found two more frames of that kind, this time in the test_clear_night split.
2018-02-04_18-18-20_00000

and 2018-02-04_18-23-32_00000

I will also remove them from my LiDAR only object detection pipeline.

Hi Martin,
can you place a pull request. I will merge those chages into the master.
Best,
Mario

@MarioBijelic: done


Project Idea : Rose | ( Mathematics )

rose-mathematics
In mathematics, a rose or rhodonea curve is a sinusoid specified by either the cosine or sine functions with no phase angle that is plotted in polar coordinates. Rose curves or "rhodonea" were named by the Italian mathematician who studied them, Guido Grandi, between the years 1723 and 1728.
This project is an attempt to showcase its visualization.
Source-wikipedia
Main goal

Visualize rhondonea curve
Educate user about the mathematics behind it
Make it interesting and visually easy to understand.

Tech stack

Frontend: HTML, SCSS/CSS and JavaScript.

Examples :

As part of GSSOC 2021, I would love to develop it and contribute to this project.
@Vishal-raj-1 @urvashi-code1255 please assign me this !


False positive on spring-integration-core-4.0.3.RELEASE.jar

False positive on spring-integration-core-4.0.3.RELEASE.jar:
cpe:/a:pivotal:spring_framework:4.0.3
cpe:/a:vmware:springsource_spring_framework:4.0.3
https://mvnrepository.com/artifact/org.springframework.integration/spring-integration-core/4.0.3.RELEASE
The issue is related to spring framework core not spring integration.

See #574. Additionally, you can post multiple false positives in a single ticket).


TCH003 incosistency

This is a bit of a weird error/question concerning TCH003.
In a PR to our repo we noticed that ruff requested moving collections.abc.Callable into a type checking block.
This is by running ruff rotkehlchen/ package.py tools
rotkehlchen/accounting/history_base_entries.py:2:29: TCH003 Move standard library import `collections.abc.Callable` into a type-checking block

This is a bit surprising as our repository uses collections.abc.Callable in many other places just for type checking and this rule has not hit. We import it normally in the main module code.
ruff version: ruff 0.1.11
The question is how can we make it work on all of the code properly and why would it not work consistently?
Repo: https://github.com/rotki/rotki
Pyproject.toml: https://github.com/rotki/rotki/blob/8b5720fa1c5fcf5f8bd75fab68b7a9d315fe3476/pyproject.toml#L85

It just entirely depends on the code in question and where collections.abc.Callable is used. I can take a look at a few examples from the repo.

It just entirely depends on the code in question and where collections.abc.Callable is used. I can take a look at a few examples from the repo.

But Callable is always used in type checking only (at least in our repo) so that's what has me wondering what the heck. Sorry I know this is more of a question and not an issue. I can also take it elsewhere if you prefer.

Unfortunately it's a bit more complicated than that :joy: It's not just about whether it's only used in type annotations, it's about whether it's only used in typing contexts.
For example, this code does not run:
from typing import TYPE_CHECKING

if TYPE_CHECKING:
    from collections.abc import Callable

def func(x: Callable): ...

If you try, you'll get a runtime error:
Traceback (most recent call last):
  File "/Users/crmarsh/workspace/foo.py", line 6, in <module>
    def func(x: Callable): ...
                ^^^^^^^^
NameError: name 'Callable' is not defined. Did you mean: 'callable'?

Python requires type annotations to be available at runtime if they're in function definitions, or annotated assignments at the top level or in classes. So it ultimately depends on where the type is used.

As a counter example, this runs without issue:
from typing import TYPE_CHECKING

if TYPE_CHECKING:
    from collections.abc import Callable

def func():
    x: Callable = 1

# Note: call the function at the end to ensure the body runs.
func()

Since Python does not evaluate annotated assignments within function bodies.

As a counter example, this runs without issue:
Since Python does not evaluate annotated assignments within function bodies.

Ah I see. Okay I think I get it then. That's the difference. I was also surprised to not see the one that ruff hit for us cause a runtime error.
I expected we would need to quote it. But when I saw no runtime error I thought that perhaps something changed in the way python wants type annotations at runtime.

Python requires type annotations to be available at runtime if they're in function definitions, or annotated assignments at the top level or in classes. So it ultimately depends on where the type is used.

This is the explanation I was seeking. Thanks. Where is that stated in the python docs btw? Would love to have it handy for next time.

In https://docs.python.org/3/reference/simple_stmts.html#annotated-assignment-statements, they say:

For simple names as assignment targets, if in class or module scope, the annotations are evaluated and stored in a special class or module attribute annotations that is a dictionary mapping from variable names (mangled if private) to evaluated annotations... Annotations are never evaluated and stored in function scopes.

Then in https://docs.python.org/3/reference/compound_stmts.html#function-definitions, they say:

The annotation values are available as values of a dictionary keyed by the parameters’ names in the annotations attribute of the function object. If the annotations import from future is used, annotations are preserved as strings at runtime which enables postponed evaluation. Otherwise, they are evaluated when the function definition is executed. In this case annotations may be evaluated in a different order than they appear in the source code.

This behavior exists because of __annotations__ -- they need to populate it, so they have to evaluate the annotations. If you use from __future__ import annotations, this behavior doesn't exist (so Ruff will flag typing-only things much more consistently). I think the same is roughly true of the upcoming PEP that changes semantics again in lieu of from __future__ import annotations but I can't remember the details :)

Thank you so much @charliermarsh. Appreciate your super quick help.


Provide a way to mark a test as ignored (only for cargo-maelstrom)

Some tests may not run under cargo metest, but may run under other test runners. For these, we should provide a way for a user to mark them as ignored in the meticulous-test.toml file.

We're going to not doing this.

We should print the number of ignored (skipped, whatever) tests at the end of the test run, and possibly during as well.
If the underlying test runner (cargo, pytest, etc) has a notion of skipped/ignored/whatever tests, we should use the same notion. The difference is that the tests explicitly marked as ignored in cargo-maelstrom.toml/maelstrom-pytest.toml/etc. will only be ignored by Maelstrom.
The point of this is to give us a last resort way to turn off a test when it's not runnable on Maelstrom.


Add unit tests for upsample and pool

LGTM, after it passes the CI tests! Thanks for merging my changes from #96 into this PR -- will close after this gets merged.


ManagedCursorManager might not be threadsafe

Subscription and stream ids are stored in a plain HashMap.

Fixed by #159


Default value when no translation keys exist

Codecov Report

Merging #157 into develop will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop     #157   +/-   ##
========================================
  Coverage    47.82%   47.82%
========================================
  Files           11       11
  Lines           69       69
  Branches         8        8
========================================
  Hits            33       33
  Misses          34       34
  Partials         2        2

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5ea7d4e...977e2ca. Read the comment docs.


Apply new flutter-tizen C-API

Depends on https://github.com/flutter-tizen/engine/pull/278

I'll update engine hash after https://github.com/flutter-tizen/engine/pull/278 merged


Fix confusing/incorrect cache lookup wording in the TLB section.

The current wording seems to imply that caches are virtually indexed and virtually tagged and do not require physical address, hence TLB lookup's result.
However they are most commonly PIPT, and in any case always require the physical address for the tag to avoid aliasing issues. The L1 set can typically be selected from the virtual address only so the TLB lookup is indeed - only partially - overlapped, but L2 and L3 need the physical address prior to the lookup.

Thank you, this is an important fix.

Just a small cosmetic fix, hope you don't mind.
Regarding footnotes... I try not to use too many footnotes, otherwise, it becomes to heavy to read, I guess. People constantly jump back and forth, loosing their thoughts, etc.
So, I use footnotes carefully. :)

Yep that's fine!
To be honest I'm not sure footnotes are the best way to deal with sources, so it makes sense.
Maybe an alternative approach would be to have a "references" section at the end of each chapter or something like that.


add fidx and tests

This PR adds a new method for re-indexing a series or data frame based on a foreign key relationship, called fidx. This is is similar to  utils.misc.reindex. The key differences are

This method can re-index both series and data frames.

The method can re-index using mutliple-columns on the left, this implies that the right has a multi-index. This is helpful when doing an aggregation across multiple columns and then joining the result back to the original data frame.

For example, suppose we want to assign to each household the number of households of the same building type in their zone:
hh_by_zone_type = h.groupby(['zone', 'building_type_id']).size()
h['zonal_hh_same_type'] = fidx(hh_by_zone_type, h, ['zone', 'building_type_id'])

See the tests for examples.

Coverage increased (+0.04%) to 94.29% when pulling f8ee96ad91ec7fe6cb9fde77e164f37a9abb6095 on AZMAG:fk_reindex into 61fc8dd0f5abdd964e2cb897b2485255c89c2485 on UDST:master.

Coverage increased (+0.04%) to 94.29% when pulling 7af3d98261491eb2bd31685ea08cc445aad05d8f on AZMAG:fk_reindex into 61fc8dd0f5abdd964e2cb897b2485255c89c2485 on UDST:master.

A nice utility function for flexible re-indexing!  Looks good.


Adding one basic usage of WOQLClient and one basic usage of WOQLQuery in README

Now the usage session of the README only points people to the documentation. 😞
It would be great to give people an idea what terminusdb_client can do before leading them into the docs. 😉

one basic usage of WOQLClient:

[ ] could be creating a database
[ ] could be connecting to an existing database

one basic usage of WOQLQuery

[ ] could be creating a simple schema
[ ] could be making a simple query to a database with data

You have some flexibility here about what you can do. If you are new to the library, see the tutorial here to set some ideas. 💡

Hey, @Cheukting I am looking for a good first issue as I am a beginner in contributions. I would like to work on this issue.

Hey, @Cheukting I am looking for a good first issue as I am a beginner in contributions. I would like to work on this issue.

No problem, it's a good one to start


Widget UPowerWidget shows two icons with default configuration.

When I enable this widget without any configuration, I have two icons on my bar. The first one looks ok, it shows my real battery, but the second one is always full (100% charged, 0:00 until full - as the widget indicates).
My battery 'setup' in /sys, maybe helpful:
/sys/class/power_supply ❯ ll
0777 0 root 23 Feb 10:55 AC -> ../../devices/LNXSYSTM:00/LNXSYBUS:00/PNP0A08:00/device:35/PNP0C09:00/ACPI0003:00/power_supply/AC
0777 0 root 23 Feb 10:55 BAT0 -> ../../devices/LNXSYSTM:00/LNXSYBUS:00/PNP0A08:00/device:35/PNP0C09:00/PNP0C0A:00/power_supply/BAT0
0777 0 root 23 Feb 11:56 hidpp_battery_0 -> ../../devices/virtual/misc/uhid/0005:046D:B023.0008/power_supply/hidpp_battery_0

Can you run busctl tree org.freedesktop.UPower and paste the output here.

It's almost certainly picking up that "hidpp_battery_0" device so passing the name in the config is probably the correct solution here.

I think that entry comes from my external monitor. I've rebooted to do a 'before and after' test.  It seems it's not an external monitor's fault - it's the mouse. When I disconnect my wireless mouse, everything is fine again. Maybe this hidpp_battery shows status of the mouse's battery?

I've also did a test with my BT headphones - as it actually be quite cool to have battery status of all BT devices, right? - but nothing new shows. It works only for BT mouse.

The widget works by looking for any device with battery in the name so battery_hidpp_battery_0 would be matched.
This isn't a bug in the widget as far as I'm concerned and it's solveable by passing the name of a device in the config so I think we can close this.

Agreed, thanks for checking this!


Add conference buttons for standings tab

buttons will allow either conference's standings to be shown.

Seeing as the endpoint that I am using returns league standings rather than conference standings, I have chosen to display all 30 teams in one listview rather than having individual buttons for each conference.


doc: add export PERL5LIB env for running test cases

Full changelog

add export PERL5LIB env for running test cases

why we need this PR?

This addition will be useful because for Ubuntu this env config is needed to run the test cases.

This addition will be useful because for Ubuntu this env config is needed to run the test cases.

So does MacOSX.


Add fixes to combustion and add pr fixes

What does this PR change?
add fixes to combustion and PR fixes

@cbosdo I have rebased


Edit Distillery: Form not showing error message

On editing a distillery, if name or region_1 or region_2 are blank, there is no error message show.

This is fixed with #44