[No QA] Disable card reconciliation when auto-sync not enabled

Details

Disable card reconciliation when auto-sync not enabled.
Fixed Issues

$ https://github.com/Expensify/App/issues/44318
PROPOSAL: N/A
Tests

[x] Verify that no errors appear in the JS console

Open any workspace and enable accounting feature there.
Go to the accounting section.
Update URL to end with accounting/xero/card-reconciliation. For example: https://dev.new.expensify.com:8082/settings/workspaces/YOUR_POLICY_ID/accounting/xero/card-reconciliation
Make sure the  Card reconciliation screen looks as expected:

The toggle should be disabled if auto-sync is off.
The should be correct text.
The deep link to the Advanced settings (on auto-sync word) should work correctly.

Offline tests

N/A
QA Steps

[x] Verify that no errors appear in the JS console

N/A
PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x]  I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:

[x] I verified that all the inputs inside a form are aligned with each other.
[x] I added Design label and/or tagged @Expensify/design so the design team can review the changes.

[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

@DylanDylann @allgandalf I guess one of you should be a reviewer here

yeah, I will take over this PR. @rayane-djouah Please ignore this PR

How you getting on with the review? 👀

Reviewer Checklist

[ ] I have verified the author checklist is complete (all boxes are checked off).
[ ] I verified the correct issue is linked in the ### Fixed Issues section above
[ ] I verified testing steps are clear and they cover the changes made in this PR

[ ] I verified the steps for local testing are in the Tests section
[ ] I verified the steps for Staging and/or Production testing are in the QA steps section
[ ] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[ ] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[ ] I checked that screenshots or videos are included for tests on all platforms
[ ] I included screenshots or videos for tests on all platforms
[ ] I verified tests pass on all platforms & I tested again on:

[ ] Android: Native
[ ] Android: mWeb Chrome
[ ] iOS: Native
[ ] iOS: mWeb Safari
[ ] MacOS: Chrome / Safari
[ ] MacOS: Desktop

[ ] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
[ ] I verified proper code patterns were followed (see Reviewing the code)

[ ] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[ ] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[ ] I verified that comments were added to code that is not self explanatory
[ ] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[ ] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
[ ] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[ ] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
[ ] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[ ] I verified the JSDocs style guidelines (in STYLE.md) were followed

[ ] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[ ] I verified that this PR follows the guidelines as stated in the Review Guidelines
[ ] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
[ ] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[ ] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[ ] If a new component is created I verified that:

[ ] A similar component doesn't exist in the codebase
[ ] All props are defined accurately and each prop has a /** comment above it */
[ ] The file is named correctly
[ ] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[ ] The only data being stored in the state is data necessary for rendering and nothing else
[ ] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[ ] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[ ] All JSX used for rendering exists in the render method
[ ] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[ ] If any new file was added I verified that:

[ ] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[ ] If a new CSS style is added I verified that:

[ ] A similar style doesn't already exist
[ ] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)

[ ] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[ ] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[ ] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[ ] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[ ] If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:

[ ] I verified that all the inputs inside a form are aligned with each other.
[ ] I added Design label and/or tagged @Expensify/design so the design team can review the changes.

[ ] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[ ] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[ ] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

I see a bug while testing this PR. The auto-sync automatically enables after we disable the toggle
https://github.com/user-attachments/assets/38e68867-ef1c-435d-8490-321f942be311

cc @MariaHCD Also tag you here because this PR belongs to Expensify card Project

The auto-sync automatically enables after we disable the toggle

Not super familiar with that API command but from our backend logs, it looks like we successfully set autoSync as false.
But it seems the Onyx update contains autoSync as true?

@mountiny good here to merge?

🚀 Deployed to staging by https://github.com/mountiny in version: 9.0.10-2 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Cherry-picked to staging by https://github.com/mountiny in version: 9.0.10-3 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
failure ❌

🕸 web 🕸
success ✅

🚀 Deployed to production by https://github.com/mountiny in version: 9.0.10-7 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
failure ❌

🕸 web 🕸
success ✅

🚀 Deployed to production by https://github.com/francoisl in version: 9.0.11-5 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


Regex dispatcher docs

Fixes the categorical check on older versions of pandas.
Adds docstrings as requested in: #412
Compiles the patterns once.

LGTM.
@dr-leo does this register docstring improve things?


quick-start page

Added content to quick-start page. Let me know if their is other information that should be added.

Looks fine to me.
I'll just add an issue to merge the quick start with the installation later since it seems to me that there is a lot of overlapping content.

@FredKSchott we have some issues with the deployment here, maybe we could switch off the deployments for PR for now and leave just the deployment for the main?

Looks fine to me.
I'll just add an issue to merge the quick start with the installation later since it seems to me that there is a lot of overlapping content.

Yeah I noticed there is a lot of similar information in the home,  /installation, and /quickstart page. Also, would making the docs sidebar headings just be headings instead of links with their own page better? Might help avoid repetitive information.

@FredKSchott we have some issues with the deployment here, maybe we could switch off the deployments for PR for now and leave just the deployment for the main?

I think deployments for PRs are helpful when you want to see the physical changes the PR is making to the website


spark-2.1.1 does not exist

Error 404: http://apache.miloslavbrada.cz/spark/spark-2.1.1/spark-2.1.1-bin-hadoop2.7.tgz
The directory http://apache.miloslavbrada.cz/spark/spark-2.1.1 does not exist on the server anymore. One gets Error 404 while installing.

The Stream4Flow configuration uses the mirror of the Apache Spark that is nearest to us. However, it seems that this resource does not keep older versions. You can use a mirror that is nearest to you (use link from http://spark.apache.org/downloads.html) or change the address in the configuration to https://archive.apache.org/dist/spark/spark-2.1.1/spark-2.1.1-bin-hadoop2.7.tgz.
We will set this original source as the default configuration option.

Mirror URL has been updated to proposed link in commit f98e7e7
Closing


Allow importing utils.js in newer Node tools

The readme.md says that the following works:
import {isContentScriptRegistered} from 'webext-dynamic-content-scripts/utils.js';

if (await isContentScriptRegistered('https://google.com/search')) {
    console.log('Either way, the content scripts are registered');
}

However the import fails, because the exports section in package.json doesn't export utils.js.  So add an entry to export it, thereby making the docs correct without needing to change them.
We don't add a wildcard entry to the exports section, because the intention is to explicitly export certain files, and hide the rest as internals.
It's also worth noting that the main file has side effects, so utils.js is exported separately for the benefit of consumers who need that but don't want the side effects.
Fixes #67.

Thank you @aspiers! Releasing now


Update docx-preview.d.ts

As file docx-preview.d.ts seems to be maintained by hand
This pull request is aimed to update its definition file refer to https://github.com/VolodymyrBaydalka/docxjs/blob/master/src/docx-preview.ts
Some mainly updates:

remove MathML Polyfill due to https://github.com/VolodymyrBaydalka/docxjs/commit/01b48a50aac540cbbf0e3213bbf6d310726f8172
add the praseAsync function definition （seemed to be done in #83 ）
also update function params to support passing null

Prefer optional parameters over nullable


[DO NOT MERGE] Publish "/part-year-profit-tax-credits" start page as a transaction

This modifies the code that publishes smart-answers on deploy so it will publish the start page (aka "landing page") of "/part-year-profit-tax-credits" as a transaction that has the same content-id as the current "/part-year-profit-tax-credits" content item, and an exact route. Its "Start now" button will still point to the "/part-year-profit-tax-credits/y" path.
The pages of "/part-year-profit-tax-credits" other than the start page get republished as a StartPageLessContentItemFlow that have a new content-id and prefix routes. Their base path is "/part-year-profit-tax-credits/y".
Considerations:

At the moment, this works locally but on integration, the republishing attempt generates an error from the Publishing API: "error":{"code":422,"message":"Base path /part-year-profit-tax-credits is already reserved by smartanswers"
This is a proof of concept, all smart answers are meant to eventually get their start pages converted into transactions in the Publisher app.
The code related to the publishing of the start page is meant to be ephemeral, and will be deleted once the transaction is managed in Publisher.
Marking this as [DO NOT MERGE] until deploy on integration works and other PRs are ready.
I have not touched the StartNodePresenter, but once all the smart answer start pages have been converted to transactions, we should consider whether it is still useful.

cc @fofr and @pmanrubia if you/someone on your team gets a chance to have a look
This is part of the work to convert all start pages across GOV.UK publishers to transactions in the Publisher app, so they can be consolidated.
Trello

Hi @chrislo @floehopper @chrisroos  if you have any thoughts on this, we could use your feedback.

Sorry for the late reply, @binaryberry. I'll take a look at this now.

Closing in favour of #3122


Add Aman Sharma to Contributors list

Good tutorial! Thanks a lot.

Hi  @algomaster99, I'm quite elated about your pull request. I wanna evolve this project to addresses various problems faced by first-time contributors. I'd love to learn about your journey in open source community, the problems, pain points you had etc.
Could you explain how you felt when you went through the tutorial, made a pull request and learned that I merged it?
We’ve recently added social share  to our web app. Could you please go to https://roshanjossey.github.io/first-contributions/#social-share and share your first contribution to open source?
Also, check out projects with easy issues while you’re there.


additional parameter callback

Do you know how I could get the the additional parameter 'callback' into the following code in index.js
exports.handler = function(event, context, callback) {
I would need it because I want to integrate the AWS lambda function with the AWS API Gateway. When I add the add the additional parameter callback I get the following error when I run grunt package:
TypeError: callback is not a function
Do you know how I can solve the issue?

Looks like grunt-aws-lambda needs to be on 0.13

can you see if #8 fixes the issue?


Location autocompletions

Hey,
I am missing autocompletions for the locations stored in the vault so I started implementing this functionality. However, I saw you started working on that as well in the brach get-autocompletions. Your implementation also seems to be more intelligent than mine.
Is there a reason you haven't merged it yet? Would love to see it in master :)
Thanks
Christian

Closing this since it's no longer relevant, and autocompletions have been added to the -repl interface.


Update Table.vue to fix footer rendering

Issue

hasCustomFooterSlot as a function may be called when $slots.footer is not yet available and returns false.

Proposed Changes

hasCustomFooterSlot should be a computed property, because it needs to recompute if $slots.footer changes

ps: actually, I don't get why Oruga tries to asses if it's a custom footer since there's no default footer. Just have the slot there and let users do whatever they want. Maybe bind columnCount to the slot and call it a day.

Are you sure that computed listens $slots changes?

@luistrcastro I will add column-count and row-count as props to the footer slot.
I agree with @jtommy. I don't think a calculated property can watch if anything changes inside a slot. However, the v-if="$slots.footer" which is already in the code ensures that the hasCustomFooterSlot function is called first after a slot exists.
The hasCustomFooterSlot function not only checks if the footer slot is present, it also checks the html tag type of the first element of the slot, so that the slot can be wrapped by a th or not if the slot already provides the th.


Properly handle model outputs in scheduler

This PR depends on https://github.com/KULeuven-MICAS/zigzag/pull/17.
I don't think this is ready to merge yet, I have two questions:

What nodes should DNNWorkload mark as output? The old code seems to check is a non-empty list is empty. Is it just the last layer? Any layer whose output is not used by any other layer? (this latter option would keep the old "sink node" behavior from the scheduler.
Is this change to the scheduler correct? It's a bit strange how copying the tensor back and deleting it was tied together before. Is it okay to just copy it to offchip like I do here and then rely on the priority scheme to delete it automatically afterwards?

Hi.

Any node in the original DNNWorkload graph that doesn't have a successor should be considered a model output.
This behavior has since changed, so please review them and modify accordingly.


To be clear - python3 scripts/dream.py works just fine. The new web server command however results in the error message:
Traceback (most recent call last):
  File "/Users/sjm/repos/lstein-stable-diffusion/backend/server.py", line 6, in <module>
    import eventlet
  File "/Users/sjm/opt/anaconda3/envs/ldm/lib/python3.10/site-packages/eventlet/__init__.py", line 17, in <module>
    from eventlet import convenience
  File "/Users/sjm/opt/anaconda3/envs/ldm/lib/python3.10/site-packages/eventlet/convenience.py", line 4, in <module>
    from eventlet import greenpool
  File "/Users/sjm/opt/anaconda3/envs/ldm/lib/python3.10/site-packages/eventlet/greenpool.py", line 4, in <module>
    from eventlet import queue
  File "/Users/sjm/opt/anaconda3/envs/ldm/lib/python3.10/site-packages/eventlet/queue.py", line 49, in <module>
    from eventlet.event import Event
  File "/Users/sjm/opt/anaconda3/envs/ldm/lib/python3.10/site-packages/eventlet/event.py", line 3, in <module>
    from eventlet import hubs
  File "/Users/sjm/opt/anaconda3/envs/ldm/lib/python3.10/site-packages/eventlet/hubs/__init__.py", line 7, in <module>
    from eventlet.support import greenlets as greenlet
  File "/Users/sjm/opt/anaconda3/envs/ldm/lib/python3.10/site-packages/eventlet/support/__init__.py", line 6, in <module>
    from eventlet.support import greenlets
  File "/Users/sjm/opt/anaconda3/envs/ldm/lib/python3.10/site-packages/eventlet/support/greenlets.py", line 3, in <module>
    import greenlet
  File "/Users/sjm/opt/anaconda3/envs/ldm/lib/python3.10/site-packages/greenlet/__init__.py", line 29, in <module>
    from ._greenlet import _C_API # pylint:disable=no-name-in-module
ImportError: dlopen(/Users/sjm/opt/anaconda3/envs/ldm/lib/python3.10/site-packages/greenlet/_greenlet.cpython-310-darwin.so, 0x0002): tried: '/Users/sjm/opt/anaconda3/envs/ldm/lib/python3.10/site-packages/greenlet/_greenlet.cpython-310-darwin.so' (mach-o file, but is an incompatible architecture (have (x86_64), need (arm64e)))

I did set up the conda environment with the line PIP_EXISTS_ACTION=w CONDA_SUBDIR=osx-arm64 conda env create -f environment-mac.yaml and as stated, everything else works fine - so I'm a little stumped.

To know the arch, you can run
import platform
platform.platform()

If you indeed have arm64, that message is weird indeed. Maybe the library you have installed is for x86?

Getting this as well.
running "uname -a" from command line I get:
Darwin MacBook-Pro 21.4.0 Darwin Kernel Version 21.4.0: Fri Mar 18 00:46:32 PDT 2022; root:xnu-8020.101.4~15/RELEASE_ARM64_T6000 arm64

So I was able to fix this by uninstalling tokenizers with pip and reinstalling it with conda.
Run:
pip uninstall tokenizers
wait for it to finish then:
conda install tokenizers

I was able to solve this with similar to @OrcsDev - in my case it was
pip uninstall greenlet
...
conda install greenlet


What exactly does "open" mean. What about Reading Pane reading of an email?

Can the product team clarify what they mean by "open" an email? If a user sees the email in the Reading Pane in Outlook, keeps the email in the reading pane for 10 seconds while they read it, then deletes the email, is the email considered open, or unopened?
Thanks.

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: a3b1941b-9521-b3cc-d10f-1fbc640a0810
Version Independent ID: a3b1941b-9521-b3cc-d10f-1fbc640a0810
Content: Use Microsoft Viva Insights in Outlook
Content Source: Viva/insights/personal/use/use-insights.md
Service: viva
Sub-service: viva-insights
GitHub Login: @madehmer
Microsoft Alias: helayne

Hello @GitRomney
I am looking into this.

Hello,
I could gather this information for you:
" Confirmed with the engineering team - open means user clicked on the email to read it; we rely on outlook signals to see if the user has read the email.
Q: If a user sees the email in the Reading Pane in Outlook, keeps the email in the reading pane for 10 seconds while they read it, then deletes the email, is the email considered open
A: For this scenario, it will be counted as "Open". "


Fix Promise#all with multiple arguments, broken in 0498f7c4

Note that the spec seems to not have this functionality, thus, perhaps, the removal was purposeful.
If it was, see #71.

Sorry, that commit was probably a little big and a few things slipped through.  It was intentional that the functionality was removed, but I should definitely have done so in a separate commit.  Had I done so, we would have been much more likely to see the documentation change.
This was done as you say, to improve our compliance with the spec.

Cool. Thank you for your explanation.


Node.js tools doesn't use color outputs because of wrong TTY detection

Describe the bug
chalk is the most popular tool for color output in the Node.js ecosystem. Unfortunately, it can’t detect that GitHub Actions support color and use colorless output.
I created an issue and we found that Node.js does not detect TTY on stdout.
process.stdout.isTTY //=> undefined

As a result, we have less readable output in all npm tools.
Area for Triage: JavaScript and Node.js
Question, Bug, or Feature?: Bug
Virtual environments affected

[ ] macOS 10.15
[x] Ubuntu 16.04 LTS
[ ] Ubuntu 18.04 LTS
[ ] Windows Server 2016 R2
[ ] Windows Server 2019

Expected behavior
Color output for chalk based tools.
Actual behavior

Create empty index.js
Add npx size-limit index.js step
Check step output on the website: it has no colors.

Auto assigning script was failed, so I will mention people manually. Sorry if I will mention somebody wrong:
@leantk @vijayma @bryanmacfarlane

Yarn 2 is currently impacted as well. I'll use a workaround in the meantime, but I'll monitor these issues to add the right fix when possible 🙂

This may be an issue for actions/runner.  @TingluoHuang and @dakale , is that correct?

@bryanmacfarlane yes, I think the issue already tracked
https://github.com/actions/runner/issues/241

Closing in favor of tracking in https://github.com/actions/runner/issues/241

Jest doesn't output colors too


flutter: Separate cache and unwrapped derivations #2

This PR is a continuation of 238177 (Sorry for the trouble)
flutter-unwrapped will now not come with engine artifacts in its cache directory.
To specify a different cache directory, set FLUTTER_CACHE_DIR
Before this PR, changing which artifacts Flutter will have required rebuilding Flutter. This is because Flutter's unwrapped derivation required symlinking the engine artifacts to the cache directory($out/bin/cache).
So this:
pkgs.flutter.override {
  supportsAndroid = false;
  supportsLinuxDesktop = true;
}

And this:
pkgs.flutter.override {
  supportsAndroid = true;
  supportsLinuxDesktop = true;
}

Would build Flutter twice, even though it's not necessary.
To fix this, this PR moved the cache directory to an environment variable(when specified). This allows changing which artifacts
Flutter sees at runtime, so no need to rebuild.
Additionally, the wrapper has been adjusted to this change and will now provide the engine artifacts through FLUTTER_CACHE_DIR.
Note
The sh file $out/bin/internal/shared.sh runs when launching Flutter and calls $FLUTTER_ROOT/bin/cache/ instead of our environment variable FLUTTER_CACHE_DIR.
I decided not to patch it since the script doesn't require engine artifacts(which are the only thing not added by the unwrapped derivation), so it shouldn't fail, and patching it will just be harder to maintain.
Description of changes

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 240715 run on x86_64-linux 1

16 packages built:

firmware-updater
firmware-updater.debug
fluffychat
fluffychat.debug
flutter
flutter-unwrapped (flutterPackages.stable)
flutter-unwrapped.cache (flutterPackages.stable.cache)
flutter2
flutter2-unwrapped (flutterPackages.v2)
flutter2-unwrapped.cache (flutterPackages.v2.cache)
flutter37
flutter37-unwrapped (flutterPackages.v37)
flutter37-unwrapped.cache (flutterPackages.v37.cache)
hover
yubioath-flutter
yubioath-flutter.debug


[Coder] Refactor coder navigation by moving business logic to the model

This is done now. We will open individual issues track further progress


TableOperationsIT diskUsage failure

Changes in 23fa7d48e7908b9af0a761fda431ffa0fc472a12 have caused a failure in the getDiskUsage test of TableOperationsIT. Here is where the error is happening in the test:

[ERROR] Tests run: 6, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 116.32 s <<< FAILURE! - in org.apache.accumulo.test.TableOperationsIT
[ERROR] org.apache.accumulo.test.TableOperationsIT.getDiskUsage  Time elapsed: 19.208 s  <<< ERROR!
org.apache.accumulo.core.client.AccumuloException: org.apache.thrift.TApplicationException: Internal error processing getDiskUsage
	at org.apache.accumulo.core.clientImpl.TableOperationsImpl.getDiskUsage(TableOperationsImpl.java:1492)
	at org.apache.accumulo.test.TableOperationsIT.getDiskUsage(TableOperationsIT.java:158)

Here is the error that is being thrown in the tablet server:

org.apache.thrift.TException: java.io.FileNotFoundException: File file:/accumulo/test/target/mini-tests/org.apache.accumulo.test.TableOperationsIT_getDis
kUsage/accumulo/tables/2 does not exist
        at org.apache.accumulo.server.client.ClientServiceHandler.getDiskUsage(ClientServiceHandler.java:448) ~[accumulo-server-base-2.1.0-SNAPSHOT.jar:2.1.0-SNAPSHOT]
        at jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method) ~[?:?]
        at jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) ~[?:?]
        at jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) ~[?:?]
        at java.lang.reflect.Method.invoke(Method.java:566) ~[?:?]
        at org.apache.accumulo.core.trace.TraceUtil.lambda$wrapService$1(TraceUtil.java:197) ~[accumulo-core-2.1.0-SNAPSHOT.jar:2.1.0-SNAPSHOT]
        at com.sun.proxy.$Proxy28.getDiskUsage(Unknown Source) ~[?:?]
        at org.apache.accumulo.core.clientImpl.thrift.ClientService$Processor$getDiskUsage.getResult(ClientService.java:2431) ~[accumulo-core-2.1.0-SNAPSHOT.jar:2.1.0-SNAPSHOT]
        at org.apache.accumulo.core.clientImpl.thrift.ClientService$Processor$getDiskUsage.getResult(ClientService.java:2410) ~[accumulo-core-2.1.0-SNAPSHOT.jar:2.1.0-SNAPSHOT]
        at org.apache.thrift.ProcessFunction.process(ProcessFunction.java:38) ~[libthrift-0.15.0.jar:0.15.0]
        at org.apache.thrift.TBaseProcessor.process(TBaseProcessor.java:38) ~[libthrift-0.15.0.jar:0.15.0]
        at org.apache.accumulo.server.rpc.TimedProcessor.process(TimedProcessor.java:54) ~[accumulo-server-base-2.1.0-SNAPSHOT.jar:2.1.0-SNAPSHOT]
        at org.apache.thrift.server.AbstractNonblockingServer$FrameBuffer.invoke(AbstractNonblockingServer.java:524) ~[libthrift-0.15.0.jar:0.15.0]
        at org.apache.accumulo.server.rpc.CustomNonBlockingServer$CustomFrameBuffer.invoke(CustomNonBlockingServer.java:116) ~[accumulo-server-base-2.1.0-SNAPSHOT.jar:2.1.0-SNAPSHOT]
        at org.apache.thrift.server.Invocation.run(Invocation.java:18) ~[libthrift-0.15.0.jar:0.15.0]
        at io.opentelemetry.context.Context.lambda$wrap$1(Context.java:207) ~[opentelemetry-context-1.7.1.jar:1.7.1]
        at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128) ~[?:?]
        at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628) ~[?:?]
        at io.opentelemetry.context.Context.lambda$wrap$1(Context.java:207) ~[opentelemetry-context-1.7.1.jar:1.7.1]
        at java.lang.Thread.run(Thread.java:829) [?:?]
Caused by: java.io.FileNotFoundException: File file:/accumulo/test/target/mini-tests/org.apache.accumulo.test.TableOperationsIT_getDiskUsage/accumulo/tables/2 does not exist
        at org.apache.hadoop.fs.RawLocalFileSystem.listStatus(RawLocalFileSystem.java:491) ~[hadoop-client-api-3.3.0.jar:?]
        at org.apache.hadoop.fs.FileSystem.listStatus(FileSystem.java:1941) ~[hadoop-client-api-3.3.0.jar:?]
        at org.apache.hadoop.fs.FileSystem.listStatus(FileSystem.java:1983) ~[hadoop-client-api-3.3.0.jar:?]
        at org.apache.hadoop.fs.FileSystem$4.(FileSystem.java:2149) ~[hadoop-client-api-3.3.0.jar:?]
        at org.apache.hadoop.fs.FileSystem.listLocatedStatus(FileSystem.java:2148) ~[hadoop-client-api-3.3.0.jar:?]
        at org.apache.hadoop.fs.ChecksumFileSystem.listLocatedStatus(ChecksumFileSystem.java:741) ~[hadoop-client-api-3.3.0.jar:?]
        at org.apache.hadoop.fs.FileSystem$5.(FileSystem.java:2255) ~[hadoop-client-api-3.3.0.jar:?]
        at org.apache.hadoop.fs.FileSystem.listFiles(FileSystem.java:2252) ~[hadoop-client-api-3.3.0.jar:?]
        at org.apache.accumulo.server.fs.VolumeManagerImpl.listFiles(VolumeManagerImpl.java:269) ~[accumulo-server-base-2.1.0-SNAPSHOT.jar:2.1.0-SNAPSHOT]
        at org.apache.accumulo.server.util.TableDiskUsage.getDiskUsage(TableDiskUsage.java:218) ~[accumulo-server-base-2.1.0-SNAPSHOT.jar:2.1.0-SNAPSHOT]
        at org.apache.accumulo.server.client.ClientServiceHandler.getDiskUsage(ClientServiceHandler.java:440) ~[accumulo-server-base-2.1.0-SNAPSHOT.jar:2.1.0-SNAPSHOT]

One issue seems to be that it's not prefixing the filesystem root directory for RawLocalFileSystem correctly. So, it's checking for a file relative to the root of the local filesystem, which is incorrect. This might have gone unnoticed with the globbing, because the glob never matched anything, whereas the current code now has a starting point in a directory it expects to exist.
A second issue is that the directory might not exist on all volumes, so we might need to have it ignore the case when there are no files on that specific volume. My concern doing this here, though, is that it might mask the first issue above, which should be fixed first.

I am not sure if the prefixing is causing the failure but the command works a few times in the IT up until it clones the table. After the clone, then it fails to find the second tableId. So there may be something else going on.

It looks like there is a change in the way that TableDiskUsage behaves with the newly created table that has yet to be compacted. Before the recent change, the test would run the command (after cloning the table but before compacting) and only return results for one table:

diskUsages = accumuloClient.tableOperations().getDiskUsage(tables);
assertEquals(1, diskUsages.size());
assertEquals(2, diskUsages.get(0).getTables().size());
assertTrue(diskUsages.get(0).getUsage() > 0);

So the files for the new table aren't there yet, until it gets compacted. Then when the command is run, it will return results for both tables.
Since the recent changes to TableDiskUsage, an exception is now thrown because the file isn't found, instead of just quietly failing as it did before. The file isn't there yet because compaction hasn't run.
I am not sure if this is a problem, since it only seems to happen in the mini test with the RawFileSystem. I ran similar commands in the shell in Uno and it works fine. Do we want to change the behavior to make the test pass? Or change the test to pass for the new behavior?

If the file (or it appears directory in this case) would it be appropriate to return a size of 0? Which, I think is your change the behavior option?

I am not sure if this is a problem, since it only seems to happen in the mini test with the RawFileSystem. I ran similar commands in the shell in Uno and it works fine.

I was mistaken. The command fails in Uno as well. Bottom line is that it doesn't handle clones. I think it might be a bug.

If the file (or it appears directory in this case) does not exist, would it be appropriate to return a size of 0? Which, I think is your change the behavior option?

I think that is one possible solution. The problem is I don't fully understand the code in TableDiskUsage that tracks different sets of IDs so I am not sure where we need to make an adjustment.


Error gzip.BadGzipFile

I'm always getting this error
2022-11-17 11:58:57 [scrapy.core.scraper] ERROR: Error downloading <GET https://xxxxxxxxxxxxxxxxxxxxxxxxxx>
Traceback (most recent call last):
  File "/xxxxxxxxxxxxx/python3.10/site-packages/twisted/internet/defer.py", line 1697, in _inlineCallbacks
    result = context.run(gen.send, result)
  File "/xxxxxxxxxxxxx/venv/lib/python3.10/site-packages/scrapy/core/downloader/middleware.py", line 60, in process_response
    response = yield deferred_from_coro(method(request=request, response=response, spider=spider))
  File "/xxxxxxxxxxxxx/venv/lib/python3.10/site-packages/scrapy/downloadermiddlewares/httpcompression.py", line 62, in process_response
    decoded_body = self._decode(response.body, encoding.lower())
  File "/xxxxxxxxxxxxx/venv/lib/python3.10/site-packages/scrapy/downloadermiddlewares/httpcompression.py", line 82, in _decode
    body = gunzip(body)
  File "/xxxxxxxxxxxxx/venv/lib/python3.10/site-packages/scrapy/utils/gz.py", line 27, in gunzip
    chunk = f.read1(8196)
  File "/usr/lib/python3.10/gzip.py", line 314, in read1
    return self._buffer.read1(size)
  File "/usr/lib/python3.10/_compression.py", line 68, in readinto
    data = self.read(len(byte_view))
  File "/usr/lib/python3.10/gzip.py", line 488, in read
    if not self._read_gzip_header():
  File "/usr/lib/python3.10/gzip.py", line 436, in _read_gzip_header
    raise BadGzipFile('Not a gzipped file (%r)' % magic)
gzip.BadGzipFile: Not a gzipped file (b'\n\n')

I tried COMPRESSION_ENABLED=False and changing priority of scrapy.downloadermiddlewares.httpcompression.HttpCompressionMiddleware, without success


It is better to adjust the size of the clone blob container dialog to ensure no scrollbar appears

Storage Explorer Version: 1.33.1 (98)
Build Number: 20240409.2
Branch: hotfix/1.33.1
Platform/OS: Windows 10/Linux Ubuntu 22.04/MacOS Sonoma 14.4(Apple M1 Pro)
Architecture: x64/x64/arm64
How Found: Ad-hoc testing
Regression From: Previous release (1.31.2)
Steps to Reproduce

Expand one storage account -> Blob Containers.
Right click one blob container -> Click 'Clone...'.
Type 'aa-' into the 'New name' field.
Check whether there is no scrollbar.

Expected Experience
It is better to adjust the size of the dialog to ensure no scrollbar appears.
Actual Experience
There is a scrollbar.

Additional Context
Here is the screenshot in previous release 1.31.2 version.

@richardMSFT I'm not able to reproduce this. Can you verify on Mac and Windows? If it reproduces, there could be a problem in the auto-sizing code, but let's just adjust the size of the dialog for now.

This issue only reproduces on Windows platform.

I'm keeping Richard assigned just so we retain that he originally worked on this.


Potential Security Issue

Hello,
We recently received a vulnerability disclosure against your repository. I couldn't find an e-mail to contact or a security process to follow, so created this issue instead.
If you would like me to e-mail over the details or put them on the GitHub Issue, I'm more than happy to facilitate this for you. Otherwise, you can access the advisory here.
It is private to you and the discloser of the report.
If you have any questions, let me know.
-- Jamie from huntr.dev

Sure. If there is a possible heap overflow somewhere somehow, then I'd like to know. There is a lot of checking on the code by us, and in the code, to avoid that.
The RE/flex library and the tool are two different and separate parts of the project. The reflex tool is a translator and not a piece of software that is deployed online or used in a way where a heap overflow could do harm.
You can find my contact info via my GitHub profile that points to my LinkedIn page. Just PM me.

Hey @genivia-inc - I have sent you a connection request on LinkedIn, and happy to give you more details over this.
If you want to view the vulnerability disclosure in the meantime, you can here:
https://huntr.dev/bounties/1-other-Genivia/RE-flex/
Let me know if you have any more questions, here to help!

Why do I need to sign up for this service to view the potential problem? Why is this posted somewhere for those that sign up and not securely communicated by email to me or the team or e.g. via a private dropbox? This is very unusual.

@genivia-inc - you don't need to sign up at all!
Happy to send you the report via e-mail. Will follow up on your earlier e-mail with the vulnerability information.
Cheers! 🍰

OK. Then I will remove this issue, because we will take it from there.

This does not look like a vulnerability after carefully checking possible usage scenarios, inputs etc. on our end with experts. I will share my observations by email and delete this issue, because we should continue our discussion there.


java.lang.NoClassDefFoundError: org/bouncycastle/util/Pack

Hello everyone, I wanted to ask for your help in this problem, I implemented the JpassKit library in a Springboot application and it uses the bcpkix-jdk15on-1.70.jar, bcprov-jdk15on-1.70.jar and bcutil-jdk15on-1.70.jar libraries to generate boarding passes, everything works correctly until the moment I generate the .war and deploy it to a Tomcat server, it shows me the following error:
2024-06-28 06:58:35,192 [http-nio-8080-exec-251] [3856417a-fe79-449e-a2f6-d5321042c342] ERROR org.springframework.boot.web.servlet.support.ErrorPageFilter - Forwarding to error page from request [/ticket/F#######/173642B721145525/pkpass] due to exception [org/bouncycastle/util/Pack]
java.lang.NoClassDefFoundError: org/bouncycastle/util/Pack
at org.bouncycastle.crypto.digests.SHA1Digest.processWord(Unknown Source)
at org.bouncycastle.crypto.digests.GeneralDigest.update(Unknown Source)
at org.bouncycastle.jcajce.provider.digest.BCMessageDigest.engineUpdate(Unknown Source)
at java.security.MessageDigest.update(MessageDigest.java:325)
at org.bouncycastle.operator.jcajce.JcaDigestCalculatorProviderBuilder$DigestOutputStream.write(Unknown Source)
at org.bouncycastle.util.io.Streams.pipeAll(Unknown Source)
at org.bouncycastle.cms.CMSProcessableFile.write(Unknown Source)
at org.bouncycastle.cms.CMSSignedDataGenerator.generate(Unknown Source)
at de.brendamour.jpasskit.signing.PKAbstractSigningUtil.signManifestUsingContent(PKAbstractSigningUtil.java:116)
at de.brendamour.jpasskit.signing.PKFileBasedSigningUtil.signManifestFileAndWriteToDirectory(PKFileBasedSigningUtil.java:133)
at de.brendamour.jpasskit.signing.PKFileBasedSigningUtil.createSignedAndZippedPersonalizedPkPassArchive(PKFileBasedSigningUtil.java:98)
at de.brendamour.jpasskit.signing.PKFileBasedSigningUtil.createSignedAndZippedPkPassArchive(PKFileBasedSigningUtil.java:77)
at com.#############.service.BookingService.generatePkPass(BookingService.java:1150)
at com.#############.service.BookingService.buildPkPass(BookingService.java:945)
at com.#############.service.BookingService.getSinglePkPass(BookingService.java:930)
at com.#############.web.BookingControllerImpl.getSingleTicketWallet(BookingControllerImpl.java:126)
the class is correctly located in the .war component at path 0.war\WEB-INF\lib\bcprov-jdk15on-1.70.jar\org\bouncycastle\util\ as seen in this image

I attach an image with the dependency tree

The application is using Java version 8 and we have implemented version 0.3.4 of JpassKit and this use these versions of your libraries, We tried adding the libraries to the pom.xml of web component the current version 1.70 and the1.76 doing a the previous exclusion of this way but show the same error

de.brendamour
jpasskit
0.3.4

org.bouncycastle
bcpkix-jdk15on

org.bouncycastle
bcprov-jdk15on

org.bouncycastle
bcprov-jdk18on
1.76

org.bouncycastle
bcpkix-jdk18on
1.76

I would be very grateful if you can shed some light on this problem.

It'll be a class path issue. What I'm not sure though.


Find settlement agencies list does not load

When navigating to help page and click Find a settlement agency near me the topic services took a really long time to load. Clear the cache and find potential regression.
Topic services are cached when it loads, may require clearing cache for most accurate results.
Acceptance Criteria

[ ]  Topic service shouldn't take more than 5 seconds to load

Steps for QA:

Navigate to help page by clicker on the question
Click on Find a settlement agency near me
Services should load in 5 seconds

Tested on Staging V1.41.0 Server V1.3.34 on iOS:

[x] Topic service shouldn't take more than 5 seconds to load (took about 3 seconds)


'too many arguments -- limit is 4096' exception

Hi!
I am trying to test in my project and it contains over 7000+ files, after running command like ' bartycrouch code -p Classes/ -l . ',  I got this exception: Terminating app due to uncaught exception 'NSInvalidArgumentException', reason: 'too many arguments (7102) -- limit is 4096'.
It seems to be an os limit? How can I deal with this situation? Thank you.

Hi there and wow, that's many files! I didn't even know there is a file limit, the big question is where that file limit arises. I should definitively dive into this question some time. But for the time being, an easy solution would be to separate those files into at least two different subfolders and run BartyCrouch twice, once for every subfolder.

@lazie I just validated this issue and it actually happens and can't be fixed very easily. I will try to find a nice solution though. I have a workaround in mind that will probably work, but it's quite hacky, so I'll wait search for a better solution first. I'll keep you updated.

I currently unfortunately also experience this.
bartycrouch update -x give me
2019-05-22 09:32:58.741 bartycrouch[47331:688397] *** Terminating app due to uncaught exception 'NSInvalidArgumentException', reason: 'too many arguments (7167) -- limit is 4096'
*** First throw call stack:
(
	0   CoreFoundation                      0x00007fff53352cfd __exceptionPreprocess + 256
	1   libobjc.A.dylib                     0x00007fff7d9fca17 objc_exception_throw + 48
	2   CoreFoundation                      0x00007fff53352b2f +[NSException raise:format:] + 201
	3   Foundation                          0x00007fff55545619 -[NSConcreteTask launchWithDictionary:error:] + 773
	4   bartycrouch                         0x000000010d719dac $s8SwiftCLI4TaskC6launch030_19E0ACB72F1C972020BFBD69850F9J1FLLyyF + 364
	5   bartycrouch                         0x000000010d719949 $s8SwiftCLI4TaskC7runSyncs5Int32VyF + 25
	6   bartycrouch                         0x000000010d71c9e9 $s8SwiftCLI3run_9arguments9directoryySS_SaySSGSSSgtKFTf4xnn_n + 393
	7   bartycrouch                         0x000000010d718bd9 $s8[1]    47331 abort      bartycrouch update -x

bartycrouch lint -x gives me
Starting Task 'Lint' ...
[1]    47453 illegal hardware instruction  bartycrouch lint -x

Currently kinda stuck and had to disable Bartycrouch until this is fixed.

Yeah, this is still planned, the fix isn't trivial though, so it might take a while. Until then instead of disabling BartyCrouch, you could also run it separately for different folders in your project each of which doesn't exceed the limit.

Hey everyone, I just released version 4.1.1 of BartyCrouch which attempts to fix this issue. Please try it out and report any issues you might run into. Should be available soon on Homebrew, or if you can't wait, just install it with Mint: mint install Flinesoft/BartyCrouch


Rendering fails when video width < 720

Hi dear.
I wonder why this has changed.
If it changes like this, no video will be output.
After that, however, the video is output again.
Please answer me. ;(
[envoronment]
Doctor summary (to see all details, run flutter doctor -v):
[✓] Flutter (Channel beta, v1.0.0, on Mac OS X 10.14.2 18C54, locale ko-KR)
[✓] Android toolchain - develop for Android devices (Android SDK 28.0.3)
[✓] iOS toolchain - develop for iOS devices (Xcode 10.1)
[✓] Android Studio (version 3.2)
[✓] VS Code (version 1.30.2)
[✓] Connected device (1 available)
[mediaconstraint code]
Map<String, dynamic> mediaConstraints = {
'audio': true,
'video': {
'mandatory': {
'minWidth': '640',
'minHeight': '480',
'minFrameRate': 30,
},
'facingMode': 'environment',
'optional': [],
}
};
try {
await navigator.getUserMedia(mediaConstraints).then((stream) async {
_localStream = stream;
});
} catch (e) {
debugPrint(e.toString());
}
[create peerconnection]
Future goCreatePeerConnection() async {
_pc = await createPeerConnection(_iceServers, _config);
_pc.onIceCandidate = (candidate) {
  RTCIceCandidate newCandidate;
  if(candidate == null) {
    debugPrint('candidate is null');
  } else {
    newCandidate = new RTCIceCandidate(
      candidate.candidate,
      candidate.sdpMid,
      candidate.sdpMlineIndex);
  }
  sendCandidate(newCandidate);
};

**_pc.addStream(_localStream);  <---- I think this code is problem.**

}
[rtc_video_view.dart]
...
initialize() async {
final Map<dynamic, dynamic> response =
await _channel.invokeMethod('createVideoRenderer', {});
_textureId = response['textureId'];
_eventSubscription = _eventChannelFor(_textureId)
.receiveBroadcastStream()
.listen(eventListener, onError: errorListener);
_eventSubscription.onData((dynamic data) {
debugPrint('--=-=-=-=-=-eventSubscription data:$data');
});
}
...
[console log]
flutter: --=-=-=-=-=-eventSubscription data:{id: 0, event: didTextureChangeVideoSize, width: 480.0, height: 640.0}
flutter: --=-=-=-=-=-eventSubscription data:{event: didTextureChangeRotation, id: 0, rotation: 90}
flutter: --=-=-=-=-=-eventSubscription data:{id: 0, event: didTextureChangeVideoSize, width: 360.0, height: 480.0}  <----- This change
flutter: --=-=-=-=-=-eventSubscription data:{id: 0, event: didTextureChangeVideoSize, width: 480.0, height: 640.0}

Attempt to fix that by replacing FlutterTexture with FlutterPlatformView lies here
https://github.com/cloudwebrtc/flutter-webrtc/tree/metal_experiment

@rostopira @LinusU @anewgate
This change submitted https://github.com/cloudwebrtc/flutter-webrtc/commit/83f690b03888e011695c9b160a3b07b3559b017d may have fixed the issue and https://github.com/cloudwebrtc/flutter-webrtc/issues/26 that the Screen Frame cannot display.
It may take several test confirmations before the issue can be closed.
The reason is that CVOpenGLESTextureCacheCreateTextureFromImage in ios_external_texture_gl.mm cannot create TextureCache and return to -6683. I refer to https://developer.apple.com/library/archive/qa/qa1781/_index.html for patches.

iPad (2018) with iOS 12.0: works

I verified on iPhone 8 and iPhone X and it worked fine, so close the issue now.


About the Impact of a Single World

I have installed this module on my server. According to feedback from server players, the effect is very good. Can you update a feature about world control in a future version. We need sparse structures to only work in the overworld, while the two worlds of Nether and end still maintain vanilla structures

I think I'll try to add this along the update that'll add support for different worlds.


⚠ Bofrost.be has degraded performance

In d449ad0, Bofrost.be (https://www.bofrost.be) experienced degraded performance:

HTTP code: 200
Response time: 1039 ms

Resolved: Bofrost.be performance has improved in 3336352 after 306 days, 4 hours, 10 minutes.


ImageNet_C overhaul (take 2)

let's try this again

The issue with OpenMind is that the unzipping of stimuli for some reason takes hours and seems to ultimately fail. I'll try re-triggering one more time and if it fails run the tests locally on braintree

we might want to mark those slow tests as @very_slow and not run them on braintree to not stuff with future stuff

all stimulus_sets run into KeyError: 'label' in https://github.com/dapello/brainio_collection/blob/ad2e8ee49915a6a41875a681e756a42e02daa844/tests/test_stimuli.py#L89 etc

are the uploaded stimulus_sets fixed? I'm still getting KeyError: 'label' in eg tests/test_stimuli.py:107

passed! Let me add something to exclude the super-long-running tests from braintree


net: lwm2m: sensor value (5700) of ipso temperature is read-only res

Sensor value is a read-only resource. A write callback for the resource
is non-sense. Remove the unreachable write-callback
Search 3303 for IPSO temperature object definition at site , 5700 for the sensor value definition

Sounds reasonable.


9anime Companion v1

Some of my suggestions for V1

[ ] Show only limited number of Recently Watched list on popup
[ ] Show only limited number of Recently Pinned list on popup
[ ] Dedicated Pinned and Recently Watch list page
[ ] Auto Mal Sync
[ ] Custom theme [custom styling & full theme]
[ ] New settings page [with more advance settings]
[ ] Playback settings [eg 1 second backward on left arrow]
[ ] Browser notification for Pinned anime?
[ ] Highlight pinned anime on Anime Schedule Page
[ ] Show download options depending on resolution [if max 720, 1080p button will be hidden]

and that's all for now

Both if possible, being able to change specific element color and even change the entire theme (eg white theme)

Show download options depending on resolution [if max 720, 1080p button will be hidden]

@densityx what happens when within the same anime, some episodes have lower quality videos and some higher quality? Check: https://github.com/lap00zza/Grabber/issues/13 for some context.

Ahhh... I understand what you are saying :frowning:
Show download options depending on resolution [if max 720, 1080p button will be hidden]
this is only applicable if the user is only downloading single episode
So I think using default fallback resolution (https://github.com/lap00zza/Grabber/issues/13) is good for this one

@densityx can you place all the suggestions in the Nice To Have column here: https://github.com/lap00zza/9anime-Companion/projects/2
Make sure to use a new card for each suggestion

Closing this issue. Moved the remaining tasks to the https://github.com/lap00zza/9anime-Companion/projects/2.


Add babel-preset-es2015

Turns out this is actually required for transpiling import statements within the jest files themselves. This should only transpile test code, so I'm not too worried about the extra size here.
Fixes #68

This is a follow-up to #67 that was supposed to be included in the original PR but I forgot to push 🤐


Logos

[ ]   #@58335434

58335434Logos buzz

Why:
Closes [issue link]

What's being changed:

Check off the following:

[x] I have reviewed my changes in staging (look for "Automatically generated comment" and click Modified to view your latest changes).
[x] For content changes, I have completed the self-review checklist.

Writer impact (This section is for GitHub staff members only):

[x] This pull request impacts the contribution experience

[ ] I have added the 'writer impact' label
[ ] I have added a description and/or a video demo of the changes below (e.g. a "before and after video")

Eee

https://github.com/github/docs/blob/6ef023a249c9d9605ee75012cd91d3e400c43dfe/content/packages/working-with-a-github-packages-registry/working-with-the-docker-registry.md

Iam<EMAIL_ADDRESS>


Parsing the filepath: regex vs custom parser

So for parsing the filepath I originally had in mind something like this functionality from mp3tag:

Basically the user inputs the pattern using percentages to delimitate the fields.
This is also possible with regex like this:

Each strategy has their strength and weaknesses:

custom parser is more intuitive
regex can parse more complex patterns, for example when the pattern is the number of characters instead of a separator
custom parser cannot distinguish if there is no separator between the fields (ie in 'i1s001rest' it cannot separate 001 from rest)
regex needs the user to input in another variable the fields (in order) as they are parsed on the string

As of now I'm supporting the custom parser but I think supporting regex will allow more flexibility for power users.

I vote for using an already established technique like regex because people already know this and creating your own parser always looks easier than it is in the end

@stebo85 I had already implemented the custom parser it works well enough, but the point of regex being the standard is good argument. I do find the custom parser more intuitive for non-technical users.
I will try to implement the regex one and maybe put the whole parsing backend through regex, that is , translating the percentage notation of the custom parser to a regex pattern.  That way all is done through regex and the percentage notation is optional and only for non-technical users.

closing this since it is already implemented in regex and the percentage notation translation to regex is also already implemented.


Serialport communication fails at 250000 baudrate on Raspberry Pi

SerialPort Version: 6

NodeJS Version: 8.7

Operating System and Hardware Platform: Raspbian Jessie Lite on Raspberry pi

Have you checked the right version of the api docs?: Yes

Are you having trouble installing and you checked the Installation Special Cases docs? N/A

Are you using Electron and have you checked the Electron Docs?: N/A

Summary of Problem
Unable to communicate with Arduino at 250000 baudrate. Identical code runs great on 2014 Mac running OSX 10.12
Steps and Code to Reproduce the Issue
I've created a repo for reproducing this bug:
https://github.com/matthova/serialport-6-250000-test

I've created a repo for reproducing this bug:
https://github.com/matthova/serialport-6-250000-test

Just attempted the same code on Raspbian Stretch lite with the same failure mode of no reply.

Linux has standard baud rates and custom baud rates. Standard baud rates are handled by serialport and can be seen here. serialport also has code for handling custom baud rates here.
250000 is a custom baud rate and for some reason it doesn't work. I tried out the code in your repo and attempting to set the baud rate to 250000 actually sets it to 38400. I'm not sure if this is a serialport issue, a Raspbian driver issue or something else. Ubuntu 14.04 also has the issue.
What does work is if the baud rate is set to a standard baud rate like 230400 which is fairly close to 250000.

@fivdi thanks for confirming the issue and for more background on where it's handled. I wish I could just set the baudrate to 250000 but I'm stuck working with 3rd party hardware that is set at 250000. @reconbot let me know if there is anything I can do to dig into the code and help with a solution.


Documentation mistake

In https://github.com/nettrine/orm/blob/master/.docs/README.md#setup
extensions:
    orm.annotations: Nettrine\ORM\DI\OrmAnnotationsExtension

orm.annotations:
    paths:
        - App/Model/Database/Entity

Instead of App/Model/Database/Entity use %appDir%/Model/Entity ?

Thanks.


Unable to run an example code.

Hello,
I am working on IOTA streams. I am new to rust and IOTA streams. But I am familiar with MAM and IOTA transaction object and implementation. Question is, the example codes from the streams/examples/src/branching/ does not work!. and creating an author itself throughs an long list of errors. for example (only a part of error, despite using "--extern")
error[E0433]: failed to resolve: maybe a missing crate iota_streams?
--> First_Streams.rs:1:5
|
1 | use iota_streams::{
| ^^^^^^^^^^^^ maybe a missing crate iota_streams?
I use linux machine, 18.04 LTS, Do I have to implement any of the iota_streams trait explicitly to avail the functionality ?.
Please correct me if I am wrong. And the Readme.md needs update. because the cargo test "--all" is deprecated.
BR,

The examples codes can be run by command cargo run --release.


Refs 4426: Enforce external,upload for custom repositories

Summary

Updates repositories list API call for use with the incoming upload repositories feature.

Testing steps

Sanity check, make sure all the things still work?

https://issues.redhat.com/browse/HMS-4426

⚠ This task currently requires qe-approval, but this PR does not fully resolve the task.  Please contact QE to determine appropriate testing required.

/retest


Exception handling for Python 3

Exception handling didn't work with Python 3 for failed connections, or authentication errors.

Coverage remained the same at 87.676% when pulling 1f7396a38b1de9965448c8d16af9f907a035462f on ogenstad:exceptions into a15da181eef908ae8438a85b2c91a16ec64f01de on fooelisa:master.


Image literals passed into onOverlapsTile will cause Blockly to throw an exception

Here is a program that reproduces the issue: https://makecode.com/_8KzRkXg5kc4y
The decompiler shouldn't be trying to decompile that literal into a tile picker block; it should decompile it as an image literal block.

Reported in the forum here: https://forum.makecode.com/t/oops-something-went-wrong-trying-to-convert-your-code/1159/3


Microsoft Learn Portal does not allow changing personal email address

It seems I have a business email address that was used to set up a personal MS Learn account. I also have an Outlook account that I have some Learn activity under.
I don't seem to be able to move the activity of the personal account with the business email address to my Outlook account.
I also don't seem to have a way to change the business email address of the personal account. If I leave my employer that email address would go away and I would like to preserve the Learn activity under this account by moving to my Outlook account or at the very least assigning a new personal email to log on with.
The Submit Feedback link at the bottom of the Learn page brought me here to submit this issue.
The primary point here is that the instructions at this link are not valid and do not match the available information on the web sites described...
https://support.microsoft.com/en-us/account-billing/change-the-email-address-or-phone-number-for-your-microsoft-account-761a662d-8032-88f4-03f3-c9ba8ba0e00b

@mth11 Click on your avatar and go to your profile.  Click on "Settings" and see account management.


Global Media Group Services Ltd Bug Bounty Program

URL
https://global.com/bug-bounty-policy/
Contact
<EMAIL_ADDRESS>Bounty
Yes
Additional Information

Information

It’s important that anybody can contact us, quickly and effectively, with security concerns or information pertinent to:
– Our customers’ privacy;
– Our suppliers’ privacy;
The confidentiality, integrity or availability of our systems.
We operate this responsible disclosure policy to help security professionals and others alert us of any security concerns as quickly as possible and with the minimum of fuss.

Response Targets

Global will make reasonable efforts to respond to submission to our programme in a timely manner. Please note the mailbox is only monitored:
– 09:00 – 17:00 (UTC) Monday to Friday. (Excluding UK public holidays)
We’ll try to keep you informed about our progress throughout the process and alert you if we’re delayed for any reason.

Disclosure Policy

We request that you always act responsibly and in the best interests of Global and our customers. In particular:
– Do not break the law;
– Do not use social engineering techniques, phishing, or physical attacks against our customers, infrastructure or staff;
– Do not perform any attack that could harm the reliability or integrity of our systems, services or data. DoS and/or spam attacks are not allowed;
– Do not put any Global data or customer data at risk;
– Do not make the bug public before it has been fixed; and
– When in doubt, email us.
Out-of-scope areas and exceptions include:
– DoS or DDoS.
– Destructive or performance-impacting attacks or testing.
– Social engineering or Phishing.
– Submissions relating to clickjacking.
– Submissions of TLS configuration weaknesses (e.g. “weak” ciphersuite support, TLS1.0, TLS1.1 support, sweet32 etc.) or Certificate issues.
– Submissions indicating that our services do not fully align with “best practice” e.g. missing security headers (CSP, x-frame-options, x-prevent-xss etc.) or suboptimal email related configuration (SPF, DMARC etc.).
– Simple rate-limiting issues without a security impact.
– Submissions entirely comprising output from commonly available automated scanners.
– Submissions that do not pertain to Global’s assets.
– Submissions of non-exploitable vulnerabilities.
When reporting an issue to us:
Please highlight security issues in third-party apps or websites that integrate with global.com;
– Be specific;
– Provide a detailed and complete submission (masking or encrypting if necessary);
– Reference existing vulnerability information, where relevant.
It is important to follow the above guidelines so that we treat your communication as a responsible disclosure and not an attack or extortion.
Be aware that Global run internal scans and testing and we may have already be aware of any submission.

Rewards

All confirmed vulnerabilities will be considered, assessed and awarded a bounty based on severity as determined by our in-house team. We do not offer a published score against CVSS metrics or similar. Each submission is judged on its own merit, applying many factors such as severity, business function of the system, the cost to mitigate, etc.
We do not guarantee that a reward will be paid and Global’s assessment of the severity of an issue and the corresponding amount of any reward, if any, will be final.
To be eligible for a reward, you must agree and adhere to our rules set out in section 5 below.

Rules

By submitting a report, you agree to comply with the following rules:

The Terms of Use for global.com as set out here;

The terms of our Privacy Notice. In particular, you agree that we can use your submission and its contents to ensure the security, integrity and reliable operation of our systems, technology and business; and

The applicable sections of our Terms and Conditions and Regulatory requirements, outlined here.

Upon Global’s request, you will agree and sign: (i) a Non-Disclosure Agreement; and (ii) a Letter of Undertakings, formally confirming that you have not downloaded, made copies of or shared with any third parties any information accessed by you and belonging to Global, and undertaking that you will continue to do the same.

Your submission should contain the following:
– Clear description and evidence of the vulnerability (logs, screenshots, responses) ;
– Detailed steps to reproduce the issue;
– Any platforms, operating systems, versions that are relevant;
– Any relevant IP addresses or URLs;
– Any supporting evidence you have collected (logging, tracing, etc.);
– Your assessment of the exploitability or impact of the issue;
– Your name, role (if appropriate) and contact details.
Please preserve as much evidence as possible as we may need to examine it.
We reserve the right to consider certain sites or sub-sites to be ineligible for any bounty or disclosure rewards.
It is important that we respond quickly and effectively, however, we take steps to manage spam to quickly identify relevant email and therefore quality submissions. We discourage and will not respond to:
– Reports of generic vulnerabilities with no evidence of relevance to our systems;
– Denial-of-Service attacks (DoS);
– Reports of any information already in the public domain;
– Reports that are vague or non-actionable.
We will respond quickly and gratefully if we believe that you are faithfully reporting an issue inline with these terms and in the best interests of Global and its customers.

Safe Harbour

Any activities conducted in a manner consistent with this policy will be considered authorised conduct and we will not initiate legal action against you. If legal action is initiated by a third party against you in connection with activities conducted in good faith and in accordance with this policy, we will take steps to make it known that your actions were conducted in compliance with this policy.

Confidentiality

You must treat all information about our systems, staff or customers that comes into your possession or that you otherwise become aware of, which is not publicly available, as strictly confidential. You must not share or otherwise use it for any purpose other than emailing it to us as a submission as described above.

Invoicing Requirements

Once we have agreed to pay a reward you and sent you a purchase order you will be required to submit an invoice containing the following details:
– Your full name
– Your address
– Email
– Billed to: [Address]
– Invoice date
– the Purchase Order number provided in the format PO-00*****
– Full bank details including IBAN/SWIFT/BIC/Account Number (whichever is relevant for the country)
– Bank name
– Full Bank address
– Your registered bank account name – this must match the invoice name
– a description of work undertaken
– the value as set out in the Purchase Order.
We cannot make a payment unless all the above details are included in the invoice.
We will make commercially reasonable efforts to make payment to the bank account set out in a valid invoice.  We will not make payments where the bank account holder’s name does not match the name you give on the invoice. If you are under 18 we will make a payment to your parent or legal guardian’s account.
We cannot make, and shall not be responsible for making a payment to you if:
– you are an individual subject to US, UK or EU sanctions;
– you reside in, or your bank account is located in, a jurisdiction subject to US, UK or EU sanctions; or
– payment is refused by our bank or your bank due to any other legal, governmental or regulatory restriction.
If our first attempt to pay you fails you may resubmit your invoice in accordance with the above requirements with alternative bank account details and we will reattempt the payment. If the payment fails to the alternative bank account we shall not re-attempt payment and you shall not receive the reward.  Please therefore ensure your bank account is able to receive payments from UK banks.
This policy exists entirely at our discretion and may be modified or cancelled at any time.
Thank you for helping keep Global and our users safe!

Added in https://github.com/disclose/diodb/commit/0ccf0e4560bedbf3ca17a8c1760293426a683376. Thank you!


Add support to build macOS & Windows on Azure DevOps

@karianna this patch was created in December/January. I was talking to @llxia and they are working on integration with AzDO (please correct me if I am wrong) and need to fix #1306. So here is just a something they can take a look (I think this script also need some fix), maybe use this instead of #1306. I will change this PR to draft.

@karianna this patch was created in December/January. I was talking to @llxia and they are working on integration with AzDO (please correct me if I am wrong) and need to fix #1306. So here is just a something they can take a look (I think this script also need some fix), maybe use this instead of #1306. I will change this PR to draft.

OK, makes sense, can you check with @llxia and then close #1306 as a duplicate?

Sorry, I missed the above message.
Thanks @junyzheng I can run it in my AzDO
https://github.com/AdoptOpenJDK/openjdk-build/pull/1306 contains tests portion. Will it be added in another PR?

@junyzheng if you can get the build part delivered, I can work on the test part. As we have smart parallelization enabled in tests, we can use this feature to leverage AzDO machines. Thanks

@llxia sorry just saw this. would yo mind to tell me what the JDK I should support? I guess tip, 11, and 8?

Lan is away for remainder of today, so I will answer yes, tip, 8 and 11 would be great!  thanks @junyzheng !

OK, I will work on this next week!

@karianna @smlambert @llxia ready to be reviewed again, sample build: https://dev.azure.com/zjunyuan/junyuanz/_build the failures are caused by I don't have AzDO billing set up for my personal account, so it can't upload to Artifacts

Thanks @junyzheng

Thanks @junyzheng ! @karianna did your comments get fully addressed? I will leave it to your final approval for merge.
Note: This PR opens the way for @llxia to add the smart parallelization testing. :)

John and I are humming and hahing about this. The PR is good but it opens up a philosophical point.  Many of the variables and versions references in here are 'duplicates' of our main build scripts, which means.... refactor time?  Not sure yet, I'll chat with John further this week

@karianna I am not sure how Adopt is planing to use this script. If they can set environment variables through by using Jenkins then I can simplify those YAML file.

@junyzheng - Can you address the comments and push the latest?

@karianna ready to be reviewed again: https://dev.azure.com/zjunyuan/junyuanz/_build


Ignore missing dependency if there is an explicit ordering

For some use-cases there are cyclic dependencies with respect to input
and output location of tasks. For example the spotless apply task depends
on the output of the spotless analyze task, but also modifies the inputs
(the sources) of the spotless analyze task. We don't have a better solution
for this use-case, yet, so we don't want to emit a deprecation warning.
So as long as there is an order relation in any direction, we do not emit
a warning about missing dependencies between tasks.
See #15616.

@bot-gradle test this

@bot-gradle test this

OK, I've already triggered ReadyForMerge build for you.

OK, I've already triggered ReadyForMerge build for you.


feat: add filter to swap

📝 Description
Add filters to swap
❓ Context

Impacted projects:

LLD

Linked resource(s):

[swap] As a user on desktop, I want to be able to filter Centralised vs Decentralised providers https://ledgerhq.atlassian.net/browse/LIVE-3730
[swap] As a user on desktop, I want to be able to filter floating vs fixed rates quotes https://ledgerhq.atlassian.net/browse/LIVE-3785

✅ Checklist

[ ] Test coverage
[ ] Atomic delivery
[ ] No breaking changes

📸 Demo

🚀 Expectations to reach
Please make sure you follow these Important Steps.
Pull Requests must pass the CI and be internally validated in order to be merged.

is there a way to test these new screens states? with mocks?

These test are skipped. @ggilchrist-ledger has another jira to update these tests.

The 'no results found' doesn't look right @sarneijim

This should be 'Floating' rate @sarneijim

Also I found a funky bug @sarneijim:

Generate a quote
Remove the quote
Exchange is still clickable for a number of seconds (it eventually becomes unclickable)

You can then cause a crash from this point if you continue with the nano
https://user-images.githubusercontent.com/87659842/193594542-067b462f-d4dd-4992-aedf-a74d6a6567eb.mov

LGTM! @sarneijim


Structure View ehancements

This is an attempt to populate the structure view with more info.
Changes:

removed "local" and "local function" from local vars/functions (there is enough information displayed that these annotations aren't needed)
when multiple local vars are defined on one line (e.g. local foo, bar, baz = ...), they still appear on their lines in the structure view
Method definitions are nested (e.g. assume methods Obj:foo(), Obj:bar(), Obj.baz(), then it will appear in the view as Obj with 3 children:

Obj

foo()
bar()
baz()

Deeper nesting is handled, e.g. Obj.Foo.Bar:baz() shows up as:

Obj

Foo

Bar

baz()

In situations where the middle references (e.g. Foo and Bar in Obj.Foo.Bar:baz()) don't have any other children., they get collapsed.  So, Obj.Foo.Bar.baz() actually shows up as:

Obj.Foo.Bar

baz()

recognizes local vars that are used as objects, e.g.

local Obj = {}
function Obj:bar()

displays as

Obj

bar()
(clicking on Obj will bring you to the declaration of Obj, clicking on bar() will bring you to the declaration of bar())

I recognize that the classes need to be split out into separate files, etc -- I kept it like this just so that you can comment and let me know if you're interested in my continuing with this effort.

:+1:  Wow, good job!
But there is no nested structure shows, are you miss somthing to commit?

Thanks a lot.

Yes, I missed simple function declarations (as opposed to method declarations).  I'll fix that.  I also want to add recognizing functions defined in tables (as long as the table is assigned to a variable).  e.g.
local SomObj = {
a = function (self) end,
b = function (self) end
}
I'll make those changes and update the pull request

Pushed the change to detect/handle
function Foo:bar() end
function Foo.bar() end

outside of function bodies.  Now working on handling assignment scenarios, e.g.
Foo.bar = function () end

The solution to that will also give us
Foo = {
   bar = function () end
}

Questions:

Would you like function-scope locals to be listed as children of their functions?
How would you like anonymous functions to be handled?  Ignored for now?  Or listed with a tag like ?

It runs ok.
I think we can provide toggle button for user to show or hide those elements that you said


Russ community updates vertices

450 is current and 423 is outdated https://github.com/algorand/docs/pull/423

replaced with https://github.com/algorand/docs/pull/459


Added support for SkiffOS

https://github.com/skiffos/skiffos
Fixes #1657

LGTM!

Thanks again.


Pause feature

we have the pause feature for the different functions: mint , swap, redeem. I think we should remove the pause feature for the redeem functions to make it more safe for the user.
@zjb0807 What do you think ?

I don't think so. When the pool is injected, it is best to suspend all functions to reduce losses. There is no guarantee that redeem is safe

for the user how holds tapETHs , he should be able to redeem his tokens at any time, otherwise the protocol is not safe for the user.

Upgradeable contracts are also unsafe for users. We want to keep the protocol as secure as possible. If a hacker redeems the user's assets, it is not safe too.


Connection lost

The problem
I keep getting this error in the logg and it loses connection to the charger even though it shows the states as available.
Sometimes it will show the charger as off even though it is on and the power sensor is showing power usage...
What is causing this?
Version of Easee integration having the issue?
0.9.50
Version of Home Assistant Core having the issue?
2023.4.6
Anything in the logs that might be useful for us?
This error originated from a custom integration.

Logger: homeassistant.helpers.entity
Source: custom_components/easee/const.py:397
Integration: easee (documentation, issues)
First occurred: 10:53:30 (256 occurrences)
Last logged: 10:54:26

Update for sensor.[xxx]_equalizer_limit fails
Traceback (most recent call last):
  File "/usr/src/homeassistant/homeassistant/helpers/entity.py", line 550, in async_update_ha_state
    await self.async_device_update()
  File "/usr/src/homeassistant/homeassistant/helpers/entity.py", line 755, in async_device_update
    raise exc
  File "/config/custom_components/easee/entity.py", line 260, in async_update
    self._state = self._state_func(self.data.state)
  File "/config/custom_components/easee/const.py", line 397, in <lambda>
    state["eqAvailableCurrentP1"],
  File "/usr/local/lib/python3.10/site-packages/pyeasee/utils.py", line 55, in __getitem__
    if type(self._storage[key]) == str and validate_iso8601(self._storage[key]):
KeyError: 'eqAvailableCurrentP1'

Additional information
No response

Seems like some data is missing, which causes the integration to fail...
Do you have an equalizer in your setup?
I guess we need to look in to solving this issue that missing data causes so much problems, this should be handled better...

This PR should remove the error message from the log at least.
https://github.com/fondberg/easee_hass/pull/322

Please test the latest release and let us know if it solves your problems.

No, I don't have an Equalizer, as that stuff is handled by tibber.
Yeah, running latest HA and easee, but still get the error...
I guess that as I don't use an Easee Equalizer, it is trying to pull data where there is none...
I just disabled that specific equalizer sensor now to not get the error.

Did you test with the latest version that v0.9.52 that we released about 1 hour ago?

No, sorry, I just got the update notification.
Let me check.

Yes, it seems to have fixed the issue.
Still not getting any data from the equalizer sensor but I guess it is because of missing service, which is expected.

Yes, there is nothing we can do about that data is missing, but at least avoid having log cluttered with errors...
Thanks for verifying.