Fix issue where minor update to conda-based installation via conda breaks the application

The current conda-based installer builds a Spyder conda package from a modified feedstock to accommodate creating the application shortcut with menuinst. When updating the conda-based installer using conda install, a Spyder conda package built from the standard feedstock is retrieved and clobbers the Menu directory resulting in a broken application.
Proposal

The installer will create an empty file and is_conda_based_app will check for this file to determine whether Spyder is a conda-based app. This ensures the distinction even if a standard conda package installs spyder-menu.json. This step can be done immediately without consequence.
The standard feedstock will be updated with the spyder-menu.json that is currently used in the installer builds. This should not affect standard conda installations.
After the standard feedstock is updated, the installer build will no longer need to patch it.

This proposal means that all Spyder conda packages (on feedstock dev branch) will include the spyder-menu.json and will be safe to install in both standard conda environments as well as our conda-based installer runtime environments. It also guarantees correct distinction of a conda-based application environment because it will rely on a feature that only the installer creates.

[ ] #21646
[x] conda-forge/spyder-feedstock#154
[ ] #21647

@ccordoba12 @dalthviz @jaimergp,
I discovered that for conda>=23.11.0, menuinst>=2.0 is also installed. Because the update to Spyder's feedstock now includes the updated menu file, this means that an end user will automatically create an application shortcut/bundle upon installing Spyder in any conda environment. This may not be what we want.
I have some ideas about how to fix this, but I think we should first decide exactly what UX we want, i.e. under which circumstances an application shortcut/bundle should be created.

Created only for our installer environment, and done so automatically.
Can be created for any environment: automatically for our installer environment, but deliberate action(s) are required by the user for a standard conda environment.
Created automatically for any environment.

I assume we prefer the first option (my preference). Thoughts?

What we did for napari was to ship the menu file in a different output (napari-menu) that depends on napari. Then, the "opt-in" action is via adding that optional package to your environment. We opt everyone in in the installers by adding napari-menu to the list. Would that work for your use case?

What we did for napari was to ship the menu file in a different output (napari-menu) that depends on napari. Then, the "opt-in" action is via adding that optional package to your environment. We opt everyone in in the installers by adding napari-menu to the list. Would that work for your use case?

This is exactly what I had in mind, or some variation of it, inspired by napari.
The PRs listed in the OP would result in UX option 3. I'm confident that we don't want this option, so the choice is really between UX option 1 and 2.
Imitating napari would result in UX option 2. Publishing a spyder-menu package to conda-forge simultaneously with spyder would make it easiest for a user to opt in to creating the application shortcut/bundle. Alternatively, if we want to discourage shortcuts/bundles outside of our installer environment, we could publish a spyder-menu package to a separate label (e.g. conda/label/spyder_menu) in order to make it harder for a user to opt in for an arbitrary conda environment.
For UX option 1, we would only create a spyder-menu package locally at installer build time, include it in the installer, but not publish it to conda-forge. This would effectively reserve the shortcut/bundle for our installer environment and prevent users from creating it in an arbitrary environment.
There are a few reasons why we may consider UX option 1.

One of the principle reasons for creating our installer is to steer users toward an isolated runtime environment for Spyder; UX option 2 may undermine that effort.[1]
Having a single shortcut/bundle would be less confusing to users (particularly new users). Multiple shortcuts/bundles for the same application requires name mangling (e.g. Spyder-ver-env.app) which is not a common practice. Are there UX standards/guidelines that say anything about this?

[1] The app section of the meta.yaml file for building the conda package can take the option own_environment: True (see here). This should result in Spyder being installed into its own environment when installed through Anaconda Navigator. This could be a good compliment to our installer.

this means that an end user will automatically create an application shortcut/bundle upon installing Spyder in any conda environment. This may not be what we want.

Why not? That would improve how Spyder works on Mac and Linux when installed in conda envs. Furthermore, that's how Spyder has been working on Windows for a long time, so we need to preserve that.

I think we should first decide exactly what UX we want, i.e. under which circumstances an application shortcut/bundle should be created

Is it possible to add the shortcut to a different folder than the default Anaconda one on Windows? Besides doing that, I think we should rename it to Spyder (application) to distinguish it from the env shortcuts.

this means that an end user will automatically create an application shortcut/bundle upon installing Spyder in any conda environment. This may not be what we want.

Why not? That would improve how Spyder works on Mac and Linux when installed in conda envs. Furthermore, that's how Spyder has been working on Windows for a long time, so we need to preserve that.

I agree that automatically creating the shortcut will make a more desirable UX for standard conda environments; I just wonder if that will discourage adopting our installers which ensure that Spyder has an isolated runtime environment. I did not realize that menuinst was installed into base environments by default on Windows; this is currently not the case for macOS and Linux. Although given the update to menuinst, it may be included in base environments by default in the future. I'm not necessarily opposed to it, but I think we should decide whether or not to automatically create a shortcut in any environment because it is the best UX, not just because we've been doing it on Windows for a long time.

Is it possible to add the shortcut to a different folder than the default Anaconda one on Windows?

I don't think so. The shortcut location is placed in the standard location for each platform.

Besides doing that, I think we should rename it to Spyder (application) to distinguish it from the env shortcuts.

This, of course, is not necessary if we reserve the shortcut for just our installer. However, if the shortcut is created automatically for any environment, then we will need to settle on a general and scalable naming scheme using environment variables available to menuinst at package creation time and/or at package install time. (See https://conda.github.io/menuinst/reference/#general-placeholders).
The only relevant parameters that I can see would be the PKG_VERSION at build time and the ENV_NAME at install time, e.g. Spyder-__PKG_VERSION__-{{ ENV_NAME }}. For our installer this would result in Spyder-6.0.0-spyder-runtime. Personally, I think this is undesirable for our installers, but acceptable for shortcuts to standard conda environments.
I would propose that we reserve Spyder as the shortcut name for the one created from our installer environment, and use Spyder-<ver>-<env name> for standard environments. I think we could accomplish this with a post-link script in Spyder's conda package. This script  would modify spyder-menu.json appropriately after the package is installed, but before menuinst is executed, and only for our installer environment.


Flex: Fix number of suggestion buttons

6 suggestion buttons did not allow to select specific words from BIP39
(cherry picked from commit 341e79c5c31516219aaf9324c2156958c99bf76d)
Description
Please provide a detailed description of what was done in this PR.
(And mention any links to an issue docs)
Changes include

[x] Bugfix (non-breaking change that solves an issue)
[ ] New feature (non-breaking change that adds functionality)
[ ] Breaking change (change that is not backwards-compatible and/or changes current functionality)
[ ] Tests
[ ] Documentation
[ ] Other (for changes that might not fit in any category)

Breaking changes
Please complete this section if any breaking changes have been made, otherwise delete it.
Additional comments
Please post additional comments in this section if you have them, otherwise delete it.

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 60.20%. Comparing base (603cf09) to head (11f4a06).
Report is 16 commits behind head on API_LEVEL_21.

Additional details and impacted files
@@               Coverage Diff                @@
##           API_LEVEL_21     #736      +/-   ##
================================================
+ Coverage         60.19%   60.20%   +0.01%
================================================
  Files                12       12
  Lines              1726     1729       +3
================================================
+ Hits               1039     1041       +2
- Misses              687      688       +1

Flag
Coverage Δ

unittests
60.20% <ø> (+0.01%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


change in device initialization behavior

There appears to be an unintended behavioral difference resulting from merging #24873: in the past some attempts to retrieve the device pointer for a device that had not yet been initialized succeeded, while they now fail.
The case is demonstrated for tests/drivers/eeprom on native_posix.  The I2C device initializes at POST_KERNEL with priority CONFIG_I2C_INIT_PRIORITY=60, while the EEPROM initializes at POST_KERNEL with priority CONFIG_KERNEL_INIT_PRIORITY_DEVICE=50.  After the merge the attempt by the EEPROM init function to retrieve its parent bus fails because the returned pointer is null as the I2C controller has not yet been initialized.  (The EEPROM driver does not use the I2C bus during initialization.)
I don't think this ever should have worked, and a fix will be to correct the init priorities in this specific case, but it suggests that this will occur in other cases and may be difficult to detect.

@tbursztyka @carlescufi @nashif for awareness.

@MaureenHelm @pabigot should we try and fix those before 2.4 is released?

Triage: Ensure this change is documented in the release notes.  Proposal was to also __ASSERT() if device_get_binding() is invoked before the device had been initialized, however the device initialization state is a boolean that cannot distinguish "not yet initialized" from "initialization failed", so we can't do that.
Formerly it was a functionally boolean that could not distinguish "not yet initialized" from "initialization succeeded", but that's a more dangerous confusion.

Ropened due to heightened concern about the impact of the change in behavior.

Since we keep playing whack-a-mole with this, and some of the solutions (e.g. #28339) have their own weaknesses, I've pushed #28369 as a potential solution for 2.4.
I think we should spend some 2.5 development effort on maintaining device state with higher fidelity.  We should be able to get a handle for a device before it's been initialized, to break dependency loops.  We should be able to delay initializing (probe() in Linux-speak) a device until it's going to be used (relates to #19448).  We should be able to shutdown and restart devices, potentially as part of device power management (also relates to #19448).
All of this is IMO appropriate to be part of device power management.

@pabigot I was going to propose the same thing, let's keep the old behavior in 2.4, and revert for 2.5 in order to fix found priority issues.


Explicitily test a case where ln gateway checks a contract status and gets "pending preimage"

This going wrong leads to hard to debug flaky failures and got broken second time in a row, as it's timing dependent.

@okjodom @jkitman

Looks like the changes you made to await_preimage_decryption should work, but is it timing out or something?

00:01:56 fedimint-test-latency> 2023-03-14T20:26:20.784152Z  WARN buy_preimage_from_federation_await_decryption{out_point=OutPoint { txid: 65cca7f04e57154594504fa6a3d368a7b3fa6eaacf3a3c2b99c7bf2a25e49043, out_idx: 0 } contract_id=8aa0a6a4ae3029a00a6577063fef03e7c3b080d25dfad95aebc3c653aa147132}: ln_gateway::actor: Failed to decrypt preimage. Now requesting a refund error=Output outcome error: Transaction rejected: TransactionReplayError(65cca7f04e57154594504fa6a3d368a7b3fa6eaacf3a3c2b99c7bf2a25e49043)

We have a variation of this test in LNv2 (where the decryption fails client side). Don't think its worth spending more time on it for LNv1.


ChanPool 如果消费超过chan长度的数据，在push是不应该永久阻塞，应该被丢弃

Codecov Report

Merging #2 into master will increase coverage by 0.02%.
The diff coverage is 100%.

@@            Coverage Diff            @@
##           master      #2      +/-   ##
=========================================
+ Coverage   98.37%   98.4%   +0.02%
=========================================
  Files           5       5
  Lines         185     188       +3
=========================================
+ Hits          182     185       +3
  Misses          3       3

Impacted Files
Coverage Δ

chan_pool.go
100% <100%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7c6981b...c5c2c5a. Read the comment docs.


How to use helper in sails with handlebars?

I read this post  http://tilomitra.com/sailsjs-with-handlebars/  ,but I don't know how to add Helpers support.

I'm using the technique described above, but am receiving the following error:
message: "Missing helper: "eq"",
name: "Error"
}```

I'm not sure if the double quote after "eq" is indicative of an error in the package.

Desired use:

```{{#eq val1 "val2"}}text{{/eq}```

How to do this in v0.11.0 . I think I cant directly define helper in a config file in this version . They need to go inside a function which can be exported using module.exports.

@stewhouston - Were you able to get this working ?

@pawanrawal - Pardon the late reply, my project was shelved for quite some time. I did not get registerHelper working as referenced above, but did get an inline/ad hoc res.view locals.helpers method to work. However it's undesirable to attach a reusable template method inside a controller.
I've been away from Sails for a bit, so if you did get this working it would still be of interest.

Just grabbing this up. Is there any solution? I have defined a math helper in config/helpers.js and try to use it in a partial template.
Console output:
error: Sending 500 ("Server Error") response:  Error: Missing helper: "math"     at Object.<anonymous> (/usr/local/lib/node_modules/sails/node_modules/handlebars/dist/cjs/handlebars/helpers/helper-missing.js:19:13)     at Object.eval (eval at createFunctionContext (/usr/local/lib/node_modules/sails/node_modules/handlebars/dist/cjs/handlebars/compiler/javascript-compiler.js:254:23), <anonymous>:18:66)     at main (/usr/local/lib/node_modules/sails/node_modules/handlebars/dist/cjs/handlebars/runtime.js:173:32)     at ret (/usr/local/lib/node_modules/sails/node_modules/handlebars/dist/cjs/handlebars/runtime.js:176:12)     at ret (/usr/local/lib/node_modules/sails/node_modules/handlebars/dist/cjs/handlebars/compiler/compiler.js:525:21)     at ExpressHandlebars._renderTemplate (/usr/local/lib/node_modules/sails/node_modules/express-handlebars/lib/express-handlebars.js:247:12)     at ExpressHandlebars.<anonymous> (/usr/local/lib/node_modules/sails/node_modules/express-handlebars/lib/express-handlebars.js:173:21) { [Error: Missing helper: "math"]   description: undefined,   fileName: undefined,   lineNumber: undefined,   message: 'Missing helper: "math"',   name: 'Error',   number: undefined }

The problem depends which node (actually which npm version you use). Starting with node >= 5, npmv3 gets shipped with it, which calculates a flat node_modules hierarchy out of you dependency tree and only installs nested node_modules if necessary.
Anyway... If you are using node >= 5 it should work when you use require('handlebars') but if you use node < 5 (e.g. v4.x) you have to require the handlebars module, sails uses for rendering your views, otherwise you would register the helper correctly, but on the wrong Handlebar module and the helper can not be found.
So:
node < 5 (e.g. v4.x):
var Handlebars = require('sails/node_modules/express-handlebars/node_modules/handlebars')
Handlebars.registerHelper('foo', function() { return 'foo' })

node >= 5:
var Handlebars = require('handlebars')
Handlebars.registerHelper('foo', function() { return 'foo' })

I put that directly on top of the config/views.js, but it should work in any config file, also in config/helpers.js

I'm using node v5.0.0.
var Handlebars = require('handlebars'); returns the correct object and I can add my math helper function. That's not the problem...
The problem is, that I can't use my defined math helper in a partial template like in the example of @shanelau

I'm having issues with helpers: require('./helpers') in my config/views.js.  When I run sails lift I get Cannot find module './helpers'. Any thoughts?

@liamanderson You need create a new file helpers.js in your project

FYI, you should always install handlebars directly into your project rather than trying to require the copy from inside Sails.

@Crease29 if you're having a separate problem, please create a new issue and we'll check it out!

Hi i was facing the same issue here. so i took a look to the source file layoutshim.js
It is using sails.config.views.helpers to initialize the helpers object on express-handlebars.
     // Use express-handlebars for handlebars templates, and set up layout functionality
      else if (engineName === 'handlebars') {
        var exphbs = require('express-handlebars');
        sails.log.verbose('Overriding handlebars engine with express-handlebars to implement layout support...');
        var hbs = exphbs.create({
          defaultLayout: path.join('..', (sails.config.views.layout + '.' + (extension || 'handlebars')) || ''),
          helpers: sails.config.views.helpers || {},
          partialsDir: path.join('views', sails.config.views.partials || ''),
          extname: extension || 'handlebars'
        });

        sails.config.views.engine.fn = hbs.engine;

So you dont need to require handlebars or registerHelper just make an object with your helper methods.
//config\helpers.js
module.exports = {
    foo: function () {
        return 'FOO!';
    },

    bar: function () {
        return 'BAR!';
    }
}

and set your sails.config.views.helpers to that object using require:
//config\views.js
  engine: 'handlebars',
  extension: 'hbs', // if you want to use .hbs extensions
  helpers: require("./helpers"),


Default FilePathsTransformation

FilePathsTransformation has to be a default and first in the list of transformations otherwise transformations fail.

Fixed #3 and #5


Cannot Open Camera

The app starts and immediately says cannot open camera. I have allowed permissions for camera and I have set the cameras to "webcam0". Any ideas? Thanks

Resolved issue - settings for AVD ;
front - virtual scene
back - webcam0


please support passing in a Publisher<T> to the assemble method instead of a synchronous Iterable<T>.

I would like to use Assembler to stream the results and aggregate the details as the results are returning.

Linking to #10 as this issue seems to be closely related. Thanks a lot Josh for the feedback, the issue you raised is interpreted as a strong indication that there is an actual demand for this particular feature and the assembler library as a whole, so this will be put at the top of the priority list

I want to make sure that got this feature request right, currently the library supports processing of reactive streams in a non-blocking way (minus issue #10 ), possibly infinite stream, here is an example https://github.com/pellse/assembler#flux
Flux<Transaction> transactionFlux = getCustomerFlux()  // something that returns a Flux<Customer>
    .bufferTimeout(10, ofSeconds(5)) // every 5 seconds or max of 10 customers, returns Flux<List<Customer>>
    .flatMap(assembler::assemble) // flatMap(customerList -> assembler.assemble(customerList)))

Another scenario (not your use case though from my understanding) could be to fully drain the Flux (when we know in advance it's a finite stream e.g. a list of parameters passed as a Flux in a REST call handled by Spring WebFlux)
Flux<Transaction> toTransaction(@RequestBody Flux<Customer> customerFlux) {
    return customerFlux
        .collectList()
        .flatMapMany(assembler::assemble)
}

By design, the assemble method needs to consume every element from the upstream (or batches of elements from the upstream) to retrieve in one shot all the correlation ids (or primary keys) needed to be used by downstream sub-query requests (those not being fully reactive yet, see #10 ) to allow a single call per sub-query passing the full list of ids (vs. one call per id) i.e. batching (or buffering) the aggregation process instead of doing it on a per element basis to avoid the N + 1 query problem. The management/configuration of those batches was deliberately left outside of the Assembler as shown in the code snippet above, using an Iterable<T> here was to make it explicit that this is a finite list, while keeping the reactive behavior when used within a scenario where we reactively split a stream into chunks (using Flux.bufferXXX methods)
Passing a Publisher<T> to the assembler method could be done, but in the scenario where the Publisher<T> is an infinite stream, the Assembler library would have to internally handle the buffering to limit the number of elements to read from the upstream before collecting ids from those elements to trigger sub-query calls on downstreams.
Let me know if this covers the use case you had in mind (issue #10 would still need to be implemented though, independently of this ticket). The other option I see is that you might have meant using the Assembler to process/aggregate on a per element basis (no buffering) i.e. not something to be used as a solution to the N + 1 query problem, but more of a nice layer on top of the reactive stream combiner operators (e.g. Flux.zip, Flux.combineLatest, etc.). If that is the case, this is anyway something I was considering doing at some point, pass a Publisher<T> to the assemble method no matter what, but have a way to pass a config to specify if each element of the stream represented by that Publisher<T> should be handled on a per element basis or if the entire stream of elements from the Publisher should be consumed to implement batching of sub-queries.

Your great suggestion is now implemented, the internal logic of the Assembler was rewritten with Project Reactor, the details are on the main page of the project https://github.com/pellse/assembler. Replacing assembler-flux dependency with reactive-assembler-core dependency in Java/Kotlin projects will allow passing in a Publisher<T> everywhere


README changes; add pictures

The merge button worked...

@comonoidial Yep! I've added you as a collaborator, which means you can now merge (and be assigned on) pull requests.


MFTEnumEx memory management confusion

I'm having trouble with the MFTEnumEx function. It's documentation says that I'm supposed to call Release on each of the returned IMFActivate pointers, which as far as I could tell is a Drop impl on ::windows::core::IUnknown (there are no methods to call explicitly like in C++).
I was a bit confused getting this to compile at all, in particular the maybe_activate line; there's some stuff going on with references that I don't fully understand, but just dereferencing the pointer without borowing resulted in a move which didn't compile because Option<IMFActivate> does not implement Copy.
As you can see I'm calling drop on whatever I get out of the array, though I suspect this is incorrect.  So I guess I'm freeing the reference (a no-op) instead of the IMFActivate object that I'm supposed to free.
Can anyone explain how to use this function correctly?
use windows::Win32::{Media::MediaFoundation::{
    IMFActivate, MFShutdown, MFStartup, MFTEnumEx, MFSTARTUP_NOSOCKET, MFT_CATEGORY_VIDEO_ENCODER,
    MFT_ENUM_FLAG_HARDWARE, MF_API_VERSION, MF_SDK_VERSION,
}, System::Com::CoTaskMemFree};

fn main() -> windows::core::Result<()> {
    let mf_version = (MF_SDK_VERSION << 16) | MF_API_VERSION;
    unsafe {
        let res = MFStartup(mf_version, MFSTARTUP_NOSOCKET);

        if res.is_ok() {
            println!("Media Foundation initialized!");

            let mut tmp: Option<IMFActivate> = None;
            let mut activate_ptrs = &mut tmp as *mut Option<IMFActivate>;
            let mut activate_ptr_count = 0u32;

            let res = MFTEnumEx(
                MFT_CATEGORY_VIDEO_ENCODER,
                MFT_ENUM_FLAG_HARDWARE.0.try_into().unwrap(),
                std::ptr::null(),
                std::ptr::null(),
                &mut activate_ptrs,
                &mut activate_ptr_count,
            );
            if res.is_ok() {
                println!("MFTEnumEx succeeded, {} MFTs returned!", activate_ptr_count);

                //call release on every IMFActivate pointer
                for i in 0..activate_ptr_count {
                    let maybe_activate = &mut *activate_ptrs.add(i as usize);
                    if let Some(activate) = maybe_activate {
                        drop(activate);
                    }
                }

                CoTaskMemFree(activate_ptrs as *const std::ffi::c_void);
                println!("Freed activate_ptrs");
            }

            let res = MFShutdown();
            assert_eq!(res.is_ok(), true);
        } else {
            println!("{:?}", res.err());
        }
    }

    Ok(())
}

I need to update to the newest version of the windows crate, but here's how I call it in displayrecorder:
https://github.com/robmikh/displayrecorder/blob/9e9617bea73847c8ff801731c7bd6ee32edf919b/src/media.rs#L20-L57

I need to update to the newest version of the windows crate, but here's how I call it in displayrecorder:
https://github.com/robmikh/displayrecorder/blob/9e9617bea73847c8ff801731c7bd6ee32edf919b/src/media.rs#L20-L57

This is helpful, thank you!
I didn't think about using transmute because I've mostly done safe Rust so far (and because of the big scary warnings in the doc); is this the recommended way of dealing with out pointers to COM interfaces?

No problem!
In this case, where you're getting a list back that's allocated by the function, transmute would be what I recommend. There shouldn't be null entries in that list and you know how long it's supposed to be, which makes it great for a slice.
Generally, sticking with the Option and unwrapping it is what I go with for COM out pointers (e.g. ID3D11Device::GetImmediateContext).

So I have copied the code from your repo (without lines 47-48), but something seems off still; when debugging I never end up in IUnknown's Drop impl because iterating over the slice gives me shared references to IMFActivate, which don't seem to actually call Release on the underlying COM object.
I've tried with VSCode and WinDbg, and with the latter I expected to end up in some Windows DLL where the COM object's Release method is implemented, which did not happen. The stack frame's name in WinDbg is mfrust!core::mem::drop<ref$<windows::Windows::Win32::Media::MediaFoundation::IMFActivate>> which implies I'm dropping the ref, not the object behind it.
Code looks like this now:
if res.is_ok() {
            println!("MFTEnumEx succeeded, {} MFTs returned!", num_mfactivate);

            //call release on every IMFActivate pointer
            let mfactivate_list: *mut IMFActivate = std::mem::transmute(mfactivate_list);
            let mfactivate_slice =
                std::slice::from_raw_parts(mfactivate_list, num_mfactivate as usize);
            for mfactivate in mfactivate_slice {
                    // We need to release each item
                    std::mem::drop(mfactivate);
            }

            CoTaskMemFree(mfactivate_list as *const std::ffi::c_void);
            println!("Freed activate ptrs");
}

Is this a bug or am I misunderstanding how Drop is supposed to work?

No, it looks like you've got it right. Thanks for catching this.
This is the only way I could think of to fix it:
unsafe {
    // If we have more than one IMFActivate in the list,
    // we can transmute it out of the Option<_>
    let mfactivate_list: *mut IMFActivate = std::mem::transmute(mfactivate_list);
    let mfactivate_slice =
        std::slice::from_raw_parts(mfactivate_list, num_mfactivate as usize);
    for mfactivate in mfactivate_slice {
        let transform_source = mfactivate.clone();
        // This is a dirty trick we play so that we can
        // release the underlying IMFActivate despite having
        // a shared reference.
        let temp: windows::core::IUnknown = std::mem::transmute_copy(&transform_source.0);
        transform_sources.push(transform_source);
        // We need to release each item
        std::mem::drop(temp)
    }
    // Free the memory that was allocated for the list
    CoTaskMemFree(mfactivate_list as *const _);
}

If you create a Vec instead of a slice, it seems to drop the items but then you can't pass the list to CoTaskMemFree. @kennykerr, do you know of a better way of handling this case?

Yeah, this is a difficult API to call properly. It probably needs a little help.
use windows::{core::*, Win32::Media::MediaFoundation::*, Win32::System::Com::*};

fn main() -> Result<()> {
    unsafe {
        let mut data = std::ptr::null_mut();
        let mut len = 0;
        MFTEnumEx(
            MFT_CATEGORY_VIDEO_ENCODER,
            MFT_ENUM_FLAG_HARDWARE.0 as _,
            std::ptr::null(),
            std::ptr::null(),
            &mut data,
            &mut len,
        )?;
        let array = ComArray::<IMFActivate>::from_raw(data as _, len);
        for i in array.as_slice() {
            println!("{}", i.GetCount()?);
        }
        Ok(())
    }
}

struct ComArray<T: Interface> {
    data: *mut T,
    len: u32,
}

impl<T: Interface> ComArray<T> {
    pub unsafe fn from_raw(data: *mut T, len: u32) -> Self {
        Self { data, len }
    }
    pub fn is_empty(&self) -> bool {
        self.len == 0
    }
    pub fn as_slice(&self) -> &[T] {
        if self.is_empty() {
            return &[];
        }

        unsafe { std::slice::from_raw_parts(self.data, self.len as usize) }
    }
}

impl<T: Interface> Drop for ComArray<T> {
    fn drop(&mut self) {
        if self.is_empty() {
            return;
        }

        unsafe {
            std::ptr::drop_in_place(std::slice::from_raw_parts_mut(self.data, self.len as usize));
            CoTaskMemFree(self.data as _);
        }
    }
}

A bit more work up front but then you know it's taken care of.

There's also windows::core::Array which is also backed by the same allocator. We could potentially generalize Array<T> to cover such APIs as well.

Thanks a lot for the help. :)

Just a quick update. With #2362 you can use the windows::core::Array type to greatly simplify this. For example:
use windows::{core::*, Win32::Media::MediaFoundation::*};

fn main() -> Result<()> {
    unsafe {
        let mut data = std::ptr::null_mut();
        let mut len = 0;
        MFTEnumEx(
            MFT_CATEGORY_VIDEO_ENCODER,
            MFT_ENUM_FLAG_HARDWARE,
            None,
            None,
            &mut data,
            &mut len,
        )?;
        let array = Array::<IMFActivate>::from_raw_parts(data as _, len);
        for i in array.as_slice() {
            println!("{}", i.as_ref().unwrap().GetCount()?);
        }
        Ok(())
    }
}


Array not closed correctly in parse method

When I run the parse method on the following:
{
   "weekly":{
      "active":true,
      "count":1,
      "weekdays":[0,1]
   },
   "monthly":{
      "active":false,
      "day":{
         "active":false,
         "dayCount":1,
         "monthCount":1
      },
      "weekday":{
         "active":false,
         "index":1,
         "weekday":0,
         "monthCount":1
      }
   }
}

Everything from "monthly" and on becomes a third element in the "weekdays"-array, rather than a second object on the same level as "weekly"

Hi.
I'll take a look into this until Sunday.
Thank you.

Hi. I've tested this string with correct escaping in the latest version and it works as expected. Are you running an older version of this script?

<%
jsonString = "{""weekly"":{""active"":true,""count"":1,""weekdays"":[0,1]},""monthly"":{""active"":false,""day"":{""active"":false,""dayCount"":1,""monthCount"":1},""weekday"":{""active"":false,""index"":1,""weekday"":0,""monthCount"":1}}}"

set jsonObj = new JSONobject
set outputObj = jsonObj.parse(jsonString)
%>

Parse Input

<%= jsonString %>

Hi!
I was using version 3.7 at the time of writing
I've updated to the new version 3.8.1, and it seems to work now.
Thanks!


Grader logging updates

High-level list of logging notes about grader & autotest; will be updated as encountered.

[x] If there is any way to decrease the verbosity of logging on the db container it would be great!
[x] Grader should log at Info level, not Trace in production (how we do this on other containers isn't great and we should revisit this more correctly; maybe through the .env?)
[x] grader      | <W> 2018-10-3 18:29:23: GradeTask::execute() - Failed to checkout commit. Requested: c40c9c91bbf7edd69f46f6f786eee35f9e421c77 Actual: c40c9c91bbf7edd69f46f6f786eee35f9e421c77 grader      | . Continuing to grade but results will likelybe wrong. (these SHAs seem to match so the message probably isn't right)
[x]  <T> 2018-10-3 18:31:56: GradeTask::execute() - Start grading container 6a4348 should be info, not trace
[x]  <T> 2018-10-3 18:31:39: GradeTask::execute() - Container f29b9b exited with code 0. should be info, not trace
[x] <T> 2018-10-3 18:31:39: GradeTask::execute() - Remove container undefined is this a bug (undefined) or should it be logged as an error?
[x] <W> 2018-10-2 10:15:13: AutoTest::invokeContainer(..) - ERROR for SHA: acf10243e0ee7cbfe5d54a4f8e09882ef417c2fa; ERROR with grading service: RequestError: Error: ESOCKETTIMEDOUT This is actually in AutoTest, but should be treated more like an info than a warning (and without the ERROR text all over the place)

(feel free to just update these on master so they get deployed along with any other small updates)

Do you want only the Grader to log at INFO? The easy way to do this is to just set LOG_LEVEL=INFO somewhere (could be in the .env for all services, or just in the compose settings for Grader).

For the db we can try setting the --quiet option by setting the entrypoint configuration on the mongo container.

@rtholmes thoughts on https://github.com/ubccpsc/classy/issues/123#issuecomment-427532539? (I'll just merge the first two points to master; last one will probably become its own issue).

I think your idea of doing it in .env for all services is the way to go!

Fixed.


Buy order and sell order price are flipped on the website

See above.
On the website, the numbers for the buy price of items and the sell price are reversed.
See example below:
Website:
https://imgur.com/a/WWZii8M
In-game stats:
https://imgur.com/a/8qc7k8u
As seen with the above imgur links, the current statistics on the website is correct, but their positions are swapped.
Text-based comparison below
item: Frail 6
Website:
Buy price: 7.2 coins
Sell price: 639.1 coins
In-game
Buy price: 639.1 coins
Sell price: 7.2 coins
I'm relatively new to posting issues, so please forgive me if anything seems wrong about this post.
Thanks!

Hi, I've just fired up Minecraft to check this for the first time in about two years, and it does seem you're correct! Only took me 5 minutes to remember where the Bazaar trader is in Skyblock too :)
The API seems to have a "quick_status" element for each item now, which it may not have done when I first wrote this, and it does seem like that data is what's used in the game - the correct way around.
I will get that fixed ASAP... I wonder how long this problem has been around for without anyone noticing!

Having thought about it a bit more, I actually think the current behaviour is correct. If I understand correctly, Bazaar Flipping involves putting in a buy order priced at or above the current highest buy order (which is what appears in your screenshot as the sell instantly price) then putting in a sell offer priced at or below the current lowest sell offer (which is what appears in your screenshot as the buy price). As a Bazaar Flipper, the people using "buy instantly" and "sell instantly" are your "customers"; so the prices are the other way around.
For example, flipping carrots, the equivalent to your screenshot is this:

But to make a profit off the people who buy and sell instantly, I want to put in a buy order at 1.8 or 1.9 so I become top of the list for people looking to sell instantly:

Then I want to put in a sell offer at 2.7 or 2.6 so I'm top of the list for people looking to buy instantly:

Assuming all goes well, this then results in a profit to me - as shown in the calculator.

Hopefully that makes sense - it fries my brain thinking about it :)

Ohhh, ok! I think I understand. Didn't realize the menus were set-up that way. Thanks for checking, though!
And thanks for making such a great site!


U2F registration final redirection

Hi,
In case I want to register a U2F token, I get redirected to /secondfactor/u2f/identity/undefined (giving an error 404) in the end of the registration process.

I cannot reproduce it anymore—I have updated Authelia and my Nginx config, so I do not know which on was faulty. Anyway, it is no longer an issue.

hello @n4kre, this is expected. It was fixed in #194.


tilt: 0.8.8 -> 0.9.2

Motivation for this change
Update tilt to the latest release.

https://github.com/windmilleng/tilt/releases/tag/v0.9.2

Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

@FRidh Thanks for the review!
The commit has been updated and force-pushed.

Builds/executes for me macos 10.13.

Also works for me, but in the mean time 0.9.4 version was release, @xrelkd maybe you can update your PR?

@jlesquembre Thanks for the review, tilt has been updated to 0.9.4
@FRidh The commit has been updated and force-pushed again, could you review it again? Thank you!


What is the purpose of requiring x-codegen-request-body-name?

This is one of the default rules, but I'm not sure what it is or does. From Googling, it looks like a holdover from a swagger generator tool?

This is actually a custom rule specific to our set of tools. One of the primary way this validator is used is to prepare API Definitions for SDK generation (using our internal SDK generator). We require the use of x-codegen-request-body-name because it results in drastically better generated SDKs.
This rule should be configurable, you should be able to turn it off if need be. Are you seeing that isn't the case?


Don't use @dontInfer on GraphQL type definitions

Hi there,
Thanks for the great theme! Since most of your users, probably going to be small sites, using @dontInfer on your GraphQL type definitions is an overkill. Specifically I need to add a field to MDX frontmatter, and type in gatsby-theme-docs-core/gatsby-node.js stops me from doing it. And since Gatsby can't overwrite gatsby-node.js my only option is to fork the theme.
Please resolve this issue. Thanks!

Hey @Dragomir-Ivanov, thanks for pointing this out.
The issue was fixed on #18 🎉

Thanks a ton!


HeadObjectError in S3: no providers in chain provided credentials

It might be worth having CI perform a dev native-link deployment in AWS, and point some builds at it. (nightly?)
To prevent regressions in the AWS deployment.
Deployed native-link on AWS (instructions) at 4cc53bc82286cce57854f6e7c2765f03932ac370 and attempted to point a build at the deployment. Encountered following error:
bazel test //:dummy_test \
    --remote_cache=grpcs://cas.DOMAIN \
    --remote_executor=grpcs://scheduler.DOMAIN \
    --remote_instance_name=main

INFO: Invocation ID: d4859976-5154-434c-91f9-3537d8ef7d40
INFO: Analyzed target //:dummy_test (0 packages loaded, 0 targets configured).
INFO: Found 1 test target...
ERROR: /home/ubuntu/native-link/BUILD.bazel:42:8: Executing genrule //:dummy_test_sh failed: (Exit 34): UNAVAILABLE: Unhandled HeadObjectError in S3: Unhandled { source: DispatchFailure(DispatchFailure { source: ConnectorError { kind: Other(None), source: CredentialsNotLoaded(CredentialsNotLoaded { source: "no providers in chain provided credentials" }), connection: Unknown } }), meta: ErrorMetadata { code: None, message: None, extras: None } }, retries: 7 : Failed to run has() on slow store : Inner store get in compression store failed : Compression underlying store get failed : --- : Received erroneous partial chunk: Error { code: Internal, messages: ["Writer was dropped before EOF was sent"] } : During first buf_channel::take() : Failed to read header in get_part compression store : Failed to get_part in get_part_unchunked : --- : Received erroneous partial chunk: Error { code: Internal, messages: ["Writer was dropped before EOF was sent"] } : Failed to recv first chunk in collect_all_with_size_hint : Failed to read stream to completion in get_part_unchunked
INFO: Elapsed time: 4.626s, Critical Path: 3.88s
INFO: 2 processes: 2 internal.
FAILED: Build did NOT complete successfully
//:dummy_test                                                   FAILED TO BUILD
Executed 0 out of 1 test: 1 fails to build.

@allada @aaronmondal
If you have a minute, any pointers on diagnosing this?
If not I'll just poke around on my own time.

Succeeds at 56eda36661daae5458b2821effcdbcbc9d03b753
bazel test //:dummy_test     --remote_cache=grpcs://cas.DOMAIN     --remote_executor=grpcs://scheduler.DOMAIN     --remote_instance_name=main

Yeah, can you tell us what checkout you are using? It may have been fixed in recent changes.
We have not had time to deep-dive the AWS config again to verify everything, because we are in the process of releasing a GCP variation and a pinned version release.
We will be making more changes to AWS config in the coming months to support rule-based auto-scaling policies, so be on the lookout for those too.

@mhz5 Is this still an issue after #423 ?
Yes this occurs even at #423.
I updated the description to include the deployed commit.
Thanks for taking a look guys, I will dig deeper.
Looking forward to the pinned release!

Hmm I just played around with things and can't reproduce this issue. I can imagine two things going wrong here:
The new s3 implementation enforces HTTPS by default and now requires explicit setting of the insecure_allow_http  flag for HTTP traffic. The error message if this is not set look something like this:
[2023-12-01T11:53:19.521Z WARN  aws_smithy_runtime::client::http::hyper_014] unrecognized error from Hyper. If this error should be retried, please file an issue. err=error t
rying to connect: Error { code: Unavailable, messages: ["Failed to call S3 connector: Custom { kind: Other, error: \"Unsupported scheme http\" }, retries: 7"] }: Error { code
: Unavailable, messages: ["Failed to call S3 connector: Custom { kind: Other, error: \"Unsupported scheme http\" }, retries: 7"] } (hyper::Error(Connect, Error { code: Unavai
lable, messages: ["Failed to call S3 connector: Custom { kind: Other, error: \"Unsupported scheme http\" }, retries: 7"] }))

In this case the fix would be to set that setting to true in the config.json.
Otherwise it might just be a difference in the way you pass the credentials to the store. The aws SDK uses a different config detection mechanism as the previous implementation. In my (working) case, I have credentials at ~/.aws/config/~/.aws/credentials.
I assumed that https://github.com/TraceMachina/native-link/blob/3ec203b9c17e8e4dfa7160f74e948c64e542de16/native-link-store/src/s3_store.rs#L152C11-L152C11 correctly forwards environment variables to the S3 store if they're set. If this is not the case we might need to make the detection of the credential environment variables explicit.

Credentials can be used from a variety of sources. On AWS it is likely coming from the service account associated attached to the instance, which comes from "<IP_ADDRESS>" (iirc). It is possible that it is unable to resolve these credentials and use them. Doing what @aaronmondal said and setting them in ~/.aws/credentials to validate the problem would help (remember to set it on the same user that runs NativeLink [probably root]).
It is possible that the new S3 SDK does not support credentials provider (I personally have not tested yet). If it is the case, we can find a work-around.

In my (working) case, I have credentials at ~/.aws/config/~/.aws/credentials.

I deployed native-link on AWS via terraform apply, and ssh'd into the scheduler, worker, and cas VMs.
I don't believe I saw the ~/.aws directory on any of these VMs (although I can double check).
@aaronmondal should ~/.aws exist on these VMs?
I'm under the impression that the AWS SDK gets credentials from the IAM roles on these VMs.

Is the a workaround for this? I'm also facing the same issue

Yep, we identified that the default credentials provider does not support this and the sdk requires this be set manually. Fix is in-flight, but waiting on a regression test.

Should be fixed by #494. This change is published in the v0.2.0 release. Containers with this fix are:
docker pull ghcr.io/tracemachina/nativelink:v0.2.0

Please let us know if things still don't work.


[Study] Look into how to improve web performances

Study ways to better the spped of the app.
We need to give a report on the performances and spot where they need to be improved.
After the study, we should be able to create several tickets to act on the performances.
Some things to read:
https://fr.reactjs.org/docs/optimizing-performance.html
https://calibreapp.com/blog/react-performance-profiling-optimization

// DESKTOP //
Homepage =>
Performance: 49
Accessibility: 100
Best Practice: 100
SEO: 100
Categories page =>
Performance: 30
Accessibility: 100
Best Practice: 100
SEO: 100
ListReferences (via category) =>
Performance: 44
Accessibility: 97
Best Practice: 100
SEO: 100
Random reference page =>
Performance: 30
Accessibility: 100
Best Practice: 100
SEO: 90
Themes Page =>
Performance: 42
Accessibility: 95
Best Practice: 100
SEO: 100
ListReferences via random theme =>
Performance: 27
Accessibility: 95
Best Practice: 100
SEO: 100
Search page =>
Performance: 42
Accessibility: 100
Best Practice: 100
SEO: 100
ListReferences via random search =>
Performance: 59
Accessibility: 100
Best Practice: 100
SEO: 100


misbehavior of data_utils.tokenize

Hi! I am working on personalized task-oriented dialog as well and investigating on your model.
I find a minor bug:
The data_utils.tokenize cannot treat "middle-aged" as one word.
Actually, tokenize('male middle-aged') returns ['male', 'middle', '-', 'aged']. I think it should be ['male', 'middle-aged'] instead. This might affect the performance of baseline memN2N

Thanks for the interest and for pointing this out! I shall work on a fix and run tests to confirm if this is actually having an impact on the performance itself.
On initial thought, I don't think it is. Our experiments showed us that accuracy of all models for the 6 profiles were almost the same. (For example, see the section on Multi-task Learning in the paper: https://arxiv.org/abs/1706.07503.) In this case, the model must have trained embeddings for 'middle' and 'aged' separately, but when storing the profile memory, it takes a sum of the various embeddings it is composed of. What do you think?
Regardless, splitting 'middle-aged' is not the behavior we intended, so I shall fix soon.

P.S. Please make a pull request if you have already made a fix for it! :)

I did fix it on my local code, but I also changed a lot to build my own model. It might be hard to create PR, sorry for that.
Actually it is a one-line fix at:
https://github.com/chaitjo/personalized-dialog/blob/master/MemN2N/data_utils.py#L56
re.split('(\W+)?', sent)``re.split('([^A-Za-z0-9-]+)', sent)
add - and the ? is unnecessary.

I also found that the accuracy won't be affected by this minor thing based on my experiment. It is reasonable as 'middle-aged' could be seen as the sum of 'middle' and 'aged' in the embedding space.


fixed spelling mistake

fixed spelling mistake in a function in driver and subsequent reference location

@agentjill
Thanks for the PR.
We will merge them.


Linked mentions do nothing when clicked

Describe the bug
Linked mentions do nothing when clicked
Operating System
Brave on Windows 7 x64
To Reproduce
Steps to reproduce the behavior:

Export a page that contains linked mentions to HTML
Open HTML and try clicking the linked mentions to navigate to that page
Nothing happens when clicked

IMPORTANT: Error Log

Dev console shows no errors when clicking the linked mentions

Hello, I assume you mean links to other files, aka a link that was created with this markdown: [[Other File Name]]? This is certainly working and I just tested on Brave. Would you mind sharing the HTML file that was generated that has this behavior? A screen recording and the original markdown could be helpful too.
Additionally, you could try testing in another browser and see if that changes anything, let me know.
Thanks for the report!

I am referring to linked mentions as shown here:

Attached are two .zip files, one of the source .md and the other of the the exported HTML files from the plugin. I also tried in Firefox and it exhibits the same behavior. When I click on Test 2 under linked mentions. nothing happens. Clicking on [[Test 1]] and [[Test 2]] work as expected. It's just the linked mentions that don't work.
test markup.zip
test html.zip

Ah okay, this has already been reported in issue #37.
Unfortunately, I am not sure this fix will come soon since those links are controlled by an internal obsidian script so it would take a decent amount of work to get them to link up properly. I will fix it eventually, thanks for the report.
I will close this for now as it is a duplicate of #37.


feat(trajectory_follower_nodes): add simple trajectory follower

Description
Add a very simple trajectory tracking controller.
The motivation is NOT for accurate trajectory tracking. It is to have a very simple controller implementation for flexible uses.
I created this controller to achieve simple biased-tracking to test a mode transition from manual to autonomous (how the autoware behaves when the autonomous mode change is requested while traveling away from the target trajectory.).
Related links

Tests performed
You can run the simulation through manual override driving following:

run planning_simulator and set initial pose, goal.
check the vehicle mode

ros2 topic echo /vehicle/status/control_mode  // 1: Autonomous, 2: Manual

set vehicle mode to MANUAL as below

ros2 service call /system/control_mode_request tier4_vehicle_msgs/srv/ControlModeRequest "{mode: {data: 0}}"

check the control mode changes to Manual
run simple_trajectory_follower

ros2 launch trajectory_follower_nodes simple_trajectory_follower.launch.xml

Notes for reviewers

Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.

[x] I've confirmed the contribution guidelines.
[x] The PR follows the pull request guidelines.

In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.

[ ] The PR follows the pull request guidelines.
[ ] The PR has been properly tested.
[ ] The PR has been reviewed by the code owners.

Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.

[ ] There are no open discussions or they are tracked via tickets.
[ ] The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

This is also good for an example implementation in autoware.core. :+1:

After fixing the topic name of command, it worked fine
https://user-images.githubusercontent.com/59680180/177249926-a45807e8-83cd-4446-924a-ae54b53b53c8.mp4

I think it's better to write a brief description in the Readme.


fix(blob)!: update the blob.Proof to return a proof to the data root

Closes https://github.com/celestiaorg/celestia-node/issues/3582

Codecov Report
Attention: Patch coverage is 75.94937% with 38 lines in your changes missing coverage. Please review.

Project coverage is 45.38%. Comparing base (2469e7a) to head (b60fbed).
Report is 149 commits behind head on main.

Files
Patch %
Lines

blob/blob.go
58.69%
8 Missing and 11 partials :warning:

blob/service.go
82.40%
10 Missing and 9 partials :warning:

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3610      +/-   ##
==========================================
+ Coverage   44.83%   45.38%   +0.54%
==========================================
  Files         265      280      +15
  Lines       14620    16045    +1425
==========================================
+ Hits         6555     7282     +727
- Misses       7313     7908     +595
- Partials      752      855     +103

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

P.S. I believe https://github.com/celestiaorg/celestia-node/issues/2289 issue is not relevant anymore: blob retrieval will download all shares anyway, so the downloaded commitment will differ from the passed one, in case smn wants to pass a commitment without 1 share.

Agreed. And in the case of a rollup referencing data using the share commitment, we can document somewhere the possibilities so that they're aware of this.

Agreed in DM with @rach-id that the proof Verification logic should additionally check commitment: whether it belongs to the blob or not.

Agreed in DM with @rach-id that the proof Verification logic should additionally check commitment: whether it belongs to the blob or not.

ae65e8d

Btw, unit test failed

Unit test fixed: 712c272
was a good catch 👍


Documentation implemented

Docstrings updated
Fully functional readthedocs: https://plothist.readthedocs.io/en/latest/index.html

Also propose that when this is merged to main, we publish on PyPI under v0.1

Small note: don't remove the docs branch, it will be the dev branch for the readthedoc (and the main pip version will be the official doc) (|Docs from latest|  and |Docs from main| buttons)


Write "Classical statistical mechanics" section

This is an important one, but also something we don't want to spend too much time summarizing, as there are already many great resources out there.  Mainly the task will be to write a very concise overview with an eye towards knowledge necessary for understanding MD simulations, then provide an excellent, specific references list.

I'm not actually too sure how to deal with this one; maybe we should just try and write a really brief amount on some of the key issues and why they are important and link out a lot.
I'll write Dan Zuckerman and see if he has any suggestions.
Actually, better yet, I'll tag him here.
@dmzuckerman we are working on getting our "simulation basics" best practices document together for submission. Basically it's sort of a "what you had better make sure you know before going too far" kind of document which we intend to be heavy with references to good sources (rather than turning it into a book). Some topics we can address -- what makes a good barostat or thermostat, what happens if you pick a bad one -- and others we have to really just describe what people should learn about (e.g. they need to know classical mechanics and we're not going to teach it to them).
One section that's tough is the one on classical statistical mechanics.  We can't teach a course on it in an article, so to some extent it has to be a list of what people should know and where to find out about it. But we may be able to put in a bit of info anyway. Alternatively, maybe there are good concise introductions to the basics which are already out there. Thoughts?
Here's what we had put in our outline about what would perhaps go here:
\item Ensembles, distribution functions for different ensembles. Equivalence of ensembles
\item What equilibrium means and difference between equilibrium and
    non-equilibrium.
    For instance, what is usually called an ``equilibrium trajectory'' generally will not embody a good sample of the equilibrium ensemble due to insufficient sampling.
        On the other hand, truly non-equilibrium conditions such as driven transitions and relaxation are fundamentally different.
        Note that relaxation can occur to the equilibrium ensemble or a non-equilibrium condition (e.g., steady state).
\item Clarify differences between nonequilibrium ensembles: driven
    nonequilibrium steady-state, systems driven out of equilibrium by a time-dependent field, systems initially out of equilibrium but relaxing
        to equilibrium
\item Time averages and ensemble averages
\item Fluctuations
\item Correlation functions

I think I wrote a lot of that brief outline!  I would consider lending a hand with this - i.e., trying to write about one page on essential concepts with links out to references.  The problem is that since I have devoted so much of my 'free time' to the subject, I will mostly self-reference my book and perhaps blog.  I would welcome additional references put in, of course.  So think about whether you want an additional author and under these conditions.

@dmzuckerman - I really like your book, and others speak highly of it as well. I'd be totally fine with accepting your contribution on those conditions. Plan on it??
I'll "assign" the issue to you. When you edit, please add yourself as an author. :)

(Actually I have to invite you to the repo first, which I'll do now.)

Closed via #28


Add support for running containers for each provider & the analyzer engine

Once the discovery process is completed, a container will need to be started for the analyzer engine, as well as a container for each provider found during the discovery process. We will probably want to use a podman pod for this.

Hello @eemcmullan,
Please add a size label (size/XS, size/S, size/M, size/L, size/XL) to assist in the Konveyor planning process.


Backport "HBASE-26834 Adapt ConnectionRule for both sync and async connections" to branch-2.4

Signed-off-by: Duo Zhang<EMAIL_ADDRESS>

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m 19s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ branch-2.4 Compile Tests _

+0 :ok:
mvndep
0m 15s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
3m  8s
branch-2.4 passed

+1 :green_heart:
compile
3m 39s
branch-2.4 passed

+1 :green_heart:
checkstyle
1m  9s
branch-2.4 passed

+1 :green_heart:
spotbugs
2m 16s
branch-2.4 passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 10s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m 54s
the patch passed

+1 :green_heart:
compile
3m 38s
the patch passed

+1 :green_heart:
javac
3m 38s
the patch passed

+1 :green_heart:
checkstyle
0m 57s
the patch passed

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
hadoopcheck
13m 44s
Patch does not cause any errors with Hadoop 2.10.0 or 3.1.2 3.2.1.

+1 :green_heart:
spotbugs
2m 27s
the patch passed

_ Other Tests _

+1 :green_heart:
asflicense
0m 17s
The patch does not generate ASF License warnings.

42m 11s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4259/1/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/4259

Optional Tests
dupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile

uname
Linux c18e7a8385f7 5.4.0-1043-aws #45~18.04.1-Ubuntu SMP Fri Apr 9 23:32:25 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2.4 / 7acfbc0bea

Default Java
AdoptOpenJDK-1.8.0_282-b08

Max. process+thread count
60 (vs. ulimit of 12500)

modules
C: hbase-server hbase-it U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4259/1/console

versions
git=2.17.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.


Export Processors in the main module.

At this page:
https://github.com/bcaudan/jasmine-spec-reporter/blob/master/docs/customize-output.md
You suggest to do something like this to write a custom processor:
var DisplayProcessor = require('./node_modules/jasmine-spec-reporter/src/display-processor');

I think this is bad practice and I think it would be far better to do something like this:
// dedicated npm module
var DisplayProcessor = require('jasmine-spec-reporter-processor');

or
var SpecReporter =  require('jasmine-spec-reporter-processor');
// accessor from main module
var DisplayProcessor = SpecReporter.newDisplayProcessor();

Actually, I'm working on a refactoring and I choose to expose both SpecReporter and DisplayProcessor from the main module:
var SpecReporter =  require('jasmine-spec-reporter').SpecReporter;
var DisplayProcessor = require('jasmine-spec-reporter').DisplayProcessor;

Awesome! Thanks you!


Promote to 1.0.0

The v1 endpoint is published. Let's look to promote the version to 1.0.0

checking w backend team on this one


Feature Request: Expandable Card

I would like to have a Card that can be expanded. By default, it would be collapsed to save space and if you click on it, it would expand to show an additional card.

This card already exist, you can do it with conditional card : https://www.home-assistant.io/lovelace/conditional/

I think more like this: https://www.w3schools.com/howto/howto_js_collapsible.asp

@Roflcopterer, yes that's the kind of card I would like to see.

Examples of other designed concepts that encapsulate this accordion functionality:

The issue you have to deal with is a Jumpy UI. The reason why this hasn't been something we have added yet. We want the UI to stay as consistent as possible and not jump when state changes. Reason why the conditional card takes up space when the condition is false. To reserve it when its condition is met

There is also this custom card: https://github.com/RossMcMillan92/lovelace-collapsable-cards

@zsarnett Good to see you dropping down to support the community addons. Thanks for your work on HA!
I totally understand that and figured that was the case of why it doesn't exist. I think with the typical Masonry layout it would be problematic but for more advanced users who know how to control layout it wouldn't be a huge issue to deal with. I get that simplicity is key right now.
Alternatively, you could also bump it out of document flow to be more like a dropdown. Users are used to that pattern more without it disrupting a layout even if it does happen to cover elements. Are there any plans to add dropdowns to HA to allow context menus like this? e.g) https://framer.com/share/Menu-Transitions--4WnylGTbp0uHEXrNlGdQ/kCNo8cAIp
Albeit this effect is more of an advanced way of handling dropdowns but the goal would be to offer more interactive actions and entities within context of a given layout or card without popups or screen transitions.


VS Code debugger not running: Attribute 'program' does not exist

VS Code's debugger has suddenly stopped working, after months of normal use. I tried to use it on a file, linkedListIntersection.js, and received the following error:
Attribute 'program' does not exist ('/path/to/linkedListIntersection.js').
My launch.json file is:
{
  // Use IntelliSense to learn about possible attributes.
  // Hover to view descriptions of existing attributes.
  // For more information, visit: https://go.microsoft.com/fwlink/?linkid=830387
  "version": "0.2.0",
  "configurations": [
    {
      "type": "node",
      "request": "launch",
      "name": "Launch Program",
      "program": "${workspaceFolder}/path/to/linkedListIntersection.js"
    }
  ]
}

Additionally, I get the error above whenever I try to start a debugging session on any file. Oddly, the error always refers to linkedListIntersection.js, even when I try to initiate debugging while in another file.

VSCode Version: 1.28.2
OS Version: macOS High Sierra 10.13.6

I'm not sure how to reproduce this issue.
Does this issue occur when all extensions are disabled?: Yes

I seem to have fixed the issue by deleting the linkedListIntersection.js launch.json file.


static get options() not working

static get options() not working

but using
Navigation.registerComponentWithRedux(
HOME_SCREEN,
() => require('../screens/Home').default,
Provider,
store
)
static get options() is working

+1

Any solutions for this?

Use this solution, it is working for me
https://wix.github.io/react-native-navigation/api/component/#registering-a-component-wrapped-with-providers


Channel notifications

I would love to have a notification when a channel get highlighted

Umm, what do you mean? Like if someone says the channel name?

Maybe @varazir means when there is activity in a channel (and as a result gets highlighted in the bottom bar in irssi).
I am also after this. Got an almost silent channel and want to get notifications if someone talks in that channel only.

@murgo No when someone say something in the channel.
@ledakis ya what's I'm looking for

You can make irssi highlight on any message in a channel. /hilight -mask -channels #test * should do it.

@d7415 I tried that but it didn't work. + Purple Hangouts plugin for Bitlbee has support for group chats, it creates a new channel so I can't keep adding a highlight for each( if it had worked)

Interesting. That worked when I tested it. It might help @ledakis anyway. It's possible that it'd even work without the -channels #test part which would highlight on everything, but that might make an irssi dev cry...

Yes it has worked for me, thanks @d7415!

Strange, I have to look into why it's not working for me. @ledakis so you have any  scripts irssinotification ofc ? Can you post your ignore/hide settings?

I have elist only.
On that particular channel I am ignoring JOINS PARTS QUITS NICKS.
And have highlighted the channel with the command above by @d7415 .

@ledakis I have a lot more, autochannel,crapbuster,smartfilter,hide and some others but I don't think they will affect this.

Removed the scripts still I can't get anything to be highlighted in the channel... it's a irssi problem more so I'm going to ask in #irssi

I solved the higlighting problem. I hadn't set it to highlight PUBLIC level. case closed.


Use multiple adjectives

added ability to optionally choose how many adjectives to use to generate the string to increase output complexity.

Hey @brandinchiu 👋,
Thanks for your pull request!
Unfortunately, I'm going to delay merging this code for now. To preserve my ability to adequately maintain the library, I need to be very careful regarding the amount and kind of code/features I include.
While I don't usually go into detail about my reasons for rejecting a PR, let me explain:

While this code supports multiple adjectives, it arbitrarily limits it to 10, without a "real" reason to. If the user wants to have even 200, duplicate or not, why would we want to prevent this?
More importantly: While this code does add functionality, I believe that the additional code that needs to be maintained as a result adding of this functionality, does not weigh up to the limited use-cases, especially given how simple it would be to implement this in your own code (perhaps not as simple as adding a "times" flag, but still):

use ClaudioDekker\WordGenerator\Generator;
use ClaudioDekker\WordGenerator\Words\Noun;
use Illuminate\Support\Collection;

Collection::make(array_fill(0, 9, null))
  ->map(fn () => Noun::random())
  ->prepend(Generator::generate("-"))
  ->join("-")

If possible, do consider releasing your code as a package so that the community can still take advantage of your contributions!

I appreciate the explanation, and support the decision.

Hey @brandinchiu,
This came up again as part of https://github.com/claudiodekker/word-generator/pull/8, and since that implementation was very minimal, I've just merged and released it as part of v1.4.0. I figured I'd let you know about this, since this is something you had an use-case for, too.
Thanks again for initially suggesting this feature, and by extension, putting weight behind the decision to get this feature added! 👍

I appreciate the heads up!


🚀 [Feature Request] - Add styles.yml File for GitHub Issue Templates

Is your feature request related to a problem ? Please describe. ✍
style.yml (Custom ISSUE_TEMPLATE):
The styles.yml file, on the other hand, serves as a custom ISSUE_TEMPLATE for issues related to coding style, code formatting, and linting rules within your GitHub repository. This template helps contributors or users report code style-related concerns or seek guidance on adhering to the project's coding standards.
The contents of styles.yml might include specific questions or prompts related to coding style, requesting users to provide examples of code snippets that need formatting adjustments or explanation. Additionally, you might include instructions on how to check code against the project's style guidelines and best practices.
Describe briefly how you would implement this enhancement.
Some steps to implement this enhancement-
1. Go to .github/ISSUE_TEMPLATE
2. Create styles.yml File in ISSUE_TEMPLATE Folder
3. Add Valuable Information in that styles.yml File

Additional context or screenshots
Additional context
Are you contributing for a program?
GSSoC2023
Code of Conduct

[X] I have read and agree to the Contributing Guidelines of this project.

Hi @Harshil-Jani . Please Review on this Issue as soon as Possible. Thank You !


Support rendering a scene to a texture

Demos pull request: https://github.com/gearvrf/GearVRf-Demos/pull/399

Ready for review

Is there some way we can implement this as a component that you attach to a scene object that will cause it to render from the camera component attached to that scene object? If we did this the feature could be used for shadow mapping and environment mapping too.

I was thinking of re-implementing this as a specialization of GVRRenderTexture. Say GVRSceneRenderTexture where you pass the scene to be rendered and you just use the thing as a regular texture otherwise. No new APIs, etc. I will think about your suggestions and come up with something more useful. Thank you.

I am excited about this feature because it will clean up the mess in that is shadow mapping. Right now this is hacked into the renderer in a very obtrustive way (mostly because I didn't want to take on reforming the render to texture stuff as you are doing now). There is a separate render texture for each shadow map but they all use the same framebuffer because they are rendered serially. Potentially this could change with Vulkan and we could render them in different threads. I know that many console and PC game engines do this, I am not sure if it is a win on mobile. We also have this thing in the C++ layer called a texture capturer. I am not sure how that fits into the scheme of things.

The texture capturer is a special facility only useful if you use the external renderer shader. In their current form both the external renderer shader and the texture capturer do not belong to this repo. They should be re-implemented differently. We probably should look into generalizing the texture capturer in the future. The external renderer shader is not something that we may even need.
In my opinion you should drop both from your vulkan development branches if they cause too much headache. @thomasflynn will correct me if I am wrong.

Minor change introducing GVRSceneRenderTexture and eliminating the proprietary apis.

I tried use this new feature to help konidk on issue #1060. I set up a scene which renders a blurred version of the camera input to a quad and then tried to use that resulting texture. Your example works beautifully. Mine displays nothing when I use the render to texture. I don't think it is a problem with my shader because it seems to work OK if I don't render to a texture first. I will try to include a ZIP file with my test app in this message if possible.
test.zip

@NolaDonato I will investigate. Thanks.

Applying the rendered-to-texture to a quad just doesn't work regardless everything else. My sample doesn't work if I use a quad instead of a cube. Makes little sense but that is what it seems.

Rebased

@NolaDonato Got your test app working. No issues with render-to-texture and/or oes textures actually.
Detailed list of changes:
gaussianblurhorz.fsh:1
#extension GL_OES_EGL_image_external_essl3 : require

to
#extension GL_OES_EGL_image_external : require

TestMain.java:61
GVRSceneObject blurryCamera = new GVRSceneObject(context, 3.6f, 2.0f, null, GVRMaterial.GVRShaderType.OES.ID);

to
GVRTexture t = getGVRContext().getAssetLoader().loadTexture(new GVRAndroidResource(getGVRContext(), R.drawable.ic_launcher));
GVRSceneObject blurryCamera = new GVRSceneObject(context, 3.6f, 2.0f, t);

Do note that if the quad is created without a texture (any texture) passed to the ctor subsequent attempts to set the texture have no effect. Will be investigating further and I think it may have something to do with issue https://github.com/Samsung/GearVRf/issues/967.
TestMain.java:113
final GVRSceneObject blurryQuad = new GVRSceneObject(mContext, 1, 1, texture, GVRMaterial.GVRShaderType.OES.ID);

to
final GVRSceneObject blurryQuad = new GVRSceneObject(mContext, 3.6f, 2.0f, texture, GVRMaterial.GVRShaderType.OES.ID);

Since the render-to-texture is not focusing on a particular scene object the scene needs to be treated as if it were the regular main scene. Hence the quad size.
TestMain.java:120
blurryQuad.getTransform().setPositionZ(-0.01f);

to
blurryQuad.getTransform().setPositionZ(-2f);

Getting culled otherwise.

As expected the performance is bad even if the regular camera is shown since the blurry one is getting rendered anyway.
The blurry camera texture is flipped vertically because the GVRSceneRenderTexture is doing it intentionally. May be it shouldn't, will be checking that.

I will be looking into prototyping the component you suggested. It will still be Java-only but will be more in line with your idea.

Take a look at this branch to see what I did in C++: https://github.com/NolaDonato/GearVRf/tree/rendertotexture
Thanks so much for fixing the blur app! Now I can help the user with his problem.
-Nola

From: Mihail<EMAIL_ADDRESS>Sent: Thursday, March 9, 2017 12:48 PM
To: Samsung/GearVRf
Cc: Nola Donato; Mention
Subject: Re: [Samsung/GearVRf] Support rendering a scene to a texture (#1028)
I will be looking into prototyping the component you suggested. It will still be Java-only but will be more in line with your idea.

You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com/Samsung/GearVRf/pull/1028#issuecomment-285478289, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AQw1S2H3wd0PlSDwzZOVJkAoTL46qAc0ks5rkGWIgaJpZM4L1a9O.

Obsoleted by https://github.com/Samsung/GearVRf/pull/1099


Attachements limitation and expiry on DirectLine

How long are attachment files stored in the DirectLine? and also any restriction on the size of the attachment that can be sent? Please point to the documentation that has the details of this. Thanks in advance!

Found the answer here: https://stackoverflow.com/questions/56733603/where-does-directline-store-files-which-are-uploaded-through-directline-upload-a


Automated cherry pick of #8543: qcloud elb auth mode bugfix

Cherry pick of #8543 on release/3.5.
#8543: qcloud elb auth mode bugfix

Codecov Report

Merging #8547 into release/3.5 will decrease coverage by 2.65%.
The diff coverage is 0.00%.

@@              Coverage Diff               @@
##           release/3.5   #8547      +/-   ##
==============================================
- Coverage         6.14%   3.48%   -2.66%
==============================================
  Files              761     307     -454
  Lines           118373   63297   -55076
==============================================
- Hits              7269    2205    -5064
+ Misses          110445   60937   -49508
+ Partials           659     155     -504

Flag
Coverage Δ

#aFlag
3.48% <0.00%> (-2.66%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

pkg/compute/models/cachedimages.go
1.73% <0.00%> (-0.04%)
:arrow_down:

pkg/compute/models/cloudregions.go
1.54% <0.00%> (-0.04%)
:arrow_down:

pkg/compute/models/cloudsync.go
0.00% <0.00%> (ø)

pkg/compute/models/cloudsyncelasticcache.go
0.00% <0.00%> (ø)

pkg/compute/models/dbinstance_secgroups.go
0.00% <0.00%> (ø)

pkg/compute/models/dbinstancejoints.go
0.00% <0.00%> (ø)

pkg/compute/models/dbinstancenetworks.go
0.00% <0.00%> (ø)

pkg/compute/models/dbinstances.go
0.75% <0.00%> (+<0.01%)
:arrow_up:

pkg/compute/models/elasticcache_accounts.go
2.51% <0.00%> (-0.35%)
:arrow_down:

pkg/compute/models/elasticcache_instances.go
0.71% <0.00%> (-0.17%)
:arrow_down:

... and 460 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f6ad813...c00402f. Read the comment docs.

/lgtm

/approve


Add support for "click-click" block drawing workflow, in addition to "click-hold-release"

Related to https://github.com/blackears/cyclopsLevelBuilder/issues/4.

Right now, when you click once with a shape drawing mode, nothing happens. This is likely because only a "click-hold-release" workflow is programmed, and since the mouse hasn't been moved by more than a few pixels between the mouse press and release, drawing is canceled.
Instead, I expect the first point to be visible, allowing me to move the mouse to the desired location, then clicking a second time to set the shape's depth.
To implement this, there should be an "hysteresis" distance below which the shape is considered to be drawn in "click-click" fashion. This means that if the mouse has moved by less than 8 pixels between its click and release location, it should be considered as a click and not a drag.

I don't think this wold work with the current design since the block tool also doubles as the selection and move tool.  It's a design idea I got from Trenchbroom, so clicking once right now has the function of deselecting your object (or selecting a different object).
One of the redesign ideas I have is to make a separate move tool so the block tool can just draw blocks.  But I don't think I can implement this until that happens.


Are the weights available?

Yes. Please check https://github.com/mlzxy/devit/blob/main/Downloads.md.  It has pretrained weights, training log, and some annotated ycb images.

Access denied with the following error: Cannot retrieve the public link of the file. You may need to change the permission to "Anyone with the link", or have had many accesses.

Hi @mdfwn This is the screenshot of opening the given link from a non-logined firefox:

I am pretty sure at least some people could access the link publicly. Could you share a screenshot of yours opening the link?

@mdfwn
If gdown is the issue, please use rclone following the instruction from #7. Let me know if you have any questions!


Wireless for V3?

I'm not sure if there's anything i can do to help or what the limitations are if this has been discussed before, but a wireless version using a nice!nano or NRF52840 board would be amazing (halves still wired but wireless to the host device)

You can build a wireless version using the v2 (current version) using Seeed Xiao, See https://github.com/tompi/cheapino/issues/74#issuecomment-2373630023

Ahh awesome. I already have my V2 working well so i may wait it out for the V3 with the Seeed Xiao fully supported. I couldn't be without my rotary encoder. Maybe V3 if wireless could replace the RJ45 space with two encoders


[feature request] Tabular style function documentation in the readthedocs theme

in the material theme, we see that the arguments of a function, are laid out in a tabular style. the same should also be for readthedocs theme. it looks great.

Since it's the ReadTheDocs theme, I think it should resemble the actual ReadTheDocs theme:

So I'm kinda opposed to change it to the Material style by default. But feel free to override some templates to get what you're looking for :slightly_smiling_face:

in the original readthedocs, the function signature looks this this

it has a nice black text + grey background.
but with mkdocstrings, they look like this

they have orange text

hi @pawamoy,
my questions:

how to have black text + grey background like the original readthedocs theme ?
in the screenshot you showed in the above comment, you have  dark mode. how did you do that with mkdocs ?

Yes, our templates are not in sync with the actual ReadTheDocs theme, pull requests are welcome :slightly_smiling_face:

how to have black text + grey background like the original readthedocs theme ?

You'll have to override the signature template I guess, though I'm not sure how to achieve the same result as RTD. If you find a way, you can open a PR so we can better match RTD by default!

in the screenshot you showed in the above comment, you have dark mode. how did you do that with mkdocs ?

I'm using the DarkReader browser extension :slightly_smiling_face:


I think test data for diagram is off

https://github.com/DartExplore/dart-explore-backend/blob/49684d57bb2fa74bcd1fe8803e86faa23962daf2/src/main/resources/MySQL_init.sql#L40-L41
I think this is supposed to be PE1 and PE2 instead of both being PE1

confirmed with Tyler


Configure coveralls.io to track and report on test suite code coverage

I think that this can be closed.
Coverage is not reported 100% using github actions
The results are generated for each run
https://github.com/twisted/constantly/actions/runs/6690741476#summary-18176638358

Feel free to reopen this if you think we should still use coveralls.io


Added clipping opt-out for Stack.

Added a flag that instructs Stack how to deal with overflowing
children: they can either be clipped or not.

LGTM too


Fixing glide reference on example

After latest commit glide.lock in example needs to be updated.

Current coverage is 40.20% (diff: 100%)

Merging #116 into master will not change coverage

@@             master       #116   diff @@
==========================================
  Files            22         22
  Lines          3119       3119
  Methods           0          0
  Messages          0          0
  Branches          0          0
==========================================
  Hits           1254       1254
  Misses         1760       1760
  Partials        105        105

Powered by Codecov. Last update d8fa00f...46b55ea

Glide must be updated through glide.yaml. Glide.lock should be removed from git.


Fire events instead of accepting functions as props

you can always pass a callback

While that's true, it's not idiomatic vuejs code.


chore(deps): update common-dev-assets digest to 106d2bd

This PR contains the following updates:

Package
Update
Change

common-dev-assets
digest
30fb50b -> 106d2bd

Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.

[ ] If you want to rebase/retry this PR, click this checkbox.

This PR has been generated by Renovate Bot.

:tada: This PR is included in version 1.13.1 :tada:
The release is available on:

GitHub release
v1.13.1

Your semantic-release bot :package::rocket:


fix(versions): update Activiti/example-runtime-bundle versions into master

UpdateBot pushed maven dependency: org.activiti.cloud.rb:activiti-cloud-runtime-bundle-dependencies to: 7.1.202

UpdateBot commands:
updatebot push-version --kind maven org.activiti.cloud.rb:activiti-cloud-runtime-bundle-dependencies 7.1.202


Crash when scrolling mouse wheel while Mouse Tweaks is installed

Issue description:
The game crashes when you're interacting with an RS block that holds a stack of items, and you scroll the mouse wheel over that item stack (should increase or decrease the amount of items in that slot, Mouse Tweaks feature). I tested this on Pattern Grid processing mode, and Interface's Export Bus. The mechanic works fine with vanilla blocks like Crafting Table and Chest, so I presume this is an RS issue.
What happens:
The game freezes for a couple of seconds, then goes into a loading screen that says "Shutting down internal server..." and exits to desktop.
What you expected to happen:
The amount of items in the slot your mouse is over to increase or decrease.
Steps to reproduce:

Place down a Controller and a Pattern Grid
Tick the processing box on
Put some items in the input grid
Hover your mouse over the items and scroll up or down with your mouse.

Version (make sure you are on the latest version before reporting):

Minecraft: 1.12.2
Forge: <IP_ADDRESS>38 (latest available as of writing this), 2825 (used in All The Mods 3: Remix 1.3.0) and 2768 (recommended by MultiMC)
Refined Storage: 1.6.14

Does this issue occur on a server? [yes/no]
I only tried in single player.
If a (crash)log is relevant for this issue, link it here:
https://pastebin.com/HN8tCQfS this log is from a little while ago when I first encountered it while playing ATM3: Remix.
https://pastebin.com/UfCF8qsv this is while testing to confirm on a fresh instance with only RS, MT and JEI installed just a moment ago.

I can confirm this is happening, same atm remix version et all.

Probably related to #1903 ?

Can no longer reproduce on 1.16.x, closing.


handle hyphenated test file names

When trying to execute the tests for l3build, I noticed that test file names with dashes cause errors. This is because they have to pass through lua's string.gsub as a pattern where the dash is a special symbol. Escaping it solves this problem.

Thanks for the quick processing.


Adding auto-adjust brightness

This adds auto-adjustable brightness.
State (on/off) is stored in a global variable. There's a switch to enable/disable the function from HA.
Brightness is calculated from the ambient light sensor. Looking at the illuminance-table at
wikipedia, it seems reasonable to divide ambient light by 4 and add a bit, so the algorithm I've used is: x / 4 * 1.1. Also, to avoid setting a new brightness every 10 seconds, we only adjust brightness if it is off by more than 2%.

@dennisse You could add a number entity that sets the max brightness (and perhaps a minimum brightness). That way everyone can set it to what works in their personal room.

nice thanx


Added coach to Roster

I've added coach field to Roster class. I think it's good place to put it there because information about coach is in the same page as roster.
Usage:
from sportsreference.nba.teams import Team
detroit = Team("DET")
detroit_roster = detroit.roster
detroit_coach = detroit_roster.coach

I hope it would resolve #285

Hey @mateuszz0000, thank you so much for creating this awesome PR!! I apologize for the very delayed response here - it's been a pretty intense year as everyone is well aware, but I'm sorry for not getting back to you sooner.
This is wonderful, and would absolutely solve #285! I'd be very happy to accept this, but looks like there are a few things to cleanup and it needs a rebase at this point to solve some merge conflicts. I know it's been a while, so if you've moved on, that's perfectly fine - just let me know and I'd be happy to take over. But, if you would still like to be a contributor here, I'd be very happy to work with you to get this over the final hump and have it merged!
Thanks again for the great work, and hope things are going well for you!

Closing this in favor of #527.


"Revert File" on inactive editors are ignored

Does this issue occur when all extensions are disabled?: Yes

VS Code version: Code - Insiders 1.77.0-insider (2a6bd78f745d3e6330c8ff7db5282dc582e117fd, 2023-03-17T21:27:01.405Z)
Steps to Reproduce:

Create two files and open them.

Edit a file and select another file without saving the changes.

Revert File in the context menu on the inactive editor does not respond.

/confirmPlease
Does that REVERT view come from an extension?

Thanks for creating this issue! To help narrow it down, please take the time to follow below steps. Thanks a lot and happy coding 🙏
Is the issue caused by an Extension?
Stop VS Code and from the command line (NOT the integrated terminal in Code), execute: code --disable-extensions and try your steps again to see if it reproduces. If it still reproduces, jump to the next chapter.
If you see it is an issue with the extension, please run the command Start Extension Bisect and follow the instructions to find the extension that is causing this issue.

Please report the issue to the extension causing this.
Is the issue caused by VS Code Core?
If the issue is not caused by an extension, it is maybe caused by your configuration. Try to run code --disable-extensions --user-data-dir <directory> where <directory> is an empty folder. This will ensure Code is starting with a fresh data directory, e.g. no specific settings and without any extensions running.
If it still reproduces, it was maybe fixed already in our nightly release. Please download from https://code.visualstudio.com/insiders/ and see if you can reproduce the issue.
Finally, to help us narrow down what change caused the issue, please run the following command to find the build. It will start previous releases of VS Code insiders to see where the regression was introduced:

npx --yes vscode-bisect@latest
follow the instructions until you found the offending build
report back the commit range in this issue

Thanks!

It is a folder name I made for taking a screenshot.
🤦

I think "Revert File" only acts on the currently active file, and reloads it from disk.

I misunderstood your report. I think it is a bug that Revert File from the context menu of a changed-but-unsaved entry in the Open Editors view doesn't reload the file from disk if it's not the active file.

All is well, i am real and also not here for fun. Just trying to make a contribution to the support team

This is a great catch in pretty old code. Always nice to see issues like these with good steps and easy fixes 👏


add v0.10 documentation, adjust versions.html

This is the result of

installing the pytorch 1.9 latest rc
installing vision from the 0.10rc1 tag

cd docs
make html
cd ..
git checkout gh-pages
mkdir 0.10
cp -r docs/build/html/* 0.10

I also edited the versions.html to add the version documentation, and changed the symlink for stable to point to 0.10.
Please check carefully that there are no post-rc1 documentation changes (that belong in master and not the release).

A preview can be seen on my fork's github pages https://mattip.github.io/vision/0.10/, just be careful that some of the links lead off the site (like the version dropdown).

@brianjo

#4059 would have done most of this work when the 0.10 tag is created, @brianjo asked me to prepare this as a backup if it doesn't work

Even if creating the tag works, another PR will be needed to adjust stable -> 0.10 and to update the versions.html

Thanks for the PR @mattip !

Please check carefully that there are no post-rc1 documentation changes (that belong in master and not the release).

As long as you ran make html from the 0.10rc1 tag, there should be no issue right?

As long as you ran make html from the 0.10rc1 tag, there should be no issue right?

I hope so. Sometimes the docstrings can be tricky, I don't know this repo well. I built a CPU version, does that matter?

Also IIUC, you suggest we wait and see if pushing the tag works properly

Yes. Please ping me when it happens.

I hope so. Sometimes the docstrings can be tricky, I don't know this repo well. I built a CPU version, does that matter?

OK, as long as we didn't include anything in the v0.10 by mistake (which I doubt), everything should be OK. Building the docs on CPU is just fine. Thanks!

Even if creating the tag works, another PR will be needed to adjust stable -> 0.10 and to update the versions.html

@mattip should we do that before or after pushing the tag?

The versions.html and stable link should be adjusted after the final docs are in position, so after the tag/merging this PR.

The tag has been created in https://github.com/pytorch/vision/releases/tag/v0.10.0
Let's see if the docs get built


Bump Gradle and all

@armiol, as of now, and assuming base-types are available at Maven (which is now not the case because of publishing problem at base), this PR (having base-types published to mavenLocal()) builds.
I'm hoping to extract base-types into a separate repo (per our conversation in Chat). If I would not finish it during today, please arrange the resolution of this task. Or, I'd finish it upon my return.


Some functions not documented in typings

eg game.get_comment() no typescript typings

I don't maintain the typescript typings.  I honestly don't know who does.  That said, I think typescript is great and would be open to merging them into the project.


Get a better Spotswood icon

Preferably an SVG.

This is now relevant to SpotswoodCollege/Logos repository.


local variable 'crypt' referenced before assignment

Hi,
When trying to use the script, I run into the following error that only appears when using the --jmp option. Please see following output

kali@kali:/opt/darkarmour$ ./darkarmour.py -f evil.exe --encrypt XOR  --loop 5 --jmp -o notevil.exe

[i] Started armouring evil.exe (73802 bytes)
[i] Configuring to use JMP loader
[i] Begining encryption via XOR
Traceback (most recent call last): key (0)
  File "./darkarmour.py", line 116, in <module>
    darkarmour.run(vars(ap.parse_args()))
  File "./darkarmour.py", line 96, in run
    self._do_crypt()
  File "./darkarmour.py", line 90, in _do_crypt
    self._do_jmp()
  File "./darkarmour.py", line 43, in _do_jmp
    bytes, length, keys_used = self._do_encrypt()
  File "./darkarmour.py", line 33, in _do_encrypt
    bytes, len, key = crypt.crypt_file(True, crypt.key, infile=self.in_file)
UnboundLocalError: local variable 'crypt' referenced before assignment

This is a bug, I will fix it in the next few days


Update docs for Databricks Workflows

Description
Update documentation with instructions for public preview support for dbt task type in Databricks Workflows.
Checklist

[ ] I have run this code in development and it appears to resolve the stated issue
[ ] This PR includes tests, or tests are not required/relevant for this PR
[ ] I have updated the CHANGELOG.md and added information about my change to the "dbt-databricks next" section.

Thanks! merging.


Crab > Darwinia !proof

https://darwinia.subscan.io/extrinsic/2158595-2?event=2158595-5
Why?

Related: https://github.com/darwinia-network/darwinia/issues/1417


Enhancement add ouputs, fix readme

Description
This PR add outputs and also adds an initial update to the placeholder header from the README as discussed here.

Type of Change

[ ] Non-module change (e.g. CI/CD, documentation, etc.)
[ ] Azure Verified Module updates:

[ ] Bugfix containing backwards compatible bug fixes, and I have NOT bumped the MAJOR or MINOR version in locals.version.tf.json:

[ ] Someone has opened a bug report issue, and I have included "Closes #{bug_report_issue_number}" in the PR description.
[ ] The bug was found by the module author, and no one has opened an issue to report it yet.

[ ] Feature update backwards compatible feature updates, and I have bumped the MINOR version in locals.version.tf.json.
[ ] Breaking changes and I have bumped the MAJOR version in locals.version.tf.json.
[x] Update to documentation

Checklist

[x] I'm sure there are no other open Pull Requests for the same update/change
[ ] My corresponding pipelines / checks run clean and green without any errors or warnings
[x] I did run all  pre-commit checks

@herms14 do you mind approving this workflow to get this merged?

@mbilalamjad as you're the new owner, would you mind reviewing this PR?
I think some interfaces have changed  since this PR was raised; so it may fail the checks. Im happy to action those :)

@mbilalamjad as you're the new owner, would you mind reviewing this PR?
I think some interfaces have changed since this PR was raised; so it may fail the checks. Im happy to action those :)

Thank you so much both for your contribution, I'll review and update by next week.

@mbilalamjad as you're the new owner, would you mind reviewing this PR?

I think some interfaces have changed since this PR was raised; so it may fail the checks. Im happy to action those :)

Thank you so much both for your contribution, I'll review and update by next week.

@mbilalamjad Any updates regarding this?