Update es-data-svc.yaml

Fix demo error The Service "elasticsearch-data" is invalid: spec.clusterIP: Invalid value: "none": must be empty, 'None', or a valid IP address

Thank you @aslubsky Good Catch! could you update the PR or amend the commit with a email sign-off.


Update pybind version

PR #7561 uses py::ellipsis which is supported from v2.3.0.

LGTM

Jenkins, test this please

Jenkins CI test (for commit 73666b2ac2c0ff31314b9b8312b2a74c7fc5dd03, target branch master) failed with status FAILURE.

Jenkins, test this please

Jenkins CI test (for commit 73666b2ac2c0ff31314b9b8312b2a74c7fc5dd03, target branch master) failed with status FAILURE.


error received - attempt 3 [book borrowed]

Hello
I still have not managed to get title successful.  Can you please lmk how I can test i have set up correctly.
Steps performed
1 Borrowed book as normal in account
2 In terminal ran the ripper.py script
i entered book ID
ii entered login credentials
script runs then returns error in terminal
Traceback (most recent call last):
File "/Users/xx/Library/Python/3.7/lib/python/site-packages/urllib3/connectionpool.py", line 706, in urlopen
chunked=chunked,
File "/Users/xx/Library/Python/3.7/lib/python/site-packages/urllib3/connectionpool.py", line 445, in _make_request
six.raise_from(e, None)
File "", line 3, in raise_from
File "/Users/xx/Library/Python/3.7/lib/python/site-packages/urllib3/connectionpool.py", line 440, in _make_request
httplib_response = conn.getresponse()
File "/Library/Frameworks/Python.framework/Versions/3.7/lib/python3.7/http/client.py", line 1336, in getresponse
response.begin()
File "/Library/Frameworks/Python.framework/Versions/3.7/lib/python3.7/http/client.py", line 306, in begin
version, status, reason = self._read_status()
File "/Library/Frameworks/Python.framework/Versions/3.7/lib/python3.7/http/client.py", line 275, in _read_status
raise RemoteDisconnected("Remote end closed connection without"
http.client.RemoteDisconnected: Remote end closed connection without response
During handling of the above exception, another exception occurred...
[error continued][then at end]
Traceback (most recent call last):
File "ripper.py", line 101, in
main()
File "ripper.py", line 54, in main
page_count = client.fetch_book_metadata()
File "/Users/xx/D/MAC/api.py", line 106, in fetch_book_metadata
res = self.session.get(self.URL_FORMAT % ('details/' + self.book_id))
File "/Users/xx/Library/Python/3.7/lib/python/site-packages/requests/sessions.py", line 555, in get
return self.request('GET', url, **kwargs)
File "/Users/xx/Library/Python/3.7/lib/python/site-packages/requests/sessions.py", line 542, in request
resp = self.send(prep, **send_kwargs)
File "/Users/xx/Library/Python/3.7/lib/python/site-packages/requests/sessions.py", line 655, in send
r = adapter.send(request, **kwargs)
File "/Users/xx/Library/Python/3.7/lib/python/site-packages/requests/adapters.py", line 498, in send
raise ConnectionError(err, request=request)
requests.exceptions.ConnectionError: ('Connection aborted.', RemoteDisconnected('Remote end closed connection without response'))
thankyou

This problem seems to happen for me when I try to use my web-browser and this at the same time.


mnw flood - high CPU load

Hi,
this problem is getting worse the more masternodes are on v12.
I did a fresh startup, it took the node 6 minutes of 100% CPU load to parse through the complete masternode list
2015-08-27 08:37:27 Dash version v<IP_ADDRESS>-5410e0a (2015-08-25 13:39:04 -0700)

[....]

2015-08-27 08:43:40 CMasternodeSync::GetNextAsset - Sync has finished

At the time of startup there were 2638 masternodes in the list
~$ dash-cli masternode count
2638

debug.log contains 9922 occurences of
CMasternodePaymentWinner::IsValid - Masternode not in the top 10
and
mnw - invalid message - Masternode not in the top 10
each.
If old v11 nodes are the cause of this, this is a DoS attack vector. In either case: This should not happen :)

Additionally it seems that this is exactly what most users report as "stuck syncronisation" (Win) or "spinning ball" (Mac) - they are impatient and do not wait the 6mins for sync to complete...

https://github.com/dashpay/dash/issues/560

@UdjinM6 can you please elaborate how this

actively syncing masternode list and masternode winners list with all its peers during startup.

is working? You are checking each of the 2638 masternode entries of e.g. 4 peers (=10550 entries) against the winners list? At least that would explain the nnw message flood in debug.log, but i don't get the rationale :)

https://poiuty.com/img/4c5cca8dc340428b66f53b2120e8.png
wait ~20min
# cat /home/dash/data/<IP_ADDRESS>/debug.log | tail -n 20
2015-08-27 15:06:32 CMasternodePaymentWinner::IsValid - Masternode not in the top 10 (12)
2015-08-27 15:06:32 mnw - invalid message - Masternode not in the top 10 (12)
2015-08-27 15:06:32 CMasternodePaymentWinner::IsValid - Unknown Masternode 1d60acb44f14c475301dc5346bf6eea700b2ea1f87f11a99822e2c7190809b9e-0
2015-08-27 15:06:32 mnw - invalid message - Unknown Masternode 1d60acb44f14c475301dc5346bf6eea700b2ea1f87f11a99822e2c7190809b9e-0
2015-08-27 15:06:32 CMasternodePaymentWinner::IsValid - Masternode not in the top 10 (11)
2015-08-27 15:06:32 mnw - invalid message - Masternode not in the top 10 (11)
2015-08-27 15:06:32 CMasternodePaymentWinner::IsValid - Masternode not in the top 10 (12)
2015-08-27 15:06:32 mnw - invalid message - Masternode not in the top 10 (12)
2015-08-27 15:06:32 CMasternodePaymentWinner::IsValid - Masternode not in the top 10 (11)
2015-08-27 15:06:32 mnw - invalid message - Masternode not in the top 10 (11)
2015-08-27 15:06:32 CMasternodePaymentWinner::IsValid - Masternode not in the top 10 (11)
2015-08-27 15:06:32 mnw - invalid message - Masternode not in the top 10 (11)
2015-08-27 15:06:32 CMasternodePaymentWinner::IsValid - Masternode not in the top 10 (11)
2015-08-27 15:06:32 mnw - invalid message - Masternode not in the top 10 (11)
2015-08-27 15:06:33 CMasternodePaymentWinner::IsValid - Masternode not in the top 10 (11)
2015-08-27 15:06:33 mnw - invalid message - Masternode not in the top 10 (11)
2015-08-27 15:06:33 CMasternodePaymentWinner::IsValid - Unknown Masternode 4f658e4ff0167c0e52b07ee9d501afb9bfd3e8e4b24bb12821c0c069f8ff1cda-0
2015-08-27 15:06:33 mnw - invalid message - Unknown Masternode 4f658e4ff0167c0e52b07ee9d501afb9bfd3e8e4b24bb12821c0c069f8ff1cda-0
2015-08-27 15:06:33 CMasternodePaymentWinner::IsValid - Unknown Masternode 07ad23ecf30a2417dd846d48853f1ce41e5afe906b49b5d25f96b340b40b675e-1
2015-08-27 15:06:33 mnw - invalid message - Unknown Masternode 07ad23ecf30a2417dd846d48853f1ce41e5afe906b49b5d25f96b340b40b675e-1

Right now it works smth like that:
Wallet tries to get MN list and waits until there is no more new MNs come in predefined timeout. Once there is no more new MNs wallet switch to MN winners list sync. After a switch it requests winners list from all his peers and same conditions with timeout applies. MN actually sunc pretty fast but winners list is smth like (number of known MNs)210*(number of peers) and it's huge (20+Mb of data imo). That many massages cause high CPU/disk usage on load and also can cause DDoS-like issues like timeouts for blocks download etc. There is no real way of skipping this step however besides having a cache (which we turned off for now because of weird issues it had) or storing winners in blockchain for example. I tried to minimize this effect in #573 but it's a half solution too.

Does the wallet do  (number of known MNs) * 2 * 10 * (number of peers) single requests? How about requesting 500 entries each (like blockchain data and/or dseg) - of course we need a working banning mechanism or this...

Not quite that way. Wallet asks "hey, give me all winners for (number of known MNs) * 2 blocks back in history. Peer responds with inv for every record and if wallet hasn't received such inv yet it will ask for a full record then. If wallet already has this record then nothing happens.
Agree about banning mechanism but I would say we'd better find a better way for syncing first otherwise we'll be banning legit users for nothing.

How about this?
https://github.com/dashpay/dash/commit/5cc8c79c7c43f0b7c32b917a45587c8a8f90dc31

:+1:

I'll give 12.1.0 a testflight :)

Seems related

well restart doesn't help, looks like i have to wait ~10min to go past that phase, strange

No it's not normal, it should be finished at 100%. Try close client and run it once again.

is it normal for v12 win wallet to stay always in THIS synch phase ?

https://bitcointalk.org/index.php?topic=421615.msg12267764#msg12267764

Tested v<IP_ADDRESS>-5cc8c79
2015-08-28 18:47:16 Dash version v<IP_ADDRESS>-5cc8c79 (2015-08-28 08:53:08 -0700)
[...]
2015-08-28 18:49:54 CMasternodeSync::GetNextAsset - Sync has finished

Sync finished in 150 secs, CPU load is flat during this time. Well done.

Tested v<IP_ADDRESS>-b1d28c9 on Windows, sync time 3.5 mins


Kanban Board Setup

Our team consists of two members.
Team member A - @Timbar09
Team member B - @Bestbynature
Here is the link to the project.

STATUS: INVALID CODE REVIEW REQUEST 🛑 🛑
Hi @Timbar09 and @Bestbynature,
While you made a great effort in this project, unfortunately, I cannot proceed to review your code.
Invalid Code Review Request
I cannot access your Kanban board. Kindly fix that. Maybe the link is broken?

Your Code Review Request will be marked as invalid in your Dashboard, so please submit a new one once you are ready 🙏
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear. And please, remember to tag me in your question so I can receive the notification.
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.

Invalid Code Review Request does not count into the code reviews limit.

Sorry about that, @TedLivist. I didn't notice that. I fix it right away.
Thanks.

Hi @Team
Your board setup is complete!
Congratulations! 🎉
Highlights

Good setup   💯

Optional suggestions
Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better.
You can also consider:

N/A

Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification @prolajumokeoni.

As described in the Code reviews limits policy  you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

Thanks, @prolajumokeoni. 🙃


Add indicator for available updates

Could we get an indicator when there's an update available for Atom, in addition to the file menu?  If someone leaves Atom open for days at a time, they could easily end up several versions behind.
I'm picturing something like Chrome's indicator, where the hamburger icon goes from green->yellow->red depending on how stale the user's version is.  Maybe just a little light in the status bar.

Doesnt the squrrel icon serve this purpose? Do you ever see a blue squirrel in the bottom right of your status bar?

@benogle Does Atom check for updates periodically while open? If it does, I haven't noticed. It seems to only check on startup and when manually requested from the menu. The scenario @ultramiraculous mentions of leaving Atom open for several days at a time would explain why maybe they haven't seen the squirrel.

Does Atom check for updates periodically while open?

Definitely doesn't on Windows, I don't think it does on Mac but I'd have to dig into the squirrel code to be sure.
Atom only triggers update checks via the Squirrel APIs at startup.

Yeah, what @lee-dohm says makes sense for the situation I'm noticing.  If Atom isn't checking periodically, I'd imagine I'd never see the icon.

I hope you don't mind me revising the title, @ultramiraculous :grinning:

I like @lee-dohm idea of the color changing squirrel, but I'd rather use blue->red gradient rather than green->red. Maybe it could be completed with a a blinking animation that gets more insistent the wider the gap between version gets.

a blinking animation

Arrghh.  Please don't.
On Fri, Jan 9, 2015 at 3:42 PM, Cédric Néhémie<EMAIL_ADDRESS>wrote:

I like @lee-dohm https://github.com/lee-dohm idea of the color changing
squirrel, but I'd rather use blue->red gradient rather than green->red.
Maybe it could be completed with a a blinking animation that gets more
insistent the wider the gap between version gets.
—
Reply to this email directly or view it on GitHub
https://github.com/atom/atom/issues/4936#issuecomment-69420909.

I'd rather use blue->red gradient

Actually, given the recent discussion about color-blindness, I think this is a wiser choice too.

I hope you don't mind me revising the title, @ultramiraculous :grinning:

No problem!

Arrghh.  Please don't

Seconded

Arrghh. Please don't.

Hahaha, I was sure it would raise objections :wink:.
More seriously, animations in UI/UX/DX design (not loving all these buzzwords, but people have been accustomed to them) are useful, when used properly, and I think this is a situation that clearly make sense for that kind of animations, rather than a blink (I should have thought twice before using that word) I think an opacity pulse should be more appropriate, let say that the pulse doesn't appear before the gap in versions reach at least 2 or 3 versions, so that people making their update regularly doesn't get annoyed by it, starting with a 4 version gap the pulse could last 2 seconds with opacity between 0.5 and 1, get to 10 it drop to 1s with opacity between 0.3 and 1, etc.

I abhor any animation on the screen while I'm trying to code.  Also, this
seems like an attempt to force me to update. I should be able to put off
upgrades if I want, especially since there has been more than once that I
had to stay on old versions waiting for a change in core.
On Fri, Jan 9, 2015 at 4:11 PM, Cédric Néhémie<EMAIL_ADDRESS>wrote:

Arrghh. Please don't.
Hahaha, I was sure it would raise objections [image: :wink:].
More seriously, animations in UI/UX/DX design (not loving all these
buzzwords, but people have been accustomed to them) are useful, when used
properly, and I think this is a situation that clearly make sense for that
kind of animations, rather than a blink (I should have thought twice before
using that word) I think an opacity pulse should be more appropriate, let
say that the pulse doesn't appear before the gap in versions reach at least
2 or 3 versions, so that people making their update regularly doesn't get
annoyed by it, starting with a 4 version gap the pulse could last 2 seconds
with opacity between 0.5 and 1, get to 10 it drop to 1s with opacity
between 0.3 and 1, etc.
—
Reply to this email directly or view it on GitHub
https://github.com/atom/atom/issues/4936#issuecomment-69424437.

The turning to red, the further you're behind is a great idea. Maybe with a tooltip how many.
@kevinsawicki I'll un-assign myself for now. If somebody can add an attribute with how many versions Atom is behind, I can do the coloring. Something like data-versions-behind="3".


protocol/chrony: support 'sourcestats' query

Thanks for submitting a pull request! We appreciate you spending the time to work on these changes. Please provide enough information so that others can review your pull request. The three fields below are mandatory.

There are only two fields, but ;)
Summary

Explain the motivation for making this change. What existing problem does the pull request solve?

Chrony puts some source information into the "SourceData" reply, which the library already handles, and some additional information into the "SourceStats" reply, which this PR adds.  I needed the stats to keep track of how far off 1Hz various PPS sources are (the "ResidFreqPPM" element).
Test Plan

Demonstrate the code is solid. Example: The exact commands you ran and their output, copy text from console etc.

I was hoping there would be some test infrastructure in the repo to properly test new messages, but the current state is that most messages aren't tested.  I could be persuaded to take some packet captures and check that they unmarshal into the right fields.  Or I could just submit this and it could be someone else's problem in the future.
In terms of manually testing, we can compare the output of this codepath with chronyc sourcestats on two machines:
Machine A
chronyc (chrony) version 4.0 (+READLINE +SECHASH +IPV6 -DEBUG)
chronyd (chrony) version 4.0 (+CMDMON +NTP +REFCLOCK +RTC +PRIVDROP +SCFILTER +SIGND +ASYNCDNS +NTS +SECHASH +IPV6 -DEBUG)
This code (+ https://github.com/jrockway/beaglebone-gps-clock to produce the output):
Name/IP Address              NP  NR           Span  Frequency  Freq Skew        Offset       Std Dev
====================================================================================================
PHC0                         46  26           6m0s    +22.704      0.004  1.741635322s         788ns
<IP_ADDRESS>                 9   6       2h17m48s     +0.126      0.334   -1.177994ms      492.01µs
<IP_ADDRESS>                 10   6       2h35m11s     +0.484      0.657    4.741208ms    1.306933ms
<IP_ADDRESS>                 12   7        3h9m24s     +0.383      0.836       26.66µs    2.176271ms
<IP_ADDRESS>                12   8        3h9m15s     +0.125      0.725    -2.80691ms    2.154848ms
<IP_ADDRESS>                 64  30           1m4s     +0.004      0.740            0s      32.452µs

chronyc sourcestats (the samples were taken a few seconds apart, so the numbers don't match perfectly, but it does feel like the right field is going to the right place):
Name/IP Address            NP  NR  Span  Frequency  Freq Skew  Offset  Std Dev
==============================================================================
PHC0                       47  26   368    +22.694      0.004  +1742ms   780ns
<IP_ADDRESS>               9   6  137m     +0.116      0.334  -1179us   492us
nu.binary.net              10   6  155m     +0.474      0.657  +4742us  1307us
<IP_ADDRESS>               12   7  189m     +0.372      0.836    +27us  2176us
time.cloudflare.com        12   8  189m     +0.114      0.725  -2808us  2155us
<IP_ADDRESS>               49  25    49     +0.029      1.110     +9ns    31us

Machine B
chronyc (chrony) version 3.4 (+READLINE +SECHASH +IPV6 -DEBUG)
chronyd (chrony) version 3.4 (+CMDMON +NTP +REFCLOCK +RTC +PRIVDROP +SCFILTER +SIGND +ASYNCDNS +SECHASH +IPV6 -DEBUG)
This code:
Name/IP Address              NP  NR           Span  Frequency  Freq Skew        Offset       Std Dev
====================================================================================================
GPS                          31  16           8m2s    +20.126     14.265   12.809642ms    3.673112ms
PPS                          16   9           4m0s     +0.000      0.016            0s       1.113µs
RTC                          10   8          2m22s     -0.036      0.011     385.133µs         304ns
<IP_ADDRESS>                50  32      14h21m50s     +0.230      0.099    4.737684ms    3.096571ms
<IP_ADDRESS>               26  14       7h10m38s     +0.257      0.304   -5.456276ms     2.95475ms
<IP_ADDRESS>                  51  24       14h40m5s     +0.190      0.085   -9.521911ms    2.579329ms
<IP_ADDRESS>                30  14       8h18m54s     +0.236      0.201   -3.028984ms    2.633467ms

chronyc sourcestats:
Name/IP Address            NP  NR  Span  Frequency  Freq Skew  Offset  Std Dev
==============================================================================
GPS                        31  16   482    +20.126     14.265    +13ms  3673us
PPS                        16   9   240     +0.000      0.016     +0ns  1113ns
RTC                        10   8   142     -0.036      0.011   +385us   304ns
2602:fe90:300:1a2::a093:>  50  32   14h     +0.230      0.099  +4738us  3097us
2605:6400:d814::ad18       26  14  430m     +0.257      0.304  -5456us  2955us
<IP_ADDRESS>                51  24   14h     +0.190      0.085  -9522us  2579us
time.cloudflare.com        30  14  498m     +0.236      0.201  -3029us  2633us

These are pretty much identical, modulo my inability to write out the proper IPv6 address from the refid ;)

Looks ok to me. Thanks for the contribution. Can you sign the FB CLA?

Good stuff @jrockway, thanks for the pull-request.
I think your manual testing is good enough, so once CLA is signed I'd be happy to merge this.
Fair point about lack of unittests, I'll make sure we have packet_test.go added, along with instructions on how to capture the raw data needed for it (#63).

Just out of curiosity, do you use UDP port 323 for this query?

CLA is signed.  Yeah, I only tested with UDP port 323.  I will hack in a sourcestats request to ntpcheck locally and make sure it works over the unix socket as well.

I did hack in a sourcestats request to the unix socket protocol (seems like only ntpcheck serverstats uses that; so odd place to put this in but a good test), and it works fine:
$ sudo ./ serverstats -v
DEBU[0000] Will use chrony protocol
--> DEBU[0000] connected to /var/run/chrony/chronyd.sock
DEBU[0000] Read 60 bytes
DEBU[0000] response head: &{Version:6 PKTType:2 Res1:0 Res2:0 Command:54 Reply:22 Status:0 Pad1:0 Pad2:0 Pad3:0 Sequence:2 Pad4:0 Pad5:0}
DEBU[0000] response data: &{NTPHits:0 NKEHits:0 CMDHits:4188 NTPDrops:0 NKEDrops:0 CMDDrops:0 LogDrops:0 NTPAuthHits:0}
DEBU[0000] ServerStats: &{0 0}
DEBU[0000] Read 84 bytes
DEBU[0000] response head: &{Version:6 PKTType:2 Res1:0 Res2:0 Command:34 Reply:6 Status:0 Pad1:0 Pad2:0 Pad3:0 Sequence:3 Pad4:0 Pad5:0}
DEBU[0000] response data: &{RefID:1346913072 IPAddr:{IP:[0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0] Family:0 Pad:0} NSamples:39 NRuns:20 SpanSeconds:304 StandardDeviation:-624300401 ResidFreqPPM:213164037 SkewPPM:-191062648 EstimatedOffset:82306687 EstimatedOffsetErr:-657262246 EOR:0}
--> stats 0: &chrony.ReplySourceStats{ReplyHead:chrony.ReplyHead{Version:0x6, PKTType:0x2, Res1:0x0, Res2:0x0, Command:0x22, Reply:0x6, Status:0x0, Pad1:0x0, Pad2:0x0, Pad3:0x0, Sequence:0x3, Pad4:0x0, Pad5:0x0}, SourceStats:chrony.SourceStats{RefID:0x50484330, IPAddr:net.IP{0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0}, NSamples:0x27, NRuns:0x14, SpanSeconds:0x130, StandardDeviation:7.522548344240931e-07, ResidFreqPPM:22.578134536743164, SkewPPM:0.0047795213758945465, EstimatedOffset:1.811721682548523, EstimatedOffsetErr:3.929697527382814e-07}}
{"ntp.server.packets_received":0,"ntp.server.packets_dropped":0}

Fixed the PULL_REQUEST_TEMPLATE. Thanks for flagging!


[12.0] pos_debt_notebook duplicate POS Order on stock

when i validate, pos order is duplicate order on stock

Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

The issue has been resolved here:
https://github.com/it-projects-llc/pos-addons/pull/1120


script to test for (simple) vulnerabilities

open ports
simple usernames and passwords
ssh password login
very outdated OS etc


tests: context cleanup failed

With changes in an unrelated module (https://github.com/apache/couchdb/pull/1127), this came up.
A test cleanup/teardown failed, causing all following context setups to fail.
module 'chttpd_db_bulk_get_test'
  /db/_bulk_get tests
    chttpd_db_bulk_get_test:66: should_require_docs_field...ok
    chttpd_db_bulk_get_test:72: should_not_accept_specific_query_params (rev)...[0.031 s] ok
    chttpd_db_bulk_get_test:72: should_not_accept_specific_query_params (open_revs)...[0.032 s] ok
    chttpd_db_bulk_get_test:72: should_not_accept_specific_query_params (atts_since)...[0.024 s] ok
    chttpd_db_bulk_get_test:72: should_not_accept_specific_query_params (w)...[0.026 s] ok
    chttpd_db_bulk_get_test:72: should_not_accept_specific_query_params (new_edits)...[0.026 s] ok
    undefined
    *** context cleanup failed ***
**in function meck_proc:gen_server/3 (src/meck_proc.erl, line 458)
in call from meck:unload/1 (src/meck.erl, line 430)
in call from chttpd_db_bulk_get_test:teardown/1 (test/chttpd_db_bulk_get_test.erl, line 36)
**error:{not_mocked,chttpd}

  undefined
  *** context setup failed ***
**in function meck_proc:start/2 (src/meck_proc.erl, line 96)
  called as start(chttpd,[passthrough])
in call from chttpd_db_bulk_get_test:mock/1 (test/chttpd_db_bulk_get_test.erl, line 254)
in call from chttpd_db_bulk_get_test:setup/0 (test/chttpd_db_bulk_get_test.erl, line 23)
**error:{already_started,<0.7458.0>}

OK, fair enough, if it recurs I'll re-open...haven't seen this one in a long while.

leaving this closed until next occurrence, but noting that this looks like a separate issue after all


Change/use case intro page content

Description
Udpate of use case introduction images and text content.
Why
Image content as well as image types (due to huge image sizes) got exchanged to reduce the image sizes as well as correcting the image content. Additionally page content got updated with new tooltip text messages.
Issue
n/a
Checklist
Please delete options that are not relevant.

[x] I have followed the contributing guidelines
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas

SVG Image Format gives issues


Hennojin: Fix chapter not found for Suwayomi user

Checklist:

[x] Updated extVersionCode value in build.gradle for individual extensions
[ ] Updated overrideVersionCode or baseVersionCode as needed for all multisrc extensions
[ ] Referenced all related issues in the PR body (e.g. "Closes #xyz")
[ ] Added the isNsfw = true flag in build.gradle when appropriate
[ ] Have not changed source names
[ ] Have explicitly kept the id if a source's name or language were changed
[x] Have tested the modifications by compiling and running the extension through Android Studio
[ ] Have removed web_hi_res_512.png when adding a new extension

What part of the PR addresses the actual issue with Suwayomi, and what part is just style/lint/general changes?  Would be preferable if you could split it into 2 commits if you are familiar with git add --patch. Or just point out the parts in a comment here.


HA restart needed every time with network drops

If the server loses network or rejoins , BROKEN PIPE ERROR shows up in logs which needs a restart of HA to load vantage components.
Even though a minor issue sometimes it annoys.

Testing a fix for this https://github.com/ben-j-h/pyvantage/commit/6b564a844f1106990f294b3bf7362155a8b41223


Test for TCP conntrack module

Also small TCP improvement and drop stats for all IP4 chains.

The test will take about 5 seconds longer than needed due to stuff described in #1897


Add CI to the project and fix the bugs related to windows build

With this PR, we want to add CI to the project.
However, It was throwing some errors to build in Windows which are fixed with this PR.
Related issue:
https://github.com/robotology/walking-teleoperation/issues/29

Thanks @traversaro .


Fix import errors - R34

From Samn
EBI	- 08fb10df-32e5-456c-9882-e33fcd49077a  -
"ERROR:hca.staging_area_validator:Error with file: prod/08fb10df-32e5-456c-9882-e33fcd49077a/metadata/supplementary_file/b41ebd9b-c1ab-50bf-85b4-ba53fd10268b_2023-11-24T09:45:31.006000Z.json
Traceback (most recent call last):
  File ""/usr/local/lib/python3.9/site-packages/hca/staging_area_validator.py"", line 301, in validate_file_json
    self.validator.validate_json(file_json, self.total_retries, schema)
  File ""/usr/local/lib/python3.9/site-packages/hca/staging_area_validator.py"", line 381, in validate_json
    validate(file_json, schema, format_checker=FormatChecker())
  File ""/usr/local/lib/python3.9/site-packages/jsonschema/validators.py"", line 1306, in validate
    raise error
jsonschema.exceptions.ValidationError: None is not of type 'string'"

EBI -2184e63d-82d8-4ab2-839e-e93f8395f568
"ERROR:hca.staging_area_validator:Error with file: prod/2184e63d-82d8-4ab2-839e-e93f8395f568/metadata/project/2184e63d-82d8-4ab2-839e-e93f8395f568_2023-10-31T11:26:09.829000Z.json
Traceback (most recent call last):
  File ""/usr/local/lib/python3.9/site-packages/hca/staging_area_validator.py"", line 301, in validate_file_json
    self.validator.validate_json(file_json, self.total_retries, schema)
  File ""/usr/local/lib/python3.9/site-packages/hca/staging_area_validator.py"", line 381, in validate_json
    validate(file_json, schema, format_checker=FormatChecker())
  File ""/usr/local/lib/python3.9/site-packages/jsonschema/validators.py"", line 1306, in validate
    raise error
jsonschema.exceptions.ValidationError: None is not of type 'string'"

EBI	- c16a754f-5da3-46ed-8c1e-6426af2ef625
Exception: ('Did not find data file', {'name': {'prod/c16a754f-5da3-46ed-8c1e-6426af2ef625/metadata/analysis_file/883dba24-9402-46e2-9d92-b5377a2c19e2_2022-04-14T10:54:34.044000Z.json'}, 'entity_id': '883dba24-9402-46e2-9d92-b5377a2c19e2', 'entity_type': 'analysis_file', 'metadata_versions': {'2022-04-14T10:54:34.044000Z'}, 'descriptor_versions': {'2022-04-14T10:54:34.044000Z'}, 'project': {'c16a754f-5da3-46ed-8c1e-6426af2ef625'}, 'category': {'output'}, 'found_metadata': True, 'data_file_name': 'GSM4058960_228I-b.dgecounts.rds.gz', 'found_data_file': False, 'crc32c': '13cf98f9'})

EBI - e526d91d-cf3a-44cb-80c5-fd7676b55a1d
ERROR:hca.staging_area_validator:Error with file: prod/e526d91d-cf3a-44cb-80c5-fd7676b55a1d/metadata/process/ffb8e6eb-e136-4783-bead-f5930a2805f5_2023-11-10T15:28:33.648000Z.json
Traceback (most recent call last):
  File "/usr/local/lib/python3.9/site-packages/hca/staging_area_validator.py", line 301, in validate_file_json
    self.validator.validate_json(file_json, self.total_retries, schema)
  File "/usr/local/lib/python3.9/site-packages/hca/staging_area_validator.py", line 381, in validate_json
    validate(file_json, schema, format_checker=FormatChecker())
  File "/usr/local/lib/python3.9/site-packages/jsonschema/validators.py", line 1306, in validate
    raise error
jsonschema.exceptions.ValidationError: Additional properties are not allowed ('schema_major_version', 'schema_minor_version' were unexpected)

EBI - c4077b3c-5c98-4d26-a614-246d12c2e5d7
"ERROR:hca.staging_area_validator:Error with file: prod/c4077b3c-5c98-4d26-a614-246d12c2e5d7/metadata/process/fe8b00e8-6a5f-42da-842d-a734f3344d3c_2023-12-04T15:08:00.816000Z.json
Traceback (most recent call last):
  File ""/usr/local/lib/python3.9/site-packages/hca/staging_area_validator.py"", line 301, in validate_file_json
    self.validator.validate_json(file_json, self.total_retries, schema)
  File ""/usr/local/lib/python3.9/site-packages/hca/staging_area_validator.py"", line 381, in validate_json
    validate(file_json, schema, format_checker=FormatChecker())
  File ""/usr/local/lib/python3.9/site-packages/jsonschema/validators.py"", line 1306, in validate
    raise error
jsonschema.exceptions.ValidationError: Additional properties are not allowed ('schema_major_version', 'schema_minor_version' were unexpected)

Failed validating 'additionalProperties' in schema['properties']['provenance']:"

Acceptance criteria

[x] Divide the issues into types
[x] Talk with Wranglers (@idazucchi, @arschat, @Wkt8 , @anu-shiva )
[x] Plan the AI for each error type and project in the comment

[x] 2184e63d-82d8-4ab2-839e-e93f8395f568
[x] 08fb10df-32e5-456c-9882-e33fcd49077a
[x] c16a754f-5da3-46ed-8c1e-6426af2ef625
[x] c4077b3c-5c98-4d26-a614-246d12c2e5d7
[x]  e526d91d-cf3a-44cb-80c5-fd7676b55a1d

Types of issues:
Project does not have submissionDate for certain entities
Due to a PUT request, the submissionDate field has been deleted

2184e63d-82d8-4ab2-839e-e93f8395f568: project entity
08fb10df-32e5-456c-9882-e33fcd49077a: Supplementary file (Spreadsheet) DUE TO project

Missing file

c16a754f-5da3-46ed-8c1e-6426af2ef625: No clue what happened here. Need to investigate talking with other wranglers

Failed reconstructions
The script to reconstruct the old datasets is reconstructing the processes with old versions (9.0.0 instead of 9.2.0)

e526d91d-cf3a-44cb-80c5-fd7676b55a1d

c4077b3c-5c98-4d26-a614-246d12c2e5d7

Project does not have submissionDate for certain entities
2184e63d-82d8-4ab2-839e-e93f8395f568
Connect to the MongoDB and update the project

Open connection to the mongoDB database
Modify the project's submissionDate to match updateDate:

import uuid
import pymongodb
db = pymongo.mongo_client.MongoClient('mongodb://localhost:27017/', uuidRepresentation='javaLegacy')
admin = db['admin']
projects = admin['project']
project = projects.find_one({'uuid': {'uuid': uuid.UUID('08fb10df-32e5-456c-9882-e33fcd49077a')}})
ok = projects.update_one({'uuid': {'uuid': uuid.UUID('2184e63d-82d8-4ab2-839e-e93f8395f568')}}, update={'$set': {'submissionDate': project['updateDate']}})

Modify the project directly in the staging area following the same direction as in the database (Thanks @arschat for the reminder of the solution in the other ticket:

gsutil cat gs://broad-dsp-monster-hca-prod-ebi-storage/prod/2184e63d-82d8-4ab2-839e-e93f8395f568/metadata/project/2184e63d-82d8-4ab2-839e-e93f8395f568_2023-10-31T11:26:09.829000Z.json | jq -jc '.provenance.submission_date = "2023-11-06T15:39:46.916Z"' > 2184e63d-82d8-4ab2-839e-e93f8395f568_2023-10-31T11:26:09.829000Z.json
gsutil cp 2184e63d-82d8-4ab2-839e-e93f8395f568_2023-10-31T11:26:09.829000Z.json gs://broad-dsp-monster-hca-prod-ebi-storage/prod/2184e63d-82d8-4ab2-839e-e93f8395f568/metadata/project/2184e63d-82d8-4ab2-839e-e93f8395f568_2023-10-31T11:26:09.829000Z.json

Spreadsheet's submissionDate is set up from project, so, need to update it in the staging area as well:

gsutil cat gs://broad-dsp-monster-hca-prod-ebi-storage/prod/2184e63d-82d8-4ab2-839e-e93f8395f568/metadata/supplementary_file/6d27a39f-d9a9-5bef-9f06-3e46a7fb0032_2023-11-06T15:24:55.140000Z.json | jq -jc '.provenance.submission_date = "2023-11-06T15:39:46.916Z"' > 6d27a39f-d9a9-5bef-9f06-3e46a7fb0032_2023-11-06T15:24:55.140000Z.json
gsutil cp 6d27a39f-d9a9-5bef-9f06-3e46a7fb0032_2023-11-06T15:24:55.140000Z.json gs://broad-dsp-monster-hca-prod-ebi-storage/prod/2184e63d-82d8-4ab2-839e-e93f8395f568/metadata/supplementary_file/6d27a39f-d9a9-5bef-9f06-3e46a7fb0032_2023-11-06T15:24:55.140000Z.json

All missing files
c16a754f-5da3-46ed-8c1e-6426af2ef625

Delete any non-needed metadata from the staging area

# Descriptors
gsutil -m rm -r gs://broad-dsp-monster-hca-prod-ebi-storage/prod/c16a754f-5da3-46ed-8c1e-6426af2ef625/descriptors/analysis_file/

# Links - NEEDS TO SINGLE OUT LINK TO SPREADSHEET
gsutil cp gs://broad-dsp-monster-hca-prod-ebi-storage/prod/c16a754f-5da3-46ed-8c1e-6426af2ef625/links/ded0820d-4c23-56f6-81ec-53d376cde4a9_2023-11-06T11:55:59.994000Z_c16a754f-5da3-46ed-8c1e-6426af2ef625.json ded0820d-4c23-56f6-81ec-53d376cde4a9_2023-11-06T11:55:59.994000Z_c16a754f-5da3-46ed-8c1e-6426af2ef625.json
gsutil -m rm -r gs://broad-dsp-monster-hca-prod-ebi-storage/prod/c16a754f-5da3-46ed-8c1e-6426af2ef625/links/
gsutil cp ded0820d-4c23-56f6-81ec-53d376cde4a9_2023-11-06T11:55:59.994000Z_c16a754f-5da3-46ed-8c1e-6426af2ef625.json gs://broad-dsp-monster-hca-prod-ebi-storage/prod/c16a754f-5da3-46ed-8c1e-6426af2ef625/links/ded0820d-4c23-56f6-81ec-53d376cde4a9_2023-11-06T11:55:59.994000Z_c16a754f-5da3-46ed-8c1e-6426af2ef625.json

# non-project/non-spreadsheet metadata
gsutil ls gs://broad-dsp-monster-hca-prod-ebi-storage/prod/c16a754f-5da3-46ed-8c1e-6426af2ef625/metadata/ | grep -v "supplementary_file" | grep -v "project" | xargs -I{} sh -c "gsutil -m rm -r {}"

Failed reconstructions
**e526d91d-cf3a-44cb-80c5-fd7676b55a1d/c4077b3c-5c98-4d26-a614-246d12c2e5d7

@idazucchi is working on updating the processes versions through the API
@ESapenaVentura to delete the information in the staging area
Someone to hit export

Monitoring export:

[x] c4077b3c-5c98-4d26-a614-246d12c2e5d7
[ ] e526d91d-cf3a-44cb-80c5-fd7676b55a1d

fixed issue with 08fb10df-32e5-456c-9882-e33fcd49077a --> date format was wrong
working on e526d91d-cf3a-44cb-80c5-fd7676b55a1d
failed second round of validation due to a mismatch in crc32c - issue already seen in R17 but no lead on what caused it

workaroud for e526d91d-cf3a-44cb-80c5-fd7676b55a1d :  no soft deletion and only exported the project file
to do:

[ ] investigate crc32c issue
[ ] re-export?
[ ] import with soft deletion for R35

moving to the icebox - when we have capacity we can prioritise


ci: add-github-actions-pipeline

We need three types of workflows:

Run tests on the current branch  - done
Run test on a merged branch      - done
Push to npm on release

It has my blessings.
For clarification @ca-d we this PR only automated test are covered in the action's. One testing on a branch other than main, the other one testing PRs.


always got connection reset

i ran the docker using readme commands, but when curl anything using local or external ip i always got 'connection reset'. if not run then it is connection refused, which means the docker is sort of 'working'.

update:
following readme use docker mendhak/http-https-echo:31 is ok.
but following https://code.mendhak.com/docker-http-https-echo, the untagged version is always not responding.

Hey it seems to be working for me, both tagged and untagged. Both 31 and latest are the same as well, so there shouldn't be any difference. You can see the digests here match up: https://hub.docker.com/r/mendhak/http-https-echo/tags
How are you running the curl commands?
I did in one terminal:
docker run -p 8080:8080 -p 8443:8443 --rm -t mendhak/http-https-echo

Then in another:
curl localhost:8080
curl -k https://localhost:8443
curl -k -X PUT -H "Arbitrary:Header" -d aaa=bbb https://localhost:8443/hello-world

All of these gave me responses.
You could also try an nc to see if the port is reachable?
nc -v -w5 -z localhost 8080
nc -v -w5 -z localhost 8443

thanks for your quick reply!
[root@iZwz9ira2qc9d5fee9fzx4Z ~]# docker run --name echo -p 8888:8080 -p 8443:8443 --rm -t mendhak/http-https-echo

(the terminal now waits).

then i open another terminal tab, and
[root@iZwz9ira2qc9d5fee9fzx4Z ~]# nc -v -w5 -z localhost 8080
Ncat: Version 7.50 ( https://nmap.org/ncat )
Ncat: Connection to <IP_ADDRESS> failed: Connection refused.
Ncat: Trying next address...
Ncat: No route to host.
[root@iZwz9ira2qc9d5fee9fzx4Z ~]#

Hmm, all good here. I tried your commands exactly.
Could it be something specific to the machine you're running this on? Or something specific to docker's firewall rules?
Use nc to listen on a port:
nc -kl 8888

Then in another terminal try to connect to it
nc -v -w5 -z localhost 8888
curl localhost:8888

The curl above will hang, but you will see some output like this in the first listening tab:
GET / HTTP/1.1
Host: localhost:8888
User-Agent: curl/7.81.0
Accept: */*

If it still doesn't work with nc, there's something firewall related maybe, I'm not very good with knowing how to troubleshoot that but at least it's a direction.
If nc does work, then it might be docker specific but I'm not sure what.
You could also try -p "<IP_ADDRESS>:8888:8080" in the docker run command, where you put <IP_ADDRESS> in front of the port number.

i think not. as said above, using mendhak/http-https-echo:31, i can immediately curl from both local and remote. i have tried two machines.

here's docker imges:
mendhak/http-https-echo                             31                  be50bc6e9a73        7 weeks ago         125MB
mendhak/http-https-echo                             latest              b9945ea69b49        3 years ago         123MB

Oh that :latest tag looks very old! It should match the :31 tag. Can you delete and repull the latest one?
Here's what it looks like for me
mendhak/http-https-echo                                        31                  be50bc6e9a73   7 weeks ago     125MB
mendhak/http-https-echo                                        latest              be50bc6e9a73   7 weeks ago     125MB

[root@iZwz9ira2qc9d5fee9fzx4Z ~]# cat /etc/docker/daemon.json
{
  "registry-mirrors": [
    "https://pee6w651.mirror.aliyuncs.com",
    "http://hub-mirror.c.163.com",
    "https://registry.docker-cn.com"
  ],
"insecure-registries":["<IP_ADDRESS>:5000","<IP_ADDRESS>:5000"]
}

is it possible in my registry latest version is not same as official registry? in my region i don't have network to access official docker registry.

Oh I didn't know about regional restrictions to Docker registry. Yes it's possible that the registries you're pointing at have an older :latest tag that haven't been updated.
I don't know if it helps but I also publish to the Github registry?
https://github.com/mendhak/docker-http-https-echo/pkgs/container/http-https-echo
That allows
docker pull ghcr.io/mendhak/http-https-echo:latest

or
docker pull ghcr.io/mendhak/http-https-echo:31

the same. we are still using some special techniques to access github. i think the root cause has found. as a walkaround, can you update your official website version to the tagged one? it's just a suggestion, and i'm happy with your great work now, thank you very much!


Suggested resolution for issue #214

Updated line 64 of source/Handlebars/Compiler/HandlebarsCompiler.cs
This will allow the context to be passed into the layout partial.

Thanks. Can you add unit tests for this please?

Aiming to get this out to NuGet tonight.

ETA on this NuGet release?  I'd rather use your release than mine.

@rexm Could you upload a new version on NuGet with this fix? Thanks!


SHA256SUMS outdated

It seems that the SHA256SUMS are not updated since the 0.8.2 release.
The downloaded file from https://github.com/restic/restic/releases/download/v0.9.4/SHA256SUMS does not contains sums for 0.9.4.

That's not the case:
$ curl -L https://github.com/restic/restic/releases/download/v0.9.4/SHA256SUMS
c7dca90fb6fd83cee8b9f6a2776f5839794341af1953d251bf06a91870be7a8e  restic-0.9.4.tar.gz
43836fc05af4c552cb500cdc87a6ca06a6fb0f6b8f179171f1a971aee0a4d6f7  restic_0.9.4_darwin_386.bz2
df278eebd151b6ff62ceae968e3a4203a58d447712ec3fdb62551b25299a61e1  restic_0.9.4_darwin_amd64.bz2
[...]

I'm guessing you had an old SHA256SUMS file in your Downloads directory, so the new one was saved under a different name. Can you please recheck?
I'm closing this issue for now, please do add feedback!

It checks and f works as expected. Thanks.

Thanks for the feedback :)


Philosophy Question: Protoyping in OctoberCMS

As in #21 and the Docs of this Plugin you are focusing on the CMS part of October. Still the ability to use the builder plugin effectively for prototyping of plugins (works great already but could yet be improved) and hence for applications based on October.
From the view of a scientist but also as a coder in research facilities I see great potential in this philosophy.
I also wrote a first intro article on a blog to put this on discussion. What do you think?

@lionax - thanks for the blog post. I don't have much input about the post contents. It looks correct to me. Many bugs have been fixed since you published the post. Regarding the issue that you mentioned:

Delete Button of Controllers is missing, so you have to delete them with the editor.

This is done intentionally and mentioned in the Builder documentation:

Builder is a productivity tool, it doesn't completely replace coding by hand and doesn't include a code editor for editing PHP files (the only exception is the version management interface). Builder never overwrites or deletes plugin PHP files, so you can rest assured knowing that the code you write never gets touched by Builder. However, Builder can create new PHP files, like models and controllers.

Please use the issue tracker only for requesting specific features or reporting bugs.


Print file path in output

Current behavior
$ ezproxy-config-lint ./databases/a*.txt
2: URL http://www.humanitiesebook.org/ !!! URL is not using HTTPS scheme
2: URL http://www.asha.org/publications/ !!! URL is not using HTTPS scheme

It's really noticeable when passing multiple files on the cli.
Proposal
My suggestion is to follow standard linter practice that's described by the Text format of staticcheck.
file:line:col: message

The linter doesn't currently support column identification, so that may could be added later.
Example
$ ezproxy-config-lint ./databases/a*.txt
./databases/oclc/acls_humanities.txt:2: URL http://www.humanitiesebook.org/ !!! URL is not using HTTPS scheme
./databases/oclc/asha.txt:2: URL http://www.asha.org/publications/ !!! URL is not using HTTPS scheme

@moorereason With<PHONE_NUMBER>819e35630365a8305a30ef6e08f036 this and issue #2 should be fixed. If possible, would you be able to test out  v0.0.7   and see what you think? Thanks!

Resolved.  Thanks


Extension request: intl on Windows

Slightly more urgent than #429
I am going to dig into how to do it, but just wanted to raise the ticket.

I tried to add intl/icu support on Windows. The icu library seems to have some trouble with producing pure static libs under MSVC: The official vcxproj file only provides options to build dll.
https://github.com/unicode-org/icu/blob/69cb085e12764b84269c31be5a054e7c510be443/icu4c/source/i18n/i18n.vcxproj#L68C1-L79C25
I may need to first solve the problem of existing extensions not being able to compile before I can actually deal with it.

Closed: https://github.com/crazywhalecc/static-php-cli/pull/445#issuecomment-2103006892


kafka: add params for node exporter resources

During a heavy workload test, we discovered that for node exporter sidecar the CPUThrottlingHighalert was being triggered.
This PR makes sure that resources used by the sidecar can be adjusted as per Kafka workload
Signed-off-by: Zain Malik<EMAIL_ADDRESS>

@zmalik did you mean to add an empty repository/kafka/docs/latest/resources.md here? It looks terrible when embedded into the site...

removed it here https://github.com/kudobuilder/operators/pull/235


Implement changing of scenes for homes and diff levels

Implemented the sprite to hold the "next_level_cave", added hitbox, just need to add to level 1 so it doesn't look dumb
Finished changing scenes from houses to open world
**Problem is now when I leave one house I end up outside another... its probably due to global position being set after exiting

Added some debugging statements, created an autoload singleton to keep track of player locations


Return START_STICKY

Task/Issue URL: https://app.asana.com/0/488551667048375/1205722911266481/f
Description
Return START_STICKY instead of START_REDELIVER_INTENT in the VpnService.
See the reasons in the Asana task
Steps to test this PR
Smoke tests AppTP/NP

Current dependencies on/for this PR:

develop

PR #3691   👈

This comment was auto-generated by Graphite.


After all report feedback incorporated and verified, change "beta" reports to "v1"

For parent ticket https://github.com/covidatlas/li/issues/235
Currently the code generates to "beta/latest" in staging and prod.  When everything is done :-) change this to v1.
Launch reports to live
e.g., links:
reports_bucket_name/v1/latest
reports_bucket_name/v1/dates
I think the code has a few hard-coded references to beta, eg in the report generation as well as in unit tests.  This should be pulled out.  The test folder structure, and possible lambda names, should be changed as well to indicate that these are v1 reports.
Any changes to report schema will need to be in a v2/latest etc etc, and we should continue to generate v1 reports for a time going forward.

Launched to staging, will launch to prod when it's ok and team agrees.

Done, launched.


$client->refreshTokenWithAssertion() is giving error

$client->refreshTokenWithAssertion() is giving error.
it gives following error
PHP Fatal error:  Uncaught exception 'LogicException' with message 'config parameter "signing_key" must be set to refresh a token with assertion' in /Users/CFADMIN/Work/googleanalytics/google-api-php-client/src/Google/Client.php:201
Stack trace:
#0 /Users/CFADMIN/Work/googleanalytics/google-api-php-client/src/Google/Client.php(190): Google_Client->fetchAccessTokenWithAssertion()
#1 /Users/CFADMIN/Work/googleanalytics/HelloAnalytics.php(27): Google_Client->refreshTokenWithAssertion()
#2 /Users/CFADMIN/Work/googleanalytics/HelloAnalytics.php(101): getService()
#3 {main}
can you please tell me why is giving error. and how to resolve this.

The library is complaining that you need to provide a signing_key config
parameter, have you tried this?
More instructions:
https://developers.google.com/api-client-library/php/auth/service-accounts
On Wed, Oct 28, 2015 at 2:28 AM rahul9878<EMAIL_ADDRESS>wrote:

$client->refreshTokenWithAssertion() is giving error.
it gives following error
PHP Fatal error: Uncaught exception 'LogicException' with message 'config
parameter "signing_key" must be set to refresh a token with assertion' in
/Users/CFADMIN/Work/googleanalytics/google-api-php-client/src/Google/Client.php:201
Stack trace:
#0
/Users/CFADMIN/Work/googleanalytics/google-api-php-client/src/Google/Client.php(190):
Google_Client->fetchAccessTokenWithAssertion()
#1 https://github.com/google/google-api-php-client/issues/1
/Users/CFADMIN/Work/googleanalytics/HelloAnalytics.php(27):
Google_Client->refreshTokenWithAssertion()
#2 https://github.com/google/google-api-php-client/pull/2
/Users/CFADMIN/Work/googleanalytics/HelloAnalytics.php(101): getService()
#3 https://github.com/google/google-api-php-client/pull/3 {main}
can you please tell me why is giving error. and how to resolve this.
—
Reply to this email directly or view it on GitHub
https://github.com/google/google-api-php-client/issues/717.

HI @bshaffer ,
All the documentation on google and other place uses some functions that are deprecated/removed like Google_Auth_AssertionCredentials() and if i use new functions in place of these deprecated functions then i get error(above). Is there not a latest documentation for this library? The documentation given by  you in the above comment also use that deprecated/removed functions. I am unable to use these new functions in correct way.

The other version has not been deprecated, v2 is not considered stable so the documentation has not been changed.  I suggest checking out the v1.1.6 tag of this library.
If you'd like to get this to work, try setting your signing key using:
$client->setConfig('signing_key', $signingKey);

truthfully, this should be set automatically when $client->setAuthConfig is called. I'll look into making this change.
Thanks for bringing this to my attention!

Hmm.. I'm using a fresh pull of the latest, and I am experiencing the exact same issue.


fix the order of comments and replies

@miltontony @hodgestar @rudigiesler

Hmm. Tests are failing?

I know exactly what's wrong and am really annoyed by it

Other than the failing tests, looks good.

:+1:


Using torchvision roi_align in libtorch c++ jit modules

🐛 Bug
Hi, I’m trying to use libtorch 1.7.1 to load a jit model that is created with pytorch 1.5.1 and torchvision 0.6.1.
This model is using torchvision::roi_align operator.
When running the model I get this error:
Could not find any similar ops to torchvision::roi_align. This op may not exist or may not be currently supported in TorchScript.
loading the model in pytorch is working fine.
Any idea why its not loading?
I need to install another package to my c++ env to be able to load this model?
Expected behavior
load and forward the model successfully in libtorch
Environment
libtorch version: 1.7.1
Collecting environment information...
PyTorch version: 1.5.1
Is debug build: False
CUDA used to build PyTorch: 10.2
ROCM used to build PyTorch: N/A
OS: Ubuntu 18.04.2 LTS (x86_64)
GCC version: (Ubuntu 6.4.0-17ubuntu1) 6.4.0 20180424
Clang version: Could not collect
CMake version: version 3.18.0
Python version: 3.6 (64-bit runtime)
Is CUDA available: False
CUDA runtime version: 10.1.243
GPU models and configuration: GPU 0: Quadro P5000
Nvidia driver version: 418.87.01
cuDNN version: /usr/lib/x86_64-linux-gnu/libcudnn.so.7.6.3
HIP runtime version: N/A
MIOpen runtime version: N/A
Versions of relevant libraries:
[pip3] numpy==1.17.2
[pip3] numpy-indexed==0.3.5
[pip3] numpy-quaternion==2<IP_ADDRESS>.26.21
[pip3] numpydoc==0.9.1
[pip3] pytorch3d==0.2.0
[pip3] torch==1.5.1
[pip3] torchvision==0.6.1
[conda] Could not collect
Thanks

@natangold85 Could you install the torch nightly and retry using the latest master of TorchVision?

@natangold85 Could you install the torch nightly and retry using the latest master of TorchVision?

Install libtorch nightly or pytorch nightly?

Install libtorch nightly or pytorch nightly?

libtorch nightly for building the C++, pytorch nightly together with torchvision nightly.
Also, please have a look at https://github.com/pytorch/vision/blob/master/test/tracing/frcnn/test_frcnn_tracing.cpp which shows how to get a torchscripted faster rcnn (with custom C++ ops like roi_align) to run in C++

libtorch nightly for building the C++, pytorch nightly together with torchvision nightly.
Also, please have a look at https://github.com/pytorch/vision/blob/master/test/tracing/frcnn/test_frcnn_tracing.cpp which shows how to get a torchscripted faster rcnn (with custom C++ ops like roi_align) to run in C++

Also IIRC PyTorch does not guarantee the binary compatibility across PyTorch versions.
What happens if you re-create the JIT object with PyTorch 1.7.1 and TorchVision 0.8.1 and load it with libtorch 1.71 ?

Also IIRC PyTorch does not guarantee the binary compatibility across PyTorch versions.
What happens if you re-create the JIT object with PyTorch 1.7.1 and TorchVision 0.8.1 and load it with libtorch 1.71 ?

torchvision 0.8.1 is not supporting torch 1.7.1 as far as i understand.
I installed updated torch which is torch 1.7.1 and torchvision 0.8.2 and i'm seeing the same crash.
will take look at link attached above and report the results.

torchvision 0.8.1 is not supporting torch 1.7.1 as far as i understand.
I installed updated torch which is torch 1.7.1 and torchvision 0.8.2 and i'm seeing the same crash.
will take look at link attached above and report the results.

Hi @datumbox
in your example you are including torchvision/vision.h and torchvision/ops/nms.h.
I don't have those files in my libtorch installation.
this is the only difference between us.
Is torchvision is not a part of the standard libtorch installation?
Do I need to install it separately if I want to use torchvision symbols in jit models?

Hi @datumbox
in your example you are including torchvision/vision.h and torchvision/ops/nms.h.
I don't have those files in my libtorch installation.
this is the only difference between us.
Is torchvision is not a part of the standard libtorch installation?
Do I need to install it separately if I want to use torchvision symbols in jit models?

These files are part of TorchVision and it has to be installed separately. As Francisco explained you need to install libtorch, pytorch and torchvision nightly.

These files are part of TorchVision and it has to be installed separately. As Francisco explained you need to install libtorch, pytorch and torchvision nightly.

Ok.
From his message i understood he meant python torchvision.
That's what I asked in the initial post.
Will install torchvision and report
Thanks

Ok.
From his message i understood he meant python torchvision.
That's what I asked in the initial post.
Will install torchvision and report
Thanks

Hi @datumbox
I installed torchvision and it didn't solved my problem.
I narrowed my model to standalone roi_align model.
This is my python code to create the model:
from torchvision.ops import roi_align
import torch
from typing import Dict
class RoIAlign(torch.nn.Module):
def init(self, aligned_height, aligned_width, spatial_scale):
super(RoIAlign, self).init()
self.aligned_width = int(aligned_width)
self.aligned_height = int(aligned_height)
self.spatial_scale = float(spatial_scale)

def forward(self, features: torch.Tensor, rois: torch.Tensor) -> torch.Tensor:
return roi_align(features, rois, (self.aligned_width, self.aligned_height), self.spatial_scale, 0)
class RoIAlignStandAlone(torch.nn.Module):
def init(self, aligned_height, aligned_width, spatial_scale):
super().init()
self.aligned_width = int(aligned_width)
self.aligned_height = int(aligned_height)
self.spatial_scale = float(spatial_scale)
def forward(self, inputs: Dict[str, torch.Tensor]) -> torch.Tensor:
return torch.ops.torchvision.roi_align(inputs["feature"],  inputs["rois"], self.spatial_scale,
self.aligned_width, self.aligned_height,
0, False)
module = RoIAlignStandAlone(7, 7, 0.125)
sc = torch.jit.script(module)
torch.jit.save(sc, "/tmp/roi_align.pt")
This my cpp code to load the model:
#include <torch/script.h>
#include <torch/torch.h>
#include <torchvision/vision.h>
#include <torchvision/nms.h>
#include <torchvision/ROIAlign.h>
int main(int argc, char **argv)
{
torch::jit::script::Module module;
try {
std::cout << "Loading model\n";
// Deserialize the ScriptModule from a file using torch::jit::load().
module = torch::jit::load("/tmp/roi_align.pt");
std::cout << "Model loaded\n";
} catch (const torch::Error& e) {
std::cout << "error loading the model\n";
return -1;
} catch (const std::exception& e) {
std::cout << "Other error: " << e.what() << "\n";
return -1;
}
return 0;
}
you understand what i'm doing wrong here?
Thanks

Hi @datumbox
I installed torchvision and it didn't solved my problem.
I narrowed my model to standalone roi_align model.
This is my python code to create the model:
from torchvision.ops import roi_align
import torch
from typing import Dict
class RoIAlign(torch.nn.Module):
def init(self, aligned_height, aligned_width, spatial_scale):
super(RoIAlign, self).init()
self.aligned_width = int(aligned_width)
self.aligned_height = int(aligned_height)
self.spatial_scale = float(spatial_scale)

def forward(self, features: torch.Tensor, rois: torch.Tensor) -> torch.Tensor:
return roi_align(features, rois, (self.aligned_width, self.aligned_height), self.spatial_scale, 0)
class RoIAlignStandAlone(torch.nn.Module):
def init(self, aligned_height, aligned_width, spatial_scale):
super().init()
self.aligned_width = int(aligned_width)
self.aligned_height = int(aligned_height)
self.spatial_scale = float(spatial_scale)
def forward(self, inputs: Dict[str, torch.Tensor]) -> torch.Tensor:
return torch.ops.torchvision.roi_align(inputs["feature"],  inputs["rois"], self.spatial_scale,
self.aligned_width, self.aligned_height,
0, False)
module = RoIAlignStandAlone(7, 7, 0.125)
sc = torch.jit.script(module)
torch.jit.save(sc, "/tmp/roi_align.pt")
This my cpp code to load the model:
#include <torch/script.h>
#include <torch/torch.h>
#include <torchvision/vision.h>
#include <torchvision/nms.h>
#include <torchvision/ROIAlign.h>
int main(int argc, char **argv)
{
torch::jit::script::Module module;
try {
std::cout << "Loading model\n";
// Deserialize the ScriptModule from a file using torch::jit::load().
module = torch::jit::load("/tmp/roi_align.pt");
std::cout << "Model loaded\n";
} catch (const torch::Error& e) {
std::cout << "error loading the model\n";
return -1;
} catch (const std::exception& e) {
std::cout << "Other error: " << e.what() << "\n";
return -1;
}
return 0;
}
you understand what i'm doing wrong here?
Thanks

sorry for the indentation problem in the attached code

sorry for the indentation problem in the attached code

Hi @datumbox , i'm attaching .py file and .cpp file.
the .py file is producing jit model and saving it to /tmp the .cpp is trying to load it.
can you please check it on your env? it will help a lot for our team to understand what is wrong in the torchvision operators in our env.
Thanks.
test_torch_cpp.txt
roi_align_py.txt

Hi @datumbox , i'm attaching .py file and .cpp file.
the .py file is producing jit model and saving it to /tmp the .cpp is trying to load it.
can you please check it on your env? it will help a lot for our team to understand what is wrong in the torchvision operators in our env.
Thanks.
test_torch_cpp.txt
roi_align_py.txt

@natangold85 I would suggest to have a look on the example provided at TorchVision repo:
https://github.com/pytorch/vision/tree/master/test/tracing/frcnn
Start using this setup and then try to adapt it to be closer to your script. This is going to help you debug whether the issue you face is related to your development env or something else.

Thanks, I found the problem.
Apparently you need to dynamically load the torchvision symbols you are using in the jit model that you are loading.
Adding this line solved the linking issue to torchvision symbols:
static auto registry =             torch::RegisterOperators()                     .op("torchvision::roi_align(Tensor input, Tensor rois, float spatial_scale, int pooled_height, int pooled_width, int sampling_ratio, bool aligned) -> Tensor", &roi_align);
BTW @datumbox these lines are missing from your example, so i'm not sure when i need to load the symbols and when not.
but for my model it worked only when i loaded them.

Thanks, I found the problem. Apparently you need to dynamically load the torchvision symbols you are using in the jit model that you are loading. Adding this line solved the linking issue to torchvision symbols:
static auto registry = torch::RegisterOperators() .op("torchvision::roi_align(Tensor input, Tensor rois, float spatial_scale, int pooled_height, int pooled_width, int sampling_ratio, bool aligned) -> Tensor", &roi_align);
BTW @datumbox these lines are missing from your example, so i'm not sure when i need to load the symbols and when not. but for my model it worked only when i loaded them.

Hi, could I look at your full code in c++?
My case does not use only roi_align, but also other 2 more different models (detection and recognition).
Between 2 models, I used roi_align but I met the problem similar to your case.
But I don't understand how to use RegisterOperators in your solution. So if you don't mind, please let me know how to use it or just let me see the code.

@JANGSOONMYUN I'm sorry but I don't quite remember my solution.
All I remember is that I had to take slightly advance version from the libtorch 1.7.1 and torchvision 0.8.0
I needed to compile them myself because I needed to be compliant to pytorch 1.7.1.
In my source code after compiling the libraries I needed to add these includes and everything worked:
#include <torchvision/ops/nms.h>
#include <torchvision/vision.h>
I don't remember which tag I used and I don't know if in current pytorch and torchvision it will work.


Preview config crashing in 0.8.0-rc.2

Description of the bug
Config preview is crashing with:

To Reproduce
What steps did you perform which led to this issue?

Have modules installed
Open app.json
Run command Expo: Preview config
Select prebuild

Expected behavior
Opens the prebuild config preview
Actual behavior
Empty document

Additional context
Happens in version 0.8.0-rc.2

Looks like this is our culprit: https://github.com/expo/expo/blob/main/packages/expo-modules-autolinking/src/autolinking/mergeLinkingOptions.ts#L10

Fixed by https://github.com/expo/vscode-expo/pull/120


Add CLI guide for upgrading a cluster

patch the release.giantswarm.io/version label on the clusters.cluster.x-k8s.io CR

[ ] add to CLI guide for upgrading a cluster to use new update cluster command

Not urgent, @marians , a little help please, could you do a small spec for this functionality when you free. Could be something that @gusevda can do.

@gusevda Spec incoming.
Note: in step 2, the comments in thew CLI command are not meant to be displayed.

1. Standard login step (see other CLI guides)
2. Update the release label
$ kubectl \
  --context gs-gremlin \                # Replace "gremlin" with the installation name
  --namespace org-marian \              # Replace "marian" with the organization name
  label clusters.cluster.x-k8s.io \
  v3c5e \                               # Replace with the cluster name
  --overwrite \
  release.giantswarm.io/version=17.0.0  # Replace "17.0.0" with the target version available

Here 17.0.0 is the release version to upgrade to.
Additional information

kubectl gs plugin installation
Cluster CRD schema
Management API introduction


Layer ensembles

The idea is to take probes trained from multiple layers and figure out a suitable weighting scheme to ensemble their predictions together, hopefully yielding higher accuracy than any one layer can.

@Benw8888 implemented a version of this with concatenated_layer_offset a while ago


Logo proposal for SwordSoundApp

Hi good day @IvanLudvig
I am a graphic designer and I would like to contribute with the project
I can offer a logo that represents the project.
You can receive the logo without any commitment.
I want to contribute because I like to do it.
Thanks for your time.
Cheers!

Hello. That sounds great! It isn't a serious project, but I would love to have a logo designed.

Hi @IvanLudvig
Ok perfect
Tell me exactly what your project is about and the exact name of it and if it has a specific feature that you think the logo should have.

The project is an Android app that does one simple thing: it plays a sword unsheathing sound everytime the user takes his phone out of his pocket. The design of the app is really minimal with a dark-grey background.
The name of the app is pretty obvious: SwordSoundApp. I didn't come up with a better name.
I think that a good logo representing this app should include a sword and maybe give the impression of motion. I mean it should be an image, but look dynamic. However, I'm not a designer.
Thank you for spending time contributing my project! I appreciate it.

Hey there, any updates on this?


Typst guide Source code

Is your typst-guide pdf is generated in typst?
If so, is it possible to get source code ?

sorry for the last reply, this is not yet available. But all the code to generate the elements can be found in the document itself.


chore(ripple): disable problematic test on iOS Safari

Disables a problematic unit test that is currently failing on iOS Safari. Similar tests have also been disabled in the ViewportRuler.

LGTM, thanks!


Build Images for CAPVCD

User Story
Background
Tasks

[ ] specify what the build pipeline should do for hydra

[ ] where to build? Do we need to build inside a vcenter or can we build in the pipeline
[ ]  where to put the image

[ ] create an operator that pulls images into a CAPVCD MC

[ ] decide on technology (operator, cronjob, ...)
[ ] how to deal with multiple MCs running against the same VCD api
[x] can we do push based? -> will propaly not work for panamax

thougths from planning

initial bootstrap
how to deal with multiple managment clusters -> how to synchronize
check how the VCD api works, maybe we can sync via it, it might be blocking
maybe prefix image names with managment cluster names

closing in favour of https://github.com/giantswarm/roadmap/issues/1251 (dupe)


Have CDib::DIBToBitmap return std::unique_ptr<>

instead of bare pointer to fix CBitmapImage::CopyAttributes()
memory leak.  Note that this commit is changing code everywhere
except where the original code is wrong, but is in line with the
long term goal of modernizing the code base.
Fix #46

Please note that I have now sent two PRs against the same master commit.  We will need to rebase one of them after the other is applied.


Fix segfaults with a mocking class with __call

I confirmed #564 with php 5.6.20 & xdebug. It says:
PHP Fatal error:  Maximum function nesting level of '256' reached, aborting! in /Users/nobu/projects/mockery/library/Mockery/Loader/EvalLoader.php(34) : eval()'d code on line 340

In the Mockery_0_test_Mockery_TestWithMethodOverloading:
public function __call($method, $args) // line 340
{
    return $this->_mockery_handleMethodCall($method, $args);
}

This pull request attempts to avoid calling non-existing method infinitely and throws BadMethodCallException as the document says. Hope it helps.

Coverage decreased (-0.04%) to 73.844% when pulling a08916a767654ec96d0911fc37755764325ab3b9 on nobuf:nobuf/segfaults-with-method-overloading into 4957f4086614e4fb4e710680f2c000dda0db1008 on padraic:master.

Coverage decreased (-0.08%) to 73.804% when pulling 03f16c6e7a5bdb592e9267f19ab1d8233b17dac8 on nobuf:nobuf/segfaults-with-method-overloading into 4957f4086614e4fb4e710680f2c000dda0db1008 on padraic:master.

Great, thanks!

What about parent of parent?

This doesn't work. recursion is needed here to properly fix this.

Oh, wait, I think this is ok, since the parent will inherit this stuff. My bad! Ignore me!

Roger roger

:troll:


Django 5.0 support?

Can you add the django 5.0 version on pyproject.toml?
Thanks!

I will provide a patch soon. Pull requests are also welcome.

Thank you very much


Fix title attribute in Pupil Capture download link

Currently on Pupil page the a tag title attribute for Pupil Capture is incorrect = title="Download Pupil Player". Needs to be updated to "Download Pupil Capture"

@willpatera - PR https://github.com/pupil-labs/pupil-labs-website/pull/261

Merged. Closing.


fix form answers sorting by flag

As an Assessor/Admin I want the sorting by flag column on the applications page to function correctly, so that I can sort by applications that have been flagged

 [QAE17IMP] As an Assessor I want the sorting by flag column on the applications page to function correctly, so that I can sort by applications that have been flagged


[$8000] Web - Triple clicking an edited message select’s the (edited) label along with the actual message

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Action Performed:

Launch the app -> Login in account
Navigate to any conversation
Send an message -> Edit that message (make sure that has (edited) label at end of statement)
Try to select that message by triple clicking on message -> Notice message is selected along with (edited) label

Expected Result:
(edited) label should not get selected
Actual Result:
(edited) label get selected along with message
Workaround:
unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android / native
[ ] Android / Chrome
[ ] iOS / native
[ ] iOS / Safari
[x] MacOS / Chrome / Safari
[x] MacOS / Desktop

Version Number: 1.2.72-0
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:
https://user-images.githubusercontent.com/43996225/219250345-846d6e72-489f-47da-b58a-4579202c565e.mp4
https://user-images.githubusercontent.com/43996225/219250368-b1870af8-11c6-4976-9dab-e4729ea4f641.mov
Expensify/Expensify Issue URL:
Issue reported by: @dhairyasenjaliya
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1676445116253349
View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01d2bbf84b58c19ab3
Upwork Job ID:<PHONE_NUMBER>239013888
Last Price Increase: 2023-03-15

Triggered auto assignment to @kevinksullivan (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

Bug0 Triage Checklist (Main S/O)

[ ] This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
[ ] This bug is not a duplicate report (check E/App issues and #expensify-bugs)

If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead

[ ] This bug is reproducible using the reproduction steps in the OP. S/O

If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
If the reproduction steps aren't clear and you determine the correct steps, please update the OP.

[ ] This issue is filled out as thoroughly and clearly as possible

Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.

[ ] I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

Job added to Upwork: https://www.upwork.com/jobs/~01d2bbf84b58c19ab3

Current assignee @kevinksullivan is eligible for the External assigner, not assigning anyone new.

📣 @MelvinBot! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.

Format:
Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

Triggered auto assignment to Contributor-plus team member for initial proposal review - @parasharrajat (External)

Triggered auto assignment to @marcochavezf (External), see https://stackoverflow.com/c/expensify/questions/7972 for more details.

Sent to the pool.

Proposal
Please re-state the problem that we are trying to solve in this issue.
The edited text gets selected when message is double clicked along with the actual message.
What is the root cause of that problem?
The edited text is user-selectable by default.
What changes do you think we should make in order to solve the problem?

We can add the following here:
style={{userSelect: 'none'}}
What alternative solutions did you explore? (Optional)
None

@parasharrajat I have updated the platforms affected.

https://expensify.slack.com/archives/C049HHMV9SM/p1677201869393969?thread_ts=1676445116.253349&cid=C049HHMV9SM

Meanwhile,
To Contributors:
Is it possible to prevent quick selections to the edited label without making it unselectable?

What do you mean by quick selection @parasharrajat?

I think triple click can be considered a quick selection where the user does not have to pick starting and ending points.
Other examples might be where you double click and the word or line under the cursor will get selected automatically.
Does this help?

Thank you for the reply. I think this should be possible with TextSelection API. We can choose a range offset such that it does not include the last 6 characters if they form the word "edited". I will post a small fiddle of this as well shortly.

Proposal
Please re-state the problem that we are trying to solve in this issue.
When we try to copy edited messages using triple click then edited label is also being selected along with message
What is the root cause of that problem?
We are wrapping the message and edited label under a single text component so the whole text is being selected here , as we are passing the selectable={!DeviceCapabilities.canUseTouchScreen() || !props.isSmallScreenWidth} to parent Text Component,
right now structure Is like this

<Text selectable>{message}<Text>(edited)</Text></Text>

What changes do you think we should make in order to solve the problem?
We can extract the edited label out of parent Text component and we can use like this
<View style={{flexDirection: ‘row’}>
    <Text>{message}</Text>
    <Text>(edited)</Text>
</View>

What alternative solutions did you explore? (Optional)
None

📣 @jayeshmangwani! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.

Format:
Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

I think triple click can be considered a quick selection where the user does not have to pick starting and ending points.
Other examples might be where you double click and the word or line under the cursor will get selected automatically.
Does this help?

Thank you for the reply. I think this should be possible with TextSelection API. We can choose a range offset such that it does not include the last 6 characters if they form the word "edited". I will post a small fiddle of this as well shortly.

@parasharrajat Here is the sandbox that I've created. Below is a video as well of the behaviour.
https://user-images.githubusercontent.com/30054992/221322843-b92bd9fa-855d-453f-94c4-bf614574e0cb.mov

Throwing out an idea for preventing the copying of the text. We can traverse the elements of the Selection here and filter out all elements that have user-select set as none. Probably not the most efficient way but I think this will work file.

@marcochavezf @kevinksullivan @parasharrajat this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

Proposal
Please re-state the problem that we are trying to solve in this issue.
Triple-click selection includes (edited) label for edited messages.
What is the root cause of that problem?
Not a problem, this is the expected behaviour since the "edited" label is a selectable <Text />. This is more like a feature request.
What changes do you think we should make in order to solve the problem?
Wrap the label (here and here) with a <Text /> having styles position: 'absolute' and width: 'max-content'.
Absolute positioned elements are considered as separated elements for the browser.
What alternative solutions did you explore? (Optional)

Instead of using position: 'absolute' use float: 'right'.

Unfortunately, none of the above solutions are perfect, the first one being absolute positioned will not respect overflow and margins of the parent, and may be cut in the middle instead of wrapping to the next line. While the second will make the label stick to the right. Just submitting as an inspiration for better solutions :grin:.

@marcochavezf, @kevinksullivan, @parasharrajat Whoops! This issue is 2 days overdue. Let's get this updated quick!

@marcochavezf, @kevinksullivan, @parasharrajat Whoops! This issue is 2 days overdue. Let's get this updated quick!

@parasharrajat thoughts on the proposal above?

@getusha Nice, I was trying to achieve something similar but sadly this does not work, it breaks triple click selection and I think @Ollyws's proposal too.
https://user-images.githubusercontent.com/16493223/223822289-a40bf960-a2bb-438c-b409-d82d8e93bbbe.mp4

For future proposal please make sure triple selection works on both cases:

Triple selection on text
Triple selection next to text

Expected behaviour should be something like that:
https://user-images.githubusercontent.com/16493223/223822651-38f1bd88-0ccd-47dc-bebf-7a3ba9c8781d.mp4

Personally I don't see much value in having the edited label being selectable, but it would be great if we can fix this without modifying anything else. If we don't get an acceptable solution for this we may end-up either applying one of earliest proposals (making the label unselectable) or closing the issue given it's low priority/value.

Heads up. We have a similar bug here.
If it's okay to disable selection on the edited label then we should do so and in addition apply the proposed fix here.
Thanks @allroundexperts for pointing this out!

Proposal
Please re-state the problem that we are trying to solve in this issue.
(edited) label get selected along with message when triple clicking the message.
What is the root cause of that problem?
The root cause is the (edited) label is currently selectable and copiable, so when we select/copy the texts nearby it, it will select/copy the (edited) label as well.
What changes do you think we should make in order to solve the problem?

You've probably seen the Github's code line number texts, they are never selectable or copiable.

We should implement the same approach as Github did, which is to make use of the ::before pseudo element to set the text content, which is never selectable or copiable. The text content set by ::before will still have all the style of the Text element, so we don't need any style change.
Here are the steps:

Introduce a new copiable prop to our Text component, defaulting to true
If copiable is false, we'll set the content of the text using the ::before pseudo element, this can be done by adding the following logic

if (!copiable && typeof children === 'string') {
        return (
            <RNText
                allowFontScaling={false}
                ref={ref}
                style={[componentStyle]}
                dataSet={{
                    textContent: children,
                    textCopiable: false,
                }}
                {...props}
            />
        );
    }

right before https://github.com/Expensify/App/blob/3b54638d85bfe9e82b4fa02d749eaf64325050d8/src/components/Text.js#L67
(if needs to, we can explore extending the logic so that it works for Text element which children is not a string, but for this issue the above is enough)

Add the CSS for the ::before pseudo element, by adding

[data-text-copiable="false"]::before {
    content: attr(data-text-content)
}

in <style> in here https://github.com/Expensify/App/blob/main/web/index.html.

For any text that we want to be non-selectable and non-copiable, we can just add the copiable={false} to the <Text> element. For this issue it will be here https://github.com/Expensify/App/blob/5dfd58c0d853926b7d30d3eb50855e9a85d6a5b6/src/pages/home/report/ReportActionItemFragment.js#L124
and here https://github.com/Expensify/App/blob/731fbd2e08bb4f0923c9343835b92475a912631d/src/components/HTMLEngineProvider/HTMLRenderers/EditedRenderer.js#L18 (For this one, make sure to add in in the children Text element rather than the parent one)

What alternative solutions did you explore? (Optional)
We can do some changes to the HTML structure so that the triple click will not copy the edited, but it's not a general approach, only a case-by-case fix, and it can easily break if we have updates to the HTML in the future.
Working well after the fix
https://user-images.githubusercontent.com/113963320/224553164-f935717f-b080-470f-ba17-2fef7222083c.mov

@marcochavezf, @kevinksullivan, @parasharrajat Whoops! This issue is 2 days overdue. Let's get this updated quick!

Hi, just want to point out that the text with user-select: none still copyable is a Chromium bug and looks like it's fixed on the latest version. I don't know about Safari though.

It's very consistent across all browsers so I wouldn't say it's a bug. I can reproduce the same behavior on latest Chrome.

Throwing out an idea for preventing the copying of the text. We can traverse the elements of the Selection here and filter out all elements that have user-select set as none. Probably not the most efficient way but I think this will work fine.

@parasharrajat We're already making use of the Selection API heavily in the SelectionScrapper file. In there, we're duplicating ranges, changing there end position and a lot of other stuff. I think adding the logic stated above would concretely solve the related issues as well. @s77rt also suggested the same (here)[https://github.com/Expensify/App/issues/15810#issuecomment-1465023649]. I think this is worth a shot.

@parasharrajat I think in the solution we're not really doing anything shady here, the solution is valid (not a hack) and the only reason we need to put in in CSS is because of the library limitation.
if we think it's a good solution then we shouldn't let a library limitation hold us off.

Unfortunately, this can't be done unless we make an exception for it.

cc @marcochavezf any thought on this?

Current assignee @parasharrajat is eligible for the Internal assigner, not assigning anyone new.

@marcochavezf, @kevinksullivan, @parasharrajat Whoops! This issue is 2 days overdue. Let's get this updated quick!

@parasharrajat still needs to review some of the other proposals. @parasharrajat once you've done so let us know if anything passes, otherwise we'll need to take this internal.

@marcochavezf, @kevinksullivan, @parasharrajat Whoops! This issue is 2 days overdue. Let's get this updated quick!

Hi @parasharrajat, any update?

Upwork job price has been updated to $4000

@parasharrajat I think in the solution we're not really doing anything shady here, the solution is valid (not a hack) and the only reason we need to put in in CSS is because of the library limitation.
if we think it's a good solution then we shouldn't let a library limitation hold us off.

Unfortunately, this can't be done unless we make an exception for it.

cc @marcochavezf any thought on this?

Could you expand on the library limitation? We aim to fix the root cause instead of band-aid solutions, so if it's a library limitation, should we fix it in the library?

Using the "float" property might be concerning, but we can achieve the same result as "float: left" by applying the display: flex can add styles.dFlex property to it's parent Text. which separates the editable text from the parent text and fixes the selection. I tested it and found that it completely fixes the issue.

Hi @getusha, just to be sure, this is a different solution than the one proposed here, correct?

@tienifr could you expand on the library limitation? We aim to fix the root cause instead of band-aid solutions, so if it's a library limitation, should we fix it in the library?

@marcochavezf the limitation is that React does not support targeting pseudo-elements using inline-style (see here for detail). This is because React inline style uses the style html attribute under the hood, which does not support targeting pseudo-elements inline.
I don't think we can fix anything in the library since it's like that by definition.
This, however, doesn't mean using pseudo-elements is a workaround. Pseudo-elements are valid HTML feature, just that it cannot be targeted by using inline style. For other pseudo-elements what we're currently doing is we set it in CSS, for example here where we use the :placeholder pseudo-element.
FYI Github is also using the exact same solution I mentioned for that use case.

The root cause is browser related (Selection API). I think we should fix that on the SelectionScraper level.
Pseudo-elements are meant for decoration purposes only; making a text unselectable should not implicit making it a decoration e.g. on https://github.com/Expensify/App/issues/15810 we have same issue with emojis, it won't make much sense to treat those as a decoration.
Proposal
Cross-Proposal

I actually think both that edited and emojis (that should be unselectable and uncopiable) are in fact “decorations”, since they are not “page content” (which should be selectable and copiable) 👍

@marcochavezf, @kevinksullivan, @parasharrajat Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@marcochavezf, @kevinksullivan, @parasharrajat Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

Hi @parasharrajat, any updates on this?

Just a small note, any solution accepted here will be applied to this issue as well . If we go with manipulating the style to avoid copying we likely need to do it again on a case by case basis for every copy-related issues.

@parasharrajat what's wrong with this proposal https://github.com/Expensify/App/issues/15194#issuecomment-1444045148. Maybe, I am missing something, but I do not see a review comments about that proposal. I think that solves the issue without any workaround. In fact, I have the exact same proposal, but I can not post a duplicate one.

Proposal
Updated
hey @parasharrajat I have updated the depth details in my proposal
Thanks @mdneyazahmad , for reminding my proposal, I wasn't active in this issue's conversation and I forgot about this issue.

Triggered auto assignment to @arielgreen (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

Bug0 Triage Checklist (Main S/O)

[ ] This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
[ ] This bug is not a duplicate report (check E/App issues and #expensify-bugs)

If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead

[ ] This bug is reproducible using the reproduction steps in the OP. S/O

If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
If the reproduction steps aren't clear and you determine the correct steps, please update the OP.

[ ] This issue is filled out as thoroughly and clearly as possible

Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.

[ ] I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

@arielgreen heading OOO so going to pass this one over to you. Thanks!

@marcochavezf, @parasharrajat, @arielgreen Whoops! This issue is 2 days overdue. Let's get this updated quick!

Applying either flex or inline-flex has this issue when the message is overflowed to multiple lines.

@Ollyws @marcochavezf Won't the proposal break triple-click selection as mentioned here https://github.com/Expensify/App/issues/15194#issuecomment-1460733406? Triple click on the empty space next to (edited) and verify the text is selected.

@Ollyws I'm not sure we want to change the hierarchy even if we can, we will struggle with similar issues. Example: The bug would still be reproducible with reaction emojis and those cannot be moved.
Check video below, just verify that the results you get are as shown in the second part of the video
https://user-images.githubusercontent.com/16493223/224516571-a2ba685d-55af-4317-8f75-5394580ce38c.mp4

@getusha Not on the edited label but on the empty space.
@Ollyws I meant to refer to the reactions emoji:

Send a message
React to that message
Triple click selection (on an empty space)
Copy the message
Verify the copied message does not include the edited label nor emojis from context menu nor the emojis from the reactions buttons.

Hi @Ollyws, yes please, let's also consider the fix for the emoji issue in the PR. Also, thank you @getusha @s77rt @mdneyazahmad for your comments and for pointing out the edge cases

@marcochavezf, @Ollyws, @parasharrajat, @arielgreen Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

PR still in review

⚠ Looks like this issue was linked to a Deploy Blocker here
If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.
If a regression has occurred and you are the assigned CM follow the instructions here.
If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

I doubt using style={{userSelect: 'none'}} and selectable={false}, both will work.
When copying the selected text, it will copy the whole string with edited text and quick emojis. Please correct me if I am missing something here. @allroundexperts @dhairyasenjaliya

@marcochavezf @parasharrajat The commit that caused that deploy blocker  is actually no longer necessary and can be removed. What's the process here?

@Ollyws yeah, let's remove that commit and create the PR again

Upwork job auto closed, here is the new one: https://www.upwork.com/jobs/~011daec0b1f8688fbb

@Ollyws can you please apply to the posting here: https://www.upwork.com/jobs/~011daec0b1f8688fbb
@dhairyasenjaliya @parasharrajat offers sent in Upwork

@Ollyws offer sent

Discussing with Marco here

Last PR has been merged but has not been deployed yet.

Merged May 19, updating payment date accordingly.

Reassigning, OOO tomorrow and Monday.

Just waiting on you @parasharrajat for the contract: https://www.upwork.com/nx/wm/offer/24481238
And the BZ Checklist: https://github.com/Expensify/App/issues/15194#issuecomment-1562078430

Payment sent.

Test Case addition requested.


Android: White screen issue outside of map when keyboard is visible

I'm using the map in a subpage of my app, so the map is only initialized when i open this subpage. What i recently discovered is, that when (map was not initialzed yet) the keyboard opens, the content area is covered by a white area (probably from root.setBackgroundColor(Color.WHITE) in GoogleMaps.java). Now when i open the subpage (and the map gets initialized), i can go back to the other pages and trigger the keyboard, just to see everything normal without any white area.
Do you have any idea what i could do about that?
I've seen this issue on Android 5 and 6 so far but haven't tested on any other devices. I'm using Crosswalk 15 and the cordova crosswalk webview plugin 1.4.0.

Do you have  <preference name="xwalkZOrderOnTop" value="true" /> to your config.xml ? If not try adding it and see if that fixes the problem.

It does not fix my problem.
I've also had an issue with some devices (nexus 5 and sony xperia) where the app would be just blank without the map ever being initialized.
I got it fixed by removing the line:
view.setLayerType(View.LAYER_TYPE_HARDWARE, null);
In GoogleMaps.java line 196.
Apparently LAYER_TYPE_HARDWARE messes the z-index up for some devices more than others. How relevant is this line anyways? I've been googling like mad but couldn't figure anything related to crosswalk.

@Alex-Sessler Could you provide some screen captures before and afters, and give some code (or html, css) that reproduce your issue.
Fortunately, I have also Nexus 5. So it should reproduce your issue.

Any update for this? If no update in couple of days, I will close this file.

@Alex-Sessler There is no problem on my Nexus 5 at all.
I could not reproduce your issue (due to less information).
I close this issue at once. If you have any update, please reopen this issue.


Fix IAM creds for podtemplate spec on S3

Unable to upload to S3 due to permissions.  I need to validate the IAM configuration on S3 and resolve the issue.

Sub task of #22


ssl-cert-check: 3.31 -> 4.14

Motivation for this change
Update to latest upstream release 4.14
Also, includes a little cleanup.
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[x] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 120851 run on x86_64-linux 1

1 package built:

ssl-cert-check

Result of nixpkgs-review pr 120851 at e8d2554b run on x86_64-linux 1

1 package built successfully:

ssl-cert-check

2 suggestions:

warning: missing-phase-hooks
installPhase should probably contain runHook preInstall and runHook postInstall.
Near pkgs/tools/admin/ssl-cert-check/default.nix:45:3:
   |
45 |   installPhase = ''
   |   ^

warning: build-tools-in-build-inputs
which is a build tool so it likely goes to nativeBuildInputs, not buildInputs.
Near pkgs/tools/admin/ssl-cert-check/default.nix:30:3:
   |
30 |   buildInputs = [
   |   ^


v1.25.1 Error: EACCES: using install script with custom location for user only install attempts to install to system directory

Description
The build and install script does not respect install location for icon installation. Unsure if this prevents a complete install, as opening the application still seems OK.
Steps to Reproduce

git pull; git checkout v1.25.1
script/build --install=/home/user/.local

Expected behavior: Installation without errors
Actual behavior: Partial installation, ends with
Removing previously installed "atom-1.25.1-amd64" at "/home/user/.local/share/atom"
Installing "atom-1.25.1-amd64" at "/home/user/.local/share/atom"
Installing icons at "/usr/share/icons/hicolor"
Error: EACCES: permission denied, mkdir '/usr/share/icons/hicolor/1024x1024'
at Object.fs.mkdirSync (fs.js:885:18)
at mkdirsSync (/home/user/apps/atom/script/node_modules/fs-extra/lib/mkdirs/mkdirs-sync.js:29:9)
at Object.mkdirsSync (/home/user/apps/atom/script/node_modules/fs-extra/lib/mkdirs/mkdirs-sync.js:35:16)
at Object.copySync (/home/user/apps/atom/script/node_modules/fs-extra/lib/copy-sync/copy-sync.js:31:36)
at fs.readdirSync.forEach.imageName (/home/user/apps/atom/script/lib/install-application.js:103:14)
at Array.forEach (:null:null)
at module.exports (/home/user/apps/atom/script/lib/install-application.js:99:36)
at binariesPromise.then.then.then.then.packagedAppPath (/home/user/apps/atom/script/build:132:7)
at :null:null
Reproduces how often:
Occurs both when building on top of previously built artifacts, and also after running git clean -fxd and building
Versions
git tag/release v1.25.1

Thanks for contributing!
We noticed that this is a duplicate of https://github.com/atom/atom/issues/16853 so you can subscribe there for updates if you'd like.

Because we treat our issues list as the Atom team's backlog, we close duplicates to focus our work and not have to touch the same chunk of code for the same reason multiple times. This is also why we may mark something as duplicate that isn't an exact duplicate but is closely related.
For information on how to use GitHub's search feature to find out if something is a duplicate before filing, see the How Can I Contribute? section of the Atom CONTRIBUTING guide.


[NTR] children of 'herpes simplex infectious disease'

Preferred term label:

[ ] 'herpes simplex type 1 infectious disease'
[ ] 'herpes simplex type 2 infectious disease'

need to import:
http://purl.obolibrary.org/obo/NCBITaxon_10298
http://purl.obolibrary.org/obo/NCBITaxon_110310

[ ] 'herpes simplex lip infection'
[x] ~'herpes simplex genital infection'~ This already exists MONDO_0005770
[x] ~create pattern: infectious_disease_by_location.yaml
Similar to: https://github.com/monarch-initiative/mondo/blob/master/src/patterns/dosdp-patterns/infectious_disease_by_agent.yaml~ We have https://raw.githubusercontent.com/monarch-initiative/mondo/master/src/patterns/dosdp-patterns/location.yaml, so we don't need a new pattern

@sabrinatoro do you know of other anatomical herpes infections?

I excluded the superclass 'male reproductive system disease' on genital herpes because this can affect females too.
For some reason 'reproductive system disease' is not inferred as a parent.