Odd choppiness to animation?

I was checking out the demo (41-cube) and noticed some chopping/lag... I wonder if this is a Go-GL issue or just something with the way to program was written.

I took a look at this. My first inclination was to dismiss it, as I couldn't reproduce the jank. But I looked very closely and did perceive a little jank, occasionally. A tiny amount, maybe once every 100 frames. Barely perceptible unless you look for it continuously and closely for a while.
So I decided to measure it. Here's a histogram, with milliseconds-per-frame on the x axis:
go-gl/glfw

C program using just glfw/glfw

Thoughts
Note the extremes on the left and the right. This data only represents a few seconds of runtime, so those individual data points are significant.
In any case I don't know if the effect I'm seeing is the same as @rucuriousyet is reporting, since we don't know what kind of choppiness he was experiencing. What we need is more data. Can someone report back with their frame timings? If you dump them in a file and attach them here, I can make a histogram. I'm just taking the elapsed time variable in gl41core-cube.
You can see there is quite a wide skew. I have run with GODEBUG=gctrace=1,schedtrace=1, but don't see anything correlating with the long frames on the Go side. There is no garbage collection occurring. This effect is observable even if I turn off all code except for glfw.SwapBuffer.
Based on what I've seen I think this could be a real (but subtle) effect, but I don't know what is at fault. It looks like it is glfw or something deeper in the stack. (I'm on recentish Nvidia drivers on Linux on a powerful card). The effect is so subtle to my eye that if it were present in other software I may not have noticed it. I can notice the effect worsening if I inject random delays of 1-5ms, implying that the delays shown in the above histograms might be the cause.
We're at the limits of what I'm able to debug for now. It would be interesting if someone is able to grab a fine time resolution trace and figure out where the time is getting lost. Maybe there is a bug in to be fixed somewhere in the stack :)


Why load training and eval data in ns-render

I am curious that when I execute ns-render using a custom camera path or calculated path, nerfstudio will load the training data and eval data like in training, would that be necessary?

It needs the data files for creating some metadata used to generate the model. This isn't ideal, at some point we hope to store that data in the model file so that this can be avoided. But as of right now, you do still need that data available when rendering.


MI - TRANSPORTS (Websocket)

Complete[1].
[1] https://github.com/wso2/docs-ei/blob/master/en/micro-integrator/docs/references/transports/webSocket-Transport.md

Moved the contents to 'Concepts' [1] and the 'Transport Parameters' [2] pages.
[1] https://github.com/wso2/docs-ei/blob/master/en/micro-integrator/docs/concepts/concepts.md
[2] https://github.com/wso2/docs-ei/blob/master/en/micro-integrator/docs/references/transports/transport-catalog.md


Document how to run on port 80/443

Add information about using setcap to allow node run on ports lower than 1024
sudo setcap 'cap_net_bind_service=+ep' /usr/bin/nodejs

Now added to the getting started in the readme


Implement sonobuoy delete subcommand

This seems to have fallen off the radar amidst all the other work.
It should try to do the namespace, or label based deletion.
The weird part here is making sure the other namespaces e2e etc are all cleaned up if there was a botched run.

Unfortunately the namespaces for all the other e2e tests are randomly generated per-test, so getting rid of them is tricky

They should be prefix'd e2e-
The things that aren't are bugz imo.

Done by #295


Multiple systems code examples

Changes
Adds code examples to the multiple systems page.

Note: Some British spelling conventions such as "learnt" and "behaviour". Not sure if we are trying to be consistent one way or the other (US vs UK spellings).

Good catch, I think we should stick to american.


Error handling: Abort current task on failure

Change behavior to abort the running task for a particular host on
failure, so subsequent tasks don't get run.  Continue with tasks for
other hosts.  This means that if there is an issue with one node, other
nodes are not affected, but the task on that particular node is stopped.
Testing: make test-all

@cawallin @anusudarsan


post to Snowflake login url /session/v1/login-request hanging, failing

This is almost a support request rather than a bug, but I can't figure out what's going on from the docs, so maybe it could be considered a bug in the docs?
Describe the bug
I'm attempting run sample01 in the "Getting Started" guide, and I can't run the initial snowddl 'apply' command for sample01_01 because the authentication appears to be failing. I've created a trial account w/snowflake and gotten my account identifier from the account selector popup.  Command line is:
snowddl -c sample01_01 -a "GAJVKZJ.OYB90337" -u SNOWDDL -p thisIsNotMyPassword --apply-unsafe --log-level DEBUG plan

(I also tried it without quotes around the account identifier.)
My current working dir. is
C:\Users\thisIsNotMyUserName\appdata\Local\Programs\Python\Python311\Lib\site-packages\snowddl\_config

Expected behavior
I expected sample01_01 to get applied to my trial Snowflake account.
Attach log
Attach log produced by SnowDDL CLI interface or by your application. Please make sure to include "context" information which is normally produced at the beginning of the log.
snowddl-out.txt
Attach YAML config (if applicable)
It is the included sample01_01 that came with the install.

The account name should be specified with hyphen: GAJVKZJ-OYB90337.
Some more info on this: https://docs.snowflake.com/en/user-guide/admin-account-identifier
Thank you.

Aha! Thank you!


Stay on Ubuntu Trusty on Travis for oraclejdk8

We are hitting build failures as Travis cannot install Oracle JDK 8. It is not available on Xenial, so one way to resolve this is to stay on Trusty. Switching to openjdk8 is another option, but it will hit the Javadoc-related bug. There does exist a workaround (modifying our Javadoc to have fully qualified class names for nested classes) for the Javadoc bug, but I don't really like that.

"Oracle JDK 8 on Trusty" Travis build succeeded, so this should be good: https://travis-ci.org/GoogleContainerTools/jib/jobs/565566417


I'm closing the ticket and blocking you for your misbehaviour.


452 add gias edubase data

Context
This is a spike to import GIAS data and see how it compares to our existing Providers data. It's being considered for merging to master so we can run it in production.
Changes proposed in this pull request

Add webpacker and so the API is no longer strictly only an API.
Add GIAS pages to import and explore GIAS data.
Add DSI integration to ensure only admins can view the GIAS pages.

Guidance to review
We want to make sure that only admins can view these pages, and that adding webpacker and everything else does not impact the API aspect of this service. This change should be pretty thoroughly tested before merging to master.
More details for how to test the importing, etc, to come.
Checklist

[ ] Make sure all information from the Trello card is in here
[ ] Attach to Trello card
[ ] Rebased master
[ ] Cleaned commit history
[ ] Tested by running locally

 [M] Add DSI integration to TTAPI (on the GIAS data branch)

Being replaced with 2 other PRs.


[ErrorWithContext] Create a new ErrorWithContext type and add it to the operational tool.

Motivation
This PR adds a new ErrorWithContext type: a wrapper around std::error::Error that provides an additional struct in which to hold auxiliary information about the context of an error object, e.g., where the error originated from in the source code, such as the error backtrace. This is useful for:

Debugging, e.g., when an error is thrown or displayed on the console but the error message isn't helpful enough to identify exactly what went wrong. So instead of having to grep for the failure message in the code and manually figure out what happened, we can see the backtrace! 😄
Updating panic! related code to use errors instead of forcing panics and not lose context (e.g., see the conversation in this issue regarding how removing panics prevents the backtrace from being displayed: https://github.com/libra/libra/pull/5617). ErrorWithContext provides the best of both worlds between panic and error handling.

This PR offers three commits:

First, we create the ErrorWithContext type and place it in common.
Second, we update the Operational tool to use the ErrorWithContext type as a way to show how it works in practice.
Third, we update the summaries in the code (as required by land blocking tests)

See the section below for how the ErrorWithContext type is formatted when printed.
Have you read the Contributing Guidelines on pull requests?
Yes.
Test Plan
When using the operational tool and encountering an error,  the tool successfully prints out the backtrace of the Error (i.e., where the error was created, and thus the error failure point!). See the example below (this is without using any backtrace env variables!).
Without ErrorWithContext:
joshlind@joshlind-mbp debug % ./libra-operational-tool account-resource --json-server <JSON SERVER> --account-address<PHONE_NUMBER>0000000000000000000000
{
  "Error": "Failed to read 'account-state' from JSON-RPC: Data does not exist. Missing data: AccountState"
}

Above, we can see that the debuggability of the error just comes down to how clear the error message is. In many cases, it's not super helpful without knowing exactly what's going on and digging through the code... Now with ErrorWithContext:
joshlind@joshlind-mbp debug % ./libra-operational-tool account-resource --json-server <JSON SERVER> --account-address<PHONE_NUMBER>0000000000000000000000
{
  "Error": "Failed to read 'account-state' from JSON-RPC: Data does not exist. Missing data: AccountState"
}
Backtrace:
    0: libra_error_with_context::ErrorWithContext<T>::new
             at /Users/joshlind/Facebook/Libra/Code/fork/libra/common/error-with-context/src/lib.rs:28
   1: <libra_error_with_context::ErrorWithContext<T> as core::convert::From<T>>::from
             at /Users/joshlind/Facebook/Libra/Code/fork/libra/common/error-with-context/src/lib.rs:87
   2: <T as core::convert::Into<U>>::into
             at /Users/joshlind/.rustup/toolchains/1.45.2-x86_64-apple-darwin/lib/rustlib/src/rust/src/libcore/convert/mod.rs:559
   3: libra_operational_tool::json_rpc::JsonRpcClientWrapper::account_state::{{closure}}
             at /Users/joshlind/Facebook/Libra/Code/fork/libra/config/management/operational/src/json_rpc.rs:41
   4: core::result::Result<T,E>::map_err
             at /Users/joshlind/.rustup/toolchains/1.45.2-x86_64-apple-darwin/lib/rustlib/src/rust/src/libcore/result.rs:612
   5: libra_operational_tool::json_rpc::JsonRpcClientWrapper::account_state
             at /Users/joshlind/Facebook/Libra/Code/fork/libra/config/management/operational/src/json_rpc.rs:39
   6: libra_operational_tool::json_rpc::JsonRpcClientWrapper::account_resource
             at /Users/joshlind/Facebook/Libra/Code/fork/libra/config/management/operational/src/json_rpc.rs:102
   7: libra_operational_tool::account_resource::AccountResource::execute
             at /Users/joshlind/Facebook/Libra/Code/fork/libra/config/management/operational/src/account_resource.rs:37
   8: libra_operational_tool::command::Command::execute
             at /Users/joshlind/Facebook/Libra/Code/fork/libra/config/management/operational/src/command.rs:120
   9: libra_operational_tool::main
             at /Users/joshlind/Facebook/Libra/Code/fork/libra/config/management/operational/src/main.rs:9
  10: std::rt::lang_start::{{closure}}
             at /Users/joshlind/.rustup/toolchains/1.45.2-x86_64-apple-darwin/lib/rustlib/src/rust/src/libstd/rt.rs:67
  11: std::rt::lang_start_internal::{{closure}}
             at /rustc/d3fb005a39e62501b8b0b356166e515ae24e2e54/src/libstd/rt.rs:52
      std::panicking::try::do_call
             at /rustc/d3fb005a39e62501b8b0b356166e515ae24e2e54/src/libstd/panicking.rs:297
      std::panicking::try
             at /rustc/d3fb005a39e62501b8b0b356166e515ae24e2e54/src/libstd/panicking.rs:274
      std::panic::catch_unwind
             at /rustc/d3fb005a39e62501b8b0b356166e515ae24e2e54/src/libstd/panic.rs:394
      std::rt::lang_start_internal
             at /rustc/d3fb005a39e62501b8b0b356166e515ae24e2e54/src/libstd/rt.rs:51
  12: std::rt::lang_start
             at /Users/joshlind/.rustup/toolchains/1.45.2-x86_64-apple-darwin/lib/rustlib/src/rust/src/libstd/rt.rs:67
  13: _main

Frame 3 shows you exactly where the error was created and what failed. 😄
Related PRs
If we're happy to land this, I'll follow up with another PR that does the same for the genesis tooling.

I'd recommend looking at eyre or anyhow instead of reimplementing behavior that these libraries already handle so well

I'd recommend looking at eyre or anyhow instead of reimplementing behavior that these libraries already handle so well

Thanks @bmwill. I wasn't aware of eyre! Although, from what I can tell:

anyhow requires nightly and also for you to set the various RUST_BACKTRACE* env variables.
eyre, also requires you setting the various RUST_BACKTRACE* env variables (https://docs.rs/eyre/0.6.0/eyre/).

I guess the issue is whether or not we think it's a good assumption for operational tool users to be required to set these variables, or if we should do it programmatically.. Looking at it now though, it might be better to adopt one of these and just require the env variables to be set. I'd rather avoid re-inventing the wheel and having to manage this debt going forward.
@davidiw, I'll just close this PR and can revisit this idea sometime in the future. It would be nice to have backtraces for the operational tool (but then again, it would be nice to have a lot of things 😄). As @bmwill pointed out, this probably isn't the best approach in which to do it. Note: we'll also need to see how bad these deps are using 'dep-hell', before adopting them. The backtrace one I prototyped in this PR wasn't that bad.


Custom Directed Graph by hiding basic blocks

Hey. Thanks for the great API!
I'm well-aware that it is possible to highlight specific blocks in graph view. I'm looking for a way to "isolate" specific blocks, possibly in a new view, without destroying the graph view.
The process will be as follows:

Make a dialog that takes a bunch of addresses (doable now)
Binja would highlight the blocks (doable now)
Binja would either "hide" all other blocks for that function, or transfer the highlighted blocks to another view for easier viewing, while retaining the control flow fo the highlighted blocks.

Let me know if this is doable. What I reached so far is to color the other blocks differently, which doesn't look great TBH

Found exactly what I was looking for here: https://api.binary.ninja/binaryninja.flowgraph-module.html#binaryninja.flowgraph.FlowGraph
Much obliged :D

@afjoseph So I think this is primarily a documentation issue. I've just pushed a change to the pydoc for the basic_block property to clarify that setting the basic_block property of a FlowGraphNode is NOT going to cause that node to necessarily take on the lines of text from the original block to appear in the flowgraphnode. This property is used to associate the two which is used for some of the rendering but you'll want to set the .lines property based on the lines / tokens from the basic block. Here's an example that will be closer to what you want:
graph = FlowGraph()
node_a = FlowGraphNode(graph)
node_a.basic_block = current_function.basic_blocks[0]
node_a.lines = [x[0] for x in current_function.basic_blocks[0]]
node_b = FlowGraphNode(graph)
node_b.basic_block = current_function.basic_blocks[1]
node_b.lines = [x[0] for x in current_function.basic_blocks[1]]
graph.append(node_a)
graph.append(node_b)
node_a.add_outgoing_edge(BranchType.UnconditionalBranch, node_b)
show_graph_report("Custom Graph", graph)

So I think the API as shown above is the intended solution -- I don't think we plan to add any native UI workflow to enable this, but you're welcome to build a user-plugin that could do it if you like. Let me know if you have any issues with the sample above! I will note that it currently is very simplified and doesn't use the disassemblysettings to objects to control whether the address or bytes are shown unlike the other views, but it could be expanded to do that if desired.

Many thanks, @psifertex! This is exactly what I wanted!


Parquet reader improvements

Organize parquet->zng transcoding around the parquet types instead of
zng types
Skip over un-typed repeated elements for now
Handle parquet timestamp times (not yet tested)
Use original parquet column names for zng field names instead of
names that have been mangled for go structures.

I did some manual testing with this branch & reported a few issues where were addressed. There should be some unit tests for those cases.

For posterity, the bugs to be tested:

zng array types created from the reader weren't getting type ids assigned.  A test for that entails reading a parquet file with a LIST in the schema.
OpenParquet() wasn't passing the resolver.Context into the reader.  This can be tested by reading two parquet files with different schemas.


Fix make serve-spin

Something about this example requires the --allow-transient-write flag to be enabled on spin up

Thanks for the PR @kingdonb!  Pinging @adamreese to see if there's extra context on why this flag is needed.  Needs to write to env.rb or other loaded assets?

Thanks for looking at this!


World.update_object does not sample pose as documented

In 3.1.0, the documentation of World.update_object contains:
:param pose: Pose of the location. If none is specified, it will be sampled.

But in reality it just issues a warning and leaves the pose as is
 if loc is not None:
     if pose is None:
         warnings.warn("Cannot specify a location without a pose.")

It would be nice if the sampling behavior supported by World.add_object was supported
here as well, but short of that the documentation should be updated.

Nice catch again! Addressing in https://github.com/sea-bass/pyrobosim/pull/287


languages cannot be set in the profile

Instead of giving all languages at the commandline, it should be possible to set them in the profile.
Before:
xliffmerge en de fr it
After:
xliffmergeconfig.json:
{..
  "languages": ["en", "de", "fr", "it"],
  ..
}
commandline:
xliffmerge --profile xliffmergeconfig.json

fixed in version 0.1

fixed in version 0.1


Unable to update legend position options at runtime

Updating options on existing charts
As documented, you can change existing options changing chart.options setting new values at runtime.
I'm trying to change the legend options as following:
myChart.options.legend.position = 'left';
myChart.update();

and then the legend on chart should be moved on the left.
Current Behavior
Using the dist/master library, the behavior is that t the first "update" this is the result:

If I invoke the update again (setting again to left), it works:

Steps to Reproduce
https://codepen.io/stockinail/pen/pogRZEb
Environment

Chart.js version: dist/master
Browser name and version: FF 77.0.1

Great catch @stockiNail. Turns out it was caused by another bug fix, so needed to split the plugin update so that some happens before the layout pass and some happens after.


Fix: "Uncaught ReferenceError: _interval" #92

Thank you @fffx! 🍰

Hey @nikolalsvk, what's the ETA on releasing this?

Hey @gradybarrett, I'll try to do it over the weekend.

I've just released new version 2.1.3! Feel free to check if everything is OK https://rubygems.org/gems/render_async/versions/2.1.3


Brightness Question!

Hello to start off I want to say thankyou so much for your guide! I would never be able to fix sleep withought your binary patching guide! I have a t431s thinkpad and my brightness at boot is always around 75% of the actual brightness even when it says its full. But when I close the lid and sleeps (thx to you :) and I open it the brightness actually goes to 100%. I was wondering if this crossed with the brightness issue on your end as well. When I get home im going to try to use your boot-arg to see if it fixes anything!

This happened to me when using the SSDT-PNLF generated by SSDTtime. Since then, I've switched to the SSDT-PNLF Sample contained in the OpenCore Package. Read the comments in the .dsl file for modifying the template.

Thankyou so much!!!!! Do you have any donations???

No, but if you like Synthwave music you could buy my music on bandcamp if you like it: https://stansteez.bandcamp.com/music


Render the entire page

Attach (recommended) or Link to PDF file here:
Configuration:

Web browser and its version: Chrome 76.0.3809.132
Operating system and its version:Windows 7
PDF.js version:2.2.228
Is a browser extension:

Steps to reproduce the problem:
1.
When I import a 10-page pdf，i want to render the entire page,But it just renders the page I've located.
In the old version,i change the DEFAULT_CACHE_SIZE = 100,It is OK.
But when i upgrade the version to 2.2.228,it is not what i expected,What should i do?Thanks~
What is the expected behavior? (add screenshot)
What went wrong? (add screenshot)
Link to a viewer (if hosted on a site other than mozilla.github.io/pdf.js or as Firefox/Chrome extension):

In the old version,i change the DEFAULT_CACHE_SIZE = 100,It is OK.

That's not recommended, please see https://github.com/mozilla/pdf.js/wiki/Frequently-Asked-Questions#allthepages

In the old version,i change the DEFAULT_CACHE_SIZE = 100,It is OK.

That's not recommended, please see https://github.com/mozilla/pdf.js/wiki/Frequently-Asked-Questions#allthepages
Can you tell me how How to render a full PDF? Thank you very much~ @Snuffleupagus

As is clearly outlined in the link I posted above rendering an entire file is not a good idea, hence that's not going to be officially supported.
(The only way to make it work would probably be to modify the BaseViewer._getVisiblePages method to always treat all pages as visible.)


Methods count is not 0, but visualizer says no call data

The console output when I run:
Output file: /Users/sbaker/Library/Caches/IntelliJIdea2018.1/flamegraph-profiler/log/take6/ImageServiceTest.removeMetadataFromJpegPhotoTest (1)-2018-04-27-13_06_21.ser
Configuration:
Including patterns:
	com.raveu.utility.*.*(*+)
	javax.imageio.*(*+)
	com.drew.*.*(*+)Methods count: 34

However, when I open results I always see:
Call tree is unavailable for this file
The ser file created is about 2MB.

Appears to work now after renaming the file.

Good


[BUG] Hero Carousel Widget Navigation Arrows Block Clickability

Describe the bug
The center of the carousel viewport is blocked by the element that contains the left / right arrows.
To Reproduce
Steps to reproduce the behavior:

Go to https://opensearch.org/
Click on the hero carousel item that announces the latest release.
Notice that the carousel item area of the same height of the arrows is not clickable.

Expected behavior
The entire carousel viewport should be clickable.
Note: this is patched by PR https://github.com/opensearch-project/project-website/pull/2307

Resolved in https://github.com/opensearch-project/project-website/pull/2307


mill.contrib.bloop: Importing build fails and reports an IvyDependency resolution error.

I'm seeing an error when I try to import the following build.sc.
Metals Server:
0.11.12+161-977d53e3-SNAPSHOT
Mill:
0.11.1
Scala:
3.3.0
Java:
11.0.19
Note: I'm using a .mill-version file.
build.sc
import mill._, scalalib._

object app extends RootModule with ScalaModule {
  def scalaVersion = "3.3.0"

  def ivyDeps = Agg(
    ivy"dev.zio::zio:2.0.15",
    ivy"dev.zio::zio-streams:2.0.15",
    ivy"org.scalafx::scalafx:20.0.0-R31"
  )
}

Metals log
2023.07.04 07:57:51 INFO  running '/home/me/projects/scala/zio-scalafx/.metals/millw --mill-version 0.11.1 --import ivy:com.lihaoyi::mill-contrib-bloop: mill.contrib.bloop.Bloop/install'
2023.07.04 07:57:51 INFO  time: code lens generation in 3.52s
2023.07.04 07:57:55 INFO  [info] compiling 1 Scala source to /home/me/projects/scala/zio-scalafx/out/mill-build/compile.dest/classes ...
2023.07.04 07:58:00 INFO  [info] done compiling
2023.07.04 07:58:00 INFO  1 targets failed
2023.07.04 07:58:00 INFO  resolvedIvyDeps Failed to load dependencies
2023.07.04 07:58:00 INFO    not found: https://repo1.maven.org/maven2/org/openjfx/javafx-base/20/javafx-base-20-${javafx.platform}.jar
2023.07.04 07:58:00 INFO    not found: https://repo1.maven.org/maven2/org/openjfx/javafx-controls/20/javafx-controls-20-${javafx.platform}.jar
2023.07.04 07:58:00 INFO    not found: https://repo1.maven.org/maven2/org/openjfx/javafx-fxml/20/javafx-fxml-20-${javafx.platform}.jar
2023.07.04 07:58:00 INFO    not found: https://repo1.maven.org/maven2/org/openjfx/javafx-graphics/20/javafx-graphics-20-${javafx.platform}.jar
2023.07.04 07:58:00 INFO    not found: https://repo1.maven.org/maven2/org/openjfx/javafx-media/20/javafx-media-20-${javafx.platform}.jar
2023.07.04 07:58:00 INFO    not found: https://repo1.maven.org/maven2/org/openjfx/javafx-swing/20/javafx-swing-20-${javafx.platform}.jar
2023.07.04 07:58:00 INFO    not found: https://repo1.maven.org/maven2/org/openjfx/javafx-web/20/javafx-web-20-${javafx.platform}.jar
2023.07.04 07:58:01 INFO  time: ran 'mill bloopInstall' in 9.93s
2023.07.04 07:58:01 ERROR Mill command failed: /home/me/projects/scala/zio-scalafx/.metals/millw --mill-version 0.11.1 --import ivy:com.lihaoyi::mill-contrib-bloop: mill.contrib.bloop.Bloop/install

Have you tried to run Mill on the CLI without Metals or Bloop? I think your issue not related to Bloop or Metals but Mill specific coursier thing.
By default, Mill tries to be reproducible, so we don't resolve platform dependent dependencies, but JavaFX uses platform properties. You need to customize your coursier resolver. Please read the comment of CoursierModule.resolutionCustomizer.
https://github.com/com-lihaoyi/mill/blob/ccbad36a93ae5d735a3a7a6b58c8e81473480625/scalalib/src/mill/scalalib/CoursierModule.scala#L66-L83

I think I did. You mean like this?
$ mill run
[build.sc] [23/49] mandatoryIvyDeps.super.mill.scalalib.JavaModule.mandatoryIvyD[build.sc] [33/49] enablePluginScalacOptions.super.mill.scalalib.ScalaModule.ena[build.sc] [38/49] scalacPluginClasspath.super.mill.scalalib.ScalaModule.scalacP[build.sc] [41/49] compile
[info] compiling 1 Scala source to /home/me/projects/scala/zio-scalafx/out/mill-build/compile.dest/classes ...
[info] done compiling
[23/48] resolvedIvyDeps
1 targets failed
resolvedIvyDeps Failed to load dependencies
  not found: https://repo1.maven.org/maven2/org/openjfx/javafx-base/20/javafx-base-20-${javafx.platform}.jar
  not found: https://repo1.maven.org/maven2/org/openjfx/javafx-controls/20/javafx-controls-20-${javafx.platform}.jar
  not found: https://repo1.maven.org/maven2/org/openjfx/javafx-fxml/20/javafx-fxml-20-${javafx.platform}.jar
  not found: https://repo1.maven.org/maven2/org/openjfx/javafx-graphics/20/javafx-graphics-20-${javafx.platform}.jar
  not found: https://repo1.maven.org/maven2/org/openjfx/javafx-media/20/javafx-media-20-${javafx.platform}.jar
  not found: https://repo1.maven.org/maven2/org/openjfx/javafx-swing/20/javafx-swing-20-${javafx.platform}.jar
  not found: https://repo1.maven.org/maven2/org/openjfx/javafx-web/20/javafx-web-20-${javafx.platform}.jar

I added this to the build.sc and the resolution error vanished.
override def resolutionCustomizer = T.task {
  Some( (r: coursier.core.Resolution) =>
    r.withOsInfo(coursier.core.Activation.Os.fromProperties(sys.props.toMap))
  )
}

Metals now shows the JavaFX dependencies but still, I cannot run the app.
$ mill run
[36/48] finalMainClass
1 targets failed
finalMainClass No main class specified or found

$ mill app.runMain Main
[build.sc] [44/49] cliImports
Cannot resolve app.runMain. Try `mill resolve _` to see what's available.

mill app.compile
[build.sc] [44/49] cliImports
Cannot resolve app.compile. Try `mill resolve _` to see what's available.

Closing this, as you could solve it with the documented way.
About the other issue. You should validate the usual settings of your project, e.g. checking the correct source dirs, checking the compiles classes, etc...
$ mill show __.sources
$ mill show __.allSourceFiles

@lefou Well, I have the exact same project layout I usually have. Folder structure etc is like the documentation recommends. I checked it several times. There is absolutely no difference to what I usually have setup.
.
├── app
│   └── src
├── build.sc
└── out

mill show __.sources
[build.sc] [23/49] mandatoryIvyDeps.super.mill.scalalib.JavaModule.mandatoryIvyD[build.sc] [33/49] enablePluginScalacOptions.super.mill.scalalib.ScalaModule.ena[build.sc] [38/49] scalacPluginClasspath.super.mill.scalalib.ScalaModule.scalacP[build.sc] [41/49] compile
[info] compiling 1 Scala source to /home/me/projects/scala/zio-scalafx/out/mill-build/compile.dest/classes ...
[info] done compiling
[1/1] show > [1/1] sources
[
  "ref:v0:c984eca8:/home/me/projects/scala/zio-scalafx/src"
]

I guess it should be projects/scala/zio-scalafx/app/src. I have no idea why it's not picked up correctly. Never had this issue before. I delete .bloop out and .metals. No change.

You use the new RootModule, introduced in Mill 0.11, which only purpose is to remove the first directory level, in your case the app. Either remove the the RootModule or adapt to the layout.


issue #297

fixed incorrect path of overview in contribute.md

These are meant to work on the live site at https://lbry.tech/conribute, which they do.


new Activity ValuedParam

Pull Request Description
What issue does this change request address?
Closes #84
What are the significant changes in functionality due to this change request?
Adds the <activity> node, which does a simple lookup of dispatch activity for the associated component.
For example, if a <Produces> component consumes steam to make electricity, a CashFlow might include the driver:
<driver>
  <activity>steam</activity>
  <multiplier>-1</multiplier>
</driver>

to suggest a cashflow of -1 * amount of steam consumed (negative * negative makes positive).

For Change Control Board: Change Request Review
The following review must be completed by an authorized member of the Change Control Board.

[ ] 1. Review all computer code.
[ ] 2. If any changes occur to the input syntax, there must be an accompanying change to the user manual and xsd schema. If the input syntax change deprecates existing input files, a conversion script needs to be added (see Conversion Scripts).
[ ] 3. Make sure the Python code and commenting standards are respected (camelBack, etc.) - See on the wiki for details.
[ ] 4. Automated Tests should pass.
[ ] 5. If significant functionality is added, there must be tests added to check this. Tests should cover all possible options.  Multiple short tests are preferred over one large tes.
[ ] 6. If the change modifies or adds a requirement or a requirement based test case, the Change Control Board's Chair or designee also needs to approve the change.  The requirements and the requirements test shall be in sync.
[ ] 7. The merge request must reference an issue.  If the issue is closed, the issue close checklist shall be done.
[ ] 8. If an analytic test is changed/added, the the analytic documentation must be updated/added.
[ ] 9. If any test used as a basis for documentation examples have been changed, the associated documentation must be reviewed and assured the text matches the example.

Before this is merged, there's one thing I need to fix, and that's error checking on the resource named.


Grey out hops which did not update in the current round

This is needed because of the issue discussed in https://github.com/fujiapple852/trippy/issues/269


Add linux support

Recreate the Linux plugin directory as the previous iteration was based on the app flutter template, not the correct plugin template.
Add CMakeLists.txt additional configuration in the Linux dir to download and compile Tensorflow-lite automatically during flutter build.
Add platform config in pubspec.yaml for linux so that we can target Linux during build.

Signed-off-by: Dani Llewellyn<EMAIL_ADDRESS>

@diddledani did you get this plugin to work with building a snap on linux?
I am manually copying the TF lite binary with the dump plugin but then encounter the issue:
Failed to load dynamic library '/snap/dakanji/x1/bin/blobs/libtensorflowlite_c-linux.so': /lib/x86_64-linux-gnu/libm.so.6: version `GLIBC_2.29' not found (required by /snap/dakanji/x1/bin/blobs/libtensorflowlite_c-linux.so

Do you have any idea how to get the right GLIBC in my app?

Thanks a lot Dani, for the PR.


lossless floating point formatting

moi667 reported this on 2009-08-12T10:31:08Z
Transfered from https://issues.dlang.org/show_bug.cgi?id=3248
CC List

andrei (@andralex)
ben.james.jones
bugzilla (@WalterBright)
clugdbug
smjg
uplink.coder
yebblies

Description
Could an option be added to the formatting to elide trailing zero's for %f ?
That way it is possible to create an optimal lossless formatting for which the
following holds:

float f;
s = format(f);
float f2 = to!(float)(s);
assert(f==f2);

The formatting I'm trying to get can be seen here (decimal):
http://www.h-schmidt.net/FloatApplet/IEEE754.html

%g fails to format like this because it uses %f for as small as 10^-5,
thus loosing precision for floats with leading zero's, like 0.00001234567.

Fixing this by using %f for 10^-5..10^-1 fails because it doesn't elide trailing zero's making it suboptimal space-wise.

It would be even nicer to have this lossless formatting added to std.format!
I would even suggest making this the default formatting for floating point; floating point isn't as straight forward as integral and it is easy to think the current formatting holds all information.

Compared to the hex %a format this new lossless format will be better readable (less bug-prone) and generally shorter (0.1 will be 0.1).

clugdbug commented on 2009-08-12T12:22:26Z
It's not that easy, actually. When should it print 0.09999999999999999, and when should it print 0.1 ? The code to do it correctly is amazingly complicated.
Just be aware that what you're asking for is much more difficult than you probably imagine.

smjg commented on 2009-08-12T18:21:21Z
I can see a few possible approaches to lossless floating point formatting:

(a) decimal with infinite precision, minus trailing zeros
(b) minimum number of significant figures guaranteed to be unique, minus trailing zeros
(c) the shortest possible string that, when parsed as a floating point, is exactly this number

(a) clearly isn't what the reporter is asking for.

(b) seems straightforward.  (Is the number of s.f. in question just the .dig property?)

(c) is optimal, and could probably be implemented quite simply (not sure whether it would be most efficient though) with the aid of the nextUp and nextDown functions.  This would also address the question in comment 1, though I'm not sure how easy it would be to implement this efficiently.

But (b) and (c) are ambiguous: do we go by uniqueness/exactitude in the real type or in the actual floating point type being used?  I can see that sometimes the app'll know what type it will later be read into, and sometimes it won't.

moi667 commented on 2009-08-12T19:45:28Z
As far as I understand it, removing trailing zeros from .8 precision and (c) are the same.
This is because the first (right to left) non-zero you encounter is there because of 2^x.

I actually used nextUp to test a few ranges of floats :) (I have a not so fast computer)

I remember .dig being 6 for all floats (could be wrong here, not close to any dmd.exe)

moi667 commented on 2009-08-12T15:40:10Z
(In reply to comment #1)
> It's not that easy, actually. When should it print 0.09999999999999999, and
> when should it print 0.1 ? The code to do it correctly is amazingly
> complicated.
> Just be aware that what you're asking for is much more difficult than you
> probably imagine.

It is less difficult than you imagine :)

Lets take floats:

A float has at most 24bits of precision

2^-24 = 0.000000059604644775390625
2^-23 = 0.00000011920928955078125

to distinguish between these two you only need a precision of 8.

Thus %.8e will always be lossless but isn't always the nicest way of representation. %g fixes this by using %f if the exponent for an e format is greater than -5 and less than the precision. The less than precision part is correct, but the greater than 10^-5 is bad as the precision specifies the number of digits generated after the decimal point; not excluding leading zeros.
If %g would be changed to use %f only between 10^-1 and precision that would solve that problem, if %f were to elide trailing zeros.

Back to the 0.1 question. 0.1 is actually saved as 0.1000000012...
Eliding trailing zeros from %f.8 would be sufficient to get 0.1

andrei (@andralex) commented on 2009-08-12T22:43:37Z
I recommend anyone interested in the subject to peruse the papers:

"How to Read Floating Point Numbers Accurately"
ftp://ftp.ccs.neu.edu/pub/people/will/howtoread.ps

and

"Printing Floating-Point Numbers Quickly and Accurately"
www.cs.indiana.edu/~burger/FP-Printing-PLDI96.pdf

smjg commented on 2009-09-07T04:41:58Z
> Neither. It's the number of sic figs which are accurate in the worst case. So
> it's the _minimum_ number of digits which are stored. To unambiguously define
> the number, more digits are almost always required.

So, if you try to put a decimal number into a float, it's how many s.f. you can get out again and be sure they'll be the same.  I don't see in what cases this differs from "the number of s.f. to which numbers are guaranteed to be storeable unambiguously"....

bugzilla (@WalterBright) commented on 2009-08-14T22:47:28Z
Right, this problem is an old one, and there's no reason to reinvent the wheel.
Also, the formatting for them works by simply forwarding the job to the underlying C library. Some C implementations of this are better than others.

moi667 commented on 2009-09-07T11:24:37Z
(In reply to comment #9)
> (In reply to comment #8)
> > (In reply to comment #4)
> > > As far as I understand it, removing trailing zeros from .8 precision and (c)
> > > are the same.
> >
> > I doubt it ... I think the optimal number of decimal s.f. would depend on the
> > binary exponent.  But I'll experiment when I have time.

You are correct, removing trailing zeros from %.8e isn't optimal, but I thought it was at least lossless..

>
> You are correct. Some numbers need an extra digit.
>

Could you maybe provide one?
As I did some ranges with nextUp and didn't find any.

A near optimal lossless formatting is fine too :)

clugdbug commented on 2009-09-07T05:02:15Z
(In reply to comment #10)
> > Neither. It's the number of sic figs which are accurate in the worst case. So
> > it's the _minimum_ number of digits which are stored. To unambiguously define
> > the number, more digits are almost always required.
>
> So, if you try to put a decimal number into a float, it's how many s.f. you can
> get out again and be sure they'll be the same.  I don't see in what cases this
> differs from "the number of s.f. to which numbers are guaranteed to be
> storeable unambiguously"....

It may be the same. I wasn't quite sure what you meant by "unambiguously". In both directions binary<->decimal there is nearly always more than one choice.

moi667 commented on 2009-08-15T09:55:41Z
Does this mean I can forget about getting this in phobos?
Could then at least an option be added to remove those trailing zeros for %f?
I don't see why %g should be that privileged ;)

smjg commented on 2009-09-07T02:58:19Z
(In reply to comment #4)
> As far as I understand it, removing trailing zeros from .8 precision and (c)
> are the same.

I doubt it ... I think the optimal number of decimal s.f. would depend on the binary exponent.  But I'll experiment when I have time.

> I remember .dig being 6 for all floats (could be wrong here, not close to any
> dmd.exe)

The spec describes .dig as "number of decimal digits of precision", which seems ambiguous.  Is it a property of the type or the value?  If it's a type property, is it the maximum number of s.f. that may be required to express a number of the type unambiguously, or the number of s.f. to which numbers are guaranteed to be storeable unambiguously?  If a value property, it is the number of s.f. according to which of the approaches I listed, or something else?

clugdbug commented on 2009-09-07T04:25:35Z
(In reply to comment #8)
> (In reply to comment #4)
> > As far as I understand it, removing trailing zeros from .8 precision and (c)
> > are the same.
>
> I doubt it ... I think the optimal number of decimal s.f. would depend on the
> binary exponent.  But I'll experiment when I have time.

You are correct. Some numbers need an extra digit.

> > I remember .dig being 6 for all floats (could be wrong here, not close to any
> > dmd.exe)
>
> The spec describes .dig as "number of decimal digits of precision", which seems
> ambiguous.  Is it a property of the type or the value?

It's a property of the type.

 If it's a type
> property, is it the maximum number of s.f. that may be required to express a
> number of the type unambiguously, or the number of s.f. to which numbers are
> guaranteed to be storeable unambiguously?

Neither. It's the number of sic figs which are accurate in the worst case. So it's the _minimum_ number of digits which are stored. To unambiguously define the number, more digits are almost always required.

yebblies commented on 2014-11-04T08:10:33Z
(In reply to hsteoh from comment #13)
> Wouldn't the most lossless format be to just dump the representation in
> hexadecimal (i.e., in the same format as a hexadecimal float literal)? That
> way you're guaranteed that you don't get excess precision where there is
> none, nor do you lose any bits.

That would no longer be human-readable.

andrei (@andralex) commented on 2015-11-03T19:26:59Z
Anyone working on this?

ben.james.jones commented on 2019-04-16T04:27:32Z
I'd be interested in taking a stab at this based on the new algorithm presented here: https://dl.acm.org/citation.cfm?id=3192369 .  STL (the person) has been tweeting about adding this to the MS STL (the library) implementation for char_conv in C++ 17(?) and it sounds like a big speed win in addition to having nice round trip properties.  Currently formatValueImpl seems to just call snprintf.

uplink.coder commented on 2019-04-16T08:01:27Z
@Ben I already have a ctfeable implementation which is lossless for doubles.
I am going to push it to druntime soon

hsteoh commented on 2014-09-19T21:33:16Z
Wouldn't the most lossless format be to just dump the representation in hexadecimal (i.e., in the same format as a hexadecimal float literal)? That way you're guaranteed that you don't get excess precision where there is none, nor do you lose any bits.


Implementierungsaufwand abwägen.
Implementieren, evtl. in C++, sonst wahrscheinlich in Python."

Discuss this with Attila from the VRVis. One option is AliceVision.
Another, more experimental, solution is to try a NeRF with surface extraction.

i would prefer Nerfstudio because it has a nicer license

Nerfstudio just released a new version with NeuS and NeuSFacto model based on this paper: https://arxiv.org/pdf/2106.10689.pdf
Could be worth a try.

interesting paper by a colleague: https://repo-sam.inria.fr/fungraph/3d-gaussian-splatting/
maybe wait and see if it will be included in nerfstudio

another interesting work that could replace COLMAP: https://openaccess.thecvf.com/content/CVPR2023/papers/Li_Neuralangelo_High-Fidelity_Neural_Surface_Reconstruction_CVPR_2023_paper.pdf

and another: https://liuyuan-pal.github.io/NeRO/

the experiments so far were not convincing. all nerf methods have either too strict requirements to the inputs (accurate camera poses, images from all sides etc.) or worse quality than COLMAP (although the paper results look better)

had a longer discussion with a visitor... NeuS and derivates are probably the way to go. we care about the geometry, which typical NeRFs can't represent properly.
note that we need a version without segmentation masks that also works on unbounded scenes. apparently, they all depend on COLMAP for camera poses.
NeuS (rather slow): https://github.com/Totoro97/NeuS
NeuDA (slow?): https://github.com/3D-FRONT-FUTURE/NeuDA
NeuS++ (faster, check branch for unmasked): https://github.com/19reborn/NeuS2/tree/neuspp
Instant Neural Surface Reconstruction(fast): https://github.com/bennyguo/instant-nsr-pl
NeRO (slow?, no unbounded scenes?): https://github.com/liuyuan-pal/NeRO
Neuralangelo (need license): https://research.nvidia.com/labs/dir/neuralangelo/
SDFStudio (like NeRFStudio but for reconstruction, check license for angelo): https://github.com/autonomousvision/sdfstudio
most interesting seem SDFStudio and NeuS++

@ErlerPhilipp Hi Philipp. I have recently released a derivative version of Neus and Neuralangelo called Instant-angelo. This new project has a friendly open-source license, higher efficiency, and is fully compatible with Colmap. Additionally, while our current reconstruction pipeline does not use masking, it focuses on reconstructing just the central area within the camera poses' field of view. I hope this new project will be useful to the research community. We provide some visualization of current results. Please let me know if you have any other questions!

Hi @hugoycj ! Thanks, your work looks indeed very interesting.
I have several questions:

There is no official publication, right? Do you plan to publish it?
Are the implementation details described or documented somewhere or should I just look at the code?
Can I download some results as textured meshes? I see only GIFs in your repo.
In case you have the time, I would really appreciate if you could run this example with your method: https://drive.google.com/drive/folders/1AgSzlI884Hezh4ebPBe5dITLAI8fX4He?usp=sharing

Apologies for the delayed response as I am currently occupied with the deadline for a conference.
Instant-Angelo is still in the developmental phase. Its functionality heavily relies on the results obtained through sfm (structure from motion) and may encounter issues if the sfm points are noisy or sparse. Our main objective for developing Instant-Angelo is to provide a useful tool for the community, and we have not yet a plan for publication. However, we intend to create a blog and detailed documentation once I complete the deadline in mid-November.
Currently, only geometry mesh export is supported in Instant-Angelo, but we are working tirelessly to incorporate a new API for exporting textured mesh.
For reference, I have run the example on your provided data. The process takes 2 minutes for structure-from-motion and 20 minutes on 3090 for dense reconstruction. You could download the geometry mesh from this link. Some quick look up results are shown below:

Sorry for the delay on my side, this time. Good luck with your submission!
Thank you so much for running it on our example. This result looks indeed pretty good. Interesting that it creates a hole in the bottom plate while it fills in the space between the feet.
We're currently switching from COLMAP to AliceVision, which is way more modular. Once this is done, we can replace e.g. the SfM/MVS part with a NeRF/NeuS variant. Your method is definitely a hot candidate for that. Thanks!

switching to AliceVision or other methods is too much work for now


[AMR Heatmap] Add Gene Details Sidebar

Description
Allows users to click on a gene (or allele) name in the AMR heatmap and display a sidebar with details for that gene. Pulling from the CARD Ontology, if a match for the gene name is found the sidebar will display the gene name as it appears in CARD, any synonyms for the gene, the gene family, the class of drugs the gene confers resistance to, the resistance mechanism, and peer-reviewed publications that give information about the gene.
At the bottom are links to the CARD Ontology entry, an NCBI AMR Reference Gene Catalog search, a Pubmed search, and a Google Scholar search.
Notes

To implement this functionality two get requests are made, both to the IDSeq backend in order to get around CORS issues. Upon first loading the sidebar asks for the updated CARD Ontology database available on github, and if a gene is found in the ontology it makes a request to the CARD website for additional information.
Apologies for the long diff

Tests

Server-side code should have automated tests - still to do
For client side code, go to All Data page, pick a bunch of samples with AMR Counts (like tb-flash), click on Heatmap Icon and select "AMR Heatmap" from the dropdown, when the heatmap loads hover over node to see the tooltip. Click on the gene names and watch the sidebar details bar pop up.

I think you should move all the parsing into the backend controller. There are a few reasons for this: 1) moves the necessary processing upstream to be cleaner since you have the backend endpoints anyway, 2) keeps our backend contract of returning JSON API responses, 3) avoids parsing stored XML in the frontend (which can be brittle and error-prone anyway), 4) enhances security by allowing for backend validation and cleaning the response passed to the client browsers. You should just assume that all external sources will have malicious data and try to inject code into our backend and the client pages.

Refactoring to add tests and move parsing to backend.

Tests added, parsing moved to the backend, polish added on the frontend. Open again for review!
Will NOT be submitting/merging this PR until legal issues are cleared up. Do not approve until then.


Update test plan

Remove redundancy in test plan and make a smoke test

@melikaeft and @Darshanapujar  working on this task

Modified version of test plan sent for review on slack


Fix hugo author deprecation

Fixes #92
Fixes a deprecated config option Hugo has, and pins Hugo to 0.139.0 so we don't unintentionally hit this again.

CI is failing due to my permissions but succeeded here: https://github.com/iofq/www.aptly.info/actions/runs/11906983424


Morse decoding

In this project, the following was done:

create a method to decode a Morse code character ✅
create a method to decode an entire word in Morse code ✅
create a method to decode the entire message in Morse code ✅

Since the last code review, the following was done

Create a method for decoding single uppercase characters eg: decide_char(".-") returns "A"
Create a method for decoding the entire word and every character in a word will be separated by a single space (e.g. decode_word("-- -.--") returns "MY").
Create a method for decoding the entire message in Morse code and Every word will be separated by 3 spaces (e.g. decode("-- -.--   -. .- -- .") returns "MY NAME").
Reuse methods whenever possible
Make sure that your code is DRY.
Once the code is ready use it to decode the message from the old bottle (      .-   -... --- -..-   ..-. ..- .-.. .-..   --- ..-.   .-. ..- -... .. . ...)


Positive Learning Rate in Optimizer

Hi,
I am using the following code for an sgd solver
optimizer.build_sgd(model, base_learning_rate=0.1, policy="step", stepsize=1, gamma=0.999)

I use workspace.FetchBlob('conv1_b_lr') to fetch the learning rate for every iteration and that results in the plot below. But, its starting point is -0.1 rather than 0.1 hence giving an illusion of rising learning rate.

I believe, the learning rate is being returned with an opposite sign.

@akshay-raj-dhamija do you still have this problem?  The - sign happens if you use WeightedSum (momentum) with SGD.

Thanks @mfawzymkh for your response.
I checked with the latest commit and the issue still exists. I am quite sure I am only using SGD.
The entire code is at http://vast.uccs.edu/~adhamija/blog/MNIST_singleGPU.html. Here, I multiply the learning rate by -1 to obtain the correct graph in cell 24.
Please do let me know in case something seems incorrect.

Hi @mfawzymkh, were you able to narrow down the issue. Is it my usage?


[Question/Feedback]: Deploy LA Workspace Daily Cap Limit Reached Alert remediation fails

Check for previous/existing GitHub issues

[x] I have checked for previous/existing GitHub issues

Description
ALZ_LAWorkspaceDailyCapLimitReached is the only policy that fails to remediate.  When attempting to remediation a standard LZ Management Subscription with a default LZ LA Workspace, I get the following error (RAW):
{
  "code": "DeploymentFailed",
  "message": "At least one resource deployment operation failed. Please list deployment operations for details. Please see https://aka.ms/arm-deployment-operations for usage details.",
  "details": [
    {
      "code": "BadRequest",
      "message": "'where' operator: Failed to resolve scalar expression named 'disable'. A semantic error occurred.. The request had some invalid properties Activity ID: 8fd507bc-dbb8-4b12-8a5f-339b862b9ea8."
    }
  ]
}

This policy shouldn't fail if there's no Daily cap set, or it should show as compliant if there's no cap to alert on.
After setting a 10 gb/d limit I still get the exact same error.

Hello @laingsc ,
thanks for your feedback. I started investigating the code and couldn't find any expression named 'disable'. Moreover, in my test environments I have no daily cap set and the remediation does not fail. In the alert, we are not looking at the daily cap setting, but at the records you would get from the Operation table if a daily cap is set (whatever value it is set to) and the ingestion rate goes OverQuota. I suspect something with the tag name. Could you please share an image with sensitive data obscured where I can see the tagging you applied to the workspace?
Thanks,
Bruno.

@Brunoga-MS thanks heaps and apologies for the late reply, I knew I was forgetting something last week.
The workspace has a custom name and custom tags, have uploaded a screenshot....

Hello @laingsc,
nothing in the screenshots rings a bell. are you remediating manually or through the remediation script?

Manually/via my own script.  I first noticed that it failed on it's own accord however.

@Brunoga-MS  omg, I forgot the most important thing and probably answered my own question:
I've got this defined in the paramaters:
"ALZMonitorDisableTagName": {
  "value": "monitor-disable"
},

@Brunoga-MS have modified the assignment by changing the ALZMonitorDisableTagName from 'monitor-disable' to 'MonitorDisable', and remediation worked fine manually.  However our tagging convention doesn't match that so would be a minor bug.

@laingsc given your feedback, can I close this issue as resolved or is there any suggestion /enhancement that you would recommend?
Thanks,
Bruno.

@Brunoga-MS sorry just seen this comment now.  My suggestion would be allowing tags that contain dashes.

@laingsc , thanks to your last comment I am going to reopen this one since I found the bug responsible for tags containing dashes not working.


Add show/hide on password inputs

Hey, I would like to work on this

this issue has been fixed


Update maintainers.

Autogenerated by the sponsors-maintainers-man-completions workflow.

Sorry this took so long to land @singingwolfboy @razvanazamfirei!


Create 2022-12-13-postfix-monitoring.md

Postfix monitoring use-case

the blog is not in the preview
files need be under /blog/

the blog is not in the preview
files need be under /blog/

Fixed now.


Pseudo C is using incorrect precedence for not operator

Version and Platform (required):

Binary Ninja Version: 3.5.4526
OS: OS X
OS Version: 13.3.1
CPU Architecture: x64

Bug Description:
If in High Level IL the (correct) code is:
if (not(zmm1.d f<= 0f))
Then in Pseudo C it shows:
if ((!zmm1 <= 0f))
Expected Behavior:
if (!(zmm1 <= 0f))

This will be fixed in 3.6.4575


Wrong maxheight calculation for Luna

Describe the bug
My char is not drawn when im on Luna near a wall (not every).
There is something wrong into
CheckIfUnderEntity in GameScene.cs
Screenshots

done


Merge pull request #435 from nightscout/release/0.2.2

Release v0.2.2

Closing because it was an unintentional PR


/dev/shm/mjpeg/cam.jpg not created automatically

I had to touch /dev/shm/mjpeg/cam.jpg manually to get raspimjpeg running. Raspimjpeg refused to start without this file, telling me "Error: Could not open mjpeg-destination". Furthermore, the error from Issue #188 appeared. I'm not sure if this is an issue of the webinterface because I connected the camera wrong on the first try. Please check.

Please forget about this one. I didn't enable the autostart after the installation.


Prototype

This PR includes the first prototype of the app, featuring the first implementation of the data model, as well as a table showing all the inserted data, and a page for each trait showing its details. Closes #3, closes #4 .
I'd like to draw the attention to the data model file (traitcuration/traits/models.py). In particular these points:

The on_delete behaviour of the different models and whether they can ever be deleted or not. Right now I am treating them as such:

In the trait model, if its current mapping is deleted I am setting it to null. If we want to never delete a mapping from the database, the other option would be to protect it from being deleted
I am protecting traits as well as ontology terms  being deleted
With the current implementation, users can be deleted, and when they are, their reviews and comments are set to a null owner

Also regarding the user model. I have created a new one, however Django already has a built in user model for authentication. I suggest we use the custom one for testing, and when we implement actual authentication we could see if it is more convenient. Let me know if you agree
I would also appreciate if you could check the individuals field in the model file and see if any field that should be nullable isn't, and vice versa. (In Django, null means it can be empty in the database, and blank means that that field can be left empty when filling in Django forms. )

The PR has been automatically deployed here https://clinvar-trai-prototype-pmia54t.herokuapp.com/ . You can create and store new data in the database as you please by going to /admin and logging in with admin username and admin password.

I pushed a commit addressing all your comments besides the ones open for discussion. In particular:

Added loading for UIKit via CDN
Turned the status fields into enum (discussion on their computing is pending)
Removed double blank line from settings.py
Made the code in models.py, line 6, single line

I also added the model for reviews, which I accidentally left off of the previous commits


Fix GAR bug with cert upload

When the user uploads a cert and an error occurs, the user is informed that a cert with the same name already exists. However, this is not the case, and instead the cert was not the correct format - raising an exception. The logic behind determining the error message for the user was incorrect. This PR aims to fix that by correcting error logic.
New output:

What were the steps to reproduce before this correction?  Removing the specific method to raise the Value error from the session introducess a bug to detect duplicate certificates as it now reports the wrong error:

Adding ValueError back in corrects this error:

Are we sure the reported issue was using a bad certificate format and not a duplicate?

The issue was that duplicate value errors were being thrown so the session was catching it's own error. I've updated the logic and tested the 3 scenarios: filename duplicate, common name duplicate and invalid certificate.


fix: 虚拟机漂移后设置新的hostId

这个 PR 实现什么功能/修复什么问题:
虚拟机漂移后设置新的hostId
是否需要 backport 到之前的 release 分支:

release/2.10.0

/area region
/cc @swordqiu @yousong

Codecov Report

Merging #3518 into master will decrease coverage by <.01%.
The diff coverage is 0%.

@@            Coverage Diff            @@
##           master   #3518      +/-   ##
=========================================
- Coverage    6.98%   6.97%   -0.01%
=========================================
  Files         498     498
  Lines       83209   83218       +9
=========================================
- Hits         5809    5807       -2
- Misses      76906   76916      +10
- Partials      494     495       +1

Flag
Coverage Δ

#aFlag
6.97% <0%> (-0.01%)
:arrow_down:

Impacted Files
Coverage Δ

pkg/compute/models/guests.go
0.6% <ø> (ø)
:arrow_up:

pkg/compute/models/disks.go
0.62% <0%> (-0.01%)
:arrow_down:

pkg/appsrv/response.go
66.15% <0%> (-3.08%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9ff0629...8f940e4. Read the comment docs.

/approve

/lgtm

/approve


AutoPairs not working with <>

For whatever reason, < > doesn't work in the Auto pairs using         { open: "<", close: ">" },.
I did a quick check and it doesn't seem to be an escaping issue, but not looked into it a lot.

So I managed to chase this down and its the same error occurring in two places.
First, our key resolution package is resolving < as <lt> meaning the opening pair code is never called.
Second, even if it was being called, < is the single special case in nvim_input, such that instead we'd need to pass over <lt>.
Should this be fixed locally, or a more global solution such that it can be re-used? Or has this issue been encountered elsewhere such that the solution can be re-used?
A fix for this for now is to set the opening binding to <lt> rather than <.


Carousel prevent the scroll up and scroll down of the containing page.

Description
The swipe up or swipe down events within the carousel are not propagating.
Carousel should handle only swipe left and swipe right events and don't impact to the the vertical scrolling of the containing page.
Repro Steps
Open the documentation  for th carousel component with a mobile device and try to scroll down or up the page starting the scroll from the carousel component.

Unfortunately the detection of swipe and a direction are not defined or supported in the native APIs of the browser.
I would recommend using Hammer.js http://hammerjs.github.io/recognizer-swipe/
Or other ways (which are less reliable) like http://stackoverflow.com/questions/17567344/detect-left-right-swipe-on-touch-devices-but-allow-up-down-scrolling

I think that we can't prevent the page scrolling when using the carousel from touch devices.
This is annoying when the carousel content fit the height of the device screen

The carousel currently does this, but the threshold for the horizontal movement is pretty low, so a downward angled swipe will often be misinterpreted as horizontal movement

Great , why don't we increase the threshold providing an option ?

The handling of the touchstart event seems to prevent vertical scrolling.
function tap(e) {
    e.preventDefault();
    ...
}

Why do we want to prevent default behaviour for this event? Any chance we can remove this line?

I agree with @winterda, I changed it to
if (e.type === 'mousedown') {
    e.preventDefault();
}

to restore the vertical scroll behaviour on mobile devices but leave it as is on desktop devices.

where did you insert that code? @redboul

@jamesjsewell I guess in the tap method.
This but just a better approach.

I am using the change proposed by @redboul in production code without issues. I have created a PR #4702.

@redboul works like a charm! Thank you!

PR #4702 was merged so that @redboul 's solution is now in master and will be included in the next release.
I suppose this issue can be closed now.

This does restore vertical scrolling on mobile... but breaks horizontal carousel scrolling AND use of the indicators!
Tested with on 0.100.2, was previously on 0.98.2 with the original bug.

Should I open a new issue for touch scroll navigation being broken (which seems pretty major) or should we reopen this one?

Can you show us (in a codepen) that it is still broken?

I just tested all the versions between 0.98.2 and 0.100.2 ...it was indeed fixed in 0.99.0.  Both vertical and horizontal scrolling were working.  Then the larger break happened in 0.100.0.

https://codepen.io/anon/pen/jGGgbm

I agree with @winterda, I changed it to
if (e.type === 'mousedown') {
    e.preventDefault();
}

to restore the vertical scroll behaviour on mobile devices but leave it as is on desktop devices.

Well done, that should do the work for you, it worked well for me.
just copy this above the carousel initial function to override the tap function.


HL7 messages unable to default and undesired expansion of fields

Problem statement
WA review of messages for Prescriptive and Medical Network Solutions uncovered some issues with our handling of messages from HL7 senders.
What you need to know
Missing MSH-3.2 and 3.3
Current
MSH|^~\&|PHX.ProviderReportingService|7uycso49^<IP_ADDRESS>.4.1.386<IP_ADDRESS>.519^ISO| ...

Desired
MSH|^~\&|CDC PRIME - Atlanta, Georgia (Dekalb)^2.16.840.1.114<IP_ADDRESS>821^ISO|7uycso49^<IP_ADDRESS>.4.1.386<IP_ADDRESS>.519^ISO| ...

The incoming message contains PHX.ProviderReportingService. Defaulting the value to CDC PRIME+OID in the schema is not working as expected with HL7.

OBR-25 unnecessary elements
Current
OBR|1|03016507^Meany Middle School^50D2252725^CLIA|03016507^Meany Middle School^50D2252725^CLIA|94558-4^SARS-CoV-2 (COVID-19) Ag [Presence] in Respiratory specimen by Rapid immunoassay^LN^^^^2.68|||202203042159+0000|202203042159+0000||||||||00000^530771003612^Meany Middle School^^^^^^^^^^NPI|2064132100^WPN^PH^^^206^4132100|||||202203042159+0000|||F^Final results^HL70123

Desired
OBR|1|03016507^Meany Middle School^50D2252725^CLIA|03016507^Meany Middle School^50D2252725^CLIA|94558-4^SARS-CoV-2 (COVID-19) Ag [Presence] in Respiratory specimen by Rapid immunoassay^LN^^^^2.68|||202203042159+0000|202203042159+0000||||||||00000^530771003612^Meany Middle School^^^^^^^^^^NPI|2064132100^WPN^PH^^^206^4132100|||||202203042159+0000|||F

The incoming message contains F in OBR-25. Note that it's getting expanded to F^Final results^HL70123. Changing the field to type ID in the schema does not resolve the issue.

OBX-2 and OBX-11 unnecessary elements
Current
OBX|1|CWE^Coded With Exceptions^HL70125|94558-4^SARS-CoV-2 (COVID-19) Ag [Presence] in Respiratory specimen by Rapid immunoassay^LN^^^^2.68|1|260415000^Not detected^SCT|||N^Normal (applies to non-numeric results)^HL70078^^^^2.7|||F^Final results; Can only be changed with a corrected result^HL70085|||202203042159+0000|50D2252725^Meany Middle School^CLIA||10811877011290_DIT^BinaxNOW COVID-19 Ag Card^99ELR^^^^2.68^^10811877011290_DIT||202203042159+0000||||Meany Middle School^^^^^50D2252725^XX^^^50D2252725|301 21st Avenue East^^Seattle^WA^98112

Desired
OBX|1|CWE|94558-4^SARS-CoV-2 (COVID-19) Ag [Presence] in Respiratory specimen by Rapid immunoassay^LN^^^^2.68|1|260415000^Not detected^SCT|||N^Normal (applies to non-numeric results)^HL70078^^^^2.7|||F|||202203042159+0000|50D2252725^Meany Middle School^CLIA||10811877011290_DIT^BinaxNOW COVID-19 Ag Card^99ELR^^^^2.68^^10811877011290_DIT||202203042159+0000||||Meany Middle School^^^^^50D2252725^XX^^^50D2252725|301 21st Avenue East^^Seattle^WA^98112

Same issue as above, CWE and F are expanded to CWE^Coded With Exceptions^HL70125 and F^Final results; Can only be changed with a corrected result^HL70085

Acceptance criteria

[ ] State message segments match the "desired" output.

PHX.ProviderReportingService is coming from prescryptive-sample1a.hl7.

Need to be reviewed and approved by @jbiskie


Proposal: Add the concept of ErrorHandler

In some cases I met the need for something which is able to log/report an error in a library without actually returning it to the caller.
A typical example is when you loop through a list of elements and call a method on them which might return an error without causing the application to get into an erroneous state:
errorHandler := ...
handlers := ...

func Shutdown() {
	// Try recovering from panic first
	err := errors.Recover(recover())
	if err != nil {
		errorHandler.Handle(err)
	}

	// Loop through all the handlers and call them
	// Log any errors that may occur
	for _, handler := range handlers {
		err := handler()
		if err != nil {
			errorHandler.Handle(err)
		}
	}
}

In this case the error handler looks like this:
// Handler is responsible for handling an error.
//
// This interface allows libraries to decouple from logging solutions.
// In most cases the implementation will provide some log functionalities though.
type Handler interface {
	Handle(err error)
}

An obvious advantage is that one does not have to rely on a leveled-logger solution in a library for example.
Looking at libraries like Logrus, they often contain hooks for well-known error/exception tracking systems like Airbrake and Bugsnag. Personally I think that it's not really a good practice to report errors like this. With the error handler concept Airbrake, Bugsnag, etc come to the same level as logging as they all become error handlers.
Looking forward to hear some opinion.

I don't see why this needs to be part of this package. From what you've
described, it's only an interface declaration.
On Fri, 9 Jun 2017, 02:01 Márk Sági-Kazár<EMAIL_ADDRESS>wrote:

In some cases I met the need for something which is able to log/report
an error in a library without actually returning it to the caller.
A typical example is when you loop through a list of elements and call a
method on them which might return an error without causing the application
to get into an erroneous state:
errorHandler := ...handlers := ...
func Shutdown() {
// Try recovering from panic first
err := errors.Recover(recover())
if err != nil {
errorHandler.Handle(err)
}
// Loop through all the handlers and call them
// Log any errors that may occur
for _, handler := range handlers {
err := handler()
if err != nil {
errorHandler.Handle(err)
}
}
}
In this case the error handler looks like this:
// Handler is responsible for handling an error.//// This interface allows libraries to decouple from logging solutions.// In most cases the implementation will provide some log functionalities though.type Handler interface {
Handle(err error)
}
An obvious advantage is that one does not have to rely on a leveled-logger
solution in a library for example.
Looking at libraries like Logrus, they often contain hooks for well-known
error/exception tracking systems like Airbrake and Bugsnag. Personally I
think that it's not really a good practice to report errors like this. With
the error handler concept Airbrake, Bugsnag, etc come to the same level as
logging as they all become error handlers.
Looking forward to hear some opinion.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/pkg/errors/issues/119, or mute the thread
https://github.com/notifications/unsubscribe-auth/AAAcA8OshU8xTF8d3fsQeHoizic1wo5tks5sCBq-gaJpZM4N0SD8
.

Well, someone may consider this package as a sane extension of the standard library error package in which case I don't see a reason against having such "recommendations" in this package. Anyway, it's just a proposal, no hard feelings if you don't see it fit here.

It's not clear to me how this would be used. It's just an interface
declaration, and people can just declare their own in their own, and avoid
the import dependency on this package.
On Fri, 9 Jun 2017, 08:15 Márk Sági-Kazár<EMAIL_ADDRESS>wrote:

Well, someone may consider this package as a sane extension of the
standard library error package in which case I don't see a reason against
having such "recommendations" in this package. Anyway, it's just a
proposal, no hard feelings if you don't see it fit here.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/pkg/errors/issues/119#issuecomment-307242387, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAAcA5LPOvg_ZvVXGV4ojcOzwAJGts5Oks5sCHKIgaJpZM4N0SD8
.

Sure thing, thanks for your answer though.


BREAKING CHANGE: new color palette, new font scale, js based theme deprecation

style: New HSLA based color scale

feat: Add VisuallyHidden component

style: Updated font scale

:tada: This PR is included in version 1.0.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


How to change the height of super-tabs-toolbar

It is possible to change the height of several items inside the toolbar (icons, label, indicator). Is it possible to change the height of the toolbar itself?

I found the solution. I included below css:
super-tabs-toolbar {
  height: 50px;
}


Fix generate command to allow GHES migrations

[ ] Did you write/update appropriate tests
[ ] Release notes updated (if appropriate)
[ ] Appropriate logging output
[ ] Issue linked

new PR --> https://github.com/github/gh-gei/pull/342


Error installing Prisma throws sha256 mismatch error for @prisma/engines

While trying to install prisma via npm install prisma, the installation fails in the step where it installs @prisma/engines and tries to download the migration-engine.gz binary. When it compares the hash with what it's "supposed" to be, the comparison fails causing the whole installation to fail.

Duplicate of https://github.com/prisma/prisma/issues/16233, will repost your details there.


Adding Dockerfile and docker-compose.yml for running as a container

Please also note the sed in Dockerfile to replace the missing CDN fil socket.io on amazon CDN to a cloudflare one.

Amazing @benoitm974 - thanks

You might want to change the CDN file location for socket io client in the code ultimately ?


Add link to HMDA filing app for certain Keycloak error messages

Keycloak has some generic error messages that leave the user stranded, with no navigation options to resolve the issue.  The most prominent one is mentioned on https://github.com/cfpb/hmda-platform-auth/issues/37#issuecomment-265893049.  Let's add a link to get the user back to our webapp so they can re-authenticate.
Other options (such as a automated redirect) could also be discussed here.

This has been remedied by recent updates to the Keycloak UI.  There is now always a "Home" link that gets you back to the filing app.


Create models related to messages

This PR adds the various models necessary to implement the message feature.
The Message model is intended for ad-hoc messages to subscriber lists to send them a particular message. This could be used as a standard mailing list message or as a means to notify them to a change to a particular list.
The MatchedMessage model serves the same purpose as the MatchedContentChange model but for messages which acts as a many to many join table.
This code was cherry picked from #927 to make it easier to merge and test individually.
Trello Card

One difference from https://github.com/alphagov/email-alert-api/pull/927 is that I've renamed path to url.


IE load main page will always loading and show js error

version: lastest
version: '3'

services:
  answer:
    image: answerdev/answer:latest
    restart: always
    ports:
      - '9082:80'
    volumes:
      - ./data:/data

At the current stage, we are not going to make compatibility with IE, and we will add a prompt for incompatibility with IE browsers in the next version;


Update Vulp and test history observers

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 95.427%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
313

Relevant Lines:
328

💛  - Coveralls


Refresh stream if blocked

Hello I want to know if you can control the stream if it is blocked, do a refresh of the stream during the video-conferencing.
Thanks

blocked as in 'frozen' ? why is it frozen in the first place ? Have you figured that out ? one reason might be the bandwidth that you are using try to lower it see https://github.com/muaz-khan/RTCMultiConnection/wiki/Bandwidth-Management

Yes when I try to record on firefox, the video of remote stream frozen. Tomorrow I try to low the bandwith

I could not solve the problem, can anyone help?

You can bypass RTCMultiConnection default bandwidth-parameters:
connection.processSdp = function (sdp) {
    return sdp; // now Chrome will use default (non-modified) SDP
};

How  can use it?


Version number is outdated

Version number is outdated (v2.2.9 instead of 2.2.11-beta)

fixed in v2.2.12


GSD Request

--- GSD JSON ---
{
  "vendor_name": "Linux",
  "product_name": "Kernel",
  "product_version": "versions from  to before v4.9.294",
  "vulnerability_type": "unspecified",
  "affected_component": "unspecified",
  "attack_vector": "unspecified",
  "impact": "unspecified",
  "credit": "",
  "references": [
    "https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/?id=66ea642af6fd4eacb5d0271a922130fcf8700424"
  ],
  "extended_references": [
    {
      "type": "commit",
      "value": "66ea642af6fd4eacb5d0271a922130fcf8700424",
      "note": "fixed"
    }
  ],
  "reporter": "joshbressers",
  "reporter_id": 1692786,
  "notes": "",
  "description": "dm btree remove: fix use after free in rebalance_children()\n\nThis is an automated ID intended to aid in discovery of potential security vulnerabilities. The actual impact and attack plausibility have not yet been proven.\nThis ID is fixed in Linux Kernel version v4.9.294 by commit 66ea642af6fd4eacb5d0271a922130fcf8700424. For more details please see the references link."
}
--- GSD JSON ---

This issue has been assigned GSD-2021-1002624


feat: mabel tactic for multiplicative abelian groups

Mabel tactic for multiplicative abelian groups (#10361)

@dignissimus You might also be interested in #13233


Address tag with valid flow content generates 'Unexpected end tag : address' error

The following valid HTML5 (as validated by the W3C validator) ...
<!DOCTYPE html>

    <meta charset="utf-8">
    <title>Noko nogo</title>

    <address>

Noko nogo

    </address>

... passed into Nokogiri::HTML with a strict configuration generates the error message ...
Unexpected end tag : address

Tested with this script: https://gist.github.com/adamc00/f57b1b1a97b2299d6516

libxml2 does not support HTML5, so it is being strict with HTML4 in mind.  Just a guess but a missing
 may be what it is complaining about.

Thanks @knu, it seems that inline elements are the only ones allowed inside an address element in HTML 4. I've switched to validating my HTML5 with html5validator.
I've updated my test script to close the li to reduce confusion but FYI closing a LI is optional in both HTML5 and HTML4.

Thanks @knu, it seems that inline elements are the only ones allowed inside an address element in HTML 4. I've switched to validating my HTML5 with html5validator.

Good to know!

I've updated my test script to close the li to reduce confusion but FYI closing a LI is optional in both HTML5 and HTML4.

Ah, of course. :blush:

I'm going to go ahead and close this; though there's a larger conversation around HTML5 support in Nokogiri that I've been pushing off. Please ping me if you have thoughts on this topic.


[search agent] Add search info

Codecov Report
Attention: 9 lines in your changes are missing coverage. Please review.

Comparison is base (fd8f6d9) 61.63% compared to head (613851f) 61.43%.
 Consider uploading reports for the commit 3783438 to get more accurate results

Files
Patch %
Lines

...ot_agent/agents/functional_agent_with_retrieval.py
10.00%
9 Missing :warning:

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #195      +/-   ##
===========================================
- Coverage    61.63%   61.43%   -0.21%
===========================================
  Files           56       56
  Lines         2763     2772       +9
===========================================
  Hits          1703     1703
- Misses        1060     1069       +9

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Fix upgrader script

Description of changes:
Fix a small typo in the upgrader script
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

/cherry-pick release-0.19

/approve
/lgtm

/approve


How to properly "migrate" migrations from previous AR::Migration

I've been migrating a project from AR to Sequel. After doing all the necessary changes in the models and other layers and making the specs run, I'm finding an issue when running my first migration. First, my dump is called ActiveRecord::Schema. So, with ActiveRecord out, that's the first "ouch" moment. My first step, I assume, is regenerate the schema, hopefully to an hybrid/sql format. How could I generate it from the existing file/database?
The other question would be: what to do with the remaining migrations? They all subclass ActiveRecord::Migration, so db:structure:load and other tasks fail as soon as they load one of the files. How to migrate them/ignore them at best?

+1


WC65 - Explore Nomad orchestration solution

Won't be explore anymore because not adding real value to deployment


Create method to serialize NumericalStatsMixin and functions

@kshitijavis, looks like at the very least, we need to update the branch.


bug(android): make sure something can reset the favorites

I forgot to hook up the "Reset to defaults" button to reset favorites. Should be simple.

I'm stuck on trying to move the MutableLiveData for the favorites into Repository. I'm getting an undefined reference there. Is Repository part of a different module that doesn't import the LiveData stuff?

If doing the UI stuff manually is getting too complicated, we may want to look into https://github.com/firezone/firezone/issues/6384.


Reuse gRPC channels

Creating a channel can be expensive, so it’s better to reuse it for performance benefits.
We need a gRPC client factory offers a centralized way to configure channels. It automatically reuses underlying channels.

Closed as

Underlying our Python wrapper, the Channel object uses C-Core's Channel which will reuse existing connections. E.g. if you create 100 channel object to the same destination with same options, there will be only 1 outstanding TCP connection.
ref: https://github.com/grpc/grpc/issues/20985#issuecomment-552604012


Potential issue with glibc on Linux

Issue description
Users using Ubuntu 18.04 may see a white screen upon launching. The DevTools will show version 'GLIBC_2.29' not found
Wallet version
Which version of wallet are you using?

wallet version (version number, commit, or branch): 0.3.0

System specification
What is your operating system?
Mac/Win/Linux (+Version and or Distro if possible) Ubuntu 18.04
Is it a repeatable issue?
Yes
Steps To reproduce the issue
Explain how the maintainer can reproduce the issue.

Launch the app

Expected behaviour
App launches
Actual behaviour
White screen
Errors
version 'GLIBC_2.29' not found

Same here, Debian 10 Buster.

Please build the AppImage against an old version of glibc.
https://unix.stackexchange.com/a/149627

The last version of trinity worked on debian 10, I believe it is possible to adjust firefly. Thanks.


Executing only one job in one run. Added Job manager tab in settings.

Codecov Report

Merging #108 (437c6e2) into master (33f756b) will decrease coverage by 0.28%.
The diff coverage is 0.00%.

@@             Coverage Diff              @@
##             master     #108      +/-   ##
============================================
- Coverage     27.88%   27.60%   -0.29%
- Complexity     2043     2056      +13
============================================
  Files            72       72
  Lines          6426     6484      +58
============================================
- Hits           1792     1790       -2
- Misses         4634     4694      +60

Impacted Files
Coverage Δ
Complexity Δ

retailcrm/lib/RetailcrmJobManager.php
0.00% <0.00%> (ø)
96.00 <8.00> (+13.00)

retailcrm/lib/RetailcrmTools.php
35.03% <0.00%> (ø)
146.00 <0.00> (ø)

retailcrm/retailcrm.php
28.41% <0.00%> (-0.40%)
223.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 33f756b...437c6e2. Read the comment docs.

Codecov Report

Merging #108 (0693a6a) into master (33f756b) will decrease coverage by 0.33%.
The diff coverage is 0.00%.

@@             Coverage Diff              @@
##             master     #108      +/-   ##
============================================
- Coverage     27.88%   27.55%   -0.34%
- Complexity     2043     2064      +21
============================================
  Files            72       72
  Lines          6426     6508      +82
============================================
+ Hits           1792     1793       +1
- Misses         4634     4715      +81

Impacted Files
Coverage Δ
Complexity Δ

retailcrm/lib/RetailcrmJobManager.php
0.00% <0.00%> (ø)
99.00 <8.00> (+16.00)

retailcrm/lib/RetailcrmTools.php
35.03% <0.00%> (ø)
146.00 <0.00> (ø)

retailcrm/retailcrm.php
28.65% <0.00%> (-0.16%)
228.00 <0.00> (+5.00)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 33f756b...0693a6a. Read the comment docs.


Documentation example is not compiling (ADT, ShapesDerivation)

Hello!
I am trying to compile the following example. https://circe.github.io/circe/codecs/adt.html
sealed trait Event

case class Foo(i: Int) extends Event
case class Bar(s: String) extends Event
case class Baz(c: Char) extends Event
case class Qux(values: List[String]) extends Event

Precisely I want to use ShapesDerivation, like here:
import io.circe._ // no such line in example, but had to import it
object ShapesDerivation {
  import io.circe.shapes // not used actually
  import shapeless.{ Coproduct, Generic }

  implicit def encodeAdtNoDiscr[A, Repr <: Coproduct](implicit
    gen: Generic.Aux[A, Repr],
    encodeRepr: Encoder[Repr]
  ): Encoder[A] = encodeRepr.contramap(gen.to)

  implicit def decodeAdtNoDiscr[A, Repr <: Coproduct](implicit
    gen: Generic.Aux[A, Repr],
    decodeRepr: Decoder[Repr]
  ): Decoder[A] = decodeRepr.map(gen.from)

}

Didn't use or write previous GenericDerivation, so no really need to suppress imports?
And this example
import ShapesDerivation._
import io.circe.parser.decode, io.circe.syntax._
decode[Event]("""{ "i": 1000 }""")
(Foo(100): Event).asJson.noSpaces

Doesn't compile on line decode[Event]("""{ "i": 1000 }"""), gives two errors:
could not find implicit value for evidence parameter of type io.circe.Decoder[com.example.Event]

and
could not find implicit value for parameter encoder: io.circe.Encoder[com.example.Event]

What else do I need? 🤔  Or may be documentation is a bit out of date?
Version if all libraries I use is 0.11.1.

The documentation works (that's verified by CI on every pull request), but the trick is that you have to compile everything on the page, in order. In this case I believe what's missing is the io.circe.generic.auto._ import, but I might be wrong.
Good catch on the unused import—I'd happily accept a PR removing it.

@travisbrown thank you! Found it https://github.com/circe/circe/blob/master/docs/src/main/tut/codecs/adt.md
Yes, may be you're right - will update and prepare PR later.

@travisbrown, no I am afraid it doesn't work that way. Could you give me a hand? Probably it's very silly mistake and I am indeed missing important import.
If I add the line import io.circe.generic.auto._, everything compiles fine, but import ShapesDerivation._ is marked as unused in IDEA now (and in any code analyser).
And decode[Foo]("""{ "i": 1000 }""") works fine (translated to Right(Foo(1000))).
However, if I change Foo to Event, it gives me Left(DecodingFailure(CNil, List())), but this is the whole idea, isn't it? 🤔

I just copied and pasted the code from the page and it decodes the example just fine:
sealed trait Event

case class Foo(i: Int) extends Event
case class Bar(s: String) extends Event
case class Baz(c: Char) extends Event
case class Qux(values: List[String]) extends Event

import cats.syntax.functor._
import io.circe.{ Decoder, Encoder }, io.circe.generic.auto._
import io.circe.syntax._

object GenericDerivation {
  implicit val encodeEvent: Encoder[Event] = Encoder.instance {
    case foo @ Foo(_) => foo.asJson
    case bar @ Bar(_) => bar.asJson
    case baz @ Baz(_) => baz.asJson
    case qux @ Qux(_) => qux.asJson
  }

  implicit val decodeEvent: Decoder[Event] =
    List[Decoder[Event]](
      Decoder[Foo].widen,
      Decoder[Bar].widen,
      Decoder[Baz].widen,
      Decoder[Qux].widen
    ).reduceLeft(_ or _)
}

import GenericDerivation._
// import GenericDerivation._

import io.circe.parser.decode
// import io.circe.parser.decode

decode[Event]("""{ "i": 1000 }""")
// res0: Either[io.circe.Error,Event] = Right(Foo(1000))

(Foo(100): Event).asJson.noSpaces
// res1: String = {"i":100}

import GenericDerivation.{ decodeEvent => _, encodeEvent => _ }

object ShapesDerivation {
  import io.circe.shapes
  import shapeless.{ Coproduct, Generic }

  implicit def encodeAdtNoDiscr[A, Repr <: Coproduct](implicit
    gen: Generic.Aux[A, Repr],
    encodeRepr: Encoder[Repr]
  ): Encoder[A] = encodeRepr.contramap(gen.to)

  implicit def decodeAdtNoDiscr[A, Repr <: Coproduct](implicit
    gen: Generic.Aux[A, Repr],
    decodeRepr: Decoder[Repr]
  ): Decoder[A] = decodeRepr.map(gen.from)

}

import ShapesDerivation._
// import ShapesDerivation._

import io.circe.parser.decode, io.circe.syntax._
// import io.circe.parser.decode
// import io.circe.syntax._

decode[Event]("""{ "i": 1000 }""")
// res3: Either[io.circe.Error,Event] = Right(Foo(1000))

(Foo(100): Event).asJson.noSpaces

Well, no wonder why it works - you put everything in one file, it means GenericDerivation is used. Have you tried to comment out or delete it's implementation?
I think the line import GenericDerivation.{ decodeEvent => _, encodeEvent => _ } doesn't work as expected in one file, it may work with separate files.
GenericDerivation works just fine, but I wanted to make ShapesDerivation to work too.

I don't have a lot of context for this example specifically or time to look at it at the moment, but yeah, I guess the import GenericDerivation.{ decodeEvent => _, encodeEvent => _ } isn't doing what the document says it does. I'll take a closer look and fix it when I can.

Here's the minimization that works as expected:
sealed trait Event

case class Foo(i: Int) extends Event
case class Bar(s: String) extends Event
case class Baz(c: Char) extends Event
case class Qux(values: List[String]) extends Event

import io.circe.{ Decoder, Encoder }
import io.circe.generic.auto._, io.circe.shapes._

object ShapesDerivation {
  import shapeless.{ Coproduct, Generic }

  implicit def encodeAdtNoDiscr[A, Repr <: Coproduct](implicit
    gen: Generic.Aux[A, Repr],
    encodeRepr: Encoder[Repr]
  ): Encoder[A] = encodeRepr.contramap(gen.to)

  implicit def decodeAdtNoDiscr[A, Repr <: Coproduct](implicit
    gen: Generic.Aux[A, Repr],
    decodeRepr: Decoder[Repr]
  ): Decoder[A] = decodeRepr.map(gen.from)
}

import ShapesDerivation._

io.circe.parser.decode[Event]("""{ "i": 1000 }""")

@travisbrown - I hit up the Gitter channel a few days ago about this exact thing as well, and you helped me get the example working. I am able to make this work as well; however, if I change the setup (like, refactor the types or implicits into different files for example), it breaks. It's making me think I'm crazy, or there's something going on I seriously don't understand. I'll put some code examples here, but in the meantime... do you have any ideas? Is there some need for all the code to be in the same file/module?

@chrisalbright If you can post an example I can take a look.

@travisbrown I'll put together some gists and post here. Thanks again.


5106 Implements validation in device form

FRONTEND PULL REQUEST
Related Issue

Resolves #5106
Resolves #5184

Changes Proposed

Adds react-hook-forms library to the SimpleReport project. This library will take care of performing basic validations, keep track of the form data state, trigger errors accordingly and perform the focus on error on elements that are properly integrated
Modifies form common components  Dropdown, Select, TextInput, MultiSelect so they can be properly setup with the library.
Updates the deviceForm component to use react-hook-form to track data state, errors and validation. It also removes the prop initialValues as it was not really used.
Moves the logic of the disease information section into its own component.
Updates necessary unit testing.
Updates the container components ManageDeviceTypeFormContainer and DeviceTypeFormContainer
Adds the role attribute to the component DeviceTypeReminderMessage
Updates the dom references of the multiplex e2e spec 09.

Additional Information
I ended up modifiying the MultiSelect component and the underlying components because the workaround had small glitches.
Testing
Tested in Dev1

Verify that all fields marked as required must be filled out in order to submit the form.
Verify that if the field is empty the form should display an error triggered but the click of the save changes button.
Verify that save changes button enables when the form is "dirty".
Verify that test length field only allows for numbers and also displays an error if a number outside the 0-999 range is entered.
Verify that the http request to update the data only triggers if the form has been filled out with valid values.
Edit mode should load values as expected upon selecting a device.

Screenshots / Demos

One weird bug I'm noticing is I type one number in "Test length (minutes)" field and it automatically enters to the next field... Can you repro this?
For some reason I can't attach the screen recording so I'll put it in slack -_-"

@zdeveloper I remember you telling you were the one that created the pill component. I have aded some small logic to integrate it with react-hook-forms if you spot any issues with its behavior please let me know!. I tested the component against the current version in main and it seems that is working as expected... but an extra set of eyes is always good.


Js/Py code separation

@veghdev I have extracted the JS templates and turned them into a JS class.
Also tried to make the Python side work without success.
Please check.

@veghdev animate() works, store/restore does not.
Can be tested on docs/examples/stories/music-history.
I've put the JS class inside the INIT template for now.


How to Exclude draft PRs in github from the Enable Preview feature

How to Exclude draft PRs in github from the Enable Preview feature
I don't want the preview to be enabled for draft PR and only want this enabled if the PR is marked ready for review.

@shrirupa you currently cannot. A lot of customers have asked for PRs to be supported in draft PR mode so not sure we are going to prioritize this. As a workaround, submit draft PRs to another branch and when you're ready, update the PR to point to a different branch.


STORM-1278: Port org.apache.storm.daemon.worker to java

This replaces pull request #1756

Confirmed 1c1029f addresses my review comments from #1756, and unit tests passed in my local.
+1


Remove irrelevant states

We might want to remove temporary handshake states that don't really matter.

Not necessary at this point in time.


ORDS docker file link broken

Hello there,
I was looking into this today, and it seems like this link is broken:
https://github.com/oracle/docker-images/blob/main/OracleRestDataServices/dockerfiles/buildDockerImage.sh
Any idea where I can find it?
Thanks!
Chris

It seems to have changed to buildContainerImage.sh and the link was not updated accordingly.
This should do the trick: https://github.com/oracle/docker-images/blob/main/OracleRestDataServices/dockerfiles/buildContainerImage.sh

@chrishoina where did you get the broken link from?

@yunus-qureshi He probably got it from https://github.com/oracle/docker-images/blob/main/OracleRestDataServices/README.md. Should be an easy fix.

Thanks @WayneNani

@yunus-qureshi just now responding, but yes, the page that @WayneNani mentioned is correct. Thanks

Thanks will get this fixed


bug: header scrollTop used with tabs scrolls all views

Type: bug
Platform: all
Hi,
I'm having trouble with scrollTop and tabs in Ionic. When you click on header (to scroll on top of the view), il you have some tabs, all tabs view scroll to top, and not only the active view.
Moreover, in my case, this scrollTop (clicking on header) recalculate collection-repeat width with parameters of active view (even if it's not the active view).
I don't know if I'm really clear so, here is my app. I have (mainly) 3 tabs with a list on each :

If I scroll a little bit on each, and decide to scroll to in one view (clicking on header), all the view are scrolling to top :(
An other thing, if I choose to scrollTop on 'Sessions' or 'Programme' view, the 'Participants' view is scrolling top but as this list uses collection-repeat, it also recalculate its dimentions and as the active view has 3 elements on top, it ends looking like this :

Not really cool... Clicking on the header on this view correctly recalculate this collection-repeat (comes back to normal). This happen even if I fix the width using item-width="100%".
I didn't have time to setup a codepen reproducing this 'bug' right now, I'll do it next weekend if my current explanations are not clear enough.
The code of my app is public and you can find related views here : https://github.com/saloonapp/ionic-app/tree/947e03cc86652ad34f4f95a28f85897fea226fc8/www/views/events

@loicknuchel yeah, a codepen would help with this. It seems like there are a few different things going on here and it would be great to get a separate look at the all

Hi, I will try to reproduce this on codepen at the end of april, I'm quite full right now.

Greetings @loicknuchel!
My sensors indicate a reply was requested, but we have not received one yet, I am using my robot powers to close this issue. However, if you are still experiencing this issue, please feel free to reopen it by creating a new issue, and include any examples or necessary information.
Thank you for allowing me to assist you.