Replace all spaces before compare with search text in workspace invite

Details

Fixed Issues

$ https://github.com/Expensify/App/issues/34020
PROPOSAL: https://github.com/Expensify/App/issues/34020#issuecomment-1878587721
Tests

Tap Profile icon
Tap Workspaces ---- Workspace ---- Members
Tap invite
Enter a number eg: +919787766754
From the list, tap and select the contact
Verify that: contact does not disappear

[x] Verify that no errors appear in the JS console

Offline tests

QA Steps

Tap Profile icon
Tap Workspaces ---- Workspace ---- Members
Tap invite
Enter a number eg: +919787766754
From the list, tap and select the contact
Verify that: contact does not disappear

[x] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If the PR modifies the form input styles:

[x] I verified that all the inputs inside a form are aligned with each other.
[x] I added Design label so the design team can review the changes.

[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

https://github.com/Expensify/App/assets/129500732/87317ca8-cb03-449a-b21f-69b625cfc693

Android: mWeb Chrome

https://github.com/Expensify/App/assets/129500732/87317ca8-cb03-449a-b21f-69b625cfc693

iOS: Native

https://github.com/Expensify/App/assets/129500732/5c5a29d2-3e98-4713-a80f-75a307899a6f

iOS: mWeb Safari

https://github.com/Expensify/App/assets/129500732/cc191e94-9b8f-4876-9bae-0ac54f7e12a9

MacOS: Chrome / Safari

https://github.com/Expensify/App/assets/129500732/6ffc4543-2450-4e56-9533-3405ea8e5b38

MacOS: Desktop

https://github.com/Expensify/App/assets/129500732/1deee5d3-e296-4538-ae95-5d301703da07

Reviewing now

Hi @dukenv0307 , there seems to be merge conflicts on the PR. Could you kindly fix the same?

@dukenv0307 Checklist tests are failing. Could you kindly fix this?

Reviewer Checklist

[x] I have verified the author checklist is complete (all boxes are checked off).
[x] I verified the correct issue is linked in the ### Fixed Issues section above
[x] I verified testing steps are clear and they cover the changes made in this PR

[x] I verified the steps for local testing are in the Tests section
[x] I verified the steps for Staging and/or Production testing are in the QA steps section
[x] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[x] I checked that screenshots or videos are included for tests on all platforms
[ ] I included screenshots or videos for tests on all platforms
[x] I verified tests pass on all platforms & I tested again on:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

[ ] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
[x] I verified proper code patterns were followed (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I verified that this PR follows the guidelines as stated in the Review Guidelines
[x] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If the PR modifies the form input styles:

[x] I verified that all the inputs inside a form are aligned with each other.
[x] I added Design label so the design team can review the changes.

[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[ ] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

https://github.com/Expensify/App/assets/46707890/8fe2864b-5dd4-40de-bf45-635492755690

Android: mWeb Chrome

https://github.com/Expensify/App/assets/46707890/73e33079-03fe-4135-bdd8-887a5b160aa0

iOS: Native

https://github.com/Expensify/App/assets/46707890/60477629-2903-4b9f-bad4-d7b290904b93

iOS: mWeb Safari

https://github.com/Expensify/App/assets/46707890/2de35d90-bbe1-4dac-a20c-f03ce7fb378a

MacOS: Chrome / Safari

https://github.com/Expensify/App/assets/46707890/e1098060-2082-42c0-877f-65ca16bacccc

MacOS: Desktop

https://github.com/Expensify/App/assets/46707890/9c776777-c405-4195-a26e-a3758a6391d3

🚀 Deployed to staging by https://github.com/thienlnam in version: 1.4.24-4 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
cancelled 🔪

🕸 web 🕸
success ✅

🚀 Deployed to production by https://github.com/mountiny in version: 1.4.24-8 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


Are all the 1 million images annotated ?

Thanks for facilitating downloading the dataset, did you annotated the 1 million images or only the 50k are annotated ?

Only 50k are annotated :)
On Fri, Oct 18, 2019, 03:19 Amal<EMAIL_ADDRESS>wrote:

Thanks for facilitating downloading the dataset, did you annotated the 1
million images or only the 50k are annotated ?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/cad0p/maskrcnn-modanet/issues/15?email_source=notifications&email_token=ADLUHNRGQJS2OAEVENFLEZTQPEFLVA5CNFSM4JCBLIFKYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4HSTVW6Q,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ADLUHNS65H363LD6WWWBRUDQPEFLVANCNFSM4JCBLIFA
.

Thanks for your best work,but i hava question about modanet dataset. how to only get 50K images,not download all paperdoll dataset?

@bamal @cad0p

There is an option on my script, if you run it from your computer
On Wed, Nov 27, 2019, 09:48 XGuider<EMAIL_ADDRESS>wrote:

@bamal https://github.com/bamal @cad0p https://github.com/cad0p
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/cad0p/maskrcnn-modanet/issues/15?email_source=notifications&email_token=ADLUHNXK3KCVLGIK63U5NADQVYX7VA5CNFSM4JCBLIFKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEFIYFBI#issuecomment-558989957,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ADLUHNUX2EPCZ22JR7LDC4TQVYX7VANCNFSM4JCBLIFA
.

thnx you,which one  script?

It's literally the first script you have to run when you install this
package
On Thu, Nov 28, 2019, 03:15 XGuider<EMAIL_ADDRESS>wrote:

thnx you,which one script?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/cad0p/maskrcnn-modanet/issues/15?email_source=notifications&email_token=ADLUHNREI7JUMC3TZHJ7SJ3QV4STTA5CNFSM4JCBLIFKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEFLHECA#issuecomment-559313416,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ADLUHNXVLUFW2VBD2QB5RD3QV4STTANCNFSM4JCBLIFA
.

Hi, I ran the download script it shown me downloading and unzipping but it didn't show anything in the images directory. Could you please help me on that front whether i miss anything?

Paste output of the program here when you ran the script

Below is the output i get when i ran the download script. NOTE: I am using google colab
/content/main/
/usr/local/lib/python3.6/dist-packages/maskrcnn_modanet/
Do you want to download the whole 1 million images (what I had to do) or to just download the 50k annotated with ModaNet?
Y for 1 million (40 GB), N for 50k: N
downloading paperdoll dataset
taken from here:
https://github.com/kyamagu/paperdoll/tree/master/data/chictopia
git: 'lfs' is not a git command. See 'git --help'.
The most similar command is
log
/root/.maskrcnn-modanet
saving your path location
/content/main/
fast download:
True
Skipping downloading PaperDoll
/content/main/datasets
\n now downloading modanet annotations\n \t\t\ttaken from here:\n \t\t\thttps://github.com/eBay/modanet
Cloning into 'modanet'...
remote: Enumerating objects: 70, done.
remote: Total 70 (delta 0), reused 0 (delta 0), pack-reused 70
Unpacking objects: 100% (70/70), done.
--2020-04-22 11:51:54--  https://github.com/cad0p/maskrcnn-modanet/releases/download/v1.0.3/modanet2018_instances_train.json
Resolving github.com (github.com)... <IP_ADDRESS>
Connecting to github.com (github.com)|<IP_ADDRESS>|:443... connected.
HTTP request sent, awaiting response... 302 Found
Location: https://github-production-release-asset-2e65be.s3.amazonaws.com/184780048/6f984b00-cde4-11e9-872f-ee636321fb6c?X-Amz-Algorithm=AWS4-HMAC-SHA256&X-Amz-Credential=AKIAIWNJYAX4CSVEH53A%2F20200422%2Fus-east-1%2Fs3%2Faws4_request&X-Amz-Date=20200422T115154Z&X-Amz-Expires=300&X-Amz-Signature=890eac2a6de1eceaaba09db39e00c2557588c51c90896403da5da1f4190c9e7a&X-Amz-SignedHeaders=host&actor_id=0&repo_id=184780048&response-content-disposition=attachment%3B filename%3Dmodanet2018_instances_train.json&response-content-type=application%2Foctet-stream [following]
--2020-04-22 11:51:54--  https://github-production-release-asset-2e65be.s3.amazonaws.com/184780048/6f984b00-cde4-11e9-872f-ee636321fb6c?X-Amz-Algorithm=AWS4-HMAC-SHA256&X-Amz-Credential=AKIAIWNJYAX4CSVEH53A%2F20200422%2Fus-east-1%2Fs3%2Faws4_request&X-Amz-Date=20200422T115154Z&X-Amz-Expires=300&X-Amz-Signature=890eac2a6de1eceaaba09db39e00c2557588c51c90896403da5da1f4190c9e7a&X-Amz-SignedHeaders=host&actor_id=0&repo_id=184780048&response-content-disposition=attachment%3B filename%3Dmodanet2018_instances_train.json&response-content-type=application%2Foctet-stream
Resolving github-production-release-asset-2e65be.s3.amazonaws.com (github-production-release-asset-2e65be.s3.amazonaws.com)... <IP_ADDRESS>
Connecting to github-production-release-asset-2e65be.s3.amazonaws.com (github-production-release-asset-2e65be.s3.amazonaws.com)|<IP_ADDRESS>|:443... connected.
HTTP request sent, awaiting response... 200 OK
Length: 105924292 (101M) [application/octet-stream]
Saving to: ‘modanet2018_instances_train.json’
modanet2018_instanc 100%[===================>] 101.02M  29.5MB/s    in 3.4s
2020-04-22 11:51:58 (29.5 MB/s) - ‘modanet2018_instances_train.json’ saved [105924292/105924292]
--2020-04-22 11:51:58--  https://github.com/cad0p/maskrcnn-modanet/releases/download/v1.0.3/modanet2018_instances_val.json
Resolving github.com (github.com)... <IP_ADDRESS>
Connecting to github.com (github.com)|<IP_ADDRESS>|:443... connected.
HTTP request sent, awaiting response... 302 Found
Location: https://github-production-release-asset-2e65be.s3.amazonaws.com/184780048/6f984b00-cde4-11e9-97db-80e1d6bc038f?X-Amz-Algorithm=AWS4-HMAC-SHA256&X-Amz-Credential=AKIAIWNJYAX4CSVEH53A%2F20200422%2Fus-east-1%2Fs3%2Faws4_request&X-Amz-Date=20200422T115158Z&X-Amz-Expires=300&X-Amz-Signature=1d2f7f1a9f44250415f2844c9d8c829934b8cb5307ce3af00a07a02009bde347&X-Amz-SignedHeaders=host&actor_id=0&repo_id=184780048&response-content-disposition=attachment%3B filename%3Dmodanet2018_instances_val.json&response-content-type=application%2Foctet-stream [following]
--2020-04-22 11:51:59--  https://github-production-release-asset-2e65be.s3.amazonaws.com/184780048/6f984b00-cde4-11e9-97db-80e1d6bc038f?X-Amz-Algorithm=AWS4-HMAC-SHA256&X-Amz-Credential=AKIAIWNJYAX4CSVEH53A%2F20200422%2Fus-east-1%2Fs3%2Faws4_request&X-Amz-Date=20200422T115158Z&X-Amz-Expires=300&X-Amz-Signature=1d2f7f1a9f44250415f2844c9d8c829934b8cb5307ce3af00a07a02009bde347&X-Amz-SignedHeaders=host&actor_id=0&repo_id=184780048&response-content-disposition=attachment%3B filename%3Dmodanet2018_instances_val.json&response-content-type=application%2Foctet-stream
Resolving github-production-release-asset-2e65be.s3.amazonaws.com (github-production-release-asset-2e65be.s3.amazonaws.com)... <IP_ADDRESS>
Connecting to github-production-release-asset-2e65be.s3.amazonaws.com (github-production-release-asset-2e65be.s3.amazonaws.com)|<IP_ADDRESS>|:443... connected.
HTTP request sent, awaiting response... 200 OK
Length: 215183 (210K) [application/octet-stream]
Saving to: ‘modanet2018_instances_val.json’
modanet2018_instanc 100%[===================>] 210.14K   820KB/s    in 0.3s
2020-04-22 11:51:59 (820 KB/s) - ‘modanet2018_instances_val.json’ saved [215183/215183]
/content/main/datasets/coco
downloading the images folder.. (2 GB)
--2020-04-22 11:51:59--  https://github.com/cad0p/maskrcnn-modanet/releases/download/v0.9/images.zip
Resolving github.com (github.com)... <IP_ADDRESS>
Connecting to github.com (github.com)|<IP_ADDRESS>|:443... connected.
HTTP request sent, awaiting response... 302 Found
Location: https://github-production-release-asset-2e65be.s3.amazonaws.com/184780048/b6d3ac80-9fea-11e9-960d-30e52ebc3bcc?X-Amz-Algorithm=AWS4-HMAC-SHA256&X-Amz-Credential=AKIAIWNJYAX4CSVEH53A%2F20200422%2Fus-east-1%2Fs3%2Faws4_request&X-Amz-Date=20200422T115159Z&X-Amz-Expires=300&X-Amz-Signature=0e5ebcdad216f878a3bc68d29f4abcd2d45d6a40cadc98dc3af66cfdb8613012&X-Amz-SignedHeaders=host&actor_id=0&repo_id=184780048&response-content-disposition=attachment%3B filename%3Dimages.zip&response-content-type=application%2Foctet-stream [following]
--2020-04-22 11:51:59--  https://github-production-release-asset-2e65be.s3.amazonaws.com/184780048/b6d3ac80-9fea-11e9-960d-30e52ebc3bcc?X-Amz-Algorithm=AWS4-HMAC-SHA256&X-Amz-Credential=AKIAIWNJYAX4CSVEH53A%2F20200422%2Fus-east-1%2Fs3%2Faws4_request&X-Amz-Date=20200422T115159Z&X-Amz-Expires=300&X-Amz-Signature=0e5ebcdad216f878a3bc68d29f4abcd2d45d6a40cadc98dc3af66cfdb8613012&X-Amz-SignedHeaders=host&actor_id=0&repo_id=184780048&response-content-disposition=attachment%3B filename%3Dimages.zip&response-content-type=application%2Foctet-stream
Resolving github-production-release-asset-2e65be.s3.amazonaws.com (github-production-release-asset-2e65be.s3.amazonaws.com)... <IP_ADDRESS>
Connecting to github-production-release-asset-2e65be.s3.amazonaws.com (github-production-release-asset-2e65be.s3.amazonaws.com)|<IP_ADDRESS>|:443... connected.
HTTP request sent, awaiting response... 200 OK
Length:<PHONE_NUMBER> (2.0G) [application/octet-stream]
Saving to: ‘images.zip’
images.zip          100%[===================>]   1.97G  34.7MB/s    in 59s
2020-04-22 11:52:59 (34.1 MB/s) - ‘images.zip’ saved [2115906618/2115906618]
unzipping..
/content/main/datasets/coco/annotations
now downloading fixed ModaNet annotations (this can also be done with datasets fix command)
--2020-04-22 11:53:25--  https://github.com/cad0p/maskrcnn-modanet/releases/download/v0.9/instances_all.json
Resolving github.com (github.com)... <IP_ADDRESS>
Connecting to github.com (github.com)|<IP_ADDRESS>|:443... connected.
HTTP request sent, awaiting response... 302 Found
Location: https://github-production-release-asset-2e65be.s3.amazonaws.com/184780048/87c43780-9ff8-11e9-8d0d-60e271df9011?X-Amz-Algorithm=AWS4-HMAC-SHA256&X-Amz-Credential=AKIAIWNJYAX4CSVEH53A%2F20200422%2Fus-east-1%2Fs3%2Faws4_request&X-Amz-Date=20200422T115325Z&X-Amz-Expires=300&X-Amz-Signature=ba5a9619e18ea3496d2a3bdfa12f3cce74acb9f2b490231f500a4c597acb2f66&X-Amz-SignedHeaders=host&actor_id=0&repo_id=184780048&response-content-disposition=attachment%3B filename%3Dinstances_all.json&response-content-type=application%2Foctet-stream [following]
--2020-04-22 11:53:25--  https://github-production-release-asset-2e65be.s3.amazonaws.com/184780048/87c43780-9ff8-11e9-8d0d-60e271df9011?X-Amz-Algorithm=AWS4-HMAC-SHA256&X-Amz-Credential=AKIAIWNJYAX4CSVEH53A%2F20200422%2Fus-east-1%2Fs3%2Faws4_request&X-Amz-Date=20200422T115325Z&X-Amz-Expires=300&X-Amz-Signature=ba5a9619e18ea3496d2a3bdfa12f3cce74acb9f2b490231f500a4c597acb2f66&X-Amz-SignedHeaders=host&actor_id=0&repo_id=184780048&response-content-disposition=attachment%3B filename%3Dinstances_all.json&response-content-type=application%2Foctet-stream
Resolving github-production-release-asset-2e65be.s3.amazonaws.com (github-production-release-asset-2e65be.s3.amazonaws.com)... <IP_ADDRESS>
Connecting to github-production-release-asset-2e65be.s3.amazonaws.com (github-production-release-asset-2e65be.s3.amazonaws.com)|<IP_ADDRESS>|:443... connected.
HTTP request sent, awaiting response... 200 OK
Length: 124180077 (118M) [application/octet-stream]
Saving to: ‘instances_all.json’
instances_all.json  100%[===================>] 118.43M  33.7MB/s    in 4.0s
2020-04-22 11:53:30 (29.6 MB/s) - ‘instances_all.json’ saved [124180077/124180077]
/content/main/results
downloading the default coco snapshot
--2020-04-22 11:53:34--  https://github.com/fizyr/keras-maskrcnn/releases/download/0.2.2/resnet50_coco_v0.2.0.h5
Resolving github.com (github.com)... <IP_ADDRESS>
Connecting to github.com (github.com)|<IP_ADDRESS>|:443... connected.
HTTP request sent, awaiting response... 302 Found
Location: https://github-production-release-asset-2e65be.s3.amazonaws.com/124870610/d5ca1180-934f-11e9-8447-d8787953f5d8?X-Amz-Algorithm=AWS4-HMAC-SHA256&X-Amz-Credential=AKIAIWNJYAX4CSVEH53A%2F20200422%2Fus-east-1%2Fs3%2Faws4_request&X-Amz-Date=20200422T115334Z&X-Amz-Expires=300&X-Amz-Signature=3008beb21791b53941011d0f2ad34fcb12c8da4bc4c058bb123bef39d910b84d&X-Amz-SignedHeaders=host&actor_id=0&repo_id=124870610&response-content-disposition=attachment%3B filename%3Dresnet50_coco_v0.2.0.h5&response-content-type=application%2Foctet-stream [following]
--2020-04-22 11:53:34--  https://github-production-release-asset-2e65be.s3.amazonaws.com/124870610/d5ca1180-934f-11e9-8447-d8787953f5d8?X-Amz-Algorithm=AWS4-HMAC-SHA256&X-Amz-Credential=AKIAIWNJYAX4CSVEH53A%2F20200422%2Fus-east-1%2Fs3%2Faws4_request&X-Amz-Date=20200422T115334Z&X-Amz-Expires=300&X-Amz-Signature=3008beb21791b53941011d0f2ad34fcb12c8da4bc4c058bb123bef39d910b84d&X-Amz-SignedHeaders=host&actor_id=0&repo_id=124870610&response-content-disposition=attachment%3B filename%3Dresnet50_coco_v0.2.0.h5&response-content-type=application%2Foctet-stream
Resolving github-production-release-asset-2e65be.s3.amazonaws.com (github-production-release-asset-2e65be.s3.amazonaws.com)... <IP_ADDRESS>
Connecting to github-production-release-asset-2e65be.s3.amazonaws.com (github-production-release-asset-2e65be.s3.amazonaws.com)|<IP_ADDRESS>|:443... connected.
HTTP request sent, awaiting response... 200 OK
Length: 164564448 (157M) [application/octet-stream]
Saving to: ‘resnet50_coco_v0.2.0.h5’
resnet50_coco_v0.2. 100%[===================>] 156.94M  35.2MB/s    in 5.1s
2020-04-22 11:53:40 (31.1 MB/s) - ‘resnet50_coco_v0.2.0.h5’ saved [164564448/164564448]
downloading the last available trained modanet snapshot
--2020-04-22 11:53:40--  https://github.com/cad0p/maskrcnn-modanet/releases/download/v1.0/resnet50_modanet.h5
Resolving github.com (github.com)... <IP_ADDRESS>
Connecting to github.com (github.com)|<IP_ADDRESS>|:443... connected.
HTTP request sent, awaiting response... 302 Found
Location: https://github-production-release-asset-2e65be.s3.amazonaws.com/184780048/e0163a80-a0c7-11e9-98e8-0f0376825af5?X-Amz-Algorithm=AWS4-HMAC-SHA256&X-Amz-Credential=AKIAIWNJYAX4CSVEH53A%2F20200422%2Fus-east-1%2Fs3%2Faws4_request&X-Amz-Date=20200422T115340Z&X-Amz-Expires=300&X-Amz-Signature=4f32b01d451729d5e9a96cbdbe3fd631f34ee4ef6cb84059599a9432032cc2e0&X-Amz-SignedHeaders=host&actor_id=0&repo_id=184780048&response-content-disposition=attachment%3B filename%3Dresnet50_modanet.h5&response-content-type=application%2Foctet-stream [following]
--2020-04-22 11:53:40--  https://github-production-release-asset-2e65be.s3.amazonaws.com/184780048/e0163a80-a0c7-11e9-98e8-0f0376825af5?X-Amz-Algorithm=AWS4-HMAC-SHA256&X-Amz-Credential=AKIAIWNJYAX4CSVEH53A%2F20200422%2Fus-east-1%2Fs3%2Faws4_request&X-Amz-Date=20200422T115340Z&X-Amz-Expires=300&X-Amz-Signature=4f32b01d451729d5e9a96cbdbe3fd631f34ee4ef6cb84059599a9432032cc2e0&X-Amz-SignedHeaders=host&actor_id=0&repo_id=184780048&response-content-disposition=attachment%3B filename%3Dresnet50_modanet.h5&response-content-type=application%2Foctet-stream
Resolving github-production-release-asset-2e65be.s3.amazonaws.com (github-production-release-asset-2e65be.s3.amazonaws.com)... <IP_ADDRESS>
Connecting to github-production-release-asset-2e65be.s3.amazonaws.com (github-production-release-asset-2e65be.s3.amazonaws.com)|<IP_ADDRESS>|:443... connected.
HTTP request sent, awaiting response... 200 OK
Length: 474901896 (453M) [application/octet-stream]
Saving to: ‘resnet50_modanet.h5’
resnet50_modanet.h5 100%[===================>] 452.90M  34.6MB/s    in 14s
2020-04-22 11:53:54 (33.3 MB/s) - ‘resnet50_modanet.h5’ saved [474901896/474901896]
/content/main/results/processedimages
/content/main/
├── datasets
│   ├── coco
│   │   ├── annotations
│   │   └── images
│   └── modanet
│       ├── annotations
│       └── logo
└── results
├── logs
├── processedimages
│   ├── annotations
│   ├── images
│   └── imagesegments
└── snapshots
14 directories
If you don't have tree installed, just install it for bash terminal and run this command again:
maskrcnn-modanet datasets download
This command also stores your saved variables with the default values. run 'maskrcnn-modanet savedvars show' to see them
Now run 'maskrcnn-modanet datasets arrange'

yeah thank you... But the code to show the process image has errors... NameError: name 'Image' is not defined

These are the commands i gave
from PIL import Image
!maskrcnn-modanet processimage  save image -p "1115865.jpg"
kindly do the needful

Yeah I fixed that a month ago but haven't updated the package :D

If you clone it from GitHub instead of installing with pip it should work
even right now
I'll update the package ASAP!

Thanks, it is working fine


boldClock

Make the minutes on the clock bold. Now with extra verified commits. :+1:

Just realized that it made write conflicts. I'll be remaking this pull request.


[Task] shenyu-plugin-springcloud use shenyu-loadbalancer

Description
shenyu-plugin-springcloud use shenyu-loadbalancer
Task List

acquire servers from eureka
loadbalancer select server

can i try this

can i try this

I have did it. if you wanted, you can contribute issue #3511


[Request] [Funimation/Crunchy] Add queue list with download links

Hi
It will be very good to put a queue list with all submited download links that will start automatically after the last is done..
Should this feature be possible to be implemented?

You can already put anime you want in a list and download new episodes later?

Its more a feature to leave it download automatically while we are away from pc/sleeping.. this will save a lot of time..
with some flag on the command that add to queue, after download an episode, the next on the queue will get downloaded automatically..

I think it would be best for you to make a .bat or .sh file for that.

Thanks, it works.


Add image to horizontal dropdown

Kindly add image to horizontal dropdown like mega menu, just like product category

Check: folatadtextile.com

Hi pls update on this


Allow Cluster Network IP to be a variable in AWS config.

In the install-config.yaml the cluster network is hardcoded at <IP_ADDRESS>/16.  If you change the vpc and subnet variables in the aws config to something other than <IP_ADDRESS>/16 then install fails due to overlapping cidr ranges.  Should be able to pass a variable through for the cluster network if changing the cidr and subnet variables.

@satyamodi @shaithal

new variable "cluster_network_cidr" is added in variable.tf file which can be used for passing network cidr.

Thanks for adding this :-)


Does it support metadata lineage to OpenMetadata

Code of Conduct

[X] I agree to follow this project's Code of Conduct

Search before asking

[X] I have searched in the issues and found no similar issues.

Describe the feature
Discovering blood relationships through OpenMetada, but not supporting Spark, Flink, and other blood relationships. If using kyuubi to automatically generate blood relationships by executing ETL on SQL, submitting them to OpenMetada, or providing blood API integration
Motivation
No response
Describe the solution
No response
Additional context
No response
Are you willing to submit PR?

[ ] Yes. I would be willing to submit a PR with guidance from the Kyuubi community to improve.
[ ] No. I cannot submit a PR at this time.

Also, I would like to know if the engines supported by kyuubi, such as JDBC, Impala, Presto, etc., all support lineage analysis

Lineage extraction is computing engine-specific functionalities, currently, Kyuubi provides a Spark lineage plugin which supports extracting lineage from query plan and sending it to the Spark event bus, and you can consume such lineage events by implementing a Spark listener


Fix bugs

Fix a bug related to unicode.  Note we still don't tokenize unicode except to make all unicode characters tokenize to 1 uniformly.  But now it doesn't crash when we see a unicode character.
Fix a verbose warning in the numpy code related to casting.  The casting still works the same as before.
The tests pass.

The np.uint64 from splitter could be removed completely. It is there only to copy the behavior of Vasily's loader.
Similarly the string types could be possibly just strings instead of numpy specialities. On the other hand, I get that this is just a bugfix, so I think it can be just merged.

I'll just merge it now since it is needed for getting v15 to work.


User registration and authentication update

Make mobile/emailAddress readonly based on the verification option used

Example: If emailAddress verification method used, upon landing on the register form, the emailAddress field should be readOnly since it auto populates from the emailAddress provided

Add a userId parameter to the response payload for the user registration creation endpoint.
Update registration form to append userId on the query
Email verification link (to be confirmed with Ian) also refer to the additional information provided on requirement 4: https://github.com/shesha-io/shesha-framework/issues/2073
Hide the O.Auth option from settings since it is not yet implemented
If AdditionalRegistrationInfoForm has been specified, upon successful verification the user should complete the additional information:

Upon completion of AdditionalRegistrationInfoForm if specified the user should automatically be logged in and directed to GoToUrlAfterRegistration

Show the error message received from the endpoint, instead of the configured message

Example: If the username used already exists, the endpoint returns explicit error message, however the UI shows the configured error message

The error message shown in the screenshot appears when a user logs in without completing the required additional information

related item #https://github.com/shesha-io/shesha-framework/issues/2073

Validate email address and mobile number to first see if it does not exist on the system before sending OTP

Hi @OmolemoBlessingLethuloe , can we remove the question marks from the highlighted fields?


Preserve drawing buffer

Replaces #12845
Sets preserveDrawingBuffer: true.as default in WebGL context attributes to make the canvases exportable and compatible with forEachLayerAtPixel along with a disablePreserveDrawingBuffer() fallback method as suggested in https://github.com/openlayers/openlayers/pull/12845#issuecomment-939544606
Add a simple Heatmap layer to the Export Map example showing changes to the export needed to handle WebGL canvases..

Here are my quick thoughts on this.  I think we should

first deal with shared WebGL contexts before adding functionality that may only work without a shared context
next establish some rendering benchmarks
then determine how preserving the drawing buffer affects performance (different devices, layer setups, etc)
only preserve the drawing buffer by default if the performance hit is negligible, or failing that
only preserve the drawing buffer when we need to (e.g. instead of on every single frame, only when exporting, only when someone asks for data at a pixel, etc), or if that proves to be impossible to achieve
expose a method for people to toggle the behavior, experimental at first, eventually part of the API if we really can't do any better

I'm not in favor of this pull request because it changes the default behavior to something that might negatively affect rendering performance (without helping to establish whether or not or where this might be the case) and adds an API method that only allows opting out of this behavior (and doesn't allow opting back in).

Context sharing possibilities will surely be affected by layer zIndex if there are interspersed 2d and WebGL layers?  And any change of zIndex might change how they are interspersed and require shared contexts to be recreated.  For forEachLayerAtPixel to work for a single layer that layer needs a unique className applied to the canvas element (which already happens for both 2d and WebGL) preventing it being shared with other layers.  I think interspersed layer types and updateable zIndex will pose a greater problem than respecting a non-updateable className within that grouping.


miri doesn't catch a violation of &mut [u8]'s validity invariants

I think miri should fail on https://play.rust-lang.org/?version=stable&mode=debug&edition=2018&gist=a79f547a85d6d09e52756c2da3c121f4 because it produces an invalid &mut [u8] on line 11 (see context for reference interpretation).
Should it be an error to produce a &mut [u8] that references uninit bytes?

I missed this bit from the README: "In particular, Miri does currently not check that integers/floats are initialized or that references point to valid data."

For the int/float part, https://github.com/rust-lang/miri/issues/1340 tracks adding an option to check that.
But for references, I don't currently have plans to implement that -- it would be prohibitively expensive. Moreover I am anyway lobbying for relaxing that UB rule. ;)

Makes sense. I'm assuming it would still be prohibitive to treat slices differently than "thin" references.
I'd be interested to see a path for relaxing that rule, the ergonomics of single-write-only buffer usage is pretty rough. I have no idea what that'll look like, but you've got an eager audience :D.

I'd be interested to see a path for relaxing that rule,

The discussion is at https://github.com/rust-lang/unsafe-code-guidelines/issues/77. ;)
To summarize, I think we should change the description of invalid references from

A reference or Box that is dangling, unaligned, or points to an invalid value.

to

A reference or Box that is dangling, unaligned, or points to an uninhabited type (i.e., a type with no valid value).


Kinetics Options - Default Parameters

Suggest adding in default fuels/reactors to the kinetics options. Perhaps 4 options like: 235-U, 233-U, 239-Pu, and custom. This could also be implemented by allowing the user to select from several predefined options and then make modification, thus negating the custom option.
The current implementation loads defaults from a variety of sources (the beta and lambda info is 235-U). I would suggest, in general, that a consistent set of defaults be made available (perhaps PWR for now). Can also draw some of this info from publicly available FSAR/DCD.

Well I'm no fuels expert, but I understand the beta_i and lambda_i stuff to be characteristic of the primary fissile isotope. So what you have for 235-U is likely acceptable. Still might be useful to protect some of these from the user as 235-U, 233-U, etc. Like I said, I'm not the fuels guys here but we should ask one to see what actually does change from reactor to reactor, core to core, cycle to cycle, etc.
The reactivity coefficients, however, could be made slightly more consistent by using a common source such as AP1000 DCD (I mention this as this is what I am familiar with, not because it it the most useful. As NHES has been interested IRIS, maybe it makes sense to use that as default, but I digress). For AP1000, you could use the material in Ch 4.3, specifically Table 4.3-2. (https://www.nrc.gov/docs/ML1117/ML11171A445.pdf)
The challenge here is that many parameters are expressed as a functions of temperature and/or boron concentration. This implies the use of a separate module outside of PK (or perhaps inside a larger kinetic module) to calculate the effective temperature/parameter and then some sort of look-up table or spline function.
So the rabbit hole is quite deep here.


Vector Mixins

It would be nice to extend math objects (vec3, mat4, quat) with custom functionality.  That way if LÖVR doesn't provide something you need, you can add it yourself and have it work nicely.  I have four ideas for how to do this and I'm not sure which one is the best, so I'm deferring here until I have enough information or desperation to make a decision:

The __index key of the metatable for math objects could be the value of lovr.math.vec3, and then we give it its own metatable with a __call key.  This works and is sort of the ideal API, since you can just write lovr.math.vec3.customMethod = function() end.

The downside here is that it's just way too magical; the code will be ugly and nobody will understand it in the future without heavy amounts of documentation and thinking.

Add a manual lovr.math.mixin function where you can pass in all your custom functions and they'll be "installed" into the math objects.
Add a lovr.conf setting that lets you mixin your own math functions.
Do nothing: if you want custom vector functions, just write some functions that take vectors.

lovr.math.vec3 is now the vec3 metatable with a __call metamethod, and you can add your own functions to the metatable.


Issue with multiple calls to sticky()

When using the plugin twice, the second call uses the options of the first call.
example: http://jsfiddle.net/horst80/4JV4s/

@Tall-Paul Thanks for that work around it works! :)


Feature/vue config

Added additional eslint config for vue

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

@MBuchalik @georg-schwarz Code updated with the formatting changes and the package-lock.json

Perfect, thank you! 🎉 @georg-schwarz From my point of view, this can be merged. Or do you want to add anything?


[Immutable X]: Complete implementation

Description
WIP Starkey primitives
Checklist
StarkKey

[x] Derivation path from eth L1 address, replication of this implem
[x] GrindKey - replication of this implem
[x] Generate private key
[x] Generate public key
[x] Support new curve/pubkey_type / extend privatekey/publickey class to seemlessly used the starkey implementation
[x] Swift unit tests
[x] Android unit tests
[x] Refactor EIP 2645 part in eth folder
[x] Signing part
[x] EIP-191
[x] expose getting private key from signature to HDWallet + example registration
[x] More c Interface + unit tests swift/kotlin

StarkSignature
How to test

Run C++ unit tests

Since we don't it add registry, so this needs app's custom network feature support

I think it's just need a new kind of entry in assets repository for layer 2 application that belong to EIP 2645, not sure that's a custom network feature.
Can imagine such entry in assets repository (additionally can add website, symbol, rpc api etc):
{
    "layer": "starkex",
    "application": "immutablex",
    "index": "1",
    "keyMsg": "Only sign this request if you’ve initiated an action with Immutable X."
}


Investigate other designs

At the moment, the user can subscribe to incoming messages by passing a  MessageHandler, a default implementation for static Functions is provided, and the user can implement the trait if (s)he needs to.
It could be a good idea to grasp inspirations from other crates to know how such a pattern is handled. Giving the user an infinite iterator over messages looks (naively) like a possibility, but how do such "infinite, blocking iterators" work?
References:

Streaming iterator
May be an interesting approach:

while let Some(message) = eb.consumer("some-address") {
    // this is an infinite loop, though :(
}

"Go full async"
https://github.com/rust-lang/rfcs/blob/master/text/2033-experimental-coroutines.md

Using mpsc and iterators for now.
Async could be really interesting too, especially since Vert.x being async by nature, crate users would not be confused by an async implementation.


Egeria UI not working in 3.3 prerelease - nginx worker process exited

In the latest 3.3 prerelease chart, the egeria-ui cannot be accessed via :443 (directed at nginx service) due to
$ kubectl logs lab-odpi-egeria-lab-nginx-5d874c84d7-8q4bt                                                      [10:35:51]
/docker-entrypoint.sh: /docker-entrypoint.d/ is not empty, will attempt to perform configuration
/docker-entrypoint.sh: Looking for shell scripts in /docker-entrypoint.d/
/docker-entrypoint.sh: Launching /docker-entrypoint.d/10-listen-on-ipv6-by-default.sh
10-listen-on-ipv6-by-default.sh: info: Getting the checksum of /etc/nginx/conf.d/default.conf
10-listen-on-ipv6-by-default.sh: info: Enabled listen on IPv6 in /etc/nginx/conf.d/default.conf
/docker-entrypoint.sh: Launching /docker-entrypoint.d/20-envsubst-on-templates.sh
20-envsubst-on-templates.sh: Running envsubst on /etc/nginx/templates/..data/default.conf.template to /etc/nginx/conf.d/..data/default.conf
20-envsubst-on-templates.sh: Running envsubst on /etc/nginx/templates/default.conf.template to /etc/nginx/conf.d/default.conf
20-envsubst-on-templates.sh: Running envsubst on /etc/nginx/templates/..2021_10_12_09_35_45.797156721/default.conf.template to /etc/nginx/conf.d/..2021_10_12_09_35_45.797156721/default.conf
/docker-entrypoint.sh: Launching /docker-entrypoint.d/30-tune-worker-processes.sh
/docker-entrypoint.sh: Configuration complete; ready for start up
2021/10/12 09:35:53 [notice] 1#1: using the "epoll" event method
2021/10/12 09:35:53 [notice] 1#1: nginx/1.21.3
2021/10/12 09:35:53 [notice] 1#1: built by gcc 8.3.0 (Debian 8.3.0-6)
2021/10/12 09:35:53 [notice] 1#1: OS: Linux 3.10.0-1160.42.2.el7.x86_64
2021/10/12 09:35:53 [notice] 1#1: getrlimit(RLIMIT_NOFILE): 1048576:1048576
2021/10/12 09:35:53 [notice] 1#1: start worker processes
2021/10/12 09:35:53 [notice] 1#1: start worker process 42
2021/10/12 09:35:53 [notice] 1#1: start worker process 43
2021/10/12 09:35:53 [notice] 1#1: start worker process 44
2021/10/12 09:35:53 [notice] 1#1: start worker process 45
2021/10/12 09:35:53 [emerg] 42#42: setgid(101) failed (1: Operation not permitted)
2021/10/12 09:35:53 [notice] 1#1: signal 17 (SIGCHLD) received from 42
2021/10/12 09:35:53 [notice] 1#1: worker process 42 exited with code 2
2021/10/12 09:35:53 [alert] 1#1: worker process 42 exited with fatal code 2 and cannot be respawned
2021/10/12 09:35:53 [emerg] 43#43: setgid(101) failed (1: Operation not permitted)
2021/10/12 09:35:53 [notice] 1#1: signal 17 (SIGCHLD) received from 43
2021/10/12 09:35:53 [notice] 1#1: worker process 43 exited with code 2
2021/10/12 09:35:53 [alert] 1#1: worker process 43 exited with fatal code 2 and cannot be respawned
2021/10/12 09:35:53 [emerg] 44#44: setgid(101) failed (1: Operation not permitted)
2021/10/12 09:35:53 [notice] 1#1: signal 17 (SIGCHLD) received from 44
2021/10/12 09:35:53 [notice] 1#1: worker process 44 exited with code 2
2021/10/12 09:35:53 [alert] 1#1: worker process 44 exited with fatal code 2 and cannot be respawned
2021/10/12 09:35:53 [emerg] 45#45: setgid(101) failed (1: Operation not permitted)
2021/10/12 09:35:53 [notice] 1#1: signal 29 (SIGIO) received
2021/10/12 09:35:53 [notice] 1#1: signal 17 (SIGCHLD) received from 45
2021/10/12 09:35:53 [notice] 1#1: worker process 45 exited with code 2
2021/10/12 09:35:53 [alert] 1#1: worker process 45 exited with fatal code 2 and cannot be respawned

cc: @lpalashevski

This looks like a k8s configuration issue - specifically with the 'Operation not permitted'
In this case the chart is running on RedHat Openshift 4.8 - previous tests were done with 4.7 - possible cause?
The SCC has been modified as per docs

In #107 the chart has been updated to work ok in 'unprivileged' mode.  (+1 hr for images to update)
You need to add '--devel' to the 'helm install' command to pick up the latest pre-release charts
This has been tested ok using the 'restricted' policy in Openshift
Please reopen if it does not work for you


Update 07-bootstrapping-etcd.md

Hello, i notice there is a small typo in the step 07
Here is a PR to fix it :D
have a nice day <3

Hello:
What's the $PRIMARY_IP variable pointing to?:
--initial-advertise-peer-urls https://${PRIMARY_IP}:2380 \
--listen-peer-urls https://${PRIMARY_IP}:2380 \
--listen-client-urls https://${PRIMARY_IP}:2379,https://<IP_ADDRESS>:2379 \
--advertise-client-urls https://${PRIMARY_IP}:2379 \

Hi @pintof113
PRIMARY_IP is configured by the provisioning steps in Vagrant and is defined as the IP assigned to the VM on the VirtualBox (or Multipass) virtual network, as in the address assigned to the primary network adapter.
Either way, it's the outward facing IP address of the node, and would be the one you use to connect to NodePort services.

Thank you @fireflycons . Appreciate the quick response!


Wrap output longitudes to canonical range

Resolves #1097

I haven't changed the default behavior of Tangram::LngLat for now, but in the future it might be easier to enforce checks like this if LngLat constructors applied this wrapping automatically.

Hmm, maybe it does make sense to do wrap the lat lon in constructor itself to start with instead of doing it at a later stage. Do you have any thoughts on how it will not be a good idea to do it now? I do not see it being a larger code change.

Yes we could do this in the LngLat constructor now and it probably wouldn't break anything, but for that to really be useful we'd also have to make LngLat immutable (i.e. members are const). Unless we do that we won't really know for sure that LngLat members are validated (they could have been set to an invalid value after construction).
That seemed like a bigger change that I didn't want to bother with right now.

Ahh.. its a struct with public access to longitude and latitude. I am fine with this for the time being in that case.

Merging this with a note to refactor this code to make LngLat members immutable and provide apt accessors along with LngLat constructor taking care of wrapping the longitude values aptly.


[Project] Axon orientation

Would be interesting to look at fibers orientation and generate maps.
To get fiber orientation histogram:
Stats = regionprops(bwlabel(~~axonseg),{'Solidity','Eccentricity','Orientation','EquivDiameter','Area'});
u=[Stats.Orientation];
hist(u(~~u),100)

From that we should find the peak and compute std. Get a max angle. create maps.

Stale


Add attribute unused to silence compiler warnings

I am using the C snapshot as a part of a larger embedded project where I can't control the compiler flags (and using a precompiled library is not an option either). To avoid excessive warnings about unused functions, I added __attribute__((unused))
it has no effect on normal operation, and I am assuming that since the hacl-c is based on a verified library, the unused functions are not a problem,

Closing as mentionned in https://github.com/mitls/hacl-star/issues/51.
We can't edit the generated code manually, so we'll have to find another solution


Failure when restarting container

found files in /u01/app/oracle/oradata Using them instead of initial database
ORA-01078: failure in processing system parameters
LRM-00109: could not open parameter file '/u01/app/oracle/product/12.1.0/xe/dbs/initxe.ora'
Starting web management console
BEGIN DBMS_XDB.sethttpport(8080); END;

ERROR at line 1:
ORA-01034: ORACLE not available
Process ID: 0
Session ID: 0 Serial number: 0
[IMPORT] Not a first start, SKIPPING Import from Volume '/docker-entrypoint-initdb.d'
[IMPORT] If you want to enable import at any state - add 'IMPORT_FROM_VOLUME=true' variable
Database ready to use. Enjoy! ;)

@eduardotang Maybe you were restarting container not graceful or before it was fully initialized?


[gfx] metal backend skeleton

This is based on #4220 with some cleanup:

metal-cpp is added as a git submodule
removed metal-cpp-extensions
cleanup CMake files and make sure the metal backend skeleton compiles
return SLANG_E_NOT_IMPLEMENTED in unimplemented stubs

@jkwak-work thanks for looking at this. I've already done some follow-up work in a local branch and will put up additional PRs for improving/implementing parts of the backend.


how to add button each row

Issue Type (delete the irrelevant ones)

[x] Question

Specs
What version are you using?
2.13.3
What browser?
All browser.
Thank you for your librarie. I would like to be able to add buttons to each line instead of selecting a line and clicking on the button. Like this image:

It's similar to this https://github.com/xaksis/vue-good-table/issues/323 but I don't want my buttons to be included in the variable row.
Thanks for your help !

hey @nacimgoura you need to use a custom row template:
documentation - https://xaksis.github.io/vue-good-table/guide/advanced/#custom-row-template
in your case:
<template slot="table-row" slot-scope="props">
    <span v-if="props.column.field == 'action'">
      <button class="myButton" @click="doSomething(props.row)"></button>
    </span>
    <span v-else>
      {{props.formattedRow[props.column.field]}}
    </span>
  </template>

closing.

Thanks :wink: I didn't understand correctly.


Cannot install botocore 1.25.12 with pip

Describe the bug
When I run pip install botocore==1.25.12 I get an error:
Could not find a version that satisfies the requirement botocore==1.25.12 (from versions: 0.4.1, 0.4.2, ..., 1.25.11)

Expected Behavior
It should be installed without warning.
Current Behavior
pip install botocore==1.25.12 -v

pip.log
Based on the logs pip collects the available versions from this URL: https://pypi.org/simple/botocore/. When I open this website manually, I also don't see the mentioned version.
Versions on this page:
...
botocore-1.25.9-py3-none-any.whl
botocore-1.25.9.tar.gz
botocore-1.25.10-py3-none-any.whl
botocore-1.25.10.tar.gz
botocore-1.25.11-py3-none-any.whl
botocore-1.25.11.tar.gz
botocore-1.25.12-py3-none-any.whl

Note that botocore-1.25.12.tar.gz is missing.
I don't know in which system the error lies, but you might have some control over it.
Reproduction Steps
pip install botocore==1.25.12

Possible Solution
No response
Additional Information/Context
No response
SDK version used
1.25.12
Environment details (OS name and version, etc.)
Centos7
Python 2.7.5
pip 8.1.2

Hi @bencehornak-gls, this is a bug in the CDN fronting PyPI. There's an open tracking ticket in Warehouse (pypa/warehouse#10390), the system that PyPI is built on. We unfortunately have no control over fixing this. It will be resolved either when the CDN cache refreshes, or when we publish a new package (which is generally every weekday by 13:00 PT).
What's interesting here is that the wheel is available but pip isn't using it. All versions of pip released with Python 3.7+ should be defaulting to using the wheel. Could you provide more information about your environment (Python version, pip version, any global pip settings you've changed)?

Hi @nateprewitt, thanks for the insightful answer. You were right, today it started to work. Very frustrating CDN behavior, which makes our Chef provisioning totally unreliable.
Do you have any tips how I could work around this? In your experience would it help to fix our awscli (and thus botocore) to a version which is consistently accessible through the CDN?
Regarding my environment, I updated the description with the exact versions. I am using Python 2.7 due to external constraints.

Ah, I believe you have a few options. If you're using Python 2.7, we haven't released a version of Boto3 or the CLI that's compatible since July of 2021. Pinning your installs to awscli<1.20 and botocore<1.21 (boto3<1.18 if needed) should stop pip from trying to grab the latest version and backtracking.
A second fix is pip 9.0.2 and later should never try to grab this version of botocore for you. I would recommend trying to upgrade that if possible as it should mitigate the issue as well.
Let us know if you have any other questions or comments on the above options.

Thanks a lot @nateprewitt, I will try it with your instructions. I think at this point it is safe to close this issue, everything needed is here.


apis/workloads: move scheduling labels here

Those labels belong into the API package.

test fails.

Fixed


Add openvino QAT question answering and image classification

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.


AheadBy and BehindBy on Prompt

They seem to have been removed?  An older version of prompt had these lines (unless I always put them in manually :S can't remember) right before if($s.EnableFileStatus -and $status.HasIndex) {
if ($status.BehindBy -gt 0) {
    # We are behind remote
    Write-Prompt "(-" -BackgroundColor $branchBackgroundColor -ForegroundColor $branchForegroundColor
    Write-Prompt $status.BehindBy -BackgroundColor $branchBackgroundColor -ForegroundColor $branchForegroundColor
    Write-Prompt ")" -BackgroundColor $branchBackgroundColor -ForegroundColor $branchForegroundColor
}
if ($status.AheadBy -gt 0) {
    # We are ahead of remote
    Write-Prompt "(+" -BackgroundColor $branchBackgroundColor -ForegroundColor $branchForegroundColor
    Write-Prompt $status.AheadBy -BackgroundColor $branchBackgroundColor -ForegroundColor $branchForegroundColor
    Write-Prompt ")" -BackgroundColor $branchBackgroundColor -ForegroundColor $branchForegroundColor
}

Did I add those manually or were they in fact removed?

I can't remember seeing that functionality in the past however I have proposed PR #202 which would change the display of the branch's status if you have any feedback on how the information is displayed.
The current PR doesn't show how far ahead/behind the branch is.. my feeling is that it would likely add too much noise. How useful do you find knowing the amount that the branch is ahead/behind?

I don't recognize those changes @terryaney - they may, in fact, be yours. I've finally merged #202, and am also curious how useful you have found the ahead/behind counts to be.

Hmm...don't recall editing the files, but I guess I could have.  I find them use full.  Have 100s of private (client) repos that I'm cycling through.  When in command prompt and I switch to a directory, it is nice/easy cue as to whether I need to push changes if it has a +N in the prompt.  Additionally, I have a C# script that walks all folders doing an 'audit' of my GIt repos to see if any need publishing and they use those values as well to determine if I need to push (which is useful).

When in command prompt and I switch to a directory, it is nice/easy cue as to whether I need to push changes if it has a +N in the prompt.

With #202 merged you'll now see ↑ or ↕ anywhere you would have seen +N, you're just missing the actual count. For my part, that count is only interesting insofar as it is nonzero (communicated by arrows).

Additionally, I have a C# script that walks all folders doing an 'audit' of my GIt repos to see if any need publishing and they use those values as well to determine if I need to push (which is useful).

Are you using LibGit2Sharp for this or shelling out to Git? I wouldn't expect a change in posh-git to impact your script.

Reviewing my LINQ script...I do indeed just shell out git and determine ahead/behind by parsing the git status text (is ahead/is behind)...so I should be good.  Will give new posh-git a try, thanks.

I've created pull request #256, which makes the prompt configurable for how it shows ahead/behind in the prompt.

and am also curious how useful you have found the ahead/behind counts to be.

I find it really useful.  If I'm behind by a lot, it means I haven't pulled in a while, and I probably should do it soon.  If the count is pretty low, I'm fairly recent and don't have to worry.  If I'm ahead by a lot, then I probably have some commits I need to squash or should go check my outstanding code reviews for feedback/signoff to get them in.
It's really great when switching to a branch to see exactly how far behind or ahead I am.

This issue has been addressed by PR #256 which was merged recently. It will be enabled by default in the upcoming 0.7.0 release.


Force work related functions all disappeared and no errors found in the log file

My mod lists are:
[Mod list length: 5]
Harmony [https://steamcommunity.com/sharedfiles/filedetails/?id=2009463077]
Core [https:// no link (local mod)]
Royalty [Official DLC] [https:// no link (local mod)]
Ideology [Official DLC] [https:// no link (local mod)]
Achtung! [https://steamcommunity.com/sharedfiles/filedetails/?id=730936602]

The content of the log file Player.log:
Mono path[0] = 'D:/SteamLibrary/steamapps/common/RimWorld/RimWorldWin64_Data/Managed'
Mono config path = 'D:/SteamLibrary/steamapps/common/RimWorld/MonoBleedingEdge/etc'
Initialize engine version: 2019.4.30f1 (e8c891080a1f)
[Subsystems] Discovering subsystems at path D:/SteamLibrary/steamapps/common/RimWorld/RimWorldWin64_Data/UnitySubsystems
GfxDevice: creating device client; threaded=1
Direct3D:
    Version:  Direct3D 11.0 [level 11.1]
    Renderer: NVIDIA GeForce RTX 3080 Ti (ID=0x2208)
    Vendor:
    VRAM:     12108 MB
    Driver:   <IP_ADDRESS>4
Begin MonoManager ReloadAssembly
- Completed reload, in  0.087 seconds
<RI> Initializing input.

<RI> Input initialized.

<RI> Initialized touch support.

UnloadTime: 0.854000 ms
Command line arguments: -savedatafolder=C:\Users\fengh\AppData\LocalLow\Ludeon Studios\RimWorld by Ludeon Studios
RimWorld 1.3.3389 rev40
Save data folder overridden to C:\Users\fengh\AppData\LocalLow\Ludeon Studios\RimWorld by Ludeon Studios
Fallback handler could not load library D:/SteamLibrary/steamapps/common/RimWorld/RimWorldWin64_Data/Mono/data-0000023B15CD7DD0.dll
Fallback handler could not load library D:/SteamLibrary/steamapps/common/RimWorld/RimWorldWin64_Data/Mono/data-0000023B151B4C90.dll
Fallback handler could not load library D:/SteamLibrary/steamapps/common/RimWorld/RimWorldWin64_Data/Mono/data-0000023B15C27A50.dll
Fallback handler could not load library D:/SteamLibrary/steamapps/common/RimWorld/RimWorldWin64_Data/Mono/data-0000023B15C30480.dll
Fallback handler could not load library D:/SteamLibrary/steamapps/common/RimWorld/RimWorldWin64_Data/Mono/data-0000023B15C33690.dll
Fallback handler could not load library D:/SteamLibrary/steamapps/common/RimWorld/RimWorldWin64_Data/Mono/data-0000023B15DBBE00.dll
Fallback handler could not load library D:/SteamLibrary/steamapps/common/RimWorld/RimWorldWin64_Data/Mono/data-0000023B38D8D020.dll
Fallback handler could not load library D:/SteamLibrary/steamapps/common/RimWorld/RimWorldWin64_Data/Mono/data-0000023B390010B0.dll
Fallback handler could not load library D:/SteamLibrary/steamapps/common/RimWorld/RimWorldWin64_Data/Mono/data-0000023B38B15010.dll
Could not load reference to RimWorld.IncidentDef named VFEM_Disease_BlackPlague
(Filename: C:\buildslave\unity\build\Runtime/Export/Debug/Debug.bindings.h Line: 39)

ScenPart has null incident after loading. Changing to TraderCaravanArrival
(Filename: C:\buildslave\unity\build\Runtime/Export/Debug/Debug.bindings.h Line: 39)

Achtung v<IP_ADDRESS> Info: To make Achtung log some performance info, create an empty 'AchtungPerformance.txt' file in same directory as Player.log
Unloading 5 Unused Serialized files (Serialized files now loaded: 2)

Unloading 58 unused Assets to reduce memory usage. Loaded Objects now: 15688.
Total: 131.683200 ms (FindLiveObjects: 1.078500 ms CreateObjectMapping: 1.107500 ms MarkObjects: 129.424000 ms  DeleteObjects: 0.072800 ms)

Unloading 3 Unused Serialized files (Serialized files now loaded: 2)
UnloadTime: 0.338500 ms

Unloading 35 unused Assets to reduce memory usage. Loaded Objects now: 15796.
Total: 129.124600 ms (FindLiveObjects: 0.716300 ms CreateObjectMapping: 0.429200 ms MarkObjects: 127.904700 ms  DeleteObjects: 0.074100 ms)

Initializing new game with mods:
  - brrainz.harmony
  - Ludeon.RimWorld
  - Ludeon.RimWorld.Royalty
  - Ludeon.RimWorld.Ideology
  - brrainz.achtung
Unloading 0 Unused Serialized files (Serialized files now loaded: 2)

Unloading 0 unused Assets to reduce memory usage. Loaded Objects now: 19847.
Total: 184.792400 ms (FindLiveObjects: 1.109600 ms CreateObjectMapping: 1.801300 ms MarkObjects: 181.838500 ms  DeleteObjects: 0.042600 ms)

The game and all mods are the latest version currently on steam.

Uh, I get it. Must click exactly on the white lightning bolt icon for it to work. I don't remember that being the case before.
Wish there was a video with the details of the mandatory work.


Commands no longer work on 1.19.1 or higher

Description
With the introduction of 1.19.1, Minecraft introduced their new Player Safety Features. However this broke something in this command library. When running the Replicator in 1.19. It works as expected. Only when run in 1.19.1 or higher, the console can still execute commands but players commands to register in the console but are not executed.
Tested on a Macbook with M1 and a PC running linux with a amd64 chip.
Replicator
class Replicator : KotlinPlugin() {
	override fun onEnable() {
		command("test") {
			executes {
				// This always get executed for the console. Regardless of the version.
				// But not for players. Then it only runs on version 1.19 or lower.
				source.sendMessage("test")
			}
		}

		listen<PlayerCommandPreprocessEvent> { event ->
			// This is stil works! Even if the command is not executed.
			println("${event.player.name} preprocessed command: ${event.message}")
		}
	}

	override fun onDisable() {
		adventure.close()
	}
}

Hi! Fixed by https://github.com/dyam0/LirandAPI/commit/26f60a4baad168d97b38ffcc0160929dd2fbe387.
Thank you for reporting the issue and using this library!


Add Mac OS pre-built binaries

Right now, the build workflow only builds for Windows and Linux targets. We should also build a Mac OS version. Unfortunately I don't have a Mac so I can't test the builds. So I'm looking for someone with a Mac who is interested in helping to set this up.
In the meantime, users on unsupported platforms can always install the crate with cargo install project-cleanup to build from source.

Since version 0.7.4, Mac OS should be supported as well. With thanks to @ando for his Mac experience


Secure WebSockets

Does traefik support WSS ?  If so, how are they setup on the front end( i cant find any documents that cover even web sockets, but i see mentions of ws use on the web ).  I saw something about a rule, but i am not sure how that is pointed at a marathon app..
Also, i plan to run the app in marathon, do i just use the traefik.frontend.entryPoints=ws ( or wss? ) to stipulate its a wss only?
Lastely, does traefik support end to end wss?  For example, for end to end https, you just add a tag in marathon ( traefik.protocol=https ) .. is that then traefik.protocol=wss ?
Thanks!! :smile:

Hi @distributorofpain
1- Traefik does support wss as it supports https. Consider using the same frontend/entrypoint configuration for http/ws and https/wss.
2- traefik.frontend.entryPoints has to be set to an entrypoint name. For example in the following entrypoint:
[entryPoints]
  [entryPoints.foobar]
    address = ":80"

The name is "foobar".
In your case, just create an entrypoint like the following:
[entryPoints]
   [entryPoints.https]
   address = ":443"
     [entryPoints.https.tls]
       [[entryPoints.https.tls.certificates]]
         CertFile = "integration/fixtures/https/snitest.com.cert"
         KeyFile = "integration/fixtures/https/snitest.com.key"
       [[entryPoints.https.tls.certificates]]
         CertFile = "integration/fixtures/https/snitest.org.cert"
         KeyFile = "integration/fixtures/https/snitest.org.key"

Then attach this entrypoint to the frontend with traefik.frontend.entryPoints=https
3- And finally: yes, you can set traefik.protocol to wss.
TIPS- To test a simple end-to-end websocket client/server, use the following configuration:
[entryPoints]
   [entryPoints.https]
   address = ":443"
     [entryPoints.https.tls]
       [[entryPoints.https.tls.certificates]]
         CertFile = "integration/fixtures/https/snitest.com.cert"
         KeyFile = "integration/fixtures/https/snitest.com.key"
       [[entryPoints.https.tls.certificates]]
         CertFile = "integration/fixtures/https/snitest.org.cert"
         KeyFile = "integration/fixtures/https/snitest.org.key"

[file]
[backends]
  [backends.backend1]
        [backends.backend1.servers.server1]
              url = "wss://echo.websocket.org"
[frontends]
  [frontends.frontend1]
      backend = "backend1"
          rule = "Path:/"

Then run wscat -c wss://localhost:443/ --host echo.websocket.org (wscat is also available from the docker image joshgubler/wscat)

To followup on existing discussion, how would one configure WSS with Kubernetes Ingress[1]? I assume with an annotation akin to traefik.backend.srv1.protocol.url, but would be nice to define schema for the whole backend at once, considering how servers are populated and updated dynamically.
[1] Currently Ingress supports only HTTP rules.

@samber Thank you for replying with very useful information!  I have tested the setup and i can see the wss showing up in the traefik status page.  I am still having a problem getting websockets to work, but it might be something on the container side at this point.  Knowing what is needed is in place, cuts down the troubleshooting time!

Hi guys..
I tried using wss but the logs of traefik say:
time="2016-10-14T21:29:09Z" level=warning msg="Error forwarding to wss://server:8080, err: unsupported protocol scheme "wss""
Did anyone have success with wss?

@emilevauge Thanks a lot but maybe you can share the rules.toml that you've used for it? BEcause as soon as I use a backend URL that starts with wss://..., I get the message that wss is not a supported protocol scheme...

@ascora sorry, I misread your issue... Could you try using https instead of wss ?

Yes, that works fine.

@emilevauge  how do one set web sockets using docker backend

using docker-backend how will one take advantage of using web sockets

I have a question (and or feature request?)
[backends.app]
[backends.app.servers.server1]
url = "http://localhost:8433"
[frontends.free]
backend = "app"
[frontends.app.routes.test_1]
rule = "Host: app.domain.com"
This service handles both http and ws on a web app port 8433
I use traefik to convert to https://app.domain.com.
Currently wss is failing. How do I enable wss (and ws?) on the same domain, free.domain.com ?
Do I need two back-ends and two front-ends?  Two back-end servers and two front-end routes?
It would be nice (feature request here) if traefik receives a wss request to app.domain.com and there is no rule specific ws/wss rule, to just use the one for the http/https server.
Thanks if you can shed any light.


Integration of several bootstrapping techniques

To add: (all of these are variants)

[ ] Bayesian bootstrap
[ ] weighted likelihood bootstrap
[ ] fixed prior weighted Bayesian bootstrap
[ ] posterior bootstrap
[ ] random restarts
[ ] fixed initialisation

I suggest that we close this PR for now. Please feel free to open a new one if needed.


[prototype] add native-rendered Electron app

There are two ways to make the electron app:

[Approach 1, server-based, preferred]: Host UI at localhost:3000 and API servers at localhost:4000, and use Electron window as a browser. This approach makes it possible to open the app in the browser, so that

users can access the browser extensions.
lightweight, no need to render another embedded Chromium (the Electron renderer)
This approach should also make it easy to re-use the server-app logic.

[Approach 2, native-rendered]: Let host only API server on localhost:4000, and render the UI pages & components directly in Electron API. This is the regular way of using Electron.

This PR implements approach 2. It can now render the  page without a problem. However, approach 1 should be the way to go. Therefore, this PR is only for reference.

this PR is only for reference.

Actually, this PR is a general platform to build approach 1 as well. I'm merging this.


Record events for testing

Change description
What problem does this solve?
Issue number: (if applicable)
Example usage
Additional details and screenshots
Checklist

[ ] I have added unit tests to cover my changes.
[ ] I have added documentation to cover my changes.
[ ] My changes have passed unit tests and have been tested E2E in an example project.

Pull Request Test Coverage Report for Build c0cae7f92d012bff89a831a208db61e62de9fdb1-PR-28

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.2%) to 65.102%

Totals

Change from base Build 29bbf58b527cbb65ad469f4126b22372f38c67f4:
-0.2%

Covered Lines:
416

Relevant Lines:
639

💛  - Coveralls

We could probably mark the event files as being generated to not count towards statistics.
This doesn't yet include executing the events or testing.
Hit `http://localhost:4000/events?plugin=your-preferred-plugin' to get a list of events.
Oban events sometimes have a pid that we'll need to clean up.

Thanks for tackling this! Great work!!!


Refactor SriovNetwork and SriovIBNetwork controllers to use same code

Controllers were refactoring to use genericNetworkReconciler, which contains all logic
This is necessary to make it easier to add new controllers.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

153 of 189 (80.95%)  changed or added relevant lines in 4 files are covered.
6 unchanged lines in 3 files lost coverage.
Overall coverage decreased (-0.2%) to 37.643%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

controllers/generic_network_controller.go
125
161
77.64%

Files with Coverage Reduction
New Missed Lines
%

controllers/drain_controller.go
1
70.36%

pkg/client/clientset/versioned/typed/sriovnetwork/v1/fake/fake_sriovnetworknodestate.go
2
48.65%

pkg/daemon/daemon.go
3
48.01%

Totals

Change from base Build<PHONE_NUMBER>:
-0.2%

Covered Lines:
4789

Relevant Lines:
12722

💛  - Coveralls

used by #646

@zeeke @SchSeba
Could you please review this PR? :)
Thx!


Request: Mail Merge

Related issues: none.
My system: Macbook Pro 15" running OS X 10.11.3 El Capitan.
My Nylas: Version 0.4.10-4e3595b
Feature Request: Mail Merge

I want to be able to run a mail merge within N1 in order to personalize batch emails. I imagine this happening by running a variable contained within an outgoing email, such as {!FirstName}, against a list of names with matched email addresses (and potentially other details run against variables within the email).
Ideally, a user would have two options for connecting their mail merge name list. Option 1: they could import a CSV file of names and email addresses. Option 2: they could invoke the name of a Group within OS X's built-in Contacts app.

I would be willing to work with others as the designer on this project.

This is possible with the current API to send the messages to each outgoing email address.
The composer would need to be hooked to prevent the message from actually sending. My guess is to set the outgoing email address to something that can be tracked using a ComposerExtension.

@michael-montano, I'm curious if you have a design perspective of this mail merge implementation demo. The integration with OS X Contacts is an interesting idea.

@DavidChouinard – Great work!

Even though it depends on the availability of a reasonably large display, your inline approach with drag-and-drop column headers is a smart one. It's certainly an improvement over Word and Yesware's wizards, though I'd retain the option to use braces with typed header names for fast-moving users. (The brace-enclosed header names could convert to bubble references when the closing brace is applied, which would in itself create a check against errors.)
The ability to drag and drop a CSV is a nice touch. You kind of flash past it in the video, but I love the speed of that option (though one should also have the ability to open a list file directly within the mail merge feature). Even better might be to link N1 to a repository (or repositories) of lists so they are readily accessible via a drop down within the mail merge feature. (One such repository could be Contacts and its Groups.)
Down the road: Maybe the one good thing about Word's approach is that users can see all the merged docs simultaneously after running the merge. In your implementation, as with Yesware's, users have to take a bit of a mental leap of faith because they can't see all of their merged emails simultaneously, though they can click forward through them. I'd make a Wordl-style simultaneous view an option, too.

What's next?

@mbilker – Matt—I'm not an engineer, and I don't fully follow your comment, but it looks like @DavidChouinard and I have some clarity about where to go with this if you're interested in working together.

The video demonstrates the best UI/Ux of a mail merge tool. I'm brand new to N1. How feasible is it to create a plugin like this?

@amit777 The UI part seems reasonable. It'd be a composer extension and the drawer could go in the Sheet:Main:Footer region.
We'd ideally want batch messages to be queued and sent out server-side, but that would require integration from Nylas. Client-side, seems like it's possible for a plugin to programmatically generate many drafts and have them queued up to be sent. (queuing SendDraftTasks; this test shows how it's done)

Hey folks! Thanks for all the input—this has been shipped in 0.4.32. We went with a UI that was very similar to @DavidChouinard's and will continue to work on mail merge as a core feature of N1. Cheers!

Nice!

Hello.  How do I get mailmerge plugin runing on Mac?

@matthewdewstowe Built in to official release.
@bengotow Is this a Pro only feature?

I cannot seem to drag a variable, like {{firstname}} into subject line.  This is good for personalisation, but also avoids the problems with current threading.  I send the same mail to lots of people and it is all threaded together despite them all being different mails and having different responses.  @mbilker If you can help apprecaited!

Unfortunately, I don't use the Pro version of N1. I stick to a modified
open source version.
On Sat, May 21, 2016 at 4:32 PM matthewdewstowe<EMAIL_ADDRESS>wrote:

I cannot seem to drag a variable, like {{firstname}} into subject line.
This is good for personalisation, but also avoids the problems with current
threading. I send the same mail to lots of people and it is all threaded
together despite them all being different mails and having different
responses. @mbilker https://github.com/mbilker If you can help
apprecaited!
—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
https://github.com/nylas/N1/issues/1608#issuecomment-220798882

this feature existed in N1 but not available in Nylas Mail. I do have Pro subscription btw


Travis CI: Build for more platforms/compilers

Right now we only build for Linux and Mac on the nightly compiler. However, some of the crates may support being built on stable. Additionally, we should test on 32-bit. Thus:

[ ] Figure out which crates can be built without nightly. If there are any, then:

[x] Add beta and stable to the list of compiler versions
[ ] Figure out what minimum compiler version we can build with, and build with that version in addition to current beta and stable
[x] Use travis-cargo instead of normal cargo so we can use the --only nightly flag to make sure we don't run tests on beta or stable that require  nightly

[ ] Figure out if Travis supports 32-bit, and if so, run the tests on 32-bit

Partially addressed in #30.


RuntimeError: cdist only supports at least 2D tensors, X2 got: 1D

Thanks for sharing your code. I got the following error when running inference code.
File "PlaneFormers/planeformers/models/inference.py", line 76, in build_connectivity_graph
dist_mat = torch.cdist(emb_i, emb_j)
File "lib/python3.7/site-packages/torch/functional.py", line 1153, in cdist
return _VF.cdist(x1, x2, p, None)  # type: ignore[attr-defined]
RuntimeError: cdist only supports at least 2D tensors, X2 got: 1D

Could you  share the input images to reproduce this? Thanks!

Closing due to inactivity

Sorry for the late reply. I tried images from this dataset. https://iccv2021-mmp.github.io/subpage/dataset.html

Thanks for the message!

Which pytorch and detectron2 versions are you using?

Could you please print out the size of emb_i and emb_j before the cdist operation in line 76 in planeformers/models/inference.py and share that?

@samiragarwala

pytorch version 1.10.1, detectron2 0.6+cu102
Here are the print out of  the size of emb_i and emb_j
torch.Size([7, 128])
torch.Size([7, 128])
torch.Size([7, 128])
torch.Size([2, 128])
torch.Size([7, 128])
torch.Size([128])
I can run successfully with 2 input images but not for 3 or 4 images. Do I need to change anything to use more than two images?

Here are the results of a successfully with 2 input images. However, the visualization of the results looks weird.
https://1drv.ms/u/s!Arx_-0rtHxmn5FZKKI_9kFig0ah5?e=qpCcTL

Thanks for sharing all this information! To run more than two images, you don't need to modify anything except providing more input images files while running the model using run.py.
Could you try running the system on images from Matterport3D which can be found at https://github.com/samiragarwala/PlaneFormers/tree/gh-pages/resources?

@samiragarwala Here are the results of a successfully with 2 input images. However, the visualization of the results looks weird. https://1drv.ms/u/s!Arx_-0rtHxmn5FZKKI_9kFig0ah5?e=qpCcTL

I have updated the visualization code and it should work now!

@samiragarwala I tried images from Matterport3D. It runs ok. Do I need to re-train the model for other types of images?
The visualized images look correct now, but the texture map for the .obj still looks weird.

Could you share your output? In what sense does it not look right? I can look into it!


Calculate gmhi viz

This PR solves the issue #9. Specifically:

the calculate_gmhi pipeline has been reimplemented:

metadata file is not needed since the action doesn't produce any plot (only the qza artifact)
we removed the code responsible for MH_prime and MN_prime calculation (those parameters are now added as optional with default values coming from the Gupta et al. 2020 paper)

the calculate_gmhi_viz pipeline has been added:

first, it runs the calculate_gmhi action in order to produce the qza artifact
second, it generates the alpha diversity plot based on the output above and metadata file (which is now required)

This diversification (i.e. two separate actions) should allow for more freedom:

if the metadata file is not available, we can simply produce the GMHI values  (qza)
if the metadata file is available, we can generate (again, using only one command) both the GMHI values  (qza) and the alpha diversity plot (qzv)

The README.md file has been updated accordingly.

The logic of GMHI calculation is more clear now. Calculate GMHI accepts arguments needed for potential upcoming indexes derived on new training sets.
Further plan:

implementing "train_index" function, which would derive new species lists, MH' and MN' from a new large training sets consisting of feature table+metadata.


updated developer-guide.md to mention cni-plugin as dependency

Expected Behavior
BASEDIR
└───calico
└───libcalico-go
└───confd
└───felix
└───typha
└───kube-controllers
└───calicoctl
└───app-policy
└───pod2daemon
└───node
└───cni-plugin

Current Behavior
BASEDIR
└───calico
└───libcalico-go
└───confd
└───felix
└───typha
└───kube-controllers
└───calicoctl
└───app-policy
└───pod2daemon
└───node

Possible Solution
We need to update Developer-Guide.md
Steps to Reproduce (for bugs)
BASEDIR
└───calico
└───libcalico-go
└───confd
└───felix
└───typha
└───kube-controllers
└───calicoctl
└───app-policy
└───pod2daemon
└───node

1 - Clone the repositories into your development environment
2 - Run make dev-image.
It will throw below error and exit :
[INFO]	Removing: /go/src/github.com/projectcalico/calicoctl/vendor/github.com/onsi/ginkgo/integration/_fixtures/focused_fixture_with_vendor/vendor
make: *** No rule to make target `../cni-plugin', needed by `cni-plugin-dev-vendor'.  Stop.

Context
Developers cannot get a build without cni-plugin project

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.Muhammet Arslan seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.

Deploy preview for calico ready!
Built with commit eec389f4886933cfdbe4eb0c501a0cc61bdc9573
https://deploy-preview-2721--calico.netlify.com

@geass thanks! This LGTM
However, the CLA bot seems to be unhappy. I think it is because there are several commits here by different authors.
Could you update the PR to be a single commit? (I don't think the change warrants multiple commits).

For some misconfigurations of my git local, I had to close this PR and re-created again.
https://github.com/projectcalico/calico/pull/2724


Adding support for TS paths after ejecting

Is this a bug report?
No
Description
My team and I are trying to add aliased paths in TS after ejecting from CRA, and we spent a significant amount of time trying to figure out where in the config this option has been disabled, but we haven't been able to figure this out. Would someone more familiar with the codebase be able to point us in the right direction?
Thanks!

Unfortunately, this is pretty tricky and is the reason we haven't implemented it.
Can you be more specific on what you're trying to accomplish (a full example of the desired paths configuration please)?

Thanks for the quick answer, @Timer!
Good to know, we actually thought it was a feature that was disabled manually rather than something that just doesn't work!
The main thing we want is to have a way to import files with absolute paths, whether is src/*** or @components/*** or @/src/***...
I know you're working on the last one based on this PR #5118, but is there any way to work around this in the meantime?
Thanks again!

@kirakik
Not sure if it can help, but we have a fork which works with paths in yarn workspaces.

Disable tsconfig checks: https://github.com/everlutionsk/create-react-app/blob/d4959942b352adc083e30a888133c4430e8dc837/packages/react-scripts/scripts/utils/verifyTypeScriptSetup.js#L130

Modify babel-loader include/exclude: https://github.com/everlutionsk/create-react-app/blob/d4959942b352adc083e30a888133c4430e8dc837/packages/react-scripts/config/webpack.config.js#L370-L371. This basically checks if a project is an monorepo.

Modify TS checker to report errors on files outside of src directory: https://github.com/everlutionsk/create-react-app/blob/d4959942b352adc083e30a888133c4430e8dc837/packages/react-scripts/config/webpack.config.js#L672-L679
(I know, it is quite ugly, but it works for us)

With those changes, you can add something like the following into tsconfig:
"paths": {
   "@app/*": ["packages/*"]
 },

and then use it like:
import Link from @app/common/Link

Disclaimer: It is a WIP and we still experimenting with it but it works for our needs.
See https://github.com/facebook/create-react-app/compare/master...everlutionsk:master for all of our changes.

@kirakik if you've ejected you should be able to disable verifyTypeScriptSetup and then configure TypeScript paths like so:
{
  "baseUrl": "src"
}

In conjunction to creating an .env file with NODE_PATH=src. This behavior should "just work" without other changes, then.
We'll get the @ support working very soon, and you should be able to un-eject then. :-)


I will arrive at 350 Moonlite Dr, Idaho Falls around 5:36 PM. I’ll let you know if I’m running late.

Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
Describe the solution you'd like
A clear and concise description of what you want to happen.
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
Additional context
Add any other context or screenshots about the feature request here.

I will arrive at 350 Moonlite Dr, Idaho Falls around 5:36 PM. I’ll let you know if I’m running late.


Parsers for different kinds of notation

The JME parser is now abstracted out, so you could create a separate parser object to interpret non-standard syntax.
This issue is to collect use cases for this, and for ideas about how it would work for the question author.
Use cases
Some of these are slight changes to the normal parser, and some are completely different notations.

j instead of i for complex numbers.
i, j, k are orthogonal unit vectors.
inline HTML, eukleides scripts, etc.
Use square brackets for grouping instead of list access (#659)
Set-builder notation, e.g. {x in R | x>2 and x<5}
Solutions of equations, e.g. x=1 or 2
Allow sin^2(x) = sin(x)*sin(x) (#478)
Juxtaposition of names and brackets means multiplication, e.g. x(x+1) = x*(x+1).
Force single-letter variable names, e.g. ab = a*b.
Single-argument functions without brackets, e.g. sin x.
Different grouping of implicit multiplication in division, e.g. a/2b = a/(2*b).
Make names case sensitive, so a isn't considered identical to A.
Differentials, such as dx and dtheta (#770)

Implementation
At the very least, a JME function parse(expr_string, parser) which returns a TExpression.
There could be an escape code to switch to a different parser. JavaScript has the ability to put a function name before a template literal, e.g. fn`my string` - we could do something similar.
Or, wherever there's a setting which takes a JME value, there could be a drop-down to pick a parser. This would make the interface quite cluttered.
The "mathematical expression" part could have a "syntax" option, which defines the parser used for the correct answer and the student's answer.
The other end of this is that the TeX and JME renderings of parsed expressions need to use the same syntax, so that you don't for example type '2j' and have it rendered as '2i'. That probably means that expression trees need to keep a reference to the parser that was used.

Aren't some of these already fixed?

j instead of i for complex numbers.
i, j, k are orthogonal unit vectors. (custom constants)
Make names case sensitive, so a isn't considered identical to A.

@jhoobergs yeah, good point!
I don't think there's any way around having multiple parsers, if you want to accept these notations. There are many mutually-exclusive notations in that list.
It's already good practice to remind students about syntax when their answer might involve something they don't use all the time.

Elixir has "sigils" for breaking out into a different notation, which I like. They start with a ~ and a letter, then a delimited substring.
For example, a date is ~D[2022-09-22], and a list of words is ~w(blue red green).
We don't currently use ~ for anything, so we could adopt this for these kinds of notation.


Refine smoke test configurations

Smoke tests seem to be slower than 90m recently, so we increase the timeout to 120m
and set the stacktrace timeout monitor to 90m.

@bot-gradle test this

OK, I've already triggered ReadyForMerge build for you.

@bot-gradle test this

OK, I've already triggered ReadyForMerge build for you.


Autowired Environment is null

Hi!
I try to add OAuth2 support to my program, and I follow the tutorial for https://github.com/eugenp/tutorials/tree/master/spring-5-security-oauth.
But the autowired Environment from SecurityConfig.java is null. I catch the NPE and throw a RuntimeException, and I get this error:
    2019-02-15 17:34:53.595  INFO 11099 --- [    Test worker] ConditionEvaluationReportLoggingListener :

    Error starting ApplicationContext. To display the conditions report re-run your application with 'debug' enabled.
    2019-02-15 17:34:53.599 ERROR 11099 --- [    Test worker] o.s.boot.SpringApplication               : Application run failed

and later
Circular reference involving containing bean 'securityConfig' - consider declaring the factory method as static for independence from its containing instance. Factory method 'clientRegistrationRepository' threw exception; nested exception is java.lang.RuntimeException: env did not get autowired

Looks to me as if the the clientRegistrationRepository method gets called before all the Springy stuff doing the autowiring is up and running.
I am still new to Spring, but as I understand, a working ApplicationContext is necessary for Autowired to work. So I see a chicken&egg problem here.
I assume your example works fine as-is, so where could I start digging in my program?
Thanks
Martin

@MartinEmrich  It's difficult to say without seeing your configuration. Does your SecurityConfig class have the @Configuration annotation and extend the WebSecurityConfigurerAdapter? To be scanned by Spring, the class needs to have the annotation and be in a package below the main application class.
Also note that if you have a Spring Boot application, then the clientRegistrationRepository bean will be created through auto-configuration, so you don't need to define it explicitly.

Hi!
Yes, it has the @Configuration annotation. An Excerpt:
@EnableResourceServer
@Configuration
public class SecurityConfig extends WebSecurityConfigurerAdapter {

/* .... */
	@Autowired
	private org.springframework.core.env.Environment env;

	private ClientRegistration getRegistration(String client) {
		logger.debug("getRegistration called for " + client);
		if (env == null)
			throw new RuntimeException("env did not get autowired");
/* ... more stuff ... */

		return getBuilder(client).clientId(clientId).clientSecret(clientSecret).build();
	}

/* ... */

On startup, I get this error:
2019-03-01 11:23:00.022  WARN 22554 --- [  restartedMain] ConfigServletWebServerApplicationContext : Exception encountered during context initialization - cancelling refresh attempt: org.springframework.beans.factory.UnsatisfiedDependencyException: Error creating bean with name 'securityConfig': Unsatisfied dependency expressed through method 'setContentNegotationStrategy' parameter 0; nested exception is org.springframework.beans.factory.UnsatisfiedDependencyException: Error creating bean with name 'org.springframework.boot.autoconfigure.web.servlet.WebMvcAutoConfiguration$EnableWebMvcConfiguration': Unsatisfied dependency expressed through method 'setConfigurers' parameter 0; nested exception is org.springframework.beans.factory.UnsatisfiedDependencyException: Error creating bean with name 'org.springframework.security.config.annotation.web.configuration.OAuth2ClientConfiguration$OAuth2ClientWebMvcSecurityConfiguration': Unsatisfied dependency expressed through method 'setClientRegistrationRepository' parameter 0; nested exception is org.springframework.beans.factory.BeanCreationException: Error creating bean with name 'clientRegistrationRepository' defined in class path resource [com/empolis/esa/esacore/SecurityConfig.class]: Bean instantiation via factory method failed; nested exception is org.springframework.beans.BeanInstantiationException: Failed to instantiate [org.springframework.security.oauth2.client.registration.ClientRegistrationRepository]: Circular reference involving containing bean 'securityConfig' - consider declaring the factory method as static for independence from its containing instance. Factory method 'clientRegistrationRepository' threw exception; nested exception is java.lang.RuntimeException: env did not get autowired

If I don't want to use one of the predefined identity providers (Google, FB, ...) but use my own, don't I have to configure my own clientRegistrationRepository?

After living with hardcoded values for two weeks, I tried using it again, and this time it worked.
I guess some seemingly-unrelated change somewhere else in my code made it work?


Added deprecation message to check_contract.

Oh, I think we need this in check_contract.rs - we often call it directly like this:
cargo run --example check_contract ../../artifacts/hackatom.wasm

Sorry for the confusion

we often call it directly like this:

If we can replace this CI step with the script directly, we can get rid of the shell wrapper:
      - run:
          name: Check development contracts
          command: |
            echo "Checking all contracts under ./artifacts"
            docker run --volumes-from with_code rust:1.59.0 \
              /bin/bash -e -c 'export GLOBIGNORE="../../artifacts/floaty.wasm"; cd ./code/packages/vm; ./examples/check_contract.sh ../../artifacts/*.wasm'
            docker cp with_code:/code/artifacts .

I doubt the .sh is used anywhere outside of this repo.


"Enable debug" is the old "unlock_menu" features?

"enable_debug": false
is the old
"unlock_menu": false

@LittleZen Yes! Changed name

disable_intro_movies
is the new
skip_start_menu ?