Static Data Loading Architecture ADR

Conversation with Ops
Write up ADR

@hectcastro I sent you an invite to edit the initial draft of the ADR. We'll work through draft 0 in Google Docs and then I'll refine it and submit a PR.


Error when a struct contains a field of type Vector{Number}

The file is as follows
# filename: struct_vector.jl
struct MyVector
    data::Vector{Number}
end

Here's the error, with Julia 1.6.0 and github version of JET.jl:
julia> report_file("struct_vector.jl", analyze_from_definitions=true);
[toplevel-info] virtualized the context of Main (took 0.029 sec)
[toplevel-info] entered into struct_vector.jl
[toplevel-info]  exited from struct_vector.jl (took 2.113 sec)
[toplevel-info] analyzing from top-level definitions ... 2/2
═════ 1 possible error found ═════
┌ @ struct_vector.jl:2 Base.convert(Core.fieldtype(MyVector, 1), data)
│┌ @ /buildworker/worker/package_linux64/build/usr/share/julia/stdlib/v1.6/LinearAlgebra/src/factorization.jl:58 _(f)
││ no matching method found for call signature: _::Type{Vector{Number}}(f::LinearAlgebra.Factorization)

dup of #145.


Error in visualization and download

In this deployment, there is an error when inspecting the WeekBasedCapacityGroup. Downloads return html instead of the desired artifacts and the frontend doesn't render the pages properly. Since neither function, I suspect this is a backend issue with the semantic hub and not due to the portal's visualization. Screenshot:

A failed download for the aspect-ttl looks like this:
<!doctype html><meta charset="utf-8"/><link rel="icon" href="data:image/x-icon;base64,iVBORw0KGgoAAAANSUhEUgAAADAAAAAwCAYAAABXAvmHAAAAAXNSR0IArs4c6QAABT1JREFUaEPlWT1MY0cQ/ubZkEhJ4TRJS9oIg9FhpFSBpDgp8SNcF0xxRkkPaS8Fpri0QJ8I7iTs64AzKZNAFQkjYWyU9qBMmoCUSLnEZqJ9frbfz+6+fTa6QLKlPW9nvtnZ+WZmCQMu3kQKr2EFQAGECZrH+YBbxvqcYkkHhLmMaTA2AYw4fxFmaB4Hg+wZ99u+AXAJawCWfQrvAgA3ZH4EkAl5604AKGELwEPpUd8RAC+6MR9EcUcAsPKi/R8B7PyUGUkmmw+JaITZzWbAJZgOmi1r78H7NW1ajpWFeBsZEE5u4gSE4UNDrRVmFCJS567FrdVPpn6uyeSMAXAZK2AUtcoMQmjnJJNKNFsrFEzBUQTAtGxP1TfC1y7iQy5jxCWr6SgdILyrY+Lvjt7LsJXY8YRK5JZeASJs5SYbi77fdDvwNpZAjtdTBpquKK+Wq1RHVwDSn6CBEhBv2JNnXQKVhpBDVq9jDdHx2VPJWKQFhyN8S3j9mpKbAIeJz8RgqQzP2Nkzp2QJAdAyrVzhlSjkKI/d4N+Vo7ElEK/3baf6wwM725gJAejD+EMQCsG4b6fGlijyou9Nz8hDAjlOYPAcgA90wIeH6Z374/VffSfAJQhvLRl4THi9SHlH3rdcr5veGzBwRYSCPdnwnWDlKL0FUpQsQqNFs/a9eqULwC2NRZEWtU5BmAt5/SSTSjYdrwvvGS0C9v5OJgoPJmqXsg8qx+kaGOOy/wg0n8vWn3kB7ILxqVYzY5UWwlxQOU7PuanWJFs5XrdAxVy2rr0flePRdTDJI8LlBQcAP8UbSOL3CONDWUaQUlyvAzhsNhOFYIng8I3IKp6OrlIdKwIsur3QYvDXs9mzr9oASvgQwPcaABuU9zcvleroNBFtmpKSzutccsJOhF+K8r3MaA7gGT7DNcpKAC/xFi2iG6fPq+m1WKUA4dS6bhWC9Yyb9Xz3pj8AZXwOxjdSAIQ9mu9dzP3q2DKDRTtpuGjVztZDDOz1unej/gBs4zEIj6QWBS5upTp2YsSqeq+LuPb3067yVwAgrW5oOh4g3mgmksVgegxNMSQe+5cB0AVwXejUKV77pFOMWwWA8aQ5lFgOeb3dBImLalLMnVK+J2eehWLdAX8IqUoBJz2bNEG+Y/IT5X41vcuQkyuBvshl69+2eaBPAKpSwG2Cdgy93oHg4xqXJH9TpTpfKREXgPA6GMuzU41Q/R+zCRL2SctxbRkBIGHRRx/fq/8Q+wREg/JXa/hSWgq056TmJTRhD3+i4CVJgej5UbpA7XujXMPD9Ob98fofHQCPQHiskA6VEUE5FSlp9A/UBInQzWUbTtXbBqAvJWqUx4TMGFkpYEDPN9AEBVpKLsEWJ6dRvk55fBnI690CzMDoTqwP3gTJmnp+ireRxC8RhogmunNpxTDKPNaBG2qC6KKZtDJeruk1NCXnYULbhxp62i92Q00QCKfNRGI6SJReACIkRO6+qXUqxjK0gNBI0CTLeI3QtZ7Bpl49+48DS+H1zhb7x+kXJo2QSesZngsNFkoX7phF+U7mjlzEG4N+Kcrx4Efyydw2iiDn5THO2sBLFIOkFNxAtKIARUw/5E2QzBjldNoZpVsoRk4qAGleVyGPAmBxa0I1So8FoCPsFmZzIOdJVYxNUiCc4xo1WDiI+6waBcDONoxH/l0mjhMng8r+xwHQhZ2ttx/NDVes4zLcUyumPQHGE3uqEfXk5Nv/9gBQMG2U024HgECBFmV0gKXjiA8u6w8h9RTDVNMrPwH3lfKciLdksyNTwzty/wATsrFPLbsvywAAAABJRU5ErkJggg=="><meta name="viewport" content="width=device-width,initial-scale=1"/><link rel="manifest" href="/manifest.json"/><title></title><link href="/static/css/main.a00cac5d.css" rel="stylesheet">

@arnoweiss and @thomas-henn,
This issue in the Semantic Hub is specifically regarding image generation for models using the SDK. Which is already fixed in the Semantic Hub 0.2.15 version.
The error occurred during the generation of SVG or PNG images for models, as the SDK was creating new temporary files for each "get diagram" request. This process would eventually lead to memory saturation and subsequently, the pod will go down.
For the older version of the BAMM model, we were utilizing the Open Manufacturing SDK, while the BAMM 2.1 and SAMM models relied on the ESMF SDK for diagram generation.
I am pleased to inform you that I have successfully addressed and resolved this issue for the ESMF SDK. The corresponding pull request has already been merged in SDK version 2.2.3.
In our discussions with Roman and Matthias, we determined that we had not pursued a fix for the Open Manufacturing SDK, as we were aware of its impending removal from the Semantic Hub. Consequently, in the latest Semantic Hub version, the usage of Open Manufacturing SDK has been eliminated.
Please be advised that this image generation issue will persist only for older BAMM models, as the Open Manufacturing SDK is used. if we use SH version 0.2.14 or lower. We anticipated that this problem would persist until the older SDK is removed from the codebase.
If you have any further questions or concerns, please don't hesitate to reach out if not then I request to close this issue.

@richaashara , @ma3u , @arnoweiss : The backend is updated to the newest sdk (2.4.2).
Is the UI Part done?

@tunacicek , Could you please check from portal team for the UI issue.

We could possibly look into the problem of the UI. For this we would need the following information:

How does the backend need to be called (url) to get a diagram back to a semantic model?
How must the backend be called (url) to get back a semantic model file (.json, .ttl , ... )?

We may also need support to run the test scenario locally. Although it should be easy to start the frontend locally, the question remains whether we can easily access the test scenario in the local development environment.

Fixed


Unable to add material[UR20_DIFF_8bit_2K_png_002-material]

Hi,
I am using Jazzy & ur_simulation_gz to simulate an UR20. When launching the default launch with
ros2 launch ur_simulation_gz ur_sim_control.launch.py ur_type:=ur20
I get the message Unable to add material[UR20_DIFF_8bit_2K_png_002-material] and the UR20 spawns with the blue covers of the upper arm without texture.

There is a reference in https://github.com/UniversalRobots/Universal_Robots_ROS2_Description/blob/rolling/meshes/ur20/visual/upperarm.dae#L165, but it seems that there is no declaration of the material?
Thanks

Thank you for reporting this. The material itself comes from the png file which lies next to that. Possibly GZ Sim doesn't read that one correctly.


[Go Live][March 03]

Push to live

Docs Build status updates of commit b018244:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

msteams-platform/feed.atom
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel


Fix typo in rouge types

Minor typo fix in the code and doc example that does not align with the writing style (rougeLsum -> rougeLSum).

The name of the variable inside rouge_score uses a lower-case s (see here):
elif rouge_type == "rougeLsum":

So I think we should leave it as it was. Why did you want to change it?

The doc state otherwise. Whatever name you want to use, it is just not uniformized.

Ok I see, then let's go with the lower-case version since that's follows the code.

Updated.
P.S. I feel like rouseLsum is an odd writing style (rougeL but you add another word, and now is it rougeLsum (same comments for variable names rouge_Lsum but also rouge_L)), but hey it is your code base.


Update Kyverno v1.6.2 -> 1.7.0

Update Kyverno dependency to v1.7.0
https://github.com/kyverno/kyverno/releases/tag/v1.7.0

This was addressed by #239.


remove paternalizing mnemonic writedown check

Allow users to set up an account with no effort at all and directly suggest calling the faucet after account creation (popup?)
user selects

import account -

user enters mnemonic
continue like below

create account

set name (optional. default to 'my account')
set pin code
confirm pin code
choose to call faucet yes/no

Shall we get rid of the AdvancedAccountOptions (EncryptionType and SecretDerivationPath)?

why? I'd keep it for now as the user doesn't have to bother.

ok

Was fixed with #94


Svelte guide not working due to NodeJS version

Expected Behavior
The page will be deployed as stated in the guide: Guide
Actual Behavior
The pipeline failes due to old NodeJS version:
npm ERR! notsup Unsupported engine for<EMAIL_ADDRESS>wanted: {"node":"^12.20 || ^14.13.1 || >= 16"} (current: {"node":"12.18.0","npm":"6.14.4"})
Section that requires update
Either the guide needs to be updated to show a solution on this conflict or the pipeline needs to be upgraded to a newer version of NodeJS

cc @lukeed

Ah ya, looks like it was changed here: https://github.com/sveltejs/kit/commit/261ee1cff9385feda45033ca7620ab2031e44e41#diff-0ac36eb0a5cc3505c582d3959e4bb51093770685d0de4a864f7cd9b68bd50b8f – beta things
I'll update the guide to reflect this


Enhancements around Deceased contacts, fixes #1870, #1750, #1588, #1572

Warning
Info
Issues
Fixes #1870
Fixes #1750
Fixes #1588
Fixes #1572

it looks like if the only remaining household member is deceased, you avoid removing them from naming.  But I thought the user story was to somehow make the name show this.  ideally customizeable, but that is probably too big a lift for now.  I thought we were maybe going to just put (deceased) after the lastname.  Sorry if I'm premature in reviewing this, or you guys decided to not do the special naming part.

Not premature. Mary was happy with just not renaming households when the last person is marked deceased. I think we can include this as-is and discuss a new naming method as an enhancement.


Several e2e are failing

Description
See https://github.com/digdir/dialogporten/actions/runs/9632734094/job/26566377714 for details
This has been failing for some time without any notice, related issue #876

Just the one failing now. Org filtering, seems like aux Org is set to digir, but all dialogs get digdir as Org.

Fixed now


objc_setAssociatedObject(… OBJC_ASSOCIATION_RETAIN_NONATOMIC) won’t compile

My code
objc_setAssociatedObject(cell.button, kAssociatedSaveKey, save, OBJC_ASSOCIATION_RETAIN_NONATOMIC);

generates
Error		reference to 'OBJC_ASSOCIATION_RETAIN_NONATOMIC' is ambiguous	Six Ages	C:\Users\User\Documents\SixAges\Source\App\SavedGameDataSource.m	129
though there’s no indication of what it is trying to pick between. (And of course, this works fine on iOS, compiled by Xcode.)

This is hard to say. The bridge only has one definition of this value. so this is likely coming from elsewhere.  Can you follow the instructions here to enable verbose build output and compile only the file above (ctrl + f7)?  That should give you the include paths to begin with.

I wonder if it's this?
C:\Users\User\Documents\SixAges\Source\App\SavedGameDataSource.m(129,66): error : reference to 'OBJC_ASSOCIATION_RETAIN_NONATOMIC' is ambiguous
C:\WinObjC\include\objc/runtime.h(896,2) :  note: candidate found by name lookup is '::OBJC_ASSOCIATION_RETAIN_NONATOMIC' (TaskId:15)
C:\WinObjC\include\objc/runtime.h(896,2) :  note: candidate found by name lookup is '::OBJC_ASSOCIATION_RETAIN_NONATOMIC' (TaskId:15)
Six Ages.log.zip

@DHowett-MSFT mentioned that he has seen this before when clang modules are enabled.  This is very likely a result of this definition coming from two different modules.  You can turn clang modules off as a workaround by opening the solution properties:

If you are using @import, you'll have to change those to #import as needed.

Yes, that works (for now, I turned it off only for this source file, since I occasionally do use @import. Thanks for getting me on to the next issue… (I don’t consider this issue resolved, since I assume the goal is to handle modules.)

"reference to 'OBJC_ASSOCIATION_RETAIN_NONATOMIC' is ambiguous" was fixed in PR #1515


[Bug]: Tooltip on Update Mode option needs to start with capital

Is there an existing issue for this?

[X] I have searched the existing issues

Description
When I hover over the Update Mode option to know what it does, the tool tip that appears for it starts with a lower case. It should start with an uppercase.
Steps To Reproduce

Drag and drop a table widget
Hover over the Update Mode property in the property pane

The tooltip on this starts with a lower case letter. Change it to upper case.

Public Sample App
No response
Version
Release

@sbalaji1192 can you fix this asap?

@dilippitchika Sure. I will fix this along with https://github.com/appsmithorg/appsmith/issues/15256


Dapr CLI version update

Describe your changes
Dapr CLI version update to version where https://github.com/dapr/cli/issues/1043 is fixed.
Issue ticket number and link
AB#11317
Checklist - Manual tasks

[ ] Examples are executing successfully
[ ] Created/updated unit tests. Code Coverage percentage on new code shall be >= 80%.
[ ] Created/updated integration tests.
[ ] Devcontainer can be opened successfully
[ ] Devcontainer can be opened successfully behind a corporate proxy
[ ] Devcontainer can be re-built successfully
[ ] Extended the documentation (e.g. README.md, CONTRIBUTING.md, Velocitas)

@mml5bg  please also upgrade the version in the example apps! Thanks!

@mml5bg  please also upgrade the version in the example apps! Thanks!

Done!


micro:bit Windows 10 app - Downloading program doesn't erase the file system

On the Windows 10 app for micro:bit, when a program is downloaded to the micro:bit the file system is not erased.
This might be done by design, but it's possible users are expecting flash to be erased, as this is the default behaviour of downloading a program from the web app.

Please let me know if this still reproes. I will move it to pxt-microbit repo.


feat(Landing): introduce micro-github-latest service for downloading the latest app

…the latest app
Issue:
What I did
How to test

Deploy preview ready!
Built with commit 476a9b5f146f4375f0a44cf780a1357b8aacf4a7
https://deploy-preview-453--mcs-lite-ui.netlify.com

Deploy preview ready!
Built with commit 476a9b5f146f4375f0a44cf780a1357b8aacf4a7
https://deploy-preview-453--mcslite.netlify.com

Deploy preview ready!
Built with commit 476a9b5f146f4375f0a44cf780a1357b8aacf4a7
https://deploy-preview-453--mcs-lite-introduction.netlify.com


nixos/bluetooth: add support for INI generator

Add services.hardware.bluetooth.config option
Use lib.generators.toINI with both config and extraConfig options
extraConfig can be preserved to maintain compatibility with existing configurations.
It can also be removed later.

Motivation for this change
This can allow for modular changes to Bluetooth configuration, like using ControllerMode = dual for AirPods.
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[ ] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

This change is

Your description says you use toINI for extraConfig... if that were the case can't you just drop the extraConfig option?
Are you sure you want to set the value of config in the default?

@aanderse What about the already existing configurations using extraConfig? This is a breaking change.

Are you sure you want to set the value of config in the default?

Great question. Is the default value always overwritten? If yes, I can define a set with default values and merge it with user config on write.

What about the already existing configurations using extraConfig? This is a breaking change.

I'm of the opinion you should change the default to null and add a warning that extraConfig has been deprecated, the user should switch to config and leave that around for a release or two before entirely removing.

Great question. Is the default value always overwritten, and not merged? If yes, I can define a set with default values and merge it with user config on write.

Yes, overwritten. If you want merge behavior (which you probably do) you can set the defaults you wish in the config section of the module.

Thanks, very helpful. r? @aanderse

Without testing, how about something like this?

@aanderse Thanks a lot - that looks great! I'll test this.

@lovesegfault Isn't it deprecated via a warning? If that's not enough, could you please clarify how to deprecate it properly? Thanks!

@filalex77 Oh, I missed that line :)

We can explicitly remove the option in a release or two when people have migrated their configurations.

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/prs-already-reviewed/2617/73

@lovesegfault @aanderse @worldofpeace Is there anything missing from this PR?

@filalex77 not from my perspective. Thanks for your contribution! :tada:


Seed hanging

When running seed, it just hangs. Ran the tests and am getting a timeout error: Error: timeout of 5000ms exceeded
I'm running this on a local machine. Can you advise? Thanks

How many files or whats the size of the json files? Relatively small?

I just added a new version 2.3.1 of node-mongo-seeds to npm. Try updating and see if that helps.


Rebuild container

Did anyone receive a message while configuring codespace that the codespaces is running in recovery mode and a prompt to rebuild the container?

@kylemasc917 what should we go for a rebuild or full rebuild in this case?

Got it! I believe you have answered in #25. But why exactly does this arise?

the default configuration runs the codespace using the devcontainer while the python option does not so it wont auto install the modules.

Understood! Thanks for answering.


ppo.py does not work out of box

/IdeaProjects/hydrogym/examples/ppo/ppo.py:457: UserWarning: Creating a tensor from a list of numpy.ndarrays is extremely slow. Please consider converting the list to a single numpy.ndarray with numpy.array() before converting to a tensor. (Triggered internally at ../torch/csrc/utils/tensor_new.cpp:275.)
a, v, logp = ac.step(torch.as_tensor(o, dtype=torch.float32))
Traceback (most recent call last):
File "/IdeaProjects/hydrogym/examples/ppo/ppo.py", line 520, in
ppo(
File "/IdeaProjects/hydrogym/examples/ppo/ppo.py", line 457, in ppo
a, v, logp = ac.step(torch.as_tensor(o, dtype=torch.float32))
ValueError: expected sequence of length 17 at dim 1 (got 0)

firedrake/envs/cylinder/coarse.msh due to "No such file or directory"


feat: optimize generic tag queries through the generic_tags table

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

47 of 59 (79.66%)  changed or added relevant lines in 4 files are covered.
2 unchanged lines in 1 file lost coverage.
Overall coverage decreased (-2.3%) to 93.664%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

src/nostr/nostr.module.ts
0
1
0.0%

src/nostr/repositories/event.repository.ts
35
46
76.09%

Files with Coverage Reduction
New Missed Lines
%

src/nostr/repositories/event.repository.ts
2
77.55%

Totals

Change from base Build<PHONE_NUMBER>:
-2.3%

Covered Lines:
850

Relevant Lines:
910

💛  - Coveralls


Re-simplify stack options

Part of the original Toybox vision was to have a very small (i.e. easily repeatable) footprint for deployment. Initially this meant sticking with file drivers and SQLite, but at some point I decided to stick with the "common" use case and stuck MySQL and Redis back in. Not a bad thing, but IMO it dilutes the point of the project and doesn't differentiate it.
Also using Jetstream is a little bit overkill at times, adding instructions on using teams adds overhead, etc. etc.
So I think it's time to go back to a "Toybox works in one way" mentality here, and only highlight which deviations are possible without having to support them too.

What would the ideal result here look like? In my mind right now:

Ubuntu (is there perhaps a better lightweight server option?)
FrankenPHP-built binary, working with Octane - i.e. PHP + Caddy + Octane
SQLite

Given #3, the leftover Octane options are Swoole and Roadrunner.
In an ideal world Swoole would be the better choice since it also grants usage of things like coroutines, the Octane cache, etc. But, getting it to work on macOS to test with has been a bit of a hack that I don't trust with my resulting install. Might be less of a fight on prod but at the same time I'm not interested in setting myself up for more potential headaches.
For simplicity then, I'll stick with Roadrunner.


Add logging for python smoke test

Adding logs to help debug when smoke tests fails on the configure Python wizard

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 41.713%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
27330

Relevant Lines:
59439

💛  - Coveralls


Ability for users to delete accounts

A user should be able to delete their account.  Add a "Settings" in a dropdown menu which takes them to a page where they can delete their account with a confirmation dialog.
this should delete their user and any data associated with them.  Do not delete any maps they uploaded, instead just empty out the userId.  You can delete any results or scores they have.

I'll pick this up! Discord - edinstance


F123 support?

Has anybody gotten this to work with the F123 line of printers? Like the F170, F270, etc.
I have a machine and a few chips to play around with.

News ?

News? :)


fix: typo for no of modes

Description
In the docs, it was mentioned that Keploy has 3 modes, but it has only 2 as of now, record and test.
Fixes https://github.com/keploy/keploy/issues/2139
Type of change

[x] Documentation update

Checklist:

[x] My code follows the style guidelines of this project.
[x] I have performed a self-review of my own code.
[x] I have made corresponding changes to the documentation.

@Sonichigo I have added the typo fix.
https://keploy.io/docs/keploy-explained/contribution-guide/#now-lets-try-running-keploy
Also, I think the command to run Keploy is also old, ie go run -exec "sudo -E env 'PATH=$PATH'" -tags=viper_bind_struct main.go test -c "path/to/go/binary/of/application" --delay 10
We can update the docs with the installation link and update the commands to run Keploy cmd directly.
Lmk, what do you think?

@Sonichigo I have added the typo fix.
https://keploy.io/docs/keploy-explained/contribution-guide/#now-lets-try-running-keploy Also, I think the command to run Keploy is also old, ie go run -exec "sudo -E env 'PATH=$PATH'" -tags=viper_bind_struct main.go test -c "path/to/go/binary/of/application" --delay 10
We can update the docs with the installation link and update the commands to run Keploy cmd directly. Lmk, what do you think?

I don't think it would be necessary since the commands mentioned in the contribution guides are for local development and testing of keploy.

Sure, then this PR is good to go.

Also is it possible to add KRoC tag to this PR?

Also is it possible to add KRoC tag to this PR?

Hi sure! you can add 1 point in the leaderboard for this on https://github.com/keploy/.github/tree/main/kroc'24


How to authenticate a request

Hi team, probably a naive question but I was not able to figure out how to authenticate a ws request.
Things I have tried,
setting custom config
  fal.config({
    credentials: // combination key here
})

setting env variables
FAL_KEY_ID=
FAL_KEY_SECRET=

But I don't see any token being sent on request, and I see Unauthorized error. Thanks

have you figured this out?

Hey! This repo is really not being supported anymore. You can instead take a look at https://github.com/fal-ai/tldraw-fal or https://github.com/fal-ai/fal-js/blob/main/apps/demo-nextjs-app-router/app/realtime/page.tsx
Sorry about the confusion.


doc: net: Add HTTP server documentation

Add documentation page for HTTP server functionality.
Rename existing HTTP documentation to HTTP client, as it only covers the
client library.
Add missing doxygen groups for HTTP service and server APIs.
Improve doxygen API documentation when missing.

Rebased, resovled conflicts and added a short section about websocket resources. Good to go from my point of view.


[SMALLFIX] Removed explicit parameter type in DirectedAcyclicGraph

Removed some explicit parameter types in the DirectedAcyclicGraph class.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/9669/
Test PASSed.

Merged build finished. Test PASSed.

LGTM


HTTP/2 error code 'PROTOCOL_ERROR' (0x1)

Please direct all support questions to slack or the forums. Thank you.
i have err is
 Grpc.Core.RpcException: Status(StatusCode="Internal", Detail="Error starting gRPC call. HttpRequestException: The HTTP/2 server sent invalid data on the connection. HTTP/2 error code 'PROTOCOL_ERROR' (0x1). (HttpProtocolError) HttpProtocolException: The HTTP/2 server sent invalid data on the connection. HTTP/2 error code 'PROTOCOL_ERROR' (0x1). (HttpProtocolError)", DebugException="System.Net.Http.HttpRequestException: The HTTP/2 server sent invalid data on the connection. HTTP/2 error code 'PROTOCOL_ERROR' (0x1). (HttpProtocolError)")

i use influxdb 2.7.6 in utuntu 22.04
this is my code
    public InfluxDbRepo(ILogger<InfluxDbRepo> logger, IConfiguration configuration)
    {
        _logger = logger;
        _configuration = configuration;
        // parse 'InfluxDbCfg' to get the configuration
        _influxDbCfg = _configuration.GetSection("InfluxDbCfg").Get<InfluxDbCfg>();
        if (_influxDbCfg == null) throw new Exception("配置文件中没有找到 InfluxDbCfg 配置");

        var host = $"http://{_influxDbCfg.Ip}:{_influxDbCfg.Port}";
        _client = new InfluxDBClient(host, _influxDbCfg.Token,_influxDbCfg.Org, _influxDbCfg.Bucket);
        // const string sql = "show databases";
        // var objects = Query(sql).ConfigureAwait(false).GetAwaiter().GetResult();
        // _logger.LogInformation($"show databases: {objects}");
    }

    public async Task<List<object>> Query(string sql)
    {
        var asyncEnumerable = _client.Query(sql);
        var ret = new List<object>();
        await foreach (var record in asyncEnumerable)
        {
            // do something with the record
            ret.Add(record);
        }

        return ret;

    }

influxdb3-csharp version is
<ItemGroup>
        <PackageReference Include="InfluxDB3.Client" Version="0.6.0" />
        <PackageReference Include="Microsoft.Extensions.Configuration.Abstractions" Version="9.0.0-preview.2.24128.5" />
        <PackageReference Include="Microsoft.Extensions.Logging.Abstractions" Version="9.0.0-preview.2.24128.5" />
        <PackageReference Include="Microsoft.Extensions.Configuration.Binder" Version="9.0.0-preview.2.24128.5" />
    </ItemGroup>
    ```
    how can i fixed it ?

Hi @ifnk,
Thank you for using our client and reaching out.
To better assist you and ensure that the issue is specifically related to our client rather than the environment setup, could you please provide a bit more detail about your current setup? Specifically, I'd like to know:

The version of .NET you are currently using.
The reasons for using the preview version of Microsoft.Extensions.

Additionally, it would be very helpful if you could run some of the examples from our repository to confirm whether the issue persists across different scenarios or if it might be isolated to your particular setup.
This information will help us identify the root cause more accurately and provide you with the best possible support.
Best Regards

This issue has been closed because it has not had recent activity. Please reopen if this issue is still important to you and you have additionally information.


optional self-identification field for queries

Could an optional parameter (if that's the word I want) be added to /occurrences that simply stores a text string, associated with that query and delivered with it in /monitors ? This would allow searchers to informally self identify if they choose, and in some cases (eg: EDDMapS, SciStarter) allow convenient clustering/filtering within a large set of queries.

@jhammock is this covered by Eli's Monitors V2? If so, please close this issue.


Colab notebook gets stuck in the loading page

It gets stuck at the loading page forever. I tried clearing browser cache, incognito mode, deleting colab folder from the drive but nothing works. Facing the issue from last two days

For general issues with Colab, please use https://github.com/googlecolab/colabtools/issues.


Diagnostic Ray

Create a ray for diagnostic purposes. Ideally it would enable visualisation of the ray path in the scene. For example, see the path of a ray through a dispersive element, such as a lens.

Related to #124.


🐛 | PlayerMPD.prev/next crash at the end of the playlist

Version
v3.5.2
Branch
future3/main
OS
Raspberry Pi OS Bookworm Lite - 32bit
Pi model
3B
Hardware
No response
What happened?

Press the configured Next button when playing the last song of a playlist, or
Press the configured Prev button when the last song of a playlist has played.

jukebox-daemon logs the below exception and stops reacting to music play requests until restarted.
Logs
Mar 15 22:32:56 phoniebox bash[739]: 15.03.2024 22:32:56 -  337:__init__.py        - jb.PlayerMPD         - Thread-2        - DEBUG    - Prev
Mar 15 22:32:56 phoniebox bash[739]: Exception in thread Thread-2:
Mar 15 22:32:56 phoniebox bash[739]: Traceback (most recent call last):
Mar 15 22:32:56 phoniebox bash[739]:   File "/usr/lib/python3.11/threading.py", line 1038, in _bootstrap_inner
Mar 15 22:32:57 phoniebox bash[739]:     self.run()
Mar 15 22:32:57 phoniebox bash[739]:   File "/home/phoniebox/RPi-Jukebox-RFID/.venv/lib/python3.11/site-packages/lgpio.py", line 554, in run
Mar 15 22:32:57 phoniebox bash[739]:     cb.func(chip, gpio, level, tick)
Mar 15 22:32:57 phoniebox bash[739]:   File "/home/phoniebox/RPi-Jukebox-RFID/.venv/lib/python3.11/site-packages/gpiozero/pins/lgpio.py", line 248, in _call_when_changed
Mar 15 22:32:57 phoniebox bash[739]:     super()._call_when_changed(ticks /<PHONE_NUMBER>, level)
Mar 15 22:32:57 phoniebox bash[739]:   File "/home/phoniebox/RPi-Jukebox-RFID/.venv/lib/python3.11/site-packages/gpiozero/pins/local.py", line 111, in _call_when_changed
Mar 15 22:32:57 phoniebox bash[739]:     super()._call_when_changed(
Mar 15 22:32:57 phoniebox bash[739]:   File "/home/phoniebox/RPi-Jukebox-RFID/.venv/lib/python3.11/site-packages/gpiozero/pins/pi.py", line 618, in _call_when_changed
Mar 15 22:32:57 phoniebox bash[739]:     method(ticks, state)
Mar 15 22:32:57 phoniebox bash[739]:   File "/home/phoniebox/RPi-Jukebox-RFID/.venv/lib/python3.11/site-packages/gpiozero/input_devices.py", line 179, in _pin_changed
Mar 15 22:32:57 phoniebox bash[739]:     self._fire_events(ticks, bool(self._state_to_value(state)))
Mar 15 22:32:57 phoniebox bash[739]:   File "/home/phoniebox/RPi-Jukebox-RFID/.venv/lib/python3.11/site-packages/gpiozero/mixins.py", line 385, in _fire_events
Mar 15 22:32:57 phoniebox bash[739]:     self._fire_activated()
Mar 15 22:32:57 phoniebox bash[739]:   File "/home/phoniebox/RPi-Jukebox-RFID/.venv/lib/python3.11/site-packages/gpiozero/mixins.py", line 431, in _fire_activated
Mar 15 22:32:57 phoniebox bash[739]:     super()._fire_activated()
Mar 15 22:32:57 phoniebox bash[739]:   File "/home/phoniebox/RPi-Jukebox-RFID/.venv/lib/python3.11/site-packages/gpiozero/mixins.py", line 348, in _fire_activated
Mar 15 22:32:57 phoniebox bash[739]:     self.when_activated()
Mar 15 22:32:57 phoniebox bash[739]:   File "/home/phoniebox/RPi-Jukebox-RFID/src/jukebox/components/playermpd/__init__.py", line 339, in prev
Mar 15 22:32:57 phoniebox bash[739]:     self.mpd_client.previous()
Mar 15 22:32:57 phoniebox bash[739]:   File "/home/phoniebox/RPi-Jukebox-RFID/.venv/lib/python3.11/site-packages/mpd/base.py", line 478, in mpd_command
Mar 15 22:32:57 phoniebox bash[739]:     return wrapper(self, name, args, callback)
Mar 15 22:32:57 phoniebox bash[739]:            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
Mar 15 22:32:57 phoniebox bash[739]:   File "/home/phoniebox/RPi-Jukebox-RFID/.venv/lib/python3.11/site-packages/mpd/base.py", line 541, in _execute
Mar 15 22:32:57 phoniebox bash[739]:     return retval()
Mar 15 22:32:57 phoniebox bash[739]:            ^^^^^^^^
Mar 15 22:32:57 phoniebox bash[739]:   File "/home/phoniebox/RPi-Jukebox-RFID/.venv/lib/python3.11/site-packages/mpd/base.py", line 463, in command_callback
Mar 15 22:32:57 phoniebox bash[739]:     res = function(self, self._read_lines())
Mar 15 22:32:57 phoniebox bash[739]:           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
Mar 15 22:32:57 phoniebox bash[739]:   File "/home/phoniebox/RPi-Jukebox-RFID/.venv/lib/python3.11/site-packages/mpd/base.py", line 396, in _parse_nothing
Mar 15 22:32:57 phoniebox bash[739]:     for line in lines:
Mar 15 22:32:57 phoniebox bash[739]:   File "/home/phoniebox/RPi-Jukebox-RFID/.venv/lib/python3.11/site-packages/mpd/base.py", line 595, in _read_lines
Mar 15 22:32:57 phoniebox bash[739]:     line = self._read_line()
Mar 15 22:32:57 phoniebox bash[739]:            ^^^^^^^^^^^^^^^^^
Mar 15 22:32:57 phoniebox bash[739]:   File "/home/phoniebox/RPi-Jukebox-RFID/.venv/lib/python3.11/site-packages/mpd/base.py", line 584, in _read_line
Mar 15 22:32:57 phoniebox bash[739]:     raise CommandError(error)
Mar 15 22:32:57 phoniebox bash[739]: mpd.base.CommandError: [55@0] {previous} Not playing

Configuration
GPIO config
input_devices:
  Prev:
    type: Button
    kwargs:
      pin: 19
    actions:
      on_press:
        alias: prev_song

  Next:
    type: Button
    kwargs:
      pin: 26
    actions:
      on_press:
        alias: next_song

More info
A stop gap solution which works for me would be something like this:
diff --git a/src/jukebox/components/playermpd/__init__.py b/src/jukebox/components/playermpd/__init__.py
index 05dff82b..f34e479c 100644
--- a/src/jukebox/components/playermpd/__init__.py
+++ b/src/jukebox/components/playermpd/__init__.py
@@ -335,16 +335,22 @@ class PlayerMPD:
     @plugs.tag
     def prev(self):
         logger.debug("Prev")
-        with self.mpd_lock:
-            self.mpd_client.previous()
+        try:
+            with self.mpd_lock:
+                self.mpd_client.previous()
+        except mpd.base.CommandError:
+            logger.debug('Failed to go to previous song, ignoring')
         self.play_position_tracker.flush()

     @plugs.tag
     def next(self):
         """Play next track in current playlist"""
         logger.debug("Next")
-        with self.mpd_lock:
-            self.mpd_client.next()
+        try:
+            with self.mpd_lock:
+                self.mpd_client.next()
+        except mpd.base.CommandError:
+            logger.debug('Failed to go to next song, ignoring')
         self.play_position_tracker.flush()

     @plugs.tag

Obviously, it doesn't cover all cases and might be suboptimal. Maybe prev/next should rather wrap around?
I'm happy to submit a PR once it is clear how it should behave and where the fix should be located.

Good catch. Thanks!
Your solutions looks already good. It would basically not do anything once the end of the playlist has been reached.
Most Phonieboxes don't have a visual interface. So if a user tries to press to get to the next song and nothing happens, it's not intuitive nor accessible.

In case it's the last song, pressing "Next" would go back to the beginning of the playlist.
When it's the first song, pressing "Previous" would go to the end (last song) of the playlist

This behviour could be configurable, meaning an option in the julebox.yaml would either enable or disable this behaviour
Thoughts?

I agree at the end going to start again with NEXT and vice versa would be the most intuitive. 👍
Making it configurable (other option "do nothing") would cover most cases and could be extended later, if we come up with more use cases in the future.

Default behavior of v2 is "do nothing" until play is pressed or a card is swiped again.
So +1 for configurable option.

Some corrections/additions:

I initially wrote that prev() on the first song of a playlist is a problem. It isn't. It's problematic at the end of a playlist when MPD is stopped.
I initially thought that the problem was only related to reaching the end of the playlist. However, the root cause is that MPD is stopped. This state can probably be reached through other ways as well (rpc, buttons, web UI) and should therefore be handled.

In essence, we need to be clear about the behavior in the following cases. I'm no longer sure if it makes sense to make all of these configurable?

Action, when prev() is run on a stopped MPD. Sane actions: stop, rewind, previously played song. I'd argue for rewind as the static default.
Action, when next() is run on a stopped MPD. Sane actions: stop, rewind, the song one after the last played song. I'd argue for the latter as the static default.
Action, when next() is run during playing the last song of a playlist. I guess this might make sense to be configurable as either stop or rewind.

I'm currently implementing it like that.
Independent of those specified cases, prev() and next() should never crash the player thread (this is handled by the above Exception handling example).

@hoffie  I encountered this bug as well, after using you fork and the hoffie-future-main branch it working fine again :+1:

So please create a PR, I can confirm your changes are working.

#2326 has been merged to future3/develop


GEODE-6443: log all request and response in geode management service

Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:

[ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?

[ ] Has your PR been rebased against the latest commit within the target branch (typically develop)?

[ ] Is your initial contribution a single, squashed commit?

[ ] Does gradlew build run cleanly?

[ ] Have you written or updated unit tests to verify your changes?

[ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?

Note:
Please ensure that once the PR is submitted, check Concourse for build issues and
submit an update to your PR as soon as possible. If you need help, please send an
email to<EMAIL_ADDRESS>

flaky test failure not related to this PR


Model validation

The template should have decent model validation out of the box.
I'm thinking FluentValidation, but need to work through the details.
Requirements:

Complex validation per model
A single model type can have different validation rules on different actions
Validation logic should be injected to get access to services in the container

In progress (validation branch)

Basic validation integrated into master.


Fix error create bucket false

Description
Terraform failed to create aws_iam_role_policy_attachment resource named docker_machine_cache_instance when cache_bucket["create"] is set to false.
Migrations required
No migrations required
Verification
terraform apply and terraform destroy

@chrizkim thanks, will check in the next days

Thanks!


Ubuntu Windows Subsystem Linux error

Hello, first of all thank you a lot for this tool! I was searching for this for a long time, because my current load balancing system was bad and this is working great on my Kali Linux Laptop.
BUT i want to run it under a Windows System, so im using the Ubuntu Linux Subsytem in Windows 10.
I have every dependency installed and have successfully run the setup, but when i try to start evillimiter i am getting this error:
OK   interface: wifi0
OK   gateway ip: <IP_ADDRESS>
Traceback (most recent call last):
File "/usr/local/bin/evillimiter", line 9, in
load_entry_point('evillimiter==1.1.0', 'console_scripts', 'evillimiter')()
File "/usr/local/lib/python3.5/dist-packages/evillimiter-1.1.0-py3.5.egg/evillimiter/evillimiter.py", line 159, in run
args = process_arguments(args)
File "/usr/local/lib/python3.5/dist-packages/evillimiter-1.1.0-py3.5.egg/evillimiter/evillimiter.py", line 91, in process_arguments
gateway_mac = netutils.get_mac_by_ip(interface, gateway_ip)
File "/usr/local/lib/python3.5/dist-packages/evillimiter-1.1.0-py3.5.egg/evillimiter/networking/utils.py", line 43, in get_mac_by_ip
response = sr1(packet, timeout=3, verbose=0, iface=interface)
File "/usr/local/lib/python3.5/dist-packages/scapy-2.4.3rc1-py3.5.egg/scapy/sendrecv.py", line 501, in sr1
s = conf.L3socket(promisc=promisc, filter=filter, nofilter=nofilter, iface=iface)  # noqa: E501
File "/usr/local/lib/python3.5/dist-packages/scapy-2.4.3rc1-py3.5.egg/scapy/arch/linux.py", line 445, in init
self.ins = socket.socket(socket.AF_PACKET, socket.SOCK_RAW, socket.htons(type))  # noqa: E501
File "/usr/lib/python3.5/socket.py", line 134, in init
_socket.socket.init(self, family, type, proto, fileno)
OSError: [Errno 97] Address family not supported by protocol
Exception ignored in: <bound method SuperSocket.del of <scapy.arch.linux.L3PacketSocket object at 0x7f77c86d90b8>>
Traceback (most recent call last):
File "/usr/local/lib/python3.5/dist-packages/scapy-2.4.3rc1-py3.5.egg/scapy/supersocket.py", line 127, in del
self.close()
File "/usr/local/lib/python3.5/dist-packages/scapy-2.4.3rc1-py3.5.egg/scapy/arch/linux.py", line 481, in close
set_promisc(self.ins, self.iface, 0)
AttributeError: 'L3PacketSocket' object has no attribute 'ins'
i couldn't solve it, so it would be really great if you could take a look on it.
I also tried to run evillimiter in a VM with the interface as bridged, but it seems to not function. The bandwith is not effected at all.
Thanks in advance

of course running a vm would work, but i was hoping that the subsystem would come in handy...

If I understood correctly, you have two issues:

the error message that you posted when you try to run evillimiter in a Linux subsystem

evillimiter will not work when run on a virtual machine, although the network interface is bridged

It seems like scapy  - a module used by evillimiter to send network packets - is causing this issue. Somehow a required socket object can not be created. This is most likey caused by the subsystem. Regarding evillimiter, I recommend sticking to a virtual machine.
However, I thought about working on a GUI version of evillimiter for Windows only.

This issue does not seem to be a bug inside evillimiter. I tried it myself and it worked perfectly fine. Maybe double check that the interface is truly bridged.

I did retry it and checked the network connection on the Debian VM(VM Ware). It is bridged and the network adapter is my wlan adapter. I don't know why it is not working maybe it's a networking issue. I will try to get a cap of it and take a look on it later

[SSL: CERTIFICATE_VERIFY_FAILED] certificate verify failed: certificate is not yet valid (_ssl.c:1056)

I am getting the same error when running Evil Limiter on WSL
OK   interface: wifi0 OK   gateway ip: <IP_ADDRESS> Traceback (most recent call last):   File "bin/evillimiter", line 15, in <module>     sys.exit(run())   File "/home/na-08/evillimiter/evillimiter/evillimiter.py", line 167, in run     args = process_arguments(args)   File "/home/na-08/evillimiter/evillimiter/evillimiter.py", line 93, in process_arguments     gateway_mac = netutils.get_mac_by_ip(interface, gateway_ip)   File "/home/na-08/evillimiter/evillimiter/networking/utils.py", line 43, in get_mac_by_ip     response = sr1(packet, timeout=3, verbose=0, iface=interface)   File "/usr/local/lib/python3.6/dist-packages/scapy-2.4.3-py3.6.egg/scapy/sendrecv.py", line 488, in sr1     nofilter=nofilter, iface=iface)   File "/usr/local/lib/python3.6/dist-packages/scapy-2.4.3-py3.6.egg/scapy/arch/linux.py", line 467, in __init__     self.ins = socket.socket(socket.AF_PACKET, socket.SOCK_RAW, socket.htons(type))  # noqa: E501   File "/usr/lib/python3.6/socket.py", line 144, in __init__     _socket.socket.__init__(self, family, type, proto, fileno) OSError: [Errno 97] Address family not supported by protocol
How to solve this issue ? is there any workaround for this ?

Hello there devs... I´m also having the same issue.
While running on WSL (Kali_Linux), I´m getting

File "bin/evillimiter", line 15, in
sys.exit(run())
File "/home/adriel/downloads/limiter/evillimiter/evillimiter/evillimiter.py", line 167, in run
args = process_arguments(args)
File "/home/adriel/downloads/limiter/evillimiter/evillimiter/evillimiter.py", line 93, in process_arguments
gateway_mac = netutils.get_mac_by_ip(interface, gateway_ip)
File "/home/adriel/downloads/limiter/evillimiter/evillimiter/networking/utils.py", line 43, in get_mac_by_ip
response = sr1(packet, timeout=3, verbose=0, iface=interface)
File "/usr/local/lib/python3.7/dist-packages/scapy-2.4.3-py3.7.egg/scapy/sendrecv.py", line 488, in sr1
nofilter=nofilter, iface=iface)
File "/usr/local/lib/python3.7/dist-packages/scapy-2.4.3-py3.7.egg/scapy/arch/linux.py", line 467, in init
self.ins = socket.socket(socket.AF_PACKET, socket.SOCK_RAW, socket.htons(type))  # noqa: E501
File "/usr/lib/python3.7/socket.py", line 151, in init
_socket.socket.init(self, family, type, proto, fileno)
OSError: [Errno 97] Address family not supported by protocol
Is there any workaround for this?

WSL will not be supported by this version of EvilLimiter and I will not work on fixing it.
There already is a Windows GUI version of the tool.


AWS SDK for Ruby V3

Implement recipe for the AWS SDK for Ruby V3.
https://github.com/aws/aws-sdk-ruby

This will be implemented on request.


Add convenience class methods for saving and loading models

Closes #72

Tagging @kaareendrup to keep you in the loop. :)  Let me know if you have any feedback on this!


In JS highlighting, comments seem to be the same colour as variables

This is such a good looking theme, has become my daily. Thank you for making it!
I noticed that in js highlighting, comments and variables have a deceptively similar color which threw me off. Is this something you have control over?

Oops!
Sorry for the late reply!
@develohpanda I honestly don't know which color to change, if you could help guide me which variable I should change to make it work, it would be great. I really don't understand much about colors using inside the code editor.
Thanks for using it, @develohpanda !

Looks like it's using var(--hl), which I think is highlight.default (see here)

cm-comment uses --hl, but cm-variable uses --color-warning. Perhaps you could explore changing these two variables for the editor and see what you like? Note the following is untested 😄
{
  styles: {
    editor: {
      highlight: {
        default: // something
      }
    }
  }
}

or
{
  styles: {
    editor: {
      foreground: {
        warning: // something
      }
    }
  }
}

@develohpanda I found it now.

Fixed in 1.0.4 🎉


modified the search-bar and suggetions and in terms of styling

@An525ish PLease add required screenshots, and there are many conflicts in your branch, for which we can' t merge, please pull the repo properly and then do required changes

https://github.com/OSCode-Community/OSCodeCommunitySite/assets/93612051/b25121c6-475c-4d48-854a-e200efc3ff6b

@An525ish PLease add required screenshots, and there are many conflicts in your branch, for which we can' t merge, please pull the repo properly and then do required changes

here is the video of the search bar ... there is a smooth transition in the search bar for scaling and for showing the results but for some reason it's not properly showing in the video

Awesome @An525ish , we will review and merge it soon:)


Misusability Cases documentation

CAIRIS supports the ability to model misusability cases via the task characteristics functionality, but this isn't documented.

Superseded by Issue #113


Performance/RegexpMatch: can't recognize use of MatchData via named capture

RuboCop says MatchData isn't used in the code below, which is false.
def f
  return unless /(?<foo>.)/ =~ 'x'
  puts foo
end

Expected behavior
No offences reported.
Actual behavior
RuboCop reports Use match? instead of =~ when MatchData is not used.
Steps to reproduce the problem
test.rb
def f
  return unless /(?<foo>.)/ =~ 'x'
  puts foo
end

.rubocop.yml
AllCops:
  TargetRubyVersion: 2.4

$ rubocop --only RegexpMatch --cache false test.rb
Inspecting 1 file
C

Offenses:

test.rb:2:17: C: Use match? instead of =~ when MatchData is not used.
  return unless /(?<foo>.)/ =~ 'x'
                ^^^^^^^^^^^^^^^^^^

1 file inspected, 1 offense detected

RuboCop version
$ rubocop -V
0.49.1 (using Parser <IP_ADDRESS>, running on ruby 2.4.1 x86_64-darwin16)

Duplicate https://github.com/bbatsov/rubocop/issues/4270
And this problem is fixed in master. See https://github.com/bbatsov/rubocop/pull/4531 .


edit import path from github.com/Alluxio to github.com/alluxio

import paths should not have uppercase
this breaks any usages, requiring a rename of "github.com/Alluxio/ -> "github.com/alluxio/

Do we need to rename the organization as well?

no need to rename the organization


Teach TSan about TaskGroups

TaskGroup::offer(completedTask):

Called from AsyncTask::completeFuture() which already takes care of
release(completedTask).  No additional edge is required if no task
is waiting and completed task is stored so it can be retrieved by
group.poll().
If group has waiting task, it will be dequeued and scheduled, add
acquire(waitingTask).

TaskGroupImpl::poll(waitingTask):

If no pending tasks, do nothing.
If returning finished task, acquire(finishedTask).
If enqueuing waiting task, release(waitingTask).

Note: release() should go before, and acquire() after the annotated
synchronization operation.
Radar-Id: rdar://75910632

Although I was creating more and more complex setups, I was still unable to create a test that "goes red" (TSan producing a FP) to proof that these annotations are needed.  So I simplified the test again to make it easier to understand.  @ktoso Do you have ideas/suggestions on how a test that "correctly goes red" could look like?

Okey, I'm a bit green in how TSAN works/expects the order of the release/acquire it somehow reads reversed to me, but maybe I'm just confused?
It looks good and your writeup is correct I think, to double check though: there's both orders which make sense in a group:

offer runs, no waiter exists -> release(completedTask AKA readyTask)
poll runs, ready task exists -> acquire(readyTask)

and

poll runs, no ready task, enqueue waiter -> release(waitingTask)
offer runs, waiter exists, run the waiter -> acquire(waitingTask)

So is it generally this feels like "when we're about to run a task, we acquire it" and when we're "done" with a task we release it", did I get that right?
The edges seem right then and I think you identified all of them - it can only be "ready + no waiter" "ready + waiter" and "waiter but nothing to wait on anyway (noop)" as you identified correctly up there.

Okey, I'm a bit green in how TSAN works/expects the order of the release/acquire it somehow reads reversed to me, but maybe I'm just confused?

I always have to remind myself:
 T1             T2
 tsan_release(x)
 unlock(x)
          -->
             lock(x)
             tsan_acquire(x)

In our case unlock() is "task enqueued/suspended". lock() is "task dequeued/resumed".

It looks good and your writeup is correct I think, to double check though: there's both orders which make sense in a group:

offer runs, no waiter exists -> release(completedTask AKA readyTask)

This is always done (sometimes unnecessarily w.r.t. task groups) in AsyncTask::completeFuture().

poll runs, ready task exists -> acquire(readyTask)

Added by this PR.

and

poll runs, no ready task, enqueue waiter -> release(waitingTask)
offer runs, waiter exists, run the waiter -> acquire(waitingTask)

Added by this PR.

So is it generally this feels like "when we're about to run a task, we acquire it" and when we're "done" with a task we release it", did I get that right?

Yes!

@swift-ci Please test

Build failed
Swift Test Linux Platform
Git Sha - 5ff6a0f60062e9d4a6945b119bee1e86981622c3

Build on Linux failed with Jenkins error:
[639/1291][ 49%][259.954s] Building CXX object lib/PrintAsObjC/CMakeFiles/swiftPrintAsObjC.dir/DeclAndTypePrinter.cpp.o
FATAL: command execution failed
java.io.EOFException
	at java.io.ObjectInputStream$PeekInputStream.readFully(ObjectInputStream.java:2759)
	at java.io.ObjectInputStream$BlockDataInputStream.readShort(ObjectInputStream.java:3234)
	at java.io.ObjectInputStream.readStreamHeader(ObjectInputStream.java:913)
	at java.io.ObjectInputStream.<init>(ObjectInputStream.java:375)
	at hudson.remoting.ObjectInputStreamEx.<init>(ObjectInputStreamEx.java:49)
	at hudson.remoting.Command.readFrom(Command.java:142)
	at hudson.remoting.Command.readFrom(Command.java:128)
	at hudson.remoting.AbstractSynchronousByteArrayCommandTransport.read(AbstractSynchronousByteArrayCommandTransport.java:35)
	at hudson.remoting.SynchronousCommandTransport$ReaderThread.run(SynchronousCommandTransport.java:63)
Caused: java.io.IOException: Unexpected termination of the channel

@swift-ci Please test Linux

Build failed
Swift Test Linux Platform
Git Sha - 5ff6a0f60062e9d4a6945b119bee1e86981622c3

Linux build again failed during compilation with a Jenkins/Java exception.

@swift-ci Please test Linux

Build failed
Swift Test Linux Platform
Git Sha - 5ff6a0f60062e9d4a6945b119bee1e86981622c3

@swift-ci please smoke test linux

Would we want to merge this? @yln

@swift-ci Please smoke test and merge

14:26:18 Failed Tests (1):
14:26:18   Swift(macosx-x86_64) :: Sanitizers/tsan/async_taskgroup_next.swift

Compilation fails:
async_taskgroup_next.swift:12:11: error: 'Task' is only available in macOS 9999 or newer

I guess we have to annotate the test like this:
https://github.com/apple/swift/commit/1173b737aa3422137eb85079b7768a6932269158

Updated test to reflect TaskGroup API changes and annotated with availability.

@swift-ci Please smoke test and merge


Extended scan

Allow users to set arbitrary keys and key ranges in a scan.  This will partially fix #1008.

LGTM

LGTM


replace call to filter function with better regex

What do you think @Fuzzyma? I think it's cleaner than f1d9f615

Jetzt. Its a better regex but the problem with leading or trailing spaces remains.
Try:
console.log('a b c  '.split('/s+')

You should see it then

Well, for that we could easily do console.log(' a b c  '.trim().split('/s+')). But then the question is if we prefer
// parse points
array = array.trim().split(/\s+|,/)

over
// parse points
array = array.split(/\s|,/).filter(function(a){ return a !== '' })

trim is a good solution. Go with yours + trim

Hmm... something weird is going on with my commits and github. The current commit on travis is not my latest commit...

ahh, it was a conflict. Fixed


Is there an English model for streaming ASR?

General Question

I tried changing the lang parameter in streaming_asr_server/conf/ws_conformer_application from 'zh' to 'en' and got the following error (when trying to run the server example given in the streaming ASR documentation):
AssertionError: Can't find "conformer_online_wenetspeech-en-16k" in resource. Model name must be one of ['conformer_online_wenetspeech-zh-16k', 'conformer_u2pp_online_wenetspeech-zh-16k', 'conformer_online_multicn-zh-16k', 'conformer_online_aishell-zh-16k', 'deepspeech2online_wenetspeech-zh-16k', 'deepspeech2online_aishell-zh-16k']
Is there any way to access English based streaming ASR engines? Do they exist yet? (The chinese engine works pretty well btw)

There is no stream English ASR yet.

is There stream English ASR now

现在是否支持流式的中英文混合的呢？


fix: drop long seq even if not sample packing

Description

empti reported in discord https://discord.com/channels/1104757954588196865/1111279858136383509/1320021873878372436 that sequences are truncated not dropped if sample_packing is off. This PR tries to fix that. RL path seems fine, only SFT is missing.
[ ] Check for pretraining case
[ ] Check handling for if skip_prepare: True
Motivation and Context

How has this been tested?

Untested!
Screenshots (if appropriate)
Types of changes

Social Handles (Optional)

I swore someone just submitted a PR that was merged to remove this


using static lib does not work [don't use "use_frameworks" flag in cocoapod]

I was investigating of integrating Apptentive to our application. Our project uses Cocoapods for 3rd party libraries and do not use use_frameworks flag.  Looks like Apptentive doesn't work with this and give error that the static library is not found.
Judging from the error and looking at the Pods, it seems like libapptentive-ios.a fails to compile.

You'll need to use a workaround if you aren't able to use the use_frameworks! directive, in the form of a post-install hook in your podfile:
post_install do |pi|
    pi.pods_project.targets.each do |target|
        target.build_configurations.each do |config|
            unless pi.podfile.defined_in_file.read().include? "\nuse_frameworks!\n"
              config.build_settings['GCC_PREPROCESSOR_DEFINITIONS'] ||= ['$(inherited)']
              config.build_settings['GCC_PREPROCESSOR_DEFINITIONS'] << 'NO_USE_FRAMEWORKS=1'
            end
        end
    end
end

@frankus tx, the workaround seems to work. Is there a plan to address this in the future so we dont need to have this workaround?

The need for the workaround was a result of adding both static library and framework targets to the project. In the next major version we will remove support for the standalone static library target (although CocoaPods will still be able to build a static library) which should fix this.


Better TypeScript Declarations & Definitions

Made a new branch.

Did a change on the .remove() method to .extract().


Fix findById which was using double rather than triple equals operator

As title, this hopefully allows findById to work correctly and fixes #699 (forever stop id seems to stop all processes).
I've not been able to run the "npm test" suite - i've filed #755 for this.
Of course I have tested this on our local build machine and now undeploying the first test environment to be setup on the machine (i.e. has a forever process as index 0) now no longer kills every nodejs process (i.e. evey test environment) on the same box.

Please verify and merge this pull request. Bug #699 has been giving us serious operational trouble since April. Inadvertently stopping all processes managed by forever by issuing a "stop 0" is a very serious bug. Thank you for your consideration.


GitHub Auth added #87

The PR may be interesting for you:
@CodeWorldIndustries, @phmatray, @leandrofagundes
I follow the suggestion of using an external Authentication provider and I don't need to issue an JWT.

GitHub authentication added.
Removed CustomerId from Requests.

Work in Progress:

Acceptance Tests are failing (We need to disable authentication via feature flag when running tests)
We should move the GetCustomer and GetAccount to the infrastructure layer

To initiate the login process navigate to https://localhost:5001/Login?ReturnUrl=swagger it will ask for GitHub credentials. At this moment it is using the credentials are set up in appsettings. You are free to change to yours https://github.com/settings/applications/new
Looking forward your feedback

Nice @ivanpaulovich, I never used github so a few terms like the branches and pull system are new to me.
Anyway, my question is: as you, if I want to use a JWT auth mode, should the API Controller convert the data into Token? I don't think the use case should do it because the dependency on application layer (or creating a service on infrastructure with a interface on application to IoC).
What do you see as the best and more accurate way to keep the architecture clean?

Nice @ivanpaulovich, I never used github so a few terms like the branches and pull system are new to me.
Anyway, my question is: as you, if I want to use a JWT auth mode, should the API Controller convert the data into Token? I don't think the use case should do it because the dependency on application layer (or creating a service on infrastructure with a interface on application to IoC).
What do you see as the best and more accurate way to keep the architecture clean?

Hey @leandrofagundes,
The JWT token creation is a UI responsibility, the controller could generate the Token but I think is better to do that the same way @phmatray did through the AuthenticatePresenter. Check out his suggestions:
https://github.com/ivanpaulovich/clean-architecture-manga/pull/103/files#diff-2f674accfac4fdc698e5d331b076321dR11
Regarding his changes, I wouldn't pass the ClientSecret through the layers, they could be injected at the Presenter.

Amazing @ivanpaulovich!
Great job from @phmatray, btw.
I'm learning much more then I expected those days. I read the book twice but I'm too much visual, sometimes just read isn't enough and you are bring reality to my questions.
Thanks again for your attention, I'll keep asking and learning but tell me if I can be usefull for something else!
:)


fixed some asset inconsistencies

fixes related to typos, asset  reference and attribute name of the asset

Thanks so much for the pull request @luipir!  Can you please fill out this Contributor License Agreement form? This only needs to be completed once, and enables contributions to all of the projects under the CesiumGS organization. Once we have that, we can review and merge this PR.  Thanks!

please fill out this Contributor License Agreement form

done!

Great, thanks!  @OmarShehata can you review this please?

probably the code workshop web page have to be aligned too with the fixed code, but I do not have access (nor I looked for it) to the page code

Yes, good point.  @OmarShehata should be able to update that as well

@OmarShehata done

Wonderful, thanks again @luipir ! I'll update the tutorial content.


[BUG] - Unable to Create class, var, or const with the Name "C"

Is there an existing issue for this?

[X] I have searched the existing issues

Current Behavior
I ran into an issue while testing other code when I tried to create a class named "C". I think it's conflicting with the internal module of the same name. I tested with const's and var's and it's the same behavior.
Expected Behavior
No response
Steps To Reproduce
Using the latest version:
>>> class C {}
>>> const c = C();
Error: File 'repl', line 1
       'module' is not callable

>>> const C = 90;
>>> print(C);
<Module C>
>>> var C = 90;
>>> print(C);
<Module C>

Anything else?
No response

I adjusted the code to not auto load the C module but to require it be explicitly imported, tested, and seemed to work fine. I can push a PR but wanted to get your (@Jason2605) thoughts and feedback on the matter before I did.

Please yeah, I'm unsure the reason I didn't autoload that module


Specify that variables are maps for TF 0.7.x

Play nicely with Terraform 0.7.x (for some x where 0 <= x <= 3 -- I don't know which exactly) .

Without this change, you get extremely confusing errors like:
Error loading Terraform: module ami.root: module virttype: required variable pv_preferred not set

And then every once in a while:
Error loading Terraform: module ami.root: module virttype: required variable hvm_preferred not set

I am not sure that this PR is needed, because it works for me on Terraform 0.7.3 and should work for other 0.7.*. Are you sure that you updated modules and using latest master branch ?

Ok, so ... I wasn't quite up to date. The version I was using didn't have the description fields in the variables.tf.json. And this appears to be a dupe of #2/#3, insofar as setting any additional fields masks the problem.
Feel free to close this PR.