fix: regenerate protos

This PR was generated using Autosynth. :rainbow:
Log from Synthtool
synthtool > Executing /tmpfs/src/git/autosynth/working_repo/synth.py.
synthtool > Ensuring dependencies.
synthtool > Pulling artman image.
latest: Pulling from googleapis/artman
Digest: sha256:75b38a3b073a7b243545f2332463096624c802bb1e56b8cb6f22ba1ecd325fa9
Status: Image is up to date for googleapis/artman:latest
synthtool > Cloning googleapis.
synthtool > Running generator for google/spanner/artman_spanner.yaml.
synthtool > Generated code into /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/js/spanner-v1.
synthtool > Running generator for google/spanner/admin/database/artman_spanner_admin_database.yaml.
synthtool > Generated code into /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/js/spanner-admin-database-v1.
synthtool > Running generator for google/spanner/admin/instance/artman_spanner_admin_instance.yaml.
synthtool > Generated code into /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/js/spanner-admin-instance-v1.
.eslintignore
.eslintrc.yml
.github/ISSUE_TEMPLATE/bug_report.md
.github/ISSUE_TEMPLATE/feature_request.md
.github/ISSUE_TEMPLATE/support_request.md
.github/PULL_REQUEST_TEMPLATE.md
.github/release-please.yml
.jsdoc.js
.kokoro/common.cfg
.kokoro/continuous/node10/common.cfg
.kokoro/continuous/node10/docs.cfg
.kokoro/continuous/node10/lint.cfg
.kokoro/continuous/node10/samples-test.cfg
.kokoro/continuous/node10/system-test.cfg
.kokoro/continuous/node10/test.cfg
.kokoro/continuous/node12/common.cfg
.kokoro/continuous/node12/test.cfg
.kokoro/continuous/node8/common.cfg
.kokoro/continuous/node8/test.cfg
.kokoro/docs.sh
.kokoro/lint.sh
.kokoro/presubmit/node10/common.cfg
.kokoro/presubmit/node10/docs.cfg
.kokoro/presubmit/node10/lint.cfg
.kokoro/presubmit/node10/samples-test.cfg
.kokoro/presubmit/node10/system-test.cfg
.kokoro/presubmit/node10/test.cfg
.kokoro/presubmit/node12/common.cfg
.kokoro/presubmit/node12/test.cfg
.kokoro/presubmit/node8/common.cfg
.kokoro/presubmit/node8/test.cfg
.kokoro/presubmit/windows/common.cfg
.kokoro/presubmit/windows/test.cfg
.kokoro/publish.sh
.kokoro/release/docs.cfg
.kokoro/release/docs.sh
.kokoro/release/publish.cfg
.kokoro/samples-test.sh
.kokoro/system-test.sh
.kokoro/test.bat
.kokoro/test.sh
.kokoro/trampoline.sh
.nycrc
.prettierignore
.prettierrc
CODE_OF_CONDUCT.md
CONTRIBUTING.md
LICENSE
README.md
codecov.yaml
renovate.json
samples/README.md
synthtool > Replaced "(const SpannerClient = require\\('\\./spanner_client'\\);)" in src/v1/index.js.
synthtool > Replaced '(module\\.exports\\.SpannerClient = SpannerClient;)' in src/v1/index.js.
synthtool > Replaced '../../package.json' in src/v1/database_admin_client.js.
synthtool > Replaced '../../package.json' in src/v1/instance_admin_client.js.
synthtool > Replaced '../../package.json' in src/v1/spanner_client.js.
synthtool > Replaced 'https:\\/\\/cloud\\.google\\.com[\\s\\*]*http:\\/\\/(.*)[\\s\\*]*\\)' in src/v1/doc/google/protobuf/doc_timestamp.js.
synthtool > No replacements made in **/doc/google/protobuf/doc_timestamp.js for pattern toISOString\], maybe replacement is not longer needed?
synthtool > Replaced '`\\[a-z\\]\\(https:\\/\\/cloud\\.google\\.com\\[-a-z0-9\\]\\*\\[a-z0-9\\]\\)\\?`' in src/v1/doc/google/spanner/admin/instance/v1/doc_spanner_instance_admin.js.
synthtool > Replaced '`\\[a-z\\]\\(https:\\/\\/cloud\\.google\\.com\\[-a-z0-9\\]\\*\\[a-z0-9\\]\\)\\?`' in src/v1/doc/google/spanner/v1/doc_spanner.js.
synthtool > Replaced '`\\(\\[a-z\\]\\(https:\\/\\/cloud\\.google\\.com\\[-a-z0-9\\]\\*\\[a-z0-9\\]\\)\\?\\)\\?`' in src/v1/doc/google/spanner/admin/instance/v1/doc_spanner_instance_admin.js.
synthtool > Replaced '`\\(\\[a-z\\]\\(https:\\/\\/cloud\\.google\\.com\\[-a-z0-9\\]\\*\\[a-z0-9\\]\\)\\?\\)\\?`' in src/v1/doc/google/spanner/v1/doc_spanner.js.
npm WARN npm npm does not support Node.js v12.13.0
npm WARN npm You should probably upgrade to a newer version of node as we
npm WARN npm can't make any promises that npm will work with this version.
npm WARN npm Supported releases of Node.js are the latest release of 6, 8, 9, 10, 11.
npm WARN npm You can find the latest version at https://nodejs.org/
npm WARN deprecated<EMAIL_ADDRESS>This is a stub types definition. p-retry provides its own type definitions, so you do not need this installed.
npm WARN deprecated<EMAIL_ADDRESS>Please note that v5.0.1+ of superagent removes User-Agent header by default, therefore you may need to add it yourself (e.g. GitHub blocks requests without a User-Agent header).  This notice will go away with v5.0.2+ once it is released.

><EMAIL_ADDRESS>install /tmpfs/src/git/autosynth/working_repo/node_modules/grpc
> node-pre-gyp install --fallback-to-build --library=static_library

node-pre-gyp WARN Using needle for node-pre-gyp https download
[grpc] Success: "/tmpfs/src/git/autosynth/working_repo/node_modules/grpc/src/node/extension_binary/node-v72-linux-x64-glibc/grpc_node.node" is installed via remote

><EMAIL_ADDRESS>postinstall /tmpfs/src/git/autosynth/working_repo/node_modules/core-js
> node postinstall || echo "ignore"

><EMAIL_ADDRESS>postinstall /tmpfs/src/git/autosynth/working_repo/node_modules/protobufjs
> node scripts/postinstall

><EMAIL_ADDRESS>prepare /tmpfs/src/git/autosynth/working_repo
> npm run compile

npm WARN npm npm does not support Node.js v12.13.0
npm WARN npm You should probably upgrade to a newer version of node as we
npm WARN npm can't make any promises that npm will work with this version.
npm WARN npm Supported releases of Node.js are the latest release of 6, 8, 9, 10, 11.
npm WARN npm You can find the latest version at https://nodejs.org/

><EMAIL_ADDRESS>compile /tmpfs/src/git/autosynth/working_repo
> tsc -p . && cp -r src/v1 build/src && cp -r protos build && cp -r proto build && cp test/*.js build/test

npm notice created a lockfile as package-lock.json. You should commit this file.
npm WARN optional SKIPPING OPTIONAL DEPENDENCY<EMAIL_ADDRESS>(node_modules/fsevents):
npm WARN notsup SKIPPING OPTIONAL DEPENDENCY: Unsupported platform for<EMAIL_ADDRESS>wanted {"os":"darwin","arch":"any"} (current: {"os":"linux","arch":"x64"})

added 1143 packages from 1429 contributors and audited 6582 packages in 32.414s
found 0 vulnerabilities

npm WARN npm npm does not support Node.js v12.13.0
npm WARN npm You should probably upgrade to a newer version of node as we
npm WARN npm can't make any promises that npm will work with this version.
npm WARN npm Supported releases of Node.js are the latest release of 6, 8, 9, 10, 11.
npm WARN npm You can find the latest version at https://nodejs.org/

><EMAIL_ADDRESS>fix /tmpfs/src/git/autosynth/working_repo
> gts fix && eslint --fix '**/*.js'

installing<EMAIL_ADDRESS>installing<EMAIL_ADDRESS>(node:15751) UnhandledPromiseRejectionWarning: Error: illegal token 'option' (protos/google/spanner/admin/database/v1/spanner_database_admin.proto, line 384)
    at illegal (/tmpfs/src/git/autosynth/working_repo/node_modules/protobufjs/src/parse.js:94:16)
    at parse (/tmpfs/src/git/autosynth/working_repo/node_modules/protobufjs/src/parse.js:719:27)
    at process (/tmpfs/src/git/autosynth/working_repo/node_modules/protobufjs/src/root.js:107:30)
    at fetch (/tmpfs/src/git/autosynth/working_repo/node_modules/protobufjs/src/root.js:166:13)
    at Root.load (/tmpfs/src/git/autosynth/working_repo/node_modules/protobufjs/src/root.js:194:13)
    at Root.loadSync (/tmpfs/src/git/autosynth/working_repo/node_modules/protobufjs/src/root.js:235:17)
    at main (/tmpfs/src/git/autosynth/working_repo/node_modules/protobufjs/cli/pbjs.js:236:18)
    at internal/util.js:278:30
    at new Promise (<anonymous>)
    at main (internal/util.js:277:12)
(node:15751) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). (rejection id: 2)
(node:15751) [DEP0018] DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js process with a non-zero exit code.
synthtool > Cleaned up 2 temporary directories.
synthtool > Wrote metadata to synth.metadata.

@alexander-fenster @callmehiphop we're seeing the decode error I've noticed before when there's a missing proto import.

@bcoe This is caused by a protobufjs bug that I fixed in https://github.com/protobufjs/protobuf.js/pull/1183 but I think there were no releases since that time.
I will rearrange options in the proto files to make it work. Closing this one for now, let's wait for the next synthtool invocation.


Code hint is invalid on mac

VSCode Version: 1.36.1
OS Version: macOS Mojave 10.14.5

Steps to Reproduce:

create a react project with creat-react-app
2.Try to enter a life cycle function

Does this issue occur when all extensions are disabled?: Yes
Mac

Windows

Does this reproduce in the latest VS Code insiders build with all extensions disabled?

Also share the code as text, not just a screenshot


CDN deployment

Question:
I'm using this lib on a website with Blazor WASM. The default way of build and deployment is copy the published files to the wwwroot\_content folder.
Now I want to copy the published files to the CDN. But how to let the dependency links be the CDN URL instead of the local _contents folder URL? I don't find any related properties of BlazorPlot or any extension methods which can help it.

ScottPlot Version: 5.0.40

Hi @LeaFrock, I think the way is to edit index.html to point to the location of the resources
https://swharden.com/tmp/sp/11/
Notice my source code especially the base reference
<!DOCTYPE html>
<html lang="en">

<head>
    <meta charset="utf-8" />
    <meta name="viewport" content="width=device-width, initial-scale=1.0, maximum-scale=1.0, user-scalable=no" />
    <title>ScottPlot Blazor Sandbox</title>
    <base href="https://swharden.com/tmp/sp/11/" />
    <link rel="stylesheet" href="css/bootstrap/bootstrap.min.css" />
    <link rel="stylesheet" href="css/app.css" />
    <link rel="stylesheet" href="Sandbox.Blazor.WebAssembly.styles.css" />


Setting on instance for new/old login

As an administrator and a ZITADEL admin, I am able to enable and disable new/old Login for an instance.
We implement a new policy (feature policy/beta features?) to be able to enable the new login.
Acceptance Criteria

[ ] I am able to set the policy per api (new api or system and admin api)
[ ] I am able to switch between new and old login
[ ] I am able to set the setting in the console
[ ] The setting will be taken into account when the suers of the instance login

Who has the permission to toggle the features?
Are there features that only we as ZITADEL devs should be able to enable.

This is not needed for the momen


Pokemon not showing on reopening of app

When I go away from the app and return, there are no pokemon showing.  Going into settings and switching show pokemon off and on again brings them back.  Maybe becuase I'm on iOS10... Any thoughts?

Are you using V2.0 IPA ?

I'm using the xcodeproj file I downloaded this morning, which I think v2.


Fix inspector dock not updating tree for main resource

Should fix #19702.

Closing. I'll fix on this pr #19351.


add stabilization?

how about adding position stabilization while already having a list of frames?
I'd think that'd be a great additional feature for a tracker, wouldn't it?
as seen in https://github.com/tawnkramer/CarND-Vehicle-Detection#3-stablization

hi, could you be more specific ?

hey, maybe just return the average position of the last n:configurable frames...
That would make for a much smoother movement of tracking frames when displayed.

what would be the method to compute the average position for moving objects ?

i guess you'd have to feed a relatively short list of frames to prevent lagging,
but maybe implementing one of those would be worth a try:
https://www.npmjs.com/package/moving-averages

ok, yes but we can't do that as we are computing in real time, we just know the next and previous frame to perform tracking ;-)

🤔  i thought that would make it fairly easy to keep the n last frames and output the moving average position instead of the actual exact position.
but of course you can do that on top of the tracking from outside...
thx anyway!

yes, but you can't display in real time in this case... Don't get me wrong, you are very welcome to send a Pull Request will this feature added that we could enable as an extra feature


Advanced search bar

I've made my own version of #36 to add quick search functionality. It also completes #49 by allowing the user to search for messages by an author within a thread (and allows for terms to be searched up in conjunction with authorship).
This search bar will be added to the beta branch first.

What's the difference between this and #46 ?

What's the difference between this and #46 ?

This search bar is fundamentally different from the search bar that Altansar adapted, leading to major differences in config.html. My plan was to get this checked and then if approved, merge it into the beta branch (replacing the one in the beta branch currently). It would then get merged into the master branch when that pull request gets approved.

Okay, that's fine with me.


Feature/webstorage

Adds support for Web Storage (set_web_storage_item/5, get_web_storage_item/4, remove_web_storage_item/2, check_web_storage_support/1)

After, eventually, learning and understanding dialyzer and fixing all @spec and style issues, I'm still get an error, from Travis this time, but it seems unrelated with my code. It is maybe a known issue?

I'm still get an error, from Travis this time, but it seems unrelated with my code. It is maybe a known issue?
Yes, travis sometimes fails to run, randomly. The best would be if you test and dialyze on your machine, before sending a code - travis is just like the last line of defense. :)

I'm still get an error, from Travis this time, but it seems unrelated with my code. It is maybe a known issue?

Yes, travis sometimes fails to run, randomly. The best would be if you test and dialyze on your machine, before sending a code - travis is just like the last line of defense. :)

Yes, I've dialyzed locally before pushing, but I wasn't get any error  (sorry for the mess in this PR, I was unaware of how ebert and dialyze work).
But today I see that the previous errors on issue  #321.2 that Travis complained about (when it tested the combination Elixr1.6.6/otp 21) and that was unrelated with my code, are gone without doing any changes on my side.

This duplicates functionality of the Drab Store.
https://hexdocs.pm/drab/Drab.Core.html#module-store

We may add options to it, like setting up the kind of storage in a runtime, or a cipher, but we should not duplicate stuff.

Yes, I was aware of Drab.Core.html#module-store, but I thought that it wasn't intended as the official way to access Web Storage because it isn't explicit stated to do that, because it lacks many functionalities, because it is signed, and because it was not under the Drab.Browser module. So it seemed to me that is was written most for internal use. For this reason I thought that it could were useful to write and share some specific APi that explicitly interfaces the Web Storage.
What da you suggest to do?

Store is an higher-level abstraction over the browser storage (and it doesn't have to be a storage, it can exist in memory only). And it is definitely purposed to be used by developers! As an analogy to Plug Session, where you don't care if it is set in cookie or in redis.

because it is signed

Actually it is crypted, it was a bug in docs!

because it lacks many functionalities

What do you mean?
What we could do to improve it, is to add two options to get_store and put_store:

:encoder, :decoder, as an analogy to cookie etc
:storage - :memory, :local_storage or :session_storage - the same as in :drab_store_storage, to allow letting users to choose; I am still thinking if it is a good idea as the same keys may confuse beginners.

I don't like the idea to create new functions for the storage. It will confuse new users. Yeah, well, that's just, like, my opinion, man :) What you might want to do, is to create a library dependent on Drab with this functionality and publish it on hex.


Error after upgrading to v0.1.2

After upgrading from v0.1.1 to v0.1.2 this morning none of my entities are updating. The following error shows in the logs:
Logger: homeassistant
Source: custom_components/victron/sensor.py:157
Integration: victron ([documentation](https://github.com/sfstar/hass-victron), [issues](https://github.com/sfstar/hass-victron/issues))
First occurred: 8:25:55 AM (30 occurrences)
Last logged: 8:28:20 AM

Error doing job: Task exception was never retrieved
Traceback (most recent call last):
  File "/usr/src/homeassistant/homeassistant/helpers/update_coordinator.py", line 229, in _handle_refresh_interval
    await self._async_refresh(log_failures=True, scheduled=True)
  File "/usr/src/homeassistant/homeassistant/helpers/update_coordinator.py", line 374, in _async_refresh
    self.async_update_listeners()
  File "/usr/src/homeassistant/homeassistant/helpers/update_coordinator.py", line 164, in async_update_listeners
    update_callback()
  File "/config/custom_components/victron/sensor.py", line 157, in _handle_coordinator_update
    self._attr_native_value = self.entity_type.decodeEnum(data).name.split("_DUPLICATE")[0]
                              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.11/enum.py", line 711, in __call__
    return cls.__new__(cls, value)
           ^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.11/enum.py", line 1128, in __new__
    raise ve_exc
ValueError: 5.0 is not a valid generic_status

Restarting, removing and re-adding the hub, removing and re-downloading the extension does not resolve the issue. Downgrading to 0.1.1 is also does not resolve the problem.
Home Assistant 2023.7.2

I've managed to get this working again.
Currently running HA 2023,7,3 and hass-victron v0.1.2. I have had to disable the "Tank Status"

I assume it's the currently disconnected tank that is causing the problem:

Hello @marnitz and thank you for opening this issue,
Would you be able to re-enable the tank status and check what the status in the GX device is when the above mentioned error is returned?
It seems that there are possible states for this register that are undocumented by victron.
Thereby, decoding of the register fails and the error is logged.
By checking the state in the GX device when the error occurs we can deduce what the state of register value 5 is supposed to be.

@sfstar - the status is "Error"

The issue has been shipped in the latest release (v0.3.0) closing issue as resolved.
Feel free to re-open if the issue persists with the v0.3.0 release


Arrow-key constants

You mentioned previously somewhere (in a pull request comment I think) that you intended to define constants for the arrow keys. What do you think about using the ASCII-codes for the ctrl-combinations that *nix has used since forever?
Up      ctrl+p    [0x10]
Down    ctrl+n    [0x0E]
Left    ctrl+b    [0x02]
Right   ctrl+f    [0x06]
Would the best place to add these on the application side be to drivers.inc/screen.h or do you see any use for the arrow keys in tty applications?

Those will conflict with control keys --- I ran into this on the ADM3a, which uses ^H, ^J, ^K, ^L and it's actually really annoying that you can't use this keys for anything else. Consider WordStar which uses ^K a lot.
High-bit-set codes are more appropriate here IMO because in the largely 7-bit world of CP/M we know these can't overlap with either printable or control characters. I was vaguely thinking of using the BBC Micro ones, $88/$89/$8a/$8b for this.

I thought of conflicting with control keys as a good thing, as you can fake the arrow keys if you are using a computer or terminal without them, but I see your point of conflicting with other uses for these key combinations as there are no standard expected functions in most cases (as there are on most unix-like systems).
I agree that using high-bit-set codes is a cleaner way to implement this,  letting the bios code handle any odd cases when needed.

I tried to add arrow key translation to the Apple II bios, but I have not figured out how to distinguish the arrow keys from Ctrl+h/j/k/u.
Does someone know if it is possible to read the raw keycodes somehow, instead of the translated ASCII?
I tried checking bit 1 of KEYMODREG (0xC025) to see if Ctrl is pressed without any luck. I'm not sure about the expected behavior here, this could perhaps be an emulation promblem?
Apart from this, I think this has been implemented on most platforms with a SCREEN driver, so maybe the issue could be closed?


fix: Fix for issue #254

Fixing the Delete button for the cases where the "Tooling API" option has been selected when querying
Describe your changes
Included logic for sending the apiType as a parameter to the data-import.
Issue ticket number and link
Issue 254
Checklist before requesting a review

[x] I have read and understand the Contributions section
[x] Target branch is releaseCandidate and not master
[x] I have performed a self-review of my code
[x] I ran the unit tests and my PR does not break any tests
[x] I documented the changes I've made on the CHANGES.md and followed actual conventions
[x] I added a new section on how-to.md (optional)

Great thank you @ogomezba for this fix 🚀 👏
FYI we had a bug last week on this feature, I added a limit to prevent errors to happen but I'm not sure if we have to go further since the tool is not really built for large data operations..

Hi @tprouvot!
For large operations, it's probably better to use other tools like the Bulk API or DataLoader. I think that, at least for now, it is okay to limit the usage to a smaller number of records. I think it aligns better with the original philosophy of the Inspector :)


[MKT-412] Updating marketplace GitHub actions to validate new template fields

What does this PR do?

Updates README validations:

Adds check that there is text under the ## Overview h2
Adds check that there is text under the ## Setup h2
Adds check that there is text under the ## Support h2 (marketplace specific)
Adds check that there exists a ## Uninstallation h2 (marketplace specific)
Adds check that there is text under the ## Uninstallation h2 (marketplace specific)

Motivation

Marketplace partners are now required to submit uninstallation instructions in their READMEs to avoid customers getting charged when they believe they have cancelled their subscription. In order to ensure that partners submit uninstallation instructions and fill out the h2, this check has been added. Customers will now have instructions to fully cancel and uninstall an integration to avoid getting charged by the partners.
Testing
This branch's ddev readmes command has been tested against the integrations-core and integrations-extras repo and passes all the readmes.
Additional Notes

Review checklist (to be filled by reviewers)

[ ] Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
[ ] PR title must be written as a CHANGELOG entry (see why)
[ ] Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
[ ] PR must have changelog/ and integration/ labels attached
[ ] If the PR doesn't need to be tested during QA, please add a qa/skip-qa label.

I added the WIP label to the PR, feel free to remove it once done and ping us in slack for a review 🙂


CLARITY notebook

can you make a clarity jupyter notebook, showing how to:

download data from ndstore
resample
learn deformation
apply deformation
visually inspect (using overlay, checkerboard, and/or the thing you used for the other example)
compute error metrics
display jacobian stuff

what do you think?

Sure.  I'll add it to my weekly experiments

OK so I've created the notebook

this is great!!!
can you please add

the metrics you computed, including the distribution and mean of

squared error
MI error
"atrophy"

example of how to ingest the coronal oriented brain back into ndstore

thank you!
On Tuesday, September 20, 2016, kkutten1<EMAIL_ADDRESS>wrote:

OK so I've created the notebook
https://github.com/neurodata/ndreg/blob/master/doc/advancedRegistration.ipynb
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/neurodata/ndreg/issues/30#issuecomment-248434347, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AACjcujjHdDWMPrXc2V1dXwTNXHxhgC8ks5qsErPgaJpZM4J5fZy
.

--
the glass is all full:  half water, half air.
neurodata.io, jovo calendar
https://calendar.google.com/calendar/embed?src=joshuav%40gmail.com&ctz=America/New_York

@jovo: I've made the suggested changes
https://github.com/neurodata/ndreg/blob/master/doc/advancedRegistration.ipynb

looks great!!!!
can you change the y-axis on the distributions to be frequency rather than
count?
On Thu, Sep 29, 2016 at 10:35 AM, kkutten1<EMAIL_ADDRESS>wrote:

@jovo https://github.com/jovo: I've made the suggested changes
https://github.com/neurodata/ndreg/blob/master/doc/
advancedRegistration.ipynb
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/neurodata/ndreg/issues/30#issuecomment-250484713, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AACjcqx9ObzlWcjMn7iXFaqcYq82UwRkks5qu8zEgaJpZM4J5fZy
.

--
the glass is all full:  half water, half air.
neurodata.io, jovo calendar
https://calendar.google.com/calendar/embed?src=joshuav%40gmail.com&ctz=America/New_York

@jovo: OK I've made that change
https://github.com/neurodata/ndreg/blob/master/doc/advancedRegistration.ipynb


[ENH][SCHEMA] Add tags for DeIdentificationMethod/CodeSequence

Add tags for DeIdentificationMethod and DeIdentificationMethodCodeSeuence, corresponding to the same-named DICOM tags. These record info on de-identification, including metadata and image content (e.g. de-facing or removing burned-in text)

This addresses issue #1709

I apologize for missing some pieces, and I think I understand, now. Thank you for your careful review and for helping me through this process. I will execute your suggestions and amend the PR with another commit.

No need to apologize! I appreciate the effort you're putting into this.

Chris,
I committed your suggested diffs as-is. For the tables and sidecars, I deviated a bit in calling both tags optional. My read of DICOM is that if PatientIdentityRemoved is TRUE (which is a tag we don't have in BIDS, and I don't think BIDS really needs it), then at least one of either DeidentificationMethod or DeidentificationCodeSequence is required. Without PatientIdentityRemoved, I would say neither is required, and both are optional. It's not that DeidentificationMethod is recommended if DeidentificationCodeSequence is present, but rather they are of equal status and people can use either. DeidentificationMethod is a single simple string, but there's a greater chance that some downstream software would replace rather than amend the string. DeidentificationCodeSequence better accounts for there being a series of de-identification steps and other software would more likely amend than overwrite it, but it's also a sequence tag and those are unpleasantly messy.
While I was copying from the MRI to the PET table, I noticed the "defacemask" block in the MRI but not PET. I copied this to the PET, since de-facing is also routinely applied to PET now.
I looked for CT-related files, but it appears that CT is not a part of BIDS currently? If CT is ever added, my recommendation is that these elements all be added to CT to match MRI and PET.
Thanks for your help and careful review!

For the tables and sidecars, I deviated a bit in calling both tags optional. My read of DICOM is that if PatientIdentityRemoved is TRUE (which is a tag we don't have in BIDS, and I don't think BIDS really needs it), then at least one of either DeidentificationMethod or DeidentificationCodeSequence is required. Without PatientIdentityRemoved, I would say neither is required, and both are optional.

Sounds good.

While I was copying from the MRI to the PET table, I noticed the "defacemask" block in the MRI but not PET. I copied this to the PET, since de-facing is also routinely applied to PET now.

Could you split that out into a separate PR? I think it will need some additional work to apply properly to PET, and I'd rather not complicate this PR more than necessary.

I looked for CT-related files, but it appears that CT is not a part of BIDS currently? If CT is ever added, my recommendation is that these elements all be added to CT to match MRI and PET.

Correct, and agreed!

Chris,
I attempted to make all the changes you suggested. The automated checks that failed appear to be related to parts of the code that I did not change in this branch, so unrelated to my changes. Thanks for your continuing reviews.
Chris

Thanks Chris (Markiewicz)!
I have a companion PR for dcm2niix at https://github.com/rordenlab/dcm2niix/pull/813, but Chris (Rorden) hasn't commented on it yet. I had initially asked him to add the tags to dcm2niix's .json, and he said to get them added to bids-specification first, so that's how arrived here.
I don't have any involvement with the other converters.
Thanks,
Chris (Schwarz)

I just want to check in on the status here. It looks like there aren't objections, but are we waiting on a PR to bids-examples, or an agreement in principle RE https://github.com/rordenlab/dcm2niix/pull/813?

This looks great as it would greatly speed up my ability to determine if PET images have been defaced or not. Will very happily add this to PET deface as soon as it's merged.


fix fsa assist interrupts fsa jump

I now have a few thousand jumps behind me with this AP and not even one miss align but these 3 lines unfortunately interrupt the fsa during the further jump attempts when the fsa is damaged. If a miss align should take place the fsa must not be interrupted that should not be a problem.

yeah, this is a good change, I've had this happen to me a few times


Fix whitespace on deployment page

Fix deployments description in french.

I signed it !

/lgtm
/approve

@Patouche Thanks a lot. Feel free to join us on the #kubernetes-docs-fr channel on the Kubernetes slack (https://slack.k8s.io)


[QUERY] Azure.Blob.Storage auto-renewal of blob

Library name and version
Azure.Blob.Storage 12.10.0
Query/Question
Hello,
I am using Azore Blob Storage to keep a cache of a list of companies in an Azure Function v3 and update it as I go.
I see an insane amount of usage on the storage ressource, severals thousands calls per day, while the code that uses that "CompanyCache" is called only a few hundreds times a day.
When I look at the logging, I realize that the BlobClient is constantly trying to continue the lease it created, even when the DI is configured to have it "Scoped" and the request is over.
And also that there is an insane amount of error because the lease was already granted.
So that makes a few questions:
1/ Do I use it correctly ? (Scoped + build the BlobClient from ctor)
=> I also tried Singleton + build from ctor, Singleton + build BlobClient before each call, also + breaking the lease manually after each call, + releasing the lease manually.
Often the breaking/releasing ends in more logging error because the BlobClient try to auto-renew a non existent lease.
Also, in local, none of those problems happens.
2/ If not, what could I change ?
3/ Is there an "auto-lease-renewal" that I can disable ? I am not sure, but it seems that I did not have this issue with version 12.7.0
4/ Why none of the samples/documentation explains how to -actually- use it in a real world problem use case, most of those just chains all the calls in a single method not giving insight on how to really use it.
I inject it this way
            builder.Services.AddAzureClients(innerBuilder =>
            {
                string connectionString = Environment.GetEnvironmentVariable("AZURE_STORAGE_CONNECTION_STRING");
                innerBuilder.AddBlobServiceClient(connectionString);
            });
            builder.Services.AddScoped<CompanyCache>();

and I use it this way
    public class CompanyCache
    {
        private const string BlobContainerName = "xxxxxxxxxx";
        private const string BlobName = "yyyyyyyyyyy";
        private readonly BlobClient _blobClient;
        private readonly SymmetricKey _symmetricKey;
        private CompanyBlob _currentCache;

        public CompanyCache(BlobServiceClient blobServiceClient)
        {
            var blobContainerClient = blobServiceClient.GetBlobContainerClient(BlobContainerName);
            blobContainerClient.CreateIfNotExists();
            _blobClient = blobContainerClient.GetBlobClient(BlobName);
            _symmetricKey = SymmetricKey.Parse(Environment.GetEnvironmentVariable("COMPANY_CACHE_KEY"));
        }

        public async Task<List<ICompany>> DownloadFromCacheAsync()
        {
            await using var encryptedBlob = new MemoryStream();
            try
            {
                var rawCompanyList = await _blobClient.DownloadToAsync(encryptedBlob);
                if (rawCompanyList.Status >= 300)
                {
                    return new List<ICompany>();
                }
            }
            catch (RequestFailedException e)
            {
                if (e.Status == 404)
                {
                    return new List<ICompany>();
                }

                throw;
            }

            byte[] decryptedBlob = _symmetricKey.Decrypt(encryptedBlob.ToArray());
            encryptedBlob.Close();
            string jsonString = Encoding.UTF8.GetString(decryptedBlob);

            _currentCache = JsonConvert.DeserializeObject<CompanyBlob>(jsonString);

            bool shouldDiscardCache = _currentCache.CreationDate < DateTime.UtcNow.AddDays(-2);
            if (shouldDiscardCache)
            {
                return new List<ICompany>();
            }

            return _currentCache.Companies;
        }

        public async Task AddElementToCacheAsync(ICompany companyToAdd)
        {
            _currentCache.Companies.Add(companyToAdd);
            await UploadCompanyBlobAsync();
        }

        public async Task UpdateElementToCacheAsync(ICompany companyToUpdate)
        {
            int companyToUpdateIndex =
                _currentCache.Companies.FindIndex(o => o.Id == companyToUpdate.Id);

            _currentCache.Companies[companyToUpdateIndex] = companyToUpdate;

            await UploadCompanyBlobAsync();
        }

        public async Task DeleteElementFromCacheAsync(string companyId)
        {
            int companyToDeleteIndex =
                _currentCache.Companies.FindIndex(o => o.Id == companyId);

            _currentCache.Companies.RemoveAt(companyToDeleteIndex);

            await UploadCompanyBlobAsync();
        }

        public async Task RebuildCacheAsync(List<ICompany> listOfCompanies)
        {
            _currentCache = new CompanyBlob
            {
                CreationDate = DateTime.UtcNow,
                Companies = listOfCompanies
            };

            await UploadCompanyBlobAsync();
        }

        private async Task UploadCompanyBlobAsync()
        {
            string jsonString = JsonConvert.SerializeObject(_currentCache);
            byte[] jsonBytes = Encoding.UTF8.GetBytes(jsonString);

            byte[] encryptedBlob = _symmetricKey.Encrypt(jsonBytes);

            await using var stream = new MemoryStream(encryptedBlob);
            var blobHttpHeader = new BlobHttpHeaders {ContentType = "application/octet-stream"};

            _ = await _blobClient.UploadAsync(stream, blobHttpHeader);
            stream.Close();
        }
    }

Environment
Azure Function v3
Nuggets
<Project Sdk="Microsoft.NET.Sdk">
  <PropertyGroup>
    <TargetFramework>netcoreapp3.1</TargetFramework>
    <AzureFunctionsVersion>v3</AzureFunctionsVersion>
  </PropertyGroup>
  <ItemGroup>
    <PackageReference Include="Azure.Storage.Blobs" Version="12.10.0" />
    <PackageReference Include="DeveloperForce.Force" Version="2.1.0" />
    <PackageReference Include="MediatR" Version="9.0.0" />
    <PackageReference Include="MediatR.Extensions.Microsoft.DependencyInjection" Version="9.0.0" />
    <PackageReference Include="Microsoft.Azure.Functions.Extensions" Version="1.1.0" />
    <PackageReference Include="Microsoft.Azure.WebJobs.Extensions.Http" Version="3.0.12" />
    <PackageReference Include="Microsoft.Extensions.Azure" Version="1.1.1" />
    <PackageReference Include="Microsoft.Extensions.Http.Polly" Version="3.1.21" />
    <PackageReference Include="Microsoft.Extensions.DependencyInjection" Version="3.1.21" />
    <PackageReference Include="Microsoft.Extensions.Options" Version="3.1.21" />
    <PackageReference Include="Microsoft.NET.Sdk.Functions" Version="1.0.38" />
    <PackageReference Include="Microsoft.IdentityModel.Tokens" Version="5.1.4" />
  </ItemGroup>

Here an example of log generated

@seanmcc-msft
I'm wondering if the changes done on the new generator earlier this year could have introduced a bug where the BlobRestClient would kind of "keep-alive" and keep renewing a lease if it received a partial result on the download start even though it successfully downloaded on the second attempt ?
That would be the explanation to my issue as when I'm in local, I don't have a partial content the first time but the full blob and that's the only difference I can think off right now... on christmas's eve 🤣
I wish you guys an amazing holiday season, hope I can find my answers in 2022.

@seanmcc-msft
I just realized that the DownloadToAsync never really complete, it get a Partial Content up to the penultimate byte then, the lease renewal process start running and will spam for about 10 minutes before the azure function shutdown (if no more calls).
Is there a way to force the BlobClient to consider that request closed for good ?
When someone repported about that PartialContent being returned, they were told that it was totally fine, but is it though ?
https://github.com/Azure/azure-sdk-for-net/issues/17945
Also, someone else started seeing a huge amount of logs about leasing and just ignored it, and was also told it was fine and to just disable logs.
https://github.com/Azure/azure-sdk-for-net/issues/21511
It may be related or not, but I recently updated most of my nuggets (start of december), and arround 12 december, my azure storage subscription started to cost more by a factor of 30, looking at metrics, the insane amount of requests begin there.
If all that is related, that would mean the issue has been introduced somewhere between Azure.Blog.Storage 12.7.0 and 12.10.0.
Response [3285bce4-b612-4af4-b38f-a4282c7afeb5] 206 Partial Content (00.2s)
Accept-Ranges:bytes
ETag:"0x8D9XXXXXXXCE454"
Server:Windows-Azure-Blob/1.0,Microsoft-HTTPAPI/2.0
x-ms-request-id:750e3af1-301e-0029-1410-f97f23000000
x-ms-client-request-id:3285bce4-b612-4af4-b38f-a4282c7afeb5
x-ms-version:2020-10-02
x-ms-creation-time:Thu, 26 Nov 2020 13:41:10 GMT
x-ms-blob-content-md5:7eju/BgAi8MTV6QhRPds6A==
x-ms-lease-status:unlocked
x-ms-lease-state:available
x-ms-blob-type:BlockBlob
x-ms-server-encrypted:true
Date:Fri, 24 Dec 2021 21:51:24 GMT
Content-Length:21887503
Content-Type:application/octet-stream
Content-Range:bytes 0-21887502/21887503
Last-Modified:Fri, 24 Dec 2021 21:46:51 GMT


Broken docker image dependencies

Hello!
I did all steps mentioned under "How to run" title, and it don't start.
I tried to run it using docker:
docker run -d -p 25565:25565 -v /etc/hopper/Config.toml:/Config.toml ghcr.io/bra1l0r/hopper-rs
Logs:
Error relocating /hopper: __res_init: symbol not found
Any tutorial with fixing it? Thank you in advance!

Hello @JaredHuh, thank you for showing interest in the project. It is a known issue to me that the docker image is missing glibc dependencies and is dorked at the moment. I will fix it right now

Fixed in b7b60805477cf3db638d7121a3cec5e46f0b237f


j.tools.team.manager.test() fails

** PLEASE IGNORE THIS BUGREPORT DO NOT ASSIGN IT TO ANY MILESTONE DO NOT ACTION IT, IT IS A PLACEHOLDER **
ERROR: test0070_j_tools_team_manager_test (tests.jumpscale_test.test09_js_dynamic_walker.TestJSDynamicWalkerTestSearch)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/opt/code/github/threefoldtech/jumpscale_core/Jumpscale/clients/git/GitFactory.py", line 288, in pullGitRepo
    interactive=interactive)
  File "/opt/code/github/threefoldtech/jumpscale_core/Jumpscale/clients/git/GitFactory.py", line 444, in pullGitRepo
    self.execute(cmd, timeout=timeout, executor=executor)
  File "/opt/code/github/threefoldtech/jumpscale_core/Jumpscale/clients/git/GitFactory.py", line 21, in execute
    return executor.execute(*args, **kwargs)
  File "/home/lkcl/src/jumpscale_core/Jumpscale/tools/executor/ExecutorLocal.py", line 137, in execute
    cmds2, die=die, showout=showout, timeout=timeout)
  File "/home/lkcl/src/jumpscale_core/Jumpscale/sal/process/SystemProcess.py", line 206, in execute
    raise RuntimeError(msg)
RuntimeError:
Could not execute:    set -e
    mkdir -p /opt/code/docs/gig
    cd /opt/code/docs/gig
    git -c http.sslVerify=false clone   ssh://git@docs.grid.tf:10022/gig/data_team.git /opt/code/docs/gig/data_team

stderr:
    Cloning into '/opt/code/docs/gig/data_team'...
    ssh: connect to host docs.grid.tf port 10022: Connection refused
    fatal: Could not read from remote repository.

    Please make sure you have the correct access rights
    and the repository exists.

unit test can now be disabled and reference this bugreport until the unit test is fixed

commit 4c1abd8


Helped Migrate to Appwrite Version 0.15.^ and Appwrite SDK 6.0.0

I found your project in awesome-Appwrite repo and decided to help you migrate it since it is on the official curated list of awesome Appwrite resources.
I also :

Fixed some issues raised by the updated linter.
Refractored some of the code

No problem @dvmjoshi 🔥💯😃


Add options for History and Wanted/Missing queries skip, remove sort on Wanted/Missing

Description of the change

Add options for History and Wanted/Missing queries skip, remove sort on Wanted/Missing

Benefits

Faster metrics collection for users not desiring History/Wanted/Missing
Stall mitigation re: users with large collections or long-lived instances

Possible drawbacks

I don't know Golang or koanf and did not look up reference for either, but I believe I have treated both appropriately.

Applicable issues

#298

Additional information

Thanks for your work.

Changes appear good here, but I wonder if it could be added to the logic --enable-additional-metrics flag instead of creating separate config flags / env options? I am not sure if there is a use-case for why you would want --enable-additional-metrics on but turn off the history & wanted/missing flags?
Also @rtrox would be great if/when you are free to review to get a pair of second eyes on this.

Thanks for the PR @codefaux! Sorry about the delayed review here, been dealing with some issues in RL. A few comments, but overall looks good!


Custom Complex RNNs

Keras a fine, well-equiped library. However, it is depressing to learn that it lacks an API interface to build custom cyclic/recurrent networks. If one needs to implement a simple a custom RNN, he needs to implement his own functions and classes on top of keras' RNN class, or switch back to TensorFlow, missing out all the Keras powerful features.
However, custom RNN is a basic necessity. How can a researcher try to emulate a human brain (that the AI is all about) without building custom RNNs?
A guy had to build a custom library (called RecurrentShop) on his own at home in free time solely for this purpose. And he built it 3 years ago, and requested Keras team to incorporate it into the framework, and still after 3 years, there is no interface of custom RNNs in Keras.
Custom RNNs are the backbone of natural AI (human brain), and are absolutely necessary so that college students and beginners can also perform more advanced research work without having to invest days and months and years learning the complexities of minute details before arriving at the stage of performing meaningful research.
Right now, if someone needs to build a custom RNN, he needs to discard keras and downgrade to TF missing all the Keras powerful features. This increases the experimentation time, debugging time, and guesswork time by 100x. Or they have to stumble upon libraries like RecurrentShop (only after hours and days of reading random stuff online), only to find out that the library is not fully compatible with latest Keras and may result in errors which may or may not be hard to debug.
[Note: I am not a student. I am a 30-year-old business man and a coder. And I have keen interests in AI.]
I request Keras team to give priority to building API interface for custom RNNs just like they have built functional APIs for Sequential Models.
If Keras team needs funding for this purpose (to shift their focus from whatever it is right now to building interface for custom RNNs), please contact me. I might be able to help with this using my connections.

Hi Keras Team,
Please do let me know what you think?


If you get error code 100 and 127 in your docker container for jenkins and ansible

failed to solve: process "/bin/sh -c apt-get update && apt-get -y install ansible" did not complete successfully: exit code: 100

failed to solve: process "/bin/sh -c apt-get update && apt-get -y install ansible" did not complete successfully: exit code: 127

The solution for error code 100 and 127 is to run below two commands to fix your time clock issue

sudo timedatectl set-ntp off
sudo timedatectl set-ntp on
date
docker-compose build


Showcase Submission for 142-rubiks-cube

Thank you OrangoMango for your contribution! A member of the Coding Train team will review it shortly.

Rubik's cube solver
OrangoMango

This is so cool! I really wanted to do something like this to finish off my video series!


[tools] Refactor update-ui-test-files.sh

This change makes it easier to copy+paste from the script when working manually, which is a common workflow.

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 88.01%. Comparing base (38e64d2) to head (9b01b29).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1743      +/-   ##
==========================================
- Coverage   88.36%   88.01%   -0.35%
==========================================
  Files          16       16
  Lines        5810     5833      +23
==========================================
  Hits         5134     5134
- Misses        676      699      +23

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Feature/update requirements with hashes

What? and Why?

What does this pull request change/fix? Why was it necessary?

Changes the requirements to work with hashes this should help prevent accidental and malicious changes. (Checked on [pre-prod])
Checklist

[x] CHANGELOG.md updated? (if required)

 Turn on PIP hashed requirements.txt (3)

Codecov Report

Merging #39 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #39   +/-   ##
=======================================
  Coverage   83.01%   83.01%
=======================================
  Files           6        6
  Lines         265      265
=======================================
  Hits          220      220
  Misses         45       45

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5c56a57...c616abc. Read the comment docs.


enhance: Add schema flags for channel watch command

Add withoutSchema & printSchema flag for show channel-watch command

/lgtm


Update to .NET 9 preview 7

Update to target .NET 9 preview 7 to address various TODOs.

@costellobot rebase

@costellobot rebase

Not enough functionality works against preview 6 to be usable, so going to merge now.
This will block new previews being published to NuGet.org until the official preview 7 release in August.


[agent] agent presence enhancements

Show resource utilization

disk free space
current network traffic up/down speeds
outbound replication bytes

capturing this in
-[ ] #5907
-[ ] #6310


Eclipse plugins don't always resolve properly via dropins

The eclipseWithPlugins mechanism uses dropins to set up an Eclipse installation with a given set of plugins. When eclipse launches there is a "reconciler" that attempts to wire these plugins up with their dependencies, but unfortunately sometimes it fails.
Take the following expression as an example:
(with eclipses; eclipseWithPlugins {
      eclipse = eclipse-rcp;
      plugins = [
        (plugins.buildEclipseUpdateSite rec {
          name = "Bndtools";
	  version = "6.0.0";
          src = fetchzip {
            stripRoot = false;
            url = "https://repo1.maven.org/maven2/org/bndtools/org.bndtools.p2/${version}/org.bndtools.p2-${version}.jar#bndtools.zip";
            sha256 = "07v4v587684232bkisw8y8p3338q0h0nmvwb2d1bhsrwg73crjsj";
          };
        })
      ];
    })

If you build this derivation and launch eclipse with the following options:
eclipse -clean -console -consoleLog -debug ~/.options
Where the .options file contains the following lines:
org.eclipse.equinox.p2.core/debug=true
org.eclipse.equinox.p2.core/reconciler=true

Then you should see the following error:
!ENTRY org.eclipse.equinox.p2.director 2 0 2021-10-19 09:46:30.050
!MESSAGE Problems resolving provisioning plan.
!SUBENTRY 1 org.eclipse.equinox.p2.director 2 0 2021-10-19 09:46:30.051
!MESSAGE Unable to satisfy dependency from bndtools.core <IP_ADDRESS>110041835 to osgi.service; (objectClass=aQute.bnd.build.Workspace).

If, however, you install the same plugins normally using p2 then everything works just fine! I believe this is a limitation of the dropins model, and so a different approach is required from the current eclipseWithPlugins.
To dive a little deeper into the example, the aQute.bnd.buildpackage is exported by the biz.aQute.bndlib plugin, which is included in the update site we configured. But eclipse already includes an earlier version of this plugin which is not compatible (5.3.0 instead of 6.0.0). I believe this is the cause of the problem. When you launch eclipse with dropins, there is a "reconciler" which attempts to wire them all up, but I suspect that it is limited in that it must allow existing plugins to take precedence over dropins. Anyone with deeper knowledge of p2 may be able to offer a more definitive diagnosis.
I am already using something which works, and imo it is simpler than eclipseWithPlugins as it leverages the p2 director to do all of the heavy lifting. There are two downsides that I can see:

There is less sharing between eclipse derivations so more disk space is taken up in general.
The system may not be backwards compatible with eclipseWithPlugins, so users may have to change their setups.

But there are also two benefits:

Correctness! Combinations of plugins which previously did not work can now work.
Higher degree of control, users can list which plugins and features they want from a p2 repo, rather than the current system which just installs everything.

I hope there is interest in this! I am more than happy to submit a PR and am semi-confident I can work the solution into a shape that is at least partially backwards compatible.
@bjornfor
@stumoss
@romildo
@rycee
@jerith666

Agreed, I'm curious to see a PR that leverages p2 more heavily!  (Though I also lack deep knowledge of p2 ... :) )

So I realize I'm asking for a fair bit of someone's time with this in review, and most people are probably checked out for Christmas still. But is there anything I can do in the meantime to help? I don't think there are any more relevant tests to run, and I don't have the confidence with Nix to feel my way forward by myself in a productive way.
Happy to answer any questions about the changes though as it's a significant rejigging. Sorry if this is just noise!

I think this is a very nice idea so many thanks for taking the time to implement it. Unfortunately I no longer use Eclipse, having finally switched Java development to Emacs, so I can't help very much with the testing/reviewing but I fully support having a more native method of installation. Using the drop-in directory as we've done is clearly not something the Eclipse upstream is very happy about 🙂


UseCollectors on command results in missing constructor

When I have the UseCollectors decorator on a command class it appears my constructor is not being initialized. All values inside are undefined and I do not see a console log I put in the constructor method.
To Reproduce
Steps to reproduce the behavior:

Have a Command class with a UseCollectors decorator.
Attempt to use the constructor inside your command class.

Expected behavior
Constructor initalizes.
Screenshots
If applicable, add screenshots to help explain your problem.
On common 5.2.3 and core 5.3.5.

Hi! I can't reproduce your problem. Make sure you add your providers to module. Also look at samples https://github.com/fjodor-rybakov/discord-nestjs/tree/master/packages/sample/interaction-collector Probably this will help you to find issue

I missed an important part in the bug description. I have updated it and included a reproducible repo.

I think the issue here is it's creating a circular dependency. Going to close the issue.


how to tell ponyc where to find pcre2?

I couldn't get make test to work for the longest time; I see that .travis.yaml installs pcre2 in /usr:
cd pcre2-10.20 && ./configure --prefix=/usr && make && sudo make install

I'm using that solution too, for now, but I usually let Ubuntu manage /usr for me, so cluttering it up like that is awkward.
If somebody installs libpcre2 in /usr/local, are they supposed to use --path=/usr/local/lib every time they use the regex package?

@dckc - I use a lot of libraries installed from source to /usr/local/lib (not just for pony), and there are more permanent ways to add that to your library lookup path.  This stackexchange post may be helpful to you: http://unix.stackexchange.com/questions/67781/use-shared-libraries-in-usr-local-lib

In general, finding libraries on Unix-like platforms is a bit of a pain (as @jemc shows), but not as hard as finding them on Windows!
Ponyc provides two mechanisms for specifying additional directories:

Using --path, -p, as @dckc points out.
Listing them in a PONYPATH environment variable.

In general, setting up your OS to Do The Right Thing is the better solution, but sometimes that's not possible for a user.


Support rotated bounding boxes in automatic annotation

My actions before raising this issue

[x] Read/searched the docs
[x] Searched past issues

We are using CVAT's automatic annotation tool Nuclio
We wrote a custom YoloV5 detector with our own model
YoloV5 supports rotated rectangle detection in the following format [x, y, w, h, theta] where theta is the rotation angle
CVAT automatic annotation also supports attributes returned from Nuclio functions, as seen in this issue 5306
After inspecting the source code, rotation is considered as attributes by CVAT too but adding this to the response payload did not help 'attributes': {'name': 'rotation', 'input_type': 'number', 'value': angle} where angle is a number, returned by the YoloV5 detector
Directly returning 'points': [x, y, w, h, theta] yields the error "Got 2.5 points"
Current Behaviour
Rotation returned from Lambda function is not used by CVAT
Possible Solution
Allow CVAT to also accept a rotation parameter from the Lambda function and make use of it in the handler, adding rotation in the attributes field of an annotation

any progress here?

Implemented in #6961


In docs, emphasize packages for new tasks

In docs, emphasize packages for new tasks. That is, on https://e3sm-project.github.io/zppy/_build/html/main/dev_guide/new_task.html, emphasize that new functionality in zppy should primarily come from stand-alone packages integrated via new zppy tasks. Currently, only the globa_time_series functionality is not stand-alone.

It may be useful to include notes (or links) on creating your own conda packages.


About JOSHI-REPLICA pytorch version

Hi,
Which code did you use in the reimplementation of Joshi et al. pytorch version? Thanks

Hi! This repo used to be this replica, but as the commits were squashed together before uploading, you can't find it on github. If you specifically need my reimplementation, I could find a local commit and send it to you. If you just need a pytorch version of the model by Joshi et al., I suggest you take a look at this repo: https://github.com/emorynlp/coref-hoi (SpanBERT + Attended Antecedent is the one).

Thank you for your quick reply!
I tried your suggested repo but I only get about avg F1 78.1 on test dataset. Even when I use Provided trained models, I cannot get the correct result. Did you get the reported result? Maybe there are some mistake of my data?

My guess is that you are probably better off asking this question there :)
I have not run the SpanBERT + AA model, but the results of EE and no-HOI models were close to the ones reported in the paper.

Ok. Thanks for answering. I will close this issue:)


Use String#freeze to allocate a single string

Upstream psych uses a constant to avoid creating so many strings.
We can use freeze in our codebase since we use ruby 2.2+
Fixes: Already initialized constant Psych::Visitors::ToRuby::SHOVEL
Fixes #5772
Before / after
$ bundle exec rails r ''

/Users/joerafaniello/Code/manageiq/gems/pending/util/extensions/miq-yaml.rb:11: warning: already initialized constant Psych::Visitors::ToRuby::SHOVEL
/Users/joerafaniello/.gem/ruby/2.2.3/gems/psych-2.0.16/lib/psych/visitors/to_ruby.rb:333: warning: previous definition of SHOVEL was here

$ bundle exec rails r ''

cc @djberg96

Does freezing a string actually help performance on an equality check? How many times is this called anyway? Not an objection, just curious.
Anyway, looks good to me.

Does freezing a string actually help performance on an equality check? How many times is this called anyway? Not an objection, just curious.

It's an allocation with probably negligible cost but it's really hard to measure and we call this alot.  With 2.2, it's hard to measure performance since the generational GC makes GC somewhat more unpredictable depending on the type of code you throw at it.
In this case, every time we parse a yaml string, each hash part... it then calls it on each child node in the hash.

@jrafanie While I'm not going to object or anything, I will say that these sorts of micro-optimizations for the benefit of GC are the sorts of things I went to dynamic languages to avoid. But, that's a topic for another time. :)
Anyway, I vote to merge.

Agreed. This is a core library that we unfortunately monkey patched and it's called tens and hundreds of thousands of times for some of our enormous yamls. Point taken though.

@matthewd Please review.  Feel free to say "I told you so"  :laughing:


Non visual play/pause button and duplicate slider-dot and some fix is needed

Conditions to reproduce :
Spicetify version : 2.11.1
Spotify version : Spotify for Windows <IP_ADDRESS>7.ga4397eb7
Spicetify Marketplace installed : Yes
Some features do not work on the css side for the latest version of Spotify version <IP_ADDRESS>7.ga4397eb7 and Spicetify version 2.11.1
CSS Hotfix needed :

Play/Pause svg button did not work (not show but functionnal)
Slider-dot is duplicate
User profil have an unexpected paddind
Made For You is not correctly Designed
Button Playlist, Artist and Album is not center
Some buttons have the old focus color (Playlists, Artists, Album, Sidebar config, Account, Profile, Private session, Settings, Log out)
Sidebar config pop-over in sidebar need redesign
Fullscreen need redesign

I tried to fix some visual problems myself on the css side as well as in the bloom.js but I didn't manage to fix the play/pause button problem.
More cordially, hoping you can update the theme. Afi

This is an issue with spicetify not working well with the latest Spotify update, which is <IP_ADDRESS>7.

Yes but it seems to me right because Specitify have made important changes... So maybe yes but Spotify have recently added new graphical elements to Spotify which could explain why Specitify is bad on certain things, so in the end I don't see what the problem is, it's not up to Specitify to fix the visual problem but you

We will pay our attention about this @afi-dev this might happening because spicetify css map doesn't match with new Spotify update or else this might our fault
We will work regarding this

Yes but it seems to me right because Specitify have made important changes... So maybe yes but Spotify have recently added new graphical elements to Spotify which could explain why Specitify is bad on certain things, so in the end I don't see what the problem is, it's not up to Specitify to fix the visual problem but the theme author

The theme is dependent on Spicetify's wrapper functions to execute the extension that's bundled with the theme, for which is broken on Spicetify 2.11.1 and Spotify 1.1.92, all of this has been patched on the Dev version of Spicetify and will be resolved as soon as we push a new release.

@afi-dev That is what @MGPlayzYT also talked about hope you will understand
@kyrie25 i really appreciate your deep explanation
Thanks a lot

Resolved via Spicetify CLI v2.12.0

@afi-dev After updating spicetify do you still having troubles or issues with bloom?

@afi-dev Dear user please tell us whether hou still having problems with bloom
We are waiting for your confirmation
We might have to close this issue as an inactive issue if we can't get your confirmation regarding this issue

I also have the play/pause buton and the fullscreen issues (persistent after updating spicetify)

@OxygenEgg Have you updated spicetify
Could you please mention the spicetify version

it's 2.12.0

also the play/pause button sometimes doesn't show up

@kyrie25 sorry to bother you dude but do you have any recommendations to fix this issue ?

I don't have much free time recently so I can't guarantee anything. Will look into it when I can.

Hi, just updated spicetify to 2.13.0 and this issue still seems to be present

@Georgetheasian if you have installed it using marketplace try installing it using powershell script in the readme.md

I installed it again using powershell but nothing changed. I will try using marketplace and seeing if that changes anything.

Marketplace also changed nothing, Im not sure if manual installation will change anything.

@Georgetheasian Can you share a screenshot with us

Marketplace also changed nothing, Im not sure if manual installation will change anything.

Complete uninstall and full reinstallation via script might also help us to determine the problem

What did u mean ?

What did u mean ?

which message you talking about ? can you quote it

Marketplace also changed nothing, Im not sure if manual installation will change anything.

Complete uninstall and full reinstallation via script might also help us to determine the problem

i meant proceeding following steps

reset spicetify and removing all the bloom theme files and going back to default spotify theme
and uninstalling the spicetify-cli and removing every file related to spicetify
running following ps script to reinstall spicetify and bloom theme
Invoke-WebRequest -UseBasicParsing "https://raw.githubusercontent.com/nimsandu/spicetify-bloom/main/install.ps1" | Invoke-Expression

note- you don't have to install spicetify-cli separately before or after running above script
afterwards can you kindly share your experience with us, so we can fix this issue at ease

Hello, I have just followed the instructions and it still seems to be an issue. Usually, the play button was there but did not function properly. Other times however, the play button is not there at all when my mouse hovers over.

@Georgetheasian Can you share a screenshot

The play button everywhere except player is not working and im working on to fix it
If its the problem can you open another issue for that

As for the instructions, I reset the spotify,  went into the Appdata and local and roaming folders to delete spicetify. After that I used powershell and just pasted the command in.

Yes sure, for me its just the playlist and daily mixes.

As for the instructions, I reset the spotify,  went into the Appdata and local and roaming folders to delete spicetify. After that I used powershell and just pasted the command in.

Nice please send a screenshot whenever possible for you

Restore spotify to original state

Delete spicetify files in appdata. Local and roaming

Use powershell to install spicetify and bloom

Restart and apply to spotify

As according to @Georgetheasian screenshot on issue #101 most of ui issues are solved by above steps
Play button issue is a separate issue
I recommend you to get trough above steps and let me know what happens

Restore spotify to original state

Delete spicetify files in appdata. Local and roaming

Use powershell to install spicetify and bloom

Restart and apply to spotify

Thanks sir
Ill even include this on readme

@afi-dev Hope this will fix the issue

No problem, its always a pleasure to help. Its an amazing theme and I want to help improve it.

@Georgetheasian ❤
Ill leave this open for a while for others to conform

Restore spotify to original state

Delete spicetify files in appdata. Local and roaming

Use powershell to install spicetify and bloom

Restart and apply to spotify

Thanks for making a guide! I'll add this to the README soon.

@MGPlayzYT ❤

@Georgetheasian @MGPlayzYT  and all the participants,
im closing this issue
i added the uninstallation guide to the readme and also i didn't forgot to credit you @Georgetheasian
thanks for everything
together we can make this stunning theme even better


add QUIC transport

QUIC looks better than TCP about performance and security.
Related Issue https://github.com/citahub/rfcs/issues/1

We are testing the performance gap between TCP and QUIC in a weak network.
see cryptape/muta-internal#147


New Yankee Workshop later seasons fails with entitlement error even with cookie file

Checklist

[x] I'm reporting a broken site support
[x] I've verified that I'm running youtube-dl version 2021.03.14
[x] I've checked that all provided URLs are alive and playable in a browser
[x] I've checked that all URLs and arguments with special characters are properly quoted or escaped
[x] I've searched the bugtracker for similar issues including closed ones

Verbose log
❯ youtube-dl -v --cookies cookies.txt -o 'The New Yankee Workshop S19E13 %(title)s.%(ext)s' https://www.thisoldhouse.com/season-19-new-yankee-workshop/21322864/s19-e13-window-bench
[debug] System config: []
[debug] User config: []
[debug] Custom config: []
[debug] Command-line args: [u'-v', u'--cookies', u'cookies.txt', u'-o', u'The New Yankee Workshop S19E13 %(title)s.%(ext)s', u'https://www.thisoldhouse.com/season-19-new-yankee-workshop/21322864/s19-e13-window-bench']
[debug] Encodings: locale UTF-8, fs utf-8, out UTF-8, pref UTF-8
[debug] youtube-dl version 2021.03.14
[debug] Python version 2.7.16 (CPython) - Darwin-20.3.0-x86_64-i386-64bit
[debug] exe versions: ffmpeg 4.3.2, ffprobe 4.3.2, rtmpdump 2.4
[debug] Proxy map: {}
[ThisOldHouse] s19-e13-window-bench: Downloading webpage
[Zype] 5f973f23c08af40001e1bf05: Downloading JSON metadata
ERROR: This video requires a purchase entitlement in order to watch.
Traceback (most recent call last):
  File "/usr/local/bin/youtube-dl/youtube_dl/extractor/zype.py", line 48, in _real_extract
    r'\.(?:js|html)\?', '.json?', url), video_id)['response']
  File "/usr/local/bin/youtube-dl/youtube_dl/extractor/common.py", line 899, in _download_json
    expected_status=expected_status)
  File "/usr/local/bin/youtube-dl/youtube_dl/extractor/common.py", line 877, in _download_json_handle
    expected_status=expected_status)
  File "/usr/local/bin/youtube-dl/youtube_dl/extractor/common.py", line 667, in _download_webpage_handle
    urlh = self._request_webpage(url_or_request, video_id, note, errnote, fatal, data=data, headers=headers, query=query, expected_status=expected_status)
  File "/usr/local/bin/youtube-dl/youtube_dl/extractor/common.py", line 652, in _request_webpage
    raise ExtractorError(errmsg, sys.exc_info()[2], cause=err)
ExtractorError: Unable to download JSON metadata: HTTP Error 403: Forbidden (caused by HTTPError()); please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; type  youtube-dl -U  to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.
Traceback (most recent call last):
  File "/usr/local/bin/youtube-dl/youtube_dl/YoutubeDL.py", line 806, in wrapper
    return func(self, *args, **kwargs)
  File "/usr/local/bin/youtube-dl/youtube_dl/YoutubeDL.py", line 827, in __extract_info
    ie_result = ie.extract(url)
  File "/usr/local/bin/youtube-dl/youtube_dl/extractor/common.py", line 534, in extract
    ie_result = self._real_extract(url)
  File "/usr/local/bin/youtube-dl/youtube_dl/extractor/zype.py", line 52, in _real_extract
    e.cause.read().decode(), video_id)['message'], expected=True)
ExtractorError: This video requires a purchase entitlement in order to watch.

Description
Most of The New Yankee Workshop videos work fine once I am logged into their site, but the last three seasons are throwing the error ERROR: This video requires a purchase entitlement in order to watch. The videos play fine in the browser, and I am using the same cookie file that works with the first 16 seasons. I have also tried logging out and back in to regenerate the login tokens, that makes no difference.
This does require a login to access, I can share my cookie file directly with the devs and I am willing to work with the devs on debugging this in any way I can.
Below is an example of a working episode in verbose mode, up to the point where it starts the download.
❯ youtube-dl -v --cookies cookies.txt https://www.thisoldhouse.com/furniture/21053902/wall-mounted-tool-chest-new-yankee-workshop
[debug] System config: []
[debug] User config: []
[debug] Custom config: []
[debug] Command-line args: [u'-v', u'--cookies', u'cookies.txt', u'https://www.thisoldhouse.com/furniture/21053902/wall-mounted-tool-chest-new-yankee-workshop']
[debug] Encodings: locale UTF-8, fs utf-8, out UTF-8, pref UTF-8
[debug] youtube-dl version 2021.03.14
[debug] Python version 2.7.16 (CPython) - Darwin-20.3.0-x86_64-i386-64bit
[debug] exe versions: ffmpeg 4.3.2, ffprobe 4.3.2, rtmpdump 2.4
[debug] Proxy map: {}
[ThisOldHouse] wall-mounted-tool-chest-new-yankee-workshop: Downloading webpage
[Zype] 5e0f6de0d7b3b70001f75c7a: Downloading JSON metadata
[Zype] 5e0f6de0d7b3b70001f75c7a: Downloading m3u8 information
[debug] Default format spec: bestvideo+bestaudio/best
[debug] Invoking downloader on u'https://content-auso3.uplynk.com/4943d473bdd64af6ad3f50923ac42740/f.m3u8'
[hlsnative] Downloading m3u8 manifest
WARNING: hlsnative has detected features it does not support, extraction will be delegated to ffmpeg
[download] Destination: Wall-mounted Tool Chest _ New Yankee Workshop-5e0f6de0d7b3b70001f75c7a.mp4
[debug] ffmpeg command line: ffmpeg -y -loglevel verbose -headers 'Accept-Charset: ISO-8859-1,utf-8;q=0.7,*;q=0.7
Accept-Language: en-us,en;q=0.5
Accept-Encoding: gzip, deflate
Accept: text/html,application/xhtml+xml,application/xml;q=0.9,*/*;q=0.8
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/74.0.3729.79 Safari/537.36
' -i 'https://content-auso3.uplynk.com/4943d473bdd64af6ad3f50923ac42740/f.m3u8' -c copy -f mp4 'file:Wall-mounted Tool Chest _ New Yankee Workshop-5e0f6de0d7b3b70001f75c7a.mp4.part'
ffmpeg version 4.3.2 Copyright (c) 2000-2021 the FFmpeg developers
  built with Apple clang version 12.0.0 (clang-1<IP_ADDRESS>)
  configuration: --prefix=/usr/local/Cellar/ffmpeg/4.3.2_1 --enable-shared --enable-pthreads --enable-version3 --enable-avresample --cc=clang --host-cflags= --host-ldflags= --enable-ffplay --enable-gnutls --enable-gpl --enable-libaom --enable-libbluray --enable-libdav1d --enable-libmp3lame --enable-libopus --enable-librav1e --enable-librubberband --enable-libsnappy --enable-libsrt --enable-libtesseract --enable-libtheora --enable-libvidstab --enable-libvorbis --enable-libvpx --enable-libwebp --enable-libx264 --enable-libx265 --enable-libxml2 --enable-libxvid --enable-lzma --enable-libfontconfig --enable-libfreetype --enable-frei0r --enable-libass --enable-libopencore-amrnb --enable-libopencore-amrwb --enable-libopenjpeg --enable-librtmp --enable-libspeex --enable-libsoxr --enable-libzmq --enable-libzimg --disable-libjack --disable-indev=jack --enable-videotoolbox
  libavutil      56. 51.100 / 56. 51.100
  libavcodec     58. 91.100 / 58. 91.100
  libavformat    58. 45.100 / 58. 45.100
  libavdevice    58. 10.100 / 58. 10.100
  libavfilter     7. 85.100 /  7. 85.100
  libavresample   4.  0.  0 /  4.  0.  0
  libswscale      5.  7.100 /  5.  7.100
  libswresample   3.  7.100 /  3.  7.100
  libpostproc    55.  7.100 / 55.  7.100
[tcp @ 0x7f83d6806000] Starting connection attempt to 2600:1f16:e2:8101:39c2:45f1:cb6f:5ce port 443
[tcp @ 0x7f83d6806000] Successfully connected to 2600:1f16:e2:8101:39c2:45f1:cb6f:5ce port 443
[hls @ 0x7f83c4808200] Skip ('#EXT-X-VERSION:5')
[hls @ 0x7f83c4808200] Skip ('#UPLYNK-SEGMENT: 4943d473bdd64af6ad3f50923ac42740,00000000,segment')
[hls @ 0x7f83c4808200] Skip ('#UPLYNK-KEY:https://content-auso3.uplynk.com/check?b=4943d473bdd64af6ad3f50923ac42740&v=4943d473bdd64af6ad3f50923ac42740&pbs=')
[hls @ 0x7f83c4808200] Skip ('#EXT-X-PROGRAM-DATE-TIME:2021-03-21T02:08:21.801000+00:00')
[hls @ 0x7f83c4808200] HLS request for url 'https://x-default-stgec.uplynk.com/ausw/slices/494/7d44d8cebd184751b43edb3c8c8bdd44/4943d473bdd64af6ad3f50923ac42740/F00000000.ts?x=0&si=0', offset 0, playlist 0
[hls @ 0x7f83c4808200] Opening 'https://content-auso3.uplynk.com/check2?b=4943d473bdd64af6ad3f50923ac42740&v=4943d473bdd64af6ad3f50923ac42740&r=f&pbs=' for reading
[tcp @ 0x7f83b4625b80] Starting connection attempt to 2600:1f16:e2:8101:39c2:45f1:cb6f:5ce port 443
[tcp @ 0x7f83b4625b80] Successfully connected to 2600:1f16:e2:8101:39c2:45f1:cb6f:5ce port 443
[AVIOContext @ 0x7f83d44dde80] Statistics: 16 bytes read, 0 seeks
[hls @ 0x7f83c4808200] Opening 'crypto+https://x-default-stgec.uplynk.com/ausw/slices/494/7d44d8cebd184751b43edb3c8c8bdd44/4943d473bdd64af6ad3f50923ac42740/F00000000.ts?x=0&si=0' for reading

FWIW, I still see the same issue with 2021.03.25.

I'm having the same issue with 2021.06.06.  I've tried using a cookie file that includes cookies for thisoldhouse and zype.  Older seasons work fine.

youtube-dl -v --cookies cookies.txt https://www.thisoldhouse.com/season-17-new-yankee-workshop/21300923/s17-e11-kitchen-island [debug] System config: [] [debug] User config: [] [debug] Custom config: [] [debug] Command-line args: [u'-v', u'--cookies', u'cookies.txt', u'https://www.thisoldhouse.com/season-17-new-yankee-workshop/21300923/s17-e11-kitchen-island'] [debug] Encodings: locale UTF-8, fs UTF-8, out UTF-8, pref UTF-8 [debug] youtube-dl version 2021.06.06 [debug] Python version 2.7.17 (CPython) - Linux-4.15.0-143-generic-x86_64-with-Ubuntu-18.04-bionic [debug] exe versions: ffmpeg 4.2.1-static, ffprobe 3.4.8, phantomjs ., rtmpdump 2.4 [debug] Proxy map: {} [ThisOldHouse] s17-e11-kitchen-island: Downloading webpage [Zype] 5f8f4e7ff5dcd800017df89c: Downloading JSON metadata ERROR: This video requires a purchase entitlement in order to watch. Traceback (most recent call last):   File "/usr/local/bin/youtube-dl/youtube_dl/extractor/zype.py", line 48, in _real_extract     r'\.(?:js|html)\?', '.json?', url), video_id)['response']   File "/usr/local/bin/youtube-dl/youtube_dl/extractor/common.py", line 899, in _download_json     expected_status=expected_status)   File "/usr/local/bin/youtube-dl/youtube_dl/extractor/common.py", line 877, in _download_json_handle     expected_status=expected_status)   File "/usr/local/bin/youtube-dl/youtube_dl/extractor/common.py", line 667, in _download_webpage_handle     urlh = self._request_webpage(url_or_request, video_id, note, errnote, fatal, data=data, headers=headers, query=query, expected_status=expected_status)   File "/usr/local/bin/youtube-dl/youtube_dl/extractor/common.py", line 652, in _request_webpage     raise ExtractorError(errmsg, sys.exc_info()[2], cause=err) ExtractorError: Unable to download JSON metadata: HTTP Error 403: Forbidden (caused by HTTPError()); please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; type  youtube-dl -U  to update. Be sure to call youtube-dl with the --verbose flag and include its complete output. Traceback (most recent call last):   File "/usr/local/bin/youtube-dl/youtube_dl/YoutubeDL.py", line 815, in wrapper     return func(self, *args, **kwargs)   File "/usr/local/bin/youtube-dl/youtube_dl/YoutubeDL.py", line 836, in __extract_info     ie_result = ie.extract(url)   File "/usr/local/bin/youtube-dl/youtube_dl/extractor/common.py", line 534, in extract     ie_result = self._real_extract(url)   File "/usr/local/bin/youtube-dl/youtube_dl/extractor/zype.py", line 52, in _real_extract     e.cause.read().decode(), video_id)['message'], expected=True) ExtractorError: This video requires a purchase entitlement in order to watch.


Mac specific hotkeys

Describe the solution you'd like
On Mac version, we need to have hotkeys that Mac users are familiar with:

[ ] Command+W to close the focused window.
[ ] Command+H to hide the app
[ ] Command+M to minimize
[ ] Command+N to open new presenter window (Orignally proposed by @bhajneet View in Slack)

Does command+m not work on macOS? It's equivalent (ctrl+m) works on desktop afaik

Not working for me v2.7.0 on Mac


Make sketch filename case match folder name

The Arduino IDE requires the sketch folder name to match the filename of the primary sketch file. On a filename case-sensitive OS like Linux, this includes matching case. This change causes the example sketch to be accessible via the Arduino IDE's File > Examples > LIBRARYNAME menu after the library is installed.
Reference:
https://github.com/arduino/Arduino/wiki/Arduino-IDE-1.5:-Library-specification#library-examples

Thanks!


[SPARK-45817]update hdfs deprecated api

What changes were proposed in this pull request?

update hdfs deprecated api
Why are the changes needed?

The isFile method in the FileSystem is Deprecated,
Does this PR introduce any user-facing change?

NO
How was this patch tested?

Was this patch authored or co-authored using generative AI tooling?

NO

dup with https://github.com/apache/spark/pull/43505

dup with #43505

sorry,I will close this pr.thanks


chore: fix formatting

Maybe it's also a good idea to have a workflow running on each PR to check wether or not the formatting is OK? 🤔
That way, we don't have these errors anymore.

The website doesn't know the prisma language so this would blow up the site, I just pushed a commit that disables the markdown linting until we can get the prisma language in.
I wonder if there's a way to opt-out of linting for a single code block w/o putting an inline comment? (don't want readers thinking they need to disable linting or something)

testing out our changing in staging real quick, then we'll deploy the new website and merge this


Few typos in readme found #115

Hi,
I've found a few typos in the Readme.md file. I prepared a really small PR to fix this.
If you consider such contribution to be to small to add me to contributors - that's fine. I've done this only for fun.
Cheers!

Coverage remained the same at 93.575% when pulling 69e85f9f8f2aba9dee7ef71e6a6d59e0231a96f8 on tomekbielaszewski:develop into 275b2856d8427507044b2c28f4927ddb9d4048c9 on rulebook-rules:develop.


GHC 8.8-compatible bounds

lens-family-th seems to just work with updated base and template-haskell bounds. Could they be relaxed and a new version or revision published, please?

Revised version <IP_ADDRESS> on hackage; thanks for the reminder.

Thanks!


Use "com" folder as an implicit namespace

Describe the bug
While using this package as a dependency it is impossible to use another one which also has com folder in its source code.
The problem occurs mostly in editable installation mode.
These sub-packages contain an __init__.py file making fail any other packages with com.company namespace :
vapi-common-client-.zip
vcenter_bindings-.zip
vmwarecloud_aws-.zip
vmwarecloud_draas-.zip
The __init__.py file :
# Required to distribute different parts of this
# package as multiple distributables
try:
    import pkg_resources
    pkg_resources.declare_namespace(__name__)
except ImportError:
    from pkgutil import extend_path
    __path__ = extend_path(__path__, __name__)

There shouldn't be any __init__.py file in the "com" folder. This latter is "universal" and can be used by many others.
Reproduction steps

pip install --upgrade git+https://github.com/vmware/vsphere-automation-sdk-python.git
pip install --editable path-to-my-other-package-containing com.compagny namespace
python -c "from com.company.mypackage.mymodule import my_function, my_class"
Traceback (most recent call last): File "<string>", line 1, in <module> ModuleNotFoundError: No module named 'com.company'

Expected behavior
from com.company.mypackage.mymodule import my_function, my_class

should be possible.
Additional context
No response

Hi @mxmrlt
This is an unfortunate case of "missing init.py trap". We are exploring the options like updating the SDK and its dependencies to use Implicit Namespace packages, removing "com" form namespace package etc. Once the approach is finalized, We will update the ticket with target dates by when the fix will be available.
Thanks
Kunal

The issue will be fixed in next SDK 8.0U3 release

8.0U3 is released. Closing the issue


Implement blocks for the game scoring.

Starting to implement: https://github.com/haroldo-ok/vcs-game-maker/tree/implement-score


Respect Rollup onwarn

I'm using Rollup in a Gulp task and have set onwarn: (message) => gutil.log('%s: %s', gutil.colors.red(rollup), message) in my Rollup config. However, rollup-plugin-babel disregards this setting and directly uses console.log.
I see that there's some code that seems to pull the passed onwarn method, but I haven't been able to get this to work.

We have some tests for passing ur own onwarn function and it seems to be working. Maybe it's something specific about ur setup with gulp? Without having a full repro case I cannot investigate this any further.


Unable to build modules which use OpenAPI

I generated a service using an OpenAPI file. When trying to build the module which has that service, I get the following error:
$ ballerina build file_server
Compiling source
	pubudu/file_server:0.1.0

Creating balos
	target/balo/file_server-2019r3-any-0.1.0.balo
error: unable to find the dependency jar from the distribution: /usr/lib/ballerina/ballerina-1.0.0-beta-SNAPSHOT/bre/lib/ballerina-openapi-1.0.0-beta-SNAPSHOT.jar

It seems in the distribution, the relevant JAR is misnamed. The file it's looking for is actually called openapi.jar in the distribution.

This is fixed with https://github.com/ballerina-platform/ballerina-lang/pull/18111/commits/02e4068b827adf0d538e9d8fcfd524dcb2e01cea
Hence closing the issue.


Update swarmprom

swarmprom has been archived by the owner for a while. This does however not mean that the stack does not work.
As we needed a working version, we adapted it in our own repos. Would you be interested in a PR to this repository that links to that code or even a PR that rips out the vendor specific things from our repository and moves the code here (we are using Hetzner in our repo)? I think this would help people a lot especially since this repository here is kind of the bible for docker swarm in production.

I would !

Just to give some details about what I am talking about:
https://github.com/neuroforgede/swarmsible/tree/master/environments/test/test-swarm/stacks/02_monitoring
This is the stack in our repo. Essentially all built on default images and all configs done via configs/secrets.

Looking back at the feature set of the original swarmprom again, I think it would proably be a good idea to mention this as an alternative to the original as we are not indending on implementing all of the features. The repo can serve as a good starting point just like swarmprom did for new users.

Our results are maintained here btw by now: https://github.com/neuroforgede/promswarm


Hidden display name is shown as tooltip with Firefox

Tested with Firefox 129.0b4
Conversation HUD 5.6.1
If you go to the tile of an NPC in Firefox whose name should remain hidden, the name still appears as a tooltip.
See picture:

Hey, thanks for reporting this bug. I will fix it and release an update in the following days, so stay tuned for that.

This issue should no longer appear in version 5.6.2. I will close the issue, but if the issue still persists or you find any other problems, feel free to reach out and I will do my best to help.


Ensure subscriptions are completed when a request is completed

Motivation:
We received a report that when using graphql-ws in conjunction with coroutine callbackFlow, awaitClose is not called. Since the awaitClose block is used to clean up resources this is a possible leak.
The cause is the Subscription which is passed over via ExecutionResult is never cancelled.
From further analysis, I found that we call ctx.cancel when a CLOSE frame is received.
https://github.com/line/armeria/blob/85bbc6533d4462d44c2d9b370dc15de21f6ef123/graphql/src/main/java/com/linecorp/armeria/server/graphql/GraphqlWebSocketSubscriber.java#L80
However, the GraphqlWebSocketSubscriber is not subscribed with the NOTIFY_CANCELLATION option.
https://github.com/line/armeria/blob/85bbc6533d4462d44c2d9b370dc15de21f6ef123/graphql/src/main/java/com/linecorp/armeria/server/graphql/GraphqlWebSocketService.java#L74
As a result, neither GraphqlWSSubProtocol#cancel is never called. This results in the upstream subscription possibly never being cancelled.
https://github.com/line/armeria/blob/85bbc6533d4462d44c2d9b370dc15de21f6ef123/graphql/src/main/java/com/linecorp/armeria/server/graphql/GraphqlWebSocketSubscriber.java#L103
Modifications:

Removed the ctx.cancel call when a CLOSE frame is received since the upstream is automatically closed from WebSocketServiceFrameDecoder

https://github.com/line/armeria/blob/85bbc6533d4462d44c2d9b370dc15de21f6ef123/core/src/main/java/com/linecorp/armeria/internal/server/websocket/WebSocketServiceFrameDecoder.java#L46

Added a GraphqlWSSubProtocol#cancel call to the onComplete callback
Added a missing break statement when a PONG is received

Result:

When a client sends a CLOSE frame, the user provided subscription is correctly closed

credit to @tobias-

Confirmed that patch solves my problem and didn't break anything obvious ;)
🙇


DNX 4.6 and Azure Web Apps

Hi,
my web application is targeting DNX 4.6 (Beta 6). It runs perfectly on IIS Express, but when I publish to Windows Azure, it crashes.

I am not able to find more error details. Can you help?
Url: http://playe.azurewebsites.net/
Repo: https://github.com/djanosik/Playe.it/
Dusan

I met this problem several times before. Usually I turn on the option "Remove additional files at destination" when publishing, and that solve the problem for me.

Thank you, but I always turn on this option. It will not help this time :/

It was caused by an incorrect connection string. The error message was not very helpful.


-betterC spec update: struct destructors now work

I believe this was fixed with https://github.com/dlang/druntime/pull/2204 and https://github.com/dlang/druntime/pull/2178, but when I made those PRs, I was just focused on remove a specific limitation and didn't intend to holistically enable struct destruction in the language.
@WalterBright What are your thoughts?  Is there anything preventing struct destruction from working in `betterC?

@JinShil nope!


When grpc-netty 1.49.x is pulled in gRPC protobuf servers will hang on onCompleted()

Environment Details

Helidon Version: 3.0.1
Helidon MP
JDK version: 17
OS: Fedora 36
Docker version (if applicable):

Problem Description
//: # Not a bug per se as Helidon gRPC integrations use 1.45.x
//: # Had a dependency that explicitly pulled in 1.49.x
//: # No exceptions were observed: but the stream observer onCompleted method hangs; onNext() is still working
Steps to reproduce
//: # Create a grpc-java server implementation(standard protobuf-type server) and allow it to be started with Helidon integrations
//: # Explicitly pull in grpc-netty 1.49.0 or 1.49.x
//: # Observe that the method onCompleted hangs
This hang does not happen with 1.48.x and below.

To support grpc 1.49.x we need to upgrade the version in Helidon. We should evaluate upgrading to 1.49.1 (https://github.com/grpc/grpc-java/releases)

@tomas-langer  @barchetta

To support grpc 1.49.x we need to upgrade the version in Helidon. We should evaluate upgrading to 1.49.1 (https://github.com/grpc/grpc-java/releases)

FYI:

when the dependency was pinned up to 1.48.1 the service continued to work.
the moment the service used 1.49.0/1.49.1 then a hang occurred in onCompleted() — the client never received any (Unary) reply
with 1.49.1 and without   Helidon gRPC integrations, i.e., starting the server manually — it works

// non-integrated - this works with 1.49.1 - onCompleted() does not hang
server = NettyServerBuilder.forAddress(new InetSocketAddress(getListeningHost(), getListeningPort()))
                .addService(new MyServiceImpl(...)).build();
        server.start();


formula_desc_cop: ensure no full stops at the end of desc

[x] Have you followed the guidelines in our Contributing document?
[x] Have you checked to ensure there aren't other open Pull Requests for the same change?
[x] Have you added an explanation of what your changes do and why you'd like us to include them?
[x] Have you written new tests for your changes? Here's an example.
[x] Have you successfully run brew tests with your changes locally?

This was a suggestion by Mike McQuaid in my homebrew-core audit
description PR. Currently, no formulae do have full stops at the
end of descriptions (based on ack "desc\b" *.rb | ack "\.$" *.rb),
but in the interests of future-proofing and consistency, we should
check for this anyway?

It turns out I got my regex wrong for this (7:30am isn't the best time to be thinking about that), so this isn't entirely speculative. Thanks to @ilovezfs for pointing that out in https://github.com/Homebrew/homebrew-core/pull/14229#discussion_r122562397. I've changed the regex to be correct now, as desc strings end in ", not just full stops.

@issyl0 Check out the failing brew tests and brew style.

@MikeMcQuaid Will do. On Tuesday when I'm back from holiday, if that's OK? Sorry that this is taking so long. I can close and reopen at a later date if you'd like?

On Tuesday when I'm back from holiday, if that's OK?

 Just had this in my queue to try and help so figured I'd jump in and offer some advice. Enjoy the holiday!)

I found a bit of downtime. 👍
I don't know why my editor inserted a weird type of space (it looked like a space, but it wasn't a space), but that's fixed now.
As for the failing test, I don't understand it. No matter how many puts I put around the test case (for expected, actual, etc), I can't see where it's going wrong. I even added ' as well as " to the regex in case it was that, but actual is still nil as it's not detecting a problem. It should be working. I wonder what silly thing I've done wrong or differently this time? It's probably something painfully obvious. Do you know, @MikeMcQuaid?

@issyl0 You don't have to add ' or " as regex_match_group method matches only with the string part.  You din't do anything wrong, except that this has to do with the ruby coding guidelines.
Convert line 77-78 into an if ..  block, and also update your regex pattern for full stop matching( remove match for '/" ) . Tests should then pass 👍

Aha! Thanks, @GauthamGoli - I must have got confused with the syntax of the test above as that used return unless yet still worked. Thanks for setting me on the right track again with regex_match_group, too - I was overthinking the quotes again!
It doesn't seem to be working again yet though, and I've made the correct changes, I think.

Sorry this is taking so long and turning complicated!

@issyl0 Never apologise for 1) trying when others don't and 2) learning publicly 👍 👏 ❤

@issyl0 Probably I told it wrong, but I meant, Line 77 - 78 needs to be in if-end block while Line 81 -83 has be return unless  guard clause, not vice versa. Otherwise Line 81 -83 may not get executed because there is a return unless statement on line 77.

@issyl0 Feel free to rebase my commit, I thought I would just resolve the conflict since I was looking at this PR anyway. 😄

@issyl0 Shout if we can help here at all but: no rush (and hope you had a good holiday)!

@JCount Thanks for that, but I did just rebase out your merge commit. :-)

@GauthamGoli Thanks! That makes a lot more sense, and now I can see the problem. I've just made that change and tests pass locally.
@MikeMcQuaid I did have a good holiday, thanks! The tests pass for this now, apart from brew style which is complaining about ifs instead of returns again: Use a guard clause instead of wrapping the code inside a conditional expression.

What happened here? The PR looks to be in pretty good shape but it was closed as stale in the end. Was it just the guard clause hiccup?

@DomT4 That was it. And then I disappeared off the face of the planet, apparently. :-)

@issyl0 should we reopen it?

@ilovezfs If you'd like. I have time to work on it again I think (this week), and it's literally one thing that's wrong. But I don't remember if I ever knew how to fix it.

@issyl0 it will also need to be made consistent with https://github.com/Homebrew/brew/pull/3349 but that shouldn't be a huge deal.

@issyl0 #3349 has now been merged. Please rebase this PR on master when you have a chance! Thanks :)

@issyl0
diff --git a/Library/Homebrew/rubocops/formula_desc_cop.rb b/Library/Homebrew/rubocops/formula_desc_cop.rb
index 4233c3a..bc36330 100644
--- a/Library/Homebrew/rubocops/formula_desc_cop.rb
+++ b/Library/Homebrew/rubocops/formula_desc_cop.rb
@@ -84,9 +84,8 @@ module RuboCop
           end

           # Check if a full stop is used at the end of a formula's desc
-          if regex_match_group(desc, /.*\.$/)
-            problem "Description shouldn't end with a full stop"
-          end
+          return unless regex_match_group(desc, /\.$/)
+          problem "Description shouldn't end with a full stop"
         end

         private
diff --git a/Library/Homebrew/test/rubocops/formula_desc_cop_spec.rb b/Library/Homebrew/test/rubocops/formula_desc_cop_spec.rb
index c82a1f2..aacb52e 100644
--- a/Library/Homebrew/test/rubocops/formula_desc_cop_spec.rb
+++ b/Library/Homebrew/test/rubocops/formula_desc_cop_spec.rb
@@ -96,9 +96,8 @@ describe RuboCop::Cop::FormulaAuditStrict::Desc do
         class Foo < Formula
           url 'http://example.com/foo-1.0.tgz'
           desc 'Description with a full stop at the end.'
-                                                       ^ Description shouldn\'t end with a full stop.
-          end
-      end
+                                                       ^ Description shouldn\'t end with a full stop
+        end
       RUBY
     end

Me ending my Rubocop error message with a full stop was unfortunate given this PR. But is that the fix for the guard clause error, the return unless? Thank you so much!

Me ending my Rubocop error message with a full stop was unfortunate given this PR.

LOL. The same thing occurred to me :)
Yes the return unless is the guard clause. Unfortunately rubocop forces a different format for the last one in the function as opposed to all of the others. :see_no_evil:

Ahhhh, that's why I had such trouble in the beginning with adding a new test and had to switch the old one around! It totally should have occurred to me. But thanks again. I just pushed the changes and fingers crossed it's green now! And now I know for next time!

Yay, the build is green. Thanks very much for your help, everyone.

Thanks again for your contribution to Homebrew, @issyl0!  You rock!

@issyl0 @MikeMcQuaid the autocorrect here doesn't actually work because the descriptions actually end in ' or " not in . so I think we need something like
-            correction.gsub!(/\.$/, "")
+            correction.gsub!(/\.(['"]?)$/, "\\1")

However that can lead to some undesirable behavior such as
-  desc "Encrypts your files, so you can safely store them in Dropbox, iCloud, ..."
+  desc "Encrypts your files, so you can safely store them in Dropbox, iCloud, "

I've replaced that description with
  desc "Encrypts your files, so you can safely store them in Dropbox, iCloud, etc."

on the assumption that we also need to white list descriptions ending in etc.

@ilovezfs That's true. I'll do a PR for whitelisting "etc", and also fix up the regex when I get a chance probably tomorrow. I also had a local branch for fixing the formulae affected by this new audit, but you beat me to it, so thanks!


Added PAYMENTREQUEST_0_NOTIFYURL to doExpressCheckoutPayment

If the PAYMENTREQUEST_0_NOTIFYURL has been set during the setExpressCheckout operation, it can be retrieved and used during the doExpressCheckoutPayment request.
From PayPal's documentation:
(Optional) Your URL for receiving Instant Payment Notification (IPN) about this transaction. If you do not specify this value in the request, the notification URL from your Merchant Profile is used, if one exists.You can specify up to 10 payments, where n is a digit between 0 and 9, inclusive; except for digital goods, which supports single payments only.
IMPORTANT:The notify URL applies only to DoExpressCheckoutPayment. This value is ignored when set in SetExpressCheckout or GetExpressCheckoutDetails.

Closing since current changes in this PR no longer reflect its original scope. Please open a new PR if needed.