[Text Field] Add Warning if no id is applied

If no id is passed to the  component in React Text Field and the user clicks the floating label, then the floating label will not float.
Text Field should throw a warning letting the developer know that id is a required field.

@moog16, just generate a random ID for the dev on component mount, and honor theirs if one is passed. IDs don't necessarily have any accessibility meaning, but they do bind a label and input element together.

Great idea! I like that...
Yes it does bind them together. I thought that relationship allows the screenreader to read the text field correctly.


build failing on OSX

Its a bit confusing what with the repathing.
Cant find it expects  "devdraw".. .. Is it in the 9fans.net/go/draw gopath ?
make build
cd /Users/apple/workspace/go/src/github.com/mjl-/duit/examples/basic/ && go build main.go && ./main
2018/04/19 10:04:54 new duit: drawfcall.New: exec: "devdraw": executable file not found in $PATH
make: *** [build] Error 1

My Make file:
# Duit is a Desktop Gui sysem for golang.

LIBPATH=github.com/mjl-/duit
LIBGOPATH=$(GOPATH)/src/$(LIBPATH)

PLAN9_LIBPATH=github.com/9fans/plan9
PLAN9_LIBGOPATH=$(GOPATH)/src/$(PLAN9_LIBPATH)

PLAN9A_LIBPATH=9fans.net/go/draw
PLAN9A_LIBGOPATH=$(GOPATH)/src/$(PLAN9A_LIBPATH)

print:
	@echo LIBPATH $(LIBPATH)
	@echo LIBGOPATH $(LIBGOPATH)

	@echo PLAN9_LIBPATH $(PLAN9_LIBPATH)
	@echo PLAN9_LIBGOPATH $(PLAN9_LIBGOPATH)

	# check plan9 path is correct
	stat $(PLAN9A_LIBGOPATH)

dep:
	# duit
	go get -u -d $(LIBPATH)
	cd $(LIBGOPATH) && dep ensure

	# plan9
	mkdir -p  $(PLAN9_LIBGOPATH)
	cd $(PLAN9_LIBGOPATH)/../ && rm -rf plan9 && git clone https://github.com/9fans/plan9port plan9

dep-clean:
	rm -rf $(LIBGOPATH)
	rm -rf $(PLAN9_LIBGOPATH)

build-all:

	cd $(LIBGOPATH) && make

build:
	cd $(LIBGOPATH)/examples/basic/ && go build main.go && ./main

did you install plan9port, and add its bin/ directory to your $PATH?
it's currently a requirement for duit.
see https://9fans.github.io/plan9port/, and follow their installation instructions.
as a side note: i've been thinking of making a smaller repo with just devdraw in it, to make it easier to onboard new user. but it would be an in-between solution, it's better to not need devdraw at all.

I've faced the same problem after install plan9port via brew.
ln -s /usr/local/opt/plan9port/libexec/bin/devdraw /usr/local/bin/devdraw fixed it

tectiv3: you are probably still missing fontsrv in that case, that's also in the plan9port bin directory.
and could you check your devdraw is using native macos drawing? not x11. i've heard before from a user with plan9port-through-brew who ended up thinking they needed an x11 server (not the case on macos). not sure what happened there, and if everyone installing through brew would say that. hopefully it was a one-off.

@mjl-
yes i installed it. See the dep task of my make file.
It should be compiled Or its a compile take package that is linked to ?

if people find this in the future: devdraw is a separate binary, that is part of plan9ports. so plan9ports needs to be installed first.


Scenario Editor Hitting rule endpoint repeatedly

Scenario editor is hitting the rule endpoint repeatedly, even after answers for those questions should be cached. It's possible that there is a sync/async thing going on, but it feels like the ultimate solution to this problem is to pre-generate the needed text and supply it as part of the reasoner's response, or as part of the ontology response, so as to ensure it happens only once, and quickly.

I discovered that the problem here was actually how slow the rule endpoint was, for no reason. So this is being kept (because I think it still may be hitting the rule endpoint more than is necessary), but it's a low priority because it's not causing any noticeable delay anymore.


Spellcheck

What's the Problem?
I wanted to rename some files and I think it would be a good feature to add spellcheck when renaming a file.
Solution/Idea
To add a spellchecking feature. Microsoft has windows spell check API  https://docs.microsoft.com/en-us/windows/win32/intl/spell-checker-api
Alternatives
You could use an alternative spell check API.
Priorities

Capability
Priority

This proposal will allow developers to accomplish W
Must

This proposal will allow end users to accomplish X
Should

This proposal will allow developers to accomplish Y
Could

This proposal will allow end users to accomplish Z
Won't

Files Version
<IP_ADDRESS>
Windows Version
Windows 10 20H2 19042.1466
Comments
No response

@AE102 the text controls have spellcheck built in, please make sure you turned it on from the settings app.

How do I access that menu?


Add info subcommand to helm plugin command

Its was a nice feature if we have info subcommand to display details for example downloaded URL, installed path etc. of the installed plugin like the following:
$ helm plugin list
NAME            VERSION         DESCRIPTION
2to3            0.2.1           migrate and cleanup Helm v2 configuration and releases in-place to Helm v3
$ helm plugin info 2to3
NAME            URL                                       PATH
2to3            https://github.com/helm/helm-2to3.git     $HOME/Library/helm/plugins/helm-2to3

If you like this idea, I am willing to do it. @hickeyma

@developer-guy What is the use case for a feature like this?

when I issued helm plugin list command it gives me only the name of the plugin but sometimes I can not remember the URL that I downloaded this plugin and maybe I want to know path simply where those plugins installed.

Personally, I like the idea.  It would also help remember if a plugin was installed from a URL or from a local clone.

Any update about the issue ?

@developer-guy As you mentioned, I suggest you post a PR implementing your suggestion, and we can review and discuss the details in there.

Ok @marckhouzam thank you 🙏 I will try to implement it soon .


Items ordering

Menu items are not ordered and use the default API ordering which is based on update date. Alphabetical order seems better in some cases.

Done for repositories (self and organizations), followers, followings and watched repositories.


[roku-driver] Added elementEnabled method

Added elementEnabled method to move the focus on the given element.
Usage:
getAppiumDriver().findElement(By.xpath("(//label[@text='Authenticate to watch'])")).isEnabled();
Adding this method with name "elementEnabled" because method should be also be available in Appium driver which is calling elementEnabled in backend calls.
Validated on Sample.zip app from Roku developers.

closed in favour of #97


WHEEL file size mismatches for ortools-7.0.6546-cp36-cp36m-manylinux1_x86_64.whl

(.venv) root@5e15c7a622d4:~/project/aaa/ortools-7.0.6546.dist-info# ls -la WHEEL
-rw-r--r-- 1 root root 109 Mar 25 14:55 WHEEL
(.venv) root@5e15c7a622d4:~/project/aaa/ortools-7.0.6546.dist-info# cat RECORD | fgrep WHEEL
ortools-7.0.6546.dist-info/WHEEL,sha256=opqqECzkr2EiaHB1f1oMkivXbaoa7jbdA_NbjmFJL1Y,112

Note that file WHEEL is of size 109, but in RECORD it's stated to be 112 bytes.

Is it an issue for you ? As i said in the release note we provide a "manylinux1" package while in reality it is a "manylinux10" so we modify the package meta using sed which would explain the size diff.
ref: https://github.com/google/or-tools/blob/39f44709bba203f5ff3bc18fab8098739f189a6d/tools/docker/build-manylinux1.sh#L186-L195

note: Most distro have a glibc >= 2.12 so it's OK IMHO...

I'm not sure I understand your comment about glibc.
My project has a bunch of dependencies and or-tools is one of them. I'm packaging a PEX ( https://github.com/pantsbuild/pex ) executable and this file is the only one rejected by PEX build. That's how to reproduce the error:
root@91e8620481ff:~# pip install pex==1.6.6
root@91e8620481ff:~# pip wheel ortools==7.0.6546
root@91e8620481ff:~# pex -o ort.pex ortools-7.0.6546-cp36-cp36m-manylinux1_x86_64.whl
Traceback (most recent call last):
  File "/usr/local/bin/pex", line 11, in <module>
    sys.exit(main())
  File "/usr/local/lib/python3.6/dist-packages/pex/bin/pex.py", line 675, in main
    pex_builder = build_pex(reqs, options, resolver_options_builder)
  File "/usr/local/lib/python3.6/dist-packages/pex/bin/pex.py", line 608, in build_pex
    pex_builder.add_distribution(resolved_dist.distribution)
  File "/usr/local/lib/python3.6/dist-packages/pex/pex_builder.py", line 336, in add_distribution
    dist_hash = self._add_dist_zip(dist.location, dist_name)
  File "/usr/local/lib/python3.6/dist-packages/pex/pex_builder.py", line 301, in _add_dist_zip
    wf.install(overrides=self._get_installer_paths(whltmp), force=True)
  File "/usr/local/lib/python3.6/dist-packages/pex/vendor/_vendored/wheel/wheel/install.py", line 289, in install
    if self.parsed_wheel_info['Root-Is-Purelib'] == 'true':
  File "/usr/local/lib/python3.6/dist-packages/pex/vendor/_vendored/wheel/wheel/install.py", line 67, in __get__
    val = self.wrapped(inst)
  File "/usr/local/lib/python3.6/dist-packages/pex/vendor/_vendored/wheel/wheel/install.py", line 259, in parsed_wheel_info
    return read_pkg_info_bytes(self.zipfile.read(self.wheelinfo_name))
  File "/usr/lib/python3.6/zipfile.py", line 1338, in read
    return fp.read()
  File "/usr/lib/python3.6/zipfile.py", line 858, in read
    buf += self._read1(self.MAX_N)
  File "/usr/lib/python3.6/zipfile.py", line 962, in _read1
    self._update_crc(data)
  File "/usr/local/lib/python3.6/dist-packages/pex/vendor/_vendored/wheel/wheel/install.py", line 493, in _update_crc
    raise BadWheelFile("Bad hash for file %r" % ef.name)
pex.vendor._vendored.wheel.wheel.install.BadWheelFile: Bad hash for file 'ortools-7.0.6546.dist-info/WHEEL'

manylinux1 defined by PEP513 require GLIBC <= 2.5 while abseil-cpp (OR-Tools dependency) require GLIBC >= 2.12 -> we can't technically provide a manylinux1 package. So we use a manylinux2010 propoosal docker containerto build a manylinux2010 package, unfortunately few distro have a pip package up to date to support the manylinux2010 platform  tag but since most distro have recent glibc (hey we are in 2019) so in practice providing a fake manylinux1 package which as been compiled against a recent glibc just work...
unfortunately pex seems to be a little bit agressive on his check, what you can do since pex seems to be a pure python lib is to hack the /usr/local/lib/python3.6/dist-packages/pex/vendor/_vendored/wheel/wheel/install.py", line 493 so pex don't care anymore of this....

Got it about libc and manylinux2010. It makes sense.
In my build script I've added an exception for or-tools and it's repacked to make the hashes match, so that's not a big issue for me. I was just wondering if you want to patch RECORD, just like you patched WHEEL and have a package with matching hash sums.

For sure, i'm not against this idea, just need to see if i can take time to do it.
I mean hack our manylinux.sh script to patch the RECORD and why not try to pex the package file to verify everything is good.

I created a PR for this: https://github.com/google/or-tools/pull/1222

Thanks.
I will let Corentin review it and merge it.
Laurent Perron | Operations Research |<EMAIL_ADDRESS>| (33) 1 42 68 53
00
Le ven. 26 avr. 2019 à 19:47, Georgi Yanchev<EMAIL_ADDRESS>a
écrit :

I created a PR for this: #1222
https://github.com/google/or-tools/pull/1222
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/google/or-tools/issues/1218#issuecomment-487143040,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ACUPL3LFQYY6JGHZFSPQL4TPSM523ANCNFSM4HIO5OPQ
.


[WIP] Tests/Fix or remove faulty tests for next assessment

Checklist

~[x] I tested the changes and all related features on the test server https://artemistest.ase.in.tum.de.~
~[x] I documented my source code using the JavaDoc / JSDoc style.~
~[x] I added integration test cases for the server (Spring) related to the features~
[x] I added integration test cases for the client (Jest) related to the features
~[x] I added screenshots/screencast of my UI changes~
~[x] I translated all the newly inserted strings~

Description

https://github.com/ls1intum/Artemis/pull/546 brought tests in, that have a misleading description and don't validate anything.
We need to either remove the file or (better) add proper tests.
Steps for Testing

Run the test in the file: src/test/javascript/spec/component/text-exercise-assessment/text-exercise-assessement.spec.ts

Screenshots

None

@fde312 @loomilahada Can you please take a look at the tests for the next assessment feature?

I can't review it because I created the PR, but it is approved from my side :+1:
Good job!


@searchable option for encrypted Elasticsearch

The @searchable directive creates an unencrypted at rest elasticsearch domain. There is no way to change the encryption after the domain is created so can we get an option to encrypt elasticsearch at rest similar to the recently added option to enable DynamoDB encryption at rest? Thanks

@gabriel-wilkes thanks for your feedback. I have added this to the backlog and we will get this prioritized

The project this was added to back in May just closed yesterday. I suppose you're tracking this internally instead? Still need this feature, thanks.

Is this issue still being worked?  We have a requirement to employ ES with a number of security features (data encryption at rest, require HTTPS) but don't know where this is being tracked or if there is a workaround to accomplish this at this point.


Document kvstore leases, update links

Update the kvstore code links to pkg.go.dev
List the objects by lease-ID with lease/GC behaviour in a nice table

Coverage increased (+0.01%) to 36.963% when pulling 8f77722dc884ba0549e6937396c550778cf3e314 on joestringer:submit/document-kvstore-leases into b5f633a6cfc3c73c223494ae424e9173b12321f4 on cilium:master.

Coverage increased (+0.01%) to 36.963% when pulling 8f77722dc884ba0549e6937396c550778cf3e314 on joestringer:submit/document-kvstore-leases into b5f633a6cfc3c73c223494ae424e9173b12321f4 on cilium:master.

Docs check passed, docs-only change. Merging.


Cache already fetched urls?

Describe the feature here
I was just using adl a bit and instead of making a range from 6 to 12 I made it from 7 to 12 and that made me wonder. Would be nice if adl had cached the urls retrieved for ep 7-12 so the next time when anime dl is called it could just fetch ep 6 url and append 7-12.
I have no idea how long is the life of usage of a fetched url. It could be one time use or forever, this is just an interesting suggestion :)

This has been fixed.


Duplicate upload fix, expose response status, and expose FormData object

hi Jonathan. thanks for this PR. can you please update README.md and bump version in package.json so I can get this published after merge. thanks.

Hello. I updated the Readme and advanced the version. I also realized I was basing my code off of 3.3.6, so I updated it to 3.3.7.

Let me know if you'd rather me cherry pick and separate these 3 issues

published to npm. thanks!

Cool, thanks!


Question

Can i use another yaml file parameter values in main values.yaml file?

Hey! I'm not sure I fully understand the question. Would you mind expanding on your thoughts a little more, perhaps with some examples?

I'm going to close this ticket due to inactivity, but please re-open if this still needs to be addressed. Thanks!


how to track eye pose?

Hi, I found the eye's pose doesn't make the model animate. Anyway to support eye pose correctly?

Ensure that there is data sending from the python to the unity.
If you are using unity chan model, check the ear_min_ratio and ear_max_ratio. The values are the window of the eye blinking animation. The ear_min_ratio sets the lower-bound of the animation (i.e. the value with eyes completely closed), while the ear_max_ration sets the upper-bound of the animation (i.e. the value with eyes completely opened).
Also, for unity-chan model, you have to drag the EYE_DEF and EL_DEF from the auto-blink script.

If you are using live-2d model, the name of the variables are the same, with the same meaning.
If you plan to use your custom model, you have to edit the live-2d script or unity-chan script to suit your model.

not eye blink, but eye ball's movement. current doesn't support right?

Yes, the unity-chan model does not support eye-ball movement.
However, other 3D models may support that. It depends on the model itself

@mmmmmm44 I am deploying a model to make eye balls can move

I see.
So you are deploying a custom 3D model which supports eye-ball movements right?
You can check out the code in Live2D model (HiyoriController.cs the function IrisMovement), copy that to your modified UnityChanController.cs script, change / add the corresponding variables to map with your custom model.
Also, if you want to play with the data loading/ saving feature, then remember to edit the UnityChanPref.cs class. Basically it's like a JSON data class. Add the corresponding variables you want to save.

@mmmmmm44 thanks, what's the pref meaning here?

The save load data function is based on the Unity tutorial about using JSON to save and load user preferences (i.e. the setup of the unity application, the detection parameters). The explanation of files applys to both live2D and unity-chan project.
The tutorial: https://youtu.be/uD7y4T4PVk0?t=346
There are three files involved in the save load preference system

SaveDataManager.cs
FileManager.cs
xxxPrefs.cs (xxx = UnityChan or Hiyori, depending on your project)

The first one contains two functions, WriteToFile(string, string) and LoadFromFile(string, string). They are for writing/ reading the json file to/ from the computer
The second one contains two functions, SaveJsonData(...) and LoadJsonData(...).  They are for saving/ loading the json data into the corresponding variables of the controller programs, such that the user does not have to set the parameters again when opens the application again.
For saving JSON file we need a class to wrap the datas to be saved/loaded, and that is what the third files contain, a class to wrap the parameters.
In both of the xxxController.cs programs, there are two functions namely PopulateSaveData(xxxPref) and LoadFromSaveData(xxxPref), which after pressing the Load/ Save button in the Setting panel, the program will load the JSON file to override the current parameters of the detection/ save the current parameters to a JSON file.
In the UISystem.cs scripts, there are two functions, SaveData() and LoadData(), which is called if you press the save/load button in the UI pannel.
The save/load feature works if you create an application from Unity (not pressing the play button)
I hope I answer your question.

@mmmmmm44 I am deploying a model to make eye balls can move

Hi, have you found any 3D models that support eyeball movement?


[Help] The all option does nothing

Really happy to find this library. I was looking for a tool which could process V8 coverage and merge it as well.
At the moment I try to replace v8 with monocart-coverage-reportss programatic API. The migration PR is here: https://github.com/tstyche/tstyche/pull/228
I managed to figure out everything except the all option. In the PR you can see list of filters. "**/main.ts": false is one of the entries, but main.ts file is not excluded, see the report: https://github.com/tstyche/tstyche/actions/runs/9481442960/job/26124230819
If filter is specified as a function, it gets called with all paths which should be there. Feels like dir is set correctly, but filter: () => false has no effect at all. Hm.. What I do wrong?

@mrazauskas the all option is design for untested files, so the all.filter should not be able to filter the files from the tested files.
please try entryFilter and sourceFilter, for example:
  entryFilter: {
    "**/main.ts": false,
    "**/node_modules/**": false,
    "**/build/**": true,
  },
  sourceFilter: {
    "**/main.ts": false,
    "**/node_modules/**": false,
    "**/source/**": true,
  },

Thanks for quick reply. That’s right! I have to use filters and it all works as expected. Now it is clear for me what the filters do.
This is not related. I was just wondering. reports: "raw" is producing JSON files similar to V8 coverage data. Are they equivalent? Sorry, I didn't dig deep, but you should know that by heart (;

Thanks! Got it.


[REQUEST] OctoPrint

Hello.
Any chance we get OctoPrint as an addon for HASS?
I use the same server for handling my 3D printer and HA and would like to have a "healthy" installation of HA.
https://hub.docker.com/r/octoprint/octoprint
Thanks!

Ohh, didn't know that. Thank you very much!


broken build_filter_conditions for keys with spaces // backtick escaping missing?

I recently ran into a crash (while my code did not change) when using collection.find() to check whether the following dict data already exists:
{'article': 'bottle-white', 'amount': 50000, 'order by date': '2023-09-20', 'delivery date': '2023-10-20', 'type': 'bottle capacity'}
I traced it down to utils.py / build_filter_conditions, which is
conditions = [f"doc.{k} == {json.dumps(v)}" for k, v in filters.items()]

but should be
conditions = [f"doc.`{k}` == {json.dumps(v)}" for k, v in filters.items()]

to allow keys with spaces, as possible in ArangoDB.
I would have bet that it worked on a previous version of python-arango, but the git seems to say otherwise.
Thanks for considering a fix.
Edit: I appears version 7.6.0 was the last one working: It does not have the build_filter_conditions function but relies on an other method that transmits the json data directly to a url, instead of composing an AQL query that now breaks.

Hey @Robert-O-Hoffmann thanks for pointing this out, will get back to you when #296 is merged & released

7.8.1 released, thank you again for catching this!


Simple INSERT and UPDATE SQL statements take hundreds of milliseconds to complete

While selecting relatively large datasets takes no time, performing any sort of insert or update operation takes hundreds of milliseconds to complete, making inserting lots of data (even just a couple hundred rows) take a long time. I've managed to combat this issue so far by inserting rows 1000 at a time, all in the same SQL statement, but I can't do the same with update statements.
The delay issue doesn't seem to be affected by database size either, as demonstrated below.
Here's some example code:
const sqlite3 = require('better-sqlite3');

const db = sqlite3('test.db');
db.prepare(`CREATE TABLE test (
    id int unique not null
)`).run();

let sum = 0;
for (i = 0; i < 30; i++) {
    const start = Date.now();
    db.prepare(`INSERT INTO test (id) VALUES (?)`).run(i);
    const duration = Date.now()-start;
    console.log(`Inserting row`, i, `took`, duration, `ms`);
    sum += duration;
}

console.log(`Average insert duration:`, Math.round(sum/30), `ms`);

The results of that test put the average row insert time at 95ms, and there doesn't seem to be any way to make those operations asynchronous. Is this a hard limit or is there a way that delay could be minimized?
Node v17.6.0
better-sqlite3 v7.5.0

The results of that test put the average row insert time at 95ms

It's not. You are also measuring the time it takes to prepare the statement every single time. See my comment here about benchmarking https://github.com/JoshuaWise/better-sqlite3/issues/780#issuecomment-1072979826

When doing any sort of benchmarking, be careful what you measure. Most benchmarks are broken from the get go because of wrong assumptions.

If you want to insert multiple rows at once, do it inside a transaction. Otherwise SQLite needs to flush every single write to disk. Also use WAL.
See https://github.com/JoshuaWise/better-sqlite3/issues/125#issuecomment-386752196 and https://github.com/JoshuaWise/better-sqlite3/issues/125#issuecomment-395532558

Also FWIW for me it's 9ms, so you are also probably using a slow disk?
This brings it down to 0ms even without wrapping all writes in a transaction
const sqlite3 = require('better-sqlite3');

const db = sqlite3('test.db');

db.pragma('journal_mode = WAL');

db.prepare(`CREATE TABLE test (
    id int unique not null
)`).run();

const stmt = db.prepare(`INSERT INTO test (id) VALUES (?)`);

let sum = 0;

for (i = 0; i < 30; i++) {
    const start = Date.now();
    stmt.run(i);
    const duration = Date.now()-start;
    console.log(`Inserting row`, i, `took`, duration, `ms`);
    sum += duration;
}

console.log(`Average insert duration:`, Math.round(sum/30), `ms`);

With transaction and WAL inserting 3000 rows takes 10ms for me
const sqlite3 = require('better-sqlite3');

const db = sqlite3('test.db');

db.pragma('journal_mode = WAL');

db.prepare(`CREATE TABLE test (
    id int unique not null
)`).run();

const stmt = db.prepare(`INSERT INTO test (id) VALUES (?)`);

let sum = 0;

console.time('insert')

db.transaction(() => {
  for (i = 0; i < 3000; i++) {
    stmt.run(i);
  }
})();

console.timeEnd('insert')

// Make sure data is actually there.
console.log(db.prepare('SELECT * FROM test').all());


Reduce the amount of times Administrator rights are required to e.g. patch

When updating PowerToys, I am prompted 3 times to enter my admin password, this should be reduced to only once.
Possibly, this is unrealistic and it is just the way W10 works, but it would mean less typey typey and more usey usey!

If you'd like to see this feature implemented, add a 👍 reaction to this post.

Closing as a duplicate of https://github.com/microsoft/PowerToys/issues/8828

Closing as a duplicate of https://github.com/microsoft/PowerToys/issues/8828


limit cmake < 3.30 to fix builds

The new cmake 3.30 release is breaking the vcpkg builds

can fix by opening PR for https://github.com/Point72/csp/tree/tkp/vcup
https://github.com/timkpaine/csp/actions/runs/9842895412


install package config for websocket

Signed-off-by: Gurdal Oruklu<EMAIL_ADDRESS>

https://jenkins.code.rdkcentral.com/job/github-triggered/386/ started

https://jenkins.code.rdkcentral.com/job/github-triggered/414/ started

https://jenkins.code.rdkcentral.com/job/github-triggered/441/ started

https://jenkins.code.rdkcentral.com/job/github-triggered/475/ started

https://jenkins.code.rdkcentral.com/job/github-triggered/484/ started


ComponentDialog::BuildDialogState throws NullReferenceException

Version
SDK 4.19
.NET 7
Describe the bug
BuildDialogState throws NullReferenceException (in line if (state.DialogStack == null)
Dialog isn't properly restored in line state = instance.State[PersistedDialogState] as DialogState;, although instance object is set properly, and State seems to be proper JObject. It looks like deserialization goes wrong. Issue appears only after upgrade to 4.19, on 4.18.1 no exception is thrown.
To Reproduce
In my bot:

Conversation is initiated
First dialogstack is built
Response to user is sent.
User sends message
On rebuilding stack exception is thrown

Expected behavior
DialogState is properly rebuilt

Hi @WueF,
Using a fresh copy of C# Sample 13 - Core Bot, I attempted to reproduce your issue by doing the following:

Change build target to .NET 7.0
Update all Bot Builder packages to 4.19.0
Update .NET packages to 7.x
Clean and Rebuild Project
Run bot and proceed through the example dialog flow

After performing these steps, I was able to go through the entire mock travel booking without encountering any NullReferenceExceptions in the ComponentDialog.
If there is more information about this issue that can help narrow down what is causing it (such as what other services are integrated, potentially incompatible packages and so on), please let me know so that I can investigate further.

I'm experiencing what I believe is a related issue in my code in OnMessageAcitivityAsync() at
await Dialog.RunAsync(turnContext, ConversationState.CreateProperty<DialogState>("DialogState"), cancellationToken);
This exception was originally thrown at this call stack:
    [External Code]
    DigitalMarx_IOT_Bot.Bots.DialogBot<T>.OnMessageActivityAsync(Microsoft.Bot.Builder.ITurnContext<Microsoft.Bot.Schema.IMessageActivity>, System.Threading.CancellationToken) in DialogBot.cs

Upgrading one Nuget package at a time, I get the exception only after upgrading Microsoft.Bot.Builder.Azure to 4.19.x. in either the .NET6 or .NET7 target frameworks.  The other packages I use don't seem to be the issue.
I'm using CosmosDb to store user and conversation state.
services.AddSingleton<IStorage>(new CosmosDbPartitionedStorage(settings.CosmosDb));
The samples default to MemoryStorage().  Could you try reproducing using CosmosDb?

Yes, I confirm above's findings. Issue exists, when using CosmosDB for state and Microsoft.Bot.Builder.Azure >= 4.19. When upgraded other packages to 4.19, but remained this one on 4.18.1, bot works fine.

Thank you both for that information. I will attempt to repro with Cosmos for state.

I ran another test with Sample 45.State Management using Cosmos.
Interestingly, I do not get a NullReferenceException. However, the sample does not function correctly, and the CosmosDB state is indeed broken. I can therefore confirm and reproduce an issue with Bot.Builder.Azure versions 4.19.x.
We will proceed to looking into a solution for this. In the meantime, please continue to use 4.18.1, as we have all confirmed that it is working.

Greetings,
I had the same issue with the blob storage provider as well.  I was able to resolve (at least for Cosmos) by passing in a custom serializer - I used the default, but had to add DialogState and PromptOptions to the AllowedTypesSerializationBinder here
In my case, the NRE was thrown on this line because the cast here was from JObject to DialogState.

@aroksa
Thank you, I will update the issue to reflect that.

https://github.com/microsoft/botbuilder-dotnet/pull/6585 should fix this issue.

Fix merged, will be live in the next patch release.

I've the same problem with MemoryStorage used in unit tests


Wildcard listener do not support priority

Do you have a link to the source where I can read into it? Need to verify it for my own personal understanding of the codebase

Here:
https://github.com/wintercms/storm/blob/develop/src/Events/Dispatcher.php#L33-L44
Specifically this line:
https://github.com/wintercms/storm/blob/develop/src/Events/Dispatcher.php#L37
Also here in when fetching the listener:
https://github.com/wintercms/storm/blob/develop/src/Events/Dispatcher.php#L152-L155
Wildcard Listeners are merged AFTER the ones sorted by priority.
Laravel has no listener priority.


Crash

Issue
happened to type a character, then crashed.
Screenshot
Maybe extension is not all ready:

But after ready still stays crashing the same,  just will restart constantly:

Code
vui example
Error
V panic: as cast: cannot cast `unknown` to `v.ast.FnType`
v hash: aebb551
0   vls                                 0x0000000105db1b7e v__checker__Checker_expr + 10078
1   vls                                 0x0000000105dbb393 v__checker__Checker_stmt + 6051
2   vls                                 0x0000000105dbf5e4 v__checker__Checker_fn_decl + 3396
3   vls                                 0x0000000105ddc82d v__checker__Checker_check + 509
4   vls                                 0x0000000105dfe2b4 vls__Vls_process_file + 5908
5   vls                                 0x0000000105e098fc vls__Vls_dispatch + 16316
6   vls                                 0x0000000105e126fe vls__Vls_start_loop + 62
7   vls                                 0x0000000105e13af7 main__run_cli + 3623
8   vls                                 0x0000000105d165bc cli__Command_parse + 2780
9   vls                                 0x0000000105e19265 main + 981
10  vls                                 0x0000000105d005c4 start + 52
[Info  - 6:16:30 PM] Connection to server got closed. Server will restart.
[Error - 6:16:30 PM] Request textDocument/codeLens failed.
Error: Connection got disposed.
	at Object.dispose (/Users/xxx/.vscode/extensions/vlanguage.vscode-vlang-0.1.8/out/extension.js:1:39411)
	at Object.dispose (/Users/xxx/.vscode/extensions/vlanguage.vscode-vlang-0.1.8/out/extension.js:1:119583)
	at w.handleConnectionClosed (/Users/xxx/.vscode/extensions/vlanguage.vscode-vlang-0.1.8/out/extension.js:1:119796)
	at w.handleConnectionClosed (/Users/xxx/.vscode/extensions/vlanguage.vscode-vlang-0.1.8/out/extension.js:1:180184)
	at t (/Users/xxx/.vscode/extensions/vlanguage.vscode-vlang-0.1.8/out/extension.js:1:117885)
	at r.invoke (/Users/xxx/.vscode/extensions/vlanguage.vscode-vlang-0.1.8/out/extension.js:1:41024)
	at o.fire (/Users/xxx/.vscode/extensions/vlanguage.vscode-vlang-0.1.8/out/extension.js:1:41785)
	at Y (/Users/xxx/.vscode/extensions/vlanguage.vscode-vlang-0.1.8/out/extension.js:1:28669)
	at r.invoke (/Users/xxx/.vscode/extensions/vlanguage.vscode-vlang-0.1.8/out/extension.js:1:41024)
	at o.fire (/Users/xxx/.vscode/extensions/vlanguage.vscode-vlang-0.1.8/out/extension.js:1:41785)
	at m.fireClose (/Users/xxx/.vscode/extensions/vlanguage.vscode-vlang-0.1.8/out/extension.js:1:49666)
	at Socket.<anonymous> (/Users/xxx/.vscode/extensions/vlanguage.vscode-vlang-0.1.8/out/extension.js:1:51251)
	at Socket.emit (events.js:327:22)
	at Pipe.<anonymous> (net.js:674:12)

@lakca Do you still experience this issue on the new version of V? I cannot replicate your situation properly

Closed. Newer versions of VLS now uses a custom analyzer instead of v.checker.


[TRG 5.07] postgresql version is not on the aligned version

Hi @adityagajbhiye9,
as discussed on the mailing list the teams decided to align the postgresql version to 15.x.
Please update/migrate your Bitnami chart version 12.x

fixed with https://github.com/eclipse-tractusx/managed-simple-data-exchanger/pull/25


fixfix in the scenario of recreating a table, the materialize…

…d view may assume that the data has not changed (#41762)
pick: https://github.com/apache/doris/pull/41762

run buildall


Decouple from invenio-records-rest and invenio-files-rest

The new invenio-records-resources and invenio-drafts-resources will totally replace invenio-rest-records and invenio-files-rest (ha naming! :smile: ). This means they replace the endpoints defined in invenio-rest-records and invenio-files-rest. Since invenio-records-permission is importing those 2, the default endpoints are brought along with it. This dependence needs to be severed so that the new endpoints are not overwritten by the old.
It also means integrating permissions with the new repos.

This is mandatory for integration right? As in we cannot integrate resources in RDM without this fixed, because records-rest & co will still be present.

If we want to get permissions integrated this month, then it would be mandatory. I don't know how we are doing permissions-wise: if we think we can achieve permissions integration then great. I can add it for now and we will see if we make it.

We won't be able to achieve this in a while since we are planning on using files-rest for the initial release. Keeping this around, but not assigning it to sprints because it is a longer-term goal.


e2e: test cloud-init setup for the SeedImage

Follow up of https://github.com/rancher/elemental-operator/issues/378
During the planning meeting, we agreed to test it manually before the next release and do the automation later.
I will see if I create another issue or not.

[ ] Manual test before next release
[ ] Automation

What I do to manually test cloud-init for the SeedImage:
I apply this file:
apiVersion: elemental.cattle.io/v1beta1
kind: SeedImage
metadata:
  name: myseedimage
  namespace: fleet-default
spec:
  baseImage: https://download.opensuse.org/repositories/isv:/Rancher:/Elemental:/Dev:/Teal53/media/iso/elemental-teal.x86_64.iso
  cloud-config:
    write_files:
    - content: |
        # My new /etc/testcloudconfig file
        # You should be able to see me :-)
      path: /etc/testcloudconfig
  registrationRef:
    apiVersion: elemental.cattle.io/v1beta1
    kind: MachineRegistration
    name: machine-registration
    namespace: fleet-default

it built my ISO and I booted a machine from it:

Today, I did a more advanced test by trying to configure a proxy using the cloud-init block:
    write_files:
    - path: /etc/sysconfig/proxy
      append: true
      content: |
        PROXY_ENABLED="yes"
        HTTP_PROXY=http://rancher.adamek.ovh:3128
        HTTPS_PROXY=http://rancher.adamek.ovh:3128
        NO_PROXY="localhost, <IP_ADDRESS>"

I followed this SUSE kb doc to configure the proxy.
When the system executed the elemental-register command, I see the communication on the proxy log:
1680180598.470    585 <IP_ADDRESS> TCP_TUNNEL/200 4432 CONNECT rancher.adamek.ovh:443 - HIER_DIRECT/<IP_ADDRESS> -

It worked with the PR above.
A new issue has been opened to write on How-to guide about using Elemental behind a proxy: https://github.com/rancher/elemental-docs/issues/71
Let's close the issue and open a new one for the automation which will probably happens after the next release.


8.12.x changes to master

Description
Merge #4899, #4897, #4896 to master
Checklist
Quality

[ ] Commit sequence makes sense and have useful messages, see ref.
[ ] New tests are added and existing tests are updated.
[ ] Self-reviewed the PR.

Maintenance

[ ] Linked an issue or added the PR to the current sprint of ouroboros-network project.
[ ] Added labels.
[ ] Updated changelog files.
[ ] The documentation has been properly updated, see ref.

LGTM! What about the tracing changes? Do you want those?

Thanks.
I will add the tracing changes in a separate PR.


Matching requirements - NFT creation without supply key should error out

Description
NFT collections (token IDs) on Hedera are required to have an initial supply of zero. The logic being that the user mints the individual serial numbers under the NFT collection with the authorization (signature) of the supply key.
Today, it is possible to create an NFT collection without a supply key, which seems like a bad design...
After checking with the Hedera team, there doesn't seem to be a valid use case for creating an NFT collection that can't have serials numbers added.
The creation of a token of type NFT without supply key should result in an error for the user.
Leemon also suggested that this should be an error.
That would be a better design that aligns with the requirements listed in the first paragraph.
Steps to reproduce
In the code below, the user doesn't find out that the tokenId doesn't have a supply key until they try to mint new NFTs. So , they're now stuck with an NFT collection that is empty forever, does not have use, and can't be deleted (if no admin key).
let nftCreateTx = await new TokenCreateTransaction()
	.setTokenName("Fall Collection")
	.setTokenSymbol("LEAF")
	.setTokenType(TokenType.NonFungibleUnique)
	.setSupplyType(TokenSupplyType.Finite)
	.setDecimals(0)
	.setInitialSupply(0)
	.setMaxSupply(5)
	.setTreasuryAccountId(client.operatorAccountId)
	// .setSupplyKey(client.operatorPublicKey)
	// .setTokenMemo("my Non-fungible token using NFT Storage.")
	.freezeWith(client);
let nftCreateSubmit = await nftCreateTx.execute(client);
let nftCreateRx = await nftCreateSubmit.getReceipt(client);
let tokenId = nftCreateRx.tokenId;

let tokenMintTx = new TokenMintTransaction()
.setTokenId(tokenId)
.setMetadata([Buffer.from(metadataURI)])
.freezeWith(client);
let tokenMintSubmit = await tokenMintTx.execute(client);
let tokenMintRx = await tokenMintSubmit.getReceipt(client);
Additional context
No response
Hedera network
mainnet
Version
v2.17
Operating system
Windows

I would think that errors should be introduced at the network level.
We've historically never errored at the client level for an operation that would succeed at the network level. If we want to do this here, there would be a high barrier to merge given the precedent.

cc: @tinker-michaelj @Neeharika-Sompalli

cc: @tinker-michaelj @Neeharika-Sompalli

Opened this issue on services

Closing this issue as it's been moved into services.


WIP disallow entering numbers with commas

Resolves #3373
Description
Change the input type of the line item quantity from number to string
Before this change, if the user added a comma to the number, it was considered invalid. The value was not sent to the backend, the save failed silently.
Now, with the string input type, the value is sent to the backend, and there is always an explicit error.
Note that this affects multiple places where the issue also occurred, for example when creating a distribution.
WIP because some barcode tests are still failing.
Type of change

Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?
<!-- Please describe the tests that you ran to verify your changes.
Added automatic tests.
Verified that this was working
Manually tested on firefox and chrome

### Screenshots

![image](https://user-images.githubusercontent.com/9966978/221177955-0282443b-0e33-4839-b479-cc409667b564.png)

Hey @fchatterji  -- I notice that you say it's WIP because some barcode tests are still failing.   If they fail sometimes, but not always, that's a known issue we have here.
If that's so, and it's the only reason you're holding it in WIP,  let's remove the WIP and see if we can get this reviewed and moved forward!

hi @cielf , no unfortunately its tests regularly failing, because of changes made here. i'll try to debug in the next few days

Hey @fchatterji -- Just checking in because it's been a couple of weeks -- how is this coming along?

Note: I rebased onto main due to an issue with the sidebar's entry expanders that I was seeing with this branch locally but not on main.

Hmm. Unfortunately this seems to break the barcode workflow (tested on Firefox on macOs with a USB barcode scanner).
I'll try to do a screen recording of the working version on main vs on this branch and upload those.

Ok.  So a bunch of barcode stuff is depending on that field input type being integer, then, it would seem.  The question then becomes do we a) back off from changing the field type to string and find a different way to trap the comma if entered,  or b) find all the places that are depending on it being integer and address them one by one.   Could be an excellent opportunity to learn more about barcodes for someone...

Seems like it would be good to truly fix it, but I'd understand if that's more than @fchatterji had time for. If they aren't sure how to continue from here, it might make sense to tweak/regroom the issue with the additional information?

To a certain extent, the barcode stuff is -- well, we don't currently have an expert on it.  So it will be a learning experience for whoever takes it on.

We have had this issue come up again in the wild,  it doesn't happen often, but when it does it is very confusing.

Closing due to inactivity.


Fixes CSS on safari and IOS [resolves #33]

Center content in overlay UI elements is misplaced on IOS and the entire overlay is invisible in safari. This pull request fixes both issues by adding cross browser compatibility code to existing CSS.

Looks good to me! Flippin' vendor prefixes 🙄


Update flow-bin to the latest version.

@koddsson do you have npm release for this package?

@koddsson do you have npm release for this package?

I think so? I'll merge this and see :P

I reverted the merge and I still have the same problem. Not sure what the deal is. Looking further 👀


Support TLS/SSL Integration

It would be nice to integrate with something like letsencrypt for generating certificate/key pairs.
I could see this being done internally via dns record verification or externally by emitting record change notifications.
There is of course a lot to consider, especially since it should be done generically to support other services like AWS Certificate Manager.  I didn't see it already mentioned on the issues though so here we are :-).

I don't quite understand how this is related to DNS? I understand that DNS is one way to verify letsencrypt certs, but should external-dns then manage certs and keys, or what is the idea? Seems quite a bit out of scope for me, unless I'm misunderstanding the issue?

You're right, I think I've got it backwards.  I was thinking that it would be nice for this service to emit records so that certificates could be generated in another system.  However now that I think about it, it's just pulling from the annotations so I can have a different service actually do the certificate generation.
Further, that other system would have to provision them in an nginx ingress or something similar anyway.
Sorry for the noise!


Doc fix: typos in README

https://github.com/mt-sre/managed-tenants-cli#available-flags
^^ has typos for what were meant to be --addons-dir and --addon-name

/assign


In phpMQTT.php line 154:Uninitialized string offset: 0

In phpMQTT.php line 154:Uninitialized string offset: 0

可能是因为服务器采用mqttv3.1.1版本，要修改代码

I am restarting this project so having a clear out of old issues (If you believe this is still valid please reopen)


A bug in save_iter (-s) flag

I am training a PGAN model on a dataset, and at scale 0 (4x4) everything was working as expected. At scale 1 (8x8), there seems to be something odd with the model training where it was not displaying any loss value but it just displays the 'changing alpha', and it looks like it's stuck and not saving the checkpoint if the -s value is 100 or greater. It would just run for a looong time and not do anything aside from displaying the alpha.
However, if I change the -s value for something less than 100 (e.g. 50), then it saves the checkpoints. But the way it's saving it is weird too - it goes 50, 150,  250, 350, etc. So it's not every 50 checkpoint.
Here's the code for reference
(pytorch_p36) ubuntu@ip-172-31-45-191:~/dcgan/pytorch_GAN_zoo$ python train.py PGAN -c config_celebaHQ.json  -n portraits -d checkpoint -s 100
Setting up a new session...
Running PGAN
size 10
9851 images found
9851 images detected
Model found at path checkpoint/portraits/portraits_s0_i48000.pt, pursuing the training
Average network found !
size (4, 4)
9851 images found
size (8, 8)
9851 images found
Changing alpha to 1.000
/home/ubuntu/anaconda3/envs/pytorch_p36/lib/python3.6/site-packages/torch/nn/functional.py:2941: UserWarning: nn.functional.upsample is deprecated. Use nn.functional.interpolate instead.
  warnings.warn("nn.functional.upsample is deprecated.


docker-py or httplib2 is incompletely cleaned up in ansible, causing errors when deploying with ansible again

After a deployment with ansible, we will run into the following issue, when we run "ansible-playbook -i environments/local prereq.yml -e mode=clean":
_pip can't proceed with requirement 'docker-py' due to a pre-existing build directory.
location: /tmp/pip_build_root/docker-py
This is likely due to a previous installation that failed.
pip is being responsible and not assuming it can delete this.
Please delete it and try again.
Storing debug log for failure in /home/vagrant/.pip/pip.log__
It seems that docker-py in uninstalled, but it does not clean up the folder /tmp/pip_build_root/docker-py for the previous installation.

This error message is for the httplib2, when we run "ansible-playbook -i environments/local prereq.yml -e mode=clean":
TASK [prereq : remove httplib2] ************************************************
Friday 10 June 2016  16:09:18 +0000 (0:00:00.426)       0:00:02.362 ***********
changed: [<IP_ADDRESS>]
fatal: [<IP_ADDRESS>]: FAILED! => {"changed": false, "cmd": "/usr/bin/pip uninstall -y httplib2", "failed": true, "msg": "stdout: Uninstalling httplib2:\nException:\nTraceback (most recent call last):\n  File "/usr/lib/python2.7/dist-packages/pip/basecommand.py", line 122, in main\n    status = self.run(options, args)\n  File "/usr/lib/python2.7/dist-packages/pip/commands/uninstall.py", line 59, in run\n    requirement_set.uninstall(auto_confirm=options.yes)\n  File "/usr/lib/python2.7/dist-packages/pip/req.py", line 1036, in uninstall\n    req.uninstall(auto_confirm=auto_confirm)\n  File "/usr/lib/python2.7/dist-packages/pip/req.py", line 599, in uninstall\n    paths_to_remove.remove(auto_confirm)\n  File "/usr/lib/python2.7/dist-packages/pip/req.py", line 1845, in remove\n    renames(path, new_path)\n  File "/usr/lib/python2.7/dist-packages/pip/util.py", line 296, in renames\n    shutil.move(old, new)\n  File "/usr/lib/python2.7/shutil.py", line 302, in move\n    copy2(src, real_dst)\n  File "/usr/lib/python2.7/shutil.py", line 130, in copy2\n    copyfile(src, dst)\n  File "/usr/lib/python2.7/shutil.py", line 82, in copyfile\n    with open(src, 'rb') as fsrc:\nIOError: [Errno 2] No such file or directory: '/usr/local/lib/python2.7/dist-packages/httplib2-0.9.2.egg-info'\n\nStoring debug log for failure in /root/.pip/pip.log\n"}
PLAY RECAP *********************************************************************
<IP_ADDRESS>                  : ok=3    changed=0    unreachable=0    failed=1
<IP_ADDRESS>                 : ok=4    changed=2    unreachable=0    failed=0
Friday 10 June 2016  16:09:18 +0000 (0:00:00.363)       0:00:02.725 ***********
setup ------------------------------------------------------------------- 1.83s
prereq : remove docker-py ----------------------------------------------- 0.43s
prereq : remove httplib2 ------------------------------------------------ 0.36s
prereq : include -------------------------------------------------------- 0.05s
prereq : include -------------------------------------------------------- 0.03s

which env did you use here? vagrant? which machine has <IP_ADDRESS> ?

@houshengbo is this issue still valid?

@lehoanganh let me verify it.


Visuals

Adding navigation bar to navigate through content

Sure. There are probably other potential solutions too. Do a little
research to see what the options are.
On Tue, Jun 9, 2020, 10:05 PM jeward414<EMAIL_ADDRESS>wrote:

@jeward414 commented on this pull request.
In portfolio/src/main/webapp/gallery.html
https://github.com/jeward414/my-portfolio/pull/9#discussion_r437834211:

@@ -0,0 +1,73 @@
+
+

Jonathan Ward's Portfolio

Like a way for it to have a central spot and be shared throughout all the
code?
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
https://github.com/jeward414/my-portfolio/pull/9#discussion_r437834211,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ACJYSORK4AXYNBM5QRHB67DRV3Z6XANCNFSM4NZ3WKDQ
.


Watch events from external database, e.g. ElasticSearch or ClickHouse

Summary
Watch Events from external database besides k8s, e.g.  ElasticSearch or ClickHouse.
Usually, k8s doesn't store events too long. In production, we  sometimes export events to external database for more use cases. There are some popular exporter to do this.  For example,
https://github.com/AliyunContainerService/kube-eventer
https://github.com/resmoio/kubernetes-event-exporter
There are at least two cases why we need this features:

For failed but not archived workflow, events sometimes expire and it is hard to track the failed reason.
For failed and archived workflow, it is even harder to track the events.

Use Cases
When would you use this?
To track the failure reason for workflows, especially for archived workflows.

Message from the maintainers:
Love this enhancement proposal? Give it a 👍. We prioritise the proposals with the most 👍.

Actually, we implement this feature on our private fork branch, but we don't think it is general approach. i wonder whether the community consider this feature.

@umialpha interested in this, put some notes on https://github.com/argoproj/argo-events/issues/1827

Why not exporting events once a workflow has completed?

Watch Events from external database besides k8s, e.g. ElasticSearch or ClickHouse.

This sounds like a feature request for Argo Events, not Workflows?

sry for confusion. I think it is a feature request of argoworkflow. The events are the kubernetes events.

Currenty, argoworkflow list-watch k8s events from k8s source. But usually k8s events lifecycle is short. In production, k8s events usually are sinked into external database like clickhouse or es.
So, is there any plan to add support to list k8s-events from other databases?

Oh you mean in the UI specifically for historical reasons. Yes currently the UI provides a list watch on k8s events for Workflows to help with debugging etc. As the k8s events you're referring to are historical for completed Workflows, it would just be a list, no need to watch in that case.
That is currently k8s native (which is ideal), and as far as I know, there is no standard historical k8s events database or standardized API. At my last job, we had historical k8s events in New Relic. That would make it very difficult to integrate as each integration would need its own implementation, connectors, dependencies, etc.
I would say that this would potentially be a good use-case for plugins a la #6943. I don't think it would be wise for Argo to support this out-of-the-box as it would be a hefty maintenance burden for a small number of users.
We do already recommend using standard k8s tooling for historical observability, such as for logs, so this would fit into that pattern. Although integrating with existing tooling may be a better paradigm than building an Argo-specific implementation like the archiveLogs feature. An archiveEvents feature could provide similar support via an Artifact Repository without too much legwork, but that would also be a not recommended hack and would not provide integration with other events stores as you describe.


Works with  DTU-Pro-S ?

Hello,
Do you know if the code also works with the Hoymiles DTU-Pro-S ? The Pro-S looks like the same as the Pro, but its for the Sub-1G frequencies used by the HMS Type from the hoymiles.
And do you know if its possible to set the output power of the hoymile inverters via modbus commands via the DTU Pro?

I don't have S version, but I'm quite sure I had a feedback that it is also working.
According to modbus spec it should be possible to turn on/off or limit output power of selected panel/port.


[azservicebus] Report proper status codes and errors from our http ATOM layer

Basically, we'll have the same bug that the old code had here: https://github.com/Azure/azure-service-bus-go/pull/258
We just need to check and return, based on the http response.

Fixed (generically) as part of #16044


Lightning consumes way too much cpu and fps drop

Godot version
3.5.2
System information
Pop!_OS 22.04 LTS x86_64 CPU: AMD Ryzen 7 4800H with Radeon Graphics (16) @ 2.900GHz      GPU: NVIDIA 01:00.0 NVIDIA Corporation TU117M
Issue description
We have been trying to find a solution for several days but it seems there is no way. If the light fills the screen, the fps drop and the cpu usage is absurdly high. We have been trying to reduce the resolution of the light image and his scale with no result, if the light fills the screen, the performance is very poor, making the game unplayable on a considerable number of computers.
Here's a screenshoot of our map, as you can see, is a normal map, there are not 5000 sprites:

Steps to reproduce
Just put some sprites and a light and see how the cpu usage increases a lot
Minimal reproduction project
Move the mouse to go where the sprites are and see how the fps drop.
Tilemap fps drop.zip

if the light fills the screen, the performance is very poor,

This is expected, as light rendering performance depends on its size but also how many sprites it touches.
If you don't need shadows, use Sprite with a CanvasItemMaterial that has its blend mode set to Add instead of Light2D. This is much faster to render.
PS: Are you running the project on the integrated GPU or the dedicated GPU? If using integrated graphics, you may be running into https://github.com/godotengine/godot/issues/23593.

I couldn't tell you offhand what is having the biggest effect. y-sort does seem to really affect it, the frame rate for me seemed around 10x higher without y-sorting. Whether that's from the y-sort directly, or because that is affecting the overlaps and making the rest of the rendering less efficient I don't know.
It might be worth experimenting with several layers of tilemap instead of a single one (so the y-sort is within a layer), to see if this helps. No idea whether it will, just a hunch.
Overlapping stuff with 2D lights is likely to kill performance in Godot 3.x due to the multi-pass approach to lighting. It is really easy to prevent any significant batching happening, which will tank performance.

Thanks for the replies.
Disabling the y-sort is not an option and I don't fully understand what you mean with experimenting with different tilemap layers. In Godot 3 there are no layers in the tilemaps.
 It increases the light of the sprites below but the normal maps don't work with this method and the map does not look very good:

Yes, I'm using the dedicated gpu:


not validate immediately after changing rules (without events in validateTrigger fired)

sample to reproduce:

and the issue affects antd Form

Please provide steps to re-produce, and expected behavior

to reproduce

render a input field with getFieldProps
rerender the component and change the rules

expected behavior
validate fields with changed rules
current behavior
does not validate after rerendering

@reallyimeric your demo is works in my browser.

@yutingzhao1991 As you can see, getFieldError did not get the error until next inputing. Is it expected?

I think it is intented behavior, validation happen only when input is changed.

@reallyimeric yes, it id expected.
@afc163 But can't get error when I try to trigger validateFields after validator changed,  Is it a bug ? ref: https://codesandbox.io/s/3yz3wk8w65 .

Try force option of validateFields: https://codesandbox.io/s/v1v61y8kv5
https://github.com/react-component/form#optionsforce-boolean


updated links to redux.js.org

The links are still pointing to rackt.github.io. I've changed them to redux.js.org.

Thanks a lot for the contribution!


SLIC

Hi! Amazing work!
When using a algorithm such as SLIC to obtain a super pixel block, it seems that the super pixel block of each picture is different. And the number of obtained super pixel blocks is not equal to the value set by the parameter "num_segments".
I can not understand it!

I believe SLIC does only guarantee equal number of superpixels in the skimage implementation if you set enforce_connectivity to False.

Yes！I just try it. They can get the equal number of superpixels when set it to false. But the number of superpixels obtained is not equal to the 'num_segments=100' (I just set the parameter).

So you have equal number of superpixels, but there are less than 100?

Yes! And when the 'num_segments=100', the equal number of superpixels is 121 more than 100.
Why the obtained superpixels is not 100?

I am not really sure, sorry. Maybe you can consult the sckit-image. authors for help

OK! Thank you very much!

Is this code a Splineconv model? Sorry, I am not familiar with this code and Splineconv.

Not really, it is my masters thesis. You can find the SplineConv implementation here.

I try use' embedded_gcnn code' to get the cifar10 dataset. And I modified it to the 'pytorch_geometric dataset' format. Then I run the mnist_graculs.py (loading the cifar10 dataset) and the result is just about 0.43. Maybe I was wrong. Could you give some advices?

This is actually quite hard to say. It could be anything from wrong data handling to bad hyperparameters.

while num_left > 0:
            min_batch = min(batch_size, num_left)
            images, labels = dataset.next_batch(min_batch, shuffle=False)
            num_left -= min_batch
            if batch_num == 0:
                label_array = labels
            else:
                label_array = np.concatenate((label_array, labels), axis=0)
            for i in xrange(labels.shape[0]):
                #data = preprocess_algorithm(images[i])
                features, node_slice, edge_index, edge_slice, pos = preprocess_algorithm(images[i])
                #edge_slice_num = edge_slice #每张图片中边的数目
                #node_slice_num = node_slice#每张图片中节点的数目
                if batch_num == 0 and i==0:
                    features_array = features
                    pos_array = pos
                    edge_index_array = edge_index
                else:
                    features_array = np.concatenate((features_array,features),axis=0)
                    pos_array = np.concatenate((pos_array, pos), axis=0)
                    edge_index_array = np.concatenate((edge_index_array, edge_index), axis=1)

                node_slice_list.append(node_slice+node_slice_list[-1])
                edge_slice_list.append(edge_slice+edge_slice_list[-1])
                #data = (features_array, node_slice_list, edge_index_array, edge_slice_list)
                j += 1
                max_index = torch.from_numpy(edge_index)[0,:].max()
                size = torch.from_numpy(pos).size(0) - 1
                assert max_index == size
                assert edge_slice == edge_index.shape[1]
            #_save(data_dir, self._names[j], data)
            _print_status(data_dir,
                          100 * (1 - num_left / dataset.num_examples))
            batch_num+=1

        _print_status(data_dir, 100)
        data = (features_array, node_slice_list, edge_index_array, edge_slice_list,pos_array)

        if isinstance(data, np.ndarray):
            data = (data, label_array)
        else:
            data = data + (label_array,)
        np.save(data_dir, data)

        #torch.save((self.data, self.slices), path)
        print()

The above is the code I modified after dataset.py. In order to be able to change the data format of pytorch-geometric, I feel that there should be no big problem.
One thing is that when I use the slic algorithm to get a super-pixel block, the number of super-pixel nodes obtained for each image is different, so I define node_slice to record the super-pixel block of each image.


github_issues.py - Fix grammar

Rather minor but the dodgy grammar in the release announcements was annoying me :-)

Thanks @jitseniesen  :-)

@ccordoba12, did not we take out this little script into a separate location (https://github.com/spyder-ide/loghub) for re-usability?
Should we just completely remove it?

@jitseniesen, I fixed the grammatical errors you reported in our Changelog in master, and also in
https://github.com/spyder-ide/loghub/blob/master/loghub.py
which is the replacement of github_issues.py and what we're using to generate Changelogs for our other projects (e.g. qtpy).


[PE-D][Tester E] View command receives numerical Names as Index

Similar to the previous bug, hypothetically speaking, if we have a person named "9" and we attempt to view her notes using the View command, "view 9" will aim to view the Person with index 9 first before viewing the Person with the name "9".
Expected output: "Viewing Note: 9" and the notes display for "9" is shown
Actual output: "The person's index provided is invalid"

Labels: type.FunctionalityBug severity.Medium
original: ulricolo7/ped#10

Planned enhancement: Restrict names to only include alphabets.


More key points of Deno presented on page

Hi,
I really like the new Deno landing page, I just wonder if it would make sense to add 1 more "key point" and modiy 1 on why to choose Deno (but I don't know how to articulate it to make it 'catchy', so I will just leave it here, maybe someone will find it useful and use it to modify landing page). I'm refering to the following part of page:

Rich standard library
There is theory that each 5 minutes new JS framework is being created. When working with Node.js it was always frustrating for me to see lot's of libs for common tasks and I was having a headache which one to choose. With Deno's standard library I find it as a great advantage that I don't need to search for some external libraries to accomplish many common tasks.
Next-gen serverless
Rename from Hussle-free deployment to Next-gen serverless. I feel like it makes sense to put more accent on serverless keyword.
What do you think? For me those 2 points are quite important and attract me to Deno a lot :)

@lambtron please handle this issue

Hey,
Actually I would suggest to change existing 3 points to following:

Rich standard library
All-in-one tooling
Next-gen serverless

No need to spend hours trying to figure out which library to choose for common tasks
Built in Typescript, linter, code formatter, ability to build a self-contained executable, test runner, IDE integration and more.
Get access to many modern serverless platforms like Deno Deploy which simplify global deployments with no server configuration

Hi @sobanieca we really appreciate your time and effort in communicating what you felt was special about Deno and how you wanted that to appear on our landing page.
we're definitely gonna take your input in account for the next time we make a change to the website.
gonna close this issue, but thanks again for helping out.


Unauthorized error when owner is not a user in gitea

Gitea version (or commit ref): 1.12.6
Git version: 2.17.1
Operating system: Ubuntu 18.04

Database:

[x] PostgreSQL
[ ] MySQL
[ ] MSSQL
[ ] SQLite

Can you reproduce the bug at https://try.gitea.io:

[ ] Yes (provide example URL)
[x] No

Log gist:

Description
Since 1.12.6, private/serv.go introduces a bug where the owner of the repository is checked to be active. However, in our case, we cannot clone or pull repositories because of this if statement and we had to downgrade to gitea 1.12.5. We get the following error for gitea 1.12.6 when using git pull on a repository that can be pulled with gitea 1.12.5:
Gitea: Unauthorized
Repository cannot be accessed, you could retry it later
fatal: Could not read from remote repository.

Please make sure you have the correct access rights
and the repository exists.

Our repositories are all part of the same organisation, so I assume that organisation is the owner. From what I understand, organisations don't have an active property, so this check will always fail.

The organisational owners do have a property is_active, but there is no means to change this from false to true


Support non-root setup

What problem are you trying to solve?
I use nix-portable since I cannot use sudo/su on my work system due to security policy. devbox tries to install on /usr/local/bin, which requires root access. It also tries to install nix as root if the nix command is not available.
Even when nix is available via nix-portable, some functionalities do not seem to work as expected, such as devbox shell --pure:
Error: could not find any nix executable in PATH. Make sure Nix is installed and in PATH, then try again

nix is available as binary in PATH, so the message is wrong, and the problem has been triggered by a different issue, probably.
What solution would you like?
I modified the setup script to target ~/.local/bin and linked nix-portable to nix. It would be nice to be able to specify a different installation path and use sudo only whenever it is needed. Giving proper documentation on how to install devbox with nix-portable would be a plus.
Alternatives you've considered
No response

devbox shell --pure fails because:

it does not look if nix is available to determine if nix is available, but it looks for known paths inside PATH
It assumes that the store PATH is under /nix/store

Any reason to not use exec.LookPath('nix') to determine the path containing nix?  Why reinvent the wheel?

@savil @frafra On my end, changing pure_shell.go to the following makes it work for devbox shell and devbox shell --pure
func findNixInPATH() (string, error) {
	path, err := exec.LookPath("nix")
	if err != nil {
		if errors.Is(err, exec.ErrDot) {
			err = nil
			workingDirectory, err := os.Getwd()
			if err != nil {
				return "", errors.New("could not find any nix executable in PATH. Make sure Nix is installed and in PATH, then try again")
			}
			path = workingDirectory
		}
		if err != nil {
			return "", errors.New("could not find any nix executable in PATH. Make sure Nix is installed and in PATH, then try again")
		}
	} else {
		path = filepath.Dir(path)
	}

	debug.Log("found nix in PATH: %s", path)
	return path, nil
}


[WIP] Expose CuPy memory pool to C/C++ space

Close #2710.
Detail to be added shortly.

I think I need some help. I want to make cupy_memory.h a header-only implementation, so that any 3rd party can just include it without worrying the linker problem. However, I am not sure how I can cleanly separate the C interface from its C++ counterpart, so that for C applications they just need a C compiler. Any advice is more than welcome!

I removed the C++ interface (cupy_device_allocator) in b68fd78 to make the implementation cleaner. This seems sufficient.

@jakirkham @kkraus14 Given your experience in RMM, I wonder if you could comment on the approach taken here, in particular the new header cupy_memory.h. 🙏
The gotcha here is that CuPy's memory pool is implemented in Cython, so to access it one has to initialize the Python interpreter (if hasn't done so already); but given the intent to interact with CuPy, I don't think this would be an issue.

@jakirkham @kkraus14 Given your experience in RMM, I wonder if you could comment on the approach taken here, in particular the new header cupy_memory.h. 🙏
The gotcha here is that CuPy's memory pool is implemented in Cython, so to access it one has to initialize the Python interpreter (if hasn't done so already); but given the intent to interact with CuPy, I don't think this would be an issue.

I would also call @harrism and @jrhemstad to attention as they have been the main contributors to RMM's C++ APIs and implementations. 😄

One thing I will point out is that RMM's allocators are all derived from a device_memory_resource base class that follows the C++17 std::pmr::memory_resource (Polymorphic Memory Resource). https://en.cppreference.com/w/cpp/memory/memory_resource
The thing to notice there is that the memory_resource::deallocate() function takes not just a pointer, but the size. All RMM deallocate functions going forward do the same. If copy's free function only takes a pointer, it will be difficult to correctly interface with RMM.

If copy's free function only takes a pointer, it will be difficult to correctly interface with RMM.

A resource is free to ignore the size parameter passed to deallocate, just like cuda_memory_resource.

@harrism @jrhemstad Thanks for quick feedbacks! Allow me to respond to a few common issues in one place.
A number of constraints apply here, IIUC, due to CuPy's Cython implementation of its memory management:

Regardless of whether functions and classes written in Cython are cdef'd or not, the manipulation must be done with a Python interpreter alive. This is Cython's limitation as it relies on Python's module import and ref count mechanisms.

CuPy has a mechanism to switch the per-thread allocator in Python (which you probably knew already as it's used in RMM 🙂), and the current allocator is respected by the C API.

So, in theory we can even do dumb things like: Ask CuPy to use RMM allocator -> Expose CuPy's pool by the C API here -> Have another Python C module (say cuDF?) to access the pool. The net effect is both cuDF and CuPy use RMM memory, but of course in practice we don't do it in this way...
To Mark's comment:

All RMM deallocate functions do the same. If copy's free function only takes a pointer, it will be difficult to correctly interface with RMM.

Yeah I noticed that from Thrust too. But I have two questions for this extra argument:

What is the expected behavior if the passed-in size does not match the actual size pointed by the device pointer/used during allocation? This behavior seems to be unspecified in C++17?
What do you mean "to interface with RMM"? Doesn't RMM already do its own memory management?

Here the exposed memory is backed by a Python object, so like Jake pointed out I can make the size accepted, but it'd just be ignored. Also, to match the signature of std::pmr::memory_resource you need another wrapper on top anyway, as the first argument here is handle.
To Jake's comment:

The requirement of having the Python Interpreter initialized would make it pretty difficult to ever use this generically in RMM.

Not sure what you meant by "use it in RMM" (see above). But if you're building a Python C/C++ module that is eventually imported in Python, this would not be a big issue. As for pure C/C++ code not involving Python --- Why would you want to interface with CuPy at all...

Since the logic is in Cython, would it be that difficult to move it to native C++?

Yes, it requires the entire cupy.cuda.memory module to be rewritten in C++ AFAIK unfortunately.

since cupy uses Thrust heavily, you may be interested to know that Thrust added some of it's own pool allocators

Oh, CuPy does not use Thrust heavily at all. Only Thrust's sorting functions are used (see the touched functions in this PR). One can even set CUPY_SETUP_ENABLE_THRUST=0 to not build cupy.cuda.thrust, and CuPy can be run if the sorting functionalities are not needed. In fact, I'd like to look into if this module can be replaced by CUB at some point.
Anyway, thanks for the pointer Jake. It'd be interesting to initialize a Thrust pool, and then warp it using CuPy's CFunctionAllocator (undocumented, why?): https://github.com/cupy/cupy/blob/ff18a56f23058a947e5ceab74995deda8514b2f1/cupy/cuda/memory.pyx#L1393

What is the expected behavior if the passed-in size does not match the actual size pointed by the device pointer/used during allocation? This behavior seems to be unspecified in C++17?

Yep, exactly. It's undefined behavior, i.e., bad, don't do it.
std::pmr::memory_resource::deallocate requires the size be exactly the same as what was passed into allocate.

(It sounds like you are in Mark and Jake's capable hands. Though please let us know if you need anything else 🙂)

Please note @jrhemstad edited one of his important comments above.
Aside: it may be helpful to have an example of why C++ PMR's require the size be passed to deallocate(). The first time I saw it, I was surprised and couldn't see why it was required -- after all  C++ delete operator and C's free() do not take a size.
The reason is because of polymorphism and composability, which is the power of PMRs. For example, I built a hybrid_memory_resource in RMM which simply has a size threshold, and pointers two upstream memory_resource objects. Any allocation / deallocation uses the specified size to select between the two upstream memory_resources. The same upstream resource must be used for both allocation and deallocation of the pointer, so the size must be known at both allocation and deallocation time. Now, the memory_resource could store a map of pointers to sizes, but that would result in duplication of that mapping in every memory_resource implementation, or require tracking it in the base class, which would be overkill for resources that don't need it (e.g. the ones that just pass through to malloc/cudaMalloc.)

Thanks all for comments!!! Before I get back to you on these, I wanna digress to a different question before I forgot: Is it possible to explicitly pass in a pre-allocated work area and a stream pointer to Thrust routines (as in CUB)? This way we could avoid writing any custom memory allocator or execution policy (I know RMM did this).

Thanks all for comments!!! Before I get back to you on these, I wanna digress to a different question before I forgot: Is it possible to explicitly pass in a pre-allocated work area and a stream pointer to Thrust routines (as in CUB)? This way we could avoid writing any custom memory allocator or execution policy (I know RMM did this).

Not like CUB, no. You could fake this by creating a Thrust allocator facade to some pre-allocated memory, but this is basically just a poor man's pool allocator.

Sorry for my delay in responding some very interesting feedbacks from Jake and Mark. Thanks @harrism for reminding me @jrhemstad's edits.

In short, there's no problem here.
This is why you shouldn't let C++ people look at Python code :)

Yeah thanks Jake! Should have been more clear in my description...😅 Also thanks to @jakirkham for making a better explanation.

For example, I built a hybrid_memory_resource in RMM which simply has a size threshold, and pointers two upstream memory_resource objects.

Thanks for the pointer, Mark! With a working example it's so much easier to understand why this is necessary. I was just digging back RMM's issue tracker, and found you folks have already discussed the very same issue here: rapidsai/rmm#302.

Not like CUB, no. You could fake this by creating a Thrust allocator facade to some pre-allocated memory and pass it as a custom exec policy, but this is basically just a poor man's pool allocator.

Yeah this is what I figured...Just wanna get an authentic verification. Thanks.
The problem with a poorman's allocator is we need to know enough the internal of the routines, so we won't be far off from the actually needed size. I think the current approach in CuPy is already the best compromise.

@pentschev are you guys interested in this feature?

@pentschev are you guys interested in this feature?

(asking internally)

I think we were primarily curious about the intended usage for this PR, cc @kkraus14 who first raised that question internally.
I'm not aware of any use cases for this currently, as in RAPIDS we primarily use RMM as the memory manager for all CUDA-related libraries, including CuPy. That's not to say that this isn't useful though. I bet if there's someone who knows of a use case for this PR in RAPIDS, that person would be @kkraus14 .

Thanks for the reply!
Would it be interesting for you guys to have some interfaces to use the RMM allocator inside cupy? or did you already solved this.

We solved this from the RMM side: https://github.com/rapidsai/rmm/blob/branch-0.14/python/rmm/rmm.py#L242-L262. It would probably be useful to document in CuPy that RMM can also be used in conjunction with it, any thoughts on this @emcastillo ?

Would it be interesting for you guys to have some interfaces to use the RMM allocator inside cupy? or did you already solved this.

As Peter said, this was solved already. I think Kenichi helped review.
Previously I think we discussed going the other way as well. Namely using CuPy's allocator within RMM ( https://github.com/cupy/cupy/issues/2635 ). This might still be interesting for comparative purposes. Though RMM has since added several different allocators. So we might already have plenty to do just figuring out how to combine RMM's allocators together in different ways.

Thanks Peter and John for your comments. Indeed, if we want a universal solution supporting throughout the Python GPU stack, RMM seems far more suitable than this. As I mentioned to Emilio offline, I didn't realize CuPy's default memory pool is tied to the Python interpreter so much when I started cleaning up the Thrust module (with hindsight it is obvious...😅)
I am sensing that even we expose our pool as is done here, it is of little use outside the CuPy space, and the team might not appreciate a controversial PR just for cleaning things up. For this reason, I'm closing this PR. Feel free to revive it if you can think of other reasons.


Transaction IDs are not preserved

The tool needs to parse the Stub class to obtain the transaction ID for each function, which will determine the original order of the methods in the AIDL file.

Closed: https://github.com/jakev/GenerateAIDL/commit/0d2cacb0d3b5e14a5b0112c198808d93cc0bf568


Replace callbacks with parameter buffer

Relates to #9
transmit and receive will no longer take a closure, but a regular byte array. In addition to that, the receive will return the RX header by default.

Tested with different DLCs. CAN FD frame is not tested.

The buffer will now always be on a lower bound 32bit alignment. data_len will never exceed the input buffer.

@richardeoin Should be about it

bors ping

bors r+


fix: Teradata SSLMODE issue fix

Solves Teradata SSLMODE support - connection timeout issue (#1011) and adds support for additional teradatasql connection options as a JSON string.
Example of usage:
data-validation connections add -c my_td Teradata --json-params "{'sslmode': 'disable', 'encryptdata': 'true'}"

PR closed/replaced due to issues with email associated with commit.


Feature/jsfmt

Addresses #375.
I'm using my fork of grunt-jsfmt. The only difference between it and the original version is that it uses the latest version of jsfmt. I'll make a PR for that project to try to fold that in.
Even with the latest version of jsfmt though, grunt-jsfmt was producing syntactically invalid javascript for mithril.js - somehow mithril's if/else statements were throwing it off. However, running jsfmt directly against mithril.js created an initial syntactically valid reformatting, and subsequent uses of grunt-jsfmt appear to work. This may be something to watch out for though.

Any updates on this?

Ah sorry, I had it merged to a separate branch.


No luck on WH-XB900N, macOS

Headset: WH-XB900N
Client version: v1.3
OS: macOS Monterey v12.3.1
Description: App doesn't work.
Specifically: Successfully connect headphones to laptop via bluetooth. Launch SonyHeadphonesClient. Click "Connect to Bluetooth Device" (had to grant permission the first time -- did so). Select headphones from list. "Enable Ambient Sound Control" is already ticked, try to move the slider and the app beachballs and does not recover :(
This is on a Macbook Air early 2015.

Can you try it on Windows or Linux? The Mac version uses a different GUI, so it might be a bit problematic.

This is probably the Monterey issue mentioned in #62

Could you try the version from #68?(https://github.com/Plutoberth/SonyHeadphonesClient/suites/6621527127/artifacts/249412614)

Closing due to inactivity


Batch Searching Doesn't Take Variables Into Account

Setting e.g. Event Time > ${dtfrom} in a search with a valid value of ${dtfrom} allows a standard search to work correctly but a batch search generates no output at all.

The search generates a processorFilter with a variable instead of a materialised value.


Touch interactions broken after zooming/panning Openseadragon on the same page

If an Openseadragon image (https://openseadragon.github.io/) is on the same page as a Leaflet map, touch interactions with the Leaflet map get broken after touching the image. This only affects touch devices.
Tested on Chrome (70.0.3538.110) on Moto G4 phone.
Example is at https://jsbin.com/sobecabati/edit?output
When the page is loaded, Leaflet map can be panned/zoomed with one/two fingers. After touching the image below the map, it becomes impossible to pan the Leaflet map with one finger, as Leaflet thinks that there are two fingers on the map. Touching the image again stops all touch interactions with the map (presumably, Leaflet thinks that there are at least three fingers on the map).
Touch interactions with the rest of the page are OK.

It's definitely related to how DomEvent.Pointer.js handles pointer events.
Turns out, events coming from openseadragon are stored in _pointers object
https://github.com/Leaflet/Leaflet/blob/37cc38648af8c5b3f54829247fc35b565bf2740e/src/dom/DomEvent.Pointer.js#L87-L90
and they're not removed from there (maybe openseadragon stops events propagation or something).
https://github.com/Leaflet/Leaflet/blob/37cc38648af8c5b3f54829247fc35b565bf2740e/src/dom/DomEvent.Pointer.js#L98-L101
Since Draggable checks event.touches length and there's a lot of touches coming from openseadragon, at some point map stops dragging
https://github.com/Leaflet/Leaflet/blob/37cc38648af8c5b3f54829247fc35b565bf2740e/src/dom/Draggable.js#L127-L138
I'm not sure which side should fix that.
Also, it's easy to break something in DomEvent.Pointer, since it fixes IE pointer events issues.
One thing that came to my mind is to check the target of pointer event before storing it in _pointers object, and store it only if it's not outside of map container.
But note, that I'm not sure that I understand properly how DomEvent.Pointer.js works.

@cherniavskii is absolutely right. Changing  _globalPointerDown to the following works without any noticeable side effects on my phone (Chrome 71.0.3578.99 on Moto G4):
function _globalPointerDown(e) {
	if (e.target._leaflet_id) {
	    _pointers[e.pointerId] = e;
	    _pointersCount++;
	}
}

However I have not tested widely; I don't know how DomEvent.Pointer.js works and so it will take someone knowledgeable to make this into a proper solution!
I think Leaflet should fix this issue as it could be caused by any other rogue script on the same page, not just openseadragon.
I think checking just the target of the pointer down event and not that of the pointer up event is the right thing to do. In other words, Leaflet should register all pointer up events even if the target is not the map, but it should register pointer down events only if they originate on the map.

The issue is not reproduced in 1.6.0
https://jsbin.com/vazegom/edit?output


Add Pour symmetry and variable input coin arity

WIP
This modifies the circuit to add symmetry to pours (a vpub_in for the balance equation) along with variable input arity to unify protects and pours.
Missing:

complete vpub_in support for PourTransaction
tests

Rebasing and producing a more complete implementation.


Shared states

Problem:

[ ] The Year change work on administrative districts but not on counties

[ ] The Linking between the administrative districts and the sidebar works only in one direction → If you click on an administrative district the right one will be selected on the sidebar, but there is no autofocus for the map


Best way to error handling

In a normal API server, we will get both success and error responses. If I have a response POJO like this:
public class FinalChannelResponse  {
    public List<InvList> inv;
    public Integer sort;
    public Integer sortOrder;
}

and a corresponding error response POJO like this :
public class ErrorResponse  {
    public String msg;
}

How do I incorporate both the responses in an API call. For example, I want to get the channel response, I call the graphQL query as :
getChannel(){
__typename
inv
sort
sortOrder
}

Now, if I get an error in the code, I should be getting the errorResponse instead. So my actual graphQL query should look like (not exactly correct):
getChannel(){
... on FinalChannelResponse{
__typename
inv
sort
sortOrder
}
... on ErrorResponse{
msg
}
}

For this to happen, I should have a common interface in my resolver response which is implemented by both FinalChannelResponse and ErrorResponse. So I created, ISearchResponse as
public interface ISearchResponse{
}

Now both my FinalChannelResponse and ErrorResponse implements this interface, and my resolver function returns ISearchResponse. I am getting the following exception when running this.
Exception in thread "main" graphql.schema.validation.InvalidSchemaException: invalid schema:
"ISearchResponse" must define one or more fields.
	at graphql.schema.GraphQLSchema$Builder.validateSchema(GraphQLSchema.java:945)
	at graphql.schema.GraphQLSchema$Builder.buildImpl(GraphQLSchema.java:939)
	at graphql.schema.GraphQLSchema$Builder.build(GraphQLSchema.java:904)
	at io.leangen.graphql.GraphQLSchemaGenerator.generateExecutable(GraphQLSchemaGenerator.java:993)
	at io.leangen.graphql.GraphQLSchemaGenerator.generate(GraphQLSchemaGenerator.java:936)
	at io.dropwizard.cli.EnvironmentCommand.run(EnvironmentCommand.java:43)
	at io.dropwizard.cli.ConfiguredCommand.run(ConfiguredCommand.java:85)
	at io.dropwizard.cli.Cli.run(Cli.java:75)
	at io.dropwizard.Application.run(Application.java:79)

@kaqqao @BaldyLocks Any solutions on this, is the approach correct?

Basically, I want to implement interfaces as mentioned in this article - https://sachee.medium.com/200-ok-error-handling-in-graphql-7ec869aec9bc


Fix output highlighting for non-classic themes

The text highlighting has some problems with themes other than the classic one. There are two overlapping texts and the result is illegible.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Hello, I have been able to replicate this issue and can confirm that your PR stops the additional text from being show when  you disable the to base64 operation. For the record I took these steps:

add To Base64 operation
add some input text
highlight some of the input text (which also highlights some output chars)
disable the operation
see the overlapping text

When trying out your change, I can see that the "old" output is not visible, but the highlight it still highlighting where the "old" characters should be. This changes when you move the cursor off the operation panel in the UI (just like how the original issue resolves itself if you unfocus)
I think this new behaviour is more dangerous than the original, because the highlight looks OK, but it is not what should be highlighted.
To approve this, I would like to see the actual highlight be updated upon pressing the 'disable' button on the To Base64 operation

The previous comments on this PR haven't been resolved and we're now 4 years on, so I'm going to close this ticket as stale.  If you have time in the future to update this, feel free to open a new PR :)


Add "HeaderStyle" to MudDataGrid

Feature request type
Enhance component
Component name
MudDataGrid
Is your feature request related to a problem?
Currently, MudDataGrid only allow for HeaderClass. When using CSS Isolation and setting the class == to what is in the CSS file (i.e.
HeaderClass="myClass"          AND in the CSS file:     .myClass{...}) Simple changes like background, color, etc. are not working. However, if I were to create a normal HTML element outside of Mud*, it of course works. Do not want to have to use

<Column HeaderStyle="background-color: red;" CellStyle="width: 200px" T="Element" Field="Number" Title="Nr" />

@ScarletKuro This one can be closed as the requirement is met.

HeaderStyle="text-align:center;" not working


Fix data race in activityBuffer

activityBuffers just need a lock when setting timestamps and performing writes.
Fixes #183.

Good catch - thank you!


LIVE-1392 Show NanoSP by default

Enable the Ledger Nano S Plus by default on the application, without requiring the SHOW_NANOSP flag like we needed up until now. This means the device should be available during onboarding and detected when plugged in (this last part was already the case).
Type
Feature
Context
https://ledgerhq.atlassian.net/browse/LIVE-1392
Parts of the app affected / Test plan

Make sure the app shows the device without needing the flag. All other functionality was tested in the specific PRs.

QA Ok pending dev review


Josh/persistent bucketer

This adds a StickyBucketer interface and hooks it up to the bucketer.
EventHandler eventHandler = OptlyEventHandler.getInstance(context);
        PersistentBucketer persistentBucketer = AndroidPersistentBucketer.newInstance(context);
        Optimizely.builder(dataFile, eventHandler)
            .withPersistentBucketer(persistentBucketer)
            .build();

I also had to bump the gradle version to get things to build on my version of IntelliJ.  I am still unable to get the project building from IntelliJ but i can I build and run tests from the command line.  All the tests are passing.  I am not sure if the issue on my machine or in the build. It was like this on the HEAD of master.

LGTM, there are mostly just minor things to address, but once those are done, merge it!

I addressed everyone's comments.  The only outstanding thing is changing the name of UserExperimentRecord#records() to something else.  I was thinking UserExperimentRecords#getAllRecords().  Also, let me know if you want to bump to 0.1.70 or go to 0.1.69.  There is no breaking API but there is new API.  @vraja2 @aliabbasrizvi @mikeng13

Looks great, just a couple of nits. Can you run "./gradlew check" locally before merging also? Thanks for addressing everything!


Windows: locate pyenv from PATH correctly

The issue
In debugging other Windows related pipenv issues, I had to patch this locally to get windows to find pyenv which was already on the PATH.  This combined with the latest fix:  https://github.com/pypa/pipenv/pull/4929 allowed pipenv to finally use pyenv-win on windows successfully to install other versions of python beyond what I had installed at a system level or manually using pyenv-win.
 Is it associated with an issue on GitHub? Please mention it.
Pipenv should be able to use the pyenv already on the path in windows, instead of printing:
$ pipenv sync
Warning: Python 3.9 was not found on your system...
Neither 'pyenv' nor 'asdf' could be found to install Python.
You can specify specific versions of Python with:
$ pipenv --python path\to\python

If your pull request makes a non-insignificant change to Pipenv, such as the user interface or intended functionality, please file a PEEP.
Non-significant change.

The fix
How does this pull request fix your problem? Did you consider any alternatives? Why is this the best solution, in your opinion?
After chatting with @oz123 he suggested trying shutil.which and that resolved the issue.  Apparently shutil should be able to do job and is more modern than distutils which is scheduled to go away in Python 3.12
The checklist

[ ] Associated issue
[ ] A news fragment in the news/ directory to describe this fix with the extension .bugfix, .feature, .behavior, .doc. .vendor. or .trivial (this will appear in the release changelog). Use semantic line breaks and name the file after the issue number or the PR #.

any chance of a new release with this in soon? We're holding off on upgrading from a very old python version until pyenv support on windows is available

@mungojam 2022.3.23 has been released!


Implement Download Now Modal for Search Card

Context
The type of Implementation: New feature (non-breaking change which adds functionality)
We need to implement the "Download Now" modal which is available on both the experiment and the search results pages' search card.
Problem or idea
(Download Now Button)

(Download Now Modal)

Based on the design, we'll build this 'Download Now' modal.
Solution or next step

Use the generic modal component (#43) to build the download now modal component
Create any sub-components or helpers as necessary

This feature branch will be created based on the PR #100 branch, thank you!


Fix incorrect occurrences count

Related to https://github.com/benignware/schedulable/issues/14 .
Fixes incorrect number of event occurrences count.
Notable changes:

acts_as_schedulable:

Occurrence date condition changed to less or equal

Many thanks for fixing this issue. This will be merged into master as soon as i get back to the project again.


fix: remove return type of promise from refresh and execute.

🔗 Linked issue

#25558
❓ Type of change

[ ] 📖 Documentation (updates to the documentation, readme or JSdoc annotations)
[x] 🐞 Bug fix (a non-breaking change that fixes an issue)
[ ] 👌 Enhancement (improving an existing functionality like performance)
[ ] ✨ New feature (a non-breaking change that adds functionality)
[ ] 🧹 Chore (updates to the build process or auxiliary tools and libraries)
[ ] ⚠ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

The TypeScript definition didn't match the implementation. The promise chain of useAsyncData does not return a value, but updates the returned Ref values.

This solves the problem that developers expect these functions to return data.

Resolves #25558
📝 Checklist

[x] I have linked an issue or discussion.
[x] I have added tests (if possible).
[x] I have updated the documentation accordingly.

@danielroe Do you think that'd be beneficial or rather result in misuse of e.g. useFetch? 🤔

@tdekoning could you also update the types in the docs?

@manniL you mean here ? They already seem to be properly typed.

Ah, perfect! Already strange that they were out of sync then! Thanks for checking 👍


chore: let Sonar to scan all modules

Sonar is not being run in the CI for the new changes in SPI. These changes try to fix that.

We are getting somewhere.  We have the report on SonarCloud for this PR even though it does not scan the sub modules. Trying to figure out what is wrong.

Not asking anyone to review this because:

I am a bit confident that it should work
There is an urgent need to merge #808 because some features rely on it. This PR is a prerequisite for it.
Even if the Sonar scan fails on master, I can fix it later because it is not a big issue.


Remove React.Children.only restriction in

React 16 introduces the ability to return multiple children from a render, so no need for this restriction any more.

This is no longer an issue in 0.7.0.


Issue 5 create flutter app

the main files edited were

app.py,
main.dart
camera_screen.dart
the other files were generated from gaining camera access and for viewing an image from storage.

Flutter app that creates a white box in the middle as guidance for the image and takes an image when button pressed. Image previewer is shown once the taken
Related Issue

Resolve #5

lint check is failing, reformat app.py


export ‘ɵɵdefineInjectable’ was not found in ‘@angular/core’

#212  I'm submitting a...

[X] Regression (a behavior that used to work and stopped working in a new release)
[ ] Bug report
[ ] Performance issue
[ ] Feature request
[ ] Documentation issue or request
[ ] Support request
[ ] Other... Please describe:

Current behavior
WARNING in<EMAIL_ADDRESS>165:59–77
export ‘ɵɵdefineInjectable’ was not found in ‘@angular/core’
Uncaught TypeError: Object(...) is not a function
at<EMAIL_ADDRESS>(datorama-akita-ng-entity-service.js:65)
at webpack_require (bootstrap:78)
at Module../src/app/app.module.ts (app.component.ts:20)
at webpack_require (bootstrap:78)
at Module../src/main.ts (main.ts:1)
at webpack_require (bootstrap:78)
at Object.0 (main.js:33253)
at webpack_require (bootstrap:78)
at checkDeferredModules (bootstrap:45)
at Array.webpackJsonpCallback [as push] (bootstrap:32)
Expected behavior
Akita should initialize without any issues
Minimal reproduction of the problem with instructions
Angular 7.1.3.
ng add @datorama/akita
npm run start
What is the motivation / use case for changing the behavior?
I want akita to work with Angular 7
Environment

Angular version: 7.1.3

Browser:
- Chrome (desktop)

For Tooling issues:
- Node version: 10.16.0
- Platform: Mac

Others:
This an issue resolve: https://github.com/angular/angular/issues/30413#issuecomment-491531239
What version of akita is compatible with angular 7.1.3? I currently don’t plan to upgrade to Angular 8.

Are you using akita-ng-entity-service?

I didn't have a possibility yet) Can't launch an app with Akita. I might not need it, but I wanted to try. I'm preparing a state management POC.

Please try with<EMAIL_ADDRESS>