tests on windows

A number of the unit tests fail on windows, usually due to using external commands e.g. mkdir.

Can you give more details? The tests seem to be fine on Windows.

I commented some out while looking at the code, there are others but here is an example
--- FAIL: TestStartup (0.25s)
    startupshutdown_test.go:50: Test 0 recieved an error of:
        exec: "mkdir": executable file not found in %PATH%
    startupshutdown_test.go:54: Test 0 recieved an error of:
        remove C:\Users\me\AppData\Local\Temp\temp_dir_for_testing_startupshutdown.go: The system cannot find the file specified.
    startupshutdown_test.go:50: Test 1 recieved an error of:
        exec: "mkdir": executable file not found in %PATH%

How does your Windows not have mkdir? https://technet.microsoft.com/en-us/library/bb490930.aspx
Sounds like your PATH might be missing something...

Yes a good point, I do of course have mkdir it's not a path program though I think it's built into cmd.exe . I wonder if this machine 64bit has a 32bit go installation on it that might be causing this.

I have 64bit go installed. This machine has hardly anything installed (no gcc, mingw or cygwin etc). Looking at
http://stackoverflow.com/questions/20437336/how-to-execute-system-command-in-golang-with-unknown-arguments I see more evidence that exec does not run shell built in commands.
If I add a mingw built gnu mkdir.exe to my path the test I mentioned above works, that's a good enough solution for me.

I don't have Windows, but it does work on my Windows VM. Do you have git installed? I think installing git might add some of those commands to the PATH.
Anyway, thanks for the report! Maybe some day we can find a more universal way to do these tests.


Determine how to do aggrigate / custom computed fields in gql with ef core

E.g. this? https://github.com/sillsdev/languageforge-lexbox/pull/152/files#diff-60417884763417174bbb024bd554bf18cabe389b8985fdb918552806f81177d8


Docker can't create a container

Expected behavior
Creation of a container
Actual behavior
"We're sorry. There seems to be an error
context canceled"
Information about the Issue
Running Docker <IP_ADDRESS> (37877)
Steps to reproduce the behavior

Launch Kitematic
Create a container

I solved the issue by downloading Docker Toolbox


Submodule branch

All the generalization works that @maxsibilla made

We can't really use Travis here due to the breaking changes/refactoring.


Documentation of epinio's APIs (input, output)

Describe the bug
Ref https://github.com/epinio/epinio/issues/1896 ... Criteria ...

The project MUST provide reference documentation that describes the external interface (both input and output) of the software produced by the project

Collect a list of epinio's inputs and outputs (APIs also) here, and check where we document them.
For those not documented create further tickets to track.

[x] CLI commands - https://docs.epinio.io/references/commands/cli/epinio
[x] (Custom) App charts - https://docs.epinio.io/next/references/customization/appcharts
[x] (Custom) builder - https://docs.epinio.io/next/references/customization/staging
[x] Supported applications - https://docs.epinio.io/next/references/supported_applications
[x] (Custom) services - https://docs.epinio.io/next/references/customization/catalog
[x] External s3 (compatible) - https://docs.epinio.io/next/references/customization/sources
[x] External container registry - https://docs.epinio.io/next/references/customization/images
[x] Routing secrets - https://docs.epinio.io/next/references/customization/routing_secrets
[x] Server API - https://docs.epinio.io/next/references/api
[x] Users - https://docs.epinio.io/next/references/authorization
[x] OIDC - https://docs.epinio.io/next/references/authentication_oidc
[ ] UI ?
[ ] What else ...

Updated project as criteria met.


How to use / enable wireguard host peer?

Hi,
My netbird self-hosted server is already part of my destination network, which I want my Netbird peers to be able to reach (I have a K8s cluster, and Netbird is already part of it. I want the clients to be able to reach the K8s network).
At the moment, the only solution to get it working is to create a "redundant" peer that is also part of the K8s network and route to it. It is somehow possible to enable wireguard-server peer interface in Netbird to be able to reach the network behind it without any additional Linux peer?

Hi @aciidic, I also got it working in a similar way. I just wanted to avoid creating an additional client which is redundant IMO, because WireGuard offers a host peer out of the box. Anyway, apparently it works only this way at the moment.

Well, to keep the backlog clean. I will close this as this is not an issue, but kind of minor limitation that can solved by a workaround.


FFI-related question

With the ffi-struct example changed like this PR shows, I'd expect the output to be
10
15
5
5
x is 5

but it actually is
x is 5
10
15
5
5

What am I missing?

D'oh! This is just a matter of outputting the lines, since the content, x is 5, indicates that it was executed after the modify.


Land enhancement

This PR fixes two problems with Land. See #9691 & #9768
Problems

Land can cause vehicle to flip upon land if the command was issued while the vehicle was moving quickly.

Land descent velocity was only MPC_LAND_SPEED.

Solutions

Vehicle will return to LAT/LON location where the Land command was issued and begin descending from there. In the future, I want to implement a BRAKE setpoint type, but this is a good fix until that work is done.

The vehicle now respects MPC_LAND_ALT1 and MPC_LAND_ALT2 to control descent velocities.

I have simulation tested and physically flight tested this on our quadcopter and have seen no problems. I would love if someone could please test this with a fixed wing aircraft to verify.
Please let me know if you have any questions, thanks!
Jake

@Stifael Behavior in mc_pos_control_main.cpp remains the same if there is no local position.
		if (abs(_local_pos.z) > _slow_land_alt1.get()) {
			_vel_sp(2) = _vel_max_down.get();

		} else if (abs(_local_pos.z) > _slow_land_alt2.get()) {
			float velocity_scaling = (abs(_local_pos.z) - _slow_land_alt2.get()) / (_slow_land_alt1.get() - _slow_land_alt2.get());
			_vel_sp(2) = _land_speed.get() + velocity_scaling * (_vel_max_down.get() - _land_speed.get());

		} else {
			_vel_sp(2) = _land_speed.get();
		}

Does a failsafe event override navigator modes?

Actually, the way the code is currently it seems like if local position was lost it would never make it into the first if statement for land
	if (_pos_sp_triplet.current.valid
	    && _pos_sp_triplet.current.type == position_setpoint_s::SETPOINT_TYPE_LAND) {

@dagar

@dakejahl with your changes, the first stages are not of type SETPOINT_TYPE_LAND, they are of type SETPOINT_TYPE_POSITION (https://github.com/PX4/Firmware/pull/9772/files#diff-7a824e3d1e9a5420071c8c9bbe27b8e7R643).
Have you tried in SITL to do fast forward flight and then turn of GPS?

a break would also be helpful for this "feature" request: https://github.com/PX4/Firmware/issues/9741#issuecomment-399912835

Please see #9804


Improved syntax highlighting for certain themes?

What happened?
Compared to the screenshots in the repo, my syntax highlighting differs just a lil bit. I'd like to know how I can maybe change this: doom-material has certain niceties to the syntax highlighting compared to other themes I tried, like doom-snazzy or doom-monokai-pro. I would like to add these niceties to other themes too, but how do I do that?
Material has type="text" highlighted nicely:

Molokai hasn't:

What did you expect to happen?
Nothing! But I would like to have the same kind of highlighting of JSX attributes like material, the screenshots of snazzy for example even show the difference too.
Steps to reproduce
1.Choose desired theme
2. ...
3. ...
System Information

Emacs version: 28.0.50 (nativecomp)
Emacs Distro: Doom Emacs
Operating System: Ubuntu
Installed commit of doom-themes: 3761dfce75144e49789b6576e187acd82e2731ee

Hi! Question; are you using the jsx-mode package?

Hi! Question; are you using the jsx-mode package?

I am, atleast I activated it by adding this:
(add-to-list 'auto-mode-alist '("\\.js\\'" . rjsx-mode))
to my config.el

I am, atleast I activated it by adding this:
(add-to-list 'auto-mode-alist '("\\.js\\'" . rjsx-mode))
to my config.el

No problem man! We've all been there. I'd only need to tweak the rjsx-mode faces to make them look better.

No problem man! We've all been there. I'd only need to tweak the rjsx-mode faces to make them look better.

Looking at the screenshots: https://github.com/hlissner/emacs-doom-themes/tree/screenshots aren't they using rjsx-mode already?

Looking at the screenshots: https://github.com/hlissner/emacs-doom-themes/tree/screenshots aren't they using rjsx-mode already?

@ema2159 sorry for the ping, got any tips on how I can help?

@zetashift I'm a noob at this (too?), however, if you are interested in the topic in general this might be of interest: http://ergoemacs.org/emacs/elisp_syntax_coloring.html and the following posts.

@zetashift sorry for the delay! Check the last tweaks I made! If you feel they are sufficient please close the issue but don't hesitate to tell me anything else you think it's worth addressing.

@ema2159 hey thanks a lot!! How do I upgrade emacs-doom-themes? I tried doom upgrade but the syntax highlighting didn't change.
Am using the doom-one theme.

Probably you'll just have to wait for the Melpa update so give it a couple of hours!
Yeah, those variables change the respective rjsx faces, but they do it inside Doom themes macro. If you wanted to change those faces inside your config you'd need to use the (set-face-attribute... function.
What would be the purpose of the PR you're mentioning?

Probably you'll just have to wait for the Melpa update so give it a couple of hours!
Yeah, those variables change the respective rjsx faces, but they do it inside Doom themes macro. If you wanted to change those faces inside your config you'd need to use the (set-face-attribute... function.
What would be the purpose of the PR you're mentioning?

Oh, I think I misunderstoond sorry! I thought your changes would only apply to the faces of doom-one. So the PR would change it for themes other than doom-one.
Also I went to do some digging on my own and saw that the themes Discord channel uses custom-set-faces!.

The faces work fine and I learned a thing or two about emacs themes! Thank you very much :D.


link to the dartlang.slack.com angular2 channel in Help & Support for Dart

I think this channel is much more helpful for Dart developers:
https://dartlang.slack.com/messages/angular2/details/
Then the irc (where it currently links to), see (https://angular.io/docs/dart/latest/help.html)

I agree.

Just to be clear, is it https://angular.io/docs/dart/latest/help.html that you're talking about?

Closing because @naomiblack removed "help and support" from the docs navigation. Not sure what will take its place.


Support [ID]! once HC does

Depends on: https://github.com/ChilliCream/hotchocolate/pull/3440

@benmccallum Looks like the dependent issue has been merged

Yea I think I was still getting a failing test last time I tried and I gave up. The code for this is in develop.
Given we don't have any [ID]! typed args, I wasn't worried yet. The item being nullable in an array doesn't really make sense, or certainly doesn't have many applications as a type, hence why it's overlooked/buggy even in HC.

Yea I couldn't get it working on HCv11 at all, v11.2, v11.3 or the last release v11.3.8, so gave up and put a note in the readme.
Maybe my HC fix was only merged into v12 main, not v11 as well.


Add examples for publish:gerrit:review scaffolder action & improve related tests

Hey, I just made a Pull Request!
Contribution of publish:gerrit:review examples as part of https://github.com/backstage/backstage/issues/18832

:heavy_check_mark: Checklist

[x] A changeset describing the change and affected packages. (more info)
[ ] Added or updated documentation
[x] Tests for new functionality and regression tests for bug fixes
[ ] Screenshots attached (for UI changes)
[x] All your commits have a Signed-off-by line in the message. (more info)

Hi @Rugvip @acierto @vinzscam
Please review this PR

Hi @vinzscam
Implemented the suggested changes. Please check


NullReferenceException in MvcSiteMapProvider at the production

The problem is I regularly get the error at the production site but can't reproduce this error locally (The version of MvcSiteMapProvider is 3.0). The text of exception is:
ExceptionType: System.NullReferenceException
Message: Object reference not set to an instance of an object.
StackTrace:
at System.Collections.Specialized.NameObjectCollectionBase.BaseGetAllKeys()
at System.Collections.Specialized.NameValueCollection.get_AllKeys()
at MvcSiteMapProvider.MvcSiteMapNode.get_MetaAttributes()
at MvcSiteMapProvider.Web.Html.SiteMapNodeModelMapper.MapToSiteMapNodeModel(SiteMapNode node, MvcSiteMapNode mvcNode, IDictionary2 sourceMetadata) at MvcSiteMapProvider.Web.Html.SiteMapPathHelper.BuildModel(MvcSiteMapHtmlHelper helper, SiteMapNode startingNode) at MvcSiteMapProvider.Web.Html.SiteMapPathHelper.SiteMapPath(MvcSiteMapHtmlHelper helper, String templateName) at ASP._Page_Views_Shared__LoggedInLayout_cshtml.Execute() in c:\Solution\Sites\Project2Site\Views\Shared\_LoggedInLayout.cshtml:line 86 at System.Web.WebPages.WebPageBase.ExecutePageHierarchy() at System.Web.Mvc.WebViewPage.ExecutePageHierarchy() at System.Web.WebPages.WebPageBase.ExecutePageHierarchy(WebPageContext pageContext, TextWriter writer, WebPageRenderingBase startPage) at System.Web.WebPages.WebPageBase.Write(HelperResult result) at System.Web.WebPages.WebPageBase.RenderSurrounding(String partialViewName, Action1 body)
at System.Web.WebPages.WebPageBase.PopContext()
at System.Web.Mvc.ViewResultBase.ExecuteResult(ControllerContext context)
at System.Web.Mvc.ControllerActionInvoker.<>c__DisplayClass1c.b__19()
at System.Web.Mvc.ControllerActionInvoker.InvokeActionResultFilter(IResultFilter filter, ResultExecutingContext preContext, Func1 continuation) at System.Web.Mvc.ControllerActionInvoker.InvokeActionResultWithFilters(ControllerContext controllerContext, IList1 filters, ActionResult actionResult)
at System.Web.Mvc.ControllerActionInvoker.InvokeAction(ControllerContext controllerContext, String actionName)
The place where I invoke SiteMapPath() method is:
@if (SiteMap.CurrentNode != null && SiteMap.CurrentNode.ParentNode != SiteMap.RootNode)
{
@Html.MvcSiteMap().SiteMapPath() // line 86
}
Thanks.

We recently also hit this exception in production intermittently, and the version we are using is pretty old as the foundation of the code base was made years. We will try to to upgrade to latest version to see if the issue is gone or not (just leave a note here for myself's reference).


Firefox not handling the same moment("2016-11-06 01") that the other browser

Firefox: moment("2016-11-06 01") .format() == "2016-11-06T01:00:00-05:00"
Chrome: moment("2016-11-06 01") .format() ==  "2016-11-06T01:00:00-04:00"
Tested on Windows 7, with OS configured with Eastern TimeZone.

Check your debug console output.  You will find a deprecation warning because it's falling-back to the Date constructor internally, and implementations of that vary across browsers.
Basically, choose one:

Use a format moment understands without help, which are either the Supported ISO 8601 Strings, or the ASP.NET JSON Date

Tell moment what format your input is in, using formatting tokens as the second parameter, as described here.

In this case, I'd choose:
moment("2016-11-06 01", "YYYY-MM-DD HH")

Basically, both options doesn't work:
Extract from: http://momentjs.com/docs/#/parsing/string/

Supported ISO 8601 strings
A time part can also be included, separated from the date part by a space or a uppercase T.
2013-02-08 09

chrome: moment("2016-11-06 01", "YYYY-MM-DD HH").format() == "2016-11-06T01:00:00-04:00"
firefox: moment("2016-11-06 01", "YYYY-MM-DD HH").format() == "2016-11-06T01:00:00-05:00"
I also see no warning in both browsers.

Matt was quite correct in telling you to specify a format initially - the date you have is not valid ISO 8601 date as it omits minutes. Now that you have a format string you see no deprecation warning and from Moment's perspective everything is fine.
That said, this is a DST transition date and time. The problem that you are now observing is that browsers do not agree on what to do with ambiguous times, so the result ant time of a parsed local time that occurs twice, like that one, varies across browsers. This is a nuanced topic, but it's explained fairly well on Matt's blog here: http://codeofmatt.com/2013/06/07/javascript-date-type-is-horribly-broken/
I also go over it in a talk here: https://www.youtube.com/watch?v=ieIzNP6gKqU (it's at 36 minutes in)

We all know javascript is broken, it was that fact making me starting to use moment.js. It seems I was expecting wrongly that moment.js would do like so many other libraries, to remove browser differences by handling the differences.
It's working better if I use the moment.tz. What I get from that use case, is that any software that may end-up dealing with a timezone having some kind of DST, should always use the moment.tz syntax.


[9.x] Add Arr:fill() method.

Hey,
This PR adds the capability to use array_fill with a callback to fill the values.
Before
If you need to fill an array with 10 items, and change every key on it, you need to use a foreach to loop over each item and change the value on it.
$array = collect(array_fill(1, 10, ''));
foreach ($array as $key => $value) {
    $array[$key] = $key;
}

After
Arr::fill(0, 10, fn ($key) => $key);

With this approach you would archive the same result as before, with an array that as the same key and value.
Also it would work, the same as array_fill if you pass any other value than a callable.
Example
Arr::fill(0, 10, 'string');

This will have an array with 10 items with the value of string.
Thanks,
Francisco

The failing test does not look related with this feature.

I think this is basically the same thing?
use Illuminate\Support\Collection;

Collection::times(10)->mapWithKeys(
  fn ($value, $key) => [$key => $value * 2]
)->all();

Not the same.
If you need the key to start on 10 that would not work out of the box.

It will be the same if:
use Illuminate\Support\Collection;

$start = 10;
Collection::times(10)->mapWithKeys(
    fn ($value, $key) => [$key + $start => $key + $start]
 )->all();

but I prefer the Arr::fill() method since it's bound to the original array_fill.

Using with Collection::rangeByKey (if accepted #44606):
public static function fill($start, $count, $value = null)
{
  if (! is_null($value) && ! is_callable($value)) {
    $value = fn () => $value;
  }

  return Collection::rangeByKey($start, $count, $value)->toArray();
}


Added webhook friendly version and edited rules

Made rules sound less childish

Also a "webhook friendly version"? What does this change that is more friendly to webhooks?

Removed


[Feature request] Make logs available from panel

For ease of debugging, it could be interesting to have at least panel logs in the panel and why not daemon logs when it's possible ?

Most likely not going to implement this as there is logic required to store those logs in the DB, and then if that fails log them to the files anyways.
There is also a good chance people will not track this stuff and end up with thousands of logs in the DB slowing everything down.
Realistically users shouldn't even need to check logs unless something is not working, in which case checking a log that cannot be accessed by anything except a user on the system is a better idea. These logs can contain sensitive information, so storing them in the DB in just an additional attack surface, and encrypting them isn't really ideal (and just slows everything).
However, the log driver is highly extensible (thanks Laravel), so you can always write a custom module to do this as needed, and I would even encourage that and make it something installable with composer.


Standardize on ceos:4.32.0F

Fixes https://github.com/srl-labs/containerlab/issues/2033
Arista (4.25.0F) is not present on the Arista website for download. The closest available seems to be 4.25.11M.
In testing 4.25.11M did not have the Cli come up, and it would hang while initializing. The standardizes all Arista labs and docs to reference version 4.32.0F, which is working.

thanks @james-m-henderson
can you confirm the method you loaded the ceos image?
was it docker load -i <tar.gz> or docker import <tar.gz>?

Docker import. I imported both images exactly the same way, two different
lab docker instances, same behaviour each time. If there are some debug or
log output you need I can get it for you Monday.
Thanks,
James
On Sat, May 4, 2024 at 4:50 PM Roman Dodin @.***> wrote:

thanks @james-m-henderson https://github.com/james-m-henderson
can you confirm the method you loaded the ceos image?
was it docker load -i <tar.gz> or docker import <tar.gz>?
—
Reply to this email directly, view it on GitHub
https://github.com/srl-labs/containerlab/pull/2034#issuecomment-2094376483,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAHPVXXGX5O273J3ZCFAR43ZAVCXTAVCNFSM6AAAAABHHC7W66VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAOJUGM3TMNBYGM
.
You are receiving this because you were mentioned.Message ID:
@.***>

thanks @james-m-henderson
I have updated the CI to use the same ceos image, the tests passed.


reconstruct outputs every addHooks (to make it compatible with watchify)

fix #68, #63

To avoid writing to ended writeStream, outputs will be constructed everytime
In the scenario that user wanna use outpipe, the outopt will be
kept as string, so we can determine the user's attempt in later codes
and do the relavant opperations

Thanks @jcppman for this patch. However this guy does not work for the case where outputs is an array of streams. I think we may need something like this to fix the issue
https://github.com/Aben/factor-bundle/commit/18692d69d983470857d6d3c6af7b7bd12266714f

added two tests which will fail before applying the patch and will success after applying the patch

Just opened #75 that incorporates these changes and tests, and also added ability for outputs to be specified as a function for the stream case. Thanks @jcppman.

In my opinion https://github.com/Aben/factor-bundle/commit/18692d69d983470857d6d3c6af7b7bd12266714f is more of a workaround to skip the part that cause the issue (write to end stream).
BTW how about two-ways merging instead of copy-and-paste? I mean, I'm not quite care if i got my name on the commit or not but i guess that's the way open-sourced things work right?

Sorry u are right. did not mean to side step credit. will do the merge in the future. Thx for vocalizing.
Just want to make sure the stream case is covered as we need it. If there is a better way then let's do it that way

@dgbeck No worry, I'm glad that it's useful to other ppl not just me!

all sorted in the 2.5.0 release

Fantastic!


ipc-cli does not respond to SIGTERM or SIGKILL when running in a docker container

We should be nice citizens and gracefully handle these signals.
See https://filecoinproject.slack.com/archives/C04JR5R1UL8/p1710176289202849

A workaround is to pass --init to the docker command which seems to address this (context).


Where is the refresh_token grant type defined? I'm trying to give a client access to it.

I'm trying to allow a client access to refresh tokens. I've given the client the "allow offline access" scope, and I can see a refresh token being provided. I'm now trying to use the refresh token, but am getting an invalid grant type error.
Looking through the docs, I see the refrest_token grant mentioned in various places, such as here, but I don't see that token available in the code under the GrantType class.
Would I just need to manually specify that grant, like below ...
Client.AllowedGrantTypes =
{
    GrantType.Code,
    GrantType.ClientCredentials,
    "refresh_token"
};

Or is there some other way that I am supposed to add this grant? Thanks!

Make sure your Client is set to AllowOfflineAccess, and then when you request your tokens add "offline_access" as a scope.

Oh, ok, I see. So you don't have to explicitly enable the grant type - it comes with that flag. Thanks,


[13.0.x] ISPN-13703 test and fix for clustered DIST_SYNC transactional cache f…

Test and possible fix for ISPN-13703. This is branched from 13.0.x, since there are some test fails already on this branch (at least when I run it) I can't be sure it doesn't create other test breaks but it certainly fixes the test that is submitted with this fix.

Integrated into 13.0.x, thanks @tomdearman !


infowindows: none template and toggle link

WIP for https://github.com/CartoDB/cartodb/issues/7418
styles for items block pending /cc @piensaenpixel

I added the style forms in this branch, too. I feel I'm missing a lot of stuff and hardcoding some values that should belong elsewhere, but wanted to push and ask for the right direction.
the next specific issue I want to tackle would be:

how to support "None" template, with no need to unselect all the fields (re: https://github.com/CartoDB/cartodb/issues/7418#issuecomment-220129988)
how to show/hide form fields depending on template type
how to support template color (time to move to compiletemplate already?)

CR @xavijam (for the forms)
/cc @alonsogarciapablo

Miss some tests about select/unselect behaviour.

None done, now working on select/unselect own view and show/hide form fields, after that I'd say it'd be ready for merge and I'll work on the header color then

retest this, please

I added the width in the defaults to kickstart the test
however, I had previously removed the defaults as infowindow and tooltip have them different i.e. https://github.com/CartoDB/cartodb.js/blob/develop/src/geo/ui/infowindow.js#L25-L36 and https://github.com/CartoDB/cartodb.js/blob/develop/src/geo/ui/tooltip.js#L7-L11 respectively) and I'm using the same infowindow-definition for them both
I'd like to discuss in further PRs how to tackle this (different definitions for each, extend the definition? please advise)
CR @javisantana
/cc @xavijam @viddo (feedback applied)

/cc @piensaenpixel I have the toggle link in the description pending!

finally added the last test, as @javisantana told me he can't review now, moving it to @viddo  now

@javisantana reviewed on site
🚀


Refactor Admin gRPC API to JSON API

Refactors the gRPC Admin API into a JSON API that is better suited to the GDS Admin UI and other administrative tasks with Google Authentication. This PR removes the gRPC protocol buffer definitions and implements the new Admin API client definitions, modifying the main.go file accordingly. It also sets up an http server to listen on the admin port and uses the Gin framework to implement a JSON API.
Fixes SC666

Codecov Report

Merging #90 (9c9924b) into main (cf17576) will increase coverage by 0.47%.
The diff coverage is 21.18%.

:exclamation: Current head 9c9924b differs from pull request most recent head a97cc40. Consider uploading reports for the commit a97cc40 to get more accurate results

@@            Coverage Diff             @@
##             main      #90      +/-   ##
==========================================
+ Coverage   24.55%   25.02%   +0.47%
==========================================
  Files          27       30       +3
  Lines        3209     3392     +183
==========================================
+ Hits          788      849      +61
- Misses       2286     2389     +103
- Partials      135      154      +19

Impacted Files
Coverage Δ

pkg/gds/admin.go
0.00% <0.00%> (ø)

pkg/gds/service.go
11.11% <0.00%> (-0.32%)
:arrow_down:

pkg/gds/admin/v1/errors.go
17.39% <17.39%> (ø)

pkg/gds/config/config.go
48.27% <33.33%> (-1.73%)
:arrow_down:

pkg/gds/admin/v1/client.go
58.44% <58.44%> (ø)

pkg/gds/admin/v1/decode.go
83.33% <83.33%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cf17576...a97cc40. Read the comment docs.

Thank you @bbengfort for this PR moving us forward with the GDS Admin and setting the stage for more fine-grained interactions for administrators of the GDS!
One thought: Perhaps we could retain the v1 gRPC service in the repo in a v1 folder to serve as an archive/reference-in-perpetuity? And we could call the JSON service v2?

I really like this suggestion! I'll make the change now, thank you for thinking of it!


browser password auto complete function working unexpectedly on Quick Pick Input

Does this issue occur when all extensions are disabled?: Yes/No

VS Code Version: Remote Version(Code-Server, I tested with scripts/code-server.bat)
OS Version: All versions

Steps to Reproduce:

Open a terminal and use git fetch with a http git url like (should need password authentication)
git clone https://xxxxx/test.git
Then vscode prompt input box on the top of window which help you input username and password, just input username and password as usual

Then sometimes chrome prompt this to let you save authentication info (or you can click the key icon on the right side of address bar), save the same username as you use on git

4.Then all input box on vscode window will prompt password autocomplete, even this input has nothing to do with password, like

Maybe this is an issue with chrome but would be appreciated if your team can give me some suggestions to deal with this. Thank you!

I tried to play around with this using the guide here:
https://developer.mozilla.org/en-US/docs/Web/Security/Securing_your_site/Turning_off_form_autocompletion#the_autocomplete_attribute_and_login_fields
but nothing seemed to work for me in Edge or Safari (and I would assume Chrome is similar)...
maybe because we're not in a form, we're just an input box... but it's wild that I can't seem to disable this.
FWIW, deleting that one saved password made the pop up go away, but it's not quite what you're looking for :(

maybe getting an issue going in Chromium is a good start... which has guides here: https://www.chromium.org/for-testers/bug-reporting-guidelines/

cc @captainbrosset for Edge input.

maybe getting an issue going in Chromium is a good start... which has guides here: https://www.chromium.org/for-testers/bug-reporting-guidelines/

Thank you for your suggestion. I also thought it's a chromium issue at first but just created an issue here to get professional analysis from VSCode team. I will try to ask chromium team as you suggested. Thank you again for your effort!

https://crbug.com/1450609 looks like a relevant issue for Chromium. I haven't confirmed yet, but if the root cause is the same and if the password the user enters on quick input with password=true can be later seen in plain text in a quick view with password=false, that sounds like a security issue.


feat: add batch mode to publish api

Description

Add batch mode to publish() api
No need to consider the cached control messages
Encode length prefixed data and same this same data to all outbound raw stream

Closes #344

replaced by #480


Control the order of config nodes

There should be a way to set the insertion point of a config node.
Right now the nodes are sorted by alphabetical order.

concurrent map does not maintain order. got a good implementation that does?

also remember that a lot of config language specs explicitly state that mapping entries are unordered

Maintained order shouldn't be relied upon, but would be a useful feature to have in order to have the config readable in a nice order.

@zml2008 how about switching from a ConcurrentHashMap to ConcurrentSkipListMap ? http://docs.oracle.com/javase/6/docs/api/java/util/concurrent/ConcurrentSkipListMap.html
This would preserve ordering yet sacrifice some performance with insertions but I do not see that as a problem since most of our operations will be read only.

I'll mess with that. People will still whine about insertion order but I think SkipListMap is a good tradeoff.

Fixed in 9263008cfc5cb9229019b5c362c9fdabf0f8bbb8

Is it now possible to load a config from a resource and save it without destroying the order?

yeah, just pass the appropriate comparator in ConfigurationOptions to the loader's load(ConfigOptions) method.

What would be the appropriate comparator for "keep things in the order they were already in"? Wouldn't this just allow you to apply a custom sort, so that you could sort things, as opposed to avoiding sorting at all?

@ryantheleach I thought about that problem as well


Node.js LTS  support

Node.js LTS  support
Description
replace ES7 module syntax with commonjs syntax
Motivation and Context
Node.js LTS  support
How Has This Been Tested?
manually on Node.js
Screenshots (if appropriate):
Types of changes

[x ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Although we use the new import syntax, OpenType.js should work in Node.js LTS because we include a main file in package.json. This should load the compiled version for use in Node.js.
Can you point out if you have a specific use case where this breaks down?

Unactive PR, closing for now, feel free to add more details and we'll open it again.


fix: set options for a query on setOptions in a queryObserver

This PR attempts to close https://github.com/TanStack/query/issues/3706
Opened questions

How to write a test for my fix? It looks quite complex, so I need an e2e test?

@TkDodo fyi, cause you have the context of the issue)

How to write a test for my fix? It looks quite complex, so I need an e2e test?

All our tests are "e2e" tests because they mount a query on a page and then have buttons to interact with them. I think you could just write what your sandbox has and assert accordingly.
However, what bothers me is that it seems like we have a test that tests exactly the opposite of what we're trying to achieve, and that's obviously failing now:
https://github.com/TanStack/query/blob/eeec5f77bc9a703ffb6a6d283dcedada34aa3c75/packages/react-query/src/__tests__/useQuery.test.tsx#L2379-L2401

fyi, the test was introduced here:

https://github.com/TanStack/query/pull/942

Hm, I'm quite confused)
First of all, that tests checks only queryFunc, not options. So, as I understand, we can save queryFunc between executions, but all other options can be updated?

First of all, that tests checks only queryFunc, not options. So, as I understand, we can save queryFunc between executions, but all other options can be updated?

I think the test only checks for queryFn because queryFn is one of the valid options that live on the query itself. It could just as well check any other option.
The PR description says:

Currently the query configuration is dependent on the order in which hooks are rendered and this could result in unexpected behaviour. This MR will make sure the query configuration is only changed on execution. Related to https://github.com/TanStack/query/discussions/932

I'm still confused a little( Looks like current behaviour (which is a bug for me) is a correct from react-query side =(

I'll close this request. Looks like it is quite outdated and it is not so useful for the community) I'll watch for that issue by using v5 and I'll be back with a feedback)


Development server with Livereload or browser-sync?

I'm submitting a ...  (check one with "x")
[x] bug report => search github for a similar issue or PR before submitting
[ ] feature request
[ ] support request => Please do not submit support request here, instead see use [gitter](https://gitter.im/mgechev/angular2-seed) or [stackoverflow](https://stackoverflow.com/questions/tagged/angular2)

Current behavior

the description maybe wrong.
Expected behavior

Minimal reproduction of the problem with instructions

What is the motivation / use case for changing the behavior?

Please tell us about your environment:

Angular Seed Version: aaaaf75

Node: node --version =

The current master supports browser-sync dev server.


Automated cherry pick of #6292: fix: 优化openstack错误处理

Cherry pick of #6292 on release/3.1.
#6292: fix: 优化openstack错误处理

Codecov Report

Merging #6294 into release/3.1 will increase coverage by 0.04%.
The diff coverage is 20.74%.

@@              Coverage Diff               @@
##           release/3.1   #6294      +/-   ##
==============================================
+ Coverage         7.45%   7.50%   +0.04%
==============================================
  Files              584     585       +1
  Lines            98663   98813     +150
==============================================
+ Hits              7354    7411      +57
- Misses           90738   90830      +92
- Partials           571     572       +1

Flag
Coverage Δ

#aFlag
7.50% <20.74%> (+0.04%)
:arrow_up:

Impacted Files
Coverage Δ

pkg/cloudcommon/db/db_dispatcher.go
0.00% <0.00%> (ø)

pkg/cloudcommon/policy/policy.go
1.58% <0.00%> (+0.04%)
:arrow_up:

pkg/cloudprovider/cloudprovider.go
1.70% <0.00%> (-0.13%)
:arrow_down:

pkg/compute/models/cloudaccounts.go
0.79% <0.00%> (+<0.01%)
:arrow_up:

pkg/compute/models/cloudproviders.go
1.00% <0.00%> (ø)

pkg/compute/models/dbinstance_accounts.go
2.31% <0.00%> (ø)

pkg/compute/models/dbinstance_databases.go
4.14% <0.00%> (ø)

pkg/compute/models/disks.go
0.55% <0.00%> (-0.01%)
:arrow_down:

pkg/compute/models/dnsrecords.go
27.52% <0.00%> (-0.39%)
:arrow_down:

pkg/compute/models/elasticcache_instances.go
1.17% <0.00%> (ø)

... and 26 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 743b4d2...08bef5e. Read the comment docs.


work on review remarks

manifest
correct version format
delete item ask for some of the arguments
scripts
improve progress bar

Duplicate of https://github.com/YunoHost-Apps/mopidy_ynh/pull/13. Closing this one 😉


Support WAV music streaming

Right now WAV files can only be full loaded as Sound.
It will be desirable to load them for streaming, like we can do with other audio file-formats.

DONE.


Gems can be duplicated in the dissasembly station, as the part is not removed when picking an ingredient

Ehm, for some reason I cannot reproduce this issue


Edit Course: Hide "Add Organization" Button If I'm Not Allowed to See It

Describe the bug
When editing a course, I see a button for "adding an organization" but when I click it, I see an empty popup and instantly an alert pops up telling me that I am not allowed to do this.
To Reproduce

Log into Artemis with an account that can edit courses
Go to a course and click edit
See and click the "Add Organization" button

Expected behavior
If I am not allowed to do that, I should not see the button in the first place or it should be disabled (maybe with a tooltip when hovering).
Screenshots

Which version of Artemis are you seeing the problem on?
6.0.2
What browsers are you seeing the problem on?
Safari
Additional context
No response
Relevant log output
No response

I want to work on this but am unsure about the necessary permissions to add organizations. Is it an admin-only feature? 🤔


Pipeline monitoring

Hi @IsaackMwenda, I have set up pipelines metrics navigation link, page and functions that will be used to generating charts when data starts being uploaded on firestore.

Added the table to display pipeline name, the last start time of the pipeline, and the last successful run.

Thanks @DanielMwendwa! I think what you have done so far is useful for us already if deployed. Could you consider adding issues to address in future for:

Filtering by active projects
Moving the navs so that we have a Miranda button and a Pipelines button under a Systems dropdown?

Added


help!

hi! i am trying to code a mod to fnf
i added custom character and custom stage (with the code of dad's stage just with different file names)
it's compiling good without errors but whenever i open the week it opens the right song but with the default stage and dad's sprite
i can switch to my custom character with the debug menu but i want it to be there by the start of the song
but when i try to load the custom stage it just loading the same default stage again
can you please help me with these 2 issues?
(and don't tell me to replace the default stage png bc i need it
have a wonderful day!
jon

check stage code
check the charting
check xml
check character code
check characterList.txt

check stage code
check the charting
check xml
check character code
check characterList.txt

yes correct, first you gotta check the stage code, if it has the week 1 bg name, rename it to yours. then you also need to check the charting, who knows, maybe you put the wrong bg and character name. then check the character code, if you wrotten the wrong xml code (actually g4merz you don't really need to change the xml because it can only detect the upper wrotten file) on the character code the game wouldn't work. and lastly check characterList.txt because if you wrotten the same name with one of the character names, it would be original.
Have a nice day!!!
Magniill

hello! sorry to keep ya all waiting i managed to get my character as the default and also my stage but not as default  i checked in the jsons and there are no references to any stage and also my stage dosen't have xml
can you tell me how to fix that? so the stage will be default?
have a wonderful day!


Contents added to message are lost in robot.catchAll handler.

Version

<EMAIL_ADDRESS>
Problem
Hubot supports populating contents in message object through middlewares, but it seems the contents are lost in catchAll handler.
Reproduce Steps
scripts/example.coffee:
# Description:
#   Test listener and catchAll.
#
module.exports = (robot) ->
  robot.catchAll (res) ->
    res.reply res.message.secret
  robot.respond /test/, (res) ->
    res.reply res.message.secret
  robot.listenerMiddleware (context, next, done) ->
    context.response.message.secret = 'hello'
    next()

Testing
C:\Users\rophy\git\hubot-secret>bin\hubot
up to date in 1.074s
hubot-secret> hubot-secret test
hubot-secret> Shell: hello
hubot-secret> hubot-secret abcabc
hubot-secret> Shell: undefined

In the test you're loading a file called config.coffee, but your src script is secret.coffee. Is that just a typo?
Also worth noting that hubot-test-helper uses mock classes and methods that aren't exactly alike to the original hubot. It's good for basic listener tests but falls short in some ways especially when testing middleware, so it may not be a fault of your code, but the test.
Have you tried prompting this interaction manually in normal hubot, for example using the shell adaptor?

@timkinnane I was trying to make a simple reproducing case, both the typo and the usage of hubot-test-helper do not affect the result.
To avoid complicating things, I have updated the reproduce sample, thanks for the response.

OK actually I think I know why this isn't working anyway. From the docs: "Listener middleware inserts logic between the listener matching a message and the listener executing" - catch all fires when no listeners match, so the listener middleware would never be called in this case. You should try it with robot.receiveMiddleware instead.

Worked exactly as @timkinnane said, thanks so much!

@timkinnane's suggestion to use a receive middleware is a good one, but I think this might be a bug, or if not, just a use case that wasn't considered.
Here's some of the relevant code:

robot.catchAll https://github.com/hubotio/hubot/blob/master/src/robot.js#L214-L233
robot.processListeners when a listener wasn't matched, so it receives a new catchall message: https://github.com/hubotio/hubot/blob/master/src/robot.js#L331-L340
robot.receive processes with listeners

Having listed this out, I am wondering if the listenerMiddleware @rophy wrote is not actually matching for the catchAll for some reason.
cc @michaelansel as my go to middleware expert 😅

@technicalpickles are you saying listenerMiddleware should be called prior to the catchAll, even if there's no listeners?
I can see why that might be helpful sometimes, but if it not doing so currently is a bug, it might confuse people and break stuff if that's "fixed", because I would assume there's scripts out there counting on the middleware not firing unless actual listeners are called (not counting catchAll).

I'm saying that the catchAll is itself a listener, so listener middleware should run as part of calling the catchAll.

if it not doing so currently is a bug, it might confuse people and break stuff if that's "fixed"

Good thing we are adopting semantic versioning and planning to release more often then 😅

Good stuff. Well this tickets original question is answered, but if we're keeping it open to resolve the bug it's raised, can we modify the title to something like "Listener middleware not called for catchAll listener"?


Fix #15062 & #14810: Fix Column level lineage overwrites pipeline Lineage & manual col lineage

Describe your changes:
Fix #15062 & Fix #14810: Fix Column level lineage overwrites pipeline Lineage & manual col lineage

I worked on ... because ...

Type of change:

[ ] Bug fix
[ ] Improvement
[ ] New feature
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Documentation

Checklist:

[x] I have read the CONTRIBUTING document.
[ ] My PR title is Fixes <issue-number>: <short explanation>
[ ] I have commented on my code, particularly in hard-to-understand areas.
[ ] For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

I suggest adding a test case or a video demonstrating the fix

+1 on getting the backend covered 🙏


Raneto is not displayed correctly

Hello,
I installed Raneto v13 on a Virtual Server with Debian 8.6.0 amd64 Minimal. I installed Node.js via package manager as stated on the Node.js website (https://nodejs.org/en/download/package-manager/). My current version of node is v6.10.0 and of npm it is 3.10.10. I used  git clone https://github.com/gilbitron/Raneto.git && cd Raneto && npm install && npm start from Raneto´s GitHub page to install Raneto.
When I am viewing the page from diffrent browsers an different end devices Raneto is not displayed correctly (see imagesy):

It is working correctly, when I install Raneto on my PC. I tried to run Raneto on Virtual Server with CentOS, with same results. I use https://www.servercow.de/ for hosting. I do not know how to resolve this issue. Maybe someone of you will have an idea :)
I really like Raneto, so I hope I can get it up and running again. Thank you for your work and help.

I solved the issue! I started Raneto with root privileges. That was causing the issue.
Just run Raneto without root privileges.

i also have this problem,  i am on the win10 system
i attemt to change privileges but no work:(
could you help  me?


Add test for GRAD changing spacing

Description
This pull request addresses the problems described at issue #3187
To Do

[x] update CHANGELOG.md
[ ] wait for all checks to pass
[ ] request a review
[ ] Figure out what to do for CFF2 fonts
[ ] Figure out how to check kerning changes

Regarding kerning, Cosimo says

traverse the GPOS kern lookup, find all device tables, look up deltas in GPOS.VarStore with the indices from device tables, and if non-zero, you have your changes
you can see how varLib.varStore does something similar for collecting all device subtables, and re-mapping varIdx after subsetting
can't you simply check that the GRAD masters (ufo) have no kerning.plist?
and features.fea have no manual "kern" feature blocks

I'll see if I can solve this for binaries.

Thanks for the review so far. I'm working on something else now, will return after I figured out how to test for kerning changes along a grade axis...

Anyone have thoughts about how to approach this?

superseded by PR #3431


Tooltip draw hooks for ModItem & GlobalItem

For review, but I think this should work fine. I tested it the entire evening with Example Sword.

Feel free to improve the Example mod (Example  sword) tooltip draws, I have not much interest in that, modder will know what to do.


Use existing Button Style for Add Lane Button

I’m not sure if this is already possible; but we use MDL style for different components, such as a button that is already design based on the company’s CI. Is there anyway to inject our  to be used for the Add Lane Button?

@Kalaschnik   hi!
I have just  done Dependency Injection mechanism. Could you please test it and give me a feedback?
https://github.com/rcdexta/react-trello/pull/274
yarn add BrandyMint/react-trello#components_dependency_injections

I think it is a good way to get full control over components customisation.
If it is Ok, I will merge it to master.

Now dependency injection in master. You can override any used components.
https://github.com/rcdexta/react-trello#3-completely-customize-the-look-and-feel-by-using-components-dependency-injection
Pls open the issue if something is wrong


dts: bindings: fix intel,dai-misc

Fix the compatible string from "intel,dai,dmic" to "intel,dai-dmic".
Also rename the yaml file to have vendor name first.

Signed-off-by: Daniel Leung<EMAIL_ADDRESS>

The test failure is due to some timing issue on QEMU that is not related to the change here.


(3.0.63) class def / instance var oddities

add iv to class, switch to variables pane (pink background ... okay)

add instance variable postLoadClassList

accept (looks good)

click on variables pane, with intent to add accessors (where'd the instance variable go?)

click off the class and then back on (ins var reappears)

I saw at least one other funky behavior in this area (adding an inst var to a class and clicking around), but I don't remember the exact sequence...
The fact that the inst var disappears make this a feb bug (in my opinion)

The service wasn't getting updated properly before selecting the variables tab. Fixed in 3.0.64. https://github.com/GemTalk/Jadeite/commit/7b316500b6b75697ea2951ab7d08965a1b45b0d9

I don't see Dale's behavior.  It's not clear what he does in step 1 "switch to variables pane", since the catagories pane is showing and he switches to variables pane in step 3.
I see a little peculiar behavior in that with variables tab selected, you can move around and between unsaved class and method defs, but when you select category you have to save or lose.  I don't see anything like a bug, just inconsistency.

@LisaAlmarode in the first graphic (step 1) I had not actually added the instance variable yet ... just edited the (pink) pane and step 2 is the accept, so step 3 is the initial switch where the iv is not visible in the vars pane and that is/was the the bug ... I did see other odd behavior in this area and was just happy that I could take screen shots of the "bad behavior" ... many times even I cannot reproduce the bug:)


Rope problems with newer Phaser

Hey,
The Rope example doesn't compile on recent Phaser due to:
TypeError: undefined is not an object (evaluating 'this.texture.baseTexture.scaleMode')

This is not caused by the example itself, but more by non-existing texture (AFAIK). The stock phaser.js from the repo works well, I just tried 2.3.0 and it's failing there.
Thanks,
V.

/c @codevinsky

I encounter the same problem, i change the Phaser.Component.LoadTexture.prototype.loadTexture implementation to work around, that must be Phaser 2.3.0 bug. /c @photonstorm
var smoothed = this.texture.baseTexture ? !this.texture.baseTexture.scaleMode : false;

This is now properly fixed in the dev branch, including the segments getter and the rope debug not taking the rope scale into account.


Gradle build fails

Error:(57, 13) Failed to resolve: com.taishi-y:flipprogressdialog:0.1.0
<somedir/build.gradle">Show in FileShow in Project Structure dialog

Thanks man! I'm going to add this lib to jcenter. It will takes 2 hours or so!

thanks you , btw it's best loading lib i've ever seen. keep it up.

Aww Thank you! XD

@Taishi-Y I just go that i can't show the dialog without fragment manager , can you explain why or if i can escape it somehow :laughing:

@gugakatsi Thank you for asking! Because FlipProgressDialog class extends DialogFragment and using show function.😅
Do you know any better way?

nah :smile:  thanks
:D


SocketException: No such host is known

nuget package 2.0 instable rev 0122 version. Not sure which torrent it was giving this exception.
Exception thrown: 'MonoTorrent.Client.Tracker.TrackerException' in MonoTorrent.dll
Scrape could not be completed
This exception was originally thrown at this call stack:
System.Net.Dns.GetAddrInfo(string)
System.Net.Dns.InternalGetHostByName(string, bool)
System.Net.Dns.GetHostAddresses(string)
System.Net.Sockets.UdpClient.Connect(string, int)
System.Net.Sockets.UdpClient.UdpClient(string, int)
MonoTorrent.Client.Tracker.UdpTracker.SendAndReceiveAsync(MonoTorrent.Client.Messages.UdpTracker.UdpTrackerMessage)
System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(System.Threading.Tasks.Task)
System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(System.Threading.Tasks.Task)
MonoTorrent.Client.Tracker.UdpTracker.ConnectAsync()
System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(System.Threading.Tasks.Task)
Exception:
{"Scrape could not be completed"}
    Data: {System.Collections.ListDictionaryInternal}
    HResult: -2146233088
    HelpLink: null
    IPForWatsonBuckets: 0x71f8cc51
    InnerException: {"No such host is known"}
    IsTransient: false
    Message: "Scrape could not be completed"
    RemoteStackTrace: null
    Source: "MonoTorrent"
    StackTrace: "   at MonoTorrent.Client.Tracker.UdpTracker.<DoScrapeAsync>d__14.MoveNext()"
    TargetSite: {Void MoveNext()}
    WatsonBuckets: null
    _HResult: -2146233088
    _className: null
    _data: {System.Collections.ListDictionaryInternal}
    _dynamicMethods: null
    _exceptionMethod: null
    _exceptionMethodString: null
    _helpURL: null
    _innerException: {"No such host is known"}
    _ipForWatsonBuckets: 0x71f8cc51
    _message: "Scrape could not be completed"
    _remoteStackIndex: 0
    _remoteStackTraceString: null
    _safeSerializationManager: {System.Runtime.Serialization.SafeSerializationManager}
    _source: "MonoTorrent"
    _stackTrace: {sbyte[24]}
    _stackTraceString: null
    _watsonBuckets: null
    _xcode: -532462766
    _xptrs: 0x00000000

Inner exception:
{"No such host is known"}
    Data: {System.Collections.ListDictionaryInternal}
    ErrorCode: 11001
    HResult: -2147467259
    HelpLink: null
    IPForWatsonBuckets: 0x71f8cc51
    InnerException: null
    IsTransient: false
    Message: "No such host is known"
    NativeErrorCode: 11001
    RemoteStackTrace: null
    SocketErrorCode: HostNotFound
    Source: "System"
    StackTrace: "   at System.Net.Dns.GetAddrInfo(String name)\r\n   at System.Net.Dns.InternalGetHostByName(String hostName, Boolean includeIPv6)\r\n   at System.Net.Dns.GetHostAddresses(String hostNameOrAddress)\r\n   at System.Net.Sockets.UdpClient.Connect(String hostname, Int32 port)\r\n   at System.Net.Sockets.UdpClient..ctor(String hostname, Int32 port)\r\n   at MonoTorrent.Client.Tracker.UdpTracker.<SendAndReceiveAsync>d__16.MoveNext()\r\n   at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)\r\n   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)\r\n   at MonoTorrent.Client.Tracker.UdpTracker.<ConnectAsync>d__15.MoveNext()\r\n   at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)\r\n   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)\r\n   at MonoTorrent.Client.Tracker.UdpTracker.<DoScrapeAsync>d__14.MoveNext()"
    TargetSite: {System.Net.IPHostEntry GetAddrInfo(System.String)}
    WatsonBuckets: null
    _HResult: -2147467259
    _className: null
    _data: {System.Collections.ListDictionaryInternal}
    _dynamicMethods: null
    _exceptionMethod: null
    _exceptionMethodString: null
    _helpURL: null
    _innerException: null
    _ipForWatsonBuckets: 0x71f8cc51
    _message: "No such host is known"
    _remoteStackIndex: 0
    _remoteStackTraceString: null
    _safeSerializationManager: {System.Runtime.Serialization.SafeSerializationManager}
    _source: "System"
    _stackTrace: {sbyte[384]}
    _stackTraceString: null
    _watsonBuckets: null
    _xcode: -532462766
    _xptrs: 0x00000000
    m_EndPoint: null
    nativeErrorCode: 11001

seems it is directly related to the trackers I addd to a magnet URL.
Could be some of these trackers are bad and result in the above issues.

Are you getting a MagnetUrl or from a torrent file? If a magnet file, I always use
System.Web.HttpUtility.UrlDecode(url);
The JSON data that I get back throws in EncodedUrl stuff. Also, for test purposes I added trackers from a file and made sure to use the HttpUtility.
Not sure if this will help. But if you're obtaining a magnet url. This breaks everything down. Maybe not very optimized.
    public static class TorrentMagnetUtils
    {
        public static MonoTorrent.MagnetLink ConvertMagnetUrl(string magnetUrl)
        {

            magnetUrl = System.Web.HttpUtility.UrlDecode(magnetUrl);
            var hash = magnetUrl.Substring(magnetUrl.IndexOf("btih:") + 5);
            hash = hash.Substring(0, hash.IndexOf("&dn"));
            var downloadName = magnetUrl.Substring(magnetUrl.IndexOf("&dn=") + 4);
            downloadName = downloadName.Substring(0, downloadName.IndexOf("&tr"));
            List<String> announcements = new List<string>();

            MatchCollection mc = Regex.Matches(magnetUrl, @"(\?|\&)([^=]+)\=([^&]+)", RegexOptions.Singleline);

            foreach (Match match in mc)
            {

                string value = match.Value;
                if (value.Contains("&tr="))
                {
                    string announcement = value.Substring(match.Value.IndexOf("&tr=") + 4);
                    announcements.Add(announcement);
                }
            }

            return new MonoTorrent.MagnetLink(MonoTorrent.InfoHash.FromHex(hash), downloadName, announcements);
        }
    }

What's the main magnet url by the way? I can probably test out those trackers. The trackers i've added to the file is quite long. But I do recognize some of your trackers that you've used. And, no issues so far.

This looks like the normal behaviour when a given Tracker cannot be contacted.
If you discovered this exception by virtue of running the code with the visual studio debugger attached then there's no further diagnosing needed unless you have reason to believe something more serious is going on.
I'll close this for now as this should be fine.

System.Web.HttpUtility.UrlDecode(url)

I'd recommend using this only if the string has been url encoded in the first place. It would be wrong to do this on a value which isn't url encoded.
Additionally - it's odd to see regex being used to parse such a simple url format. When aren't you simply parsing the string using the approriate static method on the MagnetLink class?

This looks like the normal behaviour when a given Tracker cannot be contacted.
If you discovered this exception by virtue of running the code with the visual studio debugger attached then there's no further diagnosing needed unless you have reason to believe something more serious is going on.
I'll close this for now as this should be fine.

System.Web.HttpUtility.UrlDecode(url)

I'd recommend using this only if the string has been url encoded in the first place. It would be wrong to do this on a value which isn't url encoded.
Additionally - it's odd to see regex being used to parse such a simple url format. When aren't you simply parsing the string using the approriate static method on the MagnetLink class?

the magnetlink url obtained is from a JSON response from a website. And it has encoded URL. Before, I tried to use the MagnetLink after manually parsing the hashInfo. However, it didn't behave like I wanted. Maybe I didn't know how to use it.
magnetlink obtained from JSON response:

magnet:?xt=urn:btih:0477C03A7C27555BEE24F123D774662ADE08D23F&dn=Tangled (2010) 1080p&tr=http://retracker.uln-ix.ru/announce&tr=http://tracker.best-torrents.net:6969/announce&tr=http://<IP_ADDRESS>:6969/announce&tr=http://retracker.telecom.kz/announce&tr=http://retracker.adminko.org/announce&tr=http://tracker.tfile.me/announce&tr=http://mgtracker.org:2710/announce&tr=http://bt.careland.com.cn:6969/announce

I optimized the MagnetLinkConverter function to parse the url within 0.000300 ms.  Oh, that isn't the raw response. It's pretty versioned.
If you have a MagnetLink parser, i'll try it out. I've been constantly using the newest MonoTorrent and it's purring very nicely.

The spec compliant (url encoded) form for this magnet link would be:
magnet:?xt=urn:btih:0477C03A7C27555BEE24F123D774662ADE08D23F&dn=Tangled+(2010)+1080p&tr=http%3a%2f%2fretracker.uln-ix.ru%2fannounce&tr=http%3a%2f%2ftracker.best-torrents.net%3a6969%2fannounce&tr=http%3a%2f%2f<IP_ADDRESS>%3a6969%2fannounce&tr=http%3a%2f%2fretracker.telecom.kz%2fannounce&tr=http%3a%2f%2fretracker.adminko.org%2fannounce&tr=http%3a%2f%2ftracker.tfile.me%2fannounce&tr=http%3a%2f%2fmgtracker.org%3a2710%2fannounce&tr=http%3a%2f%2fbt.careland.com.cn%3a6969%2fannounce

And you can parse this by passing it to MagnetLink.Parse (string).
One real world example where UrlDecoding will break the magnet link would be display names like Pride & Prejudice. The correct magnetlink for this is: magnet:?xt=urn:btih:0477C03A7C27555BEE24F123D774662ADE08D23F&dn=Pride+%26+Prejudice and MagnetLink.Parse will decode this back into Pride & Prejudice.
If you choose to UrlDecode this before passing it to MagnetLink.Parse then you would be attempting to parse the string "magnet:?xt=urn:btih:0477C03A7C27555BEE24F123D774662ADE08D23F&dn=Pride & Prejudice", and when you split the query string on & as required by normal url parsing rules you'll end up corrupting the display name.
In short - either use MagnetLink.Parse and everything will Just Work, or manually UrlDecode the string and parse it by hand. should not manually UrlDecode* the string and also use MagnetLink.Parse :)


Only inspect plaintext files for whitespace errors

Closes #13

I can confirm that this doesn't result in a failure linked to the JPEG file we were having trouble with. I should also check that it still reports failures as expected, too.

It's also reporting failures correctly.

Any movement on this?

@komidore64 The PR appears to be dormant, but we're using this branch ourselves. You're welcome to do so yourself if you wish - it's not going anywhere for now.


Typo in message

Folder is actually node-pools. Could you call nodePoolExportedStackTemplatePath() here instead, to ensure the correct path is in the message?

Current coverage is 68.87% (diff: 100%)

Merging #225 into master will not change coverage

@@             master       #225   diff @@
==========================================
  Files             4          4
  Lines          1134       1134
  Methods           0          0
  Messages          0          0
  Branches          0          0
==========================================
  Hits            781        781
  Misses          263        263
  Partials         90         90

Powered by Codecov. Last update 56b4efc...c5a28e1


Update build-a-distributed-environment-for-windows-10-deployment.md

Updated Notes markup.
Added a few line shifts for increased readability.

@greg-lindsay The PR that introduces minor formatting fixes to the document is available for review. Thanks.


“Detox.framework could not be found” when attempting “ios.none” type configuration

The check for the framework should only happen if the type is “ios.simulator”, but not for the others. I didn’t check, but it probably has the same requirement for android configurations as well. It shouldn’t.

Correct


[T5A3][T16-B1]Xie Jihui

Ready for review.
Please only review the second commit. Actually, I do not how to delete the first commit which should not include in this activity.

To figure out how to deal with accidental commits, try looking up stackoverflow or similar sites for tutorials on how to deal with such cases.
Accepting this PR without a review because another of your PRs for this tutorial was reviewed in detail.


fix: fill NaN Values in cumsum function

SUMMARY

Fill NaN Values before applying the cumsum function, to make the resulting lines continues.
Fixes https://github.com/apache/superset/issues/21093
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

[ ] Has associated issue:
[ ] Required feature flags:
[ ] Changes UI
[ ] Includes DB Migration (follow approval process in SIP-59)

[ ] Migration is atomic, supports rollback & is backwards-compatible
[ ] Confirm DB migration upgrade and downgrade tested
[ ] Runtime estimates and downtime expectations provided

[ ] Introduces new feature or API
[ ] Removes existing feature or API

@WulfH Thanks for the contribution, but I think this vis would be retired in Superset 3.0.

@zhaoyongjie can you say more?  See the linked bug issue, I believe this is affecting line charts (not legacy).

@sfirke Thanks for informing me, the change in the PR should affect legacy line chart and Advanced Analytics in legacy charts.
I think the same issue should resolve in new Advanced Analytics, the Resample section in AA should fill up zero/nan and so on.
If I misleading anything please ping me.

Just a comment that no this really isn't a bug.  If the user wants continuous lines, they should use a IFNULL or similar to replace the 0.  Zero and null are not the same and making nulls zeros for cumulative sum in every case breaks scenarios like this one here https://github.com/apache/superset/issues/27245 when they really should remain null.

For this, I think you just need to use Zero imputation along with. your cumsum. I'll close this, but let me know if I'm misinterpreting and we can most certainly revisit/reopen.


Refactor page titles and content for

Using content_for inside nested templates makes caching tricky because those block will not get called if those templates are cached. This PR eliminates that usage and makes some changes to trending petitions as well to so that it can be cached in the view.

Looks good, needs a rebase tho'

Rebased, merged when :green_heart:


A fresh install of WSL gets the error "-bash: eval: line 136: syntax error: unexpected end of file"

Windows Version
Microsoft Windows [version 10.0.22631.3880]
WSL Version
<IP_ADDRESS>
Are you using WSL 1 or WSL 2?

[X] WSL 2
[ ] WSL 1

Kernel Version
<IP_ADDRESS>
Distro Version
22.04
Other Software
No response
Repro Steps
1/ Install WSL (wsl --install)
2/ Follow the guide, nothing too complex
3/ Reboot
4/ Use wsl command in Terminal (Powershell)
5/ Get the error -bash: eval: line 136: syntax error: unexpected end of file :
C:\Work> wsl
-bash: eval: line 136: syntax error: unexpected end of file
nino@Desktino:/mnt/c/Work$

Expected Behavior
Not get an error
Actual Behavior
Got an error that I can't fix myself
Diagnostic Logs
No response

@NinoDLC: This looks like an issue coming from your .bashrc.
Can you share the content of your .bashrc and .profile ?


Add suppport for i2vgen-xl im2vid

Added a prompt for img2vid, cause i2vgen-xl supports that!
Also added the self.ldm.enable_vae_slicing() tweak, otherwise the model would not run on a 20GB Vram card.
Probably good to make this a config parameter or something.

Needs adjustment to detect "fp16"


Add schema_without_macros to macro_registry

Refactor to solidify the meaning of the type macro_registry. Macros can only valid based on a specific schema.

Coverage increased (+0.004%) to 93.252% when pulling eb32f95350d227e6d009098eb34e3cd57bed5ace on add_macros_to_schema_2 into 0f702067b1aa87d141064500ad6bec95efcb357d on macro_system.


Major upgrade of Gravitee BOM

Issue
N/A
Description

Bump dependencies, mainly Vert.x and Logback
Remove RxJava2 dependency, as RxJava3 is expected to be used instead
Use the latest gravitee-parent 22.0.0
Bump gravitee-orb to 4.1.0

Gravitee.io Automatic Deployment
🚀 A prerelease version of this package has been published on Gravitee's private artifactory, you can:

use it directly by updating your project with version: 6.0.0-upgrade-vertx-and-deps-SNAPSHOT
download it from Artifactory here

:tada: This PR is included in version 6.0.0 :tada:
The release is available on:

6.0.0
GitHub release

Your semantic-release bot :package::rocket:


Add member before doing tests

Summary
The submission workflow is failing as there is no member in the database when updating the test results (see https://github.com/qiskit-community/ecosystem/actions/runs/6017322417/job/16323220183#step:6:82). I believe we can fix this by adding the member before doing the tests.

Seems to work (at least doesn't break in same place): https://github.com/frankharkins/ecosystem/actions/runs/6024877417/job/16344457666

Actually, I don't think this works; the tests are incorrectly being reported as failing

Actually, this does seem to fix it, it's just the project I chose to test on is reported as failing (this is a bug, but unrelated to #518).

@frankharkins As https://github.com/qiskit-community/ecosystem/pull/519 fix it, do you still want to add the member before running the checks ?

I thought this would add test results to the submission PR, but it doesn't seem to do that either 😅
I'll close it again as it seems like an inconsequential change


update README with badges and matrix chat link

Huh, no wonder people asked in the wrong room recently.


NCMesh pyramid dev

Adding Pyramid elements to NCMesh so they can be refined and derefined.  We currently only support isotropic refinement.

PR
Author
Editor
Reviewers
Assignment
Approval
Merge

#3132
@acfisher
@pazner
@YohannDudouit + @mlstowell
8/16/22
⌛due 8/30/22
⌛due 9/6/22

PR Checklist

[ ] Code builds.
[ ] Code passes make style.
[ ] Update CHANGELOG:

[ ] Is this a new feature users need to be aware of? New or updated example or miniapp?
[ ] Does it make sense to create a new section in the CHANGELOG to group with other related features?

[ ] Update INSTALL:

[ ] Had a new optional library been added? If so, what range of versions of this library are required? (Make sure the external library is compatible with our BSD license, e.g. it is not licensed under GPL!)
[ ] Have the version ranges for any required or optional libraries changed?
[ ] Does make or cmake have a new target?
[ ] Did the requirements or the installation process change? (rare)

[ ] Update continuous integration server configurations if necessary (e.g. with new version requirements for each of MFEM's dependencies)

[ ] .github
[ ] .appveyor.yml

[ ] Update .gitignore:

[ ] Check if make distclean; git status shows any files that were generated from the source by the project (not an IDE) but we don't want to track in the repository.
[ ] Add new patterns (just for the new files above) and re-run the above test.

[ ] New examples:

[ ] All sample runs at the top of the example source file work.
[ ] Update examples/makefile:

[ ] Add the example code to the appropriate SEQ_EXAMPLES and PAR_EXAMPLES variables.
[ ] Add any files generated by it to the clean target.
[ ] Add the example binary and any files generated by it to the top-level .gitignore file.

[ ] Update examples/CMakeLists.txt:

[ ] Add the example code to the ALL_EXE_SRCS variable.
[ ] Make sure THIS_TEST_OPTIONS is set correctly for the new example.

[ ] List the new example in doc/CodeDocumentation.dox.
[ ] If new examples directory (e.g.examples/pumi), list it in doc/CodeDocumentation.conf.in
[ ] Companion pull request for documentation in mfem/web repo:

[ ] Update or add example-specific documentation, see e.g. the src/examples.md.
[ ] Add the description, labels and screenshots in src/examples.md and src/img.
[ ] In examples.md, list the example under the appropriate categories, add new categories if necessary.
[ ] Add a short description of the example in the "Extensive Examples" section of features.md.

[ ] New miniapps:

[ ] All sample runs at the top of the miniapp source file work.
[ ] Update top-level makefile and makefile in corresponding miniapp directory.
[ ] Add the miniapp binary and any files generated by it to the top-level .gitignore file.
[ ] Update CMake build system:

[ ] Update the CMakeLists.txt file in the miniapps directory, if the new miniapp is in a new directory.
[ ] Add/update the CMakeLists.txt file in the new miniapp directory.
[ ] Consider adding a new test for the new miniapp.

[ ] List the new miniapp in doc/CodeDocumentation.dox
[ ] If new miniapps directory (e.g.miniapps/nurbs), add it to MINIAPP_SUBDIRS in the makefile.
[ ] If new miniapps directory (e.g.miniapps/nurbs), list it in doc/CodeDocumentation.conf.in
[ ] Companion pull request for documentation in mfem/web repo:

[ ] Update or add miniapp-specific documentation, see e.g. the src/meshing.md and src/electromagnetics.md files.
[ ] Add the description, labels and screenshots in src/examples.md and src/img.
[ ] The miniapps go at the end of the page, and are usually listed only under a specific "Application (PDE)" category.
[ ] Add a short description of the miniapp in the "Extensive Examples" section of features.md.

[ ] New capability:

[ ] All new public, protected, and private classes, methods, data members, and functions have full Doxygen-style documentation in source comments. Documentation should include descriptions of member data, function arguments and return values, template parameters, and prerequisites for calling new functions.
[ ] Pointer arguments and return values must specify whether ownership is being transferred or lent with the call.
[ ] Any new functions should include descriptions of their intended use e.g. for internal use only, user-facing, etc., along with references to example code whenever possible/appropriate.
[ ] Consider adding new sample runs in existing examples to highlight the new capability.
[ ] Consider saving cool simulation pictures with the new capability in the Confluence gallery (LLNL only) or submitting them, via pull request, to the gallery section of the mfem/web repo.
[ ] If this is a major new feature, consider mentioning it in the short summary inside README (rare).
[ ] List major new classes in doc/CodeDocumentation.dox (rare).

[ ] Update this checklist, if the new pull request affects it.
[ ] Run make unittest to make sure all unit tests pass.
[ ] Run the tests in tests/scripts.
[ ] (LLNL only) After merging:

[ ] Update internal tests to include the new features.

Is anyone familiar with these linking errors that are showing up in the windows build?
metis.lib(wspace.c.obj) : error LNK2019: unresolved external symbol gk_mcoreMalloc referenced in function libmetis__wspacemalloc [D:\a\mfem\mfem\mfem\build\examples\ex1p.vcxproj]

metis.lib(wspace.c.obj) : error LNK2019: unresolved external symbol gk_mcoreMalloc referenced in function libmetis__wspacemalloc [D:\a\mfem\mfem\mfem\build\examples\ex1p.vcxproj]

I have not seen those. Which version of METIS is this with?

The METIS errors have been showing up intermittently in the Windows CI on many (all?) branches. We should get to the bottom of it, but I suspect that it's not specific to this PR.

This PR is now under review (see the table in the PR description). To help with the review process, please do not force push to the branch.

@mlstowell, @acfisher, is example 6 expected to fail? Is it a lot of work to get it to run properly? Any idea why ex6p works for that one example but ex6 doesn't?

@mlstowell, @acfisher, is example 6 expected to fail? Is it a lot of work to get it to run properly? Any idea why ex6p works for that one example but ex6 doesn't?

I wouldn't say that it was "expected" to fail but I was hoping to be pleasantly surprised if it worked.
I ran the serial and parallel versions of example 6 (slightly modified) on two different mixed meshes; one without pyramids the other with. I found one success and three different errors. I'll create an issue rather than try to summarize the problems here.
I have not followed up on these errors yet but I suspect they are not trivial to resolve. If @acfisher wants to address some or all of these errors in this PR that would be great but a separate PR may be advisable.

I just created an issue (#3220 ) describing the troubles with example 6. In that issue I also attached a version of fichera-mixed.mesh which includes hexahedra, tetrahedra, wedges, and pyramids. I thought this mesh might be of interest for other testing.

Thanks Mark, I didn't know about the problems with ex6, but it sounds like it it something else entirely.  I'll fix that comment and we can get this pulled in :).

@YohannDudouit, could you take a look at this when you get a chance?

@jakubcerveny, can you help with this review, if you have some time?

Thanks a bunch @jakubcerveny for taking a look at this and giving me some comments.  I'll dive into them soon.

Are folks seeing this error other places:
cc1plus: error: unrecognized argument to ‘-flto=’ option: ‘auto -ffat-lto-objects -flto=auto’

That should be fixed once #3351 is merged into master (and then master merged here)

Merged in next for testing...

Re-merged in next for testing...

Re-merged in next for testing...


Adjust luminosity of the star prefab as a serialized field

Adjust the rendering of the object's glow

This will be handled by the star prefab; the common bloom render is accurate but the different sections will require updates on the prefab side.


feat(core): Support opentelemetry exporter

Description
DB-GPT also supports OpenTelemetry for distributed tracing.  Now, you can export traces to open-telemetry compatible backends like Jaeger, Zipkin,
and others with OpenTelemetry Protocol (OTLP).
To enable OpenTelemetry support, you need install following packages:
pip install opentelemetry-api opentelemetry-sdk opentelemetry-exporter-otlp

or
pip install -e ".[observability]"

How Has This Been Tested?

TRACER_TO_OPEN_TELEMETRY=True
OTEL_EXPORTER_OTLP_TRACES_ENDPOINT=http://localhost:4317

Start the DB-GPT webserver:
dbgpt start webserver

Method 2:
Run with docker compose.

Build the image:

bash ./docker/base/build_proxy_image.sh

Start DB-GPT cluster

cd docker/compose_examples/observability

OPENAI_API_KEY="{your api key}" OPENAI_API_BASE="https://api.openai.com/v1" docker compose up -d

Make sure you have set the environment variables OPENAI_API_KEY.
Now, you can access the Jaeger UI at http://localhost:16686 to view the traces.
Snapshots:

Checklist:

[x] My code follows the style guidelines of this project
[x] I have already rebased the commits and make the commit message conform to the project standard.
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have made corresponding changes to the documentation
[x] Any dependent changes have been merged and published in downstream modules


Created Badge components

Overviews
This PR introduces the Badge component used throughout the project, as well as the FilterBadge and CategoryBadge components used on the Foods page.
Review points

Is defining constants for food categories in src/const/foodCategory.ts appropriate? I wonder how we can associate these with the data fetched from the DB.

Screenshots

Note

You can test visually by importing <BadgeUsageExample> to some page.
Although the <Badge> component is currently used in the Foods feature, I decided to place it in src/components/ui/, the project-scope directory, because the definition of the Badge component is very generic.
I haven't checked what the emojis look like on Android devices
Still waiting for the designers to define the accurate sizes of the badge, such as icon sizes, paddings, etc.

I just added one little question but, other than that. great work!! thank you.

@kanta1207 @kotaaaa
Thank you guys for your prompt reviews and comments! I have replied to all of them so please kindly take a look.


Bug - Cloudwatch Alarm Regex Typo

This PR fixes the following issue: https://github.com/sbstjn/sqs-worker-serverless/issues/2

@sbstjn any issues with merging this?

@sbstjn any issues with merging this?

@sbstjn the community has spoken, let's merge :)


Auto comment on issue and self assign the issue

Related Issue
#75
Description
I have deleted the already existing greetings.yml and have made different files for different purposes
Type of PR

[x] Bug fix
[x] Feature enhancement
[x] Documentation update
[ ] Other (specify): _______________

Screenshots / videos (if applicable)
[Attach any relevant screenshots or videos demonstrating the changes]
Checklist:

[x] I have performed a self-review of my code
[x] I have read and followed the Contribution Guidelines.
[x] I have tested the changes thoroughly before submitting this pull request.
[x] I have provided relevant issue numbers, screenshots, and videos after making the changes.
[x] I have commented my code, particularly in hard-to-understand areas.

Additional context:
[Include any additional information or context that might be helpful for reviewers.]

Hello @MohanRamSridhar , Excellent work on this PR! Thank you for your contribution!


Antiforgery token was meant for a different claims-based user than the current user

We have a UseStatusCodePagesWithReExecute middleware in place which executes a 404 error action and returns a view. We have a user-feedback form on all our views (which is also included on the 404 page). The feedback form works fine on every page - BUT - on the 404 page sending feedback runs into:

Microsoft.AspNetCore.Antiforgery.AntiforgeryValidationException:
The provided antiforgery token was meant for a different claims-based user than the current user.

Do we need to do something special in this scenario to make the token valid too?

It would be helpful to understand how the UI flow is like. For example, user had logged in or logged out and when is the 404 happening.

We have a user-feedback form on all our views

Curious, how is the feedback form generated on every view?  using some partial view or something else?

We've debugged the problem further and found the problem:
{code}
app.UseUseStatusCodePagesWithReExecute("/Error");
app.UseCookieAuthentication(...);
{code}
In case of a 404 error the cookie authentication is executed twice and it re-adds the claims although they are already existent. Therefore the ClaimsPrincipal gets the same claims twice and is considered different by the antiforgery token checker.
Is there a way to configure the CookieAuthentication in such a way that it doesn't readd the claims if they already exist?

2.0 should solve this, Cookie auth should avoid the duplication.

So, in 1.x this is a non-supported scenario? :-/

You could put CookieAuth first. CookieAuth doesn't return 403s, it redirects.

Thanks for contacting us. We believe that the question you've raised have been answered. If you still feel a need to continue the discussion, feel free to reopen it and add your comments.


Additional documentation for non-interactive sign-ins

This Docs page has an Important note that says:

"The sign-ins report only displays the interactive sign-ins, that is, sign-ins where a user manually signs in using their username and password. Non-interactive sign-ins, such as service-to-service authentication, are not displayed in the sign-ins report."

It would be helpful if there was additional documentation about non-interactive sign-ins. Are these logged anywhere? We recently noticed that there is no sign-in event generated when users authenticate using the Microsoft Authenticator app. Is this a form of non-interactive sign-ins? I tried searching, but I was not able to find any additional details on Microsoft Docs that answered this question.
Thank you,
David Bird

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 1558e7c0-eaaf-d081-30c3-5c13e0876071
Version Independent ID: 1106c01b-1e4c-5b04-be84-432f99ec4d8f
Content: Sign-in activity reports in the Azure Active Directory portal
Content Source: articles/active-directory/reports-monitoring/concept-sign-ins.md
Service: active-directory
Sub-service: report-monitor
GitHub Login: @MarkusVi
Microsoft Alias: markvi

@dbird03
Thanks for your feedback! We will investigate and update as appropriate.

This is work in progress and will be documented soon.
#please-close


GROOVY-8299: default methods

First incomplete implementation of default methods.

[x] interface with default methods is not seen as trait anymore
[x] stub generation adds default modifier to stub
[x] allow I.super in ResolveVisitor
[x] implement checking I.super.m(2) in static compiler
[x] implement correct bytecode for I.super.m(2) in static compiled code
[x] implement correct method call logic for I.super.m(2) in dynamic compiler

Jochen, looks great to me. I'll rebase and merge tomorrow if no further feedback.

Merged! Thanks!


Question about fluent locale

Hey there,
Currently Im using fluent and it is working great, but I got stuck on a little thing. I want to update some database fields with a cronjob but to do that I need to set locale in the controller to update the country
dependent fields. Is this possible in the current fluent?
Kind regardes

Hi there, I’m not sure which version you’re using but in SS3 you can use Fluent::with_locale and in SS4 it’s FluentState::singleton()->withLocale()

What does fluent except in the callback?

A closure that handles any database writes you want.


gccgo: field selection allows double pointer indirection

cmd/compile and go/types both reject this source file, but gccgo accepts it:
package p

func f() {
        var p **struct { f int }
        p.f = 0
}

See also discussion in #21738.

CC @thanm

I'll take a look


Embed OpenVPN connection

Describe the solution you'd like
It would be good if you could embed an OpenVPN client into the image so that the container boots directly into a tunnel rather than the local network. My use case is I need a linux desktop that connects to a VPN client.
Describe alternatives you've considered
I've tried installing the OpenVPN package within the container as well as standalone VPN applications but both failed (systemd issues, network-manager issues), I have found a firefox extension that will tunnel browser traffic but this isn't ideal as it leaves the OS traffic open.
Additional context
Ideally implement in a similar manner to how haugene/transmission-openvpn package does.

If it's of any assistance, I forked this repo and merged in a selection of the code from haugene/transmission-openvpn. I haven't had a lot of time to work on it, so it's a bit basic in places and I've coded it specifically to work with my VPN provider - however I do believe it could be developed further and made better. I'd used UFW to precent anything that isn't the VPN tunnel going outbound (so no non-VPN leakage), added the transmission daemon to supervisord, and openvpn also gets added to supervisord on container start.
@fcwu thank you for your amazing work - I really love this container! I've just finished merging the v2.0.0 release of your code with the VPN/Transmission components - if I can help with integrating this I'd be happy to help.

@jamesfreeman959 Cool! Could I try your Docker image first? I may not merge your code, because I like to keep this Docker image simple, but I am willing to add a link to your image if it works well~

@fcwu of course! I have tried to maintain full credit for your work in the code but if there's anything you want changing please let me know and I'll fix it. The container works well for me (been using it daily for some months now), but I would certainly welcome more testing (and I can merge in a wider array of VPN providers as in the haugene container if there is sufficient interest.

I have a self-hosting OpenVPN server. After I read haugene's document, I realize

OSX looks not to work. So I change to Ubuntu 20.04 Beta

I need to insert kernel modules (machine on linode not works)

sudo modprobe nf_conntrack_ftp nf_conntrack_netbios_ns nf_nat_ftp iptable_filter tun

Following is my docker run command (very hard to know correct command)

docker run -it --rm --cap-add=NET_ADMIN -e CREATE_TUN_DEVICE=true -v ${PWD}/CLIENTNAME.ovpn:/etc/openvpn/custom/default.ovpn -e OPENVPN_PROVIDER=custom -e OPENVPN_CONFIG=default -e OPENVPN_USERNAME= -e OPENVPN_PASSWORD= -p 6080:80 -v /dev/shm:/dev/shm -v /lib/modules/:/lib/modules/:ro jamesfreeman959/docker-ubuntu-transmission-openvpn-vnc-desktop

I don't know why network not work at startup, but it back by

ufw default allow outgoing

If we have better document and testing, I like OpenVPN as a built-in function. Before this, I also like to know image size after installing OpenVPN.

@fcwu great feedback - so to answer your points and hopefully produce a better image for everyone:
0 & 1. I have only tested this so far on Ubuntu Server LTS releases (not 20.04 yet though - I'll await the final release in a few days). These were normal libvirtd virtual machines running Docker, so I didn't need to insert any kernel modules, but I can see that on another platform this will be necessary. Do you have a recommended or preferred platform for your testing that I should target for testing so I can document required modules?

Good point - I launch the container using a Docker Compose file - here is a sanitized version of mine which hopefully helps - note I'm using MACVLAN networking which isn't necessary, but I like it for the network setup I have at home:

version: '3.2'

services:
  transmission:
    image: jamesfreeman959/docker-ubuntu-transmission-openvpn-vnc-desktop:latest
    environment:
      - OPENVPN_USERNAME=<VPN provider username for OpenVPN>
      - OPENVPN_PASSWORD=<VPN provider password for OpenVPN>
      - OPENVPN_PROVIDER=<VPN Provider directory name (currently I only integrated zoog)>
      - OPENVPN_CONFIG=<VPN provider configuration file>
      - OPENVPN_OPTS=--inactive 3600 --ping 10 --ping-exit 60
      - VNC_PASSWORD=<VNC password>
      - HTTP_PASSWORD=<HTTP password>
      - SSL_PORT=443
#      - RESOLUTION=1920x1080
      - USER=<User account name once container starts>
      - PASSWORD=<Password for above account>
    restart: always
    networks:
      mylan:
        ipv4_address: <IP address>
    hostname: <hostname>
    volumes:
      - config:/home/<username>
      - data:/mnt/data
      - /dev/shm:/dev/shm
      - ssl:/etc/nginx/ssl
    devices:
      - /dev/net/tun:/dev/net/tun
    cap_add:
      - NET_ADMIN
    dns:
      - <IP_ADDRESS>
      - <IP_ADDRESS>
volumes:
  config:
    driver: local
    driver_opts:
      type: nfs
      o: addr=<NFS Server IP address/hostname>,nolock,soft,rw
      device: ":/<config data path on NFS server>"
  ssl:
    driver: local
    driver_opts:
      type: nfs
      o: addr=<NFS Server IP address/hostname>,nolock,soft,rw
      device: ":/<SSL cert path on NFS server>"
  scratch:
    driver: local
    driver_opts:
      type: nfs
      o: addr=<NFS Server IP address/hostname>,nolock,soft,rw
      device: ":/<data path on NFS server>"
networks:
  mylan:
    external:
      name: mylan

I didn't want anything from this container to leak out onto the LAN, so all outbound traffic is blocked by default - however if the VPN comes up the traffic is allowed to flow over the VPN. This could be changed - ufw is configured in rootfs/firewall.sh. I know this setup is crude and I think haugene has improved his container since I started work on this - I haven't had time to port over his improvements yet.

Image size:

$ docker images
REPOSITORY                                                       TAG                 IMAGE ID            CREATED             SIZE
jamesfreeman959/docker-ubuntu-transmission-openvpn-vnc-desktop   latest              79f3a78e8339        4 weeks ago         1.32GB

I hope this helps!

@jamesfreeman959 do you plan to pull request for this?

@fcwu I'm open minded on this. Happy to if my little bit of hacking can enhance your original project. But if you feel it's best to keep it separate then I can do this and will try and enhance the documentation and code as time and interest permits.

@jamesfreeman959 Sure, I would like to make this happen (yes, I am excited anyone PR for new function).
I hope OpenVPN is one of flavors. This repo already has configuration file, such as https://github.com/fcwu/docker-ubuntu-vnc-desktop/tree/develop/flavors, which can install additional package as you needed. You may also create a new doc folder to write the document to introduce how to start image with OpenVPN.
If you are willing to join, I can invite you as collaborator that we can branch and do any modification on the branch. Until we feel the function is mature, I will set auto build on Docker Hub.

@fcwu great - I am really looking forward to working with you.
I reviewed the code in the flavors directory - I can implement the additional packages required in a new file (or set of files) in this directory. How would you like me to add some of my additional scripts (e.g. firewall.sh - won't be required except in the OpenVPN flavor)? Should I package them into a DEB file? Or is maybe we can expand the Jinja2 template to conditionally include some scripts based on the flavor?
I'm finishing off a project this week but I'll be able to make a start on this soon.

You may put firewall.sh or any script into rootfs/usr/local/bin. It's ok even other flavors are not using.

You just gave me an idea. What if we create rootfs/usr/local/<flavor>? Then in the Dockerfile, we add a simple command to merge that with /usr/local (e.g. rootfs/usr/local/openvpn/bin --> /usr/local/bin for the openvpn flavor only? We could do this with a simple rsync/copy command, or something like stow? That way only relevant flavor files are in /usr/local/ depending on the build.

Dockerfile which having a line add rootfs / will put everything into root file system by default. It's fine without modifying Dockerfile, i.e., we put these files in every flavor, if /usr/local/<flavor>/bin is small, probably under 1 MB. If exceeding 1 MB, I prefer put into flavor/openvpn/* and add add line in Dockerfile.

Hi there! So sorry about how long it has taken to get back to you - I was finishing editing a book which is due for release this summer.
So finally I've got a proposal for merging my transmission/OpenVPN container with your original code. I forked your repository again (to start from a clean copy) and then created a branch called "transmission". This has the following changes:

flavors/*.yml now has a new option:

mergeroot: true

If this is set, Dockerfile.j2 will try and also copy from flavors/{{ flavor }}/rootfs and copy this over the top of the rootfs that was copied previously. I have some other ideas for workloads on this container so I wanted to create a framework that was flexible. I like this but you are welcome to tell me otherwise :)

Dockerfile.j2 has been edited according to the above

rootfs/startup.sh is now renamed to startup.j2 - I have added the capability to include additional content from flavors/{{ flavor }}/rootfs/startup.additions so each flavor can have its own unique startup steps.

The change in 3 necessitated an enhancement to jinja2cli - a pull request is open on the project for including files from other directories, but it hasn't been merged in over 12 months. As a result I forked the repo, applied the fix, uploaded it to PyPI, then forked the vikingco container and created my own container. The Makefile now uses this new container.

So far I've been able to test the following:
a. The original builds seem to work as they used to, which was intended - I didn't want to cause any need to edit existing code.
b. I've tried building my code - I can only get it to build with IMAGE=ubuntu:18.04 - if I use 20.04, it fails with a repository error. It looks like one of the repos used in the build hasn't been updated to support focal yet.
c. My build succeeds as follows:
IMAGE=ubuntu:18.04 ARCH=amd64 FLAVOR=lxde-transmission-openvpn make build

However it won't quote start up - I'm seeing:
Traceback (most recent call last):
  File "/usr/local/lib/web/backend/run.py", line 9, in <module>
    from vnc.util import ignored
  File "/usr/local/lib/web/backend/vnc/util.py", line 5, in <module>
    from gevent import GreenletExit
ModuleNotFoundError: No module named 'gevent'
2020-05-27 11:14:33,259 INFO exited: web (exit status 1; not expected)

Not sure if this is something I broke?
TODO:

Complete documentation - I created a Makefile in flavors/lxde-transmission-openvpn with some of the requirements needed to run the container to help users - but as the container won't start I can't be sure if it's complete. Also I remember you said you identified some issues - I'm testing on CentOS 8.1 - are there other systems I should test on?
I'd like to add a README.md to this directory also just explaining a little more about how this flavor works - I'll get this done once the container is working and we're both happy with the development effort.

I haven't created a pull request yet because the code isn't finished, but I wanted to share my progress. I know this is a little different to our discussion and I can change it - I just wanted to demonstrate my proposal to you first. Happy to receive your feedback!

Is this thread still alive or has it been abandoned?

Hi @izzyiceberg - still here - haven't had a lot of time to work on my fork recently - I was quite happy with the direction in which it was heading as I feel I've got a fairly generic framework that can be expanded upon as required. I haven't tried to merge and build @fcwu's latest code yet either so need to revisit that. However if you want to check out the progress on this and have any feedback I'd welcome your input.

I think this is a lightweight webVNC image. It's better to keep it simple and light.
Not a good idea to embed some very specific applications.