k8s.io/client-go vendors k8s.io/apimachinery which breaks build

TL;DR: libraries must not vendor their dependencies
It is not possible to build programs that vendor k8s.io/client-go as the latter has vendored k8s.io/apimachinery.
Sample program:
package main

import (
        "flag"
        "fmt"
        "log"
        "os"
        "path/filepath"
        "time"

        metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
        "k8s.io/client-go/tools/clientcmd"

        "k8s.io/client-go/kubernetes"
)

func main() {
        kubeconfig := flag.String("kubeconfig", filepath.Join(os.Getenv("HOME"), ".kube", "config"), "absolute path to the kubeconfig file")

        flag.Parse()
        // uses the current context in kubeconfig
        config, err := clientcmd.BuildConfigFromFlags("", *kubeconfig)
        check(err)

        clientset, err := kubernetes.NewForConfig(config)
        check(err)

        for {
                pods, err := clientset.Core().Pods("").List(metav1.ListOptions{})
                check(err)

                fmt.Printf("There are %d pods in the cluster\n", len(pods.Items))
                time.Sleep(10 * time.Second)
        }
}

func check(err error) {
        if err != nil {
                log.Fatalf("fatal: %v", err)
        }
}

This program will not compile because the vendored copy of k8s.io/apimachinery (https://github.com/kubernetes/client-go/tree/master/vendor/k8s.io/apimachinery) aliases the copy in my own project, this breaks type equality.
# stash.atlassian.com/scm/kube/rds-resource-provider/cmd/postgres-resource-provider
cmd/postgres-resource-provider/main.go:29: cannot use "stash.atlassian.com/scm/kube/rds-resource-provider/vendor/k8s.io/apimachinery/pkg/apis/meta/v1".ListOptions literal (type "stash.atlassian.com/scm/kube/rds-resource-provider/vendor/k8s.io/apimachinery/pkg/apis/meta/v1".ListOptions) as type "stash.atlassian.com/scm/kube/rds-resource-provider/vendor/k8s.io/client-go/vendor/k8s.io/apimachinery/pkg/apis/meta/v1".ListOptions in argument to clientset.Core().Pods("").List
Makefile:11: recipe for target 'build' failed
make: *** [build] Error 2

TL;DR: go's vendoring system is fundamentally broken.
We are working on switching to the new dep vendoring management tool, after which this should be acceptable. (You'll run dep ensure and it will flatten the dependencies.)
If we don't vendor, then you'll have a very difficult time getting a set of dependencies that actually works. We describe this in the top level README. This is a huge source of pain for us--we just did some code moves to other packages which are causing the current set of difficulties.

(And I know the go doctrine is "have stable public apis and make new repos when you break them" but we are untangling a big ball of spaghetti and that's just totally impractical for us.)

@lavalamp no argument there, vendor/ is utterly broken for library writers. /cc @spf13

We are working on switching to the new dep vendoring management tool, after which this should be acceptable. (You'll run dep ensure and it will flatten the dependencies.)

This tool is marked pre alpha, are you sure that is prudent?
Can you at least update the vendored copy of k8s.io/apimachinery ?

Can you at least update the vendored copy of k8s.io/apimachinery ?

apimachinery updates a lot faster than client-go because of the way the process goes.  client-go is the one that needs updating, but because of the merge queue process its difficult to do.  See my comment here for fixing client-go sync https://github.com/kubernetes/kubernetes/pull/39504#issuecomment-276359358

This program will not compile because the vendored copy of k8s.io/apimachinery (https://github.com/kubernetes/client-go/tree/master/vendor/k8s.io/apimachinery) aliases the copy in my own project

@davecheney do you use a vendor package management tool? Both godep and glide will flatten the dependencies.
However, godep won't handle version conflicts in dependencies. This is why we want to switch to dep or glide, which supports specifying a range of versions, lowing the probability of conflicts.
For now, can you use the release-2.0 branch of client-go? That branch doesn't depend on k8s.io/apimachinary.

dpw/vendetta. I've worked around the issue for the moment.
Please feel free to close this issue.
On Wed, Feb 1, 2017 at 8:39 PM, Chao Xu<EMAIL_ADDRESS>wrote:

This program will not compile because the vendored copy of
k8s.io/apimachinery (https://github.com/kubernetes/client-go/tree/
master/vendor/k8s.io/apimachinery) aliases the copy in my own project
@davecheney https://github.com/davecheney do you use a vendor package
management tool? Both godep and glide will flatten the dependencies.
However, godep won't handle version conflicts in dependencies. This is why
we want to switch to dep or glide, which supports specifying a range of
versions, lowing the probability of conflicts.
For now, can you use the release-2.0 branch of client-go? That branch
doesn't depend on k8s.io/apimachinary.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/kubernetes/client-go/issues/83#issuecomment-276613181,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAAcA0CWgCsBYohiA8mIaGTztY2-Vcoyks5rYFK5gaJpZM4LyGG0
.

A version of client-go with the apimachinery package flattened back out is in github.com/lavalamp/client-go-flat. (go get github.com/lavalamp/client-go-flat should work.)
Is this approach something we should automate and officialize?

Using Glide with its --strip-vendor flag allows me to use kubernetes/client-go together with kubernetes/apimachinery, per @caesarxuchao's suggestion above.

@lavalamp @smarterclayton @liggitt in the experiment you've created here: https://github.com/lavalamp/client-go-flat/, how would another library writer who generated his clients using our client generator against the apimachinery repo go about creating a compatible client? The signatures for anything that uses an apimachinery type like RESTClient https://github.com/kubernetes/kubernetes/blob/master/staging/src/k8s.io/client-go/rest/client.go#L61-L89 will be incompatible.
As we add aggregated API servers, we expect this to be more common, not less.

@lavalamp I think we ought to try to deleting the content of vendor/k8s.io/apimachinery, but leaving its manifest entry present.  With the synchronized rollout that @caesarxuchao is working on, go get-ing from master should give matched sets instead of client-go lagging.  By leaving the manifest entry, anyone trying to vendor would be able to pin the exact version we want.  And we wouldn't face the "we generated incompatible clients" problem.

@deads2k Leaving only apimachinery out of vendor/ is strange. If a user use git clone to download client-go, missing only apimachinery in vendor/ will cause confusion.
The synchronized rollout work (https://github.com/kubernetes/test-infra/pull/1784) will keep client-go/vendor/k8s.io/apimachinery up-to-date, so keeping the whole vendor/ folder is possible.
We could also remove the entire vendor/ folder (https://github.com/kubernetes/client-go/issues/19#issuecomment-276973753), but I see two problems: 1. go get user will get incompatible dependencies. 2. we'll need to provide dependency manifests for multiple vendor package management tools. 2 is solvable, just requires some maintenance efforts.

@caesarxuchao is there another option that will allow different client-go libraries from other projects to inter-operate?

ok, I think flattening out the dependencies like we talked about at the SIG is not a workable plan.
I think our approach should be:

document
users must use a version control tool, dep, glide, or godep
continuously test so that every supported branch always always always works.

I currently need to have set exact revisions of this repo and apimachinery in my glide.yaml, in fact I never wanted to care about two packages and how they relate to each other just about makes sense to me as a user... Looks like master is broken at the moment, and simply referencing latest revisions like I did a few days ago didn't work. Perhaps there are still many usability improvements that are waiting to be implemented. I think basically it's whenever you want to construct a object natively (not from YAML), then you have to pull in apimachinery.

@seh I am also using glide up -v...

I currently need to have set exact revisions of this repo and apimachinery in my glide.yaml, in fact I never wanted to care about two packages and how they relate to each other just about makes sense to me as a user... Looks like master is broken at the moment, and simply referencing latest revisions like I did a few days ago didn't work. Perhaps there are still many usability improvements that are waiting to be implemented. I think basically it's whenever you want to construct a object natively (not from YAML), then you have to pull in apimachinery.

@caesarxuchao has https://github.com/kubernetes/test-infra/pull/1784 to change the client-go publishing infrastructure so that it stops lagging behind.

Current strategy is being worked out in https://docs.google.com/document/d/1h_IBGYPMa8FS0oih4NbVkAMAzM7YTHr76VBcKy1qFbg/edit#

@lavalamp That's not publicly viewable?

It's shared with the api machinery sig group--there should be a link in the
title.
On Mon, Feb 13, 2017 at 11:10 AM, Ruben Vermeersch<EMAIL_ADDRESS>
wrote:

@lavalamp https://github.com/lavalamp That's not publicly viewable?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/kubernetes/client-go/issues/83#issuecomment-279490751,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAnglicvYPxH_Qo3JWUSIJ8NHRu4Nsqeks5rcKqngaJpZM4LyGG0
.

It looks like v2.0.0-alpha.1 doesn't specify a version of k8s.io/apimachinery[0] in it's Godeps file so tools like glide can't determine the version needed. @errordeveloper that's why you're glide command doesn't work.
Here's an attempt to compile the out of cluster example[1]:
$ cat glide.yaml
package: github.com/ericchiang/client-go-example
import:
- package: k8s.io/client-go
  version: v2.0.0-alpha.1
$ ls
glide.yaml  main.go
$ glide up -v
[INFO]	Downloading dependencies. Please wait...
[INFO]	--> Fetching updates for k8s.io/client-go.
[INFO]	--> Setting version for k8s.io/client-go to v2.0.0-alpha.1.
[INFO]	Resolving imports
[INFO]	--> Fetching updates for github.com/go-openapi/spec.
[INFO]	--> Fetching updates for github.com/gogo/protobuf.
[INFO]	--> Fetching updates for github.com/google/gofuzz.
[INFO]	--> Fetching updates for k8s.io/apimachinery.
[INFO]	Found Godeps.json file in /home/eric/.glide/cache/src/https-k8s.io-client-go
[INFO]	--> Parsing Godeps metadata...
# ...
$ go install
./main.go:30: cannot use "github.com/ericchiang/client-go-example/vendor/k8s.io/apimachinery/pkg/apis/meta/v1".ListOptions literal (type "github.com/ericchiang/client-go-example/vendor/k8s.io/apimachinery/pkg/apis/meta/v1".ListOptions) as type "github.com/ericchiang/client-go-example/vendor/k8s.io/client-go/pkg/api/v1".ListOptions in argument to clientset.CoreV1().Pods("").List

Good news, this is fixed on master![2] So installing from that SHA works fine because glide can pull the right version of k8s.io/apimachinery.
$ cat glide.yaml
package: github.com/ericchiang/client-go-example
import:
- package: k8s.io/client-go
  version: 8b466d64c5da37e0d3985b907d812e1f58cb41cb
$ glide up -v
$ go install
# no error

[0] https://github.com/kubernetes/client-go/blob/v2.0.0-alpha.1/Godeps/Godeps.json
[1] https://github.com/kubernetes/client-go/blob/8b466d64c5da37e0d3985b907d812e1f58cb41cb/examples/out-of-cluster/main.go
[2] https://github.com/kubernetes/client-go/blob/8b466d64c5da37e0d3985b907d812e1f58cb41cb/Godeps/Godeps.json#L319

@ericchiang v2.0.0 doesn't depend on k8s.io/apimachinery, why would glide try to import apimachinery?

@caesarxuchao ah my bad.
So master imports k8s.io/apimachinery but v2.0.0-alpha.1 doesn't? I guess I'm confused about what the tag branch means.

Right. v2.0.0 is reflect kuberentes 1.5, when k8s.io/apimanichery doesn't exist yet.

Maybe most of you have seen this already: @lavalamp wrote a good summary about ways to vendor client-go: https://github.com/kubernetes/client-go/blob/master/INSTALL.md

Given my changes to README.md & INSTALL.md, and the fact that @caesarxuchao has cut & blessed the v2.0.0 tag and added some detail to CHANGELOG.md, I think we can finally consider this resolved. Separate issues have been filed for a few remaining tasks (e.g. CI for the install instructions).

@lavalamp I've tried following your instructions in INSTALL.md (I'm one of those pesky users who just wants to use go get and doesn't vendor).
I don't think it's even possible. It states:

If you want to write a simple script, don't care about a reproducible client library install, don't mind getting head (which may be less stable than a particular release) and don't share any dependencies with client-go

It's not possible to not share dependencies. For instance, getting a Pod has the following signature (as part of PodInterface):
Get(name string, options meta_v1.GetOptions) (*v1.Pod, error)

meta_v1 is k8s.io/apimachinery/pkg/apis/meta/v1.
That's hardly obscure as a use case.
I might be doing something wrong, but I don't think it's currently possible to write any meaningful application with just go get.
Am I missing something?

@rubenv thanks for pointing that out. I forgot about it in the stack of other things that were broken.

Is there any version of client-go that actually works? None of the documentation is correct on vendoring and none of the version branches work to actually import with to even get the examples working,
It seems it is now impossible to even use go to build a client for kubernetes anymore?

@lavalamp have you found any time to look into this? It's currently still impossible to use client-go without vendoring.

@rubenv this is being worked on in https://github.com/kubernetes/test-infra/pull/1784 and related PRs by @caesarxuchao.
Until that is merged and runs daily, client-go master branch continues to be kind of broken. Not really satisfying now, but we are getting nearly to a solution.

Cool, subscribing. Thanks a lot for the effort and apologies for the complaining :-)

Now if a user go get k8s.io/client-go in a clean GOPATH (meaning k8s.io/apimachinery doesn't already exist in the GOPATH), (s)he will not hit the problem described in the issue. I think we can consider the issue resolved.

So, I'm sure you all are familiar with https://github.com/ericchiang/k8s, they manage to provide from what I can tell the same functionality with only two dependencies. I am curious from a design perspective what advantage your numerous dependencies have over their two dependency solution?


Online web demo

Work in progress and suggestions are welcome!

Could u share some TODO feature for web demo ?
I'm very interested in this project and have had an idea for a long time, but no time to realize it because of busy work

Could u share some TODO feature for web demo ?
I'm very interested in this project and have had an idea for a long time, but no time to realize it because of busy work

https://colab.research.google.com/drive/12oQcLs25CFjI4evsFlWfKD1DfTEiqyCN?usp=sharing

https://colab.research.google.com/drive/12oQcLs25CFjI4evsFlWfKD1DfTEiqyCN?usp=sharing

Our web demo is online here: http://rebiber.herokuapp.com/


Building On Windows

Is exmagick supported on windows? What is the build process?
Because libtool does not seem to be in choco, and when installing graphicsmagick, exmagick still fails to find graphicsmagick-config, using graphicsmagick 1.3.28.
Here is the log from attempting to build:
https://gist.github.com/Moggers/9f90eb01fc37fabad8af4f4d3fd36b8a
Note, this project is correctly building on linux.

Hi @Moggers,
we've never tested in windows, however the code is fairly portable.
The problem is I don't have much experience in windows, so it may take a while to add support for windows and I would need someone to help testing it.
What is the version of windows your are using? Regarding libtool, I think we can use it on windows, but I don't know if that is a good practice. If you have any advice or want to contribute let me know. Any help is appreciated.
Thanks!
~dsouza

I'd be happy to help with testing, however I'm fiarly new to the elixir ecosystem, and do not know much about windows build tools in general, either. OS is Windows 10.

Ok. Any help is useful :)
I probably can start working on it this weekend. I'll give you updates about the progress ok a weekly basis, as I don't know how much time this will take.
Thanks!
~dsouza

I'll test it on windows this week.


1.11 releases archived

Requirements

Filling out the template is required. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion.
All new code requires tests to ensure against regressions

Description of the Change

Alternate Designs

Why Should This Be In Core?

Benefits

Possible Drawbacks

Verification Process

Applicable Issues

Ъдх ктг


"index.d.ts" missing

Getting the following error upon installing fresh.
typings ERR! message Unable to read typings for "aurelia-configuration". You should check the entry paths in "index.d.ts" are up to date
typings ERR! caused by https://raw.githubusercontent.com/vheissu/aurelia-configuration/master/dist/index.d.ts responded with 404, expected it to equal 200
It looks like the "index.d.ts" file was removed from the master branch. I do see it in 1.0.11.

This is fixed in the latest release.


As an Enterprise Developer account agent, I want to upload to own SFTP instead of AppStore

New Issue Checklist

[ x ] I will do it.
[ x ] Updated fastlane to the latest version
[ x ] I have read the Contribution Guidelines

Feature Description

Reuse existing Deliver implementation
Add fastlane/Repofile with basic configuration
Generate metadata.json from known metadata + Repofile and use working sample of ssh/sftp session to connect using username/password or RSA key.
Import existing metadata.json for correct version bump/bounce

Configuration Files
Repofile:
###################### More Options ######################
# If you want to have even more control, check out the documentation
# https://github.com/fastlane/fastlane/blob/master/deliver/Deliverfile.md

###################### Automatically generated ######################
# Feel free to remove the following line if you use fastlane (which you should)

app_identifier "[[APP_IDENTIFIER]]"
ipa "[[APP_IDENTIFIER]]"
app_version "[[APP_VERSION]]"
meta_title "[[APP_NAME]]"

#
# Authentication
#

# You can use your `~/.ssh/config` file to setup RSA keys to AppRepo, or use following options:

repo_url "repo.teacloud.net"
repo_user "circle"
repo_key "./lib/assets/circle.pub"

# app_identifier "" # your app's bundle identifier

# notify true # Add this to automatically notify the AppRepo users after uploading metadata/binary.

# manifest_path "./manifest.json" # Path to the manifest.json you want to use.

# meta_subtitle "Some application"

# meta_description "Detailed application description."

# app_icon './AppIcon.png'

Environment
$ fastlane -v
/Users/sychram/.rvm/rubies/ruby-2.2-head/lib/ruby/site_ruby/2.2.0/rubygems/specification.rb:2162:in `method_missing': undefined method `this' for #<Gem::Specification:0x3fc971089470 fastlane-1.89.0> (NoMethodError)
	from /Users/sychram/.rvm/rubies/ruby-2.2-head/lib/ruby/site_ruby/2.2.0/rubygems/specification.rb:1057:in `find_active_stub_by_path'
	from /Users/sychram/.rvm/rubies/ruby-2.2-head/lib/ruby/site_ruby/2.2.0/rubygems/core_ext/kernel_require.rb:64:in `require'
	from /Users/sychram/.rvm/gems/ruby-2.2-head@global/gems/fastlane-1.89.0/bin/fastlane:4:in `<top (required)>'
	from /Users/sychram/.rvm/rubies/ruby-2.2-head/bin/fastlane:22:in `load'
	from /Users/sychram/.rvm/rubies/ruby-2.2-head/bin/fastlane:22:in `<main>'
	from /Users/sychram/.rvm/gems/ruby-2.2-head/bin/ruby_executable_hooks:15:in `eval'
	from /Users/sychram/.rvm/gems/ruby-2.2-head/bin/ruby_executable_hooks:15:in `<main>'

Do you use bundler to execute fastlane (i.e. bundle exec fastlane)?
false
Do you use a Ruby environment manager (e.g. chruby, rbenv, rvm)?
rvm on workstation and rbenv on jenkins slave

Hey @suculent, thanks for submitting this issue. This sounds like a great idea, however this is probably something we don't plan on merging into the fastlane main repo. We're currently working on a plugin architecture that enables you to distribute and maintain your own plugins: https://github.com/fastlane/fastlane/issues/4744

Awesome, thanks. I'll try to migrate to that architecture when done with proof-of-concept implementation.

@suculent Really glad to have you checking out our new plugins system. Have a great week!

Thanks, this is a whole great year so far. Could not find lane 'add_plugin apprepo'. 8)
https://github.com/suculent/fastlane-plugin-apprepo

@suculent We'll need some more background, the full log, your config files and more 👍

I have working prototype now, so I'm tweaking options, have to handle existing uploads properly and solve one more rsa issue until it will be ready.
What's the required code validation tool with dog in pink square? I'm using rubocop but there's some more requirement buried somewhere around these docs/threads.
Odesláno z iPhonu

2016 v 0:36, Felix Krause<EMAIL_ADDRESS>

@suculent We'll need some more background, the full log, your config files and more 👍
—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub

Apparently, I have the production branch of fastlane installed, that does not include the plugins-manager.


Automator: update common-files@master in istio/istio@master

Generated by Automator - 2022-06-01T16:19:29+00:00

@istio-testing: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-security-multicluster_istio
f749b13d8b6bd8e4b2c97b266a1309a27842ab6c
link
true
/test integ-security-multicluster_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test integ-security-multicluster_istio


blog: post authors twitter account

I've noticed that after moving out of Medium, fewer people start following me on Medium and Twitter.
Medium followers - very expected. Twitter - not.
We should drive more followers to the author's profiles and @dvcorg profile. Also, we can deploy the email subscription somewhere (it might be not enough to have it on the very bottom of the page).
It can be done by incorporation of author twitter accounts next to author avatar/image or have it on the author page.
@andronovhopf what do you think?
PS: It might be related to #1120

We could have the author names link to their twitter, maybe? Or have a separate link next to the avatar. Both are good.
And yes to adding another field to subscribe to email updates. The only one I can find right now is at the bottom of the community page. Possible we could make a header/hero image for the community page about it?

all good points, we def need subscribe way more visible - some nice pop-up at the very bottom? let's create a separate ticket for this, @andronovhopf ?

I think we can provide the name of the author's name with the link of their twitter handles for mentioned issue.So that users can reach to them by just clicking their name.
Please give suggestions if this is good or any other plan.
And may I work on this issue?

@chaytanyasinha hi! before we jump into implementing this we need to come with some design idea. Where do you see these links fit? can you make a screenshot with an idea? Also, we should keep in mind this related issue #1120

@shcheklein
Actually I was thinking of the author's name with link that just by clicking the name they can move to their handles as I can see it will be quite difficult to fit another column their

@chaytanyasinha so, it'll contradict with #1120 I believe, right?

@shcheklein Yeah right. So any other ideas?

@shcheklein I think @chaytanyasinha's idea would work well as a quick fix while we all work out the design of individual Author pages at #1120. I could implement this very quickly, and it wouldn't be an issue to replace that link when we finally decide what we want on #1120's pages.
Maybe we should have a generic author link field so people can choose which social media page they prefer? I'd also make it optional, of course.

#1341 implements the behavior of Author markdown files accepting an optional link frontmatter field. If specified, their name on blog posts will be a Link component pointing to the value.
The value of link could be anything, but from what I can tell will usually be a Twitter link- in which case, make sure to use the full URL including https://. This is the most basic implementation, but if we want something more advanced I can easily build on it.


Get user bio from Chat ?

Hi All,
Is there a way to get user bio from BotClient ?

Please, read issue templates before posting.


Effect previews flicker if more than 1 output is active

I can't repro this, can you be more specific?

I've seen this but its very hard to repro. Will see if it still exists in outputs_are_nodes_too which substantially changes the way outputs work.

I'm going to close this since I think it is fixed with the recent refactors. Feel free to re-open if it comes back.


CNV-34692: Prevent VM stuck in starting status after detaching disk

📝 Description
Fixes:
https://issues.redhat.com/browse/CNV-34692
Prevent VM getting stuck in "Starting" status in case of detaching a disk that is in error (if PVC is not in "Bound" state, for example if you added wrong url when creating that disk) by disabling Detach button for that specific disk in the VM's Disks list.
🎥 Screenshots
Before:
Possible to detach the problematic disk leading to VM stuck in starting status:

After:
Detach button disabled if the disk is problematic/if PVC is not in Bound state:

@metalice @pcbailey @upalatucci @vojtechszocs please review

/lgtm

/retest


Bug Fix to DM-20254.

Address problem encountered with 'test' stage in Jenkins run.

The PR needs to be rebased on current master.

Rebased per advice.


[hotfix] [flink-parquet] avro parquet logical type fix

What is the purpose of the change
Currently the code doesn't use the specified Avro Model's SpecificData record which means any logicalTypes registered on the avro type are unavailable resulting in an error. This is hot fix since this is an experimental module, and only fixes the current state of things for those that need it.
Brief change log

Remove redundant schema serialization and de-serialization over and over
Make it so it uses the specific model as indicated instead of the generic 'SpecificData' model

Verifying this change
Please make sure both new and modified tests in this PR follows the conventions defined in our code quality guide: https://flink.apache.org/contributing/code-style-and-quality-common.html#testing
This change is already covered by existing tests, such as the modified two tests (adding a logical type)
Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): NO
The public API, i.e., is any changed class annotated with @Public(Evolving): NO
The serializers: YES - writer factory. although experimental
The runtime per-record code paths (performance sensitive): NO
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: NO
The S3 file system connector: NO

Documentation

Does this pull request introduce a new feature? NO
If yes, how is the feature documented? NOT APPLICABLE

@flinkbot run azure

@AlexRiedler Thanks for the PR, but this shouldn't be a hotfix but requires a proper Jira


Setting a controller number?

I have a wired Xbox360 controller connected to my PC. In settings, I selected "Use Xinput Ports 2-5" so that DS4Windows would never steal the slot from my Xbox360 controller. Instead, it always steals slot 1.
In Profiles, I set "Use Controller 2 for Mappings and readout x" in the Other section, but the number here is not saved when I click Save Profile and re-open the profile. The checkbox after "readout" is saved. Unchecking it does not prevent DS4Windows from stealing slot 1.
If I set "Use Xinput Ports 3-6" or "Use Xinput Ports 1-4", DS4Windows no longer steals slot 1.
I am determining which controller is in which slot using Joy2Key.
Not sure what version of DS4Windows I have. I ran the autoupdater today.

I'm not sure what your issue is, but as a note:
"Use Controller X for Mappings and readout" is for seeing which controller is used for setting keys to actions (as in when you press a button a controller the select a key window comes up for that controller) and readouts in the last tab of the profile settings.

Sorry, I guess there are two issues:

"Use Xinput Ports 2-5" doesn't work as I expect. (With it enabled, I'd expect DS4 to never use port 1.)
"Use Controller 2 for Mappings and readout x" wasn't saving the number. (From your description its sounds like it's only temporary for configuration.)

I haven't tried this recently, so I'll have another look with a more recent version.

What Xinput Ports means is that it gets free for other programs to use said emulated port, however the controllers are still numbered in games by the order they are connected.


Latest version of markdown breaks chalice deployments in github workflows

Sample Repo with workflow to reproduce the issue:
https://github.com/apfromiit/markdown-github-workflow
Workflow fails with markdown==3.3.5
Workflow runs successfully with markdown==3.3.4
Latest version of markdown breaks chalice deployment in github actions
Workflow: https://github.com/apfromiit/markdown-github-workflow/blob/master/.github/workflows/chalice-deploy.yml
Result: https://github.com/apfromiit/markdown-github-workflow/runs/4229057005?check_suite_focus=true
Refer the workflow in .github/workflows/
Steps to reproduce:

Fork the repo
Add AWS secrets to forked repo
Modify Readme (to make some trivial changes to create dummy commit)
git commit and push to master branch
Check Github Actions in repo.

Github workflow fails with below logs during chalice deploy step.
Logs:
Traceback (most recent call last):
  File "/home/runner/.local/lib/python3.8/site-packages/chalice/cli/__init__.py", line 636, in main
    return cli(obj={})
  File "/usr/lib/python3/dist-packages/click/core.py", line 764, in __call__
    return self.main(*args, **kwargs)
  File "/usr/lib/python3/dist-packages/click/core.py", line 717, in main
    rv = self.invoke(ctx)
  File "/usr/lib/python3/dist-packages/click/core.py", line 1137, in invoke
    return _process_result(sub_ctx.command.invoke(sub_ctx))
  File "/usr/lib/python3/dist-packages/click/core.py", line 956, in invoke
    return ctx.invoke(self.callback, **ctx.params)
  File "/usr/lib/python3/dist-packages/click/core.py", line 555, in invoke
    return callback(*args, **kwargs)
  File "/usr/lib/python3/dist-packages/click/decorators.py", line 17, in new_func
    return f(get_current_context(), *args, **kwargs)
  File "/home/runner/.local/lib/python3.8/site-packages/chalice/cli/__init__.py", line 189, in deploy
    deployed_values = d.deploy(config, chalice_stage_name=stage)
  File "/home/runner/.local/lib/python3.8/site-packages/chalice/deploy/deployer.py", line 376, in deploy
    return self._deploy(config, chalice_stage_name)
  File "/home/runner/.local/lib/python3.8/site-packages/chalice/deploy/deployer.py", line 382, in _deploy
    self._validate_config(config)
  File "/home/runner/.local/lib/python3.8/site-packages/chalice/deploy/deployer.py", line 408, in _validate_config
    validate_configuration(config)
  File "/home/runner/.local/lib/python3.8/site-packages/chalice/deploy/validate.py", line 41, in validate_configuration
    routes = config.chalice_app.routes
  File "/home/runner/.local/lib/python3.8/site-packages/chalice/config.py", line 141, in chalice_app
    app = v()
  File "/home/runner/.local/lib/python3.8/site-packages/chalice/cli/factory.py", line 277, in load_chalice_app
    app = importlib.import_module('app')
  File "/usr/lib/python3.8/importlib/__init__.py", line 127, in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
  File "<frozen importlib._bootstrap>", line 1014, in _gcd_import
  File "<frozen importlib._bootstrap>", line 991, in _find_and_load
  File "<frozen importlib._bootstrap>", line 975, in _find_and_load_unlocked
  File "<frozen importlib._bootstrap>", line 671, in _load_unlocked
  File "<frozen importlib._bootstrap_external>", line 848, in exec_module
  File "<frozen importlib._bootstrap>", line 219, in _call_with_frames_removed
  File "/home/runner/work/markdown-github-workflow/markdown-github-workflow/app.py", line 2, in <module>
    from markdown import markdown
  File "/home/runner/.local/lib/python3.8/site-packages/markdown/__init__.py", line 29, in <module>
    from .core import Markdown, markdown, markdownFromFile  # noqa: E402
  File "/home/runner/.local/lib/python3.8/site-packages/markdown/core.py", line 26, in <module>
    from . import util
  File "/home/runner/.local/lib/python3.8/site-packages/markdown/util.py", line 88, in <module>
    INSTALLED_EXTENSIONS = metadata.entry_points(group='markdown.extensions')
TypeError: entry_points() got an unexpected keyword argument 'group'

Error: Process completed with exit code 2.

I'm not sure what chalice is, but I assume that the new requirement isn't installed? install_requires=["importlib-metadata>='4.4';python_version<'3.10'"],.  It is difficult to tell without seeing the dependencies from your current failing process.

I can confirm this issue (not using charlice)
 File "/home/runner/.local/lib/python3.8/site-packages/markdown/__init__.py", line 29, in <module>
    from .core import Markdown, markdown, markdownFromFile  # noqa: E402
  File "/home/runner/.local/lib/python3.8/site-packages/markdown/core.py", line 26, in <module>
    from . import util
  File "/home/runner/.local/lib/python3.8/site-packages/markdown/util.py", line 88, in <module>
    INSTALLED_EXTENSIONS = metadata.entry_points(group='markdown.extensions')
TypeError: entry_points() got an unexpected keyword argument 'group'

while the pip install reports:
Requirement already satisfied: importlib-metadata>='4.4'; python_version < "3.10" in /usr/lib/python3/dist-packages (from markdown->-r napari-hub/backend/requirements.txt (line 8)) (1.5.0)

this is reproduced from github action using ubuntu-latest runner

I'm confused, what version is it using? It seems to suggest 1.5.0, not 4.4.  Can you post the version that is being used?

I'm confused, what version is it using? It seems to suggest 1.5.0, not 4.4. Can you post the version that is being used?

likewise, I think the version installed is 1.5.0, but pip takes that as a pass for version check.
I am not a pip expert but could it be the quote in the requirement being problematic in the version matching, should we change it to without quote?
install_requires=["importlib-metadata>=4.4;python_version<3.10"],

Hmm, maybe. I don't usually use the quotes, so I'm don't quite sure why it's being used in setup like that. Maybe create a branch with the change and see if you include that git branch as your Markdown dependency if the issue goes away.
markdown @ git+https://github.com/My-Fork/markdown.git@somebranch

Hmm, maybe. I don't usually use the quotes, so I'm don't quite sure why it's being used in setup like that. Maybe create a branch with the change and see if you include that git branch as your Markdown dependency if the issue goes away.
markdown @ git+https://github.com/My-Fork/markdown.git@somebranch

I tried out on my fork, and pip correctly install a later version of importlib-metadata when quotes are dropped: https://github.com/Python-Markdown/markdown/pull/1197

I ran into the same problem today, it appears to be a Python 3.8.x issue, I was able to successfully run actions with 3.10.x

I ran into the same problem today, it appears to be a Python 3.8.x issue, I was able to successfully run actions with 3.10.x

according to the import
the util for 3.10 would use the latest importlib instead, so it would not run into the dependency issue indeed

I tried out on my fork, and pip correctly install a later version of importlib-metadata when quotes are dropped: #1197

Perfect, then a PR would be great.

I tried out on my fork, and pip correctly install a later version of importlib-metadata when quotes are dropped: #1197

Perfect, then a PR would be great.

opened #1197 already, not sure what is the process since I am first time contributing to this repo, it seems someone need to grant permission to the workflow run 😄

I gave it permission to run. I'll let @waylan take a look and decide the next steps.

I'm not sure what chalice is, but I assume that the new requirement isn't installed? install_requires=["importlib-metadata>='4.4';python_version<'3.10'"],. It is difficult to tell without seeing the dependencies from your current failing process.

Log from failing workflow:
Requirement already satisfied: importlib-metadata>='4.4'; python_version < "3.10" in /usr/lib/python3/dist-packages (from markdown==3.3.5->-r requirements.txt (line 2)) (1.5.0)

@apfromiit, yeah, that is the same as @potating-potato's results. It is possible that #1197 will fix it.

just chiming in here - the latest version also broke Airflow 2.0.2 (the version supported by MWAA) if the Markdown version wasn't fixed to 3.3.4

Seeing similar breakage for 3.10 and 3.6 python versions when testing Roundup Issue Tracker. Tests pass with python 3.9 and 3.8.

@rouilj There shouldn't be any kind of breakage for 3.10 as it will use the default, built-in importlib.meta, or it at least should. I would test the current PR branch to see if it fixes your issue (#1197). If we don't get any testing, we can't fix anything for your use case.

https://github.com/apfromiit/markdown-github-workflow/commit/88f83457525dfd957302ce8315b779174404e824
https://github.com/apfromiit/markdown-github-workflow/actions/runs/1473009857
Workflow runs successfully with new version 3.3.6
Thanks everyone for quick resolution!


Please correct the description of "Scan files on the network"

[Enter feedback here]
Please correct the description of "Scan files on the network"
Please correct the following statements.
━━━━━━━━━━━━━━━━━━━━
Policy items and locations:
Scan files on the network
Scan > Scan network files
Default setting (if not configured):
Disabled
━━━━━━━━━━━━━━━━━━━━
Please correct as follows.
Current statement:
Default setting (if not configured): Disabled
Correct:
Default setting (if not configured) Enabled
Why it needs to be fixed:
I've checked the spec internally and confirmed that it will be enabled if I don't configure it.
A customer requested a fix. Please correct it.

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 292d5bf4-ff14-4cbe-eab1-3fe35cb5c1c9
Version Independent ID: 782db2b2-0a15-941c-24ff-345ecfe694f3
Content: Configure scanning options for Microsoft Defender Antivirus
Content Source: microsoft-365/security/defender-endpoint/configure-advanced-scan-types-microsoft-defender-antivirus.md
Service: microsoft-365-security
Sub-service: mde
GitHub Login: @denisebmsft
Microsoft Alias: deniseb

@narkuroki Thank you for your feedback. We have made changes to the document via PR#https://github.com/MicrosoftDocs/microsoft-365-docs/pull/10914
Once the author approves, the changes will be live.
Thanks
Sri

@yogkumgit The PR is merged and can be closed.
Thanks
Sri

@msbemba Thank you very much for the contribution and updating the documentation with PR. @narkuroki Hope this update is helpful for you. Thanks for taking out some time to open the issue. Appreciate and encourage you to do the same in future also.


Suspected dependency on HIT beamer theme

Thank you for sharing this amazing work! well however there seems to be a weird dependency on HIT's theme...which nonetheless doesn't affect installing IF the corresponding 'hitszbeamer.dtx' is paste into the folder
Output when trying "make doc" in terminal(macOS):
thubeamer % make doc xelatex hitszbeamer.dtx This is XeTeX, Version 3.14159265-2.6-0.999991 (TeX Live 2019) (preloaded format=xelatex)  restricted \write18 enabled. entering extended mode ! I can't find file 'hitszbeamer.dtx'. <*> hitszbeamer.dtx

Thanks for pointing out this problem. The package uploaded to CTAN has this problem, which was corrected in this repo. Please kindly use the Makefile provided here.

Hello, the weird dependency on HIT's theme is a bug in Makefile. I forgot to correct it when modifying that file from hitszbeamer package. When I noticed this bug, this package was already uploaded to CTAN. I'll upload a new version of this template soon to CTAN concerning two issues.


CI tasks parsing

Current CI command reads both symphony YAML and also YAML in ci_tasks directory, each of these YAMLs defines a task that can be run in CI mode
These files will need to be parsed, and will form the core of the ci command implementation. Once the file is passed it takes the extra params from symphony YAML (e.g. working directory, path to vars, level etc) and executes the task by dropping down to the shell
For terraform commands I think tf-exec should be used rather shell
This task is just for parsing the YAML
Building the task runner is in task xxxx

resolved by #28


[BUG]EndToEndTimeout duration is not being used for readMany

Issue:
CosmosEndToEndOperationLatencyPolicyConfig timeout is not applied to readMany.

I think this has been fixed


Working LR assembly subwf

This is the first push for a working LR assembly workflow. APOLOGIES, I am aware it's massive.
1/2 "natural" things haven't been added yet (e.g. LR-specific tests) but I will work on it in the next days (suggestions appreciated). A few "less natural" things will be discussed during EMG meeting on the 9th of December, they are listed below. If any bigger topic comes to mind please let me know! It will be good to discuss about this all together.
A general description of the pipeline:

It starts with general qc modules and evaluation
Depending on raw-reads quality and sequencing platform, reads branch out to four different assembly subwfs.
If the dataset was low quality, frameshift correction is applied to contigs
Generated assemblies converge into post-assembly decontamination and coverage calculation

The workflow is represented here.
A few practical notes/issues I would like to raise:

Some tools need zipped files as input, some others unzipped. I patched this when needed, but is there a standard way to handle this?
Could someone point me to examples to handle tool specific failures? e.g. proovframe fix generating empty files leads to pipeline failure
Hifiadapterfilt has been accepted by bioconda, I am waiting for the module to be up to finalise the nf-core module
Names given to minimap to differentiate output files are a draft, and can be improved. I would like to find an agreement for the naming in SR and LR
I created a samplesheet covering all 4 assembly subwfs, it's the one called "long_reads".
Sometimes, Proovframe doesn't seem to remember previous executions when using -resume. Is there some config I should add to the nf-core module?

Things I'd like to discuss at EMG:

How to structure the output folder / what files to keep
Add any extra criteria to filter out low-quality reads/samples
Would other tools be better suited (e.g. hifiasm assembler for PB HiFi [this one in particular would be an easy substitution]).
Refine the frameshift correction subwf:

Taking inspiration from Martin H.'s pipeline, I added an ideel module to evaluate frameshift correction. However this entails running prokka+diamond on contigs twice (before and after). Do we want to keep both? Is there any way we could keep annotations for the final assembly and have them inherited in the assembly analysis pipeline?
Which db should we use for protein curation, Swissprot or TREMBL (curated, but smaller vs non-curated but bigger)
The pipeline provides support to generate your own db, but the idea is to store our default db somewhere on the cluster.

PR checklist

[x] This comment contains a description of changes (with reason).
[ ] If you've fixed a bug or added code that should be tested, add tests!
[ ] If you've added a new tool - have you followed the pipeline conventions in the contribution docs
[ ] Make sure your code lints (nf-core lint).
[ ] Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
[ ] Check for unexpected warnings in debug mode (nextflow run . -profile debug,test,docker --outdir <OUTDIR>).
[ ] README.md is updated (including new tool citations and authors/contributors).

@Ge94, could you paste here or just prepare for meeting output structure of LR and SR pipelines for comparison, please


Update  READMEs of nva stages

The READMEs for the two nva stages (2-networking-c-nva, 2-networking-e-nva-bgp) are out-of-date wrt to what they do.
A few examples of things that are no longer true:

PSA ranges created by default
Proxy only subnets created by default
Some ranges announced to onprem

and probably some more.

At least Some ranges announced to onprem is true for all networking stages, driven by the refactor of the VPN GW variable.


Migrates the dockerfile to alpine

We could increase the space a bit more if we optimize our deployment, but cutting out ~200MB just by switching the OS is a pretty good start.

This PR also ups the version of the login action to v3


How do I fix it?  502 Bad Gateway

Version: anything_3_webui_colab.ipynb
Traceback (most recent call last):
File "launch.py", line 299, in
start()
File "launch.py", line 292, in start
webui.webui()
File "/content/stable-diffusion-webui/webui.py", line 163, in webui
app.add_middleware(GZipMiddleware, minimum_size=1000)
File "/usr/local/lib/python3.8/dist-packages/starlette/applications.py", line 135, in add_middleware
raise RuntimeError("Cannot add middleware after an application has started")
RuntimeError: Cannot add middleware after an application has started
How do I fix it?  502 Bad Gateway..

make sure to use the latest version from this repo. it should fix that problem

Thanks! Now it's working!


Add support for NS and NB sections.

As of January 1, 2023, NB and NS are now valid VE sections. In deference to the shortness of time before Winter Field day,  if NB or NS is received, perhaps MAR could be counted. This is the latest list of the ARRL sections: https://contests.arrl.org/contestmultipliers.php?a=wve

commit 65d620f removes the MAR shape and adds NB and NS.
It might work.  I have not tested it.  The regions are properly indicated on the map.
Manipulating the shape files is difficult for me. QGIS and I do not get along.
Please let me know if you have time to try it.

This seems to work fine. Thanks for getting it so fast.

YW.  Winter field day is soon!  Good luck.


MSL: Unable to dynamically access an incoming gl_ClipDistance array under tessellation

SPIR-V conversion to MSL fails with error:
MSL conversion error: Trying to dynamically index into an array interface variable in tessellation. This is currently unsupported.

The attempt in GLSL results in gl_in[0].gl_ClipDistance[_80], but in MSL main0_in, the incoming gl_ClipDistance array is flattened in to float gl_ClipDistance_0 [[attribute(8)]];.
Is this the result of a known limitation in MSL, or is it something we can enhance SPIRV-Cross to emit and access the incoming gl_ClipDistance as an array? @cdavis5e
These CTS test fail as a result:
dEQP-VK.tessellation.user_defined_io.per_vertex_block.vertex_io_array_size_implicit.triangles
dEQP-VK.tessellation.user_defined_io.per_vertex_block.vertex_io_array_size_implicit.quads
dEQP-VK.tessellation.user_defined_io.per_vertex_block.vertex_io_array_size_shader_builtin.triangles
dEQP-VK.tessellation.user_defined_io.per_vertex_block.vertex_io_array_size_shader_builtin.quads
dEQP-VK.tessellation.user_defined_io.per_vertex_block.vertex_io_array_size_spec_min.triangles
dEQP-VK.tessellation.user_defined_io.per_vertex_block.vertex_io_array_size_spec_min.quads
dEQP-VK.clipping.user_defined.clip_distance_dynamic_index.vert_tess.1
dEQP-VK.clipping.user_defined.clip_distance_dynamic_index.vert_tess.1_fragmentshader_read
dEQP-VK.clipping.user_defined.clip_distance_dynamic_index.vert_tess.2
dEQP-VK.clipping.user_defined.clip_distance_dynamic_index.vert_tess.2_fragmentshader_read
dEQP-VK.clipping.user_defined.clip_distance_dynamic_index.vert_tess.3
dEQP-VK.clipping.user_defined.clip_distance_dynamic_index.vert_tess.3_fragmentshader_read
dEQP-VK.clipping.user_defined.clip_distance_dynamic_index.vert_tess.4
dEQP-VK.clipping.user_defined.clip_distance_dynamic_index.vert_tess.4_fragmentshader_read
dEQP-VK.clipping.user_defined.clip_distance_dynamic_index.vert_tess.5
dEQP-VK.clipping.user_defined.clip_distance_dynamic_index.vert_tess.6_fragmentshader_read
dEQP-VK.clipping.user_defined.clip_distance_dynamic_index.vert_tess.6
dEQP-VK.clipping.user_defined.clip_distance_dynamic_index.vert_tess.6_fragmentshader_read
dEQP-VK.clipping.user_defined.clip_distance_dynamic_index.vert_tess.7
dEQP-VK.clipping.user_defined.clip_distance_dynamic_index.vert_tess.7_fragmentshader_read
dEQP-VK.clipping.user_defined.clip_distance_dynamic_index.vert_tess.8
dEQP-VK.clipping.user_defined.clip_distance_dynamic_index.vert_tess.8_fragmentshader_read
dEQP-VK.clipping.user_defined.clip_cull_distance_dynamic_index.vert_tess.8
dEQP-VK.clipping.user_defined.clip_cull_distance_dynamic_index.vert_tess.8_fragmentshader_read

SPIR-V file:
tess_dyn_idx_clip_dist.spv.zip

Is this the result of a known limitation in MSL

Yes and no. In the fragment shader case, it is, because MSL doesn't allow arrays to be used for shader stage I/O, other than for the express purpose of outputting [[clip_distance]]s from a vertex shader. In the tessellation shader case, it's more because remapping the access chains in this case got very hairy.

is it something we can enhance SPIRV-Cross to emit and access the incoming gl_ClipDistance as an array?

Theoretically, yes. For fragment shaders, we could declare an array to hold the incoming clip distances and index that. For tessellation shaders, we could just declare the clip distances as an array, since it's just a regular buffer. Remapping the access chain in this case could be problematic.

This is an absolute nightmare to handle. One way to handle this perhaps would be to think outside the box. If the cull/clip count can be limited to 4, we could read it as a float4 attribute, which allows us to index it properly.

Nah, minspec is 8 :\

However...if this was the most appropriate solution, then the portability extension could define and return the lower value of 4 for maxClipDistances.

Just dumping some thoughts, unsure how feasible it could be.
What about having the array decomposed into a structure with members and then building a local array in the next stage with said structure. I believe Metal should be okay with this?
Example:
Vertex GLSL
// Whatever inputs for position

layout(location = 0) out vec2 outSomeData[10];

void main()
{
    // Set position and fill outSomeData
}

Metal equivalent
// Input structure

// Our defined structure to handle the array
struct outSomeDataStructure {
    float2 value0;
    float2 value1;
    // ...
    float2 value9;
};
struct MyVertexOut {
    // position
    outSomeDataStructure outSomeData
};
vertex MyVertexOut myVertex(MyVertexIn in [[stage_in]])
{
    vec2 tempSomeDataStructure[10] = { 0 };
    // Fill tempSomeDataStructure as in GLSL

    // Copy tempSomeDataStructure to output struct
    result.outSomeData.value0 = tempSomeDataStructure[0];
    result.outSomeData.value1 = tempSomeDataStructure[1];
    // ...
    result.outSomeData.value9 = tempSomeDataStructure[9];
}

Same thing applies for the fragment, but the other way around, we need to first fill the local array. There's no real need to have a structure just for the array in GLSL and directly add the values to the output structure in Metal.
While the approach may not be the best, it should be a good enough workaround at the cost of some performance.
As of now, more tests than the ones mentioned in the original report of the issue are affected by this and make them fail (Vulkan 1.0 example):
dEQP-VK.pipeline.monolithic.multisample_interpolation.nonuniform_interpolant_indexing.centroid
dEQP-VK.pipeline.monolithic.multisample_interpolation.nonuniform_interpolant_indexing.sample
dEQP-VK.pipeline.monolithic.multisample_interpolation.nonuniform_interpolant_indexing.offset

Let me know your thoughts!

However...if this was the most appropriate solution, then the portability extension could define and return the lower value of 4 for maxClipDistances.

I don't think that helps the tests that Aito mentioned?
https://github.com/ncesario-lunarg/SPIRV-Cross/tree/issue-1796 is a very rough hack that attempts to address the general "indexing into an array with pull interpolants" problem. This is done by creating a new array for each interpolation operation seen, for each input array. This is obviously not ideal from a size and perf standpoint, but I'm not sure how one could fix this in general otherwise. The change referenced appears to get all of the tests posted here passing with the exception of tests that involve interpolateAtOffset.
@HansKristian-Work if you get a chance to take a look, could you please advise on whether this approach is worth pursuing, or if you would rather go a different route here?

FWIW...
The 24 CTS failures in the OP above are no longer occurring.
The 3 additional CTS failures that @aitor-lunarg added:
dEQP-VK.pipeline.monolithic.multisample_interpolation.nonuniform_interpolant_indexing.centroid
dEQP-VK.pipeline.monolithic.multisample_interpolation.nonuniform_interpolant_indexing.sample
dEQP-VK.pipeline.monolithic.multisample_interpolation.nonuniform_interpolant_indexing.offset

are still occurring, but report a different error:
SPIR-V to MSL conversion error: Trying to dynamically index into an array interface variable using pull-model interpolation. This is currently unsupported.

Thanks for taking a look @billhollings. I must have had an old version of CTS and/or MoltenVK on my system as I'm pretty sure those were not passing when I first looked at this 🤷♂ .
This change is for the general case of passing arrays between shader stages. It fixes the "sample" and "centroid" cases Aitor referenced, but not the "offset" case. For the offset case (and in general), some constant propagation would do the trick, unless we could perhaps use something like spirv-opt in MoltenVK before passing the spirv to spirv-cross?


Add support to file extensions

Hello,
I'm using the latest version of the ngx-uploader (4.2.4) and I was wondering if you have in mind adding support to restrict the file extensions, as it is already implemented with content types.
I think content types are more limited, because two different file extensions can have the same content type.
As an example, and you can test it in the component, if you upload a .xlx file and a .csv file, the will have the same content type.
Thanks in advance!

if I understand correctly you want to limit the upload only to particular file extensions?
I have just solved by declaring the variable 'options' in the affected component:
this.options = {concurrency: 0, allowedContentTypes: ['image / png']};
instead of 'image / png' you can enter the types of file extensions you are interested in, the complete list can be found here:
Wiki MIME
Now instead I'm looking for how to see only the files with the correct extension in the selection window, I've already added accept = ". png" but the window shows both png and unknown (so all the files)
I hope this will help you :-D


cmake: fix darwin bootstrapping

Motivation for this change
NOTE I only tested the bootstrap cmake at this point, but this might unblock staging-next.
Fixes #56244
/cc @FRidh @vcunat
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[ ] NixOS
[x] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Assured whether relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

Nitpick: what about applying darwin-only patches only on darwin?  That way we won't need to rebuild elsewhere when touching them (in future).

I'm not a fan of conditional patches, but I could make this a darwin only change if we don't want to rebuild linux packages on staging-next right now.

Well, it's perhaps no big deal, as it's darwin that's the significant bottleneck.  If we had linux-specific patches that occasionally change and cause mass darwin rebuilds, that would be different.

My build isn't done yet, but no errors so far.

Our bigmac will surely be better for this stuff, and it was idling now anyway.


Possible to get the SANs for certs that are in "Pending Request" on a CA?

This first set of code does get the request, but you can't see the SANs.
$pendingCertificates = Get-CertificationAuthority -ComputerName MyCA | Get-PendingRequest
if ($pendingCertificates.'Request.SubmittedWhen' -gt 0)
This looks strange but Co-worker and I came up with this:
$Requests = Get-CertificationAuthority -ComputerName MyCA | Get-PendingRequest
ForEach ($Request In $Requests) {
$Subject = $Request.'Request.CommonName'
$Requester = $Request.'Request.RequesterName'
$Date = $Request.'Request.SubmittedWhen'
If ($RawExtension = Get-CertificationAuthority -ComputerName MyCA | Get-AdcsDatabaseRow -Table Extension -Filter "ExtensionRequestId -eq $($Request.RequestID)" | Where ExtensionName -eq "<IP_ADDRESS>") {
$RawSANs = $RawExtension.Properties.Item("ExtensionRawValue")
$SANs = [Text.Encoding]::Utf8.GetString([Convert]::FromBase64String($RawSANs)) -split '�'
$SANs = $SANs[1..($SANs.Count-1)] -join ","
}Else{
$SANs = ''
}
"Subject: $Subject"
"Requested by: $Requester"
"Date: $Date"
"SANs: $SANs"
""
}

This line is incorrect:
$SANs = [Text.Encoding]::Utf8.GetString([Convert]::FromBase64String($RawSANs)) -split '�'

$RawSANs variable contains ASN.1-encoded SAN extension, you can't simply convert it to UTF-8 string. You have to decode the extension first:
$asnData = [System.Security.Cryptography.AsnEncodedData]::new([convert]::FromBase64String($RawSANs))
$SANs = new-object System.Security.Cryptography.X509Certificates.X509SubjectAlternativeNamesExtension $asnData,$false

Thank you, helps a lot. I'm trying to get all these data into a Table so I can create an email alert that is sent to us to inspect the certificate request before approving. Happy to know the best way to achieve this?

@Venom-Host Try the following code:
# Get pending requests
$Requests = Get-CertificationAuthority -ComputerName MyCA | Get-PendingRequest

foreach ($Request in $Requests) {
    # Get the SAN
    $BinRequest = [convert]::FromBase64String($Request.Properties["Request.RawRequest"])
    $RequestRaw = Get-CertificateRequest -RawRequest $BinRequest
    $SANObject = $RequestRaw.Extensions["<IP_ADDRESS>"]
    # Do stuff with the SANObject
    $SANObject
}


fix link

closes https://github.com/MicrosoftDocs/OfficeDocs-SharePoint/issues/3883

@kelleyvice-msft
PR has been copyedited and is ready for final review, could you please check and merge? Thanks!

@kelleyvice-msft
PR has been copyedited and is ready for final review, could you please check and merge? Thanks!

@kelleyvice-msft
PR has been copyedited and is ready for final review, could you please check and merge? Thanks!


Fixed flaky tests

Description
Fixed a flaky test causes by non-deterministic concurrent map
Reason of change
Folllowing tests are flaky and failing:
org.apache.iotdb.cluster.log.snapshot.PullSnapshotTaskTest#testWithRetry
org.apache.iotdb.cluster.log.snapshot.MetaSimpleSnapshotTest#testSerialize
org.apache.iotdb.cluster.query.reader.mult.AssignPathManagedMergeReaderTest#testMultManagerMergeRemoteSeriesReader
org.apache.iotdb.cluster.query.reader.mult.RemoteMultSeriesReaderTest#testSyncMultSeriesReader
org.apache.iotdb.cluster.query.reader.mult.RemoteMultSeriesReaderTest#testAsyncMultSeriesReader

when running
mvn -pl cluster edu.illinois:nondex-maven-plugin:1.1.2:nondex -Dtest=*TESTNAME*
The tests are flaky because in serialize() method, it uses a concurrent map to store nodeSlot which returns
non deterministic results for each run. To fix this, I changed the concurrent map to Collections.synchronizedMap(new LinkedHashMap()) to ensure the orders and the threads' safety instead of just using LinkedHashMap().

This PR has:

[X] been self-reviewed.

[X] concurrent read
[X] concurrent write
[X] concurrent read and write

[ ] added documentation for new or modified features or behaviors.
[ ] added Javadocs for most classes and all non-trivial methods.
[ ] added or updated version, license, or notice information
[ ] added comments explaining the "why" and the intent of the code wherever would not be obvious
for an unfamiliar reader.
[ ] added unit tests or modified existing tests to cover new code paths, ensuring the threshold
for code coverage.
[ ] added integration tests.
[ ] been tested in a test IoTDB cluster.

Key changed/added classes (or packages if there are too many classes) in this PR

Thanks for your job. However, I can not get your point, are you going to keep the order of map elements? if we use Collections.synchronizedMap relpace the ConcurrentHashMap, which may occur ConcurrentModificationException.

Yeah I understand your concerns. The order of the map elements keeps the same and pass for the regular runs, but the order can't be guaranteed when running NonDex tests because ConcurrentHashMap. If using ConcurrentHashMap is the best in this situation as you mentioned the exception, it would be better to change the test code in that doesn't require orders, otherwise the tests will be keep flaky when running.

Thanks for your job. However, I can not get your point, are you going to keep the order of map elements? if we use Collections.synchronizedMap relpace the ConcurrentHashMap, which may occur ConcurrentModificationException.

Originally I was thinking about using just LinkedHashMap but it not thread safe, so that's why I choose to use Collections.synchronizedMap.


#25 operation and message templates hide schema example and show formatted example

I ran all given tests (including the one I added) before and after changes, and checked outputs with kdiff. This only touches the html template. Hopefully this commit PR is OK, I realize that I kind of just appeared out from nowhere!

This looks good to me @my0n. Thanks for taking the time to fix it, really appreciate.


Add a new category Sliding Window and also include the question on longest substring with k unique characters.

Hi, I would like to contribute to the project by making a new folder for sliding window technique. I would also like to add a question
on the same.
Please assign this issue to me and add Hacktoberfest label to it.

@MuditWadhwa
wait for the first one , will assing you .

I would like to contribute a question in the sliding window category(and add the sliding window folder as well). Please assign this issue to me and add the Hacktoberfest label as well.


Radio Buttons do not work with the skin on OS X

They simply don't show up as selected so I can't tell the difference between a selected radio and not selected.

Hey, this seems similar to https://github.com/xPoke/MetroMumble/issues/2
Can you try downloading the latest Mumble snapshot from here, and let me know if this still happens (no need to install MetroMumble - it comes installed by default in the snapshot).


ActiveRecord::StatementInvalid (Could not find table 'delayed_jobs')

Hey guys,
When some application set AR configurations below:
active_record.table_name_prefix = "my_app_"
active_record.table_name_suffix = ""

and run migrations, AR creates a table with name "my_app_delayed_jobs"
Then DJ AR Backend try to query with name "delayed_jobs" and you get the Error:
ActiveRecord::StatementInvalid (Could not find table 'delayed_jobs'):
or
ActiveRecord::JdbcError (query does not return ResultSet):
If application using activerecord-jdbc-adapter
Is it possible to set DJ table name with AR prefix and suffix configs?
something like this:
self.table_name = "#{::ActiveRecord::Base.table_name_prefix}delayed_jobs#{::ActiveRecord::Base.table_name_suffix}"

Using

delayed_job (3.0.1)
delayed_job_active_record (0.3.2)
rails (3.1.3)
activerecord (3.1.3)

For Rails applications an alternative fix is set DJ table name on application.rb like:
'''Delayed::Backend::ActiveRecord::Job.table_name = "my_app_#{Delayed::Backend::ActiveRecord::Job.table_name}"'''


Export v3 and v5 from main package

On the server or when using es6 imports with tree shaking, it's idiomatic to use:
import { v4, v5 } from 'uuid';

instead of:
import v4 from 'uuid';
import v5 from 'uuid/v5';

This makes the former possible.

Hi Mike, thanks (again) for contributing.
I've deprecated the top-level API object because I don't think it adds much value for most users, and creates a cross-version dependency that in almost all cases pulls in extra code that won't get used.  It's going away in the next major rev (if/when) that happens.  (This is documented in the README.)  Thus, I'm not interested in adding to that API.


Possibility to add module twice

When adding the module twice, origin and destination from the first module is also used for the second.

Hi @CFenner,
any idea what is happening here or what could be the reason?
My JS skills are not excellent, but maybe I can also try to investigate.

Hi @CFenner,
any idea what is happening here or what could be the reason?
My JS skills are not excellent, but maybe I can also try to investigate.

Hi Matthias,
The module system should handle the separation of the config. Is this also happening for instance for the weather module?

Ah no, I have an idea. The module is using a backend service, and this service notifies both widgets with the same information. I think I can fix this tonight.


Any solution for smoothly change auto width of input based on content ?

Hello,
I am using Bootstrap 4 inline form and I want to dynamically smoothly change auto width of the inline form elements if it is possible.
I know how to achieve that with for example col-md-4 to col-md-6 with transition: width 1s ease; but problem is with col-auto
Is there any any solution for that?
I have this code -
and it looks like like this

Because my application will be multilanguage, english and german, the label will be changed dynamically and for the same input I will have german version, like this...

As you can see label for german version is longer word that english, so I would like to achieve when user changed the language by click on the english or german flag, smooth shrink of input proportional to the length of the label.
If you have some question , feel free to ask me, I will explain in more detail.
Thank you in advance

This isn't the place for how-to questions, but this is accomplishable with the grid system and some flex utilities. Worst case scenario, you could use table styles, too.


Dc's with private networks can't see each other

Reason: grid is weaved together using private addresses. This PR adds possibility to add/remove custom peer addresses per grid (basically public ip that can be seen/connected from outside of datacenter).

LGTM!


📟 Help us add examples that use Mirrorful

📟 We want as many examples as possible that use Mirrorful! Help us! 🚀
Here are some of the frameworks/setups we are looking for: (👀 - looking for; ⚠ - being worked on). And feel free to add your own.

Framework
Status

Remix
✅

Astro
⚠

Solid
👀

Steps
(copy these over to your PR description to check that you've done everything)

[ ] Add a new example project to the examples directory
[ ] Make sure it uses the latest version of Mirrorful (note that some old examples may use older version, so don't copy an old example blindly!) . You should run: npm i mirrorful@latest --save-dev
[ ] Add a README that includes an explanation of how Mirrorful is set up and how to run it.
[ ] ‼  IMPORTANT: Your project should import Mirrorful and have code that uses theming that comes from Mirrorful
[ ] Add your example to the top-level README in the ## Component Library Agnostic section
[ ] Add your example to the sub-level README in the ## Component Library Agnostic section.
[ ] Add your example to our documentation in the docs/ folder
[ ] Add your example to the list in the app here: https://github.com/Mirrorful/mirrorful/blob/main/packages/core/src/components/ExportSuccessModal.tsx (screenshot below):

Finally, push up a PR! 👏🏼
Thanks for all your help. 🚀

As we are moving towards a web-based editor (Mirrorful Cloud), going to sunset this issue for now, but thank you for all those that helped!


chore(page-title): raise test coverage

Closes #2133
Summary

raise test coverage and remove exception

All test moving forward should be using react testing library instead of enzyme but since this is a deprecated component anyways its cool..

Yeah, I just didn't want to rewrite the existing tests and it was a stupid simple test, so I just rolled with it. All my other new significant tests are testing-library.


Restore prevents updating schema

I'm currently running into an issue when initializing a producer data model with a schema such as
Type {
  int field1;
  int field2;
}

and then restoring it from data produced with a schema like
Type {
  int field1;
}

The subsequent cycles show a write state with the expected schema with 2 fields, but the produced data does not contain the second field.
The documentation here seems to suggest that this should be possible

Before restoring, we must always initialize our data model. When a data model changes between deployments, Hollow will automatically merge records of types which have changed. In order to do this correctly, Hollow needs to know about the current data model before the restore operation begins.

I have put together a test case to demonstrate the issue, which you can see here.  At HubSpot we make exclusive use of the generic API, so the test case does the same
cc @jhaber

Any Updates on this?

Hi, recently I had similar issue. It seems that produced data does contains the second field but existing HollowConsumer is unable to read it. If you create a new consumer instead of reusing existing one after the run cycle invocation for updated schema then the test passes. I'm not sure if this is expected behaviour.

That would not be the behavior I would expect.  Recreating the consumer is (in many cases) a very expensive operation and should be avoided during standard operation.


external user deployment example schema adaptions

see https://github.com/owncloud/ocis/pull/9942

We'll probably need for oCIS 6.4.0 for it to be released

Will be done by https://github.com/owncloud/ocis-charts/issues/717

Will be done by #717

self-reference?

Done in https://github.com/owncloud/ocis-charts/pull/759


Issue with binding $index in custom attribute in a repeat.for on incremental changes

This is a very specific edge case. Reproduction plunk: http://plnkr.co/edit/fguuz4
After loading the plunk, three data items will be listed and a custom attribute will be bound up and attached to each. This works as expected. Three lines are displayed with correct indices and three log entries with correct indices.
5 seconds later, a timeout fires, adding a single item to the end of the data array. The index displays correctly on screen and is interpolated correctly into the class attribute on the element. However, the $index is bound as undefined as declared in the custom attribute.
Another 5 seconds later, another timeout fires that unshifts an item to the front of the list. All indices on screen are correctly updated, The bound $index inside the custom attribute is incorrectly undefined.
Finally, 5 more seconds later, the list is completely replaced. The indices are correct on screen and are bound correctly.
It appears to be only an issue for incremental changes.

@martingust Can you take a look at this?

@peisenmann @EisenbergEffect Found the issue, will get a fix in.


Help! pwa + nuxt + cdn issure

Now cdn is ok
publicPath: isProdMode ? apiConfig.cdnUrl + 'frontweb/_nuxt/' : '',
PWA , if i remove publicPath, pwa is ok , or throw issure
//////////////////
Uncaught SyntaxError: Invalid regular expression: missing /
at sw.js:1
16:11:25.675 app.7c997200496abc20d48b.js:1 Service worker registration failed: TypeError: Failed to register a ServiceWorker: ServiceWorker script evaluation failed
//////////////////
where is wrong ? Please help me ...

This question is available on Nuxt community (#c7240)

Solved !  workerbox.js is wrong , i copy from other web, it works .
So  I suggest let workerbox.js be static . No need generate every time .


Python plotting scripts

I have some plotting scripts that I've been using.
Some of these are substitutes to the R functionality #180.
I'm not sure the best way forward.
I'm much more comfortable in Python.
You guys are more comfortable in R.
Eventually we will need to decide on one or the other for the manuscript figures, but I think for now it can make sense to just keep doing what we are comfortable with.

Just to chime in, for the estuary salinity paper, I have figures from both python and R in the manuscript. I've edited them to look similar, but for me, that was easier than deciding on one plotting language. Here is a link to the figures if you want to take a look, some had to be slightly edited in illustrator. Just an option if we want to punt on this decision...

Thanks, Galen. That's helpful to know that that is the direction you all took and it worked out okay

I have some plotting scripts that I've been using.
Some of these are substitutes to the R functionality https://github.com/USGS-R/drb-do-ml/issues/180.

There are a few ways to slice the data in this pipeline (e.g. partition/model id/site id/etc). So to a certain extent, in this semi-exploratory phase I actually think it's a nice gut-check that we've drafted the same type of figure independently and get the same results/draw the same conclusions 🙂
If there are figures that we commonly refer to, I think it's worth checking the code that creates them into version control, even if not formally integrated in either the targets or snakemake parts of the pipeline. Once we decide on the set of figures we want for the manuscript, we can add those into the pipeline (R or python probably depending on who creates the publication-quality version of each figure). Just my 2 cents.


Fix graph refresh overwriting smartstate OS info

Fix an issue where graph refresh was overwriting VM operating system
information retrieved from smartstate analysis.
This adds a custom save block which checks if smartstate has been run
before overwriting the OS record.
Alternate solution to https://github.com/ManageIQ/manageiq-providers-openstack/pull/410

We need to fix this for OpenStack, RHEV, and VMware (though on VMW graph refresh it is not default so no one should have hit this yet there).  Figured it is better to do this once in core than in each parser and it mirrors what is done by classic refresh.

There are three other locations where smartstate calls into save_inventory:

EmsRefresh.save_networks_inventory  We might just need to not delete networks with a guest_device_id according to the comment # Remove networks that were already saved via guest devices

EmsRefresh.save_system_services_inventory This is not a collection sent by refresh so we don't need to do anything here

EmsRefresh.save_custom_attributes_inventory This is also not sent by refresh, we only send ems_custom_attributes.

@Fryguy what do you think?

@agrare can this be hammer/yes?

@simaishi yes

Hammer backport details:
$ git log -1
commit 779877c22492e873b8b124244426b91f0f100776
Author: Jason Frey<EMAIL_ADDRESS>Date:   Mon Mar 18 10:37:38 2019 -0400

    Merge pull request #18477 from agrare/fix_graph_refresh_overwriting_smartstate_operating_systems

    Fix graph refresh overwriting smartstate OS info

    (cherry picked from commit f11b01e90296340d9217b9264c3d98890cede8c8)

    Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1702478


[ENG-791] feat: Add Capsule connector

Catalog variables
No required catalog variables
Notes
Testing
GET
URL: localhost:4444/v2/kases/4827250
Connection via proxy fails with this error

And the postman query for proxy looked like this

While direct hit at http://api.capsulecrm.com/api/v2/kases/4827250 works fine

PUT
URL: localhost:4444/v2/kases/4827250
Proxy request fails like this
If hit directly works fine
DELETE
URL: localhost:4444/v2/kases/4827250
Proxy request fails

Pagination

@RajatPawar please kindly take a look when you have a minute. Thanks!


TODO before InnoDay

Introduction

[ ] Explicit a way of using the Rest Client that do not require any sign in (compared to the Postman option).
[ ] Add a reference to this Http tooling section in each task that requests an http call.
[ ] Missing postman instructions :
[ ] Postman screenshots from vscode extension
[ ] Add an 👨🎓 instructor led instruction in the introduction : explain some steps won’t need to be done as they are done or will be given credentials for them

Lab 1

[x] Configure the Create or update item action to create a new document in CosmosDB in Logic App loa-proc-lab-no-ipa-[randomId] workflow `wf_orders_from_sb_to_cdb.
[x] Opérations/actions/functions <= All the ops/functions in Logic Apps are called Actions (uniformiser)
[x] Tasks lab 1 a finaliser <= Expliciter
[x] Add a quick Summary to lab 1 <= Just like lab 2 an 3

Lab 2

[x] You have to edit the code locally (not in Azure portal). <= in the codespace
[x] + précisions on where to apply changes in the code/folder
[x] re-deploy the Function App code to get your updates running on Azure: <= from the codespace terminal run the following command
[ ] #26
[x] Clixk on the FetchOrdes <= typo
[x] You can take any URL because for this lab, we disabled the key<=  Trop complexe

Lab 3

[x] Go the Azure APIM (name should start with apim-lab-no-ipa) <= consistence dans le naming avec [randomid]
[x] Add a Little explanation on what will be done in Lab 3
[x] What is APIM
[x] Add laïus on API/products in APIM
[x] We will know test our API with the subscription key. <= Now
[x] The result of this test is negative. A 401 Access Denied error is returned by the APIM. The error message states that the subscription key is missing.
[x] will now see how to securize our API with the OAuth 2.0 standard <= secure
[x] Instructor led warning to get out of the toggle
[x] Laïus on app registration.
[x] TBD : how we get the tenant ?? <=  Add an instructor led instruction on this tab
[x] OAuth 2.0 framework! <= protocole
[ ] begin, we will set a limit for the Basic user to ensur <= as it represents a free usage of our api
[x] Go back to Postman and run about ten closely spaced tests. <= Call it 6 Times to trigger the rate limiting policy
[ ] ❗Clarify the ToggleSolutions to explain how to run tests, and how to retrieve the URLs to contact from the APIM interface
[ ] Add Instructions on where to get the URL to call for the APIM policy tests
[x] Go back to Postman and run about a test and observe the result. And send one http request
[x] Once you're done with this lab you can delete all the resources which you have created at the beginning using the following command: <= from the codespace environnement, run azd down

pour moi pour l'intro, je me ferais pas trop chier. si on laisse chacun utiliser l'outil de son choix, on n'a pas à les guider particulierement. et si le mec ne sait pas faire une requete HTTP, je sais pas s'il doit faire le lab.
j'ai fix le lab1 et un bout du lab3 apres le travail de lulu et iheb

On peut effectivement ne pas rentrer dans ce niveau de détail, mais j'ai eu des cas (à chaque lab) où les gars savaient pas taper une commande az cli et remplacer des placeholders :)
Je me méfie à chaque fois maintenant.


WS2012R2 VHD prep & DC hydration skip

added support for Windows Server 2012 R2 hydration
DC hydration is skipped when the DC folder is found

All add more comprehensive tests for DC presence (if not all files present, it will rewrite all files. If all files present, it will ask ask if it should be kept or rewritten). Ill add more functionality to convert image script in tools to detect OS in image (client/server/version/generation...)

I added DC detection (will skip DC creation if items exists under lab\dc. Will add more functionality to CreateParentDisk.ps1 later


[Bug]: Create a data source, and the front end reports that the parsing result fails.

ODC version
ODC422
OB version
Has nothing to do with database version
What happened?
Create a data source, and the front end reports that the parsing result fails.

What did you expect to happen?
display normally
How can we reproduce it (as minimally and precisely as possible)?
Create a data source, and the front end reports that the parsing result fails.
Anything else we need to know?
No response
Cloud
No response

The problem has disappeared


Search available books

Implement search feature within the results from available books, depends on #20

Implement pagination


Debug Selected Tests fails and then hangs

Describe the bug
Running a single test works, but the debug option does not.
Steps to reproduce the bug

Open Test Explorer (Test->Windows->Test Explorer)
Select a test (e.g. MUXControlsTestApp > Windows.UI.Xaml.Tests.MUXControls.ApiTests > NavigationViewTests > VerifyDefaultsAndBasicSetting)

See this error:
---------------------------
Microsoft Visual Studio
---------------------------
A fatal error has occurred and debugging needs to be terminated. For more details, please see the Microsoft Help and Support web site. HRESULT=0x8000ffff. ErrorCode=0x0.
---------------------------
OK
---------------------------

The app window never renders. Closing it does not seem to exit the VS debugging state. Interjecting with a manual Stop Debugging does, although with a warning dialog. And afterwards Test Explorer seems to be in a bad state and in my experience doesn't recover without restarting Visual Studio.
Expected behavior
Test executes with the debugger breaking in.
Version Info
NuGet package version:
Commit 68a573b4
Windows 10 version:

[ ] Insider Build (xxxxx)
[x] October 2018 Update (17763)
[ ] April 2018 Update (17134)
[ ] Fall Creators Update (16299)
[ ] Creators Update (15063)
[ ] Anniversary Update (14393)

Device form factor:

[x] Desktop
[ ] Mobile
[ ] Xbox
[ ] Surface Hub
[ ] IoT

Okay, so we probably still want to edit the documentation to say that you need 16.0 to be able to debug.


Add Az 3.5.0 PowerShell module to Windows Server 2016/2019

Add Az 3.5.0 Modules to Windows Server 2016/2019 images. Customer request -  https://github.com/actions/virtual-environments/issues/440

Can we remove old versions?
No. This can break existing customers who has written there scripts based on the old AzurePS commands and using that specific version in the task.

Can we change default versions?
There are breaking changes between V2.1.0 and V5.13.0, V6.13.1. There are many third party custom tasks that may have taken dependency on V2.1.0 which will break if we change the default version.

/azp run windows2016

/azp run windows2016

/azp run windows2016

/azp run

/azp list

/azp run windows2019

/azp run windows2019


Fix issue with a match expression in an if statement

Found the issue while testing inside Metals. The code is a bit convoluted around the separate regions part, but in essence  the condition was wrong.
sepRegions1.head != '}' || sepRegions1.head != '$' will always be true, which was the issue.

Checked with Metals and this fixes the issues we've had.


net/http: TestTLSServerClosesConnection is flaky

TestTLSServerClosesConnection is flaky on Windows.

Investigate why & re-enable.

Also failed on Darwin. Details in #14195

Ran 200 runs on macOS Sierra: no problems.
Maybe this is no longer flaky.

Closing until there are reports that this still happens.


Implement enable-ops and auto-op on Fabric

Also Luck please suggest a better name for FabricOtherListeners :joy: could not think of anything better at 2 a.m.

Thanks!


No files

Hi When I install this module I dont have any files except package and readme.txt.
Can you check?

Do you mean that git clone https://github.com/oferh/ng2-autocomplete.git doesn't clone the project or something else?

I am getting only package.json and readme.txt when i clone the module

can you paste the exact command you are using? don't see any reason that you shouldn't get the files.
try to download the files from the repo and let me know if you get them all.

it looks like a git issue not related to this project


Validation with my own assemblies

Dear Author,
I am trying to validate SVs with hifiasm created assemblies. When I use my own assemblies, the error  wassequence h1tg000143l not present, and this sequence was not found in the assembly index file neither. It seems that we can only use the assemblies downloaded from download_asm.sh.
Really appreciate your help!
Thanks!

Hi Jiadong,
Glad you are using TT-Mars to do validation.
Could you provide more details about how did you validate SVs using your assemblies? To use TT-Mars with your assemblies, you will need to generate liftover files based on the assemblies by TT-Mars first. Steps can be found here: https://github.com/ChaissonLab/TT-Mars/blob/main/liftover.sh
When you use assemblies from download_asm.sh, did it work?
I will be glad to answer any other questions you have.
-- Quentin

Hi Quentin,
For the validation, the input were:

SVs detected from HG002 using hg19 reference genome.
Assemblies hap1 and hap2 of HG002 created by hifiasm with default parameters.

The HiFi reads of HG002 were obtained from GIAB ftp site. I found you provide the liftover files for HG002.
Thanks!

Hi Jiadong,
My best guess is that the assemblies you used (created by hifiasm) have different contigs from the HG002 assemblies files provided by us. By "sequence h1tg000143l not present", I suppose that means TT-Mars can not find contig "h1tg000143l". And thats why I said you may need to generate liftover files if you want to use your assemblies.
Could you provide a description about the entire pipeline? For example, the steps from generating the SVs to validating by TT-Mars. And which files did you use in each step. I believe this can help me to debug with you.
Thanks,
--Quentin

Hi Quentin,
I think I understand what you suggested. Though you provided HG002 liftover files, they were not for the assemblies I created. Therefore, I first need to created by liftover files with my own assemblies, then I can use these files to do the validation. Is that correct?
Thanks!

Yes, that's the best guess I have without seeing the actual data and pipeline you're using.
Feel free to try it (liftover steps are here: https://github.com/ChaissonLab/TT-Mars/blob/main/liftover.sh) and let me know if you have any questions.

Hi Quentin,
I am able to run TT-mars now, though one error occurs No such file or directory: './ttmars_ins/HG002/ttmars_chrx_res.txt', I still get outputs in the output directory. It seems to me that this error does not affect the final outputs.
Moreover, I still have some questions regarding to the outputs.

What are the difference between ttmars_res.txt, ttmars_agg_res.txt, ttmars_combined.txt and ttmars_regdup_res.txt. It would be great if you could describe your output files.
For my case, the input VCF file contains 237 SVs for validation. The number of SVs in the SV_positions.bed is also 237, while there are 207 SVs in the ttmars_res.txt. I guess ttmars_res.txt contains the final results for the validation and everything in this file looks normal.

Looking forward to your reply! Thanks!

Hi Jiadong,
Glad it works. Yes, "No such file or directory: './ttmars_ins/HG002/ttmars_chrx_res.txt'" does not affect the outputs.

Please use 'ttmars_combined_res.txt' as the output. Ignore the others. A description of the output can be found here: https://github.com/ChaissonLab/TT-Mars#example-output
The number of SVs in the final output file (ttmars_combined_res.txt) is expected to be smaller than the number of total SVs. Because TT-Mars will skip SVs which it can not give confident validation.

Let me know if there are other questions.
Cheers,
--Quentin

Hi,
May I ask the vcf file format you used? I tried TT-Mars using our own assemblies and vcf files but got failed. I supposed that is induced by the VCF file format.
thanks!


fix(#4373): remove legacy postgres initializer

Fixes #4373
Application had a legacy hack to forcefully drop DB connections that was needed with pow.cx.
That is no longer used and the hack no longer work with Rails 7.1 so the initializer can be removed.
Can confirm it happens on main for me without the fix:
$ > rails db:reset
undefined local variable or method `establish_master_connection' for #<ActiveRecord::Tasks::PostgreSQLDatabaseTasks:0x00007f1e4e8619b0 @db_config=#<ActiveRecord::DatabaseConfigurations::HashConfig:0x00007f1e4ee59930 @env_name="development", @name="primary", @configuration_hash={:adapter=>"postgresql", :encoding=>"unicode", :host=>"localhost", :database=>"diaper_dev", :username=>"postgres", :password=>"postgres", :pool=>5, :timeout=>5000}>, @configuration_hash={:adapter=>"postgresql", :encoding=>"unicode", :host=>"localhost", :database=>"diaper_dev", :username=>"postgres", :password=>"postgres", :pool=>5, :timeout=>5000}>
Couldn't drop database 'diaper_dev'
bin/rails aborted!
NameError: undefined local variable or method `establish_master_connection' for #<ActiveRecord::Tasks::PostgreSQLDatabaseTasks:0x00007f1e4e8619b0 @db_config=#<ActiveRecord::DatabaseConfigurations::HashConfig:0x00007f1e4ee59930 @env_name="development", @name="primary", @configuration_hash={:adapter=>"postgresql", :encoding=>"unicode", :host=>"localhost", :database=>"diaper_dev", :username=>"postgres", :password=>"postgres", :pool=>5, :timeout=>5000}>, @configuration_hash={:adapter=>"postgresql", :encoding=>"unicode", :host=>"localhost", :database=>"diaper_dev", :username=>"postgres", :password=>"postgres", :pool=>5, :timeout=>5000}> (NameError)

          establish_master_connection
          ^^^^^^^^^^^^^^^^^^^^^^^^^^^
Did you mean?  establish_connection
/home/bandito/Projects/rfg-human-essentials-fork/config/initializers/postgres.rb:7:in `drop'
Tasks: TOP => db:drop:_unsafe
(See full trace by running task with --trace)

and works fine with the fix:
$ > rails db:reset
Dropped database 'diaper_dev'
Dropped database 'diaper_test'
Created database 'diaper_dev'
Created database 'diaper_test'
loading US counties and equivalents.

Thanks!


Moves theme variables outside the theme map

This PR closes #23908
@kriim makes a valid point on using and changing theme variables. You cannot overwrite the variables inside the map unless you actually change the source, which is something you wouldn't want to do.
This PR move theme variables outside the map as suggested by @kriim

@andresgalante: I rebased this. @mdo: lgty?


Orders status incorrectly updated to Pending

This issue was solved by the next PR: https://github.com/buckaroo-it/Magento2/pull/859 Locking System


[WIP]: Adding base hal support for Atmega48P chip

It depends on changes in https://github.com/Rahix/avr-device repo, update crate version before merge.

Please rebase this changeset on master to pull in the new version of avr-device.

Please rebase this changeset on master to pull in the new version of avr-device.

Updated and tested on my examples.


[PWX-33952] Automation test for Enter and exit maintenance mode after pool resize

Automation test for Enter and exit maintenance mode after pool resize
PWX-33952
Test :-
https://jenkins.pwx.dev.purestorage.com/job/Users/job/Rushikesh/job/rushi_pxdv-7-dev/121/

Have provided some minor comments.

made the changes


Update Google.Cloud.Spanner.Data to 2.0.0-beta00

We're introducing breaking changes (semantically) so let's bump the
major version.

Yup. beta00 and alpha00 are special version numbers which the release tagger knows to ignore.


Bring back the C++ runtime version in the about dialog

Fixes https://github.com/Microsoft/pxt-microbit/issues/1063
Looks like it was originally removed because the link was wrong. I've brought it back and fixed that issue. Also, I'm now using the service ID in place of "C++" so instead of reading C++ runtime version it now reads microbit runtime version.
@mmoskal can you take a quick look and let me know if I'm using the correct fields from pxtarget?

No need for codal version - it's only the "build system", rarely changes and unlikely to cause trouble

Thanks @mmoskal! updated.

Looks good!


Add Detune to p5.Oscillator

It can mirror the .freq() implementation here https://github.com/processing/p5.js-sound/blob/master/src/oscillator.js#L175

store detune as a property of the oscillator
provide access to Web Audio API's oscillatorNode detune param, and set that value to this.detune every time a new oscillator node is created (for example in .start()), just as we do for frequency. The reason is that Web Audio API requires creation of a new oscillator node every time it is stopped/started. But we want the p5.Oscillator to remember its frequency and detune param even after it is stopped.

This is a low priority at the moment but a good issue for anyone looking for a place to get started contributing to the source code (more info here)

oops! @b2renger didn't mean to unassign you !

because of the low traction on this upgrade, i am closing this issue for now ~


Feature/propagate components demo

This PR contains the follow component demos:

Background Shapes
Blockquote
Chip

https://5a741db1efbe5d1ed00a0365.bolt-design-system.netlify.com/

Seeing stuff missing on Blockquote:

The fix for missing blockquote stuff is coming within a separate PR :-)


Fix tiny typo in rope doc string

Hi, just noticed this tiny typo while looking at the docs.

Hey @bdero thanks for submitting a PR. Please send PRs to the dev branch, we do not accept PRs to the master branch.
You can read more in our Contributing Guide.


Mark System.Threading.Task.Dataflow as Private=true

To make our microbuild definition pass again for xplat.

It fixes the microbuild because we now get Dataflow from a nuget package and not from the GAC, so the dll does not get copied to the Output directory anymore because it's marked private=false. The VSIX packager expects it to be in Output and thus fails.


🐞 dagger listen stopped working in v0.6.0 release

What is the issue?
dagger listen doesn't work anymore since starting from v0.6.0, it starts the TUI instead of executing the actual listen command
Log output

Steps to reproduce
run dagger listen
SDK version
Engine v0.6.0
OS version
N/A

I don't think this was broken in the sense that it still ran the HTTP server, but the TUI was definitely broken because the command logged directly to stderr. Fix here: #5219

I think the fact that the TUI started was breaking the playground script which started dagger listen and then did something else in the background.

I think the fact that the TUI started was breaking the playground script which started dagger listen and then did something else in the background.

Ah interesting, in that case it might be best to just run it with -s or --silent in the script now that #5218 is merged.
Could also just remove the TUI from dagger listen. I can change #5219 to do that if it makes more sense.

Throwing a curveball idea: could we retire dagger listen in favor of wrapping Playground with dagger run? :thinking: Sounds like that's sort of what your script was approximating. It's a bit different, since you'd have to use $DAGGER_SESSION_PORT and $DAGGER_SESSION_TOKEN and you'd no longer have a stable listen address (unless we make that configurable). But maybe it'd let us tidy up the CLI a bit, since it doesn't seem like most people would be using dagger listen.

dagger listen is just meant as a convenience wrapper around dagger run, for the use case "I want to debug the graphql API with curl". Unless it's very painful and expensive to keep listen, I would prefer keeping it. Even though, yes, it's a niche command and hopefully will become increasingly so.

Follow-up @vito : I prefer keeping listen BUT I do agree Playground maybe should switch to using dagger run, if it makes things easier. Like I said, listen is intendend as a convenience for users who "just want to use curl", and that doesn't match the description of Playground.

@shykes

dagger listen is just meant as a convenience wrapper around dagger run, for the use case "I want to debug the graphql API with curl". Unless it's very painful and expensive to keep listen, I would prefer keeping it. Even though, yes, it's a niche command and hopefully will become increasingly so.

Got it. I suppose showing a TUI makes sense for this case then, so the user can see progress for GraphQL queries they're submitting.

Also, unless I'm remembering wrong, dagger listen is not supposed to have a stable listening address. It's supposed to print a URL that is derived in the same way that $DAGGER_SESSION_PORT and $DAGGER_SESSION_TOKEN are - in other words, not stable.

Looks like it has always (at least in the Cloak Era) exposed a --listen flag with a default value of <IP_ADDRESS>:8080, and it doesn't set up a session token. We could change that default to <IP_ADDRESS>:0 and then print the port that was selected instead, if we still want to let the user pass a stable address while defaulting to unstable.
Is there a ton of value in having an unstable address? Seems like it would hinder reusing curl commands from your shell history, for example.

Got it. I suppose showing a TUI makes sense for this case then, so the user can see progress for GraphQL queries they're submitting.

Yes I agree.

Is there a ton of value in having an unstable address? Seems like it would hinder reusing curl commands from your shell history, for example.

Yes you’re right…