allow to skip copy of runtime dependencies

In projects such as muCommander (http://github.com/mucommander) it is needed to have the possibility not to copy runtime dependencies since the produced jar already contains all the required dependencies (proguard is being used to shrink the 'fat' jar). Therefore adding an option called 'copyDependencyJars' to be able to specify that no dependencies other than the produced jar should be copied to the app folder.

Hi
The plugin only copies dependecy jars that are in the runtime configuration. And so I think a better way to handle this would be by using gradle's various dependency configurations. So instead of putting those jars that you do not want into the compile configuraiton, you can put them into the compileOnly configuration. Then they will not be part of the runtime dependecy configuration and the plugin will not try to copy them.
See
https://docs.gradle.org/current/userguide/java_plugin.html#tab:configurations

Hi,
Making these dependencies as compileOnly dependencies won't solve the problem in my case since they are needed at runtime.
I'll try to describe the build process we used to have using maven:

compile the application classes
create a 'fat' jar that contains both the application classes & resources as well as all the required runtime dependencies
using proguard shrink the 'fat' jar
create an app for mac that uses the produced jar in the last step

The shrink stage is significant because it can reduce 2/3 of the size of the original jar (many of the classes inside the dependencies are not used by our application and thus can be removed).
I think it could be useful for other projects as well so I prefer to add it to the plugin instead of adding it just to our project, what do you think?

HI
What it sounds like to me is that you actually don't want those
dependencies to be runtime. You want them as part of the configuration to
compile against and as part of the configuration that generates the fatjar,
but after that they are not used. Think of it this way, you should be able
to run your code from gradle against the combination of your generated jar
AND the runtime configuration. That is what the runtime configuration is
for. So you really want the runtime configuration to be empty and only use
the fatjar.
Perhaps if you can show me where/how to generate the fatjar in your
build.gradle I might be better able to help. I looked at your build.gradle
at github but did not see anything related to fat jar generation, so hard
for me to be more specific.
If this can be accomplished via the gradle configuration system, I feel
that should be the preferred route. I am happy to consider the extra config
parameter if necessary, but really don't want to do that unless I am
convinced  that it is the only way. More options equals more complexity
IMHO.
thanks
Philip
On Mon, Apr 4, 2016 at 2:36 PM, Arik Hadas<EMAIL_ADDRESS>wrote:

Hi,
Making these dependencies as compileOnly dependencies won't solve the
problem in my case since they are needed at runtime.
I'll try to describe the build process we used to have using maven:

compile the application classes
create a 'fat' jar that contains both the application classes &
resources as well as all the required runtime dependencies
using proguard shrink the 'fat' jar
create an app for mac that uses the produced jar in the last step

The shrink stage is significant because it can reduce 2/3 of the size of
the original jar (many of the classes inside the dependencies are not used
by our application and thus can be removed).
I think it could be useful for other projects as well so I prefer to add
it to the plugin instead of adding it just to our project, what do you
think?
—
You are receiving this because you modified the open/close state.
Reply to this email directly or view it on GitHub
https://github.com/crotwell/gradle-macappbundle/pull/41#issuecomment-205440580

Hi Philip,
Just a quick update -
I tried to follow your suggestion and changed the dependencies to be compileOnly, but a side-effect of doing that was that the trivial import of the project as a gradle project into eclipse stopped working.
Basically in my case there are two 'profiles':

The default profile should treat the dependencies as runtime dependencies since the project is compiled as a regular Java application (and that's how eclipse treat it).
The packaging profile that produces distributions for different operating systems where I need to make a fat-jar and then shrink it. In this flow the dependencies should not be treated as runtime dependencies since the produced jar contains them.

So I decided to keep the dependencies as runtime dependencies and to adjust gradle-macappbundle plugin to mucommander. There are two adjustments:

Use the jar file that is produced by the shadowJar task (which produces fat-jar)
Not to take runtime dependencies

You can find the changes in [1] (except for the shrink part). I believe this in not the only project with similar requirements so I would be happy to discuss how to merge these changes into the official version or to get feedback about changes/improvements in the current solution.
Anyway, I'll continue with the forked version for now.
Thanks for the feedback!
[1] https://github.com/mucommander/mucommander
Arik


[IMPROVEMENT] Add support to regular line breaks (\n)

@RocketChat/android

Closes #1781, #1707

This is absolutely fantastic, thank you!


"microsoftTeams is not defined" error prevents consent dialog from opening

Hello,
My teammate and I were trying to run the tab-channel-group-sso-quickstart sample, but we ran into an issue where the consent dialog would not open.
We ran Teams in the browser and saw an error printed to the console, saying that microsoftTeams is not defined.
We changed line 94 in Tab.js from "microsoftTeams.authentication.authenticate" to just "authentication.authenticate", and it solved the issue for us.
Just wondering if this might also be affecting others, and if any change is required?
Thank you for reading this post!

Thank you for reporting this, we will check this and get back to you.

#1040 has been raised to fix this issue.


Improve GitHub template checklist

:sparkles: Enhancement
The checklist section of GitHub templates are too large.
This PR makes them more separate, and condenses the help text.

:white_check_mark: Checklist

[x] Following CODE_OF_CONDUCT.md.
[x] Checked for duplicate pull requests
[x] Title is a summary of the change, in present tense, ideally < 50 characters
[x] Pulling from a branch (right side), not master.
[x] Pulling into master branch (left side).
[x] Fixing a bug? An open bug report exists.
[x] Breaking API changes? Migration notes attached.
[x] Ready for review

:tada: This PR is included in version 3.1.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Added Jumping on the clouds problem.py

Please add the entire question on top as a comment. Check the other codes in the repository for reference.


multiplayer: implement disconnect event

Goes together with https://github.com/QUB3X-2/super-cool-server/pull/6


github-discovery should only output repositories with relevant files

Currently the way github-discovery is implemented is that it outputs all repositories that match a certain pattern, and leave it to a lower level to find the relevant catalog file within that repo. This causes a weird behavior if for example the following pattern is given:
locations:
    - type: github-discovery
      target: https://github.com/backstage/*mkdocs/blob/master/catalog.yaml

And only some of the repos with mkdocs in their name contain a catalog.yaml file. All repos will be outputted, which will cause an error to be thrown for those repos where catalog.yaml file doesn't exist.
Expected Behavior

Only relevant repos matching the entire filepattern should be outputted.
Current Behavior

Errors are thrown when reading repositories that partially match the file pattern.
Possible Solution

Steps to Reproduce

Context

Your Environment

NodeJS Version (v12):
Operating System and Version (e.g. Ubuntu 14.04):
Browser Information:

Hm i wonder if we should really mix the repo and file concerns. Would it make sense to emit the locations with presence: 'optional' instead?

I like that! I didn't like mixing the concerns as well. Creating a PR.


Feature Request: Can I edit feed article url?

I want to edit article url. Is it possible?

reformat / modify - "reformat":[array of options] "modify":[array of options]
Reformat is an array of formatting rules for the url of the full article. The rules are applied before the full article is fetched. Where as Modify is an array of formatting rules for article using the same options.


Add deprecation linting

To test this you can install an older verison of strato icons and import the ErrorIcon + Use components like Flex from the preview package (might also need an older version) that were moved to strato-components

Lint error when trying to use a deprecated component on default template

Lint error when trying to use a deprecated component on empty template


Task progress

Hi all,
How is your progress on your task assigned? @Pranjal-Srivastava-2023 are you done with the task too.  I can see the plots you created. Can we use all those plots for documentation part?

We have completed.

@reshnashrestha Thanks for letting us know.


Improvements to action reducers.

I think action reducers should be passed the value that they operate on, rather than the full state tree.  So instead of:
class MyReducers {
    add(state): { return { count: state.count + 1; }
}

Instead we should be able to write something like this:
class MyReducers {
    add(count = 0): { return count + 1; }
}

The question is how do we achieve this with decorators?  Do we assume that a class of action reducers all work on the same state slice, like this:
@Reducer({slice: 'count', actions: ['add', 'remove']})
class MyReducers {
    add(count = 0): { return count + 1; }
}

Or do we implement this on a per-method basis, like this:
class MyReducers {
    @Reducer('count') add(count = 0): { return count + 1; }
}

Thoughts?

To me, defining the slice and actions in a decorator on the class looks cleaner, and would scale better from a code re-readable standpoint.
Peppering the methods within the class with decorators referencing different slices will get messy fast.

yeh I agree with that, it’s also common to group actions that work on the same slice, so this naturally fits that pattern

Would it be feasible to make the slice an optional config on the reducer decorator? So if you don't pass a value, you just get the whole state tree?

That would be easy enough to implement, we’ve already got it passing the whole tree

That way, for the rare few times when you do need to bounce about the state tree in a single class, you can do. And you get the option to refactor later to tidy it up into slices when things are coming together.

Came up with a few more ideas for how this could work:
Specifying a slice:
@Reducer('count', ['add'])
class MyReducers {
    add(count = 0): { return count + 1; }
}

Passing the whole state tree:
@Reducer(['add'])
class MyReducers {
    add(state): { return { count: state + 1 }; }
}

Or an alternative approach could use a new decorator:
@Slice('count')
@Reducer('add')
class MyReducers {
    add(count = 0): { return count + 1; }
}

I went and refactored redux decorators to support the @Slice() decorator.  I also had to refactor the @InitialStore decorator to finish this functionality off.  It’s very flexible now but it’s impacted on the readability :(  I need to rethink the decorators and make some changes at some point.
We can now achieve slice-specific action reducers like this:
@Slice('count') // these reducers work on the count slice of the state tree
@InitialState(0) // the count slice is initlaized with a value of 0
@Reducers('add', 'remove')
class ActionReducers {
  add(count) { return count + 1; }
  remove(count) { return count - 1; }
}

I was thinking that @Slice could accept a second argument which is the initial state value for that slice - there's really no reason to have these 2 as separate decorators.

@Slice has been implemented to match the above.  This is change is currently on the develop branch.


#13766: Revise Clone Operation

Ticket
Link to Github Issue: 13766
Problem description
Clone operation need to be revised:

Kernels
Test cases
Coding conventions

What's changed

The kernel functions have been revised:

compute_kernel.cpp:

Added support for src_cb_id and dst_cb_id as compile-time arguments
Properly handled double buffering

read_kernel_id: Added support for src_cb_id as a compile-time argument
write_kernel_id: Added support for dst_cb_id as a compile-time argument

clone_program_factory.cpp: Naming and coding conventions are consistent throughout, aligning with the kernels. For now, we can simply change the cb_id pair used in this file.
clone_device_operation: Replaced Shape with SimpleShape for consistency.
test_clone.py: Properly handled test cases using ROW_MAJOR_LAYOUT. I noticed that the to_npu utility function was performing padding on ROW_MAJOR_LAYOUT tensors, which is not the expected behavior. To address this, I wrote to_ttnn and to_torch to manage it correctly.
test_copy_ops.py: Removed the old test clone script. Actually, there were two files to test the clone operation. One was removed in a previous PR.
Support compute_kernel_config

Checklist

[x] Post commit CI passes:

All post-commit tests #17677
All post-commit tests #17678
All post-commit tests #17695
All post-commit tests #17706

[X] Blackhole Post commit (if applicable): N/A
[X] Model regression CI testing passes (if applicable): N/A
[X] Device performance regression CI testing passes (if applicable): N/A
[X] New/Existing tests provide coverage for changes: 64/64 test cases passed

Test Case
Number of Test Cases

test_clone_shape
22

test_clone_memory_config
12

test_clone_dtype_conversion
28

test_clone_callback
2

@razorback3 Please take a look!

@jaykru-tt, @ntarafdar, @sjameelTT , @yan-zaretskiy could some of you help review this PR? Thank you!


fix(DatePicker): fixes server-side rendering by setting hard version …

…for flatpickr (#262)

👍

Bluemix toolchain: Delivery Pipeline deployed carbon-components-react to Bluemix Design System, including commit 28439973b4f1d22f204b6cc425be71fc80bc2b37


Milestone 3 materials

[x] README. IIRC this is the final version of the README
[x] Poster
[ ] Video
[ ] Project logs

@VietAnh1010 Could you do the video?

The video content is really similar to MS2 video.
I am concentrating on showing the differences compare to MS2 during the walk through, mainly the embed feature.
Should we talk a little bit more about testing? Our tutor suggest describing in detail the types of testing used during the development process.

I am even thinking of removing most slides after the product walkthrough... since with too much content there's no way the video will be short enough.
Testing and similar stuff should be described in the README instead. I added a bit more information there already, but feel free to add some yourself.

The Figma has been updated with shorter content, PDF coming soon.

Slide 15 - 18 should be removed. On slide 19, we may add Integration Test.
Or we can create a new slide and add a code snippet about testing in that slide. I want to talk a little bit more about our testing process.

Hmm you can cut out certain PDF pages if you want to do so. Or use the modified PDF above which is only 11 pages long.

I mostly want to modify page 19 :|
And what software did you use to record your screen?

I mostly want to modify page 19 :|

Access the (secret) link I DM'd to you to edit the Figma.

And what software did you use to record your screen?

macOS has a default screen recorder, I think Windows has one too (called Game Bar or something, I've not used Windows for 3yrs+)

I think we need to add more information about our testing process.
For example, I may add:
One notable test case for back-end is to ensure statistic for site is updated correctly whenever a new comment is posted.

Something like that. (I don't like the "test cases table" in the sample README provide on Telegram. Who care about test cases?). Some example should be enough for other teams to understand what are tested in our project.
I will also add more information about manual API testing using Postman.

Yes, please do.
Updated PDF: ms3-video-v3.pdf

Also, do you have any exisiting website? We will need to demonstrate the embed feature.
By adding the  tag on that website.

Also, do you have any exisiting website? We will need to demonstrate the embed feature.
By adding the  tag on that website.

https://ezkdev.joulev.dev/sample/index.html
source at public/sample/index.html

If possible, I want to work on prod branch as the embed URL shown in the app only works with prod branch.
Let me check the production delopment.

Hmm okay let's merge to prod. It's stable enough already anyway.

Shipped to prod, after ~3-4 mins of building and ezkomment.joulev.dev will work.

I wish I can cut some part of the video ... just the audio.
And can you access the video now?

Yes I can, sorry I had some super-urgent business for the last hour.
Will finish everything now.

If possible, you can go download the video, cut some parts and upload it again.
Please cut "hello", and "hi" when I created a comment in the app demonstration. Why did I say these 2 words with a high note?

If possible, can you download the video, cut some parts and upload it again.
Please cut "hello", and "hi" when I created a comment in the app demonstration. Why did I say these 2 words with a high note?
It's fine to keep it tho.

Don't worry this won't be the final version of the video, we will need to submit another in the week before 20 August. I will edit it then (or edit a different video if we make another).

https://drive.google.com/file/d/15DtETTPi_e2nMCnlPB3eU5kr8kfEGImP/view?usp=sharing
MOV file, process much faster.

Codecov uploading fails? I say f*ck it, it will be rerun after merging anyway.

Don't worry, since the MP4 file has already been processed even before you uploaded the MOV file (yes I tested it)


Validate user login

Completed validating user login in [commit] (https://github.com/CPSC4720Mandela/mandela/commit/267ed867ac506b08c376220ff0dcde02e4e2f525)


Avoid unconstrained sections in allocation networks

Investigations of optimizations for allocation have shown that sometimes the results are evidently sub-optimal (and can differ significantly between different optimizers) due to unconstraint sections in an allocation network. I have identified these situations in which unconstrained sections appear:

branches that end in a terminal node. The problem here is that terminal nodes are already made part of the allocation networks (I don't remember why) but no corresponding constraints were added. These constraints will be added in https://github.com/Deltares/Ribasim/issues/708, but this was judged to be a non high priority issue. Maybe remove the terminal nodes from the allocation networks again until this issue is picked up?
Fractional flow nodes. Unlike the flow conservation constraints, the fractional flow constraints still have $\le$ constraints instead of equality constraints, as I feel equality would be too restrictive. This problem could be resolved by also adding a flow conservation constraint (with equality) to nodes which have fractional flow nodes down stream. But the overarching problem is that the fractional flow constraint should hold for the accumulated flows over all priorities, not necessarily for the flows within one priority. I think this can only properly be tackled with more clever goal programming tactics, but that would take quite some investigation to implement.

An overarching question I have here is: is there a relatively simple way to check whether such unconstraint variables exist in the model? Maybe JuMP and/or HiGHS have features for this.
This is somewhat related to https://github.com/Deltares/Ribasim/issues/1207, because there the problem can also be described as a lack of constraints. This issue is a result of investigations done in https://github.com/Deltares/Ribasim/pull/1143.

I forgot to bring up fractional flow in the meeting with the RTC-Tools team, but I realised that this can also be solved nicely with buffers. That is: use equality constraints for the relationship between the inflow and the outflow for each of the fractional flow branches, and store flow that cannot immediately be used in one of these branches in a buffer.
Note that this can lead to situations where a lot of flow ends up unused in these buffers, but I would call that a schematization issue.

Hi @SouthEndMusic : are you saying.. if a user has two outgoing edges, one with fraction 0.5 and one with fraction 0.4, you basically buffer the 0.1 portion to keep your optimization problem sane.
It is the modellers problem that the fractions do not add up to 1.0.
Now I wonder two things:

what happens if the modeller has defined fractions of 0.5 and 0.6 (total > 1)
Do we have a validaton rule that actually detects that fractions do not add up to exactly 1 ?

@gijsber that is not what I'm saying. We do have validation for the sum of fractions from fractional flow nodes adding up to approximately 1.0. Also note that this has nothing (directly) to do with UserDemand nodes.
What I am talking about is something like this:
Say we have a junction in the network with incoming branch A, and outgoing branches B and C with (fractional flow) fractions 0.1 and 0.9 respectively. Now say were are at a priority where along B there is a demand, but not along C. To bring flow to the node in branch B with the demand, we have to bring 9 times the flow to branch C, even though there is no demand there.

Hi @SouthEndMusic ,
For UserDemand I agree with you solution as given in the issue description.
For FractionalFlow @SnippenE  and me concluded that we indeed have to follow the fractional flow division (as this is what the physical layer will follow), which results in B potentially missing out on water that is requested.
If modellers are unhappy, they need to consider if they have other solutions instead of fractional flows.
If we really end up in undesirable sitautaions, we may decide to update the algorithms at a later stage, e.g. as follows:

the fractionalflow division gets a priority and becomes a goal in the optimization (instead of a onstraint), where we try to minimize the deviation from this division.
the resulting fractional division then needs to be enforced via control on the fractional flow nodes.


What Markdown engine does OPS implement?

The current docs are not consistent.
The How to use Markdown for writing Docs article says:

Additionally, Open Publishing Services (OPS) implements Markdig Markdown Parser.

I guess, it corresponds to the "markdownEngineName": "markdig" setting in the docfx.json file.
However, the Using links in documentation article says:

The docs.microsoft.com site backend uses Open Publishing Services (OPS) which implements DocFX Flavored Markdown (DFM)

Again a guess, it corresponds to the "markdownEngineName": "dfm-latest" setting in the docfx.json file.

Both DFM and Markdig. It depends on the settings in the repo / docset. I think we are migrating towards markdig, but not sure of the progress on that.

@SyntaxC4 could you confirm which markdown engine name we should lead with?

Updating the two articles to match better in #196 and #197.


Access Denied Error in Windows

I am trying to publish a db to vercel. But while issuing the below command throwing Access Denied error which is leading to RecursionError: maximum recursion depth exceeded while calling a Python object.
I am using PyCharm and Python 3.9. I have reinstalled both and launched PyCharm as Admin in Windows 10. But still the issue persists.
Issued command datasette publish vercel jmeter.db --project jmeter --install datasette-vega
PS: localhost is working fine.

I tried deployment in WSL. It is working fine https://jmeter.vercel.app/

I tried deployment in WSL. It is working fine https://jmeter.vercel.app/

@QAInsights I'm having a similar problem when publishing to Cloud Run on Windows. It's not able to access certain packages in my conda environment where Datasette is installed. Can you explain how you got it to work in WSL? Were you able to access the .db file in the Windows file system? Thank you.


[BEAM-11517] Fix test_file_loads on Dataflow

Should hopefully allow streaming pipelines to use FILE_LOADS on Dataflow.

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

[ ] Choose reviewer(s) and mention them in a comment (R: @username).
[ ] Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
[ ] Update CHANGES.md with noteworthy changes.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

GitHub Actions Tests Status (on master branch)

See CI.md for more information about GitHub Actions CI.

Run Python 3.8 PostCommit

R: @pabloem

This is great. Thanks @udim
FYI @ttanay


Aliases in Traffic Shaper Rules

Hi,
I'm checking out the latest production version of OPNsense (OPNsense 20.1.7-amd64), and I notice I still can't use aliases. This would greatly enhance the usage of the shaper configuration. Setting up a shaper configuration for a slightly more advanced network is a pain a.t.m.
Link to feature
https://......../ui/trafficshaper#rules      [then edit the rule]
Request:
Ability to use aliases in the shaper rules in the hosts/port fields
Is there any plan on implementing this feature?
Best regards,
Maarten

updated the feature request, please tell me what's missing if there is.


[BUG] listeners do not update if not present in the widget tree

Checklist before submitting an issue

[X] I have searched through the existing closed and open issues for eww and made sure this is not a duplicate
[X] I have specifically verified that this bug is not a common user error
[X] I am providing as much relevant information as I am able to in this bug report (Minimal config to reproduce the issue for example, if applicable)

Description of the bug
When using a listener, the script does not get listened to, unless it is part of the template tree.
In the minimal reproduced config, the workspace icons do not update if the line (revealer :reveal false :transition 'none' bspwm_focused) is not present.
That line was just a hacky way to force eww to start the listener.
Reproducing the issue
With the following config:
eww.yuck
(defwindow bar
  :monitor 0
  :geometry (geometry
              :x "0%"
              :y "0%"
              :width "32px"
              :height "100%"
              :anchor "center left")
  ; :stacking "fg"
  ; :wm-ignore false
  :windowtype "dock"
  :reserve (struts :distance "40px" :side "left")
  (bspwm_workspaces))

(defvar bspwm_focused_icon '')
(defvar bspwm_unfocused_icon '')

(deflisten bspwm_desktops
  :initial "[]"
  `scripts/workspaces.fish desktops`)

(deflisten bspwm_focused
  `scripts/workspaces.fish focused`)

(defwidget bspwm_workspaces []
  (box
    :orientation "vertical"
    ; Hidden but necessary. If this is not present, the listener doesn't update.
    (revealer :reveal false :transition 'none' bspwm_focused)
    (for workspace in bspwm_desktops
      (workspace_label
        :workspace workspace
        :current bspwm_focused))))

(defwidget workspace_label [workspace current]
  (label
    :class "workspace-label"
    :text {workspace == current ? bspwm_focused_icon : bspwm_unfocused_icon}))

scripts/workspaces.fish
#!/usr/bin/env fish

function _json_list
    set -l quoted (printf '"%s"\n' $argv | string join ',')

    echo "[$quoted]"
end

function subscribe_focused
    echo (bspc query -D --desktop)

    bspc subscribe desktop_focus | while read -l _ _ desktop
        echo $desktop
    end
end

function _get_desktops
    set -l initial (bspc query -D --monitor default)
    echo (_json_list $initial)
end

function subscribe_desktops
    echo (_get_desktops)

    bspc subscribe desktop | while read -l event
        set -l type (string split ' ' $event)[1]
        if test $type != "desktop_focus"
            echo (_get_desktops)
        end
    end
end

switch $argv[1]
    case focused
        subscribe_focused
    case desktops
        subscribe_desktops
    case '*'
        exit 1
end

Expected behaviour
The icon for a desktop should change to the bspwm_focused_icon on change.
Additional context
Expected behaviour

Actual behaviour (bspwm_focused variable is not updating):

The above image happens when I remove the revealer widget.

Surprisingly, this is actually a feature! The idea is that running variables when the results are never shown should be considered useless overhead, so we just don't run them unless they're used. I'm not 100% clear on your example here, but in your case I'd recommend looking if you can just combine two scripts into one with both of the info, to avoid having this issue. We may want to consider adding a flag to always run variables regardless of if they're used, although I'd argue that that probably hints at a script-structure that is questionable...

If there's any usecase that we genuinely can't fill with this, feel free to re-open or maybe turn this into a feature request, but otherwise I'll close this for now!

Imo this is very unexpected behaviour because it breaks the programmers intention. In his example the variable is crucial to display the workspaces but it's never run. The variable is clearly used to display something but it's not run.
I had a very odd issue with this where the listener would not run if I only opened the bar on my main monitor. I had to open it on both monitors for it to run.
If you want I have a simpler example that shows the issue.


deterministic test failed with there is no reactor running

Describe the bug

 Log
seed = 1
Configuration {
    config_path: Regular(
        "",
    ),
    frontend_nodes: 2,
    compute_nodes: 3,
    meta_nodes: 3,
    compactor_nodes: 2,
    compute_node_cores: 2,
    etcd_timeout_rate: 0.0,
    etcd_data_path: None,
}
thread '<unnamed>' panicked at 'there is no reactor running, must be called from the context of a Tokio 1.x runtime', /Users/noelkwan/.cargo/registry/src/index.crates.io-6f17d22bba15001f/hyper-0.14.26/src/client/connect/dns.rs:121:24
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
context: node=5 "meta-2", task=129 (spawned at /Users/noelkwan/projects/risingwave/src/common/src/telemetry/report.rs:55:23)
note: run with `MADSIM_TEST_SEED=1` environment variable to reproduce this error
noelkwan@Noels-MacBook-Pro risingwave % RUST_BACKTRACE=1 MADSIM_TEST_SEED=1 ./target/sim/ci-sim/risingwave_simulation --sqlsmith 100 ./src/tests/sqlsmith/tests/testdata
seed = 1
Configuration {
    config_path: Regular(
        "",
    ),
    frontend_nodes: 2,
    compute_nodes: 3,
    meta_nodes: 3,
    compactor_nodes: 2,
    compute_node_cores: 2,
    etcd_timeout_rate: 0.0,
    etcd_data_path: None,
}
thread '<unnamed>' panicked at 'there is no reactor running, must be called from the context of a Tokio 1.x runtime', /Users/noelkwan/.cargo/registry/src/index.crates.io-6f17d22bba15001f/hyper-0.14.26/src/client/connect/dns.rs:121:24
stack backtrace:
   0: rust_begin_unwind
             at /rustc/28a29282f6dde2e4aba6e1e4cfea5c9430a00217/library/std/src/panicking.rs:577:5
   1: core::panicking::panic_fmt
             at /rustc/28a29282f6dde2e4aba6e1e4cfea5c9430a00217/library/core/src/panicking.rs:67:14
   2: core::panicking::panic_display
             at /rustc/28a29282f6dde2e4aba6e1e4cfea5c9430a00217/library/core/src/panicking.rs:150:5
   3: tokio::runtime::scheduler::Handle::current
             at /rustc/28a29282f6dde2e4aba6e1e4cfea5c9430a00217/library/core/src/panic.rs:54:9
   4: tokio::runtime::blocking::pool::spawn_blocking
             at /Users/noelkwan/.cargo/registry/src/index.crates.io-6f17d22bba15001f/tokio-1.27.0/src/runtime/blocking/pool.rs:182:14
   5: <reqwest::dns::gai::GaiResolver as reqwest::dns::resolve::Resolve>::resolve
             at /Users/noelkwan/.cargo/registry/src/index.crates.io-6f17d22bba15001f/reqwest-0.11.17/src/dns/gai.rs:26:18
   6: hyper::client::connect::dns::resolve::{{closure}}
             at /Users/noelkwan/.cargo/registry/src/index.crates.io-6f17d22bba15001f/hyper-0.14.26/src/client/connect/dns.rs:360:5
   7: hyper::client::connect::http::HttpConnector<R>::call_async::{{closure}}
             at /Users/noelkwan/.cargo/registry/src/index.crates.io-6f17d22bba15001f/hyper-0.14.26/src/client/connect/http.rs:338:17
   8: <hyper::client::connect::http::HttpConnector<R> as tower_service::Service<http::uri::Uri>>::call::{{closure}}
             at /Users/noelkwan/.cargo/registry/src/index.crates.io-6f17d22bba15001f/hyper-0.14.26/src/client/connect/http.rs:271:61
   9: <hyper_tls::client::HttpsConnector<T> as tower_service::Service<http::uri::Uri>>::call::{{closure}}
             at /Users/noelkwan/.cargo/registry/src/index.crates.io-6f17d22bba15001f/hyper-tls-0.5.0/src/client.rs:136:33
  10: <hyper_tls::client::HttpsConnecting<T> as core::future::future::Future>::poll
             at /Users/noelkwan/.cargo/registry/src/index.crates.io-6f17d22bba15001f/hyper-tls-0.5.0/src/client.rs:162:9
  11: reqwest::connect::Connector::connect_with_maybe_proxy::{{closure}}
             at /Users/noelkwan/.cargo/registry/src/index.crates.io-6f17d22bba15001f/reqwest-0.11.17/src/connect.rs:247:40
  12: reqwest::connect::with_timeout::{{closure}}
             at /Users/noelkwan/.cargo/registry/src/index.crates.io-6f17d22bba15001f/reqwest-0.11.17/src/connect.rs:415:10
  13: <core::pin::Pin<P> as core::future::future::Future>::poll
             at /rustc/28a29282f6dde2e4aba6e1e4cfea5c9430a00217/library/core/src/future/future.rs:125:9
  14: <hyper::service::oneshot::Oneshot<S,Req> as core::future::future::Future>::poll
             at /Users/noelkwan/.cargo/registry/src/index.crates.io-6f17d22bba15001f/hyper-0.14.26/src/service/oneshot.rs:60:28
  15: <F as futures_core::future::TryFuture>::try_poll
             at /Users/noelkwan/.cargo/registry/src/index.crates.io-6f17d22bba15001f/futures-core-0.3.27/src/future.rs:82:9
  16: <futures_util::future::try_future::into_future::IntoFuture<Fut> as core::future::future::Future>::poll
             at /Users/noelkwan/.cargo/registry/src/index.crates.io-6f17d22bba15001f/futures-util-0.3.27/src/future/try_future/into_future.rs:34:9
  17: <futures_util::future::future::map::Map<Fut,F> as core::future::future::Future>::poll
             at /Users/noelkwan/.cargo/registry/src/index.crates.io-6f17d22bba15001f/futures-util-0.3.27/src/future/future/map.rs:55:37
  18: <F as futures_core::future::TryFuture>::try_poll
             at /Users/noelkwan/.cargo/registry/src/index.crates.io-6f17d22bba15001f/futures-core-0.3.27/src/future.rs:82:9
  19: <futures_util::future::try_future::into_future::IntoFuture<Fut> as core::future::future::Future>::poll
             at /Users/noelkwan/.cargo/registry/src/index.crates.io-6f17d22bba15001f/futures-util-0.3.27/src/future/try_future/into_future.rs:34:9
  20: <futures_util::future::future::map::Map<Fut,F> as core::future::future::Future>::poll
             at /Users/noelkwan/.cargo/registry/src/index.crates.io-6f17d22bba15001f/futures-util-0.3.27/src/future/future/map.rs:55:37
  21: <F as futures_core::future::TryFuture>::try_poll
             at /Users/noelkwan/.cargo/registry/src/index.crates.io-6f17d22bba15001f/futures-core-0.3.27/src/future.rs:82:9
  22: <futures_util::future::try_future::try_flatten::TryFlatten<Fut,<Fut as futures_core::future::TryFuture>::Ok> as core::future::future::Future>::poll
             at /Users/noelkwan/.cargo/registry/src/index.crates.io-6f17d22bba15001f/futures-util-0.3.27/src/future/try_future/try_flatten.rs:49:61
  23: <hyper::common::lazy::Lazy<F,R> as core::future::future::Future>::poll
             at /Users/noelkwan/.cargo/registry/src/index.crates.io-6f17d22bba15001f/hyper-0.14.26/src/common/lazy.rs:69:28
  24: <futures_util::future::select::Select<A,B> as core::future::future::Future>::poll
             at /Users/noelkwan/.cargo/registry/src/index.crates.io-6f17d22bba15001f/futures-util-0.3.27/src/future/select.rs:118:35
  25: hyper::client::client::Client<C,B>::connection_for::{{closure}}
             at /Users/noelkwan/.cargo/registry/src/index.crates.io-6f17d22bba15001f/hyper-0.14.26/src/client/client.rs:368:48
  26: hyper::client::client::Client<C,B>::send_request::{{closure}}
             at /Users/noelkwan/.cargo/registry/src/index.crates.io-6f17d22bba15001f/hyper-0.14.26/src/client/client.rs:236:61
  27: hyper::client::client::Client<C,B>::retryably_send_request::{{closure}}
             at /Users/noelkwan/.cargo/registry/src/index.crates.io-6f17d22bba15001f/hyper-0.14.26/src/client/client.rs:206:65
  28: <hyper::client::client::ResponseFuture as core::future::future::Future>::poll
             at /Users/noelkwan/.cargo/registry/src/index.crates.io-6f17d22bba15001f/hyper-0.14.26/src/client/client.rs:623:9
  29: <reqwest::async_impl::client::PendingRequest as core::future::future::Future>::poll
             at /Users/noelkwan/.cargo/registry/src/index.crates.io-6f17d22bba15001f/reqwest-0.11.17/src/async_impl/client.rs:2126:53
  30: risingwave_common::telemetry::post_telemetry_report::{{closure}}
             at ./src/common/src/telemetry/mod.rs:136:9
  31: risingwave_common::telemetry::report::start_telemetry_reporting::{{closure}}::{{closure}}
             at ./src/common/src/telemetry/report.rs:111:59
  32: madsim::sim::task::Spawner::spawn_inner::{{closure}}::{{closure}}
             at /Users/noelkwan/.cargo/registry/src/index.crates.io-6f17d22bba15001f/madsim-0.2.21/src/sim/task/mod.rs:626:27
  33: <async_task::runnable::Builder<M>::spawn_local::Checked<F> as core::future::future::Future>::poll
             at /Users/noelkwan/.cargo/registry/src/index.crates.io-6f17d22bba15001f/async-task-4.4.0/src/runnable.rs:455:26
  34: async_task::raw::RawTask<F,T,S,M>::run
             at /Users/noelkwan/.cargo/registry/src/index.crates.io-6f17d22bba15001f/async-task-4.4.0/src/raw.rs:563:17
  35: madsim::sim::task::Executor::run_all_ready::{{closure}}
             at /Users/noelkwan/.cargo/registry/src/index.crates.io-6f17d22bba15001f/madsim-0.2.21/src/sim/task/mod.rs:268:50
  36: std::panicking::try::do_call
             at /rustc/28a29282f6dde2e4aba6e1e4cfea5c9430a00217/library/std/src/panicking.rs:485:40
  37: std::panicking::try
             at /rustc/28a29282f6dde2e4aba6e1e4cfea5c9430a00217/library/std/src/panicking.rs:449:19
  38: madsim::sim::task::Executor::run_all_ready
             at /Users/noelkwan/.cargo/registry/src/index.crates.io-6f17d22bba15001f/madsim-0.2.21/src/sim/task/mod.rs:268:17
  39: madsim::sim::task::Executor::block_on
             at /Users/noelkwan/.cargo/registry/src/index.crates.io-6f17d22bba15001f/madsim-0.2.21/src/sim/task/mod.rs:235:13
  40: madsim::sim::runtime::Runtime::block_on
             at /Users/noelkwan/.cargo/registry/src/index.crates.io-6f17d22bba15001f/madsim-0.2.21/src/sim/runtime/mod.rs:126:9
  41: madsim::sim::runtime::builder::Builder::run::{{closure}}::{{closure}}::{{closure}}
             at /Users/noelkwan/.cargo/registry/src/index.crates.io-6f17d22bba15001f/madsim-0.2.21/src/sim/runtime/builder.rs:128:35
note: Some details are omitted, run with `RUST_BACKTRACE=full` for a verbose backtrace.
context: node=5 "meta-2", task=129 (spawned at /Users/noelkwan/projects/risingwave/src/common/src/telemetry/report.rs:55:23)
note: run with `MADSIM_TEST_SEED=1` environment variable to reproduce this error

To Reproduce
cargo make sslt-build-all --profile ci-sim
MADSIM_TEST_SEED=1 ./target/sim/ci-sim/risingwave_simulation --sqlsmith 100 ./src/tests/sqlsmith/tests/testdata

Expected behavior
No error
Additional context
No response

Need to disable telemetry

Can we disable telemetry by default if debug_assertions in on (while keeping the ability to enable it back)?


Icon request: Finary

URL of the site or app
https://finary.com/
Logo resources for the icon
No response
Anything else?
I tried finding a branding page or svg from them but none seems to be available :/

Found some SVG logo online (see: d23da9f9f97f1b84eb28da202d281a8fa26ebb84-120x120.svg)
So I made versions on Illustrator.

White Version
Black Version
White on Black
Black on White
W on Primary

Here is a zip with everything finary-logos.zip

Based of submissions, I can assume you didn't read the CONTRIBUTING document, which is required for submission.
Submissions should be made with seperate issue using the correct form.

I don't see what i did wrong but ok ^^

Reopened since you mentioned that these are suggestions on the comment edit.
It wasn't clear before and I assumed that this was request turn into submission, sorry.

Yea I'm sorry 😅 I'm not a designer myself, just wanted to give examples as I saw on other issues ><


Object List hover popup doesn't dispaly the full list of it's object.

VSCode Version:1.1.1
OS Version: Microsoft windows 7-6.1.7601
-Node -v4.4.5-x86
Steps to Reproduce:

Hover on the object
the list of the object hover popup displayed top position only.
3.I couldn't see the full list, even the scroll feature also not in the hover popup.

Possibly related to #2378? Also annoying me; some of Darts docs are huge!

Can u try this by fix one medium size with scrolling option? is there any problem on using this approach?

I'm not sure I understand? Issue #2378 suggests scrolling should be added; I think this case is effectively a duplicate of that?

Yes...

Do we want to make the hover scrollable @joaomoreno @jrieken

pretty sure @joaomoreno added that

It is!


[Feature Request]: Add favicon to your website

Is there an existing issue for this?

[X] I have searched the existing issues

Feature Description
Hey, i noticed that your website don't have any favicon , i would like to design a favicon and add it !

Please assign me this under gssoc and hacktober fest .THANK YOU
Use Case
Favicon is and important feature every website should have, favicon gives a unique identity for your website.
Benefits
No response
Priority
Medium
Record

[X] I agree to follow this project's Code of Conduct
[X] I'm a GSSOC contributor
[X] I want to work on this issue
[X] I'm willing to provide further clarification or assistance if needed.

assigned already


no eyeballs by default

externaltools can have type EXPLORE, PREVIEW, or (allegedly?) both. The sample instructions in README.md set type EXPLORE, which flummoxes users who aren't used to digging in the file access drop-down to preview a file. Might I safely submit a PR to set these to either PREVIEW or BOTH, or is there a reason these default to EXPLORE?

fixed in v1.2+


Home vs Tazama

Suggest to replace the "HOME" text in the menu bar with TAZAMA (using the Tazama logo, if possible).
Now:

Proposed:

please review this and see if it is good.


Ignore searches that are not defined in the model

Addresses cases where not all searches are defined in the model, as is the case in VectorBase.

Thank you!


Some Command Are Not Working and Suggestion

Some features of the code were not working properly as seen in the picture(IP detected.).

####edited version is as follows.
curl -s "https://rapiddns.io/subdomain/TARGET?full=1#result" | awk -v RS='<[^>]+>' '/TARGET/' | grep "\w.*TARGET$"|sort -u >> TARGET-rapiddns.txt  #first method
curl -s "https://rapiddns.io/subdomain/TARGET?full=1#result"| grep -oaEi "https?://[^\"\\'> ]+" | grep TARGET | cut -d "/" -f3| sort -u >> TARGET-rapiddns.txt #second method
curl -s "https://riddler.io/search/exportcsv?q=pld:TARGET"| cut -d, -f6|grep TARGET|sort -u >> TARGET-riddler.txt
curl -s "https://jldc.me/anubis/subdomains/TARGET" | jq -r '.[]' 2>/dev/null| sort -u >> TARGET-jldc.txt
curl -s "https://dns.bufferover.run/dns?q=.TARGET" | jq -r '.FDNS_A[]' 2>/dev/null|cut -d, -f2|sort -u >> TARGET-bufferover.txt

Python code
import subprocess
import concurrent.futures
import sys

try:
    # List command
    command_list = [
        f'''curl -s "https://rapiddns.io/subdomain/TARGET?full=1#result" | awk -v RS='<[^>]+>' '/TARGET/' |grep "\w.*TARGET$"| sort -u >>TARGET-rapiddns.txt''',
        f'''curl -s "https://riddler.io/search/exportcsv?q=pld:TARGET""|cut -d, -f6|grep TARGET|sort -u >>TARGET-riddler.txt''',
        f'''curl -s "https://jldc.me/anubis/subdomains/TARGET" | jq -r '.[]' 2>/dev/null|sort -u >>TARGET-jldc.txt''',
        f'''curl -s "https://crt.sh/?q=%25.TARGET&output=json" | jq -r '.[].name_value' | sed 's/\*\.//g' | sort -u >>TARGET-crt.txt''',
        f'''curl -s "https://dns.bufferover.run/dns?q=.TARGET" | jq -r '.FDNS_A[]' 2>/dev/null|cut -d, -f2|sort -u >>TARGET-bufferover.txt''',
        f'''cat TARGET-*.txt | sort -u >TARGET.txt;cat TARGET.txt -n'''
    ]

    def exe_cmd(command_str: str):
        str_format = command_str.replace('TARGET', TARGET)
        print('[ + ] PROCESS:', str_format)
        result = str(subprocess.run(
            str_format, capture_output=True,shell=True).stdout.decode('utf-8')
        )
        if result:
            print(result)

    # Using as command line
    if __name__ == '__main__':
        if len(sys.argv) == 2:
            TARGET = sys.argv[1]
            with concurrent.futures.ThreadPoolExecutor(max_workers=2) as executor:
                futures = []
                for cmd in command_list:
                    futures.append(executor.submit(exe_cmd, cmd))
                executor.shutdown(wait=True)

except KeyboardInterrupt:
    pass

Tks! solved


Support for Custom Strongly-Typed Header Deserialization

This PR contains a major update with how strongly-typed headers classes are handled during deserialization. A new AutoRest flag custom-strongly-typed-header-deserialization has been added that indicates to code generation to generate header classes with custom deserialization instead of using Jackson Databind's convertValue method. Before this change, every response with strongly-typed headers would serialize the HTTP headers to JSON to deserialize the JSON into the strongly-typed headers object. Now, when this flag is enabled the strongly-typed headers will skips that serialization-deserialization and use the raw HttpHeaders directly with predefined functions to convert to the strong property type. All properties are still eagerly deserialized to ensure any parsing exceptions are still thrown from the same point in code as before, if a breaking change was acceptable deserialization would be deferred to when the property getter was called like it was in #1271 (which is no longer relevant).
This requires the azure-core code change merge in https://github.com/Azure/azure-sdk-for-java/pull/27369

You might need to run npm install
Currently we fix the @microsoft.azure/autorest.testserver to 3.2.0 in package.json, and use swagger from<EMAIL_ADDRESS>(instead of from github) for codegen in local/CI.

You might need to run npm install (there is many deleted files in PR, your local might be an earlier version of testserver)
Currently we fix the @microsoft.azure/autorest.testserver to 3.2.0 in package.json, and use swagger from this local<EMAIL_ADDRESS>(instead of from github) for codegen in local/CI.

Thanks! I was wondering why so many files were deleted. I'll regenerate to fix that.


[slider enhancement request] add prev/next to external slider JS API

Hi;
currently there is a stop/start functionality only on the slider JS Object. when using indicators the indicators, clicks can act as a trigger for next and prev style functionality but with no indicators, using a paused slider, I would still want to be able to programatically go to the next/prev slide.
I think we need a prev/next function in the API.
thanks.

Added in 5ff3ba4


Consider always labeling nodes with the kernel version

The operator currently leaves kernel version labeling of the nodes to NFD if the KERNEL_LABELING_METHOD environment variable is set to nfd.
Given the very low overhead of this additional controller, we should consider leaving it enabled and always use its label for DaemonSet scheduling; that should make debugging and troubleshooting easier.

Tracked in Red Hat ITS as MGMT-10530.


cassandra-5.0 image

You'll need to add publish logic to .github/workflows/release.yaml for cassandra 5

We should name this 5.0-beta1 and depend on 5.0-beta1 upstream image.
Otherwise changes upstream may broke our tests.

I have tested this works with the sample docker-compose's in the readme, so looking good so far.


The Merge

To comply with The Merge we need to implment some features:

[x] #486
[x] #488
[x] default fee recipient for validator client

@NeoPlays @gbayasgalan can you please confirm that this is done?

this should done

yes same here, should be done so far


In TimeUtils.timeUnitFromString(), return null if input is null or empty

For backward compatible

Codecov Report

Merging #4088 into master will increase coverage by 6.78%.
The diff coverage is 75%.

@@             Coverage Diff             @@
##             master   #4088      +/-   ##
===========================================
+ Coverage     59.91%   66.7%   +6.78%
  Complexity       20      20
===========================================
  Files          1158    1035     -123
  Lines         58332   51376    -6956
  Branches       8101    7189     -912
===========================================
- Hits          34952   34268     -684
+ Misses        20947   14754    -6193
+ Partials       2433    2354      -79

Impacted Files
Coverage Δ
Complexity Δ

.../pinot/core/segment/index/SegmentMetadataImpl.java
81.32% <0%> (-0.69%)
0 <0> (ø)

...n/config/SegmentsValidationAndRetentionConfig.java
48.23% <100%> (ø)
0 <0> (ø)
:arrow_down:

.../org/apache/pinot/common/utils/time/TimeUtils.java
89.18% <100%> (+3.47%)
0 <0> (ø)
:arrow_down:

...r/validation/RealtimeSegmentValidationManager.java
43.33% <0%> (-11.67%)
0% <0%> (ø)

...e/impl/dictionary/LongOnHeapMutableDictionary.java
88.88% <0%> (-6.67%)
0% <0%> (ø)

.../impl/dictionary/FloatOnHeapMutableDictionary.java
86.66% <0%> (-6.67%)
0% <0%> (ø)

...e/operator/dociditerators/SortedDocIdIterator.java
55.55% <0%> (-5.56%)
0% <0%> (ø)

...e/operator/dociditerators/SVScanDocIdIterator.java
65.47% <0%> (-2.39%)
0% <0%> (ø)

...ller/validation/OfflineSegmentIntervalChecker.java
26.43% <0%> (-2.3%)
0% <0%> (ø)

...l/FixedByteSingleColumnMultiValueReaderWriter.java
68.91% <0%> (-2.08%)
0% <0%> (ø)

... and 145 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update af62e20...9694387. Read the comment docs.


ng new does not create a new project

Cannot create a new project via ng new [project name]. Tested with cmd, powershell, git bash and Intellij Idea.
Versions
Windows 10 (10.0.16299.125)
Angular CLI: 1.6.8
Node: 9.5.0
OS: win32 x64
Angular:
...
Repro steps
ng new angular_test
Observed behavior
Error message: Project name "angular_test" is not valid. New project names must start with a letter, and must contain only alphanumeric characters or dashes. When adding a dash the segment after the dash must also start with a letter.
Desired behavior
New project is created
Mention any other details that might be useful (optional)
I uninstalled and installed angular cli. Older version 1.6.1 works as expected.

Isn't this simply because you used an underscore instead of a dash? '_' vs '-'

my bad 👎 (


Trouble with the sit/sleep command

The output of /version on my server is: git-Paper-624 (MC: 1.13.2)
The output of /version denizen on my server is: 1.1.4-SNAPSHOT (build 4645-DEV)
I am placing NPC automatically and I have a code to choose the npc state between (stand, sit and sleep)
I load the chunk for 4 second and placing the npc just in those 4 second. Right after placing this NPC I set the - sit npc:<[mynpc]> and it work correctly when I join the server 10 second after the automatic execution.
For the - sleep npc:<[mynpc]> however the npc is still standing up. (It has the state sleeping but the npc is standing up)
Its maybe related to loading chunk and such because when I connect 10 second after the execution I see the npc is changing state from standing up to sit mode
I dont understand why there is a difference like this between such mode
For exemple
- choose <[pose]>:
  - case assis;
    - sit npc:<[npc_nouvellement_cree]>
  - case allonge:
    - sleep npc:<[npc_nouvellement_cree]>

Your script you pasted has clear basic errors in its syntax.
Please use the Discord to discuss issues related to recent commits / new dev builds.


fix: remove some collaborators.

Proposed changes
Issue Number: close #xxx
Problem summary
ERROR from ASF infra:
An error occurred while running github feature in .asf.yaml!: You can only have a maximum of 10 external triage collaborators.
Checklist(Required)

[ ] Does it affect the original behavior
[ ] Has unit tests been added
[ ] Has document been added or modified
[ ] Does it need to update dependencies
[ ] Is this PR support rollback (If NO, please explain WHY)

Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

run buildall


Research Migrating Storage Tests

Research migrating the Storage Blob tests from using Groovy and Spock to Java and JUnit

I've ported azure-core to junit 5 to get a sense of the difficulty in moving to this. It isn't difficult - it took me about 30 minutes to do azure-core (and subprojects). I think moving to JUnit 5 is a good first step. From there we can explore parameterised tests either through built-in annotations such as CsvSource, or else external plugins to JUnit, such as Spockito.

Draft PR was published here: #4455.

I've provided sample code for a simple case of test parameterisation here


Improvement: allow ParticleAttribute to not require a name

It could just generate a random name -- the tricky bit will be making it testable.

Long done!


fix issue #1875: MergeableClusterInvoker 超时处理逻辑问题

What is the purpose of the change
fix issue #1875: MergeableClusterInvoker 超时处理逻辑问题
Brief changelog
XXXXX
Verifying this change
XXXXX
Follow this checklist to help us incorporate your contribution quickly and easily:

[x] Make sure there is a GITHUB_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
[ ] Format the pull request title like [Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commit in the pull request should have a meaningful subject line and body.
[ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
[ ] Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
[ ] Run mvn clean install -DskipTests=false & mvn clean test-compile failsafe:integration-test to make sure unit-test and integration-test pass.
[ ] If this contribution is large, please follow the Software Donation Guide.

I am thinking of the possibility of making each remote call async: invocation.setAttachment(Constants.ASYNC_KEY, Boolean.TRUE.toString());
then, invoker.invoke() itself will return a Future like async result directly, if this result has started to count timeout from the moment its request data was sent to the remote server, we will not need to calculate timeout by ourself like what we do now for each Future.

About the original code discussed in #1875:
       for (Map.Entry<String, Future<Result>> entry : results.entrySet()) {
            Future<Result> future = entry.getValue();
            try {
                Result r = future.get(timeout, TimeUnit.MILLISECONDS);
                if (r.hasException()) {
                    log.error("Invoke " + getGroupDescFromServiceKey(entry.getKey()) +
                                    " failed: " + r.getException().getMessage(),
                            r.getException());
                } else {
                    resultList.add(r);
                }
            } catch (Exception e) {
                throw new RpcException("Failed to invoke service " + entry.getKey() + ": " + e.getMessage(), e);
            }
        }

I think if the global timeout is 5s, then each invoker.invoke() has been restricted to return a value in 5s (it can be a normal value or timeout exception), it will in turn complete the corresponding future, so all future.get will not block and will return immediatelly after 5s.

after discuss with @chickenlj, we believe the original logic can handle the scenario the issue#1875 reports.


version for 1.0?

Was there ever a version of this script for autohotkey 1.0?

no, this script was made for autohotkey v2 since the first release.


secret-handshake: remove tests for numbers > 31

I saw a solution which just returned an empty list for all numbers >= 32. This is obviously wrong, as the 5 least significant bits should define the sequence of signals, no matter how large the number is. However, the current test suite tests only 32, and so all the tests passed for this solution.
I added therefore a couple of test cases for numbers > 32.
Not sure if the problem description should also be updated to make this clearer.

if the problem description should also be updated to make this clearer.

If it did, then it would close #335.

And I don't know about y'all but I personally ask a lot out of my READMEs. Maybe nobody else cares.

While I appreciate the PR, I'm against adding tests for numbers bigger than 32 as it adds a requirement for bitmasking / modulo usage that is not otherwise required.
I like that it is possible* to solve the current version with a giant case statement or lookup table.
* Although don't think these are necessarily "best practice" solutions.

An interesting question to be had as well - should 32 be removed too?

Ok, it could make sense to have only numbers up to 2^5 = 31 in the canonical test data and leave the testing of larger numbers to the tracks. After all, I don't know what support for bitwise operation all these languages have, so the exercise could be solved in different ways in different languages.
So in this case I think that also 32 should be removed as it has a bit set beyond the 5 lowest bits. Just for consistency.

32 should be removed as it has a bit set beyond the 5 lowest bits.

If you could add a comment about deliberately only testing 0-31  to the json file that would be great.
See an example of how this is handled in triangle

Done 👍

Looks good, 👍 Just some minor wording clarifications. Feel free to disagree with them.

@Insti thanks for the suggestions, I adapted the wording.

Another question: should we also mention something about negative numbers?
A solution using bitwise operations would naturally also work with negative numbers. However, for other types of solutions this would be more difficult and it depends on the used signed number representation.
Or would this make the exercise too complicated?

I think it's fine not to mention negative numbers at all.

I also prefer to keep it simple and not introduce negative numbers. If a track really wants to do it, they can still do it, for example, Java in which the signed number representation is defined by the JVM.

The comment:

In a discussion in #794 and #335 it has been decided to only include numbers between 0 and 31 (00000 to 11111) in the canonical test data.

Already covers not including negative numbers.
The only slight change I would suggest is replacing the #794 and #355 with the real links https://github.com/exercism/x-common/pull/794 and https://github.com/exercism/x-common/issues/335

Should I squash the 4 commits into 1?

Yes, that sounds like a good idea in this case.

Squashed!

A long time without objections, so let's take it. Thanks.


Failed to autodetect applicationId in multi-flavor project

Build/Submit details page URL
No response
Summary
Trying to build Android project with flavors gives the following error, although it works fine outside EAS.
Unable to read gradle project config: flavor dev is not defined.
Values from app/build.gradle might be resolved incorrectly.
Specified value for "android.package" in app.json is ignored because an android directory was detected in the project.
EAS Build will use the value found in the native code.
Failed to autodetect applicationId in multi-flavor project

Managed or bare?
Bare
Environment
expo-env-info 1.0.5 environment info:
    System:
      OS: Windows 10 10.0.22621
    Binaries:
      Node: 20.9.0 - C:\Program Files\nodejs\node.EXE
      Yarn: 1.22.19 - C:\Program Files (x86)\Yarn\bin\yarn.CMD
      npm: 10.1.0 - C:\Program Files\nodejs\npm.CMD
      Watchman: 20230709.023423.0 - C:\ProgramData\chocolatey\bin\watchman.EXE
    SDKs:
      Android SDK:
        API Levels: 33, 34
        Build Tools: 28.0.3, 30.0.3, 33.0.0, 33.0.1, 34.0.0
        System Images: android-27 | Google Play Intel x86 Atom, android-33 | Google Play Intel x86 Atom_64, android-34 | Google APIs Intel x86_64 Atom
    IDEs:
      Android Studio: AI-212.5712.43.2112.8815526
    npmPackages:
      expo: 49.0.16 => 49.0.16
      react: 18.2.0 => 18.2.0
      react-native: 0.72.6 => 0.72.6
    Expo Workflow: bare

Error output
AmbiguousApplicationIdError: Failed to autodetect applicationId in multi-flavor project.
    at getApplicationIdFromBareAsync (node_modules\eas-cli\build\project\android\applicationId.js:62:19)
    at async createAndroidContextAsync (node_modules\eas-cli\build\build\android\build.js:44:27)
    at async createBuildContextAsync (node_modules\eas-cli\build\build\createContext.js:91:22)
    at async prepareAndStartBuildAsync (node_modules\eas-cli\build\build\runBuildAndSubmit.js:169:22)
    at async runBuildAndSubmitAsync (node_modules\eas-cli\build\build\runBuildAndSubmit.js:83:49)
    at async Build.runAsync (node_modules\eas-cli\build\commands\build\index.js:41:9)
    at async Build._run (node_modules\eas-cli\node_modules\@oclif\core\lib\command.js:80:22)
    at async Config.runCommand (node_modules\eas-cli\node_modules\@oclif\core\lib\config\config.js:272:25)
    at async Object.run (node_modules\eas-cli\node_modules\@oclif\core\lib\main.js:74:5)

Reproducible demo or steps to reproduce from a blank project
flavorDimensions "default"
    productFlavors {
        create("dev") {
            applicationId "com.xxx.dev"
            resValue "string", "app_name", "xxx"
            resValue "string", "build_config_package", "com.xxx"
        }
        create("stag") {
            applicationId "com.xxx.stag"
            resValue "string", "app_name", "xxx"
            resValue "string", "build_config_package", "com.xxx"
        }
        create("prod") {
            applicationId "com.xxx.prod"
            resValue "string", "app_name", "xxx"
            resValue "string", "build_config_package", "com.xxx"
        }
    }

Have you managed to fix this issue? I'm encountering right now and I have no clue on how to fix it. Android studio's build works just fine but eas-cli doesnt

Have you managed to fix this issue? I'm encountering right now and I have no clue on how to fix it. Android studio's build works just fine but eas-cli doesnt

No, had little time to dig into it.

@ThomasBizeta what does your eas.json and productFlavors look like? I had the same error message and got this working with the following:
build.gradle
productFlavors {
    production {
        dimension "profile"
        applicationId "..."
    }
    preview {
        dimension "profile"
        applicationId "..."
    }
}

eas.json
"build": {
  "preview": {
    ...
    "android": {
      "gradleCommand": ":app:bundlePreviewRelease"
    },
  },
  "production": {
    ...
    "android": {
      "gradleCommand": ":app:bundleProductionRelease"
    },
  }
},

The key for me was to make sure flavorDimensions was a string, not an array (even though Android Studio gives a deprecation warning) and use specify the gradleCommand in the config.

Ok, the fix is straightforward, remove "applicationIdSuffix" and add "applicationId"

Ok, the fix is straightforward, remove "applicationIdSuffix" and add "applicationId"

My eas.json and productFlavors are basically the same as yours
    flavorDimensions 'Variants'     productFlavors {         'xxx' {             dimension 'Variants'             applicationId "xxx.xxx.xxx"         }         'yyy' {             dimension 'Variants'             applicationId 'yyy.yyy.yyy'         }         'zzz' {             dimension 'Variants'             applicationId 'zzz.zzz.zzz'         }     }
"android": {
     "gradleCommand": ":app:assembleyyyRelease"
   },


Add CSS font-synthesis

This is a duplicate of https://github.com/Fyrd/caniuse/issues/1799

Yup, available at https://caniuse.com/#feat=mdn-css_properties_font-synthesis


IAM

[x] AWS::IAM::AccessKey
[x] AWS::IAM::User
[x] AWS::IAM::Role
[x] AWS::IAM::Policy
[x] AWS::IAM::InstanceProfile
[ ] Unit tests

Role and Policy are now committed and showcased in the examples/lambda-features-demo/blueprint.yaml blueprint.

All required IAM features have been committed. Please review.

@EarthmanT where is InstanceProfile implemented? not found in plugin.yaml.


Provide support for relative file uris?

This is specifically regarding URIs of the form "file:path/to/somewhere"
We should provide a correct error message for now, and in case pathlib or we decide to support parsing relative path uri's we can switch, see:

https://github.com/fsspec/universal_pathlib/commit/662c2943deff680423e048f62326cfdb8405ef09#r123906140 expecting support for file:path/file.txt
https://github.com/python/cpython/pull/107640

Originally posted by @ap-- in https://github.com/fsspec/universal_pathlib/issues/108#issuecomment-1696410259

Hi!
Thanks for opening this issue - I had to take some time off and never got round to doing it myself.
I'm mainly interested in data uris (which I want to support in euporie), which consist of a scheme and a rootless path, with no authority part, query string, or fragment, e.g.:
data:image/jpeg;base64,/9j/4AAQSkZJRgABAgAAZABkAAD

\__/ \__________________________________________/
 |                       |
scheme                  path

I think you previously said you don't want to support these in universal_pathlib, but it would be nice to be able to write a UPath subclass and integrate them via the registry system.
This worked previously, but changing to using fsspec.core.split_protocol to extract the uri scheme broke this, as the current implementation assumes the path is absolute, or that an authority is present.
:slightly_smiling_face:

In the draft-PR #152 for Python 3.12 support I kept your data uri usecase in mind and switched to a non-fsspec split_protocol implementation. This will at some point become the default implementation for all python versions.
And yes, while I still think that a data UPath class shouldn't necessarily be shipped in universal_pathlib, I fully agree that we shouldn't make it hard for a custom implementation to interpret the path part of the uri in whatever way possible.
So in the meantime, since euporie is one of the popular dependents I'd be happy to keep your custom use case working. If you could make a PR that adds a minimal 3rd-party test (like in https://github.com/fsspec/universal_pathlib/blob/main/upath/tests/third_party/test_pydantic.py) for the data UPath usecase in euporie, that would be great. (As I understand these tests should then fail for the current version)
I can then start working on backporting some of the stuff from #152 to the current implementation.


Upgraded ember-cli-deploy-revision-data to v3

Aims to remove a CVE that underlies the version of simple-git used in v1 of ember-cli-deploy-revision-data.
It looks like the breaking changes are dropping support of older versions of node so we should be fine

@kiwi-josh there were issues doing a pure npm install because of conflicting dependencies so this was achieved by adding --force. I'm not sure if there are any concerns with that.

The dependencies seemed in unrelated packages, not the one I'm upgrading.


Add @callback definition on generated functions.

Right now applications that use a lib generated with oapi_generator has hard times in testing because there's coupling with the generated functions and client.
Obviously you can pass a custom client just for testing, but this means that the caller must "mock" the http calls, which is not correct because is an implementation detail of the generated library.
The approach is to use behaviours  which allows to easily mock with tools like Mox, Hammox, etc so the user of the generated library can create a fake module implementing the very same api interface as the generated operations.
This PR just adds @callback along to docs and specs which allows to use the generated operation module also as a behaviour for testing.
(I've also experimented in generating a separated behaviour module and make the operation module an impl of it, which works ok but maybe is a bit too much and not really needed, after all this will be used only for testing)

Hi @xadhoom, with the 1.0.0 line of the code (release candidate available now), I took a different approach to enable things like this. Anyone can implement changes to the rendered code using the new plugin system.
With that said, I think adding @callback attributes might be popular enough to include as an option (default off) in the default implementation of the renderer. If you agree, we could do this in a separate branch (due to the large number of code changes).

Hi, thanks for the heads up. Never add the time to check the latest changes, but the plugins system seems great, will check it out soon.
For the @callback attribute well yes I agree that having as default, without having to add a custom plugin, is reasonable. Do you want me to tackle it in the current main branch? I'll need some time to grok all the new changes.


PVC disks fail if they are block PVs

In 1.9 Kube supports block PVs.
If such a PV is used with KubeVirt, then it will fail with
      message: 'server error. command Launcher.Sync failed: virError(Code=38, Domain=18,
        Message=''Cannot access storage file ''/var/run/kubevirt-private/vm-disks/pvc1/disk.img''
        (as uid:107, gid:107): No such file or directory'')'

PR #808 should fix this.

@fabiand can we please push it?

cc @aglitke

It is still blocked by Kubernetes/openshift.
There is upstream and RH/openshift work to fix this: https://bugzilla.redhat.com/show_bug.cgi?id=1581614

Dropping critical urgent, as we need to wait until it stabilizies until we can actually complete our work.

/remove-lifecycle stale

/assign slintes

Assigned to you @slintes because it should be fixed by #1540


STORY: Validate state for hourly apportioned emissions

User Story
As a user I want to enter valid filter criteria for state so that I can see results
Acceptance Criteria
Given that a user has entered valid filter criteria for state (see below)
When the API endpoint is executed
Then the system validates the criteria and displays the results
Given that a user has entered invalid filter criteria for state (see below)
When the API endpoint is executed
Then the system will return a validation error collection (400 code)
State does not match the list of 60 records in the DB table (50 states + AS, DC, FM, GU, MH, MP, PR, PW, UM, VI)
The state or territory is not valid. Please enter a valid state or territory using the two letter postal abbreviation (use TX, not Texas).
Testing
Test Case: TC68
Tester: @davidkwartler

https://cvpcorp.testquality.com requirement R15. Do not remove or edit.

@tlageman-epa Added dev tasks to story:

#601 Create State Entity and Repo
#603  Add State Validation

began testing 12/28, will get test cases approved tomorrow 12/29

TC68 passes


Discrepancy in color shades used in pie charts

Contribution guidelines

[X] I've read the contribution guidelines and wholeheartedly agree

Description
On the Projects of Interest landing page, same color shade has been used to represent multiple entities in the pie chart. Not being able to map the entity values to the pie chart.
Expected behaviour
The pie chart should use different shades that are distinguishable to reflect each distinct entity on the chart.
Actual behaviour
Same color shade is used to reflect data for two entities on the pie chart.
Steps to reproduce
It is very much visible on the landing page for Projects of Interest.
Relevant screenshots
Note able to attach screen shot
What browsers are you seeing the problem on?
No response
Relevant log output
No response

Fixed by @sudhirverma.


TTL field doesn't unmarshal to the appropriate time

When model field is marked with ttl: true, it accepts a date object and is stored as a value in epoch seconds in Dynamo since Dynamo TTL fields require the value to be in seconds. When this is then loaded back out of dynamo, it initializes a Date object, but it doesn't get multiplied by 1000, leaving the date to be in the year 1970.

Can you post a reproduction as per the template for us to reproduce and check it out.
Thanks.

TransformReadAttribute has code to handle this. So it should work.
A test case is needed:
    transformReadAttribute(field, name, value, params, properties) {
        if (typeof params.transform == 'function') {
            //  Invoke custom data transform after reading
            return params.transform(this, 'read', name, value, properties)
        }
        if (field.type == 'date' && value != undefined) {
            if (field.ttl) {
                return new Date(value * 1000)
            } else {
                return new Date(value)
            }
        }

Ah, it looks like this was fixed in v2.5. I'm running 2.3.8 presently.


Improve Darwin support

This PR aims to improve support for Darwin operating systems (macOS).
Although this does not completely add support for macOS yet, it fixes some bugs that occur when running the tutorials on macOS or Windows.

Fixes #7 by replacing the add_paths_venv.sh shell script by a add_paths_venv.py python script which does not use readlink or realpath directly.
Fixes an error that occurs when get_nb_cpus_total or get_nb_cpus_isolated is called on macOS or Windows.

Note: running the tutorials on macOS still throws an exception due to a check that validates whether the operating system is supported. Adding Darwin to this check prevents the error. (I didn't add it in this PR to because macOS isn't officially supported yet.)

@seppewyns hello Seppe! Could you please rebase your PR against main? As is, the merge is blocked by à conflict.

@apaolillo I just pushed the rebased commits. I also added the ability to specify a venv path as introduced in d655887.


Export NASA email list

The EmailsExportWorker exports the beta list by getting queued and sending :beta to the exporter. It should also send :nasa.
https://github.com/zooniverse/panoptes/blob/master/app/workers/emails_export_worker.rb#L14

closed by #3788


Initial display on opening large files

When opening a larger file, there is a delay until the subviews (gutter and minimap) and also the main text are rendered in their final form. (The latter especially if the scroll position is further down the file.)
The main reason for this delay is that the NSLayoutManager simply takes a while to lay out the text and there is not much we can do about this. For example, the size of the visible document highlight box on top of the minimap is dependent on the length of the text document, and (with word wrapping) we won't know that until the entire layout is complete.
Nevertheless, we at least need some placeholder views and we can also do better (at least, approximate) for, at least, the gutter. However, this is more of a visual issue than one of performance; hence, I'm keeping it on the back burner for now.
(Suggestions on how to best tackle this are very welcome.)
NB: We still don't use TextKit 2 yet; maybe that has better performance.

This has been fixed with the transition to TextKit 2.


Download HD Profile Photo

Is there a way i can only download all the usernames profile photo in HD?

If logged in, profile pics get downloaded in the best resolution available. The flag --no-posts prevents downloading posts, so that only the profile pic is downloaded.


Unlink payout account

Currently I can not unlink a payout account from an organization.

Picking this up in our backlog. We help users with this in support, but it's an annoying inconvenience in case of issues during onboarding.
However, we need to manage cases where the organization might have active transactions/balance, e.g disallow changing until an account has been emptied. Additionally, it opens up some fraud vectors we need to consider, e.g users changing account frequently to avoid KYC etc.


TooManyConnections is thrown prematurely due to bad ">=" logic

Logic includes "=", whereas exception should be only thrown when this is greater than ">".

it`s not main repository for asyncmongo.
please pull to bitly/asyncmongo.

Will do. Thanks.
On Wed, Oct 12, 2011 at 1:04 PM, energycsdx <
<EMAIL_ADDRESS>
it`s not main repository for asyncmongo.
please pull to bitly/asyncmongo.
--
Reply to this email directly or view it on GitHub:
https://github.com/energycsdx/asyncmongo/pull/1#issuecomment-2384168


Breaking Slope in survival causes game Crash (1.20.1)

i am about to build a race track and ive noticed that when breaking a Slope with any tool or bare hand it causes a game crash
exit code: -1
The game crashed whilst tesselating block model
Error: java.lang.NullPointerException: Cannot invoke "net.minecraft.client.renderer.texture.TextureAtlasSprite.m_118409_()" because "sprite" is null

dupe #67

Same issue, breaking slopes cause instant client crash on any client. 1.20.6 Forge

dupe #67

It's happening to me (again) in Forge 1.20.1 with the fix published on #67


cross-repo workflow triggering

This repo contains the integration tests for the repo https://github.com/stackabletech/agent. A smooth CI workflow would require these tests to run for every PR or change on main on the other repo. This is not supported by GitHub out of the box, so we should try to make it work 'somehow'...

Triggering workflows from workflow runs in other repos can be achieved but is a little awkward:
Let's assume a workflow run in repo A should trigger another workflow in repo B:

A (human!) GitHub user with (full!) access to repo B has to create a personal token
This token has to be added as a secret to repo A (or the whole organization...)
Within the workflow in repo A, the workflow in repo B has to be triggered via the GitHub API (HTTP)
The granularity of the granted credentials is quite low, so you have to give full access to all public repos that the user has access to.

All this is doable, but the idea of someone giving away his or her credentials in that way is not practicable imho...

In a discussion with @soenkeliebau, @lfrancke , @razvan  and @siegfriedweber  we agreed that the described way using GitHub Actions is not a viable option for Stackable. Therefore we should start a task to evaluate other CI solutions.


dApp: Prevent layout from breaking on mobile

Fixes #1838
Short description
Mobile adjustments for:

Select Hub screen
Channels list in Channels screen
Transfer stepper in Transfer Summary screen

Definition of Done

[x] Steps to manually test the change have been documented
[x] Acceptance criteria are met
[ ] Change has been manually tested by the reviewer (dApp)

Steps to manually test the change (dApp)

Visit above mentioned routes and view them on mobile

channels view is ok

The text interlacing in the transfer is also resolved.


Adding Support for Amazon Linux 2, Docker, and EKS CIS Benchmark

Issue: #245 and #99
Description of changes:

Adds scripts for Amazon Linux 2, Docker, and EKS benchmarks so that they are explicitly applied
Consolidates some installation scripts

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

i assume there are no plans on getting this work merged?

@arhea the PR needs a bit of work to solve the conflicts.

I don't think this is merge-able in its current form. Docker is on it's way out in this AMI (though the EOL date has admittedly been punted a couple times). There's a handful of miscellaneous changes that should be in separate PR's. There's a moderate number of conflicts to be addressed.
I'm going to close this in favor of a new PR that addresses #99, which can use some of the work done here.


Intermittent test failure with Remote host closed the connection before initiating inbound response error

Description:
Observed an intermittent test failure for the following scenario.
There is a mock server which runs on the port (9093) and test cases were written based on the mock. And there is a separate test to check the readiness of above mentioned mock server by doing a tcp-dial. (the same port is used for the tcp-check as well)
isolated function tcpDialCheck(string address, int port, decimal timeout) returns int | error {
    tcp:Client socketClient = check new(address, port, timeout = timeout);
    check socketClient->close();
    return http:STATUS_OK;
}

Tests were intermittently failing with the error  Remote host closed the connection before initiating inbound response
Steps to reproduce:
Affected Versions:
slbeta1
OS, DB, other environment details and versions:
Related Issues (optional):

Suggested Labels (optional):

Suggested Assignees (optional):

Tested locally on Ballerina Swan Lake Beta 4. Seems the issue is fixed as it couldn't be reproduced. Hence closing the issue.


Local variables not showing

Hi I hit some issues when I was trying to use the plugin, the debugger managed to step through the tasks but I cannot inspect any local variables defined in the function.

Is there something wrong with my configurations that I could try to avoid? Cause in the higher stack functions I can see some local vars displaying.

I just tried with another GBDK project and local variables worked just fine. I'm afraid without your files, I'm not able to figure out what's wrong.

Which version of GBDK and SDCC? And did you (re)build everything with debug symbols? Does any function from this file show local variables?

actually, I noticed I cannot replicate the issue since I redownload the files from my repo, please close this ticket for now maybe better to report it later once I am able to replicate the issue and also can capture more details around it. Thanks guys.


Accuracy is very less

I tried this however the accuracy is too low and it jumps. why so?

@Zumbalamambo I think, your classifier.pkl file is likely to be incomplete. I recently committed(e4cfc5f) to the Readme.md file about how to use the code. Please refer to this commit and follow it slowly.

I tried this however the accuracy is too low and it jumps. why so?

Have you tried to improve accuracy?


Fix vs code project

Removes unnecessary trailing whitespace from VSCode Project template
Fixes compile issues due to SetCameraMode call and missing argument to UpdateCamera call.

@Shoozza thanks for the review!


Update towhee version

Signed-off-by: Binbin Lv<EMAIL_ADDRESS>

Codecov Report

Merging #1539 (182903f) into main (20eb367) will decrease coverage by 0.01%.
The diff coverage is n/a.

:exclamation: Current head 182903f differs from pull request most recent head 771b622. Consider uploading reports for the commit 771b622 to get more accurate results

@@            Coverage Diff             @@
##             main    #1539      +/-   ##
==========================================
- Coverage   70.03%   70.01%   -0.02%
==========================================
  Files         347      347
  Lines       20247    20247
  Branches     3256     3256
==========================================
- Hits        14180    14176       -4
- Misses       5166     5169       +3
- Partials      901      902       +1

Impacted Files
Coverage Δ

towhee/dataframe/dataframe.py
73.10% <0.00%> (-1.05%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 20eb367...771b622. Read the comment docs.

/lgtm


Bump rand to 0.8 and remove rand_xorshift

This is currently a draft PR, since there are still a number of libraries in arkworks-rs that needs to be adjusted to ark_std::rand, including the public repos crypto-primitives, curves, pcd and some private repos.
Since we have test_rng, it is planned to retire rand_xorshift.

btw @weikengchen , any updates on this?

Let me do a final pass on existing repos under arkworks.

All repos in arkworks have been modified, and I think it is ready to bump the version.
Note that after this PR, some post-merging actions are needed---I doubt rand_chacha 0.2 would work for rand 0.8, and we may need to bump it to rand_chacha 0.3 after this PR.

Since I don't have write access to this repo and it seems that this PR needs to sync with the master updates...I would leave this one to @Pratyush for a final pass.

(Bump)

Let me close this one and recreate it (the conflicts cannot be resolved in the web editor).


Default to not interpreting string-based values.

Addresses #11 and #9.

Given our recent discussions, I think the new AttributeEntry would be perfect to contain the typed values.
We can close this merge request, and when I get to implementing AttributeEntry, I'll make sure string-based values are representing as strings by default.


fix(include): use correct id to stop continuous polling

I'm not sure how this worked previously for the cap sensor, but we were having issues with the pressure sensor because we were using the incorrect token to stop the poll.

Codecov Report

Merging #659 (ec2fc1c) into main (6d78c60) will not change coverage.
The diff coverage is 0.00%.

@@           Coverage Diff           @@
##             main     #659   +/-   ##
=======================================
  Coverage   84.86%   84.86%
=======================================
  Files          87       87
  Lines        3786     3786
=======================================
  Hits         3213     3213
  Misses        573      573

Impacted Files
Coverage Δ

include/sensors/core/tasks/capacitive_driver.hpp
84.14% <0.00%> (ø)


Bad experience when credentials are missing

Could we rewrite the message such that it makes more sense to the user, such as

No credentials found. You need to setup credentials because...

Also, we should provide actions to guide the user to set up the credentials.

It looks like the error messages are not properly formatted:

Yeah let's close it.


Firefox Support

I've been a long time user of Firefox, and for a while I was able to load this extension as a temporary add-on (I assume this was before aligning it with Manifest V3). As someone with no experience in WebExtensions development, what exactly is the primary issue preventing this from working on Firefox now? From a quick skim of resources Mozilla seems to declare that they're supporting V3, but maybe you can shed some more light on the subject.

Per discussion on Discord, it appears the blocker in Firefox is support for background service workers for Manifest V3 https://bugzilla.mozilla.org/show_bug.cgi?id=1573659

Besides the lack of background service worker support in Firefox, there is another issue. The MAIN ExecutionWorld isn't supported by Firefox yet, which the extension uses to inject the webxr-polyfill. See: https://bugzilla.mozilla.org/show_bug.cgi?id=1736575
It's relatively straightforward to get something working as the background service worker can be swapped out for a background event page/script (I believe that is Firefox only when used with Manifest v3) and injecting the webxr-polyfill.js into the document from a content script instead of as as content script.
I created a fork with the above two changes and it seems to work surprisingly well. :slightly_smiling_face:
There is only one minor inconvenience. The execution of the polyfill script isn't guaranteed to be before the other scripts on a page, so a page might conclude that WebXR isn't supported. Setting dom.vr.webxr.enabled to true in about:config effectively works around this issue as the page either detects the "real" WebXR API or the polyfill, but once you enter an immersive session it uses the polyfill
Link to the fork: https://github.com/mrxz/immersive-web-emulator

any idea when this will happen?


Implement production ready setup with reader/writer worker split

The application is currently reliant on the Flask development mode setup since data is gathered and stored in single-process available Python global maps.
Flask is meant to be run behind some server type (sometimesa WSGI, gunicorn being one example). These servers spin up multiple instances of the Python program to help with load balancing and app runs.
The application data system is not prepared for this. Each gunicorn process would have its own global data store, meaning the app would be bashing RPC servers on a per-worker basis.
The application needs to be moved to a more production-ready state. One way would be to implement application modes for reader/writer process splitting such as:

Reader mode -> a Flask application that reads from an external data store and responds to requests
Write mode -> a Python application that writes to an external data store
Data store layer -> A data storage location that both reader and writer interface with

A production deployment would then look like:

A gunicorn server that spins up multiple Reader mode versions of the application
A writer process that writes to the data store
A shared data storage layer

Work had started here: https://github.com/DefiantLabs/cosmos-upgrades/tree/feat/production-ready-build
This was a very quick v1 of a possible reader/writer split that was working with a shared a FileSystem cache between the two workers with an example Docker Compose build linking the 2.
A more complex setup with an underlying database layer replacing the FileSystem cache may be a better move.


Best way to handle Models inside Models on a single Document?

I have a document that has the following structure:
CustomerSaleHistory

CustomerID
Sales[]

Sale
Sale
Sale

I want to be able to return back discrete classes for CustomerSaleHistory, a Collection fo Sales[], and Sale for each sale.
Currently I'm using accessors to "hack" this functionality to return classes when interacting with the CustomerSaleHistory, but convert the data back to simple arrays when saving CustomerSaleHistory.
Has anybody solved this scenario in an elegant way?

This should probably be in Discussions
Looks like embedsMany() does what I need it to

Reopening for future devs. You probably shouldn't use embedsMany because it will be removed in v4 of this repo.
I would recommend using casts to manipulate the data for you

In my case I did this (using vkovic/laravel-custom-casts because we are on Laravel 6 on this project)

namespace ITMedia\Customer\SaleHistory\Model\Casts;

use ITMedia\Customer\SaleHistory\Model\Sale;
use Vkovic\LaravelCustomCasts\CustomCastBase;

class SalesToSaleCollection extends CustomCastBase
{
    public function setAttribute($sales)
    {
        $array = [];
        foreach ($sales as $sale) {
            $array[] = $sale->toArray();
        }
        return $array;
    }

    public function castAttribute($sales)
    {
        $collection = collect();
        foreach ($sales as $sale) {
            $collection->push(new Sale($sale));
        }

        return $collection;
    }
}```


Block input when the game ends

Problem
When I'm in time trouble and just spamming hjkl more often than not when the time runs out I accidentally start the new round without seeing the score.
Solution
Block user input for some time (e.g. 1 second) right after the game ends (when the score text is displayed), or specify the new keymap for starting the game (e.g. n or s).

Good point, I've run into this as well. Thanks! I'll update this ASAP.

Added a 2.5 second timeout for now, can be adjusted in the future if needed :)

Feels good! Thanks


Fix flaky test.

This integration has had flaky builds while building in Circle CI.
The failure would occur in

Mixpanel after loading #track should should update people property if the event is in .increments FAILED

Logging false == true in this test.
The test is verifying that the last seen date is set properly. When console.logging the output of getTime, you can see why the test is flakey:
        console.log(new Date().getTime());

       ✗ should should update people property if the event is in .increments
    false == true
LOG LOG:<PHONE_NUMBER>110
LOG LOG:<PHONE_NUMBER>111

They are a milisecond off, thus the false == true assertion. You can see historically that rebuilding multiple times would eventually have the test passing, betting on the potential methods capturing the same time. If you look at the historical builds on master in CI, you can see the failure occurred in the same place.
This fix is to mitigate the flaky test, and will assert that the integration is using the correct date with some level of tolerance (a second in this case).

@ucarion yup! I just wanted to keep the changes separated for easy code review