Collect returns an empty result.

I tried obtaining a nested value between the parent uniquely and all it's children.
the following query returns empty on children.

SELECT * from cypher('text_test', $$
          MATCH (V)-[R:connect]->(V2)
          RETURN V,collect(V2.tag)
$$) as (V agtype, V2 agtype);

{"id":844424930131987,"label":"node","properties":{"tag":"div","attrib":"{\"id\": \"second\", \"class\": \"below\"}"}} | []
-- | --
{"id":844424930131973,"label":"node","properties":{"tag":"body","attrib":"null"}} | []
{"id":844424930131970,"label":"node","properties":{"tag":"head","attrib":"null"}} | []
{"id":844424930131985,"label":"node","properties":{"tag":"div","attrib":"{\"id\": \"innertwo\"}"}} | []
{"id":844424930131978,"label":"node","properties":{"tag":"div","attrib":"{\"id\": \"idone\", \"class\": \"classone\"}"}} | []
{"id":844424930131974,"label":"node","properties":{"tag":"ul","attrib":"{\"class\": \"menu\"}"}} | []
{"id":844424930131988,"label":"node","properties":{"tag":"div","attrib":"{\"class\": \"inner\"}"}} | []
{"id":844424930131983,"label":"node","properties":{"tag":"div","attrib":"{\"id\": \"innerone\"}"}} | []
{"id":844424930131979,"label":"node","properties":{"tag":"ul","attrib":"{\"class\": \"listing\"}"}} | []
{"id":844424930131969,"label":"node","properties":{"tag":"html","attrib":"{\"lang\": \"en\"}"}} | []

Is it possible to give some more information about the date in your graph? E.g. the result of
SELECT *
FROM cypher('text_test', $$
          MATCH (V)-[R:connect]->(V2)
          RETURN V, R, V2
$$) as (V agtype, R agtype, V2 agtype);

The following minimal example seems to work:
Setup
SELECT *
FROM cypher('test_graph', $$
    CREATE (n:person {name: 'parent'})
    RETURN n
$$) as (n agtype);

                                          n
--------------------------------------------------------------------------------------
 {"id":<PHONE_NUMBER>31972, "label": "person", "properties": {"name": "parent"}}::vertex
(1 row)

SELECT *
FROM cypher('test_graph', $$
    CREATE (n:person {name: 'child1'})
    RETURN n
$$) as (n agtype);

                                          n
--------------------------------------------------------------------------------------
 {"id":<PHONE_NUMBER>31973, "label": "person", "properties": {"name": "child1"}}::vertex
(1 row)

SELECT
 FROM cypher('test_graph', $$
    CREATE (n:person {name: 'child2'})
    RETURN n
$$) as (n agtype);

                                          n
--------------------------------------------------------------------------------------
 {"id":<PHONE_NUMBER>31974, "label": "person", "properties": {"name": "child2"}}::vertex
(1 row)

SELECT *
FROM cypher('test_graph', $$
    MATCH (p:person {name:'parent'}), (c1:person {name:'child1'})
    CREATE (p)-[:connect]->(c1)
    RETURN p, c1
$$) as (p agtype, c1 agtype);

                                          p                                           |                                          c1
--------------------------------------------------------------------------------------+--------------------------------------------------------------------------------------
 {"id":<PHONE_NUMBER>31972, "label": "person", "properties": {"name": "parent"}}::vertex | {"id":<PHONE_NUMBER>31973, "label": "person", "properties": {"name": "child1"}}::vertex
(1 row)

SELECT *
FROM cypher('test_graph', $$
    MATCH (p:person {name:'parent'}), (c2:person {name:'child2'})
    CREATE (p)-[:connect]->(c2)
    RETURN p, c2
$$) as (p agtype, c2 agtype);

                                          p                                           |                                          c2
--------------------------------------------------------------------------------------+--------------------------------------------------------------------------------------
 {"id":<PHONE_NUMBER>31972, "label": "person", "properties": {"name": "parent"}}::vertex | {"id":<PHONE_NUMBER>31974, "label": "person", "properties": {"name": "child2"}}::vertex
(1 row)

Query
SELECT *
FROM cypher('test_graph', $$
    MATCH (p)-[r:connect]->(c)
    RETURN p.name, collect(c.name)
$$) as (p agtype, c agtype);
    p     |          c
----------+----------------------
 "parent" | ["child2", "child1"]
(1 row)

those returns perfectly
SELECT *
FROM cypher('text_test', $$
          MATCH (V)-[R:connect]->(V2)
          RETURN V, R, V2
$$) as (V agtype, R agtype, V2 agtype);

v | r | v2
-- | -- | --
{"id":844424930131969,"label":"node","properties":{"tag":"html","attrib":"{\"lang\": \"en\"}"}} | {"id":1125899906842628,"label":"connect","end_id":844424930131973,"start_id":844424930131969,"properties":{"name":null}} | {"id":844424930131973,"label":"node","properties":{"tag":"body","attrib":"null"}}
{"id":844424930131969,"label":"node","properties":{"tag":"html","attrib":"{\"lang\": \"en\"}"}} | {"id":1125899906842625,"label":"connect","end_id":844424930131970,"start_id":844424930131969,"properties":{"name":null}} | {"id":844424930131970,"label":"node","properties":{"tag":"head","attrib":"null"}}
{"id":844424930131970,"label":"node","properties":{"tag":"head","attrib":"null"}} | {"id":1125899906842627,"label":"connect","end_id":844424930131972,"start_id":844424930131970,"properties":{"name":null}} | {"id":844424930131972,"label":"node","properties":{"tag":"title","attrib":"null"}}

I just discovered the correct query later on, what I needed to do is not to filter any field out, the rest could be done from python
          SELECT * from cypher('text_test', $$
          MATCH (V:node)-[connect]->(V2:node)
			WITH V as parent, COLLECT(V2) as children
          RETURN parent, children
$$) as (parent agtype, children agtype);

{"id":844424930131987,"label":"node","properties":{"tag":"div","attrib":"{"id": "second", "class": "below"}"}}
[{"id":844424930131988,"label":"node","properties":{"tag":"div","attrib":"{"class": "inner"}"}}]

{"id":844424930131973,"label":"node","properties":{"tag":"body","attrib":"null"}} | [{"id":844424930131987,"label":"node","properties":{"tag":"div","attrib":"{\"id\": \"second\", \"class\": \"below\"}"}},

{"id":844424930131978,"label":"node","properties":{"tag":"div","attrib":"{\"id\": \"idone\", \"class\": \"classone\"}"}},{"id":844424930131974,"label":"node","properties":{"tag":"ul","attrib":"{\"class\": \"menu\"}"}}]

{"id":844424930131970,"label":"node","properties":{"tag":"head","attrib":"null"}} | [{"id":844424930131972,"label":"node","properties":{"tag":"title","attrib":"null"}},
{"id":844424930131971,"label":"node","properties":{"tag":"meta","attrib":"{\"charset\": \"UTF-8\"}"}}]
{"id":844424930131985,"label":"node","properties":{"tag":"div","attrib":"{\"id\": \"innertwo\"}"}} | [{"id":844424930131986,"label":"node","properties":{"tag":"h2","attrib":"null"}}]

@afidegnum
You shouldn't need to rely on Python to filter your results. What you're doing should work.
Would be good to see all your code.
Please test the following. If it works, then please submit all your code that doesn't work.
-- drop graph for cleanup between tests
SELECT * FROM ag_catalog.drop_graph('test_graph', true);

-- start from a new graph
-- create parent connected to 2 children with multiple properties
SELECT * FROM create_graph('test_graph');
SELECT * FROM cypher('test_graph', $$
    CREATE (p:person {name: 'parent'})
    CREATE (c1:person {name: 'child1', age: 11 })
    CREATE (c2:person {name: 'child2', age: 12 })
    CREATE (p)-[:connect]->(c1)
    CREATE (p)-[:connect]->(c2)
    RETURN p
$$) as (p agtype);

-- collect a property of children
SELECT * from cypher('test_graph', $$
          MATCH (p)-[connect]->(c)
          RETURN p.name,collect(c.name)
$$) as (p agtype, c agtype);

Last query should return
p     |          c
----------+----------------------
"parent" | ["child2", "child1"]
(1 row)

That's the result so far.
I noticed some of the results are also not formatted in apache-age-python I draw the attention to the maintainer. I'm still waiting for his reply.

@afidegnum
Works and formats correctly for me.
Please send me your code that built the graph and you query that failed.

@afidegnum You shouldn't need to rely on Python to filter your results. What you're doing should work. Would be good to see all your code. Please test the following. If it works, then please submit all your code that doesn't work.
-- drop graph for cleanup between tests
SELECT * FROM ag_catalog.drop_graph('test_graph', true);

-- start from a new graph
-- create parent connected to 2 children with multiple properties
SELECT * FROM create_graph('test_graph');
SELECT * FROM cypher('test_graph', $$
    CREATE (p:person {name: 'parent'})
    CREATE (c1:person {name: 'child1', age: 11 })
    CREATE (c2:person {name: 'child2', age: 12 })
    CREATE (p)-[:connect]->(c1)
    CREATE (p)-[:connect]->(c2)
    RETURN p
$$) as (p agtype);

-- collect a property of children
SELECT * from cypher('test_graph', $$
          MATCH (p)-[connect]->(c)
          RETURN p.name,collect(c.name)
$$) as (p agtype, c agtype);

Last query should return p | c ----------+---------------------- "parent" | ["child2", "child1"] (1 row)

I just repeated this code. the issue I'm facing is: collecting the fields returns an empty result rather than the node themselves.
So, collect(c) works but collect(c.name) don't. I believe it should be a version issue.
I'm using the docker version of AGviewer and AG extension on Postgres 11

the code I used to build the graph is in python, can I post it ?

yes please, together with version numbers of everything and the docker hub link to the docker images you are running
select version();
select * from pg_extension;

@afidegnum
You are correct - there is something not right about the latest image bitnine/agviewer:latest
docker run --publish=3001:3001 --name=agviewer bitnine/agviewer:latest
SELECT * from cypher('test_graph', $$
          MATCH (n)
          RETURN n.name
$$) as (n agtype);

does not print the value of property 'name'.
whereas
SELECT * from cypher('test_graph', $$
          MATCH (n)
          RETURN collect(n.name)
$$) as (n agtype);

n
["parent","child1","child2"]

works fine.

you can have a look at my repo

I resolved issue on AGViewer. anything else left?

Not for now. still working on the other issue


Deal with Reader PDF search on the Yoga Tab 3

This device does not accept 'Enter' or 'Search' Key Events to initiate the search so reluctantly having to use coordinates in this special case.

To be very clear no-one likes this change at all but it is required.  Devices specific cludges should not be allowed.


Unable to run my iOS App on Windows 10 using "vsimporter.exe"

I have a commercial iOS app that I would like to carry under windows 10 using "vsimporter.exe". To do this, I follow step by step the manual of Windows bridge for iOS :

I run an online command window and place myself under the directory "name App.xcodeproj" (there is a space character between "name" and "App"... is it an identified issue ?)
then, I drag "vsimporter.exe" from "...\WinObjC\bin" to this command window and press enter

Just two seconds later, I have this messages :
Generated C:\Objective-C\App\name App.vsimporter\name App-WinStore10\name Appr.vcxproj
Generated C:\Objective-C\App\name App.xcodeproj\project-WinStore10.sln
All seems to be fine so I open "project-WinStore10.sln" in Microsoft Visual Studio Community 2015 (14.0.25431.01 update 3). I then get an error message that asks me to observe the output to have information about those that did not work (Loading failure).
The output give me :
Opening of repositories:                      ("Ouverture des référentiels :" in french)
C:\Objective-C\App
Invalid data in index - invalid entry
Invalid data in index - invalid entry
Invalid data in index - invalid entry
Invalid data in index - invalid entry
The project could not be loaded because there is a file which have name with Windows forbidden characters. So, I choose to modify this name and his reference in the file "C:\Objective-C\App\name App.vsimporter\name App-WinStore10name App\name App.vcxproj".
After that, I could load the project in VS. Then, I try to debug (Win32 and local computer). I obtain 2 build errors :

expected ':' in "SlideNavigationController.h" line 58
'sqlite3.h' file not found in "FMDatabase.h" line 2

If I try to correct the first one by adding ':' where it asks, it creates more problem than it solves...
I have no idea for the second error.
Can someone help me ? I am reluctant to do a complete repository on GitHub because it is a commercial application on App Store...

as for 'sqlite3.h' there is solution #309

for "expected ':' in "SlideNavigationController.h" line 58"
I guess sources is needed.

@ad1Dima, thanks for pointing to the solution for the "sqlite3.h" issue.
@MikaelLeGrand, would you be able to share the code from the "SlideNavigationController.h" file? or at least the portion of it where the error is?

@ArnOmsft , no problem for sharing the code you want to see :
#import <UIKit/UIKit.h>
#import <QuartzCore/QuartzCore.h>
@protocol SlideNavigationControllerDelegate
@optional

(BOOL)slideNavigationControllerShouldDisplayRightMenu;
(BOOL)slideNavigationControllerShouldDisplayLeftMenu;
@end

typedef  enum{
MenuLeft,
MenuRight,
}Menu;
@protocol SlideNavigationContorllerAnimator;
@interface SlideNavigationController : UINavigationController
@property (nonatomic, assign) BOOL avoidSwitchingToSameClassViewController;
@property (nonatomic, assign) BOOL enableSwipeGesture;
@property (nonatomic, assign) BOOL enableShadow;
@property (nonatomic, strong) UIViewController *rightMenu;
@property (nonatomic, strong) UIViewController *leftMenu;
@property (nonatomic, strong) UIBarButtonItem *leftBarButtonItem;
@property (nonatomic, strong) UIBarButtonItem *rightBarButtonItem;
@property (nonatomic, assign) CGFloat portraitSlideOffset;
@property (nonatomic, assign) CGFloat landscapeSlideOffset;
@property (nonatomic, assign) CGFloat panGestureSideOffset;
@property (nonatomic, strong) id  menuRevealAnimator;

(SlideNavigationController *)sharedInstance;

(void)switchToViewController:(UIViewController *)viewController withCompletion:(void (^)())completion __deprecated;
(void)popToRootAndSwitchToViewController:(UIViewController *)viewController withSlideOutAnimation:(BOOL)slideOutAnimation andCompletion:(void (^)())completion;
(void)popToRootAndSwitchToViewController:(UIViewController *)viewController withCompletion:(void (^)())completion;
(void)popAllAndSwitchToViewController:(UIViewController *)viewController withSlideOutAnimation:(BOOL)slideOutAnimation andCompletion:(void (^)())completion;
(void)popAllAndSwitchToViewController:(UIViewController *)viewController withCompletion:(void (^)())completion;
(void)bounceMenu:(Menu)menu withCompletion:(void (^)())completion;
(void)openMenu:(Menu)menu withCompletion:(void (^)())completion;
(void)closeMenuWithCompletion:(void (^)())completion;
(void)toggleLeftMenu;
(void)toggleRightMenu;
(BOOL)isMenuOpen;

@end
I hope this could help...

Which line of source is causing the compile error? There are not 58 lines of code in your past above.

@weswmsft Sorry to have forget lines numbers... I hope this screenshot could help this time ;o)


store: set e.Node.Dir attribute, when node expired

Sets e.Node.Dir attribute in DeleteExpiredKeys
When a directory node expired, the prevNode has a "dir":true attribute in the received expire event, but the node has no "dir":true attribute
Fixes #7033

@xiang90 resubmit pull request

lgtm


Switch from plc to estop_latch based estop handling for now.

Note that this is untested.

This is now a tested edition.  I can take LinuxCNC out of ESTOP by running 'halcmt sets power-on 1' on the command line, and then press the ESTOP button in the GUI.  But nothing happen when I try to bring LinuxCNC into ESTOP again by pressing the button again.  Should it?

bab444f2de5ad4b8c71a5fcde8ae2840f21c114e is the current estop setup used.  It do not allow me to enter estop from the GUI, but is able to bring the machine out of estop from the gui.


As IDEM, I want to lock my email once verified, so that the app cant be gamed.

Context
Once a user has verifed their email via the PGP public key server, the app should not allow the user to modify the email.  If they want to change it, the can simply delete the app.
Requires #11
AC

Given a user,
When when their email is veified,
Then they're not able to modify the email claim

Testing Notes
Create temp email - https://www.emailondeck.com/eod.php
Create PGP - https://www.attogtech.com/pgp-key-generator/

in the app add your email claim and paste your public block into the PGP paste block
Click publish public key
go to your email and click the verification link
go back to the app and click verify email which should say "success"
go back to claims list and into email, and the button should be disabled :)

Followed testing steps and button is disabled
Currently unable to test if it works when the PGP is automatically generated (dependent on #9 to be working)
Unable to test if it works when I have my own private key because of #340

Testing blocked because currently unable to publish PGP key https://github.com/dltxio/idem-mobile/issues/9#issuecomment-1211691118

Can't verify email https://github.com/dltxio/idem-mobile/issues/9#issuecomment-1219061374


Delete stuff with ShovelUtils

I can't get vm.deleteCostume(NAME) and vm.deleteSound(NAME) to delete a specific thing. They always delete the first thing in the list.

I messed up the branch


refactor: move o.t.benchmarks back in to main source set

Moves engine/src/dev in to engine/src/main.
Removes the special dev SourceSet from engine's build configuration.
mentioned in #4015, #3979
How to test
Not sure. Anyone remember why this was split out to a separate source set to begin with? I don't see any additional test failures from moving it back.

Oh, the dev source set has been around for a while: https://github.com/MovingBlocks/Terasology/commit/8e1a024bd49a081d2ec73dea37b8061efcd3b7b2

the "it's not part of engine" argument would carry more weight if it didn't get put in the jar along with all the engine classes and included in the same reflections cache.
The gradle manual has some opinions about when to create a custom source set, but concludes

If you’re unsure whether to create a custom source set or not, then go ahead and do so. It should be straightforward and if it’s not, then it’s probably not the right tool for the job.

My motivation for wanting to do away with it before some of the other work on the build configuration comes mostly from the fact that it does end up with its outputs combined with the main source set. Reflections cache is based on classes output, so it seems like we should build one reflections.cache per source set, but then if you end up with two source sets each with their own reflections.cache file and you go to pack them in to the same jar, that sounds like resource collision.
and we can't name them anything other than reflections.cache if they're intended for use with gestalt because that's the only name by which it looks for them.

which suggests another option: leave the sources where they are, in their separate src/dev and separate source set, but keep the part of this patch that source set from the reflections cache and jar.
or another other option: keep the files where they are, remove the source set, but add src/dev as a second source directory of the main source set.

or another other option: keep the files where they are, remove the source set, but add src/dev as a second source directory of the main source set.

That might have been what I was fishing for in my mind the other day. Wanting to only really have one test sourceSet, but different directories inside to distinguish between the types of tests, rather than just different packages.
Having them end up in the same jar anyway - blah. Whole new engine-benchmarks project within the repo? Gestalt does or did that at one point.
In any case: I don't think it is necessarily worth worrying about right now. So long as we have it documented for the future, like with #3979, on what it is, why it is unsual, and what we might do with it in the future 👍

oh, hah, did you know if you force-push before committing so you've just pushed what's already merged, it counts that as a nothing-to-commit PR and calls it closed?

Okay, new pass with a less disruptive approach:

keeps directory layout as-is
keeps java package namespace as-is
keeps the dev/* stuff in the engine.jar
removes the dev SourceSet; gradle considers all this to be in the main SourceSet

and I did make sure that IDEA still recognizes that these are sources.
I know this still isn't quite ideal for what your goals about how to use those benchmarks, but I hope it's not so much of a step away from it as merging the directory trees was.


allow admins to make past reservations

Guys, hurry up please. I need this merged badly to release the full admin schedule calendar functionality and we have end of sprint today 😨


"godep save" fails to vendor a dependency under some circumstances

I'm using Godep for an internal project successfully vendoring >100 dependencies. But for reasons I can't discern it always misses a certain dependency and I have to vendor it manually.
I've created a repository that reproduces the issue: https://github.com/russellhaering/godep-timetools-bug
In short, if I import github.com/vulcand/vulcand/service I see github.com/mailgun/timetools successfully pulled in, but its import of gopkg.in/mgo.v2/bson is not rewritten and gopkg.in/mgo.v2/bson is not vendored.
Again, this seems to be an unusual but painful edge case. I'm not sure what makes it unique.

Interestingly enough, I have the same exact problem -- with the same exact dependency (gopkg.in/mgo.v2/bson).  It's in the Godeps.json file, but doesn't get copied over to the vendor directory.

@cmoesel Can you share your Godeps.json file and any code? Also, what does 'find . -type d -name "bson"` return ?

I can't duplicate this, so I need more info.
$ cat main.go
package main

import (
	"fmt"

	"gopkg.in/mgo.v2/bson"
)

func main() {
	fmt.Println(bson.Binary{})
}
$ godep save
$ cat Godeps/Godeps.json
{
	"ImportPath": "github.com/freeformz/t408",
	"GoVersion": "go1.6",
	"GodepVersion": "v70",
	"Deps": [
		{
			"ImportPath": "gopkg.in/mgo.v2/bson",
			"Comment": "r2016.02.04-1-gb6e2fa3",
			"Rev": "b6e2fa371e64216a45e61072a96d4e3859f169da"
		}
	]
}
$ find .
.
./Godeps
./Godeps/Godeps.json
./Godeps/Readme
./main.go
./vendor
./vendor/gopkg.in
./vendor/gopkg.in/mgo.v2
./vendor/gopkg.in/mgo.v2/bson
./vendor/gopkg.in/mgo.v2/bson/bson.go
./vendor/gopkg.in/mgo.v2/bson/decode.go
./vendor/gopkg.in/mgo.v2/bson/encode.go
./vendor/gopkg.in/mgo.v2/bson/LICENSE
./vendor/gopkg.in/mgo.v2/LICENSE

Also @russellhaering when I checkout your example repo and I run godep save on it Godeps/_workspace/src/gopkg.in/ get's added.
Maybe it was solved in the meantime?
@cmoesel What version of godep are you using?

Yes, its not clear to me what fixed it, but this issue no longer seems to affect me. Thanks for looking into it.


Simplify kern feature generation a bit

Adding subtables to feature syntax is unnecessary because feaLib will do this itself.
Checking for conflicts in class-to-class rules is unnecessary because conflicts from other rules are considered exceptions and are allowed. In fact, we can probably do without checking for conflicts anywhere (if we're checking already in glyphs2ufo) except that we enumerate class-to-glyph rules, so glyph-to-glyph rules aren't considered exceptions of them. It would be best to do without this enumeration but that seems to cause problems with compilation (this is something to look into).

Adding subtables to feature syntax is unnecessary because feaLib will do this itself.

It doesn't do that for kerning right now, I'm working on implementing that.

And, at any rate, we should fix it there.

So, should I still review this?

Yes, please review and commit.  It should work for most fonts.  When a table overflow happens, we need to split kerning table.  That part doesn't exist yet, but I'm putting that in this week.


refactor: hyperlink  extract common logic [TOL-1637]

Wondering if we can also have a base component? So we only need to provide the handleEditLink, handleRemoveLink and the toooltipContent and the children to it? 🤔

I tried something like that, but we are calling different hooks in all those components, the types are also different and there are other quirks (different data attributes, different forma  components (link vs text), etc) It wasn't very readable in the end so I left it the way it is now


Create the simplest delete dialog action

[x] New base dialog + CSS for this styles (per #1602)
[x] Open dialog from filters-menu
[x] Should be able to open dialog when selecting multiple items
[x] CSS animations on show/hide
[x] CSS animations on badge icon
[x] Be able to delete selected items
[x] It should work with maps or datasets.
[x] Same action for several items (only front requests), as per discussion outcome in #1441
[x] export dialog do not exist yet, so needs to be implemented later, for now display a cancel button and "export your datasets" as normal text.
[x] error case, when deletion fails

Yes, those warning-cases are designed but will not be implemented in the scope of this issue (see the previous comments on this thread for a reference).
I was not talking about can-or-cannot-delete (permission) errors, but technical ones (server-side errors, e.g. deletion failed due to some error on the server that we cannot check/control from the client-side), but if you don't consider those cases to be a concern I leave this as it is.
Btw, I noticed another behaviour we might want to re-iterate on: since the new functionality allows to delete multiple items simultaneously there can be a significant delay until all selected items are deleted, e.g. ~10 sec to delete 20 items in my local dev env. During that period there is no indication that there are things being deleted.

Cool, I'll create a loading state :)

Done, we can keep this as a generic loader for operations that will happen until clicking a button. When done, the modal window should be close.

@saleiva @xavijam it's really necessary for doing batch operations that take some significant amount of time. based on yesterday's offline discussion and considering we've disabled batch operations for the time being, I'd propose to create an issue in the backlog and leave it for later. sounds reasonable to you?

This will be needed on other modals like it is in the actual dashboard, like deleting (sometimes) or retrieving your tables list. Up to you guys


Observatory and checked mode

We can run the service tests in checked mode (and some bots do).
There's an issue with uninitialized fields though:
Edit runtime/observatory/tests/service/service.status to not allow field_script_test to fail and run
python tools/test.py -mrelease --checked -t60 service/field_script_test

I get
[...]
** Killing script
Unexpected exception in service tests: type 'Sentinel' is not a subtype of type 'Instance' of 'value' where
  Sentinel is from package:observatory/service.dart
  Instance is from package:observatory/service.dart
[...]

It seems that observatory injected into the vm does never run in checked mode though.
If I apply the following patch
diff --git a/runtime/observatory/lib/src/service/object.dart b/runtime/observatory/lib/src/service/object.dart
index 954f24e6a5..731bf025e1 100644
--- a/runtime/observatory/lib/src/service/object.dart
+++ b/runtime/observatory/lib/src/service/object.dart
@@ -3202,6 +3202,9 @@ class Field extends HeapObject implements M.Field {
     if (mapIsRef) {
       return;
     }
+    if (map['staticValue'] is! Instance) {
+      print("Field staticValue for $name is not an instance! Should now fail in checked mode.");
+    }
     staticValue = map['staticValue'];

     guardNullable = map['_guardNullable'];

I get "Field staticValue for tests is not an instance! Should now fail in checked mode." (also printed to the terminal when loading the observatory in the vm, btw.)
Looking at field 'tests' via observatory in the browser it says "static value: ", so it seems that this is somewhat the expected outcome. That doesn't change that whenever a field isn't initialized a non-Instance is assigned to a variable that typed to be an Instance though.

Stale.


Optional parameters to control length of returned dataset.

@mattdeitke - Updated this to not use config and instead use key word arguments. Also added an option to specify the data dir (in case someone wants to use the load_dataset function with a custom dataset.

Also added an option to specify the data dir (in case someone wants to use the load_dataset function with a custom dataset.

I don't think we should put this option in the ProcTHOR-10K package. This should be a new PRIOR dataset titled something like CustomDataset.


Terminal: Output rendered as black/shadowed font color

VSCode Version: Code - Insiders 1.18.0-insider (af6ca44db81f5186d3104226c8e76e026789ce20, 2017-10-06T05:26:16.770Z)
VSC Stable 1.17.0

Believed to start approximately 1.5wks ago in insiders.

OS Version: Windows_NT x64 6.1.7601
Extensions:

Extension
Author (truncated)
Version

vscode-javascript-snippet-pack
aka
0.1.5

Bookmarks
ale
0.16.0

project-manager
ale
0.21.1

git-easy
bib
1.9.1

gitignore
cod
0.5.0

bracket-pair-colorizer
Coe
0.10.9

vscode-eslint
dba
1.3.2

git-extension-pack
don
0.1.3

githistory
don
0.2.3

gitlens
eam
5.4.1

tslint
eg2
1.0.9

git-project-manager
fel
1.4.0

file-icons
fil
1.0.5

vscode-npm
fkn
3.3.0

code-runner
for
0.7.2

macros
ged
1.2.0

hello
hyp
0.1.1

csharpextensions
jch
1.3.0

csharpfixformat
Leo
0.0.36

start-git-bash
McC
1.2.1

csharp
ms-
1.12.1

debugger-for-chrome
msj
3.3.1

git-add-remote
sam
0.0.2

code-settings-sync
Sha
2.8.3

gitblame
wad
2.2.0

JavaScriptSnippets
xab
1.5.0

vscode-open-in-github
ziy
1.2.8

(1 theme extensions excluded)

Steps to Reproduce:

Start Code

Start a single terminal

Exit Code

Restart Code

90% of time the terminal output will render as black (slightly visible, not blank)

Opening new terminals does not clear the issue

If you killed the terminal and then restart the problem will frequently go away
Update Note

Change of color theme sometimes fixes the issue

Reproduces without extensions: Yes

Zoom to see characters in terminal

Weird I haven't seen this at all. You indicate the issue is not particularly consistent, but are you able to get reasonably consistent repro steps?
Do you have custom colors set in your cmd.exe properties?

@Tyriar
it is weird.
It is actually close to a hundred percent reproducible if I close Code with at least one active terminal.
Upon restart font is black.  I can restart code over and over and this will persist. Once I restart code
with no terminal things get back to normal.  I thought it might be something to do with themes since I'm working on select box improvements and changing themes a lot.  I have no terminal color set.
One new observation I don't think it ever happens with light themes.  So it may indeed be related to themes.  It is almost as if the terminal erroneously gets into a light theme independent of the rest of the UI.
if you can think of any experiments I'll happily do them.

@Tyriar
I have not seen this since the last couple of insiders releases.
I think we can go and close.

@cleidigh great, thanks for the update 😃


FiLM pipeline doesn't work with "custom" metadata.

Current behavior
The FiLM metadata option can be set to contrasts, mri_params or to a "custom" name corresponding to a column of the participants.tsv file.
The "custom" option is not working and gives the following error while loading the data:

 Error message
Traceback (most recent call last):
  File "/home/mhbourget/venv-ivadomed-38c/bin/ivadomed", line 11, in <module>
    load_entry_point('ivadomed', 'console_scripts', 'ivadomed')()
  File "/home/mhbourget/code/ivadomed/ivadomed/main.py", line 567, in run_main
    run_command(context=context,
  File "/home/mhbourget/code/ivadomed/ivadomed/main.py", line 387, in run_command
    ds_valid = get_dataset(bids_df, loader_params, valid_lst, transform_valid_params, cuda_available, device,
  File "/home/mhbourget/code/ivadomed/ivadomed/main.py", line 118, in get_dataset
    ds = imed_loader.load_dataset(bids_df, **{**loader_params, **{'data_list': data_lst,
  File "/home/mhbourget/code/ivadomed/ivadomed/loader/loader.py", line 91, in load_dataset
    dataset = BidsDataset(bids_df=bids_df,
  File "/home/mhbourget/code/ivadomed/ivadomed/loader/bids_dataset.py", line 103, in __init__
    df_sub, roi_filename, target_filename, metadata = self.create_filename_pair(multichannel_subjects, subject,
  File "/home/mhbourget/code/ivadomed/ivadomed/loader/bids_dataset.py", line 208, in create_filename_pair
    self.create_metadata_dict(metadata_choice, df_sub, bids_df)
  File "/home/mhbourget/code/ivadomed/ivadomed/loader/bids_dataset.py", line 150, in create_metadata_dict
    metadata[metadata_choice] = df_sub[metadata_choice].values[0]
NameError: name 'metadata' is not defined

This is because the variable metadata is not defined in (or passed to) the create_metadata_dict function of bids_dataset.py.
The error seems to come from a refactoring we did in #765.
I tested with this config file: config_film.zip. In that case the custom metadata is "metadata": "sex". Before the refactoring PR (commit ccd82d22) the images are loaded and the training start normally. After the PR (commit ebddbfb and after), the loader returns the error above.
Notes

the config_film.json file I used to test contains the "NumpyToTensor": {} transform otherwise it would not work with older commits.
At the time of the problematic refactoring, the create_metadata_dict was in loader.py (and not bids_dataset.py).
the FiLM pipeline also have known issues with the contrasts option under certain circumstances since the integration of the new loader. Details in issue #710, but it should not affect the "custom" metadata option.

Good catch. IDE actually caught this error but during the extraction out of the load.py, I think specific function was not reviewed in detail. First thought is let's try to add meta-data past to it and see. We will get a PR going and test it out a bit more.

@mariehbourget I have added metadata t the function, how did you test for this?

@mariehbourget I have added metadata to the function, how did you test for this?

I tested with the config file from my initial comment above.

@mariehbourget I have added metadata to the function, how did you test for this?

I tested with the config file from my initial comment above.

what command do you run?

@cakester you will need data_example_spinegeneric data from https://ivadomed.org/en/latest/tutorials/one_class_segmentation_2d_unet.html


Adding tiles and board generators

Pull Request Test Coverage Report for Build 17

178 of 199 (89.45%)  changed or added relevant lines in 12 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-6.4%) to 89.447%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

repository/IngSoft2-Model/Game.class.st
65
68
95.59%

repository/IngSoft2-Model/GamePlaying.class.st
6
9
66.67%

repository/IngSoft2-Model/Tile.class.st
0
6
0.0%

repository/IngSoft2-Model/DeterministicBoardGenerator.class.st
0
9
0.0%

Totals

Change from base Build 14:
-6.4%

Covered Lines:
178

Relevant Lines:
199

💛  - Coveralls


reaction item only contains IDs

The reaction_added and reaction_removed events do not include the embedded items the same as when retrieving the reaction list.

Let me take a closer look at this soon™

Thank you!


Candlestick series not respecting priceFormat options

Lightweight Charts Version: 3.3.0
Steps/code to reproduce:
      priceFormat: {
      type: 'custom',
      minMove: 0.000001,
      formatter: (price: any) => {
        if (price < 0.000001) return parseFloat(price).toFixed(8)
        else if (price >= 0.000001 && price < 1) return parseFloat(price).toFixed(6)
        else return parseFloat(price).toFixed(4)
      }
    }

Actual behavior: Shows price to 2 decimal places and a min move of 0.01 (default).

Expected behavior: Expecting it to show price to 4 decimal places.

Screenshots:

Can you create jsfiddle snippet to reproduce the issue please? Because I cannot reproduce it here https://jsfiddle.net/jo8gk572/

I'm closing this cos it was actually an issue with kaktana-react-lightweight-charts


Remove clipBehavior == Clip.none conditions

fixes https://github.com/flutter/flutter/issues/98487
Pre-launch Checklist

[x] I read the Contributor Guide and followed the process outlined there for submitting PRs.
[x] I read the Tree Hygiene wiki page, which explains my responsibilities.
[x] I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
[x] I signed the CLA.
[x] I listed at least one issue that this PR fixes in the description above.
[ ] I updated/added relevant documentation (doc comments with ///).
[x] I added new tests to check the change I am making, or this PR is test-exempt.
[x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

/cc @Piinks


handles 204 codes, automated testing/security auditing and bumped versions

Coverage decreased (-11.1%) to 73.333% when pulling f2cb8f7427471bada723dacee3d5c38ae5e1904e on manoadamro:master into 05cb311e8be373694dc347f8297475746921800c on libwilliam:master.


Remove twin.macro, use pure tailwindcss3

Plz run the app to see that nothing was broken

@B2o5T my impression so far:
Create Project does not work
This button on the main org page:

is no longer functional; I'm not able to click on it at all.
Modals position

seems a bit off, no longer centered
CDN Connect button is not working

can't click at all

I tested all other screens and it looks the same as before ✅


teletype studies 5: mismatched image & description

(section: "dolphin and seagull" example)
according to tts5.md, line 218, script two is supposed to "Ramp down CV 4". but that script in tts5.png uses CV D, so it will never get turned off. CV 4 level always remains high. either the text in tts5.md needs to be changed to CV D, or the image needs to be updated to CV 4.

The variable D defaults to have value=4. So the description is correct, if slightly less clear than it could be. Is it worth updating the description? If not, then this issue could be closed.


The result is better than faster-rcnn mxnet official version.

Thanks for your code. It gets good results for face. However, faster-rcnn mxnet version is worse than your code. Do you use some other tricks or methods other than official faster-rcnn? Thank you very much.

Hi, @hdjsjyl , actually, we did not use some specific tricks or methods compared with official one. How much is the gap?

@jwyang , For wider face dataset, easy part 0.885-0.901, medium part 0.797-0.845, hard part 0.421-0.552. I think the gap is big for medium and hard parts.

@hdjsjyl , I see, I think it might because the difference on data loader. In our implementation, we did not resize images, but kept the aspect ratio of input images, as much as possible.

@jwyang , ok, I will check the code. thank you very much

@hdjsjyl maybe another reason is the evaluation parameters are different. Also check that.

@jwyang , thanks for your advice. I have checked it and am trying to implement it on my code. Happy chinese new year!

@hdjsjyl , thanks! I guess you are also a Chinese, right? Happy Chinese new year!

@jwyang yes, I am a chinese.

Great, enyjoy the holiday!

You too


Repopulating data with Resource $http call

Good afternoon!
I found a bug, may be it is my own =)
I created a form with large amount of controls including ui-select with multichoice. When data first load from the server - everything is ok. But then I save resource and receive data from server back (the same as first time), multiselect brakes.
Multiselect field also populates via $http resource.
I record a video, you can watch the disciplinesBefore field: http://www.youtube.com/watch?v=NIShaV7oUTM&feature=youtu.be

take a look at that: #349

Can you create a Plunker with this reproduced?


Enhanced Aspect and Foci Icons

I noticed the strange quality of the foci and aspect icons when compared to Thaumcraft and other mods of similar quality like Thaumic Augmentation so I fixed them up by resizing them from the website they were taken from. (Game-icons.net)
Tinctura was more interesting because it was two icons put together. I wasn't sure if it turned out as well but I also made an alternate version with just the paintbrush if that's more preferable. Hope it helps! ^^
icons.zip

wow yeah i tried to emulate the thaum style but failed spectacularly, thank you for your contribution, will push with the next update


Error - Output name too long

Hi guys,
On windows system which doesn't support long path, an error is raised:
with open(out_p, "wb") as f:     OSError: [Errno 22] Invalid argument: 'X-a43072aa-5c60-4d71-a91d-e89bd0d549e1:0:0-0774785a-830f-4f79-b4a3-e84054e8e194-0.png'\r\n"
The filename is defined here,
 artifact_p = f"{prefix}-{resp.request_id}-{resp.answer_id}-{idx}"
where ids are uuid (36 chars).
In addition, for multiple request, there is no way to map request results with initial prompts.
It would be shorter and more useful to use a format like
f"{prefix}-{request_idx}-{response_idx}",
where request_idx = prompt position:
python3 client.py -W 512 -H 512 -n 2 "A stunning house." "A creepy house."
-> generation-0-0.png, fisrt stunning house
-> generation-0-1.png, second stunning  house
-> generation-1-0.png, fisrt creepy house
-> generation-1-1.png, second creepy house

PR #10

It seems multiple prompts command doesn't work as I've imagined (bug?), so the filename could be simplify by using only idx


[5.8] Add --dry-run option to commands

This adds a --dry-run option to the default command structure. The idea of this is that if you pass --dry-run when calling your command, then you can use it for performing logic checks within the command to conditionally execute certain pieces of code.
Example:
// app/Console/Commands/UpdateUserStatus.php
public function handle()
{
    $users = User::where('status', $this->option('status'))->get();

    if ($this->option('dry-run')) {
        $this->error('Performing Dry Run. Would affect the following users...');
        // Show some output to preview the users affected

        return;
    }

    $users->each(function($user) {
        // some type of update on the user
    });

    $this->info('Done!');
}

Affect on existing codebases
If you have added --dry-run in the signature of an existing command, then this will just work as long as it has been declared as an option without a value.
If the option is set to receive a value (i.e. --dry-run=, then an error message of An option named "dry-run" already exists. will be displayed.
If this feels too risky for existing codebases, I can change this to PR against master.

This should be handled at your application level depending on if your commands support dry run, it feels a bit bizarre to have this option globally available to all commands by default imo.

I agree, this should be handled on a single command basis. On migrations this would be very useful, on 'artisan list' is not.
Although, this could provide a lot of messy code with ifs and elses everywhere, or you have to duplicate the whole algorithm. Can you provide an actual example of how you would apply this?

Thanks for your pull request to Laravel!
Unfortunately, I'm going to delay merging this code for now. To preserve our ability to adequately maintain the framework, we need to be very careful regarding the amount of code we include.
If possible, please consider releasing your code as a package so that the community can still take advantage of your contributions!
If you feel absolutely certain that this code corrects a bug in the framework, please "@" mention me in a follow-up comment with further explanation so that GitHub will send me a notification of your response.


tests: add impersonation to integration test

What this PR does / why we need it:

Use RBACs permissions in integration test for faster feedback related permission problems.
We've run the integration tests with cluster-admin permissions.

Which issue this PR fixes:

fixes #2617
Special notes for your reviewer:

PR Readiness Checklist:
Complete these before marking the PR as ready to review:

[ ] the CHANGELOG.md release notes have been updated to reflect any significant (and particularly user-facing) changes introduced by this PR

updated:
I think that clusters.KustomizeDeployForCluster is appropriate function for this.
And i think that we need to replace crds.go with this function for consistency.

@czeslavo
I ran the integration test in my local and got the following error.
=== RUN   TestTCPRouteExample
    examples_test.go:154: locking TCP port
    examples_test.go:165: performing test setup
    examples_test.go:165: creating a testing namespace
    examples_test.go:165: created namespace 85663534-d0df-4aac-b858-2fb2deee74be for test case TestTCPRouteExample
    examples_test.go:167: applying yaml manifest ../../examples/gateway-tcproute.yaml
    examples_test.go:173: verifying that TCPRoute becomes routable
E0724 15:34:31.000976  113924 leaderelection.go:327] error retrieving resource lock kong-system/integrationtests.konghq.com: leases.coordination.k8s.io "integrationtests.konghq.com" is forbidden: User "system:serviceaccount:kong:kong-serviceaccount" cannot get resource "leases" in API group "coordination.k8s.io" in the namespace "kong-system"
E0724 15:34:34.132071  113924 leaderelection.go:327] error retrieving resource lock kong-system/integrationtests.konghq.com: leases.coordination.k8s.io "integrationtests.konghq.com" is forbidden: User "system:serviceaccount:kong:kong-serviceaccount" cannot get resource "leases" in API group "coordination.k8s.io" in the namespace "kong-system"
E0724 15:34:36.794202  113924 leaderelection.go:327] error retrieving resource lock kong-system/integrationtests.konghq.com: leases.coordination.k8s.io "integrationtests.konghq.com" is forbidden: User "system:serviceaccount:kong:kong-serviceaccount" cannot get resource "leases" in API group "coordination.k8s.io" in the namespace "kong-system"
E0724 15:34:41.098232  113924 leaderelection.go:327] error retrieving resource lock kong-system/integrationtests.konghq.com: leases.coordination.k8s.io "integrationtests.konghq.com" is forbidden: User "system:serviceaccount:kong:kong-serviceaccount" cannot get resource "leases" in API group "coordination.k8s.io" in the namespace "kong-system"
E0724 15:34:45.475963  113924 leaderelection.go:327] error retrieving resource lock kong-system/integrationtests.konghq.com: leases.coordination.k8s.io "integrationtests.konghq.com" is forbidden: User "system:serviceaccount:kong:kong-serviceaccount" cannot get resource "leases" in API group "coordination.k8s.io" in the namespace "kong-system"
...
E0724 15:34:49.731856  113924 leaderelection.go:327] error retrieving resource lock kong-system/integrationtests.konghq.com: leases.coordination.k8s.io "integrationtests.konghq.com" is forbidden: User "system:serviceaccount:kong:kong-serviceaccount" cannot get resource "leases" in API group "coordination.k8s.io" in the namespace "kong-system"
E0724 15:34:52.043117  113924 leaderelection.go:327] error retrieving resource lock kong-system/integrationtests.konghq.com: leases.coordination.k8s.io "integrationtests.konghq.com" is forbidden: User "system:serviceaccount:kong:kong-serviceaccount" cannot get resource "leases" in API group "coordination.k8s.io" in the namespace "kong-system"
E0724 15:34:55.789159  113924 leaderelection.go:327] error retrieving resource lock kong-system/integrationtests.konghq.com: leases.coordination.k8s.io "integrationtests.konghq.com" is forbidden: User "system:serviceaccount:kong:kong-serviceaccount" cannot get resource "leases" in API group "coordination.k8s.io" in the namespace "kong-system"
E0724 15:34:59.100314  113924 leaderelection.go:327] error retrieving resource lock kong-system/integrationtests.konghq.com: leases.coordination.k8s.io "integrationtests.konghq.com" is forbidden: User "system:serviceaccount:kong:kong-serviceaccount" cannot get resource "leases" in API group "coordination.k8s.io" in the namespace "kong-system"
E0724 15:35:02.851445  113924 leaderelection.go:327] error retrieving resource lock kong-system/integrationtests.konghq.com: leases.coordination.k8s.io "integrationtests.konghq.com" is forbidden: User "system:serviceaccount:kong:kong-serviceaccount" cannot get resource "leases" in API group "coordination.k8s.io" in the namespace "kong-system"
E0724 15:37:24.864153  113924 leaderelection.go:327] error retrieving resource lock kong-system/integrationtests.konghq.com: leases.coordination.k8s.io "integrationtests.konghq.com" is forbidden: User "system:serviceaccount:kong:kong-serviceaccount" cannot get resource "leases" in API group "coordination.k8s.io" in the namespace "kong-system"
E0724 15:37:27.050934  113924 leaderelection.go:327] error retrieving resource lock kong-system/integrationtests.konghq.com: leases.coordination.k8s.io "integrationtests.konghq.com" is forbidden: User "system:serviceaccount:kong:kong-serviceaccount" cannot get resource "leases" in API group "coordination.k8s.io" in the namespace "kong-system"
E0724 15:37:29.862488  113924 leaderelection.go:327] error retrieving resource lock kong-system/integrationtests.konghq.com: leases.coordination.k8s.io "integrationtests.konghq.com" is forbidden: User "system:serviceaccount:kong:kong-serviceaccount" cannot get resource "leases" in API group "coordination.k8s.io" in the namespace "kong-system"
    examples_test.go:174:
                Error Trace:    /home1/irteamsu/kubernetes-ingress-controller/test/integration/examples_test.go:174
                Error:          Condition never satisfied
                Test:           TestTCPRouteExample
E0724 15:37:32.685467  113924 leaderelection.go:327] error retrieving resource lock kong-system/integrationtests.konghq.com: leases.coordination.k8s.io "integrationtests.konghq.com" is forbidden: User "system:serviceaccount:kong:kong-serviceaccount" cannot get resource "leases" in API group "coordination.k8s.io" in the namespace "kong-system"
E0724 15:37:36.758391  113924 leaderelection.go:327] error retrieving resource lock kong-system/integrationtests.konghq.com: leases.coordination.k8s.io "integrationtests.konghq.com" is forbidden: User "system:serviceaccount:kong:kong-serviceaccount" cannot get resource "leases" in API group "coordination.k8s.io" in the namespace "kong-system"
E0724 15:37:39.961223  113924 leaderelection.go:327] error retrieving resource lock kong-system/integrationtests.konghq.com: leases.coordination.k8s.io "integrationtests.konghq.com" is forbidden: User "system:serviceaccount:kong:kong-serviceaccount" cannot get resource "leases" in API group "coordination.k8s.io" in the namespace "kong-system"
E0724 15:37:42.574488  113924 leaderelection.go:327] error retrieving resource lock kong-system/integrationtests.konghq.com: leases.coordination.k8s.io "integrationtests.konghq.com" is forbidden: User "system:serviceaccount:kong:kong-serviceaccount" cannot get resource "leases" in API group "coordination.k8s.io" in the namespace "kong-system"
E0724 15:37:45.847833  113924 leaderelection.go:327] error retrieving resource lock kong-system/integrationtests.konghq.com: leases.coordination.k8s.io "integrationtests.konghq.com" is forbidden: User "system:serviceaccount:kong:kong-serviceaccount" cannot get resource "leases" in API group "coordination.k8s.io" in the namespace "kong-system"
E0724 15:37:49.749020  113924 leaderelection.go:327] error retrieving resource lock kong-system/integrationtests.konghq.com: leases.coordination.k8s.io "integrationtests.konghq.com" is forbidden: User "system:serviceaccount:kong:kong-serviceaccount" cannot get resource "leases" in API group "coordination.k8s.io" in the namespace "kong-system"
E0724 15:37:53.604852  113924 leaderelection.go:327] error retrieving resource lock kong-system/integrationtests.konghq.com: leases.coordination.k8s.io "integrationtests.konghq.com" is forbidden: User "system:serviceaccount:kong:kong-serviceaccount" cannot get resource "leases" in API group "coordination.k8s.io" in the namespace "kong-system"
    setup.go:33: TestTCPRouteExample failed, dumped diagnostics to /tmp/ktf-diag-2978671423
E0724 15:37:56.699788  113924 leaderelection.go:327] error retrieving resource lock kong-system/integrationtests.konghq.com: leases.coordination.k8s.io "integrationtests.konghq.com" is forbidden: User "system:serviceaccount:kong:kong-serviceaccount" cannot get resource "leases" in API group "coordination.k8s.io" in the namespace "kong-system"
E0724 15:37:59.829061  113924 leaderelection.go:327] error retrieving resource lock kong-system/integrationtests.konghq.com: leases.coordination.k8s.io "integrationtests.konghq.com" is forbidden: User "system:serviceaccount:kong:kong-serviceaccount" cannot get resource "leases" in API group "coordination.k8s.io" in the namespace "kong-system"
    examples_test.go:157: unlocking TCP port
--- FAIL: TestTCPRouteExample (211.00s)

In my opinion, the service-account exists in the kong namespace and the lease resource exists in the kong-system namespace.
https://github.com/Kong/kubernetes-ingress-controller/blob/08c67a9ba99559c3bec9ebcac8a95eb0204887d1/config/rbac/leader_election_role.yaml#L2-L7
However, the corresponding RBAC is Role instead of ClusterRole. Is it a good idea to change this to ClusterRole?

It should remain a Role; that's what it should be in an actual install. We don't want access to ConfigMaps or Leases other than our own.
The default namespace of the manifests is kong, whereas the test namespace is kong-system. You should see the other namespace and role if you check for it. Are you able to copy that role/rolebinding into kong-system for the tests?

@rainest
Thanks for pointing out the difference between the default namespace and the namespace used in the test.
Updated: deploy to the test namespace (kong-system).
And i found that the failed test passed.
--- PASS: TestTCPRouteExample (14.09s)

@parkjeongryul There's one linter issue left, could you please fix it?

There's one linter issue left, could you please fix it?

Fixed. @czeslavo
Thank you for your review.

@parkjeongryul There's one more linting issue (wasn't detected before as checks run serially).

There's one more linting issue (wasn't detected before as checks run serially).

Fixed it. https://github.com/Kong/kubernetes-ingress-controller/pull/4376/commits/b6718d9732f0e50644439df158fb91f7c55fbe96

I believe you can get a KIC contributor T-shirt by filling this form. 🙂

Wow, thank you so much! I wasn't expecting this at all. 😃


Set Up Bank Vault Consumer Job

Overview
Once our Kubernetes Cluster is set up we can create jobs that run. This job will be used in our Hub App for DAO processing in the DAOs Table (specifically for the vault data).
This depends on having our own Ceramic Node deployed (#173 will need to be completed first) so it is blocked until our node is deployed.
This also will need a Ceramic schema for the fields (we can break this into a separate issue if we need).
These are the types  from dao-data:
export interface DaoTokenBalances {
  safeAddress: string;
  fiatTotal: number;
  tokenBalances: TokenBalance[];
}

export type TokenBalance = {
  token: TokenInfo | null;
  tokenAddress: string | null;
  balance: string;
  ethValue: string;
  timestamp: string;
  fiatBalance: string;
  fiatConversion: string;
  fiatCode: string;
};

Details

Schema (fields needed):

Look to the type definitions used in dao-data to inform what we need in our schema

Create a job that gets the vault data from DAOs in the processing queue and stores their vault data to Ceramic so that it can be accessed by the DAOs Table in Hub
Steps (dao-data package has functions for this ):

Take each DAO off the queue (#194)
Query the Gnosis API by network and safe address
Create/update a DID for each DAO/safe with the token/vault info
Does this then remove the DAO from the queue and then re-add every 5 minutes to keep the data fresh with any updates?

Questions/Future Tickets Considerations:

Update the dao-data SDK to query Ceramic instead of the Gnosis API directly
In the future we may need a way to trigger this on demand (such as if a DAO sends a token immediately we'd need an updated token balance instead of one that may be have info that is ~5 minutes outdated)

For single time on demand hits the frontend app could leverage the dao-data

Deliverables

DAO Bank Vault Consumer Job added to our infrastructure
Potential Playbook documentation?

Related Issues

#195
#172
#196

Requires Helm

@alexkeating added https://github.com/HausDAO/daohaus-monorepo/issues/504


Updated the libraries and complex mech params

Proposed changes
Updated the lib versions of open-autonomy and it's deps to 0.18.2.
Removed the complex params using lists and updated and renamed them to use the dict.
Remove agent_mech_contract_addresses param and directly use the address provided in mech_to_config param
Fixes
If it fixes a bug or resolves a feature request, be sure to link to that issue.
Types of changes
What types of changes does your code introduce? (A breaking change is a fix or feature that would cause existing functionality and APIs to not work as expected.)
Put an x in the box that applies

[ ] Non-breaking fix (non-breaking change which fixes an issue)
[ ] Breaking fix (breaking change which fixes an issue)
[ ] Non-breaking feature (non-breaking change which adds functionality)
[ ] Breaking feature (breaking change which adds functionality)
[ ] Refactor (non-breaking change which changes implementation)
[ ] Messy (mixture of the above - requires explanation!)

Checklist
Put an x in the boxes that apply.

[ ] I have read the CONTRIBUTING doc
[ ] I am making a pull request against the main branch (left side). Also you should start your branch off our main.
[ ] Lint and unit tests pass locally with my changes
[ ] I have added tests that prove my fix is effective or that my feature works

Further comments
If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

@KahanMajmudar also please address failing checks.


PROD-374/message-relation-stack-does-not-exist

What functionality was breaking because of this?

It could easily cause application server error and crash the app.


version: remove checking gRPC version

gRPC version is not needed in Version() endpoint.
PTAL @runcom

Forgot about new CLA forms, will be done ASAP.

lgtm, @mrunalp PTAL

Looks good. Will wait for CLA to be resolved. Thanks!

@mrunalp CLA is resolved, Travis has to be rerun

@jjlakis Travis is telling you need to sign your commit cause it's missing DCO

@runcom @mrunalp All done, thanks.


migrate gRPC plugin to an indy plugin

What does this PR do?
Fixes #1332 by migrating to an indy plugin.
Relates to https://github.com/elastic/apm-agent-java/issues/1337
Checklist

[x] This is something else

[x] I have updated CHANGELOG.asciidoc

:green_heart: Build Succeeded

Expand to view the summary

Build stats

Build Cause: [Pull request #1358 opened]

Start Time: 2020-08-27T11:51:33.634+0000

Duration: 51 min 4 sec

Test stats :test_tube:

Test
Results

Failed
0

Passed
1484

Skipped
11

Total
1495


GUI is not working

Ludusavi version
v0.23.0
Operating system
Linux
Installation method
Standalone
Description
The tool does not work for the GUI. The CLI works just fine but the GUI doesn't. I have no idea whats causing this.
Logs
wl_drm@50: error 0: wl_drm.create_prime_buffer is not implemented
Protocol error 0 on object wl_drm@50:
Protocol error 0 on object wl_drm@50:
Protocol error warning: queue 0x5eaf99976be0 destroyed while proxies still attached:
0  wl_registry@53 still attached
on object wl_drm@50:
Protocol error thread 'main' panicked at /home/runner/.cargo/registry/src/index.crates.io-6f17d22bba15001f/wgpu-0.19.3/src/backend/wgpu_core.rs:7240: on object 18wl_drm:
@Error in Surface::configure: Validation Error
Caused by:
Surface does not support the adapter's queue family
50
: note: run with RUST_BACKTRACE=1 environment variable to display a backtrace
Protocol error 0 on object wl_drm@50:
Protocol error 0 on object wl_drm@50:
Protocol error 0 on object wl_drm@50:
Protocol error 0 on object wl_drm@50:
Protocol error 0 on object wl_drm@50:
Protocol error 0 on object wl_drm@50:
Protocol error 0 on object wl_drm@50:
Protocol error 0 on object wl_drm@50:
Protocol error 0 on object wl_drm@50:
Protocol error 0 on object wl_drm@50:

Hi! This is probably a GPU/driver issue. Please try setting the ICED_BACKEND environment variable to tiny-skia to use the software renderer instead.

Thank for the quick reply. That worked I ran ICED_BACKEND=tiny-skia ./ludusavi. This problem is solved but do you know of a more permanent solution. Other than that thanks.

I'm glad that helped :) Unfortunately, I don't know a solution to the underlying problem, especially since it may be hardware/driver-specific. In some cases, updating your graphics drivers may help.

Hi, I was thinking about this issue and tried starting a session on Xorg rather than Wayland which was what I used when the error occurred. Running Ludusavi on Xorg works fine but when I run Ludusavi on Wayland it will throw out that error. I believe that there is nothing wrong with my graphics or drivers. Does Ludusavi not have full support for Wayland?


[STYLE CHANGE] : On hover of header item, there is a layout shift

Description:
When we hover over any of the list items of the header navbar, there is a little layout shift.
Reason for Change:
Due to the shift in layout, the user experience may not look. Because also there is not any kind of transition applied.
Current Styling:
Currently, on hover, you are increasing the font size.
Proposed Styling:
But instead of increasing the font size, we can scale it and add a small transition for a good user experience.

Hey, Can you please assign this issue to me, I will fix it.

Hey @shubhamku044
I am Assigning this issue to you

Hey @shubhamku044
There is already the same issue i.e #149
Therefore I am marking this issue as a duplicate.
Thankyou for raising the issue though


Proper folder naming / structure

It is not clear from the docs.
Should I necessary name the folder google_fonts and make it a top-level folder?
I put my font into assets/fonts/montserrat/, and wrote this path in my pubspec, and it seems to be working too.
Also, it is not convenient to keep all my fonts in the same folder without subfolders. Each has it's own OFL.txt, and they will overwrite each other.

Hi, it's not. as long as it's specified somehow in the assets it will be picked up


[Bug] Deserializing KeyPackages fails when the lifetime of the KeyPackage is expired

We might want to have more flexibility when deserializing KeyPackages and only check the validity of the lifetime later. In particular, this might be useful when parsing KAT vectors.

From an oob sync call:

Use the type system to enforce validation
First verify lifetime, then signature
Have a generic validation mechanism for custom extensions


Add and modify user metadata for files after they have been uploaded.

Using the API it was previously possible to add user metadata to existing objects by staging them. The new stage api cannot be used to achieve this and object metadata can only be added on posting a new object.
It would be very useful to be able to add metadata to existing objects without having to repost the object.

@treeverse/product


validate_on_submit() expects a tuple list for SelectField even though a normal list is a valid argument

Actual Behavior
form.validate on submit() evaluates to False when choices in SelectField is a list of values only. The same form validation evaluates to  True when using (value, label) tuples as used with version 2.2.1

class RegistrationForm(FlaskForm):

    language = SelectField('Language', choices=['python', 'ruby', 'rust'], validators=[DataRequired()])
    submit = SubmitField('Submit')

@app.route('/', methods=['GET', 'POST'])
def index():
    form = RegistrationForm()
    if form.validate_on_submit():
        return redirect(url_for('test'))
    return render_template('index.html', form=form)

The SelectField() is rendered properly in the HTML form and its value can be accessed with form.language.data but form.validate_on_submit() still evaluates to False.
Expected Behavior
form.validate on submit() to evaluate to True when choices in SelectField is a list of values only as well.
Environment

Python version: 3.8.2
wtforms version: 2.3.1

Thank you for reporting this issue.
validate_on_submit is actually a flask-wtf feature, not a core wtforms. I encourage you to report the issue on the flask-wtf repository.

Okay will do.

@azmeuk validate_on_submit was misleading, it had nothing to do with the SelectField validation issue.
Duplicate of #598, needs to be backported and released on 2.x.

wtforms 2.3.2 is out now.


remove required email field for identifies

Just deployed this change, let us know if you run into any issues with it!

Excellent


1.1.1 release

🚫 CI failed with log

          1 Warning

:warning:
PR modifies CI file

  Generated by :no_entry_sign: Danger


skip derived key approval page if the user has no money

We actually don't need (or want) to do this.


Reorganized signature-scheme detection in 'apps/s_cb.c'

Reorganized signature-scheme detection in 'apps/s_cb.c:security_callback_debug' callback_debug' callback-function.
So far, it only handled hash-and-algorithm pairs from TLS1.2,
now it also handles 'schemes' defined in TLS1.3 like 0x0807=ed25519 or
0x0809=rsa_pss_pss_sha256
Now it prints information in one of these formats:
... Algorithm scheme=ecdsa_secp256r1_sha256, security bits=128 ... TLS1.3
... Algorithm digest=SHA384, algorithm=DSA, security bits=192  ... TLS1.2
... Algorithm scheme=unknown(0x0e01), security bits=128        ... unhandled case

To implement this added three new lookup-tables: signature_tls13_scheme_list,
signature_tls12_alg_list, signature_tls12_hash_list.
Also minor changes in 'security_callback_debug', eg adding variable 'show_nm'
to indicate if we should show 'nm'.
Also coding-styles fixes from matcaswell
Note: This is a re-run of PR#8249 which I couldn't properly manage. Sorry for the trouble I've caused.

comment-only change: found reference for GOST
-/* from rfc8446 4.2.3. + gost(source?) */
+/* from rfc8446 4.2.3. + gost (https://tools.ietf.org/id/draft-smyshlyaev-tls12-gost-suites-04.html) */

Travis red cross does not seem relevant.

Pushed. Thanks.

Thank you very much, mattcaswell, paulidale, levitte:)


No programming skills required?

I think I downloaded all the files and install the things needed, however I really don't know where to start like even which software I should launch. I read the readme files but I still don't know what I should do.
Do you have any advices or links to any tutorial?
Thank you

Did you run make in the README? It's basic software installation skill instead of real programming skill. Read this to learn more if you are unfamiliar with it. Notice that we need neither ./configure before make nor make install after make, so only make is required here.


Item do not decay when sector sleep

Since I using X, I notice some "annomaly" about the decay of item. When I entering a dungeon and someone pass few time before me, I see corps of monster on the ground. Since I go near of them they dissapear.
There is the same situation on mine where I can see old ore ont he ground and dissapear when i'm near them.
I think it can be 2 problems
1- Item do not decay on sleep and it should
2- Adjacent sector do not awake and it's why you see the item decay when you enter that sector.
This BUG may be the same bug than this issue: https://github.com/Sphereserver/Source-X/issues/467

Yep i confirm this issue, also is problematic for memory on summon or some other system based on memory timing, because if sector go to sleep memory on summon in sleep sector not decay --> summo not removed --> follower not update --> ecc ecc

Yep i confirm this issue, also is problematic for memory on summon or some other system based on memory timing, because if sector go to sleep memory on summon in sleep sector not decay --> summo not removed --> follower not update --> ecc ecc

I might be wrong but i think that on 56 the timer (which, upon reaching 0, causes the decay) froze if the sector was sleeping. If that's the case, the issue here is adjacent sector not waking up. Is that still happening?


Coloring

The red color in the diagram implied a case that was prohibited, not allowed or undesired, while in fact it was just meant to mark different execution.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 57342b31-8271-e130-3df5-130580c9ea70
Version Independent ID: fbd3f4b8-4199-2d82-245c-4a18f1073386
Content: Service Fabric Reliable Actors Overview
Content Source: articles/service-fabric/service-fabric-reliable-actors-introduction.md
Service: service-fabric
GitHub Login: @vturecek
Microsoft Alias: vturecek

Thanks for the feedback! I have assigned the issue to the content author to investigate further and update the document as appropriate.

Thank you for looking into the remark I have given.
My remark was not a critique of any kind and it was not indicating a mistake from your end.
It as just an attempt towards perfection because Microsoft has always been #1 in documentation and user-friendly interfaces without competition.
Yes, you can choose any colors you want. but look at this link for instance:
https://docs.microsoft.com/en-us/azure/architecture/patterns/bulkhead
Is the color red here for distinction or is it to indicate a failure in service?
In many cases, users can look at the diagram without reading the text and they should get the content immediately or at least that is what they expect.
In many Microsoft documents, I have notices that pattern, red is used to indicate a wrong use-case or a failure or bad practice etc.
That was only my concern, I am NOT reporting a bug or a mistake in documentation.


ValueError: GpuElemwise. Input dimension mis-match. Input 1 (indices start at 0) has shape[1] == 1, but the output's size on that axis is 10.

I just install keras and try an example:
from keras.models import Sequential
from keras.layers.core import Dense, Dropout, Activation, Flatten
from keras.layers.convolutional import Convolution2D, MaxPooling2D
from keras.optimizers import SGD
from keras.datasets import cifar100
from read_data import get_CIFAR10_data_original
(X_train, y_train), (X_test, y_test) = cifar100.load_data(label_mode='fine')
datasets = get_CIFAR10_data_original() # 3_32_32
train_set_x, train_set_y = datasets[0]
valid_set_x, valid_set_y = datasets[1]
test_set_x, test_set_y = datasets[2]
model = Sequential()
model.add(Convolution2D(32, 3, 3, 3, border_mode='full'))
model.add(Activation('relu'))
model.add(Convolution2D(32, 32, 3, 3))
model.add(Activation('relu'))
model.add(MaxPooling2D(poolsize=(2, 2)))
model.add(Dropout(0.25))
model.add(Convolution2D(64, 32, 3, 3, border_mode='full'))
model.add(Activation('relu'))
model.add(Convolution2D(64, 64, 3, 3))
model.add(Activation('relu'))
model.add(MaxPooling2D(poolsize=(2, 2)))
model.add(Dropout(0.25))
model.add(Flatten())
model.add(Dense(64_8_8, 256))
model.add(Activation('relu'))
model.add(Dropout(0.5))
model.add(Dense(256, 10))
model.add(Activation('softmax'))
sgd = SGD(lr=0.1, decay=1e-6, momentum=0.9, nesterov=True)
model.compile(loss='categorical_crossentropy', optimizer=sgd)
model.fit(X_train, y_train, batch_size=64, nb_epoch=5, verbose=2, show_accuracy=True)
I got the error like this:
Epoch 0
Traceback (most recent call last):
File "/home/mvg/workspace/CIFAR_10/test_keras/test_keras.py", line 43, in
model.fit(X_train, y_train, batch_size=64, nb_epoch=5, verbose=2, show_accuracy=True)
File "/usr/local/lib/python2.7/dist-packages/keras/models.py", line 490, in fit
shuffle=shuffle, metrics=metrics)
File "/usr/local/lib/python2.7/dist-packages/keras/models.py", line 211, in _fit
outs = f(*ins_batch)
File "/usr/local/lib/python2.7/dist-packages/theano/compile/function_module.py", line 618, in call
storage_map=self.fn.storage_map)
File "/usr/local/lib/python2.7/dist-packages/theano/gof/link.py", line 297, in raise_with_op
reraise(exc_type, exc_value, exc_trace)
File "/usr/local/lib/python2.7/dist-packages/theano/compile/function_module.py", line 607, in call
outputs = self.fn()
ValueError: GpuElemwise. Input dimension mis-match. Input 1 (indices start at 0) has shape[1] == 1, but the output's size on that axis is 10.
Apply node that caused the error: GpuElemwise{Composite{(i0 * ((i1 / i2) + i3))}}[(0, 0)](GpuElemwise{Composite{Cast{float32}%28AND%28GE%28i0, i1%29, LE%28i0, i2%29%29%29},no_inplace}.0, GpuElemwise{Mul}[%280, 1%29].0, GpuElemwise{Clip}[%280, 0%29].0, GpuElemwise{Composite{%28%28-i0%29 / i1%29}}[%280, 0%29].0)
Toposort index: 162
Inputs types: [CudaNdarrayType(float32, matrix), CudaNdarrayType(float32, matrix), CudaNdarrayType(float32, matrix), CudaNdarrayType(float32, col)]
Inputs shapes: [(64, 10), (64, 1), (64, 10), (64, 1)]
Inputs strides: [(10, 1), (1, 0), (10, 1), (1, 0)]
Inputs values: ['not shown', 'not shown', 'not shown', 'not shown']
Outputs clients: [[GpuAdvancedIncSubtensor1_dev20{inplace,inc}(GpuAlloc{memset_0=True}.0, GpuElemwise{Composite{(i0 * ((i1 / i2) + i3))}}[(0, 0)].0, Elemwise{Cast{int64}}.0)]]
HINT: Re-running with most Theano optimization disabled could give you a back-trace of when this node was created. This can be done with by setting the Theano flag 'optimizer=fast_compile'. If that does not work, Theano optimizations can be disabled with 'optimizer=None'.
HINT: Use the Theano flag 'exception_verbosity=high' for a debugprint and storage map footprint of this apply node.

If your model output is 10-dimensional, so should be your target. Here your target is 1-dimensional list of labels, it seems...

In case anybody else arrives here (it was the top result in Google for me for this error), the issue for me was not the number dimensions not matching. I had a 2D input and output. My issue was that the output of my model did not match the size in one dimension of the expected data y that I was feeding into .fit(), so the loss couldn't be calculated.
Maybe useful to anybody else seeing a similar problem. Check your model output size and the size of the y parameter your are feeding to fit().


RuntimeError in ctc_att_transformer_train.py

See below (using the latest master)
2021-03-29 07:34:23,835 INFO [common.py:270] ================================================================================
2021-03-29 07:34:23,837 INFO [ctc_att_transformer_train.py:440] epoch 0, learning rate 0
Traceback (most recent call last):
  File "./ctc_att_transformer_train.py", line 508, in <module>
    main()
  File "./ctc_att_transformer_train.py", line 442, in main
    objf, valid_objf, global_batch_idx_train = train_one_epoch(dataloader=train_dl,
  File "./ctc_att_transformer_train.py", line 220, in train_one_epoch
    curr_batch_objf, curr_batch_frames, curr_batch_all_frames = get_objf(
  File "./ctc_att_transformer_train.py", line 95, in get_objf
    nnet_output, encoder_memory, memory_mask = model(feature, supervisions)
  File "/ceph-fj/fangjun/py38/lib/python3.8/site-packages/torch/nn/modules/module.py", line 727, in _call_impl
    result = self.forward(*input, **kwargs)
  File "/root/fangjun/open-source/s2/snowfall/snowfall/models/transformer.py", line 92, in forward
    encoder_memory, memory_mask = self.encode(x, supervision)
  File "/root/fangjun/open-source/s2/snowfall/snowfall/models/transformer.py", line 108, in encode
    x = self.encoder_embed(x)
  File "/ceph-fj/fangjun/py38/lib/python3.8/site-packages/torch/nn/modules/module.py", line 727, in _call_impl
    result = self.forward(*input, **kwargs)
  File "/root/fangjun/open-source/s2/snowfall/snowfall/models/transformer.py", line 384, in forward
    x = self.out(x.transpose(1, 2).contiguous().view(b, t, c * f))
  File "/ceph-fj/fangjun/py38/lib/python3.8/site-packages/torch/nn/modules/module.py", line 727, in _call_impl
    result = self.forward(*input, **kwargs)
  File "/ceph-fj/fangjun/py38/lib/python3.8/site-packages/torch/nn/modules/linear.py", line 93, in forward
    return F.linear(input, self.weight, self.bias)
  File "/ceph-fj/fangjun/py38/lib/python3.8/site-packages/torch/nn/functional.py", line 1692, in linear
    output = input.matmul(weight.t())
RuntimeError: mat1 dim 1 must match mat2 dim 0

In https://github.com/k2-fsa/snowfall/pull/140, feature dimention is changed from 40 to 80. Replace num_features=40 with num_features=80 in https://github.com/k2-fsa/snowfall/blob/master/egs/librispeech/asr/simple_v1/ctc_att_transformer_train.py#L406 could fix it.

@zhu-han
thanks

I think that we should consider a refactoring of snowfall to share more code between the recipes. The number of similar issues will grow exponentially as we start adding new recipes (new corpora or scripts with new training methods).

You are good at refactoring things.  Perhaps you could work on that?
It doesn't have to be  super carefully done, we'll have further rounds of
refactoring once we settle on that algorithms we'll be using.
Right now we are a bit short-handed here, and I want to focus on reducing
the WER (currently, RNNLMs are the main focus).
On Tue, Mar 30, 2021 at 12:07 AM Piotr Żelasko @.***>
wrote:

I think that we should consider a refactoring of snowfall to share more
code between the recipes. The number of similar issues will grow
exponentially as we start adding new recipes (new corpora or scripts with
new training methods).
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/k2-fsa/snowfall/issues/142#issuecomment-809510166,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAZFLO66P2V57BIYRKVODNDTGCQV5ANCNFSM4Z6RNG4Q
.

I’m happy to do it, it’s actually been on my radar for some time now, but my time is also spread a bit thin lately. Anyway, I guess let’s just keep our eyes open for easy wins for now, once I can I’ll look into it more..


Specify a model from a specific directory for extract_features.py

I have downloaded  the model and vocab files into a specific location, using their original file names, so my directory for bert-base-cased contains:
bert-base-cased-vocab.txt
bert_config.json
pytorch_model.bin

But when I try to specify the directory which contains these files for the --bert_model parameter of extract_features.py I get the following error:
ValueError: Can't find a vocabulary file at path <THEDIRECTORYPATHISPECIFIED> ...

When I specify a file that exists and is a proper file, the error messages seem to indicate that the program wants to untar and uncompress the files.
Is there no way to just specify a specific directory that contains the vocab, config, and model files?

The last update broke this, but you can fix this in tokenization.py, you have to add this after vocab_file = pretrained_model_name:
if os.path.isdir(vocab_file):
    vocab_file = os.path.join(vocab_file, "vocab.txt")

Thank you, is it fair to assume that this will get accepted as an issue and fixed in a future update/release?

Yes :-) There is a new release planned for tonight that will fix this (among other things, basically all the other open issues).

Ok, this is now included in the new release 0.3.0 (by #73).


Layer 4 load balancer - no route to host

Hi Marc and Scott
Thank for the great book !
I am stuck at chapter 6, trying to create Layer 4 load balancer.
curl <IP_ADDRESS>:8080 -> No route to host
I used the following command with the related yaml file , replacing something that maybe is related to my version.
kubectl create deployment nginx-web --image bitnami/nginx ( replaced run with create deployment )
kubectl apply -f nginx-lb.yaml <-- replaced run selector with app
apiVersion: v1
kind: Service
metadata:
name: nginx-lb
spec:
ports:

protocol: TCP
port: 8080
targetPort: 8080
selector:
app: nginx-web
type: LoadBalancer

My logs
kubectl get  services -n default
NAME         TYPE           CLUSTER-IP      EXTERNAL-IP      PORT(S)          AGE
kubernetes   ClusterIP      <IP_ADDRESS>                  443/TCP          3h40m
nginx-lb     LoadBalancer   <IP_ADDRESS>   <IP_ADDRESS>   8080:30968/TCP   67m
kubectl describe service nginx-lb
Name:                     nginx-lb
Namespace:                default
Labels:
Annotations:
Selector:                 app=nginx-web
Type:                     LoadBalancer
IP Families:
IP:                       <IP_ADDRESS>
IPs:
LoadBalancer Ingress:     <IP_ADDRESS>
Port:                       8080/TCP
TargetPort:               8080/TCP
NodePort:                   30869/TCP
Endpoints:                <IP_ADDRESS>:8080
Session Affinity:         None
External Traffic Policy:  Cluster
Events:
Type    Reason        Age   From                Message

Normal  IPAllocated   6s    metallb-controller  Assigned IP "<IP_ADDRESS>"
Normal  nodeAssigned  6s    metallb-speaker     announcing from node "cluster01-worker"
kubectl describe  pod -n default
Name:         nginx-web-5c9b7f757-zdf2b
Namespace:    default
Priority:     0
Node:         cluster01-worker/<IP_ADDRESS>
Start Time:   Tue, 04 May 2021 16:45:02 +0200
Labels:       app=nginx-web
pod-template-hash=5c9b7f757
Annotations:  cni.projectcalico.org/podIP: <IP_ADDRESS>/32
cni.projectcalico.org/podIPs: <IP_ADDRESS>/32
Status:       Running
IP:           <IP_ADDRESS>
IPs:
IP:           <IP_ADDRESS>
Could you please help to debug ? @mlbiam @ssurovich
Thanks a lot
Regards

Hi @germal  -- Thanks for the book compliment, glad you are enjoying the book so far.
The first part I need to verify is what network the Docker bridge is on -  if you check using docker network inspect bridge, does it reply with <IP_ADDRESS>/16?

Hello @ssurovich ,
Thank you for your reply .
Yes the docker network is that :
       "Config": [
            {
                "Subnet": "<IP_ADDRESS>/16",
                "Gateway": "<IP_ADDRESS>"
            }
        ]

Thanks

Thanks for the verification on the Subnet (I assumed it was set to <IP_ADDRESS> but just wanted to make sure).
Next question - Are you running on Ubuntu, RHEL, etc...?
I'll reproduce the test in my home lab a little later today just to make sure nothing has changed that may have impacted the hands-on exercise.
On your question - I would recommend that the Repo is cloned to the Docker Host itself, not a container on the Host.  However, a Kind container shouldnt have any issues accessing the Web to clone the repo.

Hello Scott
I use Ubuntu 18.04 as Host.
Thanks for your explanation,I have to check why it doesn't access to github.

Hi @germal  -  Sorry for my delayed reply, I thought I replied last week and just realized I didnt send the comment.
I believe your issue is due to the docker network - <IP_ADDRESS> is the default Docker bridge and kind is using the kind Docker network, which is likely <IP_ADDRESS> on your host.   On page 169/170 it says to get the IP range from the docker network inspect bridge, but that should docker  network inspect kind.
If your kind bridge does match the <IP_ADDRESS>/16 range, you can edit the metallb-config.yaml file, so it will look like the below:
apiVersion: v1
kind: ConfigMap
metadata:
namespace: metallb-system
name: config
data:
config: |
address-pools:
- name: default
protocol: layer2
addresses:
- <IP_ADDRESS>-<IP_ADDRESS>
Please let me know if this does resolve your issue.  Sorry for the delay in this reply again.

Since I have tested this a few times now, I believe it will resolve your issue - If it doesnt, please re-open the issue and I will help.


Format of the timestamp in the oplog.timestamp file

Folks,
Can you provide more details into the format of the timestamp stored in the oplog.timestamp? I have to manually generate a time due to a bug I am running into (Issue 274)
E.g. I would like to convert Timestamp(1465084837, 2) into the oplog.timestamp format.

Never mind - I was able to determine the format using https://github.com/mongodb-labs/mongo-connector/issues/324


New Event for SignServContractDoc CU

Describe the request
A new event at the end of the SetInvoicing procedure which gives access to the same variables in the OnBeforeSetInvoicing Event within CU 5944 (SignServContractDoc)
Additional context
This is needed due to bespoke functionality which depends on if InvoiceNow is true after the confirm message has been shown.
Internal work item: AB#498224

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. Please do not reply to this, as we do not monitor closed issues. If you have follow-up questions or requests, please create a new issue where you reference this one.
Build ID: 15815.


Update elphyio

fix outdated imports
fix py3 compatibility
reintroduce tests

Hello @JuliaSprenger! Thanks for submitting the PR.

In the file neo/io/elphyio.py, following are the PEP8 issues :

Line 190:9: E122 continuation line missing indentation or outdented
Line 223:100: E501 line too long (100 > 99 characters)
Line 230:9: E122 continuation line missing indentation or outdented
Line 283:9: E122 continuation line missing indentation or outdented
Line 323:100: E501 line too long (100 > 99 characters)
Line 353:100: E501 line too long (100 > 99 characters)
Line 439:9: E122 continuation line missing indentation or outdented
Line 595:13: E722 do not use bare except'
Line 1189:100: E501 line too long (105 > 99 characters)
Line 1466:100: E501 line too long (101 > 99 characters)
Line 1478:100: E501 line too long (100 > 99 characters)
Line 1669:9: E722 do not use bare except'
Line 1677:9: E722 do not use bare except'
Line 1784:9: E722 do not use bare except'
Line 2695:12: E713 test for membership should be 'not in'
Line 2795:100: E501 line too long (113 > 99 characters)
Line 2805:100: E501 line too long (107 > 99 characters)
Line 2863:100: E501 line too long (100 > 99 characters)
Line 2952:37: E127 continuation line over-indented for visual indent
Line 3394:25: E231 missing whitespace after ','
Line 3395:18: E225 missing whitespace around operator
Line 3396:12: E713 test for membership should be 'not in'
Line 3507:17: E122 continuation line missing indentation or outdented
Line 3525:100: E501 line too long (100 > 99 characters)
Line 3538:13: E125 continuation line with same indent as next logical line
Line 3811:39: E711 comparison to None should be 'if cond is None:'
Line 3873:100: E501 line too long (102 > 99 characters)
Line 3879:100: E501 line too long (115 > 99 characters)
Line 3886:100: E501 line too long (102 > 99 characters)
Line 3908:100: E501 line too long (100 > 99 characters)
Line 3940:100: E501 line too long (105 > 99 characters)
Line 3941:100: E501 line too long (117 > 99 characters)
Line 4027:100: E501 line too long (103 > 99 characters)
Line 4132:100: E501 line too long (100 > 99 characters)
Line 4152:100: E501 line too long (100 > 99 characters)
Line 4255:100: E501 line too long (104 > 99 characters)

Coverage increased (+1.4%) to 50.327% when pulling cb743a4f1b3221d600dda8fb5d83fabc614d5ff8 on INM-6:fix/elphy into db9357c37de1ea281cbe04c4b46ea4095571d4b3 on NeuralEnsemble:master.

Coverage increased (+1.4%) to 50.327% when pulling cb743a4f1b3221d600dda8fb5d83fabc614d5ff8 on INM-6:fix/elphy into db9357c37de1ea281cbe04c4b46ea4095571d4b3 on NeuralEnsemble:master.

Coverage increased (+1.4%) to 50.327% when pulling cb743a4f1b3221d600dda8fb5d83fabc614d5ff8 on INM-6:fix/elphy into db9357c37de1ea281cbe04c4b46ea4095571d4b3 on NeuralEnsemble:master.

Thank you for the clean.
Can I merge ?
Are you using elphy files ??????

If you are happy with the changes, then you can merge.
No, we are not using elphy files on a regular basis, this was rather an exception.

OK.


Replace SCTFE multi-config with flags for a single log

Towards #88
Today, the SCTFE is configured via a config proto file, and supports multiple logs. We've decided to drop the support for multiple logs, and move to flags.
I'll do this in multiple steps along these lines:

drop multi log support
move from config to flags where we can, keep some things in there if need be, especially for keys that will undergo further changes
on GCP, use KMS and/or Tink
simplify the internals of the SCTFE to remove the virtual configs structs, if we can

makes a ton of sense to minimize the surface for the MVP.

The config is now gone. A bit more work is required here to simplify the internals, and pass keys in a better way.

Closing this issue as we're migrating SCTFE code to transparency-dev/static-ct.
Here are issues for the two outstanding items:

https://github.com/transparency-dev/static-ct/issues/5
https://github.com/transparency-dev/static-ct/issues/6


TypeError: undefined is not an object (evaluating 'e.toUpperCase')

This error appears from Nova v3.8.0 and above. I'm using 1.9.1 of this package.

Can confirm the same error on the latest version of multiselect and Nova. Appears to be broken on all our up to date projects.

Hi!
This is an issue with Laravel Nova and will be resolved shortly, after the PR at https://github.com/laravel/nova/pull/931 is merged.
Let us wait for them to act.

Seems like they pushed the buggy release and all went on vacation. I added a fix to this package and released it in version 1.9.2.


[17.07] cluster: Avoid recursive RLock

Cherry-picked from https://github.com/moby/moby/pull/34235/commits/bd4f66c8f1f6ad4a2f228a957f293bc157e13d9c (https://github.com/moby/moby/pull/34235)
no conflicts
ping @aaronlehmann  @fcrisciani @tonistiigi
GetTasks can call GetService and GetNode with the read lock held. These
methods try to aquire the read side of the same lock. According to the
sync package documentation, this is not safe:

If a goroutine holds a RWMutex for reading, it must not expect this or
any other goroutine to be able to also take the read lock until the
first read lock is released. In particular, this prohibits recursive
read locking. This is to ensure that the lock eventually becomes
available; a blocked Lock call excludes new readers from acquiring the
lock.

Fix GetTasks to use the lower-level getService and getNode methods
instead. Also, use lockedManagerAction to simplify GetTasks.

LGTM

Test failures are known as per docker/docker-ce#140:
Checked with this script: https://gist.github.com/seemethere/6128cb2391cd43b65b0ff4880af427e5
Output:
❯ bash check_failures.sh https://jenkins.dockerproject.org/job/docker-ce-pr/98/consoleText
found...DockerSuite.TestRmiContainerImageNotFound
found...DockerSuite.TestRmiImageIDForceWithRunningContainersAndMultipleTags
found...DockerSuite.TestRunWithNanoCPUs
found...DockerSuite.TestUpdateWithNanoCPUs
found...DockerSwarmSuite.TestServiceLogs
found...DockerSwarmSuite.TestSwarmNetworkPluginV2
found...DockerSwarmSuite.TestSwarmServicePsMultipleServiceIDs
found...DockerSuite.TestRunAttachDetachFromInvalidFlag


Notifiers tweaks

Motivation for changes:
Hindsight is 20/20
Detailed changes:

Refactored notify so that base will be reused.
Created notify_entries plugin that sets the scope to entries.
Created notify_task plugin that sets the scope to task.
Created notify_abort plugin .
Changed notify_crash to actually notify only on crashes and not any abort .
Added templates CLI that lists all file templates with their content.
Removed sting replacement code from render()

Now I'm starting to wonder about notifications from handled errors that cause log messages. I also started wondering if we want the ability to consolidate those errors so they don't get spammy. I think there should be some sort of way to notify about errors outside of task contexts, I'm just not exactly sure what sort of errors to include, and how to handle them best. Would also have to think about overlap with task level notify plugins if we have that.

Yeah, i though about hooking events to logger calls (specifically on critical, error and warning). It might still be a valid idea, but I rather get this PR out of the way first before adding new functionality.

you can use it in a global template. I think it feels better than a root level, since it has no merit or functionality on its own.

I'm talking about reporting errors outside of the task context. For example: scheduler, webui, api, irc. I think maybe a plugin to send log messages to notifier would be good, but I agree, that can wait. Should we just delete notify_crash for now then?

notify_crash is not similar to notify_abort. it checks for existence of task.traceback which gets populated only on crashes

Hmm, task.traceback? Where is that coming from? I think we may be better off just sticking with the abort one now. I think for crash notification, we really wouldn't want to confine that to individual tasks would we?

dunno, feels fine to me using it in global but I'm cool with root level too. I'll drop it

Seems good to me!

I'll update wiki asap


Fixed the Postgres database creation command to prevent errors when the database already exists

Thanks for the fix !!


Lottie Animations

I am currently working on a project using Flet and I currently need to add Lottie Animations for idle loading. So I decided to use Lottie Animations. Please is there a way for me to do so

Closing as dup of https://github.com/flet-dev/flet/issues/88


Inconsistent Response from Historical Data Requests

During Treehacks, we were seeing responses returning incomplete data(Only 1 field having data returned) or being invalid json objects. I have a feeling it is because the requests are M x N which are causing the issues.
Sample json request that was causing issues:
{
   "securities": ["FOXA US Equity", "CTSH US Equity", "APC US Equity"],
    "fields": ["PX_LAST", "OPEN", "EPS_ANNUALIZED"],
    "startDate": "20120601",
    "endDate": "20120602",
    "periodicitySelection": "DAILY"
}

@aceofsteel, can you provide more details of the language used that was running into this issue?  curl appears to be returning a response with no errors.  I am guessing this is an issue with NodeJS?

We were using python 2. Don't have my setup with me now to reproduce. When we ran the request, 3/5 times it was invalid json.

We found that this has always been issue and has recently surfaced as being exposed.  There was async mi-synchronization that was happening.  However, a48f37c of #89 fixes this issue.  We are going to bump the hackathon branch to the latest develop at cd9195a and bounce http-api.openbloomberg.com.

Updated hackathon branch and bounced http-api.openbloomberg.com - everything looks OK now.


How to use stylesheet with ADS focushighlighting?

How to use and customize stylesheet for Advanced Docking System if DockerManager configuration flag for  Focushighlighting is set true? Thanks your for your answear.

I'll see if I can find a minimum, working example of it working in PySide6 and then slowly add in styles to see what might be conflicting.

I should have a solution with this and can implement it in directly. I've also added in some tests to ensure this works well.

These are the previews after the changes,


Chips Autocomplete

Bug, feature request, or proposal:
Application does not display  Permissions in dropdown in Choose Permission field if user types first character
When user enters first character for first time it suggests.On selecting a value when user again selects first charcter it does not display the dropdown. The user has to press backspace and press character again
What is the expected behavior?
Whenever user enters first character for first time chips autocomplete filter is working as per requirement. we selected chips as required, but , just after that if we
try to enters first character, then it is not working as it was working in first time, if we will press backspace then enters first character, then it is working as per requirement
What is the current behavior?
it is isssue in chips autocomplete
What are the steps to reproduce?
Step 1 :  data = ['Afganistan','Albania','Andorra','Angola','Argentine','Armenia','Australia'];
Step 2 : enter first charactor 'A'
Step 3 : Select country 'Afganistan' in chip
Step 4 : Again enter first charactir 'A'
Now filter is not working.
What is the use-case or motivation for changing an existing behavior?
Which versions of Angular, Material, OS, TypeScript, browsers are affected?
@angular/core: ^5.2.0
@angular/material: ^5.2.0
typescript: ~2.6.2
Is there anything else we should know?

Are you able to share a live reproduction w/ the latest version of the library?

It looks like the issue that is being seen is that the first character typed in the input after selection of a chip does not trigger the autocomplete, however the second keystroke does.  See this stackblitz.
If you select apple from the autocomplete (either by clicking or via keyboard selection), then type a the autocomplete does not show, but upon typing p after the a it works as expected.  It seems the first keystroke is not triggering the necessary events.

As we have verified above given link "https://stackblitz.com/edit/angular-jbgfxv?file=app/chips-autocomplete-example.html", it is giving same result, which i reported to you. We are waiting for your response please.
in case-any query, please revert.
Thanks
Atul Singh.

I have same issue. Is this fixed already?

Cannot reproduce. I believe this was fixed in v15.