Add new child device

Is there any way to add new child devices without having to remove and re-add the alarm? I recently added new smoke/co detectors to my Ring alarm that I'd like to have ST see, if possible.

Can you share more details of the sensor? May be url to ring website product page.

https://shop.ring.com/products/first-alert-smoke-co-alarm-zcombo-g-z-wave?_pos=3&_sid=de6c2128e&_ss=r

The code doesn't support this as of now. If you can send me the API response for this device. I am happy give a try.

When I posted the original question, I didn’t realize there were multiple types of smoke/co detectors. I’ll see if I can get the api response this weekend.

Here's the response from status for one device:
        {
            "id": "{guid}",
            "name": "Hallway Smoke Alarm",
            "type": "alarm.smoke",
            "faulted": false,
            "mode": ""
        },
        {
            "id": "{different guid}",
            "name": "Hallway CO Alarm",
            "type": "alarm.co",
            "faulted": false,
            "mode": ""
        },

Finally got the code running locally, and got this response from devices:
            {
                "general": {
                    "v2": {
                        "adapterType": "zwave",
                        "batteryLevel": 99,
                        "batteryStatus": "full",
                        "catalogId": "771c8545-188a-4053-b917-97fd43addc2a",
                        "commStatus": "ok",
                        "commandTypes": {
                            "reset-chip": {
                                "reset-chip": false
                            },
                            "reset-network": {
                                "reset-network": false
                            }
                        },
                        "deviceFoundTime":<PHONE_NUMBER>051,
                        "deviceType": "alarm.smoke",
                        "lastCommTime":<PHONE_NUMBER>137,
                        "lastUpdate":<PHONE_NUMBER>181,
                        "managerId": "zwave",
                        "name": "Hallway Smoke Alarm",
                        "pollInterval": 43200,
                        "roomId": 6,
                        "setupByPluginStatus": "complete",
                        "setupByUserStatus": "complete",
                        "subCategoryId": 0,
                        "tags": [
                            "sleepy"
                        ],
                        "tamperStatus": "ok",
                        "zid": "{smoke alarm guid from last comment}",
                        "adapterZid": "{adapter-guid}"
                    }
                },
                "device": {
                    "v1": {
                        "channel": 0,
                        "panId": 0,
                        "faulted": false,
                        "mode": ""
                    }
                },
                "adapter": {
                    "v1": {
                        "channel": 0,
                        "panId": 0,
                        "faulted": false,
                        "mode": ""
                    }
                },
                "impulse": {
                    "v1": null
                }
            },
            {
                "general": {
                    "v2": {
                        "adapterType": "zwave",
                        "batteryLevel": 99,
                        "batteryStatus": "full",
                        "catalogId": "2b3cd303-1590-4577-a590-a3083bc1f42c",
                        "commStatus": "ok",
                        "commandTypes": {
                            "reset-chip": {
                                "reset-chip": false
                            },
                            "reset-network": {
                                "reset-network": false
                            }
                        },
                        "deviceFoundTime":<PHONE_NUMBER>230,
                        "deviceType": "alarm.co",
                        "lastCommTime":<PHONE_NUMBER>067,
                        "lastUpdate":<PHONE_NUMBER>478,
                        "managerId": "zwave",
                        "name": "Hallway CO Alarm",
                        "pollInterval": 0,
                        "roomId": 6,
                        "setupByPluginStatus": "complete",
                        "setupByUserStatus": "complete",
                        "subCategoryId": 0,
                        "tags": [
                            "sleepy"
                        ],
                        "tamperStatus": "ok",
                        "zid": "{co alarm guid from last comment",
                        "adapterZid": "{adapter-guid}"
                    }
                },
                "device": {
                    "v1": {
                        "channel": 0,
                        "panId": 0,
                        "faulted": false,
                        "mode": ""
                    }
                },
                "adapter": {
                    "v1": {
                        "channel": 0,
                        "panId": 0,
                        "faulted": false,
                        "mode": ""
                    }
                },
                "impulse": {
                    "v1": null
                }
            },

I created a PR for the new sensors: https://github.com/asishrs/smartthings/pull/28.


Remove Metadata

Motivation and Context
Why is this change required? What problem does it solve?:
This PR removes the concept of "metadata" in a checkout object. Instead, the string column type should be used.
Description
Describe your changes in detail:
all references to "metadata" have been removed, including the 'labelenv' lmdb db, diffing/merge reporting, and fetch/push methods to syncronize changes to a server.
Documentation still needs to be updated, but the PR is generally ready for review.
Types of changes
What types of changes does your code introduce? Put an x in all the boxes that apply:

[ ] Documentation update
[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[x] Breaking change (fix or feature that would cause existing functionality to change)

Is this PR ready for review, or a work in progress?

[x] Ready for review
[ ] Work in progress

How Has This Been Tested?
Put an x in the boxes that apply:

[ ] Current tests cover modifications made
[ ] New tests have been added to the test suite
[x] Modifications were made to existing tests to support these changes
[ ] Tests may be needed, but they are not included when the PR was proposed
[ ] I don't know. Help!

Checklist:

[x] My code follows the code style of this project.
[x] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[x] I have read the CONTRIBUTING document.
[x] I have signed (or will sign when prompted) the tensorwork CLA.
[x] I have added tests to cover my changes.
[x] All new and existing tests passed.

@hhsecond and @lantiga please review when able. I don't want to merge this until we know it's the right call.


Content Suggestion: Bitcoin Rehab Podcast

Link to Content: https://anchor.fm/bitcoinrehab
Briefly Describe Content: Bitcoin fireside chat, with bitcoiners, about bitcoin related topics or life experiences. Interviewing and chatting with mostly bitcoin plebs or individuals who are mostly hidden away in the crowd.
Suggested Section: Link to the podcast page.

Added


test-branch/execute-job/quoted-authorization/e0d374a2-cdf9-4d64-973e-4ba8a7de6912

PR for testing f841b994bce3279c409730350320b9e09e77fec2

/canonical/self-hosted-runners/run-workflows f841b994bce3279c409730350320b9e09e77fec2


chore: bump version

Coverage remained the same at 100.0% when pulling 6a4ff4c8b7b57f3870a67a89f09e18923869d9d2 on update-version into f26792cf84074539f1d405e4e1fa479cfefe85cb on master.


Make WskRestRuleTests more stable.

If there is an deployment with several controllers, the test Whisk rules should preserve rule status when a rule is updated fails intermittently. The reason is, that there are several modifications on the rule. These modifications are already retried. But enabling and disabling the rule also modifies the database document. But that change is currently not retried.
This PR puts the enabling/disabling of the rule into the retry block as well to make this test more stable against our eventual consistency.
Co-authored-by: Somaya Jamil<EMAIL_ADDRESS>Related issue and scope

[ ] I opened an issue to propose and discuss this change (#????)

My changes affect the following components

[ ] API
[ ] Controller
[ ] Message Bus (e.g., Kafka)
[ ] Loadbalancer
[ ] Invoker
[ ] Intrinsic actions (e.g., sequences, conductors)
[ ] Data stores (e.g., CouchDB)
[x] Tests
[ ] Deployment
[ ] CLI
[ ] General tooling
[ ] Documentation

Types of changes

[x] Bug fix (generally a non-breaking change which closes an issue).
[ ] Enhancement or new feature (adds new functionality).
[ ] Breaking change (a bug fix or enhancement which changes existing behavior).

Checklist:

[x] I signed an Apache CLA.
[x] I reviewed the style guides and followed the recommendations (Travis CI will check :).
[ ] I added tests to cover my changes.
[ ] My changes require further changes to the documentation.
[ ] I updated the documentation where necessary.

Codecov Report

Merging #4317 into master will decrease coverage by 4.82%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #4317      +/-   ##
==========================================
- Coverage   85.68%   80.86%   -4.83%
==========================================
  Files         168      168
  Lines        7861     7861
  Branches      523      523
==========================================
- Hits         6736     6357     -379
- Misses       1125     1504     +379

Impacted Files
Coverage Δ

...core/database/cosmosdb/RxObservableImplicits.scala
0% <0%> (-100%)
:arrow_down:

...core/database/cosmosdb/CosmosDBArtifactStore.scala
0% <0%> (-95.36%)
:arrow_down:

...sk/core/database/cosmosdb/CosmosDBViewMapper.scala
0% <0%> (-92.6%)
:arrow_down:

...whisk/core/database/cosmosdb/CosmosDBSupport.scala
0% <0%> (-84.62%)
:arrow_down:

...abase/cosmosdb/CosmosDBArtifactStoreProvider.scala
4% <0%> (-52%)
:arrow_down:

...in/scala/org/apache/openwhisk/common/Counter.scala
40% <0%> (-20%)
:arrow_down:

.../scala/org/apache/openwhisk/utils/Exceptions.scala
20% <0%> (-20%)
:arrow_down:

...whisk/connector/kafka/KafkaProducerConnector.scala
72.5% <0%> (-15%)
:arrow_down:

...nwhisk/core/database/cosmosdb/CosmosDBConfig.scala
94.11% <0%> (-5.89%)
:arrow_down:

...in/scala/org/apache/openwhisk/common/Logging.scala
80.45% <0%> (-0.76%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2ddd3c9...cd937a4. Read the comment docs.


Color array when rgb can be transferred with binary transfer

I added the possibility to transfer color with the binary transfer when it is an rgb an array of rgb
or an array of array.
I think that the next one I would like to implement is to transfer with the binary transfer the hexadecimal representation of the color. (I like it better because it is a lot smaller when saving it for the embedded version)

Coverage decreased (-0.3%) to 78.46% when pulling 3377236bc9256b2b99db28227c6fa1acf1c2c31a on jeammimi:color into 65300b524c06d87c54c17dcb060722d9f5c4b2cb on maartenbreddels:master.

Coverage decreased (-0.3%) to 78.46% when pulling 827be3f741bac235d280f94b043dfa1b18f14bc4 on jeammimi:color into 65300b524c06d87c54c17dcb060722d9f5c4b2cb on maartenbreddels:master.

Coverage decreased (-0.3%) to 78.46% when pulling ded32bcb050f6422bb07f4368a86f0268f98bb7a on jeammimi:color into 65300b524c06d87c54c17dcb060722d9f5c4b2cb on maartenbreddels:master.

I'd like to do the deserialize of the color seperately, I think I'll take some of this code and refactor it, instead of merging it... I'll let you know.

Ok.
I did it that way  because now you can be in performance 1 all the time,
and It will send the array it can in a fast way, and the other in the regular way.
It works for color, as well as if you decide to send x with different number of point for different frame.
I modified the fact that you were forcing the conversion to float32.
I think it is important to keep the type of array the same type that is send
to the widget, because for example I was sending integer, to make the
embeded version lighter.
I was thinking trying to make the embeding work when the performance is set to 1, and also look
into how to save the data in a separate file.

Ok, sounds good. I'm working on the performance of create_mesh, since that is a bit slow, and difficult to maintain. For the embedding with performance = 1, I'm not sure you should attack that now. For the more general case, with performance = 2, there is quite some progress here: https://github.com/ipython/ipywidgets/pull/1194
I think by making use of the functions on the js side it will save quite some work, but maybe you can do the Python side?

I am sory,  I am not sure what you mean by

I think by making use of the functions on the js side it will save quite some work, but maybe you can do the Python side?

Have you made a comparison of performance 1 and 2 for the speed?

If you do from the menu in the notebook, Widget->Embed widget. This is the javascript side making a json serialization. If you do the ipyvolume.pylab.save, it is the python side doing the serialization.

I did a mayor refactor, but I think your changes are included, please check if everything is working as expected, so I can close this.

Make sure you run npm update btw, threejs required a new version.

Not everything was included, but I can create another pull request.
One thing does not work anymore:
Before I was able to send array of hexadecimal value for the color such as:
array(['#f00', '#ff0a00', '#ff1500', '#ff1f00', '#ff2900', '#ff3400'])
now It does not work anymore. The problem is that for numpy it is a u7 type,
that now is included in the performance 1 case but should not. I think we shourd keep the list
of known type as it is, and this one should be json serialised.
One "improvement" is missing :
I think when using the union in traitlest (for example for color and size) we should put the array before the unicode (for color) and array before float (for size). The reason is that it first try the unicode case, and if it can not convert it, send a representation of the object in a string (I guess it is for debugging purpose) doing the repr of a numpy array is ok because it is truncated, but if for some reason we send a list, it is going to do a repr of a list which could be 1000x1000x3 (It happend to me for the color because I did not convert it to a numpy array). And doing the repr of such a list can take 1-2 seconds.
So putting the array first get rid of this problem

Hmm, surprised by that, this line only allows for ints and floats, the rest should go as json (for performance == 1). Let me think about the order of the traitlets, I noticed it in the diff, but didn't think it was intentional.

For the traitlets this might convince you:
%timeit -n 1 p3.scatter(x=np.array([1,1]),y=np.array([1,1]),z=np.array([1,1]),\
                        size=1,color=np.random.rand(1000*1000*3).reshape(1000,1000,3))

1 loop, best of 3: 87.8 ms per loop
%timeit -n 1 p3.scatter(x=np.array([1,1]),y=np.array([1,1]),z=np.array([1,1]),\
                        size=1,color=np.random.rand(1000*1000*3).reshape(1000,1000,3).tolist())

1 loop, best of 3: 6.31 s per loop
The second one is very slow, and if you change the position of array, before unicode, you wont see this

For the first point , the line you are mentionning it allows all u element and the array I mentionned is
u7, and should not be fast serialized.

u is unsigned integer U is unicode, quite confusing, isn't it?
>>> a = np.array(['#f00', '#ff0a00', '#ff1500', '#ff1f00', '#ff2900', '#ff3400'])
>>> a.dtype, a.dtype.kind
(dtype('<U7'), 'U')

Thanks for the report on the Unicode(), it must be in the error handling code.

I think the same problem is true for size size_selected and color_selected.


Tests error: Issue with python3 compatibility, on zope interface implementation

Hi, I came across the following error after run python -m pytest tests/modeling_test.py
________________________________________________________________________________ ERROR collecting tests/modeling_test.py __________________________________________________________________________________
modeling_test.py:25: in
from pytorch_pretrained_bert import (BertConfig, BertModel, BertForMaskedLM,
/usr/local/lib/python3.6/site-packages/pytorch_pretrained_bert/init.py:7: in
from .modeling import (BertConfig, BertModel, BertForPreTraining,
/usr/local/lib/python3.6/site-packages/pytorch_pretrained_bert/modeling.py:218: in
from apex.normalization.fused_layer_norm import FusedLayerNorm as BertLayerNorm
/usr/local/lib/python3.6/site-packages/apex/init.py:18: in
from apex.interfaces import (ApexImplementation,
/usr/local/lib/python3.6/site-packages/apex/interfaces.py:10: in
class ApexImplementation(object):
/usr/local/lib/python3.6/site-packages/apex/interfaces.py:14: in ApexImplementation
implements(IApex)
/usr/local/lib/python3.6/site-packages/zope/interface/declarations.py:483: in implements
raise TypeError(_ADVICE_ERROR % 'implementer')
E   TypeError: Class advice impossible in Python3.  Use the @implementer class decorator instead.
My configurations are as follows:
python version 3.6.4
CUDA Version 8.0.61
torch==1.0.1.post2
apex==0.9.10.dev0
zope.interface==4.6.0
Thanks

any solution here?

This looks like an incompatibility between apex and zope.
Have you tried without installing apex?

This looks like an incompatibility between apex and zope.
Have you tried without installing apex?

I uninstalled apex, it works now!
Thank you so much!!!!


Save/load game

Description
The save/load game feature is a feature which is apart of mostly all games used to save progress of the user in the game. This is necessary for all games but for our game especially important as having to restart from day one would take a very long time. There will be multiple save files which will be able to save simple stuff as the coins, moral standing but also more complex stuff like inventories and customer positions.
Dependencies

Main and pause menu working

Milestones

[ ] #304
[ ] Create simple load game functionality (stores money, level, moral status) (Sep. 23)
[ ] Create more advanced load game functionality (stores item locations, customer locations) (Oct 1)
[ ] Create tests (Oct 2)
[ ] Create wiki (Oct 3)

Completion Deadline: Oct 3
Documentation
Members

Jackson Van Duikeren (aridspace10)

Make sure you add it to the project


Socket: i/o timeout and bind: already in use

I switched to running the exporter in the same container as the chronyd server. I'm scraping it every 60s.
What I am seeing:
time=2024-11-04T18:43:46.590Z level=DEBUG source=collector.go:149 msg="Scrape completed" scrape_id=40 seconds=0.004325332
time=2024-11-04T18:44:21.389Z level=DEBUG source=collector.go:146 msg="Scrape starting" scrape_id=41
time=2024-11-04T18:44:21.389Z level=DEBUG source=collector.go:146 msg="Scrape starting" scrape_id=42
time=2024-11-04T18:44:21.389Z level=DEBUG source=collector.go:155 msg="Couldn't connect to chrony" scrape_id=42 address=unix:///run/chrony/chronyd.sock err="dial unixgram /run/chrony/chrony_exporter.7.sock->/run/chrony/chronyd.sock: bind: address already in use"
time=2024-11-04T18:44:21.389Z level=DEBUG source=collector.go:149 msg="Scrape completed" scrape_id=42 seconds=9.6575e-05
time=2024-11-04T18:44:21.389Z level=DEBUG source=tracking.go:176 msg="Got 'tracking' response" scrape_id=41 tracking_packet=SUCCESS
time=2024-11-04T18:44:21.390Z level=DEBUG source=collector.go:191 msg="DNS lookup took" scrape_id=41 seconds=0.000999318
time=2024-11-04T18:44:21.390Z level=DEBUG source=tracking.go:186 msg="Tracking Last Offset" scrape_id=41 offset=0.00017267093062400818
time=2024-11-04T18:44:21.390Z level=DEBUG source=tracking.go:189 msg="Tracking Ref Time" scrape_id=41 ref_time=2024-11-04T18:43:30.632Z
time=2024-11-04T18:44:21.390Z level=DEBUG source=tracking.go:192 msg="Tracking System Time" scrape_id=41 system_time=-0.0014299183385446668
time=2024-11-04T18:44:21.390Z level=DEBUG source=tracking.go:199 msg="Tracking is remote" scrape_id=41 bool_value=1
time=2024-11-04T18:44:21.390Z level=DEBUG source=tracking.go:202 msg="Tracking RMS Offset" scrape_id=41 rms_offset=0.0017726216465234756
time=2024-11-04T18:44:21.390Z level=DEBUG source=tracking.go:205 msg="Tracking Root delay" scrape_id=41 root_delay=0.0168450977653265
time=2024-11-04T18:44:21.390Z level=DEBUG source=tracking.go:208 msg="Tracking Root dispersion" scrape_id=41 root_dispersion=0.0026964773423969746
time=2024-11-04T18:44:21.390Z level=DEBUG source=tracking.go:211 msg="Tracking Frequency" scrape_id=41 frequency=-0.6470763087272644
time=2024-11-04T18:44:21.390Z level=DEBUG source=tracking.go:214 msg="Tracking Residual Frequency" scrape_id=41 residual_frequency=0.017963755875825882
time=2024-11-04T18:44:21.391Z level=DEBUG source=tracking.go:217 msg="Tracking Skew" scrape_id=41 skew=1.2864940166473389
time=2024-11-04T18:44:21.391Z level=DEBUG source=tracking.go:220 msg="Tracking Last Update Interval" scrape_id=41 update_interval=65.0595703125
time=2024-11-04T18:44:21.391Z level=DEBUG source=tracking.go:223 msg="Tracking Stratum" scrape_id=41 stratum=2
time=2024-11-04T18:44:26.393Z level=DEBUG source=collector.go:182 msg="Couldn't get serverstats" scrape_id=41 err="read unixgram /run/chrony/chrony_exporter.7.sock->/run/chrony/chronyd.sock: i/o timeout"
time=2024-11-04T18:44:26.394Z level=DEBUG source=collector.go:149 msg="Scrape completed" scrape_id=41 seconds=5.005050362
time=2024-11-04T18:44:46.586Z level=DEBUG source=collector.go:146 msg="Scrape starting" scrape_id=43

It works sometimes though. Any idea what could be the issue?

Important note:
/usr/bin/chrony_exporter --chrony.address="unix:///run/chrony/chronyd.sock" --log.level=debug --collector.serverstats --collector.chmod-socket

I also set the timeout to 30s and still getting the same errors

I figured out what was going on with the bind: already in use issue. No need to look further here. Though a caching layer would be helpful here. We have 2 scrapers running and the 2nd request fails with this.
But the I/O is happening randomly (more persistently). Some calls work within a second, while others will get tracking and then timeout on getting serverstats and some will simple fail to get both within the timeout. I have the timeout set to 30s (previously 5s) and at that duration completion, it shows this error.
Maybe this is a issue with chronyd resources?


Clearer information for the timer

Would be amazing to have a tooltip that says whether the timer box in the mod settings counts in seconds or minutes

It's in ticks, adding it to the tooltip in the next update.


Disable regex routing by default

Still looking for a way to allow configuration on a per-path basis.

@Playacem do you want to merge this now?

We can merge this for now. Disadvantage: No more regex paths.

I think that's okay, we can still reintroduce them with a config option or a new syntax later. Thanks!

Hey Javalin/GitHub Community,
for a project I wanted to use regex paths and had a bit of struggle to find a way to do it.
I had a directory files in my staticFiles configuration and wanted to create a fallback route (for reasons beyond this post)
for any request not pointing to /files/ using the route * would resolve into /+.?/ afaik. and thus overwrite it.
I ended up creating a specific route that after starting Javalin I could Match and modify its regex. Sadly both PathParser.kt and HandlerEntry are final so I had to resort to this solution. Big +1 from my side to add optional regex parameters or entire paths.
Code can be found here: https://gist.github.com/Marco-Dittrich-mk-esthetics-med/fbc895693d2d9944841b0d6b27b0623f

The best way to handle complex routes is to simply write your own subrouter to properly redirect those requests programmatically to your other handlers. Also, keep in mind that requests are matched in registration order, it means that:
/* - Route A
/files/* - Route B

will match route A for any request (/abc/, /files/), but this:
/files/* - Route B
/* - Route A

will match all /files/ requests with route B, and the rest of them with route A.


RTSP Streaming stopped when the Activity is in background (onPaused, onStop)

Hello, we developed a streaming app using this library, using the rtsp protocol and our server is on wowza, the streaming running ok until we want to share the stream, because the activity is in background when the share dialog appear, the stream stopped (onDisconnectRtsp() callback method called), how can i keep the stream running? Thank you in advance

This is related with preview lifecycle. If you want stream in background you need do it without preview with this constructors:
-Camera1:
https://github.com/pedroSG94/rtmp-rtsp-stream-client-java/blob/master/rtplibrary/src/main/java/com/pedro/rtplibrary/base/Camera1Base.java#L95
-Camera2:
https://github.com/pedroSG94/rtmp-rtsp-stream-client-java/blob/master/rtplibrary/src/main/java/com/pedro/rtplibrary/base/Camera2Base.java#L88
Remember that you should use it in a service to keep stream alive.
If you want to use preview while you are in foreground and keep stream in background. There isnt specific way to do it but you can try with this solution::
https://github.com/pedroSG94/rtmp-rtsp-stream-client-java/issues/318

ok, I'll try, thanks for your answer

hello, I've implemented the service using intentservice and service, but i got the same result, when i minimize the app, the disconnected callback doesnt called, but the stream when blank, how to solve it?

the problem when the activity is in background is the socket is closed, it there any way to keep it open and keep the connection to the server alive? I already start the stream in a service

Hi,
Are you using a background stream object without preview? (camera2 or camera1 with context, display mode or fromfile mode).
Remember allow background use if your device is Android 8.0+
I will create an example today with camera2.

Test my new activity example:
https://github.com/pedroSG94/rtmp-rtsp-stream-client-java/tree/master/app/src/main/java/com/pedro/rtpstreamer/backgroundexample

Hello,
Yeah I use stream without preview, I used the preview feature before, but now I remove it, btw I'm using OpenGlView that you provided and used Camera1, but I already tried both, I use rtsp endpoint and the server is in wowza.
I use real device with API 23 (Android 6.0 Marshmallow) for testing.
Thanks for your example, I already implemented that kind of service, I've tried using IntentService and Foreground service, just now I tried your example and implemented it in my app, but it still give blank streaming, or the stream is stopped. It seems the service is still running just fine, but the streaming it self stopped, and the method for disconnected is not called.
Any idea whats happen Sir?

Hi, I just try your example in your own app example, and what do you mean by no preview is the camera not showing the streaming progress? which is not live streaming here? So, it doesn't support live streaming then? Because in my case the stream server is still running when using service but the live streaming progress is terminated.


[uQ] What is the difference between https://github.com/pkgforge/soar?

What is the difference between https://github.com/pkgforge/soar?

What is the difference between https://github.com/pkgforge/soar?

Soar does too much stuff for my liking, give it a try if you'd like I guess?
It does everything dbin does, but it has other stuff too (couldn't really say what that stuff is since soar is still WIP and the dev has been adding a lot of stuff, not all of which is documented. Currently, his pal, Ajam, is writting the docs for their infra and updating the soar cli docs too)

LGTM，I will try https://github.com/xplshn/dbin
dbin uses Golang, I am more familiar with it

LGTM，I will try https://github.com/xplshn/dbin
dbin uses Golang, I am more familiar with it

If you're a Go dev, you're welcome to help with implementing a version of install.go/fetch.go that uses a parallel progressbar library for prettier output, I could not figure that out with https://github.com/hedzr/progressbar, the library behaved weirdly each time I tried to use it

如果您是 Go 开发人员，欢迎您帮助实现 install.go/fetch.go 版本，该版本使用并行进度条库来获得更漂亮的输出，我无法通过https://github.com弄清楚这一点/hedzr/progressbar ，每次我尝试使用它时，库都表现得很奇怪

@xplshn What is the ultimate desired effect?

To have pretty progressbars when installing binaries, like those of Pacman (Arch's package manager)
by the way, if English isn't your native tongue, consider using a translator like "deepl", its pretty good

Lovely, thanks very much!

@xplshn https://github.com/xplshn/dbin/pull/13

Hi, @akkuman
If you use telegram, come hang out with Us (@xplshn & rest of @pkgforge) at https://t.me/official_loonix/63954

@Azathothas I will join this group.


[Bug] Buffer overflow when instancing 14563 PackedScene.

Operating system or device - Godot version:
Linux - Ubuntu Mate 16.10 - Godot 2.1.2 stable
Issue description:
I was facing an over usage of RAM with my Godot 2D game prototype, and I decided to find the cause of it. I wanted to see how many PackedScene instance Godot could handle without blowing out my RAM.
I built a main scene with a simple architecture:
---> Node // Script attached  here
       +----> YSort

I built also a scene called "Hexa.tscn", with a simple architecture too:
---> Area2D
       +-----> Sprite

In a script attached to the root node of the main scene I try to add as much "Hexa" scene instance as possible in the YSort Node.
If I add 14562 Hexa scene instances, everything goes well (~3% usage of 1 CPU, ~115Mo RAM usage, that represents: 29655 Objects, 3 Resources, 29127 Nodes)
But if I add 14563 Hexa scene instances, I encounter a buffer overflow error, as follow:
In the Error tab of the debugger:
Type: Error
Description:
Time: 0:00:00:0458
C Error: Condition '(buffer_end+room_needed) >= buffer_size' is true. returned ERR_OUT_OF_MEMORY
C Source: core/message_queue.ccp:54
C function: push_call

In the Output tab of the debugger:
failed method: Sprite:_update_callback target ID: 29681
TOTAL BYTES: 1048560
NULL count: 0
CALL _sort_children: 14564
CALL_update_callback: 29126

Is this a bug ?
Steps to reproduce:
Run  the attached Godot project in Godot editor to see the error in the debugger.
Link to minimal example project:
memtest.tar.gz

You want to increase the maximum size of the message queue in:
project settings -> core -> message_queue_size_kb
to something higher.
I would in any case avoid creating so many nodes for performance reasons.

Hi @Faless !
I am glad to know that this issue is apparently not a bug, but just a misconfiguration of a setting on my part.
Thanks for you for the enlightment :)
Could it be interresting to improve the error message, in order to inform the user about this message_queue_size_kb setting tuning ?

I would like to inform you that in Godot 3.1 Alpha 2 the error message is even worst:

It took me quite some time to realize that I reached the limits of the message queue.


Do not assume argon2 based hashes

The extractArgon2ParametersFromEncodedPassword assumes argon2 based hashes and hence fails with an "Index out of bound" exception if the hash does not include a $ sign. The introduced test checks this assumption to short cut testing the policy. If the stored hash is not an argon2-hash than the policy is violated and a rehash is required.
see #3

@RobertHeim code changes look good, just tested this and Keycloak is now able to migrate to this hashing algorithm transparently as expected, thanks!


🐛  takePhoto() function working very slowly on Android

What's happening?
Using: const photo = await cameraRef.current?.takePhoto() and pressing the photo button will take about 3-4 seconds before the photo is being shown. You have enough time to click on the take photo button again.
On the Reproduceable Code, the console logs are about 3-4 seconds apart.
I tried just taking a photo with the example app and get this:
ERROR  Failed to take photo! [unknown/unknown: Capture request failed with reason ERROR]
With my front-camera it seemed to work but with back camera I get this error ^
Front-camera also took a while to load up.
Reproduceable Code
import { Camera as VisionCamera } from 'react-native-vision-camera'

const cameraRef = useRef<VisionCamera>(null)

console.log('takePhoto')
const photo = await cameraRef.current?.takePhoto()
console.log('photo', photo)

Relevant log output
-

Camera Device
{
  "formats": [],
  "sensorOrientation": "landscape-left",
  "hardwareLevel": "full",
  "maxZoom": 10,
  "minZoom": 1,
  "maxExposure": 18,
  "supportsLowLightBoost": false,
  "neutralZoom": 1,
  "physicalDevices": [
    "wide-angle-camera"
  ],
  "supportsFocus": true,
  "supportsRawCapture": false,
  "isMultiCam": false,
  "minFocusDistance": 10,
  "minExposure": -18,
  "name": "2 (BACK) androidx.camera.camera2",
  "hasFlash": true,
  "hasTorch": true,
  "position": "back",
  "id": "2"
}

Device
One Plus 12R
VisionCamera Version
4.0.5
Can you reproduce this issue in the VisionCamera Example app?
Yes, I can reproduce the same issue in the Example app here
Additional information

[ ] I am using Expo
[ ] I have enabled Frame Processors (react-native-worklets-core)
[X] I have read the Troubleshooting Guide
[X] I agree to follow this project's Code of Conduct
[X] I searched for similar issues in this repository and found none.

I have the same issue - on Realme it takes up to 8 sec. Any ideas how to fix it would be really appreciated

Setting photoQualityBalance="speed" is the fastest way to capture photos.
Maybe also choose a format with lower photo resolution if you want faster captures.
Other than that, this is what Android gives me. My API is extremely fast and it's up to Android to implement improvements on the Camera layer.

I've set the photoQualityBalance="speed" already as well, that didn't work here. I haven't tested the format yet, will have a look at those.
If those don't seem to do any difference in speed, I will check the logs and send them here.


Add Point property for mapping point datatype

Relates: #4718, elastic/elasticsearch#53804
This commit adds a Point property to map the new point data type.
A CartesianPoint type is introduced to model points.

The new point datatype can be used in shape queries. Shape queries however are bound to IGeoShape
https://github.com/elastic/elasticsearch-net/blob/f1ffbf260132eb83ea4e7950c1bcf19ef679ee6f/src/Nest/QueryDsl/Specialized/Shape/IShapeQuery.cs#L34-L38
which CartesianPoint does not implement. Think we may need to introduce new shape types here

After conversation with the geo team, it's clarified some questions around CartesianPoint:
CartesianPoint can be used for the null_value of a Point property field mapping, and allow users to use it on their documents to index into the Point field. To query on a Point field using the shape query, the PointGeoShape type can be used.
Another type (CartesianPoint) needs to be introduced because of the formats that must be supported for both the null_value of Point field mappings, and also for formats that may be used on _source documents outside of the client that the client must be able to deserialize:

Object: { "x": 41.12, "y": -71.34 }
String: "41.12,-71.34"
Array: [41.12,-71.34]
WKT: POINT (41.12 -71.34)

This PR has been rebased against master and is ready for review, @Mpdreamz.
I think we should seriously consider renaming IGeoShape to IGeometry in 8.x, and the shape types that implement IGeoShape to remove the Geo name part. The renames better reflect their intent and usage, though I do appreciate that such a change could be a reasonably large breaking change, as geo queries are popular.

Merging this one in; last test run was green and this test run fails with tests unrelated to the changes.


Implement registering Runtimes in Compass Director

Implement code that will register Runtime in the director.
Acceptance criteria:

[ ] Compass Manager is able to make authorised calls to the Compass Director API
[ ] Compass Manager registers new Runtime when Kyma CR contains a new kubeconfig
[ ] It must be assumed that Compass may be temporarily unavailable. We must provide resilience mechanisms, and eventual consistency.
[ ] Compass Manager unregisters Runtime when Kyma CR is removed.

We must consider how to store RuntimeID returned by the Compass API to be able to unregister the Runtime at some point.

Workplan

[ ] Establish an authorised connection between Compass Manager and Compass Director
[ ] Test the connection by retrieving a runtime from Director
[ ] Implement a logic that will register new runtime in Director (re-use the core functionality from Provisioner)
[ ] Provide resilience mechanisms for queries executed to Director

Blocked

[ ] Implement a logic that will unregister runtime from Director (blocked by #9)

We also need to have in mind that we must implement SetRuntimeStatusCondition() to mark the runtime in Director as Connected (now the status is permanent in Initial state)

Workplan

[x] registration of the Runtime in Compass Director https://github.com/kyma-project/compass-manager/pull/18
[ ] Compass Manager creates an CompassMapping CR + Whitesource https://github.com/kyma-project/compass-manager/pull/27
[ ] Compass Manager should mark the runtime in Director as Connected
[ ] deregistration of the Runtime while Kyma CR was deleted
[ ] CompassMapping CR custom statuses and finalizers
[ ] RBAC for CompassMapping CR, align with SRE

High level requirements
The operator must be able to operate in the following conditions:

Provisioner is not responsible for Compass integration (target architecture)
Provisioner registers runtime, and Compass Manager creates CRA's secret (intermediary architecture)
Runtime is removed, and recreated (trial suspension scenario)

The following requirements must be met:

If the Application Connector module is disabled, the event is filtered out.
If the Application Connector module is enabled, there are two options:

If runtime is not registered yet, operator performs the following operations:

Registers runtime
Fetches one-time token from the Compass Director
Creates config secret for the Compass Runtime Agent
Stores information in the KCP cluster determining if the runtime is registered

If runtime is already registered, operator performs the following actions:

Fetches one-time token from the Compass Director.
Updates config secret for the Compass Runtime Agent

Compass Manager will retry operations in case of failures. Compass Manager Mapping must contain status information to improve observability.
The following requirements must be met:

If the Compass Manager failed to register runtime the CR must have failed status.
If the Compass Manager successfully registered runtime the CR must contain kyma-project.io/compass-runtime-id annotation.
If the Compass Manager failed to create secret CR must set failed status.

It would give better insight into the system, and allow to see:

When runtime was registered, and configuration secret created.
The failure rate of Compass operations.

Done, the core flow (registering, unregistering) creatin CompassMapping, statuses and finalizers are implemented.


[BUG] longhorn-csi-plugin and longhorn-ui fail on new worker node added in cluster

Describe the bug
longhorn-csi-plugin and longhorn-ui stuck in crashloop, if one of the worker node is terminated and a new worker node is added.
To Reproduce
Steps to reproduce the behavior:

Create a custom cluster with ASG EC2 nodes for worker (1 - etcd/control, 3 - workers)
Create a volume(3 replicas) and attach to a pod.
Terminate the worker node where pod is running in aws console. (In my setup 'longhorn-ui' and user created pod was running on same node.) ASG will recreate node with same config.
'longhorn-csi-plugin and longhorn-ui' stuck get stuck in crashloop error on the new node.

Expected behavior
longhorn-csi-plugin and longhorn-ui should start healthy pod on new node.
Log
> kubectl logs longhorn-csi-plugin-hd5qj longhorn-csi-plugin -n longhorn-system
time="2020-05-05T19:06:47Z" level=info msg="CSI Driver: driver.longhorn.io csiVersion: 0.3.0"
time="2020-05-05T19:06:57Z" level=fatal msg="Error starting CSI manager: Failed to initialize Longhorn API client: Get \"http://longhorn-backend:9500/v1\": context deadline exceeded (Client.Timeout exceeded while awaiting headers)"
> kubectl logs longhorn-ui-55bd8cbfd9-hp96h -n longhorn-system
2020/05/05 19:19:39 [warn] 1#1: duplicate MIME type "text/html" in /etc/nginx/nginx.conf:7
nginx: [warn] duplicate MIME type "text/html" in /etc/nginx/nginx.conf:7
2020/05/05 19:19:39 [emerg] 1#1: host not found in upstream "longhorn-backend" in /etc/nginx/nginx.conf:32
nginx: [emerg] host not found in upstream "longhorn-backend" in /etc/nginx/nginx.conf:32

kubelet logs:
W0505 21:07:19.966603    5165 kubelet_pods.go:861] Unable to retrieve pull secret longhorn-system/ for longhorn-system/longhorn-csi-plugin-hd5qj due to secret "" not found.  The image pull may not succeed.
E0505 21:07:19.967598    5165 pod_workers.go:191] Error syncing pod 30c6fe56-e3f0-4b9a-9081-6bda32aaca80 ("longhorn-csi-plugin-hd5qj_longhorn-system(30c6fe56-e3f0-4b9a-9081-6bda32aaca80)"), skipping: [failed to "StartContainer" for "longhorn-csi-plugin" with CrashLoopBackOff: "back-off 5m0s restarting failed container=longhorn-csi-plugin pod=longhorn-csi-plugin-hd5qj_longhorn-system(30c6fe56-e3f0-4b9a-9081-6bda32aaca80)", failed to "StartContainer" for "compatible-longhorn-csi-plugin" with CrashLoopBackOff: "back-off 5m0s restarting failed container=compatible-longhorn-csi-plugin pod=longhorn-csi-plugin-hd5qj_longhorn-system(30c6fe56-e3f0-4b9a-9081-6bda32aaca80)"]

Environment:

Longhorn version: master - 05-04-2020
Kubernetes version: v1.17.5 rancher1-3
Node OS type and version: ubuntu 18.04 aws node

The real reason is

Error starting CSI manager: Failed to initialize Longhorn API client: Get "http://longhorn-backend:9500/v1\": context deadline exceeded (Client.Timeout exceeded while awaiting headers)

Somehow some of the CSI plugins and UI cannot connect to the longhorn-backend service in this cluster.

DNS resolution failed.
longhorn-backend service cannot be reached, but its cluster IP can be reached.

> k -n kube-system get pod -o wide
NAME                                      READY   STATUS      RESTARTS   AGE     IP              NODE               NOMINATED NODE   READINESS GATES
canal-6d457                               2/2     Running     0          5h1m    <IP_ADDRESS>   ip-172-31-34-172   <none>           <none>
canal-6j7d6                               2/2     Running     0          4h23m   <IP_ADDRESS>    ip-172-31-8-106    <none>           <none>
canal-fzkjp                               2/2     Running     0          3h59m   <IP_ADDRESS>   ip-172-31-25-241   <none>           <none>
canal-kqr98                               2/2     Running     0          5h4m    <IP_ADDRESS>    ip-172-31-4-117    <none>           <none>
canal-sgg6k                               2/2     Running     0          5h1m    <IP_ADDRESS>   ip-172-31-22-235   <none>           <none>
canal-vrsz6                               2/2     Running     0          3h52m   <IP_ADDRESS>    ip-172-31-35-12    <none>           <none>
coredns-7c5566588d-c52hb                  1/1     Running     0          5h4m    <IP_ADDRESS>       ip-172-31-22-235   <none>           <none>
coredns-7c5566588d-khm5g                  1/1     Running     0          5h      <IP_ADDRESS>       ip-172-31-34-172   <none>           <none>
coredns-autoscaler-65bfc8d47d-t7wzv       1/1     Running     0          5h4m    <IP_ADDRESS>       ip-172-31-22-235   <none>           <none>
metrics-server-6b55c64f86-7dfzr           1/1     Running     0          5h4m    <IP_ADDRESS>       ip-172-31-22-235   <none>           <none>
rke-coredns-addon-deploy-job-xkp46        0/1     Completed   0          5h4m    <IP_ADDRESS>    ip-172-31-4-117    <none>           <none>
rke-ingress-controller-deploy-job-5w82z   0/1     Completed   0          5h4m    <IP_ADDRESS>    ip-172-31-4-117    <none>           <none>
rke-metrics-addon-deploy-job-z5wck        0/1     Completed   0          5h4m    <IP_ADDRESS>    ip-172-31-4-117    <none>           <none>
rke-network-plugin-deploy-job-txkzp       0/1     Completed   0          5h4m    <IP_ADDRESS>    ip-172-31-4-117    <none>           <none>

> k -n kube-system get deployment
NAME                 READY   UP-TO-DATE   AVAILABLE   AGE
coredns              0/2     2            0           5h6m
coredns-autoscaler   0/1     1            0           5h6m
metrics-server       0/1     1            0           5h6m

The reason is the coredns pods are all on the down nodes: ip-172-31-22-235 and ip-172-31-34-172. Not sure why the deployment wasn't moved to other nodes.

Seems due to https://github.com/rancher/rancher/issues/26190


Your proxies are dead. RoPro have also changed their methods.

They have an activateKey function in RoPro/js/page/options.js with the API link hardcoded. Proxies were kind of a far-fetch to begin with.

Feel free to modify the patcher to work properly then create a PR. I don't have the time at the moment to work on this.

Hi, I decided to take the easy route and change the function to a basic if (true) subscription is valid.

You don't need to make your own proxy or maintain it. There's a separate branch that already has the proxy done.

It seems to be working just fine for me.

You don't need to make your own proxy or maintain it. There's a separate branch that already has the proxy done.

Hey I just stumble across this, I used the GUI and it downloaded properly, the only thing is things like server region and uptime say UNKNOWN, is this an issue with proxies I am able to fix?

It could be that. It also could be that the account that was being used no longer has rex

is this going to be fixed soon?

Not any time soon by me, I don't have the time nor dedication to maintain this. The only reason I haven't archived is to allow the possibility for someone else to fix.


Ghost Text Not Working

Setup
Browser: Google Chrome
Editor: Sublime Text 4
Description
open not working it showing connected and opens automatically Sublime without text textarea in sublime text

It works. I'd need more information than "not working"

When i run GhostText in Chrome then Sublime Editor Open's but not open's the textarea, opened only Blank Sublime Editor or open's disconnected page Contents.

https://ghosttext.fregante.com/troubleshooting/

I Tried, not helpful this Troubleshooting.


Are there any plans to merge with ckjm_ext?

There is ckjm_ext https://github.com/mjureczko/CKJM-extended / http://gromit.iiar.pwr.wroc.pl/p_inf/ckjm/down.html often used in papers and some of its features are very useful: LOC calculation for example. Are there any plans to merge both tools? I'd like to help if there are such plans/desire.
Thanks.

Thank you for the suggestion!  I think that ckjm_ext offers considerable new functionality, so it should be used if somebody requires it.  Can you please outline the benefits of merging?  What improvements would you like to see as a result over what currently available?


Immersive Portals is incompatible with anything before sodium 0.4.1 even though i have 0.4.2 and crashes

hello all
i have this error where i can play even though i have everything correct
Incompatible mod set!
net.fabricmc.loader.impl.FormattedException: Mod resolution encountered an incompatible mod set!
A potential solution has been determined:
- Replace mod 'LambDynamicLights' (lambdynlights) 2.1.2+1.19 with any version that is compatible with:
- fabric 0.55.2+1.19
- Replace mod 'Immersive Portals' (immersive_portals) 2.0.0 with any version that is compatible with:
- sodium 0.4.2+build.16
Unmet dependency listing:
- Mod 'Immersive Portals' (immersive_portals) 2.0.0 is incompatible with any version before 0.4.1+build.15 or any version after 0.4.1+build.15 of mod 'Sodium' (sodium), but a matching version is present: 0.4.2+build.16!
- Mod 'LambDynamicLights' (lambdynlights) 2.1.2+1.19 requires version 0.55.3+1.19 or later of mod 'Fabric API' (fabric), but only the wrong version is present: 0.55.2+1.19!
at net.fabricmc.loader.impl.FabricLoaderImpl.load(FabricLoaderImpl.java:190)
at net.fabricmc.loader.impl.launch.knot.Knot.init(Knot.java:148)
at net.fabricmc.loader.impl.launch.knot.Knot.launch(Knot.java:68)
at net.fabricmc.loader.impl.launch.knot.KnotClient.main(KnotClient.java:23)
here is the error

It says "or any version after 0.4.1+build.15 of mod 'Sodium' (sodium)". 2.0.0 is not yet compatible with sodium
2.0.0 is not yet stable and only published for testing


feat(react/tabs) implemented tabs component in react

A working first version of tabs component, improvements still needed.

click on tab causing the tab component out of storybook
so far, only richtext and image are recognized in tabs, if more components need to be embedded, the code needs to be updated

Hey @wc-lei is this ready for review or is it still a WIP?

Hey @wc-lei what do you think of this feedback ☝

Hey @Shashika6, awesome if you could pick this one up

Will do @just intemps

@justintemps This one is ready now made the changes based on feedback


Update OK_ICON weight to match FAIL_ICON

Fixes #576.

Thanks, @giogziro95! Even the little things matter, and this is great.
Welcome to P9k =)


Provide AddSqlServerDbContextFactory method for  Aspire.Microsoft.EntityFrameworkCore.SqlServer

The recommendation for Blazor web applications is to use AddDBContextFactory to handle the lifetime of the DBContext, I believe Aspire.Microsoft.EntityFrameworkCore.SqlServer should also provide that method to support that recommendation.
PD: Amazing tech

@eerhardt PTAL

You can use any EF API to add your DbContext as normal, and then use the EnrichXDbContext method to add the Aspire specific capabilities to it.
Take a look at

https://github.com/dotnet/aspire/issues/1403
https://github.com/dotnet/aspire/tree/main/src/Components/Aspire.Microsoft.EntityFrameworkCore.SqlServer#usage-example

You might also need to configure specific option of Sql Server, or register a DbContext in other ways. In this case call the EnrichSqlServerDbContext extension method, for example:

var connectionString = builder.Configuration.GetConnectionString("catalogdb");
builder.Services.AddDbContextPool<CatalogDbContext>(dbContextOptionsBuilder => dbContextOptionsBuilder.UseSqlServer(connectionString));
builder.EnrichSqlServerDbContext<CatalogDbContext>();

@sebastienros @IEvangelist - I don't see any information about the Enrich APIs at https://learn.microsoft.com/en-us/dotnet/aspire/database/sql-server-entity-framework-component. Should we add something there?


Mac App Localhost requests are denied

Currently I use the chrome extension which works great. However, after downloading the desktop app and using the same url "http://localhost/api/graphql" I get server error. Do you have any idea why this would happen.
I'm using macOS sierra 10.12.6 - 2015 Macbook Pro.

Really? Can you open the dev console and check the errors there? Also take a screenshot and paste it here.

How do I open the dev tools on desktop app?
I can successfully query from browser extension.

Clicking Show Docs link returns "Server Error"

The server side shows this log. Which i'm confused about i would imagine the server would not be pinged at all but it is. Is the desktop app is making POST requests?

@beatscode Yes the app makes a POST request. That's a bit strange though since the mac app pretty much does the same thing.
Could you come on gitter: https://gitter.im/altair-graphql/Lobby ?

@beatscode Also you could open the dev tools using: Cmd + option + I

I logged into gitter. I tried the cmd+Option+i on the desktop app and nothing appeared.

@beatscode Can you check the difference between sending the request from the mac app and the chrome extension in your server logs?

@beatscode There is a new mac app release. This new version enables the dev tools menu, as well as a host of other ones. You can verify if this issue still persists in the new one. I'm closing this issue for now. If the issue persists, you can reopen the issue.

The request method type is altair://applications. Not sure how to handle that method type server side. I'll do some digging


put license in files that will be copied into other repros

To fix issue https://github.com/Microsoft/vs-dockerfiles/issues/2
@heaths

Updated Contributing.md


⚠ Samsung has degraded performance

In bae5941, Samsung (https://samsung.com) experienced degraded performance:

HTTP code: 200
Response time: 2229 ms

Resolved: Samsung performance has improved in cfbb5ae.


Logo change Aurorium token

I'm submitting a ...
[ ] bug report
[x] feature request
[ ] question about the decisions made in the repository
[ ] question about how to use this project

Summary
We decided to change our Aurorium token logo. here is the PR. please merge my changes. Thanks
https://github.com/solana-labs/token-list/pull/12325

Other information (e.g. detailed explanation, stack traces, related issues, suggestions how to fix, links for us to have context, eg. StackOverflow, personal fork, etc.)

merged


Apispec

@matthidinger,
Thanks for your contribution as a Microsoft full-time employee or intern. You do not need to sign a CLA.
Thanks,
Microsoft Pull Request Bot


prisma-proxy-fetch-client

The version 0.0.8 has a small problem and is not working. The package published on NPM for this release has the index.js file, but the package.json is reading the index.min.js, so the library is not initialized.
--
Another issue: sometimes Prisma returns undefined and the library throws an error. Maybe it's better to fix it to not throw error with undefined because that's normal during everyday use.
      try {
         // null is a valid prisma response for some queries
-        return text === null ? text : JSON.parse(text);
+        return text && JSON.parse(text);
       } catch (e) {

--
It would be nice to have a fix. By the way, cool project, it's helping me build a template with Cloudflare Workers. Very thanks! :)

Thanks, @mkuchak, for digging in. Your fork looks good to me if you want to make a PR from that.

Hey! I redid the PR only with the necessary changes for the correct functioning of the two libraries.
prisma-proxy-express-server also has a little problem sending the response which should be in JSON.
     ][prismaAction];
-    prismaFunc(prismaArgs).then((data: any) => res.send(data));
+    prismaFunc(prismaArgs).then((data: any) => res.json(data));
   });

As it currently stands some ORM calls like const totalUsers = await prisma.user.count() don't work.
With PR everything should work correctly.

Great work, looks good to me! Thanks for taking the time to use the library and discover some edge cases I hadn't considered.

published in 0.0.9


[BUG] DeleteRules.DELETE_LINKS is not working?

Describe the bug
DeleteRules.DELETE_LINKS is not working. Delete a document success but all linked document didn't
To Reproduce
import asyncio
from typing import Optional

from beanie import BackLink, Document, Link, init_beanie
from beanie.odm.utils.encoder import Encoder
from motor.motor_asyncio import AsyncIOMotorClient
from pydantic import Field

from beanie import DeleteRules, WriteRules

class Person(Document):
    name: str
    age: int
    cars: list[Link["Car"]] = Field(default_factory=list)

class Car(Document):
    manufacturer: str
    price: float
    owner: Optional[BackLink[Person]] = Field(default=None, original_field="cars")

async def init():
    client = AsyncIOMotorClient(
        "mongodb://localhost:27017",
    )

    await init_beanie(database=client.test_db, document_models=[Person, Car])

    p1 = Person(
        name="John",
        age=25,
    )
    p1.cars = [
        Car(manufacturer="Toyota", price=10000),
        Car(manufacturer="BMW", price=20000)
    ]
    await p1.save(link_rule=WriteRules.WRITE)
    # The above code runs fine

    person = await Person.find_one(Person.name == "John")
    print(person)

    # Only person document is deleted, cars didn't
    await person.delete(link_rule=DeleteRules.DELETE_LINKS)

asyncio.run(init())

Expected behavior

Document and all linked document will be deleted

Additional context

Maybe I misunderstood how it works. Can you explain it?

Hi ! did you check our car document and if something change inside ? For me ( and maybe i didn't understand) the delete rule just delete the link and not the document. So if you delete the car document, the field cars inside your car document should set to null... Someone can confirm that ?

The import method is not correct. Try it like this:
from beanie.odm.fields import DeleteRules


Crashing while deploying to Android Emulator

I have cloned and trying to run in android emulator after required config, but it's crashing on launch;
System.NullReferenceException: 'The current Activity can not be detected. Ensure that you have called Init in your Activity or Application class.'

Hi @sattasundar, I have implemented the respective location permissions. Don't forget to also add the Sentry DSN and generate the OpenWeather API key, the steps are in the README.


fix: update contributing guide

Signed-off-by: 梅佳奕<EMAIL_ADDRESS>

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

LGTM. Thank you @Wence-May
/approve


Barcode scanner when scanned second time (on the example) shows Cancelled

I am testing this barcode scanner for my own purpose. Even through Dev App, the barcode scanner once scanned, shows the scanned text. When  scan again another bar code, the result shows 'Scan cancelled'.
Some inherent issue?

If this is on Android only try using tabris nightly. They retooled the callbacks for a very specific workflow that this plugin may be using.

We are seeing a problem with the plugin in the latest nightly and will investigate. When using 1.9 the plugin should work.

Which versions of Tabris.js and Barcode Scanner?  Barcode scanner has been flakes in the last few versions: #841

@natanraj What version of Barcode Scanner, not Cordova (in fact you don't even need to install Cordova).  It's specified in cordova/config.xml.  Or if you aren't specifying a version you'll get the latest, which is currently 6.0.1.

Some update on the barcode scanner plugin:
With the update to cordova-android 5.2.2 they have fixed a bug that allowed us enforce the min sdk version to be 16. This means that the barcode scanner plugin that wants to enforce min sdk version 15 can now be overruled. So phonegap-plugin-barcodescanner (6.0.2) is the one that should be used (and will be used in the Tabris.js developer app).
In addition we have fixed a bug in the tabris integration with the cordova-android platform  where the request codes were not handled correctly. (illegal request code range used by plugins, http://stackoverflow.com/a/33332468/271877)

We have reports of successful scans so i am closing this issue.


Scale argument should be none instead of false

Warning message:
The <scale> argument of guides() cannot be FALSE. Use "none" instead as of ggplot2 3.3.4.
ℹ The deprecated feature was likely used in the funModeling package.
Please report the issue at https://github.com/pablo14/funModeling/issues.

Thanks! I'm submitting a new version
On Thu, Jun 15, 2023 at 4:32 AM lyoungblood14 @.***>
wrote:

Warning message:
The  argument of guides() cannot be FALSE. Use "none" instead as
of ggplot2 3.3.4.
ℹ The deprecated feature was likely used in the funModeling package.
Please report the issue at https://github.com/pablo14/funModeling/issues.
—
Reply to this email directly, view it on GitHub
https://github.com/pablo14/funModeling/issues/23, or unsubscribe
https://github.com/notifications/unsubscribe-auth/ACHPQVNWCBGTTYFJKB5TRPLXLK273ANCNFSM6AAAAAAZHNIXJQ
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>


merge in open-mpic-core version

This branch now passes all tests and has open mpic core extracted. I propose we merge into main. Final todos would be to update the readme to properly init the submodules.

The auto unit tests fail now because of the submodule... we'll need to figure out a way to fix that in the pipeline. But I'm OK merging. Since we've been pairing on this, consider it peer reviewed :)


Only pull in tracing-subscriber for tests, examples, and CLI binary

Makes the tracing-subscriber dependency optional and mentions it in the cli feature-set.
This means the oso library no longer has a hard tracing-subscriber dependency, in accordance with best practices for leaving tracing-output selection flexible until the point of executable construction.

I have read the CLA Document and I hereby sign the CLA


test: update tests to use getMediaSections

for better readability/semantics.

Codecov Report

Merging #84 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #84   +/-   ##
=======================================
  Coverage   97.53%   97.53%
=======================================
  Files           1        1
  Lines         813      813
=======================================
  Hits          793      793
  Misses         20       20

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update add9e9e...9208ad1. Read the comment docs.

also 👋 @nils-ohlmeier ;-)


GROOVY-8771: global AST transformation declarations should move to ME…

…TA-INF/groovy instead of META-INF/services

Leaving files where they are for now. We can come back and re-look at this PR if additional impacts are found down the track.


Navbar Directory Not Found

Expected Behavior:
The directory should lead to the corresponding page without any errors.
Actual Behavior:
Users are encountering a "Directory Not Found" error message when clicking on the directory in the navbar as shown in the image.
Proposed Solution:
Investigate the backend to ensure that the correct directory paths are linked to the navbar items. Test and verify that clicking on each directory correctly navigates to the intended page without any errors.

can you please assign this issue to me??

Please allocate this task to me. I'm capable of tackling it as I possess all the requisite skills to address the matter at hand.

can you please assign me this issue ?


Topic/dynchange - [merged]

In GitLab by @proyan on Feb 19, 2019, 16:05
Merges topic/dynchange -> devel
Since it is not possible to yet add armature in pinocchio, I create this as a temporary fix for the data.f sign.
This PR replaces !105 for the time
I verified that jump and biped walking are able to converge. However, I don't have any logs to compare with, so that should perhaps be added somewhere.

In GitLab by @proyan on Feb 19, 2019, 16:07
This PR also removes the Kinv from calcdiff and creates data.Kinv in calc for the impact and floating base dynamics

In GitLab by @nmansard on Feb 19, 2019, 20:03
Thanks. Could you justify why it is important to change this sign? If I am correct, it makes the equation to be:
M qddot + b = S' tau - J'f
making f to be the forces that the robot exerts on the world, instead of the opposite.
Is that because it is more consistent with Pinocchio

In GitLab by @proyan on Feb 20, 2019, 02:45
It is the opposite. The current PR makes the dynamics to be Mddq +b = JtF+tau. Previously you had saved -f as the value in DAM, which you changed to f before sending it to pinocchio. This was problematic because the costforce uses data.f, but it was getting data.(-f)

In GitLab by @nmansard on Feb 20, 2019, 09:54
merged

In GitLab by @nmansard on Feb 20, 2019, 09:54
mentioned in commit 0e5b6c366fc3b3191227d10f1bff7cc89ab28813


Update library.properties

Picked up proposal from https://github.com/matthias-bs/BresserWeatherSensorReceiver/pull/206 with modified syntax.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>2
Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 100.0%

Totals

Change from base Build<PHONE_NUMBER>7:
0.0%

Covered Lines:
215

Relevant Lines:
215

💛  - Coveralls


Ingest and report hashrate

Description
As an operator, I want to accurately ingest hashrate reported per miner and report it as metrics.
Acceptance Criteria

Change the way we handle eth_submitHashrate and make sure we record the information provided per miner.
Report this information as metrics.

PoW is now deprecated so we won't be adding features to it


Support publicPath and hidden-source-map

webpack supports a variety of options for source maps, which we could bring to the Ember community as well. Two of them that I feel can be useful are:
publicPath: The value will be prepended to the value of sourceMappingURL. So, for a value of https://my-vpn/, the generated sourceMappingURL will be, //# sourceMappingURL=https://my-vpn/app.map. Implementing this should be as simple as prepending the value of publicPath to url here.
hidden-source-map: Using this option will prevent the reference to the source map from being added to the minified asset. The source maps can be separately uploaded to a private server and then loaded using the "Add Source Map..." option in Chrome. To implement this, we would just have to stop passing the url option to terser.
Further Reading

Seems good to me...

Raised #126 to address this.

@Turbo87, thanks for merging!
Could you also release a new version of ember-cli-uglify? The latest release on the registry v2.1.0 depends on<EMAIL_ADDRESS>I see that the PR to update this to v3 was merged but hasn't been released yet.

@astronomersiva thanks for reminding me. I'll release once https://github.com/ember-cli/ember-cli-uglify/pull/102 is merged in as well, to prevent us from having to do yet another major version bump at the end of the month.


JIT-compille DataFusion expression with column name

Which issue does this PR close?
Closes https://github.com/apache/arrow-datafusion/issues/2123
Rationale for this change
Allowing to compile more realistic expressions, like (a+1) as a step towards generating code to run on Arrays.
What changes are included in this PR?

Are there any user-facing changes?

Thanks again @Dandandan for working on JIT! I hope I can have time to work with you on jit soon.
FWIW, one of our blockers is Cranelift has no ability to inline assembly, so it causes performance regression for columnar to row conversion (as recognized in https://github.com/apache/arrow-datafusion/pull/1975). A possible solution is to use LLVM instead of Cranelift because PostgreSQL and Impala have proved that inline is feasible in LLVM. I would pick it up if it's not taken already at the time.

Thanks again @Dandandan for working on JIT! I hope I can have time to work with you on jit soon.
FWIW, one of our blockers is Cranelift has no ability to inline assembly, so it causes performance regression for columnar to row conversion (as recognized in https://github.com/apache/arrow-datafusion/pull/1975). A possible solution is to use LLVM instead of Cranelift because PostgreSQL and Impala have proved that inline is feasible in LLVM. I would pick it up if it's not taken already at the time.

Cool, thanks for the context.
I was thinking for generating the code for compiling expressions to cranelift jit, this would not be bad, as we could generate the whole loop instead to generate the new array contents which doesn't need to call any function. I am not sure if we run into the same problem as that thread, as it is about accessors for datastructures? It seems if we can operate on arrays with primitive datatypes this wouldn't be problematic?
I was thinking of the following strategy:

Get the start address, array length and the bytes for the primitive type.
Pre-allocate an output array, pass the address
Use this info to generate the full loop where the loop uses the length, the assignment uses the addresses and increases the pointer with the number of bytes.

Is this somewhere going to get stuck?

I'm a bit confused here. Do you mean https://github.com/jorgecarleitao/arrow2/issues/627 chaining expressions and avoid repeated array allocation through Jit？

chaining expressions and avoid repeated array allocation through Jit？

FWIW I think if we "JIT'd" the entire expression, an approach like https://github.com/jorgecarleitao/arrow2/issues/627  will likely not help all that much (as the temporaries will be in registers rather than being materialized in intermediate arrow arrays)

I'm a bit confused here. Do you mean https://github.com/jorgecarleitao/arrow2/issues/627 chaining expressions and avoid repeated array allocation through Jit？

The goal in that issue is similar yes, but using generated code instead of reusing arrays.
The idea is that we can compile the entire loop.
The compiled expression a + b would roughly compile to something like the following pseudo code:
i = 0
while i < length {
    *item = *a + *b;

    a += size_a;
    b += size_b;
    item += size_item;
}

Here item is the pointer to items in the target array and a / b  are pointing to items in arrays a and b.
In this case we only need to allocate one target array, instead of intermediate arrays.

I think we are good as long as we don't invoke rust functions from the JIT'd code. I am curious if cranelift will be smart enough to auto vectorize the loop though :)
If we keep the code gen API similar, then when we switch to LLVM, the migration shouldn't be too hard.

I think we are good as long as we don't invoke rust functions from the JIT'd code. I am curious if cranelift will be smart enough to auto vectorize the loop though :)
If we keep the code gen API similar, then when we switch to LLVM, the migration shouldn't be too hard.

:100: Maybe it could event coexist together (both a Cranelift / LLVM backend).
Also not sure on the autovectorization, though I am hopeful we might be able to instrument cranelift enough to have it compile to SIMD instructions (there are for example SIMD types https://docs.rs/cranelift/latest/cranelift/prelude/types/index.html).

I am sorry I am not following along this work this too carefully, but I really like where this is headed. JIT compiling predicate evaluation is definitely state of the art and I love to see it arriving in DataFusion. I think we can potentially get pretty far just JIT compiling the most common predicates even if for more complicated one we (initially) fall back to vectorized evaluation
So thank you all for pushing this forward


checkout uxarray

See https://github.com/UXARRAY/uxarray/ (and https://raijin.ucar.edu/) for an effort to coordinate development of unstructured grid functionality in the Pangeo ecosystem. It would be nice if you could participate so that FVCOM output works easily within that framework. Open an issue and say hi!

Thanks! I will say hello!


Generic caching interface

It would be nice if Ktorm offered a generic caching interface, so users could implement their own caching systems for db queries using eg. Redis or Ehcache.
The interface could look something like this:
interface KtormCache {
  fun getFromCache(generatedSql: String): QueryRowSet?
}

And a sample implementation:
class KtormCacheRedisImpl : KtormCache {
  override fun getFromCache(generatedSql: String): QueryRowSet? {
    // Return query results from redis by the generated sql, or null if not found
  }
}

Thanks.

Thank you for your suggestion.
But I don't think an ORM framework should support caching. My design philosophy is to do one thing and do it well. The caching can be implemented with other tools.
In addition, implementing caching is not so simple. We have to consider the expiring of the cached elements and the invalidation strategies, which will greatly increase the complexity of Ktorm. I want to keep Ktorm simple.
So, let's postpone that issue until anyone else asks for that.

Ok, thanks for your reply.
Could you give me an example of what you mean by other tools?
Also, you could leave the implementation of the invalidation strategy/cached element expiration to the users (even though it would of course be nicer if Ktorm had it out of the box), after all it is the user's code that will either return a null query row set or not.
So the implementation could just return null when a cached element has expired in addition to situations where such a cached element has not been found.

Google Guava is a great library that provides an effective caching implementation. Here is an example:
class DepartmentService {
    private val cache = CacheBuilder.newBuilder()
        .expireAfterWrite(1, TimeUnit.MINUTES)
        .build<Int, Department>()

    fun getDepartmentById(id: Int): Department? {
        return cache.get(id) { Departments.findById(id) }
    }

    fun addDepartment(name: String, location: String) {
        val department = Department()
        department.name = name
        department.location = location
        Departments.add(department)
        cache.put(department.id, department)
    }

    fun updateInfo(id: Int, name: String, location: String) {
        val department = Departments.findById(id) ?: return
        department.name = name
        department.location = location
        department.flushChanges()
        cache.put(id, department)
    }

    fun deleteDepartment(id: Int) {
        Departments.delete { it.id eq id }
        cache.invalidate(id)
    }
}

There are also some other caching libraries, like Spring Cache, JetCache and so on. They are very mature and have superior performance. We should choose one of them instead of implementing caching in an ORM framework.

Ok, feel free to close this if you want to.


[GOBBLIN-1645]Change the prefix of dagManager heartbeat to make it consistent with other metrics

Dear Gobblin maintainers,
Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!
JIRA

[ ] My PR addresses the following Gobblin JIRA issues and references them in the PR title. For example, "[GOBBLIN-XXX] My Gobblin PR"

https://issues.apache.org/jira/browse/GOBBLIN-1645

Description

[ ] Here are some details about my PR, including screenshots (if applicable):
Change the prefix of dagManager heartbeat to make it consistent with other metrics

Tests

[ ] My PR adds the following unit tests OR does not need testing for this extremely good reason:

Commits

[ ] My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":

Subject is separated from body by a blank line
Subject is limited to 50 characters
Subject does not end with a period
Subject uses the imperative mood ("add", not "adding")
Body wraps at 72 characters
Body explains "what" and "why", not "how"

Codecov Report

Merging #3505 (dd94fb1) into master (dd6d910) will decrease coverage by 3.18%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #3505      +/-   ##
============================================
- Coverage     46.68%   43.50%   -3.19%
+ Complexity    10411     2042    -8369
============================================
  Files          2079      405    -1674
  Lines         81323    17482   -63841
  Branches       9081     2137    -6944
============================================
- Hits          37968     7606   -30362
+ Misses        39855     9027   -30828
+ Partials       3500      849    -2651

Impacted Files
Coverage Δ

...a/org/apache/gobblin/cluster/GobblinHelixTask.java
60.21% <0.00%> (-2.16%)
:arrow_down:

...blin/service/modules/orchestration/DagManager.java

...apache/gobblin/yarn/GobblinYarnMetricTagNames.java

...service/modules/orchestration/DagManagerUtils.java

...e/gobblin/converter/SchemaConversionException.java

...gobblin/source/extractor/schema/ArrayDataType.java

...he/gobblin/service/modules/flowgraph/DataNode.java

.../main/java/org/apache/gobblin/http/StatusType.java

...obblin/service/modules/restli/FlowConfigUtils.java

...gement/retention/version/StringDatasetVersion.java

... and 1666 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dd6d910...dd94fb1. Read the comment docs.


[WIP] PoC Flutter plugins iOS integration tests Cirrus task

Description
This is a PoC of enabling flutter/plugins testing on Cirrus, running on Mac and Linux builders.
Not ready for review yet, opening this PR so that I can more easily run on Cirrus.
Related Issues
Fixes flutter/flutter#30446
Breaking Change
Does your PR require Flutter developers to manually update their apps to accommodate your change?

[ ] Yes, this is a breaking change (Please read Handling breaking changes). Replace this with a link to the e-mail where you asked for input on this proposed change.
[X] No, this is not a breaking change.

@collinjackson Should we close this PR?

I am going to close this PR since there has been no response in a while.


[PE-D] Unclear on whether name field is name of person or name of appointment

Could be clearer whether name field is name of appointment or name of person

Labels: severity.Low type.DocumentationBug
original: markbiju/ped#5

Not a Bug
We consider this not a bug, as it is implied that if the Person: field is the person, then the Name: field can no longer be the person's name.


Revert "Add API Documentation"

This reverts commit d8d79ba75b7a0371d77d646671991969c01ef36d.

I think I'll just do this with a pull request to change the wording.


431 kubeclient

To resolve https://bugzilla.redhat.com/show_bug.cgi?id=1730588

License check failed: run mvn -N license:format to update all licenses, commit, squash & force push please.

Tests failed.


Add "deploy" subcommand

When a user runs ENVIRONMENT deploy
Parity will:

fetch the git remote for the environment
check if there are changes in db/migrate
which will be pushed.
push local master branch to remote master
run parity's migrate command if needed.

This idea was considered a year ago (great minds think alike!), but the decision was to let parity do heroku and for git to do git.
For automigration, I'd recommend using Tim Pope's Heroku Ruby Buildopack, which runs the migration with the deploy for only a single restart and minimal downtime.

Note that we've been adding bin/deploy scripts to new projects through suspenders. One disadvantage to it living there is that not all projects have such a script. Also, defining deploy in parity lets us evolve the strategy (for example, unlike the deploy script from suspenders, this version won't restart if there are no migrations being deployed).
Finally, my brain has trouble swapping bin/deploy production with production deploy, which produces the following terrifying output:
> production deploy
 !    `deploy` is not a heroku command.
 !    Perhaps you meant `destroy`.
 !    See `heroku help` for a list of available commands.

@croaky Would love to have you weigh in on this. I've been using and liking this over the last week. Faster deploys than bin/deploy when there are no pending migrations, and works on non-suspenders projects!

I like that "migrate only when necessary" bit. @tute Something to consider for the default bin/deploy script in Suspenders.
I'm down with this idea. Sorry for originally shutting it down, @geoffharcourt. I guess I'm changing my tune with multiple people coming to the same conclusion.
@b Good to merge at your discretion.


Initial logging setup for debugging errors with ESPN API

Codecov Report

Merging #63 into master will increase coverage by 0.24%.
The diff coverage is 96.55%.

@@            Coverage Diff             @@
##           master      #63      +/-   ##
==========================================
+ Coverage   91.37%   91.62%   +0.24%
==========================================
  Files          12       13       +1
  Lines         545      573      +28
==========================================
+ Hits          498      525      +27
- Misses         47       48       +1

Impacted Files
Coverage Δ

ff_espn_api/logger.py
100% <100%> (ø)

ff_espn_api/league.py
86.18% <94.11%> (+0.38%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1867aae...30e35c0. Read the comment docs.

Feature #62


Killing Floor 1 Support

Would it be possible to have a build that supports Killing Floor 1?
Admittedly I haven't the slightest clue as to how difficult this would be to accomplish, but a fix to the selection issue would be a God send for the game.

I will be looking into KF support this month, it's not as easy as just hitting a button for it though, so no promises.
You can join the OldUnreal discord server to (very occasionally) see progress with this.

Oh cool, I'm already in the Old Unreal Discord.
What channel do you typically post in?

For updates on this, usually the 2k4 channels, but you'll see me talk about it (and other things) in all the channels, as I'm a OldUnreal dev.


[🐞 BUG]: Fix .github/ISSUE_TEMPLATE/Chore.yml

Description 📝
From GitHub:
There are some problems with this template
assignees must be of type String or Array. Learn more about error 1.
about is not a permitted key. Learn more about error 2.
From Me:

Remove assignees
Change about to description

Link 🔗
https://github.com/Ansub/SyntaxUI/blob/main/.github/ISSUE_TEMPLATE/chore.yml
Steps to Reproduce 🔄

Go To https://github.com/Ansub/SyntaxUI/blob/main/.github/ISSUE_TEMPLATE/chore.yml

Screenshots 📸

Expected Behavior 🤔
It should not errror
Actual Behavior 😱
It errors
Environment 🌍
na
Additional Information ℹ
No response

We are not adding a chore template at the moment. You can delete the file for this. A bug report is sufficient for this, and the user can then request that I add the "chore" label to it.


[FIX] update reports.py for Singularity image

Changes proposed in this pull request
Fix for error in generate_report function encountered when running singularity image of fmriprep version 1.1.8 on a cluster, with singularity version 2.6.0 raised in issue #1313.

Fixes #1313.
Documentation that should be reviewed
The flag encoding='UTF-8’ was added for all read_text and write_text functions.

Hi @alioco, are you planning on adding your name to the zenodo file or you'd rather opt out this time?
I'll merge as soon as I have an answer.
Thanks a lot for your contribution!

@oesteban I'll opt out at this time, thank you!


[$250] Expense - Page blinks when opening Hold RHP from report details page

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number: 9.0.1-0
Reproducible in staging?: y
Reproducible in production?: no, new feature
If this was caught during regression testing, add the test name, ID and link from TestRail: Exp around https://expensify.testrail.io/index.php?/tests/view/4661954
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause internal team
Slack conversation:
Action Performed:

Go to staging.new.expensify.com
Go to any DM.
Submit two expenses.
Go to transaction thread of any expense.
Click on the chat header.
Click Hold.

Expected Result:
Page will not blink when opening Hold RHP from report details page.
Actual Result:
Page blinks when opening Hold RHP from report details page.
Workaround:
unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android: Native
[ ] Android: mWeb Chrome
[ ] iOS: Native
[ ] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

Screenshots/Videos
https://github.com/Expensify/App/assets/38435837/b6a303ba-fd33-4085-8f9c-2b935cdea61e

View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01849f37018df4c9e8
Upwork Job ID:<PHONE_NUMBER>823292445
Last Price Increase: 2024-06-24

Issue OwnerCurrent Issue Owner: @ishpaul777

@nkuoch FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

We think that this bug might be related to #wave-collect - Release 1

Proposal
Please re-state the problem that we are trying to solve in this issue.
The page behind the RHP looks like blinking when pressing the hold button in details page.
What is the root cause of that problem?
When we choose the hold button, we do 2 things. First, dismiss the modal, and second, navigate to the hold reason page.
https://github.com/Expensify/App/blob/017605269c9f3a351522784aec04dd12644ec564/src/components/PromotedActionsBar.tsx#L68-L71
https://github.com/Expensify/App/blob/017605269c9f3a351522784aec04dd12644ec564/src/libs/ReportUtils.ts#L2808-L2809
If we see the video slowly, we can notice that it's not blinking but the multiple navigations are happening at the same time causing the RHP overlay to become darker and then lighter.
https://github.com/Expensify/App/assets/50919443/cc96fcd5-cef4-4f36-bea7-5f684b971198
What changes do you think we should make in order to solve the problem?

I don't know if it's expected to dismiss the modal when choosing the hold button, but if it's not, then we can remove it.
https://github.com/Expensify/App/assets/50919443/295f38c2-a39d-4302-92eb-a1890f9aeb6c

@ishpaul777 I checked that it's because of the focus trap initial focus on the hold explanation page. That kind of sliding issue is similar to https://github.com/Expensify/App/issues/43806 where we focus immediately while an animation is ongoing. This issue doesn't happen when you submit the hold with a mouse. One way to solve this is to delay the focus-trap  by CONST.ANIMATED_TRANSITION (300ms), adding the below code to focusTrapOptions.
checkCanFocusTrap: () => new Promise((resolve) => setTimeout(resolve, 300)),
https://github.com/Expensify/App/blob/d7db203cc8516492387a2a27b089f10bad7ab5ad/src/components/FocusTrap/FocusTrapForScreen/index.web.tsx#L43-L47

@ishpaul777
Hi from UpWork!
Here is my fix Proposal and Solution:
Issue:
The issue happens because the 2 Navigation Modal Items overlaps each other. So, the backdrop opacity of the 1st one overlaps the 2nd one during the opacity animation effect here:
https://github.com/Expensify/App/blob/d7db203cc8516492387a2a27b089f10bad7ab5ad/src/styles/index.ts#L1906
At some point the opacity sum of backdrops of the 1st modal and 2nd modal can give more than 0.72 as was prescribed during some time and make the glitch effect of increasing backdrop opacity to 1 and back.
so we have the glitch effect.
Solution:
Using the index property of useCardAnimation in BaseOverlay
https://github.com/Expensify/App/blob/d7db203cc8516492387a2a27b089f10bad7ab5ad/src/libs/Navigation/AppNavigator/Navigators/Overlay/BaseOverlay.tsx#L22
and pass it to style can help us to unidentify if we open next modal and turn off backdrop opacity animation, so we will have smooth effect without glitches and opacity animations
Demo
https://github.com/Expensify/App/assets/44111298/04a97f55-d29e-4d15-81a6-48d7ba9dd16c

@ishpaul777
Sorry, I am first time contributing to Expense, do I need anything to add to my previous post, so you can test that my solution works for modals stack? :)

@ishpaul777 after my change, pressing the Hold button won't close the details page.
[details, hold reason]
Submitting the hold reason will pop the hold reason page which animates the page to slide from right to left and the details page from left to right, and at the same time the hold explanation page is showing with animation interrupted.

@ishpaul777 If you do not mind I will provide some more details why it is the root issue and it will fix:

The project uses React Navigation and all navigation modals are separate views. This rules is applicable also for react-native-app.
When we call the navigate to modal we will open the new modal screen. In case of this issue we call:

     Navigation.dismissModal();
     ReportUtils.changeMoneyRequestHoldStatus(reportAction);

First call will trigger close modal. It spends up to 600ms to close the existed modal and trigger open new modal up to 600ms to open the new one.
In this case each modal will have its backdrop: you can debug this in browser and see that the animation is in progress for both of the modals. One modal is interpolating from 0.72 - 0 and other from 0 - 0.72.
Here the code you can test, the PR is not ready for review but you can see the changes and the issue fixed for all modals that are calling one by one:
https://github.com/oleksolv/App/pull/1

Yes, correct.
https://github.com/Expensify/App/blob/2526e31ba9c199ca606f65abb2295e39638d09ee/src/pages/iou/HoldReasonPage.tsx#L56-L69

I think we should try to fix the underlying issue which is there is no backTo in the HoldReasonPage when coming from the Search page.

I think we can do that, but I see this PR is working on a fix for this issue too.

That PR was merged to prod yesterday! I'm not able to repro this one -- @ishpaul777 can you try testing and see if it's still happening for you?

Yay! Thanks @ishpaul777


Variables view and watch view are not in sync

Testing #14305 (Might not be related)

VSCode Version: Latest Insiders
OS Version: Mac OS

Steps to Reproduce:

Create a snippet that contains an Object. Say:

let myObject = {
  a: 1
  b: 2
  c: 3
}
....

Put a break point after array definition. Start debugging
Watch myObject variable
After break point is hit, change value of any property of myObject

Expected:
myObject values should be same in Variables and Watch view

October to investigate

This is basically a duplicate of https://github.com/Microsoft/vscode/issues/2399
However there is an issue in node-debug that it is given stale variables for a variables request. Do the exactly like in @sandy081 steps however do not expand the myObject in variables view until you have changed a value of myObject.a inside the repl. Only then expand the myObject -> notice the myObject.a is stale - which is a proof that node debug is giving stale variables.
Thus assigning this to @weinand
And #2399 captures the issue on vscode side that vscode should always request new variables on each evaluation

No longer an issue in node-debug2


Dropdown.Toggle props are not accessible in Components.Dropdown

If you want to change the gray background that appears in Dropdown

you need to add a specific className in vulcan-ui-bootstrap, ui/Dropdown.jsx
<Dropdown.Toggle className="ddown" >{trigger}</Dropdown.Toggle>

and add in css :
.ddown { background: transparent; }

add a toggleProps as additional option in Dropdown ?
<Dropdown.Toggle {toggleProps} >{trigger}</Dropdown.Toggle>

I think toggleProps might be a bit redundant given that you can already pass a trigger component to replace the toggle. But I'm open to it if it's useful.

As discussed on Slack, it allows here to modify the Dropdown.Toggle not the trigger ;)


Expose the methods for measuring text to the end user.

Like the title says. This isn't super high on the list of things to do as we might replace the GUI with iced.

Closing this as I've removed the GUI for now..


Fixing failing tests

running npm run test on master results in the following
failingTests.txt
I've added some missing quotes to separate the expected cases.

Thanks


Problem with casting to number for location coordinates

Hey, I use the $geoNear feature in MongoDB, so I added a location property to the Place schema object and it looks that the admin has a problem with adding new entries.
When I programatically create a new entry to the database and check it in the admin, it works:

When I try to add a new place in the admin it doesn't work:

My schema model:
import mongoose from "mongoose";

const { Schema } = mongoose;
const schema = new Schema(
  {
    name: {
      type: String,
      required: true,
    },
    desc: {
      type: String,
    },
    location: {
      type: { type: String, default: "Point" },
      coordinates: [Number],
    },
    categories: [
      {
        type: Schema.Types.ObjectId,
        ref: "Category",
      },
    ],
    tags: [
      {
        type: Schema.Types.ObjectId,
        ref: "Tag",
      },
    ],
    published: Boolean,
  },
  { timestamps: true }
);

schema.index({ location: "2dsphere" });

const Place = mongoose.models.Place || mongoose.model("Place", schema);

export default Place;

I'd like to use your admin as it's nice. If you don't have time to fix it yourself, can you point me to the right place in the source code, so I can send a PR? :)

thanks for pointing this out - it might be a bug in the adapter

we've just released admin-bro v3.3  along with the latest mongoose adapter. Can you check them out?


BUG: smart_irrigation.reset_bucket with multiple instances

When irrigation is done this service should be called. But when using multiple instances, it appears it only works for the first integration..

confirmed.

you can now name instances so you should see multiple instances being created of the services (assuming you used unique names...)


[ml-basics] Feature space vs. Input space

Should we distinguish between feature space and input space? E.g., if we take the log of some variable then it is the original variable in the input space and the logarithmic transformation in the feature space.

 Test Ticket

 Input space vs. Feature space


[WIP] Resolved issues in search-results #534

Dev note 🛠
I started working on this issue and found out that after clicking on a search result we open whole file (instead of file with desired line of code).
I found it hard to fix all of color issues without a little bit of hacking (🪝 ).
Current implementation of FindNavigatorResultList doesn't catch selection events within the same file so I'm considering refactoring it something similar to ProjectNavigator - OutlineGroup. WDYT?
Description
Changes

Fixed issues with colors in search results
Fixed: text in the search field is removed from the input field when you switch panels.
Refactored FindNavigatorResultFileItem - extracted large parts to separate subviews

Related Issue

#534

Checklist

[x] I read and understood the contributing guide as well as the code of conduct
[x] My changes generate no new warnings
[x] My code builds and runs on my machine
[x] I documented my code
[ ] Review requested

Screenshots

Light Mode

Before
After

Dark Mode

Before
After

Looks good. We need to preserve the transparency of unbolded text in your results though.

Two related things that need to be looked at...

We need to be using a selection material instead of a color for the background of your selection. See #530.
The breadcrumb selector above the input is not spaced correctly and the inputs themselves have a slightly different style compared to Xcode.

@zuziakaxel : As you can see from the pictures it looks different.

I don't know if it's the font or the bold.
Other related text is also different in font.
@austincondiff : What do you think?

You could put the icon color of the file when it is not selected.
I also noticed one more thing, search the same word on both xcode and codeEdit, the results on the files should be the same data in the same way.
I'm not talking about the ignore case (upper and lower case) which has not yet been implemented.
I talk about the order of the files, for example the first file given on xcode is AboutView on codeEdit is WelcomeView.
How come this difference, what is based.

Agreed. Please add the appropriate icon color in that is used in the project navigator and tab bar.

Update: Still working on it. I need to refactor FindNavigatorResultList from:
List
    ForEach
        DisclosureGroup
            ForEach

to:
List
    OutlineGroup

Because previous implementation was supporting only selecting whole file (not a specific search result), therefore adjusting selection style for single "cell" was not possible.

This PR is still in draft status and it is three weeks old. To avoid this getting stale I just wanted to check on the status of this PR.

FYI, the unmatched text is too prominent, especially in dark mode.

Any updates on this?

Hey @zuziakaxel!

Closing this due to #703. Thanks for the help @zuziakaxel! Your initial work gave me a great boost.


[IR] Fix comprehension.Normalize ...

... to work if the inner comprehension is not a comprehension but some other DataBag expr.

LGTM!


Add Japanese holidays on the new Emperor

Add new holidays regarding the ceremonies of the new Emperor in Japan

Pull Request Test Coverage Report for Build 544

16 of 16 (100.0%)  changed or added relevant lines in 2 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 100.0%

Totals

Change from base Build 542:
0.0%

Covered Lines:
6177

Relevant Lines:
6177

💛  - Coveralls

Hi,
thank you very much for your contribution!
Question about it: I gave a look to your code, and noticed you've provided logic for 2019 only.
To explain my lifecycle principle, I use to say "we aim always to providing a final release library, even if we already know it won't be so".. so isn't there the possibility to manage/support future years too (eg: if year **>=** 2019: ) ?
Of course, if something in the future will change, there will be a new release to fix it.. and so on :-)
I rely on you for this because I'm not aware of how holidays in Japan work.. thanks again!
NOTE: I moved the target branch to "beta", which is the branch we use to include new PR.

The two sections with if year == 2019 are both related to the change of the Emperor, which is planned to perform this year, and there will no holidays like them from next year. I'm sorry I didn't explain enough with comments, but the latter section, which has two holidays,  is also related to Enthronement Day. These days become holidays only this year.

Let me also explain some hard-coded functions.
_add_national_holidays and _add_substitute_holidays can be calculated with programs because they are established based on a series of weekdays and holidays, (a weekday between national holidays becomes a holiday, and a Monday after a national holiday on Sunday becomes a holiday), but the code can be long and these holidays are changed by Government sometimes. This is why I chose to hard code.

Hey no problem at all, I just wanted to double check .. moreover I noticed now there's a if year >= 2020: block, so it's my fault, in the end ;-)
..Going to merge, thank you very much again!