[bug] Brave Wallet connector option not showing up

Is there an existing issue for this?

[X] I have searched the existing issues

RainbowKit Version
0.11.1
wagmi Version
0.11.6
Current Behavior
The Brave Wallet option is not showing up on the list of available wallets to connect. However, if Brave is replaced with either Ledger, Omni, or some other additional wallets, these additional wallets show up.
Expected Behavior
Brave should show up as an option to select on the list of connectable wallets.
Steps To Reproduce
import { configureChains, createClient, WagmiConfig } from 'wagmi';
import { getDefaultWallets, connectorsForWallets } from '@rainbow-me/rainbowkit';
import { braveWallet, rainbowWallet, coinbaseWallet, metaMaskWallet, walletConnectWallet, omniWallet } from '@rainbow-me/rainbowkit/wallets';

const connectors = connectorsForWallets([
  {
    groupName: 'Popular',
    wallets:  [
      rainbowWallet({chains}),
      coinbaseWallet({chains}),
      metaMaskWallet({chains}),
      walletConnectWallet({chains}),
      omniWallet({chains}),
      braveWallet({chains})
    ]
  }
])

const wagmiClient = createClient({
  autoConnect: true,
  connectors,
  provider,
});

Link to Minimal Reproducible Example (CodeSandbox, StackBlitz, etc.)
No response
Anything else?

@v1v3krk Did you test in Brave browser? Currently this connector will only appear in that browser when the Web3 > Default Ethereum Wallet setting is set to Brave Wallet or Extensions (Brave Wallet fallback).

Is there any way to show Brave Wallet by default on Brave Browser without the wallet configuration on v.0.12? @DanielSinclair

@kylengn Yes. Just add the braveWallet wallet connector to your Wallet List, and it will always appear on Brave

@DanielSinclair Thanks for the answer. However, I have added the braveWallet to my app. It's only showing after the configuration to set Default Ethereum Wallet to Brave Wallet. As I have noticed, on the RainbowKit official website, it will automatically show the Brave Wallet without the prior configuration. I would love to achieve the same thing in our app using rainbowkit and wagmi version 0.12.x.
const connectors = connectorsForWallets([   {     groupName: 'Gnosis Supported Wallets',     wallets: [       metaMaskWallet({ projectId, chains }),       walletConnectWallet({ projectId, chains }),       coinbaseWallet({ appName, chains }),       rabbyWallet({ chains }),       braveWallet({ chains }),       safeWallet({ chains }),     ],   }, ])

@kylengn This is a side effect of Brave's default wallet behavior and how it treats window.ethereum. If you upgrade to RainbowKit and Wagmi v2, you'll adopt the new EIP-6963 standard that circumvents that behavior (which is what you see on RainbowKit.com).


Weak Keychain Protection Class kSecAttrAccessibleAlways

This package uses kSecAttrAccessibleAlways keychain security attribute which is deprecated in iOS 9 and not recommended for application use.
Essentially this is a security risk which allows data in the keychain be accessible regardless if a device is locked.

If there is something to change (including deprecating any APIs or breaking changes to behavior) I'd be happy to merge a PR and issue the semver-correct (even if breaking...) change

hey @mikehardy
Help me understand how this project uses keychain so we can pick the most suitable access control.
Item Attribute Keys and Values page (search for "Accessibility Values" subtitle) has a list of access control values starting from the most restrictive kSecAttrAccessibleWhenPasscodeSetThisDeviceOnly to the least restrictive kSecAttrAccessibleAfterFirstUnlock.

I think if we were most permissive before (available always) then moving to the most permissive non-deprecated one is correct, so I would go for AfterFirstUnlock - I see you've PRd already so I'll take your comment (which is/was educational for me, thank you) into account as I review the PR


eo-collections can't be version up in objectionaries because of eo-strings tests

This build fails because there are break changes in eo-collections 0.10.0 related to arguments order in list.reducedi.
Need to change all list.reducedi uses in the repo, disable the tests, make new release and try to update eo-strings in objectionary

@maxonfjvipon the puzzle #167 is still not solved.

@yegor256 let's make a new release with tag 0.5.0

@rultor release, tag is 0.5.0

@rultor release, tag is 0.5.0

@yegor256 OK, I will release it now. Please check the progress here

@rultor release, tag is 0.5.0

@yegor256 Done! FYI, the full log is here (took me 10min)


chore(main): release 0.1.18

:robot: I have created a release beep boop
0.1.18 (2023-06-05)
Features

cli: Run pipeline using 'openhexa pipelines run -c {}' (ab29c06)
Parameter: add float to supported types (#43) (3b6f709)

This PR was generated with Release Please. See documentation.

:robot: Release is at https://github.com/BLSQ/openhexa-sdk-python/releases/tag/0.1.18 :sunflower:


Redirecting back to request's URL causes destination to lose HTTPS

What version of Remix are you using?
1.1.1
Steps to Reproduce
Assume that I have a route foo accessible at https://example.org/foo that has an action function:
export const action = async ({ request }) => {
  return redirect(request.url);
};

export default Foo() {
  return (
    <form action="POST">
      <button type="submit"> Submit Form</button>
    </form>
  );
}

Expected Behavior
When the submit button is pressed, the POST request should redirect to https://example.org/foo
Actual Behavior
When the submit button is pressed, the POST request redirects to http://example.org/foo

Have you confirmed that request.url contains https?

@adwinying I'm seeing the same thing as you. It may be related to https://github.com/remix-run/remix/issues/420
In entry.server.tsx, could you log request.url at the start of handleRequest() and confirm that you're seeing http instead of https ?
How did you configure https://example.org in your server? Is it proxying a http url ? (this is my case)

@kiliman
request.url did not contain https.
@machour
Oh, #420 seems like a workaround. I’ll try it out 👍

In entry.server.tsx, could you log request.url at the start of handleRequest() and confirm that you're seeing http instead of https ?
yep, I’m seeing http instead of https.

How did you configure https://example.org/ in your server? Is it proxying a http url ? (this is my case)
I deployed my app to heroku so I assume some kind of reverse proxy is in effect.

Thanks for the replies, the workaround in #420 worked flawlessly.
Hopefully a more robust solution would be out soon.
Will close this since it's a duplicate of #420

@adwinying but you're still doing an extra redirect for nothing all the time : https => http => https
Another solution is to use a relative redirect if you're able to: redirect('/foo')

In case anyone else stumbled across this like me, my solution in the end was to just redirect to the relative path+search:
let { pathname, search } = new URL(request.url);
redirect(pathname + search);


rest api and openapi specification based on grpc api

see https://github.com/grpc-ecosystem/grpc-gateway

managed tooling with a tools.go https://github.com/golang/go/wiki/Modules#how-can-i-track-tool-dependencies-for-a-module

we'll just use https://ogen.dev/ (openapi)


@material-ui/core uses<EMAIL_ADDRESS>

[x] The issue is present in the latest release.
[x] I have searched the issues of this repository and believe that this is not a duplicate.

Current Behavior 😯

$ npm install @material-ui/core
npm WARN deprecated<EMAIL_ADDRESS>You can find the new Popper v2 at @popperjs/core, this package is dedicated to the legacy v1

Expected Behavior 🤔

@popperjs/core v2
Steps to Reproduce 🕹

Steps:

npm i @material-ui/core

Context 🔦

When installing material-ui on new project
Your Environment 🌎

Tech
Version

Material-UI
v4.9.1

React
v16.12.0

Browser
Chrome 80

Duplicate of #19358


Add tvOS Carthage target

This also renames the iOS framework target appropriately.
This PR is a rebase of #554.

Please Fix

您好，邮件已收到


Existence of .flow-node-tasks.lock is confusing when using Hilla

Describe the bug
When I start my Hilla application, there's a file named .flow-node-tasks.lock created in the project root directory while downloading things. The name of this file make me wonder whether I accidentally picked Flow instead of Hilla.
Expected-behavior
If a temporary file is created, it should have "Vaadin" or "Hilla" in the name rather than "Flow"
Reproduction
Run with any Hilla version. Check the git diff output while starting up.
It helps with a slow network connection since then the npm package download takes a longer time.
System Info
Vaadin 24.4.0.alpha22

To be addressed in Flow.


test cmake builds

@stopiccot Can you add a script to verify the cmake build to the test directory? Would be nice to catch problems with it in jenkins/travis.

This has been addressed.


heterochromatin maintenance

I think we might need to re-create
GO:0070829    obsolete heterochromatin maintenance
A new term is necessary because the old term was not correctly defined.
heterochromatin maintenance means
"Heterochromatin maintenance is the process of restoring histone modification profiles after DNA replication. As the replication fork moves forward, parental histones are deposited back to the original location and intermixed with newly synthesized his- tones. Parental histones containing H3K9me3 serve as signals for the recruitment of Clr4 to modify newly synthesized histones, restoring the H3K9me3 domain"
I can provide many references, but here is a useful  (current) review:
Leaving histone unturned for epigenetic inheritance
Chun-Min Shan*, Yimeng Fang and Songtao Jia
PMID: 34726351
Maybe we already have an equivalent term but this would need to be added as a synonym (most of the papers I am reading refer to a nucleation step and a maintenance step which have different components)
@colinlog
@pgaudet

@ValWood is this now handled by the new terms we have created ? See https://github.com/geneontology/go-ontology/issues/22135#issuecomment-1065188656

I think it will be OK.


gpio not unexported on close

Hi
periphery export the gpio correctly on open
try:
with open("/sys/class/gpio/export", "w") as f_export:
f_export.write("%d\n" % pin)
except IOError as e:
raise GPIOError(e.errno, "Exporting GPIO: " + e.strerror)
but on close it didn't unexport the pin

'''
pin_no = 403
# FIX: periphery don't unexport the directory on closing
gpio_path = "/sys/class/gpio/gpio%d" % pin_no
    if os.path.isdir(gpio_path):
        # Export the pin
        try:
            with open("/sys/class/gpio/unexport", "w") as f_export:
                f_export.write("%d\n" % pin_no)
        except IOError as e:
            raise periphery.GPIOError(e.errno, "Exporting GPIO: " + e.strerror)

'''

python-periphery doesn't unexport the pin on close because unexporting has side effects, like resetting the pin direction to input. If you used python-periphery to drive a pin as an output, it wouldn't retain that state after you closed the pin if were automatically unexported.
Some might argue that this is more correct, and that the program should keep the pin open for as long as it's being used, but I think that the convenience of having one-off scripts that can drive outputs and expect them to remain driven is more valuable. Automatically unexporting would also be at odds with the "preserve" direction in the current API.
Closing the issue for now, but I'm open to hearing compelling arguments for unexporting on close.


Feature Request: adjust lower bounds if no "room" sensor

Would be nice if for the dashboard view of the fermentation log would exclude the "room temp" if there is no values or if the roomt temp is not assigned a pin.
I suspect most users are like me and go to this screen then instantly click off the room temp or zoom to get a clearer view of the graph.  Having "0" be the y-axis base makes the graph only useful for a general overview.

Duplicated by https://github.com/thorrak/fermentrack/issues/591, looks like i've already mentioned this.   If I get some time I'll try to adjust it and put a PR in.


Update Script Analyzer rules

Update PSSARuleSeverities.md.
Add Script Analyzer settings file to DscResource.Template.
Update VSCode workspace settings file to use custom Script Analyzer rules.

This change is

@PlagueHO whn you have a chance, could you review this one?

@PlagueHO when you have time, can you look at this? See if this is something we should add?


fixing markdown

Hi @4c74356b41, I'm your friendly neighborhood Azure Pull Request Bot (You can call me AZPRBOT). Thanks for your contribution!

This seems like a small (but important) contribution, so no contribution license agreement is required at this point. Real humans will now evaluate your PR.

TTYL, AZPRBOT;

@4c74356b41 : Thanks for your contribution to the Azure documentation! The author, @YuriDio, has been notified to review your proposed change.

@4c74356b41 thanks for your contribution. @BryanLa please merge it.


Long detail panel description overlaps button

Description

Long detail panel description overlaps button
Related Issue : METATRON-3034
How Has This Been Tested?

Check the dataset details in the Management> Dataflow screen.
If the description is long, check if it is displayed normally.
Check if the screen is displayed correctly when the screen is resized.

Need additional checks?
Types of changes

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[ ] I have read the CONTRIBUTING document.
[ ] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have added tests to cover my changes.

Additional Context

run build
deploy to 4


fix stutter/lag when sending messages

No content

Issue created by BlueBubbles Bot in the BlueBubbles commnity on behalf of @zach in #general.

I also get this lag. Not sure if it's 100% of the time. But if not, it's like 80% of the time. It's only a stutter for like 1 ms. Not sure why it happens. My guess is either 1, the sendMessage() call is too intensive. Or 2, the UI gets updated (setState) too many times as it's sending and causes lag

Since this is just a debuggable issue, we don't need to fix anything. I have renamed the ticket to reflect an Optimization to get rid of the error


fix: resolve connection error by security protocol

%4|1727246243.038|FAIL|rdkafka#consumer-1| [thrd:mykafka:9092/bootstrap: Disconnected: verify that security.protocol is correctly configured, broker might require SASL authentication (after 347ms in state UP, 7 identical error(s) suppressed)

@Uijeong97 Thanks your contribution!


Handle zero length time ranges by returning the next valid point

This appears to match current behavior when a user requests a time range
between two intervals in the archive.  The next valid point is returned
even though its outside the initial time range.
Previously, as untilInterval was not greater than fromInterval the code
would do a wrap-read of the archive reading all data points into memory
and would return the correct timeInfo but a very long array of Nones for
values.  This resulted in very large pickle objects being exchanged
between graphite webapps and very long query times.

Thanks to logstash and statsd I've been monitoring the retrieval times my Graphite web frontends log as they pull data from the data storage nodes.  This graph shows the performance improvement I've achieved by fixing this particular issue.  The left is time in seconds.

Looks impressive, will try to apply on our cluster. I do not really care for traffic (because of HTTP compression), but for delay it didn't really help because it spending time for unpickling that huge None's series anyway.

The pickles of 200,000 Nones where what tipped me off.  Not downloading them or having to unpickle them has been a big win.  For a specific query each of my data storage nodes was sending a 47MiB-ish pickle to the frontend handling the request.  It was taking 2 or 3 minutes to download (httplib issues) and 15 or 20 seconds to unpickle.
Now that same query generates pickles from my data storage nodes that are less than 40 KiB.

Tested on my cluster, didn't see much difference - but maybe couple of complex graphs didn't timeouting now. :)

Your users/apps may be better behaved too.
My test case was 5min interval data where I was requesting from=1444249200 and until=1444249440.  In the whisper.py code the from/until times are adjusted so that they were both equal to<PHONE_NUMBER> which exhibited the bug.  (I ran this against my storage nodes with local=1 too.)  I reproduced this with 1min interval data as well.
curl -v -o /tmp/out.pkl 'http://storage-backendXXX/render/?local=1&format=pickle&from=1444249200&until=1444249440&target=<simple metric target>'

If you build a similar query you should be able to reproduce this on an unpatched cluster.

Strange, can't reproduce it on my branch, at least.
Patched cluster:
$ curl -v -H 'accept-encoding: identity' -o /tmp/out.pkl 'http://10.xx.xx.xx/render/?local=1&format=raw&from=1444249200&until=1444249440&target=carbon.agents.xx.errors'
...
$ cat /tmp/out.pkl
carbon.agents.xx.errors,1444249260,1444249500,60|0.0,0.0,0.0,0.0

Unpatched cluster:
$ curl -v -H 'accept-encoding: identity' -o /tmp/out.pkl 'http://10.xx.xx.xx/render/?local=1&format=raw&from=1444249200&until=1444249440&target=carbon.agents.xx.errors'
...
$ cat /tmp/out.pkl
carbon.agents.xx.errors,1444249260,1444249500,60|0.0,0.0,0.0,0.0

What's the storage schema setting for that DB?

[default_1_min_30_days_15_min_1_year_1hour_5years_24hours_10years]
priority = 100
pattern = .*
retentions = 60:30d,900:1y,3600:5y,90000:10y

Ah, I tested carbon, that's my fault, of course. :(
[carbon]
pattern = ^carbon\.
retentions = 60:90d

You're right, nice catch and nice patch to have in 0.9.14, indeed

What do other contributors think?
@obfuscurity @SEJeff @brutasse ?

PS: Jack published article about issue - http://linuxczar.net/blog/2015/10/11/scaling-graphite-3/
In my PROD cluster I saw network traffic drop for 15-30% between frontends and backends (and I'm using internal HTTP deflate patch for compression) after applying this patch - but I'm not monitoring response time though.
Not sure about right way to patch this issue - but maybe this patch worth to apply for 0.9.14...

Why wouldn't we simply return None here instead of an invalid datapoint?

I am curious what sort of queries you're using that are causing the time boundaries to be the same. Yes, it's technically possible to hit this if your from and until values are within the same interval, but it seems like something you wouldn't hit routinely.

@obfuscurity: Shouldn't we simply return None here instead of an incorrect datapoint?

Maybe that even better - simply
if fromInterval == untilInterval:
  return None

But strictly speaking it's also wrong.
Maybe we need to pick previous point instead?
if fromInterval == untilInterval:
  fromInterval = fromInterval - archive['secondsPerPoint']

I'm quite confused by this issue tbh :)

@jjneely Could you tell me if you still experience that wrap-read problem with your fix reverted and https://github.com/jjneely/whisper/blob/0.9.x-zero-length-time-range/whisper.py#L753 fixed to:
diff = untilTime - fromTime

P.S. I'm convinced that line above is a bug. It might not have any effect on your condition but I'd love to hear either way.

/cc @SEJeff

+1 for what @obfuscurity says. It would be interesting to see the differences with that. Also @jjneely what are your storage schemas you're using to see this issue?

@deniszh:
But strictly speaking it's also wrong.
Maybe we need to pick previous point instead?

If I understand the scenario properly, we're talking about queries where the range (untilTime - fromTime) is smaller than the highest precision archive. In this case I believe returning None is the right answer. Why would you return a) a datapoint that doesn't represent the actual interval, or b) a datapoint that doesn't represent the entirety of that interval? It's misleading at best.
If I don't understand the scenario correctly (which is possible since I don't know what @jjneely's schema looks like), please clarify.
I propose a new patch that:

uses if fromInterval == untilInterval: return None
also fixes diff = untilTime - fromTime in the preceding lines

@jjneely No need to test the 2nd item, I've tested and verified it has no effect on your scenario. Regardless, it looks like an obvious bug that we should clean up ASAP.
Here we can see the impact of both approaches. None of them are what I'd consider conclusive in so much as they're absolutely the right fix, but I think there's no doubt that we need to make a change here.

Note to all interested parties: this is the last showstopper issue before we tag the next 0.9.x release. The sooner we can get this resolved, the better. :wink:

So, my main offender here was from=-4min queries against 5min interval data:
[5min]
pattern = ^5min\.*
retentions = 5m:760d

I considered / tested returning None in this case.  I'm completely fine with that option if that's what we want to do.  However, I opted to return the next datapoint because that seemed more in line with other query behavior and didn't affect existing graphs/dashboards.  The -4min queries, in all cases, returned one valid data point.  3 cases:

Query returns the valid data point at a 5min interval that occurs within the 4min bounds on the query.
The query returns the next valid data point after the 4min time bounds when the start time bound falls directly on a 5min interval.  Another case of returning a DP outside the given time bounds.
This bug is the third case.  Before the patch the whisper DB would adjust the start/end bounds to the next 5min interval outside the bounds and the adjusted bounds would be equal.  So the first value in the returned list was used by the webapp (even though there was more data in the list).

I decided to try to match the existing behavior.

@jjneely Seems reasonable enough. I really do appreciate all the work you put into diagnosing and identifying this behavior. I'm going to merge this in as-is and then patch the other issue separately.
@deniszh Do you mind testing and porting this to master?


Add modifiable scheme to client settings struct

Modifies Settings struct to contain trackable/modifiable scheme field
Enables us to move scheme initialization from clients pkg to each resources' respective pkg
Allows the client to be more lightweight and only aware of resource schemes upon accessing a resources' NewBuilder or Pull functions

/cc @kononovn

@trewest Can you change PR header/commit message to:
client: Add modifiable scheme to settings struct


refactor: restructure packages to improve extensibility

This change splits the System.IO.Abstractions package into TestableIO.System.IO.Abstractions and TestableIO.System.IO.Abstractions.Wrappers. The former contains just the interfaces and the latter the default wrapper implementations. The package System.IO.Abstractions still exists as meta package to reduce impact on existing users. The same applies to TestableIO.System.IO.Abstractions.TestingHelpers.
BREAKING CHANGE: This refactoring moves all types to the TestableIO.System.IO.Abstractions library. Users might need to recompile their libraries.

@vbreuss Could you have a quick look at this?

@vbreuss Could you have a quick look at this?

@fgreinacher : I finished my review :-)

Thanks for your comments @vbreuss, ready for round 2⃣

Thanks for the quick review @vbreuss!

What is the Benchmarks project?
Should it also have the "TestableIO" prefix?

It contains some performance benchmarks. I will also add the prefix there!

It seems I can't resolve conversations or did I just not find the corresponding button?

I guess that's because you're not member of the organization. If you're interested helping out here, just say so and I'll add you as collaborator.

I guess that's because you're not member of the organization. If you're interested helping out here, just say so and I'll add you as collaborator.

@fgreinacher : I would be happy to help out!

I guess that's because you're not member of the organization. If you're interested helping out here, just say so and I'll add you as collaborator.

@fgreinacher : I would be happy to help out!

Cool thanks, I added you to the project!


Enable differentiated error messages for DR eligibility

Description
Addresses cases when DR eligibility checks fail on the API side, but the DR Action was not able to differentiate and supply specific instruction to end users.

Done - and I just bumped the v1 tag to latest. FYI - this might pick up more commits than just my own ❗ it looks like it was still pinned to the original init commit for this repo. I'm watching the API graphs today 🤞 should be fine?

@elireisman v1 was used for launch, but going forward we plan to use semver for this Action. Next release should be 1.0.1. Changes on v1 should still be picked up I think.


Android: Setting top border radius breakes visibility of side borders

Description
Left or right border visibility is broken when accordingly borderTopLeftRadius or borderTopRightRadius style property is applied.
Tested on fresh React Native 0.71.0 project with Pixel 3XL emulator and Redmi Note 7 real device.

React Native Version
0.71.0
Output of npx react-native info
System:
OS: macOS 12.0.1
CPU: (8) x64 Intel(R) Core(TM) i5-8259U CPU @ 2.30GHz
Memory: 80.16 MB / 16.00 GB
Shell: 5.8 - /bin/zsh
Binaries:
Node: 19.7.0 - /usr/local/bin/node
Yarn: 1.22.10 - /usr/local/bin/yarn
npm: 9.5.0 - /usr/local/bin/npm
Watchman: 2<IP_ADDRESS> - /usr/local/bin/watchman
Managers:
CocoaPods: Not Found
SDKs:
iOS SDK:
Platforms: DriverKit 21.2, iOS 15.2, macOS 12.1, tvOS 15.2, watchOS 8.3
Android SDK: Not Found
IDEs:
Android Studio: 2022.1 AI-221.6008.13.2211.9514443
Xcode: 13.2.1/13C100 - /usr/bin/xcodebuild
Languages:
Java: 11.0.18 - /usr/bin/javac
npmPackages:
@react-native-community/cli: Not Found
react: 18.2.0 => 18.2.0
react-native: 0.71.0 => 0.71.0
react-native-macos: Not Found
npmGlobalPackages:
react-native: Not Found
Steps to reproduce

Start fresh React Native project version 0.71.0 and apply styles from code example

Snack, code example, screenshot, or link to a repository
import React from 'react';
import type {PropsWithChildren} from 'react';
import {
  SafeAreaView,
  ScrollView,
  StatusBar,
  StyleSheet,
  Text,
  useColorScheme,
  View,
} from 'react-native';

import {Colors, Header} from 'react-native/Libraries/NewAppScreen';

type SectionProps = PropsWithChildren<{
  title: string;
}>;

function Section({children, title}: SectionProps): JSX.Element {
  const isDarkMode = useColorScheme() === 'dark';
  return (
    <View style={styles.sectionContainer}>
      <Text
        style={[
          styles.sectionTitle,
          {
            color: isDarkMode ? Colors.white : Colors.black,
          },
        ]}>
        {title}
      </Text>
      <Text
        style={[
          styles.sectionDescription,
          {
            color: isDarkMode ? Colors.light : Colors.dark,
          },
        ]}>
        {children}
      </Text>
    </View>
  );
}

function App(): JSX.Element {
  const isDarkMode = useColorScheme() === 'dark';

  const backgroundStyle = {
    backgroundColor: isDarkMode ? Colors.darker : Colors.lighter,
  };

  return (
    <SafeAreaView style={backgroundStyle}>
      <StatusBar
        barStyle={isDarkMode ? 'light-content' : 'dark-content'}
        backgroundColor={backgroundStyle.backgroundColor}
      />
      <ScrollView
        contentInsetAdjustmentBehavior="automatic"
        style={backgroundStyle}>

        <View
          style={{
            backgroundColor: isDarkMode ? Colors.black : Colors.white,
          }}>

          <View style={styles.bordersContainer}>
            <View style={styles.blackTopBorder} />
            <View style={styles.redTopBorder} />
          </View>

          <View style={styles.bordersContainer}>
            <View style={styles.blackBottomBorder} />
            <View style={styles.redBottomBorder} />
          </View>
          <View />
        </View>
      </ScrollView>
    </SafeAreaView>
  );
}

const styles = StyleSheet.create({
  sectionContainer: {
    marginTop: 32,
    paddingHorizontal: 24,
  },
  sectionTitle: {
    fontSize: 24,
    fontWeight: '600',
  },
  sectionDescription: {
    marginTop: 8,
    fontSize: 18,
    fontWeight: '400',
  },
  highlight: {
    fontWeight: '700',
  },
  redTopBorder: {
    width: 50,
    height: 50,
    borderColor: 'red',
    borderTopWidth: 4,
    borderRightWidth: 4,
    borderTopRightRadius: 10,
    margin: 10,
  },
  blackTopBorder: {
    width: 50,
    height: 50,
    borderColor: 'black',
    borderTopWidth: 4,
    borderLeftWidth: 4,
    borderTopLeftRadius: 10,
    margin: 10,
  },
  redBottomBorder: {
    width: 50,
    height: 50,
    borderColor: 'red',
    borderBottomWidth: 4,
    borderRightWidth: 4,
    borderBottomRightRadius: 10,
    margin: 10,
  },
  blackBottomBorder: {
    width: 50,
    height: 50,
    borderColor: 'black',
    borderBottomWidth: 4,
    borderLeftWidth: 4,
    borderBottomLeftRadius: 10,
    margin: 10,
  },
  bordersContainer: {
    flexDirection: 'row',
    marginLeft: 30,
  },
});

export default App;

I'm experiencing the same issue.

Same issue on Rn version 0.71.6

hey folks - just a quick update on this, while discussing https://github.com/facebook/react-native/issues/37753 we realized that that the problem reported here is also in effect, so there's a proposed solution out atm (https://github.com/facebook/react-native/pull/37840) and once we verify that it works, we'll also backport to 0.71 - in fact, I've already added a comment about it in the 0.71 patch release discussion -> https://github.com/reactwg/react-native-releases/discussions/70#discussioncomment-6161551

did a quick local test and the revert fixes the problem:

expect this to be fixed in the next patch for 0.71, 0.71.11

Do you still experience this issue?
I have four years of experience maintaining facebook/react-native and I specialize in the Text and TextInput components. I currently have 58 facebook/react-native PRs.
If you still experience this issue, I will prepare a patched release with the fix.
Thanks a lot


Implement a Virtual Try-On System (VITON) for Clothes

Description:
We aim to build a virtual try-on system, called VITON, that allows users to see how clothes would look on them in a 2D image, without using 3D models. The system first generates a rough approximation of the user wearing the selected clothing and then refines the image to produce realistic, detailed results. This will provide an efficient and interactive way for users to "try on" different outfits virtually.
Task Overview:

Implement a deep learning model that takes as input a photo of a user and an image of clothing and outputs a realistic image of the user wearing the clothing.

Use a two-step process where the system first generates a rough image and then enhances the details to improve realism.

Focus on maintaining the proportions, texture, and draping of the clothing as it would appear on the user in real life.

i want to contribute this can you please assign me

@Charul00 proceed!

assign me this work, I have worked on this and I want to contribute

@alo7lika Go ahead with the work. Best submission will be finally merged

@SaiNivedh26 Thank you!

@UppuluriKalyani i am interested to work on this issue can you assign me

@UppuluriKalyani i am interested to work on this issue can you assign me

Proceed

@UppuluriKalyani i am interested to work on this issue can you assign me

Proceed

does this issue involve API and CUDA operations

@UppuluriKalyani i am interested to work on this issue can you assign me

Proceed

does this issue involve API and CUDA

@UppuluriKalyani i am interested to work on this issue can you assign me

Proceed

does this issue involve API and CUDA operations

Yes, this project should use APIs for connecting the model to the system, and CUDA operations are needed to make the image processing faster and more efficient.


New release with library loading fix

Hi :) would it be possible to release a new version with the #17 fix?

Hi, Done, Sorry for my late replying


[projects] Sort dropdown should change with list view sorting

Describe the bug
On carbonmark on the projects view, when you sort the list view columns the sort dropdown should switch to the sorted value.
To Reproduce
Steps to reproduce the behavior:
** Note - can't reproduce on production at the moment until https://github.com/KlimaDAO/klimadao/pull/1956 is merged as it contains an additional fix for the list view immediately switching back to grid view after trying to sort the table view.

Go to projects
Click on the list view icon
Sort the list view table by Vintage
The sort dropdown doesn't update

Expected behavior
When clicking on vintage or any other sortable column, the sort dropdown should update to reflect the sorted column
Screenshots
If applicable, add screenshots to help explain your problem.
Desktop (please complete the following information):

OS: macOs
Browser: Brave

closing as part of https://github.com/Carbonmark/monorepo/pull/712


calculate password strength

-Used entropy to calculate password strength and applied a secure randomness API (crypto.getRandomValues) for generating passwords.

m


Native drivers support

Thanks a lot for your contribution @Grivel-l. I was willing to investigate nativeDriver myself, and this PR will make it easier.
I'm a little overwhelmed with work recently. I'll review and hopefully merge this PR when I have some free time.

:+1:

I finally got a chance to test this out.
Kohana is working almost identical, I'll definitely merge that.
I understand the limitation of native driver for Sae. It changes the animation currently. I'll try finding a solution for that one.
Jiro is working fine on Android but the input exceeds it's height on iOS when it's in active state. I am trying to find a fix for that but haven't come up with a solution yet. Can you also test it on iOS?

Sorry, I forgot to specify, I can't test it on iOS

No problem @Grivel-l. Could you close this PR and open one just for Kohana, so I can merge it right away.
I'll take a look at Sae and Jiro when I have some more free time.

Yep, will do it when I have some free time


Request body with non ASCII characters is rejected

When I tried to submit user info with non ASCII characters, in my specific instance it was a ß which is very common in German street names, the request was rejected with the error message invalid_request_error: Poorly formed JSON request body..
The problem is that the stringified JSON body has a different content length than passed in the request when non ASCII characters are present. A fix for this problem was done by someone else here:
https://github.com/sentientwaffle/blockscore-node/commit/61fa874e41c5dc154145205aad8c79e41bbe8940
This is a critical issue since Blockscore is targeted to non US citizens, too, and with this issue it's not possible to enter characters that are common in other languages.

Hi @DenisStad are you using the latest version of blockscore-node? I believe the content length issue you're referring to (#25) was resolved in #30 and released in version 4.0.3.
If you are using 4.0.3 and you still have this issue, could you add a small, executable code sample that reproduces the bug?
Thanks!


chore: Updated Node Agent init container

This PR adds build args to the Dockerfile for Node, letting us target agent versions and runtimes via GHA matrices. (Creating  this workflow is a next step.)
This removes TypeScript from the Node directory--the agent isn't written in TypeScript, and does not need a build step.

Closing this to avoid duplication--this is just the POC, rather than the operator repo being developed.

@hmstepanek I've updated a couple nodejs/* files, if you don't mind taking another look.

@mrickard I moved the files into the src/ directory with the latest commit on main, I think you'll have to merge that in locally and push up a commit to fix the merge conflicts.

Thank you  @TimPansino ! I'll update this.


Tested, validated, updated narrative on DLPy_Import_Onnx_Model.jpynb example.

Validated the code and various Python and ONNX library modules used in the code.
Able to run from end to end. Updated and path-anonymized for DLPy example publication.

@yg2288 would you please take a look at to see everything is fine by you.

Looks good to me.  Great work, thanks!

Please consider only the most recent PR for today. Adding final changes requested by docair.

Replaced by pull request #317.


VS Code ignores the 2 space indent setting

Issue Type: Bug

Behaviour
I've tried using the following settings, and I still got the code formatted into 4 space indents, not 2.
  "editor.tabSize": 2,
  "editor.insertSpaces": false,
  "editor.detectIndentation": false,

Expected vs. Actual
I expected 2 space indents, but the formatter kept making them 4.
Steps to reproduce:

Install the Python extension
Configure VS Code to use 2 space indentation
Open a Python file with 2 space indentation and format it. All the indents turned into 4 spaces.

I do have a workaround, it seems these autopep8 settings work:
"python.formatting.autopep8Args": [
    "--indent-size=2",
    "--ignore E121"
]

Diagnostic data

Python version (& distribution if applicable, e.g. Anaconda): 3.7.3
Type of virtual environment used (e.g. conda, venv, virtualenv, etc.): Global
Value of the python.languageServer setting: Default

User Settings

defaultLS: {"defaultLSType":"Jedi"}

downloadLanguageServer: true

envFile: "<placeholder>"

venvPath: "<placeholder>"

venvFolders: "<placeholder>"

condaPath: "<placeholder>"

pipenvPath: "<placeholder>"

poetryPath: "<placeholder>"

languageServer: "Jedi"

linting
• enabled: false
• cwd: "<placeholder>"
• Flake8Args: "<placeholder>"
• flake8Enabled: false
• flake8Path: "<placeholder>"
• lintOnSave: false
• banditArgs: "<placeholder>"
• banditEnabled: false
• banditPath: "<placeholder>"
• mypyArgs: "<placeholder>"
• mypyEnabled: false
• mypyPath: "<placeholder>"
• pycodestyleArgs: "<placeholder>"
• pycodestyleEnabled: false
• pycodestylePath: "<placeholder>"
• prospectorArgs: "<placeholder>"
• prospectorEnabled: false
• prospectorPath: "<placeholder>"
• pydocstyleArgs: "<placeholder>"
• pydocstyleEnabled: false
• pydocstylePath: "<placeholder>"
• pylamaArgs: "<placeholder>"
• pylamaEnabled: false
• pylamaPath: "<placeholder>"
• pylintArgs: "<placeholder>"
• pylintPath: "<placeholder>"

sortImports
• args: "<placeholder>"
• path: "<placeholder>"

formatting
• autopep8Args: "<placeholder>"
• autopep8Path: "<placeholder>"
• provider: "autopep8"
• blackArgs: "<placeholder>"
• blackPath: "<placeholder>"
• yapfArgs: "<placeholder>"
• yapfPath: "<placeholder>"

testing
• cwd: "<placeholder>"
• debugPort: 3000
• nosetestArgs: "<placeholder>"
• nosetestsEnabled: undefined
• nosetestPath: "<placeholder>"
• promptToConfigure: true
• pytestArgs: "<placeholder>"
• pytestEnabled: false
• pytestPath: "<placeholder>"
• unittestArgs: "<placeholder>"
• unittestEnabled: false
• autoTestDiscoverOnSaveEnabled: true

terminal
• activateEnvironment: true
• executeInFileDir: "<placeholder>"
• launchArgs: "<placeholder>"

experiments
• enabled: false
• optInto: []
• optOutFrom: ["All"]

tensorBoard
• logDirectory: "<placeholder>"

Extension version: 2022.4.1
VS Code version: Code 1.66.2 (Universal) (dfd34e8260c270da74b5c2d86d61aee4b6d56977, 2022-04-11T07:49:20.994Z)
OS version: Darwin x64 21.4.0
Restricted Mode: No

System Info

Item
Value

CPUs
Intel(R) Core(TM) i7-8569U CPU @ 2.80GHz (8 x 2800)

GPU Status
2d_canvas: enabledcanvas_oop_rasterization: disabled_offdirect_rendering_display_compositor: disabled_off_okgpu_compositing: enabledmetal: disabled_offmultiple_raster_threads: enabled_onoop_rasterization: enabledopengl: enabled_onrasterization: enabledraw_draw: disabled_off_okskia_renderer: enabled_onvideo_decode: enabledvideo_encode: enabledwebgl: enabledwebgl2: enabled

Load (avg)
5, 7, 5

Memory (System)
16.00GB (0.02GB free)

Process Argv
--crash-reporter-id 0fbfa090-c28e-4504-bc4c-e0f3ff5ff1ad

Screen Reader
no

VM
0%

A/B Experiments
vsliv368cf:30146710
vsreu685:30147344
python383:30185418
vspor879:30202332
vspor708:30202333
vspor363:30204092
pythonvspyl392:30443607
pythontb:30283811
pythonptprofiler:30281270
vshan820:30294714
vstes263:30335439
vscoreces:30445986
pythondataviewer:30285071
vscod805cf:30301675
pythonvspyt200:30340761
binariesv615:30325510
bridge0708:30335490
bridge0723:30353136
vsaa593cf:30376535
vsc1dst:30438360
pythonvs932:30410667
wslgetstarted:30449410
pythonvsnew555:30457759
vscscmwlcmt:30465135
cppdebug:30475216

Turning this into a feature request since we never supported this.
Thanks for the feature request! We are going to give the community 60 days from when this issue was created to provide 7 👍 upvotes on the opening comment to gauge general interest in this idea. If there's enough upvotes then we will consider this feature request in our future planning. If there's unfortunately not enough upvotes then we will close this issue.

@karthiknadig Y'all did support this.   "editor.tabSize": 2, exists and is explained in the docs. But it doesn't work with Python since VS Code chose to use autopep8.

@ubershmekel we never supported deep integration like converting editor tab size setting to autopep8 specific setting. The docs are about the editor itself, and not specific to python or the tools that python extension works with. so when you use those settings, it might work until formatting is triggered (either on save or manually) and that will result in autopep8 doing the changes without considering the values used by the editor.

Thank you for submitting your feature request and everyone who considered it! Unfortunately this issue did not receive enough votes over the allotted time, and so we are closing the issue.
We are also moving out our support for linters into standalone extensions, so this would eventually be a feature request for our separate autopep8 extension (which we have not created yet).


CC-1177 Search web terraform ecs, .env file changes

CI: No IaC security warnings found

CI: No IaC security warnings found

CI: No IaC security warnings found

CI: No IaC security warnings found


Manifest V3 Support

Migrated the extension to Manifest V3.
Options page:

Improved the layout slightly.
Changed all links to open in a new tab.
Fixed some broken GitLab links.

Removed old unneeded code.
Bumped the extension version to <IP_ADDRESS>.

Thanks for this! will take a look later

Welcome!
I understand that the secret uncovered is actually an old token that I removed from the extension and so it's appearing in the commit and that's why GitGuardian is not completely happy but I don't think it's a problem. I'm sure you must have revoked it a long time ago.
However, I have no idea why the build-and-test is failing. I've personally been using my modified version of the extension and it's working fine so far.


[$2000] No padding below in add personal message on adding of new line on web

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Action Performed:

Open the app on web chrome or web safari
Open settings
Open workspaces
Open any workspace
Open manage member
Click on invite
Add new text below current personal message

Expected Result:
App should keep some padding below text on web chrome and web safari as it does on android app, android chrome
Actual Result:
App does not provide any padding below text on web chrome and web safari
Workaround:
Can the user still use Expensify without this being fixed? Have you informed them of the workaround?
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android / native
[ ] Android / Chrome
[ ] iOS / native
[ ] iOS / Safari
[x] MacOS / Chrome / Safari
[ ] MacOS / Desktop

Version Number: 1.3.0
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
https://user-images.githubusercontent.com/43996225/232320495-f1926979-5ec6-4378-8530-993961a205d8.mp4
https://user-images.githubusercontent.com/43996225/232320497-e5656c06-12dd-44f0-b14d-b935225c129e.mp4

Expensify/Expensify Issue URL:
Issue reported by: @dhanashree-sawant
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1681549363487719
View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01b88f4f183ff1d0c5
Upwork Job ID:<PHONE_NUMBER>667062272
Last Price Increase: 2023-04-26

Triggered auto assignment to @twisterdotcom (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

Bug0 Triage Checklist (Main S/O)

[ ] This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
[ ] This bug is not a duplicate report (check E/App issues and #expensify-bugs)

If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead

[ ] This bug is reproducible using the reproduction steps in the OP. S/O

If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
If the reproduction steps aren't clear and you determine the correct steps, please update the OP.

[ ] This issue is filled out as thoroughly and clearly as possible

Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.

[ ] I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

Job added to Upwork: https://www.upwork.com/jobs/~01b88f4f183ff1d0c5

Current assignee @twisterdotcom is eligible for the External assigner, not assigning anyone new.

Proposal
Please re-state the problem that we are trying to solve in this issue.
No padding below in add personal message on adding of new line on web
What is the root cause of that problem?
WorkspaceInvitePage uses TextInput which uses baseTextInput for style. this baseTextInput has a paddingBottom of 8 and while that works fine for one line text, the moment you go to the next line the issue observed in this post issue will occur.
https://github.com/Expensify/App/blob/f50afdfd5fb2c2e9582cd86ee94e61402f33e90e/src/pages/workspace/WorkspaceInvitePage.js#L342-L352
https://github.com/Expensify/App/blob/f50afdfd5fb2c2e9582cd86ee94e61402f33e90e/src/styles/styles.js#L834-L843
What changes do you think we should make in order to solve the problem?
A way to fix this is to also add marginBottom: 8 to the baseTextInput which will preserve the spacing as the user shift enters to the next lines
baseTextInput: {
    fontFamily: fontFamily.EXP_NEUE,
    fontSize: variables.fontSizeNormal,
    lineHeight: variables.lineHeightXLarge,
    color: themeColors.text,
    paddingTop: 23,
    paddingBottom: 8,
    marginBottom: 8,  << Added margin
    paddingLeft: 0,
    borderWidth: 0,
},

What alternative solutions did you explore? (Optional)
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

Triggered auto assignment to Contributor-plus team member for initial proposal review - @parasharrajat (External)

Proposal
Please re-state the problem that we are trying to solve in this issue.
No padding below in add personal message on adding of new line on web
What is the root cause of that problem?
No padding bottom of TextInput if it has multiple line.
https://github.com/Expensify/App/blob/74d5290dd95500b86f8b4f384b18b9aca87364a2/src/components/TextInput/BaseTextInput.js#L293
What changes do you think we should make in order to solve the problem?
Add styles.pb1 after (!hasLabel || this.props.multiline) && styles.pv0 to set padding bottom of TextInput if it has multiple line
What alternative solutions did you explore? (Optional)
NA
Result
Screencast from 17-04-2023 17:34:57.webm

Triggered auto assignment to @thienlnam (External), see https://stackoverflow.com/c/expensify/questions/7972 for more details.

Proposal
Please re-state the problem that we are trying to solve in this issue.
No padding below in add personal message on adding of new line on web
What is the root cause of that problem?
No padding bottom of TextInput if it has multiple line.
https://github.com/Expensify/App/blob/74d5290dd95500b86f8b4f384b18b9aca87364a2/src/components/TextInput/BaseTextInput.js#L293
What changes do you think we should make in order to solve the problem?
Add styles.pb1 after (!hasLabel || this.props.multiline) && styles.pv0 to set padding bottom of TextInput if it has multiple line
What alternative solutions did you explore? (Optional)
NA
Result
Screencast from 17-04-2023 17:34:57.webm

Proposal
Please re-state the problem that we are trying to solve in this issue.
No padding/space between the container border and the textInputContainer content
What is the root cause of that problem?
We are not providing any padding to the textInputContainer which will make the content to the bottom border of it and that leads to no space between border and content.
What changes do you think we should make in order to solve the problem?
Add the bottom padding of 8px when the textInput is multiline with this.props.multiline && styles.pb2 below.
https://github.com/Expensify/App/blob/c552dce3fbffc70bea24bbfef313c623de5db4ea/src/components/TextInput/BaseTextInput.js#L232-L242
Result
https://user-images.githubusercontent.com/14358475/233137297-a1007811-0c13-4d4e-9e50-cc4ba0a9d2bc.mp4

I've tested and the problem is present in all platforms including android but because of different ways automatic spacings go the issue is less obvious on android but when adding the additional marginBottom I could see the difference on android as well and it makes the styling looks more consistent.
When it comes to multiline TextInputs not having padding, the parent wrapper of the composer for example does have padding here:
textInputComposeSpacing: {
    paddingVertical: 5,
    ...flex.flexRow,
    flex: 1,
},

Meanwhile the textInput we are working on here, the wrapper parent element does not have a padding bottom. I tried adding padding bottom to it and it started behaving similar to the composer when it comes to spacing on the bottom but the whole text input is structured differently for different purpose so I don't see adding padding on the bottom for the parent to be a good thing because it changed the way the textInput looks adding extra space underneath the autofilled welcomeNote.

I have edited my proposal to clarify everything I managed to figure out, I apologize for the long proposal and the number of photos attached but the issue is a bit difficult to explain.

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

This is a pretty obscure bug, going to increase for some more eyes

Upwork job price has been updated to $2000

It's true that adjusting minHeight is not a solution and a better solution would be to use a more responsive design kind of approach, I must point out however that I've tested on a new empty native project using TextInput and minHeight and it seemed like Android devices I test on all behaved normally without this issue. makes me think that there is a line of code somewhere that is causing the weird behaviour of minHeight spacing on some androids, perhaps it could be the autogrow being used. also it's worth pointing out that the issue of having no padding underneath the text for multiline inputs, although it seem by design it does look inconsistent since throughout the app all TextInputs will have spacing between the text and the green border underneath. I feel like when the multiline TextInput was coded in the developers ran into an issue where setting up padding caused the welcomeNote to initially look incomplete as the TextInput has a scrollbar and a part of the welcomeNote was being covered because of that, so perhaps they decided on removing padding and adding minHeight to make sure the welcomeNote shows fully and maybe gave it a bit extra minHeight so it doesn't stick very close to the bottom border. but this is just speculation on my part. however whatever might be the reason this decision was made, the text the user type does stick very close to the bottom border for chrome and ios.

@parasharrajat Sure thing, here's the Snack: https://snack.expo.dev/@amjednazzal/multiline-test

@parasharrajat as numberOfLines for the TextInput is only supported by the android, it only takes height of (numberOfLines * lineHeight) and rest it is ignoring and currently minHeight is incorrectly given without considering bottom padding, that's why we are seeing issue in other platforms.
For eg. for this invite textinput we have given height 115px, considering 4 numberOfLines which will required height of (4*20 lineheight) + paddingTop(23) + bottom border(2) = 105px. Still we have 10px more which we need to provide as bottom padding to make it consistent across all platforms.

@parasharrajat even though if we won't provide, it is considering it as a empty space, so I think giving correct padding won't make any harm.

@parasharrajat and @thienlnam - what's your honest opinion on this then? It seems like this is genuinely more hassle than it's worth to solve and that was kind of what I was worried about when I asked about it internally.
@michaelhaxhiu what do you think? This seems like something that will cause zero impact to the user, and that no real user will complain about. I'd prefer we close this and focus our efforts elsewhere, especially given the sheer volume of other bugs we're seeing recently.
I love the idea of parity between platforms, but I think given the weirdly complex nature here, we should just close.

I love the idea of parity between platforms, but I think given the weirdly complex nature here, we should just close.

Sorry to comment here but I think consistency can be achieved with minimal changes(as numberOfLines is not supported except android).

Looking

Ok I reviewed this all again and I stand by what I said earlier - I think we should fix it. If you want to make a case to close it, that's totally fine and you can do that in #expensify-bugs. But I think consistency of newExpensify across platforms is worth the squeeze (e.g. the price of this job).

@thienlnam - sounds good to me. Give us a 👍 and I'll assign @Pujan92.

Thank you @parasharrajat, sure if @Pujan92 feels okay about that and so does everyone internally then I'd also be happy with that, again thanks for understanding!

I don't think it's crude at all to ask @AmjedNazzal. I think 50% each is fair, so $1000 each when it's deployed without regression. @thienlnam once you've 👍 let's get @Pujan92 assigned.
Note, we'll only provide the bonus for @Pujan92 and @parasharrajat as the PR submitter and reviewer though.

Yes, I am fine with the team's decision to split the fair. Just to confess I haven't actually inspired or checked your solution @AmjedNazzal before posting my updated proposal. I started looking into it after @parasharrajat made a point of the padding only seen for android.

This issue should be closed as it is outdated . This Pr #15672 has Implemented a new Workspace members invite message page.

@fedirjh I think that isn't solved this issue(padding between the border and the content of textinput).

We could wait until that hits staging and test before assigning then.

@Pujan92 I apologize for the assumption then. if your solution didn't build on top of the discussion we were having here then you have the right to the full fair.

Going to make it weekly since it has a hold on an internal PR. We'll wait for it to hit Prod for a few days before upholding.

Handy having @parasharrajat here. Has this has resolved our issue? It kind of seems like maybe we've removed padding for consistency, which I think is fine if consistency is the goal:

@twisterdotcom I think the idea for this issue is that we need to add padding for the multiline to make it consistent with the text inputs.

I kind of want to ask why though. If the multi-line inputs are all consistent, isn't that fine @shawnborton?

First, I just want to call out that this expected result is not very clear:

App should keep some padding below text on web chrome and web safari as it does on android app, android chrome

@dhanashree-sawant when you write these, do you mind adding some more detail so it's easier to catch up? For example, on which exact page or component should there be padding?

Hmm I kind of think it's fine. They are different components.

Cool, I agree! I think we can pay out @dhanashree-sawant for the bug report, but as this was "fixed" (the multi-line input is now consistent across platform) by a different PR in the end, we can close this after that.
How does that sound @parasharrajat?

Hi @shawnborton, sure I will ensure to be more specific in my future bug reports.

I always love doing nothing. Let's just close it.

Hi @twisterdotcom, you had pointed out to pay me for reporting, am I eligible for it?

Okay, let's reopen and pay out for reporting and work on determining we could close.
@dhanashree-sawant are you able to apply for $250?
@parasharrajat are you able to apply for $500?
https://www.upwork.com/jobs/~01b88f4f183ff1d0c5

Thanks @twisterdotcom, I have applied to the upwork post.

Not sure how these got lost. I sent the offers again, because I don't see them in my Upwork account folks.

Thanks @twisterdotcom, I have accepted the offer, similarly, 15541 is also pending at same awaiting payment stage. Can you check that too if you are available?

All paid out.


Feature Request: Group infos

Would be nice as User to get an option to see some descriptive text about the Group you've clicked on.
These can be simple descriptions to get some idea what the group is about or what the kink is about.

Closing this ticket since there is no plan to maintain this application much further.
Thanks for your suggestion and have a great day!


RouteBase.EnsureLoggers race condition

Describe the bug
I'm on the Azure Functions team and we see a very rare NullRef with this stack:
System.ArgumentNullException : Value cannot be null.
Parameter name: logger
   at Microsoft.AspNetCore.Routing.RouteConstraintMatcher.Match(IDictionary`2 constraints,RouteValueDictionary routeValues,HttpContext httpContext,IRouter route,RouteDirection routeDirection,ILogger logger)
   at Microsoft.AspNetCore.Routing.RouteBase.RouteAsync(RouteContext context)

I've looked into the issue (I thought it was a race on our end) but found that _constraintLogger (in RouteBase) ends up being null, even with the call to EnsureLoggers() that should be making sure it's initialized.
private void EnsureLoggers(HttpContext context)
{
    if (_logger == null)
    {
        var factory = context.RequestServices.GetRequiredService<ILoggerFactory>();
        _logger = factory.CreateLogger(typeof(RouteBase).FullName);
        _constraintLogger = factory.CreateLogger(typeof(RouteConstraintMatcher).FullName);
    }
}

Imagine if the second CreateLogger() call here runs slowly (for any reason: Functions runs on a single core, file locks, etc -- it’d be rare, but possible). Now you’ve got _logger != null, but _constraintLogger == null.  If those two CreateLogger() lines were switched, it should fix it.
To Reproduce
See my test -- required some sempahore coordination, but proved that it's possible, but rare: https://gist.github.com/brettsam/6f60bfccba80d1515be9cfb13d0d985b

@JamesNK @rynowak

@brettsam - thanks for the thorough bug report. This is indeed a bug.
@mkArtakMSFT - we should consider a backport of this, it's a low risk fix for a functional bug.

@rynowak is this fixed in 3.0 already? Or are you referring to whatever that fix would be we should backport it?

Not fix yet, but it should be very easy.

I do have a PR for this out already.

we should consider a backport of this, it's a low risk fix for a functional bug.

FYI, after conversations with the Functions team, this is a very rare occurrence and they do not feel they need a backport. If it's something we still want to backport, that's fine.

Fixed in 3.0


don't pre-bind pods to nodes

1. Issue, if available:
Will update once it's not a draft
2. Description of changes:

Eliminate binding of pods to nodes
Register extended resources as an annotation

3. How was this change tested?
4. Does this change impact docs?

[X] Yes, PR includes docs updates
[ ] Yes, issue opened: link to issue
[ ] No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

The 5 minute timeouts are now gone along with the startup taint as it no longer served a purpose.  This lets us consider a node being ready when all of the following are true:

Kubelet marks it ready
All startup taints are removed
All extended resources are initialized

If this fails for 15 minutes, we terminate the node.


Review the way we're handling telegram responses

Seems that, when a telegram message fails, the entire operator crashes and the entire payload of that task is moved to the dead-letter in consequence.
We should check the way telegram messages are handled, specially, when they fail.

A workaround for this could be to set allowFailure to true by default in the telegram plugin. Although I don't like too much this solution.... I think we need to rethink how the promise chain responses are returned.


Update Rewind VDP

Summary
Update Rewind VDP info
Quality Assurance Checklist

Review Items
Y/N

Site has a publicly known bug bounty or vulnerability disclosure program
Y

Disclosure policy is publicly available
Y

Public URL
Y

Submission follows the Diodb schema
Y

Thanks for this update!


Fix RST errors, for pretty display on PyPI

Currently, the RST is not formatted correctly on PyPI's website:
https://pypi.python.org/pypi/django-ckeditor/5.2.2
This pull request fixes the RST to make it work on the PyPI website. It fixed the errors that this command printed:
python setup.py check --restructuredtext --strict --metadata

Thank you!


No data available

The first request seems to be successfull (about a month ago) but after that no new data was gathered.
When requesting the used URL (variant 4 JSON) in a browser I receive all the JSON that contains recent data. I deleted all the datapoints and waited for the next execution but only this single one was recreated. (daswetter.0.NextHours2.Location_1.Location)
I have two instances with different locations and both have the exact same issue. I can assist you searching the error in any way you'd like.
log:
`

daswetter.0
2018-10-01 21:18:04.608
debug
nothing to do

daswetter.0
2018-10-01 21:18:04.372
debug
back to list: NextHours2.Location_1.Location Uetersen

daswetter.0
2018-10-01 21:18:04.080
debug
objects in list: 2

daswetter.0
2018-10-01 21:18:04.078
debug
got undefined days

daswetter.1
2018-10-01 21:18:03.239
debug
objects in list: 2

daswetter.1
2018-10-01 21:18:03.237
debug
got undefined days

daswetter.1
2018-10-01 21:18:02.965
debug
calling forecast hourly JSON: http://api.daswetter.com/index.php?api_lang=de&localidad=105205&affiliate_id=xxxxxxxxxxxxxx&v=3.0

daswetter.1
2018-10-01 21:18:02.946
debug
using new datastructure

daswetter.1
2018-10-01 21:18:02.935
debug
checking data structures

daswetter.1
2018-10-01 21:18:02.931
debug
deleting unused dataset

daswetter.1
2018-10-01 21:18:02.930
debug
set timeout to 300 sec

daswetter.0
2018-10-01 21:18:02.938
debug
got 0 channels

daswetter.0
2018-10-01 21:18:02.934
debug
got 0 states

daswetter.0
2018-10-01 21:18:02.834
debug
calling forecast hourly JSON: http://api.daswetter.com/index.php?api_lang=de&localidad=27502&affiliate_id=xxxxxxxxxxxxxxx&v=3.0

daswetter.0
2018-10-01 21:18:02.817
debug
using new datastructure

daswetter.0
2018-10-01 21:18:02.808
debug
checking data structures

daswetter.0
2018-10-01 21:18:02.806
debug
deleting unused dataset

daswetter.0
2018-10-01 21:18:02.805
debug
set timeout to 300 sec

`

Can you try to disable one instance and check again? you run both instances at almost the same time... The log "got undefined days" says there are no data in json (or json has a different structure). So it would be good to see the json (probably logged in browser).

see also
https://forum.iobroker.net/viewtopic.php?f=20&t=18189#p190224


Add postgres 11

Checklist

[X] I've run make from the root directory to see all Dockerfiles are created successfully.
[X] I've updated the documentation if necessary.

Motivation and Context
follow-up on this PR https://github.com/circleci/circleci-images/pull/306

@bgentry

Dug through the log file, could only find these errors:
9.6.11-postgis-add-postgres-11-ba0206a2cb1c: digest: sha256:7ce660bb0973e62f0f4a6778ac32cb687c1b8418060896dbb05199c70dfbb017 size: 4286
handling alias 9.6-postgis
The push refers to a repository [docker.io/ccitest/postgres]
Get https://registry-1.docker.io/v2/: EOF
make[1]: *** [postgres/images/9.6.11/postgis/publish_image] Error 1
make[1]: Leaving directory `/home/circleci/circleci-bundles'

And then at the end of the build:
9.5-alpine-postgis-ram-add-postgres-11-ba0206a2cb1c: digest: sha256:bea7bee48670b5c4cb6ae5fcafa8baac1c45e413efa0073cf995f71746067a88 size: 3233
Untagged: ccitest/postgres:9.5-alpine-postgis-ram-add-postgres-11-ba0206a2cb1c
Untagged: ccitest/postgres:9.5.15-alpine-postgis-ram
~/circleci-bundles
make[1]: Leaving directory `/home/circleci/circleci-bundles'
make: *** [postgres/publish_images] Error 123
Exited with code 2

No idea on the cause though 😞

hmm, thank you ! @bgentry
the example tag's Docker Hub automated build may offer more guidance—it will be direct docker build output w/o any output swallowed by make. it's pending / queued rn but will take a look as soon as it's in-progress.

@bgentry do you specifically need postgres 11 with postgis ? i just noticed we already are building postgres 11 images :
https://hub.docker.com/r/circleci/postgres/tags?page=2
https://github.com/CircleCI-Public/circleci-dockerfiles/tree/master/postgres/images/11.1
https://github.com/CircleCI-Public/circleci-dockerfiles/tree/master/postgres/images/11.1-alpine

do you specifically need postgres 11 with postgis ?

Yeah, thanks for checking but that's what we need. RAM disk doesn't matter but figured it's faster.
Obviously if there are real failures or blockers to merging this then do it on whatever schedule you need, I can figure out an alternative if necessary! And lmk if there is in fact something I can do to help move it forward (such as building an image locally).

I also pushed the v11-postgis-ram variant to DockerHub on our org as distru/postgres:11.1-alpine-postgis-ram, and completed a CircleCI build with it successfully. Anyway, lmk if there's a specific one failing that I can look into :v:

@bgentry yup, things look good on our end too—the automated build with your changes was successful: https://hub.docker.com/r/ccitest/postgres/builds

@iynere yay, thanks! 🙏


Node SDK copy edit

@astha-jain

:tada: This PR is included in version 0.5.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


improve endpoint support

small PR to add a new interface endpoint behind a feature

Have you checked if the openapi is correctly created ? I think you forgot to add the structs to the utopia thing to generate them  properly, no ?

This PR does not compile.


<EMAIL_ADDRESS>download via aria2 failed

I am going to create a PR.

#3324 PR is created


RenderTexture.draw with tint: red/blue values inverted

Version

Phaser Version: v3.51.0-FB
Operating system: MacOS 11.1 (Big Sur)

Description

Looks similar to this issue (which was apparently fixed): https://github.com/photonstorm/phaser/issues/3643
Example Test Code

When I use sprite.setTint(0xff0000), the sprite is tinted red as expected:

However, when drawing the frame to a render texture with renderTexture.draw(frame, 0, 0, 1, 0xff0000), the texture is tinted blue:

I added a crude function to swap the red and blue values, and the output looks correct:
export const invertRB = (colour: number) => {
  const [r,g,b] = colour.toString(16).padStart(6, '0').match(/[\w]{2}/g);
  return parseInt([b,g,r].join(''), 16);
}

Sorry for the delay in responding, but I can confirm this is definitely working properly now (and has been for a few versions)


bump version from 0.2.3 to 0.2.4 in package.json

And could you push new version to npmjs?
Thanks.

This has been done, also deployed to npm


PJFCB-1931 Bumped up vulnerable dependencies versions to resolve CVE-2021-0341

Successful build: link


Default 20-deployment.yaml results in kudo-controller-manager crashloop when deploying zk and kafka

What happened:

Deployed default pre-req yamls from kudo.dev.
Deployed zk and kafka
kudo-controller-manager-0 crashloops with OOM error.

What you expected to happen:

kudo-controller-manager-0 should function with defaults.

How to reproduce it (as minimally and precisely as possible):

deploy default pre-reqs from kudo.dev
run k kudo install zookeeper --instance=zk --auto-approve
run k kudo install kafka --instance=kafka --parameter ZOOKEEPER_URI=zk-zookeeper-0.zk-hs:2181,zk-zookeeper-1.zk-hs:2181,zk-zookeeper-2.zk-hs:2181 --parameter ZOOKEEPER_PATH=/small -p BROKERS_COUNTER=3 --auto-approve

Result for k describe pod -n kudo-system kudo-controller-manager-0:
    State:          Waiting       Reason:       CrashLoopBackOff     Last State:     Terminated       Reason:       OOMKilled       Exit Code:    137       Started:      Mon, 22 Jul 2019 10:08:16 -0400       Finished:     Mon, 22 Jul 2019 10:08:26 -0400     Ready:          False     Restart Count:  3     Limits:       cpu:     100m       memory:  30Mi     Requests:       cpu:     100m       memory:  20Mi
Anything else we need to know?:
Bumped the yaml mem limit to 300Mi and it's all good.
Environment:

Kubernetes version (use kubectl version):
Client Version: v1.15.1
Server Version: v1.15.0
Kudo version (use kubectl kudo version):
KUDO Version: version.Info{GitVersion:"0.3.2", GitCommit:"81cbddc1", BuildDate:"2019-07-12T19:23:56Z", GoVersion:"go1.12.4", Compiler:"gc", Platform:"darwin/amd64"}
Operator:
operatorVersion:
Cloud provider or hardware configuration:
OS (e.g. from /etc/os-release):
Kernel (e.g. uname -a):
Install tools:
Konvoy_v0.5.0
Others:

we should definitely bump the requirements before the release


Server Compatibility

The documentation page Server Compatibility would benefit from links to the downloads to the old versions of Microsoft R Client.

@abbgrade: I am happy to inform you that we have updated the Server Compatibility page with the links to older client releases. Thanks for reporting!


Centralize demo mode DB clearing logic in ExperimentUserService

This PR centralizes the logic for clearing the database (/clearDB) in demo mode within the ExperimentUserService.
Key changes:

Moved the demo mode check from ExperimentClientController to ExperimentUserService
Updated clearDB method in ExperimentUserService to include demo mode check
Simplified /clearDB endpoints in all versions of ExperimentClientController

Benefits:

Improves code maintainability by centralizing demo mode logic
Reduces risk of inconsistencies across different controller versions

Testing:

Verified that clearDB functionality works as expected in demo mode
Confirmed that clearDB is properly restricted when not in demo mode

@danoswaltCL I've added the @Authorized() decorator to the /clearDB endpoint for extra security as you suggested. I've fully tested the endpoint in different versions (v1, v4, v5) locally, and it works as expected. Please feel free to approve this PR.

wait... this endpoint shouldn't be on the client controller, that makes no sense, especially now if using an authenticated endpoint middleware that uses a different auth than the client middleware uses. clients don't call this, it's an admin endpoint that should require a google login user credential.
Maybe can we copy paste this endpoint over to some other spot like the SettingsService and delete if from all client controllers? Kinda feels like that would be a better fit (if we really have to have this endpoint).
@VivekFitkariwala @bcb37 @ppratikcr7 any thoughts? this came about from me asking Zack if we really needed this endpoint, it seems like we're flirting with danger

wait... this endpoint shouldn't be on the client controller, that makes no sense, especially now if using an authenticated endpoint middleware that uses a different auth than the client middleware uses. clients don't call this, it's an admin endpoint that should require a google login user credential.
Maybe can we copy paste this endpoint over to some other spot like the SettingsService and delete if from all client controllers? Kinda feels like that would be a better fit (if we really have to have this endpoint).
@VivekFitkariwala @bcb37 @ppratikcr7 any thoughts? this came about from me asking Zack if we really needed this endpoint, it seems like we're flirting with danger

It didn't feel like a huge change. It's technically a bit safer because the Authorization decorator is requiring the same authorization as the non-client endpoints. It's an odd endpoint so it's not obvious where it belongs. Maybe it should have its own controller? But if we're going to revisit the need for this eventually anyway, I was ok with leaving it in the client controller with Authorization required. It's necessary for the demo app to function without a lot of re-engineering,

As @bcb37 said this is an odd endpoint and it is present because we don't have a multitenant system. So I don't have a strong opinion. We must be sure that the DEMO flag is false in production :)


Allow failure reason to be reported in verbose mode

Currently, when the parser chokes on a file, it's counted as a "bad" file, and reported as so.
Yet, we don't know the reason for the failure.
This patch implements this, it uncovers the failure reason from the parser, so the user could act accordingly to fix the issue.
Fix #405

Actually, the functions are return-morphic (they return different types based on the input, this is bad). If I had to change the return type, then I need to modify the code in multiple places (not only for this feature, and this is bad too). The only other solution to get output from a function is to use a reference, and that's what I did. Please note that I'm using default value for the parameter, so it does not break existing code that make use of the previous signature.
If you don't like this, then the only other solution I can think of is to add a "File::getParserFailureMessage()" method that would be called in Media::sync upon logging the error.
However, doing so means parsing a bad song twice (once for figuring out there is an error, and the second time to extract the error).
IMHO, the way I implemented is optimal, since it's captured once upon parsing.
Maybe you don't like references (I don't see any in the code I've read so far), and then I'd remove them, but they are quite powerful for exactly this kind of edge cases.

I don't think passing a reference around is a good idea. We can always use a property instead, for example:
// File.php
$this->syncError = 'Invalid file.';

// Media.php
$song = $file->sync($this->tags, $force);
if ($file->syncError) {
    // Log the error to console
}

About File::sync returning multiple types, perhaps we can make it return void and refer to $file->song or $file->skipped attributes from caller instead.

This times, with a member syncError that captures the error upon parsing and that's displayed in the console in verbose mode, no reference used anymore

Can you resolve the conflicts and squash into 1 commit? Thanks!

Ok, done

👍


solved issue #388 adding the restartPolicy and removing the write permissions check for the packs volumes

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Resolved the issue locally in my tests


Dereference optional values in PopulateFromArm

Coverage remained the same at ?% when pulling e0097cbb6743314cc23f83733a95ed066c1279f0 on matthchr:feature/more-arm-improvements into 2c5d56a50365af6a8d549a78771fb4f3aaec542e on Azure:master.


Removing old references to GitHub Pages site

What type of PR is this?
/kind cleanup
/kind documentation
What this PR does / why we need it:
kubernetes-sigs.github.io/gateway-api -> gateway-api.sigs.k8s.io
Does this PR introduce a user-facing change?:
NONE

/lgtm

/lgtm
/approve


Fix the implementation of HeapSizeOf for LinkedList

Forgot the size of the T field itself in the list nodes.

@bors-servo r+

:pushpin: Commit 6d422d9 has been approved by Manishearth

:hourglass: Testing commit 6d422d9 with merge 2545ffa...

:sunny: Test successful - travis


:seedling: Remove APIClient, update effected rest functions

Changes:

Remove APIClient
Update the affected functions in rest.ts to use axios directly
Double check the return types of the effected functions
Updated a few API model types based on current hub handler function responses
getApplicationSummaryCSV() URL query param was incorrectly named and could lead to more results returned than expected.  Query param updated to the correct name as per the OpenAPI definition / golang handler code.

Resolves: #1821
Part-of: #1411

Looks good. The case of param name importSummary.id (and why it worked before!) is worth documenting but I leave it to you.

It worked didn't fail before because the query param is not required.


Revert loki health targets check

This change has an upgrade to loki-stack which seems to fail upgrades.
Reverting until more information is gathered.
todo: ensure we test upgrades on this CI and not only on e2e testing.
Description

Motivation and Context

This change is required to get upgrades working again so close to the release.
Regression

How Has This Been Tested?

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[ ] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[ ] I have added unit tests to cover my changes.

@reitermarkus we have to revert this on 2.5 as it's breaking upgrades.
We're very close to release so we don't have time to fix it now, but we'll look into it and re-merge when we figure out how to do it.
This was not caught because at the moment we don't test helm upgrades in this CI... We should be able to do that soonish with kind..

bors merge


el-client port stops working (POST demo)

I'm porting el-client to STM32 and to test it I'm making one POST per second with 512 bytes of the exact same character, incremented every POST ('0' to '9').
First I reset ESP and MCU and in that case I can do 10-30 POST until it fails. After that if I reset MCU I can only do 1, sometimes 2 or 3 POSTs. In order to continue I have to reset ESP and MCU.
I'm trying to understand if it's a porting related problem or if some of you have it as well. I'm using esp-link v2.2.3 and my Debug log is below. The endpoint is /ecg_mm_fixe and everything is ok until the last line (88POST/ecg_mm_fixe000) and from there on it never recovers, unless I reset the MCU. Is this related to SLIP synchronization?
UART baudrate is 9600 (started at 115200 but lowered down to see if it solved) and my response timeout is 5 seconds.
SYNC!
ELC: got 14 @200042F4: 3 200042D0 1 1 0 5 0 8D AC
RESP_CB: 536888016 1
WIFI CONNECTED
ELC: got 10 @200042F4: 2 0 0 6F B
RESP_V: 0
(...)
ELC: got 14 @200042F4: 3 2000437C 1 2 0 C8 0 37 2A
RESP_CB: 536888188 1
REST code 200
ELC: got 14 @200042F4: 3 2000437C 1 2 0 C8 0 37 2A
RESP_CB: 536888188 1
REST code 200
ELC: got 14 @200042F4: 3 2000437C 1 2 0 C8 0 37 2A
RESP_CB: 536888188 1
REST code 200
88POST/ecg_mm_fixe0000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000�g99POST/ecg_mm_fixe1111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111C00POST/ecg_mm_fixe2222222222222222222222222222222222222222222222222222222222222222222222222222222222222222222222222222222222222222222222222222222222222222222222222222222222222222222222222222222222222222222222222222222222222222222222222222222222222222222222222222222222222222r�11POST/ecg_mm_fixe3333333333...

Is this still an issue with the newer versions? And did you turn off the UART debug output? It seems to steal too much time and cause issues, sigh.

Forgot to update this but it was an error in my UART driver implementation. I was using an asynchronous UART driver that doesn't wait to flush TX before waiting for RX and that brought a lot of problems. Polling for TX empty buffer before waiting for RX solved the problem.

thanks for the update!


searchservice.json should define NativeBlobSoftDeleteDeletionDetectionPolicy

As brought up in Azure/azure-sdk-for-net#11435, documentation shows an example of using @odata.type #Microsoft.Azure.Search.NativeBlobSoftDeleteDeletionDetectionPolicy that currently is not defined in swagger. We can define one manually, but if this really is a preview feature (is it still), it should be in swagger.

Sorry, I see those classes should actually be abstract (see #9686) and I see that swagger does not actually define @odata.type "#Microsoft.Azure.Search.NativeBlobSoftDeleteDeletionDetectionPolicy". We can define one manually, but this should be in the Preview swagger as well if it's still supported.
Originally posted by @heaths in https://github.com/Azure/azure-sdk-for-net/issues/11435#issuecomment-617347493

FYI @bleroy @arv100kri

@mattmsft Please confirm if this is still on your radar.

Is there any update on this? I don't see any ack on progress or timelines.

We can add this by next week

https://github.com/Azure/azure-rest-api-specs/pull/10308

@heaths it looks like this has been merged; can this issue be closed?  https://github.com/Azure/azure-rest-api-specs/pull/10308

Yes. Thanks for the reminder. I'll open a separate issue to make sure we re-generate the track 2 SDK.


chore(policies): refactor policies and fix zone links

Closes https://github.com/kumahq/kuma-gui/issues/2162
This PR was mainly a refactor of the PolicyList component to split it into nested routes. But whilst doing this I spotted several tiny bugs that I've fixed up here also, at least one of those bugs will require a fix on 2.6.x using the older version of the code.
A good deal of the green here is taking that code that was in PolicyList and splitting it into two separate routes.

Side note:
I wonder if this flake will get fixed by this refactor 🤔 , I've hit it a few times lately.

Thats all the conversations here resolved @kleinfreund let me know on this one. The only convo I've left open is my own inline which was to remind me to make a smaller PR to fix one of the issues covered here on 2.6.x. I'll do that once this is merged.


Pass IP network type from network to DevicePortConfig

Signed-off-by: Gopi krishna Kodali<EMAIL_ADDRESS>NOTE: With the change described below mgmt/app-shared ports will no longer support dual stack behavior.
NIM will only run DHCP for the specific IP family selected as part of the network configuration.
If the dual stack is needed, we should add option for Dual stack in network configuration page, zedcloud and eve.
Description:
Network configuration that comes from cloud already has a network type
field (ipv4/ipv6). This field is currently not being passed from
zedagent to NIM as part of the NetworkPortConfig in DevicePortConfig.
This commit pushes the network type field from zedagent to NIM as part
of NetworkPortConfig. We use the IP type to run DHCP for specific
protocol type.

While this is attractively simple it might be too dangerous as configItems; imaging if a use wants to disable ipv6 and they do a typo and disable ipv4. That would turn the device into a warm brick.
(We do have some timers which can have near-similar effect - for instance setting the config poll timer to a very large number but we don't envision customers using those.)
Given that the complexity is in the dhcp config (which you've solved) maybe we should make this part of the Ipspec in the API. If so we could have an enum with 0 (default) meaning DualIPv4IPv6 and then two values for IPv4Only and IPv6Only. Then the dpc testing will handle misconfiguration and fallback.
What do you think?
Alternatively we do a disable just for IPv6 as a config item (but that could be dangerous in some deployments but fewer of them since most networks support IPv4 connectivity)

@nordmark Looking closely I found that there is already NetworkType field in NetworkXObjectConfig. While creating a network there is a drop down menu to select IPv4 or IPv6 today. But there is no Dual stack option. We may have to add that if we want both IPv4 and IPv6 to work at the same time.
I'm trying a patch where I pass NetworkType from NetworkXObjectConfig as part of NetworkPortConfig. NIM will selectively enable IPv4 or IPv6 based on this. Will push the patch after my tests.
But after this patch, if we need both IPv4 and IPv6 (dual stack) to work on mgmt/app-shared ports, we will have to add that option from UI through cloud to device.

But after this patch, if we need both IPv4 and IPv6 (dual stack) to work on mgmt/app-shared ports, we will have to add that option from UI through cloud to device.

It would be nice to not surprise users by disabling IPv6 as part of doing this.
So I think we need more of a transition where the default remains "dual stack". It would make sense to check that mosr/all networks which are defined have IPv4 as the type, and then define some new types IPv4-only and IPv6-only (and in due course add those to the UI) so that we can re-interpret "IPv4" and "IPv6" to mean "IPv*".

But after this patch, if we need both IPv4 and IPv6 (dual stack) to work on mgmt/app-shared ports, we will have to add that option from UI through cloud to device.

It would be nice to not surprise users by disabling IPv6 as part of doing this.
So I think we need more of a transition where the default remains "dual stack". It would make sense to check that mosr/all networks which are defined have IPv4 as the type, and then define some new types IPv4-only and IPv6-only (and in due course add those to the UI) so that we can re-interpret "IPv4" and "IPv6" to mean "IPv*".

@nordmark I modified code to retain the dual stack behavior for both V4 & V6 network types.
I also introduced new types for V4Only & V6Only.


License file

It would be nice if you would add a license file. MagicMirror and most other modules use the MIT license, here is an example: https://github.com/MagicMirrorOrg/MagicMirror/blob/master/LICENSE.md :slightly_smiling_face:
By the way: Without a license your module can't be displayed with a screenshot on the new module list I'm working on.

Thanks for the hint ! I did not think about that so far .....
Added now the MIT license file.

Nice. Now the screenshot is displayed in the new module list :rocket: Thanks for the quick reaction! :slightly_smiling_face:

Your alias "IoT-Coder" should work to.


Update sbt-scalariform to 1.8.3

Updates org.scalariform:sbt-scalariform from 1.8.2 to 1.8.3.
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention @scala-steward in the comments below.
Have a fantastic day writing Scala!

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "org.scalariform", artifactId = "sbt-scalariform" } ]

labels: semver-patch

closed in favour of https://github.com/wehkamp/cakemix/pull/33


How to run dev environment on azure VM?

Please provide us with the following information:

OS?

Windows 7, 8 or 10. Linux (which distribution). Mac OSX (Yosemite? El Capitan?)
Windows 8/10

Versions.

Please run ng --version. If there's nothing outputted, please run in a Terminal: node --version and paste the result here:
angular-cli: 1.0.0-beta.19-3
node: 6.9.1
os: win32 x64

Repro steps.

Was this an app that wasn't created using the CLI? What change did you do on your code? etc.
It was created using the CLI

The log given by the failure.

Normally this include a stack trace and some more information.

Mention any other details that might be useful.
I'm running angular-cli on my azure VM which works fine when I test it within the box however when I try to access it outside the box it doesn't show up. Though the ports are all good when I was running the quickstart angular without CLI that was showing okay.
I changed the angular-cli port from 4200 (default) to 3000 (using .ember-cli) to match my box port but it. Do I need to configure something in the angular-cli itself? I don't want to build a --prod yet.

Thanks! We'll be in touch soon.

Run it using ng serve --host <IP_ADDRESS> which works fine, looks like the default IP is just <IP_ADDRESS> but other than localhost it won't allow you access it outside. Does anyone which package is this binding? as I don't want to always ng serve --host <IP_ADDRESS> just want to ng serve and should good to go.

The place you're looking for is over in the Webpack-Dev-Server repos (https://github.com/webpack/webpack-dev-server/blob/master/bin/webpack-dev-server.js#L192)
Here's the thing: I'm almost certain the team doesn't bind to <IP_ADDRESS> because they don't explicitly tell WDS to bind to any host. WDS just uses its default, as seen in the linked file. Also, whenever binding to localhost isn't going to work, the use of --host is the recommended answer. @filipesilva also made it known in #1793 that the old configuration options where this used to be set would be stripped, and true to his word, the old .ember-cli configuration is no longer available, nor would it apply since changing dev servers.
What you need is to add a script to your package.json along the lines of "start": "ng serve --host <IP_ADDRESS>", and then start your project with npm start rather than ng serve.

@gelliott181
Thanks for your answer, I found the .ember-cli when I was searching how to change 4200 to something else. Is there another way of changing the default port 4200 to say 3000? Though .ember-cli seems to be still working as I'm running my app on a different port than 4200.
Will try to add the that script in my package.json.

@gelliott181 never mind about my question about port, I put in my script --port xxxx and now its running on that port.
Thanks for clearing things.


Update jenkins to the latest LTS version

The upstream jenkins page mentions 2.303.2 as the latest LTS version.
https://www.jenkins.io/changelog-stable/
And it was released almost a month ago (2021-10-06)
https://www.jenkins.io/changelog-stable/#v2.303.2
It would be good to upgrade to latest LTS version with all CVE bugfixes at least in master branch.
Upgrade in the release-4.9 branch would be appreciated as well.

The Jenkins image has now been upgraded to v2.303.3, which includes additional security fixes.


Get error when using ODBC Driver 17 on latest python image (Debian Buster)

Microsoft ODBC Driver version
msodbcsql17
Docker image
python
Problem description
Latest python image uses Debian 10 (Buster). Connecting to SQL server gives
file not found error:

    def ctrl_err(ht, h, val_ret, ansi):
        """Classify type of ODBC error from (type of handle, handle, return value)
        , and raise with a list"""

        if ansi:
            state = create_buffer(22)
            Message = create_buffer(1024*4)
            ODBC_func = ODBC_API.SQLGetDiagRec
            if py_v3:
                raw_s = lambda s: bytes(s,'ascii')
            else:
                raw_s = str_8b
        else:
            state = create_buffer_u(24)
            Message = create_buffer_u(1024*4)
            ODBC_func = ODBC_API.SQLGetDiagRecW
            raw_s = unicode
        NativeError = ctypes.c_int()
        Buffer_len = c_short()
        err_list = []
        number_errors = 1

        while 1:
            ret = ODBC_func(ht, h, number_errors, state, \
                ADDR(NativeError), Message, 1024, ADDR(Buffer_len))
            if ret == SQL_NO_DATA_FOUND:
                #No more data, I can raise
                #print(err_list[0][1])
                state = err_list[0][0]
                err_text = raw_s('[')+state+raw_s('] ')+err_list[0][1]
                if state[:2] in (raw_s('24'),raw_s('25'),raw_s('42')):
                    raise ProgrammingError(state,err_text)
                elif state[:2] in (raw_s('22')):
                    raise DataError(state,err_text)
                elif state[:2] in (raw_s('23')) or state == raw_s('40002'):
                    raise IntegrityError(state,err_text)
                elif state == raw_s('0A000'):
                    raise NotSupportedError(state,err_text)
                elif state in (raw_s('HYT00'),raw_s('HYT01'),raw_s('01000')):
>                   raise OperationalError(state,err_text)
E                   pypyodbc.OperationalError: ('01000', "[01000] [unixODBC][Driver Manager]Can't open lib '/opt/microsoft/msodbcsql17/lib64/libmsodbcsql-17.3.so.1.1' : file not found")

/usr/local/lib/python3.7/site-packages/pypyodbc.py:983: OperationalError```

Problem is only with this version, previous one (`python:3.7.4-stretch`) works fine.

I could not find installation instructions in the below page fr Debian 10:
https://docs.microsoft.com/en-us/sql/connect/odbc/linux-mac/installing-the-microsoft-odbc-driver-for-sql-server?view=sql-server-2017

Try the version 9 driver, which may or may not work.
After running:
curl https://packages.microsoft.com/config/debian/9/prod.list > /etc/apt/sources.list.d/mssql-release.list

Edit /etc/apt/sources.list.d/mssql-release.list
Replace the Debian Codename stretch (9) with buster (10)
continue with the rest of the instructions

Doing this actually does work a lot of the time for when you are bumping to a new version of Debian or Ubuntu derivatives.

I've followed the exact steps for Debian 10 using the microsoft installation doc.  The driver installs, but the driver does not work.
Steps to reproduce:
`curl https://packages.microsoft.com/keys/microsoft.asc | apt-key add -
&& curl https://packages.microsoft.com/config/debian/10/prod.list > /etc/apt/sources.list.d/mssql-release.list
sudo apt-get update
sudo ACCEPT_EULA=Y apt-get install msodbcsql17
optional: for bcp and sqlcmd
sudo ACCEPT_EULA=Y apt-get install mssql-tools
echo 'export PATH="$PATH:/opt/mssql-tools/bin"' >> ~/.bash_profile
echo 'export PATH="$PATH:/opt/mssql-tools/bin"' >> ~/.bashrc
source ~/.bashrc
optional: for unixODBC development headers
sudo apt-get install unixodbc-dev
Get ODBC connection setup
echo "[MySQLServerDatabase]
Driver=ODBC Driver 17 for SQL Server
Description=My MS SQL Server
Trace=No
Server=server_name\instance_name,1433
Database=database" > ./temp
sudo odbcinst -i -s -f ./temp -l
rm ./temp
test by running
isql -v  MySQLServerDatabase username 'password'
Output:
> [08001][unixODBC][Microsoft][ODBC Driver 17 for SQL Server]TCP Provider: Error code 0x2746
> [08001][unixODBC][Microsoft][ODBC Driver 17 for SQL Server]Client unable to establish connection
> [ISQL]ERROR: Could not SQLConnect
`
Repeating these steps using Debian 9 works fine (obviously using https://packages.microsoft.com/config/debian/9/prod.list location).

I found this thread while googling for docker debian 10 "Error code 0x2746".
This issue seems to be common to all Buster based Docker images. One of my projects uses php:7.2-apache images and it now also fails to connect to an MS SQL server. I haven't figured out what the cause is, but based on this info I'm now basing my Docker image off of php:7.2-apache-stretch and the error goes away.
So it might be worth checking if there is a specific Stretch based image if you run into this issue.

I got the same error in a debian buster virtual machine. The error occurs If I try to connect to an mssql2012 vor 2016 instance. The connection to an mssql2017 works without any errors.


feat: update Go version from 1.17 to 1.18

Also, update golangci-lint to version 1.47, which has better support for go 1.18
Closes #457
Signed-off-by: Jonathan Gonzalez V<EMAIL_ADDRESS>

The operator is crashing with this patch, see https://github.com/cloudnative-pg/cloudnative-pg/runs/7464645526?check_suite_focus=true#step:9:34

/test

We see regressions in the tests. Do not merge until we understand why.

/test

With the latest test run now everything is green

/ok-to-merge


release windows 10 under a free software license.

what

This should be interesting.
Now we will have a 1000 distros of Windows, package nightmares, and all the hell of modern day Linux in Windows.

Free software doesn't mean only Linux.


OLS-1298: fix prompt generator benchmark

Description
OLS-1298: fix prompt generator benchmark
Type of change

[ ] Refactor
[ ] New feature
[x] Bug fix
[ ] CVE fix
[ ] Optimization
[ ] Documentation Update
[ ] Configuration Update
[ ] Bump-up dependent library
[ ] Bump-up library or tool used for development (does not change the final image)
[ ] CI configuration change
[ ] Konflux configuration change

Related Tickets & Documents

Related Issue #OLS-1298

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 96.96%. Comparing base (7280586) to head (0c81c02).
Report is 14 commits behind head on main.

Additional details and impacted files

@@             Coverage Diff             @@
##             main    #2051       +/-   ##
===========================================
+ Coverage   74.89%   96.96%   +22.06%
===========================================
  Files          70       71        +1
  Lines        2892     2895        +3
===========================================
+ Hits         2166     2807      +641
+ Misses        726       88      -638

see 36 files with indirect coverage changes