Support v1 Task&Pipeline in remote resolution

Expected Behavior
Remote resolution can resolve remote v1 tasks and pipelines
Actual Behavior
Remote resolution cannot resolve remote v1 tasks and pipelines
The pipelinerun is not created, and error log is:
"error":"1 error occurred:\n\t* failed to get pipeline: failed to convert obj [tekton.dev/v1](http://tekton.dev/v1), Kind=Pipeline into Pipeline\n\n",

Steps to Reproduce the Problem
apply the sample pipeline run:
apiVersion: tekton.dev/v1
kind: PipelineRun
metadata:
  name: example-pipelinerun
  namespace: trusted-resources
spec:
  pipelineRef:
    resolver: git
    params:
      - name: url
        value: https://github.com/Yongxuanzhang/sample-tekton-pipeline
      - name: revision
        value: main
      - name: pathInRepo
        value: signed-pipeline.yaml

Additional Info

Kubernetes version:
Output of kubectl version:

Client Version: version.Info{Major:"1", Minor:"23", GitVersion:"v1.23.1", GitCommit:"86ec240af8cbd1b60bcc4c03c20da9b98005b92e", GitTreeState:"clean", BuildDate:"2021-12-16T11:41:01Z", GoVersion:"go1.17.5", Compiler:"gc", Platform:"linux/amd64"}
Server Version: version.Info{Major:"1", Minor:"24", GitVersion:"v1.24.0", GitCommit:"4ce5a8954017644c5420bae81d72b09b735c21f0", GitTreeState:"clean", BuildDate:"2022-05-19T15:39:43Z", GoVersion:"go1.18.1", Compiler:"gc", Platform:"linux/amd64"}

Tekton Pipeline version:
Output of tkn version or kubectl get pods -n tekton-pipelines -l app=tekton-pipelines-controller -o=jsonpath='{.items[0].metadata.labels.version}'

Client version: 0.23.1
Pipeline version: devel (latest main)

Thanks for creating the issue @Yongxuanzhang
It feels to me 2 ways moving forward:

Separating the folder for v1/ v1beta1 remotely/resolved Task
Converting to V1beta1 if the accepted Task is v1 here, which could be changed until we swap to v1 as storage version

But I was not sure how we should specify this somewhere for the usage of resovlers?
cc @abayer this is the use case as discussed offline:)

I think most likely we just need to make it so that the resolver can "marshal/unmarshal" v1 as well as v1beta1, isn't it ?
// resolvePipeline accepts an impl of remote.Resolver and attempts to
// fetch a pipeline with given name. An error is returned if the
// resolution doesn't work or the returned data isn't a valid
// v1beta1.PipelineObject.
func resolvePipeline(ctx context.Context, resolver remote.Resolver, name string) (v1beta1.PipelineObject, *v1beta1.ConfigSource, error) {
	obj, configSource, err := resolver.Get(ctx, "pipeline", name)
	if err != nil {
		return nil, nil, err
	}
	pipelineObj, err := readRuntimeObjectAsPipeline(ctx, obj)
	if err != nil {
		return nil, nil, fmt.Errorf("failed to convert obj %s into Pipeline", obj.GetObjectKind().GroupVersionKind().String())
	}
	return pipelineObj, configSource, nil
}

// readRuntimeObjectAsPipeline tries to convert a generic runtime.Object
// into a v1beta1.PipelineObject type so that its meta and spec fields
// can be read. An error is returned if the given object is not a
// PipelineObject or if there is an error validating or upgrading an
// older PipelineObject into its v1beta1 equivalent.
func readRuntimeObjectAsPipeline(ctx context.Context, obj runtime.Object) (v1beta1.PipelineObject, error) {
	if pipeline, ok := obj.(v1beta1.PipelineObject); ok {
		return pipeline, nil
	}

	return nil, errors.New("resource is not a pipeline")
}

We would want to support both, and call the conversion to whatever the storage version is at the time.

Yes:) I think conversion makes sense and to support both until the deprecation of v1beta1.

I think most likely we just need to make it so that the resolver can "marshal/unmarshal" v1 as well as v1beta1, isn't it ?
// resolvePipeline accepts an impl of remote.Resolver and attempts to
// fetch a pipeline with given name. An error is returned if the
// resolution doesn't work or the returned data isn't a valid
// v1beta1.PipelineObject.
func resolvePipeline(ctx context.Context, resolver remote.Resolver, name string) (v1beta1.PipelineObject, *v1beta1.ConfigSource, error) {
	obj, configSource, err := resolver.Get(ctx, "pipeline", name)
	if err != nil {
		return nil, nil, err
	}
	pipelineObj, err := readRuntimeObjectAsPipeline(ctx, obj)
	if err != nil {
		return nil, nil, fmt.Errorf("failed to convert obj %s into Pipeline", obj.GetObjectKind().GroupVersionKind().String())
	}
	return pipelineObj, configSource, nil
}

// readRuntimeObjectAsPipeline tries to convert a generic runtime.Object
// into a v1beta1.PipelineObject type so that its meta and spec fields
// can be read. An error is returned if the given object is not a
// PipelineObject or if there is an error validating or upgrading an
// older PipelineObject into its v1beta1 equivalent.
func readRuntimeObjectAsPipeline(ctx context.Context, obj runtime.Object) (v1beta1.PipelineObject, error) {
	if pipeline, ok := obj.(v1beta1.PipelineObject); ok {
		return pipeline, nil
	}

	return nil, errors.New("resource is not a pipeline")
}

We would want to support both, and call the conversion to whatever the storage version is at the time.

/assign


查询 JDBC Catalog 外部表时异常

Search before asking

[X] I had searched in the issues and found no similar issues.

Version
2.0-beta
What's Wrong?
select count(*) from aaa_10_126_128.b_v1.0.access_record
如上sql所示，连接的 JDBC Catalog 外部数据库是mysql8，aaa_10_126_128是一个 JDBC Catalog 名称，b_v1.0 是数据库名称，access_record 是数据表名称。现在的问题是由于数据库名称是有【.】的，所以加了【``】这两个符号，但提示如下信息：
ERROR 1105 (HY000): errCode = 2, detailMessage = (<IP_ADDRESS>)[CANCELLED][INTERNAL_ERROR]UdfRuntimeException: JDBC executor sql has error:
CAUSED BY: SQLSyntaxErrorException: Table 'b_v1.0.access_record' doesn't exist
用 explain select count(*) from aaa_10_126_128.b_v1.0.access_record 查看，就会发现解析错误
What You Expected?
执行正常
How to Reproduce?
No response
Anything Else?
No response
Are you willing to submit PR?

[ ] Yes I am willing to submit a PR!

Code of Conduct

[X] I agree to follow this project's Code of Conduct

Actually it is not a good habit to create table or database which has a name with comma.
for example, when creating database with name 'aaa.bb', then creating a table 'c.d' in aaa.bb.
It is very difficult for mysql to distinguish which part is correct database name.
Of course, it may be a bug of doris.
But I recommend optimizing your naming habits, which will benifits your business.
@xujiabing-001

Actually it is not a good habit to create table or database which has a name with comma. for example, when creating database with name 'aaa.bb', then creating a table 'c.d' in aaa.bb. It is very difficult for mysql to distinguish which part is correct database name. Of course, it may be a bug of doris. But I recommend optimizing your naming habits, which will benifits your business. @xujiabing-001

数据库命令确实不规范，但现在已经在使用了，不能马上就能修改，那在doris里怎么解决这个问题呢

https://github.com/apache/doris/pull/24520
This PR fixes the issue and can be tested until 2.0.3 is released


Use different source for JU-scraper

The JU-scraper seems to be deactivated.
The source now is an xls as I see but without up-to-date information (last update 2020-09-30).
The same information (last update yesterday...) can also be found on this site:
https://www.jura.ch/fr/Autorites/Coronavirus/Chiffres-H-JU/Evolution-des-cas-COVID-19-dans-le-Jura.html

Added the missing numbers for now ... https://github.com/openZH/covid_19/pull/1119

Jura used to have an xls download on that page, but it's gone since yesterday, that's why the scraper is currently deactivated. We didn't yet get any feedback from them, but good to know that they put the numbers on the website. I will adapt the scraper accordingly.

I can not guarantee if they will publish persistently on the new site ... but probably no one can for any scraper ;-)

I was told by JU that they are going to upload the xls again and update it weekly but it seems that the table accessible via the abovementioned URL is updated daily so I too suggest to adapt the scraper to the new source.


question: how to handle expired refresh token?

When using oauth2Client.refreshToken.refresh(), how do I handle when the refresh token has expired? AFAIK an error is thrown, but I'm not sure which error. My thoughts are it'd be handled like this:
try {
  await oauth2Client.refreshToken.refresh(refreshToken);
} catch (error) {
  if (isRefreshTokenExpired(error) {
    return null;
  }
  throw error;
}

Gently pinging @cmd-johnson.

Huh, I totally missed that. Absolutely, those errors shouldn't just be exported as types.
That's an easy fix though! Check out<EMAIL_ADDRESS>:slightly_smiling_face:

Nice! Thank you. Implemented in https://github.com/denoland/deno_kv_oauth/pull/131


feat(AppEngine): Add updateApply and removeApply for attach/detach and snapshot/restore

Description
Adding to AppEngine the capability to update and remove objects related to an app.  Not sure if this is the right direction, but I think the implications here are that you would be able to use czctl to manipulate volumes as well as the user interface of lifeboat. Potentially, we would want to move the expand logic to this controller too.
Fixes #207 #208
Type of change
Please delete options that are not relevant.

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update
[ ] Technical improvement or removal of technical debt.
[ ] Minor change: comments, documentation, trivial fixes

How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

[ ] Unit Tests

Optional:

[ ] Functional Tests
[ ] Integration Tests

Checklist:

[ ] My code follows the style guidelines of this project
[ ] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes
[ ] Any dependent changes have been merged and published in downstream modules
[ ] I have checked my code and corrected any misspellings

Great stuff! Should this be in provisioner base in provisioner/common?


generic constructors of Java classes

I finally found a Java class with a generic constructor: javafx.animation.KeyValue.
I can't instantiate this class from Ceylon :-(

One solution to this problem would be to map generic constructors to static methods.
So we would call KeyValue.create(prop, end).

Isn’t this the same as #335?

@Zambonifofex yes, it is. I've changed the title of #335, which was very ambiguous.


C# 9 Guideline Proposals

CONSIDER using records over classes
Unless:

Inheritance chains with classes are required
The identity of the object is not based of the value of all its fields
The type is in a public API that may be consumed by older versions of C#

AVOID positional records when validation of positional members is required
CONSIDER using init properties instead of readonly properties for optional values
DO define a constructor to allow setting init properties for backwards compatibility with pre-C# 9
DO name record positional parameter with PascalCase

As per discussion the following should be added to the guidelines.
Coding/Classes

CONSIDER using records over classes. However, init properties are cumbersome to consume in older versions of C#, records are incompatible with class inheritance chains.
AVOID positional records when validation of positional members is required.
DO name record positional parameter with PascalCase

Coding/Properties

CONSIDER using init properties instead of readonly properties for optional values. However, init properties are cumbersome to consume in older versions of C#.


Strawberry integration crashes if no query is in request

How do you use Sentry?
Sentry Saas (sentry.io)
Version
1.40.2
Steps to Reproduce
Running an app with the StrawberryIntegration crashes if graphql endpoint is called with no query field in the input data.

Place the attached litestar app code in app.py and install the requirements (sentry, strawberry graphql and litestar)
Run the local server using litestar run
Call the graphql endpoint using curl -v -X POST -d "{}" -H "Content-Type: application/json" http://localhost:8000/graphql
This causes an exception to be raised, whereas if I comment out the sentry_sdk.init() line in the code, the "expected" result of a 400 Bad Request is returned.
(The additional unwanted effect is that the 500 exception goes to sentry as an error in a production app - this is just a minimal reproduction).

app.py:
import logging

from litestar import Litestar
from litestar.logging import LoggingConfig

import sentry_sdk
from sentry_sdk.integrations.strawberry import StrawberryIntegration

import strawberry
from strawberry.litestar import make_graphql_controller

sentry_sdk.init(integrations=[StrawberryIntegration(async_execution=True)])

@strawberry.type
class Query:
    @strawberry.field
    def hello(self) -> str:
        return "Hello World"

class Schema(strawberry.Schema):
    async def execute(self, *args, **kwargs):
        try:
            return await super().execute(*args, **kwargs)
        except Exception as e:
            logging.getLogger("root").exception(e)
            raise

schema = Schema(Query)

GraphQLController = make_graphql_controller(schema, path="/graphql", debug=True)

app = Litestar(
    route_handlers=[GraphQLController],
    logging_config=LoggingConfig(
        root={"level": logging.getLevelName(logging.INFO), "handlers": ["console"]},
        formatters={
            "standard": {
                "format": "%(asctime)s - %(name)s - %(levelname)s - %(message)s"
            }
        },
    ),
)

pip freeze:
anyio==4.2.0
certifi==2024.2.2
click==8.1.7
EditorConfig==0.12.3
Faker==23.0.0
fast-query-parsers==1.0.3
graphql-core==3.2.3
h11==0.14.0
httpcore==1.0.2
httptools==0.6.1
httpx==0.26.0
idna==3.6
Jinja2==3.1.3
jsbeautifier==1.14.11
litestar==2.6.0
markdown-it-py==3.0.0
MarkupSafe==2.1.5
mdurl==0.1.2
msgspec==0.18.6
multidict==6.0.5
polyfactory==2.14.1
Pygments==2.17.2
python-dateutil==2.8.2
python-dotenv==1.0.1
PyYAML==6.0.1
rich==13.7.0
rich-click==1.7.3
sentry-sdk==1.40.2
six==1.16.0
sniffio==1.3.0
strawberry-graphql==0.219.1
typing_extensions==4.9.0
urllib3==2.2.0
uvicorn==0.27.0.post1
uvloop==0.19.0
watchfiles==0.21.0
websockets==12.0

Expected Result
< HTTP/1.1 400 Bad Request
< date: Wed, 07 Feb 2024 13:52:14 GMT
< server: uvicorn
< content-type: text/plain; charset=utf-8
< content-length: 37
<
* Connection #0 to host localhost left intact
No GraphQL query found in the request⏎

Actual Result
< HTTP/1.1 500 Internal Server Error
< date: Wed, 07 Feb 2024 13:53:11 GMT
< server: uvicorn
< content-type: application/json
< content-length: 52
<
* Connection #0 to host localhost left intact
{"status_code":500,"detail":"Internal Server Error"}⏎

On the server console, there is a traceback from inside the strawberry integration:
2024-02-07 13:53:11,970 - root - ERROR - 'NoneType' object has no attribute 'strip'
Traceback (most recent call last):
  File "/Users/james/repos/sentrystrawberry/app.py", line 25, in execute
    return await super().execute(*args, **kwargs)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/james/.pyenv/versions/3.12.0/envs/mixcloud/lib/python3.12/site-packages/strawberry/schema/schema.py", line 263, in execute
    result = await execute(
             ^^^^^^^^^^^^^^
  File "/Users/james/.pyenv/versions/3.12.0/envs/mixcloud/lib/python3.12/site-packages/sentry_sdk/integrations/strawberry.py", line 266, in _sentry_patched_execute_async
    result = await old_execute_async(*args, **kwargs)
             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/james/.pyenv/versions/3.12.0/envs/mixcloud/lib/python3.12/site-packages/strawberry/schema/execute.py", line 91, in execute
    async with extensions_runner.operation():
  File "/Users/james/.pyenv/versions/3.12.0/envs/mixcloud/lib/python3.12/site-packages/strawberry/extensions/context.py", line 191, in __aenter__
    await self.run_hooks_async()
  File "/Users/james/.pyenv/versions/3.12.0/envs/mixcloud/lib/python3.12/site-packages/strawberry/extensions/context.py", line 177, in run_hooks_async
    hook.initialized_hook.__next__()  # type: ignore[union-attr]
    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/james/.pyenv/versions/3.12.0/envs/mixcloud/lib/python3.12/site-packages/sentry_sdk/integrations/strawberry.py", line 148, in on_operation
    if self.execution_context.query.strip().startswith("mutation"):
       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
AttributeError: 'NoneType' object has no attribute 'strip'

Thanks for the super nice bug report @jthorniley! Should be easy enough for us to fix -- we need to guard against self.execution_context.query being None in a couple places.


[Feature] Subscribe & publish_value API kuksa.val.v2

This adds the features of kuksa.val.v2 to subscribe and publish a value to databroker. It fixes some conversion functions as well. It adds a unit test for subscribe function that leverages publish_value.

Looks good to me, just few small changes.


JLS Upgrades

Long polling on server extension endpoints (course, student, assignments, current assignment)

This is a nice change in general, but I added this particularly as a fix for the bug where when the page first loads, it may say you aren't in the student repository for a few seconds (hlx2-118)

File change tracking
Move file changes/submissions into a tab group to save vertical space (I also added a tabs implementation to the codebase which we'll probably end up needing in JLP extension as well based on its similar size constraints)
Assignment status tags

For past assignments, "Submitted <time> ago" or "<time> past due"
For active assignments, "Submitted" or "Not Submitted"
For future assignments, "Upcoming"
A "low time" tag also shows up next to the status tag when the assignment closes in the next 4 hours, with text "Due in <time>"

Past due warning
Submission button tooltip explains why submission is disabled (if disabled) when hovered over.

Misc:

Polished some stylesheets
Fix a couple remnants that got missed in the rename PR
Remove .env and update the .env.sample with an up-to-date example

There's some discrepancies here from the wireframes that I personally think should be changed. You have a section here with Student, Instructor, and Due Date and also have "Summary" and "Description" text boxes when neither are in the wireframes and aren't necessary. I could see an argument for putting a more explicit Due Date in a tooltip when you hover over the "Due in 2 Hours" item though, but not the rest of the stuff you have. We can autogenerate the commit message and descriptions for users - we want to abstract away the git behavior as much as possible.
I'll take a closer look at the code later but those are the first things I noticed.

There's some discrepancies here from the wireframes that I personally think should be changed. You have a section here with Student, Instructor, and Due Date and also have "Summary" and "Description" text boxes when neither are in the wireframes and aren't necessary. I could see an argument for putting a more explicit Due Date in a tooltip when you hover over the "Due in 2 Hours" item though, but not the rest of the stuff you have. We can autogenerate the commit message and descriptions for users - we want to abstract away the git behavior as much as possible.
I'll take a closer look at the code later but those are the first things I noticed.

Yeah, as I've told Chuck, I'm not following the wireframes to a tee (this is especially true for JLS since we already have an established UI), which is why I attached the screenshots to discuss in this PR. Let me also add here that David's wireframes are not "complete" in the sense that he didn't design them for us to replicate 1:1 as our exact UI; they're more so a starting design and guide (at least IMO).
Yes we have student and instructor sections when neither are in the wireframe. I would argue that instructors is useful. This can be a good place to display email/contact, as a tooltip, or something. Basically, this section was intended as a "how to get help with the assignment if you need it". I agree the student section is useless. I originally added it as a placeholder for vertical whitespace. I didn't remove it because there was no need to, and I think it looks nice, but I don't have any issue with removing it.
Due date section absolutely should be included regardless of it's in the wireframe, not sure what your point is about that. There already is an explicit tooltip when hovering over the "due in" tag. But that tag only displays as a warning when the assignment is due within 4 hours. There needs to be a clear, explicit date/time that the assignment is due shown to the student. They shouldn't have to look around and hover over stuff for it.
The summary/description cannot be autogenerated, I don't know what you mean, and also it doesn't mention git. That is the submission summary/description, which just translates into the standard git commit message format.


 instead of ?

The schema currently only accepts <name> in <respStmt> but the new conversion code uses <persName>. I have no preference one way or another, but we should get this in sync.

One reason for <name> is that the responsibility may lie with orgs or other entities not covered by <persName>.

Yes, the current code distinguishes between people and organisations, outputting <persName> for people and <orgName> for orgs. Since the code could tell the difference, I thought it would be nice to note the difference in the encoding too. @joeytakeda : what was the reason for limiting the content model of respStmt in our ODD?

IIRC, I was just following the model set by MoEML and a few of the other HCMC projects. I can't think of any good reason not to use  and .


Fix the Products Dropdown Issue

Notes for Reviewers
This PR fixes #166
https://github.com/layer5io/docs/assets/70331875/0683474d-6f69-4078-886c-2ae19e7a546c
Signed commits

[x] Yes, I signed my commits.

Hi @nikhilkalburgi  ,
Thanks for your PR! I encourage you to share this in the Website Meeting tomorrow at 6:30 PM IST. Share your screen, and walk us through it. It's cool to take and share feedback. Check the Doc here to include this PR.
You're welcome at the meeting
Check to community calendar for more details of meetings at Layers.


Use a different type alias for JsonObject

Until now, Fleece for FSharp.Data defined JsonObject as a (string * JsonValue) [].
This implies that depending on how do we interpret it, could be serialized either as JObject or JArray which might result in problems.
The idea is to use a type alias to a type that already serialize to JObject.
I propose to use Map<string,JsonValue>.
We could consider IReadOnlyDictionary<string,JsonValue>, which is used internally and we don't have an overload for it, but note that being an interface, we need to assess first that no undesired subsumption would happen in the overload resolution.
Note that this might break things in projects using FSharp.Data, but for System.Text.Json there won't be problems as long as this change is included in its first release.
Finally, I don't know why the type alias to (string * JsonValue) [] was choosen, not sure if @eulerfx  can remember the reason and give some feedback.

I think it would be a good change since the (string * JsonValue) [] is a more raw representation of the json format. Any deserialization into values will use just one of the values if there they have the same key.

The concern about multiple keys is also there.
At first sight I thought that had been one of the reasons for (string * JsonValue) [], since Json in theory allows multiple keys, but even in that case as you said, it would at some point use a dictionary and would use just one of the keys.
If we really want to support multiple keys we should change drastically the design and use a MultiMap, in all 4 implementations, but still I'm not sure all 4 libs (as standalone) support multiple keys.

Closed by #82


Implement power spectrum, autocorrelation, etc. including reliability analysis for containers

Implement the power spectrum etc for container, i.e. including averages over all topographies in a container. These function should also perform reliability analysis. For this we need a standardized entry to the info dictionary to report instrumental resolution and/or tip radius.

PR #130 implements this for the scale-dependent statistical properties


it-switch label is offset

it-switch-label-group doesn't have display: flex so it-switch-label align-self: center does not take effect.
bad:

good:

I'm quite happy w the framework & appreciate the support. Tell me if there's anything I can do to help more w issues I find. Not applying time pressure -- happy to figure my own workarounds.

Fixed


[CI][Docker] set environment variables for UTF-8, to prevent errors when running black

Updates ci_lint image to use UTF-8 encoding.

Sets environment shell encoding to UTF-8

This prevents the black formatting tool to exit with the following error:
"RuntimeError: Click will abort further execution because Python was
configured to use ASCII as encoding for the environment"

That's just a problem not seen yet, before we implement our image rebuilds.
cc @tqchen @areusch for reviews.

@areusch if you have a minute, can you review?

@leandron if it's ok, i'd like to hold this change until we finish #7995. i think it's likely not going to affect it, but we have a few CUDA changes to make in order to make any progress on updating the images and i'd like to not mix future changes. that said, if it's pressing, i don't think this one will affect much.

@leandron if it's ok, i'd like to hold this change until we finish #7995. i think it's likely not going to affect it, but we have a few CUDA changes to make in order to make any progress on updating the images and i'd like to not mix future changes. that said, if it's pressing, i don't think this one will affect much.

It would be good to merge as it is very low impact - if possible, so that I can keep validating the images overnight.
In case you want to keep this to organise #7995 - I also support it -, I’ll manage with some local change on my CI jobs. Let me know.

@tkonolige wdyt? i'm holding most changes, but this one a) only affects ci-lint and b) is pretty low-impact

This should be an easy rebuild. Let's merge.


Visual Glossary: Are there any terms that are missing (need to be added)?

There are currently 16 terms in the glossary.
During the Sept 3 meeting the guides editor(s) requested that all SWG participants review and use this issue to propose any other terms that should be added.

Reviewed and no further comments have been received.


Add improved configurability

Fixes #16
@step76 I've squashed your commits into a94ccfb and added a minor adjustment on top for slightly less repetition and to try to stay in line with the pythonic style of the rest of the file :+1:

I'm not a python developer and I don't know the Python syntax.
I've tried to do my best to suggest an enhancement.

LGTM

@step76 the suggestion was definitely appreciated! :heart:


single object app proto changes

I completely de-scoped this project. Reverted the previous PR. Just going to focus on

Getting rid of the _object stuff from the client
Making it possible to have apps with the same name but different type (requires us to send the type information during lookups)

This should be quite easy to do, and just a few lines code changes on the server.

Server changes needed for this:

In AppLookup, return app_id as well
In AppSetObjects, if single_object_id is present, use that for {"_object": ...}

Should be trivial. A minor later change we can do soon is to migrate the {"_object": ...} thing to its own db column


Not working in new Atom v1.6 update

The Pane doesn't load open tabs anymore in the new Atom v1.6 update

Commenting this CSS property solved the issue for me:
.tree-view-open-files {     /* overflow: auto; */ }

It was showing only a few files in Atom v1.6.2 but this fix works great for showing all of them. Inspired by https://github.com/bloopletech/config/commit/33431dff6f0616fa639d118bf2d466572a2bc1e8
// From https://github.com/postcasio/tree-view-open-files/issues/38
.tree-view-open-files {
  max-height: none !important;
  overflow: visible !important;
 }

@Try this, fixed for atom 1.18.0 https://github.com/sergiu-gordienco/tree-view-open-files
on atom is tree-view-open-files-updated
apm install tree-view-open-files-updated
https://atom.io/packages/tree-view-open-files-updated


Fix _save_checkpoint for online methods

What does this PR do?
The change in https://github.com/huggingface/transformers/pull/31817 is breaking for TRL since it removes metrics from _save_checkpoint.
We need to use the new style, using the new method Trainer._determine_best_metric. We need to copy this method from Trainer to ensure compatibly.
Compatibility

TRL \ Transformers
v4.46
dev

v0.11
not affected
No

dev
Yes, we copy-paste the new method Trainer._determine_best_metric into OnlineDPOTrainer
Yes

Note that once we've set the minimum transformers version to version > 4.46, we will be able to remove OnlineDPOTrainer. _determine_best_metric.
Before submitting

[ ] This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
[ ] Did you read the contributor guideline,
Pull Request section?
[ ] Was this discussed/approved via a GitHub issue? Please add a link
to it if that's the case.
[ ] Did you make sure to update the documentation with your changes? Here are the
documentation guidelines.
[ ] Did you write any new necessary tests?

Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

If at least one of you @muellerzr @SunMarc can take a look please 🙏


Introduce applied_index variable?

Right now we incorrectly assume that it is safe to trim decided entries in the log. The point at which it is ok to trim an entry is when it has been applied to the local state machine (which happens outside the scope of OmniPaxos). What we should really care about is the applied_idx not the decided_idx.  A user of OmniPaxos can still guarantee safety by ensuring they have applied all decided entries before trimming, which ensures applied_idx = decided_idx. But it is probably less error prone to instead create a public function that allows a user of OmniPaxos to inform us what the current applied_idx is. With the applied_idx we can also create a nicer API for a user to request decided-but-not-applied-entries instead of read_decided_suffix.
Furthermore if a user wants to efficiently implement crash-recovery they will need to persist this applied_idx (see section 3.8 of the Raft disseration). So it could be nice to handle this persistence for them.
Similar complications have to be considered when it comes to snapshotting. If a user calls read_decided_suffix in order to apply new entries and gets a LogEntry::Snapshotted(Snapshot) they must reset their ENTIRE state and replace it with the applied snapshot. This scenario can occur outside of the control of the user since Prepare phase syncing can cause decided-but-not-applied entries to be snapshotted. Therefore I think it makes sense to rethink snapshotting and syncing in the context of this applied_idx.

Right now we incorrectly assume that it is safe to trim decided entries in the log.

This is not entirely true. Currently, the library never trims unless it is called by the user. If the user calls it, we assume that they really want to get rid of those entries (i.e., they don't need it in their application anymore). The only additional safety mechanism we provide is to check that all servers have really decided up to the trim index argument (otherwise the lagging servers will not be able to catch up those trimmed entries).
I think this boils down to how much we want OmniPaxos to be a log library vs. an RSM library. I'm a bit reluctant towards introducing an applied_index variable because imo this is the user's responsibility. OmniPaxos' role is to be a distributed log and the log shouldn't keep track of how far you've read in it, this should be tracked by the user themselves.
I do agree that there are some benefits we could get from introducing applied_index, such as the case you describe with the snapshot. But it also comes at the potential cost of performance and more complexity (how do we guarantee the atomicity of OmniPaxos' applied_index and the application state). If we would handle these things, I think that should be another library built on OmniPaxos that is an RSM library that stores and modifies the state directly rather than a log library like OmniPaxos.

Right, if the user does everything correctly there will be no safety issues. But we should probably show how to properly handle snapshotted entries in omnipaxos-rocksdb-tutorial. This is what is currently done with isn't safe:
    fn update_database(&self, decided_entries: Vec<LogEntry<KVCommand>>) {
        for entry in decided_entries {
            match entry {
                LogEntry::Decided(cmd) => {
                    self.database.handle_command(cmd);
                }
                _ => {}
            }
        }
    }

Closing this issue here. Feel free to submit issue or PR to the tutorial repo.


RV64 exploration

Jolt can theoretically support 64-bit word sizes with relative ease. We would like to evaluate the extent to which RV64 would be more efficient than RV32 for certain programs. For example, we expect RV64 to generate smaller traces than RV32 for programs using a lot of large-field arithmetic.
As an initial exploration, we should compare the trace lengths of programs compiled to RV32IM vs RV64IM.

@moodlezoup Is this something which could be solved by a beginner?


Comments - not working with Django 1.8 implementation

@hyi - Wanted to test if comments were still working and ran into the following error.
You may know what this is off the top of your head...
Environment:

Request Method: POST
Request URL: http://beta.hydroshare.org/comment/

Django Version: 1.8.9
Python Version: 2.7.6
Installed Applications:
(u'mezzanine.boot',
 u'autocomplete_light',
 u'django.contrib.auth',
 u'oauth2_provider',
 u'corsheaders',
 u'django.contrib.contenttypes',
 u'django.contrib.redirects',
 u'django.contrib.sessions',
 u'django.contrib.sites',
 u'django.contrib.sitemaps',
 u'django.contrib.gis',
 u'inplaceeditform',
 u'django_nose',
 u'django_irods',
 u'theme',
 u'theme.blog_mods',
 u'mezzanine.conf',
 u'mezzanine.core',
 u'mezzanine.generic',
 u'mezzanine.blog',
 u'mezzanine.forms',
 u'mezzanine.pages',
 u'mezzanine.galleries',
 u'crispy_forms',
 u'mezzanine.accounts',
 u'mezzanine.mobile',
 u'haystack',
 u'jquery_ui',
 u'rest_framework',
 u'ga_ows',
 u'ga_resources',
 u'hs_core',
 u'hs_access_control',
 u'hs_labels',
 u'hs_metrics',
 u'irods_browser_app',
 u'django_docker_processes',
 u'hs_geo_raster_resource',
 u'ref_ts',
 u'hs_app_timeseries',
 u'widget_tweaks',
 u'hs_app_netCDF',
 u'hs_model_program',
 u'hs_modelinstance',
 u'hs_tools_resource',
 u'hs_swat_modelinstance',
 u'hs_geographic_feature_resource',
 u'hs_script_resource',
 u'hs_sitemap',
 u'debug_toolbar',
 u'django_extensions',
 u'filebrowser_safe',
 u'grappelli_safe',
 u'django.contrib.admin',
 u'django.contrib.staticfiles',
 u'django_comments')
Installed Middleware:
(u'django.contrib.sessions.middleware.SessionMiddleware',
 u'django.middleware.locale.LocaleMiddleware',
 u'django.contrib.auth.middleware.AuthenticationMiddleware',
 u'corsheaders.middleware.CorsMiddleware',
 u'django.middleware.common.CommonMiddleware',
 u'django.middleware.csrf.CsrfViewMiddleware',
 u'django.contrib.messages.middleware.MessageMiddleware',
 u'mezzanine.core.request.CurrentRequestMiddleware',
 u'mezzanine.core.middleware.RedirectFallbackMiddleware',
 u'mezzanine.core.middleware.TemplateForDeviceMiddleware',
 u'mezzanine.core.middleware.TemplateForHostMiddleware',
 u'mezzanine.core.middleware.AdminLoginInterfaceSelectorMiddleware',
 u'mezzanine.core.middleware.SitePermissionMiddleware',
 u'mezzanine.pages.middleware.PageMiddleware',
 u'ga_resources.middleware.PagePermissionsViewableMiddleware',
 u'debug_toolbar.middleware.DebugToolbarMiddleware')

Traceback:
File "/usr/local/lib/python2.7/dist-packages/django/core/handlers/base.py" in get_response
  132.                     response = wrapped_callback(request, *callback_args, **callback_kwargs)
File "/home/docker/hydroshare/theme/views.py" in comment
  87.     if form.is_valid():
File "/usr/local/lib/python2.7/dist-packages/django/forms/forms.py" in is_valid
  184.         return self.is_bound and not self.errors
File "/usr/local/lib/python2.7/dist-packages/django/forms/forms.py" in errors
  176.             self.full_clean()
File "/usr/local/lib/python2.7/dist-packages/django/forms/forms.py" in full_clean
  392.         self._clean_fields()
File "/usr/local/lib/python2.7/dist-packages/django/forms/forms.py" in _clean_fields
  410.                     value = getattr(self, 'clean_%s' % name)()
File "/home/docker/hydroshare/theme/forms.py" in clean_comment
  110.         if settings.COMMENTS_ALLOW_PROFANITIES == False:
File "/usr/local/lib/python2.7/dist-packages/mezzanine/conf/__init__.py" in __getattr__
  231.             return getattr(django_settings, name)
File "/usr/local/lib/python2.7/dist-packages/django/conf/__init__.py" in __getattr__
  49.         return getattr(self._wrapped, name)

Exception Type: AttributeError at /comment/
Exception Value: 'Settings' object has no attribute 'COMMENTS_ALLOW_PROFANITIES'

@mjstealey Have just done some investigation, and it looks like the new Django version and Mezzanine version don't handle this setting as they used to any more. Have to modify some copied-over code from old Mezzanine to be in sync with the new updated version. Have assigned this issue to myself and will work on this once I get work done soon for follow-up resource versioning fix.

@mjstealey In the meantime, while you are at it testing, it'd be good to test account signup and login as well since that part of functionality is also customized from old version Mezzanine code. Let me know if anything does not work as used to so I can work on this Mezzanine-related update issues together. Thanks.

In the meantime, while you are at it testing, it'd be good to test account signup and login as well since that part of functionality is also customized from old version Mezzanine code

Great ideas! Will post new issues as they are discovered.
Also adding this to the Django 1.8 update milestone

@mjstealey Could you verify whether this has been fixed and close if the answer is yes?

@mjstealey Could you verify on www to see whether this has been fixed and close if the answer is yes?

Could you verify on www

Looks to be working as expected: https://www.hydroshare.org/resource/652f51ada673432eac25614cea892a6b/

@mjstealey Thanks! Yeah, it looks like it works as expected, and I also noticed you uploaded a 2.1GB for this test resource, so it appears 2GB upload is not an issue any more now, right?

it appears 2GB upload is not an issue any more

This is connection dependent... I've not had any issues with files up to 4 GB from within our network. From outside of our network this varies dramatically depending on bandwidth and latency.
I'd think capping our uploads to 2 GB with a bandwidth disclaimer is a fair thing to do.


Give Andrea Access to Zoom Admin

@AOrthVector @jmertic , how do I start zoom so that it is recorded on the server, rather than my local machine? Also, can I (or you) share the zoom credentials with Andrea so that she can be my backup for the meetings?

@AOrthVector I've sent you an invite to LastPass - when you get it let me know.

This is complete now. The shared credentials are in Andrea's LastPass


Bug/1463 filesystem permissions are not copied in certain cases

This change is to more explicitly set the file rights from the original file. In the case of fs.copyFile this is in theory not needed, but for fs.writeFile it is. Otherwise the default right would be 644, which is not always sufficient.
This change also introduces integration tests to cover these scenarios. For windows they are not run, as it is does not fully support changing file rights via chmod.
Fixes: #1463

if for the tests, the 777 is too scary, then this could also be changed

Confused emoji? Isn't this the test you've added in a separate PR?

I think you are confused with a different pr, the test that fails is indeed from this pr. But I just created a new pr for a different problem


fix(next-plugin): allow experimental key in NextJS configs to be unndefined

fixes #999

Ah, this is my bad. Thank you!


Redesign collection advanced stats

Hence we are the aspiring leading platform for analytics on RMRK, we are looking way to simplify ways to show collections stats and insights
Right now we added some which are important basic rules of thumb to detect if wash trading occurred if the collection has organic growth or velocity of adoption per collection for future collectors.
I'm opening the discussion to bit simplify without dropping numbers in this table to to be sensible incorporated into collection view.
One way I was thinking adding some fold or switch to see "advanced stats"

To better support any argument you have, best to post pictures+link from other platforms of how they are having it so we can better gauge something good from great to perfect!
@XyloDrone might want to speak on this! :)

@yangwao I'll see what we can dooo

@yangwao I'll see what we can dooo

yes, it's open for discussion to see for example how other platforms are showing it :)

Yes Ill do some research and post the links here

https://rarible.com/azuki/items
maybe something like this, clean with borders?

https://opensea.io/collection/0xmons-xyz
they have a simple one too with simplified texts and borders

stats changed


Docs site redesign update +1

Description of changes: Description of changes: The EKS Anywhere documentation site is being reorganized in this PR to make it easier for users to find similar content in generally the same locations.

/approve

/cherry-pick release-0.16


Stops, builds forever pending

I have all my builds currently pending. If I go to my runner, it says from the status:
root@vps36199:~# service gitlab-ci-runner status
Here is what we have at the moment:
runner is running with PID = 701

the builds are assigned to the runner, and the runner is not paused. Rebooting the machine or restarting the runner does not cause it to start again.
However, assigning it to all projects then remove it's assignments makes it start again.

Please provider additional information: version, how did you install it and so on.

v5.2.1, and I installed it on Ubuntu using the instructions from the README

Going to close this for ya'll since the project is deprecated and the go runner works great.


[REQUEST] Extract arguments from error

What is the feature you're proposing?
Extract arguments from error, like the actual command the user entered with all arguments So we can debug

This is a dupe of something on our 2022 roadmap and is planned for 4.1.


FIX# Displaying 'Diff' in new line

Issue #875

Thanks for tackling this, could you add a spec for it?

I began looking at https://github.com/rspec/rspec-mocks/issues/875 before realizing there was already this open PR for it. I decided to complete it and address the test coverage as @JonRowe suggests. Not to wish to interfere here, but I am happy to help try to close this if @sivagollapalli is unable to. Thanks!

@JonRowe Added spec for the issue. @myronmarston Removed extra space as you suggested.

Thanks, @sivagollapalli!


Optimize quota usage calculation

Contents

A refactor of User.last_billing_cycle, extracted to a mixin.
Added a method ServiceUsageMetrics.get_sum_by_date_range that minimizes the requests to redis, pretty much tailored to what quota checks do.
Added a method ServiceUsageMetrics.get_date_range to get a hash of {date => metric_value}, an interface aimed at fitting in the UsageMetricsRetriever
New methods integrated into clients of ServiceUsageMetrics derived classes.

Acceptance

[ ] On a staging, run the rake task cartodb:user_overquota:calculate and check the results got against master (through the console, with OverquotaUsersService.get_stored_overquota_users )
[ ] Provision a user with here geocoder provider and a few credits.
[ ] Make sure it can geocode below its quota and that the remaining quota is displayed correctly
[ ]  Make sure that it cannot run passed its quota.

@javitonino can you please take a look? especially the part concerning the UsageMetricsRetriever thanks!

@javitonino one last look, please? I wrote a UsageMetricsInterface and made ServiceUsageMetrics and MapviewsUsageMetrics implement it.


Refactor CSSContainer

CSSContainer was build straight forward to support server-side CSS as fast as possible. Now that there's everything working fine again, we should focus on refactoring some newer stuff and add proper tests to improve code quality and reduce package size.

Got a new face introducing the CSS transformation. Should be closed.


Remove disable csrf protection for callback get request

Checklist

[x] Test your changes as thoroughly as possible before you commit them. Preferably, automate your test by unit/integration tests.
[x] Make sure mvn install runs for the whole project and, if you touched any code in the respective service, submission and distribution service can be run with spring-boot:run

Description
Enable csrf protection for callback service

is that all we need? just disabling it? what about adjusting integration tests? what needs to be done then on client side (EFGS)?


Clean DB before tests, not after

Summary
At the moment, we tear down the data from the test database at the end
of a function that uses a db_session. This is problematic as some of our
migrations inject data into the database, which might then conflict with
what tests expected. This happens to work fine if you are running the
full test suite, as by the time you get to the functions that have
conflicting data, the pre-existing data has been removed. But if you try
to run a single specific tests (e.g.
test_can_reject_a_measure_in_review_as_editor), then you get a PK
conflict error as the test stubs try to insert a record that conflicts
with data inserted by the migrations.
By removing the data before tests that use the DB, we can prevent this
problem. A side-effect is that the test DB might be left in a 'dirty'
state at the end of test runs. This feels acceptable, and possibly even
preferrable, so that you can easily look into the database after a
failed test to see the state it's at.

Presumably none, because that behaviour hasn't changed ... but I'll try it anyway, as it's a good point that it's probably weird.

@TheDoubleK Updated the materialized views after each reset. Looks fine. 👍


fix(types): export output component types

Expose the output tab components such as EnterpriseContract, ACS component types to consumers.

Merging with other PR


Question and answer session details

Add question and answer session details page
Adds a page with brief "webinar" details only visible to eligible suppliers. The page displays Q and A session details from the brief.
If the details weren't set the link from the brief page should be hidden, and this view URL will show an empty page with a "Return to brief" link.
Add CSS rule for .padding-bottom-small
Class is already used by frameworks/agreement.html template and the same class is defined and used in the buyer frontend.
Fix ask brief clarification question header width
Moves header inside the 2/3 div and fixes the order of closing tags.
[#117296475] Update brief clarification question sent confirmation banner

Changes for the new page all good - :+1: once we work out what to say about the date.


Update setup-core-components.md

When importing the CentreOfExcellenceCoreComponents managed 2_0 solution I was asked to also setup a Microsoft Teams connection. I think it is missing from the unordered list in the import steps.

This has been changed in our main branch now.


Get view holder in event hooks, e.g. on click

About this issue
I need to get the ViewHolder in my OnClickListener. Is this somehow possible? If not, could the EventHookUtil.attachToView and the ClickEventHook be changed to also pass the ViewHolder?
If someone uses DataBinding in the ViewHolders I don't want the view in my events but the ViewHolder to get access to the DataBinding so that I can access the sub views efficiently...
Details

[x] Used library version: 3.2.7
[x] Used support library version: 27.1.1
[x] Used gradle build tools version: 4.6

you get the view via the event hook here: https://github.com/mikepenz/FastAdapter/blob/develop/library-core/src/main/java/com/mikepenz/fastadapter/listeners/ClickEventHook.java#L14
you can set the ViewHolder as tag to that view and then just retrieve it.
Be careful though accessing it, as during scrolling things can always be reycled and no longer active


Added Bubble sort

Added Bubble sort

Created Function instead of Main function for bubble sort

@ekdnam  can you please merge the code I have created function instead of Main function


Logging nrf52840 - Check return value of vsnprintf

Return value of vsnprintf is not checked

I signed it!


Use the symbols if they are already loaded

This PR is part of this other PR https://github.com/ignitionrobotics/ign-sensors/pull/38 and it's related with this issue https://github.com/ignitionrobotics/ign-sensors/issues/18
The symbols for some sensors are already loaded when the ignition::gazebo::systems::Sensors is loaded (In particular Camera and ThermalCamera). Instead of creating the sensor using the Manager class (which needs to reload the library which is already loaded by the system Sensor, it's generating some issue.) I instantiated the class and add it to the Manager.
Signed-off-by: ahcorde<EMAIL_ADDRESS>

We're retargeting the upstream PR https://github.com/ignitionrobotics/ign-sensors/pull/38 to Ign-E, and this one as well. Removing from the Dome beta.

With the proposal on https://github.com/ignitionrobotics/ign-plugin/pull/35, I think this PR isn't necessary.

Removing beta label, we won't have time to wrap this up before code freeze. Let's retarget at Ignition-F.

Superseded by #617


pull request for e2e test at 01/08/2017 15:15:09

:white_check_mark: Validation status: passed
For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Prepare for 0.9.0

Bump ActiveAdmin version
Bump Rails version
Bump Devise version
From @deivid-rodriguez
Remove unused gemfile and lockfile
Remove unused stuff from Gemfile
Use https source to prevent bundler warning

The git source
`git://github.com/activerecord-hackery/ransack-mongoid.git` uses the
`git` protocol, which transmits data without encryption. Disable this
warning with `bundle config git.allow_insecure true`, or switch to the
`https` protocol to keep your data secure.

Move pry-rails to main group
bundle update
Fix RSpec deprecation warning

Requiring `rspec/autorun` when running RSpec via the `rspec` command is
deprecated. Called from
/path/to/activesupport-5.2.2/lib/active_support/dependencies.rb:291:in
`require'.

Thoughts on waiting for a PR for #138 ?

I'd include rubygems badge as well 😉

@grzegorz-jakubiak Will you please add that and push to this branch?

@boie0025 done


[CI] Have a Meshery development environment on AWS

Current Behavior
We don't have a dev environment of Meshery where we can access through the UI
Desired Behavior
Have Meshery UI deployed in AWS to be accessed for everyone
Implementation
Use EC2 instances or EKS service to deploy Meshery UI.
Reference:

Meshery Build & Release Strategy

Is this going to need a minikube installation to run in the dev enviornment?

Is this going to need a minikube installation to run in the dev enviornment?

Not really. If we use EKS, the Kubernetes runner is already there. If not, we can use KinD.

@ramrodo Is this planned for anytime soon?

@kumarabd not soon but I hope before next month. Is it urgent?

@kumarabd not soon but I hope before next month. Is it urgent?

nope it isn't a P1. Just checking in for an update.

Uhm, is it cool if i take this?, i could get KinD set up on EC2. Also must this be on AWS?

Hi @s1ntaxe770r , thanks for jumping on this. Sure, you can take this. It should be on AWS because we have an account set up there. Yes, you can do it with KinD + EC2, also I was considering using EKS that uses EC2 under the hood. But we can compare the two options and choose the better (or the cheaper).

I'm not sure what the budget is but, EKS would set us back at least $75 monthly , while ec2 + K3d  would be around $30, Also i think k3d would work better than kind in this case
https://k3d.io/


404 at /engine/installation/linux/debian/

URL: /engine/installation/linux/debian/

I got that from your store webpage https://store.docker.com/editions/community/docker-ce-server-debian/plans/docker-ce-server-debian-tier when I clicked on the link under Install Instructions. https://docs.docker.com/engine/installation/linux/debian/

This actually does work. It redirects to https://docs.docker.com/engine/installation/linux/docker-ce/debian/. Make sure Javascript is enabled and please reopen this issue if you still see an issue.


MMB: Use View instead of div in mmb-Wrapper

Using div instead of View broke the functionality of nested scroll view.
It no longer scrolled

@JoseDuSV 🚀


VM Set Up

[x] VM specs are documented and shared with Mike/NCC

[x] Request for tools to be installed submitted

The AWS SCT and Ora2Pg tools have interactive GUI interfaces that could be very useful and would be easier to install & configure on a windows server. Mike and I have discussed setting up a 4 core, 16 GB RAM, 500 GB storage windows VM.

VM specs have been identified above, however, not sure that we would get admin privs to install so we are now going down the path of requesting that the AWS SCT tool be installed on the VDI Pro VM pool. Request has been made and instructions sent to NCC group.


feat(models): Introducing Dataset Partitions Aspect

Summary
In this PR we add the dataset partitions aspect, required to collect partition stats for each. I will also raise the same PR to OSS.
Status
Ready for review.
Checklist

[ ] The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
[ ] Links to related issues (if applicable)
[ ] Tests for the changes have been added/updated (if applicable)
[ ] Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
[ ] For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

Summary by CodeRabbit

New Features

Introduced new data structures for managing dataset partitions, enhancing data organization and retrieval.
Added new records for partition key definitions and summaries to improve metadata management within datasets.
Expanded the metadata registry with entries for dataset partitions and partitions summary for better access control and structure.

Bug Fixes

Clarified the purpose and usage of the PartitionSpec record, including the deprecation of the PartitionType enum for better clarity.

Unrelated ci is failing


test-branch/execute-job/fork-branch/097cced3-c732-442d-bac0-c74485b9826d

PR for testing d1f03d18ccef461262ee6a2514af1991aa74c0b7

padding /canonical/self-hosted-runners/run-workflows d1f03d18ccef461262ee6a2514af1991aa74c0b7 padding


discussion: thoughts on transferring into sphinx-contrib

@tonybaloney, curious if you have any opinions of possibly transferring this repository into the @sphinx-contrib organization [1]. I believe there can be advantages in moving (visibility, better chance for more maintainers, etc.). Although, if you prefer to leave the repository in its current location, that is fine by me and this issue can be closed.
[1]: https://groups.google.com/forum/#!topic/sphinx-dev/y_1LgQgD_Ro

this is a great idea

@jdknight in the meantime can you check if you can merge pull requests now?

@jdknight in the meantime can you check if you can merge pull requests now?

Confirmed; with the peer review requirement disabled, I now have the ability to merge in my own requests (assuming that is what you are looking for).

this is a great idea

I assume you are for the transferring a repository (to move all the active pull requests, issues, etc.) based on this commit.
@stephenfin (pulled your name from the group and matched it to the sphinx-dev Google group), would you be able to assist in this matter (if sphinx-contrib still likes to be a container for these projects and does not mind the inclusion of the sphinxcontrib-confluencebuilder project)? I suspect once a repository transfer can be made, the end goal would be to still have @tonybaloney and myself (@jdknight) with access to manage the repository (assuming that is how the sphinx-contrib organization works).

I've invited you both to the organization. This should let you transfer the project. Ping me if you've any issues doing so.

Done! thanks @stephenfin @jdknight

@stephenfin please can you setup a team where @jdknight and I have maintainer control over this repo (merge, close, tag, etc.)

The original owner of the repo should have maintainer rights, including the ability to add new maintainers. If that's not the case, let me know and I can manually add people (or explore teams, as you suggest)

@jdknight do you have control to merge PR's etc now?

@tonybaloney looks good on my end.

It's a nit, but if possible could you drop the sphinxcontrib- prefix from the project name (though not the package name, obviously)? It's superfluous given the organisation name :smile:

It's a nit, but if possible could you drop the sphinxcontrib- prefix from the project name (though not the package name, obviously)? It's superfluous given the organisation name 😄

In the GitHub project name? The pypi package name would remain the same.

Correct. Keep the package name as-is but switch sphinx-contrib/sphinxcontrib-confluencebuilder to sphinx-contrib/confluencebuilder. Just a nit thought

Correct. Keep the package name as-is but switch sphinx-contrib/sphinxcontrib-confluencebuilder to sphinx-contrib/confluencebuilder. Just a nit though

@stephenfin i agree, I can’t make the change though. only the org admin can do that.

Ah, if you're ok with me doing that, I can do so

@stephenfin 👍 from me and @jdknight

(that's all you need :-))

Done and done. Thanks, both. I guess this can be closed now?

I believe so. Thanks @stephenfin for the help; thanks @tonybaloney for promoting the move.


Timeline: Codicons are off

//cc @sandy081 @alexr00 for views

I assume this is nothing to do with the views instead its about how entires are rendered in list/tree. CC @joaomoreno

@sandy081 Tree row contents are our of the tree's jurisdiction, but are in fact responsibility of the widget user.

Timeline doesn't use the extension tree view and instead does it's own thing. I think @lramos15 works on timeline.

@daviddossett curious, do we have an understanding what caused this? it seems relatively recent?

Might be related to #158250. @benibenj any ideas here?

It was caused by https://github.com/microsoft/vscode/commit/dffbdebac52a09539eb720d059d5a21f86fb7524, @alexr00 can you check? I see a visual difference not only with the alignment:
Before

After

@lramos15 it looks like timeline relies on the custom tree view css. I made a change in the nesting/ordering of elements in the tree view recently and I updated the css to reflect that. Because timeline relies on the css but doesn't actually use the custom tree view, this broke the timeline. I've opened a PR with a timeline specific css fix.

Issue marked as unreleased but unable to locate closing commit in issue timeline. You can manually reference a commit by commenting \closedWith someCommitSha, or directly add the insiders-released label if you know this has already been releaased


OnDiscordGuildMemberUpdated hook is not working, but correct me if I'm wrong

Correct me if I'm wrong


Better documentation/patterns around required configuration variables

@seanpreston @rsilvery this is currently the error we give when people try to run the webserver without the required variables:
There are missing required configuration variables. Please add the following config variables to either the `fides.toml` file or your environment variables to start Fides:

- app_encryption_key
- oauth_root_client_id
- oauth_root_client_secret

Do we feel that this is good enough? How else might we want to document this?

Do we feel that this is good enough? How else might we want to document this?

A link to the docs that explains the config vars and how to provide them in more detail is the main thing missing here I think

Do we feel that this is good enough? How else might we want to document this?

A link to the docs that explains the config vars and how to provide them in more detail is the main thing missing here I think

Good call, I can add this to the message

@seanpreston I failed at copy/pasta, this is the full error message:
There are missing required configuration variables. Please add the following config variables to either the `fides.toml` file or your environment variables to start Fides:

- app_encryption_key

Visit the Fides deployment documentation for more information: https://ethyca.github.io/fides/deployment/

@conceptualshark  can you sign off here? @seanpreston we're trying to embed Cole into this process more.

@rsilvery For the error message copy? This seems fine to me.

Excellent, closing as complete :)


Add a public CancelAll method to a StreamLayerClient

Resolves: OLPEDGE-975
Signed-off-by: Mykhailo Kuchma<EMAIL_ADDRESS>

I'd elaborate inside the commit message or inside the method doc on why the method must be public. E.g. why and when someone needs to explicitly cancel all requests instead of just killing the client, etc.


Add scope exclude for spotbugs

Signed-off-by: Stefano Bennati<EMAIL_ADDRESS>Please ensure that your pull request adheres to our contribution guidelines. Thank you!

@bennati looks like you configured your Git username "in reverse", swapping first and last name. The committed / author address has to match exactly what's being used in the Signed-off-by footer: Stefano Bennati<EMAIL_ADDRESS>Please fix that, and also rebase onto latest main for some test updates.

done


Clippy, rustfmt, Cargo metadata updates

[x] I agree to follow the project's code of conduct.
[x] I added an entry to CHANGES.md if knowledge of this change could be valuable to users.

bors r=michaelkirk


[ROCm] Adding ROCm support for the training ops

This PR adds ROCm support for the training ops.
This is a trivial change...please review and merge.
Thanks
deven

@tatianashp , @whchung just FYI

@deven-amd can you please check build errors

@rthadur, how do I access the log with the build errors...I do not see any links on my end


ADBDEV-4938-55: Add assertions to return from dynamic_cast.

Add assertions to return from dynamic_cast.
dynamic_cast may return NULL, so I added assertions.

https://github.com/arenadata/gpdb/pull/806


After successfully logging in, you can view the user's plaintext password via F12 (Developer Tools).

Bug description

How to reproduce the bug
1.go to login page and input username、password，and submit "Sign IN"
2.Press F12 to open (Developer Tools) on welcome page
Screenshots/recordings
No response
Superset version
3.0.4
Python version
3.9
Node version
16
Browser
Chrome
Additional context
No response
Checklist

[ ] I have searched Superset docs and Slack and didn't find a solution to my problem.
[ ] I have searched the GitHub issue tracker and didn't find a similar bug report.
[ ] I have checked Superset's logs for errors and if I found a relevant Python stacktrace, I included it here as text in the "additional context" section.

This is normal since your viewing your own payload on sent by the form POST on the developer tools.
Feel free to reopen if this is not the case


Make Prestissimo the very first package to be globally required

Description
Make Prestissimo the very first package to be globally required
Motivation and Context
So all the other packages below it will benefit from the parallel installs
Types of Changes

[] Bug fix (non-breaking change which fixes an issue).
[x] New feature (non-breaking change which adds functionality).
[] Breaking change (fix or feature that would cause existing functionality to not work as expected).

Definition of Done Checklist:

[] I've read the Contribution Guide.
[] I've updated the documentation. (refer to this for how to do so).


Fix PR template links

Changes

Changed the links to contributing.md and code_of_conduct.md to point to the files instead of a 404 page

Checklist

[x] Read the contribution guide and accept the code of conduct
[x] Readme (updated or not needed)
[x] Tests (added, updated or not needed)

Oh my 😆. I must have been dreaming when I created those.
Thank you very much!

Hmm actually this didn't use to be broken as far as I know. I did it like this in all repos.

Felt like it should have worked before yes. I found out it didn't work when I made a PR earlier today and wanted to read the files and got a "Not found" page


Problem with Java 8 "Object::new"

Someone, doing a "::new" notation on something like "Object::new" breaks the code block. Not sure if it comes from this extension or of the java syntax parser.
Object::new

I did reproduce this issue, but I think it's a problem with the java syntax highlighter. the bash highlighter has similar issues. Closing for now but we can reopen if needed


"balance" is awkward in listpeers channels

      "channels": [
         {
            "short_channel_id": "HIDDExHIDDENx1",
            "local_balance": 948887,
            "remote_balance": 51113,
            "balance": 0.948887,
            "state": "CHANNELD_NORMAL"
         }

The word balance here feels wrong while the other two numbers are  *_balance. This number is more of a ratio or a fraction?
Any thoughts for a better word to use here?

I am on your page here. It is not a balance at all but more a ratio or portion. Question is, why do we need this field at all? One could just calculate it by themselves by dividing the local_balance by the sum of remote_balance and local_balance.
Any thoughts about dropping this field entirely?

It could be related to a desired target channel ratio. For example many channels want to be 50% while others want to be mostly on one side or the other. I think keeping it is fine but I am really unsure what it should be called.

I am on your page here. It is not a balance at all but more a ratio or portion. Question is, why do we need this field at all? One could just calculate it by themselves by dividing the local_balance by the sum of remote_balance and local_balance.
Any thoughts about dropping this field entirely?

I think that field is pretty valuable in the context of desired target channel ratio. I would personally like to call swap-in with a desired ratio e.g. 0.50 and then peerswap would determine the sats needed.
I agree that balance is misleading. Also is 1.0 all balance on my side or on my peers side?

Discussion: localpercentage might be the closest name to intended meaning. Anyone have a better idea?

sgtm!


FlatList's RTL rendering broken for Android

Description:
The Flat list component works fine for iOS for both the cases when RTL is forced and in case when it is not.
But in case of Android, it doesn't work fine when RTL is forced, in case the content which it needs to render doesn't exceeds the frame of the FlatList. In such case FlatList Renders content from LTR and not RTL.

React Native version:
System:
OS: macOS Mojave 10.14.6
CPU: (8) x64 Intel(R) Core(TM) i7-4770HQ CPU @ 2.20GHz
Memory: 1.41 GB / 16.00 GB
Shell: 3.2.57 - /bin/bash

Binaries:
Node: 12.1.0 - /usr/local/bin/node
Yarn: 1.13.0 - /usr/local/bin/yarn
npm: 6.9.0 - /usr/local/bin/npm
Watchman: 4.9.0 - /usr/local/bin/watchman
SDKs:
iOS SDK:
Platforms: iOS 12.4, macOS 10.14, tvOS 12.4, watchOS 5.3
Android SDK:
API Levels: 23, 25, 26, 27, 28, 29
Build Tools: 28.0.3, 29.0.0
System Images: android-23 | Google APIs ARM EABI v7a, android-28 | Google Play Intel x86 Atom, android-29 | Google APIs Intel x86 Atom, android-29 | Google Play Intel x86 Atom
IDEs:
Android Studio: 3.4 AI-183.6<IP_ADDRESS>22156
Xcode: 10.3/10G8 - /usr/bin/xcodebuild
npmPackages:
react: 16.9.0 => 16.9.0
react-native: 0.61.5 => 0.61.5
npmGlobalPackages:
react-native-cli: 2.0.1
Steps To Reproduce
import React, {Component} from 'react';
import {
StyleSheet,
View,
FlatList,
I18nManager,
Text,
Dimensions,
} from 'react-native';
const {width} = Dimensions.get('window');
const guidelineBaseWidth = 375;
const scale = size => (width / guidelineBaseWidth) * size;
I18nManager.forceRTL(true);
export class SignInScreen extends Component {
render() {
const DATA = [
{
id: 'bd7acbea-c1b1-46c2-aed5-3ad53abb28ba',
title: 'First Item',
},
{
id: '3ac68afc-c605-48d3-a4f8-fbd91aa97f63',
title: 'Second Item',
},
];
return (

<FlatList
style={{backgroundColor: 'red'}}
horizontal={true}
data={DATA}
renderItem={({item}) => (
<View
style={{
backgroundColor: '#f9c2ff',
padding: 20,
marginVertical: 8,
marginHorizontal: 16,
}}>
{item.title}

)}
keyExtractor={item => item.id}
/>

);
}
}
const styles = StyleSheet.create({
container: {
flex: 1,
backgroundColor: '#ffffff',
},
header: {
width: '100%',
height: scale(215),
alignItems: 'center',
justifyContent: 'center',
},
logo: {
width: scale(130),
height: scale(40),
},
});
Expected Results

First Item should be right aligned and not left aligned

+1

+1

same issue


Release Google.Cloud.ApiKeys.V2 version 1.3.0

Changes in this release:
New features

Change netstandard2.1 target to netstandard2.0 (commit 82bea85)

Created release for Google.Cloud.ApiKeys.V2-1.3.0


redisClusterAsyncConnect() timeout option

We have noticed that redisClusterAsyncConnect() blocks if the server is unavailable/unreachable. We understand that the timeout option is available for commands only after context creation, but is there a way to make redisClusterAsyncConnect() return error if the connection creation has not succeeded after a certain amount of time?
Thank you.

Setting the option redisClusterSetOptionConnectTimeout() should work for connection timeouts.
There is a testcase which uses an alternative connect API, but redisClusterAsyncConnect() should work in a similar fashion.
https://github.com/Nordix/hiredis-cluster/blob/6c0aecfcf1df378494e81fa69f2645eb4c5e6de1/tests/ct_connection.c#L498-L521

Great, we will try this out.
Thank you for the support.

We have tried as in the example you mentioned & async connection timeout works with redisClusterConnect2().
But doesn't work with redisClusterAsyncConnect(). Could you please let us know if that is expected?
Thank you.

Since redisClusterAsyncConnect() both creates the context and perform a connection attempt you will not be able to configure the timeout for this attempt. So this is currently expected and the above example is your way forward I believe.

Ok, the example works for us.
Thank you.


Different Color Shapes on Mobile and Desktop (Obsidian)

When I create a shape, the colors are different on mobile vs. desktop. I have the settings for new drawings to follow the Obsidian theme, existing ones to do the same, and for Excalidraw to follow when Obsidian changes theme.

When I create drawings on the desktop version in obsidian, any lines appear correctly, in a lighter color. (Because I have dark mode on). However, on mobile, the display in a darker color, and I am not able to see them. When I open the actual file on mobile, it shows the lighter color. The embed itself is different for some reason. I have Obsidian Sync, and the settings for Excalidraw are syncing, and are the same. I'll be thankful for any help.
Mobile

Desktop

cc @zsviczian


Support Multiple Configuration FIles

openlane.config

New __main__ created

CLI to interactively create configuration files based on prompts

Config

Updated to support an arbitrary number of a combination of Tcl files, JSON files and python dictionaries (or any object conforming to Mapping) to create configuration files, each with their own Meta values
design_dir can now be set explicitly, but if unset will take dirname of last config file passed (if applicable)
Internally unified how Tcl-based configurations and others are parsed

openlane.cli

Renamed internal _force_design_dir option into new option design_dir now explicitly supported by OpenLane configs

openlane.flows.Flow

Updated constructor to support multiple configs

TODO: Add tests

@kareefardi Would you try this with caravel when you have a moment?


many settings arent calling for a reload like they should

for example when changing bottom panel/top panel toggle from off to on or vice versa.. it wont apply due to it requiring a reload.  After a reload it does but normally with toggles which require a reload a prompt will pop up stating so within svui.  For these two specifically, i dont "recall" them requiring a reload previously and maybe that is in fact the bug.  Maybe they dont call for a prompt because they dont need it and for some reason they are needing a reload now.  I know a lot of the dock settings used to be toggle'able in real time but Ive used this for so long with the same config that ive forgotten.
minor relative to alot of the other stuff im sure, but could cause a ton of tickets here without people realizing things require a reload to apply in certain cases.
dont worry - im running low on issues now lol

If you can supply some examples I'll look into it.

okie dokie, will start compiling a list :)


Truncates all characters

I am using Trunk8 for a website where it needs to truncate names in a table cell. When the website is viewed on mobile some non-essential things get trucated.
Yesterday on my Mac on Firefox 37.0.2 it worked without a problem, but after checking today on my Windows machine the text does not show up at all. This is on Firefox 37.0.2 and Chrome 42.0.2311.135. The complete text is in the "title" tag of the table-cell with the truncate class. If I press Ctrl + F5 it works correctly, but if I then just press F5 or close and reopen the page the text is gone again.
I have included jQuery 1.7 in my head and have called $(".truncate").trunk8(); below that.
On pageload:

After pressing Ctrl + F5:

Do you have a link to view the markup? (even if it's just a simple jsfiddle example that shows your problem, that would be fine)
Also, just a tip that you shouldn't need to load jQuery and trunk8 in the document head. You should be able to load these scripts at the end of the document, just before the closing body tag. I don't think it's causing the problem you're describing, but it helps page load performance.

Hi Rick,
Thank you for contacting me, much appreciated. I’ve tried using Trunk8 in a jsFiddle bit it appeared to be working fine.
As the project is in a very early stage I have no problem giving you some login credentials, the site is in Dutch but I can point you around:
Visit: http://www.nickbetting.nl/yd/
Username: Rick Viscomi
Password: testing123
Wekelijkse toegangscode: 0000
After you’ve been logged in click the “ga naar beheerpaneel” link just below the logo. Now you can click either “Locaties” or “Medewerkers” to view where it’s going wrong. I’m using Windows 8.1 with Firefox 37.0.2, Chrome 42.0.2311.135 m, Internet Explorer 11 and Opera 29 and it works on none of those. If I log in with my iPhone under Safari it works without a problem.
Thank you so much for the help!
Kind regards,
Nick Betting
Van: Rick Viscomi<EMAIL_ADDRESS>Verzonden: donderdag 7 mei 2015 05:28
Aan: rviscomi/trunk8
CC: s1h4d0w
Onderwerp: Re: [trunk8] Truncates all characters (#64)
Do you have a link to view the markup? (even if it's just a simple jsfiddle example that shows your problem, that would be fine)
Also, just a tip that you shouldn't need to load jQuery and trunk8 in the document head. You should be able to load these scripts at the end of the document, just before the closing body tag. I don't think it's causing the problem you're describing, but it helps page load performance.
—
Reply to this email directly or view it on GitHub https://github.com/rviscomi/trunk8/issues/64#issuecomment-99699631 .  https://github.com/notifications/beacon/AFZIfteJthypD8wU_NRtiALOKGAWJ6m7ks5oGtMugaJpZM4ERCYu.gif

It seems to be working for me on Chrome Mac, but one thing I noticed is that your trunk8 class is on a td element. Try structuring your markup like this instead:
text

I think the default styles on the td may be interfering with the way the text gets rendered.
Let me know if that helps.

Hi Rick,
That fixed it, thanks a bunch. I assumed it would work on any element, I saw some reported issues on other elements but didn't see any for 's. By putting the text in a separate  it worked flawlessly.
Thanks and keep up the good work!


(maint) Allow factset ordering on hash

This corrects an oversight in adding the hash field to factsets that left
ordering results on hash impossible. I'm not a fan of the solution here, but it
follows our approach for environments and I can't think of a better way ATM.
The constraints are:
a) The factsets query must be "doubled up" in jdbc.clj so that paging options are applied
on an object basis instead of a by-row basis (a factset comprises multiple rows.)
b) Both environment and hash are nullable fields in factsets, so a COALESCE is
necessary to prevent a "WHERE null IN null" scenario.

CLA signed by all contributors.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://jenkins.puppetlabs.com/job/platform_puppetdb_intn-sys_pr/387/

@pljenkinsro retest this please

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://jenkins.puppetlabs.com/job/platform_puppetdb_intn-sys_pr/390/


fix: setting path arg in a new line for all commands

What
Path arg should be in a new line so that each argument for the aws commands are in a new line
Why
Helps the identify each arg for the command easing understanding

/lgtm


Fix GUI Editor not saving Control observables

Fixes https://github.com/BabylonJS/ThePirateCove/issues/389

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

Snapshot stored with reference name:
refs/pull/13682/merge
Test environment:
https://babylonsnapshots.z22.web.core.windows.net/refs/pull/13682/merge/index.html
To test a playground add it to the URL, for example:
https://babylonsnapshots.z22.web.core.windows.net/refs/pull/13682/merge/index.html#WGZLGJ#4600
Links to test babylon tools with this snapshot:
https://playground.babylonjs.com/?snapshot=refs/pull/13682/merge
https://sandbox.babylonjs.com/?snapshot=refs/pull/13682/merge
https://gui.babylonjs.com/?snapshot=refs/pull/13682/merge
https://nme.babylonjs.com/?snapshot=refs/pull/13682/merge
To test the snapshot in the playground with a playground ID add it after the snapshot query string:
https://playground.babylonjs.com/?snapshot=refs/pull/13682/merge#BCU1XR#0


"Include special" tick box is not sticky

Visiting e.g. https://metasmoke.erwaysoftware.com/domains/tags?utf8=✓&include_special={%3Achecked%3D>false}&filter=AS-13335 reveals a page where the "Include special" box is not ticked, even though the search it is displaying used to have it ticked.

Looks like the value in the query is {:checked=>false}.

Oh, my bad; that's the URL I ended up with but I should have paid attentien to it. Anyway, this is easy enough to repro; tick the box, click search, observe that the box is now unticked again (and the resulting URL says as much).
Sent with GitHawk


To discuss: add flag to watch-administration.sh to watch singe plugin

Currently we have a custom .sh file because in our setup shopware-cli does't seem to work and we can't use shopware-cli extension admin-watch.
This results in a unusable admin watcher for large projects.
So we came up with this:
#!/bin/bash

CWD="$(cd -P -- "$(dirname -- "${BASH_SOURCE[0]}")" && pwd -P)"

set -euo pipefail

# We need to have the original plugin.json, so dump it and filter it afterwards
BIN_TOOL="${CWD}/console"
"${BIN_TOOL}" bundle:dump

# Extract the plugin name from the parameters
while [[ $# -gt 0 ]]; do
  key="$1"

  case $key in
    --plugin)
    plugin="$2"
    shift # past argument
    shift # past value
    ;;
    *)    # unknown option
    shift # past argument
    ;;
  esac
done

# Define the list of keys to keep
keys_to_keep=('Framework' 'System' 'Content' 'Checkout' 'Profiling' 'Administration' 'Storefront' 'Maintenance' $plugin)

# Read the JSON file and filter it with jq
filtered_json=$(jq -c 'with_entries(select(.key as $k | ["Framework", "System", "Content", "Checkout", "Profiling", "Administration", "Storefront", "Maintenance", "'$plugin'"] | index($k)))' var/plugins.json)

# Overwrite the original file with the filtered JSON
echo $filtered_json > var/plugins.json

# Run the watcher without dumping the bundles again, so we only use our own plugins
APP_ENV=prod SHOPWARE_SKIP_BUNDLE_DUMP=1 bin/watch-administration.sh

This makes something like this (bin/watch-administration.sh):

Into this (bin/watch-admin-plugin.sh --plugin AdyenPaymentShopware6):

Just for discussion, perhaps there are downsides. I don't know :)

Sounds good. Let's integrate it directly inside watch-administration.sh 🤔


Force-push stack buffered from previous game

Hold shoulder button to force raise until dead, quit out, start a new game, the stack will automatically rise one row.

this is still a big issue, why did you remove it from the milestone @omenking ?

i knew of this bug but cant recreate it anymore, has this been fixed by someone?

fixed it
On Feb 25, 2018 7:05 AM, "Michael"<EMAIL_ADDRESS>wrote:

i knew of this bug but cant recreate it anymore, has this been fixed by
someone?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/omenking/swap-n-pop/issues/263#issuecomment-368303907,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAAeYE7sjTinAh79rArAHSPDLCdeLw3Kks5tYUyVgaJpZM4RaZqE
.


Jd/pm update

This PR updates to PM v0.13, re-exports the supported networks.
Also fixes #233 and #235.

Codecov Report

Merging #234 into master will decrease coverage by 0.82%.
The diff coverage is 81.25%.

@@            Coverage Diff             @@
##           master     #234      +/-   ##
==========================================
- Coverage   58.68%   57.85%   -0.83%
==========================================
  Files          62       62
  Lines        2442     2477      +35
==========================================
  Hits         1433     1433
- Misses       1009     1044      +35

Impacted Files
Coverage Δ

...rc/devices/device_constructors/load_constructor.jl
93.1% <ø> (ø)
:arrow_up:

src/devices/device_models/thermal_generation.jl
96.35% <ø> (ø)
:arrow_up:

...device_constructors/hydrogeneration_constructor.jl
43.47% <ø> (ø)
:arrow_up:

src/core/core_structs/service_model.jl
0% <ø> (ø)
:arrow_up:

src/devices/device_models/common/pm_translator.jl
95.55% <ø> (ø)
:arrow_up:

src/devices/device_models/storage.jl
97.14% <ø> (ø)
:arrow_up:

src/core/core_structs/canonical_model.jl
84.21% <ø> (ø)
:arrow_up:

...ce_constructors/renewablegeneration_constructor.jl
65.85% <ø> (ø)
:arrow_up:

...devices/device_constructors/storage_constructor.jl
94% <ø> (ø)
:arrow_up:

...vice_constructors/thermalgeneration_constructor.jl
92.7% <ø> (ø)
:arrow_up:

... and 20 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9e7929e...a7ca2f7. Read the comment docs.


correct typo with km_models_ to handle the case where y is None

Hi, this is a small typo where the parameter km_models is defined with and without an underscore depending on whether y is set or not.
This is my first PR, so do not hesitate to tell me if I have done something not correct.
And thanks for the book, I enjoy it 😃


Takes over 10 seconds to construct VideoCapture object

Constructing the VideoCapture object for optical tracking can be really slow. I clocked it at 13+ seconds using a Logitech Quickcam IM model V-UBB39. Based on my experiments in #10, it may be that the constructor waits for the capture buffers to fill up before it returns. With my configuration the frame rate was around 15 fps and it was buffering around 161 frames, which is about 10.7 seconds of buffer time.

It looks like opencv, in cv::VideoCapture::open, first attempts to do direct MJPEG capture via cv::createMotionJpegCapture, but this fails, and then it falls back onto cvCreateFileCaptureWithPreference, which uses FFMPEG; and FFMPEG, lacking any information about the input format to expect (as opencv doesn't provide any such info), decides to buffer a ton of frames so that it can deduce the input format before it concludes the opening process.
It may be that opencv's MJPEG capture code only works if the MJPEG encoded video is in an RIFF container, which may not be the case with our particular webcam, or perhaps all webcams, for all we know. May warrant further investigation, depending on how much time we want to spend debugging this garbage.
MJPEG attempt:
#0  0x00007f9b797ba02d in read () at /usr/lib/libc.so.6
#1  0x00007f9b79750598 in __GI__IO_file_underflow () at /usr/lib/libc.so.6
#2  0x00007f9b7974f608 in __GI__IO_file_xsgetn () at /usr/lib/libc.so.6
#3  0x00007f9b79743eb1 in fread () at /usr/lib/libc.so.6
#4  0x00007f9b7106111e in cv::MotionJpegCapture::parseRiff(cv::MjpegInputStream&) () at /usr/lib/libopencv_videoio.so.3.2
#5  0x00007f9b7106170d in cv::MotionJpegCapture::MotionJpegCapture(cv::String const&) () at /usr/lib/libopencv_videoio.so.3.2
#6  0x00007f9b71061816 in cv::createMotionJpegCapture(cv::String const&) () at /usr/lib/libopencv_videoio.so.3.2
#7  0x00007f9b7104dc41 in cv::VideoCapture::open(cv::String const&, int) () at /usr/lib/libopencv_videoio.so.3.2
#8  0x00007f9b7104eaae in cv::VideoCapture::VideoCapture(cv::String const&) () at /usr/lib/libopencv_videoio.so.3.2
#9  0x00007f9b76436e32 in pyopencv_cv_VideoCapture_VideoCapture(_object*, _object*, _object*) () at /usr/lib/python2.7/site-packages/cv2.so
#10 0x00007f9b79d8dc60 in PyEval_EvalFrameEx () at /usr/lib/libpython2.7.so.1.0
#11 0x00007f9b79d918dc in PyEval_EvalCodeEx () at /usr/lib/libpython2.7.so.1.0
#12 0x00007f9b79d161bb in function_call () at /usr/lib/libpython2.7.so.1.0
#13 0x00007f9b79cef682 in PyObject_Call () at /usr/lib/libpython2.7.so.1.0
#14 0x00007f9b79cff05a in instancemethod_call () at /usr/lib/libpython2.7.so.1.0
#15 0x00007f9b79cef682 in PyObject_Call () at /usr/lib/libpython2.7.so.1.0
#16 0x00007f9b79d4c806 in slot_tp_init () at /usr/lib/libpython2.7.so.1.0
#17 0x00007f9b79d4905d in type_call () at /usr/lib/libpython2.7.so.1.0
#18 0x00007f9b79cef682 in PyObject_Call () at /usr/lib/libpython2.7.so.1.0
#19 0x00007f9b79d8d503 in PyEval_EvalFrameEx () at /usr/lib/libpython2.7.so.1.0
#20 0x00007f9b79d918dc in PyEval_EvalCodeEx () at /usr/lib/libpython2.7.so.1.0
#21 0x00007f9b79d919e8 in PyEval_EvalCode () at /usr/lib/libpython2.7.so.1.0
#22 0x00007f9b79dabefe in run_mod () at /usr/lib/libpython2.7.so.1.0
#23 0x00007f9b79dad1c1 in PyRun_FileExFlags () at /usr/lib/libpython2.7.so.1.0
#24 0x00007f9b79dae4e4 in PyRun_SimpleFileExFlags () at /usr/lib/libpython2.7.so.1.0
#25 0x00007f9b79dc0ca0 in Py_Main () at /usr/lib/libpython2.7.so.1.0
#26 0x00007f9b796fb43a in __libc_start_main () at /usr/lib/libc.so.6
#27 0x0000560a7bbd17ea in _start ()

FFMPEG probe:
#0  0x00007f9b79a9389d in read () at /usr/lib/libpthread.so.0
#1  0x00007f9b697e9ac8 in read (__nbytes=<optimized out>, __buf=<optimized out>, __fd=<optimized out>) at /usr/include/bits/unistd.h:44
#2  0x00007f9b697e9ac8 in file_read (h=<optimized out>, buf=<optimized out>, size=<optimized out>) at libavformat/file.c:112
#3  0x00007f9b697ca705 in retry_transfer_wrapper (transfer_func=0x7f9b697e9ab0 <file_read>, size_min=1, size=161649, buf=0x560a7e1afd3f "", h=0x560a7dd2a600) at libavformat/avio.c:378
#4  0x00007f9b697ca705 in ffurl_read (h=0x560a7dd2a600, buf=0x560a7e1afd3f "", size=161649) at libavformat/avio.c:411
#5  0x00007f9b697cd07a in avio_read (s=s@entry=0x560a7e0dbf40, buf=0x560a7e1afd3f "", size=161649, size@entry=262144) at libavformat/aviobuf.c:625
#6  0x00007f9b697f2535 in av_probe_input_buffer2 (pb=0x560a7e0dbf40, fmt=0x560a7e14ba28, filename=filename@entry=0x560a7e09c6c4 "/dev/video0", logctx=logctx@entry=0x560a7e14ba20, offset=offset@entry=0, max_probe_size=1048576) at libavformat/format.c:314
#7  0x00007f9b698fe9b2 in init_input (options=0x7ffd5a574dc0, filename=0x560a7e09c6c4 "/dev/video0", s=0x560a7e14ba20) at libavformat/utils.c:421
#8  0x00007f9b698fe9b2 in avformat_open_input (ps=0x560a7e14b710, filename=0x560a7e09c6c4 "/dev/video0", fmt=<optimized out>, options=0x560a7e14b9c8) at libavformat/utils.c:536
#9  0x00007f9b7106c469 in CvCapture_FFMPEG::open(char const*) () at /usr/lib/libopencv_videoio.so.3.2
#10 0x00007f9b7106c6df in cvCreateFileCapture_FFMPEG () at /usr/lib/libopencv_videoio.so.3.2
#11 0x00007f9b71070a13 in cvCreateFileCapture_FFMPEG_proxy(char const*) () at /usr/lib/libopencv_videoio.so.3.2
#12 0x00007f9b7104d45d in cvCreateFileCaptureWithPreference () at /usr/lib/libopencv_videoio.so.3.2
#13 0x00007f9b7104dd3c in cv::VideoCapture::open(cv::String const&, int) () at /usr/lib/libopencv_videoio.so.3.2
#14 0x00007f9b7104eaae in cv::VideoCapture::VideoCapture(cv::String const&) () at /usr/lib/libopencv_videoio.so.3.2
#15 0x00007f9b76436e32 in pyopencv_cv_VideoCapture_VideoCapture(_object*, _object*, _object*) () at /usr/lib/python2.7/site-packages/cv2.so
#16 0x00007f9b79d8dc60 in PyEval_EvalFrameEx () at /usr/lib/libpython2.7.so.1.0
#17 0x00007f9b79d918dc in PyEval_EvalCodeEx () at /usr/lib/libpython2.7.so.1.0
#18 0x00007f9b79d161bb in function_call () at /usr/lib/libpython2.7.so.1.0
#19 0x00007f9b79cef682 in PyObject_Call () at /usr/lib/libpython2.7.so.1.0
#20 0x00007f9b79cff05a in instancemethod_call () at /usr/lib/libpython2.7.so.1.0
#21 0x00007f9b79cef682 in PyObject_Call () at /usr/lib/libpython2.7.so.1.0
#22 0x00007f9b79d4c806 in slot_tp_init () at /usr/lib/libpython2.7.so.1.0
#23 0x00007f9b79d4905d in type_call () at /usr/lib/libpython2.7.so.1.0
#24 0x00007f9b79cef682 in PyObject_Call () at /usr/lib/libpython2.7.so.1.0
#25 0x00007f9b79d8d503 in PyEval_EvalFrameEx () at /usr/lib/libpython2.7.so.1.0
#26 0x00007f9b79d918dc in PyEval_EvalCodeEx () at /usr/lib/libpython2.7.so.1.0
#27 0x00007f9b79d919e8 in PyEval_EvalCode () at /usr/lib/libpython2.7.so.1.0
#28 0x00007f9b79dabefe in run_mod () at /usr/lib/libpython2.7.so.1.0
#29 0x00007f9b79dad1c1 in PyRun_FileExFlags () at /usr/lib/libpython2.7.so.1.0
#30 0x00007f9b79dae4e4 in PyRun_SimpleFileExFlags () at /usr/lib/libpython2.7.so.1.0
#31 0x00007f9b79dc0ca0 in Py_Main () at /usr/lib/libpython2.7.so.1.0
#32 0x00007f9b796fb43a in __libc_start_main () at /usr/lib/libc.so.6
#33 0x0000560a7bbd17ea in _start ()

Justin implemented an experimental replacement for the OpenCV video capture object. Brief testing shows that the new approach is able to open the Logitech camera much quicker. We briefly attempted to use it while performing alignment but ran into trouble due to excessive latency of returned video frames; see #32.

#32 has been resolved and the v4l2_capture branch has been merged into master. Closing.


Update of healthcare-api-adapter to support more than 1000 projects

https://github.com/quantumsoftgroup/healthcare-api-adapter/issues/2

Thanks, @pavertomato!


Nuget Package Creation - v3.1.7

Bumped Selenium version '4.5.1' -> '4.6.0'.
Nuget package creation - v3.1.7.

Codecov Report
Base: 100.00% // Head: 100.00% // No change to project coverage :thumbsup:

Coverage data is based on head (7aa9ecf) compared to base (12bb9ce).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff            @@
##              main       #45   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files            1         1
  Lines           84        84
  Branches         6         6
=========================================
  Hits            84        84

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Riigikogu service

AS A Service manager
I WANT TO have Riigikogu service available in Bürokratt
SO THAT I can get information about Riigikogu
Acceptance Criteria

[ ] #82

/api/statistics/participations/member/{uuid}

[x] #83
[x] #84

Information about API: https://api.riigikogu.ee/swagger-ui.html#/

https://github.com/buerokratt/Common-Services/issues/83

https://github.com/buerokratt/Common-Services/issues/82

Blocked.
Needs an AC for Rasa intent detection.

https://github.com/buerokratt/Common-Services/issues/84

https://github.com/buerokratt/Common-Services/pull/133/

Reopen, as NLU needs training

PR: https://github.com/buerokratt/Training-Module/pull/673

PR: https://github.com/buerokratt/Training-Module/pull/682

Service is working as intended.
The last vote: "Mis oli riigikogu viimane hääletus?"
The last five votes: "Mis on viimased hääletused parlamendis?"
Member attendance: "Parlamendi liikme kohalolu Mart Helme"


Do not show crowding if none of the Upcoming Departures for buses has that info

Summary of changes
Asana Ticket: 👩👩👧👦 Crowding | Hide crowding column if no vehicles have crowding data
The column containing the crowding information will not be shown if there's not at least one vehicle with those values:
With crowding:

Without crowding:

👍 lgtm!


3.12 wheels

Looks like wheels are built for each supported Python version individually.
Assuming it there are no other blockers to release a wheel for Python 3.12, could we have wheels generated for this version as well?
I'll try to find some time to look into it, in case it's something I can contribute via PR.

PR submitted:

https://github.com/pyocd/libusb-package/pull/17

Any traction on this?  It would be nice to have 3.12 support in libusb_package.

It would be really nice to get 3.12 support before 3.13 is released...


sync testing scripts for main and forks

Currently there are two GitHub Actions files in .github/workflows - one for forks and one for main. This is because:

main uses a custom registry secret from the workflow context named secrets.CR_TOKEN; forks use github.token cause they can't access the custom secret for security reasons
main pushes to the github.com/podtato-head/.... base path; forks push to github.com/<username>/podtato-head/... cause that's the only option

I think a good solution would be to test main just like forks - by using github.com/cncf/podtato-head/... as the base path and github.token as the secret. An admin of this repo would be best positioned to research and develop this.

This was addressed in #129.


add schema to the default location root

resolves #239
Description
Adds schema to the default location root
Checklist

[x] I have signed the CLA
[x] I have run this code in development and it appears to resolve the stated issue
[x] This PR includes tests, or tests are not required/relevant for this PR
[x] I have updated the CHANGELOG.md and added information about my change to the "dbt-spark next" section.

@dan1elt0m LGTM! Could you add the PR to the change log entry too? There are more entries having both the issue and the PR.
@jtcohen6 : We should communicate well about this fix. It may cause confusing: new tables created with this fix have the location which includes the schema, while existing tables have the location without the schema. If users do not like this change they keep the old behavior by adding the following macro to their project:
{% macro spark__location_clause() %}
  {%- set location_root = config.get('location_root', validator=validation.any[basestring]) -%}
  {%- set identifier = model['alias'] -%}
  {%- if location_root is not none %}
    location '{{ location_root }}/{{ identifier }}'
  {%- endif %}
{%- endmacro -%}

Still, I think it's a great change! It's even more confusing when multiple people work on the same dbt project expecting to create separate tables in their user schema, but actually the tables in different schema point to the same file location, causing unexpected, weird issues.

Could you add the PR to the change log entry too?

Done

@dan1elt0m Thanks for the PR!
@JCZuurmond I was just going to ask the same question. This is technically a breaking change, but it's really how this should have worked all along.
I'd like to include this change in v1.2 and include a clear upgrade notice to exactly this effect. Anyone who wants to preserve the old behavior has a clear mechanism for doing so.

@jtcohen6 : What is the plan for this PR?

@JCZuurmond Let's do it ✅ it's a good change, and a sensible default.
We're in the process of migrating our adapter repos to use the same changelog system (changie) that dbt-core has been using for several months. Once that's ready, let's update the changelog here to call this out as a (potentially) breaking change, for folks who've built an expectation around the old default S3 paths.

@dan1elt0m @JCZuurmond so sorry for the late update, if either of you are still free to work on this the changie swap over has been implemented some instructions can be found in the contributing guide here: https://github.com/dbt-labs/dbt-spark/blob/main/CONTRIBUTING.md#adding-changelog-entry. if you have any other questions or are not able to carry on working on this atm please let me know and we might be able to get it on our end.

@dan1elt0m Could you do the changie thing?

@McKnight-42 @JCZuurmond: I added the changie log

@McKnight-42 : Wat is the plan with this PR?

@McKnight-42 : What is the plan with this PR? I see you opened it again

@Fleid or @colin-rogers-dbt : What will we do with this PR? I still think it is an important change, but also tricky due to the change in location