Refactoring

What
This is an umbrella issue for various ideas of refactoring.
The more important items come first.

Split the MySQLCluster controller into two (or three) for better scalability.
MOCO should be able to handle over 1,000 MySQL clusters with a single controller.
The current implementation of Reconcile executes a bunch of queries to configure clustering
in addition to creating and updating Kubernetes resources, which does not scale.
So, the logic needs to be separated into two or three, namely:

Reconciliation of Kubernetes resources
Managing MySQL cluster
Managing Backup

Test the reconciler appropriately
The current test does not test Reconcile() appropriately because it does not
cover reconciliation process other than changes in MySQLCluster resources.
For example, it does not test the case when the StatefulSet is deleted.

Make Clone gRPC API synchronous
Currently, moco-agent's Clone API is asynchronous to allow the reconcile not to wait
the completion.  After we split the reconciliation processes into three, the API can be
synchronous.  Synchronous API is easier to handle.

Make the CLONE API of moco-agent simpler
The current API distinguishes two cases, namely, cloning from an external cluster and
cloning from a member of the same cluster.  We can implement the latter just as the
same as the former so that the API can be simpler.

Metrics implementation
The current metrics implementation in moco-agent is racy.
Let's make it to use global variables to eliminate potential races.
Also, let's use go-grpc-prometheus.

Authentication and security
MOCO uses a lot of plain-text passwords.  They should be protected with TLS.
Also, moco-agent should authenticate the controller with something like X509 client certificates.

Remove utils.go
Most of the functions in this file should become methods of MySQLCluster type.

MySQLCluster CRD
The default value of LogRotationSchedule can be empty.
We should treat the empty value as rotating logs every 5 minutes.

How
Describe how to address the issue.
Checklist

[ ] Finish implementation of the issue
[ ] Test all functions
[ ] Have enough logs to trace activities
[ ] Notify developers of necessary actions

#228 implements almost all the items except for TLS authentication.
They are divided into #21 and #234.


Fix naming function getPayment -> getPaymentInfo

As it seems to us, this is an obvious mistake in the overall stylization of naming. In addition, in the documentation (https://github.com/lodosstm/yandex-checkout-node/blob/master/README.ru.md) the function is called exactly getPaymentInfo.

fixed documentation in README files
right method is getPayment


View menu text scrub (resolves #820)

Resolves #820

Removed declaration of ShowExplorer  (ShowAppSettings is used by the LogEntry Component)
ditched the generated qna change

Pull Request Test Coverage Report for Build 1165

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.001%) to 53.45%

Totals

Change from base Build 1159:
0.001%

Covered Lines:
4222

Relevant Lines:
7123

💛  - Coveralls


WINDOW_BUFFER_SIZE_EVENT generated during window scrolling

Windows Version 10.0.17763.1

SetConsoleWindowInfo can be used to scroll the contents of the console screen buffer by shifting the position of the window rectangle without changing its size.

Starting from Windows 10 1709 (FCU) such scrolling generates a WINDOW_BUFFER_SIZE_EVENT even though the console buffer size remains unchanged.
This breaks our application behaviour and does not make sense for the following reasons:

The documentation explicitly says that WINDOW_BUFFER_SIZE_RECORD "describes a change in the size of the console screen buffer", but there's no change in this case.
The event is generated only if the contents of the console screen buffer is scrolled via SetConsoleWindowInfo API, but it's useless - the application already knows that the console is being scrolled because the scrolling is initiated by the application itself.
event is not generated when the user moves the scrollbar manually, so the application does not know that the console it being scrolled in that case.
It does not happen in Legacy mode and never happened before for 20+ years.

A minimal project to reproduce the issue attached.
BufferSizeEventBug.zip

Thank you for the report. I've copied this into my internal bug queue as MSFT: 19275577.

Another (possibly related) observation: v2 console sends WINDOW_BUFFER_SIZE_EVENT even if ENABLE_WINDOW_INPUT flag is not set:

ENABLE_WINDOW_INPUT 0x0008 | User interactions that change the size of the console screen buffer are reported in the console's input buffer.

It looks like this was an intentional change to fix https://github.com/Maximus5/ConEmu/issues/1123.
We don't really have any other notification mechanism for the viewport or buffer changing, so it looks like we're triggering that event whenever the view changes even when the buffer size does not to try to keep things in sync.
It looks like at the time we thought that applications receiving an additional message with no actual change wouldn't really be harmed by that information as whatever they were doing would probably be able to detect nothing really happened with GetConsoleScreenBufferInfoEx before performing a further action after the event.
In theory, we could revert the change and come up with a new message type or notification type for the viewport change behavior and then change other downstream components that are now relying on it for synchrony, but I'm a bit hesitant to do that because this is the first report I've seen of it causing issues after being in the wild for over a year. I'm also afraid changing it to fix your issue will then cause me to have to completely revisit the ConEmu one and potentially cause other bugs as a result.
Is it an extremely onerous change in your software to realize that nothing has actually changed when this message comes through with the same buffer size as before? If so, can you further describe your scenario and estimated usage market? It would be useful to weigh your report versus the installed market of ConEmu and WSL users to see whether it's worth the risk of changing this further at this time or if I need to defer a more complete solution to a future milestone.

Thanks for looking into this.
Indeed, there was no way for applications to receive notifications about window changing. And now there is one (sort of).
Sadly this looks like a quick hack rather than a long-term solution - the only information provided is basically "something's happened, go figure it out yourself":

Has the buffer size changed? You can't say for sure any more without storing the previous size somewhere
Has the window size/position changed? Maybe, but you need to call another API to find it out and yes, also compare with the previous value, stored somewhere.

Also, what about this (see above):

The event is generated only if the contents of the console screen buffer is scrolled via SetConsoleWindowInfo API ...
event is not generated when the user moves the scrollbar manually ...

- Shouldn't the event be generated in both cases if you're triggering that event "whenever the view changes"?
Our scenario:

On WINDOW_BUFFER_SIZE_EVENT the app recalculates it's interface, redraws everything and resets the viewport position
The app provides several hotkeys to scroll the viewport using SetConsoleWindowInfo (very similar to the example in the first post)
The user presses the hotkey to, say, scroll up, the app receives WINDOW_BUFFER_SIZE_EVENT and... see point 1. The viewport flickers and remains in the same position, the user is unhappy and files a bug report.

Detecting that nothing has actually changed is not extremely onerous, and that's what I already did a month ago (a commit reference is just above your comment), so it's not a blocker for us at least.
I can't say anything about other apps in the wild which might be also affected (or not) of course.
I'd say reverting this and introducing a new notification type for the window changes is a Good Thing To Do in general:

it won't break any code that existed before this change
this change is not documented, so, technically, any code that relies on it since last year relies on undocumented behaviour and should stop doing that anyway
any new code that needs to monitor window changes can be more straightforward and more efficient with the new notification type.

Obviously, the final decision is yours. But, in any case:

the inconsistency with the manual scrolling (see above) should probably be fixed?
the absence of ENABLE_WINDOW_INPUT console mode (see above) should probably be respected?
any changes should probably be reflected in the documentation?

You're right, the event should probably be generated in both of those cases if it should be generated in either one.
You're also right that the documentation should probably be reflecting what happens.
And you're right that we would have to look into the ENABLE_WINDOW_INPUT console mode.
You're also right that the solution of sending this event in hindsight is a dirtier quick hack than we thought it was at the time.
So I think what I'm going to do is promote the work item type here from a simple bug into a deliverable. It's obvious to me by how many nuances there are to this particular scenario that it needs a more concerted effort to resolve this than a simple bug fix. I do think The Right Thing To Do is for it to have its own event notification and try to resolve the ConEmu/WSL thing through that mechanism instead.
It looks like you are unblocked for now through your own workaround (sorry, I didn't see the link attached at first). That takes a bit of the pressure off and means that taking longer to craft the right solution (Deliverable style) is easier to justify than making another hack on top of this hack (Bug style).

Deliverable ID: 19275577 - Craft comprehensive solution to buffer/window overload on Input event
Task ID: 19686586 - Ensure that docs.microsoft.com reflects actual behavior of buffer/window overloads
Task ID: 19686595 - Create new/different eventing mechanism for window sizing concerns that isn't overloaded with buffer sizing
Task ID: 1968663 - Ensure that events for window buffer sizing and viewport sizing respect ENABLE_WINDOW_INPUT flag
Task ID: 19686624 - Fix WSL listener to receive new event type
Task ID: 19686633 - Verify ConEmu hosting WSL is proper after adjustments (see Maximus5/ConEmu#1123)
Task ID: 19686646 - Check consistency on event generation between SetConsoleWindowInfo API and manual scrollbar adjustment

@miniksa I noticed (unless I'm doing something wrong) that  ENABLE_VIRTUAL_TERMINAL_INPUT and ENABLE_WINDOWS_INPUT seem to be mutually exclusive.  Is this a bug you're tracking?

@oising The answer to that depends on how you're reading the console. I think that ENABLE_VIRTUAL_TERMINAL_INPUT | ENABLE_WINDOW_INPUT requires you to ReadConsoleInput. You'll get different types of INPUT_RECORD: key events containing the VT data, and window events containing the window data. You'll also be able to learn about focus events, mouse events and menu events.

Do you have a minimal repro sample code I could debug? What @DHowett-MSFT describes is how WSL does it, so I'm 99% sure that should be working for you.

@zadjii-msft I think the problem is that I had never really taken a good look at WINDOW_BUFFER_SIZE_EVENT before. I was expecting it to be emitted any time the console window was resized. It's only emitted when the console window is sized beyond the current buffer. It's never emitted when the window size is reduced (as the buffer won't shrink to match.) What I really wanted is a way to reliably monitor the viewport not the buffer.

So for the record, sometime between RS2 and RS5, we changed the behavior of the console with respect to WINDOW_BUFFER_SIZE_EVENTs. We made the console send the events anytime the viewport size changed, not only the buffer size. However, we didn't change the actual values of the message, it still had the buffer size as the payload, not the viewport size. A client app can now use that message as a notification that the window might have changed size, and they could query the actual window size using GetConsoleScreenBufferInfo.
We haven't added more messages yet, nor have we changed the content of any messages, only increased the frequency of the messages.
I believe there were earlier builds where this change was scoped only to apps using VT input, but IIRC we changed it later to just send the events for all viewport changes regardless. This was probably a year ago, so I'm definitely hazy on the specifics.

Thanks @zadjii-msft for the update. I'd still rather see a new event WINDOWS_VIEWPORT_SIZE_EVENT introduced rather than overload the buffer one, but I understand to ship is to choose. This will unblock a lot of people, but it would be nice to formalize it before it becomes a backcompat issue.

I just mentioned it on issue #305 but I realised the best way to trigger the SIGWINCH manually is to catch an event like WM_ERASEBKGND from the console window and poll the sizes there, here's a snippet from my code (which I also posted on issue #305):
pawttyxy _pawsig_ttysize = {0};
pawld _pawsig_catch_PAWSIG_TTYSIZE( pawsig *sig, UINT msg, WPARAM wp, LPARAM lp )
{
	pawttyxy xy = {0};
	CONSOLE_SCREEN_BUFFER_INFO csbi = {{0}};
	if ( msg == WM_ERASEBKGND )
		return 0;
	GetConsoleScreenBufferInfo(GetStdHandle(STD_OUTPUT_HANDLE), &csbi);
	xy.x = csbi.dwSize.X;
	xy.y = csbi.dwSize.Y;
	/* Only trigger the event if at least one of limits have changed */
	if ( xy.x && _pawsig_ttysize.x && xy.y == _pawsig_ttysize.y )
		return 0;
	sig->signal = PAWSIG_TTYSIZE;
	sig->extinf.size = xy;
	return 1;
}

I'm looping through the few events that I catch of the window so ignore the return statements and the library specific stuff like pawsig (making an all round solution that should run on all systems with the same binaries - excluding libpaw at mininum).

window buffer size.. to me, is a mixture of names by previous naming artist, SCROLL_EVENT sounds better oriented.
scroll event happens only with the terminal that has a scrollback buffer, which is defined by 4 parameters - columns, rows, left-offset, top-offset
any change of above parameter made by the user or by sending certain ESC sequences cause the scroll event. the scroll is not related to SIGWINCH that nix terminals have
size event or window size event or screen size event is completely separate, it may occur with the scroll or may not.

@awsdert those msg == WM_ERASEBKGND would NOT execute down below, seem like a CPU=100% loop, im not in window manipulation for now, better described the subscription mechanism. a polling could be implemented without this window magic

@awsdert those msg == WM_ERASEBKGND would NOT execute down below, seem like a CPU=100% loop.. im not in a window manipulation for now, better shall have described the subscription mechanism. a polling could be implemented without this window magic

Oh darn, being a linux user I would never have found out until some time after releasing the library & launcher pair I'm working on. I'm making it because I'm tired of all the ABI and executable/library type issues caused by data models and os specific APIs. Far too many variants so I'm working on the pair to just link static libs against native objects that deal with the main vs WinMain vs wMainMain vs DllMain vs etc to produce what the OS expects (*.exe vs *.AppImage vs *.so vs etc). via makefiles and a few variables handed to them for the downstream software to just pair with their static libraries to produce whatever the intended result is. For example:
build:
	$(CC) -o $(LIBPFX)foo$(LIBEXT) foo.a $(OSLIBS:%=-l %) ...

My project is on gitlab under the same username, paw repo, if anyone is interested in occasionally taking a look (I'm a lazy dev so will take a while).

Oh darn, being a linux user I would never have found out until some time after releasing the library & launcher pair I'm working on. I'm making it because I'm tired of all the ABI and executable/library type issues caused by data models and os specific APIs.

"be water my friend" (bruce lee), be a terminal user i would say, is a good tendency to strive to some sort of compatibility with other systems or with the past or to uniformity. im a conio.php user of the terminal, php isnt bound to binaries so there could be a common glue-library, like ncurses but for every OS my take

Far too many variants so I'm working on the pair to just link static libs against native objects that deal with the main vs WinMain vs wMainMain vs DllMain vs etc to produce what the OS expects (*.exe vs *.AppImage vs *.so vs etc). via makefiles and a few variables handed to them for the downstream software to just pair with their static libraries to produce whatever the intended result is. For example:
build:
	$(CC) -o $(LIBPFX)foo$(LIBEXT) foo.a $(OSLIBS:%=-l %) ...

cant say i understand any of this binary compatibility related stuff :]

My project is on gitlab under the same username, paw repo, if anyone is interested in occasionally taking a look (I'm a lazy dev so will take a while).

i dont believe the legend about evil corps, ms in particular 's kind of slow moving blob to me (where's cmd.exe user for example, they cant even force him to work, it doesnt feel like evil), sometimes it moves in the right direction (which i think is right, maybe its wrong), sometimes wrong, lone dev fellas are like parasites on its body, so not trying to jump around "brand new replacements" like gitlab or something

Did I say anything about "evil corps"? I don't think I did, I chose to move to gitlab for convenience, not because I think m$ is inherently evil. Though pretty much everyone on the planet (including myself) is (at the very least) vile when compared to God.
Github was certainly convenient but ever since the mandatory ssh key usage when uploading it became inconvenient for my small projects. I'm the only one besides God who knows my passwords, they're pretty damn secure with high entropy, they're kept in a KeePassXC database with at maximum encryption likewise high entropy password.
If I deem it safe to use my passwords instead of ssh keys then that should be my choice, not github's. For multi-dev projects, sure ssh keys should be mandatory but not single dev projects. Instead the ssh keys made it less secure just because I had to keep a copy of the unencrypted keys on my drive where any hacker that happens to break through my security can just copy it from.
As far as the binary compatibility stuff goes, you know about data models like LP32 vs ILP32 vs LP64 vs ILP64 vs LLP64 vs SILP64 right? Or how wchar_t on linux is 32bit while on windows it's 16bit right?
Those sort of inconsistencies are what my project aims to hide in the library, exposing only the fixed size integers, floats, etc that the compiler will map to the CPU's word/dword/qword for me via the _BitInt addition in C2X. I also mandate in the library that it must be a compiler like GCC or Clang that produces GNU ABI only.
This allows me to abuse the objects and static libraries that are produce by them along with makefiles to produce truly cross-platform software that relies on the launcher to hook it up to a native build of my library to handle the OS specific stuff in a consistent way.
I'm even making a custom protocol for handling common directories so that something like paw://~/ will always mean the home directory (so that $HOME vs %USERPROFILE% doesn't need to be detected).
The final goal is that users will not need to re-install many apps and libraries every time they find they need to re-install their os/distro or change to a different one. They just keep their home directory as is or redefine the OTG_DIR variable to whatever drive/directory is acting as a portable home directory.

Did I say anything about "evil corps"? I don't think I did, I chose to move to gitlab for convenience, not because I think m$ is inherently evil. Though pretty much everyone on the planet (including myself) is (at the very least) vile when compared to God.
Github was certainly convenient but ever since the mandatory ssh key usage when uploading it became inconvenient for my small projects. I'm the only one besides God who knows my passwords, they're pretty damn secure with high entropy, they're kept in a KeePassXC database with at maximum encryption likewise high entropy password.
If I deem it safe to use my passwords instead of ssh keys then that should be my choice, not github's. For multi-dev projects, sure ssh keys should be mandatory but not single dev projects. Instead the ssh keys made it less secure just because I had to keep a copy of the unencrypted keys on my drive where any hacker that happens to break through my security can just copy it from.

too much to worry about, not lazy. git has some masterpassword too, though i dont use git except for git clone something, to check others code. lazily pushing GithubDesktop button in the FTP manner.. those comments and stuff are for corporate workers, so managers can track their salaries around.

As far as the binary compatibility stuff goes, you know about data models like LP32 vs ILP32 vs LP64 vs ILP64 vs LLP64 vs SILP64 right? Or how wchar_t on linux is 32bit while on windows it's 16bit right?
Those sort of inconsistencies are what my project aims to hide in the library, exposing only the fixed size integers, floats, etc that the compiler will map to the CPU's word/dword/qword for me via the _BitInt addition in C2X. I also mandate in the library that it must be a compiler like GCC or Clang that produces GNU ABI only.
This allows me to abuse the objects and static libraries that are produce by them along with makefiles to produce truly cross-platform software that relies on the launcher to hook it up to a native build of my library to handle the OS specific stuff in a consistent way.
I'm even making a custom protocol for handling common directories so that something like paw://~/ will always mean the home directory (so that $HOME vs %USERPROFILE% doesn't need to be detected).
The final goal is that users will not need to re-install many apps and libraries every time they find they need to re-install their os/distro or change to a different one. They just keep their home directory as is or redefine the OTG_DIR variable to whatever drive/directory is acting as a portable home directory.

uniformity at the API level is what matters, sure cant use some platform dependent types or structs, call it ABI or BABABI concept's the same
relating to window magic you mentioned previously, i found out that it happens in FAR and also with another user, they probably send that WM_ erase background message to the window. can check it by slowly resizing the window frame, content redraws even before mouse btn been depressed.

uniformity at the API level is what matters

An ABI is that plus binary compatibility. And yes ABI matters, just take a look at all the workarounds the standard libraries (stdlib.h, stdint.h, etc) pull to keep their libraries working for native builds. What I'm doing just takes that a step further.

relating to window magic you mentioned previously, i found out that it happens in FAR and also with another user, they probably send that WM_ erase background message to the window. can check it by slowly resizing the window frame, content redraws even before mouse btn been depressed. one of the polling properties should be the focus, when it's on, then poll, no sense otherwise.

Good to know, will still test with wine primarily and via a copy of windows in qemu or similar once I'm satisfied.
I don't think there's anything left to extract from either of these topics for now so let's just leave end the convo here for now so the admin doesn't need to decide if any more of our comments are off topic or not.

i've re-read the topic and want to DISAGREE with the author's statement.
buffer (scroll) is defined by size and offset, so the change in the offset shall generate the scroll event.
the ENABLE_WINDOW_INPUT flag is pretty useless though, because the scroll event alone is not what terminal user wants, it is desired AFTER (less important than) the resize event, which is unreliable with this flag, because window resize by Y coordinate (columns) does not trigger WINDOW_BUFFER_SIZE_EVENT (ive answered here https://github.com/microsoft/terminal/discussions/14975) SIGWINCH is also unreliable for detecting the size of the window, so implementations in both worlds should use polling routine to detect size change (scroll is only a windows feature)
regarding to above window magic - it doesnt work (in the sense that window refreshes content and GetConsoleScreenBufferInfo reports new values), though on windows 6.1+ (ive tested the resize on windows 10 conhost) the window updates in the process of resizing, so no special magic is needed, it simply does not exists (here's demo of the problem https://github.com/Maximus5/ConEmu/discussions/2583)


closes #12 - Create copy constructors for LongArrayOutput and ByteBuf…

Provide a mechanism to get an exact copy of each BitOutput implementation.
If a user keeps a reference to the BitOutput implementation passed to a Compressor/GorillaCompressor, this will allow an exact copy to be made, finalized (as if Compressor.close() was called), and passed to a Decompressor/GorillaDecompressor without affecting the original Compressor/GorillaCompressor.
Useful in a production environment where we want to read the contents of the Compressor/GorillaCompressor but are not ready to close.

@billoley Did the previous comment solve your issue? Or is there still something you would wish to be changed? I might consider bookkeeping "helpers" for next release if you wish to have them from the library.

I believe the concept of a wrapper class is working for me.  It might be
useful to create helper classes that handle common use cases.

Compressor / Decompressor access from one place
Periodic closing of Compressors
Age off of compressors

Bill Oley
On Tue, Feb 13, 2018 at 1:27 AM, Michael Burman<EMAIL_ADDRESS>wrote:

@billoley https://github.com/billoley Did the previous comment solve
your issue? Or is there still something you would wish to be changed? I
might consider bookkeeping "helpers" for next release if you wish to have
them from the library.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/burmanm/gorilla-tsc/pull/13#issuecomment-365163724,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AFVhwzr852CXWwz2DaUEKVDH1Ic-3cfNks5tUStDgaJpZM4Ryn3j
.

I'm actually using the LongArrayOutput version of BitOutput.  The accessor for the backing array makes a copy before returning it, but it sizes the copy to length + 1.  When I use this array in a Decompressor and read the number of entries that I added, I get an  ArrayIndexOutOfBoundsException.  This does not happen if I close the compressor first.
Considering that the getLongArray() method is already copying the array (and this solution doesn't work without replicating a lot of the code to implement close()), I think that adding a copy constructor would be a good idea.

Can you create a test that causes that ArrayIndexOutOfBoundsException? If you added n-items and can't read n-items back, then there's a bug somewhere.

I pushed 2.1.0 version which allows to get the underlying array with getLongArray() and it won't do a copy anymore.

Note that the GorillaDecompressor works fine without closing in most
cases.  This particular case was caught by one of my regression tests.
package test.package;
import fi.iki.yak.ts.compression.gorilla.*;
import org.junit.Test;
import java.util.concurrent.TimeUnit;
public class TestGorillaDecompressor {
@Test
public void testReadWIthoutClose() {

    long start = System.currentTimeMillis();
    LongArrayOutput compressorOutput = new LongArrayOutput(480);
    GorillaCompressor compressor = new GorillaCompressor(start,

compressorOutput);
    long ONE_DAY = TimeUnit.DAYS.toMillis(1);
    long t = start;
    compressor.addValue(t, 1.0);
    compressor.addValue(t + ONE_DAY, 3.0);

    LongArrayInput decompressorInput = new

LongArrayInput(compressorOutput.getLongArray());
GorillaDecompressor decompressor = new
GorillaDecompressor(decompressorInput);
    for (int x = 1; x <= 2; x++) {
        Pair pair = decompressor.readPair();
        System.out.println(pair.getTimestamp() + " -- " +

pair.getDoubleValue());
}
}
}
Bill Oley
On Wed, Mar 14, 2018 at 4:51 AM, Michael Burman<EMAIL_ADDRESS>wrote:

I pushed 2.1.0 version which allows to get the underlying array with
getLongArray() and it won't do a copy anymore.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/burmanm/gorilla-tsc/pull/13#issuecomment-372946926,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AFVhw8nKDOXlKLieZXIcC2ghSb9LhnRPks5teNobgaJpZM4Ryn3j
.

Fixed in commit 32807f2f29b50a76ac67c1fbc5b5e1e1619b16ba


Improve the README

Add info about;

[ ] Renode
[ ] LiteX
[ ] How to use (#2)
[ ] What is supported
[ ] What will be supported soon
[ ] Demos

@mateusz-holenko

I tried this and was not able to get the sample to work. Apparently Vivado is required?
I found multiple arty.py in related repos, but not in this repo.
gojimmypi@ubuntu:~/workspace$ find . -type f -name arty.py
./litex/litex/boards/targets/arty.py
./litex/litex/boards/platforms/arty.py
./litex/litex-boards/litex_boards/targets/arty.py
./litex/litex-boards/litex_boards/platforms/arty.py
./litex-boards/litex_boards/targets/arty.py
./litex-boards/litex_boards/platforms/arty.py

The example usage mentions "build your LiteX platform" (a platform), but nothing seems to happen when calling the arty.py in a platforms directory. Calling one of the scripts in a targets directory gives an error message like this:
chmod -x bios.elf
 OBJCOPY  bios.bin
chmod -x bios.bin
python3 -m litex.soc.software.mkmscimg bios.bin --little
make: Leaving directory '/home/gojimmypi/workspace/litex/litex-boards/litex_boards/targets/soc_ethernetsoc_arty/software/bios'
build_top.sh: line 3: vivado: command not found
Traceback (most recent call last):
  File "arty.py", line 162, in <module>
    main()
  File "arty.py", line 158, in main
    builder.build(**vivado_build_argdict(args))
  File "/home/gojimmypi/workspace/litex/litex/soc/integration/builder.py", line 194, in build
    vns = self.soc.build(build_dir=self.gateware_dir, **kwargs)
  File "/home/gojimmypi/workspace/litex/litex/soc/integration/soc.py", line 897, in build
    return self.platform.build(self, *args, **kwargs)
  File "/home/gojimmypi/workspace/litex/litex/build/xilinx/platform.py", line 48, in build
    return self.toolchain.build(self, *args, **kwargs)
  File "/home/gojimmypi/workspace/litex/litex/build/xilinx/vivado.py", line 333, in build
    _run_script(script)
  File "/home/gojimmypi/workspace/litex/litex/build/xilinx/vivado.py", line 88, in _run_script
    raise OSError("Subprocess failed")
OSError: Subprocess failed


Explore new IA for the service manual

What
Explore IA thinking based upon several needs to improve what we have, including surfacing new IA guidance, improving wayfinding to several tranches of prototype kit guidance.
Why
We need to decide as a team, what we will create, and take into user testing with the IA team
Resources

IA placement prototype
Optimal Workshop card sort results
Card sort playback
Analysis Mural board
How does IA fit into the service manual? Mural

Done when

[ ] We've explored ideas to take forward and presented back to the team
[ ] We've decided on which route to develop

I'm taking myself off this ticket now and putting Henry on instead.
@henocookie, you might want to break this ticket down and close this one off.

@henocookie - I'm going to do the same, as @sarawilcox mentioned, feel free to close and redistribute this issue 👍


Bug report: VRM model not imported

Describe the bug
A clear and concise description of what the bug is.
To Reproduce
Steps to reproduce the behavior:
just import vrm file in blender.
File - import - vrm
Expected behavior
something lagged and only armature imported
Screenshots
Desktop (please complete the following information)

OS: Win11, Wind10
Blender [e.g. 2.93.5, 3.1.2, ...] : 3.4.1
Addon Version [e.g. 2.4.7, 2.3.8, ...] : 2.10.4

Additional context
Error message :
Python: Traceback (most recent call last):
File "(My Account)\AppData\Roaming\Blender Foundation\Blender\3.4\scripts\addons\VRM_Addon_for_Blender-release\importer\import_scene.py", line 106, in execute
return create_blend_model(
File "(My Account)\AppData\Roaming\Blender Foundation\Blender\3.4\scripts\addons\VRM_Addon_for_Blender-release\importer\import_scene.py", line 235, in create_blend_model
).import_vrm()
File "(My Account)\AppData\Roaming\Blender Foundation\Blender\3.4\scripts\addons\VRM_Addon_for_Blender-release\importer\legacy_vrm_importer.py", line 34, in import_vrm
self.make_material()
File "(My Account)\AppData\Roaming\Blender Foundation\Blender\3.4\scripts\addons\VRM_Addon_for_Blender-release\importer\abstract_base_vrm_importer.py", line 347, in make_material
self.reset_material(b_mat)
File "(My Account)\AppData\Roaming\Blender Foundation\Blender\3.4\scripts\addons\VRM_Addon_for_Blender-release\importer\abstract_base_vrm_importer.py", line 326, in reset_material
shader.clear_node_tree(material.node_tree)
File "(My Account)\AppData\Roaming\Blender Foundation\Blender\3.4\scripts\addons\VRM_Addon_for_Blender-release\common\shader.py", line 403, in clear_node_tree
while node_tree.links:
AttributeError: 'NoneType' object has no attribute 'links'

2.12.1 same

This may be a bug in the add-on. Alternatively, this error occurs when the VRM file you are trying to import is corrupt. Could you please send me ( https://twitter.com/saturday06 ) the VRM file to investigate?

Had the same issue, but changing the export settings when exporting the VRM from Unity fixed it (pose freeze, divide vertex buffer), trying different combinations made it work when bringing it to blender.

I could probably fix it with the latest version, but could not reproduce it at hand.


Python Dialog requirements

On Mac OS I was required to install the dialog utility for it to work. It could be useful to add it to the README:
brew install dialog

I was just trying to figure this out, thanks for the tip!

@sebastibe @obihann for some reason I never had to use it... I wonder where the requirement is coming from...

Ok, found it and added it to the README.
Thanks!


Adjust compression level of background (different color page edges)

Hi! My carousel template for your amazing tool requires single color background that has to be exactly the same on the page edges as well. However, either export, LinkedIn import or both compress it in a way that page edges are a bit different color. If it's something that can be changed, could you please forward me into the right direction? Thanks! Regards, Dan.

Hi @top-rated ! Yes, there is a compression setting. Can you share an example of the issue?

You can adjust by changing this line https://github.com/FranciscoMoretti/carousel-generator/blob/main/src/lib/hooks/use-component-printer.tsx#L169

Thanks again for your reply, Francisco!
So even if the current compression level is fine, I believe the issue might
be on LinkedIn side, because, I guess, it additionally compress PDFs,
right? Even if it’s a small one…
Kindly ask you to take a look at this example:
https://www.linkedin.com/posts/burykin_4-magic-pills-for-a-smb-owner-from-google-activity-7255151603618320386-xGcT?utm_source=share&utm_medium=member_ios
The idea behind my design is that such carousel background color is exactly
the same as color of LinkedIn layer under it, on mobile app (not in the
night mode). This layer goes at the top, bottom and in between of carousel
slides. So I’d wish it will be like a flow of this single color, w/o those
slightly visible sides borders. Apparently they are due to compression or
something else. This idea wasn’t my initially as I did saw an abs clear
from borders example before. Really regret I haven’t saved it though.
Thank you!
Best,
Dan
On Wed 30. 10. 2024 at 21:51, Francisco Moretti @.***>
wrote:

You can adjust by changing this line
https://github.com/FranciscoMoretti/carousel-generator/blob/main/src/lib/hooks/use-component-printer.tsx#L169
—
Reply to this email directly, view it on GitHub
https://github.com/FranciscoMoretti/carousel-generator/issues/11#issuecomment-2448352916,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AF526KCA7R7WE6YRCBPLZ63Z6FBGHAVCNFSM6AAAAABQRUCL76VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDINBYGM2TEOJRGY
.
You are receiving this because you were mentioned.Message ID:
@.***>

Hey @top-rated ! First, thanks for using this project in real life! Super exciting to see that.
I think I got the gist of what you are trying to achieve.
I checked the background of LinkedIn carousel element in light mode and it seems to be this value on my browser:

rgb(220, 230, 241)

Your carousel background seems to be:

rgb(237, 241, 252)

Can you try to set 220, 230, 241 as the background color?
Note: there is some shadow to it that changes with different swipe directions. That's not accounted.

small shadow on the left
large shadow on the right

I do imagine the pleasure and excitement of when your creation delivers a
system added value to someone. It does!)
Yes, I went this way initially, but if I change the background to the color
you say, this is what it sows me: rgba(217,229,241,255):
[image: Screenshot 2024-10-31 at 11.15.43.png]
So apparently after export/compression the color changes (and the edges are
different), attaching it.
Thx!
On Thu 31. 10. 2024 at 9:46, Francisco Moretti @.***>
wrote:

Hey @top-rated https://github.com/top-rated ! First, thanks for using
this project in real life! Super exciting to see that.
I think I got the gist of what you are trying to achieve.
I checked the background of LinkedIn carousel element in light mode and it
seems to be this value on my browser:

rgb(220, 230, 241)

image.png (view on web)
https://github.com/user-attachments/assets/05536c68-b022-4c06-960e-322a8baf646b
Your carousel background seems to be:

rgb(237, 241, 252)

Can you try to set 220, 230, 241 as the background color?
Note: there is some shadow to it that changes with different swipe
directions. That's not accounted.

small shadow on the left
large shadow on the right

image.png (view on web)
https://github.com/user-attachments/assets/707b190b-8607-4dad-a169-4569ab984c56
—
Reply to this email directly, view it on GitHub
https://github.com/FranciscoMoretti/carousel-generator/issues/11#issuecomment-2449334997,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AF526KEZZ7BGDUTPIMYXGALZ6HU5HAVCNFSM6AAAAABQRUCL76VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDINBZGMZTIOJZG4
.
You are receiving this because you were mentioned.Message ID:
@.***>

Seems your attachment didn't go through. I tried setting that background color and printing to PDF and the end result is decent.
After conversion it shows (220, 230, 241) -> (220, 230, 240) which should be almost unnoticeable.

LinkedIn changes it like this (on the preview) (220, 230, 240) -> (222, 229, 241)
Which is off, but not as much as your example post (237, 241, 252)

Not sure how to solve this problem. I suggest you try with different image formats in this line https://github.com/FranciscoMoretti/carousel-generator/blob/main/src/lib/hooks/use-component-printer.tsx#L169

Sorry for the delay... Trying to be on to of everything a once:

What do you mean by trying other formats? What are the options?
Can it be the issue of not using the last version of your tool? I mean
I've found and decided to keep the one that is on the video: has two
fields for AI input, short text and text area under it. If so, how is it
better to fix it then?

Super thank you!
On Thu, Oct 31, 2024 at 11:48 AM Francisco Moretti @.***>
wrote:

Seems your attachment didn't go through. I tried setting that background
color and printing to PDF and the end result is decent.
After conversion it shows (220, 230, 241) -> (220, 230, 240) which should
be almost unnoticeable.
image.png (view on web)
https://github.com/user-attachments/assets/cafb8fa7-0530-4d7b-aa05-e7af4b7e4b3f
LinkedIn changes it like this (on the preview) (220, 230, 240) -> (222,
229, 241)
Which is off, but not as much as your example post (237, 241, 252)
image.png (view on web)
https://github.com/user-attachments/assets/5228e2b8-a47d-4d79-acab-cf9d7bf0126f
Not sure how to solve this problem. I suggest you try with different image
formats in this line
https://github.com/FranciscoMoretti/carousel-generator/blob/main/src/lib/hooks/use-component-printer.tsx#L169
—
Reply to this email directly, view it on GitHub
https://github.com/FranciscoMoretti/carousel-generator/issues/11#issuecomment-2449558997,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AF526KEQJUJAXYIYEXO4X7DZ6IDGHAVCNFSM6AAAAABQRUCL76VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDINBZGU2TQOJZG4
.
You are receiving this because you were mentioned.Message ID:
@.***>

Thank you!
PR?
So in new version I can add an article, but only a topic, correct?
On Mon 4. 11. 2024 at 12:18, Francisco Moretti @.***>
wrote:

Thanks for the additional info:

Change this line
https://github.com/FranciscoMoretti/carousel-generator/blob/main/src/lib/hooks/use-component-printer.tsx#L169
by using options from toDataURL
https://developer.mozilla.org/en-US/docs/Web/API/HTMLCanvasElement/toDataURL
2.
Yes, that could be the cause. Unfortunately, I can only maintain the
current version. Please feel free to look into this and create a PR though.
—
Reply to this email directly, view it on GitHub
https://github.com/FranciscoMoretti/carousel-generator/issues/11#issuecomment-2454447456,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AF526KHEOXXR6HUOECDQTILZ65J2FAVCNFSM6AAAAABQRUCL76VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDINJUGQ2DONBVGY
.
You are receiving this because you were mentioned.Message ID:
@.***>


Add flags and implement PathParams to str

@jimmycuadra I'll try to implement the server component in new PR.
This ready to review.

I'm not sure I understand the motivation for the to_string function. The result seems to be the same as the previous request_path implementation, but the implementation is much more complicated.
The flags idea seems good, although we could also just have two methods like requires_authentication and rate_limited that return booleans.
Was the Send + Sync constraint on Endpoint needed to satisfy Iron somehow?

I implemented to_string to prevent doing two times in router_path and request_path.
I like the idea of vectors, because you don't have to change all api's. If matrix add a new flag.
Send + Sync was for Iron. I will remove this for now.

I implemented to_string to prevent doing two times in router_path and request_path.
I like the idea of vectors, because you don't have to change all api's. If matrix add a new flag.
Send + Sync was for Iron. I will remove this for now.

There would still be a breaking change for new flags because a new variant would be added to the enum. At the site of use, being able to call a function with a boolean result would be more expressive than checking for the presence of a particular value in a vector, too.

Regarding the flags, wouldn't it be a typical use-case for bitflags?

@jimmycuadra I like the idea of @vberger. What do you think?

What's the advantage of bitflags if you're not interoperating with C code?

Mostly: It's more space efficient and you can easily check for multiple flags at once (might be relevant if in the future more flags are added, and you need to check for the combination of 3 or 4 flags ?).
On a much more subjective argument, imo it feels like the right way to represent this information (I don't expect to convince you this that ^^ but that's why I suggested it).

Gotcha. I still think separate predicate functions for each one is the best choice. There happen to be two "flags" now, but I don't think we can assume that this is future-compatible when we have absolutely no idea how the spec might change in the future. Differences in space efficiency are trivial for such a small thing, so I don't think that is really a consideration in determining an interface for this information.
We have to go by the information we have now:
Some endpoints require authentication. Some endpoints are rate limited. These two things have nothing to do with each other. They both happen to be representable by booleans that answer the question "does this endpoint have this property"?
Based on that, I don't think it makes sense to group the two properties together in any way.

I see your point, sounds totally reasonable indeed.

I changed the api by adding two default functions with value false.
@jimmycuadra This should be complete for now.

Sorry—a few more thoughts:

What is the motivation for PathParams and QueryParams being Deserialize + Serialize? For converting PathParams to a string path (ruma-client), we have the request_path method. For converting a router path to PathParams (ruma), we have our various XParam middleware. We might come up with something easier than that later. For QueryParams, on the client side, I don't see serialization as being particularly useful. More likely we'd want some sort of functionality in ruma-client for adding the fields of the struct to the query string of component of a Url. And again, on the server side, we have middleware.
I think the return type of name and description can be &'static str. Can we get away with that or can anyone think of a reason it needs to be String? And further: can we get away with removing the description method entirely? Are docstrings on the implementing type sufficient? Or is there a case where the description needs to be accessed programmatically?
I'd rather err on the side of caution and not provide default implementations for requires_authentication and rate_limited. Default implementations seem more appropriate for getting rid of boilerplate or obvious logic, but in this case I think we want to make sure that each implementation of Endpoint explicitly declares its intent.

I add description to support auto generated swagger, but not anytime soon possibly.
The spec only define with one them is true. Removing the default implementation is no problem for me.
Removing Serialize from PathParams, no problem.
Adding Deserialize to PathParams and QueryParams reduces boilerplate work. We don't have to add multiple middlewares.
For QueryParams, we don't have a great middleware. With Deserialize, it would be easy to build one. rust-urlsupport deserialize of query params, with serde_urlencoded.

Good idea on the description for Swagger. We'll keep it.
Let's go ahead and remove the default implementations of the methods.
I guess I'm not seeing how PathParams and QueryParams could be easily deserialized on the server side just by having them implement Deserialize. rust-url only implements the Serde traits for Url. It seems only intended for converting between strings and the Url type.

You need also serde_urlencoded.

Ah, I thought you were saying serde_urlencoded was a Cargo feature of rust-url.

Sorry, My vault. My english isn't so good.


Feature Request - Mod Menu Support

Add the mod menu button for Forge users (which Forge adds by itself) and Fabric/Quilt users (which is done through Mod Menu, a mod for Fabric) to the Legacy Title Screen (and in Fabric's case, pause screen too).
It can probably fit in Help & Options or just have its own dedicated button on both screens.

(this would be an enhancement, can't assign that label.. oops)

It's a planned addition, not as a mod menu support, but rather I want to make it in the Legacy Edition style


Adding unah.hn domain

Adding the Universidad Nacional Autonoma de Honduras to the list of domains.

Oficial website URL: https://www.unah.edu.hn/
A URL of a page on the official website where a long-term (>1 year) IT related course:
https://www.unah.edu.hn/oferta-academica
https://www.unah.edu.hn/assets/UNAH/plan-de-estudios/Ingenieria-en-sistemas-2024.pdf
A URL of a page or some other proof (.pdf or a screenshot are OK): I'm unsure where to find this one, but I'll attach Images that might be useful.

Thanks for reviewing my pull request!

@Jorge-Chinchilla I am sorry, the domain unah.hn is removed from our trusted domains list because it was abused in the past. If you are the student of this school, please enroll to GitHub Student Developer Program. Then apply for JetBrains educational subscription with your GitHub account (GitHub tab at https://www.jetbrains.com/shop/eform/students).


HDFS-17007.  TestPendingReconstruction.testProcessPendingReconstructions verify HDFS-11960 test case is wrong

Description of PR
TestPendingReconstruction.testProcessPendingReconstructions() verify HDFS-11960 is wrong.
(1) It does not  stop PendingReconstructionMonitor. The blockid will into timeouts queue because of timout duration is 3s.
(2) Test blockid should be blk_1_1 with different genstamp.
(3) The blk_1_1 should test with the same DatanodeDescriptor
How was this patch tested?
It is a tested case bug.

  GenericTestUtils.waitFor(() -> pendingReconstruction.size() == 0, 500,
      10000);
  // The pending queue should be empty.
  assertEquals("Size of pendingReconstructions ", 0,
      pendingReconstruction.size());
} finally {
  if (cluster != null) {
    cluster.shutdown();
  }
}

GenericTestUtils.waitFor() will  sleep maximum 10s.  The pendingReconstruction  will timeout after 3s ，then will be into timeout list.
PendingReconstructionMonitor will not be stoped if I change  GenericTestUtils.waitFor to 1s .

HDFS-15086 changed storedBlock to blockInfo without any specific reason.

(1) It does not stop PendingReconstructionMonitor. The blockid will into timeouts queue because of timout duration is 3s.

I don't catch this, can you elaborate, what will fail? Does putting a sleep of more than 3 seconds anywhere in the test lead to failures if this isn't there, if yes, can you tell me where to put that, so that I can try locally

GenericTestUtils.waitFor(() -> pendingReconstruction.size() == 0, 500,
10000);
// The pending queue should be empty.
assertEquals("Size of pendingReconstructions ", 0,
pendingReconstruction.size());
} finally {
if (cluster != null) {
cluster.shutdown();
}
}
GenericTestUtils.waitFor() will  sleep maximum 10s.  The pendingReconstruction  will timeout after 3s ，then will be into timeout list.
PendingReconstructionMonitor will not be stoped if I change  GenericTestUtils.waitFor to 1s .

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 47s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  1s

codespell was not available.

+0 :ok:
detsecrets
0m  1s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
36m 17s

trunk passed

+1 :green_heart:
compile
1m 18s

trunk passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
compile
1m  8s

trunk passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

+1 :green_heart:
checkstyle
1m  7s

trunk passed

+1 :green_heart:
mvnsite
1m 18s

trunk passed

+1 :green_heart:
javadoc
1m  9s

trunk passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javadoc
1m 32s

trunk passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

+1 :green_heart:
spotbugs
3m 28s

trunk passed

+1 :green_heart:
shadedclient
25m 35s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
1m  8s

the patch passed

+1 :green_heart:
compile
1m 12s

the patch passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javac
1m 12s

the patch passed

+1 :green_heart:
compile
1m  3s

the patch passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

+1 :green_heart:
javac
1m  3s

the patch passed

-1 :x:
blanks
0m  0s
/blanks-eol.txt
The patch has 1 line(s) that end in blanks. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply

+1 :green_heart:
checkstyle
0m 54s

the patch passed

+1 :green_heart:
mvnsite
1m 10s

the patch passed

+1 :green_heart:
javadoc
0m 53s

the patch passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javadoc
1m 27s

the patch passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

+1 :green_heart:
spotbugs
3m 17s

the patch passed

+1 :green_heart:
shadedclient
25m 37s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
226m  2s

hadoop-hdfs in the patch passed.

+1 :green_heart:
asflicense
0m 44s

The patch does not generate ASF License warnings.

335m 24s

Subsystem
Report/Notes

Docker
ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5642/2/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/5642

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux b11039115fec 4.15.0-206-generic #217-Ubuntu SMP Fri Feb 3 19:10:13 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 969c6b6098c8a24330e7db71a941e5f2eb471d36

Default Java
Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5642/2/testReport/

Max. process+thread count
2229 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5642/2/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 48s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  1s

codespell was not available.

+0 :ok:
detsecrets
0m  1s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
35m 38s

trunk passed

+1 :green_heart:
compile
1m 17s

trunk passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
compile
1m  9s

trunk passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

+1 :green_heart:
checkstyle
1m  5s

trunk passed

+1 :green_heart:
mvnsite
1m 18s

trunk passed

+1 :green_heart:
javadoc
1m  8s

trunk passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javadoc
1m 29s

trunk passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

+1 :green_heart:
spotbugs
3m 26s

trunk passed

+1 :green_heart:
shadedclient
25m 53s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
1m  7s

the patch passed

+1 :green_heart:
compile
1m 11s

the patch passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javac
1m 11s

the patch passed

+1 :green_heart:
compile
1m  4s

the patch passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

+1 :green_heart:
javac
1m  4s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
0m 54s

the patch passed

+1 :green_heart:
mvnsite
1m  9s

the patch passed

+1 :green_heart:
javadoc
0m 52s

the patch passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javadoc
1m 27s

the patch passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

+1 :green_heart:
spotbugs
3m 14s

the patch passed

+1 :green_heart:
shadedclient
26m  2s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

-1 :x:
unit
232m 35s
/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs in the patch passed.

+1 :green_heart:
asflicense
0m 42s

The patch does not generate ASF License warnings.

341m 46s

Reason
Tests

Failed junit tests
hadoop.hdfs.server.datanode.TestDirectoryScanner

hadoop.hdfs.server.namenode.ha.TestObserverNode

Subsystem
Report/Notes

Docker
ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5642/3/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/5642

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux fdf5f1e5488f 4.15.0-206-generic #217-Ubuntu SMP Fri Feb 3 19:10:13 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / fb140aa7e584ed1d54a2d28ec55ea4af12839bd4

Default Java
Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5642/3/testReport/

Max. process+thread count
2170 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5642/3/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.


LineChart Labels BUG

Labels in line chart is updating only if Series data is filled in inspector, when I using script AddData, line labels stayed without updating

If you call chart.AddData(), XCharts automatically refreshes the Label internally.
But if you call serie.addData(), you need to call the refresh interface chart.refreshLabel () yourself.

Yes it helped, thanks a lot!


Bonus feature: Subtitles in ggplot2

Seen on Twitter: http://rud.is/b/2016/03/12/ggplot2で字幕-subtitles-in-ggplot2/

Might be coming to ggplot directly :)
https://github.com/hadley/ggplot2/pull/1582

Nice!

#43
Maybe larger textInputs would be useful for long subtitles and captions

#45


Unable to build with Arduino-Source-0.40 or higher on Mac

Apple clang version 14.0.3 (clang-14<IP_ADDRESS>.1)
System: OSX 13.4.1c
Arduino Source version: Arduino-Source-0.40 or master (earlier versions work)
Issue Statement: When executing the cmake --build . -j 10 I'm receiving the following error and process ends:
"CroppedImageDictionaryMatcher.cpp:73:16: error: variable 'c' set but not used [-Werror,-Wunused-but-set-variable]
size_t c = 0;
^
[ 15%] Building CXX object CMakeFiles/SerialPrograms.dir/Source/CommonFramework/ImageTools/FloatPixel.cpp.o
[ 15%] Building CXX object CMakeFiles/SerialPrograms.dir/Source/CommonFramework/ImageTools/ImageBoxes.cpp.o
1 error generated.
gmake[2]: *** [CMakeFiles/SerialPrograms.dir/build.make:1845: CMakeFiles/SerialPrograms.dir/Source/CommonFramework/ImageMatch/CroppedImageDictionaryMatcher.cpp.o] Error 1
gmake[2]: *** Waiting for unfinished jobs....
gmake[1]: *** [CMakeFiles/Makefile2:112: CMakeFiles/SerialPrograms.dir/all] Error 2
gmake: *** [Makefile:91: all] Error 2"
Workaround I've used:
adding #pragma GCC diagnostic ignored "-Wunused-but-set-variable" to Common/Compiler.h
This made sure the process ends, but I'm not yet sure if it causing any troubles for the usage of the tool.

Instead of adding a whole pragma statement to Common/Compiler.h which could remove any other developer insights, we should just comment out or remove the unused variable or remove that part entirely.
Adding pragmas that disable entire diagnostics is not a recommended course of action because it could disable warnings and notes regarding optimizations that we might want to look for elsewhere. Putting that pragma in Compiler.h disables the warnings across the entire project. Yes, Mac's clang is annoying that it's enabled by default, but it's a good indicator for us when we can fix the program.
If you look at the CroppedImageDictionaryMatcher.cpp file, you'll notice that the variable c was used by something commented out. The compiler is basically tell you that it's safe to just comment those out. If you want to try commenting it out. So, try editing CroppedImageDictionaryMatcher.cpp on line 73 and comment out the line.
After you comment that out, you can submit a pull request if everything works.

I don't think the OP intended this to actually go in since they mentioned it as a workaround.
In any case, I've already deleted that unused line.


Intro text change & other thoughts

@bhall999's questions in PR #28...

Interesting. I haven't heard the terms Universal Site Columns and Universal Content Types ( wasn't sure what you meant at first), but they could make the conversation clearer. The problem is, Microsoft doesn't use these words, AFAIK.
What I think would be really good is "Where should I build my IA (and why)?" That was something I was thinking about writing, but I'd love to get your take on it.
My hope with writing the What is a Content Type? and What is a Site Column? articles (and anything else we put in the Basics directory) was they could be linked as building blocks in more complex articles, like what you're suggesting.

Also see: https://github.com/SharePoint/sp-usage-docs/blob/master/docs/making-decisions/list-column-or-site-column-which-one-to-choose.md

From our offline conversation:
When I think about my “Where should I build my IA (and why)?”, I come at it from the bottom up. Will this set of content EVER be needed in more places than just this one? Will its structure serve proposes in ANY other place? I sort of think of it as the “rule of 1 + 1”. If there is ANY possibility of commonality with ANY other place (container), then we have to escalate our thinking. If it turns out the answer is the number of places is some number significantly larger than 1 + 1, the we need to think at the “enterprise” level (regardless the size of the org.) Here I’m thinking about Site Designs and Content Type Hub, Managed Metadata, etc. (Labels fit in here, too, but my thought there are too vague.)

Good conversation, but I'm going to close this as an "issue". Feel free to start new ones if we didn't accomplish something.


Add license

I came across your repo and thought it looks useful. I also noticed that there isn't a license file in the repository.
Could you please add a license? If you're open to suggestions, I would recommend a permissive license like the MIT License (if possible), which would allow others to use, modify, and distribute your code while providing credit back to you.
Here is a link that could help you choose an open source license: https://choosealicense.com/

Thanks, I added the MIT license! (Although I'm not sure about the legality of it given fftw uses GPL.
I originally wrote this with fftw to support fast convolution in a large internal code base, and decided to open source this part. Recently (or not so recently), I got approval from the SciPy developers to work on merging a native implementation of Overlap-Add fast convolution into SciPy. However, SciPy uses a version of pocketfft due to fftw being GPL licensed. So I started porting my code to use recent versions of the pocketfft libraries (C and C++ versions), but the performance I got is way worse than fftw. I would appreciate any insight or suggestions to improve the performance of any implementations here!

Yeah, I get it, the GPL licences complicate things. I don't know anything about pocketfft, but I tried to look up fftw alternatives, and I found https://github.com/project-gemmi/benchmarking-fft which links to https://github.com/Themaister/muFFT and https://www.shoup.net/PGFFT/ and https://bitbucket.org/jpommier/pffft/ which are supposed to be simpler alternatives with comparable performance and more permissive license. Could that be worth exploring?
If this is the pocketfft you were refering to: https://github.com/hayguen/pocketfft maybe it is not the best option? I mean it isn't so popular, and it has no commits for the last two years


10x factor in run time between master and stable

Information

Qiskit Aqua version: master, stable
Python version: 3.6.8
Operating system: Linux

What is the current behavior?
Running QAOA with the master branch takes 10 times longer than the stable branch.
Steps to reproduce the problem
from time import time
from qiskit.providers.aer import QasmSimulator
from qiskit.optimization import QuadraticProgram
from qiskit.optimization.algorithms import MinimumEigenOptimizer
from qiskit.aqua.algorithms import QAOA
from qiskit.aqua.components.optimizers import SLSQP
from qiskit.aqua import QuantumInstance, aqua_globals

qubo = QuadraticProgram()
qubo.binary_var('x1')
qubo.binary_var('x2')
qubo.binary_var('x3')
qubo.binary_var('x4')
qubo.binary_var('x5')
qubo.binary_var('x6')
qubo.binary_var('x7')
qubo.binary_var('x8')
qubo.binary_var('x9')
qubo.binary_var('x10')
qubo.binary_var('x11')
qubo.binary_var('x12')
qubo.binary_var('x13')
qubo.binary_var('x14')
qubo.binary_var('x15')
qubo.binary_var('x16')
qubo.binary_var('x17')
qubo.binary_var('x18')
qubo.binary_var('x19')
qubo.binary_var('x20')

qubo.minimize(linear=[1,-2,3,-6,5,4,4,5,5,5,6,6,0.3,6,6,-2,-2,-2,-2,-2],
              quadratic={('x1', 'x2'): 1, ('x1', 'x3'): -1, ('x1', 'x4'): 2,
                                            ('x2' , 'x3'): 1, ('x2', 'x4'): 6, ('x3', 'x5'): 3,
                                            ('x4', 'x6'): 3, ('x7', 'x8'): -1, ('x7', 'x9'): -1, ('x8', 'x10'): -1,
                                            ('x11', 'x12'): 3, ('x13', 'x14'): -1, ('x10', 'x13'): -1, ('x12', 'x15'): -1,
                                            ('x11', 'x16'): 3, ('x13', 'x17'): -1, ('x18', 'x13'): -1, ('x19', 'x20'): -1
                        })

seed = 10698
sim = QasmSimulator()

aqua_globals.random_seed = seed
quantum_instance = QuantumInstance(sim, seed_simulator=seed, seed_transpiler=seed)

slsqp = SLSQP()
slsqp.set_options(maxiter=500)

start = time()
qaoa_mes = QAOA(quantum_instance=quantum_instance, include_custom=True, optimizer=slsqp, p=3)
qaoa = MinimumEigenOptimizer(qaoa_mes)
qaoa_result = qaoa.solve(qubo)
print('Run time:', time()-start)

Output of machine: 345 seconds with master, 38 seconds with stable.
Suggested solutions
Maybe compare transpilation times.

Is this Aqua's issue? (Which did you use Terra master or Terra stable?)
Perhaps, https://github.com/Qiskit/qiskit-terra/pull/5429 https://github.com/Qiskit/qiskit-terra/pull/5431 may be related.
These are recently found performance problem.

I used master branches of Aqua, Aer, and Terra. Compared to stable branches of all three.

I have checked this. My environment is master and stable/0.8 of Aqua, and master of Terra and Aer for both.
227s (stable/0.8) -> 27s (master)
stable

master

This is opposite to my findings...

Ah sorry my wrong


Stop using gorilla mux

Gorilla mux is a dead project, no long maintained. It won't receive bug fixes or security patches.
gin seems to be a good alternative that has the most adoption for this purpose

Hi!
We moved away from Gin as it made significantly more problems for us than it helped, we switched to Gorilla mux intentionally because it is stable and battle proven, we are not particularly concerned as we only use the router.
We might change it in the future, but we do not have a plan to action this now.


Default TAB binding

Hello, everyone.
I can't map  in normal mode because this already mapping in the plugin to do nav_prev().
Where I found this key to make a change?

"Enter" and "Tab" keys


Change variable name used in show.blade.php

Role and permission description not showing

Upon further inspection of the code, it seems that the variable used to call desc is not correct.
This pull request changes those desc to description

please merge this branches!


chore(pointcloud_container): move glog_component to autoware_launch

Description
Move glog declaration for pointcloud_container in autoware_launch, where the container is launched.
MUST BE MERGED WITH https://github.com/autowarefoundation/autoware_launch/pull/805

Tests performed

Checked that glog_component is included in pointcloud_container with ros2 component list.
Effects on system behavior

No effect expected
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.

[x] I've confirmed the contribution guidelines.
[x] The PR follows the pull request guidelines.

In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.

[ ] The PR follows the pull request guidelines.

Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.

[ ] There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@badai-nguyen Hi, do you mind checking this PR? Related to https://github.com/autowarefoundation/autoware.universe/pull/5716


Migrate away from geoplumber

Only remaining mention of geoplumber is in reproducible.Rmd,  which is covered by #44. Closed.


fix(tracer): mypy use generic type to preserve decorated method signature

Issue #, if available: #465
Description of changes:

Checklist

[x] Meet tenets criteria
[x] PR title follows conventional commit semantics
[x] Use generic callable upper bound to preserve signature for type checker (mypy)
[ ] Use generic awaitable upper bound to preserve signature for type checker (mypy)

Breaking change checklist

RFC issue #:

[ ] Migration process documented
[ ] Implement warnings (if it can live side by side)

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Codecov Report

Merging #529 (8e1b352) into develop (5b87bb1) will decrease coverage by 0.31%.
The diff coverage is 83.33%.

@@             Coverage Diff             @@
##           develop     #529      +/-   ##
===========================================
- Coverage    99.23%   98.92%   -0.32%
===========================================
  Files          113      113
  Lines         4468     4453      -15
  Branches       243      243
===========================================
- Hits          4434     4405      -29
- Misses          22       31       +9
- Partials        12       17       +5

Impacted Files
Coverage Δ

aws_lambda_powertools/tracing/tracer.py
98.91% <83.33%> (-1.09%)
:arrow_down:

aws_lambda_powertools/utilities/parser/types.py
71.42% <0.00%> (-28.58%)
:arrow_down:

...wertools/utilities/idempotency/persistence/base.py
92.99% <0.00%> (-6.37%)
:arrow_down:

...lambda_powertools/utilities/parser/models/apigw.py
97.36% <0.00%> (-0.04%)
:arrow_down:

aws_lambda_powertools/logging/logger.py
100.00% <0.00%> (ø)

aws_lambda_powertools/metrics/metrics.py
100.00% <0.00%> (ø)

aws_lambda_powertools/logging/formatter.py
100.00% <0.00%> (ø)

aws_lambda_powertools/utilities/batch/base.py
100.00% <0.00%> (ø)

aws_lambda_powertools/shared/jmespath_functions.py
100.00% <0.00%> (ø)

... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5b87bb1...8e1b352. Read the comment docs.

Limitation: Async functions signature for type checking can only be preserved by using ParamSpec introduced in 3.10 - PEP 612
We could bring typing_extensions module (240K) which also brings other fixes we'll likely encounter as we adopt mypy more broadly in this lib, including nice features like Protocol for interfaces.
I'll postpone bringing typing_extensions until we either a) hear directly from customers using mypy with async fn as this will manifest elsewhere too not just Powertools, or b) find that we need typing_extensions in order to resolve current mypy findings someplace else.
cc @michaelbrewer @pcolazurdo @cakepietoast


Bug report:

Required VRM Bone "Left Upper Leg" is not assigned. Please confirm hierarchy of Left Upper Leg and its children. "VRM" Panel → "Humanoid" → Left Upper Leg will be empty or displayed in red if hierarchy is wrong
The leg bones cannot appear when i assign them to the respective bone data to convert
3-Step Behaviour
Steps to reproduce the behavior:

Go to 'VRM Required bones'
Click on 'Upper Leg' or another leg bone
See "No results found"

Expectative
It is supposed that the upper_leg.L bones have to be above the upper_leg.R bones, but no.
Screenshots

Desktop (please complete the following information)

OS: Windows 11
Blender 4.1
Addon Version 2.20.37
I'm trying to convert an FBX animation to VRMA format

I used the VRM armature as reference for rename the animated bones.

For the purposes of our research, could you please attach screenshots of all current bone assignments and the structure of all bones?


Should mean we're connected. What happens if you try to run a cell?

I've run the notebook, and despite the fact that it reports:
Info 2020-08-03 22:36:55: Python Daemon (pid: 17787): write to stderr: [I 22:36:55.003 NotebookApp] Kernel started: 04ed912c-1b34-4334-a75f-5b2476a2994b

Info 2020-08-03 22:36:55: Waiting for idle on (kernel): 04ed912c-1b34-4334-a75f-5b2476a2994b -> unknown
Info 2020-08-03 22:36:55: Kernel switching to busy
Info 2020-08-03 22:36:55: Request for tmlanguage file.
Info 2020-08-03 22:36:55: Python Daemon (pid: 17787): write to stderr: [I 22:36:55.212 NotebookApp] Adapting from protocol version 5.2 (kernel 04ed912c-1b34-4334-a75f-5b2476a2994b) to 5.3 (client).

Info 2020-08-03 22:36:55: Finished waiting for idle on (kernel): 04ed912c-1b34-4334-a75f-5b2476a2994b -> idle

the UI shows

When I try to run a cell nothing really happens

and the log says
Info 2020-08-03 22:37:51: Python Daemon (pid: 17787): write to stderr: [W 22:37:51.116 NotebookApp] WebSocket ping timeout after 90001 ms.

Info 2020-08-03 22:37:56: Python Daemon (pid: 17787): write to stderr: [I 22:37:56.119 NotebookApp] Starting buffering for 41c7412c-a978-495b-9e09-7f68779518cf:12b747a2-c10c-4967-aa06-043814ed6afd

Info 2020-08-03 22:38:05: Executing cell 2951b6f7-598b-4af4-8e30-fd2a12ab290e
Info 2020-08-03 22:38:05: Waiting for jupyter server and web panel ...
Info 2020-08-03 22:38:05: Submitting code for 4f3b2801-67e5-4538-8946-64af281ad595

In the meantime, the kernel gets the request, performs the calculations and returns the result
waiting for a message...
got something!
source: engine
received msgtype: calculate
received content: {
   "expr" : "2+2",
   "id" : 2
}

sending...
reply  header: {
	"date" : "2020-08-03T22:38:05.293534",
	"msg_id" : "4723970e-e8ec-45b7-9f20-a6ccb77f7c66",
	"msg_type" : "status",
	"session" : "b75e13d4-0386-4225-b846-54afbaf21d1a",
	"username" : "kernel",
	"version" : "5.0"
}
parent header: {
	"date" : "2020-08-03T20:38:05.291Z",
	"msg_id" : "ee9a1c12-7bff-4b67-aa91-bd68287182b9",
	"msg_type" : "execute_request",
	"session" : "a5848169-0891-464b-89a8-5f73189e290a",
	"username" : "",
	"version" : "5.2"
}
reply content: {
	"execution_state" : "busy"
}
sent
sending...
reply  header: {
	"date" : "2020-08-03T22:38:05.293636",
	"msg_id" : "d1d1feca-a978-4b54-973e-81d0fe338884",
	"msg_type" : "execute_input",
	"session" : "b75e13d4-0386-4225-b846-54afbaf21d1a",
	"username" : "kernel",
	"version" : "5.0"
}
parent header: {
	"date" : "2020-08-03T20:38:05.291Z",
	"msg_id" : "ee9a1c12-7bff-4b67-aa91-bd68287182b9",
	"msg_type" : "execute_request",
	"session" : "a5848169-0891-464b-89a8-5f73189e290a",
	"username" : "",
	"version" : "5.2"
}
reply content: {
	"code" : null,
	"execution_count" : null
}
sent
waiting for a message...
got something!
source: engine
received msgtype: result
received content: {
   "id" : 2,
   "result" : "4;",
   "side_effects" : ""
}

sending...
reply  header: {
	"date" : "2020-08-03T22:38:05.293750",
	"msg_id" : "459b8496-86ce-4e93-bcc4-d5e1361bb220",
	"msg_type" : "stream",
	"session" : "b75e13d4-0386-4225-b846-54afbaf21d1a",
	"username" : "kernel",
	"version" : "5.0"
}
parent header: {
	"date" : "2020-08-03T20:38:05.291Z",
	"msg_id" : "ee9a1c12-7bff-4b67-aa91-bd68287182b9",
	"msg_type" : "execute_request",
	"session" : "a5848169-0891-464b-89a8-5f73189e290a",
	"username" : "",
	"version" : "5.2"
}
reply content: {
	"name" : "stdout",
	"text" : ""
}
sent
sending...
reply  header: {
	"date" : "2020-08-03T22:38:05.332482",
	"msg_id" : "b041a6f9-bbdd-4616-86f0-1fa6a50d8697",
	"msg_type" : "execute_result",
	"session" : "b75e13d4-0386-4225-b846-54afbaf21d1a",
	"username" : "kernel",
	"version" : "5.0"
}
parent header: {
	"date" : "2020-08-03T20:38:05.291Z",
	"msg_id" : "ee9a1c12-7bff-4b67-aa91-bd68287182b9",
	"msg_type" : "execute_request",
	"session" : "a5848169-0891-464b-89a8-5f73189e290a",
	"username" : "",
	"version" : "5.2"
}
reply content: {
	"data" :
	{
		"text/latex" : "$4$",
		"text/plain" : "4"
	},
	"execution_count" : 2,
	"status" : "ok"
}
sent
sending...
reply  header: {
	"date" : "2020-08-03T22:38:05.332590",
	"msg_id" : "98a46918-b317-467e-a528-8794e6b99089",
	"msg_type" : "execute_result",
	"session" : "b75e13d4-0386-4225-b846-54afbaf21d1a",
	"username" : "kernel",
	"version" : "5.0"
}
parent header: {
	"date" : "2020-08-03T20:38:05.291Z",
	"msg_id" : "ee9a1c12-7bff-4b67-aa91-bd68287182b9",
	"msg_type" : "execute_request",
	"session" : "a5848169-0891-464b-89a8-5f73189e290a",
	"username" : "",
	"version" : "5.2"
}
reply content: {
	"data" :
	{
		"text/latex" : "$4$",
		"text/plain" : "4"
	},
	"execution_count" : 2,
	"metadata" : "{}"
}
sent
sending...
reply  header: {
	"date" : "2020-08-03T22:38:05.332653",
	"msg_id" : "7b11765a-d7d7-4a26-a49f-7ea73311d443",
	"msg_type" : "status",
	"session" : "b75e13d4-0386-4225-b846-54afbaf21d1a",
	"username" : "kernel",
	"version" : "5.0"
}
parent header: {
	"date" : "2020-08-03T20:38:05.291Z",
	"msg_id" : "ee9a1c12-7bff-4b67-aa91-bd68287182b9",
	"msg_type" : "execute_request",
	"session" : "a5848169-0891-464b-89a8-5f73189e290a",
	"username" : "",
	"version" : "5.2"
}
reply content: {
	"execution_state" : "idle"
}
sent
waiting for a message...

Hmm, is that 'switching to kernel' dialog still active? It looks like we get the idle state but don't think we finished switching.

Yes, the dialog is still active. I've just run it again, and it's still on 5 minutes after an attempt to switch the kernel.

It looks like in the code it should have finished once that ' Finished waiting for idle on (kernel): 04ed912c-1b34-4334-a75f-5b2476a2994b -> idle' message came through.
Somebody will have to debug it on our side. Can you add the 'status: idle' part to the released yacas kernel so we can debug after that fix?

Yes, of course, could you please just  tell me what you actually need? Do you compile the kernel yourself and you need only the fix pushed to the master, or you use binary debian packages?

I was using the debian packages when I tried it last. That's probably the most likely way this will get looked at.

OK, the 1.9.2 version which adds the idle message is up in the ppa

I'm having trouble installing:
dpkg: error processing archive /var/cache/apt/archives/yacas_1.3.6-2build1_amd64.deb (--unpack):
 trying to overwrite '/usr/share/yacas/scripts/array.rep/code.ys', which is also in package yacas-common 1.9.1-1~focal
dpkg-deb: error: paste subprocess was killed by signal (Broken pipe)
Errors were encountered while processing:
 /var/cache/apt/archives/yacas_1.3.6-2build1_amd64.deb
E: Sub-process /usr/bin/dpkg returned an error code (1)

Sorry I'm not anywhere near an expert on how to get packages onto linux. Does this mean I need to uninstall it first?

Yeah, I've got exactly the same issue a couple days ago, and scratched my head for quite a while.
Anyway, there's a prehistoric version of yacas (1.3.6) shipped with ubuntu. The package name for it is just yacas. The newer version from my ppa is split into several packages: yacas-common, yacas-console, yacas-gui, yacas-kernel and so on. What you need to install is yacas-kernel, which should automatically bring yacas-common as well.
I should somehow deal with this split in a way that is more user friendly, but I don't really know anything about packaging.

Updating the kernel seems to have worked. Hopefully I'll have some time to debug this in the near future.

I got some time to debug it. It looks like one of the messages returned has an invalid property set on it.
We get this error in the jupyterlab kernel:
stack trace: Error: Kernel message validation error: Property 'code' is not of type 'string
	at validateProperty (/mnt/f/vscode-python/node_modules/@jupyterlab/services/lib/kernel/validate.js:52:19)
	at validateIOPubContent (/mnt/f/vscode-python/node_modules/@jupyterlab/services/lib/kernel/validate.js:90:13)
	at Object.validateMessage (/mnt/f/vscode-python/node_modules/@jupyterlab/services/lib/kernel/validate.js:73:9)
	at JupyterWebSocket.DefaultKernel._onWSMessage (/mnt/f/vscode-python/node_modules/@jupyterlab/services/lib/kernel/default.js:108:26)
	at JupyterWebSocket.onMessage (/mnt/f/vscode-python/node_modules/ws/lib/event-target.js:120:16)
	at JupyterWebSocket.emit (events.js:200:13)
	at /mnt/f/vscode-python/out/client/datascience/kernelSocketWrapper.js:70:39
	at processTicksAndRejections (internal/process/task_queues.js:89:5)

Looking in the debugger, it looks like an 'execute_result' message is returning invalid content. It looks like so:

The content property of the message has a 'null' code item.

This is happening while we're waiting to go to idle.

OK, good catch! It's been a bit convoluted, because apparently you issue %config commands right after starting the kernel, which I somehow haven't noticed before. (Has this changed recently?).
Anyway, this detected actual bug in one of the replies (harmless in standalone jupyter, that's why it went unnoticed) and perhaps incompatibility with handling the error messages, where vscode doesn't accept null values and requires empty strings instead.
After fixing these null-value issues everything seems to work.
Thanks a lot!

Woot! Awesome that it worked.


After restarting with the installation of Teletype, Atom throws the error: Cannot redefine property: ontrack

edit by @rsese to add a couple of notes
Also reproducible on macOS 10.12.6  off of 1.29.0-dev-74c496ccd.
And as mentioned in https://github.com/atom/teletype/issues/382#issuecomment-392380722, looks like no error on 1.27.1.

Description
After restarting with the installation of Teletype, Atom throws the error: Cannot redefine property: ontrack
Steps to Reproduce

@annthurium wants to show you something cool and asks you to install Teletype
Open Atom 1.28.0-beta1 on a machine running Debian Sid under KDE 5.12.5
Install Teletype 1.32.2
Restart Atom
Observe

Expected:
Atom opens and @annthurium shows you a cool thing.
Actual:
Atom opens and throws the following error:
TypeError: Cannot redefine property: ontrack
    at Function.defineProperty (<anonymous>)
    at Object.wrapPeerConnectionEvent (/home/rubin110/.atom/packages/teletype/node_modules/webrtc-adapter/src/js/utils.js:60:10)
    at Object.shimSenderReceiverGetStats (/home/rubin110/.atom/packages/teletype/node_modules/webrtc-adapter/src/js/chrome/chrome_shim.js:288:13)
    at module.exports (/home/rubin110/.atom/packages/teletype/node_modules/webrtc-adapter/src/js/adapter_factory.js:76:18)
    at Object.<anonymous> (/home/rubin110/.atom/packages/teletype/node_modules/webrtc-adapter/src/js/adapter_core.js:13:18)
    at Object.<anonymous> (/home/rubin110/.atom/packages/teletype/node_modules/webrtc-adapter/src/js/adapter_core.js:15:3)
    at Module.get_Module._compile (/usr/share/atom-beta/resources/app/src/native-compile-cache.js:106:36)
    at Object.value [as .js] (/usr/share/atom-beta/resources/app/src/compile-cache.js:240:29)
    at Module.load (module.js:561:32)
    at tryModuleLoad (module.js:504:12)
    at Function.Module._load (module.js:496:3)
    at Module.require (file:///usr/share/atom-beta/resources/app.asar/static/index.js:47:45)
    at require (/usr/share/atom-beta/resources/app/src/native-compile-cache.js:66:33)
    at Object.<anonymous> (/home/rubin110/.atom/packages/teletype/node_modules/@atom/teletype-client/lib/peer-connection.js:1:156)
    at Object.<anonymous> (/home/rubin110/.atom/packages/teletype/node_modules/@atom/teletype-client/lib/peer-connection.js:280:3)
    at Module.get_Module._compile (/usr/share/atom-beta/resources/app/src/native-compile-cache.js:106:36)
    at Object.value [as .js] (/usr/share/atom-beta/resources/app/src/compile-cache.js:240:29)
    at Module.load (module.js:561:32)
    at tryModuleLoad (module.js:504:12)
    at Function.Module._load (module.js:496:3)
    at Module.require (file:///usr/share/atom-beta/resources/app.asar/static/index.js:47:45)
    at require (/usr/share/atom-beta/resources/app/src/native-compile-cache.js:66:33)
    at Object.<anonymous> (/home/rubin110/.atom/packages/teletype/node_modules/@atom/teletype-client/lib/peer-pool.js:3:24)
    at Object.<anonymous> (/home/rubin110/.atom/packages/teletype/node_modules/@atom/teletype-client/lib/peer-pool.js:194:3)
    at Module.get_Module._compile (/usr/share/atom-beta/resources/app/src/native-compile-cache.js:106:36)
    at Object.value [as .js] (/usr/share/atom-beta/resources/app/src/compile-cache.js:240:29)
    at Module.load (module.js:561:32)
    at tryModuleLoad (module.js:504:12)
    at Function.Module._load (module.js:496:3)
    at Module.require (file:///usr/share/atom-beta/resources/app.asar/static/index.js:47:45)

Reproduces how often:
100% of the time
Versions
Atom 1.28.0-beta1
Debian Sid under KDE 5.12.5
Teletype 1.32.2

I should note this works fine with Atom stable, 1.27.1.

Seeing same issue
Atom       : 1.28.0-beta1
Electron  : 2.0.1
Chrome   : 61.0.3163.100
Node        : 8.9.3
teletype   : 0.13.2

Thanks for the report @rubin110 - reproduced on macOS 10.12.6 with Atom 1.29.0-dev-74c496ccd.  In my case I didn't need to restart, just installing Teletype was enough to cause the error.  The error pops up after restarting too though.
Also had 1.27.1 installed and didn't see the error there.

Should be fixed by upgrading to at least<EMAIL_ADDRESS>which includes https://github.com/webrtc/adapter/pull/817.  However, it looks like teletype-client should already be picking up that version?
https://github.com/atom/teletype-client/blob/f15e39c3ad451e8660781f72eb4eeee1ab4330d8/package.json#L18


[DON'T MERGE - JUST CI VALIDATION]Merging master back into feature branch

Wrong target branch

Wrong target branch


Chart Disappears after opening an ionic modal

Hi, I am using chartjs with my ionic phonegap app. To display graphs I am using angular-chart.js as suggested in this tutorial.
I have responsive set on my line graph and everything works fine until I open up a modal window. it disappears and doesn't work until I restart the app. if I set responsive to false then I don't get this problem but by graph stays as a small size even when on bigger devices
Is there any way I can have the graphs work even after opening modals and have the graphs responsive at the same time?

I feel like this might be better asked on stack overflow.


Support Other Email Services

This includes non-sendmail, or SMTP-based (important for not sending sensitive security data to 3rd parties).

On reflection, the work here should take place after the Action Engine's initial release.

Andy Lawrence has an initial design doc here.
https://groups.google.com/a/forsetisecurity.org/d/msg/discuss/YGmop4TuPck/0gG5g7IrBwAJ


[New Component] a checkbox component

Can I work on this?

sure!!

Hey @kr-anurag @avneesh0612 can I use a external stylesheet for the checkbox component?
I am actually trying to make a custom checkbox using tailwind, but that needs to have a external stylesheet.

Hey @kr-anurag @avneesh0612 can I use a external stylesheet for the checkbox component? I am actually trying to make a custom checkbox using tailwind, but that needs to have a external stylesheet.

sure yep!


addInitialFiles is calling onAllComplete multiple times

Type of issue

[x] Bug report
[ ] Feature request
[ ] Support request

Uploader type

[x] Traditional
[ ] S3
[ ] Azure

As in topic. If I call addInitialFiles with array of ex. 3 files onAllComplete is called 3 times - should be one time.
Also there is no onUpload call.
Fine Uploader version
5.13.0

onUpload will not be called as nothing is being uploaded.

So there could be new event - onContainerCreate to indicate when new item is placed into DOM.
I have some custom  elements in item's template which need to be handled after inserting to DOM.

Listen for onSubmitted. For initial files, once a status changed of qq.status.UPLOAD_SUCCESSFUL Is broadcast, that initial file is now in the DOM.


Add Storage classes for Tut and Rec

Now has merge conflicts

seems like there is conflicts with SCA Test; pls chk


Listens to mesos state store success event to re-render UI after failed requests.

Reviewer: @daiyiwhale

Other than the #nit it LGTM


Callback verification failed with the following errors: HTTP Status Code = 404

Hello guyz,
I'm trying to work on Facebook instant games. Firstly I'm trying to run the demo game "Tic Tac Toe" provided by facebook from the following link.
https://origincache.facebook.com/developers/resources/?id=tic-tac-toe.zip
When I run the client app of the project it's able to lead me to the game play scene but that's not playable due to invalid signature from backend. Then I looked through the SERVER-README.md and found instruction of enabling messenger bot for the app. I followed all the instruction provided in the url of readme file and able to create a webhook and deploy that to heroku for my app. I tried to test the webhook through my terminal and it responded successfully as shown in the tutorial even with the deployed webhook url on heroku.
Later I tried to add the webhook to my facebook app and faced a problem which solution is not being found searching through the google. In app messenger setting, when I tried to setup webhook and provided callback url and verify token of the webhook it was not verifying saying the following error.
"The URL couldn't be validated. Callback verification failed with the following errors: HTTP Status Code = 404; HTTP Message = Not Found"
Now I'm not getting what can I do to solve the error. Please let me know if anybody knows the solution for the problem or any other way to run the demo game successfully.
Thank you

Your issue is not related to watson botkit middleware.


1.32.0-beta.0 - Fix patches for containernetworking,coredns,external-provisioner

Description of changes:
1.32.0-beta.0 - Update the missing patches for containernetworking,coredns,external-provisioner .
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Discarding it


Build PyPy wheels also

Codecov Report

Merging #1077 (bd75645) into master (2dfe9f1) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1077   +/-   ##
=======================================
  Coverage   91.28%   91.28%
=======================================
  Files          90       90
  Lines       13358    13358
  Branches     1493     1493
=======================================
  Hits        12194    12194
- Misses        952      953    +1
+ Partials      212      211    -1

Impacted Files
Coverage Δ

coverage/debug.py
58.51% <0.00%> (-0.88%)
:arrow_down:

tests/test_oddball.py
82.73% <0.00%> (+1.19%)
:arrow_up:


Dom.focus does not raise keyboard in Firefox for Android

If you do .focus() in Javascript on a text input element in a mobile device, normally the screen keyboard is shown automatically, just like if you focus the element manually.
However, using Dom.focus this does not happen in Firefox for Android.
A sample app is here:
https://ellie-app.com/embed/7FD6kr6kba1/1
(Using Elm 0.18)
Further info:
In Firefox for Android, there seems to be a condition that in order for the .focus() call to invoke the appearance of the screen keyboard, the call must be done from within an event handler responding to user action, such as a click or tap. (I guess this is a deliberate feature, to stop web pages doing crazy things with keyboards misbehaving, I believe similar logic has been used to prevent certain actions such as lots of popup windows being created etc.).
If the call is from within a callback passed to setTimeout or requestAnimationFrame, while the text input is focussed as expected, the keyboard does not appear on the screen.
Demo for this behaviour:
https://codepen.io/spookylukey/full/GyERmL
In my tests Chrome for Android, doesn't show the same behaviour, the keyboard opens in all cases. I haven't tested any other browsers.
I don't know the architecture of Elm well enough, but I'm assuming this problem is due to Elm passing everything through requestAnimationFrame or something similar, and that fixing it will basically be impossible.
If so, that's understandable. It could perhaps be documented, or this bug could serve as documentation even if it is closed as WONTFIX.
I have also tried using ports and doing the .focus() call in Javascript, but this doesn't work, presumably because that code is also not run from within the call stack of an 'onclick' event handler. (I haven't created a minimal test case for this yet).

In case the ellie-app/code-pen links rot in the future, here are minimal test cases:
Elm Main.js:
import Html exposing (Html, program, div, input, button, text)
import Html.Attributes as A
import Html.Events exposing (onClick)
import Task

import Dom

main =
  program {
     init = init, view = view, update = update,
     subscriptions = \m -> Sub.none
  }

init = (Empty, Cmd.none)

view model =
  div []
    [ input [ A.id "textbox"
            , A.type_ "text"
            ]  []

    , button [ onClick FocusIt ] [ text "Focus" ]
    ]

type Msg
    = FocusIt
    | Noop

type Model = Empty

update msg model =

  case msg of
     FocusIt ->
         (model,  Task.attempt (\_ -> Noop) (Dom.focus "textbox"))
     Noop ->
         (model, Cmd.none)

Javascript comparison:
<!DOCTYPE html>

    <input type="text" id="textbox">

Direct onclick:
      <button onclick="focusIt()">Focus it</button>

Using setTimeout:
      <button onclick="setTimeout(focusIt, 0)">Focus it</button>

Using requestAnimationFrame:
      <button onclick="requestAnimationFrame(focusIt)">Focus it</button>

According to this comment from Evan, the issue may be fixed in Elm 0.19

In 0.19 you can do things synchronously through ports. I think that'll let you do whatever you need to do.


Rani Task 6, Task 7, Task 8, Task 9

@RaniAlurwad
Task6: Changes verified
Task7: Not given index number.

Task8: Not given index number

Task9: Changes verified


Support for M6in

m6in.32xlarge can support up to 200 Gbps.  My application only needs the NAT for inbound traffic.  That being the case, is it feasible to use fck-nat with a m6in.32xlarge and get 200 Gbps inbound?  I can see you've noted 5 Gbps for egress, but I don't see a limit for ingress.

From the docs:

To other Regions, an internet gateway, Direct Connect, or local gateways (LGW) – Traffic can utilize up to 50% of the network bandwidth available to a current generation instance with a minimum of 32 vCPUs. Bandwidth for a current generation instance with less than 32 vCPUs is limited to 5 Gbps.

So it would be "up to 50%" of 200Gbps, so a max of 100Gbps. AWS doesn't provide any further guarantees.

Thanks for the quick response.  Current need is nowhere near 200 Gbps, but good to know that the real theoretical limit is up to 100 Gbps.


error when patching uvcvideo

Required Info

Camera Model
R200

Firmware Version

Operating System & Version
Ubuntu 14.04.04 LTS

Kernel Version (Linux Only)
4.4.0-040400-generic

Build System

I extract the zip file to ~/Documents, and then I follow the instructions. When I run this instruction "./scripts/patch-uvcvideo-4.4.sh v4.4-wily", some erros are displayed. Please see below, how can I deal with it? thank you.
**# patching file debian.master/config/i386/config.flavour.lowlatency
patching file debian.master/config/powerpc/config.common.powerpc
patching file debian.master/config/ppc64el/config.common.ppc64el
patching file drivers/media/usb/uvc/uvc_driver.c
Hunk #1 succeeded at 109 (offset 1 line).
patching file drivers/media/usb/uvc/uvcvideo.h
patching file include/uapi/linux/videodev2.h
Hunk #1 succeeded at 594 (offset 15 lines).
HOSTCC  scripts/basic/fixdep
HOSTCC  scripts/kconfig/conf.o
SHIPPED scripts/kconfig/zconf.tab.c
SHIPPED scripts/kconfig/zconf.lex.c
SHIPPED scripts/kconfig/zconf.hash.c
HOSTCC  scripts/kconfig/zconf.tab.o
HOSTLD  scripts/kconfig/conf
scripts/kconfig/conf  --silentoldconfig Kconfig

*** Configuration file ".config" not found!

*** Please run some configurator (e.g. "make oldconfig" or
*** "make menuconfig" or "make xconfig").

make[3]: *** [silentoldconfig] Error 1
make[2]: *** [silentoldconfig] Error 2
make[1]: *** No rule to make target include/config/auto.conf', needed by scripts'.  Stop.
make: *** [__build_one_by_one] Error 2**

Hi @brightlight2084 sorry for the trouble, I think this was unintentionally caused by me in the latest commit on master. Can you try again with a version of this script 1 commit behind HEAD? Here is a direct link: https://github.com/IntelRealSense/librealsense/blob/d185508c1780a63da9835b9f05e1b5cb0e07bd02/scripts/patch-uvcvideo-4.4.sh

Got the same issue. The script 1 commit behind HEAD is working.

Now it's working, thank you.

@ravrichard only one way to find out! :)