速度依旧很慢，是不是要进行什么配置啊

Before feedback
Before you feedback, please search for the issues to see if there are similar problems that can solve your problem.
Please delete the above and the contents of this line, then fill in the feedback form in the following format, Thanks.

Describe the bug
A clear and concise description of what the bug is.
To Reproduce
Steps to reproduce the behavior:

Go to '...'
Click on '....'
Scroll down to '....'
See error

Expected behavior
A clear and concise description of what you expected to happen.
Screenshots
If applicable, add screenshots to help explain your problem.
Environment (please complete the following information):

OS & Version: [e.g. macOS, Windows, Linux]
Version: [e.g. macOS 10.14.2, Windows 10, Ubuntu 18.04]
Motrix Version: [e.g. v1.1.3, v1.1.0]
Installation package type: [e.g. dmg, AppImage]

Additional context
Add any other context about the problem here.

使用MO下载下面有个设置，需要需改User-Agent和Referer。修改前几十K，修改后5M/s


Fixing the bugfix #1718

Bugfix #1718 for bug #1717 was faulty and gets fixed with this.

Q
A

Bug fix?
[X]

New feature?
[ ]

New sample?
[ ]

Related issues?
fixes #1717

What's in this Pull Request?
Removed the wrongly added reference to "results".

@michaelmaillot Thank you for noticing that. I have updated the code.

Sorry @IRRDC but as this is a hotfix release, target branch will be dev and not main (then we will cherry-pick your fix to master in order to release a patch verison).
Would you mind resolving conflicts before the merge?

@michaelmaillot should be resolved now.

Sorry @IRRDC but old code is still present here

@michaelmaillot Looks like the merge removed all my changes. I have restored them now.


roads check function

Once the initial review has been conducted, we could review if this is needed.
A number of comments flagged in the review .

Reworked this function and streamlined, incorporated in #2


[Event Request] Page 700 Page Management - Procedure GetSalesHeaderPageID - OnBeforeGetSalesHeaderPageID

Describe the request
Please add the following Event/-s OnBeforeGetSalesHeaderPageID to procedure GetSalesHeaderPageID in Page 700 Page Management
[Event Request] Page 700 Page Management - Procedure GetSalesHeaderPageID
    local procedure GetSalesHeaderPageID(RecRef: RecordRef): Integer
    var
        SalesHeader: Record "Sales Header";
        IsHandled : Boolean:
    begin
        // NEW
        IsHandled := FALSE;
        OnBeforeGetSalesHeaderPageID(RecRef,IsHandled);
        IF IsHandled  THEN
          EXIT;
        // NEW

        RecRef.SetTable(SalesHeader);
        case SalesHeader."Document Type" of
            SalesHeader."Document Type"::Quote:
                exit(PAGE::"Sales Quote");
            SalesHeader."Document Type"::Order:
                exit(PAGE::"Sales Order");
            SalesHeader."Document Type"::Invoice:
                exit(PAGE::"Sales Invoice");
            SalesHeader."Document Type"::"Credit Memo":
                exit(PAGE::"Sales Credit Memo");
            SalesHeader."Document Type"::"Blanket Order":
                exit(PAGE::"Blanket Sales Order");
            SalesHeader."Document Type"::"Return Order":
                exit(PAGE::"Sales Return Order");
        end;
    end;

 [IntegrationEvent(false, false)]
 local procedure OnBeforeGetSalesHeaderPageID(RecRef: RecordRef,var IsHandled : Boolean)
    begin
    end;

Additional context
Preparation for use of rebooking orders
Internal work item: AB#539823

The design is to use
OnBeforeGetConditionalCardPageID(RecRef, CardPageID, IsHandled);
in page management.
Can you use that instead? Im not really up for adding this event, as we then also have to think about other scenarios. Like purchase and service.
Cant you create your own Booking Document?

We don't have a own booking document, we have in some cases a special Order Document with a own Page/List.
The use of the OnBeforeGetConditionalCardPageID-Event would be an option, but would require that the GetSalesHeaderPageID will never get other call points and never will be global.

Ok.
We wont introduce this event. If you mark IsHandled true in OnBeforeGetConditionalCardPageID, then it will never get other call points.


Sync executable with formal spec - CHAIN STS

In the formal spec ChainState we have h ∈ HashHeader and in the exec. spec, h ∈ HashHeader?.

this is from https://github.com/input-output-hk/cardano-ledger-specs/pull/639/files
there is still the question about how the last Byron block and first Shelley block will be handled
The change was required in the exec spec and should be integrated into the formal spec

Yes, we should be consistent. @dcoutts suggested we could possibly use a sum type here to distinguish pointing to a Byron block or a Shelly block.


Problem with inference

python enhancement.py --test_dir test_dir/ --enhanced_dir enhanced_dir/ --ckpt StoRM_Checkpoints/StoRM/TIMIT+Chime3/epoch\=761-pesq\=0.00.ckpt  --mode denoiser-only

/home/dsprotasov/miniconda3/envs/storm/lib/python3.8/site-packages/torch/cuda/__init__.py:145: UserWarning:
NVIDIA A100 80GB PCIe with CUDA capability sm_80 is not compatible with the current PyTorch installation.
The current PyTorch install supports CUDA capabilities sm_37 sm_50 sm_60 sm_70.
If you want to use the NVIDIA A100 80GB PCIe GPU with PyTorch, please check the instructions at https://pytorch.org/get-started/locally/

  warnings.warn(incompatible_device_warn.format(device_name, capability, " ".join(arch_list), device_name))
/home/dsprotasov/miniconda3/envs/storm/lib/python3.8/site-packages/pydub/utils.py:170: RuntimeWarning: Couldn't find ffmpeg or avconv - defaulting to ffmpeg, but may not work
  warn("Couldn't find ffmpeg or avconv - defaulting to ffmpeg, but may not work", RuntimeWarning)
Traceback (most recent call last):
  File "enhancement.py", line 56, in <module>
    model = model_cls.load_from_checkpoint(
  File "/home/dsprotasov/miniconda3/envs/storm/lib/python3.8/site-packages/pytorch_lightning/core/saving.py", line 137, in load_from_checkpoint
    return _load_from_checkpoint(
  File "/home/dsprotasov/miniconda3/envs/storm/lib/python3.8/site-packages/pytorch_lightning/core/saving.py", line 180, in _load_from_checkpoint
    return _load_state(cls, checkpoint, strict=strict, **kwargs)
  File "/home/dsprotasov/miniconda3/envs/storm/lib/python3.8/site-packages/pytorch_lightning/core/saving.py", line 225, in _load_state
    obj = cls(**_cls_kwargs)
  File "/home/dsprotasov/xch/storm/sgmse/model.py", line 46, in __init__
    dnn_cls = BackboneRegistry.get_by_name(backbone)
  File "/home/dsprotasov/xch/storm/sgmse/util/registry.py", line 30, in get_by_name
    raise ValueError(f"{self.managed_thing} with name '{name}' unknown.")
ValueError: Backbone with name 'blade' unknown.

Does anyone know what the problem might be?

The problem is that 'blade' is not registered in Registry file. The solution is to change the value of backbone to ncsnpp.
If you check in the init() of the ScoreModel class
class ScoreModel(pl.LightningModule):
    def __init__(self,
        backbone: str = "blade", sde: str = "ouvesde",
        lr: float = 1e-4, ema_decay: float = 0.999,
        t_eps: float = 3e-2, transform: str = 'none', nolog: bool = False,
        num_eval_files: int = 50, loss_type: str = 'mse', data_module_cls = None, **kwargs
    ):

Just change that value of ncsnpp. Should look like this:
class ScoreModel(pl.LightningModule):
    def __init__(self,
        backbone: str = "ncsnpp", sde: str = "ouvesde",
        lr: float = 1e-4, ema_decay: float = 0.999,
        t_eps: float = 3e-2, transform: str = 'none', nolog: bool = False,
        num_eval_files: int = 50, loss_type: str = 'mse', data_module_cls = None, **kwargs
    ):

Worked for me. Should work for you as well.
Best of luck!!


http: add SameSite option to cookie

Codecov Report

Merging #278 into develop will increase coverage by 0.06%.
The diff coverage is 100%.

@@             Coverage Diff             @@
##           develop     #278      +/-   ##
===========================================
+ Coverage    52.62%   52.69%   +0.06%
===========================================
  Files          235      235
  Lines        22459    22480      +21
===========================================
+ Hits         11820    11845      +25
+ Misses        9291     9289       -2
+ Partials      1348     1346       -2

Impacted Files
Coverage Δ

bfe_http/cookie.go
70.32% <100%> (+2.76%)
:arrow_up:

bfe_spdy/server_conn.go
78.53% <0%> (-0.45%)
:arrow_down:

bfe_http2/server.go
71.67% <0%> (+0.32%)
:arrow_up:

bfe_websocket/server_conn.go
74.24% <0%> (+1.51%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2292561...4333868. Read the comment docs.


support setup etcd cluster with diff interfaces

Use fact ·ansible_default_ipv4.address· can setup etcd cluster on different network interfaces
for example
setup etcd cluster with 2 nodes A (default_ipv4.interface is eth0), B (default_ipv4.interface is virbr0, it's a virtual machine)
use fact ['ansible_' + etcd_interface] will failed, variable etcd_interface is related to the host that is executing, and node A does not have virbr0 and B does not have eth0 respectively.
use fact ansible_default_ipv4 can solve this.
======================
The method solve problem above was outdated.
Adapt @rutsky 's suggestion, simply using if statement to solve the problem.

This change is

@redhat-k8s-bot test please

@redhat-k8s-bot test please

See https://github.com/kubernetes/contrib/pull/724 for where this came from. @rutsky added this. What you did should, I believe, be a no-op, as etcd_interface should be set to the default ipv4 interface per host by default...

Internal error

because setuptools-34.0.2.zip installed via pip is most likely broken

https://github.com/pypa/setuptools/issues/937

This PR will break Vagrant+VirtualBox configuration and according to this comment:
# Interface on which etcd listens.
# Useful on systems when default interface is not connected to other machines,
# for example as in Vagrant+VirtualBox configuration.
# Note that this variable can't be set in per-host manner with current implementation.
etcd_interface: "{{ ansible_default_ipv4.interface }}"

it indeed doesn't allow to specify different interfaces on different hosts.
@xialonglee please suggest solution that doesn't break Vagrant configuration.

@rutsky
i see your point... so variable etcd_interface is used for Vagrant configuration.( i usaully setup a k8s clusters directly on physical machines so didn't notice that... maybe i should try it)
maybe register a fact that assigned etcd_interface value could solve it and without any side effect.
What's your opinion?
if that would work i will update this pr after few days.( because i am in vacation now and there is no environment to test)

@xialonglee I don't see easy way to support setting per-host custom public etcd interface, and, which is more important, I don't see need for this currently.
I suggest to cover two use cases: custom single etcd interface on all hosts (i.e. Vagrant case), and use of default_ipv4.interface (i.e. "common" case for typical physical/vm setups).
To do so I suggest to make etcd_interface not defined by default and in all dependent places (like etcd_machine_address: "{{ hostvars[inventory_hostname]['ansible_' + etcd_interface].ipv4.address }}") check is etcd_interface defined --- if it is, use it, if it is not, use default_ipv4.interface.

@rutsky
That's good and much better then my suggestion. it's the simplest way to solve the problem in setting etcd cluster with different network interface name.
Thanks for your suggestion, i will update my code.

@xialonglee etcd_initial_advertise_peer_urls uses etcd_interface too, you haven't covered this.

@rutsky
My local test shows that there's no problem with etcd_initial_advertise_peer_urls.
I see the etcd_advertise_client_urls was assigned by one value of
"{{ etcd_url_scheme }}://{{ etcd_machine_address }}:{{ etcd_client_port }}".
Here etcd_machine_address was assigned by {{ hostvars[inventory_hostname]['ansible_' + etcd_interface].ipv4.address }}.
There is only one value of etcd_advertise_client_urls, not related to other machines, in non-Vagrant case, it equals to default_ipv4.interface(default etcd_interface is default_ipv4.interface) of the host that is executing.
So i think that is no need to covered.

@xialonglee isn't in your case etcd_machine_address will have invalid IP address: IP of eth0 instead of IP virbr0?

@rutsky
No, it is not. It works correctly.
Actually, i got two machines node A and node B to be etcd clusters.
Node A is a physical machine and Node B is a virtual machine running on Node A.
Node A network interfaces is:
virbr0
docker0
flannel.1
....
Node B network interfaces is:
eth0
docker0
flannel.1
lo
....
type
# ansible all -m setup
I see ansible_default_ipv4 is virbr0 for node A and eth0 for node B.
Since etcd_machine_address using etcd_interface which default is default_ipv4.interface , it is not problem in my case.

@xialonglee I reviewed  once again all etcd_interface implementation and highly suggest do more serious refactoring then you provide currently.
With your change logic of interface selection starts to be twisted and error-prone --- etcd_interface doesn't mean now "public interface to use for etcd", but "try to use etcd_interface interface, and if it is not available try default interface".
Lets stick with my initial suggestion:

Make etcd_interface empty by default (or unset):

# defaults/main.yml
etcd_interface: ""

In all places that depends on etcd_interface check is etcd_interface is set, and use either etcd_interface or default interface:

# defaults/main.yml
etcd_machine_address: "{{ hostvars[inventory_hostname]['ansible_' + etcd_interface].ipv4.address if etcd_interface else ansible_default_ipv4.address }}"

# etcd/templates/etcd.conf.j2
  {{ hostvars[host]['ansible_hostname'] }}={{ etcd_peer_url_scheme }}://{{ hostvars[host]['ansible_' + etcd_interface].ipv4.address if etcd_interface else hostvars[host].ansible_default_ipv4.address }}:{{ etcd_peer_port }}

@rutsky
You are right, i think i've got your point.
I've updated the codes as your suggestion and i also added some comments in addition, PTAL.

@xialonglee please rebase.

@rutsky
I've updated the codes. Thanks!

@xialonglee still you need to rebase you PR.

@redhat-k8s-bot test please

CentOS repo mirrors related issue, not PR related

/approve

Hm, for some reason the Ci for fedora does not work. Anyway, the RHEL is fine.
/lgtm


python312Packages.packageurl-python: 0.15.6 -> 0.16.0

Automatic update generated by nixpkgs-update tools. This update was made based on information from passthru.updateScript.
meta.description for python312Packages.packageurl-python is: Python parser and builder for package URLs
meta.homepage for python312Packages.packageurl-python is: https://github.com/package-url/packageurl-python
meta.changelog for python312Packages.packageurl-python is: https://github.com/package-url/packageurl-python/blob/v0.16.0/CHANGELOG.rst
Updates performed

Ran passthru.UpdateScript

To inspect upstream changes
Impact
Checks done

built on NixOS
The tests defined in passthru.tests, if any, passed
found 0.16.0 with grep in /nix/store/63l2j6ygkz8xfizlgv5060xjasnr3ksy-python3.12-packageurl-python-0.16.0
found 0.16.0 in filename of file in /nix/store/63l2j6ygkz8xfizlgv5060xjasnr3ksy-python3.12-packageurl-python-0.16.0

Rebuild report (if merged into master) (click to expand)

17 total rebuild path(s)

17 package rebuild(s)

First fifty rebuilds by attrpath

checkov
cve-bin-tool
cyclonedx-python
dep-scan
pip-audit
python311Packages.appthreat-vulnerability-db
python311Packages.cyclonedx-python-lib
python311Packages.packageurl-python
python311Packages.scancode-toolkit
python311Packages.tern
python312Packages.appthreat-vulnerability-db
python312Packages.cyclonedx-python-lib
python312Packages.packageurl-python
python312Packages.scancode-toolkit
python312Packages.tern
sbomnix

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/63l2j6ygkz8xfizlgv5060xjasnr3ksy-python3.12-packageurl-python-0.16.0 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A python312Packages.packageurl-python https://github.com/r-ryantm/nixpkgs/archive/f05b4ed4fc9409dc702ae0141f3bad1d3884a3cf.tar.gz

Or:
nix build github:r-ryantm/nixpkgs/f05b4ed4fc9409dc702ae0141f3bad1d3884a3cf#python312Packages.packageurl-python

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/63l2j6ygkz8xfizlgv5060xjasnr3ksy-python3.12-packageurl-python-0.16.0
ls -la /nix/store/63l2j6ygkz8xfizlgv5060xjasnr3ksy-python3.12-packageurl-python-0.16.0/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
nixpkgs-review result
Generated using nixpkgs-review.
Command: nixpkgs-review

x86_64-linux

:x: 2 packages failed to build:

python312Packages.scancode-toolkit
python312Packages.scancode-toolkit.dist

:white_check_mark: 30 packages built:

checkov
checkov.dist
cve-bin-tool
cve-bin-tool.dist
cyclonedx-python
cyclonedx-python.dist
dep-scan
dep-scan.dist
pip-audit
pip-audit.dist
python311Packages.appthreat-vulnerability-db
python311Packages.appthreat-vulnerability-db.dist
python311Packages.cyclonedx-python-lib
python311Packages.cyclonedx-python-lib.dist
python311Packages.packageurl-python
python311Packages.packageurl-python.dist
python311Packages.scancode-toolkit
python311Packages.scancode-toolkit.dist
python311Packages.tern
python311Packages.tern.dist
python312Packages.appthreat-vulnerability-db
python312Packages.appthreat-vulnerability-db.dist
python312Packages.cyclonedx-python-lib
python312Packages.cyclonedx-python-lib.dist
python312Packages.packageurl-python
python312Packages.packageurl-python.dist
python312Packages.tern
python312Packages.tern.dist
sbomnix
sbomnix.dist

Maintainer pings
cc @armijnhemel for testing.

[!TIP]
As a maintainer, if your package is located under pkgs/by-name/*, you can comment @NixOS/nixpkgs-merge-bot merge to automatically merge this update using the nixpkgs-merge-bot.

Add a :+1: reaction to pull requests you find important.

Result of nixpkgs-review pr 350566 at bc150202 run on x86_64-linux 1

:x: 1 package failed to build:

python312Packages.scancode-toolkit

:white_check_mark: 15 packages built:

checkov
cve-bin-tool
cyclonedx-python
dep-scan
pip-audit
python311Packages.appthreat-vulnerability-db
python311Packages.cyclonedx-python-lib
python311Packages.packageurl-python
python311Packages.scancode-toolkit
python311Packages.tern
python312Packages.appthreat-vulnerability-db
python312Packages.cyclonedx-python-lib
python312Packages.packageurl-python
python312Packages.tern
sbomnix


Correct url for GitHub releases?

var mgr = new UpdateManager("https://github.com/mycompany/myrepo");
UpdateInfo? newVersion = await mgr.CheckForUpdatesAsync(); // 404 error

What is the correct url for github to check for new releases?  I've used the  url as shown above and also ".../releases" however I only get 404.

You need to create a new GithubSource.
Eg. new UpdateManager(new GithubSource(...));


STONEBLD-777 - tekton-ci: update bundle

Switching to new bundle since development of old one was stopped before attempt to migrate to kcp. New bundle is removing dependency on shared secret.

Switching to new bundle since development of old one was stopped before attempt to migrate to kcp. New bundle is removing dependency on shared secret.

:-) yay !

@Michkov I'm not authorized yet to log onto the new CI cluster.
If you are able to log in, can you let us know here if the push job was successful, like the build/unit-test on pull request were.
Thanks.


Nextdns dashborad broken

https://github.com/mtxadmin/ublock/blob/78b3ffa3533c31cd8c02099c0448b84e42045b46/filters/_removeparams#L262
This line prevents Nextdns dashbord from working.

More precisely the request https://api.nextdns.io/profiles/

Made an exclusion, please check

I've checked, everything works perfectly


[Feature Request] Have options to download both R-18/18G or one over other.

I was wondering if there would be an option or confirmation to download R-18G Files alongside the regular R-18 Only Mode like if you were in said mode and were going to download some stuff, the console would ask if you wanted to download both kinds or one over the other.
The R-18 mode only downloads things that are tagged with said mode and not the other variants of said mode.

Currently not possible for member related images, as the filter from Pixiv only allow to supply 1 tag (either R-18 or R-18G).
What I can do is to run 2 query for each tag. Please note that if the images has both tag, it will be processed twice.

Thank you for the informative knowledge. I was wondering this myself. It should not be challenging for people to open up the .ini and change r18mode to True if they wish to get a full catalogue from a member or section. This seems like a low priority goal. I may be wrong and minority. English is not first language after all :)

hmm, I can set it in the config.ini as flag r18Type with value 0 = both R18 and R-18G, 1 = only R18, and 2 = only R18G


CSS Font Error - Showing 24px font

Describe the bug
For some reason, when I use the css class using the clarity css
Steps to reproduce the behavior:

Expected behavior
Font should be smaller - may be 12px or so
A clear and concise description of what you expected to happen.
Versions
App

Angular: 7.0.3
Node: 10
Clarity: 1.1.2

Device:

Type: Windows 10 laptop
OS: Windows
Browser : chrome
Version : 73

Additional notes
Add any other notes about the problem here.

Hi @sandeep540
I can't diagnose what's happening here based on that screenshot alone. Could you reproduce this in one of the stackblitzes we offer?
At a glance, it looks like some styles in your application are overriding the clarity styles. But I can't say for sure.
Thanks!

Sorry for the late reply, here you go
https://stackblitz.com/edit/angular-ivtjoz
https://angular-ivtjoz.stackblitz.io/

You have <html> tags in your app.component.html, which should not be there. Those belong in the index.html file only. Removing those makes the styles correct. Closing as not-an issue, but feel free to update with additional information if I missed something.

Apologies, my bad, it fixed it


batches in progress not showing up

@tnsgmddb brought up this error. Normally when HITs are accepted (before they are submitted) "batches in progress" should progress (see screenshot below). Right now, even though HITs are accepted and being worked on, the batches in progress does not increase. After some workers finish I'll see if "Batches ready for review" increase.

On second look, I'm not sure if this is a problem on our end. I'll update this issue after I figure that out.

Thank you for posting this issue. As a follow-up on our phone meeting yesterday, here is an example of the screenshot for progress bars that we suppose to see on Mturk. Even if a HIT was not taken by anyone, the progress bar should be still up on the page.

What is the difference between batches and HITs? I think that may be why we aren't seeing anything. We are publishing individual HITs and I have a feeling batches are groups of HITs, or something like that.

It's logical there is no progress bar - we are serving an external hit and there is currently no communication with Amazon about the HIT until it is submit.

For the batch progress that reflects submission - how could we assess this if no one has submit yet?

I am pasting Vanessa's email from before.
"We are serving the HIT from an external URL, and we don't send results back to AWS, so you won't see progress until they submit and the hits are approved."
this seems to address Ian's question I believe?

We have those random "answer a question" hits I mentioned a bit ago. They
have been completed and were pending review while the batches pending
review remained 0. That's why I think batches and hits are not the same.
On Thursday, March 24, 2016, Vanessa Sochat<EMAIL_ADDRESS>wrote:

For the batch progress that reflects submission - how could we assess this
if no one has submit yet?
—
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
https://github.com/expfactory/expfactory-docker/issues/85#issuecomment-200962764

--
Best,
Ian

@IanEisenberg , that's correct. A batch is a group of HITs.
As an example statement,
Requesters make a micro-batch that has only 9 slots. This group of 9 slots (9 HITs) is a batch.
When a batch is created on Mturk internally, I should see a progress bar immediately for each batch even if no one has started or submitted the HIT.
But according to @vsoch ,  because you guys are running HIT's externally, I understand that I will not see a progress bar for a batch unless the batch is all complete, So if you assigned 2 slots for one batch, I believe those 2 HITs should be all submitted by two workers. Then I will be able to see a progress bar on Mturk internally.

If a progress bar is just "how many assignments are accepted out of total assignments", expfactory should not interact with it. Mturk should know how many assignments are currently "in progress" based on which workers currently have accepted the HIT. Progress within the HIT is something else, and not related to this "batch" progress.
Again, we have HITs in this account that have nothing to do with experimentfactory, and the batch counters are not showing them. Not sure what's going on, but I don't think it's related to experiment factory.

I don't think this is an expfactory issue. Closing.


*: some picks to release 3.0

What problem does this PR solve?
The failed cherry-pick:

Add Empty region count metrics https://github.com/pingcap/pd/pull/1756
Fix the issue that data race during clone the StoreInfo https://github.com/pingcap/pd/pull/1802

What is changed and how it works?
cherry-pick
pick some fix to release 3.0
Check List
Tests

Unit test

/run-all-tests

/merge

/merge


Blog App: Integration specs for views and fix n+1 problems

In this PR, we ( @Timbar09 and @serengia ) added integration specs for views and fixed n+1 problems.
Changes

Solved the N+1 problem.

Before-N+1 fix image
After-N+1 fix image

Used Capybara to write integration tests for the index and show views of both users and posts.

Thanks for the feedback, @cynthiainga and @tufoinnkuo10.


Validation messages not showing

Problem
I have created a simple Meteor project and added a form. The problem is that validation errors are not showing after submitting.
We are using:

aldeed:autoform,
aldeed:collection2,
communitypackages:autoform-bootstrap4 and
npm package simpl-schema

To Reproduce

Clone simple repository https://github.com/mslobodan/autoform-validation-issue
install dependencies with meteor npm install
start project with meteor command

Expected behavior
If form is not populated and after Submit button is clicked I should see validation error below input fields.
Versions

Meteor version: 2.7.3
Browser: Firefox, Chrome

Hi @mslobodan thank your for submitting an issue. I am checking out your linked repository right now and get back to you afterwards.

@mslobodan the problem is that SimpleSchema removed Meteor support with version 3 and therefore your { tracker: Tracker } has no effect at all, which results in the messages not being shown reactively.
Downgrading to simple schema @1.13.1 solves the issue. However this is a problem now, because I am not sure how we can work this out.

@jankapunkt Thank you for investigating this and for your explanation! 😄

Related:

https://github.com/Meteor-Community-Packages/organization/issues/69
https://forums.meteor.com/t/simple-schema-3/59001


SAKIII-4596 change profile pic on sent messages to receipents picture

https://jira.sakaiproject.org/browse/SAKIII-4596

Squashed and merged


Scaffold drawer can be opened from end drawer

Steps to Reproduce
Open end drawer and try to open other drawer from there by swiping from left to right from edge. iPhone used: 6s.
import 'package:flutter/material.dart';

void main() {
  runApp(
    MyApp(),
  );
}

class MyApp extends StatelessWidget {
  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      title: 'Flutter Demo',
      theme: ThemeData(
        primarySwatch: Colors.blue,
      ),
      home: MyHomePage(),
    );
  }
}

class MyHomePage extends StatefulWidget {
  MyHomePage({Key key}) : super(key: key);

  @override
  _MyHomePageState createState() => _MyHomePageState();
}

class _MyHomePageState extends State<MyHomePage> {
  @override
  void initState() {
    // TODO: implement initState
    super.initState();
  }

  @override
  Widget build(BuildContext context) {
    return Scaffold(
      body: Container(
        color: Colors.green,
        alignment: Alignment.center,
        child: Text('center'),
      ),
      drawer: Container(
        color: Colors.red,
        alignment: Alignment.center,
        child: Text('left'),
      ),
      endDrawer: Container(
        color: Colors.blue,
        alignment: Alignment.center,
        child: Text('right'),
      ),
    );
  }
}

flutter doctor
Doctor summary (to see all details, run flutter doctor -v):
[✓] Flutter (Channel beta, v1.8.3, on Mac OS X 10.14.6 18G87, locale
    en-US)

[✓] Android toolchain - develop for Android devices (Android SDK version
    28.0.3)
[✓] Xcode - develop for iOS and macOS (Xcode 10.3)
[✓] Android Studio (version 3.5)
[!] IntelliJ IDEA Ultimate Edition (version 2018.1.2)
    ✗ Flutter plugin not installed; this adds Flutter specific
      functionality.
    ✗ Dart plugin not installed; this adds Dart specific functionality.
[✓] Connected device (1 available)

! Doctor found issues in 1 category.

Video of this bug.
File from iOS.MOV.zip

Hi @fralways
After testing your code  on (Thanks to @iapicca)
Flutter 1.12.13+hotfix.8 • channel stable • https://github.com/flutter/flutter.git
Framework • revision 0b8abb4724 (2 weeks ago) • 2020-02-11 11:44:36 -0800
Engine • revision e1e6ced81d
Tools • Dart 2.7.0

This issue seems to be resolved
are you still experiencing this issue with the latest version of Flutter?
If so please provide your updated flutter doctor -v and flutter run --verbose and  I will reopen it.
Thank you


Thank you

This plugin is awesome, it really made my day!
God bless you, man! :heart: :heart: :heart:

Glad to be of help!


fix: wrap overflowed server name

Fixes word wrapping for long server names, as it's very noticeable on mobile devices or small screens.
See before/after.
Before:

After:

Also works for long words:

@zefanjajobse Hey, I just wanted to get an update on this PR.


Documentation suggestion

Hello,
First of all, let me say how pleased I am with FastEndpoints. I've been trying it out now for some time (after seeing Nick Chapsas video) and being a newbie when it comes to REST api, I'm really, really pleased with it.
Something that I've been looking for, but been unable to find is a small example of a convenient way of sending binary data from one application to my REST api FastEndpoint. I've tried (using Postman and form-data) to send a binary file, which works fine, but it would be really cool if there was a small tutorial on how to send/receive binary data that does not originate from a file. (There is a binary part of the body that maybe can be used as opposed to the form-data).
King regards
Magnus
BTW: I'm sorry if this is the incorrect form of suggesting this. Please advice if there is an alternative area for posting this question/suggestion.

what is the client you want to use for uploading the binary data?
.net httpclient or something like that?
or web browser fetch client? etc.

Thanks for the quick answer !!  :-)
I apologize for not being more clear. Basically the idea is to write a client application would use the restAPI to send instantiated classes (which obviously would have to be serialized) over the wire to the server which could then would de-serialize the data and execute functions on the re-created class on the server side.
When come to think of it, maybe I should just use a serializer and encode the class to base64 and send it like a member in a normal request type ?

Sounds like RPC to me. Like gRPC?

Thanks for the suggestion nefarius,
I'll just elaborate a little.
I already have Proto.Actor internally for some code which is in turn is gRPC below the surface. I know, totally overkill in this case since if I'm not mistaken more for microservices.
Anyway, I was asked to provide a REST api and I did create that. So far so good, but then the requirement changed and I need to handle binary data as well. Instead of revamping it all to gRPC I thought I could just add one "binary function" to keep the REST api (which is convenient for running small stuff using a web browser) but if the the guy who requested the binary approach would want to run that functionality he would have to write his own application.
I just did some small testing and maybe it is quite sufficient to code the class to json (using Newtonsoft or whatever) and then base64 code that and then receive that data using a regular request dto, process the data on the server and then respond with a response dto to the client side.
Obviously the client and the server would have to share the common object, but that is not a problem.
Of course, doing it all from scratch maybe another approach would have been better (gRPC) but I am where I am now...   My apologies !
King regards
Magnus

just use HttpClient
endpoint and shared dto/object:
public class MySharedObject
{
    public int Id { get; set; }
    public string Name { get; set; }
}

public class MyEndpoint : Endpoint<MySharedObject>
{
    public override void Configure()
    {
        Post("/api/test");
        AllowAnonymous();
    }

    public override async Task HandleAsync(MySharedObject req, CancellationToken ct)
    {
        Console.WriteLine(req.Name);
        await SendAsync("all good " + req.Name);
    }
}

in client application, just do this:
var client = new HttpClient();

await client.PostAsJsonAsync("http://mysite.com/api/test", new MySharedObject { Id = 1, Name = "test" });


Reopen: How to remove the circle when the 3D object is selected?

For some 3D models, when they're selected, There is a gray circle on the bottom. How to hide those circles for sure?

Then call getSelectionVisualizer, and then call

Call getTransformationSystem on your ArFragment (or acquire it from somewhere)

Call getSelectionVisualizer on the transformation system

Call removeSelectionVisual on the selection visualizer, passing in the node you want.

You can also modify the selection visualizer or write your own.

Call getTransformationSystem on your ArFragment (or acquire it from somewhere)
Call getSelectionVisualizer on the transformation system
Call removeSelectionVisual on the selection visualizer, passing in the node you want.

You can also modify the selection visualizer or write your own.

Thanks! Really Helpful. Consider to publish a more detailed documentation of Sceneform?

After following your instructions, the circle did disappear. However, when I use the pinch gesture, the circle shows up again.

@CranberryYam Implement your custom SelectionVisualize, override applySelectionVisual and removeSelectionVisual and leave it blank.

@CranberryYam Implement your custom SelectionVisualize, override applySelectionVisual and removeSelectionVisual and leave it blank.

It works, Thanks!

Everyone, this's the final answer:
class BlanckSelectionVisualizer: SelectionVisualizer {
    override fun applySelectionVisual(var1: BaseTransformableNode) { }
    override fun removeSelectionVisual(var1: BaseTransformableNode) { }
}

system.selectionVisualizer = BlanckSelectionVisualizer()


Fake Vote

Fake vote is not working gray panel is not pop up!

You have to call vote yourself.

yes i know, but after the update i think not working

name appears invisible and shows the original vote.
happened to me a few days ago after the 3/2/20 update.

yes same problem, somebody know what is wrong?

Looks like it was patched.

Remove it from the cheat then ?

he did, check the commits.


TIFF: make it work for 16-bit palette images

Fixes #3259

On the issue #3259, reporters confirm that this patch fixes the bug.


add codecov

@JensWalter CodeCov works now, but I had to fix 4 tests. Can you have a look at them?
When using any pointer size different from "None" the test segFaults.
If everything is ok, please merge


cannot add work machine join into cluster

Describe your issue here
i have 3 machine (etcd controll work).now i need to add a work to the cluster,and copy the ssh cmd,and run it in the work machine.but the rancher cluster have not any response.so why ?

Useful
Info

Versions
Rancher v2.3.2 UI: v2.3.22

Route
authenticated.cluster.edit

Can you supply more info on your setup (basically copy paste from this and fill in: https://raw.githubusercontent.com/rancher/rancher/master/.github/ISSUE_TEMPLATE.md)


chore(ci): merge test runs

Replaces #6146
Definition of Ready

[ ] I am happy with the code
[ ] Short description of the feature/issue is added in the pr description
[ ] PR is linked to the corresponding user story
[ ] Acceptance criteria are met
[ ] All open todos and follow ups are defined in a new ticket and justified
[ ] Deviations from the acceptance criteria and design are agreed with the PO and documented.
[ ] No debug or dead code
[ ] My code has no repetitions
[ ] Critical parts are tested automatically
[ ] Where possible E2E tests are implemented
[ ] Documentation/examples are up-to-date
[ ] All non-functional requirements are met
[ ] Functionality of the acceptance criteria is checked manually on the dev system.

@stebenz do you have an idea why TestServer_SAMLACS fails?

@stebenz do you have an idea why TestServer_SAMLACS fails?

Yes, there was a fix by @livio-a  to correct the behavior of the SAML SP if you configure a specific binding, and as the error states: It should be a redirect but it receives a POST.
I'm surprised that this test didn't fail before, but you only have to change the IDP provider configuration, and then it should work again.

@stebenz do you have an idea why TestServer_SAMLACS fails?

Yes, there was a fix by @livio-a to correct the behavior of the SAML SP if you configure a specific binding, and as the error states: It should be a redirect but it receives a POST. I'm surprised that this test didn't fail before, but you only have to change the IDP provider configuration, and then it should work again.

I'm not sure what I have to do now. The tests obviously only fail on this branch, not on main. Which fix are you referring to?

@eliobischof Seems like the tests were excluded before due to the list of paths.
I tried to add the bindings to the created providers and will take care of it if it still not works.

@livio-a thanks for reviewing and updating the branch protection


[BUG] Text is positioned off-center

When I have multiple blocks of the reading test, the text is sometimes positioned off-center. The bug only occurs when I use the attached ex.txt as the reading corpus, and only for block #3 or later.

dear mj
Thx.
can you provide a spreadsheet for the experiment?
Best
Denis
On Oct 4, 2023 at 3:44:58 PM, Minjung Kim @.***> wrote:

When I have multiple blocks of the reading test, the text is sometimes
positioned off-center. The bug only occurs when I use the attached ex.txt
https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_EasyEyes_threshold_files_12807545_ex.txt&d=DwMCaQ&c=slrrB7dE8n7gBJbeO0g-IQ&r=7X-NKAXavKeKD9gIvst_RX6MqmtP6wERm4LVB5ZkcI4&m=yl6yfxQOTm7hrQye89JdwucrLN2wTnPMLvFM5RPc9r8CJSShNiLki6rt-V2qbPwA&s=r080ckWKLzYx5Bq-zQCx-wSsVk0V1AA-1HuTLC5u16k&e=
as the reading corpus, and only for block #3
https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_EasyEyes_threshold_issues_3&d=DwMCaQ&c=slrrB7dE8n7gBJbeO0g-IQ&r=7X-NKAXavKeKD9gIvst_RX6MqmtP6wERm4LVB5ZkcI4&m=yl6yfxQOTm7hrQye89JdwucrLN2wTnPMLvFM5RPc9r8CJSShNiLki6rt-V2qbPwA&s=R12mrj9GSbX1bL0rHjQJDRnYI3CShR0Wk1mjkhU5gb4&e=
or later.
—
Reply to this email directly, view it on GitHub
https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_EasyEyes_threshold_issues_77&d=DwMCaQ&c=slrrB7dE8n7gBJbeO0g-IQ&r=7X-NKAXavKeKD9gIvst_RX6MqmtP6wERm4LVB5ZkcI4&m=yl6yfxQOTm7hrQye89JdwucrLN2wTnPMLvFM5RPc9r8CJSShNiLki6rt-V2qbPwA&s=zcIkGwerzrRxcEEeTjykh6uhEtLmznRZN2yJinIoJSY&e=,
or unsubscribe
https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_notifications_unsubscribe-2Dauth_ADKWX62Q5YRRT3TWPUKSHZDX5W4DVAVCNFSM6AAAAAA5TESBBCVHI2DSMVQWIX3LMV43ASLTON2WKOZRHEZDMOBWG42DGMY&d=DwMCaQ&c=slrrB7dE8n7gBJbeO0g-IQ&r=7X-NKAXavKeKD9gIvst_RX6MqmtP6wERm4LVB5ZkcI4&m=yl6yfxQOTm7hrQye89JdwucrLN2wTnPMLvFM5RPc9r8CJSShNiLki6rt-V2qbPwA&s=K9WIhNRLVOY594FYhRm-XQSrSA8dU4hGFVDylRLW_Ek&e=
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>

Sure! Here it is.
fontsizeTest.csv

https://trello.com/c/9fSnql0G


Organize indiviual regression test files into functions

Is your feature request related to a problem?
When attempting to debug a regression failure, it is often helpful to comment out the
non-failing sections of an individual test .py file.
This would be much easier to do if every test was organized into separate functions.
Then all one has to do is comment out the call to the succeeding functions instead of whole
blocks of code:
Take zipwrapper for instance:
#
# Ok, before we start processing any compressed files, set
# ZipWrapper default read options
#
OpenMDServer("localhost")
readOptions=GetDefaultFileOpenOptions("ZipWrapper")
readOptions["Max. # decompressed files"] = 10
SetDefaultFileOpenOptions("ZipWrapper", readOptions)

# Test 36 block STL (only 10 files decompressed at any one time)
OpenDatabase(data_path("zipwrapper_test_data/multi_ucd.visit"))

AddPlot("Pseudocolor","mesh_quality/condition")
DrawPlots()
v=GetView3D()
v.viewNormal=(-0.5, 0.296198, 0.813798)
SetView3D(v)
Test("ZipWrapper_01")
DeleteAllPlots()
CloseDatabase(data_path("zipwrapper_test_data/multi_ucd.visit"))

OpenDatabase(data_path("zipwrapper_test_data/histz_*.silo database"), 3)

AddPlot("Pseudocolor","d_dup")
DrawPlots()
v=GetView3D()
v.viewNormal=(-0.5, 0.296198, 0.813798)
SetView3D(v)
Test("ZipWrapper_02")
TimeSliderNextState()
TimeSliderNextState()
Test("ZipWrapper_03")
TimeSliderSetState(0)
Test("ZipWrapper_04")
TimeSliderNextState()
Test("ZipWrapper_05")
DeleteAllPlots()

AddPlot("FilledBoundary","mat1")
DrawPlots()
silr=SILRestriction()
silr.TurnOffSet(silr.SetsInCategory("mat1")[0])
SetPlotSILRestriction(silr)
Test("ZipWrapper_06")
DeleteAllPlots()

OpenDatabase(data_path("zipwrapper_test_data/sphere.2d.hdf5.gz"))

AddPlot("FilledBoundary","materials")
DrawPlots()
Test("ZipWrapper_07")

Exit()

could be transformed to this:
#
# Ok, before we start processing any compressed files, set
# ZipWrapper default read options
#
OpenMDServer("localhost")
readOptions=GetDefaultFileOpenOptions("ZipWrapper")
readOptions["Max. # decompressed files"] = 10
SetDefaultFileOpenOptions("ZipWrapper", readOptions)

def Test1():
    # Test 36 block STL (only 10 files decompressed at any one time)
    OpenDatabase(data_path("zipwrapper_test_data/multi_ucd.visit"))

    AddPlot("Pseudocolor","mesh_quality/condition")
    DrawPlots()
    v=GetView3D()
    v.viewNormal=(-0.5, 0.296198, 0.813798)
    SetView3D(v)
    Test("ZipWrapper_01")
    DeleteAllPlots()
    CloseDatabase(data_path("zipwrapper_test_data/multi_ucd.visit"))

def Test2():
    OpenDatabase(data_path("zipwrapper_test_data/histz_*.silo database"), 3)

    AddPlot("Pseudocolor","d_dup")
    DrawPlots()
    v=GetView3D()
    v.viewNormal=(-0.5, 0.296198, 0.813798)
    SetView3D(v)
    Test("ZipWrapper_02")
    TimeSliderNextState()
    TimeSliderNextState()
    Test("ZipWrapper_03")
    TimeSliderSetState(0)
    Test("ZipWrapper_04")
    TimeSliderNextState()
    Test("ZipWrapper_05")
    DeleteAllPlots()

    AddPlot("FilledBoundary","mat1")
    DrawPlots()
    silr=SILRestriction()
    silr.TurnOffSet(silr.SetsInCategory("mat1")[0])
    SetPlotSILRestriction(silr)
    Test("ZipWrapper_06")
    DeleteAllPlots()

def Test3():
    OpenDatabase(data_path("zipwrapper_test_data/sphere.2d.hdf5.gz"))

    AddPlot("FilledBoundary","materials")
    DrawPlots()
    Test("ZipWrapper_07")
    DeleteAllPlots()

def main():
    Test1()
    Test2()
    Test3()

main()
Exit()

Describe the solution you'd like.
Easily comment-out-able (is that a word?) sections of regression tests.

I agree that what you propose is a better design.
That said, I think there is a simple Python trick for this using """ multi-line strings
Code I want to disable
foo = """
#
# Ok, before we start processing any compressed files, set
# ZipWrapper default read options
#
OpenMDServer("localhost")
readOptions=GetDefaultFileOpenOptions("ZipWrapper")
readOptions["Max. # decompressed files"] = 10
SetDefaultFileOpenOptions("ZipWrapper", readOptions)

# Test 36 block STL (only 10 files decompressed at any one time)
OpenDatabase(data_path("zipwrapper_test_data/multi_ucd.visit"))

AddPlot("Pseudocolor","mesh_quality/condition")
DrawPlots()
v=GetView3D()
v.viewNormal=(-0.5, 0.296198, 0.813798)
SetView3D(v)
Test("ZipWrapper_01")
DeleteAllPlots()
CloseDatabase(data_path("zipwrapper_test_data/multi_ucd.visit"))

OpenDatabase(data_path("zipwrapper_test_data/histz_*.silo database"), 3)

Code Disabled
#
# Ok, before we start processing any compressed files, set
# ZipWrapper default read options
#
OpenMDServer("localhost")
readOptions=GetDefaultFileOpenOptions("ZipWrapper")
readOptions["Max. # decompressed files"] = 10
SetDefaultFileOpenOptions("ZipWrapper", readOptions)

# Test 36 block STL (only 10 files decompressed at any one time)
OpenDatabase(data_path("zipwrapper_test_data/multi_ucd.visit"))

AddPlot("Pseudocolor","mesh_quality/condition")
DrawPlots()
v=GetView3D()
v.viewNormal=(-0.5, 0.296198, 0.813798)
SetView3D(v)
Test("ZipWrapper_01")
DeleteAllPlots()
CloseDatabase(data_path("zipwrapper_test_data/multi_ucd.visit"))

OpenDatabase(data_path("zipwrapper_test_data/histz_*.silo database"), 3)
"""

Whoops...the original comment had a typo. I've updated it so go to the GitHub issue and don't look at the email.

You can comment out easily, but the challenge is that  on-isolated tests can share setup or some progression of settings. So the later parts might depend prior parts executing.   With how state propagates in VisIt, I think we are susceptible this. I think underpinning this should also be a goal to have the tests stand alone when possible.

@cyrush, I agree, and have come across the interdependence even in a test with individual functions. Commenting out a single test within a file can change results of tests following.

My """ hack was responding to the need to insert # on every line. You don't need to do that to whack out a section of code you wanna disable.

a goal to have the tests stand alone when possible.

You mean each call to TestXXX() in its own .py file? Or, each call to TestXXX() preceded by all the state setup (e.g. VisIt CLI calls including database open, setting time state, etc.) necessary to do it? I think either of those would cause an already long running test suite to run much longer and they would not adequately reflect the way real users use VisIt either.

Each test in its on py file would be overkill.
You can have common setup then have independent tests.  If things are tangled, those have to be larger tests, you but you can refactor to more independent chunks over time.  If all your tests use the same db, there is no general reason for a full close and reopen. But you should do things like delete plots or push/pop state if you are changing the state in a way that could undermine other tests.

I think all of that makes a lot of sense. And, I am probably the biggest one-long-stream-of-python-consciousness coder among us. I've never mastered OO python (or maybe even OO C++ for that matter).
That said, I do wanna caution that taking an approach where we return VisIt to some well defined state between each test is less likely to reveal bugs that real usage could encounter. Users will delete, hide, overwrite, transform from view, SIL-select away or otherwise eliminate a plot from view during normal usage and if in our testing we only ever delete, then I think we can wind up missing funky behavior.
OTOH, now that I find myself writing this, maybe its sufficient to ensure we have tests that independently demonstrates deleting works, hiding works, overwriting works, transforming out of view (I am being creative now) works, SIL selecting away works to effecitvely not show a plot and then the remainder of our test suite only needs to delete to return to base state before trying something else.
I dunno, I sill think there are potential real use cases we'd wind up missing.

We should add documentation to our developer documentation that this is our practice for adding tests.

@biagas if you prefer and wouldn't mind explaining basically, at a high level, how best to think about decomposing a .py file into different functions for different sets of tests, even if just chain of consciousness here in this issue conversation, I can try to integrate into docs.

First off, need to keep global settings global, and same for local.  I'm speaking global for all tests in a single .py file. Take color table change for instance: Is the purpose to test the color table change (then perhaps it should be local) or is it a change to make the resultant image files more interesting or point out features (then perhaps its a global setting)
The most common way to create sections I suppose is on OpenDatabase/CloseDatabase boundaries.
Or  places where 'DeleteAllPlots' 'DeleteWindow' types of calls are made, that seem to signal an 'ending' of some sort.
For DB plugin tests, there are multiple ways to go: individual files in their own functions, with multiple plot/operator combos.
This makes sense for plugins that actually accept multiple formats /  have multiple readers: (VTK, netcdf).
Honestly, when I am writing a test, I can think in terms of 'sections'.  I want to test 'a,b,c' here. Next I want to test 'd and e'.
If there isn't any connection between the two, they should be in different functions. ( a functional programmer at heart, despite my years in OO-land)
@markcmiller86 I know you are concerned about testing work-flow and the connectedness of operations within VisIt as much as individual functionality.  As such, there is room for monolithic .py test files too.
There are many ways to crack this egg.


Update interactive.jl notebook for new ClimateMARGO version

(We currently use 0.2.2)

Just noting that I successfully ported ebm.jl to 0.3.2 (most recent) and there didn't seem to be any breaking changes!


feat: replace custom C code with govips

We initially wrote our own C code because our benchmarking showed govips used too much memory but now it seems to be the opposite. Their library is also better than our custom code and it should fix #194 and #180
Test needs to pass which we don't because current implementation isn't 100% ready.

Thanks for having kept this issue in mind !


network net_test not found

When i keyboard the command "./monitordocker.sh net_test". I
The teminal stream a error "docker: Error response from daemon: network net_test not found.
curl: (7) Failed to connect to <IP_ADDRESS> port 8000 after 0 ms: Connection refused".
AND The network proxy is off .
Vesion:Ubantu

The fabric documentation shows the command as monitordocker.sh fabric_test so I would try that, as the message states net_test not found


3D support

Thank you for the tool, I am interested in trying it out.
Is it possible to run the algorithm on 3D data such as the 7 z-levels a Merscope outputs?
Or would I have to run it on every z-level separetly and then merge somehow?

There is code for 3D but havent released it. I would say it is in pre-alpha stage, it has been run on a couple of dataset internally here at UCL.
I can do a release for you. How urgent is this, can you wait till the weekend please? Btw, do you have single cell data (or some other reference data...)

Thank you so much.
It is  not urgent at all.
I am just interested in comparing cellpose vs cellpose + baysor vs cellpose + pciseq performance.
I will just subscribe to this repo and you make a release when you are ready :)
Yes, I have single-cell data of a similiar tissue.

ok, cool, I think  I will have some time free over the weekend and do a built for you.

Hi, havent forgotten that, almost there. Have to double check a few things....

Thanks, I appreciate it

Hi!
Sorry, i know I am late. I also hope this is not going to be a very bumpy road.
You will need to install redis and libvips (optionally). Redis is a in-memory database, are you on windows or Linux? For Linux do:
sudo apt-get install -y redis-server redis-tools
and then start the service:
sudo service redis-server start
For windows, Memurai is the closest thing to redis. Download memurai from here or get it straight from there. Once installed the service should have started running, but If you need to do it manually open a command window and do:
memurai.exe --service-start
I am attaching a notebook which I think you will find helpful. Links to the data for the notebook below
masks
ssingle cell data
spots
python wheel
I would say have a look at the main notebook at the master branch to understand the main things about pciSeq and then move to the one above.
Hope that helps, let me know if you have any problems

I am excited to give it a shot. I am working on a Linux HPC. Let's see if I can get redis to run without root, otherwise I will setup a container.
I think something might have gone wrong with the notebook, the link leads to https://github.com/acycliq/pciSeq/issues/url

I actually have a question about that.
The pipeline I am currently using segments my 7 image stacks separately as 2D and then fuses polygons across Z-Axis.
Vizgen recommends that, as Cellpose 3D segmentation tends to struggle with the lower resolution Z-Axis.
As such I have 2D masks for the different levels, 3D Polygons and and assigned cell id +XYZ coordinates for every transcript.
Can I run pciSeq in 3D mode for this or would I need to ger 3D masks first?

Another comment, I suspect your XYZ coords are in micron then. I work with pixels, but I dont think units matter in pciSeq. Whether xyz are in micron or pixels you should get the same results.
Units will matter is 2d pciSeq and only if you want to have a background image in the 2d viewer. Otherwise the image will not be aligned with the spots. But you dont care about that

Ok, I probably misunderstood something.
I guess the important part is, I need to supply a list matrices with length of my z-axis.
Coordinates without Cell should have value 0, and coordinates within the same cell should have the same integer value
I have both microns and pixel values, I will supply XYZ in same unit.

I am now trying with your example data.
I receive the following error:

Error message
[2023-06-28 20:18:08] INFO    (app.py:226)  save_data is set to True
[2023-06-28 20:18:08] INFO    (app.py:226)  launch_diagnostics is set to True
[2023-06-28 20:18:08] INFO    (app.py:226)  launch_viewer is set to False
[2023-06-28 20:18:08] INFO    (app.py:226)  Inefficiency is set to 0.2
[2023-06-28 20:18:08] INFO    (app.py:226)  MisreadDensity is set to 1e-05
[2023-06-28 20:18:08] INFO    (app.py:226)  nu is set to 30
[2023-06-28 20:18:08] INFO    (app.py:226)  from_plane_num is set to 18
[2023-06-28 20:18:08] INFO    (app.py:226)  to_plane_num is set to 43
[2023-06-28 20:18:08] INFO    (app.py:226)  is_3D is set to True
[2023-06-28 20:18:08] INFO    (app.py:226)  nNeighbors is set to 6
[2023-06-28 20:18:08] INFO    (app.py:226)  CellCallTolerance is set to 0.02
[2023-06-28 20:18:08] INFO    (app.py:274) check_redis_server
[2023-06-28 20:18:08] INFO    (utils.py: 67)  enabling keyspace events... OK
[2023-06-28 20:18:08] INFO    (app.py:122) Launching the diagnostics dashboard
[2023-06-28 20:18:08] INFO    (app.py:126)  Preprocessing data
[2023-06-28 20:18:08] INFO    (spot_labels.py:138)  Truncating masks and spots. Keeping those between frame 18 and 43 only
/work/rwth1209/enviroments/pciseq/bin/python: No module named streamlit
[2023-06-28 20:18:23] INFO    (spot_labels.py:127)  Found 3136 cells that exist on just one single frame. Those cells have been removed from 26 frames.
[2023-06-28 20:18:23] INFO    (spot_labels.py: 74)  Labels in segmentation array are not a sequence of integers without gaps between them. Relabelling...
[2023-06-28 20:19:01] INFO    (spot_labels.py:196)  Number of spots passed-in: 255058
[2023-06-28 20:19:01] INFO    (spot_labels.py:197)  Number of segmented cells: 5712
[2023-06-28 20:19:01] INFO    (spot_labels.py:198)  Segmentation array implies that image has width: 5905px and height: 5882px
[2023-06-28 20:19:31] INFO    (utils.py: 67)  enabling keyspace events... OK
[2023-06-28 20:19:32] INFO    (datatypes.py:600)  Single cell data passed-in have 27998 genes and 5712 cells
[2023-06-28 20:19:32] INFO    (datatypes.py:602)  Single cell data: Keeping counts for the gene panel of 73 only
[2023-06-28 20:19:32] INFO    (datatypes.py:614)  Single cell data: Grouping gene counts by cell type. Aggregating function is the mean.
[2023-06-28 20:19:32] INFO    (datatypes.py:616)  Grouped single cell data have 73 genes and 71 cell types
[2023-06-28 20:19:32] INFO    (app.py:160)  Start cell typing

RecursionError                            Traceback (most recent call last)
Cell In[21], line 1
----> 1 cellData, geneData = pciSeq.fit(spots=_iss_spots_3D, coo=_coo_3D, scRNAseq=_scRNAseq, opts=opts_3D)

File /work/rwth1209/enviroments/pciseq/lib/python3.11/site-packages/pciSeq/app.py:130, in fit(*args, **kwargs)
    127 _cells, cellBoundaries, _spots, removed_cells = stage_data(spots, coo, cfg)
    129 # 5. cell typing
--> 130 cellData, geneData, varBayes = cell_type(_cells, _spots, scRNAseq, cfg)
    132 # 6. save to the filesystem
    133 if (cfg['save_data'] and varBayes.has_converged) or cfg['launch_viewer']:

File /work/rwth1209/enviroments/pciseq/lib/python3.11/site-packages/pciSeq/app.py:161, in cell_type(_cells, _spots, scRNAseq, ini)
    158 varBayes = VarBayes(_cells, _spots, scRNAseq, ini)
    160 logger.info(' Start cell typing')
--> 161 cellData, geneData = varBayes.run()
    162 return cellData, geneData, varBayes

File /work/rwth1209/enviroments/pciseq/lib/python3.11/site-packages/pciSeq/src/cell_call/main.py:60, in VarBayes.run(self)
     57 gene_df = None
     58 max_iter = self.config['max_iter']
---> 60 self.initialise()
     61 for i in range(max_iter):
     62     self.iter_num = i

File /work/rwth1209/enviroments/pciseq/lib/python3.11/site-packages/pciSeq/src/cell_call/main.py:50, in VarBayes.initialise(self)
     48 self.genes.init_eta(1, 1 / self.config['Inefficiency'])
     49 self.spots.parent_cell_id, _ = self.spots.cells_nearby(self.cells)
---> 50 self.spots.parent_cell_prob = self.spots.ini_cellProb(self.spots.parent_cell_id, self.config)
     51 self.spots.gamma_bar = np.ones([self.nC, self.nG, self.nK]).astype(self.config['dtype'])

File /work/rwth1209/enviroments/pciseq/lib/python3.11/site-packages/pciSeq/src/cell_call/datatypes.py:354, in Spots.ini_cellProb(self, neighbors, cfg)
    350 SpotInCell = self.data.label
    351 # assert (np.all(SpotInCell.index == neighbors.index))
    352
    353 # sanity check (this actually needs to be rewritten)
--> 354 mask = np.greater(SpotInCell, 0, where=~np.isnan(SpotInCell))
    355 sanity_check = neighbors[mask, 0] + 1 == SpotInCell[mask]
    356 assert ~any(sanity_check), "a spot is in a cell not closest neighbor!"

File /work/rwth1209/enviroments/pciseq/lib/python3.11/site-packages/pandas/core/generic.py:2016, in NDFrame.__array_ufunc__(self, ufunc, method, *inputs, **kwargs)
   2012 @final
   2013 def __array_ufunc__(
   2014     self, ufunc: np.ufunc, method: str, *inputs: Any, **kwargs: Any
   2015 ):
-> 2016     return arraylike.array_ufunc(self, ufunc, method, *inputs, **kwargs)

File /work/rwth1209/enviroments/pciseq/lib/python3.11/site-packages/pandas/core/arraylike.py:396, in array_ufunc(self, ufunc, method, *inputs, **kwargs)
    393 elif self.ndim == 1:
    394     # ufunc(series, ...)
    395     inputs = tuple(extract_array(x, extract_numpy=True) for x in inputs)
--> 396     result = getattr(ufunc, method)(*inputs, **kwargs)
    397 else:
    398     # ufunc(dataframe)
    399     if method == "__call__" and not kwargs:
    400         # for np.(..) calls
    401         # kwargs cannot necessarily be handled block-by-block, so only
    402         # take this path if there are no kwargs

File /work/rwth1209/enviroments/pciseq/lib/python3.11/site-packages/pandas/core/generic.py:2016, in NDFrame.__array_ufunc__(self, ufunc, method, *inputs, **kwargs)
   2012 @final
   2013 def __array_ufunc__(
   2014     self, ufunc: np.ufunc, method: str, *inputs: Any, **kwargs: Any
   2015 ):
-> 2016     return arraylike.array_ufunc(self, ufunc, method, *inputs, **kwargs)

File /work/rwth1209/enviroments/pciseq/lib/python3.11/site-packages/pandas/core/arraylike.py:396, in array_ufunc(self, ufunc, method, *inputs, **kwargs)
    393 elif self.ndim == 1:
    394     # ufunc(series, ...)
    395     inputs = tuple(extract_array(x, extract_numpy=True) for x in inputs)
--> 396     result = getattr(ufunc, method)(*inputs, **kwargs)
    397 else:
    398     # ufunc(dataframe)
    399     if method == "__call__" and not kwargs:
    400         # for np.(..) calls
    401         # kwargs cannot necessarily be handled block-by-block, so only
    402         # take this path if there are no kwargs

    [... skipping similar frames: NDFrame.__array_ufunc__ at line 2016 (985 times), array_ufunc at line 396 (984 times)]

File /work/rwth1209/enviroments/pciseq/lib/python3.11/site-packages/pandas/core/arraylike.py:396, in array_ufunc(self, ufunc, method, *inputs, **kwargs)
    393 elif self.ndim == 1:
    394     # ufunc(series, ...)
    395     inputs = tuple(extract_array(x, extract_numpy=True) for x in inputs)
--> 396     result = getattr(ufunc, method)(*inputs, **kwargs)
    397 else:
    398     # ufunc(dataframe)
    399     if method == "__call__" and not kwargs:
    400         # for np.(..) calls
    401         # kwargs cannot necessarily be handled block-by-block, so only
    402         # take this path if there are no kwargs

File /work/rwth1209/enviroments/pciseq/lib/python3.11/site-packages/pandas/core/generic.py:2016, in NDFrame.__array_ufunc__(self, ufunc, method, *inputs, **kwargs)
   2012 @final
   2013 def __array_ufunc__(
   2014     self, ufunc: np.ufunc, method: str, *inputs: Any, **kwargs: Any
   2015 ):
-> 2016     return arraylike.array_ufunc(self, ufunc, method, *inputs, **kwargs)

File /work/rwth1209/enviroments/pciseq/lib/python3.11/site-packages/pandas/core/arraylike.py:395, in array_ufunc(self, ufunc, method, *inputs, **kwargs)
    392     result = getattr(ufunc, method)(*inputs, **kwargs)
    393 elif self.ndim == 1:
    394     # ufunc(series, ...)
--> 395     inputs = tuple(extract_array(x, extract_numpy=True) for x in inputs)
    396     result = getattr(ufunc, method)(*inputs, **kwargs)
    397 else:
    398     # ufunc(dataframe)

File /work/rwth1209/enviroments/pciseq/lib/python3.11/site-packages/pandas/core/arraylike.py:395, in (.0)
    392     result = getattr(ufunc, method)(*inputs, **kwargs)
    393 elif self.ndim == 1:
    394     # ufunc(series, ...)
--> 395     inputs = tuple(extract_array(x, extract_numpy=True) for x in inputs)
    396     result = getattr(ufunc, method)(*inputs, **kwargs)
    397 else:
    398     # ufunc(dataframe)

File /work/rwth1209/enviroments/pciseq/lib/python3.11/site-packages/pandas/core/construction.py:441, in extract_array(obj, extract_numpy, extract_range)
    396 def extract_array(
    397     obj: T, extract_numpy: bool = False, extract_range: bool = False
    398 ) -> T | ArrayLike:
    399     """
    400     Extract the ndarray or ExtensionArray from a Series or Index.
    401
   (...)
    439     array([1, 2, 3])
    440     """
--> 441     if isinstance(obj, (ABCIndex, ABCSeries)):
    442         if isinstance(obj, ABCRangeIndex):
    443             if extract_range:

File /work/rwth1209/enviroments/pciseq/lib/python3.11/site-packages/pandas/core/dtypes/generic.py:44, in create_pandas_abc_type.._instancecheck(cls, inst)
     42 @classmethod  # type: ignore[misc]
     43 def _instancecheck(cls, inst) -> bool:
---> 44     return _check(inst) and not isinstance(inst, type)

File /work/rwth1209/enviroments/pciseq/lib/python3.11/site-packages/pandas/core/dtypes/generic.py:38, in create_pandas_abc_type.._check(inst)
     37 def _check(inst) -> bool:
---> 38     return getattr(inst, attr, "_typ") in comp

RecursionError: maximum recursion depth exceeded in comparison

That is really strange, I have run this very same code lots of times. Must have been a version issue. Can you tell me what version you have for pandas and numpy please?

Name: numpy
Version: 1.25.0
Name: pandas
Version: 2.0.2

ok, let me make an env and see if I can replicate it. I will get back to you

I am not sure what is happening, it is definitely related to the version (numpy in particular I think). I have removed the offending lines, they were redundant anyway.
Can you use this version: 0.0.52.dev1.0.1_3d please. I have tested it with numpy '1.25.0', pandas '2.0.2' and python 3.11

That did the trick, thank you.

not a problem. Let me know if got any other issues

Ah with regards to an earlier reply of yours, since you will supply XYZ in the same units, then set anisotropy: 1.0 in the opts dict in pciSeq.fit()


Revert "[SPARK-9154] [SQL] codegen StringFormat"

This reverts commit 7f072c3d5ec50c65d76bd9f28fac124fce96a89e.
Revert #7546

Merged build triggered.

Merged build started.

Can I reopen the last PR to fix the issue or do I have to create a new one, because the old one got merged?

I think you might be able to reopen.

Test build #37969 has started for   PR 7570 at commit ed2c32a.

Test build #37969 has finished for   PR 7570 at commit ed2c32a.

This patch passes all tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
    case class Data(topic: Vector, index: Int)
    case class Data(globalTopicTotals: Vector)
    case class VertexData(id: Long, topicWeights: Vector)
    case class EdgeData(srcId: Long, dstId: Long, tokenCounts: Double)
case class NaNvl(left: Expression, right: Expression)

Merged build finished. Test PASSed.


Use netlink instead of shelling out to weave ps

The proxy currently invokes weave ps to rewrite docker inspect network settings; this PR retrieves the IPs from the weave interface directly with netlink.
Partially addresses #1940.

Decided with @rade to include porting weave ps itself to use netlink via weaveutil in this PR -> assigning to myself.

It is possible for a container to have more than one weave interface; only one of them from non-plugin operations (called "ethwe"), but there can be others added via docker network connect.

We should use this in scope, where we shell out to weave ps.

@bboreham am I right in thinking that prior to this PR, if you have multiple weave interfaces in a container you'll get output something like this?
<mycontainer> <iface1mac> <iface2mac> <iface1ip> <iface2ip>

This PR will make the output look like this instead, which is better IMO:
<mycontainer> <iface1mac> <iface1ip>
<mycontainer> <iface2mac> <iface2ip>

Thoughts?

I guess that's better. We didn't document the previous behaviour, or know how anyone would use it.

I guess that's better

The existing scheme is ambiguous if an interface has more than one IP, so I'd call it a definite improvement.

This is now ready for review. Note that I consider the placement of the shared functions in common to be a temporary arrangement; these should live in (a) more focused package(s), we'll have a clearer idea what they should look like as #1940 and #307 progress.

We should use this in scope, where we shell out to weave ps.

You might want to wait until the code settles down a bit - see my previous comment - perhaps create an issue in weaveworks/scope to track. You'd prefer this to a REST API to retrieve the info you need?

Comments addressed; will squash when you're ready to merge.

LGTM

Squashified.


CLOUD-576 separate swarm orcestrator

@martonsereg please review this.
only @martonsereg allow to merge this

Jenkins build finished, all tests passed.
Refer to this link for build results: http://ci.sequenceiq.com/job/cloudbreak-pull-request/1108/


Add proper metadata to models

Currently, many of the fields in model metadata are not filled.
These should either be specified manually or we should find ways to derive them (from HuggingFace Hub for example.)

We're also missing Metadata objects completely for some models (all-MiniLM-L12-v2 for instance). Or some of them have no matching revision in the results.

We're also missing Metadata objects completely for some models (all-MiniLM-L12-v2 for instance). Or some of them have no matching revision in the results.

Might be worth changing the default revision to the one in the results.

For some of the model configs such as n_parameters, embed_dim, and max_tokens, a script can be created to get those info from HF hub like how we do it in the leaderboard code.

We're also missing links

What do you mean here?

We're also missing links

On the older leaderboard you could click on the models and it would lead you to their home page. We don't have links in the ModelMeta object right now.

For some of the model configs such as n_parameters, embed_dim, and max_tokens, a script can be created to get those info from HF hub like how we do it in the leaderboard code.

I looked into this earlier, but it's not my preferred solution. A couple of reasons:

We  would rely on HuggingFace Hub's interfaces and implementation.
Consequently, it would be a piece of code that has to be written and maintained.
It would not work for models that are not on HuggingFace Hub
It would be awkward to work with models that are on the hub, but are not open access (like Llama).

I would prefer just writing these properties in by hand as:

We (the team) would only have to do this once for the models we have.
I think it would be relatively easy for people submitting new models as PRs to have to fill in this information.

I would love to hear others' thoughts tho, this is a slight preference, not a strong one.

I believe this issue is resolved will close it feel free to reopen


I can't run or compile my first Flutter app under Android Studio

Hi all.
I just installed FLUTTER with a new Android simulator on the Android Studio IDE. BUT When I'm trying to run FLUTTER App (compile it) with android studio Simulator, I receive these following errors:

FAILURE: Build failed with an exception.

What went wrong:
A problem occurred configuring root project 'android'.

Could not resolve all artifacts for configuration ':classpath'.
Could not resolve commons-io:commons-io:2.4.
Required by:
project : > com.android.tools.build:gradle:3.5.0 > androidx.databinding:databinding-compiler-common:3.5.0
Could not resolve commons-io:commons-io:2.4.
Could not parse POM https://jcenter.bintray.com/commons-io/commons-io/2.4/commons-io-2.4.pom
Could not resolve org.apache.commons:commons-parent:25.
Skipped due to earlier error
Could not resolve org.jetbrains.kotlin:kotlin-stdlib-jdk7:1.3.41.
Required by:
project : > com.android.tools.build:gradle:3.5.0 > org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.3.41
Skipped due to earlier error
Could not resolve net.sf.proguard:proguard-base:6.0.3.
Required by:
project : > com.android.tools.build:gradle:3.5.0 > net.sf.proguard:proguard-gradle:6.0.3
Skipped due to earlier error
Could not resolve com.google.auto.value:auto-value:1.5.2.
Required by:
project : > com.android.tools.build:gradle:3.5.0 > com.android.tools.build:bundletool:0.9.0
Skipped due to earlier error
Could not resolve com.google.errorprone:error_prone_annotations:2.3.1.
Required by:
project : > com.android.tools.build:gradle:3.5.0 > com.android.tools.build:bundletool:0.9.0
Skipped due to earlier error
Could not resolve org.jdom:jdom2:2.0.6.
Required by:
project : > com.android.tools.build:gradle:3.5.0 > com.android.tools.build.jetifier:jetifier-processor:1.0.0-beta04
Skipped due to earlier error
Could not resolve org.jetbrains.kotlin:kotlin-script-runtime:1.3.50.
Required by:
project : > org.jetbrains.kotlin:kotlin-gradle-plugin:1.3.50 > org.jetbrains.kotlin:kotlin-compiler-embeddable:1.3.50
Skipped due to earlier error
Could not resolve org.jetbrains.kotlin:kotlin-daemon-embeddable:1.3.50.
Required by:
project : > org.jetbrains.kotlin:kotlin-gradle-plugin:1.3.50 > org.jetbrains.kotlin:kotlin-compiler-embeddable:1.3.50
Skipped due to earlier error
Could not resolve org.jetbrains.intellij.deps:trove4j:1.0.20181211.
Required by:
project : > org.jetbrains.kotlin:kotlin-gradle-plugin:1.3.50 > org.jetbrains.kotlin:kotlin-compiler-embeddable:1.3.50
Skipped due to earlier error
Could not resolve org.jetbrains.kotlin:kotlin-build-common:1.3.50.
Required by:
project : > org.jetbrains.kotlin:kotlin-gradle-plugin:1.3.50 > org.jetbrains.kotlin:kotlin-compiler-runner:1.3.50
Skipped due to earlier error
Could not resolve org.jetbrains.kotlin:kotlin-daemon-client:1.3.50.
Required by:
project : > org.jetbrains.kotlin:kotlin-gradle-plugin:1.3.50 > org.jetbrains.kotlin:kotlin-compiler-runner:1.3.50
Skipped due to earlier error
Could not resolve org.jetbrains.kotlinx:kotlinx-coroutines-core:1.1.1.
Required by:
project : > org.jetbrains.kotlin:kotlin-gradle-plugin:1.3.50 > org.jetbrains.kotlin:kotlin-compiler-runner:1.3.50
project : > org.jetbrains.kotlin:kotlin-gradle-plugin:1.3.50 > org.jetbrains.kotlin:kotlin-scripting-compiler-impl-embeddable:1.3.50
Skipped due to earlier error
Could not resolve org.jetbrains.kotlin:kotlin-scripting-common:1.3.50.
Required by:
project : > org.jetbrains.kotlin:kotlin-gradle-plugin:1.3.50 > org.jetbrains.kotlin:kotlin-scripting-compiler-impl-embeddable:1.3.50
Skipped due to earlier error
Could not resolve org.jetbrains.kotlin:kotlin-scripting-jvm:1.3.50.
Required by:
project : > org.jetbrains.kotlin:kotlin-gradle-plugin:1.3.50 > org.jetbrains.kotlin:kotlin-scripting-compiler-impl-embeddable:1.3.50
Skipped due to earlier error
Could not resolve org.jetbrains.kotlin:kotlin-stdlib-common:1.3.50.
Required by:
project : > org.jetbrains.kotlin:kotlin-gradle-plugin:1.3.50 > org.jetbrains.kotlin:kotlin-stdlib:1.3.50
Skipped due to earlier error
Could not resolve org.jetbrains:annotations:13.0.
Required by:
project : > org.jetbrains.kotlin:kotlin-gradle-plugin:1.3.50 > org.jetbrains.kotlin:kotlin-stdlib:1.3.50
project : > com.android.tools.build:gradle:3.5.0 > com.android.tools.build:builder:3.5.0 > com.android.tools:sdklib:26.5.0 > com.android.tools.layoutlib:layoutlib-api:26.5.0
Skipped due to earlier error
Could not resolve org.jetbrains.kotlin:kotlin-util-io:1.3.50.
Required by:
project : > org.jetbrains.kotlin:kotlin-gradle-plugin:1.3.50 > org.jetbrains.kotlin:kotlin-native-utils:1.3.50
Skipped due to earlier error
Could not resolve org.apache.commons:commons-compress:1.12.
Required by:
project : > com.android.tools.build:gradle:3.5.0 > com.android.tools.build:builder:3.5.0 > com.android.tools:sdklib:26.5.0
project : > com.android.tools.build:gradle:3.5.0 > com.android.tools.build:builder:3.5.0 > com.android.tools:sdklib:26.5.0 > com.android.tools:repository:26.5.0
Skipped due to earlier error
Could not resolve org.jetbrains.trove4j:trove4j:20160824.
Required by:
project : > com.android.tools.build:gradle:3.5.0 > com.android.tools.build:builder:3.5.0 > com.android.tools:sdk-common:26.5.0
Skipped due to earlier error
Could not resolve net.sf.kxml:kxml2:2.3.0.
Required by:
project : > com.android.tools.build:gradle:3.5.0 > com.android.tools.build:builder:3.5.0 > com.android.tools.build:manifest-merger:26.5.0
project : > com.android.tools.build:gradle:3.5.0 > com.android.tools.build:builder:3.5.0 > com.android.tools.ddms:ddmlib:26.5.0
project : > com.android.tools.build:gradle:3.5.0 > com.android.tools.build:builder:3.5.0 > com.android.tools:sdklib:26.5.0 > com.android.tools.layoutlib:layoutlib-api:26.5.0
Skipped due to earlier error
Could not resolve com.google.code.findbugs:jsr305:3.0.2.
Required by:
project : > com.android.tools.build:gradle:3.5.0 > com.android.tools.build:builder:3.5.0 > com.android.tools.build:apkzlib:3.5.0
Skipped due to earlier error
Could not resolve com.google.guava:failureaccess:1.0.1.
Required by:
project : > com.android.tools.build:gradle:3.5.0 > com.android.tools.analytics-library:crash:26.5.0 > com.google.guava:guava:27.0.1-jre
Skipped due to earlier error
Could not resolve com.google.guava:listenablefuture:9999.0-empty-to-avoid-conflict-with-guava.
Required by:
project : > com.android.tools.build:gradle:3.5.0 > com.android.tools.analytics-library:crash:26.5.0 > com.google.guava:guava:27.0.1-jre
Skipped due to earlier error
Could not resolve com.google.code.findbugs:jsr305:3.0.2.
Required by:
project : > com.android.tools.build:gradle:3.5.0 > com.android.tools.analytics-library:crash:26.5.0 > com.google.guava:guava:27.0.1-jre
Skipped due to earlier error
Could not resolve org.checkerframework:checker-qual:2.5.2.
Required by:
project : > com.android.tools.build:gradle:3.5.0 > com.android.tools.analytics-library:crash:26.5.0 > com.google.guava:guava:27.0.1-jre
Skipped due to earlier error
Could not resolve com.google.errorprone:error_prone_annotations:2.3.1.
Required by:
project : > com.android.tools.build:gradle:3.5.0 > com.android.tools.analytics-library:crash:26.5.0 > com.google.guava:guava:27.0.1-jre
Skipped due to earlier error
Could not resolve com.google.j2objc:j2objc-annotations:1.1.
Required by:
project : > com.android.tools.build:gradle:3.5.0 > com.android.tools.analytics-library:crash:26.5.0 > com.google.guava:guava:27.0.1-jre
Skipped due to earlier error
Could not resolve org.codehaus.mojo:animal-sniffer-annotations:1.17.
Required by:
project : > com.android.tools.build:gradle:3.5.0 > com.android.tools.analytics-library:crash:26.5.0 > com.google.guava:guava:27.0.1-jre
Skipped due to earlier error
Could not resolve commons-logging:commons-logging:1.2.
Required by:
project : > com.android.tools.build:gradle:3.5.0 > com.android.tools.analytics-library:crash:26.5.0 > org.apache.httpcomponents:httpclient:4.5.6
Skipped due to earlier error
Could not resolve commons-codec:commons-codec:1.10.
Required by:
project : > com.android.tools.build:gradle:3.5.0 > com.android.tools.analytics-library:crash:26.5.0 > org.apache.httpcomponents:httpclient:4.5.6
Skipped due to earlier error
Could not resolve com.sun.activation:javax.activation:1.2.0.
Required by:
project : > com.android.tools.build:gradle:3.5.0 > com.android.tools.build:builder:3.5.0 > com.android.tools:sdklib:26.5.0 > com.android.tools:repository:26.5.0
Skipped due to earlier error
Could not resolve org.glassfish.jaxb:jaxb-runtime:2.2.11.
Required by:
project : > com.android.tools.build:gradle:3.5.0 > com.android.tools.build:builder:3.5.0 > com.android.tools:sdklib:26.5.0 > com.android.tools:repository:26.5.0
Skipped due to earlier error
Could not resolve com.google.jimfs:jimfs:1.1.
Required by:
project : > com.android.tools.build:gradle:3.5.0 > com.android.tools.build:builder:3.5.0 > com.android.tools:sdklib:26.5.0 > com.android.tools:repository:26.5.0
Skipped due to earlier error

Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output. Run with --scan to get full insights.

Get more help at https://help.gradle.org

BUILD FAILED in 18m 49s
Exception: Gradle task assembleDebug failed with exit code 1

PLEASE HELP ME TO RUN MY FIRST FLUTTER APP UNDER SIMULATOR ON ANDROID STUDIO.

Hi @ChegMarcoADVANTECH
Looks like Android Studio is having trouble to download the required dependencies.
Is you machine connected to internet?
If yes then this might be caused by a firewall. You can try to use a different network.

Well, it looks like you are not connected to the internet, like @pedromassangocode mentioned or maybe you have an error in your gradle files.
Could you provide your android/app/build.gradle file? Btw verify your gradle and repos options in android/build.gradle file. Should look similar to:
    repositories {
        google()
        jcenter()
    }

classpath 'com.android.tools.build:gradle:4.0.1'

Ok thank you

Hi @ChegMarcoADVANTECH
I'm closing this for now, let me know if the issue still happening with a stable internet connection.


Unable to startup in Heroku

Apologies for the late reply, I'll try to get on this as soon as I can

I am unable to reproduce this issue with Heroku. If you still have issues, feel free to reply to this again.

getting this! I don't know why .

getting this! I don't know why .

Getting this ,I don't know what. Nothing found in the logs also, please help.

Getting this ,I don't know what. Nothing found in the logs also, please help.

It's not working at the moment.
If you press the Heroku button and install it automatically, it won't work.
It doesn't work even if you install it manually.


Arbitrary Code Execution Affecting thenify package, ALL versions

Getting high severity vulnerability for thenify
Please check here: https://snyk.io/vuln/npm:thenify and provide the fixed version.

Thanks for the reminder, it was fixed in 3.3.1

@dead-horse  high severity vulnerability is still there in 3.3.1
https://snyk.io/vuln/npm:thenify

@Rahul1408 I think Snyk just needs to update their DB. I'll contact their support team as I'm getting this alert as well

Hey! Adam from Snyk here. I've updated our database and you should expect to see the changes within the next hours :)

Hey! Adam from Snyk here. I've updated our database and you should expect to see the changes within the next hours :)

thanks @AdamGold.  Just FYI, High severity vulnerability is still showing in 3.3.1. Will take more time in DB sync.

Hey! Adam from Snyk here. I've updated our database and you should expect to see the changes within the next hours :)

thanks @AdamGold. Just FYI, High severity vulnerability is still showing in 3.3.1. Will take more time in DB sync.

it is fixed now with 3.3.1


4664: Moved CustomSelectorActivity to ViewBinding

Fixes #4664
What changes did you make and why?

Issue: As per the information provided and work request on the ticket above, CustomSelectorActivity.kt is currently using Kotlin Synthetic which creates auto-generated class, and has been alread deprecated.
Solution: Hence migration was done by replacing kotlin-synthetic with viewbinding, which is always null safe, type-safe and supports both Java and Kotlin.

NB: During migration unnecessary ids of included layouts  were removed from activity_custom_selector.xml which was showing error before the fix.

@dbrant Requesting to review this PR


Improve landing page actions and view

From feedback, the current landing page is that it is focused mostly on campaign managers. There is equal weight for initial actions create a campaign or participate in a campaign. Users need more context plus we should look to emphasize participating in a campaign more than creating them.

Adjust information hierarchy for new users. Start a Campaign should not be the first information a user reads. Look to help orient and then move into action for a Participant. Start a campaign should be moved into a logged in state.
Improve map viz. Redesign markers (consider not using pin markers) for better overlap look. Use a a styled Mapbox base layer.
Adjust table information to better clarify what is being tracked, date/time, and an action to participate. Participant information does not make sense (nor does it track the correct number).

Improve map viz. Redesign markers (consider not using pin markers) for better overlap look. Use a a styled Mapbox base layer.

@smit1678 , mapbox does have free map, but it has limitation of 50,000 map views / month. https://www.mapbox.com/pricing/. Your call.

Here are some rough wireframes for the homepage, so we can discuss it:

What has been updated:

Two campaign layout variants - horizontal block or card
Initially we can hide the map
"Create campaign" and "Manage" button is only visible for the logged in campaign managers
Show the active campaigns by default, button to show inactive
Show the nearest campaigns by default, button to show all
Add radius selection or the nearest campaigns
Can add priority indicator (from OSM tasking manager)
More detailed campaign information on the homepage

Hi @smit1678 and @MariaSolovyeva, my initial thoughts:

I like the idea of having an option to show only the nearest X rather than showing all nearest. This will improve over time as more campaigns are added.
I am +1 on the 2 card panels with means it will be closer to what the 1 card per panel will be on a smaller form factor.
I am +1 on the summary map in the top right. I'm not sure how useful the "hide" map will be since the same outcome can be achieved through scrolling.

All in all I'd be +1 on turning this into a mockup according to the colour guidelines from the new tasking manager.

Here's my thoughts :

I don't think we need map view per row, it will hurts the performance.
Can we move map panel to the left? People usually scrolling in the right side of the screen.
Agree with @cchristelis, don't think hide map is useful.

@dimasciput, we could just pre-render a map and serve it as a static image. esp. if we have a whole earth view then it is just a dot. I'm wondering whether we will actually allow scrolling on the map/maps? they could just be static.

@cchristelis yes we could server it as a static image, then we need to save the jpeg file to field-campaigner-data too. But why do we need that map view in the row if we can see it the main map view?
For the scrolling, I was thinking about the main map view. I think we should be able to zoom in and out, because those are common behaviors for map.

For the map on the top, my idea was initially to hide map, and to show it only if user wants/needs, especially for displaying the nearest campaigns.

@dimasciput, the idea is to give each of the campaigns their own summary data. It is not possible to see where a campaign is once the user has scrolled down. This will also help out campaigns that have less text added by the campaign managers.

@cchristelis So like http://tasks.hotosm.org ? Then maybe we don't need the map on the top?

@dimasciput , I left the option to show map on the top for the user to see the nearest campaigns. The small thumbnail would not be helpful for this. So when there is a option ticked to show only the nearest campaigns, it should not be too heavy for the server to load only few campaigns on the map?

maybe it's also nice for logged in users to see their locations on the summary map in the top.

yes @cchristelis  I agree

Here is the non-manager user view

Here is the manager view:

"My" campaigns are added to the selection the top
"Manage" button added to the cards of the  campaigns created by user

@MariaSolovyeva Apologies for the slow reply. I like the adjustments with the cards and mini-map views. My main feedback point is that I think we need more context at the top. This landing view needs to orient new comers looking to get an update on a campaign or participate. I think we need to look to answer two questions at the top section: What is this tool? What do I need to do next / how do I get started? The filters and the active campaigns number doesn't communicate this.
@dimasciput @cchristelis for the mini-maps in the cards, what is the issue with performance? Can't we do this all client-side and not have to add things we need to save and manage in field-campaigner-data (also options like the Mapbox Static API)? I would love to keep how we manage the campaign data as simple as possible.

@smit1678 I'm using the static image from openstreetmap, so it should be fine now.

Hello @cchristelis and @smit1678, do you think of just some text input or something made of data and visual? Attached is how it can look with some descriptions. We will need to make a copy for it.

Hi @MariaSolovyeva , this is from @smit1678 :

Can you update the mockup?

@MariaSolovyeva, I tried to move the filtering into search section, but it's just not that good.

hi @dimasciput and @smit1678 ,
please see the updated home

@MariaSolovyeva Can we update the header and footer styles?
What do you think of trying to reduce down to one intro paragraph with a better title? Something along the lines of:

Something that is confusing me @MariaSolovyeva, is the distinction between the Home and Campaign List in the menu bar.

Hi @smit1678 and @cchristelis , please take a look at this.

@MariaSolovyeva Can we update the header and footer as well? Let's use the HOT logo with the tool title for now until (or if) we come up with a specific tool logo and name. Please use this as a guide: https://github.com/hotosm/osm-export-tool2/issues/217#issuecomment-325423661

@MariaSolovyeva do you have the updated layout?

Hello @dimasciput , @cchristelis and @smit1678 , here is the updated header and footer. We need somebody to write the intro copy for the homepage.

Looks pretty good. In the header, is there any different behavior between clicking on the logo/name, 'Home' and 'Campaign list'? If not, can we reduce the options there?

Thank you @PaulUithol , of course that makes sense about  logo/name, 'Home' and 'Campaign list'?, just updated it. This is what @cchristelis was pointing at too, but I didn't read it good.

@ann26, can you please confirm that our latest version is in-line with the final mock-up?

yes @cchristelis


feat(metadata): adds Associations to Metadata spec

Description
Instead of storing Association data in a file in the imageset,
it will be stored as a part of the Metadata spec for subsequent
execution to support pruning and layer differentiation. This
change also adds a new mirror option "ignore-history" which allows
past blobs to be repacked
BREAKING CHANGE: Updates the ImageSetMetadataSpec and invalidates previous metadata
Signed-off-by: Jennifer Power<EMAIL_ADDRESS>Type of change
Please delete options that are not relevant.

[ ] Bug fix (non-breaking change which fixes an issue)
[X] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

How Has This Been Tested?

[ ] Unit tests added

Checklist:

[ ] My code follows the style guidelines of this project
[ ] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes
[ ] Any dependent changes have been merged and published in downstream modules

/retest


Update cargo-binutils installation instructions.

Fix for issue #57

...I did not read the instructions and skipped the first step where this is added, whoops.


Add proper check boxes and radio buttons to forms

We don't really support this very well right now.

I don't know if you guys are still developing Ratchet, but I really like it a lot. Radio buttons support would be great


Add remaining zint generators (pdf417)

pdf417 is commonly used by banking applications so it would be very useful for generating invoices. But in general, given that there's already an enum of supported generators, why not add all of them.
I created a local copy of the plugin and added it, it ended up being a 1 line change for the pdf417 one.

I think it's supported but a shorthand is missing. Can you open a pr and add it?


bug fix when SkipFlagParsing is false and SkipArgReorder is true

Signed-off-by: Shukui Yang<EMAIL_ADDRESS>

I have this pr to fix the if case, could you give a review ? thank you!
ping @jszwedko

Oops, thank you for fixing this!


[FEATURE] Be able send the charge point status

In OCPP, the connector 0 is reserved for the entire charge point:

It should be possible to manage the charge point status from the simulator.

Duplicate of #15


Abstract class method rename problem

After the abstract method of the abstract class is renamed, the method overriding it is not renamed.
    /* renamed from: o */
    public abstract void onError(Exception exc);

    @Override // defpackage.bqu
    protected final void o(Exception exc) {
        ExceptionUtils.handleException(exc);
        this.oO.handleException((Throwable) exc, true);
    }

@MartinKayJr can you share a sample? Turns out I can't reproduce this issue :cry:

When a method is renamed in a child class, the method of the parent class can also be renamed. But when the parent class goes to rename the method, the child classes are not synchronized

I can't provide this sample because it involves privacy. But in my judgment, this has something to do with the way the renaming is made. If there are @override members of a child class to rename, the parent class can be synchronized. However, if you rename from a parent class, you cannot synchronize the @override to the child class