BUG

Program version
3.0.1
Service
Funimation
Command used
anidl.exe --service funi --s 17847 -q 10 --sub --dubLang jpn jpn --mkv -e 83
Show ID
17847
Episode
83
Console Output
=== Multi Downloader NX 3.0.1 ===
[#17847] Attack on Titan (2013)
[ 0001] Attack on Titan - #01 To You, in 2000 Years -- The Fall of Shiganshina, Part 1 (25:55) [HD1080, English, Japanese, Spanish, Portuguese]
[ 0002] Attack on Titan - #02 That Day -- The Fall of Shiganshina, Part 2 (24:25) [HD1080, Japanese, English, Spanish, Portuguese]
[ 0003] Attack on Titan - #03 A Dim Light Amid Despair -- Humanity's Comeback, Part 1 (24:26) [HD1080, Japanese, English, Spanish, Portuguese]
[ 0004] Attack on Titan - #04 The Night of the Closing Ceremony -- Humanity's Comeback, Part 2 (24:25) [HD1080, Japanese, English, Portuguese, Spanish]
[ 0005] Attack on Titan - #05 First Battle -- The Struggle on Trost, Part 1 (24:22) [HD1080, English, Japanese, Spanish, Portuguese]
[ 0006] Attack on Titan - #06 The World the Girl Saw -- The Struggle for Trost, Part 2 (24:22) [HD1080, Japanese, English, Portuguese, Spanish]
[ 0007] Attack on Titan - #07 Small Blade -- The Struggle for Trost, Part 3 (24:22) [HD1080, Japanese, English, Spanish, Portuguese]
[ 0008] Attack on Titan - #08 I Can Hear His Heartbeat -- The Struggle for Trost, Part 4 (24:22) [HD1080, English, Japanese, Portuguese, Spanish]
[ 0009] Attack on Titan - #09 Whereabouts of His Left Arm -- The Struggle for Trost, Part 5 (24:22) [HD1080, Japanese, English, Spanish, Portuguese]
[ 0010] Attack on Titan - #10 Response -- The Struggle for Trost, Part 6 (24:22) [HD1080, Japanese, English, Spanish, Portuguese]
[ 0011] Attack on Titan - #11 Idol -- The Struggle for Trost, Part 7 (24:22) [HD1080, Japanese, English, Spanish, Portuguese]
[ 0012] Attack on Titan - #12 Wound -- Attack on Trost, Part 8 (24:22) [HD1080, English, Japanese, Portuguese, Spanish]
[ 0013] Attack on Titan - #13 Primal Desire -- The Struggle for Trost, Part 9 (24:22) [HD1080, Japanese, English, Spanish, Portuguese]
[ 0014] Attack on Titan - #14 Can’t Look into His Eyes Yet -- Eve of the Counterattack, Part 1 (24:22) [HD1080, English, Japanese, Spanish, Portuguese]
[ 0015] Attack on Titan - #15 Special Operations Squad -- Eve of the Counterattack, Part 2 (24:22) [HD1080, Japanese, English, Portuguese, Spanish]
[ 0016] Attack on Titan - #16 What Needs to be Done Now -- Eve of the Counterattack, Part 3 (24:22) [HD1080, English, Japanese, Spanish, Portuguese]
[ 0017] Attack on Titan - #17 Female Titan -- The 57th Exterior Scouting Mission, Part 1 (24:22) [HD1080, Japanese, English, Spanish, Portuguese]
[ 0018] Attack on Titan - #18 Forest of Giant Trees -- The 57th Exterior Scouting Mission, Part 2 (24:22) [HD1080, English, Japanese, Portuguese, Spanish]
[ 0019] Attack on Titan - #19 Bite -- The 57th Expedition, Part 3 (24:23) [HD1080, English, Japanese, Spanish, Portuguese]
[ 0020] Attack on Titan - #20 Erwin Smith -- The 57th Exterior Scouting Mission, Part 4 (24:22) [HD1080, English, Japanese, Spanish, Portuguese]
[ 0021] Attack on Titan - #21 Crushing Blow -- The 57th Exterior Scouting Mission, Part 5 (24:22) [HD1080, Japanese, English, Portuguese, Spanish]
[ 0022] Attack on Titan - #22 The Defeated -- The 57th Exterior Scouting Mission, Part 6 (24:23) [HD1080, English, Japanese, Portuguese, Spanish]
[ 0023] Attack on Titan - #23 Smile -- Assault on Stohess, Part 1 (24:23) [HD1080, Japanese, English, Portuguese, Spanish]
[ 0024] Attack on Titan - #24 Mercy -- Assault on Stohess, Part 2 (24:22) [HD1080, English, Japanese, Spanish, Portuguese]
[ 0025] Attack on Titan - #25 Wall -- Assault on Stohess, Part 3 (24:08) [HD1080, English, Japanese, Spanish, Portuguese]
[ 0026] Attack on Titan S2 - #26 Beast Titan (24:10) [HD1080, Japanese, English, Spanish, Portuguese]
[ 0027] Attack on Titan S2 - #27 I'm Home (24:10) [HD1080, Japanese, English, Spanish, Portuguese]
[ 0028] Attack on Titan S2 - #28 Southwestward (24:10) [HD1080, Japanese, English, Portuguese, Spanish]
[ 0029] Attack on Titan S2 - #29 Soldier (24:10) [HD1080, Japanese, English, Portuguese, Spanish]
[ 0030] Attack on Titan S2 - #30 Historia (24:10) [HD1080, Japanese, English, Spanish, Portuguese]
[ 0031] Attack on Titan S2 - #31 Warrior (24:10) [HD1080, Japanese, English, Portuguese, Spanish]
[ 0032] Attack on Titan S2 - #32 Close Combat (24:10) [HD1080, Japanese, English, Portuguese, Spanish]
[ 0033] Attack on Titan S2 - #33 The Hunters (24:10) [HD1080, Japanese, English, Spanish, Portuguese]
[ 0034] Attack on Titan S2 - #34 Opening (24:10) [HD1080, Japanese, English, Spanish, Portuguese]
[ 0035] Attack on Titan S2 - #35 Children (24:10) [HD1080, Japanese, English, Spanish, Portuguese]
[ 0036] Attack on Titan S2 - #36 Charge (24:10) [HD1080, Japanese, English, Portuguese, Spanish]
[ 0037] Attack on Titan S2 - #37 Scream (24:10) [HD1080, Japanese, English, Portuguese, Spanish]
[ 0038] Attack on Titan S3 - #38 Smoke Signal (23:55) [HD1080, Japanese, English, Portuguese, Spanish]
[ 0039] Attack on Titan S3 - #39 Pain (23:55) [HD1080, Japanese, English, Spanish, Portuguese]
[ 0040] Attack on Titan S3 - #40 Old Story (23:55) [HD1080, Japanese, English, Spanish, Portuguese]
[ 0041] Attack on Titan S3 - #41 Trust (23:55) [HD1080, Japanese, English, Portuguese, Spanish]
[ 0042] Attack on Titan S3 - #42 Reply (23:55) [HD1080, Japanese, English, Spanish, Portuguese]
[ 0043] Attack on Titan S3 - #43 Sin (23:55) [HD1080, Japanese, English, Spanish, Portuguese]
[ 0044] Attack on Titan S3 - #44 Wish (23:55) [HD1080, Japanese, English, Portuguese, Spanish]
[ 0045] Attack on Titan S3 - #45 Outside the Walls of Orvud District (23:55) [HD1080, Japanese, English, Spanish, Portuguese]
[ 0046] Attack on Titan S3 - #46 Ruler of the Walls (23:55) [HD1080, Japanese, English, Portuguese, Spanish]
[ 0047] Attack on Titan S3 - #47 Friends (23:55) [HD1080, Japanese, English, Spanish, Portuguese]
[ 0048] Attack on Titan S3 - #48 Bystander (23:55) [HD1080, Japanese, English, Portuguese, Spanish]
[ 0049] Attack on Titan S3 - #49 Night of the Battle to Retake the Wall (23:55) [HD1080, Japanese, English, Portuguese, Spanish]
[ 0050] Attack on Titan S3 - #50 The Town Where Everything Began (23:55) [HD1080, Japanese, English, Spanish, Portuguese]
[ 0051] Attack on Titan S3 - #51 Thunder Spears (23:55) [HD1080, Japanese, English, Spanish, Portuguese]
[ 0052] Attack on Titan S3 - #52 Descent (23:55) [HD1080, Japanese, English, Spanish, Portuguese]
[ 0053] Attack on Titan S3 - #53 Perfect Game (23:55) [HD1080, Japanese, English, Portuguese, Spanish]
[ 0054] Attack on Titan S3 - #54 Hero (23:55) [HD1080, Japanese, English, Spanish, Portuguese]
[ 0055] Attack on Titan S3 - #55 Midnight Sun (23:55) [HD1080, Japanese, English, Spanish, Portuguese]
[ 0056] Attack on Titan S3 - #56 The Basement (23:55) [HD1080, Japanese, English, Portuguese, Spanish]
[ 0057] Attack on Titan S3 - #57 That Day (23:55) [HD1080, Japanese, English, Portuguese, Spanish]
[ 0058] Attack on Titan S3 - #58 Attack Titan (23:55) [HD1080, Japanese, English, Portuguese, Spanish]
[ 0059] Attack on Titan S3 - #59 The Other Side of the Wall (23:40) [HD1080, Japanese, English, Spanish, Portuguese]
[M0001] Attack on Titan S4 - movie#01 Attack on Titan ~Chronicle~ (2:00:35) [HD1080, English, Japanese]
[ 0060] Attack on Titan S5 - #60 The Other Side of the Sea (00:23:55) [HD1080, Japanese, English, Spanish, Portuguese]
[ 0061] Attack on Titan S5 - #61 Midnight Train (00:23:55) [HD1080, Japanese, English, Spanish, Portuguese]
[ 0062] Attack on Titan S5 - #62 The Door of Hope (00:23:55) [HD1080, Japanese, English, Spanish, Portuguese]
[ 0063] Attack on Titan S5 - #63 From One Hand to Another (00:23:55) [SD540, Japanese, English, Portuguese, Spanish]
[ 0064] Attack on Titan S5 - #64 Declaration of War (00:23:55) [SD540, Japanese, English, Spanish, Portuguese]
[ 0065] Attack on Titan S5 - #65 The War Hammer Titan (00:23:54) [HD1080, Japanese, English, Portuguese, Spanish]
[ 0066] Attack on Titan S5 - #66 Assault (00:23:55) [SD540, Japanese, English, Spanish, Portuguese]
[ 0067] Attack on Titan S5 - #67 Assassin's Bullet (00:23:55) [SD540, Japanese, English, Portuguese, Spanish]
[ 0068] Attack on Titan S5 - #68 Brave Volunteers (00:23:54) [SD540, Japanese, Portuguese, English, Spanish]
[ 0069] Attack on Titan S5 - #69 A Sound Argument (00:23:55) [SD540, Japanese, English, Spanish, Portuguese]
[ 0070] Attack on Titan S5 - #70 Deceiver (00:23:55) [SD540, Japanese, English, Portuguese, Spanish]
[ 0071] Attack on Titan S5 - #71 Guides (00:23:55) [SD540, Japanese, English, Portuguese, Spanish]
[ 0072] Attack on Titan S5 - #72 Children of the Forest (00:23:55) [SD540, Japanese, Spanish, Portuguese, English]
[ 0073] Attack on Titan S5 - #73 Savagery (00:23:55) [HD1080, Japanese, Portuguese, Spanish, English]
[ 0074] Attack on Titan S5 - #74 Sole Salvation (00:23:55) [HD1080, Japanese, Spanish, Portuguese, English]
[ 0075] Attack on Titan S5 - #75 Above and Below (00:23:40) [SD540, Japanese, Portuguese, Spanish, English]
[ 0076] Attack on Titan S5 - #76 Judgment (00:23:55) [HD1080, Japanese, English]
[ 0077] Attack on Titan S5 - #77 Sneak Attack (00:23:55) [HD1080, Japanese, English]
[ 0078] Attack on Titan S5 - #78 Two Brothers (00:23:55) [HD1080, Japanese, English]
[ 0079] Attack on Titan S5 - #79 Memories of the Future (00:23:55) [HD1080, Japanese]
[ 0080] Attack on Titan S5 - #80 From You, 2,000 Years Ago (00:23:55) [HD1080, Japanese]
[ 0081] Attack on Titan S5 - #81 Thaw (00:23:55) [HD1080, Japanese]
[ 0082] Attack on Titan S5 - #82 Sunset (00:23:55) [HD1080, Japanese]
[ 0083] Attack on Titan S5 - #83 Pride (00:23:55) [HD1080, Japanese] (selected)
[ 5930] Attack on Titan S99 - event#210370 Anime Boston Premiere Panel (47:21) [HD720, English]
[V0001] Attack on Titan S6 - ova#01 Ilse's Notebook: Memoirs of a Scout Regiment Member (00:23:18) [SD540, Japanese]
[V0002] Attack on Titan S6 - ova#02 The Sudden Visitor: The Torturous Curse of Youth (00:25:23) [SD540, Japanese]
[V0003] Attack on Titan S6 - ova#03 Distress (00:23:56) [SD540, Japanese]
[V0004] Attack on Titan S6 - ova#04 No Regrets: Part 1 (00:24:03) [SD540, Japanese]
[V0005] Attack on Titan S6 - ova#05 No Regrets: Part 2 (00:29:59) [SD540, Japanese]
[V0006] Attack on Titan S6 - ova#06 Lost Girls: Wall Sina, Goodbye: Part 1 (00:23:53) [SD540, Japanese]
[V0007] Attack on Titan S6 - ova#07 Lost Girls: Wall Sina, Goodbye: Part 2 (00:23:55) [SD540, Japanese]
[V0008] Attack on Titan S6 - ova#08 Lost Girls: Lost in the Cruel World (00:23:55) [SD540, Japanese]
[INFO] Selected Episodes: 0083
[INFO] Attack on Titan - S5E83 - Pride
[INFO] Available streams (Non-Encrypted):
[ERROR] Track not selected

Additional Information
Same going for english dub of episode 78 same show

Some episodes might require a premium account

Some episodes might require a premium account

I have Premium

Can you give me the complete console output?

Can you give me the complete console output?

Ok

Can you give me the complete console output?

I have updated the console output please me out

Can you give me the complete console output?

reply please i have changed my console output

First, I am still a student and I do this not only in my free time but also for free.
So I will respond and work on this whenever I choose to do so.

Said episode downloaded without issues for me.

Closing due to inactivity, feel free to re-open if this is still a problem.


USHIFT-1628 [BUG] Custom qemu-guest-agent library mishandles non-0 virsh status

As it is, the virsh processes's return data is accessed before checking the virsh exit status.  If the exit code is non-0, result.stdout['return'] is unassigned, causing a json decoding error.
This fix checks the result.rc before result.stdout['return'] to protect against accessing a non-existent key.

@copejon , please link the PR to a JIRA issue and unhold to merge
/lgtm
/hold

USHIFT-1628
/jira refresh

/retest

/unhold


Allow Root In Bower

This patch allows root users to build the admin interface which otherwise
may be problematic for test systems (e.g. Docker containers).
Your pull request should…

[ ] have a concise title
[ ] close an accompanying issue if one exists
[ ] be against the correct branch (features can only go into develop)
[ ] include migration scripts and documentation, if appropriate
[ ] pass automated testing
[ ] have a clean commit history
[ ] have proper commit messages (title and body) for all commits
[ ] have appropriate tags applied

So that's why buildbot's workers did not work properly as root...


[MWPW-137074] Long Text block: Plain variant to support color page layout

Some updated stylings for color pages including a plain version of the long-text block
Resolves: MWPW-137074
Test URLs:

Before: https://stage--express--adobecom.hlx.page/express/colors/red?lighthouse=on
After: https://mwpw-137074--express--adobecom.hlx.page/express/colors/red?lighthouse=on

Codecov Report

Merging #304 (87815a6) into stage (632286e) will increase coverage by 0.16%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##            stage     #304      +/-   ##
==========================================
+ Coverage   50.56%   50.72%   +0.16%
==========================================
  Files          33       33
  Lines        9993     9993
==========================================
+ Hits         5053     5069      +16
+ Misses       4940     4924      -16

see 1 file with indirect coverage changes
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Please add .d.ts file to this project to support typescript

Some problems come to me when I try to use typescript to write my web app, so i wonder if you could write an index.d.ts file for this project to support vscode intellisense or make it easy for us to write code by typescript?

l agree that. l also have to handle file uploading in koa2 with typescript. But l can't find type definition file for this module. Have you accomplished that ?

Nice @benstevens48 <Multer.MulterIncomingMessage> cast, solves ctx.req.file or files :)
Merci Beaucoup


Question about get_2d_boxes in kitti_converter.py

Hello,
First, I want to thank you for your effort to push this area forward!
I wonder why loc_3d [line] is not using the location (or transformed center location) provided in KITTI labels? I see you add an offset to the original location. Why is the transformation needed?

It is because the labels provided by KITTI are in the coordinate of reference camera (camera 0). Instead, we would like to store them with the coordinates in the current camera (camera 2). There approximately exists an offset over the horizontal direction as shown in the KITTI paper.
This error is limited for left RGB camera (compared to the adjacent camera 0) while significant for right cameras.

Got it. Thank you very much!


Enable testing with all possible feature sets

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@4fcc668). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master      #93   +/-   ##
=========================================
  Coverage          ?   80.29%
=========================================
  Files             ?       49
  Lines             ?     1609
  Branches          ?        0
=========================================
  Hits              ?     1292
  Misses            ?      317
  Partials          ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4fcc668...c290fe6. Read the comment docs.

bors r+


Incorrect value for client port number

In ListenerOrIncomingConnection class, method getClientPortNumber returns server port number value instead of client port number value.

Will be fixed within #555

Did this get fixed in 555? If so can we please close this?


"Extract to JSX component" code action

This would be nice. Select a bunch of JSX and extract it as a proper component.
cc @nojaf

Interesting idea, how would you approach this?
What would the rough outline be?


get_issues() to only return issues, not PRs

Fix #34 by limiting get_issues() to really only get issues, not PRs. Since PR handler has its own methods to get open PRs, this should not break anything?
>>> changebot.github.github_api import RepoHandler
>>> repo = RepoHandler('astropy/astropy')
>>> repo.get_issues('open', 'Close?')  # No 3845
[6025, 5193, 4842, 4549, 3951, 2603, 2232, 435, 383, 282]
>>> repo.get_issues('open', 'Close?', exclude_pr=False)  # Has 3845
[6025, 5193, 4842, 4549, 3951, 3845, 2603, 2232, 1920, 435, 383, 282]

Also added a test for this as per #33.
p.s. I briefly thought about having get_issues() to return a list of handlers instead of just numbers, but that has larger overhead, so will need a good reason to do so.

Coverage decreased (-0.3%) to 67.172% when pulling 5e57d89e513b2415da6c1b575d02af2974380332 on pllim:get_issue_no_pr into 2e32dcc7e264ec4a86ea8323cbe691cb342f5a68 on astropy:master.

Coverage increased (+1.3%) to 68.75% when pulling 2674b4676fd6fc6e7fb5c2a0022853e5e7d17267 on pllim:get_issue_no_pr into 2e32dcc7e264ec4a86ea8323cbe691cb342f5a68 on astropy:master.

Coverage increased (+2.6%) to 70.053% when pulling ce38ee5eb063d287c9955300b11c23537c6c8cd0 on pllim:get_issue_no_pr into 2e32dcc7e264ec4a86ea8323cbe691cb342f5a68 on astropy:master.


Warning: startReportingRuntimeErrors doesn’t accept launchEditorEndpoint argument anymore

Hi,
We use React, Razzle (https://github.com/jaredpalmer/razzle) and SSR for our website.
I tried to implement react-cookie with universal-cookie-express which works fine for me. My only concern is a warning in a console.
index.js:1 Warning: "startReportingRuntimeErrors" doesn’t accept "launchEditorEndpoint" argument anymore. Use "listenToOpenInEditor" instead with your own implementation to open errors in editor
Have you registered that and is there a way to solve it? Seems like it happens after installing packages with npm for me or to be more specific after npm audit
added 3 packages from 3 contributors and audited 34756 packages in 16.613s found 437 vulnerabilities (435 moderate, 2 high)   run "npm audit fix" to fix them, or "npm audit" for details

Sorry, I just investigate a bit further and it's a npm, node problem. Definitely not caused by react-cookie


Confusing prompt on accelerator config

When setting up accelerator with deepspeed, the prompt of how many processes will be used is really confusing, especially when one only starts with accelerator.
In which compute environment are you running? ([0] This machine, [1] AWS (Amazon SageMaker)): 0
Which type of machine are you using? ([0] No distributed training, [1] multi-CPU, [2] multi-GPU, [3] TPU): 2
How many different machines will you use (use more than 1 for multi-node training)? [1]: 1
Do you want to use DeepSpeed? [yes/NO]: yes
What should be your DeepSpeed's ZeRO optimization stage (0, 1, 2, 3)? [2]: 2
Where to offload optimizer states? [NONE/cpu/nvme]: cpu
How many gradient accumulation steps you're passing in your script? [1]: 16
How many processes in total will you use? [1]: 16           <============== this one right here
Do you wish to use FP16 or BF16 (mixed precision)? [NO/fp16/bf16]: fp16

I'd suggest maybe something like - How many GPUs are you using?
That's assuming I got this line correctly :-)

It could be TPUs, or even CPUs if you use distributing training in CPU, so we can't replace it with "How many GPUs". Maybe "devices" ?

Across how many devices should everything be distributed?

Is made even more exact with https://github.com/huggingface/accelerate/pull/344
Follows your request @elonsalfati as we can pick up if you're using TPU, GPU, or CPU based on question 1 😄
Thanks for the idea!

That's awesome! Thanks :-)


PHP 8 support

This covers PHPLIB-595 and PHPLIB-588.
Due to PHP 8 not being available on Evergreen yet, we test standalone, replica set, and sharded topologies on PHP 8 as well, in addition to testing them on PHP 7.4. While a new version of the extension is required on PHP 8, we will not bump the minimum ext-mongodb version as existing versions should continue to work as expected.
Notable changes:

PHPUnit 9 moves the global assertions functions to a PHPUnit namespace. To provide compatibility with earlier PHPUnit versions (required to continue supporting PHP 7.0 and newer) we include a polyfill here which falls back to the PHPUnit functions if they exist.
travis-ci tested on PHP 7.3 by default. This was changed to PHP 7.4, including simplifying the configuration to make future changes easier (we expect to always test on the newest stable version)
The BC layer for constraints has been removed, as the changes were incorporated into the PHPUnit Bridge provided by Symfony. We'll update the dependency to a stable version once Symfony 5.2 has been released. Since it's a development dependency, using a branch version for it has no stability impact on users.

Fix https://github.com/mongodb/mongo-php-library/pull/786


Don't fail if creating a venv didn't succeed. Also provide a way to disable creating separate venvs.

https://github.com/apache/beam/pull/16658 made a change to Python SDK harness container boot sequence to launch SDK processes in separately created virtual environments.
It appears that the venv dependency is sometimes not available on non-beam Python container images. Users who supply  custom containers  may run into errors when python3-venv is not installed, and need to install it separately, which is inconvenient.
Creating a venv is not strictly required, therefore we can fallback on prior behavior to use global environment.
Drive-by changes:

Log why creating a venv didn't succeed.
Provide an way to disable venv creation, which may benefit users who wish to re-use a precreated virtual environment on their image.  To disable creating isolated venvs, users can add the following line to their Dockerfiles: ENV RUN_PYTHON_SDK_IN_DEFAULT_ENVIRONMENT=1

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

[ ] Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
[ ] Update CHANGES.md with noteworthy changes.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)

See CI.md for more information about GitHub Actions CI.

r: @liferoad

cc: @riteshghorse

R: @lostluck
For Go.

Thank you very much, all.

cc: @phoerious FYI.

Run PythonDocker PreCommit

Run Python_PVR_Flink PreCommit


[DO NOT MERGE] Add xdg-toplevel-decoration support

This adds support for xdg-toplevel-decoration in rootston. The preferred mode is "client". rootston will accept the client's mode requests.
A new example client is added. When launched, it will be yellow if using server-side decorations and green if using client-side decorations. The client's initial preferred mode can be given as an argument (either "client" or "server"). The client's preferred mode can be toggled by clicking on its surface.
Test plan: try the example
TODO:

[ ] When https://patchwork.freedesktop.org/series/39042/ is merged: reflect wording changes

I like copy-pasta!

Just look at the last 3 commits f you don't want to review the xdg-shell changes.

This PR is ready for review.

This is a replace of KDE's Server-Decoration protocol, right?

It is, yes, developed in cooperation with KDE and Mir.

@SirCmpwn will it be added to wayland-protocols?

We have sent it in for inclusion, yeah.

Superseded by #1053


fix(cli): remove demo when spaces in path

Describe your PR

Closes #2558
Allows spaces to be in the target path of the project on new pizza-app

:tada: This PR is included in version 9.0.1 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


try ruby 3.0

use ruby 3 compatible analytics
upgrade cancancan for ruby 3 compatibility
function argument changes
BigDecimal.round(0) difference
update to work with latest selenium-webdriver

replaced by https://github.com/Energy-Sparks/energy-sparks/pull/3258


Bump major version of glob

Can you please bump the version of glob? I think this repo is the reason why I see deprecations warnings for graceful-fs on nearly every npm install

See
<EMAIL_ADDRESS>/Users/jefe/repos/yargs
├─┬<EMAIL_ADDRESS>│ └──<EMAIL_ADDRESS>├─┬<EMAIL_ADDRESS>│ └─┬<EMAIL_ADDRESS>│   └──<EMAIL_ADDRESS>└─┬<EMAIL_ADDRESS>  ├─┬<EMAIL_ADDRESS>  │ └─┬<EMAIL_ADDRESS>  │   └──<EMAIL_ADDRESS>  └─┬<EMAIL_ADDRESS>    ├─┬<EMAIL_ADDRESS>    │ └─┬<EMAIL_ADDRESS>    │   └──<EMAIL_ADDRESS>    └─┬<EMAIL_ADDRESS>      └─┬<EMAIL_ADDRESS>        ├─┬<EMAIL_ADDRESS>        │ └──<EMAIL_ADDRESS>        └─┬<EMAIL_ADDRESS>          └──<EMAIL_ADDRESS>

npm WARN deprecated<EMAIL_ADDRESS>graceful-fs v3.0.0 and before will fail on node releases >= v7.0. Please update to<EMAIL_ADDRESS>as soon as possible. Use 'npm ls graceful-fs' to find it in the tree.

I can see this is done by https://github.com/mochajs/mocha/commit/c9bcfc1b015c8d15d5fe5159e30818cd02f6a098
but still need them to actually cut a release

That and still it's only v3. @boneskull I feel this is rather urgent. Can you cut a release from this?

@eljefedelrodeodeljefe What's urgent about it?

(a release won't happen until #2231 is merged; this will likely happen before Node.js v7 is released.  if you're in a hurry, you can either suppress the warnings or npm install mochajs/mocha to get the latest source in master)

It's very bad UX for two thirds of npm users seeing deprecations warnings and wondering what is wrong and not being able to do anything.

hmm. Waiting for that PR seems ambitious.

channeling Allen Iverson
I mean, listen, we're sitting here talking about a warning.  Not an error.  Not an error.  Not an error.  But we're talking about a warning.  We're not talking about an error.  We're not actually talking about an error, where it actually matters, but we're talking about a warning.

I've seen maybe 10 issues created for this issue. I am not sure what is so scary about a warning involving a version of Node.js that is not released yet.  Let's just all take a deep breath and realize that the sky will not fall.
We'll do the next release methodically to mitigate the likelihood of actual errors.  We're not going to rush it to suppress a warning.

Yeah that's all fine. Still that makes me question why an integral part of the ecosystem fails to nurture its development by not updating ancient dependencies. The is the pre-stage of issues like left-pad and deeply worry me.

@eljefedelrodeodeljefe this is why

It's pretty obvious at this point that @boneskull

has a plan on when he wants to release
cares about maintaining compatibility for his users

He's described a workaround, I just updated to use it and moved on.
Here are the docs for anyone not familiar with that - ironically using mocha as an example.
https://docs.npmjs.com/files/package.json#github-urls
Comparing this to left-pad is a bit poor though.  The team here deserves a bit of gratitude for the work being put in.


fix: Don't allow group chair to change group parent

Fixes #6037

It turns out that the form is accepted (form.is_valid==True), but form.cleaned_data only contains the fields that are shown to the user - in the case of editing just the parent field, it's an empty dict.

I still think it's the right time to change the view behavior to 403 if there's no field to edit. (such as with your xyzzy example).

Unit testing on github is failing with 'ietf/name/models.py:104: error: Need type annotation for "next_states"  [var-annotated]'. Did something change in the settings?


Pass token in auth/token/… within the POST body instead of using the URL.

When I renew the token I get the warning:
Using a token in the path is unsafe as the token can be logged in many places. Please use POST or PUT with the token passed in via the "token" parameter.
It seems that the request is already a POST request with the token in the body but the token is also in the path.

Can you provide a bit more context? Which functionality/API do you use? When does this happen?

Here the versions that I use:
spring-vault: 2.1.0.RELEASE
vault: 0.11.5

I used this code with autowired VaultOperations:
VaultToken token = VaultToken.of(vaultToken);
VaultTokenResponse response = operations.opsForToken().renew(token);

I fixed it now by doing the API request with RestTemplate because I can use the parameter increment from the Vault API.
https://www.vaultproject.io/api/auth/token/index.html#renew-a-token
So without the increment a default value is used which is too much according to the max_ttl and the token is not renewed. I get the same error when I send the API request with an increment of 36000s.

Thanks! But where do you set the increment parameter in the POST body?

We do not send increment during renewal. This ticket was initially about sending the token within the POST body.
If you require further customizations then subclass VaultTokenTemplate and provide overloads in your code as needed.


As an analysis implementer, I want to see Programming Code Context and Ref elements in the ARS model, as are appropriate

These elements exist as part of the current ARM model. If we decide they are needed for the new ARS model, we will make necessary updates to the model and associated examples.

@bhavinbusa These are the changes that I made for this PBI:

Added the following slot to the AnalysisMethod class:

codeTemplate: an instance of the new ProgrammingCodeTemplate, which is based on the ARM for Define ProgrammingCode element and contains the following slots:

context: specifies the programming language name and version.
parameters: can contain zero or more instances of the new CodeParameter class, each of which includes the name, description and valueSource for any replacement parameters referenced in the programming code.  More work may be needed here, both to specify the format of the parameter references within the code (e.g. are they enclosed in {braces} or [brackets], or prefixed with &ampersands, etc.?) - specification using regular expressions may be any option - and to figure out/constrain what is put in valueSource to indicate where the value of the parameter will come from when the programming code is used within the context of a specific analysis.
templateCode, which can be either text or an instance of the new DocumentRef class (see #43 for details).


Investigate if esbuild would work support our usecase

https://github.com/evanw/esbuild can dramatically speed up build time

[ ] Investigate if it's compatible
[ ] Implement if it is
[ ] Update readme accordingly

As for the time, being NX doesn't provide any builder for esbuild which would make this very complicated. Closing for now.


Custom plugin building blocks

In what area(s)?
/area runtime

/area operator

Ask your question here
Is it possible to load custom extensions into the dapr sidecar, to say provide a custom building block?

Check out pluggable components if you haven’t already :)
https://docs.dapr.io/developing-applications/develop-components/pluggable-components/pluggable-components-overview/


thread 'main' panicked

Hi there. Thanks for a handy tool.
Running just kb-remap
in terminal on macOS 14.3 I get:
thread 'main' panicked at /Users/[username]/.cargo/registry/src/index.crates.io-6f17d22bba15001f/kb-remap-0.3.3/src/hid.rs:56:39: byte index 9 is out of bounds of `` note: run with RUST_BACKTRACE=1 environment variable to display a backtrace
Then running RUST_BACKTRACE=1 kb-remap
I get:
thread 'main' panicked at /Users/[username]/.cargo/registry/src/index.crates.io-6f17d22bba15001f/kb-remap-0.3.3/src/hid.rs:56:39: byte index 9 is out of bounds of
stack backtrace:    0: rust_begin_unwind              at /rustc/82e1608dfa6e0b5569232559e3d385fea5a93112/library/std/src/panicking.rs:645:5    1: core::panicking::panic_fmt              at /rustc/82e1608dfa6e0b5569232559e3d385fea5a93112/library/core/src/panicking.rs:72:14    2: core::str::slice_error_fail_rt    3: core::str::slice_error_fail              at /rustc/82e1608dfa6e0b5569232559e3d385fea5a93112/library/core/src/str/mod.rs:88:9    4: <hashbrown::map::HashMap<K,V,S,A> as core::iter::traits::collect::Extend<(K,V)>>::extend    5: kb_remap::hid::list    6: kb_remap::main note: Some details are omitted, run withRUST_BACKTRACE=fullfor a verbose backtrace.
It used to work fine a month or three ago or so.
I tried reinstalling kb-remap and rust to no effect.
Any input on the error?
Thanks again

Hi, what is the output of hidutil list if you run it in your terminal? This code is trying to parse that and I guess there is a bug in the parsing

Services:
VendorID ProductID LocationID         UsagePage Usage RegistryID  Transport Class                                Product                            UserClass               Built-In
0x5ac    0x27e     0xffffffff80500000 13        12    0x100003e03 USB       AppleMultitouchDevice                Apple Internal Keyboard / Trackpad (null)                  1
0x5ac    0x27e     0xffffffff80500000 65280     11    0x100003dd3 USB       AppleDeviceManagementHIDEventService Apple Internal Keyboard / Trackpad (null)                  1
0x5ac    0x8262    0x0                32        65    0x10000050b (null)    (null)                               (null)                             (null)                  1
0x5ac    0x8600    0x0                1         6     0x100003e14 (null)    AppleUserHIDEventService             TouchBarUserDevice                 AppleUserHIDEventDriver 1
0x5ac    0x8302    0xffffffff80600000 13        5     0x10000051c USB       AppleUserHIDEventService             Touch Bar Display                  AppleUserHIDEventDriver 1
0x0      0x0       0x0                12        1     0x10000020c (null)    AppleACPIButton                      (null)                             (null)                  1
0x5ac    0x0       0x0                65280     23    0x1000002c2 (null)    IOHIDSystem                          (null)                             (null)                  0
0x5ac    0x27e     0xffffffff80500000 1         6     0x100003dd8 USB       AppleHIDKeyboardEventDriverV2        Apple Internal Keyboard / Trackpad (null)                  1
0x5ac    0x8103    0xffffffff80400000 12        1     0x100000510 USB       AppleUserHIDEventService             Headset                            AppleUserHIDEventDriver 1
0x5ac    0x8102    0x0                65298     1     0x100000534 (null)    (null)                               (null)                             (null)                  0
0x0      0x0       0x0                65280     41    0x10000020f (null)    AppleACPILid                         (null)                             (null)                  1
0x0      0x0       0x0                12        1     0x10000020b (null)    AppleACPIButton                      (null)                             (null)                  1

Devices:
VendorID ProductID LocationID         UsagePage Usage RegistryID  Transport Class              Product                            UserClass                 Built-In
0x5ac    0x27e     0xffffffff80500000 65280     11    0x100003dbf USB       AppleUserHIDDevice Apple Internal Keyboard / Trackpad AppleUserUSBHostHIDDevice 1
0x5ac    0x8102    0xffffffff80700000 65298     1     0x1000004e8 USB       AppleUserHIDDevice Touch Bar Backlight                AppleUserUSBHostHIDDevice 1
0x5ac    0x8102    0xffffffff80700000 65280     15    0x1000004ca USB       AppleUserHIDDevice Touch Bar Backlight                AppleUserUSBHostHIDDevice 1
0x5ac    0x8302    0xffffffff80600000 13        5     0x1000004b3 USB       AppleUserHIDDevice Touch Bar Display                  AppleUserUSBHostHIDDevice 1
0x5ac    0x8103    0xffffffff80400000 12        1     0x1000004bc USB       AppleUserHIDDevice Headset                            AppleUserUSBHostHIDDevice 1
0x5ac    0x8262    0xffffffff80300000 32        65    0x100000497 USB       AppleUserHIDDevice Ambient Light Sensor               AppleUserUSBHostHIDDevice 1
0x5ac    0x27e     0xffffffff80500000 65280     3     0x100003dcc USB       AppleUserHIDDevice Apple Internal Keyboard / Trackpad AppleUserUSBHostHIDDevice 1
0x5ac    0x27e     0xffffffff80500000 65280     13    0x100003dca USB       AppleUserHIDDevice Apple Internal Keyboard / Trackpad AppleUserUSBHostHIDDevice 1
0x5ac    0x27e     0xffffffff80500000 1         2     0x100003dc7 USB       AppleUserHIDDevice Apple Internal Keyboard / Trackpad AppleUserUSBHostHIDDevice 1
0x5ac    0x27e     0xffffffff80500000 1         6     0x100003dc2 USB       AppleUserHIDDevice Apple Internal Keyboard / Trackpad AppleUserUSBHostHIDDevice 1
0x5ac    0x8600    0x0                1         6     0x100003e0e (null)    IOHIDResource      TouchBarUserDevice                 (null)                    1

Hmmm this parses fine on my machine 🤔. Some ideas to help further debug:

Possibly this only happens if you have a particular USB device plugged in? Confirm that kb-remap has errored right before you run hidutil list.

Could you get the output exactly without going via your clipboard in case there are some characters processed by your   terminal. For example something like this:
hidutil list > output.txt

And then add output.txt here.

OK. Thanks for helping me out.
Tried kb-remap without any usb connected: same result

Tried kb-remap with a new usb connection and keyboard: same result
hidutil list > output.txt
I generated output both with and without a usb keyboard attached:
hidutil list output - without usb.txt
hidutil list output - usb.txt

Thanks, this was helpful. Fixed in d637bcce3fec15868ec7859816777bd4a4284bfd, will do a release as well.

It works. Excellent.
I'm sorry the line break in bounds of ``  was garbled in the initial post. I should have realised it was the key part.
Thanks a lot for your help.


Limit article list length

Task was split off from https://github.com/urfuwo/hlx-test/issues/279
Motivation: Article lists (which are e.g. being used on dynamically generated author, topic and tag pages like https://main--hlx-test--urfuwo.hlx.page/topics/sustainability don't have an article list limit. They take very long to load and require editors to scroll endlessly.
Full scope task: according to Figma specs (#tbd)

if the total number is < 10, we should show all entries
if the total number is between 11 and 20, we should show 10 and a "Show more" button (see similar logic built into content lists)
if the total number is more than 20, we should introduce pagination
This should be done in for article lists and content-lists to not build the logic twice

Reduced scope task (intermediate solution):

Limit the list to max 24 entries. This creates full rows for rows of 2, rows of 3 and rows of 4

For March 22, the intermedia solution would be an achievable target.

closing this ticket as per discussion with @pahupe  as content task is not required inside github

closing this ticket as per discussion with @pahupe  as content task is not required inside github. Functionality is part of #308


Refactoring "config-defaults" to use Defaultable (for timeout)

Changes
Each type of tektoncd/pipeline implements Defaultable (from knative/pkg), which is meant to be used to set defaults value.
This changes uses this mechanisms to set the default timeout for TaskRuns, instead of putting this mechanisms in the timeout_handler code.
Additionnaly this will help moving to injection-based controller infrastructure as it removes the need to pass the config store to the timeout handler.
/cc @houshengbo @bobcatfish @abayer
Signed-off-by: Vincent Demeester<EMAIL_ADDRESS>Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:

[x] Includes tests (if functionality changed/added)
[ ] Includes docs (if user facing)
[x] Commit messages follow commit message best practices

See the contribution guide
for more details.

@bobcatfish good point, maybe ? :angel:

/lgtm

@vdemeester This is neat refactoring, and it was also the reason I used to ask you about the setDefault.


Feature/demo authorization simplify

:tada: This PR is included in version 0.18.0-rc.1 :tada:
The release is available on:

npm package (@testnet dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Integration Test - Release - 2019/02/13 12:20:23

Auto create for integration test. AnotherAuthorUpdatedArticleFlow

#assign PRMergerTest1

PRMergerTest1 is not a valid GitHub ID, or is not a collaborator on this repo.


Fix the datatype of the returned tensor in Blend function

The Blend() function in TorchVision/Functional.cs converts the returned tensor to the wrong dtype.
Working pytorch code:
import torch
import torchvision.transforms.functional as F

img1 = torch.randn((1,32,32)).to(torch.uint8)
img2 = F.adjust_contrast(img1, 2)
assert(img1.dtype == img2.dtype)

Non working torchsharp code:
using TorchSharp;
using F = TorchSharp.torchvision.transforms.functional;

var img1 = torch.randn(1,32,32).to(ScalarType.Byte);
var img2 = F.adjust_contrast(img1, 2);
Debug.Assert(img1.dtype == img2.dtype);

Process terminated. Assertion failed.
   at TorchSharpExample.Program.Main(String[] args)

The original torchsharp code was introduced in this commit https://github.com/pytorch/vision/commit/e79caddf7490a1cb7f460fe353880fb8b54505a8#diff-497b983ae7c82237c4a0722bc6f6637525e0cdf8369dbd78ee19cf986bffe258R109
Implemented with to(img1.dtype):
def _blend(img1, img2, ratio):
    bound = 1 if img1.dtype.is_floating_point else 255
    return (ratio * img1 + (1 - ratio) * img2).clamp(0, bound).to(img1.dtype)

However the c# version was introduced here https://github.com/dotnet/TorchSharp/blob/418bd160d11f5b149fbfa79d2758a76f4456eab7/src/TorchSharp/TorchVision/Adjustment.cs#L17C81-L17C81
Implemented with to(img2.dtype)
protected Tensor Blend(Tensor img1, Tensor img2, double ratio)
{
    var bound = img1.IsIntegral() ? 255.0 : 1.0;
    return (img1 * ratio + img2 * (1.0 - ratio)).clamp(0, bound).to(img2.dtype);
}

So the torchsharp code has never matched the pytorch implementation for this functions return dtype.

@NiklasGustafsson I can add a unit test for this one.


[etlas] Send proxy settings to coursier

I think the proxy support is enough complete for now with https://github.com/typelead/etlas/pull/8.
Only the documentation would be pending

i think we can close this one by #411


Documentation: Recommend using pipx for installation (PEP 668)

Documentation feedback

Page title: Getting started
Page URL: https://cratedb.com/docs/crate/crash/en/latest/getting-started.html
Source: https://github.com/crate/crash/blob/master/docs/getting-started.rst

When installing as a python package, should we not recommend using pipx instead of pip to avoid dependency conflicts?

Dear Brian,
apologies for the late reply, and thanks for your report. Indeed, I only recently became aware that newer distributions of Linux rightfully deny pip acting upon the system Python installation by default.
This procedure succeeded until Debian Bullseye, but fails with Bookworm.
docker run --rm -it debian:bullseye bash
docker run --rm -it debian:bookworm bash

apt-get update
apt-get install --yes python3-pip
pip install crash

With kind regards,
Andreas.
Error
error: externally-managed-environment

× This environment is externally managed
╰─> To install Python packages system-wide, try apt install
    python3-xyz, where xyz is the package you are trying to
    install.

    If you wish to install a non-Debian-packaged Python package,
    create a virtual environment using python3 -m venv path/to/venv.
    Then use path/to/venv/bin/python and path/to/venv/bin/pip. Make
    sure you have python3-full installed.

    If you wish to install a non-Debian packaged Python application,
    it may be easiest to use pipx install xyz, which will manage a
    virtual environment for you. Make sure you have pipx installed.

    See /usr/share/doc/python3.11/README.venv for more information.

note: If you believe this is a mistake, please contact your Python installation or OS distribution provider. You can override this, at the risk of breaking your Python installation or OS, by passing --break-system-packages.
hint: See PEP 668 for the detailed specification.

OT
If someone reading this, by chance, needs to override this on a system, CI or otherwise ephemeral configuration, or even persistently (don't!), those are two variants, applicable for both the pip and uv package managers.
Disable error: externally-managed-environment by environment variables.
# https://pip.pypa.io/en/stable/cli/pip_install/#cmdoption-break-system-packages
# https://docs.astral.sh/uv/reference/settings/#pip_break-system-packages
PIP_BREAK_SYSTEM_PACKAGES: true
UV_BREAK_SYSTEM_PACKAGES: true

Disable error: externally-managed-environment by configuration.
# https://docs.astral.sh/uv/reference/settings/#pip_break-system-packages
mkdir -p ~/.config/pip
mkdir -p ~/.config/uv
echo -e "[global]\nbreak-system-packages = true" > ~/.config/pip/pip.conf
echo -e "[tool.uv.pip]\nbreak-system-packages = true" > ~/.config/uv/uv.toml

Solution: Using pipx
@bmunkholm: Thanks for suggesting pipx. Which solution would you prefer to advertise? All of them?
apt-get update
apt-get install --yes pipx
pipx ensurepath
pipx install crash

This command variant would also work, but adds verbosity.
pipx run crash --version

This variant would be sensible for system-wide installation, also using pipx.
export PIPX_BIN_DIR=/usr/local/bin
pipx install crash
crash --version

Solution: Using uv
Another promising installation variant would be to use the uv package manager. That would roughly look like this:
docker run --rm -it debian:bookworm bash
apt-get update && apt-get install --yes curl
curl -LsSf https://astral.sh/uv/install.sh | sh
source $HOME/.cargo/env
uv venv
uv pip install crash
uv run crash --version

Note that uv can also be installed using pip or pipx: pipx install uv. ;]
Note that your system will not even need a Python installation. The first invocation of uv venv will transparently download a Python that will be hosted separately from your system. The roundtrip speed is insane.
Including Python installation
time (uv venv; uv pip install crash; uv run crash --version)

real	0m6.025s
user	0m1.930s
sys	0m1.726s

Excluding Python installation
time (uv venv; uv pip install crash; uv run crash --version)

real	0m1.651s
user	0m1.025s
sys	0m0.265s

NB: Python has been installed beforehand using uv python install 3.13.

Hi again. GH-451 implements a minimal update to relevant documentation sections, thanks. Feel free to submit any kinds of fixes yourself, we appreciate improvements of any size and matter.


[serverless-1.32] patch func deploy task for serverless 1.32.0

patch for func-deploy task to use midstream specific client built for 1.32.0

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

:exclamation: No coverage uploaded for pull request base (serverless-1.32@202d9d1). Click here to learn what that means.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@                Coverage Diff                 @@
##             serverless-1.32     #750   +/-   ##
==================================================
  Coverage                   ?   50.95%
==================================================
  Files                      ?      107
  Lines                      ?    14612
  Branches                   ?        0
==================================================
  Hits                       ?     7445
  Misses                     ?     6419
  Partials                   ?      748

Flag
Coverage Δ

e2e-test-runtime-go
24.79% <ø> (?)

unit-tests-ubuntu-latest
49.57% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

merging once images are already public


Replace std::uintXX_t by std::uintXX_fast_t

And enclose instances of large constants with UINT64_C and such.

Should be done with e60a6bc

And 74b5dac.


[CARBONDATA-3218] Fix schema refresh and wrong query result  issues in presto.

Problem:
Schema which is updated in spark is not reflecting in presto. which results in wrong query result in presto.
Solution:
Update the schema in presto whenever the schema changed in spark. And also override the putNulls method in all presto readers to work for null data scenarios.
Be sure to do all of the following checklist to help us incorporate
your contribution quickly and easily:

[ ] Any interfaces changed?

[ ] Any backward compatibility impacted?

[ ] Document update required?

[ ] Testing done
Please provide details on
- Whether new unit test cases have been added or why no new tests are required?
- How it is tested? Please attach test report.
- Is it a performance related change? Please attach the performance test report.
- Any additional information to help reviewers in testing this change.

[ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.

Build Failed  with Spark 2.1.0, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder2.1/2095/

Build Failed  with Spark 2.3.2, Please check CI http://<IP_ADDRESS>:8080/job/carbondataprbuilder2.3/10349/

Build Failed with Spark 2.2.1, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder1/2300/

Build Success with Spark 2.1.0, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder2.1/2099/

Build Success with Spark 2.3.2, Please check CI http://<IP_ADDRESS>:8080/job/carbondataprbuilder2.3/10353/

Build Failed with Spark 2.2.1, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder1/2304/

Build Success with Spark 2.1.0, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder2.1/2106/

Build Success with Spark 2.3.2, Please check CI http://<IP_ADDRESS>:8080/job/carbondataprbuilder2.3/10360/

Build Success with Spark 2.2.1, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder1/2311/

Build Success with Spark 2.1.0, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder2.1/2111/

Build Failed with Spark 2.2.1, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder1/2316/

Build Success with Spark 2.3.2, Please check CI http://<IP_ADDRESS>:8080/job/carbondataprbuilder2.3/10365/

Build Success with Spark 2.1.0, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder2.1/2122/

Build Success with Spark 2.2.1, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder1/2329/

Build Failed  with Spark 2.3.2, Please check CI http://<IP_ADDRESS>:8080/job/carbondataprbuilder2.3/10375/


Add is error to event

When checking out Command, I noticed a few tiny things that could be improved, including a change in Config.swift:

Add isError property to CommandEvent
Add CommandRunning conformance to CommandRunner
Unify switch case statements in CommandEvent utf8String
Update Config.swift to latest Config API

@all-contributors add @natanrolnik for code


New commands agent output files

Fixes #
Changes proposed in this pull request:
Two New Commands
Get-SQLAgentJobOutputfile and
Set-SQLAgentJobOutputfile
How to test this code:
Run against a server with Agent Jobs with or without output files
Run against a server with Agent Jobs with multiple job steps
Check values or changes are valid
Has been tested on minimum requirements:

[ x]  Powershell 3
[ X]  Windows 7
[x ]  SQL Server 2000

Has been tested on maximum requirements:

[ ]  SQL Server vNext
[x ]  Windows 10
[ N/A]  Azure Database

Tests for tester:

[ ] Working/useful help content, including link to command on dbatools web site
[ ] All examples work as advertised
[ ] Does not contain template content
[ ] Does not contain excessive/unnecessary amounts of comments
[ ] Works remotely
[ ] Works locally
[ ] Works on lower versions or throws error specifying version not supported
[ ] Works with named instances
[ ] Works with clustered instances
Not required
[ ] Handles offline/read only databases
Does Not support multiple servers - Not required IMO happy to discuss
[ ] Supports multiple servers (at the command line or piped from Get-SqlRegisteredServerName)
[ ] No un-handled errors which stop the command working with multiple servers

OK all tests pass now!

Tests failing on Get-DbaMaxmemory which is fixed in ie-zeros PR I believe

hey @SQLDBAWithABeard -- there are too many unrelated files in this PR, particularly Get-DbaMaxmemory.Tests.ps1. Please work with @ConstantineK to get them fixed.

Sorry, brain not functioning, files removed

OK - pushing the limit I know but can someone review??

Alright, it seems like there is an issue where changing the case of the filenames is causing both a conflict (and not a conflict when you commit.)
This is a side effect I havent come across before which I need to do some additional research on as it doesnt appear switching file systems (from not case sensitive to case sensitive) was the underlying root cause.
I am going to take the easy way out and create a new branch just pulling the useful changes into it.

closing this one cuz it's boned - @ConstantineK made the proper branch!


UI: Need an option to change language

We can add the change language option in the app settings and reuse the currency selector UX.
We will need an icon for change language.

We can add the change language option in the app settings and reuse the currency selector UX.
We will need an icon for change language.

Spec link
https://xd.adobe.com/view/35f7d5d7-6dd0-44e8-91c3-8ea30c6994b4-60a4/screen/49efc643-9a36-4ea9-adae-454ca7723a5d/
Settings – Currency & Language and related screens

@AliMeer  please review,


Treexy.DriverFusion version <IP_ADDRESS>

[x] Have you signed the Contributor License Agreement?
[x] Have you checked that there aren't other open pull requests for the same manifest update/change?
[x] This PR only modifies one (1) manifest
[x] Have you validated your manifest locally with winget validate --manifest <path>?

[x] Does your manifest conform to the 1.4 schema?

Note: <path> is the name of the directory containing the manifest you're submitting.

Microsoft Reviewers: Open in CodeFlow

@microsoft-github-policy-service agree company="Treexy"

Examining this application in a VM causes the PowerShell window to stop responding.

Examining this application in a VM causes the PowerShell window to stop responding.

You mean the installer or the application? Both work here (tried on three systems).

Works OK in Windows Sandbox too:

Works OK in Windows 10 + 11 Sandbox too:
PowerShell remains responsive; there are no problems.

I think it was an issue with my testing VM's configuration in running this package. After changing a couple of operations, it doesn't freeze.


added channel management APIs

What this PR does / why we need it:
Which issue(s) this PR fixes:

Fixes #171
Special notes for your reviewer:
Does this PR introduce a user-facing change?

This PR adds to the legacy channel management API.

Additional documentation, usage docs, etc.:

Opened a new PR #179 , closing this


we need another keybind

to be able to scroll to change your weapons and plus switching with aimbot on needs to be a little bit smoother and fast especially with duos and squads

wtf is switching with aimbot on

you can bind scroll wheel to next slot...

but only one way, lets say i wanted to bind scroll wheel up and down, i can only do one or the other
On Wednesday, December 19, 2018, 1:14:23 PM CST, silentes<EMAIL_ADDRESS>wrote:
Closed #219.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.


Updates for docling-serve

Here are updates coming for docling-serve.

Updates to the latest docling v2. New input and output formats, better processing, more options.

Richer endpoints. The new options in docling allow for a richer API, for example:

One endpoint with multiple output formats. Which one is returned is controlled by the input payload options (see later)
One endpoint specialized for markdown which returns the markdown as plain text

POST /convert
{
    "document": {
        "markdown": "",
        "docling_document": {},
        "html": "",
    },
    "errors": [],
    "status": "enum",
    "timings": {},
}

POST /convert/markdown
# text/markdown response

Input options. Both endpoint will accept the following payload
{
    "file_source": {
        "base64_string": "string",
        "filename": "string"
    },
    "http_source": {
        "url": "string",
        "headers": {}
    },

    "options": {
        "output_markdown": "bool, default false",
        "output_html": "bool, default false",
        "output_docling_document": "bool, default true",
        "do_ocr": "bool, default true",
        "ocr_engine": "enum (easyocr, tesseract, rapidocr",
        "ocr_lang": "optional[list[str]]",
        "do_table_structure": "bool, default true",
        "include_images": "bool, default ... Embedded page images in docling_document, embedded images in ",
        "images_scale": 2.0
    }
}

Persistent DocumentConverter. To avoid reloading models all the time, we should keep a global DocumentConverter initialized. However, the initialization of the class will set options like which OCR engine, i.e. we want to add a cache for multiple DocumentConverter one for each common set of input options.

Asyncs APIs will require some more thinking depending how you want to work. Two different avenues:

Call to the API initially sends back a token, and there is a websocket endpoint to connect to (authenticating with the token), from where the server can push a "conversion ready" message or directly the result.
Call to the API sends back the token, but then you let the client regularly ping another endpoint until the result (or an error is sent back.

In both cases, you can implement a queue system, with feedback on where you are in the queue, and eventually the progress of the conversion (if/when docling provides such data).
Option 2 is more crude. Option 1 is more evolved, but would allow for real-time feedback (like when you advance in the queue). However it puts more load on the "client" side as it's not anyone who knows how to work with web sockets.
And of course the two are doable simultaneously as anyway the tokens and queue themselves are handled separately.
Anyway, directly to your questions @vishnoianil:

Only expose the aysnc API's to start with.

That's not what I would start with as it's more complicated to consume (from a client perspective). Let's start by offering a sync API, then add async endpoints.

Expose two version of the API, one is for sync and one for async (provide websocket or just simple polling with the job id)

That's where I would go, using both Websockets and "standard" status as it's not that much more implementation.
As we discussed, my current implementation offers two endpoint for processing url(s) and file(s). We seemed to agree to continue it this way. So here is the API map I am proposing (I am adding a v1 prefix to allow for organized non-breaking evolution in the future):

/health -> simple health check for probes
/v1/convert/url -> converts a url or a set of urls (either in a list or comma-separated sting, that's my current behaviour)
/v1/convert/file -> converts a file or a set of files.

In both cases, the client can specify each option available in the docling CLI, plus some outputs options (direct markdown, files in a zip). Options are currently:

from_format (Optional[Union[List[str], str]]): Input format(s) to convert from. Allowed values: docx, pptx, html, image, pdf, asciidoc, md. Defaults to all formats.
to_format (Optional[Union[List[str], str]]): Output format(s) to convert to. Allowed values: md, json, text, doctags. Defaults to Markdown.
ocr (Optional[bool]): If enabled, the bitmap content will be processed using OCR. Defaults to true.
force_ocr (Optional[bool]): If enabled, replace any existing text with OCR-generated text over the full content. Defaults to false.
ocr_engine (Optional[str]): OCR engine to use. Allowed values: easyocr, tesseract_cli, tesseract. Defaults to easyocr.
pdf_backend (Optional[str]): PDF backend to use. Allowed values: pypdfium2, dlparse_v1, dlparse_v2. Defaults to dlparse_v1.
table_mode (Optional[str]): Table mode to use. Allowed values: fast, accurate. Defaults to fast.
abort_on_error (Optional[bool]): If enabled, abort on error. Defaults to false.
return_as_file (Optional[bool]): If enabled, return the output as a file. Defaults to false.

Above is doable almost immediately (give me 1-2 days after we agree, this project is unfortunately not on the top of my list).
In a second phase I would introduce the async endpoints:

/v1/async_convert/url -> converts a url or a set of urls (either in a list or comma-separated sting, that's my current behaviour)
/v1/async_convert/file -> converts a file or a set of files.
/v1/status/{task_id} -> standard feedback (retries implemented client side)
/v1/ws_status/{task_id} -> websocket feedback (real-time feedback)

Waiting for comments/approval to go on.

Asyncs APIs will require some more thinking depending how you want to work. Two different avenues:

Call to the API initially sends back a token, and there is a websocket endpoint to connect to (authenticating with the token), from where the server can push a "conversion ready" message or directly the result.
Call to the API sends back the token, but then you let the client regularly ping another endpoint until the result (or an error is sent back.

In both cases, you can implement a queue system, with feedback on where you are in the queue, and eventually the progress of the conversion (if/when docling provides such data). Option 2 is more crude. Option 1 is more evolved, but would allow for real-time feedback (like when you advance in the queue). However it puts more load on the "client" side as it's not anyone who knows how to work with web sockets. And of course the two are doable simultaneously as anyway the tokens and queue themselves are handled separately.

Makes sense to me. I think sync api -> async-api (with client polling) -> async-api (with websocket), seems like a reasonable evolution plan.

Anyway, directly to your questions @vishnoianil:

Only expose the aysnc API's to start with.

That's not what I would start with as it's more complicated to consume (from a client perspective). Let's start by offering a sync API, then add async endpoints.

Expose two version of the API, one is for sync and one for async (provide websocket or just simple polling with the job id)

That's where I would go, using both Websockets and "standard" status as it's not that much more implementation.

Sounds good. I think major issue with any async apis is the scaling of the apis. Running multiple instances of the docling + api server etc might need some more work. But i believe that's not our day 1 problem at this point of time, but something to keep in back of our mind.

As we discussed, my current implementation offers two endpoint for processing url(s) and file(s). We seemed to agree to continue it this way. So here is the API map I am proposing (I am adding a v1 prefix to allow for organized non-breaking evolution in the future):

/health -> simple health check for probes
/v1/convert/url -> converts a url or a set of urls (either in a list or comma-separated sting, that's my current behaviour)
/v1/convert/file -> converts a file or a set of files.

This looks good to me, minor suggestion, can be use /v1alpha/ instead of /v1, given that these are first cut api's and will need some time to stablize.

In both cases, the client can specify each option available in the docling CLI, plus some outputs options (direct markdown, files in a zip). Options are currently:

from_format (Optional[Union[List[str], str]]): Input format(s) to convert from. Allowed values: docx, pptx, html, image, pdf, asciidoc, md. Defaults to all formats.
to_format (Optional[Union[List[str], str]]): Output format(s) to convert to. Allowed values: md, json, text, doctags. Defaults to Markdown.
ocr (Optional[bool]): If enabled, the bitmap content will be processed using OCR. Defaults to true.
force_ocr (Optional[bool]): If enabled, replace any existing text with OCR-generated text over the full content. Defaults to false.
ocr_engine (Optional[str]): OCR engine to use. Allowed values: easyocr, tesseract_cli, tesseract. Defaults to easyocr.
pdf_backend (Optional[str]): PDF backend to use. Allowed values: pypdfium2, dlparse_v1, dlparse_v2. Defaults to dlparse_v1.
table_mode (Optional[str]): Table mode to use. Allowed values: fast, accurate. Defaults to fast.
abort_on_error (Optional[bool]): If enabled, abort on error. Defaults to false.
return_as_file (Optional[bool]): If enabled, return the output as a file. Defaults to false.

Above is doable almost immediately (give me 1-2 days after we agree, this project is unfortunately not on the top of my list).
In a second phase I would introduce the async endpoints:

/v1/async_convert/url -> converts a url or a set of urls (either in a list or comma-separated sting, that's my current behaviour)
/v1/async_convert/file -> converts a file or a set of files.
/v1/status/{task_id} -> standard feedback (retries implemented client side)
/v1/ws_status/{task_id} -> websocket feedback (real-time feedback)

I think the following url might be more cleaner :
/v1alpha/url/async
/v1alpha/file/async
/v1alpha/status/poll/{task_id}
/v1alpha/status/ws/{tasl_id}
But i think we can take the async api discussion through different issues.

Waiting for comments/approval to go on.

Details for the sync api's looks good to me. so +1 from me.

@vishnoianil Thanks for the feedback. I'm going on with this plan then.

Taking a look at some of the response options for /convert, is there any reason I wouldn't be able to add in responses for different types like text, json and others included in the export commands already?


Remove vim, git and postgresql-client on Docker image

This commit removes the installation of vim, git and pgsql. This will reduce the docker image size when compiled

Thanks @JorgeMartinezG! I'm going to leave those in for now so it helps with debugging and merge this PR in a little while.


Add ServiceMonitor for cloudflared

Resolves #127

Thanks for your contribution! @z0rc I will review this PR and push it to get merged soon! ❤

awesome! I am going to test it on my local machine manually, and I think this pr would be merged soon!


IDs for modules should be unique on define?

From turing.touch, it says turing.dom should that be turing.touch?
https://github.com/alexyoung/turing.js/blob/master/turing.touch.js#L30
From turing.plugins, it says turing.dom shouled that be turing.plugins?
https://github.com/alexyoung/turing.js/blob/master/turing.plugins.js#L26
Thanks for the great articles!

Yes, thanks!

Great learning experience! Thanks for the efforts!


[BUG] Won't Open on Mac

Describe the bug
AME won't open a window on mac, just sits in dock without opening anything.
To Reproduce
For me, all I did was download AME. I tried using the .pkg file and the .dmg file and both did the same. I reinstalled several times but no difference.
Expected behavior
For Apple Music to open.
Screenshots
AME saying it's open in the dock, but no window showing.

Showing all avaliable windows of AME.

All windows that I have opened, AME does not show.

Environment Information

OS: MacOS Sierra (my mac is pretty old) 10.12.6
AME Version: 2.5.0

Additional context
Nothing.
Have you followed the troubleshooting guide and checked for any outstanding/pinned issues that can help?
Troubleshooting guide can be found here.
Yes
Log File
A log file for AME does not exist on my PC, most likely because the app won't even start.

@apr34 i was having this issue, however when i launched the app in terminal mode, i discovered that it had created a folder without permissions, which then caused the app to hang.
to test if you have the same issue as i was having, open this folder in Finder - ~/Library/Caches/Apple Music/ and try opening the 'themes' folder

i did that and it still wont work :/ do u know how i can compile to 3.0.0?

sadly no, i presume the link shared by @coredev-uk should work. If you can't get that working, try right clicking on the application and selecting show package contents - open the contents folder and then open the MacOS folder. if you click on the Apple Music icon that should be present in there, a terminal will launch and will hopefully show you whats wrong.


Resizing app with HtmlElementView halves the FPS in Firefox

Is there an existing issue for this?

[X] I have searched the existing issues
[X] I have read the guide to filing a bug

Steps to reproduce

Create an HtmlElementView with video element
Start your app in Firefox non-fullscreen window
Fullscreen the window
See the FPS drops from >60 to just ~40, until the HtmlElementView is removed from the widget tree

The issue doesn't happen in Chrome.
Expected results
The FPS shouldn't change
Actual results
The FPS drops significantly
Code sample
Code sample
class FpsCounter extends StatefulWidget {
  const FpsCounter({super.key});

  @override
  State<FpsCounter> createState() => _FpsCounterState();
}

class _FpsCounterState extends State<FpsCounter> {
  var fps = 60;

  @override
  Widget build(BuildContext context) {
    return Container(
      alignment: Alignment.topRight,
      margin: const EdgeInsets.all(10) + const EdgeInsets.only(right: 50),
      child: Stack(children: [
        Text(
          fps.toString(),
          style: TextStyle(
            fontSize: 30,
            foreground: Paint()
              ..style = PaintingStyle.stroke
              ..strokeWidth = 4
              ..color = Colors.black,
          ),
        ),
        Text(
          fps.toString(),
          style: const TextStyle(
            fontWeight: FontWeight.bold,
            fontSize: 30,
            color: Colors.white,
          ),
        ),
      ]),
    );
  }

  @override
  void initState() {
    super.initState();

    var frameCount = 0;

    void postFrameCallback() {
      frameCount++;
      setState(() {});
      WidgetsBinding.instance.addPostFrameCallback((_) => postFrameCallback());
    }

    postFrameCallback();

    Timer.periodic(const Duration(seconds: 1), (timer) {
      setState(() => fps = frameCount);
      frameCount = 0;
    });
  }
}

import 'shims/dart_ui.dart' as ui;

main() {
    var showVideo = false;

    // this line might be problematic, because platformViewRegistry is not yet available in public API, you need to import the shims to make it work
    ui.platformViewRegistry.registerViewFactory(
        '1234',
        (_) => VideoElement()
          ..style.border = 'none'
          ..style.height = '100%'
          ..style.width = '100%'
          ..style.pointerEvents = 'none');

    runApp(MaterialApp(
      home: StatefulBuilder(
        builder: (_, setState) {
          return Column(
            children: [
              Expanded(
                child: showVideo
                    ? const HtmlElementView(viewType: '1234')
                    : Container(
                        color: Colors.red,
                        child: const Text('No video'),
                      ),
              ),
              SizedBox(
                height: 50,
                child: Row(children: [
                  MaterialButton(
                    child: Text(showVideo ? 'hide video' : 'show video', style: const TextStyle(color: Colors.white)),
                    onPressed: () {
                      setState(() => showVideo = !showVideo);
                    },
                  ),
                  const FpsCounter()
                ]),
              )
            ],
          );
        },
      ),
    ));
}

// put this in lib/shims/dart_ui.dart
export 'dart_ui_fake.dart' if (dart.library.html) 'dart_ui_real.dart';

// put this in lib/shims/dart_ui_fake.dart
import 'dart:html' as html;

class platformViewRegistry {
  /// Shim for registerViewFactory
  /// https://github.com/flutter/engine/blob/main/lib/web_ui/lib/ui.dart#L72
  static bool registerViewFactory(String viewTypeId, html.Element Function(int viewId) viewFactory) {
    return false;
  }
}

// put this in lib/shims/dart_ui_real.dart
export 'dart:ui';

Screenshots or Video

Screenshots / Video demonstration
The text at the left bottom is the fps counter.
First I start the app fullscreen, then I show that adding HtmlElementView to the widget tree doesn't cause performance drop.
Then I make the window smaller, refresh the page, again add HtmlElementView to the widget tree and then fullscreen the window. You can see that this time FPS drops to 40 and even resizing the window back to its original size doesn't fix it.
https://github.com/flutter/flutter/assets/35242233/9469944e-a5ce-4f13-9653-544e44b55677

Logs
Logs
[Paste your logs here]

Flutter Doctor output
Doctor output
[✓] Flutter (Channel stable, 3.10.2, on Microsoft Windows [Version 10.0.22000.1936], locale pl-PL)
    • Flutter version 3.10.2 on channel stable at C:\tools\flutter
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 9cd3d0d9ff (12 days ago), 2023-05-23 20:57:28 -0700
    • Engine revision b4fb11214d
    • Dart version 3.0.1
    • DevTools version 2.23.1

[✓] Windows Version (Installed version of Windows is version 10 or higher)

[✗] Android toolchain - develop for Android devices
    ✗ Unable to locate Android SDK.
      Install Android Studio from: https://developer.android.com/studio/index.html
      On first launch it will assist you in installing the Android SDK components.
      (or visit https://flutter.dev/docs/get-started/install/windows#android-setup for detailed instructions).
      If the Android SDK has been installed to a custom location, please use
      `flutter config --android-sdk` to update to that location.

[✓] Chrome - develop for the web
    • CHROME_EXECUTABLE = C:\Program Files\Chromium\Application\chrome.exe

[✓] Visual Studio - develop for Windows (Visual Studio Community 2022 17.4.3)
    • Visual Studio at C:\Program Files\Microsoft Visual Studio\2022\Community
    • Visual Studio Community 2022 version 17.4.33205.214
    • Windows 10 SDK version 10.0.22000.0

[!] Android Studio (not installed)
    • Android Studio not found; download from https://developer.android.com/studio/index.html
      (or visit https://flutter.dev/docs/get-started/install/windows#android-setup for detailed instructions).

[✓] IntelliJ IDEA Ultimate Edition (version 2023.1)
    • IntelliJ at C:\Users\Gieted\AppData\Local\JetBrains\Toolbox\apps\IDEA-U\ch-0\231.9011.34
    • Flutter plugin version 74.0.4
    • Dart plugin version 231.9065

[✓] Connected device (3 available)
    • Windows (desktop) • windows • windows-x64    • Microsoft Windows [Version 10.0.22000.1936]
    • Chrome (web)      • chrome  • web-javascript • unknown
    • Edge (web)        • edge    • web-javascript • Microsoft Edge 112.0.1722.68

[✓] Network resources
    • All expected network resources are available.

! Doctor found issues in 2 categories.

Thanks for the detailed report. Seeing the same behavior as reported on Firefox.

 stable, master flutter doctor -v
[!] Flutter (Channel stable, 3.10.1, on macOS 12.2.1 21D62 darwin-x64, locale
    en-GB)
    • Flutter version 3.10.1 on channel stable at
      /Users/dhs/documents/fluttersdk/flutter
    ! Warning: `flutter` on your path resolves to
      /Users/dhs/Documents/Fluttersdk/flutter/bin/flutter, which is not inside
      your current Flutter SDK checkout at
      /Users/dhs/documents/fluttersdk/flutter. Consider adding
      /Users/dhs/documents/fluttersdk/flutter/bin to the front of your path.
    ! Warning: `dart` on your path resolves to
      /Users/dhs/Documents/Fluttersdk/flutter/bin/dart, which is not inside your
      current Flutter SDK checkout at /Users/dhs/documents/fluttersdk/flutter.
      Consider adding /Users/dhs/documents/fluttersdk/flutter/bin to the front
      of your path.
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision d3d8effc68 (35 hours ago), 2023-05-16 17:59:05 -0700
    • Engine revision b4fb11214d
    • Dart version 3.0.1
    • DevTools version 2.23.1
    • If those were intentional, you can disregard the above warnings; however
      it is recommended to use "git" directly to perform update checks and
      upgrades.

[!] Xcode - develop for iOS and macOS (Xcode 12.3)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    ! Flutter recommends a minimum Xcode version of 13.
      Download the latest version or update via the Mac App Store.
    • CocoaPods version 1.11.2

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] VS Code (version 1.62.0)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.21.0

[✓] Connected device (5 available)
    • SM G975F (mobile)       • RZ8M802WY0X • android-arm64   • Android 11 (API 30)
    • Darshan's iphone (mobile)  • 21150b119064aecc249dfcfe05e259197461ce23 •
      ios            • iOS 14.4.1 18D61
    • iPhone 12 Pro Max (mobile) • A5473606-0213-4FD8-BA16-553433949729     •
      ios            • com.apple.CoreSimulator.SimRuntime.iOS-14-3 (simulator)
    • macOS (desktop)            • macos                                    •
      darwin-x64     • Mac OS X 10.15.4 19E2269 darwin-x64
    • Chrome (web)               • chrome                                   •
      web-javascript • Google Chrome 98.0.4758.80

[✓] HTTP Host Availability
    • All required HTTP hosts are available

! Doctor found issues in 1 category.

[!] Flutter (Channel master, 3.11.0-18.0.pre.76, on macOS 12.2.1 21D62
    darwin-x64, locale en-GB)
    • Flutter version 3.11.0-18.0.pre.76 on channel master at
      /Users/dhs/documents/fluttersdk/flutter
    ! Warning: `flutter` on your path resolves to
      /Users/dhs/Documents/Fluttersdk/flutter/bin/flutter, which is not inside
      your current Flutter SDK checkout at
      /Users/dhs/documents/fluttersdk/flutter. Consider adding
      /Users/dhs/documents/fluttersdk/flutter/bin to the front of your path.
    ! Warning: `dart` on your path resolves to
      /Users/dhs/Documents/Fluttersdk/flutter/bin/dart, which is not inside your
      current Flutter SDK checkout at /Users/dhs/documents/fluttersdk/flutter.
      Consider adding /Users/dhs/documents/fluttersdk/flutter/bin to the front
      of your path.
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 0b7415356e (2 days ago), 2023-06-03 07:16:37 -0400
    • Engine revision c838a1b059
    • Dart version 3.1.0 (build 3.1.0-166.0.dev)
    • DevTools version 2.24.0
    • If those were intentional, you can disregard the above warnings; however
      it is recommended to use "git" directly to perform update checks and
      upgrades.

[!] Android toolchain - develop for Android devices (Android SDK version 30.0.3)
    • Android SDK at /Users/dhs/Library/Android/sdk
    ✗ cmdline-tools component is missing
      Run `path/to/sdkmanager --install "cmdline-tools;latest"`
      See https://developer.android.com/studio/command-line for more details.
    ✗ Android license status unknown.
      Run `flutter doctor --android-licenses` to accept the SDK licenses.
      See https://flutter.dev/docs/get-started/install/macos#android-setup for
      more details.

[✓] Xcode - develop for iOS and macOS (Xcode 13.2.1)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Build 13C100
    • CocoaPods version 1.11.2

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] IntelliJ IDEA Ultimate Edition (version 2021.3.2)
    • IntelliJ at /Applications/IntelliJ IDEA.app
    • Flutter plugin version 65.1.4
    • Dart plugin version 213.7228

[✓] VS Code (version 1.62.0)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.29.0

[✓] Connected device (3 available)
    • Darshan's iphone (mobile) • 21150b119064aecc249dfcfe05e259197461ce23 • ios
      • iOS 15.3.1 19D52
    • macOS (desktop)           • macos                                    •
      darwin-x64     • macOS 12.2.1 21D62 darwin-x64
    • Chrome (web)              • chrome                                   •
      web-javascript • Google Chrome 109.0.5414.119

[✓] Network resources
    • All expected network resources are available.

! Doctor found issues in 1 category.

[!] Xcode - develop for iOS and macOS (Xcode 12.3)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    ! Flutter recommends a minimum Xcode version of 13.
      Download the latest version or update via the Mac App Store.
    • CocoaPods version 1.11.2

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] VS Code (version 1.62.0)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.21.0

[✓] Connected device (5 available)
    • SM G975F (mobile)       • RZ8M802WY0X • android-arm64   • Android 11 (API 30)
    • Darshan's iphone (mobile)  • 21150b119064aecc249dfcfe05e259197461ce23 •
      ios            • iOS 14.4.1 18D61
    • iPhone 12 Pro Max (mobile) • A5473606-0213-4FD8-BA16-553433949729     •
      ios            • com.apple.CoreSimulator.SimRuntime.iOS-14-3 (simulator)
    • macOS (desktop)            • macos                                    •
      darwin-x64     • Mac OS X 10.15.4 19E2269 darwin-x64
    • Chrome (web)               • chrome                                   •
      web-javascript • Google Chrome 98.0.4758.80

[✓] HTTP Host Availability
    • All required HTTP hosts are available

! Doctor found issues in 1 category.

Make sure when you are measuring performance to run in --profile or --release mode.

Yes, it also happens both in profile and release mode. Here's demo from a live application:
https://github.com/flutter/flutter/assets/35242233/092d87b7-a7a2-42b0-ac19-7eb1b114125a

I think I might wrongfully diagnose this problem as an issue with HtmlElementView. In fact, even without it, there is a huge, persistent fps drop, after scaling-up Firefox window. This means the problem might be lying inside Flutter Web engine.

I've done some more digging and found a potential cause of this issue, which is this line of code.
When the canvas is resized, it picks a resolution which is 40% bigger than required. For some reason Chrome is able to draw it without much problem, however for Firefox this is absolutely catastrophic, because it now has to draw twice as many pixels than required, which causes a huge performance drop.
You should probably remove this "40% bonus" when resizing the canvas, or at least make sure it's never bigger than the screen resolution.

I'm encountering an issue that I think is related with this +40% in Chrome, when attempting to solve the following issue:

https://github.com/flutter/flutter/issues/129182

(I'm sure both issues are not directly related, but they seem to have to do with the extra space allocated to canvases when the app grows)

I've noticed that the reason why performance drop is so severe to me is that I had hardware acceleration disabled for my browser. With it enabled, I don't see any performance drop. However I think it's still worth considering whenever this issue won't cause some performance problems even with acceleration enabled, when some very complicated graphics would need to be drawn.

@Gieted how did you disable hw acceleration?

Firefox has a bug that makes HW crash when a DisplayPort docking station is connected. I'm not sure if you can disable it manually.

This is related to one or both of the following issues.

https://github.com/flutter/flutter/issues/145563
https://github.com/flutter/flutter/issues/145360

I'd like to continue the discussion of Firefox performance in those issues.