Added environment to create "page" files

Description

Added a submenu to create a new page under UI Builder - New Page
Added a modal where you only enter the name and a yaml for the page is created
Added the new filetype = page
Added a route for .../page/... as a subpage of explorer
Under .../page/... the component PageEditor is loaded

Currently the PageEditor is only a duplicate of the EndpointEditor.
Checklist

[x] Documentation updated if required
[x] Test coverage is appropriate

Checklist Internal

[x] Linear issue linked (e.g. [DIR-XXXX] pull request title)
[x] Has the PR been labeled

@stefan-kracht When you set the type to "page" in the createFile payload in this file there is an error, that I couldn't solve yet.
That's the reason why for now I duplicated everything from the EndpointEditor (like the 62 files under /pageEditor/schema and pageEditor/form in that commit [ad18abe]
Maybe you have an idea or we can take a look together tomorrow.

Thanks for the feedback!
Yes, that is what the error was about, that type: page is not valid when submitting the form. So I need the addition in the backend to continue with further customization of the PageEditor.
I changed the menu as you suggested. I agree that we only need a submenu when we have more than one option in it.

I deleted all the duplicated files from the gateway endpoint and PageEditor on the page URL is for now just an empty component.
I think I can't change the rest like the breadcrumb icon because the data in the payload is type endpoint.
Shall we merge this or wait for the backend to add the filetype=page? What do you think?

Thanks for your review! I cleaned everything up and updated the description of the PR and would be ready to merge.
I am also very happy, that Yassir was able to get the backend change in here already. 🙂


PreCommit Spotless

The following jenkins jobs have been migrated:
https://ci-beam.apache.org/view/PreCommit/job/beam_PreCommit_Spotless_Commit
https://ci-beam.apache.org/view/PreCommit/job/beam_PreCommit_Spotless_Cron
https://ci-beam.apache.org/view/PreCommit/job/beam_PreCommit_Spotless_Phrase
How has it been tested?
How has it been tested?
The job has been tested on Self-hosted GKE runners ubuntu 20.04.
The following test cases are passed:
by creating pull requests with changes in trigger paths
by adding a comment to the PR
by making a push

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

[ ] Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
[ ] Update CHANGES.md with noteworthy changes.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)

See CI.md for more information about GitHub Actions CI.

Run Spotless PreCommit

Workflows here: https://github.com/aleksandr-dudko/beam/actions/workflows/beam_PreCommit_Spotless.yml

Run Spotless PreCommit

Run Spotless PreCommit


rare rewriting crash cost mismatch

cargo run --release --bin=compress experiments/data/rec-fp/iteration=10_2019-07-11T19:49:10.899159/iteration_0.json --fmt=dreamcoder -i1 -a4 -n100
crashes with
thread 'main' panicked at 'assertion failed: `(left == right)`
  left: `78878`,
 right: `69182`:
[fn_0 arity=4: (#0 (#3 (#1 #2)))]
', src/extraction.rs:88:5

looks like a truly absurd invention that it thinks should rewrite to something better than it does.

cargo run --release --bin=compress data/cogsci/nuts-bolts.json -i10 -a4 yields
Cost before: 212456
thread 'main' panicked at 'assertion failed: `(left == right)`
  left: `231646`,
 right: `193266`:
[fn_5 arity=4: (#3 #2 #1 #0)]
', src/extraction.rs:89:9

seems specific to arity 4 not lower arities

we  can track it directly with
cargo run --release --bin=compress data/cogsci/nuts-bolts.json -i1 -a4 --track="(#3 #2 #1 #0)" --follow-track --no-opt

compressive_utility: -445006
global_correction:      590244

Omg absolutely wild. It turns out utility_of_loc_once was going negative meaning each usage of the invention could have negative compressive effect, then it was choosing force-reject all these usages which resulted in a massive positive correction so it could trick the system into thinking it was positive when it was super negative.
Basically it was turning the app penalty of like -104 into a positive a bunch of times haha

ah yes in particular this code was assuming that children by default would Accept and therefore that we would gain their negative utility:
// if it's not in corrected_utils, it must have had no conflicts so we must be switching from accept to reject with no other side effects
                // so we do (reject - accept) = (- util(idx) - 0) = - util(idx)
                // where accept was 0 since it caused no conflicts
                .unwrap_or_else(|| - utility_of_loc_once[*idx])

fixed in ebd7199ab73464fdf51958b00432de078d1aa121


executor, pkg/csource: conditional code inclusion based on options is mess

Current condition code inclusion in executor/common_linux.g based on #if defined(SYZ_FOO) is complete mess, it's almost impossible to get right. Even when it's correct, we have lots of duplicate includes.
We need something better that will automatically strip unused code and includes.

Thinking of this I can't come up with any better solution.
Automatically detecting unused functions/variables/includes/macros on source code level is too hard and fragile.
Doing bisection based on if the code still compiles or not is also hard, and we can't do this at runtime each time. We would need some additional generation step that will figure out everything that needs to be removed for thousands of options combinations.
Closing this for now as unactionable.


allow more triangle styling and better placement

PR Checklist
Please check if your PR fulfills the following requirements:

[ ] Tests for the changes have been added (for bug fixes / features)
[x] Docs have been added / updated (for bug fixes / features)

PR Type
What kind of change does this PR introduce?

[ ] Bugfix
[ x] Feature
[ ] Code style update (formatting)
[ ] Refactoring (no functional changes)
[ ] Documentation content changes

Other information

draw triangle using border-top to permit better size and placement handling.
add a drop-shadow to mimic your design (instead of border-box)
add vars allow styling from outside

Issue Number: N/A

Thanks for the PR 👍.
Had to make few adjustements after merge and I released it v0.0.44 afterwards.

@peterpeterparker There is a case where the triangle is off the toolbar, when you select text at the very left:

I had added this: left: max(var(--stylo-toolbar-triangle-start), calc(var(--stylo-triangle-width) / 2)); to prevent the triangle going to far to the left if --stylo-toolbar-triangle-star is negative

@malteludwig thanks for the ping. this did not work if the position was set in percent - i.e. when the menu set 50% the triangle was not correct positioned neither.
I fixed this edge case in this commit https://github.com/papyrs/stylo/commit/d9b66960863d6bad95129b9ca8c96f9ec0192ce3
Thanks for the ping


tsdframe downsampling gets rid of the columns

Given a tsdframe, df, if I downsample it by df[::5], the columns of the resulting df will be automatically changed to numerical index.

Fixed in #279


Issues building application using angular-google-signin

Hi,
I managed to integrate angular-google-signin to my application but I am currently having some issues to build the application using ng build --prod
I am getting the following output:
fcaldas@node1:~/APP⟫ ng build --prod

Date: 2018-06-26T17:11:22.891Z
Hash: f51372f8373a12d9e55b
Time: 6437ms
chunk {scripts} scripts.3cb258799966decee22a.js (scripts) 142 kB  [rendered]
chunk {0} runtime.6afe30102d8fe7337431.js (runtime) 1.05 kB [entry] [rendered]
chunk {1} styles.cf8f2a72d86ab6663e64.css (styles) 223 kB [initial] [rendered]
chunk {2} polyfills.bb453547f4804812c2d3.js (polyfills) 130 bytes [initial] [rendered]
chunk {3} main.324541d43b39aaa6d019.js (main) 128 bytes [initial] [rendered]

ERROR in : Unexpected value 'GoogleSignInComponent in /home/.../APP/node_modules/angular-google-signin/index.d.ts' declared by the module 'AppModule in /home/.../APP/src/app/app.module.ts'. Please add a @Pipe/@Directive/@Component annotation.

Anyone else have a similar issue? Are we missing something on the tutorial?
Best,

Exactly same problem here. This is the output of my ng --version command.
Angular CLI: 6.1.5
Node: 8.11.4
OS: win32 x64
Angular: 6.1.7
... animations, common, compiler, compiler-cli, core, forms
... http, language-service, platform-browser
... platform-browser-dynamic, router

Package                           Version
-----------------------------------------------------------
@angular-devkit/architect         0.7.5
@angular-devkit/build-angular     0.7.5
@angular-devkit/build-optimizer   0.7.5
@angular-devkit/build-webpack     0.7.5
@angular-devkit/core              0.7.5
@angular-devkit/schematics        0.7.5
@angular/cdk                      6.4.7
@angular/cli                      6.1.5
@angular/material                 6.4.7
@ngtools/webpack                  6.1.5
@schematics/angular               0.7.5
@schematics/update                0.7.5
rxjs                              6.3.2
typescript                        2.7.2
webpack                           4.9.2

I see this as well.

ERROR in : Unexpected value 'GoogleSignInComponent in /Users/paulfleetwood/code/horsemanager/tools/cs-console/console/node_modules/angular-google-signin/index.d.ts' imported by the module 'AppModule in /Users/paulfleetwood/code/horsemanager/tools/cs-console/console/src/app/app.module.ts'. Please add a @NgModule annotation.

`
Angular CLI: 1.7.4
Node: 8.12.0
OS: darwin x64
Angular: 6.1.10
... animations, common, compiler, compiler-cli, core, forms
... http, language-service, platform-browser
... platform-browser-dynamic, router
@angular/cli: 1.7.4
@angular-devkit/build-optimizer: 0.3.2
@angular-devkit/core: 0.3.2
@angular-devkit/schematics: 0.3.2
@ngtools/json-schema: 1.2.0
@ngtools/webpack: 1.10.2
@schematics/angular: 0.3.2
@schematics/package-update: 0.3.2
typescript: 2.7.2
webpack: 3.11.0
`

Solved my problem importing as provider, not as component neither directive.
...
,
    providers: [
        { provide: LOCALE_ID, useValue: 'es-CL' },
        { provide: APP_BASE_HREF, useValue: '/' },
        GoogleSignInComponent
    ],
...


Make it not need root (mostly for test/dev)

Just a nice to have type of thing.
When you cargo run as root or make test-integration, it creates root owned files in ./target. Then you need to be root anytime you do anything with cargo after that, or at least  delete .cargo-lock
I think it needs root to

read the system's authtoken.secret
there's already a flag for specifying this file, so this might be already work around able
there's also a standard user location for a copy of authtoken.secret to exist. maybe i'll make it search there too.
bind to port 53
on macos, it just lets you bind 53 as a user. on linux, you could modify your system to allow it. but maybe the port should configurable.
I don't know enough about dns to know if this type of dns server ever wants to be bound to a non 53 port. Probably only if it's getting queried by another server, not by the end user/os.

meh


老师您好，还有一个问题，就是使用标贝数据训练时，如果我把训练数据集减小至7000条以下，就会报这个错，您能帮我分析一下吗？

Exception ignored in: <function _MultiProcessingDataLoaderIter.del at 0x7f659cdc9dc0>
Traceback (most recent call last):
File "/opt/conda/envs/diffsinger/lib/python3.8/site-packages/torch/utils/data/dataloader.py", line 1328, in del
self._shutdown_workers()
File "/opt/conda/envs/diffsinger/lib/python3.8/site-packages/torch/utils/data/dataloader.py", line 1268, in _shutdown_workers
if not self._shutdown:
AttributeError: '_MultiProcessingDataLoaderIter' object has no attribute '_shutdown'
Traceback (most recent call last):
File "train.py", line 438, in
main()
File "train.py", line 43, in main
mp.spawn(
File "/opt/conda/envs/diffsinger/lib/python3.8/site-packages/torch/multiprocessing/spawn.py", line 230, in spawn
return start_processes(fn, args, nprocs, join, daemon, start_method='spawn')
File "/opt/conda/envs/diffsinger/lib/python3.8/site-packages/torch/multiprocessing/spawn.py", line 188, in start_processes
while not context.join():
File "/opt/conda/envs/diffsinger/lib/python3.8/site-packages/torch/multiprocessing/spawn.py", line 150, in join
raise ProcessRaisedException(msg, error_index, failed_process.pid)
torch.multiprocessing.spawn.ProcessRaisedException:
-- Process 0 terminated with the following error:
Traceback (most recent call last):
File "/opt/conda/envs/diffsinger/lib/python3.8/site-packages/torch/multiprocessing/spawn.py", line 59, in _wrap
fn(i, *args)
File "/home/notebook/code/personal/S9052934/vits/tts/vits_chinese-master/train.py", line 159, in run
train_and_evaluate(
File "/home/notebook/code/personal/S9052934/vits/tts/vits_chinese-master/train.py", line 203, in train_and_evaluate
for batch_idx, (x, x_lengths, bert, spec, spec_lengths, y, y_lengths) in enumerate(train_loader):
File "/opt/conda/envs/diffsinger/lib/python3.8/site-packages/torch/utils/data/dataloader.py", line 359, in iter
return self._get_iterator()
File "/opt/conda/envs/diffsinger/lib/python3.8/site-packages/torch/utils/data/dataloader.py", line 305, in _get_iterator
return _MultiProcessingDataLoaderIter(self)
File "/opt/conda/envs/diffsinger/lib/python3.8/site-packages/torch/utils/data/dataloader.py", line 878, in init
super(_MultiProcessingDataLoaderIter, self).init(loader)
File "/opt/conda/envs/diffsinger/lib/python3.8/site-packages/torch/utils/data/dataloader.py", line 497, in init
self._sampler_iter = iter(self._index_sampler)
File "/home/notebook/code/personal/S9052934/vits/tts/vits_chinese-master/data_utils.py", line 236, in iter
+ ids_bucket * (rem // len_bucket)
ZeroDivisionError: integer division or modulo by zero

 加个这个？我现在不方便操作

我去试试，谢谢老师！


etcd3 api documentation

I work in a primarily java and python organization. We would like to start integrating etcd3 into our system. I understand that etcd3 is still in alpha, but by the time we are done with dev/integration work etcd3 will most likely be production ready.
To that end  I was looking for documentation, similar to v2 api docs ("Communicating with etcd" section at https://coreos.com/etcd/docs/latest/), on v3 api. However, I came up with very few pages, and they require reading proto and go source code. The pages that I'm referring to are: https://github.com/coreos/etcd/blob/master/Documentation/dev-guide/api_reference_v3.md and
https://coreos.com/etcd/docs/latest/rfc/v3api.html
So I'm wondering if there is documentation similar to v2 api docs? In case that reading of source code and protobuf definitions (i.e. .proto files) is required, how stable are definitions and examples/v3 client code?

@eho-eho We have reference doc for v3 api https://github.com/coreos/etcd/blob/master/Documentation/dev-guide/api_reference_v3.md.
If you look for Java client, we have https://github.com/coreos/jetcd.
You can do the same thing for Python. Generate Protocol Buffer files in Python, and write client code in Python.

@eho-eho Proto is the API spec and it is stable. We do not have an API spec for v2, the doc for v2 is example style. We now use etcdctl as example doc: https://github.com/coreos/etcd/blob/master/Documentation/dev-guide/interacting_v3.md
I understand not all people are comfortable reading protos. We are still trying to figure out the best approach here.

@gyuho
Thanks for the pointer to jetcd.
@xiang90
Thanks for the link. I'm OK with reading protos. The only thing that I was wondering about is stability. Don't like when things change under me, that's all.

@eho-eho We will make it backward compatible. So closing this issue.


Use orderedOps in codegen to eliminate the ambiguous generation of commutativity instructions

Several test cases fail on OS X due to the ambiguous code generation of commutativity operators. This patch fixes the issue by using Inst::orderedOps instead of the raw operand vector Inst::Ops in LLVM codegen.
Note that now LLVM code generation of commutativity operators are shaped by the less than operator of souper::Inst. The ordering of operands does not always follow the way LLVM InstCombine canonicalization prefers. For example, the most common canonicalization rule is that if there is a constant in the operand list and the operator is commutative, then place the constant on the RHS. However, the current Souper code will always put the constant on the LHS. This "constant on LHS" ordering is already spread all over the Souper test suite. I can give a patch for fixing that if @regehr agrees that constant should be placed on the RHS.

ref: https://github.com/llvm/llvm-project/blob/948e745270de615cb83bc9c68cdfa4da62925d0f/llvm/lib/Transforms/InstCombine/InstructionCombining.cpp#L23

LGTM thanks!


UI become frozen/unresponsive for a few seconds on the new "read contract" feature

try contract 0x1111111254EEB25477B68fb85Ed929f73A960582 on mainnet, click the "read contract" tab.
we should implement some loading status similar to what was done in the search results to avoid freezing the browser.

assigning it to you @sealer3

I'm not able to reproduce this, but I do see freezing for a few seconds when I click the "Contract" tab. It appears to take some time to load all of the functions and events in the ABI.
It's possible that I fixed it in #1189 by adding a key to the list of ReadFunction components. Before it was showing some duplicate key errors in the console.

hm. agree, just tried it after merging the ethers v6 PR.
I think the issue is in the contract tab then. let me change the bug description :)

sometimes chrome gives me the "tab unresponsible" warning

I've narrowed down the source of the "jank" to the Solidity SyntaxHighlighter element: https://github.com/otterscan/otterscan/blob/6c2ef8ec819d7e68a2b6a502976b797389b860f2/src/execution/address/ContractFromRepo.tsx#L29C9-L29C9
The length of jank in my browser seems to be roughly proportional to the size of the smart contract, and even small contracts (like 3 KB) produce a small amount of jank due to the syntax highlighter.


Make node-fetch optional for use in browser

Hi ! Great library but only for node ? :(
Problem :
Needed an oembed-parser for a website (who grab through a proxy), but can't use that lib due to "node-fetch" required.. (and global.Promise patch)
Proposal :
Is there any way to add a proxy and a node param in extract options, that way we can make that lib available in the browser in minutes !
(made changes in this fork : https://github.com/ghostfly/oembed-parser)
Proxy used : Cors anywhere
Thanks for the work :)

Thank you for your idea. It's time to refactor this lib with more flexible approach.

@Ghostfly theoretically we can make oembed-parser work at the brower side easily, just call native browsers Fetch APIs instead of node-fetch. Browsers' Fetch APIs supports CORS as default.
But nowadays some vendors created a new concept called CORB - Cross-Origin Read Blocking. In the browsers those have this feature, we can still fetch (cross domain) successfully, but the response is alway empty. I've tested on several browsers, it seems only Firefox didn't implemented CORB. Latest versions of Chrome, Chrominum, Opera, Vivaldi did.
So we stop planing to bring oembed-parser to client side, until there is a better approach.

Hum, seems that i'm not impacted since i request on the same domain..
Thanks for trying, will keep my fork updated, np 👍


Boids simulation for some birds

The sparrows already have boids-like flocking behavior, although it's currently a bit difficult to encounter naturally. I will work on expanding this functionality in future updates, like adding it to other birds and implementing flock spawning.


Add MOI Disjunction Set Representation

This adds the MOIDisjunction reformulation method which transforms disjunctions in vector constraints that use DisjunctionSet. This enables us to pass disjunctions directly down to the MOI level.

I will close this in favor of a PR that is based on the right branch.


[release-4.13] CNV-31188: Fix VM clone

📝 Description
Manual backport for #1420 and #1433
🎥 Demo

Please add a video or an image of the behavior/changes

/lgtm

/cherry-pick release-4.12


Invalid example in the doc

Here is the example taken from https://docs.ruuda.nl/rcl/functions/#first-class-functions:
let replicants = [
  { activation_year = 2016, name = "Pris Stratton" },
  { activation_year = 2016, name = "Roy Batty" },
  { activation_year = 2017, name = "Leon Kowalski" },
];
replicants.group_by(r => r.activation_year)
// Evaluates to:
{
  2016 = [
    { activation_year = 2016, name = "Pris Stratton" },
    { activation_year = 2016, name = "Roy Batty" },
  ],
  2017 = [
    { activation_year = 2017, name = "Leon Kowalski" },
  ],
}

However, 2016 and 2017 are not identifiers, thus they can't be used in record form.

Good catch, that should be : instead of =. Thank you for reporting this. This is fixed in 20e61dd628ec447a1c6d1cb816777cb6adabca77, and updated now on the website.


no "LuauTypes" files

You forgot to include the LuauTypes file.

I made this to be loaded using Wally package manager for Roblox documented more here. The LuauTypes is a separate repository. Will add docs here soon.


use huggingface model not support mp4 format

model use zongxiao/whisper-small-zh-CN
occur error
`
Traceback (most recent call last):
File "multiprocessing\process.py", line 314, in _bootstrap
File "multiprocessing\process.py", line 108, in run
File "buzz\transcriber\whisper_file_transcriber.py", line 98, in transcribe_whisper
File "buzz\transcriber\whisper_file_transcriber.py", line 123, in transcribe_hugging_face
File "buzz\transformers_whisper.py", line 194, in transcribe
File "transformers\pipelines\automatic_speech_recognition.py", line 283, in call
return super().call(inputs, **kwargs)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "transformers\pipelines\base.py", line 1294, in call
return next(
^^^^^
File "transformers\pipelines\pt_utils.py", line 124, in next
item = next(self.iterator)
^^^^^^^^^^^^^^^^^^^
File "transformers\pipelines\pt_utils.py", line 269, in next
processed = self.infer(next(self.iterator), **self.params)
^^^^^^^^^^^^^^^^^^^
File "torch\utils\data\dataloader.py", line 631, in next
data = self._next_data()
^^^^^^^^^^^^^^^^^
File "torch\utils\data\dataloader.py", line 675, in _next_data
data = self._dataset_fetcher.fetch(index)  # may raise StopIteration
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "torch\utils\data_utils\fetch.py", line 32, in fetch
data.append(next(self.dataset_iter))
^^^^^^^^^^^^^^^^^^^^^^^
File "transformers\pipelines\pt_utils.py", line 186, in next
processed = next(self.subiterator)
^^^^^^^^^^^^^^^^^^^^^^
File "buzz\transformers_whisper.py", line 53, in preprocess
File "transformers\pipelines\audio_utils.py", line 41, in ffmpeg_read
raise ValueError(
ValueError: Soundfile is either not in the correct format or is malformed. Ensure that the soundfile has a valid audio file extension (e.g. wav, flac or mp3) and is not corrupted. If reading from a remote URL, ensure that the URL is the full address to download the audio file.
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "main.py", line 4, in
File "buzz\buzz.py", line 38, in main
File "PyInstaller\hooks\rthooks\pyi_rth_multiprocessing.py", line 50, in _freeze_support
File "multiprocessing\spawn.py", line 122, in spawn_main
File "multiprocessing\spawn.py", line 135, in _main
File "multiprocessing\process.py", line 329, in _bootstrap
AttributeError: 'NoneType' object has no attribute 'write'
`
but mp3 format is ok

https://github.com/user-attachments/assets/bf31118e-e22f-4b5e-bc58-8db8c45274de

@NightMoonIsland In general .mp4 files work fine with the Huggingface model. I have tested this with several files that have been downloaded from the Youtube. I also tested your model with some Chinese video I downloaded from the Youtube, it also worked.
Any chance you can share this file or some other file that does not work?


aria-labels for previous , next buttons are not localized (always shows in English)

when we set the locale of the control, the UI components (month names etc) gets changed to respective locale however the following aria-labels (a11y) are not get translated and always shows in English
"Previous Month button"
"Next Month button"
Steps to replicate:
Setup the control with locale other than English
registerLocale("es", es);
<DatePicker
             aria-label="select a date"
             selected={startDate}
             onChange={(date) => setStartDate(date)}
             locale="es"
             peekNextMonth
             showMonthDropdown
             showYearDropdown
             dropdownMode="select"
             calendarStartDay={1}
           />

Run it and test with any Screen Reader , it always reads the labels in english

Setting locale only changes date stuff, not labels. For that you need to use the localization props, like nextMonthButtonLabel and others.
Unfortunately some of them doesn't work (see #2430), but some of the do. 😕


Cannot scroll up on iPhones

Having this strange issue on iphones, the same code works fine on android and desktop but it breaks when it comes to iOS.
Whenever I scroll down then lift my finger off the screen and try to scroll up again, it doesn't work. But when I scroll down and scroll up without lifting my finger, it works. This only happens on iOS devices, I have tested it both on safari and chrome, same results.
Tried my best to solve it but seems like I am missing something in here, any help is appreciated.
Thanks in advance. :)

Here's a video.
https://drive.google.com/file/d/1d-DDUK5QcQgrTe8Ma5aR3tZqp5IG6ejJ/view?usp=sharing

@mechaadi, hi, did you manage to fix it?

@YuriyBC Hey, nope. No luck 😕

Any luck - experiencing the exact same issue...my guess is the swipe event is being intercepted by the bottom sheet and doesn't reach the child component?

@mankee10200, i managed to succeed with using only react-swipeable-views lib. You can try it directly

Do you have any code snippet on how you achieved that?

On May 14, 2021 at 7:12 pm,  <YuriyBC @.***)>  wrote:
@mankee10200 (https://github.com/mankee10200), i managed to succeed with using only react-swipeable-views lib. You can try it directly
—
You are receiving this because you were mentioned.
Reply to this email directly,   view it on GitHub (https://github.com/manufont/react-swipeable-bottom-sheet/issues/21#issuecomment-841415864), or   unsubscribe (https://github.com/notifications/unsubscribe-auth/AGKMIWENELC5BAJGRHCPJDLTNVRYDANCNFSM4Z4VUQUA).

Did you manage to solve the problem?

anyone have solution for this ?

Try to define in css:
.ReactSwipeableBottomSheet--closed,
.ReactSwipeableBottomSheet--open {
overflow: hidden !important;
}

Try to define in css:
.ReactSwipeableBottomSheet--closed, .ReactSwipeableBottomSheet--open { overflow: hidden !important; }

I tried this and fixed scroll up but introduce cannot scroll down on the IOS issue. 😥

Anyone can solved this issue. I am also facing this problem, try to solved it but can't fix this.

Any update regarding this issue

Any update regarding this issue

@YuriyBC I am facing the same issue rn. It would be greate if you can share the code of how you solved using only react-swipeable-views lib

@Nandan-Reddy I faced this issue but am not able to fix it so I replace this Library with https://www.npmjs.com/package/react-spring-bottom-sheet it has the same functionality.

@bini-man can you please share the code of how you made the bottom swipeable drawer with https://www.npmjs.com/package/react-spring-bottom-sheet?

Try to define in css:
.ReactSwipeableBottomSheet--closed, .ReactSwipeableBottomSheet--open { overflow: hidden !important; }

This solution can solve the problem that you cannot scroll up after scrolling down to the bottom, but it will also cause another problem. As long as you scroll to the bottom and swipe up again, the entire component will be collapsed. This problem needs to be solved.


README instructions reference a 404 repo

https://github.com/Azure-Samples/IoTDemos/blob/master/RetailDemo/README.md says to clone this:  git clone https://github.com/Teodelas/RetailDemo.git which gives a 404.  I think you want to clone this:  https://github.com/Azure-Samples/IoTDemos.git
@Teodelas most likely

git lfs pull subsequently fails with 404 errors.  My guess is that's because I'm not cloning the repo you think I am.

Good catch.  Fixed.
Thank you!

Good catch.  Fixed.
Thank you!


Improve math Normalization when SQLTemplates is not quote enable

Hi,
If I had a query construct with an SQLTemplate and quote is not enabled (https://github.com/querydsl/querydsl/blob/91b1db4b51ffda5ddc40ce763a7e754e0b52ee7c/querydsl-sql/src/main/java/com/mysema/query/sql/SQLTemplates.java#L64)
and then perform a normal query, with filter condition accepting a list of strings, where string's value is java.util.UUID, then the match normalization would mis-interpret it into expression (https://github.com/querydsl/querydsl/blob/91b1db4b51ffda5ddc40ce763a7e754e0b52ee7c/querydsl-core/src/main/java/com/mysema/query/support/Normalization.java) .
The result therefore is not correct.
SQLQuery select = ..;
select.from(BOOK).where(BOOK.ISBN.in(ids)).list(BOOK.TITLE, BOOK.ISBN);

where ids is a list of UUID
if SQLTemplates.Builder.quote() is set, the normalization issue does not exist.
Sample table structure:
public class BookQDSL extends RelationalPathBase<BookQDSL>
{
    public static final String TABLE_NAME = BookQDSL.TABLE_NAME;

    public final NumberPath<Long> ID;
    public final StringPath TITLE;
    public final StringPath ISBN;

    public BookQDSL()
    {
        this(TABLE_NAME);
    }

    public BookQDSL(String sqlVariable)
    {
        super(BookQDSL.class, sqlVariable, "", TABLE_NAME);
        ID = createNumber(BookQDSL.ID, Long.class);
        TITLE = createString(BookQDSL.TITLE);
        ISBN = createString(BookQDSL.ISBN);
    }
}

Can you please evaluate the normalization in this situation?
As a side note, I think having quote default enabled instead of calling this SQLTemplates.Builder.quote() is preferred. I guess some might want to have QueryDSL to generate the SQL literal, but my guess directly with SQLQuery is more common.
Thanks for the work. Have a great holiday season.
-Chau

@cmhuynh Could you try 3.6.1? I was not able to reproduce this issue anymore.

related to https://github.com/querydsl/querydsl/issues/1224 which was fixed.
Please reopen if the issue persists with 3.6.3.


Adding a test for "ended" event after hotswapping

Webkit has a bug affecting the "ended" event
(https://bugs.webkit.org/show_bug.cgi?id=61336). This test point it
out. Note this bug affect only "old" webkit version since the bug is
fixed. Although, the current Safari version (5.1.2) is still affected.

Alright then, closing pull request.
I leave the gist in case anyone have to fix this bug.


question - How to generate a Xcode vanilla project for a node extension

I want to create a blank project that I can develop from within XCode.
I followed the instructions on installing node-gyp and created a basic binding.gyp file
containing
{
  "targets": [
    {
      "target_name": "binding",
      "sources": [ "src/binding.cc" ]
    }
  ]
}

and then ran
node-gyp configure

I want to somehow be able to develop the extension from XCode (or another IDE if necessary).
I don't understand how to generate the xcode project.
Thanks

Run node-gyp configure -- -f xcode.  You won't be able to use node-gyp build and I'm not 100% sure if xcode puts the binary in the default location of build/Release.


Loading Indicator for video

My issue is about [Mobile]
latest flutter version in stable channel on branch master
When loading photos and videos,
the url text from that source is displayed in text before the data is fully imported
In this case, it may feel like an error and it doesn't look good,
so could you provide an option to change it to a loading widget?

I edited and added pull request.
https://github.com/singerdmx/flutter-quill/pull/469
(When uploading a video file, show video progress indicator & show url text in case of error)


Update Trailer to version 1.3.2

Upgraded to the latest version of Trailer (1.3.2) from 1.3.1

Thanks.


Product sets: wishlist (@W-12301966@)

Description

Types of Changes

[ ] Bug fix (non-breaking change that fixes an issue)
[ ] New feature (non-breaking change that adds functionality)
[ ] Documentation update
[ ] Breaking change (could cause existing functionality to not work as expected)
[ ] Other changes (non-breaking changes that does not fit any of the above)

Breaking changes include:

Removing a public function or component or prop
Adding a required argument to a function
Changing the data type of a function parameter or return value
Adding a new peer dependency to package.json

Changes

(change1)

How to Test-Drive This PR

(step1)

Checklists

General

[ ] Changes are covered by test cases
[ ] CHANGELOG.md updated with a short description of changes (not required for documentation updates)

Accessibility Compliance
You must check off all items in one of the follow two lists:

[ ] There are no changes to UI

or...

[ ] Changes were tested with a Screen Reader (iOS VoiceOver or Android Talkback) and had no issues
[ ] Changes comply with WCAG 2.0 guidelines levels A and AA
[ ] Changes to common UI patterns and interactions comply with WAI-ARIA best practices

Localization

[ ] Changes include a UI text update in the Retail React App (which requires translation)

FYI I plan to do the following:

On the PDP, make sure the Add To Wishlist button for the individual children works with the child (not the parent)
Revert some api config change that was used for debugging/testing


Adding method chaining into the Mail helpers' setters

This is awesome @vitya1!
Could you please sign our CLA so I can merge this? https://github.com/sendgrid/sendgrid-php/blob/master/CONTRIBUTING.md#cla

@thinkingserious I did

Here is big psr-4 refactoring in additional to the main commit

Hi @vitya1,
Could you please resolve the conflicts so that I may test and merge? Thanks!

Hi @thinkingserious. Conflicts have fixed!

As my mind, in case you plan to add pretty big number of classes in lib\Helper\Templates or lib\Helper\Attachments - it's good idea to group helper's classes. But if you just want to extend mail helper functional - better do not move classes for some time. For ex. maybe better to extend existing Attachment class (especially it has only getters and setters)?

@vitya1,
Thanks for taking the time to elaborate your thoughts. Your proposal makes sense.
I would suggest we then just move everything to Helper\Mail. So that if we create a helper for say, contact management, that would go in Helper\ContactManagement

Ok, let I move

Done

@vitya1
Can you please update the dependency to php-http-client to v3.4?
Check out this release: https://github.com/sendgrid/php-http-client/pull/6
Thanks!

@thinkingserious
Sure

@vitya1,
Ah, your tests are failing because of this pull request: https://github.com/sendgrid/php-http-client/pull/9
Could you please update your tests accordingly?
Also, please use:
"sendgrid/php-http-client": "~3.4"
Thanks!

@thinkingserious
I forgot about tests, but bow it's ok.

@vitya1,
It looks like we have some conflicts now. Could you please update the branch? Thanks!

@thinkingserious,
Done. All conflicts are fixed now. Could the branch be merged before the next ones?

@vitya1,
This ticket finally came back up to the top of our queue. It looks like it needs some further conflicts to be resolved. Can you take care of that please? Thanks!

@thinkingserious, it's actually nice.
I resolved conflicts and the branch good to merge

Hi @vitya1,
I've made a pull request on your fork, please take a look and merge if everything looks OK. Thanks!
https://github.com/vitya1/sendgrid-php/pull/1

@thinkingserious, that is actually a pretty important pr. Please look my review and then good to merge

@vitya1,
Changes updated, thanks!

@thinkingserious, I've merged.
Thanks

I'll take care about build checks  troubles

@vitya1,
I just fixed the unit test, could you please review and merge? Thanks!

@thinkingserious, yes I did. Thanks

It would be great to have better naming for the Email class, to better split it from the Mail class. I.e. Contact or EmailAddress would be my preference.

Hello @lode,
I like Contact, but it I think it would cause confusion with our Contacts API.
EmailAddress is good, but we also include the name in the object, that's why we chose the more generic Email, then choosing Mail for the enclosing object.
What do you think @vitya1?

Personalization? ContactPerson? Person? EmailContact?
I understand it might by tricky. But imagine the code review in user land when seeing both Email and Mail. Those are even more vague. I think it is quite important to think well about those names.

@lode,
Great feedback, once again :)
Well, now you've got me thinking the main object should be Email, rather than mail and the previously named Email object should be Contact, and perhaps the user does not need to know about that object.
For example, from a users perspective you would do something roughly like:
// behind the scenes the contact object is created, which performs any validations
$email.AddTo("First Last"<EMAIL_ADDRESS>$email.AddFrom("First Last"<EMAIL_ADDRESS>$email.AddSubject("Hello World")
$email.AddContent("text/plain", "GoodBye World")
if ( $email.Validate() ) {
  $response = $email.Send()
}

BTW, we have an open project to refactor the mail helper here: https://github.com/sendgrid/sendgrid-php/projects
I view this update as an interim iteration.

Ha @thinkingserious that looks like a nice interface, indeed to hide what the API under the hood needs.
There's some more classes in the mail 'helpers' that don't add that much value to working with it. Also more complex ones like attachment could be just a addAttachment('path/to/file') where that method internally figures out what the correct mime type is. (I'm not sure this is the best example as I haven't dived deep into SendGrids interface/API.)
I'm into helping out with making steps into improving things like this, but a bit hesitating as there's also bigger refactors going on, like this PR. Until this one's merged, work on that project seems quite useless. Or otherwise I might not fully understand the expected end result of the project.

@lode,
Thanks again for your contribution.
I'm going to merge this one with the current naming convention and move the naming conversation to the refactor project. I hope you will join us over there as we craft the next iteration of the helper.

Hi @lode
I agree with you. Seems my pr haven't been merged yet, cause there are so much changes.
It's nice idea to hide Email (Contact) into the Mail class. Maybe better even move Email's functional to the Mail (especially that there is setters and getters only in the Email now).

@vitya1,
I'll be merging this one. Apologies on the delay, I'm just powering through the queue :)

@thinkingserious,
No problems. Thank for taking time for this

Hello @vitya1,
This one finally came back to the top of my queue, but it looks like we have some more merge conflicts. Could you please take a look? Thanks!
With Best Regards,
Elmer

Hi @vitya1,
Just checking in with you. Please let me know if there is anything I can do to help move this forward. Thanks!

Hi @thinkingserious,
Sorry for delayed respond. Its a nice news that this pr finally will be merged. I'll fix conflicts soon

No problem @vitya1! It's great to hear from you :)

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.1 out of 4 committers have signed the CLA.:white_check_mark: thinkingserious:x: Victor Sheremetov:x: skytime:x: vitya1Victor Sheremetov, skytime seem not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.

@thinkingserious
Finally, I did it. But I'm not sure about version. It was 6.0.0 in my old commits, actual product version is 5.X.X. Could you check which is correct?

Hello @vitya1,
Thanks!
Please revert any changes relating to versioning. You can leave those as-is. I will go ahead and update those after merge.
Additionally, it looks like there are several people who have contributed commits that have not signed a CLA. I can not merge these changes unless everyone who has committed signs the CLA. This is now much easier, just click on the link and there is short form to fill out. No more downloading and signing. But, each person must have an email attached to their GitHub account. Please advise.
With Best Regards,
Elmer

Hi @vitya1,
Is there anything I can do to help?

Hi @thinkingserious,
These commits were made in some different computers with different git author configurations. And unfortunately I don't access to one of those emails now :(
And that is a trouble with singing.

I can try to cherry pick commits to another branch, but I'm not sure it will be helpful.
How do you think?

Hi @vitya1,
Since we can't merge this as is, I would suggest you create a new PR with your current GitHUb account. I hope that is not too much trouble :(
With Best Regards,
Elmer

Made some comments for this PR @thinkingserious , also I don't see any new tests in this PR, we should be very strict to don't consider any PR without unit, functional or integrations tests (if tests are required of course 😄 )

Thanks for taking the time to review @shonjord!

Hi @vitya1,
I will be incorporating some of your changes to the internals of the new library and you will be credited accordingly. For now, I would greatly appreciate your feedback here.
With Best Regards,
Elmer


Update the contributors command to "contributors.add"

I noticed that npm start "addContributor CompuIves" didn't work, but npm start "contributors.add" does. This updates the documentation for it.

Ah! Thanks! Hard to keep things updated!

Codecov Report

Merging #11 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff          @@
##           master    #11   +/-   ##
=====================================
  Coverage     100%   100%
=====================================
  Files           2      2
  Lines          60     60
  Branches        9      9
=====================================
  Hits           60     60

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d0189f9...216d6b5. Read the comment docs.


[NoQA] Fix the new contributor message

Details

The functionality is broken currently as seen here, and I am working on a refactoring of the predeploy, but cant fit it into my schedule currently as testing takes a long time.
The problem is that the isExpensifyEmployee takes the username of the person who merged the code and not the owner of the PR.
Fixed Issues

This is related to https://github.com/Expensify/Expensify/issues/194440
Tests

QA Steps

See whether a PR from a new contributor gets a welcome message.

I might be able to re-run this job https://github.com/Expensify/App/runs/5869232353?check_suite_focus=true once this is merged to test the PR.

Thank you @madmax330 🙇

Confirmed it worked by checking the action for this PR merge, the username should be mine (mountiny) as the creator of the PR and not of Maxence. All good  👍

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

🚀 Deployed to staging by @madmax330 in version: 1.1.54-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to production by @Julesssss in version: 1.1.54-1 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


Inline single export from current source

Removes need to export {} at the suffix of a output so frequently.

Codecov Report

Merging #259 into master will increase coverage by 0.05%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #259      +/-   ##
==========================================
+ Coverage   94.58%   94.64%   +0.05%
==========================================
  Files          14       14
  Lines        1385     1400      +15
  Branches      132      136       +4
==========================================
+ Hits         1310     1325      +15
  Misses         71       71
  Partials        4        4

Impacted Files
Coverage Δ

src/transformers/exports.ts
93.77% <100%> (+0.34%)
:arrow_up:

src/options.ts
95.8% <100%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 59484c2...41bff37. Read the comment docs.


iptstate: init at 2.2.6

[X] Tested using sandboxing
(nix.useSandbox on NixOS,
or option build-use-sandbox in nix.conf
on non-NixOS)
Built on platform(s)

[ ] NixOS
[ ] macOS
[M] Linux

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[X] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[X] Tested execution of all binary files (usually in ./result/bin/)
[X] Fits CONTRIBUTING.md.

Squashed to change commit title to match naming convention for package updates.
Thanks!


hyperparam_utilities.py link broken in Hyperparameter Tuning README.md

Hyperparameter Tuning README.md hyperparam_utilities.py link broken here.

Thanks for reporting this. I just fixed the related text.


iOS issue Unity renders blank

The game runs fine and communication between unity and react native on the loaded scene works, but for some reason the app is transparent

What exactly do you mean with "transparent"? Can you provide a screenshot?

This approach helped a lot of people with rendering issues in the past. You could give it a try.

Having the same issue as OP here, unfortunately solution attached by @JanOwiesniak has not worked :(
Unity exports correctly
No errors in xcode
No errors in console when inspecting
The rest of the app works fine, the unityview just displays see-through!
React-native: 0.55.3
React-native-unity-view: 1.2.1
Unity: 2018.3.14f1

I solved this by downgrading unity to v1.2.0, and using 2018.1.9f2, but I believe it could work with any pre Unity 2019 versions

What I could figure out is that Unity GL shaders do not render correctly on metal when upgraded to 1.3.3 and also if downgraded to 1.3.0, it works on pre iPhone X devices


Is there someone taking care of this repository?

Pull requests are left unreviewed for months...

This is mostly @KorvinSzanto 's baby. But he's aware that it's important to get the items reviewed. If you need him to review something ping him in Slack and I'm sure he'll give it his attention.


Dropped messages

Environment

VerneMQ Version: 1.4.0
Erlang/OTP version: 20.3
OS: docker image running on Centos 7

Preface
Testing Performance
Scheme:
publisher ---message---> broker ---> subscriber
Publisher generates around 70k rps
HW(Publisher): 4Core, 4RAM, SSD, ~ 30% LOAD
HW(Broker): 8Core, 8RAM, NON-SSD ~ 60% LOAD
HW(Subscriber): 4Core, 4RAM, NON-SSD, ~30% LOAD
Sometimes i have "dropped messages" in logs  like:
[warning] subscriber {[],<<"subscriber">>} dropped 705 messages
Its subscriber hardware problem or it posibble to tune?

@monoton thanks for asking!
The knob to tune for "dropped messages" is max_online_messages. This is a per queue setting (but set globally). When the queue has more than the configured number of messages at some point, it will drop messages. See docs here: https://vernemq.com/docs/configuration/options.html
Setting max_online_messages is not your silver bullet though, as it might load to high RAM requirements.
Now why does the queue fill up in the first place? Yes, maybe slow consumer. Maybe CPU bound by broker. Maybe bandwidth.
I'm interested what and how you are testing exactly. Let's exchange learnings in any case!

Thanks, that tweak helps
But now we have another strange behavior
Publisher send messages to broker around 70k msg/s.
Scheme:
publisher ---message---> broker ---> restreamer ---> broker
Publisher generates around 70k msg/s to some topics
Restreamer gets all messages from this topics, do some business logic and pushing to another topic
When restreamer subscribed and publish with different clientIDs everything right
When restreamer subscribed and publish with same clientIDs both messages are not published without any errors. But if simulate same case without high load - everything fine.
Something happens only on high load.

@monoton what does "published without any error" entail?
You're sending the same amount of messages over one TCP connection (same ClientID), or two TCP (different ClientIDs) connections. I think this is the base explanation for different behaviour under high load in this scenario.

We tryed subscribe and publish in same TCP connection (((
When split this operations by each unique connections - everything works fine. It seems kernel restriction.
Issue can bew closed


Fix typos

@iamkun Would appreciate a review & merge, as this data is being used in https://github.com/vuejs/vetur


User deletion with admin permissions

Linked issue
Resolves: #2122
What kind of change does this PR introduce?

[ ] Bug fix
[ ] New feature
[ X] Refactor
[ ] Docs update
[ ] CI update

What is the current behavior?
Describe the state of the application before this PR. Illustrations appreciated (videos, gifs, screenshots).
Currently it is not possible to delete a user who has super user permissions.
What is the new behavior?
Describe the state of the application after this PR. Illustrations appreciated (videos, gifs, screenshots).

remove check for superuser permission while deleting
only user with permission FULL_ACCESS_USERS_TEAMS_ROLES can delete other user with FULL_ACCESS_USERS_TEAMS_ROLES
send mail to both the users (removed user and removed by), and klaw admin
audit log

Other information
Additional changes, explanations of the approach taken, unresolved issues, necessary follow ups, etc.
Requirements (all must be checked before review)

[ ] The pull request title follows our guidelines
[ ] Tests for the changes have been added (if relevant)
[ ] The latest changes from the main branch have been pulled
[ ] pnpm lint has been run successfully

When I delete a superuser I get a "Delete User Request: SUCCESS" I think it should just say "Delete User: SUCCESS"
As I thought I had to approve the deletion request initially. It also does say this on create as well, "Create User Request: SUCCESS"


create basic screens and navigation

fixes #9
fixes #10
fixes #11

Great to see something tangible!
Writing a Splash-screen related comment here, as I couldn't get the hang where it resides in the code :)
#9 :

Text lines with description can be added beneath the logo to make it consistent with Figma Prototype.

Other than these three bits, the code seems good 👍

I propose removing text from the splash screen in the requirements for now.
Creating splash screen with text is more involved and we still don't have a good name and a logo.

I propose removing text from the splash screen in the requirements for now.
Creating splash screen with text is more involved and we still don't have a good name and a logo.

Okay, this sounds reasonable👍Let's add splash screen text to the backlog then.


update github_actions_runner file for multi commands

Here is Pull request for Trigger multiple PR-Agent command on GitHub Actions pull request event. In this PR, I update script to support multiple PR-Agent command on GitHub Actions. I reuse logic from github_app.py file. I also add [github_workflow] section in configuration.toml file to handle github_actions_runner file. Now This script running fine and handle multi-commands. Here is screenshot for example:

This PR solves #309

This was already addressed:
https://github.com/Codium-ai/pr-agent/commit/a6e65e867fb5b0c93d13203301204edf1a6ebb39
https://github.com/Codium-ai/pr-agent/blob/main/Usage.md#working-with-github-action
In addition, I don't see how the proposed solution would work. 'pr_commands' is a complicated list-like object, not a string.
How can you give it as an environment variable ?

@mrT23
yes, this functionality has already been implemented using GitHub Actions. However, previously, only the review command was executed for every pull request. Recently, there was a request to trigger multiple commands using GitHub Actions. As a result, I have updated the code to accommodate multiple commands. To achieve this, I have switched from using a single string to using a list. Now, GitHub Actions will run two commands: /describe --pr_description.add_original_user_description=true --pr_description.keep_original_user_title=true and /auto_review. Please review and provide feedback.

@sarbjitsinghgrewal
The change in https://github.com/Codium-ai/pr-agent/pull/329 enables the user to automatically run any tool he want, with github action. The default option is to run only the 'review' tool, and I want it to remain this way for now. Users can easily change the default option, to suit their needs.
You suggest here a completely different mechanism, ignoring the previous mechanism, without any reason.
In addition, i don't think your mechanism works, because GitHub action enables giving only plain strings as environment variables, and 'pr_command' is a list, not a string. Have you checked that your mechanism works ?
This PR will not be merged, due to the reasons above. We will think in the future about some refactoring and unification of the auto-command syntax, and may use your PR as reference.

Merge

Invalid

Preparing review...

Preparing review...

Preparing review...

Preparing review...

Preparing review...

Preparing review...

Preparing review...

Preparing review...


[!INCLUDE pre-release-label]???

I see "[!INCLUDE pre-release-label]" in the beginning of the document.
Is this somekinds of place holder? what this means?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: d0a95d02-732d-3324-37ce-d2c1a41131e0
Version Independent ID: bc0366f3-8714-e758-ff02-07837a7751d0
Content: Connect a bot to the Web Chat channel - Bot Service
Content Source: articles/bot-service-channel-connect-webchat.md
Service: bot-service
Product: bot-framework
GitHub Login: @RobStand
Microsoft Alias: kamrani

@KeiroKamioka0000 That's a markup error on our side. The fix should be live in a day or two.


removing commented/incomplete test code

why do we not want this test? i might have missed something


request: option to set attachments folder

Currently, if you have embedded images in your note, they must be in the same directory as the note to be exported.
I ask that an option to set the designated attachments folder is added, so as to not have to move the images to the note directory every time you want to export something.

Thanks for testing this! That's definitely a bug, I was hoping relative paths would resolve correctly. Hopefully this will be fixed by the end of next week.
I think the best approach is to use the same logic for finding images that the Obsidian HTML preview does. If Obsidian has an attachments folder setting, then I'll use that setting too. My vault is a giant flat folder, so I'll have to do some testing with subfolders to see exactly how it works.
Note to self: be careful about images inside embedded notes - paths should resolve relative to the files they're embedded in, and embedded notes should have paths re-resolved to be relative to the file they're embedded in.

FYI, the latest version half works - it uses relative paths, whereas Obsidian seems to pretend everything is in the same folder.
If you have an image in a folder called images which you embed using ![[images/image.png]] in a note in the root of your vault, then exporting the note will work correctly.
I'll still fix this issue soon, just thought I'd mention a temporary workaround.

Closing in favour of #29 which is the same underlying issue

I still have the problem, that pandoc does not find the images when they are in my attachment folder...

Same issue here. Images in separate attachement folder are not found when exported. #29 is also closed but it did not help. Should we wait for #23 now?

Same issue here. Especially  if you have specific assets-folders per subfolder. Still need to move all images to the root of the vault for the plugin to work.

I too need to move the attachments up to the root.

Having yet the same issue

Still having the issue


dependency-injection 1.5.0 incompatible to aurelia-validation 1.4.0

After a fresh npm install my au build is failing due to problems with the compatibililty of the .d.ts files of aurelia-validation 1.4.0 and aurelia-dependency-injection 1.5.0
.../node_modules/aurelia-validation/dist/aurelia-validation.d.ts(436,6): error TS2707: Generic type 'Lazy<TBase, TImpl, TArgs>' requires between 1 and 3 type arguments.

@DrSammyD Do you think you would be able to help out with this?

For now, I recommend reverting to 1.4.0. See the release notes on 1.5.0 which indicate there may be some incompatibilities for TS users. @DrSammyD Can we introduce default type parameter values to address this?

I think, this version indicates breaking changes. Because of that in semver like versioning it should be version 2.0.0. What do you think about.

It's a tricky issue, but we can't pull it and change the version now.
We did have a discussion on this topic on the original PR that improved the typings. Last time we did a major version bump it caused far-reaching issues for several months afterwards (which we thought were probably worse than a potential d.ts break on a minor release). Also, this wasn't a change in any behavior, nor was it a change that affected any standard JavaScript developers. We thought the types were constructed to be backward compatible for TS users (obviously we missed some things). So, all those things combined, and we thought a minor bump would be ok.
@BlischkeFlorian I apologize for the inconvenience. We'll try to make some fixes/improvements, and get another release out soon. Hopefully @DrSammyD and @bigopon can assist.
We'll refrain from doing this sort of change going forward. For Aurelia 2 we've got a monorepo and a number of systems already in place that will help to prevent these types of surprises.

We can add the default generics or take advantage of it to update other repo's less accurate typings. e.g. https://github.com/aurelia/validation/pull/533

totally agree. You're deeper in the framework. Can we bring this live on npm?

Merged the validation PR. I'll aim to get that released today.

@EisenbergEffect any update on releasing plan for this?

I'm going to have to get to it tomorrow (Friday).


ASP.NET MVC DropDownListFor with SelectListItem

Fixes https://github.com/dotnet/AspNetCore.Docs/issues/18841

@Gavin-Paolucci-Kleinow  at least it's documented.

@Rick-Anderson Thanks! That helps.


Cannot make bootstrap-dev-environment within a fresh pyenv

Describe the bug
See title.
System Information (please complete the following information):

OS: [e.g. macOS Sonoma] macOS Sonoma 14.6
Lumigator version [e.g. commit SHA] d0e24bf5e121382e403d6a99dd8a840ae229f8f3

To Reproduce
pyenv virtualenv 3.11 lumigator
pyenv activate lumigator
make bootstrap-dev-environment

Expected behavior
Full setup of a venv environment for development work.
Screenshots
Here's my stdout upon failure:
➜  lumigator git:(main) ✗ pyenv virtualenv 3.11 lumigator
➜  lumigator git:(main) ✗ pyenv activate lumigator
pyenv-virtualenv: prompt changing will be removed from future release. configure `export PYENV_VIRTUALENV_DISABLE_PROMPT=1' to simulate the behavior.
(lumigator) ➜  lumigator git:(main) ✗ make bootstrap-dev-environment
Installing python and configuring venv
bash devtools/shell/bootstrap_python.sh
Darwin setup
UV is available at /Users/compa/.pyenv/shims/uv
Local python found at /Users/compa/.pyenv/shims/python is not the right version - installing from UV
pyenv: uv: command not found

The `uv' command exists in these Python versions:
  3.8.19/envs/langchain-3.8
  3.12.3/envs/langchain-3.12
  langchain-3.8
  langchain-3.12

Note: See 'pyenv help global' for tips on allowing both
      python2 and python3 to be found.
make: *** [.python/cpython-3.11.9-macos-aarch64-none/bin/python3] Error 127
(lumigator) ➜  lumigator git:(main) ✗

Additional context

Have installed pants==0.12.0
Note that I don't have uv installed globally.
I typically develop using a combination of pyenv and poetry.

We now use uv for everything, so this should be resolved!


Quick Start final step yields empty site

When following the Quick Start guide one creates a single content site that is marked as draft. While the guide says to start the server including drafts (-D option) this is not the case for the last step, which just says to run "hugo" to get the site generated. So one is left with basically an empty site and no hint where the post is gone to.
I think it would be good to tell users to either use -D as well or to remove the draft status from the post (or maybe give a warning or info when compiling that states which files are omitted because of the draft state).

I followed the Quick Start Guide as well and also get an empty page as an result.
But changing the draft status does not fix it. Also I get this warning:
found no layout file for "HTML" for "home": You should create a template file which matches Hugo Layouts Lookup Rules for this combination.
I think it would be a better end of the Quick Start Guide to be able to actually see a page. Because right now I am just confused and don't know how to go on.

I have run in the same issues. Any solution @julia-r and @freelon ?

I haven't used the quick start since then - the -D option didn't help? Did you get any errors/warnings?

No errors and no warnings. the -D option didn't help. I am still getting a blank website.

I just reran the quickstart and have no problem with the output. The test server and also the build is working fine. I'm using version 0.60.1 /extended linux/amd64

It worked for me with a newer version (v0.59.1) and a fairly up to date theme ("indigo").

Hi, I also ran to the same issue...

The output of getting started doc is fine.
Then I commit to keep that work and move to other computers
clone and try "hugo server -D" => blank page with below warning.

bus710@aw17:automation$ hugo server -D
Building sites … WARN 2020/03/02 09:29:02 found no layout file for "HTML" for kind "page": You should create a template file which matches Hugo Layouts Lookup Rules for this combination.
WARN 2020/03/02 09:29:02 found no layout file for "HTML" for kind "home": You should create a template file which matches Hugo Layouts Lookup Rules for this combination.
WARN 2020/03/02 09:29:02 found no layout file for "HTML" for kind "page": You should create a template file which matches Hugo Layouts Lookup Rules for this combination.
WARN 2020/03/02 09:29:02 found no layout file for "HTML" for kind "section": You should create a template file which matches Hugo Layouts Lookup Rules for this combination.
WARN 2020/03/02 09:29:02 found no layout file for "HTML" for kind "taxonomyTerm": You should create a template file which matches Hugo Layouts Lookup Rules for this combination.
WARN 2020/03/02 09:29:02 found no layout file for "HTML" for kind "taxonomyTerm": You should create a template file which matches Hugo Layouts Lookup Rules for this combination.

I ran into this too and found that the issue was that I missed this step in the quickstart guide:

Then, add the theme to the site configuration:
echo 'theme = "ananke"' >> config.toml

I skimmed past it because I thought it wasn't relevant - from the layout, it looked like it was under the 'for non-git users' section. I think this could be clearer, tbh.


How to treat different errors in a promise chain

I'm using PromiseKit 6.
I'm trying to find a way to properly structure the following code. The idea is that depending on which step returned the error I want to do a different treatment in the catch block:
firstly {
    return createFileOnAPI()
}.then { file in
    self.upload(file)
}.then {
    self.notifyAPIOfUpload()
}.catch { error in
    self.markAsFailedLocally(error)

    if this was NOT a createFileOnAPI error {
      self.markAsFailedOnServer(error, onSuccess: {
          self.finish()
      }, failure: { error in
          self.finish()
      })
    }
}

One possibility is to return a different type of error for createFileOnAPI(). However, this step that communicates with the API would not return the same type of error as the notifyAPIOfUpload() step which also talks to the API. As a consequence, we would need a little "dance" to extract the underlying error.
firstly {
    return createFileOnAPI()
}.then { file in
    self.uploadFile(file)
}.then {
    self.updateFileOnAPI()
}.catch { error in
    if let error = error as? APICreationError {
        self.markAsFailedLocally(error.underlyingError)
    } else {
        self.markAsFailedLocally(error)

        self.markAsFailedOnServer(error, onSuccess: {
            self.finish()
        }, failure: { error in
            self.finish()
        })
    }
}

That doesn't feel quite right either.
Any recommendation on how to better structure that code?

This is a style question, so there isn't going to be an answer per se. But I think you might find it helpful to consider the options opened by recover.
Also keep in mind that your promise chain needn't be linear. Something like this might be more what you're seeking (pseudocode, probably needs some additional type info to compile):
firstly {
    return createFileOnAPI()
}.then { file in
    self.uploadFile(file).then {
        self.updateFileOnAPI()
    }.recover { error in
        self.markAsFailedOnServer(error, onSuccess: self.finish, failure: self.finish)
        raise error
    }
}.catch { error in
    self.markAsFailedLocally(error)
}

If it's a problem to call markAsFailedOnServer or finish out of order, you can just set a flag in the recover block that you check later in catch.

Thanks. Maybe the following code will do what I need (I turned markAsFailedOnServer into a Promise as well)? But I cannot find a good way to ensure I always throw the recovered error whether markAsFailedOnServer fails or not:
firstly {
    createFileOnAPI().recover { error in
        self.markAsFailedLocally(error)
        throw error
    }
}.then {
    try self.uploadFile(file).then {
        self.updateFileOnAPI()
    }.recover { error in
        self.markAsFailedLocally(error)
        self.markAsFailedOnServer(error).ensure { <---- Invalid conversion from throwing function of type '() throws -> Void' to non-throwing function type '() -> Void'
            throw error
        }
    }
}.catch { _ in
    self.notifyUserOfFailure()
}.finally {
    self.finish()
}

This version seems less clear to me. The error message is correct that you can't throw an error from ensure. It's chain-terminating, so there's no way to add extend the chain past that point.
You'd probably be best off with a flag, as shown below. It's a bit inelegant, but at least the flow is linear and clear.
var reachedServerPhase = false

firstly {
    return createFileOnAPI()
}.then { file in
    reachedServerPhase = true
    return self.uploadFile(file)
}.then {
    self.updateFileOnAPI()
}.catch { error in
    self.markAsFailedLocally(error)
    if reachedServerPhase {
        self.markAsFailedOnServer(error)
    }
    self.notifyUserOfFailure()
}.ensure {
    self.finish()
}

@GarthSnyder thanks, this is very helpful. I agree that the flag is more clear.
Ideally, I want finish() to be called when markAsFailedOnServer has finished, as well (but I don't really care if markAsFailedOnServer has been successful or failed).
Is there a way to refactor the catch to make it more clear:
firstly {
    createFileOnAPI()
}.done {
    successfullyCreatedFileOnAPI = true
}.then {
    try self.uploadFile(self.file)
}.then {
    self.updateFileOnAPI()
}.recover { error -> Promise<Void> in
    self.markAsFailedLocally(error)

    if successfullyCreatedFileOnAPI {
        return self.markAsFailedOnServer(error).done {
            throw error
        }.recover { apiError in
            DDLogError("Failed to mark file as failed on server: \(apiError)")
            throw error
        }
    } else {
        return Promise(error: error)
    }
}.catch { error in
    self.notifyUserOfFailure()
}.finally {
    self.finish()
}

Promise chains are self-sustaining as far as memory references. You don't need to weave them all together. It's fine to start a new, independent chain and just let it do its own error handling. It's no concern of your main path since there is apparently no interaction between the two types of errors.
firstly {
    createFileOnAPI()
}.then {
    successfullyCreatedFileOnAPI = true
    return try self.uploadFile(self.file)
}.then {
    self.updateFileOnAPI()
}.catch { error -> Promise<Void> in
    self.markAsFailedLocally(error)
    if successfullyCreatedFileOnAPI {
        self.markAsFailedOnServer(error).catch { apiError in
            DDLogError("Failed to mark file as failed on server: \(apiError)")
        }
    }
    self.notifyUserOfFailure()
}.finally {
    self.finish()
}

@GarthSnyder but in your suggested example, the finally block will be called before the markAsFailedOnServer completes? I want to make sure it's called after.

Ah, sorry, I had missed your intent there. Given that requirement, your previous code is pretty much correct. The done clause on markAsFailedOnServer needs to come after the recover; otherwise, this code will always log an error. And you don't need to create a pre-errored Promise to return, just throw from within recover
The DDLogError clause (presumably) doesn't need to interact with the main sequence, so you can hang it off a separate fork of the chain if you want to. The only real advantage is that this avoids the awkwardness of either creating a dummy Promise() to return or adding yet another "throw error" to the mix. If the error handling is on its own fork, it can be a catch instead of a recover, which is simpler.
firstly {
    createFileOnAPI()
}.then {
    successfullyCreatedFileOnAPI = true
    return try self.uploadFile(self.file)
}.then {
    self.updateFileOnAPI()
}.recover { error -> Promise<Void> in
    self.markAsFailedLocally(error)
    guard successfullyCreatedFileOnAPI else { throw error }
    let failPromise = self.markAsFailedOnServer(error)
    failPromise.catch { apiError in
        DDLogError("Failed to mark file as failed on server: \(apiError)")
    }
    return failPromise.done { throw error }
}.catch { _ in
    self.notifyUserOfFailure()
}.finally {
    self.finish()
}

In that last example, is the error that will reach the last catch block can be the error I'm interested in (thrown by file creation, or file upload) or it could be the error returned by markAsFailedOnServer()?
}.catch { _ in // <-- what is the error that arrives here?
    self.notifyUserOfFailure()
}.finally {
    self.finish()
}

That's not a problem here, but in case I was using the content of error to notify the user, that could lead to surprises later:
}.catch { error in
    self.notifyUserOfFailure(error)
}.finally {
    self.finish()
}

Yes, it could be the apiError. If an apiError occurs, it will propagate down both forks of the chain.

This is very clear now. Thanks a lot for your help and your answers!


Add code to handle incremental text updates

Nice project! I can't use it yet because I really only need go to type definition, but I'm keeping an eye on this.
Anyway, it would be very good if you could add code to the crate that (optionally) lets users have the incremental text updates handled for them. It's quite a pain to get right yourself because everything is done by line and row indices and they are measured in UTF-16 code points even though the actual text is sent as UTF-8!

Thanks for the kind words and feedback! Have you thought of using codespan and codespan-lsp, by any chance? The latter crate in particular should handle most of the conversions you describe, and it's what I personally use in my own LSP projects, including incremental text updates. With that said, I'm open to potentially "baking in" this sort of functionality into the project as an optional addition.
As for textDocument/definition, I suppose that API addition will have to come in the next few releases. 😄

Both textDocument/definition and textDocument/typeDefinition are on the list in #10. Hopefully I can knock them out over the next several days. If you would like to submit a pull request yourself, of course, that would also be most welcome.

Thanks for the links to codespan - didn't know about that. Since I wrote this I also discovered that rust-analyzer has its LSP stuff as a generic crate. Here's an example. However they don't provide a nice trait like you do, so I'd definitely rather use this if it were complete.

@Timmmm I've just merged in pull request #76, which implements goto declaration, goto definition, and goto type definition support. I hope to have a new release out on Crates.io fairly soon! Feel free to depend directly on the master branch in the meantime, if your project allows it and you're eager to begin iterating. ☺

Ah cool, thanks! I'll give it a go.

@Timmmm Please alert me to any glaring issues come up before the next release! I'll do my best to get in some quick fixes before publishing to Crates.io, if deemed necessary.

@Timmmm Version 0.6.0 has just been published to Crates.io with support for goto declaration, goto definition, and goto type definition.

We are currently depending on an old version of lsp-types (0.68 vs. 0.70, at the time of writing) because codespan-lsp hasn't been updated to support the latest version of lsp-types (see brendanzab/codespan#163). Once this is updated, I think we can update our lsp-types dependency to the latest version and close this issue as invalid.

Closed by #105, which gives us access to the latest lsp-types and therefore compatibility with the latest codespan-lsp.

Finally got around to retrying this - haven't got incremental code changes to work yet (waiting to see what comes of https://github.com/brendanzab/codespan/issues/249), but Go To Definition works perfectly, thanks!

@Timmmm That's fantastic news! Glad it works for you. 🤗 I'm still waiting to see what the future of codespan will actually be, given that @brendanzab has been refactoring the repo quite a bit. I'm sure some solution for your needs will still exist though.


DateEditor setting minDate, maxDate

If we set MinDate = '2018-01-10' of a DateEditor

Before
After

Need to apply this to TypeScript version if problem still there


feat: add new freecodecamp quiz

Checklist:

[x] I have read freeCodeCamp's contribution guidelines.
[x] My pull request has a descriptive title (not a vague title like Update index.md)

I'm not sure this qualifies to be a quiz question, but if it is, should be fun. 😅

At this time we are not looking to add questions for the freeCodeCamp quiz. If that changes, then we will add an announcement in GitHub discussions. 👍

Noted. Thanks


Dinosaur emojis

Two kinds of dinosaurs, T-Rex and Sauropod, have been accepted for inclusion in Unicode 10.0, but there are many more species. Some are hard to distinguish from Dragons 🐉🐲.
Petitions

change.org: Dinosaur
change.org: Dinosaur
change.org: Dinosaur
change.org: Velociraptor
change.org: Dinosaur
change.org: Dinosaur
change.org: Dinosaur
iPetitions: Dino
Emoji Request: Dinosaur

#DinosaurEmoji

While T-Rex and Sauropod have been added to Unicode 10.0 released in mid-2017, there are many other types of dinosaurs. I'll keep this issue open for those.


feat: remove isomorphic-git dependency in favor of local git command

remove isomorphic-git dependency
execute installed git binary to clone a repository
format URL to handle access token

i'm not sure about how i insert token in URL.
I've forgot to put issue number in commit message.

I've forgot to put issue number in commit message.

We conventionally never put issue number in commit message so it's fine 👍 If you want to link the PR to the issue, see Linking a pull request to an issue using a keyword

@allcontributors please add @orlando1108 for code


[BUG] Minimalistic Example

Hi
The Minimalistic Example is wrong because of "from rl4co.envs.routing import TSPEnv, TSPGenerator".
It seems that the TSPGenerator has been removed.
Thank you

Thank you for your reply.
My version is v0.4.0
I mean, in the README file (https://github.com/ai4co/rl4co), the Minimalistic Example code is wrong.
TSPGenerator cannot be found there.
from rl4co.envs.routing import TSPEnv, TSPGenerator
from rl4co.models import AttentionModelPolicy, POMO
from rl4co.utils import RL4COTrainer

# Instantiate generator and environment
generator = TSPGenerator(num_loc=50, loc_distribution="uniform")
env = TSPEnv(generator)

# Create policy and RL model
policy = AttentionModelPolicy(env_name=env.name, num_encoder_layers=6)
model = POMO(env, policy, batch_size=64, optimizer_kwargs={"lr": 1e-4})

# Instantiate Trainer and fit
trainer = RL4COTrainer(max_epochs=10, accelerator="gpu", precision="16-mixed")
trainer.fit(model)

The correct one is:
env = TSPEnv(generator_params={'num_loc': 50})

I have tested the code and here's the conclusion:
The minimalistic example in the main branch is consistent with the code under active development (v0.5.0dev), so I can't say it's incorrect.
However, I think it's better to keep it aligned with the latest released version to reduce such confusions for new users. What do you think, @fedebotu?

Thanks for taking care of this issue @Furffico!
I won't have access to a computer these days, but I agree with you, the current README should be consistent with the latest released version. Given we should release the 0.5.0 soon (i.e.: next week), I guess we can provide @leolyg either a working code for the previous version, or preferably, asking to install the latest dev version from source with pip install -U git+https://github.com/ai4co/rl4co.git(which will be released soon anyways)

Thank you very much. Can't wait to see the new version.


--insecure not working

What is the issue?
Currently registry.ollama.ai has an expired TLS certificate, see #3336
I tried to use --insecure to mitigate the certificate issue, but it is not working:
> ollama pull mistral --insecure
pulling manifest
Error: pull model manifest: Get "https://registry.ollama.ai:443/v2/library/mistral/manifests/latest": tls: failed to verify certificate: x509: certificate has expired or is not yet valid: “ollama.ai” certificate is expired

What did you expect to see?
According to the help, --insecure should be able to ignore the expired certificate:
> ollama pull --help
Pull a model from a registry

Usage:
  ollama pull MODEL [flags]

Flags:
  -h, --help       help for pull
      --insecure   Use an insecure registry

Environment Variables:
      OLLAMA_HOST        The host:port or base URL of the Ollama server (e.g. http://localhost:11434)

Ollama version
0.1.29

Merging with #3336


Very slow loading video

I have an issue / a question (pick one) about Vlc.DotNet.
Generic information

Vlc.DotNet version :  2.2.1
Vlc.DotNet project used : WinForms
libvlc version : x64 + oficial FTP Site 3.0.0
.net version : 4.6
Project language : C#
Project build architecture : x64
Operating system : Windows 10 x64

Summary
I made a small example to run a video, it works, but it takes too long to load the video, about 30 seconds. The official GitHub example also behaves the same way. What could be happening?
vlcControl1.Play(new FileInfo(@"C:\Users\adils\Videos\sample4.avi"));

Does that happen at each run or only the first time? Any antivirus software in place?

Hi Jeremy! No, it always happens, the first and any other that runs. I only have Windows Defender on the machine ...

I downgrade to vlc-2.2.1 its work fine!

and with vlc 3.0.4?

Did you try with the actual VLC?

I tried with vlc 3.0.4, same problem, it took about 15 seconds to start the video. I seem to be a bug in versions higher than vlc 2.2.1

If this is a bug in vlc, you should file a bug in vlc's bug tracker.

I will do! Thanks Jeremy!


Add example for when we might need to ignore an invalid markdown link

This is for discussing our Prosemirror issues in Forestry only

Hey @jeffsee55 : I updated PR with prosemirror extension to support relref links. I plan to add more test coverage for it, that is very important in this scenario.
@DirtyF : it might be useful in-fact to merge this in tina also, if we need to support hugo stuff.

@jpuri I'll let that technical decision up to @ncphillips, for now, Tina doesn't really need this.

Tina doesn't really support Hugo right now, so I would hold off on accepting this.
Eitherway, I wouldn't want to SSG specific stuff in the react-tinacms-editor package, but maybe this could be a good candidate for a plugin?

Yep @ncphillips : plugin is indeed good idea. We can build this kind of extension points in parser and build plugins.
I agree it not idea to add customisations like this to core lib.

Hi @jpuri - I've added the example for shortcodes discussed in Basecamp, let me know if it's not clear what we're after here.

@jeffsee55 , @DirtyF : I have updated the PR with handling for links. The fix uses a REGEX for Hugo links.
I had discussion with Frank about these tags {{% grid %}} but there is apparently no way to fix whitespace issue while keeping markdown also valid.

@jeffsee55 does this PR still need to be open?

No we can close it. Thanks


Review references to HOWTO/install-xxx.md in our repositories

We did a cleanup to move instructions for third party tools to the WHATIS directory. In this process we may have broken links to these files.  All remaining references deleted files in senzing-garage are in deprecated repositories and will not be updated.


Added YouTube URL to bytesize

Added the missing URL.

Duplicate of #1457

This was for demonstration during bytesize. Closing this PR without merge. /FBo


Cannot read property 'install' of undefined

Version
nuxt-i18n: ^6.20.0
nuxt: ^2.0.0
Nuxt configuration

[X] server / ssr
[] spa

Nuxt-i18n configuration
modules: [
    // Doc: https://axios.nuxtjs.org/usage
    '@nuxtjs/axios',
    '@nuxtjs/pwa',
    // Doc: https://github.com/nuxt-community/dotenv-module
    '@nuxtjs/dotenv',
    'nuxt-i18n',
  ],
  i18n: {
    locales: ['en', 'fr', 'es'],
    defaultLocale: 'en',
    vueI18n: {
      fallbackLocale: 'en',
      messages: {
        en: {
          welcome: 'Welcome'
        },
        fr: {
          welcome: 'Bienvenue'
        },
        es: {
          welcome: 'Bienvenido'
        }
      }
    }
  },

Reproduction Link
Steps to reproduce
Follows the basic usage guide using a custom express nuxt example:
What is Expected?
Full page refresh loads the page fine
What is actually happening?
Cannot read property 'install' of undefined

Can you create a repo that reproduces? You could use https://codesandbox.io/s/nuxt-nuxt-i18n-base-template-sty4f as a base.
The crashing line in the screenshot is a Vue.use(VueI18n) call where VueI18n is imported with `import VueI18n from 'vue-i18n' so that's pretty basic stuff that should work unless there is something funky going on in your project.

Before trying nuxt-18n, I tested vue-i18n-next which ask to install vue-i18n@next (last version).
Uninstalling vue-18n and installing with npm i --save vue-i18n (8.22.4) solves the problem.
https://github.com/kazupon/vue-i18n/tags
I noticed that vue-18n changed the maintainer and versions after 8.22.4 requires Vue 3. I suppose that was the issue.
Thanks.


Protractor for hybrid apps

can we use protractor to automate hybrid apps.. browser testing works fine but how to proceed with hybrid apps.

Duplicate of https://github.com/angular/protractor/issues/1940

Hi,

We want to implement Protractor in all the angular projects in our

company CSC so need your support & guidance.. Kindly let us know your team
availability we will have a conference call.

Can you please clarify following

Protractor support for hybrid apps release date
How to work with date picker controls

Regards
Lenin Christopher

We would like to implement it all our angular projects...Can you please clarify following

Protractor support for hybrid apps release date
How to work with date picker controls

We would like to implement protractor all our angular projects.. Please clarify the following

Protractor support for hybrid apps release date (showstopper for us now)
How to work with date picker controls
On switching over to new page the controls in navigated page not getting identified..it displays error as element not found


render_shapes now has a scale parameter

@giovp This now scales the shapes. It however, doesn't adjust the coordinate axis extent. That'd be quite a lot of work since AFAIK we cannot easily use the transformation syntax for this since we need to scale each shape around its centroid and the transformation scale scales the layer.

Codecov Report

Merging #152 (91908e8) into main (f78e0c7) will decrease coverage by 1.36%.
The diff coverage is 100.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #152      +/-   ##
==========================================
- Coverage   76.37%   75.01%   -1.36%
==========================================
  Files          11       11
  Lines        1287     1293       +6
==========================================
- Hits          983      970      -13
- Misses        304      323      +19

Files Changed
Coverage Δ

src/spatialdata_plot/pl/render.py
89.34% <ø> (ø)

src/spatialdata_plot/pl/basic.py
85.63% <100.00%> (ø)

src/spatialdata_plot/pl/render_params.py
100.00% <100.00%> (ø)

src/spatialdata_plot/pl/utils.py
61.03% <100.00%> (-2.71%)
:arrow_down:

This now scales the shapes. It however, doesn't adjust the coordinate axis extent. That'd be quite a lot of work since AFAIK we cannot easily use the transformation syntax for this since we need to scale each shape around its centroid and the transformation scale scales the layer.

I'd approximate it by identifying the largest radius of the collection of the shapes, let's say r, and, by calling k the scale factor, I'd enlarge the extent in each direction by r*k - r.
Notes:

if all the shapes have the same radius then the extent is correct
the approximation above is good enough, to be more precise one could use it only for large datasets, and use the exact (but more expensive) calculation for smaller dataset, described next.
(obvious, but gonna be explicit for completeness) the exact calculation can be obtained by temporarily moving the radius column somewhere else, by scaling the radius column, by calling get_extent() and by replacing the radius column with the old one.
(obvious, but gonna be explicit for completeness) the adjustment of the extent needs to be done only if the shapes are circles


Consul: Restore leader after cluster crash

After a consul cluster crash, like in one described here #566 , consul is unable to re-elect leader. One way to fix that is to remove consul's raft data and restart the consul service.
This is ansible playbook tasked to do that.

It also has to backup and reinstall all the data that is stored in consul... so it's not so easy that you can just wipe all the data. It's really a problem in consul that cannot easily be hacked around in mantl...

afaik removing raft's db will allow consul to reinitialize master election process. In what kind of state the data stored in consul I'll have to check out.

You should only have to remove /var/lib/consul/raft.peers to enable consul leader re-election. Consul Outage Recovery

Should we just have a script that deploys on the nodes that removes the peers and restarts? From an operations standpoint, we can't guarantee that the person who deployed via ansible will be the one who has to recover in the case of a crash.

We could merge this right away if it only removed /var/lib/consul/raft.peers, right? Does we also need to tell Consul to re-join?

consul.json already has retry_after_leave set. That causes Consul to rejoin.

Closing this in favor of #948, which only removes /var/lib/consul/raft/peers.json.


Change name from kcli to kfcli

Hi there,
Any chance to change the app name from kcli to kfcli ? here there is another famous app that already has the same name kcli.
Thanks in advance

The k stands for kafka but I am trying to make it work with AWS Kinesis and SQS.  If I can get an SQS interface I would be willing to change it to qcli or something else.  The 'cli' part of the name doesn't even make sense for what this thing does anyhow.


Update README.md

updating 'broken" render of the file

Coverage remained the same at 97.436% when pulling 22e55e96c098ddb8580ddac6784e543e21ebefe5 on foxmask:patch-1 into 2c0b932668814730853e3992e05743f0c5b4037a on owais:master.

Coverage remained the same at 97.436% when pulling 22e55e96c098ddb8580ddac6784e543e21ebefe5 on foxmask:patch-1 into 2c0b932668814730853e3992e05743f0c5b4037a on owais:master.

Coverage remained the same at 97.436% when pulling 22e55e96c098ddb8580ddac6784e543e21ebefe5 on foxmask:patch-1 into 2c0b932668814730853e3992e05743f0c5b4037a on owais:master.


Fix published npm version

The current version of the package npm looks like it has a rogue typescript file included. This causes issues with type checking locally because it's automatically pulled in as a source file. Can this be republished with the index.ts file?

Hi Will,
Thanks for identifying this, yeah we can definitely clean that up. Thanks!
On Fri, Sep 18, 2020 at 02:17 Will McClellan<EMAIL_ADDRESS>wrote:

The current version of the package npm looks like it has a rogue
typescript file included. This causes issues with type checking locally
because it's automatically pulled in as a source file. Can this be
republished with the index.ts file?
[image: image]
https://user-images.githubusercontent.com/875453/93562924-45530480-f9ca-11ea-917f-a7816165fa1e.png
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/Extrct/react-native-stars/issues/27, or unsubscribe
https://github.com/notifications/unsubscribe-auth/ACMIZ3FFQFK6SVQPXW76EADSGL3OHANCNFSM4RRP4VXA
.

should be resolved now, let me know if you encounter any additional issue. Thanks man 👍


RC - Constructor use a struct

I've thought about that this weekend and I'm wondering if it will really improve readability/usability.
The issue with using a struct is that everywhere in RC's code we'll have things like _struct_name.battery.isCharging() or _struct_name.videokit.playAnimation() etc.
It will make RC's code harder to read.
On os/main.cpp side, it will not make much of a difference. it will just introduce a new variable to pass to RC's constructor, but the variable will need to be created the same way.
One way to fix that would be to make a factory function creating RC, but that usually mean heap, and that's not good.
boost::di could be a good solution, we could investigate.
In any case, this is not urgent, so I'm removing it from v1.0.0

closing for now as not important


Fail to login when password has special chars

First, thank you for this, it's going to be extremely valuable to me (reading on an e-reader is so much more comfortable than on a tablet or a phone)
Now, my problem is my passwords are generated, and, as such, contain special chars.
Right now, two of them are giving me problems: : and $
As a workaround, I escaped $ with \, but I had to modify credentials parsing to change the configured separator into a character which does not appear in my password.
May I suggest adding a --sep option, defaulting to :, so that user can choose whatever char suits best ?
As for $, I think it's more of a shell related problem, and I can't see for now a solution to this (other than escaping it, that is). Do you have any idea how we could overcome this ?
I am not fluent in python, but I can probably submit a PR making this separator option change, what do you think ?

I was going to make a new post, but my error is possibly the same as above.  I use an email address for login and a password that ends with a special character (one of these: !@#$%^&*()).  When I attempt to use the script, I get the following:
[21/May/2018 06:57:57] ** Welcome to SafariBooks! **
[21/May/2018 06:57:57] Logging into Safari Books Online...
[21/May/2018 06:58:00] Retrieving book info...
[21/May/2018 06:58:01] API: Out-of-Session (Authentication credentials were not provided.).

[21/May/2018 06:58:01] Last request done:
	URL: https://www.safaribooksonline.com/api/v1/book/9780134807553/
	DATA: None
	OTHERS: {}

	401
	Server: nginx/1.10.3 (Ubuntu)
	Content-Type: application/json
	strict-transport-security: max-age=3600; includeSubDomains
	Content-Language: en-US
	WWW-Authenticate: Bearer realm="api"
	Allow: GET, HEAD, OPTIONS
	X-Frame-Options: SAMEORIGIN
	x-content-type-options: nosniff
	x-xss-protection: 1; mode=block
	Set-Cookie: api_key=; expires=Thu, 01-Jan-1970 00:00:00 GMT; Max-Age=0; Path=/, logged_in=; expires=Thu, 01-Jan-1970 00:00:00 GMT; Max-Age=0; Path=/, sessionid=n1h1n2qucgwp9sxom4cn3863w9lt8xxk; Domain=.www.safaribooksonline.com; expires=Mon, 04-Jun-2018 11:58:04 GMT; httponly; Max-Age=1209600; Path=/; secure
	Content-Length: 58
	Accept-Ranges: bytes
	Date: Mon, 21 May 2018 11:58:02 GMT
	Via: 1.1 varnish
	Connection: keep-alive
	X-Client-IP: <IP_ADDRESS>
	X-Served-By: cache-atl6236-ATL
	X-Cache: MISS
	X-Cache-Hits: 0
	X-Timer: S1526903882.203840,VS0,VE311
	Vary: Accept, Accept-Language, Authorization, Cookie

{"detail":"Authentication credentials were not provided."}

Ok, I'll work on it.

Is it correct?

Sorry, I should have give an example: if “mail@mail.com:pa$$word” is correctly parsed, then it seems good to me

Ok, updated.
Let me know if the problem is solved. I'll leave this open until then.

No, you know. You have to escape the "$" char: "pa\$\$word"...

That's what I thought, perhaps on note on the README could help future users ? Anyway, thanks for having a look at it

Done with a6bbf31
Thank you!

Hi
password has only @ and it is a corporate account. I am unable to login.

[#] HTTPSConnectionPool(host='learning.oreilly.com', port=443): Max retries exceeded with url: /login/unified/?next=/home/ (Caused by NewConnectionError('<urllib3.connection.HTTPSConnection object at 0x10e9c3190>: Failed to establish a new connection: [Errno 60] Operation timed out'))
[#] Login: unable to reach Safari Books Online. Try again...
[!] Aborting...

Hi
password has only @ and it is a corporate account. I am unable to login.

[#] HTTPSConnectionPool(host='learning.oreilly.com', port=443): Max retries exceeded with url: /login/unified/?next=/home/ (Caused by NewConnectionError('<urllib3.connection.HTTPSConnection object at 0x10e9c3190>: Failed to establish a new connection: [Errno 60] Operation timed out'))
[#] Login: unable to reach Safari Books Online. Try again...
[!] Aborting...

I am getting the same behavior. I have removed special characters from my password.


mainType is missing some types

Hey @Zoha, this library is excellent — thanks so much 💯
Found a few issues while using movier for a pet project.
For the mainType field, currently only movie, series, and seriesEpisode are supported. However, IMDB supports several more types that you can infer by looking at the titles.basics interface.
These include:

video (seems to be mostly animated movies)
tvSpecial
tvMovie
short

All of these are easy to differentiate in the HTML except for short, which the only indication is that short is included in the list of title genres. short is currently filtered out of the output genres, however, so there is no guaranteed way to figure this out with the current output.
Since mainType is such an important field for understanding IMDB's data model, this is imho pretty important. Happy to provide a PR to fix.

It's correct @transitive-bullshit first I wanted to include all these types but, then I think I decided to use just these three types and in the future add a subtype to include these other types, for example, I see short as a movie, and it's more like a category of it.

Honestly, I'd much prefer to stay as close as possible to IMDB's official schemas and data formatting decisions. That will make it easier as things change in the future. If developers want to introduce their own abstractions / derived types outside of the "official" IMDB ones, then that is fine, but it's much easier to maintain software like this imho if you stick to the underlying platform's existing conventions as much as possible.
This is what I've done, for instance, with https://github.com/NotionX/react-notion-x, and it's worked out really well.
Happy to submit a PR.

It makes sence @transitive-bullshit
so plz submit a pr for it if you can
thanks 😊