Update IntegrationTestPlugin.m

The integration_test native plugin is not being correctly registered on iOS when running tests via flutter drive. Adding an
IntegrationTestPlugin instance to registerWithRegistrar method in IntegrationTestPlugin.m.
This plugin instance was previously removed before integration_test was migrated from e2e to prevent an error where the e2e plugin would not exit testing. This does not appear to be an issue with integration_test and my tests exit properly regardless of run with flutter drive or through XCode.
List which issues are fixed by this PR. You must list at least one issue.
https://github.com/flutter/flutter/issues/91668
If you had to change anything in the flutter/tests repo, include a link to the migration guide as per the breaking change policy.
Pre-launch Checklist

[x] I read the Contributor Guide and followed the process outlined there for submitting PRs.
[x] I read the Tree Hygiene wiki page, which explains my responsibilities.
[x] I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
[x] I signed the CLA.
[x] I listed at least one issue that this PR fixes in the description above.
[x] I updated/added relevant documentation (doc comments with ///).
[x] I added new tests to check the change I am making, or this PR is test-exempt.
[x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

I tried to get the hang to reproduce and couldn't, details in https://github.com/flutter/flutter/issues/91668#issuecomment-1454200234
Instead of this one line change, let's actually remove the entire workaround from https://github.com/flutter/plugins/pull/2465.  Meaning remove the exposed -setupChannels: method, and change the +registerWithRegistrar to its original
+ (void)registerWithRegistrar:(NSObject<FlutterPluginRegistrar> *)registrar {
  FlutterMethodChannel *channel = [FlutterMethodChannel methodChannelWithName:kIntegrationTestPluginChannel
                                                              binaryMessenger:registrar.messenger];
  [registrar addMethodCallDelegate:[self instance] channel:channel];
}

Let me know if you would prefer I close this and open my own PR instead.

(Triage) @barringb Do you still have plans to follow-up on the feedback given above? Thanks!

I wound up reverting https://github.com/flutter/plugins/pull/2465 in https://github.com/flutter/flutter/pull/123729, including removing the now-dead code.
@barringb Thank you for your contribution and kicking off this investigation!


python311Packages.opower: 0.0.33 -> 0.0.34

Diff: https://github.com/tronikos/opower/compare/refs/tags/v0.0.33...v0.0.34
Changelog: https://github.com/tronikos/opower/releases/tag/v0.0.34
Description of changes

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 255598 run on x86_64-linux 1

5 packages built:

home-assistant-component-tests.opower
python310Packages.opower
python310Packages.opower.dist
python311Packages.opower
python311Packages.opower.dist


Update microshift-documentation repo to reflect the current upstream status and productization effort

Update microshift-documentation repo to reflect the current upstream status and productization effort

Replaced "CentOS 8 Stream" by "CentOS Stream"
Updated cri-o installation instructions on "CentOS Stream" based on https://github.com/redhat-et/microshift-documentation/pull/174 PR
Removed AIO-container instructions
Using 4.8.0-microshift-2022-04-20-141053 branch name when cloning the repository

Closes: USHIFT-7

/assign @fzdarsky

Removed the requested section

Thanks.
/LGTM


Multi Line CompletionItem (fixes #283)

Added clarification about multi line text to insert and who is responsible for adding contextual indentation.

@svenefftinge,
Thanks for having already signed the Contribution License Agreement. Your agreement was validated by Microsoft. We will now review your pull request.
Thanks,
Microsoft Pull Request Bot

Why should the complexity here be passed to the client when the server has all the necessary info to just include the right identation?

The wording is a little too vague I think. It may seem 'obvious' what 'current indentation' means to you but I don't think it is.
Also I agree with @mickaelistria that its not more of an annoyance than a help in many situations when the client performs 'magic' indentations when the server is capable of generating snippets that are already perfectly spaced.
See a PR and issue that I raised a while ago about this:

https://github.com/Microsoft/language-server-protocol/pull/221
https://github.com/Microsoft/language-server-protocol/issues/83

Why should the complexity here be passed to the client when the server has all the necessary info to just include the right identation?
Because VS Code does it so.

closed in favor of #221


Use utcnow time to test ctime info

When running tests from the future (in a zone at day+1 compared to UTC time), the test_info test fails with:
>       assert gcs.created(a).isoformat().startswith(today)
E       AssertionError: assert False

This fix uses the UTC date with datetime.datetime.utcnow().date() instead of datetime.date.today() since it has to be compared with ctime info that seems to be UTC as well.

How many times has this been run without hitting midnight :)


Please invite me to the community

Invite me to the Surpath Community.

Name: Bryson

Discord Username(if exists): Bryson

Additional Context: To learn more about open source

Hello, thanks for your interest to join in our community. I'll put this On hold for now while the GitHub Actions isn't release yet.

Hi bryson, thanks for your interest in our community. We know each other, and yeah only people from Philippines are allowed to join and be part of the community. See you in EddieHub Community, happy to assist you there :)


Release Google.Cloud.Storage.V1 version 4.7.0

Changes in this release:
No API surface changes; just dependency updates.

@jskeet I lost your approval when I pushed the commit fixing the snippets and tests that were using the obsolete DateTime properties. If you can stamp again we can release.

Just to check: did you rerun all the integration tests? I'm just worried that with the DateTimeOffset issues we've been seeing in the other repo, we might have problems...

Just to check: did you rerun all the integration tests? I'm just worried that with the DateTimeOffset issues we've been seeing in the other repo, we might have problems...

Yes, that's why it took me so long, I reran everything, and was green on local.

Created release for Google.Cloud.Storage.V1-4.7.0


Fixed the SafeString check

Use Ember.String.isHTMLSafe() to do the SafeString check as discussed here https://github.com/emberjs/ember.js/issues/13318

Cool, thanks!


[SYSTEMML-1470] Reset MLContext stats between runs

Update ScriptExecutor to reset stats between executions if needed.
Update resetGlobalFlags to set DMLScript.STATISTICS_COUNT using
DMLOptions.defaultOptions.statsCount rather than hardcoded value.

Refer to this link for build results (access rights to CI server needed):
https://sparktc.ibmcloud.com/jenkins/job/SystemML-PullRequestBuilder/1462/

Thank you for reviewing @nakul02!


slight issue

Hi,
Getting following after i start the exe.
Any help would be much appreciated.

[DG0] wsapi.go:551:onEvent() error unmarshalling READY event, json: cannot unmarshal number into Go struct field ReadState.read_state.last_message_id of type string

I've tried finding the cause of the error myself, its related to the use of the discord session. Lines 163, 165, 174 and 208 are probrably the ones that need diving into.

redo everything (del everything before)
and then if it still dosent work show us a picture of the config file (censor email and password!!!!!!)
or contact me directly in discord:
drache GRaf#8675
if the maker dosent make a discord server i will do it


Design how data will keep in sync between Dataverse and the ADO work items

Release Planner needs the information in the different ADO work items in order to make decision in the UI (logic, information, etc). Although this data is in Dataverse, it is also in ADO. We want it to be in ADO so people can edit it accordingly. If such an update happens, how will the Release Planner will keep that information in sync?
Same is true for Service Tree information. If a service or product name changes, we want to make sure that the change is consumed in both Dataverse and the ADO workitems

We can use an automated cloudflow that gets triggered when work item is created or updated.

@maririos I believe we can close this now since we have cloud flows in place to sync the data between ADO and Dataverse.


The UltimateDifferentViewTypeAdapter sample does not bind the data in the list or harcode data either

As you can see in the image the sample does not work. The data is the same at the layouts. Don't bind the values in the list. (sorry for bad english)

The noBindViewHolder method of the multi adapter needs to be erased, it is overwriting the bindViews of the SimpleBinder


German localization

Hello, we use this tool on all Macs in our company. We would like to change the uptime text, as it is here recommended to restart every day. If I set the number to zero or one via Jamf, then unfortunately the German is wrong. Can we change this somehow, or would you have to do it?
It should say : Dein Administrator empfiehlt Dir einen Neustart täglich durchzuführen
Thank you for this great app

You can add the property "Update Text" and write whatever you want.

Okay thanks for flagging this! So if I understand correctly this is only an issue when the restart is recommended at a daily basis and not every more than 1 days? In other words, setting UptimeDaysLimit to 1 shows an incorrect sentence and correct when set to >1? Which sentence of the three provided here is the best?

Hi,
that's exactly how it is. If a 1 or a 0 in UptimeDaysLimit it says :
Dein Administrator empfiehlt Dir einen Neustart alle Tag.
It should be :
Dein Administrator empfiehlt Dir einen Neustart jeden Tag
Or better :
Dein Administrator empfiehlt Dir einen täglichen Neustart.
When its set to >1 it is correct.
Greetings
Von: Jordy Witteman @.>
Datum: Mittwoch, 13. November 2024 um 23:05
An: root3nl/SupportApp @.>
Cc: Thrun, Adam - Externer Mitarbeiter @.>, Author @.>
Betreff: [EXT] Re: [root3nl/SupportApp] German localization (Issue #199)
Sie erhalten nicht häufig E-Mails von @.*** Erfahren Sie, warum dies wichtig isthttps://aka.ms/LearnAboutSenderIdentification
Okay thanks for flagging this! So if I understand correctly this is only an issue when the restart is recommended at a daily basis and not every more than 1 days? In other words, setting UptimeDaysLimit to 1 shows an incorrect sentence and correct when set to >1? Which sentence of the three provided here is the best?
—
Reply to this email directly, view it on GitHubhttps://github.com/root3nl/SupportApp/issues/199#issuecomment-2474919006, or unsubscribehttps://github.com/notifications/unsubscribe-auth/BMXK3NPBNNXHURJZTIZMDLD2APEKRAVCNFSM6AAAAABRKS7CTGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDINZUHEYTSMBQGY.
You are receiving this because you authored the thread.Message ID: @.***>

@bskhsup013 thanks for clarifying! In Slack other people agree on this translation: Dein Administrator empfiehlt Dir, täglich einen Neustart durchzuführen.
For now that's what I will add unless that doesn't make sense. We can ship this in a bug fix release 2.6.1

Yes , it doesn’t make any sense. I know , but that’s what they want.
Many thanks 😊
Von: Jordy Witteman @.>
Datum: Donnerstag, 14. November 2024 um 12:02
An: root3nl/SupportApp @.>
Cc: Thrun, Adam - Externer Mitarbeiter @.>, Mention @.>
Betreff: [EXT] Re: [root3nl/SupportApp] German localization (Issue #199)
Sie erhalten nicht häufig E-Mails von @.*** Erfahren Sie, warum dies wichtig isthttps://aka.ms/LearnAboutSenderIdentification
@bskhsup013https://github.com/bskhsup013 thanks for clarifying! In Slack other people agree on this translation: Dein Administrator empfiehlt Dir, täglich einen Neustart durchzuführen.
For now that's what I will add unless that doesn't make sense. We can ship this in a bug fix release 2.6.1
—
Reply to this email directly, view it on GitHubhttps://github.com/root3nl/SupportApp/issues/199#issuecomment-2476046440, or unsubscribehttps://github.com/notifications/unsubscribe-auth/BMXK3NIC3WZXPOMJTFO4WHL2AR7M3AVCNFSM6AAAAABRKS7CTGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDINZWGA2DMNBUGA.
You are receiving this because you were mentioned.Message ID: @.***>

Wouldn't it be better to use the Sie form for all the notifications?


Add Support to Validate Security Code/CCV

Cool script, sadly missing something very crucial, validating the CCV to the credit card number. Or am I missing something and not seeing it anywhere.

You can't validate a CCV beyond checking its length (4 for Amex, 3 for most others). I don't think you need a plugin for that.

On 1 Sep 2015, at 19:53, neotropic2023<EMAIL_ADDRESS>wrote:
Cool script, sadly missing something very crucial, validating the CCV to the credit card number. Or am I missing something and not seeing it anywhere.
—
Reply to this email directly or view it on GitHub.

	$('#cvv').on('keyup', function(){
		var reg, ex, cvv = $(this).val(), cardtype = $('#card-number > input').attr('class');
		if(cardtype === 'amex') {
			reg = /^[0-9]{3,4}$/;
		} else {
			reg = /^[0-9]{3}$/;
		}
		ex = reg.exec(cvv);
		if(ex === null) {
			$(this).addClass('error');
		} else {
			$(this).removeClass('error');
		}
	});

@PawelDecowski

The validation doesn't have to be IN this plugin, but the information about the valid cvv length could. Please see https://github.com/PawelDecowski/jquery-creditcardvalidator/pull/73

@pawlik I suppose it wouldn’t hurt to add it to the card_types property. That way it would be available in the result object.

messed up branches, here it is: https://github.com/PawelDecowski/jquery-creditcardvalidator/pull/74


Improve Chronos API descriptions

Pull request to improve Chronos API descriptions. Does not change actual functionality, only improves the descriptions of some parameters.
If this is sucessful (not 100% whether other files need to be modified as well or whether this happens automatically), I will provide further description improvements.

Please add me (boonbaluri) to reviewer when changes are done, and ready for review.

@boonbaluri I do not have the rights to add you as reviewer...

Please create new branch in mercedes-benz/DnA Repo and raise PR again. Thank you


[Revise subclass] MONDO:0019303 'premature aging' and children

MONDO:0019303 'premature aging'
is currently
Subclass of:
disorder of development or morphogenesis
skin disease
RO_0002573 some rare
I believe that the parentage to skin disease terms is incorrect and an artefact due to ORDO provenance. Skin appearance may be affected in prematurely aged individuals, but that doesn't make premature aging (and all of its children) a disease of the skin. We face the same issue in EFO. Please consider implementing similar changes to the ones I outlined in https://github.com/EBISPOT/efo/issues/544. Thanks!

note to self - to remove superclass assertion for 'skin disease'

Continued from above: suggestions for children of 'Premature aging': from https://github.com/EBISPOT/efo/issues/544
Acrogeria:

[ ] Add parents 'genetic disorder' and 'skin disease' (if the latter is removed from 'premature aging')

[ ] Add def "A congenital skin condition characterized by premature aging, more especially in the form of unusually fragile, thin skin on the hands and feet. Its onset is in early childhood; it progresses over the next few years and then remains stable. A bruising tendency has been observed."

Add xref Wikipedia:Acrogeria
De Barsy syndrome:

[ ]  Remove all existing parents except for 'Premature aging' (consider changing them in axioms pointing to phenotypes)

[ ] Add parent 'autosomal recessive disease'

[ ] Edit def to "A rare autosomal recessive genetic disorder characterized by facial dysmorphism (down-slanting palpebral fissures, a broad flat nasal bridge and a small mouth) with a progeroid appearance, large and late-closing fontanel, cutis laxa (CL), joint hyperlaxity, athetoid movements and hyperreflexia, pre- and postnatal growth retardation, intellectual deficit and developmental delay, and corneal clouding and cataract. [ Orphanet:2962 ]"

Flynn-Aird syndrome:

[ ]  Remove parent 'Rare genetic neurological disorder' (consider changing it in an axiom pointing to phenotype)
[ ]  Add parent 'autosomal dominant disease'

Hallermann-Streiff syndrome:

[ ] Remove all existing parents except for 'Premature aging' (consider changing them in axioms pointing to phenotypes)
[ ] Add parent 'genetic disorder'

LMNA-related cardiocutaneous progeria syndrome:

[ ]  Remove parent 'Rare genetic cardiac disease' (consider changing it in an axiom pointing to phenotype)

[ ]  Add parent 'genetic disorder'

[ ] Add def "A rare, genetic, premature aging syndrome characterized by adulthood-onset cutaneous manifestations that result in a prematurely aged appearance (i.e. premature thinning and graying of scalp hair, loss of subcutaneous fat, tightening of skin) associated with prominent cardiovascular manifestations, such as accelerated atherosclerosis, calcific valve disease, and cardiomyopathy. Patients present loss of eyebrows and eyelashes in childhood and have a predisposition to develop malignancies. [ Orphanet:363618 ]"

progeroid syndrome:

[ ] Fix typo in def, should start with uppercase A.

also is premature aging a good disease name?
On Mon, Sep 30, 2019 at 3:36 PM Nicole Vasilevsky<EMAIL_ADDRESS>wrote:

Continued from above: suggestions for children of 'Premature aging': from
EBISPOT/efo#544 https://github.com/EBISPOT/efo/issues/544
Acrogeria:

Add parents 'genetic disorder' and 'skin disease' (if the latter is
removed from 'premature aging')
Add def "A congenital skin condition characterized by premature aging,
more especially in the form of unusually fragile, thin skin on the hands
and feet. Its onset is in early childhood; it progresses over the next few
years and then remains stable. A bruising tendency has been observed."
Add xref Wikipedia:Acrogeria
De Barsy syndrome:

Remove all existing parents except for 'Premature aging' (consider
changing them in axioms pointing to phenotypes)
Add parent 'autosomal recessive disease'
Edit def to "A rare autosomal recessive genetic disorder characterized
by facial dysmorphism (down-slanting palpebral fissures, a broad flat nasal
bridge and a small mouth) with a progeroid appearance, large and
late-closing fontanel, cutis laxa (CL), joint hyperlaxity, athetoid
movements and hyperreflexia, pre- and postnatal growth retardation,
intellectual deficit and developmental delay, and corneal clouding and
cataract. [ Orphanet:2962 ]"
Flynn-Aird syndrome:

Remove parent 'Rare genetic neurological disorder' (consider
changing it in an axiom pointing to phenotype)
Add parent 'autosomal dominant disease'

Hallermann-Streiff syndrome:

Remove all existing parents except for 'Premature aging' (consider
changing them in axioms pointing to phenotypes)
Add parent 'genetic disorder'

LMNA-related cardiocutaneous progeria syndrome:

Remove parent 'Rare genetic cardiac disease' (consider changing it in
an axiom pointing to phenotype)
Add parent 'genetic disorder'
Add def "A rare, genetic, premature aging syndrome characterized by
adulthood-onset cutaneous manifestations that result in a prematurely aged
appearance (i.e. premature thinning and graying of scalp hair, loss of
subcutaneous fat, tightening of skin) associated with prominent
cardiovascular manifestations, such as accelerated atherosclerosis,
calcific valve disease, and cardiomyopathy. Patients present loss of
eyebrows and eyelashes in childhood and have a predisposition to develop
malignancies. [ Orphanet:363618 ]"
progeroid syndrome:

Fix typo in def, should start with uppercase A.

—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub
https://github.com/monarch-initiative/mondo/issues/821?email_source=notifications&email_token=AAAMMOOWVAQZFD5DYACL7QLQMJ5ORA5CNFSM4IVUSRSKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD77J6JY#issuecomment-536780583,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAAMMOLFGOEZ73XIUGCTBRDQMJ5ORANCNFSM4IVUSRSA
.

It does seem like more of a phenotype than a disease. In MeSH, it is classified under 'Signs and Symptoms'
https://meshb.nlm.nih.gov/record/ui?ui=D019588
@cmungall are you suggesting we rename it? or obsolete it?
If we renamed it, what should we rename it as? premature aging syndrome? premature aging disorder?
This article describes 'premature aging syndrome' but I think they are talking about progeroid syndromes:
https://www.ncbi.nlm.nih.gov/pubmed/22411253
This article describes premature aging syndromes too:
https://academic.oup.com/ageing/article-pdf/27/1/73/34683/27-1-73.pdf
This site uses the term 'premature aging disorders': https://www.coriell.org/1/NIA/Collections/Premature-Aging-Disorders

@nicolevasilevsky
@cmungall
Same here please - tentatively adding to your upcoming release milestone :-)


Always fire DOM event on the map too

Since the new event delegation API, when we add a listener on the map, for example on "mouseover", this listener is not called when the event is targeted by a layer (Polygon, Marker…).
What I understand, is that with the old API, the event was listened both on each layer and on the map. With the new API, it's listened only on the map (which is nice) and then forwarded to the original target, but only to this target.
So here is a suggestion to fix that.
Thanks for reviewing :)

I'm thinking about something else.
As far as I understand, with the old API, as we were listening DOM events both on the vectors or marker and on the map, we were able to use the stopPropagation when catching the event on the vector or marker, which then would prevent the map to catch the event.
I think this will not work anymore with my current patch proposal, as we are dealing with Leaflet events.
Also, I wonder if a better approach is not to extend the propagate API to always also propagate to the map.
(Breakfast time. After that I'll try to add more unit tests to cover the stopPropagation use cases.)

@mourner I think I need your thoughts before going forward :)

Haven't thought about this closely yet, will do :)

@mourner this last commit makes all tests happy, but I feel like workarounding the issue, so I think a more global (expert) view is still needed :)

In this branch don't work popup

Yes! Because click event is sent both to the layer and to the map, so it opens the popup and close it just in the same stack. So the layer should stop it for it not to be propagated to the map.
But clearly this means that this branch is work in progress. ;)

I'm kinda lost here, need to revisit and rethink how events and propagation work to have some input in this...

@yohanboniface as an alternative, can you please check https://github.com/Leaflet/Leaflet/pull/3450 and see if it's a good approach for this case? This way we explicitly bubble up all layer events to map. There should be the same problem with popups though.

Note to self: create a webpage inside /debug/test with overlapping polygons, draggable markers, and mouseover/mouseout event handlers on everything.

@IvanSanchez added :)
So it works smoothly in the map-domevent branch, but it doesn't in the master branch:

when the mouse is over the marker itself there is no mousemove event fired so the marker stop, then the mouse goes out the marker, and the map fire again the mousemove so the marker move above the mouse again, and so on
when the mouse is over the polygon, nothing happens for the same reason

@mourner I'm travelling in Italy right now, so not really connected and not really behind my computer, but I will have a look for sure. As first thoughts, this option sounds really interesting, but I do think we still should support bubbling events from features (polygon, marker...) to map, and being able to stop them when we do not want this bubbling.

So the problem with popups is that the order of the events is:

polygon preclick
polygon click (popup opens here)
map preclick (popup closes here)
map click

I'll spend some time trying to figure out how to fix this order into preclick-preclick-click-click.

Good catch :)
Seems to me that, out of what you found, the popup issue is a generic problem introduced by this PR: events listened both on a feature AND the map will often need to be stopped not to trigger twice the listener.
I feel like we need to spend a bit of time more to clean/rationalize the way Leaflet events can be stopped if we want to dig more on this PR.
I'm at work today, but on IRC if you are on this and need a plastic duck to talk to :)

What I don't like in the code changes is that there's now handleDOMEvent method that used to actually handle DOM events, but now also handles Leaflet events in special cases, and there's Leaflet DomEvent.stopPropagation method that used to only deal with DOM events and now has a special case for Leaflet events. It's confusing, and will probably lead us to more traps later.
We should look for a way to handle the issue more gracefully.

We should look for a way to handle the issue more gracefully.

This needs a sprint in Trondheim for sure! ;) cc @IvanSanchez
(/me at SotM France for three days right now)

@mourner, tested with addEventParent/removeEventParent: seems much more cleaner. Not sure about the perfs, though, as we are adding the map in the hash of every single Layer instance. What do you think?

there's Leaflet DomEvent.stopPropagation method that used to only deal with DOM events and
now has a special case for Leaflet events. It's confusing, and will probably lead us to more traps
later.

I agree that, as it is, it's hacky. However, I think that if we take care of propagating events (which I think we should) we should also have of a way to stop them, nope?
I thought that the lightest way was to rely on the cancelBubble property even for Leaflet events, so I've made a quick POC. But maybe we should instead have an internal property, which would be less confusing (like _stopped or whatever). What do you think?

You're probably right about performance, but I need to recheck this.

But maybe we should instead have an internal property, which would be less confusing (like _stopped or whatever). What do you think?

Sounds good. cancelBubble here is indeed a bit confusing.

@mourner Done :)
Should we document that somehow? Or we wait a bit to see if we are sure we go this direction? :)

@yohanboniface lets wait, I'm still not sure about the approach and have a feeling that we may regret merging this too hastily.

OK :)

Seems to me the right approach to this problem is to combine event delegation with simulated event bubbling. So:

Map receives an event bubbled from a child element. Now it's responsible for performing delegation. It traverses the DOM hierarchy upwards from the source element, looking for listening targets.
Right now the code assumes there is only one listening target. It should be changed to fire an event to each listening target in the hierarchy, as it traverses it. This is simulating event bubbling for delegated events.
After firing the event at a particular target, check e.isPropagationStopped(). If so, stop the simulated bubble. (Will need to check browser compatibility of isPropagationStopped and possibly implement a polyfill.)

With this strategy we shouldn't need any special handling for firing events on the map container additionally -- it just needs to be registered with addInteractiveTarget -- and we get a clean way to cancel propagation.

Thanks @jfirebaugh, as usual your explanation is accurate and synthetic. :)
Some comments though:

seems that you are strictly talking about DOM events, while at the moment Leaflet is catching the DOM event then firing a custom event; which then doesn't know about isPropagationStopped for example. So we need to decide if we switch to using only original events (but adding some properties to it, like latlng?, which sounds a bit hackish to me), or to add a isPropagationStopped like method on it (which is what is done in this PR BTW)

when referring to "hierarchy", I'm not sure if we are talking about DOM hierarchy or Leaflet hierarchy; i.e. are we traversing DOM parent of the original target (say svg => overlay div => … => map div), or the Leaflet hierarchy (say marker => layer => map)? As we are listening events on Leaflet object instances, I guess we want to traverse the Leaflet hierarchy, but then this concept is a bit fuzzy to me: when an event is initiated on a marker, for example, how do we define its parents hierarchy? Everything we have called addTo with it as parameter? In this case I should make that addEventParent is called on the right place

does this only works for DOM events, or should we expect that every fired event should "bubble" through its parents hierarchy?

I really like the idea of firing and bubbling Leaflet events and being able to stop them just like "normal" events (so for example catching every marker events on a FeatureLayer), but we should reach a simple, strong, and efficient implementation.
@mourner @IvanSanchez thoughts? I'm on IRC if needed.
I'll hack a bit on this today, so I may post further comments :)
(1.0-beta1, watch out, we are coming! :) )

I'm talking about DOM hierarchy traversal; the existing traversal is here. I'm not suggesting extending the existing addEventParent scheme.
This is just for events that go through the map._handleDOMEvent logic. I'm not sure we should simulate bubbling for custom events. Perhaps there's a way to unify this with the addEventParent stuff but it's not immediately obvious to me.

I'm talking about DOM hierarchy traversal; the existing traversal is here. I'm not suggesting
extending the existing addEventParent scheme.

I think I'm not fully following you. I don't get how to connect DOM events with Leaflet listeners is this case.
Let's take an example. If I do mymap.on('mousemove', myhandler), I'm attaching the listener to the map object, but not as a normal DOM listener (I mean, it's just a entry in a JavaScript hash). So when processing the DOM event, caught from a polygon for example, even if I traverse all the DOM hierarchy, I'll never fire myhandler (which is not attached to the map container).
Are you suggesting to specifically attach map DOM event listeners to the map container, or am I missing? :)

@yohanboniface There is already a map between DOM elements and L.Eventeds, it's  implemented by map._findEventTarget and layer.addInteractiveTarget (which could easily be moved to map). Given a DOM element, we get its L.Evented via this._targets[L.stamp(src)].

@mourner one more try ;)
A first shot implementing @jfirebaugh recommendations.
Some remarks:

isPropagationStopped doesn't seem supported at all neither by FF nor Webkit at this time (this is why I'm still using _stopped instead)
while catching DOM events, we are firing Leaflet events (because we add some properties, like the latlng the event occurred at)
when firing an event, we first clone it, so we can't rely on the event itself while bubbling by hand (this is why I'm setting _stopped on e.originalEvent instead of e)

Whoa, looks pretty nice! I'll check it out. So we avoid the performance implications of addInteractiveTarget, and popups also work as expected, right?

So we avoid the performance implications of addInteractiveTarget

Yep :)

and popups also work as expected, right?

As far as I can test, yes, and unit tests are green. :)

Just got back from a 2-week US trip, now looking into it again. :) After merging this we're only left with docs updates for a proper beta release. @jfirebaugh can you help me review this?

_fireDOMEvent is used by Canvas.js, it will need changes too.
This will change what properties the preclick event object has -- before it has containerPoint, layerPoint, latlng, after it does not. I don't know whether this is important or not.
I would do some refactoring here, essentially inlining _findEventTargets into _fireDOMEvent so that it isn't necessary to construct a temporary targets array on each event.

_fireDOMEvent is used by Canvas.js, it will need changes too.

Gasp! Good catch :) I'm surprised this doesn't break any unittest :(
I'll have a look, it seems a bit more work than just changing how _fireDOMEvent is called.

This will change what properties the preclick event object has -- before it has containerPoint, layerPoint, latlng, after it does not. I don't know whether this is important or not.

Not sure about that. I've added a unittest that covers this, tell me if I'm missing something. :)

I would do some refactoring here, essentially inlining _findEventTargets into _fireDOMEvent so that it isn't necessary to construct a temporary targets array on each event.

I've moved the call of _findEventTargets in to _fireDOMEvent. Did you mean actually moving the code of _findEventTargets inside instead?

Did you mean actually moving the code of _findEventTargets inside instead?

Yes, I mean collapsing the two loops (1, 2) into one.

@yohanboniface any further updates, or should I attempt to address the comments above myself? That's the only issue to finish and merge for 1.0-beta1. :)

@mourner as always I'm travelling while working, so not that much extra time. My plan is to work on this one morning this week. My main issue is to unit test the Canvas scenario.
But if you feel to work on it, I don't want to refrain you :)

Looks like popups still don't open with the latest commits. Checked on debug/map/map.html.

Ahem, good catch @mourner :/
I'll look on this too.
While sailing today I had a quick shot on the canvas issue. I've pushed a working version, but not really happy with it.
Basically, I think we can't use the same manual tree traversing while using canvas (i.e. we can't add the canvas as addInteractiveTarget) given that the canvas takes all the map area, and thus listen to events also where nothing is drawn.
On a train tomorrow, hopefully I'll continue hacking.

@mourner fixed the popup issue.
What I don't really like in the current solution, is that we have two ways of bubbling events: one using our internal propagate system (to reach for example the LayerGroup from a marker), the other one traversing the DOM tree. That doesn't seem really ideal.
Should we try to merge those two patterns? I.e. something like while in _fireDOMEvent, looping through both DOM tree to find registered listeners AND looking if there are some manually registered ones (through addEventParent) ?

Thanks for the fix!
Yeah, the double propagation mechanic is pretty complicated, but if we try to refactor this now, we may get into a trap and stuck for a while more, so I'd rather merge now and release, and think about refactoring later. We can't make it perfect after all, — only good enough.

@yohanboniface wanna do a final rebase and clean up before we merge? E.g. marking fixup commits, etc.

wanna do a final rebase and clean up before we merge?

Sure!

E.g. marking fixup commits, etc.

Not sure what you mean by "marking fixup commit". Shouldn't I just rebase everything into one clean commit?

I mean, when you do an interactive rebase, you can reorder commits, mark some of the commits as "fixup" so that they're merged with a commit above (often useful when you're doing small fixes such as whitespace or typo).

OK, I'm doing that in a moment :)

I would do some refactoring here, essentially inlining _findEventTargets into _fireDOMEvent so that it isn't necessary to construct a temporary targets array on each event.

BTW, do we want to refactor at least this bit before merge? It would be nice, but I didn't find a clean way to do that yet, and performance gain is probably not significant here because it only happens on DOM events.

I've not reached a nice solution when tried (but maybe it was just too much waves ;) ), after fixing the canvas issue. I'll make a new shot just after nomnom :)

Ah what the hell!


Download media feature not working..

Up until yesterday, I was able to download Buzzfeed videos from their tweets but whenever I tried to do so, it shows the prompt that it is downloading, but it never actually completes.
I have updated to the most recent version but the problem is still there. I have also checked my settings both in the app, and in system, and the app has permission to write to the location, so there is no reason on my end for it not to work.
Please fix as soon as possible.
Thank you.

I cannot reproduce. I can download videos from Buzzfeed tweets right now.
Which Buzzfeed tweet video are you trying to download?

Thanks for the response. This was the video I was trying to download..
https://x.com/BuzzFeedFood/status/1753162779270263061?s=35
I have tried to do the same on my phone and it still didn't work. I am using the latest version on both devices.

Strange because I opened the tweet you provided and was able to download the video (104 Mb).
Maybe it's because you have a really slow internet connection and there is a timeout at some point?

I have the same issue. Nothing pop up. Version 3.7.3

I'm still trying to fix the issue. Not done yet.
In my tests I found that when I try to download a video directly from a feed/group timeline or a profile tweet list, it works as expected (not selecting the tweet prior to try to download its video).
The problem arise if I select the tweet, that shows the page with the tweet thread, and then I try to download the video, nothing happens, I have to cancel.

Version v3.7.4 should fix the issue.


feat: replace prometheus/log package with log

Background:
There are some old issues, between package github.com/sirupsen/logrus and github.com/Sirupsen/logrus.
When I import the clickhouse_exporter package into my project, I met the problem with: case-insensitive import collision.
I've searched several infos, like https://github.com/golang/dep/issues/1010
clickhouse_exporter seems import sirupsen package because of the past-out prometheus/log package, which is already renamed and archived. https://github.com/prometheus-junkyard/log
So, I think clickhouse_exporter should remove prometheus/log package instead of using log package.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

@Slach @CHERTS @AlekSi @bobrik @f1yegor

Pipeline failed with: gocoverutil Command not found
Looks like the make env don't have gocoverutil tool. PTAL.

fixed in https://github.com/ClickHouse/clickhouse_exporter/commit/2263a68c67ddb3cc9cbda3f7caba6681742225aa


registering new user with existing email address gives 500 error on confirmation

Gogs version (or commit ref): 0.9.97
Git version: 2.1.4-2.1+deb8u2
Operating system: debian amd64
Database (use [x]):

[ ] PostgreSQL
[ ] MySQL
[x] SQLite

Can you reproduce the bug at https://try.gogs.io:

[x] Yes (provide example URL)
[ ] No
[ ] Not relevant

Log gist:
2016/09/28 18:56:22 [...routers/user/auth.go:281 Activate()] [E] UpdateUser: e-mail has been used

Description
When creating a test account using an existing email address, the process lets Gogs register the account and send an email confirmation request. When clicking on that, a 500 error appears. Tested on try.gogs.io (user ids sepoy and gaul).
If it is an error to have two accounts with the same email address, it should be prevented to register a new account. At least, it should display an error instead of just the 500.
...

I had this issue as well, I think it should give an error already when trying to sign up. Or it should allow multiple users with the same e-mail. But the 500 on confirmation is just confusing.

Duplicate with https://github.com/gogits/gogs/issues/3681


Add ds9_string_to_objects

Looking at
http://astropy-regions.readthedocs.io/en/latest/api.html#functions
I see objects_to_ds9_string, but no ds9_string_to_objects.
It seems that in the implementation (ds9_parser(filename)) the reading from file and parsing aren't separated.
This is weird, parsing should take string as input and then read should just read the file and call the parser with the string, no?
OK if I make this change now?

Yes, good idea.  We probably just shortcutted this step at pyastro

Commit attached here. @keflavich or anyone -- review?

:+1: I saw no problems.

I did expose the intermediate "region list" also in the high-level API and add some high-level docs.
They should appear here:
http://astropy-regions.readthedocs.io/en/latest/getting_started.html#ds9-region-strings
But they currently don't because RTD seems to error out for every build:
http://readthedocs.org/projects/astropy-regions/builds/4226037/
(the same happens for Gammapy today)
@astrofrog @keflavich It's not great, but maybe good enough for the 0.1 release?
In any case: test coverage, API and docs for the DS9 region part need work. Issues with suggestions or even pull requests welcome.

yeah, good enough.  If I'm lucky, I'll have some time to test and then maybe contribute again in two weeks...


Sql table dependency task cancellation

Hello!
I' m trying to use Table sql dependency as hosted service inside and asp.net core web.api project. The issue is that after the initialization phase I receive a cancellation token and the notification doesn't work
this is the log:
2020-12-08 16:56:52.412 []Trigger dbo_RES_INFO_LINEA_2e6eecda-cdd0-4486-a262-01fc26c4cb3b created.
2020-12-08 16:56:52.489 []Watch dog started.
2020-12-08 16:56:52.573 []All OK! Database objects created with naming dbo_RES_INFO_LINEA_2e6eecda-cdd0-4486-a262-01fc26c4cb3b.
2020-12-08 16:56:52.574 []Waiting for receiving RES_INFO_LINEA's records change notifications.
2020-12-08 16:56:52.590 []Get in WaitForNotifications.
2020-12-08 16:57:07.588 []Operation canceled.
2020-12-08 16:57:07.929 []DropDatabaseObjects method executed.
2020-12-08 16:57:07.929 []Stopped waiting for notification.
I faced the same behaviour using a worker service (so windows service project) in .net core. The only way I was able to get it working is using a console application but it' s not my scope. Is there a way to make it working or could you point me to where the issue could be using these hosted service?

HI Alex, I'm trying to get it working as a background task too, I'm getting closer - but I think we need to crack open the API a bit to support it.

Hello @ajex85 , I found the same problem at work.
We are using the Dependency with a .net core worker service.
The only way I found to be able to work with it is to restart the dependency when the service receive an error.
I have setup the event OnStatusChanged, and if the service get a TableDependencyStatus.WaitingForNotification, we try to restart the notification.
can you let me know if this resolve your problem?
Here the code (missing not usefull part), we are using version <IP_ADDRESS>
`private readonly SqlServerConnection _connection;
private int _restartDependencyRetryInterval = default;
public async Task StartTableDependencyAsync()
{
SqlTableDependency... _tableDependency ...;
...
_tableDependency.OnStatusChanged += new StatusEventHandler(StatusChanged);
_tableDependency.Start();
}
private void StatusChanged(object sender, StatusChangedEventArgs e)
{
switch (e.Status)
{
case TableDependencyStatus.WaitingForNotification:
...
break;
case TableDependencyStatus.StopDueToError:
TryRestartDependency();
break;
default:
// Do nothing
break;
}
}
private void TryRestartDependency()
{
if (_connection.Check())
{
_logger.LogInformation("Restart table dependency");
DisposeTableDependency();
StartTableDependencyAsync().Wait();
_restartDependencyAttempt = 0;
}
else if (_restartDependencyAttempt < 3)
{
_logger.LogInformation("Unavailable DB connection");
_restartDependencyAttempt++;
Thread.Sleep(500);
TryRestartDependency();
}
else
{
_logger.LogInformation("Waiting for restart table dependency");
_restartDependencyAttempt = 0;
Thread.Sleep(_restartDependencyRetryInterval);
TryRestartDependency();
}
}
public void DisposeTableDependency()
{
try
{
_tableDependency.Dispose();
}
catch (Exception e)
{
_logger.LogError(e.ToString());
throw;
}
}`
Have a nice day

Hello @ajex85 , I found the same problem at work.
We are using the Dependency with a .net core worker service.
The only way I found to be able to work with it is to restart the dependency when the service receive an error.
I have setup the event OnStatusChanged, and if the service get a TableDependencyStatus.WaitingForNotification, we try to restart the notification.
can you let me know if this resolve your problem?
Here the code (missing not usefull part), we are using version <IP_ADDRESS>
`private readonly SqlServerConnection _connection;
private int _restartDependencyRetryInterval = default;
public async Task StartTableDependencyAsync()
{
SqlTableDependency... _tableDependency ...;
...
_tableDependency.OnStatusChanged += new StatusEventHandler(StatusChanged);
_tableDependency.Start();
}
private void StatusChanged(object sender, StatusChangedEventArgs e)
{
switch (e.Status)
{
case TableDependencyStatus.WaitingForNotification:
...
break;
case TableDependencyStatus.StopDueToError:
TryRestartDependency();
break;
default:
// Do nothing
break;
}
}
private void TryRestartDependency()
{
if (_connection.Check())
{
_logger.LogInformation("Restart table dependency");
DisposeTableDependency();
StartTableDependencyAsync().Wait();
_restartDependencyAttempt = 0;
}
else if (_restartDependencyAttempt < 3)
{
_logger.LogInformation("Unavailable DB connection");
_restartDependencyAttempt++;
Thread.Sleep(500);
TryRestartDependency();
}
else
{
_logger.LogInformation("Waiting for restart table dependency");
_restartDependencyAttempt = 0;
Thread.Sleep(_restartDependencyRetryInterval);
TryRestartDependency();
}
}
public void DisposeTableDependency()
{
try
{
_tableDependency.Dispose();
}
catch (Exception e)
{
_logger.LogError(e.ToString());
throw;
}
}`
Have a nice day


Windows Agent Container will not start

Component
agent
Describe the bug
When trying to run the agent on a Windows Server,  docker fails with the following error
 - woodpecker-agent 2 layers [⣿⣿] 115.2kB/115.2kB Pulling                                                          1.0s
   - b24db7c103d9 Extracting      [==================================================>] ...                        0.4s
   ✔ 592d0b7ade7a Download complete                                                                                0.3s
failed to register layer: re-exec error: exit status 1: output: hcsshim::ProcessBaseLayer \\?\C:\ProgramData\docker\windowsfilter\061a39a4298a318187ad4428eda7a06e3ed5a2c505ca4f03d270715b7de0bdd4: The system cannot find the path specified. ```

### System Info

```shell
Windows Server 2022, also tested on Windows Server 2019
Docker: Server: Docker Engine - Community
 Engine:
  Version:          24.0.2
  API version:      1.43 (minimum version 1.24)
  Go version:       go1.20.4
  Git commit:       659604f9
  Built:            Thu May 25 21:52:13 2023
  OS/Arch:          windows/amd64
  Experimental:     false

Additional context
No response
Validations

[X] Read the Contributing Guidelines.
[X] Read the docs.
[X] Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
[X] Checked that the bug isn't fixed in the next version already [https://woodpecker-ci.org/faq#which-version-of-woodpecker-should-i-use]
[X] Check that this is a concrete bug. For Q&A join our Discord Chat Server or the Matrix room.

https://learn.microsoft.com/en-us/virtualization/windowscontainers/quick-start/run-your-first-container

disabled it for now: https://github.com/woodpecker-ci/woodpecker/commit/b3c2bb2e151b45ef6ee8808df8f05c1acd8548fd
looks like we need an dedicated windows container anyway :/
PS: the pipeline now publish windows binaries witch should cover most windows use cases :)

https://learn.microsoft.com/en-us/virtualization/windowscontainers/deploy-containers/version-compatibility?source=recommendations&tabs=windows-server-2022%2Cwindows-10#matching-container-host-version-with-container-image-versions
looks like we would have to create a own image for each windows version.

@6543 I've been creating windows containers for work for a year now. While i have little experience with GO. I will give it a shot

@6543 I'm also looking forward to try out Woodpecker CI with Windows support.
Have been using Drone CI for the past 4 years now, but they already turned Windows into a second-class citizen 2 years ago, and my support request from 1 year ago went entirely unanswered. Now they even killed the open support forums...
Let me know what is currently blocking this feature and what I can potentially do to unblock it. I'm open to jump into a call if that makes things easier (considering that we speak the same language and live in the same timezone).
FWIW, I'm thinking about using Woodpecker CI for the existing Windows containers at work as well as for the ReactOS Project, where I'm currently maintaining a CI from the pre-container era (https://build.reactos.org)

There is nothing blocking, just a pull missing, witch adds support to build working containers and a change to our pipeline to do so :)


Uncaught TypeError: Cannot read property 'apply' of undefined

[Enter steps to reproduce below:]

...
...

Atom Version: 1.2.4
System: Microsoft Windows 10 Home
Thrown From: color-picker package, v2.0.14
Stack Trace
Uncaught TypeError: Cannot read property 'apply' of undefined
At /C:/Users/juliang478/.atom/packages/color-picker/lib/modules/Emitter.coffee:15

TypeError: Cannot read property 'apply' of undefined
    at Object.emit (file:///C:/Users/juliang478/.atom/packages/color-picker/lib/modules/Emitter.coffee:11:22)
    at Object.emitClose (file:///C:/Users/juliang478/.atom/packages/color-picker/lib/ColorPicker-view.coffee:221:20)
    at Object.close (file:///C:/Users/juliang478/.atom/packages/color-picker/lib/ColorPicker-view.coffee:451:21)
    at file:///C:/Users/juliang478/.atom/packages/color-picker/lib/ColorPicker-view.coffee:139:62
    at Emitter.module.exports.Emitter.emit (C:\Users\juliang478\AppData\Local\atom\app-1.2.4\resources\app.asar\node_modules\event-kit\lib\emitter.js:86:11)
    at Pane.module.exports.Pane.setActiveItem (C:\Users\juliang478\AppData\Local\atom\app-1.2.4\resources\app.asar\src\pane.js:248:22)
    at Pane.module.exports.Pane.activateItem (C:\Users\juliang478\AppData\Local\atom\app-1.2.4\resources\app.asar\src\pane.js:312:21)
    at atom-tabs.TabBarView.onMouseDown (C:\Users\juliang478\AppData\Local\atom\app-1.2.4\resources\app.asar\node_modules\tabs\lib\tab-bar-view.js:670:19)

Commands
     -1:58.2.0 autocomplete-plus:confirm (atom-text-editor.editor.is-focused.autocomplete-active)
     -1:57.7.0 editor:newline (atom-text-editor.editor.is-focused)
     -1:55.5.0 core:backspace (atom-text-editor.editor.is-focused)
  3x -1:49.8.0 core:move-down (atom-text-editor.editor.is-focused.autocomplete-active)
     -1:49.3.0 autocomplete-plus:confirm (atom-text-editor.editor.is-focused.autocomplete-active)
     -1:47.9.0 editor:newline (atom-text-editor.editor.is-focused)
     -1:47.2.0 snippets:next-tab-stop (atom-text-editor.editor.is-focused)
     -1:47.2.0 snippets:expand (atom-text-editor.editor.is-focused)
     -1:47.2.0 editor:indent (atom-text-editor.editor.is-focused)
     -1:45 core:backspace (atom-text-editor.editor.is-focused.autocomplete-active)
     -1:43.4.0 core:move-down (atom-text-editor.editor.is-focused.autocomplete-active)
     -1:43.2.0 autocomplete-plus:confirm (atom-text-editor.editor.is-focused.autocomplete-active)
     -1:43.2.0 autocomplete-plus:activate (atom-text-editor.editor.is-focused)
     -1:40.3.0 core:save (atom-text-editor.editor.is-focused)
     -0:35.2.0 settings-view:open (atom-text-editor.editor.is-focused)
  7x -0:26.8.0 color-picker:open (atom-text-editor.editor.is-focused)

Config
{
  "core": {
    "themes": [
      "seti-ui",
      "seti-syntax"
    ]
  }
}

Installed Packages
# User
atom-jade, v0.3.0
color-picker, v2.0.14
indent-guide-improved, v1.4.5
jade-autocompile, v0.6.5
minimap, v4.16.2
seti-syntax, v0.4.1
seti-ui, v0.8.1

# Dev
No dev packages

Please update color-picker to v2.1.1 and restart Atom. This should be fixed now!

I have this same error when trying to open the color picker on an scss variable color:
$color: #000;
background-color: $color;


Sultan.load() vs Sultan()

In Streaming Results from a Command we see:
with Sultan.load() as s:
    result = s.yum('install', '-y', 'postgresql').run(streaming=True)
    while True:
        # if full output is needed, read the pipes one last time
        # after `is_complete == True` to avoid a race condition
        complete = result.is_complete
        for line in result.stdout:
            print(line)
        for line in result.stderr:
            print(line)
        if complete:
            break
        time.sleep(1)

My question is: how different would this code be if Sultan.load() were replaced with Sultan().

is load documented anywhere? Is Sultan() documented anywhere?

Hey @metaperl ... the documentation for load() is here: https://sultan.readthedocs.io/en/latest/sultan-examples.html#example-2-sultan-with-context-management
All the examples there use the load() method.
If you were to use it with the constructor Sultan(), you can pass these contexts in with the context keyword argument, which is a dictionary. Sultan uses these determine the right type of bash command to generate based on the parameters you provide, so using load() is the right way to do it. I didn't document using Sultan() constructor because of this reason, since it is not the recommended way of doing so.


WEB3-94: Updated deployment scripts and guide from 1.1 deployment

During the 1.1 deployment, I implemented a number of improvements to the deployment process to make it a bit easier and less error prone.
Primary among these changes is adding a deployment.toml file that records the addresses of and associated information about each chain we deploy to, and the contracts that are deployed there.
My hope is to use this file to do additional work around further automating deployment, testing that deployments are correctly configured on-chain, and generating the table of addresses that goes into our docs.

This PR is marked as draft, as I'd like to merge the deployment_guide.md file into the existing README. They are currently two files simply due to the process by which I ended up writing that file.

@capossele, this is ready for review. Give it a look when you have a chance. I'm hoping you'll be able to run this for the 1.2 release, when it happens. (You can ask me for the deployment_secrets.toml file and other secrets you'll need)

Only 600 lines of instruction 🙈

And believe me when I say it's an easier process now! 😅


Array push_back

Currently, calling json_array.push_back(json_array.back()) results in undefined behavior if push_back causes a reallocation. This is different behavior than exhibited by std::vector, for which self-referential push_back is valid. Either the documentation should contain an explicit warning about this difference, or the implementation should be amended to follow std::vector's practice.
Additionally, the documentation for push_back claims the Strong Exception guarantee, however, the implementation invalidates references if constructing the array element throws.
Note that both issues apply to emplace_back as well.

Should work now thanks


Remove optional=true from some module dependencies

While IMHO those dependencies should ultimately be added as includes
by the deployers that need them (XD-3615), for the time being they
should really not be marked optional.
They ARE needed at runtime my modules/deployers, but are currently
excluded because of https://github.com/spring-cloud/spring-cloud-stream/issues/168.
Even when that is fixed (alignment with boot), they still shouldn't be marked
optional.

I shall add this is a prereq to https://github.com/spring-cloud/spring-cloud-dataflow/pull/134 & https://github.com/spring-cloud/spring-cloud-dataflow/pull/132

The optional flag was added for these dependencies to avoid having these dependencies transitively when the module itself is added as dependency. Please see the related discussion [here] (https://github.com/spring-cloud/spring-cloud-stream-modules/pull/24#discussion-diff-37690910). Currently, these dependencies should be part of the module executable and available when the deployer resolves the module.

First of all, boot does not package deps of optional deps. It so happens that the dependencies we talk about here don't have themselves dependencies that are needed (or at least they're either re-added elsewhere / the code paths we use don't need them). But this is wrong in itself in my opinion.
Secondly, I don't really understand the rationale here: if we decide that a unit module needs those deps, then a composed module ought to need them (it's a module).
Put it another way: given the way deployers currently work (again, I'd prefer to revisit via XD-3615) those dependencies are NEEDED for the lattice,marathon & k8s deployers to function properly. So, whether it's a unit module or a composition thereof, they are NEEDED.
The problem is made more apparent because of https://github.com/spring-cloud/spring-cloud-stream/issues/168, but really those deps should not have been marked optional in the first place IMHO.

if we decide that a unit module needs those deps, then a composed module ought to need them (it's a module).

If you compose the modules via aggregation (or direct-binding), then I believe those connector deps are automatically available. If you create a composed module using a separate POM, then I believe one would always have the SCSM parent POM as its parent which then brings the connector dependencies.
But, I agree. We need to remove the optional flag only to avoid [this] (https://github.com/spring-cloud/spring-cloud-stream/issues/168).

LGTM, rebased and merged as https://github.com/spring-cloud/spring-cloud-stream-modules/commit/4866d047276653203a60b34dfa86fb065e71abd2


Current docs are missing style sheets?

It seems like the latest deployed docs (at https://docs.daml.com/) are missing the style sheets.  I've checked this on 2 separate browsers with the same results.  Here's a screen shot of what I'm seeing.  This wasn't like this last week

Fixed with https://github.com/digital-asset/docs.daml.com/pull/754


Add stopOnUpdateErrors to manifest

Updated to add the stopOnUpdateErrors to the manifest

This is good, but we still need to change FXLauncher to accept this parameter and save it in the manifest. Will you give that a go as well? Should be pretty straight forward.

By that name do you mean the FXLauncherPlugin in this project or the actual FXLauncher project?

The actual FXLauncher. Sending that command to FXLauncher now wouldn't result in it being added to the manifest.

Ok, I'll take a look at that one.
Thank you

Perfect! Let me know if you get stuck on anything.

I believe I got it all, tell me if I missed anything in that project.


Create getting started documentation

This tracks the work for generating the getting started documentation for the library

Fixed by #10568


Replace File with UploadedFile

Why
To keep the file-ending and treat every file as an uploaded file.
If you are using File for files added via API, Shopware tries to guess the file-extension. This is sometimes wrong.
It's better to treat the files as UploadedFile instead of File so Shopware will use the given file-extension.
What
Use UploadedFile instead of File
Description

Questions
Answers

Why?
To keep the file-ending and treat every file as an uploaded file.

If you are using File for files added via API, Shopware tries to guess the file-extension. This is sometimes wrong.

It's better to treat the files as UploadedFile instead of File so Shopware will use the given file-extension.

BC breaks?
no

Tests exists & pass?
no

Related tickets?
If this PR fixes an existing issue ticket, please add there url here.

How to test?
Upload a file via API.

Before: If you upload a .stp file, it will be saved as .txt

After: If you upload a .stp file, it will be saved as .stp

Requirements met?
Yes

Hello,
thank you for creating this pull request.
I have opened an issue on our Issue Tracker for you. See the issue link: https://issues.shopware.com/issues/SW-19229.
Please use this issue to track the state of your pull request.

@mitelg Sorry, something went wrong here.
Because i deleted my repository in the meanwhile, i had to create a new pull-request.
This one can be closed. Here is the new PR.
https://github.com/shopware/shopware/pull/1257


⚠ Guya.moe Proxied has degraded performance

In be63458, Guya.moe Proxied (https://ice.guya.moe/) experienced degraded performance:

HTTP code: 200
Response time: 12011 ms

Resolved: Guya.moe Proxied performance has improved in 851ec11 after 28 minutes.


[Question]:  Does deepdoc support high concurrency processing?

Describe your problem
Does deepdoc support high concurrency processing?

Make it parallelly by enlarge 'WS' in docker/entrypoint.sh.
After modify it, do not forget to docker build it.


Revamp Ingestion Backend

While the value provided in OpenMetadata comes from many different fronts (from foundational aspects just as the standard language to the UX navigating the tool), the typical user flow is:

Discover the tool
Install
Ingest

Without correctly bringing the metadata, we cannot provide the rest of the value layers. Therefore, we need to make as many efforts as necessary to make sure that the foundations behind the Ingestion Framework are as solid as possible. We have been focusing on bringing as many features and connectors as possible, but now it's time to double down on quality and stability.
In this epic, we are going to track all the improvements that can be done in core elements of the Ingestion Framework.

https://github.com/open-metadata/OpenMetadata/issues/1673 - We are adding complexity because of this
https://github.com/open-metadata/OpenMetadata/issues/2848 - Also a requirement for https://github.com/open-metadata/OpenMetadata/issues/4698. Reorganizing the core definitions and properly setting the package dependencies between ingestion and ingestion-core will help us evolve faster and improve release flows.
https://github.com/open-metadata/OpenMetadata/issues/3394 - We've been delaying this for too long! Pylint is a great source of improvements and knowledge, and the longer it takes for us to get this fixed, the more work we'll need to do. Afterward, we'll be able to update the CI workflows to check the linting results and ensure that the codebase does not deteriorate.
https://github.com/open-metadata/OpenMetadata/issues/3054 - While sonar helps us to avoid bugs and issues during PRs, we are missing important inputs from coverage. This is a requirement to help us see where we need to improve.
https://github.com/open-metadata/OpenMetadata/issues/4766 - After fixing sonar and pylint, let's add mypy to the mix to ensure that we are properly typing and sending the expected data.
https://github.com/open-metadata/OpenMetadata/issues/3940 - SQLSource is the major pillar of the ingestion framework, and it is not in its best shape. Properly refactor it into more manageable and better tested methods.
https://github.com/open-metadata/OpenMetadata/issues/4894 - Tags cleanup
https://github.com/open-metadata/OpenMetadata/issues/4767 - We need proper Lineage & Usage modules that centralize the logic. It will be easier to test and evolve.
https://github.com/open-metadata/OpenMetadata/issues/4880 - Standardise JSON schema types
https://github.com/open-metadata/OpenMetadata/issues/5014 - Fix ingestion-core publish and usage
https://github.com/open-metadata/OpenMetadata/issues/5093 - DBT refactor

Lets clean this up in 0.13

we'll close linting on 0.13. Moving the rest for 0.14

@pmbrull anything to consider for 0.13.1 if not lets move it to 1.0

let's call it 1.0

we're only missing mypy. Will close this issue


Transactions are recorded in READONLY PRODUCTION connections

Description
For connections that are set to Connection Type production and readonly (Both under: Edit Connection -> General) transactions are recorded, even though they shouldn't.
DBeaver Version
Community <IP_ADDRESS>302060909
Operating System
Windows 11
Database and driver
Tested on
Postgresql 14
Postgres JDBC Driver 42.5
and
Oracle 12 (not sure here)
Oracle jdbc8 v12.2.01.
Steps to reproduce
Create a connection to a database (Oracle or postgres, probably also works for others)
Set it to production and read-only
execute SELECT 1; or
SELECT 1 FROM dual;
Transaction count is set to 1 and you need to COMMIT or ROLLBACK
Additional context
No response

Hello @dmichulke
Sorry, but I'm not sure.
https://stackoverflow.com/questions/818074/transactions-for-read-only-db-access
Does read-only connection not have transactions? Can you point me to the documentation which says that?

Hmm, following your link I can see how there might be reasons to still have transactions.
I can see that there might be technical reasons to still not autocommit by default. However, the link is 12 years old, performance should matter less these days and I think my point is a bit more specific.
Firstly, Iḿ not arguing for a general autocommit, I argue (and I could have made that clearer)
for autocommit in case of select statements.
If as a user I ever want a setting to be changed,
I run it before the SELECT, e.g. "SET ROLE ...;"
At this point it's clear a transaction would make sense.
Still, 95% of the time I just run a plain SELECT and if I'm not in a transaction before running the select, I shouldn't be in a transaction after the select either.
Does that make sense?

We can't be sure, that simple plain select do not lead to any modifications as, for example, there can be some functions, which may be triggered by such select execution.

But what is the point of using production mode with the read-only together? Maybe using of Development mode will help you?

The point of using "readonly connection" for me is to avoid accidental writes, e.g, INSERT accidentally because you thought you're working on the dev database.
At that time accumulating transactions using SELECT is

uncomfortable (you have to COMMIT or ROLLBACK, I personally would like an auto-rollback here because it makes it clear that nothing was changed)
and potentially blocks other people's transactions (not sure this can happen)

Hello @dmichulke,
A read-only connection doesn't imply you can't edit data using SQL. Even if a SELECT statement doesn't seem to do anything harmful, it can call a function that can potentially alter data in the database. There may be databases that support triggers on query execution that can modify data too.
So having transactions always enabled is better for your safety. I don't consider current behavior as a bug.


Provide verification of bpfd bytecode images

Integrate bpfd with Rekor/Sigstore  in order to provide owner verification of bpfd bytecode images.

Done in #671


AWVerify record

This article does not mention using an awverify record for pre-staging any DNS / custom domain changes - this would be helpful.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 224b73dd-c59d-a833-0d4d-a778af6086a9
Version Independent ID: c6b167c9-9589-45d0-ee6a-7a47a4aec41e
Content: Map existing custom DNS name - Azure App Service
Content Source: articles/app-service/app-service-web-tutorial-custom-domain.md
Service: app-service-web
GitHub Login: @cephalin
Microsoft Alias: cephalin

Thanks for the feedback! We are currently investigating and will update you shortly.

Hi @blarsonrp, I have assigned the issue to the content author to evaluate and update the docs as appropriate.

@blarsonrp We have a link to the doc you're looking for in the section called "Migrate an active domain". Let me know if that's not the information you need. #please-close


Fix Lutron Pico

Description:
Lutron Pico keypads do not work. The problem is because they don't have LEDs assigned to them within the configuration, so they get skipped over when keypads are being added to HASS.
Related issue (if applicable): fixes #
Pull request with documentation for home-assistant.io (if applicable): home-assistant/home-assistant.io#10490
Example entry for configuration.yaml (if applicable):
n/a
Checklist:

[x] The code change is tested and works locally.
[x] Local tests pass with tox. Your PR cannot be merged unless tests pass
[x] There is no commented out code in this PR.
[x] I have followed the development checklist

If user exposed functionality or configuration variables are added/changed:

[x] Documentation added/updated in home-assistant.io

If the code communicates with devices, web services, or third-party tools:

[x] The manifest file has all fields filled out correctly. Update and include derived files by running python3 -m script.hassfest.
[x] New or updated dependencies have been added to requirements_all.txt by running python3 -m script.gen_requirements_all.
[x] Untested files have been added to .coveragerc.

If the code does not interact with devices:

[x] Tests have been added to verify that the new code works.

@cdheiser @thecynic @achatham can you guys take a quick look at this? This seems like a bit of a hack to get Pico's into homeassistant, but I'm not sure if there's a better way.

What should pylutron do for keypads? Keypads.leds looks like a hack already :( Clearly not what was intended for that API. If you can file an issue on pylutron as tobwayt we think we want out of the keypad API, I can take a look.

Rather than adding an extra nestng level, you could just add a
If not keypad.leds:
after the loop. Won't be as ugly.
That's a good idea...

What should pylutron do for keypads? Keypads.leds looks like a hack already :( Clearly not what was intended for that API. If you can file an issue on pylutron as to what we think we want out of the keypad API, I can take a look.
The way buttons are being added definitely seems like a hack to me, I think the original idea that whoever wrote this was that they didn't want buttons to be added to HA that had no programming in RadioRA2. To be honest, I don't love that idea. If we add all buttons, even the ones that don't have a function, we could program those to do actions within HA, which I think would be really cool. Thoughts?

er, you'll need to excuse my noob-ness. I'd attempted to push an updated commit with the fix that @thecynic suggested (to remove a nested layer), but apparently I somehow included a whole bunch of other changes into my PR.... Any tips on how to either revert to a previous commit, or remove those other "modified" files?

find the sha you want to be the tip and then just force push to the branch:
git push -f <your_fork> aa0abcf98dcbdd6f64634b95bc80e3a28930303d:refs/heads/pico-fix

Oh wait, yeah thats the top of the stack. If you are sure you aren't losing anything, just:
git rebase -i upstream/dev
and just delete the patches you didn't want. Worst case they'll be in your reflog.

The way buttons are being added definitely seems like a hack to me, I think the original idea that whoever wrote this was that they didn't want buttons to be added to HA that had no programming in RadioRA2. To be honest, I don't love that idea. If we add all buttons, even the ones that don't have a function, we could program those to do actions within HA, which I think would be really cool. Thoughts?

Does HASS have a concept of mindless button with no function?! :)

find the sha you want to be the tip and then just force push to the branch:
git push -f <your_fork> aa0abcf98dcbdd6f64634b95bc80e3a28930303d:refs/heads/pico-fix

Oh wait, yeah thats the top of the stack. If you are sure you aren't losing anything, just:
git rebase -i upstream/dev
and just delete the patches you didn't want. Worst case they'll be in your reflog.

Very much appreciate the help, but when I run git rebase -i upstream/dev, I don't see any commits that I need to wipe out. I think the issue I had was that I rebased against dev and it's reflecting all of the other changed files since I first forked, does that make sense?

Does HASS have a concept of mindless button with no function?! :)

Well, what would effectively show up is a scene that does nothing, not a button with no function. Not sure how @MartinHjelmare feels about this, but I don't think it's actually undesirable behavior. Think about it, if you have a keypad with 6 physical buttons on it, and only 5 are programmed within RadioRA2 software, doesn't it make sense that you'd get 6 buttons represented as 'scenes' within HA?

The keypad buttons in home assistant are just exposed as events without any
entity behind them (I haven't used them though).
On Sun, Sep 29, 2019, 9:04 PM Jon Gilmore<EMAIL_ADDRESS>wrote:

Does HASS have a concept of mindless button with no function?! :)
Well, what would effectively show up is a scene that does nothing, not a
button with no function. Not sure how @MartinHjelmare
https://github.com/MartinHjelmare feels about this, but I don't think
it's actually undesirable behavior. Think about it, if you have a keypad
with 6 physical buttons on it, and only 5 are programmed within RadioRA2
software, doesn't it make sense that you'd get 6 buttons represented as
'scenes' within HA?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/home-assistant/home-assistant/pull/27059?email_source=notifications&email_token=AAU22YPGWX4G6AGKJK7SYDTQMF3F7A5CNFSM4I3T7DY2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD74LA7I#issuecomment-536391805,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAU22YN6C2HFLT3POE5MRSDQMF3F7ANCNFSM4I3T7DYQ
.

find the sha you want to be the tip and then just force push to the branch:
git push -f <your_fork> aa0abcf98dcbdd6f64634b95bc80e3a28930303d:refs/heads/pico-fix

Oh wait, yeah thats the top of the stack. If you are sure you aren't losing anything, just:
git rebase -i upstream/dev
and just delete the patches you didn't want. Worst case they'll be in your reflog.

Very much appreciate the help, but when I run git rebase -i upstream/dev, I don't see any commits that I need to wipe out. I think the issue I had was that I rebased against dev and it's reflecting all of the other changed files since I first forked, does that make sense?
edit: I think this is whats happening: the other PRs that were accepted after my initial fork are now showing up in my PR. Not sure how the hell to remove them.... but I'll continue to mess around with it.

Sorry, I don't know.. Seems like a github-ism I guess?

You can try git rebase upstream/dev and force push, if upstream hasn't changed, maybe try git commit --amend but just save/exit to get a new sha and force push.
Alternatively, stackoverflow suggests to edit hte PR, change the target branch from dev to something else, then change it back to dev.  Seems like a github oddity. Sorry.

Does HASS have a concept of mindless button with no function?! :)

Well, what would effectively show up is a scene that does nothing, not a button with no function. Not sure how @MartinHjelmare feels about this, but I don't think it's actually undesirable behavior. Think about it, if you have a keypad with 6 physical buttons on it, and only 5 are programmed within RadioRA2 software, doesn't it make sense that you'd get 6 buttons represented as 'scenes' within HA?

But it's weird to create a scene that doesn't actually do anything. It feels like we're mixing concepts, and shoehorning. It just sounds awkward. What's wrong with Andrew's description of a button just being an event and you tie that as a trigger for automation? Why do you want it to be a scene? Seems that other integrations do something similar, just fire events. For example, insteon:
https://www.home-assistant.io/components/insteon/#events-and-mini-remotes
I'm not very familiar with this side of HASS, so someone who knows how it's all intended to work should chime in :)

If you do an interactive rebase of the ten latest commits in your branch, you should be able to drop the non related ones.
Another option is to start over in a new PR and branch.
Stateless buttons are represented as events in home assistant. The button is pushed and sends information to home assistant which triggers an event.
If we want to trigger an action in a stateless device from home assistant that is done via a home assistant scene. Here home assistant sends information to the device.

Huge thanks @MartinHjelmare and @thecynic - I've still got a lot to learn with Git, but think I got it figured out :D
As far as how we want to represent the buttons/etc - I think we can move that conversation out of here, I'll probably open up an issue in pylutron.

The original implementation used LEDs to basically ignore Pico remotes,
mainly because there are 3 ways one generally uses them:

Bound to a single device.
Actually used to implement a single/multi-room scene
Left unprogrammed to let HA or something else do something smarter.

Not all of the buttons on a Pico remote are the same either.  in a 5-button
remote, the raise/lower buttons can be bound to arbitrary devices, but are
stuck with the raise/lower functionality.  The other 3 can do pretty much
everything a normal keypad can do except you're stuck with
single/multi-room scenes.
None of my PICO remotes are actually programmed to do anything in Lutron,
because it's just a little too dumb.  I don't have an XML dump from a
repeater that actually has pico remotes programmed, and I can't decide if
it's useful to have unprogrammed buttons visible in HA.
On Tue, Oct 1, 2019 at 2:11 AM Dima Zavin<EMAIL_ADDRESS>wrote:

@thecynic commented on this pull request.
In homeassistant/components/lutron/init.py
https://github.com/home-assistant/home-assistant/pull/27059#discussion_r329946466
:

@@ -80,6 +80,11 @@ def setup(hass, base_config):
hass.data[LUTRON_DEVICES]["scene"].append(
(area.name, keypad.name, button, led)
)

           # All keypads have LEDs except Pico keypads

           if not keypad.leds:

Hmm. So the more I look at this code, the more weird the whole thing is.
The code on 74-82 wants to only add a scene if there's an LED associated
with the button, and button is assigned something to do. Your code here
adds it blindly. It seems like you should have same logic. In fact, I'd
turn these loops inside out.. to make it more sane as to what's happening.
Something like this (replaces lines 70-87)
for button in keypad.buttons:
If the button has a function assigned to it, add it as a scene
if (
button.name != "Unknown Button"
and button.button_type in ("SingleAction", "Toggle")
):
# Associate an LED with button if there's one
led = next((led for led in keypad.leds if led.number == button.number), None)
hass.data[LUTRON_DEVICES]["scene"].append(
(area.name, keypad.name, button, led)
)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/home-assistant/home-assistant/pull/27059?email_source=notifications&email_token=ACQARWQ3GXEMHE6GKASHEMDQMMH23A5CNFSM4I3T7DY2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCGOE2XY#pullrequestreview-295456095,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ACQARWW4J52CHECXAGYSQE3QMMH23ANCNFSM4I3T7DYQ
.

The original implementation used LEDs to basically ignore Pico remotes, mainly because there are 3 ways one generally uses them: 1) Bound to a single device. 2) Actually used to implement a single/multi-room scene 3) Left unprogrammed to let HA or something else do something smarter. Not all of the buttons on a Pico remote are the same either. in a 5-button remote, the raise/lower buttons can be bound to arbitrary devices, but are stuck with the raise/lower functionality. The other 3 can do pretty much everything a normal keypad can do except you're stuck with single/multi-room scenes. None of my PICO remotes are actually programmed to do anything in Lutron, because it's just a little too dumb. I don't have an XML dump from a repeater that actually has pico remotes programmed, and I can't decide if it's useful to have unprogrammed buttons visible in HA.

Thanks @cdheiser, this is great background to have. I can't tell by your post, are you opposed to having them inside of HA for some reason then? Sounds like you're still on the fence. Here's my use case: I have pico's that turn a few different lights on/off. I'd like them to create a scene that I can trigger from HA. I suppose I could create a scene on the main repeater, but it doesn't make sense to duplicate the functionality.

@cdheiser @thecynic - thoughts on my post from above? I'd really like to get my pico's into HA.

I am not opposed to this change
On Thu, Oct 10, 2019, 6:02 PM Jon Gilmore<EMAIL_ADDRESS>wrote:

@cdheiser https://github.com/cdheiser @thecynic
https://github.com/thecynic - thoughts on my post from above? I'd
really like to get my pico's into HA.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/home-assistant/home-assistant/pull/27059?email_source=notifications&email_token=ACQARWREJEEKM2CP5RRZNI3QN7GBJA5CNFSM4I3T7DY2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEA6ND3A#issuecomment-540856812,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ACQARWSXULNIXBXNUSNKDTLQN7GBJANCNFSM4I3T7DYQ
.

@MartinHjelmare I just re-requested a review. Changed some of the logic around so I'm not just blindly adding buttons in that don't have led's associated with them. Seem to have buy in from a couple other individuals who are invested in the Lutron component. Let me know, thanks!!


Registering preview component per field

Here I go suggesting a feature again :P. I would like to help, but unfortunately, I know nothing about react :(. Maybe I'll have learned some next year :)
Anyways.
It would be nice if we could register a preview component per field, instead of just per collection. The reason being that we would (or maybe could, I don't know if it would require extra work) then get sync-scroll for the custom preview. This could be very nice for collections with lots of long fields.

Not sure I completely understand the request here. How would per field previews get sync scrolling? Is the sync scrolling not working right now for you, or are you looking for something about it to change?

Yeah I mistook how the sync scrolling works. It does indeed work fine.
I somehow thought it worked by scrolling into view the elements whose corresponding fields are in view. Which now that I think about it doesn't make sense, as it would mean the sync-scrolling would not happen linearly. That would probably feel very weird.
I'll go ahead close this.


Parse Talker IDs

I recently got a GPS which reports talker IDs. I've been testing it with the ROS 2 of this repo and found that when the talker IDs are reported, the parsing fails. I can open a PR with some fixes if this feature interests anyone.
Example of packets with talker IDs:
$GBGGA,122712.0,0120.44802,N,10357.72683,E,2,06,2.3,37.5,M,8.2,M,1.0,0009*63
$GNGGA,122720.0,0120.44992,N,10357.72963,E,2,08,2.1,32.8,M,8.2,M,1.0,0009*63

More details:
https://gpsd.gitlab.io/gpsd/NMEA.html#TALKERS

I think the issue is something else. Closing. this issue.


undefined method `to_hash' for nil:NilClass

Hi.
When I do a simple object.build(my_key) and object.retrieve I get:
undefined method `to_hash' for nil:NilClass
    from /opt/boxen/rbenv/versions/2.0.0-p247/lib/ruby/gems/2.0.0/gems/s3-0.3.21/lib/s3/object.rb:249:in `parse_headers'
    from /opt/boxen/rbenv/versions/2.0.0-p247/lib/ruby/gems/2.0.0/gems/s3-0.3.21/lib/s3/object.rb:190:in `object_headers'
    from /opt/boxen/rbenv/versions/2.0.0-p247/lib/ruby/gems/2.0.0/gems/s3-0.3.21/lib/s3/object.rb:61:in `retrieve'
    from /opt/boxen/rbenv/versions/2.0.0-p247/lib/ruby/gems/2.0.0/gems/s3-0.3.21/lib/s3/objects_extension.rb:12:in `find_first'

Seems simple but not sure if it's a bug or me using the gem wrong.

Hi guys, I faced the same issue.
Created a new bucket via CyberDuck app, the file is present in the bucket. When I try to fetch it with s3 gem, it returns this error.

This should be fixed in master, please try again, and let me know if it doesnt work.
thanks

Getting the exact same error.
created a bucket, added a single file.
bucket.objects.first.content  => actual file content
bucket.objects.first.key => actual file key
bucket.objects.first.request_acl => {"my s3 user"=>"FULL_CONTROL", "Everyone"=>"READ"}
bucket.objects.first.retrieve => NoMethodError: undefined method `to_hash' for nil:NilClass

precisely according to Dagnan's stacktrace above.  The object_request for headers returns nil. (I guess, boiling down to the Connection.request method, and possibly an empty response from s3)

It's indeed fixed in master. It'd be nice to see this change propagated to rubygems.

@qoobaa can you add me to rubygems so I can cut a new gem. thanks

@arthurnn done.

new version released https://rubygems.org/gems/s3/versions/0.3.22

I am facing the same problem.
I have a working S3 bucket with files, and the bucket.objects manages to correctly list files, and get their contents, but is unable to retrieve them.
Example of output from the Rails console:
2.3.0 :009 > bucket
=> #<S3::Bucket:kyouko>
2.3.0 :010 > bucket.objects[125]
 => #<S3::Object:/kyouko/anime/147799.jpg>
2.3.0 :011 > bucket.objects[125].retrieve
NoMethodError: undefined method to_hash' for nil:NilClass Did you mean?  to_h         from /home/rd/.rvm/gems/ruby-2.3.0/gems/s3-0.3.24/lib/s3/object.rb:245:in parse_headers'
       from /home/rd/.rvm/gems/ruby-2.3.0/gems/s3-0.3.24/lib/s3/object.rb:190:inobject_headers'         from /home/rd/.rvm/gems/ruby-2.3.0/gems/s3-0.3.24/lib/s3/object.rb:61:in retrieve'
I am using v0.3.24. I thought this was fixed? Or is it another problem?

+1 on this issue


Backslashes in pkg-config output are processed incorrectly

pkg-config uses backslash to preserve literal meaning of following byte.
Different arguments are separated by unescaped space. The idea behind all this,
is to be compatible with parsing behaviour of UNIX shell, when used in
following manner from a makefile:
program: program.c
     cc program.c $(shell pkg-config --cflags --libs ..)

That doesn't actually work in full generality, because in UNIX shell backslash
escaping works character wise, and pkg-config does escape everything outside
ASCII, but in byte wise manner. Just remember not to put emoji in header
include directories and you will be fine.
EDIT:
Once fixed, this part should no longer be necessary: https://github.com/alexcrichton/pkg-config-rs/blob/5203aff8b20479c9df159be2efb4162450019330/src/lib.rs#L507
EDIT 2: Previous example, was broken.

Fixed in #61.


DBT hub instructs/links to version 0.1.2

DBT hub instructs people to install version 0.1.2 and links to the readme for 0.1.2. Users landing on dbt-expectations via Google and click on the Github link will see the outdated readme.
https://hub.getdbt.com/calogica/dbt_expectations/0.1.2/
This bit me as I did not realize I was looking at an old readme and the arguments for macros had changed, spent ~45 min debugging and scratching my head.
This also probably explains why on the DBT slack lots of people are using or mention version 0.1.2 during debugging. Example: https://getdbt.slack.com/archives/C2JRTGLLS/p1649122057115889?thread_ts=1648837415.237699&cid=C2JRTGLLS

Looking closer, this might be Google's fault. it looks like it is returning the page for 0.1.2 on dbt hub when I google dbt_expectations. Guessing it is happening for a lot of other people too?
Maybe oldest versions could be retired and forward to the current version on DBT hub to get pagerank to fix?

Hi @ttusing , thanks for raising this issue! I think this is indeed a Google issue. Let me see what we can do there. The hub page does link to the latest version.

Looks like there's an open issue in dbt-labs


Unable to add padding for calling notification

How to add padding around the notification ui?
For some android devices (eg.: Redmi 10) padding is not there for the calling notification.

Please look into it.

please update version 1.0.3+1. adding prop isCustomSmallExNotification

@hiennguyen92 I tried with that parameter and doesn't work, it shows like this

What I did was create a custom notification layout with horizontal and vertical padding called "layout_custom_xiaomi_notification" with the same ids like the "layout_custom_small_notification" and the I added this validation in the "CallkitNotificationManager" right in the middle of the if and else clause that validates the Samsung manufacturer
else if (Build.MANUFACTURER.contains("Xiaomi",ignoreCase = true) || Build.MANUFACTURER.contains("Redmi",ignoreCase = true)) {
    notificationSmallViews = RemoteViews(context.packageName, R.layout.layout_custom_xiaomi_notification)
    initNotificationViews(notificationSmallViews!!, data)
}


Add a convenience method to simplify the access to the cache

This PR adds a convenience method called Cache#fetch to simplify the access to the cache, similar to what Ruby on Rails does.
Fetches data from the cache using the given key. If there is data in the cache with the given key, then that data is returned.
If there is no such data in the cache (a cache miss), then null will be returned. However, the passed function is executed in
the event of a cache miss. The function's return value will be written to the cache under the given cache key, and that
return value will be returned.
// cache hit
cache.write('today', 'Monday');

cache.fetch('today', () async {
  return 'Tuesday';
}); // 'Monday'

// cache miss
cache.get('city'); // null

cache.fetch('city', () async {
  return 'Phuket';
}); // 'Phuket'

cache.get('city'); // 'Phuket'

Apologies in advance if this code is substandard. I'm a beginner in Dart and mocktail. And I haven't tried Serverpod yet - I found it a few hours ago on Twitter and noticed that the introductory tutorials used get/set so here I am.
Challenges

I had more tests to add to redis_test.dart. But I couldn't find a way to generate the serverpod_test_client/protocol/client with utils/generate_all or serverpod generate:

00:00 +0 -1: loading test/redis_test.dart [E]
  Failed to load "test/redis_test.dart":
  test/redis_test.dart:82:42: Error: The method 'fetch' isn't defined for the class '_EndpointRedis'.
   - '_EndpointRedis' is from 'package:serverpod_test_client/src/protocol/client.dart' ('../serverpod_test_client/lib/src/protocol/client.dart').
  Try correcting the name to the name of an existing method, or defining a method named 'fetch'.
        var retrieved = await client.redis.fetch<SimpleData>(
                                           ^^^^^
  test/redis_test.dart:92:42: Error: The method 'fetch' isn't defined for the class '_EndpointRedis'.
   - '_EndpointRedis' is from 'package:serverpod_test_client/src/protocol/client.dart' ('../serverpod_test_client/lib/src/protocol/client.dart').
  Try correcting the name to the name of an existing method, or defining a method named 'fetch'.
        var retrieved = await client.redis.fetch<SimpleData>(
                                           ^^^^^

I also tried to avoid mocking the RedisController, and wanted to mock RedisConnection directly, but the variable _command is private. Not a trivial change without Dependency Injection.

contribute#editing-the-pubspecyaml-files states that we shouldn't update the pubspec files directly. Initially, I updated the templates and ran the generation scripts, but my IDE complained that the package could not be found.

Pre-launch Checklist

[x] I read the Contribute page and followed the process outlined there for submitting PRs.
[x] This update contains only one single feature or bug fix and nothing else. (If you are submitting multiple fixes, please make multiple PRs.)
[x] I read and followed the Dart Style Guide and formatted the code with dart format.
[ ] I listed at least one issue that this PR fixes in the description above.
[x] I updated/added relevant documentation (doc comments with ///), and made sure that the documentation follows the same style as other Serverpod documentation. I checked spelling and grammar.
[x] I added new tests to check the change I am making.
[x] All existing and new tests are passing.
[x] Any breaking changes are documented below.

I have read the CLA Document and I hereby sign the CLA

recheck

@wilsonsilva This is a really neat addition. I will finish it for you and get it into Serverpod.

Consolidated the interface into a single one with an optional parameter for handling the cache miss logic.
Bonus: Apart from adding tests for the cache miss functionality the relevant cache tests from the local cache where ported to the Redis cache.


[question] When is the next version planned?

The current state of master seems good right now. I'm currently using a specific commit to have the #1351 patch. I'm just wondering when will there be a release. There's currently 136 unreleased commits ;)
merged commits related to Issues that would be part of next version:
#1321
#1323
#1325
#1331
#1332
#1335
#1336
#1339
#1341
#1345
#1346
#1347
#1348
#1349
#1350
#1351
#1352
#1353
#1354
#1355
#1356
#1357
#1361
#1363
#1364
#1366
Is there a roadmap?

Just uploaded https://pypi.org/project/django-extensions/2.1.7/ to pypi :-)
There is no roadmap or fixed release schedule or alike.
Since I haven't found a way yet to drive some income and therefor dedicate some time for Django Extensions the current situation with releases and efforts put into the project will likely not change.


fix: zcat usage in bwa_mem2 wrapper

Coverage: 85.037% (+0.02%) from 85.013% when pulling a278c146c6e684346eea54924799a0563c2d56d6 on fix-zcat-bwa-mem2 into bc4c55b2b095a9a8c792cf937efd6fda87d8e09e on main.


[Tracking Issue] Prebuilt PyPI wheels

Prepare PyPI wheels for users to trying-out directly:

cuda version (follows PyTorch): 11.8, 12.1
cuda architectures: sm 75(still wip)/80, 86, 89, 90(performance not optimized yet).
manylinux version: manylinux_2_24

Done.


UnicodeDecodeError "utf8" codec isn't decode byte 0xbl in position 24: invailid star byte

can't open pixivutil cause error occurred
================================================
Traceback (most recent call last):
File "PixivConfig.pyc", line 116, in loadConfig
File "PixivHelper.pyc", line 312, in OpenTextFile
File "codecs.pyc", line 896, in open
UnicodeDecodeError "utf8" codec isn't decode byte 0xbl in position 24: invailid star byte
then window close
any other version(including 0314 version) was not opened
what should i do

Write the answers to the questions asked in the template. They were put for a cause.
What version of PixivUtil2 do you use?

Try to backup/delete the old config file and rerun the application?


Add service name for AI Project SDK

There's one more change that needs to be made here. The boolean, after "client" needs to be set to "true", not "false".

Thanks for the comment have made the change.


Announcement: Version 11 ready.  Please review/test. 😇

https://github.com/ctrlplusb/react-universally/issues?utf8=✓&q=is%3Aissue milestone%3A11.0.0
Update feature branches

[x] apollo
[x] found (done in PR)
[x] glamor
[x] jest
[x] koa2
[x] mobx
[x] postcss-sass
[x] redux
[x] styled-components
[x] styletron

Staged on the next branch.

I'll test it out right now!

Released. :)


Need some more space for district names

Describe the bug
We do not have enough room for district names. Need to increase cell width bit more
To Reproduce
Expand any of state to show district details
Screenshots

Desktop (please complete the following information):

OS: fedora 31
Browser:  chrome
Version: 79.0.3945.130

Hey thanks for working on this fix!
So I've tested it on a mobile screen width and it seems to be working great!
However, on desktops it tends to resize the tables. Could you possibly have that fixed too?