#86

This change is

PR is added to the queue for testing as 2. task. (42466a2)

Hi @vasilevskayaem, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!
You've already signed the contribution license agreement. Thanks!
We will now validate the agreement and then real humans will evaluate your PR.
TTYL, MSBOT;

Hi @vasilevskayaem, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!
You've already signed the contribution license agreement. Thanks!
We will now validate the agreement and then real humans will evaluate your PR.
TTYL, MSBOT;

PR is added to the queue for testing as 3. task. (3a9a586)

Test (Success) 83591764 build is completed (42466a2)
See https://github.com/ThaliTester/TestResults/tree/8359176442466a2__86_vasilevskayaem/ for the logs

Test<PHONE_NUMBER>466a2(42466a2) has successfully finished without an error
See https://github.com/ThaliTester/TestResults/tree/8359176442466a2__86_vasilevskayaem/ for the logs

Test (Success) 83591764 build is completed (3a9a586)
See https://github.com/ThaliTester/TestResults/tree/835917643a9a586__86_vasilevskayaem/ for the logs

Test 835917643a9a586(3a9a586) has successfully finished without an error
See https://github.com/ThaliTester/TestResults/tree/835917643a9a586__86_vasilevskayaem/ for the logs

When https://github.com/thaliproject/Thali_CordovaPlugin_BtLibrary/pull/87 get LGTM, I'll review this one

Review status: 0 of 1 files reviewed at latest revision, all discussions resolved.

Comments from Reviewable

PR is added to the queue for testing as 4. task. (b77310c)

PR is added to the queue for testing as 6. task. (f116baa)

Test (Fail) 83591764 build is completed (b77310c)
See https://github.com/ThaliTester/TestResults/tree/83591764b77310c__86_vasilevskayaem/ for the logs

PR is added to the queue for testing as 8. task. (81a80d7)

Test (Success) 83591764 build is completed (f116baa)
See https://github.com/ThaliTester/TestResults/tree/83591764f116baa__86_vasilevskayaem/ for the logs

work started in vNext_vasilevskayaem_86, after changes appears next core test fails, continue working
--- Failed tests ---
2016-09-09T10:28:32.191Z - warn: 64. #startUpdateAdvertisingAndListening - destroying remote peers connection kills the local connection - fail
2016-09-09T10:28:32.191Z - warn: 67. We do not emit peerAvailabilityChanged events until one of the start methods is called - fail
2016-09-09T10:28:32.191Z - warn: 68. Test updating advertising and parallel data transfer - fail
2016-09-09T10:28:32.191Z - warn: 69. initial peer discovery - fail
2016-09-09T10:28:32.191Z - warn: 70. update peer discovery 1 - fail
2016-09-09T10:28:32.191Z - warn: 71. update peer discovery 2 - fail
2016-09-09T10:28:32.191Z - warn: 72. check latest peer discovery - fail
2016-09-09T10:28:32.191Z - warn: 73. no peer discovery - fail
2016-09-09T10:28:32.191Z - warn: 107. Action fails because of a bad hostname. - fail
2016-09-09T10:28:32.192Z - info:
2016-09-09T11:12:23.860Z - info: Running on android test: 59. Can connect to a remote peer
2016-09-09T11:13:48.396Z - warn: Failed on android test: 59. Can connect to a remote peer

Test 83591764f116baa(f116baa) has failed
See https://github.com/ThaliTester/TestResults/tree/83591764f116baa__86_vasilevskayaem/ for the fail logs

Test (Success) 83591764 build is completed (81a80d7)
See https://github.com/ThaliTester/TestResults/tree/8359176481a80d7__86_vasilevskayaem/ for the logs

Test<PHONE_NUMBER>a80d7(81a80d7) has failed
See https://github.com/ThaliTester/TestResults/tree/8359176481a80d7__86_vasilevskayaem/ for the fail logs

PR is added to the queue for testing as 2. task. (1a423dc)

Test (Fail) 83591764 build is completed (1a423dc)
See https://github.com/ThaliTester/TestResults/tree/835917641a423dc__86_vasilevskayaem/ for the logs

@vasilevskayaem I think we should just close this PR and make a note in issue thaliproject/Thali_CordovaPlugin_BtLibrary#86 of which branch you put the fix code into. What do you think?


Add string alignment handling to FormatWith functionality

Additional values & tests for a left-padding format string.
This type of format string does not currently work in FormatWith.
I suspect a format-string parse issue, where it assumes the first format-string delimiter is ':', rather than a potential ','.
I've been trying to find workarounds, but haven't managed to do so yet.

FormatWith/Internal/FormatHelpers.cs around line 48, the parser checks for the first instance of ':', but it is possible for the format string to begin with ',' followed by a number then ':' and the rest of the format string.  the ',' plus number denotes padding the value with spaces.
A positive value indicates left-padding.
A negative value indicates right-padding.

Here's a .NET Fiddle example of the format string with alignment in action.
.Net Fiddle - Format String with Alignment

A quick .NET Fiddle sample comparing a regex parse to a IndexOf/Substring parse.
https://dotnetfiddle.net/BBqTMB

@crozone I'm not familiar with the innards of the library.  Can you let me know where else I might need to make changes to handle the alignment portion of a format string?

@crozone This is what I was thinking of for making the parsing code publicly accessible.
public class TokenInformation
{
	public string RawToken { get; private set; }
	public string TokenKey { get; private set; }
	public string Alignment { get; private set; }
	public string Format { get; private set; }
	public string FormatString { get; private set; }

	private static readonly System.Text.RegularExpressions.Regex _parseRegEx = new System.Text.RegularExpressions.Regex(@"(?<token>([^,:\s]+))(,(?<alignment>-?\d+))?(:(?<format>.*))?", System.Text.RegularExpressions.RegexOptions.Compiled);

	// IndexOf/Substring version of parser based on existing code
	public TokenInformation(string rawToken)
	{
		this.RawToken = rawToken;
		this.Format = null;
		this.Alignment = null;

		// Parse out the format
		var separatorIdx = this.TokenKey.IndexOf(":", System.StringComparison.Ordinal);
		if (separatorIdx > -1)
		{
			this.Format = this.TokenKey.Substring(separatorIdx + 1);
			this.TokenKey = this.TokenKey.Substring(0, separatorIdx);
		}

		/// Parse out alignment
		var alignmentIdx = this.TokenKey.LastIndexOf(",", System.StringComparison.Ordinal);
		if(alignmentIdx > -1)
		{
			this.Alignment = this.TokenKey.Substring(alignmentIdx + 1);
			this.TokenKey = this.TokenKey.Substring(0, alignmentIdx);
		}

		/// assemble full format string ([,ALIGNMENT][:FORMAT])
		this.FormatString = ((alignmentIdx > -1) ? $",{this.Alignment}" : System.String.Empty) + ((separatorIdx > -1) ? $":{this.Format}" : System.String.Empty);
	}

	//// RegEx version of parser, for performance comparison, and in case someone else knows how to optimize it more
	//public TokenInformation(string rawToken, bool ignoreThisParameterItIsHereForPerformanceComparisons)
	//{
	//	this.RawToken = rawToken;
	//	this.Alignment = null;
	//	this.Format = null;
	//
	//	System.Text.RegularExpressions.Match results = _parseRegEx.Match(rawToken);
	//	if(results.Success)
	//	{
	//		this.TokenKey = results.Groups["token"].Value;
	//		this.Alignment = results.Groups["alignment"].Value;
	//		this.Format = results.Groups["format"].Value;
	//	}
	//
	//	/// assemble full format string ([,ALIGNMENT][:FORMAT])
	//	this.FormatString = ((alignmentIdx > -1) ? $",{this.Alignment}" : System.String.Empty) + ((separatorIdx > -1) ? $":{this.Format}" : System.String.Empty);
	//}
}

Also, if you're willing to have a breaking change for 4.0, you could re-structure the special handler designation such that it can have alignment, handler, and formatting, and provide a way to register multiple handlers, rather than requiring library users to write a single method to handle any and all special handlers they want to use.

I've also got a set of changes for the 4.0 branch, but I've always been in TFS shops, so I'm having issues figuring out the process for Git in Visual Studio.  And it'll probably need a look at whether I've missed anything regarding the use of ReadOnlySpan rather than String.


Correct MSIE8 reserved word error

Q
A

Is bugfix?
yes

New feature?
no

Breaks BC?
no

Tests pass?
yes

Fixed issues

In MSIE8 and below, yii.gridView file is not loaded and GridView widget is not working (throws Identifier expected error). The reason is that the variable name 'class' is a reserved word. To correct this, the variable name should be changed into an array key, which eliminates the error.
More info about the causes of error: https://tiffanybbrown.com/2013/09/10/expected-identifier-bug-in-internet-explorer-8/

Thanks!


README secrets screenshot

The README secrets screenshot in "Step Four: Set Your Secrets" includes QUESTIONS_API_KEY, which now seems to be deprecated.
https://github.com/ryooan/metaculus-bot-forecaster?tab=readme-ov-file#step-four-set-your-secrets

Thank you, I've updated the readme to add a note before the image that QUESTIONS_API_KEY is no longer needed.


Schema ActionType AmsiContent

Unable to locate ActionType "AmsiContent" in the schema. Is this actiontype not available to advanced hunting?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: dc9f0472-a1fe-8d1e-f081-fd3c97bbfc92
Version Independent ID: ddc56801-5d2f-cef2-c6fe-3360368088fa
Content: Data tables in the Microsoft 365 Defender advanced hunting schema
Content Source: microsoft-365/security/defender/advanced-hunting-schema-tables.md
Product: m365-security
Technology: m365d
GitHub Login: @schmurky
Microsoft Alias: maccruz

@Bievens Thank you for the feedback. I was not able to locate "AmsiContent" in the schema and I don't see them in any of the reference documents for advanced hunting. So, I'd say this action type is not available for advanced hunting. If you'd like to see this action type in the schema,  you can provide feedback to help improve a Microsoft product! To make sure that your feedback gets routed to the appropriate team, please post it on the Microsoft 365 Q&A portal.
Hope this helps!
Thanks
Sri

@msbemba Thank you very much for the contribution and sharing this explanation. @Bievens Hope this comment is helpful for you. If you see a documentation update is required, please feel free to open an issue for the same. We proceed here to close it. Thanks for taking out some time to open the issue. Appreciate and encourage you to do the same in future also.

@bievens for additional guidance, not all ActionTypes are documented, only tables and column names are. Kindly check inside the portal under DeviceEvents for AmsiContent.


Remove test skips since upstream fix

PR to merge once the upstream fix is in 20191024 nightly. Closes #606

Humm, seems that there are still 2 test case failing. let me take a closer look.

Closing as this is solved in https://github.com/tensorflow/addons/pull/669


Feature Request: fs::remove_all

Would having the following function be a good addition to this library?
/// This function will either remove the file specified at `path` or remove the
/// directory and all of its contents specified at `path`
pub async fn remove_all<P: AsRef<Path>>(path: P) -> io::Result<()> { ... }

@Nokel81 I agree that it is a reasonable addition to libstd. I'll leave this issue open for reference.


Node debug breaking on reject inside caught promise

VS Code Version: 1.53.2
OS Version: Windows_NT x64 10.0.19041

Steps to Reproduce:

Debug a node script like this: new Promise((resolve, reject)=>reject("Exception!")).catch(console.log);
It will break on the exception, even though it is caught in the promise. Hitting continue in the debugger will proceed without issue.

Does this issue occur when all extensions are disabled?: Yes

/jsDebugLogs

This is an issue in V8: https://bugs.chromium.org/p/chromium/issues/detail?id=465666&q=uncaught promise pause&can=2 Once that's fixed, Node and our debugger will (eventually) be fixed.


DRAFT: Attempt 2 to fix ctl integration tests

This updates how the Click to Load integration tests determine whether Facebook requests are loading. Instead of assuming "0" requests will be successful, it looks at requests that are expected (iFrame requests are generally sent regardless, and blocked by the extension).
It should now consistently pass if things are working right with CTL.

@Charlie-belmer is this still a draft, or can we merge? It looks like it provides some improvement to the flakiness of the tests.

We can merge - it's an improvement, but not yet perfect.


docs: improve documentation around verify_patches

The prior documentation was missing steps around updating the list file generated, and would cause users to end up in a state where bazel would flag them for a malformed file. This adds the necessary steps to ensure that end users don't trip up when implementing this feature.

Type of change

Documentation (updates to documentation or READMEs)

Test plan
None

Done!

sorry about the red CI on main, it's fixed now


Using multiple branches or multiple sites.

Hi! I am new to using netlify cms and was interested in using it for a side project.
Is it possible to use the same cms and refer to multiple sites? For example, for posts and events I want to both city websites to refer to the same city .md files or back end data.
If I want to deploy two similar websites with the only differences being title changes and colors, is it best to make two branches within my repo or do I have to make two separate repos and how would that affect my config.yml?
This is my first time posting here so sorry if I missed something!

@erquhart related question, if I have a monorepo with many different websites, how can I configure a distinct CMS for each website in the monorepo? I ported sites from distinct repos but now the CMS for each website has broken though I updated them to point to the new monorepo. Any ideas?

@adrw you'd have to provide details on how they're broken. It's inherently valid to have an unlimited number of Netlify CMS instances because they don't know about one another, and they only target whatever directories and files you configure them to, so monorepo vs regular repo isn't a necessary distinction. To Netlify CMS it's just files.

Ah, just saw #2250, will comment there.


Adding firmware for 2021 Honda CRV Touring

What's your Dongle ID?

c73b9fb79dc5a9a5
On Wed, Jun 9, 2021 at 5:12 PM Chris McCammon @.***>
wrote:

What's your Dongle ID?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/commaai/openpilot/pull/21211#issuecomment-858183852,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ASANIZUMFDMLNYOSVXINEC3TR77QBANCNFSM46M65RRA
.


Support Veolia IDF?

Hi,
Are you willing to add/maintain Veolia IDF (https://espace-client.vedif.eau.veolia.fr/) version? They share the name Veolia but the website is not the same, the account is not shared, the contract number is different etc. And data are returned in JSON format, with a POST request. In summary, they share nothing except the name.
However, the actual client is small. So I don't know what do you want to proceed. If you are willing to maintain, I think I could submit a PR.

The purpose of this request is to be possibile to use the Veolia integration in HA without forking everything.

I've just found another library that uses webdriver to click on the "Download" button to get the CSV version https://github.com/Flobul/conso_veolia/blob/master/get_veolia_idf_consommation.py

Hi,
Thank you for your interest. Manage all the Veolia entrypoints within the same library sound good.
I'm not a big fan using webdriver to trigger the request. It's better to reproduce the final request like the POST one you described.
On your Veolia version, do you have a page where you can see your consumption like this :

What's the delay to get your daily consumption?

The UI is completely different. I can get consumption in euros, m3 or litters. There is no delay, this morning I got yesterday consumption.
So I think I'll look into it in the next few days and will try to submit a PR.

Well, it's harder than I thought. Veolia IDF build they website using Salesforce with a JS framework (Aurora) with many states. It would require effort to reverse engineer the JS framework. I'm looking around and it seems all attempts are based on a webdriver. Besides the above links, other examples:

https://github.com/ssenart/PyVeoliaIDF
https://github.com/s0nik42/veolia-idf/

After another round playing around, try to get the essential data, it's quite complex. Here are the post data to get the mesures (it won't work as-is because I remove the cookies part):
message={"actions":[{"id":"335;a","descriptor":"aura://ApexActionController/ACTION$execute","callingDescriptor":"UNKNOWN","params":{"namespace":"","classname":"LTN015_ICL_ContratConsoHisto","method":"getData","params":{"contractId":"4VhoQjJVQMHyZOV9Y2k9WMJaAg7KXnfBjNIWZBPX57ieLhgPERHbEy9zWajeNsI0","TYPE_PAS":"JOURNEE","DATE_DEBUT":"2021-02-02","DATE_FIN":"2021-02-16","NUMERO_COMPTEUR":"crb8b9r0YvC%2BYqg5H8CvcTaqej4mjA3Gi1PeqhiCtJDIcBsLyG4mcgliBpU4rORl","ID_PDS":"lJqG66BlO5A1jIugBnI%2B9LtqvoXmyI8ED8ms78tOKDQ%3D"},"cacheable":false,"isContinuation":false}}]}&aura.context={"mode":"PROD","fwuid":"8WYDoRiNKzw4em08r-Gg4A","app":"siteforce:communityApp","loaded":{"APPLICATION@markup://siteforce:communityApp":"fV3Zo7mI3PLrr1VMsCPF3w","COMPONENT@markup://forceCommunity:embeddedServiceSidebar":"G-AEnzq63TIgJNF3Aq3-Xw"},"dn":[],"globals":{},"uad":false}&
aura.pageURI=/s/historique&
aura.token=eyJub25jZSI6InF4Q1g3dzM0UENnSW5ySFkzcHRSVFBTWXRJQkhiUWJNMEFHT0xJanNfVkVcdTAwM2QiLCJ0eXAiOiJKV1QiLCJhbGciOiJIUzI1NiIsImtpZCI6IntcInRcIjpcIjAwRDBZMDAwMDAzQndnc1wiLFwidlwiOlwiMDJHMFkwMDAwMDBoMXJPXCIsXCJhXCI6XCJjYWltYW5zaWduZXJcIn0iLCJjcml0IjpbImlhdCJdLCJpYXQiOjE2MTM0MjA5MDQ3MDYsImV4cCI6MH0=..ubavIisGutVchOTsNeyAzpKekhUPvISKgojwF6yyFIc=

Another link https://forum.jeedom.com/viewtopic.php?f=140&t=21200&start=680#p747026 so even with curl to reproduct the request, it won't work after a week.

It’s just a matter of token. To be checked if the value is stored  within a cookie for instance. Once the location of this value found, we have to know which request create this resource. Most of the time, it’s the login step.

I think there is also some random value generated at the beginning. I haven't had time yet to reinvestigate the problem. If you want I think I could give you temporary access to my account to check the login / consumption data.

@jcisio Are you on the HA discord or on Reddit? We will need a place where to share the credentials ;)

Bonjour,
I'm also interested in having this wonderful client available for Veolia IDF website. I'm targetting to integrate the data in Home Assistant afterwards.
Where did you investigations ended previously ? Did you manage to avoid using Selenium to fetch the data ?

@pafnow unfortunately, nowhere :( The workflow to get the resource request is too complex. The JS framework used is not grokkabke. And Veolia support said that they didn't have any plan to make an API availble.

Thanks for the answer, sadly, it was predictable...
Well I'll put this on hold until i'm resigned to use Selenium

Hi, I'm also interested in the integration of IDF.

Hi, maybe you could have a look at : https://github.com/s0nik42/veolia-idf ...
It works with domoticz in my home on a raspberry pi3 + raspbian

Hi, maybe you could have a look at : https://github.com/s0nik42/veolia-idf ...
It works with domoticz in my home on a raspberry pi3 + raspbian

This lib uses selenium and webscraping is not allowed by Home assistant. There was too many issues with such library.

OK, I understand that but https://github.com/s0nik42/veolia-idf is basically a crontab job which could write the result in a file. Is there a way to send this file content to a Home Assistant entity or device ?
(I am not fluent in HA API ...)

Hi guys,
Any chance that something move ahead on this Veolia IDF topic during the last 2 years ?
It would be great seeing this happening :)
Thanks a lot


WskRestOperation implements action create with copy but it should not

The copy operation is a function of the cli, not the rest api.
So supporting a copy in the WskRestOperation's implementation of wsk.action.create doesn't make sense.
The code should be removed and any rest tests in place should be moved strictly to the cli tests.
It's arguable we should preserve this behavior --- if we reify this implementation into a scala SDK for openwhisk. Otherwise, I'm not sure why we should support this.

A similar point can be made for merging annotations on action update.
https://github.com/apache/incubator-openwhisk/blob/3ab604c167ac5bec76c756e3e76473863eb0a25d/tests/src/test/scala/common/rest/WskRestOperations.scala#L380-L387


Create internal test runner

Change the current test runner from the one provided by jest-editor-support to an internal one.  We want to model this runner off the ones used by react-scripts and Nx.dev.  Will need to include some of the result parsing of jest-editor-support.
Relates to #40 and #14.

See:

https://github.com/nrwl/nx/blob/master/packages/jest/src/builders/jest/jest.impl.ts
https://github.com/facebook/create-react-app/blob/master/packages/react-scripts/scripts/utils/createJestConfig.js


iina: add wrapper for iina-cli

Description of changes
This PR adds a wrapper for the iina-cli binary to $out/bin, mimicking the brew cask. This binary is needed by applications such as ani-cli as they rely on it to be present on PATH.

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[x] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[x] sandbox = relaxed
[x] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

everything else looks good
Result of nixpkgs-review pr 278174 run on aarch64-darwin 1

1 package built:

iina

seems like IINA 1.3.4 was out 2 days ago

I did not update the version because usually nixpkgs wants one pr for one purpose

I will add your requested changes as well, please wait a moment

Squash those two commits and we are good to go, happy new year btw 🎉

Will do, thank you so much, happy new year to you too!

Result of nixpkgs-review pr 278174 run on aarch64-darwin 1

1 package built:

iina

I updated the package in #280297.


VolumeReplicationGroup Operator: Add watchers to monitor pvcs

Adding watchers in the VolumeReplicationGroup operator to watch for
pvcs and send reconcile request for pvc create/update/delete
operations based on the following logic

The pvc on which notification came must belong to one of
the VolumeReplicationGroup CR's namespace
The pvc on which notification came must have labels that
matches with the VolumeReplicationGroup CR from the namespace
to which the pvc belongs to.

Signed-off-by: Raghavendra M<EMAIL_ADDRESS>

This PR has conflicts. Sending a new PR.


Cluster integration tests cleanup

Changes

:broom: Refactor: NewInClusterDialer() now takes clientcmd.ClientConfig as a parameter, this removes dependency on global kubectl configuration. This allowing test parallelization.

:broom: General improvements for TestUploadToVolume() and TestDialInClusterService():

Better allocation and cleanup of testing resources. All test resources names are randomized and the resources are deleted after test.
TestUploadToVolume() now uses Deployment instead of plain Pod for the testing service. Rationale: pods of Deployment/Job should have security context set automatically.
TestUploadToVolume() the testing service now does not run on privileged port. Rationale: some cluster do not allow to run pods in privileged mode to non-admin users.
Both TestUploadToVolume() and TestDialInClusterService() are not running in new namespace, instead they are run in current default namespace. Rationale: not all cluster users can create a namespace, this change ensures the tests can be run with non-admin cluster users.

/retest


Should CivGradle enforce a Paper version?

Each of the plugins' paper module define within their build.gradle.kts the paper dev version (example). But CivGradle also sets the run-server plugin to 1.18 (reference). Should this kind of version-enforcement be consistent? Or should both be within the plugins' paper module? Or kept as is?

Superceded by https://github.com/CivMC/Civ/pull/544


Nodejs- Pulsar-Client NPM issues

Describe the bug
Attempt to install pulsar-client from npm, was not successful: node-pre-gyp WARN Tried to download(404): https://pulsar.apache.org/docs/en/client-libraries-cpp/libpulsar-v1.1.0-node-v64-linux-x64.tar.gz
node-pre-gyp WARN Pre-built binaries not found for<EMAIL_ADDRESS>and<EMAIL_ADDRESS>(node-v64 ABI, glibc) (falling back to source compile with node-gyp)
To Reproduce
Steps to reproduce the behavior:
npm install pulsar-client

Expected behavior
A clear and concise description of what you expected to happen.
Screenshots

Desktop (please complete the following information):

OS: [e.g. iOS]

Additional context
Add any other context about the problem here.

@nkurihar are you and your team able to help with this issue?

Waiting anxiously for this fix. Thank you

Currently, pulsar-client-node isn't built and published pre-built binaries in release flow. If you use, you should install C++ library, and build binary in "falling back to source compile with node-gyp" step(automatically run).
See details at https://pulsar.apache.org/docs/en/client-libraries-node/#requirements
Currently, C++ library isn't support Windows platform. Is your environment Windows? If so, you can't use pulsar-client-node correctly now.
https://pulsar.apache.org/docs/en/client-libraries-cpp/#supported-platforms

I got the same error on linux. Including this in a pre-build step when running from docker is the challege.

node-pre-gyp warning log is always shown when installing(because pre-gyp binaries isn't uploaded).
Here is an example.
If you can't install, check Pulsar C++ library and g++.
root@4d65efd5b3e5:/# curl -sLO https://archive.apache.org/dist/pulsar/pulsar-2.5.1/DEB/apache-pulsar-client.deb
root@4d65efd5b3e5:/# curl -sLO https://archive.apache.org/dist/pulsar/pulsar-2.5.1/DEB/apache-pulsar-client-dev.deb
root@4d65efd5b3e5:/# apt-get install ./apache-pulsar-client.deb ./apache-pulsar-client-dev.deb
root@4d65efd5b3e5:/# npm install pulsar-client
npm WARN deprecated<EMAIL_ADDRESS>request has been deprecated, see https://github.com/request/request/issues/3142

><EMAIL_ADDRESS>install /node_modules/pulsar-client
> node-pre-gyp install --fallback-to-build

node-pre-gyp WARN Using request for node-pre-gyp https download
node-pre-gyp WARN Tried to download(404): https://pulsar.apache.org/docs/en/client-libraries-cpp/libpulsar-v1.1.0-node-v72-linux-x64.tar.gz
node-pre-gyp WARN Pre-built binaries not found for<EMAIL_ADDRESS>and<EMAIL_ADDRESS>(node-v72 ABI, glibc) (falling back to source compile with node-gyp)
make: Entering directory '/node_modules/pulsar-client/build'
  CC(target) Release/obj.target/nothing/../node-addon-api/src/nothing.o
  AR(target) Release/obj.target/../node-addon-api/src/nothing.a
  COPY Release/nothing.a
  CXX(target) Release/obj.target/Pulsar/src/addon.o
  CXX(target) Release/obj.target/Pulsar/src/Message.o
  CXX(target) Release/obj.target/Pulsar/src/MessageId.o
  CXX(target) Release/obj.target/Pulsar/src/Authentication.o
  CXX(target) Release/obj.target/Pulsar/src/Client.o
  CXX(target) Release/obj.target/Pulsar/src/Producer.o
  CXX(target) Release/obj.target/Pulsar/src/ProducerConfig.o
  CXX(target) Release/obj.target/Pulsar/src/Consumer.o
  CXX(target) Release/obj.target/Pulsar/src/ConsumerConfig.o
  CXX(target) Release/obj.target/Pulsar/src/Reader.o
  CXX(target) Release/obj.target/Pulsar/src/ReaderConfig.o
  SOLINK_MODULE(target) Release/obj.target/Pulsar.node
  COPY Release/Pulsar.node
make: Leaving directory '/node_modules/pulsar-client/build'
npm WARN saveError ENOENT: no such file or directory, open '/package.json'
npm notice created a lockfile as package-lock.json. You should commit this file.
npm WARN enoent ENOENT: no such file or directory, open '/package.json'
npm WARN !invalid#1 No description
npm WARN !invalid#1 No repository field.
npm WARN !invalid#1 No README data
npm WARN !invalid#1 No license field.

+<EMAIL_ADDRESS>added 122 packages from 130 contributors and audited 284 packages in 26.036s

1 package is looking for funding
  run `npm fund` for details

found 0 vulnerabilities

Thanks for the response.  I was able to include cpp in  docker file in a multi stage build as suggested by @sijie  and it worked but the challenge is the image size after all is bigger. I am currently considering to use Dockerslim

Currently running into the same, issue for windows 10 in VSCode. Is there a work around?

Currently running into the same, issue for windows 10 in VSCode. Is there a work around?
Currently, C++ library isn't support Windows platform.

Closed as stale. The development of the Node.js client has been permanently moved to https://github.com/apache/pulsar-client-node. If it's still relevant, please open an issue there.


Upgrade psycopg2

I think the rollbars we've been seeing on the model endpoints are the result of this issue: https://github.com/psycopg/psycopg2/issues/346
My thought is that we upgrade here and then simulate upgrading jardin in batching.
Not sure if we want to pin to 2.7.7 though -- thoughts? https://pypi.org/project/psycopg2/

I think the rollbars we've been seeing on the model endpoints are the result of this issue: psycopg/psycopg2#346
My thought is that we upgrade here and then simulate upgrading jardin in batching.
Not sure if we want to pin to 2.7.7 though -- thoughts? https://pypi.org/project/psycopg2/

what about psycopg2>=2.7.7

We also need to increment jardin version

@mathieuripert should be good now


libraries/eosiolib/multi_index.hpp: comments still using N(xx) notation

In libraries/eosiolib/multi_index.hpp, numerous comments explaining the usage of multi_index are still using the old N(xx) notation, instead of the new name("xx") or "xx"n

constexpr auto  my = "aaaa"_n; print(my); // evalutate in compiling time
print("bbbb"_n); // evaluate in run time
@larryk85
https://stackoverflow.com/questions/39650122/how-to-ensure-constexpr-function-never-called-at-runtime

#define N(expr) & { constexpr auto x = #expr##_n; return x; }()
Re-add macro N like this? @larryk85

@fingera thanks for bringing that to my attention I just fixed the operator instead of reintroducing a macro.

Resolved by PR #213


Refactored function

Added

getDiagnostic sdk function
getmarketData api function
chainInfo in chain store
marketData in chain store
marketData endpoint url

@AnthonyLaw Can you rebase it off the current master? This way, your commits don't include duplicated work.


Epoch time remaining estimate unavailable

It's broken on the test page and needs investigation.

This has been removed entirely.


OWD project: Document Temporal on MDN

This project proposes that Open Web Docs works on adding Temporal docs to MDN.
Repository: https://github.com/tc39/proposal-temporal
Spec: https://tc39.es/proposal-temporal
Docs: https://tc39.es/proposal-temporal/docs/
Problem statement
Temporal is a stage 3 ECMAScript proposal that aims to replace the JS Date API which has many pain points for web developers.
Temporal is a new API with a large surface area: the API reference is a few hundred properties and methods across 10 different types. It is not just a matter of writing a few PRs to get this documented. It likely makes sense to start work on the docs in parallel to implementations so that there won't be a few-month gap between implementation release and MDN docs for it.
See also https://github.com/tc39/proposal-temporal/issues/1449 for the original request for MDN documentation.
Priority assessment
This table checks this project against the OWD prioritization criteria.

Criteria
Assessment

Effort
Large. A few hundred properties and methods across 10 different types.

Dependencies
None

Community enablement
Possible. Temporal docs can be added collaboratively.

Momentum
High! A replacement for Date is long overdue. Currently stage 3, so probably not yet 100% stable. Implementation work starts now.

Enabling learners
Conceptual material should be added to understand dates, time, timezones, etc. a lot better.

Enabling professionals
Professionals and early adopters will want to know about Temporal as soon as it implemented.

Underrepresented topics / ethical web
N/A. (probably improves l10n/i18n, though)

Operational necessities
N/A

Addressing needs of the Web industry
Date is known as a pain point of the Web. Temporal aims help with that.

Proposed solutions

Start work on documenting Temporal on MDN. Mark it as unstable for the time being, but make progress together with the implementations, so that docs are in shape when the first implementation is ready.
Figure out how much is re-usable from https://tc39.es/proposal-temporal/docs/ and give feedback to these docs and the specification when possible.

Task list
A detailed content plan can be worked out as we go. Some first thoughts:

The reference docs would live under the Standard built-in objects page tree.

This means pages for a few hundred properties and methods across 10 different types.
This will need compat data and interactive-examples for all reference pages as well.

Date and DateTimeFormat docs might need some pointers to the new / better Temporal APIs.
If Date or certain APIs are deprecated or considered legacy now, we should maybe write a guide how to migrate to Temporal (this was proposed in https://github.com/mdn/content/issues/2696) and maybe compare legacy Date APIs and Temporal APIs side by side.
The JS Guide has a chapter on Numbers and Dates. I guess it makes sense to split this up and have a dedicated chapter just for Date and Time. I reckon some guidance around when to use Date, when Temporal and when the Intl API is needed, too? And there is likely a compatibility story to tell there, too.

I decided to rough out part of a directory skeleton.  You can find it here: https://github.com/meyerweb/content/tree/temporal.  The intent is to set up the bare bones of a directory structure approach, for review and approval/disapproval by the group.  Once set up locally, start from en-US/docs/Web/JavaScript/Reference/Global_Objects/Temporal in the browser and files/en-us/web/javascript/reference/global_objects in the file structure.  Only now has a subdirectory at the moment.  I patterned it (more or less) after the Date and Intl directories on MDN.
If this file structure makes sense, I can start filling things in.  If it doesn’t, let’s determine what does make sense, and then we’ll have a path forward.

To be more specific and useful, you can look here on GitHub to see the directory structure (and the few index files, I suppose): https://github.com/meyerweb/content/tree/temporal/files/en-us/web/javascript/reference/global_objects/temporal

If this file structure makes sense, I can start filling things in. If it doesn’t, let’s determine what does make sense, and then we’ll have a path forward.

It does make sense and looks exactly what I would have expected :) Great work!
An option is also to have temporal docs sit in a branch unpublished for a while given it is not yet implemented or stable. I guess this would work well for new pages at least. Amendments to existing pages would likely lead to merge conflicts given all the activity on mdn/content, though.

@Elchi3 what about merging the additions in, but with some descriptive text about how the implementation are WIP instead? Could that work?

Yes, that could work, too.
Do you think it is beneficial to have Temporal on MDN sooner rather than later? (even though the API is still unstable [I assume at least])

My inclination is to keep this in an unpublished branch until the API is fully documented, in the sense that every method/property/etc. has basic documentation and at least one example.  At that point, I could see publishing with a warning note on Temporal pages similar to the one currently used for Date pages (e.g. https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Date).
A thing I discovered (being new to Temporal) is the overlap of methods, with() and toString() being two such.  I’m pondering whether they should have their own subpages in each section—that is, creating Temporal/time/with/index.html, Temporal/yearmonth/with/index.html, Temporal/zonedDateTime/with/index.html, and so on—or if those methods which show up repeatedly should be in a separate unique place like Temporal/with/index.html or Temporal/methods/with/index.html which lists all of the objects in which they appear, with examples of using them in those objects.
I lean toward the latter: I think it should reduce the authoring and maintenance overhead, and would also naturally give readers a sense of methods that are common.  My feeling is that someone clicking on a link to Temporal.time.with() and landing on a page that describes how with() works in general, plus shows examples from all the objects that allow it in one place, will learn more and more quickly than having to pogo-stick up and down a linktree to find out how with() is handled in each object, or which objects don’t have it.
That said, I’m definitely open to counterarguments on this, as I currently have a lot less experience with authoring MDN and API docs than the rest of you.  In the end, I want to do what works best (on balance) for readers, not whatever is easiest or whatever I thought up.

Sorry, forgot to clarify in my last comment: this also applies to properties.

In case it helps, I compiled a survey of method and property frequencies in Temporal, and put it on on Google Sheets for ease of sharing.  Note: Methods are in one tab, Properties in another.

Great to see you diving into the content planning here!
I guess the counterarguments are that the pages for from(), with(), etc. will need to disambiguate and talk about quite a few different contexts then. Maybe that's possible, though, because as you say, maybe describe things conceptional and then present specific examples given the various constructors.
I haven't looked closer but https://tc39.es/proposal-temporal/docs/instant.html#from and https://tc39.es/proposal-temporal/docs/duration.html#from are two from() descriptions and I guess I could imagine having two pages here that present the information. Just a feeling, though.
Not sure if comparable but to attempt to draw a comparison to existing MDN pages: the Intl API has format() on their constructors and we have separate pages:
https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Intl/DateTimeFormat/format
https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Intl/NumberFormat/format
This has also to do with providing different interactive-examples, code examples, spec links, and compat data. The Intl APIs didn't land all at once and so having new pages as the API grows has been a good thing. (Not sure if Temporal grows, but usually all Web APIs grow sooner or later :)

I’ve found a couple of discrepancies.

https://tc39.es/proposal-temporal/docs/#Temporal-now lists Temporal.now.plainTime(calendar) but https://tc39.es/proposal-temporal/docs/now.html does not.
The TOC for https://tc39.es/proposal-temporal/docs/plaindatetime.html lists the properties era and eraYear twice.

@meyerweb thanks! https://tc39.es/proposal-temporal/docs/#Temporal-now is outdated, I removed those methods but missed them there. Would you like to file an issue on the temporal repo?

So only Temporal.now.plainTime() was removed from now, or was plainTimeISO() also removed?

Issues filed.
Progress: I picked the lowest-hanging fruit and filled out Temporal.now’s methods with pages of their own.  They can be previewed in https://github.com/meyerweb/content/tree/temporal/files/en-us/web/javascript/reference/global_objects/temporal/now (or in your own local copy).  Feedback is welcome, particularly if you spot anything incorrect or missing.
Note: As I write this, the methods plainDateTime() and zonedDateTime() lack examples, because I’ve been utterly shamelessly stealing the examples from https://tc39.es/proposal-temporal/docs/now.html, and those two don’t have examples for me to steal.  Happy to take contributions if anyone has them; if not, I’ll make up my own based on other examples.

I’ve let commenting on this issue languish, but I’ve been making progress and am now very close to being ready for an actual PR.  The reference pages are all done, modulo a few bits of structural cleanup and adding an advisory banner to the tops of all the pages.  The content itself has been through review and editing at Igalia.
The branch of my fork is here for those who’d like to preview what I have: https://github.com/meyerweb/content/tree/temporal/

@meyerweb That's great news!
Heads up: there are some changes coming to the docs from https://github.com/tc39/proposal-temporal/pull/1492.  We'll (hopefully) get approval for the underlying spec changes in next week's TC39 plenary meeting, after which we'll merge all the pending draft PRs, including for the docs. So it probably makes sense to wait to PR the docs into MDN until those changes are in the MDN docs too. There are no other significant docs changes on the radar, AFAIK.
Also, have you been tracking docs PRs in the Temporal repo and making parallel changes to your docs?  Want to make sure that doc fixes make it into both places. There's only a few relatively minor changes recently, but there have been a few like these:

https://github.com/tc39/proposal-temporal/pull/1503
https://github.com/tc39/proposal-temporal/pull/1512
https://github.com/tc39/proposal-temporal/pull/1396

Also, once the docs are in MDN, will we remove the docs on the Temporal side and PR any future docs changes only into MDN?
Finally, what's the release plan?  Will we wait until the first browser implementation ships before merging into prod MDN?  Or does it make sense to put the docs in MDN even before a browser ships with Temporal?

Thanks, @justingrant!  I’ll check the changes to make sure they’re reflected; I’ve been making some changes in parallel but I’ll make sure they’re in, and I’ll continue stay on top of any future changes.
On the question of the docs’ home, I personally would be fine with removing the TC39 docs and PR changes on MDN — but, as a newcomer to all this, I’ll defer to those with longer experience with Temporal and TC39 process.  That said, removing the TC39 copies would need to wait until all the relevant documentation has been migrated.  As of now, what’s ready for review is the reference pages.  More discursive content (e.g., all the things linked in https://tc39.es/proposal-temporal/docs/#other-documentation) has yet to be converted to MDN.  They’re next on my roadmap, to be clear, but not done as of this moment.
On the question of the release plan, there are currently discussions about how to label MDN content covering features not yet implemented (e.g., https://github.com/mdn/content/issues/5118).  Once that’s settled, I’ll update the PR with whatever solution is agreed upon, assuming it’s settled before there’s a shipping implementation, and be ready for merging.
I’m also planning to add interactive examples that incorporate the polyfill, and am currently in the process of determining the best way to structure that.  Wrapped up in that will be determining the best way to provide the polyfill via MDN for people to download.  I hope those two updates in particular will help speed adoption of Temporal, but they might lag behind initial publication of the docs on MDN.

Update on changes: I brought over a few changes from https://github.com/tc39/proposal-temporal/pull/1396 that were missed; the rest were already in place thanks to the timing of my work against that PR being merged.  https://github.com/tc39/proposal-temporal/pull/1512 was already represented, and https://github.com/tc39/proposal-temporal/pull/1503 has yet to be migrated, so no problem there.

@meyerweb FYI Firefox has just added its stage 3 implementation behind a flag: https://bugzilla.mozilla.org/show_bug.cgi?id=1519167
So we're coming up to the time we will need MDN documentation. Can you give me a view on where you see your current updates? I.e. have you been tracking changes in the spec? How close are these docs to the existing status and MDN JavaScript docs conventions? I haven't look at what you have done yet at all - trying to understand the best way to move forward.

I'm closing this as not planned for the moment. When Temporal is ready, we will of course offer help with compat data and documentation as needed.
I think Eric's draft still lives at https://github.com/meyerweb/content/tree/temporal but it's quite likely that the specification has changed quite a bit since 2021. https://tc39.es/proposal-temporal/docs/ might be more up to date but I haven't checked.

https://tc39.es/proposal-temporal/docs/ might be more up to date but I haven't checked.

This site is indeed kept up to date. There have been a few public-facing changes since 2021, but relatively few. And it'd be easy to look at git history to identify where changes were. So I'd assume that any docs work from 2021 is still almost entirely useable.
We're about to propose removing a lot of stuff from Temporal in response to implementers' size concerns, so that will cause corresponding removals from the docs, but shouldn't cause docs of remaining functions to be out of date.


4.0.2 - Pagination / Dynamic Bullets RTL mode

[x] bug
Swiper Version: 4.0.2
Live Link Codepen: https://codepen.io/ezra_siton/pen/vebqbd

What you did
First, this is very cool new feature.
The Pagination styles and active states look buggy. See codepen.

Thanks!


Testimonials text responsive and bordering on dark mode.

Is there an existing issue for this?

[X] I have searched the existing issues

What happened?
The testimonial cards are not visible on the dark mode , only the image and name is visible . I will add some shadow boxing to it so that it will look as cards in dark mode as well. And need to make the text in the testimonials responsive as well .

Record

[X] I agree to follow this project's Code of Conduct
[X] I'm a GSSOC'24 contributor
[X] I want to work on this issue

Assigned!
Make sure to attach before & after screenshots in your PR. Also, star the repo before working on it. While creating your PR, ensure you pull all existing changes beforehand to avoid conflicts.
Happy open-source contributing!


Tracking milestone changes

Add/Set an empty CHANGES.md file in the beginning of work on every milestone. This file would include a summary of relevant changes (including breaking changes) across repos and SDKs. This would later become the release notes. The idea is to have a place to track relevant changes as we go. In the end, the changes will follow the release branch, so users and devs have a readable history of changes baked in the branch.

If release notes are included in PRs (for example https://github.com/kubernetes/kubernetes/pull/64503), there are tools that help with release notes gathering like this one from Kubernetes project https://github.com/kubernetes/release/tree/master/cmd/release-notes
It looks pretty simple to use. However it does not handle reverted commits (for an example: search for the mentioning of 64365 in https://gist.github.com/marpaia/acfdb889f362195bb683e9e09ce196bc. There are two release notes: one for the PR and one for the revert PR). If reverts are rare we could manually check for them right before checking in a release note. If they are common we will probably need to find another way or enhance the tool to support handling of reverted commits.
cc @wcs1only

With the addition of RELEASE NOTES to Issues, are we still planning to include CHANGES.md?


export nodeType

It doesn't seem like this was excluded on purpose since it isn't used inside the module?
Needed for https://github.com/garyb/purescript-dom-classy/pull/5

Thanks! Yeah, hiding this export was accidental.


type object 'Bot' has no attribute 'watch_user_reels'

type object 'Bot' has no attribute 'watch_user_reels'
Why this is error ??

Could you provide your code and relevant logging file? Or at least (if applies) the used example, so that we can reproduce or investigate this error?


mne anonymize command

we should have the command equivalent of
$ mne_anonymize
usage: mne_anonymize [options]
Remove subject information from a fif file.
	--his             remove the HIS ID tag as well
	--file name       the file to modify.
	--help            print this info.
	--version         print version info.

I'm happy to take it, if no one started.

go for it.
it would be nice to allow be able to operate inplace too but fine to do it
in a subsequent PR.

okay, but please help me understand --his parameter.
Since in mne.io.meas_info.anonymize_info we remove whole subject_info key so his_id as well by default. Should I modify anonymize_info function to preserve this depending on some his flag?

removing it all the time is good. Forget the --his param.

this was closed in #6892


serialization: fix a bug, improve doc and clean weird condition

tests?

@privat  Sure! when #2296 is fixed.

+1

+1


Update meta.yaml

While trying to install a new soconda on Princeton Della for development purposes, I got the following error while compiling so3g:
SHA256 mismatch: '48a1f66ba1eca0c6035780257b70eafd1fd9651a0dcec31a74f7143851480a71' != '468b1a813fa1baf1134f7041898380b0552fe3a02f0fdbe450ac1e452bbae349'

I updated the YAML file as this PR and so3g was installed correctly. It may be a general diff from so3g.

I have seen this kind of thing before with a stale download.  Let me go double check something and will reply soon.


fix: JSON loading logs

SUMMARY
https://github.com/apache/superset/pull/28702 unified JSON calls to a single module which is great. Unfortunately, that PR also altered the default behavior when loading a JSON object and added a log entry every time an invalid object is parsed to the utility function. It is the responsibility of the caller to decide how to deal with an invalid JSON. In many places, a default empty object is used when an invalid JSON is received and there's no need for extra logs. This PR restores the previous behavior.
Fixes https://github.com/apache/superset/issues/30079
TESTING INSTRUCTIONS
Check the original issue for instructions.
ADDITIONAL INFORMATION

[ ] Has associated issue:
[ ] Required feature flags:
[ ] Changes UI
[ ] Includes DB Migration (follow approval process in SIP-59)

[ ] Migration is atomic, supports rollback & is backwards-compatible
[ ] Confirm DB migration upgrade and downgrade tested
[ ] Runtime estimates and downtime expectations provided

[ ] Introduces new feature or API
[ ] Removes existing feature or API

@michael-s-molina - good catch, thanks
@mistercrunch - indeed , at least now we got it all in one place ☺


Configure Azure Pipelines

This pipeline configuration builds the application and produces a build for the Release configuration.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: nkumajhi sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.


[Bug]: can not close dark mode in doc core

Version
@modern-js/doc-core @latest

Details
I want to close dark mode and set themeConfig.darkmode:false, but it is not valid.
Reproduce link
empty
Reproduce Steps

doc.themeConfig.darkMode: false
In a doc project dir, run modern dev
Can also enable darkMode.

I'll fix it.


Class ctors

@h1alexbel take a look, please

PR-Codex overview
This PR adds constructors to the KeySerializer, ValueSerializer, KeyDeserializer, and ValueDeserializer classes that accept a serializer/deserializer class. It also adds tests for these constructors.
Detailed summary

Added constructors that accept a serializer/deserializer class to KeySerializer, ValueSerializer, KeyDeserializer, and ValueDeserializer classes
Updated the constructors to use serializer.getCanonicalName() and deserializer.getCanonicalName()
Added tests for the new constructors

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@l3r8yJ thank you for your Pull Request. I'll assign someone to review it soon.
If this PR solves a todo from the code, please don't forget to remove it.

@l3r8yJ please review this Pull Request. Deadline (when it should be merged or closed) is 2023-06-14T09:09:05.145811.
You should check if the requirements have been implemented (partially or in full), if there are unit tests covering the changes and if the CI build passes. Feel free to reject the PR or ask for changes if it's too big or not clear enough.
Estimation here is 30 minutes, that's how much you will be paid. You will be paid even if this PR gets rejected.

@rultor merge

@rultor merge

@h1alexbel OK, I'll try to merge now. You can check the progress of the merge here

@rultor merge

@h1alexbel Done! FYI, the full log is here (took me 2min)

@l3r8yJ thanks!

@l3r8yJ thank you for resolving this ticket. I've just added it to your active invoice. You can always check all your invoices and more on the Contributor Dashboard.


2019 mac air collapse

Issue Type: Feature Request
On the MAC, tasked.json in VSCODE, when I swiped the trackpad with my fingers, suddenly the program crashed and couldn't close. The problem was solved only when I rebooted the computer
VS Code version: Code 1.47.2 (17299e413d5590b14ab0340ea477cdd86ff13daf, 2020-07-15T18:18:50.054Z)
OS version: Darwin x64 19.6.0

Are you still facing this crash ? If so, can you launch code with --crash-reporter-directory <path>, once the crash happens can you attach the *.dmp file generated under the <path>. Thanks!
It is also worth verifying if the crash happens with our exploration builds https://az764295.vo.msecnd.net/exploration/f0e1fbf4cb8c4c27d6290f0310f5a4d63597cd21/VSCode-darwin-exploration.zip


add to registry

@JuliaRegistrator register branch=main
Release notes:
Initial registration

Registration pull request created: JuliaRegistries/General/64643
After the above pull request is merged, it is recommended that a tag is created on this repository for the registered package version.
This will be done automatically if the Julia TagBot GitHub Action is installed, or can be done manually through the github interface, or via:
git tag -a v0.0.1 -m "<description of version>" 5612e4bef90709e1a157e5adb925383fd8eaa223
git push origin v0.0.1

@JuliaRegistrator register branch=main
Release notes:
Initial registration

Registration pull request updated: JuliaRegistries/General/64643
After the above pull request is merged, it is recommended that a tag is created on this repository for the registered package version.
This will be done automatically if the Julia TagBot GitHub Action is installed, or can be done manually through the github interface, or via:
git tag -a v0.0.1 -m "<description of version>" ac46f0a044cff5c9314a7333a232fed464998c15
git push origin v0.0.1

@JuliaRegistrator register branch=main
Release notes:
Initial registration

Registration pull request updated: JuliaRegistries/General/64643
After the above pull request is merged, it is recommended that a tag is created on this repository for the registered package version.
This will be done automatically if the Julia TagBot GitHub Action is installed, or can be done manually through the github interface, or via:
git tag -a v0.0.1 -m "<description of version>" 286dfb715eea119744b7639920d9910a78e0e31d
git push origin v0.0.1


Feature/variation legend

Merged manually: https://github.com/Ensembl/ensembl-webcode/commit/9a818d6db744acc759dbf3dde63b380ddb7bf232


A3P-39: switch readonly variables from storage to memory

Realized that I was using storage instead of memory for local vars on those getter functions that I created just to avoid the "stack to deep" error in AirnodeTokenPayment.sol

I prefer using storage any time the variable is read-only. What are the implications?

I prefer using storage any time the variable is read-only. What are the implications?

Even though it might be a bit more expensive to use memory (since we are making a local copy) I was thinking it is safer and more semantic to do that inside a view or getter function since this function should not be modifying the values in the state var.

Actually can you test and report the gas usage with both?

Actually can you test and report the gas usage with both?

When using storage:
·----------------------------------------------------------------------------|----------------------------|-------------|-----------------------------·
|                            Solc version: 0.8.9                             ·  Optimizer enabled: false  ·  Runs: 200  ·  Block limit: 30000000 gas  │
·············································································|····························|·············|······························
|  Methods                                                                                │
·······································|·····································|··············|·············|·············|···············|··············
|  Contract                            ·  Method                             ·  Min         ·  Max        ·  Avg        ·  # calls      ·  eur (avg)  │
·······································|·····································|··············|·············|·············|···············|··············
|  AirnodeTokenPayment                 ·  makePayment                        ·           -  ·          -  ·     149452  ·            2  ·          -  │
·······································|·····································|··············|·············|·············|···············|··············
|  Deployments                                                               ·                                          ·  % of limit   ·             │
·············································································|··············|·············|·············|···············|··············
|  AirnodeTokenPayment                                                       ·           -  ·          -  ·    2655495  ·        8.9 %  ·          -  │
·----------------------------------------------------------------------------|--------------|-------------|-------------|---------------|-------------·

When using memory:
·----------------------------------------------------------------------------|----------------------------|-------------|-----------------------------·
|                            Solc version: 0.8.9                             ·  Optimizer enabled: false  ·  Runs: 200  ·  Block limit: 30000000 gas  │
·············································································|····························|·············|······························
|  Methods                                                                                │
·······································|·····································|··············|·············|·············|···············|··············
|  Contract                            ·  Method                             ·  Min         ·  Max        ·  Avg        ·  # calls      ·  eur (avg)  │
·······································|·····································|··············|·············|·············|···············|··············
|  AirnodeTokenPayment                 ·  makePayment                        ·           -  ·          -  ·     149452  ·            2  ·          -  │
·······································|·····································|··············|·············|·············|···············|··············
|  Deployments                                                               ·                                          ·  % of limit   ·             │
·············································································|··············|·············|·············|···············|··············
|  AirnodeTokenPayment                                                       ·           -  ·          -  ·    2655495  ·        8.9 %  ·          -  │
·----------------------------------------------------------------------------|--------------|-------------|-------------|---------------|-------------·

Gas usage seems to be negligible.

The main idea of using memory was that a `view` functions should never change state and I thought that a good way to prevent that is by making copies in memory of state vars instead of using pointers but I also understand that higher gas usage might be an issue too.

So that 206 gas is the reason why I prefer storage over memory for view functions. It is indeed error-prone because you may end up updating that variable forgetting that you're also updating storage, but that's what the view modifier is there for. So I'm closing this PR, but conceding the fact that using storage here is a subjective decision with potential downsides.


Will not log unless reception center status changes

I'll approve this, but we will need to support multiple centers in the future. Issue #35 has details.


Enable Highcharts context menus

Not sure if this is a single toggle or impossible, please let me know. This task is to enable the "hamburger menu" on all our charts so that more options can be performed on them:

If the options are available, please ensure only the options in the above screenshot from CESI are enabled.

Hey team! Please add your planning poker estimate with ZenHub @RyanCoulsonCA @yileifeng @spencerwahl

Added value: Have a configurable toggle to enable or disable the hamburger menu entirely.


Release version 0.2.0

I'd like to get 0.2.0 out the door by the end of June. Normally, I'd want to set some goals for things to include in a release, but this one is kind of simpler

everything that's gone in the last ~3 years
verified working guide for running on windows
verification that at least 3 of the bindings work

I expect this first go will be bumpy. To meet the end-of-June goal, I plan to cut a release branch off of master starting June 15th (barring special circumstances).

If folks could volunteer for testing particular data store bindings that would be a super big help. To make the release notes the testing will have to be on one of the release candidates, but seeing if things work at all right now (and filling in missing READMEs) would be grand.

I think #250 and #261 will have to be blockers.

we need a manual check that #91 behaves correctly.

My kid was ill over the weekend, so I didn't get to finish #250. Presuming no one has a strong objection, I'm going to punt the release branch to Wednesday Jun 17th.

All of the blocker and critical issues for 0.2.0 are solved now, so shortly I'll create the release candidate branch and post up what kind of testing I'd like to see here.

release branch blocked on #306

Here's my plan for driving the release:

Branch 0.2.0 (0.2.0-staging) and tag version 0.2.0-RC1 (source only)
Testers should build and use either the distribution artifact (ycsb-0.2.0-RC1.tar.gz) or a binding specific distribution (e.g. ycsb-hbase-0.2.0-RC1.tar.gz)
Testers should file issues/prs for problems found
Fixes for issues should go to master. I'll pull things back to the release staging branch. if you are feeling generous feel free to cherry-pick bug fixes back, but no new functionality please (adding a README.md so that a datastore gets its own distribution tarball is fine)
When issues come up, I'll start cutting new release candidates every other day off of the 0.2.0-staging branch.
When the final release is published, I'll delete the branch. The tag from the release will remain as a starting point if we need to make a patch release.

Successful testing of a datastore binding should be noted here. please include:

datastore binding (e.g. hbase)
version of datastore tested against (e.g. hbase 1.0.0 cluster)
if the datastore has different single node / clustered modes, which was used (e.g. hbase standalone)
OS for client
packaging used (either the distribution artifact or a datastore specific artifact)
workload used
other options used

Things we need to get through for a release:

release notes (which I'll build as we test things)
running on windows for some datastore binding
running 3 datastore bindings (other than basic / test ones)
verification that the different histogram options from #214 work
verification that the export to text / json / json array works
verification that the data verify from #91 works

The final release will have

notes

compatibility changes for workload / bindings downstream
datastore binding changes (new bindings or support for additional version support)
measurement changes
exporter changes

source download
convenience binary distribution artifact
any datastore binding specific tarball that we've tested

Another thing we need to check: licensing for dependencies that are getting packaged in.

RC1 is available now (ref status page)

I'm happy to try Hadoop, Cassandra.

Excellent. I'll try to get through testing on Windows and take a look at Accumulo.
@allanbank any chance you could take on testing Mongo?
@bigbes could you try out the generated Tarantool artifacts?

@busbey of course, i'll try them tomorrow, if you don't mind?

tomorrow works for me. I'm fairly certain there'll be another RC and I likely won't make that until Sunday or Monday.

I will take it for a test drive but probably won't have a solid block of time until Sunday.

Sunday is totally fine.
On Jun 19, 2015 6:07 PM, "allanbank"<EMAIL_ADDRESS>wrote:

I will take it for a test drive but probably won't have a solid block of
time until Sunday.
—
Reply to this email directly or view it on GitHub
https://github.com/brianfrankcooper/YCSB/issues/266#issuecomment-113667861
.

I did some quick tests on:
HBase 1.0.0 (hbase-10 client).
Cassandra 2.0.15 (cassandra-cql and cassandra-10 clients).
I ran into #302 and #293, but otherwise things seem to work fine.
Tested:

Loading 1000 records (workload A)
Running workload A
Running workload A with coordinated omission (target=15000; my desktop can't hit that).
Running workload A with HDR Histogram + intended latency reporting (latencies get impressively large).

Results in this gist. Things look reasonable to me.
I think #302 is a blocker; I can't decide about #293.

With #302 closed now I'll make a new RC tomorrow morning so folks who want to test over the weekend don't hit it.

@steffenfriedrich if you have the time to try out the different exporters using the release candidate that would be a big help. Understandable if you're too busy.

RC2 is now available. If you are still testing, please switch to it. (ref release page)

filed #313 for current RAT flagged failures. I'll check them one more time to make sure it's just missing headers (there's a bunch of noise). Presuming it's just the missing headers it's not a blocker.

I am not finding the Client when I run from the command line:
$ bin/ycsb load -db mongodb -s -P workloads/workloada -threads 10 -p "mongodb.url=mongodb://<IP_ADDRESS>:27017/ycsb?w=1&maxPoolSize=10&waitQueueMultiple=10"
java -cp /home/rjmoore/ycsb-testing/YCSB-0.2.0-RC2/mongodb-binding/conf com.yahoo.ycsb.Client -db com.yahoo.ycsb.db.MongoDbClient -db -s -P workloads/workloada -threads 10 -p mongodb.url=mongodb://<IP_ADDRESS>:27017/ycsb?w=1&maxPoolSize=10&waitQueueMultiple=10 -load
Error: Could not find or load main class com.yahoo.ycsb.Client

This was a fresh pull on the RC2 source followed by a mvn clean package:
wget https://github.com/brianfrankcooper/YCSB/archive/0.2.0-RC2.tar.gz
tar xzvf 0.2.0-RC2.tar.gz
cd YCSB-0.2.0-RC2/
mvn clean package

I can run test if I unpack the MongoDB distribution.
The README for the MongoDB driver is based on pulling the source, running a mvn package and then running from the source directory. Is that no longer supported?  Is the plan to provide pre-build binary distributions?
Rob.

We do provide binary distributions as well as source. The preference will
be use of the binaries, since it's less steps to mess up.
We should still have running out of a built source tree though. Can you
file an issue? Not sure if it should be considered blocking.
We'll need to do a sweep of the instructions either way.
On Jun 21, 2015 6:01 PM, "allanbank"<EMAIL_ADDRESS>wrote:

I am not finding the Client when I run from the command line:
$ bin/ycsb load -db mongodb -s -P workloads/workloada -threads 10 -p "mongodb.url=mongodb://<IP_ADDRESS>:27017/ycsb?w=1&maxPoolSize=10&waitQueueMultiple=10"
java -cp /home/rjmoore/ycsb-testing/YCSB-0.2.0-RC2/mongodb-binding/conf com.yahoo.ycsb.Client -db com.yahoo.ycsb.db.MongoDbClient -db -s -P workloads/workloada -threads 10 -p mongodb.url=mongodb://<IP_ADDRESS>:27017/ycsb?w=1&maxPoolSize=10&waitQueueMultiple=10 -load
Error: Could not find or load main class com.yahoo.ycsb.Client
This was a fresh pull on the RC2 source followed by a mvn clean package:
wget https://github.com/brianfrankcooper/YCSB/archive/0.2.0-RC2.tar.gz
tar xzvf 0.2.0-RC2.tar.gz
cd YCSB-0.2.0-RC2/
mvn clean package
I can run test if I unpack the MongoDB distribution.
The README for the MongoDB driver is based on pulling the source, running
a mvn package and then running from the source directory. Is that no
longer supported? Is the plan to provide pre-build binary distributions?
Rob.
—
Reply to this email directly or view it on GitHub
https://github.com/brianfrankcooper/YCSB/issues/266#issuecomment-113966304
.

Submitted #315.

See issue #316.  Not a blocker as far as I am concerned but fixing improves usability.

I finished the first round of testing with MongoDB.  For this round I ran each workload (a-f) against a single MongoDB instance running on the same machine as the the YCSB client. For each run I varied the number of client threads and connection to MongoDB and the version of MongoDB running.
Tested Versions:

MongoDB 1.8.5: mongodb-async (the mongodb does not support 1.8).
MongoDB 2.0.9: mongodb and mongodb-async
MongoDB 2.2.7: mongodb and mongodb-async
MongoDB 2.4.14: mongodb and mongodb-async
MongoDB 2.6.10: mongodb and mongodb-async
MongoDB 3.0.4: mongodb and mongodb-async

That is the latest patch release for all production MongoDB versions released since 2011.
All MongoDB instance ran with a single command line option:
mongod --dbpath .

Issues Found:
#315 - Cannot run YCSB from the source tree.
#316 - StatusThread keeping the client running for 20 seconds after the test completes.
#314 - Saw several instances of reads in Workload D returning 1 which means the query did not find the document.
I will do another round of tests with MongoDB 3.0.4 varying the storage engine and the cluster configuration.
Rob

@busbey i'm sorry for delay, i'll check this today

No worries, we all get busy. Thanks for whatever time you get to spend on
things.
On Jun 22, 2015 1:45 PM, "bigbes"<EMAIL_ADDRESS>wrote:

@busbey https://github.com/busbey i'm sorry for delay, i'll check this
today
—
Reply to this email directly or view it on GitHub
https://github.com/brianfrankcooper/YCSB/issues/266#issuecomment-114215542
.

Issue #301 is now in the staging branch. I'd like to get #315 in before cutting RC3. If no one else gets to it I'll take care of it in time for an RC on wednesday night (CT).

@busbey I've tested Tarantool bindings from distribution. Everything works fine, except scan operation. I'll check it and fix

RC3 is now available. if you are still testing, please use it (release page)

There is an issue with the MongoDbClient doing scan operations. I have been working with the MongoDB folks to try and figure out what the issue is but I think it is within the driver itself.  MongoDB ticket is: https://jira.mongodb.org/browse/SERVER-19273
Rob.

last week I ran RC2's hbase specific distribution through the recommended series of core workloads using the hbase-10 client against an HBase CDH5 cluster. Everything went fine, including export to JSON (didn't try the export to JSONArray version)

I ran through using RC3 for the basic binding on Windows 7. Ran into #335, but otherwise was fine. Added a proposed wiki page to #246.

Ran RC3 through the recommended workload sequence for ~1 hour per step against an Accumulo cluster. Ran into #340 at cleanup of the initial load step, but otherwise everything looked fine.

@allanbank since the issue is in the Mongo driver and only impacts scan workloads, are we fine just labeling it a known issue? we can then fix it in the YCSB release after whatever gets worked out on the mongo ticket.
(also, if you have a second please take a look at this issue)

I think all that's left before release is

release notes
verification that the export to text works
verification that the data verify from #91 works

I'll start writing up draft release notes tomorrow.

@busbey - I wrote a ticket (#344) for the MongoDB scan issue so you can reference it in the release notes. (and I can commit against it once it get fixed).

proposed release notes

worth noting that the issue refs (e.g. #266) will show up as links when in the release notes.

Release notes look good to me.

release is live: https://github.com/brianfrankcooper/YCSB/releases/tag/0.2.0
Thanks everyone! Let's start sending announcement emails.

Thanks, Sean!
On Jul 7, 2015 7:24 PM, "Sean Busbey"<EMAIL_ADDRESS>wrote:

Closed #266 https://github.com/brianfrankcooper/YCSB/issues/266.
—
Reply to this email directly or view it on GitHub
https://github.com/brianfrankcooper/YCSB/issues/266#event-350325078.


能改成python3的代码吗，win10系统装不了python2的tensorflow

I am just working on fixing this issue by making the library python2/python3 compatible. For now it seems that the main thing is just print. Anything else I should look for? For now it seems that it runs well.


您好，我想知道如何获取的offset_Tick？

请问能否告知呢？

Could you please tell me?

offset_Tick = 0x2AB44D0

你能告诉我吗？

offset_Tick = 0x2AB44D0

这个数值是如何得到的呢，由于我玩的是学习版，这个数值好像不对，我想知道咋获取我去更新他

Open your IDA, quickly filter "APalPlayerCharacter::tick" in the function list, and go to the function header to get its offset

Owner

Okay, thank you very much for your answer

Might aswell use dumper-7 to dump xbox store version SDK and use that to make sure all offsets are right ?

I tried doing this, it throws 100 errors about redefinitions. I made them go away and got it to compile, but it still doesn't work, nothing from the menu works when I click it.


Turn EmailAuthBackend on by default in development environment

Currently, in the development environment, we only enable the DevAuthBackend (the click-to-login) thing, and require the user to go through some non-obvious steps fiddling with config files that aren't in .gitignore to test password authentication / the login process.  I'd like to eliminate those extra steps.  In large part the reason we haven't done this already is that this is super ugly:

I think we can improve this a lot by changing the arrangement on the login page to put DevAuthBackend above the password login flow (or maybe do a side-by-side block structure with the DevAuthBackend buttons on the left, and the "normal" login UI that one would get in production on the right), and adding some reasonable space separating things, so that things look reasonably good, and then turn on email auth.
There's a few related things that could be part of this project:

Restructuring the DevAuthBackend view code to separate out the different realms ("community users" is actually a second realm) and maybe look a bit nicer now that we have ~9 users rather than 5 by default.
Enabling Google and/or GitHub auth could also be good, but is messier; I opened https://github.com/zulip/zulip/issues/3651 for that.

I think the only tricky requirement here is that we want to make sure we don't modify the CSS for what the login page looks when DevAuthBackend is disabled.

An alternative strategy to consider would be to move DevAuthBackend to a totally separate URL, like /devlogin, with a prominent login to /login for folks who want to test password auth on that page, and change HOME_NOT_LOGGED_IN (aka where you get redirected to by default) to /devlogin in development.

I think second strategy will be more cool.

OK, seems worth trying that out.

yup
@zulipbot  claim

@zulipbot claim


Use "tslint:recommended" instead of "tslint:latest"

Somehow #35 didn't take effect. Doing it again.

@andy-ms,
Thanks for your contribution as a Microsoft full-time employee or intern. You do not need to sign a CLA.
Thanks,
Microsoft Pull Request Bot


CanvasMarker instead of CanvasIconLayer

CanvasMarker should be compatible with all other leaflet layers / layers groups, to use it completely transparent. E.g. to be able to add each marker to any existent layergroup, and process all events.

Or it would be like this:
L.Marker.mergeOptions({ renderer: L.CanvasIconLayer }); // doesn't work now


Accessing the widgets shown in screenshots

Are the widgets shown in the readme screenshots separate from this project? If they are included, how are they accessed? I see the Widget Manager which allows me to open the Logs menu, but I can't seem to access anything beyond this. Are there keybinding or some other form of input?

Those widgets are separate, they come from the game scripts.
In the case of TLAD, I was using the debug scripts accidentally included in the initial release of GTA IV: Complete Edition, that's why there's so many widgets in the screenshot. You should be able to find them somewhere on the internet.
As for TBoGT and base GTA IV, it creates some widgets during some missions (like the first TBoGT mission, don't remember if any GTA IV mission created widgets), but, since we only have their release scripts, there's not many widgets left.


Update Segmentfault to StackOverflow

What is the purpose of the change
resolve #312 and fix typo
Brief changelog
site_config/community.jsx
Follow this checklist to help us incorporate your contribution quickly and easily:

[x] Make sure there is a GITHUB_issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
[ ] Format the pull request title like Fix UnknownException when host config not exist #XXX. Each commit in the pull request should have a meaningful subject line and body.
[ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
[ ] Test your code locally by running docsite start, and make sure it works as expected.
[ ] Make sure no files under build directory is added.
[ ] If this contribution is large, please follow the Software Donation Guide.

it looks like this:

Hi, it is still being discussed in the mailing list, let's wait for a few more hours, typically in Apache a decision needs to be make for at least 72 hours.

Let's merge it now :)


[SIP-63] Incorporating other map sources in Superset

[SIP] Proposal for Incorporating other map sources in Superset
Motivation
Superset currently uses MapBox to display maps which has its own limitations. There are other map sources available as Web Map Services (WMS). For example, Open Street Maps (OSM) that can be called upon using many js libraries like Leaflet or OpenLayers. This would pave way for more GIS functionalities in SuperSet in true open source spirit.
Later, the same could also apply to the deck,gl visualizations that simply use mapbox for its simplicity.
Proposed Change
Module can be created that permit adding WMS services during the creation of charts. Other features may include:

Adding multiple layers and providing facility to turn them on/off.
Permitting clicking on features (points) to show a popup with more data/links on the map itself.

New or Changed Public Interfaces
Same as described above.
New dependencies
Leaflet (https://www.npmjs.com/package/leaflet) and OpenLayers (https://www.npmjs.com/package/ol)
Migration Plan and Compatibility
Should work with existing setup.
Rejected Alternatives
I am proposing considering the open data sources right now. So, no Google/Bing maps etc.
Describe alternative approaches that were considered and rejected.
I would like to attempt this but I am really at a loss for where to begin with implementing it. I have seen discussions about new chart types here and although the documentation is old regarding that, some of the issue threads provide pointers in the right direction.
I intend this thread to be something of the same kind where some of the developers may point us to the right section of the code where we can begin exploring and implementing open source mapping visualizations.
I hope the developers see some merit in it.

Any Update on this ?

I would be interested in engaging with the community about this. MapBox is a non-starter for us and a solid block for us to use Superset. Are there plans to implement support for open mapping projects? We would be interested in helping to get open mapping projects added so the package is a truly open source solution.

@juen1jp I'm sure a contribution would be warmly welcomed by the community. As it will probably be a major change, I would propose opening a SIP (Superset Improvement Proposal) to make sure the community is able to chime with ideas and concerns prior to any major development work taking place.

@juen1jp I'm sure a contribution would be warmly welcomed by the community. As it will probably be a major change, I would propose opening a SIP (Superset Improvement Proposal) to make sure the community is able to chime with ideas and concerns prior to any major development work taking place.

@villebro I opened this thread as a SIP itself. Are you proposing a fresh SIP be opened?
I just need a few indicators regarding what part of the code to look into, as in, the code files that make the mapbox magic happen. Just searching with 'mapbox' keyword in the code files has not given me much to go upon.

@gk1089 my bad, I didn't notice this was in fact opened as a SIP as it wasn't indicated in the title. The title should be prefixed with [SIP-XX] where XX is the next available unused SIP id. I believe SIP-50 is the next available id.
I assume most mapping systems require some for of token. This should be added to config.py so that it can be defined in the local superset_config.py. Currently the mapbox token is returned by viz.py to the relevant visualizations; I believe the plan is to return this type of data in the bootstrap payload in the future. The committers can surely help with the details once we get that far. I propose reaching out on Slack, e.g. the #visualization_plugins channel.

@villebro Thanks for your response. As far as I understand it, tokens are compulsory only for metered map services like MapBox, ESRI, Bing, Google map services etc. For the open map services like Open Street Map (OSM), this is not a requirement and maps can be accessed directly by including the corresponding (Web Map Service) WMS URL through some js libraries like Leaflet or OpenLayers.
For example, I found the WMS URL (http://maps.heigit.org/osm-wms/service?REQUEST=GetCapabilities&SERVICE=WMS) for a world map on the info section of https://www.osm-wms.de/, which in turn was found on the OSM page on WMS (https://wiki.openstreetmap.org/wiki/WMS). I can use this WMS URL to show a map in my own page and the corresponding Leaflet/OpenLayers library will provide me tools to navigate on the map, show popups, make measurements etc.
It would be great to have the same control through a custom Superset visualization.
I shall try to join the slack and discuss it there and I request @juen1jp to chime in with his ideas. Meanwhile, may I request you to tag contributors who may have worked on the mapbox module in the past to share their take on this in this thread.

@villebro May I also request for this thread to be marked as active. It is currently marked as 'closed' by the activity bot.

In case there is no need for a token, then this will be quite straight forward, and should not be any different from any other new viz plugin. Please see the Hello World blog post on how to get started of you haven't already.

In case there is no need for a token, then this will be quite straight forward, and should not be any different from any other new viz plugin. Please see the Hello World blog post on how to get started of you haven't already.

Thanks! I was not aware of this post.
While I have a go at it, for the sake of reusing the code is it possible to point to the files which deal with the existing MapBox code?

That sounds fair. Between the Hello World blog post (thanks a lot, @villebro) and ECharts examples could a JS newbie implement the leaflet EChart example into Superset? Could you point me in other places you'd look if you were to implement such a chart into Superset?

Keeping the alternate plugins outside seems like the smart way to go for me too. Perhaps we should instead close this and open another SIP focused on formalizing the plugin ecosystem (although I am assuming that is already on the roadmap)

we'll start to investigate those questions soon. Probably there will be some stuff that we can provide.

Keeping the alternate plugins outside seems like the smart way to go for me too. Perhaps we should instead close this

I'd propose not to close this and to get the focus back on this SIP, which is incorporating another map library instead of Mapbox GL JS (which in turn accesses a freely accessible base map server).
Specifically it's about replacing "deckl.gl Scatterplot".
I would not take WMS as service protocol but stick to the raster tiles (XYZ) scheme, like Mapbox base maps - now based on free tile servers, like http://openwhatevermap.xyz shows.
And to clarify this: You only need to exchange the Mapbox GL JS map library with Leaflet. You don't necessarily need to host the map tiles yourself.
mistercrunch commented:

We recently made the resolution to use ECharts as our primary visualization library #10418
Do the maps in ECharts depend on mapbox?

There are about four map types at https://echarts.apache.org/en/download-extension.html , among them Mapbox - and echarts-leaflet.
echarts-leaflet is the one we want: https://github.com/gnijuohz/echarts-leaflet
Instead of a map token this would need a urlTemplate like  'https://{s}.tile.openstreetmap.fr/hot/{z}/{x}/{y}.png'
So: What's left to be done in order agree on this and to implement this?

Due to a numbering snafu, there was another SIP that was numbered SIP-53. While this issue is older, and really had the right to that number, the other one has already been voted through, so it should not be renumbered. I'll move this one to the next available SIP number, which is SIP-63. Sorry for the extra layer of awkwardness.

Hi @villebro, How is the progress on this SIP? Is it approved? Is anyone working on this? Thank you! :)

Maplibre integration or DeckGL enhancement as a true opensource project should be considered.
Geographic preview and live maps are really useful on many dashboard made with superset.

This sip has not been put up for a [VOTE] thread on the dev@ mailing list yet. Is there any intent to carry that forward? I'm not sure the SIP is actually needed, since this is effectively about building additional plugins. We can close this out if the author and others agree.

Can this be kept alive until a solution is found ? Can the it be put to a vote ? Or is there a place to link-it for additional plugins request ?

Well, I have a few thoughts on the matter, personally, but curious to hear the opinions of others (including @gk1089)

Is the intent here to add additional mapping plugins? If so, I don't think a SIP is required.
Is the intent here to replace Mapbox? This is more contentious, and would need a SIP.
If the idea is to add additional plugins, but the author doesn't have the intent to contribute them directly, this should probably be filed under an "Ideas" thread in the repo's Discussions.
If the idea is that someone's taking this project under their wing, we greatly look forward to a PR, and would be happy to help with any tactical questions along the way either on the PR itself or in the #contributing channel of the Slack workspace.

Wondering if anyone (dis)agrees with the above, and we can decide what to do with the SIP status accordingly.

I agree with @rusackas on the bullet list. The way I see it, I also agree it'd be great to add support for additional map sources. IMO we should have a MAP_SOURCES or similar config into which one could add entries for map sources that geospatial charts could use. Something like
class MapSource(str, Enum):
    MAPBOX = "mapbox"
    LEAFLET = "leaflet"
    OPEN_LAYERS = "open_layers"
    ....

MAP_SOURCES: Dict[MapSource, Dict[str, Any]] = {
    MapSource.MAPBOX: {
        <mapbox params go here...>
    },
    MapSource.LEAFLET: {
        <leaflet params go here...>
    }
}

This info would then be passed along to the frontend in bootstrap data, and viz plugins would then have a dropdown where the end user could choose which of the enabled map sources they want to use for a specific geospatial chart. And if the config is empty, geospatial viz' would be completely disabled.

I am happy that this is still being considered. The following has been my reasoning behind initiating this issue and I think it still stands:

The mapbox chart extension, while very easy to use, is not in the true spirit of open source. It needs registration and requires a key. It does not support overlaying other layers that a user might find more relevant to their use case.
Overlaying WMS services as layers of choice can be a powerful way of customized representation. This is supported by many popular BI tools and should be a part of default charts and not left for the users to develop from scratch.
There are pretty straightforward and widely used JS libraries that make embedding a map possible, like Leaflet and OpenLayers.
With my limited exposure to development for Superset, I think creating a chart for maps is more involved than other kinds of charts. Even the superset suggested charting library ECharts does not have support for WMS layers so there is even less building blocks to work upon.

I stand behind the suggestions of @rusackas and @villebro though to begin with even the option to add a WMS layer would be a great start since these can be easily published with customizations using widely available open source tools.
I have found Superset very useful and am willing to take up the challenge with some students that come work with me periodically. But the main challenges I face are a very restrictive internet environment that prohibits the use of many live discussions platforms. And even more than that, the lack of authoritative and updated information regarding starting from ground up and reaching the latest development build. If someone can give a focused push in getting us running, I am sure we can come up with something useful in the coming six months.
Cheers!

@gk1089 I think if we're not replacing the mapbox plugin, but either adding new ones, or (better yet) making the current one more extensible as @villebro suggests, we can probably close this as an issue and cancel the SIP, and instead convert this to an "Ideas" discussion. Let me know if you have any objection.
Also, I'm happy (as is Ville, I'm sure) to find a way to collab with you and your students on this - are you able to join the Slack community or a Zoom call, when the time is right? If not, please feel free to email me and we'll sort something out.

Hi @rusackas and @gk1089 just checking in. Any news regarding this option ?

Hi @rusackas and @gk1089 just checking in. Any news regarding this feature ?

I am working with my students and getting them up to speed is taking time. I hope to have some positive outcome in the next 3 months. I will definitely reach out to @rusackas & @villebro when I get stuck eventually.

Many thanks for your work @gk1089 perhaps should consider maplibre instead using mapbox ? no key required, same powerfull features, maplibre is growing fast.

I've seen that Apache has took over Echarts, that contain lots of geo visualisation. I can't find if they are using Mapbox or another paying provider it look like it's fully community based ? So it's also an option ?

@Stephane-Thales I suggest you check out this discussion: #21758

@Stephane-Thales I suggest you check out this discussion: #21758

Thanks, interesting and there are perhaps some overlaps, but that's not exactly what we are discussing here.

Hi there,
Any news @gk1089 ? It would be awesome to be able to put maplibre links or have the opportunity to change the map tiles provider ;)
Thanks,

It seems there is a plugin with openlayers but don't know how to install it :persevere:
https://www.npmjs.com/package/superset-ol-plugin

It seems there is a plugin with openlayers but don't know how to install it 😣 https://www.npmjs.com/package/superset-ol-plugin

Hi @Doctor-Who it's not part of the core superset so indeed it looks difficult to setup. You need to recompile superset if I understood correctly. Also, there is no descriptions of the features.

It seems there is a plugin with openlayers but don't know how to install it persevere
https://www.npmjs.com/package/superset-ol-plugin

I am currently working on moving the openlayers plugin to the core. I just have to fix some build issues, but I am sure that I will be able to open a first PR soon.

It seems there is a plugin with openlayers but don't know how to install it persevere
https://www.npmjs.com/package/superset-ol-plugin

I am currently working on moving the openlayers plugin to the core. I just have to fix some build issues, but I am sure that I will be able to open a first PR soon.

That's a really good news! Thanks for your dedication!

It seems there is a plugin with openlayers but don't know how to install it persevere
https://www.npmjs.com/package/superset-ol-plugin

I am currently working on moving the openlayers plugin to the core. I just have to fix some build issues, but I am sure that I will be able to open a first PR soon.

Thanks ! keep us posted here.

Many thanks for you hard work !

@jansule, Can you please update on the build issues regarding superset-ol-plugin. Have they been fixed?
I have followed these steps so far:
cd /opt/superset/superset-frontend
nvm use 16.19.1
npm i superset-ol-plugin
_npm ERR! code ERESOLVE
npm ERR! ERESOLVE unable to resolve dependency tree
npm ERR!
npm ERR! While resolving<EMAIL_ADDRESS>npm ERR! Found<EMAIL_ADDRESS>npm ERR! node_modules/@ant-design/icons
npm ERR<EMAIL_ADDRESS>from the root project
npm ERR!   peer<EMAIL_ADDRESS>from<EMAIL_ADDRESS>npm ERR!   packages/superset-ui-chart-controls
npm ERR<EMAIL_ADDRESS>npm ERR!     node_modules/@superset-ui/chart-controls
npm ERR<EMAIL_ADDRESS>from<EMAIL_ADDRESS>npm ERR!       packages/superset-ui-demo/node_modules/@superset-ui/legacy-plugin-chart-time-table
npm ERR!         peer @superset-ui/legacy-plugin-chart-time-table@"" from<EMAIL_ADDRESS>npm ERR!         packages/superset-ui-demo
npm ERR!       26 more (@superset-ui/legacy-plugin-chart-time-table, ...)
npm ERR!   1 more (@superset-ui/plugin-chart-pivot-table)
npm ERR!
npm ERR! Could not resolve dependency:
npm ERR! peer<EMAIL_ADDRESS>from<EMAIL_ADDRESS>npm ERR! node_modules/superset-ol-plugin
npm ERR!   superset-ol-plugin@"" from the root project
npm ERR!
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force, or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution.
npm ERR!
npm ERR! See /home/asupset/.npm/eresolve-report.txt for a full report.
npm ERR! A complete log of this run can be found in:
npm ERR!     /home/asupset/.npm/logs/2023-09-21T13_57_33_253Z-debug-0.log_
Please note that I also tried with npm i superset-ol-plugin -- force and npm i superset-ol-plugin --legacy-peer-deps and was able to proceed to next step i.e. npm cli and again had to do npm cli -- force but after that npi run build keeps giving errors.
Looking forward to your reply.

This SIP has not been brought up for a vote, and the thread is a bit all over the map - I'm not quite sure the scope of the standing proposal that we'd be voting on. Does anyone feel like recapitulating the thread/proposal and calling a vote, or should we abandon this and start a new proposal when people have availability to pursue the renewed effort?

This SIP has not been brought up for a vote, and the thread is a bit all over the map - I'm not quite sure the scope of the standing proposal that we'd be voting on. Does anyone feel like recapitulating the thread/proposal and calling a vote, or should we abandon this and start a new proposal when people have availability to pursue the renewed effort?

Hi @rusackas , for me the initial description of the issue is still relevant, i don't think the thread changed the scope. Can we reuse it ?

A first PR for supporting cartodiagrams and external map sources (WMS, WFS, XYZ) was created: https://github.com/apache/superset/pull/25869

Looking forward to merging that cartodiagram! In the meantime, this SIP itself has gone dormant in terms of official consensus activity (proposed for Discussion in 2021 with no replies since). The original author doesn't seem to be here to put it to a vote. According to a recently voted process, we'll close this out as stale. If someone wishes to rekindle this effort, I think we should take the most important bits into a fresh SIP and start the process anew.

This link suggests a way to replace mapbox basemaps with that of OSM. But I'm unable to find that code snipper in the superset_config.py file.
https://www.restack.io/docs/superset-knowledge-superset-map-visualization-guide