GitHub Commit error after June VS Code update

Issue Type: Bug
After updating VS Code with the June update, I get an Error (Bad status code: 500) when I try to commit my code udpates to GitHub.
This is the command output:

git -c user.useConfigOnly=true commit --quiet
Error: Bad status code: 500
at ClientRequest. (c:\Users\scott\AppData\Local\Programs\Microsoft VS Code\resources\app\extensions\git\dist\git-editor-main.js:1:470)
at Object.onceWrapper (node:events:510:26)
at ClientRequest.emit (node:events:390:28)
at HTTPParser.parserOnIncomingClient (node:_http_client:623:27)
at HTTPParser.parserOnHeadersComplete (node:_http_common:128:17)
at Socket.socketOnData (node:_http_client:487:22)
at Socket.emit (node:events:390:28)
at addChunk (node:internal/streams/readable:315:12)
at readableAddChunk (node:internal/streams/readable:289:9)
at Socket.Readable.push (node:internal/streams/readable:228:10)
error: There was a problem with the editor '"c:\Users\scott\AppData\Local\Programs\Microsoft VS Code\resources\app\extensions\git\dist\git-editor.sh"'.
Please supply the message using either -m or -F option.

This is the Git Log:
[2022-07-08T04:36:17.835Z] > git -c user.useConfigOnly=true commit --quiet [363ms]
[2022-07-08T04:36:17.835Z] Error: Bad status code: 500
at ClientRequest. (c:\Users\scott\AppData\Local\Programs\Microsoft VS Code\resources\app\extensions\git\dist\git-editor-main.js:1:470)
at Object.onceWrapper (node:events:510:26)
at ClientRequest.emit (node:events:390:28)
at HTTPParser.parserOnIncomingClient (node:_http_client:623:27)
at HTTPParser.parserOnHeadersComplete (node:_http_common:128:17)
at Socket.socketOnData (node:_http_client:487:22)
at Socket.emit (node:events:390:28)
at addChunk (node:internal/streams/readable:315:12)
at readableAddChunk (node:internal/streams/readable:289:9)
at Socket.Readable.push (node:internal/streams/readable:228:10)
error: There was a problem with the editor '"c:\Users\scott\AppData\Local\Programs\Microsoft VS Code\resources\app\extensions\git\dist\git-editor.sh"'.
Please supply the message using either -m or -F option.
[2022-07-08T04:36:17.891Z] > git config --get-all user.name [52ms]
[2022-07-08T04:36:17.948Z] > git config --get-all user.email [54ms]
VS Code version: Code 1.69.0 (92d25e35d9bf1a6b16f7d0758f25d48ace11e5b9, 2022-07-07T05:28:36.503Z)
OS version: Windows_NT x64 10.0.19043
Restricted Mode: No

System Info

Item
Value

CPUs
Intel(R) Core(TM) i7-6700HQ CPU @ 2.60GHz (8 x 2592)

GPU Status
2d_canvas: enabledcanvas_oop_rasterization: disabled_offdirect_rendering_display_compositor: disabled_off_okgpu_compositing: enabledmultiple_raster_threads: enabled_onopengl: enabled_onrasterization: enabledraw_draw: disabled_off_okskia_renderer: enabled_onvideo_decode: enabledvideo_encode: enabledvulkan: disabled_offwebgl: enabledwebgl2: enabled

Load (avg)
undefined

Memory (System)
15.86GB (7.56GB free)

Process Argv
--crash-reporter-id b6d5ae76-63a0-48eb-aa8e-87fb9f164435

Screen Reader
no

VM
0%

Extensions (6)

Extension
Author (truncated)
Version

githistory
don
0.6.19

python
ms-
2022.10.0

vscode-pylance
ms-
2022.7.20

jupyter
ms-
2022.6.1001902341

jupyter-keymap
ms-
1.0.0

jupyter-renderers
ms-
1.0.8

A/B Experiments
vsliv368cf:30146710
vsreu685:30147344
python383:30185418
vspor879:30202332
vspor708:30202333
vspor363:30204092
vstes627:30244334
vslsvsres303:30308271
pythonvspyl392:30443607
vserr242:30382549
pythontb:30283811
vsjup518:30340749
pythonvspyt551:30345470
pythonptprofiler:30281270
vshan820:30294714
vstes263:30335439
vscoreces:30445986
pythondataviewer:30285071
vscod805:30301674
binariesv615:30325510
bridge0708:30335490
bridge0723:30353136
vsaa593:30376534
vsc1dst:30438360
pythonvs932:30410667
wslgetstarted:30449410
vscscmwlcmt:30465135
cppdebug:30492333
vsclangdc:30486549

Issue Type: Bug
After updating VS Code with the June update, I get an Error (Bad status code: 500) when I try to commit my code udpates to GitHub.
This is the command output:

git -c user.useConfigOnly=true commit --quiet
Error: Bad status code: 500
at ClientRequest. (c:\Users\scott\AppData\Local\Programs\Microsoft VS Code\resources\app\extensions\git\dist\git-editor-main.js:1:470)
at Object.onceWrapper (node:events:510:26)
at ClientRequest.emit (node:events:390:28)
at HTTPParser.parserOnIncomingClient (node:_http_client:623:27)
at HTTPParser.parserOnHeadersComplete (node:_http_common:128:17)
at Socket.socketOnData (node:_http_client:487:22)
at Socket.emit (node:events:390:28)
at addChunk (node:internal/streams/readable:315:12)
at readableAddChunk (node:internal/streams/readable:289:9)
at Socket.Readable.push (node:internal/streams/readable:228:10)
error: There was a problem with the editor '"c:\Users\scott\AppData\Local\Programs\Microsoft VS Code\resources\app\extensions\git\dist\git-editor.sh"'.
Please supply the message using either -m or -F option.

This is the Git Log:
[2022-07-08T04:36:17.835Z] > git -c user.useConfigOnly=true commit --quiet [363ms] [2022-07-08T04:36:17.835Z] Error: Bad status code: 500 at ClientRequest. (c:\Users\scott\AppData\Local\Programs\Microsoft VS Code\resources\app\extensions\git\dist\git-editor-main.js:1:470) at Object.onceWrapper (node:events:510:26) at ClientRequest.emit (node:events:390:28) at HTTPParser.parserOnIncomingClient (node:_http_client:623:27) at HTTPParser.parserOnHeadersComplete (node:_http_common:128:17) at Socket.socketOnData (node:_http_client:487:22) at Socket.emit (node:events:390:28) at addChunk (node:internal/streams/readable:315:12) at readableAddChunk (node:internal/streams/readable:289:9) at Socket.Readable.push (node:internal/streams/readable:228:10) error: There was a problem with the editor '"c:\Users\scott\AppData\Local\Programs\Microsoft VS Code\resources\app\extensions\git\dist\git-editor.sh"'. Please supply the message using either -m or -F option. [2022-07-08T04:36:17.891Z] > git config --get-all user.name [52ms] [2022-07-08T04:36:17.948Z] > git config --get-all user.email [54ms]
VS Code version: Code 1.69.0 (92d25e3, 2022-07-07T05:28:36.503Z) OS version: Windows_NT x64 10.0.19043 Restricted Mode: No
System Info
Extensions (6)
A/B Experiments

I have the same issue.  I guess the issue is that when you just do "F1 - > commit" it doesn't give you the option to supply a message and therefor you get the error " Please supply the message using either -m or -F option."

Issue Type: Bug
After updating VS Code with the June update, I get an Error (Bad status code: 500) when I try to commit my code udpates to GitHub.
This is the command output:

git -c user.useConfigOnly=true commit --quiet
Error: Bad status code: 500
at ClientRequest. (c:\Users\scott\AppData\Local\Programs\Microsoft VS Code\resources\app\extensions\git\dist\git-editor-main.js:1:470)
at Object.onceWrapper (node:events:510:26)
at ClientRequest.emit (node:events:390:28)
at HTTPParser.parserOnIncomingClient (node:_http_client:623:27)
at HTTPParser.parserOnHeadersComplete (node:_http_common:128:17)
at Socket.socketOnData (node:_http_client:487:22)
at Socket.emit (node:events:390:28)
at addChunk (node:internal/streams/readable:315:12)
at readableAddChunk (node:internal/streams/readable:289:9)
at Socket.Readable.push (node:internal/streams/readable:228:10)
error: There was a problem with the editor '"c:\Users\scott\AppData\Local\Programs\Microsoft VS Code\resources\app\extensions\git\dist\git-editor.sh"'.
Please supply the message using either -m or -F option.

This is the Git Log:
[2022-07-08T04:36:17.835Z] > git -c user.useConfigOnly=true commit --quiet [363ms] [2022-07-08T04:36:17.835Z] Error: Bad status code: 500 at ClientRequest. (c:\Users\scott\AppData\Local\Programs\Microsoft VS Code\resources\app\extensions\git\dist\git-editor-main.js:1:470) at Object.onceWrapper (node:events:510:26) at ClientRequest.emit (node:events:390:28) at HTTPParser.parserOnIncomingClient (node:_http_client:623:27) at HTTPParser.parserOnHeadersComplete (node:_http_common:128:17) at Socket.socketOnData (node:_http_client:487:22) at Socket.emit (node:events:390:28) at addChunk (node:internal/streams/readable:315:12) at readableAddChunk (node:internal/streams/readable:289:9) at Socket.Readable.push (node:internal/streams/readable:228:10) error: There was a problem with the editor '"c:\Users\scott\AppData\Local\Programs\Microsoft VS Code\resources\app\extensions\git\dist\git-editor.sh"'. Please supply the message using either -m or -F option. [2022-07-08T04:36:17.891Z] > git config --get-all user.name [52ms] [2022-07-08T04:36:17.948Z] > git config --get-all user.email [54ms]
VS Code version: Code 1.69.0 (92d25e3, 2022-07-07T05:28:36.503Z) OS version: Windows_NT x64 10.0.19043 Restricted Mode: No
System Info
Extensions (6)
A/B Experiments

After reading the documentation I now understand the behavior :)
https://code.visualstudio.com/updates/v1_69#_author-commit-message-using-an-editor
so just untick this if you want the old experience

I have been trying to reproduce this issue in-house without much luck. Would you be able to create a gif recording (https://gifcap.dev) while reproducing the issue? Thank you very much in advance!

ah thank you so much I have been trying to figure out how to fix this 500 error code for 2 days! Go figure all you have to do is untick a box....

@CryptoCherie, apologies for the caused inconvenience. While toggling the setting to disable the new flow is a valid workaround, I do want to get to the bottom of the root cause and fix it. Are you able to reproruce the 500 error in all repositories or only some? If only in some, is there anything specific about those repositories? Could you please share a recording (https://gifcap.dev) when you reproduce the issue? Thank you!

I get this pressing the new commit button with no text in the textbox using a remote environment where the other side has git version 2.7.4.
It hangs indefinitely, and to recover I need to reload the window.
Ideally, if there I'd no text I'd get a pop-up warning like if I try to commit with no staged changes.

@MarkAHamann, thanks for the additional details.
Which extension are you using to connect to the remote environment? Remote-Containers? Remote-SSH? Remote-WSL?

Remote-ssh. Windows 10 at my desk connected to Linux beast somewhere in the building.

Also, it seems to be opening .git/COMMIT_EDITMSG into my open editors. Empty, of course, because I didn't have a commit message in the text box.

@MarkAHamann, if you do not specify a commit message in the input than VS Code will open the COMMIT_EDITMSG file in an editor tab. you can use that to enter the commit message and close the editor to complete the commit operation. Closing the editor when it's contents are empty will cancel the commit operation. Is that the behaviour that you are seeing?

Hmm... I hadn't really noticed that new file opening up until later. I just did a commit, got the open file, added a message, hit ctrl-s to save, and now it's still hung indefinitely.
Wait, I just hit the little x to close the editor and it completed.
OK, I see what's going on now. Working as expected (though with new expectations). Pebcak.

[makz159] Thanks a lot my friend @makz159, I could solved this bug c.

@lszomoru See attachment for my gif recording while I reproduce the error. I've got a fairly streamlined setup. I don't have many VS Code extensions beyond Python, Jupyter and Git History. I haven't done any further attempts to rectify the problem since I filed the report last night; however, I now realize the problem seems to stem from my neglect to include a comment with my Commit. It would be nice if VS Code could fail more gracefully though. Thanks for your support.

@lszomoru I confirmed the Commit proceeds successfully if I simply enter a message in the empty Message field directly above the Commit button before I hit the Commit button.
Do you want me to close this ticket or leave it open to track graceful resolution of the error reporting?

Issue Type: Bug
After updating VS Code with the June update, I get an Error (Bad status code: 500) when I try to commit my code udpates to GitHub.
This is the command output:

git -c user.useConfigOnly=true commit --quiet
Error: Bad status code: 500
at ClientRequest. (c:\Users\scott\AppData\Local\Programs\Microsoft VS Code\resources\app\extensions\git\dist\git-editor-main.js:1:470)
at Object.onceWrapper (node:events:510:26)
at ClientRequest.emit (node:events:390:28)
at HTTPParser.parserOnIncomingClient (node:_http_client:623:27)
at HTTPParser.parserOnHeadersComplete (node:_http_common:128:17)
at Socket.socketOnData (node:_http_client:487:22)
at Socket.emit (node:events:390:28)
at addChunk (node:internal/streams/readable:315:12)
at readableAddChunk (node:internal/streams/readable:289:9)
at Socket.Readable.push (node:internal/streams/readable:228:10)
error: There was a problem with the editor '"c:\Users\scott\AppData\Local\Programs\Microsoft VS Code\resources\app\extensions\git\dist\git-editor.sh"'.
Please supply the message using either -m or -F option.

This is the Git Log:
[2022-07-08T04:36:17.835Z] > git -c user.useConfigOnly=true commit --quiet [363ms] [2022-07-08T04:36:17.835Z] Error: Bad status code: 500 at ClientRequest. (c:\Users\scott\AppData\Local\Programs\Microsoft VS Code\resources\app\extensions\git\dist\git-editor-main.js:1:470) at Object.onceWrapper (node:events:510:26) at ClientRequest.emit (node:events:390:28) at HTTPParser.parserOnIncomingClient (node:_http_client:623:27) at HTTPParser.parserOnHeadersComplete (node:_http_common:128:17) at Socket.socketOnData (node:_http_client:487:22) at Socket.emit (node:events:390:28) at addChunk (node:internal/streams/readable:315:12) at readableAddChunk (node:internal/streams/readable:289:9) at Socket.Readable.push (node:internal/streams/readable:228:10) error: There was a problem with the editor '"c:\Users\scott\AppData\Local\Programs\Microsoft VS Code\resources\app\extensions\git\dist\git-editor.sh"'. Please supply the message using either -m or -F option. [2022-07-08T04:36:17.891Z] > git config --get-all user.name [52ms] [2022-07-08T04:36:17.948Z] > git config --get-all user.email [54ms]
VS Code version: Code 1.69.0 (92d25e3, 2022-07-07T05:28:36.503Z) OS version: Windows_NT x64 10.0.19043 Restricted Mode: No
System Info
Extensions (6)
A/B Experiments

Provide a message or text while committing Files

@Schlermie, thank you very much for the recording. We should keep the issue opened as this is clearly a problem that I have to address. One should be able to go through the commit flow even if a commit message is not provided as illustrated in the release notes.

@Schlermie, could you please reproduce the problem again, and then invoke the Developer: Toggle Developer Tools command and share the contents of the console? I have tracked down that code that fails but I need to understand the exact error that occurs as currenrly we only log the status code. Thank you!

I have further looked at the code and my current hypothesis is that we are failing to open the COMMIT_EDITMSG file. At the moment we are assuming that the last argument passed to git-editor-main.ts is the path of this file but I think that assumption might be wrong. I am looking at testing out the fix first in Insiders before we port it to Stable so that it is included in the upcoming recovery release.

Could https://github.com/microsoft/vscode/issues/154503 be related to this one?

@Schlermie, could you please reproduce the problem again, and then invoke the Developer: Toggle Developer Tools command and share the contents of the console? I have tracked down that code that fails but I need to understand the exact error that occurs as currently we only log the status code. Thank you!

@lszomoru See attachment for my error reproduction, followed by invoking the Developer Tools.

@Schlermie, could you please check the version of git that you are using by running git --version? thanks!

'git --version' returns this:
git version 2.28.0.windows.1

Issue Type: Bug
After updating VS Code with the June update, I get an Error (Bad status code: 500) when I try to commit my code udpates to GitHub.
This is the command output:

git -c user.useConfigOnly=true commit --quiet
Error: Bad status code: 500
at ClientRequest. (c:\Users\scott\AppData\Local\Programs\Microsoft VS Code\resources\app\extensions\git\dist\git-editor-main.js:1:470)
at Object.onceWrapper (node:events:510:26)
at ClientRequest.emit (node:events:390:28)
at HTTPParser.parserOnIncomingClient (node:_http_client:623:27)
at HTTPParser.parserOnHeadersComplete (node:_http_common:128:17)
at Socket.socketOnData (node:_http_client:487:22)
at Socket.emit (node:events:390:28)
at addChunk (node:internal/streams/readable:315:12)
at readableAddChunk (node:internal/streams/readable:289:9)
at Socket.Readable.push (node:internal/streams/readable:228:10)
error: There was a problem with the editor '"c:\Users\scott\AppData\Local\Programs\Microsoft VS Code\resources\app\extensions\git\dist\git-editor.sh"'.
Please supply the message using either -m or -F option.

This is the Git Log:
[2022-07-08T04:36:17.835Z] > git -c user.useConfigOnly=true commit --quiet [363ms] [2022-07-08T04:36:17.835Z] Error: Bad status code: 500 at ClientRequest. (c:\Users\scott\AppData\Local\Programs\Microsoft VS Code\resources\app\extensions\git\dist\git-editor-main.js:1:470) at Object.onceWrapper (node:events:510:26) at ClientRequest.emit (node:events:390:28) at HTTPParser.parserOnIncomingClient (node:_http_client:623:27) at HTTPParser.parserOnHeadersComplete (node:_http_common:128:17) at Socket.socketOnData (node:_http_client:487:22) at Socket.emit (node:events:390:28) at addChunk (node:internal/streams/readable:315:12) at readableAddChunk (node:internal/streams/readable:289:9) at Socket.Readable.push (node:internal/streams/readable:228:10) error: There was a problem with the editor '"c:\Users\scott\AppData\Local\Programs\Microsoft VS Code\resources\app\extensions\git\dist\git-editor.sh"'. Please supply the message using either -m or -F option. [2022-07-08T04:36:17.891Z] > git config --get-all user.name [52ms] [2022-07-08T04:36:17.948Z] > git config --get-all user.email [54ms]
VS Code version: Code 1.69.0 (92d25e3, 2022-07-07T05:28:36.503Z) OS version: Windows_NT x64 10.0.19043 Restricted Mode: No
System Info
Extensions (6)
A/B Experiments

Thanks a million, this recent change they made was driving me crazy for the past 2 days. I use custom hot keys to commit and push my code, so I expect the text box to appear and ask for a message. This post just saved my sanity.

Issue Type: Bug
After updating VS Code with the June update, I get an Error (Bad status code: 500) when I try to commit my code udpates to GitHub.
This is the command output:

git -c user.useConfigOnly=true commit --quiet
Error: Bad status code: 500
at ClientRequest. (c:\Users\scott\AppData\Local\Programs\Microsoft VS Code\resources\app\extensions\git\dist\git-editor-main.js:1:470)
at Object.onceWrapper (node:events:510:26)
at ClientRequest.emit (node:events:390:28)
at HTTPParser.parserOnIncomingClient (node:_http_client:623:27)
at HTTPParser.parserOnHeadersComplete (node:_http_common:128:17)
at Socket.socketOnData (node:_http_client:487:22)
at Socket.emit (node:events:390:28)
at addChunk (node:internal/streams/readable:315:12)
at readableAddChunk (node:internal/streams/readable:289:9)
at Socket.Readable.push (node:internal/streams/readable:228:10)
error: There was a problem with the editor '"c:\Users\scott\AppData\Local\Programs\Microsoft VS Code\resources\app\extensions\git\dist\git-editor.sh"'.
Please supply the message using either -m or -F option.

This is the Git Log:
[2022-07-08T04:36:17.835Z] > git -c user.useConfigOnly=true commit --quiet [363ms] [2022-07-08T04:36:17.835Z] Error: Bad status code: 500 at ClientRequest. (c:\Users\scott\AppData\Local\Programs\Microsoft VS Code\resources\app\extensions\git\dist\git-editor-main.js:1:470) at Object.onceWrapper (node:events:510:26) at ClientRequest.emit (node:events:390:28) at HTTPParser.parserOnIncomingClient (node:_http_client:623:27) at HTTPParser.parserOnHeadersComplete (node:_http_common:128:17) at Socket.socketOnData (node:_http_client:487:22) at Socket.emit (node:events:390:28) at addChunk (node:internal/streams/readable:315:12) at readableAddChunk (node:internal/streams/readable:289:9) at Socket.Readable.push (node:internal/streams/readable:228:10) error: There was a problem with the editor '"c:\Users\scott\AppData\Local\Programs\Microsoft VS Code\resources\app\extensions\git\dist\git-editor.sh"'. Please supply the message using either -m or -F option. [2022-07-08T04:36:17.891Z] > git config --get-all user.name [52ms] [2022-07-08T04:36:17.948Z] > git config --get-all user.email [54ms]
VS Code version: Code 1.69.0 (92d25e3, 2022-07-07T05:28:36.503Z) OS version: Windows_NT x64 10.0.19043 Restricted Mode: No
System Info
Extensions (6)
A/B Experiments

After reading the documentation I now understand the behavior :) https://code.visualstudio.com/updates/v1_69#_author-commit-message-using-an-editor
so just untick this if you want the old experience

Thanks a million, this recent change they made was driving me crazy for the past 2 days. I use custom hot keys to commit and push my code, so I expect the text box to appear and ask for a message. This post just saved my sanity.

@lszomoru closing this for verification since the associated PR was merged.

@rubensa, are you able to reproduce the problem with the latest Insiders release?

@rubensa, are you able to reproduce the problem with the latest Insiders release?

@lszomoru I'll try to check.

Thanks @makz159 , its resolved at my end


gettext translation within component inline templates is not working

It seems that Django's makemessages does not recognize/find a simple translated string within a component's inline template:

@default.register
class Foo(Component):
    template: django_html = """{% load i18n %}<div>{% translate "foo" %}</div>"""

When using template_name and a file, it is handled correctly, as expected.
I don't know exactly where this must be handled. InlineTemplate?
@samwillis - any ideas?

The only solution ATM is to use template_name instead of template and use a .html file which Django can parse during manage.py makemessages.
Overriding / patching Django's behaviour here seems to be a bit overwhelming. Evtl. tetra could add a translate "proxy" templatetag that writes the string into a separate .py file using gettext_noop, so that at least the strings get extracted from there during the next makemessages run.
But that makes me shiver a bit if I think about it...

@samwillis So you have any idea how to get into this? Just need a hint here. gettext and Django makemessages do not support "plugins" or flexible parsing.

Hey @nerdoc
it looks like Django explicitly doesn't use the "django" domain for .py files, which is understandable as it expecting normal gettext behaviour in a .py:
https://github.com/django/django/blob/1a36dce9c5e0627d46582829d7abd47ed872e3aa/django/core/management/commands/makemessages.py#L87
I would look at overriding the makemessages command like tetra does for startserver with an option to extract messages from templates in .py files. https://docs.djangoproject.com/en/5.0/topics/i18n/translation/#customizing-the-makemessages-command

That's a good catch. I'll look into that, thanks!

Tetra could overwrite the is_templatized method and "parse" the file (I asked ChatGPT to generate some code here):
    def is_templatized(self):
        if self.domain == "djangojs":
            return self.command.gettext_version < (0, 18, 3)
        elif self.domain == "django":
            file_ext = os.path.splitext(self.translatable.file)[1]
            if file_ext == ".py":
                with open(self.translatable.file, "r") as file:
                    content = file.read()
                    try:
                        tree = ast.parse(content)
                        for node in ast.walk(tree):
                            if isinstance(node, ast.Call) and isinstance(node.func, ast.Name) and node.func.id == "Component":
                                return True
                    except SyntaxError:
                        return False
            return file_ext != ".py"
        return False

This would be horribly inefficient and slow when firing makemessages, but could be a starting point.

this is a good plan.
You can probably infer if there might be a component by checking if the files text includes the correct import statements, and only parse it if so. That would make it significantly more efficient.

There may be multiple ways of importing Tetra components.
from tetra.components import Component  # -> class Foo(Component)
from tetra import components  # -> class Foo(components.Component)
from tetra.components import component as Baz  # -> class Foo(Baz)
from my_app import FooComponentBase  # -> class Foo(FooComponentBase)

Which are all correct imports, but makes parsing more complicated...
I'll check how this impacts performance. makemessages is not a performance problem when run from time to time...

class BuildFile(MakeMessagesBuildFile):
    def is_templatized(self):
        if self.domain == "django":
            file_ext = os.path.splitext(self.translatable.file)[1]
            if file_ext == ".py":
                with open(self.translatable.file, "r") as file:
                    content = file.read()
                    if "from tetra.components import Component" in content:
                        try:
                            tree = ast.parse(content)
                            for node in ast.walk(tree):
                                if isinstance(node, ast.ClassDef):
                                    has_component_base = False
                                    has_template_attr = False
                                    for base in node.bases:
                                        if (
                                            isinstance(base, ast.Attribute)
                                            and base.attr == "Component"
                                            and isinstance(base.value, ast.Name)
                                            and base.value.id == "tetra.components"
                                        ):
                                            has_component_base = True
                                    for stmt in node.body:
                                        if isinstance(stmt, ast.Assign):
                                            for target in stmt.targets:
                                                if (
                                                    isinstance(target, ast.Name)
                                                    and target.id == "template"
                                                ):
                                                    has_template_attr = True
                                    if has_component_base and has_template_attr:
                                        return True

                        except SyntaxError:
                            return False
                return file_ext != ".py"
            return super().is_templatized()

smashed together by ChatGPT. Leave it here as lift-off point, have no time this evening for real coding :-(

This is a major issue and not easy to solve. makemessages has a multi-staged process of parsing files and preparing them for gettext. I subclassed BuildFile and tried to change the way it preprocess the files. But this does not really work, as in fact Django uses django.utils.translation.templatize(src, origin=None) to prepare files for gettext. What would need to be done is hook into that process before the file is preprocessed, see if there is a Tetra component, and "extract" the template string from the component, writing a separate tmp file with it's content. This tmp file then must be added to the files_list and hence fed to the gettext program. The line numbers must be matched to the original document.
So subclassing the BuildFile is too late in the process, as this only encapsulates ONE file.
This seems such a complicated task that it occurs to me that there must be something wrong.
My first mental approach would be: why this complicated? Why don't we support (or even recommend) building a component in a directory instead of a single file?
my_component/
  __init__.py     # or my_component.py
  my_component.js
  my_component.css
  my_component.html

Then all those problems would be solved, including caching, IDE/highlighting support etc. This is what other component frameworks do as well.
But @samwillis - I think you mad this one-file approach with a clear goal in mind. The problem here is that, without huge effort, translating is not possible in a component - which is VeryBad™.

Ah, it's always the same. Countless hours of coding, reading, thinking. Then, I decide to ask in a forum, open an issue, go for help. And a few minutes later a new idea comes up, and that path solves the issue.
I seem to have done it. It's (as always) easier than initially thought: The TetraBuildFile  class must check if  a .py file is "templatized". It does this by parsing the code and checking if this file contains a component. And when it is, it just returns True. Everything else is done by Django.
The only issue remaining is that the code line referenced in the .po file is the line the inline template starts. This could be done in another step. But at least, this is solved.
Fix as commit later today.


History of student scores

Currently, it does not seems to be possible to inspect the history of the students' scores.
Would be nice to have such feature in the web frontend, since due to some bugs in the tests, the score of the student may change with resubmissions, and TAs should be able to confirm if the student indeed had a higher score in the past.

Sounds reasonable. @0xf8f8ff can you comment on whether or not we already have the relevant data in database. If we do, this would be a matter of requesting it from the database and displaying it in the frontend.

Sounds reasonable. @0xf8f8ff can you comment on whether or not we already have the relevant data in database. If we do, this would be a matter of requesting it from the database and displaying it in the frontend.

At the moment we only record the last submission and its scores. We could of course record each submission as before, but, as we experienced, a student can make over a hundred pushes for a single assignment so it would just bloat a database for a feature that (if I understand correctly?) is only needed once in a while.
Alternatively, we could record the highest score achieved by the student for the given lab. A potential issue: an incorrect test that gives higher score than intended. To prevent this we could give teachers an option to reset higher scores for an assignment.

I've thought some more about this, and I think the better solution is to require the student to fix their code to regain the required score after a bug in the tests has been fixed... This is explained in #539. That is, I think we should instead implement #539. Let me know if you have thoughts. If you agree, we can close this.


Fedora generic aarch64 does not boot

Fedora fails to boot, I tried with both Workstation 34 and Rawhide, one on my eMMC and one on my microSD. (I forget which one is which).
Two screenshots:
It works (to an extent) when using Fedora's own uboot, package spec/source here: https://src.fedoraproject.org/fork/rdossant/rpms/uboot-tools/blob/rawhide/f/uboot-tools.spec
I know UEFI booting is incomplete, so I figure there's something either upstream or a patch in Fedora's repo that makes this work, but unfortunately I don't know enough about uboot to understand what's going on in either your nix build system or how Fedora's rpm spec works.
(Unrelated note, my own matrix server needs to be burned with fire and abandoned due to lack of maintenance; when I have a matrix home I'll be joining your matrix group).

Is it the UEFI installer iso, or once installed that it fails to boot?
Note that I haven't looked at the "pre-installed image" use case at all, only at using the USB iso image to do the "usual installation wizard".
Coincidentally someone yesterday on Matrix told me this:

Fedora actually doesn't load for me because of some weird EFI error. Running bootefi mmc 1:1 /efi/fedora/grubaa64.efi works fine though

For which I'm also unclear whether it means the USB iso, a "pre-installed" image, or once installed from that iso.
Finally also note that I'm really not a Fedora user. My experience with Fedora starts and ends at downloading an AArch64 iso to test on some of the Tow-Boot platforms.

I'm not using a .iso on USB, but rather a raw disk image flashed to SD/eMMC.
I did miss your notes, but as I'm dedicating my SPI to Tow-Boot the only thing I see in there that seems especially relevant is that shim doesn't work. I replaced BOOTAARCH64.efi with grub from the same image and got to a boot menu and then a Fedora boot splash that eventually stopped spinning. It looks like it froze, but we're getting further...

There was some more discussion on the Matrix. I don't remember what was the conclusion of that discussion though.

I got fedora booting. I used a Rawhide Workstation image, I replaced the BOOTAA64.efi shim with the grub efi binary, and I added blacklist=efifb efifb=off to the command line.
I went and did something else for a few minutes after, and the power light is glowing green and I'm at a Gnome desktop. (No NVMe or WiFi, so something isn't quite right still...)
So while I wouldn't suggest closing this till more works… I can safely say that with a little light caressing Fedora does boot!

@b- was this with the Pinebook Pro? I am looking into using Tow Boot with Fedora on the Pinephone Pro.

@Be-ing we've had a user recently who apparently succesfully used the UEFI iso from Fedora without changes to just install with Tow-Boot present on the SPI.
So I figure whatever issues are now fixed. Anyway, since last May, I know that many of the underlying issues are fixed.
I am closing this issue, but @Be-ing, don't hesitate to ask here or in the matrix room if you have questions. I simply assume it will work given the success from earlier this week.


Add IdentifyPrivateVariants and DeleteVariants pipelines.

Also delete some obsolete code.

comments updated, PTAL

LGTM, thanks!


Automated cherry pick of #10437: fix(region): scoped policy filter by project id

Cherry pick of #10437 on release/3.7.
#10437: fix(region): scoped policy filter by project id

Codecov Report

Merging #10438 (8ca6d17) into release/3.7 (0ff3997) will increase coverage by 9.96%.
The diff coverage is 0.00%.

@@               Coverage Diff                @@
##           release/3.7   #10438       +/-   ##
================================================
+ Coverage         5.98%   15.95%    +9.96%
================================================
  Files              848      124      -724
  Lines           131795    12895   -118900
================================================
- Hits              7887     2057     -5830
+ Misses          123206    10647   -112559
+ Partials           702      191      -511

Flag
Coverage Δ

aFlag
15.95% <0.00%> (+9.96%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

pkg/apis/input.go
0.00% <ø> (ø)

pkg/apis/list.go
0.00% <ø> (ø)

pkg/baremetal/tasks/stop.go
0.00% <0.00%> (ø)

pkg/cloudcommon/validators/validators.go
62.39% <0.00%> (-0.69%)
:arrow_down:

pkg/compute/guestdrivers/aws.go
2.88% <ø> (+0.62%)
:arrow_up:

pkg/compute/guestdrivers/base.go
0.00% <ø> (ø)

pkg/compute/guestdrivers/esxi.go
0.78% <ø> (+<0.01%)
:arrow_up:

pkg/compute/guestdrivers/kvm.go
1.62% <0.00%> (ø)

pkg/compute/guestdrivers/managedvirtual.go
0.00% <0.00%> (ø)

pkg/monitor/alerting/conditions/reducer.go
77.27% <0.00%> (-13.94%)
:arrow_down:

... and 658 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5d35798...8ca6d17. Read the comment docs.


Support 'import.meta'

Fixes #22861. This PR introduces support for import.meta, a meta-property described here.
Here are some details on the implementation.
The ImportMeta Interface
The type of import.meta is the global ImportMeta type which is defined in lib.es5.d.ts:
interface ImportMeta {
}

This interface is extremely limited. Adding well-known properties for Node or browsers requires interface merging and possibly a global augmentation depending on the context.
For example, one might want to say that __dirname is always available on import.meta:
// node.d.ts
interface ImportMeta {
    __dirname: string;
}

Any user of the above .d.ts file will be able to get completions for import.meta.__dirname which has the type string.
Alternatively, you might be in a bind and just need to say "yes, I know import.meta will have this property, and I only need to use it in one file":
// declaring a property ad-hoc/offhandedly
declare global  {
    interface ImportMeta {
        mySuperCoolProperty: string;
    }
}

import.meta.mySuperCoolProperty // Has type 'string', not 'any'.

An earlier version of this pull request defined ImportMeta as follows:
interface ImportMeta {
    [propertyName: string]: any;
}

However, this interface is extremely lax, and means that you can misspell any property.
Community feedback is appreciated here.
Targets
import.meta is only allowed when targeting ESNext modules and ECMAScript targets.
I think it might make sense to say "this only runs on ESNext modules, but can run on any target", but I'd rather be conservative for now.
Incremental Parsing
import.meta is only valid within a module. This implies one of two things:

It is an error to use import.meta if the current module does not contain a module indicator (i.e. the module has no imports/exports).
import.meta itself is a module indicator (which turns the current file into a module).

I went with choice (2), which implies that a module indicator can occur anywhere within the file. To avoid a full walk of the tree, I use a new NodeFlag called PossiblyContainsImportMeta. Much like NodeFlags.PossiblyContainsDynamicImport, this new flag is set exactly once, and is never unset when re-using an AST.
When the flag is set, we will do a full walk of the AST to find module indicators, but in the common case, we'll run into an import or export declaration.

2.9 would be our next feature release, which should be cut sometime near the end of May.

Please take a look at the checklist in https://github.com/Microsoft/TypeScript/wiki/Release-Activities#new-syntax-introduced.
we need to add colorization support as well.


Add validation for ORCID, surname, given_name, before sending request to EZID

Addressing some issues identified by @myucekul during the review of #2

Last name is must have in the xml. So when last name is not present then use first name as surname.

Looks good. Thanks for the update, Hardy. 👍
Thankfully I haven't seen an author with both last and first name null or empty.

Test case - create doi for preprint with author whose last name is empty string. "" or bunch of white spaces "  ". See if crossref is okay or not.

this PR has been merged and deployed... I don't believe we can get crossref feedback on the staging server, so we'd have to test this in prd...


Fix php compatibility and fix build

Fix expected output for travis
Fix php compatibility

Closing this as Builds are now all fixed.


Response.sendError(500) is not working correctly

Describe the bug
In all our SlingModels, WcmUsePojo we are catching exceptions from services and in catch setting response.sendError(500);
Expected: Only 500 page should load.
Actual: The network Tab shows 500 as status. loads the page but below the page the contents of that page load normally as though the exception never occurred.
I've tried doing response.flushBuffer() response.getWriter().close()
to prevent other models and components from writing content into the response but nothing works.
Environment

AEM Version: 6.5
Author Instance
Setting response.sendError(500) has no effect status is still 200.

Publish instance
Status is 500 when response.sendError(500) is set but page loads anyways below 500.html page
Expected behavior
500.html should load when response.sendError(500) is set and when Error Page Handler is enabled

I think this might be intended for ACS AEM Commons project?

just setting the statuscode to 500 does not stop the rendering process. If you want to stop the rendering process, you should either refrain from catching the exception, or re-throw the exception.
Anyway, this does not sound like an issue of asset-share commons, and it's also not an issue specific to ACS AEM Commons, but a more general question affecting all AEM/sling development.

I did perform response.sendError(500). This should have been enough but it's not. I used getStatus() to confirm if sendError(500) is actually doing the job or not.


Upgrade gatekeeper version

No CRDs are managed by a job in the chart. Upgrade should be seamless.


Enter to close rename process dialogue box

Describe the solution you'd like
When renaming a process, hitting enter should close the dialogue box
Todo:

[ ] Make the dialog a bit larger
[ ] Enter to close the dialog

Requirements for testing:

[ ] Pressing enter should close the dialog box
[ ] Pressing escape should close the dialog box
[ ] Pressing the 'x' should close the dialog box
[ ] Pressing outside the dialog should close the dialog box
[ ] User should be able to rename a process by typing in the input-field

quick-fix @SjoenH ?

Discussed if we want to simplify a bit. Removing the dialog box and edit text directly

Note, that we today can close the edit box by pressing escape, clicking the x or clicking outside the edit box.
Enter-key would be an intuitive, and quick thing to add.
Removing the dialog box and editing the text directly would take a bit more time, but still a small task.

Connected to #417 ?

@askbulle Yes, what's described in #417 would render this #361 unnecessary. So we would need to choose one over the other.

@SjoenH Could not both be possible, or is it bad practice to have same function two places? If not, I would prefer #417 I think. @Linedueo : What do you think?

Of course, we could have both, but I would advise against it.
I would also vote for #417.

I agree that #417 would be the better option and not both.

I also prefer #417


Missing regenerator-runtime dependency?

Building the snowflake-app with react-native start, failed with an error about missing regenerator-runtime/runtime.js. Adding the regenerator-runtime package as a dependency solved the problem for me.
Don't know if others have run into the same problem. Feel free to just close the pull-request, if not relevant.

Weird, I build this on a CI (Bitrise) w/no error nor has anyone else
reported.  I'll do fresh checkout later to replicate...
On Nov 16, 2016 3:14 AM, "RasmusErik Voel Jensen"<EMAIL_ADDRESS>wrote:

Building the snowflake-app with react-native start, failed with an error
about missing regenerator-runtime/runtime.js. Adding the
regenerator-runtime package as a dependency solved the problem for me.
Don't know if others have run into the same problem. Feel free to just
close the pull-request, if not relevant.
You can view, comment on, or merge this pull request online at:
https://github.com/bartonhammond/snowflake/pull/166
Commit Summary

Add regenerator-runtime as dependency

File Changes

M package.json
https://github.com/bartonhammond/snowflake/pull/166/files#diff-0 (1)

Patch Links:

https://github.com/bartonhammond/snowflake/pull/166.patch
https://github.com/bartonhammond/snowflake/pull/166.diff

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/bartonhammond/snowflake/pull/166, or mute the thread
https://github.com/notifications/unsubscribe-auth/ABORPJdQux4uCMWU7biG-dGYd62DKA-Zks5q-slwgaJpZM4KzlQ0
.

I'll do a clean checkout and try again,
to see if the problem persists,
the way I set it up is:
cd ~/tmp &&
rm -rf snowflake &&
git clone https://github.com/bartonhammond/snowflake.git &&
cd snowflake &&
npm install &&
cp src/lib/config.example.js src/lib/config.js  &&
react-native run-android &&
react-native start

If nobody else has this problem,
it is probably a bitflip, or an issue with my build setup,
so you can just close this :)
On Wed, Nov 16, 2016 at 2:53 PM, Barton Hammond
<EMAIL_ADDRESS>wrote:

Weird, I build this on a CI (Bitrise) w/no error nor has anyone else
reported. I'll do fresh checkout later to replicate...
On Nov 16, 2016 3:14 AM, "RasmusErik Voel Jensen"<EMAIL_ADDRESS>wrote:

Building the snowflake-app with react-native start, failed with an error
about missing regenerator-runtime/runtime.js. Adding the
regenerator-runtime package as a dependency solved the problem for me.
Don't know if others have run into the same problem. Feel free to just
close the pull-request, if not relevant.
You can view, comment on, or merge this pull request online at:
https://github.com/bartonhammond/snowflake/pull/166
Commit Summary

Add regenerator-runtime as dependency

File Changes

M package.json
https://github.com/bartonhammond/snowflake/pull/166/files#diff-0 (1)

Patch Links:

https://github.com/bartonhammond/snowflake/pull/166.patch
https://github.com/bartonhammond/snowflake/pull/166.diff

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/bartonhammond/snowflake/pull/166, or mute the thread
https://github.com/notifications/unsubscribe-auth/ABORPJdQux4uCMWU7biG-dGYd62DKA-Zks5q-slwgaJpZM4KzlQ0
.

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.

--
RasmusErik Voel Jensen
Independent computer scientist and software developer
more info on https://solsort.com

I did reproduce it with a clean checkout
(and also after doing an npm install,
and restart the packager as the error recommends).
I've attached an image of the error in the emulator.
Anyway I have a workaround,
and it is thus not an issue for me anymore,

so if you cannot reproduce it, just close it.

On Wed, Nov 16, 2016 at 2:53 PM, Barton Hammond
<EMAIL_ADDRESS>wrote:

Weird, I build this on a CI (Bitrise) w/no error nor has anyone else
reported. I'll do fresh checkout later to replicate...
On Nov 16, 2016 3:14 AM, "RasmusErik Voel Jensen"<EMAIL_ADDRESS>wrote:

Building the snowflake-app with react-native start, failed with an error
about missing regenerator-runtime/runtime.js. Adding the
regenerator-runtime package as a dependency solved the problem for me.
Don't know if others have run into the same problem. Feel free to just
close the pull-request, if not relevant.
You can view, comment on, or merge this pull request online at:
https://github.com/bartonhammond/snowflake/pull/166
Commit Summary

Add regenerator-runtime as dependency

File Changes

M package.json
https://github.com/bartonhammond/snowflake/pull/166/files#diff-0 (1)

Patch Links:

https://github.com/bartonhammond/snowflake/pull/166.patch
https://github.com/bartonhammond/snowflake/pull/166.diff

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/bartonhammond/snowflake/pull/166, or mute the thread
https://github.com/notifications/unsubscribe-auth/ABORPJdQux4uCMWU7biG-dGYd62DKA-Zks5q-slwgaJpZM4KzlQ0
.

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.

--
RasmusErik Voel Jensen
Independent computer scientist and software developer
more info on https://solsort.com

extra comment with image, as email attachments does not gets attached to the issue

I can't reproduce on my Mac nor on Bitrise.


Unnecessary info notification shown after selecting venv

Testing #21878
After choosing a venv option I see this info notification which feels unnecessary because it's right above the language status item, would it be possible to just wiggle the language status item when an extension changes its value if the goal is to provide confirmation that the change took place?

@karrtikr Would it be possible to add an internal API to wiggle the status item? Once we have that you can re-assign this to me to remove the notification in this case.

I'm not sure how to trigger the wiggling of the language status item. @joyceerhl Are you aware of any existing way to do so?

I do not know, @jrieken?

Actually, we use a normal status bar item and not the language status item here, given our discussion with VS Code. We don't have the ability to pin items just yet, so we can't switch to it.
Given all this, I don't think it's currently possible to trigger a wiggle.

What we can possibly do though is add some dummy item in language status and quickly remove it to trigger a wiggle.

Does it need attention brought to it? Take tasks for example which show a spinner in a status bar item when it's happening and then it just hides when the task finishes without fanfare.

If we're changing user's selected interpreter, I think we should let them know somehow.

@karrtikr we (vscode) didn't start the action though, the user did, so they already know they have changed the environment. Instead of telling them what they already know, we should inform them if we cannot do it. And if it takes some time, have some indicator like a tasks loader.

They created an environment, they did not ask to change it right? We've a prompt which previously appeared when a venv was created:

We noticed only about 70% users selected "yes", so intention of creating an environment may not always be selection 🤔 that being said, we can remove the notification and try it out.

I'm happy with using a progress indicator which briefly states "Selecting environment" instead of showing the notification.

@karrtikr activating the environment seems like it would be implied to me, but anyway the way I got the notification was clicking on the kernel picker in the top right and after it's done it shows the environment I just created.


morphablemodel::get_mean() for models with expressions

For MorphableModels that contain a PCA expression model, we have to decide whether morphablemodel::get_mean() should return the combined identity + expression mean. If yes, that would mean that the result probably wouldn't be a neutral face.

Changed this in b8be43698704deaafaa5ceff5f5e52cc66312ab3 to return the overall, combined mean now. I think that's the more sound way.
If someone wants the obtain the neutral-only shape mean, they can use get_shape_model().get_mean() and sample_to_mesh.

@patrikhuber dear author
I saw that you had an example where you could turn any expression into a neutral expression. Why didn't you see it. Now that I have extracted the expression change parameters, it works. Now I need the texture to be able to change according to the expression,


figure out nomenclature

what's the deal with the board? appointed by any logic? what are members called?

http://codes.findlaw.com/ca/public-utilities-code/puc-sect-130051.html


[Dev files preview] .reg not working

Microsoft PowerToys version
0.58.0
Running as admin

[ ] Yes

Area(s) with issue?
Developer file preview
Steps to reproduce
Updated from v0.75.2 to v0.58.0. Disabling and re-enabling the preview also didn't helped.
✔ Expected Behavior
Previewing .reg file with dev preview.
❌ Actual Behavior
Windows default preview is used for .reg files.

(Output from /tools/Verification scripts/Check preview handler registration.ps1)
PowerToysReport_2022-05-05-00-09-25.zip
Other Software
No response

cc: @aaron-junker

@aaron-junker
I like the ps script we have l. Maybe we can connect it to the json from dev preview. The list of file types is outdated

I found out what happens. The installer installs the handler correctly for .reg files, but under  HKEY_CLASSES_ROOT\regfile\ShellEx\{8895b1c6-b41f-4c1c-a562-0d564250836f} is also a key, which overwrites the one set in  HKEY_CLASSES_ROOT\.reg.
cc: @stefansjfw

I found out what happens. The installer installs the handler correctly for .reg files, but under  HKEY_CLASSES_ROOT\regfile\ShellEx\{8895b1c6-b41f-4c1c-a562-0d564250836f} is also a key, which overwrites the one set in  HKEY_CLASSES_ROOT\.reg.
cc: @stefansjfw

This is the correct behavior according to https://docs.microsoft.com/en-us/windows/win32/shell/fa-file-types

The default HKEY_CLASSES_ROOT\regfile seems to be the one from HKEY_LOCAL_MACHINE\SOFTWARE\Classes\regfile, meaning we should be able to add HKEY_CURRENT_USER\SOFTWARE\Classes\regfile for our handler.
When doing this, we need to test if the variables set directly in HKEY_LOCAL_MACHINE\SOFTWARE\Classes\regfile that we don't change are still preserved in HKEY_CLASSES_ROOT\regfile.

The default HKEY_CLASSES_ROOT\regfile seems to be the one from HKEY_LOCAL_MACHINE\SOFTWARE\Classes\regfile, meaning we should be able to add HKEY_CURRENT_USER\SOFTWARE\Classes\regfile for our handler.
When doing this, we need to test if the variables set directly in HKEY_LOCAL_MACHINE\SOFTWARE\Classes\regfile that we don't change are still preserved in HKEY_CLASSES_ROOT\regfile.

I think we should create our on files keys like PtMonacoReg to prevent collision with other apos that only replace the reference in .reg.

I think we should create our on files keys like PtMonacoReg to prevent collision with other apos that only replace the reference in .reg.

The main issue here is that in order for Preview Handler to read it, we do need to set it in the place that Windows reads it from to pick what to load for preview pane. (Perhaps I misunderstood the suggestion though)

ClassesRoot shows what is written in other places. I think it's like a merged view. So changing ClassesRoot changes HKLM and other way. (https://docs.microsoft.com/en-us/windows/win32/sysinfo/hkey-classes-root-key)
The correct way of doing is creating a key like ...\MyAppFileType with all properties and then linking ...\.ext to ...\MyAppFileType. This preserves the settings of  other apps and only changes the assignment from A to B.

I was thinking about about changin KKEY_CURRENT_USER, not Classes Root directly :)

I was thinking about about changin KKEY_CURRENT_USER, not Classes Root directly :)

We should test what has higher priority. Not sure about that.

HKEY_CLASSES_ROOT checks HKEY_CURRENT_USER before HKEY_LOCAL_MACHINE.

@Aaron-Junker
Fix with 0.62.0 or still not fixed?

@Aaron-Junker
Fix with 0.62.0 or still not fixed?

No. Not fixed

what @jaimecbernardo said makes sense to me. For this specific extension (.reg), looks like this regfile registry entry has higher priority than software/classes/.reg. So we should be able to add regfile in HKCU and make it work

Something like this https://github.com/microsoft/PowerToys/pull/20579

(don't forget the Project status)

Improved in v0.63


How to get monaco global accesible in unit tests - Karma/Jasmine

I am making use of @materia-ui/ngx-monaco-editor which wraps this library and am having trouble getting the monaco global to be recognised during unit test runs with Karma+Jasmine.
Component
import {
    Component,
    OnInit } from '@angular/core';
import { MonacoEditorLoaderService } from '@materia-ui/ngx-monaco-editor';
import { filter, take } from 'rxjs/operators';

@Component({
    selector: 'my-editor',
    templateUrl: './my-editor.component.html',
    styleUrls: ['./my-editor.component.scss']
})

export class MyEditorComponent implements OnInit {

    public modelUri: monaco.Uri;

    constructor(private monacoLoaderService: MonacoEditorLoaderService) {
        this.monacoLoaderService.isMonacoLoaded$.pipe(
            filter(isLoaded => isLoaded === true),
            take(1),
        ).subscribe(() => {
            this.monacoLoaderService.isMonacoLoaded$
                .pipe(
                    filter(isLoaded => isLoaded),
                    take(1)
                )
                .subscribe(() => {
                    // This seems to be the issue during test runs - monaco is not defined
                    monaco.languages.json.jsonDefaults.setDiagnosticsOptions({});
                })
            })
    }
}

In my component file, monaco is being resolved from interfaces exposed in the @materia-ui/ngx-monaco-editor:

Test Spec
describe('MyEditorComponent Test Suite:', () => {
    let component: MyEditorComponent;
    let fixture: ComponentFixture<MyEditorComponent>;
    let tagsService: TagsService;
    beforeEach(async(() => {
        TestBed.configureTestingModule({
            declarations: [MyEditorComponent],
            providers: [ MonacoEditorLoaderService ],
            schemas: [CUSTOM_ELEMENTS_SCHEMA]

        }).compileComponents();
    }));

    beforeEach(() => {
        fixture = TestBed.createComponent(MyEditorComponent);
        component = fixture.componentInstance;
        fixture.detectChanges();
    });

    it('Should create component', () => {
        expect(component).toBeTruthy();
    });
});

When it comes to unit testing my component, I get errors from Karma to tell me that monaco is not defined:

I am struggling with getting monaco to be correctly picked up by Karma, at least I believe thats my problem here.
Whats the right approach here to get things loading in my test suite correctly?

Is the Editor actually loading in your unit tests? Can you show your Karma config with focus on bundling/proxying the Monaco assets?

@TaylorShane my karma.conf looks very similar except one thing. In the proxies section I have
"/assets/monaco/": '/absolute' + path.resolve("./node_modules/ngx-monaco-editor/assets/monaco/")

note the ./node_modules vs your ../node_modules
perhaps thats the missing part?

@zewa666 thanks so much, that was it. Much appreciated!

@zewa666 Thanks again, that did resolve the issue with Karma not finding the loader.js file and karma now shows the editor in the browser of running tests. But whenever the unit test gets to a reference to the monaco namespace the test fails because the namespace is still undefined.
For example, references like this:
new monaco.Range(linePosition, 1, linePosition, 1) const model = monaco.editor.getModels()[0]; const diffmodel1 = monaco.editor.getModels()[1];
I'm using version 7.0.0

This sounds potentially like an issue of how your testbed is setup with the dependency on the ngx-monaco module. It needs to be instantiated and done before you get into your unit test as that should trigger the loader to get the monaco global available

`// Karma configuration file, see link for more information
// https://karma-runner.github.io/1.0/config/configuration-file.html
module.exports = function (config) {
config.set({
basePath: '',
frameworks: ['jasmine', '@angular-devkit/build-angular'],
plugins: [
require('karma-jasmine'),
require('karma-chrome-launcher'),
require('karma-jasmine-html-reporter'),
require('karma-coverage-istanbul-reporter'),
require('@angular-devkit/build-angular/plugins/karma')
],
client: {
clearContext: false // leave Jasmine Spec Runner output visible in browser
},
coverageIstanbulReporter: {
dir: require('path').join(__dirname, './coverage/test'),
reports: ['html', 'lcovonly', 'text-summary'],
fixWebpackSourcePaths: true
},
reporters: ['progress', 'kjhtml'],
port: 9876,
colors: true,
logLevel: config.LOG_INFO,
autoWatch: true,
singleRun: false,
browsers: ['Chrome'],
customLaunchers: {
ChromeHeadless: {
base: 'Chrome',
flags: [
'--headless',
'--disable-gpu',
'--no-sandbox',
'--remote-debugging-port=9222',
]
}
},
restartOnFileChange: true,
files: [
{ pattern: './node_modules/ngx-monaco-editor/assets/monaco//*.js', watched: false, included: false, served: true },
{ pattern: './node_modules/ngx-monaco-editor/assets/monaco//*.css', watched: false, included: false, served: true }
],
proxies: {
'/api': 'http://<IP_ADDRESS>:8081',
'/assets/monaco/': '/absolute' + path.resolve("./node_modules/ngx-monaco-editor/assets/monaco/")
},
proxyValidateSSL: false
});
};
`
getting the following error:


PLDM: DBus infrastructure support for redfish client

This commit enhances the system by integrating support for the DBus infrastructure. Now, few system entity paths are accessible via DBus, facilitating seamless interaction for the redfish client. This integration streamlines querying of DBus paths and enables efficient management of interface properties. Notably, the update includes the upstreaming of crucial properties like CPUCore, motherboard, and coreCount.

Changes looked good to me. How is this tested ?

this is tested on hardware and corecount properties looks like this:

xyz.openbmc_project.Inventory.Item.Cpu                interface -         -                                        -
.Characteristics                                      property  as        0                                        emits-change writable
.CoreCount                                            property  q         8                                        emits-change writable


need generic patches for 3.10.x and 4.1.x

i have a honor 6x phone with soc hi6250 at nougat versison it has 4.1.x kernel and in marshmellow version it has 3.10.x kernel.but non of them got any pathes.i have tried testing other patches but no use.
@pelya @jcadduono
This is my marshmellow source
https://github.com/OpenKirin/android_kernel_honor_berlin/tree/6.x
This is my nougat source
http://download-c1.huawei.com/download/downloadCenter?downloadId=96012&version=415794&siteCode=worldwide
Hope anyone could help me

@pelya please help me

@sriram407 He's not interested in this project anymore (i ask him many time, but no answer), so would not help.
Check-up for this at fist : https://github.com/pelya/android-keyboard-gadget/issues/101#issuecomment-354152955

I'm sorta kinda still interested, but I have neither time nor a device to
test with.
On Mon, 28 May 2018 20:01 goshil<EMAIL_ADDRESS>wrote:

@sriram407 https://github.com/sriram407 He's not interested in this
project anymore (i ask him many time, but no answer), so would not help.
Check-up for this at fist : #101 (comment)
https://github.com/pelya/android-keyboard-gadget/issues/101#issuecomment-354152955
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/pelya/android-keyboard-gadget/issues/139#issuecomment-392570941,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAJewOccqQ83nsb-X5gjfMbtvndPk-XXks5t3C1pgaJpZM4UJv6N
.

@jcadduono @pelya  i have patched https://goo.gl/AQEQjm to my source
That was succesful but i have one last doubt.How should i enable hid?
In configfs or by modifying kconfig and using android composite gadget.I prefer configfs if there is a way
cause my phone has kirin chipset and OP5 has qcom and there are few lines i android.c with qcom
Help me Please

Wtf????

@welem143 What do you mean?
Am i going wrong or right?


Codecov not working sometimes

This is a spin off from #246 where I noticed that codecov was not working. After some investigation I realised that this is not a new behaviour and there is an error that pops up in the interface see the image. Another PR with no codecov is #242 but you can find most of them by following the PR with the error from codecov.

FYI @aCampello @lizgzil

According to the docs
In order to produce an accurate coverage comparison, Codecov must have the coverage report for the pull request base.

Best Practice: Always fork a branch from a successful CI commit that has coverage uploaded, as illustrated below.

This issue occurs when the base commit (the parent commit of the first commit on the pull request) did not upload coverage and/or failed CI tests.

I have no idea how this might be happening since we always compare to main?

https://docs.codecov.io/docs/error-reference

I think there is some conversation about it happening when commits change i.e. force pushing or squash etc which makes sense according to what you found. In my PR codecov failed before because I had to fix the command that runned it so that explains it as well. So let's monitor this, maybe it is not a bug but a feature. If that is the source I wonder whether there is anything we can do to fix it when it occurs.

I will investigate this even though it might not help with hacktoberfest.

Maybe #365 is not needed, we could reason about this without another PR.
As we can see in #365 the codecov failed. if we go to codecov it says missing base report.

The previous PR that was merged was #364, check the commit hashes

And now check the hashes in main

In fact the latest hash has changed and tests are running. This is because our default merge strategy is Rebase and merge.

Another example of the problem is #362 which according to codecov has a missing base report as well

The previous PR that was merged was #363, the commit hash in the PR was

In main though the commit changed for the same reason mentioned above

A report was never produced for the new hash, maybe because there were no code changes?

Another interesting case are these missing commits

As you can see one of those commits made it to main with codecov saying it cannot find it while the others exist on a branch of this PR https://github.com/wellcometrust/WellcomeML/pull/351/commits that was never merged.
As we ca see from observing the commits, all those commits have failed builds.

This is not a problem most of the time as the last commit before we merge should have tests passing and an accurate coverage report but it is worth noting as someone might branch out from a commit with failed build and this would create problems


Updated communities widgets with Travis's changes.

In the long run, I take it we are going to ditch keeping widget JavaScript
code in the narrative codebase and migrate it all to ui-common.  Should I
not worry about the need to have 2 copies of the code until after the
February event?
On Friday, February 6, 2015, Bill Riehl<EMAIL_ADDRESS>wrote:

You can view, comment on, or merge this pull request online at:
https://github.com/kbase/ui-common/pull/82
Commit Summary

Updated communities widgets with Travis's changes.

File Changes

M src/widgets/communities/kbaseAbundanceDataBoxplot.js
https://github.com/kbase/ui-common/pull/82/files#diff-0 (9)
M src/widgets/communities/kbaseAbundanceDataPcoa.js
https://github.com/kbase/ui-common/pull/82/files#diff-1 (2)
M src/widgets/communities/kbaseAbundanceDataTable.js
https://github.com/kbase/ui-common/pull/82/files#diff-2 (6)
M src/widgets/communities/kbaseAbundanceDataView.js
https://github.com/kbase/ui-common/pull/82/files#diff-3 (22)

Patch Links:

https://github.com/kbase/ui-common/pull/82.patch
https://github.com/kbase/ui-common/pull/82.diff

—
Reply to this email directly or view it on GitHub
https://github.com/kbase/ui-common/pull/82.

Yes, that's exactly the plan. These are mainly for the reasonably simplistic landing pages that Matt's leading the charge on, and it was decided that, although not really a good solution, this is the easiest way forward.