Tutorial to migrate from MongoDB to TypeDB

This issue was originally posted by @sorsaffari  on 2018-08-22 19:16.
The main objectives of this task are to:

Describe the strengths and weaknesses of MongoDB
Describe the strengths of TypeDB
Describe how to model a simple domain with rich relationships in TypeDB
Load the data into TypeDB (keep it short; refer to migration tutorial if the user wants to learn more)
Demonstrate interesting and insightful queries using TypeDB

Database Comparison
The audience is assumed to be experienced with MongoDB
MongoDB Strengths and Weaknesses
MongoDB is great in,

Allows changes in the design over time
Has built-in support for Geospatial data
Scales well horizontally (Sharding)
Document based query language that feels familiar to the JS community

MongoDB sucks in that it's:

Limited by its initial design: it’s only when you start working with a complex aggregation framework, that you realise the need to redesign the data scheme
The aggregation framework gets large fast and becomes difficult to read (mongoose tries to solve this).
It’s not possible to bind logic to a stored procedure
(complex) transactions are sacrificed for better scalability
Proper (strict) indexing is required for better performance. From MongoDB Docs

Introduce TypeDB
TypeDB is awesome in,

You don’t have to know all future requirements when coming up with the initial design. as the requirements evolve, TypeDB adopts
Queries are short and easy to read
Rules can be defined to make my knowledge graph learn and become more intelligent
Interconnected pieces of data, allow complex transactions

Dataset and Analysis
People who call each other. Those who make calls have a contract with company Telecom.
Insights

Since September 14th, which customers called person X?
Who are the people who have received a call from a London customer aged over 50 who has previously called someone aged under 20?
Who are the common contacts of customers X and Y?
Who are the customers who 1) have all called each other and 2) have all called person X at least once?
How does the average call duration among customers aged under 20 compare those aged over 40?

This will come under the broader Migration section in the new documentation.


  Could your issue with the command line or PowerShell?  If you drop that line into a .js file and run it with node, does the same thing happen?  If you open node interactively (node -i) and paste that line, does it run?
$ node -p "require('./dist/index.cjs')('http://localhost:3000/').then(console.dir, console.dir)"
Promise { <pending> }
Response {
  size: 0,
  [Symbol(Body internals)]: {
    body: PassThrough {
      _readableState: [ReadableState],
      _events: [Object: null prototype],
      _eventsCount: 7,
      _maxListeners: undefined,
      _writableState: [WritableState],
      allowHalfOpen: true,
      [Symbol(kCapture)]: false,
      [Symbol(kCallback)]: [Function: bound onwrite]
    },
    boundary: null,
    disturbed: false,
    error: null
  },
  [Symbol(Response internals)]: {
    url: 'http://localhost:3000/',
    status: 200,
    statusText: 'OK',
    headers: Headers { [Symbol(query)]: [Array], [Symbol(context)]: null },
    counter: 0,
    highWaterMark: 16384
  }
}

If you drop that line into a .js file and run it with node, does the same thing happen?

Still gives the error.

If you open node interactively (node -i) and paste that line, does it run?

Still gives the error.
I'll add the error here as I didn't seem to add it in the original post.
➜  Test node .\test.js
D:\CodingProjects\Discord\Bord\node_modules\node-fetch\lib\index.js:1305
                throw new TypeError('Only absolute URLs are supported');
                      ^

TypeError: Only absolute URLs are supported
    at getNodeRequestOptions (D:\CodingProjects\Discord\Bord\node_modules\node-fetch\lib\index.js:1305:9)
    at D:\CodingProjects\Discord\Bord\node_modules\node-fetch\lib\index.js:1410:19
    at new Promise (<anonymous>)
    at fetch (D:\CodingProjects\Discord\Bord\node_modules\node-fetch\lib\index.js:1407:9)
    at ClientRequest.<anonymous> (D:\CodingProjects\Discord\Bord\node_modules\node-fetch\lib\index.js:1539:15)
    at ClientRequest.emit (node:events:329:20)
    at HTTPParser.parserOnIncomingClient (node:_http_client:652:27)
    at HTTPParser.parserOnHeadersComplete (node:_http_common:126:17)
    at Socket.socketOnData (node:_http_client:518:22)
    at Socket.emit (node:events:329:20)

@LukasDoesDev Can you post your package.json and test.js files? Based on a separate conversation, I'm thinking this is related to something within the discord library.

im having the same issue with the URL "https://discord.com/api/v8/oauth2/token"
Package:
  "name": "token-app",
  "version": "0.0.1",
  "description": "A token app.",
  "main": "server.js",
  "scripts": {
    "start": "node server.js"
  },
  "dependencies": {
    "express": "^4.17.1",
    "node-fetch": "^2.6.1"
  }
}

And server.js:
const express = require("express");
const fetch = require("node-fetch");
const app = express();

app.get("/", (req, res) => {
  fetch("https://discord.com/api/v8/oauth2/token", {
    method: "POST",
    body: "grant_type=client_credentials&scope=identify",
    headers: {
      Authorization:
        "Basic [redacted]",
      "Content-Type": "application/x-www-form-urlencoded"
    }
  })
    .then(r => r.json())
    .then(response => {
      res.json(response);
    });
});

app.use(express.static("site"));

const listener = app.listen(process.env.PORT, () => {
  console.log("Your app is listening on port " + listener.address().port);
});

im having the same issue with the URL "https://discord.com/api/v8/oauth2/token"
Package:
  "name": "token-app",
  "version": "0.0.1",
  "description": "A token app.",
  "main": "server.js",
  "scripts": {
    "start": "node server.js"
  },
  "dependencies": {
    "express": "^4.17.1",
    "node-fetch": "^2.6.1"
  }
}

And server.js:
const express = require("express");
const fetch = require("node-fetch");
const app = express();

app.get("/", (req, res) => {
  fetch("https://discord.com/api/v8/oauth2/token", {
    method: "POST",
    body: "grant_type=client_credentials&scope=identify",
    headers: {
      Authorization:
        "Basic [redacted]",
      "Content-Type": "application/x-www-form-urlencoded"
    }
  })
    .then(r => r.json())
    .then(response => {
      res.json(response);
    });
});

app.use(express.static("site"));

const listener = app.listen(process.env.PORT, () => {
  console.log("Your app is listening on port " + listener.address().port);
});

Hello I got the same problem.
I have only node-fetch as a dependency.
`const headers = new Headers();
headers.append("Accept", "application/x.dx4.publicws.rest+json;version=4.0.1");
headers.append("Content-Type", "application/json");
headers.append("Authorization", "Bearer " + global.db.rwt);
    const request = {
        "customerName": global.db.customerName,
        "userName": global.db.username,
        "password": global.db.password
    };

    const url = new URL("/restws/publicws/rest/api/v1/login", global.db.url);
    console.log(url);

    const response = await fetch({
        mode: "cors",
        method: "POST",
        url: url.href,
        headers: headers,
        body: JSON.stringify(request)
    });`

URL: 'https://********/restws/publicws/rest/api/v1/login'
Node Version 14.15.4

Hello I got the same problem.
I have only node-fetch as a dependency.
`const headers = new Headers();
headers.append("Accept", "application/x.dx4.publicws.rest+json;version=4.0.1");
headers.append("Content-Type", "application/json");
headers.append("Authorization", "Bearer " + global.db.rwt);
    const request = {
        "customerName": global.db.customerName,
        "userName": global.db.username,
        "password": global.db.password
    };

    const url = new URL("/restws/publicws/rest/api/v1/login", global.db.url);
    console.log(url);

    const response = await fetch({
        mode: "cors",
        method: "POST",
        url: url.href,
        headers: headers,
        body: JSON.stringify(request)
    });`

URL: 'https://********/restws/publicws/rest/api/v1/login'
Node Version 14.15.4

@mathiasschuetz Can you please post 1) your full script, 2) the result of console.dir(global.db), and 3) the version of node-fetch you are using?

@mathiasschuetz Can you please post 1) your full script, 2) the result of console.dir(global.db), and 3) the version of node-fetch you are using?

Hello @tekwiz

async function login() {
    const headers = new Headers();
    headers.append("Accept", "application/x.dx4.publicws.rest+json;version=4.0.1");
    headers.append("Content-Type", "application/json");
    headers.append("Authorization", "Bearer " + global.db.rwt);

    const request = {
        "customerName": global.db.customerName,
        "userName": global.db.username,
        "password": global.db.password
    };

    const url = new URL("/restws/publicws/rest/api/v1/login", global.db.url);
    console.log(url);

    const response = await fetch({
        mode: "cors",
        method: "POST",
        url: url,
        headers: headers,
        body: JSON.stringify(request)
    });

    if (response.ok) {
        return await response.text();
    } else {
        return undefined;
    }
}

no sorry it has only user information
node-fetch: 2.6.1

Hello @tekwiz

async function login() {
    const headers = new Headers();
    headers.append("Accept", "application/x.dx4.publicws.rest+json;version=4.0.1");
    headers.append("Content-Type", "application/json");
    headers.append("Authorization", "Bearer " + global.db.rwt);

    const request = {
        "customerName": global.db.customerName,
        "userName": global.db.username,
        "password": global.db.password
    };

    const url = new URL("/restws/publicws/rest/api/v1/login", global.db.url);
    console.log(url);

    const response = await fetch({
        mode: "cors",
        method: "POST",
        url: url,
        headers: headers,
        body: JSON.stringify(request)
    });

    if (response.ok) {
        return await response.text();
    } else {
        return undefined;
    }
}

no sorry it has only user information
node-fetch: 2.6.1

no sorry it has only user information

@mathiasschuetz That's reasonable, but I at least need to see the output of console.dir(global.db.url)

no sorry it has only user information

@mathiasschuetz That's reasonable, but I at least need to see the output of console.dir(global.db.url)

I have had a similar issue, and the problem was multiple versions of node-fetch.  In my case I was running in a monorepo and the test app and the support packages resolved to different node_modules folder.   Somewhere deep in the implementation there is a check against a JS symbol which would not match in this case.

@tbrannam yes you are right. I got fixed my problem by using FormData and Axios in combination

I can't give the package.json because i lost the whole project to a drive failure. Good thing most of my projects are on GitHub or GitLab.

package.json: https://www.github.com/LukasDoesDev/bord/tree/master/package.json

I have had a similar issue, and the problem was multiple versions of node-fetch. In my case I was running in a monorepo and the test app and the support packages resolved to different node_modules folder. Somewhere deep in the implementation there is a check against a JS symbol which would not match in this case.

how did you solve that?

I have had a similar issue, and the problem was multiple versions of node-fetch. In my case I was running in a monorepo and the test app and the support packages resolved to different node_modules folder. Somewhere deep in the implementation there is a check against a JS symbol which would not match in this case.

how did you solve that? @tbrannam

I changed the example project to only reference node-modules as a peer dependency.  And relied on the root node_modules folder to already have it installed.

same here windows 10

@pavelloz @steelx could you submit the exact code that aren't working, along with exact versions of node-fetch, node, npm, and os?
node -p "require('./dist/index.cjs')('http://localhost:3000/').then(console.dir, console.dir)"

Is this not working?


fix(initState): typing gql and initState API response

try adding the first event handler type definition in types directory
typing gql and initState() handler
update typegen result with latest staging Cofacts API

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

24 of 24 (100.0%)  changed or added relevant lines in 2 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.4%) to 90.714%

Totals

Change from base Build<PHONE_NUMBER>:
-0.4%

Covered Lines:
976

Relevant Lines:
1048

💛  - Coveralls


Contributing to: .json

Adding/Updating .json

Woops, sorry about that!

No worries :) Happens all the time.


auto rotate not working when orientation is 3

Possible bug
Is this a possible bug in a feature of sharp, unrelated to installation?

[x] Running npm install sharp completes without error.
[x] Running node -e "require('sharp')" completes without error.

If you cannot confirm both of these, please open an installation issue instead.
Are you using the latest version of sharp?

[x] I am using the latest version of sharp as reported by npm view sharp dist-tags.latest.

If you cannot confirm this, please upgrade to the latest version and try again before opening an issue.
If you are using another package which depends on a version of sharp that is not the latest, please open an issue against that package instead.
What is the output of running npx envinfo --binaries --system --npmPackages=sharp --npmGlobalPackages=sharp?
System:
OS: Linux 5.10 Ubuntu 20.04.4 LTS (Focal Fossa)
CPU: (16) x64 AMD Ryzen 7 3700X 8-Core Processor
Memory: 17.21 GB / 25.01 GB
Container: Yes
Shell: 5.0.17 - /bin/bash
Binaries:
Node: 16.14.0 - ~/.nvm/versions/node/v16.14.0/bin/node
Yarn: 1.22.17 - /mnt/c/Users/icyly/AppData/Roaming/npm/yarn
npm: 8.5.4 - ~/.nvm/versions/node/v16.14.0/bin/npm

What are the steps to reproduce?
There are two ways to recreate the problem:

Try to rotate an image by 180 degrees
Have an image with orientation: 3 and call rotate without arguments

What is the expected behaviour?
Image is rotated by 180 degree.
This still works if I downgrade to version 0.30.7
Please provide a minimal, standalone code sample, without other dependencies, that demonstrates this problem
const img = fs.readFileSync("./test.jpg");
const image = sharp(img);
image.rotate();
const metadata = await image.metadata();
console.log("meta", metadata);
image.resize(320, 240);
const buffer = await image
  .jpeg({ force: true, quality: 75 })
  .toBuffer();
fs.writeFileSync("./out.jpeg", buffer);

Please provide sample image(s) that help explain this problem
Input

output 0.30.7

output 0.31.0

Hi, thanks for reporting, this is due to the same problem as #3352 - let's track it rhere.


Fixed Covid-19 page image and navbar font sizes

Description
make the image responsive and fixed the sizes of navbar.
Fixes:  #551

Type of change

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

Checklist:

[x] I have made this from my own
[ ] I have taken help from some online resourses
[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[x] My changes generate no new warnings

ATTACH SCREEN-SHOTS / DEPLOYMENT LINK

Which html file are you talking about @VidhiBhatt01 ?


Archival memory/Memory issues

Using: text-generastion-webui
Model: ehartford_dolphin-2.2-mistral-7b - not quantized
Installed: using pip install -r requirements
OS: Windows 10
Shell: cmd.exe
Python: Python 3.11.3
pymemgpt installed: yes
Hardware: 12th Gen i7 64GB/RAM, RTX3060 12GB RAM
LLM and MemGPT on same system
There seems to be a problem with the archival memory usage (it's not happening) since I updated to memgpt 1.8

Including this in case it's related, I see this often after a few pages of conversation it repeats:

Could you double check your config ~/.memgpt/config to make sure archival memory is set to local? You should see something like this:
[archival_storage]
type = local

If that looks ok, when can you try re-running with memgpt run --debug and see if it outputs additional logs?
Can you also check what happens if you run the /memory command?

config shows:
[archival_storage]
type = local
/memory works fine, the archival section is empty, any memory editing fails, core_memory_update/edit/etc, same with archival memory, I just get;  insert error RetryError[<Future at 0x204beff9310 state=finished raised AuthenticationError>]

trying --debug

Could you show a screenshot of what happens with a core memory update?

lol this time it has no knowledge of that function, normally it reports the authentication error

not sure if it's related but if you recall- after I updated yesterday, in another ticket I reported the following trouble and you told me to delete .memgpt/config to fix it

I found this in the output:
Incorrect API key provided: NULL. You can find your API key at
https://platform.openai.com/account/api-keys.
I am hosting locally and not using OpenAI, I will remove the env variable for OPENAI_API_KEY as I do not need it and set it as a 'just in case' since I saw it had a bearing on something else I was reading about I threw it in there. I'll remove it and start over and see what happens.

I now get this when I start without that env variable:

confirmed that webui is set as the BACKEND_TYPE

confirmed that webui is set as the BACKEND_TYPE

The last few errors are from not having OPENAI_API_BASE set (https://memgpt.readthedocs.io/en/latest/webui/). Not sure about the archival memory error, that's odd, looking into it.

Can you share whats in your ~/.memgpt/config in the [embedding] section?

[embedding]
model = local
dim = 384
chunk_size = 300

cpacker, above you said:  The last few errors are from not having OPENAI_API_BASE set (you need both BACKEND_TYPE and OPENAI_API_BASE to be set, https://memgpt.readthedocs.io/en/latest/webui/). Not sure about the archival memory error, that's odd, looking into it.
This is untrue for me, both of those variables are and have been set - those errors are not caused by a lack of having those env vars set properly in my case. Also note that the OPENAI_API_KEY is one the I mentioned because --debug revealed the detail I posted above complaining that I do not have a valid API KEY

Hm so I'm pretty confused why there would be any kind of authentication error, since everything should be done locally for the embeddings if thats what your config is set to. Could you try running with memgpt installed via pip install pymemgpt-nightly and see if you have the same issues?

ok sure, can I just run that in the current memgpt conda env?

btw. I had to restore the system env variable OPENAI_API_KEY=Null in order to run memgpt, without it I get the invalid API key error above and can't run memgpt at all.

I'm not sure if I should do this on top of my current install or not, waiting for confirmation from you. Also if you have Anydesk installed I can give you my ID so you can check it out for yourself

Could you try:
pip uninstall pymemgpt
pip install -U pymemgpt-nightly

Things appear to be working, the archival memory is being populated without error, what should I do now?

Are there any other problems? If not I can close this issue.

I 'think' things are working properly, will this nightly build become tomorrow's update? should I 'pip uninstall' it and normally install memgpt tomorrow?


Build for dev?

Hi,
I am missing one function - build dev.
Why? I am using it with Laravel, a lot of ajax etc and I need to run it from Laravel not from dev: localhost:8080.
It is also giving me issues with devtools...

@phanan What's your typical strategy for Laravel integration? I can explain what I do for Rails and I'm guessing the general strategy should transfer, but Laravel-specific instructions would probably be more helpful. 🙂

@chrisvfritz Interactions with server/templates, also I am using bootstrap components which are using bootstrap CSS etc.
What's your suggestions?

@mariaczi I actually just published this, which demos 3 different Vue integrations with Rails, including one that uses this template and includes Bootstrap. What may be of particular interest to you is the proxyTable config and how Bootstrap is included via bootstrap-sass.

Hey, sorry I missed this. I've never tried Vue Webpack + Laravel combo before actually, but will try to find some time this weekend to look at it.

@mariaczi I'm moving this issue to the forum, as it looks like someone has found a good solution and is able to answer questions about it.


Luxon

Switch away from moment-timezone
Reduced package size to 1.44 mb
Restyled 'meetings in progress' section

playwright is installed, i have no idea why that test is not working
otherwise everything seems good:

https://tsml-ui.code4recovery.org/tests/aasanjose.html old
https://deploy-preview-244--tsml-ui.netlify.app/tests/aasanjose.html new


Show_app_links flag added to public site .env

Flag enables or disables "application due" on listings pages
Pull Request Template
Issue
#157
Addresses # (issue)

[x] This change addresses the issue in full
[ ] This change addresses only certain aspects of the issue
[ ] This change is a dependency for another issue
[ ] This change has a dependency from another issue

Description
Creates an App flag that enables or disables showing the Application countdown.
Type of change

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Prototype/POC (not to merge)
[ ] This change is a refactor/address technical debt
[ ] This change requires a documentation update
[ ] This change requires a SQL Script

How Can This Be Tested/Reviewed?
Look at listings page as well as individual page, to see Application Due countdown removed.

[x] Desktop View
[x] Mobile View
[ ] Test A
[ ] Test B

Checklist:

[ ] My code follows the style guidelines of this project
[ ] I have performed a self-review of my own code
[ ] I have reviewed the changes in a desktop view
[ ] I have reviewed the changes in a mobile view
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes
[ ] Any dependent changes have been merged and published in downstream modules
[ ] I have assigned reviewers
[ ] I have updated the changelog to include a description of my changes

I see in #157 that you mentioned putting this SHOW_APP_LINKS flag in .env - could we do that in this PR? (And that was my assumption - that feature flags like this go in the .env - but have we confirmed that?)
A separate thought: maybe we can make this change one level up: wherever ApplicationStatus is invoked instead of returning null for ApplicationStatus.

I agree about trying to change this at the sites/public level instead of at the ui-components level.

@willrlin Exactly what I discovered while playing around here before lunch.  If we pass the listing prop, the Image block will show the ApplicationStatus, or as I was able to trigger in my local with a small update, the ListingUpdate:

We could enable some logic (or another prop) if we want to only show the ListingUpdate and no ApplicationStatus.
Additionally, to your point, since this is the public src file for ListingView, we could just remove the other instances of ApplicationStatus (one for desktop on right rail, one for mobile **see screenshot), and either replace with ListingUpdate, or not include since its up in the ImageCard.

Also, this was refactored slightly upstream - instead of passing the entire Listing to the ImageCard, it's now just the application status - see https://github.com/CityOfDetroit/bloom/pull/325.

Closing this PR and taking learnings to new PR with latest ListingsList changes from upstream.


Improve ConvLSTM2D computations and reduce the problem size

This PR is to improve speed of ConvLSTM2D tests.

I confirmed it was effective on my laptop (MacBook Pro), but it is not so on travis..


How to pass through an element without rendering?

Is there a way to pass through an element and leave it un-modified in the output?
I am using this (great!) tool to prepare loads of transaction emails for use in our Netsuite/ecommerce implementation. In the example below I need to leave this line alone <#list transaction.item as item><#if item_index==0> for Netsuites templating engine to iterate on on send. For all the rest of the email, I need the optimised html output from the dist folder. (I have about 60 differing emails to do here!)

The details of your order are;

   **<#list transaction.item as item><#if item_index==0>**

Foo1

{item.quantity@label}	{item.itemname@label}

               </#if>
${item.quantity}	${item.description}
                </#list>

I should add that I have tried:
{{{<#list transaction.item as item><#if item_index==0>}}}
{{{{raw}}}}<#list transaction.item as item><#if item_index==0>{{{{/raw}}}}
\<#list transaction.item as item><#if item_index==0>}}}
and many other variants!

Hey @Mizpah haven't had time to look into this in detail but looks like you've tried the raw option which I thought would have worked. I found a slight variation of it here. And also a helper someone documented here. Two options worth looking at. I can dig deeper if this doesn't work.

I'm looking for similar, too. Trying to establish a workflow where this tool helps us develop and test templates that would make their way to Postmark as a template. Their templating language is Mustachio, which is mostly similar to what we're doing in handlebars. I think all the syntax I'd want to use is the same between HBS and Mustachio.
My ideal scenario is to build the template with g-e-w with dummy data provided from a /data file, iterate over it fully rendered, then be able to flag a render to output in "template mode," with no dummy data and all the partials flattened.
In this scenario, littering my template w/ extra flags would be sub-par.
I'll see if I can pull it off with a helper, but any feasibility insight would be super.

@Mizpah - Block Helpers, see Raw Block sample are pry your best bet for getting uncompiled handlebars into your dist/ output.
@ericdfields - Agree this is helpful.
I've done a few iterations on the preview app that will render the compiled dist/ templates using various flavors (liquid, handlebars, php), plus allow you to create sample data files (json / yaml) that get parsed in for previewing only. You get A+ previews, and your templates are ready to ship as-is. TL;DR - Involves modifying server.js - I'll open a suggestion issue for this specifically.

@taeo very cool. Thanks for the guidance.

@Mizpah - I just tried a variation of your code and it works just fine without the need to bypass compiling. Out of the box, handlebars won't compile non-handlebars syntax.
Both your sample code and the following simplification worked without issue and ended up in the compiled .html template identical to the input in .hbs
<#list transaction.item as item>
    <#if item_index==0>
        {item.quantity@label}
    </#if>
    ${item.description}
</#list>

Did you have any specific errors or munged output that you can share?

Thanks @taeo - will dive into this later today, and put together a .hbs and the output thats being modified!

Back again! As per the email above, am back doing some more of these. Here is an .hb containing an orders table.

<#list transaction.item as item><#if item_index==0>

      {item.quantity@label}	{item.itemname@label}

</#if>

      ${item.quantity}	${item.description}

</#list>

Line 2 is the issue - when output in the workflow it looks like this:
<#list transaction.item="" as="" item=""><#if item_index="=0">
Which is enough to prevent it from being imported into the netsuite mail templates.

@Mizpah99 - The juice task is treating the netsuite template syntax as html, converting logic and operators into attributes <#if item_index==0> becoming <#if item_index="=0">
You can reproduce the issue in isolation over here: http://automattic.github.io/juice/
I don't see a clear path to fixing that without doing something obscure.
For example. The following passes through juice unmodified. You'd have to then replace [[ to < and ]] to > after the juice task using something like grunt-replace

  [[#list transaction.item as item]]
  [[#if item_index==0]]

      {item.quantity@label}	{item.itemname@label}

  [[/#if]]

      ${item.description}

  [[/#list]]

With respect to non-html looking entities, passing other data through.
You can pass un-rendered single line hbs code with a backslash like this \{{myvar}}
#87 is working towards adding a raw helper and much more.


[release/1.1 backport] Update runc to 96ec2177ae841256168fcf76954f7177af

backport of https://github.com/containerd/containerd/pull/2857 for the 1.1 branch.
minor conflict in vendor.conf, but trivial to resolve.
This fixes a regression in runc that didn't allow signals being sent to
paused containers.

@crosbymichael @estesp ptal

The vndr run double-check during CI doesn't think the changes match?
These files were modified:
 M vendor/github.com/opencontainers/runc/libcontainer/configs/config.go
The command "script/validate/vendor" exited with 1.

ouch; thought about re-running vndr, but didn't do that 😊 let me fix that

updated; let's see if it goes green now 👍

Codecov Report

Merging #2864 into release/1.1 will not change coverage.
The diff coverage is n/a.

@@             Coverage Diff              @@
##           release/1.1    #2864   +/-   ##
============================================
  Coverage        48.99%   48.99%
============================================
  Files               85       85
  Lines             7603     7603
============================================
  Hits              3725     3725
  Misses            3203     3203
  Partials           675      675

Flag
Coverage Δ

#linux
48.99% <ø> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dbf186d...a1bfd3a. Read the comment docs.

LGTM


Profile asks to verify veteran status after verified.

Bug Report
What is the current behavior?
Go to operationcode.org profile and verify id for first time using ID.me. When finished return to profile and the page still requests user to verify in right side.
What is the expected behavior?
User shouldn't be asked to verify again.
What steps did you take to get this behavior?

Login to operationcode.org
Navigate to profile.
Click Sign in with troop ID.
Successfully verify status.
Return to profile and see the request.

Additional Info
Screenshots

Upon being logged out (timeout) and logging back-in this is what I see. So it's a bug?


chore: update changelog generation process

The update enhances the changelog generation process in multiple ways. Firstly, it uses the new documentation website and ensures that directory and branch names follow a more uniform naming pattern. Also, it optimizes how the changelog information is extracted from Jira by filtering out irrelevant issues and fetching additional details, enhancing the document's content. Temporary files used in the process are now being stored in a local '.tmp' folder, which is ignored by Git, keeping the repository clean.
Cherry-pick of 074895e0b

We do not run IntegTests as it is only changes in the release process scripts


Reduced fonts list for tests

The project currently expects the full Noto font set to be installed on the system in order to run the tests. The package is over 1GB in size and contains over 1600 font files. This is especially problematic for Windows CI tests automation where each font must be installed one by one.
We should instead identify the fonts that are actually used in the tests and only install those.

I whole heartedly agree.  I just updated the rfctools docker container to pull in all of those font files and it made the container nearly 2GB.  I'd love to reduce the size of that while also having proper PDF output.

@paulej - you're asking for something different than what this issue is trying to achieve - the minimal set of fonts that would be needed for the tests to run is smaller than the set that a general-purpose installation of xml2rfc would need to produce arbitrary pdfs. The set of fonts needed for that may also be smaller than "All of them", but it's still a different set.
Consider building a utility into your container that would let users augment the set of fonts on demand? If that were easy, starting with just the fonts needed for testing might be good enough.

@rjsparks Ah, sorry for diverging the topic. Yesterday was the first time I used xml2rfc to build a PDF file and was astonished at how large the font set was. I'm not familiar enough with usage to know which are safe to include or exclude. As one who just wants to output a document, how would I know? I would assume there must be a sunset the RFC editor will use.

It depends on the document. For any specific doc it would use a considerably smaller set but I agree with Robert that it's hard to predict in advance exactly what fonts any specific doc would need.
It'd definitely be better to arrange to fetch missing fonts on the fly.


Debug button not disabled when app is not running

If the app isn't running, I would expect the Debug button to be disabled/grayed-out.

For the record, clicking on Debug doesn't do anything. Which is expected.

It opens the debugger view, or activates it if it's already open.

If my app isn't running, why would I want to open the debugger view?

Currently it's the only place to see a full list of breakpoints.

ah. interesting. The look of that button makes me think Verb/Action. "Debug now". I don't think "view the debug window and its various things".
Debug is a verb.
Maybe Debugger is better here. Debugger is a noun.

Change update, nomenclature change is easy. I'm going for terseness in the button labels - there's a bunch of them now, and they take up a lot of horizontal space.
I think the breakpoints view will move into it's own tab - there's no need to give it such a prominent position in the debugger view. Then the debugger button can be disabled when the app terminates.

I think the breakpoints view will move into it's own tab - there's no need to give it such a prominent position in the debugger view. Then the debugger button can be disabled when the app terminates.

That works. Do you have an issue for that, which we can link up?
I know terseness is a goal, which I love. But consider noun or verb in relation to buttons (which, usually perform a verb)


Add append and format option in LogReport

TODO: add tests

/test

TODO: Add a proper LogReport test that writes the file and parses it back.
There is currently no LogReport test, so I will be adding it in a different PR

/test

CI fails are real :(

/test

/tes

/test


Commit init

Description of change

Pre-Merge Checklist

[ ] Tests and/or benchmarks are included
[ ] Documentation is changed or added
[ ] Lint process passed (npm run lint)
[ ] Tests passed (npm run test)

These images are non-critical resources and used for tests only. We are not interested in this change, thanks.


⚠ ClamAV has degraded performance

In 91781ce, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 94 ms

Resolved: ClamAV performance has improved in 0c1cfcb.


Gift Card donation notification for Collective

Current status
In the current state, when an Individual donate to a Collective using a Gift Card, the Collective is receiving two notifications. One notifying the Individual joined as a Backer, one notifying the Organization joined.
Expected
We would like to replace that with a single email.
Screenshots

Got a feedback requesting this today: https://opencollective.slack.com/archives/C1974QBNK/p1564181467005300

Another related issue that would be solved by this (from https://opencollective.freshdesk.com/a/tickets/2301)
When contributors make their first contributions to collectives, we create a new Member entry and send an email to notify the collective. When existing contributors join other tiers, we still send emails.
Example: If I join Babel's "Bronze Sponsor" + "Gold Sponsor" tiers, they'll receive two emails:

Benjamin is now a Bronze Sponsor of Babel
Benjamin is now a Gold Sponsor of Babel

The problem is that when using gift cards, a lot of people will join many different tiers and we send unnecessary notifications.

Rather than developing a new email template, I propose that we pass the payment method on the existing "New Backer" email.

We should include the gift card emitter name, OC profile link and website. Maybe we can re-use the same design from the redeemed page?
If we want to prioritize this issue, this is something I'd be happy to work on.


Add groth16 proof verifier EE

based on https://github.com/cdetrio/scout.ts/tree/bn128-pairing

I've moved this code to its own standalone repository at https://github.com/jwasinger/groth16-verify-wasm .

Would be nice to have a README and/or commented code which explains the expected input to the verifier.

I've detailed the input format in the README in the repository.


Support Helm 3.7.0

With the release of Helm 3.7.0, the OCI specific segments were completely reworked, causing helmfile to fail with OCI charts
This PR seeks to address the Helm specific changes required
HIP-006
Helm 3.7.0

Please, helm 3.6.3 doesn't support to install a 3.7.0 packaged helm chart:
Error: manifest does not contain a layer with mediatype application/tar+gzip]

Looking for this too. What would be the oci format in helmfile. Is this correct?
releases:
- name: some-chart
  namespace: default
  chart: oci://myrepo.azurecr.io/charts/some-chart:0.1.1

Looking for this too. What would be the oci format in helmfile. Is this correct?
releases:
- name: some-chart
  namespace: default
  chart: oci://myrepo.azurecr.io/charts/some-chart:0.1.1

@dkirrane I've ensured oci:// get added in automatically to prevent disruptions to existing helmfiles using OCI charts
I think the code segment below should work
releases:
- name: some-chart
  namespace: default
  chart: myrepo.azurecr.io/charts/some-chart
  version: 0.1.1

Leaving out oci:// is good with me

I prefer removing the oci: true property, and explicitly adding the oci:// protocol

I prefer removing the oci: true property, and explicitly adding the oci:// protocol

The first part would be out of scope for this PR at least, since it'd require a lot of changes as to how helmfile differentiates a regular chart from an OCI one, the second part my only concern is, how many users/workflows would be affected since they'd need to edit their helmfile to accommodate this
Helm 3.7.0 was a already a breaking  change (for no good reason on the OCI side) which disrupted a lot of systems

You are right, and I agree with you, however there is to consider that the approach used by Helm for the management of the OCI was declared as experimental, and could be removed at any moment, to be used at your own risk.
In any case, in my opinion, it is possible to manage both approaches, to avoid breaking changes:
url: acr.azurecr.io
oci: true

and
url: oci://acr.azurecr.io

You are right, and I agree with you, however there is to consider that the approach used by Helm for the management of the OCI was declared as experimental, and could be removed at any moment, to be used at your own risk.
In any case, in my opinion, it is possible to manage both approaches, to avoid breaking changes:
url: acr.azurecr.io
oci: true

and
url: oci://acr.azurecr.io

I'll try experimenting on this and see if I can get it to work
Keeping both options sounds like a good idea 👍

Hello
Do you have any estimation on releasing a new version with this fix ?

+1
Urgently waiting for the compatibility update

@roboll Are there any blockers we need to resolve to get have this merged?

@mumoshu Could I get a review for my PR?

@eshepelyuk @sbckr @whyman I don't usually say things like this as I believe users know what they're doing but anyway- You shouldn't use any experimental features in a production-like environment that requires urgency in enhancements like this!
Ah..., or maybe we lack documentation on the helmfile side to say that helm's OCI support is experimental?
I had been blindly assuming everyone reads helm doc before using helmfile so they might know helm's OCI support is experimental, but I'm now doubting if the expectation is correct.
I can get important feedbacks like this only when it breaks so I'd appreciate your feedback.

@mumoshu I really like the OCI support in helm and helmfile, and we use this feature in our alpha-ish / development environment. The recent changes to helm broke our convenience setup, and there would have been many ways to work around the issue that arose, but I wanted to express my support for the enhancement provided by @aditmeno and OCI support in general.
Regarding your question, helm indicates in its documentation or feature abstract that the support for OCI is experimental. Since helmfile adds on top of helm, it is more or less implicit that this feature is experimental, but unless I am missing something elsewhere, it is not written in helmfile's documentation directly. If you want to make it explicit, I'd suggest to add a note to oci-registries referring to Helm - Registries or OCI Feature Abstract.


can't use Bootstrap.css file to make Navbar as drop-down on Responsive Mobile View

Hello
I need help, I want to learn Bootstrap where I can use Bootstrap.css to to Website's Navbar as Drop-Down on Responsive Mobile View.
Please help me in this.
Waiting for your quick reply,
Dhaval

sorry, the issue tracker is only to discuss bugs/issues in bootstrap, not for general help/how-tos. suggest using StackOverflow or similar. see https://github.com/twbs/bootstrap/blob/master/CONTRIBUTING.md#using-the-issue-tracker


r2d2::Error should derive PartialEq and Clone

Maybe there's a good reason not to do this, but in my use case, it would be very convenient if Error derived PartialEq and Clone. I'm wrapping r2d2::Error in my own Error type, which I would like to be able to derive PartialEq and Clone for. PartialEq, particularly in combination with Debug, is particularly useful in tests, where it allows you to assert_eq!(Err(...), result). Sure, you can assert!(...) with a custom message, but I think it's more ergonomic and produces better errors to use assert_eq!. And while adding code just to support tests isn't something you generally should do, in this case, I don't see it increasing maintenance burden at all.
It should just be as simple as adding PartialEq and Clone to the #[derive()] for r2d2::Error.
Any good reason not to add them? If not, I'm happy to raise the (tiny) PR making this change.

Very few error types in the ecosystem implement those traits. You'll probably have a hard time with that design more broadly.

Is that a good reason not to, though?
If you think it would harm the library in any way, then sure. But otherwise, with such a simple error type, I don't see any reason to restrict possible uses of it by not deriving.
And yes - wrapping generally isn't preferred. But sometimes it's a nice middle ground for internal code between properly embedding the contents of the error while adding context (like you ideally would in a library use case) and resorting to something like anyhow for application code.
Anyway, if you still disagree, feel free to close and I'll just extract the Option<String> from r2d2's error.

It prevents this error type from ever including something not Clone or not PartialEq.

Very true.
It occurred to me to check what serde does, and it doesn't implement PartialEq either. That led me to this issue with some relevant discussion: https://github.com/serde-rs/json/issues/271, with one of the downstream suggestions being to use assert_matches!. This is better for all parties - ergonomic tests, good errors, and no need to derive just for tests.
Closing this issue as not planned.


Translation-Docs » Operations Guides - 操作指南 » Access Control Lists (ACL)：What is an Access Control List?

finished


does this work for users who have domains as usernames and not bsky domains?

i keep getting this error - made list, had seven people, remove everything, and keep getting this. the only thing i can think it isnt working to convert a list to a starter pack is that i dont use bsky.app as my username

Assuming you closed it because you got it sorted? If not, share the link to the Starter Pack you're trying to populate. There are a few different formats for them and I think I got 'em all, but I may have missed one. I do see you have one SP in your account but I don't know if that's the new one converted from a list or not.

thanks got it sorted. had to refresh my browser the starter pack url wasnt updating properly,

Seems fixed. No need to input the hosting provider as apparently it gets automagically inferred from the bsky handle. I would only add a more elaborate success message – telling the user to check the list now created, printing its name perhaps.

bsky-core.php if you want to see how it works

I took a look, seems like a query is made to BS XRPC API for handle's DID and then DID is looked up in PLC Directory. I don't know BS API internals and whether there are use cases this wouldn't work, but my infosec intuition tells me there is a reason why most services expect this to be provided by the user. One example would be an attack on plc.directory that would result in yielding spoofed response in order to enable MITM attack (not saying this is feasible). Another would be in a situation in which PLC Directory would simply block responses regarding given PDS for any reason (censorship), making it more difficult to log in to our PDS this way (again, might be not feasible, as PLC might perhaps make our life harder in many more ways). What I would suggest considering is to add an input field for PDS and pre-populate (suggest) it with getPDS function after the handle is entered, but leave the final decision to the user. This might help the UX a little too, as user immediately would see the custom PDS is supported. But this is just me, maybe you decide to keep it as it is for now.


agent failing on ecr get-login

Especially in the morning, you may see: ERROR: denied: Your Authorization Token has expired. Please run 'aws ecr get-login' to fetch a new one. When this happens, it's an agent that has been running for more than a day.
Here are some excerpts from a build that had this happen. I modified it and removed parts so let me know if this is sufficient (removed any identifying characteristics of what this job is doing).
$ /etc/buildkite-agent/hooks/environment
Setting up the environment	1s
Sourcing CloudFormation environment...

Starting an SSH Agent...
Agent pid 3354

Running global pre-command hook	0s
$ /etc/buildkite-agent/hooks/pre-command
Running build script	1s
$ docker-compose -f docker-compose.yml down
docker-compose -f docker-compose.yml run our_command bash -c "command is here"
docker-compose -f docker-compose.yml down
Removing network daily_default
WARNING: Network daily_default not found.
Creating network "daily_default" with the default driver
Creating daily-server_1
Pulling container_name (container details)...
ERROR: denied: Your Authorization Token has expired. Please run 'aws ecr get-login' to fetch a new one.

Hi @micheletest sounds like something is going wrong with ECR authentication. Are you running a recent stack version with the ECRAccessPolicy parameter?

The auth token for ECR is 12 hours, which sounds like re-auth somehow isn't happening.

hi @lox I don't think we are setting the ECRAccessPolicy, which would explain this. I am out of the office, but can confirm if that fixes this early next week. Thanks for looking at this.

@micheletest alternately, set AWS_ECR_LOGIN=true in your env vars.

@lox Thanks - setting the AWS_ECR_LOGIN in your env vars worked.

Great! Updating to the latest stack should fix it too.
On Wed., 30 Nov. 2016 at 8:28 am, Michele Martone<EMAIL_ADDRESS>wrote:

@lox https://github.com/lox Thanks - setting the AWS_ECR_LOGIN in your
env vars worked.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/buildkite/elastic-ci-stack-for-aws/issues/178#issuecomment-263704561,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAA9jneyEN1UQosxSKjGfWs35MV25mLZks5rDJkCgaJpZM4K6rdQ
.

Urgh, this is a regression. Will fix.

Fixed in master.


Welcome Text Misalignment on Sign-Up Page

Issue Template
Description
The welcome text on the sign-up page is not aligned properly to the center, affecting the overall appearance of the page.
Steps to Reproduce

Go to the sign-up page of the note-taking website.
Observe the welcome text displayed.

Expected Behavior
The welcome text should be centered in the view.
Actual Behavior
The welcome text is misaligned and appears off-center.
Screenshots
![Welcome text alignment issue](

)
Additional Context
This issue affects the user experience on the sign-up page and should be addressed for a more polished look.

the 'welcome to scribbie' is put intentionally on the left side, not by mistake. so no need to fix it ;)


Customizer missing since last update (v3.0.12)

Issue description:
Since the last update, Customizer is missing. I am not sure if this is related but in the console, there's the  error: Uncaught ReferenceError: kirkiAllFonts is not defined

Version used:
3.0.12
Using theme_mods or options?
theme_mods
Code to reproduce the issue (config + field(s))
Customizer went perfectly fine with v3.0.11, I've developed the entire theme based on it. If I revert back all goes well.

I can't replicate this one...
Can you please try resetting your browser's cache?
Which WP version are you using?

my situation is same. i use  wordpress 4.8.3 and it is same on different browsers and incognito mod.

I'm still unable to replicate.
Does this happen with a specific theme?
Have you tried disabling other plugins to see if it's a conflict of some sort?
If you update your site to WP 4.9 does this still happen?

If one of you can tell me what to do to replicate this issue I'll be able to debug it...
If not then perhaps someone could send me some administration and FTP credentials on a site that has this issue so that I may debug it there.
Unfortunately without replicating the issue there's not much I can do.

I'd be happy to @aristath , please, let me know at which e-mail address can I send you the theme? So, to give you a bit info, this is a theme I personally developed under 3.0.11, so I know for sure it worked perfectly until 3.0.12.

@wowthemesnet thank for sending over your theme, I was able to replicate the issue with it.
Pushed a fix and now releasing version 3.0.13 with that bugfix. 👍

Aristeides, bravo, it works!
I am so happy to be able to release the theme now. I very much appreciate your work and thank you so much. Have a great day!
Best Regards,
Sal
http://www.wowthemes.net/ www.wowthemes.net
De la: Aristeides Stathopoulos<EMAIL_ADDRESS>Trimis: Thursday, November 9, 2017 2:13 AM
Către: aristath/kirki<EMAIL_ADDRESS>Cc: WowThemesNet<EMAIL_ADDRESS>Mention<EMAIL_ADDRESS>Subiect: Re: [aristath/kirki] Customizer missing since last update (v3.0.12) (#1612)
@wowthemesnet https://github.com/wowthemesnet  thank for sending over your theme, I was able to replicate the issue with it.
Pushed a fix and now releasing version 3.0.13 with that bugfix. 👍
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub https://github.com/aristath/kirki/issues/1612#issuecomment-343004863 , or mute the thread https://github.com/notifications/unsubscribe-auth/AFVrKHs3h5ys4SXTMWXpjX77ILVL_zNFks5s0kOVgaJpZM4QWRio .  https://github.com/notifications/beacon/AFVrKCg_LQlYk2HjUDh8yLLPwxG_ya-wks5s0kOVgaJpZM4QWRio.gif

I’m glad I could help :)
I’m pushing the 3.0.13 version on wordpress.org now, it should be online in a few minutes.
Good luck with your theme! I didn’t have time to take a good look at it because it’s 2am where I live right now, but I spent a couple of minutes with it and it looks pretty neat and organised.
Have a great day!

On 9 Nov 2017, at 02:15, WowThemesNet<EMAIL_ADDRESS>wrote:
Aristeides, bravo, it works!
I am so happy to be able to release the theme now. I very much appreciate your work and thank you so much. Have a great day!
Best Regards,
Sal
http://www.wowthemes.net/ www.wowthemes.net
De la: Aristeides Stathopoulos<EMAIL_ADDRESS>Trimis: Thursday, November 9, 2017 2:13 AM
Către: aristath/kirki<EMAIL_ADDRESS>Cc: WowThemesNet<EMAIL_ADDRESS>Mention<EMAIL_ADDRESS>Subiect: Re: [aristath/kirki] Customizer missing since last update (v3.0.12) (#1612)
@wowthemesnet https://github.com/wowthemesnet thank for sending over your theme, I was able to replicate the issue with it.
Pushed a fix and now releasing version 3.0.13 with that bugfix. 👍
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub https://github.com/aristath/kirki/issues/1612#issuecomment-343004863 , or mute the thread https://github.com/notifications/unsubscribe-auth/AFVrKHs3h5ys4SXTMWXpjX77ILVL_zNFks5s0kOVgaJpZM4QWRio . https://github.com/notifications/beacon/AFVrKCg_LQlYk2HjUDh8yLLPwxG_ya-wks5s0kOVgaJpZM4QWRio.gif
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub https://github.com/aristath/kirki/issues/1612#issuecomment-343005384, or mute the thread https://github.com/notifications/unsubscribe-auth/AAj7kI6VImU_LLtztlCB7N0XmNktEeajks5s0kQ6gaJpZM4QWRio.

I'm on the same timezone being from Romania, so I understand the effort:) Once again, thank you so much!

Same issue after updating to WordPress 4.9 and Kirki to 3.0.15.

@pasqualevitiello , I think @aristath is aware, I've tested the latest 3.0.16-dev and the issue is solved, so it will probably follow an update soon on .org.


Force Create

Add force: true option that can be used withaction: create to force a feature to be UPSERTEd on a duplicate key error.
This can only be used under the following condions

Explicitly enabled via auth config (disabled by default)
action: create is set (not allowed for modify, delete or restore)
a key: value is specified.

cc/ @mattficke @lukasmartinelli @mapbox/geocoding-gang

Closes: https://github.com/mapbox/Hecate/issues/77


config nodes don't get cleaned up

When you have deleted all the ssdp-discover nodes from  your flows and Deployed the flow, there is still config lying around which causes the same crash as in bug #1 when you're offline, even though there are no visible nodes in the flow.
I'm not sure whether removing the config after the last node has been removed, or whether the existence of config shouldn't be causing the library to attempt connections, but either way it's breaking node-RED :)

any progress on this? or has development stopped?


tiktok is now verifying the _signature parameter

The signing algo is buried under a lot of obfuscated javascript. In order for the module to work, it will be necessary to find the code responsible for creating the "_signature" value so that API calls respond with that.

If you are interested on an paid solution write me<EMAIL_ADDRESS>


flcbdfWrappers.os mis-installed

With host-arch, it installs to linux2/lib/python2.7/site-packages/$PETSC_ARCH/proteus/flcbdfWrappers.so, thus needs to be copied to linux2/lib/python2.7/site-packages/proteus/

believe this was fixed with more recent "arch" hashdist profiles that @tridelat was using. reopen if needed.


B-21375 I-13559 Calculated UB allowance when either dependents age group is 0 - MAIN

INT PR

Warnings

:warning:
This PR does not include changes to storybook, even though it affects component code.

  Generated by :no_entry_sign: dangerJS against b40c84dd1f3261edf004754bff68763b2a92ed65

This branch is being merged into main via this main PR: https://github.com/transcom/mymove/pull/14124


port: [#6354] isMatch adaptive expression returns error when value is null or empty string (#6426)

Fixes #4310
Description
This PR ports the changes in PR#6426 to fix the error in the isMatch built-in function when the value is null or an empty string.
Specific Changes

Updated the IsMatch built-in function to handle empty strings and null values by the evaluator.
Added 2 new unit tests for empty string and null values for the IsMatch function.

Testing
Here we can see the new unit tests passing after the changes.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

4 of 4 (100.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.006%) to 84.62%

Totals

Change from base Build<PHONE_NUMBER>:
0.006%

Covered Lines:
19922

Relevant Lines:
22305

💛  - Coveralls


Facebook login - required fields

Hey,
I run into an issue with the AuthenticateFacebookAsync.
After receiving the FB token the Server tries to do the request to fetch the user data.
With this request it sends some extra fields.
I did not find any place where we need this information gender,locale,timezone.
https://github.com/heroiclabs/nakama/blob/4b92d9fb24cd281bf6de00e0c1d3ab82f22029ba/social/social.go#L198
The problem is that those fields are not active by default:

I tried to create a new app and clicked on the "Develop a game or connect with one".
But those apps don't have the "gender,locale,timezone" fields set.
The workaround was to create a "Develop linked functions"-App.

To avoid such an error in the future could you remove the fields if they are not required or could you add some extra information to the documentation about the FB authentication?
Thank you

@OtterBlitzStudio Thanks for the detailed report. I think we should just remove those fields from the request we send to fetch the user profile with Facebook. I think there's probably been an API change in the Facebook graph which makes it problematic to request those fields. Do you want to open a pull request? 😄

I could do it, but:

I haven't cloned the repo until now. It should not be so hard, but I'm not a go developer ^.^

Maybe there could be some side effects. I guess the complete line could be deleted and then the documentation needs some changes:
var perms = new List(){"public_profile", "email"}; (https://heroiclabs.com/docs/authentication/#facebook)

To test all of this requires some time, so I think it should be faster if you do it by yourself.
Otherwise, I could check it at the weekend. :P

Fixed in https://github.com/heroiclabs/nakama/commit/dd51571d2194529fef2eb9355732dacf7d6eac7e and will be part of the next release.


multi-arch-build for piraeus-server

The need for this change has been discussed in piraeusdatastore/piraeus#74
Please note that this is basically copy+paste from #84

Thanks!


Fix error reporting for invalid addresses

Suppress emitting E_WARNING and test promise is successfully rejected.
This PR builds on top of #46, so the diff also includes its changes. Look here for changes only related to this PR alone. (no longer applies after rebasing)

I've just rebased this on the current master now that #46 is in.
Ready for review :)

LGTM :shipit:


Improve callback code structure

Codecov Report

Merging #84 (0f1530c) into main (0a4d5f9) will increase coverage by 0.00%.
The diff coverage is 95.00%.

@@           Coverage Diff           @@
##             main      #84   +/-   ##
=======================================
  Coverage   92.45%   92.45%
=======================================
  Files          25       25
  Lines         967      968    +1
=======================================
+ Hits          894      895    +1
  Misses         73       73

Impacted Files
Coverage Δ

src/callbacks.jl
95.23% <95.00%> (+0.23%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0a4d5f9...0f1530c. Read the comment docs.


feature/validation

fixes #2019
Note to reviewers: I used that PR to improve nullable checks, and align some bracketing to get us in a more consistent place and ready to enable nullable. I suggest you check the ignore whitespace option in your diff.

Note: missing changelog


router.errorView is not effected when a router was created by calling  router.NewGroupPath()

Easy fix
diff --git a/router.go b/router.go
index 9b5c5e3..e7550d4 100644
--- a/router.go
+++ b/router.go
@@ -38,6 +38,7 @@ func (r *Router) NewGroupPath(path string) *Router {
 	g.router = r.router.Group(path)
 	g.parent = r
 	g.beginPath = path
+	g.errorView = r.errorView

 	return g
 }

I will have the pleasure to accept your PR if you want :)
If not that's it, I will fix it.


toml_edit::easy formatting differences from toml-rs

I tried using toml_edit::easy on one of my projects since it sounds like it will be the future according to https://github.com/toml-rs/toml/issues/340 and noticed that table like fields are treated differently in toml_edit::easy:
I'm wondering if this is this an intentional change or something that might be fixed before the migration? If intentional, could we add a way to configure it to use the old style?
I find the old style to be more readable, uses less characters, and less error prone when editing (don't have to worry about matching brackets as much etc.).
toml_edit::easy::to_string
name = "Test"
metadata = { hair_color = "brown", "dog's name" = "Frodo" }
addresses = [{ id = 0, name = "Home", street = "123 Baker ST" }, { id = 1, name = "Office", street = "124 Baker ST" }]

toml::to_string
name = "Test"

[metadata]
hair_color = "brown"
"dog's name" = "Frodo"

[[addresses]]
id = 0
name = "Home"
street = "123 Baker ST"

[[addresses]]
id = 1
name = "Office"
street = "124 Baker ST"

Code used for this
use serde::Serialize;
use std::collections::HashMap;

#[derive(Serialize)]
pub struct Address {
    id: usize,
    name: String,
    street: String,
}

#[derive(Serialize)]
pub struct Person {
    name: String,
    metadata: HashMap<String, String>,
    addresses: Vec<Address>,
}

fn main() {
    let mut hm = HashMap::new();
    hm.insert("dog's name".into(), "Frodo".into());
    hm.insert("hair_color".into(), "brown".into());
    let person = Person {
        name: "Test".to_string(),
        metadata: hm,
        addresses: vec![
            Address {
                id: 0,
                name: "Home".to_string(),
                street: "123 Baker ST".to_string(),
            },
            Address {
                id: 1,
                name: "Office".to_string(),
                street: "124 Baker ST".to_string(),
            },
        ],
    };

    println!("{}", toml::to_string(&person).unwrap());
    println!("---");
    println!("{}", toml_edit::easy::to_string(&person).unwrap());
}

Note that going from toml::to_string to toml_edit::easy::to_string did fix a bug I was running into (I think it was similar to https://github.com/toml-rs/toml-rs/issues/475) so I appreciate the effort to consolidate things for consistency, and I can see how that will benefit going forward. I hope this issue doesn't sound negative towards that. Thanks!

Looks like to_string_pretty does what I was looking for, similar to to_string_pretty in serde_json. Makes sense and works great 👍.
Might be a good thing to note in a migration guide or something when toml-rs gets migrated to use toml_edit.


Add support for specifying dependant plugins for plugin builds

I saw that someone on the Unreal Source Discord wanted to build a plugin that depends on other plugins. While it isn't valid to build a plugin like this for Fab (you can't have external/non-engine plugin dependencies for code plugins), it's perfectly fine if you want to distribute plugin binaries on e.g. GitHub.
It seems reasonable for UET to support this. I think a rough outline of the work probably looks like:

[ ] BuildGraph XML: Add -BuildDependantPlugins to compile steps when building a plugin with dependencies.
[ ] BuildGraph XML: The "Assemble Host Project" needs to perform the plugin copy steps not just from $(PluginDirectory), but the additional plugin directories as well, with each plugin getting it's own $(ShortPluginName). Maybe we can just give additional plugins a short name of P1, P2, ...? Depends on whether BuildGraph for loops will allow me to do that.
[ ] BuildGraph XML/Prepare Step: Figure out where we're going to clone the additional plugin repositories, since those paths will have be what $(PluginDirectory) is replaced with when copying out the additional plugins. Thankfully PluginDirectory is already a subdirectory of the main repository (usually __REPOSITORY_ROOT__/(plugin name)), so maybe we can just clone into __REPOSITORY_ROOT__/.uet/ExtraPlugins or something like that. If this is a consistent path, we might be able to just have an e.g. ExtraPluginsDirectory and set our host project tagging to do a filter of e.g. */Config/...; to just grab all the content from all the plugins without a foreach loop in the BuildGraph XML?
[ ] BuildGraph XML: Figure out what to do with Assemble Test Project. This isn't needed for "build only" paths, but it is necessary the moment you want to run any tests. Maybe we just don't support running tests for these kinds of plugin-depending-on-plugin situations for now?
[ ] Prepare Step: Actually add the "prepare download plugin" step. This is mostly copying the one that already exists for projects and adapting it for the new paths.
[ ] Can we add a parameter to uet build that lets you specify dependent plugins without having to use BuildConfig.json? It might be unwieldy though due to the interpolation support and number of parameters that plugin source specs actually need.

Oh this is actually a duplicate of #31. I'll keep this one open though because it has the list of tasks that need to be undertaken to complete the work.


Weave on a RaspberryPi

Hi,
I just want to share with the Weave team some research (like #466) I've done in order to use Weave with Raspberry Pi which is, I think, something that could be cool for IoT.
It was not easy for me and I've write the process to make it work on medium.
Feel free to close this issue as soon as you read it if you think it's useless.
Thanks !

Glad you got it working in the end, and thanks for publishing the instructions. @errordeveloper @fintanr may want to take a closer look and perhaps find ways to simplify the process.

@guillaumewuip we certainly do see how Weave may be used as a fundamental building block for connecting devices to the cloud, potentially allowing for cool usecases with microservices distributed all the across etc.
Firstly, I can see that you are using a older revision of weave script, as a workaround #466... There is now a different better way of doing this, you can just grab the weave script from master branch and use with --local flag, which will eliminate the need for that tools container image. The only thing to keep in mind is that you will need to have ip, iptables, curl and ethtools installed on the the RPi.
Secondly, there are a few approaches that you have gone through, and I understand that it's something you feel like sharing, however it's not making things easy for the reader. My best recommendation would be to leave only a single method, whichever is the simplest one. If you really wish discuss the uncertainties with your audience, you could probably drop those down into comments section, keeping main article short.

Hi @errordeveloper, thanks for you reply.
I've actually just switched project so I won't test the new weave script these days. But I keep this in mind and hope I can try your solution soon.
Thank you also for you feedback about my post. I'll refactor it as soon as I've tested the new weave script.

Hi, @guillaumewuip I'm also interested in this. Do you have any update on this?

Hi @xiamx. Actually I haven't use weave since this try with RaspberryPi. So no, there is nothing new from me.

Another user has managed to get it working, let me check with them and I will let you know.

Hi @xiamx.  I was able to get weave working on Pi.  Here are the steps I took:

Fresh Hypriot/Jessie (that's a 0.5 release), log in
apt-get update && apt-get upgrade
echo "deb http://mirrordirector.raspbian.org/raspbian/ stretch main contrib non-free rpi" >> /etc/apt/sources.list
apt-get update && apt-get dist-upgrade
apt-get install golang build-essential ethtool iputils-arping libpcap-dev git mercurial bc
Run this script:
export GOPATH=~/gopath
mkdir $GOPATH
cd $GOPATH
go clean -i net
go install -tags netgo std
mkdir -p src/github.com/weaveworks
cd src/github.com/weaveworks
git clone https://github.com/weaveworks/weave
cd weave
git checkout 1.0
make
Note that the build fails with this near the end:
Status: Downloaded newer image for gliderlabs/alpine:latest
---> 5bd56d818842
Step 1 : MAINTAINER Weaveworks Inc<EMAIL_ADDRESS>---> Running in 03dc69c10b66
---> a8da1b2070df
Removing intermediate container 03dc69c10b66
Step 2 : RUN apk add --update     curl     ethtool     iptables     iproute2     util-linux     conntrack-tools   && rm -rf /var/cache/apk/*
---> Running in 0b102983d17c
exec format error
[8] System error: exec format error
Makefile:78: recipe for target 'weaveexec.tar' failed
make: *** [weaveexec.tar] Error 1

This is because part of the weave build system currently assumes that it is x86 and depends on an x86 image pulled from the docker registry.
Because of the mentioned build error, "Docker API proxy" will not function.
All weave commands must use '--local' as the first parameter.

If desired, inspect resulting container images (there may be additional
container images, these are the important ones):
root@rpi-2 ~/gopath/src/github.com/weaveworks/weave # docker images
REPOSITORY             TAG                 IMAGE ID            CREATED             VIRTUAL SIZE
weaveworks/weavedns    latest              7b18be319930        About an hour ago   8.426 MB
weaveworks/weave       latest              3611cdc94cfd        About an hour ago   11.65 MB
Install weave executable:
cp weave /usr/local/bin/
chmod +x /usr/local/bin/weave

From here I was able to run weave commands, but always remember to add --local.

@cbrown9871 thank you very much for the instructions!!
@xiamx @guillaumewuip please let me know if this works for you.

@cbrown9871 thank for your solution, it looks way better than mine :+1:
@errordeveloper sry, I can't test this these days as I'm more than busy

@cbrown9871 Thanks for posting this. I previously arrived to step 7, but thought that weave was unusable without that image. Glad to know that it will work just fine

the alpine linux used by gliderlabs/alpine also has a rpi build according to http://alpinelinux.org/downloads/ It would be interesting to see that image ported to rpi.

Hi @guillaumewuip , I have build weave RPi image, philipz/weave, etc...But, weavedns isn't work. I still try to fix it.
https://github.com/philipz/weave

Let's ping @progrium regarding Alpine images for the RPi, and see if he has
looked into that.
On Mon, 7 Sep 2015 13:44 philipz<EMAIL_ADDRESS>wrote:

Hi @guillaumewuip https://github.com/guillaumewuip , I have build weave
RPi image, philipz/weave, etc...But, weavedns isn't work. I still try to
fix it.
https://github.com/philipz/weave
—
Reply to this email directly or view it on GitHub
https://github.com/weaveworks/weave/issues/495#issuecomment-138277245.

Looping in @andyshinn to see how hard it would be to add support for ARM based Alpine image, perhaps as a tag (:3.2-arm, :latest-arm?). Not sure if we need to use Raspberry Pi specific build or if we can use the generic ARM build...

@errordeveloper , @progrium. The ARM based Alpine image, I use armbuild/alpine.
https://hub.docker.com/r/armbuild/alpine/
The weavedns code in master branch is remove and merge to weaveexec. So, it's work now only on RPi2.

Go ahead and opena n issue at gliderlabs/docker-alpine if there is a need or want for ARM Alpine Docker images. Though, I've been directing people to the armbuild/alpine image for those who have asked. Scaleway bases their images off the armbuild/alpine image as well

Hi all, I have build v1.1.0 for RPi ARMv6 & RPi2 ARMv7 image both. Just like official method. :)
sudo curl -L git.io/rpi_weave -o /usr/local/bin/weave
sudo chmod a+x /usr/local/bin/weave


[Bug Report] Stuck in the middle

Describe the bug
The application gets stuck in the middle of the output
Expected behavior
The app should print and exit
Screenshots

Desktop (please complete the following information):

OS: EndeavourOS (x86_64)
Terminal: Konsole
Desktop: KDE (Wayland)
Kernel: 6.10.10-arch1-1
Shell: bash

Possibly relevant config lines:

Default

Additional context
Installed from AUR - albafetch-bin (https://aur.archlinux.org/packages/albafetch-bin)

Huh
for some reason it gets stuck trying to count the installed packages
would you mind trying to disable pkg_snap pkg_flatpak and pkg_pacman one by one and see which one is causing the issue?
You can check /etc/xdg/albafetch.conf for a reference syntax, not sure if the changes will actually be read if you change any settings from that file, pretty sure that's only on -git (actually, I'm not even sure if I implemented that in git or you still have to copy it to your home dir. Should probably check)

I haven't tested the changes you proposed (I can test them later), but I saw here that the application isn't freezing, it just takes a long time to run (more than 2 minutes!)
Maybe this option should be disabled by default!
Thanks.

It should totally not take that long, especially if it's just pacman. Could you please tell me what you get as installed packages? pip takes a long time to run, which is why I have disabled it by default

What is taking two minutes though? it can't be pacman, maybe flatpak or snap?

What is taking two minutes though? it can't be pacman, maybe flatpak or snap?

I think it's pacman that's taking too long! I'm using EndeavourOS live and I don't have any flatpak or snap installed! I also didn't install anything using pip!

If you want, I can test here on my PC how long it takes to extract the number of installed packages...
Let me know if I can help with anything. If you send me a debug build, I can try running it here and send you the result!
Thanks

albafetch basically counts the number of subdirectories inside of /var/lib/pacman/local, basically just like ls /var/lib/pacman/local | wc -l (subtracting 2 because of . and .. being counted too)
You can do that with pacman too using pacman -Qq | wc -l
You can get a debug build by cloning this repository and running make debug inside of it

I run this commands and both are very fast in my PC:
**time ls /var/lib/pacman/local | wc -l**
_3560

real    0m0,011s
user    0m0,006s
sys     0m0,008s_

**time pacman -Qq | wc -l**
_3559

real    0m0,028s
user    0m0,018s
sys     0m0,032s_

Later I can test the debug version and share the results!
Thanks

Debug (--no-pip):

Debug:

Tried to look into this.
No idea what the culprit is. I even tried going through it with chatgpt (which I usually barely use) out of desperation and yeah it was doing the same stuff I was doing.
This is the code in question, or at least so I think. If you're comfortable with coding in C try to put some printfs in ./src/info/packages.c and try to find out what part is taking this long.
if(_pkg_pacman && (dir = opendir(path)) != NULL) {
            while((entry = readdir(dir)) != NULL)
                if(entry->d_type == DT_DIR && strcmp(entry->d_name, ".") != 0 && strcmp(entry->d_name, "..") != 0)
                    ++count;
            closedir(dir);

            if(count) {
                snprintf(dest, 255 - strlen(buf), "%s%u%s", done ? ", " : "", count, _pkg_mgr ? " (pacman)" : "");
                done = true;
            }
        }

Yeah, no clue, I wonder if pacman really is the part that's taking long, or if it could be something outside of packages

I found where the problem is!
This command takes forever to run on my PC:
$ time snap list
error: cannot list snaps: cannot communicate with server: Get "http://localhost/v2/snaps": dial unix /run/snapd.socket: connect: no such file or directory

real    2m0,014s
user    0m0,153s
sys     0m0,118s

I will try to fix my snap installation and try again!
Thanks for the help!

My 'snapd' service was not running and this caused the slow down of the application!
Maybe you should check first if snapd is active before quering about installed snaps!
Thanks and sorry for the bug! The problem was only on my machine!

Oh great, so my hypothesis was correct
I'll likely look for a way to list snap packages without executing a command to begin with

@Dominiquini can you please check albafetch-git and see if the situation improved after https://github.com/alba4k/albafetch/commit/4a857750fc10e675c83a79c40c27df5bd2446d44?
121029 ms should now be no more than 2 ms lol

I checked the last version from git and the problem was resolved, even after I stopped the snapd service!
Thanks.


rocmPackages: 5.7.0 -> 5.7.1

Description of changes
Tracking: #197885
Update the ROCm packages.
Change rocmUpdateScript to use releases/latest by default.
Preliminary support for config.rocmSupport - an analogue to config.cudaSupport.
resolves #261546, resolves #261551, resolves #261558, resolves #261561, resolves #261566, resolves #261575, resolves #261587, resolves #261592

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

The gentoo guys are/were talking about replacing rocprofiler with radeon_compute_profiler, which apparently has deprecated rocprofiler, despite rocprofiler having more recent commits.

Kicked off builds

Wondering whether this update fixed the flang build failures we were seeing in 5.7.0

Removing the config commit.
This is too big of an issue that needs more discussion before putting it into a PR.


Allow formulae to prevent optimization level stripping

[x] Have you followed the guidelines in our Contributing document?
[x] Have you checked to ensure there aren't other open Pull Requests for the same change?
[x] Have you added an explanation of what your changes do and why you'd like us to include them?
[ ] Have you written new tests for your changes? Here's an example.

[x] Have you successfully run brew typecheck with your changes locally?
[x] Have you successfully run brew tests with your changes locally?

Some upstream build systems require finer control over the optimisation
level. For example, libgcrypt sets -O0 when building its
jitter-based entropy collector (jent), but -O2 otherwise.
This allows formulae to set ENV.permit_optimization_level in the
install method to prevent the stripping of -O[0-9zs] flags. In particular,
it will allow us to build libgcrypt with the jitter-based entropy collector
which, as far as I can tell, is a valuable additional source of entropy. (Not
an expert though. But I assume there's a good reason upstream build this
unless you explicitly disable it.)
While we're here, clean up an old comment referencing ENV.libstdcxx.

Review period will end on 2021-04-21 at 22:33:15 UTC.

I'll admit that I'm not sure how I feel about making these changes to superenv for one formula. On the other hand, it's an important formula, and has security-relevant consequences.

What happens with the status quo? Does it fail to build? Does it fail to build the relevant component? Can we make use of the existing ENV.Ox methods to do any of this?

With the status quo, we need to disable the jent module. The formula does this by passing --disable-jent-support to configure. Without this flag, libgcrypt will fail to build with the error message
./jitterentropy-base.c:60:4: error: "The CPU Jitter random number generator must not be compiled with optimizations. Use the compiler switch -O0"

We can build the jent module without making any changes to superenv by using ENV.O0 in the install method. This was previously entertained and rejected. See https://github.com/Homebrew/homebrew-core/pull/15750.
So our alternatives to not making this change are:

Not building the jent module, which leaves libgcrypt without an entropy source that the libgcrypt developers find useful enough to add by default;
Build all of libgcrypt with ENV.O0; or,
Find a way to build the jent module separately from the rest of libgcrypt so that ENV.O0 can be used.

I don't think either of 1 or 2 are good options. I've looked into the third, and I'm not sure it's possible. It likely involves patching to the build system that I am sceptical we would be able to upstream (which would also make it a not good option).
Making changes to superenv seems to me like it would be the least bad option here.
However, I will keep looking into option 3. It might be better than my initial impression suggests it is.

Not building the jent module, which leaves libgcrypt without an entropy source that the libgcrypt developers find useful enough to add by default;

This is the current default/status quo, right?

3. Find a way to build the jent module separately from the rest of libgcrypt so that ENV.O0 can be used.
I don't think either of 1 or 2 are good options. I've looked into the third, and I'm not sure it's possible. It likely involves patching to the build system that I am sceptical we would be able to upstream (which would also make it a not good option).

This seems ideal to me if possible.

Making changes to superenv seems to me like it would be the least bad option here.

I'm the opposite. I hate patching software in Homebrew but I think it's preferable rather than introducing a new DSL and the relevant superenv logic for a single formula, particularly considering the current status quo doesn't seem too awful.

Not building the jent module, which leaves libgcrypt without an entropy source that the libgcrypt developers find useful enough to add by default;

This is the current default/status quo, right?

It's what the formula does currently, but it's not the default build configuration. We need to pass --disable-jent-support to disable it.

Find a way to build the jent module separately from the rest of libgcrypt so that ENV.O0 can be used.
I don't think either of 1 or 2 are good options. I've looked into the third, and I'm not sure it's possible. It likely involves patching to the build system that I am sceptical we would be able to upstream (which would also make it a not good option).

This seems ideal to me if possible.

Ok, will look into this some more then.

I had forgotten the fourth option, which I did contemplate (but don't remember why I didn't pursue it): make superenv smarter about handling -O flags.
This will avoid the need for:

a special DSL for a single formula; and/or,
patches to libgcrypt.

I think I can make it a change I'd feel good about. Will work on a PR.
Thanks for the motivation here, Mike.

I had forgotten the fourth option, which I did contemplate (but don't remember why I didn't pursue it): make superenv smarter about handling -O flags.

@carlocab To save you some work: mind pitching it here and we can discuss it?

Just to explain my radio silence here: your last comment read a little like (completely warranted) scepticism to me, so I started second-guessing myself. Taking the time to mull over a proper solution here. Will be back with one in the next few days.

Review period ended.


Explore button in Problems view giving 404

Describe the bug
When I click the explore button I get Grafana 404 problem
Expected behavior
Goes to explore view as implemented in here: #948
Screenshots

Extra info why problem appears
I checked the URL when manually going to explore page and it includes org_id, like so explore?orgId=1&left= the URL from explore button does not and when I add the org_id info to it, then it works fine. It seems to just miss that part. I guess it is change since Grafana 8.0.0 to require org_id in URL, even when only 1 org is used.
Software versions

Grafana
Zabbix
Grafana-Zabbix Plugin

8.0.4
5.0.11
4.1.5

Подтверждаю, та же проблема


[e2e]: container-based schedule main gcp-workload-identity slsa3

Repo: https://github.com/slsa-framework/example-package/tree/main
Run: https://github.com/slsa-framework/example-package/actions/runs/7649312083
Workflow file: https://github.com/slsa-framework/example-package/tree/main/.github/workflows/e2e.container-based.schedule.main.gcp-workload-identity.slsa3.yml
Workflow runs: https://github.com/slsa-framework/example-package/actions/workflows/e2e.container-based.schedule.main.gcp-workload-identity.slsa3.yml
Trigger: schedule
Branch: main
Date: Thu Jan 25 03:07:44 UTC 2024

Repo: https://github.com/slsa-framework/example-package/tree/main
Run: https://github.com/slsa-framework/example-package/actions/runs/7663444914
Workflow file: https://github.com/slsa-framework/example-package/tree/main/.github/workflows/e2e.container-based.schedule.main.gcp-workload-identity.slsa3.yml
Workflow runs: https://github.com/slsa-framework/example-package/actions/workflows/e2e.container-based.schedule.main.gcp-workload-identity.slsa3.yml
Trigger: schedule
Branch: main
Date: Fri Jan 26 03:11:53 UTC 2024
Tests are passing now. Closing this issue.


Longitude in AgContext editor produces '>= 0 error' if negative value

Only found this now that I'm uploading North American datasets, but negative longitudinal values produce an error in the AgContext editor, though negative latitude are.

Even though you can set the form, it looks like it won't accept negative values and move onto the next part of the upload process.

This was an error in the schema, which should be resolved by https://github.com/Sydney-Informatics-Hub/Weed-AI/pull/549


Nvidia Cuda docs and best practices articles lead to no where

new links which work
CUDA C Best Practices Guide : https://docs.nvidia.com/cuda/cuda-c-programming-guide
CUDA C Programming guide : https://docs.nvidia.com/cuda/cuda-c-programming-guide

Hello! @k10231 . I request you to please add the file names from the next time onwards so that it is easy for anyone to fix the issue.

@k10231, please note that the links which you have provided are for different resources. Your links go to resources in C++ regarding the same subject. We can add this as a new resource I think.


Update NodeJS getting started following all the breaking changes in v0.3.0

What is the issue?
Since now we split required args and optional args, we need to update the code in the documentation. Other breaking changes might have to update the documentation as well.
Tasks

[ ] update host.workdir() part with new API

cc @vikram-dagger : we talked about this today. You can close this issue when it's up to date with v0.3.0 (got released a few minutes ago)

It seems like the get started snippets are already up to date @dolanor. Was there a specific issue you found which requires changes?

No, as I said, I created before we talked together and you released an update. It now should be good.


Add more telecomms variations

About the PR

for mappers
Why / Balance

Technical details

Media

[ ] I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Breaking changes

Changelog

no fun

Test failure real.

What does this PR do? The title and description aren't clear

What does this PR do? The title and description aren't clear

bruh, just check the code part


Getting error prompt when displaying adaptive card with media using link to SharePoint in Bot Framework Composer

Describe the bug
Getting error prompt when using adaptive card with media using link to SharePoint for video and same link in button in Bot Framework Composer. The output is displayed fine in PVA. But for some reason when I test the bot in emulator it keeps giving me error "Something went wrong..." not sure if there is something failing or just something I need to avoid by pressing ok.
V2.0.0
Version:  2.0.0
Electron: 8.2.4
Chrome: 80.0.3987.165
NodeJS: 12.13.0
V8: 8.0.426.27-electron.0
Browser

[ ] Electron distribution
[ ] Chrome
[ ] Safari
[ ] Firefox
[x] Edge

OS

[ ] macOS
[x] Windows
[ ] Ubuntu

To Reproduce
Steps to reproduce the behavior:
Add Adaptive card with this code :
- ```{
    "$schema": "http://adaptivecards.io/schemas/adaptive-card.json",
    "type": "AdaptiveCard",
    "version": "1.2",
    "fallbackText": "This card requires Media to be viewed. Ask your platform to update to Adaptive Cards v1.1 for this and more!",
    "body": [
        {
            "type": "Media",
            "poster": "https://sites.ey.com/sites***.png",
            "sources": [
                {
                    "mimeType": "video/mp4",
                    "url": "https://sites.ey.com/sites/***.mp4"
                }
            ],
            "horizontalAlignment": "Center",
            "spacing": "Small"
        },
        {
            "type": "ActionSet",
            "actions": [
                {
                    "type": "Action.OpenUrl",
                    "title": "Open in Internet Explorer",
                    "url": "https://sites.ey.com/sites/***.mp4",
                    "style": "positive"
                }
            ],
            "horizontalAlignment": "Center",
            "spacing": "Small"
        }
    ],
    "backgroundImage": {
        "horizontalAlignment": "Center"
    }
}```

Expected behavior
Expecting a video as we do in any normal video adaptive card.
Screenshots

Additional context
please let me know in case of any more details needed.

Hi @mukeshOps I'm assuming this is due to the issue specified here: https://github.com/microsoft/BotFramework-Composer/issues/6128
I'm also assuming that the video file url does not need/use any sort of authentication, correct?
I'll do some further testing and see if I can confirm the above for that linked bug.

Can confirm I can can reproduce. Will share when I have more information.

Thx. I think I have one more issue to report but more of problem inside PVA. I will raise separately. Thank You for looking into it.

@garypretty Another issue related to codec support in the electron flavor we are using.

Further clarification; I tested in Webchat/TestinWebchat and that works. So, it is for sure the electron flavor.

Closing as the issue is being tracked in #6128.
This is a known issue for Emulator and Composer WebChat. You can use WebChat or other channels (assuming specific channel supports video in cards).


Refactor the 'EmbeddingPreview' UI component to support multiple views of the embedding

Background
Link to issue
https://biomage.atlassian.net/browse/BIOMAGE-470
Link to staging deployment URL
https://ui-scemtqcwy5xrmxw94mkxw6orsc.scp-staging.biomage.net/
Links to any Pull Requests related to this
N/A
Anything else the reviewers should know about the changes here
The wireframes Vicky posted had an error, as inversion is only an option for the continuous embedding, not the categorical. I assumed it was a mistake, so I fixed it accordingly. It is not possible to invert colors easily via a continuous embedding using the schema we have.
Changes
Code changes
We used the code base for the existing continuous/categorical embedding schema in Plots and Tables to design the embedding. I reused the components from those components.
Definition of DONE
Your changes will be ready for merging after each of the steps below have been completed:
Testing

[ ] Unit tests written
[x] Tested locally with Inframock
[x] Deployed to staging

To set up easy local testing with inframock, follow the instructions here: https://github.com/biomage-ltd/inframock
To deploy to the staging environment, follow the instructions here: https://github.com/biomage-ltd/biomage-utils
Documentation updates
Is all relevant documentation updated to reflect the proposed changes in this PR?

[x] Relevant Github READMEs updated
[x] Relevant wiki pages created/updated

Approvers

[ ] Approved by a member of the core engineering team
[ ] (UX changes) Approved by @vickymorrison

Just before merging:

[ ] After the PR is approved, the unstage script in here: https://github.com/biomage-ltd/biomage-utils is executed. This script cleans up your deployment to staging

Optional

[x] Photo of a cute animal attached to this PR

I don't understand the comment about colour inversion - it is an option in the categorical embedding in Plots and Tables.

I don't understand the comment about colour inversion - it is an option in the categorical embedding in Plots and Tables.

This is a super weird thing - when I open the link in staging and go to configure embedding, when I click between the 4 views, the colours of the cell sets change at some point. See the video:
https://user-images.githubusercontent.com/65414651/106112587-bc08c700-614d-11eb-8303-c400608436c8.mov
Just to confirm -- this is happening because we haven't connected the view with real cell sets data?

This is a super weird thing - when I open the link in staging and go to configure embedding, when I click between the 4 views, the colours of the cell sets change at some point. See the video:
https://user-images.githubusercontent.com/65414651/106112587-bc08c700-614d-11eb-8303-c400608436c8.mov
Just to confirm -- this is happening because we haven't connected the view with real cell sets data?

This is a super weird thing - when I open the link in staging and go to configure embedding, when I click between the 4 views, the colours of the cell sets change at some point. See the video:
Screen.Recording.2021-01-28.at.09.46.28.mov
Just to confirm -- this is happening because we haven't connected the view with real cell sets data?

Correct. This happens because the system right now generates new colors each time the config changes. This will not be the case once the system fetches data from Redux, for now it was the easiest thing to do.

This is a super weird thing - when I open the link in staging and go to configure embedding, when I click between the 4 views, the colours of the cell sets change at some point. See the video:
Screen.Recording.2021-01-28.at.09.46.28.mov
Just to confirm -- this is happening because we haven't connected the view with real cell sets data?

Correct. This happens because the system right now generates new colors each time the config changes. This will not be the case once the system fetches data from Redux, for now it was the easiest thing to do.

I don't understand the comment about colour inversion - it is an option in the categorical embedding in Plots and Tables.

Fair point. I think there is a bug in the way I generate colors right now that somehow messes with the inversion, as it also changes the colors of the clusters and not just the axes. The same issue does not appear in the categorical plot in plots and tables.
Either way, the feature is added.

I don't understand the comment about colour inversion - it is an option in the categorical embedding in Plots and Tables.

Fair point. I think there is a bug in the way I generate colors right now that somehow messes with the inversion, as it also changes the colors of the clusters and not just the axes. The same issue does not appear in the categorical plot in plots and tables.
Either way, the feature is added.


ci: update pnpm/action-setup to v3 for node-20 changes

pnpm/action-setup has been updated to v3 which now uses node-20 actions as node-16 actions are deprecated.

As a side commit, I have limited the CI to run on master branch only as I have noticed 2 checks run on branches you work on in this repo, it is a waste of computing power.
Again, I included it in this commit because I already have enough PRs open


Some Grammatical errors in Issue and PR Template

This issue is about Error in Issue and PR Templates.

[x] I searched or browsed the repo’s other issues to ensure this is not a duplicate.
[x] This issue is for enhancement/bug fixing.
[ ] This issue is an addition to JSON database.
[x] I have gone through Contribution Guidelines.
[x] Assign this issue to me.

Which errors are you referring in particular ?

@Anshuman-Verma Assign me


fixes to the priority queue, and a new method pqShift

this allows for the PeekAndShift pattern.
https://gist.github.com/mikedewar/2ddbef88e8e2363176c9

ping! This one passes checks now.

:fire: :fire_engine:


Add JavaScript Solution

#4 Added javascript solution and create a pull request. Please review it.

#4 Added javascript solution and create a pull request. Please review it.

Linked the issue to the PR


Set blocked state if CA is missing

I took a same approach as  etcd charm and added check for missing certificates.available flag.
I have the same thing prepared for the kubernetes-worker, but I'm gonna open this PR first to hammer out any possible issues.
LP: https://bugs.launchpad.net/charm-kubernetes-master/+bug/1868541

LGTM. Should a unit test be created for the fixed use case (where certificates.available is missing)?

LGTM. Should a unit test be created for the fixed use case (where certificates.available is missing)?

+1 from me for kubernetes-master.

+1 from me for kubernetes-master.


Add Darwin as a supported platform type for #if os

LGTM

This is an Apple platform owner concern, so I've reached out to the appropriate people at Apple, and it's being pre-reviewed. I'll update this PR with the results of that conversation.

This is an Apple platform owner concern, so I've reached out to the appropriate people at Apple, and it's being pre-reviewed. I'll update this PR with the results of that conversation.

Hi, I had a moment and was revisiting some of the old proposals I made to try to get them across the finish line. Do you happen to recall what the results of this discussion were?

Hi @SerenaKit, there is an ongoing conversation over on the Swift Forums based on the internal discussions at Apple.