feat(FX-3274): fallback name for saved search alert without name

The type of this PR is: Feature

This PR resolves FX-3274
Description

PR Checklist (tick all before merging)

[x] I have included screenshots or videos to illustrate my changes, or I have not changed anything that impacts the UI.
[x] I have tested my changes on iOS and Android.
[x] I have added tests for my changes, or my changes don't require testing, or I have included a link to a separate Jira ticket covering the tests.
[x] I have added a feature flag, or my changes don't require a feature flag. (How do I add one?)
[x] I have documented any follow-up work that this PR will require, or it does not require any.
[x] I have added an app state migration, or my changes do not require one. (What are migrations?)
[x] I have added a changelog entry below or my changes do not require one.

Changelog updates
Changelog updates

Cross-platform user-facing changes

Display fallback name for saved search alert without name - dimatretyak

iOS user-facing changes

Android user-facing changes

Dev changes

This PR contains the following changes:

Cross-platform user-facing changes (Display fallback name for saved search alert without name - dimatretyak)

  Generated by :no_entry_sign: dangerJS against 748a75f232222ed03198208b5f094c7196e02b63


Drop recently-pushed-branches-enhancements

I'm tired of having to rewrite this every few months because of class changes. Maybe we should just drop it.

Feature also temporarily disabled in https://github.com/sindresorhus/refined-github/commit/c8a50197b2695b7f4bf5c96d87dd5211a5d9c7a6

I'm seeing the same issue from my end.

Enterprise only feature? It's super stable there. 🤣


#4645 issue: Updated button.overrides

Updated the code so that the submit button will become red when clicked instead of the previous buggy blue circular shadow it was showing before.

@Shivaji2808 you need to sign the Plone Contributor Agreement to merge this pull request.
Learn about the Plone Contributor Agreement: https://plone.org/foundation/contributors-agreement

@Shivaji2808 you need to sign the Plone Contributor Agreement to merge this pull request.
Learn about the Plone Contributor Agreement: https://plone.org/foundation/contributors-agreement

This is not the correct fix. We need to remove the box-shadow from the focus style for circular buttons only. This is removing the box-shadow from all buttons, and adding a new color which is not wanted.


[Automation] Generate Fluent Lite from help#package-2023-01-01-preview

[Automation] Generate Fluent Lite from help#package-2023-01-01-preview

/azp run prepare-pipelines

/azp run java - selfhelp - ci

API change check
APIView has identified API level changes in this PR and created following API reviews.
azure-resourcemanager-selfhelp


Expected parent IDs to be set when ordering by parent ID.

Hi Prisma Team! My Prisma Client just crashed. This is the report:
Versions

Name
Version

Node
v16.13.0

OS
darwin-arm64

Prisma Client
in-memory

Query Engine
c875e43600dfe042452e0b868f7a48b817b9640b

Database
mysql

Logs
prisma:tryLoadEnv Environment variables not found at
prisma:tryLoadEnv Environment variables not found at
prisma:tryLoadEnv No Environment variables loaded
prisma:client dirname /Users/ashemagalhaes/Desktop/code/hearth/server/prisma
prisma:client relativePath
prisma:client cwd /Users/ashemagalhaes/Desktop/code/hearth/server/prisma
prisma:client clientVersion in-memory
prisma:client clientEngineType library
prisma:client:libraryEngine internalSetup
prisma:client:libraryEngine:loader loadEngine using /Users/ashemagalhaes/Desktop/code/hearth/server/node_modules/prisma/engines/c875e43600dfe042452e0b868f7a48b817b9640b/libquery_engine-darwin-arm64.dylib.node
prisma:client:libraryEngine requestBatch
prisma:client:libraryEngine library starting
prisma:client:libraryEngine sending request, this.libraryStarted: false
prisma:client:libraryEngine library already starting, this.libraryStarted: false
prisma:client:libraryEngine sending request, this.libraryStarted: false
prisma:client:libraryEngine library already starting, this.libraryStarted: false
prisma:client:libraryEngine library started
prisma:client:request_handler {"clientVersion":"in-memory"}
prisma:client:libraryEngine library is already stopping
prisma:client:libraryEngine library stopping
prisma:client:libraryEngine library is already stopping
prisma:client:libraryEngine library stopped
prisma:client:libraryEngine requestBatch
prisma:client:libraryEngine library starting
prisma:client:libraryEngine library started
prisma:client:libraryEngine sending request, this.libraryStarted: true
prisma:client:libraryEngine sending request, this.libraryStarted: true
prisma:client:libraryEngine library is already stopping
prisma:client:request_handler {"clientVersion":"in-memory"}
prisma:client:libraryEngine library is already stopping
prisma:client:libraryEngine library stopping
prisma:client:libraryEngine library stopped
prisma:client:libraryEngine sending request, this.libraryStarted: false
prisma:client:libraryEngine library starting
prisma:client:libraryEngine sending request, this.libraryStarted: false
prisma:client:libraryEngine library already starting, this.libraryStarted: false
prisma:client:libraryEngine library started
prisma:client:libraryEngine library is already stopping
prisma:client:libraryEngine library stopping
prisma:client:libraryEngine library stopped
prisma:client:libraryEngine sending request, this.libraryStarted: false
prisma:client:libraryEngine library starting
prisma:client:libraryEngine sending request, this.libraryStarted: false
prisma:client:libraryEngine library already starting, this.libraryStarted: false
prisma:client:libraryEngine library started
prisma:client:libraryEngine library is already stopping
prisma:client:libraryEngine library stopping
prisma:client:libraryEngine library stopped
prisma:client:libraryEngine requestBatch
prisma:client:libraryEngine library starting
prisma:client:libraryEngine library started
prisma:client:libraryEngine library stopping
prisma:client:libraryEngine library stopped
prisma:client:libraryEngine requestBatch
prisma:client:libraryEngine library starting
prisma:client:libraryEngine library started
prisma:client:libraryEngine library stopping
prisma:client:libraryEngine library stopped
prisma:client:libraryEngine requestBatch
prisma:client:libraryEngine library starting
prisma:client:libraryEngine library started
prisma:client:libraryEngine library stopping
prisma:client:libraryEngine library stopped
prisma:client:libraryEngine requestBatch
prisma:client:libraryEngine library starting
prisma:client:libraryEngine library started
prisma:client:libraryEngine requestBatch
prisma:client:libraryEngine library is already stopping
prisma:client:libraryEngine library stopping
prisma:client:libraryEngine library stopped
prisma:client:libraryEngine sending request, this.libraryStarted: false
prisma:client:libraryEngine library starting
prisma:client:libraryEngine sending request, this.libraryStarted: false
prisma:client:libraryEngine library already starting, this.libraryStarted: false
prisma:client:libraryEngine library started
prisma:client:request_handler {"clientVersion":"in-memory"}
prisma:client:libraryEngine library is already stopping
prisma:client:libraryEngine library stopping
prisma:client:libraryEngine library stopped
prisma:client:libraryEngine requestBatch
prisma:client:libraryEngine library starting
prisma:client:libraryEngine sending request, this.libraryStarted: false
prisma:client:libraryEngine library already starting, this.libraryStarted: false
prisma:client:libraryEngine sending request, this.libraryStarted: false
prisma:client:libraryEngine library already starting, this.libraryStarted: false
prisma:client:libraryEngine library started

Client Snippet
// PLEASE FILL YOUR CODE SNIPPET HERE

Schema
// PLEASE ADD YOUR SCHEMA HERE IF POSSIBLE

Prisma Engine Query
{"X":{}}

Hey @ashemag,
Could you please provide us with your Prisma Schema (or a subset of it) and the query that led to this error? Your Prisma Client version would also be helpful. Without it, we can hardly reproduce your issue, unfortunately.
Thank you 🙏

Hi @ashemag
Following up: we're happy to move this issue forward, but are unable to reproduce. Could you please fill out the Client Snippet, Schema, and Prisma Engine Query sections of your issue?
Thank you!

Hi,
We haven't seen movement or responses here, so we will have to close. If you have a similar issue please leave a comment or open a new issue.


Pype 3.0 - command and install refactoring

Feature
This is first step towards new Pype 3 infrastructure. It dissolves pypeclub/pype-setup into pypeclub/pype. It provides basic build infrastructure to build/freeze Pype into standalone self-contained application. All required repositories are now added as git submodules into repos folder.
You can either clone it and init submodules in one step:
git clone -b 3.0/refactoring --recurse-submodules git@github.com:pypeclub/pype.git

Or if you already cloned pype just run:
git submodule update --init --recursive.

Building Pype
Windows
You will need Python 3.7 and newer and git.
Clone repository:
git clone --recurse-submodules git@github.com:pypeclub/pype.git

Run PowerShell script build.ps1. It will create venv, install all
required dependencies and build Pype. After it is finished, you will find
Pype in build folder.
Pype is build using CX_Freeze to freeze itself and all dependencies.

This doesn't work yet BTW. It should build OK under windows and print help, but pype_commands (former PypeLauncher) is not implemented yet.

It is now possible to run Tray. Well - almost. What is missing is refactor of pype.lib package into pype.lib module.


add dynamic provisioning option for helm charts

Add item for persistence.storageClass to support dynamic volume provisioning for shared and composer pvcs to helm-charts/ibm-blockchain-network/values.yaml . Default behavior kept to use hostPath persistent volumes.
Change logic in deploy_charts.sh to avoid blocking when the /shared persistent volume is removed after helm charts are removed or when it has not yet been created (first run of script).
PR allows for deployment to clusters with more than one worker supporting a dynamic volume provisioner for persistence. Tested on IBM Cloud Private using an nfs-based dynamic provisioner https://github.com/timroster/deploy-ibm-cloud-private/blob/all_features/docs/deploy-nfs-provisioner.md .

@mrshah-at-ibm / @dhyey-ibm, I've reviewed these changes and they are OK to merge.

Thanks @eddie-at-ibm


updateWssdCert.ps1 fails after having issues running Connect-Eflowvm

Describe the bug
Cannot run Connect-EflowVm anymore on several installations, getting the following error:
 - C:\Program Files\Azure IoT Edge\nodectl.exe  compute vm list -o tsv --query "[*].name" failed to execute [Error: rpc error: code = Unavailable desc = connection error: desc = "transport: authentication handshake failed: x509: certificate signed by unknown authority (possibly because of \"crypto/rsa: verification error\" while trying to verify candidate authority certificate \"NodeAgent\")"] at line 4268

[01/22/2024 15:34:30] Exception caught!!!

I've found https://github.com/Azure/iotedge-eflow/issues/225 and tried running updateWssdCert.ps1 with no success, where I'm getting the following error:
Stopping WSSDAgent service
Stop-Service : Cannot stop service 'WSSD Agent Service (wssdagent)' because it has dependent services. It can only be stopped if the Force flag is set.
At C:\----\----\updateWssdCert.ps1:9 char:1
+ Stop-Service wssdagent
+ ~~~~~~~~~~~~~~~~~~~~~~
    + CategoryInfo          : InvalidOperation: (System.ServiceProcess.ServiceController:ServiceController) [Stop-Service], ServiceCommandException
    + FullyQualifiedErrorId : ServiceHasDependentServices,Microsoft.PowerShell.Commands.StopServiceCommand

Remove-Item : Cannot find path 'HKLM:\SOFTWARE\Microsoft\WssdAgent\v0.10.8-alpha.10\CertificateInternal' because it does not exist.
At C:\----\----\updateWssdCert.ps1:10 char:1
+ Remove-Item -Force -Path "HKLM:SOFTWARE\Microsoft\WssdAgent\v0.10.8-a ...
+ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    + CategoryInfo          : ObjectNotFound: (HKLM:\SOFTWARE\...ificateInternal:String) [Remove-Item], ItemNotFoundException
    + FullyQualifiedErrorId : PathNotFound,Microsoft.PowerShell.Commands.RemoveItemCommand

Restarting WSSDAgent service
Remove-Item : Cannot find path 'C:\Users\----\.wssd\nodectl' because it does not exist.
At C:\----\----\updateWssdCert.ps1:17 char:1
+ Remove-Item -Recurse -Force -Path "$env:UserProfile\.wssd\nodectl"
+ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    + CategoryInfo          : ObjectNotFound: (C:\Users\----\.wssd\nodectl:String) [Remove-Item], ItemNotFoundException
    + FullyQualifiedErrorId : PathNotFound,Microsoft.PowerShell.Commands.RemoveItemCommand

Copy-Item : A positional parameter cannot be found that accepts argument 'Â'.
At C:\----\----\updateWssdCert.ps1:21 char:1
+ Copy-Item -Path "$env:UserProfile\.wssd\nodectl\cloudconfig"Â  -Desti ...
+ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    + CategoryInfo          : InvalidArgument: (:) [Copy-Item], ParameterBindingException
    + FullyQualifiedErrorId : PositionalParameterNotFound,Microsoft.PowerShell.Commands.CopyItemCommand

[01/22/2024 15:40:06] Exception caught!!!

 - C:\Program Files\Azure IoT Edge\nodectl.exe  compute vm list -o tsv --query "[*].name" failed to execute [Error: rpc error: code = Unavailable desc = connection error: desc = "transport: authentication handshake failed: x509: certificate signed by unknown authority (possibly because of \"crypto/rsa: verification error\" while trying to verify candidate authority certificate \"NodeAgent\")"] at line 4268
Error caught while invoking VM command
Failed to retrieve virtual machine name.

Expected behavior
To be able to sign in to VM using Connect-EflowVm
Windows Host OS (please complete the following information):

Edition: Windows 10 Pro
Version: 22H2
Virtual Machine: Azure Iot Edge LTS <IP_ADDRESS>12

Additional context
Is there a way to fix this without doing a clean install of Iot Edge?
I can find the .wssd-folder, but it's empty, hence the ItemNotFound exception.
Should updateWssdCert.ps1 be updated to work with LTS <IP_ADDRESS>12?
Is it possible to update Iot Edge without fixing this issue first?
Other suggestions?
Thanks!

Can I ask what the solution was to this please? I am experiencing the exact same issue where I can't run the powershell script as /.wssd/nodectl cannot be fount (.wssd is present but empty). We can't afford to delete and re-install this as it's in a production environment.

Hi @TashaRoseLisle,
I did not find a solution, and got no feedback either.
I can reopen the issue.

Hi @chokosticks , if this issue still persists on recent EFLOW releases, please open a new GitHub issue and we will take a look. Thank you!


flutter compiler-precompiler

My flutter project currently wants to support web and windows, but part of the code cannot be compiled on the web, how can I use conditional compilation? Similar to #ifdef #endif

@JonathanGit There is no way to conditionally compile see https://github.com/dart-lang/sdk/issues/34262#issuecomment-416129832  and also https://stackoverflow.com/a/64068904/8253662
Closing as this is neither a bug nor a feature request.


Instead of SimSun and SimHei, replace with SimSun-18030 and YaHei

As described in fontist/formulas#58 SimSun is available as "SimSun-18030" and SimHei should be replaced with YaHei due to font availability. This task is to update the gem to reflect this.

This gem is frozen, and is not being updated to deal with metanorma updates.
Frozen means frozen, so this will not be actioned.


Serializing equations: many cases

Fortunately to ensure equality objects including predicates have been made concrete. However, there is a long chase

Equation and EquationNode depend on Expression
The sums, products etc of expressions can be serialized given the components are serialized.
The complicated cases are InitialVal and FinalVal, which depend on a Variable.

The case Elem of a Variable in turn depends on a RandomVariable; this can be an instance of a family (AtCoord) or a concrete one.
The Elemalso depends on an element, which can be a term, type, function etc. depending on the random variable; in addition we have such an object for AtCoord.
We also have events, that depend on a Sort.
A Sort can depend on a Fitler or Restrict, both depending on maps. However these should be concrete.

A handful of concrete RandomVars are in TermGeneratorNodes while most are in TermRandomVars. They shoud be unified.

Unification done. Some cases are not used, so about 15-20 cases are needed manually.

We should follow the approach of 5eb7201df257eca where equations were factorised, and a separate lookup table was generated for elementary expressions. In this case we also need lookup tables for events, coefficients etc.

The remaining painful case is serializing GeneratorEquationNode for serializing Coeff


Use bytesize to calculate content length of unzipped body

length returns the number of characters, not the number of bytes,
which can cause data to get truncated when the input contains multibyte
characters.

Oops, I meant to PR this onto our fork! Feel free to merge if you want though.

I'll clean this up to not have the extraneous merge commit in a minute.

:+1: would be happy to merge this

Released in v0.0.3

Thanks!


perf: Use include_fields to strip down bugzilla response, use paging

Reduces query time from 2m or more to a more manageable 10-30s
Also standardize on the table viewer and remove the logic that purges
bugs on disk on startup.

/test images

/retest


Open in Browser generates a folder with lots of files

Good morning,
I noticed that opening a URL from newsboat with Google Chrome generate a '~google-chrome'  folder containing several subfolfders (i.e.  Default, WidevineCdm, GrShaderCache, etc). The content of this folder is updated every time a new feed is opened in the browser.
My question is: is it possible to prevent this data dumping to the folder, o at least purge it upon closing newsboat?
Thank you very much in advance for the support,
kind regards
Alfredo

Hi Alfredo,
Newsboat does not create these kinds of folders, so I expect that Google Chrome creates the folder by itself.
Does Chrome also create the folder if you start it from outside of Newsboat?
Do you manually configure the browser in the newsboat config (via a set browser …  line) or is it configured via the BROWSER environment variable? (and do either of those contain extra command line arguments?)

Alright, nice to hear you found the cause.
If you still want to store the database in a specific location, you could try using Newsboat's --cache-file=/path/to/cache.db option.
Be aware that you would then need to specify that every time (might be possible using an alias in your shell).
Just to be save, make sure you have backed up Newsboat's config/urls/cache files before starting to use that option.
Regardless, looks like the problem is resolved so I'm closing this issue.
Feel free to open a new issue (or reopen this issue) in case of related problems/questions.


Query conf

Codecov Report

Merging #20 into master will increase coverage by 3.24%.
The diff coverage is 99.1%.

@@            Coverage Diff             @@
##           master      #20      +/-   ##
==========================================
+ Coverage   90.24%   93.49%   +3.24%
==========================================
  Files          15       16       +1
  Lines         369      584     +215
==========================================
+ Hits          333      546     +213
- Misses         36       38       +2

Impacted Files
Coverage Δ

include/ozo/query_builder.h
100% <100%> (ø)
:arrow_up:

include/ozo/query_conf.h
99.06% <99.06%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1b5e3cc...331f313. Read the comment docs.


PHOENIX-6238 Fix missing executable permission because of MASSEMBLY-941

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 46s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

-1 :x:
test4tests
0m  0s
The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ master Compile Tests _

+0 :ok:
mvndep
8m 32s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
7m 50s
master passed

+1 :green_heart:
compile
2m 15s
master passed

-1 :x:
javadoc
0m 13s
phoenix4-connectors-assembly in master failed.

-1 :x:
javadoc
0m  6s
phoenix5-connectors-assembly in master failed.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 19s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
6m 32s
the patch passed

+1 :green_heart:
compile
2m  9s
the patch passed

+1 :green_heart:
javac
2m  9s
the patch passed

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
xml
0m  6s
The patch has no ill-formed XML file.

-1 :x:
javadoc
0m  6s
phoenix4-connectors-assembly in the patch failed.

-1 :x:
javadoc
0m  6s
phoenix5-connectors-assembly in the patch failed.

_ Other Tests _

-1 :x:
unit
69m 52s
root in the patch failed.

-1 :x:
asflicense
0m 33s
The patch generated 1 ASF License warnings.

102m 32s

Subsystem
Report/Notes

Docker
ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-40/1/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/phoenix-connectors/pull/40

Optional Tests
dupname asflicense javac javadoc unit xml compile

uname
Linux 706a10ad1f7c 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev/phoenix-connectors-personality.sh

git revision
master / ad05445

Default Java
Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08

javadoc
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-40/1/artifact/yetus-general-check/output/branch-javadoc-phoenix4-connectors-assembly.txt

javadoc
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-40/1/artifact/yetus-general-check/output/branch-javadoc-phoenix5-connectors-assembly.txt

javadoc
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-40/1/artifact/yetus-general-check/output/patch-javadoc-phoenix4-connectors-assembly.txt

javadoc
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-40/1/artifact/yetus-general-check/output/patch-javadoc-phoenix5-connectors-assembly.txt

unit
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-40/1/artifact/yetus-general-check/output/patch-unit-root.txt

Test Results
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-40/1/testReport/

asflicense
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-40/1/artifact/yetus-general-check/output/patch-asflicense-problems.txt

Max. process+thread count
1806 (vs. ulimit of 30000)

modules
C: phoenix4-connectors-assembly phoenix5-connectors-assembly . phoenix-hive-base U: .

Console output
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-40/1/console

versions
git=2.7.4 maven=3.3.9

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Committed to master


Underline attributes

changed how .underline and .strikethrough attributes were used. Allowing the use of NSUnderlineStyle for both, so people can use a variety of styles for these lines.

@SteveBarnegren - this is ready for another look.


Fix store-first local cache bug

Normally, the first request to the local cache is a DirectoryBuildCacheService.load(), which initializes the cache, so when we hit it with the first store, the directory is already there and prepared.
However, if the task is re-run (via --rerun-tasks, or because it's marked as upToDateWhen()), then Gradle won't load any results from cache. In this case the first access to the local cache is a store:

we first create the ".part" file inside the build-cache directory in DirectoryBuildCacheService.allocateTempFile(),
the cache directory is then initialized (and all content deleted, including the ".part" file) when we hit DirectoryBuildCacheService.store()
we try to move the (now deleted) ".part" file into the cache, which promptly fails

The problem was introduced in Gradle 4.1 with this: https://github.com/gradle/gradle/commit/e7344b65d8a4c4ba287b4acd7c5291beaa585c8c#diff-e43aa4ae86a4aefdc533a6c7a486d60bR170

Branch build: https://builds.gradle.org/viewQueued.html?itemId=9023934

New branch build: https://builds.gradle.org/viewQueued.html?itemId=9024838

Note about the build above: it should be considered as a pass as the native performance tests are flaky on master too.

New build after rebasing to fixed master: https://builds.gradle.org/viewQueued.html?itemId=9029875

Belated LGTM.


Fix the portrait focus order

TL;DR: this fix a no reported issue related to the order of the portraits
Apparently there's a bug that causes lost the focus order:

This PR fixes it:

Gracias :)


touchegg: 1.1.1 -> 2.0.8

Side note
This is my first PR to nixpkgs, so sorry if I am doing anything wrong! Also, if possible, I would like to maintain this package, but I do not know if there are any specific requirements to becoming a maintainer? Thanks.
Motivation for this change
Since touchegg started receiving updates again, the current touchegg in nixpkgs is quite outdated.
Things done
There has been done some work upstream to make it possible to build on NixOS. See

Discussion at discourse
PR on the touchegg project

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[x] (Found no tests) Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[x] (Found no packages that depended on touchegg with grep -rnw '/path/to/nixpkgs/' -e 'touch.gg') Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[ ] Fits CONTRIBUTING.md.

The check from ofborg-eval This PR does not cleanly list package outputs after merging. gives the warning:
Warning: `stdenv.lib` is deprecated and will be removed in the next release. Please use `lib` instead.
I am not quite sure what the problem is. I tried fixing it in d54f18e

Thanks for reviewing!

Also please squash the commits.

Also please squash the commits.

Done! :smile:

Touchégg v2.0.9 was released I got curious and found this PR.
It seems to be working great on my side (2.0.9), way better than my poor overlay attempt, thanks @Hvassaa

@Hvassaa the tests try to create a directory outside of the sandbox:
schemas/touchegg-2.0.8/glib-2.0/schemas/ install
[100%] Built target touchegg
Install the project...
-- Install configuration: "Release"
CMake Error at cmake_install.cmake:46 (file):
  file cannot create directory: /usr/share/touchegg.  Maybe need
  administrative privileges.
make: *** [Makefile:127: install] Error 1
builder for '/nix/store/j0khdssfdfq7bh7hn1hyz6s7q6mizhwr-touchegg-2.0.8.drv' failed with exit code 2
error: build of '/nix/store/j0khdssfdfq7bh7hn1hyz6s7q6mizhwr-touchegg-2.0.8.drv' failed

I think I will need help on this one, if anyone knows how to fix it

Looks like there's a bit of nasty business going on somewhere regarding the config.  I'm not an expert in cmake, but here's a grungy brute force "fix" added into the .nix file:
`  configurePhase = ''
mkdir -p $out
mkdir build
cd build
cmake -DCMAKE_INSTALL_PREFIX:PATH=$out -DCMAKE_BUILD_TYPE=Release ..
# Not sure why the cmake paths aren't being set; there are, however, a few paths hard coded into files that need to be updated.
sed -i "s|/lib|$out/lib|g" cmake_install.cmake
sed -i "s|/etc|$out/etc|g" cmake_install.cmake
sed -i "s|\''${CMAKE_INSTALL_PREFIX}|$out|g" cmake_install.cmake
sed -i "s|/usr/share/|$out/share/|g" ../src/utils/paths.cpp
sed -i "s|/usr/share/|$out/share/|g" ../src/utils/paths.h
sed -i "s|/usr/share/|$out/share/|g" ../src/config/xml-config-loader.cpp
sed -i "s|/usr/share/|$out/share/|g" ../src/config/xml-config-loader.h

'';`
This at least gets it to install, be found in the path, and look for the configuration file in the correct place (touchegg blows up if it can't find it whatever directory was in src/utils.paths.cpp).  It does not get the systemd file to work.
Hopefully this gives some insight as to why touchegg isn't installing and that there's a more elegant solution for at least the cmake portion that doesn't involve sed.  I just did a quick and dirty mod because I missed gestures in X

OH, it looks like the version that the .nix downloads is actually older than the PR you made, so it doesn't have any of those fixes in place.  Updating the file to version 2.0.10 (and updating the sha as appropriate) makes it work.  Here's a gist with the updated file.

Tracking touchegg 2.0.11 upgrade as part of Pantheon 6 upgrade in https://github.com/NixOS/nixpkgs/pull/130380#issuecomment-886060881.

Also, after this PR is merged, could the package be backported to 21.05, as GNOME 40 gestures in X11 requires the package


Switch DB to mongo

This might be a better longer-term alternative instead of writing query functions with acid

Bad idea. After some research mongo.doesnt work well with Haskell


Oozie's job browser incorrectly renders PNG data

Describe the bug:
This is the continuation of #1262, in which the problem was firstly described. There are two problems:

If Hue can't render the Oozie job's graph from XML, it tries to fetch its PNG representation from Oozie and to render it instead. This ends up into a broken user experience since the PNG's binary data is dumped on the HTML's code without any <img> tag:

As mentioned above, if Hue cannot handle the Oozie's job XML code it fallbacks to the PNG image. In our case, we have a workflow with extra "" in some actions that cause the str representation of the XML to not be transformable in valid JSON (that is needed to then render the graph correctly in the UI).

The end result of both is this broken page:

Steps to reproduce it?
In a workflow.xml, it is sufficient to have a map-reduce action with a property like the following:
                <property>
                    <!--Quoted on purpose -->
                    <name>cassandra.output.keyspace</name>
                    <value>"${cassandra_keyspace}"</value>
                </property>

The double quoting in this case is needed (it is passed to a cassandra client that doesn't accept single quotes) but it makes the xml -> json conversion to fail:
[14/Nov/2020 09:03:32 +0000] dashboard    ERROR    Graph data could not be generated from Workflow 0015355-201103154415936-oozie-oozi-W: Expecting ',' delimiter: line 1 column 2511 (char 2510)
Traceback (most recent call last):
  File "/usr/lib/hue/apps/oozie/src/oozie/views/dashboard.py", line 363, in list_oozie_workflow
    workflow_data = Workflow.gen_workflow_data_from_xml(request.user, oozie_workflow)
  File "/usr/lib/hue/apps/oozie/src/oozie/models2.py", line 263, in gen_workflow_data_from_xml
    node_list = generate_v2_graph_nodes(oozie_workflow.definition)
  File "/usr/lib/hue/apps/oozie/src/oozie/importlib/workflows.py", line 748, in generate_v2_graph_nodes
    node_list = json.loads(node_list)
  File "/usr/lib/python3.7/json/__init__.py", line 348, in loads
    return _default_decoder.decode(s)
  File "/usr/lib/python3.7/json/decoder.py", line 337, in decode
    obj, end = self.raw_decode(s, idx=_w(s, 0).end())
  File "/usr/lib/python3.7/json/decoder.py", line 353, in raw_decode
    obj, end = self.scan_once(s, idx)
json.decoder.JSONDecodeError: Expecting ',' delimiter: line 1 column 2511 (char 2510)

The specific bit in workflows.py that causes the problem is:
  # Get XSLT
  parser = etree.XMLParser(resolve_entities=False)
  xslt = etree.parse(xslt_definition_fh, parser=parser)
  xslt_definition_fh.close()
  transform = etree.XSLT(xslt)

  # Transform XML using XSLT
  transformed_root = transform(workflow_definition_root)
  node_list = re.sub('[\s]', '', str(transformed_root))
  node_list = json.loads(node_list)

In theory there should be a way to escape properly some chars before the json.loads, but I didn't find a valid solution yet (suggestions welcome).
Hue version or source?
Hue 4.8.0

@romainr hi! Any idea how to debug this?

@romainr hi! Any idea how to debug this?

It feels like we either need to encode the binary properly so that it is json compatible, e.g. https://stackoverflow.com/questions/1443158/binary-data-in-json-string-something-better-than-base64 (and maybe add a new type field in the response saying that if it is regular workflow data or binray)
or create a new API endpoint to get back the binary image directly.

It feels like we either need to encode the binary properly so that it is json compatible, e.g. https://stackoverflow.com/questions/1443158/binary-data-in-json-string-something-better-than-base64 (and maybe add a new type field in the response saying that if it is regular workflow data or binray)
or create a new API endpoint to get back the binary image directly.

@romainr so I see two problems:

the XML -> json conversion that doesn't work

the fact that, as a fallback, the image of the workflow is retrieved from oozie and displayed as is without any  tag or similar in the HTML code.

for some workflows may be acceptable, but the fallback should work in theory..

@romainr so I see two problems:

the XML -> json conversion that doesn't work

the fact that, as a fallback, the image of the workflow is retrieved from oozie and displayed as is without any  tag or similar in the HTML code.

for some workflows may be acceptable, but the fallback should work in theory..

:+1:

:+1:

@romainr the follow up in this case would be to see if we can add the  tag for the PNG binary stuff, but it is a little outside my realm, suggestions?

@romainr the follow up in this case would be to see if we can add the  tag for the PNG binary stuff, but it is a little outside my realm, suggestions?

So the easiest is probably to add the  tag and fill it up when the API is called with format=svg?

So the easiest is probably to add the  tag and fill it up when the API is called with format=svg?

Still need to be fixed :)

This is still a bug!


Filters giving error

While using filters, there is an error appearing.

Solved in #101, closing.


Picker mode="time" 时，在支付宝中会导致崩溃

u-picker mode="time" 时，在支付宝中会报错，程序崩溃掉，但是在微信里面是正常的。
af-appx.worker.min.js:26 Cannot read property 'props' of null
Please check your axml:
    in picker-view
    in view
    in view
    in scroll-view
    in view
    in view
    in /node-modules/uview-ui/components/u-popup/u-popup
    in /node-modules/uview-ui/components/u-picker/u-picker
    in view
    in pages/delivery/index

+1

#409

+1

+1

+1


⚠ GitHub has degraded performance

In 03069df, GitHub (https://www.githubstatus.com/api/v2/status.json) experienced degraded performance:

HTTP code: 200
Response time: 172 ms

Resolved: GitHub performance has improved in 7226b79.


SPARK-35874 has removed an mapOutputStatisticsFuture API

We need to incorporate this change because there was an API removed
For more details read SPARK-35874

I took a quick look at this. The main change is that ShuffleExchangeLike.mapOutputStatisticsFuture is now protected and called from a new submitShuffleJob method, which is final.
  final def submitShuffleJob: Future[MapOutputStatistics] = executeQuery {
    mapOutputStatisticsFuture
  }

  protected def mapOutputStatisticsFuture: Future[MapOutputStatistics]

Hopefully, we can get away with moving our class to the same package and continue to override this but we'll need to test this once we can compile and test with Spark 3.2.

This isn't causing any test failures locally so I don't think this is a P1. We still need to look at this before we release 21.10 though.

We do not override this method so this does not affect us after all


[Typo]: useDeferredValue parameters in react 18

Summary
I read in the react 19 blogpost that useDeferredValue will support initialValue as an optional second parameter
but this is currently listed as a parameter in the docs for react 18
I think this is a mistake
Page
https://18.react.dev/reference/react/useDeferredValue#usedeferredvalue
Details
No response

The docs state that this is a Canary-only feature.


Feature/vuex settings menu

Branch not stable
Idea is to slowly move to using vuex to store application state.
This branch is an attempt at moving some logic to this, however the changeset became too large to manage in a simple PR.
May come back to this at a later point.

Closing PR as this has been completed in other PRs in a smaller iterative way.


subsys/fs/littlefs: initialize LittleFS at POST_KERNEL

Initialize LittleFS at POST_KERNEL and not at APPLICATION stage.
When using LittleFS as settings backend for OpenThread, LittleFS needs
to be available when net_init is performed.
Arguably, FS is an OS kernel component that should be ready when
applications are starting.
Possibly, the same change should be applied to FAT fs as well.


Metric contexts: check that SQLite, DuckDB, and Postgres support querying JSON fields within a column

Need to ensure Gorm supports json querying.
Context is not flat, need to query nested objects.
Need to query a variety of types
Determine if db engines have a max_depth, if so, or if there are perf implications, we may need a story to block that behaviour in the UI

Findings.

Gorm supports JSON for PG, Sqlite, and Mysql -- but not Duckdb.

hey @suprjinx, what about the max depth for querying?

@jgiannuzzi i am not seeing mention of practical limits for querying nested json in PG or Sqlite docs -- but it seems intuitive we'd encounter this at some point. Perhaps we'd need to create a json document of the expected complexity and verify it with a benchmark test?

let's have a look at what we can do in Go then in terms of limiting the depth of the JSON query

I assume we're going to support a context query syntax like Aim's? it seems like we can just "count the dots" and set a limit? This will get translated, most likely, into "->" operator in the sql.


cost more training time per epoch than centernet

Using single GPU, same network architecture, I found the training time per epoch of ttfnet is about 1.6 times than centernet.
I'm not sure whether I did the comparison right , has anyone made such comparison?

I also found the same problem. Using dla34 for training, the training time of centernet is faster than that of ttfnet, and the accuracy of centernet is also higher than that of ttfnet when training for 12 epochs.


Anonymous users can't register since 0.1.13

Before my last meteor upgrade (https://clbin.com/Zo0E9, Meteor <IP_ADDRESS> -> <IP_ADDRESS>, artwells:accounts-guest 0.1.12 -> 0.1.13, anonymous accounts worked as expected:

Every new user got a new Meteor.userId()
They were still shown the "Sign in / Join" button
They could login whenever they pleased

After this upgrade:

Every new user gets a new Meteor.userId()
They're not shown the "Sign in / Join" button
** Instead, either a made-up username or an empty username is shown, depending on AccountsGuest.anonymous and AccountsGuest.name
Instead of registration and signup options, the user is only presented with the option to sign out, but when he signs out, a new anonymous account is automatically created again, so he never gets the chance to register

Btw, this should be enough to reproduce the bug:
git clone git@github.com:RazZziel/LetsGO.git
cd LetsGO
meteor

(anonymous users can register)
<Ctrl+C>
meteor update
meteor

(anonymous users now can't register)

Also reproducible after upgrading only accounts-guest package with:
$ meteor update artwells:accounts-guest

Changes to your project's package version selections from updating package versions:

accounts-password             removed from your project
artwells:accounts-guest       upgraded from 0.1.12 to 0.1.13
brettle:accounts-login-state  added, version 0.0.3
brettle:accounts-patch-ui     added, version 0.0.1
npm-bcrypt                    removed from your project
sha                           removed from your project
srp                           removed from your project

diff: https://clbin.com/9yHYJ
I also managed to update meteor while keeping accounts-guest package working:
$ meteor remove artwells:accounts-guest
$ meteor add<EMAIL_ADDRESS>$ meteor update

diff: https://clbin.com/P6T5l

I encountered the same problem. Moving back to version 0.1.12 seems to prevent the issue from happening.

@brettle can you look into this, seems to be your pull request remvoed some funcitonality

Looking into it...

I think I've found the problem. My PR changed things so that instead of replacing the currentUser helper globally, it is uses brettle:accounts-patch-ui which only overrides currentUser in Template.loginButtons and (this is the relevant bit) only when accounts-ui-unstyled is installed. You are using ian:accounts-ui-bootstrap-3 which provides it's own Template.loginButtons and doesn't use accounts-ui-unstyled, so brettle:accounts-patch-ui doesn't override currentUser in the loginButtons template and you don't get the Sign in/up option.
I'm currently trying figure out the best way to fix it.

This should be fixed now for users of ian:accounts-ui-bootstrap-3. A meteor update should update their brettle:accounts-patch-ui to version 0.1.2 which I just published and which adds support for that package.
@RazZziel, please confirm that this fixes things for you.
@MastaBaba, if a meteor update doesn't fix this for you, please indicate what accounts UI package you are using.
@artwells, brettle:accounts-patch-ui only supports packages which use accounts-ui-unstyled (e.g. accounts-ui), the useraccounts suite, and now ian:accounts-ui-bootstrap-3. Your README currently claims support for "any other accounts-ui derivative". If the derivative uses accounts-ui-unstyled, it should work. Other "derivatives" which actually replace accounts-ui-unstyled (like ian:accounts-ui-bootstrap-3) will not work unless support for them is explicitly added. You could return to overriding the global currentUser helper if you want complete backward compatibility and are willing to accept that such an override has effects outside of the login buttons. The following code should do that:
Template.registerHelper("currentUser",
  AccountsPatchUi.wrapWithSignedUp(function () {
    return Meteor.user();
  })
);

Last meteor update pushed iron:router from 1.0.9 to 1.0.10, so now I can't update brettle:accounts-patch-ui because of this dependency:
<EMAIL_ADDRESS><- brettle:accounts-patch-ui 0.1.2 <- artwells:accounts-guest 0.1.13

Fixed now. Please try again. Thanks!
On Tue, Oct 6, 2015 at 10:30 PM, Ismael Barros²<EMAIL_ADDRESS>wrote:

Last meteor update pushed iron:router from 1.0.9 to 1.0.10, so now I
can't update brettle:accounts-patch-ui because of this dependency:
<EMAIL_ADDRESS><- brettle:accounts-patch-ui 0.1.2 <- artwells:accounts-guest 0.1.13
—
Reply to this email directly or view it on GitHub
https://github.com/artwells/meteor-accounts-guest/issues/41#issuecomment-146080566
.

Seems to be working for me.

After running meteor update, social login buttons are shown, but user/password login is not.
After realizing the accounts-password had been removed and reinstalling it, everything seems to be running fine again.


Allow the registration of regular MessageConverters as beans

Currently, all custom message converters must extend AbstractFromMessageConverter and must use the specific class of the bean or at least AbstractFromMessageConverter for being added to the configuration. This is inconvenient as it exposes too much implementation detail to the end user.
Proposed solution:

allow the registration of ordinary MessageConverter beans and allow them to participate in the StreamListener argument conversion as well as bound message channel conversion (see below);
introduce an extended interface e.g. TargetTypeMessageConverter to capture the additional contract of converters that can be added on the input and output channels, i.e. that they advertise specific target content-types and target classes - so only MessageConverters that are also TargetTypeMessageConverters can be used for setting up conversion on input and output channels;
make AbstractFromMessageConverter a utility base implementation of TargetTypeMessageConverter;

Reopening as this is a valid feature for 1.1.0.M1

Pay attention to the @IntegrationConverter and the IntegrationConverterInitializer underneath on the matter. May be useful...

Thanks :).


Discard Changes on unstaged file will abort the current merge

Issue Type: Bug
These steps may be more specific than they need to be, but they're what I was following:

From a clean working directory, merge changes from another branch that produce a conflicted file.
Note that 'git status' reflects that you are currently in the middle of a merge.
Add the conflicted file to the staging area so all conflicts appear resolved.
Make another change to the conflicted file, so it is reflected as an unstaged change.
Click the "Discard Changes" button on the unstaged file to revert the change you made in step 4.

Expected behavior: I should be back where I was at the end of step 3 -- with my unstaged change removed, but still in a merging state.
Actual behavior: The unstaged change is correctly removed, but 'git status' reflects that I am no longer merging. I am unable to complete the merge without restarting it from the beginning.
 When I run git status after step 5 I get:
➜  fakeproject git:(master) ✗ git status
On branch master
All conflicts fixed but you are still merging.
  (use "git commit" to conclude merge)

Changes to be committed:

        modified:   file.txt

Notice the All conflicts fixed but you are still merging..


chore(install): assert profile region is US

Here is an example of output when run for an EU account:
FATAL Only the US region is supported at this time. region EU is not supported.


Importing/Exporting JsonLogic with additional operators

Firstly, thank you very much for this library. It's been a breeze to use!
I'm in the process of replacing react-awesome-query-builder with this package and have hit my first hitch.
We are using JsonLogic with some additional operators such as:
JSONLogic.add_operation("lessThanOrEqualDate", isBeforeOrEqual);
When attempting to import a query that uses this operator with parseJsonLogic  e.g.
{
  "query": {
    "and": [
      {
        "lessThanOrEqualDate": [
          {
            "var": "device.authenticatedAt"
          },
          "PT-24H"
        ]
      }
    ]
  }
}

Then passing it into parseJsonLogic it seems to strip it out. However, any condition that is using one of the defaultOperators works fine.
I assume it's something to do with parseJsonLogic being scoped to the default operators. Is there anyway to let it recognise additional ones?

Hey @hwhmeikle, thanks for the kind words! I'm curious about what's driving your migration from RAQB to RQB. Any feedback is appreciated!
The parse* functions bail out (skip the rule) when they don't know what to do, and that includes rules with non-standard operators. This could be addressed in userland (i.e. you provide your own workaround) or with a configuration to instruct the function how to handle unknown operators.
I'd rather try the former option first. Could you transform the JsonLogic object to map any new operators to known operators first, and then parse it? Your example would change like this, I think:
 parseJsonLogic({
   and: [
     {
-      lessThanOrEqualDate: [
+      "<=": [
         { var: "device.authenticatedAt" },
         "PT-24H"
       ]
     }
   ]
 })

If that doesn't work, we'd probably need to go with the latter option and create a configuration, maybe a map from custom operators to standard ones so parseJsonLogic knows what to do with each one. Let me know what you think.

Thanks for quick reply! The main reason for the migration is that whilst RAQB is very powerful, the DX feels cumbersome once you need to add any custom behaviour. Our main use case is allowing users to create queries and essentially create their own custom fields on the fly. I won't go into detail but the process of updating the config/fields in RAQB and not having it break was fairly hacky and not reacty at all.
I'll give what you suggested a go, and let you know - cheers!

Update: I've written the logic for transforming the keys for importing it and that's working well!
My next hurdle is transforming the other way e.g. <= -> lessThanOrEqualDate. I only want to transform <= operator to lessThanOrEqualDate when it is for the device.authenticatedAt field.
Would there be a way to use transformQuery here to achieve this, or is my best bet writing my own custom transformer?

I don't think you need to use transformQuery, just pass a custom ruleProcessor to formatQuery like below (CodeSandbox here):
import {
  defaultRuleProcessorJsonLogic,
  formatQuery,
  RuleGroupType,
  RuleType
} from "react-querybuilder";

const query: RuleGroupType = {
  combinator: "and",
  rules: [{ field: "device.authenticatedAt", operator: "<=", value: "PT-24H" }]
};

const jsonlgc = formatQuery(query, {
  format: "jsonlogic",
  ruleProcessor: (r: RuleType) => {
    if (r.field === "device.authenticatedAt") {
      return { lessThanOrEqualDate: defaultRuleProcessorJsonLogic(r)["<="] };
    }
    return defaultRuleProcessorJsonLogic(r);
  }
});

What that's doing is taking '<=' property from the result of the default rule processor and assigning it to the lessThanOrEqualDate property of a new object (unless you're dealing with a different field, in which case it just falls back to the default rule processor).
You may need to add some error checking and other contingencies but hopefully that gets you headed in the right direction.

@jakeboone02 Thank you that works nicely :).
You've already gone above and beyond, but would be keen to hear your thoughts on approaching converting the multiselect output from RAQB to RQB.
When using a multiselect in RAQB it seems to wrap the entire rule with an all operator e.g.
{
  "and": [
    {
      "all": [
        {
          "var": "multicolor"
        },
        {
          "in": [
            {
              "var": ""
            },
            [
              "green",
              "yellow",
              "orange"
            ]
          ]
        }
      ]
    }
  ]
}

When using a multiselect in RQB it doesn't wrap it in an all operator (which to me makes more sense) e.g.
{
  "in": [
    {
      "var": "alsoPlaysInstruments"
    },
    [
      "Double bass",
      "Fiddle",
      "Guitar"
    ]
  ]
}

My thinking is that I need to somehow transform the RAQB output to match the RQB output as RQB doesn't use all internally so the rule gets skipped when using parseJsonLogic.

That's confusing to me. I think RAQB is not doing what one would typically expect, but maybe I'm misreading it. For example, this RAQB rule:

generates this JsonLogic rule:
{ "and": [{ "all": [{ "var": "multicolor" }, { "in": [{ "var": "" }, [ "yellow", "orange" ]] }] }] }

But that rule passes when the data is { "multicolor": ["yellow"] } (notice the value is an array). It's saying "is the value an array that contains a value in this other array?" I would expect the rule to pass instead for { "multicolor": "yellow" }, which would say (more simply, and I believe more intuitively) "is the value in this array?" That would also be more like the SQL IN operator.
So I'm not sure there actually is a direct translation from the RAQB output to what RQB handles, at least not that keeps the same logic. Like I said, maybe I'm misreading something.

@jakeboone02 I'm on the same page and would expect it to work as you describe. We've had to get around it by turning the value into an array as you've shown. I guess keeping the same logic would mean turning ["yellow"] -> "yellow".

Yeah that would make more sense to me. You'll still have to translate the "all" operator. Looks like you should take the first element of the "all" array and use that as the first element of the "in" array instead of { "var": "" }. Then extract the "in" rule and process that instead of the full "all" rule.

@jakeboone02 Thanks for the help! Will close this issue.

@hwhmeikle I just released v5.3.2 with a new configuration option for parseJsonLogic called jsonLogicOperations. Documentation here.
You can now specify a function that returns a rule or group based on any custom operation.


pypi token vs password - template is very confusing

Date you used Cookiecutter PyPackage: 08-05-2020
Cookiecutter version used, if any: master branch
Python version, if any: 3.6
Operating System: Windows 10

Description
There are two options to deploy: login/password and token. The recommended option is to use pypi api token, however this template puts a login in the travis.yml. It encourages to use the non recommended option, and the readme file does not explain any of this. I spent the whole afternoon to figure out, why I get pypi authorization errors over and over.
TL;DR I suggest to make this clear by putting few additional lines into the readme.
What I Did
It was my first package to upload to pypi, and I had no idea about how to do it. I used this template, because I wanted things to be done fast. I followed the guide in the README file of this repositroy. At this line in the guide:

Register your project with PyPI.

I follow the provided link and read about creating a token, so I have created it. Next step was

Run the Travis CLI command travis encrypt --add deploy.password to encrypt your PyPI password

This line I misunderstood. Unfortunately, I thought that I should provide a token not a password. There is no token mentioned in the readme, and no password mentioned in the pypi documentation. So I assumed it is the same thing, just different name (and indeed you can put both in the password field of the travis.yml config).
The next bad luck, is that I am using Windows. travis encrypt works strange on Windows, because to terminate input one has to press Enter, then Ctrl+Z, then Enter again. However the console prompt says "press Ctrl+D". My first thought was that windows inserts some additional '\n' or '\r' in the encrypted string. I tried few times and it did not work. Then I rebooted to linux live usb, and it still did not work.
Finally, after few hours of wasted time, I realized that maybe I should look into travis documentation.
deploy:
  provider: pypi
  user: "__token__"
  password: "Your PyPI API token, including the pypi- prefix"

And I realized that for token authorization, one has to modify user field. This was completely surprising for me, because there is no comment about that in the cookiecutter template.

THANK YOU SO MUCH! I've been struggling with this exact same issue for the exact same reason. I may submit a PR to improve the documentation/workflow around this because it's confusing


feat: Schedule blog post

Prerequisites checklist

[x] I have read the contributing guidelines.

What is the purpose of this pull request?
Schedule @captbaritone's blog post for next Tuesday.
Is there anything you'd like reviewers to focus on?
It should be safe to merge this ahead of time because we don't render future posts in production.

Post looks good to me! One thing I noticed is that even though I have an author bio defined in the repo (from my previous post) I don't see it used anywhere in this post. Is that expected?

It should be safe to merge this ahead of time because we don't render future posts in production.

I tested this locally with CONTEXT=production environment variable, and:

The page is rendered and can be opened directly.
It doesn't appear in the list of blog posts on https://eslint.org/blog/, but it does appear in the list of blog posts on https://eslint.org/blog/category/case-studies/.
It appears in sitemap.xml.

Maybe we should fix this before merging?

One thing I noticed is that even though I have an author bio defined in the repo (from my previous post) I don't see it used anywhere in this post. Is that expected?

Author bio is at the end of the blog post:
https://deploy-preview-645--new-eslint.netlify.app/blog/2024/10/code-review-nit-to-ecosystem-improvements/#conclusion

Now that https://github.com/eslint/eslint.org/pull/646 is merged, I think it should be safe to merge this?
We do a nightly data fetch to regenerate the site, so I think this will get automatically published on Tuesday.

Now that #646 is merged, I think it should be safe to merge this?

Yes, I'll merge it now and check the build log and the site.

We do a nightly data fetch to regenerate the site, so I think this will get automatically published on Tuesday.

It should be as there's always some change in the data. I'll doublecheck on Tuesday.

Works fine:
5:25:12 PM: > npx @11ty/eleventy
5:25:13 PM: Ignoring future blog post src/content/blog/2024-10-08-code-review-nit-to-ecosystem-improvements.md
5:25:16 PM: [11ty] Writing _site/feed.xml from ./src/static/feed.njk
...

And https://eslint.org/blog/2024/10/code-review-nit-to-ecosystem-improvements/ doesn't exist yet.

The blog post is published now:
https://eslint.org/blog/
https://eslint.org/blog/2024/10/code-review-nit-to-ecosystem-improvements/


Support for writing pages larger than consumer data buffer size

Closing since fast dispatch2.0 is being developed and may support this. If not, this issue can be re-opened @pgkeller


RTL code breaks layouts with fewer than two items

That's at least my guess. Here's the likely offending line:
                    const firstKey = keyExtractor(data[firstIndex], firstIndex)
                    const secondKey = keyExtractor(data[secondIndex], secondIndex)

The assumption is that the 1 index (whether firstIndex or secondIndex depending on RTL) is valid, which isn't necessarily the case.

Hi. Thanks for reporting. Good catch. I did not like that code but that was the only way to calculate spacing between two items in a correct way. In real world scenario no one would use this component with a single child but still that should be handled.

True that a single item isn't the usual use case. But, I'm testing this out for dynamically generated categories and it's very much possible for a category to have only one item.

Right. I'll fix that as soon as possible

Any ETA on this? Or should I fork it?

Version 0.4.1 just released

Working great. Thank you!


feat: add "mobile" plugin

Description
Add a mobile plugin

The plugin listens for certain events from the mobile app.
The plugin does not load if the app is not running inside the mobile app
The primary action is to do a keep alive ping/pong so the mobile app can know if the app has crashed or didn't load correctly
Includes the walletImported event that can be used in the future to tell the user that their previous mobile app wallet was imported into the new mobile app

Notice

[X] Have you followed the guidelines in our Contributing guide?
[X] Have you checked to ensure there aren't other open Pull Requests for the same update/change?

Pull Request Type

[ ] :bug: Bug fix (Non-breaking Change: Fixes an issue)
[ ] :hammer_and_wrench: Chore (Non-breaking Change: Doc updates, pkg upgrades, typos, etc..)
[X] :nail_care: New Feature (Breaking/Non-breaking Change)

Issue (if applicable)
See https://github.com/shapeshift/mobile-app/issues/11
Risk
Low/None
The plugin won't even load unless it's running in the mobile app
Testing
When running the mobile app in the simulator/emulator, you can see the PING/PONG messages in the logs.
Engineering
When running the mobile app in the simulator/emulator, you can see the PING/PONG messages in the logs. They started automatically, there's no need to take any action.
When running in web,

turn on TRACE logging in Flags screen
check the developer console. You shouldn't see any messages like Sending "pong" response

Operations
Screenshots (if applicable)

@0xdef1cafe / @cjthompson just confirming this doesn't need testing by ops? there is nothing in our section for this PR


Unable to import 3rd party CSS files

Using this template, I have a .vue file that imports the .css in the <script> section.
<template>
  <div id="app">
  <!-- more content here -->
  </div>
</template>

<script>
import Vue from 'vue'
import VueMaterial from 'vue-material'
import 'vue-material/dist/vue-material.min.css'
import './assets/material-icons.css'

Vue.use(VueMaterial)
// More javascript code here
</script>
<style lang="scss" scoped>
h1, h2 {
  font-weight: normal;
}
ul {
  list-style-type: none;
  padding: 0;
}
li {
  display: inline-block;
  margin: 0 10px;
}
a {
  color: #42b983;
}
</style>

The files node_modules/vue-material/dist/vue-material.min.css and ./assets/material-icons.css exists.
But when I run npm run dev, I do not see the CSS files loaded

I have another project that uses similar syntax, and the CSS works fine. This is the webpack.conf.js for that project https://gist.github.com/hanxue/4fe712752319178668eadb326e468322
What changes do I need to make so that the CSS files get loaded?

So is there anything left here?

I've had this problem as well, and it was webpack that was missing style-loader.
https://github.com/webpack-contrib/style-loader


Syntax Issue For GroundSystem python Table Validate Command

I'm trying to get the syntax right for the validation command.  I've been running gdb to look at the contents of the message.  All I get is a cryptic invalid msg length error.  With the following from the cFS-GroundSystem/Guid, instructions, I know I am not interpreting it right.

Originally posted by @JimKaidyNASA in https://github.com/nasa/ECI/issues/42#issuecomment-545620809

I retrieved the latest GroundSystem-master.zip and did a new make.
I sent the command as before and still seeing the Invalid msg length error.

No surprise since there's likely cross versioning going on here.  You'll need to make the command definition match the software.

I'm using what is written in the Description box for CFE_TBL_INACTIVE and ACTIVE.  Where can I find the proper syntax written for the command?

It appears in the debugger that the CFE_TBLE_ValidateCmd is not actually being called.  I've set a breakpoint dwelling on this call from the cfe_tbl_task.c and the function is never entered although the CommandCode is set properly when the error occurs.  Since the CommandCode 4 is being set properly it makes sense that the Invalid msg length error is being thrown in the CFE_EVS_SendEvent since the CFE_TBL_ValidateCmd is actually never executed.

It's not a problem with the syntax you are using.  It's a mismatch between the definition of the packet in the ground system and the definition of the packet in the cFE.  You need to make:
https://github.com/nasa/cFS-GroundSystem/blob/master/Subsystems/cmdGui/ParameterFiles/struct_c_f_e___t_b_l___validate_cmd__t
match whatever it is your version of table services has defined.  Likely in a file similar to what's in the latest version:
https://github.com/nasa/cFE/blob/777f20a12c7592f2048621a9b19eeda919cf8b41/fsw/cfe-core/src/inc/cfe_tbl_msg.h#L553-L569

Ok.  I'll be the first to admit I am unclear about how the packet definition is translated back into code.  I see uint16 and char which are consistent with the code.  I also see comments consistent with the commented code.  Not sure if lp0 and lp1 are lines, p2, p3, etc are spacing, S versus aS some time of string designation,  aa is some type of grouping of features.  All this points to the command window as far as I can tell, which is much more information than is in the code.

The most likely issue is the string size doesn't match your code.  It's the aS'38' line.  Make the number match the size of TableName in CFE_TBL_ValidateCmd_Payload_t.  Or just modify it such that you don't get the error (if reported length is 10, and 20 is expected, add 10 to the number).

Ok that worked.  I modified S38 to S40 since the length discrepancy was off by 2.  I found that I had to do the same thing for the Table Activate command where I modified the value from S38 to S40 in struct_c_f_e_t_b_l__activate_cmd__t.
Is it correct to say that any user who is using cFE 6.5 will have to make these two mods to the GroundSystem parameters to have these (and possibly others) work properly?

Correction aS38 to aS40

Is it correct to say that any user who is using cFE 6.5 will have to make these two mods to the GroundSystem parameters to have these (and possibly others) work properly?

Yes.  In general it's on the user to handle any cross versioning or customization of sizes issues.  The open source community typically focused on getting the system to work with all the current versions for the default configuration.


Unable to unpack a Qihoo app

[] Android Dalvik Unpacker/Unprotector -<EMAIL_ADDRESS>[+] Hunting for com.brazil.vod
[+] 1949 is service pid
[+] 2003 is clone pid
[+] Attempting to detect packer/protector...
[] Nothing special found, assuming Bangcle...
[+] Unpacked odex found in memory!
[+] Attempting to dump memory region 0xb7781000 to 0xb7782000
[!] pread seems to have failed!
[!] An issue occured trying to dump the memory to a file!
I'm using Nox Emulator to do this since I don't have a rooted device.

Nox emulator? Can you provide a link for that?
Can you please also upload the file in question?

I'd also suggest doing a git pull because it appears you're running some code that is minimally 3 years old;
https://github.com/strazzere/android-unpacker/commit/97ad55d700068c6b0f3880f3ee87414ee67f497a

Ok, so, it does look fairly similar to issue #42 - however I won't close this issue until you can rerun the new code against it.
I do think that this is just, the same packer and will complain due to mprotect usage about i/o issues.

Ok cool, seem to be the same issue as #42 -- it's likely do to mprotect. There are some suggestion in that issue on how to handle this, but for the time being I'm going to close this one since it's a duplicate.


EIP1559/legacy artifacts

Component
Forge
Have you ensured that all of these are up to date?

[X] Foundry
[X] Foundryup

What version of Foundry are you on?
forge 0.2.0 (70f4fb5 2022-11-02T00:05:06.592613Z)
What command(s) is the bug in?
forge script
Operating System
macOS (Apple Silicon)
Describe the bug
When developing parseJson helpers to automatically parse forge-script artifacts:

Seeing some artifacts from a chain that I know doesn't support EIP1559 and it has the gas field without the gasPrice, as you would expect from a LegacyTransaction. It could be that their RPC returns the info incorrectly, so there is nothing forge can do.

Basically, I deployed to MilkomedaC1, which is not EIP1559 but got EIP1559-type artifacts.

@odyslam What exactly is the issue here? This sounds like an issue with the MilkomedaC1 RPC and not forge?

@mds1, if I remember correctly, for some reason, several nonERC1559 chains produced ERC1559 artifacts. I will need to investigate again.

Marking as stale, this has likely been resolved over time. If this is not the case feel free to re-open.


Wrap require(express) in express constructor in examples/server.js.

From: https://github.com/rackt/redux/issues/955
Wrapped each express constructor in parentheses to keep express from showing when running depcheck.  I did notice the examples have a lot of unused deps.  Should I go ahead and remove them?
Screenshot of some of the unused deps:

Please don't remove dependencies. :-)
That depcheck didn't realize some of them are dependencies isn't a good enough reason to remove them.

@gaearon Figured it was worth asking.  Went ahead and changed the express constructor syntax as per https://github.com/rackt/redux/issues/955.

:+1: thanks!


auth: Fix sign out for proxy auth providers

Expected Behavior
For any of the proxied auth providers the logout should either just work, link to the logout page, or be disabled.
Actual Behavior
The sign out button does nothing.
Steps to Reproduce

Set up any of the proxied auth providers and sign in.
Head to the user settings page and select "Sign Out" in the kebab menu on the profile card.

Context
#11954

We are using the oauth2-proxy container for authentication. Seems like the container exposes an endpoint /oauth2/sign_out - this URL is used to clear the session cookie. Is it possible in the current implementation of backstage to set this button to hit this URL?

I don't think the logout URL is oauth2 proxy is something that's possible to configure, so no need to make it configurable on our end either tbh. All we really want to do is to make sure the page navigates there when the logout button is clicked.

Hi @justinjao, you are very welcome to give it a go 👏

Hi @jhaals - thanks for getting back to me! I'll try and give it a shot. Just managed to finish setting it up locally (I think).
Currently trying to read through the documentation regarding proxy auth providers above, and how exactly to set this up, so that I can reproduce the issue. I'm also reading through setting it up with Google IAP, and if I understand correctly so far, I'll need to set up my own IAP account for this, so planning on trying that for now.
If I misunderstood anything, do let me know. Otherwise, I'll just carry on for now. 🙂

Sorry I haven't followed up - got caught up with other commitments (namely university exams!).
If it's still free, I'm still very much interested in contributing. I'm hopeful I'll have some time next week to revisit it (I have a bit of a winter break, after exams).

Not sure if this is a separate issue or not, but there is a second way to sign out in Settings->Authentication Providers-> "Sign Out" button.  This seems to have a different behavior than the kebab menu on the Settings->General->Profile card, which does seem to be working for me (Okta).
The Sign Out button in the Authentication Providers tab seems to be trying to send a refresh token to Okta and I am not sure if that is the correct behavior or not.

Any news on this?

Is this still an issue that can be picked up? Looking to be a first time contributor 😄

@spark72018 it's all yours! I don't think any progress has been made on this yet!

@spark72018 Yes, please feel free to work on it! I've been caught up with other responsibilities, and realistically won't be able to work on it anytime soon. Thank you for picking it up, and good luck!

Assigned!

@Rugvip
how about this for a solution that only redirects to the signing page if the user logs out of signinpage provider?
like if a user is logged in with Google and GitHub but the sign-in provider is Github, and the user sign out of Google does nothing but if the user logs out of GitHub then logs out and redirects to sign-in page.

@npiyush97 that's a slightly different issue but it also makes sense, let's discuss it in the PR. This issue is about actually performing the logout action when using a proxies auth provider, which requires navigation to a particular logout URL provided by the proxy.

Trying to setup backstage with oauth2-proxy connected to a keycloak, I'm able to login without problems, but the sign out button on the profile does nothing at all and just refresh the page.
This is the log I get from backstage when clicking on the sign out button:
{"level":"info","message":"::1 - - [13/Feb/2024:17:12:21 +0000] \"GET / HTTP/1.1\" 200 - \"-\" \"Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/121.0.0
.0 Safari/537.36\"","service":"backstage","type":"incomingRequest"}                                                                                {"level":"info","message":"::1 - - [13/Feb/2024:17:12:21 +0000] \"GET /static/vendor.c7c17463.css HTTP/1.1\" 200 - \"-\" \"Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML,
like Gecko) Chrome/<IP_ADDRESS> Safari/537.36\"","service":"backstage","type":"incomingRequest"}                                                                                {"level":"info","message":"::1 - - [13/Feb/2024:17:12:21 +0000] \"GET /favicon.ico HTTP/1.1\" 200 - \"-\" \"Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chr
ome/<IP_ADDRESS> Safari/537.36\"","service":"backstage","type":"incomingRequest"}                                                                                {"level":"info","message":"::1 - - [13/Feb/2024:17:12:21 +0000] \"GET /api/catalog/entities/by-name/User/default/backstageadmin HTTP/1.1\" 404 237 \"-\" \"node-fetch/1.0 (+https://gi
thub.com/bitinn/node-fetch)\"","service":"backstage","type":"incomingRequest"}                                                                                {"component":"token-factory","level":"info","message":"Issuing token for user:default/backstageadmin, with entities user:default/backstageadmin","plugin":"auth","service":"backstage"
,"type":"plugin"}                                                                                {"level":"info","message":"::1 - - [13/Feb/2024:17:12:21 +0000] \"GET /api/auth/oauth2Proxy/refresh HTTP/1.1\" 200 677 \"-\" \"Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/<IP_ADDRESS> Safari/537.36\"","service":"backstage","type":"incomingRequest"}

I'm doing something wrong ? because I don't see anywhere it sends a logout signal to the oauth2-proxy or clear the tokens, it just ask for a refresh to the proxy.

Hi @koshrf, this is exactly what this issue is about, thanks for letting us know that this is happening to you as well.
We're always looking for contributors, would you be interested in submitting a pull request 🙂 ?

Hi @koshrf, this is exactly what this issue is about, thanks for letting us know that this is happening to you as well. We're always looking for contributors, would you be interested in submitting a pull request 🙂 ?

Hi, sorry, I'm not a TS/React/JS developer, I can't fix this kind of bug, I'm on the devops side with an extensive infrastructure that I could use to test if anyone provides a fix to this.

@koshrf can you test with this #23480

@npiyush97 could you perhaps create a separate issue for the bug you're aiming to fix? It's not related to this issue

@npiyush97 could you perhaps create a separate issue for the bug you're aiming to fix? It's not related to this issue

Yes, i know just remainder to think of this issue.
As you said this does not log the user out of the app just removes user credentials thus user can linger in the app in settings as soon comes out of API,home or catalog network goes mental with refresh request which can be some issue ?.
thinking of how to fix this

As backstage provides multiple auth so if user logs out of their auth-provider (1st auth they logged in with) redirect to the login page as general setting does.
2)create a global state or kind of context that keep track of all auth provider user is logged in with if the state is empty which user not logged in with anything so redirect to login page.
I'm in favour of 1st option. 2nd sound handful if someone wants they can implement themselves .
Do you have anything other in your mind ?
Now i understand issue 😜?

@Rugvip Okay, got it.

Hi @Rugvip! You could assign the issue on me I'll tackle it on the week.

Hi  @freben @Rugvip
"@backstage/plugin-user-settings": "^0.8.7"
we are using okta sign in and on click of sign out from "General tab" or "Authentication Providers tab" its redirecting to home page, please let me know how to fix this

@vinaykv23 I think that actually your issue is something separate to this thinking about it a little bit.
I think that it's to do with the auto prop that you're using, which means that when you click signout, you don't have another page to go to as it's going to try and automatically sign you back in again as that's what the auto prop does.
I would encourage you to open up a separate issue here, as I think that this is a bit of an unexpected corner case that we didn't think about.


[WIP][fix] gws seed issues

Coverage increased (+0.3%) to 79.645% when pulling ccc6dc62e846ce3145b6e4d1d9389ed7741b78d6 on sunny4381:features/gws-seeds2 into 679804ea63f947ff4e7e2d304dc6ea9c03b428dc on shirasagi:master.

Coverage increased (+0.02%) to 79.691% when pulling 15d229a4efc16606629e6e3c14ff77670e746e99 on sunny4381:features/gws-seeds2 into 1de4ac5147ec423474fa98a3d359526c1f2ecaaf on shirasagi:master.


CAMPD Home Page- 508 issue

Finding

Screen
Finding
WCAG 2.0 Standard(s)

Home Page
Skip nav is anchored past unique informational text on the home page https://campd-dev.app.cloud.gov/. It should be anchored right above the text ‘Your resource for emissions, compliance, and allowance data.’
2.4.1

Context

Tested on all pages, skip nav is functional and correctly anchored


Enhance faster_whisper Engine

Hi, developers!
This pull request introduces the following improvements and fixes:

Updated NVIDIA CUDA Container: The version of the nvidia/cuda container has been updated from 11.7.0 to 11.7.1. This was necessitated as version 11.7.0 is no longer available.

Modifications in faster_whisper Engine:

The model_converter function within the engine has been enhanced. Previously, the function had hardcoded float16. This has now been replaced with a variable that defaults to float16, allowing for greater flexibility.
In core.py, the environment variable ASR_QUANTIZATION has been added. This allows users to specify various quantization levels including float16, int16, int8, int8_float16, and int4. However, it should be noted that there seems to be an issue with the int4 mode which may require further investigation.

Regarding issue #127, if there's an inherent bug in the original codebase, I would prefer to remove the MAPPING. Instead of:
if torch.cuda.is_available():
    model = WhisperModel(model_path, device="cuda", compute_type=MAPPING[model_quantization])
else:
    model = WhisperModel(model_path, device="cpu", compute_type="int8")
model_lock = Lock()

I suggest the following:
model = WhisperModel(model_path, device="cuda", compute_type=model_quantization)

PS. My PR will definitely conflict with #117.

The diff is kinda messed up for some Git reason I don't understand. Using this to compare to main after 1.2 release.

@ayancey hi! Thanks, yeah, seems codebase was updated. I'll fix conflicts.

Here's my attempt at benchmarking and comparing between @ahmetoner's latest release (1.2.0) and this PR. I bumped the CUDA version on your fork so it would be an even comparison.
Tests done with 23 second audio file using small model and faster_whisper backend. GPU is NVIDIA GeForce GTX 1650.

Branch
CUDA ver
mem before trials
GPU mem before trials
mem after trials
GPU mem after trials
Avg time (seconds)

1.1.1
11.8.0
1.743GiB
1142MiB
2.782GiB
1452MiB
1.82

1.2
11.8.0
613.2MiB
1144MiB
1.606GiB
1454MiB
1.84

EvilFreelancer
11.8.0
1.75GiB
1142MiB
2.808GiB
1452MiB
1.93

I don't understand it, but it looks like Ahmet fixed the problem you referred to in #127. But I couldn't find any improvements in GPU or CPU memory.

@ayancey hi! Thanks, yeah, seems codebase was updated. I'll fix conflicts.

So it sounds like the model conversion is no longer an issue, but we still want to let users choose their quantization?

So it sounds like the model conversion is no longer an issue, but we still want to let users choose their quantization?

I  think it's a good idea, in any case we may keep float16 as default value. For example i use int8 version of large-v2 model for my projects.

Awesome. Once you fix the conflicts I can bug Amet to merge this. I'm really excited to start playing around and comparing the different options.

@ayancey hi! I've updated my PR, you may try to add ASR_QUANTIZATION env option with one of modes described on this page: https://opennmt.net/CTranslate2/quantization.html

👏 👏


OCPBUGS-16567: Bump library-go to remove dependency on goproxy

Bump library-go to remove dependency on goproxy - it should be removed from go.sum.
cc @openshift/storage

/lgtm


Does not work when nested

I have this weird case:
  render: ->

      <Row>
        <Input
          hasFeedback
          required
          name  =<EMAIL_ADDRESS>          label = {t("Password")}
          value =<EMAIL_ADDRESS>        >
          <InputPassword
            required
            zxcvbn    = {zxcvbn}
            className =<EMAIL_ADDRESS>            onChange  = {@_handlePasswordChange}
          />
        </Input>
      </Row>
      <Row>
        <Input
          hasFeedback
          required
          name  =<EMAIL_ADDRESS>          label = {t("Repeat Password")}
          help  = {@_getRepeatPasswordHelp()}
          value =<EMAIL_ADDRESS>        >
          <InputPassword
            required
            zxcvbn    = {false}
            infoBar   = {false}
            className =<EMAIL_ADDRESS>            onChange  = {@_handleRepeatPasswordChange}
          />
        </Input>
      </Row>

where the Input is from require('react-bootstrap') and InputPassword is from require('react-ux-password-field') ...
Bootstrap's Input allows it to have more inputs nested. But that does not go well with formsy-react and is probably the cause of https://github.com/christianalfoni/formsy-react/issues/110

Hi @binarykitchen ,
You have to provide a Formsy.Form element too:
<Formsy.Form>
        <MyInput
          hasFeedback
          required
          name  =<EMAIL_ADDRESS>          label = {t("Password")}
          value =<EMAIL_ADDRESS>        >
</Formsy.Form>

I already do in a parent element.

It has to be inside the same component :-)
In React 0.14 we get parent-child context which will fix this, but currently it is not possible.

ah, that is very unfortunate :(

You are the first person to point it out actually ;-)
We are using Formsy on a huge project with a lot of forms and have not met that issue. That said, it would be nice to have, and it will when React 0.14 is released.

alright, i ll have to search for another react form validation library for now or go with the native setCustomValidity() ...

Jup, the important thing is that you find something that works for you :-)

Just to make sure there was no misunderstanding here :-) :
This works:
var MyForm = React.createClass({
  render: function () {
    return (
      <Formsy.Form>

          <MyInput/>

             <MyInput/>

      </Formsy.Form>
    );
  }
});

But this does not until React 0.14:
var MyFormContent = React.createClass({
  render: function () {
    return (

          <MyInput/>

             <MyInput/>

    );
  }
});

var MyForm = React.createClass({
  render: function () {
    <Formsy.Form>
      <MyFormContent/>
    </Formsy.Form>
  }
});

Great news. I have just encountered the problem as well with the "multi-step/wizard" control I am building (each step as its own control). formsy is fantastic BTW really fills a much needed gap IMO

Same here :(

React 0.14 is now in BETA and new formsy version is right around the corner. Will release some test info very soon.


Revert "Prepare release for Azure.ResourceManager.LoadTestService"

Reverts Azure/azure-sdk-for-net#31956

API change check
APIView has identified API level changes in this PR and created following API reviews.
Azure.ResourceManager.LoadTestService


All The Get Alls

In testing preload_all with Flipper::Cloud, I found that the memoizing and caching adapters weren't working correctly with get_all (which preload_all uses). Several things were subtly not right causing extra net/http calls. I added several specs that verify the number of network calls and tested externally with a few apps I control. This also adds get_all to all the adapters flipper supports out of the box. This ensures that when possible preload_all and get_all do the fewest network calls.
There is some funny business with caching and get_all. The trick with get_all and caching is you don't know the features so you can't do a get_multi for all features. This left two obvious options:

wrap the entire get_all call with its own cache fetch block.
add an extra network call to avoid calling get_all more than necessary when using a caching adapter.

Option 1 meant get_all would be 1 network call which was dope. The downside was it would not share the primed caches from get and get_multi. Additionally, it would mean that all features would need to fit in a single cache value (usually 1MB with memcached). Probably fine, but I didn't want to make assumptions.
Option 2 was to do an unless exists get_all key. If the key was present, then we are moderately sure that both the set of feature keys and each feature is cached, so the cache adapters do at least 2 network calls (get the set of feature keys and then get_multi all the individual feature cache values). The upside is this shares the per feature cache values with get and get_multi. Another upside is that because the cache is per feature, having a lot of features won't overflow a single value like option 1. The downside of this is a minimum of 3 network calls. I guess I'm assuming that cache calls are super fast, so 3 small ones that share between many adapter methods is better than potentially 1 big one that doesn't share.

Looks like rails 3.2 failures... I'll look at them, get this merged and release 0.11

It seems unless_exist wasn't added until rails 4, which is why rails 3 tests are failing.
xref https://github.com/rails/rails/commit/b5005b6259144eeea5b903d659f54bd8a0343d25


NavigationView Navigate throw System.NullReferenceException

Describe the bug
Sample code
MainWindow _mainWindow = App.GetService<MainWindow>() as MainWindow;
_mainWindow.navView.Navigate(typeof(SomePage));

Call Stack: Wpf.Ui.Controls.Navigate->NavigateInternal-.UpdateContent
To Reproduce
Just try to use Navige function of NavigationView
Expected behavior
Should not throw exception
Screenshots
No response
OS version
windows 10
.NET version
.net 6
WPF-UI NuGet version
3.0.0-preview.7 but it is the same in previous 3.0.0 previews
Additional context
No response

Hi,

You should learn how .Net Dependency injection with WPF works.
If you go to app.xaml you'll see that the service for "MainWindow" is add as an implementation of "INavigationWindow"
services.AddScoped<INavigationWindow, MainWindow>();
That being said if you want to get an implementation of a service you'll have to get it through a Factory pattern (so you can use it for other Windows which gives you added scalability),
or simply
MainWindow saleWindow = App.GetService<INavigationWindow>() as MainWindow;

Hope i've helped.

I was looking at Gallery example where implementation was with services.AddSingleton<IWindow, MainWindow>();

My bad, i'm still using the 2.1 version,
but after going through the code of 3.0 preview version,
I found that this may not be a bug,
because the IWindow or the MainWindow or NavigationView them selves doesn't have a navigation function,
rather the MainWindow (you can see in it's constructor) is Subscribing to navigation changes through an injected navigation service,
public MainWindow(         MainWindowViewModel viewModel,         ->INavigationService navigationService,<-         IServiceProvider serviceProvider,         ISnackbarService snackbarService,         IContentDialogService contentDialogService     )
this service then wraps the NavigationView control (navView in your case)
navigationService.SetNavigationControl(NavigationView);
then NavigationView control uses this function to retrieve page instances and view models
NavigationView.SetServiceProvider(serviceProvider);
So, to navigate you need this navigation service either by injecting to a constructor or using the service provider to get it
_navigationService.Navigate(typeof(SomePage));
My advice is still on you need to learn how ioc di works.
Thanks.

I still have a problem but I'm not sure if it is possible.
I need to user UserControl as I want to use the PopUp from Hardcodet.NotifyIcon. In it I want to use NavigationView and to be able to navigate to specific Item. I can't inject in the UserControls constructor so right after creating the PopUp I do
navigationService.SetNavigationControl(nvSample);
nvSample.SetPageService(pageService);
_navigationService= navigationService;

then I call _navigationService.Navigate(pageType); but I get System.NullReferenceException: 'Object reference not set to an instance of an object.'  as _pageService in _navigationService is null. Otherwise if I don't navigate from code the PopUp works fine.

try this
        NavigationView.Loaded += (_, _) =>
        {
            var navigationService = ServiceManager.Services.GetService<INavigationService>()!;

            navigationService.SetNavigationControl(NavigationView);
            NavigationView.SetServiceProvider(ServiceManager.Services);
        };

Tried
nvSample.Loaded += (_, _) =>
            {
                var navigationService = App.GetService<INavigationService>();
                navigationService.SetNavigationControl(nvSample);
                nvSample.SetServiceProvider(App.GetService<IServiceProvider>());
                _navigationService = navigationService;
            };

It does not work.

Tried 试图
nvSample.Loaded += (_, _) =>
            {
                var navigationService = App.GetService<INavigationService>();
                navigationService.SetNavigationControl(nvSample);
                nvSample.SetServiceProvider(App.GetService<IServiceProvider>());
                _navigationService = navigationService;
            };

It does not work.它不工作。

Are you sure you registered the corresponding page in the services

Tried
nvSample.Loaded += (_, _) =>
            {
                var navigationService = App.GetService<INavigationService>();
                navigationService.SetNavigationControl(nvSample);
                nvSample.SetServiceProvider(App.GetService<IServiceProvider>());
                _navigationService = navigationService;
            };

It does not work.

Are you sure you registered the corresponding page in the services

Yes I did and it is not the pages that cause the problem. It seems that there is no page service.

Yes I did and it is not the pages that cause the problem. It seems that there is no page service.

Oh, I might know why SetServiceProvider did you get a new ServiceProvider? Not the one you built in the first place?

Yes I did and it is not the pages that cause the problem. It seems that there is no page service.

Oh, I might know why. SetServiceProvider did you get a new ServiceProvider? Not the one you built in the first place?

No, I can't change the constructor of the popup so how could I get a new one?


kubelet: Move KillContainer to container runtime.

Following https://github.com/GoogleCloudPlatform/kubernetes/pull/6039
@vmarmol @dchen1107

Options to handle pod infra container:

Let docker container runtime to recreate the pod infra container and then restart the whole pod in RunContainer():
Something like

func dockertools.RunContainer() {
    if needToRecreatePodInfraContainer {
        killAndRecreatedPodInfraContainer()
        for each container is running pod {
            killContainer()
        }
    }
    runContainer()
}

Pros: No additional logic for kubelet, kubelet just need to compare the running containers with their desired states, the pod infra container will be recreated at the first run of RunContainer() if it's necessary.
Cons: Need container runtime to manage the refs, readiness.

Similiar to 1), but only "MARK" the running containers as invalid. So in the kubelet loop, it can kill and restart it.

func dockertools.RunContainer() {
    if needToRecreatePodInfraContainer {
        killAndRecreatedPodInfraContainer()
        for each container is running pod {
            container.Hash = SomeInvalidHash
        }
    }
    runContainer()
}

Pros: No additional logic for kubelet. Also no ref, readiness management for the container runtime.
Cons: Need the running pod as an input for the RunContainer() so we can mark them.

Let kubelet handle the pod infra container in a seperate function, which will do something special if the container runtime is docker:

switch container runtime choice {
    case docker:
        if needToRecreatePodInfraContainer {
            killAndRecreatedPodInfraContainer()
            re-listing the running pod
        }
    case rocket: no-op
    case other: ...

Pros: The interface of the container runtime can be simpler, and it does not need to deal with ref, readiness, etc.
Cons: Added some additional code path for kubelet to deal with different container runtime.
I think 2) or 3) is better than 1).
@vmarmol

I'm late to the party, but I have a question @vmarmol @yifan-gu does a pod running on rocket not require an infra container?

@pmorie AFAIK Rocket creates a top-level "container" with namespaces and then runs other containers within that container. We'd configure the top-level as we do today for the pod infra and run the others similar to what we do today in Docker.

@pmorie vmarmol
So in rocket, all the containers (a.k.a "apps" in rocket term) are launched together to form a pod. These apps are all managed by a PID 1 process within the same namespaces. Each app can have their dedicated resource requirements, and the whole pod can have a global resources requirement as well.
No additional pod infra container is necessary.
/cc @jonboulle

Not sure why I'm being CCed (I think Yifan is explaining things pretty well - pods are the fundamental execution unit in Rocket so it should be able to manage them natively without futzing around with infra containers), but let me know if there's anything I can clear up :-).

Is this PR still relevant given our other discussions?

@vmarmol So if we decide to take the preparePod approach now, then we can put off this PR.

Closing since we're moving elsewhere. Feel free to re-open or re-send when we get here.


auto-fix generates invalid jsx

with two rules from eslint-plugin-react enabled, i get invalid jsx when either selecting "Fix all auto-fixable problems" or with Ctrl+S and "source.fixAll.eslint": "explicit".
see this repo for a minimal reproduction: https://github.com/stefanprobst/issue-eslint-react (i did check in a fresh vscode install with only the eslint extension installed)
steps:

clone repo
run pnpm install
open src/app.tsx in vscode and press Ctrl+S
see invalid jsx

some observations:

running pnpm run lint --fix from the terminal does not have this problem. the resulting (correct) jsx is:<button aria-disabled={true} className="test">Test</button>

after Ctrl+S in vscode, the resulting jsx is:<button aria-disabled className="test"={true}>Test</button>

Dups #1745
Although different rules there was an underlying problem with generating all fixes which got solved in #1745

@dbaeumer when do you expect the fix for this issue to be released? thanks


Resnet50 pretrained model for fine tuning, the model is not convergence

Hi,
I'm using pretrained Resnet50 model for my own data's training.  The model is not convergence even the train accuracy looks good shown by the log, and validation loss and accuracy is not improved during the training phase.
I also test the trained model on training and val set, the accuracy is very pool(see below)
And I try the tensorflow 1.15.0 and 2.4.0 different version, the problem is the same. Then I just change to VGG model, it works fine(no convergence problem). So could help on this issue?
My code is :
`
base_model = tf.keras.applications.ResNet50(include_top=False)
base_model.trainable = False

model = tf.keras.models.Sequential([
    base_model,
    #tf.keras.layers.Conv2D(filters=num_cat, kernel_size=1),
    tf.keras.layers.GlobalAveragePooling2D(),
    tf.keras.layers.Dense(units=num_cat)
])
model.summary()
optimizer = tf.keras.optimizers.RMSprop(learning_rate=0.001)
loss_func = tf.keras.losses.CategoricalCrossentropy(from_logits=True)
eval_func = tf.keras.metrics.CategoricalAccuracy()

model.compile(
    optimizer=optimizer,
    loss=loss_func,
    metrics=[eval_func]
)
history = model.fit(train_ds, epochs=10, validation_data=val_ds)
model.save_weights('./checkpoints/final')`

And the training log is:

Train on 156 steps, validate on 39 steps
Epoch 1/10
156/156 [==============================] - 183s 1s/step - loss: 1.8214 - categorical_accuracy: 0.5048 - val_loss: 3.5411 - val_categorical_accuracy: 0.0386
Epoch 2/10
156/156 [==============================] - 33s 211ms/step - loss: 0.4409 - categorical_accuracy: 0.8931 - val_loss: 3.6663 - val_categorical_accuracy: 0.0386
Epoch 3/10
156/156 [==============================] - 34s 219ms/step - loss: 0.2582 - categorical_accuracy: 0.9365 - val_loss: 3.8821 - val_categorical_accuracy: 0.0386
Epoch 4/10
156/156 [==============================] - 32s 203ms/step - loss: 0.1666 - categorical_accuracy: 0.9550 - val_loss: 3.9013 - val_categorical_accuracy: 0.0386
Epoch 5/10
156/156 [==============================] - 31s 201ms/step - loss: 0.1212 - categorical_accuracy: 0.9630 - val_loss: 4.2440 - val_categorical_accuracy: 0.0386
Epoch 6/10
156/156 [==============================] - 31s 201ms/step - loss: 0.0826 - categorical_accuracy: 0.9759 - val_loss: 4.2431 - val_categorical_accuracy: 0.0386
Epoch 7/10
156/156 [==============================] - 31s 198ms/step - loss: 0.0648 - categorical_accuracy: 0.9807 - val_loss: 4.3009 - val_categorical_accuracy: 0.0514
Epoch 8/10
156/156 [==============================] - 32s 205ms/step - loss: 0.0573 - categorical_accuracy: 0.9823 - val_loss: 4.3420 - val_categorical_accuracy: 0.0386
Epoch 9/10
156/156 [==============================] - 31s 196ms/step - loss: 0.0548 - categorical_accuracy: 0.9839 - val_loss: 4.4843 - val_categorical_accuracy: 0.0386
Epoch 10/10
156/156 [==============================] - 31s 200ms/step - loss: 0.0478 - categorical_accuracy: 0.9887 - val_loss: 4.7390 - val_categorical_accuracy: 0.0386
Run inference on training data and validation data:
156/156 [==============================] - 35s 227ms/step - loss: 4.7357 - categorical_accuracy: 0.0386
39/39 [==============================] - 11s 279ms/step - loss: 4.7326 - categorical_accuracy: 0.0386
Train Loss: 4.735676199961931; Train Acc: 0.03858520835638046
Val Loss: 4.732603843395527; Val Acc: 0.03858520835638046

@gganduu
This issue is more suitable for TensorFlow Models repo. Could you Please post it on Tensorflow Models repo from here. Thanks!

@UsharaniPagadala， already posted.

@gganduu
To avoid duplicates can you please close this and subscribe/follow that issue posted in TensorFlow Models repo ?
Thanks!

Sure, thank @UsharaniPagadala