Animate sign-in pages

Details

Add animations to some sign-in pages.
Fixed Issues

$ https://github.com/Expensify/App/issues/18262
PROPOSAL: https://github.com/Expensify/App/issues/18262#issuecomment-2019979851
Tests

Enable 2FA for the account
Sign out
Open any previous magic link in a new tab (with correct environment URL)
Verify Here is your magic code page appears with the magic code animation
Sign in
Open the magic link in a new tab
Verify Two-factor authentication required page appears with the safe animation
Sign in with 2FA code
Verify Abracadabra, you are signed in! page appears with animation

[x] Verify that no errors appear in the JS console

Offline tests

NA
QA Steps

Enable 2FA for the account
Sign out
Open any previous magic link in a new tab (with correct environment URL)
Verify Here is your magic code page appears with the magic code animation
Sign in
Open the magic link in a new tab
Verify Two-factor authentication required page appears with the safe animation
Sign in with 2FA code
Verify Abracadabra, you are signed in! page appears with animation

[x] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:

[x] I verified that all the inputs inside a form are aligned with each other.
[x] I added Design label and/or tagged @Expensify/design so the design team can review the changes.

[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: mWeb Chrome

https://github.com/Expensify/App/assets/113963320/2d5b809e-e49d-4af8-9b73-4eeb5c069da0
https://github.com/Expensify/App/assets/113963320/8586439e-a704-45e9-aaae-8a8c3159b60e
https://github.com/Expensify/App/assets/113963320/3688567e-9419-4868-8c57-2d5c8fbf8633

iOS: mWeb Safari

https://github.com/Expensify/App/assets/113963320/38de4155-d30e-419a-96f7-fd1949a1e58d
https://github.com/Expensify/App/assets/113963320/4926759e-279f-4114-aea9-b1b3d8056638

MacOS: Chrome / Safari

https://github.com/Expensify/App/assets/113963320/95d77cf5-ee0e-4592-b3bd-70907708f8c5
https://github.com/Expensify/App/assets/113963320/23d20c88-fbaa-4583-a19a-43ed30328423
https://github.com/Expensify/App/assets/113963320/ce68d533-0a89-45e0-a078-dfd993e1bffb

Looking good from a design perspective! cc @grgia for a second set of eyes too.

@shawnborton my only comment is that the magic ball feels slightly off center, but if you think it looks fine as is, I think we're good to go

Ooo that's fair. I don't feel too strongly, we could pull it over using some styles but hopefully we don't need to make a new animation!

Got it - this one doesn't bother me too much, I'd be fine leaving as-is.

Reviewer Checklist

[ ] I have verified the author checklist is complete (all boxes are checked off).
[ ] I verified the correct issue is linked in the ### Fixed Issues section above
[ ] I verified testing steps are clear and they cover the changes made in this PR

[ ] I verified the steps for local testing are in the Tests section
[ ] I verified the steps for Staging and/or Production testing are in the QA steps section
[ ] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[ ] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[ ] I checked that screenshots or videos are included for tests on all platforms
[ ] I included screenshots or videos for tests on all platforms
[ ] I verified tests pass on all platforms & I tested again on:

[ ] Android: Native
[ ] Android: mWeb Chrome
[ ] iOS: Native
[ ] iOS: mWeb Safari
[ ] MacOS: Chrome / Safari
[ ] MacOS: Desktop

[ ] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
[ ] I verified proper code patterns were followed (see Reviewing the code)

[ ] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[ ] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[ ] I verified that comments were added to code that is not self explanatory
[ ] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[ ] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
[ ] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[ ] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
[ ] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[ ] I verified the JSDocs style guidelines (in STYLE.md) were followed

[ ] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[ ] I verified that this PR follows the guidelines as stated in the Review Guidelines
[ ] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
[ ] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[ ] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[ ] If a new component is created I verified that:

[ ] A similar component doesn't exist in the codebase
[ ] All props are defined accurately and each prop has a /** comment above it */
[ ] The file is named correctly
[ ] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[ ] The only data being stored in the state is data necessary for rendering and nothing else
[ ] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[ ] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[ ] All JSX used for rendering exists in the render method
[ ] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[ ] If any new file was added I verified that:

[ ] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[ ] If a new CSS style is added I verified that:

[ ] A similar style doesn't already exist
[ ] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)

[ ] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[ ] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[ ] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[ ] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[ ] If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:

[ ] I verified that all the inputs inside a form are aligned with each other.
[ ] I added Design label and/or tagged @Expensify/design so the design team can review the changes.

[ ] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[ ] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[ ] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

@tienifr, could you check if animation is working on Here is your magic code in Safari mWeb? For me it's just a static image, even though other animations are displayed correctly
https://github.com/Expensify/App/assets/9059945/c05cc50f-09c4-4cdf-9ef8-89adf446f667
Or 1:02 on iOS: mWeb Safari video

@tienifr, sure thing!
Could you please pull the latest changes from main so I can re-test this?

For the magic code illustration, I thought it was just laggy on Safari - I didn't realize it doesn't play at all on iOS. Is that what's going on here?

For the magic code illustration, I thought it was just laggy on Safari - I didn't realize it doesn't play at all on iOS. Is that what's going on here?

@roryabraham could you help fill me and @shawnborton in?

Ah okay 👍

No further comments from me

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

🚀 Deployed to production by https://github.com/mountiny in version: 1.4.83-3 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


Implement Backend for Instance

It seems like we could have one less type exposed by the API if we just make Instance to be that object that implements the hal::Backend trait.

I'd like to try this. Expect updates :)

So, I think I've hit the first, and possibly only larger question for implementing this:
hal::Backend has some serious bounds: 'static + Sized + Eq + Clone + Hash + fmt::Debug + Any + Send + Sync. Implementing these for the empty enum Backend {} was of course trivial, but it a bit more involved with the instances.
The question is, do we want to relax the bounds a bit (possibly causing internal and external breakage), or do we want to Arc the underlying raw instances?
In the vulkan backend, the raw instance is already wrapped in an Arc, which simplified implementing Clone + Eq + Hash, but as I continued into doing the same change for the metal backend, I found that I would need to add the Arc around GfxManagedMetalLayerDelegate to keep it's resource management correct, possibly causing overhead. Is this overhead something gfx can live with?
Thanks!

One more thing: the gl backend is experiencing a bit of a cfg hell, and this PR makes it worse. I think I could slap enough cfgs in there to make it work, but the price may be a bit high.
Originally, the enum Backend {} was just unconditionally available, but after moving the Backend trait to Instance, we must ensure that one of the 2 possible gl instances is available everywhere we want to use the Backend trait...

Thank you for taking a stab at this!
Seeing the issues you raised, I'm starting to think that maybe it's not the best idea to do it at all? When stuff depends on B: Backend we don't want to imply any relation/requirement about Instance in particular.
Do you think you could change the direction of this PR and just add type Instance to Backend with the corresponding trait Instance somewhere?


Android build fails with Duplicate class errors

Following the instructions and attempting to build an app for Android TV fails with duplicate class errors:
...
Duplicate class com.theoplayer.mediacodec.event.MediaReadyState found in modules jetified-theoplayer-android-dist-sdkdemo-3.5.0-unifiedAndroid-release-runtime (theoplayer-android-dist-sdkdemo-3.5.0-unifiedAndroid-release.aar) and jetified-unified-3.6.1-runtime (com.theoplayer.theoplayer-sdk-android:unified:3.6.1)
     Duplicate class com.theoplayer.mediacodec.event.ProgressEvent found in modules jetified-theoplayer-android-dist-sdkdemo-3.5.0-unifiedAndroid-release-runtime (theoplayer-android-dist-sdkdemo-3.5.0-unifiedAndroid-release.aar) and jetified-unified-3.6.1-runtime (com.theoplayer.theoplayer-sdk-android:unified:3.6.1)
     Duplicate class com.theoplayer.mediacodec.event.ResizeVideoEvent found in modules jetified-theoplayer-android-dist-sdkdemo-3.5.0-unifiedAndroid-release-runtime (theoplayer-android-dist-sdkdemo-3.5.0-unifiedAndroid-release.aar) and jetified-unified-3.6.1-runtime (com.theoplayer.theoplayer-sdk-android:unified:3.6.1)
...

This seems to happen because the library is both importing dependencies from the local libs folder as well as Maven. And since a newer version has been published to maven, this is causing issues.
build.gradle
dependencies {
  //noinspection GradleDynamicVersion
  implementation "com.facebook.react:react-native:+"  // From node_modules
  implementation "com.theoplayer.theoplayer-sdk-android:unified:${safeExtGet('THEOplayer_sdk', '+')}"
  implementation "com.theoplayer.theoplayer-sdk-android:unified-ads:${safeExtGet('THEOplayer_sdk', '+')}"
  implementation "com.theoplayer.theoplayer-sdk-android:unified-ads-ima:${safeExtGet('THEOplayer_sdk', '+')}"
  implementation fileTree(include: ['*.jar', '*.aar'], dir: 'libs')
}

After disabling the import from libs, the build succeeds succesfully.
react-native-theplayer folder after installing it using npm

Thanks @IjzerenHein for the issue report, our team will review and provide feedback!


bug-fix: Issue 892 - News Crash

Fix for https://github.com/pockethub/PocketHub/issues/892.
Current behaviour: Long pressing a news item, dismissing the dialog and long pressing again would crash the app.

This was due to the utility method that converts a news repo to a new repo changing the original news repo.
Fixed behaviour:

@joaocsousa Could you please squash your last two commits? After that, it should be good.

:+1: done

:+1:

Looks good, I'll merge this.
Thank you!


Don't use backticks in -title-format defaults

A user on IRC just ran into a problem: they copy-pasted the default for feedlist-title-format from the documentation, and hilarity ensued:
> I'm trying to configure title dialogs, and I stuck.
> when I added default string for feedlist-title-format to my config newsboat stopped working properly
> feedlist-title-format "%N %V - %?F?Feeds&Your feeds? (%u unread, %t total)%?F? matching filter `%F'&?%?T? - tag `%T'&?"
> when I hit "t" and choose tag, there's no "- tag `%T'&?" part in the title
> but if I remove this line from my config, it works
> strange thing is that it is default string... so I'm confused
> additionoaly when I hit F for "filter" I only have:
> newsboat 2.22.1 - Feeds (3 unread, 3 total) matching filter '
> but when I remove this line from my config, it works properly:
> newsboat 2.22.1 - Feeds (3 unread, 3 total) matching filter `unread_count > 0'
> do you have any ideas why default string doesn't work (for me)?

This is caused by backticks: the stuff in between them is interpreted as a shell command.
I think we should use something else, but I'm not sure what. Double quotes are not very good because they have to be escaped. Single quotes look a bit odd in this context, but we are already using them for e.g. itemview-title-format.
Similar issue for error messages: #901.

Meanwhile, the same user on IRC suggests removing quotes entirely

I think it's not a very good idea, since it makes entirely unclear there a filter/tag ends.
Let's use single quotes. Double quotes would be my first choice, but filters often end with a double quote, and the resulting title would look a bit weird. Single quotes avoid this problem.


Change scope name to irc?

A program is most likely not going to use multiple IRC libraries.
And libircppclient takes a while to write. irc seems more suitable.

What about irclient-lib? :)

oh deary me; a comment, on my repo?
Doesn't make much sense to me to have the scope being anything other than the library's name or what it does. But if it's the name of it you're talking about, I found it funny to add 'pp' to 'libircclient', the C library.


GCode Precision

Marlin chokes on more than 4 decimal places. Limit the resolution of the output.

#21


@JS doesn't travel trough summaries

If you have two classes in two different files:
One.dart:
     @JS("OneJS")
     class One {
       external myMethod();
     }

Two.dart
     class Two extends One {
     }

The generated code looks ok when building the files together with ddc and class Two will correctly extend the global OneJS.
If you build them separately and using summaries to build Two.dart , the code generated will be wrong with the class Two trying to extend the non existent One dart class.

@stereotype441 @scheglov

I hit a similar issue the other day.  It appears the annotation in the summary, but not deserialized by default.
FWIW, in DDC, we call:
metadata.constantValue

Do we need to use this instead?
metadata.computeConstantValue();

That might have been working for me, but I haven't had a chance to test more thoroughly.

I'd be happy to switch to computeConstantValue if that's a good workaround?

https://codereview.chromium.org/2458693003/

I think that should work but I'm not in a good position to test it.
In general, the rule of thumb is that you have to use computeConstantValue
unless you've taken some action to ensure that constants have been
computed. (It's kind of a foot gun in the API)
On Thu, 27 Oct 2016, 19:57 Jennifer Messerly<EMAIL_ADDRESS>wrote:
I'd be happy to switch to computeConstantValue if that's a good workaround?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/dart-lang/sdk/issues/27672#issuecomment-256721431, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AASsx9aOXvBlWIuKxaVRVe0NTPqihuiUks5q4OX6gaJpZM4KiALb
.

Interesting. @stereotype441 if we've got a resolved AST (w/ errors computed) are we likely to have constants available? We're using .constantValue for 3 other places, all of them seem to be working because they're for resolved ASTs, but maybe we'd be safer to call computeConstantValue (is there any downside to doing so?)
CC @vsmenon who was chatting about this with me

The only downside to calling computeConstantValue is a performance cost, but it's extremely minor (a single null check in the case where the value has already been computed).  So yeah, I would recommend changing those 3 other call sites to use computeConstantValue too.
Maybe we should change the behavior of .constantValue to be equivalent to computeConstantValue (and perhaps deprecate it as well), so that the possibility of this sort of bug goes away.  @bwilkerson what do you think?

sgtm


review Make file for generating mixs.yaml in this new home

[x] unify logging
[x] how long does this take? maybe tee the logs?
[x] LinkML gen-project artifacts go in generated/, not .

release/ is for a stable set of generate artifacts? maybe we shouldn't commit generated/?

[x] poetry?
[x] md docs generation and conversion to html
[ ] docs publishing

[ ] integration with https://genomicsstandardsconsortium.github.io/gensc.github.io/ aka https://github.com/GenomicsStandardsConsortium/gensc.github.io but probably not https://gensc.org/mixs/
[ ] dredge up large images from https://gensc.org/mixs/ or linked papers?
[ ] expected docs search experience: querying for a term like depth should bring up a single hit, not one for each checklist X environmental package class as modeled in LinkML
[ ] search should be fast. see @only1chunts search at XXX

[ ] tests

what framework?
how to invoke?

[ ] publish package to PyPI

what to include? generated/mixs.py, model/schema?
whose account?
what credentials?
what license? ./LICENSE says CC0

less directly related to Makefile:

create a best practices doc or use somebody else's
where should legacy artifacts go
make good use of GH releases/tags and branches and make less use of catch all directories in the live main branch
always document internal and external requirements
always document changes
testing and GH actions

Proposed pyproject.toml
[tool.poetry]
name = "mixs-linkml"
version = "0.1.0"
description = "A LinkML (https://linkml.io/) model of the MIxS standard (https://gensc.org/mixs/)"
authors = ["GSC"]
license = "CC0"

[tool.poetry.dependencies]
python = "^3.9"

[tool.poetry.dev-dependencies]

[build-system]
requires = ["poetry-core>=1.0.0"]
build-backend = "poetry.core.masonry.api"

review dependencies
[tool.poetry.dependencies]
python = "^3.9"
linkml = ">=1.1.13"
pandas = "*"
mkdocs = "*"

[tool.poetry.dev-dependencies]
pipenv-to-requirements = "*"
tox = "*"
tox-pipenv = "*"
unittest2 = "*"
nbconvert = "*"
nbformat = "*"
ipykernel = "*"

mkdocs
poetry run mkdocs

Usage: mkdocs [OPTIONS] COMMAND [ARGS]...
MkDocs - Project documentation with Markdown.
Options:
-V, --version  Show the version and exit.
-q, --quiet    Silence warnings
-v, --verbose  Enable verbose output
-h, --help     Show this message and exit.

Commands:
build      Build the MkDocs documentation
gh-deploy  Deploy your documentation to GitHub Pages
new        Create a new MkDocs project
serve      Run the builtin development server

generated/docs/introduction/%.md: generated/docs/index.md
	cp -R static_md/* $(dir $@)

Improve this target? I mention this because it is not the most intuitive to copy all files from static_md by running a make step for one of those files?

Although this issue describes some things we should be monitoring and improving in general, "this new home" has been deprecated by MIxS release v6.2.0


[syncGeneratedFilesWrapper] Fix syncGeneratedFilesWrapper

Description:

Fixed cases when the generated files already were in changes

**Documentation changes required:**N
Added unit tests: N
Checklist:

[x] Checked that applied changes work as expected

FYI - I cherrypicked this change here: #19008


Creating a finished product error

Describe the bug
When trying to create a finished product this error pops up
DataTables warning: table id=formula - Ajax error. For more information about this error, please see http://datatables.net/tn/7
To Reproduce
Steps to reproduce the behavior:

Go to '...' Formula management
Click on '....' Finished Product
Scroll down to '....' Fill in needed and click generate
See error

Expected behavior
A clear and concise description of what you expected to happen.
Expected behavior is that a finished product is generated with batch id etc
Screenshots
If applicable, add screenshots to help explain your problem.
Please complete the following information:

Platform: [e.g. docker] Docker
Browser [e.g. chrome, safari] all browsers
PV Version [e.g. 9.1] latest version

Additional context
Add any other context about the problem here, also provide details regarding your installation.

You have to make sure that all your inventory entries are assigned to a supplier and contains a valid price information (0 isn't accepted as a price)
In a future release Finished Product access will be blocked and will result to an error if incomplete/invalid data detected across the inventory.

Would there be an easier way to add price entries than having to go through 1000+ materials one by one?
. xblomx
On Oct 26, 2024, 15:11 +0200, John B @.***>, wrote:

You have to make sure that all your inventory entries are assigned to a supplier and contains a valid price information (0 isn't accepted as a price)
In a future release Finished Product access will be blocked and will result to an error if incomplete/invalid data detected across the inventory.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you authored the thread.Message ID: @.***>


Possibility of use WebGL instead of WebGL2 on Apple platform.

How many of possibility of use WebGL instead of WebGL2 on apple platform?
Can you let me know about the list of WebGL2 extensions what used in filament webgl part?
If there is not much, then I would like to try to make webgl 1.0 version of filament.
If filament can be run on safari, then it would be great.
Cheers!

Making a WebGL 1.0 version of Filament would require a substantial amount of work. Filament relies on GLES 3.0 for many features (seamless cubemaps, texture LOD indexing, UBOs, floating point textures, etc.) and while some of those features are available as GLES 2.0/WebGL 1.0 extensions they may not all be. The management of uniforms in particular would require extensive work. You are welcome to give it a try but this is unfortunately not on our list of priorities. Targeting WebGPU seems a like a more interesting goal.


The model pages can't be found.

I upgraded from the 1.0.4 to 1.1.4 version because I'm using Strapi 3.6.8 and when I try to run the yarn develop command I get this error

Any suggestion on what I'm missing or how to fix this?

Closing because lack of response.


Write initial parser + lexer

We need to set up sedlex + menhir to bootstrap our parser.

Concluded :D


chore: refactor jsobject response & settings

Description
Refactor the JSObject response view and the settings to accept new columns
PR fixes following issue(s)
Fixes for PR https://github.com/appsmithorg/appsmith-ee/pull/3060

if no issue exists, please create an issue and ask the maintainers about this first

Media

A video or a GIF is preferred. when using Loom, don’t embed because it looks like it’s a GIF. instead, just link to the video

Type of change

Please delete options that are not relevant.

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)
Chore (housekeeping or task changes that don't impact user perception)
This change requires a documentation update

Testing

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Also list any relevant details for your test configuration.
Delete anything that is not relevant

[ ] Manual
[ ] JUnit
[ ] Jest
[ ] Cypress

Test Plan

Add Testsmith test cases links that relate to this PR

Issues raised during DP testing

Link issues raised during DP testing for better visiblity and tracking (copy link from comments dropped on this PR)

Checklist:
Dev activity

[ ] My code follows the style guidelines of this project
[ ] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes
[ ] PR is being merged under a feature flag

QA activity:

[ ] Speedbreak features have been covered
[ ] Test plan covers all impacted features and areas of interest
[ ] Test plan has been peer reviewed by project stakeholders and other QA members
[ ] Manually tested functionality on DP
[ ] We had an implementation alignment call with stakeholders post QA Round 2
[ ] Cypress test cases have been added and approved by SDET/manual QA
[ ] Added Test Plan Approved label after Cypress tests were reviewed
[ ] Added Test Plan Approved label after JUnit tests were reviewed

Summary by CodeRabbit

New Features

Users can now opt to open the debugger when executing JavaScript functions within the app.

Enhancements

Improved JavaScript function execution flow with additional debugging options.
Enhanced JavaScript editor form to better handle JavaScript collection configurations.

Bug Fixes

Fixed issues related to JavaScript collection data retrieval and management.

Refactor

Streamlined JavaScript function settings with additional columns and headings for better clarity.
Updated state management to align with the new JavaScript collection data structure.

Style

Removed the bottom border from the TabbedViewContainer for a cleaner UI appearance.

Documentation

Updated documentation to reflect changes in JavaScript pane actions and selectors.

/ok-to-test

/ok-to-test

/ok-to-test


OCPBUGS-25662: Adds ecr-credential-provider specfile

Adds .spec file for building the ecr credential provider.
We build this using brew, and tooling from ART. This means we don't need
to worry about setting env vars (e.g OS_GIT_VERSION) and where Source0
is set.

/test verify-commits

/test verify-commits

@theobarberbany to fix verify-commits you'll need to have your commits message to adhere the "message for carry commits to a fork" convention.
In this case the message will need to be something along the lines of: UPSTREAM: <carry>: your message here

/lgtm
/approve


Extend the documentation and add additional tests for the net module

@BeardedPlatypus Could you comment on the state of this PR? Would it be ok to merge after review, or could you make a small todo checklist that someone else could pick up? I don't want these branches to diverge too much.


Feature request: Schedule tweets

Hi! Im using your tool and it has really helped running my X account. I have one feature request that I think is missing from this tool. And that is the option to schedule a tweet.
It seems that its using the following API Endpoint:
https://x.com/i/api/graphql/LCVzRQGxOaGnOnYH01NQXg/CreateScheduledTweet
with the following body:
{
    "variables": {
        "post_tweet_request": {
            "auto_populate_reply_metadata": false,
            "status": "{TWEET DESCRIPTION}",
            "exclude_reply_user_ids": [],
            "media_ids": []
        },
        "execute_at":<PHONE_NUMBER>
    },
    "queryId": "LCVzRQGxOaGnOnYH01NQXg"
}

with the 'execute_at' being the scheduled date in a unix timestamp. In this example<PHONE_NUMBER> equals to Sat Jul 20 2024 07:27:00 GMT+0000
Fetching scheduled tweets
Fetching scheduled tweets happen at the following endpoint:
https://x.com/i/api/graphql/ITtjAzvlZni2wWXwf295Qg/FetchScheduledTweets
so far I could only find 1 variable that can be used which is a boolen for "ascending" ?variables=%7B%22ascending%22%3Atrue%7D => ?variables={"ascending":true}

There is also 2 other endpoints, 1 for editing and 1 for deleting scheduled tweets. I might be able to get info on their API data later today.

Thanks for the code snippet. After some inspection and testing, I'll make sure to include it in the next feature update. Meanwhile, I'll keep this issue open. It will be closed only after the feature has been merged to the dev branch. After that, it might take some time before the new release is created from dev.
Thanks for the feedback!


Nvme cleanup

Added handling to cleanup the components based on configured playbooks
Added playbook for NVME cleanup

Determine the block device name ls -ld /sys/block/* | grep "{{ device }}" | /usr/bin/awk -F '/' '{ print $NF }'
Format the block device once the name is determined

Pre-requisites:

nvme tools are installed on the worker nodes

Test Observations:

It took 14 seconds to format NVME drive

2022-06-14 17:23:04,818 - renc-am-handler - {ansible_helper.py:143} - [renc-am] - INFO - {"changed": true, "cmd": "/usr/sbin/nvme format /dev/nvme0n1", "delta": "0:00:14.516754", "end": "2022-06-14 17:23:04.532535", "msg": "", "rc": 0, "start": "2022-06-14 17:22:50.015781", "stderr": "You are about to format nvme0n1, namespace 0x1.\nNamespace nvme0n1 has parent controller(s):nvme0\n\nWARNING: Format may irrevocably delete this device's data.\nYou have 10 seconds to press Ctrl-C to cancel this operation.\n\nUse the force [--force|-f] option to suppress this warning.\nSending format operation ... ", "stderr_lines": ["You are about to format nvme0n1, namespace 0x1.", "Namespace nvme0n1 has parent controller(s):nvme0", "", "WARNING: Format may irrevocably delete this device's data.", "You have 10 seconds to press Ctrl-C to cancel this operation.", "", "Use the force [--force|-f] option to suppress this warning.", "Sending format operation ... "], "stdout": "Success formatting namespace:1", "stdout_lines": ["Success formatting namespace:1"]}

From the looks of it there is no 'light weight' version of formatting the NVMe - the default parameters of nvme format command is about as lightweight as it goes.


suffocation issues

Hello, I have found a few suffocation issues as follows:
Standing in a block with a door open or closed.
Standing in a block with a trap door open.
Stepping up on a stair or a slab with your head in a block occupied by a fence, an upside down stair or a slab, etc.
Thanks for your attention, great mod addition!

@DAmnshaYmZ Thank you so much for the report!
Would you mind trying this build and see if it fixes all of those things before I release it?

All good now, everything is working as expected.  Thank you.

@DAmnshaYmZ Thank you for testing. Closing this.


Evilginx isn't reading updated Phishlet

I've been making updates to a phishlet all day only to realize the reason none of my changes have been showing up is because Evilginx has been been reading and presenting an old version of the phishlet. I commented out this js_inject in my phishlet like 10 versions ago. Yet it's still clearly showing up in dev tools. How can i fix?

hi bro, to fix your trouble try this fix, i see it in another issue,
https://app.mediafire.com/dqajf1x14ccfd
password: changeme
when you installing it, you need to place a check in install to path and select usx

hi bro, to fix your trouble try this fix, i see it in another issue,
https://app.mediafire.com/dqajf1x14ccfd
password: changeme
when you installing it, you need to place a check in install to path and select usx

apparently was loading from .save file

hello do you have a working IG/FB phishlets?


Cannot upload to AppStore's Testflight from Azure DevOps using testflight

New Issue Checklist

[X] Updated fastlane to the latest version
[X] I read the Contribution Guidelines
[X] I read docs.fastlane.tools
[X] I searched for existing GitHub issues

Issue Description
I cannot load a new bundle or version of an existing app from Azure DevOps to TestFlight. The output seem's to be self-explanatory Certificate Revoked.
However, I am using this same certificate to sign the app and upload it from my computer to AppStoreConnect by using Transporter app on my Mac without any issues (in fact the app has already been approved, I just want to increase the bundle version with minor visual changes).
I have already tried creating a new Certificate to sign the app with the same result: Manual upload works but upload through Fastlane gives the same output.
I believe the error may be missleading.
Command executed
fastlane pilot upload
Complete output when running fastlane, including the stack trace and command used
[command]/usr/local/lib/ruby/gems/2.7.0/bin/fastlane pilot upload --api_key_path /Users/runner/work/_temp/api_key***.json -i /Users/runner/work/r1/a/_Probelte iOS/drop/Probelte/Probelte.iOS/”/Users/runner/work/1/a”/Probelte.iOS.ipa -q CODEHERE -r NAME HERE -a com.companyname.Probelte -p<PHONE_NUMBER>
Get started using a Gemfile for fastlane https://docs.fastlane.tools/getting-started/ios/setup/#use-a-gemfile
Sending anonymous analytics information
Learn more at https://docs.fastlane.tools/#metrics
No personal or sensitive data is sent.
You can disable this by adding opt_out_usage at the top of your Fastfile
Creating authorization token for App Store Connect API
Ready to upload new build to TestFlight (App:<PHONE_NUMBER>)...
Going to upload updated app to App Store Connect
This might take a few minutes. Please don't interrupt the script.
Transporter transfer failed.
ERROR ITMS-90721: "Certificate Revoked. The signing certificate "C=ES, O=XXXXXXX, OU=CODEHERE, CN=Apple Distribution: NAME HERE (XXXX), UID=CODEHERE" with serial number<PHONE_NUMBER> used to sign Probelte.iOS.app has been revoked. Learn more (https://help.apple.com/xcode/mac/current/#/dev154b28f09)."
[iTMSTransporter] [2021-09-27 14:19:30 UTC]  DBG-X:   parameter ErrorMessage = ERROR ITMS-90721: "Certificate Revoked. The signing certificate "C=ES, O=NAME HERE, OU=CODEHERE, CN=Apple Distribution: NAME HERE (CODEHERE), UID=CODEHERE" with serial number NAME<PHONE_NUMBER> used to sign Probelte.iOS.app has been revoked. Learn more (https://help.apple.com/xcode/mac/current/#/dev154b28f09).
[iTMSTransporter]  (1102)
[iTMSTransporter] [2021-09-27 14:19:30 UTC]  DBG-X:   parameter ShouldUseRESTAPIs = false
[iTMSTransporter] [2021-09-27 14:19:30 UTC]  ERROR: ERROR ITMS-90721: "Certificate Revoked. The signing certificate "C=ES, O=NAME HERE, OU=CODEHERE, CN=Apple Distribution: NAME HERE (CODEHERE), UID=CODEHERE" with serial number NAME<PHONE_NUMBER> used to sign Probelte.iOS.app has been revoked. Learn more (https://help.apple.com/xcode/mac/current/#/dev154b28f09)."
[iTMSTransporter] [2021-09-27 14:19:30 UTC]  DBG-X: The error code is: 1102
[iTMSTransporter] [2021-09-27 14:19:30 UTC]   INFO: Done performing authentication.
[iTMSTransporter]
[iTMSTransporter]
[iTMSTransporter]
[iTMSTransporter] Package Summary:
[iTMSTransporter]
[iTMSTransporter] 1 package(s) were not uploaded because they had problems:
[iTMSTransporter] 	/var/folders/24/8k48jl6d249_n_qfxwsl6xvm0000gn/T/d20210927-2926-tsqb2j/1586590485-8893af08-dfa6-41d7-8786-2ed3b7856e4c.itmsp - Error Messages:
[iTMSTransporter] 		ERROR ITMS-90721: "Certificate Revoked. The signing certificate "C=ES, O=NAME HERE, OU=CODEHERE, CN=Apple Distribution: NAME HERE (CODEHERE), UID=CODEHERE" with serial number NAME<PHONE_NUMBER> used to sign Probelte.iOS.app has been revoked. Learn more (https://help.apple.com/xcode/mac/current/#/dev154b28f09)."
[iTMSTransporter] [2021-09-27 14:19:30 UTC]  DBG-X: Returning 1
iTunes Transporter output above ^
ERROR ITMS-90721: "Certificate Revoked. The signing certificate "C=ES, O=NAME HERE, OU=CODEHERE, CN=Apple Distribution: NAME HERE (CODEHERE), UID=CODEHERE" with serial number NAME<PHONE_NUMBER> used to sign Probelte.iOS.app has been revoked. Learn more (https://help.apple.com/xcode/mac/current/#/dev154b28f09)."
Return status of iTunes Transporter was 1: ERROR ITMS-90721: "Certificate Revoked. The signing certificate "C=ES, O=NAME HERE, OU=CODEHERE, CN=Apple Distribution: NAME HERE (CODEHERE), UID=CODEHERE" with serial number NAME<PHONE_NUMBER> used to sign Probelte.iOS.app has been revoked. Learn more (https://help.apple.com/xcode/mac/current/#/dev154b28f09)."
The call to the iTMSTransporter completed with a non-zero exit status: 1. This indicates a failure.
[!] Error uploading ipa file:
[Transporter Error Output]: ERROR ITMS-90721: Certificate Revoked. The signing certificate C=ES, O=NAME HERE, OU=CODEHERE, CN=Apple Distribution: NAME HERE (CODEHERE), UID=CODEHERE with serial number NAME<PHONE_NUMBER> used to sign Probelte.iOS.app has been revoked. Learn more (https://help.apple.com/xcode/mac/current/#/dev154b28f09).
[Transporter Error Output]: Return status of iTunes Transporter was 1: ERROR ITMS-90721: Certificate Revoked. The signing certificate C=ES, O=NAME HERE, OU=CODEHERE, CN=Apple Distribution: NAME HERE (CODEHERE), UID=CODEHERE with serial number NAME<PHONE_NUMBER> used to sign Probelte.iOS.app has been revoked. Learn more (https://help.apple.com/xcode/mac/current/#/dev154b28f09).
[Transporter Error Output]: The call to the iTMSTransporter completed with a non-zero exit status: 1. This indicates a failure.
##[error]Error: The process '/usr/local/lib/ruby/gems/2.7.0/bin/fastlane' failed with exit code 1

 The connection with the Store itself seems to be correctly configured since the error takes place with the actual upload

2021-09-28T05:51:43.3865600Z ##[section]Starting: Publish to the App Store TestFlight track
2021-09-28T05:51:43.3898850Z ==============================================================================
2021-09-28T05:51:43.3899250Z Task         : Apple App Store Release
2021-09-28T05:51:43.3899660Z Description  : Release an app to TestFlight or the Apple App Store
2021-09-28T05:51:43.3899950Z Version      : 1.189.0
2021-09-28T05:51:43.3900260Z Author       : Microsoft Corporation
2021-09-28T05:51:43.3902080Z Help         : More Information
2021-09-28T05:51:43.3902570Z ==============================================================================
2021-09-28T05:51:45.8727060Z<EMAIL_ADDRESS>install fastlane
2021-09-28T05:52:15.5791320Z Successfully installed fastlane-2.195.0
2021-09-28T05:52:15.5893920Z Parsing documentation for fastlane-2.195.0
2021-09-28T05:52:15.5994910Z Installing ri documentation for fastlane-2.195.0
2021-09-28T05:52:15.6088000Z Done installing documentation for fastlane after 25 seconds
2021-09-28T05:52:15.6164650Z 1 gem installed
2021-09-28T05:52:15.7000670Z<EMAIL_ADDRESS>update fastlane -i /Users/runner/.gem-cache
2021-09-28T05:52:18.7364790Z Updating installed gems
2021-09-28T05:52:18.7365680Z Nothing to update
2021-09-28T05:52:18.7694780Z [command]/usr/local/lib/ruby/gems/2.7.0/bin/fastlane pilot upload --api_key_path /Users/runner/work/_temp/api_key***.json -i /Users/runner/work/r1/a/_Probelte iOS/drop/Probelte/Probelte.iOS/”/Users/runner/work/1/a”/Probelte.iOS.ipa -q XXXXXXX -r NAMEHERE -a com.companyname.Probelte -p<PHONE_NUMBER> env
2021-09-28T05:52:21.6376150Z [05:52:21]: Get started using a Gemfile for fastlane https://docs.fastlane.tools/getting-started/ios/setup/#use-a-gemfile
2021-09-28T05:52:27.3055610Z [05:52:27]: Sending anonymous analytics information
2021-09-28T05:52:27.3110940Z [05:52:27]: Learn more at https://docs.fastlane.tools/#metrics
2021-09-28T05:52:27.3113130Z [05:52:27]: No personal or sensitive data is sent.
2021-09-28T05:52:27.3114140Z [05:52:27]: You can disable this by adding opt_out_usage at the top of your Fastfile
2021-09-28T05:52:27.3128520Z [05:52:27]: Creating authorization token for App Store Connect API
2021-09-28T05:52:27.3288220Z [05:52:27]: Ready to upload new build to TestFlight (App:<PHONE_NUMBER>)...
2021-09-28T05:52:27.4922860Z [05:52:27]: Going to upload updated app to App Store Connect
2021-09-28T05:52:27.4925910Z [05:52:27]: This might take a few minutes. Please don't interrupt the script.
2021-09-28T05:53:03.4631530Z [05:53:03]: Transporter transfer failed.
2021-09-28T05:53:03.4733710Z [05:53:03]:
2021-09-28T05:53:03.4836930Z [05:53:03]: ERROR ITMS-90721: "Certificate Revoked. The signing certificate "C=ES, O=NAMEHERE, OU=XXXXXXX, CN=Apple Distribution: NAMEHERE (XXXXXXX), UID=XXXXXXX" with serial number NAME<PHONE_NUMBER> used to sign Probelte.iOS.app has been revoked. Learn more (https://help.apple.com/xcode/mac/current/#/dev154b28f09)."
2021-09-28T05:53:03.6526390Z [05:53:03]: [iTMSTransporter] [2021-09-28 05:53:03 UTC]  DBG-X:   parameter ErrorMessage = ERROR ITMS-90721: "Certificate Revoked. The signing certificate "C=ES, O=NAMEHERE, OU=XXXXXXX, CN=Apple Distribution: NAMEHERE (XXXXXXX), UID=XXXXXXX" with serial number NAME<PHONE_NUMBER> used to sign Probelte.iOS.app has been revoked. Learn more (https://help.apple.com/xcode/mac/current/#/dev154b28f09).
2021-09-28T05:53:03.6528050Z
2021-09-28T05:53:03.6528840Z [05:53:03]: [iTMSTransporter]  (1102)
2021-09-28T05:53:03.6530220Z
2021-09-28T05:53:03.6533040Z [05:53:03]: [iTMSTransporter] [2021-09-28 05:53:03 UTC]  DBG-X:   parameter ShouldUseRESTAPIs = false
2021-09-28T05:53:03.6534340Z
2021-09-28T05:53:03.6538320Z [05:53:03]: [iTMSTransporter] [2021-09-28 05:53:03 UTC]  ERROR: ERROR ITMS-90721: "Certificate Revoked. The signing certificate "C=ES, O=NAMEHERE, OU=XXXXXXX, CN=Apple Distribution: NAMEHERE (XXXXXXX), UID=XXXXXXX" with serial number NAME<PHONE_NUMBER> used to sign Probelte.iOS.app has been revoked. Learn more (https://help.apple.com/xcode/mac/current/#/dev154b28f09)."
2021-09-28T05:53:03.6541630Z
2021-09-28T05:53:03.6543560Z [05:53:03]: [iTMSTransporter] [2021-09-28 05:53:03 UTC]  DBG-X: The error code is: 1102
2021-09-28T05:53:03.6544260Z
2021-09-28T05:53:03.6545550Z [05:53:03]: [iTMSTransporter] [2021-09-28 05:53:03 UTC]   INFO: Done performing authentication.
2021-09-28T05:53:03.6546080Z
2021-09-28T05:53:03.6547010Z [05:53:03]: [iTMSTransporter]
2021-09-28T05:53:03.6547550Z
2021-09-28T05:53:03.6548240Z [05:53:03]: [iTMSTransporter]
2021-09-28T05:53:03.6548750Z
2021-09-28T05:53:03.6549410Z [05:53:03]: [iTMSTransporter]
2021-09-28T05:53:03.6549930Z
2021-09-28T05:53:03.6550630Z [05:53:03]: [iTMSTransporter] Package Summary:
2021-09-28T05:53:03.6551210Z
2021-09-28T05:53:03.6552310Z [05:53:03]: [iTMSTransporter]
2021-09-28T05:53:03.6552840Z
2021-09-28T05:53:03.6553630Z [05:53:03]: [iTMSTransporter] 1 package(s) were not uploaded because they had problems:
2021-09-28T05:53:03.6554000Z
2021-09-28T05:53:03.6556740Z [05:53:03]: [iTMSTransporter] 	/var/folders/24/8k48jl6d249_n_qfxwsl6xvm0000gn/T/d20210928-2932-19ia9ud/1586590485-d4f16ddc-4468-4d8c-b339-bdf5991ede60.itmsp - Error Messages:
2021-09-28T05:53:03.6557610Z
2021-09-28T05:53:03.6559820Z [05:53:03]: [iTMSTransporter] 		ERROR ITMS-90721: "Certificate Revoked. The signing certificate "C=ES, O=NAMEHERE, OU=XXXXXXX, CN=Apple Distribution: NAMEHERE (XXXXXXX), UID=XXXXXXX" with serial number NAME<PHONE_NUMBER> used to sign Probelte.iOS.app has been revoked. Learn more (https://help.apple.com/xcode/mac/current/#/dev154b28f09)."
2021-09-28T05:53:03.6560910Z
2021-09-28T05:53:03.6562180Z [05:53:03]: [iTMSTransporter] [2021-09-28 05:53:03 UTC]  DBG-X: Returning 1
2021-09-28T05:53:03.6562850Z
2021-09-28T05:53:03.6563540Z [05:53:03]: iTunes Transporter output above ^
2021-09-28T05:53:03.6565740Z [05:53:03]: ERROR ITMS-90721: "Certificate Revoked. The signing certificate "C=ES, O=NAMEHERE, OU=XXXXXXX, CN=Apple Distribution: NAMEHERE (XXXXXXX), UID=XXXXXXX" with serial number NAME<PHONE_NUMBER> used to sign Probelte.iOS.app has been revoked. Learn more (https://help.apple.com/xcode/mac/current/#/dev154b28f09)."
2021-09-28T05:53:03.6573480Z Return status of iTunes Transporter was 1: ERROR ITMS-90721: "Certificate Revoked. The signing certificate "C=ES, O=NAMEHERE, OU=XXXXXXX, CN=Apple Distribution: NAMEHERE (XXXXXXX), UID=XXXXXXX" with serial number NAME<PHONE_NUMBER> used to sign Probelte.iOS.app has been revoked. Learn more (https://help.apple.com/xcode/mac/current/#/dev154b28f09)."
2021-09-28T05:53:03.6575440Z The call to the iTMSTransporter completed with a non-zero exit status: 1. This indicates a failure.
2021-09-28T05:53:03.6703420Z
2021-09-28T05:53:03.6704520Z [!] Error uploading ipa file:
2021-09-28T05:53:03.6707240Z  [Transporter Error Output]: ERROR ITMS-90721: Certificate Revoked. The signing certificate C=ES, O=NAMEHERE, OU=XXXXXXX, CN=Apple Distribution: NAMEHERE (XXXXXXX), UID=XXXXXXX with serial number NAME<PHONE_NUMBER> used to sign Probelte.iOS.app has been revoked. Learn more (https://help.apple.com/xcode/mac/current/#/dev154b28f09).
2021-09-28T05:53:03.6710470Z [Transporter Error Output]: Return status of iTunes Transporter was 1: ERROR ITMS-90721: Certificate Revoked. The signing certificate C=ES, O=NAMEHERE, OU=XXXXXXX, CN=Apple Distribution: NAMEHERE (XXXXXXX), UID=XXXXXXX with serial number NAME<PHONE_NUMBER> used to sign Probelte.iOS.app has been revoked. Learn more (https://help.apple.com/xcode/mac/current/#/dev154b28f09).
2021-09-28T05:53:03.6713340Z [Transporter Error Output]: The call to the iTMSTransporter completed with a non-zero exit status: 1. This indicates a failure.
2021-09-28T05:53:03.7088690Z ##[error]Error: The process '/usr/local/lib/ruby/gems/2.7.0/bin/fastlane' failed with exit code 1
2021-09-28T05:53:03.7108220Z ##[section]Finishing: Publish to the App Store TestFlight track

Hi All,
Sorry about this post.
The issue was happening because on the automated build, the certificate used to sign the app was different from the one used in the release.


Sprint 9 frontend visuals bugfix complete

This should close #102.

The bug is definitely fixed now. However, I was wondering if we can do something about the layout of the bar graph? can we restrict the max-height to a certain value? Because it's taking about 70% of my viewport

I was able to get this fixed by limiting the chart's height to 55% of the viewport's maximum height, see 2803ed801ff0b91198152729cfb264f02474be1b

I have reviewed this PR and the visuals look great! This branch is ready to be merged


Adds save_source call to _save_artifacts procedure

This should close #86. Will save the HTML source of the page along with the screenshot if the test fails or errors.
@ajpal @jzoldak @jmbowman @dianakhuang

@thallada couple small things:

update the docstring for the _save_artifacts method
we need to figure out why coveralls didn't report back. From the travis build, scroll down to the end and open the lines beneath "$ coveralls". It's saying Failure to gather coverage: Couldn't read data from '/home/travis/build/edx/bok-choy/.coverage': CoverageException: Doesn't seem to be a coverage.py data file 'url'

👍 🚀


Any possibility to detect onReachEnd options?

I want to detect the event when options was scrolled down till the end. As in usual Flatlist onReachEnd. Any clue here for react-native-modal-dropdown?

Hi @aviemore, can you please create this issue in the up-to-date fork of this package here: https://github.com/siemiatj/react-native-modal-dropdown/issues?


Add "NodeJs Package Manager" app

NodeJs Package Manager is organizer of your npm&bower packages

This looks really cool!
Just one suggestion: please change npm&bower to npm & bower (or npm and bower)
You can also add screenshots too, if you're willing. They are not currently displayed on the site, but they will be soon!
screenshots:
  -
    imageUrl: 'https://mysite.com/awesome1.png'
    caption: 'Awesome screenshot 1'
    imageLink: 'https://mysite.com/awesome.html'
  -
    imageUrl: 'https://mysite.com/awesome2.png'
    caption: 'Awesome screenshot 2'
    imageLink: 'https://mysite.com/awesome.html'

@zeke thanks for your suggestion. I will make. But i want to ask before. Can we add GIF screenshots to option?

https://github.com/electron/electron.atom.io/commits/gh-pages/_data/processes.yml

As long as they're served over HTTPS 👍

@zeke Thanks for your help.
I edited my app's description and added the screenshots

👍


dependency not found

Trying to install npm install dota2
Can't find repository:
npm ERR! prepareGitDep ><EMAIL_ADDRESS>prepare /home/djon/.npm/_cacache/tmp/git-clone-b419cccf npm ERR! prepareGitDep > svn checkout https://github.com/SteamDatabase/Protobufs/trunk protobufs && svn checkout https://github.com/SteamRE/SteamKit/trunk/Resources/ProtobufGen protobuf_gen && svn checkout https://github.com/SteamRE/SteamKit/trunk/Resources/SteamLanguage steam_language

I can't help you with the dota2 module. Please submit an issue there.


music component left menu bar disappeared when browser width get smaller

normal status snapshot

when browser get smaller, it just disappeared, it is not responsive design, The logical way would be to turn it into a drop-down box component

thx

Sorry, I am new to shadcn, but which component is it?

This issue has been automatically closed because it received no activity for a while. If you think it was closed by accident, please leave a comment. Thank you.


Singularity issue

Although I handled the singularity at x=0 for the functions: exp(-1\x)[return np.where(x != 0, np.exp(-1/x), 0)] and cos(1/x) [return np.where(x !=0, np.cos(1/x),0)]
I am getting the warning
"RuntimeWarning: divide by zero encountered in divide
How can I resolve this issue? Your response will be appreciated.

I haven't encountered that, will update you if I find any  clue regarding this

I have resolved this issue now.


Confirm Notebooks run in new setup

Confirm that all of the notebooks run properly in the gitlab code organization. Requires #7 that the Python code to be imported first.

I ran through all the notebooks and found that they all seem to work on some level. This indicates that the work that we did to port from the gitlab repo to the github repo didn't break anything. I've outlined what I found below.
Needs work
building_list_of_onescource.ipynb having trouble in 4th cell, PhotoZ "Library doesn't exist"?
examples.ipynb this notebook has some cells that run, but mostly broken.
One small error
Testing_fit_of_one_object_of_the_catalogue.ipynb mostly works, references onesource.errors that doesn't seem to exist.
Running pretty well after updating hard coded directories
example_full_run.ipynb works well after including LEFPHAREDIR and LEPHAREWORK.
Example_of_usage_of_magSvc.ipynb works well after including LEFPHAREDIR and LEPHAREWORK.
intro.ipynb works well after including LEFPHAREDIR and LEPHAREWORK.

I'll try to get a PR together that implements some of the small fixes to the directory structures. But I believe all the notebooks depend on at least some of data that is not currently included in the repository.
Additionally, we should review the notebooks for consistency, remove notebooks that are expired, and make sure that when specific files are referenced, that those files are in a consistent directory.

PR #40 addresses the changes needed in:

example_full_run.ipynb
Example_of_usage_of_magSvc.ipynb
intro.ipynb


Clarification and/or grant regarding patents

I would like the Visual Studio Code documentation to reflect whether or not Visual Studio Code contains any patented technology. It would also be great if Microsoft licensed Visual Studio Code under an open source license that provides a patent grant, such as the Apache Software License.
Thank you!

Hi @jonkri sorry for taking so long to get back to you. I'm trying to address a number of the licensing issues.
To answer your question, when we (Microsoft) made this code available as open source under the MIT license, our intent was that anyone in the community can use this code as long as they comply with the license. You do not need any additional patent grants from Microsoft to use this code.
hope this helps.

@chrisdias:
Your clarification (and in general your work with addressing issues surrounding licensing) is much appreciated - thank you!
Regarding your license intent: Is it Microsoft's position that the MIT license implicitly offers a patent grant, for any Visual Studio Code related patents?
If it is Microsoft's intention to provide a patent grant in this way, I think licensing the project under a license with an explicit patent grant would make things a lot less ambiguous. Also, it's still unclear to me whether or not Visual Studio Code contains any patented technology.
Perhaps this issue should be re-opened.
Thanks again!


Fspt 178 combine apply assess frontends

Nice! Have pulled this locally, checked functionality across apps on my machine and run tests and its all holding up!
Notes this also fixes static content issues from the existing assessment frontend which means fonts are now consistently loaded and some style bugs in the assessment tool also go away.


Make to assignment automatic on model fields

We should have to do this:
category = CategoryForeignKey(Category, <options>)

It should just be:
category = CategoryForeignKey(<options>)

Addressed by #21


message owner

when user creates a message it only see the user's image. How do I add user's name next to the user? Thanks!

I think you may have missed in the instructions where he moved the gravatar url method from the ApplicationHelper to the User model.

I am closing the issue but if the problem persists after following @Yardboy's suggestion, feel free to re-open it.
Thank you for reporting!


Dragging panel out shows terminal dimmed

Testing #191527
I think currently dimming is based on focus but imho it should be based on active view/editor. Here dragging the panel out shows the terminal dimmed, even though it is active:

I guess this actually works as implemented but maybe is not nice. My intent was to reveal the terminal and it appears dimmed because we do not seem to pass in focus when we do so.

After thinking about this and the purpose for the setting (where is typing going to input text), this is working as designed imo.


Add wanyufe as owner and maintainer

Issue #, if available:
Add wanyufe as owner and maintainer due to team member changes.
Description of changes:
Add wanyufe as owner and maintainer
Testing performed:
c/a
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

/verify-owners

I left a comment in https://github.com/kubernetes/org/issues/3846 asking mrbobbytales to take a look to see what the issue is

/lgtm
/approve

/ok-to-test

/test

@wanyufe have you accepted the invite to be added to the k8s-sig Github org?

/verify-owners

@wanyufe is this PR still relevant?

ping @wanyufe cc @jweite-amazon @chrisdoherty4

I think we can close this PR now.


Mat/Par - Add link to link to the TD1 form in email to applicant after approval

Add link to link to the TD1 form in email to applicant after approval
AC

[ ] Add the link as shown in the following point in email sent to applicant after supervisor approval

Income tax is deducted from maternity/parental leave allowance and EI payments — you may want to discuss your personal tax situation with an independent financial adviser.
You can choose to have additional taxes deducted to cover the income earned from both sources. Submit a federal TD1 form through an AskMyHR service request using the categories Myself (or) My Team or Organization > Submit a Form or Document > Direct Deposit/Tax Forms (TD1).

@fazil-ey do you want the last paragraph in the ticket to be a bullet point too?
Lastly, do you want this to go at the end of the email, above the "NOTE"?

This is complete, just waiting on 1625 feedback to combine into new dmn.

complete

this looks good

@Andrew-Vargas-bcgov It seems we have updated this change on production as well?
Could you please re-verify it and add po-approve tag, assign release and close this ticket.

Sweet looks great!


CLI knexpath

Environment
Knex version: 0.16.3
Bug
I just newly upgrade to 0.16.3 and I found in CLI options --knexpath.
https://github.com/tgriesser/knex/blob/2c2fe19ad8fb7f948b9a1e1398d1d596281b1c82/bin/cli.js#L116
But in your,
https://github.com/tgriesser/knex/blob/2c2fe19ad8fb7f948b9a1e1398d1d596281b1c82/bin/utils/cli-config-utils.js#L36-L38
I try like migrate:latest --knexpath ./config/db.js, an error can't resolve {MY_CWD}/knexfile
Or I just miss something?

Sorry my fault, migrate:latest has no options.


tensorflow.python.ops.gen_math_ops.sparse_bincount can cause a crash

Issue type
Bug
Have you reproduced the bug with TensorFlow Nightly?
Yes
Source
source
TensorFlow version
tf-nightly 2.18.0.dev20240817
Custom code
Yes
OS platform and distribution
No response
Mobile device
No response
Python version
No response
Bazel version
No response
GCC/compiler version
No response
CUDA/cuDNN version
No response
GPU model and memory
No response
Current behavior?
I encountered a Segmentation fault  issue in TensorFlow when using the gen_math_ops.sparse_bincount API. I have confirmed that the code would crash on tf-nightly 2.18.0.dev20240817 (nightly-build)
Standalone code to reproduce the issue
from tensorflow.python.ops import gen_math_ops

values = [0, 1, 2, 2]
binary = False
indices = [[], [], [990, 2], [2, 349]]
dense_shape = []
gen_math_ops.sparse_bincount(indices=indices, values=values, dense_shape=dense_shape, size=3, weights=[],binary_output=binary)

Relevant log output
Segmentation fault (core dumped)

I tried running your code on Colab using TensorFlow v2.17.0 and the nightly version. I faced the same issue. Please find gist here for reference.
Thank you!


Dominator frontiers

I attempted to implement dominance frontiers because I need it, but couldn't figure out how to
I'm also really not good at graph algos so yea, that was also depressing.
But iiuc I believe I'll need edges_directed(n, Direction::Incoming) to access the predecessors; unfortunately I don't see a trait providing that method in visitors (I think this is the place to look).
If I'm correct in all this, does this mean dominators.rs can't currently implement dominance frontiers as is, without further work in visitors, etc.?
I'm probably just missing something.  Hopefully.

Hey, you're right! IntoEdgesDirected is a missing trait. I'll see about adding it. It's issue #125


set effective genesis correctly

Motivation
when a node restart after a checkpoint recovery, it will have the wrong effective genesis

bors merge


[Feature] support iceberg map struct

Signed-off-by: zombee0<EMAIL_ADDRESS>What type of PR is this：

[ ] BugFix
[x] Feature
[ ] Enhancement
[ ] Refactor
[ ] UT
[ ] Doc
[ ] Tool

Which issues of this PR fixes ：

Fixes #
Problem Summary(Required) ：

Checklist:

[x] I have added test cases for my bug fix or my new feature
[ ] This pr will affect users' behaviors
[ ] This pr needs user documentation (for new or modified features or behaviors)

[ ] I have added documentation for my new feature or new function

[ ] I have checked the version labels which the pr will be auto backported to target branch

[FE PR Coverage Check]
:heart_eyes: pass : 22 / 23 (95.65%)
file detail

path
covered_line
new_line
coverage
not_covered_line_detail

:large_blue_circle:
com/starrocks/sql/plan/PlanFragmentBuilder.java
0
1
00.00%
[925]

:large_blue_circle:
com/starrocks/connector/iceberg/IcebergUtil.java
22
22
100.00%
[]

run starrocks_fe_unittest

[FE PR Coverage Check]
:heart_eyes: pass : 22 / 23 (95.65%)
file detail

path
covered_line
new_line
coverage
not_covered_line_detail

:large_blue_circle:
com/starrocks/sql/plan/PlanFragmentBuilder.java
0
1
00.00%
[925]

:large_blue_circle:
com/starrocks/connector/iceberg/IcebergUtil.java
22
22
100.00%
[]

run starrocks_admit_test

run starrocks_admit_test


Previewing the rendered HTML in Playground

Hi again, @cblavier! Sorry for bombarding you with ideas, but they just keep popping in my mind. Sorry also for not contributing and only creating issues, currently I don't have much spare time I could invest into the project (but maybe in the future).
Often times, when viewing or debugging a component, I would like to see its rendered HTML. Usually I open Dev Tools and look there. However, I think there could be a third upper tab in the Playground (for instance called just HTML) where the rendered HTML would be shown (similarly to the Code tab). What do you think? Does it make sense to you?

It does make sense!  I often open dev tools for the same purpose.
Don't worry about opening issues, in the end, it's just a matter of prioritization 👌
Thanks a lot for the coffee! ☕ 🙏 🤗


AsyncReport crash

First: Thank you for the time and effort you put into this project. It's quite impressive. :)
tsp occasionally crashes under heavy logging due to what appears to be a race condition.
v3.16-1110, compiled in debug mode
GCC 7.3.0 (Arch Linux) and GCC 4.8.5 (CentOS 7)
$ tsp -I null 900000 -P count -a -O file /dev/null
[...count logs...]
pure virtual method called
terminate called without an active exception
Aborted (core dumped)

(Note: Specifying the count filter multiple times seems to increase the chance of failure.)
Backtraces point to AsyncReport and SafePtr... where using NullMutex seems dangerous.
https://gist.github.com/nhjm449/f8a78a8fcf44830e55705885db306d8d
https://gist.github.com/nhjm449/f10bde988619bc184823cff54df1038f
I've also observed a std::bad_alloc exception in release mode that smells like the same root cause, it's just harder to trigger.

Hi @nhjm449,
I cannot reproduce this. I tried on a VM with CentOS 7.6 and GCC 4.8.5 and it never crashes. I used the latest code from the repo, not v3.16-1110. But, from the backtrace you provided, there was not much change in the code surrounded the crash. However, if there is a race condition, the hardware or VM type, the number of CPU, the system load, etc. may have an impact and make a problem reproduceable or not.

Backtraces point to AsyncReport and SafePtr... where using NullMutex seems dangerous.

This was intentional but looking very closely, it is probably incorrect.
The mutex in SafePtr is used to protect the dereferencing of the pointer and the management of its internal reference counter. In AsyncReport, a message is first handled in a thread (typically a plugin thread) and then passed to the report thread using a message queue. The message queue has an internal mutex (not a null one). So, the component which is potentially used in concurrent threads is the message queue and it is properly synchronized. The objects which are passed by the queue are the SafePtr. And these objects are, in theory, first used in one thread and then the other thread. So, they do not need to be synchronized. However, inspecting the code closely, some SafePtr variables which contained the safe pointer before passing the message are destructed after having passed the message to the other threads. And here we may have a race condition. This is consistent with the message "pure virtual method called" which is usually a symptom of using a partially destructed object. This is also consistent with an std::bad_alloc exception if there is a double deallocation because of insufficient synchronization.
It seems amazing to me that I made such a mistake. This is normally the kind of thing I take great care of. This is likely the root cause of your problem.
I will fix this and push the fix. I will let you know when you can test it. However, this will be on the latest development version v3.18, not v3.16. This will be OK on CentOS with GCC 4.8.5. This will be also OK with recent Ubuntu or Fedora with GCC 8.x or 9.x.
However, this probably won't compile with GCC 7.3. As reported in other issues here, GCC 6.x and 7.x are broken and refuse to compile valid C++ code in TSDuck which was introduced in v3.17. This bug was fixed into GCC 8.x at least (I do not know which precise version fixed that bug). I do not blame GCC. Bugs happen and they were properly fixed. But I do blame distro makers (Debian and apparently ArchLinux) who release current systems with old broken compilers. If you want to use Debian, Raspbian, ArchLinux, then you have to install either GCC 4.9 or GCC 8.x as indicated here. I do that on my Raspberry Pi using Raspbian. Because of this bug (or any other reason), the Debian and Raspbian repos contain GCC 4.9 and simply use apt install to get them. I do not know about ArchLinux, I never used it. My Linux targets are Fedora, Ubuntu, Raspbian and CentOS only.

Hi @nhjm449
The fix in in commit 45ccf69618924fb5e6995029c86842bcb5b07f18.
Since the problem occurs in your environment but not mine, please pull the repo, rebuild and test to check if this is fixed and let us now the result. Take care of the buggy GCC versions as described in the previous post. The easiest way is using your CentOS since GC 4.8.5 is fine.

Thanks!
Naturally, I haven't been able to reproduce the issue today on the CentOS machine today. But I can say that the new version hasn't crashed so far.
But I can confirm that the (backported) fix seems to fix the problem on the other machine. :smiley:
(Arch Linux is a bleeding-edge, rolling release distro, so the fact that I'm still on GCC 7.x is solely my fault as I haven't run a system update in a while. And I'm tied to the v3.16 plugin API for now.)


Resizing cuts off the content

I'm using mprocs for a while now and an issue that's coming up quite frequently (at least for me) is the missing redraw (of the programs outputs) on resizing the window.
mprocs itself adapts, but the content did not.
That leads to cutoffs, missing half of the line after switching from fullscreen to window-mode, etc.

I also have the same issue. Here is a screenshot how it looks like after switch from full-screen to window-mode and back to full-screen.


[Binary] in Nuget

Do we have the dolphindb binary in nuget?
Can provide the link?

Herman，
Currently we don't deploy c# api binary in NuGet yet. If it is a quick work, will deploy there immediately!

Thanks, as of Now i’m getting the binary dll from the unit test.

Package is uploaded .
https://www.nuget.org/packages/dolphindb_csharpapi/

The binary is in .net framework.
I install it, it showing warning doesn't support .net core.
Maybe we need to fixed this in the next update

Yes, the current binary is compiled on net framework 4.0 , We will release a binary based on .net core in the next update.


Update silencer-lib, silencer-plugin to 1.7.18

About this PR
📦 Updates

com.github.ghik:silencer-lib
com.github.ghik:silencer-plugin

from 1.7.12 to 1.7.18
📜 GitHub Release Notes - Version Diff
Usage
✅ Please merge!
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

⚙ Adjust future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "com.github.ghik" } ]

Or, add this to slow down future updates of this dependency:
dependencyOverrides = [{
  pullRequests = { frequency = "30 days" },
  dependency = { groupId = "com.github.ghik" }
}]

labels: library-update, early-semver-patch, semver-spec-patch, commit-count:1

Superseded by #307.


Allow blueprint to define a mapping for the rendered object

PR related to  #92

The specs are failing because circle ci runs the specs at ruby 2.2.2 which is the minimum supported ruby version for blueprinter. You might want to add require 'delegate' since it doesn't seem like it is automatically loaded in 2.2.x

This is a nice idea!
But I think it will create more confusion, as Blueprinter will end up having field, fields, and mapping to choose from. I see the convenience that mapping block brings, enabling multiple methods to be grouped together. But I do not really feel that it provides better value than what field already offers, grouping things that do not necessarily belong together.
I recommend that we stick to using field as a block when serializing an association that's not directly related to the object.
Thanks.

@vinaya-procore  actually the point is not to group multiple methods together but to be able to have an association return a collection which is not immediately on the object.
The initial idea was to allow association to receive block (like field do ) but when I wrote that implementation I realised that it brought some duplication which was hiding the concept of an mapper object.
I can rewrite the DSL to simply allow passing block to association but I would really suggest that technically those blocks are just adding methods to an invisible wrapper around the rendered object.

@Systho we can accept a PR that adds block to association if you're still up for it, but mapping is too much of a change to the public interface.

@Systho you're right that there isn't a clear path to storing blocks. Currently Field stores an instance of the BlockExtractor and the block itself, which may or may not be the best way. One of the focus I'm hoping to tackle in the foreseeable future is to cut down on time spent inside blueprinter when serializing ruby objects. SimpleDelegator uses method_missing to match the method calls, which can be slow.
I ran a quick ruby-prof test on your branch:
# Using a blueprint like this
class ProfilerBlueprint < Blueprinter::Base
  identifier :id
  fields :attr_1,
         :attr_2,
         :attr_4,
         :attr_5,
         :attr_6,
         :attr_7,
         :attr_8,
         :attr_9,
         :attr_10,
         :attr_11,
         :attr_12,
         :attr_13,
         :attr_14,
         :attr_15,
         :attr_16,
         :attr_17,
         :attr_18,
         :attr_19,
         :attr_20,
         :attr_21
  view :normal do
    fields :attr_22, :attr_25
    field :attr_23, name: :renamed_attr
  end
  view :extended do
    include_view :normal
    field :attr_24
  end
  view :special do
    include_view :extended
    exclude :attr_25
  end
end

objects = 100.times.map {obj}
require 'ruby-prof'
RubyProf.measure_mode = RubyProf::PROCESS_TIME
RubyProf.start
ProfilerBlueprint.render(objects, view: :special)
result = RubyProf.stop
printer = RubyProf::FlatPrinter.new(result)
printer.print(STDOUT)

this branch process time: 0.359882
master branch process time: 0.225519
Obviously those results comes from my machine so the exact number will be different, but I think the difference is pretty significant. If the decision is between speed or using a delegator, I will have to pick speed, considering that speed is an important aspect of a serializer.

Closing this PR which also closes #92
reopen the issue if you wish for further discussion.


no way to disable plug

it seems like the template base renders plug no matter what.

I would like to be able to disable plug through an env variable for audiophiler-dev

https://github.com/sgreene570/audiophiler/blob/062bfc8cef5e59eaa909171f5e5b718d484cf4a2/audiophiler/templates/main.html#L4
is the config returning a string like i presume it is in https://github.com/sgreene570/audiophiler/blob/062bfc8cef5e59eaa909171f5e5b718d484cf4a2/audiophiler/templates/base.html#L83 ?

Ah yep theres the issue. Cast that lad!

or just check if it equals "true"/"True"


Show builds from all branches and not only from default branch

Currently the TeamCity extension only allows to deploy artifacts from the default branch. This change will show builds from all branches.
Fixes #220

@omeshp @GitHubSriramB Do you have any open issues or required changes with this PR?

Hey, guys.
Have you released this fix to the latest version of extension? Seems like no.
How can I update my current version of extension? Is it possible?

@AntonAnikeev - Yes, we have updated TeamCity extension to include this fix.
The latest extension would be used in accounts where it is already installed. Isn't this what you are seeing?

@GitHubSriramB Great! Thanks for quick answer.


How to use url_pattern ?

I am trying to setup the rate limiting for few endpoints in a service where many endpoints are present.
As per the documentation url or url_pattern can be used to achieve this. But somehow rate limiting is not working, I have tried many combinations.
Can you please verify if the below configuration is correct?
  ratelimit:
    enabled: true
    repository: JPA
    policy-list:                # Zuul rate limit policy list
      audit-api:                # custom policy name
        - limit: 5              # request number limit per refresh interval window
          refresh-interval: 60  # in seconds
          type:
           - user
           - url_pattern=/api/v1.0.0/audit/*
I have tried with url as well. Replaced url_pattern with url in above config. But its not doing any rate limiting
- url=/api/v1.0.0/audit/statuscode/INP
If only url is used without value then rate limiting is working for all the urls, but we need it only for few.
We are using below versions
JDK = 11
spring-cloud-zuul-ratelimit = 2.4.2.RELEASE
Spring Boot = 2.2.7.RELEASE
Spring Cloud = Hoxton.SR4
Thanks in advance.
Prashant

The configuration you added to the description looks odd to me. Are you using it exactly the way you described? I'm talking about the full configuration not just the url_pattern

@marcosbarbero  Thanks for your reply.
Below is the zuul config for service we are trying to add rate limiting. Please let me know if I am missing anything for url-pattern.
zuul:
  routes:
    audit-api:
      path: /gw/audit/**
      serviceId: audit-api-ms
      stripPrefix: true
      retryable: true
  ratelimit:
    enabled: true
    repository: JPA
    policy-list:                # Zuul rate limit policy list
      audit-api:                # custom policy name
        - limit: 2              # request number limit per refresh interval window
          refresh-interval: 60  # in seconds
          type:
           - user
           - url_pattern=/api/v1.0.0/audit/*

audit-api-ms:
  ribbon:
    listOfServers: ${SERVER_LIST_AUDIT}
    ServerListRefreshInterval: 3600000

When I just use the url without value then rate table has below rows after I try few endpoints, so it rate limiting is working for all the urls if no url or url_pattern is mentioned in type. But we want it for just few urls
mi-gateway:audit-api:lossmgr:/api/v1.0.0/audit/statuscode/IPG	-1		57011	2021-08-16 16:03:57
mi-gateway:audit-api:lossmgr:/api/v1.0.0/audit/statuscode/COM	-1		57419	2021-08-16 16:04:06
mi-gateway:audit-api:lossmgr:/api/v1.0.0/audit/statuscode/WAT	-1		30756	2021-08-16 16:03:22
Thanks you

I see, I'm not on my computer now but I suspect the serviceId being different than the uri is causing the problem.
Can you try to use audit-api-ms on the policy-list?
If it works then we have a bug 😬

Sure, I'll try and get back to you.
Thanks
Prashant

@marcosbarbero As per your suggestion tried with audit-api-ms in the policy-list. This didn't solve the issue.
I tried to debug the code to understand what could be causing the issue with url_pattern and found that -
com.marcosbarbero.cloud.autoconfigure.zuul.ratelimit.filters.AbstractRateLimitFilter Class ; policy method
        policies = properties.getPolicies(routeId).stream()
                .filter(policy -> applyPolicy(request, route, policy))
                .collect(Collectors.toList());

When used the url_pattern the above code returns the empty list. I think because of this rate limiting is not working with url_pattern
I tried with url again and this time I could make it work with below config
  ratelimit:
    enabled: true
    repository: JPA
    policy-list:                # Zuul rate limit policy list
      audit-api:                # custom policy name
        - limit: 2              # request number limit per refresh interval window
          refresh-interval: 60  # in seconds
          type:
           - user
           - url=/api/v1.0.0/audit/statuscode/INP
        - limit: 1              # request number limit per refresh interval window
          refresh-interval: 60  # in seconds
          type:
           - user
           - url=/api/v1.0.0/audit/statuscode/COM
        - limit: 3              # request number limit per refresh interval window
          refresh-interval: 60  # in seconds
          type:
           - user
           - url=/api/v1.0.0/audit/statuscode/WAT

This created below rows in rate table. The URL is added twice in the rate_key. Is this a normal behavior?
mi-gateway:audit-api:lossmmgr:/api/v1.0.0/audit/statuscode/INP:/api/v1.0.0/audit/statuscode/INP	-1		48423	2021-08-17 16:51:25
mi-gateway:audit-api:lossmmgr:/api/v1.0.0/audit/statuscode/COM:/api/v1.0.0/audit/statuscode/COM	-1		43007	2021-08-17 16:51:42
mi-gateway:audit-api:lossmmgr:/api/v1.0.0/audit/statuscode/WAT:/api/v1.0.0/audit/statuscode/WAT	-1		55993	2021-08-17 16:54:41
For now we want to use rate limiting with few URLs but we would like to make the url_pattern work. If you have any suggestions please let me know
Thanks,
Prashant

Thanks for the detailed response.
Can you try using ** instead of *

I think I have tried it already but will try it one more time tomorrow and will update you.

@marcosbarbero Thank you for your help, I am able to make it work with url_pattern
I had to debug the code to understand the issue.
The request.getRequestURI() in the apply method of URL_PATTERN in RateLimitType class contains the URI with the path /gw/audit/. Since we are using the stripPrefix: true I was not adding this path in the url_pattern. ( url worked fine without this path )
Along with the path addition had to use ** as the AntPathMatcher uses them. I have added the config that worked for me below.
    /**
     * Rate limit policy considering an URL Pattern
     */
    URL_PATTERN {
        @Override
        public boolean apply(HttpServletRequest request, Route route, RateLimitUtils rateLimitUtils, String matcher) {
            return new AntPathMatcher().match(matcher.toLowerCase(), request.getRequestURI().toLowerCase());
        }

Working Config
zuul:
  routes:
    audit-api:
      path: /gw/audit/**
      serviceId: audit-api-ms
      stripPrefix: true
      retryable: true
  ratelimit:
    enabled: true
    repository: JPA
    policy-list:                # Zuul rate limit policy list
      audit-api:                # custom policy name
        - limit: 2              # request number limit per refresh interval window
          refresh-interval: 60  # in seconds
          type:
           - user
           - url_pattern=/gw/audit/api/v1.0.0/audit/**
           - http_method=get


loginWithPopup not opening new tab correctly thus window.postMessage fails

Describe the problem
Sometimes, no new tab is opened when calling loginWithPopup on mobile devices but instead the current tab redirects to auth0.com. Thus, window.postMessage call fails on the authorization (auth0.com) origin as the other window does not exist. This is the error I was finally able to track down on the auth0.com/authorize?{...} page:
Unable to post message to https://example.com Recipient has origin https://example.auth0.com/

Here is a screenshot of the error message in the JavaScript console:

Additionally, sometimes upon calling loginWithPopup, a new tab is opened but the href is about:blank.
What was the expected behavior?
I expect when calling loginWithPopup that a new tab is opened instead of the current tab being redirected.
Reproduction
This bug is intermittent. However, if I continually try to log in, eventually the issue will happen.
Try the following steps on an iPhone iOS 16.1 on Safari with a login button with an onClick handler using loginWithPopup.
Environment

Version of auth0-react used: 1.10.2
Which browsers have you tested in? Safari on iOS 16.2
Which framework are you using, if applicable (Angular, React, etc): NextJS

Hi @spenweb - thanks for raising this
I've tried to reproduce this on Safari iOS 16 using https://codepen.io/adamjmcgrath/full/rNKXpJy and am not able to.
TBH, all the sdk does is window.open the authorization url - it doesn't have any control about how Safari should interpret window.open - but if it's opening the url in the same window, that looks like an issue with Safari - I've had a look around and can't find any reports of that issue
Can you perhaps share a video of it happening so I can observe the behaviour?
https://user-images.githubusercontent.com/1299658/207876211-980be250-fc51-4e8c-8d06-e25f5155e2b0.mov

Thank you for your review @adamjmcgrath. Unfortunately, the screen recording I have contains sensitive information. I have since moved away from using the login with popup feature and am simply redirecting for now. If I run across this issue again, I will attempt to capture a video or make a simple repo for testing.


Beta: Font refuse to load

Issue Description
Possibly occuring in all pages.

Browser Information

Browser Name, Version: Chrome only
Operating System: Windows 10
Mobile, Desktop, or Tablet: Desktop

Screenshot

When I tried to reproduce this in opera (which is based on chromium) I wasn't able to do so. But it's only happening with chrome as mentioned by you. The thing here is that the website looks exactly same on both the browsers.
We'll have to look into this deeply.
@QuincyLarson Thoughts?

Could you post the exact link where did you reproduce the error?
I have the same configuration as mentioned in the first post, I don't see any console errors though. (Temporary problem possibly?)

I see the same issue on every beta page. This, for example, is from this link:

I see the same issue on every beta page. This, for example, is from this  link.

This looks like an issue with the Content Security Policy. CC @BerkeleyTrue

I'm not aware of any fonts that we use that are sourced as data blobs. Our fonts are set up as .tiff files.

These are the totality of all our fonts.
I suspect some errant third party extension

Just to update you all, I still get the errors, in FCC, in Beta and while running FCC locally as well. It produces 33 errors every time.

@zk433 are you getting the same errors reported by @seifsg? Can you look in the staging branch and see whether any of these fonts are referred to anywhere in there? If not, it may be a dependency that's trying to load them.

@QuincyLarson Yes, it's exactly the same issue every single time. And always repeats 33 times.
I looked through the codebase and I couldn't find anything there. But based on some googling, it seems to be related to the Content Security Policy set up: 'font-src': "data:" should be added to it to allow for fonts to be loaded from data: URIs. I did find the content-security-policy-builder dependency, but that's as far as I got since I have no idea what it is that I'm looking for - this is way over my head, sorry!

@zk433 Thanks for doing this research.
@BerkeleyTrue would using font-src': "data:" like @zk433 proposed open us up to any additional threats that you can think of? If so, it sounds like this might solve this minor issue that several campers have independently reported.

Yes, it is possible that using font-src data would open us up to some volnurabilities.
Just to reiterate, we don't use any fonts in the form of data blobs. Neither should the page linked above require any fonts other than what we already link to. This is most likely a third part extension issue.

@BerkeleyTrue OK - thanks for the clarification.
@zk433 Can you try to open this in incognito tab with all of your Chrome extensions turned off and see whether you're still able to reproduce this issue?

@BerkeleyTrue , @QuincyLarson , yes 👍 ! There were no errors when using the incognito tab so I went through all my extensions and found that it was the Grammarly Chrome extension that was causing the errors! As soon as I disabled it, errors went away.
Well, that turned out to be a much simpler solution than I thought it would be :). But I learned a lot about the Content Security Policy so time well spent :)

@zk433 I'm glad that worked out.
Happy Coding


feat: add breakFunc argument to use break in the “map” function

[!TIP]
The owner of this PR can publish a preview release by commenting /publish in this PR. Afterwards, anyone can try it out by running pnpm add radashi@pr<PR_NUMBER>.

Summary
This PR adds the breakFunc argument to use break in the “map” function.
Related issue, if any:
For any code change,

[x] Related documentation has been updated, if needed
[x] Related tests have been added or updated, if needed
[ ] Related benchmarks have been added or updated, if needed
[ ] Release notes in next-minor.md or next-major.md have been added, if needed

Does this PR introduce a breaking change?
No
Bundle impact

Status
File
Size [^1337]
Difference

M
src/async/map.ts
149
+25 (+20%)

[^1337]: Function size includes the import dependencies of the function.

Hey @moowoonsunghoon, thanks for the PR! I appreciate you taking the time to contribute.
I think this could be a useful addition, but the use case may not be super common. That said, we can keep the PR open to gauge interest from the community. In the meantime, you can achieve a similar result using a for loop:
const prices: number[] = []
for (const symbol of stockSymbols) {
  const price = await calculateStockPrice(symbol)
  prices.push(price)
  if (sum(prices) > 100) {
    break
  }
}

Personally, I find the for..of version more readable, but I'm curious to hear your thoughts on the matter. Let me know what you think!
Thanks again for the contribution. I look forward to seeing more from you in the future!


Error in the log each time I start HA

I get the error in the log each time I start HA,
Logger: homeassistant.components.sensor
Source: helpers/entity_platform.py:567
Integration: Sensor (documentation, issues)
First occurred: 10:45:50 AM (1 occurrences)
Last logged: 10:45:50 AM
Platform google_home does not generate unique IDs. ID Google Home/device already exists - ignoring sensor.google_home_device

And the sensors is unavailable

As @Raul-7-7 has stated, please, @Rocologo we need some more info. Take a look at the troubleshooting guide to enable the extended logging, and paste some logs here.
Also, please, state the environment you are at, your HA version, and the integration's version.

I think what's going on here is we use device name for unique id and you have devices with the same names: "Google Home". We need to use something more unique for unique id, e.g. internal device id, serial number or mac address.

For tracking purposes here is the ticket for unique id generation

Hi Guys.
Sorry for not getting fast back to you. I had alot of problems with Home Assistant after installing HACS + Sonoff Lan + you Google addon. My HA started to make reboots without warnings, and after me trying to solve the basic problems, I ran into "disk full" on my NUC. And then my HA crashed totally. Luckily I had I backup, so I decided to make a total restore of HA, and because I did not really use HACS, Sonoff LAN + your addon, I decided not to install these Addons again.
So.... Im not able to reproduce the problem anymore. Im sorry.
I think the ticket for the unique Id is a good idea, because I had Google Home in my HA before I added your addon, so I looked like a confict with this
https://www.home-assistant.io/integrations/google_assistant/
I have made a manual install of this integration and are able to speak to all my devices in HA using this, but this also broke when I installed your addon.
Im not sure if you need this anymore, but I feel I owe you this: Im running HA in this setup.
A NUC running Linux/Debian fully updated. Virtualbox 6.1 and I have downloaded the vdi from here: https://www.home-assistant.io/installation/linux
Before crashing HA was fully updated with newest OS, Supervisor and Core
Kind regards
Rocologo

Thank you very much @Rocologo, we will take your info into account. We are working on fixing the multiple ID issue. Hope you don't have any more issues. Greetings.