Fix import dock "Set as default"

Pull Request Description:
This PR fixes importer dock "Set as default" and other related actions functionality. It ensures that when clicking this button, the currently edited importer properties get saved as the importer defaults.
Steps to reproduce:

Open Godot editor v3.0.alpha.build1.
Select an importable asset from the FileSystem dock.
Navigate to the "Import" dock tab.
Modify any of the importer properties.
Click on "Preset > Set as default for 'type'".

Results: Modified importer properties get reset to their original (default) values.
Expected Results: Modified importer properties get saved as the global default properties for the importer type.

I believe there's still work to be done in the importer process, since re-importing assets doesn't apply this previously saved configurations. I'll confirm this and either create a new issue or try and find a fix and create a new PR.

Added PR description (github went ahead and posted this for me prematurely... huh)


Don't error on "ok" as response.

This should fix #108.

 This doesn't fix the actual error because it will still enter the "else" statement.

... never mind, I was wrong in my above comment :P

Travis still failed though.
Can you ensure it doesn't fail locally?

@Manishearth Travis didn't fail anymore after the merge: https://travis-ci.org/Manishearth/ChatExchange

Oh, it says "1 check failed" above but it's still yellow. shrug

Looking at the build errors, it appeared that Travis didn't fetch the PR content well...

Yeah, but I got an email with green travis, so it's all good now


panic safety fix: guard against double drop

Hello :crab: ,
we (Rust group @sslab-gatech) found a memory-safety/soundness issue in this crate while scanning Rust code on crates.io for potential vulnerabilities. This PR contains a fix for the issue.
Issue Description
https://github.com/rustgd/glsl-layout/blob/119f5ec524dca42403db2aa07569baa349793e9b/src/array.rs#L177-L199
As the comments in the code indicates, the code above needs a patch for panic safety.
If a panic happens within f,
the item copied by ptr::read() can be dropped twice since the ownership of the item is duplicated.
Suggested Fix
I used ManuallyDrop<_> to contain values, in order to guard against double drop.
Thank you for reviewing this PR :+1:

This change is

p.s. the same issue exists for the code that matches the latest crates.io release (v0.3.2)

p.s. the same issue exists for the code that matches the latest crates.io release (v0.3.2)

Thanks. This looks exactly how it should be done.
It is possible to add a guard to drop values not yet read. But leaks are safe so it's not mandatory.

Thanks. This looks exactly how it should be done.
It is possible to add a guard to drop values not yet read. But leaks are safe so it's not mandatory.


Issue 1830/packets encoding

Purpose

How does the solution address the problem

Changes made

prnet cleaned-up successfully


Inbound Email notifications don’t work

It seems like sending push notifications with emails does not work.
After a brief look into the logs, I saw the inbound email service correctly forwarded the mail itself.
But still, the puffery server responded with a 404 Channel not found.
One quick guess: is resolving the email address prefix case sensitive?

The tests confirmed this hypothesis and the deployed fix actually solves the issue.
Though before closing this issue, we should search for other possible other cases. This should be located in the ChannelRepository.


Report incorrect annotations

If I add a [@dead] annotation to the declaration of a function f in an interface file, when f is actually live, then there is a report that the implementation is dead (assuming all the uses are from other modules). It would be more useful if such incorrect annotations were reported as such, rather than trusting them and misreporting on the implementation. I'm thinking of the use case of using the dead annotations as a way to record the current state of the dead code analysis, and thinking of what happens when a new use of a previously dead value is added. In that case, the old dead annotation is incorrect, and it would be helpful to report that.

I think it makes sense,
Curious: do you have an example where this happened?

There's actually one issue.
If you develop with a dead code PPX, as I'm doing in the sample projects. Then as soon as a @dead annotation is found, that code is gone, as if it had never been written.
So there's no opportunity to report a wrong annotation.
So I'm not sure so far.

Not having used the dead code analyzer for very long, this scenario is still hypothetical. But I'm working with a code base that I'm not yet familiar with, and there are several alternative implementations where one is dead at any given time. I don't want to remove the alternative implementations, but it would be good to know what code across the project is dead in the current configuration, to better understand refactoring constraints, etc.

Whatever you find out, curious to learn more from experience.
You should get the warning now.


CMYK input/conversion

I forked your project and incorporated a CMYK input/conversion for the Chrome option. Here's the repo in case you want to work it in. If you'd like, I'd be happy to issue a pull request. Just let me know.
https://github.com/dalumiller/vue-color

How's this play with array DB columns?

@dalumiller Sorry for the late reply. It would be great if you would issue the PR. Thanks in advance.


FR: state export/import for an executed board history

When you use a board like breadboard-ai.web.app you may end up with an execution which is of interest... maybe a thing broke, maybe you figured out a problem, or maybe you did something so cool you wanna show your buddies.
Right now you just take a screenshot.
part 1: export
But it would be better to have a JSON export for all of the state of the board execution

inputs (redacted secrets)
outputs (at the top because that's useful)
errors (at the top because that's useful)
node execution history, as inputs and outputs
board configuration details

This JSON data will be ugly, but a great artifact and it could be dropped into pastebin or something like that.
part 2: import
Given a JSON data, or perhaps a URL to JSON, load the full history into a board UI.
part 3: bonus
You could add annotations to a node, a comment, or highlight or something.  That might be a bridge too far, but it'd be useful for collaboration... like a flag for See this thing here, that's the problem

Part 1 should be done. I've done my best to redact secrets, but it's possible to still include them in various ways (like if we hardcode one into a URL, say).


Possible to install multiple crates in a task?

Sorry, not sure if this is a feature request or is already supported. I want my web building task to install two crates. Is this possible? I tried a space-separated string, as well as a list of strings. Not sure if there's an existing syntax for this, or if it just isn't supported.
Thanks.

i actually have a section on how to do that
https://github.com/sagiegurari/cargo-make#usage-installing-dependencies-multiple
tell me if that helps or it needs improvement

Wow, totally missed that. Apologies.
I'm trying to install trunk and wasm-bindgen-cli for a build task. I have:
[tasks.install-trunk]
install_crate = "trunk"

[tasks.install-wasm-bindgen-cli]
install_crate = "wasm-bindgen-cli"

[tasks.run-web-example]
dependencies = ["install-trunk", "install-wasm-bindgen-cli"]
cwd = "examples/web"
command = "trunk"

But running cargo make install-trunk gives:
[cargo-make] ERROR - Missing cargo command to invoke.
I've tried adding command = "trunk" and a couple other permutations, but none works. I basically just want to run cargo install trunk then trunk ... directly (I.e. not cargo trunk ...). What syntax do I need for that?
Thanks again.

see crate installation section
https://github.com/sagiegurari/cargo-make#usage-installing-crates
it has an example to do that

OK, got it figured out. I guess it isn't very clear when I can use
install_crate = "trunk" vs. the longer form. Given a choice, I'd
prefer the simpler syntax, and assumed it'd check for the crate's
presence for me.
Thanks.

its one of those features that started one way and than expanded and made me wish i could do some backward break :)
anyway, i hope this solves it for you


PACKAGES: main template Global key issue

Main template throws this exception on changing route, it doesn't hangs the app nor crashes it.
It says Global key GlobalKey<NavigatorState> being used by multiple widgets. But its only being used by MaterialApp and key is Modular.navigatorKey

MaterialApp(
      debugShowCheckedModeBanner: false,
      builder: (context, child) => LayoutTemplate(body: child),

      theme: ThemeData(
        primarySwatch: Colors.blue,
      ),
      darkTheme: ThemeData.dark(),
      themeMode: model.themeMode,
      initialRoute: Paths.home,
      onGenerateRoute: Modular.generateRoute,
      navigatorKey: Modular.navigatorKey,
      localizationsDelegates: [
        AppLocalizations.delegate,
        GlobalWidgetsLocalizations.delegate,
        GlobalMaterialLocalizations.delegate
      ],
      supportedLocales: const <Locale>[
        Locale('en'),
        Locale('es'),
        Locale('fr'),
        Locale('ur'),
      ],
    );

And the exception is
══╡ EXCEPTION CAUGHT BY WIDGETS LIBRARY ╞═══════════════════════════════════════════════════════════
The following assertion was thrown while finalizing the widget tree:
Multiple widgets used the same GlobalKey.
The key [LabeledGlobalKey<NavigatorState>#ccf3c] was used by multiple widgets. The parents of those
widgets were different widgets that both had the following description:
_BodyBuilder
A GlobalKey can only be specified on one widget at a time in the widget tree.

When the exception was thrown, this was the stack:
package:build_web_compilers/src/dev_compiler/C:/b/s/w/ir/cache/builder/src/out/host_debug/dart-sdk/lib/_internal/js_dev_runtime/private/ddc_runtime/errors.dart 196:49  throw_
package:flutter/src/widgets/framework.dart 246:13
<fn>
package:build_web_compilers/src/dev_compiler/C:/b/s/w/ir/cache/builder/src/out/host_debug/dart-sdk/lib/_internal/js_dev_runtime/private/linked_hash_map.dart 23:13      forEach
package:flutter/src/widgets/framework.dart 193:18
<fn>
package:build_web_compilers/src/dev_compiler/C:/b/s/w/ir/cache/builder/src/out/host_debug/dart-sdk/lib/_internal/js_dev_runtime/private/linked_hash_map.dart 23:13      forEach
package:flutter/src/widgets/framework.dart 189:26
<fn>
package:flutter/src/widgets/framework.dart 253:14
_debugVerifyGlobalKeyReservation
package:flutter/src/widgets/framework.dart 2700:21
<fn>
package:flutter/src/widgets/framework.dart 2780:16
finalizeTree
package:flutter/src/widgets/binding.dart 885:18
drawFrame
package:flutter/src/rendering/binding.dart 283:5
[_handlePersistentFrameCallback]
package:flutter/src/scheduler/binding.dart 1108:15
[_invokeFrameCallback]
package:flutter/src/scheduler/binding.dart 1047:9
handleDrawFrame
package:flutter/src/scheduler/binding.dart 963:5
[_handleDrawFrame]
package:build_web_compilers/src/dev_compiler/C:/b/s/w/ir/cache/builder/src/out/host_debug/flutter_web_sdk/lib/_engine/engine.dart
190:21                                <fn>
════════════════════════════════════════════════════════════════════════════════════════════════════
Another exception was thrown: Multiple widgets used the same GlobalKey.
Another exception was thrown: Multiple widgets used the same GlobalKey.
Another exception was thrown: Multiple widgets used the same GlobalKey.
Another exception was thrown: Multiple widgets used the same GlobalKey.
Another exception was thrown: Multiple widgets used the same GlobalKey.

done with https://github.com/getcouragenow/packages/commit/85b48fdd3540b1bab67841cc8831d7e140d43f5b


FRRouting doesn't start after enabling SNMP AgentX

for more information, see https://github.com/opnsense/plugins/issues/3166 …

:roll_eyes:

https://github.com/opnsense/plugins/issues/3608


Possibly incorrect ConvLSTM warping

Hello, thanks for releasing your work. I had a question regarding the implementation of the depth warping:
As I understand it, this is the current flow of the code during training:

Use current depth D_t as the current estimate. As mentioned in the paper, this is done for stabilization of training.
Compute the transformation from previous pose to current pose
Project current depth to point cloud and transform it using the above transformation, followed by sampling the hidden state

This does not seem correct to me. If we are using the current depth D_t, then there isn't any need for transforming the point cloud and we can directly sample the hidden state. Additionally, why transform the current depth by using a transformation of previous to current?
If we used D_t-1 as the depth estimate i.e. depth_estimation = depths_cuda[measurement_index] instead of depth_estimation = depths_cuda[reference_index] over here, then it would make sense.
It would be great if you could shed some light on this and correct me if I've gotten anything wrong!

LaTeX is broken for some reason, so I'm writing the next bits a bit weird.
Now there is another thing that may be the source of confusion: During testing, let alone having $D_t$, we are trying to predict it. So, we do a similar operation to the equation above to get $\tilde{D}_t$.
Now, instead of getting $Q_{t-1}$ from $D_{t}$,
we get (estimate) $\tilde{D}_t$
from $D_{t-1}$ by also considering occlusions between 3D points.
This is the preparation step for the inverse sampling. All in all, it may look like we are going back and forth, but it is necessary for sticking to inverse mapping paradigm. Otherwise, we have to deal with differentiable point cloud rendering: unproject hidden state at t1 to a 3D point cloud, and render it from the viewpoint at t. This is a highly complex and approximate operation. Keep in mind that, we don't want to break the gradient flow through the unrolled states of the ConvLSTM.
Note: I am not sure what you mean by the following,
"This does not seem correct to me. If we are using the current depth D_t, then there isn't any need for transforming the point cloud and we can directly sample the hidden state."
Hope it's a bit clearer.

I think my confusion stemmed from a misunderstanding of inverse mapping, I didn't realize projecting $D_t$ to $D_{t-1}$ was necessary before sampling. The explanation cleared it up. Thank you!


Can you sign your commit? Seems I am not an admin of the repo and it has that rule 😅


windows installation issue

I couldn't install it using pip install GoogleScrapper on my windows machine.
I tried it with python3.4,3.5, but it didn't work with any python version.
#####################################################
beautifulsoup4            4.6.0
bs4                       0.0.1
certifi                   2<IP_ADDRESS>
chardet                   3.0.4
cssselect                 1.0.1
idna                      2.6
lxml                      3.7.2                    py34_0
pip                       9.0.1                    py34_1
python                    3.4.5                         0
requests                  2.18.4
selenium                  3.5.0
setuptools                27.2.0                   py34_1
urllib3                   1.22
vs2010_runtime            10.00.40219.1                 2
wheel                     0.29.0                   py34_0
//////////////////////////////////////////////////////////////////////////
(py3.4) H:\Utility>pip install git+git://github.com/NikolaiT/GoogleScraper/
Collecting git+git://github.com/NikolaiT/GoogleScraper/
Cloning git://github.com/NikolaiT/GoogleScraper/ to c:\users\frank\appdata\loc
al\temp\pip-xcy6hjob-build
Complete output from command python setup.py egg_info:
running egg_info
creating pip-egg-info\GoogleScraper.egg-info
writing pip-egg-info\GoogleScraper.egg-info\PKG-INFO
writing requirements to pip-egg-info\GoogleScraper.egg-info\requires.txt
writing dependency_links to pip-egg-info\GoogleScraper.egg-info\dependency_l
inks.txt
writing entry points to pip-egg-info\GoogleScraper.egg-info\entry_points.txt
writing top-level names to pip-egg-info\GoogleScraper.egg-info\top_level.txt
writing manifest file 'pip-egg-info\GoogleScraper.egg-info\SOURCES.txt'
warning: manifest_maker: standard file '-c' not found
Traceback (most recent call last):
File "", line 1, in
File "C:\Users\Frank\AppData\Local\Temp\pip-xcy6hjob-build\setup.py", line
25, in
install_requires=requirements
File "C:\Anaconda3\envs\py3.4\lib\distutils\core.py", line 148, in setup
dist.run_commands()
File "C:\Anaconda3\envs\py3.4\lib\distutils\dist.py", line 955, in run_com
mands
self.run_command(cmd)
File "C:\Anaconda3\envs\py3.4\lib\distutils\dist.py", line 974, in run_com
mand
cmd_obj.run()
File "C:\Anaconda3\envs\py3.4\lib\site-packages\setuptools-27.2.0-py3.4.eg
g\setuptools\command\egg_info.py", line 195, in run
File "C:\Anaconda3\envs\py3.4\lib\site-packages\setuptools-27.2.0-py3.4.eg
g\setuptools\command\egg_info.py", line 222, in find_sources
File "C:\Anaconda3\envs\py3.4\lib\site-packages\setuptools-27.2.0-py3.4.eg
g\setuptools\command\egg_info.py", line 306, in run
File "C:\Anaconda3\envs\py3.4\lib\site-packages\setuptools-27.2.0-py3.4.eg
g\setuptools\command\egg_info.py", line 335, in add_defaults
File "C:\Anaconda3\envs\py3.4\lib\site-packages\setuptools-27.2.0-py3.4.eg
g\setuptools\command\sdist.py", line 159, in add_defaults
File "C:\Anaconda3\envs\py3.4\lib\distutils\cmd.py", line 299, in get_fina
lized_command
cmd_obj.ensure_finalized()
File "C:\Anaconda3\envs\py3.4\lib\distutils\cmd.py", line 107, in ensure_f
inalized
self.finalize_options()
File "C:\Anaconda3\envs\py3.4\lib\site-packages\setuptools-27.2.0-py3.4.eg
g\setuptools\command\build_py.py", line 34, in finalize_options
File "C:\Anaconda3\envs\py3.4\lib\distutils\command\build_py.py", line 55,
in finalize_options
self.package_dir[name] = convert_path(path)
File "C:\Anaconda3\envs\py3.4\lib\distutils\util.py", line 127, in convert
_path
raise ValueError("path '%s' cannot end with '/'" % pathname)
ValueError: path 'examples/' cannot end with '/'
----------------------------------------
Command "python setup.py egg_info" failed with error code 1 in C:\Users\Frank\Ap
pData\Local\Temp\pip-xcy6hjob-build\

It works on ubuntu, but when i run it with keyword "apple" as in your description, it returns with only ten or so results.

I just had the same issue.
go into setup.py and remove the '/' from this line: "package_dir={'examples': 'examples**/**'},"


Code example fix

Thanks for the nice library, just some minor fixes which I noticed when reading the documentation.
Line 65 add async function for await otherwise, it will not work.
Line 68 add quotes.
Line 366 throws error and server exit when the client sends a request. There is no need for next() function.

Thanks @nairihar jan for comments.
For the first 2 -  I am ok with fixes.
For the 3-d one (removing next) I don't agree.
Think we should allow to run next() even if we send reply. @davidharutyunyan ?

But there is an error when you calling next() function

I added back next function call instead I added the second handler for the same channel.


Rolling down beta to main

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.3 out of 4 committers have signed the CLA.:white_check_mark: tpmanley:white_check_mark: greens:white_check_mark: varzac:x: satyajitanandYou have signed the CLA already but the status is still pending? Let us recheck it.


Add release version label to all resources

Add the released version label to all files in config
Closes #381
Signed-off-by: Chmouel Boudjnah<EMAIL_ADDRESS>
Changes

Submitter Checklist

[x] ♽  Run make test lint before submitting a PR (ie: via pre-push github hook no need to waste CPU cycle on CI
[x] 📖 If you are adding a user facing feature or make a change of the behaviour, please make sure to document it
[x] 🧪 100% coverage is not a target but most of the time we would rather have a unit test if you make a code change.
[x] 🎁 If that's something that is possible to do please make sure to check if we can add a e2e test.
[x] 🔎 If there is a flakyness in the CI tests then make sure to get the flakyness fixed before merging or if that's not possible there is a good reason to bypass it.

See the contribution guide
for more details.

just a flakyness, other pr has merged with e2e passing since then,


fix: align sponsors and give background

[x] I have read freeCodeCamp's contribution guidelines.
[x] My pull request has a descriptive title (not a vague title like Update index.md)
[x] My pull request targets the master branch of freeCodeCamp.
[x] None of my changes are plagiarized from another source without proper attribution.
[x] All the files I changed are in the same world language (for example: only English changes, or only Chinese changes, etc.)
[x] My changes do not use shortened URLs or affiliate links.

Closes #35450

before:

After:

That's nice! Is the new layout the same in the default theme?

Looks great! Are we pushing this for production or this would be frozen for now and would release with the next release after the one we're prepping for?

@Bouncey thanks, Yes.
@thecodingaviator thanks, not sure.

@thecodingaviator This is a fix, so it is not affected by the feature freeze.
The feature freeze puts a hold on new features entering the code base. Fixes and chores are still important to merge before the release.


Feature Request: Rotation offset.

Some art packs have top down tokens at diagonals instead of facing down. In these cases, it would be nice to have a rotation offset angle that we could enter so the module would work correctly in those cases.

Seconded. Please please please implement this. The rotation offset in Foundry default works for initial token placement, but gets reset as soon as the token moves for the first time.

would love to see this feature also. A lot of horses are on a diagonal so hard to implement in conjunction with foundry vtt mount up currently.

Hey I had locked my updates until recently I'm updating everything and saw that this feature was added. Thank you so much!


Wont compile

When i click compile i get this error:
WARNING: Failed to remove contents in a temporary directory 'C:\Users\josia\Downloads\PySilon-malware-main\PySilon-malware-main\pysilon\Lib\site-packages~il'.                                                                                You can safely remove it manually.
How to reproduce: i just clicked compile and thats it
Edit: i waited a bit and it compiled but when i try running it, it gives me this error:
Traceback (most recent call last):
File "resources\discord_token_grabber.py", line 5, in
ModuleNotFoundError: No module named 'requests'

the bot needs to be online (https://dashboard.botghost.com/ for the bot to be online)

I did that just now and

it still gave me the error

Do you have python from 3.11.1?

i can check but i think i do

@HeckerMan-png use the latest version of pysilon, this particular bug has been fixed in latest ver

I got the info by myself, as I done some research

still shows the same error for me on latest version.


Move the sorted column arrow closer to the column name

It looks like the table is sorted by fees and not by liquidity depth:

@pingustar Does this throw a spanner in the works given the b-table setup?

@Velua yes, some more background info can be found here: #151

new table component fixes this. Will be applied to all tables in the coming days. Closing this.


Use keyword arguments for calls to cli.set_env_vars

Fixes #268
Options were not being properly propagated due to not specifying arguments correctly when calling cli.set_env_vars

Coverage remained the same at 42.024% when pulling a0b32cdffe48f8f371a9727ac278af84ebb180d7 on issue-268 into e13b91ccd61eef085cb49cd542df98be17859713 on master.


Linting for when a backtick is followed only by white space

Moved from https://github.com/PowerShell/vscode-powershell/issues/69

I've been bitten by this bug a few times:
$oven = Toast-Bread `
    -Bread Wheat

You probably can't see the problem - there's a space after the backtick, which causes the parser not to take the next line as part of the command, causing the command to be issued without the Bread parameter. It would be great if vscode-powershell highlighted this issue because I'm sure it's almost never done intentionally.
This seems to be a PowerShell problem generally - why isn't a backtick followed only by white space and a newline handled the same as a backtick immediately followed by a newline?

Related conversation: https://github.com/PowerShell/PSScriptAnalyzer/issues/218

Yeah, this makes a lot of sense to me as a warning.
Is everyone onboard with warning as the severity level? If you really intend to escape a space, add a SuppressMessage attribute.

Or maybe make the rule scoped to backticks followed by arbitrary whitespace and a newline

Good point.

Andrew added the new rule!
https://github.com/PowerShell/PSScriptAnalyzer/pull/425


Emojis/Icons for programming languages

Recently started using this for making personal knowledge bases, and although not a big thing, it would be nice to have emoji/icons/stickers for different programming languages. Any possibility of this? :)

It's most likely "as complex" as making some changes to this file: https://github.com/silverbulletmd/silverbullet/blob/main/plugs/emoji/emoji.json -> adding the emoji and setting a suitable tag to it.

I don't fully understand, have emojis for programming language? Like a "Java" emoji? If you can map an emoji to an existing emoji (part of the emoji standard), like :python: to 🐍  or something, @bbroeksema 's suggestion would work. Custom emojis (as in: custom images) would be a different story. Also doable, but a different implementation approach required.

Yeah I meant more like being able to use custom images probably. For example do :typescript and get something like this: https://slackmojis.com/emojis/1383-typescript

So basically this would amount to custom emoji right? That may be nice to have.

We have custom emoji configuration, we have image attachments, I think if we had syntax to include an image inline and make its height equal to line height, this could be implemented nicely.

Side effect: inline images acould be nice for e.g. runes and other cool symbols not in Unicode and/or the font

This is going to be my solution for everything now, but once Space Lua stabilizes I think we can indeed implement this feature in a library combining some images with a simple Lua function that renders as an image (I still have to decide if supporting literal HTML can be done somewhat securely). In that case the flow would be: install some Library that imports a bunch of programming language libraries, then you could inline their icons using e.g. ${lang "python"} (which would then render as the Python logo.

I'd say that supporting |inline size specifier is easier to understand and doesn't need any library script. Both give it a lower barrier to entry, but I will have a more informed opinion when I actually attempt to write it and use a bit

It definitely needs some work in same places as #827 and #833, but is really simple: https://github.com/Maarrk/silverbullet/commit/62bcdaacbf3b9da4167789b7db67923d1b4b4fb6

On the other hand, I'm not sure if it's worth pursuing this way at all, since some of the coolest places where we use emoji can't work with widgets:

A much simpler alternative would be to write a nice documentation on how to serve more fonts that include the desired icons, and setup emoji aliases for these.


[Translation] Support manifests and nginx

Description
Support manifest and refine docker compose for Translation example.
Issues
n/a
Type of change
List the type of change like below. Please delete options that are not relevant.

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds new functionality)
[ ] Breaking change (fix or feature that would break existing design and interface)
[ ] Others (enhancement, documentation, validation, etc.)

Dependencies
None
Tests
Local tested

The Check Paths and Hyperlinks issue will be fix by @ZePan110 in this PR: https://github.com/opea-project/GenAIExamples/pull/826


Use PT timeout on CI only

@losipiuk @wendigo PTAL

CI  https://github.com/prestosql/presto/issues/6024


Add hover hook

Adds Hooks.hover
Also switches ClickableText and TodoExample to use it.

/azp run


fix for #KARAF-4486

fix for #KARAF-4486
very simple change

Closed by https://github.com/apache/karaf/commit/dde032a99b355c710193b83d0f7437d9caaeda8a


Move total time in Module Details to the top right corner

Issue has been completed in Compare tab for multiple profiler files #140 https://github.com/BalticAmadeus/ProPeek/issues/140


Per connector ignoreFieldOrder and additional CB it enablement

Addresses: #1601, #1668, #1607

Current coverage is 63.89% (diff: 0.00%)

Merging #1696 into master will decrease coverage by 0.03%

@@             master      #1696   diff @@
==========================================
  Files           350        350
  Lines         16572      16580     +8
  Methods       16293      16301     +8
  Messages          0          0
  Branches        139        139
==========================================
  Hits          10594      10594
- Misses         5978       5986     +8
  Partials          0          0

Powered by Codecov. Last update 5c18961...c393885

So I can stop checking it constantly … I’m happy to merge this whenever it’s green. Just let me know ;)

For sure. Thought I had all the tests that required ignoreFieldOrder marked, but looks like I missed another. Will let you know when ready.

@sellout Ready.


Gradle Enterprise information about transitive dependencies is sometime wrong/misleading

Expected Behavior
Gradle Enterprise should accurately represent the dependency tree for each project
Current Behavior
Gradle Enterprise displays information about transitive dependencies of projects that can be misleading/inaccurate.

The path module 3 > modules 1 > fileupload > io is not an actual path.
Context
In big projects (400+ sub-projects) it makes it difficult to find where a transitive dependency is leaking back in the project - the information is Gradle Enterprise is not as useful as it could/should be.

Steps to Reproduce
See reproducer (attached)

reproducer:
gradle-17848.zip


(1977) Move back button to under phase banner

This moves the back button to under the phase banner to avoid the awkward spacing issues we have had and also DRY up the templates. I've also added a BackLink decorator, which sets the backLink without it having to be present in templates.
Screenshots of UI changes
Before

After

Very happy about the back link decorator!

Ta for the review! 👍


Add support for RedM

Add support for RedM - Red Dead Redemption Multiplayer

The redm.py is the same as the fivem.py. You just need to set the query type as fivem for redm server.
You removed the gportal in __init__.py. Please make sure your repo is up to date before the pull request.
You just need to edit the games.csv in this case, I will add by myself this time, thanks.
redm,Red Dead Redemption 2 - RedM,fivem,port=30120


Issue 1989: Support Content-Encoding: deflate

This change adds support for Content-Encoding: deflate, and fixes a bug so that if an unrecognized Content-Encoding type is encountered we pass it through instead of removing it and making recorded stubs unusable.
Prior to these changes, if a Content-Encoding header is present, we remove it.  However, we only decompress the body if the Content-Encoding is gzip. If we're going to remove the header, we should also decode the content, and vice-versa.
Also, added .gitattributes so that when spotlessApply is used on Windows line endings are not changed to CRLF.

@mrsalt Are you still interested in this PR? There is another one from @craftsman228 in the same area, and IIUC the quick discussion with @tomakehurst the change would need some refactoring. Would you be interested to work together in the coming weeks? Or would you be fine if we take the lead and refactor this pull request to get it  over the line? Thanks for your time!

@mrsalt Are you still interested in this PR? There is another one from @craftsman228 in the same area, and IIUC the quick discussion with @tomakehurst the change would need some refactoring. Would you be interested to work together in the coming weeks? Or would you be fine if we take the lead and refactor this pull request to get it over the line? Thanks for your time!

@oleg-nenashev I apologize for being slow to reply.  I'm not sure what specifically needs to be done, so it sounds better for you all to take the lead.  I'd like to review what you do though.

@mrsalt ack, thanks! I think we still need one implementation to be landed


feat(katana): Get storage multiple

Highlights

The structure is chosen to have compact requests and responses.
If the parameter storage_addresses seems complicated, it could be broken into,

contract_address: FieldElement
keys: Vec<FieldElement>
But this limits to storage from one contract per call

To have them Felts in nested Vecs be more semantic, I'm using some type aliases. Hopefully they'll be picked up at docs generation.
RPC method is getStorageAtMultiple, does that make sense?
We could also return hash map with key: value if we want more readability. But since storage addresses are hashed anyway, it wouldn't be tremendously better.

Parameters:
(
  storage_addresses: Vec<
    (
      ContractAddressFieldElement,
      Vec<StorageKeyFieldElement>
    )
  >
)

Returns:
Result(
  Vec<
    Vec<Felt>
  >
)

Parameters:
(
  storage_addresses: Vec<
    (
      ContractAddressFieldElement,
      Vec<StorageKeyFieldElement>
    )
  >
)

I'm more leaning towards keeping the api simple and limit the params to a single contract address only. wdyt @tarrencev ?

RPC method is getStorageAtMultiple, does that make sense?

Maybe getStorageAtMany sounds better? I'm up for suggestions.

We could but it'll be at least 60% larger payload.
Which'd be totally fine after we switch to gRPC though.

We could but it'll be at least 60% larger payload. Which'd be totally fine after we switch to gRPC though.

Yup and with gzip it would be negligible, since repeated data is easily compressed

Yup and with gzip it would be negligible, since repeated data is easily compressed

Ahh true!


core: Update messages/init.py to account for AIMessageChunk which breaks message history runnable.

Description: fix parse issue for AIMessageChunk when using
Issue: https://github.com/langchain-ai/langchain/issues/14511
Dependencies: none
Twitter handle: none

Taken from this fix: https://github.com/gpt-engineer-org/gpt-engineer/issues/804#issuecomment-1769853850
Please make sure your PR is passing linting and testing before submitting. Run make format, make lint and make test from the root of the package you've modified to check this locally.
See contribution guidelines for more information on how to write/run tests, lint, etc: https://python.langchain.com/docs/contributing/
If you're adding a new integration, please include:

a test for the integration, preferably unit tests that do not rely on network access,
an example notebook showing its use. It lives in docs/docs/integrations directory.

If no one reviews your PR within a few days, please @-mention one of @baskaryan, @eyurtsev, @hwchase17.

holy cow... that merged quick.  Thanks!


BUG Fix broken form actions on parent and nested gridfields

Substitute fix for code removed from https://github.com/silverstripe/silverstripe-framework/pull/5854#issuecomment-236487239 (for context).
However, this PR doesn't depend on that PR. :)

Looks good. No tests though, be good to get a behat test to show the things that didn't work now do, but no biggy.


Something Wrong in v3.0.1

StandardTag not compile correctly

@Aliang-code I just released version 3.1.0, could you check if you still have the issue?


Error during QuickSpec pruning (no instances)

Running emna on the following Haskell code:
data List a = Empty | Cons a (List a)

listMap :: (a -> b) -> List a -> List b
listMap f Empty       = Empty
listMap f (Cons a as) = Cons (f a) (listMap f as)

prop :: List a -> Equality (List a)
prop a = listMap id a === a

causes the following error:
emna: src/QuickSpec/Pruning.hs, line 100: No instances in
  [a, List a]
for
  listMap x Empty = Empty :: List a
under
  [x :: c -> a, Empty :: List a, Empty :: List c,
   listMap x Empty :: List a]

However, running it manually on the generated TIP code (from tip-ghc) works fine:
(declare-datatypes (a)
  ((List2 (Empty) (Cons (Cons_0 a) (Cons_1 (List2 a))))))
(define-fun-rec
  (par (a b)
    (listMap
       ((x (=> a b)) (y (List2 a))) (List2 b)
       (match y
         (case Empty (as Empty (List2 b)))
         (case (Cons a2 bs) (Cons (@ x a2) (listMap x bs)))))))
(assert-not
  (par (a)
    (forall ((b (List2 a))) (= (listMap (lambda ((x a)) x) b) b))))
(check-sat)

Use the v2-dan branch on quickspec
/Dan
On 9 March 2016 at 15:39, chip2n<EMAIL_ADDRESS>wrote:

Running emna on the following Haskell code:
data List a = Empty | Cons a (List a)
listMap :: (a -> b) -> List a -> List b
listMap f Empty       = Empty
listMap f (Cons a as) = Cons (f a) (listMap f as)
prop :: List a -> Equality (List a)
prop a = listMap id a === a
causes the following error:
emna: src/QuickSpec/Pruning.hs, line 100: No instances in
[a, List a]
for
listMap x Empty = Empty :: List a
under
[x :: c -> a, Empty :: List a, Empty :: List c,
listMap x Empty :: List a]
However, running it manually on the generated TIP code (from tip-ghc)
works fine:
(declare-datatypes (a)
((List2 (Empty) (Cons (Cons_0 a) (Cons_1 (List2 a))))))
(define-fun-rec
(par (a b)
(listMap
((x (=> a b)) (y (List2 a))) (List2 b)
(match y
(case Empty (as Empty (List2 b)))
(case (Cons a2 bs) (Cons (@ x a2) (listMap x bs)))))))
(assert-not
(par (a)
(forall ((b (List2 a))) (= (listMap (lambda ((x a)) x) b) b))))
(check-sat)
—
Reply to this email directly or view it on GitHub
https://github.com/danr/emna/issues/6.

Thanks, that solved that problem. However, I get another error now (which I think I've encountered before):
https://gist.github.com/chip2n/07e393bbd2154ad65838

Yes, this is because the translation of not perfectly saturated function
calls from QuickSpec is wrong.
This can probably be fixed by translating all function calls as
applications with At as Head, and functions to curried eta-expansions,
somewhere around this line:
https://github.com/tip-org/tools/blob/master/tip-spec/src/Tip/QuickSpec/Translate.hs#L112
For instance, say we have a function f which takes two arguments. We
translate it then to (lam x (lam y (f x y)).
When we get a QuickSpec application of for instance f t, we will then
translate that to the reducible (@ (lam x (lam y (f x y)) t), and say we
have f t u v, we get (@ (@ (@ (lam x (lam y (f x y)) t) u) v).
On 9 March 2016 at 15:57, chip2n<EMAIL_ADDRESS>wrote:

Thanks, that solved that problem. However, I get another error now (which
I think I've encountered before):
https://gist.github.com/chip2n/07e393bbd2154ad65838
—
Reply to this email directly or view it on GitHub
https://github.com/danr/emna/issues/6#issuecomment-194333104.


Update property name

For #

[ ] Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR).
[ ] Title summarizes what is changing.
[ ] Has a news entry file (remember to thank yourself!).
[ ] Appropriate comments and documentation strings in the code.
[ ] Has sufficient logging.
[ ] Has telemetry for enhancements.
[ ] Unit tests & system/integration tests are added/updated.
[ ] Test plan is updated as appropriate.
[ ] package-lock.json has been regenerated by running npm install (if dependencies have changed).

Thanks for fixing my typos

Codecov Report

Merging #6806 (db0302a) into main (9425a4a) will decrease coverage by 0%.
The diff coverage is 50%.

@@          Coverage Diff           @@
##            main   #6806    +/-   ##
======================================
- Coverage     68%     68%    -1%
======================================
  Files        411     411
  Lines      28628   28628
  Branches    4280    4280
======================================
- Hits       19692   19502   -190
- Misses      7264    7445   +181
- Partials    1672    1681     +9

Impacted Files
Coverage Δ

src/client/api/pythonApi.ts
57% <50%> (ø)

...ience/variablesView/variableViewMessageListener.ts
22% <0%> (-78%)
:arrow_down:

...ent/common/application/webviewViews/webviewView.ts
14% <0%> (-72%)
:arrow_down:

...c/client/datascience/variablesView/variableView.ts
18% <0%> (-62%)
:arrow_down:

src/client/common/application/webviews/webview.ts
13% <0%> (-54%)
:arrow_down:

src/client/datascience/webviews/webviewViewHost.ts
19% <0%> (-53%)
:arrow_down:

...on/application/webviewViews/webviewViewProvider.ts
80% <0%> (-20%)
:arrow_down:

.../datascience/variablesView/variableViewProvider.ts
65% <0%> (-16%)
:arrow_down:

...lient/datascience/variablesView/notebookWatcher.ts
80% <0%> (-14%)
:arrow_down:

src/client/datascience/webviews/webviewHost.ts
80% <0%> (-7%)
:arrow_down:

... and 18 more


KeyborgCallback not exported

Libraries that want to type callbacks for keyborg don't have the appropriate type and are resorting to deep imports microsoft/fluentui#20892

Yeah, it is, I just forgot to ever merge it :), I'll merge and release


[Bug] cannot get the list of consoles

Platform

Device: Phone, Laptop
OS: Windows, Android
Browser: Chrome, Kiwi
Browser Version:
Better xCloud Version: 3.1.5

Describe the bug
Cannot get the list of consoles to start remote play since hours ago but it worked before, meanwhile the official Xbox Beta app is able to stream and play.
When I look into the dev tool, I find that it failed to connect to https://wus2.gssv-play-prodxhome.xboxlive.com/v6/servers/home?mr=50 , which may relate to the problem.
By the way, I'm trying from China and also tried Japan's VPN.
Screenshots/Videos

The WestUS2 server for Remote Play is down at the moment.
You can use this version to switch to EastUS: https://github.com/redphx/better-xcloud/raw/main/better-xcloud.user.js

That works, thank you!


Adding an item did not animate the view

I used the following code to insert an item at the start of the list ie, position 0       itemAdapter.addModel(arr, news); ,the item got added but i had to scroll to view the item that just got added.There was no animation that took place that pushed all other elements down like it would with the default implementation of the recycler view.Am i missing a piece of code that enables animations?

Did you set an item animator on RecyclerView?

@ankitbatra11 I have not,i was under the impression that addModel was internally calling notifyiteminserted which would automatically animate the view using the default animator of the recycler view.Do i need to set a default animator ,if so how?

I can't access my Mac right now but it must be recyclerview.addItemAnimator(new DefaultItemAnimator())

@judemanutd yes the add methods will automatically call the internal notify methods. Just make sure you call these methods on the UI thread. If it happens on any other thread it won't work.
I think the RV has already by default the animator set, but you can define it again and make sure. (Thanks @ankitbatra11 )

I am using rxjava and this i my current code.
                                  `Observable.fromIterable(newses)
                                  .subscribeOn(Schedulers.computation())
                                 .observeOn(AndroidSchedulers.mainThread())
                                 .subscribe(news -> UserDataRepository.getUser(news.getPosterId())
                                .doFinally(() -> {

                                    // Updating Ui here
                                })
                                .observeOn(AndroidSchedulers.mainThread())
                                .subscribe(User -> {
                                    count++;
                                    dataRepository.addUserToNews(news, User);

                                    final List<News> arrayList = itemAdapter.getModels();

                                    if (arrayList.size() > 0) {

                                        for (int arr = 0; arr < arrayList.size(); arr++) {
                                            if (news.getPostDate() > arrayList.get(arr).getPostDate()) {
                                                itemAdapter.addModel(arr, news);
                                                break;
                                            } else if (arr == arrayList.size() - 1) {
                                                itemAdapter.addModel(news);
                                                break;
                                            }
                                        }
                                    } else {
                                        itemAdapter.addModel(news);
                                    }

                                }, throwable -> Log.i("retrofit", throwable.getLocalizedMessage())));`

I even manually set the default animator to the recycler view but the item did not animate.

@judemanutd have you tried doing it via an handler to make sure doing it via rx is not the problem?
Android is very unpredictable if things were not done on the correct thread (and yes I have seen that you would do it via the mainThread scheduler)

I added the following code
Handler handler = new Handler();         handler.post(new Runnable() {         @Override         public void run() { 			itemAdapter.addModel(chatMessages.get(position));         }         });
but it didn't make a difference.
There was also another part similar to this that was casuing an issue where i am notifying the adapter that an item was changed but it wouldn't reflect the changes.
Handler handler = new Handler();                         handler.post(() -> itemAdapter.setModel(position, chat));
I am notifying the adapter that a specific item was changed but the changes don't reflect.

try Handler handler = new Handler(context.getMainLooper());

@FabianTerhorst tried that ,did not work,for now i am using this workaround.
 linearLayoutManager.smoothScrollToPosition(recyclerView, null, itemAdapter.getItemCount());
@mikepenz @FabianTerhorst Is there a way to notify the adapter that only a single item in the view is modified rather than updating all items of that specific item.
For example if my viewHolder contains 2 text views and only 1 of them needs to be changed while the other kept the same,is there a way to do that?As of now when a notify function is called then the onBind is called which updates all items of the view.

@judemanutd you do not have to notify the adapter or anything. The FastAdapter / and it's ItemAdapter already takes care of this.
So if you call .add() it will automatically call the correct notify method for this


Feature/design feedback

See commit messages for changelog.

This is great Erik! 😍
Some minor feedback:

Button groups (top 5 - stress conditions have 1px border radius)
Sourcing and destination county borders are 1px 50% opacity, not solid black.
Hide the non-active counties (and roads, if it applies) when interacting with the Top 5 / All selector
Same as above when hovering on a county, either on the map or on the sidebar list
I understand we are waiting for the drought data to be ready and the stress styles are not implemented.

Looking fantastic otherwise 👍


Testing RobotOS.jl

Currently tests fail because of (1) missing dependencies and (2) a need to set up a testing environment before starting Julia.
I was trying to solve problem (2) by starting the environment in my test script but couldn't get it working. So I figured I'd just open the issue and see what you thought.
Here are the travis commands I use:
language: julia
julia:
  - release
  - nightly
before_install:
  - sudo apt-add-repository -y "deb http://packages.ros.org/ros/ubuntu precise main"
  - wget https://raw.githubusercontent.com/ros/rosdistro/master/ros.key -O - | sudo apt-key add -
  - sudo apt-get update
  - sudo apt-get -y install ros-hydro-ros-base
  - sudo apt-get -y install ros-hydro-common-msgs
  - sudo rosdep init
  - rosdep update
before_script:
  - source /opt/ros/hydro/setup.sh
  - roscore &
  - sleep 5
  - python test/republish.py &
  - sleep 5
after_script:
  - killall roscore
  - killall python
  - sleep 5

If there isn't a simple fix for this, I suppose it would be fine to just mark the package as untestable.

Yeah thats way beyond the level of dependency/setup/teardown PkgEval is designed for, I'll just make it as untestable.

Thanks!


Rethink the dlog.Logger interface

The 1.x dlog.Logger interface is simple-to-implement but "slow" in that non-logged formatting can't be optimized out. Implementations can opt-in to such an optimization by also implementing the dlog.OptmizedLogger interface, but it's more complex.
There's some thinking that it's a design flaw that it's so easy to do the slow thing.
See the discussion on https://github.com/datawire/dlib/pull/33

Related art: logr.LogSink https://pkg.go.dev/github.com/go-logr/logr#LogSink
logr.LogSink has an .Enabled(level) method that can be used to implement this optimization, without delegating formatting to the backend. However, this limits the backend to only be able to filter based on the loglevel, and nothing else.


Use key instead of keyCode for keyEvent helper?

According to MDN, keyCode is deprecated in favor of key. Thoughts on updating the keyEvent helper to accommodate that?

I am aware. However now the helpers of this projects are becoming "official" and have been copied into https://github.com/emberjs/ember-test-helpers/.
During the migration I left a comment here and there is an issue to do it soon: https://github.com/emberjs/ember-test-helpers/issues/265
Since now many helpers of this addon are becoming "official" inside @ember/test-helpers, if we fix it it will be in that repo. Those helpers here will be deprecated and eventually removed.

Gotcha. Thanks for the info, I didn't realize ember-native-dom-helpers is becoming part of ember-test-helpers.


Fortran linter

@swenczowski
I have for some time had a collection of regex'es for "cleaning" up old Fortran code that I manually applied to code whenever I saw some necessity. I decided to collect, clean up and make it a bit more streamlined.
The result is this simple Fortran-linter that will detect some common style issues (see CONTRIBUTING.md for some style guidance).
Example of how it looks like when the linter finds something it does not like:

Most of the errors like this can be fixed with --fix <filename>  or --fixall to the linter script, but "complex problems" like too long lines cannot be fixed automatically - this is a manual task. The linter is based on regular expressions and is by no means a language parser - so it cannot do anything complex.
Fixes need to be applied, inspected and committed manually. I do not trust the script enough to enable automatic fixing. Only the lines that are affected by a particular PR is checked - this means that lingering linter errors in the codebase will not pop up in the next PR again.
I find this useful when working - and particularly the --fixall. I hope you also find it useful.

That sounds interesting and could be helpful. I do not have experience with such tools and am curious to make some practical experience with it.
Best regards,
Simon


[bug] WalletConnect QR code not appearing

Is there an existing issue for this?

[X] I have searched the existing issues

RainbowKit Version
1.0.7
wagmi Version
1.4.3
Current Behavior
Clicking WalletConnect does not surface a QR code despite configurations
I see a seemingly related error in the console whose stacktrace includes walletconnect.js but not sure how to make sense of it:
index.mjs:152 Uncaught (in promise) TypeError: n is not a function
    at index.mjs:152:20
    at async a.getItem (9.b5a06b3b.chunk.js:2:219759)
    at async 9.b5a06b3b.chunk.js:2:221374

Anyone seen anything like this before?
Expected Behavior
Clicking WalletConnect should surface QR code
Steps To Reproduce
You can try the application in production here: https://zkp2p.xyz/
Go to Connect Wallet > WalletConnect
See config file here: https://github.com/zkp2p/zk-p2p/blob/develop/client/src/index.js.
Link to Minimal Reproducible Example (CodeSandbox, StackBlitz, etc.)
No response
Anything else?
No response

Hey @asoong. Are you able to update @rainbow-me/rainbowkit and wagmi package to the latest version ?
Also can you look at your project id and make sure it's configured correctly on the wallet connect dashboard ? Usually when a qr code is not appearing it has to do with the project id most of the times.
We also have an example repo here to look at. Here is the preview link as well.

Thanks for getting back to me.
I tried updating the packages to the latest here and also double checked my project id config. Neither seems to have done the trick.

@asoong It is possible that you're seeing a dependency bundling/resolution issue bubble up as this behavior. The WalletConnect libraries under the hood of Wagmi can sometimes be temperamental. Here is our example Next.js app config to compare against. Additional  docs discussing this are here. Let me know if this doesn't resolve the issue!

Closing for now, but let me know if your issue persists after the above!


DBDAART-4575 PRV & APR prvdr_id long values

What is this and why are we doing it?
to address the issue of long provider ID values, greater than 12 characters, in the PRV & APR Identity & Group segments

Link to the Jira ticket for this change:
https://jiraent.cms.gov/browse/DBDAART-4575

What are the security implications from this change?
none
How did I test this?
notebook in databricks VAL
Should there be new or updated documentation for this change? (Be specific.)
no
PR Checklist

[x] The JIRA ticket number and a short description is in the subject line
[x] My code follows any applicable style guides
[x] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation

GM @alihashmi-wh, could you please add a link to your Notebook used for testing?


Region 2

Howdy
Me again. How easy would it be to hook this up to region 2?

I got it working for region 2 by updating endpoints.py. Have not done full testing but it logged into sunsynk and pushed some data to MQTT
#login_endpoint = ('https://pv.inteless.com/oauth/token')
#plants_endpoint = ('https://pv.inteless.com/api/v1/plants?page=1&limit=10&name=&status=')
#energy_base_url = "https://pv.inteless.com/api/v1/plant/energy/"
login_endpoint = ('https://api.sunsynk.net/oauth/token')
plants_endpoint = ('https://api.sunsynk.net/api/v1/plants?page=1&limit=10&name=&status=')
energy_base_url = "https://api.sunsynk.net/api/v1/plant/energy/"
inverter_list_url = "https://api.sunsynk.net/api/v1/inverters?page=1&limit=10&status=-1&type=-1"

Hello!
Yeah, just needs a minor update to the api urls. @chris2172 If you wanna open a PR for that, I'd be quite happy to merge it in!

If there are no more users in Region 1 it is simple to replace the URLs
But if there are still users in Region 1 then it would be best to add a Region selector in the config
@ThePheonixGuy

resolved in https://github.com/ThePheonixGuy/sunsynk-scraper-addon/pull/24


Removed unnecessary tree building for CatBoost

There is no need to build trees, since all shap values are available from the CatBoost. I suggest just get everything back as it was in 0.29.1. The need arose in connection with issue https://github.com/slundberg/shap/issues/662

I should probably check and make sure that all the same cases are supported, but if the tree building is failing we should at least make it a soft-fail and use CatBoost whenever we can. Perhaps just wrap this in a try rather than a full delete for the moment?

Hello, @lupusomniator . I have implemented the code that you suggest to delete. This tree building is necessary for calculation of SHAP values for binary classification. While the code you are referring to calculates SHAP values only for regression task. Just look at these issues: https://github.com/catboost/catboost/issues/668
https://github.com/slundberg/shap/issues/576
@lupusomniator, hold your horses. To break - not to build.

Hello, @lupusomniator . I have implemented the code that you suggest to delete. This tree building is necessary for calculation of SHAP values for binary classification. While the code you are referring to calculates SHAP values only for regression task. Just look at these issues: catboost/catboost#668
#576
@lupusomniator, hold your horses. To break - not to build.

Yeap, I was wrong. I'll close this review and will fix the existing problem by the next commit.


YML generation

Hi,
I there a way to generate the yml automatically on reading XLSX file or PG table ?
Thank you
Jonathan

No.
Could be an enhancement.


ContractKit->0.4.18-dev, CLI->0.0.61-dev

Description
ContractKit->0.4.18-dev
CLI->0.0.61-dev
Related issues

Fixes #5577

LGTM


Add IS NOT NULL operator

Hi! I'm unable to filter non-null values in CH with this syntax: NOT "x" IS NULL. It is invalid for CH. The correct expression is "x" IS NOT NULL. I added NotNullCriterion term to get things done. Thanks.

Coverage increased (+0.006%) to 98.325% when pulling 2f4a6b5e12c4f61991efa115d014bc6502ab5cf7 on khokhlin:add-clickhouse-isnotnull into 6ff9fa2ffeac40dd59c4c8392302ac6e0940b53c on kayak:master.


feat: sync ledgetech/lua-resty-http

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.1 out of 5 committers have signed the CLA.:white_check_mark: spacewander:x: bootjp:x: pintsized:x: Invizory:x: TieskeYou have signed the CLA already but the status is still pending? Let us recheck it.

Surpass https://github.com/api7/lua-resty-http/pull/7


Remove extension DragonBones (planed to remove in next release axmol-2.3.0)

Describe your changes
see CHANGELOG.md (axmol-2.1.0 Jan.20 2024)
Mark as deprecated, and will be removed in next release axmol-2.2.0
Extensions DragonBones
extension GUI: changed description (Reason: replacing with ax::ui is not so easy):
GUI - Deprecrated, should only used for the axmol test suit (e.g. cpp-tests)
Issue ticket number and link
Checklist before requesting a review
For each PR

[ ] Add Copyright if it missed:
- "Copyright (c) 2019-present Axmol Engine contributors (see AUTHORS.md)."

[ ] I have performed a self-review of my code.
Optional:

[ ] I have checked readme and add important infos to this PR.
[ ] I have added/adapted some tests too.

For core/new feature PR

[ ] I have checked readme and add important infos to this PR.
[ ] I have added thorough tests.

For new release strategy, should remove in release +2  aka 2.3

ok. I close it


SOV-3011: Export CSV

https://sovryn.atlassian.net/browse/SOV-3011

closing this PR due to merge issue


Enable tf.log() for SparseTensor

Enabled tf.log() for SparseTensor. Added tests and verified locally. This partially addresses #1828.

Can one of the admins verify this patch?

@tensorflow-jenkins test this please


Add more machine learning algorithms

Algorithms

Linear Model

[x] Ordinary Least Squared Linear Regression
[x]  Gradient Descent Linear Regression
[x]  Stochastic Gradient Descent Linear Regression
[x]  Logistic Regression
[ ]  Lasso Regression
[ ]  Ridge Regression
[ ]  Elastic Regression
[ ]  Bayesian Regression
[ ]  SVD Regression

SVM (Support Vector Machine)

[ ] SVC
[ ] SVR
[ ] LinearSVC
[ ] LinearSVR
[ ] NuSVC
[ ] NuSVR

Cluster

[x] KMeans
[ ] DBSCAN
[ ] Spectral clustering
[ ] Hierarchical clustering

Decomposition

[x] PCA
[ ] Sparse PCA
[ ] Kernel PCA
[ ] Incremental PCA

Naive Bayes

[x] Bernoulli Naive Bayes
[x] Nultinomial Naive Bayes
[x] Gaussian Naive Bayes
[ ] Complement Naive Bayes

Neighbors

[x] Nearest Neighbors Classifier
[x] Nearest Neighbors Regressor
[ ] Nearest centroid classifier

Tree

[x] Decision Tree

Ensemble

[x] Random Forest
[ ] Gradient Boosting
[ ] XGBoost
[x] AdaBoost
[ ] Stacking
[ ] Voating

Some of the Tree base algorithms are implemented but need some review.

I want to implement linear models. Can I start working?

Yes @das-ankur, you can start working on it. If you need any help, please reach out to me.


Add ability for user-defined "nicknames" or "bookmarks" that add a descriptive label to a host

Identify by mac address, not IP address
save in CSV file alongside executable

c795fca247bbcbb44a70a3f54eee339d2ffa3ba9


Configuration issues when running in pipeline

When running in pipeline, Shakapacker is sometimes failing to compile the assets, due to error.
Expected behavior:
Not to fail occasionally
Actual behavior:
Failing with the following message / stack trace, but when the pipeline is being retried, is passing without any issues. There is no config change between retries.
NoMethodError:
  undefined method `[]' for nil:NilClass

        symbolized_config = config[env].deep_symbolize_keys
                                  ^^^^^
# /home/runner/work/decidim/decidim/vendor/bundle/ruby/3.1.0/gems/shakapacker-7.1.0/lib/shakapacker/configuration.rb:130:in `load'
# /home/runner/work/decidim/decidim/vendor/bundle/ruby/3.1.0/gems/shakapacker-7.1.0/lib/shakapacker/configuration.rb:121:in `data'
# /home/runner/work/decidim/decidim/vendor/bundle/ruby/3.1.0/gems/shakapacker-7.1.0/lib/shakapacker/configuration.rb:106:in `fetch'
# /home/runner/work/decidim/decidim/vendor/bundle/ruby/3.1.0/gems/shakapacker-7.1.0/lib/shakapacker/configuration.rb:34:in `ensure_consistent_versioning?'
# /home/runner/work/decidim/decidim/vendor/bundle/ruby/3.1.0/gems/shakapacker-7.1.0/lib/shakapacker/version_checker.rb:30:in `raise_if_gem_and_node_package_versions_differ'
# /home/runner/work/decidim/decidim/vendor/bundle/ruby/3.1.0/gems/shakapacker-7.1.0/lib/shakapacker/railtie.rb:13:in `block in <class:Engine>'
# /home/runner/work/decidim/decidim/vendor/bundle/ruby/3.1.0/gems/railties-<IP_ADDRESS>/lib/rails/initializable.rb:32:in `instance_exec'
# /home/runner/work/decidim/decidim/vendor/bundle/ruby/3.1.0/gems/railties-<IP_ADDRESS>/lib/rails/initializable.rb:32:in `run'
# /home/runner/work/decidim/decidim/vendor/bundle/ruby/3.1.0/gems/railties-<IP_ADDRESS>/lib/rails/initializable.rb:61:in `block in run_initializers'
# /home/runner/work/decidim/decidim/vendor/bundle/ruby/3.1.0/gems/railties-<IP_ADDRESS>/lib/rails/initializable.rb:60:in `run_initializers'
# /home/runner/work/decidim/decidim/vendor/bundle/ruby/3.1.0/gems/railties-<IP_ADDRESS>/lib/rails/application.rb:391:in `initialize!'
# /home/runner/work/decidim/decidim/spec/decidim_dummy_app/config/environment.rb:5:in `<top (required)>'
# /home/runner/work/decidim/decidim/vendor/bundle/ruby/3.1.0/gems/activesupport-<IP_ADDRESS>/lib/active_support/dependencies.rb:332:in `require'
# /home/runner/work/decidim/decidim/vendor/bundle/ruby/3.1.0/gems/activesupport-<IP_ADDRESS>/lib/active_support/dependencies.rb:332:in `block in require'
# /home/runner/work/decidim/decidim/vendor/bundle/ruby/3.1.0/gems/activesupport-<IP_ADDRESS>/lib/active_support/dependencies.rb:299:in `load_dependency'
# /home/runner/work/decidim/decidim/vendor/bundle/ruby/3.1.0/gems/activesupport-<IP_ADDRESS>/lib/active_support/dependencies.rb:332:in `require'
# /home/runner/work/decidim/decidim/decidim-dev/lib/decidim/dev/test/base_spec_helper.rb:21:in `<top (required)>'
# /home/runner/work/decidim/decidim/vendor/bundle/ruby/3.1.0/gems/activesupport-<IP_ADDRESS>/lib/active_support/dependencies.rb:332:in `require'
# /home/runner/work/decidim/decidim/vendor/bundle/ruby/3.1.0/gems/activesupport-<IP_ADDRESS>/lib/active_support/dependencies.rb:332:in `block in require'
# /home/runner/work/decidim/decidim/vendor/bundle/ruby/3.1.0/gems/activesupport-<IP_ADDRESS>/lib/active_support/dependencies.rb:299:in `load_dependency'
# /home/runner/work/decidim/decidim/vendor/bundle/ruby/3.1.0/gems/activesupport-<IP_ADDRESS>/lib/active_support/dependencies.rb:332:in `require'
# ./spec/spec_helper.rb:9:in `<top (required)>'
# ./spec/system/admin/admin_edits_proposal_spec.rb:3:in `require'
# ./spec/system/admin/admin_edits_proposal_spec.rb:3:in `<top (required)>'

Env variables:
   env:
    DATABASE_USERNAME: postgres
    DATABASE_PASSWORD: postgres
    DATABASE_HOST: localhost
    RUBYOPT: -W:no-deprecated
    VALIDATOR_HTML_URI: http://localhost:8888/
    ELECTIONS_BULLETIN_BOARD_SERVER: http://localhost:8000/api
    RUBY_VERSION: 3.1.1
    DECIDIM_MODULE: decidim-proposals
    CODECOV_TOKEN: bc15b944-6b42-420a-b3f9-a5a8fb214326
    DECIDIM_BULLET_ENABLED: true
    DECIDIM_BULLET_N_PLUS_ONE: false
    DECIDIM_BULLET_COUNTER_CACHE: true
    DECIDIM_BULLET_UNUSED_EAGER: false
    DISPLAY: :99
    CI: true
    SIMPLECOV: true
    PARALLEL_TEST_PROCESSORS: 2
    SHAKAPACKER_RUNTIME_COMPILE: false
    NODE_ENV: test

Small, reproducible repo:
It happens occasionally, so I do not have reproducible steps.
Setup environment:

Ruby version: 3.1.1
Rails version: 6.1.7
Shakapacker version: 7.1.0

It happens occasionally, so I do not have reproducible steps.

This is strange, and we have never faced such issues.
Hard to say anything unless we can reproduce the issue.
Please add further details as soon as you get any.

I am trying to see if i can replicate it locally. The pipeline output is :
failing
passing

@G-Rath , indeed, we are overriding shakapacker config, so that we generate a file like the one below:
Also, the  configuration file is being loaded from here:

https://github.com/decidim/decidim/blob/develop/decidim-core/lib/decidim/webpacker/configuration.rb#L14

Indeed, the issue that we are facing may or may not be related to shakapacker itself. due to size of decidim dest suite we use both matrix and parallels gem to run 2 suites at once. Thanks for pointing me to the race condition issue.
On decidim, we are using since like beginning the NPM, and now we already work on moving the shakapacker to use esbuild instead of babel.
I have noticed the package_json gem while checkingh #349, and I really think that we could use that in our code base as well. I personally got hit by the struggle to manually add to Package.json various node packages so that i make other decidim modules work.
---
default:
  source_path: app/packs
  source_entry_path: entrypoints
  nested_entries: true
  css_extract_ignore_order_warnings: false
  public_root_path: public
  public_output_path: decidim-packs
  cache_path: tmp/shakapacker
  webpack_compile_output: true
  extract_css: true
  shakapacker_precompile: true
  additional_paths: &1
  - node_modules
  - app/packs
  - "/home/alecslupu/Sites/decidim/redesign/decidim-api/app/packs"
  - "/home/alecslupu/Sites/decidim/redesign/decidim-core/app/packs"
  - "/home/alecslupu/Sites/decidim/redesign/decidim-comments/app/packs"
  - "/home/alecslupu/Sites/decidim/redesign/decidim-accountability/app/packs"
  - "/home/alecslupu/Sites/decidim/redesign/decidim-admin/app/packs"
  - "/home/alecslupu/Sites/decidim/redesign/decidim-assemblies/app/packs"
  - "/home/alecslupu/Sites/decidim/redesign/decidim-blogs/app/packs"
  - "/home/alecslupu/Sites/decidim/redesign/decidim-budgets/app/packs"
  - "/home/alecslupu/Sites/decidim/redesign/decidim-debates/app/packs"
  - "/home/alecslupu/Sites/decidim/redesign/decidim-forms/app/packs"
  - "/home/alecslupu/Sites/decidim/redesign/decidim-meetings/app/packs"
  - "/home/alecslupu/Sites/decidim/redesign/decidim-pages/app/packs"
  - "/home/alecslupu/Sites/decidim/redesign/decidim-participatory_processes/app/packs"
  - "/home/alecslupu/Sites/decidim/redesign/decidim-proposals/app/packs"
  - "/home/alecslupu/Sites/decidim/redesign/decidim-sortitions/app/packs"
  - "/home/alecslupu/Sites/decidim/redesign/decidim-templates/app/packs"
  - "/home/alecslupu/Sites/decidim/redesign/decidim-surveys/app/packs"
  - "/home/alecslupu/Sites/decidim/redesign/decidim-system/app/packs"
  - "/home/alecslupu/Sites/decidim/redesign/decidim-verifications/app/packs"
  - "/home/alecslupu/Sites/decidim/redesign/decidim-conferences/app/packs"
  - "/home/alecslupu/Sites/decidim/redesign/decidim-design/app/packs"
  - "/home/alecslupu/Sites/decidim/redesign/decidim-dev/app/packs"
  - "/home/alecslupu/Sites/decidim/redesign/decidim-elections/app/packs"
  - "/home/alecslupu/Sites/decidim/redesign/decidim-initiatives/app/packs"
  cache_manifest: false
  webpack_loader: babel
  ensure_consistent_versioning: true
  compiler_strategy: digest
  useContentHash: false
  entrypoints: &2
    decidim_api_docs: "/home/alecslupu/Sites/decidim/redesign/decidim-api/app/packs/entrypoints/decidim_api_docs.js"
    decidim_api_graphiql: "/home/alecslupu/Sites/decidim/redesign/decidim-api/app/packs/entrypoints/decidim_api_graphiql.js"
    decidim_core: "/home/alecslupu/Sites/decidim/redesign/decidim-core/app/packs/entrypoints/decidim_core.js"
    decidim_sw: "/home/alecslupu/Sites/decidim/redesign/decidim-core/app/packs/entrypoints/decidim_sw.js"
    decidim_conference_diploma: "/home/alecslupu/Sites/decidim/redesign/decidim-core/app/packs/entrypoints/decidim_conference_diploma.js"
    decidim_editor: "/home/alecslupu/Sites/decidim/redesign/decidim-core/app/packs/entrypoints/decidim_editor.js"
    decidim_email: "/home/alecslupu/Sites/decidim/redesign/decidim-core/app/packs/entrypoints/decidim_email.js"
    decidim_map: "/home/alecslupu/Sites/decidim/redesign/decidim-core/app/packs/entrypoints/decidim_map.js"
    decidim_geocoding_provider_photon: "/home/alecslupu/Sites/decidim/redesign/decidim-core/app/packs/entrypoints/decidim_geocoding_provider_photon.js"
    decidim_geocoding_provider_here: "/home/alecslupu/Sites/decidim/redesign/decidim-core/app/packs/entrypoints/decidim_geocoding_provider_here.js"
    decidim_map_provider_default: "/home/alecslupu/Sites/decidim/redesign/decidim-core/app/packs/entrypoints/decidim_map_provider_default.js"
    decidim_map_provider_here: "/home/alecslupu/Sites/decidim/redesign/decidim-core/app/packs/entrypoints/decidim_map_provider_here.js"
    decidim_widget: "/home/alecslupu/Sites/decidim/redesign/decidim-core/app/packs/entrypoints/decidim_widget.js"
    decidim_comments: "/home/alecslupu/Sites/decidim/redesign/decidim-comments/app/packs/entrypoints/decidim_comments.js"
    decidim_accountability: "/home/alecslupu/Sites/decidim/redesign/decidim-accountability/app/packs/entrypoints/decidim_accountability.js"
    decidim_accountability_admin: "/home/alecslupu/Sites/decidim/redesign/decidim-accountability/app/packs/entrypoints/decidim_accountability_admin.js"
    decidim_accountability_admin_imports: "/home/alecslupu/Sites/decidim/redesign/decidim-accountability/app/packs/entrypoints/decidim_accountability_admin_imports.js"
    decidim_admin: "/home/alecslupu/Sites/decidim/redesign/decidim-admin/app/packs/entrypoints/decidim_admin.js"
    decidim_assemblies: "/home/alecslupu/Sites/decidim/redesign/decidim-assemblies/app/packs/entrypoints/decidim_assemblies.js"
    decidim_assemblies_admin: "/home/alecslupu/Sites/decidim/redesign/decidim-assemblies/app/packs/entrypoints/decidim_assemblies_admin.js"
    decidim_blogs: "/home/alecslupu/Sites/decidim/redesign/decidim-blogs/app/packs/entrypoints/decidim_blogs.js"
    decidim_budgets: "/home/alecslupu/Sites/decidim/redesign/decidim-budgets/app/packs/entrypoints/decidim_budgets.js"
    decidim_budgets_admin: "/home/alecslupu/Sites/decidim/redesign/decidim-budgets/app/packs/entrypoints/decidim_budgets_admin.js"
    decidim_debates_admin: "/home/alecslupu/Sites/decidim/redesign/decidim-debates/app/packs/entrypoints/decidim_debates_admin.js"
    decidim_forms: "/home/alecslupu/Sites/decidim/redesign/decidim-forms/app/packs/entrypoints/decidim_forms.js"
    decidim_forms_admin: "/home/alecslupu/Sites/decidim/redesign/decidim-forms/app/packs/entrypoints/decidim_forms_admin.js"
    decidim_questionnaire_answers_pdf: "/home/alecslupu/Sites/decidim/redesign/decidim-forms/app/packs/entrypoints/decidim_questionnaire_answers_pdf.js"
    decidim_meetings: "/home/alecslupu/Sites/decidim/redesign/decidim-meetings/app/packs/entrypoints/decidim_meetings.js"
    decidim_meetings_admin: "/home/alecslupu/Sites/decidim/redesign/decidim-meetings/app/packs/entrypoints/decidim_meetings_admin.js"
    decidim_pages: "/home/alecslupu/Sites/decidim/redesign/decidim-pages/app/packs/entrypoints/decidim_pages.js"
    decidim_participatory_processes: "/home/alecslupu/Sites/decidim/redesign/decidim-participatory_processes/app/packs/entrypoints/decidim_participatory_processes.js"
    decidim_participatory_processes_admin: "/home/alecslupu/Sites/decidim/redesign/decidim-participatory_processes/app/packs/entrypoints/decidim_participatory_processes_admin.js"
    decidim_proposals: "/home/alecslupu/Sites/decidim/redesign/decidim-proposals/app/packs/entrypoints/decidim_proposals.js"
    decidim_proposals_admin: "/home/alecslupu/Sites/decidim/redesign/decidim-proposals/app/packs/entrypoints/decidim_proposals_admin.js"
    decidim_sortitions: "/home/alecslupu/Sites/decidim/redesign/decidim-sortitions/app/packs/entrypoints/decidim_sortitions.js"
    decidim_templates: "/home/alecslupu/Sites/decidim/redesign/decidim-templates/app/packs/entrypoints/decidim_templates.js"
    decidim_templates_admin: "/home/alecslupu/Sites/decidim/redesign/decidim-templates/app/packs/entrypoints/decidim_templates_admin.js"
    decidim_system: "/home/alecslupu/Sites/decidim/redesign/decidim-system/app/packs/entrypoints/decidim_system.js"
    decidim_verifications: "/home/alecslupu/Sites/decidim/redesign/decidim-verifications/app/packs/entrypoints/decidim_verifications.js"
    decidim_conferences: "/home/alecslupu/Sites/decidim/redesign/decidim-conferences/app/packs/entrypoints/decidim_conferences.js"
    decidim_conferences_admin: "/home/alecslupu/Sites/decidim/redesign/decidim-conferences/app/packs/entrypoints/decidim_conferences_admin.js"
    decidim_design: "/home/alecslupu/Sites/decidim/redesign/decidim-design/app/packs/entrypoints/decidim_design.js"
    decidim_dev: "/home/alecslupu/Sites/decidim/redesign/decidim-dev/app/packs/entrypoints/decidim_dev.js"
    decidim_dev_test_custom_map: "/home/alecslupu/Sites/decidim/redesign/decidim-dev/app/packs/entrypoints/decidim_dev_test_custom_map.js"
    decidim_elections: "/home/alecslupu/Sites/decidim/redesign/decidim-elections/app/packs/entrypoints/decidim_elections.js"
    decidim_elections_admin: "/home/alecslupu/Sites/decidim/redesign/decidim-elections/app/packs/entrypoints/decidim_elections_admin.js"
    decidim_votings: "/home/alecslupu/Sites/decidim/redesign/decidim-elections/app/packs/entrypoints/decidim_votings.js"
    decidim_votings_admin: "/home/alecslupu/Sites/decidim/redesign/decidim-elections/app/packs/entrypoints/decidim_votings_admin.js"
    decidim_initiatives: "/home/alecslupu/Sites/decidim/redesign/decidim-initiatives/app/packs/entrypoints/decidim_initiatives.js"
    decidim_initiatives_admin: "/home/alecslupu/Sites/decidim/redesign/decidim-initiatives/app/packs/entrypoints/decidim_initiatives_admin.js"
    decidim_initiatives_print: "/home/alecslupu/Sites/decidim/redesign/decidim-initiatives/app/packs/entrypoints/decidim_initiatives_print.js"
    decidim_initiatives_initiatives_votes: "/home/alecslupu/Sites/decidim/redesign/decidim-initiatives/app/packs/entrypoints/decidim_initiatives_initiatives_votes.js"
  stylesheet_imports: &3 {}
  compile: false
development:
  source_path: app/packs
  source_entry_path: entrypoints
  nested_entries: true
  css_extract_ignore_order_warnings: false
  public_root_path: public
  public_output_path: decidim-packs
  cache_path: tmp/shakapacker
  webpack_compile_output: true
  extract_css: true
  shakapacker_precompile: true
  additional_paths: *1
  cache_manifest: false
  webpack_loader: babel
  ensure_consistent_versioning: true
  compiler_strategy: mtime
  useContentHash: false
  compile: false
  dev_server:
    https: false
    host: localhost
    port: 3035
    hmr: false
    inline_css: true
    client:
      overlay: false
    compress: true
    allowed_hosts: all
    pretty: true
    headers:
      Access-Control-Allow-Origin: "*"
    static:
      watch:
        ignored: "**/node_modules/**"
  entrypoints: *2
  stylesheet_imports: *3
test:
  source_path: app/packs
  source_entry_path: entrypoints
  nested_entries: true
  css_extract_ignore_order_warnings: false
  public_root_path: public
  public_output_path: packs-test
  cache_path: tmp/shakapacker
  webpack_compile_output: true
  extract_css: true
  shakapacker_precompile: true
  additional_paths: *1
  cache_manifest: false
  webpack_loader: babel
  ensure_consistent_versioning: true
  compiler_strategy: digest
  useContentHash: false
  compile: false
  entrypoints: *2
  stylesheet_imports: *3
production:
  source_path: app/packs
  source_entry_path: entrypoints
  nested_entries: true
  css_extract_ignore_order_warnings: false
  public_root_path: public
  public_output_path: decidim-packs
  cache_path: tmp/shakapacker
  webpack_compile_output: true
  extract_css: true
  shakapacker_precompile: true
  additional_paths: *1
  cache_manifest: true
  webpack_loader: babel
  ensure_consistent_versioning: true
  compiler_strategy: digest
  useContentHash: true
  compile: false
  entrypoints: *2
  stylesheet_imports: *3

From what I can tell, this is a "question" and not a "bug."

@G-Rath , @ahangarha and @justin808, thanks for your input. Yes, now after clarification, it looks like a question, and based on your input, is not even related to shakapacker. Thanks for input!


Implement a NIOAsyncWriter

Motivation
We previously added the NIOAsyncSequenceProducer to bridge between the NIO channel pipeline and the asynchronous world. However, we still need something to bridge writes from the asynchronous world back to the NIO channel pipeline.
Modification
This PR adds a new NIOAsyncWriter type that allows us to asynchronously yield elements to it. On the other side, we can register a NIOAsyncWriterDelegate which will get informed about any written elements. Furthermore, the synchronous side can toggle the writability of the AsyncWriter which allows it to implement flow control.
A main goal of this type is to be as performant as possible. To achieve this I did the following things:

Make everything generic and inlinable
Use a class with a lock instead of an actor
Provide methods to yield a sequence of things which allows users to reduce the amount of times the lock gets acquired.

Result
We now have the means to bridge writes from the asynchronous world to the synchronous

@Lukasa I changed the API to always yield a Deque now and I added a performance test for this. Let me know what you think!

@Lukasa @glbrntt @gjcairo I just pushed a new commit that changes a few things after our offline discussion:

Allow sending an Error with the Sink/finish(error:) method. Any suspended or subsequent call to NIOAsyncWriter/yield will throw this error. It provides a way to surface an underlying error to the callers of the NIOAsyncWriter. We have been doing this in grpc-swift to surface errors from the channel pipeline
I removed the generic Failure parameter from the NIOAsyncWriter since we agreed that there is little value in providing a generic here over just an Error. Furthermore, since we want to allow to send an Error from the Sink/finish(error:) method it would mean we would have to introduce another generic parameter.
Added a few more tests for the new state and updated the documentation.


[Syntax] Implement fallthrough-statement

This isn't a robust implementation and is breaking the build. I'll
put it back once indentation is better specified.

@swift-ci smoke test and merge

@swift-ci smoke test and merge

@swift-ci smoke test and merge

@swift-ci Please smoke test


Feature/budget v2

Since the PR wasn't getting reviewed, I cut it up into pieces that are easier to digest. Just go commit-by-commit and it'll be (hopefully) clear what's going on.
Still missing some client-side validation, but I'm pretty sure Emily isn't a malicious actor.
Below is the expository text from the previous PR.
I'm moving the age-old MS Access database to the website, for a few
reasons:

If a treasurer has a Mac, they can't use Access easily
This allows officers to check the status of their budgets
The database needed a schema change to deal with reimbursement
through Venmo. Currently it can only handle checks.
 It literally modifies your
queries when you save them, sometimes in ways that change the
functionality.

Downsides:

Access has a lot of powerful features, especially involving
filtering and sorting. I'd have to implement these myself.
This requires my time and effort. Technically a downside.

Here are some screenshots of the interface. It's a little prettier now though. Not quite "nice", but it'll do.

Also, I should probably explain the bookkeeping system, for the non-treasurers.
Accounts - pretty self-explanatory, things like Wells Fargo, Caltech Bursar, or Cashbox
Fiscal Year - a year, for the purposes of accounting. Ours start in September, up to treasurer's discretion.
Budget - an amount of money set aside for a particular office or purpose for a particular fiscal year, e.g., Ath Team 2017, or Rotation 2016.
Expense - when someone spends money on behalf of the house, no matter whose money is actually being spent. Examples: the Treasurer buying new ceiling tiles, or Ath Team buying clothes. For our purposes, income is just a negative expense.
Payment - the actual movement of money from a Ruddock account to another individual.
Expenses and payments have a many-to-one relationship. For example, a reimbursement check could cover multiple expenses. It could be many-to-many, but that makes accounting pretty hard, so... nah.
Lastly, a note on dates. For an expense, date_incurred is when the purchase was made. For a payment, there are two dates: date_written and date_posted. The former is when the payment was made, and the latter when it takes effect. The difference is clearest with checks, where the former is when the treasurer writes the check, and the latter is when the recipient deposits it. The distinction is necessary when checking to see if account balances are accurate.


Adding the JART v1b memristor model for aihwkit

Description
Support a new device type based on JART V1b memristor model and test scripts for that.
Details can be found at https://ieeexplore.ieee.org/document/10052010
Details
The code was written for the old backend and some adaptations for the new version are needed.
Support for CUDA is strange, where sometimes the results are not transferred back to PyTorch.
Cycle-to-cycle variability is currently not supported for CUDA, as we need fields to save more device-specific parameters.

@ZhenmingYu, actually I cannot edit your branch anyway, so I will first review it, so that you can make changes

@maljoras Thanks a lot for the kind words! I couldn't have done this without your support last year.
So I tried to invite you as a collaborator under my fork, this should enable you to edit the branch.
My plan is to keep the JART_v1b_device branch as is and improve and merge the master branch.
I'm also wondering whether there can be more than 6 device-specific parameters in version 0.7 now with the new backend, which could be helpful with c2c noises.
Thanks a lot for the help!
Zhenming

We could add some more device-to-device parameters into the kernels. like another par_4 (to have 4 values per synapse). Would this be enough? So you need to modify  them or are they constant?

We have implemented a random walk based c2c noise that acts on 4 parameters, starting from their d2d values.
The parameters themselves are already included in the 6 device-to-device parameters, and they each need 2 boundaries to prevent random walks from going too far.
So there are 8 constants in total, that are equal to Par_d2d*(1+-10%), calculated after d2d noises being applied.
Adding 2 par4s would then be enough.

OK, I could add 2 par_4 that are both writeable. the current par_2 and par_4 are considered constant. Then you have 8 more writable parameters per synapse, in addition to the 6 constant (par_2, par_4) and the weight and "hidden" weight.

That would be great. Thanks a lot!
Although I've discovered that the CUDA version runs pretty slow compared to the CPU version some how.

The GPU kernel currently seems quite complex one could potentially improve the performance. However, for small batch sizes and small weights the CPU version always will be faster, since there is quite an overhead of memory transfer etc in the CUDA kernel. If the compute amount is too small, that part will dominate. If you increase the batch size and weight size GPU should become much faster than CPU.

Thanks for the suggestions, it is much faster now.

moved to #583  since I cannot edit this PR


MTC avatar room translation

Added translations for all MTC avatar room strings.
NOTE: There is a slight issue with one of the Neos bot creator strings, as posted in Czech coordination issue (https://github.com/Neos-Metaverse/NeosLocale/issues/1).
(this comment will be updated if more changes will be made before this pull request's merge/closing)

Thank you for the new translations! I'll let the team know about the text issue.


Make both super and super member work

the 2 failing tests are now more or less invalid, but should be investigated further.

@rwjblue @btecu this is ready for review + can likely be tested in that PR.

It works great with the PR. I still have those two tests failing which cause a few smoke tests fail:
1) calls appropriate hooks with correct arguments (basic blueprint installation)
2) calls appropriate hooks with correct arguments (basic blueprint uninstallation)

LGTM

released as 2.0.0


Build Issues on Amazon Linux AMIs

I'm trying to build on Amazon Linux AMIs because if I install it via RPM it has issues running.
 /usr/lib64/libnvidia-container.so.1: undefined symbol: cap_get_bound

I tried to compile to overcome this issue. I ran into another problem.
In file included from /usr/include/sys/prctl.h:22:0,
                 from /home/ec2-user/libnvidia-container/src/nvc_ldcache.c:10:
/usr/include/linux/prctl.h:134:2: error: unknown type name ‘__u64’
  __u64 start_code;  /* code section bounds */
  ^
/usr/include/linux/prctl.h:135:2: error: unknown type

I've installed the kernel headers which I thought would provide __u64. Any help or support for this compiling on Amazon Linux?

What version of libcap is installed on your Amazon Linux AMI?
Also can you give me the output of:

echo '#include <linux/types.h>' | gcc -E - | grep __u64
echo '#include <sys/prctl.h>' | gcc -E - | grep __u64

The Linux AMI version is 4.9.62-21.56.amzn1.x86_64. It was built in September.
Libcap
Version of libcap is at 2.16:
[ec2-user]# ldconfig -v | grep libcap
	libcap-ng.so.0 -> libcap-ng.so.0.0.0
	libcap.so.2 -> libcap.so.2.16

[ec2-user]# yum search --show-duplicates libcap
devel-2.16-5.5.8.amzn1.x86_64 : Development files for libcap
libcap-2.16-5.5.8.amzn1.x86_64 : Library for getting and setting POSIX.1e capabilities
libcap-ng-0.7.5-4.15.amzn1.i686 : An alternate posix capabilities library

Header Information

echo '#include <linux/types.h>' | gcc -E - | grep __u64

[ec2-user]# echo '#include <linux/types.h>' | gcc -E - | grep __u64
__extension__ typedef unsigned long long __u64;
typedef __u64 __le64;
typedef __u64 __be64;

echo '#include <sys/prctl.h>' | gcc -E - | grep __u64

[ec2-user]# echo '#include <sys/prctl.h>' | gcc -E - | grep __u64
__extension__ typedef unsigned long long __u64;
typedef __u64 __le64;
typedef __u64 __be64;
 __u64 start_code;
 __u64 end_code;
 __u64 start_data;
 __u64 end_data;
 __u64 start_brk;
 __u64 brk;
 __u64 start_stack;
 __u64 arg_start;
 __u64 arg_end;
 __u64 env_start;
 __u64 env_end;
 __u64 *auxv;

@mzsanford This should fix the issue.
We will probably release packages as well for the next release of nvidia-docker.


The nodejs version does not work

Please check the signva_sign.js does not work, it just create an empty header
HttpHeaders {}

What is your exact code that doesn't work for you, e.g. produces the result you're describing?

+1 the example code doesn't work as written. Consider running it, fixing any issues, and updating the examples. In example 2, the example imports sigV4ASignBasic but uses sigV4ASign.
I also was not able to get the example working even after fixing a few things with the aws-crt version in the package.json. I updated the version to 1.21 which got it working. Considering updating the package.json to include a version range so it gets future updates, like: "aws-crt": "^1.21.1"

@crowecawcaw thanks, should be fixed now.


onKeyUp event doesn't work after upgrade to Storybook 5.0.1

Describe the bug
I have a React component that use the onKeyPress event and before the Storybook version 5.0.1 was working fine. However, after migrate to the last version, it stop working. Doing nothing.
To Reproduce
I have this React hook:
import { useEffect } from 'react'
import includes from 'lodash/includes'

export default function useOnKeyUp({ action, keyCodes = [], when = true }) {
  useEffect(() => {
    function onKeyUp(e) {
      if (includes(keyCodes, e.keyCode) && when) {
        action()
      }
    }

    document.body.addEventListener('keyup', onKeyUp)

    return () => document.body.removeEventListener('keyup', onKeyUp)
  }, [when, action, keyCodes])
}

And I'm using a component that use this hook to close a modal:
// Close on press keyCodes (ex: ESCAPE or ENTER)
  useOnBodyKeyUp({
    action: closeModal,
    keyCodes: keyCodesToClose,
    when: isOpen,
  })

Expected behavior
To fire the event.

@aralroca are you using any addons and if so, which ones?

Yes! I'm using this ones:
import 'storybook-addon-jsx/register'
import '@storybook/addon-knobs/register'

Both with 5.0.1 version

@aralroca What version of Storybook are you upgrading from?

@shilman I was using 4.1 before 5.0.1

@tmeasday @Jessica-Koch Could this be due to the updated keyboard handling in SB5?

This is all the keybinding we do inside the preview, AFAIK:
https://github.com/storybooks/storybook/blob/cf96e889c18095c225325d034501e40ced0472d3/lib/core/src/client/preview/start.js#L197-L205
I'm not sure how that could stop the keyup event firing?

Tom is right
Sent from my iPhone

On Mar 12, 2019, at 3:34 AM, Tom Coleman<EMAIL_ADDRESS>wrote:
This is all the keybinding we do inside the preview, AFAIK:
https://github.com/storybooks/storybook/blob/cf96e889c18095c225325d034501e40ced0472d3/lib/core/src/client/preview/start.js#L197-L205
I'm not sure how that could stop the keyup event firing?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

This is all the keybinding we do inside the preview, AFAIK:
storybook/lib/core/src/client/preview/start.js
Lines 197 to 205 in cf96e88
window.onkeydown = event => {
if (!focusInInput(event)) {
// We have to pick off the keys of the event that we need on the other side
const { altKey, ctrlKey, metaKey, shiftKey, key, code, keyCode } = event;
channel.emit(Events.PREVIEW_KEYDOWN, {
event: { altKey, ctrlKey, metaKey, shiftKey, key, code, keyCode },
});
}
};
I'm not sure how that could stop the keyup event firing?

I'm not familiar with the storybook codebase but from some investigation and looking at this, it's likely that you have a global listener on the manager view that listens to the key events in which you've emitted here.
I think whatever is listening to this event in the manager view is changing the focus from the preview to the parent. That would explain the keyup event never firing inside of the preview if the keydown "key" matches one of your targets.
running the following in the browser console will disable the key listeners in the preview but it will allow the browser to fire keyup events as usual.

Hmm, thanks for investigating @mouhannad-sh and I think you are likely right. What is the specific key you are pressing that causes the issue?
I'm not quite sure what we can do to avoid this problem. We currently check to see if the keydown event happens inside an input or textarea, but of course if you have a custom element that is handling key events this will not help. What is likely happening is you are triggering a shortcut such as the / key which focuses the search box.
We could be very conservative and only pass events through if they happen outside the rendered story but this would have the confusing effect of making shortcuts not work in many cases 🤔

Thanks for replying so quickly @tmeasday
In my story I have Modal component that should close on "Escape" keyup.
I think the storybook script has more priority to the preview's context.
That's been said your event listeners are likely to execute their logic before anythings else inside of the preview view.
I would suggest one of 3 solutions that comes to my head:

To have a more complex key bindings to solve this issue.
Provide a config to modify/disable specific hotkeys per story.
Do not change the focus if it's inside of the preview

To have a more complex key bindings to solve this issue.

Well we have customizable keybindings so I'm not sure we can solve it this way. I guess the escape keybinding isn't customizable though so I'm not sure you can even work around it by changing that one :/

Provide a config to modify/disable specific hotkeys per story.

This approach is definitely doable, although a bit heavy for the user.

Do not change the focus if it's inside of the preview

This seems interesting although maybe hard to guarantee. I wonder why pressing the esc key is changing the focus in the first place?
I dug into the code. The reason is this:
https://github.com/storybooks/storybook/blob/next/lib/api/src/modules/shortcuts.ts#L130
I wonder why it does that? It was originally added in this commit by @ndelangen - do you remember what it is about Norbert?
I suspect it is something to do with the treeview. If so, I think maybe it should be removed from the general keybinding and added to the keybinding for the treeview only.
This wouldn't entirely solve the problem in all cases (e.g. the / key) but given esc is a really common key for people to use as a shortcut in their own components it would probably go a long way towards it.

I'm fine with removing that line actually. It's purpose is to remove focus on something in the treeview.
Would you open a PR removing that line and verify that it fixes the issue @aralroca?

I am using storybook for a wcag accessible component, and the keyboard shortcuts totally kill my component's ability to function properly with it's key bindings.
Is it possible to disable all of the storybook key bindings? That is what I would do if I could.

Here is an example https://benbowes.github.io/react-responsive-select-next/?path=/story/info--home

@benbowes I think there's an option that's not working and should be fixed: https://github.com/storybooks/storybook/issues/6569#issuecomment-485239507

Great @shilman, thanks a mill

Yowza!! I just released https://github.com/storybooks/storybook/releases/tag/v5.1.0-alpha.35 containing PR #6578 that references this issue. Upgrade today to try it out!
Because it's a pre-release you can find it on the @next NPM tag.
Closing this issue. Please re-open if you think there's still more to do.

Works a treat on 5.1.0-alpha.35 🎉


can it be used in g++4.8?

i meet this error in g++4.8:
/usr/local/lib/python2.7/dist-packages/tensorflow/include/tensorflow/core/util/cuda_kernel_helper.h:24:31: fatal error: cuda/include/cuda.h: No such file or directory
look forward to hearing from you
@Zardinality @JiahuiYu

I dont think its related to g++ version, maybe u will find these issue helpful:
issue1
issue2
issue3

thank you very much!


Nuget Package Creation - v1.9.14

Gmail API dependency update ('<IP_ADDRESS>89' -> '<IP_ADDRESS>96').
Nuget package creation - v1.9.14.

Codecov Report
All modified lines are covered by tests :white_check_mark:

Comparison is base (c9371ab) 99.48% compared to head (c9fc99b) 99.48%.
Report is 62 commits behind head on main.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@           Coverage Diff           @@
##             main      #63   +/-   ##
=======================================
  Coverage   99.48%   99.48%
=======================================
  Files           1        1
  Lines         781      781
  Branches      183      183
=======================================
  Hits          777      777
  Misses          2        2
  Partials        2        2

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


allow oauth2 to authenticate as openID connect with only code response type and no openid scope or id_token

There is currently no widely available Apache HTTP server module for authenticating against OAuth2.0 using authorization code grant type, but OAuth2.0 is widely used. This would be very valuable asset for securing static content that is best served directly from Apache HTTP server. IMO mod-auth-openidc is the best suited module to accomplish this.
Expected behaviour
If scope doesn't have openid and response type is set to only "code" and the provider response doesn't contain id_token then assume that the bearer is using OAuth2 and authenticate as in oauth20 even though AuthType is openid-connect.
Actual behaviour
OpenID connect doesn't work with pure OAuth2.0, but OAuth2.0 resource server only authenticates bearers who have already obtained a token and there doesn't seem to be a way to mix the two modes and achieve the expected behavior.
If response type is only "code" then OpenID connect works with OAuth2 provider:

it creates the correct authorization link, and gets the authorization code with successful user authentication
it exchanges the authorization code for a bearer token
But then it fails to authenticate the bearer's token because OpenID connect expects id_token but Oauth2 only has access_token.

Minimized example that reproduces the behaviour
OIDCRedirectURI https://myapp.com/docs/
OIDCCryptoPassphrase passphrase
OIDCProviderIssuer https://myapp.com
OIDCProviderAuthorizationEndpoint https://myapp.com/o/authorize/
OIDCProviderTokenEndpoint https://myapp.com/o/token/
OIDCClientID client-id
OIDCClientSecret client-secret
OIDCScope "read write groups"
OIDCProviderTokenEndpointAuth client_secret_post

Alias /docs/ /home/me/myapp/docs/_build/html/
<Directory /home/me/myapp/docs/_build/html>
AuthType openid-connect
Require valid-user
LogLevel debug
</Directory>

There's a reason for OpenID Connect to exist on top of OAuth 2.0: that's because OAuth 2.0 in itself cannot be used to do Web SSO or user authentication in the way that you suggest.  By implementing a flow like you suggest you'd be open to impersonation attacks. Please see: https://oauth.net/articles/authentication/