Changing names for ctx.queryParamOrDefault(a, defaultValue) and ctx.pathParamOrDefault(a, defaultValue)

Changing names for ctx.queryParamOrDefault(a, defaultValue) -> ctx.queryParam(a, default) and ctx.pathParamOrDefault(a, defaultValue) -> ctx.pathParam(a, default) #239

You could do this with default values and @JvmOverloads
@JvmOverloads
ctx.queryParam(key: String, default: String = null) = queryParams(queryParam)?.get(0) :? default

Null can not be a value for non-nullable type of variable default.
If you make the default a nullable type, than there is no way this method can decide whether it returns nullable or non-nullable String type and it will always return String?.
I'd expect it to give me back a non-nullable String by giving a default.

2 separate methods allow us to exploit type system better :)

Hm. Nullability shouldn't be lost info here, since the method is intended for Java developers. In Kotlin you should do:
val qp = queryParam("qp") ?: "default"

The suffix orDefault is something that's used in Java's APIs, for example map.getOrDefault().
I'm getting worried this change might encourage Kotlin users to use the method instead of elvis, and confuse Java users.

Ok, then, I've changed it to use overload. I'm not that familiar with Kotlin code style, but if handling null with elvis is more 'idiomatic' in Kotlin then I agree :)

I'm now thinking, can we support also form/queryParam(x): Optional? I could add it here.
It is lately very common to use optionals to avoid NPEs and it is cumbersome if I have to wrap it every time myself.

I'm now thinking, can we support also form/queryParam(x): Optional? I could add it here.

Not as part of this commit, but you can create a separate issue for it. I'll have to warn you that I'm against it though, so it's unlikely that it'll become part of the API.


datePickerModeAndroid='spinner' doesn't work in Android 7.0

datePickerModeAndroid='spinner' works in Android 8.0, but doesn't work in Android 7.0.

Hey @spacewideweb .
Yes, Android 8.0 doesn't support the spinner picker. That's why the RN Android DatePicker doesn't support it.
Since we react-native-modal-datetime-picker uses the native Android DatePicker we don't support it.


nixos/plasma5: fix activation

Description of changes
I tried impermanence and bind-mounted my ~/.config/Trolltech.conf file as suggested to preserve it between reboots.
The plasma activation script does sed -i over it which fails because sed -i outputs to a temporary file and then renames that file into the original one (similar problem discussed here). Renaming may fail when destination is a bind-mounted file and indeed does on NixOs 22.05 I'm using.
My fix is to manually create temporary file, write sed output in there and cp it into the Trolltech.conf thus making it work when config is bind-mounted.
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
22.11 Release Notes (or backporting 22.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

Closing because the premise is wrong. Impermanence's approach with bind-mounting just doesn't play well with KDE. The ~/.config/Trolltech.conf is not the only file which is going to be overwritten in-place. At least .config/konsolerc gets overwritten in-place by the konsole terminal emulator which files when it's bind-mounted. This seems to happen within KDE internals so it's less easy to patch.
Overall bind-mounting seems to be not so good idea for config files since some software does expect to be able to modify them by creating a temporary file and renaming it into the original one, which bind-mounting just doesn't allow.
The workaround is to use symlinks - can confirm works reasonably well for me.


Referenced page in Next Steps does not contain the promised information

Under Next Steps: the page says
"To set dependencies on resources that are created in a loop, see Resource dependencies."
The page referenced contains no information on how to reference or set dependencies on resources created by a loop.

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 29aa29b9-d815-0d49-3ae4-dce770899fa4
Version Independent ID: cbde0a1e-6200-5cf2-55c1-d2fdca115d9d
Content: Iterative loops in Bicep - Azure Resource Manager
Content Source: articles/azure-resource-manager/bicep/loops.md
Service: azure-resource-manager
Sub-service: bicep
GitHub Login: @mumian
Microsoft Alias: jgao

@cpdohert
Thanks for your feedback! We will investigate and update as appropriate.

@cpdohert - thank you for your comments.  I have created a PR to fix the link inside Next steps.
#please-close


Base bgp session parameters

Hi,
Please kindly review  base_bgp_session_parameters  for RT1.1 automation.
Thanks,
Prabha

Will open new pull request.

Please revert the deletion of the *.testbed and *.binding files.

Hi Likai,
Please could you let me know how to revert testbed/binding files ?
I deleted in UI but now its now showing option to delete it.
Thanks,
Prabha
Juniper Business Use Only
From: Likai Liu @.>
Sent: Friday, May 27, 2022 2:39 PM
To: openconfig/featureprofiles @.>
Cc: Prabha Chethan @.>; State change @.>
Subject: Re: [openconfig/featureprofiles] Base bgp session parameters (PR #201)
[External Email. Be cautious of content]
Please revert the deletion of the *.testbed and *.binding files.

Reply to this email directly, view it on GitHubhttps://urldefense.com/v3/__https:/github.com/openconfig/featureprofiles/pull/201*issuecomment-1140058452__;Iw!!NEt6yMaO-gk!FOzo4Eefn2afMTudqHTe0KeO1dnraa6wqtjd-rTbHrlfWNIVixPU3Ko8PYSI5-dkYlO3qTgPeQXSNuC5ook8p3h1$, or unsubscribehttps://urldefense.com/v3/__https:/github.com/notifications/unsubscribe-auth/AHCEB5W2ELS6X2XQ5PKCUL3VME6HRANCNFSM5XFN7W6A__;!!NEt6yMaO-gk!FOzo4Eefn2afMTudqHTe0KeO1dnraa6wqtjd-rTbHrlfWNIVixPU3Ko8PYSI5-dkYlO3qTgPeQXSNuC5or4NokXz$.
You are receiving this because you modified the open/close state.Message ID<EMAIL_ADDRESS>

I've only used the git command line and not the github UI. If you want to use UI, perhaps the GitHub Desktop App could help.
https://debug.to/1090/how-to-restore-deleted-file-in-github-website
This repo is also configured to do "squash and merge" for PRs, so I think just adding the files back should work. We can try this, and I'll take a look at the "files changed" in this PR and see what happens.
If a repo does not do "squash and merge," then I typically use git rebase -i main in the command line to produce a clean commit history, but you'd need to be careful with what you're doing, or you could accidentally lose a commit. The basic idea is to restore the file back from a past commit as a new commit, then reorder the commit history so the restoration commit either squash or fixup the commit that deleted it. The end result of the rebase should neutralize the unwanted deletion.

Hi Likai,
I have updated permissions on topology files. Please could you check.
Thanks,
Prabha
Juniper Business Use Only
From: Likai Liu @.>
Sent: Tuesday, May 31, 2022 8:24 AM
To: openconfig/featureprofiles @.>
Cc: Prabha Chethan @.>; State change @.>
Subject: Re: [openconfig/featureprofiles] Base bgp session parameters (PR #201)
[External Email. Be cautious of content]
It looks like the file permissions changed from 100644 → 100755 (from non-executable to executable) after you added the deleted files back. Please revert the file permissions as well. These files are not supposed to be executable.

Reply to this email directly, view it on GitHubhttps://urldefense.com/v3/__https:/github.com/openconfig/featureprofiles/pull/201*issuecomment-1142280988__;Iw!!NEt6yMaO-gk!FgK77IBCdlb-DgUlEp0d916fe3-6n7BWg6crhddnXmJigSvnOEvZpboXQ6HnZ1CZd874eFHFU97zXhS9vnnTm6c0$, or unsubscribehttps://urldefense.com/v3/__https:/github.com/notifications/unsubscribe-auth/AHCEB5WXFR6AKE6S7QZGP6TVMYVHZANCNFSM5XFN7W6A__;!!NEt6yMaO-gk!FgK77IBCdlb-DgUlEp0d916fe3-6n7BWg6crhddnXmJigSvnOEvZpboXQ6HnZ1CZd874eFHFU97zXhS9vlVJQLih$.
You are receiving this because you modified the open/close state.Message ID<EMAIL_ADDRESS>

Hi Likai,
Also on pull request, I could see couple of errors in static analysis.
Please could you share pointers to fix them.
Thanks,
Prabha
Juniper Business Use Only
From: Likai Liu @.>
Sent: Wednesday, June 1, 2022 9:59 AM
To: openconfig/featureprofiles @.>
Cc: Prabha Chethan @.>; State change @.>
Subject: Re: [openconfig/featureprofiles] Base bgp session parameters (PR #201)
[External Email. Be cautious of content]
Hi Prabha, after you changed the permissions in your local repo, please make sure to create a new commit with the permission change and push it to the PR.

Reply to this email directly, view it on GitHubhttps://urldefense.com/v3/__https:/github.com/openconfig/featureprofiles/pull/201*issuecomment-1143877987__;Iw!!NEt6yMaO-gk!BD-CTklaEDnRWmEW5JhbnbxtQoosgZ4ytGlg_t1ri_6qZOWl1ezS_7Ne-V8vysmb9Ul-PN416l9InlXJe2n5dXeZ$, or unsubscribehttps://urldefense.com/v3/__https:/github.com/notifications/unsubscribe-auth/AHCEB5R74XEITPGPRU6DTM3VM6JEZANCNFSM5XFN7W6A__;!!NEt6yMaO-gk!BD-CTklaEDnRWmEW5JhbnbxtQoosgZ4ytGlg_t1ri_6qZOWl1ezS_7Ne-V8vysmb9Ul-PN416l9InlXJe-r5Hb9L$.
You are receiving this because you modified the open/close state.Message ID<EMAIL_ADDRESS>

I still haven't had a chance to review the code in detail, but I have another round of administrative comments:

I still see the *.testbed and *.binding as executable. Please make sure you push the commit that sets them back to 0644?
I don't think atedut_3 is needed for RT-1.1. Remove?
For the test plan markdown, could you just convert the RT-1.1 from the shared Google doc using the exact wording instead of rewriting it? Here is an example from TE-1.1: https://github.com/openconfig/featureprofiles/blob/main/feature/interface/staticarp/ate_tests/static_arp_test/README.md
Rename the test plan markdown to README.md?
In the *_test.go file, it would help expedite the review if you could add the wording from the test plan as code comments.

Thanks for your patience.

Hi Likai,

I have updated permissions of topology files today and committed them
I have removed atedut_3.testbed file.
I have updated README.md file as you have suggested.

I will update script with comments and commit it soon.
Thanks,
Prabha

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
111 unchanged lines in 2 files lost coverage.
Overall coverage decreased (-4.7%) to 61.89%

Files with Coverage Reduction
New Missed Lines
%

topologies/binding/new.go
5
0%

topologies/binding/binding.go
106
40.66%

Totals

Change from base Build<PHONE_NUMBER>:
-4.7%

Covered Lines:
596

Relevant Lines:
963

💛  - Coveralls

Hi Likai,
I have updated README.md and base_bgp_session_parameters_test.go  files with all the review comments.
And pushed changes to github.
Looks like there is new check added now , and its failing due to "Executable Files".
I have not added any new testbed/binding files during this commit but its failing due to earlier commit of testbed/binding files.
Please could you let me know how to resolve this issue.
Thanks,
Prabha

Thanks Subhajit. I have verified this and working fine.
-Prabha.
Juniper Business Use Only
From: Subhajit Pal @.>
Sent: Thursday, June 23, 2022 11:23 PM
To: openconfig/featureprofiles @.>
Cc: Prabha Chethan @.>; State change @.>
Subject: Re: [openconfig/featureprofiles] Base bgp session parameters (PR #201)
[External Email. Be cautious of content]
@SubhajitPalKeysight commented on this pull request.

In feature/experimental/bgp/ate_tests/base_bgp_session_parameters/base_bgp_session_parameters_test.gohttps://urldefense.com/v3/__https:/github.com/openconfig/featureprofiles/pull/201*discussion_r905752503__;Iw!!NEt6yMaO-gk!HwS1w-FrDLMEa9IJLApuBQ1uM8DDs31_W9--ZUW2MkVvublWuwTXB8FmdFDk2MmAHehcQRPjPcxK47Mn2ncDmQtn$:

port1 := ate.Port(t, "port1")

  topo := ate.Topology().New()

  iDut1 := topo.AddInterface(ateAttrs.Name).WithPort(port1)

iDut1.IPv4().WithAddress(ateAttrs.IPv4CIDR()).WithDefaultGateway(dutAttrs.IPv4)

  bgpDut1 := iDut1.BGP()

bgpDut1.AddPeer().WithPeerAddress(dutAttrs.IPv4).WithLocalASN(ateAS).WithTypeExternal()

  t.Log("Pushing config to ATE and starting protocols...")

  topo.Push(t)

  topo.StartProtocols(t)

  t.Log("Verify BGP session state : ESTABLISHED")

  nbrPath.SessionState().Await(t, time.Second*100, telemetry.Bgp_Neighbor_SessionState_ESTABLISHED)

  t.Log("Send Cease Notification from ATE to DUT")

  // TODO: waiting for ATE to support notification.

ATE support of sending BGP notification has been provided. Please refer : openconfig/ondatra#17https://urldefense.com/v3/__https:/github.com/openconfig/ondatra/pull/17__;!!NEt6yMaO-gk!HwS1w-FrDLMEa9IJLApuBQ1uM8DDs31_W9--ZUW2MkVvublWuwTXB8FmdFDk2MmAHehcQRPjPcxK47Mn2rXb7RkW$

Reply to this email directly, view it on GitHubhttps://urldefense.com/v3/__https:/github.com/openconfig/featureprofiles/pull/201*pullrequestreview-1018031576__;Iw!!NEt6yMaO-gk!HwS1w-FrDLMEa9IJLApuBQ1uM8DDs31_W9--ZUW2MkVvublWuwTXB8FmdFDk2MmAHehcQRPjPcxK47Mn2rq56hH2$, or unsubscribehttps://urldefense.com/v3/__https:/github.com/notifications/unsubscribe-auth/AHCEB5TBLIOZWA7OPMKYBRTVQVH6BANCNFSM5XFN7W6A__;!!NEt6yMaO-gk!HwS1w-FrDLMEa9IJLApuBQ1uM8DDs31_W9--ZUW2MkVvublWuwTXB8FmdFDk2MmAHehcQRPjPcxK47Mn2izBASw1$.
You are receiving this because you modified the open/close state.Message ID<EMAIL_ADDRESS>

/gcbrun

/gcbrun

Hi Likai,
Please could you let me know if any more changes needed for this pull request.
Thanks,
Prabha

Hi Likai,
Please could you let me know if any other changes needed for this PR.
Thanks,
Prabha

@liulk FYI,  @cprabha is out until Aug 23, will resume review then

@liulk , I have updated base bgp session parameters script and submitted changes. Please check.
And did not update anything on README file as you have already updated it.
Thanks,
Prabha

Thanks for the contribution. I think we're very close now, just two more comments.

Thanks Likai. I have updated both review comments provided , please could you check them.

/gcbrun

/gcbrun

I think the disco-idea-817 failure is because the go.mod/go.sum is outdated. I'm going to go ahead and merge.

Thanks for the contribution!

Thank you.
-Prabha
Juniper Business Use Only
From: Likai Liu @.>
Sent: Wednesday, August 31, 2022 4:17 PM
To: openconfig/featureprofiles @.>
Cc: Prabha Chethan @.>; Mention @.>
Subject: Re: [openconfig/featureprofiles] Base bgp session parameters (PR #201)
[External Email. Be cautious of content]
I think the disco-idea-817 failure is because the go.mod/go.sum is outdated. I'm going to go ahead and merge.

Reply to this email directly, view it on GitHubhttps://urldefense.com/v3/__https:/github.com/openconfig/featureprofiles/pull/201*issuecomment-1233541472__;Iw!!NEt6yMaO-gk!HdghlTfxWXlpAqazgH1JadGeJdQaGiyAJNEqEtdYcccnxwWfYlnBFkl7s4t23aYz1KgmyqGaffaf-8UELPh5RcON$, or unsubscribehttps://urldefense.com/v3/__https:/github.com/notifications/unsubscribe-auth/AHCEB5Q2UJV6HOWGBOD77FLV37RYDANCNFSM5XFN7W6A__;!!NEt6yMaO-gk!HdghlTfxWXlpAqazgH1JadGeJdQaGiyAJNEqEtdYcccnxwWfYlnBFkl7s4t23aYz1KgmyqGaffaf-8UELEScpJnk$.
You are receiving this because you were mentioned.Message ID<EMAIL_ADDRESS>


k8s cluster upgrade fails with template error

Is this a request for help?:
yes
Is this an ISSUE or FEATURE REQUEST? (choose one):
ISSUE
What version of acs-engine?:
0.24.0

Orchestrator and version (e.g. Kubernetes, DC/OS, Swarm)
Kubernetes 1.10.7
What happened:
When trying to upgrade Cluster to 1.10.9 the following error is thrown:

INFO[0000] validating...
INFO[0004] Name suffix: 12658618
INFO[0004] Gathering agent pool names...
INFO[0005] VM k8s-dynamic-12658618-vmss_0 in VMSS k8s-dynamic-12658618-vmss has a current tag of Kubernetes:1.10.7 and a desired tag of Kubernetes:1.10.9. Upgrading this node.
INFO[0005] VM k8s-dynamic-12658618-vmss_1 in VMSS k8s-dynamic-12658618-vmss has a current tag of Kubernetes:1.10.7 and a desired tag of Kubernetes:1.10.9. Upgrading this node.
INFO[0005] VM k8s-dynamic-12658618-vmss_2 in VMSS k8s-dynamic-12658618-vmss has a current tag of Kubernetes:1.10.7 and a desired tag of Kubernetes:1.10.9. Upgrading this node.
INFO[0005] VM k8s-dynamic-12658618-vmss_3 in VMSS k8s-dynamic-12658618-vmss has a current tag of Kubernetes:1.10.7 and a desired tag of Kubernetes:1.10.9. Upgrading this node.
INFO[0005] VM k8s-graph-12658618-vmss_0 in VMSS k8s-graph-12658618-vmss has a current tag of Kubernetes:1.10.7 and a desired tag of Kubernetes:1.10.9. Upgrading this node.
INFO[0005] VM k8s-static-12658618-vmss_0 in VMSS k8s-static-12658618-vmss has a current tag of Kubernetes:1.10.7 and a desired tag of Kubernetes:1.10.9. Upgrading this node.
INFO[0005] VM k8s-static-12658618-vmss_1 in VMSS k8s-static-12658618-vmss has a current tag of Kubernetes:1.10.7 and a desired tag of Kubernetes:1.10.9. Upgrading this node.
INFO[0005] VM k8s-static-12658618-vmss_2 in VMSS k8s-static-12658618-vmss has a current tag of Kubernetes:1.10.7 and a desired tag of Kubernetes:1.10.9. Upgrading this node.
INFO[0005] VM k8s-static-12658618-vmss_3 in VMSS k8s-static-12658618-vmss has a current tag of Kubernetes:1.10.7 and a desired tag of Kubernetes:1.10.9. Upgrading this node.
INFO[0005] VM k8s-static-12658618-vmss_4 in VMSS k8s-static-12658618-vmss has a current tag of Kubernetes:1.10.7 and a desired tag of Kubernetes:1.10.9. Upgrading this node.
INFO[0005] VM k8s-static-12658618-vmss_5 in VMSS k8s-static-12658618-vmss has a current tag of Kubernetes:1.10.7 and a desired tag of Kubernetes:1.10.9. Upgrading this node.
INFO[0005] VM k8s-static-12658618-vmss_6 in VMSS k8s-static-12658618-vmss has a current tag of Kubernetes:1.10.7 and a desired tag of Kubernetes:1.10.9. Upgrading this node.
INFO[0005] VM k8s-static-12658618-vmss_7 in VMSS k8s-static-12658618-vmss has a current tag of Kubernetes:1.10.7 and a desired tag of Kubernetes:1.10.9. Upgrading this node.
INFO[0005] VM k8s-static-12658618-vmss_8 in VMSS k8s-static-12658618-vmss has a current tag of Kubernetes:1.10.7 and a desired tag of Kubernetes:1.10.9. Upgrading this node.
INFO[0005] VM k8s-static-12658618-vmss_9 in VMSS k8s-static-12658618-vmss has a current tag of Kubernetes:1.10.7 and a desired tag of Kubernetes:1.10.9. Upgrading this node.
INFO[0005] VM k8s-static-12658618-vmss_10 in VMSS k8s-static-12658618-vmss has a current tag of Kubernetes:1.10.7 and a desired tag of Kubernetes:1.10.9. Upgrading this node.
INFO[0005] VM k8s-static-12658618-vmss_11 in VMSS k8s-static-12658618-vmss has a current tag of Kubernetes:1.10.7 and a desired tag of Kubernetes:1.10.9. Upgrading this node.
INFO[0005] VM k8s-static-12658618-vmss_12 in VMSS k8s-static-12658618-vmss has a current tag of Kubernetes:1.10.7 and a desired tag of Kubernetes:1.10.9. Upgrading this node.
INFO[0005] VM k8s-static-12658618-vmss_13 in VMSS k8s-static-12658618-vmss has a current tag of Kubernetes:1.10.7 and a desired tag of Kubernetes:1.10.9. Upgrading this node.
INFO[0005] VM k8s-static-12658618-vmss_14 in VMSS k8s-static-12658618-vmss has a current tag of Kubernetes:1.10.7 and a desired tag of Kubernetes:1.10.9. Upgrading this node.
INFO[0005] VM k8s-static-12658618-vmss_15 in VMSS k8s-static-12658618-vmss has a current tag of Kubernetes:1.10.7 and a desired tag of Kubernetes:1.10.9. Upgrading this node.
INFO[0005] VM k8s-static-12658618-vmss_16 in VMSS k8s-static-12658618-vmss has a current tag of Kubernetes:1.10.7 and a desired tag of Kubernetes:1.10.9. Upgrading this node.
INFO[0005] VM k8s-static-12658618-vmss_17 in VMSS k8s-static-12658618-vmss has a current tag of Kubernetes:1.10.7 and a desired tag of Kubernetes:1.10.9. Upgrading this node.
INFO[0005] VM k8s-static-12658618-vmss_18 in VMSS k8s-static-12658618-vmss has a current tag of Kubernetes:1.10.7 and a desired tag of Kubernetes:1.10.9. Upgrading this node.
INFO[0005] VM k8s-static-12658618-vmss_19 in VMSS k8s-static-12658618-vmss has a current tag of Kubernetes:1.10.7 and a desired tag of Kubernetes:1.10.9. Upgrading this node.
INFO[0005] VM k8s-static-12658618-vmss_20 in VMSS k8s-static-12658618-vmss has a current tag of Kubernetes:1.10.7 and a desired tag of Kubernetes:1.10.9. Upgrading this node.
INFO[0005] Master VM name: k8s-master-12658618-0, orchestrator: Kubernetes:1.10.7 (MasterVMs)
INFO[0005] Upgrading to Kubernetes version 1.10.9
INFO[0005] Master nodes StorageProfile: ManagedDisks
INFO[0005] Prepping master nodes for upgrade...
INFO[0005] Resource count before running NormalizeResourcesForK8sMasterUpgrade: 10
INFO[0005] Evaluating if agent pool: master, resource: [concat(variables('masterVMNamePrefix'), copyIndex(variables('masterOffset')))] needs to be removed
INFO[0005] Evaluating if extension: [concat(variables('masterVMNamePrefix'), copyIndex(variables('masterOffset')),'/cse', '-master-', copyIndex(variables('masterOffset')))] needs to be removed
INFO[0005] Evaluating if extension: [concat(variables('masterVMNamePrefix'), copyIndex(variables('masterOffset')), '/computeAksLinuxBilling')] needs to be removed
INFO[0005] Resource count after running NormalizeResourcesForK8sMasterUpgrade: 10
INFO[0005] Total expected master count: 1
INFO[0005] Master nodes that need to be upgraded: 1
INFO[0005] Master nodes that have been upgraded: 0
INFO[0005] Starting upgrade of master nodes...
INFO[0005] masterNodesInCluster: 1
INFO[0005] Upgrading Master VM: k8s-master-12658618-0
INFO[0005] fetching VM: dev_004_QKNOWS_K8s/k8s-master-12658618-0
INFO[0006] found nic name for VM (dev_004_QKNOWS_K8s/k8s-master-12658618-0): k8s-master-12658618-nic-0
INFO[0006] deleting VM: dev_004_QKNOWS_K8s/k8s-master-12658618-0
INFO[0006] waiting for vm deletion: dev_004_QKNOWS_K8s/k8s-master-12658618-0
INFO[0102] deleting nic: dev_004_QKNOWS_K8s/k8s-master-12658618-nic-0
INFO[0102] waiting for nic deletion: dev_004_QKNOWS_K8s/k8s-master-12658618-nic-0
INFO[0102] deleting managed disk: dev_004_QKNOWS_K8s/k8s-master-12658618-0_OsDisk_1_08bcf62084bd4234858234979722d2ba
INFO[0163] Master offset: 0
INFO[0163] Master pool set count to: 1 temporarily during upgrade...
INFO[0163] Starting ARM Deployment (master-18-10-18T20.58.38-194173334). This will take some time...
INFO[0164] Error creating upgraded master VM: k8s-master-12658618-0
FATA[0164] Error upgrading cluster: resources.DeploymentsClient#CreateOrUpdate: Failure sending request: StatusCode=0 -- Original Error: autorest/azure: Service returned an error. Status=400 Code="InvalidTemplate" Message="Deployment template validation failed: 'The value for the template parameter 'kubernetesDashboardCPULimit' at line '1' and column '16921' is not provided. Please see https://aka.ms/arm-deploy/#parameter-file for usage details.'."

This unfortunately happens after the Master node was already deleted.
What you expected to happen:
Cluster upgrade to complete successfully
How to reproduce it (as minimally and precisely as possible):
Initial setup of Cluster with acs-engine 0.21.2:

Kubernetes 1.10.7
Private cluster
RBAC enabled
Calico Networkpolicy
Disable addons:

blobfuse-flexvolume
smb-flexvolume

1 Master
3 Agentpools as vmss

Command used to upgrade:
acs-engine upgrade --subscription-id  --resource-group --location northeurope --deployment-dir deployment-20181004_104850/arm-deploy --upgrade-version 1.10.9 --auth-method client_secret --client-id  --client-secret
Anything else we need to know:
Cluster could be brought back up with using acs-engine 0.21.2 and upgrading to original k8s version 1.10.7.

@chreichert Thanks for reporting. This is indeed a regression that we need to fix.


CAMEL-20276 fixing jms shared topic tests

Description
it seems that sometimes publication happens before artemis finishes creating consumers
Tracking
https://issues.apache.org/jira/browse/CAMEL-20276

/component-test camel-jms

/component-test camel-jms

One thing that probably could be done is polling artemis for the state of consumers, instead of just waiting. If it is needed i can dig into it

/component-test camel-jms

LGTM, thanks.

Thanks for pointing out that i need to wait for the context to be up, instead of just noop!


Taskrun failed to create pod if network policy is added.

I've a namespace tekton where I create task and taskruns. But after adding network policy, taskrun fails to create pod.
error:   failed to create task run pod "echo-hello-world-task-run": pods "echo-hello-world-task-run-pod-7cx77" is forbidden: unable to validate against any pod security policy: [spec.volumes[4]: Invalid value: "downwardAPI": downwardAPI volumes are not allowed to be used]. Maybe missing or invalid Task tekton/echo-hello-world
Note: A taskrun named echo-hello-world exists in tekton namespace.
This is my network policy. tekton-pipeline  & tekton namespaces have a label  role: klovercloud
apiVersion: networking.k8s.io/v1
kind: NetworkPolicy
metadata:
  name: allowed-namespaces
  namespace: tekton
spec:
  ingress:
  - from:
    - namespaceSelector:
        matchLabels:
          role: klovercloud
  - from:
    - namespaceSelector:
        matchLabels:
          role: kube-system
  podSelector: {}
  policyTypes:
  - Ingress

Based on the error message it sounds like the problem is with the controller's pod security policy not allowing use of downward API volumes, not with the network security policy.  What Kubernetes platform are you using, openshift or something else?  How did you install Tekton?

@GregDritschler  I am using kubernetes, I've installed tekton by following descriptor.
https://storage.googleapis.com/tekton-releases/pipeline/latest/release.yaml

I would like to check a few things in your cluster.  Can you post the output of the following commands:
$ kubectl get podsecuritypolicy

$ kubectl get pods -n tekton-pipelines -l app=tekton-pipelines-controller -o yaml

I suspect the tekton controller is using a PodSecurityPolicy that doesn't authorize use of downwardAPI volumes.
Tekton provides a PodSecurityPolicy for the controller but it doesn't authorize use of downwardAPI volumes.  I think it needs to be updated to do that.  @gabemontero @skaegi  do you see any problem with adding that?
There was another problem related to the controller's role binding not granting access to that PSP but that was fixed by #2966.
I was able to recreate the problem in an IBM-hosted cluster but it wasn't easy.  IBM provides default PSPs that grant access to downwardAPI volumes so the admission controller was using those policies.  I had to remove the downwardAPI volume from those PSPs and then the problem occurred.  I added downwardAPI to the tekton controller PSP and it worked again.

I would like to check a few things in your cluster. Can you post the output of the following commands:
$ kubectl get podsecuritypolicy

$ kubectl get pods -n tekton-pipelines -l app=tekton-pipelines-controller -o yaml

I suspect the tekton controller is using a PodSecurityPolicy that doesn't authorize use of downwardAPI volumes.
Tekton provides a PodSecurityPolicy for the controller but it doesn't authorize use of downwardAPI volumes. I think it needs to be updated to do that. @gabemontero @skaegi do you see any problem with adding that?

I'm good with that @GregDritschler
I would consider these volumes valid for the PSP:

configMap
downwardAPI
emptyDir
persistentVolumeClaim
secret

There was another problem related to the controller's role binding not granting access to that PSP but that was fixed by #2966.
I was able to recreate the problem in an IBM-hosted cluster but it wasn't easy. IBM provides default PSPs that grant access to downwardAPI volumes so the admission controller was using those policies. I had to remove the downwardAPI volume from those PSPs and then the problem occurred. I added downwardAPI to the tekton controller PSP and it worked again.

/kind question

@GregDritschler
kubectl get podsecuritypolicy
00-rook-privileged   true    SYS_ADMIN   RunAsAny   RunAsAny           RunAsAny    RunAsAny    false            configMap,downwardAPI,emptyDir,persistentVolumeClaim,secret,projected,hostPath,flexVolume
privileged           true    *           RunAsAny   RunAsAny           RunAsAny    RunAsAny    false            *
psp.restricted       false               RunAsAny   MustRunAsNonRoot   MustRunAs   MustRunAs   true             configMap,emptyDir,secret,persistentVolumeClaim
tekton-pipelines     false               RunAsAny   RunAsAny           MustRunAs   MustRunAs   false            emptyDir,configMap,secret

kubectl get pods -n tekton-pipelines -l app=tekton-pipelines-controller -o yaml

apiVersion: v1
items:
- apiVersion: v1
  kind: Pod
  metadata:
    annotations:
      cluster-autoscaler.kubernetes.io/safe-to-evict: "false"
      cni.projectcalico.org/podIP: <IP_ADDRESS>/32
      cni.projectcalico.org/podIPs: <IP_ADDRESS>/32
      kubernetes.io/psp: privileged
    creationTimestamp: "2020-08-28T15:58:02Z"
    generateName: tekton-pipelines-controller-676ff889cf-
    labels:
      app: tekton-pipelines-controller
      app.kubernetes.io/component: controller
      app.kubernetes.io/instance: default
      app.kubernetes.io/name: controller
      app.kubernetes.io/part-of: tekton-pipelines
      app.kubernetes.io/version: v0.15.2
      pipeline.tekton.dev/release: v0.15.2
      pod-template-hash: 676ff889cf
      version: v0.15.2
    name: tekton-pipelines-controller-676ff889cf-9k6mh
    namespace: tekton-pipelines
    ownerReferences:
    - apiVersion: apps/v1
      blockOwnerDeletion: true
      controller: true
      kind: ReplicaSet
      name: tekton-pipelines-controller-676ff889cf
      uid: 35a109ea-d2af-41bb-b1c8-ca2e2ed67c78
    resourceVersion: "738735"
    selfLink: /api/v1/namespaces/tekton-pipelines/pods/tekton-pipelines-controller-676ff889cf-9k6mh
    uid: c6d97375-2f44-4558-a317-5a73e8fbd23a
  spec:
    containers:
    - args:
      - -kubeconfig-writer-image
      - klovercloud/tektoncd-pipeline-cmd-kubeconfigwriter:v0.15.2
      - -creds-image
      - klovercloud/tektoncd-pipeline-cmd-creds-init:v0.15.2
      - -git-image
      - klovercloud/tektoncd-pipeline-cmd-git-init:v0.15.2
      - -entrypoint-image
      - klovercloud/tektoncd-pipeline-cmd-entrypoint:v0.15.2
      - -nop-image
      - klovercloud/tektoncd-pipeline-cmd-nop:v0.15.2
      - -imagedigest-exporter-image
      - klovercloud/tektoncd-pipeline-cmd-imagedigestexporter:v0.15.2
      - -pr-image
      - klovercloud/tektoncd-pipeline-cmd-pullrequest-init:v0.15.2
      - -build-gcs-fetcher-image
      - klovercloud/tektoncd-pipeline-cmd-gcs-fetcher:v0.15.2
      - -gsutil-image
      - klovercloud/gcloud-sdk
      - -shell-image
      - klovercloud/tektoncd-distroless-base
      env:
      - name: SYSTEM_NAMESPACE
        valueFrom:
          fieldRef:
            apiVersion: v1
            fieldPath: metadata.namespace
      - name: CONFIG_DEFAULTS_NAME
        value: config-defaults
      - name: CONFIG_LOGGING_NAME
        value: config-logging
      - name: CONFIG_OBSERVABILITY_NAME
        value: config-observability
      - name: CONFIG_ARTIFACT_BUCKET_NAME
        value: config-artifact-bucket
      - name: CONFIG_ARTIFACT_PVC_NAME
        value: config-artifact-pvc
      - name: CONFIG_FEATURE_FLAGS_NAME
        value: feature-flags
      - name: CONFIG_LEADERELECTION_NAME
        value: config-leader-election
      - name: METRICS_DOMAIN
        value: tekton.dev/pipeline
      image: klovercloud/tektoncd-pipeline-cmd-controller:v0.15.2
      imagePullPolicy: Always
      name: tekton-pipelines-controller
      resources: {}
      terminationMessagePath: /dev/termination-log
      terminationMessagePolicy: File
      volumeMounts:
      - mountPath: /etc/config-logging
        name: config-logging
      - mountPath: /var/run/secrets/kubernetes.io/serviceaccount
        name: tekton-pipelines-controller-token-nzmns
        readOnly: true
    dnsPolicy: ClusterFirst
    enableServiceLinks: true
    nodeName: test-worker-1
    priority: 0
    restartPolicy: Always
    schedulerName: default-scheduler
    securityContext: {}
    serviceAccount: tekton-pipelines-controller
    serviceAccountName: tekton-pipelines-controller
    terminationGracePeriodSeconds: 30
    tolerations:
    - effect: NoExecute
      key: node.kubernetes.io/not-ready
      operator: Exists
      tolerationSeconds: 300
    - effect: NoExecute
      key: node.kubernetes.io/unreachable
      operator: Exists
      tolerationSeconds: 300
    volumes:
    - configMap:
        defaultMode: 420
        name: config-logging
      name: config-logging
    - name: tekton-pipelines-controller-token-nzmns
      secret:
        defaultMode: 420
        secretName: tekton-pipelines-controller-token-nzmns
  status:
    conditions:
    - lastProbeTime: null
      lastTransitionTime: "2020-08-28T15:58:02Z"
      status: "True"
      type: Initialized
    - lastProbeTime: null
      lastTransitionTime: "2020-08-28T15:58:10Z"
      status: "True"
      type: Ready
    - lastProbeTime: null
      lastTransitionTime: "2020-08-28T15:58:10Z"
      status: "True"
      type: ContainersReady
    - lastProbeTime: null
      lastTransitionTime: "2020-08-28T15:58:02Z"
      status: "True"
      type: PodScheduled
    containerStatuses:
    - containerID: docker://671cd1603854fdc5e927d2326a93271d9c0d6d4351e5ea65fb8da3d00435b453
      image: klovercloud/tektoncd-pipeline-cmd-controller:v0.15.2
      imageID: docker-pullable://klovercloud/tektoncd-pipeline-cmd-controller@sha256:a26839a8fab19457649ee64aa3cb4818c93f5734c93cd2c1fdf2591da9964d5f
      lastState: {}
      name: tekton-pipelines-controller
      ready: true
      restartCount: 0
      started: true
      state:
        running:
          startedAt: "2020-08-28T15:58:09Z"
    hostIP: <IP_ADDRESS>
    phase: Running
    podIP: <IP_ADDRESS>
    podIPs:
    - ip: <IP_ADDRESS>
    qosClass: BestEffort
    startTime: "2020-08-28T15:58:02Z"
kind: List
metadata:
  resourceVersion: ""
  selfLink: ""

That's strange.  The controller pod was validated with the privileged PSP per the kubernetes.io/psp: privileged annotation.  That PSP allows all volume types per the output of kubectl get podsecuritypolicy.  So I don't understand how the reported error of the controller not being able to create a pod that uses a downwardAPI volume is happening.  @gabemontero Am I missing something here?  I still think the tekton PSP needs to be updated but I'm not sure based on this that it's the problem here.

Not that I can tell @GregDritschler
The network policy must be getting in the way somehow of the pod security policy stuff in a unexpected way, per the cause and effect noted in the description.  As I took the description, it runs fine with PSP on and NP off.
I'm unfamiliar with networks policies.  Per the doc at https://kubernetes.io/docs/concepts/services-networking/network-policies/#prerequisites which pointed me to https://kubernetes.io/docs/concepts/extend-kubernetes/compute-storage-net/network-plugins/ it is an alpha level feature even as far out as 1.19.
Unexpectedness with alpha level features is not unheard of.
I tried some searches around using PSP and NP in conjunction but did not find anything of note.
But again, feels more like a k8s issue than a tekton one.

The tekton-pipelines-controller and tekton-pipelines-webhook both need to have an egress to the api server. Something like...
apiVersion: networking.k8s.io/v1
kind: NetworkPolicy
metadata:
  name: only-allow-egress-to-apiserver
  namespace: tekton-pipelines
spec:
  podSelector:
    matchLabels: {}
  policyTypes:
  - Egress
  egress:
  - to:
    - ipBlock:
         cidr: <IP_ADDRESS>/32
    ports:
    - port: 2040
      protocol: TCP

It's likely different in your cluster, but If you look at the kubernetes service in the default namespace you can get the correct values ipBlock and port values from the service Endpoint. e.g.
Simons-MBP:~ skaegi$ kubectl describe service kubernetes
Name:              kubernetes
Namespace:         default
Labels:            component=apiserver
                   provider=kubernetes
Annotations:       <none>
Selector:          <none>
Type:              ClusterIP
IP:                <IP_ADDRESS>
Port:              https  443/TCP
TargetPort:        2040/TCP
Endpoints:         <IP_ADDRESS>:2040
Session Affinity:  None
Events:            <none>


How to turn off tunnelling?

Hi guys,
is there an easy way to turn off tunelling the traffic?
I would like to have VPN set up that it does not tunell my computer traffic but let me access other computer in the network (and also jenkins that is hosted on same machine and that is binded to VPN's IP address).
Thank a lot for help!

Look at disabling NAT routing:
https://github.com/kylemanna/docker-openvpn/blob/master/bin/ovpn_genconfig#L43

Hello, just wanted to ask the same question but the link point on a blank line :/


generateEntityDiagram.rb (LoadError)

I enter my project but this error comes ruby: No such file or directory what is problem

Can you please give us some more information on how you invoke the ruby command and what is the folder structure?

Hello. I'm having the same problem.
I run the command git clone https://github.com/yoshimkd/swift-auto-diagram into Terminal.
Then ruby generateEntityDiagram.rb ~/User/ProjectName
and then I get the error ruby: No such file or directory -- generateEntityDiagram.rb (LoadError).
What I'm doing wrong?
Thanks for the help!

Hello. I'm having the same problem.
I run the command git clone https://github.com/yoshimkd/swift-auto-diagram into Terminal.
Then ruby generateEntityDiagram.rb ~/User/ProjectName
and then I get the error ruby: No such file or directory -- generateEntityDiagram.rb (LoadError).
What I'm doing wrong?
Thanks for the help!

@Karencse Do you execute the command from the directory where the generateEntityDiagram.rb script is located (the cloned directory)?

@Karencse Do you execute the command from the directory where the generateEntityDiagram.rb script is located (the cloned directory)?

@Karencse Do you execute the command from the directory where the generateEntityDiagram.rb script is located (the cloned directory)?

Hello yoshimkd,
thanks for your answer. I checked that. I'm executing the command from the directory (swift-auto-diagram). The project is in my desktop. So I called
ruby generateEntityDiagram.rb~/Users/karencruz/Desktop/TrackingApp
but im still having this issue.
ruby: No such file or directory -- generateEntityDiagram.rb~/Users/karencruzsanchez/Desktop/TrackingApp (LoadError)

@Karencse Do you execute the command from the directory where the generateEntityDiagram.rb script is located (the cloned directory)?

Hello yoshimkd,
thanks for your answer. I checked that. I'm executing the command from the directory (swift-auto-diagram). The project is in my desktop. So I called
ruby generateEntityDiagram.rb~/Users/karencruz/Desktop/TrackingApp
but im still having this issue.
ruby: No such file or directory -- generateEntityDiagram.rb~/Users/karencruzsanchez/Desktop/TrackingApp (LoadError)

@Karencse There should be a space character before specifying the directory: ruby generateEntityDiagram.rb ~/Users/karencruz/Desktop/TrackingApp.

@Karencse There should be a space character before specifying the directory: ruby generateEntityDiagram.rb ~/Users/karencruz/Desktop/TrackingApp.

@yoshimkd Hello yoshimkd, I am having a similar issue.
I am typing -- ruby generateEntityDiagram.rb ~/Users/jodanelysee/Desktop/Bullseye -- into my terminal and it keeps on telling me: ruby: No such file or directory -- generateEntityDiagram.rb (LoadError)
When I check the info on the file that I want to diagram, that is the file path that it is giving me and It is still not working. What could I do to fix this?


construct a fake function defination and use ast.parse to extract the args

to Cover all the function defination styles

test with https://github.com/PaddlePaddle/docs/pull/4432


feat(pubsublite): multipartition publisher

This PR implements a multipartition publisher

This change is

google/cloud/pubsublite/internal/multipartition_publisher.cc, line 207 at r46 (raw file):
Previously, dpcollins-google wrote…
TriggerPublisherCreation doesn't check this before emplacing the future, so this is a race. You need to check whether it is shutdown under lock, otherwise you have this race:

thread 1 checks if composite is shutdown in TriggerPublisherCreation
thread 2 calls Shutdown, shuts down composite
thread 2 gets mutex, sees no outstanding request
thread 1 gets mutex, emplaces outstanding request

Note you don't need to call Shutdown() under lock.

Actually sorry, this comment is just wrong. Since the cancel_token_ has already been destroyed, there are no new calls to TriggerPublisherCreation, so the ordering here is only necessary for the early exit in the alarm case. You can just remove the comment, no other changes are needed

When I said I would reject PRs over 1,000 lines it was not meant as a challenge for you to get as close to that as possible. That meant "1,000 lines is obviously too many, I won't even bother looking".

Oh sorry didn't mean for the LOC count in this PR to come off like that. I just interpreted 1k as a standard threshold to follow.

google/cloud/pubsublite/internal/multipartition_publisher_test.cc, line 170 at r50 (raw file):
Previously, 18suresha (Adarsh Suresh) wrote…
I don't follow why it would be easier? Isn't the test harness DRYing up the instantiation?

You may be "DRYing" the instantiations, but then repeat this cleanup fragment over and over:
  // https://stackoverflow.com/questions/10286514/why-is-googlemock-leaking-my-shared-ptr
  EXPECT_TRUE(Mock::VerifyAndClearExpectations(partition_publisher_0_.get()));
  EXPECT_TRUE(Mock::VerifyAndClearExpectations(partition_publisher_1_.get()));

The tradeoff is not obvious, and the increased distance (in code lines) from where the mocks are created to where they are used is a downside.
Maybe a helper function that returned both mocks would be fine (if it removed the need to copy that fragment over and over)?
Creating two mocks is not a particularly interesting piece of "knowledge", repeating it in each test case would not be the end of the world.
Maybe move the cleanup fragment to a TearDown() function?
If I was doing this, I think I would just initialize the mocks in each test case, but I would be fine if the cleanup was refactored too.
:information_source: as originally published, DRY says "Every piece of knowledge must have a single, unambiguous, authoritative representation within a system". Code duplication is not the problem that DRY is talking about (it is "a" problem, but not "the" problem).


Is it possible for you to do more frequent releases following semver?

This is the current difference between the last released version (0.2.13) and master: https://github.com/angular-ui/ui-router/compare/0.2.13...master
I notice that there is sometime more than 4 months of lag between merging pull requests and releases.
It would not be a bad idea to make sure to follow http://semver.org/ and releasing a new patch version when bugs are fixed.
Is there a good reason not to have a task in the gruntfile that automatically does the release on bower and it is executed after some code is merged and tests pass?
If the core team cannot, can we find somebody among all the contributors that can and want to do it?

Here are the short answers:

Is it possible for you to do more frequent releases [...] ?

Yes.

[...] [F]ollowing semver?

No.
Slightly longer answer:
Semver dictates a new major release with every BC-breaking change. There are a lot of things in the API that, even after all this time, are still very much evolving, and we plan to lock it down once 1.0 hits. So, for the moment those two things are in conflict. Post-1.0, however, we very much plan to follow semver.
Finally, I'll push a new release tonight or tomorrow. While doing a release certainly isn' a major project, it is still somewhat involved, as certain packaging systems (NPM for one, I think) still haven't been fully integrated into the build tooling. If this is something you'd like to help fix, I'd be happy to help point you in the right direction.

At long last, your moment of zen. Sorry about the wait.


Rails Capstone Project: FINAL REVIEW

WELCOME TO BUDGET APP
During this capstone project, I successfully achieved the following milestones:

I used Ruby and Ruby on Rails (RoR) design this RESTful application.
The application includes several models based on an Entity-Relationship Diagram (ERD) in PostgresSQL. The models include
User, Group, Expense, and a bridge tables.
Authentication is implemented using Devise, while authorization is handled by cancancan.
An unauthorized user is presented with a splash screen upon accessing the application.
The category page serves as the home page for the application.
A transaction page has been created.
Unit and integration tests have been written using RSpec.
Authenticated users have the ability to create groups and expenses.
I have recorded a video presentation showcasing the project's details. please check below
The web service has been deployed on the Render site, as shown below
The design of the application adhered to a mobile-first approach

Project presentation video record_button . Please click the link to check it out link

Thanks @addod19,  Sure I will fix it


update the logo and category of PaddlePaddle

Pre-submission checklist:
Please check each of these after submitting your pull request:

[x] Are you only including a repo_url if your project is 100% open source? If so, you need to pick the single best GitHub repository for your project, not a GitHub organization.
[x] Is your project closed source or, if it is open source, does your project have at least 250 GitHub stars?
[x] Have you picked the single best (existing) category for your project?
[x] Does it follow the other guidelines from the new entries section?
[x] Have you included a URL for your SVG or added it to hosted_logos and referenced it there?
[x] Does your logo clearly state the name of the project/product and follow the other logo guidelines?
[x] Does your project/product name match the text on the logo?
[x] Have you verified that the Crunchbase data for your organization is correct (including headquarters and LinkedIn)?
[x] ~10 minutes after opening the pull request, the CNCF-Bot will post the URL for your staging server. Have you confirmed that it looks good to you and then added a comment to the PR saying "LGTM"?

LGTM.

LGTM

Deploy preview for lfailandscape ready!
Built with commit 086a7ab
https://deploy-preview-160--lfailandscape.netlify.com

LGTM


[SPARK-17511] Yarn Dynamic Allocation: Avoid marking released container as Failed

What changes were proposed in this pull request?
Due to race conditions, the  assert(numExecutorsRunning <= targetNumExecutors) can fail causing AssertionError. So removed the assertion, instead moved the conditional check before launching new container:
java.lang.AssertionError: assertion failed
        at scala.Predef$.assert(Predef.scala:156)
        at org.apache.spark.deploy.yarn.YarnAllocator$$anonfun$runAllocatedContainers$1.org$apache$spark$deploy$yarn$YarnAllocator$$anonfun$$updateInternalState$1(YarnAllocator.scala:489)
        at org.apache.spark.deploy.yarn.YarnAllocator$$anonfun$runAllocatedContainers$1$$anon$1.run(YarnAllocator.scala:519)
        at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
        at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
        at java.lang.Thread.run(Thread.java:745)

How was this patch tested?
This was manually tested using a large ForkAndJoin job with Dynamic Allocation enabled to validate the failing job succeeds, without any such exception.

Can one of the admins verify this patch?

Jenkins, test this please

Test build #65321 has started for PR 15069 at commit 19d55b6.

Test build #65321 has finished for PR 15069 at commit 19d55b6.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/65321/
Test PASSed.

Jenkins, test this please

Test build #65387 has started for PR 15069 at commit 5bca02d.

minor nit, waiting on Jenkins, otherwise looks good.

@tgravescs fixed the test name

Test build #65387 has finished for PR 15069 at commit 5bca02d.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/65387/
Test PASSed.

Jenkins, test this please

Test build #65391 has started for PR 15069 at commit 09fbd3e.

Test build #65391 has finished for PR 15069 at commit 09fbd3e.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/65391/
Test PASSed.


ImportError: No module named '_pywrap_tensorflow_internal'

Hi all,
Using windows 7 and have made tensorflow work in the cpu version. But keep getting this error in the gpu version.
Installed it using pip install tensorflow-gpu. Have cuda 8.0 and cudnn 5.1. Have the dll file and cudnn files copied over. GPU model is K610M.
Thanks in advance for the assistance.
Capture of the screen:
(C:\Users\KiraYamato\Anaconda3) C:\Users\KiraYamato>activate tensorflow-gpu
(tensorflow-gpu) C:\Users\KiraYamato>python
Python 3.5.3 |Continuum Analytics, Inc.| (default, Feb 22 2017, 21:28:42) [MSC v
.1900 64 bit (AMD64)] on win32
Type "help", "copyright", "credits" or "license" for more information.

import tensorflow as tf
Traceback (most recent call last):
File "C:\Users\KiraYamato\Anaconda3\envs\tensorflow-gpu\lib\site-packages\tens
orflow\python\pywrap_tensorflow_internal.py", line 18, in swig_import_helper
return importlib.import_module(mname)
File "C:\Users\KiraYamato\Anaconda3\envs\tensorflow-gpu\lib\importlib_init_
.py", line 126, in import_module
return _bootstrap._gcd_import(name[level:], package, level)
File "", line 986, in _gcd_import
File "", line 969, in _find_and_load
File "", line 958, in _find_and_load_unlocked
File "", line 666, in _load_unlocked
File "", line 577, in module_from_spec
File "", line 914, in create_module
File "", line 222, in _call_with_frames_removed
ImportError: DLL load failed: The specified procedure could not be found.

During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "C:\Users\KiraYamato\Anaconda3\envs\tensorflow-gpu\lib\site-packages\tens
orflow\python\pywrap_tensorflow.py", line 41, in
from tensorflow.python.pywrap_tensorflow_internal import *
File "C:\Users\KiraYamato\Anaconda3\envs\tensorflow-gpu\lib\site-packages\tens
orflow\python\pywrap_tensorflow_internal.py", line 21, in
_pywrap_tensorflow_internal = swig_import_helper()
File "C:\Users\KiraYamato\Anaconda3\envs\tensorflow-gpu\lib\site-packages\tens
orflow\python\pywrap_tensorflow_internal.py", line 20, in swig_import_helper
return importlib.import_module('pywrap_tensorflow_internal')
File "C:\Users\KiraYamato\Anaconda3\envs\tensorflow-gpu\lib\importlib_init
.py", line 126, in import_module
return _bootstrap._gcd_import(name[level:], package, level)
ImportError: No module named '_pywrap_tensorflow_internal'
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "", line 1, in
File "C:\Users\KiraYamato\Anaconda3\envs\tensorflow-gpu\lib\site-packages\tens
orflow_init_.py", line 24, in
from tensorflow.python import *
File "C:\Users\KiraYamato\Anaconda3\envs\tensorflow-gpu\lib\site-packages\tens
orflow\python_init_.py", line 51, in
from tensorflow.python import pywrap_tensorflow
File "C:\Users\KiraYamato\Anaconda3\envs\tensorflow-gpu\lib\site-packages\tens
orflow\python\pywrap_tensorflow.py", line 52, in
raise ImportError(msg)
ImportError: Traceback (most recent call last):
File "C:\Users\KiraYamato\Anaconda3\envs\tensorflow-gpu\lib\site-packages\tens
orflow\python\pywrap_tensorflow_internal.py", line 18, in swig_import_helper
return importlib.import_module(mname)
File "C:\Users\KiraYamato\Anaconda3\envs\tensorflow-gpu\lib\importlib_init_
.py", line 126, in import_module
return _bootstrap._gcd_import(name[level:], package, level)
File "", line 986, in _gcd_import
File "", line 969, in _find_and_load
File "", line 958, in _find_and_load_unlocked
File "", line 666, in _load_unlocked
File "", line 577, in module_from_spec
File "", line 914, in create_module
File "", line 222, in _call_with_frames_removed
ImportError: DLL load failed: The specified procedure could not be found.
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "C:\Users\KiraYamato\Anaconda3\envs\tensorflow-gpu\lib\site-packages\tens
orflow\python\pywrap_tensorflow.py", line 41, in
from tensorflow.python.pywrap_tensorflow_internal import *
File "C:\Users\KiraYamato\Anaconda3\envs\tensorflow-gpu\lib\site-packages\tens
orflow\python\pywrap_tensorflow_internal.py", line 21, in
_pywrap_tensorflow_internal = swig_import_helper()
File "C:\Users\KiraYamato\Anaconda3\envs\tensorflow-gpu\lib\site-packages\tens
orflow\python\pywrap_tensorflow_internal.py", line 20, in swig_import_helper
return importlib.import_module('pywrap_tensorflow_internal')
File "C:\Users\KiraYamato\Anaconda3\envs\tensorflow-gpu\lib\importlib_init
.py", line 126, in import_module
return _bootstrap._gcd_import(name[level:], package, level)
ImportError: No module named '_pywrap_tensorflow_internal'
Failed to load the native TensorFlow runtime.
See https://www.tensorflow.org/install/install_sources#common_installation_probl
ems
for some common reasons and solutions.  Include the entire stack trace
above this error message when asking for help.

Hi @quatre008,
As the stack overflow link suggests, have you tried to invoke tensorflow by staying out of the source code directory?

Hi @quatre008, sorry you're facing issues, could you please check if your CUDA and cuDNN DLLs are properly set on your %PATH%?

Hi,
@karandesai-96 I tried many different directories and still the same. Tensorflow worked but not tensorflow gpu.
@Carmezim How do I know if it is properly set? I only found the following:
PATH: C:\Users\KiraYamato\Anaconda3;C:\Users\KiraYamato\Anaconda3\Scripts;C:\Users\KiraYamato\Anaconda3\Library\bin
CUDA_PATH : C:\Program Files\NVIDIA GPU Computing Toolkit\CUDA\v8.0
CUDA_PATH_V8_0: C:\Program Files\NVIDIA GPU Computing Toolkit\CUDA\v8.0

@quatre008 what happens sometimes is that cuDNN DLLs are installed in a different directory of CUDA so you need to add it also. Make sure you installed cuDNN correctly and if its DLLs are not in those directories already in your %PATH% you need to add them.

@Carmezim I have copied the files into the same CUDA directory as mentioned. So I am guessing it should be working fine. I have re-downloaded and overwritten to make sure this was the case too.

@quatre008 If you went over CUDA and cuDNN installation again and have everything figured out completely uninstall TensorFlow and install it (only GPU) again. If the problem persists then it's not CUDA/cuDNN related.

Ok I finally managed to resolve the issue.
2 issues at work here. One being my Visual Studio was not installed properly, and the second one (outside of this topic but still interesting) is that my laptop has dual graphics boot-up.
So for the first issue, I managed to resolve it by deleting most folders and restarting the installation, starting from visual studio (the free version of community VS2017 did not work previously).
Then as for the second issue, I only need to remove intel graphics from the bootup menu and solely use the K610M that I am having and everything is fine now, except for a list of warning messages that seems to be common in most cases.
Thanks for the help again. Much appreciated.

Glad you got it resolved, and thank you for reporting information to help others in the future. Closing for now.

Hi @quatre008 ... I am having the same error as u had. Which visual studio version did u use ?

Hi, I am having this issue on Linux. I am trying to install tensorflow with pypy.
My ./configure has everything default except the python interpreter /usr/local/bin/pypy.
When importing I get:
Python 2.7.13 (c925e73810367cd960a32592dd7f728f436c125c, Jun 08 2017, 09:20:57)
[PyPy 5.8.0 with GCC 6.3.0 20170516] on linux2
Type "help", "copyright", "credits" or "license" for more information.
>>>> import tensorflow
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/root/nn/pypy2-v5.8.0-src/site-packages/tensorflow/__init__.py", line 24, in <module>
    from tensorflow.python import *
  File "/root/nn/pypy2-v5.8.0-src/site-packages/tensorflow/python/__init__.py", line 49, in <module>
    from tensorflow.python import pywrap_tensorflow
  File "/root/nn/pypy2-v5.8.0-src/site-packages/tensorflow/python/pywrap_tensorflow.py", line 52, in <module>
    raise ImportError(msg)
ImportError: Traceback (most recent call last):
  File "/root/nn/pypy2-v5.8.0-src/site-packages/tensorflow/python/pywrap_tensorflow.py", line 41, in <module>
    from tensorflow.python.pywrap_tensorflow_internal import *
  File "/root/nn/pypy2-v5.8.0-src/site-packages/tensorflow/python/pywrap_tensorflow_internal.py", line 28, in <module>
    _pywrap_tensorflow_internal = swig_import_helper()
  File "/root/nn/pypy2-v5.8.0-src/site-packages/tensorflow/python/pywrap_tensorflow_internal.py", line 20, in swig_import_helper
    import _pywrap_tensorflow_internal
ImportError: No module named _pywrap_tensorflow_internal

Failed to load the native TensorFlow runtime.

See https://www.tensorflow.org/install/install_sources#common_installation_problems

for some common reasons and solutions.  Include the entire stack trace
above this error message when asking for help.
>>>>

@mateon1
https://stackoverflow.com/questions/35953210/error-running-basic-tensorflow-example

Try to use cuDNN v5.1 for CUDA 8.0, this solves the issue for me.

If you are using tensorflow 1.3 then the current documentation, you want to use cuDNN v6.0 https://github.com/tensorflow/tensorflow/issues/7705

tensorflow 1.2 + cudnn 5.1: works fine
tensorflow 1.2 + cudnn 6.0: ImportError
tensorflow 1.3 + cudnn 5.1: works fine
tensorflow 1.3 + cudnn 6.0: works fine

@chriswbarrett  Thanks so much!
TensorFlow 1.3 + cudNN 6.0 with Cuda 8

Working!

It really does work!

TensorFlow 1.3 + CuDNN 6.0 with Cuda 8

TensorFlow 1.3 + CuDNN 6.0与Cuda 8

TensorFlow 1.3 + CuDNN 6.0 with Cuda 8
It worked with CuDNN 6.0. I had "import error" with CuDNN 5.1.

tensorflow 1.3 + cudnn 6.0: works fine
tensorflow 1.3 + cudnn 7.0.2: import error

@lintseju TensorFlow as of now only supports cuDNN v6.0

@aselle should we lock the thread? The solution mostly comes down to reading the
installation docs and is given multiple times in the thread already.

Look like the TensorFlow has stated using cuDNN 6.x in the past couple of days (from 5.1).
(cuDNN=NVIDIA CUDA Deep Neural Network library )
https://www.tensorflow.org/install/install_windows#CommonInstallationProblems
The problem on my computer got solved after I upgrading cuDNN 6.x (TF will not work with cuDNN  7 yet)
https://developer.nvidia.com/cudnn
My configuration is
Windows 10 x64, with GPU GTX 1080 ti
Anaconda 5.0.0 (with Python 3.6)
CUDA Toolkit 8.0
cuDNN v6.0

On Win7, W7, Windows 7 try to install   Microsoft Visual C++ 2015 Redistributable Update 3
https://www.microsoft.com/en-us/download/details.aspx?id=53587
first. It helped for me.
see: https://github.com/tensorflow/tensorflow/issues/5949

I have experienced the same issue after replacing hardware on my computer. I tried @mrry script to check the install was correct, and it was. However, in the process, it appears that either the drivers got corrupted or required to be upgraded.
After installing the 388.00 drivers (http://us.download.nvidia.com/Windows/388.00/388.00-desktop-win8-win7-64bit-international-whql.exe), tensorflow would import again.

I had the same problem with tensorflow 1.6, i downgrade it to 1.5 and everything is OK now.
pip uninstall tensorflow
And then
pip install tensorflow==1.5

@sddai , I have the same problem, my environment is win7+cuda9.1+cudnn7, I downgrade tensorflow-gpu to 1.5, I still have the same issue

@yslTech Cuda 9.1 does not work with tf yet. I've outlined the instructions and troubleshooting in the post above.

Please also check if your CPU supports AVX if you have installed tensorflow 1.6. I got this error since my CPU does not support AVX, so I had to downgrade to tensorflow 1.5.

@MarioDogan I checked my CPU with tool CPU-Z and found it doesn't support AVX, I downgrade tensorflow-gpu to 1.5 and finally I can import it.  Thank you so mach!

@sddai solution is working !

MarioDogan's answer is the one if the PC you're running on is pre-2012, or if you are like "wtf cuda library? I didn't install GPU version."

[non cuda, cpu only version]
this is all about your video chip/card and CPU compatibility with TF VERSION! Current version of Tensor Flow is 1.8 and it crashes on both my machines.
I have a win7 Gateway notebook using an I5 CPU and intel video chip. I have a desktop win7 unit with AMD Phenom II and AMD Radeon HD5450 video card. The I5 notebook requires V1.6 of TensorFlow and the desktop AMD unit takes V1.5. I don't have a GPU available for running ANN's so I don't know how that would affect it.
Here's the command line for PIP install: pip install --upgrade tensorflow==1.5.0 (or whatever other version you need). This will uninstall your current version and then install the indicated version.
Build or copy a small TensorFlow script and run it. Open a second command window and install a different version. I'd recommend starting at 1.5 and working your way up.

On Win7, W7, Windows 7 try to install Microsoft Visual C++ 2015 Redistributable Update 3
https://www.microsoft.com/en-us/download/details.aspx?id=53587
first. It helped for me.
see: #5949

plz confirm your tensorflow version and python version and system 32 bit or 64 bit

i am also facing this issue .please suggest some solution

I gave up on TensorFlow, but now I have Win10 machines, Python 3.7, and a new mother board and CPU so I'll give it a try later. I'll start with V1.5 and work my way up as suggested earlier. Also I have VS2019. I need to see if I've got the older C++ Redist. installed. That seems to be a major issue for TF.


1.6beta1: trivial invocation of go test -msan fails with use-of-uninitialized-value

foo_test.go:
package foo

import "testing"

func FooTest(t *testing.T) {
}

$ go test -msan
==1083== WARNING: MemorySanitizer: use-of-uninitialized-value
    #0 0x7ff79a84d2a8  (/tmp/go-build084496566/github.com/cockroachdb/cockroach/foo/_test/foo.test+0x30a2a8)
    #1 0x7ff79a74f7ac  (/tmp/go-build084496566/github.com/cockroachdb/cockroach/foo/_test/foo.test+0x20c7ac)

Exiting
exit status 77
FAIL	github.com/cockroachdb/cockroach/foo	0.013s

Running under lldb didn't reveal much other than the involvement of cgo (I had to build the executable to get image lookup to work):
$ go test -msan -c -o foo.test
$ lldb-3.6 -- foo.test
(lldb) target create "foo.test"
Current executable set to 'foo.test' (x86_64).
(lldb) process launch --disable-aslr=false
Process 1193 launching
Process 1193 launched: '/go/src/github.com/cockroachdb/cockroach/foo/foo.test' (x86_64)
(lldb) ==1193== WARNING: MemorySanitizer: use-of-uninitialized-value
    #0 0x7f2b2762c2a8  (/go/src/github.com/cockroachdb/cockroach/foo/foo.test+0x30a2a8)
    #1 0x7f2b2752e7ac  (/go/src/github.com/cockroachdb/cockroach/foo/foo.test+0x20c7ac)

Exiting
Process 1193 exited with status = 77 (0x0000004d)

error: No auto repeat.
(lldb) image lookup --address 0x7f2b2752e7ac
      Address: foo.test[0x000000000020c7ac] (foo.test..text + 709100)
      Summary: foo.test`runtime.asmcgocall + 172 at asm_amd64.s:612
(lldb) image lookup --address 0x7f2b2762c2a8
      Address: foo.test[0x000000000030a2a8] (foo.test..text + 1748200)
      Summary: foo.test`_cgo_sys_thread_start + 920 at gcc_linux_amd64.c:72
(lldb)

Some system details:
$ uname -a
Linux 43c41b292c47 4.0.9-boot2docker #1 SMP Thu Sep 10 20:39:20 UTC 2015 x86_64 GNU/Linux
$ go version
go version go1.6beta1 linux/amd64
$ go env
GOARCH="amd64"
GOBIN=""
GOEXE=""
GOHOSTARCH="amd64"
GOHOSTOS="linux"
GOOS="linux"
GOPATH="/go"
GORACE=""
GOROOT="/usr/local/go"
GOTOOLDIR="/usr/local/go/pkg/tool/linux_amd64"
GO15VENDOREXPERIMENT="1"
CC="/usr/bin/clang-3.6"
GOGCCFLAGS="-fPIC -m64 -pthread -fno-caret-diagnostics -Qunused-arguments -fmessage-length=0"
CXX="/usr/bin/clang++-3.6"
CGO_ENABLED="1"

Note that I had to use:

linux 4.0.9 due to https://llvm.org/bugs/show_bug.cgi?id=24155, and couldn't upgrade from
clang 3.6 due to https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=779785

cc @ianlancetaylor

On GNU/Linux you need to use at least clang 3.8.
This should be documented but I'm not sure where to do it.

I'm able to reproduce this with clang 3.8 as well.
It appears the magic that reproduces it is:
CGO_LDFLAGS='-fsanitize=memory' CGO_CPPFLAGS='-fsanitize=memory' go test -a -msan

I'm using CGO_{LDFLAGS,CPPFLAGS} to control compilation of my cgo stuff, but it appears that compiling something in the standard library with these environment variables causes this issue.
I'm using clang as provided by the Chromium team (https://github.com/google/sanitizers/wiki/AddressSanitizerHowToBuild#chrome). The exact version is:
$ clang --version
clang version 3.8.0 (trunk 255169)
Target: x86_64-unknown-linux-gnu
Thread model: posix
InstalledDir: /third_party/llvm-build/Release+Asserts/bin

Thanks for the reproduction instructions.  I will send a CL to fix this.


attributesWhitelist does not handle class attribute in img tags

Describe the bug
This configuration:
attributesWhitelist: {
'img': 'class|style|data-.+'
},
Does not keep the class attribute in the img tag.
To Reproduce

add a image
goto source editor
add class="myclass" to the img tag
save

Expected behavior
It would be nice to have the class tag keept at the img tag even after save.
Use Case: PreviewImage in a template should be visible in editor and not visible in saved output.
Version: 2.44.12

Browser firefox

Classes must start with "se-, se".

Thank you!

The 2.45.0 version has been updated.
Thank you.


Dramatically speed up FID computation using DataLoader for asynchronous data loading

Hello,
By using Pytorch's data loading pipeline, we can benefit of parallel and asynchronous data loading.
With the same batch size, My FID computation times goes from ~18 mins to ~3 mins.

Hi, why not use original torchvision.datasets.ImageFolder?

because it forces to have a subdirectory in your image directory (because it gets labels from subdirs) which is an unnecessary and unnatural constraint for the problem at hand

okay, that's reasonable. My workaround is to wrap one more folder. It is quite convenient.

that works too, but is less convenient to work with :)

Outdated due to #47.


Improve file meta data

Allow displaying custom views as value
Allow linking to a file settings dialog tab
Link to text tracks settings dialog tab.

Coverage remained the same at 99.095% when pulling 74b32e7ad716b6b2cd91f498830669615f55b98b on tf:meta-data-items into 953d72224ff44b572e577fffd29a2132d80d7aa4 on codevise:master.

Coverage remained the same at 99.095% when pulling 34fdd9b9537450de374c32817cfd26aec0ed45cf on tf:meta-data-items into cb4e0fac7e63d0e30b029467cd72f4ad9e59abf5 on codevise:master.


gradle release v3.4.1

To be merged after the release is complete.

The Kokoro-macos builds seem to stuck with "Queueing next build".

3.4.1 is available on https://plugins.gradle.org/plugin/com.google.cloud.tools.jib


[Jan 20] Create DynamoDB schema for GameState

WIP https://github.com/rightoneducation/righton-app/pull/85

@maniramezan posted a WIP https://github.com/rightoneducation/righton-app/pull/85


Feature/google poly

Keen for a review, but it needs a bit of UI work before we can merge it to master. I'm not sure where the google poly sidebar should display, on the left, on the right? In place or at the same time as the inspector? Maybe as a component under the inspector? I'm not sure - thoughts?

needs rebase?

I haven't seen it yet, but my uninformed intuition says if it is about adding a component, then to the left. If about editing it's properties then to the right.
Is it visible where I could see it somewhere yet?

Hey @carlfravel we need to set up feature branch to subdomain deployment before you can see how this works. It currently displays on the right in addition to the inspector, so it takes up way too much screen space. I'll try rebase it and get it displaying on the left hand side under a tab 'add poly' and post a screenshot.


change the extension name

Can one of the admins verify this patch?

@invincibleJai can you please review these changes related to 'name change for the VSCode extension'

Thanks @SriKrishnaPaparaju looks good, just one observation given in the comment.


Module Loader error

Hey, I keep running into this error whenever I attempt to build.
Any idea how to fix it?

@KenseiEmam, please try with the latest version of vue-audio-tapir. Is the error still there?


Graphics acceleration not loading with NixOS 24.05

After updating to 2024-09-03 I'm getting issues loading the mesa driver:
LIBGL_DEBUG=verbose glxinfo -B with 2024-07-31:
libGL: Can't open configuration file /etc/drirc: No such file or directory.
libGL: Can't open configuration file /home/autrimpo/.drirc: No such file or directory.
using driver asahi for 4
libGL: Can't open configuration file /etc/drirc: No such file or directory.
libGL: Can't open configuration file /home/autrimpo/.drirc: No such file or directory.
MESA-LOADER: device is not located on the PCI bus
using driver asahi for 4
MESA-LOADER: dlopen(/run/opengl-driver/lib/dri/asahi_dri.so)
libGL: Can't open configuration file /etc/drirc: No such file or directory.
libGL: Can't open configuration file /home/autrimpo/.drirc: No such file or directory.
libGL: Can't open configuration file /etc/drirc: No such file or directory.
libGL: Can't open configuration file /home/autrimpo/.drirc: No such file or directory.
libGL: Can't open configuration file /etc/drirc: No such file or directory.
libGL: Can't open configuration file /home/autrimpo/.drirc: No such file or directory.
Using DRI3 for screen 0
name of display: :0
display: :0  screen: 0
direct rendering: Yes
Extended renderer info (GLX_MESA_query_renderer):
    Vendor: Mesa (0xffffffff)
    Device: Apple M2 (G14G B0) (0xffffffff)
    Version: 24.2.0
    Accelerated: yes
    Video memory: 15678MB
    Unified memory: yes
    Preferred profile: core (0x1)
    Max core profile version: 4.6
    Max compat profile version: 4.6
    Max GLES1 profile version: 1.1
    Max GLES[23] profile version: 3.2
Memory info (GL_ATI_meminfo):
    VBO free memory - total: 15678 MB, largest block: 15678 MB
    VBO free aux. memory - total: 0 MB, largest block: 0 MB
    Texture free memory - total: 15678 MB, largest block: 15678 MB
    Texture free aux. memory - total: 0 MB, largest block: 0 MB
    Renderbuffer free memory - total: 15678 MB, largest block: 15678 MB
    Renderbuffer free aux. memory - total: 0 MB, largest block: 0 MB
Memory info (GL_NVX_gpu_memory_info):
    Dedicated video memory: 15678 MB
    Total available memory: 15678 MB
    Currently available dedicated video memory: 15678 MB
OpenGL vendor string: Mesa
OpenGL renderer string: Apple M2 (G14G B0)
OpenGL core profile version string: 4.6 (Core Profile) Mesa 24.2.0-devel
OpenGL core profile shading language version string: 4.60
OpenGL core profile context flags: (none)
OpenGL core profile profile mask: core profile

OpenGL version string: 4.6 (Compatibility Profile) Mesa 24.2.0-devel
OpenGL shading language version string: 4.60
OpenGL context flags: (none)
OpenGL profile mask: compatibility profile

OpenGL ES profile version string: OpenGL ES 3.2 Mesa 24.2.0-devel
OpenGL ES profile shading language version string: OpenGL ES GLSL ES 3.20

LIBGL_DEBUG=verbose glxinfo -B with 2024-09-03:
MESA-LOADER: dlopen(/run/opengl-driver/lib/dri/swrast_dri.so)
did not find extension DRI_Kopper version 1
libGL: Can't open configuration file /etc/drirc: No such file or directory.
libGL: Can't open configuration file /home/autrimpo/.drirc: No such file or directory.
libGL: Can't open configuration file /etc/drirc: No such file or directory.
libGL: Can't open configuration file /home/autrimpo/.drirc: No such file or directory.
did not find extension DRI2_Flush version 1
name of display: :0
display: :0  screen: 0
direct rendering: Yes
Extended renderer info (GLX_MESA_query_renderer):
    Vendor: Mesa (0xffffffff)
    Device: llvmpipe (LLVM 17.0.6, 128 bits) (0xffffffff)
    Version: 24.2.0
    Accelerated: no
    Video memory: 15679MB
    Unified memory: yes
    Preferred profile: core (0x1)
    Max core profile version: 4.5
    Max compat profile version: 4.5
    Max GLES1 profile version: 1.1
    Max GLES[23] profile version: 3.2
Memory info (GL_ATI_meminfo):
    VBO free memory - total: 0 MB, largest block: 0 MB
    VBO free aux. memory - total: 12517 MB, largest block: 12517 MB
    Texture free memory - total: 0 MB, largest block: 0 MB
    Texture free aux. memory - total: 12517 MB, largest block: 12517 MB
    Renderbuffer free memory - total: 0 MB, largest block: 0 MB
    Renderbuffer free aux. memory - total: 12517 MB, largest block: 12517 MB
Memory info (GL_NVX_gpu_memory_info):
    Dedicated video memory: 69379 MB
    Total available memory: 85058 MB
    Currently available dedicated video memory: 0 MB
OpenGL vendor string: Mesa
OpenGL renderer string: llvmpipe (LLVM 17.0.6, 128 bits)
OpenGL core profile version string: 4.5 (Core Profile) Mesa 24.2.0-devel
OpenGL core profile shading language version string: 4.50
OpenGL core profile context flags: (none)
OpenGL core profile profile mask: core profile

OpenGL version string: 4.5 (Compatibility Profile) Mesa 24.2.0-devel
OpenGL shading language version string: 4.50
OpenGL context flags: (none)
OpenGL profile mask: compatibility profile

OpenGL ES profile version string: OpenGL ES 3.2 Mesa 24.2.0-devel
OpenGL ES profile shading language version string: OpenGL ES GLSL ES 3.20

can confirm. same here

I cannot reproduce this with a M2 Max + non-homemanger hyprland. Could someone post their kernel log?

I use NixOS stable on an M1. Here is the kernel.log

I believe the issue lies in the following error: apple-dcp 38bc00000.dcp: RTKit: syslog message: PPipeDCP_H13P.cpp:11109: IOMFB updateFrequencies EDT ERROR: getClockFrequency(0) (237333328) < videoClock 402278400! Giving up on frequencies. This error points to a mismatch between getClockFrequency() and videoClock, indicating that the system is unable to properly synchronize the display frequency. The system is attempting to set a clock frequency of 237.333328 MHz, while the expected video clock is 402.278400 MHz.
I will also review my kernel log to check for any additional details.

My kernel log is different, but I am still encountering errors related to getClockFrequency(). Specifically, I find this error: PPipeDCP_H13P.cpp:11092: IOMFB updateFrequencies: minimum-frequency property not found, using getClockFrequency(0) instead. It seems to be connected to the kernel log of @jmastr.
kernel.log

Here's mine, I also see the frequency error. kernel.log

The issue does not seem to be related to getClockFrequency() as I initially thought, because it occurs in both kernels. However, when comparing the kernel logs between versions 6.9.12 and 6.10.6, the following differences emerge:

Missing initialization of the Asahi GPU in kernel 6.10.6:

In kernel 6.9.12, the Asahi GPU is detected and initialized correctly, with messages confirming the activation of the MMU and device tree configurations. An excerpt from the kernel log showing the GPU initialization in version 6.9.12:[    2.336925] asahi 206400000.gpu: MMU: initialized
[    2.336927] asahi 206400000.gpu: GPU ID registers: 0x4021100 0x40a04 0x30808 0x40404 0x1320300 0x101311
[    2.336931] asahi 206400000.gpu: GPU Information:
[    2.336932] asahi 206400000.gpu:   Type: G13G
[    2.336933] asahi 206400000.gpu:   Clusters: 1
[    2.336934] asahi 206400000.gpu:   Cores: 8 (8)
[    2.336934] asahi 206400000.gpu:   Frags: 8 (8)
[    2.336935] asahi 206400000.gpu:   GPs: 4 (4)
[    2.336936] asahi 206400000.gpu: Getting configuration from device tree...
[    2.337151] asahi 206400000.gpu: Dynamic configuration fetched

In kernel 6.10.6, there are no messages related to the Asahi GPU, indicating that the driver is not being loaded or that the GPU is not being recognized.

Initialization of the simpledrm framebuffer:

The simpledrm framebuffer is initialized correctly in both kernel versions. However, in kernel 6.10.6, it seems to be the only display-related component that is loaded, with no further initialization of the GPU.

kernel-6.9.12.log

This is my kernel.log when switching to nixos-unstable. after that GPU is working fine, which means is "just" a missing dependency on stable?

Does anyone have an idea about how to fix this dependency issue on stable 24.05?

Same thing happens to me, Hyprland doesn't launch

Do we know what packages are causing the issue? I can try various overlays in my flake if not.

Setting ```
hardware.asahi = {
useExperimentalGPUDriver = true;
};

@mogery  can't confirm. i have useExperimentalGPUDriver = true; set as well and on nixos-24.05 GPU driver does not load

@mogery I have that set aswell, still does not load

@mogery I have that set aswell, still does not load

Are you on unstable nixpkgs or 24.05? Is that + unstable a universal workaround for now?

@mogery I have that set aswell, still does not load

Are you on unstable nixpkgs or 24.05? Is that + unstable a universal workaround for now?

I'm on 24.05 with a few unstable packages

@mogery my workaround is too switch my nixos and home-manager channels to nixos-unstable resp. master, i.e.:
$ sudo nix-channel --list
apple-silicon-support https://github.com/tpwrules/nixos-apple-silicon/archive/main.tar.gz
home-manager https://github.com/nix-community/home-manager/archive/master.tar.gz
nixos https://nixos.org/channels/nixos-unstable
nixos-unstable https://nixos.org/channels/nixos-unstable

Note:
$ uname -a
Linux apple-macbook-pro 6.10.6-asahi #1-NixOS SMP PREEMPT_DYNAMIC Tue Jan  1 00:00:00 UTC 1980 aarch64 GNU/Linux

The issue probably is that NixOS 24.05 ships Rust 1.77, but kernel 6.10 requires Rust 1.78 for CONFIG_RUST. Therefore, CONFIG_RUST is disabled when building the current kernel on 24.05. This can be verified with zcat /proc/config.gz | grep CONFIG_RUST (empty with 24.05, set to yes with unstable).

 Thank you!

@lukaslihotzki You're spot on, thank you! I made a local overlay for the kernel:
(final: prev: let
  nixpkgs-asahi = import inputs.apple-silicon.inputs.nixpkgs {};
in {
  linux-asahi = nixpkgs-asahi.callPackage "${inputs.apple-silicon}/apple-silicon-support/packages/linux-asahi" { };
})

and things work fine now.

I am using nixos-unstable and when I try to use
hardware.asahi.useExperimentalGPUDriver = true;

I get the following error, have anyone else encountered this? or have any good ways of fixing it/tracking it down?
         at /nix/store/y6205wq8hxvpqvl8l9d1n9xah01kg0lq-source/pkgs/build-support/replace-dependency.nix:70:18:

           69|
           70|   dependsOnOld = drv: dependsOnOldMemo.${discard (toString drv)};
             |                  ^
           71|

       error: 'builtins.storePath' is not allowed in pure evaluation mode

       at «none»:0: (source not available)

The entire log, using `--show-trace`
```
building the system configuration...
error:
     … while calling anonymous lambda
   at /nix/store/y6205wq8hxvpqvl8l9d1n9xah01kg0lq-source/lib/attrsets.nix:1571:24:

   1570|     let f = attrPath:
   1571|       zipAttrsWith (n: values:
       |                        ^
   1572|         let here = attrPath ++ [n]; in

 … while calling anonymous lambda

   at /nix/store/y6205wq8hxvpqvl8l9d1n9xah01kg0lq-source/lib/attrsets.nix:1205:18:

   1204|         mapAttrs
   1205|           (name: value:
       |                  ^
   1206|             if isAttrs value && cond value

 … from call site

   at /nix/store/y6205wq8hxvpqvl8l9d1n9xah01kg0lq-source/lib/attrsets.nix:1208:18:

   1207|             then recurse (path ++ [ name ]) value
   1208|             else f (path ++ [ name ]) value);
       |                  ^
   1209|     in

 … while calling anonymous lambda

   at /nix/store/y6205wq8hxvpqvl8l9d1n9xah01kg0lq-source/lib/modules.nix:254:72:

    253|           # For definitions that have an associated option
    254|           declaredConfig = mapAttrsRecursiveCond (v: ! isOption v) (_: v: v.value) options;
       |                                                                        ^
    255|

 … while evaluating the option `system.build.toplevel':

 … while calling anonymous lambda

   at /nix/store/y6205wq8hxvpqvl8l9d1n9xah01kg0lq-source/lib/modules.nix:836:28:

    835|         # Process mkMerge and mkIf properties.
    836|         defs' = concatMap (m:
       |                            ^
    837|           map (value: { inherit (m) file; inherit value; }) (addErrorContext "while evaluating definitions from `${m.file}':" (dischargeProperties m.value))

 … while evaluating definitions from `/nix/store/y6205wq8hxvpqvl8l9d1n9xah01kg0lq-source/nixos/modules/system/activation/top-level.nix':

 … from call site

   at /nix/store/y6205wq8hxvpqvl8l9d1n9xah01kg0lq-source/lib/modules.nix:837:128:

    836|         defs' = concatMap (m:
    837|           map (value: { inherit (m) file; inherit value; }) (addErrorContext "while evaluating definitions from `${m.file}':" (dischargeProperties m.value))
       |                                                                                ^
    838|         ) defs;

 … while calling 'dischargeProperties'

   at /nix/store/y6205wq8hxvpqvl8l9d1n9xah01kg0lq-source/lib/modules.nix:908:25:

    907|   */
    908|   dischargeProperties = def:
       |                         ^
    909|     if def._type or "" == "merge" then

 … from call site

   at /nix/store/y6205wq8hxvpqvl8l9d1n9xah01kg0lq-source/nixos/modules/system/activation/top-level.nix:71:12:

     70|   # Replace runtime dependencies
     71|   system = foldr ({ oldDependency, newDependency }: drv:
       |            ^
     72|       pkgs.replaceDependency { inherit oldDependency newDependency drv; }

 … while calling 'foldr'

   at /nix/store/y6205wq8hxvpqvl8l9d1n9xah01kg0lq-source/lib/lists.nix:121:20:

    120|   */
    121|   foldr = op: nul: list:
       |                    ^
    122|     let

 … from call site

   at /nix/store/y6205wq8hxvpqvl8l9d1n9xah01kg0lq-source/lib/lists.nix:128:8:

    127|         else op (elemAt list n) (fold' (n + 1));
    128|     in fold' 0;
       |        ^
    129|

 … while calling 'fold''

   at /nix/store/y6205wq8hxvpqvl8l9d1n9xah01kg0lq-source/lib/lists.nix:124:15:

    123|       len = length list;
    124|       fold' = n:
       |               ^
    125|         if n == len

 … from call site

   at /nix/store/y6205wq8hxvpqvl8l9d1n9xah01kg0lq-source/lib/lists.nix:127:14:

    126|         then nul
    127|         else op (elemAt list n) (fold' (n + 1));
       |              ^
    128|     in fold' 0;

 … while calling anonymous lambda

   at /nix/store/y6205wq8hxvpqvl8l9d1n9xah01kg0lq-source/nixos/modules/system/activation/top-level.nix:71:53:

     70|   # Replace runtime dependencies
     71|   system = foldr ({ oldDependency, newDependency }: drv:
       |                                                     ^
     72|       pkgs.replaceDependency { inherit oldDependency newDependency drv; }

 … from call site

   at /nix/store/y6205wq8hxvpqvl8l9d1n9xah01kg0lq-source/lib/trivial.nix:957:7:

    956|     { # TODO: Should we add call-time "type" checking like built in?
    957|       __functor = self: f;
       |       ^
    958|       __functionArgs = args;

 … while calling anonymous lambda

   at /nix/store/y6205wq8hxvpqvl8l9d1n9xah01kg0lq-source/pkgs/build-support/replace-dependency.nix:20:1:

     19| # (and all of its dependencies) without rebuilding further.
     20| { drv, oldDependency, newDependency, verbose ? true }:
       | ^
     21|

 … while calling 'dependsOnOld'

   at /nix/store/y6205wq8hxvpqvl8l9d1n9xah01kg0lq-source/pkgs/build-support/replace-dependency.nix:70:18:

     69|
     70|   dependsOnOld = drv: dependsOnOldMemo.${discard (toString drv)};
       |                  ^
     71|

 error: 'builtins.storePath' is not allowed in pure evaluation mode

 at «none»:0: (source not available)

</details>

@dvaerum I have useExperimentalGPUDriver as true and experimentalGPUInstallMode unset and it doesn't error when I build. If you want you can post/link your config somewhere and I'll build/diff it with mine.

The issue probably is that NixOS 24.05 ships Rust 1.77, but kernel 6.10 requires Rust 1.78 for CONFIG_RUST. Therefore, CONFIG_RUST is disabled when building the current kernel on 24.05.

What if there were two linux-asahi kernel packages? One that would track the latest Asahi patches and one that would track a more stable kernel with a non-latest Asahi patchset but compatible with stable NixOS channels?
(This would tie in nicely with https://github.com/tpwrules/nixos-apple-silicon/issues/182#issuecomment-2391145199)

@dvaerum I have useExperimentalGPUDriver as true and experimentalGPUInstallMode unset and it doesn't error when I build. If you want you can post/link your config somewhere and I'll build/diff it with mine.

Are you using flakes? Because I am using flakes and the documentation said that replace (the default) does not work with flakes.

For flakes, one has to run nixos-rebuild with the --impure option to let the replace-option work properly.

Interesting @xeniagda, do you know if I can declare that inside flake as some variable? Something like
{
  flake-settings.impure = true;
  inputs = { ... };
  outputs = { ... };
}

This is likely due to NixOS stable having a too-old version of Rust.
As mentioned, stable support is on a best-effort basis. 24.11 is almost here so I do not plan to address this. If you need graphics acceleration before then, please downgrade the Apple Silicon support module.


Possible socket allocator memory leak

In the function csp_socket() of the current commit in master at the time of writing this.
A socket is allocated using the csp_conn_allocate( ). Then, if connectionless, a queue is allocated for the socket using csp_queue_create( ). If the queue failed to allocate then the function returns without freeing the socket allocation.
I'm not sure if this is the intended functionality. If it is, just delete this issue.

It seems to be a bug, as the reference to 'sock' is lost (not returned). Will look into that.

Fixed in branch release-1.5.


compact: do not delete compact dir if halt error occurs

Let's leave the compactDir if a HaltError occurs to aid in debugging
problems. Without this, it is impossible to inspect the state on disk
after a HaltError occurs.
Signed-off-by: Giedrius Statkevičius<EMAIL_ADDRESS>
[ ] I added CHANGELOG entry for this change.
[x] Change is not relevant to the end user.

Changes
Added a named return for the error in a function. Checked if it is not a halting error before trying to delete compactDir.
Verification
e2e test improvements that fail without this change.

Oops, my bad - forgot to push the latest changes. e2e tests should pass now.

lgtm; if we have halt errors then we don't really care about the compact dir growing in size since there are likely bigger problems, right?

The whole process will hang at that point. And there is a:
  935         // Clean up the compaction temporary directory at the beginning of every compaction loop.
  936         if errRemove := os.RemoveAll(c.compactDir); errRemove != nil {
  937             return errors.Wrap(errRemove, "clean up the compaction temporary directory")
  938         }

That ensures we start with a fresh directory.

hmm actually something here is a little funny.. the err variable is never actually used or set, so IsHaltError will always return false, no?

No, that's not needed - the named variables get their values according to what's after return if they have been explicitly written. For example https://play.golang.org/p/WsvFWYw1iAp.
Actually, we even have a paragraph about this in our style guide: https://thanos.io/contributing/coding-style-guide.md/#use-named-return-parameters-carefully :smile:

well, our style guide mentions named returns but says nothing of this particular language feature. In any case, this feature is news to me


Error Fixed "Failed to find Platform SDK with path: platforms;android-Q"

Hi,
Android Q issue has been fixed, please accept my pull request so the project will run correctly.
Thanks.

Now Check


Using a newer version of Gridish for experimental grid.

Some class names have been added, removed or changed in CSS Gridish, from when you guys added it behind an experimental flag.
I'd be happy to open a PR with a more recent version of Gridish, using your values. Would you guys consider generating the grid as part of your build process, or would that be a little overkill?

@joshblack Was thinking this too - although generated markdown and sketch files look like they'd be ignored from being published to NPM with your current file settings.
Our team is hoping to use CSS Gridish going forward so I could look into IBM/css-gridish#20

Closing as this is really a question / enhancement within the gridish repo.


[Team]: Informatics Infrastructure

Team
Informatics Infrastructure (ToL–IT)
Short description
The Informatics Infrastructure team provides support for the production of reference genome assemblies and large-scale genome analyses in the Tree of Life programme, and helps with the management and use of the institute's IT resources.
Long description
The Tree of Life projects will generate tens of thousands of high-quality genomes – more than have ever been sequenced! It is a challenging and extremely exciting task that will shape the future of biology, and the team’s role is to provide the platform for assembling and analysing those genomes at an unprecedented scale. We are the interface between the Tree of Life teams (assembly production and faculty research) and Sanger IT, working together with the informatics teams of the other programmes.
The team is organised in three poles.
Data management
Our data curators and managers maintain the integrity, consistency, and quality, or multiple databases used in production, including Genomes on a Tree (GoaT), Sample Tracking System (STS), Collaborative Open Plant Omics (COPO), and BioSamples.
Bioinformatics
Our bioinformaticians develop the suite of analysis pipelines that will run on every genome produced in Tree of Life, providing a central database of core results available for all.
Systems
We develop and maintain some core systems used in production, including the execution and tracking of all bioinformatics pipelines, and the deployment of third-party web applications for internal use.
Tech stack
The team uses a wide range of technologies, frameworks and programming languages, including Nextflow, Python, Conda, Jira, LSF, Singularity, and Kubernetes. The technology wheel below shows most of their logos. How many can you recognise?
tech stack image
Informatics Infrastructure Technology wheel.pdf

Current Members
Priyanka Surana (@priyanka-surana)
Matthieu Muffato (@muffato)
Beth Yates (@BethYates)
Cibele Sotero-Caio (@)
Cibin Sadasivan Baby (@cibinsb)
Guoying Qi (@gq1)
Paul Davis (@)
Which pipelines has the team contributed towards?

[X] blobtoolkit
[X] ensemblgenedownload
[X] ensemblrepeatdownload
[X] genomeassembly
[X] genomenote
[X] insdcdownload
[X] readmapping
[X] sequencecomposition
[X] treeval
[X] variantcalling

Slack
No response
Twitter
No response
Youtube
No response
Mastodon
No response
Any additional information
This is currently identical to our FRED page. Everyone please update with current relevant information. Thank you.
Code of Conduct

[X] I agree to follow this project's Code of Conduct

I have updated the content to match the page on Fred (and asked Luke to push the content of the Fred page to the Sanger website)

Updating "IDS resources" in short description to "informatics resources and digital solutions", since external audience will have no idea what IDS stands for.
Updating "IDS" in long description to "Informatics and Digital Solutions team at the Wellcome Sanger Institute".
Similarly for STS, is there a link to a landing/description page? The current link just takes the visitor to the login page and our visitors will not have access. I am removing the link for now, and keep looking for an alternative.
Updating link for "suite of analysis pipelines" to https://pipelines.tol.sanger.ac.uk/pipelines
Can you share a copy of the tech stack image in png/svg format?

Done
Done
For STS, the best description I could find is https://sangerinstitute.blog/2022/12/08/software-to-sort-samples-and-sequence-species-at-scale/
Done

Team description added.


How to use Datasette with apache webserver on GCP?

Hi Simon and Datasette team-
I have installed apache2 webserver inside GCP VM using apt.
I can see my "Hello World" index.html if I use the external IP of this GCP in a browser.
However, when I try to run datasette with different combinations of -h and -p, I am still unable to access the webpage.
I cannot invest Docker on this VM.
Any pointers to use datasette with already existing apache2 webserver on GCP is appreciated.
Thanks.

@gk7279, you had asked in a separate bug about how to redirect web servers in general.  The datasette docs actually have pretty good information on this for both nginx and apache2: https://docs.datasette.io/en/stable/deploying.html#running-datasette-behind-a-proxy

Thanks @dmick  . I chose to create a firewall rule under my GCP to open the port of interest and datasette works.


Dev

Pull Request Test Coverage Report for Build 58

7 of 7 (100.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 100.0%

Totals

Change from base Build 55:
0.0%

Covered Lines:
49

Relevant Lines:
49

💛  - Coveralls


find-moj-data test and dev environments and deployments

Split from https://github.com/ministryofjustice/find-moj-data/issues/115

Create test and preprod for find-moj-data

Creating test and preprod for find-moj-data in CP
https://github.com/ministryofjustice/cloud-platform-environments/pull/21520
https://github.com/ministryofjustice/cloud-platform-environments/pull/21521

https://github.com/ministryofjustice/cloud-platform-environments/pull/21522

there only seem to be person access tokens at the moment? if my account gets removed the link from the frontend to the backend is gone.

  createAccessToken(
    input: {
      type: PERSONAL
      actorUrn: "urn:li:corpuser:datahub"
      duration: NO_EXPIRY
      name: "find-my-data auth"
    }
  ) {
    accessToken
    metadata {
      id
      name
      description
    }
  }
}```
creates a PAT from the command line


Gather permissions from API

In GitLab by @jasonpagetas on Aug 5, 2024, 06:48
Require an API endpoint to fetch all permissions used

Require an API endpoint to fetch all permissions used

to fetch when used where?? or do you mean to show permissions available??

added 2m of time spent

@jasonpagetas, this issue was migrated from gitlab to github. During this migration you were not added as the user whom opened this issue. This message will ensure that you receive further updates on this issue as it progresses.
Further information can be found within #215


Update gulpfile to only process scss

Coverage remained the same at 93.811% when pulling 058888529e5c7e167ce81dca68aeee009c2ff63e on gulp-changes into a772dab1c7a27d907e0d0c71afde49082a83043d on master.

Coverage remained the same at 93.811% when pulling e7b95ccc8b92b2724d03af2bef82fe69167d4200 on gulp-changes into a772dab1c7a27d907e0d0c71afde49082a83043d on master.

Coverage remained the same at 93.811% when pulling fd68ad4fcc1f78281c5d0133c685d0f16b2d52b5 on gulp-changes into a772dab1c7a27d907e0d0c71afde49082a83043d on master.

Coverage remained the same at 93.811% when pulling ff6395f7d120edf3c78ab48714d5412a41bbff90 on gulp-changes into a772dab1c7a27d907e0d0c71afde49082a83043d on master.

Coverage remained the same at 93.811% when pulling ff6395f7d120edf3c78ab48714d5412a41bbff90 on gulp-changes into a772dab1c7a27d907e0d0c71afde49082a83043d on master.

lgtm, with one concern---a bunch of files were deleted and added, rather than renamed---can we just rename?

handled offline. we good

Coverage remained the same at 93.831% when pulling 12e15f061359e28a5649beb33265ecb9b88043c4 on gulp-changes into cdb16e88b69d30d9fd0821ed0f0584c334abec80 on master.


Pin github action (workflows) by commit hash

In order to continue to improve security of the organization and to improve the OSSF scorecard score we need to pin all github workflows by a commit hash (instead of version).
Motivation: Using actions by commit hash reference is a remediation for, when actions are compromised or go under a dependency confusion attack, you are not using the malicious version. This remediation along with using least privilege principle for each action in the workflow, makes it harder for a possible action hijacker to have high access to your repository.
You can read the following resources to explore the subject a bit more:

Ensure your GitHub Actions are pinned to a SHA

Example with the following PR on NodeSecure/CLI: https://github.com/NodeSecure/cli/pull/142
Repositories to asserts

[x] CLI
[ ] scanner
[ ] JS-X-Ray
[ ] i18n
[ ] vulnera
[ ] CI
[ ] ci-action
[ ] RC
[ ] flags
[ ] report
[ ] preview
[ ] domain-check
[ ] estree-ast-utils
[ ] Utils
[ ] fs-walk
[ ] github
[ ] gitlab
[ ] ossf-scorecard-sdk
[ ] npm-tarball-license-parser
[ ] licenses-conformance
[ ] size-satisfies
[ ] sec-literal
[ ] vis-network
[ ] eslint-config
[ ] npm-registry-sdk
[ ] npm-security-fetcher
[ ] documentation-ui
[ ] authors
[ ] eslint-config

Feel free to help and open a pull-request

Note: https://app.stepsecurity.io/ is able to open pull request for us on the subject (testing it).