<HttpError 400 when requesting https://www.goo gleapis.com/gmail/v1/users/me/messages/import?alt=json&neverMarkSpam=true&fields =id returned "Invalid From header">

I received this error after a couple hundred emails had already been restored.:
Using backup folder C:\Users\John\Documents\Johns_Gmail_Backup
restoring 10 messages (10/39719)
Traceback (most recent call last):
File "", line 1491, in
File "", line 1112, in main
File "C:\Users\jlee\Documents\GitHub\got-your-back\oauth2client\util.py", line
137, in positional_wrapper
File "C:\Users\jlee\Documents\GitHub\got-your-back\googleapiclient\http.py", l
ine 1378, in execute
File "", line 794, in restored_message
File "C:\Users\jlee\Documents\GitHub\got-your-back\googleapiclient\http.py", l
ine 1372, in execute
googleapiclient.errors.HttpError: <HttpError 400 when requesting https://www.goo
gleapis.com/gmail/v1/users/me/messages/import?alt=json&neverMarkSpam=true&fields
=id returned "Invalid From header">

Getting this error everytime i run gyb.  Any idea on why? Anyone?

This error implies the message you backed up has an invalid From header.
You can try adding:
--fast-restore
to your GYB command and those messages should succeed however messages
restored with fast restore are neither threaded into conversations nor
de-duplicated.
A future version of GYB will skip over these failures instead of erroring
out.
Jay
On Sep 7, 2015 2:17 PM, "jschafer72"<EMAIL_ADDRESS>wrote:

Getting this error everytime i run gyb. Any idea on why? Anyone?
—
Reply to this email directly or view it on GitHub
https://github.com/jay0lee/got-your-back/issues/61#issuecomment-138351641
.

Thanks!

I received this error as well.
Looked for the erroring file which turns out to have had a hard wrap in the "From:" (as the error message indicated) i.e.:
From: "=?utf-8?Q?Augsburg=20Student=20Financial=20Services?=" <studentfinances
@augsburg.edu>
The hard wrap appears to have come from the export process (also GYB). Is it possible that the Google API introduces the wrap? or the possibly the excessive long name is not account for on the file write?

I'm in the same boat with the 400 error.  Any idea when the future version will be released?

I ran into this as well, and in my case, my errors were due to invalid email addresses in the 'From' field.  These were messages that were created via an SMS backup app, and had put some messages with a from field in the form of 'myname' instead of<EMAIL_ADDRESS> A few 'find' and 'sed' commands to adjust the malformed email addresses in my backup did the trick for me.

I get this error every time.  I dont want to particularly use fast-restore, as I would like the messages to remain threaded, and de-duped.
I wish I had the skill to contribute to the code, and fix this.

@maltokyo, are you able to identify which emails are causing the error?  If we can examine the emails, it is my experience that the problematic emails can be adjusted.  Personally, I dropped in a little code that caught this particular error and then spit out the problematic emails to a log file so I could review them individually afterwards and fix those specific ones.

I'm having this problem too and I don't know what email is causing it. Is there any easy way to make the skipping happen in this version of the code?

This is fixed in the latest GYB release.

Thanks @jay0lee! Update 0.43 is a win!


Access Lists not working.

Checklist

Have you pulled and found the error with jc21/nginx-proxy-manager:latest docker image?
Yes
Are you sure you're not using someone else's docker image?
Yes
If having problems with Lets Encrypt, have you made absolutely sure your site is accessible from outside of your network?
N/A

Describe the bug
V2.30
Just to start! NPM is awesome! I love that little to no maintenance needs to go into setting up my proxies. Thank you for all your hard work!
When trying to add access rules it does not seem to apply it to the Ngnix config. I am trying to allow only my local subnet to get access to a certain page.
To Reproduce
Steps to reproduce the behavior:
Add ip or ip range to access list.
I do not add anyone in for authorization.
Save.
I then add the access rule to a new proxy that I setup. I am using Lets Encrypt to get the certificate.
Expected behavior
I expect to be able to access my page from the IPs specified. I keep getting 403 on the pages. I checked the conf file for the proxy and there seems to be nothing added under the section where access list is commented. All that is there is the default deny all rule.
Operating System
Ubuntu Server 18.04 VM
Thank you in advance.

Can you try 2.3.1 or 2 or latest docker tags please

That did it. Didn't see there was a new version posted! Thank you very much!

Hi, i have the same problem with V2.9.15. If i use any access List the Password never works. eg. I create Access Lsit with Name =test, User=Test pw= Test. If i try to enter the page i will ask for User and PW. If i user Test/Test i get the responde {
"message": "invalid username or password"
}


Example Settings File

Hi
Using the example settings file gives the following error:
Warning: Parse error in settings file.  EndOfFileExpected at position 28
Error in settings: object expected at $settings
It appears to be missing a set of {} around the contents of the file.
Regards
Richard

Hi Richard, we haven't been able to reproduce this. Example-Settings.json does already have brackets around the contents. Please give us a full stack trace and the full steps to reproduce the issue. Thanks.


CUDA Indexing Assertion Failure in Transformer Decoder

During the training of a Transformer-based neural machine translation bilingual model, a CUDA assertion failure is occurring in the indexing operation. See error here
Here is my config file:
## IO
save_data: processed_data/
overwrite: True
seed: 1234
report_every: 100
valid_metrics: ["BLEU"]

### Vocab
src_vocab: processed_data/spm_src_8000_bpe.onmt_vocab
tgt_vocab: processed_data/spm_tgt_9000_bpe.onmt_vocab
share_vocab: false
#n_sample: -1

data:
    corpus_1:
        path_src: data/src-train.txt
        src_lang: fr
        path_tgt: data/tgt-train.txt
        tgt_lang: ty
    valid:
        path_src: data/FR-val.txt
        src_lang: fr
        path_tgt: data/TY-val.txt
        tgt_lang: ty
        #transforms: [onmt_tokenize]

transforms: [normalize, sentencepiece, filtertoolong]
transforms_configs:
  normalize:
    norm_quote_commas: true
    norm_numbers: true
  sentencepiece:
    #src_subword_type: sentencepiece
    src_subword_model: "processed_data/spm_src_8000_bpe.model"
    #tgt_subword_type: sentencepiece
    tgt_subword_model: "processed_data/spm_tgt_9000_bpe.model"
  #filtertoolong:
    #src_seq_length: 100
    #tgt_seq_length: 100

#dump_samples: true
#n_samples: 1000

# Number of candidates for SentencePiece sampling
#subword_nbest: 20
# Smoothing parameter for SentencePiece sampling
#subword_alpha: 0.1

training:
    # Run configuration
    model_path: models
    keep_checkpoint: 70
    save_checkpoint_steps: 1000
    train_steps: 70000
    valid_steps: 500
    #train_from: models/step_60000

    # Train on a single GPU
    world_size: 1
    gpu_ranks: [0]

    # batching
    batch_type: "tokens"
    batch_size: 1024
    valid_batch_size: 1024
    batch_size_multiple: 1
    accum_count: [10]
    accum_steps: [0]

    # Optimizer & Compute
    compute_dtype: "fp16"
    optim: "adam"
    #self_attn_backend: "pytorch"
    learning_rate: 1.5
    average_decay: 0.1
    #warmup_steps: 4000
    decay_method: "noam"
    adam_beta2: 0.998

    # Data loading
    bucket_size: 1024
    num_workers: 4
    prefetch_factor: 50

    # Hyperparams
    dropout_steps: [0]
    dropout: [0.1]
    attention_dropout: [0.1]
    max_grad_norm: 0
    label_smoothing: 0.1
    #param_init: 0
    param_init_method: "xavier_uniform"
    normalization: "tokens"

    #early_stopping: 3

tensorboard: true
tensorboard_log_dir: logs
log_file: logs/eole.log

# Pretrained embeddings configuration for the source language
embeddings_type: word2vec
#src_embeddings: data/en.wiki.bpe.vs25000.d300.w2v.txt
#pre_word_vecs_enc: data/en.wiki.bpe.vs25000.d300.w2v.txt
#tgt_embeddings:

model:
    architecture: "transformer"
    hidden_size: 512
    share_decoder_embeddings: false
    share_embeddings: true
    layers: 6
    heads: 8
    transformer_ff: 512
    embeddings:
        word_vec_size: 512
        position_encoding_type: "SinusoidalInterleaved"
        #position_encoding: true

The same config file used to work fine, until the system threw the error. I updated Eole to the latest version. I made a clean reinstall of CUDA 11.5, Nvidia Driver 555.42.06, CUDA Toolkit, etc. I deleted long sentences and now my longest line is 85 tokens for the source, and 73 tokens for the target. I even doubled my EBS storage but the issue is still breaking the training process.

This seems like more of an issue with your setup than with eole per se.
These errors/warnings look weird:
2024-11-20 06:28:55.193090: I tensorflow/core/util/port.cc:153] oneDNN custom operations are on. You may see slightly different numerical results due to floating-point round-off errors from different computation orders. To turn them off, set the environment variable `TF_ENABLE_ONEDNN_OPTS=0`.
2024-11-20 06:28:55.208500: E external/local_xla/xla/stream_executor/cuda/cuda_fft.cc:477] Unable to register cuFFT factory: Attempting to register factory for plugin cuFFT when one has already been registered
WARNING: All log messages before absl::InitializeLog() is called are written to STDERR
E0000 00:00:1732084135.225895    5808 cuda_dnn.cc:8310] Unable to register cuDNN factory: Attempting to register factory for plugin cuDNN when one has already been registered
E0000 00:00:1732084135.231025    5808 cuda_blas.cc:1418] Unable to register cuBLAS factory: Attempting to register factory for plugin cuBLAS when one has already been registered
2024-11-20 06:28:55.247740: I tensorflow/core/platform/cpu_feature_guard.cc:210] This TensorFlow binary is optimized to use available CPU instructions in performance-critical operations.
To enable the following instructions: AVX2 AVX512F AVX512_VNNI FMA, in other operations, rebuild TensorFlow with the appropriate compiler flags.

Maybe you want to fall back to some sample workloads to make sure your CUDA setup is fine.
Also, it is not super clear what changed between the time when it "used to work fine", and now.

Hi Francois, for several weeks now Iʻve conducted many experiments without a problem. I didnʻt update any of the software at all. I just refined my datasets and experimented with various hyperparameters. All of a sudden, those errors popped in. So I started troubleshooting, first inspecting my data for super long sentences, then I tried fiddling with the hyperparameters, and then I reinstalled CUDA 11.5, Nvidia Driver 555.42.06, CUDA Toolkit, pulled the latest Eole code and doubled my EBS storage. To no avail. I donʻt know what to do. What do you mean by some sample workload? Itʻs hard for me to think smaller datasets will clear these issues when my larger datasets worked fine for several weeks.

I would start with some very naive approaches like described here -- https://chatgpt.com/share/673df6c4-4e94-8003-9e95-70acd3c606a0

So, after multiple tests on the datasets, I am finally able to get my fr-ty training running. It turned out that share_embeddings is the culprit. I changed from true to false and now the model is able to train. Why is that? Why does share_embeddings set to true work for english to tahitian but not for french to tahitian?

That's a weird one indeed. Maybe there is an edge case in the fr-ty vocabulary which is not in the en-ty vocab.


Big Changes!!!!

Attempt to do https://github.com/openaps/docs/pull/36 properly

+1 after @channemann fixes the minor things I said verbally.


Empty array returned on iOS 13

The following method in iOS 13 returns an empty array.
ContactsService.getContacts()
In iOS 13, developers are unable to access the notes portion of contacts. I was thinking that this could be the cause of the problem.

@uohziyoam what was the reason for referencing issue #5 ?

@darrylong what are the results you get when you run the example app included in the example/ folder?

@lukasgit no result.

Start example app
Showing permission request
I'm allow
Empty page
Add contact button is work, contacts creating, page is empty.

Can I collect some more data for you?

@olegkrutskih recent updates were pushed just now. Please try again and let me know if things are working for you now. Thanks!

@olegkrutskih recent updates were pushed just now. Please try again and let me know if things are working for you now. Thanks!

Super!
It works!

Flutter (Channel stable, v1.9.1+hotfix.2)
worked!  0.3.4 confirmed!

Have exact same problem using a real device.
Using example I'm getting an empty array of contacts.
It works using Android and iOS Simulator.
iOS 13
[✓] Flutter (Channel stable, v1.9.1+hotfix.2, on Mac OS X 10.14.6 18G95, locale en-US)
[✓] Android toolchain - develop for Android devices (Android SDK version 28.0.3)
[✓] Xcode - develop for iOS and macOS (Xcode 11.0)
[✓] Android Studio (version 3.5)
[✓] VS Code (version 1.38.1)
[✓] Connected device (1 available)

Hello @lukasgit is there any way we can get the 'note', while creating or updating the contact. Earlier we were using note in 0.2.8 but its no longer available now.

@kroksys and @sivanookalatt Apple recently announced iOS 13 will no longer support access to the Notes field:
https://techcrunch.com/2019/06/05/with-ios-13-apple-locks-out-apps-from-accessing-users-private-notes-in-contacts/

@olegkrutskih and @dvlj ... great to hear it's working for you now!

@lukasgit no result.

Start example app
Showing permission request
I'm allow
Empty page
Add contact button is work, contacts creating, page is empty.

Can I collect some more data for you?

i have same problem in version 0.4.6


'istioctl version' should write to stdout, not stderr

Alternate fix for the bug I introduced writing CLI version output to stderr.
The reason for the change was to be able to use Cobra's capture facility for unit tests.
Unfortunately I used the variant that writes to stderr instead of the variant that writes to stdout and supports the Cobra capture facility.

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: esnible
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: nmittler
Assign the PR to them by writing /assign @nmittler in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

pkg/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: esnible, hklai
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

pkg/OWNERS [hklai]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


zen-observable-ts broken import

Before opening, please confirm:

[X] I have checked to see if my question is addressed in the FAQ.
[X] I have searched for duplicate or closed issues.
[X] I have read the guide for submitting bug reports.
[X] I have done my best to include a minimal, self-contained set of instructions for consistently reproducing the issue.

App Id
arn:aws:amplify:us-west-2:220927856021:apps/d2hxpiwsgtlb15
Region
us-west-2
Amplify Console feature
Build settings
Describe the bug
I receive this error when trying to deploy my app with amplify-aws api included. Fixing this file locally by using "{ Observable }" solves the issue but I cannot make changes to this file when building on the server.
`2021-09-09T18:57:21.046Z` [WARNING]: Error: node_modules/@aws-amplify/api/lib-esm/API.d.ts:2:8 - error TS2613: Module '"/codebuild/output/src167203613/src/black-dashboard-angular-master/node_modules/zen-observable-ts/index"' has no default export. Did you mean to use 'import { Observable } from "/codebuild/output/src167203613/src/black-dashboard-angular-master/node_modules/zen-observable-ts/index"' instead?
                                    2 import Observable from 'zen-observable-ts';

Expected behavior
Build successful
Reproduction steps
deploy from master branch
Build Settings
No response
Additional information
No response

Hi  :wave:, thanks for raising. I'm going to transfer to the JS repo to get some more eyes on it.
Do you mind providing a bit more information about your app? Mainly, any frameworks/versions/code snippets that may help :)


Error spam when adjusting a CollisionShape's position (Godot physics with BVH)

Godot version:
3.2.4.beta a329de566c109557d6b3b
The bisect points to #45154, but I assume that was hiding the real culprit: #44901.
OS/device including version:
Ubuntu 20.10
Issue description:
In Godot physics, with the new BVH partitioning, when adjusting a CollisionShape's position, the project freezes with an error spam.
ERROR: set_axis_angle: The axis Vector3 must be normalized.
   At: core/math/basis.cpp:980.
ERROR: instance_set_transform: Condition "Math::is_nan(v.x)" is true.
   At: servers/visual/visual_server_scene.cpp:699.
ERROR: instance_set_transform: Condition "Math::is_nan(v.x)" is true.
   At: servers/visual/visual_server_scene.cpp:699.

Steps to reproduce:
I'm not sure exactly, but it happens when running the attached MRP.
Minimal reproduction project:
BVHBug.zip

Ok I'll take a look. :+1:
In the meantime, you can switch back to old behaviour with physics->3d->godot_physics->use_bvh set to off.

Ok I'll take a look. :+1:
In the meantime, you can switch back to old behaviour with physics->3d->godot_physics->use_bvh set to off.

It seems like the problem is caused by the same CollisionObjectSW being added to the BVH twice.
In the BVH these are being registered as 2 objects with the same userdata pointer, and it calls the pairing callback indicating that they have collided with themselves. This is pretty much correct behaviour from the BVH, though I can easily put in a check and prevent callbacks being called for pairs with the same userdata.
Maybe there is some code in the octree (and bullet?) that prevents pairing between objects with the same userdata. I will investigate and see whether the same double add is occurring with octree.

It seems like the problem is caused by the same CollisionObjectSW being added to the BVH twice.
In the BVH these are being registered as 2 objects with the same userdata pointer, and it calls the pairing callback indicating that they have collided with themselves. This is pretty much correct behaviour from the BVH, though I can easily put in a check and prevent callbacks being called for pairs with the same userdata.
Maybe there is some code in the octree (and bullet?) that prevents pairing between objects with the same userdata. I will investigate and see whether the same double add is occurring with octree.

The octree is only adding once. I suspect it may be a simple explanation, that the client code is assuming that 0 ID means the BVH object is unset, whereas actually it is a valid BVH ID. I had to use plus 1 IDs for the rendering, I can easily change this for the physics too. :+1:

The octree is only adding once. I suspect it may be a simple explanation, that the client code is assuming that 0 ID means the BVH object is unset, whereas actually it is a valid BVH ID. I had to use plus 1 IDs for the rendering, I can easily change this for the physics too. :+1:

Fixed by #45184.

Fixed by #45184.


Per-point colors in point clouds

🎉 New feature

Part of https://github.com/ignitionrobotics/ign-gazebo/issues/1156
Needed by https://github.com/ignitionrobotics/ign-gui/pull/318

Summary

We have been populating the colors vector in Ogre2DynamicRenderable, but not using the colors for anything.
For most dynamic renderables, we fill the vertex buffer with position and normal. But points don't have normals, so we've been leaving half the buffer empty. The implementation on this PR takes advantage of those empty slots to place per-point colors (only RGB, no A).
Thanks @WilliamLewww for helping me out with this!
Test it

The marker example on https://github.com/ignitionrobotics/ign-gui/pull/318 uses this:

Checklist

[x] Signed all commits for DCO
[ ] Added tests
[ ] Added example and/or tutorial
[x] Updated documentation (as needed)
[x] Updated migration guide (as needed)
[x] codecheck passed (See contributing)
[ ] All tests passed (See test coverage)
[x] While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge
🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸

works for me. I made some changes in the iche033/6/marker_point_color branch for Metal. I don't have a working mac setup to test it though.
Using the normal buffer is fine. I know that in ogre 1.x, you can create vertex element of type VES_DIFFUSE to store colors per vertex (e.g. in place of VES_NORMAL if operationType is point list) but I couldn't find examples that does it in ogre 2.x so not sure how well it's working. Otherwise, that would probably be a more semantically correct way to pass colors to shaders.

I made some changes in the iche033/6/marker_point_color branch for Metal.

Thanks! Merged in.

FYI, I rebased this PR to Garden (main), because downstream PRs have breaking changes that need to target Garden. If there's a need to backport this to Fortress later I can open a separate PR.


fix: don't run beforeAll/afterAll in skipped block

Summary
Fixes #6755
Fixes #8379
Test plan
e2e/__tests__/skipBeforeAfterAll.test.ts corresponds to #8379 example. I checked it failed on previous revision.

Nice and clean, thanks! This is missing a file to actually run the e2e test you've added. Something like https://github.com/facebook/jest/blob/7a7710d2c9cdc7da97a3674c36f1ca46f7068f78/e2e/tests/importedGlobals.test.ts

Codecov Report

Merging #9931 into master will not change coverage.
The diff coverage is 0.00%.

@@           Coverage Diff           @@
##           master    #9931   +/-   ##
=======================================
  Coverage   64.23%   64.23%
=======================================
  Files         292      292
  Lines       12466    12466
  Branches     3075     3076    +1
=======================================
  Hits         8007     8007
  Misses       3810     3810
  Partials      649      649

Impacted Files
Coverage Δ

packages/jest-jasmine2/src/treeProcessor.ts
0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ad1b9dc...77f975d. Read the comment docs.

Looks good, thanks @jeiea! Just missing a test file so the new e2e test actually runs.

Thanks!


docs: clarify namespace in ABNF

i found the docs confusing.
in the current ABNF it reads
property-name = 1*(namespace ":") name
; ...

the problem i saw: the namespace is used multiple time, so if i registered a namespace, how would i use it multiple times?
Here is a fix.

i found the docs confusing.
in the current ABNF it reads
property-name = 1*(namespace ":") name
; ...

the problem i saw: the namespace is used multiple time, so if i registered a namespace, how would i use it multiple times?
Here is a fix.

Maybe it should be reworded instead? Instead of namespace maybe namespace-segment? The current syntax is to differentiate between namespaces, sub-namespaces, and the name of the property within the namespace. Thoughts?

re: https://github.com/CycloneDX/cyclonedx-property-taxonomy/pull/48#issuecomment-1483692202
then why not call these things exctly like that?
property-name =  name
property-name =/ namespace ":" 1*(sub-namespace ":") name

namespace = 1*namechar
sub-namespaces = 1*namechar
name = 1*namechar

; ...


Await example in tutorial.ipynb does not work as expected

The bug
In the example,
# sometimes you want to partially execute a program, the `await` command allows you to do this
# it awaits a variable and then consumes that variables (so after the await command the variable)
prompt = guidance('''Generate a response to the following email:
{{email}}.
Response:{{gen "response"}}
{{await 'instruction'}}
{{gen 'updated_response'}}''', stream=True)

# note how the executed program is only partially executed, it stops at the await command
# because the instruction variable is not yet set
prompt = prompt(email='Hello there')

the user is supposed to continue running by supplying instruction. However, the prompt here is a python generator (<generator object Program._stream_run at 0x7fee2191d190>), which cannot run
----> 1 prompt2 = prompt(instruction='Please translate the response above to Portuguese.')
      2 prompt2

TypeError: 'generator' object is not callable

To Reproduce
Please see above
please see above

System info (please complete the following information):

OS: MacOS
Guidance Version 0.0.63

Yes, Facing same issue in this tutorial.

same

Same here.
Workaround: change parameter stream to false.
prompt1 = guidance('''Generate a response to the following email: {{email}}. Response:{{gen "response"}} {{await 'instruction'}} {{gen 'updated_response'}}''', stream=False)

We did away with await in the new release, where everything is much simpler by virtue of being pure python. Sorry we took so long to get to this! :)


Refactor: Implementing EditorController

Implemented 4/4 functions in editor_controller.js.
Also:

Rearranged some functions in toolbox_controller.js for readability.
Implemented one or two functions that were closely linked to functions in EditorController.
Moved some functions from EditorController to ToolboxController and WorkspaceController.

This change is

src/view/workspace_editor_view.js, line 118 at r1 (raw file):

     * TODO: Move in from wfactory_view.js:setBaseOptions()
     */
    throw 'Unimplemented: initBaseConfigs()';

Nit; throw is for initBaseConfigs

Comments from Reviewable

Review status: 0 of 7 files reviewed at latest revision, 1 unresolved discussion.

src/view/workspace_editor_view.js, line 118 at r1 (raw file):
Previously, svouse wrote…
Nit; throw is for initBaseConfigs

Done.

Comments from Reviewable

LGTM.
Note: There are some chunks of code that are moving around but don't seem to be changing.  It makes the diff a bit hard to read.

Reviewed 4 of 5 files at r1, 3 of 3 files at r2.
Review status: all files reviewed at latest revision, 1 unresolved discussion.

Comments from Reviewable

Noted, I'll make code-rearrangements into separate PR's (which I think will happen because some of the files are hard to read and some functions could be grouped by functionality).

You can also just leave a note that says "I moved this function from here to here but didn't change it" if it's just a few that you moved on the way.

Review status: all files reviewed at latest revision, 1 unresolved discussion.

Comments from Reviewable


Add feature to close TMScope inspector

It resolves #19675.

@rokoroku,
Thanks for having already signed the Contribution License Agreement. Your agreement was validated by Microsoft. We will now review your pull request.
Thanks,
Microsoft Pull Request Bot

Would love to see this in the next release ❤

Thank you for your contribution! :heart:


[MM-14529] Show channel name in post input placeholder

Summary
Displays title of channel in post input placeholder similar to other messaging apps. Original PR included other features which will be split into another PR.
Ticket Link
This was submitted originally for the MatterCon 2019 Hackathon.
https://mattermost.atlassian.net/browse/MM-14529
Checklist

[x] Ran make check-style to check for style errors (required for all pull requests)
[x] Ran make test to ensure unit and component tests passed
[x] Added or updated unit tests (required for all new features)
[x] Includes text changes and localization file (.../i18n/en.json) updates
[x] Touches critical sections of the codebase (auth, posting, etc.)

@esethna I've submitted this draft PR, the decision about "~" and "@" prefixes notwithstanding.

Setup Test Server label detected. Spinmint test server created if build succeeds (checks pass and no conflicts with base branch).

Spinmint test server created at: https://i-0bfc7f13a4d7da9b2.test.spinmint.com
Test Admin Account: Username: sysadmin | Password: sysadmin
Test User Account: Username: user-1 | Password: user-1
Instance ID: i-0bfc7f13a4d7da9b2

Spinmint test running for more than 7 days. This test server was terminated.

Spinmint test server destroyed

Setup Test Server label detected. Spinmint test server created if build succeeds (checks pass and no conflicts with base branch).

Spinmint test server created at: https://i-098b7fe6fddb27dd7.test.spinmint.com
Test Admin Account: Username: sysadmin | Password: sysadmin
Test User Account: Username: user-1 | Password: user-1
Instance ID: i-098b7fe6fddb27dd7

Thanks @michaelgamble , I'll open for dev review!

Spinmint test server destroyed

Spinmint test running for more than 7 days. This test server was terminated.


Move documentation drom codeplex to github Wiki

Hello based on https://blogs.msdn.microsoft.com/bharry/2017/03/31/shutting-down-codeplex/ can you transfer project documentation from codeplex to this project wiki?
"  In October, we’ll set CodePlex to read-only, before shutting it down completely on December 15th, 2017."
Thx

Hello @pokornyIt ,
The documentation is now online here: http://entityframework-effort.net/
We will soon fully re-write it with some online example on https://dotnetfiddle.net/
Best Regards,
Jonathan


Introduce LightBlock support for MockContext

Overview
Closes #389
Description
This PR introduces two important changes:
1. Module mock_context.rs was expanded
This module was broken down into two separate modules: context.rs with an implementation of MockContext
https://github.com/informalsystems/ibc-rs/blob/110a3d81dc811820a73879fe43ce8a384f435c4a/modules/src/mock/context.rs#L31
and host.rs with various host chain-specific types, e.g., HostBlock
https://github.com/informalsystems/ibc-rs/blob/b9b4667699a2b7f3b2e95d1421389fea800b93c0/modules/src/mock/host.rs#L30-L33
Note that two types of blocks are now possible: mocks or synthetically generated Tendermint blocks (based on testgen).
2. The ibc crate now exports a mocks feature
https://github.com/informalsystems/ibc-rs/blob/b9b4667699a2b7f3b2e95d1421389fea800b93c0/modules/Cargo.toml#L17-L20
This feature grants the relayer access to mock structures, so the relayer can build an in-process mock chain based on MockContext.

For contributor use:

[X] Updated the Unreleased section of CHANGELOG.md with the issue.
[ ] If applicable: Unit tests written, added test to CI.
[X] Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
[ ] Updated relevant documentation (docs/) and code comments.
[ ] Re-reviewed Files changed in the Github PR explorer.

Codecov Report

Merging #390 (f18e4b2) into master (b1b37f5) will increase coverage by 21.1%.
The diff coverage is 64.8%.

@@            Coverage Diff            @@
##           master    #390      +/-   ##
=========================================
+ Coverage    13.6%   34.8%   +21.1%
=========================================
  Files          69     145      +76
  Lines        3752    9183    +5431
  Branches     1374    3108    +1734
=========================================
+ Hits          513    3201    +2688
- Misses       2618    5738    +3120
+ Partials      621     244     -377

Impacted Files
Coverage Δ

modules/src/events.rs
0.0% <0.0%> (ø)

modules/src/ics02_client/events.rs
0.0% <ø> (ø)

modules/src/ics02_client/msgs.rs
0.0% <0.0%> (ø)

modules/src/ics02_client/raw.rs
0.0% <0.0%> (ø)

modules/src/ics03_connection/error.rs
13.6% <0.0%> (-19.7%)
:arrow_down:

modules/src/ics04_channel/error.rs
75.0% <ø> (+50.0%)
:arrow_up:

modules/src/ics04_channel/packet.rs
0.0% <0.0%> (ø)

modules/src/ics07_tendermint/client_def.rs
0.0% <0.0%> (ø)

modules/src/ics07_tendermint/error.rs
75.0% <ø> (+75.0%)
:arrow_up:

modules/src/ics18_relayer/error.rs
0.0% <0.0%> (ø)

... and 268 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 24db51d...4d5b108. Read the comment docs.


implement PyBuilder access to git describe

This implements access to git describe with some useful options. Usually, it looks for available git tags (tag objects), but there are some fall-backs that are activated to make it more robust.

--allways: Show uniquely abbreviated commit object as fallback.
--tags: Instead of using only the annotated tags, use any tag found in refs/tags namespace. This option enables matching a lightweight (non-annotated) tag.
--dirty:            Describe the working tree. It means describe HEAD and appends --dirty if the working tree is dirty.

So, for example, while developing this feature, I get the following: v0.11.10-30-g8bec37a30b-dirty.
This means: when descending the git DAG the first that was found was v0.11.10, this commit is 30 commits ahead of that tag, g means this is the git version control system, 8bec37a30b is the abbreviated commit ID (hash) of the commit and finally --dirty means the working directory was "dirty" (had un-staged, but not necessarily un-commited) changes.
I would like to have this merged, because we are looking to move away from continuous versioning (counting git commits using count) for one project because it has become so significant for us that we will move to semantic versioning. However, we would like to use git tags to set the version number and we want our build system to embrace that scheme. Using description allows us to do exactly that. If we are exactly on tag 23.42.666, then the project version will be precisely that and will be reflected when we upload the project to our internal PyPi like repository. During development, on branches etc.., we get a nice human readable version number that allows us to pinpoint where that version might have come from.
For more details please see the manpage for git describe.

I am willing to backport this to the v0.11 branch and add documentation to solve #551 when this is merged.

Coverage decreased (-0.2%) to 74.856% when pulling 4ffa50496483d33200731b483364eb9b9c146b14 on esc:esc/feature/git_describe into 854c6851e43f52dd053130cf98022176dc59beab on pybuilder:master.

@esc please backport this as well if there is demand


mixup with sderr and stdout

I get the below error; Expected onBeforeMountComponent() parent and onSetChildren() to be consistent. according to https://github.com/facebook/react/issues/8692 This will be a non issue in React 16. I'm using Enzyme for this test suite, so I can't upgrade to the latest React Native untile Enzyme supports React 16.
I wanted to suppress the error for now, and I noticed something strange:
The test results get posted to stderr instead of stdout and when I turn on verbose logging it get even stranger, stdout gets the errors and most of what I would expect in stdout gets logged to stderr?
(the failing test and console log are on purpose)
The full output of my test:
$ npm test -- --coverage

> App@ test /media/dev/app
> jest "--coverage"

 FAIL  core/tests/components/settings.js
  ● Console

    console.error node_modules/react-native/Libraries/Core/ExceptionsManager.js:71
      Warning: ReactTestUtils has been moved to react-dom/test-utils. Update references to remove this warning.
    console.error node_modules/react-native/Libraries/Core/ExceptionsManager.js:71
      Warning: Exception thrown by hook while handling onSetChildren: Invariant Violation: Expected onBeforeMountComponent() parent and onSetChildren() to be consistent (7 has parents 0 and 5).
      Invariant Violation: Expected onBeforeMountComponent() parent and onSetChildren() to be consistent (7 has parents 0 and 5).
          at invariant (/media/dj/dev/scan-app/node_modules/fbjs/lib/invariant.js:44:15)
          at Object.onSetChildren (/media/dj/dev/scan-app/node_modules/react/lib/ReactComponentTreeHook.js:186:78)
          at callHook (/media/dj/dev/scan-app/node_modules/react-test-renderer/lib/ReactDebugTool.js:27:8)
          at emitEvent (/media/dj/dev/scan-app/node_modules/react-test-renderer/lib/ReactDebugTool.js:39:7)
          at Object.onSetChildren (/media/dj/dev/scan-app/node_modules/react-test-renderer/lib/ReactDebugTool.js:311:5)
          at ReactTestComponent.setChildrenForInstrumentation (/media/dj/dev/scan-app/node_modules/react-test-renderer/lib/ReactMultiChild.js:157:38)
          at ReactTestComponent._updateChildren (/media/dj/dev/scan-app/node_modules/react-test-renderer/lib/ReactMultiChild.js:360:39)
          at ReactTestComponent.updateChildren (/media/dj/dev/scan-app/node_modules/react-test-renderer/lib/ReactMultiChild.js:299:12)
          at ReactTestComponent.receiveComponent (/media/dj/dev/scan-app/node_modules/react-test-renderer/lib/ReactTestRenderer.js:68:10)
          at Object.receiveComponent (/media/dj/dev/scan-app/node_modules/react-test-renderer/lib/ReactReconciler.js:125:22)
    console.log core/tests/components/settings.js:97
      [ 1, 3, 2 ]

  ● settings functions work as expected › Settings.getAllSelected(product) works as expected

    expect(received).toEqual(expected)

    Expected value to equal:
      false
    Received:
      true

      at Object.<anonymous> (core/tests/components/settings.js:99:35)

 PASS  src/tests/view-test.js
 PASS  core/tests/components/details.js
 PASS  core/tests/components/scan.js
 PASS  core/tests/components/search.js
 PASS  core/tests/components/login.js
 PASS  core/tests/helpers/collections.js
 PASS  core/tests/helpers/search-guests.js
 PASS  core/tests/helpers/urls-dev.js
 PASS  core/tests/components/init.js
 PASS  core/tests/helpers/urls-prod.js

=============================== Coverage summary ===============================
Statements   : 43.59% ( 558/1280 )
Branches     : 33.72% ( 175/519 )
Functions    : 50% ( 227/454 )
Lines        : 49.26% ( 467/948 )
================================================================================

Test Suites: 1 failed, 10 passed, 11 total
Tests:       1 failed, 1 skipped, 34 passed, 36 total
Snapshots:   13 passed, 13 total
Time:        5.437s
Ran all test suites.
npm ERR! Test failed.  See above for more details.

only stdout:
$ npm test -- --coverage 2>/dev/null

> App@ test /media/dev/app
> jest "--coverage"

Determining test suites to run...
=============================== Coverage summary ===============================
Statements   : 43.59% ( 558/1280 )
Branches     : 33.72% ( 175/519 )
Functions    : 50% ( 227/454 )
Lines        : 49.26% ( 467/948 )
================================================================================

only stderr:
$ npm test -- --coverage 1>/dev/null
 FAIL  core/tests/components/settings.js
  ● Console

    console.error node_modules/react-native/Libraries/Core/ExceptionsManager.js:71
      Warning: ReactTestUtils has been moved to react-dom/test-utils. Update references to remove this warning.
    console.error node_modules/react-native/Libraries/Core/ExceptionsManager.js:71
      Warning: Exception thrown by hook while handling onSetChildren: Invariant Violation: Expected onBeforeMountComponent() parent and onSetChildren() to be consistent (7 has parents 0 and 5).
      Invariant Violation: Expected onBeforeMountComponent() parent and onSetChildren() to be consistent (7 has parents 0 and 5).
          at invariant (/media/dj/dev/scan-app/node_modules/fbjs/lib/invariant.js:44:15)
          at Object.onSetChildren (/media/dj/dev/scan-app/node_modules/react/lib/ReactComponentTreeHook.js:186:78)
          at callHook (/media/dj/dev/scan-app/node_modules/react-test-renderer/lib/ReactDebugTool.js:27:8)
          at emitEvent (/media/dj/dev/scan-app/node_modules/react-test-renderer/lib/ReactDebugTool.js:39:7)
          at Object.onSetChildren (/media/dj/dev/scan-app/node_modules/react-test-renderer/lib/ReactDebugTool.js:311:5)
          at ReactTestComponent.setChildrenForInstrumentation (/media/dj/dev/scan-app/node_modules/react-test-renderer/lib/ReactMultiChild.js:157:38)
          at ReactTestComponent._updateChildren (/media/dj/dev/scan-app/node_modules/react-test-renderer/lib/ReactMultiChild.js:360:39)
          at ReactTestComponent.updateChildren (/media/dj/dev/scan-app/node_modules/react-test-renderer/lib/ReactMultiChild.js:299:12)
          at ReactTestComponent.receiveComponent (/media/dj/dev/scan-app/node_modules/react-test-renderer/lib/ReactTestRenderer.js:68:10)
          at Object.receiveComponent (/media/dj/dev/scan-app/node_modules/react-test-renderer/lib/ReactReconciler.js:125:22)
    console.log core/tests/components/settings.js:97
      [ 1, 3, 2 ]

  ● settings functions work as expected › Settings.getAllSelected(product) works as expected

    expect(received).toEqual(expected)

    Expected value to equal:
      false
    Received:
      true

      at Object.<anonymous> (core/tests/components/settings.js:99:35)

 PASS  src/tests/view-test.js
 PASS  core/tests/components/search.js
 PASS  core/tests/components/details.js
 PASS  core/tests/components/scan.js
 PASS  core/tests/components/login.js
 PASS  core/tests/helpers/collections.js
 PASS  core/tests/helpers/search-guests.js
 PASS  core/tests/helpers/urls-dev.js
 PASS  core/tests/components/init.js
 PASS  core/tests/helpers/urls-prod.js

Test Suites: 1 failed, 10 passed, 11 total
Tests:       1 failed, 1 skipped, 34 passed, 36 total
Snapshots:   13 passed, 13 total
Time:        5.985s
Ran all test suites.
npm ERR! Test failed.  See above for more details.

even more strange, when I turn on verbose the error gets logged to stdout..
 $ npm test -- --coverage --verbose 2>/dev/null

> Chipta@ test /media/dj/dev/scan-app
> jest "--coverage" "--verbose"

  console.error node_modules/react-native/Libraries/Core/ExceptionsManager.js:71
    Warning: ReactTestUtils has been moved to react-dom/test-utils. Update references to remove this warning.

  console.error node_modules/react-native/Libraries/Core/ExceptionsManager.js:71
    Warning: Exception thrown by hook while handling onSetChildren: Invariant Violation: Expected onBeforeMountComponent() parent and onSetChildren() to be consistent (7 has parents 0 and 5).
    Invariant Violation: Expected onBeforeMountComponent() parent and onSetChildren() to be consistent (7 has parents 0 and 5).
        at invariant (/media/dj/dev/scan-app/node_modules/fbjs/lib/invariant.js:44:15)
        at Object.onSetChildren (/media/dj/dev/scan-app/node_modules/react/lib/ReactComponentTreeHook.js:186:78)
        at callHook (/media/dj/dev/scan-app/node_modules/react-test-renderer/lib/ReactDebugTool.js:27:8)
        at emitEvent (/media/dj/dev/scan-app/node_modules/react-test-renderer/lib/ReactDebugTool.js:39:7)
        at Object.onSetChildren (/media/dj/dev/scan-app/node_modules/react-test-renderer/lib/ReactDebugTool.js:311:5)
        at ReactTestComponent.setChildrenForInstrumentation (/media/dj/dev/scan-app/node_modules/react-test-renderer/lib/ReactMultiChild.js:157:38)
        at ReactTestComponent._updateChildren (/media/dj/dev/scan-app/node_modules/react-test-renderer/lib/ReactMultiChild.js:360:39)
        at ReactTestComponent.updateChildren (/media/dj/dev/scan-app/node_modules/react-test-renderer/lib/ReactMultiChild.js:299:12)
        at ReactTestComponent.receiveComponent (/media/dj/dev/scan-app/node_modules/react-test-renderer/lib/ReactTestRenderer.js:68:10)
        at Object.receiveComponent (/media/dj/dev/scan-app/node_modules/react-test-renderer/lib/ReactReconciler.js:125:22)

  console.log core/tests/components/settings.js:97
    [ 1, 3, 2 ]

=============================== Coverage summary ===============================
Statements   : 43.59% ( 558/1280 )
Branches     : 33.72% ( 175/519 )
Functions    : 50% ( 227/454 )
Lines        : 49.26% ( 467/948 )
================================================================================

$ npm test -- --coverage --verbose 1>/dev/null
 FAIL  core/tests/components/settings.js
  ● settings functions work as expected › Settings.getAllSelected(product) works as expected

    expect(received).toEqual(expected)

    Expected value to equal:
      false
    Received:
      true

      at Object.<anonymous> (core/tests/components/settings.js:99:35)

  Settings renders correctly
    ✓ without event (32ms)
    ✓ with event (30ms)
  settings functions work as expected
    ✓ Settings.selectEventProduct(product) adds product as expected (22ms)
    ✓ Settings.selectEventProduct(product) removes product as expected (18ms)
    ✓ Settings.getSelected(product) works as expected (9ms)
    ✕ Settings.getAllSelected(product) works as expected (28ms)
    ✓ Settings.selectAll() works as expected (20ms)
    ○ skipped 1 test

 PASS  src/tests/view-test.js
  ✓ LoginView renders correctly (39ms)
  ✓ SettingsView renders correctly (10ms)
  ✓ DrawerView renders correctly (65ms)
  ✓ ScanView renders correctly (4ms)
  ✓ ResultView renders correctly (17ms)
  ✓ DetailsView renders correctly (19ms)

 PASS  core/tests/components/details.js
  ✓ Details renderers correctly (47ms)

 PASS  core/tests/components/scan.js
  ✓ Scan renderers correctly (22ms)

 PASS  core/tests/components/login.js
  ✓ Login renders correctly (19ms)

 PASS  core/tests/components/search.js
  ✓ Search renderers correctly (14ms)

 PASS  core/tests/helpers/collections.js
  models are created as expected
    ✓ event is created properly (2ms)
    ✓ guest is created properly (1ms)
    ✓ event product is created properly
    ✓ guest product is created properly (1ms)
  guest functions work as expected
    ✓ guest.getFullName() returns full name of user (1ms)
    ✓ guest.getFullName() returns email of guest if no name is found (1ms)
    ✓ guest.getTotals() returns [used products, total products] (2ms)
  guest product functions work as expected
    ✓ guestProduct.isValid() checks if the product is valid (1ms)
    ✓ guestProduct.confirm(eventId, status) sets last use time on product (3ms)

 PASS  core/tests/helpers/search-guests.js
  searchGuests works as expected
    ✓ searchGuests works as expected without searchTerm (1ms)
    ✓ searchGuests works as expected with name (3ms)
    ✓ searchGuests works as expected with barcode (2ms)

 PASS  core/tests/helpers/urls-dev.js
  ✓ makeGuestProductUrl works as expected
  URLconfig is correct for dev
    ✓ ajaxURL
    ✓ socketURL (1ms)

 PASS  core/tests/components/init.js
  ✓ Init renders correctly (5ms)

 PASS  core/tests/helpers/urls-prod.js
  URLconfig is correct for prod
    ✓ ajaxURL
    ✓ socketURL

Test Suites: 1 failed, 10 passed, 11 total
Tests:       1 failed, 1 skipped, 34 passed, 36 total
Snapshots:   13 passed, 13 total
Time:        5.485s
Ran all test suites.
npm ERR! Test failed.  See above for more details.

This is how it works in Jest and it's not a bug.

pass or fail is not error, it is expected output.
error is error, not expected output.
I can only find it strange.
Is there documentation on this I could read?


NO-JIRA: Add static.Logger() so new code can use non-static patterns.

Add static.Logger() so that the static logger can be passed as an argument.
Allows old code using the static log pattern to be extended with new code using log argument passing.

I'm not sure if we should add this, need to think about this a bit.
In a pinch you can already use the return value of V(0) to get a copy of the static logger instance.

/close
static.V(0) is equivalent to the proposed static.Logger() so no need for this.


Spc branch

done did,
is compatible with Biotech
should be compatible with Children, school & learning

Sorry for the wait, and thanks for the help!
Updated in 4602b09


Suggestion: Add names to buffers

Currently Buffers show up with no name. It would be real cool if they said "no-neck-pain"

Thanks for testing the plugin!

It would be real cool if they said "no-neck-pain"
Make sense! Sadly we can't have multiple buffers with the same name but I could append -left and -right

Linking https://github.com/shortcuts/no-neck-pain.nvim/issues/15 for visibility, which aims at make side buffers configurable

Side note: side buffers are not even on your screenshot, is it because it's cropped or they were not the same size?

Oh, my screen is super wide so I just cropped the relevant stuff. Yes, they are even.

Works great!


DO NOT MERGE: ci: use self-hosted runners for some jobs

Just a test to see impact

Not worth it in this structure, box is OOM fast and jobs are killed. Also only scales to 2 jobs per box, not fast.


How to change size for icon

Hi adm,
I want size up large icon. How to?
Thanks !

You want to have the icons a little bit bigger? I'm afraid, but this is not possible with our implementation... You may want to suggest that change at vscode's repo and link it here, so we can track the status, too.

The icons have a fixed size of 32x32 in Zoom 0 mode. You can increase/decrease the size by zooming in and out (Ctrl - -, Ctrl - +, or navigate to View).

The icons have a fixed size of 32x32 px in Zoom 0 mode. You can increase/decrease the size by zooming in and out (Ctrl - -, Ctrl - +, or navigate to View).

I need icon size change option. Only icon and folder icon size NOT ZOOM.

Same here.

I too would like to see larger icons.
Compare VSCode to Atom, the icons in Atom are much clearer, while VS Code has a lot of wasted space around them:

It's 2020 and we still need larger icons.  Please implement?  Thanks!

This is out of scope for this extension, it requires VSCode official Team to tackle down things like this.

No problem, thanks.  I was just hopeful.  I even considered going to look
see if I could program it myself, but I've not contributed to open source
yet, so I wouldn't be entirely sure what I was looking for.
On Fri, Feb 28, 2020 at 9:49 PM Manuel Bojato<EMAIL_ADDRESS>wrote:

This is out of scope for this extension, it requires VSCode official Team
to tackle down things like this.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/vscode-icons/vscode-icons/issues/1070?email_source=notifications&email_token=AIK4W2Y2TNLXGMHDEKCZMJDRFGBFHA5CNFSM4DTDTQI2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOENKJBQA#issuecomment-592744640,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AIK4W27H2FDP6SRCWEQC2LLRFGBFHANCNFSM4DTDTQIQ
.

You can use zoom and adjust the editor font size

The icons have a fixed size of 32x32 px in Zoom 0 mode. You can increase/decrease the size by zooming in and out (Ctrl - -, Ctrl - +, or navigate to View).

Man you saved my morning! For some reason the zoom was if below 0 and they was really small!!!!!
Ctrl ++ solve the problem!

Try "window.zoomLevel": 0.3,:

I created a feature request for vscode, track it at microsoft/vscode#129771

Please refer this answer: https://stackoverflow.com/a/73754045/12804254

use mac: cmd + +  , in win: ctrl ++ to change icons size ; font size it would be  changed also in editor , so you need to change font size , just go to settings the chose Text Editor then change the font size

It's 2020 and we still need larger icons. Please implement? Thanks!

It's 2024 and still no news


pydantic object init() function call revealed in fastAPI type_error payload

First Check

[X] I added a very descriptive title to this issue.
[X] I used the GitHub search to find a similar issue and didn't find it.
[X] I searched the FastAPI documentation, with the integrated search.
[X] I already searched in Google "How to X in FastAPI" and didn't find any information.
[X] I already read and followed all the tutorial in the docs and didn't find an answer.
[X] I already checked if it is not related to FastAPI but to Pydantic.
[X] I already checked if it is not related to FastAPI but to Swagger UI.
[X] I already checked if it is not related to FastAPI but to ReDoc.

Commit to Help

[X] I commit to help with one of those options 👆

Example Code
from fastapi import FastAPI
import pydantic

app = FastAPI()

@pydantic.dataclasses.dataclass
class TestPayload:
    message: str = dataclasses.field(
        metadata={"description": "test message"}
    )

@app.put('/test_endpoint')
def create(test_payload: TestPayload) -> TestPayload:
    return test_payload

payload = {"false_key": "test message"}

app.put("/test_endpoint",
        json=payload,
      )

Description
Hi,
When trying to use a pydantic model as a parameter for an endpoint, if this said payload isn't matching the pydantic model defined, with, in this case, a wrong key, fastAPI will return an error payload as follows:
# fastAPI error payload returned
{
'loc': ('body',),
'msg': "TestPayload.__init__() got an unexpected keyword argument 'false_key'",
'type': 'type_error'
}

The error message reveals that .init() is called from the pydantic object, and this kind of message is not quiet what an API user would like to see following a key error.
The question then being, Is it the good behavior following those kind of errors ? Is it ok to reveal this kind of call information ?
May be it is a bug, or an error that isn't correctly catched on the server side
Operating System
macOS
Operating System Details
No response
FastAPI Version
0.74.1
Python Version
Python 3.10.2
Additional Context
No response

If you ask me pydantic dataclass is not directly related to FastAPI's API. I mean when you pass {"false_key": "test message"}, it will be interpreted like def __init__(message: str) by dataclass. So, in your example, you are simply passing like as follows.
test_payload = TestPayload(false_key="test message")

This means you are passing an argument with the wrong name to the initialization method.

The issue here is that FastAPI returns a different error if pydantic.dataclasses is used instead pydantic.BaseModel.
pydantic.BaseModel returns:
[
     {'loc': ['body', 'reason'], 'msg': 'field required', 'type': 'value_error.missing'}
]

while dataclasses variante returns:
[{
    'loc': ('body',),
    'msg': "TestPayload.__init__() got an unexpected keyword argument 'false_key'",
    'type': 'type_error'
}]

The dataclasses versions leak implementation details, which is a bug for me as dataclasses variant is officially supported: https://fastapi.tiangolo.com/advanced/dataclasses/


Swipe not working properly.

Hello,
i managed to install it finally on my TX Ultimate 3 relay.
The issues i have noticed so far is that if i swipe left or right.... the sensors don't get updated and they stay ON.
the worst issue with it is that if i touch the switch and try to swipe... the relays always activate.
so if relay 1 turns the light on.... and swipe up opens the cover....
when i try to open the cover, the light also turns on.
so the event of the relay action must only happen on the release and not press

so the event of the relay action must only happen on the release and not press

Good point... I will look at that.

I believe this is fixed in dev. I will move it to main later today.
Could you please give it a try and let me know?

I'm reopening this as I could see the issue persists.

any luck with this?

I have some ideas for this, but couldn't work with this project recently. The latest ESPHome came with some break changes that got my attention, now I'm getting prepared to move to a new house...
But I will try to look at thin in the coming days.

the latest ESPHome broke your house and now you need to move to a new one? i should stay away from that update then.
but no worries :) let me know when you have time again. enjoy your new home

Hi Edward,
did you find time to check this out?
@edwardtfn

I couldn't work at this yet, but I promise to do it later this week.
Sorry for that.

I've finally assembled by device back, but could run only very limited tests.
Could you please give it a try and let me know the results?

this is not fixed. if you try to slide...
the first button that you touch while going to slide... it gets activated

Could you please try again? 😬

Hi, on a 3 gang US model swiping up or down appears as swipe left or right on the logs, therefore the corresponding sensors never turn on

Well, technically, the US model is a portrait like device... When you rotate it to be landscape, the device isn't aware of that, so, from the point of view of the device, you are swiping to the side.
If that is an issue for you, please add a feature request for a "US landscaped" mode, but I'm not gonna make any promises here, as covering all the possible positions on both models will be a nightmare.
What I can do (in fact this was already started) is moving all those strings to substitutions, so you can set it yourself in your local yaml and it will use the labels you want.

What I meant to say is that the swipe actions don´t appear to do anything, either in HA or in the web page of the device. Since I saw the id definitions for all swipe directions on TX-Ultimate-Easy-ESPHome_core_hw_touch.yaml I thought that the swipe events were mapped differently for the EU and US versions with the recent update

Got it!
Let's work with this in the new issue:

#51
I will try to work at this later today.


Transient initial state with lazily initiated context causes two child actor spawns

Bug or feature request?
Bug.
Description:
When a parent machine spawns a child actor in a lazily initialized context (  context: () => ({ child: spawn(child, "child") })), and there is a transient initial state, the parent spawns two child actors: one referenced in the context, and one referenced in it's children property. Without the transient initial state, a single actor is spawned as expected.
(Bug) Expected result:
A single child actor is spawned, with references in the children and context properties pointing to the same instance.
(Bug) Actual result:
Two child actors are spawned, one referenced in the children property and the other referenced in the context property.
(Bug) Potential fix:
The issue appears to lie in the interpreter's handling of the transient initial state. On the initial service.start() call, in var resolvedState = initialState === undefined ? this.initialState ... this.initalState has a spawned child in context, but an empty children property. I'm not sure where this.initialState is defined.
Link to reproduction or proof-of-concept:
Codesandbox reproduction: https://codesandbox.io/s/brave-chihiro-6p0jy

Would you be able to test out if this gets fixed with the patch from this PR?
Even if it doesn't get fixed with that - we were just talking today with David about refactoring the code around initial actors and this work has been planned for the next two weeks. This should resolve issues like this holistically.

This patch doesn't quite fix it. Initial state now has a child actor referenced in children, and one in context, but they are different instances still. This isn't a blocker for me, so I can wait for the refactor.
The reason this popped up is because invoked actors can be referenced on the children property, but aren't in context. If you want to invoke a sibling child actor B and pass it the reference to child actor A through the data property, you don't have access to the children map, only context and event. So I tried spawning child actor A rather than invoking, so it could be referenced in context, and passed to child actor B.

This no longer happens in the latest version of XState: https://codesandbox.io/s/modern-shape-1hrgp2?file=/src/index.js


How to RUN Joomla 3 in Jphp??

Hi,
I am new to JPHP, anyone here had successfully ran Joomla/SugarCRM/Drupal using JPHP?
https://www.joomla.org/download.html
If yes, kindly shown the how to or provide an example for such.

Just implements the missing features (functions) of php core.
P.S. Zend core api (https://github.com/jphp-compiler/jphp/tree/master/jphp-zend-ext) is deprecated now. Its a new language.

jphp and php not compatible. Better compare jphp with java

See here: http://j-php.net/faq/

Another missing the mark project. No wonder the adoption rate is so low. The above mentioned projects are majority codes in the php community.


swapped danger and warning colours

As discussed in #82 , the Dashing-derived application.scss had amber for danger and red for warning statuses, which is really just wrong by most conventions.
This just simply swaps them.

Coverage remained the same at 87.162% when pulling eaa9074404b5b64e40bdb538b6abb2e521cf1da9 on mackenza:switch-status-colours into ad560015d71a904d57ced912e54b333f1e743e95 on kittoframework:master.

Thanks @mackenza makes more sense like this.


[All Hosts] (dialog) support cross-domain messaging

Docs Build status updates of commit 3f9ccfa:
:warning: Validation status: warnings

File
Status
Preview URL
Details

docs/develop/dialog-handle-errors-events.md
:warning:Warning
View
Details

docs/reference/requirement-sets/dialog-origin-requirement-sets.md
:bulb:Suggestion
View
Details

docs/develop/auth-with-office-dialog-api.md
:white_check_mark:Succeeded
View

docs/develop/dialog-api-in-office-add-ins.md
:white_check_mark:Succeeded
View

docs/develop/dialog-best-practices.md
:white_check_mark:Succeeded
View

docs/reference/requirement-sets/office-add-in-requirement-sets.md
:white_check_mark:Succeeded
View

docs/toc.yml
:white_check_mark:Succeeded
View

docs/develop/dialog-handle-errors-events.md

Line 33, Column 337: [Warning-bookmark-not-found] Cannot find bookmark '#send-information-from-the-dialog-box-to-the-host-page' in 'develop/dialog-api-in-office-add-ins.md'.

docs/reference/requirement-sets/dialog-origin-requirement-sets.md

Line 3, Column 14: [Suggestion-duplicate-descriptions] Attribute 'description' with value 'Learn more about the Dialog API requirement sets.' is duplicated in 'reference/requirement-sets/dialog-api-requirement-sets.md(3,14)', 'reference/requirement-sets/dialog-origin-requirement-sets.md(3,14)'.

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Docs Build status updates of commit cdf098f:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/develop/auth-with-office-dialog-api.md
:white_check_mark:Succeeded
View

docs/develop/dialog-api-in-office-add-ins.md
:white_check_mark:Succeeded
View

docs/develop/dialog-best-practices.md
:white_check_mark:Succeeded
View

docs/reference/requirement-sets/dialog-origin-requirement-sets.md
:white_check_mark:Succeeded
View

docs/reference/requirement-sets/office-add-in-requirement-sets.md
:white_check_mark:Succeeded
View

docs/toc.yml
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Docs Build status updates of commit 61449fc:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/develop/dialog-api-in-office-add-ins.md
:bulb:Suggestion
View
Details

docs/develop/auth-with-office-dialog-api.md
:white_check_mark:Succeeded
View

docs/develop/dialog-best-practices.md
:white_check_mark:Succeeded
View

docs/reference/requirement-sets/dialog-origin-requirement-sets.md
:white_check_mark:Succeeded
View

docs/reference/requirement-sets/office-add-in-requirement-sets.md
:white_check_mark:Succeeded
View

docs/toc.yml
:white_check_mark:Succeeded
View

docs/develop/dialog-api-in-office-add-ins.md

Line 349, Column 1: [Suggestion-sensitive-language-wl] Term 'whitelist' is sensitive and should not be used in content or code. Usage: 'For example, your code could store a whitelist of domains in a variable in the [Office.onReady or Office.initialize methods](initialize-add-in.md)'

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Docs Build status updates of commit 7092dac:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/develop/dialog-api-in-office-add-ins.md
:bulb:Suggestion
View
Details

docs/develop/auth-with-office-dialog-api.md
:white_check_mark:Succeeded
View

docs/develop/dialog-best-practices.md
:white_check_mark:Succeeded
View

docs/reference/requirement-sets/dialog-origin-requirement-sets.md
:white_check_mark:Succeeded
View

docs/reference/requirement-sets/office-add-in-requirement-sets.md
:white_check_mark:Succeeded
View

docs/toc.yml
:white_check_mark:Succeeded
View

docs/develop/dialog-api-in-office-add-ins.md

Line 349, Column 1: [Suggestion-sensitive-language-wl] Term 'whitelist' is sensitive and should not be used in content or code. Usage: 'For example, your code could store a whitelist of domains in a variable in the [Office.onReady or Office.initialize methods](initialize-add-in.md)'

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Docs Build status updates of commit c1a7e88:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/develop/auth-with-office-dialog-api.md
:white_check_mark:Succeeded
View

docs/develop/dialog-api-in-office-add-ins.md
:white_check_mark:Succeeded
View

docs/develop/dialog-best-practices.md
:white_check_mark:Succeeded
View

docs/reference/requirement-sets/dialog-origin-requirement-sets.md
:white_check_mark:Succeeded
View

docs/reference/requirement-sets/office-add-in-requirement-sets.md
:white_check_mark:Succeeded
View

docs/toc.yml
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel


Create Method with persist option, relaton data is disappear

Describe the bug
Hello ,
when create data with relation (PersistOptions)
relation data is disappear
Steps to reproduce the bug
1. Define models [...]
import { Model } from '@vuex-orm/core'

class Seat extends Model {
  static entity = 'seat'
  static primaryKey = '_id'

  static fields = () => {
    return {
      _id: this.attr(null),
      name: this.attr(null),
    }
  }
}

class Order extends Model {
  static entity = 'order'
  static primaryKey = '_id'

  static fields = () => {
    return {
      _id: this.attr(null),
      seat_id: this.attr(null),
      seat: this.belongsTo(Seat, 'seat_id'),
    }
  }
}

2. Create data & Retrieve data
Seat.create({ data: [
  {_id: 1, name: 'Table 1'},
  {_id: 2, name: 'Table 2'},
  {_id: 3, name: 'Table 3'},
});

// results of Seat.query().get()
Seat {$id: "1", _id: "1", name: "Table 1",}
Seat {$id: "2", _id: "2", name: "Table 2",}
Seat {$id: "3", _id: "3", name: "Table 3",}

Found Problem
Order.create({
  data: [{_id: 100, name:"Test Order", seat_id:2, seat: { _id: 2, name:" Table 2"}}],
  insertOrUpdate: ['seat']
})

// results of Seat.query().get()
Seat {$id: "2", _id: "2", name: "Table 2",}
problem: data miss Table 1 and Table 3

Order.create({
  data: [{_id: 100, name:"Test Order", seat_id:4, seat: { _id: 4, name:" Table 4"}}],
  insert: ['seat']
})

// results of Seat.query().get()
Seat {$id: "4", _id: "4", name: "Table 4",}
problem: data miss Table 1-3

Thank you.
Versions

Vuex ORM: 0.36.3
Vue: 2.6.11

Additional context
I thank  can add "excludes" option to PersistOptions
if you don't need create, insert, update to relation is better
however if relation hasMany with persist option is work,

This is very weird. I'm not sure the timeline here. So you do call Seat.create first, then calling Order.create? It would be nice if you can provide some working code example for this one.

Hello @kiaking
i found this problem with  plugin-axios
when data have been response order with seat
seat relation is disappear.
export default class Order extends Model {
  static entity = 'order'
  static primaryKey = '_id'

  static fields = () => {
    return {
      _id: this.attr(null),
      seat_id: this.attr(null),
      seat: this.belongsTo(Seat, 'seat_id'),
    }
  }
}

Create Seat Data
Seat.create({ data: [
  {_id: 1, name: 'Table 1'},
  {_id: 2, name: 'Table 2'},
  {_id: 3, name: 'Table 3'},
});

Call Order API
Order.api().post('/api/fetch', {}, {
  persistBy:'create',
  persistOptions: [{ insertOrUpdate: 'seat' }]
})

response example.
[{_id: 100, name:"Test Order", seat_id:2, seat: { _id: 2, name:" Table 2"}}],
Result of Seat.query().get()
Seat {$id: "2", _id: "2", name: "Table 2",}
result miss Table 1-3
I found this problem with belongsTo.
Thank you.

@mean-cj persistOptions expects an object, as per docs. So your create persistence is being applied to both model and relations.
This: persistOptions: [{ insertOrUpdate: ['seat'] }]
Should be: persistOptions: { insertOrUpdate: ['seat'] }

Hello @cuebit
I will check my code is ok , i'm sorry invalid code with my example,
Please check persist not work with belongsTo relation is miss
i think this bug on vuex-orm
Example
Seat.create({ data: [
  {_id: 1, name: 'Table 1'},
  {_id: 2, name: 'Table 2'},
  {_id: 3, name: 'Table 3'},
});

Order.create({
  data: [{_id: 100, name:"Test Order", seat_id:2, seat: { _id: 2, name:" Table 2"}}],
  insertOrUpdate: ['seat']
})

Same problem with
Order.api().post('/api/fetch', {}, {
  persistBy:'create',
  persistOptions: { insertOrUpdate: ['seat'] }
})

Result of Seat.query().get()
Seat {$id: "2", _id: "2", name: "Table 2",}
Miss Table 1 and Table 3

Sorry @mean-cj, I'm unable to reproduce. Doesn't seem like a bug to me.
See reproduction using your code. Am I missing something?

Hello @cuebit
Thank you so much for help
I fork and test your code
now i found bug , when i use underscore (_) on entity
Please follow
https://wncpu.csb.app/
https://codesandbox.io/s/wncpu

@mean-cj ahh I see now. This is still not a bug. You need to provide the entity name and not the field name for the relation you wish to control. It is documented here.
{
  data: [...],
  insertOrUpdate: ['merchant_seat']
}

Ohhhh my god, i'm apologise.
I'm misunderstand persist option for enter the field name.
Why we don't enter relation field name on persist option?
i think it make sense better than enter entity name.
@cuebit  thank you so much : )

The entity name is required because the model handles persistence. So you’re instructing your entity, or model, to persist using insertOrUpdate. The field just forms part of the entity schema.
Hope that helps.

I think this issue has been solved? Please feel free to open another issue if there's anything 👍


Enhancement of Arrays class

I think we should implement four more methods in our Arrays class
1. Remove duplicate
there should be method namely removeDuplicates() which remove duplicate records in array consider following data set
        $dataSet = [
            'users' =>
            [
                'id' => 1,
                'name' => "Umer",
                'username' => 'peter',
            ],
            [
                'id' => 2,
                'name' => "Peter Khot",
                'username' => 'peter',
            ]
        ];

Look at above problem set and see the username become duplicate, we don't think how it happen, but there should be way/method which remove duplicate by specific key pair.
2. Pluck
To retrieves all of the values for a given key from an array
Consider following dataset
        $array = [
            ['developer' => ['id' => 1, 'name' => 'Umer']],
            ['developer' => ['id' => 2, 'name' => 'Peter']],
        ];

if we do something following  Arr:ays:pluck($array, 'developer.name'); it should return both name.
3. Most Occurring
Like anyone wants return most occuring name from array so there should be method that works with every datatype to get most occurring values.
consider the following dataset
        $dataSet = [
            'users' =>
            [
                'id' => 1,
                'name' => "Umer",
                'username' => 'peter',
            ],
            [
                'id' => 2,
                'name' => "Umer",
                'username' => 'umer01'
            ],
            [
                'id' => 3,
                'name' => "Peter Khot",
                'username' => 'peter',
            ]
        ];

so if we wants most occuring name it should return Umer [It should works with every data type even with bool]
4 Least Occurring
Like anyone wants return least occuring name from array so there should be method that works with every datatype to get most occurring values.
consider the following dataset
        $dataSet = [
            'users' =>
            [
                'id' => 1,
                'name' => "Umer",
                'username' => 'peter',
            ],
            [
                'id' => 2,
                'name' => "Umer",
                'username' => 'umer01'
            ],
            [
                'id' => 3,
                'name' => "Peter Khot",
                'username' => 'peter',
            ]
        ];

so if we wants least occuring name it should return Peter Khot [It should works with every data type even with bool]
Here above all are real world problem sets
What do you think @peter279k  and @Maikuolan

Now last method is left still
2. Pluck
To retrieves all of the values for a given key from an array
Consider following dataset
        $array = [
            ['developer' => ['id' => 1, 'name' => 'Umer']],
            ['developer' => ['id' => 2, 'name' => 'Peter']],
        ];

if we do something following  Arr:ays:pluck($array, 'developer.name'); it should return both name.

Please consider about the array_column function.
https://www.php.net/manual/en/function.array-column.php
Muhammad Umer Farooq<EMAIL_ADDRESS>於 2019年5月13日 週一 下午5:12 寫道：

Now last method is left still
2. Pluck
To retrieves all of the values for a given key from an array
Consider following dataset
    $array = [            ['developer' => ['id' => 1, 'name' => 'Umer']],            ['developer' => ['id' => 2, 'name' => 'Peter']],        ];

if we do something following Arr:ays:pluck($array, 'developer.name'); it
should return both name.
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub
https://github.com/zestframework/Zest_Framework/issues/223#issuecomment-491742493,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ACE2SMZCIEJW2GDXVFMW5F3PVEWJVANCNFSM4HJ5X6SA
.

@peter279k  i tried following code

    public static function pluck(array $array, $key, $opr = '.')
    {
        if (self::isMulti($array)) {
            $dataSet = [];
            foreach (explode($opr, $key) as $k) {
                print_r($k);
                    $dataSet = array_column($array, $k);
                    //$dataSet = $array[$k];
                    print_r($dataSet);
            }

            return $dataSet;
        }

        throw new \InvalidArgumentException("The array given should be multi-dimensional array", 500);

    }

Usage
        $array = [
            ['developer' => ['id' => 1, 'name' => 'Alex']],
            ['developer' => ['id' => 2, 'name' => 'Peter']],
        ];
        $arrTest = [1,2,3,1,4,6];
        echo "

Most Occuring

";
        //print_r($dataSet);
        print_r(Arrays::pluck($array, 'developer.id'));
        echo "
";

Output

Expexted output you already knows that discussed aboved
help to resolve this case.

 $array = [
            ['developer' => ['id' => 1, 'name' => 'Alex']],
            ['developer' => ['id' => 2, 'name' => 'Peter']],
        ];

The array_column is only worked on the following array:
$array = [
    ['id' => 1, 'name' => 'Alex'],
    ['id' => 2, 'name' => 'Peter'],
];

If we want to accept the array you specify, It's not good enough to use array_column.
My approach is as follows:

Firstly, check the specific key is mapped to the value array.
Second, if it's array, the next specific key is in the array column, collect it.

@peter279k  Thanks for your reply, i have found another good solution, this is required only last key which we want to search here in above case is id or name let me add that code in PR


How to choose power to calculate distance

Hello,
I have found that the time of flight is using to calculate the distance between the anchor and TAG. But an i use signal strength to calculate the distance? Please refer the attached peace of code.
computeRangeAsymmetric(myDistantDevice, &myTOF);

Maybe you can use the signal strength/power, but this library do not use it.


✨[feature Request]: Signup page UI does not matches with the Login page UI

Description
Related Issues

Closes #548

Type of PR

[ ] ()

Screenshots / videos (if applicable)
Before :

After :

Same UI as Login Page

Checklist

[x] I have gone through the contributing guide
[x] I have updated my branch and synced it with project main branch before making this PR
[x] I have performed a self-review of my code
[x] I have tested the changes thoroughly before submitting this pull request.
[x] I have provided relevant issue numbers, screenshots, and videos after making the changes.
[x] I have commented my code, particularly in hard-to-understand areas.

Additional context:

@Anjaliavv51 I've made the changes you can review it, in the new code i have deleted login page and register page css and combined them together in a new css file

@amitroy-thedev u need to make login same as signup

make the login, signup and google buttons pink?

@amitroy-thedev yes

@Anjaliavv51 Done

@Anjaliavv51 I've made the changes would you review and merge it

@Anjaliavv51 I've made the changes would you review and merge it


[epic] Flowershow website v0.2

Acceptance

[ ] #65 ✅ 2022-07-28 #74
[ ] Nicer version of the benefits section ✅ 2022-07-27 #73
[ ] ...

@rufuspollock, since both features/roadmap and benefits sections on the front page are done, I guess the last thing we would want to improve would be a nicer version of the features/roadmap section (conversion from simple md to some fancy html elements) ?

I think for now we leave and focus on prepping the announce post and adding features.


Server Profile task creation is aborting

I'm trying to create multiple server profiles at once and do not want to wait for each task to complete so I'm adding a timeout of 5 seconds to server_profiles create. However, after the 5 seconds is reached, the task is aborted. This is what I'm reading in the server_profile create usage for the timeout:
timeout: Timeout in seconds. Wait for task completion by default. The timeout does not abort the operation in OneView, just stop waiting for its completion.
but this is what I'm seeing when trying to create a profile with the 5 second timeout:
2017-06-01 06:27:10,110 ERROR    hpOneView    Waited 5 seconds for task to complete, aborting when creating server profile Encl4, bay 10 Compliant Profile KZPKYJ
It looks like the task_monitor __wait_task_completion is aborting the task after the timeout.
Am I reading the timeout usage incorrectly in the server_profile create function?

Hi @elliottkat
Nope, you're not reading it wrong, the way it was implemented it waits synchronously for the task to finish, and if it reaches the timeout it aborts waiting for the task, but not send any cancellation signal to OneView.
So you can use a try-except to catch these timeout exceptions and create them assynchronously.
However, it may take some time to the timeout occur for each of them, and you may lost track when the creation is complete. Fortunately you can bypass that using Python threads.
I've created this code example that may help you to do that.
Thanks for pointing that out!

Thanks so much, Thiago!


Add basic example to docs landing page

Problem
Currently, the documentation landing page (https://viewcomponent.org) does not give folks new to the framework an idea of what it accomplishes.

I think we could put a really convincing example there showing off some of the features of view components as well as the value they provide. - @BlakeWilliams

Proposed solution
Add (or maybe just move) a basic example to the landing page. Perhaps we could move some of https://viewcomponent.org/guide/?

Closing as resolved.


Does DomainNew support configure URL redirection?

Does have any way to configure URL redirection for CDN like that https://www.alibabacloud.com/help/en/doc-detail/27133.htm?
Note

I'm using pulumi-alicloud version: v2.31.0

I'm not sure. This provider is generated from https://github.com/aliyun/terraform-provider-alicloud. I'm not an expert on alicloud.
I'd recommend opening a similar issue upstream, which is maintained by alicloud. If there is a way to do so in the alicloud's TF provider, I can show you how to do it in this Pulumi provider.


Flare VM installation

What's the problem?
please i have been trying to install flareVM on my windows 11 vm with this "(New-Object net.webclient).DownloadFile('https://raw.githubusercontent.com/mandiant/flare-vm/main/install.ps1',"$([Environment]::GetFolderPath("Desktop"))\install.ps1")" but i get the response of - "Exception calling "DownloadFile" with "2" argument(s): "The underlying connection was closed: An unexpected error
occurred on a send."
At line:1 char:115

... /main/install.ps1',"$([Environment]::GetFolderPath("Desktop"))\instal ...

                      ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

CategoryInfo          : NotSpecified: (:) [], MethodInvocationException
FullyQualifiedErrorId : WebException" what can be the cause and how can i maneuver

Steps to Reproduce
(New-Object net.webclient).DownloadFile('https://raw.githubusercontent.com/mandiant/flare-vm/main/install.ps1',"$([Environment]::GetFolderPath("Desktop"))\install.ps1")
Environment
VirtualBox
powershell 5.6
windows 11
Additional Information
No response

The link showed 404 status code on clicking, Tried replacing the link:
(New-Object net.webclient).DownloadFile('https://raw.githubusercontent.com/mandiant/flare-vm/refs/heads/main/install.ps1',"$([Environment]::GetFolderPath("Desktop"))\install.ps1")


Added a blank window (Mac and Windows)

main.cpp now displays a blank window. I've tested it on my Mac and on a Windows 64-bit ARM VMware instance.

Will need to implement Linux support too, at least partially, since the linter is running in a Linux environment. Will try, but might have to hold off until later if it becomes a rabbit hole

Added Linux windowing support as well. Settings are a bit less forgiving, as it expects users to have sdl on local system installed. I thought about including a static binary with the build but thought against it. People using Linux for playing emulators probably know what they're doing..
I added necessary dependencies to the GH action, added explicity clang install, and set clang as the default compiler. Hopefully, this will make the linting behave consistently between GH actions and the docker image..


Disable logging?

How to disable console logs?

Hi @davinderkumar ,
Can you please give a brief about which logs are you talking about?

Console logs

Can you send a screenshot of the same?

you have many prints in your code

These logs are coming from an underlying package ddp that meteorify is using.
I'll just push up some changes in a separate branch that will help you out in disabling the logs.
But I'll need your help in order to test those changes as I don't have access to a meteor server to connect to right now.
I hope you'll be available for that.

Hi @davinderkumar ,
Can you please test the changes in the feature/disable-ddp-logging branch?
All you have to do is to switch the dependency resolution to point to this branch using:
dependencies:
  meteorify:
    git:
      url: git@github.com:ShivamArora/meteorify.git
      ref: feature/disable-ddp-logging

and
make your connection by providing the enableLogs parameter like this:
var status = await Meteor.connect('ws://example.meteor.com/websocket', enableLogs: false);

Let me know if that works for you and I'll push an update accordingly.

error

Also, can you publish an updated version for latest flutter.

Logging is still there

Also, can you publish an updated version for latest flutter.

The package doesn't depend on flutter sdk. It only uses Dart under the hood.
Is there something that I misunderstood?

Logging is still there

Did you use enableLogs: false?

Yes

Did you use enableLogs: false?

DDP is dependent on some older version libraries.   I am getting this error
meteorify >=1.0.3 depends on ddp ^0.0.13 which depends on tuple ^1.0.2, meteorify >=1.0.3 requires tuple ^1.0.2.

The package doesn't depend on flutter sdk. It only uses Dart under the hood.

DDP is dependent on some older version libraries. I am getting this error
meteorify >=1.0.3 depends on ddp ^0.0.13 which depends on tuple ^1.0.2, meteorify >=1.0.3 requires tuple ^1.0.2.

I think the error message is a bit incomplete or wrong regarding the required version.
But I get the point that you might have started using the latest flutter sdk which has support for Dart Null Safety which requires tuple ^2.0.0.
Is there any other package as well that you see that needs to be upgraded?

Yeah.
And because tuple >=1.0.2 <2.0.0-nullsafety.0 depends on quiver >=0.22.0 <3.0.0, meteorify >=1.0.3 requires quiver >=0.22.0 <3.0.0.

I think the error message is a bit incomplete or wrong regarding the required version.

@davinderkumar
Seems like the DDP dependency that I use https://github.com/haoguo/ddp is no longer under maintenance.
That's where the tuple and quiver dependencies are being used and since they've upgraded the major version it might bring some breaking changes to DDP.
I'll try if I can do something about it in my free time. But it would surely take a large chunk of time and might have to publish an up-to-date version of DDP myself.
For now, I'll create an issue on the DDP repository and see if I get a response.

@ShivamArora
Can you check this repo https://github.com/wendellrocha/enhanced_ddp

@davinderkumar Just checked. But even this fork is using the older version of tuple.

yeah. most of it is just addition of enhanced word, using web_socket_channel, and remove listener.

https://github.com/ShivamArora/meteorify/blob/feature/disable-ddp-logging/lib/src/meteor/subscribed_collection.dart
file contains lot of prints


404 when listing issues

Although genuinely impressed by the install procedure :+1:
My fist choice of command (following mkalias) was issue which didn't pan out too well:

It's actually not the URL that's the problem - it's the authentication:
This one works fine:
curl -s -i -u :c3832d7afxxxxxxxxxxxxxxxxa8823dc21d9b8f6 https://api.github.com/repos/Praqma/praqma.com/issues

but
curl -s -i https://api.github.com/repos/Praqma/praqma.com/issues

Dies:

I expected that git auth would be my rescue
But:

Hmmm
The token was generated and added to my .gitconfig file:
[phlow]
	token = 028b751455a11beb4feea4bf104f0ce0658af21c
	user = lakruzz

but still it seems invalid:

It looks like I haven't been given sufficient access:

I have this:

When I change to:

....
curl -s -i -u :028b751455a11beb4feea4bf104f0ce0658af21c https://api.github.com/repos/Praqma/praqma.com/issues

actually works

....AAArgh
git issues

still fails

It works on public repos, but not private:

yes the phlow only works with public repos, but I will look and the access rights and so it works with private repos too.
Thanks for the feedback


bug: java.util.concurrent.ExecutionException: java.lang.Exception: Failed to start Cody agent

Plugin version: 5.3.27
IDE version: RM-233.13135.91
Stacktrace:
java.util.concurrent.ExecutionException: java.lang.Exception: Failed to start Cody agent
	at java.base/java.util.concurrent.CompletableFuture.reportGet(CompletableFuture.java:396)
	at java.base/java.util.concurrent.CompletableFuture.get(CompletableFuture.java:2073)
	at com.sourcegraph.cody.agent.CodyAgentService$Companion.withAgentRestartIfNeeded$lambda$1(CodyAgentService.kt:133)
	at com.intellij.openapi.application.impl.ApplicationImpl$2.run(ApplicationImpl.java:249)
	at java.base/java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:539)
	at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264)
	at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1136)
	at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:635)
	at java.base/java.util.concurrent.Executors$PrivilegedThreadFactory$1$1.run(Executors.java:702)
	at java.base/java.util.concurrent.Executors$PrivilegedThreadFactory$1$1.run(Executors.java:699)
	at java.base/java.security.AccessController.doPrivileged(AccessController.java:399)
	at java.base/java.util.concurrent.Executors$PrivilegedThreadFactory$1.run(Executors.java:699)
	at java.base/java.lang.Thread.run(Thread.java:840)
Caused by: java.lang.Exception: Failed to start Cody agent
	at com.sourcegraph.cody.agent.CodyAgentService.startAgent$lambda$3(CodyAgentService.kt:82)
	at com.intellij.openapi.application.impl.ApplicationImpl$2.run(ApplicationImpl.java:249)
	at java.base/java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:539)
	at com.intellij.util.concurrency.ContextCallable.call(ContextCallable.java:32)
	at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264)
	at com.intellij.util.concurrency.ContextRunnable.run(ContextRunnable.java:27)
	... 7 more
Caused by: java.util.concurrent.ExecutionException: org.eclipse.lsp4j.jsonrpc.ResponseErrorException: [UriError]: If a URI does not contain an authority component, then the path cannot begin with two slash characters ("//")

Error: [UriError]: If a URI does not contain an authority component, then the path cannot begin with two slash characters ("//")
    at f (C:\snapshot\dist\agent.js)
    at e3.t3 (C:\snapshot\dist\agent.js)
    at new e3 (C:\snapshot\dist\agent.js)
    at Function.parse (C:\snapshot\dist\agent.js)
    at _Uri.parse (C:\snapshot\dist\agent.js)
    at C:\snapshot\dist\agent.js
    at MessageDecoder.callback (C:\snapshot\dist\agent.js)
    at MessageDecoder._write (C:\snapshot\dist\agent.js)
    at writeOrBuffer (node:internal/streams/writable:392:12)
    at _write (node:internal/streams/writable:333:10)
    at Writable.write (node:internal/streams/writable:337:10)
    at Socket.ondata (node:internal/streams/readable:766:22)
    at Socket.emit (node:events:537:28)
    at Socket.emit (node:domain:482:12)
    at addChunk (node:internal/streams/readable:324:12)
    at readableAddChunk (node:internal/streams/readable:297:9)
	at java.base/java.util.concurrent.CompletableFuture.reportGet(CompletableFuture.java:396)
	at java.base/java.util.concurrent.CompletableFuture.get(CompletableFuture.java:2096)
	at com.sourcegraph.cody.agent.CodyAgentService.startAgent$lambda$3(CodyAgentService.kt:69)
	... 12 more
Caused by: org.eclipse.lsp4j.jsonrpc.ResponseErrorException: [UriError]: If a URI does not contain an authority component, then the path cannot begin with two slash characters ("//")

Error: [UriError]: If a URI does not contain an authority component, then the path cannot begin with two slash characters ("//")
    at f (C:\snapshot\dist\agent.js)
    at e3.t3 (C:\snapshot\dist\agent.js)
    at new e3 (C:\snapshot\dist\agent.js)
    at Function.parse (C:\snapshot\dist\agent.js)
    at _Uri.parse (C:\snapshot\dist\agent.js)
    at C:\snapshot\dist\agent.js
    at MessageDecoder.callback (C:\snapshot\dist\agent.js)
    at MessageDecoder._write (C:\snapshot\dist\agent.js)
    at writeOrBuffer (node:internal/streams/writable:392:12)
    at _write (node:internal/streams/writable:333:10)
    at Writable.write (node:internal/streams/writable:337:10)
    at Socket.ondata (node:internal/streams/readable:766:22)
    at Socket.emit (node:events:537:28)
    at Socket.emit (node:domain:482:12)
    at addChunk (node:internal/streams/readable:324:12)
    at readableAddChunk (node:internal/streams/readable:297:9)
	at org.eclipse.lsp4j.jsonrpc.RemoteEndpoint.handleResponse(RemoteEndpoint.java:209)
	at org.eclipse.lsp4j.jsonrpc.RemoteEndpoint.consume(RemoteEndpoint.java:193)
	at org.eclipse.lsp4j.jsonrpc.json.StreamMessageProducer.handleMessage(StreamMessageProducer.java:194)
	at org.eclipse.lsp4j.jsonrpc.json.StreamMessageProducer.listen(StreamMessageProducer.java:94)
	at org.eclipse.lsp4j.jsonrpc.json.ConcurrentMessageProcessor.run(ConcurrentMessageProcessor.java:113)
	at java.base/java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:539)
	at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264)
	at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1136)
	at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:635)
	... 1 more

hello @kareem05 👋 I am sorry you encountered this issue 🙇
we added a few improvements that should help with this one. we hope to release them within a week. I kindly ask you for some patience. it seems that the issue may be related to the slow internet connection - as a quick workaround, you can try to use a better connection
I am closing this one in favour of https://github.com/sourcegraph/jetbrains/issues/723

This looks like separate issue, which should not be handled as part of https://github.com/sourcegraph/jetbrains/issues/723.
I'm reopening it, it needs a separate action.