Review and set guidelines for use of featured image + anchors

Where we use a featured image and anchor list, the page is very overwhelming.

How should we deal with this?

Recommend not using Featured image when there is an anchor list
Downscale the image
Reconsider peristence of anchor list

26 January:

Featured image on parent page
Anchor list (where needed) on content (child) page

26 January:

Featured image on parent page
Anchor list (where needed) on content (child) page

[Discussed 28 Jan]

Have no featured image on informational content pages that have a clear purpose, and are pages that have either a long list of grouped cards or have anchor links.
If a page has anchor links, this should be shown below the featured text.
Anchor links are used when there is a minimum of 3 H2s on the page. The advised maximum number of H2s should be no more than 8.

[Discussed 28 Jan]

Have no featured image on informational content pages that have a clear purpose, and are pages that have either a long list of grouped cards or have anchor links.
If a page has anchor links, this should be shown below the featured text.
Anchor links are used when there is a minimum of 3 H2s on the page. The advised maximum number of H2s should be no more than 8.

For @GarethOrmerod to consider in the template audit

For @GarethOrmerod to consider in the template audit


It seems we were passing tests becaues Asserts were being swallowed. …

…Fix this.
Basically we were turning asserts to throws, which then got caught and swallowed.
Fix it so that we fail the test oin that case.
Also fix these tests to be more uniform about how we unpack the data files we comare to.   improve the test so that it is more helpful when there are failures.
Finally there were problems that were being ignored that needed to be fixed.
In particular, we were assigning two stacks to the same event (becase there were events with the same QPC time).   Fixed this by disambiguating based on processor number (this is the change in TraceLog.cs).

Can you point out the exception handler that was catching this?

@sharwell The try that swallows the exception is in TraceEvent.Dispatch().   I have added a comment on the line I changed.


rasterize.js exits with error when size specified

Which version of PhantomJS are you using?

$ phantomjs --version
2.1.1

What steps will reproduce the problem?

$ phantomjs .../examples/rasterize.js http://google.com google.png 1024px
size: 1024px
ReferenceError: Strict mode forbids implicit creation of global property 'pageWidth'

  phantomjs://code/rasterize.js:29 in global code

Which operating system are you using?

macOS Sierra 10.12.3 (16D32)
$ uname -a
Darwin Cliffjumper.local 16.4.0 Darwin Kernel Version 16.4.0: Thu Dec 22 22:53:21 PST 2016; root:xnu-3789.41.3~3/RELEASE_X86_64 x86_64

Did you use binary PhantomJS or did you compile it from source?

Binary from homebrew:
$ brew info phantomjs
phantomjs: stable 2.1.1 (bottled), HEAD
Headless WebKit scriptable with a JavaScript API
http://phantomjs.org/
/usr/local/Cellar/phantomjs/2.1.1 (49 files, 50.5M) *
  Poured from bottle on 2016-10-10 at 11:22:09
From: https://github.com/Homebrew/homebrew-core/blob/master/Formula/phantomjs.rb
==> Dependencies
Required: openssl ✔
==> Requirements
Build: git ✔, xcode ✔
Required: macOS >= 10.7 ✔

Please provide any additional information below.

Fixed in https://github.com/ariya/phantomjs/commit/b5e44097413cebe584e84f979b265118cde77a12


Add support for Material Symbols Icons to the Flutter material library

Use case
One alternative solution is to download and use icons directly as icon assets from https://fonts.google.com/icons. There is also a package https://pub.dev/packages/material_symbols_icons that provides these icons, but this requires pulling in another dependency for something that seems like it should be provided by Flutter material out of the box.
Proposal
Include the Material Symbols Icons (https://fonts.google.com/icons) as Icons.foo objects.

Hi @kenzieschmoll, there's an issue tracking this in https://github.com/flutter/flutter/issues/102560.
For now, the recommendation is to use the material_symbols_icons package.
Closing this in favor of the issue linked above.
Thank you


User-defined sun positions

Add possibility to define custom sun positions based on the sun angle.

Implemented with release 1.2.0.


Package retrieval needs to be more robust.

When running elm-package commands I quite often get the following error:
Downloading elm-lang/core

Error: failed with 'InternalIOException recv: resource vanished (Connection reset by peer)' when sending request to
    <http://github.com/elm-lang/core/zipball/3.0.0/>

I am sure this is due to my shocking internet connectivity, but it would be nice if elm tried a few times, rather than giving failing on what appears to be the first attempt.
This is probably related to #151

Actually, a duplicate of this other issue: https://github.com/elm-lang/elm-package/issues/163?

:+1:

Okay, closing this one here, then.


Handle all types of date format in the indicator calculation logic

Some date strings, such as birthdates, only contain year resulting in ValueError: time data '1958' does not match format '%Y-%m-%d' Need a clever way of handling different formats

FHIR dates and datetimes are ISO 8601 date / datetime strings. I think something like dateutil's isoparse could probably be used to address this use-case.

Thanks @ibacher for the heads-up this is what we need!


Add CodeBlockShiki to allow for syntax highlighting using Shiki

Hello everyone! 👋
This PR is response to this tweet: https://twitter.com/tiptap_editor/status/1488817865121845248
It adds a new node/extension that would be an alternative to the CodeBlockHighlight node/extension. It utilizes Shiki instead of scrivo/highlight.php to provide the actual syntax highlighting.
It differs in a couple of important ways,

It requires the installation of a npm package
It adds inline styles to the markdown, which allows it to work without requiring any external css files
It allows the user to specify what code theme to use
It requires the user to specify the language, it does not have the ability to guess what language the snippet is, the use would specify the language by using three backticks followed by the language for the snippet (```php <? php phpinfo() ```). If the user does not specify the language as noted aforementioned, it will default to the set default which is html, or a default set by the developer.

This PR also introduced the package.json file to install shiki in the dev environment, which is used in the test suite to test functionality.
This is my first contribution for this project, so please feel free to pass constructive feedback and/or request changes.
☑ Readme documentation updated
☑ Test suite updated
Cheers 🍻
Wyatt

Amazing! :-) Thanks for the work on this!


Convert SA1501 (StatementMustNotBeOnASingleLine) use of IsAnalyzerSuppressed to configuration

Currently the behavior of SA1501 (StatementMustNotBeOnASingleLine) varies based on whether or not various diagnostics are suppressed (SA1503, SA1519, SA1520). The analyzer should not rely on this type of configuration; the behavior should instead be exposed as explicit options in stylecop.json.

I looked at this but didn't find a solution that looked like an obvious winner. For now moving to the Backlog milestone to deal with after the 1.0 release.


feat: add substrate-transfer precompile json for Blockscout

Description of proposed changes

Practical tips for PR review & merge:

[ ] All GitHub Actions report PASS
[ ] Newly added code/functions have unit tests

[ ] Coverage tools report all newly added lines as covered
[ ] The positive scenario is exercised
[ ] Negative scenarios are exercised, e.g. assert on all possible errors
[ ] Assert on events triggered if applicable
[ ] Assert on changes made to storage if applicable

[ ] Modified behavior/functions - try to make sure above test items are covered
[ ] Integration tests are added if applicable/needed

pre-commit.ci autofix


Incorrect dependencies

See, https://wordpress.slack.com/archives/C02QB2JS7/p1525790289000579

I'll need more details then that. 👋

If you try to run the latest version of Gutenberg with a create-guten-block the styles on the front-end won't load because of the missing wp-blocks dependency.
I also don't believe the other dependencies are necessary either.

I'd love for you to create a PR to fix this? Find the template in packages/cgb-scripts/template/ inside this repo.
Looking forward!

Following up

@TimothyBJacobs we're (maintainers) all traveling this week. It'll be a few days before I or someone on the team can test the changes and push live for the next release cycle. Google #io18, #MSBuild, and #WP15, etc.
Bear with us! Peace! ✌

@ahmadawais for styles wp-blocks dependency is not required
@TimothyBJacobs for scripts we need those dependencies have added review / comment for the same
For more details:

https://wordpress.org/gutenberg/handbook/blocks/generate-blocks-with-wp-cli/#examples
https://github.com/WordPress/gutenberg/pull/6778
https://github.com/wp-cli/scaffold-command/pull/151

@ajitbohra thanks for the review I am away due to a family emergency.

@ahmadawais no worries though to drop details/links for reference take your time to go through it when it feasible for you.
Emergency !!! Hope nothing serious all good


refactor: replace String with Str

This is a little bit slower than before.
Comparing results between 'main' and 'Current_run'
Host 'Brown-rhinoceros-beetle' with 8 'aarch64' processors with 7 GB memory, running:
#1 SMP PREEMPT_DYNAMIC Mon May 27 16:05:41 UTC 2024

MyBenchmark
lipsum metrics
Time (wall clock): results within specified thresholds, fold down for details.

Time (wall clock) (μs) *
p0
p25
p50
p75
p90
p99
p100
Samples

main
14
14
14
14
15
16
16
100

Current_run
15
15
15
15
15
15
15
100

Δ
1
1
1
1
0
-1
-1
0

Improvement %
-7
-7
-7
-7
0
6
6
0

lipsum-zh metrics
Time (wall clock): results within specified thresholds, fold down for details.

Time (wall clock) (ns) *
p0
p25
p50
p75
p90
p99
p100
Samples

main
1550
1579
1619
1626
1677
1811
1837
100

Current_run
1597
1604
1607
1611
1665
1736
1757
100

Δ
47
25
-12
-15
-12
-75
-80
0

Improvement %
-3
-2
1
1
1
4
4
0

medium-fragment metrics
Time (wall clock): results within specified thresholds, fold down for details.

Time (wall clock) (μs) *
p0
p25
p50
p75
p90
p99
p100
Samples

main
44
44
44
44
44
47
47
100

Current_run
44
44
44
44
44
45
46
100

Δ
0
0
0
0
0
-2
-1
0

Improvement %
0
0
0
0
0
4
2
0

small-fragment metrics
Time (wall clock): results within specified thresholds, fold down for details.

Time (wall clock) (ns) *
p0
p25
p50
p75
p90
p99
p100
Samples

main
4615
4620
4628
4641
4755
4776
4777
100

Current_run
4660
4665
4669
4669
4674
4690
4825
100

Δ
45
45
41
28
-81
-86
48
0

Improvement %
-1
-1
-1
-1
2
2
-1
0

strong metrics
Time (wall clock): results within specified thresholds, fold down for details.

Time (wall clock) (μs) *
p0
p25
p50
p75
p90
p99
p100
Samples

main
20
20
20
20
20
21
21
100

Current_run
19
19
20
20
20
21
21
100

Δ
-1
-1
0
0
0
0
0
0

Improvement %
5
5
0
0
0
0
0
0

tiny-fragment metrics
Time (wall clock): results within specified thresholds, fold down for details.

Time (wall clock) (ns) *
p0
p25
p50
p75
p90
p99
p100
Samples

main
469
488
506
585
635
693
695
100

Current_run
502
508
540
584
623
657
680
100

Δ
33
20
34
-1
-12
-36
-15
0

Improvement %
-7
-4
-7
0
2
5
2
0

Comparing results between 'main' and 'Current_run'
Host 'Brown-rhinoceros-beetle' with 8 'aarch64' processors with 7 GB memory, running:
#1 SMP PREEMPT_DYNAMIC Sat Aug  3 22:26:24 UTC 2024

MyBenchmark
lipsum metrics
Time (wall clock): results within specified thresholds, fold down for details.

Time (wall clock) (μs) *
p0
p25
p50
p75
p90
p99
p100
Samples

main
14
14
14
14
14
15
15
100

Current_run
14
14
14
14
14
14
15
100

Δ
0
0
0
0
0
-1
0
0

Improvement %
0
0
0
0
0
7
0
0

lipsum-zh metrics
Time (wall clock): results within specified thresholds, fold down for details.

Time (wall clock) (ns) *
p0
p25
p50
p75
p90
p99
p100
Samples

main
1547
1553
1558
1561
1566
1624
1681
100

Current_run
1545
1596
1606
1614
1624
1691
1697
100

Δ
-2
43
48
53
58
67
16
0

Improvement %
0
-3
-3
-3
-4
-4
-1
0

medium-fragment metrics
Time (wall clock): results within specified thresholds, fold down for details.

Time (wall clock) (μs) *
p0
p25
p50
p75
p90
p99
p100
Samples

main
44
44
44
44
45
47
47
100

Current_run
43
43
43
43
43
46
46
100

Δ
-1
-1
-1
-1
-2
-1
-1
0

Improvement %
2
2
2
2
4
2
2
0

small-fragment metrics
Time (wall clock): results within specified thresholds, fold down for details.

Time (wall clock) (ns) *
p0
p25
p50
p75
p90
p99
p100
Samples

main
4581
4588
4649
4755
4919
4932
4933
100

Current_run
4625
4637
4645
4796
4805
4813
4818
100

Δ
44
49
-4
41
-114
-119
-115
0

Improvement %
-1
-1
0
-1
2
2
2
0

strong metrics
Time (wall clock): results within specified thresholds, fold down for details.

Time (wall clock) (μs) *
p0
p25
p50
p75
p90
p99
p100
Samples

main
20
20
20
20
21
22
22
100

Current_run
19
19
19
19
20
21
21
100

Δ
-1
-1
-1
-1
-1
-1
-1
0

Improvement %
5
5
5
5
5
5
5
0

tiny-fragment metrics
Time (wall clock): results within specified thresholds, fold down for details.

Time (wall clock) (ns) *
p0
p25
p50
p75
p90
p99
p100
Samples

main
463
468
483
487
924
928
931
100

Current_run
454
460
489
529
570
618
619
100

Δ
-9
-8
6
42
-354
-310
-312
0

Improvement %
2
2
-1
-9
38
33
34
0


reference to 'Stream' is ambiguous error

Describe the bug
HI
I am trying to use this library but when include any of this library, i faced with this error:
error: reference to 'Stream' is ambiguous.
libraries:
#include "Arduino_BHY2Host.h"
#include <ArduinoJson.h>
#include <PubSubClient.h>
Arduino IDE version: 1.8.19
Portenta h7 lite latest frimware
OS: Ubuntu 20.04 LTS

Hi @yari0757
What a nonsense you post. If you add a new library and get compile error, that must be the issue of the newly-added library.
Anyway, I tested and compile OK, with the inclusion of those 3 libraries
If you continue lazily posting this kind of nonsense again, you'll be blocked from accessing these libraries to reduce wasting time of other people.

You can't threaten people that easily.  It is my absolute right to ask my question and this is what this place was created for.  The quality of asking questions is completely related to the level of expertise of people in that field, and I am currently a junior in your field of work.  I will report your threatening behavior to GitHub.


How to Use custom table for Login

Hey @antonioribeiro ,
I am using my custom table for the login and i used my own custom guard.
Tracker plugin working fine but tracker_session table "user_id" values is blank.

Below is my user table id

I did below settings in tracker.php but i think its wrong.

What is the solution?

@anuj509

I keep ioc_binding as it is "auth" and changed id to my custom table id. because using auth it take automatically guard and data.
Let me know if you have any question


ddc mode refactoring

Description

Types of Changes

[x] Tech Debt (Code improvements)
[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[x] Breaking change (fix or feature that would cause existing functionality to change)
[ ] Dependency upgrade (A change in substrate or any 3rd party crate version)

Migrations and Hooks

[x] This change requires a runtime migration.
[ ] Modifies on_initialize
[ ] Modifies on_finalize

Checklist

[x] Change has been tested locally.
[x] Change adds / updates tests.
[x] Changelog doc updated.

obsolete https://github.com/Cerebellum-Network/blockchain-node/pull/312


Can not change integer part when it is "0"

I use this:
element.inputmask('numeric', {
    digits: 2
});

Example: Initital value is "0.12".
Now select the "0", and type "3". Result is "30.12". Expected "3.12".
It works when the integer digit is non-zero.
Or when the "0" is not selected, but the cursor is placed after "0", then it works, too.

@gharlan ,
FIxed in the latest version

Thanks! But it does not work for me. Same behavior as before.
Version: 3.2.8-11

I'm sorry. It works!!
But there is a new issue. When the value is 0.00, and I select the first 0 (integer part), type 2, I get: 200.
Expected: 2.00

I will push the fix soon.

@gharlan ,
Fixed

thanks!


Add Other Geometric Shapes

C2SIM Problem Report / Change Request
Submitter Name (s): Curtis Blais for Geir Sletten and Ole Martin Mevassvik
Contact email address<EMAIL_ADDRESS><EMAIL_ADDRESS>Submitter Organization(s): FFI
Date of Submission: 23 May 2022
Type (Problem Report or Change Request): Change Request
Product: Core Ontology
Problem/Change Description:
From: Evaluation of C2SIM for use in Army Course of Action simulation, 22 February 2022, p 6
Support for circles or fan areas should also be supported.

This is a whole area that could be expanded in the ontology for a specific use. Presumably the point of "supporting" a particular shape would be that the class would have properties that described how control points would be used to define the shape. For example, a circle could be defined by a center location and a radius rather than by a (large) number of vertices on the circumference. The ontology has almost no support for any shapes at this point; note for example that it doesn't even have a rectangle, i.e. one aligned with compass directions. I recommend that this area be left as an extension to the core-- simple enough, as it should comprise new subclasses to MapGraphic. A "Graphic Shapes" extension could define classes for the two mentioned above plus many others.

A framework for shapes that are not Map Graphics could be added. See issue #8

Sounds like a good way to generate more delay - maybe to this next year?

Doug Reece @.***>
January 31, 2023 at 7:09 PM
A framework for shapes that are not Map Graphics could be added. See
issue #8 https://github.com/OpenC2SIM/C2SIMArtifacts/issues/8
—
Reply to this email directly, view it on GitHub
https://github.com/OpenC2SIM/C2SIMArtifacts/issues/9#issuecomment-1411247301,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABN7HSKRZYM7UDFC336L7FLWVGSVFANCNFSM5WXOLRSA.
You are receiving this because you are subscribed to this
thread.Message ID:
@.***>
clblais @.***>
May 23, 2022 at 8:16 PM
Geir Sletten and Ole Martin Mevassvik, Evaluation of C2SIM for use in
Army Course of Action simulation, 22 February 2022, p 6
Support for circles or fan areas should also be supported.
—
Reply to this email directly, view it on GitHub
https://github.com/OpenC2SIM/C2SIMArtifacts/issues/9, or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABN7HSKRUF3SGSVC4VGXK6DVLQNWNANCNFSM5WXOLRSA.
You are receiving this because you are subscribed to this
thread.Message ID: @.***>


remove formatter function from percentage diff evaluation

This commit fixes a small correctness issue with some metrics in the new Diff % column.
Before (sample):
|                                                        Metric |         Task |    Baseline |   Contender |         Diff |   Unit |     Diff % |
|--------------------------------------------------------------:|-------------:|------------:|------------:|-------------:|-------:|-----------:|
|                    Cumulative indexing time of primary shards |              |   0.0355667 |      0.0667 |      0.03113 |    min |      0.00% |
|             Max cumulative indexing time across primary shard |              |   0.0355667 |      0.0667 |      0.03113 |    min |      0.00% |
|                       Cumulative merge time of primary shards |              |     0.11245 |      0.0516 |     -0.06085 |    min |     -0.00% |
|                Max cumulative merge time across primary shard |              |     0.11245 |      0.0516 |     -0.06085 |    min |     -0.00% |
|                                                    error rate |       search |    0.655664 |           0 |     -0.65566 |      % | -10000.00% |

After (same sample):

|                                                        Metric |         Task |    Baseline |   Contender |         Diff |   Unit |   Diff % |
|--------------------------------------------------------------:|-------------:|------------:|------------:|-------------:|-------:|---------:|
|                    Cumulative indexing time of primary shards |              |   0.0355667 |      0.0667 |      0.03113 |    min |  +87.54% |
|             Max cumulative indexing time across primary shard |              |   0.0355667 |      0.0667 |      0.03113 |    min |  +87.54% |
|                       Cumulative merge time of primary shards |              |     0.11245 |      0.0516 |     -0.06085 |    min |  -54.11% |
|                Max cumulative merge time across primary shard |              |     0.11245 |      0.0516 |     -0.06085 |    min |  -54.11% |
|                                                    error rate |       search |    0.655664 |           0 |     -0.65566 |      % | -100.00% |

marked as :internal to keep it out of the release notes, minor bug fix for an as-yet-unreleased feature.

Now I'm curious however, why do we use convert.factor(100) for error rates?

We express our error rates as a percentage.  It might be able to be refactored away from the formatter (so we just use the identity, the default) but I'm leaving that as out-of-scope for this change

Thanks! Yes, definitely out of scope, I wasn't suggesting a refactoring.


Amplify Console build fails (API/RDS). Is team-provider-info.json ignored?

I have a simple (for now) Amplify Project with a GraphQL API with an RDS (Aurora Serverless) datasource.
Everything is working fine with "amplify push" but the build from the console (same environment) fails because it hangs with an input like if the datasource in the environment was never initialized (? Provide the region in which...):

While this parameters are already defined in the team-provider-info.json file.

Does anybody have the same problem (or nobody using RDS nowadays...)?
Any workaround for this?
Thankyou!

@swaminator  this issue still present on latest version like 4.32.1
We use the PR Preview feature, so we have to create the environment at runtime, so add those values on the amplify/team-provider-info.json is not an option
we have a custom amplifyPush to do the headless workflow but this didn't work because, the amplify console have no idea of how handle the RDS settings
At the Amplify Console the build got stuck, but nothing was shown

Running the script locally with the same env variables

We can see the console got stuck waiting for user confirmations
Related with Headless push with Aurora doesn't work #5536


Update UI to better handle different roles

Resolves #3721
How is this addressed

Update SecuredByRole to handle workpsace and app roles
Update Cost tags to display for workspace serivces and user resources
Hide History and Operations when user does not have access

/test-force-approve
UI only


Sort the steps of taskrun based on the steps of task

Changes

Closes: #942
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:

[x] Includes tests (if functionality changed/added)
[x] Includes docs (if user facing)
[ ] Commit messages follow commit message best practices

See the contribution guide
for more details.
Release Notes

release-note

/assign @hrishin @bobcatfish @vdemeester

this sounds worthwhile enough to mention in the release note,

@hrishin I have changed the structure of the code a bit. In order to separate the sort function, we have to make sure it is done between we get the taskrun and we update the taskrun.

/retest

Thank you @houshengbo :bowing_man:

I0614 17:21:03.378] 2019/06/14 17:21:03 util.go:142: Please use kubetest --gcp-service-account=/etc/test-account/service-account.json (instead of deprecated GOOGLE_APPLICATION_CREDENTIALS=/etc/test-account/service-account.json)
I0614 17:21:03.379] 2019/06/14 17:21:03 main.go:761: --gcp-project is missing, trying to fetch a project from boskos.
I0614 17:21:03.379] (for local runs please set --gcp-project to your dev project)
I0614 17:21:03.379] 2019/06/14 17:21:03 main.go:773: provider gke, will acquire project type gke-project from boskos
I0614 17:21:03.434] 2019/06/14 17:21:03 main.go:312: Something went wrong: failed to prepare test environment: --provider=gke boskos failed to acquire project: resource not found
I0614 17:21:03.462] Test subprocess exited with code 0

bah, reopened https://github.com/tektoncd/plumbing/issues/29
/test pull-tekton-pipeline-integration-tests

I0614 18:16:31.836] 2019/06/14 18:16:31 error processing import paths in "config/controller.yaml": Get https://gcr.io/v2/: net/http: TLS handshake timeout

whyyyyyyyy

/test pull-tekton-pipeline-integration-tests

/lgtm
/meow space

@bobcatfish Thank you.

/lgtm

/approve


unexpected token error after updating to today's version of C++/WinRT

After updating to today's build of C++/WinRT, my projects do not build anymore:
2>T:\Projects\TranslucentTB\packages\Microsoft.Windows.CppWinRT.2.0.190729.1\build\native\Microsoft.Windows.CppWinRT.targets(314,28): error MSB4092: An unexpected token "true" was found at character position 69 in condition "'$(_MdMergeDepth)' == '' And '$(CppWinRTRootNamespaceAutoMerge) == 'true''".

I think the error is related to the double ' in the condition, right after the "true" and the lack of a ' after "$(CppWinRTRootNamespaceAutoMerge)"

fixed and new release published.  sorry folks.


Add "to" attribute for Zammad issues

Incoming messages in Zammad currently do not show the "Reply" button/link. I looked into the JSON objects of messages created via chat API vs normal issues. The only difference I could make out was a missing to attribute in the article object. We should there fore add this attribute, which should be the "integreat-chat" group.

Unfortunately I am not having any luck with this. From what I've found online, adding an email address to the group is also required, but even doing this + adding the "to" field does not show success.

https://docs.zammad.org/en/latest/api/ticket/articles.html seems to contain relevant information. I'll have a look.

The following request opens a ticket that has a reply button:
{
  "title": "Fooo",
  "group_id": "2",
  "customer_id": 18,
  "state_id": "1",
  "article": {
    "from": "test user",
    "to": "integreat-chat",
    "body": "Bar",
    "type_id": 11,
    "sender_id": 2,
    "form_id": "556ee556-b140-4b1e-8e83-2167722cb592",
    "content_type": "text/html"
  },
  "organization_id": "",
  "id": "c-10"
}


MacOS: starting from bundle prevents file open and terminal tab from working

Lapce Version
Lapce nightly-5b2d412
System information
MacOs 12.6.2 (21G320)
Describe the bug
Open Lapce from the Finder.
Cannot open any file.
Terminal tab is not working
Opening a file from file picker or from the side bar results in an empty buffer without a name.
Clicking a second time on the same file from the sidebar results in a second buffer with the correct name but is still empty.
Closing and restarting the editor and the buffers are correctly opened but trying to open new buffers is the same as before.
Terminal tab still not working
Starting the application from the terminal, launching it with open -a Lapce.app or directly with Lapce.app/Contents/MacOS/lapce fix the issue for files and terminal tab
Additional information
Can't find any logs related in Console.
started from Finder

Started from Terminal

I think it's a dead end


Feature Request: Capturing additional SQL Query information

The current MySQL instrumentation only captures the url and query type of each query made.
It would be nice to update the instrumentation to also capture the actual query being run.
Obviously there would be privacy concerns attached to this, since you probably don't want to log out every query.
I'm happy to implement this if I can get some direction from the core team as to how you want to handle this.
I was thinking you can provide a predicate as part of the options initialising the instrumentation. This predicate that would be given the query being run, and return whether or not this query should log the query being run.
I came to look for this after seeing this forum thread: https://forums.aws.amazon.com/thread.jspa?messageID=809685

Hi clark-pan,
Due to the sensitive nature of the data and information that could be captured, we have plans to address this issue internally. We are still discussing on how to handle best to handle this to get most value out of it, while still being safe and protecting our customer's potentially sensitive data and prevent unintentionally leaking data due to misconfiguration. We do intend to address this in the next calendar year.
Thanks,
Sandra

Any Updates @awssandra ? Is there a plan for this?

@gvatreya Still on the roadmap and being prioritized against other items. PRs are welcome.

@ss2305 / @awssandra : Any updates on this enhancement request. We see a lot of value of including our sqls while instrumenting our PostgreSQL DB roundtrips and as @araines points, there is not much value instrumenting DB round trips without the sql info. It looks like customers have been waiting for this feature for 3 years now.

Hi @shrinidhiachar,
We are sorry this feature hasn't been prioritized yet. We're continuing to work on how best to capture these queries in a secure manner.

Are you good with somebody (like me) submitting a PR to implement an optional SQL capture for MySQL (along the lines of 390 that was done for Postgres)?


Allow index & cluster default refresh interval setting value to be -1

Description
This PR fixes the bug that does not allow the index setting index.refresh_interval  and cluster setting cluster.default.index.refresh_interval  to be set to -1.  More details on https://github.com/opensearch-project/OpenSearch/issues/11410.
Related Issues
Resolves #11410

Check List

[x] New functionality includes testing.

[x] All tests pass

[x] New functionality has been documented.

[x] New functionality has javadoc added

[x] Failing checks are inspected and point to the corresponding known issue(s) (See: Troubleshooting Failing Builds)
[x] Commits are signed per the DCO using --signoff
[ ] ~Commit changes are listed out in CHANGELOG.md file (See: Changelog)~
[ ] ~Public documentation issue/PR created~

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

❌ Gradle check result for fb11796: FAILURE
Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Flaky test - https://github.com/opensearch-project/OpenSearch/issues/9891

Will prefer a more predictable value rather than disabling a mode meant to perform constant work in the system(segment creation and replication)

Can you elaborate more on this, @Bukhtawar?

@astute-decipher  : can you pick this one and rebase it ?

@gbbafna  let me do that for you. @astute-decipher might not have the access for it.


Gpio type erasure

Implemented downgrade for gpio pins to solve #203.
Currently only thumbv7m support, but I think it could be ported to thumbv6m easily.

Looks great! Can you explain the naming of the pin_x and pin_xx macros? It's not terribly clear what it means from the name.

Also, could you document the downgrade method since it is public?

Just realized that the current implementation of Pxx is buggy. I'll try to fix it.

@Sympatron, now that #302 has been merged, will the DynPin API satisfy your needs?

Yes this can be closed now.


PowerToys Toggle

I use PowerToys Keyboard Manager to make my Windows keyboard function much more like a mac (don't judge). I know there's an option to set certain shortcuts to only work with certain programs, but I think a simpler solution would be to add a context dropdown menu when one right-clicks on the PowerToys icon in the taskbar to disable/enable all of PowerToys, or just some of the features. It saves a number of clicks of having to go through the menus.

Thank you for your feedback. There is an existing issue for a better quick access flyout in the taskbar #6751. You can raise your opinion there. Closing this as duplicate.


[SPARK-37644][SQL] Support datasource v2 complete aggregate pushdown

What changes were proposed in this pull request?
Currently , Spark supports push down aggregate with partial-agg and final-agg . For some data source (e.g. JDBC ) , we can avoid partial-agg and final-agg by running completely on database.
Why are the changes needed?
Improve performance for aggregate pushdown.
Does this PR introduce any user-facing change?
'No'. Just change the inner implement.
How was this patch tested?
New tests.

Test build #146211 has started for PR 34904 at commit b414ccb.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/50685/

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/50685/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/50685/

Test build #146218 has started for PR 34904 at commit 313d51d.

Test build #146211 has finished for PR 34904 at commit b414ccb.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/146211/

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/50692/

Test build #146222 has started for PR 34904 at commit b76f5f8.

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/50692/

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/50696/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/50692/

Test build #146218 has finished for PR 34904 at commit 313d51d.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/146218/

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/50696/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/50696/

Test build #146222 has finished for PR 34904 at commit b76f5f8.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/146222/

ping @cloud-fan

Test build #146250 has started for PR 34904 at commit ac187cc.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/50724/

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/50724/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/50724/

Test build #146250 has finished for PR 34904 at commit ac187cc.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/146250/

Test build #146266 has started for PR 34904 at commit f1d523f.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/50741/

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/50741/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/50741/

Test build #146266 has finished for PR 34904 at commit f1d523f.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

retest this please

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/146266/

Test build #146289 has started for PR 34904 at commit f1d523f.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/50761/

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/50761/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/50761/

Test build #146291 has started for PR 34904 at commit 9d9cd64.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/50763/

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/50763/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/50763/

Test build #146289 has finished for PR 34904 at commit f1d523f.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test build #146291 has finished for PR 34904 at commit 9d9cd64.

This patch passes all tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
   (defaultdict(<class 'list'>,

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/146291/

Test build #146384 has started for PR 34904 at commit 2384e38.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/50859/

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/50859/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/50859/

Test build #146384 has finished for PR 34904 at commit 2384e38.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/146384/

Test build #146398 has started for PR 34904 at commit 24ce91d.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/50873/

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/50873/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/50873/

Test build #146399 has started for PR 34904 at commit b4be693.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/50874/

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/50874/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/50874/

Test build #146398 has finished for PR 34904 at commit 24ce91d.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/146398/

Test build #146399 has finished for PR 34904 at commit b4be693.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/146399/

Test build #146460 has started for PR 34904 at commit ee36dbb.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/50935/

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/50935/

Test build #146460 has finished for PR 34904 at commit ee36dbb.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/146460/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/50935/

Test build #146464 has started for PR 34904 at commit 448bc7f.

Test build #146464 has finished for PR 34904 at commit 448bc7f.

This patch fails Scala style tests.
This patch merges cleanly.
This patch adds no public classes.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/146464/

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/50939/

Test build #146467 has started for PR 34904 at commit 4575c71.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/50941/

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/50939/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/50939/

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/50941/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/50941/

Test build #146467 has finished for PR 34904 at commit 4575c71.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/146467/

Test build #146479 has started for PR 34904 at commit c939885.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/50955/

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/50955/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/50955/

Test build #146479 has finished for PR 34904 at commit c939885.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

cc @huaxingao

thanks, merging to master!

@cloud-fan Thanks a lot!


Add Kerbal Kristmas Pack - Lights and presents from SpaceDock

This pull request was automatically generated by SpaceDock on behalf of OrbitalPhoenix, to add Kerbal Kristmas Pack - Lights and presents to CKAN.
Mod details:
name = /mod/2034/Kerbal%20Kristmas%20Pack%20-%20Lights%20and%20presents
author = OrbitalPhoenix
abstract = Just a fun little festive mod which adds attachable lights and wrapped presents KIS containers. Requires Kerbal Inventory System (KIS) to function.
license = CC-BY-4.0 https://creativecommons.org/licenses/by/4.0/
Homepage =
description =   Description:
Just a fun little festive mod which adds attachable lights and KIS container presents.
Requires Kerbal Inventory System (KIS) to function.
More Images here:
https://imgur.com/a/5zjxB5E
Instructions:
-Download and install Kerbal Inventory System (KIS)
https://forum.kerbalspaceprogram.com/index.php?/topic/149848-15-kerbal-inventory-system-kis-v116/
-Copy KerbalKristmasPack folder into the KSP GameData folder.
-Have Fun and Happy Holidays!
Changelog:
v1.0
-First Release
Please direct questions about this pull request to OrbitalPhoenix.

This was added in #6960.


Docs built from package should merge extensions into base type

Community Note

Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
If you are interested in working on this issue, please leave a comment

Describe the Feature

Currently, when you build the documentation for a project using the SDK, the docs for classes and structures in the Swift SDK are missing all of the things defined in extensions. The extensions should be merged into the main class or struct, so that SomeType includes everything declared as extension SomeType when looked up in the documentation

[ ] I may be able to implement this feature request

Fixed but pending publication of updated docs

Related to #757

Released in AWS SDK for Swift 0.32.0


Could not determine the dependencies

Can you tell what i'm doing wrong only by this error output?:
* What went wrong:
Could not determine the dependencies of task ':cordova-social-ok:odnoklassniki-android-sdk:compileReleaseAidl'.
> Could not resolve all task dependencies for configuration ':cordova-social-ok:odnoklassniki-android-sdk:releaseCompileClasspath'.
   > Could not resolve project :CordovaLib.
     Required by:
         project :cordova-social-ok:odnoklassniki-android-sdk
      > Project :cordova-social-ok:odnoklassniki-android-sdk declares a dependency from configuration 'releaseCompile' to configuration 'release' which is not declared in the descriptor for project :CordovaLib.

This error is thrown both in cordova-social-ok and cordova-social-vk plugins when running the cordova build android --release command.

Please see this answer on stackoverflow for workaround.

Well, it does not help — I already have the same gradle.build configuration as advised on StackOverflow:
dependencies {
    implementation fileTree(dir: 'libs', include: '*.jar')
    // SUB-PROJECT DEPENDENCIES START
    implementation(project(path: "CordovaLib"))
    implementation(project(path: "cordova-social-ok:odnoklassniki-android-sdk")){
        exclude module:("CordovaLib")
    }
    implementation(project(path: "cordova-social-vk:vksdk_library")){
        exclude module:("CordovaLib")
    }
    compile "com.onesignal:OneSignal:3.7.1"
    compile "com.facebook.android:facebook-android-sdk:4.+"
    // SUB-PROJECT DEPENDENCIES END
}


Standardized project structure

Feature Request
Is your feature request related to a problem? Please describe:
Currently our project file structure has some confusion, which is not very convenient and clear when reading the code and finding it.
Describe the feature you'd like:
Aligning the standard structure of other go projects:

https://github.com/golang-standards/project-layout
https://github.com/kubernetes/kubernetes

Describe alternatives you've considered:
N/A
Teachability, Documentation, Adoption, Migration Strategy:
N/A

/assign
I am working on this.

I have spent a lot of time in the past improving it. I think it's mostly done. Maybe the next effort will be to merge the code of ticdc and dm.

I have spent a lot of time in the past improving it. I think it's mostly done. Maybe the next effort will be to merge the code of ticdc and dm.


Configuration file location

The modules ui, node and cli all have their specific locations for the configuration file. This could be useful in some cases but normally, we want to use the same file. We should keep looking for the specific location but in case the configuration file is not found, look into the parent 'config' folder.

Fixed using the maven 'dist' module.


The Max78000 FTHR, while running the kws_20_demo with a 3.5mm microphone input, is experiencing issues

I am working on developing an IOT device based on Max7800 FTHR. However, I faced an error when I tried to use the 3.5mm audio input with my own microphone on the FTHR board running kws20_demo. I followed the readme file in the “MAX78000/CNN/kws20_demo/” project and enabled ENABLE_CODEC_MIC in the project.mk file. But I got an error in the image below when executing the max9867_init(mc_i2c_regs_t *i2c_inst, int mclk, int controller) function.

There seems to be something wrong with the reg_read function in max9867.c and the control mode of the I2C1.
Could you help me check this problem? I want to use my own microphone in the kws20_demo.

Hi @ChongHao-Qiu, thanks for reporting.  We will re-test the project to see if we can replicate the issue

We were able to replicate the issue and are investigating the codec driver code

Sorry for the delay @ChongHao-Qiu,
The following diff fixes the codec drivers.  It turns out the I2C was never initialized...
diff --git a/Libraries/MiscDrivers/CODEC/max9867.c b/Libraries/MiscDrivers/CODEC/max9867.c
index d895fa0c81..173704495a 100644
--- a/Libraries/MiscDrivers/CODEC/max9867.c
+++ b/Libraries/MiscDrivers/CODEC/max9867.c
@@ -377,6 +377,12 @@ int max9867_init(mxc_i2c_regs_t *i2c_inst, int mclk, int controller)
     if (!i2c_inst)
         return E_NULL_PTR;

+    if ((err = MXC_I2C_Init(i2c_inst, 1, MAX9867_ADDR)) != E_NO_ERROR)
+        return err;
+
+    if ((err = MXC_I2C_SetFrequency(i2c_inst, 100000)) != E_NO_ERROR)
+        return err;
+
     /* Static I2C request values */
     i2c_req.i2c = i2c_inst;
     i2c_req.addr = MAX9867_ADDR;

However there seems to be some deeper issues with the I2S drivers that we have been troubleshooting.  It will take us some more time to test and fix them.  I hope that the on-board microphone is acceptable as an alternative for you in the meantime.

The on-board microphone is functioning correctly. However, having the 3.5mm audio input operational is essential for my project. Could you provide some guidance on rectifying the I2S drivers? I am attempting to rewrite and resolve this issue.

One of the main issues with our I2S drivers is that they don't seem to be well implemented for sample sizes other than 8, 16, or 32 bits.  (see the logic in MXC_I2S_RevA_ConfigData) for example...
To sample the line-input, we need to interface with the on-board MAX9867 codec, with the codec acting as the master.  The codec has 16 bits per sample (16-bit ADCs), and the default configuration from the drivers is a 24kHz sample rate (controlled by LRCLK).

The number of BCLKs per channel on the I2S bus is controlled by the BSEL register.  The easiest options to use are the LRCLK multipliers.

64x LRCLK results in 32 bits per channel.
48x LRCLK results in 24 bits per channel.  This is the default setting used by the drivers.

As a result, we have 24 bits per channel, but only 16 bits of actual data.  These extra bits correspond to this section in the timing diagrams from the codec datasheet.

For the MAX78000, this configuration matches a sub-sample configuration with a sample size of 16 and a "bits per word" size of 24.  See section 15.5.4 of the MAX78000 User Guide for more details on the register settings for this.  The UG shows an 8-bit sub-sample as an example.

However, you'll notice that the conditional in our drivers here is not correct.  It ends up setting a sample size of 16 and a "bits per word" size of 16, which results in a byte misalignment in the received data.
The following diff on the I2S_DMA_Target example's main file seems to work to trick the drivers into using uint32_t data alignment, sample size = 16, and "bits per word" = 24.
--- a/Examples/MAX78000/I2S_DMA_Target/main.c
+++ b/Examples/MAX78000/I2S_DMA_Target/main.c
@@ -180,7 +180,7 @@ void i2s_init(void)
 #define I2S_CRUFT_PTR (void *)UINT32_MAX
 #define I2S_CRUFT_LEN UINT32_MAX

-    req.wordSize = MXC_I2S_DATASIZE_HALFWORD;
+    req.wordSize = MXC_I2S_DATASIZE_WORD;
     req.sampleSize = MXC_I2S_SAMPLESIZE_SIXTEEN;
     req.justify = MXC_I2S_MSB_JUSTIFY;
     req.wsPolarity = MXC_I2S_POL_NORMAL;
@@ -200,6 +200,8 @@ void i2s_init(void)
     else
         printf("I2S initialized successfully \n");

+    // Overwrite bits-per-word = 24 after initialization
+    MXC_SETFIELD(MXC_I2S->ctrl1ch0, MXC_F_I2S_CTRL1CH0_BITS_WORD, (24 - 1) << MXC_F_I2S_CTRL1CH0_BITS_WORD_POS);

So bringing it together...

I would suggest starting with the I2S_DMA_Target example, and applying the workaround above.  See if you can get the recording/playback on the line-in and line-out working with the codec alone.  This would be a good starting point for digging into the driver's configuration and confirming a working setup.

From that point, the KWS model requires audio with a 16kHz sample rate and 16-bits per channel.  You should be able to easily reduce the LRCLK setting in the codec to achieve the 16kHz sample rate.

From there, you can start moving towards the CNN again.  The KWS demo doesn't use DMA to unload the I2S FIFOs, and I think part of the problem is that its I2S request struct (here) is not configured properly to match the codec if ENABLE_CODEC_MIC is defined.  The demo program has a lot going on, so you might also find it valuable to look at the "Kown Answer Test" (KAT) in the kws20_v3 example.  This is the direct output of the ai8x-synthesis tool for the model.

I hope this is helpful for getting started.  We are also looking into this in parallel, but we are a relatively small team with lots of micros to maintain.  Any contributions you're willing to make would be very much welcome, and we're happy to assist with more clarification however we can.  Our I2S drivers have needed a refresh for some time.

Hello @ChongHao-Qiu ,
Please check if PR #847 fixes your issues. After configuring the example plug cable to J5 (line-in jack) and play a recorded sound to see KWS outputs. Please let us know if anything appears.
Note: Enabling 3.5mm Jack input doesn't allow you to use your headphone's analog mic as it's not connected to anywhere. Please see in schematics for the details.

Hi, @ahmetalincak. I appreciate your help. I updated the latest SDK and built the kw_20 project successfully. However, I still get an error message in the serial port output:

Have you happened to see this error?

Hi @ChongHao-Qiu,
Thanks for checking this. You can see in the PR that I added codec_init function to initialize MAX9867 and this would resolve any MAX9867 related problem.
As #847 has not been merged to main branch yet, I need to ask you to check if you checked out to branch fix/i2s_driver_enhancements (you can simply do it by running git fetch && git checkout -b fix/i2s_driver_enhancements origin/fix/i2s_driver_enhancements).

#847 merged, closing as fixed


Added a fun youtube link in phone number

Had to update my project to get in line with all of the forked items and new data, but fixed the merge conflicts and then added a fun link to try and learn how to do embedded links with tool tips. Thanks again!

That's great! Good job 👍


Verify the scheduled synchronization task section

Needs an updated screenshot using the current Azure AD portal.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: f59cedc6-86e8-6549-ee51-0fb2315653d6
Version Independent ID: 579d36a9-63a6-f1e7-e3ab-803a4ce925db
Content: Azure AD Connect: Next steps and how to manage Azure AD Connect
Content Source: articles/active-directory/hybrid/how-to-connect-post-installation.md
Service: active-directory
GitHub Login: @billmath
Microsoft Alias: billmath

@danmyhre Thanks for your feedback! We will investigate and update as appropriate.

@danmyhre Thanks for the feedback !  I have assigned this issue to content author to investigate and update the document as appropriate.


flutter_firebase_chat_core function get list of users through FirebaseChatCore.instance.users(); is not returning list of users in android OS version 11 and 10

General
What bug do you experience? 🐞
Provide a clear and concise description of what the bug is.
How can it be reproduced? 🤔
A few steps to define where does the bug occur.
Step 1. ...
Step 2. ... etc.
What behavior is expected? 💡
A clear and concise description of what you expected to happen.

Extras
Screenshots or videos 📸
If applicable, add screenshots or videos to help explain your problem.
Code snippets 📝
If applicable, add code samples to help explain your problem.
// Your snippet here...

Environment info
Please specify the flutter, flutter_firebase_chat_core versions.
flutter: ...
flutter_firebase_chat_core: ...
flutter doctor -v output 👇

Platform
Device (e.g. Android emulator, iOS simulator, Samsung Galaxy S21): ...
OS version (e.g. iOS 14.5, Android 11): ...

Additional context
Add any other context about the problem here.
<!-- Thank you for making us better 🤝--!>

var userToRoom = FirebaseChatCore.instance.users();
userToRoom.listen((listOfStrings) async {
// From this point you can use listOfStrings as List object
// and do all other business logic you want
          for (var con in listOfStrings) {
            // print(str);
            if (con.metadata!
                .containsValue(widget.patronData['email'])) {
              sendUserToRoom = myString;
              print(sendUserToRoom);
              break;
            } else {}
          }

}
Here userToRoom has 6 entries but retrieves an Empty stream when trying in OS versions 11 and 10.

An instance of '_EmptyStream<List>' is what I am getting as a print statement in the userToRoom variable.

Maybe old version? Can you try on new, Flutter 3 version?

@demchenkoalex I am trying this on Flutter 3.0.1 already, but getting issue.

Does it work on iOS? Or Android versions 9 or 12?

No , checked in android version 10,11,12 not working

And iOS? If iOS does not work as well I think it might be something on your side. I do receive users in the example app.

I don't have the data you have, and can't use your code. Your path should be - checking that simple FirebaseChatCore.instance.users works (similarly to the example) and then debugging it from that point.

FirebaseChatCore.instance.users is returning An instance of '_EmptyStream' this and hence I am not able to create a room for the user .

Okay, but in the example it returns a list of users normally. Then it is a matter of mapping users from your Firebase store, something is off there, probably users can't be mapped, that means some values are off? I think I had this even if at least one entity is broken, the whole list will be empty. How many users do you have and are you able to verify they can be mapped correctly?

@demchenkoalex I figured out this issue and bingo, I found the bug. Thanks for elaborating. Resolved.

@demchenkoalex It's not working again , I tried getting users list from firebase method its returning and then created a room through flyer chat method createRoom it's saying "User doesn't exist"
var userToRoom =                 FirebaseFirestore.instance.collection('users').snapshots();             print(userToRoom);             userToRoom.listen((listOfStrings) async {               for (var myString in listOfStrings.docs) {                 // print(str);                 var email = myString.get('metadata');                 if (email['email'] == widget.patronData['email']) {                   sendUserToRoom = myString;                   print(sendUserToRoom);                   break;                 } else {}               }               Map str = sendUserToRoom.data();               var user = types.User(                       id: sendUserToRoom.id,                       firstName: str['firstName'],                       lastName: str['lastName'],                       imageUrl: str['imageUrl'])                   .toJson();               print(user);               final room = await FirebaseChatCore.instance.createRoom(                   types.User(                       id: sendUserToRoom.id,                       firstName: str['firstName'],                       lastName: str['lastName'],                       imageUrl: str['imageUrl']));

It's sudden sometimes it's returning users and sometimes not

for the future, please use a code block with a formatting, cause it is hard to follow that piece of code above. You can do this by typing ```dart, then on the next line your code, then close with 3 backticks again. (it will look like the code below I pasted)
There is one thing I realised regarding the createRoom function - it actually uses only ID inside, so you could simplify code by removing all other fields, like firstName, lastName, imageUrl from the call to createRoom - e.g.
final room = await FirebaseChatCore.instance.createRoom(types.User(id: sendUserToRoom.id))

Next, I not sure I understand all of those strings transformations you have, when you listen to the FirebaseChatCore.instance.users() snapshots, in the data you have User types - I see you need to check metadata to select a particular user, why not just do
user.metadata?['email'] == widget.patronData['email']

and then you have a User without any modifications, faster and easier.
Next, you can always look at the source code (it is super easy), for example users stream - see, there is no dark magic inside, so in case you sometimes don't get somethings, please check your transformations and/or what you have in Firebase (is it confirming to the User type) - all should be correctly working.

@demchenkoalex Thank you very much for the formatting tip, I am new with it.
Regarding your suggestion not to use firstName, LastName let me try this out. Thanks for the clarification.


Inner-query with byte[] FK produces wrong result with EFCore 2.1.x

After upgrading EFCore to 2.1.x, specific kind of query produces wrong result.
Steps to reproduce
I have following models
    public class Blog
    {
        [Key]
        public byte[] Name { get; set; }
        public List<Comment> Comments { get; set; }
    }

    public class Comment
    {
        public int Id { get; set; }
        public byte[] BlogName { get; set; }
        public Blog Blog { get; set; }
    }

and following query.
                var query = from blog in ctx.Blogs
                            select new
                            {
                                blog.Name,
                                Comments = blog.Comments.Select(u => new
                                {
                                    Id = u.Id,
                                }).ToArray(),
                            };

complete example is at https://gitlab.com/suzuki_ds/efcore_test .
Test1 in UnitTest1.cs describes this issue.
Expected behavior
Result items should have Comments collection.
Actual behavior
Result items have Comments collection with no element. (size == 0)
This problem will happen only on EFCore 2.1.x, not on 2.0.x.
Further technical details
EF Core version: Microsoft.AspNetCore.All 2.1.2
Database Provider:Microsoft.EntityFrameworkCore.Sqlite 2.1.1
Operating system: Windows 10 Pro 1803
IDE: Visual Studio 2017 15.7.5

We generate the following query plan:
(QueryContext queryContext) => IEnumerable<<>f__AnonymousType0<byte[], <>f__AnonymousType1<int>[]>> _InterceptExceptions(
|__ source: IEnumerable<<>f__AnonymousType0<byte[], <>f__AnonymousType1<int>[]>> _ShapedQuery(
|   |__ queryContext: queryContext,
|   |__ shaperCommandContext: SelectExpression:
|   |       SELECT [blog].[Name]
|   |       FROM [Blogs] AS [blog]
|   |       ORDER BY [blog].[Name],
|   |__ shaper: (QueryContext queryContext | ValueBuffer blog) => new {
|           byte[] TryReadValue(blog, 0, Blog.Name),
|           <>f__AnonymousType1<int>[] ToArray(List<<>f__AnonymousType1<int>> queryContext.QueryBuffer.CorrelateSubquery(
|           |__ correlatedCollectionId: 0,
|           |__ navigation: Blog.Comments,
|           |__ resultCollectionFactory: (INavigation n) => new List<<>f__AnonymousType1<int>>(),
|           |__ outerKey: new MaterializedAnonymousObject(new object[]{ (object)!(blog.IsEmpty) ? byte[] TryReadValue(blog, 0, Blog.Name) : default(byte[]) }),
|           |__ tracking: False,
|           |__ correlatedCollectionFactory: () => IEnumerable<Tuple<<>f__AnonymousType1<int>, MaterializedAnonymousObject, MaterializedAnonymousObject>> _ShapedQuery(
|           |   |__ queryContext: queryContext,
|           |   |__ shaperCommandContext: SelectExpression:
|           |   |       SELECT [t].[Name], [blog.Comments].[Id], [blog.Comments].[BlogName]
|           |   |       FROM [Comments] AS [blog.Comments]
|           |   |       INNER JOIN (
|           |   |           SELECT [blog0].[Name]
|           |   |           FROM [Blogs] AS [blog0]
|           |   |       ) AS [t] ON [blog.Comments].[BlogName] = [t].[Name]
|           |   |       ORDER BY [t].[Name],
|           |   |__ shaper: (QueryContext queryContext | TransparentIdentifier<ValueBuffer, MaterializedAnonymousObject> t0) => new Tuple<<>f__AnonymousType1<int>, MaterializedAnonymousObject, MaterializedAnonymousObject>(
|           |           new { int TryReadValue(t0.Outer, 1, Comment.Id) },
|           |           new MaterializedAnonymousObject(new object[]{ (object)!(t0.Outer.IsEmpty) ? byte[] TryReadValue(t0.Outer, 2, Comment.BlogName) : default(byte[]) }),
|           |           new MaterializedAnonymousObject(new object[]{ (object)(object)object TryReadValue(t0.Outer, 0, Blog.Name) })
|           |       )),
|           |__ correlationPredicate: (MaterializedAnonymousObject o | MaterializedAnonymousObject i) => object i.GetValue(0) == default(object) || object o.GetValue(0) == default(object) ? False : (byte[])object o.GetValue(0) == (byte[])object i.GetValue(0)))
|        }),
|__ contextType: Repro12748.MyContext,
|__ logger: DiagnosticsLogger<Query>,
|__ queryContext: Unhandled parameter: queryContext)

problem is that corelationPredicate does regular comparison for byte[], we should be performing structural comparison on those values instead.

fixed in e38ead5e17ff8afda8a69c9879cf7b6b00b57a47


[feat] Implement the constructor

Constructor function that is to be implemented from the Solidity code base - https://github.com/allo-protocol/allo-v2/blob/4dd0ea34a504a16ac90e80f49a5570b8be9b30e9/contracts/core/Registry.sol#L78
Resources :
https://book.cairo-lang.org/title-page.html
https://book.cairo-lang.org/ch16-02-00-composability-and-components.html?highlight=assert#example-an-ownable-component
If you have any doubts over on how to implement something similar to this you can try discovering few cairo code bases such as :
Unruggable memecoin : https://github.com/keep-starknet-strange/unruggable.meme/tree/main/packages/contracts/src
Blobstream : https://github.com/keep-starknet-strange/blobstream-starknet/tree/main/src
Exclusively for Starknet India team - To onboard new devs from India
Estimated Time taken to complete - 2-3 days (Max)

i would like to take this issue

Awesome less go !!

Hello my name is Kenneth Komu. I am a Starknet developer and I would like to work on the issue.


Some notice on /etc/zsh/zshrc

I install with this step
sudo git clone https://github.com/ahmetb/kubectx /opt/kubectx
sudo ln -s /opt/kubectx/kubectx /usr/local/bin/kubectx
sudo ln -s /opt/kubectx/kubens /usr/local/bin/kubens
mkdir -p ~/.oh-my-zsh/completions
chmod -R 755 ~/.oh-my-zsh/completions
ln -s /opt/kubectx/completion/kubectx.zsh ~/.oh-my-zsh/completions/_kubectx.zsh
ln -s /opt/kubectx/completion/kubens.zsh ~/.oh-my-zsh/completions/_kubens.zsh

and It's work.
But I get some notice. I don't know what happen ?
❯ kubens
/etc/zsh/zshrc: line 31: key: BackSpace: must use subscript when assigning associative array
/etc/zsh/zshrc: line 31: key: "${terminfo[kbs]}": must use subscript when assigning associative array
/etc/zsh/zshrc: line 31: key: Home: must use subscript when assigning associative array
/etc/zsh/zshrc: line 31: key: "${terminfo[khome]}": must use subscript when assigning associative array
/etc/zsh/zshrc: line 31: key: End: must use subscript when assigning associative array
/etc/zsh/zshrc: line 31: key: "${terminfo[kend]}": must use subscript when assigning associative array
/etc/zsh/zshrc: line 31: key: Insert: must use subscript when assigning associative array
/etc/zsh/zshrc: line 31: key: "${terminfo[kich1]}": must use subscript when assigning associative array
/etc/zsh/zshrc: line 31: key: Delete: must use subscript when assigning associative array
/etc/zsh/zshrc: line 31: key: "${terminfo[kdch1]}": must use subscript when assigning associative array
/etc/zsh/zshrc: line 31: key: Up: must use subscript when assigning associative array
/etc/zsh/zshrc: line 31: key: "${terminfo[kcuu1]}": must use subscript when assigning associative array
/etc/zsh/zshrc: line 31: key: Down: must use subscript when assigning associative array
/etc/zsh/zshrc: line 31: key: "${terminfo[kcud1]}": must use subscript when assigning associative array
/etc/zsh/zshrc: line 31: key: Left: must use subscript when assigning associative array
/etc/zsh/zshrc: line 31: key: "${terminfo[kcub1]}": must use subscript when assigning associative array
/etc/zsh/zshrc: line 31: key: Right: must use subscript when assigning associative array
/etc/zsh/zshrc: line 31: key: "${terminfo[kcuf1]}": must use subscript when assigning associative array
/etc/zsh/zshrc: line 31: key: PageUp: must use subscript when assigning associative array
/etc/zsh/zshrc: line 31: key: "${terminfo[kpp]}": must use subscript when assigning associative array
/etc/zsh/zshrc: line 31: key: PageDown: must use subscript when assigning associative array
/etc/zsh/zshrc: line 31: key: "${terminfo[knp]}": must use subscript when assigning associative array
/etc/zsh/zshrc: line 73:  ${+terminfo[smkx]} : bad substitution
/etc/zsh/zshrc: line 75: zstyle: command not found
/etc/zsh/zshrc: line 83:  ${+aliases[run-help]} : bad substitution
/etc/zsh/zshrc: line 84: autoload: command not found
/etc/zsh/zshrc: line 90: autoload: command not found
/etc/zsh/zshrc: line 91: compinit: command not found

Sadly this is not relevant to this repo.
I recommend you check your zshrc file. I don't know what /etc/zsh/zshrc does.

@ahmetb Thanks for answering me.
Do you have a suggestion, keyword or some link for this issue?
I don't know where should  I go

This is /etc/zsh/zshrc file
# /etc/zsh/zshrc: system-wide .zshrc file for zsh(1).
#
# This file is sourced only for interactive shells. It
# should contain commands to set up aliases, functions,
# options, key bindings, etc.
#
# Global Order: zshenv, zprofile, zshrc, zlogin

READNULLCMD=${PAGER:-/usr/bin/pager}

# An array to note missing features to ease diagnosis in case of problems.
typeset -ga debian_missing_features

if [[ -z "${DEBIAN_PREVENT_KEYBOARD_CHANGES-}" ]] &&
   [[ "$TERM" != 'emacs' ]]
then

    typeset -A key
    key=(
        BackSpace  "${terminfo[kbs]}"
        Home       "${terminfo[khome]}"
        End        "${terminfo[kend]}"
        Insert     "${terminfo[kich1]}"
        Delete     "${terminfo[kdch1]}"
        Up         "${terminfo[kcuu1]}"
        Down       "${terminfo[kcud1]}"
        Left       "${terminfo[kcub1]}"
        Right      "${terminfo[kcuf1]}"
        PageUp     "${terminfo[kpp]}"
        PageDown   "${terminfo[knp]}"
    )

    function bind2maps () {
        local i sequence widget
        local -a maps

        while [[ "$1" != "--" ]]; do
            maps+=( "$1" )
            shift
        done
        shift

        sequence="${key[$1]}"
        widget="$2"

        [[ -z "$sequence" ]] && return 1

        for i in "${maps[@]}"; do
            bindkey -M "$i" "$sequence" "$widget"
        done
    }

    bind2maps emacs             -- BackSpace   backward-delete-char
    bind2maps       viins       -- BackSpace   vi-backward-delete-char
    bind2maps             vicmd -- BackSpace   vi-backward-char
    bind2maps emacs             -- Home        beginning-of-line
    bind2maps       viins vicmd -- Home        vi-beginning-of-line
    bind2maps emacs             -- End         end-of-line
    bind2maps       viins vicmd -- End         vi-end-of-line
    bind2maps emacs viins       -- Insert      overwrite-mode
    bind2maps             vicmd -- Insert      vi-insert
    bind2maps emacs             -- Delete      delete-char
    bind2maps       viins vicmd -- Delete      vi-delete-char
    bind2maps emacs viins vicmd -- Up          up-line-or-history
    bind2maps emacs viins vicmd -- Down        down-line-or-history
    bind2maps emacs             -- Left        backward-char
    bind2maps       viins vicmd -- Left        vi-backward-char
    bind2maps emacs             -- Right       forward-char
    bind2maps       viins vicmd -- Right       vi-forward-char

    # Make sure the terminal is in application mode, when zle is
    # active. Only then are the values from $terminfo valid.
    if (( ${+terminfo[smkx]} )) && (( ${+terminfo[rmkx]} )); then
        function zle-line-init () {
            emulate -L zsh
            printf '%s' ${terminfo[smkx]}
        }
        function zle-line-finish () {
            emulate -L zsh
            printf '%s' ${terminfo[rmkx]}
        }
        zle -N zle-line-init
        zle -N zle-line-finish
    else
        for i in {s,r}mkx; do
            (( ${+terminfo[$i]} )) || debian_missing_features+=($i)
        done
        unset i
    fi

    unfunction bind2maps

fi # [[ -z "$DEBIAN_PREVENT_KEYBOARD_CHANGES" ]] && [[ "$TERM" != 'emacs' ]]

zstyle ':completion:*:sudo:*' command-path /usr/local/sbin \
                                           /usr/local/bin  \
                                           /usr/sbin       \
                                           /usr/bin        \
                                           /sbin           \
                                           /bin            \
                                           /usr/X11R6/bin

(( ${+aliases[run-help]} )) && unalias run-help
autoload -Uz run-help

# If you don't want compinit called here, place the line
# skip_global_compinit=1
# in your $ZDOTDIR/.zshenv
if grep -q '^ID.*=.*ubuntu' /etc/os-release && [[ -z "$skip_global_compinit" ]]; then
  autoload -U compinit
  compinit
fi

I don’t know. I don’t edit that file.


[ACR] Support build arg value propagated from environment variable

This checklist is used to make sure that common guidelines for a pull request are followed.

[ ] The PR has modified HISTORY.rst describing any customer-facing, functional changes. Note that this does not include changes only to help content. (see Modifying change log).

[ ] I adhere to the Command Guidelines.

@tjprescott can you please take a look?


Sign up page

Add a sign up page in your app so that user can register themselves.
Assign this issue to me..

Okay.

I want to contribute on this, can you please assign it to me ?

I want to contribute on this, can you please assign it to me ?

Sure.


ApplicationRef.isStable never goes to "true" when an instance of AngularFireAuth is injected

When AngularFireAuth is injected anywhere on the page, the ApplicationRef.isStable never emits true. This causes problems with latest @angular/service-worker, which relies on ApplicationRef.isStable to install the worker. This probably also would cause server-side rendering to timeout, but I didn't test this.
Version info
Angular: 5.0.0
Firebase: 4.6.2
AngularFire: 5.0.0-rc4
How to reproduce these conditions
Inject AngularFireAuth into a component and subscribe to the ApplicationRef.isStable observable:
import { Component, ApplicationRef, ChangeDetectorRef } from '@angular/core';
import { AngularFireAuth } from 'angularfire2/auth';

@Component({
  selector: 'my-app',
  templateUrl: './app.component.html',
  styleUrls: [ './app.component.css' ]
})
export class AppComponent  {
  constructor(appRef: ApplicationRef, af: AngularFireAuth) {
    appRef.isStable.subscribe(s => {
      console.log(s);
    });
  }
}

Here is a project that reproduces the problem: https://stackblitz.com/edit/angularfire2-appref-isstable
Expected behavior
The ApplicationRef.isStable observable should emit true shortly after application is loaded.
Actual behavior
The ApplicationRef.isStable observable emits only initial false value.

I'm actually tackling right now. Thanks for the report!

Once patched I'll cut a new RC.

I have a somewhat different issue, seems like return ApplicationRef; never got executed.
I'm new to angularfire2, can someone offer some good use cases for using angularfire2?

The same issue when I injects AngularFirestore.

jep, same issue here.

I am having the same issue when injecting AngularFirestore

seems like angularfire uses @firebase/auth which is not supported in angular.*
firebase auth or firebase module itself should be initialized outside angular(ngZone.runOutsideAngular())
@firebase/auth utilizes timers which stall app from emitting Stable result.
https://github.com/angular/angular/issues/8089#issuecomment-214098366

From @JiaLiPassion  "firebase auth make a very very long setTimeout to do proactive token refresh. (more than 200000ms)". Based on this comment, AngularFire2 needs to be doing something like this when running this long setTimeout.
I'm not sure how we could disable Firebase Auth from doing this so that AngularFire2 could do it in an Angular-friendly way, but this will be a problem for integration testing as well as Service Worker registration. @jamesdaniels is anyone on the Firebase team able to look into this?

angularfire2 cannot leave RC stage until this is fixed.

Fixed in rc7

The issue persists in the Auth module.
After you login some setTimeout is set at 33000ms. The code is too obfuscated to pinpoint where it exactly comes from except from auth.js from firebase.
By using a so called TaskTrackingZoneSpec, I was able to determine that when this zone task is created, the NgZone.isInAngularZone() returns true, and the e2e tests will timeout.
When I put this inside the onScheduleTask of the trackingZone:
if (task.type === 'macroTask' && task.data.delay > 3200000 && task.data.delay < 3400000) {
  setTimeout(() => {
    Zone.current.cancelTask(task);
  });
}`

The tests will run fine, because that particular task is no longer blocking the stable state of the angular zone, but also that task no longer exists, and I don't know how important it is ;).
Apparently some calls inside the AngularfireAuthModule trigger this timeout to run inside the zone. I haven't figured out which one exactly yet. My best guess is that it has something to do with the IdToken, judging by the stack trace

After a little more digging I found that the problem is originating from the fireauth.AuthUser.prototype.initializeProactiveRefreshUtility_.
This is at least triggered on login with using just email and password, or by using the getIdToken() and setting forceRefresh to true.
For now the workaround is whenever you call these functions is to wrap it inside a ngZone.runOutsideAngular -> ngZone.run

Just talking with myself here, I manged to work around it by having to override the AngularFireAuth like this:
{ provide: AngularFireAuth, useClass: AngularFireOwnAuth },

And have this:
@Injectable()
class AngularFireOwnAuth extends AngularFireAuth {
  readonly idToken: Observable<string | null>;

  constructor(
     @Inject(FirebaseOptionsToken) options: any,
     @Optional() @Inject(FirebaseNameOrConfigToken) nameOrConfig: string|any|undefined,
     @Inject(PLATFORM_ID) platformId: Object,
     zone: NgZone
  ) {
    super(options, nameOrConfig, platformId, zone);

    this.idToken = this.user.pipe(
      switchMap(async user =>
        user ? zone.run(async() => await zone.runOutsideAngular(() => user.getIdToken())) : null
      )
    );
  }
}

This will make sure the getIdToken is called outside the angular zone. If this is called inside the zone, it will trigger the long setTimeout and prevent angular from ever getting stable. At least not for 3300000ms :)

Thanks @PierreDuc! I can confirm the run outside zone method works as intended. I'm not using angular fire but it fixes it with interval from rxjs since it's the same idea.

Thanks for finding that problem. I had incorrectly assumed switchMap
would've stayed in the outer zone, I'll patch for the next RC.
On Thu, May 31, 2018, 4:04 PM Ed Pelc<EMAIL_ADDRESS>wrote:

Thanks @PierreDuc https://github.com/PierreDuc! I can confirm the run
outside zone method works as intended. I'm not using angular fire but it
fixes it with interval from rxjs since it's the same idea.
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
https://github.com/angular/angularfire2/issues/1347#issuecomment-393709707,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AACvrxI76CsS67UUQ_K-JT7X0bvUJhOfks5t4Hb3gaJpZM4QjZYY
.

@jamesdaniels The problem is that the observable this.user is inside the zone. So any pipe from it will be in the zone as well. Besides having to override the service, I also had to make any call to the AngularFireAuth, which in turn can possibly trigger the initializeProactiveRefreshUtility_ from firebase, to run outside the zone, and reenter after done.
I didn't have the time to figure out which of the calls trigger it, but I'm sure that at least user.getIdToken is a naughty one

@PierreDuc, maybe the problem is goog.Promise is not zone aware? Could you provide a reproduce repo?

@JiaLiPassion well, the issue is a long lasting setTimeout, triggered by firebase itself. This timeout is running inside the angular zone, and preventing the zone to be without macroTasks. Don't think that goog.Promise is involved here.
To reproduce a repo, I have to set-up a mock firebase app, where you can register and login. Don't think I have time soon to make something like that

@PierreDuc , ok, I know about the long lasting setTimeout one.
About the code here
if (task.type === 'macroTask' && task.data.delay > 3200000 && task.data.delay < 3400000) {
  setTimeout(() => {
    Zone.current.cancelTask(task);
  });
}`

Maybe there is a better way to solve this one, if this long setTimeout is not relevant to test,
you can try this in onScheduleTask,
onScheduleTask: (delegate, curr, target, task) => {
  if ( task.source === 'setTimeout' && task.data.delay > 3200000 && task.data.delay < 3400000) {
      task.cancelScheduleRequest();
      task = Zone.root.scheduleTask(task);
      return task;
  }
  return delegate.scheduleTask(target, task);
}

@JiaLiPassion Ah, but that's just in an additional test class called a TaskTrackingZoneSpec, which I modified a bit to determine what was causing the hanging angular zone.
But yes instead of overriding the AngularFireAuth, I could implement it like this, just in the e2e, although I don't really want something like this in my specs. It will make the e2e code different from the production code.

@PierreDuc , got it, I believe in Testability there is an additional API to let you decide when to done, but anyway, it also use TaskTrackingZoneSpec. When you have time, if you can share your e2e code, maybe I can help to find out how to make it look better, because it maybe a common use case for using zone for test. Thanks.

This issue should be reopened. Angular9 + AngularFire6 has same issue.

@JeongJun-Lee it would be appropriate to open a new issue in that case.
You may want to look into https://angular.io/api/service-worker/SwRegistrationOptions as that allows you to register a SW without waiting for isStable to be true.

i am developing a plugin to ignore such special async tasks.
https://www.npmjs.com/package/protractor-sync-options-plugin
https://github.com/angular/protractor/issues/4584#issuecomment-684487566
would be nice, if community supports me with pr and tests/issues for your use-cases.


Merging - Split nightly publish build into 2 steps

Add tests for the promotion project to verify proper build steps are present in projects.
Slightly deeper class hierarchy to support Half builds which are single steps.
Allow passing additional arguments to Gradle from TC when running builds.
Add "prep" tasks which run first during either step (to ensure necessary properties are present).

This supercedes PR #20248 and provides a clean merge with just split work (not JDK 18 or other experimental work).

This is the cleaned up version of 20248, which I believe is ready to be merged.  It must be merged at the same time as https://github.com/gradle/gradle-promote/pull/80, and we would like to use it with the upcoming 7.5 release.

@bot-gradle test this

OK, I've already triggered the following builds for you:

PullRequestFeedback build

@bot-gradle test and merge

OK, I've already triggered a build for you.


implements watcher chaining architecture

Purpose
Implements watcher chaining architecture.  closes #89
Changes
As described in #89 .  Slightly changes notebook interface.
Remaining issues
Per-run callbacks aren't in yet; that should probably go into a different PR.  There were also some changes to the watcher notebook in a different PR, so I might need to merge/resolve those differences before merging into main.

What is being logged here?
https://github.com/angelolab/toffy/blob/76ab82f0ad32f7a23ff91aaa49ca160a6304f612/toffy/fov_watcher.py#L189
watcher_callbacks::build_fov_callback returns the function fov_callback however fov_callback doesn't seem to modify or return anything. Could you clarify what it is doing?
https://github.com/angelolab/toffy/blob/cb995f355de2d6338ff265ebe4f31ba19b47037d/toffy/watcher_callbacks.py#L105

@srivarra When the bin files + json files are transferred over from the instrument computer, there's a chance that the bin file is created as a 0 byte file, but doesn't never gets filled in with the actual data.  This logs that event.
As for fov_callback, I'll write up some documentation to make this more clear.  The gist of it, is that the user passes the names of the member functions of FovCallbacks as *args.  These functions can then be retrieved as getattr(FovCallbacks(run_folder, point_name), member_function_name, None), with None being returned if member_function_name isn't found.  The **kwargs are passed as the arguments to these retrieved member functions.  Also, instead of using *args, I could set it up to take in a single list/iterable argument if that would be more clear.

I think everything's in.  Either way, this version is good to merge in.


Is it possible to set redirect location after login as admin

Is it possible to redirect to dashboard after login as admin?
Or is it possible to start live edit mode after login as admin?

for login you can do something like that
using GET or POST request
This will login only http://example.com/api/user_login?username=user&password=pass
This will login and redirect: http://example.com/api/user_login?username=user&password=pass&redirect=http%3A%2F%2Fexample.com%2Fadmin

Is your version redirecting to the website home page after login instead of the admin dashboard? I had a similar issue recently, you might want to check your code in userfiles\modules\users\login\index.php around line 49, I changed the following line:
window.location.href ='<?php print site_url(); ?>';
to
window.location.reload();


Error when executing Hover

Describe the bug
This could be related to #1079, but it does not mention an error message with this form:
Error executing vim.schedule lua callback: ...ite/pack/packer/start/lspsaga.nvim/lua/lspsaga/hover.lua:155: attempt to call fi
eld 'set' (a nil value)
stack traceback:
        ...ite/pack/packer/start/lspsaga.nvim/lua/lspsaga/hover.lua:155: in function 'open_floating_preview'
        ...ite/pack/packer/start/lspsaga.nvim/lua/lspsaga/hover.lua:324: in function 'handler'
        /usr/share/nvim/runtime/lua/vim/lsp.lua:1390: in function ''
        vim/_editor.lua: in function <vim/_editor.lua:0>

It is a Typescript project and I'm using Copilot, tsserver, tailwindcss and eslint as client attached to the lsp buffer.
When I dismiss this error by pressing enter, the hover window is shown but with no rendering enabled. To dismiss the hover I have to enter the window and :q it.

Steps to reproduce
Hover
Expected behavior
Hover window works
Neovim version (nvim -v)
NVIM v0.9.0-dev-843+g860fea1a3
lspsaga commit
01b9633aefd010f272d6c7e3d8293c44fcfe7696
Terminal name/version
Alacritty

because you build neovim with old code . use release stable neovim 0.9 or pull latest code of neovim build from 0.10


Handle partial dependency for ppe

Description

Checklist

[ ] Code style is correct (follows pylint and black guidelines)
[ ] Includes new or updated tests to cover the new feature
[ ] New features are properly documented (with an example if appropriate)
[ ] Includes a sample plot to visually illustrate the changes (only for plot-related functions)
[ ] Widget states have been properly saved (only for notebooks with widgets) see for details.

I have added the initial selection of which variables will enter the free_rvs, priors, and bounds.(this includes the partially dependent variables)..
Now,the next will be to calculate the initial guess followed by compiling the model. For the compile model step will there be any changes done to compile_logp for this case, bcoz once I go to minimize in optimize_pymc_model, I am getting an array of ones for the partial variable(which definitely cannot be true).

I can check this tomorrow. In the meantime maybe @ricardoV94 has some tips to offer.

For the compile model step will there be any changes done to compile_logp for this case, bcoz once I go to minimize in optimize_pymc_model, I am getting an array of ones for the partial variable(which definitely cannot be true).

Do you have some code I can look at where you are seeing the odd pattern (and even better, what you expected it to be)?

Thanks @ricardoV94 for looking into this...
One issues we are trying to work on is calculating the prior for partially dependent vars.
# One such example
import pymc as pm
import pandas as pd
import preliz as pz

cs_data = pd.read_csv('testdata/chemical_shifts_theo_exp.csv')
diff = cs_data.theo - cs_data.exp
cat_encode = pd.Categorical(cs_data['aa'])
idx = cat_encode.codes
coords = {"aa": cat_encode.categories}
with pm.Model(coords=coords) as model:
    # hyper_priors
    a = pm.Normal("a", mu=1, sigma=10)
    z = pm.HalfNormal("z", sigma=10)

    x = pm.Normal("x", mu=a, sigma=10, dims="aa")    # Need to calculate for this, we don't do this right now

    y = pm.Normal("y", mu=x[idx], sigma=z, observed=diff)

target = pz.Normal(mu=40, sigma=7)

prior, new_prior, pymc_string = pz.ppe(model, target)
print(prior)
print(pymc_string)

Before preliz was finding priors for the hyper-parameters but not intermediate parameters?

Currently preliz can find the values for intermediate parameters if the intermediate parameters fully depend on other RVs. If the dependence is partial, like for x = pm.Normal("x", mu=a, sigma=10, dims="aa"), the PreliZ is nor working as expected.

I can check this tomorrow. In the meantime maybe @ricardoV94 has some tips to offer.

Hey @aloctavodia , did you get time to see this one...


include not found

Describe the bug
I installed VS2019 and installed Opencv2 with vcpkg and have vcpkg integrate install successfully, but #include <opencv2/opencv.hpp >
#include < opencv2/imgproc/types_c.h>,
both of which will report an error saying not found, I have been bothered by this problem for a long time, it would be really good if someone answered me, here are the relevant images
To Reproduce

Environment

windows 10
vs2019:

Could you please replace opencv2 to opencv2.4\opencv2 and try again.

I'm not able to repro this issue, could you please provide your sample project.
Please make sure you use the usage provided by cmake:
set(OpenCV_DIR "${VCPKG_INSTALLED_DIR}/x64-windows/share/opencv2")
find_package(OpenCV REQUIRED)

Please replace opencv2 to opencv2.4\opencv2 and try again, thanks.

Please replace opencv2 to opencv2.4\opencv2 and try again, thanks.

Isn't the proper solution to manually add include\opencv2.4 to the include dirs when not using CMake?

Please replace to and try again, thanks.opencv2``opencv2.4\opencv2
The installed path of the header files is as follows:opencv2

Really thank you very much, I think I've solved this problem with your help, it's the header file path that is wrong

Really thank you very much, I think I've solved this problem with your help, it's the header file path that is wrong @Adela0814

Really thank you very much, too.I think I've solved this problem with your help, it's the header file path that is wrong @dg0yt


Compilation fails on Ubuntu 18.04 with undefined reference to libldap with "external" libcurl

I spent some time trying to fix it, but I haven't figured it out yet - I'll need more time.
Workaround: supply -DGOOGLE_CLOUD_CPP_CURL_PROVIDER=package to cmake.
$ cat /etc/issue
Ubuntu 18.04.1 LTS \n \l
$ cmake -H. -Bbuild-output
$ cd build-output
$ make
[...]
../../../../external/lib/libcurl.a(ldap.c.o): In function `Curl_ldap':
ldap.c:(.text+0xa6): undefined reference to `ldap_url_parse'
ldap.c:(.text+0x112): undefined reference to `ldap_set_option'
ldap.c:(.text+0x121): undefined reference to `ldap_set_option'
ldap.c:(.text+0x12f): undefined reference to `ldap_init'
ldap.c:(.text+0x14d): undefined reference to `ldap_simple_bind_s'
ldap.c:(.text+0x169): undefined reference to `ldap_set_option'
ldap.c:(.text+0x177): undefined reference to `ldap_simple_bind_s'
ldap.c:(.text+0x1b2): undefined reference to `ldap_search_s'
ldap.c:(.text+0x1d3): undefined reference to `ldap_first_entry'
ldap.c:(.text+0x209): undefined reference to `ldap_get_dn'
ldap.c:(.text+0x281): undefined reference to `ldap_memfree'
ldap.c:(.text+0x294): undefined reference to `ldap_first_attribute'
ldap.c:(.text+0x2c6): undefined reference to `ldap_get_values_len'
ldap.c:(.text+0x47a): undefined reference to `ldap_set_option'
ldap.c:(.text+0x48b): undefined reference to `ldap_set_option'
ldap.c:(.text+0x496): undefined reference to `ldap_simple_bind_s'
ldap.c:(.text+0x4bd): undefined reference to `ldap_err2string'
ldap.c:(.text+0x4e8): undefined reference to `ldap_msgfree'
ldap.c:(.text+0x502): undefined reference to `ldap_free_urldesc'
ldap.c:(.text+0x513): undefined reference to `ldap_unbind_s'
ldap.c:(.text+0x58a): undefined reference to `ldap_value_free_len'
ldap.c:(.text+0x592): undefined reference to `ldap_memfree'
ldap.c:(.text+0x5a7): undefined reference to `ber_free'
ldap.c:(.text+0x5b4): undefined reference to `ldap_value_free_len'
ldap.c:(.text+0x5bc): undefined reference to `ldap_memfree'
ldap.c:(.text+0x601): undefined reference to `ldap_next_attribute'
ldap.c:(.text+0x61e): undefined reference to `ber_free'
ldap.c:(.text+0x62c): undefined reference to `ldap_next_entry'
ldap.c:(.text+0x67b): undefined reference to `ldap_err2string'
ldap.c:(.text+0x6bb): undefined reference to `ldap_err2string'
ldap.c:(.text+0x729): undefined reference to `ldap_memfree'
ldap.c:(.text+0x73f): undefined reference to `ldap_memfree'
ldap.c:(.text+0x779): undefined reference to `ldap_set_option'
ldap.c:(.text+0x788): undefined reference to `ldap_set_option'
ldap.c:(.text+0x7ac): undefined reference to `ldap_set_option'
ldap.c:(.text+0x7bd): undefined reference to `ldap_set_option'
ldap.c:(.text+0x7ca): undefined reference to `ldap_simple_bind_s'
collect2: error: ld returned 1 exit status
google/cloud/storage/examples/CMakeFiles/storage_quickstart.dir/build.make:102: recipe for target 'google/cloud/storage/examples/storage_quickstart' failed
make[2]: *** [google/cloud/storage/examples/storage_quickstart] Error 1
CMakeFiles/Makefile2:10782: recipe for target 'google/cloud/storage/examples/CMakeFiles/storage_quickstart.dir/all' failed
make[1]: *** [google/cloud/storage/examples/CMakeFiles/storage_quickstart.dir/all] Error 2
make[1]: *** Waiting for unfinished jobs....

I just tested with:
cd ci/test-readme
sudo docker build -f Dockerfile.ubuntu .

and it compiled without problems.
I think libcurl automatically detects that libldap2 is installed, and compiles against it.  Our build scripts do not know that sometimes libcurl.a requires additional dependencies, and the build breaks.
I am going to test this idea and if it works I will disable the ldap functionality when building as an external package.

libcurl has the strange behavior of having everything enabled by default and then checking if the dependency exists and disabling the flag if it doesn't. You have to explicitly pass CURL_DISABLE_LDAP. See https://github.com/curl/curl/blob/master/CMakeLists.txt#L432
if(NOT CURL_DISABLE_LDAP)
# ...
    if(NOT HAVE_LDAP_H)
      message(STATUS "LDAP_H not found CURL_DISABLE_LDAP set ON")
      set(CURL_DISABLE_LDAP ON CACHE BOOL "" FORCE)

@remyabel yes.  In this case I think HTTP_ONLY=ON might be a more resilient fix, using external projects is great for development, and for testing, but I suspect most users will link against installed versions of libcurl when it comes time to use google-cloud-cpp in their projects. Curious about your thoughts on that actually.

Fixed by #1721.


LineChart 0.50.0 leftTitle and bottom title can't custom size

for example, I make the width as 110, but it doesn't work.
SideTitles(
        getTitlesWidget: (position, meta) => Container(
          width: 110,
          child: Text(
            position.toStringAsFixed(2),
          ),
        ),
        showTitles: true,
        interval: (state.maxY - state.minY) / 10,
        reservedSize: 10,
      ),

Screenshots

Versions

2.10.4
0.50.0

The size of drawing texts determines by reservedSize property. (There is no possibility to set different sizes for each titles)