x-forwarded-for does not set correct ip

Is this a BUG REPORT or FEATURE REQUEST? (choose one):
BUG REPORT

Kong Ingress controller version:
kong:0.13.1-centos
Kubernetes version (use kubectl version):
# kubectl version
Client Version: version.Info{Major:"1", Minor:"10", GitVersion:"v1.10.2", GitCommit:"81753b10df112992bf51bbc2c2f85208aad78335", GitTreeState:"clean", BuildDate:"2018-04-27T09:22:21Z", GoVersion:"go1.9.3", Compiler:"gc", Platform:"linux/amd64"}
Server Version: version.Info{Major:"1", Minor:"10", GitVersion:"v1.10.2", GitCommit:"81753b10df112992bf51bbc2c2f85208aad78335", GitTreeState:"clean", BuildDate:"2018-04-27T09:10:24Z", GoVersion:"go1.9.3", Compiler:"gc", Platform:"linux/amd64"}

Environment:

Cloud provider or hardware configuration:
OS (e.g. from /etc/os-release):
Kernel (e.g. uname -a):
Install tools:
Others:

[root@dfkjyph kong]# uname -a
Linux dfkjyph 3.10.0-514.el7.x86_64 #1 SMP Tue Nov 22 16:42:41 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
[root@dfkjyph kong]# cat /etc/redhat-release
CentOS Linux release 7.3.1611 (Core)
[root@dfkjyph kong]#

What happened:
Can't get the correct x-forwarded-for ip
What you expected to happen:
Set correct x-forwarded-for header for correct ip
How to reproduce it (as minimally and precisely as possible):
[root@dfkjyph kong]# cat dummy-application.yaml

apiVersion: extensions/v1beta1
kind: Deployment
metadata:
  name: http-svc
spec:
  replicas: 1
  selector:
    matchLabels:
      app: http-svc
  template:
    metadata:
      labels:
        app: http-svc
    spec:
      containers:
      - name: http-svc
        image: chinglinwen/echoserver:1.8
        ports:
        - containerPort: 8080
        env:
          - name: NODE_NAME
            valueFrom:
              fieldRef:
                fieldPath: spec.nodeName
          - name: POD_NAME
            valueFrom:
              fieldRef:
                fieldPath: metadata.name
          - name: POD_NAMESPACE
            valueFrom:
              fieldRef:
                fieldPath: metadata.namespace
          - name: POD_IP
            valueFrom:
              fieldRef:
                fieldPath: status.podIP

---

apiVersion: v1
kind: Service
metadata:
  name: http-svc
  labels:
    app: http-svc
spec:
  ports:
  - port: 80
    targetPort: 8080
    protocol: TCP
    name: http
  selector:
    app: http-svc

---
[root@dfkjyph kong]# cat dummy.ingress
apiVersion: extensions/v1beta1
kind: Ingress
metadata:
  name: http-svc
spec:
  rules:
  - host: dummy.service
    http:
      paths:
      - path: /
        backend:
          serviceName: http-svc
          servicePort: http
[root@dfkjyph kong]#

access is from browser ( kong have nodePort type service, port 80 on every node )
map a name specified in dummy ingress to the ip of any node
get the following html page

Hostname: http-svc-55dd675888-wbvqx

Pod Information:
	node name:	dfkjyph-46-122
	pod name:	http-svc-55dd675888-wbvqx
	pod namespace:	default
	pod IP:	<IP_ADDRESS>

Server values:
	server_version=nginx: 1.13.3 - lua: 10008

Request Information:
	client_address=<IP_ADDRESS>
	method=GET
	real path=/
	query=
	request_version=1.1
	request_uri=http://<IP_ADDRESS>:8080/

Request Headers:
	accept=text/html,application/xhtml+xml,application/xml;q=0.9,image/webp,image/apng,*/*;q=0.8
	accept-encoding=gzip, deflate
	accept-language=en,en-US;q=0.9,zh;q=0.8,zh-CN;q=0.7
	cache-control=no-cache
	connection=keep-alive
	host=<IP_ADDRESS>:8080
	pragma=no-cache
	upgrade-insecure-requests=1
	user-agent=Mozilla/5.0 (Windows NT 6.1; WOW64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/66.0.3359.181 Safari/537.36
	x-forwarded-for=<IP_ADDRESS>
	x-forwarded-host=dummy.service
	x-forwarded-port=8000
	x-forwarded-proto=http
	x-real-ip=<IP_ADDRESS>

Request Body:
	-no body in request-

<IP_ADDRESS> is node ip
expect x-forwarded-for be my desktop ip <IP_ADDRESS>
Anything else we need to know:

Isn't it related to https://kubernetes.io/docs/tutorials/services/source-ip/#source-ip-for-services-with-type-nodeport ? Did you try kubectl patch svc kong-proxy -p '{"spec":{"externalTrafficPolicy":"Local"}}

Facing same issue +1

+1

This is related to the Kubernetes network configuration.
Please refer https://kubernetes.io/docs/tutorials/services/source-ip and setup your service accordingly.
Thank you for opening this issue.

@joubertredrat, try setting trusted_ips and real_ip_header to use 'X-Forwarded-For' on Kong configuration, this can fix the x-real-ip:
trusted_ips: <IP_ADDRESS>/0,::0
real_ip_recursive: "on"
real_ip_header: X-Forwarded-For

https://docs.konghq.com/1.3.x/configuration/#trusted_ips

Hello @raittes , i have the same issue with your configuration, I think the proxy does not support modification

I have the same problem, too.
And I think it's important to me, In my Cluster, I will use kong to forward some requests to external services, and these external services will check x-forward-for header, Because they only support some ip address which in their white ip list.
We add our node ip to this white ip list, so I want to my request x-forward-for is a node ip.

Hey @Pierre-Malherbe
I got this plugin at kong-ingress-controller version: 2.1.x
You can read this #issue
And this is my plugin:
kind: KongPlugin
apiVersion: configuration.konghq.com/v1
config:
  functions:
    - ngx.var.upstream_x_forwarded_for=nil
metadata:
  annotations:
    global: 'true'
    kubernetes.io/ingress.class: kong
  name: egress-plugin-remove-x-forwarded-for
plugin: pre-function

With this config on pre-function, it will make X-Forwarded-For to be my node ip in my kubernetes cluster.

I have the same problem. How was it finally resolved?

I have the same problem. How was it finally resolved?

apiVersion: v1
kind: Service
metadata:
  annotations:
    konghq.com/override: cc     # you need this, cc is the name of kongingress
    kubernetes.io/ingress.class: kong   # ingressController
  name: cc
spec:
  ports:
  - port: 80
    protocol: TCP
    targetPort: 80
  selector:
      k8s-app: cc
      qcloud-app: cc
---
apiVersion: configuration.konghq.com/v1
kind: KongIngress
metadata:
  annotations:
    kubernetes.io/ingress.class: kong
  name: cc
route:
  preserve_host: false  # this must be false
upstream:
  host_header: cc.isd.com   # this is the finally host that client get
---
# ingress yaml detail
# ---
# deployment yaml detail


question about the settings-symmetrical index and mimic go

<!--
Thank you for reporting issues.
Since the developer is so busy, please understand that unimportant questions or requests may not be responded.

[Before adding an issue]
Please search and check if there are similar issues and questions, including those already closed.

[How to add a new issue]
**Title**
Make it possible to grasp the content of the issue by title only.

  Good: 'Resigns immediately on handicap games'
  Bad: 'some questions', 'a bug'

**Comments**
Please write the contents concisely.
Do not include multiple topics in one issue.

In the case of a bug, please describe the following contents.
+ Execution environment (AQ ver. / OS / CPU / GPU)
+ Reproduction procedure (in detail as much as possible)
+ How to fix it (if you have an idea)

**Labels** (able to attach from the right setting list)
'question': just a question
'enhancement': request for additional functions and improvement
'bug': a bug

Other labels will be judged by the developer, so the reporter should not use it.
--!>
What does this setting do?

This issue is closed due to lack of recent activity.


docs(style-guide): fix some typos

@johnpapa forwarded me this typos.

1 comment, otherwise LGTM

Liked most. Tweaked a few.


Expose the percentage of addresses that have staked in the past X time

Provide details of the % of addresses / coins held that have staked in the past X time against number of known addresses that have not.

not sure what this will look like or give valuable insight but there's only one way to find out.

@jambaboba

@sakdeniz
Daily/Monthly total staking graph for whole network would be nice.


Enable remote Killswitch

The current Kill Switch is system salt. If changed, all existing accounts will be unrecoverable, and thus all data as well. However, the current implementation explicitly disallows updating this via the API. And thus, it is not possible to easily disable the system!
A suggestion is to remove the limiting of changing settings, and instead add a piece of code, which will allow the System Administrator to update the Salt as a special case, whereby the keys for the Administrator is re-encrypted using the new Salt. This has the benefit, that the Administrator can use the standard API to control everything, including the Salt - without having to manually update the Database. Further, for sensitive setups, it will also allow a quick killing of the system.

The feature can be implemented relatively easily, and as part of the implementation, a simplification of the underlying data model can also be made whereby the modifiable flag is removed. The only value where the feature is used, is for the system salt.

A system wide kill switch is possible by accessing the database and changing the system salt. Any administrator can do this. Also an administrator could turn the system easily off by shutting the database down or deactivating the connection to the database. Exposing the killswitch to a wider audience could be more damaging due to misuse than to actually provide more benefit.
Instead a personal killswitch could be very interesting, because personal passwords are quite likely to become compromised. In that situation a user could deactivate his account easily - e.g. a button in the user profile - and only his access would be destroyed.

Turning question into task:

Add new Action to the processMember request called "invalidate"
Add Logic to the ProcessMemberService, which will ensure that the account is invalidated to the point of not being reparable.
Add testing of this, to ensure that the account is completely useless

With the latest commit, this feature should be enabled. Closing ticket now.


Read albedo over time (v1)

Purpose
Add in functionality to read in data files over time. This is largely copied from ClimaCoupler.jl's BCReader module.
Closes #243 (see for more info)
Broken down into smaller PRs: #264 (done), #280 (done)

[x] I have read and checked the items on the review checklist.

replaced by #264, #280


[UI] Adopt fundamental styles - view Diff preview

Target

[ ] Adopt the fundamental styles in Diff preview view

Use https://github.com/dirigiblelabs/ide-next as reference

Issue cloned to https://github.com/eclipse/dirigible/issues/1496


Update Star Citizen: Add UmU

This is draft PR for migrating to umu at least for star-citizen to resolve #151
Currently doesn't run (but does build) due to how umu is packaged in their flake
Star Citizen Updates:
• Add attr "useUmu" to support umu:
• Add attr protonPath to set umu's proton version:
This defaults to proton-ge-bin in nixpkgs. To always use the latest
proton-ge you can set this to "GE-Proton"
• Add attr protonVerbs to set proton verbs, only affects umu
Flake lock file updates:
• Updated input 'nixpkgs':
'github:NixOS/nixpkgs/02923630b89aa1ab36ef8e422501a6f4fd4b2016?narHash=sha256-OhysviwHQz4p2HZL4g7XGMLoUbWMjkMr/ogaR3VUYNA%3D' (2024-05-18)
→ 'github:NixOS/nixpkgs/9355fa86e6f27422963132c2c9aeedb0fb963d93?narHash=sha256-%2B%2BTYlGMAJM1Q%2B0nMVaWBSEvEUjRs7ZGiNQOpqbQApCU%3D' (2024-07-16)
• Added input 'umu':
'git+https://github.com/Open-Wine-Components/umu-launcher/?dir=packaging/nix&ref=refs/heads/main&rev=ce78913d68afafca5f695f3ebb1e6a706377480d&submodules=1' (2024-07-18)
• Added input 'umu/nixpkgs':
follows 'nixpkgs'

I have confirmed that this is now running correctly.


Fix for #192

Fix an XmlDataProvider test failure with Java 8.
Change XmlDataProvider KeyValueMap class to use List for items.
Unmarshall was failing in test dataProvider.getDataAsHashTable()
with java 8 (which changed to us JAXP 1.6).

@sebady, I am checking this too. Will comment soon.

@sebady, @mach6 LBetterTM!


v1.3 - Revamp predicate and add find parameter

see #58

Maybe we can delay this change for v1.3 after we finish all the features in 1.2?


Custom CheckpointManager for EventProcessorClient

Why is not possibile anymore to create custom CheckpointManager for eventhub processors?
In older sdk versions that was possible.
Is there any workaround to not use Blob storage?
Or that feature is going to be implemented in the future?

Hi @lommez.   The functionality that you're looking for exists on the EventProcessor<TPartition> primitive.
Generally speaking, EventProcessorClient was designed to provide a familiar API to that of the EventHubConsumerClient and offer an intuitive "step-up" experience for developers exploring Event Hubs as they move towards production scenarios.   For a large portion of our library users, that covers their needs well.   There's definitely a point, however, where your application requires more control to handle higher throughput or specialized needs that aren't shared by a large group - that's where the EventProcessor<TPartition> is intended to help.
The EventProcessor<TPartition> fills a similar role as the EventProcessorClient, but offers native batch processing, extension points utilizing different storage providers, more control over load balancing, and a lighter, less opinionated API.   The caveat is that this comes in the form of an abstract base, which needs to be extended and the core “handler” activities implemented via override.  More on the design and philosophy behind this can be found [here].

Hi @jsquire
Thanks so much for your detailed reply!

My pleasure.   If you decide to extend the EventProcessor<TPartition>,  we'd be very interested in your experience and feedback to help us refine any rough areas.
I'm going to close this out, but please feel free to reopen if there was something further that you wanted to discuss in the context of this issue.


Produced AIGER file contains two different names for the same latch

hi again,
Consider the following verilog file:
verilog.v.zip
When translating into AIGER by executing
read_verilog verilog.v
synth -flatten
abc -g AND
write_aiger -ascii -symbols hoho.aag

the resulting AIGER assigns two different names for latch l43 (in the symbols table)
hoho.aag.zip
l43 __qdead
o0 bad
l43 bad

(l30 is also repeated twice)
I don't know if that is a bug or not, but original AIGER tools from Armin fail on such files, which is strange.
Thanks.

The wires bad and __qdead definitely are the same net, so it seems like it is correct for this latch to have two symbols:
assign bad = __qdead;

but original AIGER tools from Armin fail on such files

Interesting. I've now changed the behavior of write_aiger in c365e33 to consolidate multiple symbols for the same object and print them in one line (with blanks separating the individual symbols). At least aigbmc from the AIGER package seems to accept this syntax.
Looking at your verilog input I would guess that you would like to use this to create specifications for reactive synthesis problems (some of your inputs have names that start with controllable_). Cool! Afaict the new behavior should be compatible with the "Extended AIGER Format for Synthesis", since it is possible that a latch or output has multiple symbols, but if an input has multiple symbols that would indicate a driver-driver conflict and thus an invalid circuit specification, therefore it should be guaranteed that all i* symbols only have one name. (So the controllable_* names will never be accidentally prefixed with another symbol name followed by a blank.)

thanks, it works now!
(yes, i hopefully use if for my tool at SYNTCOMP, but in a very simple scenario --- to generate AIGER for a state machine described in verilog)


Customizer for byte[] to bytes

Fixes #567

Please reopen, if there is still need to be merged.

I think the only thing left in this is a documentation update and one test code to make sure that bytes() actually works. We do a lot of testing on memoryview but we do not specifically test "bytes" and "bytearray".   Perhaps I should just add that as a suite to the test battery.


219 office agents

Update styling around office images
Test URLs:

Before: https://main--hsf-commonmoves--hlxsites.hlx.page/offices
After: https://219-office-agents--hsf-commonmoves--hlxsites.hlx.page/offices
After: https://219-office-agents--hsf-commonmoves--hlxsites.hlx.page/offices/belmont

Changes LGTM but we need to discuss about the complete flow once, how offices.xlsx will get populated


WFLY-18306 Default Infinispan remote-timeout should not be less than the default lock-timeout

https://issues.redhat.com/browse/WFLY-18306

Do we really need a schema bump?  Unless we update the parsers to be schema aware regarding default values this change actually impacts all of the older schema versions.  Maybe just the model bump so tranformers can at least be correct?

Do we really need a schema bump? Unless we update the parsers to be schema aware regarding default values this change actually impacts all of the older schema versions. Maybe just the model bump so tranformers can at least be correct?

Technically, the default value as defined in the XSD would be wrong otherwise - but I get your point, that configuration migrated from an older version will have the new default applied - contrary to the default value defined in those schemas.
So, maybe the XSD version bump is unnecessary?

Thanks @pferraro @darranl and @rhusar
If it turns out we don't need the 17.1 api version we should tweak this before we release WF 30.


Auto generate vectorstore collection on application startup

During installation, I had problems as I expected the collection in the vectorstore to be created automatically.
I would like to propose inserting the auto-generation of the vectorstore in an after_initialize.
Is this a valid solution in your opinion? I can do a PR if you think it is a good solution.
Below is a Proof of Concept of the solution:
module MyRailsApplication
  class Application < Rails::Application
    # ....
    # Run vectorsearch initialization after application is loaded.
    config.after_initialize do
      provider = LangchainrbRails.config.vectorsearch
      default_schema = provider.get_default_schema
      provider.create_default_schema if !default_schema ||  default_schema.dig('status') != 'ok'
    end
  end
end

@gregogalante I think it would be a good idea to implement this :)


Fixed role remove icon displacement

Previously the role remove icon would be placed in the center of the role on a user's popup, now it is nicely displayed on the side like in normal discord. There is of course a matter of preference to whether or not you like the way the roles look without hovering over them. Personally, I think they look nice and the subtle change from hovering over them is satisfying.
Before without hovering:

Before hovering over the role:

After without hovering:

After hovering over the role:

Fixed for a far better solution since discord FINALLY added a way to determine if you have perms or not.


TextInput onChange -> text generated an Object

Hi,
i have a Problem with my TextInput
If i change the Text in the Inputfield it generates an Object. Why generated an Object?
MYCODE

WARNING if i tipping in the Inputfield

ERROR if i show the text in a textView

What is wrong?
Thanks for helping!

My Problem was , i use the onChange function, not the onChangeText function!
😤


"Select All" in Variable Explorer for DataFrames

Hi,
thanks for the great Spyder 4 release.
I have noticed that in contrast to Spyder 3, when opening a pandas DataFrame (with index and column names) in the variable explorer and hitting "Select All", this will not copy the index / column names. For copying and pasting to external applications it would be great if the old behaviour from Spyder 3 that also copied index and column headers could be re-established.

Thanks for reporting. This is a valid request.
@dalthviz, please take a look at this one.


environment building issues

the wheel for detectron2 and pytorch3d arent building and this is likely due to usage of torch 2.2, could you send me your conda env.yaml?

nvm, i was able to install using conda:
conda install -y conda-forge::detectron2
conda install -y pytorch3d::pytorch3d
but init.sh is throwing errors

what's the gcc version you are using? make sure to use a version >=9.2


Unexpected directive 'ScrollTo' imported by the module ...

When trying to include ScrollTo into the NgModule's imports array

I'm unable to reproduce the problem.
Can you attach your package.json?

package.json.txt

I've created project's module and add ScrollTo into declarations - now it's working
//scrollto.module.ts
import {NgModule} from "@angular/core";
import {ScrollTo} from "ng2-scroll-to";
@NgModule({
exports: [
ScrollTo
],
declarations:[
ScrollTo
]
})
export class ScrollToModule {
}
//app.module.ts
....
import {ScrollToModule} from "./scrollto.module";
.....
@NgModule({
......
imports: [
....
ScrollToModule,
....


Please publish 2.0.6

An extremely critical fix has been merged for 2.0.6, but 2.0.6 has not yet been released.
Over a month since last release, and over 2 weeks since the fix was merged.
https://github.com/florent37/SingleDateAndTimePicker/pull/152
Please publish 2.0.6, as without the fix, this library is not usable for anyone who tries to use it for apps below API 24, as they 100% guaranteed crash every single time

done ;)
you have the 2.0.6 and 2.0.7

@florent37 That 2.0.6 version isn't shown in releases, why?


Deselect tests to run

Hey there!
You can selectively run some tests by specifying their directory, but is there a way to deselect some tests and keep the others using minitest?
Thanks!

@eddbrown I added exclude pattern in this PR https://github.com/KnapsackPro/knapsack_pro-ruby/pull/72 and I've just released a new version of knapsack_pro gem.
Here is documentation for exclude pattern:
https://github.com/KnapsackPro/knapsack_pro-ruby#how-to-exclude-tests-from-running-them


Hana seattle data

Created files with Seattle resource data in YAML. Each file represents a unique resource and location (resources with multiple locations are split into separate files). These files will be used to populate the database of resource information.

LGTM!


[BitSail][Connector]Migrate HBase connector (Source+Sink) from legacy to v1 interface

Signed-off-by:
Pre-Checklist
Note: Please complete ALL items in the following checklist.

[x] I have read through the CONTRIBUTING.md documentation.
[x] My code has the necessary comments and documentation (if needed).
[x] I have added relevant tests.

Purpose

Some description about what this PR wants to do.
Approaches

Some description about how this PR achives the purpose.
Related Issues

e.g. Close #796
New Behavior (screenshots if needed)

N/A

General comment: Could you add unit test for new created classes and integration test for HBase Source?

The License header check fails. It mentions one of new created file doesn't have license. Please correct it.

The current commit (18th) already has 10+ commits behind bytedance:master branch. Please sync your branch with bytedance:master regularly or once your PR is good to merge.

The current commit (18th) already has 10+ commits behind bytedance:master branch. Please sync your branch with bytedance:master regularly or once your PR is good to merge.

Sure. Just synced the branch update to date.

Hi @hk-lrzy @lujg, if there are no other comments, can you please approve this MR? Thanks!


sequences_exhausted does not take account of all sequences

Hello,
The sequences_exhausted does not take acocunt of all sequences. Only sequences that are linked to a serial are taken in account. It's quite easy to take account of the other sequences, but of course we are not able to link the sequences to the real maximum value allowed for storing in a column. So, we'll have to trust the DBA/developer with the MAXVALUE set at sequence creation.

Fixed


openstack-ardana: move root_mount to role defaults

Following @rtamalin suggestion, this change moves root_mount variable to
defaults.yml as it makes more sense when this variable is used to define
resize_tools which is also in defaults.yml

Tested in: https://ci.suse.de/blue/organizations/jenkins/openstack-ardana-bootstrap-clm/detail/openstack-ardana-bootstrap-clm/1730/pipeline


Message in Azure portal about registration required

[Enter feedback here]
When we want to use this feature in the portal, it still shows us the 'Capacity reservation group is in public preview. To create a capacity reservation group, you must register your subscription.' message with a Learn more link that redirects to this page. However, this page does not provide any information on this requirement. Is it still needed to register for this feature as it is public preview now?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: d0337435-b6d6-58cc-fc5c-e7ccf1456423
Version Independent ID: e1e011f5-a2f9-54a9-0561-962bd8222de5
Content: On-demand Capacity Reservation in Azure (preview) - Azure Virtual Machines
Content Source: articles/virtual-machines/capacity-reservation-overview.md
Service: virtual-machines
GitHub Login: @vargupt
Microsoft Alias: vargupt

@gjongeneel
Thanks for your Question! We are currently investigating and will get back on this.

@gjongeneel
As this feature is in public preview there is no registration needed. This feature is available to all customers without any sub registration.
When we want to use this feature in the portal, it still shows us the 'Capacity reservation group is in public preview.
This is fixed by the product now, you should not see this anymore.
Hope this helps.

Hope the provided information is helpful.
We will now close this issue. If there are further questions regarding this, please tag me in a comment. I will reopen it and we will continue the discussion.


BuildConfig.java is missing

Hello,
I am not able to see BuildConfig.java in "frostwire" github repository. Please let me know where I can find this file.
I am trying to set up frostwire android client in Android Studio and getting compile time errors.
Thanks,
Unni

this file is generated during the build process.


Resetting the Moto_server state after completion of pytest cases.

Greetings Team,
I was able to setup moto_server with latest version and had my tests use the moto_server. I have multiple tests using aws services like Dynamodb, secretmanager with sometimes same tablename/secret etc.. So when I run it together, I am getting ResourceInUse etc.. exceptions. I was wondering if there is a way to reset the state of the moto_server post every run/test. Apologies for a basic question as I am a new user of moto.
Thanks
Bala

Hi @Balasundaram, welcome to Moto! You can make a POST-request to http://localhost:5000/moto-api/reset (assuming you're using the default server/port) to remove all the data.


 It will also act as a sort of Q-reduction. For LZChess they wrote a separate function that returns the real current Q instead of Q including virtual losses for this.

minigo-default-q v minigo-dynamic-q (168/500 games)
board size: 19   komi: 7.5
                   wins              black         white       avg cpu
minigo-default-q     34 20.24%       15 17.86%     19 22.62%     91.69
minigo-dynamic-q    134 79.76%       65 77.38%     69 82.14%     93.70
                                     80 47.62%     88 52.38%

I think this is a good idea - dynamic parent Q will reduce the impact of a noisy parent Q measurement,  lessening the likelihood of explore1/explore-all behavior. Also agreed with ducky's point about vloss interaction.
The right way to do this might be to use the vloss counter in the calculations, instead of mutating the W and N numbers.
(I.e. instead of Q = W / N where W and N have been mutated, don't mutate and instead do Q = (W - #vlosses) / (N + #vlosses)

One thing I don't like about my implementation.
node.child_Q[move] != node.child[move].Q()
Should I maybe move this definition under a new property name? dynamic_Q? dynamic_child_Q?

+1 for keeping child_Q as child_W(i)) / (1 + child_N(i) and adding a new property. I don't have a strong preference for either dynamic_Q or dynamic_child_Q.

what are we doing with this?  It seemed like a win in selfplay but was weaker vs Leela.  Do we add it for v10 or table it for future experimental runs?

weaker vs Leela ? That's weird. Did you do any experiment with fpu reduction btw ?


Vevo HTTP Error 500 is back.

Please follow the guide below

You will be asked some questions and requested to provide some information, please read them carefully and answer honestly
Put an x into all the boxes [ ] relevant to your issue (like that [x])
Use Preview tab to see how your issue will actually look like

Make sure you are using the latest version: run youtube-dl --version and ensure your version is 2016.05.01. If it's not read this FAQ entry and update. Issues with outdated version will be rejected.

[x] I've verified and I assure that I'm running youtube-dl 2016.05.01

Before submitting an issue make sure you have:

[x] At least skimmed through README and most notably FAQ and BUGS sections
[ ] Searched the bugtracker for similar issues including closed ones

What is the purpose of your issue?

[x] Bug report (encountered problems with youtube-dl)
[ ] Site support request (request for adding support for a new site)
[ ] Feature request (request for a new functionality)
[ ] Question
[ ] Other

The following sections concretize particular purposed issues, you can erase any section (the contents between triple ---) not applicable to your issue

youtube-dl --verbose http://www.vevo.com/watch/jennifer-lopez/Aint-Your-Mama/USSM21600795
[debug] System config: []
[debug] User config: []
[debug] Command-line args: [u'--verbose', u'http://www.vevo.com/watch/jennifer-lopez/Aint-Your-Mama/USSM21600795']
[debug] Encodings: locale UTF-8, fs utf-8, out UTF-8, pref UTF-8
[debug] youtube-dl version 2016.05.01
[debug] Python version 2.7.9 - Darwin-13.4.0-x86_64-i386-64bit
[debug] exe versions: none
[debug] Proxy map: {}
[Vevo] USSM21600795: Downloading video info
ERROR: Unable to download info: HTTP Error 500: Internal Server Error (caused by HTTPError()); please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; type  youtube-dl -U  to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.
File "/usr/local/bin/youtube-dl/youtube_dl/extractor/common.py", line 388, in _request_webpage
return self._downloader.urlopen(url_or_request)
File "/usr/local/bin/youtube-dl/youtube_dl/YoutubeDL.py", line 1942, in urlopen
return self._opener.open(req, timeout=self._socket_timeout)
File "/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/urllib2.py", line 437, in open
response = meth(req, response)
File "/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/urllib2.py", line 550, in http_response
'http', request, response, code, msg, hdrs)
File "/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/urllib2.py", line 475, in error
return self._call_chain(*args)
File "/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/urllib2.py", line 409, in _call_chain
result = func(*args)
File "/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/urllib2.py", line 558, in http_error_default
raise HTTPError(req.get_full_url(), code, msg, hdrs, fp)
If the purpose of this issue is a site support request please provide all kinds of example URLs support for which should be included (replace following example URLs by yours):

Single video: https://www.youtube.com/watch?v=BaW_jenozKc
Single video: https://youtu.be/BaW_jenozKc
Playlist: https://www.youtube.com/playlist?list=PL4lCao7KL_QFVb7Iudeipvc2BCavECqzc

Description of your issue, suggested solution and other information
HTTP Error 500 again is creeping up from before.

Thank you


Flutter fails to render the last saved changes made to code after the app is relaunched.

Steps to Reproduce

Create a fresh flutter project from flutter stable channel v3.7.9.
Run the app
Make a simple text change, say from A to B
Close the app and relaunch again (not force stop or removing app from recents)
The updated data is not rendered but shows the previous data, (Shows A, instead of B)
If you do ctrl save or save the file in which u made the change, the UI will then show B.

Expected results:
Should show B
Actual results:
Shows A instead of B
Lemme know if i need to provide any additional information. I have attached verbose logs in the pastebin

Code sample
You can recreate the code yourself as well by creating flutter project from stable branch
import 'package:flutter/material.dart';

void main() {
  runApp(const MyApp());
}

class MyApp extends StatelessWidget {
  const MyApp({super.key});

  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      title: 'Flutter Demo',
      theme: ThemeData(

        primarySwatch: Colors.blue,
      ),
      home: const MyHomePage(title: 'Flutter Demo Home Page'),
    );
  }
}

class MyHomePage extends StatefulWidget {
  const MyHomePage({super.key, required this.title});

  final String title;

  @override
  State<MyHomePage> createState() => _MyHomePageState();
}

class _MyHomePageState extends State<MyHomePage> {
  int _counter = 0;

  void _incrementCounter() {
    setState(() {

      _counter++;
    });
  }

  @override
  Widget build(BuildContext context) {

    return Scaffold(
      appBar: AppBar(

        title: Text(widget.title),
      ),
      body: Center(

        child: Column(

          mainAxisAlignment: MainAxisAlignment.center,
          children: <Widget>[
            const Text(
              'flutter ui not updated',
            ),
            Text(
              '$_counter',
              style: Theme.of(context).textTheme.headlineMedium,
            ),
          ],
        ),
      ),
      floatingActionButton: FloatingActionButton(
        onPressed: _incrementCounter,
        tooltip: 'Increment',
        child: const Icon(Icons.add),
      ), // This trailing comma makes auto-formatting nicer for build methods.
    );
  }
}

Logs
Verbose logs:
https://katb.in/verboselogs
Flutter analyze:
@Milind ➜ hello  flutter analyze
Analyzing hello...
No issues found! (ran in 2.7s)

flutter doctor -v:
@Milind ➜ ~ flutter doctor -v
[✓] Flutter (Channel stable, 3.7.9, on Microsoft Windows [Version 10.0.22621.1485], locale en-IN)
    • Flutter version 3.7.9 on channel stable at C:\flutter
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 62bd79521d (4 days ago), 2023-03-30 10:59:36 -0700
    • Engine revision ec975089ac
    • Dart version 2.19.6
    • DevTools version 2.20.1

[✓] Windows Version (Installed version of Windows is version 10 or higher)

[✓] Android toolchain - develop for Android devices (Android SDK version 33.0.1)
    • Android SDK at C:\Users\Lenovo\AppData\Local\Android\Sdk
    • Platform android-33-ext4, build-tools 33.0.1
    • ANDROID_SDK_ROOT = C:\Users\Lenovo\AppData\Local\Android\Sdk
    • Java binary at: C:\Program Files\Android\Android Studio\jbr\bin\java
    • Java version OpenJDK Runtime Environment (build 11.0.15+0-b2043.56-9505619)
    • All Android licenses accepted.

[✓] Chrome - develop for the web
    • Chrome at C:\Program Files\Google\Chrome\Application\chrome.exe

[!] Visual Studio - develop for Windows (Visual Studio Community 2022 17.4.4)
    • Visual Studio at C:\Program Files\Microsoft Visual Studio\2022\Community
    • Visual Studio Community 2022 version 17.4.33213.308
    ✗ Visual Studio is missing necessary components. Please re-run the Visual Studio installer for the "Desktop
      development with C++" workload, and include these components:
        MSVC v142 - VS 2019 C++ x64/x86 build tools
         - If there are multiple build tool versions available, install the latest
        C++ CMake tools for Windows
        Windows 10 SDK

[✓] Android Studio (version 2022.1)
    • Android Studio at C:\Program Files\Android\Android Studio
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 11.0.15+0-b2043.56-9505619)

[✓] VS Code, 64-bit edition (version 1.77.0)
    • VS Code at C:\Program Files\Microsoft VS Code
    • Flutter extension version 3.60.0

[✓] Connected device (4 available)
    • 2109119DI (mobile) • 417812e0 • android-arm64  • Android 13 (API 33)
    • Windows (desktop)  • windows  • windows-x64    • Microsoft Windows [Version 10.0.22621.1485]
    • Chrome (web)       • chrome   • web-javascript • Google Chrome 111.0.5563.147
    • Edge (web)         • edge     • web-javascript • Microsoft Edge 111.0.1661.62

[✓] HTTP Host Availability
    • All required HTTP hosts are available

! Doctor found issues in 1 category.

Screen Recording:
https://user-images.githubusercontent.com/45682747/229568632-427116ad-e22e-4c91-a2f8-10748ae306f6.mp4

Thanks for clarifying 👍👍


TextField in iOS occurs bug when using system built-in [Chinese, Simplified] keyboard.

Bug summary
When using system built-in [Chinese, Simplified] keyboard, user click one key, TextField will show more than 2 chars(at least).
Screenshot

Demo (is very small)
void main() {
  runApp(MyApp());
}

class MyApp extends StatelessWidget {
  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      title: 'TextField input Chinese',
      theme: ThemeData(
        primarySwatch: Colors.blue,
        visualDensity: VisualDensity.adaptivePlatformDensity,
      ),
      home: MyHomePage(),
    );
  }
}

class MyHomePage extends StatefulWidget {
  @override
  _MyHomePageState createState() => _MyHomePageState();
}

class _MyHomePageState extends State<MyHomePage> {
  @override
  Widget build(BuildContext context) {
    return Scaffold(
      appBar: AppBar(
        title: Text('TextField input Chinese'),
      ),
      body: TextField(
        onChanged: (value) => print(value),
      ),
    );
  }
}

iOS version
13.5

Flutter version
Flutter 1.19.0-4.3.pre • channel beta • https://github.com/flutter/flutter.git
Framework • revision 8fe7655ed2 (6 days ago) • 2020-07-01 14:31:18 -0700
Engine • revision 9a28c3bcf4
Tools • Dart 2.9.0 (build 2.9.0-14.1.beta)

Flutter doctor
Doctor summary (to see all details, run flutter doctor -v):
[✓] Flutter (Channel beta, 1.19.0-4.3.pre, on Mac OS X 10.15.5 19F101, locale
    zh-Hans-CN)

[✓] Android toolchain - develop for Android devices (Android SDK version 29.0.2)
[✓] Xcode - develop for iOS and macOS (Xcode 11.5)
[✓] Chrome - develop for the web
[✓] Android Studio (version 3.6)
[!] IntelliJ IDEA Community Edition (version 2019.3.4)
    ✗ Flutter plugin not installed; this adds Flutter specific functionality.
[✓] VS Code (version 1.46.1)
[✓] Connected device (4 available)

! Doctor found issues in 1 category.

Hi @weichengwu
i can reproduce this on beta channel and not issue on dev channel

flutter doctor -v
[✓] Flutter (Channel dev, 1.20.0-3.0.pre, on Mac OS X 10.15.5 19F101, locale en-GB)
    • Flutter version 1.20.0-3.0.pre at /Users/taha/Code/flutter_dev
    • Framework revision 0af027f805 (4 days ago), 2020-07-04 12:19:20 -0700
    • Engine revision a751393804
    • Dart version 2.9.0 (build 2.9.0-20.0.dev 22da8934ac)

[✓] Android toolchain - develop for Android devices (Android SDK version 30.0.0)
    • Android SDK at /Users/taha/Code/sdk
    • Platform android-30, build-tools 30.0.0
    • ANDROID_HOME = /Users/taha/Code/sdk
    • Java binary at: /Applications/Android
      Studio.app/Contents/jre/jdk/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b3-6222593)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 11.5)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Xcode 11.5, Build version 11E608c
    • CocoaPods version 1.9.3

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 4.0)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin version 47.1.2
    • Dart plugin version 193.7361
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b3-6222593)

[✓] VS Code (version 1.46.1)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.12.1

[✓] Connected device (3 available)
    • Taha’s iPhone (mobile) • 00008020-001059882212002E • ios            • iOS 13.5.1
    • Web Server (web)       • web-server                • web-javascript • Flutter Tools
    • Chrome (web)           • chrome                    • web-javascript • Google Chrome
      83.0.4103.116

• No issues found!

Can you please upgrade to dev channel and try again and confirm this doesn't exist for you in dev channel?
Execute following
flutter channel dev
flutter upgrade --force
flutter doctor -v
Thank you

Hi @weichengwu
i can reproduce this on beta channel and not issue on dev channel
flutter doctor -v
Can you please upgrade to dev channel and try again and confirm this doesn't exist for you in dev channel?
Execute following
flutter channel dev
flutter upgrade --force
flutter doctor -v
Thank you

Thank you, it won't happen in dev channel.


To specify multiple versions, prefer the versions array

💡 Summary
Noticed that the affected object was getting repeated for each version number.
https://github.com/cisagov/vulnrichment/blob/develop/2024/30xxx/CVE-2024-30378.json#L245-L326
{
            "cpe": "cpe:2.3:o:juniper:junos:21.1:-:*:*:*:*:*:*",
            "vendor": "juniper",
            "product": "junos",
            "versions": [
              {
                "status": "affected",
                "version": "21.1"
              }
            ],
            "defaultStatus": "unknown"
          },
          {
            "cpe": "cpe:2.3:o:juniper:junos:21.2:-:*:*:*:*:*:*",
            "vendor": "juniper",
            "product": "junos",
            "versions": [
              {
                "status": "affected",
                "version": "21.2"
              }
            ],
            "defaultStatus": "unknown"
          },

versions array could be used instead.
Motivation and context
This would reduce the size of the ADP data.
Implementation notes
Example output that utilizes the version array
{
            "cpe": "cpe:2.3:o:juniper:junos:21.1:-:*:*:*:*:*:*",
            "vendor": "juniper",
            "product": "junos",
            "versions": [
              {
                "status": "affected",
                "version": "21.1"
              },
              {
                "status": "affected",
                "version": "21.2"
              },
              {
                "status": "affected",
                "version": "21.3"
              }
            ],
            "defaultStatus": "unknown"
          }

This could also be simplified further by using version=21.1 and lessThanOrEqual=22.3
Acceptance criteria
How do we know when this work is done?

[ ] Criterion

@prabhu Thank you for the report! We intend to revisit the way the version data is organized and support a more flexible and concise encoding of versions and bounds. Currently we do not have an ETA on this feature but will update this ticket as we make progress towards that goal.

@prabhu we have implemented the versions array on our end. We are still making progress and need to support having multiple CPEs in an affected entry. In your example, one affected entry might have all three of the individually versioned CPEs, along with the array of versions that match. We continue to make progress there. For completeness, I'm going to leave this open for the moment until we support multiple CPEs in a single affected entry.

I believe this is resolved per @jwoytek-cisa's comment above, at least for going forward. There are a few ways to do this correctly, so we'll have to weigh the value of going back and "fixing" the style in this issue for historical ADPs.


Update tests suites and CI

Hello!

Type: code quality
Link to issue:

In raising this pull request, I confirm the following:

[ ] I have checked that another pull request for this purpose does not exist
[ ] I wrote some tests for this PR
[ ] I updated the CHANGELOG

Small description of change:
Thanks

Related #2111

Related #2111


README updates

This PR:

[x] Updates dead links
[x] Updates header sections (add space after last #)

Coverage remained the same at 99.564% when pulling eec69b7cdccc8fa95c35fc86d11640ca4efb1159 on wnuqui:misc/update-readme into 796beebc909a007fc476d37474d93d4f9ce3d912 on PromisePay:master.

This the updated README and this is the current one .
In the updated README,

headers are fixed, and
dead links are updated

@terenceponce please review!

Coverage remained the same at 99.564% when pulling eec69b7cdccc8fa95c35fc86d11640ca4efb1159 on wnuqui:misc/update-readme into 796beebc909a007fc476d37474d93d4f9ce3d912 on PromisePay:master.

Thanks @terenceponce !


Detect 4 digit version numbers

Add the ability to update to 4 digit version numbers if needed.

4 digits will never be used according to SemVer


BUG Strict null check not warning about possibly undefined class members

TypeScript Version:  2.2.1
Code
class MyClass {
    public request: {} | null;
}
const c = new MyClass();
 // with strict null check the type here is {} | null, but its actually undefined!
c.request

Expected behavior:
The type-checker should warn that request is undefined if no value was set in the member declaration or in the constructor
Actual behavior:
TS treating the member as the declared type, even its not initialize

Heh, another one issue https://github.com/Microsoft/TypeScript/issues/14929

Duplicate of #8476 which is very difficult to solve.

Duplicate of #8476 which is very difficult to solve.

"Very difficult to solve" should not have been the reason to close #8476

any comments should go to #8476


Add high res launcher icons

Was getting annoyed by the grainy launcher icon on higher res screens.
Before:

After:

Notice that the new icons, generated by Android Asset Studio, are slightly smaller, think this is probably okay. They are the same size as Instagram's icon :)

Should this be going into 2.24? Don't know how much we care about being conservative with what we sneak in after code-freeze, but this seems borderline.

(Happy to merge it if that's not something we care about enforcing, definitely a nice add).

Hey,
This isn't the new icon, is it? I thought we had one with the other blue?
On Wed, Oct 28, 2015 at 9:06 AM, Aliza Stone<EMAIL_ADDRESS>wrote:

Merged #752 https://github.com/dimagi/commcare-odk/pull/752.
—
Reply to this email directly or view it on GitHub
https://github.com/dimagi/commcare-odk/pull/752#event-447966524.


chore(consensus): add error for state machine and shc disagreeing

update handle_state_machine_vote

This change is

[!WARNING]
This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

#2956  👈 (View in Graphite)
#2955
#2954
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Merge activity

Dec 26, 7:08 AM EST: A user started a stack merge that includes this pull request via Graphite.


Update manage-indicators.md

Checked that Creating indicators for  files is available for MDE P1 So added that to the applies to section.

@JohanFreelancer9 Please copy review

@denisebmsft Please merge this PR, Thanks


adapting to reMarkable 2

reMarkable 2 uses 32bit graphics ... could this be implemented? I'm happy to help with testing.
I guess having a command line option (-16 / -32) could be a good way to switch.
And thanks for this very useful piece of software!

Unfortunately, it's not super simple to do. The code currently passes around an image.Gray16 for performance (and even that doesn't perform super well), so we'd have to come up with a nice abstraction over image.Gray16 and a made-up image.Gray32. That's by no means impossible, but without owning the device myself I don't really I want to. The iteration cycle would just be too slow. I also don't really use even my reMarkable 1 anymore. So my own need for this project has been basically zero.
It never quite made it out of the PoC phase of its existence and it might just be time to officially freeze it. There are alternatives though and it would always be possible for someone to fork srvfb and adopt it.


Remove roadmap from 2015

The roadmap has many issues:

It is outdated and (obviously) does not reflect the current state.
It implies that there is a unique roadmap for the whole project. However, practically each contributor has their own roadmap.
The embedded video is likely a GDPR cookie violation.

Fix all issues by removing it.
I think in the future it might be better for contributor(s) to share roadmaps not on this project's website, but on the appropriate mailing list, a blog, or a GitHub gist, or somewhere else.
Also, general bitcoin education content is better hosted on websites dedicated to hosting educational content.

Hi, please forgive me for stacking
just a couple of small immediate thoughts
On Mon, Jan 17, 2022 at 12:32 PM MarcoFalke @.***>
wrote:

The roadmap has many issues:

It is outdated and (obviously) does not reflect the current state.

Why not just append a text telling this?

It implies that there is a unique roadmap for the whole project.
However, practically each contributor has their own roadmap.

Present this as a feature. Again,
why not just append a text telling this?

The embedded video is likely a GDPR cookie violation.

Fix all issues by removing it.
I think in the future it might be better for contributor(s) to share
roadmaps not on this project's website, but on the appropriate mailing
list, a blog, or a GitHub gist, or somewhere else.
Also, general bitcoin education content is better hosted on websites
dedicated to hosting educational content.
You can view, comment on, or merge this pull request online at:
https://github.com/bitcoin-core/bitcoincore.org/pull/848
Commit Summary

ac13200
https://github.com/bitcoin-core/bitcoincore.org/pull/848/commits/ac13200468e36e0b8b203db82e359ef4ee65874f
Remove roadmap from 2015

File Changes
(5 files https://github.com/bitcoin-core/bitcoincore.org/pull/848/files)

D _posts/en/posts/2015-12-07-ml-capacity-roadmap.md
https://github.com/bitcoin-core/bitcoincore.org/pull/848/files#diff-12a08673764ec834adcb9967ca9a0e6dc7344bd4ba769688efdc17682f71fead
(93)
D _posts/en/posts/2015-12-14-segregated-witness.md
https://github.com/bitcoin-core/bitcoincore.org/pull/848/files#diff-762e6b9ed99cbc93991726126490ae145bec29eed701234229eade53ece8e059
(18)
D _posts/en/posts/2015-12-21-capacity-increases.md
https://github.com/bitcoin-core/bitcoincore.org/pull/848/files#diff-c64a1b477b29c78bbf5b874bfc347f42e5891258f2e2a7a97c6d301ba8ea22f3
(21)
D _posts/en/posts/2015-12-23-capacity-increases-faq.md
https://github.com/bitcoin-core/bitcoincore.org/pull/848/files#diff-0f8f35d35d72b325486c730133a823b2a2460c73ff99be2a19d4d07504b2d678
(199)
D assets/images/ok-48.png
https://github.com/bitcoin-core/bitcoincore.org/pull/848/files#diff-08b421529fce548c902d809c3bffb9f6bcfa82fa83fef2d4c082df10d2a8a79b
(0)

Patch Links:

https://github.com/bitcoin-core/bitcoincore.org/pull/848.patch
https://github.com/bitcoin-core/bitcoincore.org/pull/848.diff

—
Reply to this email directly, view it on GitHub
https://github.com/bitcoin-core/bitcoincore.org/pull/848, or unsubscribe
https://github.com/notifications/unsubscribe-auth/AMRS4W7NTT7E3LCBYJALD33UWP453ANCNFSM5MEOJQAQ
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>

Hi, please forgive me for stacking
just a couple of small immediate thoughts

The roadmap has many issues:

It is outdated and (obviously) does not reflect the current state.

Why not just append a text telling this?

It implies that there is a unique roadmap for the whole project.
However, practically each contributor has their own roadmap.

Present this as a feature. Again,
why not just append a text telling this?

The embedded video is likely a GDPR cookie violation.

Fix all issues by removing it.
I think in the future it might be better for contributor(s) to share
roadmaps not on this project's website, but on the appropriate mailing
list, a blog, or a GitHub gist, or somewhere else.
Also, general bitcoin education content is better hosted on websites
dedicated to hosting educational content.

ACK
It seems reasonable not to have historical bitcoin-dev mailing list posts also stored on the bitcoincore.org site.

The embedded video is likely a GDPR cookie violation.

Can you explain why embedded video links are likely a GDPR cookie violation? Do you have any further details on this?

Can you explain why embedded video links are likely a GDPR cookie violation? Do you have any further details on this?

Links aren't an issue, but iframes might be.

The website is not hosted in the EU, GDPR does not apply. It seems wasteful to break the many links to this post.

Not a lawyer, but I am pretty sure that GDPR applies based on the location of the individual that the data is collected from, not the location of the website server? Otherwise, Google LLC could trivially avoid their fines (https://www.cnil.fr/en/cnils-restricted-committee-imposes-financial-penalty-50-million-euros-against-google-llc, ...) by claiming that "us-east-1b" or so served the requests.
Happy to keep the sites and add a "Archived" note instead. I removed them because there are superior and more complete sources. (For example optech on tx fee savings, also taking into account taproot). If they are kept, I think at the very least they should be removed from the navigation bar. Currently it is the first item in the "FAQ" dropdown, implying that this is recommended reading material for users.

Not a lawyer, but I am pretty sure that GDPR applies based on the location of the individual that the data is collected from, not the location of the website server? Otherwise, Google LLC could trivially avoid their fines (https://www.cnil.fr/en/cnils-restricted-committee-imposes-financial-penalty-50-million-euros-against-google-llc, ...) by claiming that "us-east-1b" or so served the requests.

I'm tempted to reply with a Pirate-Bay-style "just because you write a law that says it applies to me does not mean it applies to me if I don't live in your country" response :) Part of the Google issue is they actually have corporate subsidiaries, operations, and generally do business in Europe. A random static site hosted in the US does not :p.

Happy to keep the sites and add a "Archived" note instead. I removed them because there are superior and more complete sources. (For example optech on tx fee savings, also taking into account taproot). If they are kept, I think at the very least they should be removed from the navigation bar. Currently it is the first item in the "FAQ" dropdown, implying that this is recommended reading material for users.

SGTM.

For stuff with lots of inbound links, I also prefer not deleting it.

lots of inbound links

There shouldn't be too many links: https://duckduckgo.com/?q="bitcoincore.org%2Fen%2F2015%2F12%2F23%2Fcapacity-increases-faq

static

Is it static if the content is <iframe> youtube.com/watch <...? I am actually hoping to see a GDPR lawsuit where the defendant isn't FAANG (is that called MAANG now?). If https://lists.linuxfoundation.org/pipermail/bitcoin-dev/2022-January/019741.html is also covering the entity that hosts this website, it might be worth to eat the risk.

lots of inbound links

There are various news articles and social media posts at the time covering the related ML post, and this document is rather historical.

Created #850 for discussion


Random error in test_logger

Observed in CI. Windows python 3.9
Looks like an instrument from a pre existing test was not cleaned up? Which is strange since the new autocontext manger should close all instruments at test exit
=========================== short test summary info ===========================
FAILED qcodes/tests/test_logger.py::test_instrument_connect_message - assert 'Closing VISA...instrument.\n' == "[awg_sim(AWG...re': '0.1'}\n"
  - [awg_sim(AWG5208)] Connected to instrument: {'vendor': 'QCoDeS', 'model': 'AWG5208', 'serial': '1000', 'firmware': '0.1'}
  + Closing VISA handle to lakeshore_372 as there are no non weak references to the instrument.
= 1 failed, 2632 passed, 233 skipped, 6 xfailed, 1 xpassed, 3 warnings in 950.19s (0:15:50) =
Error: Process completed with exit code 1.

================================== FAILURES ===================================
_______________________ test_instrument_connect_message _______________________
[gw1] win32 -- Python 3.9.13 C:\hostedtoolcache\windows\Python\3.9.13\x[64](https://github.com/QCoDeS/Qcodes/actions/runs/6402218105/job/17378489286?pr=5416#step:9:65)\python.exe

    @pytest.mark.usefixtures("remove_root_handlers", "awg5208")
    def test_instrument_connect_message() -> None:
        """
        Test that the connect_message method logs as expected

        This test kind of belongs both here and in the tests for the instrument
        code, but it is more conveniently written here
        """

        with open(logger.get_log_file_name(), encoding="utf-8") as f:
            lines = f.readlines()

        con_mssg_log_line = lines[-1]

        sep = logger.logger.LOGGING_SEPARATOR

        con_mss = con_mssg_log_line.split(sep)[-1]
        idn = {"vendor": "QCoDeS", "model": "AWG5208",
               "serial": "1000", "firmware": "0.1"}
        expected_con_mssg = ("[awg_sim(AWG5208)] Connected to instrument: "
                             f"{idn}\n")

>       assert con_mss == expected_con_mssg
E       assert 'Closing VISA...instrument.\n' == "[awg_sim(AWG...re': '0.1'}\n"
E         - [awg_sim(AWG5208)] Connected to instrument: {'vendor': 'QCoDeS', 'model': 'AWG5208', 'serial': '1000', 'firmware': '0.1'}
E         + Closing VISA handle to lakeshore_3[72](https://github.com/QCoDeS/Qcodes/actions/runs/6402218105/job/17378489286?pr=5416#step:9:73) as there are no non weak references to the instrument.

qcodes\tests\test_logger.py:311: AssertionError
---------------------------- Captured stdout setup ----------------------------
Qcodes Logfile : C:\Users\runneradmin\.qcodes\logs\231004-3060-qcodes.log
Connected to: QCoDeS AWG5208 (serial:1000, firmware:0.1) in 0.06s
------------------------------ Captured log call ------------------------------
INFO     qcodes.instrument.visa:visa.py:30 Closing VISA handle to x as there are no non weak references to the instrument.
INFO     qcodes.instrument.visa:visa.py:30 Closing VISA handle to x as there are no non weak references to the instrument.
INFO     qcodes.instrument.visa:visa.py:30 Closing VISA handle to y as there are no non weak references to the instrument.
INFO     qcodes.instrument.visa:visa.py:30 Closing VISA handle to z as there are no non weak references to the instrument.
INFO     qcodes.instrument.visa:visa.py:30 Closing VISA handle to lakeshore_372 as there are no non weak references to the instrument.
INFO     qcodes.instrument.visa:visa.py:30 Closing VISA handle to lakeshore_372 as there are no non weak references to the instrument.
---------------------------- Captured log teardown ----------------------------
INFO     qcodes.instrument.instrument:instrument.py:1[86](https://github.com/QCoDeS/Qcodes/actions/runs/6402218105/job/17378489286?pr=5416#step:9:87) Closing all registered instruments

maybe gc gests collected at a not-expected moment?
maybe the test could be rewritten to make sure the connect message is among the messages instead of expecting it to be the last message? alternatively, the test could be rewritten to use instrument's log instance explicitly with a well-defined message, and then perhaps it would be more stable against changes to what is being logged in various places in qcodes

I don't think the problem is that other messages are injected. Looking at the detailed output the message is just not there. In the attached pr I reworked it to use caplog and reworked the hander reset fixture to not modify pytest handlers


Value of meta is undefined in queries returned by useQueries

Describe the bug
When a value is assigned to the meta field on the queries passed to the useQueries hook, that value is undefined when iterating over the queries.
const pokemonList = ['ditto', 'pikachu', 'charizard'];

const queries = useQueries({
  queries: pokemonList.map((pokemon) => ({
    queryKey: ['pokemon', pokemon],
    queryFn: () => axios(`https://pokeapi.co/api/v2/pokemon/${pokemon}`),
    meta: { pokemon },
    staleTime: Infinity,
  })),
});

return (

    {queries.map((query) => {
      // meta is undefined here
      console.log(query.meta);

      return
{query.data.data.name}
;
    })}

);

Your minimal, reproducible example
https://stackblitz.com/edit/vitejs-vite-2hz1pw?file=src%2FApp.jsx
Steps to reproduce

Open the example at https://stackblitz.com/edit/vitejs-vite-2hz1pw?file=src%2FApp.jsx.
Open the browser console from within the preview.
Note that the logged value of query.meta is undefined.

Expected behavior
I expected the value of the meta field to be defined and accessible inside my component on each query returned by the useQueries hook.
How often does this bug happen?
Every time
Screenshots or Videos
No response
Platform

OS: macOS (v14.1)
Browsers: Edge (v118), Safari (v17.1)

Tanstack Query adapter
react-query
TanStack Query version
4.36.1
TypeScript version
No response
Additional context
No response

meta is not part of the returned object from useQuery, just like other fields that you pass to the query are not returned. Like, if you were to access result.queryKey, it would also be undefined. Have a look at the API docs to see what gets returned, and please consider using TypeScript.


Datatree: Dynamically populate the HTML repr

What is your issue?
Originally posted by @TomNicholas in https://github.com/xarray-contrib/datatree/issues/206
@andersy005, @jbusecke and I noticed that for big trees (hundreds or thousands of nodes) the HTML repr can become very slow to render, potentially locking up your jupyter notebook.
We think that's because the HTML representing the whole tree is pre-rendered in one go, and hidden by defaulting sections to be closed. If your tree contains thousands of nodes that's a lot of HTML to render.
@andersy005 suggested that perhaps the HTML repr should contain some kind of callback, so that the code to render new nodes is only opened
I don't know if that's possible at all, or whether it would work for reprs rendered in non-interactive environments (such as in xarray's static docs pages).

Both html repr and the normal repr are struggling with large datatrees. The normal repr should probably be truncated in similar fashion as the dataset repr:
https://github.com/pydata/xarray/blob/ce5130f39d780cdce87366ee657665f4a5d3051d/xarray/core/options.py#L67

With this example the html repr takes 3 minutes compared to the 840 from the normal repr:
import numpy as np
import xarray as xr
from xarray.core.datatree import DataTree

def create_datatree(number_of_files, number_of_groups, number_of_variables):
    datasets = {}
    for f in range(number_of_files):
        for g in range(number_of_groups):
            # Create random data:
            time = np.linspace(0, 50 + f, 100 + g)
            y = f * time + g

            # Create dataset:
            ds = xr.Dataset(
                data_vars={
                    f"temperature_{g}{i}": ("time", y)
                    for i in range(number_of_variables // number_of_groups)
                },
                coords={"time": ("time", time)},
            ).chunk()

            # Prepare for Datatree:
            name = f"file_{f}/group_{g}"
            datasets[name] = ds
    dt = DataTree.from_dict(datasets)

    return dt

number_of_files = 25
number_of_groups = 20
number_of_variables = 2000

dt = create_datatree(number_of_files, number_of_groups, number_of_variables)

# %timeit dt._repr_html_()
# 3min 15s ± 4.37 s per loop (mean ± std. dev. of 7 runs, 1 loop each)

# %timeit dt.__repr__()
# 840 ms ± 29.1 ms per loop (mean ± std. dev. of 7 runs, 1 loop each)


Implement client-id sending on requests

This should be done as a pipeline policy.

It's already provided by Azure.Core


TypeError undefined is not a function, js engine: hermes

CallService#acceptCall 44:4
Screenshot
https://prnt.sc/r942y7
The error happens on pressing Accept (call).

Commenting out:
this.resetRingtone();
Makes it work.

Thanks, @Manf26 !
I've removed it. It was a mistake (prev name of method "stopSounds")

Since there is no activity I’m going to close the issue. Please raise a separate issue in case of any other questions.


Autoscaling capability to opensearch-dashboards helm chart

Signed-off-by: pgodithi<EMAIL_ADDRESS>Description
This PR adds autoscaling capability to opensearch-dashboards helm chart, this autoscaling field exists but was redundant as there was no necessary configs under templates.
Issues Resolved
https://github.com/opensearch-project/helm-charts/issues/230
Check List

[x]  Commits are signed per the DCO using --signoff

For any changes to files within Helm chart directories:

[x]  Helm chart version bumped

[x] Helm chart CHANGELOG.md updated to reflect change

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Hello @TheAlgo and @DandyDeveloper can you review this PR when you get a chance?

@DandyDeveloper @TheAlgo please review again and see if @prudhvigodithi has addressed all your concerns.
Thanks.

Hey @TheAlgo and @DandyDeveloper , can you please check this PR?
Thank you


Use deployment_status event for GitHub

GitHub parser & deployments.sql collect failed deployments as well as succeeded ones (more precisely, deployment event itself has no status information) and insert into deployments table.
And then, both kind of deployments are taken into consideration when calculating deployment frequency and lead times.
This is unexpected behavior for me (or perhaps for us), so I suppose it's more appropriate using deployment_status events with success state.

Note: nox is failing on an unrelated test -- the relevant tests passed.


Update benchmark.yml

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.


Update hello_world.md

delete wrong extra tick sign in CLI code
Explanation
Correct the CLI cocde in docs.
Related issue
No existing issue
What type of PR is this
/kind documentation
Proposed Changes
Correct the CLI cocde in docs.

Hello, I am a code review bot on flows.network.
It could take a few minutes for me to analyze this PR. Relax, grab a cup of coffee and check back later. Thanks!

The DCO check failed. Please refer to this for signing DCO: https://www.secondstate.io/articles/dco/

@ahndmal Could you please sign-off your commits? More info on how to: https://github.com/WasmEdge/docs/pull/178/checks?check_run_id=17924620845

Signed the commits.
Please also note that https://www.secondstate.io/articles/dco/ page seems to have incorrect flags in:
git commit —amend —no-edit ---signoff to be git commit --amend --no-edit --signoff

Please squash your commits. One of your commits is not DCO-signed.

Hi @ahndmal
Could you please take a look at the DCO issue? It still fails. Thanks!

Due to the DCO not being signed, we are not able to merge this PR. Closing it for now. Please feel free to re-submit a new PR if the DCO is signed.


Export Default Parse Rules

What
Added default parse rule plugins to the export of the package
Why
Whilst converting the prosemirror-math to a remirror extension. I noticed in math-schema.ts that defaultInlineMathParseRules where being destructured into the schema
parseDOM: [{ tag: "math-inline" },...defaultInlineMathParseRules]

Other stuff

The remirror extension
Judging from the snippets in attempts to support tiptap I think this change will help with adding parse rules to other prosemirror based editors #27

Thanks for your contribution (and sorry for the very late reply)!  I'm not able to merge your PR since the structure of the project has changed, but I just merged PR #67 which exposes the parse rules.


Always check for the presence of custom actions

If custom actions are not allowed, the workflow will be rejected by the custom actions job(s) and fail. With this condition in place it was silently skipping custom actions.
Change-type: patch

I self-certify!


Silence CMake warnings ECFLOW-1936

Silence CMake warnings regarding the policies: CMP0046, CMP0144 and CMP0148

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (21f37df) 83.33% compared to head (c742571) 83.34%.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop      #76   +/-   ##
========================================
  Coverage    83.33%   83.34%
========================================
  Files          590      590
  Lines        52611    52611
========================================
+ Hits         43845    43847    +2
+ Misses        8766     8764    -2

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Windows version support

Is Windows 10 Pro recent compared with 'Windows 10 Fall Creators Update'?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 2254d309-a79d-b6ed-fb4c-73ef689b76ec
Version Independent ID: 96fa695b-4f0e-4d09-4b26-f7a501a78c9c
Content: Installing UWP apps from a web page - UWP app developer
Content Source: windows-apps-src/packaging/installing-UWP-apps-web.md
Product: windows
GitHub Login: @laurenhughes
Microsoft Alias: lahugh

Hi @chainhead -- does this page answer your question? https://docs.microsoft.com/en-us/windows/uwp/updates-and-versions/choose-a-uwp-version


Added Active and Inactive logic on expense-calculator for expense bil…

…l and id for wage bill

Closing this because already merged into master.


Delete ignored key from config.json

Since the exercise implementations are all in the exercises directory
we no longer need to ignore any non-exercise directories in the root
of the track.
See https://github.com/exercism/meta/issues/3 for context.

I've created another PR, #79, which normalizes all of the whitespace in the config.json so
that the change in this PR is minimized and easier to see.
If you merge the other PR first, I'll go ahead and rebase this one onto master.
Sorry about the noise!


BuldingNet SDF

Hi,
Impressive work. Is it possible to give the dataset collection and the preprocessing step that went into SDF creation. Because most of the buildings in BuildingNet are open and have holes in them. When i tried SDF with them for a different project of mine, it did not work well. If you already have a subset of buildings that you have collected and preprocessed to make it a closed surface would like to use it for one of my projects.

I have a similar requirement.I want to know how to tranfer my dataset to the format like in the ShapeNet_lists.

Has the issue been resolved? I'm having the same question, how can I tranfer my dataset to the format like in the ShapeNet_lists?


[ownership] Fix assert to test the right thing semantically in the linear lifetime checker.

I think this assert was just testing the wrong thing. Specifically, it is trying
to say that either the given value has a consuming use or it is post-dominated
by dead end blocks.
Instead of checking that directly by using DeadEndBlocks::isDeadEnd(), it was
using a different empty check that caused the assert to actually semantically
say that:
A value must have a lifetime ending use or the dead end blocks analysis must
have found at least one block at all in the function that is reachable from a
function terminating terminator (e.x.: return).
This is clearly not the former and was causing the linear lifetime error to hit
this assert in certain cases.
rdar://problem/70690127

@swift-ci smoke test


Add the workflow id to the folder in staging-davs

This will prevent output/scratch files related to different workflows putting in the same folder and being hard to distinguish.
Suggested in slack thread, sorry it has only internal access.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>3
Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 89.51%

Totals

Change from base Build<PHONE_NUMBER>7:
0.0%

Covered Lines:
1681

Relevant Lines:
1878

💛  - Coveralls


Updates chalk to 1.0.0.

Updates Chalk to latest version, 1.0.0. See the releasenotes for the changes.
This is the first major version, and the API can now be considered stable.
This commit and PR is auto-generated. Please merge with care. My apologies if it's undesirable.
Made with ♥ by Sindre, Joshua, and all our wonderful contributors.

Chalk not used on this task any more.


Keep in line with current accessibility standards

Using Genesis Framework who have put extensive work into accessibility in their latest version like underlining links. Thought this would be a good place to start http://genesis-accessible.org/
If this isn't the scope of sanitize.css please delete issue.

First, a warning; this site may have hijacked links to shareasale. Links to Genesis Framework seem to be compromised.
Second, thanks for sharing! Words like “accessibility”, “standards” and “framework” get me amped!
In this particularly case, the Leiden theme from Genesis Accessible is too specific for WordPress. What I mean is, it targets WordPress classnames rather than elements, attributes, and agnostic markup patterns.
The generic things it does target trouble me. For instance, the link to explain body > div { font-size: 1.6rem; } is not working, but that seems particularly dangerous when it’s labeled as a Chrome fix. I don’t think Chrome has an issue with a div being the child of body. Similarly, outside WordPress a img { margin-bottom: -4px; margin-bottom: -0.4rem; } might trip up developers.
I hope this explains my decision and doesn’t come across as a dismissal of your point. I’m a big fan of accessibility frameworks, so I never, ever want to discourage you or anyone from bringing one to my attention. Please, let me know if there were any particular patterns you found in Genesis Accessible, the plugin, the Leiden theme, or anywhere for that matter that I could pay closer attention to.

cc @RRWD

@corvannoorloos @jonathantneal
The functionality the plugin Genesis Accessible and the theme Leiden are now integrated into Genesis core and the Genesis Sample Theme (https://github.com/copyblogger/genesis-sample).
The css is very specific to WordPress and to Genesis.
Is there anything specific you want me to look at here?

@RRWD not for me personally. Although I am a big fan of both Leiden and sanitize.css.
First, a warning; this site may have hijacked links to shareasale. Links to Genesis Framework seem to be compromised.
Perhaps I misunderstood, but mainly this and the reasoning after is why I pinged you as you might be interested in reading this topic. I hope no one minded.

First, thanks everyone for chiming in.
Re: hijacked links. I see one for example for “basic Genesis Framework” at http://genesis-accessible.org/installation/
Re: Sanitize / Genesis - anything for us to look at. I think @murrayac wanted me to look for elements to borrow from Genesis / Leiden. While I didn’t find anything, I will say that Sanitize.css could be a great use case for Genesis, paying close attention to https://github.com/10up/sanitize.css/blob/master/sanitize.scss#L270-L298
Even if you did not want to adopt Sanitize.css, this project is dedicated to the public domain, meaning I encourage you to freely take or expand upon anything you like without troubling yourself with licensing. Whatever benefits the users.

Well, actually, the links are not hijacked, they're affiliate links, I earn some money with that.
I looked at the scss, specifically targeting ARIA seems like a good idea, yes.


Add AttachmentEditor

[x]  dev @jNery
[ ]  qa

Create an AttachmentEditor similar to previous API https://developers.arcgis.com/silverlight/sample-code/start.htm#ToolkitAttachmentEditor
that will allow users to work with ArcGISFeatureTable add/update/delete attachments and open attachment for preview and/or save attachment locally.
Should also handle auto-submission of attachment edits for ServiceFeatureTable.

@mbranscomb : Should this issue also be closed or re-considered for v100.0?

@jNery @mbranscomb please consider implement it for all .Net supported API's :)

@shaharbukra Thanks for the feedback, we'll be working on the Toolkit components over the coming weeks.


Fix itsybitsy_m4 CI error

Summary
Fix itsybitsy_m4 CI error on nightly.

Self-approving so that CI can start being green again


not working with flow and create react app

I tried to use snapguidist  with create react app in a project which include flow type but did not manage to get it work. Not even to get to the point of this issue: https://github.com/styleguidist/snapguidist/issues/35
1st try: use the configuration from snapguidist documentation:
module.exports = snapguidist({
  components: "src/components/**/[A-Z]*.js",
  defaultExample: true,
  webpackConfig: {
    module: {
      rules: [
        {
          test: /\.jsx?$/,
          exclude: /node_modules/,
          loader: "babel-loader"
        },
        {
          test: /\.css$/,
          loader: "style-loader!css-loader"
        }
      ]
    }
  }
});

=>  FAIL failed to compiled
compiler do not understand the word "type"
2nd try: I installed the flow plugin for babel :
 npm i flow-babel-webpack-plugin
And add the plugin in the configuration file:
module.exports = snapguidist({
  components: "src/components/**/[A-Z]*.js",
  defaultExample: true,
  webpackConfig: {
    module: {
      rules: [
        {
          test: /\.jsx?$/,
          exclude: /node_modules/,
          loader: "babel-loader"
        },
        {
          test: /\.css$/,
          loader: "style-loader!css-loader"
        }
      ]
    },
    plugins: [new FlowBabelWebpackPlugin()]
  }
});

=> styleguidist start and freeze, server never stop neither any message appears.
Is there a way to get snapguidist working with create-react-app and flow?

Hello @YohMer, thanks for opening this issue.
I just tried to use CRA + Flow with Snapguidist and it seems to work.
Repro:

yarn create react-app whatever
cd whatever
Follow these steps to add Flow to CRA
yarn add --dev react-styleguidist snapguidist
Create a config file:

// styleguide.config.js

module.exports = require('snapguidist')();

Create an example:

// Button.js

// @flow

import React from 'react'

type Props = {
  text: string,
}

function Button(props: Props) {
  return <button>{props.text}</button>
}

export default Button

// Button.md

Button example:

<Button text="🍕" />

Runnpx styleguidist server
Snapguidist works:

At this point, you would experience the issue described in https://github.com/styleguidist/snapguidist/issues/35.
I hope this helps.

Thanks.
Would be nice to add a line in the README for the CRA user.
For the https://github.com/styleguidist/snapguidist/issues/35 issue, I m going to have a look to replace the snap extension by another extension.


Could not find a declaration file for module 'react-social-icons'.

When I am using import { SocialIcon } from 'react-social-icons'; statement in my js file it is giving me ,
Could not find a declaration file for module 'react-social-icons' error. Can anyone tell me how to resolve this ?

@AnmolChhabra98  I believe you are using Typescript. This library does not provide type declarations, you will have to create your own. I found this stack overflow answer useful https://stackoverflow.com/questions/41292559/could-not-find-a-declaration-file-for-module-module-name-path-to-module-nam

I will re-open this issue in case you (or anyone else) would like to contribute a type declaration to this package. I will review the changes and publish a new release on approval. You can use this documentation as a reference https://www.typescriptlang.org/docs/handbook/declaration-files/introduction.html. I'm looking forward to your contribution!


[KOGITO-3610] - Updating Kogito Service interface to describe CloudEv…

…ents
See: https://issues.redhat.com/browse/KOGITO-3610
This is the last PR that comprehends the full CloudEvents reengineering feature. Now our resources also tells to users how to consume or publish events to our services:
Spec:
  Image:  quay.io/ricardozanini/process-knative-quickstart-quarkus:latest
  Infra:
    kogito-knative-infra
  Replicas:  1
Status:
  Cloud Events:
    Consumes:
      Type:  travellers
    Produces:
      Source:  /process/travelers
      Type:    process.travelers.processedtravellers

That would make super easy for interested parts to create Triggers on Knative, for instance:
Spec:
  Broker:  default
  Filter:
    Attributes:
      Type:  process.travelers.processedtravellers
  Subscriber:
    Ref:
      API Version:  serving.knative.dev/v1
      Kind:         Service
      Name:         event-display
      Namespace:    kogito-3610

Here's the final produced event:
☁  cloudevents.Event
Validation: valid
Context Attributes,
  specversion: 1.0
  type: process.travelers.processedtravellers
  source: /process/travelers
  id: 5992ef76-6aab-4a54-830b-e0ba6aa0eb72
  time: 2020-11-05T17:23:27.159245Z
Extensions,
  knativearrivaltime: 2020-11-05T17:23:27.312975513Z
  knativehistory: default-kne-trigger-kn-channel.kogito-3610.svc.cluster.local
  kogitoprocessid: Travelers
  kogitoprocessinstanceid: 093a20f9-17eb-4894-956f-ceacb1645a12
  kogitoprocessinstancestate: 1
Data,
  {"firstName":"Jane","lastName":"Doe","email":"jane.doe@example.com","nationality":"Canadian","processed":true}

Ref: https://github.com/kiegroup/kogito-runtimes/pull/853
@evacchi @tsurdilo we did it!
Signed-off-by: Ricardo Zanini<EMAIL_ADDRESS>Many thanks for submitting your Pull Request :heart:!
Please make sure that your PR meets the following requirements:

[x] You have read the contributors' guide
[x] Pull Request title is properly formatted: [KOGITO-XYZ] Subject
[x] Pull Request contains a link to the JIRA issue
[x] Pull Request contains a description of the issue
[x] Pull Request does not include fixes for issues other than the main ticket
[x] Your feature/bug fix has a unit test that verifies it
[x] You've tested the new feature/bug fix in an actual OpenShift cluster

@danielezonca FYI
/jenkins test

@spolti I believe I covered your comments.
/jenkins test

@sutaakar I wish to merge this one today. Could you please take a look? I understand that you are swamped and it's my fault for the short notice. I apologize. :(

Code looks good, will try on OCP.

Once you verify it, I'll incorporate the comments since they are just cosmetics and any other bug that you may found. Many thanks!

/jenkins test

@ricardozanini Sorry for late reply. Above review comments are not blocker. If this PR is already tested then we could skip those and open a small jira to handle them later.

/jenkins test


Added helper function to simplify .fire() when using a Void type

This makes it so that you can call .fire() without having to pass an empty tuple.

Also cleaned up some code-smell semicolons

Uuh, didn't even notice all those semicolons. Thanks! Looks good.


Update this repo to the current state

This template almost certainly is outdated in many places with regards to what a v3 track looks like. There is also more outdated stuff, like the mention of Travis. We should update the template.

@ErikSchierboom How much work is involved in this?

@iHiD Couple of hours? It will be mostly doc changes. Might be good to have a "starting a new track?" document in the docs repo, and/or possible opening some issues whenever a new track repo is created.

OK, pop it on your list as part of our "getting everything to a good clean slate" jobs!


Issue 1028 more modular

#1028

probably need to change the mixs importing steps in the makefile to work with the new biosmaple.yaml file instead of nmdc.yaml.

Thanks for your help with this, @anastasiyaprymolenna
I'm closing this PR and issue now. I don't think anybody wants to split nmdc.yaml into more schema modules.
We can continue to work on sample preparation modeling in the other open branches/PRs.


feat: adds default terraform tags

What
feat: adds default terraform tags

:tada: This PR is included in version 0.7.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Redirect to overview page after new container

After creating container, it should be redirected to list of container page, not the setup log

Tested; thanks :)


SubscriptionMonitoring.ps1 Timing Out

subscription monitoring script is timing out when trying to build out the deadletter queue subscription client

Issue was due to an exception generated when calling
$dlClient = [Microsoft.ServiceBus.Messaging.SubscriptionClient]::CreateFromConnectionString($conn, [Microsoft.ServiceBus.Messaging.SubscriptionClient]::FormatDeadLetterPath($topicName, $subscriptionName));
and the final value of FormatDeadLetterPath exceeded 67 characters.  Fix is to instead just append the known dead letter path instead
$dlClient = [Microsoft.ServiceBus.Messaging.SubscriptionClient]::CreateFromConnectionString($conn, $topicName, $subscriptionName + '/$DeadLetterQueue');
Fix is in v<IP_ADDRESS>


Mysterious unhandled error event

Hello,
I got interested in trying out localtunnel but everytime i run it with my local servers i get
events.js:72
throw er; // Unhandled 'error' event
^
Error: connection refused: localtunnel.me:40283 (check your firewall settings)
What don't i do right?

Error: connection refused: localtunnel.me:40504 (check your firewall settings)
Every once in a while this happens, it's weird.

I have the same issue.

Me too…

Me too.  I suspect this is caused by a port's lease expiring.  I don't know how localtunnel works, but I wonder if it's using something like UPnP to open a port first on local machine, then gateway/network router.  Those leases perhaps expire after a while?

I know little about network to help debug the issue, but I do use localtunnel frequently in my company to debug mobile websites, and sooner or later that error appears and the localtunnel connection dies. I'm happy to help with testing, if needed, tho.

I have the same issue, the tunnel works for a while , then it crashes with the same error.

you're probably using nodemon or something which restarts the server causing the port to go down for a brief moment

This error is happening with me too... after a while the connection goes down. Is there anything I could do to help tracing the problem?

You need to install localtunnel globally:
npm install -g localtunnel

@ekosten I guess this is actually the default recommendation?

This happens to me every once in a while too.

I am getting the same error message as described in the uploaded images. Any news on how to avoid it ?
--Regards

+1

+1

For simple uses of localtunnel (i.e. Not attached to browsersync), I've migrated to ngrok.io. Reliable and also seems more powerful (?). The install procedure is the same, npm install -g ngrok

The ngrok solution does work well, but requires a paid subscription for custom subdomains. Still curious about a solution for localtunnel.

I haven't had time to look into it but to likely just a missing error
handler.
On Thursday, January 7, 2016, Suchaaver Chahal<EMAIL_ADDRESS>wrote:

The ngrok solution does work well, but requires a paid subscription for
custom subdomains. Still curious about a solution for localtunnel.
—
Reply to this email directly or view it on GitHub
https://github.com/localtunnel/server/issues/14#issuecomment-169900252.

+1

Same here, a few times a day, sometimes after 5 minutes, sometimes after many hours. Using gulp and browsersync

+1, frequently experiencing this issue.

Might seem odd, but I'm using GnuRoot to run linux on my android device and have had success using localtunnel to expose a web server. But it doesn't take long ( < 15 minutes) before the server closes with connection refused: localtunnel.me:43027 (check your filewall settings). I'm connected to wifi for what it's worth, though it'd be cool if it was also possible over 4G

This issues is not fixed yet.
your url is: https://customname.localtunnel.me
/usr/lib/node_modules/localtunnel/bin/client:58
        throw err;
        ^

Error: connection refused: localtunnel.me:44406 (check your firewall settings)
    at Socket.<anonymous> (/usr/lib/node_modules/localtunnel/lib/TunnelCluster.js:47:32)
    at emitOne (events.js:77:13)
    at Socket.emit (events.js:169:7)
    at emitErrorNT (net.js:1253:8)
    at nextTickCallbackWith2Args (node.js:442:9)
    at process._tickCallback (node.js:356:17)

Ill re-iterate here what I said in another issue on the client side. I don't have much time to work on localtunnel right now. I know these issues are happening and if someone wants to take master and fix it up I will happily review and deploy new versions but I want to be clear that I am not actively working on this day to day due to other obligations right now.

create as bash script like try.sh with
#!/bin/bash
lt --subdomain testratesyapp --port 3000

and then run watch n30 ./try.sh so this runs the try.sh every 30 sec
and it worked for me with a constant subdomain..
i found no other solution.. works in ubuntu and all other linux OS i guess :)

Also you could use pm2 or forever so it restart process when it fails.

turnoff antivirus, this help me w10

create file localtunnel.desktop
[Desktop Entry]
Version=1.0
Type=Application
Name=localtunnel
Comment=localtunnel tunneling localhost
Exec=watch -n 3 lt -s myweb -p 8080 && clear
Icon=knetattach
Path=
Terminal=true
StartupNotify=false
works in GNU/Linux

as variant for static subdomain
shell script
#!/bin/bash while true do lt -p 9292 -s hpbuildserver sleep 5 done


Fix replaceRecord handling for IndexedDB and LocalStorage

Fixes the handling of the replaceRecord operation in the IndexedDB and LocalStorage sources.
Prior to this PR, replaceRecord would complete clobber the existing record. This PR changes that behaviour that so that it merges the new fields into the old fields.

Thanks @mmun!
Just published:

<EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS>


Is the -Connection flag still supported?

When I run the command
Update-Database -Connection="..."

I get this error message:
Update-Database : A parameter cannot be found that matches parameter name 'Connection'.

Running the command get-help Update-Database, it gives this for the syntax:
SYNTAX
    Update-Database [[-Migration] <String>] [-Context <String>] [-Project <String>] [-StartupProject <String>] [<CommonParameters>]

From the description of the syntax, it looks like -Connection isn't supported. Am I looking at the wrong documentation, or is the -Connection flag no longer supported?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 22803277-a2a7-0adf-acfc-35ed8e4238c8
Version Independent ID: 19869482-5737-adff-3f7f-60b4217b977d
Content: EF Core tools reference (Package Manager Console) - EF Core
Content Source: entity-framework/core/miscellaneous/cli/powershell.md
Product: entity-framework
Technology: entity-framework-core
GitHub Login: @bricelam
Microsoft Alias: bricelam

It's coming in EF Core 5.0.0. Looks like we forgot to update the PMC page when we fixed #2470.

Ah, got it; thanks.
Should I close this bug or leave it open for the documentation to be fixed?

Leave open to fix docs. 👌


chore(deps): update common-dev-assets digest to b015de0

This PR contains the following updates:

Package
Update
Change

common-dev-assets
digest
d5bdf01 -> b015de0

Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.

[ ] If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot.

/run pipeline

:tada: This PR is included in version 1.2.1 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Timer resets when changing desktop

When I switch from the pomo's desktop to another (via ctrl+win+arrow for example) the pomo restarts, which is annoying as I switch regularly.
Could you fix that ?
Also love your app, it really is good and minimalistic as I wanted.

Hi @AntoineArt,
I am not the developer (@DinoChan is), but a quick test with (Ctrl+Win+Arrow) key on Widows 10 did NOT restarts OnePomodoro for me. Can you please confirm the version of windows and how I can reproduce this?
Thanks,
@billhung

Thank you for your feedback,I want to know which Pomodoro View you are using.
And thanks billhung for the test.

Hi everyone, thank you for your quick response.
I am on Windows 10 build 19042.
First I will complete the problem I had yesterday :
I used gradients pomodoro all day in pinned mode. At the end of the day I noticed the fact that when switching desktop it resets the pomo. I also tried to kill and relaunch OnePomodoro but it didn't solve the problem.
Today I am embarrassed as I can't reproduce it, everything works well (though I haven't restarted my computer).
So for now it works as expected, if the problem reappears I will record it for you.
Thank you for your time, I really like OnePomodoro, it is exactly what I was looking for to focus on work.

Hi everyone, thank you for your quick response.
I am on Windows 10 build 19042.
First I will complete the problem I had yesterday :
I used gradients pomodoro all day in pinned mode. At the end of the day I noticed the fact that when switching desktop it resets the pomo. I also tried to kill and relaunch OnePomodoro but it didn't solve the problem.
Today I am embarrassed as I can't reproduce it, everything works well (though I haven't restarted my computer).
So for now it works as expected, if the problem reappears I will record it for you.
Thank you for your time, I really like OnePomodoro, it is exactly what I was looking for to focus on work.

Thank you very much for your reply.
I will try to reproduce the problem in the same environment.

Hi again, the problem occurred again.
You can see it for yourself in this YouTube video I just uploaded : https://youtu.be/piYLwb6qkj0.
It seems to have happened again when I hit win+tab to move a window from a virtual desktop to another.
After that the pomo was bugged.
I tested several pomodoro skins but the bug happens each time.
Also I doubt it is the source of the problem but I am using several screens (3).


How to create enums from list of resources?

Hi,
I want to create some enums called "ImageKey", "LocalizableKey", etc based on the resources from R.images, R.strings, etc. For instance R.images.titleIcon will become ImageKey.titleIcon, R.strings.localizable.title to LocalizableKey.title, etc. How do I go about that?
Thanks.

Nevermind. I just found out about the StringResourceType.key and ImageResourceType.name. I can just parse them it. LOL. Although for now I need to create the enums manually for each string. But if anyone knows of any script that can automate the process so that when there are some other new strings or images in the R.generated, it will be great if you can share it.
Thanks.


Can we add toggle to the Editor

I love this Project so much because it has all that I need for my current project except for the toggle option between wysiwyg and html
I think we can have @tbw-toggle="true/false" and then the true/'false value can be control by external button

I will add the feature soon.
Ref:
https://alex-d.github.io/Trumbowyg/documentation/#toggle

I will add the feature soon.
Ref:
https://alex-d.github.io/Trumbowyg/documentation/#toggle

Thank you!

The editor already has a button to preform this action.
Why do you want to control this behaviour from external button?

Closing due to no activity, feel free to open


[GEP-21] Handle Seed IPFamilies (IPv6)

How to categorize this PR?
/area dev-productivity
/kind enhancement
What this PR does / why we need it:
This is part of GEP-21. Implementation of the local IPv6 Seeda
Which issue(s) this PR fixes:
Part of #7051
Special notes for your reviewer:
Loki is not yet IPv6 ready until https://github.com/grafana/dskit/pull/185 is merged.
Release note:
Gardener's local setup now supports bootstrapping a Seed with IPv6 single-stack networking using `make gardener-up IPFAMILY=ipv6`. See the [documentation](https://github.com/gardener/gardener/blob/master/docs/deployment/getting_started_locally.md) for more detailed steps.

/ok-to-test

/assign
I will take over the PR from @breuerfelix

I resolved the remaining comments and all merge conflicts.
Though, I still need to iterate over this once more, clean some things up, and do a final test.
Until that is done:
/hold

/hold cancel
@rfranzke @ScheererJ thanks for your patience and all your feedback so far.
I've rebased the PR, addressed the feedback, introduced a workaround for https://github.com/kubernetes-sigs/kind/issues/3114, and simplified some things again (see the last 11 commits).
This is ready for another round of review now :)

Rebase done :)

Rebased again :)

@rfranzke @ScheererJ Could you kindly take another look before the rebase fun starts again? 😉

@ScheererJ I replied to your questions, I hope things are clearer now. Can you take another look please? :)

.... aaaaaaaand rebased 😁

@rfranzke @ScheererJ I rebased and addressed your suggestions :)

/approve

It seems like since that PR was merged, there are a few errors that are generated by the remote-local-setup :
while trying to start the Gardelet ( make start-gardenlet SEED_NAME=local )

Putting the emphasis on :
panic: failed during bootstrapping: incorrect node network specified in seed configuration (cluster node="<IP_ADDRESS>" vs. config="fd00:10::/64")

And while trying to run (  KUBECONFIG=${KUBECONFIG%:*} USER=root make start-extension-provider-local ). I'm getting the following.

Can you look at that potential regression ?