Validations should not do coercion

Not to make things more complicated, and I know that most of the validation code has been pulled over from the RoboFab project, but I've been thinking that the validations might be worth massaging a bit.
One big issue I think that could be low-hanging fruit: a number of validations also transform the value that's passed to them. Ideally, value coercion and validation would be separate steps, and I think that if it's possible to get validations working without returning a value, the separation between the two would be conceptually neater.
In the future that could also mean that validations could be implemented in a way that's less coupled to the implementation of the objects requiring validations.

So something like this:
import validators
import coercions

    # ...

    def _set_base_width(self, value):
        value = coercions.coerceGlyphWidth(value)
        value = validators.validateGlyphWidth(value)
        self._set_width(value)

    # ...

I put the two together for convenience (aka "I'm lazy"). I'm not opposed to breaking them apart. Though... what comes first, validation or coercion? The point of the validators is to make sure that the environment implementations will be getting/sending proper types. For example, if a certain attribute wants wants a float but the scripter sends an int, we want to handle that coercion before validation. If the validation comes first, the validator will need to know about the possible type coercions. If the coercion comes first, should it raise an error if a string has been sent instead of the expected float/int? That's validation.
Sidenote: RoboFab didn't have validation or coercion. That's why I put it in fontParts. Back in ye day, and sometimes even in modern editors, we'd hit situations where we'd try to do something in a script and we'd get an hard app crash, an opaque traceback ("CXXError") or things would silently fail. Validation will get rid of most of those mysteries. Coercion will make it so that scripters don't have to worry about types too strictly.

Right—that's the rub, and why this is an issue ticket rather than a PR… It might have to be a case-by-case basis to see what makes sense.

Or really more like:
def _set_base_width(self, value):
    value = coercions.coerceGlyphWidth(value)
    validators.validateGlyphWidth(value)
    self._set_width(value)

I also wonder: a) if validators that are as specific as e.g. GlyphWidth should live in the same module as Glyph, and b) if the validators module ends up being a collection of generic validations of which the more specific ones are composed.

Thinking this through, I'm alright breaking this apart, but the more I think about it, the more it seems that the are interlinked enough that perhaps the issue is that we're calling them validators, when perhaps we should just call them normalizers as @typesupply suggested here: https://github.com/robofab-developers/fontParts/pull/11#issuecomment-200588533
Doing so would be clearer in the code and avoid having two lines in each thing you need to coerce/validate. Put the complexity in one spot, rather than having to remember to have those two lines each time you need them.
As for where they should go, I'm not sure. One is going to have to import something from validators no matter what, so no difference there. I do see an advantage in keeping the validator/normizer/coercer near the thing it's working on, however. These details won't matter to the scriptor, but they will matter to those implementing the API in an app, so doing what you recommend @jackjennings may be better for that user.

(Now that the documentation of these is done, let's make it all have to be redone! Yay!)
Validators is the wrong name for these. Let's call them "normalizers". I want to keep them in a module on their own rather than folding them into the objects. Why? Because they are very often used by more than one object. It will get even more confusing if they are spread out all over the place.

Done: 8a93f03f9d007c0f5b930ac9bd36a27dab320652.


Vocabulary option for models with sentencepiece tokenizer.

Hi,
Thanks a lot for this wonderful project! I tried to distill a model2vec model from sentence-transformers/paraphrase-multilingual-mpnet-base-v2 by providing it with a vocabulary list for my domain, but got the following error message:
ValueError: You passed a vocabulary, but the model you are using does not use a WordPiece tokenizer. This is not supported yet.Feel free to open an issue if this is a blocker: https://github.com/MinishLab/model2vec/issues

So I took the liberty to open an issue, as you kindly suggested. ;-)
Ps. As a temporary work-around I had tried to distill the model using the tokenlearn recipe instead, but was surprised to find that the dataset for extracting features was hard-coded there (i.e. C4, which won't work for my language and domain). Changing the tokenlearn code to load any arbitrary dataset is an easy enough work-around for now, but I wanted to flag the issue here regardless, for awareness.
Cheers!

Hello!
I don't think we'll be supporting Unigram tokenizers any time soon. This is because Unigram tokenizers sample from a probability distribution, and we don't really know how to correctly set the probabilities of the words you'll be adding, because we don't have access to word frequencies. Sorry to be the bearer of bad news.
If you have more information about your use-case, we might be able to come up with another solution.
I've added an issue to tokenlearn, see here, we'll tackle it.

I see, that makes sense.
In that case, just distilling the model without providing an in-domain vocabulary and subsequently finetuning on a custom dataset with the tokenlearn method should still work, as that's not updating the tokenizer. Is that correct?
(thanks for picking up the tokenlearn dataset issue!)

Hey @trpstra,
sorry for the late reply! Yes, that should work, and should also work pretty well. It depends on your specific use-case of course, but in our case we've seen bigger gains from performing tokenlearn than adding a large number of tokens to the vocabulary. It depends a little bit of course.
Please let us know what you run into in terms of results, super curious to hear about what worked and what didn't.
Stéphan

Thanks a lot @stephantul !
I will try it out and report back.
(Feel free to close this ticket if you like)


feat(TextInput): change type prop label

Description
Added type React.ReactNode for label in the TextInput component.
Issue:  #1877

@u4aew Hi, thanks for contribution. But, unfortunately, we've changed our mind regarding this feature. The inital problem we had could be resolved another way, not expanding the API. For now we don't want to have ReactNode there, because it could be a potential lost of control in this place, we want there to be a simple string


Support Listener Access Logging for TLS troubleshooting

Description:
Envoy supports several types of Access Loggers. The access log that is most commonly in use is configured in HCM or TCP/UDP/Thrift Proxy. Envoy additionally supports a listener-level access log. The listener access log is particularly useful for:

Providing information related to downstream connection establishment issues, e.g. using the %DOWNSTREAM_TRANSPORT_FAILURE_REASON% operator, and following the TLS troubleshooting guide.
Providing information when other network-filter level access loggers are not invoked (e.g. when there is no matched filter chain, NR response flag).

Currently, Envoy Gateway uses the user-defined access log format for the listener access log, but the listener access log is only emitted when there is no matching filter chain.
https://github.com/envoyproxy/gateway/blob/0abdda7a033f0e37647177a588a904c90b783149/internal/xds/translator/accesslog.go#L216
Envoy Gateway should also support listener access logs for TLS troubleshooting. Common issues include:

Downstream TLS parameter mismatch: supported versions, ciphers, ...
Downstream Client Certificate validation issues: expiration, trust store compatibility, ...

To support the TLS troubleshooting use case, Envoy Gateway may:

Make the listener access log fully configurable for end-users (including format, filters, etc.)
Conditionally emit a listener access log containing the %DOWNSTREAM_TRANSPORT_FAILURE_REASON% when a TLS connection error occurs. This can be done by appending the TLS details to the user-defined/default access log format, or by emitting a different log that is fully controlled by EG and contains relevant information such as Client IP, Available TLS Context (SNI, Cert details, ...)

To filter listener logs based on a TLS failure,  a CEL access log filter can be used:
filter:
extension_filter:
  name: envoy.access_loggers.extension_filters.cel
  typed_config:
    '@type': type.googleapis.com/envoy.extensions.access_loggers.filters.cel.v3.ExpressionFilter
    expression: connection.transport_failure_reason != "-"

isnt this already supported today https://github.com/envoyproxy/gateway/issues/3279 ?

Notes from today's community meeting:

Prefer option (2)
Emit the user-defined access log
Users that are interested in the transport failure reason should add the relevant operator to their format

Emit the user-defined access log
@guydc does this mean EG will have a separate use-defined access log format for listener-level log? From the envoy docs, listener-specific fields are very limited.

TBH, is this a common use case? can it be covered by using EnvoyPatchPolicy (or ExtensionManager) instead of introuduce an new API?

@zhaohuabing my vote would be to use the same format thats defined in envoyProxy.spec.telemetry for all access log cases, and use the default value even for the listener access log case

is this a common use case?
I would say that observability for TLS failures, especially when client certificate auth is a feature, is important. Having said that, most proxies support this sort of troubleshooting through error logs, rather than access log.

can it be covered by using EnvoyPatchPolicy (or ExtensionManager) instead of introuduce an new API?

Yes. But, the current proposal is not to extend the API. Rather, we will emit listener access logs in more scenarios and not just NR.

In light of #3688, another approach here would be to make Listener log matcher configurable. This will:

not change current default filters (only log for NR) or format
allow users to emit listener access log for TLS troubleshooting or other reasons (e.g. observability for TCP connections in general)

@arkodg , @zirain - WDYT?

In light of #3688, another approach here would be to make Listener log matcher configurable. This will:

not change current default filters (only log for NR) or format
allow users to emit listener access log for TLS troubleshooting or other reasons (e.g. observability for TCP connections in general)

@arkodg , @zirain - WDYT?

sounds good

In light of https://github.com/envoyproxy/gateway/pull/3688, another approach here would be to make Listener log > matcher configurable. This will:
not change current default filters (only log for NR) or format
allow users to emit listener access log for TLS troubleshooting or other reasons (e.g. observability for TCP connections in general)
Should the  connection.transport_failure_reason != "-" or other listener-level errors be include in the default filters?


Group creation dialog is broken; not clearing name from previous creation

Go to the Groups screen and click "+"
Name a new group and create it.
Navigate back to the Groups screen and click "+" again

You'll see that the form already contains the name from your first Group creation. Additionally, if you change that name to something new (or keep it the same) the form wont go anywhere (i.e. no new group can be created).

I’ll fix this today.

close it?


cronstrue.js:230 Locale 'zh_CN' could not be found; falling back to 'en'

when I use: cronstrue.toString(record, { locale: 'zh_CN' }
waring:cronstrue.toString(record, { locale: 'zh_CN' }
my version is 2.19.0

Did you import the locale?  See the README instructions.
Example of it working: https://runkit.com/embed/d7pbucqomrcr


Suggestion: new v-component option - replace

I'm used to use v-component with <template> sometimes when I want to keep all related elements inside the component's template.
So now 0.11.8 is out and using v-component on <template> is broken: $ object of the component is always empty, regardless of how many times v-ref is used.
I remember <template> is not supposed to be used with v-component to begin with (could we add warnings for the case?), so now I'm asking for some kind of replacement:
Add a new v-component option - replace
Using

 will result .holder to be completely replaced by component's template elements (instead of getting inside) .holder  so the $el will not be .holder but a top-level element inside component's template. If there are more then one top-level element - lets throw a warning.
I mean something like this:
new Vue({
    el: 'body',
    components: {
        name: {
            template: '

'
        }
    }
});

will be compiled to

So now 0.11.8 is out and using v-component on

It is working: http://jsfiddle.net/azamatsharapov/v8r4yepd/ or did I misunderstand you?

@azamat-sharapov
Aye, right. Looks like the case in not that simple. Maybe its when its <template> inside <template>. Need to check it out more carefully

Why don't you use the replace option?

@yyx990803 Oooops. Looks like I've been missing something reeeeaaaly important for so daaaamn long...
Thanks man. Going to cry now :D
Need some eye examination o something -_-

You simply need to change your glasses to another one, like Evan's.

;)


Add CITATION.cff to .Rbuildignore?

Should we add an instruction in Add a CITATION.cff file about adding ^CITATION\.cff$  to .Rbuildignore?
Without that we get two notes about it, see below. I don't see any way to to do it automatically.

I think are all good ideas!
Specifically, cffr::cff_write() helps to solve the issue, indeed.
Of course the section Add a CITATION.cff file is not specific for R packages. So, adding guidelines for this file in R packages maybe should be done later in the document.
I like also the idea to mention how to work with .gitignore as it is something important while developing R software.


Implement DeliveryOptions

Use DeliveryOptions that's available in Delivery SDK. It can be used together with IOptions to quickly load environment variables.
Docu: https://github.com/Kentico/delivery-sdk-net/wiki/Using-the-ASP.NET-Core-Configuration-API-and-DI-to-Instantiate-the-DeliveryClient
This will also resolve #19

I would like to work on this task.

great, i'll assign the issue to you once you accept the invitation to the project :)


Using xPath to locate elements

@aamorozov what cases you need to use XPath?

@isnifer Looking into this framework for the second day and haven't seen something that i got used to in appium, hence the question )

Take a look in this issue, https://github.com/wix/detox/issues/188, it might answer some of your questions

@rotemmiz @isnifer
Thanks guys, I was asking if smth like element(by.xpath()) would work, but it doesn't seem like detox matchers have this method.
 TypeError: by.xpath is not a function

@aamorozov don't forget - xpath soooo sloooow instead of testIDs. I don't see iterate over testIDs.
In our app we are using detox for iOS tests and Appium for Android (I wrote a wrapper for both frameworks). All tests except tests with webview are using testIDs without problems

@isnifer Yep, I'm aware of difference between those two in speed of locating element. I am also using appium for android, right now leveraging detox for ios builds. Is it a public project that you're using the wrappers on ?

@isnifer
Oh and actually to avoid piling up the issues, do you know if there is similar to findElementsBy() method for locating multiple elements, storing them in array and then do whatever you need to do with them ? Haven't found it in the docs

@isnifer

All tests except tests with webview are using testIDs without problems

Would you care to elaborate meaning of this? I having problem with check Webview visible.
My Webview is open a PDF file that I store inside application storage, but some how I can not get "pass" the test.
Specify: detox stuck at await expect(testIDofWebView).toBeVisible(); and then throw
Error: Timeout of 120000ms exceeded. For async tests and hooks, ensure "done()" is called; ifreturning a Promise, ensure it resolves.. It happened with all PDF link (open PDF file, no mater it on the internet or local storage).
However, if I use Webview to open a website (like google.com or facebook) then the test pass as normal. Should this is a bug?

@hungbm can you create a small repo to reproduce it. And we will work together on tests for it.

We have no plans of implementing xpath support at the moment.


implement plug-n-play replacement for shotgun

So that Timmy could be used by Fuel without any customizations in Fuel code.
For example: substitute shotgun binary with a wrapper for timmy which will convert command line params

not needed anymore since Timmy is to be used by Fuel UI by default in MOS 9.1+


fortinet importer NAT - source nat using destination interface address

[x] need to get interface names, IPs for rules; is the dst-if always defined in this NAT mode?
[x] no example found yet, where dstintf=any, so assuming interface is always fixed in this mode
[x] could not find IP for interfaces via API yet, using dummy object "gateway-hide-nat" instead? Per gateway or one global object? Getting it now thanks to https://fndn.fortinet.net/index.php?/forums/topic/2938-get-interface-status-not-administrative-status-from-api/&tab=comments#comment-11344
[x] final step would be adding the interface IP (if we can find the right API call)

Interfaces with IP can now be read

complete in #1557


[DSDK-332][LL][Passkey] Implement command and types related for the backup config.

✅ Checklist

[x] npx changeset was attached.
[x] Covered by automatic tests.
[x] Impact of the changes:

...

📝 Description
Implementation of App data backup commands:
Backup

getAppStorageInfo to get App data information of format in libs/device-core/src/commands/entities/AppStorageInfo.ts.

LC: APP_NAME_LEN;
Data: APP_NAME.

backupAppStorage to get a chunk of the App data to backup

No need to specify offset;
No need to format the data in response;
Only parse the response to string.

Restore

restoreAppStorageInit to initialise restoration state on the device;

LC: APP_NAME_LEN + BACKUP_LEN_LEN whose length is always 4.
Data: BACKUP_LEN + APP_NAME where the length of the backup always take 4 places.

restoreAppStorage to send backup data in chunk to the device, no need to pass offset in the command;
restoreAppStorageCommit to commit the data sent in previous step on the device.

❓ Context

JIRA or GitHub link: DSDK-332

🧐 Checklist for the PR Reviewers

The code aligns with the requirements described in the linked JIRA or GitHub issue.
The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
There are no undocumented trade-offs, technical debt, or maintainability issues.
The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
Any new dependencies have been justified and documented.
Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

Overall remark: we should always try to add individual commands to the CLI or the REPL to make them easily testable.
With this implementation I have no way to test myself the commands until the full feature is developed. And even then I won't be able to test them independently from each other.

Overall remark: we should always try to add individual commands to the CLI or the REPL to make them easily testable. With this implementation I have no way to test myself the commands until the full feature is developed. And even then I won't be able to test them independently from each other.

The commands here are not independent.

The only commands that can be tested individually is getAppStorageInfo and restoreAppStorageInit;
The command backupAppStorage must be sent after getAppStorageInfo;
restoreAppStorage and restoreAppStorageCommit must be sent after restoreAppStorageInit.

To make them testable via CLI or on the REPL, we must combine some of them which will be far from the command conception.

@jiyuzhuang

The commands here are not independent.

The only commands that can be tested individually is getAppStorageInfo and restoreAppStorageInit;
The command backupAppStorage must be sent after getAppStorageInfo;
restoreAppStorage and restoreAppStorageCommit must be sent after restoreAppStorageInit.

To make them testable via CLI or on the REPL, we must combine some of them which will be far from the command conception.

I know that they have to be sent in a specific order, the person using the REPL or CLI can do that themselves if they have access to each individual command.
The restoring one will be trickier to test but at least they can be tested.
It just seems a bit crazy for me to validate the implementation of those commands if it has never been tested for real.
Maybe we don't do it in this PR, but to me we should make a task that is exactly about that: making those commands testable outside of Ledger Live.
The same was made for the custom lock screen.

About the encoding, I think it's better to send / receive the buffer directly and encode / decode them at higher level. If not, calculating the base64 encoded string will make it more complicated.


Implement ability to prefill for all languages/operating systems/architectures

[x] Add logic to download Linux depots
[x] Add --os flag that takes linux and/or windows as a parameter
[x] --os defaults to Windows
[x] Update detailed command documentation

On my 200 game library, there are approximately 50 games w\ Linux support, for a total of ~80gb

On a larger library of over 1000 games


samtools_reset task?

Hello, this is probably not a bug, but in rc2 samtools.wdl I can see samtools_reset task which removes HP,PS,PC,SA,mg,mc,mi,rm,fi,fp,ri,rp tags from bam file, but I cannot see this task being called anywhere. Am I missing something?
Thank you!

The files in the wdl-common submodule contain tasks that are used by multiple workflows. Not all tasks are used by all workflows.


Test excluding known-bad CI configuration

This is a showcase for:

https://github.com/voxpupuli/puppet_metadata/pull/19

I was optimistic but it seems to exclude all acceptance tests.
yet, only Puppet 5 n Ubuntu 20 is supposed to be excluded:
romain@zappy puppet-splunk % bundle exec metadata2gha --use-fqdn --pidfile-workaround false
::set-output name=beaker_setfiles::[{"name":"CentOS 7","value":"centos7-64{hostname=centos7-64.example.com}"},{"name":"Debian 9","value":"debian9-64{hostname=debian9-64.example.com}"},{"name":"Debian 10","value":"debian10-64{hostname=debian10-64.example.com}"},{"name":"Ubuntu 16.04","value":"ubuntu1604-64{hostname=ubuntu1604-64.example.com}"},{"name":"Ubuntu 18.04","value":"ubuntu1804-64{hostname=ubuntu1804-64.example.com}"},{"name":"Ubuntu 20.04","value":"ubuntu2004-64{hostname=ubuntu2004-64.example.com}"}]
::set-output name=puppet_major_versions::[{"name":"Puppet 6","value":6,"collection":"puppet6"},{"name":"Puppet 5","value":5,"collection":"puppet5"}]
::set-output name=puppet_unit_test_matrix::[{"puppet":6,"ruby":"2.5"},{"puppet":5,"ruby":"2.4"}]
::set-output name=known_bad_combinations::[{"setfile":{"name":"Ubuntu 20.04","value":"ubuntu2004-64{hostname=ubuntu2004-64.example.com}"},"puppet":{"name":"Puppet 5","value":5,"collection":"puppet5"}}]

https://github.com/voxpupuli/puppet_metadata/pull/21 was merged.  Closing this demo PR.


Build on ubuntu 20.04

fixes #812

building on ubuntu:22.04 produces binaries which require too recent glibc
version (2.32+) and that means the binary no longer works on
older ubuntu versions, like 20.04 and 18.04.

building on ubuntu:20.04 fixes the problem and the binary again works
on ubuntu 18.04 and 20.04

also bumped the version in the release workflow which got forgotten

Hmm, so this moves the glibc version requirement to 2.17, which is better than before, but still not quite the same
./mvnd/maven-1.0.0-m5-SNAPSHOT-mvnd-m39-linux-amd64/bin/mvnd: /lib/x86_64-linux-gnu/libc.so.6: version `GLIBC_2.17' not found (required by ./mvnd/maven-1.0.0-m5-SNAPSHOT-mvnd-m39-linux-amd64/bin/mvnd)

Reading through https://github.com/apache/maven-mvnd/pull/730, it says

An explicit glibc requirement also removes a side effect of changing the build system. When update the build system from ubuntu 18.04 to 20.04, the glibc requirement may also increase to match the new os. On the other hand, glibc 2.12 is required by graalvm.

which is not really the case (anymore?). We bumped the build system and as a side-effect glibc version got bumped as well. GraalVM got updated from 22.2.0 to 22.3.1 in the meantime, in case that could be somehow related.

I wasn't able to make this work so that the glibc requirement would still be 2.12 (released on 2010-12-13). I tried to follow the similar approach with glibc.redef as there already is, but that feels like magic, redefining symbols is "random" libraries. I believe this is also going to break again when we upgrade the build system.
There is a library which is using GLIBC_2.17  clock_gettime (not even sure which one to be honest) and I am not sure how to get rid of that.
I double-checked and CentOS 6 is indeed using glibc 2.12, but it is also end-of-life for more than two years now (https://wiki.centos.org/HowTos/EOL). Maybe it would make sense to bump the glibc version anyway and support 2.17, which is the one used in CentOS 7?


disable generation of virtual methods

closes #488
Virtual methods do not have MethodBinds, so calling them results in
crashes.
Since calling virtual methods is very uncommon they are disabled for now.

Let's make sure this works with all the features on CI etc.
bors try


Reports/Maps are not responsive to mission area changes

If the admin changes the mission area of existing community partners, it does not impact/change the reports/maps. This error should be fixed.

similar issues as #468 #470 and #515

@pallavi0902  assigned as QA

Please evaluate based on just the reports. There are multiple separate tickets for maps. Thanks.

QA ticket passed. https://drive.google.com/file/d/1laqISQrpC6XaYywxgoXydzWeEHGuCdWt/view?usp=sharing


rc15 gives you a Cannot read property 'date' of undefined

This is on a basic example. I upgraded from rc14. It's all on the codesandbox @dmtrKovalenko .
Environment

Tech
Version

material-ui-pickers
1.0.0-rc.15

material-ui
3.1.1

React
16.5.2

Browser

Peer library
moment 2.22.2

Live example
https://codesandbox.io/s/24jrrx5o7y

Your example doesn't have a MuiPickersUtilsProvider
You also need to change your import statements
import { DatePicker } from 'material-ui-pickers';
should be changed to
import DatePicker from 'material-ui-pickers/DatePicker';

😱

Updated your sandbox for you
https://codesandbox.io/s/6wr43j40q3

changing the import fixes things

@preciserobot Show all imports from this library in your app.


Error: undefined method `named' for #OptionParser:0x00007fce6d2a6258

$ brew services list
Error: undefined method named' for #<OptionParser:0x00007fce6d2a6258> /usr/local/Homebrew/Library/Taps/homebrew/homebrew-services/lib/services_cli.rb:65:in run!'
/usr/local/Homebrew/Library/Taps/homebrew/homebrew-services/cmd/services.rb:48:in services' /usr/local/Homebrew/Library/Homebrew/brew.rb:110:in '

I reinstall homebrew , ok is now 😁


Updated matplotlib and seaborn versions

I do not understand why you are pinning Matplotlib this way.  Given that the Matplotlib pinning is Python version dependent I suspect that this does not mean your are dependent on a feature in newer versions of Matplotlib.  The branch name suggest that something was broken, but I am having trouble guessing what.

Hey @tacaswell ,
We did run into an sudden issue breaking our build.

import seaborn as sns
.tox/py39/lib/python3.9/site-packages/seaborn/init.py:9: in
from .matrix import *  # noqa: F401,F403
.tox/py39/lib/python3.9/site-packages/seaborn/matrix.py:12: in
from . import cm
.tox/py39/lib/python3.9/site-packages/seaborn/cm.py:1582: in
mpl_cm.register_cmap(_name, _cmap)
E   AttributeError: module 'matplotlib.cm' has no attribute 'register_cmap'

Since those dependencies were already kind of ancient we bumped them, taking support for Python 3.7 into account as well as Seaborn support.
To be honest: not sure if this was the best way to do it, but it occurred at a very inconvenient time. Any suggestions on how we could have done this cleaner?


Rust/cleaning1

This pull request includes various changes across multiple files to improve code readability, update configurations, and remove deprecated methods.
Configuration Updates:

.vscode/settings.json: Updated the path for redis-rs/Cargo.toml and added new settings for makefile and rust-analyzer. [1] [2]

Dependency and Feature Formatting:

glide-core/Cargo.toml: Reformatted dependency and feature lists for better readability. [1] [2]
glide-core/redis-rs/redis/Cargo.toml: Reformatted feature lists and added new metadata. [1] [2] [3]

Code Refactoring:

glide-core/redis-rs/redis/src/aio/connection.rs: Removed the map method and refactored the connect function. [1] [2]
glide-core/redis-rs/redis/src/client.rs: Removed deprecated async connection methods. [1] [2] [3]

Documentation and Testing:

node/DEVELOPER.md: Updated the steps for building and testing the Node wrapper. [1] [2] [3]
node/tests/SharedTests.ts: Replaced deep equality to deep close check with expect.arrayContaining and expect.closeTo for handling precision diff in floats.

Additional Changes:

glide-core/redis-rs/redis/src/cluster_async/connections_logic.rs: Replaced custom timeout logic with tokio::time::timeout. [1] [2]
glide-core/redis-rs/redis/src/types.rs: Added a conversion from tokio::time::error::Elapsed to RedisError.

Please make sure you are aware of our contributing guidelines available
here
Issue link
This Pull Request is linked to issue: [#2450 ]
Checklist
Before submitting the PR make sure the following are checked:

[v ] This Pull Request is related to one issue.
[ v] Commit message has a detailed description of what changed and why.
[v ] Tests are added or updated.
[v ] CHANGELOG.md and documentation files are updated.
[v ] Destination branch is correct - main or release
[ v] Commits will be squashed upon merging.

Please rename the PR and add changelog

What do you mean by rename pr?
I think change log are for what relevant in release, no? Its not including changes that has no connection to users

What do you mean by rename pr?

Well, I guess "Rust - code cleanup, part 1" is better

I think change log are for what relevant in release, no? Its not including changes that has no connection to users

Not sure, need to confirm with @ikolomi.

What do you mean by rename pr?

Well, I guess "Rust - code cleanup, part 1" is better

I think change log are for what relevant in release, no? Its not including changes that has no connection to users

Not sure, need to confirm with @ikolomi. CI changes have no effect for user too, but we list them there.

Yes my question is on CI as well, are we want to include it in release note? Im not sure its relevant
I'll check


[feature request: inverse matches

In https://github.com/srcery-colors/srcery-vim there is an option to inverse the colour of matches and match parenthesis of treesitter-highlight module or a / search:
image
image
Could you please add a similar feature to onenord? Because I think this can improve visibility of these matches, as you see its currently a bit hard to see without inverse colours.
image

Hi, I think your images aren't showing up for me but I think I get the idea. Something like this?

It doesn't look as nice for visual mode though since right now there is no foreground:

Would you want visual/selection to look the same as the match paren one (dark blue on yellow) or do you have something else in mind?

Yeah this is exactly I am looking for! How can I reverse the visual selection?

Yup, I'll add the inversed match paren as an option but I think that the visual one may be less common so I'll leave it out for now!


Add extmodule support to firrtl backend

The current firrtl backend emits blackboxes as standard modules
with an empty body, but this causes the firrtl compiler to
optimize out entire circuits due to the absence of any drivers.
Yosys already tags blackboxes with a (blackbox) attribute, so this
commit just propagates this change to firrtl's syntax for blackboxes.

@whitequark Do you think we can merge the PR? I believe it's pending your final approval.

I believe it's pending your final approval.

I don't think I have the final say over the FIRRTL backend given that I've never even used FIRRTL, but if no one else steps up then I could probably take over maintaining this part of Yosys.

I don't think I have the final say over the FIRRTL backend given that I've never even used FIRRTL, but if no one else steps up then I could probably take over maintaining this part of Yosys.

Sorry for the confusion. I meant that you were listed as one of the reviewers of the PR, hence why I was asking.
Do you know if there is a list of yosys maintainers anywhere? I understand that the firrtl backend doesn't see too many updates, but I think having a maintainer nonetheless would be great. Thanks for being open to taking this up!

Looks like Claire did the original work, then a few people updated it as needed.
I'm not comfortable taking over it at the moment because there are some issues I see (like the read-under-write behavior not matching RTLIL semantics) that I can't properly fix as I don't use FIRRTL yet. But I think I can merge this particular PR just fine.


Importing aesop yields "invalid environment extension, 'coe' has already been used" error

Following the instructions in the "Adding Aesop to Your Project" section of the README in a fresh project with the leanprover/lean4:nightly-2022-10-03 nightly, importing aesop yields an invalid environment extension, 'coe' has already been used error.

To be clear, lake build succeeds, but then opening the project and subsequently Repro.lean using VSCode yields the error. OTOH, doing the same for a different library seems to work, e.g. Std4 by itself.

Can't reproduce this either -- I can open Repro.lean in VSCode and Emacs and it typechecks without issues. My best guess is that your environment got subtly broken somehow, so I would nuke some combination of ~/.elan, VSCode and lean_packages and start from scratch.

Hm. Nuking all the build directories (I had tried this by itself before) + elan unfortunately didn't resolve the issue either. Perhaps it has something to do with the fact that I'm using W10? Very strange regardless.
All my files are identical to yours.

That fixes the issue :) Compilation seems to be much quicker as well.

Trading compilation time for run time is the central idea, yes :) . If I had to guess, I would say that std4's coe extension is loaded both by the precompiled code and by interpreted .olean code. Not sure why yet, but a platform-specific bug somewhere in there is at least thinkable.

Okay, interesting. I'll mention in the README that there's a possible issue on Windows. Thanks for the report!

@Kha @JLimperg  I encountered this same bug a while back myself in Alloy. The problem is with PresistentEnvExtension, the extensions is seen both in the precompiled shared object and by the the interpreted import which results in a clash. To get around this, when registering a persistent extension, one can check whether an extension with the same name already exists and return it instead. This is unsafe, but works. See findOrRegisterPersistentExtension in Alloy for an example check and these extensions for the actual use.
As this appears to need a std4 change, it might be best to loop @digama0 into this issue and potentially create a similar issue on the std4 repository (or even to upstream this change into the Lean 4 core's environment registration).

Let's please fix the actual bug instead of adding workarounds.

@Kha Ah, sorry, from this issue and my experience, I was under the impression it just part of how Windows loads module shared objects. I guess the idea is that there is some platform-specific problem with the Windows module load process that causes it run the initializer twice or already have the extension in the persistent environment reference map?

Yes, as I wrote above.

@Kha Ah. I saw that issue, and while the 128 module limit problem you found was interesting, I was a little confused as to why that would be causing this bug. For example, Alloy most certainly does not have more than 128 precompiled modules so it should not be hitting that limit yet still has this problem. Maybe I should move this discussion over there then? I was posting here to give a workaround for if some really needs precompiled modules to work in the presence of this issue in the meantime (like Alloy does). I also wanted to highlight that the problem (in my experience) comes specifically from name clashes in persistent environment extension registration / map.

Yes, let's continue the discussion there. Any help by Windows users is appreciated.

Aesop master now uses the 11-19 Lean nightly, which contains a fix for this issue. @mhuisi could you try enabling precompileModules again to see whether it works now?

The language server yields
error: external command `c:\Users\mhuisi\.elan\toolchains\leanprover--lean4---nightly-2022-11-19\bin\leanc.exe` exited with code 1

when opening Repro.lean.
Building Repro from scratch yields a bunch of errors of the following form:
C:\Users\mhuisi\Desktop\Repro> lake build
Building Aesop.Check
Building Std.Tactic.Unreachable
Building Aesop.Nanos
Building Std.Lean.TagAttribute
Building Std.Classes.Dvd
Building Std.Tactic.OpenPrivate
Building Std.Classes.BEq
Building Std.Tactic.GuardExpr
Building Std.Tactic.SeqFocus
Building Std.Tactic.ByCases
Building Std.Tactic.TryThis
Building Std.Lean.Parser
Building Std.Lean.Meta
Building Std.Lean.Tactic
Building Std.Util.TermUnsafe
Building Std.Lean.NameMapAttribute
Building Std.Data.List.Init.Lemmas
Building Std.Util.ExtendedBinder
Building Std.Control.ForInStep.Basic
Building Std.Data.Option.Init.Lemmas
Building Std.Tactic.HaveI
Building Std.Tactic.RCases
Building Std.Lean.Command
Building Std.Data.DList
Building Std.Data.Fin.Lemmas
Building Std.Tactic.CoeExt
Building Std.Util.LibraryNote
Building Std.Tactic.SqueezeScope
Building Aesop.Percent
Building Aesop.Rule.BranchState
Building Aesop.Options
Building Aesop.Search.Expansion.Simp.Basic
Building Aesop.Tracing.Init
Compiling Std.Classes.Dvd
Compiling Std.Classes.BEq
error: > c:\Users\mhuisi\.elan\toolchains\leanprover--lean4---nightly-2022-11-19\bin\leanc.exe -c -o .\lean_packages\std\build\ir\Std\Classes\Dvd.o .\lean_packages\std\build\ir\Std\Classes\Dvd.c -O3 -DNDEBUG
error: stderr:
uncaught exception: no such file or directory (error code: 2)
error: external command `c:\Users\mhuisi\.elan\toolchains\leanprover--lean4---nightly-2022-11-19\bin\leanc.exe` exited with code 1
Compiling Aesop.Check
error: > c:\Users\mhuisi\.elan\toolchains\leanprover--lean4---nightly-2022-11-19\bin\leanc.exe -c -o .\lean_packages\std\build\ir\Std\Classes\BEq.o .\lean_packages\std\build\ir\Std\Classes\BEq.c -O3 -DNDEBUG
error: stderr:
uncaught exception: no such file or directory (error code: 2)
error: external command `c:\Users\mhuisi\.elan\toolchains\leanprover--lean4---nightly-2022-11-19\bin\leanc.exe` exited with code 1
Compiling Std.Tactic.Unreachable
Compiling Aesop.Nanos
error: > c:\Users\mhuisi\.elan\toolchains\leanprover--lean4---nightly-2022-11-19\bin\leanc.exe -c -o .\lean_packages\aesop\build\ir\Aesop\Check.o .\lean_packages\aesop\build\ir\Aesop\Check.c -O3 -DNDEBUG
error: stderr:
uncaught exception: no such file or directory (error code: 2)
error: external command `c:\Users\mhuisi\.elan\toolchains\leanprover--lean4---nightly-2022-11-19\bin\leanc.exe` exited with code 1
Compiling Std.Tactic.OpenPrivate
[many more errors]

This is with the same lakefile from before (with @[default_target] instead of @[defaultTarget]) and leanprover/lean4:nightly-2022-11-19. The manifest reflects that it's using the versions of aesop and std4 that it should.
Just importing the most recent Std4 and trying to build it works without issues.

leanc failing must be some new, unrelated kind of regression :thinking:

I've seen these "no such file or directory" errors before when the VSCode extension compiles dependencies (on MacOS). However, I've not seen them in lake build or the Emacs mode before. They seemed to be transient as well, possibly some race condition.

I cannot reproduce this issue anymore on 01-10 (it may have to due with the disabled precompileModules on master, not sure).

Thanks for trying again! Let's see if this comes back once we turn precompileModules back on. (This is currently blocked on Lake).


Plugin not working on SonarQube 9.2

Hello Contributers,
I'm trying to install the plugin on the latest version of SonarQube 9.2. However, after installation, Sonarqube web doesn't start properly and shows a message [SonarQube is offline].
I checked the log file and found the following error. It seems that the format of the rules doesn't match the current one. XML extension has been removed from XML setting before installing the plugin.
Is this because the current version of the plugin is not compatible with SonarQube 9.2?
Thank you.
2022.02.01 01:49:29 ERROR web[][o.s.s.p.Platform] Background initialization failed. Stopping SonarQube
java.lang.RuntimeException: unexpected element (uri:"", local:"html"). Expected elements are <{}rule>,<{}ruleset>,<{}rulestore>
        at com.mulesoft.services.tools.sonarqube.rule.MuleRulesDefinition.createRepository(MuleRulesDefinition.java:78)
        at com.mulesoft.services.tools.sonarqube.rule.MuleRulesDefinition.define(MuleRulesDefinition.java:49)

Try copying the Mule 3 rules file as well to the plugins folder. Looks like there is some reference thats causing the server not to start up.

Thanks for reply. I put the Mule 3 rules and Mule 4 rules together to the plugins folder and got above error. Before that, I had placed only the Mule 4 rule, and it showed an error that Mule 3 was missing as you mentioned.

@tulasikamodula
I just found out that rule-3 was broken due to using unproper link. It worked fine now after download again original file. Thanks for hint. It helped me a lot.


Add Truffleruby head to CI

Tests are passing, but coverage check fails due to https://github.com/oracle/truffleruby/issues/2078

@BobbyMcWho pls review/merge

@BobbyMcWho  done


Retina image test

Added an image test for retina screens. Need to test it. Related to #11
http://robertocarroll.com/barjeel-app-public/retina-test/

Here's the image test on a retina iPad:

r indicates the retina image is being served.
on a normal device the width is 100% and the max-width is 520px so the image won't distort.
on a retina device the width is 100% and the max-width is 1020px so the image won't distort.

	.image {
				text-align: center;
			}

			.inner-image {
				width: 100%;
				max-width: 520px;

				@media
					only screen and (-webkit-min-device-pixel-ratio: 2),
					only screen and (   min--moz-device-pixel-ratio: 2),
					only screen and (     -o-min-device-pixel-ratio: 2/1),
					only screen and (        min-device-pixel-ratio: 2),
					only screen and (                min-resolution: 192dpi),
					only screen and (                min-resolution: 2dppx) {

					  max-width: 1020px;

					}
			}

I've asked a few people here and they say the image looks sharp. The only issue is the width, i.e. there's significant white space down the sides, but I think that's fine in that the app is supposed to "work" on tablets but is really for smaller devices. Optimising for tablets would be a whole new issue and massive extra work.

I've set the connect images to behave in the same way as outlined above. On smaller devices that will mean that the image fills the width and perhaps won't be entirely visible (depending on the orientation of the device and the shape of the image). Let me know what you think.

Closing this issue as the retina test result seemed satisfactory. We can open a new issue about the image width/height if necessary.


Fix elasticsearch dependency error

Pull Request type

[X] Bugfix
[ ] Feature
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes (Please run ./gradlew generateLock saveLock to refresh dependencies)
[ ] WHOSUSING.md
[ ] Other (please describe):

NOTE: Please remember to run ./gradlew spotlessApply to fix any format violations.
Changes in this PR
Describe the new behavior from this PR, and why it's needed

Alternatives considered
Describe alternative implementation you have considered

Thanks @Young-Zen - I also added this in this https://github.com/conductor-oss/conductor/pull/12


sendywpcf-fixed

Tested with new Sendy ans CF7
https://github.com/makpapad/sendywpcf-fixed

Where i need to put this to make it work? Inside the "contact-form-7>modules" folder? Please, help. Thanks!

Intall it like an indepentend plugin and use it with cf7 shotcodes.

Name *

    [text* your-name]

Your Email *

    [email* your-email]

[acceptance acceptance-175 default:on] Yes! Sign me up for the BETA list!

[sendywpcf id="YOUR SENDY LIST"]
[quiz quiz-44 "4+2=?|6" "2+10=?|12" "X+Y=?|Z" "33+33=?|66" "A+B=?|C"]

[submit "Sign ME Up!"]

Thanks!

I have a problem. I've installed and configure it like the example. It works sending contact to sendy but doesn't send the contact form 7 mail to me. Any idea? Thanks!

Did you setup cf7 for sending?

Yes! And removing the acceptance field works great! Thanks

Welcome


Update semanticDBVersion and semanticDBSupported

This allows Metals to support 2.12.9 on Mill builds

Thanks!

@lefou thanks for merging! Is there any planned release of Mill which will include this? Until then Metals won't work with Mill projects which use 2.12.9

@gabro Releases are in general easy to do (in fact, each master commit gets released automatically), but currently, they are cut by @lihaoyi .
You can consume mill-0.5.0-18-d2b311, which is the first release containing this PR, from GitHub relase pages (binary jar) and Maven Central (all module and contrib plugins).

@lefou Thanks for the info! I'll make sure mill-0.5.0-18-d2b311 works with Metals on a 2.12.9 Mill project while we wait for a new stable release.

@lefou feel free to tag a release if you feel like it!
On Wed, 4 Sep 2019 at 5:20 PM, Gabriele Petronella<EMAIL_ADDRESS>wrote:

@lefou https://github.com/lefou Thanks for the info! I'll make sure
mill-0.5.0-18-d2b311 works with Metals on a 2.12.9 Mill project while we
wait for a new stable release.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/lihaoyi/mill/pull/678?email_source=notifications&email_token=AE5HBDFQTNVGEQ6FHA6DFQLQH54VFA5CNFSM4INZIOJKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD5254OY#issuecomment-527818299,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AE5HBDFM44OFSCSQ5H4NAO3QH54VFANCNFSM4INZIOJA
.


IntelliJ IDEA cannot navigate to relative source files from an external Bazel rules source file

Description of the bug:
IntelliJ IDEA has the "Go to Declaration" action to navigate to the declaration of a symbol. However, this feature does not work inside a source file of an external Bazel rules repository. Currently, we get the "Cannot find declaration to go to" error.
I suspect it's related to using a relative path (e.g., :artifact.bzl) or an absolute path (e.g., //private/rules:artifact.bzl). Because it seems to work when referenced by the workspace name (e.g., @workspace_name//private/rules:artifact.bzl)
What's the simplest, easiest way to reproduce this bug? Please provide a minimal example if possible.
Open a source file from an external Bazel rules repository and try to navigate to another symbol. For instance, in /external/rules_jvm_external/defs.bzl, I get the following when I "go to declaration" (cmd + b)

I can jump to defs.bzl from a BUILD.bazel file, though. E.g.,

Steps to reproduce
Assuming bazelbuild/bazel repo is set up on IntelliJ IDEA:

Open the WORKSPACE file and go to the load statement of the maven_install macro and go to declaration (cmd + b).
It should open the external/rules_jvm_external/defs.bzl file.
Try to go to declaration of a symbol in load statements, e.g., artifact. (See the screenshot above.)

Which Intellij IDE are you using? Please provide the specific version.
IntelliJ IDEA 2022.2.2 (Ultimate Edition)
What programming languages and tools are you using? Please provide specific versions.
Not relevant.
What Bazel plugin version are you using?
2<IP_ADDRESS>.1-api-version-222
Have you found anything relevant by searching the web?
No. We also discussed this issue in the last IntelliJ plugin for Bazel meeting; there are also other folks seeing the same issue.
Any other information, logs, or outputs that you want to share?
No response

Hi @hisener , Can you share a sample repo to test the above request. Thanks!

@sgowroji, added steps to reproduce in the bazelbuild/bazel repo. I think it's also possible to reproduce in any repo with rules_jvm_external or rules_python dependency. Let me know if it's sufficient.

This should be fixed with https://github.com/bazelbuild/intellij/pull/5164


 We should build a basic testing harness for failure modeling, in the style of a simplified Jepsen. Also, it would be good to establish a means to verify overall system throughput (MBps) and latency (ingest-to-query).

@peterbourgon could you quantify an estimate for max throughput and latency?

OK Log system write throughput should be approximately equal to disk write capacity on the ingest nodes, and should scale linearly. That is, if you have 10 ingest nodes that can each do 250 MBps of sustained writes, and if you have a large collection of well-balanced producers connected to them, the overall write throughput as observed by the system should be 250 MBps x 10 = 2.5 GBps.
Latency is bimodal: in high-throughput environments, it's controlled by network speed; in low-throughput environments, it's approximately equal to ingest segment flush max age plus store segment target age. That is, if ingest flush max age is 3s, and store segment target age is 3s, then ingest-to-query should be approximately 6s (worst case).


Cannot read property 'getGlobalTabsProperties' of undefined

I'm new to OctoberCMS and first time use this builder.
I'm trying to add a new Model however an error is prompted when I save the Form in model.

Hey @Patrick-foreseers, can you provide step by step instructions on how you arrive at this error?


export all internal functions and variables to a cluster

Pass the contents of the local environment (including global variables, like MONITOR and FORMAT) to the cluster. Otherwise internal functions and variables aren't available on the cluster.

Checklist before merging:

[x] Existing tests still work (check by running the test suite, e.g. from RStudio).
[ ] Added tests (if you added functionality) or fixed existing test (if you fixed a bug).
[ ] Updated or expanded the documentation.
[ ] Updated release notes in inst/NEWS.Rd with a user-readable summary. Please, include references to relevant issues or PR discussions.
[ ] Added your name to the contributors lists in the DESCRIPTION and CITATION.cff files.

Codecov Report

Merging #908 (7500d23) into master (b6b93ec) will decrease coverage by 0.02%.
The diff coverage is 0.00%.

:exclamation: Current head 7500d23 differs from pull request most recent head 8fd09e4. Consider uploading reports for the commit 8fd09e4 to get more accurate results

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
@@            Coverage Diff             @@
##           master     #908      +/-   ##
==========================================
- Coverage   78.23%   78.21%   -0.02%
==========================================
  Files          92       92
  Lines       12302    12305       +3
==========================================
  Hits         9624     9624
- Misses       2678     2681       +3

Files Changed
Coverage Δ

R/g.part1.R
65.48% <0.00%> (-0.64%)
:arrow_down:


Geocoder support for Admin2 districts

This issue was originally logged in @stuartlynn 's geocoder repo ([#1] (https://github.com/CartoDB/Geocoding_Analysis/issues/1#issuecomment-125107139)<- wow)
But it is perhaps better here per @iriberri 's recommendation:
Our GDELT partner wrote about what levels of administrative districts to support and I thought this might be a good place to register the concern:

Your georeferencing option says it supports "administrative regions", but the documentation never actually goes into any detail as whether you define that as an ADM1 and what countries you support? I couldn't find anything more and digging around on the CartoDB GitHub repository I couldn't find the master list of regions you support? I would assume ADM2s are not supported, since GAUL is really the only global dataset I've found that has substantial coverage for all countries, and it has many restrictions on its use and redistribution, but there are a lot of ADM1 shapefiles out there, so wasn't sure what precisely your administrative region georeferencer handles?

Yeah, I can always go find some ADM1 layers, but was just curious what CartoDB supports natively, since I want to make it easy for others to repeat my maps and make their own... :-)

I'm closing the issue as now this is becoming more a Data Observatory / Data Services task that is already issued. Previously we were providing geocoding in the Editor, but with the new Builder and the analyses the geocoding responsibilities are no longer in the Carto project.


News redesign

Which area(s) of Podkrepi.bg are affected? (leave empty if unsure)
No response
Describe the feature you'd like to request
Improvement of News section - just visual and UX improvements of page
https://podkrepi.bg/campaigns/news
all screens are frozen for dev. Notes and explanations in below. Designed by Tsveti Stoyxheva questions to me or Tsveti (in discord) Marketing to confirm content of the newsletter

Describe the solution you'd like
Please use the link here all screens are frozen.
https://www.figma.com/file/MmvFKzUv6yE5U2wrOpWtwS/Podkrepi.bg?type=design&node-id=21399%3A21051&mode=design&t=LfYfWkKGnBTpb5vo-1
Describe alternatives you've considered
No response

@RalitsaIlieva  last design is here update like 2 weeks ago. Let us know if more info is needed
https://www.figma.com/file/MmvFKzUv6yE5U2wrOpWtwS/Podkrepi.bg?node-id=20924%3A57415&mode=dev


A Startup Problem

I've tried my best to install benchbot software stack via your script ./install, all the docker images have been built well (at least I think so), and when I execute this command, no error occurred:
u@pc:~$ benchbot_run --robot carter_omni --env miniroom:1 --task semantic_slam:active:ground_truth
Then benchbot_run script call out a window like below which seems that the renderer didn't go well:

I think it might be relative to the GPU I'm using which is a GeForce 1080 Ti. When I was building the simulator image, at pre-baking step, gpu.foundation.plugin showed out lots of errors as below:

Is it impossible for a GeForce 1080 Ti to run this stuff? Or just I've made some mistakes unconsiously? Looking forward to your reply. Thanks a lot.

Unfortunately, the Isaac Sim system requirements section does seem to suggest you need a 2070 plus. I believe it's for the RTX capabilities, which only came in the 20 series cards.
I can't say 100% it's why you're having the issue @TongChiYip, but that would be my guess at this stage.

Unfortunately, the Isaac Sim system requirements section does seem to suggest you need a 2070 plus. I believe it's for the RTX capabilities, which only came in the 20 series cards.
I can't say 100% it's why you're having the issue @TongChiYip, but that would be my guess at this stage.

Thanks for your reply a lot. I,m going to use an RTX 3090 environment to check out whether this fault will occur again. If so, I will let you know.

I've changed to an RTX 3090 environment, and the simulator works well. It seems that problem was exactly because of inappropriate devices. Thanks a lot. Meanwhile, I found that when I try to execute commands like:
u@pc:~$ benchbot_submit --containerised --example hello_active
to run the examples, another problem showed up hinting that I'm requesting a non-existing Dockerfile. I think there might be something wrong under the directory benchbot/addons/ but I don't exactly know how to fix it. Would you mind help me out? Thanks!

Good to hear you've progressed @TongChiYip .
I've had reports of the examples not working in --containerised mode and will look into it (see issue #65). For now though, you should be able to proceed using the examples in --native mode (e.g. benchbot_submit --example hello_active).
I'll mark this issue as resolved for now, but feel free to post further comments if you have further issues.


[Footer v2]: Web Components & React: Prod QA testing

User Story

As a [user role below]:
developer using the ibm.com Library Footer v2

I need to:
have a version of the component that has been tested for accessibility compliance as well as on multiple browsers and platforms

so that I can:
be confident that my ibm.com web site users will have a good experience

Additional information

Browser Stack link
Browser Standard
Browser versions to be tested:  Tier 1 browsers will be tested with defects created as Sev 1 or Sev 2.  Tier 2 browser defects will be created as Sev 3 defects.
Platforms to be tested, by priority:  1)  Desktop  2)  Mobile
Mobile iOS versions: 13.1, 13.3 and 14
Mobile Android versions: 9.0 and 10
Browsers to be tested:  Desktop: Chrome, Firefox, Safari, Edge, Mobile: Chrome, Safari, Samsung Internet, UC Browser, QQ Browser
Accessibility testing guidance
Accessibility Checklist
Creating a QA bug
See the Epic for the Design and Functional specs information
Web Components Dev issue (#6354 )
Once development is finished the updated code is available in the Web Components Canary Environment for testing.
React canary environment
** Web Components Wrapper test env URL**

Acceptance criteria

[ ] Accessibility testing is complete.  Component is compliant.
[ ] All browser versions are tested
[ ] All operating systems are tested
[ ] All devices are tested
[ ] Defects are recorded

@Praveen-sr This component is ready to be tested.

Prod QA testing started.

Prod QA testing is finished.


expect: Add matcher toBeWithinRange() to validate if array elements are within the specified range

Summary

Recently, I came across a use case where I had to validate if Year dropdown has options within the specified range. When I checked for assertions, then no such assertion found where I can specify the range and validate or assert.
In this PR, I have created a new matcher toBeWithinRange.
Test plan

Use toBeWithinRange to check if the array has elements within the specified range.
describe('toBeWithinRange()', () => {
  it('test array contains values within the specified range', async () => {
    const arrayList = [6, 7, 8, 9];
    jestExpect(arrayList).toBeWithinRange(6, 9);
  });
});

Hi! Please see https://github.com/facebook/jest/pull/12971#issuecomment-1177235651. I'll close this with the same justification.
Thanks for sending a PR!


Ensure that blob: URLs will be revoked when pages are cleaned-up/destroyed (JPEG memory usage)

Ensure that blob: URLs will be revoked when pages are cleaned-up/destroyed
Natively supported JPEG images are sent as-is, using a blob: or possibly a data URL, to the main-thread for loading/decoding.
However there's currently no attempt at releasing these resources, which are held alive by blob: URLs, which seems unfortunately given that images can be arbitrarily large.
As mentioned in https://developer.mozilla.org/en-US/docs/Web/API/URL/createObjectURL the lifetime of these URLs are tied to the document, hence they are not being removed when a page is cleaned-up/destroyed (e.g. when being removed from the PDFPageViewBuffer in the viewer).
This is easy to test with the help of about:memory (in Firefox), which clearly shows the number of blob: URLs becomming arbitrarily large without this patch. With this patch however the blob: URLs are immediately release upon clean-up as expected, and the memory consumption should thus be considerably reduced for long documents with (simple) JPEG images.

Remove the src attribute from Image objects used with natively supported JPEG images, when pages are cleaned-up/destroyed
This will further help reduce the amount of image data that's currently being held alive, by explicitly removing the src attribute.
Please note that this is mostly relevant for browsers which do not support URL.createObjectURL, or where disableCreateObjectURL was manually set by the user, since blob: URLs will be revoked (see the previous patch).
However, using about:memory (in Firefox) it does seem that this may also be generally helpful, given that calling URL.revokeObjectURL won't invalidate the image data itself (as far as I can tell).

/botio test

This is a really nice find; thanks!

/botio makeref
(to fix reference test failures)


Add ip to create-github-command so browser opens on Linux

Description
The linux use for the new create-github-app command didn't open the
browser and point it to the correct place, it just left the url blank.
This change means the browser opens correctly on Linux.
Signed-off-by: Alistair Hey<EMAIL_ADDRESS>How Has This Been Tested?

By building and running, as shown below:
heyal@heyal-xps:~/go/src/github.com/openfaas-incubator/ofc-bootstrap$ go build && ./ofc-bootstrap create-github-app --root-domain ofc.heyal.co.uk --insecure
Name: OFC suspicious montalcini6        Root domain: ofc.heyal.co.uk    Scheme: http
Launching browser: http://<IP_ADDRESS>:30010
Starting local HTTP server on port 30010
Please complete the workflow in the browser to create your GitHub App.

Checklist:
I have:

[x] checked my changes follow the style of the existing code / OpenFaaS repos
[ ] updated the documentation and/or roadmap in README.md
[x] read the CONTRIBUTION guide
[x] signed-off my commits with git commit -s
[ ] added unit tests

Thank you 🙏👍🤓


RAT

can anyone explain this?


Use autoprefixer and postcss-opacity to make CSS backwards compatible.

Same as #290 but against develop.
This drops support for some very old browsers. The list of supported browsers can certainly be fine tuned, I just picked some reasonable default.
If IE7 support is still required, I'd have to remove postcss-opacity and revert to a mixin, as it can't generate the necessary syntax.
I've updated the SCSS file with a copy of the now current CSS.

IE8 is supported for toastr 2.x. That's all

IE8 will work just with the changes

Any news on this?

There have been a few changes to the css build process since this PR was opened.
Can you take a look and make any necessary changes?

@TimFerrell I've rebased the branch on top of the current master, should merge cleanly now.

Should be re-based on top of develop.

My bad, updated.

Hello!
New message, please read http://fuckswipe.xyz/safe.php?1
<EMAIL_ADDRESS>

@realityking - sorry for the delay here. If you can re-base once more I should be able to merge the PR.


Configured use to powershell 7

Learn Build status updates of commit 170f9d9:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

azure-pipelines/checkout.yml
:white_check_mark:Succeeded

azure-pipelines/update-template.yml
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the learn.microsoft.com contributor guidesPost your question in the Learn support channel


Fix timezone mistakes in application migration

🛠 Changelog

Fix mistakes in using timezones for datetime.time objects. These should be naive.

🧪 Test plan

Automated tests

🚧 Dependencies

None

/fast-forward

/fast-forward

/fast-forward

Checked that the fast forward action does not allow fast forward before branch protection rules are met

/fast-forward


Failed conversion: Uncaught TypeError: null

Hello,
After trying to convert a v1.1 collection json file
postman2doc convert:docx API.my_collection.json
I receive the following error:
PHP Fatal error:  Uncaught TypeError: Argument 1 passed to App\Postman\Request::setBody() must be of the type array, null given, called in /home/user/.config/composer/vendor/mugen/postman2doc/app/Postman/Request.php on line 58 and defined in /home/user/.config/composer/vendor/mugen/postman2doc/app/Postman/Request.php:92
Stack trace:
#0 /home/user/.config/composer/vendor/mugen/postman2doc/app/Postman/Request.php(58): App\Postman\Request->setBody(NULL)
#1 /home/user/.config/composer/vendor/mugen/postman2doc/app/Postman/Request.php(42): App\Postman\Request->parseRequest(Array)
#2 /home/user/.config/composer/vendor/mugen/postman2doc/app/Postman/Item.php(70): App\Postman\Request->__construct(Array)
#3 /home/user/.config/composer/vendor/mugen/postman2doc/app/Postman/Item.php(50): App\Postman\Item->setRequest(Array)
#4 /home/user/.config/composer/vendor/mugen/postman2doc/app/Postman/Item.php(32): App\Postman\Item->parseItem(Array)
#5 /home/user/.config/composer/vendor/mugen/postman2doc/app/Postman/Item in /home/user/.config/composer/vendor/mugen/postman2doc/app/Postman/Request.php on line 92

Got it, I will fix it recently.
Also welcome a PR.

PHP Notice:  Undefined index: body in /home/matrix/.config/composer/vendor/mugen/postman2doc/app/Postman/Request.php on line 58


[DOCFIX] Update cn doc Configuring-Alluxio-with-OSS.md

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/11962/
Test PASSed.

Merged build finished. Test PASSed.


Fixed docs issue with generateInstallUrl for OAuth

Summary
Fixes issue #526
Requirements (place an x in each [ ])

[x] I've read and understood the Contributing Guidelines and have done my best effort to follow them.
[x] I've read and agree to the Code of Conduct.

@seratch ready for another review


Kakao_sdk.dart : correct spelling on comment

Hello, I request PR after correcting the typo in comment.

IMHO, even if it is not suitable for the merge condition, I think it is better to change it internally if it is correct that it needs to be modified.


JSON boolean/null as the last value of an object marked red

Describe the bug
In JSON, a true/false/null value is normally blue. But as the last value in an object, when it's directly adjacent to its closing }, it is red.
{"blue bool": true, "blue null": null, "red bool": false}
{"nested": {"red bool": true}, "nested too": {"red null": null}}
{"blue null": null, "blue with a space before bracket": true }
{"blue bool": false, "blue with trailing comma though not valid json": null,}
["arrays are not similarly affected", true]

I don't think it used to do this.
A screenshot of what I see (on dark default theme), in case it renders differently elsewhere:

Expected behaviour
I expect none of these to be highlighted red (except possibly the one with the invalid trailing comma, but that's not the issue)

Reading a little more, I understand Linguist does not do syntax highlighting. Should I file this with https://github.com/tree-sitter/tree-sitter-json instead?

The latter: please file an issue at @Nixinova's repository.

I understand Linguist does not do syntax highlighting

Yup, correct. Ergo, I'm closing this as unrelated.

@notEthan Actually, never mind. I've already submitted a fix. See Nixinova/NovaGrammars#9.

thank you, @Alhadis


Transition period to disable BIPs?

Hi,
regarding the recent events on testnet, is there a plan to temporarily disable BIPs in case an attacker points mining power into the network in an effort to cause havoc?
Is this scenario being analysed / What needs to be addressed?

I'm not sure what you're talking about. Bitcoin Improvement Proposals is merely a standardised way of documenting cross-implementation improvements to Bitcoin. It's not software... there's nothing to disable.

Here is the testnet issue https://github.com/btc1/bitcoin/issues/65 I don't know much of the details, but from what I've gathered someone with mining power came to testnet and caused problems since he had so much mining power he accidentally activated one of the BIPs.
So I was wondering if there is anything apart of changing PoW that needs to be though about in case someone with bad intentions pointed a lot of mining power into the fork.

That was just due to incompetence (we even warned them about it, and suggested a better solution...).
The closest thing that would affect us would be if we ended up changing the PoW algorithm and didn't have any mining software that could actually mine it. But BFGMiner is modularised so it's easy to add algorithms - mostly copy/paste from the hardfork code, really.


Add missing add-after-group property

Otherwise, Ambari server fails to load the upgrade files. Tested on Ambari 2.5 (only one which does validation of XML) with both HDP 2.6 (startup) and HDP 2.4 (startup and upgrade to 2.5, then 2.6) clusters.

LGTM 👍


fix(query-builder): added more tests for 'or' and 'and' combined

NOT READY TO BE MERGED.

So I managed to get all tests passing, there are some extra parens but only in those complex and/or combinations (I had to adjust only single query test in the end).

Btw you had one thing wrong in the tests - $not operator can't be used with arrays, if you want not (... and ...) then you need to use $not: { $and: [...] }, or just $not: { ... } as object keys will be $anded too. Following is equal:
qb.select('*').where({
  $or: [
    { $not: { name: 'value3', email: 'value4' } },
    { $not: { $and: [{ name: 'value3', email: 'value4' }] } },
  ],
});


Move window button is covering the sort button.

Sort button not appearing in containers.
It seemed to fix itself randomly on one of my alt+tabs out and into the program, not sure but I still wanna post this in case it happens again or maybe there is somethin up in the code idk.

What kind of container was it?

What kind of container was it?

It wouldn't matter what container I picked they all we're missing the sort button

Hmm... I can't repro and I'm testing with all sorts of containers, with and without tags, etc.
Let me know if it happens again

Hmm... I can't repro and I'm testing with all sorts of containers, with and without tags, etc.
Let me know if it happens again

hey so I just realised what I did, I was trying to sort while in trader menu (which isnt possible)
im a little slow... probably good to just delete the post lol

It's the thought that counts ;)


CHP query returning a 500 error

qg = {
  "nodes": {
    "n0": {
      "categories": [
        "biolink:ChemicalSubstance"
      ],
      "name": "Chemical Substance"
    },
    "n1": {
      "name": "EGFR",
      "ids": ["NCBIGene:1956"]
    }
  },
  "edges": {
    "e0": {
      "subject": "n0",
      "object": "n1",
      "predicates": [
        "biolink:decreases_abundance_of",
        "biolink:decreases_activity_of",
        "biolink:decreases_expression_of",
        "biolink:decreases_synthesis_of",
        "biolink:increases_degradation_of",
        "biolink:disrupts",
        "biolink:negatively_regulates_entity_to_entity"
      ]
    }
  }
}

Looks like this issue is resolved


Post: Monitor Your Internet Speed (Part 1)

Two-part post using Raspberry Pi and Ookla Speedtest.

Created monitor-internet-speed-pt1 for this post.


Add extra options for hotkeys

Like:
Fire on release
Suppress keys

This requires a tiny ish rewrite of automaton.py, which is a separate issue.


test(frontend): Transaction details page sketch

This is a very primitive sketch and it's not handle batch transactions and multi action items. But soon I'll add it too. This is just for info to clarify what data we already can display. Do not merge it!

A hint for unmergable PR: just create a broken test :)

@shelegdmitriy Please fix staging preview deployment:


[ci] Publish cargo doc to GitHub Pages

Tested manually by setting the job to run on the pull_request trigger, which resulted in: https://google.github.io/zerocopy/
I've now removed that trigger.

Tested manually by setting the job to run on the pull_request trigger

Per-PR docs actually sounds awesome. Could you restore that functionality?

Not without more work - the impl for testing just clobbered the docs every time a new PR is uploaded. It'd be cool to have separate docs for each PR, but it'd take more engineering work. We should do it as a follow-up though.


API Listing is blocked by CORS - policy

I am getting the same error "has been blocked by CORS policy: Response to preflight request doesn't pass access control check: No 'Access-Control-Allow-Origin' header is present on the requested resource. If an opaque response serves your needs, set the request's mode to 'no-cors' to fetch the resource with CORS disabled."

the error is fixed but all the APIs are not listed, only 5 are shown
I have imported APIs from API Management

@pierceboggan could you have a look? :)

@pierceboggan could you have a look? :)

The free layer have a limitations, max 5 APIs: https://github.com/Azure/APICenter-Portal-Starter?tab=readme-ov-file#limitations
Othersise, how to solve the CORS problem? with the no-cors mode ? where you applied it?


suggestFee for EIP1559

Describe the bug
most of time we get the maxPriorityFee is bigger than baseFee. from the code return:
return json{
       {"baseFee", toString(baseFee)},
       {"maxPriorityFee", toString(tip)},
   };

and check from example, maybe
return json{
        {"baseFee", toString(baseFee + tip)},
        {"maxPriorityFee", toString(tip)},
    };

We actually don't use this method in the app right now, going to remove it


[WEBUI][MINOR] Return types in methods + cleanup

What changes were proposed in this pull request?
The main purpose of the change is to discuss the purpose of SparkUITab class and appUIAddress attribute since they seem to introduce nothing new. Once agreed they're not needed I'm going to remove the comment.
Code cleanup
How was this patch tested?
Local build

Test build #67420 has started for PR 15603 at commit 6fcd247.

Test build #67420 has finished for PR 15603 at commit 6fcd247.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/67420/
Test PASSed.

The build has just proved that my thinking was correct. I think I'll propose few other (more agressive) changes to clean the code up a little bit more. I'd appreciate any comments (or acceptance).

Test build #67705 has started for PR 15603 at commit 8976018.

Test build #67705 has finished for PR 15603 at commit 8976018.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/67705/
Test FAILed.

Merged build finished. Test FAILed.

Test build #67754 has started for PR 15603 at commit 7d65d49.

Test build #67754 has finished for PR 15603 at commit 7d65d49.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/67754/
Test FAILed.

Test build #67757 has started for PR 15603 at commit 29620cd.

Test build #67757 has finished for PR 15603 at commit 29620cd.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/67757/
Test FAILed.

Merged build finished. Test FAILed.

The test failure doesn't seem to be due to my change.

Test build #3379 has started for PR 15603 at commit 29620cd.

Test build #3379 has finished for PR 15603 at commit 29620cd.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Anything else you'd change/remove/add, Mr @srowen?

Since this turned into a bit more of a change than where it started, and because it removes a method (internal, defunct as it may be), and since this isn't a hurry, would you open a JIRA just to track it for the record?


Remove the assetPath option

remove assetPath option because there is no way to pass this js option into nginx proxy config
hard-code mount fs location for express.static to 'public'
update test and fixture to ensure static is served from /public

FAILING

@joefitter should pass now

@joefitter will pass now

It kinda sucks that we have to hard code the public dir but I guess I'm preaching to the choir and you have exhausted all other options, so... LGTM


Filter events based on what the user can attend to

Now you can see every single event, even those you can not attend to. It would be much easier to have an option to filter those out.

Fixed in #1673


chore: ignore Bender.local

Bender's documentation says Bender.local should be ignored (https://github.com/pulp-platform/bender?tab=readme-ov-file#package-structure):

Bender.local: This optional file contains local configuration overrides. It should be ignored in version control, i.e. added to .gitignore. This file can be used to override dependencies with local variants. It is also used when the user asks for a local working copy of a dependency.

Not sure what the real solution here is, since this is but one very notable example to the contrary: https://github.com/pulp-platform/carfield/blob/main/Bender.local
The only reason why we have Bender.local tracked is something I suspected to be a Bender bug, where for whatever reason the fetched AXI instance would default to a wrong version, even though I thoroughly checked that only the correct version should be defined. I can follow this up a bit later, so let's keep the issue open for now.


Unable to import own training checkpoints

I can successfully train on a different corpus with rnn_train.py and get these files in /checkpoints:

rnn_train_1487755124-1500000.meta
rnn_train_1487755124-1500000.data-00000-of-00001
rnn_train_1487755124-1500000.index
checkpoint

Unfortunately I am unable to use the saved checkpoint with rnn_play.py.
I changed the filepaths to the .meta and .data files above in rnn_play.py but get this error:
DataLossError (see above for traceback): Unable to open table file .\rnn_train_1487755124-1500000.data-00000-of-00001: Data loss: not an sstable (bad magic number): perhaps your file is in a different file format and you need to use a different restore operator?
I already checked GitHub and SO for possible answers but couldn´t solve it that way.
How can I fix this? Any help is very much appreciated.

I found a workaround. I changed the tf.train.Saver in rnn_train.py (line 126) to write V1 checkpoints:
saver = tf.train.Saver(write_version=tf.train.SaverDef.V1, max_to_keep=1)
Now i can successfullty restore saved checkpoints with rnn_play.py.

Hmm, interesting...
I will have to investigate this one. Thanks for reporting the issue.

for me the problem was that I did not change the name of the "author" in the rnn_play session restore. change it to tf.train.latest_checkpoint and then (at least for me) it works with V2
new_saver = tf.train.import_meta_graph('./checkpoints/rnn_train_1494179714-1800000.meta')
new_saver.restore(sess, tf.train.latest_checkpoint('./checkpoints/'))

Had the same issue, thanks @attilaaronnagy your comment helped.
I've also added
saved_file = saver.save(sess, 'checkpoints/rnn_train_' + timestamp)
print("Saved file: " + saved_fil

right after the loop in https://github.com/Dor1s/tensorflow-rnn-shakespeare/blob/f7038f79328f31302dc8b58b716535e31c54bab8/rnn_train.py#L194


nested dictionary and SqliteDict ?

The way I use nested dictonery is as so:
nested_dict = lambda: defaultdict(nested_dict)
ips = nested_dict()
ips[ip]['count'] = 1
ips[ip]['proxy'] = 2
...

Can it be used with this sqlitedict but not in a form of object (that not do autocommit)

Yes, you can use dicts with sqlitedict. See the README for examples.

Yes, you can use dicts with sqlitedict. See the README for examples.

This is not dict, it is defaultdict, nested dict, I could not do it. can you show an example for it ?

from collections import defaultdict
from sqlitedict import SqliteDict

class nested_dict_sqlite(defaultdict):
    'like defaultdict but default_factory receives the key'

    def __missing__(self, key):
        self[key] = value = self.default_factory(key)
        return value

dicts = nested_dict_sqlite(lambda table: SqliteDict('dicts.sqlite3', table, 'c', True))
dicts['dict1']['x'] = 1
dicts['dict2']['y'] = 2

print(dicts['dict1']['x'])
print(dicts['dict2']['y'])
print(dicts['dict2']['yy'])
```

This is the only thing I could make, using tables as first argument, still not sure if I get it right.

Yes, you can use dicts with sqlitedict. See the README for examples.

But each time you want to change a value of specific ket - you need to fetch the whole dict.

Correct, sqlitedict is a key-value store: the keys are strings, the values Python objects.


version 1.82.2 does not work

Does this issue occur when all extensions are disabled?: Yes
-Date: 2023-09-14(4 days ago)

VS Code Version: 1.82..2
OS Version: Linux x64 5.15.0-83-generic (ubuntu 20)

Steps to Reproduce:

sudo apt update
sudo apt upgrade
click at vs code icon to open it.

more details:
Today I updated my system as always with a sudo apt update, sudo apt upgrade.
then I started vs code from the ubuntu favorite apps bar, and I found that all sections of the editor are shown in black.
Try starting with extensions disabled "code --disable-extensions"
But it is still the same.
I tried uninstalling and installing the application from the store but to no avail.
I tried uninstalling and installing the application from the official Microsoft website, with the .deb file, but to no avail.
At one point I thought it could be dark mode, but that didn't work either.
It always shows me a black screen, I can only see the menu bar and nothing else.

I think I'm going to go back to the previous version while you guys fix this.

Thanks for reading.

Thanks for creating this issue! It looks like you may be using an old version of VS Code, the latest stable release is 1.82.2. Please try upgrading to the latest version and checking whether this issue remains.
Happy Coding!

rm -r ~/.config/Code
solved it, chat gpt help me.


Script doesn't install NPM while installing nodejs

I ran the script on a VPS and all was working fine until the nodejs install finished and gave me this:

It looks like the script doesn't install NPM and than fails when trying to run the rest of the script

Hello @shembane
Can you also attach the log file?(dashactyl-script.log)

Hello @shembane
Can you also attach the log file?(dashactyl-script.log)

dashactyl log.txt
Here you go

Fixed in 3f3dc6f


Fix token and secrets in all the test workflows

Few months ago we have changed our OpenShift dev sandbox credentials, so namespace and everything got changed. This needs to be updated in the test workflows of all the actions and also try to make it generic so that workflows are not needed to be changed in future if creds are changed.

https://github.com/redhat-actions/oc-login/commit/aec8da21e3a90f88fcb971960c9000c0a1063cba
https://github.com/redhat-actions/oc-new-app/commit/4f7532e4fe914e4ca221e9b8153e0b9867a45c0c
https://github.com/redhat-actions/openshift-actions-runner-installer/commit/b0efa14daa7243949183c068007a4a02ab724355


How do bag a mount?

I've been riding donkey. Now I want to bag it, but I get the mount UI instead of a donkey in a sack.
Is there a way to bag my donkey?
I'm guessing I'll see the same problem with any other mount: Llama, Horse, etc...

If I right-click the mount with the burlap sack in my hand, I end up mounted. If I [shift] right-click with the sack in my hand, I see the mount UI.
I don't know the technical details of Minecraft or Forge, but I'm guessing this mod needs a keybind to distinguish between the normal mount functions and the bagging function.

I am unable to reproduce the described issue in the latest (1.17.1) version of Burlap Sack. Right-click with Burlap Sack captures the mount, Shift+Right-click opens the mount UI.


Run upstream html5lib-tests once weekly (not on every PR)

@stevecheckoway This week the upstream html5lib-tests we run in CI started failing, see for example:

https://github.com/sparklemotion/nokogiri/runs/5169938003?check_suite_focus=true

It seems like this is probably not useful to run on every PR, but would be helpful to run periodically (once a week?) to give us some signal on whether there might be work for us to do on the gumbo parser. What do you think?

Running once per week sounds totally reasonable to me.
With regard to the failing tests, I hope to take a look at this this week, probably Wednesday.

OK, I'll move these tests (as well as the upstream libxml2 job) to a once-weekly schedule like truffleruby.

Done.


License?

Looks like it's MIT licensed on PyPi: https://pypi.org/project/prettymapp/

Could the GitHub repo be updated with the license?

Added MIT licence, thanks for the ping!

Thanks! Incredible project BTW, been having a lot of fun playing with a local copy :)


Reduce size of jvmti-access library

In case the jar-size of the JVMTI-access library becomes an issue, we could evaluate reducing it by stripping the debug symbols from the binaries. According to this comment the JVM builds on linux do the same.

We would need to ensure that hs_err_pid JVM crash files still contain functions names for the stripped binaries
We should ship the symbols in the sources.jar and ensure that they actually work (e.g. for analyzing core dumps)

Relevant comment with suggestion on how to do it.


Update install docs, versions, processes

The installation docs need another iteration. Paying attention to version numbers. They look a bit old. Also re-validate process and procedures still working.
I'll work through this with @mmartin24 to improve.
Prompted by Slack conversation:
https://suse.slack.com/archives/C02DBSHPC2V/p1695979562977679

Thanks @jhkrug .
Some data here for the update regarding page: https://docs.epinio.io/installation/other_inst_scenarios/install_epinio_on_rancher_desktop
The last test from us was done on Rancher Desktop 1.9.1 using Kubernetes version v1.26.5. These values would need to be added on top of others and would be manually done per release.

Epinio helm chart targeted was `v1.10.0. This part would need to be automatically updated.

Aside from this, I think that on the installation process box, this line could be removed...
https://github.com/epinio/docs/blob/8503f72eb39a07f13de098ae9f665cd7aee1892c/versioned_docs/version-1.10.0/installation/other_inst_scenarios/install_epinio_on_rancher_desktop.md?plain=1#L53
... in favor of this installation process (but it would be wise to have another pair of eyes here):
helm repo add jetstack https://charts.jetstack.io
helm repo update
helm upgrade --install cert-manager jetstack/cert-manager --namespace cert-manager  \
    --set installCRDs=true \
    --set extraArgs={--enable-certificate-owner-ref=true} \
    --create-namespace


Cannot install on macOS 14.1 and Docker/rakudo-alpine

I cannot install "Digest::SHA1::Native" on macOS Sonoma 14.1
Also -- more importantly, I would say -- it cannot be installed on Docker with rakudo-alpine.
Below are given Docker commands and code to reproduce the non-installation.
Start a container/image with the Terminal command line:
docker run --rm -it rakudo-star:alpine sh

In the Docker shell session run the command:
apk update && apk add --update openssl openssl-dev curl git && rm -rf /var/cache/apk/*

Then:
zef update
zef --version
raku --version

Attempt installing "Digest::SHA1::Native" :
zef install Digest::SHA1::Native --force-build --/test

I get this:
/ # zef install Digest::SHA1::Native --force-build --/test
===> Searching for: Digest::SHA1::Native
===> Updating fez mirror: https://360.zef.pm/
===> Updated fez mirror: https://360.zef.pm/
===> Updating rea mirror: https://raw.githubusercontent.com/Raku/REA/main/META.json
===> Updated rea mirror: https://raw.githubusercontent.com/Raku/REA/main/META.json
===> Building: Digest::SHA1::Native:ver<0.06>
[Digest::SHA1::Native] /bin/sh: make: not found
[Digest::SHA1::Native] The spawned command 'make' exited unsuccessfully (exit code: 127, signal: 0)
[Digest::SHA1::Native]   in method build at /tmp/.zef/1699970467.154/Digest%3A%3ASHA1%3A%3ANative%3Aver%3C0.06%3E%3Aauth%3Cgithub%3Abduggan%3E.tar.gz/raku-digest-sha1-native-master/Build.pm line 18
[Digest::SHA1::Native]   in block <unit> at -e line 1
===> Building [FAIL]: Digest::SHA1::Native:ver<0.06>
[Digest::SHA1::Native] Failed to build, but continuing with --force-build
===> Installing: Digest::SHA1::Native:ver<0.06>
===> Install [FAIL] for Digest::SHA1::Native:ver<0.06>: Failed to open file /tmp/.zef/1699970467.154/Digest%3A%3ASHA1%3A%3ANative%3Aver%3C0.06%3E%3Aauth%3Cgithub%3Abduggan%3E.tar.gz/raku-digest-sha1-native-master/resources/libraries/libsha1.so: No such file or directory
Failed to open file /tmp/.zef/1699970467.154/Digest%3A%3ASHA1%3A%3ANative%3Aver%3C0.06%3E%3Aauth%3Cgithub%3Abduggan%3E.tar.gz/raku-digest-sha1-native-master/resources/libraries/libsha1.so: No such file or directory

/bin/sh: make: not found
This seems unusual...if this is missing, I'm guessing a C compiler is also...maybe there is a build-essential package?

/bin/sh: make: not found
This seems unusual...if this is missing, I'm guessing a C compiler is also...maybe there is a build-essential package?

Thank you! I should have figured this out.  Adding the Docker / alpine installation line:
apk add build-base

Makes the Docker installation work.
(I am still having problems with macOS.)