[desktop] FrostWire for Desktop can't detect latest version of PIA on Windows.

The solution is to get the interface ID for PIA and then check the active routes and see if it's there.

by parsing the output of netstat -nr possibly using regex.

more likely is a minor variation on the description string https://github.com/frostwire/frostwire/blob/master/desktop/src/com/limegroup/gnutella/gui/VPNs.java#L84

what I've noticed is that the ID of the network adapter listed for PIA appears as one of the active network adapters once the PIA connection is established.

oh I see, forgot that we get that through libtorrent, yes, they did change the name :)
That's gonna make it a lot easier.
Thanks so much @aldenml
Miss you buddy.

yes, it worked!
9441601a86b2598ee3d751f9c716b0d0be95b378


Game crash when creating a new world

i just downloaded the lastest template folder and putted it in the monecraft folder but it keeps crashing when i create a new world... i tried redownloading all but still crashing...

ok... for everyone that have the same problem its just that the first map loading is REALLY long to load took me 5 minutes so try to wait 5 minutes.

yup, that is normal, it depends on the speed of your hard drive to copy the template over.


Update scalacheck to 1.17.0

Updates org.scalacheck:scalacheck from 1.16.0 to 1.17.0.
GitHub Release Notes - Version Diff
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Adjust future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "org.scalacheck", artifactId = "scalacheck" } ]

Or, add this to slow down future updates of this dependency:
dependencyOverrides = [{
  pullRequests = { frequency = "@monthly" },
  dependency = { groupId = "org.scalacheck", artifactId = "scalacheck" }
}]

labels: test-library-update, early-semver-minor, semver-spec-minor, commit-count:1

Superseded by #715.


Issue in moyaser 2.0.2

../../AppData/Local/Pub/Cache/hosted/pub.dev/moyasar-2.0.2/lib/src/widgets/network_icons.dart:8:18: Error: Cannot invoke a non-'const' constructor where a const expression is expected.
Try using a constructor or factory that is 'const'.

Hey @devm7mdibrahim 👋
Can you please share more information about the issue?
Device (iOS/Android)
Physical/Simulator
OS Version
The PaymentConfig object used to initialize the widget

Hey @Fghurayri ,
Dart 2.19.4
Flutter 3.7.7
Android
Physical
13
final paymentConfig = PaymentConfig(
publishableApiKey: PaymentStrings.publishableApiKey,
amount: amount,
description: 'order #1324',
metadata: {'size': '250g'},
applePay:
ApplePayConfig(merchantId: PaymentStrings.merchantId, label: 'xxxxx', manual: false),
);

@devm7mdibrahim I'm not able to reproduce the issue. Looking at the path you've shared, the issue is most likely related to caching. Here are various ways to clearing the cache: https://stackoverflow.com/questions/49279379/how-to-clear-flutters-build-cache


YouTube card

We can show an interactive YouTube player similar to our HTML5 video player.
https://github.com/Microsoft/BotBuilder/issues/1984

I guess the thing to do here is to sniff out the youtube domain from video file URLs and present them in a custom player. What other video providers would we support specially?

I've been poking around at how to do this, and I think one could sniff the youtube domain and video ID in the Media component, and render an iframe with the youtube video embed URL instead of a video. Some parameters for this function can also be used and passed along to the embed URL. Seems like this would be the way to go: https://developers.google.com/youtube/player_parameters#Overview
As far as other video providers go, I would suggest vimeo and facebook.

sounds good to me!

Vimeo players also appear to be embeddable via iframe, similar to how the youtube player is built (see #303). I'm also working on an implementation of this.

implemented by a number of recent PRs. Thanks, @bnookala!

Thanks @bnookala !!

I'm using this code to send youtube video :
Activity replyToConversation = activity.CreateReply("Should go to conversation, with a hero card");
               replyToConversation.Attachments.Add(new Attachment(contentType: "video/mp4", name: "Simple Attachment Name", thumbnailUrl: "https://s29.postimg.org/ei98jsp7r/My_Bot.jpg", contentUrl: "https://youtu.be/A9Vu9n7YxrI"));
               await connector.Conversations.ReplyToActivityAsync(replyToConversation);

But doesn't work.
Any idea ? I read that you implemented this but i don't know how to use :D
Thank you in advance guys :)

I can't speak to the C# SDK, but this is working for me in the Node SDK:
            const msg = new builder.Message(session);
            msg.addAttachment({contentType: 'video/mp4', contentUrl: 'https://youtu.be/A9Vu9n7YxrI'} as builder.IAttachment);
            session.send(msg);

I don't think this is the cause of your issues, but note that there are several kinds of video cards. My code above is the simplest kind - it only allows the URL of the video. You can also send one of contentType: application/vnd.microsoft.card.video which has many more options including a thumbnail image, auto looping, etc.

For c# there is no .video property  : https://docs.botframework.com/en-us/csharp/builder/sdkreference/dd/d32/_additional_properties_8cs_source.html

hero cards and video cards are two different things

Yes. I found out in docs.
https://docs.botframework.com/en-us/csharp/builder/sdkreference/d7/d82/_video_card_8cs_source.html

Why it doesn't show up ?
http://prntscr.com/eh163q
code :
resultMessage.AttachmentLayout = AttachmentLayoutTypes.Carousel;
resultMessage.Attachments = new List();
VideoCard video = new VideoCard()
{
Title ="title"
Media = getMedia(activities[counter]),
};
and my getMedia function :
 public IList<MediaUrl> getMedia (ActivityModel model)
        {
            IList<MediaUrl> mediaUrl = new List<MediaUrl>();
            MediaUrl item = new MediaUrl();
            item.Url = model.DocumentPath;
            mediaUrl.Add(item);
            return mediaUrl;
        }

@lonche There's a Sample for That ™ ;)
https://github.com/Microsoft/BotBuilder-Samples/blob/master/CSharp/demo-CardsAttachments/public-TestBot/Scorables/RichCards/VideoCardScorable.cs
new VideoCard

                {

                    Title = "Big Buck Bunny",

                    Subtitle = "by the Blender Institute",

                    Text = "Big Buck Bunny (code-named Peach) is a short computer-animated comedy film by the Blender Institute, part of the Blender Foundation. Like the foundation's previous film Elephants Dream, the film was made using Blender, a free software application for animation made by the same foundation. It was released as an open-source film under Creative Commons License Attribution 3.0.",

                    Image = new ThumbnailUrl

                    {

                        Url = "https://upload.wikimedia.org/wikipedia/commons/thumb/c/c5/Big_buck_bunny_poster_big.jpg/220px-Big_buck_bunny_poster_big.jpg"

                    },

                    Media = new List<MediaUrl>

                    {

                        new MediaUrl()

                        {

                            Url = "http://download.blender.org/peach/bigbuckbunny_movies/BigBuckBunny_320x180.mp4"

                        }

                    },

                    Buttons = new List<CardAction>

                    {

                        new CardAction()

                        {

                            Title = "Learn More",

                            Type = ActionTypes.OpenUrl,

                            Value = "https://peach.blender.org/"

                        }

                    }

                }.ToAttachment()

and I built a simple bot and put this in a method and it works just fine:
private async Task HandleMessageAsync(IDialogContext context, IAwaitable<object> result)
{
    var videoMsg = context.MakeMessage();
    videoMsg.Attachments.Add(new VideoCard("My Video", "a subtitle", "some text", media: new[] { new MediaUrl(@"http://download.blender.org/peach/bigbuckbunny_movies/BigBuckBunny_320x180.mp4") }).ToAttachment());

    await context.PostAsync(videoMsg);
}

hope that helps

This is a little buggy :dagger: . Facebook allows only one video per message ?

Incorrect number of files uploaded. Must upload exactly one file

@lonche That sounds like a bug in Facebook :-) Different channels have different capabilities.
The way to show YouTube videos is simply to provide a YouTube URL

Yes. But Facebook does not render YouTube URL as a video when bot sends a message. Facebook renders YouTube URL without "preview".
How do you post YouTube videos ?

hi @lonche - I think you may have confused Bot Framework webchat's implementation of youtube video previews with those of Facebook's. This issue and the pull request around it (https://github.com/Microsoft/BotFramework-WebChat/pull/303) very specifically only render youtube and vimeo video previews for video cards on the webchat client (this repository), and not facebook. How facebook/skype/slack/etc render their cards is up to them, and not us.

I have got the same problem. I'd like to render Youtube / Vimeo video clips, but that doesn't work with video cards, neither with more classical attachment as @billba solution (I'm not using Typescript, so don't the as builder.IAttachment).
So my 'ugly' solution is to use carousel of HeroCards with buttons openUrl to videos

I tried this , on webchat works fine , i used my vidéo "http://iitbot.000webhostapp.com/IIT.mp4" and it works fine , but when tried it on messenger , it gives me :Sorry, my bot code is having an issue.
back to the bot i found this , "{"error":{"message":"(#100) Invalid data","type":"OAuthException","code":100,"error_subcode":2018032,"fbtrace_id":"E1LyycaFN8g"}} " and There was an error sending this message to your bot: HTTP status code InternalServerError , any help ?

Hello @achrafbenalaya since your issue functions correctly with WebChat and is nonfunctional on messenger, can you please file your issue with the BotBuilder repo? https://github.com/Microsoft/BotBuilder

@danmarshall  i found out the problem , that facebook do not allow 000webhostapp.com files or sites. thank you =)

how can i embed youtube videos in bot frameowrk sdk with c# net , I need reproduce a youtube video inside a bot


Style Album Page

There's already a simple page that links stuff correctly, so let's take that and build ourselves a page based off of the existing code. It's got all the links and such. If you need help getting the page set up contact me (i.e. /simple-pages might not have the file in it).

I migrated the simple page to a new php simple-page called Album. The original page is still "the gail photos" or something like that in the admin view. I kept most everything the same, except for CSS.
The margins on the squares are really irritating, since the first column is offset by one adding a margin will mess with the spacing of the things on the page. Remedied by adding left margin to other columns. Could also fix by creating another album and making it an even 6 instead of a harder 5.


Update rbac.yaml

Sorry, I started to work on this before I had seen your PR.
Does it work for you with the update code in main?

Let me check...

Now it works without making changes to rbac.yaml :-)


Add a Gitter chat badge to README.md

vinniefalco/Beast now has a Chat Room on Gitter
@vinniefalco has just created a chat room. You can visit it here: https://gitter.im/vinniefalco/Beast.
This pull-request adds this badge to your README.md:

If my aim is a little off, please let me know.
Happy chatting.
PS: Click here if you would prefer not to receive automatic pull-requests from Gitter in future.

Part of #23


 Or am I doing something wrong here? Thanks for your patience!
Screenshots

hi i'm not very sure what this error means but I did encounter this error too. I think it might be the Num(Optional). Num should always take in an Integer type so the Optional will also be Optional. So instead of declaring a generic type T maybe just declare Optional in the Num constructor?

If I remembered correctly I added another private constructor and it removed some of the warnings. Not sure why this error occurs though. Would appreciate it if someone can shed some light on this.

Thanks for the responses guys! I haven started on the exercises but it turns out there's a trick to @SuppressWarnings("unchecked"), but I also don know what's the theory behind this hahaha

Just listing out some guesses:

did you extend Num from AbstractNum? the problem might be caused by extending from AbstractNum
does your Num class a generic class (i.e. Num ?) that might be redundant.

Thanks for the responses guys! I haven started on the exercises but in the fifth exercise it turns out there's a trick to @SuppressWarnings("unchecked"), but I also don know what's the theory behind this hahaha

I think Prof has disallowed usage of this method -- you're supposed to use another method that you've defined earlier to allow the return types to be Maybe<R>.

hi i'm not very sure what this error means but I did encounter this error too. I think it might be the Num(Optional). Num should always take in an Integer type so the Optional will also be Optional<Integer>. So instead of declaring a generic type T maybe just declare Optional<Integer> in the Num constructor? One more thing to add, is your Num class extends from AbstractNum? I think you need to specify the generic type. So it should be Num extends AbstractNum<Integer>

Just listing out some guesses:

did you extend Num from AbstractNum<Integer>? the problem might be caused by extending from AbstractNum<T>
does your Num class a generic class (i.e. Num<T> ?) that might be redundant.

Thanks so much guys! CodeCrunch has finally accepted my files; while my outputs are wrong there's at least no warning when I changed to Num extend AbstractNum. I was previously using Num extend AbstractNum. But actually I still don't get whats going on here hahahaa my knowledge of generics is not pinned down like honestly I don even know why I shouldn't do Num extends AbstractNum, do yall happen to know which part of the slides talks about this or if you have any good resources I would be grateful as well 🙏

I don even know why I shouldn't do Num extends AbstractNum

I think this is similar to our Project where we do EventComparator implements Comparator<Event>. We don't do EventComparator<T> implements Comparator<T> because we are confident that we are only dealing with Events here, so there's no need for generics. Similarly for Num, we know that we are only dealing with Integers, so we don't bother allowing Num to do generic typing.

I don even know why I shouldn't do Num extends AbstractNum

@GarlicButterSteak I think this is similar to our Project where we do EventComparator implements Comparator<Event>. We don't do EventComparator<T> implements Comparator<T> because we are confident that we are only dealing with Events here, so there's no need for generics. Similarly for Num, we know that we are only dealing with Integers, so we don't bother allowing Num to do generic typing.

Ahhh makes a lot of sense thanks!!


Consider adding an admission control webhook sample deployment with '-include-unqualified'

Specifically kube api server expects admission control webhooks to a have SAN entry for <service-name>.kube-system.svc
...
initContainers:
...
    args:
      - -namespace=$(NAMESPACE)
      - -pod-name=$(POD_NAME)
      - -query-k8s
      - -include-unqualified
...

Results in an issued cert with the necessary SAN entry for the "un-qualified" <service-name>.kube-system.svc:
# kubectl -n kube-system logs deployment/<name>-webhook -c certificate-init-container
# openssl x509 -in certificate.crt -text -noout

Certificate Information:
Common Name: 100-96-2-2.kube-system.pod.cluster.local
Subject Alternative Names:
  100-96-2-2.kube-system.pod.cluster.local
  <service-name>.kube-system.svc.cluster.local
  <service-name>.kube-system.svc
  IP Address:<IP_ADDRESS>
  IP Address:<IP_ADDRESS>
Valid From: August 14, 2020
Valid To: August 14, 2021
Serial Number: 8f618d0c4564d8233bc158d097534b03

Without -include-unqualified kube-apiserver will reject the created certificate:
Failed calling webhook,
  failing open <name>:
     failed calling webhook "<name>":
     Post https://<service-name>.kube-system.svc:443/mutate?timeout=10s: x509: certificate is valid for
       <service-name>.kube-system.svc.cluster.local, (fully qualified service name)
not <service-name>.kube-system.svc

Yeah, that's really a bug in kube-apiserver. I don't believe svc is a reserved top-level domain, so theoretically someone could register it and create interesting mischief. I should get around to filing the bug sometime.
I don't like recommending people run things in less secure configurations, but as we found out when we deployed our first admission control webhook, Kubernetes kinda forces them to.

Good points.
I looked into the clientConfig field of the webhook spec.
It looks like you can specify either a service or a url:

kubernetes-api/v1.18 admissionregistration-k8s-io/v1beta1 - webhookclientconfig

I'll try with that today.  I'm not so happy about -include-unqualifed and .svc domains now.
Kudos for making this tool flexible enough to work with unqualified *.svc URLs regardless.

TL;DR - you correct, you have to have a TLS cert with a SAN entry for unqualified svc DNS when the webhook runs in cluster.
clientConfig:
  service:
    name: <name>
    namespace: kube-system
    path: "/mutate"

# vs

clientConfig:
  url: https://<name>.kube-system.svc.cluster.local/mutate

According to the API documentation url is for external webhooks.
`url` gives the location of the webhook, in standard URL form (`scheme://host:port/path`).
...
The `host` should not refer to a service running in the cluster; use the `service` field instead.

The host might be resolved via external DNS in some apiservers (e.g., `kube-apiserver` cannot resolve in-cluster DNS as that would be a layering violation).
`host` may also be an IP address.
...
The scheme must be "https"; the URL must begin with "https://".
A path is optional, and if present may be any string permissible in a URL.
You may use the path to pass an arbitrary string to the webhook, for example, a cluster identifier.
...

This matches the behavior kube-apiserver tries to lookup the name using non cluster aware DNS:
failed calling webhook <webhook-fqdn>":
 Post https://<name>.kube-system.svc.cluster.local/mutate?timeout=30s:
  dial tcp: lookup
    <name>.kube-system.svc.cluster.local
    on <IP_ADDRESS>:53:
      no such host


#184752077 Configure ESLint

##What does this PR do?
This PR sets up es-lint to check syntax error and enforce formatting style.
Description of Task to be completed?
ESLint is the required linter for the project. It'll help check for style violations and flag them.
##How should this be manually tested?

Clone the repo
Cd into that repo
run npm install
After that run npm run dev

Any background context you want to provide?

I have configured ESLint to use Javascript module because it is the style convention we will be using throughout the development process.

What are the relevant pivotal tracker/Trello stories?

#184752077

@Reennee Here are my feedback to be addressed:

Please use ## for the headings, this will make it look more like a heading instead of looking like a normal text eg.

What does this PR do?

On the description of task to be completed, refer to the Pivot Tracker description for your task
On the section of How should this be manually tested? Please specify clear also how we can test that eslint was configured
Please do not exceed 1 (one) commit message. You need to squash your commits to only 1 commit
Remember to assign this PR to atleast 5 people. I can only see you assigned it to one person

Changed the number of reviewers and changed the titles


testVerifyXcodeArgs

Checks that helpful exception is given if j2objcConfig not configured for Xcode

@advayDev1, @confile - this is an easy PR

LGTM

@advayDev1 - PTAL

lgtm

Error message changed from 'TARGET-NAME' to 'IOS-APP-TARGET' so that it's more clear. Now merged.

Left behind some commits that I meant to FIXUP. Ugly but probably best to leave them as I prefer not to much with the history.


Case Field 'Brief Description' is 280 characters not 140

Allow 280 characters to be entered into the 'Brief Description' case field

@dethe Can I close this?

I will close it when it is pushed to production. Right now the tests are failing, not because of anything we've done, but because our dependencies are out of date and the Continuous Integration tool we use for testing is choking on that. One step forward, two steps back.


Focus to focus-visible for all elements

Related to #160. All interactive elements will need to change from a focus state to a focus visible state. This way we don’t get unwanted focus states when using a mouse; only when a keyboard is used.

Navigation (following styling of truck lineup)
Inpage navigation (following styling of truck lineup)
Buttons in general
Play/pause button
Scroll to top button

Kamino cloned this issue to hlxsites/vg-volvotrucks-us


Validate the element template type <-> binding combination

Is your feature request related to a problem? Please describe.
Element template types (Boolean, String, Hidden, ...) can not be used for all bindings. Some combinations of types and bindings lead to errors (see https://github.com/camunda/camunda-modeler/issues/1933).
It would be helpful for the users to validate the type <-> binding combination and throw a more meaningful error.
Describe the solution you'd like
If a user configured a non-valid type <-> binding combination, a meaningful error shall be thrown (e.g., Boolean is not valid for camunda:InputParameter please use one of the following: <String, ...>)
Describe alternatives you've considered
Mid-term it would be even better to do a json schema validation.
Additional context
Related to #1933
Related to https://github.com/bpmn-io/element-templates-json-schema/issues/2
Related to https://github.com/bpmn-io/element-templates-json-schema/issues/9
Docs

Better implementation of this feature would be to do an entire json schema validation.

This will be fixed by https://github.com/bpmn-io/bpmn-js-properties-panel/issues/386, when we integrate the new JSON Schema

Also related to #2159

Fixed upstream via https://github.com/bpmn-io/bpmn-js-properties-panel/pull/455


[WIP] Update repo to work with Terraform 0.13.x

Update CircleCI to use Terraform 0.13.x.
Upgraded the Google Providers to 3.43.0.
Update the version constraint on all examples to require at least 0.12.26.
Update pre-commit hooks to add gofmt.

Upgrade the tests to support Terratest v0.30.23

In general, TF 0.13.x seems backwards compatible from a testing perspective: I did not need to change anything in modules in this PR.

Okay builds passed in https://app.circleci.com/pipelines/github/gruntwork-io/terraform-google-load-balancer/62/workflows/1c7b6469-7ddc-45c7-956c-4f132bd92606/jobs/93, so I'll mark this as ready for review.

ok @rhoboat thanks for the review. I've made the changes and will need a re-review when you have a moment!


bump-minor-pre-major not behaving as expected prior to first release

If a library has not been released yet, but has a package.json at a pre-major version, bump-minor-pre-major suggests 1.0.0 as the first release still.
Refs: https://github.com/pkgjs/parseargs/pull/36

This is intended behavior - the initial release version is specified by the release strategy (or Release-As commit in #1222). For an initial release, there's no notion of version bumping as there was no previous release.


Add Thunderbird.app nl v31.7.0

Added the thunderbird-nl package v31.7.0

@gmkey In the future, commits should be squashed.
It’s an obtuse process that stumps most beginners, though, so I’ll leave you with the link to read at your leisure, and merge this as is.
Thank you.


double-beep: Watch lonvega.tumblr.com

double-beep requests the watch of the watch_keyword lonvega\.tumblr\.com. See the MS search here and the Stack Exchange search here.

lonvega\.tumblr\.com has been seen in 1 true positive, 0 false positives, and 0 NAAs.

Approved by Makyen in Charcoal HQ


Spelling error

Title
Fixed spelling error
Summary
Fixed spelling error

This seems like a small (but important) contribution, so no Contribution License Agreement is required at this point. We will now review your pull request.
Thanks,
.NET Foundation Pull Request Bot

This seems like a small (but important) contribution, so no Contribution License Agreement is required at this point. We will now review your pull request.
Thanks,
.NET Foundation Pull Request Bot

Build was stuck so closed and reopened to kick off a new build.


Cannot get Pie/Polar chart to work on page with other charts

Hi
This is really annoying because when I copy and paste the HTML/JS out from my reporting page into JSBIN OR a plain HTML page it works however on my main reporting page which has about 5 bar/line graphs above the pie chart I am having problems with it and JS errors.
I would have thought it was down to another JS error above the one in question but the only errors raised are due to the Pie chart e.g "Uncaught ReferenceError: datasetLabel is not defined" which happens when I try a Pie or a Doughnut chart by moving my mouse over the segments. All other charts have been okay so far.
What happens is that when I load the page the other charts above it load correctly, with labels shown when hovering above each data point. However with the Pie Chart, it loads but when I put my cursor over any of the slices I instantly get JavaScript errors (Chrome/FF), each time I move the mouse over a different point.
The errors in the minified chart code when I directly call https://cdnjs.cloudflare.com/ajax/libs/Chart.js/1.0.2/Chart.min.js just show this.
(function(obj
/**/) {
var p=[],print=function(){p.push.apply(p,arguments);};with(obj){p.push('',datasetLabel,': ',value,'');}return p.join('');
})
However if I load in each Chart file separately I get the error in FF as
Error: ReferenceError: datasetLabel is not defined
Source File: http://mysite.com/Chart.Core.js line 463 > Function
Line: 1
Then in Chrome when I run it I get more detailed errors
Uncaught ReferenceError: datasetLabel is not defined(anonymous function) @ VM8513:3tmpl @ Chart.Core.js:482helpers.template @ Chart.Core.js:484(anonymous function) @ Chart.Core.js:1020helpers.each @ Chart.Core.js:181extend.showTooltip @ Chart.Core.js:1006(anonymous function) @ Chart.Doughnut.js:70chartInstance.events.(anonymous function) @ Chart.Core.js:735
I am at a loss to figuring out what could be causing this as no other JS errors appear on the page and all other graphs / charts are showing.
If I directly copy out the javascript code I am using and put it in a JSBIN it works as you can see here
http://output.jsbin.com/ganiduviqa/
However it fails to show any data labels on my own reporting site.
Maybe some object getting overwritten somewhere?
I tried reformatting the data to have a DataSet inside it but then the graph didn't show at all. I have tried using upper case Label: "Green", and even moving the graph up the page above the others AND having just that graph (same code as the JSBIN) on the page but I still get these errors trying to show the labels.
Any help getting to the bottom of this would be much appreciated.
Thanks
Rob

@monkeymagix that's an interesting one. It looks like it's trying to show the tooltip for multiple items and failing since there is no datasetLabel
Are you reusing the same canvas element for multiple charts? If so, you need to call destroy on the old chart before creating the new one. My thought here is that the old chart is still looking for data that no longer exists when you hover over the canvas.

Hi
No I create a new canvas DIV for each of my charts and there is no other chart with the same canvas ID/Name on the page.
Is there some sort of method that can be called to dispose / destroy any chart code in memory?
Then I could try calling that in between each chart. Then every new chart would be fresh in memory and not have any other chart code it could conflict with?
Also it only seems to be Pie/Doughnut charts that I get this error for. Is there something different in the code that handles those 2 types of chart maybe?
Thanks
Rob

At the moment I am having to use Google Charts for Pie Charts which works ok. I'd rather not have to if possible due to the stored proc data being in a different format for their graph source data. I have tried putting
var conversionRateChart = new Chart(chart6).Line(conversionRateData);
conversionRateChart = null;
Before the Pie Chart - as this is the last working chart before the Pie Chart - also if I change the type of graph to a bar chart it works okay so it must be something to do with Pie Charts as I've tried using them on 2 different reporting pages now and both of them don't render the labels when hovering over the slices.
Thanks
Rob

Hello, today I am closing all issues that are only affecting version 1 of Chart.js as WONTFIX.
If this issue does affect version 2 as well, I apologize for the error. Please create a test case against Chart.js 2 using on of the below websites and we will be happy to reopen the issue and update its classification:

http://jsbin.com/
http://jsfiddle.net/
http://codepen.io/pen/
Premade template: http://codepen.io/pen?template=JXVYzq


Suggestion for Including Code

Thanks for this great package!!
I had a suggestion after working for several months with Franklin (actually PkgPage). Everything runs quite smoothly for me, except when it comes to including code. So far, there are two options for doing this: i) introducing code directly into the text, or ii) creating a code file that is eventually called in the text.
I thought that a third option would be valuable: writing a file with ALL scripts to include, with tags to separate them.
MWE
This is how you'd write the code

This is how you'd include the code on text

This option is especially useful if you've worked on a project and want to create a website explaining the code snippets (or if you wrote code without the intention of creating a website, creating an ideal alternative to Jupyter) More generally, I think it'd also make writing the code more smoothly.
Thanks again for all your work!

I know that it could handle Literate but, since I never used it, I ignored it. It seems that it's what I was describing!!! I'll take a lookn into it. It seems it's not automatic, but it can address this.
I'm aware of Xranklin. The comment was to provide some feedback, just in case it was useful for Xranklin ( the # was just an example, to give a same feeling as the references to headers). In fact, I use PkgPage, and it'd be great if Xranklin could have some package similar to PkgPage!
Thanks for your work!


"methods" option in the API

Hello, I have seen that some components have the "methods" option in the API, but it is not clear what that would be and how to use it. I tried to find some examples but to no avail. What's different about it with "events" and an example of usage.

@mikejavier When you use a component the best practice is to use only props and events but sometimes you could need to force a behaviour of a component calling its method.
For example:
<b-autocomplete ...
       ref="autocomplete">
</b-autocomplete>

export default {
        ...
        mounted() {
             this.$refs.autocomplete.setSelected(...)
        }
}


Ensure Q is defined in moveDmp.mk to prevent unquoted test on Solaris

It may be the case that this should have already included the definition via settings.mk or https://github.com/AdoptOpenJDK/TKG/blob/cca8f28c9c557037d8a04f7d097250fc53226d0d/makeGen.mk#L28 but either way setting it in the file works. If there is a preferred solution to obtain it via the inclusion of one of the other files I'm happy to do that instead.
(As an aside this would also work if you ran with make SHELL=bash compile but for portability that's not the best option here unless things get problematic further down the line)
Signed-off-by: Stewart X Addison<EMAIL_ADDRESS>

For historic reference this was raisd as a result of Grinder 7578 failing with this error:
14:28:20  if [ -z $(tail -1 /export/home/jenkins/workspace/Grinder/openjdk-tests/TKG/../TKG/output_compilation/compilation.log | grep 0) ]; then perl scripts/moveDmp.pl --compileLogPath=/export/home/jenkins/workspace/Grinder/openjdk-tests/TKG/../TKG/output_compilation/compilation.log --testRoot=/export/home/jenkins/workspace/Grinder/openjdk-tests/TKG/..; false; else rm -f -r /export/home/jenkins/workspace/Grinder/openjdk-tests/TKG/../TKG/output_compilation; fi
14:28:20  /bin/sh: syntax error at line 4: `(' unexpected
14:28:20  gmake: *** [makefile:75: compileTools] Error 2

moveDmp.mk doesn't include settings.mk at this moment. Since only Q is needed, I think it's not preferred to include setting.mk. So we can have Q added in moveDmp.mk like in this change. I think a better way is to create another small mk file which contains Q, D, etc. and we can include it wherever we need. But this can be a future improvement.


Promote print of Constitution page as the PDF version

The constitution PDF is severely outdated. Since we already use AsciiDoc, we can either have a PDF version generated from it or just promote browser print of constitution page as the PDF version, which is something even many governments do these days so it should be OK for us. Let's discuss at the call.

(In other words, I think we should not have two sources of truth for this document. Just make it AsciiDoc driven)

Let's remove the PDF from the constitution page.

I'll take care of it by next meeting. Thank you


how to make avs device sdk without google test support ?

Hi Sir,
Is it possible to make avs device sdk without google test support?
it seems google test is enabled in default. How to disable ?
Thanks!

Hi @DiazSo, we will add a way to do this in our future release.  In the meantime, please try "make SampleApp".  This should only build the SDK without the tests.  Thanks!

Hi @DiazSo, we have added in v1.2 of the SDK a new cmake option "-DACSDK_EXCLUDE_TEST_FROM_ALL=ON" so that tests will not be built with make all.   Thanks!


Fix: copy field metadata for pydantic

Adds to PR strawberry-graphql/strawberry#2190
See https://github.com/strawberry-graphql/strawberry/pull/2190#issuecomment-1358333300

The addition of the metadata attribute for fields isn't handled for Pydantic support. This ensures that the metadata attribute on fields isn't lost when a @strawberry.experimental.pydantic.type is created.

Description

In the module strawberry/experimental/pydantic/object_type.py, function _build_dataclass_creation_fields, a StrawberryField is constructed.  This code change just makes sure that the metadata attribute isn't forgotten.
Types of Changes

[ ] Core
[x] Bugfix
[ ] New feature
[ ] Enhancement/optimization
[ ] Documentation

Issues Fixed or Closed by This PR

None

Checklist

[x] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[x] I have read the CONTRIBUTING document.
[x] I have added tests to cover my changes.
[x] I have tested the changes and verified that they work and don't break anything (as well as I can manage).

Hi, thanks for contributing to Strawberry 🍓!
We noticed that this PR is missing a RELEASE.md file. We use that to automatically do releases here on GitHub and, most importantly, to PyPI!
So as soon as this PR is merged, a release will be made 🚀.
Here's an example of RELEASE.md:
Release type: patch

Description of the changes, ideally with some examples, if adding a new feature.

Release type can be one of patch, minor or major. We use semver, so make sure to pick the appropriate type. If in doubt feel free to ask :)
Here's the tweet text:
🆕 Release (next) is out! Thanks to Huy Z for the PR 👏

Get it here 👉 https://github.com/strawberry-graphql/strawberry/releases/tag/(next)

Can you add a release file? :)

Oh sorry. Added.  I hope a force-push was ok.

Thanks for contributing to Strawberry! 🎉 You've been invited to join
the Strawberry GraphQL organisation 😊
You can also request a free sticker by filling this form: https://forms.gle/dmnfQUPoY5gZbVT67
And don't forget to join our discord server: https://strawberry.rocks/discord 🔥


objects in tempdb have incorrect highlighting

SQL Operations Studio Version:

Steps to Reproduce:
Enter: CREATE TABLE #foo (bar int);
Everything from the number sign (hash for the UK) is green, but should be the same colors as;
CREATE TABLE foo (bar int);

Duplicate of https://github.com/Microsoft/sqlopsstudio/issues/98


Missing which and too fast failures

We don't have which in all containers. Also, in some cases when, when tests fail before the first container is created, the cleanup can fail by trying to remote empty string.

[test]


bill tip calculator modified

🛠 Issue (1669)

Closes #1669
Description
Negative bill amount is not accepted as input and if input is negative then an alert is displayed "Please enter positive bill amount"
Type of change

[x] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)

Checklist:

[x] I have made this from my own
[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] My changes generate no new warnings
[x] The title of my pull request is a short description of the requested changes.

ATTACH SCREEN-SHOTS / DEPLOYMENT LINK

@TusharKesarwani @zugzwang03 @harshit-paneri I have done the required changes, please merge this pr


docs(event-grid): Fix typo about encoding

Hello everyone,
While reading these docs, I noticed something that I thought was not coherent. SAS Keys are not base-64 encoded strings, they are URL-encoded strings. Here is an example, taken from the docs:
aeg-sas-token: r=https%3a%2f%2fmytopic.eventgrid.azure.net%2fapi%2fevents&e=6%2f15%2f2017+6%3a20%3a15+PM&s=XXXXXXXXXXXXX%2fBPjdDLOrc6THPy3tDcGHw1zP4OajQ%3d
The Base64-encoded string is only the signature part, which is not the whole SAS token.
Cheers,
Loris

@spelluru
Can you review the proposed changes?
Important: When the changes are ready for publication, adding a #sign-off comment is the best way to signal that the PR is ready for the review team to merge.
#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

#sign-off


Timesheet - 16/04/2021 - Chrisha Canete

Task 1
Reviewing April 14, 2021-TNB-Core Team Payment Calculation
Proof of Work
-https://docs.google.com/spreadsheets/d/1wgEXGOHkHJaYRucIu1uwVSzDrsLlNdH4pH9nqKofTy0/edit?usp=sharing
Time Spent
1 hour

Total Time Spent
1 hour
Account Number
7053f27870d388b0bca4149fe72765172c3e6d1b4ffc7cd0149a296cbefe8f57

Approved

Approved


QuerySession.Logger depends on concrete implementation

I have a custom IManagedConnection implementation that I want to use for better statement tracking (see #1284). Using IMartenSessionLogger is not sufficient for proper tracing as that is just a point in time after the SQL has already executed, there is no way to get how long the command actually took.
The issue I have run in to is that QuerySession.Logger is hard-coded to expect a ManagedConnection, which breaks the contract of being passed in an IManagedConnection.
So my question is, should QuerySession and / or IManagedConnection be changed to allow the contract to be fully public and not a hidden detail, or is there something further with statement tracking that we can look at?
I may be wrong but I cannot see any other obvious way of tracking performance over Npgsql beneath Marten, so need to do in within Marten's usage.

@barclayadam First, I'm sorry it's taken so long to get to this. I made the tiny change so that you can override the IManagedConnection and still override the Logger on IQuerySession. Could I ask you to contribute your statement tracking connection to Marten and we'll work that in as an optional use thing? Sounds useful.

@jeremydmiller thanks for the update. I have actually just today been updating my code to work around this issue (by wrapping IDocumentSession, IBatchQuery and IMartenQueryable).
I'd be happy to contribute something back, but I'm not entirely sure the best route here to make it useful given the many different libraries for APM (i.e. Datadog, App Insights, Elastic APM, OpenTracing). Any thoughts?
In addition, although this will unblock me, the code will still rely on reflection to change the internals of QuerySession to actually override the ManagedConnection as it is not exposed anywhere to set/override it's creation (i.e. it's newed up in DocumentStore.buildManagedConnection).

@barclayadam,
"In addition, although this will unblock me, the code will still rely on reflection to change the internals of QuerySession to actually override the ManagedConnection as it is not exposed anywhere to set/override it's creation (i.e. it's newed up in DocumentStore.buildManagedConnection)." -- I'd vote to do something at the DocumentStore.OpenSession() methods the same way we today let you use your own NpgsqlConnection.
When Marten v4 is "done", I'm most likely going back to my Jasper tool to add Open Telemetry support. I'd be interested in hearing about what you're doing. I know there's the new Open Telemetry tracing built into .Net 5, but I haven't looked at all.

@jeremydmiller
Being able to directly wire in a different implementation of IManagedConnection would certainly help, but I wonder if Marten should bake this in (i.e. from https://jimmybogard.com/building-end-to-end-diagnostics-activitysource-and-open/ implement the Diagnostics package code directly in Marten)? Having it built-in makes it a one-line light-up for consumers (.AddSource("Marten")) and should be lightweight for those not interested.
At the moment in our library we have a small APM abstraction with implementations for Elastic APM and a couple of others but Open Telemetry looks to make much more sense now.
Another thought is what to track. I see 2 useful ways of tracing here... Either directly trace the actual SQL being executed, or, as I'm looking at doing at the moment, track the high-level operations. For example I could have the "SQL" statement be either Load<User>([id]) or `SELECT * FROM mt_doc_users WHERE id = [id]". I can see a benefit in both the options
I could look at a PR if you are interested, but wonder if it makes sense to wait for V4 as not sure on the state of that in terms of breaking changes?

@barclayadam,
I'd love to have this baked in, but my strong preference would be to do that only within V4 (master). And I'd absolutely take you up on the PR.
Hadn't talked to anyone else about this yet, but at a bare minimum now that we're going to only support .Net Core & .Net 5 is to wire up a new MartenLogger that wraps the .Net Core ILogger abstraction out of the box.


Get Batch of Block Payload With Outputs

ℹ This issue is part of Epic #204
Objective
Implement the POST request: Get Batch of Block Payload With Outputs

This issue was not implemented because after making requests with Postman, we noticed that the API rejects the connection and returns a 404 status.


Optimize use of Arrays in Bokeh JS callback

Make use of slicing of Arrays to get rid of a nested for-loop. Also use a neat JavaScript trick to emulate a simple range to create the time series. Finally store some stuff to variables to avoid needing to retrieve it repeatedly.

This doesn't have any real effect on HTML file size, but it does result in faster interactive responses. Also it should help keep the code a little cleaner. 😄


fix: increase max pods to 100

This PR increases the max number of pods per node to 100.

This PR is included in version 2.1.7 :tada:


[Command] how to debug postman phpstorm?

Version of Warden
0.12.0
Operating System and Installation Method
Ubuntu
Describe the Bug
how to debug postman phpstorm?

Follow the instructions here to set up PHPStorm for xdebug in a Warden project: https://docs.warden.dev/configuration/xdebug.html
In Postman you just need to add an XDEBUG_SESSION for your warden domain. Se the value to "PHPSTORM" and the expiration to some time in the future:
XDEBUG_SESSION=PHPSTORM; Path=/; Expires=Sun, 08 Feb 2099 19:49:16 GMT;

Make sure your PHPStorm is listening for debug connections, then execute your request in Postman.


CANNOT RENDER HTML IN FASTAPI

I am a beginner in python and I am trying to build an app in fastapi.
My task is to get text from html,
render html in fastpi
run python code on the text
and return the output to html page
This is my code
`from typing import Optional
from fastapi import FastAPI, Request, Response
from fastapi.staticfiles import StaticFiles
from fastapi.responses import HTMLResponse
from fastapi.templating import Jinja2Templates,
app = FastAPI()
app.mount("/static", StaticFiles(directory="static"), name="static")
templates = Jinja2Templates(directory="templates")
@app.get("/", response_class=HTMLResponse)
async def get():
return templates.TemplateResponse("layout.html")
@app.post("/")
async def post(request: Request):
text = request.get("sent")
`

WE'D LOVE TO HELP YOU! :peace_symbol:
But we need your help first... :runner:
Can you:

Format your code snippet:

Image:

Generated code:

from fastapi import FastAPI

app = FastAPI()

Be specific on how we can help you.

What is the problem?
What is failing?
What do you want to achieve?

Last but the most important: please, follow our question issue template. It makes us know where you have searched possible solutions, understand your issue better and several benefits for those who have the same problem as you and for those who are trying to help as well. :sunglasses:

You have to pass the request as part of the key-value pairs in the context for Jinja2.
The fix is quite easy you just need to add Request in query parameters,
from fastapi import Request
...
@app.get("/", response_class=HTMLResponse)
async def get(request: Request):
    return templates.TemplateResponse("layout.html", {"request": request})

Then pass all the data inside the dictionary that you want to render.

@Kludex
Code:
import json

from fastapi import FastAPI, Request
from fastapi.staticfiles import StaticFiles
from fastapi.responses import HTMLResponse
from fastapi.templating import Jinja2Templates
from urduhack.models.ner.predict import predict_ner

app = FastAPI()

app.mount("/static", StaticFiles(directory="static"), name="static")

templates = Jinja2Templates(directory="templates")

@app.get("/", response_class=HTMLResponse)
async def get(request: Request):
    return templates.TemplateResponse("layout.html", {"request": request})

@app.post("/", response_model=HTMLResponse)
async def post(request: Request):
    text = request.get("sentence")
    entities = predict_ner(text)
    if entities:
        return json.dumps(dict(entities))

This is what I can put forward here,
Like in Flask there is a function, render_template , it renders whole html page and we can select the things we want.
I want to do the same thing, get method renders html page but I can't use it in the post method, it returns null. Can you guide me on that, as no documentation is available from fastapi.

@Kludex if you still don't understand, below is the link to kind of thing I want to build using fastapi
anago-tagger

You have to pass the request as part of the key-value pairs in the context for Jinja2.
The fix is quite easy you just need to add Request in query parameters,
from fastapi import Request
...
@app.get("/", response_class=HTMLResponse)
async def get(request: Request):
    return templates.TemplateResponse("layout.html", {"request": request})

Then pass all the data inside the dictionary that you want to render.

I think you understood my point,
Can you please elaborate a bit on that point,
Let's say I want to select a div text whose id is "sentence",
def post():
how can I get the text here, run a machine learning model and then return it

You should be good to go with the same way i mentioned above
return templates.TemplateResponse("layout.html", {"request": request, "data": data})
Now you successfully rendered, you just need to use that form front-end

             {% for value in data %}

{{ value.title }}

             {% endfor %}

Let's say I want to select a div text whose id is "sentence"
I didn't understand that so you want to scrape a page and render it ?

You should be good to go with the same way i mentioned above
return templates.TemplateResponse("layout.html", {"request": request, "data": data})
Now you successfully rendered, you just need to use that form front-end

             {% for value in data %}

{{ value.title }}

             {% endfor %}

Let's say I want to select a div text whose id is "sentence"

I didn't understand that so you want to scrape a page and render it ?

@ycd thanks for your response,
here is y layout.html page,
<!DOCTYPE html>

    <meta charset="UTF-8">
    <title>AnaGo-demo</title>
    <meta http-equiv="x-ua-compatible" content="ie=edge">
    <meta name="MobileOptimized" content="320">
    <meta name="description" content="">
    <meta name="viewport" content="width=device-width, initial-scale=1">
    <link rel="stylesheet" type="text/css" href="https://cdnjs.cloudflare.com/ajax/libs/bulma/0.4.2/css/bulma.min.css">
    <link rel="stylesheet"<EMAIL_ADDRESS>

and I want to select text from
<textarea id="sentence" name="sentence" class="textarea" placeholder="Enter English Text Here"></textarea>

How can I do that with Fastapi. Can you please guide me on that ?

You should be good to go with the same way i mentioned above
return templates.TemplateResponse("layout.html", {"request": request, "data": data})
Now you successfully rendered, you just need to use that form front-end

             {% for value in data %}

{{ value.title }}

             {% endfor %}

Let's say I want to select a div text whose id is "sentence"

I didn't understand that so you want to scrape a page and render it ?

@ycd I am not familiar with difference in scraping and rendering in terms of web

I'm not a frontend guy but In this case you need to send a request from Front-end to Back-end, with Axios or Ajax etc. I only know vue and axios so i created a example for you with axios and vue.
home.html

<title></title>

        <textarea name="" id="content" cols="30" rows="10" v-model="content"></textarea>
        <button @click="addText" id="add-textarea">click me</button>

main.py
from fastapi import FastAPI, Request
from fastapi.templating import Jinja2Templates
from pydantic import BaseModel

templates = Jinja2Templates(directory="templates")

app = FastAPI()

class TextArea(BaseModel):
    content: str

@app.post("/add")
async def post_textarea(data: TextArea):
    print(data.dict())
    return {**data.dict()}

@app.get("/")
async def serve_home(request: Request):
    return templates.TemplateResponse("home.html", {"request": request})

When i go to my root path:

I'm seeing this textarea and click button, now let's send a request.
 {'content': 'Hello textarea!'}
INFO:     <IP_ADDRESS>:51682 - "POST /add HTTP/1.1" 200 OK

Is the problem resolved @siamhassan66 ?

not yet
On Sat, Aug 15, 2020 at 2:03 AM Yağızcan Değirmenci <
<EMAIL_ADDRESS>wrote:

Is the problem resolved @siamhassan66 https://github.com/siamhassan66 ?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/tiangolo/fastapi/issues/1878#issuecomment-674271154,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AO7GJH5ED7KISILES5EU73TSAWRBVANCNFSM4P3IRT4Q
.

I went through the same problem with the post request. I tend to agree that the Fastapi documentation doesn't explain how to link the post request with an html web page. It shows what you need in Fastapi only without the other part. I figured out how to do it by myself. I asked that question too but received no answer for it. There is a need of an example to do this in the documentation. I can contribute on this aspect. I generated web pages with fastapi and it works similar to Flask. Had to relearn to program it in Fastapi code.

Is the problem resolved @siamhassan66 ? If it is, do you mind closing the issue?

I noticed this issue still open. I logged a similar one https://github.com/tiangolo/fastapi/issues/2525
@eliteuser26 please review and let me know. SO link here--https://stackoverflow.com/questions/65335763/fastapi-render-template-in-index-html-not-working

For fastapi & jinja2 templates, you should use absolute path,
for example:
main.py
'''
from pathfile import Path
BASE_PATH = Path(file).parent.resolve()
lets say your template directory is under the root directory
templates = Jinja2Templates(directory=f'{BASE_PATH}/templates')
@app.get('/', response_class=HTMLResponse)
async def login(request: Request):
return templates.TemplateResponse('index.html', {'request': request})
'''

Problem: intercept the template generation process
I believe have the exact same problem as @siamhassan66. I too come from Flask. Here's what I think he meant: he wants to render the template into HTML in the backend, and get a result that is a string with the HTML inside. The documentation is strongly opinionated in this regard. It assumes that all one could ever wish is to:

cook some values;
pass these to the templates.TemplateResponse call;
return immediately the outcome of templates.TemplateResponse.

Allow me to highlight a different scenario: I do not want to return that generated HTML, and for a good reason! My frontend is a Vue app. I am not serving pages there. All I do is communicate with the frontend via API calls and data.
What I really want here is to render a few templates, concatenate the results and conver them to PDF. Then — and only then! — do I want to return. Literally, you click on a button on the browser and seconds later here comes a PDF with a medical report.
Flask and render_template
@siamhassan66 is absolutely right: in Flask, you do:
from flask import render_template

html_fragment = render_template(
    'template.jinja2',
    param=value,
    another_parameter=another_value,
    i_think_you_are=starting_to_get_the_gist,
)

and that variable html_fragment is now a string with HTML inside. The way  have it, I collect a variable number of HTML fragments and then I pass them to a final overall template.
In no step do In wish to return this. I pass the final full HTML document to a function based on pdfkit/wkhtmltopdf.
Faslapi and templates.TemplateResponse
The only pattern present here, in all fora and in the documentation is this:
@app.get("/items/{id}", response_class=HTMLResponse)
async def read_item(request: Request, id: str):
    return templates.TemplateResponse("item.html", {"request": request, "id": id})

Everything is monolythically hardwired to the one-track process of returning the HTML.
Is it even possible to intercept this, as opposed to returning the HTML instantly? Is there any method / property in templates.TemplateResponse that yields / holds the HTML?
If I find a solution, I'll post it here.

it's been solved

Dear @siamhassan66,
I realise you got somewhere, but I can't find your solution here. I came here to find help and I'm sure more people do the same. So, as promised, here is the solution I came up with, hoping the next person will find it useful.
My approach is to break away from templates.TemplateResponse, because I came to realise that this is designed to do just that: pack and send back a response. Instead, I use a two-step approach where I acquire a template — via templates.get_template — and then I render it with some values — via template.render.
This approach allows me to get the generated HTML, while doing away with the need to provide a request. This way, the whole processing can be done at middleware level.
Here's the gist:
from fastapi.templating import Jinja2Templates

templates = Jinja2Templates(directory=r"manager_backend\templates")
template = templates.get_template("item.jinja2")

@app.get("/items/{id}")
async def read_item(id: str):
    text = template.render(id=id)
    response = whatever(text) # do some processing with the text
    return response

Please notice that, compared with the previous snippet:

I changed the template from item.html to item.jinja2;
the arguments to template.render don't include the request, so I removed it from the path operation signature;
the arguments to template.render are no longer a dict, but rather kwargs;
I removed the response_class=HTMLResponse from the signature;
in my particular case, the function is returning a pdf file, but this is not a saved file, so I could not use FileResponse; instead, I did something like this:

@router.get("/{id}")
def generate_report_id(id):
    pdf, file_name = generate_report(id)
    return Response(content = pdf, headers = {
        'Content-Type': 'application/pdf',
        'Content-Disposition': f'attachment; filename={file_name}',
        'x-suggested-filename': file_name,
    })

This allows me to click a button on the frontend and get a pdf downloaded.
I hope this helps. I wish I had something like this in the examples.


refactor: createSignedTx not taking unsigned

BREAKING CHANGE:

createSignedTx has a changed signature: createSignedTx(address: string, signingPayload: string, signature: string, metadataRpc: string): string. In particular, the metadata is a needed argument.

Disregard


Load external Python libs

If I wanted to import for example requests or numpy (regardless of the reason), what would be the best way to add it?
So far I was trying to check the site-packages approach but I'm not sure exactly where the jython plugin would check.

I decided to go with this approach.
import sys
from os.path import abspath, sep
sys.path.append(abspath('.') + sep + 'site-packages')

import requests
requests.get('https://example.org').text

In the project folder create a site-packages folder,, extract the library wheel compatible with py 2.7, append that path to the system at runtime and you have the library.


[ZEPPELIN-3014] NPE bug fix and Error message enhancement with Kylin Interpreter

What is this PR for?
A few sentences describing the overall goals of the pull request's commits.
First time? Check out the contributing guide - https://zeppelin.apache.org/contribution/contributions.html
What type of PR is it?
Bug Fix
Todos

[ ] - Task

What is the Jira issue?

https://issues.apache.org/jira/browse/ZEPPELIN-3014

How should this be tested?

Setup Travis CI as described on https://zeppelin.apache.org/contribution/contributions.html#continuous-integration
Use existing unit tests in kylin module.

Screenshots (if appropriate)
before: NPE when result set is empty

after: no NPE when result set is empty, just an empty table

before: when query fails, only error code is returned, no error message

after: when query fails, both error code and error message are displayed to users

Questions:

Does the licenses files need update? No.
Is there breaking changes for older versions? No.
Does this needs documentation? No.

This PR has two commits, https://github.com/apache/zeppelin/pull/2634/commits/ec68d12437611dd6fb817fa058020bb926b7e163 is to enhance the error message parse and display, the second commit is https://github.com/apache/zeppelin/pull/2634/commits/d20872c5014e66ffcaf9d3bb51193ca3023bce92 for NPE bug fix when returned dataset is empty.

@jinxliu
read  https://zeppelin.apache.org/contribution/contributions.html (Creating a Pull Request)

can you update the PR description

@felixcheung is there something wrong with travis-ci?

seems like travis problem. please try to kick it off again by close-reopen this PR

I have tried several times since yesterday, hope this time it works.

@felixcheung it still does not work.

@jinxliu Could you rebase and try again ?

@zjffdu sure I will close this PR and have created another PR https://github.com/apache/zeppelin/pull/2645. Please review.

@jinxliu Actually you don't need to create another PR, for the next time you just need to rebase and force push


Webhook optimization

Codecov Report

Merging #77 (bdc41a7) into main (157755f) will decrease coverage by 43.11%.
The diff coverage is 0.00%.

@@              Coverage Diff              @@
##               main      #77       +/-   ##
=============================================
- Coverage     95.48%   52.36%   -43.12%
- Complexity        0      466      +466
=============================================
  Files            33      110       +77
  Lines           753     2811     +2058
  Branches        236      211       -25
=============================================
+ Hits            719     1472      +753
- Misses           34     1215     +1181
- Partials          0      124      +124

Impacted Files
Coverage Δ

...featureprobe/api/controller/WebHookController.java
0.00% <0.00%> (ø)

...a/com/featureprobe/api/service/WebHookService.java
63.04% <0.00%> (ø)

...ature-probe-ui/src/components/Variations/index.tsx

...e-probe-ui/src/components/SwitchLanguage/index.tsx

feature-probe-ui/src/components/Rule/condition.tsx

feature-probe-ui/src/components/History/index.tsx

feature-probe-ui/src/components/NoData/index.tsx

feature-probe-ui/src/components/Filter/index.tsx

feature-probe-ui/src/components/FormItem/index.tsx

...ture-probe-ui/src/components/FormItem/password.tsx

... and 135 more


Feature: Need to add a new domain name

🚀 Feature Proposal
I recently discovered that the official domain name of leetcode has changed from leetcode-cn.com to leetcode.cn. This means that the plugin needs to be transformed, and I'm willing to help if I can~
behavior: #798 #799
Motivation
If you don't change it, the Chinese leetcode will not be available anymore.
Contribution
I will add a new domain name in this file

是域名的问题，我基于官方插件修改的版本修复了这个问题，详情看这里：labuladong 的 vscode 刷题插件

@labuladong Yes, it is indeed a problem with the domain name. Thank you for contributing such a good plugin, I'll try it out. Also hope the official can modify the project soon.

This link solves the problem; just replace the domain name.
Of course, I would still like to submit a PR to solve this problem and ask the official to take care of this issue. I am willing to contribute to it.

try 0.18.1, feel free reopen issue if it wont resolve your issue


Use protocolless URL for external resource

So jQuery loads if sitemap.xml is requested via HTTPS

Protocoless URI's are now an antipattern (http://www.paulirish.com/2010/the-protocol-relative-url/) should just use https.

@wilr I can never keep up with what is the "right" way and the "wrong" way these days!


Android - Payments - Debit card option Is missing under the Add payment method

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Action Performed:

Launch the app
Log in with expensifail accounr
Go to Setting - Payments
Tap on Add Payment method

Expected Result:
Debit Card option is visible under Payments
Actual Result:
Debit Card option is missing under Payments
Workaround:
Unknown
Platform:

Where is this issue occurring?

Android

Version Number: <IP_ADDRESS>
Reproducible in staging?: Yes
Reproducible in production?: No
Email or phone of affected tester (no customers): any expensifail account
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
https://user-images.githubusercontent.com/93399543/180892026-cc07d5a8-0b3e-4688-9ce0-24a47036f0c5.mp4
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:
View all open jobs on GitHub

:wave: Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

Identify the pull request that introduced this issue and revert it.
Find someone who can quickly fix the issue.
Fix the issue yourself.

Just to confirm, this is only occurring on Android? And it is 100% reproducible or intermittent?
Seems this option would be hidden if the betas are not yet loaded.
Does the option appear eventually?

Seems potentially related to this -> https://github.com/Expensify/Expensify/issues/213881
https://github.com/Expensify/App/pull/9768
cc @yuwenmemon @luacmartins

It could be related to removing the beta, but I couldn't repro on the simulator. @marcaaron did you manage to reproduce this?

Testing on a hardware device. App feels pretty unstable...

white screen for several seconds when logging in
unable to tap the settings icon for many seconds later
generally very slow

But I am able to access the Debit Card option fine.

@kbecciv could you test this again? We are having issues reproducing this on our end.

@luacmartins We are checking

Issue is repro
https://user-images.githubusercontent.com/43995119/181137616-934e37fc-5e68-4d5f-a7ae-587a8f432a70.mp4

The only way I could reproduce this issue was delaying the response of OpenApp with a setTimeout, but the option eventually shows up when the call completes. @kbecciv can you confirm if the issue still happens with the steps below?

Log out
Sing back in
Wait 15-20s
Navigate to Settings > Payments > Add payment method
Verify that debit card is an option

checking with the team

Removing the blocker label since we couldn't reproduce and this would only affect a beta feature. @mvtglobally Can we add this to the KI tests?

@kbecciv  is this issue still reproducible?

@luacmartins Chcking, update you shortly

Unable to reproduce it with build v1.1.88-14

Thanks for confirming! I think this was fixed here. Not really sure how though.
Closing this issue. Please reopen if you see this happening again.


Do you upload Pre-Trained Model?

Dear,
Question 1: Are you planning or already upload the pre-trained models (if you already trained multiple model)? Can you share the links on github to download those model and used for only inference and validation?
Question 2: If you can share the hyperparameters for training each specific model with results and loss function? Also, if you can share how much time it will take to train those models on your specific machine?
Best,

The pre-trained models can be found here: https://github.com/foamliu/InsightFace-v2/releases/download/v1.0/BEST_checkpoint_r101.tar.

Hello,
I run with your checkpoint https://github.com/foamliu/InsightFace-v2/releases/download/v1.0/BEST_checkpoint_r101.tar.
Accuracy: 99.61666666666666%, threshold: 75.49033778039826
Different with your report, why ?


I had to use da to activate the Danish dictionary

In the docs, and in the code of the extension, it says to use dk to activate the danish dictionary.
This did not work for me, but using da to activate the Danish dictionary did work.

da is correct. I'll look at the docs.

Fixed: streetsidesoftware.code-spell-checker-danish


Small path correction

Just a missing s in the path.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Stream returned by ZipFile.GetInputStream() hangs when accessing Length property

Steps to reproduce

Create a new ZipFile instance
Get a Stream object returned by ZipFile.GetInputStream(), and try to get it's length.
Program stuck

Expected behavior
Return the acutal length of the decompressed file. Or throw an expection if it's not possibile.
Actual behavior
When accesing  Stream.Length propperty from the object returned by  ZipFile.GetInputStream(), execution hangs.
Version of SharpZipLib
Obtained from (only keep the relevant lines)

Package installed using NuGet
1.3.3

It should throw, not sure what is happening in your case:
https://github.com/icsharpcode/SharpZipLib/blob/519ed7367daf0a5ad7f2d36bee6e994ffcd7e9e8/src/ICSharpCode.SharpZipLib/Zip/Compression/Streams/InflaterInputStream.cs#L534-L544

Ah, my bad. Exception not caught correctly, nevermind


add Formatter for CreateTable statement

Add formatter for CreateTable statement, also add TableOption and ColumnOption structure for it.
But still not support PARTITION option.
DEMO
package main

import (
	"fmt"

	"github.com/knocknote/vitess-sqlparser/sqlparser"
)

func main() {
	stmt, err := sqlparser.Parse(`
CREATE TABLE partition_example (
  id bigint(20) unsigned NOT NULL AUTO_INCREMENT,
  created_at datetime NOT NULL,
  PRIMARY KEY (id, created_at)
) ENGINE=InnoDB DEFAULT CHARSET=utf8
PARTITION BY RANGE COLUMNS(created_at)
(PARTITION p201809 VALUES LESS THAN ('2018-10-01') ENGINE = InnoDB,
 PARTITION p201810 VALUES LESS THAN ('2018-11-01') ENGINE = InnoDB,
 PARTITION p201811 VALUES LESS THAN ('2018-12-01') ENGINE = InnoDB,
 PARTITION p201812 VALUES LESS THAN ('2019-01-01') ENGINE = InnoDB,
 PARTITION p201901 VALUES LESS THAN ('2019-02-01') ENGINE = InnoDB,
 PARTITION p201902 VALUES LESS THAN ('2019-03-01') ENGINE = InnoDB,
 PARTITION p201903 VALUES LESS THAN ('2019-04-01') ENGINE = InnoDB,
 PARTITION p201904 VALUES LESS THAN ('2019-05-01') ENGINE = InnoDB,
 PARTITION p201905 VALUES LESS THAN ('2019-06-01') ENGINE = InnoDB,
 PARTITION p201906 VALUES LESS THAN ('2019-07-01') ENGINE = InnoDB,
 PARTITION p201907 VALUES LESS THAN ('2019-08-01') ENGINE = InnoDB,
 PARTITION p201908 VALUES LESS THAN ('2019-09-01') ENGINE = InnoDB,
 PARTITION p201909 VALUES LESS THAN ('2019-10-01') ENGINE = InnoDB,
 PARTITION p201910 VALUES LESS THAN ('2019-11-01') ENGINE = InnoDB,
 PARTITION p201911 VALUES LESS THAN ('2019-12-01') ENGINE = InnoDB);
`)
	if err != nil {
		panic(err)
	}
	fmt.Println(sqlparser.String(stmt))
	/*
		       output the following

			   CREATE TABLE `partition_example` (
			           `id` bigint(20) UNSIGNED NOT NULL AUTO_INCREMENT,
			           `created_at` datetime NOT NULL,
			           PRIMARY KEY  (`id`, `created_at`)
			   ) ENGINE=InnoDB DEFAULT CHARSET=utf8
	*/
}

LGTM:+1:

thanks!


Remove unsound offset_of macro

And replace it with constants that define the offsets to the fields.
It's not a pretty solution, but it's one without UB.
Closes #1483.

This should fix #1483 @RalfJung.

Merging #1487 because that CI fails without this change, and this pr fails without #1487.


Roll Flutter Engine from cb51292d802e to 99162a301412 (1 revision)

https://github.com/flutter/engine/compare/cb51292d802e...99162a301412
2024-10-14<EMAIL_ADDRESS>Disable non-functional and deprecated package_api_docs lint (flutter/engine#55833)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jacksongardner<EMAIL_ADDRESS>on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Commit queue failed; closing this roll.


Add suport for Type.MakeArrayType and Array.CreateInstance

I thought this would require a #if CORERT hack in the classlib, but turns out this  is just about emitting another mapping table. On Project N, this mapping table only has arrays of value types in it (type loader builds the rest on demand), but on CoreRT we don't generate enough data structures to support type loader yet. Turns out that if we put the reference types in the table, the type loader is able to find them and won't try to build them.

Also adding support for parsing array type syntax in RD.XML. Instead of building yet another parser, I'm deferring to the custom attribute type name format. This change is not compatible with Project N's RD.XML since the syntax for generic type instantiations is different, but at this point I don't care.

@nattress PTAL

LGTM


fix(ds): add back runc cleanup

Changes

#1172  👈
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @MasterPtato and the rest of your teammates on  Graphite


Update Travis-CI for R

Coverage decreased (-8.5%) to 73.228% when pulling f9260f3f71aa4cdaba320448b7f724ea83b0f57d on update_travis into 5c230ebbd28b6d4e95d60f366991b796f93793ac on master.

Coverage decreased (-8.5%) to 73.228% when pulling f9260f3f71aa4cdaba320448b7f724ea83b0f57d on update_travis into 5c230ebbd28b6d4e95d60f366991b796f93793ac on master.


license?

I may be using this project, so it would be nice to know how you plan on licensing it? The simplest solution would be to follow upstream (zlib) or rust (apache + mit dual).

License is MIT. There's now  a LICENSE file in addition to the Cargo property.
Before using it, you should run cargo bench to get a benchmark. In my experience, XXHash3 is always faster.

Thank you! Yea XXHash3 is pretty solid but afaik doesn't have a collision proof which I need for my use case.


Site and global config should not be merged to module index

Not actual, it should be merged to allow retrieve at least the public directory path.


SL Review: UX Testing with ADMs

[x] Create the script for UX testing

[ ] Finalize list of ADMs to test with

[ ] Conduct UX Testing session with ADMs

UX testing plan reviewed Sept 28. Jodi/Eddie will provide a script about the SL review for Fazil. Deb Godfrey sent out invite to ADMs to participate in testing on Sept 29 (4 days later than expected). Expecting responses back by Oct 4. Can begin scheduling after that.

HI there, Is UX testing still in scope/required for launch?


Added AWTRIX3 and E-Flux plugins + url validation via github workflows

@stas-demydiuk what do you think, can you review?


RFC: Allow concurrent testing without excessive warning noise

OTELJS uses @opentelemetry/api/build/src/internal/global-utils.js, which provides value for managing the singleton nature of tracing resources.
Use of globals makes sense in prod at runtime, but during tests, if you bring servers up and down, your console gets littered with warnings/errors, which is highly undesirable:
    console.warn
      Current logger will overwrite one already registered from Error:
          at DiagAPI.setLogger (/Users/c0d01a5/src/ce-sample-service-2/node_modules/.pnpm/@opentelemetry+api@1.6.0/node_modules/@opentelemetry/api/src/api/diag.ts:97:23)
          at setupOrchestraTracerProvider (/Users/c0d01a5/src/ce-sample-service-2/node_modules/.pnpm/@org+orchestra-tracing@0.0.0-beta.20231129171128_@types+node@20.10.1/node_modules/@org/orchestra-tracing/src/setup/setup-tracing-provider.ts:79:10)
          at setupPlugIn (/Users/c0d01a5/src/ce-sample-service-2/node_modules/.pnpm/@org+orchestra-tracing@0.0.0-beta.20231129171128_@types+node@20.10.1/node_modules/@org/orchestra-tracing/src/plug-ins/fastify3-plug-in.ts:239:54)
          at Plugin.Object.<anonymous>.Plugin.exec (/Users/c0d01a5/src/ce-sample-service-2/node_modules/.pnpm/avvio@8.2.1/node_modules/avvio/plugin.js:130:19)
          at Boot.loadPlugin (/Users/c0d01a5/src/ce-sample-service-2/node_modules/.pnpm/avvio@8.2.1/node_modules/avvio/plugin.js:272:10)
          at processTicksAndRejections (node:internal/process/task_queues:82:21)

      at DiagConsoleLogger.warn (node_modules/.pnpm/@opentelemetry+api@1.6.0/node_modules/@opentelemetry/api/src/diag/consoleLogger.ts:49:28)
      at DiagAPI.setLogger (node_modules/.pnpm/@opentelemetry+api@1.6.0/node_modules/@opentelemetry/api/src/api/diag.ts:99:19)
      at setupOrchestraTracerProvider (node_modules/.pnpm/@org+orchestra-tracing@0.0.0-beta.20231129171128_@types+node@20.10.1/node_modules/@org/orchestra-tracing/src/setup/setup-tracing-provider.ts:79:10)
      at setupPlugIn (node_modules/.pnpm/@org+orchestra-tracing@0.0.0-beta.20231129171128_@types+node@20.10.1/node_modules/@org/orchestra-tracing/src/plug-ins/fastify3-plug-in.ts:239:54)
      at Plugin.Object.<anonymous>.Plugin.exec (node_modules/.pnpm/avvio@8.2.1/node_modules/avvio/plugin.js:130:19)
      at Boot.loadPlugin (node_modules/.pnpm/avvio@8.2.1/node_modules/avvio/plugin.js:272:10)

    console.error
      Error: @opentelemetry/api: Attempted duplicate registration of API: trace
          at registerGlobal (/Users/c0d01a5/src/ce-sample-service-2/node_modules/.pnpm/@opentelemetry+api@1.6.0/node_modules/@opentelemetry/api/src/internal/global-utils.ts:47:17)
          at TraceAPI.setGlobalTracerProvider (/Users/c0d01a5/src/ce-sample-service-2/node_modules/.pnpm/@opentelemetry+api@1.6.0/node_modules/@opentelemetry/api/src/api/trace.ts:67:35)
          at BasicTracerProvider.register (/Users/c0d01a5/src/ce-sample-service-2/node_modules/.pnpm/@opentelemetry+sdk-trace-base@1.18.0_@opentelemetry+api@1.6.0/node_modules/@opentelemetry/sdk-trace-base/src/BasicTracerProvider.ts:153:11)
          at setupPlugIn (/Users/c0d01a5/src/ce-sample-service-2/node_modules/.pnpm/@org+orchestra-tracing@0.0.0-beta.20231129171128_@types+node@20.10.1/node_modules/@org/orchestra-tracing/src/plug-ins/fastify3-plug-in.ts:241:18)
          at Plugin.Object.<anonymous>.Plugin.exec (/Users/c0d01a5/src/ce-sample-service-2/node_modules/.pnpm/avvio@8.2.1/node_modules/avvio/plugin.js:130:19)
          at Boot.loadPlugin (/Users/c0d01a5/src/ce-sample-service-2/node_modules/.pnpm/avvio@8.2.1/node_modules/avvio/plugin.js:272:10)
          at processTicksAndRejections (node:internal/process/task_queues:82:21)

This repeats for N-1 test cases for which your code registers OTEL entities.
In order to silence all of this in tests, I am forced to meddle with OT globals. I'm not going to share the code snippet, as I don't want to encourage the behavior for other readers.
Solution-wise, it would be preferable to:

userland to not meddle with OT globals in order to keep a good signal:noise ratio in test output
userland to not mock OT entities in order to keep a good signal:noise ratio in test output

Ideas:

check for NODE_ENV=test and disable the logging
** this has the hazard of not reporting true positive error conditions
check for NODE_ENV=production to enable the logging
** this has the benefit of giving you warnings where you need them most, albeit late in the development process
pick a stronger stance: crash or be silent
provide a testing recipe to the associated loggers and/or global settings to silence these warnings
provide a global log level override for these global utils
...your ideas here :)

[x] This only affects the JavaScript OpenTelemetry library
[ ] This may affect other libraries, but I would like to get opinions here first

Not stale


Toggle to allow old behavior: use straight shortcuts instead of PowerShell scripts

First, I will say that I absolutely love this Manager app; I always will and I hope that this will not be seen as complaining.
I do get where doZennn is coming from, with the advent of PowerShell scripts for imports, that keep each individual launcher for imported games open only as long as the game itself is open; that's best for computers with pretty limited resources, and should remain the default behavior. I do very much appreciate doZennn's looking out for all computer users in this regard :)
Thing is, for those of us with somewhat beefier systems who do not have a problem with Origin, uPlay, EGS etc. remaining resident all the time, having them launch every time a game is launched still does add a short delay to the game's launch, and there is also the factor of the ease of access to the storefronts offered by said launchers before or after playing a game, which is removed by the use of the scripts.
If there were a toggle to allow the old behavior: the creation of straight shortcuts when importing games that require launchers (a la the GOG games, which of course do not require a launcher), instead of forcing the use of the auto-closing PowerShell scripts, I think that would be awesome.
Thank you! Keep up the wonderful work and have a great holiday.

If the launcher is left open after closing a game, Steam won't see the game as closed since it injects the overlay into the launcher and any child processes.

Ooof! That's tough. And I guess that's the only way it can be, if one wants to run non-Steam games while still using the overlay.
Okay, so, this is an impossible issue. The delay's not so bad after all, and if I really want the storefronts I can access the websites themselves or start the client back up.
Thank you for the clarification on why this can't work, doZennn! Closing, and keep up the wonderful work!


switch to unified github context string: suse/cloud

The previous context string "suse/mkcloud" was specific
to mkcloud. So it would be misleading to let jobs testing
other deployment tools report a status using this context
string.
On the other hand adding new context strings and requiring
them as mandatory for a merge would mean that on most PRs
some checks will never be run, because not all PRs run with
all deployment tools.
So this new context string

must have a success status which is mandatory for a merge
will be used for the status of the default test (PR build)
of this PR.
Hint: this is the "standard" job, that is defined in the
github-pr yaml in:
https://github.com/SUSE-Cloud/automation/blob/master/scripts/github_pr/github_pr_cloud.yaml#L5
The "standard" is not added as suffix to the context, while
all other build names (keys on the same level in the yaml) are
appended as suffix to the base context.
is the base string for all additional (optional and mandatory)
contexts that are required (this is already the case).
e.g.
old: suse/mkcloud/stable
new: suse/cloud/stable

Please note:
This PR is just a preparation for the switch of the context string during the planned downtime.
Do NOT merge it yet.

have we considered changing this to suse/cloud/mkcloud/stable instead of suse/cloud/stable ? stable is a very generic term and it was much more specific before.


[sync-server] this.repo.sharePolicy(...).then is not a function

Came here from hypermerge and really glad to see this project. Pluggability ftw!
I'm getting:
dist/synchronizer/CollectionSynchronizer.js:78
            void this.repo.sharePolicy(peerId, documentId).then(okToShare => {
                                                           ^

TypeError: this.repo.sharePolicy(...).then is not a function

Which is fixed in packages/automerge-repo-sync-server/src/index.js in the same way as here:
-   sharePolicy: (peerId) => false,
+    sharePolicy: async (peerId) => false,

Sorry I think I need to clarify. The error is thrown by the code in this repo here https://github.com/automerge/automerge-repo/blob/main/packages/automerge-repo-sync-server/src/index.js#L27 when running yarn start:syncserver and starting to send sync traffic.
My diff is a proposed fix.

Ah, thanks @jmatsushita. Need some tests for sync-server still.

@jmatsushita my apologies. Should have read the title. I'll get a fix for that pushed shortly.
@pvh will see if I can put together a smoke test at the very least.


CM Tools

About the PR

adds CM13's tools, including old sprites
Why / Balance

to-do request

fix #643

Media

note: I fixed the wirecutter's lefthand sprite, but I'm too lazy to take another screenshot because I closed RSIedit by accident.

[x] I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Changelog

You can add fixes or resolves to your pr description to automatically complete issues when merged by the way


Allow Hackmons Cup for past gens

randomHCTeam works by picking six random dex numbers, then a random legitimate forme for each number (so for instance it will only pick a mega in gen >= 6). Naturally, for past gens, some dex numbers have no legitimate formes, so we have to limit the maximum dex number somehow.

Does https://github.com/Zarel/Pokemon-Showdown/blob/master/data/scripts.js#L1055 not fix that?
template.gen <= this.gen

It only helps in the case that the base forme is legal. When the base form isn't legal (because its dex number is too high), then no legal formes exist. The code then crashes trying to use a random forme from an array of length zero.


Added Icy_tower_game

PR Description 📜
Fixes # 5041

Mark the task you have completed ✅

[X] I follow CONTRIBUTING GUIDELINE & CODE OF CONDUCT of this project.
[x] I have performed a self-review of my own code or work.
[X] I have commented my code, particularly in hard-to-understand areas.
[X] My changes generates no new warnings.
[X] I have followed proper naming convention showed in CONTRIBUTING GUIDELINE
[X] I have added screenshot for website preview in assets/images
[X] I have added entries for my game in GameZone's README.md
[X] I have added README.md in my Game folder
[] I have added working video of the game in README.md (optional)
[X] I have specified the respective issue number for which I have requested the new game.
[X] I have added my Game to gamesData.json file and it is loading properly on main website as intended.

Thank you soo much for contributing to our repository 💗

Thank you @pavitraag ,for creating the PR and contributing to our GameZone 💗
Review team will review the PR and will reach out to you soon! 😇
Make sure that you have marked all the tasks that you are done with ✅.
Thank you for your patience! 😀

Done with changes @ishita-43

Please resolve merge

@ishita-43 done

Thank you  @pavitraag , for your valuable time and contribution in our GameZone 💗.
It’s our GameZone, so Let’s build this GameZone altogether !!🤝
Hoping to see you soon with another PR again 😇
Wishing you all the best for your journey into Open Source🚀


isBefore(null) sometimes returns true in Firefox

Calling isBefore() with null returns false most of the time, but sometimes - true. The problem is easily reproducible in Firefox console.
(new Date()).isBefore(null);
=> true

Tested with:

Sugar 1.4.1
Firefox 30 (OS X)

UPD: It can be reproduced in Chrome 41.0.2272.118 but it occurs less frequently.

Will have a look... thanks for this!

Hi, can you confirm that this is still happening? Thank you!

Tested against latest release and cannot reproduce anymore.
Thanks!


bug(http): missing docs and setCookie() allows Max-age to be 0

Description
Regarding this line: https://github.com/denoland/deno_std/blob/45f7a6b46018e9f4d330943918299c68ae80f1bb/http/cookie.ts#L91
While working on the cookie implementation in undici/node, I realized that the max-age implementation is slightly off.
This is what I wrote to the corresponding code piece in the undici PR

Imho the spec rfc 6265 is not correctly implemented.
Either only positive integers excluding 0 are allowed (which the current implementation does not match) for MaxAge or all integer values are allowed (this PR)
I think the problem arises because imho https://www.rfc-editor.org/rfc/rfc6265#section-4.1.1 talks about how the data in the useragent is stored while https://www.rfc-editor.org/rfc/rfc6265#section-5.2.2 talks about the data which the useragent receives and how it should be processed.
So a server can send negative values for max-age, while a client has to drop all cookies with negative values immediatly. If the maxage is set to 0, then it would actually mean to drop the cookie according to the rfc, but it seems most useragents keep the cookie till the end of the session.
Anyhow, this means that we must allow negative integers for validateMaxAge.

https://github.com/nodejs/undici/pull/2888
Expected behavior
Negative numbers should be allowed

setCookie() sends non-expired cookies to the client. If you'd like to send cookies that expire before the current time, use deleteCookie() instead. We should include these facts in the documentation. You are correct that setCookie() should not allow cookies with a Max-age of 0. I'd happily take a look at PRs that fix these two issues.

@iuioiua
What about #992 and #989 ?
ping to @asos-craigmorten @SimonRask  @wperron
So this would be basically a regression?

While adding this isn't a big deal, deleteCookie() does precisely what setCookie() would do if it allowed Max-Age <= 0, so there's no need to make the change. Again, in my eyes, the only tweak that seems reasonable is not allowing setCookie() to set Max-Age >= 0 and documenting this clearly. Yes, let's undo #992.

I think the fix #4459 needs more support from the community to be landed.

@kt3k
who can make the decision? tbh. I still think that we should allow negativ integers.

@Uzlopak, can you please explain why you can't just use deleteCookie()? Again, your suggestion extends the functionality of setCookie() so it overlaps with deleteCookie().

I personally think the current state is a good compromise between what RFC encourage to do (max-age > 0) and what people believe to work (max-age >= 0).
I think the reason why people think max-age=0 should work is that it was encouraged by the older versions of RFCs (https://www.rfc-editor.org/rfc/rfc2109.html, https://www.rfc-editor.org/rfc/rfc2965) and some blog post / Q&As are still mentioning it.

Closing this now. Let's keep the current behavior. @Uzlopak, please feel free to re-open if you're able to provide reasoning behind wanting to support negative expiries. Either way, thank you for the suggestion.


sched: replace the pthread interface used in the kernel

Summary
In protected build, kernel cannot call usersapce interface：

change pthread_exit to nx_pthread_exit.
change pthread_kill to tkill.

Impact
pthread_exit and pthread_cancel.
Testing
ostest passed on the sabre-6quad:knsh_smp board

[Experimental Bot, please feedback here]
No, the provided PR summary does not meet the NuttX requirements.
Here's why and how to improve it:

Missing Details: The summary lacks critical information:

Why is this change necessary? Explain the problem with using pthread_exit and pthread_kill in a protected build. What errors or issues were encountered?
How do the changes work? Provide a more technical explanation of how replacing the functions addresses the problem.
Issue References:  Are there related NuttX issues that this PR addresses? If so, include the issue numbers.

Impact Section Needs Expansion:

Feature Impact: Be specific. Is this a bug fix, an optimization, or a new behavior?
User Impact:  Will users notice any functional changes? Will they need to modify their applications?
Build Impact: Will users need to change any build configurations or options?
Hardware Impact: Be specific about the affected architectures and boards.
Documentation: If this change affects user-facing behavior, you'll likely need to update the documentation. Mention if you've included those updates in your PR.
Security, Compatibility:  Address these points, even if the answer is "NO."

Testing is Insufficient:

More Details:  Provide more specific information about your testing environment:

Build Host OS:  (e.g., Ubuntu 20.04, macOS 13.2)
Build Host Compiler: (e.g., GCC 11.2, Clang 14.0.0)
Target Architecture:  (e.g., ARMv7-M, RISC-V)
NuttX Configuration: (e.g., knsh_smp, any custom configurations)

Show Relevant Logs:  The provided logs are placeholders. Include the actual error messages or output that demonstrate the issue before the change and the correct behavior after the change.

Example of an Improved Summary:
## Summary

This PR addresses a critical issue where using `pthread_exit` and `pthread_kill` directly in a protected build environment leads to system instability and potential crashes. This is because these standard POSIX functions are not designed to handle the memory protection boundaries between the kernel and userspace in a protected build.

To resolve this, the PR replaces the problematic calls with their NuttX-specific counterparts:

* `pthread_exit` is replaced with `nx_pthread_exit`, which is specifically designed to manage thread termination within the NuttX protected build context.
* `pthread_kill` is replaced with `tkill`, which provides a kernel-safe mechanism for sending signals to tasks within the NuttX environment.

This change ensures proper thread management and signal handling in protected builds, enhancing system stability and preventing potential crashes.

**Related Issue:** #1234 (Replace this with the actual issue number if applicable)

## Impact

* **Feature Impact:** Bug fix - Improves stability and correctness in protected builds.
* **User Impact:** Users running NuttX in a protected build configuration will benefit from increased stability. No application code changes are required.
* **Build Impact:** None.
* **Hardware Impact:** Affects all architectures and boards running NuttX in a protected build configuration.
* **Documentation Impact:** The documentation will be updated to reflect the correct usage of `nx_pthread_exit` and `tkill` in protected builds.
* **Security Impact:**  The change improves system stability, indirectly enhancing security by preventing potential crashes.
* **Compatibility Impact:** None.

## Testing

**Build Host:**
* OS: Ubuntu 22.04
* Compiler: GCC 11.3.0

**Target:**
* Architecture: ARMv7-M
* Board: STM32F4 Discovery board
* NuttX Configuration: `knsh_smp` with protected build enabled

**Testing Logs (Before Change):**

[Relevant log output showing the error or crash caused by the original pthread_exit/pthread_kill calls]

**Testing Logs (After Change):**

[Relevant log output demonstrating the correct behavior after using nx_pthread_exit and tkill]


security.ssl3.ecdhe_rsa_aes_256_sha; false - broke uBlock Origin "MVPS HOSTS" filter update.

When user_pref("security.ssl3.ecdhe_rsa_aes_256_sha", false); this breaks the connection to https://winhelp2002.mvps.org/ and prevents the uBlock Origin "MVPS HOSTS filter from updating. Decision at your discretion.

There's a reason they are not disabled by default: because they are still used in the wild. I did the stats on them all and it was about 3% of nightly/beta traffic used the ciphers in 1263+1264

@gwarser FYI

for the record: (from when I looked them up a few weeks ago)

the code numbers are [here](from https://dxr.mozilla.org/mozilla-central/source/security/manager/ssl/nsNSSCallbacks.cpp#903)
telemetry from SSL_CIPHER_SUITE_FULL:

go to https://telemetry.mozilla.org/
click Measurement Dashboard, etc

   // user_pref("security.ssl3.ecdhe_rsa_aes_128_sha", false);   //  3: 0.33%
   // user_pref("security.ssl3.ecdhe_ecdsa_aes_128_sha", false); //  4: 0.01%
   // user_pref("security.ssl3.ecdhe_rsa_aes_256_sha", false);   //  5: 0.91%
   // user_pref("security.ssl3.ecdhe_ecdsa_aes_256_sha", false); //  6: 0.00%
   // user_pref("security.ssl3.dhe_rsa_aes_128_sha", false);     // 21: 0.17% DHE [DEFAULT: false FF78+]
   // user_pref("security.ssl3.dhe_rsa_aes_256_sha", false);     // 23: 0.30% DHE [DEFAULT: false FF78+]
   // user_pref("security.ssl3.rsa_aes_128_sha", false);         // 61: 1.16% NOPFS
   // user_pref("security.ssl3.rsa_aes_256_sha", false);         // 63: 0.83% NOPFS

So excluding the DHE which are now disabled by default, that's approx 3.24%. ecdhe_rsa_aes_256_sha is about 1%

"MVPS HOSTS" is available, but not enabled by default.


initial snippets for classroom course management

added changes for all feedback except the if (courses.length).

Ping after fixing the === statements and we'll merge.

Ping after fixing the == (to ===) statements and we'll merge.

great, thanks! submitted the change