[5.8] Fix: FormRequest: Call to a member function validated() on null

In normal case app will call FormRequest::validateResolved() and this method will create a new instance of validator. But when you create/mock FormRequest by hand (in our case we need a mock for tests) the validateResolved() will not be called -> FormRequest::$validator will be null => $request->validated() will fail: "Call to a member function validated() on null".
This PR fixes this.

Could have side effects. Do not mock FormRequests. Just run an integration test.

@taylorotwell, in big app with complex logic this is too difficult and required a lot of mocks... Request mock much better. And in any case, this is a bug.


Retain (and indicate) orphaned dynamic profiles

The original intent with dynamic profiles was that they could be uninstalled but that Terminal would remember your settings in case they ever came back.
After we implemented dynamic profile deletion, however, we accidentally made it so that saving your settings after a dynamic profile disappeared scoured it from the planet forever (since we remembered that we generated it, but now it was no longer in the settings file).
This pull request implements:

Tracking for orphaned dynamic profiles
A new settings page for the profile that explains what happened
Badging on the Navigation Menu indicating which profiles are orphaned and which are hidden

Closes #14061
Closes #11510
Refs #13916
Refs #9997
It looks like this:

If you disable all profile sources, it looks barren indeed:

@zadjii-msft does this actually _close _#9997?

Removed from body
It looks like this:

If you disable all profile sources, it looks barren indeed:


Chat not working

Every time I start with a langchain-repo I spend at least 2 days to get it to work.
If it is not built for windows, just mention it explicitly.  I do not want to waste time.
Just checkedout and have this problem after starting chat:
✓ Compiled /_error in 960ms (3168 modules)  ⨯ Error: Error in similaritySearch Error: Cannot query field "russel" on type "GetObjectsObj". Did you mean "Russel"?: {"response":{"errors":[{"locations":[{"column":6,"line":1}],"message":"Cannot query field \"russel\" on type \"GetObjectsObj\". Did you mean \"Russel\"?","path":null}],"status":200,"headers":{}},"request":{"query":"{Get{russel(nearVector:{vector:[-0.0134877665,-0.011036796,-0.009321116,
What is the issue

It's probably because it is saved as Russel on Weaviate. Weaviate seems to upper case the index name automatically


Feature Request - Add images to blocks

A handy feature would be if it was possible to upload an image which gets displayed alongside the block name, to help illustrate the layout which that particular block will end up displaying like.

 Blocks to change


[Feature]the webservice component has no args parameter

Is your feature request related to a problem? Please describe.

At present, the webservice component has only command parameter, but no args parameter. Therefore, it needs to be extended for easy use
Describe the solution you'd like

Add the args parameter to the webservice component
Describe alternatives you've considered

Additional context

https://github.com/kubevela/kubevela/pull/5227


Visual Studio Code - Insiders: Projects file not found

I can see, you already have a TODO in vsc.js:44 for this. Any news on that? If I find the time, I'll see if I can make it work and create a Pull Request. Just wanted to make sure, it's really not working yet with your code in comments.

Version 1.1.0 containing PR #6 from @kaibrueckers 👍 just released


iOS upload screen: picture progress

When 30% of the photo has been uploaded, it would be nice to show 30% of the photo on the mobile upload screen (and maybe 70% faded "left to be uploaded").

This depends on #171: first we must know the upload progress!


Refresh landing page

Following the new design conventions.
One thing worth noting is that I changed the logo colors and dropped the gradient. IMHO looks better and is in line with the rest of the tools. Made a PR for The Guild's components too: https://github.com/the-guild-org/the-guild-components/pull/510.

Uses flex gap here

Uses flex gap here

It confused, I thought below items are clickable

Uses flex gap here

The features do have a gap, they have the class gap-6. However, the gap seems to disappear when reducing the screen size. Can you check please @B2o5T? I am really unfamiliar with tailwind. 😅

It confused, I thought below items are clickable

Made them clickable.

Uses flex gap here

The features do have a gap, they have the class gap-6. However, the gap seems to disappear when reducing the screen size. Can you check please @B2o5T? I am really unfamiliar with tailwind. 😅

It confused, I thought below items are clickable

Made them clickable.

Will fix tomorrow!

Subscriptions and File Uploads are not related to the GraphQL over HTTP specification

spacings feel to big for me

I feel like each of this points should have a "Learn more" link that links to the specific documentation?

Error masking is kind of a default - maybe we should instead have a sectiopn that showcases the features that are enabled by default (error masking, parser/validation caching) - then have another one for additional plugins (response caching, auth, rate-limiting)

Pushed a bunch of improvements keeping the requested changes in mind.
Looks significantly better now TBH, I even altered the SVGs to match each of the section's color scheme 😅 .
I'd love it if you guys could give the page a fresh look and leave feedback (especially about details I potentially missed).


Run VSCode tasks in a single session

I would like to migrate my local deployment commands to VSCode task. I need to run them as root. When I did those in the terminal, I was asked to provide the password only once.
$ sudo echo hello
[sudo] password for pt12lol:
hello
$ sudo echo hello
hello

Unfortunately when I configured my VSCode task:
{
    "version": "2.0.0",
    "tasks": [
        {
            "label": "Hello task",
            "type": "shell",
            "command": "sudo echo hello"
        }
    ]
}

I suppose it runs every task in a separate session, and I am asked to provide my password every single time.
> Executing task: sudo echo hello <

[sudo] password for pt12lol:
hello

Terminal will be reused by tasks, press any key to close it.

> Executing task: sudo echo hello <

[sudo] password for pt12lol:
hello

Terminal will be reused by tasks, press any key to close it.

I would like to set up tasks deployment so that it keeps last sessions and I am not asked for my password every single time.

duplicate of https://github.com/microsoft/vscode/issues/44152


Action routing in the post-signal-overhaul age

Before #20, actions could be connected with SignalRouter like so:
let router = TestSignal::connector().route_to::<TestActor>(ctx);
// ...
router.connect(&action, "activate", signal_name).unwrap();

And this made sense, since the action signals were converted to a BuilderSignal enum variant.
#20 removes BuilderSignal, and while actions can still be connected with:
woab::route_signal(action, "activate", signal_name, ctx.address()).unwrap();

This creates a woab::Signal, which means it takes two steps to get the action parameter - first convert the glib::Value to glib::Variant, and then get the concrete type from the variant.
This is far less convenient than what we had!
Actions are common enough (I think?) and always have the same structure. Why not give them their own message type?
woab::route_action_activate(action, ctx.address()).unwrap();
// Or
woab::route_action_change_state(action, ctx.address()).unwrap();

We can use the action to identify the signal (either by name or by exposing the action object) and the action type can
impl actix::Handle<woab::ActionSignal> for MyActor {
    type Result = woab::ActionSignalResult;

    fn handle(&mut self, msg: woab::Signal, ctx: &mut <Self as actix::Actor>::Context) -> Self::Result {
        Ok(match msg.name() {
            "action1" => {
                let param = msg.param()?; // Unlike woab::Signal::param, woab::ActionSignal.param needs no index
                // ...
            }
            "action2" => {
                // ...
            }
            _ => msg.cannot_handle()?,
        })
    }
}

To be honest, I like having all my handlers in one place and only having to implement Handler once. Most of the time, I only care about the action and don't use the parameters anyways.
I'd prefer a solution that makes the boilerplate manageable. I'm thinking of something similar to how we deal with event subtypes. For example, one could add an action_param<T>, that asserts the number of arguments, casts the first argument to Variant and then further down to T or something like that.

Makes sense. Now that I think about it, my main beef is with the verbosity of woab::route_signal which is unneeded when it comes to actions, but I can have woab::route_action that deduces the signal type and the signal name from the action, and sends a standard woab::Signal.
I was actually thinking about having msg.param_variant(1) for actions and msg.param_event(1) for events, to make things flexible enough for anything that uses variants/events. But I can't really think of any other signal that uses these, and while this doesn't mean there aren't any - one could always use msg.param() and convert it manually, so we are not losing much from using msg.action_param() and msg.event_param() that can only use the second parameter.
Is it really necessary though to fail if there are more than two parameters?

Is it really necessary though to fail if there are more than two parameters?

Good question. I'm failing to find any case where implicitly ignoring arguments could lead to undesired behavior.

OK - action routing looks good now, with woab::route_action() and Signal::action_param(). https://github.com/idanarye/woab/blob/action-routing/examples/example_actions.rs


Update showcase.js

Thanks for submitting a pull request! Please provide enough information so that others can review your pull request:
(You can skip this if you're fixing a typo or adding an app to the Showcase.)
Explain the motivation for making this change. What existing problem does the pull request solve?
Prefer small pull requests. These are much easier to review and more likely to get merged. Make sure the PR does only one thing, otherwise please split it.
Test plan (required)
Demonstrate the code is solid. Example: The exact commands you ran and their output, screenshots / videos if the pull request changes UI.
Make sure tests pass on both Travis and Circle CI.
Code formatting
Look around. Match the style of the rest of the codebase. See also the simple style guide.
For more info, see the "Pull Requests" section of our "Contributing" guidelines.

By analyzing the blame information on this pull request, we identified @lacker and @brentvatne to be potential reviewers.

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at<EMAIL_ADDRESS>Thanks!

Hey @alexHlebnikov, we are changing the way the showcase works so that everything now has a link to some external content, like press coverage by a well-known publisher, or a deep technical blog post detailing the development process using React Native. Unfortunately it does not seem like this application meets these requirements at this time.

Hi @hramos!
Can you tell me more details which requirements were doesn't met?
Because Sib.fm is a well known in Siberia internet media.
Also, the app is branded with a public company brand - [2GIS] (http://info.2gis.com/index_en.html).
Why these two conditions are not enough?

Well, the link should just be useful for the average reader of the website. Usually that means, there's some reason it would get clicked on, and then there's some useful content at the link. In particular it probably has to be in English to be useful to the readers of the website - the language is vast majority English, a little bit Chinese, and then a huge dropoff to #3. Even the Chinese apps we are including here have English-language links. The only stuff I can find looks Russian, so, it just doesn't seem like it would be something we can get people to click on.

Thank you for answer, @lacker.


ADMX_WindowsExplorer/EnableSmartScreen is incorrectly not applying due to a licensing rejection under Windows 11 Business

ADMX_WindowsExplorer/EnableSmartScreen is incorrectly not applying due to a licensing rejection under Windows 11 Business:
MDM PolicyManager: Policy is rejected by licensing, Policy: (EnableSmartScreen), Area: (ADMX_WindowsExplorer), Result:(0x82B00006) Unknown Win32 Error code: 0x82b00006.

Document details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 6fe02a28-215f-f176-6086-8e79fcb48471
Version Independent ID: f9143995-669d-be4d-3632-be2d0517d452
Content: Policy CSP - ADMX_WindowsExplorer - Windows Client Management
Content Source: windows/client-management/mdm/policy-csp-admx-windowsexplorer.md
Product: w10
Technology: windows
GitHub Login: @vinaypamnani-msft
Microsoft Alias: vinpa

Hey @pcamh, we're in the process of updating the CSP docs using a new format which will make this issue obsolete as the new format doesn't include Business applicability. As we continue, we'll work further on including the Business edition applicability appropriately for all CSPs, so I'm closing this issue for the time being.


B 20756

Agility ticket
Summary
Is there anything you would like reviewers to give additional scrutiny?
this article explains more about the approach used.
Verification Steps for the Author
These are to be checked by the author.

[ ] Tested in the Experimental environment (for changes to containers, app startup, or connection to data stores)
[ ] Have the Agility acceptance criteria been met for this change?

Verification Steps for Reviewers
These are to be checked by a reviewer.

[ ] Has the branch been pulled in and checked out?
[ ] Have the BL acceptance criteria been met for this change?
[ ] Was the CircleCI build successful?
[ ] Has the code been reviewed from a standards and best practices point of view?

Setup to Run the Code

Instructions for starting storybook
Instructions for starting the MilMove application
Instructions for running tests

How to test

Access the
Login as a

Frontend

[ ] There are no aXe warnings for UI.
[ ] This works in Supported Browsers and their phone views (Chrome, Firefox, Edge).
[ ] There are no new console errors in the browser devtools.
[ ] There are no new console errors in the test output.
[ ] If this PR adds a new component to Storybook, it ensures the component is fully responsive, OR if it is intentionally not, a wrapping div using the officeApp class or custom min-width styling is used to hide any states the would not be visible to the user.
[ ] This change meets the standards for Section 508 compliance.

Backend

[ ] Code follows the guidelines for Logging.
[ ] The requirements listed in Querying the Database Safely have been satisfied.

Database
Any new migrations/schema changes:

[ ] Follows our guidelines for Zero-Downtime Deploys.
[ ] Have been communicated to #g-database.
[ ] Secure migrations have been tested following the instructions in our docs.

Screenshots

Warnings

:warning:

Files located in legacy directories (src/shared or src/scenes) have
been edited. Are you sure you don’t want to also relocate them to the new file structure?
View the frontend file org ADR for more information

  Generated by :no_entry_sign: dangerJS against ce5d6759c60aba448f31e42095d6016994cb3e12

Test coverage on client failed.
Last run: Mon 21 Oct 2024 02:44:01 PM UTC
Refer to this report to see coverage details for the client app.
Documentation for test coverage can be found at this link.

Test coverage on server failed.
Last run: Tue 22 Oct 2024 02:37:52 PM UTC
Refer to this report to see coverage details for the server app.
Documentation for test coverage can be found at this link.

Test coverage on server failed.
Last run: Thu 24 Oct 2024 04:45:43 PM UTC
Refer to this report to see coverage details for the server app.
Documentation for test coverage can be found at this link.


Updated Oculus Rift driver

This version of the plugin is autoloading and doesn't require the VRPN driver. It also supports Oculus SDK versions 0.4.4-beta through <IP_ADDRESS>-beta.
It addresses the issues #1, #8, and #9.

please make sure to also update the OSVR-DOCS repository
On Tue, Feb 23, 2016 at 3:14 PM, Kevin Godby<EMAIL_ADDRESS>wrote:

This version of the plugin is autoloading and doesn't require the VRPN
driver. It also supports Oculus SDK versions 0.4.4-beta through
<IP_ADDRESS>-beta.
It addresses the issues #1
https://github.com/OSVR/OSVR-Oculus-Rift/issues/1, #8
https://github.com/OSVR/OSVR-Oculus-Rift/issues/8, and #9
https://github.com/OSVR/OSVR-Oculus-Rift/issues/9.
You can view, comment on, or merge this pull request online at:
https://github.com/OSVR/OSVR-Oculus-Rift/pull/10
Commit Summary

Initial work on new Oculus Rift driver.
Added helper macros for determing Oculus Rift SDK version.
Updated FindOVR.cmake script to work with OVR SDK 0.6.x
Updated to work with MSVC 2013 and OVR SDK 0.6.x.
Work with multiple versions of Oculus SDK.
Builds against dynamic OVR library under Linux. Started work on
sending tracking data.
More work on the Oculus Rift plugin. Still buggy.
Install documentation in the proper subdirectory.
Improved searching for Oculus SDK libraries.
Tidy up FindOVR.cmake. Search proper subdir for headers.
FindOVR.cmake: Now successfully finds OVR 0.4.4 libraries in
Windows. Also adjusted VS platform detection code.
Find OVR 0.4.4 libraries.
Started work on updating to OVR <IP_ADDRESS>.
More work on updating driver.
Successfully builds against all versions of Oculus SDK 0.4.4 through
<IP_ADDRESS>.
Fixed include directories for renamed header file.
Updated README.
Fix some lifetime issues.
Printing context address for debugging.
Printing context address for debugging.
Catch exception when OculusRift can't be constructed.
Moved source files to src/ subdir. Removed debug messages.
Adding initial Travis CI scripts.
Updated teh README.
Fixed bug in travis.yml file.
Fixed bug in OSVR-Core build script for Travis CI.
Fixed more Travis CI bugs.
Travis CI: Improved OpenCV installation detection.
Travis CI: Overwrite on unzip.
Travis CI: Added libudev dependencies.
Travis CI: Added cmake. Fixed OVR SDK dir.
Travis CI: Fixed typo.
Travis CI: Fix OVR SDK OS X URL
Travis CI: Fix OVR directory.
Travis CI: Fix checks for pre-existing dependencies.
Travis CI: Set PATH to include installed dependencies.
Travis CI: Set OpenCV_DIR.
Travis CI: Fix typo in Oculus SDK installer for OS X.
Travis CI: Caching installed dependencies. Updated dependency checks.
Travis CI: Make unzip be quiet.
Travis CI: Removed OpenCV dependency.
Travis CI: See what files have been installed.
Travis CI: Fix OS X path for Oculus SDK. Don't build OSVR clients.
Travis CI: Added missing popd.
Tidied up the code slightly.

--
Yuval Boger
CEO | VRguy http://www.vrguy.net
Sensics, Inc. http://www.sensics.com
Latest news and blog posts:
21 Feb: VRguy podcast Episode 3: Paul Travers, CEO of Vuzix, on AR/VR in
the Enterprise and Consumer Markets
http://sensics.com/vrguy-podcast-episode-3-paul-travers-ceo-of-vuzix-on-arvr-in-the-enterprise-and-consumer-markets/
16 Feb: Vision Summit 2016: Using OSVR to Support (practically) Any Device
in AR/VR
http://vrguy.blogspot.com/2016/02/vision-summit-2016-using-osvr-to.html
25 Jan: Got new or custom HMD? Need direct render, time warping, distortion
correction and game engine integration?
http://vrguy.blogspot.com/2016/01/got-new-hmd-need-direct-render-time.html


Execute disk attack on TurtleBot3

@ryanewel seems like we can close this issue?

I think the criteria for closing this one is to make a PR similar to https://github.com/aws-robotics/ROS2-SecTest/pull/17 for the disk attack


CSHTML: script tags with type text/template no longer hightlight HTML syntax

VSCode Version: 1.12.1
OS Version: Windows 10

Steps to Reproduce:

create .cshtml file
add script tag with type text/template
write HTML inside

EG:

This was working until the most recent update...

Duplicate of #25920 which we plan to fix in the next recovery build.


DeletedField errors in RelistFixedPriceItem call

I'm trying to delete the value of the location field of an item. In this call I'm sending a DeletedField of Item.Location to do this, but receive the error;
 [{"ShortMessage":"DeletedField tag is invalid.","LongMessage":"DeletedField tag name \"item.location\" is invalid. You must use a valid path in the form \"item.tag1[.tag2]\".","ErrorCode":"10201","SeverityCode":"Error","ErrorParameters":[{"Value":"item.location","ParamID":"0"}],"ErrorClassification":"RequestError"}]
Is it correct that the value is converted to lowercase? I've tried other values to delete the field including Location, location, item.location all which give the same error.

you should first try the ebay api test tool at the developer section to be 100% sure, that you are able to delete this special field. if that is working, you can compare the xml of the SDK to the XML you created in the tool to finde the difference.

@michabbb Thank you, trying it now, but still getting the same error, which appears to go against the docs! I think I'm sending the deletedfield name correctly, so will try it a bit more to be sure before I close this issue.

@ChangePlaces ebay docs are not always correct, i know ;-( but either you are not allowed to delete that field or your xml (you are building in the tool by hand) is wrong. in cases like this, my suggestion is: first create a working xml in that tool, so you can be 100% sure, it has nothing todo with the SDK. btw you get to know the ebay api better, because many things are hidden in a SDK ;) and if nothing is working, there is still the ebay premium support, they usually do a great job.

@michabbb I tried without deletefield (assuming I cannot just delete the field at this point) and just passed an empty string, and it still keeps the old value. I've tried an empty string with a space, but still the old value remains! It really is infuriating how sloppy the docs are now!
And unfortunately, $75 for one hour of premium support is a little step when you're just working on a project just for yourself!

@ChangePlaces don´t forget: investing 5 hours of debugging our time is (i´m sure) more expansive than 75$ for premium support. and if it turns out, it´s a bug, you won´t get charged. anyway, it´s up to you.
sorry if i cannot help any further.

The error may be an indication that you are not allowed to delete that field. I know from experience that eBay's API messages don't always explain what is wrong.


Amend Upload Script to hide pages

Currently when uploading a page to the app it doesn't hide the pages automatically, and users are expected to add the metadata about the page in before transcribing.
Change requested is that the script be amended to default to hiding the pages, allowing for a team member to input the metadata behind the scenes and then switch the page to visible for users to begin transcribing. The goal is to make the transcribing experience easier for users.
Copy of the script and changed script should be created and saved for documentation purposes.

@rsmithlal @mcagan
What is the status on this enhancement?

Should be fixed with the latest commit. @rsmithlal did we merge that to production?


Continuous Attachment

Is it possible to add a switch for "continuous attachment", that is, even after attaching to one client, it will continue to look for any newly launched clients to attach and patch?
I'm testing some things and this requires me to repeatedly close and open clients, and I don't want to keep having to launch kanan for each time I launch a client.
Thanks :)

This will only rerun the scripts on new instances of mabi if all previous instances are closed.

I was thinking of attaching to all new instances as they are launched without having to close others, but this works just as well, since I won't be multi-clienting. Thanks! :+1:

Yeah I plan on improving multi-client support soon!


Remove copy of source code from dist directory

I recently changed the dist build task to copy the source file to the dist directory, but this is really unnecessary so I want to revert this.

This change has now been committed to the develop branch and so it will be in the v1.2.1 release.


Fix quick_search_query logging

Fixes

Partially fixes https://github.com/Police-Data-Accessibility-Project/data-sources-app/issues/270 - "modify quick search logs -- store the airtable_uid of data sources as results, not a full package

Description

Replaces prior logging logic of quick_search_query logging with new method which inserts a list of the airtable_uids of results, rather than the whole package of results.
Additionally, this modifies the INSERT_LOG_QUERY to be paramaterized, rather than involve string insertion, reducing risk of sql injection

Testing

TODO

Performance

Marginal performance impact -- adding all ids of the results is an O(n) action, with n being the number of results.

Docs

No docs required

Wrong repository! Closing in favor of here.


Move downsample from tt_eager to ttnn

Ticket
9760
Problem description
Move downsample from tt_eager to ttnn
What's changed
Move downsample cpp implementation ttnn, pybindings to ttnn and make respective documentation changes
Checklist

[ ] Post commit CI passes
[ ] Model regression CI testing passes (if applicable)
[ ] New/Existing tests provide coverage for changes

Are you moving the tests on a separate PR?

The

Are you moving the tests on a separate PR?


Update composer.json

fixed php version. get minimal from README.md

hello, please write me on skype - oleg-linpax


Flatten CDM Mapping

@erichs @chasen-bettinger I'm not a fan of having string values that need additional parsing.
Have you seen my previous recommendations?
"assetOwner": "third-party",
"assetCategory": ["applications"],
"controlDomain": ["identify", "protect"]


[FABG-958] Adopt operations/system.go for new API

Fix & upgrade dependencies, fix statsd.SendLoop() usage.
FABG-958

@troyronda please pay attention to this pull request, SDK doesn't build without this fix.

@VadimInshakov
I'm having trouble seeing the change. Perhaps a rebase and squash would help.
Also looks like the integration tests failed.

@troyronda all checks have passed now. You can find my changes here:
https://github.com/hyperledger/fabric-sdk-go/pull/61/commits/a472a8ffa37329c44241938b5f714cd6450bc0a3
https://github.com/hyperledger/fabric-sdk-go/pull/61/commits/324bbbdc3226c5f1baf17edd06be8628187b551a
Thanks for your time.

This PR modifies upstream files from fabric. The way the upstream changes are managed is described in https://github.com/hyperledger/fabric-sdk-go/blob/master/scripts/third_party_pins/README.md. Basically, the idea is to keep maintaining two commits (one for the pull from upstream and one for any patching), otherwise it's very difficult to discern between upstream originals and our patches. Let me know if this is more then you want to learn, I can apply these changes for you.

@alikic sorry, it’s hard for me to understand how to do it right.

New PR created here: https://github.com/hyperledger/fabric-sdk-go/pull/65

Hey @alikic - I'm running in to issues with this, getting the following error:
# github.com/hyperledger/fabric-sdk-go/internal/github.com/hyperledger/fabric/core/operations
vendor/github.com/hyperledger/fabric-sdk-go/internal/github.com/hyperledger/fabric/core/operations/system.go:227:23: not enough arguments in call to s.statsd.SendLoop
        have (<-chan time.Time, string, string)
        want (context.Context, <-chan time.Time, string, string)

This is when using the Fabric GO SDK in a project with and API that's using Go-Kit. Is there any chance this PR can be merged. The key part is the line here: https://github.com/hyperledger/fabric-sdk-go/pull/61/files#diff-d9970f9b84f37d0a0d7b39806c899ee3R227
Thanks!

What release version is this fixed in?


torch.int64 and torch.int32 not quantizable?

Greetings,
I am attempting to quantize the torchvision.models.vit_b_16 model.
I am working on Vitis-AI 2.5, with torch==1.12.1 and torchvision==0.13.1+cpu.
When I attempt to quantize this model I get the following error -
vit_b_16_quantization_error.txt
I see the following warnings -
[VAIQ_WARN][QUANTIZER_TORCH_FLOAT_OP]: The quantizer recognize new op `nndct_expand` as a float operator by default.

[VAIQ_WARN][QUANTIZER_TORCH_FLOAT_OP]: The quantizer recognize new op `nndct_bmm` as a float operator by default.

[VAIQ_WARN][QUANTIZER_TORCH_FLOAT_OP]: The quantizer recognize new op `nndct_select` as a float operator by default.

[VAIQ_WARN][QUANTIZER_TORCH_FLOAT_OP]: The quantizer recognize new op `aten::div` as a float operator by default.

[VAIQ_NOTE]: =>Doing weights equalization...

[VAIQ_NOTE]: =>Quantizable module is generated.(quantize_result/VisionTransformer.py)

[VAIQ_NOTE]: =>Get module with quantization.
  0%|                                                                                | 0/100 [00:00<?, ?it/s]
[VAIQ_WARN][QUANTIZER_TORCH_TENSOR_TYPE_NOT_QUANTIZABLE]: The tensor type of VisionTransformer::VisionTransformer/12391 is torch.int64. Only support float32/double/float16 quantization.

[VAIQ_WARN][QUANTIZER_TORCH_TENSOR_TYPE_NOT_QUANTIZABLE]: The tensor type of VisionTransformer::VisionTransformer/Encoder[encoder]/Sequential[layers]/EncoderBlock[encoder_layer_0]/MultiheadAttention[self_attention]/14809 is torch.int64. Only support float32/double/float16 quantization.

[VAIQ_WARN][QUANTIZER_TORCH_TENSOR_TYPE_NOT_QUANTIZABLE]: The tensor type of VisionTransformer::VisionTransformer/Encoder[encoder]/Sequential[layers]/EncoderBlock[encoder_layer_0]/MultiheadAttention[self_attention]/14811 is torch.int64. Only support float32/double/float16 quantization.

[VAIQ_WARN][QUANTIZER_TORCH_TENSOR_TYPE_NOT_QUANTIZABLE]: The tensor type of VisionTransformer::VisionTransformer/Encoder[encoder]/Sequential[layers]/EncoderBlock[encoder_layer_0]/MultiheadAttention[self_attention]/14813 is torch.int64. Only support float32/double/float16 quantization.

[VAIQ_WARN][QUANTIZER_TORCH_TENSOR_TYPE_NOT_QUANTIZABLE]: The tensor type of VisionTransformer::VisionTransformer/Encoder[encoder]/Sequential[layers]/EncoderBlock[encoder_layer_0]/MultiheadAttention[self_attention]/12591 is torch.int32. Only support float32/double/float16 quantization.
....................................................................................................................................................................................................................................................................................................................................................

[VAIQ_WARN][QUANTIZER_TORCH_TENSOR_TYPE_NOT_QUANTIZABLE]: The tensor type of VisionTransformer::VisionTransformer/Encoder[encoder]/Sequential[layers]/EncoderBlock[encoder_layer_11]/MultiheadAttention[self_attention]/14725 is torch.int32. Only support float32/double/float16 quantization.
100%|█████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████| 100/100 [04:41<00:00,  2.82s/it]
loss: 3.23606
top-1 / top-5 accuracy: 51 / 70

[VAIQ_NOTE]: =>Exporting quant config.(quantize_result/quant_info.json)

[VAIQ_WARN][QUANTIZER_TORCH_TENSOR_NOT_QUANTIZED]: Node ouptut tensor is not quantized: VisionTransformer::VisionTransformer/12391 type: nndct_elemwise_mul

[VAIQ_WARN][QUANTIZER_TORCH_TENSOR_NOT_QUANTIZED]: Node ouptut tensor is not quantized: VisionTransformer::VisionTransformer/Encoder[encoder]/Sequential[layers]/EncoderBlock[encoder_layer_0]/MultiheadAttention[self_attention]/14809 type: nndct_elemwise_mul

[VAIQ_WARN][QUANTIZER_TORCH_TENSOR_NOT_QUANTIZED]: Node ouptut tensor is not quantized: VisionTransformer::VisionTransformer/Encoder[encoder]/Sequential[layers]/EncoderBlock[encoder_layer_0]/MultiheadAttention[self_attention]/14811 type: nndct_elemwise_mul

[VAIQ_WARN][QUANTIZER_TORCH_TENSOR_NOT_QUANTIZED]: Node ouptut tensor is not quantized: VisionTransformer::VisionTransformer/Encoder[encoder]/Sequential[layers]/EncoderBlock[encoder_layer_0]/MultiheadAttention[self_attention]/14813 type: nndct_elemwise_mul
....................................................................................................................................................................................................................................................................................................................................................

[VAIQ_WARN][QUANTIZER_TORCH_TENSOR_NOT_QUANTIZED]: Node ouptut tensor is not quantized: VisionTransformer::VisionTransformer/Encoder[encoder]/Sequential[layers]/EncoderBlock[encoder_layer_11]/MultiheadAttention[self_attention]/14725 type: nndct_elemwise_mul

[VAIQ_WARN][QUANTIZER_TORCH_TENSOR_NOT_QUANTIZED]: Parameter tensor is not quantized: VisionTransformer::encoder.pos_embedding. If this parameter is not a parameter embedded in torch operation, like weights of CONV, this kind of parameter will not be quantized. Please embed the parameter into CONV/Linear/BN.

[VAIQ_WARN][QUANTIZER_TORCH_TENSOR_NOT_QUANTIZED]: Some tensors are not quantized, please check their particularity.

....................................................................................................................................................................................................................................................................................................................................................

/opt/vitis_ai/conda/envs/vitis-ai-pytorch-neww/lib/python3.7/site-packages/pytorch_nndct/nn/modules/module_template.py:132: TracerWarning: torch.tensor results are registered as constants in the trace. You can safely ignore this warning if you use this function to create tensors out of constant variables that would be the same every time you call this function. In any other case, this might cause the trace to be incorrect.
  output = caller(*args, **kwargs)
/opt/vitis_ai/conda/envs/vitis-ai-pytorch-neww/lib/python3.7/site-packages/pytorch_nndct/quantization/torchquantizer.py:53: TracerWarning: Converting a tensor to a Python boolean might cause the trace to be incorrect. We can't record the data flow of Python values, so this value will be treated as a constant in the future. This means that the trace might not generalize to other inputs!
  if inf.sum() > 0 or nan.sum() > 0:
/opt/vitis_ai/conda/envs/vitis-ai-pytorch-neww/lib/python3.7/site-packages/pytorch_nndct/nn/modules/fix_ops.py:68: TracerWarning: Converting a tensor to a Python boolean might cause the trace to be incorrect. We can't record the data flow of Python values, so this value will be treated as a constant in the future. This means that the trace might not generalize to other inputs!
  tensor.storage().size() != tensor.numel()):
/opt/vitis_ai/conda/envs/vitis-ai-pytorch-neww/lib/python3.7/site-packages/pytorch_nndct/nn/modules/prim_ops.py:116: TracerWarning: Converting a tensor to a Python boolean might cause the trace to be incorrect. We can't record the data flow of Python values, so this value will be treated as a constant in the future. This means that the trace might not generalize to other inputs!
  if not (list(self.node.out_tensors[0].shape[1:]) == list(input.size())[1:]):
/opt/vitis_ai/conda/envs/vitis-ai-pytorch-neww/lib/python3.7/site-packages/pytorch_nndct/nn/modules/module_template.py:132: UserWarning: To copy construct from a tensor, it is recommended to use sourceTensor.clone().detach() or sourceTensor.clone().detach().requires_grad_(True), rather than torch.tensor(sourceTensor).
  output = caller(*args, **kwargs)
/opt/vitis_ai/conda/envs/vitis-ai-pytorch-neww/lib/python3.7/site-packages/pytorch_nndct/nn/modules/prim_ops.py:51: TracerWarning: Converting a tensor to a Python integer might cause the trace to be incorrect. We can't record the data flow of Python values, so this value will be treated as a constant in the future. This means that the trace might not generalize to other inputs!
  output = int(input)

[VAIQ_NOTE]: VisionTransformer_int.onnx is generated.(quantize_result/VisionTransformer_int.onnx)

[VAIQ_NOTE]: =>Converting to xmodel ...

[VAIQ_WARN]: VisionTransformer::12350 is not tensor.

[VAIQ_WARN]: VisionTransformer::12357 is not tensor.

[VAIQ_WARN]: VisionTransformer::12360 is not tensor.

[VAIQ_WARN]: VisionTransformer::12392 is not tensor.

[VAIQ_WARN]: VisionTransformer::12402 is not tensor.
....................................................................................................................................................................................................................................................................................................................................................

[VAIQ_WARN]: VisionTransformer::14731 is not tensor.

[VAIQ_WARN][QUANTIZER_TORCH_CONVERT_XMODEL]: Convert 'VisionTransformer' to xmodel failed with following reasons:
XIR don't support multi-outputs op.(VisionTransformer::VisionTransformer/Encoder[encoder]/Sequential[layers]/EncoderBlock[encoder_layer_0]/MultiheadAttention[self_attention]/14805, nndct_chunk)
XIR don't support multi-outputs op.(VisionTransformer::VisionTransformer/Encoder[encoder]/Sequential[layers]/EncoderBlock[encoder_layer_1]/MultiheadAttention[self_attention]/14816, nndct_chunk)
XIR don't support multi-outputs op.(VisionTransformer::VisionTransformer/Encoder[encoder]/Sequential[layers]/EncoderBlock[encoder_layer_2]/MultiheadAttention[self_attention]/14827, nndct_chunk)
XIR don't support multi-outputs op.(VisionTransformer::VisionTransformer/Encoder[encoder]/Sequential[layers]/EncoderBlock[encoder_layer_3]/MultiheadAttention[self_attention]/14838, nndct_chunk)
XIR don't support multi-outputs op.(VisionTransformer::VisionTransformer/Encoder[encoder]/Sequential[layers]/EncoderBlock[encoder_layer_4]/MultiheadAttention[self_attention]/14849, nndct_chunk)
XIR don't support multi-outputs op.(VisionTransformer::VisionTransformer/Encoder[encoder]/Sequential[layers]/EncoderBlock[encoder_layer_5]/MultiheadAttention[self_attention]/14860, nndct_chunk)
XIR don't support multi-outputs op.(VisionTransformer::VisionTransformer/Encoder[encoder]/Sequential[layers]/EncoderBlock[encoder_layer_6]/MultiheadAttention[self_attention]/14871, nndct_chunk)
XIR don't support multi-outputs op.(VisionTransformer::VisionTransformer/Encoder[encoder]/Sequential[layers]/EncoderBlock[encoder_layer_7]/MultiheadAttention[self_attention]/14882, nndct_chunk)
XIR don't support multi-outputs op.(VisionTransformer::VisionTransformer/Encoder[encoder]/Sequential[layers]/EncoderBlock[encoder_layer_8]/MultiheadAttention[self_attention]/14893, nndct_chunk)
XIR don't support multi-outputs op.(VisionTransformer::VisionTransformer/Encoder[encoder]/Sequential[layers]/EncoderBlock[encoder_layer_9]/MultiheadAttention[self_attention]/14904, nndct_chunk)
XIR don't support multi-outputs op.(VisionTransformer::VisionTransformer/Encoder[encoder]/Sequential[layers]/EncoderBlock[encoder_layer_10]/MultiheadAttention[self_attention]/14915, nndct_chunk)
XIR don't support multi-outputs op.(VisionTransformer::VisionTransformer/Encoder[encoder]/Sequential[layers]/EncoderBlock[encoder_layer_11]/MultiheadAttention[self_attention]/14926, nndct_chunk)

-------- End of vit_b_16 test
**************************************************
* VITIS_AI Compilation - Xilinx Inc.
**************************************************
[UNILOG][FATAL][XCOM_FILE_NOT_EXISTS][The file is not exists] "/workspace/src/Vitis-AI-Quantizer/vai_q_pytorch/example/vit_b_16/quantize_result/*.xmodel" doesn't exist.
*** Check failure stack trace: ***
This program has crashed!
Aborted (core dumped)

Please advise how to workaround this? or how to offload parts of this to the CPU?

Hi. Quantization of torch.int64 and torch.int32 is not supported yet. We only support float32/double/float16 quantization. Your error is beacause XIR does not support multi-outputs op. You can use QuantStub() and DeQuantStub() in your model to offload parts of this to the CPU.(You can see more details in README.md

Hi @Alexiazzf,
Thank you for your response and the suggestion. Can you please help me understand how to add the QuantStub() and DeQuantStub() to pretrained model? for example: I am working with the pretrained model from the torchvision module :
from pytorch_nndct.apis import torch_quantizer
import torch
import torchvision
from torchvision.models import vit_b_16
model = vit_b_16(weights='IMAGENET1K_V1').cpu()

How do I add QuantStub() and DeQuantStub() function here?
Any help would be greatly appreciated!

Hi @anirudhitagi ,
You could add QuantStub() and DeQuantStub() into your vit_b_16 model. You can find our example in  https://github.com/Xilinx/Vitis-AI/blob/master/src/vai_quantizer/vai_q_pytorch/example/resnet18_qat.py#L251. And you can see the instruction in README.md which can answer your questions exactly.

Hi @Alexiazzf ,
sorry to follow up regarding the same doubt, but I am struggling to add QuantStub() and DeQuantStub() functions in the vit_b_16 model.
In the example that you have shared above, it looks like first the entire resnet model is coded manually and then the QuantStub() and DeQuantStub() functions are inserted. is there another way to insert these functions directly into the vit_b_16 model?

Hi @anirudhitagi ,
We only support insert QuantStub() and DeQuantStub() manually into the model. If you do not add QuantStub() and DeQuantStub(), you will quantize the whole model.

Hi. Quantization of torch.int64 and torch.int32 is not supported yet. We only support float32/double/float16 quantization. Your error is beacause XIR does not support multi-outputs op. You can use QuantStub() and DeQuantStub() in your model to offload parts of this to the CPU.(You can see more details in README.md

Hey,
I use vitis-ai-pytorch to quantize my model, and the below warning appears:
"[VAIQ_WARN]: The tensor type of  Model::input_0 is torch.float16. Only support float32/double quantization."
My Vitis AI version is VitisAI2.5 GPU. Is the GPU version dose not support float16 quantization?
Then I print the "dtype" of the model, and it shows "torch.float32". Can this proves that the precision of the model is float32? If not, would you mind tell me how can I judge the accuracy of my model?
Thx~


Background on toffeescript?

I asked about toffeescript on the nodejs mailing list.  It looks very interesting and useful to me.  Can I ask a few questions?
Have you tested it much?
Does it include any test code for your new features?
Have you used it in any production code?
If I get the time I might help by writing some test code.  This way I could learn how to use it and help you.

Have you tested it much?
Does it include any test code for your new features?

Yes, the related test cases are at
test/async.coffee
test/symbols.coffee
test/regexps-plus.coffee

Have you used it in any production code?

Yes, I'm using it in my own production, Actually I've used it instead of CoffeeScript totally.
Thank you, Any improvement or idea on toffeescript are welcome.


Decide which properties should be reflected

It seems likely that at least some of the properties of the MWC components should be reflected to attributes.
Most likely candidates are boolean properties like disabled.
Least likely candidates are stringy properties like value.

Internally we've been using a modified version of mwc-textfield. Here are the properties thus far we've reflected:
      outlined: { type: Boolean, reflect: true },
      disabled: { type: Boolean, reflect: true },
      required: { type: Boolean, reflect: true },
      type: { type: String, reflect: true },
      pattern: { type: String, reflect: true },
      maxlength: { type: Number, reflect: true },
      min: { type: Number, reflect: true },
      max: { type: Number, reflect: true },
      touched: { type: Boolean, reflect: true },


One default target (redux)

Same as #534 but now it doesn't crash when viewing source code.
r? @pietroalbini

There are merge conflicts.

...and it'd be nice to add tests, at least for the web part.

There are merge conflicts.
Yeah ... I tried to rebase, but it didn't work very well, I think because of the commit to master reverting the earlier changes. I'll fix the conflicts (again) once I've written some tests, probably tomorrow.

So ... I can add tests for the web changes once #553 is merged (it has the .file() addition to FakeReleases). However, we don't currently have a way to test the build step works properly and generates all the static files it should. I might spend some time adding a FakeBuild tomorrow, but my schedule is about to get busy again so I may not finish.

However, we don't currently have a way to test the build step works properly and generates all the static files it should. I might spend some time adding a FakeBuild tomorrow, but my schedule is about to get busy again so I may not finish.

I'd not handle builds along with other tests in the codebase, but I'd do something separate (like rustwide's buildtest or crater's minicrater). My worry with adding built tests along with the other tests is that it encourages using a "fake build" around the codebase tests: builds are inheritely slow, as the rustwide initialization can't be parallelized, so we want to have as few of them as possible.


differance between orders wrt original direction

##feature request##
you can differentiate between buy trade and sell trade like below
'''buy trade'''
buy / sell
'''sell trade'''
short / cover

An order is an independent entity and closely resembles an order at the exchange with extra information. Covering an order requires broker positions to determine the side.
To cover your orders manually, use the following broker methods

close_all_positions
cover_orders

To automatically cover orders, use orders in the stop module
To extend custom functionality, sub class CompoundOrder


Changed the nominal name

Notes on the PR title:

The PR title is not representative of the change you are introducing, but of the correction I indicated in your previous PR (which was never merged). It should be adapted.

Notes on the PR description:

The PR descriptioun should describe the changes that you are introducing, and perhaps even adding a specific reference to the issue that you want to close. Something like " Fixes #57 ".

Notes on the commit messages:

as noted in the Contributing Guidelines, commit messages should follow the Conventional Commits style.
To fix that, you can use git rebase -i (git rebase interactive), and then git push --force-with-lease origin your-branch-name to change the commits in the remote version of your repository.

Notes on commit signatures:

As noted in the contributing guidelines, commits should be cryptographically signed.

Notes on the branch "history":

Ideally, it should minimise the number of commits that it containes. You can fix that by squashing commits together with git rebase -i.


Change groupId to io.quarkiverse.fx

See https://hub.quarkiverse.io/#projects-maven-artifact-groupids

@all-contributors add @CodeSimcoe for code and maintenance

Done


[RFP] uget-integrator

Issue description
uget-integrator - https://github.com/ugetdm/uget-integrator
Allows for the uget browser plugin to work with chrome and firefox.

It's in master since a7ce93955d9.


Request body while Creating new Mock

Hi, I want to CreatE new mock (not from logged requests), how can I do this?
Did find this feature...

Hi, to create a mock you can click create mock on top left, its the 3rd actionable button from the left. Let me know if it works.

Yep, but how can I add Request body to my POST request?

I see only RESPONSE body when Creating new Mock

Here is example

You can't add the request body here, API calls are mocked on the basis of URL only, everything else is ignored as of now and there is no plan to use query parmas or body for matching as they same as are params to a function call.
Later on, with the Mokku dashboard, you can provide a function for any URL where you will get the passed body as param there you can perform any operation and return back just like Express framework.
Why do want to add a body? different mocks according to the body?

I want to intercept request and cause of this my only way is to send this request via UI (click button for example), than go to Logs section and find this request and click Mock.
And next time when I click this button I can intercept request.
Am I right?

Or Mokku is designed to Mock only Response?

Yes, it is designed to mock response only ( and headers), you can assume it as a server running in Chrome.  In logs, you can see the body, query params because they are fetched from the current request to help the user, those are not saved with mocks.


[Feature Request] LoRA(Low-Rank Adaptation of Large Language Models) Support

See:
https://huggingface.co/blog/lora
https://github.com/AUTOMATIC1111/stable-diffusion-webui/commit/855b9e3d1c5a1bd8c2d815d38a38bc7c410be5a8

+1

https://github.com/liuliu/swift-diffusion/blob/main/examples/lora/main.swift
https://github.com/liuliu/swift-diffusion/blob/main/examples/txt2img/main.swift#L193


CI: fix CodeQL test

see https://github.com/github/codeql/issues/15647

I'd rather wait CodeQL to fix this than hardcode .0 in the go.mod file.

I'd rather wait CodeQL to fix this than hardcode .0 in the go.mod file.

I understand you point, but keeping the CI tests red is way worse IMO.
We have too many tests failing on new PRs, trying to ignore this drives me crazy 🙀

Merging as per discussion, we will revert the commit once codeql workflow is fixed for golang 1.22


[WebToolsE2E][Aspire][MacOS][Unstable]Debugging Aspire project using "dotnet watch", Safari browser page displays the error "Can't connect to the server" and manually refresh the browser can display the correct page.

INSTALL STEPS

Clean machine: MacOS Sonoma(14.1) on Intel machine
Install latest 8.0 SDK: 8.0.100(latest-released-build)
Apply NuGet Feeds
Install the latest VS Code from: Download Visual Studio Code - Mac, Linux, Windows
Download the latest released C# Dev Kit from: C# Dev Kit - Visual Studio Marketplace
Open Terminal and run commands below to install aspire workload

sudo dotnet workload update --skip-sign-check --interactive --source https://pkgs.dev.azure.com/dnceng/public/_packaging/dotnet8/nuget/v3/index.json

sudo dotnet workload install aspire --skip-sign-check --interactive --source https://pkgs.dev.azure.com/dnceng/public/_packaging/dotnet8/nuget/v3/index.json

REPRO STEPS

Open VS Code, click Extension button > Install from VSIX… > select the downloaded "Green" file > Install.
Type 'Command+Shift+P' to open Command Palette > .NET: New Project > click .NET Aspire Application to create a new project
Right-click the project > Build
Right-click the aspire.AppHost project > Open in Integrated Terminal > dotnet watch.

NOTE:

This issue may occur during the second or third time using dotnet watch to debug the project, I have tried many times, but the first debugging project rarely replicates this bug, so I added the unstable tag.
Using Edge browser displays the error "Can't reach this page", but the Edge browser can automatically refresh to the correct page.

ACTUAL
The Safari browser page displays the error "Can't connect to the server", then manually refresh the browser multiple times can display the correct page.

EXPECTED:
The Safari browser can automatically refresh to the correct page.

Verify this issue using aspire 8.0 preview 1, the third time using dotnet watch to debug the project can meet the bug, added the REGRESSION INFO as Unintentional (bug).

This seems like it could be a timing issue in that the browser gets launched by dotnet watch but for some reason the endpoint the dashboard is on can't serve a response yet. Chrome and Edge will automatically retry connecting to the server if the first request fails to connect (e.g. DNS or TCP connection issue) but Safari might not.
@davidfowl could this be related to the decoupling of the dashboard from Aspire.Hosting? How is the "Now listening on.." message printed to the console coordinated to ensure it only happens once the server is running in the new design?

Currently dashboard starts after calls to start projects/containers. I think purpose of current way was to make sure things are starting to run when we show dashboard rather than empty dashboard. Perhaps dotnet watch could launch browser after "Now listening on.." appears.

Perhaps dotnet watch could launch browser after "Now listening on.." appears.

I'm pretty sure that's what it does already as that logic is in dotnet watch itself (it sniffs console output for a known message).

@lemon0213 @v-cazhang this seems to be a 'dotnet watch' scenario on macOS. Does this issue still reproduce using Aspire 8.0 P2? How about when using latest Aspire 8.0 P3 builds?

@balachir Verified today, this issue does not repro on Aspire 8.0 P2, but it still repro using latest Aspire 8.0 P3 builds (8.0.0-preview.3.24072.7).

@kvenkatrajan should this be in P5, P6, or postponed?

@adamint can you try reproing this in safari please?

@kvenkatrajan the issue (can't reach this page) appears in all browsers, and the specific safari behavior is reproducible

Blocked on above linked sdk issue

@adamint , On Mac OS aspire preview 5 [8.0.0-preview.5.24201.12] + .NET 8.0.204 SDK(latest-released-build) with safari version 17.4.1 (196<IP_ADDRESS>.14), this issue is not repro with 'dotnet watch' / 'dotnet run -lp http/https'.
But it repro every time on safari with 'Ctrl + Shift + P' > Debug: Select and Start Debugging > C#: xxx.AppHost [https/http].
(Manually refresh the browser can display the correct page, Chrome and Edge not repro.)

@kvenkatrajan will take a look to see if there is something to fix for 8.1 and to check if this still repros.

This issue does reproduce with dotnet watch, all browsers. Also reproduces in VSCode with the above steps

@kvenkatrajan is there anything to fix for 9.0 here?

@kvenkatrajan is there anything to fix for 9.0 here?

There is not, the linked sdk issue is still active.

dotnet watch is being re-designed to work with aspire. That work is happening in 9.0.200 SDK which is not shipping with .NET 9. This has been fixed in that branch.
You can see the work items for watch and aspire here https://github.com/dotnet/sdk/issues?q=is%3Aissue label%3AAspire


Feature: Ability to save regex Find/Replace patterns for future use

Feature Request

VSCode Version:
Version 1.4.0 (1.4.0)
OS Version:
OS X El Capitan 10.11.6 (15G31)

Steps to Reproduce:

Open a text document in vscode with a fair amount of text.
Launch the Find/Replace dialogue "Command + F"
Click the regex icon to enter a regex pattern for the find and replace forms.
Observe there is no means from that dialogue to save the regex pattern or reference previously used regex patterns.

Expected Behavior:

The Find/Replace dialogue would provide a means of saving regex patterns used for future use. Please see attached screen shots of the method BBEdit uses to accomplish this as an example of this feature.

Duplicates #5865


build-osuosl-aix71-ppc64-1: tests which specify -Xgc:metronome fail (openj9 option)

Tests which use the openj9 command line option -Xgc:metronome fail when run on build-osuosl-aix71-ppc64-1 but pass when run on test-ibm-aix71-ppc64-2.
The symptoms are the same as those described in https://github.com/eclipse/openj9/issues/10579, where the underlying reason was said to be "AIX machine is not configured for High Resolution Clock to support Metronome".

The issues discussed in the note above have been addressed in the AIX playbook. Apparently the changes were never applied manually to the osuosl systems and/or the playbooks were not re-run to update user settings.

The issues discussed in the note above have been addressed in the AIX playbook. Apparently the changes were never applied manually to the osuosl systems and/or the playbooks were not re-run to update user settings.

@aixtools Safe to close this now in that case?

@aixtools Safe to close this now in that case?

@lumpfish Are you able to verify whether this now works? It's clear from this issue which test showed the problem

@lumpfish Are you able to verify whether this now works? It's clear from this issue which test showed the problem

Likewise, as I mentioned in #1816 (read asked) the possibility of just rebuilding build-osuosl-aix71-ppc64-1, and perhaps later build-osuosl-aix71-ppc64-2 - rather than trying to dig in a system that has been manually adjusted several times. Especially if test-osuosl-aix71-ppc64-1 seems to be working correctly - which was recently built using the latest playbook(s).

Likewise, as I mentioned in #1816 (read asked) the possibility of just rebuilding build-osuosl-aix71-ppc64-1, and perhaps later build-osuosl-aix71-ppc64-2 - rather than trying to dig in a system that has been manually adjusted several times. Especially if test-osuosl-aix71-ppc64-1 seems to be working correctly - which was recently built using the latest playbook(s).

The tests still fail when run on build-osuosl-aix71-ppc64-1: https://ci.adoptopenjdk.net/view/Test_grinder/job/Grinder/6081/consoleFull
This will rerun on of the tests affected:  https://ci.adoptopenjdk.net/job/Grinder/parambuild/?JDK_VERSION=8&JDK_IMPL=openj9&JDK_VENDOR=adoptopenjdk&BUILD_LIST=functional&PLATFORM=ppc64_aix&TARGET=cmdLineTester_jvmtitests_5

The tests still fail when run on build-osuosl-aix71-ppc64-1: https://ci.adoptopenjdk.net/view/Test_grinder/job/Grinder/6081/consoleFull
This will rerun on of the tests affected:  https://ci.adoptopenjdk.net/job/Grinder/parambuild/?JDK_VERSION=8&JDK_IMPL=openj9&JDK_VENDOR=adoptopenjdk&BUILD_LIST=functional&PLATFORM=ppc64_aix&TARGET=cmdLineTester_jvmtitests_5

I looked at the changes listed in https://github.com/eclipse/openj9/issues/10579#issuecomment-742627758 - and I had already added the capabilities to jenkins.
What I notice is still different - root was not the administrator of the group staff (should not influence capabilities), but the shell is still ksh and not bash.
Further, while /home/jenkins/.profile does not exist - there is nothing (simple) to find to describe what variables are being set by /etc/environment and/or /etc/profile.
for the record:
# lsuser -a capabilities fsize  cpu rss stack nofiles jenkins
jenkins capabilities=CAP_NUMA_ATTACH,CAP_BYPASS_RAC_VMM,CAP_PROPAGATE fsize=-1 cpu=-1 rss=65536 stack=65536 nofiles=2000

I looked at the changes listed in https://github.com/eclipse/openj9/issues/10579#issuecomment-742627758 - and I had already added the capabilities to jenkins.
What I notice is still different - root was not the administrator of the group staff (should not influence capabilities), but the shell is still ksh and not bash.
Further, while /home/jenkins/.profile does not exist - there is nothing (simple) to find to describe what variables are being set by /etc/environment and/or /etc/profile.
for the record:
# lsuser -a capabilities fsize  cpu rss stack nofiles jenkins
jenkins capabilities=CAP_NUMA_ATTACH,CAP_BYPASS_RAC_VMM,CAP_PROPAGATE fsize=-1 cpu=-1 rss=65536 stack=65536 nofiles=2000

I found something - thx Adam for your assistance!
There is an RBAC privilege associated using the realtime clock (PV_PROC_RTCLK) - and my guess is that AIX 7.1 TL5 and later use the CAP_* capabilities to activate that.
What needs to be verified now is if the changes I made to build-osuosl-aix71-ppc64-1 fix the test issue. If so, I'll open a PR and make an addition to the playbooks - specific for AIX 7.1 TL4 (if TL5 is working using the capabilities attribute).

I found something - thx Adam for your assistance!
There is an RBAC privilege associated using the realtime clock (PV_PROC_RTCLK) - and my guess is that AIX 7.1 TL5 and later use the CAP_* capabilities to activate that.
What needs to be verified now is if the changes I made to build-osuosl-aix71-ppc64-1 fix the test issue. If so, I'll open a PR and make an addition to the playbooks - specific for AIX 7.1 TL4 (if TL5 is working using the capabilities attribute).

Verified in several grinder jobs - the metronome setting is fixed with some additional RBAC settings. I'll make an additional role (rbac) for AIX so that this is fixed in AIX 7.1 TL4 systems.
It seems the CAP_* capabilities provide the kernel privilege in a different way.
a) This could be closed - as fixed aka fix known - or
b) wait for the PR to be merged (but that may take a lot longer).

Verified in several grinder jobs - the metronome setting is fixed with some additional RBAC settings. I'll make an additional role (rbac) for AIX so that this is fixed in AIX 7.1 TL4 systems.
It seems the CAP_* capabilities provide the kernel privilege in a different way.
a) This could be closed - as fixed aka fix known - or
b) wait for the PR to be merged (but that may take a lot longer).

As far as running the test goes - this can be closed. -Xgcpolicy:metronome works on both build-osuosl-aix71-ppc-{1,2} systems. See https://ci.adoptopenjdk.net/job/Grinder/6233/console (build-2) and https://ci.adoptopenjdk.net/job/Grinder/6202/console (build-1)

@lumpfish Was the ci.role.test label removed from this machine? While this now seems to be resolved I'm curious as to what it was that flagged up this issue given that the tests aren't currently able to be selected for that machine (May be that it was discussed/mentioned elsewhere but I'm just looking at this issue for now)

As I recall the role was removed from the machine before the Jan 2021 release runs because there were a number of known issues on that machine which might cause tests to fail.

OK I've added the label back onto build-osuosl-aix71-ppc64-2 again to increase capacity - I prefer to keep one dedicated build system but happy to share the second with test for now. That explains why AIX has been a limiting factor in terms of general testing capacity recently.


Default / 0 values for Y axis on every tick on X

My apologies for asking it here. I did ask on stackoverflow but no luck. Any help would be greatly appreciated.
http://stackoverflow.com/questions/39547512/default-0-value-for-missing-data

I would like missing Y values to default to 0 without me explicitly submitting the value as 0.
On the screenshot the data what is in the table was plotted onto the chart.
It is displayed in green. The red is what I would like to achieve. Notice how I have only got data for 7 days.
Is there any way that I can achieve this? In someway I would have expected this to be the default behaviour ... so it might just be an option I can not find in the docs.
The code is similar to this one:
reportChart = new Chart(reportChartElement, {
                type: 'line',
                data: data,
                options: {
                    spanGaps: true,
                    scales: {
                        xAxes: [{
                            ticks: {
                                //autoSkip:true,
                            },
                            type: 'time',
                            time: {
                                unit: 'day',
                                displayFormats: {

                                }
                            }
                        }],
                        yAxes: [{
                            ticks: {
                                min: 0,
                                stepSize: 1
                            }
                        }]
                    }
                }

            });

Do you have a jsfiddle that reproduces this issue?

Hey :)
I didn't see much point of creating a js fiddle for this ... I think you get it anyway.
Is there anyway I could modify this designed behaviour by overriding some of the functions ?
Thank you for your help!
If not possible it would be a great feature.
------ more explanation if needed ------
Take a look at the any of the dates on the x axis which I have not got submitted data for for example Jun 6.
The green graph shows the "wrong info" It suggest that on Jun 6 there was some units yet there was nothing.
I have to submit 0 as a value for every single date in the graph to get the red line showing (which I have just drawn in Photoshop).
This is a pain :) because that is not how naturally comes out of mysql for example.
If you do something like
SELECT
COUNT(order_items.id) AS 'number_of_units',
DATE(orders.order_date) AS 'order_date'
FROM
orders
LEFT JOIN
order_items ON orders.id = order_items.order_id
DATE(order_date) >= '2016-08-01'
AND
DATE(order_date) <= '2016-08-31'
GROUP BY DATE(order_date)
ORDER BY number_of_units DESC
If you have no data for a one particular day that date will not be in the result. So I have to somehow bodge 0 values to display on the graph ...

@turigeza could you post what your data looks like?
I think I have an idea of how to make this work. If you specify your data like the following it might work the way you want
data: {
  datasets: [{
    data: [{
      x: x value,
      y: y value
    }, {
      x:,
      y:
    }]
  }]
}

You were right i should have started with a js fiddle :) The data looks just like you did there ...
Here is the link for an example:
https://jsfiddle.net/gezaatturigezacom/m3fpaeu4/
I would like the red line to behave like the green one. Aka default to 0 on the date 2016-02-03 without me having to supply the data for that date.

That's going to take some work to support. it might be easier to simply add the 0s into the data.

Thank you for your help ... I will modify the data so it contains default values for each date now.
I was hoping there might an already existing option or some way of tapping into a function which gets called on every x value but after that I realised you are possibly drawing the points in the order I give you the data and not in order of x.
It is worth mentioning in this case I have to recreate the same logic as the  time scale on the xAxis does aka generate unique dates for every day.
Anyway I go and do it :)) Thank you again taking you time :)

Yup, the points are drawn in the order given to allow for charts that loop back.
It is annoying to have to do all the date work. I will keep this issue open for any future work we may do on it

I have exactly the same problem. I think this is a really common problem for time-based charts. May it be clicks/sells/.. which are stored/aggregated in a database like
2016-11-11: 5
2016-11-16: 3
2016-11-17: 4
And it is very annoying to fill the missing dates to zero after retrieving. If the data is very sparse, then there is also some memory overhead created, or if the gaps are generated on server-side also network traffic is increased.

I have written a workaround plugin:
var fillScatteredTimeScaleDataPlugin = {
beforeUpdate: function(c) {
var timeAxis = c.options.scales.xAxes[0].time;
if (!timeAxis || !timeAxis.fillGapsWithZero) return;
for (var i=0;i<c.data.datasets.length;i++){
var set = c.data.datasets[i];
var min, max, hash = {};
for (var j=0;j<set.data.length;j++){
var val = moment(set.data[j].x, timeAxis.parser);
if (!min || min.diff(val)>0)
min = val;
if (!max || max.diff(val)<0)
max = val;
hash[set.data[j].x] = 1;
}
for (var val = min; max.diff(val)>0; val.add(1, timeAxis.minUnit)){
var d = val.format(timeAxis.parser);
if (!hash[d])
set.data.push({x:d, y:0});
}
set.data.sort(function(a,b){
return a.x < b.x?-1:1;
});
}
}
}
Chart.pluginService.register(fillScatteredTimeScaleDataPlugin);
Usage:

for the timeAxis use the option "fillGapsWithZero: true"
set a reasonable "minUnit" (e.g. "day")
set x values as strings and set a parser-format

Wow that was fast : ) I thought I might post the solution I had but there is no point now : D

@cyberbeat , I'm trying to use your plugin, but on page load getting an error that moment is not defined. This is with Chart.bundle.js v2.6.0. Any advice?

I don't use the bundle, but include chartjs and moment separatly.

Yes, I had to include moment separately. Seems like your plugin must only work for an older version of Chart.js, no? It's not OK for multiple datasets, but I had to do this:
`var fillGapsWithZeroPlugin = {
beforeUpdate: function(c) {
var timeAxis = c.options.scales.xAxes[0].time;
if( ! timeAxis || ! timeAxis.fillGapsWithZero ) return;
var min, max, newLabels = [], newData = [], assoc = {};
var dates = c.data.labels;
for( var i = 0; i < dates.length; i++ ){
var val = moment( dates[i] );
if( ! min || min.diff( val ) > 0 )
min = val;
if( ! max || max.diff( val ) < 0 )
max = val;
assoc[ val.format( timeAxis.parser ) ] = c.data.datasets[0].data[i];
}
for( var d = min; max.diff( d ) > 0; d.add( 1, timeAxis.minUnit ) ){
var cur = d.format( timeAxis.parser );
newLabels.push(cur);
if( ! assoc[cur] ){
newData.push(0);
}else{
newData.push( assoc[cur] );
}
}
c.data.labels = newLabels;
c.data.datasets[0].data = newData;
return;
}
}
Chart.pluginService.register(fillGapsWithZeroPlugin);
`

Any updates on this? I have the same problem.

+1 would like this feature


Run as Trusted Installer on system startup

Description of the feature, modification, idea or suggestion
I would be happy if System Informer could start up automatically as trusted installer on user log on.
This could co-exist with current Enable Run As Admin flag in settings.
Proposed implementation details (optional)
No response

The TrustedInstaller service is created in session 0 while the current user is session +1 and creating cross-session processes requires modifying the window station and desktop security granting Everyone access. System Informer currently requires user interaction before making changes to the desktop security descriptor making it incompatible to launch as TrustedInstaller after startup.
If you need to start applications with TI at startup then dedicated software like NSudo/NanaRun is better at creating systeminformer.exe with TrustedInstaller (they change the security descriptors automatically without user interaction) 👍
https://github.com/M2TeamArchived/NSudo/
https://github.com/M2Team/NanaRun

Thank you very much!


HHH-15090 Access to public field with extended bytecode enhancement returns null for entity lazy-loaded from polymorphic toOne association

https://hibernate.atlassian.net/browse/HHH-15090

Merged, thanks


Improvement string injecting and text creation

Hi, recently i using AutoFixture and think that's fantastic!
I have an idea for improve default string creation, by inspiring from this extension for visual studio we can create dummy text.So code can be something like this:
var fixture = new Fixture();
fixture.InjectDummyString(vocabulary: Vocabulary.LoremIpsum, wordCount: 10);
// Or maybe
//fixture.InjectDummyString(vocabulary: Vocabulary.ChildeHarold, wordCount: 5, startWord: 5);
var dummyText = fixture.Create<string>();

I know we can use fixture.Customizations.Add(new DummyTextBuilder()); or something like this but i think string data are high usage and AutoFixture native string builder (using hashing) are meaningless and ugly but in this way is more structured.
Thank you.

Thank you for firing the issue and sharing your idea.
To be honest, I don't see how "Lorem Ipsum.." string is better than the Guid we currently generate. The benefit from Guid is that each string is unique and your tests have additional guards. With Lorem Ipsum strings will not be so unique, so it could lead to false positive/negative in unexpected places.
public class Sut
{
	public Sut(string prop1, string prop2)
	{
		Prop1 = prop1;
		Prop2 = prop2;
	}

	public string Prop1 { get; }
	public string Prop2 { get; }
}

public class Tests
{
	[Fact]
	public void SutTest()
	{
		var fixture = new Fixture();
		var str1 = fixture.Create<string>();
		var str2 = fixture.Create<string>();

		var sut = new Sut(str1, str2);

		Assert.Equal(sut.Prop1, sut.Prop2);
	}
}

If your string generator produced not random enough string, the tests like above could pass, even if that is false positive.
Therefore, I'd vote to not change the current generation algorithm to not break the existing solutions and keep tests trustworthy.
@moodmosaic @adamchester Would appreciate if you could also share your opinion.

@JaWiD2, thank you for bringing this extension to our attention 👍
Yes, it's possible to replace each and every internal builder with a custom one, e.g. as shown here, or using extension method(s) like the InjectDummyString one, as shown by @JaWiD2 proposes.
Other than that, there are no plans to integrate any of these in AutoFixture itself; the existing ones, and the various Customization APIs, have been battle tested for 7+ years.


Upgrade react-native-svg to 13.4.0

Discussed in slack starting here
Details
Upgrades react-native-svg to latest to support Fabric
Fixed Issues
$ (partial) https://github.com/Expensify/App/issues/8503
Tests / QA Steps

Run the app
Make sure icons and default avatars render correctly throughout the app. (note that avatars aren't cached offline correctly, but that's a separate known issue)

[ ] Verify that no errors appear in the JS console

PR Review Checklist
PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] iOS / native
[x] Android / native
[x] iOS / Safari
[x] Android / Chrome
[x] MacOS / Chrome
[x] MacOS / Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product was added in all src/languages/* files
[x] I verified any copy / text that was added to the app is correct English and approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)

[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

PR Reviewer Checklist
The reviewer will copy/paste it into a new comment and complete it after the author checklist is completed

[x] I have verified the author checklist is complete (all boxes are checked off).
[x] I verified the correct issue is linked in the ### Fixed Issues section above
[x] I verified testing steps are clear and they cover the changes made in this PR

[x] I verified the steps for local testing are in the Tests section
[x] I verified the steps for Staging and/or Production testing are in the QA steps section
[x] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[x] I checked that screenshots or videos are included for tests on all platforms
[x] I included screenshots or videos for tests on all platforms
[x] I verified tests pass on all platforms & I tested again on:

[x] iOS / native
[x] Android / native
[x] iOS / Safari
[x] Android / Chrome
[x] MacOS / Chrome
[x] MacOS / Desktop

[x] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
[x] I verified proper code patterns were followed (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product was added in all src/languages/* files
[x] I verified any copy / text that was added to the app is correct English and approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I verified that this PR follows the guidelines as stated in the Review Guidelines
[x] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)

[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots
Web

Mobile Web - Chrome

Mobile Web - Safari

Desktop

iOS

Android

PullerBear is not working, tagging in @AndrewGable and @stitesExpensify since we're all invested in getting Fabric enabled ASAP

Tested all platforms, LGTM!

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

checks passed

🚀 Deployed to staging by @stitesExpensify in version: 1.2.20-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

FYI, this PR introduced a couple of major crashes on Android. Perhaps it wasn't reproducible for you all as it required a custom profile image? Reverted here.

I think it just another data point showing that wider smoke testing would be valuable in preventing regressions. We'll never spot all of these issues with manual testing.

I think its just another example showing that wider smoke testing would be valuable in preventing regressions. We'll never spot all of these issues with manual testing.

I totally agree, thanks for handling the blocker

Perhaps it wasn't reproducible for you all as it required a custom profile image?

That's probably what it was. The account i was testing on didn't have a custom image

🚀 Deployed to production by @chiragsalian in version: 1.2.20-3 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


Revised font system

Fonts are currently bitmap fonts that were pregenerated.  It would be preferable to use a system that can handle generating font atlases at runtime, can support better scaling support, support for additional character sets via fallback fonts, etc.
The ideal conversion would be to replace the current implementation with FontStashSharp.  We'd want the result to be a mostly drop in replacement in terms of the visual result.

I've begun working on these improvements.

How is this progressing? Are there any problems and can I help in anyway?
Otherwise we could reconsider reopening #406? if FontSharp is not a priority? Gives a bit more variety in the meantime.
I have some ideas with fading from and to Krytan typeface to give a cool visual effect. :D

Is there any update on this issue? I have replaced BitmapFont with FontStashSharp in my forked repository, which supports Chinese and works well. Of course, my code is only used to verify the support of Blish HUD for Chinese and the implementation of IME Helper. (Currently, there are no good ideas.)


Fix a typo in a docstring in activations.py:

"is define as" => "is defined as"

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 57.42%. Comparing base (4f7f852) to head (b4c94f7).

:exclamation:  There is a different number of reports uploaded between BASE (4f7f852) and HEAD (b4c94f7). Click for more details.
HEAD has 6 uploads less than BASE

Flag
BASE (4f7f852)
HEAD (b4c94f7)

keras
4
1

keras-torch
1
0

keras-tensorflow
1
0

keras-jax
1
0

Additional details and impacted files
@@             Coverage Diff             @@
##           master   #20305       +/-   ##
===========================================
- Coverage   78.83%   57.42%   -21.41%
===========================================
  Files         511      511
  Lines       48989    48989
  Branches     9022     9022
===========================================
- Hits        38621    28133    -10488
- Misses       8505    19043    +10538
+ Partials     1863     1813       -50

Flag
Coverage Δ

keras
57.42% <ø> (-21.28%)
:arrow_down:

keras-jax
?

keras-numpy
57.42% <ø> (-0.01%)
:arrow_down:

keras-tensorflow
?

keras-torch
?

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


isn't class an ECMAScript reserver keyword ?

according to this: https://developer.mozilla.org/en/JavaScript/Reference/Reserved_Words
(for future use)

Discussed in #37


ci: add the common Danger workflow

#skip-changelog

@ribice can you approve + merge this one first?

Please revert this, we manually write the changelog once it it time for a release.


error when execute python server.py

on windows, all is running ok until i run server.py
i got this error
can someone give any help?
thanks in advance
Traceback (most recent call last):
File "server.py", line 12, in
import spotipy
File "X:\Python\Python37\lib\site-packages\spotipy_init_.py", line 2, in
from client import Spotify, SpotifyException
ModuleNotFoundError: No module named 'client'

Problem is with python v3
Solved with python v.2.7.15


The second scheme of item attribute reading is given

You can select the mode to use in the configuration file
I added a scheme, as the issue said
The mode of + 10 Heal or + 10 + 10 - 5 heal is supported

And I added an event
Let more developers define the reading of attributes themselves

Provides a direct means to close and open the skillbar

Two events are added to make the attack target judgment of the plug-in more customized

I appreciate the work you've done. I don't really see a need for the events you've added though. The 'can attack' is more of a condition than an event. Probably the better way to give developers a better handle on damage that way would either be a SkillAPI Damage Event or introducing an ally API with which the developers can define who is allied with who. Additionally, the Attribute Read event seems pointless aside from being able to be cancelled, since the properties are all read-only.
I'm still sort of toying with the concept of the alternate reading method too. There is probably a more efficient and cleaner way to accomplish that.
Additionally, the majority of the code changes are formatting changes. It would make my job easier and browsing the code easier if you follow the same formatting. If you're using IntelliJ, here is my formatting configuration. Just save it to a .xml file and import it into IntelliJ in Settings > Code Style > Java
<code_scheme name="Default" version="173">
  <option name="WRAP_WHEN_TYPING_REACHES_RIGHT_MARGIN" value="true" />
  <JavaCodeStyleSettings>
    <option name="DO_NOT_WRAP_AFTER_SINGLE_ANNOTATION" value="true" />
    <option name="ALIGN_MULTILINE_TEXT_BLOCKS" value="true" />
  </JavaCodeStyleSettings>
  <codeStyleSettings language="JAVA">
    <option name="BLANK_LINES_AROUND_METHOD_IN_INTERFACE" value="0" />
    <option name="ALIGN_GROUP_FIELD_DECLARATIONS" value="true" />
    <option name="ALIGN_CONSECUTIVE_VARIABLE_DECLARATIONS" value="true" />
    <option name="TERNARY_OPERATION_WRAP" value="5" />
    <option name="TERNARY_OPERATION_SIGNS_ON_NEXT_LINE" value="true" />
    <option name="KEEP_SIMPLE_BLOCKS_IN_ONE_LINE" value="true" />
    <option name="KEEP_SIMPLE_METHODS_IN_ONE_LINE" value="true" />
    <option name="KEEP_SIMPLE_LAMBDAS_IN_ONE_LINE" value="true" />
    <option name="KEEP_SIMPLE_CLASSES_IN_ONE_LINE" value="true" />
    <option name="ARRAY_INITIALIZER_WRAP" value="5" />
    <option name="ARRAY_INITIALIZER_LBRACE_ON_NEXT_LINE" value="true" />
    <option name="ARRAY_INITIALIZER_RBRACE_ON_NEXT_LINE" value="true" />
    <option name="PARAMETER_ANNOTATION_WRAP" value="5" />
    <option name="WRAP_ON_TYPING" value="1" />
    <arrangement>
      <groups>
        <group>
          <type>GETTERS_AND_SETTERS</type>
          <order>KEEP</order>
        </group>
        <group>
          <type>OVERRIDDEN_METHODS</type>
          <order>BY_NAME</order>
        </group>
      </groups>
    </arrangement>
  </codeStyleSettings>
</code_scheme>```

So if you can help me see why having those events is important and can adjust the formatting for me, that would be awesome! Thanks for your contribution!

Yes, as you said, I need an ally API, because it is difficult to make other team systems support skillapi. Then, attribute reading is to break through the fixed format and let developers use some cooler formats, such as enhanced plug-ins. A lore can be directly enhanced and written in the suffix, such as + 20 damage (+ 5). I think it is intuitive and cool. I'm sorry I didn't think about the format so thoroughly, because I mainly write code with kotlin. I don't know much about the Java format, resulting in a lot of reading difficulties. I'm sorryIn conclusion, thank you for your reply. I like this project very much

You're good man. I use slightly different formatting settings anyway for my Java projects to try to make things a little more readable. I'll probably make some changes to this when I pull it in, but it's a good place to start from.

Thank you very much for your answer, which makes me very excited
Thank you for modifying my code


Can we use this plugin to build xamarin android projects?

Will I be able to build xamarin android projects using fastlane/fastlane-souyuz plugin?

yes, this is my sample step:
   souyuz(
        platform: "android",
        build_configuration: configuration",
        keystore_path: ENV["KEYSTORE_PATH"],
        keystore_alias: ENV["KEYSTORE_ALIAS"],
        keystore_password: ENV["KEYSTORE_PASSWORD"],
        output_path: "./src/App.Droid/bin/#{configuration}"
      )

@orestesgaolin thats exactly how you do it, thank you
closing here

Hi i'm new with Fastlane and it's king of hard to start.
I tool @orestesgaolin sample but the question is: What command i should type to make it works?
Can i do it from anywhere on my local or only in my project? Thanks

Hey @Kingamattack just have a look in the Wiki section of this repo here. To use this plugin you have to use fastlane, full documentation is located here. There are example Fastfiles for Android and iOS.


[MB-16218] service request documents uploader

Jira ticket
Summary
This PR addresses 3 things

Creates an uploader to handle ServiceRequestDocuments
Adds factory functions for ServiceRequestDocument and ServiceRequestDocumentUpload that are needed for server test
Added a delete function to the ServiceRequestDocumentUpload model, very similar to the one on the PrimeUpload model. One thing to note is that we're trying to move away from methods like these on the model and instead use service objects. While I think that was out of scope for this ticket given time constraints, I would like to move this into the existing mtoserviceitem service object as part of the work for https://dp3.atlassian.net/browse/MB-16192 if there's time

Verification Steps for the Author
These are to be checked by the author.

[ ] Tested in the Experimental environment (for changes to containers, app startup, or connection to data stores)
[x] Have the Jira acceptance criteria been met for this change?

Messages

:book:
:link: MB-16218

  Generated by :no_entry_sign: dangerJS against bc83d5f031f246a123cb4839451f928469966a67

Just a question about some commented code I saw, but other than that, looks good to me!

Thanks, I forgot to remove this!


feat(deps): update renovate/renovate docker tag to v35.2

This PR contains the following updates:

Package
Update
Change

renovate/renovate
minor
35.1 -> 35.2

Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.

[ ] If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot.

:tada: This PR is included in version 4.1.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket: