"Edit this Page" missing from userbar

Issue Summary
In previous versions of Wagtail, the userbar contains a link to "Edit this page" on both the live page and when viewing draft pages. The userbar shown on live pages still contains this link.

But the version displayed on "View Draft", e.g. example url: https://example.com/admin/pages/25185/view_draft/, does not.

Steps to Reproduce

Create a site using Wagtail 4.1.1 or 4.2rc1
Create a page and "Save draft"
From the page explorer for the parent of the draft page above, choose "View Draft"
Click on the Wagtail icon to display the menu

I have only found this on existing projects I have upgraded. I have not confirmed that this issue can be reproduced as described on a fresh Wagtail project.
Technical details

Python version:  3.8.16
Django version: 4.1.5
Wagtail version: 4.1.1 and 4.2rc1
Browser version: Chrome 109

I can confirm this on my own Wagtail 4.1.1 installation, and confirm that it previously worked on a (different) Wagtail 3.0.1 site.
I have also confirmed it on a fresh Wagtail project with no modifications (using 4.1.1).

Hi, I want to work on this issue, if possible would you please assign this issue to me?

Thanks for your interest @satvikvash! You are welcome to work on this. We do not assign issues outside of the core team - we just ask that people indicate their intention to work on an issue (as you have now done), to avoid duplicating efforts.
For further help in getting started, please see https://dev.to/lb/ten-tasty-ingredients-for-a-delicious-pull-request-hgc - you may also wish to join our #new-contributors channel on Slack.

Hi, would it be possible to work on this issue as well?

Hello, Removing
try:
   if request.is_preview:
       return ""
except AttributeError:
    pass
from EditPageItem class of userbar.py will solve the issue.
I will be happy to create a pull request.

Hi @Aravind2203, if you do this it creates an edit button on preview page also, and this whole code is for not having an edit button on preview page userbar (this is also mentioned in the comment written above this code). I think removing this code will resolve this issue but create a new issue. I have solved this issue using a different approach and presently I am working on writing the tests for the pull request.

This is a regression in https://github.com/wagtail/wagtail/pull/8766, because the "view draft" view uses Page.make_preview_request().

Hi @laymonage, are you suggesting that the edit button is missing on purpose from view_draft? Could you please clarify?

To add, this also means the "Edit" link is also missing from other previews, namely the revision preview and the workflow preview.
Accessing the Preview from here:

and here:

will result in the same issue.
Looking at the reasoning behind #8766, I feel like the changes made in that PR should be redone in a different approach, so that the edit link is hidden when viewing the preview on edit/create views only (and not the other previews).
This can be done by adding another extra attribute to the request object, e.g. is_editing, on the PreviewOnEdit view:
https://github.com/wagtail/wagtail/blob/59c0044df369752fc00071fdadbd51eabbc7b53c/wagtail/admin/views/generic/preview.py#L108-L112
Then, check for the new attribute in here:
https://github.com/wagtail/wagtail/blob/59c0044df369752fc00071fdadbd51eabbc7b53c/wagtail/admin/userbar.py#L140-L146
e.g.
- if request.is_preview:
+ if request.is_preview and request.is_editing:


updated babel-root-import dependency

it seems like the babel-root-import package is now deprecated and has been renamed to babel-plugin-root-import @junaidrsd

@w74 Released https://github.com/SC5/sc5-styleguide/releases/tag/2.0.4


How to evaluate a pretrained model?

@huminghao16
Could you include the scripts for evaluating a pretrained model?
(for example evaluating the large model you have included in the readme.)

Do you attempt to evaluate a pretrained model without fine-tuning?
There are some newly-added parameters that are randomly initialized. If you don't fine-tune the model, the model may produce random predictions.

Yes, that's what I want to do.

Is there a way to fix the "newly-added parameters" when loading the model file?
(I mean, what's the point of creating a model when you can't even evaluate it?)
FYI @tusharkhot

@danyaljj @huminghao16   hi, I also want to evaluate the model using the checkpoint given by the author, but I can not get similar results with the paper. Can you give some suggestions?

Dear @huminghao16,
Thank you for releasing the code and your trained model.
I also have the same issue on evaluating the provided checkpoint.
Could you please give us some tips on how to evaluate your checkpoint?
Thank you for your support!


Add gcmp project

This a copy of gcmp.io excluding the newsletter form.
The font size and card styling are different because I'm just using what's in the design system.

Merging blindly so I can set up a Vercel preview


laxcomma doesn't work in jasmine tests

my .jshintrc config:
{
  "browser": true,
  "jquery": true,
  "jasmine": true,
  "node": true,
  "phantom": true,
  "laxbreak": true,
  "laxcomma": true,
  "globals": {
    "angular": false
  }
}

the laxcomma switch works for all of my application files.  However, in my jasmine unit tests, I still receive the error message about unsafe line breaks with a comma.
I, therefore, have had to add /* jshint laxcomma:true */ to the first line of my jasmine scripts.

My initial guess is that there is an additional .jshintrc file in an intermediate directory between your test file and the RC file whose contents you have shared here. Without more detail, though, it's difficult to say what is going wrong. Is the source code of your project available online?

Nope, no additional .jshintrc anywhere except in the main project folder.  JSHint was never added to the project until I did so.  And, unfortunately, this is a private project - not on github.

I'm not sure what it could be about your test files that are causing the configuration to be ignored. Without an example, I'm not able to diagnose further, though. Could you put together a demonstration that you are able to share publicly?

Without more information, we won't be able to resolve this issue, so I'm going to close it. If anyone is able to share a minimal test case, we can re-open and continue the investigation.


kube::api::Void conflicts with void::Void

Not strictly a conflict since Rust has a module system, but it seems like a pointless source of confusion, especially given that kube::api::Void is the exact opposite of void::Void. Especially given that kube::api::Void is just a long-winded way of writing ().

Ah, didn't realise there was a crate for this, interesting.
Now, the void::Void one is an unconstructible enum, and mine is an empty struct.
The primary reason we have this type herein isn't because the object might never have a status, but it's because we'd like to indicate that we never care about it.
By having a serde impl on an unconstructible enum, you end up failing to deserialize it when you actually get something there, whereas with an empty struct, you just discard everything.
Maybe there's a better way of wording the type so that it's less of a source of confusion (which I totally agree with).

Rust already has the builtin () type (aka "unit") for this, and serde implements both Deserialize and Serialize for it.

Hm. I started out with that. Don't remember why I changed, but it was probably trait bounds. Will try again later with just a raw unit type.

I tried replacing pub struct Void {} with pub type Void = ();, and all tests seem to pass, and all examples build. PR is on its way.

If it works with just (), feel free to just take out the type entirely and replace it with the literal where it comes up.

My plan was to leave Void as an alias for now but mark it deprecated, to avoid breaking library consumers (then again, I'm fine with removing it completely, this is, after all, still 0.x).

Actually, there is one more source of potential breakage.. Void serializes as an empty object ({} for JSON), while serde-json serializes () as null. I guess K8s might not like that? More investigation required!
That would also explain why it's an empty struct (struct Void {}) rather than a unit struct (struct Void;).

Ah, that rings a bell. Think I used to have Option<()> for a while as well. That might have been to get around that. Sorry, it's been a while.

Void is only used for Status objects, which you can only really set replace_status and patch_status, you'd probably not be allowed to set it to null, if the subresource exists, but you can probably set it to empty struct.

Makes sense, that's promising then. So the remaining thing to check would be whether creates still work correctly.

Looks like the problem is actually that Serde only allows null for () fields. I tried eradicating Void from examples/crd_api.rs, but that crashes:
[2020-02-19T21:54:37Z TRACE kube::client] DELETE https://<IP_ADDRESS>:8443/apis/apiextensions.k8s.io/v1beta1/customresourcedefinitions/foos.clux.dev?
[2020-02-19T21:54:37Z TRACE kube::client] 200 https://<IP_ADDRESS>:8443/apis/apiextensions.k8s.io/v1beta1/customresourcedefinitions/foos.clux.dev?
[2020-02-19T21:54:37Z INFO  crd_api] Deleted foos.clux.dev: (Some(CustomResourceDefinitionCondition { last_transition_time: Some(Time(2020-02-19T21:54:37Z)), message: Some("CustomResourceDefinition marked for deletion; CustomResource deletion will begin soon"), reason: Some("InstanceDeletionPending"), status: "True", type_: "Terminating" }))
[2020-02-19T21:54:38Z INFO  crd_api] Creating CRD foos.clux.dev
[2020-02-19T21:54:38Z TRACE kube::client] POST https://<IP_ADDRESS>:8443/apis/apiextensions.k8s.io/v1beta1/customresourcedefinitions?
[2020-02-19T21:54:38Z TRACE kube::client] 201 https://<IP_ADDRESS>:8443/apis/apiextensions.k8s.io/v1beta1/customresourcedefinitions?
[2020-02-19T21:54:38Z INFO  crd_api] Created foos.clux.dev (Some(CustomResourceDefinitionStatus { accepted_names: CustomResourceDefinitionNames { categories: None, kind: "", list_kind: None, plural: "", short_names: None, singular: None }, conditions: None, stored_versions: ["v1"] }))
[2020-02-19T21:54:39Z INFO  crd_api] Creating Foo instance baz
[2020-02-19T21:54:39Z TRACE kube::client] POST https://<IP_ADDRESS>:8443/apis/clux.dev/v1/namespaces/default/foos?
[2020-02-19T21:54:39Z TRACE kube::client] 201 https://<IP_ADDRESS>:8443/apis/clux.dev/v1/namespaces/default/foos?
[2020-02-19T21:54:39Z WARN  kube::client] {"apiVersion":"clux.dev/v1","kind":"Foo","metadata":{"creationTimestamp":"2020-02-19T21:54:39Z","generation":1,"name":"baz","namespace":"default","resourceVersion":"6803","selfLink":"/apis/clux.dev/v1/namespaces/default/foos/baz","uid":"f0569a7b-2aee-4cbc-b6eb-3341fbb5fcb3"},"spec":{"info":"old baz","name":"baz"}}
    , Error("invalid type: map, expected unit", line: 1, column: 283)
Error: Error deserializing response

Caused by:
    invalid type: map, expected unit at line 1 column 283

The Serde-official way to ignore a field seems to be IgnoredAny, but sadly that doesn't impl Serialize.
As a plan B, maybe we could rename Void to something else? I'd suggest Empty or NotUsed.

Ah, damn. Thanks for trying it out anyway.

As a plan B, maybe we could rename Void to something else? I'd suggest Empty or NotUsed.

Both of those are good. Leaning slightly towards Empty myself for brevity.

Ok, PR is coming up.


feat(entity-generator): add import extension for referenced entities

In a generated entity, add the ability for referenced entities to be imported by a named import.
Most common case is a extension of '.js' but node does support '.cjs' and '.mjs'. Supported ESM_FILE_FORMAT can be found in the node docs https://nodejs.org/docs/latest-v16.x/api/esm.html#resolution-algorithm
Another possible approach is to check package.json for "type": "module" but that felt like I was being too smart as I wouldn't know for sure which supported file format the consumer would want.

Took your advice. Added a default option to check if an esm is turned on through package.json. Removed all the other options (cjs/mjs) and instead turned into a boolean to be a esm import.

Codecov Report
Base: 99.98% // Head: 99.97% // Decreases project coverage by -0.00% :warning:

Coverage data is based on head (ff83443) compared to base (40f725e).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3420      +/-   ##
==========================================
- Coverage   99.98%   99.97%   -0.01%
==========================================
  Files         205      205
  Lines       12646    12660      +14
  Branches     2923     2926       +3
==========================================
+ Hits        12644    12657      +13
- Misses          2        3       +1

Impacted Files
Coverage Δ

packages/core/src/utils/Configuration.ts
100.00% <ø> (ø)

packages/core/src/utils/ConfigurationLoader.ts
100.00% <100.00%> (ø)

packages/entity-generator/src/EntityGenerator.ts
100.00% <100.00%> (ø)

packages/entity-generator/src/SourceFile.ts
100.00% <100.00%> (ø)

packages/core/src/utils/Utils.ts
99.78% <0.00%> (-0.22%)
:arrow_down:

packages/core/src/MikroORM.ts
100.00% <0.00%> (ø)

packages/cli/src/commands/SchemaCommandFactory.ts
100.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

Thanks!


Missing Transcript Plots with Preview

Hello!
My first time posting so my apoligies if I am missing some information.
I am using baysor preview with V0.6.2. The code works but then I get an error at the end. When I open the html output, I get all the available plot outputs except for the transcript plots. Does anyone know what could be the matter?
(baysor) $ baysor preview -x x_location -y y_location -z z_location -g feature_name -m 10 path/to/transcript.csv
[14:51:39] Info: # CLI params: `-x x_location -y y_location -z z_location -g feature_name -m 10 path/to/transcript.csv`
[14:51:39] Info: (2024-03-14) Run Baysor v0.6.2
[14:51:39] Info: Loading data...
[14:51:54] Info: Loaded 4594120 transcripts
[14:51:56] Info: Estimating noise level
[14:53:21] Info: Done
[14:53:21] Info: Estimating local colors
[15:08:59] Info: Building transcript plots
[15:09:02] Info: Building gene structure plot
[15:10:01] Info: Plotting
[15:11:27] Info: All done!

(process:35155): GLib-CRITICAL **: 15:11:27.593: g_datalist_id_set_data_full: assertion 'key_id > 0' failed

(process:35155): GLib-CRITICAL **: 15:11:27.593: g_datalist_id_set_data_full: assertion 'key_id > 0' failed

Update: it seems to have worked if I downgraded Baysor to v0.5.0.

That looks like some dependency error. If it's still relevant, could you try running it on a subset of the data?

I get the same error with V0.6.2. Still missing transcript plots from the preview report.

That is something, which is supposed to be fixed in v0.7.0. Transcript plots were just too big on Xenium, so they weren't rendered. (Yeah, I remember that v0.7.0 doesn't work for you because of the bug).
I'd suggest building a transcript plot manually. I have this WIP package baysorpy, which is mostly for internal use. But you can use it from Python, and have from baysorpy.plot_utils import plot_molecules and then run plot_molecules(df, color="ncv_color") on the Baysor output. It only requires columns to be named x, y and gene.


Update Excel.Sheets.FillAcrossSheets.md

Wrong example code

The example code is not Wrong. Just I don't know I can use Array() to index Sheets object before. Sorry.


Add EmailDeliveryFailure view

Details
Adds a new "email delivery failed" view to newDot for when users are blocked because AWS / Mailgun haven't been able to deliver emails to them.
Fixed Issues
$ https://github.com/Expensify/Expensify/issues/286767
PROPOSAL: N/A
Tests

Login into your account on oldDot and add the email delivery failed NVP by pasting the following in the JS console: NVP.set('expensify_emailDeliveryFailure', {'lastSMTPErrorDatetime': moment.now().addDays(1).toString()});
In an incognito window, try to log into your account in newDot
Confirm you see the following view:

Click the here link and confirm it redirects to https://community.expensify.com/discussion/5651/deep-dive-best-practices-when-youre-running-into-trouble-receiving-emails-from-expensify/p1?new=1
Click Back and confirm it takes you back to login view to enter an email/sms number
In your original window run NVP.set('expensify_emailDeliveryFailure', null); in the JS console to unblock your account

[x] Verify that no errors appear in the JS console

Offline tests

Login into your account on oldDot and add the email delivery failed NVP by pasting the following in the JS console: NVP.set('expensify_emailDeliveryFailure', {'lastSMTPErrorDatetime': moment.now().addDays(1).toString()});
In an incognito window, try to log into your account in newDot
Disable your network connection
Confirm you see the following view:

QA Steps

Login into your account on oldDot and add the email delivery failed NVP by pasting the following in the JS console: NVP.set('expensify_emailDeliveryFailure', {'lastSMTPErrorDatetime': moment.now().addDays(1).toString()});
In an incognito window, try to log into your account in newDot
Confirm you see the following view:

Click the here link and confirm it redirects to https://community.expensify.com/discussion/5651/deep-dive-best-practices-when-youre-running-into-trouble-receiving-emails-from-expensify/p1?new=1
Click Back and confirm it takes you back to login view to enter an email/sms number
In your original window run NVP.set('expensify_emailDeliveryFailure', null); in the JS console to unblock your account

[x] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android / native
[x] Android / Chrome
[x] iOS / native
[x] iOS / Safari
[x] MacOS / Chrome / Safari
[x] MacOS / Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[x] I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Mobile Web - Chrome

Mobile Web - Safari

Desktop

iOS

Android

Some changes going on with the SignInPage where it was converted to a functional component and then reverted so going to hold off on updates for now

Looks like there's a WIP PR to migrate that component again so holding off until that's merged

https://github.com/Expensify/App/pull/20708 is in review so going to continue to hold off on making changes

@NikkiWines did a quick test seems to work well. I get to see the failure view.

There are a couple of related prop errors/warnings please fix that, thanks

thanks for the review @Santhosh-Sellavel, updated!

@NikkiWines Seems the warning still occurs please check the video below
https://github.com/Expensify/App/assets/85645967/a7d20f56-06cc-47cb-9198-8a215b10203e

Ah, sorry about that @Santhosh-Sellavel, should be good now

Updated once more 🙇

@NikkiWines Keyboard Doesn't disappear automatically on iOS alone.
https://github.com/Expensify/App/assets/85645967/d7de6228-87b1-496f-9c7f-e9cf5b261bcd

Reviewer Checklist

[x] I have verified the author checklist is complete (all boxes are checked off).
[x] I verified the correct issue is linked in the ### Fixed Issues section above
[x] I verified testing steps are clear and they cover the changes made in this PR

[x] I verified the steps for local testing are in the Tests section
[x] I verified the steps for Staging and/or Production testing are in the QA steps section
[x] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[x] I checked that screenshots or videos are included for tests on all platforms
[x] I included screenshots or videos for tests on all platforms
[x] I verified tests pass on all platforms & I tested again on:

[x] Android / native
[x] Android / Chrome
[ ] iOS / native
[x] iOS / Safari
[x] MacOS / Chrome / Safari
[x] MacOS / Desktop

[x] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
[x] I verified proper code patterns were followed (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I verified that this PR follows the guidelines as stated in the Review Guidelines
[x] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[ ] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web & Desktop
https://github.com/Expensify/App/assets/85645967/66d1e0a4-dc06-4959-bfc6-c2d40d63703a

Mobile Web - Chrome & Mobile Web - Safari
https://github.com/Expensify/App/assets/85645967/89585d8c-8c9a-4bbb-b604-6b659f0fe03b

iOS & Android
https://github.com/Expensify/App/assets/85645967/777e720e-bf74-40ff-a433-82437729b084

@Santhosh-Sellavel added logic to dismiss the keyboard

🚀 Deployed to staging by https://github.com/PauloGasparSv in version: 1.3.40-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to production by https://github.com/Julesssss in version: 1.3.40-5 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

There is a regression in the back end so going to fix that

@Santhosh-Sellavel issue created! Sorry about that - https://github.com/Expensify/App/issues/22910


Left Nav is cumbersome to use

Hey @apotonick , thanks for your work on Trailblazer and all of its gems. 👍
I just want to log a note here that the left nav leaves something to be desired when clicking through a gem's pages.  For example, when looking up how to use Representable, I find myself clicking through all the links on the left side nav, but because the Representable links aren't visible at the top of the page, it's frustrating to scroll down to find the right link.
My suggestion would be to collapse the links for the gems that you aren't currently looking at, like this:

I would love that, can you do it? :heart_eyes:


[Slider] Fixes for docs

A few fixes for the docs so that they run correctly.
Also added a few things:

Custom label interpreter function
Bug with reversed slider label positioning

/cc @jlukic @flytreeleft

@gdaunton The variable sliderObserver(which is at line 84 in src/definitions/modules/slider.js) should be removed.
I didn't ever notice it in my last PR :(


Map.ts:14:5 Property '[Symbol.toStringTag]' has no initializer and is not definitely assigned in the constructor.

I am a deno user and recently switched to deno's new vendoring feature.
This means I am no longer using the cached (transpiled .js) version, but rather the .ts source code.
Deno gives me the following error (minimal_polyfills@2.2.1):
TS2564 [ERROR]: Property '[Symbol.toStringTag]' has no initializer and is not definitely assigned in the constructor.
    [Symbol.toStringTag]: string;
    ~~~~~~~~~~~~~~~~~~~~
    at .../raw.githubusercontent.com/garronej/minimal_polyfills/v2.2.1/deno_dist/Map.ts:14:5

I experienced this when trying to import * as evt from<EMAIL_ADDRESS>

Sorry I forgot to make it reproducible, here are the steps:
mkdir _test_mp
cd _test_mp
echo "import * as evt from \"https://deno.land/x/evt@v2.3.3/mod.ts\";" > deps.ts
deno vendor --force --output=.deno_vendor deps.ts
deno run --check --import-map=.deno_vendor/import_map.json deps.ts

The key is to use  --check, so deno checks the files.

Thank you very much for your help


[REQUEST]Add 32b meta data space to SPIFFS

Hi,
I am using arduino-esp32 and SPIFFS core is built by IDF
As ESP32 is still in development I would like to request SPIFFS is compilated using
#define SPIFFS_OBJ_META_LEN             32
to be able to use the SPIFFS meta data to store file creation/modification date/time as currently this feature (SPIFFS_OBJ_META_LEN) is disabled because space is set to 0.
The impact of such change is on tools and backward compatibility - so better to ask earlier than latter as it was suggested by @me-no-dev
This value could be configurable by make menuconfig also but this means to add new parameter to tools like mkspiffs
The hardcode solution advantage would be that tools need update once and stay consistent after
The configurable solution may lead to incompatibilities with tools not using same data size but I guess can be handled
Also I read a new mkspiffs would be done soon, so It would be a good chance to get this change incorporated as well -  so it is good time for such request that will give more flexibility in SPIFFS

I am generally for this change. Lets discuss how that will work in reality :) like if time is not configured, what would be set as last modification or creation. As @luc-github mentioned, the current mkspiffs is not working and we can use the opportunity to add it there as well.

I have an ESP32 spiffs implementation for ~5 months with metadata used for timestamp.
mkspiffs also works without problems.
You may look at my repository

Yup :) we saw your repo and begun discussion on the topic :) needs to be implemented in IDF though so to be working on all esp32 levels :) thanks for implementing it:) i hope you will see it soon here as well

I did modification for IDF and Arduino to add last write time to SPIFFS and unify it for SD and SPIFFS:
https://github.com/luc-github/esp-idf/commit/bfc9d60bce70145e33ad78c364008b1c0ee5be01
https://github.com/luc-github/arduino-esp32/commit/4b32c261717c1db526d3548776574ffa8bb583b7 and https://github.com/luc-github/arduino-esp32/commit/2d6d6ba1e9eb61f4a99246d998e2ab4d4e86fdc2
For mkspiffs it just need to change the meta len for ESP32 package
#define SPIFFS_OBJ_META_LEN (4)
So compilation is not an issue, but I wonder how to discriminate mkspiffs for ESP8266 vs ESP32 ?
Currently there is nothing but version to say which version is for ESP32

I did same modification for SPIFFS for ESP8266 : https://github.com/luc-github/Arduino/commit/c6bf371a412c35302945bb0ca9a9250ab6e7bd73
if it can help to simplify global consistency

I did PR as suggested by @me-no-dev
idf : https://github.com/espressif/esp-idf/pull/1128 (signed twice  CLA but seems not recognize me :sob: )
esp-32 : https://github.com/espressif/arduino-esp32/pull/738
esp8266: https://github.com/esp8266/Arduino/pull/3730
to lower impact on mkspiffs
Thank you


The method '*' was called on null.

Implemented  sizer: ^1.1.8 but getting error when I set it as following:
SizedBox(height: 20.0.h),
Error:
======== Exception caught by widgets library =======================================================
The following NoSuchMethodError was thrown building LoginWithSet(dirty, dependencies: [_FocusMarker, MediaQuery, _InheritedTheme, _LocalizationsScope-[GlobalKey#39772]], state: _LoginWithSetState#2e207):
The method '*' was called on null.
Receiver: null
Tried calling: *(20.0)

The relevant error-causing widget was:

When the exception was thrown, this was the stack:
#0      Object.noSuchMethod (dart:core-patch/object_patch.dart:51:5)
#1      SizerUtil.height (package:sizer/sizer_util.dart:32:20)
#2      SizerExt.h (package:sizer/sizer_ext.dart:7:29)
#3      StatefulElement.build (package:flutter/src/widgets/framework.dart:4744:28)
...

Same issue here.

Solved. May you forgot this lines  to add in main.dart

It's working fine now.

I have these lines in my main.dart but still getting this error. What is the basic reason for this error!?!!?
Please someone help.
`import 'package:flutter/material.dart';
import 'home_page.dart';
void main() {
runApp(MyApp());
}
class MyApp extends StatelessWidget {
// This widget is the root of your application.
@override
Widget build(BuildContext context) {
return MaterialApp(
debugShowCheckedModeBanner: false,
title: 'Flutter Demo',
theme: ThemeData(
primarySwatch: Colors.blue,),
home: HomePage(),
);
}
}
`


TensorRT-LLM Backend Exported Model

Hey everyone!
WhisperS2T now supports the TensorRT-LLM backend, achieving double the inference speed compared to the CTranslate2 backend! The current optimal configuration on an A30 GPU achieves transcription of 1-hour files in approximately 18 seconds.
After TensorRT-LLM optimization, the exported model only works on NVIDIA GPUs with the same cuda_compute_capability. This means a model exported on a T4 GPU won't work on an A100, and vice versa.
Help Needed: Model export takes about 3-6 minutes. I need volunteers out there to export the model for a specific GPU and share it. It would be a huge help to the community! I have access to A30, A100, and T4 GPUs for which I will add the exported models.
PS: I will update this discussion in a few weeks on how to contribute your exported model.
Thanks,
Shashi

@shashikg  It's a very nice and excited project. If you're not in a hurry, I will be available to help you after 20 days. One concern is that, with the updates of the tensorrt-llm cpp runtime, these exported models might become obsolete. It would be best to have a one-button script to handle this, so we can regularly generate the latest models and then upload them to Hugging Face: like this https://huggingface.co/csukuangfj/k2/tree/main/cuda with tensorrt-version-gpu-model-name.pt

I can  help with  P40   and  P4 .   Is there any incompatibility  with  WhisperX.  A mean if WhisperX is already installed and work, if i install this packet , will cause any problems ??

Hi @yuekaizhang  thanks for showing interest in this project!

If you're not in a hurry, I will be available to help you after 20 days.
Yeah no hurry.. I am planning to maintain this project for a longer duration!

It would be best to have a one-button script to handle this, so we can regularly generate the latest models and then upload them to Hugging Face.
Right suggestion. So at present exported models are cached locally in tmp directory (even this helps - basically if anyone uses the package again on the same device, it picks up the exported model from the cache directory). I am working on to generate a tarred format for the exported model, which can be used to load the model or share it.  I will integrate the huggingface_hub client library to automate the upload process as well.

I will ping here once everything get's ready.


Fix embedded media not displaying in status cards

Embedded media does not currently display due to the styles starting at line 553 hiding status card media if there's no image. Clicking the play icon on such status cards will still load and play the media but set the display on the corresponding iframe to none, creating a video or audio track that is playing but cannot be paused or muted.
Adding this property overrides that style if the element is a video status card containing an iframe. This allows embedded media from YouTube, SoundCloud, and other media-focused sites to display correctly.
This change is best demonstrated by searching for #music and clicking around some of the status cards with embedded media and play buttons.

Thanks @LetyDoesStuff! ❤


Update dcp_pad url

Addresses issue #319 and a task in #272. One reviewer required.
This dataset should be tested locally but it is quite large therefore it might not be able to. If that is a problem, we should test using the single dataset runner with an updated librar-archive-action.

It won't work on the runner until we  run the library-archive-action  workflow @AmandaDoyle


formatterParams for tickCross breaks the view

I am new to this node, learning how to use it to create rich tables. So far loving it.
I am displaying data coming from a fs-file-lister node, and want a column which shows if it is a file or folder.
First, I created the column definition:
    {
        "title": "Folder",
        "field": "stat.isDirectory",
        "formatter": "tickCross",
    },

And it works great, but I wanted different icons, so I added a formatterParams (I will check the icons later once it is working):
    {
        "title": "Folder",
        "field": "stat.isDirectory",
        "formatter": "tickCross",
        "formatterParams": {
            "tickElement": "",
            "crossElement": ""
        }
    },

For this this I get this on the dashboard instead of my table:
","crossElement":"
"}},{"title":"Name","field":"fname"},{"title":"Size","field":"stat.size"},{"title":"Created","field":"stat.created"}],"outputs":1,"cts":false,"x":910,"y":4460,"wires":[["7732d00f3757fdea"]]})'>

I am not sure if this is because some options are not supported, or I missed something else as well.

Sorry, I realized I just had to escape the double quotes and it works:
    {
        "title": "Folder",
        "field": "stat.isDirectory",
        "formatter": "tickCross",
        "formatterParams": {
            "tickElement": "",
            "crossElement": ""
        }
    },


ES Modules support

Link to:
https://github.com/Chatie/tsconfig/issues/16

@anaivebird This PR enables the ESM with the latest TypeScript version 4.4.3.
Please help us to review this PR and feel free to improve and merge it when you believe it's good to go.
Thank you very much.


Rendering speed of suggestions is affected by length of current file

With longer files (>50k lines) it starts to take longer and longer time to render reposes.
I attach short movie:
https://user-images.githubusercontent.com/205610/216761471-47fb6801-513d-4ee6-b457-09580eac552c.mp4

I just tested it and now it take some time to load suggestions, but once response is ready, I can quickly switch between suggestions. So at least this part is fixed.
When Codeium is enabled on large file, I still see some slowness (short blocking) when I just type. It's probably related to remaining call which calculates cursor_offset -  codeium#util#PositionToOffset('.', '.')
Maybe you could consider adding to language server API, ability to provide line numer + column, instead of absolute offset in whole string? This should remove dependency to this O(N) funciton completely.

I just checked accepting suggestion, and it has the same long delay.

I've made some optimizations in https://github.com/Exafunction/codeium.vim/pull/69, curious to see how your case behaves now.

Great, I'll close this for now. One other place which is still O(N) is assembling the full document from the lines. Not sure if that's avoidable though -- in at least Neovim the buffer is stored as an array of lines according to this Reddit comment.


Enhancement for autocomplete & datepicker: allow for positionning the options/calendar panel elsewhere than next to the input

Bug, feature request, or proposal:
Proposal for enhancement for autocomplete & datepicker
What is the expected behavior?
Panel for autocomplete options or datepicker calendar can be positionned elsewhere than next to their related input field.
What is the current behavior?
Panel for autocomplete options or datepicker calendar cannot be positionned elsewhere than next to their related input field.
What are the steps to reproduce?

    <form [formGroup]="formStatus.form">

        <md-input-container>
          <input mdInput placeholder="Address" [mdAutocomplete]="auto" formControlName="address">
        </md-input-container>

    </form>

    <md-autocomplete #auto="mdAutocomplete" [displayWith]="addressFormatter">
      <md-option *ngFor="let address of addresses | async" [value]="address">
        {{ address.description }}
      </md-option>
    </md-autocomplete>

What is the use-case or motivation for changing an existing behavior?
Autocomplete and datepicker usage will be more flexible
Which versions of Angular, Material, OS, TypeScript, browsers are affected?
Angular material: 2.0.0-beta.6
If I am wrong and this feature is currently available, maybe a update to the documentation would be worthwhile.

Got the same with 2.0.0-beta.7

Seems like this could be useful for a search like inbox's

For a start, I would be happy to deactivate the automatic positioning based on space. Like having an option for positioning:

auto: Current behavior
bottom: force to always show below the input field
top: force to always show above the input field
custom: What this whole issue ticket is suggesting

It's ugly, but for anyone else who is desperate for a workaround you can cast to any then overwrite your instance's MatAutocompleteTrigger._getOverlayPosition() and MatAutocompleteTrigger._getHostWidth() functions in ngAfterViewInit (assuming the autocomplete trigger is not destroyed until the host component is destroyed too).
    constructor(
        private hostEl: ElementRef
    ) {}

    public ngAfterViewInit(): void {
        (<any>this.autocompleteTrigger)._getOverlayPosition = () => this.getAutocompleteOverlayPosition();
        (<any>this.autocompleteTrigger)._getHostWidth = () => this.getAutocompleteHostWidth();
    }

    private getAutocompleteOverlayPosition(): PositionStrategy {
        const trigger = this.autocompleteTrigger as any;
        trigger._positionStrategy = trigger._overlay.position().connectedTo(
            this.hostEl,
            {originX: 'start', originY: 'bottom'}, {overlayX: 'start', overlayY: 'top'}
        ).withFallbackPosition(
            {originX: 'start', originY: 'top'}, {overlayX: 'start', overlayY: 'bottom'}
        );
        return trigger._positionStrategy;
    }

    private getAutocompleteHostWidth(): number {
        return this.hostEl.nativeElement.getBoundingClientRect().width;
    }

@benelliott we tried this solution but it didn't fix the issue. Did this work for you?

@dhatawesomedude Yes, but it assumes you want to attach the panel to the host element. What didn't work for you?

The latest version of angular material's autocomplete has the feature described above. See: https://material.angular.io/components/autocomplete/overview#attaching-the-autocomplete-panel-to-a-different-element
I am not sure about the datepicker though. Can anyone let us know if this is planned for the datepicker?

@benelliott  you're the man! With your code I succeed in forcing autocomplete to always open down.
I just have a minor issue: when ngAfterViewInit triggers, my autocomplete still undefined causing me an error. But it works as I intend it to, thanks again!


Broker API: Funding - Transfers

This is to implement the routes found here
Need to add to BrokerClient:
  def create_transfer_for_account(
          self,
          account_id: Union[UUID, str],
          transfer_data: CreateTransferRequest,
  ) -> Transfer:
      pass

  def get_transfers_for_account(
          self,
          account_id: Union[UUID, str],
  ) -> List[Transfer]:
      pass

  def cancel_transfer_for_account(
          self,
          account_id: Union[UUID, str],
          transfer_id: Union[UUID, str],
  ) -> None:
      pass

take


client.go: HybridVSockDialer: Close dup fd after receive packet

kata runtime jenkins-ci-ubuntu-1804-firecracker always failed when agent
of vendor is updated to new version in
https://github.com/kata-containers/runtime/pull/2285.
This test passed after added code to close dup fd after receive packet
in http://jenkins.katacontainers.io/job/kata-containers-runtime-ubuntu-1804-PR-firecracker/1339/.
Fixes: #703
Signed-off-by: Hui Zhu<EMAIL_ADDRESS>

/test


Add api/log endpoint

We need to add the api/log endpoint, along with start and count paramters.

api added from version 10.0.18


Automatically downloaded toolchains massively slow down the build (possibly only on Linux, otherwise only on CI)

Apologies for a very rough description, but the issue may be serious so filing as best I can.
Expected Behavior
Build performance should be the same, except for an initial download period, whether a toolchain is automatically downloaded or not.
Current Behavior
Build performance tanks when setting toolchains for tests and having it automatically download the toolchains.
Context
We have recently been suffering from extremely slow builds in our large repository. We eventually realized that it is a problem with automatically downloaded toolchains that doesn't happen with provided ones. I had incorrectly used -D instead of -P to set the paths, fixed in
https://github.com/open-telemetry/opentelemetry-java-instrumentation/pull/1775
Before that, even if a build was fully cached, the build would take 30min instead of 5min. We can see two here
Preloaded JDK - https://scans.gradle.com/s/frbajdj3zfyr6/timeline?anchor=qnx7l7tpz5l2i
Downloaded JDK - https://scans.gradle.com/s/v6cux6ukulbdq/timeline?anchor=ukxmf7budwyhy
The automatically downloaded JDK was only used for test tasks.
Notably, with the downloaded JDK, all test FROM-CACHE hits take around 30s for "Fingerprinting inputs". On other builds, they take less than 1s. And after fixing our configuration problem, this behavior went away. We finally found the configuration issue because we noticed in the network tab of the build scan that it was downloading JDK.
While we could expect even a few minutes of extra time taken in the beginning for a downloaded JDK, in our case the difference was 5min to 30min for fully cached build, and 30min to 2hour for non-cached build.
Build scans for extremely slow, mostly non-cached builds
Preloaded JDK: https://gradle.com/s/x3ri24ow3ni6o
Downloaded JDK: https://scans.gradle.com/s/wtvetc5j2wmnw
Steps to Reproduce
I don't know a good way to reproduce this unfortunately. Our configuration is here
Gradle:
https://github.com/open-telemetry/opentelemetry-java-instrumentation/blob/master/gradle/java.gradle#L204
GitHub workflow:
https://github.com/open-telemetry/opentelemetry-java-instrumentation/blob/91a9e1885ea6a54d457173420eb249f0099ed26f/.github/workflows/nightly.yaml#L79
(notice the typo of -D instead of -P)
On my Mac, tests always use a downloaded JDK and there's no added slowness. I don't have Linux handy to try there, it might be Linux-only and if so, easy to repro there. If running locally, can use ./gradlew test -PtestJavaVersion=15, unless your default JDK is Java 15 in which case you would change that to any other version to have it register the launcher.
The only way I know of reproducing this right now is by forking https://github.com/open-telemetry/opentelemetry-java-instrumentation/commit/91a9e1885ea6a54d457173420eb249f0099ed26f  and pushing commits to master to trigger the build on GitHub. GitHub actions will run and demonstrate the slowness.
We have many builds over the past week we've had this issue with build scan links in case they can help - https://github.com/open-telemetry/opentelemetry-java-instrumentation/actions
Your Environment
GitHub Actions, ubuntu-latest runner, Java 11 build toolchain (provided by OS), Java 15 test launcher (downloaded by Gradle), Gradle 6.7.1

Thanks, @anuraaga for the detailed description, steps to reproduce, and the build scans. I finally found the reason why the fingerprinting was taking so long on your builds. Toolchains are used as task input for the various compile/test tasks (major version and more information in 6.8). But due to a bug, we re-provisioned the downloaded toolchain again when checking the inputs from a task. We didn't download it again (that's why it doesn't show up in the network tab in the scan) but we just unzip the whole jdk again.
The fix will be in 6.8 RC2 (to be released in the next few days). At this stage, I don't think we'll backport this to 6.7.x as there is an easy workaround. In case you're curious to try it out, I quickly hacked together the changes needed for upgrading to 6.8 on a fork of your project.


Cache schema and document loading result

Outdated since https://github.com/dotansimha/graphql-code-generator/pull/7344


'regex string' fixups

Renamed regexp to regex (matching python docs, and regexp in method names is deprecated in unittest).
Altered regex example to encourage creation of meaningful Parameter subclasses.
Added string and regex values to the failure-to-match error message.

Coverage remained the same at 76.354% when pulling a86d4a2adc888f52e4c4012c53a9a6092853eb66 on string_regex_fixups into dd9491ec4e854cf6a2c2b0c66cda6ac2bee109df on master.


Vertical monitor. Output rotation

Hi. I'm new sway uses and maybe miss something, but is there support for vertical monitors? I.e. can I setup rotation for the output?

Seems, upstream issue https://github.com/Cloudef/wlc/issues/86

This is supported in wlroots, so when sway eventually gets ported over to that, rotation will be supported.


Playing music over Bluetooth can be choppy

I've always used a 3.5mm cable in the past for reliability, but have recently been using Bluetooth to play music to a couple of different stereo systems. This has exhibited some strange behaviour in regard to choppy music that seems to differ on each:

With my Mum's car:

Music is sometimes briefly choppy
When choppiness occurs, turning the screen on seems to reduce it

With my mate's Bluetooth speaker:

Music is unlistenable - choppy every few seconds
Neither proximity nor turning the screen on seem to make a difference

With my parents' camper van:

Sometimes disconnects and then reconnects like a minute later
Seems to consistently pause a couple of minutes into a trip (roughly equivalent to the length of a song)

In case it makes a difference, this was with Spotify, and a Pebble connected also.
Device: Cosmo Communicator
Android build number: Cosmo-9.0-Planet-02032021-V25

@wovoja Did you mean to post that comment on https://github.com/shymega/planet-devices/issues/38?


postgres library built as static would not install unless also buildi…

postgres library built as static would not install unless also building shared version

Nice catch :+1:
@mloskot it was fixed on master with 4fab0bb33a0593f0e78a3443d57b9529403a9b93


Add dynamic sidecar tasks

Adds a new task type: dynamic_sidecar_task, that allows for running dynamic tasks with custom pod specs.
Type

[ ] Bug Fix
[x] Feature
[ ] Plugin

Are all requirements met?

[x] Code completed
[x] Smoke tested
[x] Unit tests added
[x] Code documentation added
[ ] Any pending items have an associated Issue

Complete description
The new class SdkDynamicSidecarTask is a hybrid of the dynamic and sidecar tasks. The core logic in SdkDynamicTask was moved into a mixin (SdkDynamicTaskMixin) that was then used as a base in SdkDynamicTask and SdkDynamicSidecarTask respectively. SdkDynamicSidecarTask allows us to use the same mechanisms for specifying custom pod specs in sidecar_tasks for dynamic_tasks as well!
Tracking Issue
https://github.com/lyft/flyte/issues/
Follow-up issue
NA

Codecov Report

Merging #152 into master will decrease coverage by 0.02%.
The diff coverage is 58.82%.

@@            Coverage Diff             @@
##           master     #152      +/-   ##
==========================================
- Coverage   80.88%   80.85%   -0.03%
==========================================
  Files         225      225
  Lines       14669    14683      +14
  Branches     1204     1205       +1
==========================================
+ Hits        11865    11872       +7
- Misses       2521     2528       +7
  Partials      283      283

Impacted Files
Coverage Δ

flytekit/sdk/tasks.py
71.26% <16.66%> (-4.05%)
:arrow_down:

flytekit/common/tasks/sidecar_task.py
79.24% <60.00%> (-2.01%)
:arrow_down:

flytekit/common/tasks/sdk_dynamic.py
96.39% <100.00%> (+0.10%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8d557a0...36f25a7. Read the comment docs.

@jeevb this is actually pretty cool and explains that our interface for task construction is incorrect.
I think it should be
@task(type=Sidecar(pod_spec=...), dynamic=True, ....)
def func(...):

@kumare3: I like where you are going with that, but it isn't clear to me how it will play with other task types like @spark_task though. It does make sense for @python_task and @sidecar_task.

@jeevb it will be the same
@task(type=Spark(spark_conf=...), resources=...)

But also we dont have to use it for all task types, some task types may have dedicated decorators (I really want to avoid that, to simplify the design language)

Ah I see. That makes sense!

let me run this through our other tests tomorrow morning before merging.


Use with onGenerateRoute

As same as issue title, can I use this package with onGenerateRoute?

As long as you place DoubleBackToCloseApp in the initial route, there should be no problem. Please let me know if you have any.


How did you merge the multi-objects masks results in DAVIS17？

The model predicted masks of objects in the same image separately.
However, for the multi-objects in the same image, we need merge the results.
I wonder that how did you merge the multi-objects masks results in DAVIS17？
Please tell us some details.
Thank you!

I get an Index error when trying to run davis model test. After debugging I found that for obj_id = 4 in “india” video the input_ids list is empty therefore indexing using choice_sent is invalid.
Did you have the same issue ? How did you solve it ?


Allows removing existing swap from a CSV fact

This allows us to work around on a system where stringify facts is true
We instead make a CSV of swapfile paths and sizes, split by ||
We have a function to return if the swapfile exists in the CSV string, and if it does, what is the size of the existing swapfile in KB
Updates acceptance test to actually test the new functionality

@acjohnson can you test this works for you? In my acceptance tests it works with stringify_facts = true, so should work for you 👍

@petems just letting you know I am testing this now, looks like you've merged already so I'll just test the master branch.

Awesome! Sorry I merged because I'm trying to get all my 2.X features in before I jump to the 3.X release with the type and providers for swap instead of execs.
If there's any problems, raise an issue and I'll get it fixed 😄

I just tested and it appears working. I am going to use tag v2.4.1 on our openstack instances. Thanks!

Awesome! Glad it works, v2.4.1 or v2.4.0 will work, v2.4.1 is just an update to the changelog: https://github.com/petems/petems-swap_file/compare/v2.4.0...v2.4.1


New Release

We’ve updated dependencies on our side with the zxlib:

Fix reported issue https://github.com/cosmos/ledger-cosmos/issues/125.

We are also adding an extra buffer check and improving error propagation of a function.


text above is blurry

I trained with my own data, and for some textures The text above is blurry. Some results are acceptable. What can I do to improve in cases of blurriness?

I encountered the same problem.

hi, how do you preprocess your own data? Specifically, how did you get the 'Mask' folder?


[FR]: Press Enter to open folder note in File Explorer

Now that Obsidian allows for keyboard navigation inside the File Explorer it would be great if created Folder Notes would be accessible by pressing Enter whilst traversing the File Explorer with keyboard.
Great Plugin :)

Enter, or Shift+Enter would be great. +1 for this FR
@Glint-Eye, a workaround for now is: (even with the Hide Folder Notes option turned on)

expanding the folder with → key, and then pressing ↓ once, so that the focus is on the hidden div which contains the folder note, then pressing Enter


Remove impl_outer_ macros

Those macro are no longer used, people should rather use construct_runtime, it is some code debt when implementing new functionality in substrate (e.g. metadata changes).

farewell macro rules

bot merge


Document exceeds maximum length.

# cat error.log | haste
failure uploading: {"message":"Document exceeds maximum length."}

any solution or run my own server only?

It has to do with a configuration option on the Haste server.
If you have your own server you can change this behavior in config.js
As for a workaround, you could split the file into multiple parts then upload each one of them individually (manually or automated) and then collect the URLs given back to you.


Replace throughput test with locust

see https://github.com/Microsoft/Recommenders/blob/gramhagen/load_test/notebooks/05_operationalize/aks_locust_load_test.ipynb

Adressed in #20


MenuAnchor controller open method bugs in scrollable widgets

Steps to reproduce

Take code from second example at https://api.flutter.dev/flutter/material/MenuAnchor-class.html
Create ListView from MenuAnchors (and remove shortcuts)
Scroll down, so bottom item is barely visible
Click rmb on it at positon that menu is unable to open down from it

Expected results
If I click rmb on bottom item, and menu doesn't fit vertically - it opens at the top of an mouse click
Maybe https://github.com/flutter/flutter/issues/122129 can fix this, maybe not
Actual results
If I click rmb on bottom item, and menu doesn't fit vertically - it opens at the top of an item

Code sample
Code sample
import 'package:flutter/foundation.dart';
import 'package:flutter/material.dart';
import 'package:flutter/services.dart';

enum MenuEntry {
  about('About'),
  showMessage(
      'Show Message', SingleActivator(LogicalKeyboardKey.keyS, control: true)),
  hideMessage(
      'Hide Message', SingleActivator(LogicalKeyboardKey.keyS, control: true)),
  colorMenu('Color Menu'),
  colorRed('Red Background',
      SingleActivator(LogicalKeyboardKey.keyR, control: true)),
  colorGreen('Green Background',
      SingleActivator(LogicalKeyboardKey.keyG, control: true)),
  colorBlue('Blue Background',
      SingleActivator(LogicalKeyboardKey.keyB, control: true));

  const MenuEntry(this.label, [this.shortcut]);
  final String label;
  final MenuSerializableShortcut? shortcut;
}

class MyContextMenu extends StatefulWidget {
  const MyContextMenu({super.key, required this.message});

  final String message;

  @override
  State<MyContextMenu> createState() => _MyContextMenuState();
}

class _MyContextMenuState extends State<MyContextMenu> {
  MenuEntry? _lastSelection;
  final MenuController _menuController = MenuController();
  ShortcutRegistryEntry? _shortcutsEntry;
  bool _menuWasEnabled = false;

  Color get backgroundColor => _backgroundColor;
  Color _backgroundColor = Colors.red;
  set backgroundColor(Color value) {
    if (_backgroundColor != value) {
      setState(() {
        _backgroundColor = value;
      });
    }
  }

  bool get showingMessage => _showingMessage;
  bool _showingMessage = false;
  set showingMessage(bool value) {
    if (_showingMessage != value) {
      setState(() {
        _showingMessage = value;
      });
    }
  }

  @override
  void initState() {
    super.initState();
    _disableContextMenu();
  }

  @override
  void didChangeDependencies() {
    super.didChangeDependencies();
    // Dispose of any previously registered shortcuts, since they are about to
    // be replaced.
    _shortcutsEntry?.dispose();
    // Collect the shortcuts from the different menu selections so that they can
    // be registered to apply to the entire app. Menus don't register their
    // shortcuts, they only display the shortcut hint text.
    final Map<ShortcutActivator, Intent> shortcuts =
        <ShortcutActivator, Intent>{
      for (final MenuEntry item in MenuEntry.values)
        if (item.shortcut != null)
          item.shortcut!: VoidCallbackIntent(() => _activate(item)),
    };
    // Register the shortcuts with the ShortcutRegistry so that they are
    // available to the entire application.
  }

  @override
  void dispose() {
    _shortcutsEntry?.dispose();
    _reenableContextMenu();
    super.dispose();
  }

  Future<void> _disableContextMenu() async {
    if (!kIsWeb) {
      // Does nothing on non-web platforms.
      return;
    }
    _menuWasEnabled = BrowserContextMenu.enabled;
    if (_menuWasEnabled) {
      await BrowserContextMenu.disableContextMenu();
    }
  }

  void _reenableContextMenu() {
    if (!kIsWeb) {
      // Does nothing on non-web platforms.
      return;
    }
    if (_menuWasEnabled && !BrowserContextMenu.enabled) {
      BrowserContextMenu.enableContextMenu();
    }
  }

  @override
  Widget build(BuildContext context) {
    return Padding(
      padding: const EdgeInsets.all(50),
      child: GestureDetector(
        onTapDown: _handleTapDown,
        onSecondaryTapDown: _handleSecondaryTapDown,
        child: MenuAnchor(
          controller: _menuController,
          menuChildren: <Widget>[
            MenuItemButton(
              child: Text(MenuEntry.about.label),
              onPressed: () => _activate(MenuEntry.about),
            ),
            if (_showingMessage)
              MenuItemButton(
                onPressed: () => _activate(MenuEntry.hideMessage),
                shortcut: MenuEntry.hideMessage.shortcut,
                child: Text(MenuEntry.hideMessage.label),
              ),
            if (!_showingMessage)
              MenuItemButton(
                onPressed: () => _activate(MenuEntry.showMessage),
                shortcut: MenuEntry.showMessage.shortcut,
                child: Text(MenuEntry.showMessage.label),
              ),
            SubmenuButton(
              menuChildren: <Widget>[
                MenuItemButton(
                  onPressed: () => _activate(MenuEntry.colorRed),
                  shortcut: MenuEntry.colorRed.shortcut,
                  child: Text(MenuEntry.colorRed.label),
                ),
                MenuItemButton(
                  onPressed: () => _activate(MenuEntry.colorGreen),
                  shortcut: MenuEntry.colorGreen.shortcut,
                  child: Text(MenuEntry.colorGreen.label),
                ),
                MenuItemButton(
                  onPressed: () => _activate(MenuEntry.colorBlue),
                  shortcut: MenuEntry.colorBlue.shortcut,
                  child: Text(MenuEntry.colorBlue.label),
                ),
              ],
              child: const Text('Background Color'),
            ),
          ],
          child: Container(
            alignment: Alignment.center,
            color: backgroundColor,
            child: Column(
              mainAxisAlignment: MainAxisAlignment.center,
              children: <Widget>[
                const Padding(
                  padding: EdgeInsets.all(8.0),
                  child: Text(
                      'Right-click anywhere on the background to show the menu.'),
                ),
                Padding(
                  padding: const EdgeInsets.all(12.0),
                  child: Text(
                    showingMessage ? widget.message : '',
                    style: Theme.of(context).textTheme.headlineSmall,
                  ),
                ),
                Text(_lastSelection != null
                    ? 'Last Selected: ${_lastSelection!.label}'
                    : ''),
              ],
            ),
          ),
        ),
      ),
    );
  }

  void _activate(MenuEntry selection) {
    setState(() {
      _lastSelection = selection;
    });
    switch (selection) {
      case MenuEntry.about:
        showAboutDialog(
          context: context,
          applicationName: 'MenuBar Sample',
          applicationVersion: '1.0.0',
        );
      case MenuEntry.showMessage:
      case MenuEntry.hideMessage:
        showingMessage = !showingMessage;
      case MenuEntry.colorMenu:
        break;
      case MenuEntry.colorRed:
        backgroundColor = Colors.red;
      case MenuEntry.colorGreen:
        backgroundColor = Colors.green;
      case MenuEntry.colorBlue:
        backgroundColor = Colors.blue;
    }
  }

  void _handleSecondaryTapDown(TapDownDetails details) {
    _menuController.open(position: details.localPosition);
  }

  void _handleTapDown(TapDownDetails details) {
    if (_menuController.isOpen) {
      _menuController.close();
      return;
    }
    switch (defaultTargetPlatform) {
      case TargetPlatform.android:
      case TargetPlatform.fuchsia:
      case TargetPlatform.linux:
      case TargetPlatform.windows:
        // Don't open the menu on these platforms with a Ctrl-tap (or a
        // tap).
        break;
      case TargetPlatform.iOS:
      case TargetPlatform.macOS:
        // Only open the menu on these platforms if the control button is down
        // when the tap occurs.
        if (HardwareKeyboard.instance.logicalKeysPressed
                .contains(LogicalKeyboardKey.controlLeft) ||
            HardwareKeyboard.instance.logicalKeysPressed
                .contains(LogicalKeyboardKey.controlRight)) {
          _menuController.open(position: details.localPosition);
        }
    }
  }
}

class ContextMenuApp extends StatelessWidget {
  const ContextMenuApp({super.key});

  static const String kMessage = '"Talk less. Smile more." - A. Burr';

  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      theme: ThemeData(useMaterial3: true),
      home: Scaffold(
        body: ListView.builder(
          itemBuilder: (_, __) => MyContextMenu(message: kMessage),
        ),
      ),
    );
  }
}

void main() {
  runApp(ContextMenuApp());
}

Screenshots or Video
No response
Logs
Logs
MENU: Tapped Outside Instance of 'MenuController'
MENU: Closing children of _MenuAnchorState#81f1d
MENU: Opening _MenuAnchorState#cc67d at Offset(299.6, 54.6) with alignment offset Offset(0.0, 0.0)
MENU: Added:
MenuAnchor(focusNode: FocusNode#ad465(SubmenuButton(Text("Background Color"))), style: null, clipBehavior: hardEdge, alignmentOffset: Offset(0.0, -8.0), child: "Text("Background Color")")
├MenuItemButton(child: Text("Red Background"), shortcut: SingleActivator#e9998(keys: Control + Key R))
├MenuItemButton(child: Text("Green Background"), shortcut: SingleActivator#6834b(keys: Control + Key G))
└MenuItemButton(child: Text("Blue Background"), shortcut: SingleActivator#e1c46(keys: Control + Key B))

Flutter Doctor output
Doctor output
[✓] Flutter (Channel stable, 3.19.5, on macOS 14.4.1 23E224 darwin-arm64, locale en-RU)
    • Flutter version 3.19.5 on channel stable at /opt/homebrew/Caskroom/flutter/3.10.4/flutter
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 300451adae (5 days ago), 2024-03-27 21:54:07 -0500
    • Engine revision e76c956498
    • Dart version 3.3.3
    • DevTools version 2.31.1

[!] Android toolchain - develop for Android devices (Android SDK version 34.0.0)
    • Android SDK at /Users/geara0/Library/Android/sdk
    ✗ cmdline-tools component is missing
      Run `path/to/sdkmanager --install "cmdline-tools;latest"`
      See https://developer.android.com/studio/command-line for more details.
    ✗ Android license status unknown.
      Run `flutter doctor --android-licenses` to accept the SDK licenses.
      See https://flutter.dev/docs/get-started/install/macos#android-setup for more details.

[✓] Xcode - develop for iOS and macOS (Xcode 15.3)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Build 15E204a
    • CocoaPods version 1.15.2

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 2023.1)
    • Android Studio at /Users/geara0/Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 17.0.7+0-17.0.7b1000.6-10550314)

[✓] IntelliJ IDEA Ultimate Edition (version 2023.1.1)
    • IntelliJ at /Users/geara0/Applications/IntelliJ IDEA Ultimate.app
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart

[✓] VS Code (version 1.87.2)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.84.0

[✓] Connected device (2 available)
    • macOS (desktop) • macos  • darwin-arm64   • macOS 14.4.1 23E224 darwin-arm64
    • Chrome (web)    • chrome • web-javascript • Google Chrome 123.0.6312.87
    ! Error: Browsing on the local area network for iPhone HOME. Ensure the device is unlocked and attached with a cable or associated with the same local area network as this Mac.
      The device must be opted into Developer Mode to connect wirelessly. (code -27)

[✓] Network resources
    • All expected network resources are available.

! Doctor found issues in 1 category.

Thanks for the detailed report. I also can see the issue without a scrollable widget as below:

This seems to be similar to https://github.com/flutter/flutter/issues/122129. Keeping this open for other's thoughts.

flutter doctor -v (stable and master)
[✓] Flutter (Channel stable, 3.19.5, on macOS 14.1 23B74 darwin-x64, locale en-VN)
    • Flutter version 3.19.5 on channel stable at /Users/huynq/Documents/GitHub/flutter
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 300451adae (25 hours ago), 2024-03-27 21:54:07 -0500
    • Engine revision e76c956498
    • Dart version 3.3.3
    • DevTools version 2.31.1

[✓] Android toolchain - develop for Android devices (Android SDK version 34.0.0)
    • Android SDK at /Users/huynq/Library/Android/sdk
    • Platform android-34, build-tools 34.0.0
    • ANDROID_HOME = /Users/huynq/Library/Android/sdk
    • Java binary at: /Applications/Android Studio.app/Contents/jbr/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 17.0.9+0-17.0.9b1087.7-11185874)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 15.2)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Build 15C500b
    • CocoaPods version 1.15.2

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 2023.2)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • android-studio-dir = /Applications/Android Studio.app/
    • Java version OpenJDK Runtime Environment (build 17.0.9+0-17.0.9b1087.7-11185874)

[✓] VS Code (version 1.87.2)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.84.0

[✓] Connected device (3 available)
    • Pixel 7 (mobile) • 2B171FDH20084L • android-arm64  • Android 14 (API 34)
    • macOS (desktop)  • macos          • darwin-x64     • macOS 14.1 23B74 darwin-x64
    • Chrome (web)     • chrome         • web-javascript • Google Chrome 123.0.6312.86

[✓] Network resources
    • All expected network resources are available.

• No issues found!

[!] Flutter (Channel master, 3.22.0-2.0.pre.19, on macOS 14.1 23B74 darwin-x64, locale en-VN)
    • Flutter version 3.22.0-2.0.pre.19 on channel master at /Users/huynq/Documents/GitHub/flutter_master
    ! Warning: `flutter` on your path resolves to /Users/huynq/Documents/GitHub/flutter/bin/flutter, which is not inside your current Flutter SDK checkout at /Users/huynq/Documents/GitHub/flutter_master. Consider adding /Users/huynq/Documents/GitHub/flutter_master/bin to the front of your path.
    ! Warning: `dart` on your path resolves to /Users/huynq/Documents/GitHub/flutter/bin/dart, which is not inside your current Flutter SDK checkout at /Users/huynq/Documents/GitHub/flutter_master. Consider adding /Users/huynq/Documents/GitHub/flutter_master/bin to the front of your path.
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 0ee25923ae (2 hours ago), 2024-04-01 21:22:29 -0400
    • Engine revision 9a513de652
    • Dart version 3.5.0 (build 3.5.0-6.0.dev)
    • DevTools version 2.34.1
    • If those were intentional, you can disregard the above warnings; however it is recommended to use "git" directly to perform update checks and upgrades.

[✓] Android toolchain - develop for Android devices (Android SDK version 34.0.0)
    • Android SDK at /Users/huynq/Library/Android/sdk
    • Platform android-34, build-tools 34.0.0
    • ANDROID_HOME = /Users/huynq/Library/Android/sdk
    • Java binary at: /Applications/Android Studio.app/Contents/jbr/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 17.0.9+0-17.0.9b1087.7-11185874)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 15.2)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Build 15C500b
    • CocoaPods version 1.15.2

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 2023.2)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • android-studio-dir = /Applications/Android Studio.app/
    • Java version OpenJDK Runtime Environment (build 17.0.9+0-17.0.9b1087.7-11185874)

[✓] VS Code (version 1.87.2)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.84.0

[✓] Connected device (3 available)
    • RMX2001 (mobile) • EUYTFEUSQSRGDA6D • android-arm64  • Android 11 (API 30)
    • macOS (desktop)  • macos            • darwin-x64     • macOS 14.1 23B74 darwin-x64
    • Chrome (web)     • chrome           • web-javascript • Google Chrome 123.0.6312.87
    ! Error: Browsing on the local area network for iPad. Ensure the device is unlocked and attached with a cable or associated with the same local area network as this Mac.
      The device must be opted into Developer Mode to connect wirelessly. (code -27)

[✓] Network resources
    • All expected network resources are available.

! Doctor found issues in 1 category.

CC @QuncCccccc


Revert [gtk] Use TISCopyCurrentASCIICapableKeyboardInputSource()

In US-Keyboard with Japanese Input, cannot get keyboard layout data.
Please see my report detail
https://developercommunity.visualstudio.com/content/problem/104471/visual-studio-for-mac-720540-cannot-launch-exc-bre.html
Sorry, not test on my machine yet.
Building mono runtime is too heavy task...

Made another approach #45


Fix misspelling of JWT

JWT was spelled JTW.

@andrusch : Thanks for your contribution! The author(s) have been notified to review your proposed change.


HV-1251 Check that we don't use snapshot dependencies when we release

https://hibernate.atlassian.net/browse/HV-1251

Nice!


Video upload info returned

Figure out how to return video url when upload was successful when using react-cloudinary-upload-widget  package.

Needed to use the onSuccess property for the Widget component to call a function called successCallBack that returns a result. The url and path is returned to me successfully. So, now I can send it to my database when I have connected it to the React app.


foonathan-memory: init at 0.7.3

Description of changes
https://github.com/foonathan/memory
STL compatible C++ memory allocator library.
This package in other distros: https://repology.org/project/foonathan-memory/versions
Things done

Built on platform(s)

[X] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[X] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[X] Fits CONTRIBUTING.md.

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/prs-ready-for-review/3032/2654

Rebased and migrated to pkgs/by-name.


Duplicate files with ledger-secure-sdk

Following warning while compiling with updated ledger SDK
[WARNING] Found duplicate files in SDK and APP: base58.h swap_lib_calls.h swap_utils.h
Rename app files so that duplication is avoided.

It's probably worth checking if we can use Ledger's base58.h, swap_lib_calls.h and swap_utils.h instead.

Working on it.
On Wed, Feb 21, 2024, 9:59 AM Palmer Sébastien @.***>
wrote:

It's probably worth checking if we can use Ledger's base58.h,
swap_lib_calls.h and swap_utils.h instead.
—
Reply to this email directly, view it on GitHub
https://github.com/trilitech/ledger-app-tezos-baking/issues/32#issuecomment-1956286310,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/BCZ3ZOF75MNDAU4QPQGRMKTYUXAQNAVCNFSM6AAAAABDBIYBFWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNJWGI4DMMZRGA
.
You are receiving this because you authored the thread.Message ID:
@.***>


Can I ignore the hidden files while searching ?

When I make a document hidden, I don't want users to be able to search for it（like show in search result list）.
Hoping this feature can be supported in future versions~~~

maybe this solution will solve your problem click

Is it already supported？I tried but didn't work in V3~

please create a reproduction


[#2164]optimization client build path

at client, valid contextPath if need, and change build path user Paths. Done #2164

Make sure that:

[x] You have read the contribution guidelines.
[x] You submit test cases (unit or integration tests) that back your changes.
[x] Your local test passed mvn clean install -Dmaven.javadoc.skip=true.

Codecov Report

Merging #2170 (414f318) into master (c69d8d8) will decrease coverage by 0.73%.
The diff coverage is 6.66%.

@@             Coverage Diff              @@
##             master    #2170      +/-   ##
============================================
- Coverage     60.47%   59.73%   -0.74%
+ Complexity     4066     4035      -31
============================================
  Files           607      607
  Lines         18096    18097       +1
  Branches       1734     1733       -1
============================================
- Hits          10943    10810     -133
- Misses         6268     6405     +137
+ Partials        885      882       -3

Impacted Files
Coverage Δ

...alibaba/dubbo/AlibabaDubboServiceBeanListener.java
0.00% <0.00%> (ø)

...t/apache/dubbo/ApacheDubboServiceBeanListener.java
0.00% <0.00%> (ø)

...ient/springcloud/init/ContextRegisterListener.java
22.50% <0.00%> (+0.54%)
:arrow_up:

...enyu/client/tars/TarsServiceBeanPostProcessor.java
33.82% <0.00%> (-22.06%)
:arrow_down:

...cloud/init/SpringCloudClientBeanPostProcessor.java
73.01% <25.00%> (-2.40%)
:arrow_down:

...rg/apache/shenyu/admin/utils/ThreadLocalUtils.java
0.00% <0.00%> (-66.67%)
:arrow_down:

...apache/shenyu/admin/transfer/MetaDataTransfer.java
34.56% <0.00%> (-65.44%)
:arrow_down:

...ache/shenyu/client/tars/common/dto/TarsRpcExt.java
0.00% <0.00%> (-30.77%)
:arrow_down:

...ache/shenyu/plugin/grpc/cache/GrpcClientCache.java
64.70% <0.00%> (-29.42%)
:arrow_down:

...che/shenyu/sync/data/http/HttpSyncDataService.java
63.10% <0.00%> (-26.22%)
:arrow_down:

... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c69d8d8...414f318. Read the comment docs.

may be check-it is error,will re ci


momentum stopper

#96
Objects were keeping momentum on the server when paddle controllers were switched AI -> player.
(Taking control, waiting ~2mins without hitting anything still takes the paddle OOB)

(Taking control, waiting ~2mins without hitting anything still takes the paddle OOB)

Any idea what's causing this?

Same thing, but the client player does not move to sync the server paddle and it slowly slides OOB.

Ah, OK. Merging this!


Minor issue: Google analytics script should be in header

The analytics.html code is included from scripts.html which in return is included at the end of default.html. When you verify your site through google-analytics, you get a warning:

Move the tag inside the head.
We have detected that the Google Analytics tracking code is outside of the
section on this page. This decreases the likelihood that the tracking beacon will be sent before the user leaves the page.
One of the main advantages of the asynchronous snippet is that you can position it at the top of the HTML document. This increases the likelihood that the tracking beacon will be sent before the user leaves the page. We've determined that on most pages, the optimal location for the asynchronous snippet is at the bottom of the section, just before the closing tag.
Solution: Ensure that you add the Google Analytics tracking code onto this page before the closing tag.

Despite the fact that I really don't care, I wanted to report it for your information.

I'm aware. It's intentionally included near the closing </body> element to improve page loading performance.
I care more about potentially speeding up the page load for a visitor than Google Analytics being able to track a partial page load (the reason Google suggests placing in the head).

Yes, I suspected this but wasn't sure. Please close this issue then.

@mmistakes but the <script> element is async...

Google uses Google Analytics to verify domains, and it won't be able to do it because the script is in ~the wrong~ a different place:

Verification failed for [URL] using the Google Analytics method (84 days ago). The Google Analytics tracking code on your site is in the wrong location. You can verify site ownership with the asynchronous snippet placed in the  section of your home page. Learn more.


We need to check for Persiter class for post refresh

We need to check for Persister class for post refresh, since
the return value changed, we don't return Array anymore.

@miq-bot assign @agrare
@miq-bot add_label bug

@chessbyte is faster than @miq-bot :D

Great find, another reason I don't like the ambiguous if parsed.kind_of?(Array) implies its an inventory object refresh


fix(tabletoolbar): support carbon i18n strings

Closes #590

Summary

Add i18n support for some strings in the TableToolbar

Change List (commits, features, bugs, etc)

Add strings, default props, proptypes
Add function to properly pass the strings into the stock Carbon component
Refactor to use i18n object instead of one off variable names
Update story/knobs

Acceptance Test (how to verify the PR)

If you modify the default prop for these values in Table, you'll see the change in the UI.
You should be able to modify the strings via knobs, but I think we have so many knobs configured in the table i18n story, it doesn't render them all. This issue is in the production storybook, I've opened issue #602 for it.

🛑 Hold off on merging this, I'm going to push some additional i18n table fixes momentarily

@dennynguyen @bryancboyd please re-review. I've added the additional i18n strings that were missing so we can completely close #590 🎉

:tada: This PR is included in version 2.8.3 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Turn it into a PWA

Is your feature request related to a problem? Please describe.
A PWA can send push notifications to android smartphones
Describe the solution you'd like
Create a next.js app, and then use the pwa next.js package to build it
Describe alternatives you've considered
CRA with PWA, Svelte with PWA
Additional context
Make a custom install button

Done in #26


[Agent] 敏捷教练

systemRole
You are a professional Agile coach specializing in software engineering. You have a deep understanding of the Agile Manifesto and its principles, and are well-versed in Agile frameworks and methodologies such as Scrum, Kanban, XP (Extreme Programming), and SAFe (Scaled Agile Framework).Don't apologise unnecessarily. Review the conversation history for mistakes and avoid repeating them.
With extensive hands-on project experience, you can effectively apply theoretical knowledge to practice and solve real-world problems. You possess excellent communication and facilitation skills, capable of clearly articulating Agile concepts and values. You are a good listener who understands team needs and can effectively guide team discussions and decision-making processes.
You demonstrate outstanding problem analysis and solving abilities. By breaking down complex issues into manageable steps, you design feasible solutions. You excel at summarizing lessons learned and continuously improving processes.
Answer all my questions in Chinese.
identifier
agile-coach
avatar
👨🏫
title
敏捷教练
description
擅长软件工程的专业敏捷实践
tags
敏捷教练, 软件工程, 项目管理, 团队协作, 解决问题
locale
zh-CN

meta 信息和 systemrole 语种不符


Debugging support in Boogie

I am working on a project using Boogie for verifying distributed applications. In my work I am in need of a better debugging support when a verification fails.
I browsed through the command line options and have found the following options useful in my context:

\mv
\z3multipleErrors
\break
I tried them and have some issues/questions.

I will try to explain my issue through a trivial example. Below is a Boogie specification for incrementing a counter.
counter.bpl :::
var counter: int;
procedure increment(value: int)
modifies counter;
ensures (counter >= 0);
{
  assume(counter >= 0);
  counter := counter + value;
}

I am executing the command line as follows : Boogie.exe /z3multipleErrors /mv:counter.model counter.bpl
The result is :
Boogie program verifier version <IP_ADDRESS>016, Copyright (c) 2003-2014, Microsoft.
counter.bpl(10,1): Error BP5003: A postcondition might not hold on this return path.
counter.bpl(5,1): Related location: This is the postcondition that might not hold.
Execution trace:
    counter.bpl(7,3): anon0

Boogie program verifier finished with 0 verified, 1 error

and the model is :
counter.model:::
*** MODEL
%lbl%@82 -> false
%lbl%+37 -> true
%lbl%+45 -> true
counter -> 0
counter@0 -> (- 1)
value -> (- 1)
tickleBool -> {
  true -> true
  false -> true
  else -> true
}
*** END_MODEL

The counter example in this case is when the value to be incremented is -1 when counter is 0. But I would like to have more counter examples. So I have two questions here :

I expected the /z3multipleErrors option to give me multiple counter examples, in this particular case something like [counter = 0 & value = -1, -2, -3,..], [counter = 1 & value = -2, -3, ...] etc. Then I plan to use the set of values to get insights into the error, in this case value is negative. Am I missing something here?
Is the counter example the "minimal counter example"? I know this case is a trivial example, but I wish to know if I always get a minimal counter example.
Suppose I have a linked list which I am checking whether it is linear. As a counter example, I can have the following results:
1 -> 1 or 1 -> 2 -> 3 -> 4 ..... -> 1
Both are ideally counter examples, but the first one is a minimal counter example.

Now coming to the next stage of my issue.
The counter example is pretty comprehensible when the data types involved are simple. When I use maps or nested maps like below, the counter examples generated run into several pages and it is tiresome to try to understand it. I am giving a trivial example of a 2D matrix which has a constraint that all its elements should be non-negative.
matrix.bpl:::
var matrix: [int][int]int;
procedure modify(row:int, column:int, value: int)
modifies matrix;
ensures (forall r, c:int :: matrix[r][c] >= 0);
{
  assume(forall r, c:int :: matrix[r][c] >= 0);
  matrix[row][column] := matrix[row][column] + value;
}

matrix.model:::
*** MODEL
%lbl%@193 -> false
%lbl%+104 -> true
%lbl%+79 -> true
c@@0!0!0 -> 2
column -> 2
matrix -> |T@[Int][Int]Int!val!0|
matrix@0 -> |T@[Int][Int]Int!val!1|
r@@0!0!1 -> 1
row -> 1
value -> (- 563)
Store_[$int]$int -> {
  |T@[Int]Int!val!1| 2 (- 563) -> |T@[Int]Int!val!0|
  else -> |T@[Int]Int!val!0|
}
Select_[$int]$int -> {
  |T@[Int]Int!val!0| 2 -> (- 563)
  |T@[Int]Int!val!1| 2 -> 0
  else -> (- 563)
}
tickleBool -> {
  true -> true
  false -> true
  else -> true
}
Select_[$int][$int]$int -> {
  |T@[Int][Int]Int!val!1| 1 -> |T@[Int]Int!val!0|
  |T@[Int][Int]Int!val!0| 1 -> |T@[Int]Int!val!1|
  else -> |T@[Int]Int!val!0|
}
Store_[$int][$int]$int -> {
  |T@[Int][Int]Int!val!0| 1 |T@[Int]Int!val!0| -> |T@[Int][Int]Int!val!1|
  else -> |T@[Int][Int]Int!val!1|
}
*** END_MODEL

Ideally the inference here should be the same as the non-negative counter above, ie, the value should be non-negative. But understanding that information from this counter example requires a lot of effort.
I have two questions in this context:

Is there any on going effort in making the counter example comprehensible for non-expert users? I have seen the BVD interface, but I felt it a small beautification of the plain text model.
The description of the \break flag looks promising, but I see it is not yet implemented. It would be useful to know the status of that. Is there some work in progress?

Thank you for taking your time out to read this lengthy report. I would appreciate any help, even if it only addresses a small part of the question.
--
Sreeja.
PS: I had tried to send this to the mailing list. I got a notice indicating the decision is with the moderator and it was a week back.

Sorry for the (very) late response!

I expected the /z3multipleErrors option to give me multiple counter examples, in this particular case something like [counter = 0 & value = -1, -2, -3,..], [counter = 1 & value = -2, -3, ...] etc. Then I plan to use the set of values to get insights into the error, in this case value is negative. Am I missing something here?

The /z3multipleErrors option does not exist anymore, but I don't think it could have given you the kind of sophisticated error explanation you are looking for out of the box.

Is the counter example the "minimal counter example"?

No. Boogie processes whichever model the underlying theorem prover could produce.

Is there any on going effort in making the counter example comprehensible for non-expert users? I have seen the BVD interface, but I felt it a small beautification of the plain text model.

I'm not aware of any such effort.

The description of the \break flag looks promising, but I see it is not yet implemented. It would be useful to know the status of that. Is there some work in progress?

This is actually a legacy flag that should be removed. It has to do with attaching a debugger to the Boogie process (i.e., debugging Boogie itself, not debugging a Boogie program).


Warnings not shown

I have just updated Tslint and linter and my warnings from TsLint are no longer visible.
There is a yellow rectangle on the line where warning should appear, but I cannot access it.
How can I bring warnings back? (See the missing semicolumn)

Thanks!

I am unable to reproduce with linter-jshint, linter-eslint and atom-hack. You might wanna report this in that linter :)

@tomitrescak - I'm guessing that tslint has API depreciations that no longer work with atom v1.3. You'll have to stick with v1.2.4 until the tslint plugin is updated.

SideNote: The yellow rectangle is from atom's git diff, not from linter.

I'm having the same issue but with linter-jsonlint and linter-pylint. js-lint however works.
No deprications showing. Let me what info you want. Please be specific, I am not

I have same problem with linter-jsxhint on last OSX

Reinstal Atom, remove .atom/ don't fix it. linter-less works fine.

@mrakjos You didn't have to reinstall atom :stuck_out_tongue:
You could've just downgraded linter using apm install<EMAIL_ADDRESS>

Closing based on comment above.

Thank you @steelbrain. I downgraded linter to 1.2.4 painlessly using apm. I have been very impressed with Atom.