New version: GridapPETSc v0.2.0

Registering package: GridapPETSc
Repository: https://github.com/gridap/GridapPETSc.jl
Created by: @victorsndvg
Version: v0.2.0
Commit: 8a353c2599e1f4ec64b31aeb534394a66707a69e
Reviewed by: @victorsndvg
Reference: https://github.com/gridap/GridapPETSc.jl/commit/8a353c2599e1f4ec64b31aeb534394a66707a69e#commitcomment-37495966

This won't load without MPI installed (Same as  julia MPI package https://github.com/JuliaRegistries/General/pull/9831 )


Problem with dynamic routing and computed properties

Version
3.1.0-beta.3
Reproduction link
https://codesandbox.io/s/gracious-grothendieck-jbinu
Steps to reproduce
Just go DestinationDetails.vue and check why the dynamic routing param, coming from router/index.js cannot be passed to the computed property in the same component file.
What is expected?
Showing me how to fix the problem when it comes to dynamic routing
What is actually happening?
Hello! I'm watching currently this tutorial on
https://vueschool.io/courses/vue-router-for-everyone?friend=vuerouter#
about routing in Vue Js (I'm a newbie just to say), so everything was fine until I got this error
Uncaught (in promise) TypeError: Cannot read property 'name' of undefined
which was coming from the fact when the dynamic routing was set and the store.js (which is not in the sandbox, but I get the exact files from the course repo) was import; after that when a computed property was generated to find the exact element in the array coming from store.js, I got this error; also a warning that this is likely a Vue internals bug.
So I guess the mistake is coming from the computed properties and inability to generate one with a dynamic routing parameter like the id -
" computed: {
destination() {
return store.destinations.find(
(destination) => destination.id === this.destinationId
);
},
},
"
the course file are little bit differently structured but anyway I cannot solve the problem. I think the data is coming after it was being used; so the data is being used but it is not there yey (that's my guess); I've tried with mounted() to set new property on data() function but nothing. Hopefully someone will clear for me what is going on in here? Thanks in advance :)

Okay if someone is seeing something else, please post it in here!
The problem was (or I think that was the problem) that I use the strict operator (===) and the values which was coming from the router parameters was string; the id from store.js was an integer. So I when I use comparison operator (==) everything was fine!

I was using Vue 3, I just forgot to set the version in the sandbox. Sorry about that.


Rename --xkcdlang and --xkcdsep

Fixes #1506
RELEASE_NOTES=[CLEANUP] Rename xkcd generator options
Signed-off-by: Dominik Schulz<EMAIL_ADDRESS>

Codecov Report

Merging #1509 into master will decrease coverage by 0.07%.
The diff coverage is 77.78%.

@@            Coverage Diff             @@
##           master    #1509      +/-   ##
==========================================
- Coverage   60.96%   60.88%   -0.07%
==========================================
  Files         219      219
  Lines       12199    12212      +13
==========================================
- Hits         7436     7435       -1
- Misses       3940     3954      +14
  Partials      823      823

Impacted Files
Coverage Δ

internal/action/generate.go
56.76% <50.00%> (ø)

internal/action/commands.go
100.00% <100.00%> (ø)

internal/action/show.go
42.57% <0.00%> (-2.82%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9726700...f9d7ce4. Read the comment docs.


Login with Mail Address and LDAP fallback

Hello,
for internal user authentication we will use LDAP Adapter and for external users the Zend DB Adapter. All external users uses the mail address as username. Also with the LDAP Adapter we will use the email address as username. We have more external than internal users.

How could the login login scheme look like?
LDAP as Fallback Adapter?
But how can we make sense that the LDAP also uses the mail address for the login? (first LDAP search and then bind with dn?)

class AuthenticationService extends ZendAuthenticationService implements AuthenticationServiceInterface
{
    /**
     * Authentication fallback adapter
     *
     * @var AdapterInterface
     */
    private $fallbackAdapter = null;

    /**
     * @param AdapterInterface $adapter
     * @return $this
     */
    public function setFallbackAdapter(AdapterInterface $adapter)
    {
        $this->fallbackAdapter = $adapter;
        return $this;
    }

    /**
     * @return AdapterInterface
     */
    public function getFallbackAdapter()
    {
        return $this->fallbackAdapter;
    }

    /**
     * @param AdapterInterface|null $fallbackAdapter
     * @return Result
     */
    public function fallbackAuthenticate(AdapterInterface $fallbackAdapter = null)
    {
        if (!$fallbackAdapter) {
            $fallbackAdapter = $this->getFallbackAdapter();
        }

        return $fallbackAdapter->authenticate();
    }

    /**
     * @return mixed
     */
    public function getIdentity()
    {
        if ($this->hasIdentity()) {
            $user = parent::getIdentity();
        } else {
            $user = new UserEntity();
            $user->setId(0);
            $user->setUsername('Gast');
            $user->setRole('guest');
        }

        return $user;
    }

}

@heiglandreas

Regarding your 3rd Question: You should always first bind with a known user to the LDAP, then search for the user that tries to log in with the provided information and then (re)bind to the ldap with the DN of the found user and the provided password.
That way you are
a) LDAP-compliant and
b) have the possibility to use any (unique) attribute to identify a user.
I'm using that so users can use there email-address or their UID to log into the systems.
Have a look for a plain PHP-Implementation here

From what I've seen right now in Zend\Authentication\Adapter\Ldap that's not an LDAP-Adapter but an AD-Adapter (or an adapter where all users are known to be part of one subtree) as the described way of authentication via retrieve user after a bind with a privileged user doesn't seem to be supported… Or I'm missing it ATM…
So it looks to me as there's a complete authentication-adapter missing. And that's the one you're looking for…

I've hacked together a gist that might help you creating a solution. Take care, it's not been tested!!

This repository has been closed and moved to laminas/laminas-authentication; a new issue has been opened at https://github.com/laminas/laminas-authentication/issues/4.


[TODO] Resource id 5513 and 5853 conflicts

Do we need to put them in specificRid to work around?
Or ask the IPSO alliance to correct the conflicts?

IPSO Alliance has replied to this issue. It will be fixed soon.
Left this issue here, waiting for IPSO spec. revision.

2016/06/23
http://technical.openmobilealliance.org/Technical/technical-information/omna/lightweight-m2m-lwm2m-object-registry

In starter pack

In expansion pack

IPSO already fixed these conflicts. lwm2m-id also sync to it.


How to apply the neural network algorithm to FATE?

How to apply the neural network algorithm to FATE?Has anyone tried something like this?

we will support dnn in v1.1, which is released in September


Expose SQLite.export().

This is interesting. Can we clarify what the use case is, though? I can see how re-importing the same data is useful to show that it works, but besides the demo would you want to reuse that export on the same page? Or is it more—say—that you would use the page to edit a db, then click on a  button to download an export or save it to an asset server?

Maybe the better solution here would be to document how to access the underlying SQLite instance. I don’t think we want to create wrapper functions for everything that SQLite supports, especially if it’s not a use case we expect is common.

Can we clarify what the use case is, though?

🤔 I want to persist the SQLite database at the client by puling it out with export() and storing it somewhere, then pushing it back in with load().

would you want to reuse that export on the same page?

You're right, probably not the best way to show the example by using the same data on the same page.

Maybe the better solution here would be to document how to access the underlying SQLite instance. I don’t think we want to create wrapper functions for everything that SQLite supports, especially if it’s not a use case we expect is common.

My thinking was "if there is a load(), there should be a matching save()" 🤷 Happy to go with accessing SQLite directly for things like this 👍


Room - Room description is showing more spacing in Android but different in mweb.

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number: 1.4.42
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4318764
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:
Action Performed:

Launch app and mweb
Tap on a room report
Tap heade
Tap description
Enter # g
567
Tap save
Note the behaviour in app and mweb

Expected Result:
Room description in both android & mweb must be displayed with same spacing
Actual Result:
Room description is showing more spacing in Android but different in mweb
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[x] Android: Native
[x] Android: mWeb Chrome
[ ] iOS: Native
[ ] iOS: mWeb Safari
[ ] MacOS: Chrome / Safari
[ ] MacOS: Desktop

Screenshots/Videos
Add any screenshot/video evidence

https://github.com/Expensify/App/assets/78819774/6de3dc92-1921-44a6-b7ec-68274db635cd
View all open jobs on GitHub

@bz FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

We think that this bug might be related to #vip-vsp
CC @quinthar

We can close this to focus on more urgent issue, this is just a minor viewing discrepancy


We want to validate if the CPR or CVR consists of the correct amount of numeric values

When receiving a move-in request we want to validate if CPR and CVR consist of the correct amount of numeric values.
Because DH3 has "fake" CPR numbers we are not able to ensure uniqueness. As a minimum we want to validate the length of the numbers received.
Acceptance criteria

[x] A CPR number should consist of exactly 10 numeric values. If not a message with error code XX and error text XXX is sent

[x] A CVR number consist of exactly 8 numeric values. If not a message with error code XX and error text XXX is sent

[x] CPR numbers ending with 1111(fake) are treated as blanks (discuss with business)

[x] Add error text and code "D17" "Ugyldigt CPR/CVR nummer" "invalid customer number"

Tasks

[x] Create a new CustomerNumber value object, that handle all customer number variations (1 PED)
[x] Refactor RequestMoveIn to accept a CustomerNumber only. No need, to specifiy number type. (1 PED)
[x] Specify EDI error codes (1 PED)

Tested and done'et


Added kwargs to Excel UI process beads table.

See #222.

As of e1111cf, all unit tests pass:
> python -m unittest discover
........................................................................................................................................................................................................................................................................................
----------------------------------------------------------------------
Ran 280 tests in 5.213s

OK

Tested manually and was able to turn off subpopulation selection step:
FlowCal.excel_ui.process_beads_table(beads_table, instrument_table, plot=True)

yielded:

FlowCal.excel_ui.process_beads_table(beads_table, instrument_table, plot=True, get_transform_fxn_kwargs={'selection_fxn':None})

yielded:

(FL3 channel; top peak was being explicitly excluded in the input XLSX sheet)

Just to confirm, there are two peaks to the right being excluded in the second plot of your example. Are you explicitly excluding both?

Yep. This should be the Beads tab of the XLSX sheet for that plot:


Timeouts after script runs for about 15 mins

I get the following output after the script runs for about 15 mins:
Traceback (most recent call last):
  File "/usr/local/Cellar/python/3.7.0/Frameworks/Python.framework/Versions/3.7/lib/python3.7/urllib/request.py", line 1317, in do_open
    encode_chunked=req.has_header('Transfer-encoding'))
  File "/usr/local/Cellar/python/3.7.0/Frameworks/Python.framework/Versions/3.7/lib/python3.7/http/client.py", line 1229, in request
    self._send_request(method, url, body, headers, encode_chunked)
  File "/usr/local/Cellar/python/3.7.0/Frameworks/Python.framework/Versions/3.7/lib/python3.7/http/client.py", line 1275, in _send_request
    self.endheaders(body, encode_chunked=encode_chunked)
  File "/usr/local/Cellar/python/3.7.0/Frameworks/Python.framework/Versions/3.7/lib/python3.7/http/client.py", line 1224, in endheaders
    self._send_output(message_body, encode_chunked=encode_chunked)
  File "/usr/local/Cellar/python/3.7.0/Frameworks/Python.framework/Versions/3.7/lib/python3.7/http/client.py", line 1016, in _send_output
    self.send(msg)
  File "/usr/local/Cellar/python/3.7.0/Frameworks/Python.framework/Versions/3.7/lib/python3.7/http/client.py", line 956, in send
    self.connect()
  File "/usr/local/Cellar/python/3.7.0/Frameworks/Python.framework/Versions/3.7/lib/python3.7/http/client.py", line 1384, in connect
    super().connect()
  File "/usr/local/Cellar/python/3.7.0/Frameworks/Python.framework/Versions/3.7/lib/python3.7/http/client.py", line 928, in connect
    (self.host,self.port), self.timeout, self.source_address)
  File "/usr/local/Cellar/python/3.7.0/Frameworks/Python.framework/Versions/3.7/lib/python3.7/socket.py", line 727, in create_connection
    raise err
  File "/usr/local/Cellar/python/3.7.0/Frameworks/Python.framework/Versions/3.7/lib/python3.7/socket.py", line 716, in create_connection
    sock.connect(sa)
TimeoutError: [Errno 60] Operation timed out

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "spotify-restore.py", line 353, in <module>
    start_import()
  File "spotify-restore.py", line 312, in start_import
    id_ = add_playlist(li['name'])
  File "spotify-restore.py", line 209, in add_playlist
    f = urllib.request.urlopen(url, data=params)
  File "/usr/local/Cellar/python/3.7.0/Frameworks/Python.framework/Versions/3.7/lib/python3.7/urllib/request.py", line 222, in urlopen
    return opener.open(url, data, timeout)
  File "/usr/local/Cellar/python/3.7.0/Frameworks/Python.framework/Versions/3.7/lib/python3.7/urllib/request.py", line 525, in open
    response = self._open(req, data)
  File "/usr/local/Cellar/python/3.7.0/Frameworks/Python.framework/Versions/3.7/lib/python3.7/urllib/request.py", line 543, in _open
    '_open', req)
  File "/usr/local/Cellar/python/3.7.0/Frameworks/Python.framework/Versions/3.7/lib/python3.7/urllib/request.py", line 503, in _call_chain
    result = func(*args)
  File "/usr/local/Cellar/python/3.7.0/Frameworks/Python.framework/Versions/3.7/lib/python3.7/urllib/request.py", line 1360, in https_open
    context=self._context, check_hostname=self._check_hostname)
  File "/usr/local/Cellar/python/3.7.0/Frameworks/Python.framework/Versions/3.7/lib/python3.7/urllib/request.py", line 1319, in do_open
    raise URLError(err)
urllib.error.URLError: <urlopen error [Errno 60] Operation timed out>

Just saw the last few lines in your description, sorry.


chore(package): update eslint-plugin-jest to version 22.16.0

Closes #4

Codecov Report

Merging #21 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff          @@
##           master    #21   +/-   ##
=====================================
  Coverage     100%   100%
=====================================
  Files           1      1
  Lines          11     11
=====================================
  Hits           11     11

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 30f03e2...34b1ef3. Read the comment docs.


Feature request: add "optimize for" in the AutoML CLI

System information

OS version/distro: Windows 10 (but applies to any)
.NET Version (eg., dotnet --info): netcoreapp2.2

Issue

What did you do? Ran the AutoML CLI from powershell
What happened? It auto-trained as expected, but seemed to optimize just for accuracy. This isn't helpful when the data is highly skewed and I want to optimize for high precision or F1 score.
What did you expect? I was hoping to be able to specify what to optimize for just like I do when using this from C# and not the CLI.

The feature request is to add a command line flag to specify what to optimize for when running the AutoML CLI utility.

dup of #699


(feature) Configure webpack build process

What will we put in the dev config? What will we put in the production config?


Fixing broken paths in the BARRA replace land scripts and commenting out diagnostic printing.

The paths to the BARRA replace land scripts had become broken (missing "/" between directory names).
The paths have been fixed and diagnostic printing has been commented out at the same time.

@aidanheerdegen, good suggestion about adding in printing statements so that the job is not completely silent.
I will merge the pull request for the moment, then we can talk about possible debug and default printing statements.
Thank you for handling the pull request.


Move socket watch APIs into System::Layer

Problem
Transitionally, System::Layer operations are provided by a
configuration-specific WatchableEventManager, but they are not yet
sufficiently aligned to convert to abstract and implementation classes.
Part of #7715 Virtualize System and Inet interfaces
Change overview

Move socket event watch APIs into System::Layer.
Remove WatchableSocket and its include-file hack that allowed
implementation-specific state to be contained directly in EndPoints.
Revise the select() implementation to use an internal pool for watch
state in place of the EndPoint-embedded WatchableSocket.
Revise the libevent sample implementation to use libevent timers
directly instead of the System::Timer pool. The libevent
implementation uses STL containers with heap-allocated state for the
sake of being different from the select()-based implementation.
Added/moved documentation comments into headers.

Testing
CI; no change to functionality should is expected.

Note: the equivalent changes for LwIP configurations will be in a separate PR, to keep the size of each slightly smaller.

@saurabhst ?


Support for AWS ECR?

Hi,
is there support for AWS ECR? Couldn't really find documentation or figure out how to get it working...
ECR requires to generate an authorization token which changes every 12h.

Because the Docker CLI does not support the standard AWS authentication methods, you must authenticate your Docker client another way so that Amazon ECR knows who is requesting to push or pull an image. If you are using the Docker CLI, then use the docker login command to authenticate to an Amazon ECR registry with an authorization token that is provided by Amazon ECR and is valid for 12 hours.

http://docs.aws.amazon.com/AmazonECR/latest/userguide/Registries.html#registry_auth
http://docs.aws.amazon.com/AmazonECR/latest/userguide/docker-push-ecr-image.html

is there support for AWS ECR?

Not at the moment. We would love to support ECR, but haven't yet.

ECR requires to generate an authorization token which changes every 12h.

That's probably the biggest issue that we would need to work on, but in the meantime you can solve it by periodically re-generating config and then running fluxctl set-cofing -f flux-ecr-generated.confg.
To generate config, I would start with:
eval "$(aws ecr get-login)"
printf "registry: {auths: %s}" "$(jq -c .auths ~/.docker/config.json)"

How the above makes sense, I'd be happy to help if you jump on Slack and we can figure out how to update the docs and talk more about how we could make it easier for you.

Hi,
I gave it a go but run into following issues (AWS ID & repo names are fake...):
$ fluxctl list-images
Error: 500 Internal Server Error getting images for services: fetching image metadata for 123456789.dkr.ecr.eu-west-1.amazonaws.com/xyz: Get https://123456789.dkr.ecr.eu-west-1.amazonaws.com/v2/xyz/tags/list: http: non-successful response (status=401 body="Not Authorized\n")

It's definitely a valid login, the xyz repo name was fetched from aws ecr - so seems to work.
I noticed following different error with -n 10 added:
$ fluxctl list-images -n 10
Error: 500 Internal Server Error getting images for services: fetching image metadata for 123456789.dkr.ecr.eu-west-1.amazonaws.com/xyz: Get https://index.docker.io/v2/123456789.dkr.ecr.eu-west-1.amazonaws.com/xyz/tags/list: http: non-successful response (status=401 body="{\"errors\":[{\"code\":\"UNAUTHORIZED\",\"message\":\"authentication required\",\"detail\":[{\"Type\":\"repository\",\"Class\":\"\",\"Name\":\"123456789.dkr.ecr.eu-west-1.amazonaws.com/xyz\",\"Action\":\"pull\"}]}]}\n")

Seems to put together wrong urls.. trying to accidentally access docker.io under the hood?
-> https://index.docker.io/v2/123456789.dkr.ecr.eu-west-1.amazonaws.com/xyz/tags/list

@hartmut-pq could you please try the following:

refresh the token by re-running the commands I showed earlier
edit the config and make sure only *.amazonaws.com keys are present in auths object
check actual keys (based on what you shown above, the correct key should be 123456789.dkr.ecr.eu-west-1.amazonaws.com

As I said earlier, you are welcome to login to Weaveworks Slack and ping me (@ilya).

NB this work around will no longer work, since the credentials are needed by the daemon rather than the service. We'll have to build something into the flux daemon if we can -- as a stop-gap, it may be possible to add a sidecar container that does the credentials update (though we'd probably have to build in a flag to override where to look for credentials).

Does k8s (specifically kubelet) work with ECR? How?

Answering my own question: yes, it does.

Just to clarify, ECR is still not supported in flux right?
The error, for fellow debuggers is:

auth={map[]} err="requesting tags: Get https://.dkr.ecr.us-east-1.amazonaws.com/v2//tags/list: no basic auth credentials"

Correct. Hence this issue is still open.

For those affected by this limitation, check out this tool that lets you use imagePullSecrets for AWS credentials.  I was able to work around my issue by using it.

@corcoran How did you get this to work? I still get the "no basic auth credentials" error even though I'm using registry-creds and injecting the imagePullSecrets into the flux service account.

Flux doesn't try to access image secrets attached to its service account (maybe it should; but I'm not sure they are accessible to the processes inside the pod).
However, https://github.com/weaveworks/flux/pull/1065 could help. If you have a sidecar that can put the image creds into a volume, you can use --docker-config to tell flux to look there for credentials. @errordeveloper Want to try doing a worked example?

Here's a proof of concept I came up with for anybody who wants a workaround until this is natively supported. I'm just trialing a new deployment pipeline for my team's clusters so I want to iterate fast rather than fix the Go code right now.
https://github.com/mwhittington21/flux-ecr-example
Follow the instructions there and hopefully you can get it working. Thanks for all the tips above, helped me out a lot.

@mwhittington21 Nice! Looks like a good approach, thank you for posting here :100:

@mwhittington21 Your sidecar example works for me except on the refresh. A new cred file is loaded correctly into the flux container, but it doesn't seem like flux picks up the new credentials in the file?

Yeah unfortunately there is no way to get Flux to refresh the creds. I've moved to having a bash script that will kill Flux once every ~8 hours that runs as the entrypoint for the pod for now. It's not very pretty.
I would like to make a PR to add a Flux endpoint that will allow refresh of creds from file which would allow the sidecar to signal Flux to reload the config. Either that, or Flux could re-read the file after an auth error.
@tornadical you can see an example of this approach on the kill-every-8-hours-tmp-fix branch.

@mwhittington21 If flux just read the file every time it needed it, would that fix this problem?

@squaremo It looks that way from my perspective. The new cred file is loaded correctly each refresh into the flux container.

https://github.com/weaveworks/flux/pull/1230 makes it so that the credentials are read each time they're requested, rather than just at the start.

@squaremo Any guidance for someone who might want to submit a PR to build ECR support into Flux?

@squaremo Any guidance for someone who might want to submit a PR to build ECR support into Flux?

What kind of guidance are you after?
I have no particular design in my head for this. But I can pre-judge some approaches that might come up:

if it would involve baking an AWS CLI binary into the image, it's better done as a separate image that can be run as a sidecar (but perhaps this already exists? see the thread above)
if it's as simple as the GCP hack, then it could reasonably live alongside it

Hey guys,
as I was also facing that issue. I came with a simplified solution that works well for me. So I took away the part https://github.com/weaveworks/flux/issues/539#issuecomment-394588423 and adjusted it slightly by mounting a generated json file directly from the outside and pass it as argument to fluxd. So my question is would it be possible to add the docker.config parameter to the helm chart? Than you only need to generate the config-mapping or secret.
Cheers,
Thomas

What I can think of right now is to deploy a  private Docker Registry pod in the flux namespace that syncs to ECR via IAM roles.
Your deployment manifest will then just have to refer to the private Docker Registry repo without authentication.. like how Openshift do it.

Hi guys, I created ecr-k8s-secret-creator kubernetes service that automatically creates/updates a ECR config.json as a Flux Pod mounted kubernetes secret for me over time. Thanks to https://github.com/weaveworks/flux/pull/1065 for making this possible..

Great intel, thanks @errordeveloper. Yeah, we could start with just getting a token when we need it, and later try to refresh it on a schedule.
@jml ^ Ilya has answered your question better than I could :-)

+1

I followed the solution suggested by @bzon - that is, deploying the pod ecr-k8s-secret-creator  in conjunction with editing Weave Flux deployment via  kubectl edit deployment weave-flux-agent and using the created secret as a docker volume in the Flux pod along with adding --docker-config argument to the container. But, I notice that the pod spec for the agent keeps getting updated automatically which results in the removal of the --docker-config flag. The other edits I made such as mounting the secret created ecr-k8s-secret-creator as a volume appear to stick. What is causing this and what is the solution?


Error sound effect doesn't play in multiplayer

Versions
Minecraft: 1.18.2
Forge: 40.0.34
Hex: Commit 767dd99
Paucal: Commit 8f64bef
Issue
It simply doesn't play if you're in multiplayer.
Any error that would've played the sound effect (missing args, couldn't match pattern to iota, etc) doesn't play the sound effect.
Encountered this on the patron server.

can't reproduce?

It probably has something to do with the Hex version mismatch between client and server, so it'll probably resolve itself when the server's updated.

Any word on this?

I've observed the sound working on Blanketcon so I'm gonna close this.


dotfiles in test dir cause a panic

Prerequisites

[X ] Can you reproduce the problem?
[X ] Are you running the latest version?
[X ] Did you perform a cursory search?

Description
Using latest release on macos, the --dir tests cause the binary to panic because a non-yaml file, .DS_Store, exists in the directory. This also happens if there's a .gitignore or .gitattributes file present.
Steps to Reproduce

Create a testing dir
add a non-yaml dotfile to the directory
test using --dir
observe the binary panic

Expected behavior: the binary should skip hidden files
Actual behavior: the binary does not skip hidden files, and panics
Specifications

Version: 2.5.0
Platform: All

thanks to @jscottsf for pointing out this bug to me


optimize: decrease gradient tolerance

I have seen multiple complaints (both in the survey and offline) that the optimize solver "is not robust". Likely the problem with this is that the default tolerance is quite high, and small floating point noise destroys the linesearch. We can document that people should set their tolerance, but that doesn't mean they'll listen. The current default is the way it is for two reasons:

I feel/felt that by default optimize should find the optimum, not something kind of close
There is trickiness with specifying the default behavior of the setting. We don't want the setting to be used if it's a gradient-free function. We also typically do not want such a setting for global optimizers (otherwise you're stopping at the first local minimum found which defeats the point).

Given the usability problems, I'm probably in the minority on point 1, and we should change it. An equally valid argument is that the default case should do what's best for most people, and advanced users can set their own settings. A default tolerance of 1e-4 or 1e-6 is probably good enough for most cases, and it will have the practical effect of reducing the default number of function calls which is nice.
On point 2: It seems reasonable, again, that the default case work well. In particular, the default case is to choose a local method where the setting is useful. Second, the most common case for global optimization algorithms is to be gradient-free (including all of the ones we currently implement), so this won't affect users choosing the standard algorithms. It seems reasonable to treat someone using a gradient-based global optimization method as a "sufficiently advanced" user to expect them to set a setting.
It would be nice if there was a way to "always do the right thing", but I don't see how to do so. Maybe if we have a way for the Method to communicate that the gradient tolerance doesn't need to be checked, but I don't see a clean way to do that.

I don't know gonum optimization algorithms (I am just search the web for some mathy project for practicing go) but perhaps the following:
a.) For larger instances, there will be so many accumulated floating-point errors that some tolerances will be unreasonable. It would be per possible per algorithm to estimate for an instance so lower bound on the default tolerance and then set a bit higher.
b.) If an algorithm can return data needed for a warm start, then the user can restart the algorithm with stricter tolerance if desired.


chore(switch): add micro perf benchmarks for switch operator

Merged with b9b58cc... thanks @jinroh!


Multiple Replicas

I recently tried scaling the registry up to increase throughput and redundancy but after doing so pushes started to fail with blob upload unknown. It appears there is some internal state while a push is on-going. To fix the issue, I set sessionAffinity: ClientIP on the deis-registry service. Any reason this would be a bad idea? If not, I can post a pull request adding it to the service template so scaling works out of the box.

@croemmich I'd say if this solution is working for you, a PR would definitely be welcome for us to test out; haven't yet experimented with multiple registry replicas here.

Hey!
So just for context, this repo is just a few wrapper scripts around the upstream docker registry. I noticed there's a few issues related to "blob upload unknown": https://github.com/docker/distribution/search?q=blob+upload+unknown&type=Issues&utf8=✓. I'd suggest starting there and see if there's anything actionable upstream before we start pinning tails on the donkey.

@bacongobbler, from what I can tell looking through the issues is that there is generally an issue with distributed file stores like S3, Swift, GCS. The layer is written to a storage node, but isn't immediately available if your next request hits a different node, which is probable. When the registry tries to read back the layer meta for a consistency check a 404 is thrown if the node does not yet have the file. The S3 and Swift drivers have a wait function that polls for the segments to show up before continuing. The GCS driver, which I'm using, does not.
It would appear there is some cache internal to the registry that knows about the previously uploaded layers and allows the next to be pushed without a check to the storage backend. My workaround solves the issue by relying on that cache. Ideally the issue would be fixed upstream, but the required polling fix is pretty dirty. I'd recommend the sessionAffinity: ClientIP fix for the time being, as it fixes the issue with GCS immediately and I suspect it will slightly increase the performance of image uploads to S3 and Swift as they won't have to poll for layers. The downside is that concurrent reads and writes from the same Kube node are not scaled, but with a single replica, that's the case anyways. It does still provide high(er) availability and fast failover which was my main concern.

If you feel like hacking up a PR, that would be wonderful.

@bacongobbler, PR created, sorry for the delay.


Update dep latest github.com/swagger/gin-swagger

Describe the PR
update gin-swagger to the latest version
Relation issue
gin-swagger#131

@easonlin404 @ubogdan Would it be possible to maybe get an ETA when next tag will arrive with this change?

@ffenix113 since 1.6.9 was released 10 days ago, I don't think it will happen too soon.
On the other hand, every release should come with a set of fixes and features.


Actually get height from table cell

FIX #217.

Hello - What's changed here? Is this a bug fix or a new feature? Thanks

Before this commit height was never respected:
height = None
    if height is not None:

This surely looks like a bug but am not enough familiar with source code to be 100% sure.

Ha - well I definitely notice that table rows now don't default to being really tall, which is great.


Inconsistent attribute naming of eagerly loaded polymorphic relation

Hello,
The attribute names of eagerly loaded polymorphic relationships are using snake casing, while other relationships (e.g., BelongsTo) are named in camel casing fashion. Example:
class Payment extends Model
{
    public function paymentProfile()
    {
        return $this->belongsTo(PaymentProfile::class);
    }

    public function paymentDetails()
    {
        return $this->morphTo();
    }
}

Behaviour:
$payment = Payment::with('paymentProfile', 'paymentDetails')->first();

var_dump($payment->paymentProfile); // PaymentProfile instance

var_dump($payment->paymentDetails); // NULL

var_dump($payment->payment_details); // SepaDirectDebitPaymentDetails instance

If I remember correctly, it should be independent of the relation type used and should follow the method's name (PaymentDetails in this case).
Jarno

You need to call:
var_dump($payment->payment_profile);

Fixed in https://github.com/laravel/framework/pull/15334.


Option to ignore css Files

Hi,
i have problems that sass won't compile my css Files (Error: Interpolation isn't allowed in plain CSS) but it is not needed to compile css!
Is it possible to add an extra option to ignore css Files? Or maybe support of * in inputFolder like src/main/webapp/resources/**/*.scss?
Thanks
Daniel

Hey, @DG606 .
Do you have a minimal example that I can use to reproduce that behavior?
Also, can you compile the files normally using the Dart Sass executable? If yes, then can you share the command and the file that is being compiled?

Hi,
if i use the dartsass executeable with the command: sass --update src/main/webapp/resources:src/main/webapp/resources --no-source-map it compiles all my *.scss file in resources and subfolders. All css File in there will be ignored. So no error takes place. (Version 1.58.1) But the version in plugin is not the problem, i have change it to 1.58.1 lokal as a test.
The maven plugin includes all css Files for compiling. So i get an error. As an workaround I rename my *.css File to *.Css . So the plugin ignores it ;-) but this feels like a bad solution.
cssfile content (the '#{resource' will be replaces later at deployment of jsf application which i can't change:
@font-face {
src: url("#{resource['layout:icons/icons.eot']}");
src: url("#{resource['layout:icons/icons.eot']}#iefix") format('embedded-opentype'),
url("#{resource['layout:icons/icons.ttf']}") format('truetype'),
url("#{resource['layout:icons/icons.woff']}") format('woff'),
url("#{resource['layout:icons/icons.svg']}#icons") format('svg');
font-weight: normal;
font-style: normal;
}

Hey, @DG606. Thanks for sharing a sample CSS file.
I see that that's the same behavior that you get if you use Dart Sass CLI in the many-to-one mode and the input folder and the output folder are different. So the plugin is behaving the same way the CLI does. Try to compile files in folder A to a different folder B and you'll get the same error.
As a workaround, can you try setting the inputFolder and outputFolder parameters for the plugin in your pom.xml and try to execute the plugin goal again?

Hi,
yes it works if I use same input and output folder. Very strange! So I can use it but than I have to exclude generated css-files from my cvs. :-(
Thanks for your help.

See https://github.com/sass/dart-sass/pull/862
You're leveraging that feature of the CLI: if there's a .css file inside a directory and the destination is the same folder, then it won't be compiled, so that's why you see no error. You have to assume that .css files will be compiled if the source and destinations are different.
That being said, this is not something we'll fix so that we don't override the CLI behavior. Just set inputFolder and outputFolder to the same path.


Added RELEASING.md

I noticed the information here is partly redundant to
CONTRIBUTING.md.  But the link to the dataset and the explicit clld
initdb command might be usefull."

I think the CONTRIBUTING.md comes from the app template.
Tarik Havighorst @.***> schrieb am Fr., 19. Nov. 2021,
19:22:

I noticed the information here is partly redundant to
CONTRIBUTING.md. But the link to the dataset and the explicit clld
initdb command might be usefull."
You can view, comment on, or merge this pull request online at:
https://github.com/clld/mixezoqueanvoices/pull/2
Commit Summary

2038a57
https://github.com/clld/mixezoqueanvoices/pull/2/commits/2038a57351d230444290f9dac390028c589b59fb
Added RELEASING.md

File Changes
(1 file https://github.com/clld/mixezoqueanvoices/pull/2/files)

A RELEASING.md
https://github.com/clld/mixezoqueanvoices/pull/2/files#diff-87d6a57a759f2386bf9caf5309b9aa0b9ff0ca70f5e38696e114a1ccdb0e785d
(18)

Patch Links:

https://github.com/clld/mixezoqueanvoices/pull/2.patch
https://github.com/clld/mixezoqueanvoices/pull/2.diff

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/clld/mixezoqueanvoices/pull/2, or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAGUOKCX5JGUY2YJQD6E63TUM2IVVANCNFSM5IMXVTZQ
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.


user/v danwesley/writer pass on "Publish a Microsoft Edge extension"

Learn Build status updates of commit 4b9613e:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

microsoft-edge/extensions-chromium/publish/publish-extension.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the learn.microsoft.com contributor guidesPost your question in the Learn support channel

Learn Build status updates of commit b342789:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

microsoft-edge/extensions-chromium/publish/publish-extension.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the learn.microsoft.com contributor guidesPost your question in the Learn support channel


ConstrainedDelaunay2 "Failed to find vertex in graph."

I have created a ConstrainedDelaunay2 and added the following 7 vertices: (-1, -1), (-1, 1), (1, -1), (0, 0), (0, -1), (-1, 0), (0, 0).
When I insert the edge (3, 4) I get the error "Failed to find vertex in graph." in GetLinkEdges. I assume this has something to do with the duplicated vertex. The vmap in GetLinkEdges contains only 6 vertices. But GetNumVertices() and GetNumUniqueVertices() of  ConstrainedDelaunay2 both return 7. Might this be a bug or isn't it allowed to add duplicated vertices or am I doing something else wrong? I would very appreciate any help.

Thank you for reporting this. I am looking into the issue. It might be a regression when I switched from using  to <unordered_set>. I should have a resolution in one or two days.

Is there still a chance that this will be fixed soon? I just wanted to ask so I know if it is worth waiting or if I should better look for another solution.

The regression occurred in Delaunay2 when I switched from 'set' to 'unordered_set'. The ProcessedVertex Hash(...) and operator==(...) functions incorrectly used the 'location' member function. I also modified ConstrainedDelaunay2::InsertEdge to replace the incoming edge by the equivalence-class vertex indices (via mDuplicates) in case InsertEdge is called with a duplicated vertex. The Delaunay2D sample has another test case added to it. The fixed code has been pushed.


help add the logic of creating arrow builder for the type uint64 in Go

Hi, long time no see. Wish you all the best.
Recently I learned the base knowledge of Apache Arrow and read the code for creating Arrow Builder in your project. I noticed that you are only supporting some primitive types in Go, and these types are int64, float64, string, and bool.
So I would like to help implement builders for other primitive types in Go, such as uint64, uint8, etc.
I also noticed that we should define the values of enums in protobuf, and the type uint64 has already been defined there. So this PR is just a case for what I want to do, and it implements the arrow builder for the type uint64.
Would like to wait for your opinions or concerns, thanks!

Thanks a lot. @gernest

Hi @gernest could we merge this PR first if no concerns？ Thanks！

Looks good to me @elliotchenzichang thanks for the contribution!


spandsp: refactor

Includes (to avoid merge conflict):

https://github.com/NixOS/nixpkgs/pull/218477
https://github.com/NixOS/nixpkgs/pull/218478

Description of changes
The spandsp derivation has the clauses in the wrong order     (e.g. makeFlags before configureFlags) which makes it hard to    understand.
This commit fixes the clause order, factors out common.nix from    the two versions of spandsp, and also tries to normalize the coding    style.
CC: @SuperSandro2000 for review
Things done

Built on platform(s)

[x] x86_64-linux
[x] aarch64-linux

Wait, it includes the changes, but not the commits? I merged in the wrong order, I guess, but I thought it would work if this PR includes those?

#218477 got some suggested changes which I forgot to backport into this PR.
It's rebased now.


Regular parameters cannot come after default parameters. (E051)

Hey,
Recently came across this error while programming using default parameters. I plugged it into google and it sent me to a jshint github issue, the issue is now closed and fixed. I think this might be a quick fix and update for you on the atom add-on (hopefully you can do it soon). (All my add-ons are up to date)

We depend on the latest JSHint, so you might have to wait until its released with JSHint, or if it is, reinstall this plugin to get the latest dependencies.


facts.files.File does not properly handle the ~ (relative) directory in Ubuntu/Debian

Describe the bug
Addressing file via ~/file notation resolves to wrong path using facts.files.File, operations.files.file and so on
To Reproduce

Spin up Ubuntu/Debian vm
Create file test.txt in ~ directory
Run main.py:

from pyinfra.facts import files
from pyinfra import host

relative_file = host.get_fact(files.File, '~/test.txt')
absolute_file = host.get_fact(files.File, '/home/ubuntu/test.txt')

print()
print()
print('+++\n' + str(relative_file) + '\n+++')
print('+++\n' + str(absolute_file) + '\n+++')
print()

See output:

(...)
+++
None
+++
+++
{'user': 'ubuntu', 'group': 'ubuntu', 'mode': 664, 'atime': datetime.datetime(2023, 11, 6, 8, 5, 43), 'mtime': datetime.datetime(2023, 11, 6, 8, 5, 43), 'ctime': datetime.datetime(2023, 11, 6, 8, 5, 43), 'size': 0}
+++
(...)

Target system information
Ubuntu 20.04.6 LTS (GNU/Linux 5.4.0-164-generic x86_64)
Debian GNU/Linux 12 (bookworm) Linux 6.1.0-13-amd64 x86-64

Expected behavior
Explicit warning/error about using of ~ in path, or support for this notation
Meta

Include output of pyinfra --support.

pyinfra --support
--> Support information:

    If you are having issues with pyinfra or wish to make feature requests, please
    check out the GitHub issues at https://github.com/Fizzadar/pyinfra/issues .
    When adding an issue, be sure to include the following:

    System: Linux
      Platform: Linux-6.2.0-36-generic-x86_64-with-glibc2.37
      Release: 6.2.0-36-generic
      Machine: x86_64
    pyinfra: v2.8
    Executable: /home/user/Projects/Test/venv/bin/pyinfra
    Python: 3.11.4 (CPython, GCC 12.3.0)

How was pyinfra installed (source/pip)?
pip
Include pyinfra-debug.log (if one was created)
none
Consider including output with -vv and --debug.
nothing special in verbose output

Yeah this should work, it's a gotcha currently that it doesn't just work as one would expect.

I believe this is caused by the fact that ~ is not expanded when wrapped inside quotes (does not matter if single or double quotes).
It might be a viable solution to check if the path starts with ~ and if it does, only quote the part after the tilde.
I'll try to create a PR later.

It seems like #1175 only fixed this issue for the File fact - file operations still seem to be broken :/

It seems like #1175 only fixed this issue for the File fact - file operations still seem to be broken :/

I've opened #1235 to track this bug


When ?readthedocs-diff=true we can't disable visual diff

Steps to reproduce it:

https://docs--11751.org.readthedocs.build/en/11751/user-defined-redirects.html?readthedocs-diff=true
Press d

Visual diff should be disabled, but it doesn't --another layer of diff is added somehow.

I understand this is because the "enabled" state coming from the URL is read by docdiff itself, but it's not read by hotkeys addon. Instead of calling enableDocDiff() we need to trigger the Event.

This is working fine now 👍🏼


Adds option to retrieve currently playing podcast episode. Fixes #562

Adds option to pass additional_types to the currently_playing and current_playback.
This allows to get currently playing podcast episodes, not only tracks.
Reference to docs

Nice, thank you


Update UM_ROLE table structure

Purpose
Update UM_ROLE table structure to make following newly added columns to not required columns to preserve backward compatability.

UM_ROLE_UUID
UM_CREATED_DATE
UM_LAST_MODIFIED

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/7876665277

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/7876665277
Status: success


ci: Ensure ci-imgs repo is only triggered when new releases occur

The release.yaml workflow currently triggers the ci-imgs repository to rebuild anytime a merge to main happens.
This PR makes the logic smarter by only triggering the ci-imgs repository to rebuild when an actual release occurs.
This will prevent ci-imgs rebuilds from occurring unnecessarily.

:tada: This PR is included in version 1.9.0 :tada:
The release is available on:

GitHub release
PyPI release

Your semantic-release bot :package::rocket:


mask_iou_mean、mask_iou_at_5、mask_iou_at_7=0？

Hello, I would like to ask why these indicators mask_iou_mean, mask_iou_at_5, mask_iou_at_7=0 during training?
I only used the ytb_vos dataset for training, please answer,Thank you!

I just met the same question recently, and i find the problem is in the siammask.py/siammask_sharp.py iou_measure. In iou_measure, mask_sum = pred.eq(1).add(label.eq(1)) which can not > 2. And in the next line, intxn = torch.sum(mask_sum==2,dim=1).float will never be larger than 2.
I think it may be the version of pytorch. The pytorch I use is pytorch.1.5.1. But in the official code, the version of pytorch is 0.4.0. Hope helpful

Thank you! I got it！I have solved it! Thanks again

@StarrySky-SHT HI, have you encountered the following problem? when I train the train_siammask_refine function. get WARNING:root:NaN or Inf found in input tensor

I just met the problem today morning ,and it confuse me for a long time. but I think I have gotten it now. I just turn down the lr in the experiments/siammask_sharp/config.json. I turn down the lr to start_lr = 0.001, end_lr = 0.00025. It seems the problem gone but I do not know if it is actually right.

@StarrySky-SHT Hi! have you encountered the following problem? when I train train_siammask_refine ValueRrror: loaded state dict has a different number of parameter groups!!!

I just met the problem today morning ,and it confuse me for a long time. but I think I have gotten it now. I just turn down the lr in the experiments/siammask_sharp/config.json. I turn down the lr to start_lr = 0.001, end_lr = 0.00025. It seems the problem gone but I do not know if it is actually right.

Thanks a lot!

The type of mask causes this error since the mask in PyTorch 0.4.X is an integer type, but in the higher PyTorch version is a boolean type. You can modify line 179 in models/siammask.py and line 183 in models/siammask_sharp.py.
mask_sum = pred.eq(1).int().add(label.eq(1).int())

大佬们，iou一直等于零到底怎么解决啊，求助，万分感谢


Allow configuring extra chruby paths

Motivation
Closes #1969
Chruby allows configuring extra directories to search for Ruby installations. We'll need to offer a similar setting to match the behaviour.
Implementation
Added the setting and started pushing the configured URIs into the list of places to search for.
Automated Tests
Added a test.

Is it not possible to just pull this from the environment variable? That seems like a cleaner solution, if possible.

Not in a scalable and clean way. For example:

How would we know where the environment variable is defined? The VS Code process doesn't source your ~/.zshrc, ~/.bashrc or equivalent. Your shell does, but not VS Code. Which means we would need to source those files, which has caused us a number of issues in the past
What if the environment variable is not defined directly in the rc file? For example, what if RUBIES is only defined when there's a prompt or with some conditional behaviour. In many situations, invoking the shell from NodeJS doesn't match the expected conditionals, which may not set the variable

Trying to integrate with shells (our previous approach) basically resulted in a variety of problems. People can configure their environments in unexpected ways that don't integrate well with the extension. As examples, we had reports of users with shell plugins that refused to activate if they weren't in a TTY, breaking our integration.
In other cases, shell plugins hijacked the stderr pipe, redirecting it to something else and only restoring the original file descriptor if the user was about to write a command, which never gets detected when we invoke the shell from NodeJS - again breaking the editor/server communication.
In yet another case, some shell plugin maxed the user's CPU when we invoke their shell from the NodeJS process. Probably because it did not account for the case of having the shell be invoked as a script.
Basically, integrating with shells proved to be extremely brittle and lead to a lot of frustration. We invested significant effort to decouple from shells to prevent all of those. I understand that having to set RUBIES twice is a small inconvenience, but we had to accept that tradeoff in favour of more stable Ruby activation.


Remove global tab handler

Remove tab focus policy for all views except file list panels. Remove global tab handler

Thank you!


Ubuntu 14.04 no longer uses upstart

Was this intentional? Trusty switched to sysv instead of upstart in forever-service v0.5.9.
uses sysv - forever-service --version => 0.5.9
uses upstart - forever-service version => 0.5.8
$ lsb_release -a
No LSB modules are available.
Distributor ID:	Ubuntu
Description:   	Ubuntu 14.04.3 LTS
Release:       	14.04
Codename:      	trusty

Probably side effect of sysv support for Ubuntu 15.04 onwards.


Could not run the exe

Hi,
we were not able to start the ... application,
because of missing dll files.
They probably compiled for a other version.
Thanks
Patrick

I had the same problem. They linked the application to CUDA 7.5, but included the libraries for CUDA 8.0.
You could install CUDA 7.5 and copy the correct libraries from there to the directory where deep_image_analogy.exe resides. You'll probably need to do the same with CuDNN.

I also changed the 8.0 references to 7.5 (in windows\deep_image_analogy\deep_image_analogy.vcxproj) without any problems.
That problem aside, there is also a dependency on Eigen, which does not appear to be included in this solution (that or a reference is broken) and causes WLS.cpp to not build.  Currently trying to figure out how to get Eigen to build with this project.

Hi, sorry for my mistake. The executable file has been updated but based on another CUDA version, so it could not run. For now, I have update dlls for current executable file. Please check them.


fixes react StrictMode deprecation warnings

When using this library with the latest version of React with StrictMode enabled, two different warning are generated:

componentWillMount will be removed in React 17 and should no more be used.

ReactDOM.findDOMNode will be removed in React 17 and should no more be used.

This PR just follows the official React documentation (here and here) to fix these warnings.

Hi, thanks. But I think this version of library won't work with React 17 anyway. It have to be totally rewritten using new approaches in React introduced in newest versions.

We can't be sure this library will work or not with React 17, but at least with this PR, there is no more any warnings.
As far as the tests are concerned, I was unable to run tests without error. It seems there is an already referenced issue about it (#54 ).

Yes, I meant manual tests.


Update index.md - Increase readability

Increase readability

@lukemurraynz - Many great suggestions! Thank you! I'll work on addressing your comments.

IMPORTANT: When the changes are ready for publication, add a #sign-off comment to signal that the PR is ready for the review team to merge.
#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

#label:"cact-review-in-progress"

#label:"cact-review-in-progress"

@lukemurraynz - thanks for your contribution. I had to revert a few of the changes for style guide alignment and technical correctness.
CACT #sign-off
#remove-label:"do-not-merge"
#label:"ready-to-merge"


[nri-statsd] Add global for NR license key secret

The nri-bundle chart provides globals for storing a license key in a secret. I'd love to see the nri-statsd chart do the same.

global.customSecretLicenseKey
string
""
Key in the Secret object where the license key is stored

global.customSecretName
string
""
Name of the Secret object where the license key is stored

We appreciate you taking the time to bring this to our attention. After reviewing this issue, we are unable to commit on a timeline to resolution. When committing to resolve an issue, we take into account the type of issue, the customer impact, and the development effort required. If the situation changes, we will revisit this decision.
However, we encourage community contributions and are happy to collaborate on design proposals and pull requests. See our PR guidelines in the README. If you have any further questions or comments about this, please let us know by replying to this issue.


chore(main): release 0.14.0

:robot: I have created a release beep boop
0.14.0 (2024-12-16)
Features

reexport postgresql insert function (51dbb18)

Miscellaneous Chores

release 0.14.0 (b07a965)

This PR was generated with Release Please. See documentation.

:robot: Created releases:

v0.14.0
:sunflower:


Filenames with trailing whitespace in stable branch

$ git clone --branch xchange-4.2.0 https://github.com/timmolter/XChange
$ find XChange/ -iname "* "
XChange/xchange-livecoin/api-specification.txt
XChange/xchange-yobit/api-specification.txt

Git is unable to handle these files on Windows.

Fixed in develop by https://github.com/timmolter/XChange/commit/430e7dd2229def52b1b134eac1c2c4eb285253f3#diff-13168082187878f15b3ebc3759086577
Is there any chance to get this into stable? Or when the new release is planned?

I could do a release, but why can't you build your own jar for now? mvn clean install

I can do jars, but git fails to commit my modifications to repository.

You should be able to check out any commit on develop you want and then build a jar.

Yes. I'll wait for a new release. Looks like there is no stable branch, so cherrypicking from develop seems like the right strategy.

I'll try to get a release out soon. The stable branch is master. the problem is, and what makes this project unique, is that the bitcoin exchanges are a constantly moving target, so nothing is really ever stable. it's unfortunate, but the way it is.

So maybe there is no need to keep develop at all then? Keep master always stable and let features mature in branches/PRs?


Tagged Release 0.3.5

[x] Update the version in package.json
[x] npm i to regenerate package-lock.json
[x] npm publish to publish the version to npm registry.
[x] PR #1041 to merge changes to the Editor's master branch
[x] Git annotated tag and push to Github

[x] git tag -a v{version} -m "{your message}" to create an annotated tag
[x] git push origin v{version} to push up to the project's
releases

[x] Docker build and publish tagged Image, see See documentation for more information

[x] Build a tagged Docker image i.e. docker build -t ld4p/sinopia_editor:{version} .
[x] Push the tagged version to Dockerhub with docker push ld4p/sinopia_editor:{version}

[x] Create Release notes for the tagged version on Github
[x] Once tagged release is live on https://development.sinopia.io, this ticket will be assigned to the product owner who will approve the tagged release for deployment on

[ ] Staging at https://stage.sinopia.io/
[ ] Production at https://sinopia.io

Release Notes

. New InputLookupSinopia component for linking to Sinopia created entities
. InputLookupQA and InputListLOC allow users to enter a URI if not found in the lookup
. Validation of embedded Resource Templates
. Improved handling of languages for the InputLiteral
. Numerous bug fixes and improved testing

Closing in favor of #1059


Cross-framework guidance on .Net 5 porting

Hi,
I've been trying to port/upgrade an existing software solution to .Net 5 Preview 8 (.Net 5.0.100-preview.8.20417.9)
It is a legacy solution, consisting of several generations of .Net technologies, which I am hoping to move in the direction of .Net 5.
It's a quite large solution with 60+ projects using various .Net technologies. I will try to describe how it looks (simplified) now, and where I want to move to.
I am hoping that some one on the team can reach out, and tell me whether or not I am trying to do the impossible - or there is a way for our solution to move forward.
The solution consists of several projects, here grouped into categories.
Baseclasses/Common Business logic (6-7 projects, currently .Net 4.5)
These are trivial to convert to .Net 5.
Some of them make use of Windows Forms components, so have chosen net5.0-windows as TFM.
I have added the following to the .csproj for those requiring WinForms or WPF.
<UseWindowsForms>true</UseWindowsForm> <UseWpf>true<UseWpf>
.Net Core 2.1 API
A few years ago we developed an API on top of the common business logic.
This also has a almost trivial path to .Net 5.
So have converted this, and this works almost as expected.
A few custom middleware classes needs adjustments - but certainly doable.
This is the key project needing .Net 5, as we need to upgrade the framework for this to move on.
.Net Core 3.1 was skipped since it's not compatible with .Net 4.5 (or 4.6/4.7) and our baseclasses will still need to support this.
Legacy Web projects
We have some legacy webprojects, still active though.
They are based on Asp.Net 2, Asp.Net WebApi, WCF, etc.
Common for these are they use System.Web, the use WCF and they are stuck there - or doomed to be rewritten, as I understand it.
These are still used by customers, and I will estimate several months of work to convert to newer technology.
So these can't be moved to .Net 5.
Windows application
We have a normal WinForms based windows application on top as well.
Currently .Net 4.5, will assume it can be moved to .Net 5 even though using Windows Forms.
It is currently referencing some of the Web projects, as it has some WCF generated client classes.
So until the references to web projects is refactored, this will stay on e.g .Net 4.7.2
My proposed solution

The idea I am going for is to let the baseclasses build for both net472 and net5.0-windows. So these projects has multiple TFM's.
<TargetFrameworks>net5.0-windows;net472</TargetFrameworks>

The api should build for net5.0-windows. (Down the road we can clean up and remove the -windows binding by removing Windows Forms from the baseclasses.

The legacy webprojects should build for net472, and as such not be running as .Net 5.

The Windows application should in first step be net472, but over time moved to .Net 5, as we refactor the requirements and project references to legacy webprojects.

Status
The baseclasses and the API works. So I have my API running .Net 5.
Where I get stuck is with the webprojects.
As an example I have a project IosDeviceIntegration.csproj
On my .Net 5 machine, I can build it using msbuild.
&"C:\Program Files (x86)\Microsoft Visual Studio\2019\Preview\MSBuild\Current\Bin\MSBuild.exe" .\IosDeviceIntegration.csproj
Using dotnet cli it fails with the below
dotnet build IosDeviceIntegration.csproj

C:\Users\Anders\sertica\IosDeviceIntegration\IosDeviceIntegration.csproj(206,3): error MSB4019: The imported project "C:\Program Files\dotnet\sdk\5.0.100-preview.8.20417.9\Microsoft\VisualStudio\v16.0\WebApplications\Microsoft.WebApplication.targets" was not found. Confirm that the expression in the Import declaration "C:\Program Files\dotnet\sdk\5.0.100-preview.8.20417.9\Microsoft\VisualStudio\v16.0\WebApplications\Microsoft.WebApplication.targets" is correct, and that the file exists on disk.

I assume this is expected, as the csproj file is not converted using try-convert. So this is still good old csproj with toolsversion 14 and a TargetFrameworkVersion v4.7.2.
When I then try to build the WinForms project with MsBuild (targeting .Net 4.7.2), i run into problems.
This gives me this error

"C:\WinForms\logihold.csproj" (default target) (1) ->
(ResolveNuGetPackageAssets target) ->
C:\Program Files (x86)\Microsoft Visual Studio\2019\Preview\MSBuild\Microsoft\NuGet\16.0\Microsoft.NuGet.targets(186,5): error : Your project file doesn't list 'win' as a "RuntimeIdentifier". You should add 'win' to the "RuntimeIdentifiers" property in your project file and then re-run NuGet restore. [C:\Winforms\logihold.csproj]

I have added the RuntimeIdentifier to the logihold.csproj - but somehow it seems to not pick it up.
So the big question is:
Is it at all possible to keep .Net 4.7.2 old style projects referencing .Net 5 built assemblies, when these .Net 5 assemblies are built with TFM net472?
If doable what steps do I need to take to make it work?

How do I overcome the "win missing runtime identifier" msbuild error - where does this come from?
Do I need split up my solution into several solutions for baseclasses, api, legacy web, and winforms? Or can they co-exist in same solution?

I hope someone can give me some hints here.
I hope I can follow my idea, as having to maintain individual solutions and projects for "old" .Net and new .Net5 seems an hard and troubled way to go. Then developers will need to add new files two places for everything to work - which is doomed to fail.
Let me know if any specific details are needed to answer this question.
Best regards
/Anders

Hi
Just a short feedback.
It seems the "win" RuntimeIdentifier is caused by "corrupt" data in the obj folder.
Reading the net, this could be caused by nuget having restored with the new project format in same folder. Which is not unreasonable to think I have tried - as I have been trying out a lot of things to experiment different paths.
Deleting the obj folder seems to have put me in the right direction again.
I am leaving the office for today - but will reply with an answer tomorrow, if I am stuck a new place.  Or if everything just works - then I can leave a small note on how I made it work.

Hi again.
I think it works now.
I have some challenges left, on getting the output patchs matching for the old and new assemblies.
My approach has been
*BaseClasses

Convert the csproj files with try-convert -p projectfile.csproj
Adjust TargetFrameworks to net5.0-windows and net472
<TargetFrameworks>net5.0-windows;net472</TargetFrameworks>
For those projects using WindowsForms or WPF add the corresponding tags
<UseWindowsForms>true</UseWindowsForms>
<UseWPF>true</UseWPF>
Add conditional reference to Microsft.CSharp if net472 targetframework.
<ItemGroup Condition=" '$(TargetFramework)' == 'net472'">
  <Reference Include="Microsoft.CSharp"></Reference>
</ItemGroup>

.Net Core API
Follow the conversion guidelines moving from .Net Core 2.1->3.1->5.0
Starting point here
System.Web dependent projects and above
I have not converted these, and as such they are just kept as old-style csproj files, compiling to .Net 4.7.2.
So only change for now is that their target framework is moved from 4.5 to 4.7.2.
Last question - if anyone gets here.
The "old" System.Web projects targeting .Net 4.7.2 and using System.Web.
Is it the right approach to leave them alone, or should I convert them using try-convert, and moving to the new build chain, but only targeting net472?

@richlander @terrajobst do we have any guidance on how to perform migration?

Closing this.
After some time away from this I have now a working setup.
Ended up with targeting .Net4.8 and .Net 5.0

Assemblies depending on System.Web or other non .Net5.0 ported bits are kepts as .Net 4.8 assemblies, on old-style csproj files. So no conversions here. In this block is our existing Windows application and legacy webservcices. They also require some win only parts. The only target net48 in TargetFramework
The .Net Core API, and test projects are converted to .Net 5.0
Shared assemblies between legacy webservices, windows application and API, from the bottom up, is compiled with two TargetFrameworks both net5.0-windows and net48

References to external third party assemblies are for most parts changed to nuget packagereferences to avoid manually handling .Net4.8 /5.0 switching.
Had to move some bits and parts around, some blocks are left out in .Net 5.0 with #if net48 preprocessor directives etc.
Quite some work in figuring out when msbuild, mstest and dotnet CLI works best, and how to restore nuget references etc.
.Net4.8 solutions is built with msbuild and tested using mstest.
API solutions is built with msbuild, but tests run with dotnet test.
Visual Studio 2019 does it all - but on buildservers some trial and error should be expected.
But... all in all, it seems like the 10-15 year old codebase can coexist and be used both in a .Net 4.8 and .Net 5.0 runtime.


Compress wallet data

Especially the smidgen multisig file.

Pruning of redundant smidgen history implemented so compressing is not really needed at this time, open to reconsider in future...


Update README.md

Fix arxiv link of paper: A Multitask, Multilingual, Multimodal Evaluation of ChatGPT on Reasoning, Hallucination, and Interactivity.

Thanks.


Improve sql logging by adding additional context.

Reladomo's sql logging is so useful that I sometimes leave it turned on in production.
DEBUG com.gs.fw.common.mithra.sqllogs.MyClass: connection:1030722971 find with: select t0.key,t0.number from MY_CLASS t0 where  t0.key = 'abcd' and t0.system_to = '9999-12-01 23:59:00.000'
DEBUG com.gs.fw.common.mithra.sqllogs.MyClass: retrieved 1 objects, 2.0 ms per

I have some ideas on how to make this logging even more useful.
It's currently hard to log only sql, or only timings, without the other. That's because both log statements using the same logger, com.gs.fw.common.mithra.sqllogs.MyClass in this example. I propose adding markers for each.
private static final Marker MARKER_SQL = MarkerFactory.getMarker("Reladomo SQL");
private static final Marker MARKER_TIMING = MarkerFactory.getMarker("Reladomo Timing");

And adding the markers to the relevant log statements. For example, change this:
logger.debug("source '" + source + "': " + text);

to
logger.debug(MARKER_SQL, "source '" + source + "': " + text);

In addition, the timing information could be even more useful if I didn't have to parse it out of the logged message. I propose adding the timing information to MDC. That way I more easily create dashboards of the amount of time spent on queries over time.
For example, change this:
this.sqlLogger.debug("retrieved " + this.rowCount + " objects, " +
        ((this.rowCount > 0) ? ((totalTime / this.rowCount) + " ms per") : (totalTime +
                " ms")));

to
MDC.put("rowCount", String.valueOf(this.rowCount));
MDC.put("totalTime", String.valueOf(totalTime));
try
{
    this.sqlLogger.debug(MARKER_TIMING, "retrieved " + this.rowCount + " objects, " + ((this.rowCount > 0) ? (totalTime / this.rowCount + " ms per") : (totalTime + " ms")));
}
finally
{
    MDC.remove("rowCount");
    MDC.remove("totalTime");
}

I'm happy to contribute these changes but I wanted to discuss here before working on the whole thing.
I'm starting with the assumption that changing the existing logging is undesirable because users already rely on the current behavior. So this proposal adds markers and MDC but doesn't change, remove, or combine any messages. What do you think?

I'm a little confused about the MDC, but before we go there, I want to make sure you're aware of two existing hooks here.

There is aggregate performance data in the runtime, on the portal object MithraPerformanceData getPerformanceData();
There is a way to snoop on the SQL via SqlLogSnooper. This might be closer to what you're doing above.

So the first question is, should we somehow improve the snooper?
And the second question: if the MDC key/value is getting cleared right after the log, what good is it? (worded differently: how're you going to use it)

Oh, I'm fine with the markers as long as the default is blank.

The more I read this, the more I'm convinced I misread the intent. Is this meant to be some sort of in-VM dashboard or is it an external process reading logs and you just want to make the parsing easier?

Thanks for the quick reply. I didn't know about getPerformanceData() and I think I'll make use of it. I think MDC would be useful too. I'll set up an example.
private static final Logger LOGGER = LoggerFactory.getLogger(ExampleApplication.class);
private static final Marker MARKER = MarkerFactory.getMarker("Example marker");

MDC.put("example metric", String.valueOf(123));
try
{
    LOGGER.info(MARKER, "Example metric: " + 123);
}
finally
{
    MDC.remove("example metric");
}

I set up a logback console appender with this pattern:
%highlight(%-5level) %cyan(%date{HH:mm:ss}) [%white(%thread)] <%cyan(%marker)> {%magenta(%mdc)} %green(%logger): %message%n

And I get output like:
INFO  21:29:52 [main] <Example marker> {example metric=123} com.example.ExampleApplication: Example metric: 123

If I remove the marker and mdc from my pattern:
%highlight(%-5level) %cyan(%date{HH:mm:ss}) [%white(%thread)] %green(%logger): %message%n

Then they simply aren't logged:
INFO  21:31:13 [main] com.example.ExampleApplication: Example metric: 123

Dropwizard comes with a json log format
The same log message gets output like this:
{"level":"INFO","logger":"com.example.ExampleApplication","thread":"main","message":"Example metric: 123","mdc":{"example metric":"123"},"timestamp":1567042492086}

I just now realized that the marker is missing. I'll try to fix that upstream in Dropwizard. Another problem is that all MDC values are strings. Downsides aside, the json format, as well as other tools like logstash-logback-encoder or elk appenders help me get this data into Kibana/Graphana where I can create dashboards. For example, I histogram that shows the sum of all time spent in database queries for each 5 minute window. For this data to be the most useful, I need it to be per query, and allow Kibana/Graphana to perform the aggregations.

is it an external process reading logs and you just want to make the parsing easier?

Exactly. I should have started with that. These additions would make it easier to use the logs in Kibana/Graphana and probably other tools too.

Ok, I understand the intent: external log crawler that prefers a standard parsable format (json).
Please submit the code :smile:
A couple of notes: all work/garbage must stay inside isDebugEnabled(), and even then try to be frugal (e.g. reuse strings). There is also a lot of places we log. Try to get all the relevant ones.

Will do, thanks 👍


Make plugin dynamic-loadable

I've not checked fully yet, yet DevKit has no complaints so far.

I'll check.


BUG: Sensitive JDBC data was exposed publicly

Hi team, Hope u doing well :)
I have found a bug or we can say it's an issue that sensitive data was exposed publicly which causes a high advantage to an attacker.
Because JDBC is an application programming interface (API) for the programming language Java, which defines how a client may access a database. It is a Java-based data access technology used for Java database connectivity. It is part of the Java Standard Edition platform, from Oracle Corporation.
For an attacker, it becomes easier to access the database belonging to this repository

Thanks for raising however the clusters provisioned are automatically span up / down for pipeline testing in a private repo - this doesn't affect the application in any way.

Thanks for raising however the clusters provisioned are automatically span up / down for pipeline testing in a private repo - this doesn't affect the application in any way.

you welcome 🙂. However it's revealing the username and password know? Like attacker might get access if in case if any bypass works??

This isn't a issue it's just a DB connection for a demo application that runs for 10 mins on the cluster :) then the whole thing is torn down.

This isn't a issue it's just a DB connection for a demo application that runs for 10 mins on the cluster :) then the whole thing is torn down.

Ok 🙂


IFormFile.CopyToAsync() causes an exception on 2nd+ execution

I get the following exception after calling my controller on the 2nd and subsequence calls:
[HttpPut("{id}")]
public async void Put(string id, [FromForm]string data, [FromForm]List<IFormFile> media) {
     using (var memoryStream = new MemoryStream()) {
          await media[0].CopyToAsync(memoryStream);
     }
}

The first call to this controller action works, but the 2nd time will produce this exception until a restart:
System.ObjectDisposedException: Safe handle has been closed
   at System.Runtime.InteropServices.SafeHandle.DangerousAddRef(Boolean& success)
   at System.StubHelpers.StubHelpers.SafeHandleAddRef(SafeHandle pHandle, Boolean& success)
   at Interop.Kernel32.SetFilePointerEx(SafeFileHandle hFile, Int64 liDistanceToMove, Int64& lpNewFilePointer, UInt32 dwMoveMethod)
   at System.IO.FileStream.SeekCore(Int64 offset, SeekOrigin origin)
   at System.IO.FileStream.ReadNativeAsync(Byte[] bytes, Int32 offset, Int32 numBytes, Int32 numBufferedBytesRead, CancellationToken cancellationToken)
   at System.IO.FileStream.ReadAsyncInternal(Byte[] array, Int32 offset, Int32 numBytes, CancellationToken cancellationToken)
   at System.IO.FileStream.ReadAsync(Byte[] buffer, Int32 offset, Int32 count, CancellationToken cancellationToken)
   at Microsoft.AspNetCore.WebUtilities.FileBufferingReadStream.<ReadAsync>d__35.MoveNext()

Switching to use IFormFile.CopyTo() gets rid of the error, but it's no longer async.  Thanks!

You need to define the action as async Task not async void.

Ahh yes, thank you!


adding content to each blog

@ajay-dhangar I would like to add content related to each blog, on clicking the read more button, please assign this issue to me under gssoc-ext, hacktoberfest-accepted, and please provide the level

@ajay-dhangar  Could you please consider it as level2 , I have to work more please


Feature/monopipe

add docker compose test from Jenkins

done @laucapreviewer : after a rebase is it better now?


prefer ActiveSupport.on_load(:action_controller)

trim a little bit the load time

unstable ci: Failure/Error: require "solidus_support/extension/feature_helper"

Not unstable. factory_girl needs to be pinned to 4.8.1

my bad, I've corrected the dependency

I've reverted the commit, the problem wasn't only changing the dependency where I changed it. Also, I don't think this pull request it worth the time I would take make it work. So, from my point of view, if it's working for the test suite with Ruby 2.5+, then it's working as expected.


Writing aspects in Kotlin

Hi. Thank you for this plugin. I am wondering is it possible to write aspects in Kotlin? I compiled project with no errors. But when i looked in the decompiled code there is no aspects in there. Im using kotlin 1.2.30

Nope. Technically AJ not supports it.
AspectJ can augment Kotlin code so on. You may try to write kotlin class annotated with @Aspect and try to compile it. Not sure it works.

I actually wrote a full Android project and an Aspect weave class with all my pointcuts, both with Kotlin, and it is working fine, I'm just surprised with this @Archinamon, shouldn't it be working?
Is that Issue still relevant? Maybe this is old?

I actually wrote a full Android project and an Aspect weave class with all my pointcuts, both with Kotlin, and it is working fine, I'm just surprised with this @Archinamon, shouldn't it be working?
Is that Issue still relevant? Maybe this is old?

Can you please send us the repo link. Currently we are also struggling with the same issue.


How

it's not an issue it's a question how do I download it

https://github.com/mumumusuc/joycon-toolkit/releases/download/v0.0.3/app.apk


Agent manager is crashing when I try to parallelize a simple piece of code

When I run the following code with AgentManager and parallelization
import numpy as np
from rlberry.manager import AgentManager
from rlberry.envs.benchmarks.ball_exploration import PBall2D
from rlberry.agents.torch.a2c.a2c import A2CAgent

env_ctor = PBall2D
env_kwargs = dict()
env = env_ctor(**env_kwargs)

agent = AgentManager(A2CAgent, (env_ctor, env_kwargs), fit_budget=100, n_fit=3, max_workers=2, parallelization="process")
agent.fit()

results in the following error
RuntimeError:
        An attempt has been made to start a new process before the
        current process has finished its bootstrapping phase.

        This probably means that you are not using fork to start your
        child processes and you have forgotten to use the proper idiom
        in the main module:

            if __name__ == '__main__':
                freeze_support()
                ...

        The "freeze_support()" line can be omitted if the program
        is not going to be frozen to produce an executable.

Constructing an agent with AgentManager and adding mp_context = fork seems to solve the problem but still it seems a problem.

Did you try to execute this code in a notebook ? The default mp_context = spawn do not work in a notebook, the parallelization gets messed up and you have to use fork.

To follow up, here is a working script :
import numpy as np
from rlberry.manager import AgentManager
from rlberry.envs.benchmarks.ball_exploration import PBall2D
from rlberry.agents.torch.a2c.a2c import A2CAgent

env_ctor = PBall2D
env_kwargs = dict()
env = env_ctor(**env_kwargs)

agent = AgentManager(A2CAgent, (env_ctor, env_kwargs), fit_budget=100, n_fit=3, max_workers=2, parallelization="process")
if __name__ == '__main__':
    agent.fit()

In short, the explanation is that if you use paralellization="process" and mp_context=spawn then the parallel computing code must be "protected" behing a if __name__ == '__main__':.

paralellization="process"  is to have real paralellization, without this it is not really parallel except if you do a lot of numpy in each fit
From what I understood, mp_context=spawn is mainly because mp_context=fork do not work with jax

Solved by PR#120, I close.


The nested AD-with-PKI-ADStack- keeps failing on DC2

I tried to Deploy into a new VPC using default CIDRs and IPs in us-east-1. With 3 combinations of AZs, us-east-1a/us-east-1c, or us-east-1a/us-east-1b, or us-east-1a/us-east-1b, I kept getting the same error: DomainController2, CREATE_FAILED, Received FAILURE signal with UniqueId i-################ :(

Have you found a solution to this issue? We are seeing a similar problem. We are trying to deploy in an existing VPC and the First EC2 is created successfully, however when CloudFormation creates the second EC2 it never continues. The EC2 is created successfully, but for some reason CloudFormation doesn't recognize it and it will eventually time-out.

There are a few issues that I found by looking at the cloudwatch logs on my runs.
if you look at the error CREATE_FAILED, Received FAILURE signal with UniqueId i-################ it does not tell you much. Neither does the one that caused that which is from the nested cloudformation that that stack spawns. However, if you look into Cloudwatch logs for the microsoft-pki-TwoTierCAStack (the nested cloudformation that is spawned when you run this guy). I dont know if you guys had the same issues I had but this is what I encountered and what I did to workaround it.
My first  run through some errors because I only added my service account to  AWS Delegated Enterprise Certificate Authority Administrators and not the AWS Delegated Administrator groups (both are required). With that done I started getting an error because Computer 'EC2AMAZ-XXXXXX' was successfully joined to the new domain 'mydomain.com', but renaming it to 'ENTCA1' failed with the following error message: The account already This is because the cloudformation only reverses the AWS stuff and not the AD stuff that it does. So, you need to delete both ENTCA1 from the computer's OU and from the DNS records. Once this was done I ran it again and I got the following error
Connecting to remote server ENTCA1 failed with the following error message : The WinRM client sent a request to an HTTP server and got a response saying the requested HTTP URL was not available. This is usually returned by a HTTP server that does not support the WS-Management protocol. For more information, see the about_Remote_Troubleshooting Help topic. + CategoryInfo : OpenError: (ENTCA1:String) [], PSRemotingTransportException + FullyQualifiedErrorId : URLNotAvailable,PSSessionStateBroken
Now, this is the main reason that I believe its causing the majority of the issues here and I think that AWS needs to amend the requirements. Howerver before I go over this workaround there is something that needs to be done or this will not work if you got this error and remembering that cloudformation will not revert and windows changes, you will need to:

So, you need to delete both ENTCA1 from the computer's OU and from the DNS records
Two and this I realized when by luck. So, even though the ENTCA1 did not finished configuring failed and was removed, the Root CA cert and key were added to the domain SYSVOL, so it will not matter if you fix the winrm issue, the enterprise CA will keep having issues because it will not be able to become subordinate to the ORCA1 as the cert in Sysvol is from you previous failed run. Therefore you will need to delete it so go to File Explorer \$DomainDNSName\SYSVOL$DomainDNSName\Policies\PkiRootCA you can delete the PkiRootCA directory as it is a temporary directory made by the powershell module https://github.com/aws-ia/cfn-ps-microsoft-pki/blob/main/scripts/Modules/Module-Pki/Module-Pki.psm1 or you can just go inside and delete the cert and key which is what i did.
Now that we basically restored the AD as close to the baseline required before running cloudformation again; we can fix the issue with WINRM. First thing you need to add the ability to make group policy changes to it as AWS AD Services you will not see Configuration\Policies\Administrative Templates\Windows Components\Windows Remote Management\WinRM Service even though you can see the setting in some of the aws made policies. So you can get the templates from microsoft by going to https://learn.microsoft.com/en-us/troubleshoot/windows-client/group-policy/create-and-manage-central-store finding the correct version of Windows that you need remember that Server 2019 translates to Windows 10 just look for the build that you have currently AWS Directory services are 2019. I grabbed whatever matched the Server that AWS spun up for me to manage the AD which it was build 1809 (but I do not think it matters as long as it is one of the windows 10 versions). install the MSI on your dxxxx-managementInstance take note of where you installed it. Defaults to C:\Program Files (x86)\Microsoft Group Policy and follow these instructions https://docs.aws.amazon.com/whitepapers/latest/access-workspaces-with-access-cards/install-the-group-policy-administrative-template-files-for-the-workspaces-streaming-protocol-wsp.html as it is the same process. all of the ADMX go under the Sysvol \morpheus.rviolet.com\SYSVOL\morpheus.rviolet.com\Policies\PolicyDefinitions and the adml under the language en-US for example will go under the en-US folder in that same location in the sysvol (if the folder exists copy just the adml files in to it if it does not you can just copy the directory.
Now that this is completed go to the group policy under the OU that your computers are located should be under the ou that has your netbios name called winrm and complete the following changes:

Computer Configuration\Policies\Administrative Templates\Windows Components\Windows Remote Management\WinRM Service\Allow CredSSP authentication Set it to Not Configured as it should say enabled
Computer Configuration\Policies\Administrative Templates\Windows Components\Windows Remote Management\WinRM Service\Allow remote server management thought WinRM add and * to ipv6 filter (im not sure if this is needed but it should not hurt) you can remove after you complete the cloudformation. I added * to ipv4 as well as i was tired of running this cloudformaton template. I reverted to the filters that were there after.
Also just to be sure though I dod not think it necessary as this is an SSL thing, I enabled Computer Configuration\Policies\Administrative Templates\Windows Components\Windows Remote Management\WinRM Service\Turn On Capatibility HTTP Listener as again I ran this thing for two days as i debugged it.

After all that was done I ran it again and everything worked.
Hopefully, this will work for you guys. I highly recommend looking into cloudwatch for the errors as they will be in the /aws/Quick_Start/whatever_you_named_this and as they are most likely related to windows and not cloudformation


Wrong title for the button that scrolls to the top

Issue Type: Bug
In the Release Notes tab, as you scroll there is a button that takes you back to the top, this button when I hover over it, the title shows the '#' sign instead of saying for example: 'Scroll to the top' and also, the scroll sometimes is not smooth and doesn't scroll to the top completely, so, when I click on it, it scrolls only to almost the top, not the full top top. Hope it gets fixed :)

Can I take a look at this issue and try to work on this?

Yes, this button comes from the VS Code release notes: https://github.com/Microsoft/vscode-docs/blob/52876af9117d50861e8c8563f109f0282b10a121/release-notes/v1_43.md#L842

I've added a title tag to the button.
https://github.com/microsoft/vscode-docs/pull/3501

Closing as upstream


Detail ways to create a C++ binding

I opened this issue to discuss ways to create C++ bindings for lvgl.
I don't think the bounty will do it, especially with the conditions that it should be perfect and with examples..
So let's discuss how to do the binding and start with simple examples so it can be done one step each time.
Can we generate code from the rust bindings ? so we have similar APIs ?

I think we should use the JSON generated from LVGL's API and generate the C++ binding based on that.

If the JSON generation code gets added to LVGL the workload of putting together a C++ binding just got reduced by a HUGE amount. Couple that with the documentation for LVGL being available in that JSON output and now you can add that documentation to the binding code and make changes to the documentation programmatically so it would suit the C++ binding.
Examples and unit tests would probably need to be written by hand. unit tests are pretty easy to do actually. Instead of writing the data to a display in the flush callback you dump it into a buffer and you compare the data in that buffer to the data of what the expected output is supposed to be.  The only thing that you need to do special is setting the render mode to direct and making the frame buffer the same size as the "fake" displays resolution using 3 bytes per pixel.


HTTP Basic Auth filter

The implementation for HTTP Basic Auth filter.
Description: HTTP Basic Authn is a frequently requested feature from users, I'd like to have Envoy to support it.
Related issue: https://github.com/envoyproxy/envoy/issues/15365
Sponsor: wbpcode
Risk Level: low
Testing: Yes
Docs Changes: Yes
Release Notes: Yes
Platform Specific Features: No
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]

@wbpcode Since we agreed on the API, I changed this PR to draft and proceed with implementation.

 Not running target
2023-10-19T01:49:05.0445943Z INFO: Streaming build results to: https://source.cloud.google.com/results/invocations/67d01545-51a7-464d-b3e2-a3f6a31dbb72
2023-10-19T01:49:05.1933312Z ##[error]Bash exited with code '1'.
2023-10-19T01:49:05.1984296Z ##[section]Finishing: Run CI script docs
2023-10-19T01:49:05.2021023Z ##[section]Starting: Check disk space at end

/wait

Please don't use force-update after the review has started. It will make it pretty hard to review a PR that contains lots of changes. Thanks.

Please don't use force-update after the review has started. It will make it pretty hard to review a PR that contains lots of changes. Thanks.

Sorry for that, will not use force-update again.

/wait

Both is OK for this function (because this only be called once when configuration is loaded), although string view still be better to reduce unnecessary sub-string copy/creation.

I changed it back to std::string because the compiler was not happy about this line:
users->emplace(name, User{std::string(name), std::string(hash)});

Both is OK for this function (because this only be called once when configuration is loaded), although string view still be better to reduce unnecessary sub-string copy/creation.

I changed it back to std::string because the compiler was not happy about this line:
users->emplace(name, User{std::string(name), std::string(hash)});

SGTM, we any optimize it in the future anyway, if we have free time. Just merge main and add a release note. :)

Should integration test be added to make sure that it works e-2-e?

SGTM. But I have no strong opinion on this because this extension is pretty simple.

Should integration test be added to make sure that it works e-2-e?

SGTM. But I have no strong opinion on this because this extension is pretty simple.

Should I add an e-2-e test? Looks like there are no e-2-e tests for HTTP filters in the test/integration directory, or I looked into the wrong place?

Integration tests are placed in sub directory of filter itself.
You can check test/extensions/filters/http/fault/fault_filter_integration_test.cc as a example to see how to write a integration test of http filter.

@wbpcode @cpakulski Integration test has been added. PTAL.

/retest


Apply style guide similar to httpd's one, tweak code style

Related to: https://issues.redhat.com/browse/MODCLUSTER-783
I used indent with following options: -i4 -npsl -di0 -br -nce -d0 -cli0 -npcs -nfc1 -nut -ncs -l120.
The most of the changes are by indent itself, however, I removed some unnecessary parenthesis, inconsistent brackets, and made minor tweaks.
Please, I welcome any feedback.

Can one of the admins verify this patch? If it is not dangerous to our systems, juts tell me to "run_tests".  ( without the underscore and quotes :smiley: )

BTW @jajik  Is there a some linter / code style checker tool that we can use to keep the style in place?

Ok. I will have a look at settings we could use.

@rhusar I added a .clang-format file for clang-format tool. To see changes it produces, I ran (from native directory):
for f in */*.c; do clang-format $f > $f-diff; done

and then used meld on corresponding files.
Also, see the trailing comma I added with the last commit. Without it, the format is different (and uglier) and unfortunately this seems like the best way to force this format (we could use an empty comment too, but that seems like a worse option) . Other than that, I think it is usable but it differs from indent slightly.
I am going to see all the changes it proposed and tweak it, if necessary. I'll be happy for any comment.

Update 3:
I changed a few bits in the proposed .clang-format. I also applied the rules to the code base in the latest commit. Overall, I think that the results are better than with indent, even though I have some reservations about (some) comments' formatting and (some) array initializer lists. For the latter, I added clang-format off/on comments to preserve the format we already have.

Done.