Set filetype fzf for all buffers

I have it set to highlight trailing spaces only when the filetype is markdown, but when I run :FzfLua in a markdown file, it highlights them like this.

In README.md

This does not happen with other file types.

In LICENSE

@uga-rosa, can you post the part of your config causing this? The main fzf window is set to ft=fzf, I’d like to see the autocmd responsible for this so I can test it and understand why this happens.

minimal/init.lua
local lazypath = vim.fn.stdpath("data") .. "/lazy/lazy.nvim"
if not vim.loop.fs_stat(lazypath) then
  vim.fn.system({
    "git",
    "clone",
    "--filter=blob:none",
    "https://github.com/folke/lazy.nvim.git",
    "--branch=stable", -- latest stable release
    lazypath,
  })
end
vim.opt.rtp:prepend(lazypath)

vim.opt.termguicolors = true

require("lazy").setup({
  {
    "uga-rosa/trailing-whitespace",
    config = function()
      require("trailing-whitespace").setup({
        enable = { "markdown" },
      })
    end,
  },
  { "ibhagwan/fzf-lua" },
})

I was looking into this because I had a similar problem with another plugin, but it appears that the FileType is not yet updated at these events.
https://github.com/uga-rosa/trailing-whitespace/blob/8ad137cb55a819334b6887c697b574a4a4ba445c/lua/trailing-whitespace/init.lua#L6
I will fix it. Sorry for the inconvenience.

Ty for the update @uga-rosa


Make it clearer this sends text to a web service

Currently the readme has a notice about the extension using a web service but it is possible for a user to install the extension without been informed in any way

This patch makes a small change to the description to disclose the mechanism used for spell check. Users can then either go ahead or refer to the readme for additional information if they wish.

Cheers :+1:


Add Domain BPK Penabur Jakarta

https://bpkpenabur.or.id/
https://bpkpenabur.or.id/cities/jakarta

@frans-bfi bpkpenaburjakarta.txt I am sorry, I have to close the request without merging, because you made a mistake in a request and did not specify any filepath. Please ensure that you are familiar with this repository rules located at the bottom of this page and make a new correct request. Thank you for your understanding!


Best Practices for templateUrl and ngInclude URLs

I'm surprised at, with how much this guide pushes modularity in AngularJS, that there is nothing in it that suggests how an app should generate the URLs for ngInclude calls and directive/component templateUrls. Because manually specifying such paths as you do in various examples detracts from modularity and expects the specified file to be in a very specific place relative to the base URL.
For example, relative to my app's index.html, my Angular source code is in mysite/js/myNg/, and my compiled AngularJS scripts will sit in mysite/scripts.js (Angular frontend sitting on top of a SilverStripe PHP backend, mysite contains all non-framework code as a practice of SilverStripe).
If I were to ditch SilverStripe and move my UI to a different platform, or simply place this UI module on a different server by itself, I would have to go through all of my files and manually change each URL to point to the correct paths if the new framework discouraged the same module directory structure as Silverstripe, or if I decide to plop the scripts in a different place altogether.
There are a couple different routes I can think of right here and now to address this, if this is something that the guide should cover.

Specify an APP_DIR constant in the module config that contains the relative-to-base path to the module code, and then inject this constant into any directive or controller that will need to call in templates or partials. This will make it so there is only one file that needs to be edited if the code base is moved, and module authors can document this as something that needs to be changed.
Use a Grunt/Gulp build task (e.g. grunt-angular-templates to get all .html files in a module, giving them to $templateCache.

ngInclude should be avoided. Use a component instead.
I agree with you about templateUrl and constants but you cannot use angular.module.constant because you cannot declare the component factory method when writing a component. You are limited to the definition object.
You have to do that :
angular
    .module('sales.widgets')
    .component('acmeSalesCustomerInfo', {
        templateUrl: 'app/sales/widgets/acme-sales-customer-info.html',
        bindings: {
            data: '<',
            onWhateverClick: '&'
        },
        controller: salesCustomerInfo
    });

    function salesCustomerInfo(/* component controller injections are here */) {
        /* implementation details */
    }

You cannot do that :
angular
    .module('sales.widgets')
    .component('acmeSalesCustomerInfo', acmeSalesCustomerInfoComponent);

    acmeSalesCustomerInfoComponent.$inject = ['TEMPLATES_URL'];

    function acmeSalesCustomerInfoComponent(TEMPLATES) {
        return {
            templateUrl: TEMPLATES + '/acme-sales-customer-info.html',
            bindings: {
                data: '<',
                onWhateverClick: '&'
            },
            controller: salesCustomerInfo
        };
    }

    function salesCustomerInfo(/* component controller injections are here */) {
        /* implementation details */
    }

Anyway you could use external file with global var as constants and used IIFE to inject them, example :
(function (angular, TEMPLATES_URL) {
    'use strict';

    angular
        .module('sales.widgets')
        .component('acmeSalesCustomerInfo', {
            templateUrl: TEMPLATES_URL.SALES.WIDGETS + '/acme-sales-customer-info.html',
            bindings: {
                data: '<',
                onWhateverClick: '&'
            },
            controller: salesCustomerInfo
        });

    function salesCustomerInfo() {
        /* implementation details */
    }

})(angular, TEMPLATES_URL);

Something like that.

In that case, I feel it would be much more prudent to have HTML template files compiled into calls to $templateCache.put() in a run block, seeing how components cannot have a factory. I've experimented with this approach since I posted and I find it to be easy and fitting for the style being put forth.
In general, you point grunt-angular-templates at a file list, and it generates an Angular run block that calls $templateCache.put() with each template file path and its contents. So it finds app/sales/widgets/acme-sales-customer-info.html at compile time, and makes it so your app always has app/sales/widgets/acme-sales-customer-info.html available when the module is included, even if the file doesn't exist on the server.

...I didn't mean to close this issue with that comment. Sorry.


Key error - Incorrect parsing of Amino acids

Dear authors,
I tried to re-train Instanovo using your Hugginface dataset: https://huggingface.co/datasets/InstaDeepAI/instanovo_ninespecies_exclude_yeast
To do so, I changed the config file parameter "dec_precursor_sos:" to True.
I experience multiple key error bugs during training.
I am running following command:
python -m instanovo.transformer.train ../train-00000-of-00002-ca1fbc3de7c99259.parquet ../validation-00000-of-00001-b84568f5bf3ba95d.parquet --n_workers 128
I get following error:
INFO:root:Initializing training.
INFO:root:Vocab: {0: 'G', 1: 'A', 2: 'S', 3: 'P', 4: 'V', 5: 'T', 6: 'C(+57.02)', 7: '(+57.02)', 8: 'C(+57.02', 9: 'L', 10: 'I', 11: 'N', 12: 'D', 13: 'Q', 14: 'K', 15: 'E', 16: 'M', 17: 'H', 18: 'F', 19: 'R', 20: 'Y', 21: 'W', 22: 'M(+15.99)', 23: 'M(+15.99', 24: '(+15.99)', 25: '(+.98)', 26: 'N(+.98)', 27: 'Q(+.98)'}
INFO:root:Loading data
INFO:root:Data loaded: 249,701 training samples; 571 validation samples
INFO:root:Updates per epoch: 7,804, step_scale=1.0
INFO:root:Sample batch:
INFO:root: - spectra.shape=torch.Size([32, 200, 2])
INFO:root: - precursors.shape=torch.Size([32, 3])
INFO:root: - spectra_mask.shape=torch.Size([32, 200])
INFO:root: - len(peptides)=32
INFO:root: - peptides_mask=None
INFO:root:Model loaded with 94,614,558 parameters
INFO:root:Test forward pass:
INFO:root: - y.shape=torch.Size([32, 38, 30])
INFO:root:Initializing PL trainer.
Auto select gpus: [0, 1, 2]
GPU available: True (cuda), used: True
TPU available: False, using: 0 TPU cores
IPU available: False, using: 0 IPUs
HPU available: False, using: 0 HPUs
Initializing distributed: GLOBAL_RANK: 0, MEMBER: 1/1
INFO:torch.distributed.distributed_c10d:Added key: store_based_barrier_key:1 to store for rank: 0
INFO:torch.distributed.distributed_c10d:Rank 0: Completed store-based barrier for key:store_based_barrier_key:1 with 1 nodes.
----------------------------------------------------------------------------------------------------
distributed_backend=nccl
All distributed processes registered. Starting with 1 processes
----------------------------------------------------------------------------------------------------

LOCAL_RANK: 0 - CUDA_VISIBLE_DEVICES: [0,1,2]

  | Name    | Type             | Params
---------------------------------------------
0 | model   | InstaNovo        | 94.6 M
1 | loss_fn | CrossEntropyLoss | 0
---------------------------------------------
94.6 M    Trainable params
0         Non-trainable params
94.6 M    Total params
378.458   Total estimated model params size (MB)
SLURM auto-requeueing enabled. Setting signal handlers.
INFO:torch.nn.parallel.distributed:Reducer buckets have been rebuilt in this iteration.
Epoch 0:  22%|██▏       | 576/2605 Traceback (most recent call last):]

/.local/lib/python3.8/site-packages/torch/nn/modules/module.py", line 1194, in _call_impl
    return forward_call(*input, **kwargs)
.local/lib/python3.8/site-packages/depthcharge/components/transformers.py", line 422, in forward
    tokens = [self.tokenize(s) for s in sequences]
.local/lib/python3.8/site-packages/depthcharge/components/transformers.py", line 422, in <listcomp>
    tokens = [self.tokenize(s) for s in sequences]
/.local/lib/python3.8/site-packages/depthcharge/components/transformers.py", line 183, in tokenize
    tokens = [self._aa2idx[aa] for aa in sequence]
.local/lib/python3.8/site-packages/depthcharge/components/transformers.py", line 183, in <listcomp>
    tokens = [self._aa2idx[aa] for aa in sequence]
KeyError: 'N(+.98'

I guess this is caused by incorrect parsing of the peptide sequence. I can "solve" this issue by adding N(+.98 to the list of accepted AAs in the config file. I experience similar bugs with the other modifications. Is there a solution to this behavior or is this caused by the dataset?

Hi, this is actually an error in the dataloader from when we updated the schema of the datasets. In the original schema, the modified_sequence column was wrapped in _.
The lines here and here should not have the [-1,1] indexing. Eg.:
peptide = row["modified_sequence"][1:-1]

should become
peptide = row["modified_sequence"]

Fixing this now...


Fix portfolio card header overflow.

If the portfolio title was too long the text was overflowing the card and button actions were pushed to next line.
Before => After

Thanks @lgalis for noticing this

Codecov Report

Merging #218 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #218   +/-   ##
=======================================
  Coverage   86.82%   86.82%
=======================================
  Files          95       95
  Lines         941      941
  Branches       84       84
=======================================
  Hits          817      817
  Misses        116      116
  Partials        8        8

Impacted Files
Coverage Δ

...onal-components/portfolio/portfolio-card-header.js
100% <ø> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c5bf30c...42ae78a. Read the comment docs.


Do not show for preview window

Signed-off-by: Zang MingJie<EMAIL_ADDRESS>

Good call.  Merged, thank you.


deconz: 2.26.3 -> 2.27.6

Description of changes
Update to latest version.
I tested it with my ConBee2 on nixos-24.05.

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[x] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Apparently upstream has a login redirect bug which means that accessing http://myserver/ wrongly redirects to http://myserver/pwa/login.html (non-functional) instead of the correct http://myserver/pwa/login2.html (note the '2').
https://forum.phoscon.de/t/web-access-not-working/5023/3
The workaround is to not rely on the redirect.
(I didn't notice this issue at first, because I was already logged in during the upgrade.)

Apparently upstream has a login redirect bug which means that accessing http://myserver/ wrongly redirects to http://myserver/pwa/login.html (non-functional) instead of the correct http://myserver/pwa/login2.html (note the '2').
https://forum.phoscon.de/t/web-access-not-working/5023/4

Fixed in the 2.28.0 release: https://github.com/NixOS/nixpkgs/pull/335068


fix: fusefs use under FreeBSD 13

kldload fuse.ko now throws an error, as per the install message, it seems kldload fusefs should be used instead.
Using fuse with the latest version throws this error:
exec ssh: pkg  install  -y fusefs-sshfs && kldload  fuse.ko && sshfs -o allow_other,default_permissions runner@<IP_ADDRESS>:work /Users/runner/work
[command]/usr/bin/ssh -t freebsd
[...]
=====
Message from fusefs-libs3-3.10.2_1:

--
Install the FUSE kernel module (kldload fusefs) to use this port.
[...]
For further options see ``sshfs -h''.
kldload: can't load fuse.ko: No such file or directory

Release with fix?

@tsuckow
done.


Activity log to include read operations of buckets

When using noobaa api events_api read_activity_log '{}' I am able to view Upload/Delete events for the buckets.
Would like to have a configuration option which would allow us to record Read events as well.
Is the file https://github.com/noobaa/noobaa-core/blob/master/src/endpoint/s3/ops/s3_get_bucket.js the only the place we need to update in order to achieve this?

Any suggestions for the above? Would love to contribute the feature also, just need some pointers.

Invoking @guymguym :D


onnx ver.1.4 is not supported

I am using the Pytorch ver 1.0.0 which is exporting onnx model in ver 1.4.0, directly lead to the upsample operation transfering failed.
the representation of Upsample-op in the older version is now supported looks like
{
'Upsample',
inputs=['X'],
outputs=['Y'],
mode='nearest',
width_scale=2,
height_scale=2,
}
but in the new verison of ONNX, Upsample-op looks like
{
'Upsample',
inputs=['X', 'scales'],
outputs=['Y'],
mode='nearest',
}
Is there a way to modify the model_optimizer source code to make it work tranfering the new ops in ONNX and if yes how can I do it efficiently?
Any advice is welcome !

Zyu Zyu what is the exact error which Model Optimizer is giving you for the new version ?

@shubha-ramani Thanks for your reply. The error message is 'One/both of widths_scale = {} and height_scale = {} is not defined for Upsampe node {}.' which located on model_optimizer/extensions/front/onnx/upsample_ext.py line 70.

Zyu it seems you are right, given the current code located at : https://github.com/opencv/dldt/blob/2018/model-optimizer/extensions/front/onnx/upsample_ext.py
Which does not match the latest PyTorch documentation:
https://pytorch.org/docs/stable/nn.html
I will file a bug. Thank you for using OpenVino.
PS. If you want to hack upsample_ext.py as a temporary workaround and later submit a pull-request yourself feel free.
Shubha

@shubha-ramani Thank you for comfirming my work. I'm new to the sourse code here now. I will submit a pull-request as long as I finished this work.

I wonder if there will be timeline to fix this issue. In ONNX, Upsample-9 op supports dynamic scales, which makes "scales" an input instead of an attribute. I didn't find a way to extract the value of input and convert to attribute in model-optimizer. Is there any hint on that?

@wuhy08 Wondering the same, cause it's not possible from what I know to convert a PyTorch model to an ONNX v9 model.

@wuhy08 Wondering the same, cause it's my model has the "Expand" layer what isn't supported < Opset v9

@wuhy08 Wondering the same, cause my model has the "Expand" layer what isn't supported < Opset v9

Hi @Aeroxander
I don't have Expand Op in my model so I cannot comment on that. But based on ONNX manual, Expand is just broadcasting. I wonder if you can change that Op to Reshape in the model.

@wuhy08 I tried it with this issue but I get Blob "37" not found in const blobs during the loading of the ONNX model after the Expand layer is initialized when I try to map the Expand layer to type "Scale".
I'm just not that familiar with adding layers to OpenCV yet and how OpenCV works with broadcasting.
So tried to emulate how Numpy broadcast in this way:
layerParams.blobs.push_back(Mat::ones(blob.cols, blob.rows, blob.type()));
layerParams.type = "Scale";

But then I get the blob not found error.
When I try to map it to "Reshape" instead of "Scale" I get:
Can't create layer 37 of type Expand in function 'cv::dnn::LayerData...

@ZyuZyuZyu is this issue still actual?

It seems that the issues is not actual anymore as no response. Closing it. Feel free to reopen it or create a new one.


Multi-gpu training

Hi,
Thanks for sharing the code! Does your code support dp or ddp training? I tried running your training script but it seemed that it only supports single-gpu. Could you please tell me how to train your model with dp or ddp?

Thank you for your interest. I planned to update the code recently to support this.


Open epub from url

Hello
How open url epub file without download to cash browser?
thank you

Just put it after the # symbol at the end of the url.

i cant open epub book using its url
even after concatenating the file at the end of the url with #
my case i want to open the files using hyperlinks or passing physical paths instead of uploading

To use local files directly, you need to run ePubViewer in something like NW.js or Electron, or you need to serve the files from a local server. To use files from another server, it needs to have CORS configured correctly.

any solution for this? always looking for this..

i cant open epub book using its url even after concatenating the file at the end of the url with #
my case i want to open the files using hyperlinks or passing physical paths instead of uploading

have you found?

Write the url like this:
https://pgaskin.net/ePubViewer/#//raw.githubusercontent.com/scillidan/repo_cos/main/epub/Alice_in_Wonderland.epub

You can see it.
And If you put .epub file in ePubViewer's folder, you can write it like:
http://localhost:4002/#Alice_in_Wonderland.epub


BLE Mesh Provisioner generates value 0 outside of Specification for Push, Twist (IDFGH-5079)

Environment

Development Kit: ESP32-C3-DevKitM-1
Kit version [v1.0]
Module or chip used: ESP32-C3-Mini-1
IDF version (run git describe --tags to find it):
v4.4-dev-744-g1cb31e509
Build System: idf.py
Compiler version (run xtensa-esp32-elf-gcc --version to find it):
riscv32-esp-elf-gcc (crosstool-NG <IP_ADDRESS>_64eb9ff) 8.4.0
Operating System: Linux
Using an IDE?: Yes VS Code
Power Supply: USB

Problem Description
When using the Input OOB Push method, 0 is output sometimes, which is invalid per spec.  Likely an issue with input OOB Blink, Beep, and Vibrate as well in Node device.
Mesh Profile Spec v1.0.1
When the Authentication Method 0x03 (Authentication with Input OOB) method is used and when Input OOB Action for the Authentication Action value is equal to Push, then the Provisioner shall select a random integer between 0 and 10 to the power of the Authentication Size exclusive. That random number shall be input by the number of push actions. When Input OOB Action for the Authentication Action value is equal to Twist, then the Provisioner shall select a random integer between 0 and 10 to the power of the Authentication Size exclusive. That random number shall be input by the number of twist actions until the value on the control has been entered.
Expected Behavior
Push Button OOB to be 1-9
Actual Behavior
Sometimes it will be 0
Steps to reproduce

Setup Provisioner for BLE Mesh
Configure Node on BLE Mesh to use Input Push Button Auth
During Auth Procedure Provisioner will sometimes output 0 for Button Presses

Code to reproduce this issue
See https://github.com/espressif/esp-idf/blob/master/components/bt/esp_ble_mesh/mesh_core/prov.c:753

@dastarling Can you provide some logs?


Modifications to support nosetests in Travis

In this PR, .travis.yml has been modified to correctly set up a test environment on the Travis worker in order to run nosetests.
Now we are able to get all of our dependencies correctly...including postgis and gdal! The problem was that the standard Travis worker runs precise (Ubuntu 12.04) whereas we need a newer version of gdal (>1.10), which can be found in the trusty (Ubuntu 14.04) repos. The fix was to specify that a trusty worker was needed.
This branch has also been merged with the changes introduced in the autodeploy branch. The changes from there are necessary to get our plenario package to deploy correctly through CloudFormation.
Finally, there has been a slight change to plenario/__init__.py in which an import was moved into a function instead of at the root of the file. The problem was that init_db.py was calling __init__.py, and accordingly this import, which contained resources which called tables in the database...before the database was initialized by init_db.py.

The keys are still the old keys for my geosir repo. I will update them for this repo tomorrow.

I've updated the encryption keys in .travis.yml and fixed any merge conflicts. This branch is now ready to be merged into master.


Cannot save config with sector roots pruning disabled

Current Behavior
The UI considers Prune Sector Roots a required field and doesn't allow saving the config if it is disabled.

Expected Behavior
Should be able to save the config regardless.
Steps to Reproduce
No response
Version
Latest master
What operating system did the problem occur on (e.g. Ubuntu 22.04, macOS 12.0, Windows 11)?

No response

We should probably slightly change the copy too, "old" and "new" hosts is quite vague I think. I would completely drop the part on it being slow on pre 1.6.0 hosts too. Maybe just:

When enabled, the autopilot will prune deleted sector roots from all contracts. These roots can be safely removed because they where linked to objects that have been deleted, and thus no longer need to be paid for.

fixed


Optional type as required if used in one branch of nested promises

Bug Report
The system falsely reports an optional property as required if one branch returns the one optional property, but a second branch skips it and returns another optional property.
🔎 Search Terms
promise, catch, optional property
🕗 Version & Regression Information

3.1.4
nightly (4.2.0-dev.20210112)

⏯ Playground Link
This playground shows 3 examples of the code posted below, where I commented out specific parts of the code. If you remove the comments in a variant, it will show the error:
https://www.typescriptlang.org/play?#code/KYDwDg9gTgLgBDAnmYcAiBDGG4F44AKUEAtgJYDOwAPAN4BQcTcUwAjgK5msAmREKWIgBccAHYcSAI2BQA3I2YCYZCGIwAbfoKQBGAPyiJ02QuZxlq9VuI7EAJkPjJM+fQC+APjNx6AYzUKeAA3DCgyDCkNYFFMbDxCYnIqADpWCggNYOAACnsASnoUmAALYDEcnLBiACtgPxh8vE84BiYyADM4HIBCaog6hqa25lYYDigxVsVzVk5uYD5bWSRRAAYAGhmlMBU1TW0VxF1Re03t9x93OGANKmnzAHpHsYmp-mTgNOAMrNyAbQAuvlimUKjkmrgWiNZsBxpMHuZRuwuLxDkJ1lskTs9tZ0Uh7KJdOdsZdts93Pkrh5Cik-Fg-CVKpCWjkRpZ9jYBEcTnBiViWCiFktuRi4OdKVT6P5AiEwhEosBCegsDh8B9KF90plsnlaaVypV+oNGs1EZ1un1avVTTDBfCpnamHNUYt8SJxQKno8OXjlkJeWcvXAyUxrrd7nbXgiNaltX8ckCQQbwSzEbCHemkS7he7MdtzL6Dv6CUSSUjQ8xKdTKUV6TBGcyzWzFEWuXZefzFDm0SWPRL8lKZWIgnBQuFItEAMyxVUJWNan463IFIopo3WoZmkYW3rGm3DbbRx0FwXzXui1ae09t92B8thq43O6oKNwt6JUia76-XVJ0GGhC26nseWawuebp9vm2JMLefbKl2pI+GGUphjS9DPHSDJMkBULdAwzywbsVjFpexxllshFnq6Ip2PmFKDgow6-F8GgQAA5jk44KtEGxjvKk5Knx3GCVOhRAA
💻 Code
export type Data = Promise<{
    requiredProperty: number;
    optionalProperty1?: number;
    optionalProperty2?: number;
}>;

const variable: Data = Promise.resolve(2)
.then((project) => {
  if (!project) {
    return {
      requiredProperty: 0,
      optionalProperty1: 20,
    };
  } else {
    return Promise.resolve([]).then(() => {
      return {
        requiredProperty: 0,
        optionalProperty2: 10,
      };
    });
  }
})
.catch(() => ({
  optionalProperty1: 10,
  requiredProperty: 0,
}));

🙁 Actual behavior
⠏ (3/3) Building...
test.ts:7:7 - error TS2322: Type 'Promise<number | { optionalProperty1: number; requiredProperty: number; }>' is not assignable to type 'Data'.
  Type 'number | { optionalProperty1: number; requiredProperty: number; }' is not assignable to type '{ requiredProperty: number; optionalProperty1?: number | undefined; optionalProperty2?: number | undefined; }'.
    Type 'number' is not assignable to type '{ requiredProperty: number; optionalProperty1?: number | undefined; optionalProperty2?: number | undefined; }'.

7 const variable: Data = Promise.resolve(2)
        ~~~~~~~~

test.ts:8:7 - error TS2345: Argument of type '(project: number) => Promise<{ requiredProperty: number; optionalProperty2: number; }> | { requiredProperty: number; optionalProperty1: number; }' is not assignable to parameter of type '(value: number) => { requiredProperty: number; optionalProperty2: number; } | PromiseLike<{ requiredProperty: number; optionalProperty2: number; }>'.
  Type 'Promise<{ requiredProperty: number; optionalProperty2: number; }> | { requiredProperty: number; optionalProperty1: number; }' is not assignable to type '{ requiredProperty: number; optionalProperty2: number; } | PromiseLike<{ requiredProperty: number; optionalProperty2: number; }>'.
    Type '{ requiredProperty: number; optionalProperty1: number; }' is not assignable to type '{ requiredProperty: number; optionalProperty2: number; } | PromiseLike<{ requiredProperty: number; optionalProperty2: number; }>'.
      Property 'optionalProperty2' is missing in type '{ requiredProperty: number; optionalProperty1: number; }' but required in type '{ requiredProperty: number; optionalProperty2: number; }'.

8 .then((project) => {
        ~~~~~~~~~~~~~~

  test.ts:18:9
    18         optionalProperty2: 10,
               ~~~~~~~~~~~~~~~~~~~~~
    'optionalProperty2' is declared here.

ℹ (3/3) Building...found 2 errors

🙂 Expected behavior
Should work without reporting any errors.
Please explain if this was intended in any way.

I think that this is something that can't be easily fixed. The problem is that TS has no idea that those values can be somehow unified, promises are not that special for the compiler.
The computed signature of the first callback here is:
(project: number) => Promise<{ requiredProperty: number; optionalProperty2: number; }> | { requiredProperty: number; optionalProperty1: number; }

and that is being used as an inference source for this signature:
(value: number): TResult1 | PromiseLike<TResult1>

On top of that... non-naked targets are preferred and that's why the inference gets fixed with { requiredProperty: number; optionalProperty2: number; }.
You can workaround this by either declaring the types manually to aid the compiler or by using async/await syntax. This is likely, not fixable without making the compiler treat raw Promise-based code how it treats async/await.

As @Andarist has pointed out, this is a limitation of the type system making the best of the information it has at hand, and there are a lot of moving parts that cause a problem here. In the variable example, we can contextually type the return type of .catch from Data, but that contextual type doesn't flow backwards to the preceding .then().

This is likely, not fixable without making the compiler treat raw Promise-based code how it treats async/await.

I don't think this is feasible. As you said, TS doesn't treat Promise as anything special, and often has to also handle PromiseLike as well as any other non-native Promise/A+-compatible definitions.


Setup CI

The project has tests to prevent anything from breaking, but there's no system in place to check new PRs. Would make sense to add TravisCI or CircleCI to test this.
I can make a PR if you want :)

I suggest adding the php-cs check

Closing this as an issue... I'll get Travis set up shortly and then we can merge #326.


unsupported protocol scheme "" when uploading to S3

Describe the bug
I have configured storage to use Backblaze bucket, S3 compatible, but when trying to upload a file the logs show an error:
"method":"POST","uri":"/api/v1/resource/blob","status":500,"error":"code=500, message=Failed to save resource, internal=Failed to upload via s3 client: operation error S3: PutObject, exceeded maximum number of attempts, 3, https response error StatusCode: 0, RequestID: , HostID: , request send failed, Put \"/s3.path-to-bucket-endpoint?x-id=PutObject\": unsupported protocol scheme \"\""}

Steps to reproduce

Configure S3 storage in settings
Try to create a new note and attach a jpg file

Screenshots or additional context
I am running Memos in docker on Ubuntu server, behind nginx proxy with Let's Encrypt SSL

Try to add the URL Scheme (http:// or https://) before the S3 Base URL.
This fixed the error for me.
Note: You should NOT Transmit your data over http to S3, because anybody can read your files!
(This should only even be possible with custom, self-hosted S3 Servers)


Adding ACM.DnsValidatedCertificate failes

Thanks for the guide and the example project (and sorry for the stupid pull-request).
I have tried to extend your example by adding a DnsValidatedCertificate to the domain stack. After several days and a lot of headache I still can't get it to work. An I just don't know why.
Maybe this is more likely to be a question for stackoverflow, but since the base is your code, maybe you have an idea what could be wrong?
What I did:

Added a custom role for the CDKBuild since I need access to 'route53:ListHostedZonesByName'
Route53.HostedZone.fromLookup() <- I checked it with console.log(). It works.
Added new ACM.DnsValidatedCertificate().

The build action works fine. But the deployment of the domain stack fails:

[AssetParameters0b9723d54b7db3-------782a949b4372d0f0ArtifactHashF8F836D1, AssetParameters0b9723d54b7db3fbf-----a949b4372d0f0S3VersionKey83D9C166, AssetParameters0b9723d54b7db3-----80782a949b4372d0f0S3Bucket0997A4A0] must have values (Service: AmazonCloudFormation; Status Code: 400; Error Code: ValidationError; Request ID: c5803b8c-73f8------91b6-b-----2f432)

If I try to deploy it from my local machine with:

yarn cdk deploy cra-serverless-domain -r arn:aws:iam::------:role/cra-serverless-pipeline-PipelineDeployDomainRole-----

It works. I have really no idea at all why it failing in was CodePipeline.
Changes I made:
https://github.com/nullsumme/cra-serverless/commit/5ca5fd4395131ef2aafb58c77d6445952fa1bde4

Not sure if this is related but the recently announced CDK Pipelines construct library doesn't (yet?) support context queries:

No context queries – Context queries are not supported. That means that Vpc.fromLookup() and other functions like it don’t work.


Return to vimunit testing

With tests it is easier to prepare example of completion that does not work properly or to see that some modification caused unexpected side effect. Please see vimunit_tests branch.

Merged.

Merged.


Uri.encodeFull doesn't encode url

var wishoooUrl = Uri.encodeFull('https://www.newzem.com/index.php?route=product/product&product_id=1445');
print('encoded: '  + wishoooUrl);

It returned the url as it is not encoded!
had to use the Uri.encodeQueryComponent for the whole url

You may have better luck opening this over at https://github.com/dart-lang/sdk/issues/new

(closed as this is now tracked in dart bug database)


Runtime Error with new and delete Operator

Hi Hugh,
I ran into some issues when attempting to test a CUDA project that was successfully compiled with Coriander, and I encountered this error message:
_Znwm is called, but not defined
basicblockdumper.runGeneration got exception whilst processing:  %6 = tail call i8* @_Znwm(i64 18112) #11

After some digging, I realized that this was related to the new operator and removed it. I then ran into this error
_ZdaPv is called, but not defined
basicblockdumper.runGeneration got exception whilst processing:  tail call void @_ZdaPv(i8 addrspace(1)* %20) #11

And realized that it was related to the delete operator. Is there any existing support for these operators? Or are there any plans to support them?

Can you try to create a very tiny test case, eg use the examples in the test/cocl folder as a basis, so I can reproduce the issue on my own machine?

Yes, new and delete operators are called from inside the kernel

Oh wow. This is new information for me :-) . A very simple test case I can use would be good though.  I doubt I'm going to implement this any time soon.  But depends.  As far as how to implement it ....
it could be possible actually.  This would tie into the new virtual memory management that's sort of evolving. Basically, we'd allocate one gi-normous gpu buffer right at the start, from the hostside, inside coriander, and then just dole out little bites of this when people do cudaMalloc etc hostside. We could then pass this single buffer into kernels, and dole out bits of that to the kernel itself.
Well... hmmm... yeah... that should work.  We already started to handle virtual memory device-side, https://github.com/hughperkins/coriander/blob/31739d97d951531ffef47efe882beaf6c380c29a/src/kernel_dumper.cpp#L178-L188
struct GlobalVars {
    local int *scratch;
    global char *clmem0;
    unsigned long clmem_vmem_offset0;
};
inline global float *getGlobalPointer(__vmem__ unsigned long vmemloc, const struct GlobalVars* const globalVars) {
    return (global float *)(globalVars->clmem0 + vmemloc - globalVars->clmem_vmem_offset0);
}

What is your use-case? To what extent can you work around this issue for now?

The use case requires allocating and de-allocating memory on the fly and in parallel, though I'll have to estimate the effort to work around the issue for now.
As for a test case I've taken a sample from the CUDA samples and tweaked it. There is another issue I forgot to bring up, when trying to allocate the allocation limit for a thread, the following error is thrown:
error: use of undeclared identifier
      'cudaLimitMallocHeapSize'
    cudaThreadSetLimit(cudaLimitMallocHeapSize, 128 * (1 << 20));

I've commented it out so you can see the runtime error
newdelete.tar.gz

Allocating in parallel is possible, as long as we store the vmem table in local memory. Note that only one kernel can run at a time, and no hostside allocations of GPU memory should occur whilst it is running.
On 8 June 2017 10:27:05 BST, Adel Johar<EMAIL_ADDRESS>wrote:

The use case requires allocating and de-allocating memory on the fly
and in parallel, though I'll have to estimate the effort to work around
the issue for now.
As for a test case I've taken a sample from the CUDA samples and
tweaked it. There is another issue I forgot to bring up, when trying to
allocate the allocation limit for a thread, the following error is
thrown:
error: use of undeclared identifier
     'cudaLimitMallocHeapSize'
   cudaThreadSetLimit(cudaLimitMallocHeapSize, 128 * (1 << 20));

I've commented it out so you can see the runtime error
newdelete.tar.gz
--
You are receiving this because you commented.
Reply to this email directly or view it on GitHub:
https://github.com/hughperkins/coriander/issues/35#issuecomment-307049856

--
Sent from my Android device with K-9 Mail. Please excuse my brevity.

Actually... If we store the vmem table in global memory, we can allocate in parallel across multiple kernels and hostside.
On 8 June 2017 10:27:05 BST, Adel Johar<EMAIL_ADDRESS>wrote:

The use case requires allocating and de-allocating memory on the fly
and in parallel, though I'll have to estimate the effort to work around
the issue for now.
As for a test case I've taken a sample from the CUDA samples and
tweaked it. There is another issue I forgot to bring up, when trying to
allocate the allocation limit for a thread, the following error is
thrown:
error: use of undeclared identifier
     'cudaLimitMallocHeapSize'
   cudaThreadSetLimit(cudaLimitMallocHeapSize, 128 * (1 << 20));

I've commented it out so you can see the runtime error
newdelete.tar.gz
--
You are receiving this because you commented.
Reply to this email directly or view it on GitHub:
https://github.com/hughperkins/coriander/issues/35#issuecomment-307049856

--
Sent from my Android device with K-9 Mail. Please excuse my brevity.

We can store the vmem table at the start of the ginormous buffer, in global memory.
On 8 June 2017 10:27:05 BST, Adel Johar<EMAIL_ADDRESS>wrote:

The use case requires allocating and de-allocating memory on the fly
and in parallel, though I'll have to estimate the effort to work around
the issue for now.
As for a test case I've taken a sample from the CUDA samples and
tweaked it. There is another issue I forgot to bring up, when trying to
allocate the allocation limit for a thread, the following error is
thrown:
error: use of undeclared identifier
     'cudaLimitMallocHeapSize'
   cudaThreadSetLimit(cudaLimitMallocHeapSize, 128 * (1 << 20));

I've commented it out so you can see the runtime error
newdelete.tar.gz
--
You are receiving this because you commented.
Reply to this email directly or view it on GitHub:
https://github.com/hughperkins/coriander/issues/35#issuecomment-307049856

--
Sent from my Android device with K-9 Mail. Please excuse my brevity.

We can store the vmem table at the start of the ginormous buffer, in global memory.

I imagine it would be possible to allocate a certain size, though support for the following function should be considered too
cudaThreadSetLimit(cudaLimitMallocHeapSize, <value>);
How long would it take to have this implemented in Coriander? I ask this because the current project I'm porting has a lot of intertwining dependencies on new and delete, and it would take a long time just to work around these dependencies.


Implement generator of inductive constants and recursion rules

We should write functions to generate the constructors and recursors of inductive types, along with their respective types, from inductive declarations. So, for instance, from
inductive Nat where
| Zero : Nat
| Succ : Nat -> Nat

we should generate the constants
Nat : Type
Nat.Zero : Nat
Nat.Succ : Nat -> Nat
Nat.rec{u} :
  {motive : Nat → Sort u} →
  motive Nat.Zero →
  ((a : Nat) → motive a → motive (Nat.Succ a)) →
  (t : Nat) →
  motive t

and the recursion rule associated with Nat.rec

This is related to #136. We can either create our recursors or validate the ones provided


Bump pip-tools to 7.0.0

Pip v23.2 broke pip-tools, there is a fix in 7.0.0. This change also pins pip and setuptools to prevent future breakages.

@AnthonyDiGirolamo is there a way to have constraints include cython for example?

We may miss it now. I believe this PR has two things against cython:

it is build with python 3.11
even if built with python 3.9, we removed gdbgui which removes gevent which removes cython

@AnthonyDiGirolamo is there a way to have constraints include cython for example?

We may miss it now. I believe this PR has two things against cython:

it is built with python 3.11 (gdbgui was excluded in that version)
even if built with python 3.9, we removed gdbgui which removes gevent which removes cython

Sure, but I'm guessing the python deps are larger than this requirements set? It seems awfully small for the surface area we have.

I believe we could add this to requirements.all.txt
cython==0.29.36 ; python_version < "3.11"
cython==3.0.0 ; python_version >= "3.11"
Then just remove --strip-extras when running pip-compile.
Note I don't know if that's the right version to check for cython. Was just trying to pick one version for python 3.11 and a separate for 3.10 and lower.

I believe we could add this to requirements.all.txt
cython==0.29.36 ; python_version < "3.11" cython==3.0.0 ; python_version >= "3.11"
Then just remove --strip-extras when running pip-compile.
Note I don't know if that's the right version to check for cython. Was just trying to pick one version for python 3.11 and a separate for 3.10 and lower.

Thanks! More my question was, how can we have this build a fully recursive and exhaustive set. This isn't the first time we've been bitten here.

Passing in all the requirements.txt files to pip-compile does that:
pip-compile --output-file=constraints.txt --resolver=backtracking --strip-extras --allow-unsafe requirements.*.txt

here's the result:
constraints.txt

Passing in all the requirements.txt files to pip-compile does that:
pip-compile --output-file=constraints.txt --resolver=backtracking --allow-unsafe requirements.*.txt

here's the result: constraints.txt

Thanks!
Is removing --strip-extras the difference from what we have?

Is removing --strip-extras the difference from what we have?

Yeah, just that and passing in all the requirements files.

@woody-apple @andy31415 Should I add the fully expanded constraint to this PR?

@woody-apple @andy31415 Should I add the fully expanded constraint to this PR?

I would not add cython in particular here because we do not depend on cython anymore. The cython error was because we generated this on a python 3.11 and that guarded off some things.
So ideally we should run this on a docker image that is recent on 3.9 and update when CI is 3.11. Right now we have itsdangerous<2.1 ; python_version < "3.11" on esp32, so that is something that is missing.

@woody-apple @andy31415 Should I add the fully expanded constraint to this PR?

I would not add cython in particular here because we do not depend on cython anymore. The cython error was because we generated this on a python 3.11 and that guarded off some things.
So ideally we should run this on a docker image that is recent on 3.9 and update when CI is 3.11. Right now we have itsdangerous<2.1 ; python_version < "3.11" on esp32, so that is something that is missing.

requirements.all should include all others right? I think that is sufficient.

On second thought, let's do that in a follow up. This just pins pip and pip-tools correctly.

On second thought, let's do that in a follow up. This just pins pip and pip-tools correctly.

Yes, I believe that different freezing is a separate problem. We should pick one of the paths:

move CI to python 3.11
switch constraints to be generated by a python 3.9 system

@woody-apple @andy31415 Should I add the fully expanded constraint to this PR?

Let's handle fully expanding this later :) (but soon please!)

On second thought, let's do that in a follow up. This just pins pip and pip-tools correctly.

Yes, I believe that different freezing is a separate problem. We should pick one of the paths:

move CI to python 3.11
switch constraints to be generated by a python 3.9 system

We're moving CI to Python 3.11, that should be done tonight.


rgh-netiquette: Add "Don't comment" banner

In some issues, the author wrote "Please do not leave comments", because those issues are not meant for discussion.
This PR adds a banner to issues with such requests in rgh-netiquette.
The /regex/ may not be perfect, please test if it works on other issues
Test URLs

https://github.com/refined-github/refined-github/issues/7404
https://github.com/refined-github/refined-github/issues/7000
https://github.com/refined-github/refined-github/issues/6000

Screenshot

Thank you for the interest! However this is extremely rare so it's not worth running this regex on every single page load. On 7000 issues/PRs we only have like 6 issues where I said "don't leave comments"


crash in scan.rb - no implicit conversion of nil into Array

New Issue Checklist

[ x ] Updated fastlane to the latest version
[ x ] I have read the Contribution Guidelines

Issue Description
Complete output when running fastlane, including the stack trace and command used

You can use: --capture_output as the last commandline argument to get that collected for you

$ fastlane all
[16:02:06]: ------------------
[16:02:06]: --- Step: scan ---
[16:02:06]: ------------------
[16:02:06]: $ xcodebuild -list -workspace xxx.xcworkspace
[16:02:16]: Command timed out after 10 seconds on try 1 of 4, trying again...
[16:02:26]: Command timed out after 10 seconds on try 2 of 4, trying again...
[16:02:36]: Command timed out after 10 seconds on try 3 of 4, trying again...
[16:02:46]: Command timed out after 10 seconds on try 4 of 4
+------------------------+-------------------+
|                Lane Context                |
+------------------------+-------------------+
| DEFAULT_PLATFORM       | ios               |
| PLATFORM_NAME          | ios               |
| LANE_NAME              | ios all           |
| SCAN_DERIVED_DATA_PATH | build/DerivedData |
+------------------------+-------------------+
[16:02:46]: no implicit conversion of nil into Array
[16:02:47]: fastlane finished with errors
.../fastlane/lib/fastlane/actions/scan.rb:32:in `-': [!] no implicit conversion of nil into Array (TypeError)
	from .../fastlane/lib/fastlane/actions/scan.rb:32:in `ensure in run'
	from .../fastlane/lib/fastlane/actions/scan.rb:34:in `run'
	from .../fastlane/lib/fastlane/runner.rb:243:in `block (2 levels) in execute_action'
	from .../fastlane/lib/fastlane/actions/actions_helper.rb:50:in `execute_action'
	from .../fastlane/lib/fastlane/runner.rb:221:in `block in execute_action'
	from .../fastlane/lib/fastlane/runner.rb:217:in `chdir'
	from .../fastlane/lib/fastlane/runner.rb:217:in `execute_action'
	from .../fastlane/lib/fastlane/runner.rb:139:in `trigger_action_by_name'
	from .../fastlane/lib/fastlane/fast_file.rb:146:in `method_missing'
	from Fastfile:9:in `block (2 levels) in parsing_binding'
	from .../fastlane/lib/fastlane/lane.rb:33:in `call'
	from .../fastlane/lib/fastlane/lane.rb:33:in `call'
	from .../fastlane/lib/fastlane/runner.rb:192:in `try_switch_to_lane'
	from .../fastlane/lib/fastlane/fast_file.rb:282:in `test'
	from Fastfile:51:in `block (2 levels) in parsing_binding'
	from .../fastlane/lib/fastlane/lane.rb:33:in `call'
	from .../fastlane/lib/fastlane/lane.rb:33:in `call'
	from .../fastlane/lib/fastlane/runner.rb:49:in `block in execute'
	from .../fastlane/lib/fastlane/runner.rb:45:in `chdir'
	from .../fastlane/lib/fastlane/runner.rb:45:in `execute'
	from .../fastlane/lib/fastlane/lane_manager.rb:52:in `cruise_lane'
	from .../fastlane/lib/fastlane/command_line_handler.rb:30:in `handle'
	from .../fastlane/lib/fastlane/commands_generator.rb:105:in `block (2 levels) in run'
	from .../vendor/bundle/ruby/2.0.0/gems/commander-4.4.3/lib/commander/command.rb:178:in `call'
	from .../vendor/bundle/ruby/2.0.0/gems/commander-4.4.3/lib/commander/command.rb:178:in `call'
	from .../vendor/bundle/ruby/2.0.0/gems/commander-4.4.3/lib/commander/command.rb:153:in `run'
	from .../vendor/bundle/ruby/2.0.0/gems/commander-4.4.3/lib/commander/runner.rb:446:in `run_active_command'
	from .../fastlane_core/lib/fastlane_core/ui/fastlane_runner.rb:38:in `run!'
	from .../vendor/bundle/ruby/2.0.0/gems/commander-4.4.3/lib/commander/delegates.rb:15:in `run!'
	from .../fastlane/lib/fastlane/commands_generator.rb:302:in `run'
	from .../fastlane/lib/fastlane/commands_generator.rb:42:in `start'
	from .../fastlane/lib/fastlane/cli_tools_distributor.rb:65:in `take_off'
	from .../bin/fastlane:15:in `<top (required)>'
	from .../ruby-2.0.0-p648/bin/fastlane:23:in `load'
	from .../ruby-2.0.0-p648/bin/fastlane:23:in `<main>'
	from .../ruby-2.0.0-p648/bin/ruby_executable_hooks:15:in `eval'
	from .../ruby-2.0.0-p648/bin/ruby_executable_hooks:15:in `<main>'

Environment
Please run fastlane env and copy the output below. This will help us help you :+1:
If you used --capture_output option please remove this block - as it is already included there.
### Stack

| Key                 | Value                                       |
| ------------------- | ------------------------------------------- |
| OS                  | 10.11.6                                     |
| Ruby                | 2.0.0                                       |
| Bundler?            | true                                        |
| Git                 | git version 2.10.0                          |
| Installation Source | ~/.rvm/gems/ruby-2.0.0-p648/bin/fastlane    |
| Host                | Mac OS X 10.11.6 (15G1004)                  |
| Ruby Lib Dir        | ~/.rvm/rubies/ruby-2.0.0-p648/lib           |
| OpenSSL Version     | OpenSSL 1.0.2h  3 May 2016                  |
| Is contained        | false                                       |
| Is homebrew         | false                                       |
| Xcode Path          | /Applications/Xcode.app/Contents/Developer/ |
| Xcode Version       | 8.0                                         |

### fastlane gems

| Gem      | Version | Update-Status      |
| -------- | ------- | ------------------ |
| fastlane | 2.19.1  |   Update available |

Thanks for the fix in #8678 🚀


compiler-bridge_2.12:1.3.0 not compatible with scala-compiler:2.13.1

scala-maven-plugin uses precompiled compiler-bridge (as deployed in maven central).
It looks like version 1.3.0 is not compatible with 2.13.1.
java.lang.NoSuchMethodError: scala.tools.nsc.Settings.nowarn()Lscala/tools/nsc/settings/AbsSettings$AbsSetting;
xsbt.Command$.getNoWarn(Command.scala:42)
xsbt.DelegatingReporter$.apply(DelegatingReporter.scala:23)
xsbt.CachedCompiler0.<init>(CompilerInterface.scala:85)
xsbt.CompilerInterface.newCompiler(CompilerInterface.scala:28)
sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
java.lang.reflect.Method.invoke(Method.java:498)
sbt.internal.inc.AnalyzingCompiler.call(AnalyzingCompiler.scala:248)
sbt.internal.inc.AnalyzingCompiler.newCachedCompiler(AnalyzingCompiler.scala:145)
sbt.internal.inc.AnalyzingCompiler.newCachedCompiler(AnalyzingCompiler.scala:132)
sbt.internal.inc.FreshCompilerCache.apply(CompilerCache.scala:102)
sbt.internal.inc.AnalyzingCompiler.compile(AnalyzingCompiler.scala:92)
sbt.internal.inc.MixedAnalyzingCompiler.$anonfun$compile$4(MixedAnalyzingCompiler.scala:91)
scala.runtime.java8.JFunction0$mcV$sp.apply(JFunction0$mcV$sp.java:23)
sbt.internal.inc.MixedAnalyzingCompiler.timed(MixedAnalyzingCompiler.scala:186)
sbt.internal.inc.MixedAnalyzingCompiler.$anonfun$compile$3(MixedAnalyzingCompiler.scala:82)
sbt.internal.inc.MixedAnalyzingCompiler.$anonfun$compile$3$adapted(MixedAnalyzingCompiler.scala:77)
sbt.internal.inc.JarUtils$.withPreviousJar(JarUtils.scala:215)
sbt.internal.inc.MixedAnalyzingCompiler.compileScala$1(MixedAnalyzingCompiler.scala:77)
sbt.internal.inc.MixedAnalyzingCompiler.compile(MixedAnalyzingCompiler.scala:146)
sbt.internal.inc.IncrementalCompilerImpl.$anonfun$compileInternal$1(IncrementalCompilerImpl.scala:343)
sbt.internal.inc.IncrementalCompilerImpl.$anonfun$compileInternal$1$adapted(IncrementalCompilerImpl.scala:343)
sbt.internal.inc.Incremental$.doCompile(Incremental.scala:120)
sbt.internal.inc.Incremental$.$anonfun$compile$4(Incremental.scala:100)
sbt.internal.inc.IncrementalCommon.recompileClasses(IncrementalCommon.scala:180)
sbt.internal.inc.IncrementalCommon.cycle(IncrementalCommon.scala:98)
sbt.internal.inc.Incremental$.$anonfun$compile$3(Incremental.scala:102)
sbt.internal.inc.Incremental$.manageClassfiles(Incremental.scala:155)
sbt.internal.inc.Incremental$.compile(Incremental.scala:92)
sbt.internal.inc.IncrementalCompile$.apply(Compile.scala:75)
sbt.internal.inc.IncrementalCompilerImpl.compileInternal(IncrementalCompilerImpl.scala:348)
sbt.internal.inc.IncrementalCompilerImpl.$anonfun$compileIncrementally$1(IncrementalCompilerImpl.scala:301)
sbt.internal.inc.IncrementalCompilerImpl.handleCompilationError(IncrementalCompilerImpl.scala:168)
sbt.internal.inc.IncrementalCompilerImpl.compileIncrementally(IncrementalCompilerImpl.scala:248)
sbt.internal.inc.IncrementalCompilerImpl.compile(IncrementalCompilerImpl.scala:74)
sbt_inc.SbtIncrementalCompiler.compile(SbtIncrementalCompiler.java:130)
scala_maven.ScalaCompilerSupport.incrementalCompile(ScalaCompilerSupport.java:299)
scala_maven.ScalaCompilerSupport.compile(ScalaCompilerSupport.java:101)
scala_maven.ScalaCompilerSupport.doExecute(ScalaCompilerSupport.java:83)
scala_maven.ScalaMojoSupport.execute(ScalaMojoSupport.java:555)
scala_maven.ScalaTestCompileMojo.execute(ScalaTestCompileMojo.java:49)
org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPluginManager.java:137)
org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:210)
org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:156)
org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:148)
org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:117)
org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:81)
org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build(SingleThreadedBuilder.java:56)
org.apache.maven.lifecycle.internal.LifecycleStarter.execute(LifecycleStarter.java:128)
org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:305)
org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:192)
org.apache.maven.DefaultMaven.execute(DefaultMaven.java:105)
org.apache.maven.cli.MavenCli.execute(MavenCli.java:956)
org.apache.maven.cli.MavenCli.doMain(MavenCli.java:288)
org.apache.maven.cli.MavenCli.main(MavenCli.java:192)
sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
java.lang.reflect.Method.invoke(Method.java:498)
org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced(Launcher.java:282)
org.codehaus.plexus.classworlds.launcher.Launcher.launch(Launcher.java:225)
org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode(Launcher.java:406)
org.codehaus.plexus.classworlds.launcher.Launcher.main(Launcher.java:347)

The missing method is a bridge method.
Looking at scala/tools/nsc/settings/MutableSettings.class
2.13.0:
  public nowarn()Lscala/tools/nsc/settings/MutableSettings$BooleanSetting;
  ...
  public synthetic bridge nowarn()Lscala/tools/nsc/settings/AbsSettings$AbsSetting;

In 2.13.1, the bridge is missing. I'll take a look to find out what's the reason for this change.

@lrytz Thanks a lot!

Let me add: the compiler is not binary compatbile between minor releases, so an artifact that was compiled against scala-compiler-2.13.0 may likely not work with scala-compiler-2.13.1. The maven plugin should not assume this kind of binary compatibility.
However, I cannot explain the change from the top of my head, and it's important to investigate. If we 2.13.1 has a breaking change in the way it generates bytecode compared to 2.13.0, then that's a major problem.

The maven plugin should not assume this kind of binary compatibility.

I don't think we assume anything.
The compiler-bridge's current version scheme only accounts for runtime Scala version and zinc version, not target compiler Scala version, see https://search.maven.org/artifact/org.scala-sbt/compiler-bridge_2.12/1.3.0/jar.

compiler-bridge's current version scheme only accounts for runtime Scala version and zinc version

Yes, but as far as I know, sbt doesn't use the binary release of the compiler bridge. Instead, sbt re-compiles the compiler bridge from source (using the -sources.jar) for every new Scala compiler version. I think, but I'm not really sure, that the binary .jar is only released to maven because "it has to", i.e., sonatype doesn't allow publishing a sources jar only.
The assumption is that the scala 2.13.x compilers remain source compatible with the _2.13 compiler bridge, but binary compatibility is not assumed.

I think, but I'm not really sure, that the binary .jar is only released to maven because "it has to", i.e., sonatype doesn't allow publishing a sources jar only.

IIRC, back in the sbt 0.13 days, only the sources jar was available.
IMHO, precompiled binaries have a lot of value in speeding up initial compile time, eg on ephemeral environments with empty local caches.

I mean, why do the whole world need to recompile the bridge locally from sources while one could publish the precompiled jar for every Scala minor version?

I think @eed3si9n can give a better answer than me to this question. One aspect is to make sbt work with any new Scala version, be it an official release or a nightly build.
Maybe binaries could be published for official releases. But the overhead of compiling locally is quite small, and it happens only once per Scala version and machine.

If Zinc was to provide an API for handling with compiler bridge (locating pre-installed, compiling and installing), I'd gladly use it for scala-maven-plugin.
AFAIK, this is only internal and sbt private (https://github.com/sbt/sbt/blob/1.3.x/zinc-lm-integration/src/main/scala/sbt/internal/inc/ZincComponentCompiler.scala).

Update: the missing bridge method is due to a change in the corresponding source code, so this is good news. I updated my comment above https://github.com/sbt/zinc/issues/698#issuecomment-533055123.

It's expected that the compiler bridge for 2.13.0 doesn't work for 2.13.1. The bridge is always compiled per Scala version and JVM version, meaning Zinc will recompile the bridge if either of these change. I don't know how scala-maven-plugin interfaces with the Zinc APIs but that's the current behavior.

It's expected that the compiler bridge for 2.13.0 doesn't work for 2.13.1.

From the user's perspective, it's not expected from a jar whose coordinates are org.scala-sbt:compiler-bridge_2.13:1.3.0.
It would be if jar was org.scala-sbt:compiler-bridge_2.13.0:1.3.0 or org.scala-sbt:compiler-bridge_2.13.1:1.3.0

meaning Zinc will recompile the bridge if either of these change

That's not how Zinc behaves. That's how the way Zinc behaves when used by sbt.
The very convenient sbt.internal.inc.ZincUtil provides methods that takes the compiled bridge, not the sources.

I don't know how scala-maven-plugin interfaces with the Zinc APIs

In short: ZincUtil. Full code here.
If it's not possible to get an official API and/or an official documentation, I would really appreciate if you could provide some pointers on some code that's not private[sbt] that would deal with locating/compiling/installing the compiler bridge.

compiler bridge for 2.13.0 doesn't work for 2.13.1

Nit: there's no "compiler bridge for 2.13.0", there's only "the compiler bridge for 2.13" (on maven).
I agree with @slandelle it's misleading and breaking the expectations, but the _2.13 really means source compatibility here, not binary compatibility.

I feel like we've had this conversation before - https://github.com/davidB/scala-maven-plugin/issues/346#issuecomment-501035129

Unlike Scala Library, there's no binary compatibility guarantees for Scala Compiler, so please ignore the binary artifact compiler-bridge_2.13-1.2.5.jar, and use compiler-bridge_2.13-1.2.5-sources.jar.

@eed3si9n Indeed, but, correct me if I'm wrong, without reaching a solution for Zinc 1.3 as relevant code was pulled out of ZincUtil and moved to ZincComponentCompiler that is private.

@slandelle wrote:

scala-maven-plugin uses precompiled compiler-bridge (as deployed in maven central).

The stuff on Maven Central is not a precompiled bridge. Please do not use the binary artifact.

I mean, why do the whole world need to recompile the bridge locally from sources while one could publish the precompiled jar for every Scala minor version?

The way to resolve this is to ship the Zinc compiler bridge as part of scala/scala. This makes sense because the reason we have to do compile-source-on-every-machine hack is because Zinc was always attached to the compiler as a hack. We can stop doing that. There's a PR here (https://github.com/sbt/zinc/pull/661) that I sent in April to move us away from this mess.

Indeed, but, correct me if I'm wrong, without reaching a solution for Zinc 1.3 as relevant code was pulled out of ZincUtil and moved to ZincComponentCompiler that is private.

The Ivy specific binding just moved to sbt/sbt. I'd be happy to improve the API if that's blocking you:
https://github.com/sbt/sbt/blob/develop/zinc-lm-integration/src/main/scala/sbt/internal/inc/ZincLmUtil.scala

@slandelle You're not using Zinc APIs correctly and it's fine. Using Zinc is hard, can be misleading, sure, and you need to be aware of this and other stuff. Anyway, it's not your fault. But this is precisely why Bloop exists, so that we don't spend time explaining how you should use Zinc and you have an integration independent from the fragile and undocumented Zinc APIs.

The way to resolve this is to ship the Zinc compiler bridge as part of scala/scala.

Another solution would be to publish a new pre-compiled version of the zinc bridge every time there's a version of the Scalac compiler. Shipping an implementation of the compiler bridge inside the compiler is only an implementation detail.
Either of these solutions doesn't meet one of the current guarantees of the Zinc compiler bridge infrastructure: the bridge is compiled per JVM version and platform. Do you change your JVM version or change GraalVM's JDK by IBM's? Then the bridge will be recompiled. I don't know why this is the way it is, I'm just describing the state-of-the-art.

Just landed here while trying to upgrade our Hydra plugin and noticed the issue of not using the source compiler-bridge. The old zinc was handling the on-the-fly compilation of the bridge, not sure what the new API is. /cc @dotta

That’s the appropriate API, I think you guys are good, Zinc will recompile the bridge for 2.13.1


Test jobs failing: Cannot contact test-macincloud-macos1013-x64-1

Several occurences today of test jobs failing:
11:57:28  Cannot contact test-macincloud-macos1013-x64-1: java.lang.InterruptedException
12:03:33  wrapper script does not seem to be touching the log file in /Users/jenkins/workspace/Test_openjdk11_j9_extended.system_x86-64_mac_xl@tmp/durable-50152030
12:03:33  (JENKINS-48300: if on an extremely laggy filesystem, consider -Dorg.jenkinsci.plugins.durabletask.BourneShellScript.HEARTBEAT_CHECK_INTERVAL=86400)

https://ci.adoptopenjdk.net/job/Test_openjdk11_j9_extended.system_x86-64_mac_xl/211/console
https://ci.adoptopenjdk.net/job/Test_openjdk11_j9_sanity.openjdk_x86-64_mac/215/console

@andrew-m-leonard Machine appears online and running - has this recurred or was it a one-off

I think this was a one-off


Staking and Rewards (part 4)

continuation of: https://github.com/mintlayer/core/pull/68
Lukas' comment about changing public to account Id
offline pks
Use OptionQuery
Reward all to block author (no more disperse_rewards)
DisableValidatorsThreshold set to 0
test_keys.json - keys here are based on polkadot.js... for testing purpose. SUBJECT TO CHANGE. This needs to change using the actual keys.
note: ran cargo fmt on this.
TODO: more tests

@muursh , so i set the --local to use https://github.com/mintlayer/core/pull/83/files#diff-cdd1a61745cf1c21b3c5dcd75e3e521b994a2346d28e581d693b521ff9e5baf4
and for the functional tests to use the "already" known sks, for easier testing.

For testing (functional or otherwise) we can stick with the old SKs. Doesn't bother me. My only concern is that the new SKs don't go near github

Btw, I have a feeling that all your staking work can be moved to another pallet. No pressure about that now. Maybe after the release of testnet.

@b-yap  I see in the tests you're testing the logic of locking, unlocking and withdrawal. Can you write a test to test staking, eras, sessions, etc? A test that resembles how the system will work and stake? That will be the ultimate test we need.

continue with https://github.com/mintlayer/core/pull/93


Add "javascript 6to5" to syntax target list

Adds support for https://github.com/6to5/6to5-sublime/

Thanks for the PR.

@STRML WOW that was fast! thanks!

No problem, was expecting it. Working on a 1.1.0 release now, closing a
few other tickets in the repo then will release. I'll comment when done.
On 1/17/15 8:03 PM, Andres Suarez wrote:

@STRML https://github.com/STRML WOW that was fast! thanks!
—
Reply to this email directly or view it on GitHub
https://github.com/SublimeLinter/SublimeLinter-jsxhint/pull/18#issuecomment-70379571.


Create Polkadot branch v0.9.39

New releases are available, so we should follow
Update to new polkadot branch v0.9.39

[x] create new branch polkadot-v0.9.39: based on tag v0.10.0
[x] create new branch polkadot-v0.9.39-tag-v0.9.0: based on tag `v0.9.0
[ ] create new branch polkadot-v0.9.39-tag-v0.7.0: based on tag v0.7.0

Upgrade branch polkadot-v0.9.38-tag-v0.10.0, based on tag v0.10.0, to polkadot v0.9.39: see https://github.com/scs/substrate-api-client/pull/489
Upgrade from branch polkadot-v0.9.38 to polkadot-v0.9.39-tag-v0.0.9 : https://github.com/scs/substrate-api-client/pull/482
Upgrade from branch polkadot-v0.9.38-tag-v0.0.7 to polkadot-v0.9.39-tag-v0.0.7: https://github.com/scs/substrate-api-client/pull/490


Phenomic is bundling default render in client bundle

The title pretty much explains itself. This should be consider at high priority and should be fix immediately.
We have 2 options here:

Use webpack 2 tree-shaking
Remove phenomic-plugin-* export from /src/index.js

webpack 2 #421, since more are moving to index.js. Should not be that hard anyway.
That's not really bug, but yeah that sucks :D

It makes my bundle 1MB . So yeah, it really sucks

After a careful measurement since it adds 500KB to the bundle size. This should be consider as a bug (well technically it doesn't)

I planned to handle webpack 2 before previous release, I forgot :D

This was resolved in master branch


[Opentelemetry] Prometheus exporter

Should be done only after https://github.com/tailcallhq/tailcall/pull/924 has merged
Add support for the prometheus opentelemetry exporter

was implemented in https://github.com/tailcallhq/tailcall/pull/924


Cycling definition list

I have this markup:

Term

Description

Term

Description

Term

Description

Term

Description

How can I make this an a grid, where each dt and next dd is a row? The closest I can come up with is this, but this pushes the first 'dd' down, so its not aligned with its term.
dl.property-list {
	margin: 0;
	padding: 0;
	@include cf();

	dt {
		@include column(1/3);
		color: #aaa;
		text-align: right;
		text-overflow: ellipsis;
		white-space: nowrap;
	}

	dd {
		@include column(2/3, $cycle: 1);
	}
}

I was actually wrong here -- the codepen demo I was using uses :nth-child, so my solution is total bs. I think jeet should be switched back to :nth-child.


Fix promise typing for updateNetwork

Have updateNetwork correctly typed to return a Promise (as it's async) and have it throw on failure so UIs can observe and react.
THIS IS A POSSIBLY SMALL BREAKING CHANGE
Users of updateNetwork that also have a lint rule to forbid hanging promises will need to await or catch

This is the right change. We'll have to consider what version to bump to though.

@dckesler A major version bump feels in order. But we should time it with the major version bump @aaronmgdr is planning for contract kit itself for the removal of libphonenumber

Maybe we can fit V1 WC support into V2 as well.

Maybe we can fit V1 WC support into V2 as well.

Yeah definitely, was thinking the same :)


Newly create local module does not exist in Haste module map

🐛 Bug Report
I'm trying to import a module I created in my App.js file
import RNModule from 'react-native-module';

The module is not found by metro when trying to load the project.

Yes I have tried:
1. Clear watchman watches: `watchman watch-del-all`.
2. Delete the `node_modules` folder: `rm -rf node_modules && npm install`.
3. Reset Metro Bundler cache: `rm -rf /tmp/metro-bundler-cache-*` or `npm start -- --reset-cache`.
4. Remove haste cache: `rm -rf /tmp/haste-map-react-native-packager-*`.

It however works if you import the module using NativeModules...
import { NativeModules } from 'react-native';
const { RNModule } = NativeModules;

To Reproduce

Create project using react-native init
Create a library using react-native-create-library
npm install your library from your project
react-native link
import the library in the App.js (or anywhere else) of the project
Try run react-native run-android or react-native run-ios

Expected Behavior
The project should load without issues.
Code Example
https://github.com/814k31/TestReactNativeNativeModule
Environment
React Native Environment Info:
System:
OS: macOS 10.14.2
CPU: (8) x64 Intel(R) Core(TM) i7-6700K CPU @ 4.00GHz
Memory: 486.52 MB / 16.00 GB
Shell: 3.2.57 - /bin/bash
Binaries:
Node: 10.13.0 - /usr/local/bin/node
npm: 6.4.1 - /usr/local/bin/npm
Watchman: 4.9.0 - /usr/local/bin/watchman
SDKs:
iOS SDK:
Platforms: iOS 12.1, macOS 10.14, tvOS 12.1, watchOS 5.1
Android SDK:
API Levels: 22, 23, 26, 27, 28
Build Tools: 23.0.1, 25.0.0, 26.0.2, 27.0.3, 28.0.0, 28.0.2, 28.0.3
System Images: android-28 | Google APIs Intel x86 Atom
IDEs:
Android Studio: 3.2 AI-181.55<IP_ADDRESS>14246
Xcode: 10.1/10B61 - /usr/bin/xcodebuild
npmPackages:
react: 16.6.3 => 16.6.3
react-native: ^0.58.3 => 0.58.3
npmGlobalPackages:
create-react-native-app: 2.0.2
react-native-ci-tools: 1.1.0
react-native-cli: 2.0.1
react-native-create-library: 3.1.2
react-native-git-upgrade: 0.2.7

@814k31 Thank you for the solid repro repository! I've checked out the project and I don't have any issues importing the library. Are you sure you are not symlinking the library into node_modules? Because that doesn't work with the metro bundler https://github.com/facebook/metro/issues/1.
These are the commands that lead to the below screenshot:
  598  git clone https://github.com/814k31/TestReactNativeNativeModule
  599  cd TestReactNativeNativeModule/
  600  ls
  601  cd RNApp/
  602  ls
  603  yarn
  604  cat package-lock.json
  605  ls -lah node_modules/react-native-module
  606  ls -lah node_modules | grep react-native-module
  607  react-native run-ios

@bartolkaruza ahhh thank you symlinking is a very high possibility though I didn't do it explicitly, the only linking was done using npm install which would most likely be the culprit there.
I'll check it out tomorrow and report back!

@bartolkaruza it was the symlink issue... thanks!
I will close this issue now but out of curiosity whats a good way to develop this way?
I've just learnt about npm pack which worked, though it seems like it will be a bit annoying to keep repacking and installing for every change...

@814k31
Several options, but the ones I like to use is to checkout the library inside the node_modules or when I'm working on a library and an app project in parallel I use https://github.com/wix/wml
Neither solution is perfect but it gets the job done. Hope this helps you along.

@bartolkaruza legend, thanks for your help!

@814k31 resolved?
I have the same problem even after linking.

@bartolkaruza why did you not have to run react-native link after running yarn in the main project?

I can reproduce @bartolkaruza's screenshot with @814k31's repo, but not if I start with a fresh project (react-native init):
$ cd TestReactNativeNativeModule
$ react-native init RNApp2
$ cd RNApp2
$ yarn add file:../react-native-module
$ react-native run-ios

Build succeeds, but when I click the button, this happens

When I diff RNApp with RNApp2 (diff -qr -x node_modules -x build -x android ./RNApp ./RNApp2) I see that some XCode project files are different and that @814k31 added a cocoapod or something for the native code. Am I missing something, or has something broken with the newest react and importing native modules?
I created a fork here with the new project: https://github.com/grisaitis/TestReactNativeNativeModule

@814k31
Several options, but the ones I like to use is to checkout the library inside the node_modules or when I'm working on a library and an app project in parallel I use https://github.com/wix/wml
Neither solution is perfect but it gets the job done. Hope this helps you along.

wix/wml doesn't work on Window 10. I used npm link and it seemed to work fine until I got the 'module doesn't exist in Haste module map' error.
Any solution?


If the target path doesn't match the source path, restore reports "Cache not found for input keys"

Hey there,
I've been trying to use the save/restore actions from two separate jobs, and after six hours of head-scratching, worked out what's going on. If the path provided to the restore command doesn't exactly match the path that was provided to the save command, the restore action reports "Cache not found for input keys". Here's a repro case. Run this in any repo, then look at the action console output; the second fetch-stuff-from-cache job won't restore any files.
name: cache-test
on:
  push:
    branches: ["main"]
    paths:
      - '.github/workflows/caching-test.yml'
  workflow_dispatch:
jobs:
  cache-some-stuff:
    runs-on: ubuntu-latest
    steps:
      - name: Create some files
        run: |
          mkdir my-files
          echo "Hello" > my-files/file0001.txt
          echo "World" > my-files/file0002.txt
          ls -lR
      - uses: actions/cache/save@v4
        id: put-files-in-cache
        with:
          path: my-files
          key: my-cached-files-${{ github.run_id }}
  fetch-stuff-from-cache-success:
    runs-on: ubuntu-latest
    steps:
      - name: restore files from from cache
        uses: actions/cache/restore@v4
        with:
          path: my-files
          key: my-cached-files
      - name: List files
        run: ls -lR
  fetch-stuff-from-cache-failure:
    runs-on: ubuntu-latest
    steps:
      - name: restore files from from cache
        uses: actions/cache/restore@v4
        with:
          path: this-will-fail-because-the-path-is-not-the-same
          key: my-cached-files
      - name: List files
        run: ls -lR

It's not clear anywhere in the documentation or in the error message that you can only restore cached content to the same path it was originally cached from - presumably because if you're using the cache action rather than separate save/restore actions there's no way to specify a different path.
Is there any underlying technical reason I can't restore cached content to a different path than it was originally saved from? If not, this would make the save/restore combination far more flexible for caching files in complex build jobs - but if this isn't possible, could the restore error message be updated to make it explicit that the target path doesn't match and that's the reason it can't find anything?
Thanks,
Dylan

Is there any underlying technical reason I can't restore cached content to a different path than it was originally saved from? If not, this would make the save/restore combination far more flexible for caching files in complex build jobs

That would be a huge advantage.
+1
Probably with an optional extra parameter for the restore action this would be possible.


Add graph kernel benchmarks and non tensor inputs GP class

This PR adds two classes SIGP (which is a subclass of ExactGP that avoids all data checks) and Inputs (a class with a data attribute that stores any form of input as a list). This PR also contains all of Leo's changes and additions.
I've not added a subclass of gpytorch's Kernel as it seems to do a lot of stuff that's irrelevant for non-tensor inputs (e.g. pairwise euclidean distance calculations, treating lengthscales for ARD, etc.). I'd recon that it's much easier to define kernels manually subclassing torch.nn.Module, and I've added such a class that just scales the kernel matrices.
The drawback of this custom kernel class is that it seems that botorch's automatic training function fails to discover all the kernel parameters (I'd argue this is a botorch bug / perhaps we're not subclassing appropriately for the autodiscovery).
The test files have examples of usage of these classes.
This PR also adds two notebooks - one that produces black box graph kernel benchmarks for all datasets based off of Ryan's script, and one that produces results using Leo's native torch kernel with the wrappers I've written. I've made the native RandomWalk kernel slightly more minimal and fixed a very minor bug.

It would be great to get this merged, there are just a couple of conflicts that need to be resolved!

Closed in favor of #49, see description of #49 for details.


[improve][io] Upgrade HBase to 2.4.15

Motivation
Currently, the HBase sink uses HBase 2.4.9, which is released over a years ago.
Modifications
This PR upgrades HBase to the current latest version of the 2.4.x line so that we can ensure the HBase sink works with it.
Verifying this change

[x] Make sure that the change passes the CI checks.

This change is already covered by existing tests, such as HbaseGenericRecordSinkTest.
Does this pull request potentially affect one of the following parts:

If the box was checked, please highlight the changes

[x] Dependencies (add or upgrade a dependency)
[ ] The public API
[ ] The schema
[ ] The default values of configurations
[ ] The threading model
[ ] The binary protocol
[ ] The REST endpoints
[ ] The admin CLI options
[ ] The metrics
[ ] Anything that affects deployment

Documentation

[ ] doc
[ ] doc-required
[x] doc-not-needed
[ ] doc-complete

Matching PR in forked repository
PR in forked repository: https://github.com/sekikn/incubator-pulsar/pull/8
The CI above failed on the PULSAR_IO_ORA test group, but it's irrelevant to this PR.

/pulsarbot rerun-failure-checks


[ADAM-1680] Eliminate non-determinism in the ShuffleRegionJoin.

Resolves #1680. In the existing shuffle region join code, the partition start/stop boundaries are determined by sorting the data and looking at the coordinates of the first and last record on each partition. This is done via a sampling process, which is fundamentally non-deterministic. Once these partition bounds are picked, we replicate records from the right side of the join into the partitions they overlap. There was a bug in this step that led to records being dropped from the first partition of each contig (except for the first contig). This was due to a bug in how the IntervalArray was being used to search for repartitioning bounds.
This PR replaces the interval array with a map between contig names and the partitions that contain their data. The first and last partition of each contig are extended to the start/end of each contig.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/ADAM-prb/2409/
Test PASSed.

Ping for review.

I can go back and rerun if you need numbers, but the perf impact was reasonably negligible.

Can we merge this?

Can we merge this?

I've been running joins of features to features, to see if behavior changed per https://github.com/bigdatagenomics/adam/pull/1754#discussion_r143518233.  No answer to that question yet, unfortunately

My opinion is that we should require the user to provide valid sequence dictionaries. GIGO.

Pinging for a merge.

I've been trying to cause troubles by joining various features with no sequence dictionaries and haven't found any, in fact the answers are correct whereas before they were not always correct.

Thank you, @fnothaft.  Thank you for the review, @devin-petersohn.


Move and update api.ManufacturerData

move api.ManufacturerData to usecases/api
fix serialization not to use SPINE schema

Works like a charm. Thank you very much.


Tests Fail in New CLI Project Due to Jest 28

Description
A new project generated with npx react-native init is created with jest and babel-jest dependencies of version 28.x. This causes the generated __tests__/App-test.js file to fail with errors including (full output further below)

Invalid return value: process() or/and processAsync() method of code transformer found at "…/node_modules/react-native/jest/assetFileTransformer.js" should return an object or a Promise resolving to an object. The object must have code property with a string of processed code. This error may be caused by a breaking change in Jest 28: https://jestjs.io/docs/upgrading-to-jest28#transformer
Jest did not exit one second after the test run has completed.

That error note about Jest 28 appears to be correct; downgrading to 27 fixes the errors.
I'd recommend that jest and babel-jest be locked to 27.x until all relevant dependencies are updated to work with 28.x
Version
0.68.1
Output of npx react-native info
System:
    OS: macOS 12.3.1
    CPU: (8) x64 Intel(R) Core(TM) i5-1038NG7 CPU @ 2.00GHz
    Memory: 8.48 GB / 32.00 GB
    Shell: 5.8 - /bin/zsh
  Binaries:
    Node: 16.14.2 - ~/.nvm/versions/node/v16.14.2/bin/node
    Yarn: 1.22.18 - ~/.nvm/versions/node/v16.14.2/bin/yarn
    npm: 8.7.0 - ~/.nvm/versions/node/v16.14.2/bin/npm
    Watchman: 2<IP_ADDRESS> - /usr/local/bin/watchman
  Managers:
    CocoaPods: 1.11.3 - /Users/josh/.rbenv/shims/pod
  SDKs:
    iOS SDK:
      Platforms: DriverKit 21.4, iOS 15.4, macOS 12.3, tvOS 15.4, watchOS 8.5
    Android SDK: Not Found
  IDEs:
    Android Studio: Not Found
    Xcode: 13.3.1/13E500a - /usr/bin/xcodebuild
  Languages:
    Java: 17.0.2 - /usr/bin/javac
  npmPackages:
    @react-native-community/cli: Not Found
    react: 17.0.2 => 17.0.2
    react-native: 0.68.1 => 0.68.1
    react-native-macos: Not Found
  npmGlobalPackages:
    *react-native*: Not Found

Steps to reproduce

Create a new project with npx react-native init YourProjectName
cd into it and run yarn test. You should see the following output, and the tests should hang:

  console.error
    The above error occurred in the <Header> component:

        at Header (/Users/josh/apps/JestSandbox/node_modules/react-native/Libraries/NewAppScreen/components/Header.js:18:22)
        at View
        at Component (/Users/josh/apps/JestSandbox/node_modules/react-native/jest/mockComponent.js:28:18)
        at RCTScrollView
        at Component (/Users/josh/apps/JestSandbox/node_modules/react-native/jest/mockNativeComponent.js:17:18)
        at ScrollViewMock (/Users/josh/apps/JestSandbox/node_modules/react-native/jest/mockScrollView.js:21:52)
        at RCTSafeAreaView
        at Component (/Users/josh/apps/JestSandbox/node_modules/react-native/jest/mockNativeComponent.js:17:18)
        at SafeAreaView
        at App (/Users/josh/apps/JestSandbox/App.js:56:22)

    Consider adding an error boundary to your tree to customize error handling behavior.
    Visit https://reactjs.org/link/error-boundaries to learn more about error boundaries.

      at logCapturedError (node_modules/react-test-renderer/cjs/react-test-renderer.development.js:10989:23)
      at update.callback (node_modules/react-test-renderer/cjs/react-test-renderer.development.js:11022:5)
      at callCallback (node_modules/react-test-renderer/cjs/react-test-renderer.development.js:3662:12)
      at commitUpdateQueue (node_modules/react-test-renderer/cjs/react-test-renderer.development.js:3683:9)
      at commitLifeCycles (node_modules/react-test-renderer/cjs/react-test-renderer.development.js:11855:11)
      at commitLayoutEffects (node_modules/react-test-renderer/cjs/react-test-renderer.development.js:14443:7)
      at Object.invokeGuardedCallbackProd (node_modules/react-test-renderer/cjs/react-test-renderer.development.js:11308:10)

 FAIL  __tests__/App-test.js (7.452 s)
  ✕ renders correctly (4963 ms)

  ● renders correctly

    ● Invalid return value:
      `process()` or/and `processAsync()` method of code transformer found at
      "/Users/josh/apps/JestSandbox/node_modules/react-native/jest/assetFileTransformer.js"
      should return an object or a Promise resolving to an object. The object
      must have `code` property with a string of processed code.
      This error may be caused by a breaking change in Jest 28:
      https://jestjs.io/docs/upgrading-to-jest28#transformer
      Code Transformation Documentation:
      https://jestjs.io/docs/code-transformation

      at ScriptTransformer._buildTransformResult (node_modules/@jest/transform/build/ScriptTransformer.js:507:15)
      at ScriptTransformer.transformSource (node_modules/@jest/transform/build/ScriptTransformer.js:628:17)
      at ScriptTransformer._transformAndBuildScript (node_modules/@jest/transform/build/ScriptTransformer.js:765:40)
      at ScriptTransformer.transform (node_modules/@jest/transform/build/ScriptTransformer.js:822:19)
      at require (node_modules/react-native/Libraries/NewAppScreen/components/Header.js:23:15)

Test Suites: 1 failed, 1 total
Tests:       1 failed, 1 total
Snapshots:   0 total
Time:        7.527 s
Ran all test suites.
Jest did not exit one second after the test run has completed.

This usually means that there are asynchronous operations that weren't stopped in your tests. Consider running Jest with `--detectOpenHandles` to troubleshoot this issue.

Downgrade jest and babel-jest to ^27, then rerun yarn test. You should see:

 PASS  __tests__/App-test.js (6.309 s)
  ✓ renders correctly (4430 ms)

Test Suites: 1 passed, 1 total
Tests:       1 passed, 1 total
Snapshots:   0 total
Time:        6.372 s
Ran all test suites.
✨  Done in 8.19s.

Snack, code example, screenshot, or link to a repository
https://github.com/CodingItWrong/rn-cli-jest-28-errors demonstrates the issue. The main branch is the default project created and shows the problem, and the jest27 branch downgrades to Jest 27 and shows the fix.

A new project generated with npx react-native init is created with jest and babel-jest dependencies of version 28.x

I've just tested it and this is not the case. I have this package.json after a
npx react-native init RN0681 --version 0.68.1
  "dependencies": {
    "react": "17.0.2",
    "react-native": "0.68.1"
  },
  "devDependencies": {
    "@babel/core": "^7.12.9",
    "@babel/runtime": "^7.12.5",
    "@react-native-community/eslint-config": "^2.0.0",
    "babel-jest": "^26.6.3",
    "eslint": "^7.32.0",
    "jest": "^26.6.3",
    "metro-react-native-babel-preset": "^0.67.0",
    "react-test-renderer": "17.0.2"
  },

Therefore I suppose you're usign a different template.

@cortinico I just retested, and npx react-native init gives different results whether you do or don't specify --version 0.68.1. If I specify it as you did, I see jest 26.x as you showed.
If I don't specify the version, and I run npx react-native init RNLatest, I get: (note Jest 28.*)
  "dependencies": {
    "react": "17.0.2",
    "react-native": "0.68.1"
  },
  "devDependencies": {
    "@babel/core": "^7.17.10",
    "@babel/runtime": "^7.17.9",
    "@react-native-community/eslint-config": "^3.0.1",
    "babel-jest": "^28.0.3",
    "eslint": "^8.14.0",
    "jest": "^28.0.3",
    "metro-react-native-babel-preset": "^0.70.2",
    "react-test-renderer": "17.0.2"
  },

I understand that it may not be intended behavior that not specifying the version gives different results, but there does appear to be a difference.

Hmm, although the output of my npx react-native info command above indicated that I didn't have react-native-cli installed globally, I tried running npm uninstall react-native-cli and then rerunning npx react-native init RNLatest, and then I get the Jest 26 output as you show. But now that I've uninstalled it, rerunning npx react-native info gives "Unrecognized command" so I can't reconfirm the state now.
In any case, I think that means this issue can be closed. Whatever CLI weirdness is going on, we've both confirmed that we see the correct Jest version outputted with no globally-installed CLI.

@cortinico  Why is it marked off topic? Its a genuine issue, react-native/jest is using 26 version of jest internally which is causing breaking changes with jest 28. It's making react native 0.68 not usable with jest 28 which is needed for Github actions reporter!

The original issue is related to npx react-native init generating projects that depends on Jest 28.

No, the original issue is that react native doesn't support the latest Jest versions (v28+). Locking the jest version to 26 isn't fixing the problem, it's just slapping a bandage on it for those who use npx react-native init. Anyone who creates a project themselves or tries to upgrade Jest to the latest version is still affected by this. The real solution is to actually fix the code to make it Jest 28 compatible.

As the original poster, I can confirm that the original issue is

A new project generated with npx react-native init is created with jest and babel-jest dependencies of version 28.x.

It is a different issue if you manually update a project to Jest 28 and it doesn't work. To say something is "off-topic to this issue" isn't to say it isn't an issue, it's just to say it isn't this issue.
All that is needed to get attention on any incompatibility with Jest 28 is to create a new issue about "when I manually update to Jest 28"

All that is needed to get attention on any incompatibility with Jest 28 is to create a new issue about "when I manually update to Jest 28"

Thanks for clarifying @CodingItWrong
As already mentioned, the original issue has been resolved.
@param-finder @simon-abbott I invite you to open a separate issue and explaining what's the failure on your end, providing examples and so on.
If you're looking into updating the code to be Jest 28 compatible, that's totally doable (a PR is more than welcome). It's just off-topic for the sake of this issue.


lint: use no-unused-vars lint rule

In https://github.com/Jozty/Fae/pull/71, we had added lint to Deno config. To pass the CI/CD for sometime, we had added some of the rules to lint-exclude. We need to remove those one by one. In this issue, we will removing no-unused-vars lint rule from the lint-exclude option.

Sure @jyotijangid. Assigning it to you


Fix: WebView , show in App browser

If you click on the sign-in with the GitHub button then it should redirect you to the GitHub URL it should be the in-app web view that is there in the current app but you should show the in-app URL above. Refer below image ⬇
Example :

assigned to you @vinayak-trivedi :)

PR under review

Merged !


Refs Error

On line 678 of dist/react-datepicker.js:
Uncaught TypeError: Cannot read property 'focus' of null
  toggleFocus: function toggleFocus(focus) {
    if (focus) {
      React.findDOMNode(this.refs.input).focus();
    } else {
      React.findDOMNode(this.refs.input).blur();
    }
  },

Which version of React are you running?

This maybe somewhat unrelated, but I stumbled across the same error when using Datepicker with the customInput property: In this case you need to ensure, that you pass a stateful component, and not a functional one. That solves the error in this context, because stateless components cannot be refed in React.


Is it possible to add window titles instead of application names?

Should be easy, just a new CLI arg

Thanks, but I still have one more question. How to generate  css? enter this command( for example "hyprswitch --custom-css /home/tatu")?

Hyprswitch applies the default CSS (found in the README) to the GUI.
You can write a custom css file with styles for the classes described in the README to override the default CSS.
Then use the --custom-css option to load this file.

Thanks bro

--show-title added to the init command


Get Team Access for the Azure Sandbox

[ ] submit tickets to create 014gc AD accounts for team members
[ ] add them through IAM to resource group

Opened ticket for Active Directory account creations for team

Finis !


Fixes a bug in template and adds utility function.

What's this PR do?
This PR fixes an issue where on every campaign action page load, there are about 6 or less (because of the number of initial gallery items) notices regarding an undefined offset 641. The issue is that the function in the template that is called to find a particular nested array item won't work because the dosomething_helpers_isset() function cannot handle dealing with grabbing values if the value is nested.

This PR also cleans up:

dosomething_helpers_isset() function to rename a param to help make it more obvious what it is.
dosomething_kudos_term_is_selected() since the param name no longer reflected what was being passed in to it.. it is no longer a $reportback_item object, but a $kudos array.

How should this be reviewed?
Load a campaign action page. If you don't see any Notice: Undefined offset: 641 errors, then all is well!
Relevant tickets
Fixes #6700
Checklist

[ ] Tested on staging.

@deadlybutter @angaither @jessleenyc

👍  🚢

🏁 🚀


Securing prod docker images

[ ] Set the default user of the docker container to a non-root user.
[ ] Add UFW rules to ensure that only the necessary ports are exposed of the docker containers.

Hey @sainak I can try to set the default user to non-root user but have no idea of UFW rules


Overview fires imageloadstart multiple times and bug main map

Dup of :
https://github.com/openlayers/openlayers/issues/8513
https://github.com/openlayers/openlayers/issues/8290
https://github.com/openlayers/openlayers/issues/8728
But all closed with no resolution (I think)

In OpenLayers 6 layers can only be used in a single map https://github.com/openlayers/openlayers/blob/master/changelog/upgrade-notes.md#layers-can-only-be-added-to-a-single-map but if layers share the same source the problem is still there as can be seen when the #8728 fiddle is updated to replace v4.6.5 with the master full build http://jsfiddle.net/ykh692ne/3/  But the workaround suggested there still applies - use separate sources as well as layers
var sourceOptions = {
        url: 'http://maps.dwd.de/geoserver/dwd/wms',
        params: {
          LAYERS: 'dwd:bluemarble',
          TRANSPARENT: true,
          VERSION: '1.3.0'
        }
      };

var ovMap = new ol.control.OverviewMap(
  {
    layers: [
      new ol.layer.Image({
        source: new ol.source.ImageWMS(sourceOptions)
      })
    ],
    collapsed: true,
    collapsible: true
  }
);

var map = new ol.Map({
  layers: [
    new ol.layer.Image({
      source: new ol.source.ImageWMS(sourceOptions)
    })
  ],
  controls: [ovMap],

Also rastersources cannot be used twice - see https://stackoverflow.com/questions/56992171/multiple-imagelayer-with-rastersource-not-visible  Ideally such limitations should be mentioned in the API.

What makes you think raster sources cannot be used by more than one layer? See https://codesandbox.io/s/simple-r0bdx that shows an OSM source used by two layers in two maps.
So maybe this issue is specific to ol/OverviewMap? If anyone wants to fix that, we could use a maintainer of the OverviewMap. If issues keep popping up around that, we'll have to remove it from the library.

What makes you think raster sources cannot be used by more than one layer? See https://codesandbox.io/s/simple-r0bdx that shows an OSM source used by two layers in two maps.
EDIT: Oh, it seems you meant ol/source/Raster. That's different than a tile image source. A documentation improvement pull request would be welcome.
~So maybe this issue is specific to ol/OverviewMap? If anyone wants to fix that, we could use a maintainer of the OverviewMap. If issues keep popping up around that, we'll have to remove it from the library.~

Yes, and ImageWMS sources can also be shared without problems (I've tested that with maps sharing a view when the map sizes differ, and views in different projections when the ImageWMS projection is defaulted) so it does seem to be an issue with OverviewMap and main map synchronisation.
#8513 involved ol/source/Raster so it was unlikely to work regardless of what is causing the problem with ol/source/ImageWMS.

I suspect what is happening is similar to the problem in https://stackoverflow.com/questions/56090823/synchronize-different-maps-with-different-center-and-rotation which meant that simple setCenter(), setRotation() and setResolution() calls needed to be replaced by animate().  In OL6 the callbacks and flags would be unnecessary as calling getAnimating() works equally well to check if the other view is animating.  OverviewMap.js uses setCenter(), setRotation() and fit().  The first two could be replaced by animate(), and fit() would need an explicit duration (which could be zero).

I have identified the problem in earlier versions of OpenLayers as the ovview.fit(extent) call which doesn't set the desired extent, resulting in an endless loop of attempts.  It is easily fixed by changing to ovview.fit(extent, {constrainResolution: false}); (tested using a patched 4.6.5 debug full build).  When using the #8728 jsfiddle with an OL6 full build a different loop is caused by the parent map view having an extent constraint (demonstrated by removing the constraint).  Potentially any of the setCenter, setRotation or fit calls in OverviewMap.js which conflicts with view constraints (including the default multiWorld: false) could now cause problems.


Change PushEvent.Pusher type to CommitAuthor

Fixes https://github.com/google/go-github/issues/2998
CommitAuthor currently has the exact fields that the push event's Pusher provides and is more correct than using User for the reasons laid out in the linked issue.

Thank you, @valbeat !
Merging.


Remove the local StringSet

Use the one in admiral everywhere.

This needs https://github.com/submariner-io/admiral/pull/165.


[IMPROVEMENT] Add previews on all views

Is your improvement request related to a problem? Please describe.
no previews on views
Describe the solution you'd like
add previews based on @mariob suggestion

Tell me if you need help to share the work

@mariob Tnx man! I kinda didn't wanna bother you with this legwork and it required some changes in other parts of the code. You could delete all "top" views if you wanna? Since previews would replace these and no need for them really.
Then i need to do some design work and play with colors a bit, i want to make it so you have light and dark mode variants for some views, not only "neumorph button" :)