Python 3 migration

Python 2 is not supported at many places and it's getting harder to meet the dependencies for it now

Python 3 fork: https://github.com/FichteFoll/Sushi

@arbarbosa1979 Thanks for this!


Is there any log?

Hello! Thanks for this wonderful and helpful tool.
I just added a new json schema to my configuration, but it is not being picked up. I was wondering if there is any log I can check to understand why may be happening?
In any case, here is my config
  lspManager.setup("jsonls", {
    settings = {
      json = {
        schemas = vim.list_extend({
          {
            description = "Haxe format schema",
            fileMatch = { "hxformat.json" },
            name = "hxformat.schema.json",
            url = "https://raw.githubusercontent.com/vshaxe/vshaxe/master/schemas/hxformat.schema.json",
          },
        }, require("schemastore").json.schemas()),
        validate = { enable = true },
      },
    },
  })

You can try looking through the LSP logs: :lua vim.cmd("edit " .. vim.lsp.get_log_path())
This may also help: https://www.reddit.com/r/neovim/comments/sbohdv/help_installing_jsonls_schemas

I'm using the same configuration in another neovim config file and it just works as expected. It is probably an issue with LunarVim.
Thanks for your help.


Open and shut down terminals

Problem
Currently it's possible switch to a running terminal if the widget is already opened in the main area. However it's not possible to re-open a closed terminal widget, or shut down a terminal:
jupyterlite-terminal-open-shutdown.webm
Proposed Solution
Implement these functionalities.
Additional context
Tested with the changes from https://github.com/jupyterlite/terminal/pull/11.

Related is that we need to handle an exit command in cockle to shutdown the terminal from within it. Presumably this will need some sort of callback from cockle to terminal.

I've looked at this and dealing with the shutdown will be fine. But reopening a closed terminal widget is problematic as in  JupyterLite this sends an actual REST API request rather than a mocked one.
In JupyterLab the code that gets the list of running terminals is:
https://github.com/jupyterlab/jupyterlab/blob/f8cdbba3b8ac64c80f2c7701f35db4c568716f3f/packages/services/src/terminal/restapi.ts#L70-L71
and it takes serverSettings or creates a new one if none is supplied.
The standard code path to get the list of terminals is
https://github.com/jupyterlab/jupyterlab/blob/f8cdbba3b8ac64c80f2c7701f35db4c568716f3f/packages/services/src/terminal/manager.ts#L217
using the TerminalManager.serverSettings, and works as expected.
However, the equivalent code to reopen a closed terminal widget is
https://github.com/jupyterlab/jupyterlab/blob/f8cdbba3b8ac64c80f2c7701f35db4c568716f3f/packages/terminal-extension/src/index.ts#L363
No setting are passed in so new one is created, and evidently this uses a real WebSocket in Lite rather than a mocked one.
To check this, if I change the last line to
const models = await TerminalAPI.listRunning(serviceManager.serverSettings);

then it works as expected using the mock socket which is routed to the terminal extension and handled by
app.router.get('/api/terminals', ...)

I don't know enough about the Jupyter Lab and Lite relationship to know if the workaround above is a reasonable thing to do, or if JupyterLite should be handling this in some other way such as by overriding the makeSettings in some way.

Thanks @ianthomas23 for investigating this!
It looks like this should indeed be fixed in JupyterLab directly with the change you proposed above. Would you like to open a PR?
Then we'll need to get this in a JupyterLab 4.3.x release, and make a release of JupyterLite updated to the latest @jupyterlab packages, after https://github.com/jupyterlite/jupyterlite/pull/1514 is finished.

It looks like this should indeed be fixed in JupyterLab directly with the change you proposed above. Would you like to open a PR?

Yes, I'll do that tomorrow.

Corresponding JupyterLab issue jupyterlab/jupyterlab#16920 and PR jupyterlab/jupyterlab#16921.


Adds ability to unlock multiple accounts

I needed to deploy to a remote node (via INFURA) and to test transactions with multiple accounts. Using WalletSubprovider does not allow for this -- this PR switches that subprovider for HookedSubprovider, which is much more flexible.
This is derived from https://github.com/trufflesuite/truffle-hdwallet-provider/pull/3 but does not require any changes to provider-engine.

Just looking over this and realize the counter i starts at 0, but it should start at address_index.


exit-hook prevents graceful cleanup of resin preload

@pimterry @jviotti
The exit-hook npm package, which is used by cli-cursor which is used by inquirer which is used by resin-cli-form, resin-cli-visuals and reconfix prevents resin-preload from cleaning up the preloader container when it is interrupted (by SIGINT for example).
exit-hook is used to register hooks on exit. The problem is that, once it executes the registered hooks it exits the node process with process.exit(128 + signal) instead of resending the same signal it got with a process.kill(process.pid, signal).
This means that the asynchronous cleanup function of resin-prelaod does not have time to finish its job before node exits.
We need to fix exit-hook or replace it with something else like node-cleanup or https://github.com/Tapppi/async-exit-hook

resin-cli version: all
Operating system and architecture: all

process.exit in exit-hook: https://github.com/sindresorhus/exit-hook/blob/master/index.js#L18

One interesting note is that new versions of cli-cursor (which seems to have gained an intermediate package called restore-cursor) don't use exit-hook at all.
If we upgraded to a newer version of inquirer (3.0.0+ should work), it would use v2 of cli-cursor, which uses v2 of restore-cursor, which uses signal-exit instead. As far as I can tell, that never runs process.exit, and does call process.kill(process.pid, signal) instead.
Does that help?
If so, that'll need an inquirer upgrade in one or more of resin-cli-form, resin-cli-visuals and reconfix, depending on which ones matter for the preload case, and some thorough testing to make sure it doesn't break anything. Reconfix is getting a big upgrade soon anyway, so if we can skip upgrading that that'd be useful.

We could probably omit updating reconfix as it is probably not loaded when calling resin preload.
I'll see if we can easily update resin-cli-form, resin-cli-visuals and inquirer-dynamic-list (used by resin-cli-visuals).

Also inquirer 4.0.0 dropped support for node 4

Also inquirer 4.0.0 dropped support for node 4

Good to see that resin-cli is on-trend :+1:


Version 1.30 breaks if DISABLE_PANTHEON_UPDATE_NOTICES is set

We have DISABLE_PANTHEON_UPDATE_NOTICES set to true on our sites so our users don't get confused. This morning all of our sites are showing the error:
[14-Feb-2024 15:03:09 UTC] PHP Fatal error:  Uncaught Error: Call to undefined function _pantheon_get_current_wordpress_version() in /code/web/app/mu-plugins/pantheon-mu-plugin/pantheon.php:22
it looks like pantheon-updates.php isn't included if DISABLE_PANTHEON_UPDATE_NOTICES is set and that is where _pantheon_get_current_wordpress_version() is defined.

Thanks for reporting this. I will take a look at this today and ensure we have tests that check for this issue.


DP Singleton in Python

Need to make a readme file which should have the
Definition
Explanation in simple terms
Code related explanation.

Could you please assign me this issue?

ok


[BUG] using end kwarg in print function results in a syntax error.

Describe the bug
I am trying to use a print statement that looks something like print(constant_in_module_scope, end=''). When I try to compile this I get a syntax error saying Expected ')', found '='
Code to reproduce the behaviour:
# example code
import cython

ORANGE = "\u001b[38;5;209;1m"  # orange color in the terminal, this was that "constant_in_module_scope" from before

def test_function():
    print(ORANGE, end='')
    # from here I would actually print other stuff that I wanted in orange
    # ...
    # print RESET code here, with the same `end=''` kwarg

Expected behaviour
to compile without a syntax error
Environment
OS: Arch Linux
Python version: 3.11.0 (installed via AUR)
Cython version: 0.29.32 (installed in a venv)
Additional context

I am using pure-python mode
the file in question doesn't contain any cython decorators (I was just seeing if it would compile a change I made in another file first)

turns out I'm an absolute fool.
It took me a while to find an answer (I had already been searching for 90 minutes and found nothing).
I had to add this in to my setup.py. It turns out I just needed to set the language_level
ext_modules=cythonize("src/*.py", include_path=[], language_level=3)


[php] support ingress v1

support ingress v1 for kubernetes 1.19
addressed the following changes

apiVersion
backend.service

https://kubernetes.io/docs/concepts/services-networking/ingress/#ingress-rules
https://github.com/kubernetes/kubernetes/pull/89778

Checklist

[x] Chart Version bumped

@taishin
Thanks for the PR!
If you don't mind, can you give me a link to the documentation about the changes in backend.service?

@taishin
Thanks for the PR!
If you don't mind, can you give me a link to the documentation about the changes in backend.service?

I've added the relevant links in the description section.


Print the pokemons in inventory and profile on each step

Should we wait for the refactoring ? @douglascamata

@diordache you mind rebasing your work with the master? We got some big refactoring done. Also, please consider a reworking the profile print to something with less lines, otherwise it's gonna spam the terminal a lot and can hide more important things (like Pokemons caught, Pokestops, etc).
Thanks!


fix: DEV-3745: unselecting all itens in history instead just the selected item

Hi @juliosgarbi!
This PR was created in response to a PRs in upstream repo:

https://github.com/heartexlabs/label-studio-frontend/pull/1042

/git merge develop


Compilation errors

I got this error after cabal build
*** Compiling DerivedText_Editor.cpp...
DerivedText_Editor.cpp: In member function ‘void DerivedText_Editor::remove_key_binding(int, int, DerivedText_Editor::Key_Binding_With_Callback**)’:
DerivedText_Editor.cpp:91:36: error: ‘last’ may be used uninitialized in this function [-Werror=maybe-uninitialized]
   if (last) last->next = curr->next;
                                    ^
cc1plus: all warnings being treated as errors

This is on gcc 4.9.2, ghc 7.8.4 and on a Archlinux 64bits system.
If I disable -Werror on c-src/Makefile.in (or initialize the "last" pointer in the cpp code) then the compilation continue , but fails later on linking fase. Lot of line similar to:
undefined reference to `Fl_Menu_Button::Fl_Menu_Button(int, int, int, int, char const*)'

I try to resolve it later, and post any further ideas.

Thanks for the report.
Unfortunately my version of g++:
g++ (Ubuntu/Linaro 4.8.1-10ubuntu9) 4.8.1
Copyright (C) 2013 Free Software Foundation, Inc.
This is free software; see the source for copying conditions.  There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.

did not catch that warning at all.
The error you're getting happens if the FLTK libs are not found in the library path. Did you compile by hand or use a package manager?

Ok, I've used the package manager from my distro to get the fltk version1.3.3-4, and the library path is /usr/include/FL. I have remove it and installed from sources following your README instrucctions AND COMPILATION IS OK, like a charm :-)
Maybe my distro package lacks some libraty headers code or something like that , Idon't know.


Corrected Vocabulary of some sentences in README.md file

Issue Title:
resolve issue: #issue_number
Type of change ☑
What sort of change have you made:

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Code style update (formatting, local variables)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

Checklist: ☑

[ ] My code follows the guidelines of this project.
[ ] I have performed a self-review of my own code.
[ ] I have commented my code, particularly wherever it was hard to understand.
[ ] I have made corresponding changes to the documentation.
[ ] My changes generate no new warnings.
[ ] I have added things that prove my fix is effective or that my feature works.
[ ] Any dependent changes have been merged and published in downstream modules.

How Has This Been Tested? ⚙
Describe how have you verified the changes made.

@aatmajajoshi Which issue is this PR resolving?


macro: private members

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

73 of 118 (61.86%)  changed or added relevant lines in 2 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-3.9%) to 69.675%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

macro.go
7
8
87.5%

action.go
66
110
60.0%

Totals

Change from base Build<PHONE_NUMBER>:
-3.9%

Covered Lines:
193

Relevant Lines:
277

💛  - Coveralls


Why use Slidr lead to GPU render excess?

User SliderPanel wrapper after DecorView.  It's lead to render excess.

Yes, this is a problem I've been meaning to resolve.

@r0adkll did you resolve this bug sir?

This should now be resolved.


rollout_options does not allow empty value, when performing plan a change is detected

Describe the bug
Having the following configuration block in terraform without rollout_option:
resource "bindplane_configuration" "configuration" {
  for_each   = var.configurations
  name       = each.key
  platform   = each.value.platform
  labels     = each.value.labels
  rollout    = each.value.rollout
  extensions = each.value.extensions
  dynamic "source" {
    for_each = each.value.sources != null ? each.value.sources : []
    content {
      name       = source.value.name
      processors = source.value.processors
    }
  }

  dynamic "destination" {
    for_each = each.value.destinations != null ? each.value.destinations : []
    content {
      name       = destination.value.name
      processors = destination.value.processors
    }
  }
}

A plan of this produces:
# bindplane_configuration.configuration["test"] will be updated in-place
  ~ resource "bindplane_configuration" "configuration" {
        id           = "idhere"
        name         = "cph-proxy"
        # (4 unchanged attributes hidden)

      - rollout_options {
        }

        # (4 unchanged blocks hidden)
    }

To Reproduce
Create a configuration with rollout_option block and perform a terraform plan.
Expected behavior
No change on the configuration
Screenshots
/
Environment:
Terraform 1.6.6 and provider version 1.4.0

@nbrys thank you for reporting. We will look into replicating this issue.

I have re-produced this, working on a solution :+1:

@nbrys this should be resolved in v1.4.3 https://github.com/observIQ/terraform-provider-bindplane/releases/tag/v1.4.3


The existing version fails on symlinks

Great tool, thank you! However, I would like to propose a patch, because we have a small problem with relative symlinks for the current tophat2.sh start script:
readlink returns the plain content of the symlink, which may be a relative path resolved from the directory, the link lives in, for example "../Cellar/tophat/2.1.1_1/bin/tophat2" in case of the brew system (homebrew or linuxbrew). The relative path is handled different by the existing tophat2.sh-script than by a shell resolving a symlink. The shell would resolve it relatively to the link's directory, the original tophat2.sh script tries to resolve it relatively to the current working directory, which usually fails. The proposed change will take care of this issue and set DIR to the real directory tophat2.sh lives in.
For Linux only, the readlink command supports a "-f" parameter making it return the canonical path, but this is non-standard and won't work e.g. on a Mac.
I have tested my patch on Ubuntu 16.04 with linuxbrew and will test it on a current Mac OS X El Capitan, as soon as possible (currently, there seems to be some network problem with homebrew).
I would really be thankful, if you could consider my change, because we heavily use the brew system and would have to patch after each update otherwise. Thank you,
Stephan

Ok, now I could test it on OS X: Results: The error does not occur on this platform, but the modification anyway works -- and the bug on Ubuntu linuxbrew has been fixed. I don't have any Cygwin ready to test, so, sorry, cannot test that.


Add Chainhooks feature guide

@trichards-hiro : Thomas to work with Ludo and Max E and pull the content from https://github.com/hirosystems/chainhook/.
Readme to be updated in the Chainhooks repo.

Here's my rough notes on the lay of the land of what options exist in the latest with Chainhooks:
chains:

    bitcoin
    stacks

    protocols:

        bitcoin
        ordinals
        stacks

        networks:

            testnet
            mainnet

        if-this:

            scopes:

                txid
                ft_event
                sft_event
                nft_event
                stx_event
                print_event
                contract_deployment
                outputs

            operations:
                equals
                starts_with
                ends_with
                p2sh (btc)
                p2wpkh (btc)
                p2wsh (btc)
                pox_committed (stacks)
                leader_key_registered (stacks)
                stx_transfered (stacks)
                stx_locked (stacks)
                inscription_revealed (ordinals)

        then-that:

            actions:

                http_post
                file_append

More docs here: https://hackmd.io/SIix9Dw9QEGSrIy0SAo5tw?both

Relates to https://github.com/hirosystems/chainhook/issues/238

Chainhooks documentation PR: https://github.com/hirosystems/chainhook/pull/239

https://docs.hiro.so/chainhooks/overview


source highlight style does not extract to a file

The project is a great extension.
I want to use it to publish my documents. So I tried the extension. I found a problem: source highlight style does not extract to a file; the style of asciidoc is extracted to a file.

Hi @diguage, please provide a test case with the command used and expected output versus actual output.

Hi @diguage, please provide a test case with the command used and expected output versus actual output.

I'm submitting an example to asciidoctor-maven-examples, you can pull the PR to check it, https://github.com/asciidoctor/asciidoctor-maven-examples/pull/134

@diguage, I am not familiar with Maven and am not able to provide support for Maven. It is currently outside the scope of this project.

please provide a test case with the command used and expected output versus actual output

Can you provide the equivalent asciidoctor command, like one of the ones shown in the README? You can even run it directly from a local clone of the repository—see the Development section.

OK, Let me create a example：
= Example Manual
Doc Writer<EMAIL_ADDRESS>2014-09-09
:icons: font
:source-highlighter: coderay
:coderay-style: monokai
:coderay-linenums-mode: table
:stylesdir: assets/styles/
:linkcss:

This is a user manual for an example project.

[#introduction]
== Introduction

This project does something.
We just haven't decided what that is yet.

[#source-code]
== Source Code

[source,java]
.Java code from project
----
package com.diguage;

/**
 * @author D瓜哥 · https://www.diguage.com/
 */
public class Main {
    public static void main(String[] args)
        System.out.println("Hello, world");
    }
}
----

This page was built by the following command:

 $ mvn

$ asciidoctor -r asciidoctor-multipage -b multipage_html5 -D . -a toc=left index.adoc

$ tree assets
assets
└── styles
    └── asciidoctor.css

If I remove :stylesdir: assets/styles/ and :linkcss:, it is OK.

@diguage, thanks for the example. I was able to reproduce the problem: with the stock html5 converter, Asciidoctor writes out coderay-asciidoctor.css but with the multipage converter it does not. This may be related to handling of the copycss attribute, which "is set by default unless the safe mode is secure" (quoting the documentation).
It is possible to work around this by explicitly setting the copycss attribute, either in the document (:copycss:) or as a command line option (-a copycss).

As implied in my previous comment and stated in the documentation, Asciidoctor is responsible for writing the stylesheet(s), not the extension.
With this asciidoctor-multipage extension, Asciidoctor is only really aware of the top-level page. This page seldom or never requires any highlighting, so the highlighter is never used and indicates that no stylesheet is needed. This is worked around with commit e61c95a13754c1b2cbbc51e8418060626eeea251, included in release v0.0.16.


Print/Access alert or rule types used in .yaml in alerts.py for

Hi,
Need help in accessing alert or rule types used in .yaml
/elastralert/elastalert/alerts.py
I am able to access and print values filter and name.

get_filter = self.rule.get('filter', None)
get_rulename = self.rule.get('name', None)
How can i access alert type example whether it is frequency or Average etc

I tried as get_rules = self.rule.get('type', None) but it print the following line including the class etc
"Print rules: <elastalert.ruletypes.FrequencyRule object at 0x7fd3e204c310>"
A little background:
I am creating a custom payload for class ServiceNowAlerter(Alerter): in alerts.py

Yelp/elastalert is no longer maintained. Please use jertel elastalert. Questions to the discussion below
https://github.com/jertel/elastalert/discussions


Forwardport 2.1: Fix typo and bracketing in macro args

This is a forwardport of two fixes from https://github.com/ARMmbed/mbedtls/pull/999:

Bracketing around arguments to function macros in net_sockets.c
Typo in net_sockets.c comment.

Identical to #1297 which has been merged.


Fix date for published blog article

This change affects the date shown in the repository and does not affect the URL or content of the published article.
/area blog
/kind cleanup

/lgtm
/approve


The inferred images exhibit severe artifacts, which adversely affect the visual quality.

When I infer the results of images using my own model, I notice the presence of square-shaped artifacts. Even when using example images provided by the official model for inference, similar artifacts are present (as indicated by the red arrows in the image, showing semi-transparent square artifacts). However, these artifacts are more clearly in my results, severely affecting the visual effect. What could be causing this situation? How can it be avoided?

I checked the dimensions of the data. The official example input is:
ref_image.shape is : (1117, 714, 3)
ref_mask.shape is : (1117, 714)
back_image.shape is : (512, 512, 3)
tar_mask.shape is : (512, 512)
unique_ref_mask is : [0 1]
unique_tar_mask is : [0 1]，
Whereas, the input for my own data is:
ref_image.shape is : (1080, 1920, 3)
ref_mask.shape is : (1080, 1920)
back_image.shape is : (720, 1280, 3)
tar_mask.shape is : (720, 1280)
unique_ref_mask is : [0 1]
unique_tar_mask is : [0 1]
I dnt think the difference between back image  will affect the final output.

You could remove the operator of "crop and paste back"

@XavierCHEN34
This is not a solution to the problem, but rather a way to avoid it. Are there any several methods to eliminate artifacts?

Currently, it is a common issue that the newly inpainted region would be slightly different from the original pixels. A better VAE, higher resolutions might help.


add send_header_applicationjson/send_header_content_length

helpers for Content-Type: application/json and Content-Length: which I need in an upcomming mptsd pull request


Python Package Seems Broken

Checklist

[N/A] I'm reporting a broken site support issue
[x] I've verified that I'm running yt-dlp version 2021.05.20
[N/A] I've checked that all provided URLs are alive and playable in a browser
[N/A] I've checked that all URLs and arguments with special characters are properly quoted or escaped
[x] I've searched the bugtracker for similar bug reports including closed ones
[x] I've read bugs section in FAQ

Verbose log
yt-dlp.exe
Traceback (most recent call last):
  File "c:\python39\lib\runpy.py", line 197, in _run_module_as_main
    return _run_code(code, main_globals, None,
  File "c:\python39\lib\runpy.py", line 87, in _run_code
    exec(code, run_globals)
  File "C:\Python39\Scripts\yt-dlp.exe\__main__.py", line 4, in <module>
ModuleNotFoundError: No module named 'yt_dlp'

Description
I'm using cached yt_dlp-2021.5.20-py2.py3-none-any.whl (2.1 MB).
Python package seems non-functional.

hmm, now its woring for me (same version). Strange.

I was gonna write "cant reproduce", but I see you've gotten it working too. If you encounter this again, please reopen with the exact steps needed to reproduce


test: Create generic test runner for binary ops

This allows test any binary op using predefined test cases. In preparation for testing bitwise ops.

LGTM. One thing to consider: should we in this generic executor also check for "op does not modify input parameters"?

Yes. Originally I wanted to have separate set of tests for this, but once we have generic runner I think it is good place for it.

:+1:


theming

Habitat DS must be a themable library.
Every project that use it should be able to pass a set of custom Design Tokens (provided by the Casavo Design team) as json file and see the new changes without the need of touching the source components code or overriding their appearance through parent style.
We are going to achieve this by mixing the Theming utilities of Vanilla Extract and the Style Dictionary implementation that we have already provided within the repo (nice to have: expose the CLI command to generate the plain .json token file to the parent project using this library)
Acceptance criteria

[ ] theming implemented within the library
[ ] documentation updated to explain how to use the theme values within the library
[ ] documentation updated to explain how to use custom themes in parent projects

@pietrograndi @marcel-casavo I think this is the best place to continue the discussion and propose solutions 😎

thanks @moebiusmania, we have recently discussed it internally in team activation and we decided that this activity should not block or create a dependency in any way between the theming capabilities of habitat and the second release of our partnership with Unicredit (which has a hard deadline at the end of June). As it happened for the first release, we will use the theming capabilities of the existing projects to implement the requested features.
Moreover we decided that in any case we should leverage on this opportunity to define soon (in our spare time) what would be the specs that a consumer of this library could expect when implementing a business scenario like ours (apply a tenant theme to our products).  I will take care of this initiative activation-side and post some updates here in the near future.
Moreover, based on the capacity of team activation after the end of June release we could consider even integrating a themed habitat on flow and remove what could be seen as potentially tech debt (which is a local theme).  Of course to be discussed with product.

thanks @moebiusmania, we have recently discussed it internally in team activation and we decided that this activity should not block or create a dependency in any way between the theming capabilities of habitat and the second release of our partnership (end of June). As it happened for the first release, we will use the theming capabilities of the existing projects to implement the requested features.
Moreover we decided that in any case we should leverage on this opportunity to define soon (in our spare time) what would be the specs that a consumer of this library could expect when implementing a business scenario like ours (apply a tenant theme to our products). I will take care of this initiative activation-side and post some updates here in the near future.
Moreover, based on the capacity of team activation after the end of June release we could consider even integrating a themed habitat on flow and remove what could be seen as potentially tech debt (which is a local theme). Of course to be discussed with product.


Compiler plugins

Fixes #19

Wow, is someone actually thinking about using this?!?
@puffnfresh The travis build is failing, is that expected?

@puffnfresh Also do you want to be a contributor on the project?

I'm not sure why Travis is failing :crying_cat_face:

@puffnfresh Travis is currently building with 2.10. Worth trying to bump to 2.11?

@charleso as an sbt plugin for 0.13, doesn't it have to use Scala 2.10?

@puffnfresh Managed to reproduce with jdk1.7.0_76 (worked fine with jdk1.8.0_92 though). Does that give you anything to go by?

Right, scalaz 7.3.0-M3 compiled with 1.6 bytecode, but depends on 1.8 classes:
https://github.com/scalaz/scalaz/commit/f148413fe15a867531e5eb642d192e48ccd0115d
Sigh. It's almost ironic. :(
I don't mind if you want to fix the build to use Java 8, or use an older scalaz.


should user commit history be stored in a one-per-block structure?

this makes a natural rate limiter as the user cannot record more than 1 commit per block. However, this would vary across chains and block times, e.g. long block times == harsher rate limiter

What are the outcomes/how can we close this ticket?


Add ability to goBackTo (pathname)

What problem does this feature solve?
Our app has pages that require a bluetooth connection, we need the ability to send the user back to a neutral page if they lose connection/disconnect.
Something like router.goBackTo(pathname) would solve this problem.
What does the proposed API look like?
new goBackTo method that finds the delta to invoke router.go with for navigating back

Yes but if the user clicks back then they would access invalid pages.
Why would you just close this ticket?  @posva
Theres no way to go back to a specific named page and always going forward is not a valid option.


Bug: Multiple vulnerabilities detected on devtroncd & argo namespace

📜 Description
I've deployed devtron v0.6.8 over a private GKE cluster and enabled the gke security posture feature from GCP and after scanning it showed more than 1k+ vulnerabilites in devtroncd namespace itself and out of which 600 are medium,150 high & 15 critical vulnerabilites which imposes a major threat to the overall cluster & due to this it wouldn't be a good option to deploy devtron in prod envt.
👟 Reproduction steps
Configure GKE cluster and deploy devtron over it and turn the security posture feature on.
👍 Expected behavior
No or very less vulnerabilities must've occured.
👎 Actual Behavior
Attached is the overview of the vulnerabilites found.

☸ Kubernetes version
GKE v1.23
Cloud provider
GCP
🌍 Browser
Chrome
🧱 Your Environment
No response
✅ Proposed Solution
To fix this,update the library packages being used in devtron and disabling pod containers to run as root in argo workflow-controller pod.

👀 Have you spent some time to check if this issue has been raised before?

[X] I checked and didn't find any similar issue

🏢 Have you read the Code of Conduct?

[X] I have read the Code of Conduct

Hi @wali97 Thanks for reporting the issue. We have a responsible disclosure policy at https://github.com/devtron-labs/devtron#bug-vulnerability-reporting.
Also the it run in privilege mode because it uses DIND which requires privilege access. It is the one which is used by Jenkins agent also and provided by other providers.
Though they are considered not root-safe they are considered valuable in the trusted workload environment. You can read more about it at https://brauner.io/2019/02/12/privileged-containers.html
And since Devtron installation is not multi-tenant, its installed within your infrastructure running workloads approved by your team it is a trusted workload. Additionally these are temporary isolated nodes and therefore can be further hardened.
Having said that we are also exploring few mechanisms to do it without DIND so that we dont need privileged access for eg moving to using emissary on argo workflos. Will open a separate issue for that.
Please send us the details of the vulnerabilities at<EMAIL_ADDRESS>

Resolved by #4839


x/tools/godoc/static: Missing x/time subrepo.

golang.org/x/time appears to be a real, albeit small, subrepo. Its source is https://go.googlesource.com/time and it's mirrored to https://github.com/golang/time.
package.html does not include it in the list of all sub-repositories.

I sent a trivial CL that just manually adds a new entry. That's how it was done before, i.e., see #9081 and golang/tools@06e42bd9eb281c80b8c04b1c38ece4e33e0df1f3.
I noticed that that are even more subrepos missing. That's outside of scope of this issue and will probably involve some discussion and decisions (should all the subrepos be displayed, or should some be hidden? should codereview entry pointing at code.google.com be removed? etc.). Filed a higher level issue #24432 to track that.


content: cleanup service and interfaces

After implementing pull, a few changes are required to the content store
interface to make sure that the implementation works smoothly.
Specifically, we work to make sure the predeclaration path for digests
works the same between remote and local writers. Before, we were
hesitent to require the the size and digest up front, but it became
clear that having this provided significant benefit.
There are also several cleanups related to naming. We now call the
expected digest Expected consistently across the board and Total is
used to mark the expected size.
This whole effort comes together to provide a very smooth status
reporting workflow for image pull and push. This will be more obvious
when the bulk of pull code lands.
There are a few other changes to make content.WriteBlob more broadly
useful. In accordance with addition for predeclaring expected size when
getting a Writer, WriteBlob now supports this fully. It will also
resume downloads if provided an io.Seeker or io.ReaderAt. Coupled
with the httpReadSeeker from docker/distribution, we should only be
a lines of code away from resumable downloads.
Signed-off-by: Stephen J Day<EMAIL_ADDRESS>

Codecov Report

Merging #559 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #559   +/-   ##
=======================================
  Coverage   62.12%   62.12%
=======================================
  Files           3        3
  Lines         404      404
=======================================
  Hits          251      251
  Misses         93       93
  Partials       60       60

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0b45d91...9c15ad6. Read the comment docs.

LGTM


IOS: The application crashes if you try to download a file containing Cyrillic characters in the name

In Android application everything is fine.

Hmm, interesting. This is an appropriate bug to fix for new contributors.

Need to debug this.
@zulipbot claim

The results of some debugging on this are in #2246 , but that PR was never finished.
I described a plan for how to fix this bug in this comment: https://github.com/zulip/zulip-mobile/pull/2246#issuecomment-380640640 with some additional details in the comment just after it.

I couldn't reproduce this when I tried just now. This was in v26.28.151 (the current beta), on iOS 12.4.1 on an iPhone 7.
Specifically:

I went to this message on czo: https://chat.zulip.org/#narrow/stream/7-test-here/topic/ContainsNonASCII/near/559041
which has an uploaded image with Cyrillic as well as Latin letters in its filename.
All was well. I tapped the image to open the lightbox.
The image didn't actually show up! So that seems like there's still a related bug here.
But the lightbox header and footer showed up just fine and remained responsive as normal.
I tapped the overflow menu at the lower right, and "Download image".
Got a toast saying the download succeeded.
And indeed if I go over to the system Photos app, the image is there.

We haven't heard any new reports of this crash recently that I can recall, either.
Looking back at #2246 which was described as fixing this, it seems the details were actually all about getting the image to show up in the lightbox, too -- not about downloading, or any crash.

OK, I've filed #4099 for the "lightbox doesn't show image" issue. But it seems the issue originally reported here has been fixed at some point! Closing, but if anyone sees this symptom again please reply here and we can reopen.


Write tests

Draft of in-work PR for some code tests... to be merged after #26

Tests are failing because of upstream dependency issue in GOSTrocks (which should be solved by https://github.com/worldbank/GOSTrocks/pull/5).


Wrong display of VsCode Extensions icons in panels

Does this issue occur when all extensions are disabled?: No (but it's normal, the bug happens within an extension :) )

Before:

Since latest version of VsCode

Nothing changed within the extension (whose i'm the maintainer)

VS Code Version:

$ code -v
1.83.0
e7e037083ff4455cf320e344325dacb480062c3c
x64

OS Version:

$ systeminfo
Nom du système d’exploitation:              Microsoft Windows 11 Famille
Version du système:                         10.0.22621 N/A build 22621

Steps to Reproduce:

Install VsCode SFDX Hardis
Open VsCode SFDX Hardis extension panel
Look at the sad icons :(

/duplicate of #194710

Thanks for creating this issue! We figured it's covering the same as another one we already have. Thus, we closed this one as a duplicate. You can search for similar existing issues. See also our issue reporting guidelines.
Happy Coding!


[REPL] Rewrite dictionary testing & improve infra to be more reliable.

This now uses lit. It's shorter and hopefully more reliable than
pexpect. As part of this, I also did all the plumbing for testing
the repl in lldb, so what I've done here can be used for other repl
tests. While I'm at it, remove the old test, we don't need it anymore.
rdar://problem/37407231

@swift-ci please test

I decided to be a little more conservative in this. If you think it's always safe also in the repl to use CHECK-NEXT I'll go for it.

If there's repl output between those check lines, I'd be concerned / would want a test failure to learn about the issue. I don't feel very strongly about this and wouldn't block the PR over it.

Also, thanks to @jrose-apple for suggesting the right way of testing multiple commands via < :)

Uh, note that you should use // for your comments, then! # is not a comment character in Swift.

@jrose-apple thanks! I'll update my pull request accordingly.

@swift-ci please test

@swift-ci please test


Cairo runner CLASS_HASH_NOT_FOUND when using other package contract

Problem
Since scarb 2.8.3, when a contract is imported from an other package, the deploy syscall using other_package::contract::TEST_CLASS_HASH panics with CLASS_HASH_NOT_FOUND.
Using scarb 2.8.2, it works as expected.
Steps

Write a first package with this contract:

#[starknet::contract]
pub mod c1 {
    #[storage]
    struct Storage {}
}

Write a second package with this test:

#[cfg(test)]
mod tests {
    use other::c1;

    #[test]
    fn deploy_other_package_contract() {
        let r = starknet::syscalls::deploy_syscall(
            c1::TEST_CLASS_HASH.try_into().unwrap(),
            1234,
            [].span(),
            false
        );

        println!("{:?}", r);
    }
}

You should see an error like:

Result::Err([384202928933128251697107453381487007374824001092])

Which stands for CLASS_HASH_NOT_FOUND.
Possible Solution(s)
The way crates ids are collected has changed between 2.8.2and 2.8.3, not using collect_all_crate_ids anymore.
But even trying to add it back, the correct crate ids are shown, but the error seems to persist.
Notes
No response
Version
`2.8.2` works, `2.8.3` stop working.

Manually adding the contract with build-external-contracts works. But is that the intended behavior for testing too?
If yes, then can be closed.

Hi!
Yes, since 2.8.3 we have stopped building all contracts from all dependencies preemptively. This is an optimization. Please take a look at the release notes https://github.com/software-mansion/scarb/releases/tag/v2.8.3

Found the release afterward, sorry didn’t close. Thank you @maciektr. 👍


Code Files for Number Guessing Game

Description
This is a simple number guessing game built using HTML, CSS, and JavaScript. The game generates a random number between 1 and 100, and the player has 10 chances to guess it correctly. After each guess, feedback is provided to help guide the player, indicating whether the guess is too high or too low. The game ends when the correct number is guessed or all chances are used.

TechStack

HTML: Provides the structure for the game, including input fields for guessing and displaying feedback to the player.
CSS: Used to style the game layout, making the interface user-friendly and visually appealing.
JavaScript: Implements the core game logic, including generating a random number, tracking the player's guesses, providing feedback, and determining whether the player wins or loses after 10 chances.

Type of change

[x] New Project
[ ] Issue fix (issue number: )

Checklist:

[X] I have included a README.md file for my project clearly explaining its purpose, functionality, and usage instructions (applicable for new projects, not bug fixes).
[X] My code adheres to the style guidelines outlined by this project.
[X] I have thoroughly reviewed my code to identify and address any potential errors or inconsistencies.
[X] I have added clear and concise comments to my code, especially in sections that might be challenging to understand at first glance.
[X] I have reviewed and followed the project's Contributing Guidelines to ensure my contribution aligns with the project's requirements.

@sudo-parnab Please review the PR. Thanks

great work @siddhant2002, Thank you!


Add a --pingfirst parameter to ping devices before testing.

Changed my mind.  PINGing an off machine can be as slow as waiting for another command to fail, so net benefit is likely not much if anything.


[pointer_interceptor] Widget flickers when page rebuilt under pointer_interceptor

I am still having the same problems when using flutter widgets on top of HtmlElementView. I read the comments on issue #54027 and it looks like it is still a bug and the temporary fix is to use Pointer Interceptor. Is this still the case? It has been a while since the last comment and the bug report has been closed.

Hi @jeannelim
This has been into a package, check out https://github.com/flutter/flutter/issues/54027#issuecomment-747132587,  not a temporary fix, hence the issue is closed
Closing, as this isn't an issue with Flutter itself. If you disagree, please write in the comments and I will reopen it.
Thank you

Thanks for the clarification. I'm using the Pointer Interceptor package and it works on some cases and not in others. I tried to replicate it in a sample app. When MyHomePage is rebuilt, with the Pointer Interceptor the page flickers when the comment button appears and without the Pointer Interceptor the comment button just appears without any flickering. What would you suggest?
class MyHomePage extends StatefulWidget {
MyHomePage({Key key, this.title}) : super(key: key);
final String title;
@override
_MyHomePageState createState() => _MyHomePageState();
}
class _MyHomePageState extends State {
int _counter = 0;
void _incrementCounter() {
print('counter pressed');
setState(() {
_counter++;
});
}
@override
Widget build(BuildContext context) {
return Scaffold(
body: Stack(children: [
MyHtmlView(
src: "assets/sample.pdf",
),
if (_counter==2) PointerInterceptor(
child:
Center(
child: FloatingActionButton(
onPressed: () => print('comment button pressed'),
child: Icon(Icons.comment),
),
),
),
]),
floatingActionButton: PointerInterceptor(
child: FloatingActionButton(
onPressed: _incrementCounter,
tooltip: 'Increment',
child: Icon(Icons.add),
),
),
);
}
}
class MyHtmlView extends StatefulWidget {
final Key key;
final String src;
final double height, width;
MyHtmlView({this.key, this.src, this.height, this.width});
@override
State createState() {
return MyHtmlViewState();
}
}
class MyHtmlViewState extends State
with AutomaticKeepAliveClientMixin {
@override
void initState() {
super.initState();
final html.IFrameElement _iframeElement = html.IFrameElement()
..height = '100%'
..width = '100%'
..src = widget.src
..style.border = 'none'
..style.overflow = "hidden"
..allow = "autoplay"
..allowFullscreen = true;
// ignore: undefined_prefixed_name
ui.platformViewRegistry.registerViewFactory(
widget.src,
(int viewId) => _iframeElement,
);
}
@override
void dispose() {
super.dispose();
}
@override
bool get wantKeepAlive => true;
@override
Widget build(BuildContext context) {
super.build(context);
return Stack(children: [
Center(
child: HtmlElementView(
viewType: widget.src,
),
),
]);
}
}

This is most likely related to https://github.com/flutter/flutter/issues/71888; @jeannelim can you take a look at 71888 and see if it seems familiar?

No, I don't think it's the same issue.
My problem is using Pointer Interceptor when the state changes. Originally in my sample code I have this
        if (_counter == 2)
          //If this PointerInterceptor is commented out no flickering, but the button can't be clicked
          PointerInterceptor(
            child:
            Center(
              child: FloatingActionButton(
                onPressed: () => print('comment button pressed'),
                child: Icon(Icons.comment),
              ),
            ),
          ),

so when _counter == 2 the page would flicker because of the Pointer Interceptor. But if I move the condition to the child it doesn't flicker anymore.
        //if (_counter == 2)
          //If this PointerInterceptor is commented out no flickering, but the button can't be clicked
          PointerInterceptor(
            child: _counter == 2 ?
            Center(
              child: FloatingActionButton(
                onPressed: () => print('comment button pressed'),
                child: Icon(Icons.comment),
              ),
            )
            : Container(width: 1, height: 1),
          ),

So it's like the Pointer Interceptor has to be built on the first build. Does that make sense?

I am seeing a similar issue. I have a PDF being rendered and I am showing an AlertDialog. If I wrap the AlertDialog with PointerInterceptor I can click on fields and buttons but when the AlertDialog is shown it does a "load" on the PDF viewer inside the HtmlElementView and re-renders it at the beginning of the PDF document.
If I don't wrap with PointerInterceptor it doesn't do a load again and remains at same position but I can't click on buttons and fields in the AlertDialog.

@gib40f can you minimally reproduce the issue (in a new flutter issue?). I'm currently working in rendering HtmlElementViews in a way that shouldn't reload, and the more test cases, the better!

David,
Here is a link to a minimal Flutter project that I think demonstrates the behaviour.
https://github.com/gib40f/flutterpointerinterceptor
Much appreciated that you are looking into it.
Thanks
Simon
Simon Gibson
Software Engineer | The Australian e-Health Research Centre
CSIRO Health and Biosecurity
T: +61 7 3253 3613 |  M:<PHONE_NUMBER>
E: @.*** | www.csiro.au | www.aehrc.com
Address: Level 5 - UQ Health Sciences Building 901/16, Royal Brisbane and Women's Hospital,  Herston   Qld  4029

From: David Iglesias @.>
Sent: 07 April 2021 10:58
To: flutter/flutter @.>
Cc: Gibson, Simon (H&B, Herston - RBWH) @.>; Mention @.>
Subject: Re: [flutter/flutter] [pointer_interceptor] Widget flickers when page rebuilt under pointer_interceptor (#77369)
@gib40fhttps://github.com/gib40f can you minimally reproduce the issue (in a new flutter issue?). I'm currently working in rendering HtmlElementViews in a way that shouldn't reload, and the more test cases, the better!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com/flutter/flutter/issues/77369#issuecomment-814526374, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AB4NITAVBJM2XANLUFFVTEDTHOU4FANCNFSM4YVJW4KQ.

I've started working on this, please track progress here: https://github.com/flutter/flutter/issues/80524

@gib40f it seems that your platform view is not being rendered underneath the bottom bar.
In the example that you produced there's no need for the pointer interceptor. It is only required when the buttons are OVERLAID on top of the HtmlElementView (think of a Stacked widget, is the most extreme case of this)
This is what your app looks like, in html render mode, in the chrome devtools:

@gib40f ahhh, I misunderstood, I thought it was the two buttons in the first page. My apologies. Let me verify again with the experimental engine I'm building!

@gib40f here's the deployed version of your demo app with the experimental engine applied, the PDF is not reloading anymore:
https://dit-grain-pdf-reload.web.app
(Note that "Without PointerInterceptor" is letting mouse events go through the modal and into the PDF, so I guess the preferred way of showing this modal is With PointerInterceptor.)
The only modification I had to do to your code is just to ensure the iframe has a 100% height/width so it fills the allocated space by the framework:
$ git diff lib
diff --git a/lib/main.dart b/lib/main.dart
index f85adbf..eb56868 100644
--- a/lib/main.dart
+++ b/lib/main.dart
@@ -152,6 +152,8 @@ class _MyHomePageState extends State<MyHomePage> {
         ..id = uri.hashCode.toString()
         ..src = uri
         ..style.border = 'black'
+        ..style.width = '100%'
+        ..style.height = '100%'
         ..addEventListener('load', (event) {
           print('load event happened - ${event.type}');
         });


m3u8: import Apple's test samples

Apple - you know, the one who basically "own" the HLS spec - provide some m3u8 samples at
https://developer.apple.com/streaming/examples/
These would be good to have in testdata. I saw that Shaka Player have the examples in their test suite.

Would this be in addition to or replacing the current samples?

Would this be in addition to or replacing the current samples?

In addition to. Looking at the playlists in the testdata directory
each one seems to be there to test different tags. But it's not clear
looking at the files what each one is really for. A comment at the top
of each file, and/or a descriptive file name would be helpful
especially for someone forgetful like me :)

But it's not clear looking at the files what each one is really for.

Actually, looking at it again today, after a sleepy Sunday, I think
it's relatively clear what each is for. For example,
testdata/frame_rate.m3u8 is for frame rates, with names for each (PAL,
NTSC etc.) and testdata/resolution.m3u8 is for resolution. There's two
which are unclear:

bbb.m3u8
tos.m3u8

I've fixed these up in 7c79b05479.


Better handling of markerZoomAnimation event hooks

Fixes #4453. This is two-fold:

L.Layer shall remove the same layer events that it attached. No longer assume that two calls to L.Layer.getEvents() will return the same values. (not 100% needed for this bug, but it is a sane change)
L.Marker needs to know a map option before deciding whether to attach a zoomanim event handler or not. Manual handling on onAdd and onRemove is thus needed.

Despite my efforts, I couldn't make a failing test case before the bugfixes, so no new unit tests :-(

Any update on this?

looks good to me


Add api to allow error message window to be customizable.

Right now the default error window is not customizable or very useful. Add an api where users can customize what is shown when an unexpected error occurs.

I modified the command.js to emit "error" event on my local. But I can't publish the branch and pull request.


New version: OttoZumkeller.QR-CodeReader version 1.1.0

Pull request has been created with WinGet Releaser v2 :rocket:
Microsoft Reviewers: Open in CodeFlow

I have installed my app locally without any trouble, Windows Defender has not flagged it as malware or anything else and all checks have passed successfully. So I don't see why there is a "Validation-Executable-Error"? Further information would be greatly appreciated.

Manual Validation ended with:

4:16:32 PM: 2024-01-02 16:16:32.263 [FAIL] Installer failed security check. Url: https://github.com/ottozumkeller/QR-Code-Reader/releases/download/v1.1.0/QR-Code-Reader-1.1.0.msi Result: 0x80004005

(Automated response - build 512.)


LFS-877: When clicking (+) on a subject chart, don't allow the creation of new subjects that are not descendants of the current subject

This addresses the remaining issue from #571

I ran into this problem and I believe it is out of scope:

create Demographic form for patient P1
go to P1's chart
delete Demographic form
click on the (+) and try to create a new Demographic form
this happens if you did not refresh prior to clicking on (+)


Error Duplicate Header Detected

Duplicate header detected: "If other, indicate where". Please make sure all non-empty headers are unique

That means what it says - two of you header cells had the same value in it, in this case If other, indicate where
The row-based methods us the header row as object keys, so there can be no duplicates.

is there any ways to use first column as headers?

@Makstorm do you mean instead of making everything based on rows, use columns instead? Like the first column is the headers and adding each "row" would add a column instead?

Yep, I have google sheets that use colums like you sad and i need to fetch data from it

well it's certainly possible... but would take quite a few changes to restructure things in the codebase. Can you just flip your sheet? You could also probably have a second read-only sheet that flips the data just for viewing (from rows back to columns)


Error: waiting Firewall Policy Rule Collection Group "rcg-core"

Deployment of firewall fails on a new fresh deployment of TRE.
The error of interest appears to be this one:-
Error message: Unable to find image '***.azurecr.io/tre-shared-service-firewall@sha256:47de4b8b5b23fadbc82856ba6f14dfd410cf32eb4c089d2c15e31ca8040d2b7c' locally ╷ │
Error: waiting Firewall Policy Rule Collection Group "rcg-core"
Full error output below:-
5468f7b2-9bfb-4589-9e7c-d6224b3e4493  deployment_failed  install   /shared-services/11336b4d-f3f3-4dc1-84cc-41e5cdc23a19  11336b4d-f3f3-4dc1-84cc-41e5cdc23a19:
Error message: Unable to find image '.azurecr.io/tre-shared-service-firewall@sha256:47de4b8b5b23fadbc82856ba6f14dfd410cf32eb4c089d2c15e31ca8040d2b7c' locally ╷ │
Error: waiting Firewall Policy Rule Collection Group "rcg-core" (Resource Group "rg-" / Policy: "fw-policy-"): Code="FirewallPolicyUpdateFailed" Message="Put on Firewall Policy fw-policy- Failed with 1 faulted referenced firewalls" │  │   with azurerm_firewall_policy_rule_collection_group.core, │   on rules.tf line 1, in resource "azurerm_firewall_policy_rule_collection_group" "core": │    1: resource "azurerm_firewall_policy_rule_collection_group" "core" *** │  ╵
error running command /cnab/app/terraform /usr/bin/terraform apply -auto-approve -input=false -var api_driven_network_rule_collections_b64=W10= -var api_driven_rule_collections_b64=W10= -var microsoft_graph_fqdn=graph.microsoft.com -var sku_tier=Standard -var tre_id=*** -var tre_resource_id=11336b4d-f3f3-4dc1-84cc-41e5cdc23a19: exit status 1 Error:
error running command /cnab/app/terraform /usr/bin/terraform apply -auto-approve -input=false -var api_driven_network_rule_collections_b64=W10= -var api_driven_rule_collections_b64=W10= -var microsoft_graph_fqdn=graph.microsoft.com -var sku_tier=Standard -var tre_id=*** -var tre_resource_id=11336b4d-f3f3-4dc1-84cc-41e5cdc23a19: exit status 1 1
error occurred: 	* mixin execution failed: package command failed /cnab/app/cnab/app/mixins/terraform/runtimes/terraform-runtime install ╷ │
Error: waiting Firewall Policy Rule Collection Group "rcg-core" (Resource Group "rg-" / Policy: "fw-policy-"): Code="FirewallPolicyUpdateFailed" Message="Put on Firewall Policy fw-policy-*** Failed with 1 faulted referenced firewalls" │  │   with azurerm_firewall_policy_rule_collection_group.core, │   on rules.tf line 1, in resource "azurerm_firewall_policy_rule_collection_group" "core": │    1: resource "azurerm_firewall_policy_rule_collection_group" "core" *** │  ╵
error running command /cnab/app/terraform /usr/bin/terraform apply -auto-approve -input=false -var api_driven_network_rule_collections_b64=W10= -var api_driven_rule_collections_b64=W10= -var microsoft_graph_fqdn=graph.microsoft.com -var sku_tier=Standard -var tre_id=*** -var tre_resource_id=11336b4d-f3f3-4dc1-84cc-41e5cdc23a19: exit status 1 Error:
error running command /cnab/app/terraform /usr/bin/terraform apply -auto-approve -input=false -var api_driven_network_rule_collections_b64=W10= -var api_driven_rule_collections_b64=W10= -var microsoft_graph_fqdn=graph.microsoft.com -var sku_tier=Standard -var tre_id=*** -var tre_resource_id=11336b4d-f3f3-4dc1-84cc-41e5cdc23a19: exit status 1    1
error occurred: 	* mixin execution failed: package command failed /cnab/app/cnab/app/mixins/terraform/runtimes/terraform-runtime install ╷ │
Error: waiting Firewall Policy Rule Collection Group "rcg-core" (Resource Group "rg-" / Policy: "fw-policy-"): Code="FirewallPolicyUpdateFailed" Message="Put on Firewall Policy fw-policy-*** Failed with 1 faulted referenced firewalls" │  │   with azurerm_firewall_policy_rule_collection_group.core, │   on rules.tf line 1, in resource "azurerm_firewall_policy_rule_collection_group" "core": │    1: resource "azurerm_firewall_policy_rule_collection_group" "core" *** │  ╵
error running command /cnab/app/terraform /usr/bin/terraform apply -auto-approve -input=false -var api_driven_network_rule_collections_b64=W10= -var api_driven_rule_collections_b64=W10= -var microsoft_graph_fqdn=graph.microsoft.com -var sku_tier=Standard -var tre_id=*** -var tre_resource_id=11336b4d-f3f3-4dc1-84cc-41e5cdc23a19: exit status 1 Error:
error running command /cnab/app/terraform /usr/bin/terraform apply -auto-approve -input=false -var api_driven_network_rule_collections_b64=W10= -var api_driven_rule_collections_b64=W10= -var microsoft_graph_fqdn=graph.microsoft.com -var sku_tier=Standard -var tre_id=*** -var tre_resource_id=11336b4d-f3f3-4dc1-84cc-41e5cdc23a19: exit status 1    1
error occurred: 	* container exit code: 1, message:    ; Command executed: az cloud set --name AzureCloud && az login --identity -u cb711806-1c70-4803-a83d-be084f044f7b && az acr login --name *** && porter install "11336b4d-f3f3-4dc1-84cc-41e5cdc23a19" --reference .azurecr.io/tre-shared-service-firewall:v1.1.5  --param arm_environment="public" --param arm_use_msi="true" --param id="11336b4d-f3f3-4dc1-84cc-41e5cdc23a19" --param microsoft_graph_fqdn="graph.microsoft.com" --param tfstate_container_name="tfstate" --param tfstate_resource_group_name="" --param tfstate_storage_account_name="" --param tre_id="" --force --credential-set arm_auth --credential-set aad_auth
Steps to reproduce

Deploy tre at version 0.15.x
This error appears on the first run.
A rerun at this point fails with an error saying "Firewall Policy Rule Collection Group "rcg-core" already exists
login to azure, delete the "rcg-core" network collection
rerun successful

Azure TRE release version 0.15.x:
Believing that this is possibly a terraform ordering issue, "depends_on" has been added  to make the network collections dependent on the FW policy, and then subsequently then making the FW itself dependent on the network collection. This seemed to make matters worse so that attempted fix has been reverted.

Hi @Danny-Cooke-cCK. We have seen this before. I believe it is either the rule collection being created before the firewall policy is showing succeeded, or an Azure level failure with the deployment of the Firewall or Firewall Policy.  In your case I expect the former as rerunning succeeded.
Unless can reproduce it is hard to resolve... As a first step the Azure RM terraform provider in the Firewall Shared Service
terraform {
  required_providers {
    azurerm = {
      source  = "hashicorp/azurerm"
      version = "=3.53.0"
    }
  }

  backend "azurerm" {}
}

Looks like it could do with an update.

Thanks. This should be easy enough to recreate. it happens on every deployment we do for the first time. I'll get this fix in and test during this week and report back

Thanks strange as we don't see it in our extended tests, which are fresh deployments each time.

So a strange update on this. We spent the last few weeks running deployments with this issue occurring every time. After raising this ticket and making no changes at all, the problem has disappeared during two further deployments.  So i think we can close this as and underlying azure issue which seems to be rectified now? . Slightly annoying that it's disappeared as it was so consistently failing

If it comes back let us know. I've seen it before too, but very infrequently.

We're getting something similar when the firewall shared service deploys:

The initial message about the missing container image is not present in our log, but the remainder is the same.

Possibly this? https://github.com/hashicorp/terraform-provider-azurerm/issues/15440

The missing container image can be ignored, docker returns that before needs to pull. We do try to  supress it in some places.
@jonnyry if look in the portal at the Provisioning state of the Firewall and the Firewall policy, what does it show? Do they show failed or succeeded?

We have succeeded:

On both the firewall and the policy?

Ah sorry, yes the policy has failed:

If you can - rather than just deleting and trying again (we know that will fix it if you need to move on now) it would be good to create a support case in the portal and ask for root cause as to why it has failed? Feel free to loop me into the email once get a support engineer - marcus.robinson at microsoft.com .
Unless you can see anything in the activity log on the resource? If any failures, please post the JSON output. Thanks.

Sorry only just had chance to do a re-deploy (to a clean env)... same issue again (though this time I did get the "Unable to find image" error:

Here's the Activity Log on the Firewall Policy:

Here's the main failure I could see in the JSON on the activity log
    "properties": {
        "statusMessage": "{\"status\":\"Failed\",\"error\":{\"code\":\"ResourceOperationFailure\",\"message\":\"The resource operation completed with terminal provisioning state 'Failed'.\",\"details\":[{\"code\":\"FirewallPolicyUpdateFailed\",\"message\":\"Put on Firewall Policy fw-policy-nwsdedev Failed with 1 faulted referenced firewalls\"}]}}",

When you say "deleting it and trying again" - do you mean just deleting the Firewall Policy in the Azure Portal and re-running the deploy?

Let me know if that works, in the meantime I'm going to try and find out if its an issue that has been seen elsewhere (outside of this project).

Deleting the rcg-core rule collection and then re-running the failed job worked.

Thanks for your input @jonnyry. I haven't had time to investigate further on this but experience the same and like i said, i found it to be inconsistent failing sometimes and then working sometimes.
to me the problem seems to be a dependency issue but then it fails with something completely different. What i was going to do next week is take the firewall code out separately, and run it in its own deployment just as terraform coe (removing the porter element from the equation) and seem if it fails like that. I'll report back when i've had chance

I wouldn't expect the Azure resource to be in a failed state as a result of a terraform dependency issue. Ultimately I think need to create a support case with the Azure team, with a failed deployment that they can look at.

I've been in touch with an engineering on the Azure Networking team. They would love some logs from Terraform with timestamps and correlation IDs.
To do this the the env var needs to be set: TF_LOG="TRACE"
@Danny-Cooke-cCK  You can see some shared services have a file to deploy locally already templates/shared_services/gitea/terraform/deploy.sh, if can create one of these for the firewall service and reproduce, it would be amazing. You can use make terraform-deploy DIR=./templates/shared_services/firewall/terraform/

ok cool. leave it with me. sounds like a monday job :)

Or even just the Azure resource ID -  such as  /subscriptions/bb0916b2-xxxx-4efb-xxx-a41ecc9fd132/resourceGroups/rg-tre0db03523/providers/Microsoft.Network/firewallPolicies/fw-policy-tre0db03523 would be useful. Via Email or Teams.

Will return to this thread when have some further information. Azure team is investigating the operation logs.

Hi @marrobi did you hear anymore from back from the Azure team?  We've just experienced this again on a fresh deployment cc @m1p1h

Can you create a support case via the portal and when you get a support engineer loop me in via email? It's not always the same thing.
My workaround it to delete Firewall Policy Rule Collection Group "rcg-core", ensure the policy and Firewall are in a succeeded state and then run an upgrade on the firewall.

Created supported case

@marrobi sent you the log by email.

Thanks, awaiting product group feedback.

Just to add that I've tried upgrading the Terraform azurerm provider version to the latest 3.93.0 and are still seeing the same error as above.

I've been thinking. We could move the firewall resource itself into the core deployment. Then just have the rules as the shared service. This would avoid these dependency issues and also potentially simplify deployment.
Could also have an env var in the config.yaml to specify firewall SKU, or even to not deploy the firewall at all for development sceanrios.
@tamirkamara welcome your thoughts on this.

Hi @marrobi just wondering if you could help me understand where the firewall dependency issue lies -
I'm presuming it's not as simple as the firewall policy & the firewall being deployed at the same time - as these are both declared within https://github.com/microsoft/AzureTRE/blob/main/templates/shared_services/firewall/terraform/firewall.tf and I would hope terraform implicitly understands the dependency between these two.
Is it the fact that other shared services apply firewall rules, potentially at the same time / before the firewall & policy itself have been created?  (Since the firewall is a shared service itself & shared services are deployed concurrently in the Deploy TRE GitHub Action)

I believe the issue is the the terraform provider for the firewall is returning "success" before the deployment has actually finished. Hence the rules fail as are being associated with a Firewall that hasn't finished deploying. Other than having a pause, or loop to check, not something we can fix in the Azure TRE code base.

Ok, so it seems the firewall rule collections can't be applied if other operations on the subnets in the VNet are in progress.
I suggest we try adding these dependencies to all of the route table associations ( https://github.com/microsoft/AzureTRE/blob/ddddbf6e3e8d13db477f70dc2ca8048dd12c563a/templates/shared_services/firewall/terraform/routetable.tf#L18-L52 )  along with azurerm_firewall_policy_rule_collection_group.dynamic_network and azurerm_firewall_policy_rule_collection_group.dynamic_application  so no subnets  on the vnet do not have any concurrent operations until after the firewall rules have deployed.


[1.11] Release 1.11.7

@runcom @umohnani8 @giuseppe PTAL
This includes the fsync patch as well.

/test all

LGTM

/lgtm

I am working on releasing this :)


[backport] Assume CUDA v8 in cuSPARSE check

Backport of #1780

[automatic post] Jenkins, test this please.

Jenkins CI test (for commit bca5fdf7634ca8d3d0acb64632bc86239948dfef, target branch v5) succeeded!


Drillthrough function reflection only base store data

Steps to reproduce
I have a partial join between 2 datastores.

When I perform a drillthrough, I only see data from the base store and not the joined store.

Environment

atoti: 0.4.2
Python: 3.8.5
Operating System: win32

Indeed, columns from partially joined stores can't be used in drillthroughs.

#684 Similar type of issue.


DCOS-19114 DCOS-19108 DCOS-19109 DCOS-19111: add filter nodes by health

This adds the DSL filter functionality from the service page to the nodes page.

Yes Design wise it is not looking the best right now. But I am going to implement the Service filter as well and as  soon as this one is removed I would like to expand the bar over the whole line.
Closes DCOS-19114 DCOS-19108 DCOS-19109 DCOS-19111
Checklist

[ ] Did you add a JIRA issue in a commit message or as part of the branch name?
[ ] Did you add new unit tests?
[ ] Did you add new integration tests?
[ ] If this is a regression, did you write a test to catch this in the future?

Alfred test this please

Alfred test this please

Alfred test this please

Unhealthy proximity alarm!

Comments have been addressed.

Took care of the comments @ahoskins and finally made the grid view work with the filters.

@Poltergeist we've got some test that need to be fixed 🤓

Alfred please retest this.

@Poltergeist looks like legit fails?!

Alfred test this please

Alfred please test this

Alfred please test this

I'll look into this tomorrow morning first thing.

@philipnrmn I had a look at the failing integration tests, both failed locally for me (cc @bstavroulakis) so I pushed a fix for Networks-cy which was failing.
The other one is the same issue @nLight reported above where we are not able to filter when on grid view.
I can confirm that isn't working for me either, I tested locally running the local start and the testing.

@Poltergeist (unless you want to hand this one off to @philipnrmn 😏 )

its not, it is also broken on master…
ticket: https://jira.mesosphere.com/browse/DCOS-20051

dismissing dimas review, @ahoskins can you please re-review? 👍


prefix links with https

Based on a feedback, we should replace our links to set a protocol prefix (https:) rather than just calling them from //.
It's a better approach if the examples are copied to a local environment and opened via a file protocol.

:+1:. Besides from the reason mentioned there, nowadays https:// is fast and increasingly necessary, so protocol-relative URLs are really becoming an anti-pattern.


Macro Blind GM rolls

When making a macro to roll on a better table, I'm having a hard time getting the rolltables to be made as anything but public. I'd like the macro to roll it as a Blind GM roll, but the standard syntax doesn't seem to work.

Could you please provide an example macro?
Would help to know what to test against.

I came to ask the same thing. I cannot find any API documentation on how to send results to chat as a GMroll.
Using the example in the API, there is no where to add a version of {rollMode:"gmroll"}
const table = game.tables.getName("Master Loot Rolls"); game.betterTables.betterTableRoll(table);

This will be possible with #142
The macro would look like this:

const table = game.tables.getName("Master Loot Rolls");

//blind roll
game.betterTables.betterTableRoll(table, {rollMode: 'blindroll'});

//gm roll
game.betterTables.betterTableRoll(table, {rollMode: 'gmroll'});

//self roll
game.betterTables.betterTableRoll(table, {rollMode: 'selfroll'});

Only these values are valid. Anything else is ignored.


Autoscaling not working

Description
I try to use this module with enabled autoscaling for reader instances. When I create a cluster based on the following example in the readme I only get a cluster with one writer instance:
instance_class = "db.r6g.large"
  instances = {
    one = {}
  }

  autoscaling_enabled      = true
  autoscaling_min_capacity = 1
  autoscaling_max_capacity = 5

Am I missing something? This should be pretty straightforward based on the docu but does not seem to work.
⚠ Note
Before you submit an issue, please perform the following first:

Remove the local .terraform directory (! ONLY if state is stored remotely, which hopefully you are following that best practice!): rm -rf .terraform/
Re-initialize the project root to pull down modules: terraform init
Re-attempt your terraform plan or apply and check if the issue still persists

Versions

Module version [Required]:
7.6.2
Terraform version:
1.3.3

Reproduction Code [Required]
Module
module "aurora_cluster" {
  count                  = var.aurora_cluster_settings.enabled ? 1 : 0
  source                 = "terraform-aws-modules/rds-aurora/aws"
  version                = "7.6.2"
  create_cluster         = var.aurora_cluster_settings.create_cluster
  name                   = "${var.cluster_name}-postgres-db-cluster"
  engine                 = "aurora-postgresql"
  engine_version         = var.aurora_cluster_settings.engine_version
  vpc_id                 = module.vpc.vpc_id
  subnets                = module.vpc.private_subnets
  create_security_group  = false
  port                   = var.aurora_cluster_settings.port
  vpc_security_group_ids = [aws_security_group.aurora_security_group.id]
  storage_encrypted      = var.aurora_cluster_settings.storage_encrypted
  kms_key_id             = aws_kms_key.encryption.arn
  instance_class         = var.aurora_cluster_settings.instance_class
  instances = {
    one = {}
  }
  autoscaling_enabled             = var.aurora_cluster_settings.autoscaling_enabled
  autoscaling_min_capacity        = var.aurora_cluster_settings.autoscaling_min_capacity
  autoscaling_max_capacity        = var.aurora_cluster_settings.autoscaling_max_capacity
  autoscaling_target_cpu          = var.aurora_cluster_settings.autoscaling_target_cpu
  apply_immediately               = var.aurora_cluster_settings.apply_immediately
  monitoring_interval             = var.aurora_cluster_settings.monitoring_interval
  performance_insights_enabled    = var.aurora_cluster_settings.performance_insights_enabled
  performance_insights_kms_key_id = var.aurora_cluster_settings.performance_insights_kms_key_id
  preferred_maintenance_window    = var.aurora_cluster_settings.preferred_maintenance_window
  preferred_backup_window         = var.aurora_cluster_settings.preferred_backup_window
  backup_retention_period         = var.aurora_cluster_settings.backup_retention_period
  enabled_cloudwatch_logs_exports = var.aurora_cluster_settings.enabled_cloudwatch_logs_exports
  publicly_accessible             = var.aurora_cluster_settings.publicly_accessible
  auto_minor_version_upgrade      = var.aurora_cluster_settings.auto_minor_version_upgrade
  master_password                 = var.aurora_cluster_settings.master_password
  create_random_password          = false
  tags = {
    Environment = var.environment
    Terraform   = "true"
  }
}

Variables
aurora_cluster_settings = {
    enabled                  = true
    create_cluster           = true
    port                     = "3306"
    engine_version           = "14.5"
    storage_encrypted        = true
    autoscaling_enabled      = true
    autoscaling_min_capacity = 1
    autoscaling_max_capacity = 3
    autoscaling_target_cpu   = 70
    instance_class           = "db.t3.medium"
    apply_immediately        = true
    monitoring_interval = 10
    performance_insights_enabled    = true
    performance_insights_kms_key_id = **************"
    preferred_maintenance_window    = "mon:04:00-mon:05:00"
    preferred_backup_window         = "03:00-04:00"
    backup_retention_period         = 3
    enabled_cloudwatch_logs_exports = ["postgresql"]
    publicly_accessible             = false
    auto_minor_version_upgrade      = false
    master_password                 = var.aurora_password
  }

Steps to reproduce the behavior:

Expected behavior

Actual behavior

Terminal Output Screenshot(s)

Additional context

Isn't that correct - you asked for a min capacity of 1 and you got 1? When there is load added it should trigger the autoscaling event to kick out a new instance which will be a reader (the writer instance is a reader/writer)

The examples says following:
3. Create homogeneous cluster scaled via autoscaling. At least one instance (writer) is required

Resources created:
Writer: 1

Reader(s):
At least 1 reader
At most 5 readers

As far as I understand it should add at least one reader and a writer.

Ok, I tested it now with the following setting:
  instance_class = "db.r6g.large"
  instances = {
    one = {}
  }

  autoscaling_enabled      = true
  autoscaling_min_capacity = 2
  autoscaling_max_capacity = 5

Its the same result only one writer instance is created but no additional reader instances.

Testing with this configuration as well and getting the same result. It appears the configuration suggested in the docs doesn't work as described.


Remove the ability to set nullable strings

closes #39

Current coverage is 90.53%

Merging #40 into master will increase coverage by +0.18% as of a6a6f83

@@            master     #40   diff @@
======================================
  Files          134     134
  Stmts         4293    4299     +6
  Branches       443     445     +2
  Methods          0       0
======================================
+ Hit           3879    3892    +13
  Partial        155     155
+ Missed         259     252     -7

Review entire Coverage Diff as of a6a6f83

Powered by Codecov. Updated on successful CI builds.


Improve progress example

content-length: 29574010
2759
0% done
5518
0% done
8277
0% done
8948
0% done
11707
content-length: unknown
10
20
30
40
50
60
70
80
content-length: 1759
1759
100% done
completed

relates to https://github.com/square/okhttp/issues/3740


Hyphenate words displayed on multiple lines FIXED FOR (footer)

[x] This pull request has been linted by running npm run lint without errors
[x] This pull request has been tested by running npm run start and reviewing affected routes
[x] This pull request has been built by running npm run build without errors
[x] This isn't a duplicate of an existing pull request

Description
when we  set text style to "Open Dyslexic", enable "enhance inputs" and "syllables"; there is no hypen in the ### footer of the gmail so i fixed this .......
fixed in all types of devices you can check
Steps to test

go to deploy preview
then go to footer and set text style to "Open Dyslexic", enable "enhance inputs" and "syllables";

screenshot before-

after-

Related issues
#256 fixed only 2 part  see in the screenshot for 2 part

you plz avoid this file it uncessary showing in this pr thanks

Thanks for the pull request, @Raunaksingh100. It looks good.
When I tested this fix, it seemed misleading by adding a hyphen into an email address. I'm asking for designers' suggestion in the issue comment.


Support Advanced Usages

What kind of change does this PR introduce?
fix #32
What is the current behavior?
There's no way to specify additional options to configure the underlying requests library for advanced usages.
What is the new behavior?
A new optional parameter options is added to the constructor and the execute method to support advanced usages like SSL Cert Verification and Client Side Certificates.
Does this PR introduce a breaking change?
No

@steve148 Do you have any idea why is the discrepancy with Black? Maybe, due to different versions being used?

Local

Github Actions

@DaleSeo latest version of black gave me this.

@DaleSeo latest version of black gave me this.

Yeah, I'm still trying to figure out why my VSCode auto-formats differently from the command line 😞 .

@sreerajkksd Fixed the formatting issues by updating pre-commit hooks so that the same latest version of Black is used by the pre-commit, on my terminal and IDE.
➜  python-graphql-client git:(support-options) ✗ pre-commit autoupdate
Updating https://github.com/psf/black ... [INFO] Initializing environment for https://github.com/psf/black.
updating stable -> 20.8b1.
Updating https://gitlab.com/pycqa/flake8 ... [INFO] Initializing environment for https://gitlab.com/pycqa/flake8.
updating  -> 3.8.4.

@masudias Thanks for the feedback. I've added the Advanced Usage section to README. Hope it helps clarify how to use this library. Please feel free to improve the docs if you want it to be more clear.


Modal not working on some Samsung devices.

Is there a fix for the issue of modal not working on some Samsung devices ?

Any solution to this bug ? Facing same problem with Samsung devices.

We went back to the standard Modal component from React Native. Works great
for us !
Le jeu. 3 juin 2021 à 12:57, harsimrandev @.***> a
écrit :

Any solution to this bug ? Facing same problem with Samsung devices.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/jacklam718/react-native-modals/issues/270#issuecomment-853781513,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AOLE7CKO5RQG7GGGYQP7C2TTQ5N2RANCNFSM44Q5H2XQ
.

The devices that reported this same failure to me are
Galaxy Note 20 with Android 12
Galaxy S22 with Android 12
I think I will have to change to Standard Modal as well, other packages have general failures with Android 12, but this package only has it with Samsung devices


Fix bug in temporal utilities due to DST being ignored.

Which issue does this PR close?
Closes #901
What changes are included in this PR?
Replaces the function using_chrono_tz with a function using_chrono_tz_and_utc_naive_datetime
The rationale for this is that an offset for a timezone depends on the point in time at which the offset is required -- it will vary depending on whether DST is in effect at that point in time or not.
Are there any user-facing changes?
I'm not sure. using_chrono_tz is a publicly available function (albeit under the chrono-tz feature flag) so strictly speaking the API is changing? If this is a concern, we could have both functions appear (with using_chrono_tz remaining unused).
What do you think @alamb ?

Codecov Report

Merging #955 (7e0e187) into master (32d8c0a) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #955   +/-   ##
=======================================
  Coverage   82.31%   82.32%
=======================================
  Files         168      168
  Lines       48715    48713    -2
=======================================
+ Hits        40100    40102    +2
+ Misses       8615     8611    -4

Impacted Files
Coverage Δ

arrow/src/compute/kernels/temporal.rs
97.35% <100.00%> (+1.27%)
:arrow_up:

arrow/src/datatypes/field.rs
53.37% <0.00%> (-0.31%)
:arrow_down:

parquet_derive/src/parquet_field.rs
65.98% <0.00%> (ø)

parquet/src/encodings/encoding.rs
93.71% <0.00%> (+0.19%)
:arrow_up:

arrow/src/array/transform/mod.rs
85.47% <0.00%> (+0.27%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 32d8c0a...7e0e187. Read the comment docs.

Thank you @novemberkilo  -- I appreciate the follow up


Remove noop from external dependencies

Re https://github.com/microsoft/vscode-jupyter/issues/10307
We don't need external modules to offer noop ;)

[x] Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR).
[x] Title summarizes what is changing.
[x] Has a news entry file (remember to thank yourself!).
[ ] Appropriate comments and documentation strings in the code.
[ ] Has sufficient logging.
[ ] Has telemetry for feature-requests.
[ ] Unit tests & system/integration tests are added/updated.
[ ] Test plan is updated as appropriate.
[ ] package-lock.json has been regenerated by running npm install (if dependencies have changed).

Codecov Report

Merging #10372 (2f432b4) into main (cf7da9f) will decrease coverage by 0%.
The diff coverage is 100%.

@@          Coverage Diff          @@
##           main   #10372   +/-   ##
=====================================
- Coverage    64%      64%   -1%
=====================================
  Files       212      212
  Lines      9559     9559
  Branches   1530     1530
=====================================
- Hits       6145     6143    -2
- Misses     2935     2936    +1
- Partials    479      480    +1

Impacted Files
Coverage Δ

src/platform/api/pythonApi.ts
69% <100%> (ø)

src/platform/errors/errorHandler.ts
62% <0%> (-1%)
:arrow_down:


Wow! Incredible.

I'm yet to test this library but i had goosebumps when i seen it on the Async Webserver issues.
A couple questions

Do you have plans to implement SSE?
I'm currently using an ESP Async Webserver fork  and heavily using SSE.
Do you plan to implement middlewares?
Do you plan to implement AP filter?
Does this lib have not found capture?
Does this lib support handler classes? ( Create a handler class for a route endpoint and pass it to the server object )
Can it handle gzip compression? ( Send gzipped content automatically )

I'm excited to try this out!
Thank you in the name of all the open source ppl!

I'm glad that you're excited!  I wasn't sure what features were popular so
I implemented the minimum I needed for my own use. I'll look into SSE and
see how difficult it would be to add.
On Tue, Dec 5, 2023, 04:02 DrRandom @.***> wrote:

I'm yet to test this library but i had goosebumps when i seen it on the
Async Webserver issues.
One question. Do you have plans to implement SSE?
I'm currently using an ESP Async Webserver fork and heavily using SSE.
I'm excited to try this out!
Thank you in the name of all the open source ppl!
—
Reply to this email directly, view it on GitHub
https://github.com/hoeken/PsychicHttp/issues/3, or unsubscribe
https://github.com/notifications/unsubscribe-auth/AABEHSVQHKXTWYSK3Y6VKNLYH3PI7AVCNFSM6AAAAABAHKAM7GVHI2DSMVQWIX3LMV43ASLTON2WKOZSGAZDKNRXGA4DQMY
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>

Oops, I just saw the rest of your list.

event source: i'm looking into this and it seems possible, but it will definitely take a bit of work.  espasynctcp is tightly coupled with AsyncTCP so i need to change all that out + fix all the knock on effects
I'm not sure what you mean by middlewares?
AP filter would be cool, I can look into it if there is interest
Yes, you can set a notfound handler
Not exactly, this library is similar to ESPAsyncWebserver, but doesn't use the exact Handler class syntax that it does.  It uses a simpler .on(url, method, callback) style. Part of the reason is that the underlying ESP-IDF callbacks require a URL + method for each endpoint so you cant just loop over each handler and call canHandle for each request because of that.
it does not support gzip automatically but that could probably be added.  I'm not sure exactly how useful that would be though.  The slowdown in processing would probably offset the speed you gain from sending smaller files.  it does support sending .gz files from SPIFFS/LittleFS automatically if it finds {request_url}.gz

Do you mind sending me some code how you use Event Source?  The example on the ESPAsyncWebserver site is pretty basic.

Yeah, that was it. It is working with https://psychic.local/

yes, wss is working.. just that demo code isn't checking the protocol of the page and adapting appropriately.

Oh, it would be good if there were a callback to redirect to secure context if the user wants. Will test it thanks! Let me know if you need more examples or help on anything. I will fork the repo and see what i can do.

Yeah that would be great.  I think it might be possible to create a second server that redirects all requests to the https side.

Would you consider splitting the library to more files? It is really hard to see through the code when everything is in one file. I would split it into it's corresponding h and cpp files.

Absolutely.  I agree its a pain to read through it all.  I'm also going to try and make a flowchart of how all the pieces fit together.

I am preparing the changes for the EventSource + handlers functionality and just pushed a big cleanup that splits out all the individual classes and files.

That is wonderful. More pll should hear about this lib. We are waiting so long for exactly this library. So many ppl tried to do what MeNoDev done but all of it failed. I have tested the reliability of the requests and the websocket. I couldn't crash it with minimal test cases. I will write a more real world experience soon. The websocket is slower than ESPAsyncWebserver as you said, it can be improved. But again, you are amazing.

Thanks man!  To be fair, most of the hard work is done in the ESP-IDF library and PsychicHttp just makes it easy to use. :)

Quick little update, I have a pretty viable plan for v1.1 to add in EventSource stuff, as well as the generic handler functionality that ESPAsyncServer has. Plan is on the homepage if you're curious.  It's a bit of a job since the code isn't actually based on ESPAsyncWebserver, but I'll get there.  Tomorrows forecast is rainy so looking good for getting work done.

Will check!

Well, it sounds like a massive rewrite but it will worth it. If you have separate handlers the user can organise their code much more. Like in my case.

Really cool. I will test it as soon as i can. I think I will start to implement this tomorrow side by side to my esp async webserver.

Like @zekageri the world has been waiting years for this library, super excited to start the port on my code. EventSource is also important to me, so happy to contribute there.

@proddy thanks :)
I've got EventSource implemented in the main branch, seems to be working well.  I'm hoping to make a v1.1 release this week.   If you could test with the git version of the code and give feedback that would be great.
I'm going to start a "Porting From ESPAsyncWebserver" section on the docs.  I've already converted my code in bits and pieces, so a lot of it will be from memory.  It would be great if you could send me any issues you run into so I can add it to the list.


migration #736: moved auth tokens to the database

created new prisma models;
removed maps from class;
created include field in UserRepository;
created DbUser;
added DbUser to UserRepository;
simplified DbStudent;
changed in dtos telegram id to bigint;

closes #736

It's better to create repositories for new entities

No. It's not a business entity


Make a footer part of the site as a react element

Currently footer is hardcoded in the html markup, so that it is not possible to localize its content.
We want to transform this part of the site to a react rendered part. Defined it as a component and use prepared infrastructure to translate its content.

Is this still open?

there's a PR open for this - #67

@jmb521 it is nearly the month, since the last action was made in the pull request.
So if you are interested create your own pull request, let!s do it.
Take a look to the pull request comments:
https://github.com/Kentico/cloud-sample-app-react/pull/67
The work consist from:

move html from index.html to the component (do not forget to change class attributes to className)
change display type of the footer element in css (desribed in pullrequest comment)
(optionally) set up the translation for the element as is in other components

If you have any question, feel free to ask :-)

Implemented in https://github.com/Kentico/cloud-sample-app-react/pull/70


Sensei Ten Support

Not a problem, but the Sensei Ten from steelseries launched recently. Has the same basic layout as the other senseis (at least the raw) with RGB lighting included on the scrollwheel, and steelseries logo in the palm.
I'd hope it would be fairly simple to build support for it, but i personally am scared to attempt to just modify the old sensei files to get it working.
Currently i'm just using a VM with USB passthrough to modify the mouse settings.

I'd be willing to do any debugging necessary, as i do have the device on-hand. I have an arch machine with a windows VM to test with.

Yes, please modify the settings one by one in the VM and capture the packets with wireshark.
Please have one wireshark session log per action.
We can start with the DPI. Can you get me the following logs?

Set DPI 1 to min
Set DPI 1 to next step
Set DPI 1 to next step
Set DPI 1 to 1000
Set DPI 1 to max
Set DPI 2 to min
Set DPI 2 to next step
Set DPI 2 to max

Repeat the steps from DPI 2 for every other DPI setting, in case you have more than two DPI settings.

I'm not too familiar with capturing with wireshark, let alone logging with it. Sorry if it's any hassle, but could you give me some more explicit directions?

Issues i'm seeing with doing this already: Steelseries engine (At least with this mouse) allows up to 5 settings (I only personally use 1) and whenever i move the DPI/CPI slider past one of the other settings in either direction (either lower or higher DPI) it shifts where it is in the order.

I am not sure I follow. Can you explain better or send a screenshots/video?

Here's a video about that: https://f.cloudninja.pw/2019-12-14_23-35-20.mp4

I have an actual windows install now that i can use, if that makes it easier.


The link at the top of the repo may have been hijacked

The link at the top of the repo, http[colon]//production.ember-skeleton.divshot.io/ appears to have been lost, and I'm getting it blocked from my company vpn as a source of malware. You should probably remove it, change it, or fix whatever the issue is? Sorry I'm not a security expert.

Link removed. Thanks!


Fix a shutdown hanger because of a collection status lock.

Can only be tested by observing Jenkins in the next few weeks.

http://jenkins01.arangodb.biz:8080/view/PR/job/arangodb-matrix-pr/6323/


sign up form centered

Description
Please include a summary of the change and a link to which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes # (issue)
Type of change
Please delete options that are not relevant.

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

[x] Test A
[ ] Test B

Checklist:

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] My code has been reviewed by at least one peer
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[x] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes

sign up form prettier.  thats all i changed just a few lines of CSS


MPSAccelerator not available

🐛 Bug

MPSAccelerator can not run on your system since the accelerator is not available. The following accelerator(s) is available and can be passed into accelerator argument of Trainer: ['cpu'].

Raised from accelerator_connector.py::AcceleratorConnector#_set_parallel_devices_and_init_accelerator:
https://github.com/Lightning-AI/lightning/blob/2415834aaf4f215ddb0d618bf415405d670f9114/src/pytorch_lightning/trainer/connectors/accelerator_connector.py
Availability determined here:
https://github.com/Lightning-AI/lightning/blob/2415834aaf4f215ddb0d618bf415405d670f9114/src/pytorch_lightning/accelerators/mps.py
Check is wrong due to platform check here expecting arm (my M1 Max reports platform arm64):
https://github.com/Lightning-AI/lightning/blob/master/src/pytorch_lightning/accelerators/mps.py#L27

To Reproduce
from pytorch_lightning import Trainer
Trainer(accelerator='mps')

Expected behavior
Program should complete without raising an error.
Environment
* CUDA:
        - GPU:
        - available:         False
        - version:           None
* Packages:
        - lightning:         2022.8.2
        - lightning_app:     0.5.2
        - numpy:             1.23.0
        - pyTorch_debug:     False
        - pyTorch_version:   1.13.0.dev20220802
        - pytorch-lightning: 1.7.0
        - tqdm:              4.64.0
* System:
        - OS:                Darwin
        - architecture:
                - 64bit
                -
        - processor:         arm64
        - python:            3.9.12
        - version:           Darwin Kernel Version 21.5.0: Tue Apr 26 21:08:37 PDT 2022; root:xnu-8020.121.3~4/RELEASE_ARM64_T6000

cc @tchaton @rohitgr7 @akihironitta @justusschock

I've written a fix:
https://github.com/Lightning-AI/lightning/pull/13992

I caught the same error running the same testing code. Reinstalled the package. nothing changed. Can you advise it? Thanks.


FocusTSO - Price provider for Flare FTSO

FocusTSO. Data provider built by Focus Global team of developers and Polish Flare community members who run an educational portal in Polish , English and Japanese. The team also provide tools like Airdrop Simulator and recently released Delegation Portal.

We have just submitted the change - Trailing slash removed

Good afternoon,
We have just submited the change .
Regards
Andrzej Mackowiak
W dniu pon., 14.08.2023 o 13:25 Per Lindström @.***>
napisał(a):

@.**** requested changes on this pull request.
The PR does not passed yarn test as specified in the instructions, the
URL should not have a trailing slash.
—
Reply to this email directly, view it on GitHub
https://github.com/TowoLabs/ftso-signal-providers/pull/314#pullrequestreview-1576742887,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/BBVF324VINWU76GBMEQ23XDXVIKMLANCNFSM6AAAAAA3BROUEU
.
You are receiving this because you authored the thread.Message ID:
@.***>

Requested change done


Add to docs how to set none-standard Contextionary location

Related to: https://github.com/creativesoftwarefdn/weaviate/issues/574
Add to this file how to change to another Contextionary.

https://github.com/creativesoftwarefdn/weaviate/pull/672


Add example USV model: WAM-V

Ported the WAM-V model from VRX. The USV is static right now as we still need to add plugins.
to spawn the usv:
ros2 launch mbzirc_ign spawn.launch.py name:=usv world:=simple_demo model:=wam-v type:=usv x:=20 y:=0 z:=-1.0 R:=0 P:=0 Y:=0

After the review, I think we can just upload the model onto Fuel for anyone to use.

Works for me but the engine.dae and propeller.dae are missing.

See 4a767c2

ah thanks for adding the daes.