Roll Engine from 46c2ccae24e4 to dfde2aad73f9 (9 revisions)

https://github.com/flutter/engine/compare/46c2ccae24e4...dfde2aad73f9
2022-03-17<EMAIL_ADDRESS>Roll Dart SDK from 24bf86f16411 to 5bc905e69609 (9 revisions) (flutter/engine#32075)
2022-03-16<EMAIL_ADDRESS>Wrap the global timeline event handler callback in a std::atomic (flutter/engine#32073)
2022-03-16<EMAIL_ADDRESS>Update the magic number for JPEG to just FF D8 FF. (flutter/engine#32076)
2022-03-16<EMAIL_ADDRESS>Fix issues with nested gradients in html renderer. (flutter/engine#31887)
2022-03-16<EMAIL_ADDRESS>[web] Remove the --passfail flag when calling goldctl in post-submit (flutter/engine#32071)
2022-03-16<EMAIL_ADDRESS>Add WASM target in gn (flutter/engine#31670)
2022-03-16<EMAIL_ADDRESS>Add a display list op to clear to transformation stack. (flutter/engine#32050)
2022-03-16<EMAIL_ADDRESS>Fix done button click not blur in iOS keyboard (flutter/engine#31718)
2022-03-16<EMAIL_ADDRESS>Optionally specify the target dir in tools/gn (flutter/engine#32065)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC<EMAIL_ADDRESS>on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Gold has detected about 3 new digest(s) on patchset 9.
View them at https://flutter-gold.skia.org/cl/github/100270


Table: add context prop

Please makes sure these boxes are checked before submitting your PR, thank you!

[ ] Make sure you follow Element's Contributing Guide.
[ ] Make sure you are merging your commits to dev branch.
[ ] Rebase before creating a PR to keep commit history clear.
[ ] Add some descriptions and refer relative issues for you PR.

Vue now supports scoped template natively in 2.1. What's your opinion towards it? I think it can solve much edge cases such as context and variable scoping.
https://gist.github.com/yyx990803/faebe22e8763f5b17572b35ed96f52fe

@HerringtonDarkholme
Yes, We will soon support the feature and as a recommended.


solve panic.

solve panic in:
https://github.com/golang/groupcache/issues/145
The same issue happened to me. I add RWMutex outside and add RLock before get and Lock before Add. But outside lock seems not work, I got the same panic.
It seems that a type check is needed.
memory leak would be involved since delete(c.cache, kv.key) maybe ignored.

cc @neild @bradfitz @desimone

any one check this?
cc @neild @bradfitz @desimone


Sc 28993/instrument go sttp api

Problem: We don't have much insight into this API. Libraries that bundle their own loggers are noisy.
How this addresses the problem: We add basic logger support to the API through the Subscriber struct. This PR uses a slog.Logger but doesn't do anything particularly structured with the logs.

No further comments beyond the bug Alex pointed out; looks good otherwise! :)


How to adjust the order of sheets？

Adjust Sheet2 before Sheet1

Thanks for your issue, this library not support to adjust the order of sheets directly, you can rename sheet with SetSheetName, note that it won't be update the sheet name in the formula or reference associated with the cell. So there may be problem formula error or reference missing.

New function MoveSheet has been added, this function will be available on the next released version.

Hi @RichardHill, the MoveSheet function already released in the version 2.9.0. Please upgrade to the lasted version.


Final Comprehensive Exam Autograder Question

For the comprehensive final exam, when the professor said that "there will be no assistance offered for the autograder" did he mean that the autograder will not give any feedback on what we did wrong AND it will not tell us how many points we got? Or will it give us one or the other?

Anyone know the answer to this? I was hoping the professor or TA might know, but if a fellow student knows, do tell me! :)

It will function just like the other autograders. When I say that no assistance will be offered, I mean that you are not to come to office hours for assistance with the final exam programming tasks.

@jdmar3 Ohhh okay thank you so much for the clarification on that! Thanks for keeping the autograder aspect for the final, it will be very helpful! 😄


Cannot get ID token on getIDTokenForcingRefresh

[READ] Step 1: Are you in the right place?
YES
[REQUIRED] Step 2: Describe your environment

Xcode version: 10.2.1
Firebase SDK version: 6.5.0
Firebase Component: Auth, Core, Database, Analytics
Component version: 6.2.1, 6.1.0, 6.0.0, 6.0.4

[REQUIRED] Step 3: Describe the problem
Steps to reproduce:
I cannot refresh ID token for signed in user when app's lunching. I've found some closed issues https://github.com/firebase/firebase-ios-sdk/issues/3111 and https://github.com/firebase/FirebaseUI-iOS/issues/729 but they look closed and solved for Firebase SDK version 6.4.0. I updated all components and the Firebase SDK is 6.5.0 now, but I'm still receiving this error.
Relevant Code:
My code:
func getToken(force: Bool) -> Promise<String>
    {
        return Promise { resolve, reject in

            self.getIDTokenForcingRefresh(force, completion: { token, error in

                if let error = error {
                    reject(error)
                    return
                }

                guard let token = token else {
                    reject(ErrorManager.build("Unable to authenticate, Firebase error"))
                    return
                }

                resolve(token)
            })
        }
    }

Response:
Error Domain=FIRAuthErrorDomain Code=17999 "An internal error has occurred, print and inspect the error details for more information." UserInfo={FIRAuthErrorUserInfoNameKey=ERROR_INTERNAL_ERROR, NSLocalizedDescription=An internal error has occurred, print and inspect the error details for more information., NSUnderlyingError=0x283f78300 {Error Domain=FIRAuthInternalErrorDomain Code=3 "(null)" UserInfo={FIRAuthErrorUserInfoDeserializedResponseKey={
    code = 400;
    details =     (
                {
            "@type" = "type.googleapis.com/google.rpc.Help";
            links =             (
                                {
                    description = "Google developers console";
                    url = "https://console.developers.google.com";
                }
            );
        }
    );
    message = "API key not valid. Please pass a valid API key.";
    status = "INVALID_ARGUMENT";
}}}}

Are you getting 400 errors on any other Firebase SDK requests?

@morganchen12 no, I don't receive any other 400 errors, I use some firebase observers and they are working fine, but I can't fetch new ID token.
I've also tried re-downloading the GoogleService-Info.plist file, the API_KEY is/was there, but it didn't help.

Does swapping the GoogleService-Info.plist for one from a different Firebase project repro the issue? If not, it may be an issue with your Firebase project.

@morganchen12 it looks like it fires only on early app lunching, like if it's called in applicationDidBecomeActive when app is lunching. When I trigger the call later it looks it's working. Can it happens because Firebase needs some time to configure first? But I think applicationDidBecomeActive happens after didFinishLaunchingWithOptions
Not sure if it may be helpful but here is our flow:
On the backend side we are using https://firebase.google.com/docs/auth/web/password-auth#sign_in_a_user_with_an_email_address_and_password and https://firebase.google.com/docs/reference/admin/node/admin.auth.Auth.html#createcustomtoken methods to login the user.
On sign in the backend is using signInWithEmailAndPassword(email, password) method to get the user, then it uses .auth().createCustomToken(uid) and sends back custom_token to the iOS app when the user is successfully signed in. Then the custom token is used to sign in to Firebase on app side.
Later when the session token expires or on lunch the app checks if the it is still valid and if not it calls getIDTokenForcingRefresh

Can you share your AppDelegate file?

@morganchen12 I saw 6.5.0 - [Firebase/Auth][I-AUT000004] Token auto-refresh scheduled in 55:00 for the new token. in my logs too, but I can't see any documentation for it. Is there now any process that will auto-refresh the token?

Chuan, can you answer the last question about token refresh?

@morganchen12 I discovered that this error happened when I was storing the User reference to keychain and then I used it during relaunching to get new Token ID if it was invalid. Do you know why this happen?

@skyfoxa Are you storing the User yourself? Could you please describe the full steps to reproduce.

@renkelvin Yes, I was storing it myself. I had a custom object, LocalUser  with some properties needed in our app and with  property var actualFirebaseUserRef: User?. Once the app received the User object in Auth.auth().addStateDidChangeListener it would assign this object to LocalUser property. Then the LocalUser was encoded via NSKeyedUnarchiver.archiveObject and stored to the keychain using KeychainAccess pod. This LocalUser is like singleton and whenever it is accessed in the app it is loaded from Keychain.
static var main: LocalUser? {
        guard let encoded = Keychain()[data: LocalUser._userKeychainKey] else { return nil }
        let user = LocalUser(encoded: encoded)
        return user
}

I was playing with it for a while, I removed the logic responsible for storing the User object to the keychain, then I switched between several git branches several times and today I tried to revert to the commit with the logic responsible for storing the User to the keychain and I didn't see the error in the console anymore. Not sure why the error is gone, probably the pods didn't update properly last time or the pods were cached.

I saw 6.5.0 - [Firebase/Auth][I-AUT000004] Token auto-refresh scheduled in 55:00 for the new token. in my logs too, but I can't see any documentation for it. Is there now any process that will auto-refresh the token?
@renkelvin  is there any documentation for this feature?

OK, thanks for providing the details. There is additional internal mechanism to handle the API key and tokens. This should explain the API key error you received. My recommendation is to always keep LocalUser updated with FIRAuth.auth.currentUser to avoid such errors.


Update index.md

Fix variable interpolation typo

Why:
Closes: https://github.com/github/docs/issues/27622

What's being changed (if available, include any code snippets, screenshots, or gifs):
The Copilot docs description currently reads "Use the REST API to manage the % data variables.product.prodname_copilot_for_business %} subscription for your organization.".
This fix will instead render the value of variables.product.prodname_copilot_for_business.

Check off the following:

[x] I have reviewed my changes in staging, available via the View deployment link in this PR's timeline.

For content changes, you will also see an automatically generated comment with links directly to pages you've modified. The comment won't appear if your PR only edits files in the data directory.

[x] For content changes, I have completed the self-review checklist.

@meanguy Thank you for opening a PR and linking it to your issue! ✨
I'll get this triaged for review! :zap:


Problem running linux scripts

Describe the bug
I have some scripts programmed to raise and lower volumes, run vlc, etc, etc, etc. After a while, the scripts stop executing and the error message:
QProcessPrivate::createPipe: Cannot create pipe 0x7f0320139030 (Too many open files)
Expected behavior
that the scripts work
-Linux

Q Light Controller Plus version 4.12.4 and Q Light Controller Plus version 4.12.3
Debian bullseye

Additional context
Add any other context about the problem here.

I don't know if this problem can be solved with what is described in this page:
https://www.baeldung.com/linux/error-too-many-open-files

Thanks, as soon as I have some time, I will visit the forum.

So basically you opened an issue report regarding a misterious script you haven't shared, without describing the actual communication channel with QLC+ (web?? other??) and you want QLC+ to be fixed somehow.
Sorry but this is not the way to report an issue. As suggested by Santiago, please use the forum like everybody else.

Sorry, I have been trying to register in the forum for days and it is impossible.
I keep trying.

I launch the scripts from the qlc+ virtual console, with a button that executes it. Here is an example script.
#!/bin/sh
xdotool set_desktop 3
player-control vlc play
exit
When I start running qlc+ , the scripts work, but, after a while, they stop working and I get the error described above. It is as if the program opens many pipes and does not close them. I increased the limits according to the instructions in the link and for now they work, but the processes don't seem to close.
Sorry about the forum, but I really am not able to register.

Does the script actually ends or some process in it keeps it pending?
You can probably inspact this with the 'ps' command

I tested this command in Ubuntu 22.04. The command pal
Missatge de Massimo Callegari @.***> del dia dt., 7 de
juny 2022 a les 15:50:

Does the script actually ends or some process in it keeps it pending?
You can probably inspact this with the 'ps' command
—
Reply to this email directly, view it on GitHub
https://github.com/mcallegari/qlcplus/issues/1339#issuecomment-1148704241,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABO5H46XFCLRL6MT2APIGQ3VN5HQRANCNFSM5XQOSE7A
.
You are receiving this because you commented.Message ID:
@.***>

I used in a console
playerctl -p vlc play
playerctl -p vlc stop
xdotool command is not needed to control vlc with playerctl command.
Missatge de Santiago Benejam Torres @.***> del dia dt., 7 de
juny 2022 a les 19:12:

I tested your commands and I cannot run player-control. Have you installed
anything that provides the player-control command?. In Ubuntu I found only
playerctl to control vlc.
Missatge de Massimo Callegari @.***> del dia dt., 7
de juny 2022 a les 15:50:

Does the script actually ends or some process in it keeps it pending?
You can probably inspact this with the 'ps' command
—
Reply to this email directly, view it on GitHub
https://github.com/mcallegari/qlcplus/issues/1339#issuecomment-1148704241,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABO5H46XFCLRL6MT2APIGQ3VN5HQRANCNFSM5XQOSE7A
.
You are receiving this because you commented.Message ID:
@.***>

I believe that the scrip ends, since it carries the command "Exit 0". I have also tried running it from a script called "vlc_play.sh" , which contains those commands and it does the same. When I start qlc+ , the output from the command :
#lsof -p $(pidof qlcplus)
....
qlcplus 1224 manteniment   47r  a_inode               0,13        0   10093 inotify
qlcplus 1224 manteniment   48u  a_inode               0,13        0   10093 [eventfd]
After executing the command ( which is associated with a button that executes a syscommand ) the output is:
#lsof -p $(pidof qlcplus)
....
lcplus 1224 manteniment   47r  a_inode               0,13        0   10093 inotify
qlcplus 1224 manteniment   48u  a_inode               0,13        0   10093 [eventfd]
qlcplus 1224 manteniment   50w     FIFO               0,12      0t0   22078 pipe
qlcplus 1224 manteniment   51r     FIFO               0,12      0t0   22079 pipe
qlcplus 1224 manteniment   53r     FIFO               0,12      0t0   22080 pipe
qlcplus 1224 manteniment   55r     FIFO               0,12      0t0   22081 pipe
qlcplus 1224 manteniment   57u  a_inode               0,13        0   10093 [pidfd]
If I run another script again, the output is:
#lsof -p $(pidof qlcplus)
....
qlcplus 1224 manteniment   50w     FIFO               0,12      0t0   22078 pipe
qlcplus 1224 manteniment   51r     FIFO               0,12      0t0   22079 pipe
qlcplus 1224 manteniment   52w     FIFO               0,12      0t0   29072 pipe
qlcplus 1224 manteniment   53r     FIFO               0,12      0t0   22080 pipe
qlcplus 1224 manteniment   54r     FIFO               0,12      0t0   29073 pipe
qlcplus 1224 manteniment   55r     FIFO               0,12      0t0   22081 pipe
qlcplus 1224 manteniment   57u  a_inode               0,13        0   10093 [pidfd]
qlcplus 1224 manteniment   58r     FIFO               0,12      0t0   29074 pipe
qlcplus 1224 manteniment   60r     FIFO               0,12      0t0   29075 pipe
qlcplus 1224 manteniment   62u  a_inode               0,13        0   10093 [pidfd]
Debian is configured by default with a limit of 1024. The output of the command is:
$ulimit -n
1024
So, if I run the scripts a number of times, there comes a time when I get the error:
$QProcessPrivate::createPipe: Cannot create pipe 0x7f0320139030 (Too many open files)
If I increase the limit to 500000 as proposed in the link, I don't get the error.
I don't know if this is the solution or if something can be done to make qlc+ close these "pipes".
Note:
Qlc+ I use it to project presentations with libreoffice impress, pdf with impressive, play audios with audacious and project videos with vlc on an extended desktop that exits to a projector.
I use the xdotool command to switch virtual desktops. Vlc only runs on desktop 4. So, if I run an impress presentation on desktop 1, when I switch desktops, with a good compton configuration, I get a fade of images on the extended desktop.
(P.S. I still can't register, is there a problem with the forum or am I just clumsy?)

BTW this is related to #1270
As for forum, new users are registering daily. Perhaps try with another email address

I have pushed a change that fixes the issue on the procfix branch.
Please help to test.
Please note though that this changes the behavior of a system command execution. A Script must have a proper wait entry to keep the Script running for as long as the system command will last (e.g. play a 10 seconds video, wait 10 seconds)
If no wait time is added, the Script will end immediately and the invoked process killed accordingly.
I might need to fix the case where a Script is a Chaser step, then the duration is overridden.
@chille  might be interested in this too.

Hello @mcallegari, I would object that the script needs to know the timing expected from the environment. Most scripts just trigger another program or remote entity (e.g. to update a screen or start something), but are not made to match the duration of the calling step, e.g. through a web hook to set the room lights on a house automation it will terminate before the new hous scene is done and the sequence in qlcplus continues. Maybe, I misunderstand your point, though.
Can we fork the qlcplus process and let the script perform whatever needs to be done and ignore how long it is running, otherwise? The script would then terminate and the forked process would as well whenever the script deems it time to terminate.
I might be able to look into this in a few weeks and try to join you in finding a solution.

The problem here is that QProcess leaves file descriptors open forever (at least on Linux), unless you explicitly tell Qt to close/terminate/delete them.
Not knowing the duration of a Script would cause to terminate it too soon.
How to solve this then?

I would dig into a solution with the QProcess::startDetached Architecture, but I have less research and experience than anyone in this chat how to manage the pipes closure yet.
To me, that directs into what I would expect, but I may be wrong. It should be possible to detach and monitor or timeout in the detached process to clean things up because when calling a command from within qlcplus it's more a fire-and-forget with the baseline that if the called program or script is behaving well, terminating sometime and we don't clutter the system resources.
Is my assumption wrong?

@sbenejam I'd ike to hear your opinion too on this since I know you use/used Scripts in a few projects. Thanks

Massimo, I tested with system scripts or commands long time ago to control
libreoffice or pdf viewers to make presentations.
From this case I have tested the version of GIT not the procfix yet.
With the playerctl -p vlc command play the processes remain open until QLC+
stops. The player-control command that Suso uses in Debian don't exists in
Ubuntu.
I think it depends on whether a system command or script that can contain
other system commands that can end up either in a good or bad way.
For example mpv video.ogg plays a video with a duration that QLC+ does not
know. But if you want to play the video for only 10s a wait 10 maybe
enough, I don't know how it can be done.
playerctl -p vlc does nothing if VLC is not running.
Maybe per playerctl a wait 1 is enough, so the only thing that does is send
an opportune signal, stop, pause, etc. to VLC.
If I have some time this weekend I'll test the profix commit with different
commands, playing vídeos and audio files.
Regards
Missatge de Massimo Callegari @.***> del dia dj., 16 de
juny 2022 a les 18:20:

@sbenejam https://github.com/sbenejam I'd ike to hear your opinion too
on this since I know you use/used Scripts in a few projects. Thanks
—
Reply to this email directly, view it on GitHub
https://github.com/mcallegari/qlcplus/issues/1339#issuecomment-1157868962,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABO5H45GHD7WQTPI4SJWKKLVPNH6TANCNFSM5XQOSE7A
.
You are receiving this because you were mentioned.Message ID:
@.***>

@mcallegari, the changes on the branch seem to make sense, better than a detached start, I think now. But do they leave sufficient time for commands to execute?
If I run time playerctl -p vlc pause with an open player it takes up to 60ms on the commandline.
I wonder how we can reproduce this. When I add the systemcommand to engine/test/script/script_test.cpp, compile and execute it, it has no effect on the running VLC. Either it is not executed at all, it is terminated prematurely or there is another failure which I don't know of yet. Stderr seems to be silenced.
I see two kinds of systemcommands:

Forground programs started at that point in the script and terminated at the end of the script as they run in the foregound (like a VLC being fired up and stopped like in the documentation)
Background programs calling a hook on e.g. a DBUS (playerctl) or REST (curl) interface to remote-control another program, which may take some second until they should terminate.

As we know of programs which shall terminate at the end of the script and some which may take a second or more:

Should we consider to add documentation in the manual to add a "wait 3s" after the systemcommands because they will be terminated
or add the expected execution time (as an argument to the systemcmd) and track and wait before terminating them
or distinguish systemcmd into systemcmd and systemservice

How can we add a test for the behavior? I tried with bash -c "wait 3s && date > /tmp/script_test.log", but had no success in facilitating the script_test.cpp for this matter yet.

Fixed by #1358


Download Jenkins artifacts fails with ExtractionFailed Error: Unsupported file type "undefined"

Required Information
Entering this information will route you directly to the right team and expedite traction.
Question, Bug, or Feature?
Bug
Enter Task Name: Jenkins download artifacts
Environment

Server - Azure Pipelines or TFS on-premises?
Azure Pipelines: PG-CT/DIAC/ReleaseAndCiScripts Trigger

Agent - Hosted or Private:
Private: Windows Server 2012 R2

Issue Description
We have moved our pipelines from one organization to another. after this move, the Jenkins download artifact task started to fail, when it is trying to extract the downloaded artifact:
2021-02-01T10:57:30.3729956Z ##[section]Starting: Download artifacts produced by DIAC/ReleaseAndCiScripts 2021-02-01T10:57:30.3866217Z ============================================================================== 2021-02-01T10:57:30.3866604Z Task         : Jenkins download artifacts 2021-02-01T10:57:30.3866914Z Description  : Download artifacts produced by a Jenkins job 2021-02-01T10:57:30.3867198Z Version      : 1.175.0 2021-02-01T10:57:30.3867423Z Author       : Microsoft 2021-02-01T10:57:30.3867876Z Help         : https://docs.microsoft.com/azure/devops/pipelines/tasks/utility/jenkins-download-artifacts 2021-02-01T10:57:30.3868293Z ============================================================================== 2021-02-01T10:57:32.3462228Z Downloading content from Jenkins server:https://XXX/jenkins//job/DIAC/job/ReleaseAndCiScripts//api/json with strict SSL:false 2021-02-01T10:57:32.3683842Z Download artifacts from last successful build of DIAC/ReleaseAndCiScripts 2021-02-01T10:57:32.9371670Z Found job type org.jenkinsci.plugins.workflow.job.WorkflowJob 2021-02-01T10:57:32.9406506Z Downloading content from Jenkins server:https://XXX/jenkins//job/DIAC/job/ReleaseAndCiScripts//api/json?tree=lastSuccessfulBuild[id,displayname] with strict SSL:false 2021-02-01T10:57:33.4743316Z Found Jenkins job details jobName:DIAC/ReleaseAndCiScripts, jobType:org.jenkinsci.plugins.workflow.job.WorkflowJob, buildId:274, branchName:undefined 2021-02-01T10:57:34.0748456Z Downloading artifacts from: https://XXX/jenkins///job/DIAC/job/ReleaseAndCiScripts//274/artifact/*zip*/ 2021-02-01T10:57:34.7577721Z Downloading  to C:\agent\_work\1\s\jenkinsArtifacts\archive.zip 2021-02-01T10:57:34.7918752Z Downloaded  to C:\agent\_work\1\s\jenkinsArtifacts\archive.zip 2021-02-01T10:57:35.0867427Z Total Files: 1, Processed: 1, Skipped: 0, Failed: 0, Download time: 1.01 secs, Download size: 0Bytes 2021-02-01T10:57:35.1542149Z ##[warning]Can\'t find loc string for key: ExtractionFailed 2021-02-01T10:57:35.1558149Z ##[error]ExtractionFailed Error: Unsupported file type "undefined"     at DecompressZip.extractFile (C:\agent\_work\_tasks\JenkinsDownloadArtifacts_86c37a92-59a7-444b-93c7-220fcf91e29c\1.175.0\node_modules\decompress-zip\lib\decompress-zip.js:309:11)     at C:\agent\_work\_tasks\JenkinsDownloadArtifacts_86c37a92-59a7-444b-93c7-220fcf91e29c\1.175.0\node_modules\decompress-zip\lib\decompress-zip.js:242:28     at Array.forEach (native)     at DecompressZip.extractFiles (C:\agent\_work\_tasks\JenkinsDownloadArtifacts_86c37a92-59a7-444b-93c7-220fcf91e29c\1.175.0\node_modules\decompress-zip\lib\decompress-zip.js:241:11)     at C:\agent\_work\_tasks\JenkinsDownloadArtifacts_86c37a92-59a7-444b-93c7-220fcf91e29c\1.175.0\node_modules\decompress-zip\lib\decompress-zip.js:121:21     at _fulfilled (C:\agent\_work\_tasks\JenkinsDownloadArtifacts_86c37a92-59a7-444b-93c7-220fcf91e29c\1.175.0\node_modules\q\q.js:854:54)
Task logs
debugLogs.zip
Error logs
2021-02-01T10:57:35.1542149Z ##[warning]Can't find loc string for key: ExtractionFailed
2021-02-01T10:57:35.1558149Z ##[error]ExtractionFailed Error: Unsupported file type "undefined"
at DecompressZip.extractFile (C:\agent_work_tasks\JenkinsDownloadArtifacts_86c37a92-59a7-444b-93c7-220fcf91e29c\1.175.0\node_modules\decompress-zip\lib\decompress-zip.js:309:11)

We have noticed something very similar in the last few days. We had another issue that was preventing the Azure Devops job from being triggered. Last job that worked was the 25th Dec. Fixed the trigger issue last Friday (29th Jan) and now see this.
In the meantime we have updated Jenkins from LTS 2.263.1 to 2.263.3. There are some suggestions of changes in the zip format in the latter, even though at least some of the fixes are reported as regression issues for 2.263.2. I am wondering if the format has changed over this time and Azure Devops is having problems coping.

I have downgraded our Jenkins instance from 2.263.3 to 2.263.1 and the link to Azure Devops has now started working again.
I have also compared the behaviour of using the "(all files in zip)" under artifacts - the code on Azure Devops appears to be using the equivalent of this. The behaviour of this command has indeed changed - based on the Jenkins released notes, it seems deliberately so. Let's assume that the file we were trying to send is called foo.zip. The old (2.263.1) behaviour creates a file called archive.zip which in turn contains foo.zip at its root level. The new (2.263.1) behaviour still creates file archive.zip but its contents are slightly different: inside the zip there is a top-level directory archive and foo.zip is inside that directory.
My suggestion is that the Adevops code is updated to handle both scenarios - either automatically or there being an option.

Note: I may have got the above analysis the wrong way around (it might be the 2.263.1 version that has got the extra directory) but definitely downgrading to 2.263.1 seems to fix the problem. This sounds related to the following Jenkins issue JENKINS-64621, although that claims to have been fixed for 2.263.3.

I've now tried  Jenkins 2.263.4. The change of behaviour with archive.zip I noticed seems to have been fixed (the file structure of the zip is the same as 2.263.1) but I still see the problem reported. Suggestion then is that the real issue is something different. Currently my only solution is to stick to Jenkins 2.263.1, which continues to work. That is not a long term solution.

I have the same issue with Azure DevOps on hosted Nodes with Jenkins 2.281
The same environment as previsouly worked for a few weeks.
I assume that changes made in Jenkins 2.276 may habe brocken the Azure task.

I'm too experiencing this issue and it seems related to a change in Jenkins output. Although I see the same folder structure, the file must be different in some way that Azure cannot identify. I upgraded to Jenkins 2.277.1 and the issue still remains. So, as mentioned by others, I'm sticking with 2.263.1
Based on the error logs, it seems like it might be an issue with the Node package used for unzipping.

Facing the same problems when using ubuntu 16.04 and Jenkins 2.277.1

@narula0781 hi, do you have any progress on this issue?
We found that it is reproducible on the latest jenkins server

I tested this with Jenkins server 2.6 and later upgraded it to 2.7 and could reproduce the issue. After debugging, issue seems to be with Jenkins server compression, artifacts folder that gets downloaded from Jenkins has all the files but the type of the file is missing in its metadata which is resulting in this failure.
Example file detail from debugging:
FileDetails {
_offset: 418,
_maxSize: 22,
parent: 'archive',
filename: 'test.txt',
path: 'archive\test.txt',
type: undefined,
mode: 420,
compressionMethod: 8,
modified: 2021-04-26T07:19:56.000Z,
crc32:<PHONE_NUMBER>,
compressedSize: 22,
uncompressedSize: 20,
comment: '',
flags:
{ encrypted: false,
compressionFlag1: false,
compressionFlag2: false,
useDataDescriptor: true,
enhancedDeflating: false,
compressedPatched: false,
strongEncryption: false,
utf8: true,
encryptedCD: false } }
Due to this unzip of the folder is failing. We need to raise a bug with Jenkins to look into this as there is not much we can do at task end.

Workaround is to downgrade Jenkins.
We will reopen this if we hear back from Jenkins end.

@harshiniks could you post the reference to the Jenkins ticket you have I assume by now raised?

I have located the bug.
The OSS dependency "decompress-zip": "0.3.0" defaults to 'undefined' file type for directory entries in zip files if the zip file is labeled as created on UNIX.
I made a small test program to extract the Jenkins generated zip in the same way as the task, and this bug causes the extraction failure with the same error message.
Solution is to update to "decompress-zip": "0.3.3"
I have not tested this in place, and the history for DownloadBuildArtifactsV0 implies this might need other dependencies to be updated.

@harshiniks will you take the change suggested by @mstfn ?

HI @john-forrest let us take a look

We have the same problem, the azure unzip return: ExtractionFailed Error: Unsupported file type "undefined"
Are there workaround that not ask the jenkins downgrade?

I see this links to #15007

This is resolved now with latest version of task 1.90


Perses Governance

I'm planning on proposing a super simple governance model for Perses with existing maintainers selecting / approving new maintainers.  Before I start, can I get a list of the existing maintainers? Knowing how many maintainers we have now and who they are will help me make a proposal that will work for us today with the idea that we can grow it over time as needed.

Hi @geekygirldawn !
Oh interesting, thank you for doing it !

Knowing how many maintainers we have now and who they are

When you say that, are you asking what do they do in Perses, or are you thinking about something else ?
Here the current list of persons that actively contribute to Perses in term of code:

Antoine Thebaud (@AntoineThebaud)
Augustin Husson (@Nexucis)
Luke Tillman (@LukeTillman)
Steven Cobb (@sjcobb)

Then you have :

Julius Volz (@juliusv)
Rob Skillington (@robskillington)
Karan Malhi

that are helping by giving ideas, defining in an understable way the scope of Perses, talking about it around them ...etc.
Does it help ?

I was thinking about including 2 roles:

Contributors: People who contribute in various ways (including ideas), but who don't have edit rights to merge PRs.
Maintainers: People who can merge contributions from other people.

yes all 4 contributeurs are owner of the perses org and so can merge the PRs.
Even the 3 others can also merge it, but it's unlikely that will happen ( But hey, it can change and then I will say something wrong haha)

and the last person that can merge PRs today is Charles Ma (@chucknthem), but I don't know his status.

It might be a good idea to scrub the list of org owners and remove access for people who aren't actively contributing.
I also see a few more contributors here: https://github.com/perses/perses/graphs/contributors if they are still active.
I also wonder if we should use a settings.yaml file to provide more transparency around who has access to do what? Chris set that up for CoreDash, but it's not something we need to do right away.
https://github.com/coredashio/community/blob/main/.github/settings.yml
I think I have what I need right now. I will look in more detail about where people have actually made contributions, and make a proposal in a PR for who the maintainers should be based on contributions. Once I have a proposal, if I get anything wrong, I'm sure people will tell me 🤣

I also see a few more contributors here: https://github.com/perses/perses/graphs/contributors if they are still active.

Na the only contributors that are active are the 4th one above.

I think I have what I need right now. I will look in more detail about where people have actually made contributions, and make a proposal in a PR for who the maintainers should be based on contributions. Once I have a proposal, if I get anything wrong, I'm sure people will tell me

cool :). Don't hesitate to ping me if you need further details

I also wonder if we should use a settings.yaml file to provide more transparency around who has access to do what? Chris set that up for CoreDash, but it's not something we need to do right away.

While considering this for Prometheus, it seemed to risky to introduce this. While it brings welcomed transparency, it turns every contributor into an admin.

I think we can close this issue right @geekygirldawn  ?

Yes, I'll close this. Thanks for all of your help (and patience) with this! :)


Move the logic for invoking a fuzzer into a shell script

Thanks! Was meaning to do this at some point...
bors r+


List of update and edits of a page

Hello,
Thank you for this great repo, it is very useful.
I was wondering if there is a way to have the list of edits of a page as we can have on the "Update" part on the Notion app.  I would love to have who has changed the page and what they did.
Thank you very much in advance.

That would be a great idea. I'm going to mark this as an Enhancement and see whether anyone wants to take it on.


Allow anything that implements Observable to be returned from getObservable

Open the flood gates!

In response to issue#283, this PR proposes letting any thing that implements the Observable interface through the getObservable function. Right now it appears this function is only used in the most.from method.
The criteria has been changed to reflect the wording in the API docs for most.from here:

... it must have a Symbol.observable method that return an object with a well-behaved .subscribe() method.

(maybe I should add a spelling correction for return?)
The following was changed:

check if truthy o has an observable Symbol function (oSf) on it.
remove the unbinding and rebinding of the oSf (Did not see the need to do this, will totes put back if ya want it)
verify that the thing returned from the oSf provides a subscribe method. Pretty sure it gets checked further down the line, but makes sense to reject in most.from. This is also an opinion and will also change this back to just checking for an object type, if desired.
Added some additional assertions to provide, falsey and truthy values for possible types.
updated the is valid spec to account for the need to have the subscribe method.

Thanks @evilsoft.  I'll have time to look at this more closely tomorrow.

(maybe I should add a spelling correction for return?)

Good catch. Please do!

remove the unbinding and rebinding of the oSf

Believe it or not, there's a reason behind this madness.  It's possible for a malicious or buggy getter to "attack" code that accesses it twice.  For example, the getter could return a function the first time, and a non-function the second time.  Promise implementations typically take this extra precaution (accessing a foreign thenable's then method only once), and I noticed that es-observable does the same.  So, unlikely as it seems, it's also not much extra code, so I'd like to keep it.
We should probably add a comment about why it's there, though, since it isn't obvious at all!  Let me know if you want to do that in this PR, or if you want me to do it separately.

Sounds good, I thought there was a good reason for it so I wanted to draw your attention to that change. I will add it back on this PR as I am the one that caused the damage.
That will make this simple PR 4 commits tho...should I rebase them into one?

Looks great, @evilsoft.

should I rebase them into one?

Nah, no worries.  We can just let github squash and merge them.
Thanks again for this!


Outdoor mapping Loop not close

Hello
I'm using cartographer for outdoor mapping.I use Visual Odometry (topic: /zed/odom), IMU (topic: /imu/data)  .Laser only used the front 180 degree.
final map image
https://drive.google.com/file/d/1ikTg0s1kHxhTAFN4OwTb1QMRqkZZRM5g/view?usp=sharing
output from rosbag_validate
https://gist.github.com/qs371102/11e203283657d34a27c96d9fa6bbe97f
bag file
https://drive.google.com/file/d/1-TayPX_BSlbwcygIMkishmwGdXB7oZoP/view?usp=sharing
cartographer_ros
https://github.com/qs371102/cartographer_ros
The launch file is demo_andi.launch
gampping result show that the Visual Odometry is reliable

After the bagfile play finished cant see any tend to loop close.I try to Tuning the params but work little .Any advice would be appreciated.

I would recommend to increase the search window of the fast correlative scan matcher in the config.


rbd admin: add a String method to LevelSpec type

Fixes: #522
This adds a String method to LevelSpec. I opted not to implement an Equals method as I felt that x.String() == y.String() is as expressive as x.Equals(y) in this case and I feel that Equals is starting to tread into territory that may interact with generics and so I'd rather leave that aside for now until Go has generics and the community has had time to experiment with them.
Checklist

[x] Added tests for features and functional changes
[x] Public functions and types are documented
[x] Standard formatting is applied to Go code

Not needed at this time. Closing.


fix(validateCallback): pass jotai setter

Closing issues
Closes #54

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (d8d463c) 96.99% compared to head (a3c94a5) 97.00%.
 Consider uploading reports for the commit 17cd660 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #55   +/-   ##
=======================================
  Coverage   96.99%   97.00%
=======================================
  Files           3        3
  Lines        2396     2402    +6
  Branches      243      243
=======================================
+ Hits         2324     2330    +6
  Misses         72       72

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


GraphQL resolvers/queries/mutations

https://www.apollographql.com/docs/react/local-state/local-resolvers/


Adding utility function for calculating model size in bytes

What does this PR do?
Adding a utility function for computing the size of a model per discussion in #8343
Does your PR introduce any breaking changes ? If yes, please list them.
No breaking changes.
Before submitting

[x] Was this discussed/approved via a GitHub issue? (not for typos and docs)
[x] Did you read the contributor guideline, Pull Request section?
[x] Did you make sure your PR does only one thing, instead of bundling different changes together?
[ ] Did you make sure to update the documentation with your changes? (if necessary)
[x] Did you write any new necessary tests? (not for typos and docs)
[x] Did you verify new and existing tests pass locally with your changes?
[x] Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)
[x] Did you list all the breaking changes introduced by this pull request?

PR review
Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

[ ] Is this pull request ready for review? (if not, please submit in draft mode)
[x] Check that all items from Before submitting are resolved
[x] Make sure the title is self-explanatory and the description concisely explains the PR
[x] Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?
Make sure you had fun coding 🙃

Hello @calebrob6! Thanks for opening this PR. We checked the lines you've touched for PEP 8 issues, and found:

In the file pytorch_lightning/utilities/model_helpers.py:

Line 73:1: E302 expected 2 blank lines, found 1
Line 78:121: E501 line too long (140 > 120 characters)
Line 91:13: E128 continuation line under-indented for visual indent
Line 91:13: W503 line break before binary operator
Line 93:16: W292 no newline at end of file

In the file tests/utilities/test_model_helpers.py:

Line 98:1: E302 expected 2 blank lines, found 1
Line 108:1: E302 expected 2 blank lines, found 1
Line 118:30: W292 no newline at end of file

@calebrob6 I merged master and added a changelog entry.
Ready for review?
This will then unblock #8495

Hey @awaelchli, I just requested a review, although I have not changed anything about the code since the above comments.
I think (from #8495) that this code should be merged as-is as an utility function, the model_size() property will be deprecated, then I will implement a new version of this utility function that deals with sparse tensors.

Yesterday #8495 was labelled as "blocked by 8500".
@roshikouhai @ananthsub @calebrob6 can you confirm in which order these two PRs should be reviewed and merged?

can you confirm in which order these two PRs should be reviewed and merged?

I think this shall be merged before deprecating size attribute

Dear @calebrob6,
Thanks for putting the effort with this PR. The Lightning Team decided to go with the ByteCounter approach for v1.5. in this PR: https://github.com/PyTorchLightning/pytorch-lightning/pull/10123
Closing this PR.
Best,
T.C


Update is_string_constructible for C++23 P2166R1

I work on MSVC's C++ Standard Library implementation, and we regularly build sol2 (along with many other open-source projects) to identify compiler/library bugs that would break your project, so we can fix them before shipping. This also allows us to provide advance notice of source-breaking changes - which is the case here.
The paper P2166R1 "Prohibiting basic_string And basic_string_view Construction From nullptr" has been accepted for the upcoming C++23 Standard, and we recently implemented it by merging https://github.com/microsoft/STL/pull/1995 from our contributor @sam20908. Our open-source test pass then discovered the following code in sol2 that leads to a compiler error in C++23:
https://github.com/ThePhD/sol2/blob/bb5f60e138191bb5838ffbd9d458701ff3b05552/include/sol/traits.hpp#L663-L666
According to my understanding, this type trait lists the various things that std::basic_string is constructible from, which allows other conversions in your library to be constrained in order to avoid ambiguity. This has been broken by C++23's addition of a std::basic_string constructor from std::nullptr_t (which is deleted, but that doesn't affect overload resolution).
This PR contains my proposed fix: use std::is_null_pointer_v to detect (cv-qualified) std::nullptr_t. I believe that this can be added unconditionally (i.e. not guarded by Standard mode). First, this type trait was present in C++17 along with std::is_same_v being used here. Second, before C++23, attempting to construct std::basic_string<CharT> from std::nullptr_t would consider the const CharT* constructor (and then lead to UB at runtime), while in C++23 it selects the new constructor. Because a constructor would be considered either way, it seems correct for both types to activate your is_string_constructible.
There may be other ways to fix this C++23 source-breaking change; there may also be additional occurrences of this throughout the sol2 codebase that we haven't encountered yet. Thanks to @cdacamar, MSVC compiler front-end dev, for analyzing and reducing this issue (which I originally mistakenly reported as an MSVC compiler bug).
Here are my instructions for how to reproduce the bug and verify the proposed fix, using our development build of the STL (as the C++23 change to std::basic_string is available on GitHub but will take some time to ship in a Visual Studio Preview):

Click to expand lengthy repro instructions:
:: Download and extract https://www.lua.org/ftp/lua-5.4.3.tar.gz .
:: For example, my working directory is C:\Temp\REPRO
:: so I extract it to C:\Temp\REPRO\lua-5.4.3 with:

7z x lua-5.4.3.tar.gz
7z x lua-5.4.3.tar

:: Use an x64 native command prompt, VS 2019 16.11 Preview 2:

"C:\Program Files (x86)\Microsoft Visual Studio\2019\Preview\VC\Auxiliary\Build\vcvars64.bat"

:: Build the STL:

git clone https://github.com/microsoft/STL
pushd STL
git submodule update --init --progress vcpkg
.\vcpkg\bootstrap-vcpkg.bat
.\vcpkg\vcpkg.exe install boost-math:x64-windows
cmake -G Ninja -S . -B out\build\x64
ninja -C out\build\x64
set INCLUDE=%CD%\out\build\x64\out\inc;%INCLUDE%
set LIB=%CD%\out\build\x64\out\lib\amd64;%LIB%
set PATH=%CD%\out\build\x64\out\bin\amd64;%PATH%
popd

:: Clone my fork of sol2:

git clone https://github.com/StephanTLavavej/sol2.git

:: Build the repro. It works in C++17 mode, but fails in C++23 mode with basic_string's new overloads:
:: Note: /std:c++latest /D_HAS_CXX23=1 is necessary for Clang until https://reviews.llvm.org/D103155 ships in Clang 13.

cl /std:c++17                          /EHsc /nologo /W4 /MT /Od /Ilua-5.4.3\src /Isol2\include /c sol2\examples\source\multi_results.cpp
cl /std:c++latest                      /EHsc /nologo /W4 /MT /Od /Ilua-5.4.3\src /Isol2\include /c sol2\examples\source\multi_results.cpp
clang-cl /std:c++17                    /EHsc /nologo /W4 /MT /Od /Ilua-5.4.3\src /Isol2\include /c sol2\examples\source\multi_results.cpp
clang-cl /std:c++latest /D_HAS_CXX23=1 /EHsc /nologo /W4 /MT /Od /Ilua-5.4.3\src /Isol2\include /c sol2\examples\source\multi_results.cpp

:: Check out my proposed fix:

pushd sol2
git checkout cxx23
popd

:: With the proposed fix, verify that the repro successfully compiles in both C++17 and C++23 modes:

cl /std:c++17                          /EHsc /nologo /W4 /MT /Od /Ilua-5.4.3\src /Isol2\include /c sol2\examples\source\multi_results.cpp
cl /std:c++latest                      /EHsc /nologo /W4 /MT /Od /Ilua-5.4.3\src /Isol2\include /c sol2\examples\source\multi_results.cpp
clang-cl /std:c++17                    /EHsc /nologo /W4 /MT /Od /Ilua-5.4.3\src /Isol2\include /c sol2\examples\source\multi_results.cpp
clang-cl /std:c++latest /D_HAS_CXX23=1 /EHsc /nologo /W4 /MT /Od /Ilua-5.4.3\src /Isol2\include /c sol2\examples\source\multi_results.cpp

Here is the full compiler output (from VS 2019 16.11 Preview 2 and Clang 11) from the "build" and "verify" steps at the end:

Click to expand lengthy compiler output:
C:\Temp\REPRO>cl /std:c++17                          /EHsc /nologo /W4 /MT /Od /Ilua-5.4.3\src /Isol2\include /c sol2\examples\source\multi_results.cpp
multi_results.cpp

C:\Temp\REPRO>cl /std:c++latest                      /EHsc /nologo /W4 /MT /Od /Ilua-5.4.3\src /Isol2\include /c sol2\examples\source\multi_results.cpp
multi_results.cpp
sol2\include\sol/tie.hpp(64): error C2593: 'operator =' is ambiguous
C:\Temp\REPRO\STL\out\build\x64\out\inc\xstring(3142): note: could be 'std::basic_string<char,std::char_traits<char>,std::allocator<char>> &std::basic_string<char,std::char_traits<char>,std::allocator<char>>::operator =(std::nullptr_t)'
C:\Temp\REPRO\STL\out\build\x64\out\inc\xstring(2894): note: or       'std::basic_string<char,std::char_traits<char>,std::allocator<char>> &std::basic_string<char,std::char_traits<char>,std::allocator<char>>::operator =(std::basic_string<char,std::char_traits<char>,std::allocator<char>> &&) noexcept'
sol2\include\sol/tie.hpp(62): note: while trying to match the argument list '(std::basic_string<char,std::char_traits<char>,std::allocator<char>>, sol::stack_proxy)'
sol2\include\sol/tie.hpp(53): note: see reference to function template instantiation 'void sol::tie_t<int,std::basic_string<char,std::char_traits<char>,std::allocator<char>>>::set_extra<0,1,_Ty>(std::true_type,std::integer_sequence<size_t,0,1>,T &&)' being compiled
        with
        [
            _Ty=sol::protected_function_result,
            T=sol::protected_function_result
        ]
sol2\include\sol/tie.hpp(58): note: see reference to function template instantiation 'void sol::tie_t<int,std::basic_string<char,std::char_traits<char>,std::allocator<char>>>::set_extra<0,1,_Ty>(std::true_type,std::integer_sequence<size_t,0,1>,T &&)' being compiled
        with
        [
            _Ty=sol::protected_function_result,
            T=sol::protected_function_result
        ]
sol2\include\sol/tie.hpp(77): note: see reference to function template instantiation 'void sol::tie_t<int,std::basic_string<char,std::char_traits<char>,std::allocator<char>>>::set<_Ty>(std::true_type,T &&)' being compiled
        with
        [
            _Ty=sol::protected_function_result,
            T=sol::protected_function_result
        ]
sol2\include\sol/tie.hpp(79): note: see reference to function template instantiation 'void sol::tie_t<int,std::basic_string<char,std::char_traits<char>,std::allocator<char>>>::set<_Ty>(std::true_type,T &&)' being compiled
        with
        [
            _Ty=sol::protected_function_result,
            T=sol::protected_function_result
        ]
sol2\examples\source\multi_results.cpp(28): note: see reference to function template instantiation 'sol::tie_t<int,std::basic_string<char,std::char_traits<char>,std::allocator<char>>> &sol::tie_t<int,std::basic_string<char,std::char_traits<char>,std::allocator<char>>>::operator =<sol::protected_function_result>(T &&)' being compiled
        with
        [
            T=sol::protected_function_result
        ]
sol2\examples\source\multi_results.cpp(28): note: see reference to function template instantiation 'sol::tie_t<int,std::basic_string<char,std::char_traits<char>,std::allocator<char>>> &sol::tie_t<int,std::basic_string<char,std::char_traits<char>,std::allocator<char>>>::operator =<sol::protected_function_result>(T &&)' being compiled
        with
        [
            T=sol::protected_function_result
        ]

C:\Temp\REPRO>clang-cl /std:c++17                    /EHsc /nologo /W4 /MT /Od /Ilua-5.4.3\src /Isol2\include /c sol2\examples\source\multi_results.cpp

C:\Temp\REPRO>clang-cl /std:c++latest /D_HAS_CXX23=1 /EHsc /nologo /W4 /MT /Od /Ilua-5.4.3\src /Isol2\include /c sol2\examples\source\multi_results.cpp
In file included from sol2\examples\source\multi_results.cpp:2:
In file included from sol2\include\sol/sol.hpp:52:
In file included from sol2\include\sol/stack.hpp:28:
In file included from sol2\include\sol/stack_core.hpp:34:
sol2\include\sol/tie.hpp(64,68): error: use of overloaded operator '=' is ambiguous (with operand types
      'std::basic_string<char, std::char_traits<char>, std::allocator<char>>' and 'sol::stack_proxy')
  ...(void)detail::swallow { 0, (get<I>(static_cast<base_t&>(*this)) = get<I>(types<Tn...>(), target), 0)..., 0 };
                                 ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
sol2\include\sol/tie.hpp(58,4): note: in instantiation of function template specialization 'sol::tie_t<int,
      std::basic_string<char, std::char_traits<char>, std::allocator<char>>>::set_extra<0, 1,
      sol::protected_function_result>' requested here
                        set_extra(detail::is_speshul<meta::unqualified_t<T>>(), indices(), std::forward<T>(target));
                        ^
sol2\include\sol/tie.hpp(79,4): note: in instantiation of function template specialization 'sol::tie_t<int,
      std::basic_string<char, std::char_traits<char>, std::allocator<char>>>::set<sol::protected_function_result>'
      requested here
                        set(tieable(), std::forward<T>(value));
                        ^
sol2\examples\source\multi_results.cpp(28,26): note: in instantiation of function template specialization
      'sol::tie_t<int, std::basic_string<char, std::char_traits<char>,
      std::allocator<char>>>::operator=<sol::protected_function_result>' requested here
        sol::tie(first, second) = multi();
                                ^
C:\Temp\REPRO\STL\out\build\x64\out\inc\xstring(2894,42): note: candidate function
    _CONSTEXPR20_CONTAINER basic_string& operator=(basic_string&& _Right) noexcept(
                                         ^
C:\Temp\REPRO\STL\out\build\x64\out\inc\xstring(3122,42): note: candidate function
    _CONSTEXPR20_CONTAINER basic_string& operator=(const basic_string& _Right) {
                                         ^
C:\Temp\REPRO\STL\out\build\x64\out\inc\xstring(3142,19): note: candidate function has been explicitly deleted
    basic_string& operator=(nullptr_t) = delete;
                  ^
1 error generated.

C:\Temp\REPRO>pushd sol2

C:\Temp\REPRO\sol2>git checkout cxx23
Switched to a new branch 'cxx23'
Branch 'cxx23' set up to track remote branch 'cxx23' from 'origin'.

C:\Temp\REPRO\sol2>popd

C:\Temp\REPRO>cl /std:c++17                          /EHsc /nologo /W4 /MT /Od /Ilua-5.4.3\src /Isol2\include /c sol2\examples\source\multi_results.cpp
multi_results.cpp

C:\Temp\REPRO>cl /std:c++latest                      /EHsc /nologo /W4 /MT /Od /Ilua-5.4.3\src /Isol2\include /c sol2\examples\source\multi_results.cpp
multi_results.cpp

C:\Temp\REPRO>clang-cl /std:c++17                    /EHsc /nologo /W4 /MT /Od /Ilua-5.4.3\src /Isol2\include /c sol2\examples\source\multi_results.cpp

C:\Temp\REPRO>clang-cl /std:c++latest /D_HAS_CXX23=1 /EHsc /nologo /W4 /MT /Od /Ilua-5.4.3\src /Isol2\include /c sol2\examples\source\multi_results.cpp

C:\Temp\REPRO>

Nice, I'm glad this paper made it. Thanks for the PR!


Fixed potential memory leak in grib splitting.

When we open a grib locally, we currently do not use a context manager to open it. This means that close() is never called on the open grib data, which would thus leak memory.
In addition to this fix, I've refactored a bit of pipeline code to use less variables.

CC: @mahrsee1997 @deepgabani8 Hey! Check out 7ea07dc – I think this pattern of closing an XArray dataset in a context manager could be useful to you two (from what we discussed about this morning).


Degrading quality of icons on iPad 4

When using Iconbundles to create my theme I noticed that the icons looked blurry and not as crisp as the actual exported files looked. So to see if it was just how the iPad renders them I tried theming through the standard method and saw that the icon was as sharp as it should be. What I want to know is has anyone had this issue and if its a bug with Iconbundles.
Comparison Picture: http://i.imgur.com/aQtcHFM.png[1]
Another bit of information that I have on this issue is I noticed that my icon didn't theme with the extension ~ipad@2x for retina, instead it only themed when using the non-retina ~ipad. So maybe there is a bug with Iconbundles down-sampling the icon thinking it is a non-retina device.

This happens to me too. iPod 5. iOS 8.1.2
Did you ever find a fix?


Big updates

The PR finishes, finally

Huge pull request. Will take me a while to review. Thanks!


[gitconfig] Error when including "~" into /etc/gitconfig

Hello,
I have the following line in /etc/gitconfig
$ cat /etc/gitconfig
...
[include]
        path = ~/.gitconfig
...

Leading to the following error:
DEBU[0001] Evaluated 2 locals (remaining 0): xxxxxxxx  prefix=[/home/repo/XXXXXXX]
DEBU[0001] Found locals block: evaluating the expressions.  prefix=[/home/repo/XXXXXXXXXXX]
DEBU[0001] Evaluated 5 locals (remaining 0): xxxxxxxx  prefix=[/home/repo/XXXXXXX]
DEBU[0001] Evaluated 3 locals (remaining 1): xxxxxxxx
DEBU[0001] Evaluated 1 locals (remaining 0): xxxxxxxx
DEBU[0001] git show-toplevel result:

error: could not expand include path '~/.gitconfig'
fatal: bad config line 28 in file /etc/gitconfig

ERRO[0001] /home/repo/XXX/terragrunt.hcl:27,20-34: Error in function call; Call to function "get_repo_root" failed: exit status 128., and 1 other diagnostic(s)
ERRO[0001] Unable to determine underlying exit code, so Terragrunt will exit with error code 1

Here are the version I am using:
$ terragrunt -v
terragrunt version v0.36.8
$ terraform  -v
Terraform v1.1.9
on linux_amd64
+ provider registry.terraform.io/hashicorp/aws v4.4.0
+ provider registry.terraform.io/hashicorp/random v3.1.2

Here is the compliance to ~ for gitconfig

Hi,
looks like a bug
if in the same directory will be executed:
git rev-parse --show-toplevel

it will work fine?

Yeap not issue there.
$ git rev-parse --show-toplevel
/home/repo/XXXXXXX

Try to use v0.36.9 or later if will available, it has a fix on passing env variables to git invocation
https://github.com/gruntwork-io/terragrunt/releases/tag/v0.36.9

Hello,
It seems to be fixed.
Thanks for the heads up.
Kind regards,
JM

Just for anyone having similar issues with Atlantis (We deployed with https://github.com/terraform-aws-modules/terraform-aws-atlantis):
fatal: detected dubious ownership in repository at '/home/atlantis/.atlantis/repos/company/terraform/101/default'
To add an exception for this directory, call:

	git config --global --add safe.directory /home/atlantis/.atlantis/repos/company/terraform/101/default

time=2022-11-25T11:58:43Z level=error msg=Error: Error in function call

time=2022-11-25T11:58:43Z level=error msg=  on /home/atlantis/.atlantis/repos/company/terraform/101/default/provider/aws/aws.hcl line 41, in locals:

time=2022-11-25T11:58:43Z level=error msg=  41:     "Config file"    = "${get_path_from_repo_root()}/terragrunt.hcl"

time=2022-11-25T11:58:43Z level=error msg=

time=2022-11-25T11:58:43Z level=error msg=Call to function "get_path_from_repo_root" failed: exit status 128.

Just for anyone having similar issues with Atlantis (We deployed with https://github.com/terraform-aws-modules/terraform-aws-atlantis):
fatal: detected dubious ownership in repository at '/home/atlantis/.atlantis/repos/company/terraform/101/default'
To add an exception for this directory, call:

	git config --global --add safe.directory /home/atlantis/.atlantis/repos/company/terraform/101/default

time=2022-11-25T11:58:43Z level=error msg=Error: Error in function call

time=2022-11-25T11:58:43Z level=error msg=  on /home/atlantis/.atlantis/repos/company/terraform/101/default/provider/aws/aws.hcl line 41, in locals:

time=2022-11-25T11:58:43Z level=error msg=  41:     "Config file"    = "${get_path_from_repo_root()}/terragrunt.hcl"

time=2022-11-25T11:58:43Z level=error msg=

time=2022-11-25T11:58:43Z level=error msg=Call to function "get_path_from_repo_root" failed: exit status 128.

did you manage to fix the above @amontalban

@roberc7 I added this command in my Atlantis workflow before running terragrunt:
git config --global --add safe.directory '*'

Just for anyone having similar issues with Atlantis (We deployed with https://github.com/terraform-aws-modules/terraform-aws-atlantis):
fatal: detected dubious ownership in repository at '/home/atlantis/.atlantis/repos/company/terraform/101/default'
To add an exception for this directory, call:

	git config --global --add safe.directory /home/atlantis/.atlantis/repos/company/terraform/101/default

time=2022-11-25T11:58:43Z level=error msg=Error: Error in function call

time=2022-11-25T11:58:43Z level=error msg=  on /home/atlantis/.atlantis/repos/company/terraform/101/default/provider/aws/aws.hcl line 41, in locals:

time=2022-11-25T11:58:43Z level=error msg=  41:     "Config file"    = "${get_path_from_repo_root()}/terragrunt.hcl"

time=2022-11-25T11:58:43Z level=error msg=

time=2022-11-25T11:58:43Z level=error msg=Call to function "get_path_from_repo_root" failed: exit status 128.

how did you resolve the get_path_from_repo_root function error?

I ended up doing this: https://github.com/runatlantis/atlantis/issues/2221#issuecomment-1155231919


add a variant annotation example

Possible annotations:

allele frequency
allele fraction
vcf stats
clinvar annotations
esp annotations (with dedupe)

Done. See DemoApp with a demo of adding haplotype frequencies and pharmgkb annotations.

Done. See DemoApp with a demo of adding haplotype frequencies and pharmgkb annotations.


Add performance tests

Feature request
We need to extend https://github.com/OpenAdaptAI/OpenAdapt/issues/314 to include some useful tests and generate an automated report.
This involves:

Create recordings of three tasks:

Open a calculator and perform a short calculation
Open a spreadsheet (e.g. https://github.com/OpenAdaptAI/OpenAdapt/pull/702/files#diff-f1c1e3c2360bde1f343427e1f219851ec9d6184c83a0359fd8ef073d62358aa6), open a time tracking app (e.g. https://clockify.me), copy a week's worth of data from the spreadsheet into the app, and save/submit the data in the app.
Open powerpoint and create a short presentation.

Save them as fixtures
Add automated tests to run a replay (with configurable strategy, defaulting to VanillaReplayStrategy) and evaluate the outcome. Outcome evaluation can be implemented with WindowEvent data.
Add a script to log the outcome results to stdout and/or to a file.

Motivation
Scientific rigor and reproducibility.

@seanmcguire12 your assistance would be greatly appreciated!

@KrishPatel13 outcome evaluation for web apps will depend on finishing https://github.com/OpenAdaptAI/OpenAdapt/pull/364


uTorrent is missing from the manifest repository

Description of the new feature/enhancement

Proposed technical implementation details (optional)

Cannot be included as their installer executable needs to be unzipped and according to the manifest spec, winget-cli currently does not support the zip InstallerType (depends on https://github.com/microsoft/winget-cli/issues/140).

@denelon can you label as Blocking-Issue? Thanks!

https://github.com/microsoft/winget-cli/issues/140

There isn't enough information here to go off of; Since this issue is so old, can you please submit a new Package Request so we can better track exactly which package you're looking for?


feature/AP-96  Added dockerfile to build containers.

Added instructions to readme

I've resolved both mine and @adrianclay's comments as @a5rar isn't available.
I also pushed one other unrelated README change in 3232e37 after I noticed that we seemed to have two headings and introductions (possibly the result of a merge that I missed in #2 )


Fix misaligned text on Workspace Card Page

Details

Changes the styling used in our button text so that it's aligned in all platforms.
Fixed Issues

$ https://github.com/Expensify/App/issues/4338
Tests

Open one of your workspaces
The Manage Cards text should be correctly centered inside the button.

QA Steps

Tested On

[x] Web
[x] Mobile Web
[x] Desktop
[x] iOS
[x] Android

Screenshots

Web

Mobile Web

Desktop

iOS

iOS - iPad

Android

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

🚀 Deployed to staging         in version: 1.0.82-8🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to production by @francoisl in version: 1.0.83-1 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
failure ❌

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


Correct calculation of size of calculated_stats_ vector

In #453 I introduced the calculated_factors_ vector to store the calculated stats for each bin for each factor the user wants to calculate stats for. The size of this vector is calculated and set in initialise_vector method, but initially I only allowed one "channel" per factor. This PR fixes this by including the other "channels" in the vector resize calculation, namely those specified in the already-existing initialise_output_channels method:
https://github.com/imperialCHEPI/healthgps/blob/46677a62b0f66b650fb57edae14ca2a8688d5ca6/src/HealthGPS/analysis_module.cpp#L530-L559
I have also renamed the vector to calculated_stats_ as it seems more appropriate.

So I did some bits, but then realised that all I was doing was simple duplicating what the initialise_output_channels method was doing with the channels_ vector, so I have decided to just reuse that. @alexdewar you might want to take another look because this changes the changes in the PR a bit.


[BUG] - Dropdown Error

NextUI Version
2.6.4
Describe the bug
I got this error after upgrading to latest version, and it work in previous version
chunk-GZD7INZN.js?v=6411179e:521 Warning: Function components cannot be given refs. Attempts to access this ref will fail. Did you mean to use React.forwardRef()?
Check the render method of NextUI.DropdownTrigger.
at PopoverTrigger (http://localhost:5173/node_modules/.vite/deps/@nextui-org_react.js?v=cb94c851:53307:43)
at DropdownTrigger (http://localhost:5173/node_modules/.vite/deps/@nextui-org_react.js?v=cb94c851:57690:35)
at http://localhost:5173/node_modules/.vite/deps/@nextui-org_react.js?v=cb94c851:53335:11
at Dropdown (
Your Example Website or App
No response
Steps to Reproduce the Bug or Issue

Create component with dropdown

<Dropdown>           <DropdownTrigger>               <div>                   <Button variant="bordered">Open Menu</Button>               </div>           </DropdownTrigger>           <DropdownMenu aria-label="Static Actions">               <DropdownItem key="new">New file</DropdownItem>               <DropdownItem key="copy">Copy link</DropdownItem>               <DropdownItem key="edit">Edit file</DropdownItem>               <DropdownItem                   key="delete"                   className="text-danger"                   color="danger"               >                   Delete file               </DropdownItem>           </DropdownMenu>       </Dropdown>
Expected behavior
Fix
Screenshots or Videos
chunk-GZD7INZN.js?v=6411179e:521 Warning: Function components cannot be given refs. Attempts to access this ref will fail. Did you mean to use React.forwardRef()?
Check the render method of NextUI.DropdownTrigger.
at PopoverTrigger (http://localhost:5173/node_modules/.vite/deps/@nextui-org_react.js?v=cb94c851:53307:43)
at DropdownTrigger (http://localhost:5173/node_modules/.vite/deps/@nextui-org_react.js?v=cb94c851:57690:35)
at http://localhost:5173/node_modules/.vite/deps/@nextui-org_react.js?v=cb94c851:53335:11
at Dropdown (
Operating System Version
Mac OS
Browser
Chrome

https://github.com/nextui-org/nextui/issues/4245

Duplicate - lets' track in above one.


[SPARK-10422] [SQL] String column in InMemoryColumnarCache needs to override clone method

https://issues.apache.org/jira/browse/SPARK-10422

Merged build triggered.

Merged build started.

Test build #41944 has started for   PR 8578 at commit 1469cb0.

:+1:

Test build #41944 has finished for   PR 8578 at commit 1469cb0.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/41944/
Test FAILed.

Test build #1715 has started for   PR 8578 at commit 1469cb0.

Merged build triggered.

Merged build started.

Test build #41952 has started for   PR 8578 at commit 2905fd5.

Test build #1715 has finished for   PR 8578 at commit 1469cb0.

This patch fails PySpark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Test build #1716 has started for   PR 8578 at commit 2905fd5.

Test build #41952 has finished for   PR 8578 at commit 2905fd5.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/41952/
Test PASSed.

Test build #1716 has finished for   PR 8578 at commit 2905fd5.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

LGTM, merging this into master 1.5


adjust test controller for job input

Add JOB as new input to get the output based on workflow run 'api-test' or 'ui-test'

@alephnull I have made my changes here, please review so I can proceed with template modifications

@alephnull, @asutosh  could you review and approve so we get this merged?


SVG template broken in firefox

See here: https://github.com/Polymer/polymer/issues/1976

Also broken in Safari

Fixed in 1.0.2


Describe relationship to DistKV

Could you please describe the relationship between DistMQTT and DistKV?

Is DistKV required to use DistMQTT?
What features does DistKV add to this project or MQTT in general?
Why did you make the decision to couple a DistKV client and MQTT client together?

I'm asking because while I generally like the idea of anyio hbmqtt library, I don't think I need DistKV for my project.

No. You can safely ignore it and I'll modify things to support that better soon(ish).
Distributed master-less persistence, and support for server-side data translation. (MQTT wants "ON" and "OFF" or whatever, while when you use DistKV you can just use Python data types directly.)
I didn't; the MQTT server acts as a DistKV client / gateway.


put() got an unexpected keyword argument 'overwrite' in django_orm.Storage

The argument overwrite is not present in the parent's class method, thus throwing an error.

Triaging.
This bug appears to be misfiled.  There is nothing that implements or uses anything named django_orm.Storage in the client library.

There is a DjangoOrmStorage class in oauth2client which might be related.

Greetings!  This issue is getting pretty old :)  If this is still an issue... please do let us know!


⚠ Bofrost.at has degraded performance

In bbd9ac9, Bofrost.at (https://www.bofrost.at) experienced degraded performance:

HTTP code: 200
Response time: 1713 ms

Resolved: Bofrost.at performance has improved in 5d10cb1.


--max-wait

The asciinema play command has a --max-wait option that is very helpful.  Could this be implemented in the web player without too much trouble?

Yes. In fact version 1.x of the player supported this but it got lost during the 2.0 rewrite.
I'll see what we can do here 😎

It has been implemented in 1cc8c35ded38c04749534c6bdd3d4e8e6e4634b2. Will be released in the next version of the player.

Groovy!


Consider moving return value witnesses directly after the inputs so function signature fully defines ABI

We recently moved to a situation where we always generate distinct witnesses for all of the return values (#4914). This means that we can know exactly how many witnesses will be needed for the return values before performing acir gen.
This then raises the potential for just reserving these witness indices so that instea of [...program inputs, ...intermediate witnesses, ...program return values] the witnesses are laid out as [...program inputs, ...program return values, ...intermediate witnesses].
The result of this is that ABI encoding/decoding of arguments/return values will be entirely defined by the function signature and independent of the rest of the circuit. This will allow us to have a foundry cast like tool for ABI encoding/decoding witnesses.

This will make it so param_witnesses and return_witnesses are not needed anymore right? since they can be completely derived from the types


make spotlight search safer for bad inputs

@Sarkar @aaustin

This whole thing looks excessive. What are the use cases for people passing in specifically bad typed values into a method with explicit types?

:+1:

I agree that this is excessive. I don't see any real value-add here. I'm going to close this for now.


trunk-ng: 0.17.11 -> 0.17.16

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://github.com/ctron/trunk/releases.
meta.description for trunk-ng is: Build, bundle & ship your Rust WASM application to the web
meta.homepage for trunk-ng is: https://github.com/ctron/trunk
Updates performed

Rust version update

To inspect upstream changes

Release on GitHub

Compare changes on GitHub

Impact
Checks done

built on NixOS
The tests defined in passthru.tests, if any, passed
found 0.17.16 with grep in /nix/store/3y2vldfyzpy1rfagsb0p5zvpbcp05bdm-trunk-ng-0.17.16
found 0.17.16 in filename of file in /nix/store/3y2vldfyzpy1rfagsb0p5zvpbcp05bdm-trunk-ng-0.17.16

Rebuild report (if merged into master) (click to expand)

1 total rebuild path(s)

1 package rebuild(s)

First fifty rebuilds by attrpath
trunk-ng

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/3y2vldfyzpy1rfagsb0p5zvpbcp05bdm-trunk-ng-0.17.16 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A trunk-ng https://github.com/r-ryantm/nixpkgs/archive/e0b94c5e7919a0734984377c14ad370fbad65340.tar.gz

Or:
nix build github:r-ryantm/nixpkgs/e0b94c5e7919a0734984377c14ad370fbad65340#trunk-ng

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/3y2vldfyzpy1rfagsb0p5zvpbcp05bdm-trunk-ng-0.17.16
ls -la /nix/store/3y2vldfyzpy1rfagsb0p5zvpbcp05bdm-trunk-ng-0.17.16/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

1 package built:

trunk-ng

Maintainer pings
cc @ctron for testing.

Result of nixpkgs-review pr 276488 run on aarch64-darwin 1

1 package failed to build:

trunk-ng

What about this: https://github.com/NixOS/nixpkgs/pull/276488/commits/b3baac408918462b96b9f6f83f37501a7ef00db4?

Result of nixpkgs-review pr 276488 run on aarch64-darwin 1

1 package built:

trunk-ng

Works for me, thanks @wegank!

This is of course possible. However, a greater concern of this PR is that it does not build on ofborg due to hash mismatch on darwin, which is a regression. I suspect there's a case-sensitivity issue, but I haven't looked into it yet.

That's odd. The hash starting with sha256-AivISmT looks familiar to me and I might've come across it while building trunk-ng locally on my machine.
Curious about what you find in regards to the ofborg failure.

@wegank when building trunk-ng locally from master on aarch64-darwin I now get a hash mismatch, the hash I get is the same as the linux one. What could be going (wr)on(g) here?
What could be the reasons for the cargoHash to differ on the platforms?
error: hash mismatch in fixed-output derivation '/nix/store/9z7gdhxxi1zhih0mz924sakwacqzkfk0-trunk-ng-0.17.16-vendor.tar.gz.drv':
         specified: sha256-TwpGw3LH3TmZSbC4DkoOYpQdOpksXXoAoiacyZAefTU=
            got:    sha256-AivISmT/r8xa/vSXUN8sU7z67t1hcyMQM+t6oXmIOhU=

That's not the case on my side, though. I suppose you're having a case-insensitive store?

Nope /tmp is definitely case-sensitive…
% (cd /tmp; touch foo Foo; ls ?oo)
Foo foo


#390 Target Microsoft.Extensions.DependencyInjection.Abstractions ins…

…tead of implementation
Thanks for helping out :+1:
Before submitting a pull request, please have a quick read through the contribution guidelines and provide the following information, where appropriate replace the [ ] with a [X]
The issue or feature being addressed
#390
Details on the issue fix or feature implementation

Change package references from Microsoft.Extensions.DependencyInjection to Microsoft.Extensions.DependencyInjection.Abstractions

Confirm the following

[X] I have ensured that I have merged the latest changes from the dev branch
[X] I have successfully run a local build
[ ] I have included unit tests for the issue/feature - no needed
[X] I have included the github issue number in my commits

Does it need to be 2.2.0? or can it be >=2.1.0. If you reference directly to 2.2.0 than it can not be used with AspNetCore 2.1.-. Which is target for current LTS of dotnet (https://dotnet.microsoft.com/platform/support/policy/dotnet-core)

I suppose it's out of scope for this PR. At first, I suggest to replace dependency to Abstractions and then we can check using of 2.1 version. What do you think?

Sure let's keep it simple.


Fix "zero-sized fn" nightly warnings

Example:
src/signal.rs:93:70: 93:79 warning: `extern "C" fn(&core::cell::RefCell<Box<core::ops::FnMut() -> glib::source::Continue + 'static>>) -> i32 {signal::trampoline}` is now zero-sized and has to be cast to a pointer before transmuting to `core::option::Option<unsafe extern "C" fn(*mut libc::c_void) -> i32>`, #[warn(transmute_from_fn_item_types)] on by default

src/signal.rs:93         glib_ffi::g_idle_add_full(glib_ffi::G_PRIORITY_DEFAULT_IDLE, transmute(trampoline),

                                                                                ^~~~~~~~~

src/signal.rs:93:70: 93:79 warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release!

src/signal.rs:93:70: 93:79 note: for more information, see issue #19925 <https://github.com/rust-lang/rust/issues/19925>

We should make our extern fns match the expected signatures to make transmutes unnecessary.

Can't we just cast as *mut c_void? It would do the same after all.

Transmuting fn is too fragile anyway. More error-prone than transmuting or casting individual arguments.

Um, well, speaking of signals there may not be actual signatures to adhere to. I'm not sure now. So this issue needs some investigation.

https://github.com/rust-lang/rust/issues/19925 stated that we can do even transmute(size_changed_trampoline as usize).
As for @gkoz concern about transmuting individual arguments IMHO it not applied here, except for &Box<Fn> argument that really not error-prone.
May be better solution will be pass some structure with some id and function pointer that will be checked before using function but it needed some storage with unclear rule for erasing elements.
As we need transmute trampoline anyway IMHO better add cast sooner.

It looks like we'll have to use the as usize workaround for signal trampolines because there's no other choice there. Callbacks with defined types (like GtkTreeModelFilterVisibleFunc) and g_idle_add can avoid transmuting fns.

I add PR for gtk and glib then.

Also calling  g_idle_add_full and other in glib also needed casting.

Looks like all warnings are gone. Thanks @EPashkin


Small issue with serialization

Hey Daniel,
I just noticed this and while it might be by design, it tripped me up.... So, thought i would mention it.
When you have a definition like this:
{
  "type": "object",
  "properties": {
    "number": {
      "type": "number"
    },
    "string": {
      "type": "string"
    },
    "bool": {
      "type": "boolean"
    }
  }
}

If you generate the form and without updating the form in any way - submit the object, the resulting object looks like this:
{
"number" : "",
"string: "",
"bool" : false
}

The bool defaulted correctly(?) to the false value. The string defaulted to an empty string. The number is the odd one - it evaluated to an empty string.
This means that if you have server side code that tries to parse the Json, it may fail - expecting a numeric value there.
It seems like the quick fix is to simply add "value":0 to the definition and the problem won't appear.
That's probably a  reasonable thing to do - but it's just sad that it works out of the box for the boolean and not for the number.
Is there some design reason for this that I can't see ?
Kind regards,
Derick

For fixing this bug: https://github.com/ncform/ncform/issues/150

Thanks Daniel. Yeah, that's how I got around it too.  The workaround works perfectly.


Cannot connect postersql

can you provide with JDBC Driver version and JDBC URL? so we can repeat the issue.
please follow the issue format, like one issue example

Good evening,
Thanks for email, sorry for my wrong format.
Form the detail, it says 'Please report this exception', I thought that posted is 'report'.
Kind regards,
Sybil[cid:83440a62-f2a4-407f-acb7-0d9659a75cbf]

From: tox_at_fishing<EMAIL_ADDRESS>Sent: Thursday, 4 March 2021 19:25
To: dbeaver/dbeaver<EMAIL_ADDRESS>Cc: Sybil997<EMAIL_ADDRESS>Author<EMAIL_ADDRESS>Subject: Re: [dbeaver/dbeaver] Cannot connect postersql (#11592)
can you provide with JDBC Driver version and JDBC URL? so we can repeat the issue.
please follow the issue format, like one issue examplehttps://github.com/dbeaver/dbeaver/issues/11577
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://github.com/dbeaver/dbeaver/issues/11592#issuecomment-790466923, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ATCQJT7D2R6T6NWTYDN2WZ3TB5GYRANCNFSM4YSO6IPA.

Hey guys,
I'm a new one to use it, after installing, I am experiencing one connect issues when creating connection.

After I press test connection it shown that

What Postgresql version do you use?

PostgreSQL 13

@Sybil997 is there something in the logs?

@Sybil997 please, provide an error stacktrace https://github.com/dbeaver/dbeaver/wiki/Log-files

there is no update on the issue for a long time.
If it is still actual for you - feel free to reopen it with an additional info


Add Proxy support. Fixes #25

Looks good. Has it been tested?

Not yet. @zxjinn, mind testing this?

I don't believe I'll have time for at least a few weeks now. See if you can find another guinea 🐷 , otherwise I can do it later.

@basepi Okay, I just tested it. Seems like it works. 👍


(WIP) Additional Isolated Servers support

If we want to support an agent registering itself with multiple separate instances of server, we need to define all the information for each server instance/cluster.
My suggestion is that we add an array property where users can define this data for each additional server they want to register. This can be passed into the Kubernetes tentacle environment variable as a JSON blob which is pulled apart by the configure script and multiple calls to register-k8s-cluster can be made.

Closing as out of scope.


Is this repo active?

I have to do a lot of client side image manipulations. Is this library still active and can it be used in production? Are there any recent alternatives?

The current master branch is unlikely to change for awhile, but I have been trying to find time to work on the more experimental cleanup branch, which contains a lot of backwards incompatible changes. I'm also exploring implementing WebWorkers again since the last time I implemented them, browsers didn't support cool stuff like transferring data ownership or passing UInt8Arrays without serialization (it was strings only).
The current master branch is suitable for production use.


istio gateway reference document error

(NOTE: This is used to report product bugs:
To report a security vulnerability, please visit https://istio.io/about/security-vulnerabilities
To ask questions about how to use Istio, please visit https://discuss.istio.io)
Bug description

[x] Docs
[ ] Installation
[ ] Networking
[ ] Performance and Scalability
[ ] Extensions and Telemetry
[ ] Security
[ ] Test and Release
[ ] User Experience
[ ] Developer Infrastructure
[ ] Upgrade

I believe the change needed here is in https://github.com/istio/api/blob/master/networking/v1alpha3/gateway.proto#L264. Once it's changed there, the make gen will update the gateway.pb.html and the nightly istio.io job will pull the change.

https://github.com/istio/api/pull/1877

@ericvn I have done it already, the test result showed that it needs a release notes. And I had submit the pr with it.
https://github.com/istio/istio/pull/30729/files


Unable to Provide ASPA Objects via RTR

I attempted to provide the validation results of rpki-client via RTR (Version 2) to OpenBGPD, using two Ubuntu 22.04 machines (Ubuntu_A and Ubuntu_B) deployed in a virtual environment. While I was able to provide ROA objects, I could not provide ASPA objects.
【Environment】
Ubuntu_A (<IP_ADDRESS>): rpki-client 8.6 and Stayrtr v0.5.1 (compatible with RTRv2)
Ubuntu_B (<IP_ADDRESS>): OpenBGPD 8.3
I executed the rpki-client and generated a JSON file, which was then specified as a cache file to run Stayrtr, using the following command:
stayrtr -protocol 2 -cache /usr/local/var/db/rpki-client/json &
In the OpenBGPD config (bgpd.conf), I wrote the following. Currently, I am testing the provision of validation results via RTR, so I haven't written settings for include (include "/usr/local/var/db/rpki-client/openbgpd") or neighbors, which are generated by the rpki-client.
ASN="65001"
AS $ASN

router-id <IP_ADDRESS>

prefix-set mynetworks {
    <IP_ADDRESS>/24
}

network prefix-set mynetworks set large-community $ASN:1:1

allow to ebgp
allow from ebgp

rtr <IP_ADDRESS> {
        descr Ubuntu_A
        port 8282
}

When checking the state of the RTR session with "bgpctl show rtr," the output seems to be fine.
bgpctl show rtr

RTR neighbor is <IP_ADDRESS>, port 8282
 Description: Ubuntu_A
 Session ID: 42450 Serial #: 1
 Refresh: 3600, Retry: 600, Expire: 7200

  RTR RefreshTimer     due in 00:58:33
  RTR ExpireTimer      due in 01:58:33

When checking the state of each object with "bgpctl show sets," it is confirmed that ROA objects are being provided correctly via RTR, but the ASPA objects are listed as "Never," indicating they are not being provided.
bgpctl show sets
Type   Name                                 #IPv4   #IPv6 #ASnum Last Change
ROA    RPKI ROA                            293275   70582      -    00:09:41
ASPA   RPKI ASPA                                -       -      0       Never
PREFIX mynetworks                               1       0      -    00:14:12

The Stayrtr v0.5.1 I used is compatible with RTRv2 communication, and OpenBGPD has been compatible since version 7.8, as stated in the release notes.
"Add ASPA support for the RTR protocol based on draft-ietf-sidrops-8210bis-10"
Why can't ASPA objects be provided via RTR?

ASPA is currently in a state of flux. The RTR bits are based on a draft that is not compatible with the ASPA profile and verification drafts. Right now I can only suggest to not use ASPA until these issues are resolved at SIDROPS.
I fear that stayrtr is not correctly reading the data from rpki-client and so does not send any ASPA PDUs but that is me guessing.

I can confirm that the problem is in stayrtr and OpenBGPD is working fine.
See https://github.com/bgp/stayrtr/pull/105 for a possible fix.

Thank you for the quick fix.
By running Stayrtr on your modified source code, you can now serve ASPA objects to OpenBGPD via RTR.
bgpctl show sets
Type   Name                                 #IPv4   #IPv6 #ASnum Last Change
ROA    RPKI ROA                            240955   56649      -    00:08:52
ASPA   RPKI ASPA                                -       -     25    00:28:57
PREFIX mynetworks                               1       0      -    16:29:04

Thank you for fixing the bug.


add intuit_account support to command-line options

#252 added support for this in the code via Python, but we should have a command-line option and updated README :)

@jasonkissinger Is the intuit_account functionality that this issue relates to actually working?  I started working on implementing the command-line option and it appears that we hang in a try\except loop.  If you are able to successfully use this functionality, I'll keep pushing through to see what I'm doing wrong.  Otherwise, I'll explore a bug fix in conjunction.

It worked a few months ago but I've abandoned the project which uses it so
haven't tried in awhile.  I've noticed that the login UI has changed
recently so I wouldn't doubt it no longer works.
On Sun, Dec 12, 2021, 9:48 AM Matthew Burke @.***>
wrote:

@jasonkissinger https://github.com/jasonkissinger Is the intuit_account
functionality that this issue relates to actually working? I started
working on implementing the command-line option and it appears that we hang
in a try\except loop. If you are able to successfully use this
functionality, I'll keep pushing through to see what I'm doing wrong.
Otherwise, I'll explore a bug fix in conjunction.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/mintapi/mintapi/issues/314#issuecomment-991921432,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABVK4FZSPUY27OVKPIBHVMLUQS75JANCNFSM5GAETVRA
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

@jasonkissinger got it, thanks for the update!


Remove target_os 'bitrig' in fuser which is unsupported by Rust

Description of change
Our fuser fork emits a lot of warnings during builds, impacting our pull requests. This change addresses the use of undeclared target operating systems.
Bitrig is no longer developed and most changes were contributed back to its upstream OpenBSD. Bitrig support was removed from Rust in 2019 (https://github.com/rust-lang/rust/pull/60775). This change removes the conditions from Fuser, who's MSRV is 1.74.
This change is a good candidate to be contributed to upstream (https://github.com/cberner/fuser/pull/312). Once contributed, this commit can be removed.
Does this change impact existing behavior?
bitrig will no longer be a supported operating system for fuser (though its unlikely it worked, given MSRV of 1.74).

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and I agree to the terms of the Developer Certificate of Origin (DCO).

This change was contributed upstream. Let's pick it up next time we update the fork. https://github.com/cberner/fuser/commit/f69c8385ad1cb36d06f7b31b84d251ca398277b7

Actually, let's just close this and rebase from the fork soon.


TS-4972: Configure collapsed_forwarding plugin as global or remap.

Add the ability to configure collapsed_forwarding plugin globally.  Original version can only be configured per remap.
Also cleaned up a memory leak in the event of failed transaction.

FreeBSD build successful! See https://ci.trafficserver.apache.org/job/Github-FreeBSD/1011/ for details.

Linux build successful! See https://ci.trafficserver.apache.org/job/Github-Linux/903/ for details.

Seems fine.

FreeBSD build successful! See https://ci.trafficserver.apache.org/job/Github-FreeBSD/1014/ for details.

Linux build successful! See https://ci.trafficserver.apache.org/job/Github-Linux/906/ for details.


Installing pytc on Windows - Printing error for unable to find pyqt5 on install, but gui still able to run

When running setup.py install on Windows, this throws an error - "Could not find suitable distribution for Requirement.parse". However, there is a folder for PyQt5 which installs with the latest version of Anaconda. The Gui loads and seems to be able to run fine when I execute the gui_main.py script.

Fixed!


Add magic touch x never gonna give you up (PILLife) by  Romos, Rick Asley

Song Name
magic touch x never gonna give you up (PILLife)
Artist Name
Romos, Rick Asley
Source
Youtube
Youtube Link
Sdh_AVYAV1c
Direct File Link
No response
Song ID
595342
Start Offset [ms]
500
Extra
Created from Auto Nong.
Created for level: 11849346

accept


test: optimize test case

Coverage increased (+10.6%) to 72.565% when pulling 0c9137372022e4c5e3252a2b38b101726e26f66f on edison-hm:dev into be2178facf6c3b38e9d2c7dc8a8c6208bc6c0039 on ZhonganTechENG:dev.


Can't filter dashboards from newly created label

On the dashboards index page, add a new label to a dashboard
Click that label in the dashboard card

The following error will be thrown in the console:
Uncaught TypeError: Cannot read property 'name' of undefined
    at InlineLabels._this.handleLabelClick (InlineLabels.tsx:70)
    at Label._this.handleClick (Label.tsx:85)
    at HTMLUnknownElement.callCallback (react-dom.development.js:149)
    at Object.invokeGuardedCallbackDev (react-dom.development.js:199)
    at invokeGuardedCallback (react-dom.development.js:256)
    at invokeGuardedCallbackAndCatchFirstError (react-dom.development.js:270)
    at executeDispatch (react-dom.development.js:561)
    at executeDispatchesInOrder (react-dom.development.js:583)
    at executeDispatchesAndRelease (react-dom.development.js:680)
    at executeDispatchesAndReleaseTopLevel (react-dom.development.js:688)

Looks like this may have been resolved in #12468