Match repository getting huge!

Hello
We are using fastlane match for a lot of apps, and it seems to change every certificate every time match is run, so for example the last commit match did changed 384 files, because of this the repo gains about 5mb in size each time and we just hit 1gb.
Is there anything I can do to make it only push the ones it generates rather than the whole lot? Or is this to do with how the encryption works?
The only flag we are using is shallow_clone
Environment
🚫 fastlane environment 🚫
Stack

Key
Value

OS
10.12.4

Ruby
2.2.4

Bundler?
false

Git
git version 2.11.0 (Apple Git-81)

Installation Source
~/.fastlane/bin/bundle/bin/fastlane

Host
Mac OS X 10.12.4 (16E195)

Ruby Lib Dir
~/.fastlane/bin/bundle/lib

OpenSSL Version
OpenSSL 1.0.2g  1 Mar 2016

Is contained
false

Is homebrew
true

Is installed via Fabric.app
false

Xcode Path
/Applications/Xcode.app/Contents/Developer/

Xcode Version
8.3

System Locale

Variable
Value

LANG
en_US.UTF-8
✅

LC_ALL
en_US.UTF-8
✅

LANGUAGE
en_US.UTF-8
✅

fastlane files:
No Fastfile found
`./fastlane/Appfile`
app_identifier "net.xxxx.app01" # The bundle identifier of your app
apple_id "xxxxxx" # Your Apple email address
team_id "xxxx"  # Developer Portal Team ID

fastlane gems

Gem
Version
Update-Status

fastlane
2.24.0
🚫 Update available

Loaded fastlane plugins:
No plugins Loaded
Loaded gems

Gem
Version

slack-notifier
1.5.1

i18n
0.7.0

json
1.8.1

thread_safe
0.3.5

tzinfo
1.2.2

minitest
5.4.3

activesupport
<IP_ADDRESS>

CFPropertyList
2.3.5

claide
1.0.1

colored
1.2

nanaimo
0.2.3

xcodeproj
1.4.2

rouge
1.11.1

xcpretty
0.2.4

terminal-notifier
1.7.1

unicode-display_width
1.1.3

terminal-table
1.7.3

plist
3.2.0

public_suffix
2.0.5

addressable
2.5.0

multipart-post
2.0.0

word_wrap
1.0.0

tty-screen
0.5.0

babosa
1.0.2

highline
1.7.8

commander-fastlane
4.4.4

excon
0.54.0

faraday
0.11.0

unf_ext
<IP_ADDRESS>

unf
0.1.4

domain_name
0.5.20161129

http-cookie
1.0.3

faraday-cookie_jar
0.0.6

fastimage
2.0.1

gh_inspector
1.0.3

uber
0.0.15

representable
2.3.0

retriable
2.1.0

mime-types-data
3.2016.0521

mime-types
3.1

hurley
0.2

little-plugger
1.1.4

multi_json
1.12.1

logging
2.1.0

jwt
1.5.6

memoist
0.15.0

os
0.9.6

signet
0.7.3

googleauth
0.5.1

httpclient
2.8.3

google-api-client
0.9.26

mini_magick
4.5.1

multi_xml
0.6.0

rubyzip
1.2.0

security
0.1.3

xcpretty-travis-formatter
0.0.4

dotenv
2.2.0

bundler
1.14.3

faraday_middleware
<IP_ADDRESS>

generated on: 2017-04-19

Argh, that's not good. The problem is that match by default re-encrypts all certs/profiles, causing it to change on git. I'm not sure if that's something we can easily fix though

possible duplicate of https://github.com/fastlane/fastlane/issues/8793#issuecomment-292311108
as mentioned there i think introducting a new option - to bypass encryption/decryption should solve it.
with the right warning-notice i think this should solve the problems of the super-large-enterprise users 👍
@KrauseFx are you fine, with that? (i would do a PR)

hey 🙌  folks i prepared a PR: https://github.com/fastlane/fastlane/pull/8919
i would love to hear feedback from you if the propsed solution is feasible for you.

Is there any plan to fix this? It's now more than a minute to run match, our repo is only 50MB as there are 30 odd profiles in there for all our app brands, environments, notifications etc. Does it do a new clone each time? Could there just be a pull instead? Or am I misunderstanding how this works?

So yeah, it's certainly not just with 1000s of apps. There are 6 apps, some with different profiles for dev, beta, stage, test, and live. All with a notifications profile. Adds up to 30. Have seen it getting slower and slower to the point where match takes nearly 2 minutes to run. Adding a device to all of the adhoc profiles takes about 30 minutes.

@evilDave don't forget to use shallow_clone
A different approach would be to do a reset after each run of match, as the history is useless
https://stackoverflow.com/a/13102849

is there a reason why match doesn't use shallow_clone by default?

I'll give shallow clone a go.
As for resetting, wouldn't the commits still be there?
Are other people just not getting this problem? I guess I've got about 150 commits to the repo with modifying capabilities and adding devices - repo size really multiplies.

This is an issue for me too, our repo is approaching 2GB. Watching with
interest.
On 7 June 2017 at 14:26, David K Clark<EMAIL_ADDRESS>wrote:

I'll give shallow clone a go.
As for resetting, wouldn't the commits still be there?
Are other people just not getting this problem? I guess I've got about 150
commits to the repo with modifying capabilities and adding devices - repo
size really multiplies.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/fastlane/fastlane/issues/8917#issuecomment-306794000,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAO6yG9K4X-c7g8TJBj_7TpNDF2T3_3qks5sBqUagaJpZM4NB5w1
.

the problem is the encryption, as every file changes every time.
to resolve this you can:

handle with care:

clone repo to safe place
delete repo on the server
recreate empty repo
clone empty repo
remove .git from prev. cloned repo in safe place
copy over the files
git add them - commit  and push

this should shrink it.
however the problem will come back, as it grows in the future.
for really large repo's - you could upvote this: https://github.com/fastlane/fastlane/pull/8919
which adds a flag to disable encryption (🔥) - then each incremental commit is very small, as only a few files really change.

I think disabling encryption, particularly for "more enterprisey" users, seems like the wrong idea.
The more I think about this issue, the less I think git is a good tool for storing these assets. I mean I get it, we have git, we know git, let's use git. But in this case, the history is not needed, just the hosting. Some way to bypass that (and the link above, now that I've read it properly and noticed the 'git gc' in there, might work as suggested) is good but in the end maybe we are just using the wrong tool. If it does work though, another option might be to modify match to do it by default or by option.

Why exactly does match encrypt all of the certs and profiles again? Maybe that can be changed?  The cert or profile has changed and an old one won't work anyway.

--shallow_clone makes it better: 30 seconds in lieu of 1:30.
I suppose the repo is still getting huge on github but I care less about that.

I don't think we should remove encryption.
Git is for sure n't the best storage method as we are not interested in all history and it has capacity issues. But I suspect we have to stick to it for a while.
It might be possible to encrypt only what we need. But I am not sure how this can be achieved easily. Because of the history and growing repo size, it might still cause issues (not sure how in practice though). For people with 1000 of apps, for sure.
A simpler alternative is as @hjanuschka wrote earlier is to provide a way rewrite the git history. This could be risky if several git push operations are going on simultaneously. We could write a match prunehistory or even a more generic gitprunerepohistorycommand for example that could contain several safe guards to reduce that risk.
A long term solution would have been for the storage backend to be flexible. Think s3 or whatever.

We was also having an issue like this. Our repo had reached a size of 200MB and for some reason, our connection was always very slow (~200kb/s) when cloning the repo which made the cloning take around 20-30 minutes. It was a pack file within the .git folder that was causing the size to be so big. I tried many things but the following commands seem to have resolved the issue and now cloning the repository takes seconds rather than minutes.
$ git reflog expire --expire=now --all
$ git repack -ad
$ git gc --prune=now
$ git push --all --force
$ git push --tags --force
Hopefully this helps others.

Hey everyone, the new release is live, can you update and let us know if that works for you? You might want to squash/clear the history of the repo.

Hi! Someone happens to know if there is a way to clear history and mantain branches as they are (need this cause I'm using the match's branch feat)?


Proposal: put ViewModel instance on this.state instead of this.props

It has been suggested that the current setup misuses props, and that the ViewModel instance should be placed on this.state instead of this.props. That the viewModel is a dynamic (mutable) thing and is better part of state than props. Props (in react world) always represented what was on the component tag itself (passed down from above). The parent component is responsible for setting new props. The initial state of a component can be derived from props, but the props remain as they were set by the parent.
If we make this change, this.props would act as it always did in normal react, and this.state would be coopted as the ViewModel instance. The render function provided to reactViewModel would be called with 2 arguments: props and state.

Yes, using state is definitely preferred over props. Props are a component's relationship to the outside, parent or otherwise, and state is internal. I'd go as far as to say the distinction should be made even more clear by using a this.viewModel and documenting the second argument to reactViewModel as viewModel not state. In my mind, it is better to teach something new than try to overload an existing construct so critical to regular React components that it would lead to confusion. The this.viewModel may need a proposal all its own, but this is how I have done similar React observable integrations; though your technical limitations are most likely different.

To weigh in here with my opinion:
I originally envisioned React-View-Models (RVM) as a higher-order component (HoC), that enhances a "Dumb / Presentational Component" into a "Smart / Container Component" like Recompose, or React-Redux's connect.
HoCs are a very well known and accepted pattern for component composition in the React eco-system, and RVMs behaviour would therefore be consistent with current norms.
The idea that is key to HoCs is that the dumb component only takes props and renders stuff, so the HoC/Enhancer sort of ends up being a "props proxy" and "rendering hijacker" sort of thing, it's a very cool pattern, and makes composition of small, easily testable pieces into more complex components a breeze.
RVM never quite got to my (recently decided) optimally desired API:
const EnhancedComponent = withViewModel( DefineMapClass )( DumbComponent )

...but the idea of enhancing a dumb component into a smart component was always there.
So, I see nothing wrong with props being the thing that ends up being passed to the connected or dumb component.
That being said, I am not sure what this proposal is gong to change with the current implementation.
According to the docs the viewModel isn't on this.props anyway is it? It seems to be passed in as an argument to the "render" function.
reactViewModel( 'AppComponent', ViewModel, (props) => (
{props.name}
) )

...so is there really any difference if you document it:
reactViewModel( 'AppComponent', ViewModel, (viewModel) => (
{viewModel.name}
) )

...?
I would be against adding a second parameter:
const AppComponent = reactViewModel( 'AppComponent', ViewModel, (props, viewModel) => (
{viewModel.name}
) )

...as it breaks the idea of the HoC a little, and is odd in the sense that, what is props at that point?
Is it just the props passed into the "Enhanced Component"? Maybe, I don't know. It just get's further away from the Easy to understand HoC idea, but I suppose I am not against it. You'd probably want to render every time prop changed then, even if nothing in the viewModel caused a change event at that point.
Regardless, the notion of this.state seems irrelevant here. It is an implementation detail as near as I can tell, nothing to do with how the user will use the library.
The change to:
const AppComponent = reactViewModel( 'AppComponent', ViewModel, ( props ) => (
{this.state.name}
) )

Seems, odd, and arbitrary, but nothing I have strong feelings about anyway.
The strong feelings I do have, are that I wanted RVM to behave much like Recompose's withState(), where the state part of it, is abstracted away, and separated from the component, and only added to a component to enhance it and decide when rendering happened. I wanted this before I had ever discovered Recompose, but Recompose matches my mental model so well, it clarified and reinforced what I wanted from RVMs API.
Now, as an implementation detail there is one thing to consider about putting the viewModel in the returned components state. If the viewModel is set on this.state, then it's shows up in React-Dev-Tools when inspecting components, which is a small, but maybe interesting thought.
So... yeah, long story short (too late), what would this proposal actually change? I am probably not against it, but what are we making the user change? What is the concept we are tying to pass onto RVM users?


Automated cherry pick of #4010: Add about Kubernetes egress

Cherry pick of #4010 on release-v3.16.
#4010: Add about Kubernetes egress

too bad the squash isn't working.

/merge-when-ready squash-commits

OK, I will merge the pull request when it's ready, squash the commits when I merge it, and leave the branch after I've merged it.

Deploy preview for calico ready!
Built with commit ea41cca4113d3fa0de977ec578c679aab89bccb1
https://deploy-preview-4018--calico.netlify.app


Extract PR status setting to CommitStatus class

This solves the issue where the app was always setting
the final success status with houndci's token,
instead of user's token (if available).
This also gets all that code out of BuildRunner
and into its own CommitStatus class.

:+1: I think this makes things quite a bit cleaner.


Naive Parallelism Multi-GPU example script fails

Hi, I tried to adapt this example script to use device='auto', to support a larger model.
https://github.com/huggingface/trl/blob/main/examples/scripts/ppo_multi_adapter.py
Unfortunately it fails on the compute_reward_score step. (the generate step does work).
The error using llama-13b on 4 A100s is below.
I'm running it using naive parallelism.
I believe it's because set_adapter isn't correctly loading the weights onto the GPU?
Any help/comments would be greatly appreciated.
The error:
    raw_rewards = ppo_trainer.model.compute_reward_score(**inputs)
  File "/usr/local/lib/python3.8/dist-packages/trl/models/modeling_base.py", line 498, in compute_reward_score
    base_model_output = self.pretrained_model(
  File "/usr/local/lib/python3.8/dist-packages/torch/nn/modules/module.py", line 1533, in _call_impl
    return forward_call(*args, **kwargs)
  File "/usr/local/lib/python3.8/dist-packages/peft/peft_model.py", line 977, in forward
    return self.base_model(
  File "/usr/local/lib/python3.8/dist-packages/torch/nn/modules/module.py", line 1533, in _call_impl
    return forward_call(*args, **kwargs)
  File "/usr/local/lib/python3.8/dist-packages/peft/tuners/tuners_utils.py", line 106, in forward
    return self.model.forward(*args, **kwargs)
  File "/usr/local/lib/python3.8/dist-packages/accelerate/hooks.py", line 164, in new_forward
    output = module._old_forward(*args, **kwargs)
  File "/usr/local/lib/python3.8/dist-packages/transformers/models/llama/modeling_llama.py", line 820, in forward
    outputs = self.model(
  File "/usr/local/lib/python3.8/dist-packages/torch/nn/modules/module.py", line 1533, in _call_impl
    return forward_call(*args, **kwargs)
  File "/usr/local/lib/python3.8/dist-packages/transformers/models/llama/modeling_llama.py", line 708, in forward
    layer_outputs = decoder_layer(
  File "/usr/local/lib/python3.8/dist-packages/torch/nn/modules/module.py", line 1533, in _call_impl
    return forward_call(*args, **kwargs)
  File "/usr/local/lib/python3.8/dist-packages/accelerate/hooks.py", line 164, in new_forward
    output = module._old_forward(*args, **kwargs)
  File "/usr/local/lib/python3.8/dist-packages/transformers/models/llama/modeling_llama.py", line 424, in forward
    hidden_states, self_attn_weights, present_key_value = self.self_attn(
  File "/usr/local/lib/python3.8/dist-packages/torch/nn/modules/module.py", line 1533, in _call_impl
    return forward_call(*args, **kwargs)
  File "/usr/local/lib/python3.8/dist-packages/accelerate/hooks.py", line 164, in new_forward
    output = module._old_forward(*args, **kwargs)
  File "/usr/local/lib/python3.8/dist-packages/transformers/models/llama/modeling_llama.py", line 321, in forward
    query_states = self.q_proj(hidden_states)
  File "/usr/local/lib/python3.8/dist-packages/torch/nn/modules/module.py", line 1533, in _call_impl
    return forward_call(*args, **kwargs)
  File "/usr/local/lib/python3.8/dist-packages/peft/tuners/lora/bnb.py", line 290, in forward
    output = lora_B(lora_A(dropout(x)))
  File "/usr/local/lib/python3.8/dist-packages/torch/nn/modules/module.py", line 1533, in _call_impl
    return forward_call(*args, **kwargs)
  File "/usr/local/lib/python3.8/dist-packages/torch/nn/modules/linear.py", line 114, in forward
    return F.linear(input, self.weight, self.bias)
RuntimeError: Expected all tensors to be on the same device, but found at least two devices, cuda:0 and cpu! (when checking argument for argument mat2 in method wrapper_CUDA_mm)

I was able to solve this by looping through the named parameters and putting the reward model adapter on the correct gpu instance.
If you look at the original devices of all the parameters, you see the default adapter and the base model layers on the right machines, but the reward model adapter on the CPU, and set_adapter doesn't correctly place the model adapters.
The code I run before the train loop is:
    ppo_trainer.model.pretrained_model.set_adapter(ppo_trainer.model.rm_adapter_name)
    ppo_trainer.model.pretrained_model.eval()
    previous_device = None
    for name, module in ppo_trainer.model.pretrained_model.named_parameters():
        if str(module.device) == "cpu":
            module.data = module.data.to(previous_device)
        previous_device = module.device
    ppo_trainer.model.pretrained_model.set_adapter("default")
    ppo_trainer.model.pretrained_model.train()


Replace macro in array_array to remove duplicate codes

Which issue does this PR close?

Closes #.
Rationale for this change

What changes are included in this PR?

Are these changes tested?

Are there any user-facing changes?

@alamb  @jayzhan211  this PR is ready for review.
PTAL : )


Installation of optional dependencies

Is your feature request related to a problem? If so, please describe it.
We would like to install just orquestra-core in orquestra-qml-core, but to do so we need to install orquestra-opt[cma]. We do not have this option with the current state of orquestra-core.
How you envision the solution
Having a list of optional dependencies in the setup.cfg file of orquestra-core that would allow for all the possible combinations of optional dependencies of orquestra-opt, orquestra-...
Describe alternatives you've considered
The alternative is to install orquestra-opt and then on top of that install orquestra-opt[cma].

CC. @brian-dellabetta

You should not use orquestra-core as a dependency in your projects, as most probably you don't need all the elements from orquestra-core.  orquestra-core was intended to be just a utility that allows you to quickly start tinkering with your project by installing all the deps you might need.
Much better solution would be to just specify which packages from orquestra-core you really need inside your project. So in this case that would be orquestra-opt[cma].

Understood, thanks @mstechly


Accessing multiple google spread sheet

Hi ,
I am trying to access multiple google spread sheet through the Table provider but I am not able to read the second spread sheet through the config. Can you please let me know is there any method to access multiple spread sheet.
I am currently using below code for accessing one spread sheet at a time.
.config(function(TabletopProvider){
TabletopProvider.setTabletopOptions({
key:'https://docs.google.com/spreadsheets/d/1lizvDwl',
simpleSheet: true
});

Hi @kaviproject!
The problem is that you can only configure a provider once per module. One option would be to create a separate module for the second sheet, then inject that as a dependency into the first module.
See this SO post. The only difference is that you're configuring TabletopProvider instead of $stateProvider. :smile:

Thank you aendrew


Curl errors during authentication

Running :codeium Auth and pasting the authentication key gives me:
Navigating to https://<my url>
Paste your token here: **********************************************************************************Error detected while processing function codeium#command#Command[6]..39:
line   66:
E474: Unidentified byte: curl: (6) Could not resolve host: https^@
E474: Failed to parse curl: (6) Could not resolve host: https^@
Press ENTER or type command to continue

» nvim --version
NVIM v0.10.1
Build type: Release
LuaJIT 2.1.1713484068

Codeium version: 1.8.66

Does anyone have any ideas how to fix this?

Resolved on its own :shrug:


Add initial support for _resultDependsOn and _resultDependsOnSelf

These attributes are used to establish lifetime dependence between argument/self and the result.
Matching swift-syntax PR :  https://github.com/apple/swift-syntax/pull/2281

Please test with following pull request:
https://github.com/apple/swift-syntax/pull/2281
@swift-ci Please test

Please gate the implementation of a underscored attributes behind an experimental feature flag; see the EXPERIMENTAL_FEATURE macro in Features.def for examples.

I'll add the NonEscapableTypes experimental feature flag in this PR: https://github.com/apple/swift/pull/69164

Please test with following pull request:
https://github.com/apple/swift-syntax/pull/2281
@swift-ci Please test

Please test with following pull request:
https://github.com/apple/swift-syntax/pull/2281
@swift-ci Please test

PR https://github.com/apple/swift/pull/69164 landed. You can use the experimental feature flag here.

Please test with following pull request:
https://github.com/apple/swift-syntax/pull/2281
@swift-ci Please test

Please test with following pull request:
https://github.com/apple/swift-syntax/pull/2281
@swift-ci Please test

Previous run of tests passed, but main has changed, so testing again..

Please test with following pull request:
https://github.com/apple/swift-syntax/pull/2281
@swift-ci Please test

Please test with following pull request:
https://github.com/apple/swift-syntax/pull/2281
@swift-ci Please test


Table header/footer nib can't be made Reusable

Reported by @sdevos:
Table header/footer nib can't be made Reusable, because a reuse identifier can only be set on a UITableViewCell not on other UIView subclasses. Therefore R.swift will not generate a NibResource that implements Reusable.
This makes that the helper method func registerNibForHeaderFooterView<T: NibResource where T: Reusable, T.T: UIView>(nibResource: T) never can be called.
We should consider an alternative, for example:

Make the function take nibResource: T and a reuseIdentifier: String
Make it possible to make the rootview from the xib implements a protocol so it can provide an identifier

I'm not sure if this helps, but you can drag and drop a UITableViewCell into your nib, and change it's class to a custom class that inherits from UITableViewHeaderFooterView.
Using this solution, I'm currently facing this issue:
let headerView = tableView.dequeueReusableHeaderFooterViewWithIdentifier(R.nib.homeFeedSectionHeaderView)

With an error that reads "Cannot convert value of type '_R.nib._HomeFeedSectionHeaderView` to expected argument type 'String'.
I think it's due to the generic constraints on dequeueReusableHeaderFooterViewWithIdentifier, which is expecting a type of UITableViewCell

What about for headers/footers conventionally generate reuse identifier with value of the nib name? Personally for me it's a default approach to use class name both for nib name and for reuse id. I think that is also true for most of devs.
Alternative approach could be to provide an extension to UITableViewHeaderFooterView that adds @IBInspectable property for identifier (and stores it as associated object). Then after user first runs R.swift and includes generated code he/she will be able to set the reuse identifier in IB. Then on next build R.swift will be able to parse xib and extract that value (stored in user defined attributes node).
If adding such extension is not an option then users most likely will have it anyway (or R.swift documentation can recommend to add such extension to enable reuse id generation) so R.swift can still inspect user defined attributes basing on some naming convention.
@justinmakaila That will work, but I had problems with auto-layout. Header was not rendered correctly, particularly it was not filling table width completely. Anyhow I suppose it's more like a hack way and can break with any new release of Xcode.

I +1 the suggestion to synthesize a reuse identifier with an appropriate prefix.

Currently I'm facing this issue that my headerview is blank after I reload the tableview. I end up to setup the headerview everytime I reload the tableview.


Sandbox to production?

This document describes how to manage Marketing when copying a production instance to a sandbox. Is it possible to do the reverse, for example purchase a Marketing license, use it on a sandbox instance, then transfer that to a production instance?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 093fa946-ea87-e50a-55a4-d9438fbb18c9
Version Independent ID: ba234ae0-f6df-f2c3-4063-8cc85f7f1809
Content: Manage marketing instances (Dynamics 365 for Marketing)
Content Source: ce/marketing/manage-marketing-instances.md
Service: dynamics-365-marketing
GitHub Login: @kamaybac
Microsoft Alias: kamaybac

Hi @dcbrown16, The reverse should work as well. Another option could be to convert the sandbox into a production instance. Marketing is licensed per instance, so you may need to keep an eye on that. There could also be some licensing issues when it comes to the total number and types of Dynamics 365 instances you have active, so please make sure you are well acquainted with these before you get started. Here are the licensing details.

Thanks @kamaybac!


Add compositor_free branch in Compatibility scene renderer free function

Fixes: https://github.com/godotengine/godot/issues/88861
See the equivalent code in the other renderers:
https://github.com/godotengine/godot/blob/bb6b06c81343073f10cbbd2af515cf0dac1e6549/servers/rendering/dummy/rasterizer_scene_dummy.h#L171-L173
https://github.com/godotengine/godot/blob/bb6b06c81343073f10cbbd2af515cf0dac1e6549/servers/rendering/renderer_rd/renderer_scene_render_rd.cpp#L1199-L1200
CC @BastiaanOlij

Looks correct, you probably also need to add:
} else if (is_compositor_effect(p_rid)) {
	compositor_effect_free(p_rid);

It's a bit weird with these (including environment) as their implementation is in the base system but then the free logic is in each renderer.

@BastiaanOlij Done!

Thanks!


Release version 0.1.0

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 100.00%. Comparing base (faceaec) to head (63784c1).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #255   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files           68        68
  Lines         1395      1395
  Branches        52        52
=========================================
  Hits          1395      1395

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Good Blessing No Major Power

The Good blessing has no major power at level 10.

This makes the Good Blessings underpowered compared to the other blessing.  Maybe a  major power could be added.


Why do both tasks continue to run despite a stop() ?

Hello and sorry for my bad english, I'm french :)
Thanks you very much for your library. :)
I created a Timer module, which triggers a countdown.  I want this Timer to stop when leaving the screen. I put my code in a useEffect :
useEffect(() => {
    startBackgroundService()

    return () => stopBackgroundService()
}, [])

Sometimes when the user goes to the next screen I trigger a new Timer with others parameters (including the departure time, to display a countdown in notifications) .
In this situation, the first countdown does not have time to stop and both tasks continue to run
I created a simplified example to show my problem.
In this situation, I don't understand why two timers are running in the background:
const sleep = (time) => new Promise((resolve) => setTimeout(() => resolve(), time))

const backgroundTask = async (taskData) => {
  await new Promise(async (resolve) => {
      const { delay } = taskData;

      for (let i = 0; BackgroundService.isRunning(); i++) {
        console.log('// ' + i)

        await BackgroundService.updateNotification({
          taskDesc: 'rest : ' + i,
        });
        await sleep(delay);
      }
  });
}

const startBackgroundService = async () => {
  await BackgroundService.start(backgroundTask, {
    taskName: 'training',
    taskTitle: 'name',
    taskDesc: 'description',
    taskIcon: {
      name: 'ic_small_icon',
      type: 'drawable',
    },
    parameters: {
      delay: 1000,
    }
  })
}

const stopBackgroundService = async () => {
  await BackgroundService.stop()
}

const Timer = () => {
  useEffect(() => {
    startBackgroundService()
    stopBackgroundService()
    startBackgroundService()
  }, [])

  ...
}

LOG  // 0
LOG  // 0
LOG  // 1
LOG  // 1
LOG  // 2
LOG  // 2
LOG  // 3
LOG  // 3
LOG  // 4
LOG  // 4
LOG  // 5
LOG  // 5
...

I found an alternative solution, thank you :)

I found an alternative solution, thank you :)

Could you share it please?


redis should not be required for local tests

Running the test locally should require redis (introduced in #459). Those should be tagged and opt in.

What's the easiest way to do this?


tests/sources/keytest.py is buggy

See original issue on GitLab
In GitLab by [Gitlab user @cs-shadow] on Oct 22, 2019, 15:32
Summary
In tests/sources/keytest.py, we try to test that BuildStream never calls get_unique_key() on sources before their refs are resolved. We try to do a soure track and a build. While the tests asserts that the operations were successful, they do not assert that they indeed did what they were suppposed to do.
For example, in this case,  if you bst source track key-test.bst you'd expect its state to go from inconsistent to resolved, but that's not what happens. Similarly, after bst build key-test.bst, you'd expect its state to go from resolved to cached, but that doesn't happen either. The state remains inconsistent even after building.
Looking more into it, it seems like the build is never scheduled, bst build only ends scheduling one track operation and nothing else. (See terminal output at the bottom)
Steps to reproduce
# Take a fresh clone of buildstream
cd tests/sources/project_key_test
bst build --track key-test.bst
bst show key-test.bst
# At this point, we expect it to be cached, but it is still inconsistent

What is the current bug behavior?
The state of key-test.bst does not update correctly after tracking and building.
What is the expected correct behavior?
The state of key-test.bst does update correctly after tracking and building.
Possible fixes
The immediate reason this is happening because the custom plugin used by these tests does not behave correctly. However, even when plugins are misbehaving, BuildStream must cope with that correclty.
Terminal output
$ bst build --track key-test.bst
[--:--:--][        ][    main:core activity                 ] START   Build
[--:--:--][        ][    main:core activity                 ] START   Loading elements
[00:00:00][        ][    main:core activity                 ] SUCCESS Loading elements
[--:--:--][        ][    main:core activity                 ] START   Resolving elements
[00:00:00][        ][    main:core activity                 ] SUCCESS Resolving elements
[--:--:--][        ][    main:core activity                 ] START   Resolving cached state
[00:00:00][        ][    main:core activity                 ] SUCCESS Resolving cached state
[--:--:--][        ][    main:core activity                 ] START   Checking sources
[00:00:00][        ][    main:core activity                 ] SUCCESS Checking sources

BuildStream Version 1.91.1+21.g27d3c61a
  Session Start: Tuesday, 22-10-2019 at 15:31:59
  Project:       key-test (/Users/csingh43/buildstream/bst-tmp/tests/sources/project_key_test)
  Targets:       key-test.bst

User Configuration
  Configuration File:      Default Configuration
  Cache Directory:         /tmp/bst/buildstream
  Log Files:               /tmp/bst/buildstream/logs
  Source Mirrors:          /tmp/bst/buildstream/sources
  Build Area:              /tmp/bst/buildstream/build
  Strict Build Plan:       Yes
  Maximum Fetch Tasks:     10
  Maximum Build Tasks:     4
  Maximum Push Tasks:      4
  Maximum Network Retries: 2

Loaded Plugins
  Source Plugins
    - key-test

Pipeline
no reference ???????????????????????????????????????????????????????????????? key-test.bst
===============================================================================
[--:--:--][????????][   track:key-test.bst                  ] START   key-test/key-test/????????-track.37166.log
[00:00:00][????????][   track:key-test.bst                  ] SUCCESS key-test/key-test/????????-track.37166.log
[00:00:00][        ][    main:core activity                 ] SUCCESS Build

Pipeline Summary
  Total:       1
  Session:     1
  Track Queue: processed 1, skipped 0, failed 0
  Fetch Queue: processed 0, skipped 0, failed 0
  Build Queue: processed 0, skipped 0, failed 0

In GitLab by [Gitlab user @cs-shadow] on Oct 22, 2019, 15:45
mentioned in commit 9f947521fe652daec78c4554653c26024dbffe87

In GitLab by [Gitlab user @cs-shadow] on Oct 22, 2019, 15:45
mentioned in merge request !1664

In GitLab by [Gitlab user @cs-shadow] on Oct 22, 2019, 21:26
mentioned in commit 349c38905faf64cfa71294bded4cb6dc13d61723

In GitLab by [Gitlab user @marge-bot123] on Oct 22, 2019, 22:12
closed via merge request !1664

In GitLab by [Gitlab user @marge-bot123] on Oct 22, 2019, 22:12
mentioned in commit c5c29c99662d1bc667bcbd41c6d2f288b6c0e57d


DBZ-1452 New and deprecated options on event flattening SMT

https://issues.redhat.com/browse/DBZ-1452

Supersedes #1231.

@Naros, @jpechane, could either of you review and merge this one, so we can include it in tomorrow's Beta2 release? Thanks!

Other than the nit-pick typo I saw, this LGTM.  Once it passes CI again I'll merge.

The unrelated test failure has already been addressed on master.

@gunnarmorling, awesome merging then.


Update IDL

Update to the latest webgpu.idl, which may affect the API.
The eventual API changes are minimal this time.

Texture has new props weight, height, depth_or_array_layers
Buffer has new prop map_state

The IDL does move get_preferred_format to the global GPU object, but we need to have it on the canvas context, because we have different types of canvases. So in the end this did not result in a change 🤷

I'll merge this once I've made sure that PyGfx works with the update too.


Prevent div-by-0 when producing test execution summary

This is a fix for SR-334, in which a NaN value would appear in the final summary line at the end of test execution:
Total executed 0 tests, with 0 failures (0 unexpected) in -nan (0.0) seconds

This is a simple fix for the issue, but I have greater doubts about the calculation of the time values that are being printed. The current code prints ... in {average test duration} ({total test duration}) seconds, however the two figures printed by the original XCTest seem to be something closer to ... in {total time spent executing tests} ({total elapsed time since XCTest began running}) seconds, or similar. Does anyone have more insight into what XCTest provides here?
@modocache

Awesome, thanks @briancroom! :+1:

...the two figures printed by the original XCTest seem to be something closer to ... in {total time spent executing tests} ({total elapsed time since XCTest began running}) seconds, or similar.

Here's some output from tests on an open-source project of mine:
Test Suite 'PendingTests_ObjC' started at 2015-12-20 16:29:09.975
Test Case '-[PendingTests_ObjC testAnOtherwiseFailingExampleWhenMarkedPendingDoesNotCauseTheSuiteToFail]' started.
Test Case '-[PendingTests_ObjC testAnOtherwiseFailingExampleWhenMarkedPendingDoesNotCauseTheSuiteToFail]' passed (0.007 seconds).
Test Case '-[PendingTests_ObjC testBeforeEachDoesNotRunForContextsWithOnlyPendingExamples]' started.
Test Case '-[PendingTests_ObjC testBeforeEachDoesNotRunForContextsWithOnlyPendingExamples]' passed (0.051 seconds).
Test Case '-[PendingTests_ObjC testBeforeEachOnlyRunForEnabledExamples]' started.
Test Case '-[PendingTests_ObjC testBeforeEachOnlyRunForEnabledExamples]' passed (0.022 seconds).
Test Suite 'PendingTests_ObjC' passed at 2015-12-20 16:29:10.116.
	 Executed 3 tests, with 0 failures (0 unexpected) in 0.080 (0.140) seconds

The last line, Executed 3 tests, with 0 failures (0 unexpected) in 0.080 (0.140) seconds, outputs two times:

0.080: the sum of the times between the start and stop of each XCTestCaseRun in the XCTestSuite. Notice the three test cases pass in 0.007, 0.051, and 0.022 seconds, and that 0.007 + 0.051 + 0.022 == 0.080.
0.140: the time between the start and stop of the XCTestSuiteRun.

The current code prints ... in {average test duration} ({total test duration}) seconds...

The outputs definitely appear to represent two different things.
My takeaways:

It should be clear to users what these numbers represent. If they are indeed averages in swift-corelibs-xctest, we should state that fact in the output. For swift-corelibs-xctest, how about creating a JIRA issue or submit a pull request? For Apple XCTest, how about submitting a radar?
The goal of swift-corelibs-xctest is to "enable your project's tests to run on all Swift platforms without having to rewrite them". I consider different output to be contrary to that goal--if I write code to parse test output on OS X, it should work equally well on Linux. swift-corelibs-xctest doesn't have an XCTestSuite yet, but it could print ...in {sum of times for each test method} ({delta between test case start and stop}) seconds, which I think would be more in line with what Apple XCTest outputs. Again, I'd create a JIRA issue or submit a pull request.

While we're printing averages, though, I think the proposed change is an improvement. LGTM! :ship:

Closing in favor of #23!


Fix automated jazzy generation

This PR aims to work towards resolving the automated jazzy generation logic, in reference to the following issue.

Codecov Report

Merging #131 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff          @@
##           master   #131   +/-   ##
=====================================
  Coverage      50%    50%
=====================================
  Files           1      1
  Lines          10     10
=====================================
  Hits            5      5
  Misses          5      5

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 636aeeb...b9f19d3. Read the comment docs.

@ShihabMehboob I've made some additional changes on my branch in https://github.com/djones6/Package-Builder/commit/7b389cebda809bffbd4b32b94e4d8b56830da6b9 that address my comments above.
However, upon testing, it seems we cannot simply git checkout <branchname> because apparently, for a Pull Request build, Travis performs a shallow clone of the repo under test, then merges the PR into it.  There's nothing here we can push to.
What we might have to do is something like this:
git remote add jazzy https://github.com/${TRAVIS_REPO_SLUG}.git
git fetch jazzy
git checkout jazzy/${TRAVIS_PULL_REQUEST_BRANCH} -b ${TRAVIS_PULL_REQUEST_BRANCH}

I've just dropped that into my branch and am running the CI on https://github.com/IBM-Swift/Kitura/pull/1217 to test it.

This has been delivered in #133


fix: Make sure that global imports/exports do work

With this change following import should work:
import { sum } from "ember-math-helpers";

Fixes: #1673

@MichalBryxi thanks for the PR! Looks like it might need some additional tweaks to get it to work though.

Now it seems to be working ok on mine:
pnpm test

...

1..66
# tests 66
# pass  66
# skip  0
# todo  0
# fail  0

# ok


*: add pd-recover to Dockerfile

What problem does this PR solve?
Closes #2402.
What is changed and how it works?
This PR does three things:

change make target to compile pd-recover together
add pd-recover to the docker image
add -V parameter to show the version of pd-recover

Check List
Tests

Unit test

Release note

Fix the issue that pd-recover is not included in the docker image

Codecov Report

Merging #2406 into master will decrease coverage by 0.00%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #2406      +/-   ##
==========================================
- Coverage   76.32%   76.31%   -0.01%
==========================================
  Files         206      206
  Lines       22018    22018
==========================================
- Hits        16805    16804       -1
+ Misses       3936     3934       -2
- Partials     1277     1280       +3

Impacted Files
Coverage Δ

server/kv/etcd_kv.go
75.32% <0.00%> (-12.99%)
:arrow_down:

server/cluster/coordinator.go
74.52% <0.00%> (-2.20%)
:arrow_down:

server/member/leader.go
73.54% <0.00%> (-1.95%)
:arrow_down:

server/core/storage.go
74.38% <0.00%> (-0.83%)
:arrow_down:

server/tso/tso.go
82.48% <0.00%> (-0.73%)
:arrow_down:

server/cluster/cluster.go
80.32% <0.00%> (-0.44%)
:arrow_down:

server/server.go
78.31% <0.00%> (+0.31%)
:arrow_up:

server/grpc_service.go
59.24% <0.00%> (+1.39%)
:arrow_up:

client/base_client.go
90.34% <0.00%> (+3.44%)
:arrow_up:

pkg/dashboard/adapter/manager.go
84.40% <0.00%> (+3.66%)
:arrow_up:

... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update feb738d...01c4a7b. Read the comment docs.

@rleungx Please cherry-pick this to 3.1. Thanks!

@rleungx Please cherry-pick this to 3.1. Thanks!

OK

/merge

/merge

/merge

/merge

/merge

/merge


Pychron

Trying to open the last FC-2 analyzed on Pychron, I obtained this error (for all of the FC-2):
-- Analysis 28440-01 not in local repository Irradiation-NM-323. You may need to pull changes. If local repository is up to date you may need to push changes from the data collection computer.
This happened only with FC-2 samples of NM-323. The unknown samples work.

these issue is not related to the PychronWeb project aka SampleTracker


OAK-10974 and OAK-10869 : temporarily disabling flaky tests

even just in this run more tests turn up as flaky, but as this PR improves 2 cases, I'll go ahead still (but yes, more needs to be done)


Make a downloadable package for branding

Please use one of the following templates to create new issues:
As a VISITOR. when I go to operationcode.org/press-kit all of the press media should be available as a downloadable file.
There should also be branding guidelines and individual downloads of content.
Additional Information (eg browser version, screenshots etc):
This would be a downloadable .zip file

@kjaymiller, good call. I can put these in AWS and share in the links this week.


Update font icon library

Needed with - https://github.com/silverstripe/silverstripe-cms/pull/1268
Also updated the buttons in the files area to the new 'flat' style

Looks like this also fixes #4528 :)

@kinglozzer have you tested locally? good to take in?!

I tested locally, though I don't have IE 10 and couldn't replicated #4528 with IE11 in emulation mode.
I don't see any obvious regressions and the new buttons look nice.

Just added implementation of new logout font-icon to this PR

@kinglozzer would you be able to test IE10?

Tested in IE8, 9, 10 & 11, Chrome, Firefox and Safari - the icons looks great in all of them! Thanks @scott1702

Thanks!


Test Wire Migration

Build issues
e: C:\Users\yuri\workspace\emulator-tools\src\main\kotlin\com\android\emulator\control\SocketControl.kt: (210, 17): Expecting ';' after the last enum entry or '}' to close enum class body

e: C:\Users\yuri\workspace\emulator-tools\src\main\kotlin\com\android\emulator\control\LogMessage.kt: (269, 21): Type mismatch: inferred type is Unit but Serializable was expected
e: C:\Users\yuri\workspace\emulator-tools\src\main\kotlin\com\android\emulator\control\TouchEvent.kt: (168, 21): Type mismatch: inferred type is Unit but Serializable was expected
e: C:\Users\yuri\workspace\emulator-tools\src\main\kotlin\com\android\emulator\snapshot\Config.kt: (204, 21): Type mismatch: inferred type is Unit but Serializable was expected
e: C:\Users\yuri\workspace\emulator-tools\src\main\kotlin\com\android\emulator\snapshot\Snapshot.kt: (585, 21): Type mismatch: inferred type is Unit but Serializable was expected
e: C:\Users\yuri\workspace\emulator-tools\src\main\kotlin\com\google\waterfall\Cmd.kt: (256, 18): Type mismatch: inferred type is Unit but Serializable was expected
e: C:\Users\yuri\workspace\emulator-tools\src\main\kotlin\com\google\waterfall\Cmd.kt: (257, 21): Type mismatch: inferred type is Unit but Serializable was expected

open is a keyword


Please update README in branch 2.0

Thanks for bringing this up! I've opened #3353 to fix this.


Automator: update istio/client-go@master dependency in istio/istio@master

Generated by Automator - 2024-02-15T18:35:56+00:00

@istio-testing: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-basic-arm64_istio
2dac132da1ccab21d9dfa6228d1c77a0cf001585
link
unknown
/test integ-basic-arm64

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@istio-testing: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-basic-arm64_istio
2dac132da1ccab21d9dfa6228d1c77a0cf001585
link
unknown
/test integ-basic-arm64

integ-pilot-istiodremote-mc_istio
2dac132da1ccab21d9dfa6228d1c77a0cf001585
link
unknown
/test integ-pilot-istiodremote-mc

unit-tests-arm64_istio
2dac132da1ccab21d9dfa6228d1c77a0cf001585
link
unknown
/test unit-tests-arm64

integ-helm_istio
2dac132da1ccab21d9dfa6228d1c77a0cf001585
link
unknown
/test integ-helm

integ-pilot-istiodremote_istio
2dac132da1ccab21d9dfa6228d1c77a0cf001585
link
unknown
/test integ-pilot-istiodremote

release-notes_istio
2dac132da1ccab21d9dfa6228d1c77a0cf001585
link
unknown
/test release-notes

integ-ipv6_istio
2dac132da1ccab21d9dfa6228d1c77a0cf001585
link
unknown
/test integ-ipv6

lint_istio
2dac132da1ccab21d9dfa6228d1c77a0cf001585
link
unknown
/test lint

analyze-tests_istio
2dac132da1ccab21d9dfa6228d1c77a0cf001585
link
unknown
/test analyze-tests

integ-cni_istio
2dac132da1ccab21d9dfa6228d1c77a0cf001585
link
unknown
/test integ-cni

integ-ambient_istio
2dac132da1ccab21d9dfa6228d1c77a0cf001585
link
unknown
/test integ-ambient

integ-ds_istio
2dac132da1ccab21d9dfa6228d1c77a0cf001585
link
unknown
/test integ-ds

integ-security_istio
2dac132da1ccab21d9dfa6228d1c77a0cf001585
link
unknown
/test integ-security

integ-operator-controller_istio
2dac132da1ccab21d9dfa6228d1c77a0cf001585
link
unknown
/test integ-operator-controller

integ-telemetry-discovery_istio
2dac132da1ccab21d9dfa6228d1c77a0cf001585
link
unknown
/test integ-telemetry-discovery

integ-distroless_istio
2dac132da1ccab21d9dfa6228d1c77a0cf001585
link
unknown
/test integ-distroless

integ-pilot_istio
2dac132da1ccab21d9dfa6228d1c77a0cf001585
link
unknown
/test integ-pilot

integ-telemetry_istio
2dac132da1ccab21d9dfa6228d1c77a0cf001585
link
unknown
/test integ-telemetry

gencheck_istio
2dac132da1ccab21d9dfa6228d1c77a0cf001585
link
unknown
/test gencheck

integ-pilot-multicluster_istio
2dac132da1ccab21d9dfa6228d1c77a0cf001585
link
unknown
/test integ-pilot-multicluster

integ-security-istiodremote_istio
2dac132da1ccab21d9dfa6228d1c77a0cf001585
link
unknown
/test integ-security-istiodremote

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@istio-testing: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-basic-arm64_istio
2dac132da1ccab21d9dfa6228d1c77a0cf001585
link
unknown
/test integ-basic-arm64

integ-pilot-istiodremote-mc_istio
2dac132da1ccab21d9dfa6228d1c77a0cf001585
link
unknown
/test integ-pilot-istiodremote-mc

unit-tests-arm64_istio
2dac132da1ccab21d9dfa6228d1c77a0cf001585
link
unknown
/test unit-tests-arm64

integ-helm_istio
2dac132da1ccab21d9dfa6228d1c77a0cf001585
link
unknown
/test integ-helm

integ-pilot-istiodremote_istio
2dac132da1ccab21d9dfa6228d1c77a0cf001585
link
unknown
/test integ-pilot-istiodremote

release-notes_istio
2dac132da1ccab21d9dfa6228d1c77a0cf001585
link
unknown
/test release-notes

integ-ipv6_istio
2dac132da1ccab21d9dfa6228d1c77a0cf001585
link
unknown
/test integ-ipv6

lint_istio
2dac132da1ccab21d9dfa6228d1c77a0cf001585
link
unknown
/test lint

analyze-tests_istio
2dac132da1ccab21d9dfa6228d1c77a0cf001585
link
unknown
/test analyze-tests

integ-cni_istio
2dac132da1ccab21d9dfa6228d1c77a0cf001585
link
unknown
/test integ-cni

integ-ambient_istio
2dac132da1ccab21d9dfa6228d1c77a0cf001585
link
unknown
/test integ-ambient

integ-ds_istio
2dac132da1ccab21d9dfa6228d1c77a0cf001585
link
unknown
/test integ-ds

integ-security_istio
2dac132da1ccab21d9dfa6228d1c77a0cf001585
link
unknown
/test integ-security

integ-operator-controller_istio
2dac132da1ccab21d9dfa6228d1c77a0cf001585
link
unknown
/test integ-operator-controller

integ-telemetry-discovery_istio
2dac132da1ccab21d9dfa6228d1c77a0cf001585
link
unknown
/test integ-telemetry-discovery

integ-distroless_istio
2dac132da1ccab21d9dfa6228d1c77a0cf001585
link
unknown
/test integ-distroless

integ-pilot_istio
2dac132da1ccab21d9dfa6228d1c77a0cf001585
link
unknown
/test integ-pilot

integ-telemetry_istio
2dac132da1ccab21d9dfa6228d1c77a0cf001585
link
unknown
/test integ-telemetry

gencheck_istio
2dac132da1ccab21d9dfa6228d1c77a0cf001585
link
unknown
/test gencheck

integ-pilot-multicluster_istio
2dac132da1ccab21d9dfa6228d1c77a0cf001585
link
unknown
/test integ-pilot-multicluster

integ-security-istiodremote_istio
2dac132da1ccab21d9dfa6228d1c77a0cf001585
link
unknown
/test integ-security-istiodremote

release-test_istio
2dac132da1ccab21d9dfa6228d1c77a0cf001585
link
unknown
/test release-test

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@istio-testing: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-basic-arm64_istio
2dac132da1ccab21d9dfa6228d1c77a0cf001585
link
unknown
/test integ-basic-arm64

integ-pilot-istiodremote-mc_istio
2dac132da1ccab21d9dfa6228d1c77a0cf001585
link
unknown
/test integ-pilot-istiodremote-mc

unit-tests-arm64_istio
2dac132da1ccab21d9dfa6228d1c77a0cf001585
link
unknown
/test unit-tests-arm64

integ-helm_istio
2dac132da1ccab21d9dfa6228d1c77a0cf001585
link
unknown
/test integ-helm

integ-pilot-istiodremote_istio
2dac132da1ccab21d9dfa6228d1c77a0cf001585
link
unknown
/test integ-pilot-istiodremote

release-notes_istio
2dac132da1ccab21d9dfa6228d1c77a0cf001585
link
unknown
/test release-notes

integ-ipv6_istio
2dac132da1ccab21d9dfa6228d1c77a0cf001585
link
unknown
/test integ-ipv6

lint_istio
2dac132da1ccab21d9dfa6228d1c77a0cf001585
link
unknown
/test lint

analyze-tests_istio
2dac132da1ccab21d9dfa6228d1c77a0cf001585
link
unknown
/test analyze-tests

integ-cni_istio
2dac132da1ccab21d9dfa6228d1c77a0cf001585
link
unknown
/test integ-cni

integ-ambient_istio
2dac132da1ccab21d9dfa6228d1c77a0cf001585
link
unknown
/test integ-ambient

integ-ds_istio
2dac132da1ccab21d9dfa6228d1c77a0cf001585
link
unknown
/test integ-ds

integ-security_istio
2dac132da1ccab21d9dfa6228d1c77a0cf001585
link
unknown
/test integ-security

integ-operator-controller_istio
2dac132da1ccab21d9dfa6228d1c77a0cf001585
link
unknown
/test integ-operator-controller

integ-telemetry-discovery_istio
2dac132da1ccab21d9dfa6228d1c77a0cf001585
link
unknown
/test integ-telemetry-discovery

integ-distroless_istio
2dac132da1ccab21d9dfa6228d1c77a0cf001585
link
unknown
/test integ-distroless

integ-pilot_istio
2dac132da1ccab21d9dfa6228d1c77a0cf001585
link
unknown
/test integ-pilot

integ-telemetry_istio
2dac132da1ccab21d9dfa6228d1c77a0cf001585
link
unknown
/test integ-telemetry

gencheck_istio
2dac132da1ccab21d9dfa6228d1c77a0cf001585
link
unknown
/test gencheck

integ-pilot-multicluster_istio
2dac132da1ccab21d9dfa6228d1c77a0cf001585
link
unknown
/test integ-pilot-multicluster

integ-security-istiodremote_istio
2dac132da1ccab21d9dfa6228d1c77a0cf001585
link
unknown
/test integ-security-istiodremote

release-test_istio
2dac132da1ccab21d9dfa6228d1c77a0cf001585
link
unknown
/test release-test

integ-security-multicluster_istio
2dac132da1ccab21d9dfa6228d1c77a0cf001585
link
unknown
/test integ-security-multicluster

integ-telemetry-istiodremote_istio
2dac132da1ccab21d9dfa6228d1c77a0cf001585
link
unknown
/test integ-telemetry-istiodremote

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@istio-testing: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-basic-arm64_istio
2dac132da1ccab21d9dfa6228d1c77a0cf001585
link
unknown
/test integ-basic-arm64

integ-pilot-istiodremote-mc_istio
2dac132da1ccab21d9dfa6228d1c77a0cf001585
link
unknown
/test integ-pilot-istiodremote-mc

unit-tests-arm64_istio
2dac132da1ccab21d9dfa6228d1c77a0cf001585
link
unknown
/test unit-tests-arm64

integ-helm_istio
2dac132da1ccab21d9dfa6228d1c77a0cf001585
link
unknown
/test integ-helm

integ-pilot-istiodremote_istio
2dac132da1ccab21d9dfa6228d1c77a0cf001585
link
unknown
/test integ-pilot-istiodremote

release-notes_istio
2dac132da1ccab21d9dfa6228d1c77a0cf001585
link
unknown
/test release-notes

integ-ipv6_istio
2dac132da1ccab21d9dfa6228d1c77a0cf001585
link
unknown
/test integ-ipv6

lint_istio
2dac132da1ccab21d9dfa6228d1c77a0cf001585
link
unknown
/test lint

analyze-tests_istio
2dac132da1ccab21d9dfa6228d1c77a0cf001585
link
unknown
/test analyze-tests

integ-cni_istio
2dac132da1ccab21d9dfa6228d1c77a0cf001585
link
unknown
/test integ-cni

integ-ambient_istio
2dac132da1ccab21d9dfa6228d1c77a0cf001585
link
unknown
/test integ-ambient

integ-ds_istio
2dac132da1ccab21d9dfa6228d1c77a0cf001585
link
unknown
/test integ-ds

integ-security_istio
2dac132da1ccab21d9dfa6228d1c77a0cf001585
link
unknown
/test integ-security

integ-operator-controller_istio
2dac132da1ccab21d9dfa6228d1c77a0cf001585
link
unknown
/test integ-operator-controller

integ-telemetry-discovery_istio
2dac132da1ccab21d9dfa6228d1c77a0cf001585
link
unknown
/test integ-telemetry-discovery

integ-distroless_istio
2dac132da1ccab21d9dfa6228d1c77a0cf001585
link
unknown
/test integ-distroless

integ-pilot_istio
2dac132da1ccab21d9dfa6228d1c77a0cf001585
link
unknown
/test integ-pilot

integ-telemetry_istio
2dac132da1ccab21d9dfa6228d1c77a0cf001585
link
unknown
/test integ-telemetry

gencheck_istio
2dac132da1ccab21d9dfa6228d1c77a0cf001585
link
unknown
/test gencheck

integ-pilot-multicluster_istio
2dac132da1ccab21d9dfa6228d1c77a0cf001585
link
unknown
/test integ-pilot-multicluster

integ-security-istiodremote_istio
2dac132da1ccab21d9dfa6228d1c77a0cf001585
link
unknown
/test integ-security-istiodremote

release-test_istio
2dac132da1ccab21d9dfa6228d1c77a0cf001585
link
unknown
/test release-test

integ-security-multicluster_istio
2dac132da1ccab21d9dfa6228d1c77a0cf001585
link
unknown
/test integ-security-multicluster

integ-telemetry-istiodremote_istio
2dac132da1ccab21d9dfa6228d1c77a0cf001585
link
unknown
/test integ-telemetry-istiodremote

integ-telemetry-mc_istio
2dac132da1ccab21d9dfa6228d1c77a0cf001585
link
unknown
/test integ-telemetry-mc

unit-tests_istio
2dac132da1ccab21d9dfa6228d1c77a0cf001585
link
unknown
/test unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.


grpc_http1_bridge: support for prepending and trimming the grpc frame header

This is an implementation based on the discussion in #19198.
When application/x-protobuf is used the filter will prepend the payload with the gRPC header, as defined by the wire format. Before returning the response the frame is also trimmed. This functionality is behind a configuration setting.

Risk Level: Medium
Testing: Unit tests
Docs Changes: WIP
Fixes #19198

@adisuissa thanks for review, I think I addressed most of your feedback. Please have another look when you have the time!

@lizan CI seems to be happy now :-)

I'll be off after January 17th and would like to help addressing any feedback before then. I'm not sure, but I get the impression from the reviewers that it's mostly good to go? (cc @mattklein123 as assignee)

/assign-from @envoyproxy/first-pass-reviewers

assigning to lizan as a grpc expert.


10/06/23 Team Meeting

Agenda:
-Finish SRS
-Discuss what to do for Team Review

TODO

@fadymorcos21 finish reflection
@DangJustin @HamidHarris @FardeenAfsar @Lazarus-XD @fadymorcos21 Create at least 1 issue (not typos) for team 7 for SRS https://github.com/d-akselrod/SweatSmart
Due date for reviews is Oct 10
Hazard Analysis Due October 20th (the Friday after reading week)
TA review October 16th


Interactive discovery

Resolves L2B-3055
What's changed
Added interactive mode where you can manage overrides (watch mode, relative, methods, etc) over the CLI.
Notes

comments-json used for comments preservation
built on top of current architecture with little to no changes made to the core

How to test it?

It will only run with some diffs present.

Ideally, you have to have the main repo and tools cloned.
Clone and build tools
Link @l2beat/discovery - go to /packages/discovery and use yarn link in the terminal
Connect the other part of the local link in the main l2beat repo via yarn link @l2beat/discovery
Rebuild main repo deps - yarn install --force

If yarn still fails to resolve the discovery package from the tools repository (might still use remote npm under the hood), explicitly point to discovery dist as a dependency location:

6. Go to /package/backend/ in the main l2beat repo
7. Run yarn discover <chain> <project> --dry-run --interactive
8. Mess around

i'd love this <33333


More information on activities and amenities

During our CUTgroup test, we heard questions about the activities/amenities a preserve offers. One example is that a tester was interested in finding a place to rent a canoe. She searched for "Canoe" and saw that her only option was "canoe landing." She then wondered if a canoe landing can also rent canoes or if she has to bring her own. She was not sure, and then thought she might want to look at "Boat rentals" but did not know if boat rentals would have canoes.

@smarziano We need to try to come up with a list of alternative names for activities and amenities that help this situation. One of my testers searched "run" or "running," which will be a common query, and came up empty. So the official amenity is hiking, but that should also trigger for "run," "jog," etc. Similar issue when someone searched "kayak."

Covered in enhanced search and POI descriptions (example: POIs with boat rentals/launches indicate what boats are allowed. Provides link to more info about boat rentals).


Invoke ViewComponent using javascript

This is more of a discussion then an issue, I hope this is ok.
I'm developing a simple content management system using ViewComponents and I need to update/rerender a component without rendering the complete page again. Is it possible to invoke a ViewComponent using javascript and skip the routing mechanism?

No, that is not possible. You need a controller that returns a partial view

You could build a standard proxy for viewcomponents if you'd like though (similarly you could build a proxy to partial views). e.g. you a catchall attribute route on an action

I guess it's the same problem if I have an html form in my viewcomponent and need to handle the posted data, a catch all attribute route on an action is the only way to handle the form post? @yishaigalatzer

You should think of a viewcomponent as a fancy html helper and not a child action.
Thus you can and should probably have individual actions to handle the form post rather than a catchall.


Frontend: static journal component

Please work in the AddJournalScreen.tsx file only (so push only this file).

git fetch origin
git checkout 28-frontend-static-journal-component


Log file format

Hi,
I config nlog(v4.0.30319) like this:
  <targets>
    <target xsi:type="File" name="globalErrorLog" fileName="${basedir}\App_Data\Logs\log.txt"
       header="${longdate}"
       layout="${message}"
       footer="---------------${level} | ${logger}---------------"
     />
  </targets>

  <rules>
    <logger name="*" minlevel="Error" writeTo="globalErrorLog"/>
  </rules>

but I get the log file content like this:
2016-09-30 16:14:43.4178
Void HandleUnknownAction(System.String) | A public action method 'Index' was not found on controller 'SesameManager.User.Controllers.HomeController'.
---------------Off | ---------------
Void HandleUnknownAction(System.String) | A public action method 'Index' was not found on controller 'SesameManager.User.Controllers.HomeController'.
---------------Off | ---------------
Void HandleUnknownAction(System.String) | A public action method 'Index' was not found on controller 'SesameManager.User.Controllers.HomeController'.

the format of log file i want is:
datetime
message
----------log level | logger name----------

v4.0.30319 is the NLog version.I use ASP.NET MVC 5(.NET Framework 4.5.2)
the csharp code in my project:
public class MvcApplication : System.Web.HttpApplication
{
    protected void Application_Error(object sender, EventArgs e)
   {
        Logger logger = LogManager.GetLogger("globalErrorLog");
        Exception ex = Server.GetLastError();
        logger.Error(ex.TargetSite + " | " + ex.Message);
        Server.ClearError();
    }
}

Thanks for your answer.

Please anwer my questions ;)
And that is the net framework version, please check packages.config

Sorry,the Nlog version is 4.3.9

Could you give an example with multiple items?

I'm not sure if I understand your question correcyly
You would like to have this output? (as example)
2016-09-30 16:14:43.4178
A public action method 'Index' was not found on controller 'SesameManager.User.Controllers.HomeController'.
----------Error | globalErrorLog----------
2016-09-30 16:14:43.1112
A public action method 'Index' was not found on controller 'SesameManager.User.Controllers.HomeController'.
----------Error | globalErrorLog----------
2016-09-30 16:14:43.1113
A public action method 'Index' was not found on controller 'SesameManager.User.Controllers.HomeController'.
----------Error | globalErrorLog----------

Yes,you are right.
Where did I go wrong?

what about:
  <targets>
    <target xsi:type="File" name="globalErrorLog" fileName="${basedir}\App_Data\Logs\log.txt"
       layout="${longdate}${newline}${message}${exception}${newline}----------${level} $logger}----------"

     />
  </targets>

  <rules>
    <logger name="*" minlevel="Error" writeTo="globalErrorLog"/>
  </rules>

Thanks,the problem is solved by your solution :)
But why my config cannot work?
Thanks again.


Cannot start node (MainNet)

I follow the instruction to setup a mainnet node here, with Ubuntu 20.04. However, my node cannot start, with the error log included here:
$ /usr/bin/casper-node-launcher --force-version 1.4.5
{"timestamp":"May 07 17:28:05.536","level":"INFO","fields":{"message":"node starting up","version":"1.4.5-725c25d9e-casper-mainnet"},"target":"casper_node::cli"}
{"timestamp":"May 07 17:28:05.537","level":"INFO","fields":{"message":"no previous crash detected"},"target":"casper_node::cli"}
{"timestamp":"May 07 17:28:05.537","level":"WARN","fields":{"message":"large event size, consider reducing it or boxing","event_size":"152","type_name":"\"casper_node::reactor::initializer::Event\""},"target":"casper_node::reactor"}
{"timestamp":"May 07 17:28:05.537","level":"INFO","fields":{"message":"reindexing block store"},"target":"casper_node::components::storage"}
{"timestamp":"May 07 17:28:05.537","level":"INFO","fields":{"message":"block store reindexing complete"},"target":"casper_node::components::storage"}
{"timestamp":"May 07 17:28:05.537","level":"INFO","fields":{"message":"initializing v1 block body database"},"target":"casper_node::components::storage"}
{"timestamp":"May 07 17:28:05.537","level":"INFO","fields":{"message":"v1 block body database initialized"},"target":"casper_node::components::storage"}
{"timestamp":"May 07 17:28:05.537","level":"INFO","fields":{"message":"initializing v2 block body database"},"target":"casper_node::components::storage"}
{"timestamp":"May 07 17:28:05.537","level":"INFO","fields":{"message":"v2 block body database initialized"},"target":"casper_node::components::storage"}
{"timestamp":"May 07 17:28:05.537","level":"INFO","fields":{"message":"initializing block metadata database"},"target":"casper_node::components::storage"}
{"timestamp":"May 07 17:28:05.537","level":"INFO","fields":{"message":"block metadata database initialized"},"target":"casper_node::components::storage"}
{"timestamp":"May 07 17:28:05.537","level":"INFO","fields":{"message":"initializing deploy metadata database"},"target":"casper_node::components::storage"}
{"timestamp":"May 07 17:28:05.537","level":"INFO","fields":{"message":"deploy metadata database initialized"},"target":"casper_node::components::storage"}
{"timestamp":"May 07 17:28:05.537","level":"INFO","fields":{"message":"the maximum delegators per validator is currently set to: 952"},"target":"casper_node::reactor::initializer"}
{"timestamp":"May 07 17:28:05.541","level":"INFO","fields":{"message":"reactor main loop is ready"},"target":"casper_node::reactor"}
{"timestamp":"May 07 17:28:05.561","level":"WARN","fields":{"message":"invalid run, no blocks stored but not a genesis chainspec: exit to downgrade"},"target":"casper_node::components::chainspec_loader"}
{"timestamp":"May 07 17:28:05.562","level":"INFO","fields":{"message":"exiting casper-node","exit_code":"102"},"target":"casper_node"}

DId you try to follow this :https://github.com/casper-network/casper-node/wiki/Mainnet-Node-Installation-Instructions ?


Ability to add statements within blocks (if, else, while, do, switch etc..)

As title.

This can be done by getting the Block node descendant (ts.SyntaxKind.Block) and calling addStatement() or insertStatement() on that.


[v1.2] Move wallet address to sidebar

Description of done:

wallet address button removed from TopBar
Wallet address displayed as clickable link beneath olympus brand header (same link as original button, wallet etherscan)

Also addressed in https://github.com/OlympusDAO/olympusdao/pull/160

Also addressed in #160

Cool just link pr to this ticket too when you submit


service_bindings corrupts values containing %

Issue
The /v2/service_bindings endpoint will mangle values containing the % character. In some cases, this can result in invalid JSON. It resembles a string format call with missing argument values.
Context
My user provided service contains the string "hello%world" which becomes "hello%!w(MISSING)orld". The value is fine when read from the application and cf env app.
Here's a snippet from the response:
{
      "metadata": {
        "guid": "9bdbffd9-48fe-49a8-8edc-1a00f3788150",
        "url": "/v2/service_bindings/9bdbffd9-48fe-49a8-8edc-1a00f3788150",
        "created_at": "2017-03-21T16:43:20Z",
        "updated_at": "2017-03-21T16:43:20Z"
      },
      "entity": {
        "app_guid": "65935225-ba35-4f86-bcc3-0467218baea7",
        "service_instance_guid": "53f1f12d-9563-481d-93d9-b79af96d48fd",
        "credentials": {
          "secret": "hello%!w(MISSING)orld"
        },
        "binding_options": {

        },
        "gateway_data": null,
        "gateway_name": "",
        "syslog_drain_url": "",
        "volume_mounts": [

        ],
        "app_url": "/v2/apps/65935225-ba35-4f86-bcc3-0467218baea7",
        "service_instance_url": "/v2/user_provided_service_instances/53f1f12d-9563-481d-93d9-b79af96d48fd"
      }
    }

If the % occurs at the end of the value, this will result in invalid JSON being returned:
{
  "secret": "helloworld%"!(MISSING),
}

Steps to Reproduce
Create a user provided service containing %.
$ cf cups my-service -p '{"secret": "hello%world"}'

Bind the service to an app.
$ cf bind-service my-app my-service

Hit the service_bindings endpoint.
$ curl 'https://api.fr.cloud.gov/v2/service_bindings' | grep hello

Expected result
Valid JSON response with un-modified string "hello%world".
Current result
String is mangled: "hello%!w(MISSING)orld"

Hey @adborden,
What version of CF is this happening on?
We were unable to reproduce this with the steps provided above. Using the most recent code from the master branch, we correctly saw hello%world in the call to /v2/service_bindings.
Thanks,
CAPI Community Pair @aashah & @jenspinney

Thanks for looking into it. We have a thin proxy in front of our API and it looks like that's where the problem is, thank you!


Google sign -in button - "Use another account" does not provide a call back or consent form

here are the steps to reproduce the issue:

click on google signin Button.
choose "use another account"
sign in with the new account and this should bring you back to the app.
app only shows dark overlay and consent form or callback is not working.

then if i touch the screen the dark overlay goes away, and if i touch facebook button i get a toast saying an error has occured. at this time if i press the google button again it automatically logs me in with the account. I tried a few apps like stackoverflow,traveloka, airBNB, my own simple app with a google SSO button and glassdoor,lazada, etc and a few others and all of them give an error after getting to option 3. but i'd expect facebook button not to give an error at least .

Thanks for reporting.  The main place we're tracking this issue is here:
https://github.com/googlesamples/google-services/issues/358
This requires an update to the Google Play services APK on your phone.  Not something we can fix with an SDK bump.

Which google play service version fix this issues, in my pixel, I update to the latest version, the same problem happens. My google play service version is 12.6.73(090400-194189626)

@Xiaojuanmao this issue is still not fixed.

I use play services 15.0.1 and this problem exists !

@samtstern : It would be great if you could provide an update on this issue. I'm baffled that Google is taking so long to fix such a high priority issue which is not allowing the first time users to use the app. I'm sure this is being looked into but at least ETA can help us manage the expectations and behavior of real paying users on our app.. Also it would be highly appreciated if you or your team has been able to come up with any workaround whatsoever to unblock the huge set of users affected by this.

@shahankitt we have a fix coming but not a workaround that works.  As I said, this has to be rolled into a new Google Play services release.  It's a big shame, but releasing Google Play services means rolling out a new app to literally a billion devices (or more!) so it's not something that happens quickly at all.  I can't share a timeline right now.

@samtstern
Until we get release update from google, here is the another work around by which I got solution .
As we know onActivityResult() does not called only when user add new account, but onRestart() and start() method get called.
Below is the code to open google concent screen to picked up account or add new account.
Intent signInIntent = loginHandler.mGoogleSignInClient.getSignInIntent();
activity.startActivityForResult(signInIntent, RC_GET_TOKEN);
Before calling above code I keep currently registered google accounts count. i.e 3 accounts registered in my device.
Once user complete add new account process, onStart() method will get call and here I checked again google account count by below code:
Account[] googleAccounts = AccountManager.get(activity).getAccountsByType("com.google");

if (googleAccounts != null && googleAccounts.length > 0) {
    if (lastGoogleAccounts == 0) {
        lastGoogleAccounts = googleAccounts.length;
    } else {
        if (googleAccounts.length > lastGoogleAccounts) {
         // do login

}
if new count is > last count, it means new account is registered and redirect to home screen.
Hope this will help you.


Problem opening calendar in mobile browser

When I open my system in the computer browser it appears normal data, now when it is in the mobile browser (IOS was what I tested), it does not make the background color on the date and neither appears the data when clicked.
What can be done?

@jefvonmuhlen Could you remote debug the browser in your device to see what error is printed out in the console?
If the issue is only related to Safari, sometimes it's because of below problem
https://stackoverflow.com/questions/4310953/invalid-date-in-safari

@twinssbc it is not generating any errors on the console. Any idea what I need to change?

I found this error on the safari:
Error: undefined is not an object (evaluating 'rows[startIndex].events')
_onDataLoaded@http://<IP_ADDRESS>:8084/SalaoWeb/componentes/rcalendario/js/calendar-tpls.js:974:64
onEventSourceChanged@http://<IP_ADDRESS>:8084/SalaoWeb/componentes/rcalendario/js/calendar-tpls.js:88:43
http://<IP_ADDRESS>:8084/SalaoWeb/componentes/rcalendario/js/calendar-tpls.js:30:46

Could you debug to see what's the value of startIndex?
And what does your event look like? What's the value in the startTime and endTime fields?

I tried to debug but could not find the problem. But everything indicates that it is the Date format.


Added openstack services details to configuration for webui

webui need endpoint details for all openstack services which was hardcoded in
webui configuration which was causing issue as the protocol was hardcoded to
http where we use https. This is causing webui to fail. This patch fix that by
accepting them as params.

This is workiing even though test was timedout

build #480


Dev/ahn nath: Add social media icons with links to representative card

Issue: #295
🖼: Front-end
⚙: Back-end
🏗: Architecture
We have completed the following:
Process and implementation

[X] ⚙ Identify social media URLs from the identifiers property.
To identify social media URLs from the URLs I used Postman and chose: Instagram, Facebook, Twitter, and Youtube as my targets.
- [X] ⚙ Improve the back-end API schema to send back social media profiles in an array.
I am using a function that uses the “identifiers” attribute from the representative JSON object as an argument and process the item with a switch statement to get the relevant sites and apply filters as required. I get the social media name, the social media value (username), and set the social media icon to use for it on the front end (example: fa-instagram). Then the funciton returns the array as a new property of the representative JSON that will be sent to the frontend.
- [X] 🖼 Display icons for known social media platforms.
I have downloaded the FontAwesome library and have implemented it as specified in the official documentation. I felt that it was more practical than downloading svg files one by one, specially since we may be using more social media icons in the future.

Looking forward to your comments.

@paramsiddharth
Hi, Param. Thanks.
Yes, I have tested it several times, normally, with zip codes corresponding to Washington. I cannot upload a screenshot since I have internet connection issues right now, and it prevents me from connecting to Codespaces. Tomorrow I will be at a place with stable and high speed connection and will attach it. If I happen to have the opportunity today, I will do so as well.

@paramsiddharth
The screenshots:
Postal code: 98104

Postal code: 32118


Matching if/else/endif select a wrong endif

I'm afraid regression happened and #122 no longer works correctly.
ifeq (1,2)

 ifeq (2,3)
  A := B
 else
  A := C
 endif

endif

Select the first endif, and it will be matched to the first ifeq instead of the last one. For some illustrations, see comments to #122.
This is the biggest issue for me now: I have a huge if...else...endif blocks, and I cannot rely on the plugin to correctly match ifeq and endif.

I've reverted the behavior, now only matching if/endif are highlighted. else keyword is never highlighted.
It seems that desired behavior is not supported by IntelliJ platform.

Thanks a lot!
I'm following the repo commits. Looks like you didn't push it 8)

Indeed. What I didn't forget though is to upload the plugin to the Plugin Marketplace.


Linked multicanvas support

🚀 Feature
A number of issues and people have requested multi canvas support, for example #561  and #662 representing two major use cases - #561 is something like our grid mode but now with linked cameras so that zooming in on one spot in one canvas causes the same zoom on all the canvas. In this mode you could still have one global dims model, each layer would get assigned exactly to one canvas, and you could have one global set of QtDims sliders that sliced through all the layers simultaneously in the same way. Supporting this wouldn’t be much of a breaking change and should be relatively straightforward.
#662 would enable simultaneous ortho views + 3D view (optional). Here you need a different dims slider for each of the 3 orthoviews and no dims slider for the 3D rendering. You also might still want to still have some global dims sliders, say if you we looking at ortho views of a volumetric time series and you wanted to always look at single time slice at in all the canvases. It’s a little unclear how we should best support this.
Another option is that people just want to look at different layers side by side with fully independent control of camera and sliders. I’m not sure if we want to support this (why not then have a tabbed viewer, or multiple viewers), but on the other hand why prevent it if people want it, and architecting the system for this generality could future proof us for new features, prevent overfitting to our biases and special casing. I’m inclined to give this a level of generality a go, and then we’d do the linking (and possibly removing of duplicate sliders etc) after.
Another thing we should also consider at this point are things like our 1D time series and histogram plots in #675. We have discussed whether these should be considered as “layers” or something special, and whether they should live in “DockWidgets” or the “MultiCanvas mode”. One thing to consider is if the mulitcanvas mode can accept “DockWidgets” so you could rearrange a grid of the “DockWidgets”. Clearly these objects would not have the same type of camera and dims slicing, but you might want the to be updatable from the dims model (i.e. when slider moves change the histogram). That might be custom code that differs use case by use case, but we still want to make sure it is possible.
To me, some big questions we need to answer first are - how generic do we make the multicanvas stuff? As noted above, I prefer starting with as generic as is still simple and then if we need to reduce functionality we can. That would mean that inside the main viewer widget there would be a QGridLayout where we can put whatever widgets we like and maybe DockWidgets so they can easily be rearranged. I think I would also still like to keep option for a global dims slider at the bottom, but it might be simpler to drop that too and just have each canvas have all the sliders they need right under them and then sync elsewhere. Certainly the idea of turning a QHBoxLayout with a vispy canvas + QtDims model into a reusable widget that can be moved around has some appeal too (say called QtCanvas). You could think of the main QtViewer as containing one of those QHBoxLayouts right now in the middle.
Next question is how do we think about the dims model when there can now be multiple views on the same layer. One option if to have viewer.dims become a list with one dims model (and QtDims) for each canvas. This is quite a simple, though major breaking change. Another option is we keep one dims model, but turn things like order, ndisplay, point and indices into lists. I’m not quite as sure about that one though.
I think then I’d also want to ability to have “layer copies” where data and most properties are shared but the _data_view can be different and each copy has its own vispy (this is maybe easier when each layer just has one Dims model). This would mean the layer would appear in the layer list each time it was in a canvas and each time with its own thumbnail for the different view. Do people like this idea, or is that weird? Again imagine the orthoview case. Would you like to see the layer just once or 3 or 4 times in the layers list. If just once then we might want to go with one Dims model that has lists inside. If we want 3 or 4 times we might want to go with layer copies.
We’d need an api to create multiple canvases, assign layers to each canvas. If a layer appears in multiple canvases it now gets multiple views and so it’s dims model expands in one of the ways described above, and we then need a way to link dims models and cameras across views as desired.
I think this actually all sounds pretty reasonable and I’d like to get going on it after we get this last burst of styling / widget PRs in. I think I’d start off with the changes to multicanvas and QGridLayout and ability to assign layers to different canvases while still having a global dims model. This will be not be too much of a breaking change and could still happen in 0.2. We can then think more about the orthoview case and different Dims models for each canvas which might need to come in an 0.3 release.
What are peoples thoughts?

there's a lot here, so I might have missed some things, but some immediate thoughts:

#662 would enable simultaneous ortho views + 3D view (optional). Here you need a different dims slider for each of the 3 orthoviews and no dims slider for the 3D rendering. You also might still want to still have some global dims sliders, say if you we looking at ortho views of a volumetric time series and you wanted to always look at single time slice at in all the canvases. It’s a little unclear how we should best support this.

I think ortho-views might be the most obvious/direct application for multi-canvas.  If I understand what you're proposing, it's the same I had been imagining: an additional slider for each new orthoview ... so a 3D image (in 2D view) would have 3 sliders instead of 1, (and each slider would affect the view of 2 of the three orthview canvases).  In 3D view, the sliders would all disappear, and the orthoview would be represented as different camera angles on the same scene.  (alternatively... in 3D view, the sliders could stay and we could do something like the quad view in paintera ... which I particularly like for 3D annotation).

Another thing we should also consider at this point are things like our 1D time series and histogram plots in #675. We have discussed whether these should be considered as “layers” or something special, and whether they should live in “DockWidgets” or the “MultiCanvas mode”. One thing to consider is if the mulitcanvas mode can accept “DockWidgets” so you could rearrange a grid of the “DockWidgets”.

this might just be semantics, but I wouldn't try to somehow allow for our actual QtViewerDockWidget to be added to the canvas... rather, in the case of the 1D plots in #675 for instance, we might want to have multiple graphs next to each other.  And in that case it's not the Qt DockWidget we're duplicating, but the vispy PlotWidget (SceneCanvas).

Next question is how do we think about the dims model when there can now be multiple views on the same layer.

as long as the different views are strictly orthogonal, as in an orthoviewer, I don't think we need a different model at all, but if we're considering arbitrarily different oblique views on the same layer, then the possibilities become quickly unmanageable and the only thing I can picture would be a different dims object per view... but then the GUI representation becomes quickly challenging.  I think I'd need to hear an obvious use case to wrap my head around the application there.

just took a look at this and wanted to put my thoughts somewhere (not ready for a PR yet, but i think this is one direction it could go).
for an orthoviewer, inQtViewer, instead of using add_view on the central_widget, use add_grid (which makes a Vispy.scene.widgets.Grid) and add seperate views to the grid for XY, YZ, XZ:
        self.grid = self.canvas.central_widget.add_grid()
        self.viewXY = self.grid.add_view(row=0, col=0)
        self.viewYZ = self.grid.add_view(row=0, col=1)
        self.viewXZ = self.grid.add_view(row=1, col=0)

then in QtDims._update_display, all dimensions that have any representation in the orthoviewer (e.g. all three dimensions for a 3D stack) need to have their slider_widgets displayed.
The components.dims.Dims.displayed property also needs to be aware of whether we're showing multiple orthoviews, because the Dims.indices property will need return a slice for all dimensions if so.
layers.image.Image._set_view_slice() would then need to set not one, but three different self._data_views: one for each of the ortho-slices.  I think that probably jives well with the proposed datasource that @d-v-b is working on in #792:  the datasource would know how to return each of the three orthoviews given the dims.indices.  In other words, this line in the image _set_view_slice would be modified to retrieve all the needed slices from the datasource.
https://github.com/napari/napari/blob/9ba2e7f55a2bdbff340d84788c994c1237d1c444/napari/layers/image/image.py#L499
The corresponding VispyImageLayer would then want to maintain not one, but three separate ImageNodes (and each of those three nodes would need to have their parent assigned as the corresponding QtViewer.viewXY.scene, QtViewer.viewYZ.scene, etc...).  There would also be three different cameras to link up to the VispyImageLayer (QtViewer.viewXY.camera, QtViewer.viewYZ.camera, etc..).  It would be nice to link those three cameras as well, such that zooming on one view zoomed on all three views.
VispyImageLayer._on_data_change() would then need to assign each of the three views generated by the Image model  in _set_view_slice with the corresponding node.set_data method.
For the sake of efficiency, it would also be important not request a new data view on slider change for the axes that are not affected (i.e. the sliders that would have previously been hidden)

High level thoughts - leveraging the grid_view that is built into vispy definitely seems worth exploring. I'm not too familiar with it, so need to learn more.
I'm now really coming around to the though that sliders should always be at the bottom of the whole viewer inside the sliders widget, i.e. there will never be sliders located within the little grid windows, and we show all the sliders needed to interact properly with the displayed info. This means that we don't need to think as much about the GridLayout being at the Qt layout but can maybe use the grid_view mentioned above.
The comments about VispyImageLayer and Image are well taken, but we want this to work for all our layer types and so I'd love if we could figure out how to do this without actually having to make many changes to our individual layer models, but instead think about some automated wrapping that could work for all of them

any objection closing this issue to consolidate multicanvas effort to https://github.com/orgs/napari/projects/16?

any objection closing this issue to consolidate multicanvas effort to https://github.com/orgs/napari/projects/16?

I think ok to close. I guess philosophy here is that with the new project board we have consolidated links to all the old issues and we should close the old ones as they aren't likely to be sites of continued discussion and it will make it easier to deal with the new issues and discussions that are coming in

@potating-potato @sofroniewn I just realised that multi-scale and multi-canvas (and I'm not sure if anything else) are being consolidated in a single project. These are quite orthogonal (pun not intended) concerns, and I think they should be separate projects.

I'm fine with either 3 projects or one project as long as if we split into 3 we're taking into consideration that some of the changes we make for one might have big impacts for the others. As @potating-potato says what they have in common is that they all require changes to our slicing model and it could be that we make a single change to slicing that will enable all of them.


Improve the GUI or use anything else other than tkinter

after all seems the code only for developers, as you not showing the steps to use it and how to deploy it

after all seems the code only for developers, as you not showing the steps to use it and how to deploy it

Everything is mentioned in Readme.

use customtinker


Interested in contributing GitHub wiki-related actions

outdated
Hello @bubkoo! 👋
I was wondering if this organization (@wow-actions) would consider creating a new wow-actions/publish-to-github-wiki or similar repo to publish in-source Markdown docs to GitHub wiki
The reason why I ask: I'm not a very good GitHub actions guy. @wow-actions is. Hence, it might be cool for you to bring an existing GitHub Action into the fold or make a new version that solves the goal of publishing in-source markdown to a GitHub wiki.
Why this is better than relying on existing actions: Giving the wow-actions/* organization scope to something is almost like making it an "official" GitHub Action. In fact, the wow-actions/something (I forget which one) is used in the GitHub tutorial (the demo repo walkthrough)! That's how I stumbled across this awesome GitHub Actions collection! ❤ Having a wow-actions/publish-to-github-wiki or similar (wow-actions/github-wiki, etc, doesn't matter) would legitimize it (I hope) with this @wow-actions' prestige as "the place for cool actions".
Here's a list of prior art that I found:

https://github.com/marketplace/actions/wiki-sync
https://github.com/marketplace/actions/wiki-action
https://github.com/marketplace/actions/update-wiki
https://github.com/marketplace/actions/wiki-update
https://github.com/marketplace/actions/github-wiki-sync-action
https://github.com/marketplace/actions/publish-to-github-wiki
https://github.com/marketplace/actions/wiki-page-creator-action
https://github.com/marketplace/actions/github-wiki-action
https://github.com/marketplace/actions/github-docs-to-wiki
https://github.com/marketplace/actions/publish-readmes-to-github-wiki
https://github.com/marketplace/actions/external-repo-wiki-sync-action
https://github.com/marketplace/actions/bi-directional-wiki-sync-action
https://github.com/marketplace/actions/update-wiki-with-php-project-documentation
https://github.com/marketplace/actions/pencil_pusher

I'm just posing this as a suggestion. Thanks for your time reading this! 👋

I've mentioned this issue in https://github.com/Andrew-Chen-Wang/github-wiki-action/discussions/19

I think that this isn't likely to happen. 🤷♂ Closing.

Hello again @bubkoo! 👋 I've revived my interest in this idea because, guess what, the GitHub wiki action that I have been trying to improve just isn't enough. I think there need to be four separate actions to achieve "maximum goodness". Thus, I'm shopping around multiple GitHub Actions -related organizations to see if they're interested in adding my projects under their umbrella. This appears to be a single-contributor @actions-ecosystem organization, so sorry if I'm in the wrong spot here.
I am interested in adding GitHub Actions that would make it easy to sync a GitHub in-source folder like /wiki/*.md to the actual "wiki" tab on GitHub. This is useful for users who want to possibly:

Autogenerate documentation but don't want to put it on GitHub Pages, so they put it on a wiki instead
Allowing the normal GitHub flow of PRs + merges for wiki changes
Letting users auto-generate other things like build data and post it to the wiki
etc.

Particularily, there are 4 "things" that I see being useful to have actions for so that you can do something like this:
on:
  push:
    branches: "main"
    paths: wiki/**
jobs:
  source-to-wiki:
    runs-on: ubuntu-latest
    steps:
      - uses: actions/checkout@v3
      - uses: wow-actions/source-to-wiki-links@v1
      - uses: wow-actions/upload-wiki@v1

on:
  gollum: null
  schedule:
    - cron: "0 0 * * *"
jobs:
  wiki-to-source:
    runs-on: ubuntu-latest
    steps:
      - uses: actions/checkout@v3
      - uses: wow-actions/download-wiki@v1
      - uses: wow-actions/wiki-to-source-links@v1
      - uses: EndBug/add-and-commit@v9

source-to-wiki-links: Rewrites links like ./Hello.md to be ./Hello since GitHub wikis don't do file extensions; also renames README.md to Home.md
(publish|push|upload)-wiki: Pushes current folder or subfolder to the GitHub wiki
(download|clone|pull)-wiki: Pulls the GitHub wiki to the current folder or sub folder
wiki-to-source-links: Rewrites links like ./Hello to ./Hello.(md|markdown|mdown,etc) to work in source control; also renames Home.md to README.md

So far, I've got 2/4 repos ready to just hit transfer on that are "working"!
https://github.com/jcbhmr/preprocess-source-for-github-wiki
https://github.com/jcbhmr/preprocess-github-wiki-for-source


chore: generating eni limits for missing aws instances

Please ensure your pull request adheres to the following guidelines:

[X] For first time contributors, read Submitting a pull request
[ ] All code is covered by unit and/or runtime tests where feasible.
[X] All commits contain a well written commit description including a title,
description and a Fixes: #XXX line if the commit addresses a particular
GitHub issue.
[ ] If your commit description contains a Fixes: <commit-id> tag, then
please add the commit author[s] as reviewer[s] to this issue.
[X] All commits are signed off. See the section Developer’s Certificate of Origin
[X] Provide a title or release-note blurb suitable for the release notes.
[X] Thanks for contributing!

Cilium does not have ENI limits defined for some AWS instance types.
Used aws cli command from limits.go file:
AWS_REGION=us-east-1 aws ec2 describe-instance-types | jq -r '.InstanceTypes[] | "\"\(.InstanceType)\": {Adapters: \(.NetworkInfo.MaximumNetworkInterfaces), IPv4: \(.NetworkInfo.Ipv4AddressesPerInterface), IPv6: \(.NetworkInfo.Ipv6AddressesPerInterface), HypervisorType: \"\(.Hypervisor)\"},"'  | sort | sed "s/null//"
Added
c7g.metal
m6idn.12xlarge
m6idn.16xlarge
m6idn.24xlarge
m6idn.2xlarge
m6idn.32xlarge
m6idn.4xlarge
m6idn.8xlarge
m6idn.large
m6idn.xlarge
m6in.12xlarge
m6in.16xlarge
m6in.24xlarge
m6in.2xlarge
m6in.32xlarge
m6in.4xlarge
m6in.8xlarge
m6in.large
m6in.xlarge
m7g.12xlarge
m7g.16xlarge
m7g.2xlarge
m7g.4xlarge
m7g.8xlarge
m7g.large
m7g.medium
m7g.metal
m7g.xlarge
r6idn.12xlarge
r6idn.16xlarge
r6idn.24xlarge
r6idn.2xlarge
r6idn.32xlarge
r6idn.4xlarge
r6idn.8xlarge
r6idn.large
r6idn.xlarge
r6in.12xlarge
r6in.16xlarge
r6in.24xlarge
r6in.2xlarge
r6in.32xlarge
r6in.4xlarge
r6in.8xlarge
r6in.large
r6in.xlarge
r7g.12xlarge
r7g.16xlarge
r7g.2xlarge
r7g.4xlarge
r7g.8xlarge
r7g.large
r7g.medium
r7g.metal
r7g.xlarge
Adding eni limits for missing aws instances of families `c7g`, `m6idn`, `m6in`, `m7g, `r6idn`, `r6in`, and `r7g`

/test

Required reviews are in, all CI jobs are good. Marking this ready to merge.


Update to Angular 5.0.0 final when officially released

waiting for #51

Waiting for #59

I started a new project called 'angular-cli-skeleton' here: https://github.com/Ks89/angular-cli-skeleton
I want to deprecate this project in January 2018.


Add json metadata to nova barclamp for 2c scenario

It's missing in QA scenario and causing builds to fail.

+1

+1

+1

Not tested by CI so merging...