Bandit with python 3.6 cannot be installed

Describe the bug
Installing bandit with python 3.6 throws an error.
Reproduction steps
$ ~/python36/bin/python -m venv venv

$ venv/bin/python -V
Python 3.6.5 :: Anaconda, Inc.

$ venv/bin/pip install bandit
Collecting bandit
  Cache entry deserialization failed, entry ignored
  Cache entry deserialization failed, entry ignored
  Downloading https://files.pythonhosted.org/packages/1b/b7/be70ee3cc87607ffc474d95ca0ce4d06c2fcad8163cc6b47a99470f09826/bandit-1.7.2-py3-none-any.whl (113kB)
    100% |████████████████████████████████| 122kB 1.9MB/s
bandit requires Python '>=3.7' but the running Python is 3.6.5

### Expected behavior

I understand that python 3.6 is end of life, but I would have expected an older version of bandit to be installed and work
Currently what it looks like is that it is downloading bandit==1.7.2 and that is not working with python 3.6
Which is pretty weird

### Bandit version

1.7.2

### Python version

3.6

### Additional context

I still have some CI setups that use the older version of python
Yes, even though it is EOL... (I have limited influence in how much i can encourage my users to more to py 3.7+)

After discussing with some folks at pantsbuild - I realized the issue was pip version. When I create a venv - the pip version is quite old by default
$ ~/python36/bin/pip -V
pip 21.0.1
$ venv/bin/pip -V
pip 9.0.3

Doing: venv/bin/pip install -U pip got me pip 21.3.1 which works fine


API Requests

What would you like to be added
API Documentation.
Why is this needed
To Create own load Testing/testing microservices
Additional context
I want to use API requests. Made a post request to this endpoint "/api/v1/users/login" with the following payload  {"username": "fdse_microservice", "password": "111111"}. It throws error 400, message":"JSON parse error: Unrecognized token 'username': was expecting ('true', 'false' or 'null');
I'm not sure what fields should I use or not. Any help will be appreciated. thanks.

Hi Rajib! We created a tool (https://github.com/pptam/pptam-tool) that uses locust.io to do load test on the trainticket application!  We use 2 machines, one to drive the load test, one to setup trainticket. We deploy train ticket using docker, perform the load test using locust.io, and then collect the data. If you are just interested in the API calls, have a look at https://github.com/pptam/pptam-tool/blob/master/design_trainticket/locustfile.py!

Thank you very much. That's what I was looking for. I also need to do the load test and very much interested to try your system. I deployed Train Ticket in the K8S cluster.

You can have a look at https://github.com/pptam/pptam-tool/blob/master/installation/Installation_full.md and try to install it. Probably something will not work since we are still working on this framework - then drop me a mail at<EMAIL_ADDRESS>:)

Well - if you just want to do a load test on an already deployed installation, then our setup is much easier... I'll add this point to our documentation!

Your tools are great. I'll try the load test first. If I face any issues, I have your email. :).  "I'll add this point to our documentation!" - that would be wonderful.


kpod pull needs to shutdown the runtime

Since kpod is using the new runtime code it needs to call
Shutdown, when it is finished to make sure the store is
cleaned up.
Signed-off-by: Daniel J Walsh<EMAIL_ADDRESS>

@umohnani8 PTAL, I think this could be causing your problem with the tests.

@mheon PTAL

LGTM

[retest]

LGTM, let's merge once CI passes

LGTM, one question that I wouldn't hold this review for.

The ones using getStore() handle this behind the scenes, but when we use libpod.Runtime or the older libkpod.Server, you need to call Shutdown.

@rhatdan why not just merge my pull PR which already has this?

@baude Link?

@baude patch included this fix.


Describe the feature you'd like A clear and concise description of what you want to happen.  Describe alternatives you've considered A clear and concise description of any alternative solutions or features you've considered.  Additional context Add any other context or screenshots about the feature request here.Describe the feature you'd like A clear and concise description of what you want to happen.  Describe alternatives you've considered A clear and concise description of any alternative solutions or features you've considered.  Additional context Add any other context or screenshots about the feature request here.

Describe the feature you'd like
A clear and concise description of what you want to happen.
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
Additional context
Add any other context or screenshots about the feature request here.

#1937

#2147 #483 #647 #648 #654 #473 #644 #575 #646


Adds some status info from any thermostats

Our house has the ADT Smart Thermostat, which is a rebranded Alarm Dot Com thermostat. I found that ADT's similar API provides access to the thermostat data, and extended my local copy of this plugin to expose some of its information.
The resulting sensor_status looks like:
...Bedroom is Closed, System is Closed, Thermostat_ambientTemp is 75.0, Thermostat_coolSetpoint is 76.0, Thermostat_fanMode is 0, Thermostat_heatSetpoint is 69.0, Thermostat_humidityLevel is 44.0, Thermostat_state is 3

Seems fine to me, but I'm not sure if everyone's portal has the thermostat section. Maybe add the thermostat option as an optional parameter to async_update()?
Something like:
async def async_update(self, thermostats=False):
and then test for thermostats before loading the thermostat data.
We can pass thermostats in from the yaml to the custom component to the library.

Oh interesting, I would have assumed it would just return an empty list.
I like that the configuration for this component is very minimal, and I don't want to complicate the config with an additional flag. The REST call to fetch data about the main system also returns data about the available devices. Instead of a user-provided flag, this response could be used to automatically set a flag to enable the thermostat fetching only if any thermostats are found in the main system information. Can I implement that instead of a user flag?

Oh interesting, I would have assumed it would just return an empty list.
I would think so too, but it's undocumented and we don't know. We saw that the arming options available in the portal and to REST call can vary: https://github.com/uvjustin/alarmdotcomajax/issues/15#issuecomment-691482336

I like that the configuration for this component is very minimal, and I don't want to complicate the config with an additional flag. The REST call to fetch data about the main system also returns data about the available devices. Instead of a user-provided flag, this response could be used to automatically set a flag to enable the thermostat fetching only if any thermostats are found in the main system information. Can I implement that instead of a user flag?

That sounds fine. Are there any other sensors that are exposed?
The other thing to think about is whether we want to send back the info to HA together with the zone status or separate it out. I agree with you on keeping it simple (I don't even use the sensor states myself) and would prefer not to make many changes, but it is probably cleaner if we do take out the temperature status.
Just out of curiosity, why do you have the thermostats set up through ADC? Wouldn't it be easier to hook them into HA directly? Is it not possible as they are somehow paired to the ADT hub?

I apologize for the delay!
I've updated the PR to use this detection logic.
I agree with simplicity, and so I tried to make this change as small as possible.
I currently rely on this excellent ADC plugin to retrieve the sensor status easily from my ADT-secured house, and our ADT-branded ADC thermostat is part of this setup. I haven't yet tried to join the ZWave network, which would eliminate latency and probably provide more functionality, but that's a project for the future!
The main systems/system call (in my ADT Control setup) hints at a lot of possibilities:

accessControlAccessPointDevices
boilerControlSystem  (It's data is null, as opposed to an empty list like the rest)
cameras (I have 4)
commercialTemperatureSensors
fences (geofence definitions)
garageDoors
gates
geoDevices (I believe these are the 2 phones with the ADT app installed)
imageSensors (I have 1, somewhere?)
lights
locks (I have 1)
remoteTemperatureSensors
scenes (I apparently have 4)
sdCardCameras
sensors (I have 41)
shades
sumpPumps
thermostats (I only have the 1)
valveSwitches
waterMeters
waterSensors
waterValves
x10Lights

Sorry for the delay - it looks good to me. Although I won't be able to test the thermostat functionality, I will test it on my end just to make sure there are no problems with my setup.


Remote write compliance: TestRemoteWrite/otelcollector/NameLabel

The OpenTelemetry collector is not passing https://github.com/prometheus/compliance/tree/main/remote_write
TestRemoteWrite/otelcollector/NameLabel.
=== CONT  TestRemoteWrite/otelcollector/NameLabel
    labels.go:108:
        	Error Trace:	labels.go:108
        	            				main_test.go:101
        	            				main_test.go:65
        	Error:      	Should be true
        	Test:       	TestRemoteWrite/otelcollector/NameLabel
        	Messages:   	found zero samples for up{job="test"} = 0

Assign to me plz.

Blocked on PR #2993 waiting to be merged in Collector.

Test is passing with current collector and compliance tests main branches.


[BUG] calls to Pinpoint to send an SMS that return a failed response do not call Pinpoint callback

Describe the Bug
When sending an SMS with Pinpoint to a number that will not receive a text (e.g., opted out), the Pinpoint callback will not be triggered.
To Reproduce
Steps to reproduce the behavior:

opt out a phone number
make a request to send a text to that phone number
verify in the logs/Datadog that the callback has not been triggered

Expected Behavior
The callback should be triggered
Actual Behavior
The callback is not triggered
Relevant Story
https://github.com/department-of-veterans-affairs/notification-api/issues/273
Additional Context
The list of statuses from Pinpoint that will fail are in AwsPinpointClient._validate_response(): ['DUPLICATE', 'OPT_OUT', 'PERMANENT_FAILURE']. In theprovider_tasks.py's deliver_sms() method, call the callback in the catch block for NonRetryableException to fix this bug.

dev httpreq link: https://httpreq.com/cold-cherry-420zwgsz

We desk checked this defect. This can be closed.


Fix unused warnings as  is always defined but not always exported

Warnings like https://travis-ci.org/sodiumoxide/sodiumoxide/jobs/615562099#L255

Pull Request Test Coverage Report for Build 1207

0 of 0   changed or added relevant lines in 0 files are covered.
4 unchanged lines in 2 files lost coverage.
Overall coverage remained the same at 94.806%

Files with Coverage Reduction
New Missed Lines
%

crypto/aead/aead_macros.rs
1
99.38%

crypto/stream/stream_macros.rs
3
97.52%

Totals

Change from base Build 1206:
0.0%

Covered Lines:
3103

Relevant Lines:
3273

💛  - Coveralls

How about unit tests? The report showed 0.3% coverage decreasing https://github.com/sodiumoxide/sodiumoxide/pull/373#issuecomment-529317478

Maybe it would be better than hiding warnings?

Unit tests won't make these errors go away: Tests are compiled using #[cfg(test)] and hence a normal build of this library, e.g. as a dependency for just via cargo clippy, will still produce them.
This is dead code after all as non-public functions can't be used by anything outside the crate itself and adding tests does not change that. Or put differently, why test something that nobody using this library can actually use.
I think the cleaner way would be to not define the the internal functions at all. Maybe actually provide a generic method like
fn gen_random_nonce<N: Default + AsMut<[u8]>>() -> N {
  let mut n = N::default();
  randombytes_into(n.as_mut());
  n
}

instead of generating via a macro? But this would imply implementing AsMut<[u8]> for new_type!{nonce ..}...

How about unit tests? The report showed 0.3% coverage decreasing #373 (comment)

I can add more unit tests if you like but I have to admit I feel that they should have part of the original MR. Can you be specific which unit tests you'd like to see?

I feel that they should have part of the original MR

Good idea

Maybe actually provide a generic method like

I added another commit here that implements the generic method (c.f. the commit message for the details) and avoid defining any unused functions or extending the public interface of the nonce types. I feel like this is a nicer solution overall, but it admittedly is also more involved than the status quo.

Looks like the PR did not affect coverage

Looks like the PR did not affect coverage

Different from what I implied earlier, the loss of coverage in #373 was not because of the unused functions but due to the forwarding functions gen_nonce which still seem to be in need of additional unit tests as the unit tests generated by the macros do not cover them anymore. But then these unit tests would be copies of the ones created by the macros...

But then these unit tests would be copies of the ones created by the macros...

Actually, I'll try to add something that asserts on the nonce length which should actually be somewhat sensible and should fix the coverage.

But then these unit tests would be copies of the ones created by the macros...

Actually, I'll try to add something that asserts on the nonce length which should actually be somewhat sensible and should fix the coverage.

Did that. Also factored out the random nonce generation from the box_ and secretbox modules.

Ready to merge?

Ready to merge?

Yes, definitely. I was just adding more cosmetics. Sorry for the large number of force-pushes. I just try to get review as early as possible and then always find more nits to fix.

bors: r+


Difference between edm-xmap executable and Python binding xmap

@keichi , I'm trying to understand the difference between the edm-xmap executable and the python binding xmap. Are they different? In the documentation, it says the executable performs pairwise cross mapping using simplex projection. What does the python binding xmap do? Furthermore, how are the xmap and ccm python functions different?  Are the random samples drawn in the CCM function excluded from the embedding procedure?
A follow up question is why the python bindings run slower than the executable. Both appear to be using the GPU, but the executable calculates the all-to-all CCM for a 10,000 x 500 matrix in like 20 seconds whereas the python code takes forever (i didn't finish it). it's almost as if the python binding is only partially utilizing the GPU.
Originally posted by @davidgwyrick in https://github.com/keichi/kEDM/issues/40#issuecomment-1728557472

@davidgwyrick The edm-xmap executable and the Python xmap() function should produce the same output and performance. The backstory is that we initially had the edm-xmap executable only, but then we expanded the library and added Python bindings.
The differences between xmap() and ccm() are:

xmap() omits the convergence check part of CCM. CCM rho is calculated using the full library only, and random sampling. Our use case is to use xmap() to screen promising combinations and then test for convergence using ccm().
xmap() accepts multiple time series (tested up to 100K) and computes the CCM rho for every pair of time series (both directions). ccm() accepts only two time series. We also plan to implement an all-to-all version of ccm() but I didn't have the bandwidth.

The Python xmap() should perform the same as the executable. Can you run the following and paste the results?
import kedm
print(kedm.__file__)
print(kedm.get_kokkos_config())

I figured out where I went wrong in the installation process. after building the source code, I ran pip install -e . in the kEDM directory, rather than "pip3 install git+https://github.com/keichi/kEDM.git" . I think the -e option might have caused it to switch to no-gpu, Idk. It works now! SO FAST! like i'm so excited. My code is slow as a snail compared to this.
By checking for convergence you mean running different size libraries to see if the CCM rho changes? And if it does, that means the pair of timeseries may be causally interacting? Seeing your explanation about xmap vs ccm, I think I've always been doing just xmap then in my own code. I'm not sure if you're aware of this paper? [https://www.biorxiv.org/content/10.1101/2<IP_ADDRESS>4916v3.abstract]
How do you estimate the optimal embedding dimension of a time series? How we do it is by determining  the smallest embedding dimension that gives you the largest CCM value for a pair of timeseries. The thought being that you would expect that to the embedding dimension to change for different pairs of timeseries right. But based on the function, it looks like you're estimating the embedding dimension per timeseries, not per pair of timeseries?

Basically, what I want to figure out is how to utilize your ccm python binding function to obtain a cross-validated measure of ccm-rho. Are the random samples that are tested to calculate ccm-rho excluded from the embedding / nearest neighbor search? A similar question is what portion of the data is used as library when you give a library size smaller than the actual library time series?  Usually I do simple k-fold cross-validation, but here with the random samples I can't.
I apologize for all of the questions, but I am not proficient enough in cpp to understand the code really.

@keichi , hey I know you're probably super busy but if you could help me understand the following, I would greatly appreciate it.

The xmap function does not  give a option for the number of random samples to be tested, while ccm does. How is xmap evaluating the cross map skill then? Is it not cross-validated?

For the ccm function, are the random samples that are tested to calculate ccm-rho excluded from the embedding / nearest neighbor search?

A similar question is what portion of the data is used as library when you give a library size smaller than the actual library time series?

How do you estimate the optimal embedding dimension of a time series?


Improve SQL query regexp

Improve sql query validator pattern
Improve regexp
Improve regexp

Good stuff, great work! Being a regex far from trivial and not being able to add comments in a multiline regexp, how about throwing somewhere some notes about it? Unfortunately the schema file is in json, so it doesn't accept comments (and the $comment keyword was only added in Draft 7) so I don't have a good idea about where to add the notes

@rporres please take a look now.
I've changed the thing a bit as there are some cases where the previous expression was not working. Basically now, it supports both type of comments and '*' is possible to be used in values.
There are pretty complex queries in app-interface and I think a regexp is not the best approach to validate the syntax, so I think it's better to just focus this effort to add support for comments and not check the sql syntax in any way.


Create contributors UI

Issue

close #381

Overview (Required)

Implement View
Fetching contributors from api

Screenshot
https://user-images.githubusercontent.com/26338889/190031955-b36c787b-98ab-4045-b4c6-9b7635b5267f.mp4
Unresolved Problems

Bring back previous tab when  view state updated.
Not highlighting row when selected.

Sorry, I have mistaken in rebase the branch... so I close this PR.


Consider multiple sub types for Transaction

Right now we only have 1 Transaction class - and that's used for everything - but what instead if we were to introduce multiple Transaction sub classes - one for each specific functionality - this way we can build in Transaction specific handling into the node for different types of transaction

The upside to this is that we are free to make changes to the structure of things by adding a new Transaction type in the future which would not impact the historical chain
This would not be too hard to implement and would give us the option to release MainNet earlier - e.g. the first MainNet release could be just the basic blockchain without the dApp infrastructure - and future releases could gradually introduce features that bring a new Transaction type
In the event of us not getting the funding - this would enable us to go to Mainnet with pre-mine and then get listed on an exchange which would then provide cash for working on SushiChain

not at this time


why isn't gmail.new.get.thread_data() reliable?

Is there any way to ensure this returns a response other than undefined? it never seems available when i need it

gmail.new.get,thread_data() is only "guaranteed" to contain data for a thread which has been in view somehow, or was preloaded during Gmail-launch, and with gmail.js injected early enough to intercept this data.
If you want to "guarantee" that you have the relevant thread-data, you need to:

create a preloader for Gmail.js only, to ensure it gets loaded quickly
only request thread-data for threads you know to be visible to the end-user

That's about it. Is your extension within these bounds?


SyntaxError - Unmatched selector

I have using Webpack2, Pug, and ngx-translate-extract 2.3.4
Extracting failed on each rows in pug files.
Error:
/var/www/gtr-crm-front/node_modules/css-what/index.js:85
		throw new SyntaxError("Unmatched selector: " + selector);
		^

SyntaxError: Unmatched selector: (header="Confirmation", icon="fa fa-question-circle", width="425")

Pug file looks like:
p-confirmDialog(header="Confirmation", icon="fa fa-question-circle", width="425")

p-tabView

  p-tabPanel([header]="'common.deposits' | translate")

    div
      h3(class="panel-title") {{ 'common.deposits_assigns' | translate }}:

      div
        button(
          pButton,
          (click)="cancelDepositAssign()",
          [label]="'common.cancel' | translate"
        )

So it fails on first row. If i remove first row it will fail on second, third etc...
On version 2.3.2 it works properly.

Thanks, your solution solved the problem!

Should be fixed in next version


tests: adding a test for tree view

Hoping to show #25.

No, I don't. Is the file uproot-issue213.root?

No, it's uproot-Event.root. This branch:
>>> tree = uproot.open(skhep_testdata.data_path("uproot-Event.root") + ":T")
>>> tree["event/fTriggerBits/fTriggerBits.fAllBits"].interpretation
AsJagged(AsDtype('uint8'), header_bytes=1)
>>> tree["event/fTriggerBits/fTriggerBits.fAllBits"].interpretation.typename
'uint8_t[]'

Yes, for me that gives:
>>> tree = uproot.open(skhep_testdata.data_path("uproot-Event.root") + ":T")
>>> tree["event/fTriggerBits/fTriggerBits.fAllBits"].interpretation
AsJagged(AsDtype('uint8'), header_bytes=1)
>>> tree["event/fTriggerBits/fTriggerBits.fAllBits"].interpretation.typename
'uint8_t*'

It's technically the same, but an irritating difference. I could search&replace it out of the output if needed.

Hmmm. I'm following the path it takes through uproot.interpretation.identify.interpretation_of.

https://github.com/scikit-hep/uproot4/blob/8e3ab33c2d137079db53cd2c21b4c3ac7e1dcffc/src/uproot/interpretation/identify.py#L363
https://github.com/scikit-hep/uproot4/blob/8e3ab33c2d137079db53cd2c21b4c3ac7e1dcffc/src/uproot/interpretation/identify.py#L380
https://github.com/scikit-hep/uproot4/blob/8e3ab33c2d137079db53cd2c21b4c3ac7e1dcffc/src/uproot/interpretation/identify.py#L63
https://github.com/scikit-hep/uproot4/blob/8e3ab33c2d137079db53cd2c21b4c3ac7e1dcffc/src/uproot/interpretation/identify.py#L96
https://github.com/scikit-hep/uproot4/blob/8e3ab33c2d137079db53cd2c21b4c3ac7e1dcffc/src/uproot/interpretation/identify.py#L31
https://github.com/scikit-hep/uproot4/blob/8e3ab33c2d137079db53cd2c21b4c3ac7e1dcffc/src/uproot/interpretation/identify.py#L60 because fType is 51
https://github.com/scikit-hep/uproot4/blob/8e3ab33c2d137079db53cd2c21b4c3ac7e1dcffc/src/uproot/interpretation/identify.py#L425
https://github.com/scikit-hep/uproot4/blob/8e3ab33c2d137079db53cd2c21b4c3ac7e1dcffc/src/uproot/interpretation/identify.py#L432
https://github.com/scikit-hep/uproot4/blob/8e3ab33c2d137079db53cd2c21b4c3ac7e1dcffc/src/uproot/interpretation/identify.py#L446
https://github.com/scikit-hep/uproot4/blob/8e3ab33c2d137079db53cd2c21b4c3ac7e1dcffc/src/uproot/interpretation/identify.py#L462
https://github.com/scikit-hep/uproot4/blob/8e3ab33c2d137079db53cd2c21b4c3ac7e1dcffc/src/uproot/interpretation/identify.py#L470 and model_cls is AsArray(False, True, dtype('uint8'), ()), which has a typename of "uint8_t[]", so let's descend into parse_typename
https://github.com/scikit-hep/uproot4/blob/8e3ab33c2d137079db53cd2c21b4c3ac7e1dcffc/src/uproot/interpretation/identify.py#L1074
https://github.com/scikit-hep/uproot4/blob/8e3ab33c2d137079db53cd2c21b4c3ac7e1dcffc/src/uproot/interpretation/identify.py#L1101 and tokens is a list of match objects corresponding to "unsigned", "char*"
https://github.com/scikit-hep/uproot4/blob/8e3ab33c2d137079db53cd2c21b4c3ac7e1dcffc/src/uproot/interpretation/identify.py#L563
https://github.com/scikit-hep/uproot4/blob/8e3ab33c2d137079db53cd2c21b4c3ac7e1dcffc/src/uproot/interpretation/identify.py#L617

And that's how we get the final interpretation on Linux. Wait a minute: you're saying you see the same interpretation, just a different typename? Let me look into that...

int* and int[] are the same, so if it’s just (expected) differences in the underlying implementation, I can just always replace one with the other in the test.

Back to where we have a AsArray(False, True, dtype('uint8'), ()) on https://github.com/scikit-hep/uproot4/blob/8e3ab33c2d137079db53cd2c21b4c3ac7e1dcffc/src/uproot/interpretation/identify.py#L470, the next step is that this goes into AsObjects, which then gets simplified:
https://github.com/scikit-hep/uproot4/blob/8e3ab33c2d137079db53cd2c21b4c3ac7e1dcffc/src/uproot/interpretation/identify.py#L489-L493

simplify: https://github.com/scikit-hep/uproot4/blob/8e3ab33c2d137079db53cd2c21b4c3ac7e1dcffc/src/uproot/interpretation/objects.py#L239
enters https://github.com/scikit-hep/uproot4/blob/8e3ab33c2d137079db53cd2c21b4c3ac7e1dcffc/src/uproot/interpretation/objects.py#L247, but it CannotBeStrided
it's not AsString, but it is AsArray: https://github.com/scikit-hep/uproot4/blob/8e3ab33c2d137079db53cd2c21b4c3ac7e1dcffc/src/uproot/interpretation/objects.py#L273
it has one header_bytes (due to the speedbump) and the values are a NumPy dtype, so we get to https://github.com/scikit-hep/uproot4/blob/8e3ab33c2d137079db53cd2c21b4c3ac7e1dcffc/src/uproot/interpretation/objects.py#L288 That's how the final interpretation becomes AsJagged. The typename in the output comes from the self._model.typename, which is "uint8_t[]" on Linux.

So how did the self._model get that typename? Following that path now...

The reason I'm deep-diving into this is that there shouldn't be any platform-dependent difference. It's disturbing me. The ROOT file is the same set of bytes, and if there's a platform-dependency in how we grab those bytes, I want to know about it.
(Like all of Window's int32 differences. Knowing about them prevents future bugs.)

The model, which has a typename that gets passed to the simplified final interpretation, is created by evaluating the string made here:
https://github.com/scikit-hep/uproot4/blob/8e3ab33c2d137079db53cd2c21b4c3ac7e1dcffc/src/uproot/interpretation/identify.py#L620-L622
which is exactly
uproot.containers.AsArray(False, True, numpy.dtype("u1"))

That should be entirely platform-independent: the only variable going into making that string is header, which must be "True" because you see the same number of header bytes (1, not 0).
If I evaluate
>>> import uproot, numpy
>>> uproot.containers.AsArray(False, True, numpy.dtype("u1")).typename
'uint8_t[]'

on Linux, I get the brackets, as you can see above. On any platform, this has to produce brackets, not a *, because the AsArray.typename is defined like this:
https://github.com/scikit-hep/uproot4/blob/8e3ab33c2d137079db53cd2c21b4c3ac7e1dcffc/src/uproot/containers.py#L628-L631
Before entering simplify (this block), is your model_cls not an AsArray? Could it possibly be an AsPointer? That's the only type that has a typename with a "*" in it.

Maybe if regular expressions act a little differently:
>>> import re
>>> _tokenize_typename_pattern = re.compile(
...     r"(\b([A-Za-z_0-9]+)(\s*::\s*[A-Za-z_][A-Za-z_0-9]*)*\b(\s*\*)*|<|>|,)"
... )
>>> list(_tokenize_typename_pattern.finditer("unsigned char*"))
[
    <re.Match object; span=(0, 8), match='unsigned'>,
    <re.Match object; span=(9, 14), match='char*'>,
]

If the tokenizer results in three tokens, corresponding to "unsigned", "char", and "*", rather than the two above, that would make the model resolve into an AsPointer and a dtype, rather than an AsArray and a dtype. If that's the case, I want to be sure that we use regular expressions in a platform-independent way in the future. (The intended behavior is what Linux is doing, but that's because it was developed on Linux.)

>>> import uproot, numpy
>>> uproot.containers.AsArray(False, True, numpy.dtype("u1")).typename
'uint8_t*'

Ahh, I was using uproot 4.0.11. Upgrading to 4.2.2 gives the 'uint8_t[]' answer!

Oh, okay. (I'm breathing a sigh of relief.) 4.0.11 may be very different from 4.2.2; there's a lot of versions in between. I don't know what change it might have been (probably not the parsing, I'd guess), but not something that I need to look into.


[WIP]analytics: Make stats of all realms accessible to server admins.

Currently, I've made things working.
@timabbott @rishig FYI.

Tests aren't updated/added yet.
Sorry for the delay actually in this comment https://github.com/zulip/zulip/pull/7568#issuecomment-378648704 I've misunderstood that we want the data of /stat to be served in the tables of /activity page, indeed I'm not sure whether we want to do this also or not?
Currently we can access chart stats of any realm at URL analytics/chart_data/realm/(?P<realm_str>[\S]+). Definitely, we need a page to direct to these links or we can have these links at /activity page(I think this clears my above confusion).

cool! I would put the links on /activity next to the email icon. Maybe a chart icon?

Sounds good, added the link:

small comment about the UI: we don't need another column for this. We can just have an empty column label, and then put both the mail icon and the pie chart icon together in each box.

@rishig @timabbott Updated the PR.

Tim: do we care for this page to be translated at all?

ah, I was confused by something in the diff. Agreed about not translating.

I fixed a couple things:

The target_realm_name variable fix was in the wrong commit
There was a typo in the last commit's spelling of "activity".

Merged, thanks @shubhamdhama!
I think one follow-up that we should do after this is take advantage of it to improve the analytics development process.  @rishig may have some thoughts, but ideally, we'd have a default user have is_staff enabled.
(1) populate_analytics_db we should probably run directly from the main populate_db project, and maybe hide the shylock user.
(2) We should make update the docs on analytics development to recommend using this feature
(The overall goal is to make "testing analytics" not require a bunch of manual setup)


Getting CLASSPATH from Apache Ant build file.

To make this works, we just need a task called classpath on the Ant
build.xml file, that returns the classpath needed to compile the current
file on Vim. It can be a fixed string or a command that returns a
combination of paths, like:
<?xml version="1.0"?>
<project name="neomake" default="build" basedir=".">
   <path id="compile.path">
      <pathelement location="a.jar"/>
      <pathelement location="b.jar"/>
      <pathelement location="c.jar"/>
   </path>

   <target name="classpath">
      <echo message="${toString:compile.path}"/>
   </target>
</project>

which will print:
$ ant classpath -f build.xml -S -q
/tmp/a.jar:/tmp/b.jar:/tmp/c.jar

that can be used on Neomake.

Removed the unused var.

Seems everything is fine now. :-)

Waiting for feedback from @wsdjeg.

I just test it, This PR works well for me. thanks for your work.
@blueyed I thinks this PR can be merged. :)


Marketing SMS trying again

Sorry I am a PHP n00b. Took me a minute to figure out how to get the tests working with the new file. Just checking to see if the Travis CI build will work now.

Sorry for triggering like 50 builds on the Travis CI. I don't know what I'm doing.


Use the children of component as the content instead of having a property

Components like Dialog, FileInput... have a "content" property, but instead the content elements should be children of the component.

Fixed in the new release

Fixed in the new release


fix bug in Insight.address()

fixes https://github.com/bitpay/bitcore/issues/1175

Coverage increased (+0.2%) to 91.76% when pulling 73d51758f9f4829f1e266c0d47a739b907de7d64 on maraoz:fix/bitcore/1175 into 512e7a66a3441202290a830545fb132388a01d6d on bitpay:master.

I added this test to be sure it works for strings and objects: https://github.com/bitpay/bitcore-explorers/pull/18/files#diff-9a1575ea9a5c3ae37016c0af0f68ac73R16

Coverage increased (+0.2%) to 91.76% when pulling aff8df7475d17470e9820fd5e263224c3b1e4355 on maraoz:fix/bitcore/1175 into 512e7a66a3441202290a830545fb132388a01d6d on bitpay:master.

LGTM (is there a button for that somewhere?)

Coverage decreased (-0.26%) to 91.3% when pulling d9bdbea29ba5af5e23b6d0927b3cc0b648368bd6 on maraoz:fix/bitcore/1175 into 512e7a66a3441202290a830545fb132388a01d6d on bitpay:master.

Coverage increased (+3.06%) to 94.62% when pulling b97487b3753d7a2392b3de9c903532f131b5dce4 on maraoz:fix/bitcore/1175 into 512e7a66a3441202290a830545fb132388a01d6d on bitpay:master.

Coverage increased (+3.06%) to 94.62% when pulling a2b59ad9854282bbb92013ff17a3c1d5b530d605 on maraoz:fix/bitcore/1175 into 512e7a66a3441202290a830545fb132388a01d6d on bitpay:master.


feat: fix update public plan proposal

Description

closes: #131
Tasks

[x] Change UpdatePublicPlanProposal logic to update plan type when there is a request
[x] Add test codes to cover the updated cases

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

[ ] Appropriate labels applied
[ ] Targeted PR against correct branch
[ ] Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
[ ] Code follows the module structure standards.
[ ] Wrote unit and integration
[ ] Updated relevant documentation (docs/) or specification (x/<module>/spec/)
[ ] Added relevant godoc comments.
[ ] Re-reviewed Files changed in the Github PR explorer
[ ] Review Codecov Report in the comment section below once CI passes

codecov patch is not reliable and there are many issues out there proposing it to be disabled.

https://github.com/kata-containers/runtime/issues/511
https://github.com/kata-containers/tests/issues/508
https://github.com/aws/amazon-vpc-cni-k8s/pull/1226/files


Add commands for Network Security Perimeter

This checklist is used to make sure that common guidelines for a pull request are followed.

For new extensions:

[ ] My extension description/summary conforms to the Extension Summary Guidelines.

About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
The precondition is to put your code inside this repository and upgrade the version in the pull request but do not modify src/index.json.

Network Security Perimeter

@microsoft-github-policy-service agree [company="Microsoft"]


maximumWaitingRuns add to designer GUI

Describe the Bug with repro steps
https://learn.microsoft.com/en-us/azure/logic-apps/logic-apps-workflow-actions-triggers#runtime-config-options
Some of our Logic Apps error when reading messages off a service bus queue as they are "waiting" longer than the max lock duration on the topics subscription settings (5 minutes).
We have resolved this by setting the maximumWaitingRuns to 1,
"runtimeConfiguration": {
"concurrency": {
"maximumWaitingRuns": 1,
"runs": 10
}
},
"type": "ServiceProvider"
}

However this can only be set in code view.  If any makes a change ion the designer and saves the workflow this setting isa lost.  Please could this be added to the GUI as it is a really useful feature.
What type of Logic App Is this happening in?
Standard (Portal)
Are you using new designer or old designer
New Designer
Did you refer to the TSG before filing this issue? https://aka.ms/lauxtsg
Yes
Workflow JSON
No response
Screenshots or Videos
No response
Browser
edge
Additional context
No response

Closing as a duplicate of https://github.com/Azure/LogicAppsUX/issues/4927, given that we're seeing more customers want this, I'm gonna go ahead and see if this can be implemented


New version: JetBrains.IntelliJIDEA.Community version 2023.3.4

[ ] Have you signed the Contributor License Agreement?
[ ] Have you checked that there aren't other open pull requests for the same manifest update/change?
[ ] This PR only modifies one (1) manifest
[ ] Have you validated your manifest locally with winget validate --manifest <path>?
[ ] Have you tested your manifest locally with winget install --manifest <path>?
[ ] Does your manifest conform to the 1.6 schema?

Note: <path> is the name of the directory containing the manifest you're submitting.

Microsoft Reviewers: Open in CodeFlow

Manual Validation ended with:

Hi @PckgrBot,
The installation isn't unattended. Is there an installer switch to have the package install silently?
(Automated response - build 745.)

[Policy] Needs-Author-Feedback

Close with reason: Duplicate of #138982;


set "available" status from system idle time

@RocketChat/core

Closes #86

Sets user to Available status if user is not idle on the system where the client is running.  If I can make it better, please let me know how.

I have only tested this on Windows, but the idle timer is supposed to work on Mac/Linux as well

@vitamindck thanks for contributing.  Will take a look!


chore: Update from _rust template

Pull Request Test Coverage Report for Build<PHONE_NUMBER>6
Warning: This coverage report may be inaccurate.
This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

For more information on this, see Tracking coverage changes with pull request builds.
To avoid this issue with future PRs, see these Recommended CI Configurations.
For a quick fix, rebase this PR at GitHub. Your next report should be accurate.

Details

0 of 0   changed or added relevant lines in 0 files are covered.
1 unchanged line in 1 file lost coverage.
Overall coverage decreased (-0.8%) to 74.227%

Files with Coverage Reduction
New Missed Lines
%

src/lib.rs
1
74.23%

Totals

Change from base Build<PHONE_NUMBER>8:
-0.8%

Covered Lines:
72

Relevant Lines:
97

💛  - Coveralls


Add support for signing JSON BOM files

Currently, only XML BOM's can be signed. Please add support for signing JSON BOM's.

Duplicate of #56


MongoDB connection errors

I've getting these errors very often of late.
Error: failed to connect to [mongo.onmodulus.net:27017]
      at null.<anonymous> (/mnt/data/1/node_modules/promised-mongo/node_modules/mongodb/lib/mongodb/connection/server.js:536:74)
      at EventEmitter.emit (events.js:118:17)
      at null.<anonymous> (/mnt/data/1/node_modules/promised-mongo/node_modules/mongodb/lib/mongodb/connection/connection_pool.js:150:15)
      at EventEmitter.emit (events.js:110:17)
      at Socket.<anonymous> (/mnt/data/1/node_modules/promised-mongo/node_modules/mongodb/lib/mongodb/connection/connection.js:516:10)
      at Socket.EventEmitter.emit (events.js:107:17)
      at net.js:436:14
      at process._tickCallback (node.js:343:11)

Also, there have been no new commits to promised-mongo of late. Mongojs has continued to update. In Promised mongo still under development?

I think that's your server refusing connections.  Sorry for the delays in development.


Manually set desired system architecture for cross compilation.

Motivation

It is a good practice to set system architecture manually for cross compilation. This was missing so I have added the supporting code.

Modifications
Change summary
Please describe what changes are included in this pull request.

Manually set desired system architecture for cross compilation.
Updated the SDK commit id to use latest code from SDK.
Updated Docker images with correct SDK flags
Statically linked aws library.
Linked OpenSSL and Crypto libraries.

Revision diff summary
If there is more than one revision, please explain what has been changed since the last revision.
Testing
Is your change tested? If not, please justify the reason.
Please list your testing steps and test results.

CI test run result:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Yah!!


Determine if keys can have gaps

Currently on publish, keys must be consecutive with no gaps in the rolling period.
We need to verify w/ the one device protocol how extended power off periods are handled. Are gaps backfilled before key upload or should we allow gaps by not overlap?
/assign @peetsasaki @flagxor
/kind question

Confirmed w/ Android team that if a phone is powered off there will be a gap in the intervals, but overlap is not allowed.
/assign


arangodb <IP_ADDRESS> Compile error

My Environment

ArangoDB Version:        <IP_ADDRESS>
Storage Engine:             RocksDB

Problem:
I tried to compile the source code of <IP_ADDRESS>, but found the following error. I am using gcc7.3.0:
/root/arangodb-<IP_ADDRESS>/arangod/Aql/InputAqlItemRow.h:65:41: error: temporary of non-literal type ‘arangodb::aql::SharedAqlItemBlockPtr’ in a constant expression
: _block(nullptr), _baseIndex(0) {}
^
In file included from /root/arangodb-<IP_ADDRESS>/arangod/Aql/InputAqlItemRow.h:29:0,
from /root/arangodb-<IP_ADDRESS>/arangod/IResearch/IResearchExpressionContext.h:28,
from /root/arangodb-<IP_ADDRESS>/arangod/IResearch/ExpressionFilter.h:28,
from /root/arangodb-<IP_ADDRESS>/arangod/IResearch/ExpressionFilter.cpp:24:
/root/arangodb-<IP_ADDRESS>/arangod/Aql/SharedAqlItemBlockPtr.h:32:7: note: ‘arangodb::aql::SharedAqlItemBlockPtr’ is not literal because:
class SharedAqlItemBlockPtr {
^~~~~~~~~~~~~~~~~~~~~
/root/arangodb-<IP_ADDRESS>/arangod/Aql/SharedAqlItemBlockPtr.h:32:7: note:   ‘arangodb::aql::SharedAqlItemBlockPtr’ has a non-trivial destructor
Deleted the constexpr of the constructor in file InputAqlItemRow.h and succeeded
Is it the version of gcc I am using?
Expected result:

https://github.com/arangodb/arangodb/blob/v<IP_ADDRESS>/VERSIONS has all the versions that were used for our binaries.

@Neverstop : we are internally building our binaries with g++ 9.2 and 9.3, which are known to work well.
Older versions of g++ lack support of some of the c++17 features we use, so things may not compile there.
IIRC, g++ 8.2 was also very capable and likely still works, but g++ 7 is likely too old already.

The problem seems to be solved, thus closing the ticket.


ROS 2 Humble Hawksbill - honister branch

Progress tracking:

[x] Update recipes in honister branch against humble rosdistro using superflore
[x] Fix recipes to build in honister
[x] Testing and validation

[x] tester 1 @vmayoral (writeup)
[ ] tester 2 @rosterloh
(looking for more beta testers)

This pull request has been mentioned on ROS Discourse. There might be relevant details there:
https://discourse.ros.org/t/branched-humble-call-for-beta-testing/25284/11

@vmayoral I'd love to be a beta tester

All right, as it is, recipes build for me in my workstation but there might some minor hiccups with the following recipes which required some manual hacking in my build directory:

cyclonedds
orocos-kdl-vendor

@rosterloh, feel free to share your feedback if you find time to test it.

Made a small writeup about how to reproduce things: https://news.accelerationrobotics.com/ros2-humble-yocto-petalinux/
Checked from my side, ready for review.

This pull request has been mentioned on ROS Discourse. There might be relevant details there:
https://discourse.ros.org/t/branched-humble-call-for-beta-testing/25284/20

This is not working for me,
First I had this problem with rosidl-adapter-native  and rmw-implementation_2.8.1-2.bb
ERROR: Nothing PROVIDES 'rosidl-adapter-nativerosidl-adapter-native' (but /media/jlamperez/DATA/Xilinx/Kria/2022.1/Vitis-Tutorials/Vitis_Platform_Creation/Design_Tutorials/01-Edge-KV260/ref_files/xilinx-kv260-starterkit-2022.1/project-spec/meta-ros/meta-ros2-humble/generated-recipes/rmw-implementation/rmw-implementation_2.8.1-2.bb DEPENDS on or otherwise requires it)
NOTE: Runtime target 'launch-ros' is unbuildable, removing...
Missing or unbuildable dependency chain was: ['launch-ros', 'rclpy', 'rmw-implementation', 'rosidl-adapter-nativerosidl-adapter-native']
NOTE: Runtime target 'demo-nodes-cpp' is unbuildable, removing...
Missing or unbuildable dependency chain was: ['demo-nodes-cpp', 'launch-ros', 'rclpy', 'rmw-implementation', 'rosidl-adapter-nativerosidl-adapter-native']
ERROR: Required build target 'petalinux-image-minimal' has no buildable providers.
Missing or unbuildable dependency chain was: ['petalinux-image-minimal', 'demo-nodes-cpp', 'launch-ros', 'rclpy', 'rmw-implementation', 'rosidl-adapter-nativerosidl-adapter-native']

Solved with this,
--- a/meta-ros2-humble/recipes-bbappends/rmw-implementation/rmw-implementation_%.bbappend
+++ b/meta-ros2-humble/recipes-bbappends/rmw-implementation/rmw-implementation_%.bbappend
@@ -2,7 +2,7 @@

 ROS_BUILD_DEPENDS:remove = "${@bb.utils.contains('ROS_WORLD_SKIP_GROUPS', 'connext', 'rmw-connext-cpp rmw-connextdds', '', d)}"

-ROS_BUILD_DEPENDS:append = "rosidl-adapter-native"
+ROS_BUILD_DEPENDS:append = " rosidl-adapter-native"
 ROS_EXEC_DEPENDS:append = " \
     rmw-fastrtps-cpp \
     rmw-cyclonedds-cpp \

And now with ament-cmake-test_1.3.1-2.bb
| -- Installing: blah/build/tmp/work/cortexa72-cortexa53-xilinx-linux/ament-cmake-test/1.3.1-2-r0/image/usr/share/ament_cmake_test/cmake/ament_add_test_label.cmake
| rm: cannot remove 'blah/build/tmp/work/cortexa72-cortexa53-xilinx-linux/ament-cmake-test/1.3.1-2-r0/image/home': No such file or directory
| WARNING: exit code 1 from a shell command.
ERROR: Task (blah/project-spec/meta-ros/meta-ros2-humble/generated-recipes/ament-cmake/ament-cmake-test_1.3.1-2.bb:do_install) failed with exit code '1'

This can be seen using petalinux-build -c ament-cmake-test . It seems that it can not remove an image/home directory, it is weird.
I don't have a solution.

The first patch doesn't make sense. Please provide a proper patch if meant as a contribution.
Your second issue seems specific to your build environment. I'd recommend doing this in a clean environment and with the right PetaLinux version.

The first is just a space.
I am using a fresh PetaLinux 2022.1 project. The project is created in /media/DATA/blah instead of in /home/blah  and the ament-cmakge-test is creating me a folder called /media/DATA/petalinux_project/build/tmp/work/cortexa72-cortexa53-xilinx-linux/ament-cmake-test/1.3.1-2-r0/image/media/DATA/petalinux_project/build/tmp/work/cortexa72-cortexa53-xilinx-linux/ament-cmake-test/1.3.1-2-r0/recipe-sysroot-native/usr/lib/python3.9/site-packages/ if my petalinux project was in /home it would work well and it would remove the pointed image/home folder but this is not created and instead I got iimage/media

I think the problem is this ament-cmake-test_%.bbappend

Same problem with rosidl-cmake_%.bbappend and this line

I am seeing a lot of bbappend recipes with same pattern
# ERROR: do_package: Files/directories were installed but not shipped in any package
#
do_install:append:class-target() {
    mkdir -p ${D}/usr/lib/python3.9/site-packages/
    mv ${D}${STAGING_DIR_NATIVE}/usr/lib/python3.9/site-packages/${ROS_BPN}* ${D}/usr/lib/python3.9/site-packages/
    rm -r ${D}/home

Can there be any other way for this?
I count more or less all this files are going to fail to me
./recipes-bbappends/rosidl-dds/rosidl-generator-dds-idl_%.bbappend:    rm -r ${D}/home
./recipes-bbappends/rosidl/rosidl-generator-cpp_%.bbappend:    rm -r ${D}/home
./recipes-bbappends/rosidl/rosidl-typesupport-introspection-c_%.bbappend:    rm -r ${D}/home
./recipes-bbappends/rosidl/rosidl-parser_%.bbappend:    rm -r ${D}/home
./recipes-bbappends/rosidl/rosidl-generator-c_%.bbappend:    rm -r ${D}/home
./recipes-bbappends/rosidl/rosidl-adapter_%.bbappend:    rm -r ${D}/home
./recipes-bbappends/common-interfaces/actionlib-msgs_%.bbappend:    rm -r ${D}/home
./recipes-bbappends/common-interfaces/std-msgs_%.bbappend:    rm -r ${D}/home
./recipes-bbappends/common-interfaces/diagnostic-msgs_%.bbappend:    rm -r ${D}/home
./recipes-bbappends/common-interfaces/geometry-msgs_%.bbappend:    rm -r ${D}/home
./recipes-bbappends/common-interfaces/visualization-msgs_%.bbappend:    rm -r ${D}/home
./recipes-bbappends/common-interfaces/sensor-msgs_%.bbappend:    rm -r ${D}/home
./recipes-bbappends/common-interfaces/shape-msgs_%.bbappend:    rm -r ${D}/home
./recipes-bbappends/common-interfaces/trajectory-msgs_%.bbappend:    rm -r ${D}/home
./recipes-bbappends/common-interfaces/std-srvs_%.bbappend:    rm -r ${D}/home
./recipes-bbappends/common-interfaces/nav-msgs_%.bbappend:    rm -r ${D}/home
./recipes-bbappends/common-interfaces/stereo-msgs_%.bbappend:    rm -r ${D}/home
./recipes-bbappends/rosidl-typesupport-fastrtps/rosidl-typesupport-fastrtps-cpp_%.bbappend:    rm -r ${D}/home
./recipes-bbappends/rosidl-typesupport-fastrtps/rosidl-typesupport-fastrtps-c_%.bbappend:    rm -r ${D}/home
./recipes-bbappends/rmw-dds-common/rmw-dds-common_%.bbappend:    rm -r ${D}/home
./recipes-bbappends/rcutils/rcutils_%.bbappend:    rm -r ${D}/home
./recipes-bbappends/rosbag2/rosbag2-interfaces_%.bbappend:    rm -r ${D}/home
./recipes-bbappends/rosbag2/rosbag2-py_%.bbappend:    rm -r ${D}/home
./recipes-bbappends/unique-identifier-msgs/unique-identifier-msgs_%.bbappend:    rm -r ${D}/home
./recipes-bbappends/example-interfaces/example-interfaces_%.bbappend:    rm -r ${D}/home
./recipes-bbappends/geometry2/tf2-py_%.bbappend:    rm -r ${D}/home
./recipes-bbappends/geometry2/tf2-geometry-msgs_%.bbappend:    rm -r ${D}/home
./recipes-bbappends/geometry2/tf2-kdl_%.bbappend:    rm -r ${D}/home
./recipes-bbappends/geometry2/tf2-msgs_%.bbappend:    rm -r ${D}/home
./recipes-bbappends/rcl-interfaces/action-msgs_%.bbappend:    rm -r ${D}/home
./recipes-bbappends/rcl-interfaces/lifecycle-msgs_%.bbappend:    rm -r ${D}/home
./recipes-bbappends/rcl-interfaces/rcl-interfaces_%.bbappend:    rm -r ${D}/home
./recipes-bbappends/rcl-interfaces/rosgraph-msgs_%.bbappend:    rm -r ${D}/home
./recipes-bbappends/rcl-interfaces/statistics-msgs_%.bbappend:    rm -r ${D}/home
./recipes-bbappends/rcl-interfaces/builtin-interfaces_%.bbappend:    rm -r ${D}/home
./recipes-bbappends/rcl-interfaces/composition-interfaces_%.bbappend:    rm -r ${D}/home
./recipes-bbappends/rosidl-python/rosidl-generator-py_%.bbappend:    rm -r ${D}/home
./recipes-bbappends/rosidl-typesupport/rosidl-typesupport-cpp_%.bbappend:    rm -r ${D}/home
./recipes-bbappends/rosidl-typesupport/rosidl-typesupport-c_%.bbappend:    rm -r ${D}/home
./recipes-bbappends/rosidl-typesupport/rosidl-typesupport-introspection-cpp_%.bbappend:    rm -r ${D}/home
./recipes-bbappends/message-filters/message-filters_%.bbappend:    rm -r ${D}/home

Some problems with rosbag2 and zstd-vendor
| Cloning into 'zstd-1.4.4'...
| fatal: unable to access 'https://github.com/facebook/zstd.git/': error setting certificate verify locations:  CAfile: /usr/local/oe-sdk-hardcoded-buildpath/sysroots/x86_64-petalinux-linux/etc/ssl/certs/ca-certificates.crt CApath: none
| Cloning into 'zstd-1.4.4'...
| fatal: unable to access 'https://github.com/facebook/zstd.git/': error setting certificate verify locations:  CAfile: /usr/local/oe-sdk-hardcoded-buildpath/sysroots/x86_64-petalinux-linux/etc/ssl/certs/ca-certificates.crt CApath: none
| Cloning into 'zstd-1.4.4'...
| fatal: unable to access 'https://github.com/facebook/zstd.git/': error setting certificate verify locations:  CAfile: /usr/local/oe-sdk-hardcoded-buildpath/sysroots/x86_64-petalinux-linux/etc/ssl/certs/ca-certificates.crt CApath: none
| -- Had to git clone more than once:
|           3 times.
| CMake Error at /media/DATA/petalinux-project/build/tmp/work/cortexa72-cortexa53-xilinx-linux/zstd-vendor/0.15.1-2-r0/build/zstd-1.4.4-prefix/tmp/zstd-1.4.4-gitclone.cmake:31 (message):
|   Failed to clone repository: 'https://github.com/facebook/zstd.git'
|
|
| ninja: build stopped: subcommand failed.
| WARNING: exit code 1 from a shell command.
ERROR: Task (/media/DATA/petalinux-project/project-spec/meta-ros/meta-ros2-humble/generated-recipes/rosbag2/zstd-vendor_0.15.1-2.bb:do_compile) failed with exit code '1'

Re-launched with a few other BSPs. Recipes throw no errors for me, bitbake task executor initiates nicely and the builds finish fine (after a few hours 🤣):
| meta-ros (Honister|Humble) in AMD ZCU104 | meta-ros (Honister|Humble) in NVIDIA Jetson AGX Xavier |
|----------|----------|
|  |  |

My test environment is this one,

Petalinux 2022.1 upgraded to the last 2022.1_update1 that supports kv260/kr260

petalinux-upgrade -u 'http://petalinux.xilinx.com/sswreleases/rel-v2022/sdkupdate/2022.1_update1/' -p 'aarch64'

BSP: xilinx-kv260-starterkit-v2022.1-05140151.bsp

petalinux-create --type project -s xilinx-kv260-starterkit-v2022.1-05140151.bsp

This Petalinux update contains meta-ros layers inside (foxy). I am removing it from bblayers.conf file and only adding meta-ros2-humble and also replacing the new meta-som-apps ros-tsn-pubsub for inheriting with ros_distro_humble.bbclass.
And start building with petalinux-build.
Then I am getting the errors pointed out above. The one that I don't know how to deal with is ca-certificates.crt CApath: none I would need to dig it more.
It seems that this Petalinux 2022.1_update doesn't like humble.

I've been able to pass the zstd-vendor doing some changes on the patch, now I am having same CAfile problem with orocos_kinematics_dynamics
| Cloning into 'orocos_kdl-507de66'...
| fatal: unable to access 'https://github.com/orocos/orocos_kinematics_dynamics.git/': error setting certificate verify locations:  CAfile: /usr/local/oe-sdk-hardcoded-buildpath/sysroots/x86_64-petalinux-linux/etc/ssl/certs/ca-certificates.crt CApath: none
| Cloning into 'orocos_kdl-507de66'...
| fatal: unable to access 'https://github.com/orocos/orocos_kinematics_dynamics.git/': error setting certificate verify locations:  CAfile: /usr/local/oe-sdk-hardcoded-buildpath/sysroots/x86_64-petalinux-linux/etc/ssl/certs/ca-certificates.crt CApath: none
| -- Had to git clone more than once:
|           3 times.
| CMake Error at /media/DATA/petalinux-project/build/tmp/work/cortexa72-cortexa53-xilinx-linux/orocos-kdl-vendor/0.2.2-2-r0/build/orocos_kdl-507de66-prefix/tmp/orocos_kdl-507de66-gitclone.cmake:31 (message):
|   Failed to clone repository:
|   'https://github.com/orocos/orocos_kinematics_dynamics.git'

This pull request has been mentioned on ROS Discourse. There might be relevant details there:
https://discourse.ros.org/t/ros-2-humble-hawksbill-released/25729/7

This pull request has been mentioned on ROS Discourse. There might be relevant details there:
https://discourse.ros.org/t/announcing-the-completion-of-meta-ros-milestone-17/25933/2

@panxxhub, @robwoolley, @jlamperez and @rosterloh, ping.
We sent a new set of changes that should address some of the issues discussed above more elegantly.

Thanks for all this work getting Humble ready for meta-ros.   I am setting up a machine to do some build coverage and test coverage across the matrix of supported releases.
Since that might take some more time to get up and running, I did a quick visual review of the commits you have added so far.   Here are a few things I saw:
I noticed that you added the byobu recipe.  Is this needed by ROS?  The only reference to it that I could find was this: http://wiki.ros.org/screenrun  Perhaps it should be added to another layer alongside screen or tmux?
A few of the commits modify recipes that were adjusted by previous commits in the series.   I suggest we should try to clean up the commit history for this PR.
I noticed a few cases where comments and code was copied from another recipe but the copyright assignment was changed.   I noticed this in the rcutils bbapend as well as in the rosidl-typesupport-fastrtps recipe.   I suggest we should retain the original copyright line when copy and pasting code that was contributed by LG.

Thanks for all this work getting Humble ready for meta-ros. I am setting up a machine to do some build coverage and test coverage across the matrix of supported releases.

Interesting. Can this CI-like effort be contributed back? I think we all will benefit significantly from it.

I noticed that you added the byobu recipe. Is this needed by ROS? The only reference to it that I could find was this: http://wiki.ros.org/screenrun Perhaps it should be added to another layer alongside screen or tmux?

That's a good catch and it's specific to my dev. preferences. I don't think that should be added. We can remove it.

A few of the commits modify recipes that were adjusted by previous commits in the series. I suggest we should try to clean up the commit history for this PR.

This is fair ask. I'll need to rewrite the git history for that, so let's do it once we're good with the rest of the changes.

I noticed a few cases where comments and code was copied from another recipe but the copyright assignment was changed. I noticed this in the rcutils bbapend as well as in the rosidl-typesupport-fastrtps recipe. I suggest we should retain the original copyright line when copy and pasting code that was contributed by LG.

This surprised me a bit @rcwoolley. We've been quite cautious with giving credit to LG and all previous contributors, only adding our contributions where appropriate (where there're actual changes). Note that the humble recipes are brand new, so there's not much to compare against, except if we look at rolling which is the closest one. I guess your claims above point to that.
You mention rcutils and rosidl-typesupport-fastrtps:

rcutils

rcutils_5.0.0-1.bbappend rolling (link)
rcutils_%.bbappend humble (link)

rosidl-typesupport-fastrtps: I'm sorry but you need to be more specific. Are you referring to rosidl-typesupport-fastrtps-cpp, or rosidl-typesupport-fastrtps-c. I checked the latter and it seems to be pretty obvious that there are relevant changes:

rosidl-typesupport-fastrtps-c_2.0.2-1.bbappend rolling (link)
rosidl-typesupport-fastrtps-c_%.bbappend humble (link)

In both cases I see strong reasoning and contributions to make it work in Humble. So based on the above @rcwoolley, I don't find reason in your comment.
I understand you just sent some ideas on a quick pass, and though I agree we should assess contributions and credit appropriately, I think we should be very careful with claims such as the one you make above. They just discourage contributions and frankly, it's not like this repo has received a lot 😉. If you still have concerns about some recipes, we can look at it case by case. In case we mistakenly modified something we shouldn't have, happy to rectify.

There are multiple QA fixes like that https://github.com/ros/meta-ros/pull/1003/commits/b424870e4f996ea20789bb5cca5c3874223ffc6a#diff-19a762c9c9a46f1cd00a06c856d4bcae93a3149a1d0acc5507705126067bf1cbR16
I am wondering whether it is the correct way of fixing these issues?

This pull request has been mentioned on ROS Discourse. There might be relevant details there:
https://discourse.ros.org/t/ros-2-tsc-meeting-minutes-2022-06-16/26093/2

Hi @vmayoral,
I was successfully able to use your branch to create a ros2 humble image, but a peculiar thing I observed was that the source script ros_setup.sh was nowhere to be found. I never faced this issue with any of the previous versions of ROS2.
setup.sh file is sourced from ament-packages template, but while building the ros2 humble image, I got all the 'ros-core' packages installed and each individual package having its own local_setup.sh in /usr/share, but ros_setup.sh found in /usr/bin is nowhere to be found. Hence I cannot source the environment. Do you have any suggestions here?
thanks

Kudos to @grsandeep85 and @mhatle. I've pushed their patches to the branch of this PR.
To everyone testing things, please pull and re-build.
@suyash-narain, this should address your issues.

This pull request has been mentioned on ROS Discourse. There might be relevant details there:
https://discourse.ros.org/t/robotic-processing-unit-and-robotcore/27562/7

Hi @vmayoral,
I just pushed a preview of my changes for humble + kirkstone here: https://github.com/robwoolley/meta-ros/tree/superflore/humble/2022-09-30 I did it from scratch so I could see the problems first hand.
One example was ros-distro.inc missing things in ROS_SUPERFLORE_GENERATED_BUILDTOOLS which is why many of the packages had to have BBCLASSEXTEND += "native" added where they didn't need to before.  I fixed the problems I saw in iceoryx-, orocos-kdl-, and cyclonedds. The fixes might be applicable to honister as well and in resolving the problems you saw.
Let me know if I can help you with getting your ROS 2 Humble Hawksbill Honister configuration ready to merge.
What sort of support level were you aiming for with maintaining your configuration? (The levels are listed here: https://github.com/ros/meta-ros/wiki/Policies#supportlevel-values-in-mcf-files ) Since the Honister release in Yocto Project is EOL, it would normally fall to "best-effort" according to the existing policy that was laid out. You may also consider "contrib" if you want to reduce the effort spent maintaining the branch and doing regular builds.
Regards,
Rob

This pull request has been mentioned on ROS Discourse. There might be relevant details there:
https://discourse.ros.org/t/meta-ros-bof-at-roscon2022/27765/2

Community members and clients are relying on this PR and branch. Given that things haven't been moving forward for a while, and the unstable status of thehonister branch. Let's get this in for now.
@robwoolley, happy to work together and merge the efforts you've led at https://github.com/ros/meta-ros/pull/1035 as well. Ping me and let's have a side chat to move things forward on this direction if desired.


Tasks::GoTo: Now peds don't run

Only one parameter...

Maybe we could implement a method overload with this parameter?
Tasks::GoTo(Entity ^target, Math::Vector3 offset, int timeout)
Tasks::GoTo(Entity ^target, Math::Vector3 offset, int timeout, bool run)

Tasks::GoTo(Math::Vector3 position)
Tasks::GoTo(Math::Vector3 position, bool run)

But here already is RunTo method.

Oh, nvm then. Didn't see it


Cursor go to top when change query file

SQL Operations Studio Version: 0.31.2

(Sorry my english)

Steps to reproduce:

Open two query editors with text in them
Put the cursor somewhere other than the start in one file
Switch tabs to another file then back to the original file

Actual behavior: The cursor goes back to the first line
Expected behavior: The cursor stays in the same place

In addition to the cursor returning to the top of the screen the editor unfolds any folded sections.

And the size of the columns in the results grid have also been reset to the default size when reopening the tab.

This issue is fixed for the query editor scroll position while switching tabs in the latest insiders build at https://github.com/Microsoft/sqlopsstudio/releases/tag/0.32.1.  We have other active issues tracking similar problems in the results grid and elsewhere.


support CastTimeAsDuration in TiFlash

Feature Request
Is your feature request related to a problem? Please describe:

Describe the feature you'd like:

Support CastTimeAsDuration in TiFlash
TiDB's implementation:
https://github.com/pingcap/tidb/blob/562bb9f9e2c194c3f398300d5e5e920965da9f47/expression/builtin_cast.go#L1454
Describe alternatives you've considered:

Teachability, Documentation, Adoption, Migration Strategy:

Hi, has this job been done by someone?
I want to do this job. But I don't have much experience and I'm a little busy. I may do it for a long time. Is there a Deadline in this job?

Hi, has this job been done by someone?
I want to do this job. But I don't have much experience and I'm a little busy. I may do it for a long time. Is there a Deadline in this job?

Hi, feel free to give it a try. There is no hard deadline for this task. I can assign this task to you :)

Thank you, I will try to do my best to do it well.

/label good first issue


Osiris Manualmapping Crashing CSGO

Osiris Manualmapping Crashing CSGO,
LoadLibrary Working.
ManualMapping Crash CSGO.
Can You Help ?

Maybe your injector is doing something wrong or you're manual mapping debug dll.

ManualMap

Types

ManagedPtr.cs =  https://hastebin.com/axeripubip.cpp
Win32
Definitions.cs =  https://hastebin.com/busotawete.cs
Imports.cs =  https://hastebin.com/upedisoxux.cs
pDefinitions.cs =  https://hastebin.com/zepesalegi.nginx
Helpers.cs =  https://hastebin.com/ehuvibipom.cs
ManualmapInjector.cs =  https://hastebin.com/ubodopezag.cs

Bro Other Cheats No Problem Only Osiris Injecting After CSGO Closing.
Osiris Not Supporting ManualMap Please Fix.

i need help.

I reported this problem long time ago. but, it's closed with reason "there's nothing to fix"

may not have seen. @AMATEURZ1337

I asked my friends osiris does not support. they said use another source. but I think this problem can be easily overcome.

Strangle enough I use manual mapping injector all time without any problem.

Why does it cause problems when injecting manualmap?
@danielkrupinski Can you share the manualmap file you use?

https://github.com/danielkrupinski/Inflame

what could be the problem in my loader?

The game closes when osiris converts bytes. Can't find a solution to this? @danielkrupinski


Migrate bots APIs to use data-user-id instead of data-email

Issue #3643

For the get_user ->  get_user_profile_by_id migration, we're losing an implicit assertion that the bot is in the same realm as the user making the request; we should either add explicit checks for that case with tests (or do a get_user_profile_by_id_in_realm (seems messier).  Maybe it's implicit via can_admin_user?

(I merged the first couple commits)

@timabbott yes, its implicitly checked in can_admin_user, added tests to make sure.
I am kinda stuck here, I can't figure out why backend tests for 58 line in zerver/lib/rest.py isn't covered. :thinking:

My guess is that is because you removed the last use of an obscure feature, but not sure.

I fixed the test failure (adding a warning comment to avoid others making the same mistake in the future) and merged this, thanks @YJDave!

@timabbott Thanks for the fixing! Yes, it became really hard to debug, I will keep this in mind.
I will be further working on migrating json/user API as well, if you have any thoughts/suggestions let me know.


40x errors

I get the following:

403 KubeInvaders_wasm.js
404 try_game.png

The really weird thing is if I simply touch the .js file it serves up, it seems like there's some weird bit on the file or something in the image.

Yes!


Fix async incompatibility with Python 3.7.0

Python 3.7.0 puts async and await as reserved words https://docs.python.org/3.7/whatsnew/3.7.html

These are autogenerated files that will be overwritten whenever I regenerate the client.  This needs to be fixed as a swagger modification.


develop-0.3 cypress fixed

Codecov Report

Merging #176 (158f64f) into develop-0.3 (4eed4ca) will not change coverage.
The diff coverage is n/a.

@@             Coverage Diff              @@
##           develop-0.3     #176   +/-   ##
============================================
  Coverage        43.70%   43.70%
============================================
  Files               10       10
  Lines             1167     1167
============================================
  Hits               510      510
  Misses             624      624
  Partials            33       33

Flag
Coverage Δ

unittests
43.70% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


Style Dictionary Output References

Looking at the docs for Style Dictionary's outputReferences support https://amzn.github.io/style-dictionary/#/version_3?id=output-references I noticed that their syntax is slightly different.
Given that I have a very basic typography style in Figma, the plugin outputs:
{
	"fontFamilies": {
		"sans": {
			"value": "sans",
			"type": "fontFamilies"
		}
	},
	"body": {
		"b1": {
			"fontFamily": {
				"value": "{fontFamilies.sans}"
			}
		}
	}
}

When ran through SD, using the basic config we get:
$font-families-sans: sans;
$body-b1-font-family: [object Object];

Their example shows you need to reference .value in your alias. So if we change our token.json to:
{
	"fontFamilies": {
		"sans": {
			"value": "sans",
			"type": "fontFamilies"
		}
	},
	"body": {
		"b1": {
			"fontFamily": {
				"value": "{fontFamilies.sans.value}"
			}
		}
	}
}

We get:
$font-families-sans: sans;
$body-b1-font-family: $font-families-sans;

if we set outputReferences to true.
Which is amazing.
Is this something the plugin should support out of the box? I'm not sure how others are using aliases because the first example doesn't work.

Good catch with the spec. I put in a PR on Style Dictionary itself to see if they'd be willing to make a change on their end. I feel like it's probably best to follow the spec in this case. Even though it's just a draft, I can't imagine that part changing.

I have the same issue here with colors

Adding .value to the end of reference breaks the color preview in the plugin

But Style Dictionary works fine this ways.
$light-background: #fff;
$light-text: #111827;
$light-text-weak: #6b7280;
$light-text-light: #9ca3af;
$light-background-strong: #080b12;
$light-background-light: #f3f4f6;
$light-border: #e5e7eb;
$light-state-active: #c2410c;
$light-state-hover: #f97316;
$light-text-primary: #ea580c;

If I remove the .value I get [object Object] output instead.
Any update on this?

+1

We're waiting for a fix on Style Dictionary end for this as the W3C draft doesn't have the .value prop in the draft.
A PR seems to be coming 🙏
https://github.com/amzn/style-dictionary/pull/746

@six7 thanks for the update 🙏

@six7 Style dictionary PR merged 🎉

When it should be released?

@six7 So I guess the fix in Style Dictionary (amzn/style-dictionary#746) with the optional .value suffix now allows the output of Figma Tokens to be directly transformed by Style Dictionary without appending the .valuesuffix to each alias beforehand.
Not sure if it should also work the other way around? I.e. being able to reference other tokens using {alias.value}? As far as I can see the spec doesn't mention this.
If not, then this issue could be closed...

Agree, I think we can close this one for now. If we'd decide in the future to allow aliases to not just reference the value but also description or other custom fields on a token then we'd need something like that, but for now we're good.


FreeRTOS BLE "CordioM" task not receiving notifications

I am working off of my fork which is based on https://github.com/Analog-Devices-MSDK/msdk/commit/136b2f7f60adb414d3a9795eadf5ee7762b6c30d + https://github.com/Analog-Devices-MSDK/msdk/pull/685
While running repeats of my BLE streaming application (based on BLE_FreeRTOS), occasionally I end up in a state where the CordioM task is no longer able to receive notifications.  I traced this to inconsistent state in the FreeRTOS task control block and what seems like a race condition/synchronization bug.  I don't know how to fix the problem but I do know for sure that the CordioM task state variable ucNotifyState is not taskWAITING_NOTIFICATION even though the task is on the xSuspendedTaskList when notification is attempted.   And because of this the task is never added to the ready list despite the notification.
I instrumented xTaskGenericNotify to check for this condition:
            traceTASK_NOTIFY( uxIndexToNotify );

            /* If the task is in the blocked state specifically to wait for a
             * notification then unblock it now. */
            /********************************************************************/
	    /* tasks on delayed list must be waiting for notification */
	    if ((strcmp(pxTCB->pcTaskName, "CordioM") == 0) &&
		listLIST_ITEM_CONTAINER( &( pxTCB->xStateListItem ) ) == &xSuspendedTaskList) {
		//configASSERT(ucOriginalNotifyState == taskWAITING_NOTIFICATION);
		if (ucOriginalNotifyState != taskWAITING_NOTIFICATION) {
			notify_out_of_sync_original_state = ucOriginalNotifyState;
			notify_out_of_sync_count++;
		}
	    }
           /********************************************************************/
            if( ucOriginalNotifyState == taskWAITING_NOTIFICATION )

and then detect and report the condition in my app's run loop:
		extern volatile uint32_t notify_out_of_sync_count;
		extern volatile uint8_t notify_out_of_sync_original_state;
		extern uint32_t last_notify_out_of_sync_count;
		if (last_notify_out_of_sync_count != notify_out_of_sync_count) {
			TRACE_ERR2("detected notify out of sync, notify_out_of_sync_count = %d, original_state = %d", notify_out_of_sync_count, notify_out_of_sync_original_state);
			last_notify_out_of_sync_count = notify_out_of_sync_count;
		}

While running repeats, sometimes after just a few minutes, sometimes after several hours, I see in my console log:
khp@Kevins-MacBook-Pro-M1 % tail -f logs/repeats_20230806_ble_hang.log | grep "out of sync"
2023-08-06T15:50:22.828292: runLoop: detected notify out of sync, notify_out_of_sync_count = 1, original_state = 0

Reviewing the code in Libraries/FreeRTOS/Source/tasks.c it's not clear to me how a task can ever be in the taskNOT_WAITING_NOTIFICATION state and be suspended, but I don't have a lot of experience with this code.  Once in this state the CordioM task will never respond to notifications and BLE is essentially hung.

@khpeterson Hey Kevin, is related to #685 ? Does that PR fix this issues or still persists? Do you have a minimal application you can share so I can try to reproduce?

Hi @EdwinFairchild, thanks for taking a look.  For sure this issue is not related to https://github.com/Analog-Devices-MSDK/msdk/pull/685 - I am running with my fork which includes that pull request.
Unfortunately, I do not have a pared down app that will easily reproduce the dropped notifications.  From what I can tell the issue is timing dependent and given that it sometimes takes hours of continuous BLE streaming with my full app to see, it may be pretty hard to create one.
I have a lot on my plate at the moment but my first thought would be to pull out the Wsf message queue/dispatch and send/receive messages continuously with 2 tasks with varying load conditions (e.g. random durations via MXC_Delay).
My suspicion is that the critical section protection set up in the port of FreeRTOS is not bullet proof, but I can't prove that.
My current work around is to force both the msg task and the event task back into the waiting notification state when I detect the out of sync condition.  With this (and https://github.com/Analog-Devices-MSDK/msdk/pull/685) in place I can stream BLE over night without a problem.

Hi @EdwinFairchild, I was able to reproduce this with a minimal application (attached).  Please build with this branch of my fork to pick up the change for the wsfTimer leak as well as an assertion that checks for (ucOriginalNotifyState == taskWAITING_NOTIFICATION) when the task being notified is on the suspended list.
I'm running on a vanilla MAX32666FTHR with a shell logging from the UART console connecting to BLE using ADI Attach (version 1.0.1+2 on an iOS 16.6 iPhone 10) : connect to DATS and enable notifications for the "ARM Proprietary Data Service" and let it run.  Timing varies, and it may take a couple of hours, but eventually you will see the assertion I added to FreeRTOS/Source/tasks.c.
BLE_FreeRTOS_v2023_06_notif_out_of_sync.zip


[20.09] pitivi: Fix .svg loading at startup, see #56943 #89691

Motivation for this change
Backport of #101398, without it pitivi does not start.
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[x] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

Tested before and after. Makes it work. Thanks!
Result of nixpkgs-review pr 101435 1

1 package built:

pitivi


Blog: Streamlining EDA Design with AsyncAPI Code Generation and PubSub+ Event Portal

Post title

Streamlining EDA Design with AsyncAPI Code Generation and PubSub+ Event Portal
Post description

The combination of AsyncAPI, PubSub+ Event Portal, and Spring Cloud Stream provides a streamlined yet powerful approach to designing, developing, and managing event-driven systems.
In my blog, I connect the dots, highlighting the following key aspects:

Adopting AsyncAPI: Embrace AsyncAPI for its structured specifications and clarity in defining event-driven services. It ensures consistency and alignment throughout the development lifecycle.

Leveraging PubSub+ Event Portal: Use Event Portal’s robust design and management capabilities to create, document, and export Event-Driven Architecture (EDA) applications as AsyncAPI documents. This simplifies the transition from design to implementation.

Utilizing Code Generators: Automate the generation of boilerplate code for frameworks like Spring Cloud Stream using AsyncAPI code generators. This not only accelerates development but also improves accuracy, minimizes manual errors, and enhances developer productivity by producing consistent, bug-free code.

Integrating with Spring Cloud Stream: Build event-driven services with Spring Cloud Stream to leverage its abstraction over messaging systems, simplified configuration, and seamless integration within the Spring ecosystem.

In essence, I wanted to highlight an approach that enables you to build efficient, reliable, and scalable event-driven architectures with clarity, speed, and precision.
This blog has been already published on solace at https://solace.com/blog/streamlining-eda-design-asyncapi-code-gen-event-portal and a livestream was hosted by @AceTheCreator on Nov 21 https://www.youtube.com/watch?v=Q2cvxsUUgzA where the first part of the discussion digs into the details around the blog content.
Guide
Here are a few steps you can follow to write an AsyncAPI blog post:

After getting feedback on the issue, fork the website repository or open it in Gitpod. You can do that by prefixing the issue URL with gitpod.io/#.
Run the command npm run write:blog.
Run the website by using instructions from the README to test your changes.
Open a PR with your blog post and test your changes with a preview of the site on Netlify. If you use Gitpod, it will create a fork of the website repo for you before you create a PR.
Maintainers reviewing the article (e.g., language, images) may ask for improvements.
Once it's merged, it will be available live in production. :rocket:

We encourage you to write a blog post and share it with the community. We can't wait to read it :smile:!

afaik PubSub+ Event Portal is not an open source project but a commercial product - which means the article is a sales pitch that we should avoid on asyncapi.com
I plan to work on improvements to our sponsorship offer, to offer sponsored article once a year, but such article is then marked as sponsored.


Add metrics registration uts

What is the purpose of the change
Add full test for registration metrics.
Brief changelog
add test for following metrics:

METRIC_RT_MAX  (Max Response Time)
METRIC_RT_AVG (Average Response Time)
METRIC_RT_SUM (Sum Response Time)
METRIC_RT_MIN (Min Response Time)
REGISTER_METRIC_REQUESTS_SUCCEED  (Succeed Register Requests)
REGISTER_METRIC_REQUESTS (Total Register Requests)
REGISTER_METRIC_REQUESTS_FAILED (Failed Register Requests)
METRIC_RT_LAST (Last Response Time)
REGISTER_METRIC_REQUESTS_FAILED (Failed Register Requests)
SERVICE_REGISTER_METRIC_REQUESTS (Total Service-Level Register Requests)
SERVICE_REGISTER_METRIC_REQUESTS_SUCCEED (Succeed Service-Level Register Requests)
SERVICE_REGISTER_METRIC_REQUESTS_FAILED (Failed Service-Level Register Requests)
SERVICE_SUBSCRIBE_METRIC_NUM (Total Service-Level Subscribe Num)
SERVICE_SUBSCRIBE_METRIC_NUM_SUCCEED (Succeed Service-Level Num)
SERVICE_SUBSCRIBE_METRIC_NUM_FAILED (Failed Service-Level Num)

Checklist

[x] Make sure there is a GitHub_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.

@songxiaosheng PTAL

Codecov Report

Merging #12134 (697f216) into 3.2 (3adfbec) will increase coverage by 0.63%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##                3.2   #12134      +/-   ##
============================================
+ Coverage     68.94%   69.58%   +0.63%
+ Complexity      341        2     -339
============================================
  Files          3537     1593    -1944
  Lines        162380    65403   -96977
  Branches      26800     9522   -17278
============================================
- Hits         111960    45510   -66450
+ Misses        40699    15519   -25180
+ Partials       9721     4374    -5347

see 1974 files with indirect coverage changes
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


how to pass TaskA's result to TaskB's parameter

how to pass TaskA's result to TaskB's parameter

This is a question I get a lot from other developers new to Wexflow. There probably needs to be documentation specifically on how to use selectFiles and selectEntities.

Refer to this issue.

I updated the documentation regarding selectFiles and selectEntities.
See the section "How tasks communicate between each other?" here.


⚠ Bofrost.lu has degraded performance

In 81c75c8, Bofrost.lu (https://www.bofrost.lu) experienced degraded performance:

HTTP code: 200
Response time: 1299 ms

Resolved: Bofrost.lu performance has improved in 3d6e590 after 40 minutes.


Todays update has made it so bots can't login

Hey, so my bot was working fine, and since the update to discord this morning, my bot is unable to login. I get the following issue :
Alexs-iMac:Kanye-Bot alextrott$  node index.js
events.js:85
      throw er; // Unhandled 'error' event
            ^
Error: unable to verify the first certificate
    at Error (native)
    at TLSSocket.<anonymous> (_tls_wrap.js:929:36)
    at TLSSocket.emit (events.js:104:17)
    at TLSSocket._finishInit (_tls_wrap.js:460:8)

Is there a quick fix for this?

discord fixed the issue


Binary patching of build prefixes

Now that we've merged https://github.com/Homebrew/brew/pull/12890, we can narrow the focus of this PR only to what is necessary to enable binary patching.  I've written a new unit test keg_relocate/binary_relocation_spec.rb to test relocate_build_prefix, which is by far the most complicated part of the PR.  This should help us avoid breaking this method in the future.   I'm not sure how practical it is implement useful unit tests for the other changes but they're not as complex.

Review period will end on 2022-03-02 at 02:58:25 UTC.

Review period ended.

There's a lot of great feedback here so far which has identified a few things that I think may warrant their own smaller PRs first.  That seems to be a better strategy than try to cram too many big changes into one PR.  These would be the PRs:

In keg_relocate.rb, rename apply_ad_hoc_signature to codesign_patched_binary, and create an OS generic method that does nothing, which is overridden on macOS.  Note that we do use apply_ad_hoc_signature in contexts outside this PR but we're just renaming a method so it's not hard to change those other occurrences.
In keg_relocate.rb, revert each_unique_file_matching to its original form, and replace each_unique_binary_file with a much simpler binary_file? method that takes a single file as an argument and scans if for null bytes.  Ironically this means I broke each_unique_file_matching for nothing, but now I'm more comfortable with unit tests so it wasn't all bad!
Create a cellar_from_tag method in software_spec.rb to get the cellar from a tag, and refactor compatible_locations? to use this.

I know we've been working on this for a long time but given the scope of what is being implemented here I think it's worth doing this right!

There's a lot of great feedback here so far which has identified a few things that I think may warrant their own smaller PRs first. That seems to be a better strategy than try to cram too many big changes into one PR.

Agreed 👍🏻

I know we've been working on this for a long time but given the scope of what is being implemented here I think it's worth doing this right!

Agreed and these changes all sound good. This code is a bit gnarly and it's nice to see it being left in a better state than it was at the beginning, great work @danielnachun!

I've now pushed a major update which has addressed most of the feedback so far and things are much cleaner now.  Here's a summary:

The relocate_build_prefix method now just uses a single loop over files with prefix matches, skipping files which are not binary or are sharballs.
In relocate_build_prefix, the string splitting by null bytes no longer discards empty strings at the end, so we only have to pad the build prefixes and don't have to pad at the end of the file anymore.
I had to add back the generic codesign_patched_binary to keg.rb rather than keg_relocate.rb, because the macOS method is defined in os/mac/keg.rg.

The only thing that I think is still a little rough is how we handle deciding if a bottle needs prefix location.  The way the logic works is that a bottle will only be poured if one of the following conditions is met:

The bottle cellar is :any or :any_skip_relocation.
The user's cellar is the same as the bottle cellar.
The user's cellar is of equal or shorter length to the bottle cellar.

If a bottle is being poured, we still have to determine if the bottle needs prefix patching.  Prefix patching will be skipped if either of the following is true:

The bottle cellar is :any or :any_skip_relocation.
The user's cellar is the same as the bottle cellar.

The set of conditions in which we skip prefix patching is a strict subset of the set of conditions for us to decide if a bottle should be poured at all, but must be evaluated afterward.  As I've currently implemented it, the checks for whether the prefix should be patched are being done in pour in formula_installer.rb.
We could move these checks into their own method, but that would bring us back to the original issue of having a somewhat redundant method with compatible_locations?.  Alternatively we could move the logic into relocate_build_prefix itself, though it may require a bit of refactoring.  I'm open to suggestions on the best way to implement this.

I'm going to merge now given that we have much better testing coverage of this code and the scope of the PR is a lot smaller, so I am more confident now this won't break anything.


[do not merge] Unfilter ADB logs to debug integration test

For testing :)
Pre-launch Checklist

[ ] I read the Contributor Guide and followed the process outlined there for submitting PRs.
[ ] I read the Tree Hygiene wiki page, which explains my responsibilities.
[ ] I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
[ ] I signed the CLA.
[ ] I listed at least one issue that this PR fixes in the description above.
[ ] I updated/added relevant documentation (doc comments with ///).
[ ] I added new tests to check the change I am making, or this PR is test-exempt.
[ ] I followed the breaking change policy and added Data Driven Fixes where supported.
[ ] All existing and new tests are passing.

FYI @camsim99 converting to draft so this doesn't show up in PR review. If it being a draft blocks you in any way, feel free to mark ready for review.


Global extension installation

This is a personal preference in terms of UI customization. When I work in devcontainers I like to have just the extensions that serve for the purpose of the project. I'd rather have any icons, fonts and theme extensions installed globally so they don't polute the containers extensions tab.
See image below:

Adding extensionKind: ["ui", "workspace"] should do the trick. It will prevail running the extension next to the local environment and if not available (web), it will the choose the workspace.
I can send a PR


MGMT-16452: Change MCE subscription to use the default channel

List all the issues related to this PR

[ ] New Feature
[ ] Enhancement
[ ] Bug fix
[ ] Tests
[ ] Documentation
[ ] CI/CD

What environments does this code impact?

[ ] Automation (CI, tools, etc)
[ ] Cloud
[ ] Operator Managed Deployments
[x] None

How was this code tested?

[ ] assisted-test-infra environment
[ ] dev-scripts environment
[ ] Reviewer's test appreciated
[ ] Waiting for CI to do a full test run
[ ] Manual (Elaborate on how it was tested)
[x] No tests needed

Checklist

[ ] Title and description added to both, commit and PR.
[ ] Relevant issues have been associated (see CONTRIBUTING guide)
[ ] This change does not require a documentation update (docstring, docs, README, etc)
[ ] Does this change include unit-tests (note that code changes require unit-tests)

Reviewers Checklist

Are the title and description (in both PR and commit) meaningful and clear?
Is there a bug required (and linked) for this change?
Should this PR be backported?

/test


Modified lines shown more than once

See RHS line 316 in 4883edd90cc8011041a6cee0622805d6bc7847a0.

Seems OK: LHS and RHS line 316 occur in different hunks, which is allowed.


[Draft] XNET gRPC APIs

What does this Pull Request accomplish?
TODO: Include high-level description of the changes in this pull request.
Why should this Pull Request be merged?
TODO: Justify why this contribution should be part of the project.
What testing has been done?
TODO: Detail what testing has been done to ensure this submission meets requirements.

Closing this, as we will create PR's from doshirohan/grpc-device forked repo


Adding Hand Detection

Adding code that detects hands from xml. I've also included a sample xml with all the hands well formed (text_good.xml) and one with a missing 8S and a duplicated JD (test_errors.xml). At the moment the error handling is just print statements, as I assume we want to integrate this into the Flask app (eg ask the user if they're ok with the missing card, etc.), which is what I'm going to try to do next.
You should be able to run this from the command line in a virtual environment created from the new requirements.txt (we're using sklearn now, for the clustering). It just takes the xml you want to parse as an argument.
The output is currently the 'deal' section of a PBN, but this is easy enough to change:
[Deal "N:K74.KQ96.T43.Q65 T962.5.AQ9.AKJT3 AQ3.A72.J82.974 J5.JT843.K765.82"]

This didn't have all the changes i made this afternoon. Will resubmit in a  moment.


Multiple root workspace runs always first folder

I have multiple azure functions in my project. When I try to debug my function it always runs the first one in workspace "folder". It does not follow function picked by launch.json

Hi @adamijak, for now please make sure you're following the steps outlined in our wiki for multi root workspaces: https://github.com/microsoft/vscode-azurefunctions/wiki/Multiple-function-projects#option-2-use-multi-root-workspace

I think I did follow the wiki, however I do not want to launch multiple projects at once

"Option 1" on that page discusses using a single project. Just set the VS Code setting azureFunctions.projectSubpath to the project you want to use

"Option 1" on that page discusses using a single project. Just set the VS Code setting azureFunctions.projectSubpath to the project you want to use

You might have misunderstood me, I do have a solution file opened with multiple projects and multiple azure functions. I do not want to change azureFunctions.projectSubpath or deploySubpath each time. I do have multiple projects opened as folders in workspace. For each project/azure function I have generated .vscode folder with launch and deploy settings.

@adamijak Could you share your launch.json please?
I think VS Code may only respect the launch.json that is in the root of your workspace's .vscode folder.  Right now the func host start task ignores the cwd property in a launch.json and runs it in the first function folder it detects (or in the azureFunctions.projectSubpath setting).
It would be convenient if wherever your launch.json was located is where the task would run, but I think that would rely on VS Code showing a different Run and Debug configuration dependent on which launch.json you are currently viewing so to support this, we would need to figure out how to respect the cwd property.

This feature request is now a candidate for our backlog. The community has 240 days to upvote the issue. If it receives 5 upvotes we will move it to our backlog. If not, we will close it. To learn more about how we handle feature requests, please see our documentation.
Happy Coding!

@adamijak Could you share your launch.json please?
I think VS Code may only respect the launch.json that is in the root of your workspace's .vscode folder. Right now the func host start task ignores the cwd property in a launch.json and runs it in the first function folder it detects (or in the azureFunctions.projectSubpath setting).
It would be convenient if wherever your launch.json was located is where the task would run, but I think that would rely on VS Code showing a different Run and Debug configuration dependent on which launch.json you are currently viewing so to support this, we would need to figure out how to respect the cwd property.

Lets say I have 2 azure functions. Functions are in independent folders Fun1 and Fun2. These folders are registered in .code-workspace file. Each folder contains .vscode folder with generated files. As these are separate functions, I want to have different azureFunctions.deploySubpath for example. Each .vscode folder contains this generated launch.json
{
  "version": "0.2.0",
  "configurations": [
    {
      "name": "Attach to .NET Functions",
      "type": "coreclr",
      "request": "attach",
      "processId": "${command:azureFunctions.pickProcess}"
    }
  ]
}

In Run and Debug I can see "Attach to .NET Functions (Fun1)" and "Attach to .NET Functions (Fun2)" but no matter what I click it will always start debugging Fun1

@nturinski Once again I looked into VsCode multi-root workspace documentation and you really can have multiple .vscode folders in workspace.

With multiple root folders in one workspace, it is possible to have a .vscode folder in each root folder defining the settings that should apply for that folder. To avoid setting collisions, only resource (file, folder) settings are applied when using a multi-root workspace. Settings that affect the entire editor (for example, UI layout) are ignored. For example, two projects cannot both set the zoom level.
User settings are supported as with single folder projects and you can also set global Workspace settings that will apply to all folders in your multi-root Workspace. Global Workspace settings will be stored in your .code-workspace file.

Hi @adamijak
Sorry that it took so long to get back to you. I started investigating this and figured out the reason for the bug.
Unfortunately, the way we are looking for the debug configuration for .NET projects is causing an error if all of the debug configurations have the same name.  While VS Code will denote this on the UI with the subfolder name in parenthesis (ala Attach to .NET Functions (Fun2)), the configs we are checking to all look identical.
If you change your launch.json to have a different name (such as Attach to .NET Functions (2) or something similar) then it should work as expected.
Thanks for filing this issue! I'm currently working on a fix, but please use that workaround for now if you'd like to enable your scenario. Again, sorry that it took so long to investigate this.

Thanks @nturinski for the workaround, it works for me. My scenario seems identical to what @adamijak  has described.

Tracking https://github.com/microsoft/vscode/issues/158471

Moving to tracking milestone since this is an external bug.