Data Formats - Structured, Unstructured and Semi-Strunctured

Effective and efficient usage of data formats can help you to choose which form best meets your business needs:
Understand customer needs at a deeper level to better serve them
Create more focused and targeted marketing campaigns
Track current metrics and create new ones
Create better product opportunities and offerings
Reduce operational costs
All data is not created equal.
Some data is structured, but most of it is unstructured.
Structured and unstructured data is sourced, collected and scaled in different ways, and each one resides in a different type of database.
What are the key differences between structured and unstructured data?
While structured (quantitative) data gives a “birds-eye view” of customers, unstructured (qualitative) data provides a deeper understanding of customer behavior and intent. Let’s explore some of the key areas of difference and their implications:
Sources: Structured data is sourced from GPS sensors, online forms, network logs, web server logs, [OLTP systems](https://www.ibm.com/cloud/learn/oltp), etc., whereas unstructured data sources include email messages, word-processing documents, PDF files, etc.
Forms: Structured data consists of numbers and values, whereas unstructured data consists of sensors, text files, audio and video files, etc.
Models: Structured data has a predefined data model and is formatted to a set data structure before being placed in data storage (e.g., schema-on-write), whereas unstructured data is stored in its native format and not processed until it is used (e.g., schema-on-read).
Storage: Structured data is stored in tabular formats (e.g., excel sheets or SQL databases) that require less storage space. It can be stored in data warehouses, which makes it highly scalable. Unstructured data, on the other hand, is stored as media files or NoSQL databases, which require more space. It can be stored in data lakes which makes it difficult to scale.
Uses: Structured data is used in machine learning (ML) and drives its algorithms, whereas unstructured data is used in [natural language processing](https://www.ibm.com/cloud/learn/natural-language-processing) (NLP) and text mining.

Structured data — typically categorized as quantitative data — is highly organized and easily decipherable. Structured query language (SQL) is the programming language used to manage structured data. By using a relational (SQL) database business users can quickly input, search and manipulate structured data.
Pros
Easily used by machine learning (ML) algorithms: The specific and organized architecture of structured data eases manipulation and querying of ML data.
Easily used by business users: Structured data does not require an in-depth understanding of different types of data and how they function. With a basic understanding of the topic relative to the data, users can easily access and interpret the data.
Accessible by more tools: Since structured data predates unstructured data, there are more tools available for using and analyzing structured data.

Cons
Limited usage: Data with a predefined structure can only be used for its intended purpose, which limits its flexibility and usability.
Limited storage options: Structured data is generally stored in data storage systems with rigid schemas (e.g., “[data warehouses](https://www.ibm.com/cloud/blog/cloud-data-lake-vs-data-warehouse-vs-data-mart)”). Therefore, changes in data requirements necessitate an update of all structured data, which leads to a massive expenditure of time and resources.

Structured data tools
[OLAP](https://www.ibm.com/cloud/learn/olap): Performs high-speed, multidimensional data analysis from unified, centralized data stores.
[SQLite](https://sqlite.org/): Implements a self-contained, [serverless](https://www.ibm.com/cloud/learn/serverless), zero-configuration, transactional relational database engine.
[MySQL](https://cloud.ibm.com/catalog/content/mysql): Embeds data into mass-deployed software, particularly mission-critical, heavy-load production system.
[PostgreSQL](https://www.ibm.com/cloud/learn/postgresql): Supports SQL and JSON querying as well as high-tier programming languages (C/C+, Java, [Python](https://www.ibm.com/cloud/blog/python-vs-r), etc.).

Use cases for structured data
Customer relationship management (CRM): CRM software runs structured data through analytical tools to create datasets that reveal customer behavior patterns and trends.
Online booking: Hotel and ticket reservation data (e.g., dates, prices, destinations, etc.) fits the “rows and columns” format indicative of the pre-defined data model.
Accounting: Accounting firms or departments use structured data to process and record financial transactions.

Unstructured data, typically categorized as qualitative data, cannot be processed and analyzed via conventional data tools and methods. Since unstructured data does not have a predefined data model, it is best managed in non-relational (NoSQL) databases. Another way to manage unstructured data is to use data lakes to preserve it in raw form.
The importance of unstructured data is rapidly increasing. Recent projections indicate that unstructured data is over 80% of all enterprise data, while 95% of businesses prioritize unstructured data management.
Pros and cons of unstructured data
Examples of unstructured data include text, mobile activity, social media posts, Internet of Things (IoT) sensor data, etc. Their benefits involve advantages in format, speed and storage, while liabilities revolve around expertise and available resources:
Pros
Native format: Unstructured data, stored in its native format, remains undefined until needed. Its adaptability increases file formats in the database, which widens the data pool and enables data scientists to prepare and analyze only the data they need.
Fast accumulation rates: Since there is no need to predefine the data, it can be collected quickly and easily.
Data lake storage: Allows for massive storage and pay-as-you-use pricing, which cuts costs and eases scalability.

Cons
Requires expertise: Due to its undefined/non-formatted nature, [data science](https://www.ibm.com/cloud/learn/data-science-introduction) expertise is required to prepare and analyze unstructured data. This is beneficial to data analysts but alienates unspecialized business users who may not fully understand specialized data topics or how to utilize their data.
Specialized tools: Specialized tools are required to manipulate unstructured data, which limits product choices for data managers.

Unstructured data tools
[MongoDB](https://www.ibm.com/cloud/learn/mongodb): Uses flexible documents to process data for cross-platform applications and services.
[DynamoDB](https://aws.amazon.com/dynamodb/): Delivers single-digit millisecond performance at any scale via built-in security, in-memory caching and backup and restore.
[Hadoop](https://www.ibm.com/cloud/blog/hadoop-vs-spark): Provides distributed processing of large data sets using simple programming models and no formatting requirements.
[Azure](https://www.ibm.com/cloud/architecture/architectures/ibm-cloud-private-azure/): Enables agile cloud computing for creating and managing apps through Microsoft’s data centers.

Use cases for unstructured data
[Data mining](https://www.ibm.com/cloud/learn/data-mining): Enables businesses to use unstructured data to identify consumer behavior, product sentiment, and purchasing patterns to better accommodate their customer base.
[Predictive data analytics](https://www.ibm.com/analytics/predictive-analytics): Alert businesses of important activity ahead of time so they can properly plan and accordingly adjust to significant market shifts.
[Chatbots](https://www.ibm.com/cloud/learn/chatbots-explained): Perform text analysis to route customer questions to the appropriate answer sources.

Semi-structured data (e.g., JSON, CSV, XML) is the “bridge” between structured and unstructured data. It does not have a predefined data model and is more complex than structured data, yet easier to store than unstructured data.
Semi-structured data uses “metadata” (e.g., tags and semantic markers) to identify specific data characteristics and scale data into records and preset fields. Metadata ultimately enables semi-structured data to be better cataloged, searched and analyzed than unstructured data.
Example of metadata usage: An online article displays a headline, a snippet, a featured image, image alt-text, slug, etc., which helps differentiate one piece of web content from similar pieces.

Example of semi-structured data vs. structured data: A tab-delimited file containing customer data versus a database containing CRM tables.

Example of semi-structured data vs. unstructured data: A tab-delimited file versus a list of comments from a customer’s Instagram.

The future of data
Recent developments in artificial intelligence (AI) and machine learning (ML) are driving the future wave of data, which is enhancing business intelligence and advancing industrial innovation. In particular, the data formats and models covered in this article are helping business users to do the following:
Analyze digital communications for compliance: Pattern recognition and email threading analysis software that can search email and chat data for potential noncompliance.
Track high-volume customer conversations in social media: Text analytics and sentiment analysis that enables monitoring of marketing campaign results and identifying online threats.
Gain new marketing intelligence: ML analytics tools that can quickly cover massive amounts of data to help businesses analyze customer behavior.


Technical - Link code documentation from the DSM

Documentation integration in DSM
Requirement
As a user of the Design System Management website
I want to be able to browser the DSM description page and drill down to the code examples
So That I can understand how to use the code from the mobile libraby
General description
The developer user should be able to access from the dsm to the code documentation in order to have quick response when browsing the DSM.
In the web section the DSM was linked to a storybook documentation, it needs to be clarified how to do it here.
UI specifications
Anatomy
a code documentation view should be visible from within the DSM pages using an iframe.

Is a duplicate as it is treated within #157


[FEAT][C++] Not allow setting custom namespace for code clarity

Proposed changes
As issue #414 describe
Checklist
Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

[x] I have read the CONTRIBUTING doc
[x] I have signed the CLA
[x] Lint and unit tests pass locally with my changes
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] I have added necessary documentation (if appropriate)

Further comments
close #414

Could you please update the examples in documentations to use graphar instead of GAR_NAMESPACE?

Done.


Review of GCP Acceptable Use Policy

Describe the issue
Legal requested the business area review of the CSP's Acceptable Use Policy from an operational and policy perspective.
Additional context
https://cloud.google.com/terms/aup
Definition of done

read through terms
identify any issues or risks, if applicable
discuss issues/risk with Product Owner
report back to Legal

no issues or risks

we're already operating under the same rules per our gov rules


Adding PlotLines with JavaScript after Render

I am having issues adding PlotLines onto the charts after rendering into my template.
This code adds a plotline:
chart.xAxis[0].addPlotLine({
                   value: 1000,
                   color: 'red',
                   width: 2,
                   id: 'plot-line-1',
                   zIndex: 3,
 });

The plot lines are being added to the html, but with some funky characteristics:
<g class="highcharts-plot-lines-0">
    <path fill="none" stroke="red" stroke-width="200" visibility="hidden"></path>
</g>

Namely:

Visibility is set to "hidden"
There is no 'd' attribute in the path

Is this likely to be a Highcharts failure?

The issue was that the x-axis value was not correct!


sync query rule when sync user

when sync user, we should add query rule to proxysql too, otherwise the new user not auto Read/Write split

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Test name
Status

commit: https://github.com/percona/percona-xtradb-cluster-operator/pull/1084/commits/62ff513fd1f96c830435bc1c958d6ba9c396164b
image: perconalab/percona-xtradb-cluster-operator:PR-1084-62ff513f

@delgod @hors could you please take a look?
@zlcnju tests are failing due to some problem in go modules, I'll ask you to rebase to main once #1085 is merged.

@delgod @hors could you please take a look?
@zlcnju tests are failing due to some problem in go modules, I'll ask you to rebase to main once #1085 is merged.

@delgod @hors please review, the releated jira is PSQLADM-49,PSQLADM-187. Now the proxyadmin tools add the --add-query-rule option, but our operator doesn't use it and the user must create query rule manually

@zlcnju As you can see tests are failing due to problem in go modules. I have fixed this issue in main branch . Could you please rebase it to main.

done

Test name
Status

haproxy
passed

scheduled-backup
failed

upgrade-haproxy
passed

storage
passed

scaling
passed

big-data
passed

recreate
passed

self-healing
passed

self-healing-chaos
passed

scaling-proxysql
passed

init-deploy
passed

restore-to-encrypted-cluster
passed

security-context
passed

upgrade-proxysql
passed

self-healing-advanced
passed

self-healing-advanced-chaos
passed

limits
passed

demand-backup
passed

monitoring-2-0
passed

smart-update
passed

operator-self-healing
passed

operator-self-healing-chaos
passed

affinity
passed

one-pod
passed

pitr
passed

auto-tuning
passed

proxysql-sidecar-res-limits
passed

upgrade-consistency
passed

users
passed

demand-backup-encrypted-with-tls
passed

tls-issue-self
passed

tls-issue-cert-manager
passed

tls-issue-cert-manager-ref
failed

commit: https://github.com/percona/percona-xtradb-cluster-operator/pull/1084/commits/7a720a72b15c272e92a9c6587a82c48371cc0677
image: perconalab/percona-xtradb-cluster-operator:PR-1084-7a720a72

@hors  because i have no access to pipeline, can you help me check the failed test。 I think my commit has no effect on backup and tls

Test name
Status

recreate
passed

restore-to-encrypted-cluster
passed

demand-backup
passed

pitr
passed

demand-backup-encrypted-with-tls
passed

scheduled-backup
passed

haproxy
passed

upgrade-haproxy
passed

scaling
passed

big-data
passed

init-deploy
passed

scaling-proxysql
passed

limits
passed

security-context
passed

storage
passed

monitoring-2-0
passed

self-healing
passed

affinity
passed

self-healing-chaos
passed

one-pod
passed

self-healing-advanced
passed

auto-tuning
passed

self-healing-advanced-chaos
passed

proxysql-sidecar-res-limits
passed

operator-self-healing
passed

users
passed

operator-self-healing-chaos
passed

tls-issue-self
passed

tls-issue-cert-manager
passed

tls-issue-cert-manager-ref
passed

upgrade-proxysql
passed

validation-hook
passed

smart-update
passed

upgrade-consistency
passed

commit: https://github.com/percona/percona-xtradb-cluster-operator/pull/1084/commits/7a720a72b15c272e92a9c6587a82c48371cc0677
image: perconalab/percona-xtradb-cluster-operator:PR-1084-7a720a72

@zlcnju Thanks for contribution. The PR was merged.


Added TypeScript typings file

Merges in the type definition previously published on DefinitelyTyped, and also adds some missing definitions.

@Keats made a better one in #92.


Custom property for dom-repeat

It is not possible to create a custom property for an instance of a dom-repeat element: https://github.com/Polymer/polymer/issues/3534
A computed property can't be used, because we only know the ID inside the dom-repeat and as far as I know I can't pass arguments into a computed property:
  getScene(sceneId) {
    return this.sceneManager.filter(scene => scene.id === sceneId)
  }

  static get template() {
    return `
      <template is="dom-repeat" items="{{scenes}}" as="sceneId">
        {{getScene(sceneId)}}
      </template>
    `
  }

If it would be possible to create a custom property inside dom-repeat, I would not have to call getScene(sceneId) all the time to retrieve the data for the scene.

Or just create another element and pass in result of getScene(sceneId) into it:
      <template is="dom-repeat" items="{{scenes}}" as="sceneId">

        <scene-list-item scene="{{getScene(sceneId)}}"></scene-list-item>

      </template>


Persistent bookmarks error

I get this error when I open Neovim and press <leader>bt:
E5108: Error executing lua: ...s/.local/share/nvim/lazy/spelunk.nvim/lua/spelunk/ui.lua:85: [spelunk.nvim] Could not read file:
stack traceback:
        [C]: in function 'error'
        ...s/.local/share/nvim/lazy/spelunk.nvim/lua/spelunk/ui.lua:85: in function 'read_lines'
        ...s/.local/share/nvim/lazy/spelunk.nvim/lua/spelunk/ui.lua:270: in function 'update_preview'
        ...s/.local/share/nvim/lazy/spelunk.nvim/lua/spelunk/ui.lua:309: in function 'update_window'
        ...s/.local/share/nvim/lazy/spelunk.nvim/lua/spelunk/ui.lua:318: in function 'toggle_window'
        ....local/share/nvim/lazy/spelunk.nvim/lua/spelunk/init.lua:107: in function <....local/share/nvim/lazy/spelunk.nvim/lua/spelunk/init.lua:106>

This is with the config from README.md
When I change enable_persist to false then I get this immediately after opening Neovim:
Failed to run `config` for spelunk.nvim

....local/share/nvim/lazy/spelunk.nvim/lua/spelunk/mark.lua:100: bad argument #1 to 'ipairs' (table expected, got nil)

# stacktrace:
  - /spelunk.nvim/lua/spelunk/mark.lua:100 _in_ **setup**
  - /spelunk.nvim/lua/spelunk/init.lua:420 _in_ **setup**
  - ~/.config/nvim/init.lua:958 _in_ **config**
  - ~/.config/nvim/init.lua:817

I did use the plugin for a short while without problems before those errors showed up. I mentioned that because it looks like it might be a problem with the persistent bookmarks, perhaps I somehow corrupted the save file. I might have used two different Neovim instances at the same time, maybe that broke something?

Hmmm, this may have something to do with an update I made to the mark representation lately. Could I get your help pasting the contents of the stored file? Should be available at ~/.local/state/nvim/spelunk/$DIRECTORY_BAME, where the last component is the directory you’re in. You should be able to clear that file and reset then, though you’ll lose your marks. Apologies.
It sounds like the previewer is unable to find a given file, which is odd. I suppose, would you happen to have deleted a marked file recently? Especially from outside Neovim?

Also! Some of the core concerns from this PR should be addressed in: https://github.com/EvWilson/spelunk.nvim/pull/33
Was able to confirm all this behavior myself, and get it fixed from at least the testing I was able to do. Going to leave this issue open for a bit in case it doesn't address all concerns, or just in case I happen to have missed something.

Seems to work now 👍🏻


Frontend Login and Registration

Is your feature request related to a problem? Please describe.

We do not have a way to login or register on the frontend

Describe the solution you'd like

Connect to the API using axios
Allow user to send POST requests on the register and login page
Add login/logout functionality

Describe alternatives you've considered

N/A

Additional context

N/A

An import feature of our platform


How to label our sprints

Talking with @hnicke the question appeared how do we show which issues belongs to a specific sprint.
@hnicke suggested to create milestones to label them.
I thought of creating a sprint_n label.
What is your oppinion?

Milestones are probably the most clear option to show what issues belong to which sprint.
They also allow to set a due date and use features like velocity tracking to analyse sprint progress.
Having a milestone for every sprint might get a little confusing though, especially for other people looking into this repo. It might also confuse people because currently we plan to do normal milestones as well (e.g. after the completion of the AWS pugin). It might be a good idea to just set a release (or pre release) when we finish a big milestone (not sprints).
In my opinion using milestones would provide valid benefits over just using labels.

Any other opinions on this?

We have decided to use milestones.


Autosynth: Added files in a client make extra PRs

When a new file is added to a client. Other clients generated after this client also see the files added to their PRs

It has to do with the generated cache directory and copying the files to the clients folder


ManualAstMod PutLiteralBytes should check if bytes exist

In the current implementation literals to add will simply be added and lexed. An advanced version might check if the literal exists in the current lexer input and just return a reference.

This api got deprecated, will close therefore.


Add possibility to sign calls via cli

Needed for chaos testnet tooling.
@rphmeier Can you please take a look if this fulfills your requirements? Please note that the returned value atm is an UncheckedMortalCompactExtrinsic, not an UncheckedMortalExtrinsic.
$ cd subkey/
$ cargo run -- sign-transaction \
    --call 0300ff408aa36b945720031fbb2e661fc9c9f1ed799be5369f991bbfce02103b5f0e44e514 \
    --nonce 0 \
    --suri //Alice/// \
    --password password \
    --prior-block-hash f8349fe94e9fd86e8a85745bbb70a4d2d5f4d8fc32a1f8fc08088faf1840e705
0x250281ffd43593c715fdd31c61141abd04a99fd6822c8558854ccde39a5684e7a56da27d0ecdb36c371c4a5e2d7528e12f68fcc57912df0c80418cca794fd83c24f29825efbaaaa2ae4472726e065f4f1db75ba7c39114e25b58de4dde54d6b51aa3e20500000300ff408aa36b945720031fbb2e661fc9c9f1ed799be5369f991bbfce02103b5f0e44e514

Passwords should not be passed as command line arguments, as on Unix-like systems this is a local information disclosure vulnerability (via ps(1) et all).

@DemiMarie-temp I totally agree and have pointed this out in the past as well. Thing is: Changing this would require changing it in the whole subkey crate (as I just implemented the same structure as the other subcommands do). It would also require changing the way we currently pass node secrets in substrate (also via cli). So I would rather create a follow up ticket.

@cmichi Also, this is only exploitable if untrusted users are on a machine, which for Parity is probably not the best configuration anyway for security reasons.

Trying out your example call
subkey sign-transaction \
    --call 0300ff408aa36b945720031fbb2e661fc9c9f1ed799be5369f991bbfce02103b5f0e44e514 \
    --nonce 0 \
    --suri //Alice/// \
    --password password \
    --prior-block-hash f8349fe94e9fd86e8a85745bbb70a4d2d5f4d8fc32a1f8fc08088faf1840e705

it results in
Using a genesis hash of dcd1346701ca8396496e52aa2785b1748deb6db09551b72159dcb3e08991025b
thread 'main' panicked at 'called `Option::unwrap()` on a `None` value', /rustc/f3e1a954d2ead4e2fc197c7da7d71e6c61bad196/src/libcore/macros/mod.rs:15:40
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace.

See https://github.com/paritytech/substrate/issues/5180

P.S.: That same parameter set did NOT crash your OLD subkey version from May 2019 = I have tried that too: https://github.com/paritytech/substrate/issues/5180#issuecomment-596093813


Multi-Slider Feature

Would be cool to have something 2 Values aka min/max like this:
https://pub.dev/packages/flutter_multi_slider

will be great


ParserAbstract error whn trying to generate a diagram (on docker)

I can't get phuml on docker to work, I haven't tried with Composer or Phive.
It was working last time I tried some months ago.
I tried the examples on the docs page and also tried editing it without any success
docker run --rm -v $PWD:/code montealegreluis/phuml phuml:diagram -p dot -r -a src UML.png
[|] Running... (This may take some time)
[|] Parsing codebase structure

In ParserAbstract.php line 318:

  Syntax error, unexpected T_STRING, expecting T_VARIABLE on line 7

phuml:diagram [-p|--processor PROCESSOR] [-r|--recursive] [-a|--associations] [-i|--hide-private] [-o|--hide-protected] [-m|--hide-methods] [-t|--hide-attributes] [-b|--hide-empty-blocks] [-e|--theme [THEME]] [--] <directory> <output>

I get the same error

Hello, I have been utilizing phuml on Docker as well and it is working sucessfully.
I would ask for the image version that you was using at that time but at least the image tagged latest works for my experiments, I used it on a dummy project with 4 classes only.
As info. the image tagged 6.1.0is non-working correctly, as a non-expert on PHP I think that is an error with the source code used on that tag.
I'll expose a demonstration about how I use the tool on a pretty straighforward project and the results that I got.
Project structure and files
./
  .docker/  --> Bridge for containerization logic.
  └── compose.yaml

  src/      --> App logic.
  └── Leaf
      ├── LeafHandler.php  --> Use Repository logic.
      ├── LeafHandlerInterface.php
      └── Repository
          ├── LeafRepository.php
          └── LeafRepositoryInterface.php
  uml/      --> Directory where to store artifacts.

For my purposes I have to use a docker compose scheme in order to orchestrate this service with some others required.
# .docker/compose.yaml

services:
    # Some other services before this line.
    uml:
        image: montealegreluis/phuml:latest
        volumes:
            - ./../:/code
            - ./../uml:/uml

Hands on
After observing the documentation and the "layers" that x image have on it the next
docker commands helps my to achieve my needs.
docker compose -f .docker/compose.yaml build
To execute the phuml services I do it in this way, feel free to observe the documentation in order to understand the command and set of arguments.
docker compose -f .docker/compose.yaml run --rm uml phuml:diagram -r -a -i -o -p dot src/ uml/example.png
Results
After observe the uml/ directory I have the next image:

Expected for me ofc! ⚽
References

https://montealegreluis.com/phuml/docs/class-diagram.html
https://hub.docker.com/layers/montealegreluis/phuml/latest/images/sha256-ed5caaa36c8c9742c72b70d71d5f0b159b031417229a88a2b7d66f2ba1e13efa?context=explore
https://dasunhegoda.com/class-diagram-from-php-code-using-phuml/867/

I didn't review the final reference, but seems ok for me share the blog related with this tool and how the autor use it.

Hello @MontealegreLuis
Maybe you could review this issue and close it, assuming that there is an incomplete evidence from the author and the project have at least a Docker image working (I did not try all of them).

I can confirm this error. It may be due to using phUML docker image on a PHP 8.2 code base.

I can confirm this error. I am also using PHP 8.2.


[gardening] Use "#if 0" (instead of "/*") for disabling code blocks

What's in this pull request?
Use #if 0 (instead of /*) for disabling code blocks.
Resolved bug number: –

Before merging this pull request to apple/swift repository:

[ ] Test pull request on Swift continuous integration.

Triggering Swift CI
The swift-ci is triggered by writing a comment on this PR addressed to the GitHub user @swift-ci. Different tests will run depending on the specific comment that you use. The currently available comments are:
Smoke Testing
    Platform     | Comment
    ------------ | -------------
    All supported platforms     | @swift-ci Please smoke test
    OS X platform               | @swift-ci Please smoke test OS X platform
    Linux platform              | @swift-ci Please smoke test Linux platform

Validation Testing
    Platform     | Comment
    ------------ | -------------
    All supported platforms     | @swift-ci Please test
    OS X platform               | @swift-ci Please test OS X platform
    Linux platform              | @swift-ci Please test Linux platform

Note: Only members of the Apple organization can trigger swift-ci.

The patch looks fine, but what do you mean by regression?  Whoever committed this should probably just remove the code.

@lattner Oh, sorry - confusing wording from my part. Regression in the sense that all usages of /* (instead of #if 0) had been cleaned out and that this new instance of /* put us back in the previous state of mixing /* and #if 0. I've removed the "regression" wording now :-)


Use the customerId as the key when sending Kafka events

This means that all events relating to a given customer will be in the same partition, and thus will be consumed in the order they were sent.
As suggested by @lehnerm.
If this seems reasonable, I'll do the same for all our other Kafka producers.

This PR was successfully deployed to production by CircleCI build 36 at 2016-12-21 15:07 GMT.


Area cut of paris 12th district not right

Here is the right cut of it
"district-75112" : "m 676.86371,295.93344 -33.28182,-3.33281 -14.71313,-2.03681 -47.78523,-8.96187 -13.93201,-0.67891 -18.48905,-4.75253 -6.90088,-1.22205 -18.09853,-9.23344 -9.37469,-6.24614 -0.84379,0.0428 0.73648,6.04895 -1.74423,5.03828 -9.95625,28.61504 -2.53693,7.50813 21.26532,25.92914 17.51099,21.09681 15.42665,21.42906 20.8997,26.81607 10.1474,8.71519 13.00251,-10.90536 15.51912,-2.93603 12.79281,-7.54986 z",

Hello,
Thank for noticing it, but it seems that the "bois de Vincennes" area is part of the 12th district according to Google maps and other sources : https://www.google.fr/maps/place/12e+Arrondissement,+75012+Paris/@48.8291179,2.3638758,12z/data=!4m5!3m4!1s0x47e6728cb7d7d747:0x50b82c368941b00!8m2!3d48.8293647!4d2.4265406 , the same for the 16th district and the "bois de Boulogne" area : https://www.google.fr/maps/place/16e+Arrondissement,+Paris/@48.8570816,2.1228168,11z/data=!4m5!3m4!1s0x47e67ab3264355e9:0x50b82c368941b40!8m2!3d48.8585799!4d2.2847017

On wikimedia commons, both maps can be found including or excluding these two wood areas :
https://commons.wikimedia.org/wiki/File:Paris_department_location_map.svg
https://commons.wikimedia.org/wiki/File:Numbered_map_of_Paris_with_Bois_de_Boulogne_and_Bois_de_Vincennes.svg
Maybe the proper solution should be to provide these two versions of the Mapael map of Paris.


Add custom manylinux docker for aarch64

To install the package in the jetson we need a custom release package based on
--> messense/manylinux2014-cross:aarch64
See: https://github.com/messense/maturin-action#manylinux-docker-container

supported already


electron app does not work on macOS 13.4

Hello Thomas, thanks for your great work.
Just reporting that version 0.0.3 doesn't work on macOS 13.4.

but if I compile code, it works well.

hey thanks for message and sorry, i havent seen it earlier.
did you figure out how to fix it? i am quite busy with work, but can have a look once a have some free time.

I end up making own MediaPipe OSC Sender because I couldn't fix the issue, and also MediaPipe is updated. I'm also bit busy at the moment but would be nice to have time to contribute updating Popeye later. Thanks for your message!

i will hopefully find some time over christmas, planning to updat ethe lib. there seems to be an issue with the electron bundle. it is way to big.
potentially will port it to tauri.

Cool, never heard of tauri but looks interesting.

i started porting it to tauri, which now reduces the bundle size to 20mb instead of 600mb.
still some fixes left to do.
in case you wanna give it try. let me know how it works for you.
i also will cleanup the js part soon, it got a bit messy. and should update the media pipe libs.
any contributions are welcome of course.

Cool Thomas! I will try it out!
Last year, we made our own webApp that communicates with oF via websocket
(without UDP). I will ask if we can publish the app.
Recent updates of MediaPipe improves reducing jittering and adds new
parameters (visibility, if I remember correctly).
On Tue, 4 Jun 2024, 11:40 Thomas Geissl, @.***> wrote:

i started porting it to tauri, which now reduces the bundle size to 20mb
instead of 600mb.
still some fixes left to do.
in case you wanna give it try. let me know how it works for you.
i also will cleanup the js part soon, it got a bit messy. and should
update the media pipe libs.
any contributions are welcome of course.
—
Reply to this email directly, view it on GitHub
https://github.com/thomasgeissl/popeye/issues/21#issuecomment-2147084138,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AABPGAAWXJQGXZFMBBW3LITZFWDQHAVCNFSM6AAAAAA554DLAGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNBXGA4DIMJTHA
.
You are receiving this because you authored the thread.Message ID:
@.***>

sounds good.
and quite related, i started working on an webview for oF. that helps to get rid of the ws communication.
basically an oF based electron.
https://github.com/thomasgeissl/ofxChoc/tree/main/example-webview

I just tried ofxChoc and all works great on macOS 14.
So I tried replacing /dist contents of example-webserver_webview example with our MediaPipe webApp.
and WOW! Magic!

thanks for giving it a try and reporting back. glad to hear that it worked without issues.
the event system might need some internal tweakings, but i think the basics are already there.

Webcam works, MediaPipe works, Landmark detection works, Gui works!
One issue I found is that video doesn't record. (We have a HTML5 video recording feature for webcam input to adjust MediaPipe parameters). Great work!

thanks. feel free to add an issue on the other repo and move that conversation over there.
probably nothing i can fix easily, maybe more an webkit issue or how it is implemented in choc. wonder if it works on windows.

btw, I'm quite surprised to see that oF's Project Generator is about 430MB.
It might be good to re-write with Tauri.

yeah, electron is quite heavy. also it takes a bit longer to load the app.
i would like to see it written with ofxChoc, since it has a c++ backend instead of rust.

oh i see, that's also sounds good.


Hover tooltip on guttermarks

Could a tooltip with eslint warning/error message text be displayed when hovering by mouse over the guttermarks? It's a bit clumsy to lookup the message using line number in the (bottom) report panel.

Added in 2.9.0

Perfect job!


[FXT features] Bonus cars/songs, SP arcade mode?

https://www.youtube.com/watch?v=sCdbClzjnVk
I'm just requesting this so I'll never have to use the janky FXT hack again. I'm not sure if they were hacked in from the arcade version though. Thanks for your work!

I wish i could give you 50 likes just for calling FXT "janky" lmao.
As for the bonus songs, currently the only way to enjoy them is to use the included CDSwitcher feature.

I wish i could give you 50 likes just for calling FXT "janky" lmao.
As for the bonus songs, currently the only way to enjoy them is to use the included CDSwitcher feature.

FXT itself wasn't the jankiest, but all the hoops you had to jump through to limit the framerate with special K and the broken anti-aliasing... oh wait... it was janky as hell. Never mind.

I wish i could give you 50 likes just for calling FXT "janky" lmao.
As for the bonus songs, currently the only way to enjoy them is to use the included CDSwitcher feature.

I appreciate the work he did trying to wrangle in Outrun 2006, but man is it janky. I just tried it on Windows 10 and it just constantly forced windowed mode and opened the driver's license menu at a rapid fire, even after I limited it to 60FPS.
I also liked the custom track order mod, I used to always play the shuttle mission second.

I wish i could give you 50 likes just for calling FXT "janky" lmao.
As for the bonus songs, currently the only way to enjoy them is to use the included CDSwitcher feature.

I appreciate the work he did trying to wrangle in Outrun 2006, but man is it janky. I just tried it on Windows 10 and it just constantly forced windowed mode and opened the driver's license menu at a rapid fire, even after I limited it to 60FPS.
I also liked the custom track order mod, I used to always play the shuttle mission second.

It's also a lot more resource demanding than Tweaks. C'mon, if a game from motherfriggin' 2006 can't run on a old gaming rig from a couple of years later (it also runs well on a Vaio from twelve years ago!) , ask yourself a couple of questions...

I wish i could give you 50 likes just for calling FXT "janky" lmao.
As for the bonus songs, currently the only way to enjoy them is to use the included CDSwitcher feature.

FXT itself wasn't the jankiest, but all the hoops you had to jump through to limit the framerate with special K and the broken anti-aliasing... oh wait... it was janky as hell. Never mind.

To be honest, I was contemplating on making a new request here to see if its possible to backport some of the FXT-specific fixes for the game (with Howards help, of course) because I could see this as the open-source evolution/successor to FXT Edition.

What "fixes" from FXT are still missing from Tweaks?

FXT Edition fixes the broken Horn button which does nothing at all when pressed by default but there is a button/key for it in the Options under the keyboard/controller configuration menu. Apparently FXT restores two more music tracks that were omitted in the US version (although the music player in Tweaks could possibly add those).

FXT Edition fixes the broken Horn button which does nothing at all when pressed by default but there is a button/key for it in the Options under the keyboard/controller configuration menu. Apparently FXT restores two more music tracks that were omitted in the US version (although the music player in Tweaks could possibly add those). It also has a pseudo "Arcade Mode" function that mimics OutRun 2 SP by hiding the other menus.

Well if you look at the commits, the Horn will come in a future version... what are the two music tracks? Are those part of the four tracks from the Japanese PS2 version?

FXT Edition fixes the broken Horn button which does nothing at all when pressed by default but there is a button/key for it in the Options under the keyboard/controller configuration menu. Apparently FXT restores two more music tracks that were omitted in the US version (although the music player in Tweaks could possibly add those). It also has a pseudo "Arcade Mode" function that mimics OutRun 2 SP by hiding the other menus.

Well if you look at the commits, the Horn will come in a future version... what are the two music tracks? Are those part of the four tracks from the Japanese PS2 version? I can't find any info about that.

I haven't installed FXT in forever, but a cursory search tells me it might be Passing Breeze [H.] Arrange Ver., Splash Wave J Arrange Ver., Rush a Difficulty J Arrange Ver., Lift You Up!. I also have a sound mod for FXT titled Japan Exclusive Tracks.

This is weird, because it's not mentioned anywhere, not even on sites like The Cutting Room Floor (sections for OR2 are mostly empty lol)
I'm starting to think he wrote about the "removed" tracks without knowing what he was talking about.

Well, whatever! Just load the Outrun anniversary box and be done with it (though ideally, LOOP point metadata can also be integrated so you don't have to generate 40 minute loops).
On the subject of FXT features, Howard has a Course Editor tool that lets you change the order of maps. I haven't tested if this works with just Tweaks, though, but integrating this as a feature would also be cool. It modifies the script files, though, so it might be harder than just simply arranging the order in an ini. It's buried in the Outrun hacking forum so I'll repost it here. If anyone tries it and it works, let us know.
https://www.youtube.com/watch?v=8J1I7xaxZvM

Well, whatever! Just load the Outrun anniversary box and be done with it (though ideally, LOOP point metadata can also be integrated so you don't have to generate 40 minute loops).

I tested the four Japanese tracks to report a problem with fonts (you got a red heart instead of "H." in Passing Breeze [H.] Arrange Ver.)
For now the CDSwitcher is the best alternative if the tracks cannot be fully implemented in-game like on PS2.


Moviegoer: remove unnecessary "attr_reader"

The attr_reader :age, :member line is not necessary since we don't need to expose the attributes.

Thank you for the patch!  It is definitely good to see someone new here making contributions!


Preview 1.82.3 Release

What's New ? - 1.82.3

[Imp] Exception data improvements, by @bagusnl

Add CPU and GPU details to make it easier for us to debug
Use AssemblyVersion for Release tag so it's handled in the dashboard nicely
Detach Enable/Disable setter so it won't freeze the UI when toggling

[Fix] Fixed launcher update logic, by @neon-nyan

Fixed errors when/after updating via Velopack
Users are advised to freshly installed Collapse (will not affect settings) in this update

[Imp] Updated submodules, by @bagusnl

Synced both H.NotifyIcon and DiscordRPC submodules from its main repository

[Imp] Refactor file asset checking mechanism by matching in-game repair behavior for Genshin Impact, by @neon-nyan

Hopefully this would fix unwanted behavior which causes the game repair to fail for some reason.
Preferring XXH64 hash to be used for file integrity (if available)

[Imp] Improved Full Check Speed on HDD, by @bagusnl & @neon-nyan

Limit thread number for checking to 1 if the mechanism detects HDD. Any errors in the mechanism will fallback to detect as HDD and use multithreaded check.
Currently only implemented in Genshin Impact repair.

[Fix] More IOSharingViolation fixes for multithreaded ForeachAsync, by @bagusnl
[Fix] AccessDenied error in GameBoost mechanism, by @bagusnl

This is probably due to the game not being fully launched yet. The default delay for the mechanism is 10s, slower systems might take longer to load the game.
Now game boost mechanism have a retry system that will retry for at least 3 times in the background

[Fix] Retry mechanism in Database operation StoreKeyValue not correctly defined, by @bagusnl
[Fix] App crash when logger fails to get console width, by @bagusnl
[Fix] FileNotFound errors on Hi3 repair mechanisms, by @neon-nyan

Templates

Changelog Prefixes
  **[New]**
  **[Imp]**
  **[Fix]**
  **[Loc]**
  **[Doc]**

MY BAD


Make preprocess only extract from classes from ternary operators

Currently {prism} gets extracted as language-{params which is not valid css syntax. With this PR only ternary operators get extracted from the string and those like in the example above stay untouched.

Should fix https://github.com/windicss/svelte-windicss-preprocess/issues/63

thanks for your work! 👍


Obsoletion request: GO:1905267	endonucleolytic cleavage involved in tRNA processing GO:0042779	tRNA 3'-trailer cleavage GO:0034415	tRNA 3'-trailer cleavage, exonucleolytic GO:0034414	tRNA 3'-trailer cleavage, endonucleolytic GO:0072684 mitochondrial tRNA 3'-trailer cleavage, endonucleolytic

Please provide as much information as you can:

GO term ID and Label
GO:1905267	endonucleolytic cleavage involved in tRNA processing
GO:0042779	tRNA 3'-trailer cleavage
GO:0034415	tRNA 3'-trailer cleavage, exonucleolytic
GO:0034414	tRNA 3'-trailer cleavage, endonucleolytic

[x] GO:0072684	mitochondrial tRNA 3'-trailer cleavage, endonucleolytic

Reason for deprecation

[x]  The reason for obsoletion is that these term represent molecular functions.

"Replace by" term (ID and label)

GO:1905267	endonucleolytic cleavage involved in tRNA processing
GO:0042779	tRNA 3'-trailer cleavage
GO:0034415	tRNA 3'-trailer cleavage, exonucleolytic
GO:0034414	tRNA 3'-trailer cleavage, endonucleolytic
All replace by  GO:0042780   tRNA 3'-end processing
GO:0072684	mitochondrial tRNA 3'-trailer cleavage, endonucleolytic
replace by
GO:1990180    mitochondrial tRNA 3'-end processing

Are there annotations to this term?

How many EXP:

(12)	endonucleolytic cleavage involved in tRNA processing
(9)	tRNA 3'-trailer cleavage, endonucleolytic
(4)	mitochondrial tRNA 3'-trailer cleavage, endonucleolytic
(3)	nuclear tRNA 3'-trailer cleavage, endonucleolytic
(20)	PomBase
(7)	FlyBase
(6)	TAIR
(4)	GOC
(4)	SGD
(2)	CAFA
(1)	EcoCyc
(1)	UniProt
No reannotation is necessary, annotations will be migrated.
@hattrill @tberardini @srengel  you might want to check that the corresponding MF terms are correctly annotated though...

Are there mappings and cross references to this term? (InterPro, Keywords; check QuickGO cross-references section)

Is this term in a subset? (check the AmiGO page for that term)

Any other information

Checklist for ontology editor
Check term usage and metadata in Protégé

[ ] check term usage in the ontology
[ ] check internal mappings: RHEA, EC, MetaCyc
[x] check subset usage
[x] check taxon constraints

Check annotations
Not required, annotations will be migrated to replaced_by term
Notification

[x] https://github.com/geneontology/go-announcements/issues/509
[ ] announce to GO friends<EMAIL_ADDRESS>[ ] paste the text in the ontology ticket

done!

I'm not sure what happened here but
GO:1905267 endonucleolytic cleavage involved in tRNA processing
is still in the ontology
https://www.ebi.ac.uk/QuickGO/term/GO:1905267

and
GO:0042779  tRNA 3'-trailer cleavage


SpO2 equation

Hello,
First of all I would like to congratulate for the excellent job you did. I developed myself a version of "tinyPulsePPG" with MAX30105 sensor using you project as reference .  Thank you.
Now comes my question/concern regarding SpO2 calculation.  You present two options for SpO2 calculation: one linear and the other quadratic.
With regards on the linear equation, in the documentation you mention "104 - 1.7 * R", but inside the code you implement "104-0.17 * R+0.5". Fact that is a bit confusing. Anyhow, the implemented linear equation works fine.
If possible, please clarify this concern (or may be I'm wrong).
Other way around, using as reference a guideline from Maxim Integrated (https://www.maximintegrated.com/en/design/technical-documents/app-notes/6/6845.html) , I implemented also a quadratic equation : "1.5958 * R * R - 34.6596 * R + 112.6898 " with very close results to your linear implemented eq. I was afraid of wrong results, the coefficients of quadratic equation being for MAX30101 , me using MAX30105 (as I said). But no problem. It worked well.

Thanks for your kind words. I am afraid that I cannot find the original reference, so I have no idea whether it should be 1.7 or 0.17. I was not able to calibrate or verify the SPO2 measurement in an way, so I would be very careful about inferring anything about blood oxygen level from it. If you have been able to compare it with a commercial device, I would be very interested in the results

Noted. Actually, I was able to compare the results (SpO2 level) of the present project with a Beurer PO-40 pulse-oximeter (https://www.beurer.com/web/gb/products/medical/ecg-and-pulse-oximeter/pulse-oximeter/po-40.php).  Let's say there are differences of 1-2%, if any (most of the time, there are not). I think the max-integrated sensor is well calibrated and the default coefficients for their SpO2 - quadratic equation lead to satisfactory results.

Thanks, that’s really interesting - still would not rely on it in a medical situation!


Semantic Tokens: Provide guidance for tokenType taxonomy

Ref: #85976
Consider this case:
import * as vscode from 'vscode';

export function activate(context: vscode.ExtensionContext) {
	new Bar();
}

import, as, from, export, new are all tokenType: "keyword"
Their scopes are:

import: keyword.control.import.ts -> purple
as: keyword.control.as.ts -> purple
from: keyword.control.from.ts -> purple
export: keyword.control.export.ts -> purple
new: keyword.operator.new.ts -> blue

Should I mark them all as keyword with different modifiers? Or should I mark, say, new as a new category importantKeyword, if I intend it to be marked with a different color, distinct from other keywords (but even if I do, theme authors need to mark them differently as well)?
The issue is:

As tokenizer author, I don't know how much granularity should I provide for tokenType.
As theme author, the new system seems to encourage more coarse taxonomy, making it impossible for a theme to give more accurate color. For example, if I think new is 100 times more important than other keywords, I can't highlight new differently now because I can't tell it away from other keywords.

Should we allow extensions to give tokenType such as keyword.operator or ['keyword', 'operator'] etc?

The current default token dictionary is still just proposal and we will extend it based on the feedback of the first users. For you have a good name of that kind of keyword? Based on that we can see if it's a new type or rather a modifier.
In the future, extensions will be able to extend the token dictionary along with default color rules.
That said, keywords are not really a good example for a semantic highlight provider. The current story is that the semantic token provider adds semantic tokens while syntax tokens are coming from the textmate theme. Keywords are typically served by a the syntax theme. Yes it's possible that in some very context specific language a keywords can only be evaluated by a real parser.
So a semantic color provider would not report all keywords, just the one's that need a real parser.

It's now possible for extension to define their own token types that extend an existing token type.


Help with translation into Russian.

Hello. I am from Russia. My name is Artem and I am 19. I came across your game in one of the Russian Telegram channels. I would like to offer you my help with translation into Russian. Exclusively in a voluntary form.

Thats great! feel free to check out the translating README https://github.com/saving-satoshi/saving-satoshi/blob/dev/i18n/README.md and let us know if you have any other questions in our bitcoin design discord

Amazing!! Thank you so much for you interest in helping with this! Tagging @aassoiants in case he can be helpful for review :smile:

@satsie ha! My proofreading would need some proofreading!

This issue is a duplicate of https://github.com/saving-satoshi/saving-satoshi/issues/1194 so I am closing this one!


Roll engine 72986c39ea36..0a2869e5c3dc (4 commits)

https://github.com/flutter/engine/compare/72986c39ea36...0a2869e5c3dc
git log 72986c39ea3669ef26d4d7d7cd0c44f513fcd117..0a2869e5c3dc9b46f1aec27aa2393db079f0bfde --no-merges --oneline
0a2869e5c Added support for authentication codes for the VM service (flutter/engine#8527)
36d2135ad Redo a fix for cull rect calculation on TransformLayers with a perspective transform (flutter/engine#8528)
0b36d3e2f Change Rect internal representation from Float32List to Float64List (flutter/engine#8524)
b1ae0ccb7 Roll src/third_party/skia 10bf7020aa15..b5c685991faa (3 commits) (flutter/engine#8526)
The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff (jsimmons@google.com), and stop
the roller if necessary.

Trybots failed. These were the failed builds: https://cirrus-ci.com/task/5833117196615680

Commit queue failed; closing this roll.


feat: add Ui-Kit Search Component to BE

Replace BE's form components with Ui-Kit components.

Closed as a duplicate of https://github.com/casper-network/casper-ui-kit/issues/39


"AABB size is negative" when importing glb

Godot version
v4.0.beta6.official [7f8ecffa5]
System information
Windows 11
Issue description
Receiving lots of "AABB size is negative" error messages. I've imported a 3D model (glb file) and it's caused the engine to move extremely slow to the point its near unusable when it comes to saving/loading/running.
The model started in Character Creator 4, then imported to Adobe's Mixamo for rigging, then imported into Blender and exported from that as a glb to Godot (Character Creator 4 -> Mixamo -> Blender -> Godot).
Steps to reproduce
Here is a download link the the model being used:  Google Drive
You can just import the glb file, but there's a blend file too if anyone wants to see what it looks like before it's exported as a glb.
Minimal reproduction project
N/A

This doesn't invalidate the issue, but your model is 104.9MB. This is quite huge for a game engine.

Duplicate of https://github.com/godotengine/godot/issues/56458.
Closing this issue so we can track it in one place

Can this thread/issue be re-opened? I've updated Godot to the latest version (Beta 8) and the issue persist even though it seemed it might have been fixed here #65035.
Still getting an infinite amount of "E 0:00:21:0732   merge_with: AABB size is negative, this is not supported. Use AABB.abs() to get an AABB with a positive size." and this seems to be making the engine move very slow (loading/saving/running).


Orientation may not be set to reverse portrait

Screen orientation may not be set to reverse portrait or reverse landscape.
Screen orientation should use reverse values or be sensor-based.
Eg. like screenOrientation values defined here https://developer.android.com/guide/topics/manifest/activity-element.html
Steps to reproduce:

Modify config.xml to force screen orientation to portrait <preference name="orientation" value="portrait" />
Works as expected (screen orientation is portrait only).
Modify config.xml to force screen orientation to sensor portrait or reverse portrait <preference name="orientation" value="sensorPortrait" />
Value is ignored and screen orientation is invalid.

@jgw96 I don't think issue applies to ionic-framework, but cordova. do you agree?


Support AutoFac 9, Serilog 3, .NET 4.8.1

Hello, I am using the above versions. When I installed this package, I get a yellow triangle:

Visual Studio is fantastic about not telling me why. I can only assume all of my dependencies and my project are not a match for this project. Is an update possible? Did I install it wrong?

Hi Victorio! Thanks for reaching out. I haven't dug into this project for a while, I think things are getting a little too far behind.... A PR that updates the target frameworks and dependency versions to modern ones would be more than welcome, if you're able to take a look?


IoT Extension Release v0.10.11

Notes for this extension release can be found here:
https://github.com/Azure/azure-iot-cli-extension/releases/tag/v0.10.11

This checklist is used to make sure that common guidelines for a pull request are followed.

For new extensions:

[ ] My extension description/summary conforms to the Extension Summary Guidelines.

About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your PR is merged into master branch, a new PR will be created to update src/index.json automatically.
The precondition is to put your code inside this repo and upgrade the version in the PR but do not modify src/index.json.

IoT

/azp run


control_toolbox: 2.0.1-1 in 'foxy/distribution.yaml' [bloom]

Increasing version of package(s) in repository control_toolbox to 2.0.1-1:

upstream repository: https://github.com/ros-controls/control_toolbox.git
release repository: https://github.com/ros-gbp/control_toolbox-release.git
distro file: foxy/distribution.yaml
bloom version: 0.9.7
previous version for package: 2.0.0-1

control_toolbox
* Fix dependencies
* Export ament_cmake build type
* Contributors: ahcorde

This should fix the failures seen on the build farm from the last release.


Adds Select All functionality

Looks like this was just missing from the edit menu. Added.

#225

Goddammit these Pr's come in before I can find my mac lol...
Thanks for this, this was exactly the change I was going to implement

Ahhh crap, this is what I get for not letting the build finish.
Please run the linter before pushing to a pull request.  The build failed on some quote style issues

Ah crap, sorry! Thought I double-checked my quotes... Also, didn't notice the lint script... I'll slow down :checkered_flag:


Adding workarounds for issues 93 and 95

@nickdgriffin, the workarounds for the issues:
Issue 93 - "Reference_Application_Performance_Tests job failing due to not finding apache-jmeter-2.13.tgz": https://github.com/Accenture/adop-docker-compose/issues/93 and
Issue 95 - "Reference_Application_Regression_Tests job randomly failing because the 2 containers are not created on the same hosts": https://github.com/Accenture/adop-docker-compose/issues/95
were committed to this file.

LGTM. The archive.apache.org location for JMeter artifact should be permanent, so more than a workaround, I think is the best solution, and gives total control to decide when to jump to the next 3.x release of JMeter. Thanks!

@deors, I am going to close this pull request and create another one. This has just one commit for the 2 fixes. I am going to add a commit per fix.


Allow commands to run on a single stack, multiple or all stacks

Allows running commands on multiple or all stacks.  I need to add a cucumber scenario for this.

Next up will be adding a --changed option to only execute commands on changed stacks. This will be useful to run on CI to post stack diffs to PRs. stack_master diff --changed.

+1 no matter which way the question I posed is answered.

I'm unclear about the code path for:
stack_master apply us-east-1
Is that just getting destructured to region, nil? If so... nice!
We should probably add something to the readme about this?
:+1:

@gstamp yep:
❯ irb
irb(main):001:0> ['us-east-1'].each_slice(2).to_a
=> [["us-east-1"]]

irb(main):002:0> ['us-east-1'].each_slice(2) {|r,s| puts "r: #{r}, s: #{s.class}" }
r: us-east-1, s: NilClass
=> nil
irb(main):003:0>

Good point I'll update the readme before merging.

:+1:


Add HMOS code.

I have added whatever changes I did for porting. but this PR not completely ported (only 30-40 % work done). And there are some errors which will need to be fix.

@Click2cloud-Eros Can you please failure reason -

What went wrong:
Task 'checkstyle' not found in root project 'FastScroll-RecyclerView'.

Actually I have not configure checkstyle, Sonarqube yet in this project.

@sharathks84 Please add<EMAIL_ADDRESS>to this project for further development.

Hi,
Please add me


Specify the metric to order by for Series Limit

Used to be based on the first metric from the metric multi-choice, but there's the use case where you don't want to show the metric you are sorting by. It will still default to use the first metric if the new select is empty

👍 Thanks a lot Maxim. Your very quick help was well above my expectation :)

@mistercrunch Hi, do you have any plan on enabling metrics ordering? For example, I want to show the first metric on the left in the visualization, but it is always the largest on the left. Just asking... I know you have to prioritize everything. Thanks a lot!

How to specify the order by on metrics (computed columns) ?
For ex. if i want to show only top rows after order by  "particular_metric asc". What should i do. It looks like superset/caravel always sort in "desc". How to change that ?. Theres no field for that.


remove last byte

They aren't needed. The same is true for the kefctl module.
I do not known perl and I didn't test.
In my aiokef Python package I confirm that this works.

You are correct. And i still have not the slightest idea what the last byte is supposed to do in the protocol.


CI: Test for min requirements

This PR checks for the minimum requirements in as mentioned in the README file.
Since we are specifying some minimum versions for the dependencies in the README file, I thought it would be a good idea to check for those minimum versions in the CI. If in future, we unknowingly use functions from the dependencies that are not available in the older versions, that would be problematic.

I think what I was trying to say is maybe we should only use minimum requirements in test?

I think what I was trying to say is maybe we should only use minimum requirements in test?

One possible downside is: if someone has a newer version in their system, in that case, they still need to uninstall the newer one and install the older one.

If we use requirements.txt, it will have version fixed. But if we use just pip install, it will use newer versions, won't it?

If we use requirements.txt, it will have version fixed. But if we use just pip install, it will use newer versions, won't it?

If we use == it will install that exact version, >= will install the latest version.

What I think, we should always use the latest version so that we have the latest and greatest features (that are supported by the minimum version as well), but if we want to use a new feature that is only available in the latest version, we will simply bump up the minimum version.

If we use requirements.txt, it will have version fixed. But if we use just pip install, it will use newer versions, won't it?

If we use == it will install that exact version, >= will install the latest version.

OK. Good. Here is what I think:
We can test every possible combinations. So I'd say we clean out test to:

Highest Python 2 (2.7) with fixed version
Highest Python 2 (2.7) with latest version
Highest Python 3 (non-dev) with fixed version
Highest Python 3 (non-dev) with latest version

And don't worry about other versions for now. We can add later if someone ask for.

What I think, we should always use the latest version so that we have the latest and greatest features (that are supported by the minimum version as well), but if we want to use a new feature that is only available in the latest version, we will simply bump up the minimum version.

We can use just == in requirements. That also works.

@yunhailuo Done! :smiley:

Do you know why requirements are installed twice: https://travis-ci.com/yunhailuo/xena-GDC-ETL/jobs/204304313#L443-L513?

Should pip install . be independent so that it could check installation without pre-install requirements?

Is there something we can to to better organize 4 jobs (except lint) in tests? Two are now run with global setting and two are run without. It's not straight forward to understand. But I'm not expert on tests either. One way I'm looking at possible combination:

pip install . with Python 3 without pre-installing requirements since it uses requirements anyway;
pip install . with Python 2 without pre-installing requirements since it uses requirements anyway;
pip install -r min-requirements.txt with following installments and tests in Python 3
pip install -r min-requirements.txt with following installments and tests in Python 2
Lint tests

It feels really wrong to allow failure on tests. Maybe we should fix lint, though it's not a priority at all.

I think makefile might be overkill here, though I'm not sure. I'll merge this PR and play on top of it a little bit myself. Nice job!

Renaming left!

Renaming left!

That's fine. The goal of this PR is achieved. Simplify/reorganizing tests can be another PR.

This PR is ready. :tada:


fixme(fasthttp/router): upgrade fasthttp router to solve '/'

router: /v1/publish/{pubsubname}/{topic:*}
request1:
/v1/publish/pubsubname1/topic1   RequestCtx  {topic: "topic1"}
/v1/publish/pubsubname1/ RequestCtx {topic: ""}  not {topic: "/"}
fasthttp/router pr47

/cc @yaron2 @mukundansundar this is technically a breaking change but I believe this is a legit fix for a corner case. The impact is that apps that were getting 404 for topic name as "/" will now get a 204 success.

/cc @yaron2 @mukundansundar this is technically a breaking change but I believe this is a legit fix for a corner case. The impact is that apps that were getting 404 for topic name as "/" will now get a 204 success.

I agree, it's a fix. If anything, it'll allow apps to have topics named /, not that I understand why anyone would choose such a topic name.


Bump omnibus software

/cc @adamleff @chef/engineering-services @scotthain

:+1:

Not a "maintainer," but :+1: since my omnibus changes are causing to software definition issues you're likely hitting :)


[Build] Darwin test failed  -[MTRXPCListenerSampleTests test900_SubscribeClusterStateCache]

Build issue(s)
2023-06-27T05:25:37.9210620Z 2023-06-27 05:25:37.918 xcodebuild[85838:204236] [MT] IDETestOperationsObserverDebug: 151.145 sec, +151.145 sec -- end
2023-06-27T05:25:43.5069200Z Failing tests:
2023-06-27T05:25:43.5069390Z
2023-06-27T05:25:43.5070160Z 	-[MTRXPCListenerSampleTests test900_SubscribeClusterStateCache]
2023-06-27T05:25:43.5070520Z Test session results, code coverage, and logs:
2023-06-27T05:25:43.5070700Z
2023-06-27T05:25:43.5078630Z ** TEST FAILED **
2023-06-27T05:25:43.5078830Z
2023-06-27T05:25:43.5080000Z 	/Users/runner/Library/Developer/Xcode/DerivedData/Matter-fezxjrcgbvmiwkgpcrhtmcinmudo/Logs/Test/Test-Matter Framework Tests-2023.06.27_05-13-40-+0000.xcresult
2023-06-27T05:25:43.5080670Z
2023-06-27T05:25:43.5139080Z Testing started
2023-06-27T05:25:48.5399760Z ##[error]Process completed with exit code 65.

https://github.com/project-chip/connectedhomeip/actions/runs/5385718043/jobs/9775015395
Platform
No response
Anything else?
No response

Failing bit:
2023-06-27T05:25:19.1145580Z /Users/runner/work/connectedhomeip/connectedhomeip/src/darwin/Framework/CHIPTests/MTRXPCListenerSampleTests.m:1793: error: -[MTRXPCListenerSampleTests test900_SubscribeClusterStateCache] : (([result[@"data"][@"value"] boolValue]) equal to (YES)) failed: ("NO") is not equal to ("YES")
2023-06-27T05:25:19.1249260Z Test Case '-[MTRXPCListenerSampleTests test900_SubscribeClusterStateCache]' failed (9.273 seconds).

This looks like a racy test to me.  It sends an "on" command and then once we get the response to that command it fulfills the expectation we are waiting on.  Once that happens we try to read the cached data.  In this case you can see in the log that this read is happening interleaved with (on a different thread) us getting the actual data report that would update said cached data.
This is actually quite easy to reproduce if I change the min-interval for the subscription to 10.

I guess the test has a sleep(1) to try to make it pass...but that's still racy.

And it looks like the XPC subscribe API does not report attribute bits, so there is no way to wait until we actually get the report.


adobe-air-sdk imported

See Homebrew/homebrew#37104.

I got the same problem with another formulae move: if you make a pull request to add it to a tap while the PR on the main repo has not yet been merged, the bot audits the formula from the main repo instead of this one. This is why this build failed saying the formula should have a test do block even if it has one (because the formula in the main repo doesn’t).


[stable/nextcloud] add subPath option

What this PR does / why we need it:
This PR allows setting a subPath for nextcloud's folders. I use the standard configuration option used by many other helm charts, by adding nextcloud.persistence.subPath option. If this option is set, instead of mounting nextcloud data at data, themes etc. in the storage volume, instead it will mount at $subPath/data, $subPath/themes etc.
Special notes for your reviewer:
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

[x] DCO signed
[x] Chart Version bumped
[x] Variables are documented in the README.md
[x] Title of the PR starts with chart name (e.g. [stable/mychartname])

Maintainers: @chrisingenhaag @billimek

/assign @billimek
/ok-to-test

/ok-to-test

/lgtm


[WFLY-4424] Temporary fix not requiring core upgrade

Windows Build 1225 is now running using a merge of 944d381c9bfa941015b568a76c75552398195813

Linux Build 6112 is now running using a merge of 944d381c9bfa941015b568a76c75552398195813

Linux with security manager Build 1089 is now running using a merge of 944d381c9bfa941015b568a76c75552398195813

Linux with security manager Build 1089 outcome was SUCCESS using a merge of 944d381c9bfa941015b568a76c75552398195813
Summary: Tests passed: 814, ignored: 352 Build time: 0:05:19

Linux Build 6112 outcome was SUCCESS using a merge of 944d381c9bfa941015b568a76c75552398195813
Summary: Tests passed: 2828, ignored: 412 Build time: 0:47:31

Windows Build 1225 outcome was SUCCESS using a merge of 944d381c9bfa941015b568a76c75552398195813
Summary: Tests passed: 2828, ignored: 412 Build time: 0:48:01

@asoldano needs a rebase

this should be closed as there was core release and proper fix was already merged.


replace copyrights headers/comments in kogito-images

Will be done via https://github.com/apache/incubator-kie-kogito-images/pull/1708


Compatibility with numpy 1.10.1

Numpy 1.10 apparently has stricter rules for casting floats as integers:
https://github.com/scikit-learn/scikit-learn/issues/5397
This causes an error with PyAbel as well, specifically for the example_hansenlaw.py.
I think that we just need to specifically cast the numbers to the correct types, but I think I recall there is something weird going on with a half-integer origin in the case of the hansen-law transform? @stggh
Here is the output from trying to run the example:
Daniels-MacBook-Pro-3:examples danhickstein$ python example_hansenlaw.py
Loading data/O2-ANU1024.txt.bz2
image size 1024x1024
Performing Hansen and Law inverse Abel transform:
HL: Calculating inverse Abel transform:  image size 1024x1024
HL: Individual quadrants
HL: Calculating inverse Abel transform ...
0.29 seconds
Generating speed distribution ...
Traceback (most recent call last):
  File "example_hansenlaw.py", line 52, in <module>
    recon, speeds = iabel_hansenlaw (im,quad=(False,False,False,False),verbose=True)
  File "/Users/danhickstein/Documents/PyAbel-master/abel/hansenlaw.py", line 210, in iabel_hansenlaw
    speeds = calculate_speeds(recon,origin=image_centre)
  File "/Users/danhickstein/Documents/PyAbel-master/abel/tools.py", line 24, in calculate_speeds
    polarIM, ri, thetai = reproject_image_into_polar(IM,origin)
  File "/Users/danhickstein/Documents/PyAbel-master/abel/tools.py", line 145, in reproject_image_into_polar
    x, y = index_coords(data, origin=origin)
  File "/Users/danhickstein/Documents/PyAbel-master/abel/tools.py", line 179, in index_coords
    x -= origin_x
TypeError: Cannot cast ufunc subtract output from dtype('float64') to dtype('int64') with casting rule 'same_kind'

Thanks to @ellisje624 for pointing this out.

np.meshgrid(np.arange(nx), np.arange(ny)) returns integer numpy.arrays for nx, ny integer.
A possible solution is to convert to float:
178,180c178
<     x, y = np.meshgrid(np.arange(nx), np.arange(ny))  # int numpy.array
<     x.astype(float)
<     y.astype(float)
---
>     x, y = np.meshgrid(np.arange(nx), np.arange(ny))

So, I'm pretty sure that the previous behavior was that the ints were being cast to floats, so I think that we indeed just need to cast the ints to floats explicitly (as you mentioned). The behavior should be identical.
I think that the following change is the most pleasing to the eye, since no new lines are required:
x, y = np.meshgrid(np.arange(float(nx)), np.arange(float(ny)))

Fixed!


PAINT touchup should not create NOT annotations for annotations that violate the taxon contraints.

Those annotations should be simply stripped.
See http://amigo.geneontology.org/amigo/term/GO:0071790
for an example.
(This comes form https://github.com/geneontology/go-annotation/issues/1819)
Thanks, Pascale

Duplicate of #15685


Add Verbose Logging Support to Diagnose Performance Issues

Sorry, this might be totally wrong place to open the issue. Feel free to close.
Anyway, I'm working with a 3rd party project* that uses your awesome wrapper and I'm having problems there, which brings me back here. Everything seems to be working, but not with the speed I expect after using plain llama.cpp. With some prompts it seems to even completely freeze, never completing the task. Could I somehow raise this wrapper's logging level to make it more verbose, so I could see in real-time as it works?
* https://github.com/hwchase17/langchain

Hi, thanks for submitting this issue!
Yes, we can add logging support!
If possible do you mind providing some of the following:

operating system (Linux / MacOS / Windows)
cpu architecture (x86 / M1)
python package manager (pip / conda / poetry)
langchain examples of slow / hanging completions

I'm adding verbose flag to the Llama instance but in the meantime can you try (and kindly post here if possible) the following.
from langchain.llms import LlamaCpp
import llama_cpp

# change model path
llm = LlamaCpp(model_path="./ggml-model-q4_0.bin")
ctx = llm.client.ctx # this returns the llama.cpp context
llama_cpp.llama_print_system_info()
llama_cpp.llama_reset_timings(ctx)
llm("Some example phrase")
llama_cpp.llama_print_timings(ctx)

And let me know if the output of print_system_info matches what you get when you run e.g. ./main in llama.cpp

Gotcha, it looks like it compiled correctly wrt optimisations.
There are a few knobs for the Llama class that aren't exposed in LangChain (I'll try to create a PR for those soon) but you should be ale to replace the instance in the embedding class with a new "more tuned" version as follows:
new_llama = Llama(**kwargs)
LlamaCpp.client = new_llama

The kwargs I'd play with are

n_threads: Anywhere between cpu_count / 2 to cpu_count should be ideal
use_mlock: True
f16_cache: True
n_batch: Set the max value of this to your n_ctx this effects how many tokens get eval'd at once.

Let me know if any of that helps.

Could not make it work without getting:
ValueError: llm must be an instance of langchain.llms.base.LLM
Quite possibly I did it wrong though. I tried it with LlamaCpp and LlamaCppEmbeddings with same result.
from llama_cpp import Llama
new_llama = Llama(**LlamaArgs)
LlamaCpp.client = new_llama

# define our LLM
llama_llm = LlamaCpp.client
predictor = LLMPredictor(llm=llama_llm)

With the original llama_llm = LlamaCpp(**LlamaArgs) line, I would just get multiple instances (and the error for unknown arg)

Sorry I think you might have misunderstood, you should still initialise the llm from as a LlamaCpp class but then just replace the internal client.
llama_llm = LlamaCpp(**LlamaArgs)
llama_internal = llama_cpp.Llama(n_ctx=2048, n_batch=2048, use_mlock=True, f16_cache=True, embedding=True)
llama_llm.client = llama_internal
predictor = LLMPredictor(llm=llama_llm)


Tests failing in forge

Component
Forge
Have you ensured that all of these are up to date?

[X] Foundry
[X] Foundryup

What version of Foundry are you on?
forge 0.2.0 (0e1d52d 2022-10-31T00:04:54.74416Z)
What command(s) is the bug in?
forge test
Operating System
macOS (Apple Silicon)
Describe the bug
The code for setUp is as follows:
    contract ClaimTest is Test {
    Claim public claim;
    NFTContract public nftContract = new NFTContract();

    function setUp() external {
        nftContract.mint();
        claim = new Claim(address(nftContract));
    }
}

The test command with -vvvv flag throws this error

can you try after running foundryup?


Update README.md

Updating README in accordance with this issue: https://github.com/covid19risk/covidwatch-android/issues/110

Removed a lot of the discussion of methodology as I figured that should live in a TCN repo/doc


Multiple duplicate lines in choco console UI (but not log file)

What You Are Seeing?
When installing or updating a package, the console often shows multiple (2 or 3) duplicates of the log messages that show after the Exporting function, Importing function, and Importing alias lines.
One example:
[INFO ] - VERBOSE: Refreshing environment variables from the registry.
[INFO ] - VERBOSE: Refreshing environment variables from the registry.
[INFO ] - VERBOSE: Refreshing environment variables from the registry.
[INFO ] - VERBOSE: Refreshing environment variables from the registry.
[INFO ] - Restricting write permissions to Administrators
[INFO ] - Restricting write permissions to Administrators
[INFO ] - Restricting write permissions to Administrators
[INFO ] - Restricting write permissions to Administrators
[INFO ] - We are setting up the Chocolatey package repository.
[INFO ] - We are setting up the Chocolatey package repository.
[INFO ] - We are setting up the Chocolatey package repository.
[INFO ] - We are setting up the Chocolatey package repository.

What is Expected?
Each line should only show up once.
How Did You Get This To Happen? (Steps to Reproduce)

Turn on "Show console output".
Install or update any package.
Notice the ongoing log, especially after the "Exporting/Importing function" messages.

System Details

OS Build: Windows 7
Windows PowerShell version: The ChocolateyGUI inbuilt one
Chocolatey version: The example I used above happened when upgrading from 1.0.1 to 1.1.0

Output Log
N/A - The log file correctly shows only one line for each message. This seems to be a UI problem only.

I've been seeing this a lot in recent weeks. I'm using Windows 10, with Chocolatey 1.10 and ChocolateyGUI <IP_ADDRESS>.
It worries me when I see things like the below, as it looks like it's downloading and installing twice:
Downloading libreoffice-fresh 64 bit
  from 'https://download.documentfoundation.org/libreoffice/stable/7.3.2/win/x86_64/LibreOffice_7.3.2_Win_x64.msi'
Downloading libreoffice-fresh 64 bit
  from 'https://download.documentfoundation.org/libreoffice/stable/7.3.2/win/x86_64/LibreOffice_7.3.2_Win_x64.msi'

Download of LibreOffice_7.3.2_Win_x64.msi (332.01 MB) completed.
Download of LibreOffice_7.3.2_Win_x64.msi (332.01 MB) completed.
Installing libreoffice-fresh...
Installing libreoffice-fresh...

It worries me when I see things like the below, as it looks like it's downloading and installing twice:

Indeed. That was the very reason my attention was grabbed by this bug. Downloading 600+ MB instead of 300+ MB would have been a huge waste of data. It was only after browsing the log that I realised this was not the case.

I can reproduce this issue as well

I hit this the other day while testing some things.

@gep13 want me to do anything here to bring this issue up?

Has this been fixed yet? Here's some more info on this bug: The duplicate lines increase every time you install Chocolatey GUI. I got 3 lines after the latest update, uninstalled the GUI, reinstalled the GUI, now I have 4 lines duplicated. This perhaps isn't just a bug with the program, but possibly some resident config setting that doesn't get cleaned, and duplicates itself every time you install the GUI. I don't know where these settings are hidden, so I have no idea how to clean them myself.

@DefectiveByDesign unfortunately although we had hoped to get this fix into 1.1.0, the change I made in PR #954 introduced an even bigger and worse bug (in a certain scenario you lost all logging and all console output). However, knowing that the number of duplicate lines increases is good information. As for where the config is stored, we don't currently have it documented officially, but some of them are captured in a docs issue here: https://github.com/chocolatey/docs/issues/303

@DefectiveByDesign You might be onto something. I'm 85–90% certain I've also un/reinstalled ChocolateyGUI in the past. It would've been a while back, though, hence the uncertainty.

It isn't just reinstalling, billyjo, simply updating to a new version will do it. As for the config files, is it safe to delete them? What would be the protocol for a clean uninstall / reinstall? I don't really understand the reasoning behind chocolatey not having a clean uninstall. This behavior is well known to be problematic with various software. Drivers for instance, created a need for DDU, and there are various uninstall tools, which some charge money for, that will monitor software installation to do "true" uninstallation. Some other programs I've known to need special cleaning has been various DRM, virtual CD software with drivers, motherboard utilities like Asus, Dell bloatware. There used to be stuff like PC decrapifier, which I think is no longer supported, but the need still exists. I shouldn't have to wipe the OS to fix software that doesn't uninstall properly.
Recently, updates in general seem to be a problem with chocolately, more than years ago. Many programs refuse to update. I have to uninstall them and reinstall, instead of using the update function. Sometimes the update function breaks the program even if it installs, like LibreOffice, which would load the writer then crash, which I fixed by uninstalling / reinstall. These problems don't exist with the old fashioned update process, just when using chocolatey, and it isn't with all updates either, so maybe the majority updates, but you're always left with a couple that don't. Kinda defeats the purpose.

The duplicate lines increase every time you install Chocolatey GUI.

I'm not denying whether or not the above is true, but for interest I have just installed Chocolatey and Chocolatey-GUI onto a brand-new Windows 11 laptop, used Chocolatey-GUI to install Firefox and saw duplicate lines (2 lines) immediately.

The duplicate lines increase every time you install Chocolatey GUI.

I'm not denying whether or not the above is true, but for interest I have just installed Chocolatey and Chocolatey-GUI onto a brand-new Windows 11 laptop, used Chocolatey-GUI to install Firefox and saw duplicate lines (2 lines) immediately.

This has been going on for years - duplicate output lines....

I'm rugging on chocolatey 2.2.2 and chocolateygui 2.1.0 and also have this multiple line output issue.
Is there a time-frame when this bug is solved, or for the first response, are only the log messages multyplied or are even the downloads and install proccesses multyplied?


Adopt Exoplayer 2.16 for Android 12 compatiblity

https://medium.com/google-exoplayer/exoplayer-2-16-whats-new-785afe47ef95
Includes easier track selection.  Could help with direct play and changing tracks.

Upgraded the library to 2.16.1, no code changes were necessary.


Allow hiding Accounts icon when Activity Bar Position is Top

Previously, the Accounts icon in the title bar could not be hidden when the Activity Bar Position was set to Top. This pull request fixes this issue by adding the ability to hide the Accounts icon in the title bar when the Activity Bar Position is set to Top.
As it's very hard to support the the same context menu across the activity actions and the layout/editor actions, we decided we would have a different context menu just for the two global activity actions (Manage and Accounts)
Fixes #197306

If it's a toolbar similar to the layout icons, shouldn't we let them hide settings too?

@daviddossett We don't allow users to hide that action in the default activity bar layout as well. This change aligns the behaviour with the default layout. @sandy081 has more knowledge on the reasoning for this

Yes, we do not allow hiding Settings action mainly because it contains application update information. One can argue it can be user choice but we have no ask for that so far.

Being consistent with the default activity bar behavior seems like a good starting point 👍


[(minor) cosmetical issue] Missing connection on topology graph

I would expect the nodes to be connected with the gateway. Just a minor issue ;-)

@cimba007 This is expected in MySensors network. If you unchecked Realtime you will see the topology diagram based on relations ships in database. When you check Realtime It will show you how nodes connected on real time. Every 30 minutes once real time graph will be updated. You can update manually by calling Discover on gateway page.
Important: This feature supports only on MySensors 2.0 version

Jep, working perfectly, my mistake ;-)


Revert PR11313

CC @Justicea83
Details
Revert a PR which introduced regressions to native mobile file upload
Fixed Issues

$ https://github.com/Expensify/App/issues/12466
Tests

Attempt to upload an unsupported file, something like .heic
Either the upload should succeed (native iOS), or you should see an error modal preventing the upload
However, iOS web will show the same behaviour as the regression

QA Steps

Run above test

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] iOS / native
[x] Android / native
[x] iOS / Safari
[x] Android / Chrome
[x] MacOS / Chrome
[x] MacOS / Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product was added in all src/languages/* files
[x] I verified any copy / text that was added to the app is correct English and approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)

[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

PR Reviewer Checklist
The reviewer will copy/paste it into a new comment and complete it after the author checklist is completed

[ ] I have verified the author checklist is complete (all boxes are checked off).
[ ] I verified the correct issue is linked in the ### Fixed Issues section above
[ ] I verified testing steps are clear and they cover the changes made in this PR

[ ] I verified the steps for local testing are in the Tests section
[ ] I verified the steps for Staging and/or Production testing are in the QA steps section
[ ] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[ ] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[ ] I checked that screenshots or videos are included for tests on all platforms
[ ] I included screenshots or videos for tests on all platforms
[ ] I verified tests pass on all platforms & I tested again on:

[ ] iOS / native
[ ] Android / native
[ ] iOS / Safari
[ ] Android / Chrome
[ ] MacOS / Chrome
[ ] MacOS / Desktop

[ ] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
[ ] I verified proper code patterns were followed (see Reviewing the code)

[ ] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[ ] I verified that comments were added to code that is not self explanatory
[ ] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[ ] I verified any copy / text shown in the product was added in all src/languages/* files
[ ] I verified any copy / text that was added to the app is correct English and approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[ ] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[ ] I verified the JSDocs style guidelines (in STYLE.md) were followed

[ ] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[ ] I verified that this PR follows the guidelines as stated in the Review Guidelines
[ ] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
[ ] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[ ] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[ ] If a new component is created I verified that:

[ ] A similar component doesn't exist in the codebase
[ ] All props are defined accurately and each prop has a /** comment above it */
[ ] The file is named correctly
[ ] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[ ] The only data being stored in the state is data necessary for rendering and nothing else
[ ] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[ ] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[ ] All JSX used for rendering exists in the render method
[ ] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[ ] If a new CSS style is added I verified that:

[ ] A similar style doesn't already exist
[ ] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)

[ ] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[ ] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[ ] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots

Web

Mobile Web - Chrome

Mobile Web - Safari

Issue still occurs -- as expected

Desktop

iOS

Android

We're ignoring the checklist

Not an emergency. Tested and testing again on staging now 👍

@Julesssss So upload works but no loading image, Does it look like Pass?
https://user-images.githubusercontent.com/43995119/199995672-44ba366a-20a8-4836-981a-0a136a2b036d.mp4

Hey @mvtglobally, that seems like a pass to me. This is an odd issue as different browsers/clients handle this differently. For example, iOS uploads successfully.
So yes, as long as the images upload successfully or show the 'Attachment is the wrong type' modal, this is a pass for all platforms. On Android we should see the Modal 👍

Yeah. It also seem to be file specific. Same use tried another file and get the error

Excellent, thanks. I just verified Android:

🚀 Cherry-picked to staging by @Julesssss in version: 1.2.23-9 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

Asking in Slack for an iOS user to confirm this. As it appears to be converted to a .jpg file for me when I download it to my device 😖

@Julesssss It happens to me too.

🚀 Deployed to production by @Julesssss in version: 1.2.23-9 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Cherry-picked to staging by https://github.com/AndrewGable in version: 1.3.28-2 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

🚀 Deployed to production by https://github.com/AndrewGable in version: 1.3.28-5 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅