Cilium 1.13.0 restart requires an app reconnect

Start minikube
minikube start --driver=docker --network-plugin=cni

Install Cilium
$ cilium version
cilium-cli: v0.13.1 compiled with go1.20 on linux/amd64
cilium image (default): v1.13.0
cilium image (stable): v1.13.0
$
$ cilium install --version v1.13.0

Wait until Cilium pods are ready
sleep 2s
kubectl wait --for=condition=Ready=true pods -l k8s-app=cilium -n kube-system --timeout=60s

Deploy some apps
kubectl apply --force=false -f ./test/k8s/manifests/migrate-svc-client.yaml
kubectl apply --force=false -f ./test/k8s/manifests/migrate-svc-server.yaml

Wait until the apps are ready:
kubectl wait --for=condition=Ready=true pods -l zgroup=migrate-svc

$ kubectl get pods -A -o wide -w
NAMESPACE     NAME                               READY   STATUS    RESTARTS        AGE     IP             NODE       NOMINATED NODE   READINESS GATES
default       migrate-svc-client-2jsl7           1/1     Running   0               20s     <IP_ADDRESS>     minikube   <none>           <none>
default       migrate-svc-client-4dpt8           1/1     Running   0               20s     <IP_ADDRESS>      minikube   <none>           <none>
default       migrate-svc-client-884zx           1/1     Running   0               20s     <IP_ADDRESS>     minikube   <none>           <none>
default       migrate-svc-client-bf7qd           1/1     Running   0               20s     <IP_ADDRESS>     minikube   <none>           <none>
default       migrate-svc-client-qhxds           1/1     Running   0               20s     <IP_ADDRESS>      minikube   <none>           <none>
default       migrate-svc-server-dch4f           1/1     Running   0               20s     <IP_ADDRESS>     minikube   <none>           <none>
default       migrate-svc-server-fqfjp           1/1     Running   0               20s     <IP_ADDRESS>     minikube   <none>           <none>
default       migrate-svc-server-fxxth           1/1     Running   0               20s     <IP_ADDRESS>     minikube   <none>           <none>
kube-system   cilium-m8w6j                       1/1     Running   0               63s     <IP_ADDRESS>   minikube   <none>           <none>
kube-system   cilium-operator-864b7b486c-sbz5h   1/1     Running   0               63s     <IP_ADDRESS>   minikube   <none>           <none>
kube-system   coredns-787d4945fb-prgjg           1/1     Running   0               30s     <IP_ADDRESS>     minikube   <none>           <none>
kube-system   etcd-minikube                      1/1     Running   0               4m44s   <IP_ADDRESS>   minikube   <none>           <none>
kube-system   kube-apiserver-minikube            1/1     Running   0               4m42s   <IP_ADDRESS>   minikube   <none>           <none>
kube-system   kube-controller-manager-minikube   1/1     Running   0               4m44s   <IP_ADDRESS>   minikube   <none>           <none>
kube-system   kube-proxy-l595b                   1/1     Running   0               4m28s   <IP_ADDRESS>   minikube   <none>           <none>
kube-system   kube-scheduler-minikube            1/1     Running   0               4m42s   <IP_ADDRESS>   minikube   <none>           <none>
kube-system   storage-provisioner                1/1     Running   1 (3m58s ago)   4m41s   <IP_ADDRESS>   minikube   <none>           <none>

Restart Cilium agent:
kubectl delete pod  -n kube-system -l k8s-app=cilium

Check that apps got restarted:
kubectl get pods -A -o wide
NAMESPACE     NAME                               READY   STATUS    RESTARTS        AGE     IP             NODE       NOMINATED NODE   READINESS GATES
default       migrate-svc-client-2jsl7           1/1     Running   2 (96s ago)     2m15s   <IP_ADDRESS>     minikube   <none>           <none>
default       migrate-svc-client-4dpt8           1/1     Running   2 (96s ago)     2m15s   <IP_ADDRESS>      minikube   <none>           <none>
default       migrate-svc-client-884zx           1/1     Running   2 (96s ago)     2m15s   <IP_ADDRESS>     minikube   <none>           <none>
default       migrate-svc-client-bf7qd           1/1     Running   2 (96s ago)     2m15s   <IP_ADDRESS>     minikube   <none>           <none>
default       migrate-svc-client-qhxds           1/1     Running   2 (96s ago)     2m15s   <IP_ADDRESS>      minikube   <none>           <none>
default       migrate-svc-server-dch4f           1/1     Running   1 (84s ago)     2m15s   <IP_ADDRESS>     minikube   <none>           <none>
default       migrate-svc-server-fqfjp           1/1     Running   1 (84s ago)     2m15s   <IP_ADDRESS>     minikube   <none>           <none>
default       migrate-svc-server-fxxth           1/1     Running   1 (84s ago)     2m15s   <IP_ADDRESS>     minikube   <none>           <none>
kube-system   cilium-l627f                       1/1     Running   0               106s    <IP_ADDRESS>   minikube   <none>           <none>
kube-system   cilium-operator-864b7b486c-sbz5h   1/1     Running   0               2m58s   <IP_ADDRESS>   minikube   <none>           <none>
kube-system   coredns-787d4945fb-prgjg           1/1     Running   0               2m25s   <IP_ADDRESS>     minikube   <none>           <none>
kube-system   etcd-minikube                      1/1     Running   0               6m39s   <IP_ADDRESS>   minikube   <none>           <none>
kube-system   kube-apiserver-minikube            1/1     Running   0               6m37s   <IP_ADDRESS>   minikube   <none>           <none>
kube-system   kube-controller-manager-minikube   1/1     Running   0               6m39s   <IP_ADDRESS>   minikube   <none>           <none>
kube-system   kube-proxy-l595b                   1/1     Running   0               6m23s   <IP_ADDRESS>   minikube   <none>           <none>
kube-system   kube-scheduler-minikube            1/1     Running   0               6m37s   <IP_ADDRESS>   minikube   <none>           <none>
kube-system   storage-provisioner                1/1     Running   1 (5m53s ago)   6m36s   <IP_ADDRESS>   minikube   <none>           <none>

The above bug is NOT happening with Cilium 1.12.5

@aanm Thanks for the issue! Do you have a sysdump before and after?

@aanm Thanks for the issue! Do you have a sysdump before and after?

@brb
before: cilium-sysdump-20230306-144708.zip
after: cilium-sysdump-20230306-144842.zip
$ kubectl get pods -A -o wide
NAMESPACE     NAME                               READY   STATUS    RESTARTS       AGE     IP             NODE       NOMINATED NODE   READINESS GATES
default       migrate-svc-client-2jjbp           1/1     Running   2 (36s ago)    2m15s   <IP_ADDRESS>     minikube   <none>           <none>
default       migrate-svc-client-45s7g           1/1     Running   2 (36s ago)    2m14s   <IP_ADDRESS>     minikube   <none>           <none>
default       migrate-svc-client-dz58v           1/1     Running   2 (36s ago)    2m14s   <IP_ADDRESS>     minikube   <none>           <none>
default       migrate-svc-client-z9946           1/1     Running   2 (36s ago)    2m14s   <IP_ADDRESS>      minikube   <none>           <none>
default       migrate-svc-client-ztq2j           1/1     Running   2 (36s ago)    2m14s   <IP_ADDRESS>      minikube   <none>           <none>
default       migrate-svc-server-bkhz5           1/1     Running   0              2m14s   <IP_ADDRESS>      minikube   <none>           <none>
default       migrate-svc-server-hbb8j           1/1     Running   1 (24s ago)    2m14s   <IP_ADDRESS>      minikube   <none>           <none>
default       migrate-svc-server-rnkhf           1/1     Running   1 (24s ago)    2m14s   <IP_ADDRESS>     minikube   <none>           <none>
kube-system   cilium-operator-864b7b486c-k79k7   1/1     Running   0              2m53s   <IP_ADDRESS>   minikube   <none>           <none>
kube-system   cilium-r4dgv                       1/1     Running   0              46s     <IP_ADDRESS>   minikube   <none>           <none>
kube-system   coredns-787d4945fb-q6jsr           1/1     Running   0              2m21s   <IP_ADDRESS>     minikube   <none>           <none>
kube-system   etcd-minikube                      1/1     Running   0              3m44s   <IP_ADDRESS>   minikube   <none>           <none>
kube-system   kube-apiserver-minikube            1/1     Running   0              3m47s   <IP_ADDRESS>   minikube   <none>           <none>
kube-system   kube-controller-manager-minikube   1/1     Running   0              3m44s   <IP_ADDRESS>   minikube   <none>           <none>
kube-system   kube-proxy-jtprb                   1/1     Running   0              3m31s   <IP_ADDRESS>   minikube   <none>           <none>
kube-system   kube-scheduler-minikube            1/1     Running   0              3m44s   <IP_ADDRESS>   minikube   <none>           <none>
kube-system   storage-provisioner                1/1     Running   1 (3m1s ago)   3m44s   <IP_ADDRESS>   minikube   <none>           <none>

Thanks. The migrate-svc-* pod logs are missing. Could you paste them collected after the upgrade?

Thanks. The migrate-svc-* pod logs are missing. Could you paste them collected after the upgrade?

@brb
$ kubectl get pods -A
NAMESPACE     NAME                               READY   STATUS    RESTARTS        AGE
default       migrate-svc-client-7d5vr           1/1     Running   2 (108s ago)    3m44s
default       migrate-svc-client-7d745           1/1     Running   2 (108s ago)    3m44s
default       migrate-svc-client-bss2b           1/1     Running   2 (108s ago)    3m44s
default       migrate-svc-client-dpplz           1/1     Running   2 (108s ago)    3m44s
default       migrate-svc-client-mgb6b           1/1     Running   3 (95s ago)     3m44s
default       migrate-svc-server-692zr           1/1     Running   1 (96s ago)     3m44s
default       migrate-svc-server-gjgn5           1/1     Running   1 (96s ago)     3m44s
default       migrate-svc-server-nktkt           1/1     Running   0               3m44s
kube-system   cilium-8c6jl                       1/1     Running   0               117s
kube-system   cilium-operator-864b7b486c-9mdsx   1/1     Running   0               4m28s
kube-system   coredns-787d4945fb-b6btd           1/1     Running   0               3m47s
kube-system   etcd-minikube                      1/1     Running   0               4m41s
kube-system   kube-apiserver-minikube            1/1     Running   0               4m41s
kube-system   kube-controller-manager-minikube   1/1     Running   0               4m40s
kube-system   kube-proxy-m6qfk                   1/1     Running   0               4m29s
kube-system   kube-scheduler-minikube            1/1     Running   0               4m41s
kube-system   storage-provisioner                1/1     Running   1 (3m57s ago)   4m40s

logs.zip

Hmm, nothing interesting in the logs. Also, no changes in the drop counters. The affected packet path is the bpf_lxc's per-packet LB to ClusterIP.

There won't be any drop counter increasing: the apps restarted because of TCP RSTs.

One example from the last after sysdump:
$ cat hubble-flows-cilium-r4dgv-20230306-144842.json | ~/hubble/hubble observe --port 48158 --numeric
Mar  6 13:48:01.067: <IP_ADDRESS>:8000 (world) -> <IP_ADDRESS>:48158 (ID:55227) to-endpoint FORWARDED (TCP Flags: SYN, ACK)
Mar  6 13:48:01.067: <IP_ADDRESS>:8000 (world) -> <IP_ADDRESS>:48158 (ID:55227) to-endpoint FORWARDED (TCP Flags: ACK, PSH)
Mar  6 13:48:01.067: <IP_ADDRESS>:8000 (world) -> <IP_ADDRESS>:48158 (ID:55227) to-endpoint FORWARDED (TCP Flags: ACK)
Mar  6 13:48:02.568: <IP_ADDRESS>:48158 (ID:55227) -> <IP_ADDRESS>:8000 (ID:22641) to-endpoint FORWARDED (TCP Flags: ACK, PSH)
Mar  6 13:48:02.568: <IP_ADDRESS>:48158 (ID:55227) <- <IP_ADDRESS>:8000 (ID:22641) to-endpoint FORWARDED (TCP Flags: RST)
Mar  6 13:48:17.120: <IP_ADDRESS>:8000 (ID:22641) -> <IP_ADDRESS>:48158 (ID:55227) to-endpoint FORWARDED (TCP Flags: ACK)
Mar  6 13:48:17.120: <IP_ADDRESS>:48158 (ID:55227) -> <IP_ADDRESS>:8000 (ID:22641) to-endpoint FORWARDED (TCP Flags: RST)
Mar  6 13:48:32.351: <IP_ADDRESS>:8000 (ID:22641) -> <IP_ADDRESS>:48158 (ID:55227) to-endpoint FORWARDED (TCP Flags: ACK)
Mar  6 13:48:32.351: <IP_ADDRESS>:48158 (ID:55227) -> <IP_ADDRESS>:8000 (ID:22641) to-endpoint FORWARDED (TCP Flags: RST)
Mar  6 13:48:47.711: <IP_ADDRESS>:8000 (ID:22641) -> <IP_ADDRESS>:48158 (ID:55227) to-endpoint FORWARDED (TCP Flags: ACK)
Mar  6 13:48:47.711: <IP_ADDRESS>:48158 (ID:55227) -> <IP_ADDRESS>:8000 (ID:22641) to-endpoint FORWARDED (TCP Flags: RST)

No surprises here, we have a NAT issue. The server IP goes from <IP_ADDRESS> (clusterIP) to <IP_ADDRESS> (endpoint IP). That trace point is right before we deliver in the destination pod so we shouldn't see a service IP. Something was most likely broken before the restart.

Corresponding CT entries:
$ git grep :48158 cilium-bugtool-cilium-r4dgv-20230306-144842/cmd/cilium-bpf-ct-list-global.md
cilium-bugtool-cilium-r4dgv-20230306-144842/cmd/cilium-bpf-ct-list-global.md:TCP IN <IP_ADDRESS>:48158 -> <IP_ADDRESS>:8000 expires=126997 RxPackets=3 RxBytes=430 RxFlagsSeen=0x06 LastRxReport=126987 TxPackets=1 TxBytes=54 TxFlagsSeen=0x04 LastTxReport=126958 Flags=0x0013 [ RxClosing TxClosing SeenNonSyn ] RevNAT=0 SourceSecurityID=55227 IfIndex=0
cilium-bugtool-cilium-r4dgv-20230306-144842/cmd/cilium-bpf-ct-list-global.md:TCP OUT <IP_ADDRESS>:48158 -> <IP_ADDRESS>:8000 expires=126997 RxPackets=1 RxBytes=54 RxFlagsSeen=0x04 LastRxReport=126958 TxPackets=3 TxBytes=430 TxFlagsSeen=0x06 LastTxReport=126987 Flags=0x0013 [ RxClosing TxClosing SeenNonSyn ] RevNAT=4 SourceSecurityID=55227 IfIndex=0
cilium-bugtool-cilium-r4dgv-20230306-144842/cmd/cilium-bpf-ct-list-global.md:TCP IN <IP_ADDRESS>:8000 -> <IP_ADDRESS>:48158 expires=148587 RxPackets=7 RxBytes=1238 RxFlagsSeen=0x1a LastRxReport=126987 TxPackets=0 TxBytes=0 TxFlagsSeen=0x00 LastTxReport=0 Flags=0x0010 [ SeenNonSyn ] RevNAT=0 SourceSecurityID=2 IfIndex=0
cilium-bugtool-cilium-r4dgv-20230306-144842/cmd/cilium-bpf-ct-list-global.md:TCP OUT <IP_ADDRESS>:8000 -> <IP_ADDRESS>:48158 service expires=148587 RxPackets=0 RxBytes=11 RxFlagsSeen=0x00 LastRxReport=0 TxPackets=0 TxBytes=0 TxFlagsSeen=0x06 LastTxReport=126987 Flags=0x0012 [ TxClosing SeenNonSyn ] RevNAT=4 SourceSecurityID=0 IfIndex=0

Reverse NAT entries:
$ cat cilium-bugtool-cilium-r4dgv-20230306-144842/cmd/cilium-bpf-lb-list---revnat.md
ID   BACKEND ADDRESS (REVNAT_ID) (SLOT)
2    <IP_ADDRESS>:9153
4    <IP_ADDRESS>:8000
1    <IP_ADDRESS>:443
3    <IP_ADDRESS>:53

I couldn't reproduce it on Kind with multiple K8s Nodes. But once I switch to a single Node cluster (i.e., only with kind-control-plane), it's fairly easy to reproduce. From tcpdump / pwru output I see the same issue as described by @pchaigno - the rev DNAT xlation for the ClusterIP didn't happen, thus the TCP RST.

Issue debugged on a fairly stock config:
debug:
  enabled: true
  verbose: datapath
bpf:
  monitorAggregation: none
image:
  repository: quay.io/cilium/cilium-dev
  tag: latest
  pullPolicy: IfNotPresent
  useDigest: false
operator:
  enabled: true
  replicas: 1
  image:
    override: ~
    repository: quay.io/cilium/operator
    tag: latest
    useDigest: false
    pullPolicy: IfNotPresent
    suffix: ""

And a single node kind cluster:
kind: Cluster
name: cilium-testing
apiVersion: kind.x-k8s.io/v1alpha4
networking:
  disableDefaultCNI: true
  ipFamily: dual
  podSubnet: "<IP_ADDRESS>/16,c::/63"
  serviceSubnet: "<IP_ADDRESS>/16,d::/108"
  apiServerAddress: "<IP_ADDRESS>"
  apiServerPort: 6443
nodes:
- role: control-plane

Also updated the migration services to just spawn 1 of each client and server for simplicity.
apiVersion: apps/v1
kind: ReplicaSet
metadata:
  name: migrate-svc-client
spec:
  replicas: 1
  selector:
    matchLabels:
      app: migrate-svc-client
  template:
    metadata:
      labels:
        app: migrate-svc-client
        zgroup: migrate-svc
    spec:
      containers:
      - name: server
        image: docker.io/cilium/migrate-svc-test:v0.0.2
        imagePullPolicy: IfNotPresent
        command: [ "/client", "migrate-svc.default.svc.cluster.local.:8000" ]
---
apiVersion: v1
kind: Service
metadata:
  name: migrate-svc
spec:
  ports:
  - port: 8000
  selector:
    app: migrate-svc-server
---
apiVersion: apps/v1
kind: ReplicaSet
metadata:
  name: migrate-svc-server
spec:
  replicas: 1
  selector:
    matchLabels:
      app: migrate-svc-server
  template:
    metadata:
      labels:
        app: migrate-svc-server
        zgroup: migrate-svc
    spec:
      containers:
      - name: server
        image: docker.io/cilium/migrate-svc-test:v0.0.2
        imagePullPolicy: IfNotPresent
        command: [ "/server", "8000" ]

The issue is highly reproducible, however its a bit of a pain to debug since it requires restarting the agent and catching monitor logs.
Here is what I'm seeing.
flowchart TD

subgraph "Client Pod"
	c("userpace-client")
	c_veth1("veth1@1")

	c -->| Src: PodIP, Dst: ServiceIP | c_veth1
end

subgraph "Host NetNS"
	direction LR
	c_veth1 --> c_veth2("veth1@2\n service xlate: ServiceIP => BackendIP")
	c_veth2 -->| BPF Redirect\n Src: PodIP, Dst: BE-IP | be_veth2("veth2@2")
	be_veth2("veth2@2")

	c_veth2 -..->| service xlate failure| hns("host network stack")
	hns -..-> | Src: PodIP, Dst: ServiceIP, RST | c_veth2
end

subgraph "Backend Pod"
	direction LR
	be_veth2 --> be_veth1("veth2@1")
	be_veth1 --> be("userpace-backend")
end

Dotted lines show the error case, solid lines show the normal case.
On agent restart, existing flows from Client Pod -> service translation -> Backend Pod are dropping to stack.
When they hit stack, no service translation has occured, and the host network stack doesn't know why you're sending it a 'ACK' or 'ACK/PUSH', and responds with a RST.
The RST goes back to the Client Pod and it rips down the Client. The server reads from the client's socket and is forced to close with probably an EOF.
This situation can be confirmed with IPTables.
On v1.12.5, where the issue is not present, create a rule like so (<IP_ADDRESS> == ServiceIP)
iptables -t raw -A PREROUTING -p tcp -d <IP_ADDRESS> --dport 8000 -j TRACE
Restart the Cilium agent and check for any hits:
iptables -t raw -L PREROUTING -v
Chain PREROUTING (policy ACCEPT 0 packets, 0 bytes)
 pkts bytes target     prot opt in     out     source               destination
  644  541K CILIUM_PRE_raw  all  --  any    any     anywhere             anywhere             /* cilium-feeder: CILIUM_PRE_raw */
    0     0 TRACE      tcp  --  any    any     anywhere             <IP_ADDRESS>         tcp dpt:8000

There aren't any, since no packets were spilt to the host stack during during restart.
Now, checkout HEAD, where the issue is present, and do the same.
(Sanity check, no hits before agent restart)
root@cilium-testing-control-plane:/home/cilium# iptables -t raw -L PREROUTING -v
Chain PREROUTING (policy ACCEPT 0 packets, 0 bytes)
 pkts bytes target     prot opt in     out     source               destination
12795 9527K CILIUM_PRE_raw  all  --  any    any     anywhere             anywhere             /* cilium-feeder: CILIUM_PRE_raw */
    0     0 TRACE      tcp  --  any    any     anywhere             <IP_ADDRESS>           tcp dpt:8000

(Hits after agent restart)
root@cilium-testing-control-plane:/home/cilium# iptables -t raw -L PREROUTING -v
Chain PREROUTING (policy ACCEPT 0 packets, 0 bytes)
 pkts bytes target     prot opt in     out     source               destination
 2715 1019K CILIUM_PRE_raw  all  --  any    any     anywhere             anywhere             /* cilium-feeder: CILIUM_PRE_raw */
   11  1860 TRACE      tcp  --  any    any     anywhere             <IP_ADDRESS>           tcp dpt:8000
root@cilium-testing-control-plane:/home/cilium#

(One more sanity check that rule is not hit once normal operation is back)
🖳  kubectl get pods
NAME                       READY   STATUS    RESTARTS        AGE
migrate-svc-client-jcfqs   1/1     Running   2 (3m55s ago)   6m26s
migrate-svc-server-xcvdd   1/1     Running   1 (3m43s ago)   6m26s

---
root@cilium-testing-control-plane:/home/cilium# iptables -t raw -L PREROUTING -v
Chain PREROUTING (policy ACCEPT 0 packets, 0 bytes)
 pkts bytes target     prot opt in     out     source               destination
28644 5337K CILIUM_PRE_raw  all  --  any    any     anywhere             anywhere             /* cilium-feeder: CILIUM_PRE_raw */
   11  1860 TRACE      tcp  --  any    any     anywhere             <IP_ADDRESS>           tcp dpt:8000

Wireshark also supports this theory, as we see a RST on the Client side, but no corresponding RST on the Backend's VETH interface.
This indicates, the RST the client receives is not from the Backend itself (its from the host netns).
It appears at some point we introduced a bug which drops LB flows to the stack during agent restart.

    Assume the filter names can also contain 'cilium'.

    Signed-off-by: Timo Beckers<EMAIL_ADDRESS>
 bpf/init.sh           | 10 ++++------
 cilium/cmd/cleanup.go |  5 ++++-
 2 files changed, 8 insertions(+), 7 deletions(-)

And indeed, checking out the commit just prior to this stops the RST's on agent restart in my test cluster.

Thanks @ldelossa, fix proposed in https://github.com/cilium/cilium/pull/24336.


Github sidebar link outdated

What is the type of issue?
Documentation is confusing
What is the issue?
The sidebar on the github repo points to https://effect-ts.github.io/effect/ , dunno if that's intended, I would've expected to find the link to https://www.effect.website/ there.
Where did you find it?
https://github.com/Effect-TS/effect sidebar 'About' section

Changed to https://www.effect.website, thanks.


Optgroup feature

Hi,
seems that I didn't manage to update pull request #145 .
So here's a new /rebased version of it.
Sorry for the delay.
Cheers

@tolleiv would you please check "allow edits" on the RHS of this PR?

@tolleiv would you please check "allow edits" on the RHS of this PR?


Eval local HF models with flag

Addresses  #1486

yikes! Thanks for the review, though I'll be more careful to check what I'm staging next time

I notice that in huggingfaceserver, all the models are loaded in "cuda:0". Since we will run the model locally (maybe with --num-threads > 1), maybe it's better to load the mode into different gpus?

Is --enable-local-huggingface-models still available in the latest version of Helm?


NEED HDFS file system and HIVE datasource configuration

*For better global communication, please give priority to using English description, thx! *
Describe the question
A clear and concise description of what the question is.
I want to configure HDFS file system and HIVE datasource in the DS cluster,  would you please someone provide detailed configuration and explain that ? thx so much!
Which version of DolphinScheduler:
-[1.2.0]
Additional context
Add any other context about the problem here.
**Requirement or improvement

Please describe about your requirements or improvement suggestions.

You can find the detailed configuration in the documentation
https://dolphinscheduler.apache.org/zh-cn/docs/1.2.0/user_doc/cluster-deployment.html


Update Regression CI

Since maintaining a baseline is not possible (see #543 for context), I have modified the regression CI to run baselines on main and tests on the PR branch in one go. The trigger for this is now a comment with "/test_regression".
Reuses a lot of code from before. Works for the moment. Long term we could look at using asv instead. (see #543)

@michaeldeistler could you approve this? This should make the CI pass again.


Previous post and next post buttons

Please add previous post and next post button support, it would be really awesome since a lot of Ghost themes use it.

This would be awesome, or at least documentation that describes how to modify/add helpers?

The feature isn't implemented yet. I'll see if I can add it in my free time and submit a PR. :+1:

=)

It's done already. https://github.com/tomkwok/journey/commit/45f78a47719074bd81c8f488ea07c0bab47c9bcc
Pull request #74


Evaluating JPointer can report incorrect start line

This showed up in a functional test of the SARIF log file validator in the SARIF SDK. The SARIF test file
src/Test.FunctionalTests.Sarif/TestData/Multitool/ValidateCommand/Inputs/SARIF2017.LocationsMustHaveRequiredProperties_Invalid.sarif
contains an intentional validation error at /runs/0/results/2/locations/2/physicalLocation/artifactLocation, which is at Line 57 Column 37.
The SARIF output file produced by the validator is
src/Test.FunctionalTests.Sarif/TestData/Multitool/ValidateCommand/ExpectedOutputs/SARIF2017.LocationsMustHaveRequiredProperties_Invalid.sarif
On Line 155, it correctly reports the validation error at /runs/0/results/2/locations/2/physicalLocation/artifactLocation. However on Line 166, it reports that location as Line 54, Column 37: three lines too early. This seems to be related to the fact that there is a 3-line-long JSON object named "properties" directly above the "artifactLocation". We get the correct answer if we put the "artifactLocation" above the "properties".
The validator uses JsonPointer.Evaluate to resolve the path /runs/0/results/2/locations/2/physicalLocation/artifactLocation to a JToken, and then extracts the line/column locations from the token. Debugging this in the validator shows that the text of the JToken is correct (here, { "index": 0 }), but the line number is wrong.
I haven't been able to repro this in the JsonPointer unit tests (EvaluatorTests.cs).

Another example: In the same test input file, if you move the run.artifacts property down below run.results, the line numbers for the reported violations should all decrease by 7 lines (because that's how many lines) run.artifacts occupies in that test file. So for example, the first violation should be reported on line 13 rather than on line 20. But the reported line numbers do not change.

There's no JPointer bug.It turns out that the SARIF validator performs a transformation which has the unintended side effect of reordering the properties in the input file before the analysis is performed.
@michaelcfanning FYI


Jenkins build collector issue

Hi,
I have installed hygieia on a separate machine than jenkins. On the properties file for the jenkins build collector, I am having issues connecting to my Jenkins from the hygieia machine. provided the api keys from Credentials->configure->API keys. But still not connecting to Jenkins.
Can anyone assist?
Jenkins server (required) - Can provide multiple
jenkins.servers[0]=http://<IP_ADDRESS>3:1234/jenkins/
or
jenkins.servers[0]=http://my-jenkins.url:1234/jenkins/
If using username/token for api authentication
(required for Cloudbees Jenkins Ops Center) see sample
<EMAIL_ADDRESS>Another option: If using same username/password Jenkins auth,
set username/apiKey to use HTTP Basic Auth (blank=no auth)
jenkins.username=ab1234
jenkins.apiKey=myapikey
Thanks
Sam G

Can you paste the stack trace? Thanks.

Solved this by opting to use hygieia-jenkins-plugin. Thanks!!

Hi,
I am having issue with Jenkins and hygieia connectivity, I am using cludbees Jenkins and trying to connect with username and API<EMAIL_ADDRESS>but getting error
ValidatorException: PKIX path building failed: sun.security.provider.cer
tpath.SunCertPathBuilderException: unable to find valid certification path to re
quested target


👮

testing the codeowner changes
How does this pull request make you feel (in animated GIF format)?
![alt text](giphy link)
What are the relevant GitHub issues?
resolves [link to github issue]
What does this pull request do?
??
How should this be manually tested?
??
Is there any background context you want to provide for reviewers?
??
Questions for the pull request author (delete any that don't apply):

[ ] Are any needed README/wiki/documentation updates needed for this pull request?
[ ] Does the code you updated have tests? If not, could you add some please?
[ ] Does this pull request require any new server dependencies which need to be added to the build process? If so, please explain what.

Acceptance Criteria
These should be checked by the reviewers

[ ] This pull request does not cause the database export script to become out of sync with the db schema

this was just a test to make sure #1416 was set up correctly


Idea: Empty block for scaffolding

So that you can easily write out blocks to be filled in later. Or maybe it is just wirings with 0 elements


Suggested modifications for age-selectivity type 11

when working with age-specific selectivity of 1.0 for a range of ages.
Sorry if I made this pull request to the wrong base branch, i.e., it should not go into main. Feel free to suggest a different branch and I can rebase and submit a different/modified pull request.
The change in wording will be helpful to users that are new to selectivity type = 11. Even though I have used the type before I had to go to the Report.sso to make sure that it was doing what I thought it was. I was not sure if the parameters corresponded to the bins for ages or to the actual age numbers themselves. I also included an example in the suggested text.

Clarification: I edited the second suggestion to read "from...to..." instead of "to...to...".

Also:  selectivity operates on real ages, not data age bins.

@iantaylor-NOAA thank you for the helpful suggestions. If you have time, can you go ahead and just make the needed changes directly to this branch?

I just attempted to implement my suggested changes--slightly differently than what I originally thought.
@Rick-Methot-NOAA, I added you as a review hoping you can look at this one more time.

Thanks @iantaylor-NOAA, there is one typo though The these .

Just fixed that Kelli!

@Rick-Methot-NOAA,
Looking at the mirror_mask and mirror_mask_a vectors at
https://github.com/nmfs-ost/ss3-source-code/blob/main/SS_readcontrol_330.tpl#L4241
and
https://github.com/nmfs-ost/ss3-source-code/blob/main/SS_readcontrol_330.tpl#L4319
I see that the 1e-10 constant seems to only be added to the length-based formulation, not the age-based version. If you recall some good reason for that difference, we could document it for posterity. If it's just happenstance, I don't see a need to spend more time on this.

No good reason for the difference.  Just happenstance by not doing both at same time and not having today's coding tools at the time.

Thank you everyone for your help on this pull request. @e-perl-NOAA I will leave it to you to merge it in to whatever branch you want when you think the time is appropriate.


Changed the statistical type so it doesn't return an array

Warnings

:warning:

The README has not been updated. Please update the README.

Messages

:book:

Awesome! Thanks for the well-formatted PR!

  Generated by :no_entry_sign: dangerJS


Website: VL logo regression

Looks like the VirtusLab logo is missing ;)

@kubukoz,
Thanks for reporting, it should be fixed now.


Add LaCrosse sensor platform

Signed-off-by: Heiko Thiery<EMAIL_ADDRESS>Description:
Pull request in home-assistant.github.io with documentation: home-assistant/home-assistant.github.io#3829
Example entry for configuration.yaml (if applicable):

sensor:
  - platform: lacrosse
    sensors:
      wohnzimmer_temperature:
        friendly_name: Wohnzimmer Temperatur
        type: temperature
        id: 60
      wohnzimmer_humidity:
        friendly_name: Wohnzimmer Luftfeuchtigkeit
        type: humidity
        id: 60
      wohnzimmer_battery:
        friendly_name: Wohnzimmer Sensor Batterie
        type: battery
        id: 60

Checklist:
If user exposed functionality or configuration variables are added/changed:

[x] Documentation added/updated in home-assistant.github.io

If the code communicates with devices, web services, or third-party tools:

[ ] Local tests with tox run successfully. Your PR cannot be merged unless tests pass
[x] New dependencies have been added to the REQUIREMENTS variable (example).
[x] New dependencies are only imported inside functions that use them (example).
[x] New dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
[x] New files were added to .coveragerc.

If the code does not interact with devices:

[ ] Local tests with tox run successfully. Your PR cannot be merged unless tests pass
[ ] Tests have been added to verify that the new code works.

Hi @hthiery,
It seems you haven't yet signed a CLA. Please do so here.
Once you do that we will be able to review and accept this pull request.
Thanks!

Hi @hthiery,
It seems you haven't yet signed a CLA. Please do so here.
Once you do that we will be able to review and accept this pull request.
Thanks!

Currently I cannot figure out why build fails. Has anyone an idea?

Do I need to add tests for the PR?

You could if you want. It's not a requirement as you depend on a module and often the module itself contains already tests.

Ok that means I can remove the checkbox for tests from the checklist?

Oh, you were talking about the local tox tests. We run tox on the Pull requests automatically. If a local tests fails the chances are high that it will fails here too.


Installation of package ‘CVXR’ had non-zero exit status

Hi, I tried to use install.packages('CVXR')  to install the CVXR package on linux-gnu, but I was failed. The showed errors are as follows. The r verion I used is 3.4.1 (2017-06-30).

compilation aborted for RcppCVXcanon.cpp (code 2) make: *** [RcppCVXcanon.o] Error 2
ERROR: compilation failed for package ‘CVXR’
removing ‘/scratch/work/XXXX/R/3.4.1/CVXR’
The downloaded source packages are in
‘/tmp/Rtmpbl4UzJ/downloaded_packages’
Warning message:
In install.packages("CVXR", repos = "https://CRAN.R-project.org") :
installation of package ‘CVXR’ had non-zero exit status

So, Could you give me some help or suggestions? Thanks in advance.

Without the full details of what the error is, it is hard to provide help. But I would suggest that you upgrade your R version which is almost 2 years old. Then, also make sure you have the compiler tool chain. On Debian linux platforms,
apt-get install r-base-dev

will ensure that.

Thank you so much. After upgrading the R version, I successfully installed the CVXR package. Now, it works well.


small synthon search optimization

It doesn't seem like generating SMILES is necessary

Closing this because the change will come in the FP synthon search PR


add pyupgradeand small refactor

Codecov Report

Merging #118 (638e580) into master (2fcfbd0) will increase coverage by 0.19%.
The diff coverage is 87.30%.

@@            Coverage Diff             @@
##           master     #118      +/-   ##
==========================================
+ Coverage   85.85%   86.05%   +0.19%
==========================================
  Files          77       76       -1
  Lines        5233     5171      -62
==========================================
- Hits         4493     4450      -43
+ Misses        740      721      -19

Flag
Coverage Δ

unittests
86.05% <87.30%> (+0.19%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

base/views/outline_initial_views.py
68.81% <ø> (ø)

base/models/target_vertex.py
90.69% <60.00%> (-4.04%)
:arrow_down:

base/forms.py
67.99% <77.77%> (ø)

utils/outline_finish.py
95.71% <89.74%> (-2.54%)
:arrow_down:

utils/basic/info_generatation.py
73.68% <100.00%> (ø)

utils/basic/mode.py
87.87% <100.00%> (ø)

utils/basic/target_line.py
80.95% <100.00%> (ø)

utils/get_deff.py
93.22% <100.00%> (ø)

utils/outline_complete.py
95.48% <100.00%> (-0.06%)
:arrow_down:

utils/basic/village.py
59.55% <0.00%> (-5.62%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2fcfbd0...638e580. Read the comment docs.


Refactor Absinthe.Relay.Node.ParseIDs to be more flexible

This is a pretty thorough refactoring of the Absinthe.Relay.Node.ParseIDs middleware to better support complex forms like lists of node IDs and nested list IDs.
An example of a simple node ID to parse:
field :foo, :foo do
  arg :id, :id
  middleware Absinthe.Relay.Node.ParseIDs, id: :foo
  resolve &resolve_foo/2
end

An example of a list of node IDs to parse:
field :foos, list_of(:foo) do
  arg :foo_ids, list_of(:id)
  middleware Absinthe.Relay.Node.ParseIDs, foo_ids: :foo
  resolve &resolve_foos/2
end

An example of a nested structure with node IDs to parse:
mutation do
  payload field :update_parent do

    input do
      field :parent, :parent_input
    end

    output do
      field :parent, :parent
    end

    middleware Absinthe.Relay.Node.ParseIDs, [
      parent: [
        id: :parent,
        children: [id: :child],
        child: [id: :child]
      ]
    ]

    resolve &resolve_parent/2
  end
end

(Note the children: [id: :child] above is even a description of a list of node IDs inside a nested structure.)
Progress

[x] Parses one valid ID successfully
[x] Parses one invalid ID successfully; reports correct error
[x] Parses a list of valid IDs successfully
[x] Parses a list of invalid IDs successfully; reports correct error (any invalid -> arg/field invalid)
[ ] Parses a nested structure of valid IDs successfully
[ ] Parses a nested structure of invalid IDs successfully; reports correct error (any invalid -> arg/field invalid)

Complex forms:

[ ] Parses a list of nested structures of valid IDs successfully
[ ] Parses a list of nested structures of invalid IDs successfully; reports correct error (any invalid -> arg/field invalid)
[ ] Parses a nested structure with a list of valid IDs successfully
[ ] Parses a nested structure with a list of invalid IDs successfully; reports correct error (any invalid -> arg/field invalid)

Just one test left (list inside nested) to shake out the main functionality, then it's code coverage (especially for edge cases) and cleanup.

Tests all passing; plan on merging this in soon after adding a few more -- if someone wants to give it a real world shake-down, I'd appreciate it.


nixos/man-db: allow man-cache to be fetched from cache

Description of changes
Currently, we build man-cache with runCommandLocal, which causes it
to get re-built locally instead of fetched from cache. While the
resulting derivation might be small, it does take a fair bit of time to
build for all my systems, and would be far quicker to fetch.
With this change, we use runCommand instead of runCommandLocal,
allowing it to get fetched from cache instead of rebuilt for all hosts.
Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
22.11 Release Notes (or backporting 22.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[ ] Fits CONTRIBUTING.md.

I think I have the opposite problem: I'm rebuilding man-db frequently since I have various package overrides and this change causes Nix to copy over a bunch of stuff to my 3 remote builders when it could just run the command locally - where the packages already are.
@lovesegfault Since you originally saw long rebuilds, could you test with this patch to prefer local builds without excluding substitutions? I'm using it right now and it seems to work, so if it works for you I can make an official PR.
diff --git a/nixos/modules/misc/man-db.nix b/nixos/modules/misc/man-db.nix
index d557b5e20b0f..9d5882039992 100644
--- a/nixos/modules/misc/man-db.nix
+++ b/nixos/modules/misc/man-db.nix
@@ -64,6 +64,7 @@ in
       let
         manualCache = pkgs.runCommand "man-cache" {
           nativeBuildInputs = [ cfg.package ];
+          preferLocalBuild = true;
         } ''
           echo "MANDB_MAP ${cfg.manualPages}/share/man $out" > man.conf
           mandb -C man.conf -psc >/dev/null 2>&1


Clickable links to WebIDL types like DOMString?

Is there some mode of using Bikeshed that would generate these links? I would've expected it to be in the default bibliography. This came up as a question in reviewing the WebAssembly/JS interface specification.

It appears they are generated, but only in some contexts. E.g. they are linked in https://littledan.github.io/spec/document/JS.html#dictdef-moduleimportdescriptor but not in https://littledan.github.io/spec/document/JS.html#typedefdef-instanceexportsmap .
It may be in fact that only record<>s are missing the links. In any case, a good Bikeshed bug find.

Looks like this is a widlparser bug; specifically, the first type in a record<> isn't being parsed as the correct sort of thing, so it doesn't get passed to the right function to mark it up as an autolink.  I've reported this (linked above), will fix as soon as widlparser updates.

Fixed, thanks.


Server returns 404 or 401 - no reaction at all

Hi,
using this snippet:
           Future<HttpResponse<JsonNode>> futureHttpResponse = Unirest.post(url)
                    .header("Accept", "application/json")
                    .basicAuth(username, password)
                    .asJsonAsync(new Callback<JsonNode>() {
                        @Override
                        public void completed(HttpResponse<JsonNode> httpResponse) {
                           ...
                        }

                        @Override
                        public void failed(UnirestException e) {
                          ...
                         }

                        @Override
                        public void cancelled() {
                           ...

                        }
                    });

There is NO callback on 401 or 404.

Ok, that was easy.
The reason is your attempt to understand the HTML response as JSON
Class JsonNode:
   public JsonNode(String json) {
        if (json != null && !"".equals(json.trim())) {
            try {
                this.jsonObject = new JSONObject(json);
            } catch (JSONException var5) { <--- Exception: A JSONObject text must begin with '{' at 1 [character 2 line 1]
                try {
                    this.jsonArray = new JSONArray(json);
                    this.array = true;
                } catch (JSONException var4) {
                    throw new RuntimeException(var4);    <--- Exception A JSONArray text must start with '[' at 1 [character 2 line 1]
                }
            }
        } else {
            this.jsonObject = new JSONObject();
        }

    }

Well, this is a nice attempt, but real world is ugly some times and returns anything but JSON. Any chance to fix that?

OK, found it.
Future<HttpResponse<String>> futureHttpResponse
and
.asStringAsync(new Callback<String>() {
does it.


[EDQ-427] Python package to create 'Data Quality Issue' dashboard

Package is intended to create unique dashboards that detail all of the current data quality issues for the sites. The main script in this file should ultimately generate Excel files that can easily be distributed to an online project management platform.

@nishanthpp93 Please merge this when you get the chance.
I do notice that there is an overlapping commit with something that was already merged (#462, which GitHub seems to already recognize). This is my bad; I had to use the command line since I was using Pycharm on macOS (rather than the WindowsOS, which I am more familiar with) so it looks like I messed up on this front. Please let me know if this is an issue and I can re-open a new PR.

Hey @noahgengel, yes it looks like an already existing commit is in the PR. A new PR with only the latest commit would resolve this.

@nishanthpp93 anger. I created a new PR that only has one commit. My apologies.


pull request for e2e test at 01/31/2017 13:56:12

:white_check_mark: Validation status: passed
For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Including defaultTokens as dependency for strike_dataGrid

@kevinberonilla

Thanks @ryansieve for your PR we've already implemented this and will reflect in our next release!


Change the way of being unbreakable(durability infinite)

Now,if the rpgitems which are unbreakable are damaged,the plugin will fix the item.
But do you think if the rpgitem are damaged too much to fix(breaked, been disappeared) the plugin could not fix it!
So, You can add a NBT(Unbreakable) to the item to protect them form being breaken).
That's will be better!

Please use /rpgitem {itemName} power unbreakable instead of /rpgitem {itemName} power unbreaking if you want the NBT version of unbreaking ability.
See #88


Memory overflows in cli mode

Memory overflows in cli mode

You've made a pull request against wrong repository. Please do it against yiisoft/yii2. Thanks.


fix: default generated tests missed import for RouteGuards and a typo

Thanks a lot @DominikPieper! I'll soon activate running the unit tests too by default on the generated projects, so this comes in super handy!

Thanks a lot @DominikPieper! I'll soon activate running the unit tests too by default on the generated projects, so this comes in super handy!

@beeman I'll take a look on some of the other tests later. On the login/logout/register tests there's a missing input I'd say. They can't resolve Auth-page (I think that was the one)

@beeman I'll take a look on some of the other tests later. On the login/logout/register tests there's a missing input I'd say. They can't resolve Auth-page (I think that was the one)

That would be definitely appreciated to have some more tests being generated!
The web-auth-feature tests should now run correctly after this commit https://github.com/nxpm/stack/commit/6c3bed3242dc4be6adf8e377017b9a4a41e4053a and a few other tweaks landed

That would be definitely appreciated to have some more tests being generated!
The web-auth-feature tests should now run correctly after this commit https://github.com/nxpm/stack/commit/6c3bed3242dc4be6adf8e377017b9a4a41e4053a and a few other tweaks landed


moveItemInArray event returning wrong current index

Bug, feature request, or proposal:
In drop div, I have too many long text button in the 2-3 line. If I want to move long text button from 2nd line to 1st line. I am getting the wrong index.

In the above snapshot, in 2nd line 2nd element want to move in the first line in 3rd position but getting index 4.
Please suggest me how to overcome this problem
What is the expected behavior?
What is the current behavior?
What are the steps to reproduce?
Providing a StackBlitz reproduction is the best way to share your issue.
StackBlitz starter: https://goo.gl/wwnhMV
What is the use-case or motivation for changing an existing behavior?
Which versions of Angular, Material, OS, TypeScript, browsers are affected?
Is there anything else we should know?

@ankitg1602
Can you please share a StackBlitz sample.

Needs more information before we can investigate.

Closing because this issue has been inactive for 2 weeks or more after follow up was requested.


Replace Loading string during loading with TimetableItemDetailScreen

Idea Description
Please replace the 'Loading' text on the TimetableItemDetailScreen with something else that indicates it is loading, such as a progress bar.
Reference images and links

I would like to challenge this issue!

@matsumo0922
Thank you for your challenge! Assigned!


Fix translation problems that difficult reading

[x] I have read freeCodeCamp's contribution guidelines.
[x] My pull request has a descriptive title (not a vague title like Update index.md)
[x] My pull request targets the master branch of freeCodeCamp.
[x] None of my changes are plagiarized from another source without proper attribution.
[x] My article does not contain shortened URLs or affiliate links.

If your pull request closes a GitHub issue, replace the XXXXX below with the issue number.
Closes #XXXXX

Congrats @otavioarc on your first pull request (PR)! 🎉
Thank you for your contribution to the page! 👍
We're happy to accept these changes, and look forward to future contributions. 📝


NuGetPublisher URI checking and creating new NuGet.config everytime

Hi @Alduhoo, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!

In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes. I promise there's no faxing. https://cla.microsoft.com.

TTYL, MSBOT;

@Alduhoo, Thanks for signing the contribution license agreement so quickly! Actual humans will now validate the agreement and then evaluate the PR.
Thanks, MSBOT;


Enhancement Re-add deduplication to auto partition rpc

Proposed changes
Issue Number: close #xxx
removed in https://github.com/apache/doris/pull/27817. we need it so re add it.

run buildall

testing in internal regression environment

run buildall

run buildall

skip buildall


added 3rd standard option for Emacs undo: 'ctrl-x u'

This is one of the standard options for undo, as shown in the manual: https://www.gnu.org/software/emacs/manual/html_node/emacs/Undo.html

Thanks @JRMeyer!
I've merged your suggestions for ctrl-x u and ctrl-x ctrl-c. The ones for git-plus and advanced-open-file I'll leave out, since these are 3rd party packages, and ctrl-x ctrl-o in emacs seems to be bound to delete-blank-lines by default rather than something resembling application:add-project-folder.


Import d2fb3befb1: Allow using regular installation of qt on Linux (by Maki)

This is an automated proposal to look at a commit made by Maki and import it into Overte

Commit:
d2fb3befb113f69480c133d6fcf6b725014a787f

Author:
Maki

Date:
Wed, 11 Mar 2020 21:33

Allow using regular installation of qt on Linux

Stats:

Filename
Stats
Lines
Added
Removed
Lines in blame

hifi_qt.py

30
17
13
⚠ 0

1 files
-
30
17
13
0

To work on this, please assign the issue to yourself, then look at the commit and decide whether this would be a good addition to Overte.

If the commit is useful, tag it with "Tivoli: Keep", and keep it open until it's merged.
If the commit is not useful, tag it with "Tivoli: Discard", and close it.
If the commit is not useful right now, but might be later, tag it with "Tivoli: Maybe later", and close it.
If it's hard to decide, tag it with "Tivoli: Discuss", and keep it open.

Useful commits should be submitted as a PR against Overte. Tag this issue in PR, so that it's automatically closed once the PR is merged.
You can cherry-pick this issue with this command:
git cherry-pick d2fb3befb113f69480c133d6fcf6b725014a787f

not in blame, we don't need this


:infinite-scroll="false"

not all emojis are visible

Similarly to #155 I need a step-by-step sequence of actions to get to the issue. Good to also make sure it is reproduced in the demo app or provide a minimal code example.


maxPerPage parameters required when calling from Java

Bug Information
From Kotlin I can do:
AzureData.getDatabases { response ->
   ...
}

...since the maxPerpage param will default to null
Now, from Java, I am required to pass null for maxPerPage or there is a compilation error:
AzureData.getDatabases(null, onCallback(response -> {
   ...
}

Steps to Reproduce
Look in the example Java module for examples.
Expected Behavior
I shouldn't have to pass null if I don't want to pass maxPerPage
Actual Behavior
I need to pass null or it won't compile.

Believe this can be mitigated with @JvmOverloads annotation on methods with default params.  PR to come.


Issue with one vhost overwriting the second vhost

Hello, I am not sure if this is a bug or a configuration issue. I'm trying to use vhosts, but the HLS segment and manifest files are written only for 1 vhost (domain1.com) to the hls_path.
If I define 2 vhosts in RTMP configuration, domain1.com and domain2.com, then only the first (domain1.com) works: the HLS files are written into hls_path. The second vhost (domain2.com), the hls_path is different from the first (see my config below), but the files are not created for domain2.com and /var/live/domain2.com/hls remains empty.
When publishing to the second vhost (domain2.com), in the access_log I see nothing, but when I stop publishing, I only see a PUBLISH "live" event. And strangely enough, I see a PLAY "live" event in the first vhost (domain1.com) when I stop publishing to domain2.com!
Also if I change the names of the applications for domain2.com, for example from "live" -> "live2", "hls" -> "hls2", it still doesn't work.
If I switch the vhosts, and define domain2.com first, and then domain1.com, then domain2.com works and domain1.com does not!
Is there a conflict in my RTMP configuration?  I have changed localhost to specific FQDN names:
rtmp://localhost//... -> rtmp://server.domain1.com/...


TF32 Support

Hi, I noticed that the following line disables TF32 support. I wonder what is the motivation for doing so?
https://github.com/PanQiWei/AutoGPTQ/blob/main/auto_gptq/quantization/gptq.py#L15
I'm asking this question as these lines disabled TF32 globally when auto_gptq is imported (explicitly, or implicitly through other modules). As a particular example, HuggingFace sometimes imported auto_gptq when certain functions are called (during runtime). As a consequence, this means the aforementioned lines would turn off TF32 in such case.

They are in the original reference implementation: https://github.com/IST-DASLab/gptq/blob/main/gptq.py#L13
So the lower precision would probably hurt the quality of quantization. But they should be contained within the GPTQ class or AutoGPTQ itself.
Maybe inside a del to set them back to True?

I'm not sure why it would hurt quantization, since the W4A16 kernel is homemade anyway it most likely does not use TF32.

I think TF32 is automatically used for certain operations if enabled. I doubt they disabled them just for fun. Matmul is disabled by default in pytorch.


Great module - Minor Suggestions

Feature Request - CV Control
Feature Request - Dim up/down control with middle mouse scroll wheel (windows)
UI Request - Rename "Dim" to "Brightness" or similar so Up is brighter and Down is Dimmer.  Right now it's the opposite and a bit awkward.

@stoermelder Do you want to consider / respond to these suggestions.
I think direct CV control is unlikely, but it could be made compatible with SAIL.

Feature Request - CV Control
Feature Request - Dim up/down control with middle mouse scroll wheel (windows)
UI Request - Rename "Dim" to "Brightness" or similar so Up is brighter and Down is Dimmer. Right now it's the opposite and a bit awkward.

Thank you for your feature requests, I will talk to Omri how he thinks about them.
About the label „Dim“: I think about the other way around, on 100% the module dims the light by 100% to full dark, on 0% the module dims the light by 0% with no effect at all.

Available in version 1.1.1


Remove unused code from the fips module

Now that we have checksums, it is a bit easier to spot source files that should not be in the fips module.
NOTE that the MD5 ASM sources are still in the checksum file for some reason.
This is a follow-on from PR #15164

Checklist

[ ] documentation is added or updated
[ ] tests are added or updated

NOTE that the MD5 ASM sources are still in the checksum file for some reason.

diff --git a/Configurations/unix-Makefile.tmpl b/Configurations/unix-Makefile.tmpl
index d98c42c85e..c2a0de3a97 100644
--- a/Configurations/unix-Makefile.tmpl
+++ b/Configurations/unix-Makefile.tmpl
@@ -1167,7 +1167,6 @@ $(SRCDIR)/providers/fips.module.sources: \
          for x in crypto/bn/asm/*.pl crypto/bn/asm/*.S \
                   crypto/aes/asm/*.pl crypto/aes/asm/*.S \
                   crypto/ec/asm/*.pl \
-                  crypto/md5/asm/*.pl \
                   crypto/modes/asm/*.pl \
                   crypto/sha/asm/*.pl; do \
            echo "$$x"; \

CIs won't run with the conflict :(

Needs #15171 to merged anyway.. So may as well wait till then.

#15171 is merged now


allow before functions to store/retrieve data over multiple rules in workflows

In Rule 1 (Workflow):
context.storage.set("key", "value");

In Rule 2 (Workflow):
context.storage.get("key") // = "value";

This would allow workflows to transport important infos to later steps

workflows should auto clean the storage before start

works in 2.2.0


🐋 Dockerimage for artifact creation

Creating an application artifact requires a working shell environment with every tool installed. There should be a Dockerfile that allows building the artifact without all tools being installed.
It should include:

go
make
creating a non-root user with specific id (1000)

Running the image should

compile an artifact at a specific location so directories can be mounted; the image should be deletable outside of the container (file ownership)
allow to set the target os and architecture from environment variables
allow to set the artifact's version and commit hash

docker build -t git-nest-build -f _docker/Build.Dockerfile .

docker run \
   --user 1000:1000
   -e GOOS=<target os> \
   -e GOARCH=<target architecture> \
   -e GIT_NEST_BUILD_VERSION=<git-nest version> \
   -e GIT_NEST_BUILD_COMMIT_SHA = <git-nest commit hash> \
   -v ./:/git-nest/src:ro \
   -v ./build:/git-nest/build \
   git-nest-build

There is a new Dockerfile and build script that builds supported binaries. It also calculates the checksum. Documentation in the README is still missing, as that image does not yet allow setting a custom os and architecture.

And then each 'os/arch' combination is seperated using a whitespace, keeping it nice and simple for external automation.
E.g.:
-e TARGET_OVERRIDE="js/wasm openbsd/amd64 android/arm64"

would override the internal array and build the defined target and calculate their checksums.


Can't add some feeds

I'm not sure if this is related to my setup, or if others have experienced it.
Sometimes, when I try to add a feed, I get a feed_not_found_error, and after a few tries it goes through. I'm using stringer on a free instance of RedHat Cloud.
For example, I haven't been able to add this feed: https://copperhead.co/feed.xml
Tell me if there is any info I can provide. I'm not sure how to debug that.

To me this sounds like temporary issues with connectivity, so I'm not sure what we can do on our part. Does this affect fetching of any other feeds?

All my other feeds were refreshing properly. I tried the feed mentionned in my first comment for about a week without luck, so I posted the issue in case it was a problem bigger than connectivity.

Hey @guiniol, thank you for reporting this issue. I'm going to close this now due to inactivity. Feel free to re-open if you have any updates on this.

Alright. I haven't updated in a while, so I'll try and check how it goes.

ticket should be re-openend, because this error still exists. Not only on the RSS in the first post, here: http://www.drwindows.de/external.php?do=rss&type=newcontent&sectionid=1&days=120&count=10, too :/ Stringer could not fetch the feed.

Definitely. I checked and forgot to come back and say that it still doesn't work.

None of these feeds pass the W3C Feed Validation Service at the time of this writing.
https://copperhead.co/feed.xml

Server returned [Errno 1] _ssl.c:504: error:14077438:SSL routines:SSL23_GET_SERVER_HELLO:tlsv1 alert internal error [help]

http://www.drwindows.de/external.php?do=rss&type=newcontent&sectionid=1&days=120&count=10

description contains bad characters
description should not contain attachment140530" attribute
etc.

yeah i tried it myself with the W3C Feed Validator and the rist one is not valid, but the second one ist valid. W3C says it is a valid Feed. The Messages are only Recommendations like not using attachment attribute, etc.

The error with the www.drwindows.de feed appears to be related to Feedjira and the options we pass to it.
$ racksh
Rack::Shell v1.0.0 started in development environment.
[1] stringer-development(main)> url = "http://www.drwindows.de/external.php?do=rss&type=newcontent&sectionid=1&days=120&count=10"
=> "http://www.drwindows.de/external.php?do=rss&type=newcontent&sectionid=1&days=120&count=10"
[2] stringer-development(main)> options = {user_agent: "Stringer (https://github.com/swanson/stringer)", if_modified_since: Time.now, timeout: 30, max_redirects: 2, compress: true}
=> {:user_agent=>"Stringer (https://github.com/swanson/stringer)",
 :if_modified_since=>2016-01-30 13:15:07 +0100,
 :timeout=>30,
 :max_redirects=>2,
 :compress=>true}
[3] stringer-development(main)> Feedjira::Feed.fetch_and_parse(url, options)
/home/koronen/.rbenv/versions/2.0.0-p247/lib/ruby/gems/2.0.0/gems/feedjira-1.3.0/lib/feedjira/feed.rb:237: warning: uncaught exception from callback
=> 200
[4] stringer-development(main)> Feedjira::Feed.fetch_and_parse(url)
=> #<Feedjira::Parser::RSS:0x007f73959667b0 ...>

so i should report it to the developer of Feedjira?

I have found another feed which I cannot add to stringer: https://blog.patternsinthevoid.net/feeds/all.atom.xml
This feed does not pass the w3c validation. If I understood correctly from the previous comments, this should be reported directly to feedjira to see if they want to support such feeds, right?

Hey @guiniol can I close this, or is still a problem?

Seems to work now, so sure, go ahead!


Regarding the issue of static compilation not taking effect

I specified the -- static option when configuring, but the compiled SRS program is still dynamically linked. There is no such problem in version 3.0, but upgrading to version 4.0 will cause this issue, which has been bothering me for a long time. I hope the experts can give me some advice!
=======================================================================================
我在configure时指定了--static选项，但是编译得到的srs程序仍然是dynamically linked，在3.0版本没有这个问题，但是升级4.0版本就会这样，困扰了很长时间，望大佬们赐教！

If you really need to use a static linked executable, here is the solution:
https://github.com/ossrs/srs/blob/3e811ba34a478b675282d4af394c4a33300d5c8e/trunk/configure#L227
change to:
SrsLinkOptions="${SrsLinkOptions} -static";
But I don't think the fully static linked executable is a good idea.
-static-libstdc++ will use static linked libstdc++ to replace the libstdc++.so,
-static-libgcc will remove libgcc_s.so,
With those 2 link options will make your executable portable enough.

@suzp1984 I think it's ok to support statically link libc by change the bellow:
SrsLinkOptions="${SrsLinkOptions} -static-libstdc++ -static";

Please file a PR to fix this?

我关闭了 #4152 这个PR，因为目前对于 -static的副作用还不清楚，尽管静态链接glibc，依然有些函数是动态链接，这可能会造成其他问题。
如果你可以承受这个风险，可以自己改下代码，将 configure 中的 -static-libstdc++ 换成 -static即可。


Use graphql-shield with graphql and express-graphql

Hi everyone,
I'm doing a project that uses graphql but I use graphql with express-graphql. But I want to apply graphql-shield to my project.
Please help me!
Thanks for the support!
import {   GraphQLSchema,   GraphQLObjectType, } from 'graphql';
import { user, users, usersByRole } from './queries/UserQueries';
const queryType = new GraphQLObjectType({   name: 'QueryType',   description: 'The root for all queries available.',   fields: {     users,     user,     usersByRole, } });
// Creating schema
const schema = new GraphQLSchema({   query: queryType, });
export const permission = shield({   Query: queryType, });
export default schema;

Hey @nmquaan 👋 I think this is a duplicate of #53 in a way, tell me if that solved your problem. 😄

Thanks for the support @maticzav
I solved my problem.
I will close this issue.


Add changelog for v1.6.4

What this PR does / why we need it:
Add changelog for v1.6.4
What type of PR is this?
/kind documentation
Does this PR introduce a user-facing change? Then add your Release Note here:
NONE

Documentation:
NONE

/assign @kron4eg @ahmedwaleedmalik

/cherrypick release/v1.6

/lgtm
/approve


remove internal env vars like $TEST, and then add a travis test to prevent new ones

see the comments in #3725
(basically, search for os.GetEnv)

Solution:
get rid of integration tests all together and migrate to integration-cli


How to fix this errors ? sd-webui-blip2

Traceback (most recent call last):
File "C:\SD\venv\lib\site-packages\gradio\routes.py", line 337, in run_predict
output = await app.get_blocks().process_api(
File "C:\SD\venv\lib\site-packages\gradio\blocks.py", line 1015, in process_api
result = await self.call_function(
File "C:\SD\venv\lib\site-packages\gradio\blocks.py", line 833, in call_function
prediction = await anyio.to_thread.run_sync(
File "C:\SD\venv\lib\site-packages\anyio\to_thread.py", line 31, in run_sync
return await get_asynclib().run_sync_in_worker_thread(
File "C:\SD\venv\lib\site-packages\anyio_backends_asyncio.py", line 937, in run_sync_in_worker_thread
return await future
File "C:\SD\venv\lib\site-packages\anyio_backends_asyncio.py", line 867, in run
result = context.run(func, *args)
File "C:\SD\extensions\sd-webui-blip2\scripts\main.py", line 71, in gen_caption
image = vis_processors"eval".unsqueeze(0).to(device)
KeyError: 'eval'

I think you have not chosen the model
Please select model from model list

I think you have not chosen the model Please select model from model list

Same here :(
Model was selected...
Have you test your plugin on windows 10?

Can you put up all the logs?
I din't verify this with windows 10. I will try it now.

Can you put up all the logs? I din't verify this with windows 10. I will try it now.

To create a public link, set share=True in launch().
Loading data...
loading model pretrain_opt6.7b...It takes time.
generating...
Traceback (most recent call last):
File "G:\stable-diffusion\venv\lib\site-packages\gradio\routes.py", line 337, in run_predict
output = await app.get_blocks().process_api(
File "G:\stable-diffusion\venv\lib\site-packages\gradio\blocks.py", line 1015, in process_api
result = await self.call_function(
File "G:\stable-diffusion\venv\lib\site-packages\gradio\blocks.py", line 833, in call_function
prediction = await anyio.to_thread.run_sync(
File "G:\stable-diffusion\venv\lib\site-packages\anyio\to_thread.py", line 31, in run_sync
return await get_asynclib().run_sync_in_worker_thread(
File "G:\stable-diffusion\venv\lib\site-packages\anyio_backends_asyncio.py", line 937, in run_sync_in_worker_thread
return await future
File "G:\stable-diffusion\venv\lib\site-packages\anyio_backends_asyncio.py", line 867, in run
result = context.run(func, *args)
File "G:\stable-diffusion\extensions\sd-webui-blip2\scripts\main.py", line 71, in gen_caption
image = vis_processors"eval".unsqueeze(0).to(device)
KeyError: 'eval'

It looks like the model is still in the process of being loaded.
When the model has finished loading, Finish loading model {modeltype}! is displayed

It looks like the model is still in the process of being loaded. When the model has finished loading, Finish loading model {modeltype}! is displayed

I've waiting for 10 minutes did not get Finish loading model {modeltype}! :(

It looks like the model is still in the process of being loaded. When the model has finished loading, Finish loading model {modeltype}! is displayed
I'd find that blip2_pretrained_opt2.7b.pth is on
G:\stable-diffusion\tmp.cache\torch\hub\checkpoints\blip2_pretrained_opt2.7b.pth but there is no blip2_pretrained_opt6.7b.pth
looks like pretrain_opt6.7b did not loaded full :( could you plz give me direct link for it to redownload it
Thanks.

Afer restart 1111 - opt2.7b stoped working too :(

Problem solved. Should have waited for the model to load.

It looks like the model is still in the process of being loaded. When the model has finished loading, Finish loading model {modeltype}! is displayed

I've waiting for 10 minutes did not get Finish loading model {modeltype}! :(

It is extremely long and I'm currently thinking about speeding it up.


Not work on Tmux 2.5

When I typing: C-a + C-f not works, and cannot select as expected, please watch following video screen record:
https://www.dropbox.com/s/o4iqkkfnthfx8fg/tmux_2.5_problem.mov?dl=0
I am using fishshell 2.6 and tmux 2.5 on osx

tmux 2.5 also broke my setup, some changes I noticed:

the -t argument (to select a keymap table) is now -T
the keymap tables were renamed (e.g. vi-copy is now copy-mode-vi)
copy mode commands now need to be sent with send-keys -X, e.g. where before I could do page-down I now have to call send-keys -X page-down

Hi,
the changes in tmux 2.4 broke this plugin. I have to find some time to make fixes. I've added a note about this to the readme.

Any update on this?

Hi, unfortunately no. The plugin works up to tmux version 2.3 and that's stated in the readme.

I have some scripts that can extract paths & urls from the buffer which you can then select via fzf. So it's not the same as copycat but it works quite well. If anyone is interested I can try to turn that into a plugin.

Before you turn those into a plugin, could you share the scripts so that we can try them out? 🙂

Everything that uses tmux and fzf tends to be a good thing
I’m not sure how much I can help myself but I’m interested.
Sent from my iPhone

On 20 Sep 2017, at 12:14, Christian Zangl<EMAIL_ADDRESS>wrote:
I have some scripts that can extract paths & urls from the buffer which you can then select via fzf. So it's not the same as copycat but it works quite well. If anyone is interested I can try to turn that into a plugin.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

@maximbaz @oschrenk you can take a look at it here

@laktak I have replaced tmux-copycat with your plugin as it seems to be more universal and less keys to remember 👍

@phye thanks, I had a ton of help from @ivanalejandro0 and @maximbaz though!

@laktak awesome plugin 👌

Closing this PR as this was addressed via #119

So great and in the process extrakto was born 😊


Kotlin dependencies alignment between OkHttp and Okio

OkHttp depends on Okio, and both have Kotlin stdlib dependencies.  But there's a mismatch between the stdlib versions that they depend on.
What I'm currently getting at runtime is a mix of versions.  (kotlin-stdlib version 1.4.10 and kotlin-stdlib-common version 1.4.0.)  That makes me wonder what version of those libraries were used in the OkHttp test pipeline.  I would be grateful if there were an alignment between OkHttp and Okio on the Kotlin stdlib version that they depend on, so it would be clear what to use at runtime.

Dupe of https://github.com/square/okhttp/issues/6184
Generally we try to keep them lined up, but different developers do the upgrade, so they can be temporarily out of alignment.  This is not considered to be an issue, in your app you can safely depend on the latest kotlin version.

Also if you have 1.4.10 of the stdlib then it should have a dependency on 1.4.10 of the stdlib-common which your build system should select over a transitive dependency on 1.4.0 of the stdlib-common. Or perhaps those Kotlin versions are just too old? In the newer ones this is definitely what will happen.


Fixes #59: Adds Python Program to find factorial of entered number

Added both recursive and iterative approach to find factorial of an entered number.

@HarendraSingh22 Please review :)


[WFRP4e System] Custom path for Icons

Wouldn´t it be kinda great if we could have a custom path for the WFRP core icons? From: Peace#3721foundry: 10.291wfrp4e: 6.3.0wfrp4e-altdorf: 2.0.2wfrp4e-archives1: 2.4.1wfrp4e-archives2: 3.0.1wfrp4e-core: 3.0.4wfrp4e-owb1: 2.0.1wfrp4e-rnhd: 3.0.2wfrp4e-starter-set: 3.0.2wfrp4e-ua1: 2.3.2wfrp4e-ua2: 2.0.0wfrp4e-up-in-arms: 3.0.0Active Modules: about-time, advanced-macros, alien-actions, arcane-marks-careers, autoanimations, autocomplete-whisper, baileywiki-nuts-and-bolts, betterroofs, chat-portrait, colorsettings, compendium-folders, dd-import, dfreds-droppables, drag-ruler, easy-target, find-the-culprit, forien-quest-log, foundryvtt-simple-calendar, fxmaster, lessfog, levels, lib-wrapper, mels-masterworks, monks-active-tiles, monks-scene-navigation, monks-wall-enhancement, moulinette-core, moulinette-gameicons, moulinette-imagesearch, moulinette-scenes, moulinette-sounds, moulinette-tiles, multi-token-edit, multilevel-tokens, perfect-vision, popout, quick-insert, quick-module-enable, select-tool-everywhere, sequencer, socketlib, splatter, times-up, token-action-hud, token-attacher, tokenmagic, vtta-tokenizer, wall-height, weather-control, wfrp4-wfrp4e-npc-generator, wfrp4e-fx, wfrp4e-gm-toolkit, yze-combat, forge-vtt, forge-vtt-optional

https://github.com/moo-man/WFRP4e-FoundryVTT/issues/135


Where can I find your paper?

Hello, can you post a link to the paper, thank you~

@yuemengyuan Google this paper title directly, you won't miss it.

hello, do you find the paper?

@ayantian Yes, google it's title directly

Thank you very much:)
发自我的iPhone
------------------ Original ------------------
From: wangzhe0623<EMAIL_ADDRESS>Date: Fri,Sep 27,2019 1:32 PM
To: AlexanderParkin/ChaLearn_liveness_challenge<EMAIL_ADDRESS>Cc: ayantian<EMAIL_ADDRESS>Mention<EMAIL_ADDRESS>Subject: Re: [AlexanderParkin/ChaLearn_liveness_challenge] Where can I find your paper? (#4)
@ayantian Yes, google it's title directly
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.


Remove deprecation from FleetAllocation

Since #600 is in the wings for next release, which is another breaking change, let's keep FleetAllocation stable for another release and mark GameServerAllocation as experimental to manage expectations appropriately.

/cc @Kuqd @jkowalski - this work for both of you?


Not working in Python 3

It works when I run with Python 2, but when I run with Python 3 I get the following error.
Traceback (most recent call last):
  File "og.py", line 9, in <module>
    import opengraph
  File "/usr/local/lib/python3.5/dist-packages/opengraph/__init__.py", line 1, in <module>
    from opengraph import OpenGraph

This needs a new release, current code in master branch is working correctly. The 0.5 release doesn't have the fixes.
You can get by installing from current master checkout.

seems like the author uploaded the python 3 version with another package name, it's on PyPI as opengraph_py3
pip install opengraph_py3

4.5 years ago. I think that this codebase is deprecated.
Better use:
https://github.com/topicaxis/opengraph
or:
https://github.com/ji3g4m6zo6/opengraph_py3-0.71
or even:
https://github.com/jvanasco/metadata_parser


Matcher throws an error when the test wants to check an array of the object.

Matcher throws an error when the test wants to check an array of the object.
When a karate match request using the * match response = #[] schema'  the karate matcher throw an error
java.lang.AssertionError: SyntaxError: Unnamed:1:24 Expected ; but found : {name: '#string', region: '#string'}
Repository to reproduce test - https://github.com/TomashGombosh/karate-demo
Test - https://github.com/TomashGombosh/karate-demo/blob/main/src/test/java/com/tomashgombosh/qa/test/Main.java

@TomashGombosh this is a case where I'd appreciate just 2-3 lines that I can paste into a feature file and try. a maven project is not required. please provide that to reopen. for example:
* def city = {name: '#string', region: '#string'}
* def schema =
"""
{
  "id": "#number",
  "cities": "#[] city"
}
"""
* def response = [{"id": 1, "cities": [{"name": "Uzhhorod", "region": "ZK"}]}]
* match response == '#[] schema'

@ptrthomas Thank you for answering my question.
If I use that code that you use, the matcher does not throw any error.
But if I use to read from file the JSON that I want to match, as in my repo. The matcher still throwing errors.
Are some differences in that approaches?
`
Feature: Check
Scenario:
* def schema = read('dataFiles/example.json')
* def response = [{"id": 1, "cities": [{"name": "Uzhhorod", "region": "ZK"}, {"name": "Kyiv", , "region": "ZK"}]}, {"id": 2, "cities": [{"name": "Uzhhorod", "region": "ZK"}, {"name": "Kyiv", , "region": "ZK"}]}]
* match response == '#[] schema'
`

@TomashGombosh yes I think there is a difference. you should be able to make it out by comparing what I posted and what you have. I haven't had the time to dig deep, but I think you are using karate in an un-supported way. please refer to the docs and examples if you have any specific questions. I also prefer that questions like this are asked on stack overflow. here is an example: https://stackoverflow.com/a/70006027/143475

@ptrthomas understood. Thank you!


Update teslajs.js with getPaintColor Error handling

Fixes #Tesla removing Option_codes.
Changes proposed in this pull request:

Added a conditional to see if either vehicle or vehicle.option_codes exists, if one is true, return "unknown"
Tesla have removed option_codes from some cars through this method so it makes sense to add some error handling eventualities

Apologies for the delayed review. I've stepped away from the library for a while as Tesla sorts out their 3rd party developer story.


Paloma LightNode Sale Auction Back-end

As a user, I want to be able to participate in the Paloma LightNode sale where I can enter my bid for a Paloma LightNode and have that bid calculated on the VCG auction model.
Acceptance Criteria

Create the back-end auction service for Paloma LightNode Sale
Use the VCG Auction model and code from https://www.notion.so/volumefi/EPIC-07-12-24-Paloma-Light-Node-Public-Sale-8ea43ca42b2442d3977f8dc6237624f3
Store purchaser information into the back-end

Close this as won't complete. We are moving to bonding curve.


[random123] Add new port

Provide port for Deshaw Research's Random123 implementation

Which triplets are supported/not supported? Have you updated the CI baseline?
All / Yes - This is a header only package.

Does your PR follow the maintainer guide?

Yes

If you are still working on the PR, open it as a Draft: https://github.blog/2019-02-14-introducing-draft-pull-requests/

Thanks for adding this port, please run command vcpkg x-add-version random123 --overwrite-version on vcpkg window.

Thanks for adding this port, please run command vcpkg x-add-version random123 --overwrite-version on vcpkg window.

I applied the fixes you requested.  Thank you for providing feedback.

I applied the fixes you requested. Thank you for providing feedback.

This didn't work because you modified the portfile without committing this change before running x-add-version. You have to run vcpkg x-add-version random123 --overwrite-version again.

vcpkg x-add-version random123 --overwrite-version

I didn't understand that they needed to be in separate commits.  I updated the version again.

You have modified or added at least one vcpkg.json where you should check the license field.

The software uses as custom license, so I added license: null.

Sorry I am late, I did a little change, just formatted the portfile.cmake and merged master, added "" for absolute path.


Topicable namespace

The namespace for the Topicable model is currently 'namespace App\Models;but should benamespace Harishdurga\LaravelQuiz\Models;` like the others in the package so it could be accessed elsewhere.
For example, you cannot run Topicable::truncate();

@harishdurga happy to create a pull request for a fix for this if you want but figured it would be easiest for you if you just made the modification with whatever else you are doing in your next release. If not, let me know and I'll take care of it.

I'm sorry for not getting back to you sooner. I will work on this issue as soon as possible and resolve it.


Fix singleton creation

fixes #133
Hello Yoichi,
thank you for creating Swinject!
I found that the calls to the initCompleted closures caused some objects to be created twice. In my case it was a ViewController which was instantiated twice during object creation.
Postponing the call to the initComplete methods allows the Parent class to be registered in the pool before the initComplete method of the Child gets executed and thus prevents the duplicate creation of Parent.
Please find in the PR a test case for the problem as well as a suggestion for the solution. This PR is targeted at version 1 since this is the version I'm currently using.
Cheers,
Markus

Thanks @marcorei for the great idea to fix the issue. I was thinking it was difficult fix it, but you got it. Let me check the changes, and I'll come back soon.

Thank you @marcorei for fixing the difficult problem😃💡👍 I'll release an update soon.


Worker API loses all hierarchy information in FileTree

When using the Worker API, a parameter that is a ConfigurableFileCollection has its data serialized via getFiles() and so, if a FileTree is used as the input, all hierarchy information is lost. Essentially the FileTree is just a FileCollection at this point.
Expected Behavior

I should be able to pass a file tree into a worker action and have the worker action see the input parameter as a file tree, and not a file collection.
Current Behavior

Due to how the data is seralized/unpacked (getFiles()), hierarchy information is lost, and using parameters.fileCollection.asFileTree.visit {} visits only files and not directories, and the visited file has a useless relativePath property (it's just the filename itself).
Context

In my dependency analysis plugin, I analyze source files and it's important to know the path to the file relative to the root. An example of a root is src/main/java and an example of a useful relative path is com/example/Foo.java. Without this information from the file tree, I have to bake in the assumption that there's a prefix that is three path segments long and then trim that off manually. Additional context is that I need to do this for both Android and JVM projects, which have very different source set implementations.
Steps to Reproduce

class MyPlugin : Plugin<Project> {
  override fun apply(...) {
    tasks.register("myTask", MyTask::class.java) {
      it.theSourceFiles = getFileTreeOfSourceFiles() // impl left to the imagination

      // note that this works as expected:
      getFileTreeOfSourceFiles().visit {
        if (!isDirectory) { println(relativePath) }
      }
    }
  }
}

abstract class MyTask @Inject constructor(
  private val workerExecutor: WorkerExecutor
): DefaultTask() {

  @get:InputFiles
  abstract val theSourceFiles: ConfigurableFileCollection

  @TaskAction fun action() {
    workerExecutor.noIsolation().submit(MyWorkAction::class.java) {
      sourceFiles.setFrom(theSourceFiles)
    }
  }
}

interface MyParameters : WorkParameters {
  val sourceFiles: ConfigurableFileCollection
}

abstract class MyWorkAction : WorkAction<MyParameters> {
 override fun execute() {
   parameters.sourceFiles.asFileTree.visit {
     if (!isDirectory) { println(relativePath) } // just the file name
   }
 }
}

Your Environment
Discussed with @wolfs in gradle community slack https://gradle-community.slack.com/archives/CA745PZHN/p1637971577129300

Would still like this.


feat: 添加Mina文档

feat: 添加Mina文档

it's possible in theory due to its size not getting bigger. but currently MINA's transaction throughput is not big enough (seems like 1 tps). anyway, i would try if there's any way to put it on mobile.


update checkSearchingAllReferencesReturnsWellFormed

The current test searches for all reference sets then checks they match the test data. This fails for servers with more than just the compliance data.
This PR replaces the comparision to compliance data with checks that the id is not null and the md5 looks like an md5.
Fixes #161

+1

:+1:


Middleware process_resource isn't called for sinks

This may be intentional, but I couldn't find anything in docs to confirm that other than some discussion on #691... even there, though, it wasn't necessarily clear that this behavior's intentional.
If we have a process_resource method on middleware, it's not called when a sink is matched, since resource is None inside of api.__call__. Personally I would consider a sink to be a resource, but really I'm just looking for clarification about whether they should be (and in that case, is this behavior a bug) or should not be (and then maybe just a note added to the docs).

Hi @mcm, I can see how a sink might be considered a resource in the abstract, but in terms of implementation, the former is universal responder method, while the latter is a collection of responders wrapped in a class. Therefore, a given process_resource() method would have to distinguish between the two.
I can think of a couple of ways we might handle this, but before we get into that, could you elaborate on your particular use case? Do you need a reference to the sink callable, or do you have some logic that you only want to run when a resource or a sink matches the requested URL path?

Hi there, to resurrect this issue that the googlebots brought me to, I ran into this with authorization-vs-custom-404.
Use case:

Have a custom 404 responder implemented as a sink to respond a custom 404 to any unmatched routes
Have authorization implemented as a middleware
I would expect an unmatched route to first hit authorization, then the 404 sink only if authorization succeeds (ie expect a 401 before revealing route is 404)

imho, falcon is being too restrictive by defining "middleware" as "something that operates on a Resource", if a sink is not to be a Resource.
Feels like there should be a middleware abstraction that allows you to act on any request so you can do things like authorization, session mangling, request logging, or any other aspect-oriented things regardless of whether the request is ultimately handled by a Resource or a single-function sink.
Perhaps the answer to make sinks an implicit Resource of some sort?

We now have three types of routes supported by the framework:

Resources
Sinks
Static files

It may make sense after all to provide a way for middleware components to hook requests that end up matching any of the above, rather than only providing a way to intercept requests to resources.

I was a bit suprised to see that middlewares are not called for sinks!
My use case: serving files behind a prefixed route: GET /api/v1/images/.*
Because the files may be stored in a file tree (say, foo/bar/dog.png), I though a sink would be good, but then it broke my auth middleware.

Hi @Sylphe88!
Yeah, that's the way it currently works...
As a workaround for authentication middleware you might be able to leverage [process_request()] instead, that is called for all incoming requests.

I changed how the route URI is formed so I can use resources instead of sinks, the result is cleaner. process_request() would have been the other way to go but then again existing middlewares (e.g. falcon-auth) mostly rely on process_resource() for better performance, so they won't be called for sinks


improv: add notoggle attribute to media-time-display

tested out and this is working on basic.html example 👍🏼


Remove "type": "module" from all package.json files

Since #1264, another person could not build its assets with Encore and a babel plugin.
So for now we decided to revert the "type: module" declaration.
Revert the "type: module"
Remove this "type" line from all package.json files and revert replacing "main:" with "module:"
Before
   "type": "module",
   "module": "dist/foo.js",

After
   "main": "dist/foo.js",

Fix Svelte ESM bug with vite/vitest
We recommend converting your config to ESM by either:

    adding "type": "module" to the nearest package.json
    renaming vite.config.js/vite.config.ts to vite.config.mjs/vite.config.mts

(https://vitejs.dev/guide/troubleshooting.html#config)
So i used the second one.... and it seems to work

PR was merged... just didn't close


RSpec 3.2 compatibility

I've rewritten the way the methods are aliased for RSpec. This effectively removed all deprecation warnings from our Jenkins test-suite.
I'm not sure whether I've changed the changelog correctly, feel free to change if needed.

Thanks!


Add GitPod config file

/cc @nate-double-u

:+1: Thanks!
It'd even be possible to launch both a webserver to run the site (bundle exec nanoc view) and a watcher for changes in the sources (bundle exec guard IIRC), but this is good for now.


Makefile: correct indentation using tab. Fix #13

Fix for error: Makefile:8: *** missing separator.  Stop.

Thanks.


weight initialization at message passing module

Hi:)
May I know why you use random normal initializer at messaging passing module given the activation function is RELU.
I think using He initializer or Xavier initialzer would  be better?
Best,
ZX

Another question is that, I wonder whether dropout is turned off at testing stage?

As to weight initialization, you can have a try. And yes, dropout is turned off in the testing phase.

Could you please tell me more on how dropout is turned off during test phase?
Based on what I observe: in lanenet merged model: Lanenet.test_inference still calls vgg_encoder, where dropout is not turned off.
So Im quite confused loll.
Thanks!

Please see this function. In training, dropout is enabled and in testing, it is turned off.

okay:) this helps!
Thanks!


Fix GH Actions: trigger (branch name) and pylint

Description
This PR fixes triggering of GH Actions and pylint.
This syntax:
    branches: [ $default-branch ]

doesn't work (it comes from "Workflow templates", see: Stack Overflow).
After it's fixed this line:
        python -m pip install pylint --rcfile=pylintrc.dms pipeline_dp tests

results in "no such option: --rcfile" error ("pip install" happens during the earlier "Install dependencies" step).
Affected Dependencies
None
How has this been tested?

Describe the tests that you ran to verify your changes.
Tested on my fork.

Provide instructions so we can reproduce.
~Try it on your fork.~ See below :arrow_down:

Checklist

[x] I have followed the Contribution Guidelines and Code of Conduct
[x] I have commented my code following the OpenMined Styleguide
[x] I have labeled this PR with the relevant Type labels
[x] My changes are covered by tests

Could you please run make format to fix issues that might be fixed automatically and also create a Github issue to fix others?

make format currently uses 4 spaces for indentation (this is from a yapf option) while pylint requires 2 space indentation (a setting in pylintrc.dms). I think this needs to be resolved first.
Do you have a battle tested setup where both yapf and pylint can be used together for formatting without conflicts? I'm not sure if we really want to maintain two configs (yapf and pylint) for the same thing (formatting)? Maybe let's talk during the call tomorrow.


cleaner code, gitgnore, simplify

Looks good to me!

While I appreciate that you took the time to do this, I don't appreciate:

The restructuring of my preferred directory layout

While it is outdated since I made the server obsolete, I still prefer a base src folder.
The deletion of the LICENCE and README.md files.
The addition of a bloated .gitignore file.
Infringing on my established formatting and member naming styles.
Moving around a lot of utilities that doesn't need to be moved around.
Gross over-usage of instanced classes.
Removing the JsonProperty attributes (why?).
Setting fields to null when I purposefully don't want them to be.

I understand the current code leaves much to be desired, but that is because I prioritized making it work first and foremost. If you would like to assist me in development, please tackle an existing issue or contact me through Discord (Tomat#0001) or Matrix (@tomat:matrix.org).
Thanks!


Integration Testing for more GPUs

Greetings from AWS,
I work with the PyTorch team at AWS, we are interested in testing & validating Triton support for the GPU hardware we offer to customers on AWS.
I went through the integration tests & see that A10 & V100 GPU's are currently being tested as part of the integration tests. We would like to extend the testing harness to run tests on the supported GPU's (T4, A10, T4G, V100, A100) offered by AWS. If the community is interested in this we can help with offering the needed hardware on AWS, extending the test harness to run tests on these GPU's & fixing issues in the running the tests.
The following table captures, current status on Triton's GPU support and testing.

GPU
CUDA
Supported
Tested

T4
7.5
Yes
No

A10
8.6
Yes
Yes

T4G
7.5
Yes
No

V100
7
Yes
Yes

A100
8
Yes
No

We look forward to working with Triton community to make this happen.

That would nice.

We would like to extend the testing harness to run tests on the supported GPU's (T4, A10, T4G, V100, A100) offered by AWS.

For free?  😁
@ptillet

I'd love to! I think it just boils down to creating github agents that are hooked up to our repo.
Are you guys on the triton-slack? if not, here's an invite link: https://join.slack.com/t/triton-lang/shared_invite/zt-1o7f49vj9-lMcqMjWZOaizB85neBdzTA . We can discuss there.

Thanks @Jokeren & @ptillet appreciate the quick response. @ptillet I just created the slack account & reached out to you to discuss this further.

I wonder if we could get multiple instances of the same GPU as well (e.g., 2xA100s)? That could potentially reduce the conflicts a bit when people are making contributions.


ENOENT: no such file or directory, rename

Seeing issue #866 on npm 5.8.0
npm ERR! path /mnt/Temp/svc-project/node_modules/.isobject.DELETE/node_modules/isarray
npm ERR! code ENOENT
npm ERR! errno -2
npm ERR! syscall rename
npm ERR! enoent ENOENT: no such file or directory, rename '/mnt/Temp/svc-project/node_modules/.isobject.DELETE/node_modules/isarray' -> '/mnt/Temp/svc-project/node_modules/isobject/node_modules/isarray'
npm ERR! enoent This is related to npm not being able to find a file.
npm ERR! enoent

Running npm i<EMAIL_ADDRESS>before npm install got rid of the error above but it errored out on another dependency
ENOENT: no such file or directory, rename '/mnt/project/node_modules/.ldap-filter.DELETE/node_modules/assert-plus' -> '/mnt/project/node_modules/ldap-filter/node_modules/assert-plus'
npm ERR! enoent This is related to npm not being able to find a file.

I am running npm on Ubuntu 16

Interestingly running the npm install on a non-mounted file system did not give this error and the install was successful

I just deleted the existing node_modules and it worked for me.

Hello everyone,
Try to delete package-lock.json file and then install package what you want (that caused a renaming files).
It can fix a problem. I hope this help you :-)

what also causes this error is due to incorrect path


[cxxgraph] Add new port CXXGraph

[x] Changes comply with the maintainer guide
[x] The name of the port matches an existing name for this component on https://repology.org/ if possible, and/or is strongly associated with that component on search engines.
[x] Optional dependencies are resolved in exactly one way. For example, if the component is built with CMake, all find_package calls are REQUIRED, are satisfied by vcpkg.json's declared dependencies, or disabled with CMAKE_DISABLE_FIND_PACKAGE_Xxx
[x] The versioning scheme in vcpkg.json matches what upstream says.
[x] The license declaration in vcpkg.json matches what upstream says.
[x] The installed as the "copyright" file matches what upstream says.
[x] The source code of the component installed comes from an authoritative source.
[x] The generated "usage text" is accurate. See adding-usage for context.
[x] The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
[x] Only one version is in the new port's versions file.
[x] Only one version is added to each modified port's versions file.

@microsoft-github-policy-service agree

Note: I will be converting your PR to draft status. When you respond, please revert to "ready for review".
That way, I can be aware that you've responded since you can't modify the tags.

The PR was not marked as draft, so consider this comment to be marking as ready for review :)

Looks great, thanks for the new port!


PHPUnit stopped working with Luthier-CI

Dear Sir,
Once I installed the Luthier-CI, all the tests of the TDD UnitTest start giving the following error:
1) Welcome_test::test_index
Exception: Serialization of 'Closure' is not allowed

One I comment the Hook information:
$hook = Luthier\Hook::getHooks([
    'modules' => ['auth']
]);

Everything works fine, any suggestion?
Thank you,

Hi!
The unit tests are not being finished yet. we were very busy but the development of this project (and others that we own) will be resumed in a few days. However, these unit tests are meant for the Luthier CI development, not to be used as a PHPUnit bridge for CodeIgniter applications. You can use the kenjis/ci-phpunit-test package for that.

I did, but all the tests fails because of the error that I told you about:
1) Welcome_test::test_index
Exception: Serialization of 'Closure' is not allowed

Yeah, I've confirmed the error, but it's too early to tell you what's triggering it. At the moment I'll keep this issue open while finding a solution :worried:

Nothing yet. I'm still looking for a solution.

Is this repo is still being maintained?

Related to https://github.com/kenjis/ci-phpunit-test/issues/187#event-1118117087
It can be solved by the workaround above.


Installation problem

Hi, For testing purposes, I wanted to install your program on my VPS server.  Unfortunately, I have a problem like in the screenshot.  Could you please help me solve my problem?

I had the same issue.
It is related to Python version. Probably You have Python 2 installed instead of Python 3