Support call_nth/2

This predicate is particularly useful for testing purposes.

Why not ask for change_arg/3. You can bootstrap a lot
of usuful think with change_arg/3 alone. Here is my take
on call_nth/2 as done for Dogelog Player:
/**
 * call_nth(G, C):
 * The predicate succeeds whenever G succeeds and unifies C with
 * the numbering of the successes.
 */
% call_nth(+Goal, -Integer)
call_nth(G, C) :- var(C), !,
   call_nth2(G, N),
   C = N.
call_nth(G, C) :-
   C > 0,
   call_nth2(G, N),
   (C =:= N -> !; fail).

% call_nth2(+Goal, -Integer)
call_nth2(G, N) :-
   Holder = v(0),
   G,
   arg(1, Holder, M),
   N is M+1,
   change_arg(1, Holder, N).

Ok, you know this implementation anyway,
but nobody promotes change_arg/3, why is this so?
count the number of calls of a clause
https://stackoverflow.com/a/11400256/17524790

Providing destructive assignment has many negative effects. It results in many implementation dependent effects that practically prevent more advanced techniques. Both statically and dynamically.
Consider the fact
f(g(h(c)), h(c)).

this might be compiled into
f(g(X),Y) :- X=h(c), X = Y.

With destructive assignments present, such optimizations change the meaning of programs.
If you look into existing implementations, there are only a few that permit general destructive assignment (SWI), many provide more limited, much better defined forms (SICStus, Eclipse). And some just provide call_nth/2 like Trealla and Scryer.
Term representation becomes a bit visible when writing unnamed variables (?- writeq(X-X).) and in term comparison. With destructive assignment things become much worse.
The easiest way out is just to provide call_nth/2 and to defer all other considerations to a later moment.

If you don't think about introducing change_arg/3 in your
Prolog system first, and start implementing call_nth/2 and all
other stuff instead first, you are doing something wrong.
The design flaw is seen in Scryer Prolog which has a much slower call_nth/2 now:
/* Scryer Prolog */
?- time((between(1,1000,_), call_nth(call_nth((X=a;X=b), N), M), fail; true)).
   % CPU time: 1.010s
   true.

On the other hand in Dogelog Player I get, and I even don't need
any expensive setup_call_cleanup/3 in its implementation:
/* Dogelog Player */
?- time((between(1,1000,_), call_nth(call_nth((X=a;X=b), N), M), fail; true)).
% Wall 61 ms, gc 0 ms, 837475 lips
true.

Or as Trump said: "If it works, its not broken". You can mark
the built-in as internal only, and warn the ordinary end-user
to not use it, until the end-user exactly knows what he is doing.

Actually Trump said: "Sounds good, doesn't work". But change_arg/3
is exactly the converse. It excels above all!!! In the above Dogelog Player
is 16 times faster. But I nowhere advocate making change_arg/3 a
novice Prolog programmer predicate. I even don't know whether its
possible in Scryer Prolog or in ichiban/prolog. Also change_arg/3 is
usally simpler to use for atomic Prolog terms than for non-atomic
Prolog terms. So a strategy could be to first experiment with change_arg/3
that can update atomic replacements. Later things can indeed become
complicated, for example SWI-Prolog has two different copy_term/2.

As to SICStus and ECLiPSe, you could see their highly restricted ways providing such functionality in the link to SO that you posted. They do not provide the generality of setarg. There used to be an (undocumented) setarg in earlier versions of SICStus which was according to the sources "Put in at the express request of" some person. And it only worked for one cons-cell. As for GNU, it does not have garbage collection...

You wrote:

you could see their highly restricted ways providing such functionality in the link to SO

I don't see anything. Its shows the use case call_nth/2. It doesn't not discuss ECLiPSe Prolog even.

You see what the potential speed is in GNU Prolog:
?- ((between(1,1000000,_), call_nth2(call_nth2((X=a;X=b),N), M), fail; true)).
(1578 ms) yes

I was using:
call_nth2(Goal_0, C) :-
   State = v(0),
   Goal_0,
   arg(1, State, C1),
   C2 is C1+1,
   setarg(1, State, C2, false),
   C = C2.

@UWN Thank you for letting me know this! I've learnt that the community hasn't agreed on what nth really means in Prolog https://github.com/ichiban/prolog/issues/160#issuecomment-1068351595 so I'll implement call_nth/2 as an extension and make it available in 1pl.

Looks good, even for this case. And don't worry, should there be any further error, it will soon appear, because I use call_nth/2 quite a lot.


Django 4.0 compatibility

Replace django.utils.http.urlquote with urllib.parse.quote for django… 4.0 compatibility (see https://docs.djangoproject.com/en/4.0/releases/3.0/#deprecated-features-3-0)

Hey Victor, anything I can do, to get this updated? Thanks

This broke my project.  Time to drop.

I have to drop this dependency due to the compatibility problem.  Hope you're ok Victor and you can get around to fixing at some stage!  cheers :)


FormElement shows automatic validation state only when validator addon is present

Fixes #240

Looks good to me.


LogstashTcpSocketAppender: fails silently when connecting to destination fails

Looking a bit closer, it's not actually silent, but I didn't have a statusListener configured in logback which caused this logging to go to /dev/null. A better upstream default here would be nice :/.

Created http://jira.qos.ch/browse/LOGBACK-1097 upstream.

I think the logback-logstash-encoder behavior is correct here.
Do you have any recommendations?

My recommendation is we fix this upstream in logstash. Comments, votes, design discussion on http://jira.qos.ch/browse/LOGBACK-1097 very welcome :)
Personally I like leaving this 'downstream' issue open (with an appropriate tag) until the problem is solved 'upstream': that way we can keep track of 'external' work that will improve the experience of working with logstash-logback-encoder, and perhaps see if we can find another workaround when the problem remains unresolved upstream. But that might be a matter of personal preference :).

It s better to add failed connecction log in default configuration. I m a newbee to logstash-logback-encoder. When my LogstashTcpSocketAppender destination configuration failed to connect logstash, it made me confused cause no single failure log were shown on my console.  Of course we can get failure logs by extending listener. It s still a good idea to add a first time connection failure log for better debuging experience of  logstash-logback-encoder.

The solution of adding to OnConsoleStatusListener is overkill for the appender, because it doesn't just log the errors, it also logs all the INFO messages to console.  It would work much better to have an "on error" status listener that didn't spam data to the console

@wsargent, please file a new issue

done


Allow forms with nested collections of values

Add a unit test?  Not sure if there are any tests for this function currently


fix(platform): redirect to 404 for non-existent projects

closes #3234

:tada: This PR is included in version 5.6.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


[release-1.4] Keep service instances sorted by creation/hostname

This is an automated cherry-pick of #19265

@istio-testing: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

e2e-simpleTests-distroless_istio_release-1.4
fed3d6f243e977fb08705b201336bbaa6aad646d
link
/test e2e-simpleTests-distroless_istio_release-1.4

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/retest


Widget - Standard: In edit mode, I cannot close a widget select box or delete the box after opening.

I expanded the widget options by clicking the + sign to the left. I am unable to close the box by clicking the red x on the right

I tested this in chrome, firefox, and safari. It appears to be working @kelea99 can you test again?


JS SDK - Feature: Add a storage abstraction for persisting task objects and artifacts to other storage locations like redis #2

Is your feature request related to a problem? Please describe.
You can't scale out an Agent because tasks and artifacts are only ever stored in memory.
Describe the solution you'd like
There should be a storage abstraction added that lets you replace the in-memory based storage of tasks and artifacts with an external storage container like redis. I would also add the ability for the Agent developer to store their own state alongside the tasks and artifacts.
The CRUD operations around artifacts should also be abstracted:
https://github.com/AI-Engineer-Foundation/agent-protocol-sdk-js/blob/main/src/agent.ts#L355
I may want to store them in some form of blob storage versus the local disk.
Original link: https://github.com/AI-Engineer-Foundation/agent-protocol-sdk-js/issues/2

I've just created a new repo for file storage - https://github.com/nalbion/any-cloud-storage
Supports AWS, GCP, Firebase, Supabase, git and local file system


Tweak appearance of engine logs

While looking through the console, I found myself scrolling through a lot of long engine lines. I wanted these to be shorter and expandable to make more efficient use of the console space.
These are some subjective and bikesheddy changes to the appearance of engine logs that I'd like to propose. :angel:

Put extra arguments in an object map so that they are expandable and field names can be inspected
Shorten log prefixes to "[engine]" / "[engine] ->" / "[engine] <-" (I feel these are unambiguous when viewing the full content of the log line)
Lowercase all message titles

Before:

After:

:eyeglasses: :bike: @keybase/react-hackers

👍


fix(runtime): Fix runtime errors on 0.4.0

This fixes some runtime errors we encountered with the 0.4.0

@Thebarda Thanks again!  Could you move this PR to the development branch and add some testing?  wanted to understand what kind of code this is breaking!  because we could improve the filtering on line 73 and for the flow right there, because from that line on those properties should exist for the use cases in the react components scenario using hooks, I would be grateful if you would provide a code example that the linter is running.


upload-product-and-stemcell/task.yml still calls out upload-product/task.sh

https://github.com/pivotal-cf/pcf-pipelines/tree/master/tasks/upload-product-and-stemcell/task.yml
Still points to :
run:
path: pcf-pipelines/tasks/upload-product/task.sh
needs to be updated to point to :
run:
path: pcf-pipelines/tasks/upload-product-and-stemcell/task.sh

pull request submitted to correct
https://github.com/pivotal-cf/pcf-pipelines/pull/21


Topshelf keeps waiting for service start that already crashed

I try to run a service using HostFactory.Run and topshelf keeps waiting for started service state even service has already been crashed with an exception during startup.
If service has started succesfully topshelf reports that service is started.
Is it possible to detect service crashing and report failed result code without waiting for a long?
Topshelf v<IP_ADDRESS>, .NET Framework v4.0.30319.42000

Where is the service crashing? Do you have a stack trace indicating the handlers that is throwing? Or is it outside of the Topshelf lifecycle?

Hey, I'm having the same problem.
This seems to be due to sc.WaitForStatus(ServiceControllerStatus.Running, startTimeOut); in this file: https://github.com/Topshelf/Topshelf/blob/1ecd70e130e73fa9e958f506a493319523e660ff/src/Topshelf/Runtime/Windows/WindowsHostEnvironment.cs
Running as '<executable> start'
Either an exception or returning false doesn't stop this timeout and the executable will only exit once timeout has occurred. Debug shows that all threads are dead except for the one in WaitForStatus.
Is it possible to instead link the timeout to RequestAdditionalTime? And on wake up due to timeout check if additional time has been requested?
Alternatively check states more carefully, implementing WaitForStatus in topshelf by polling Status, and not require any topshelf timeout be set?
        var exitCode = HostFactory.Run(x =>
        {
            x.UseLog4Net();
            x.RunAsLocalSystem();
            x.SetDescription("");
            x.SetDisplayName(cs.Config.ServiceName);
            x.SetServiceName(cs.Config.ServiceName);
            x.SetStartTimeout(TimeSpan.FromMinutes(5));
            x.Service<Service>(s =>
            {
                s.ConstructUsing(_ => new Service());
                s.WhenStarted((service, hostControl) =>
                {
                    //throw new Exception("what?");
                    return false;
                });
                s.WhenStopped(service => {});
            });
        });
        if (exitCode == TopshelfExitCode.Ok)
            log.Info("Exiting with success code");
        else
            log.Error($"Exiting with failure code: {exitCode}");

Problem is not a Topshelf crashing, but unnecessary waiting for changing service status change (which in case of service start fails never happens).
When you call 'app.exe start', then this process instance calls Topshelf-StartService from 'src/Topshelf/Runtime/Windows/WindowsHostEnvironment.cs'.
    public void StartService(string serviceName, TimeSpan startTimeOut)
    {

...
sc.Start();  <- windows SCM will create new process to handle service (there is no error or an exception in this function). Now sc.Status should be ServiceControllerStatus.StartPending
sc.WaitForStatus(ServiceControllerStatus.Running, startTimeOut); <- now 'app.exe start' waits for new service process to change status to ServiceControllerStatus.Running, but it will never happens if the new service process will terminate/crash, because sc.Status will change to ServiceControllerStatus.Stopped - but sc.WaitForStatus continues to wait for ServiceControllerStatus.Running (but sc.Status is already ServiceControllerStatus.Stopped).
Solution for this issue would be for example custom waiting (pooling with small sleep like 250ms) for service status change, and if service status changes to Stopped, then do not wait anymore for Running (because it won't change to that status). Of course total pooling time should be maxiumum up to startTimeOut.

I'm having the same issue. It is highly inconvenient, I would call it a bug.

I am closing all issues that haven't seen any activity. You're welcome to submit a PR to resolve the issue or provide more information.


Nothing happens

I ran peerflix with: 'peerflix "someurl" -g'
and unless I use ctrl+c, nothing happens. Nothing is printed either...

Happens with specific torrent with no peers.


Restrict running some operators on only one GPU?

Is it possible to restrict some operators to run on only one GPU? For example, pytorch calculate the Loss on only one GPU. This benefits some losses like Triplet Loss, where we need to search hard positives and hard negatives. The search space is N-GPU times larger.

finally, i solved the problem by splitting  the network to two parts as the gan network does.


add support Dodo_v1

Codecov Report

Merging #35 (4b0d587) into master (07c6f1d) will increase coverage by 2.36%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master      #35      +/-   ##
==========================================
+ Coverage   80.30%   82.66%   +2.36%
==========================================
  Files          20       22       +2
  Lines         533      600      +67
  Branches       98      108      +10
==========================================
+ Hits          428      496      +68
+ Misses        105      104       -1

Impacted Files
Coverage Δ

contracts/oracles/DodoOracle.sol
100.00% <100.00%> (ø)

contracts/oracles/DodoV2Oracle.sol
100.00% <100.00%> (ø)

contracts/libraries/Sqrt.sol
90.00% <0.00%> (+10.00%)
:arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


Add interfaces for ServerAsyncReader/Writers

This change adds ServerAsyncReaderInterface, ServerAsyncWriterInterface, and ServerAsyncReaderWriterInterface classes, analogous to the existing ClientAsyncReaderInterface, ClientAsyncWriterInterface, and ClientAsyncReaderWriterInterface classes.  This adds consistency and makes async server code easier to test (e.g. with mocks).

Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok to test.

Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok to test.

I signed it!

Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok to test.

Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok to test.

LGTM


packet response mac address incorrect

Is there an existing issue for this?

[X] I have searched the existing issues

What happened?
This is a regression experienced after upgrading from 1.10 to 1.11.
This is specially in relation to proxy replacement for services of type LoadBalancer (it could be more pervasive but we haven't noticed anything to this point).
We run (non-bundled) metallb and peer against an FRR router instance. DSR is currently disabled. The expected traffic pattern is:
client -> (intermediary routers) -> frr -> cluster node(s) -> pod
pod -> cluster node(s) -> frr -> (intermediary routers) -> client
After upgrading to 1.11 we observe traffic not returning to the frr node but instead taking a different return path (again, DSR is disable currently).
Below are sample tcpdumps with the different versions installed:
### 1.11.1

#from FFR to K8s
20:49:35.409093 00:50:56:96:94:c2 > 00:50:56:96:e3:ad > <IP_ADDRESS>.53615 > <IP_ADDRESS>.https

# k8s/cilium node
15:49:42.275581 00:50:56:96:94:c2 > 00:50:56:96:e3:ad > <IP_ADDRESS>.53615 > <IP_ADDRESS>.https
15:49:42.275672 00:50:56:96:e3:ad > 00:22:bd:f8:19:ff > <IP_ADDRESS>.https > <IP_ADDRESS>.53615

### 1.10.3

# from FRR to K8s
17:17:59.767264 00:50:56:96:94:c2 (oui Unknown) > 00:50:56:96:e3:ad (oui Unknown), ethertype IPv4 (0x0800), length 60: <IP_ADDRESS>.54663 > <IP_ADDRESS>.https: Flags [.], ack 1, win 1024, length 0
17:17:59.767264 00:50:56:96:94:c2 (oui Unknown) > 00:50:56:96:e3:ad (oui Unknown), ethertype IPv4 (0x0800), length 60: <IP_ADDRESS>.54663 > <IP_ADDRESS>.https: Flags [F.], seq 1, ack 1, win 1024, length 0
17:17:59.767468 00:50:56:96:e3:ad (oui Unknown) > 00:50:56:96:94:c2 (oui Unknown), ethertype IPv4 (0x0800), length 54: <IP_ADDRESS>.https > <IP_ADDRESS>.54663: Flags [F.], seq 1, ack 2, win 502, length 0
17:17:59.775200 00:50:56:96:94:c2 (oui Unknown) > 00:50:56:96:e3:ad (oui Unknown), ethertype IPv4 (0x0800), length 60: <IP_ADDRESS>.54663 > <IP_ADDRESS>.https: Flags [.], ack 2, win 1024, length 0

# k8s/cilium node
22:04:36.059055 00:50:56:96:94:c2 (oui Unknown) > 00:50:56:96:e3:ad (oui Unknown), ethertype IPv4 (0x0800), length 54: <IP_ADDRESS>.54646 > <IP_ADDRESS>.https: Flags [.], ack 1, win 1024, length 0
22:04:36.059066 00:50:56:96:94:c2 (oui Unknown) > 00:50:56:96:e3:ad (oui Unknown), ethertype IPv4 (0x0800), length 54: <IP_ADDRESS>.54646 > <IP_ADDRESS>.https: Flags [F.], seq 1, ack 1, win 1024, length 0
22:04:36.059484 00:50:56:96:e3:ad (oui Unknown) > 00:50:56:96:94:c2 (oui Unknown), ethertype IPv4 (0x0800), length 60: <IP_ADDRESS>.https > <IP_ADDRESS>.54646: Flags [.], ack 2, win 502, length 0
22:04:36.059592 00:50:56:96:e3:ad (oui Unknown) > 00:50:56:96:94:c2 (oui Unknown), ethertype IPv4 (0x0800), length 60: <IP_ADDRESS>.https > <IP_ADDRESS>.54646: Flags [F.], seq 1, ack 2, win 502, length 0
22:04:36.064077 00:50:56:96:94:c2 (oui Unknown) > 00:50:56:96:e3:ad (oui Unknown), ethertype IPv4 (0x0800), length 54: <IP_ADDRESS>.54646 > <IP_ADDRESS>.https: Flags [.], ack 2, win 1024, length 0

Of particular note is the last line from the 1.11.1 output: 15:49:42.275672 00:50:56:96:e3:ad > 00:22:bd:f8:19:ff > <IP_ADDRESS>.https > <IP_ADDRESS>.53615
The ff mac address is associated with a switch in the networking fabric.
The c2 address is the frr instance.
The ad address is one of the cluster nodes.
We're not quite sure why with 1.11.1 those outbound packets are getting (for us) an undesired mac address associated to it.
Any tips/thoughts/pointers? Have I missed a config option that should be set or similar?
Thanks!
Cilium Version
1.10.3 vs 1.11.1
Kernel Version
NAME             STATUS   ROLES                      AGE    VERSION   INTERNAL-IP    EXTERNAL-IP   OS-IMAGE                KERNEL-VERSION               CONTAINER-RUNTIME
na01lkubwrkd01   Ready    worker                     199d   v1.21.4   <IP_ADDRESS>   <none>        CentOS Linux 7 (Core)   5.12.6-1.el7.elrepo.x86_64   docker://19.3.7
na01lkubwrkd02   Ready    worker                     199d   v1.21.4   <IP_ADDRESS>   <none>        CentOS Linux 7 (Core)   5.12.6-1.el7.elrepo.x86_64   docker://19.3.7
na01lkubwrkd03   Ready    worker                     199d   v1.21.4   <IP_ADDRESS>   <none>        CentOS Linux 7 (Core)   5.12.6-1.el7.elrepo.x86_64   docker://19.3.7
na01lkubwrkd04   Ready    controlplane,etcd,worker   199d   v1.21.4   <IP_ADDRESS>   <none>        CentOS Linux 7 (Core)   5.12.6-1.el7.elrepo.x86_64   docker://19.3.7
na01lkubwrkd05   Ready    controlplane,etcd,worker   199d   v1.21.4   <IP_ADDRESS>   <none>        CentOS Linux 7 (Core)   5.10.1-1.el7.elrepo.x86_64   docker://19.3.7
na01lkubwrkd06   Ready    controlplane,etcd,worker   199d   v1.21.4   <IP_ADDRESS>   <none>        CentOS Linux 7 (Core)   5.12.6-1.el7.elrepo.x86_64   docker://19.3.7
na01lkubwrkd07   Ready    worker                     199d   v1.21.4   <IP_ADDRESS>   <none>        CentOS Linux 7 (Core)   5.10.1-1.el7.elrepo.x86_64   docker://19.3.7
na01lkubwrkd08   Ready    worker                     199d   v1.21.4   <IP_ADDRESS>   <none>        CentOS Linux 7 (Core)   5.10.1-1.el7.elrepo.x86_64   docker://19.3.7
na01lkubwrkd09   Ready    worker                     200d   v1.21.4   <IP_ADDRESS>   <none>        CentOS Linux 7 (Core)   5.10.1-1.el7.elrepo.x86_64   docker://19.3.7

Kubernetes Version
1.21.4
Sysdump
Sorry didn't catch this before downgrading the cluster :( can add later for sure.
Relevant log output
No response
Anything else?
No response
Code of Conduct

[X] I agree to follow this project's Code of Conduct

Of particular note is the last line from the 1.11.1 output: 15:49:42.275672 00:50:56:96:e3:ad > 00:22:bd:f8:19:ff > <IP_ADDRESS>.https > <IP_ADDRESS>.53615
The ff mac address is associated with a switch in the networking fabric.
The c2 address is the frr instance.
The ad address is one of the cluster nodes.

In short, the diff between the two versions is:
1.11:

00:50:56:96:e3:ad > 00:22:bd:f8:19:ff > <IP_ADDRESS>.https > <IP_ADDRESS>.53615

1.10:

00:50:56:96:e3:ad > 00:50:56:96:94:c2 > <IP_ADDRESS>.https > <IP_ADDRESS>.54646

In 1.11, it's pushing the packet to the switch as next hop vs in 1.10 pushing to the frr instance as next hop.
Is the 00:22:bd:f8:19:ff the default gateway from the pov of the <IP_ADDRESS> node?
Who is installing 00:22:bd:f8:19:ff onto the node? When you do ip r and ip n, would regular traffic originating from node <IP_ADDRESS> also take the switch as next hop or rather the frr instance?
In 1.11, we reworked the neigh handling to reuse the existing kernel's neighbor table on the node:
https://isovalent.com/blog/post/2021-12-release-111#managed-ipv4-ipv6-discovery

OK, finally had a chance to revisit this after waiting for v1.11.2 to be released. Indeed the issue was related to the nexthop discovery changes between 1.10 and 1.11.
In our case (for both dsr and snat configurations, or said differently, even without dsr enabled) the result of the changes was asymmetric routing and undesirable behavior (for us). As mentioned in the description we have some intermediate FRR routers where our LB IPs are advertised and all LB traffic coming into the cluster goes through those. We wanted all LB traffic to return through those as well (while not screwing with the standard routes on the nodes).
Based on the work here:

https://github.com/cilium/cilium/pull/18585
https://github.com/cilium/cilium/issues/18199

we have now been able to create some policy based routing rules that push any traffic with the LB IPs as the src back through FRR (and only that traffic). A crude example of this is:
# create the routing table
echo 20 cilium >> /etc/iproute2/rt_tables

# create a src-based routing rule to use the table
ip rule add from <service/metallb network> lookup cilium
...repeat for all BGP/metallb networks

# populate the table with a default route
ip route replace default via <FRR IP> table cilium

# (optional if you have more than 1 router instance) populate the table with multiple default nexthops
ip route replace default table cilium \
    nexthop via <FRR1>  weight 1 \
    nexthop via <FRRN> weight 1

My intent is to write a sort of metallb agent that automates all of the above by watching the metallb configmap AND doing some sort of health check on the nexthops for scenarios where multiples are defined.
Thanks for the help an attention! This can likely be closed at this point.

Thanks for the help an attention! This can likely be closed at this point.

Thanks for the update. Closing.

As a final update I created this to manage this: https://github.com/travisghansen/metallb-node-route-agent


When used with Ember.js the 'Uncaught Office Web Extension script library file name should be office.js or office.debug.js' occurs

Standard app import is used

app.import('bower_components/microsoft-office-js/scripts/office/1/office.debug.js');
script loads but throws:

UnrecognizedURLError: /assets/bower_components/microsoft-office-js/scripts/office/1/office.debug.js

'bower install' does not work when bower.json is updated with: "microsoft-office-js": "*",

ENOTFOUND Package microsoft-office-js not found

'bower install' creates the microsoft.office.js folder when bower.json if updated with:  "microsoft.office.js": "*"

Neither approach works.

Microsoft as moved to a model where they don't publish the JS files even via NuGet anymore, rather the JS libraries are all hosted. Thus... keeping this project updated with the latest is not relevant anymore.


DONT-MERGE exploring broken test

Don't merge this, if the fix makes sense, we can merge https://github.com/rancher/cattle/pull/2451, as it has the same fix.

Closing in favor of https://github.com/rancher/cattle/pull/2451


feat: support RequestQueue batched add requests

I've only done preliminary tests, however it's mostly a copy-paste of addRequest with added handling for multiple requests
Closes https://github.com/apify/apify-ts/issues/58

Ah, Actions have some issues... That explains why CI is not running rn

i would like to see some integration tests, seems like you only tested the client method is called, but not that it actually works

I'd love to setup an E2E test for this, maybe I can get some help from @AndreyBykov with doing it if he has time? Would also let us see if the endpoint works

Mmmm actually, I am quite sure it will not work, as those tests work locally, and we don't have the batch support implemented in storage-local! Please take a look at that too, do it in the https://github.com/apify/apify-storage-local-js repo, not in the monorepo copy, so we can publish it.

also how does the unprocessedRequests work, do we need to handle that somehow here?

At a first glance, it seems to return requests that weren't added to the request queue (at a glance it seems to be requests that already exist in the queue that would be filled in here). I don't think we want to re-add them again forcefully


Is this feature already released ?

Hi , i just wanted to know if this feature is already released ?
I see the Global Teams policy "Discover private Teams" and it is on, but i cannot search for private Teams.
THX Sven

@skares thank you for submitting feedback.
I think the best way forward is if you open a service ticket in your tenant so this can get resolved ASAP. Based on the outcome let me know if it is something that can be called out in the docs.
Please follow this link to contact support for business products:https://docs.microsoft.com/office365/admin/contact-support-for-business-products
Please keep us posted here on the resolution so we can feed whatever information you discover into the content.


Kivy with Python 3.5 (Ubuntu)

Is it possible to run kivy with python 3.5 on ubuntu?
It works with python 2.7. It also works with python 3.5 on windows.
monny@aPC:~$ python3.5 helloWorld.py
[INFO   ] [Logger      ] Record log in /home/monny/.kivy/logs/kivy_15-11-06_9.txt
[INFO   ] [Kivy        ] v1.9.0
[INFO   ] [Python      ] v3.5.0+ (default, Oct 11 2015, 09:05:38)
[GCC 5.2.1 20151010]
[INFO   ] [Factory     ] 173 symbols loaded
[INFO   ] [Image       ] Providers: img_tex, img_dds, img_gif, img_sdl2, img_pil (img_ffpyplayer ignored)
[INFO   ] [Text        ] Provider: sdl2
[INFO   ] [OSC         ] using <multiprocessing> for socket
[INFO   ] [Window      ] Provider: sdl2(['window_egl_rpi'] ignored)
[CRITICAL] [Window      ] Unable to find any valuable Window provider at all!
egl_rpi - ImportError: cannot import name 'bcm'
  File "/usr/lib/python3/dist-packages/kivy/core/__init__.py", line 57, in core_select_lib    fromlist=[modulename], level=0)
  File "/usr/lib/python3/dist-packages/kivy/core/window/window_egl_rpi.py", line 12, in <module>
    from kivy.lib.vidcore_lite import bcm, egl

sdl2 - TypeError: expected bytes, str found
  File "/usr/lib/python3/dist-packages/kivy/core/__init__.py", line 65, in core_select_lib
    cls = cls()
  File "/usr/lib/python3/dist-packages/kivy/core/window/window_sdl2.py", line 121, in __init__
    super(WindowSDL, self).__init__()
  File "/usr/lib/python3/dist-packages/kivy/core/window/__init__.py", line 616, in __init__
    self.create_window()
  File "/usr/lib/python3/dist-packages/kivy/core/window/window_sdl2.py", line 171, in create_window
    self.fullscreen, resizable, state)
  File "kivy/core/window/_window_sdl2.pyx", line 60, in kivy.core.window._window_sdl2._WindowSDL2Storage.setup_window (kivy/core/window/_window_sdl2.c:1379)

x11 - ImportError: No module named 'kivy.core.window.window_x11'
  File "/usr/lib/python3/dist-packages/kivy/core/__init__.py", line 57, in core_select_lib
    fromlist=[modulename], level=0)

[CRITICAL] [App         ] Unable to get a Window, abort.
 Exception ignored in: 'kivy.properties.dpi2px'
 Traceback (most recent call last):
   File "/usr/lib/python3/dist-packages/kivy/utils.py", line 360, in __get__
     retval = self.func(inst)
   File "/usr/lib/python3/dist-packages/kivy/metrics.py", line 169, in dpi
     EventLoop.ensure_window()
   File "/usr/lib/python3/dist-packages/kivy/base.py", line 126, in ensure_window
     sys.exit(1)
 SystemExit: 1
[CRITICAL] [App         ] Unable to get a Window, abort.

helloWorld.py content:
from kivy.app import App
from kivy.uix.button import Button

class TestApp(App):
    def build(self):
        return Button(text='Hello World')

TestApp().run()

I can't run Kivy 1.9 with neither Python 3.4 nor 3.5. (Installed via sudo apt-get install python3-kivy)

ImportError: No module named 'kivy.uix.behaviors'

@CreamyCookie, have you also installed all these deps? http://kivy.org/docs/installation/installation-linux.html#ubuntu-example

Reinstall kivy after ensuring that they are present.

@dessant No, but I thought this wasn't necessary, because it's in the "Installation in a Virtual Environment" part, and I installed via sudo apt-get install python3-kivy.
But if I try to install these, this is what I get: (I'm on Ubuntu 15.10)
Some packages could not be installed. This may mean that you have
requested an impossible situation or if you are using the unstable
distribution that some required packages have not yet been created
or been moved out of Incoming.
The following information may help to resolve the situation:

The following packages have unmet dependencies:
 libavcodec-dev : Depends: libavcodec-ffmpeg56 (= 7:2.7.2-1build1) but it is not going to be installed
E: Unable to correct problems, you have held broken packages.

@thopiekar pingly

Stable or daily PPA?

Can confirm this on daily PPA. Affects all python* versions. kivy.uix.behaviors seems to be a new module in kivy (sorry for not being up-to-date).
Will fix that shortly!

For those who are interested: The failing buildlog at launchpad says everything:
dh_install: usr/lib/python2.7/dist-packages/kivy/uix/behaviors/drag.py exists in debian/tmp but is not installed to anywhere
dh_install: usr/lib/python2.7/dist-packages/kivy/uix/behaviors/togglebutton.py exists in debian/tmp but is not installed to anywhere
dh_install: usr/lib/python2.7/dist-packages/kivy/uix/behaviors/drag.pyc exists in debian/tmp but is not installed to anywhere
dh_install: usr/lib/python2.7/dist-packages/kivy/uix/behaviors/__init__.pyc exists in debian/tmp but is not installed to anywhere
dh_install: usr/lib/python2.7/dist-packages/kivy/uix/behaviors/focus.pyc exists in debian/tmp but is not installed to anywhere
dh_install: usr/lib/python2.7/dist-packages/kivy/uix/behaviors/__init__.py exists in debian/tmp but is not installed to anywhere
dh_install: usr/lib/python2.7/dist-packages/kivy/uix/behaviors/codenavigation.pyc exists in debian/tmp but is not installed to anywhere
dh_install: usr/lib/python2.7/dist-packages/kivy/uix/behaviors/focus.py exists in debian/tmp but is not installed to anywhere
dh_install: usr/lib/python2.7/dist-packages/kivy/uix/behaviors/button.py exists in debian/tmp but is not installed to anywhere
dh_install: usr/lib/python2.7/dist-packages/kivy/uix/behaviors/togglebutton.pyc exists in debian/tmp but is not installed to anywhere
dh_install: usr/lib/python2.7/dist-packages/kivy/uix/behaviors/codenavigation.py exists in debian/tmp but is not installed to anywhere
dh_install: usr/lib/python2.7/dist-packages/kivy/uix/behaviors/compoundselection.pyc exists in debian/tmp but is not installed to anywhere
dh_install: usr/lib/python2.7/dist-packages/kivy/uix/behaviors/button.pyc exists in debian/tmp but is not installed to anywhere
dh_install: usr/lib/python2.7/dist-packages/kivy/uix/behaviors/compoundselection.py exists in debian/tmp but is not installed to anywhere
dh_install: usr/lib/python3/dist-packages/kivy/uix/behaviors/drag.py exists in debian/tmp but is not installed to anywhere
dh_install: usr/lib/python3/dist-packages/kivy/uix/behaviors/togglebutton.py exists in debian/tmp but is not installed to anywhere
dh_install: usr/lib/python3/dist-packages/kivy/uix/behaviors/__init__.py exists in debian/tmp but is not installed to anywhere
dh_install: usr/lib/python3/dist-packages/kivy/uix/behaviors/focus.py exists in debian/tmp but is not installed to anywhere
dh_install: usr/lib/python3/dist-packages/kivy/uix/behaviors/button.py exists in debian/tmp but is not installed to anywhere
dh_install: usr/lib/python3/dist-packages/kivy/uix/behaviors/codenavigation.py exists in debian/tmp but is not installed to anywhere
dh_install: usr/lib/python3/dist-packages/kivy/uix/behaviors/compoundselection.py exists in debian/tmp but is not installed to anywhere
dh_install: usr/lib/python3/dist-packages/kivy/uix/behaviors/__pycache__/compoundselection.cpython-35.pyc exists in debian/tmp but is not installed to anywhere
dh_install: usr/lib/python3/dist-packages/kivy/uix/behaviors/__pycache__/focus.cpython-35.pyc exists in debian/tmp but is not installed to anywhere
dh_install: usr/lib/python3/dist-packages/kivy/uix/behaviors/__pycache__/__init__.cpython-34.pyc exists in debian/tmp but is not installed to anywhere
dh_install: usr/lib/python3/dist-packages/kivy/uix/behaviors/__pycache__/__init__.cpython-35.pyc exists in debian/tmp but is not installed to anywhere
dh_install: usr/lib/python3/dist-packages/kivy/uix/behaviors/__pycache__/togglebutton.cpython-34.pyc exists in debian/tmp but is not installed to anywhere
dh_install: usr/lib/python3/dist-packages/kivy/uix/behaviors/__pycache__/drag.cpython-35.pyc exists in debian/tmp but is not installed to anywhere
dh_install: usr/lib/python3/dist-packages/kivy/uix/behaviors/__pycache__/codenavigation.cpython-35.pyc exists in debian/tmp but is not installed to anywhere
dh_install: usr/lib/python3/dist-packages/kivy/uix/behaviors/__pycache__/codenavigation.cpython-34.pyc exists in debian/tmp but is not installed to anywhere
dh_install: usr/lib/python3/dist-packages/kivy/uix/behaviors/__pycache__/drag.cpython-34.pyc exists in debian/tmp but is not installed to anywhere
dh_install: usr/lib/python3/dist-packages/kivy/uix/behaviors/__pycache__/compoundselection.cpython-34.pyc exists in debian/tmp but is not installed to anywhere
dh_install: usr/lib/python3/dist-packages/kivy/uix/behaviors/__pycache__/togglebutton.cpython-35.pyc exists in debian/tmp but is not installed to anywhere
dh_install: usr/lib/python3/dist-packages/kivy/uix/behaviors/__pycache__/button.cpython-35.pyc exists in debian/tmp but is not installed to anywhere
dh_install: usr/lib/python3/dist-packages/kivy/uix/behaviors/__pycache__/focus.cpython-34.pyc exists in debian/tmp but is not installed to anywhere
dh_install: usr/lib/python3/dist-packages/kivy/uix/behaviors/__pycache__/button.cpython-34.pyc exists in debian/tmp but is not installed to anywhere

The only reason why we have packages not finding the uix.behaviours is that the changes, which use this new module were uploaded before adding uix.behaviours itself ^^

Stable.

Will fix that shortly!

Nice! And btw. thanks for your great work, kivy developers! :+1:

Was the original issue here ever addressed?

@inclement it was, closing.

I still have the issue with python 3.5 in ubuntu 17.04:
(kivyinstall) john@john-P37V6:~$ python3 -c "import kivy"
[WARNING] [Config      ] Older configuration version detected (14 instead of 19)
[WARNING] [Config      ] Upgrading configuration in progress.
[INFO   ] [Logger      ] Record log in /home/john/.kivy/logs/kivy_17-09-01_11.txt
[INFO   ] [Kivy        ] v1.10.0
[INFO   ] [Python      ] v3.5.3 |Anaconda custom (64-bit)| (default, Mar  6 2017, 11:58:13)
[GCC 4.4.7 20120313 (Red Hat 4.4.7-1)]
errors:INFO   ] [Logger      ] Record log in /home/john/.kivy/logs/kivy_17-09-01_9.txt
[INFO   ] [Kivy        ] v1.10.0
[INFO   ] [Python      ] v3.5.3 |Anaconda custom (64-bit)| (default, Mar  6 2017, 11:58:13)
[GCC 4.4.7 20120313 (Red Hat 4.4.7-1)]
[INFO   ] [Factory     ] 194 symbols loaded
[INFO   ] [Image       ] Providers: img_tex, img_dds, img_pil, img_gif (img_sdl2, img_ffpyplayer ignored)
[INFO   ] [Text        ] Provider: pil(['text_sdl2'] ignored)
[CRITICAL] [Window      ] Unable to find any valuable Window provider.
egl_rpi - ImportError: cannot import name 'bcm'
File "/home/john/anaconda3/lib/python3.5/site-packages/kivy/core/init.py", line 59, in core_select_lib
fromlist=[modulename], level=0)
File "/home/john/anaconda3/lib/python3.5/site-packages/kivy/core/window/window_egl_rpi.py", line 12, in
from kivy.lib.vidcore_lite import bcm, egl
sdl2 - ImportError: /home/john/anaconda3/lib/python3.5/site-packages/numexpr/../../../libstdc++.so.6: version `CXXABI_1.3.9' not found (required by /usr/lib/x86_64-linux-gnu/libmodplug.so.1)
File "/home/john/anaconda3/lib/python3.5/site-packages/kivy/core/init.py", line 59, in core_select_lib
fromlist=[modulename], level=0)
File "/home/john/anaconda3/lib/python3.5/site-packages/kivy/core/window/window_sdl2.py", line 26, in
from kivy.core.window._window_sdl2 import _WindowSDL2Storage
x11 - ImportError: No module named 'kivy.core.window.window_x11'
File "/home/john/anaconda3/lib/python3.5/site-packages/kivy/core/init.py", line 59, in core_select_lib
fromlist=[modulename], level=0)
[CRITICAL] [App         ] Unable to get a Window, abort.

I too still have this issue in python3.5 in Ubuntu 16.04. it works fine using python2.7
Error code:
´´´
[CRITICAL] [Window      ] Unable to find any valuable Window provider at all!
egl_rpi - ImportError: cannot import name 'bcm'
File "/usr/lib/python3/dist-packages/kivy/core/init.py", line 57, in core_select_lib
fromlist=[modulename], level=0)
File "/usr/lib/python3/dist-packages/kivy/core/window/window_egl_rpi.py", line 12, in
from kivy.lib.vidcore_lite import bcm, egl
sdl2 - TypeError: expected bytes, str found
File "/usr/lib/python3/dist-packages/kivy/core/init.py", line 65, in core_select_lib
cls = cls()
File "/usr/lib/python3/dist-packages/kivy/core/window/window_sdl2.py", line 121, in init
super(WindowSDL, self).init()
File "/usr/lib/python3/dist-packages/kivy/core/window/init.py", line 616, in init
self.create_window()
File "/usr/lib/python3/dist-packages/kivy/core/window/window_sdl2.py", line 171, in create_window
self.fullscreen, resizable, state)
File "kivy/core/window/_window_sdl2.pyx", line 60, in kivy.core.window._window_sdl2._WindowSDL2Storage.setup_window (kivy/core/window/_window_sdl2.c:1447)
x11 - ImportError: No module named 'kivy.core.window.window_x11'
File "/usr/lib/python3/dist-packages/kivy/core/init.py", line 57, in core_select_lib
fromlist=[modulename], level=0)
[CRITICAL] [App         ] Unable to get a Window, abort.
Exception ignored in: 'kivy.properties.dpi2px'
Traceback (most recent call last):
File "/usr/lib/python3/dist-packages/kivy/utils.py", line 360, in get
retval = self.func(inst)
File "/usr/lib/python3/dist-packages/kivy/metrics.py", line 169, in dpi
EventLoop.ensure_window()
File "/usr/lib/python3/dist-packages/kivy/base.py", line 126, in ensure_window
sys.exit(1)
SystemExit: 1
[CRITICAL] [App         ] Unable to get a Window, abort.
´´´

@IQYottabit, you're using an older version, try Kivy 1.10.0. If you are able to reproduce the bug with the latest release, open a new issue with the required details.

Thanks, that solved the issue. I update the Kivy 1.10.0 now.


Fix Pipfile and add .env file

We're not using flask anymore so flask as a dependency should be removed.
Furthermore .env file should be present

Issue resolved


Single header implementation define

Have a RLIBRETRO_IMPLEMENTATION which would...
Generates the implementation of the library into the included file. If not defined, the library is in header only mode and can be included in other headers or source files without problems. But only ONE file should hold the implementation.

I think this would impact

/**
 * The global libretro core object.
 */
rLibretro LibretroCore = {0};

This won't work, since it needs a few libs from libretro.


Follow webpacker standar paths

Hi, nice gem.
just for consistency, It may be a good idea to follow the webpack standar paths and names.
Thanks

Hi @ngelx,
it's a nice idea. I should update the next release to follow the webpacker standard paths for the initializer and the engine webapcker generators.


[TECH ED] Play Can't Unsee

Link to the coursework
https://cantunsee.space/
Why are we doing this?
To make a professional looking website, you must attend to all the small details. Play this fun game to sharpen your eye for the professional polish that will set your portfolio apart.
Maximum time in hours
.5
How to get help
Play it again!

Kamino closed and cloned this issue to sairaheta1/My-Coursework-Planner-test


non recoverable error on game load

Problem Description
The mod Factory Planner (2.0.16) caused a non-recoverable error.
Please report this error to the mod author.
Error while running event factoryplanner::on_configuration_changed
factoryplanner/backend/migrations/migration_2_0_16.lua:15: table index is nil
stack traceback:
factoryplanner/backend/migrations/migration_2_0_16.lua:15: in function 'migration_function'
factoryplanner/backend/handlers/migrator.lua:67: in function 'apply_migrations'
factoryplanner/backend/handlers/migrator.lua:105: in function 'migrate_player_tables'
factoryplanner/backend/init.lua:240: in function <factoryplanner/backend/init.lua:229>
Reproduction
from factorio-current:
Error while running event factoryplanner::on_configuration_changed
factoryplanner/backend/migrations/migration_2_0_16.lua:15: table index is nil
stack traceback:
factoryplanner/backend/migrations/migration_2_0_16.lua:15: in function 'migration_function'
factoryplanner/backend/handlers/migrator.lua:67: in function 'apply_migrations'
factoryplanner/backend/handlers/migrator.lua:105: in function 'migrate_player_tables'
factoryplanner/backend/init.lua:240: in function <factoryplanner/backend/init.lua:229>
49.874 Info IDWithQuality.cpp:304: fixing missing qualityID for id rail
49.874 Info Blueprint.cpp:52: when loading blueprint ""
49.874 Info SimulationWidget.cpp:34: save base/menu-simulations/menu-simulation-train-junction.zip
49.874 Info IDWithQuality.cpp:304: fixing missing qualityID for id rail-ramp
49.874 Info Blueprint.cpp:52: when loading blueprint ""
49.874 Info SimulationWidget.cpp:34: save base/menu-simulations/menu-simulation-train-junction.zip
59.973 Info IDWithQuality.cpp:304: fixing missing qualityID for id signal-blue
59.973 Info Blueprint.cpp:52: when loading blueprint "ALL"
59.973 Info SimulationWidget.cpp:34: save base/menu-simulations/menu-simulation-artillery.zip
59.973 Info IDWithQuality.cpp:304: fixing missing qualityID for id signal-F
59.973 Info Blueprint.cpp:52: when loading blueprint "Factorio"
59.973 Info SimulationWidget.cpp:34: save base/menu-simulations/menu-simulation-artillery.zip
59.973 Info IDWithQuality.cpp:304: fixing missing qualityID for id signal-W
59.973 Info Blueprint.cpp:52: when loading blueprint "Wube"
59.973 Info SimulationWidget.cpp:34: save base/menu-simulations/menu-simulation-artillery.zip
59.974 Info IDWithQuality.cpp:304: fixing missing qualityID for id rail
59.974 Info Blueprint.cpp:52: when loading blueprint ""
59.974 Info SimulationWidget.cpp:34: save base/menu-simulations/menu-simulation-artillery.zip
59.974 Info IDWithQuality.cpp:304: fixing missing qualityID for id rail-ramp
59.974 Info Blueprint.cpp:52: when loading blueprint ""
59.974 Info SimulationWidget.cpp:34: save base/menu-simulations/menu-simulation-artillery.zip

Thanks for the report. Not sure how that part of the code can crash, but I put a mitigation in place for the next release.


[transwarp] add a new port

Describe the pull request

What does your PR fix?
Add a new port called transwarp, a header-only C++ library for task concurrency
Related transwarp issue:
https://github.com/bloomen/transwarp/issues/26

Which triplets are supported/not supported?

Yes

Hi there,
I find there is one check failed, saying file's SHA on x86_windows's is incorrect.
Error: While reading versions for port transwarp from file: C:\a\1\s\versions\t-\transwarp.json
       File declares version `2.2.2` with SHA: a21d15430c4c31ab2e8f597191578b33862ff234
       But local port with the same verion has a different SHA: 532341b073fc648d89f9430488535076bbe34e05
       Please update the port's version fields and then run:
vcpkg x-add-version transwarp

I did run ./vcpkg x-add-version --all before submitting the PR, do I still need to run vcpkg x-add-version transwarp for it?

LGTM, thanks for the PR!


2.0 Catalog issues

Rancher versions: 2.0 master 12/12
Results:

[ ] Add catalog, the title names for the fields are different colors and sizes.

[ ] Add catalog, spacing between fields needs to be consistent

[x] Add catalog, no fields are required.  Name and URL should probably be required fields.

[x] Catalog Apps - no change event, so after adding catalog I have to hit refresh to see templates

[x] Search in Custom is taking UUID into account even if you can't see it.  I put in f in search and it returned all catalogs even thou none of them have an f anywhere in them.

Version - 2.0 master 3/1
All Catalog bugs will be entered in new issue.


Handle require payment method error on confirmSetupIntent on android

Summary
Handle RequiresPaymentMethod error from confirmSetupIntent so that error information matches iOS implementation
Motivation
Whilst testing our switch from tipsi-stripe to this package, I noticed a difference in the error's returned from confirmSetupIntent on iOS vs Android. If a card is declined the error is now available on android and iOS for display to the user. Previous to this PR - instead of the actual error android returned unhandled error: requires payment method
Testing

[x] I tested this manually
[ ] I added automated tests

Documentation
Select one:

[ ] I have added relevant documentation for my changes.
[x] This PR does not result in any developer-facing changes.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.wijskinner seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.

Good catch and change! letting e2e tests run before merging

@charliecruzan-stripe Anything else need to be done here? Would really appreciate getting this out in a release as soon as possible?

sorry @wijskinner , this passed e2e and completely slipped my mind! I overhauled our setup-intent handling logic as part of https://github.com/stripe/stripe-react-native/pull/879/files#diff-f694d33641390cc6897469c6942c0cefda04833cff587e7d337ae0403d7f2b5eR81-R120, so this will actually be addressed in there. We plan on releasing that linked PR in a week or so, does that work?

No probs at all @charliecruzan-stripe. Yep your new setup-intent handling looks fine so will happily wait for that. Thanks for the quick response. I'll close this PR.


[QUERY] How to set the visibility timeout  and checkpoint mode on StorageQueueTemplate?

Query/Question
Earlier up to version 2.14.0 of the spring integration library for Azure Storage Queue, the StorageQueueMessageSource used to take a StorageQueueOperation object.  This was replaced by StorageQueueTemplate in version 4.0.0
The earlier StorageQueueOperation object allowed us to set the checkpoint mode and visibility timeout
These setters are missing in StorageQueueTemplate object
How do I set these values when working with StorageQueueTemplate?
Also the StorageQueueMessageSource seems to always all the underlying StorageQueueTemplate with a visibilityTimeout that is set to null!
Why is this not a Bug or a feature Request?
At this point this is just a question.  Depending on the response, this may be followed up with a feature request.
Setup (please complete the following information if applicable):

OS: Not relevant
IDE: Not relevant
Sample Path: https://github.com/Azure-Samples/azure-spring-boot-samples/tree/spring-cloud-azure_4.2.0/storage/spring-cloud-azure-starter-integration-storage-queue/storage-queue-integration
Library/Libraries: com.azure.spring:spring-integration-azure-storage-queue:4.0.0  (and 4.1.0  and 4.2.0)

Information Checklist

[x] Query Added
[x] Setup information Added

Hi @soumabrata-chakraborty thanks for reaching us. There is the breaking changes about the visibility timeout and checkpoint mode for StorageQueueTemplate compared with StorageQueueOperation.
For visibility timeout, now we don't provide any API to set a default visibility timeout for the template object, while when using the StorageQueueTemplate directly you can call the StorageQueueTemplate#receiveAsync to specify the timeout value. while for using StorageQueueMessageSource, then we don't support to specify it.
For checkpoint mode, we removed this conception in StorageQueueTemplate, and developers have to manually checkpoint messages now. This is because for the previous RECORD mode, messages will be checkpointed before they have been truly consumed by the customer handling code.

Hi @yiliuTo - thanks for response.  This breaking changes introduces missing functionality for usage with spring integration.
I understand the change for the Checkpoint mode being MANUAL.  This was the recommended approach for spring integration earlier too.
However, not being able to specify visibility timeout in StorageQueueMessageSource is an issue.
I am using StorageQueueMessageSource with @InboundChannelAdapter in Spring Integration.
I have multiple instances of my application deployed in Production, and each instance listens to the same queue.
It takes my integration flow about 3 minutes to process a message.
If the StorageQueueMessageSource does not support visibility timeout - then it becomes 30 seconds default I think -- so I cannot prevent different instances of my spring integration app from picking up the same message from the queue.
The only option left to me would be to extend StorageQueueMessageSource and introduce a configurable visibility timeout in it - but perhaps its better to change the azure project code and add this functionality with a default of 30 seconds if not configured by user.
If you think this feature makes sense - I am happy to contribute this back to the azure project.

Hi @soumabrata-chakraborty your request fully makes sense to us. And the reason why we decided to remove the option of visibility timeout from StorageQueueTemplate is that, we think this property is related with each message instead of the whole StorageQueueTemplate, thus we don't think StorageQueueTemplate should hold a member of visibilty timeout.
Also your contribution is always welcome, and we would like to know whether you have other ideas rather than adding a member for StorageQueueTemplate?

Please refer https://github.com/Azure/azure-sdk-for-java/issues/29566

Hi @soumabrata-chakraborty  the pr has been merged and you can look forward to our next release which is expected to be published in this month.


Fix compose for Ian

Which issue does this PR close?
Closes #267.
Rationale for this change
Described in issue.
What changes are included in this PR?
Several docker-compose fixes.
Are there any user-facing changes?
This will break for ubuntu:20.04 users unless they sudo snap install docker @andygrove

@avantgardnerio Really thanks!


CI: sync changes from votca/votca

I just want to test both.
On a single full compile ninja isn't much faster, but it is usually faster for incremental builds.


errorMessages aren't displayed when exiting with error

It would be helpful to display the content of the errorMessages field when exiting with error. Optionally, including the response body in debug output might also be helpful.

see #9 to display the jira error messages when ticket creation fails.


Double appmenu in desktop environments that don't show appmenus

Reticketed from https://github.com/tiliado/nuvolaplayer/issues/193#issuecomment-168243101:
I have now double options:

Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

Fixed in master.
Before:

After:


h5 file

h5.create_dataset('images', (size, in_channels, *img_size))
Can you elaborate this statement, specially '*img_size' whats mean?

is for unpacking a tuple, please read about splat operator


@sanjaygunda13 I never tried the processing in Base64, maybe you need to try to decode the Byte64 into PIL format first.

@sanjaygunda13 I never tried the processing in Base64, maybe you need to try to decode the Byte64 into PIL format first.
Originally posted by @vinson2233 in https://github.com/openai/CLIP/issues/83#issuecomment-1186712343
thanks for the update now i am able to train the clip but not able to load the saved model getting serialization error i am not sure what mistake i have made. let me know if you have any leads on below error.
untimeError                              Traceback (most recent call last)
Input In [8], in <cell line: 7>()
2 # model, preprocess = clip.load("ViT-B/32", device=device, jit=False)
6 model, preprocess = clip.load("ViT-B/32",device=device,jit=False) #Must set jit=False for training
----> 7 checkpoint = torch.load("/home/sanjay/model_data/model_10.pt")
9 # # Use these 3 lines if you use default model setting(not training setting) of the clip. For example, if you set context_length to 100 since your string is very long during training, then assign 100 to checkpoint['model_state_dict']["context_length"]
10 # checkpoint['model_state_dict']["input_resolution"] = model.input_resolution #default is 224
11 # checkpoint['model_state_dict']["context_length"] = model.context_length # default is 77
12 # checkpoint['model_state_dict']["vocab_size"] = model.vocab_size
14 model.load_state_dict(checkpoint['model_state_dict'])
File ~/.conda/envs/clip_prefix_caption/lib/python3.9/site-packages/torch/serialization.py:594, in load(f, map_location, pickle_module, **pickle_load_args)
592             opened_file.seek(orig_position)
593             return torch.jit.load(opened_file)
--> 594         return _load(opened_zipfile, map_location, pickle_module, **pickle_load_args)
595 return _legacy_load(opened_file, map_location, pickle_module, **pickle_load_args)
File ~/.conda/envs/clip_prefix_caption/lib/python3.9/site-packages/torch/serialization.py:853, in _load(zip_file, map_location, pickle_module, pickle_file, **pickle_load_args)
851 unpickler = pickle_module.Unpickler(data_file, **pickle_load_args)
852 unpickler.persistent_load = persistent_load
--> 853 result = unpickler.load()
855 torch._utils._validate_loaded_sparse_tensors()
857 return result
File ~/.conda/envs/clip_prefix_caption/lib/python3.9/site-packages/torch/serialization.py:845, in _load..persistent_load(saved_id)
843 data_type, key, location, size = data
844 if key not in loaded_storages:
--> 845     load_tensor(data_type, size, key, _maybe_decode_ascii(location))
846 storage = loaded_storages[key]
847 return storage
File ~/.conda/envs/clip_prefix_caption/lib/python3.9/site-packages/torch/serialization.py:834, in _load..load_tensor(data_type, size, key, location)
831 dtype = data_type(0).dtype
833 storage = zip_file.get_storage_from_record(name, size, dtype).storage()
--> 834 loaded_storages[key] = restore_location(storage, location)
File ~/.conda/envs/clip_prefix_caption/lib/python3.9/site-packages/torch/serialization.py:175, in default_restore_location(storage, location)
173 def default_restore_location(storage, location):
174     for _, _, fn in _package_registry:
--> 175         result = fn(storage, location)
176         if result is not None:
177             return result
File ~/.conda/envs/clip_prefix_caption/lib/python3.9/site-packages/torch/serialization.py:157, in _cuda_deserialize(obj, location)
155         return storage_type(obj.size())
156 else:
--> 157     return obj.cuda(device)
File ~/.conda/envs/clip_prefix_caption/lib/python3.9/site-packages/torch/_utils.py:79, in cuda(self, device, non_blocking, **kwargs)
77 else:
78     new_type = getattr(torch.cuda, self.class.name)
---> 79     return new_type(self.size()).copy(self, non_blocking)
File ~/.conda/envs/clip_prefix_caption/lib/python3.9/site-packages/torch/cuda/init.py:462, in _lazy_new(cls, *args, **kwargs)
459 _lazy_init()
460 # We may need to call lazy init again if we are a forked child
461 # del _CudaBase.new
--> 462 return super(_CudaBase, cls).new(cls, *args, **kwargs)
RuntimeError: CUDA out of memory. Tried to allocate 20.00 MiB (GPU 0; 15.90 GiB total capacity; 1.39 GiB already allocated; 10.75 MiB free; 1.47 GiB reserved in total by PyTorch)

pytorch is really memory sensitive. make sure your CUDA memory is not occupied. use nvidia-smi command in the terminal to see GPU memory usage


Discussion: Bash-it Alias/Plugin/Completion Load Priority

Work in Progress
Sorry for the long post...
The work on this feature can be tracked in the load-priority branch in my Bash-it fork for the first part, and the enabled-global branch for the second half. I will create a pull request on the main Bash-it repo once the implementation has been completed (see #974 for the first half and #1043 for the second half).
Please feel free to provide comments on this feature - especially @tswicegood, @edubxb, @revans and @thedrow. Others are of course welcome, too.
Problem Statement
One recurring problem (see #688 and #841 for examples) has been that Bash-it loads its components in a predefined order and does not allow to define dependencies between the components.
The fixed order for loading the components is

aliases
plugins
completions

This leads to the following problems, with two different flavors:

Within the same kind (e.g. plugins), load order is determined by alphabetical order, which means that the node plugin is loaded before the nvm plugin. When using nvm to install and run Node.js, nvm needs to be loaded first to make the node command available. With the current load order of Bash-it, this is not possible.
Dependencies between different kinds of components do not work. One example is the alias-completion plugin, which tries to enable shell completions for aliases. Since plugins are loaded before completions, the plugin does not find any completions that it could apply to the defined aliases. The current fix for this is to either move the plugin to the custom folder, or to run reload after Bash-it has loaded.

There are probably more examples than these two.
Solution Approach
The approach described here tries to address the two main problems described above.
Load Order
(Implemented in #974)
To address the problem with a load order that's not purely based on the component's name, we are going to introduce a numeric value that determines the order in which the files are loaded.
With the current approach, the component (e.g. the nvm plugin) is linked into the plugins/enabled folder as nvm.plugin.bash. To break up the dependency on the plugin name for load order, a three digit numeric value will be introduced when creating the link, e.g 250---nvm.plugin.bash.
Using a format like this for the link will allow to tailor the order of loading the files since the order will be based on the numeric value instead of the name, and the three dashes will allow to parse the name, separating the number from the name of the plugin.
By default, each type of component will have a default priority, preventing us from having to update all of the files:

Aliases: 150
Plugins: 250
Completions: 350

These values allow for adjusting individual components up or down. To specify a different load priority for a component, we will introduce an optional comment value in the component file, which allows to override the default priority:
# BASH_IT_LOAD_PRIORITY: 999

If this value is found in a component's file while enabling the component, it will be used instead of the default priority.
To implement this, the following areas of Bash-it have to be touched:

Enable Component will need to parse the component file and then create the link in the new format.
Show Components will need to parse the name of the links in the enabled folder to display which ones are enabled.
Disable Components will need to find the component to disable.

This solves the first problem by allowing to specify that the nvm plugin should be loaded before the node plugin:

The nvm plugin uses a custom priority, with a lower value than the default for plugins, e.g. 225.
The node plugin uses the default priority of 250.

If both are enabled, it will look like this:

225---nvm.plugin.bash
250---node.plugin.bash

One Common "Enabled" Directory
(Implemented in #1043)
The second problem of having a predefined order of the different component types (first aliases, then plugins, then completions), is caused by the fact that each of the components has their own enabled directory, which is then loaded in turn by the bash_it.sh script.
To break up this fixed order, we are going to introduce a common enabled directory that will replace the individual directories. It's going to be placed at $BASH_IT/enabled
Same as above the Enable, Show and Disable functionalities will have to be adjusted to make this work, using the common directory instead of the individual ones.
There should not be any naming conflicts, since the component files use an individual extension, e.g. .plugin.bash for plugins.
Backwards-Compatibility
To allow existing installations to work, the common enabled directory will be loaded before the current loop that loads aliases, plugins and completions. Existing installations that do not yet use the common directory will continue to work without any changes, while installations that already use the common directory will also work once all of the components have been migrated to the common directory.
Migration
We will add a bash-it migrate command that moves the symbolic links of the enabled components from the individual directories to the new common directory.
In addition to this, the migrate command will automatically run whenever the user enables a new component. This will ensure that existing installations will continue to work without changes, but once the user enables new functionality, the existing components will be migrated.
The migrate command will display a message to tell the user how many items were migrated to the new common enabled directory.
Tasks
I'm probably going to commit this a two separate Pull Requests, where the first one will introduce the load priority, but still use the individual directories, and then the second one will move everything into a common enabled directory.
Some of the tasks that I'm aware of - I'll try to provide unit tests where they make sense:
Load Order
(Implemented in #974)

[x] bash-it enable a single component
[x] bash-it enable all components
[x] bash-it disable a single component
[x] bash-it disable all components
[x] Install script (it uses its own enabling code)
[x] Completion needs to consider the new and the old syntax
[x] Add bash-it migrate command
[x] Automatically run bash-it migrate when enabling/disabling something
[x] Update help/documentation
[x] Fix usage of enabled directory in existing code, e.g. plugins and themes
[x] Merge code (#974)

One Common "Enabled" Directory
(Implemented in #1043)

[x] bash-it enable a single component
[x] bash-it enable all components
[x] bash-it disable a single component
[x] bash-it disable all components
[x] Install script (it uses its own enabling code)
[x] Completion needs to consider the new and the old location
[x] Update bash-it migrate command to move enabled components to the new common directory
[x] Automatically run bash-it migrate when enabling/disabling something
[x] Update help/documentation
[x] Update the bash_it.sh code to load the global enabled directory's content
[x] Move/refactor/test the command_exist function so that there is no hidden dependency from the main code on this function from the base plugin. (Fixes #1009)
[x] Merge code (#1043)

I'm probably going to commit this a two separate Pull Requests, where the first one will introduce the load priority, but still use the individual directories, and then the second one will move everything into a common enabled directory.
Some of the tasks that I'm aware of - I'll try to provide unit tests where they make sense:
Load Order

[ ] bash-it enable a single component
[ ] bash-it enable all components
[ ] bash-it disable a single component
[ ] bash-it disable all components
[ ] Install script (it uses its own enabling code)
[ ] Completion needs to consider the new and the old syntax
[ ] Add bash-it migrate command
[ ] Update help/documentation

One Common "Enabled" Directory

[ ] bash-it enable a single component
[ ] bash-it enable all components
[ ] bash-it disable a single component
[ ] bash-it disable all components
[ ] Install script (it uses its own enabling code)
[ ] Completion needs to consider the new and the old location
[ ] Update bash-it migrate command to move enabled components to the new common directory
[ ] Automatically run bash-it migrate when enabling something
[ ] Update help/documentation

Implemented the first part of this in #974 - please feel free to review...

Merged the first half of this in #974 - please feel free to give it a try.

Implemented the second half in #1043 - reviews welcome!

Closing since both parts have been merged in master now. Open a new issue if there are any issues, please.


Plugin support for popup/dialog windows with external URL or content. Window focus issue.

I confirm (by marking "x" in the [ ] below: [x]):

[x] This is not a troubleshooting question. Troubleshooting questions go here: https://docs.mattermost.com/install/troubleshooting.html.
[x] This doesn't reproduce on web browsers (such as in Chrome). If it does, issue reports go to the Mattermost Server repository.
[x] I have read contributing guidelines.

Show (focus on) already opened popup on url change. It's hard to understand what's going on when main app is in fullscreen and popup is in background.
Environment

Operating System: macOS
Mattermost Desktop App version: 5.2.2
Mattermost Server version: 7.5.1

Steps to reproduce

Plugin (right panel in our case) opens some url. Popup gets focus.
Go back to main app. Popup is in background
Plugin opens another url. Some intentional user action like user clicked another button.

Expected behavior
Popup gets focus.
Observed behavior
Popup is in background.
Possible fixes
Change line
https://github.com/mattermost/desktop/blob/master/src/main/views/webContentEvents.ts#L195
From
this.popupWindow.once('ready-to-show', () => {
to
this.popupWindow.on('ready-to-show', () => {

@catz Can you give an example where plugins should be doing this? The current behaviour of the Desktop App is to not open another popup (or a plugin URL in the same popup window) so I can't see where this would be happening.

Hello Devin,
I will try to explain.

User opens the right panel and clicks info on some event

MM opens new BrowserWindow

User returns to main MM window. MM main window becomes on top of child window.
User clicks on another event.
Child's window content gets updated but the child window itself stays behind the main MM window. It doesn't receive focus because 'ready-to-show' event happens only once.

Can't say it's a big issue but imho fix seems very trivial.

@catz Which plugin are you using here?

@devinbinnie this is our own (work in progress) plugin.


Access to robot's position/accelerometer

Hi,
Is it possible to access the robot's position or accelerometer? I own the D5 Connected and it somehow manages to navigate back to the charging base. There has to be some navigation data that I can access, correct?
It would open the doors for great apps, such as drawing the area it's been in, ability to click on a position on the map to tell the robot to spot clean, etc.
On a side note, is there any specific reason why the coverage map is not available on the D5 Connected if it has all the same navigation features and sensors?
Poking @ostinelli
Thanks.

The cloud API do not allow to access low-level API such as accelerometers and navigation data. We are working to extend those functionalities and will keep your suggestions in mind. Thank you!

Do you have any update on this?


Fixed null given to fread

Hey, thanks for the patch.
But I was wondering if you have ever seen this condition occur? There are only four places in the codebase that write to $this->socket, and I'd be interested to know which was passing an invalid socket resource. (It'd be even better to have a test, of course, but I can write that if you can point me in the right direction to reproduce the failure).
What I mean is that, PHP does this on fread with an invalid socket:
$ php <<< '<?php var_dump(fread(false, 100));'

Warning: fread() expects parameter 1 to be resource, boolean given in - on line 1

Call Stack:
    0.0001     231416   1. {main}() -:0
    0.0001     231560   2. fread() -:1

bool(false)

The fact that it returns false for this case (and other falsey values I checked like null, []) means the contents of this if branch you're adding will never be hit, right?
Double-check my thinking on that, and if you can come up with some situation where it would be, I'll merge this. As it is, I can put exit(1) inside the if branch, and the test suite still passes! (Just indicates it doesn't occur with our admittedly low-coverage test suite, but still.)

Aha! I gotcha now! :D

Fixed my Fix :)
Had this in some rare cases where PHP runs in CLI, forked itself to background and runs for some days. Maybe it has to do with port-overflow or something like that. Seem to be really low level but i think as it is now it cannot harm anything while still beeing on the safe side.

Looks good now. Tweaked it to make sure ->connected was back to false.
Woo, thanks again. :tada:


DocBook plugin

works as a part of a compound build,
but doesn't when used by version (0.7.11).
Find out what is going on and add a test to the plugin.

Glitch? Works now...


Run as node user, not as root

This runs the process as user 'node', not as root.

Update: this may give problems accessing /var/run/docker.sock, needs more work.

@logentries, maybe add something in the README that describes the permissions problem here.

Please see https://github.com/logentries/docker-logentries/pull/43 for a fix


Modify uses-permission to solve duplication of SMS

Modify uses-permission to solve duplication of SMS

@coderFrankenstain thankyou, looks good.
I've approved this as it can't do any harm, even if it doesn't fix the problem; but can you explain how the lack of SEND_SMS & RECV_MMS permissions causes duplicates?

If you plan to perform any SMS/MMS-related tasks, you also need related permissions. Although the system obviously does not check these when determining eligible default application candidates, the following permissions are necessary for their corresponding operations
If you miss the SEND_SMS, READ_SMS or WRITE_SMS permission when trying to perform a given operation, a SecurityException will be thrown. However, if you lack the RECEIVE_MMS permission, your application will not be able to provide related broadcasts, and nothing seems to happen when testing these functions, but when inserting data into content://sms, it will not succeed. Return null

@coderFrankenstain thankyou, looks good.
I've approved this as it can't do any harm, even if it doesn't fix the problem; but can you explain how the lack of SEND_SMS & RECV_MMS permissions causes duplicates?

@coderFrankenstain thankyou, looks good.
I've approved this as it can't do any harm, even if it doesn't fix the problem; but can you explain how the lack of SEND_SMS & RECV_MMS permissions causes duplicates?

I was hoping for a drill-down, not an overview.
Let's start with "duplication" where exactly?
I assumed you were getting multiple copies of messages backed up into your mail folder; or do you mean multiple copies of restored messages? or something else instead?
Are these new finer-grained permissions whose allowed functions were previously enabled by some other permissions?
Otherwise what is your reasoning for adding those two permissions in particular?
Is there evidence that an exception is being thrown because of the lack of SEND_SMS, and that in turn somehow causes duplicates? If so, please walk me through the sequence of operations and highlight which one fails. (I would expect to need WRITE_SMS to be needed to restore SMSes, but not SEND_SMS. And neither to be required for backing up.)
What are "the related broadcasts" that are enabled by RECEIVE_MMS?
Have you tested the change in a live device? Or is this merely a hypothetical fix?
-Martin

I have tried many times, if my sms-backup does not have full SMS permissions (SEND_SMS, RECEIVE_SMS, READ_SMS, WRITE_SMS, RECEIVE_MMS), I cannot restore my SMS to the SMS application

Well that's worth fixing, so this is a useful PR.
But how is that causing "duplication of SMS"? Should I perhaps rename this PR, as it fixes a different problem (e.g. "restoration fails")?
This feels like a work-around for a buggy version of Android, so it would be helpful to get an idea of how many people are likely to be affected and/or will have their problem solved by this PR.

Which Android version are you using?
Which SMS app are you using? What version?

I think I have a problem with the wrong expression, duplication of SMS means that the text message writing to content://sms failed
my device is ZET9000N
android version ： 10
SMS app：System default SMS application

Update title to state the purpose of this patch (in this case, describe the fault that's fixed by it)


tester

Change Description

API Changes

[ ] API Changes

Documentation Additions

[ ] Documentation Additions

Can this PR be closed since tester is now in eos? https://github.com/EOSIO/eos/pull/9018


add react + genie demo/docs

related to https://github.com/kentcdodds/genie/issues/33

@all-contributors please add @sw-yx for docs

:tada: This PR is included in version 0.6.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


add github templates and bots

Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Codecov Report
Patch coverage has no change and project coverage change: -0.06 :warning:

Comparison is base (2c4475f) 79.14% compared to head (e16f865) 79.08%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #564      +/-   ##
==========================================
- Coverage   79.14%   79.08%   -0.06%
==========================================
  Files          25       25
  Lines        5489     5489
==========================================
- Hits         4344     4341       -3
- Misses       1145     1148       +3

see 2 files with indirect coverage changes
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Support multiple directories to bump the same package across dependency files

In https://github.com/web-platform-tests/wpt we track Python dependencies with a number of files named requirements_*.txt across directories, since the project is used in a number of different contexts (mostly browser engines like Chromium, Gecko and WebKit) where only a subset of the dependencies are needed.
We switched from pyup to Dependabot in https://github.com/web-platform-tests/wpt/pull/29161, and quickly found that Dependabot is creating separate pull requests for the same dependency across files, for example https://github.com/web-platform-tests/wpt/pull/29223 + https://github.com/web-platform-tests/wpt/pull/29227 or https://github.com/web-platform-tests/wpt/pull/29219 + https://github.com/web-platform-tests/wpt/pull/29224 + https://github.com/web-platform-tests/wpt/pull/29225.
We want those dependencies to stay in sync, so it would be much better if they were updated together. Unfortunately, there doesn't seem to be a way to specify multiple directories. This was the state of our config when the PRs were created:
https://github.com/web-platform-tests/wpt/blob/f44fd9953ebdbe8ef90ddf3bae8daaaa0173a92c/.github/dependabot.yml
Note that this is not the same request as https://github.com/dependabot/dependabot-core/issues/2178, wildcards would not  help us since there's no pattern that would match everything we want to update and still exclude all the things we don't want to touch (third party code).

Solving this is a more general way is a bit beyond dependabot's scope.  However, you should be able to solve this with a custom github workflow.  You would create an action that runs whenever a new PR is created by dependabot and it uses github-script to locate instances of the same dependency in other locations across your repo and then merges the changes from the new PR into the existing one and closes this new PR with a comment referring to the other PR.

This is a monorepo specific problem, so is tricky because some users want us to bump a dep across all apps/libraries in the monorepo, and others want us to only bump in one specific place at a time.
So if we added support for this, we'd need to ensure it was configurable. For now, I created the F: monorepo label so we can track the monorepo-related feedback together and added this to it.

Actually, this is a duplicate of:

https://github.com/dependabot/dependabot-core/issues/1595

So follow/upvote that for updates.


New package: RobotDojo v0.1.0

Registering package: RobotDojo
Repository: https://github.com/thowell/RobotDojo.jl
Created by: @thowell
Version: v0.1.0
Commit: a0675911793f85f28065471bc89678a193c42834
Reviewed by: @thowell
Reference: https://github.com/thowell/RobotDojo.jl/issues/1#issuecomment-967314993
Description: A differentiable simulator for robotic systems.

Superseded by #48713 I guess


[DOC] Documentation desperately needs a keyword index

Suppose I want to find the documentation on the "should" keyword.
In order to look that up, I need to notice that that's an option within the "bool" query.
That shouldn't be necessary.
I should be able to find it either by searching for "should" (which doesn't work) or by looking in the index for "should".
But there is no index. BTW, the search engine would presumably use the tag used to create the index entry to go directly to that page as well.

@kolchfa-aws: Can we transfer this to the project website?

There is already an issue for it in the project website https://github.com/opensearch-project/project-website-search/issues/43.


Strange static shared state in live services

Hi!
For example LiveAudioPlayerClient.swift contains static shared state which looks like an anti-pattern:
private var dependencies: [AnyHashable: AudioPlayerClientDelegate] = [:]

Maybe you should consider moving it to closure-captured memory of AudioPlayerClient methods (and all other services like that in this repository)
This will deallocate service state automatically when all instances of the service are deallocated.
Current implementation can push developers who use this example to adopt bad practice of static shared state for other usages, which can result in undetectable memory leaks.
extension AudioPlayerClient {
  static func makeLive() {
    var dependencies: [AnyHashable: AudioPlayerClientDelegate] = [:]
    return AudioPlayerClient(
      play: { id, url in
        .future { callback in
          do {
            let delegate = try AudioPlayerClientDelegate(
              url: url,
              didFinishPlaying: { flag in
                callback(.success(.didFinishPlaying(successfully: flag)))
                dependencies[id] = nil
              },
              decodeErrorDidOccur: { _ in
                callback(.failure(.decodeErrorDidOccur))
                dependencies[id] = nil
              }
            )

            delegate.player.play()
            dependencies[id] = delegate
          } catch {
            callback(.failure(.couldntCreateAudioPlayer))
          }
        }
      },
      stop: { id in
        .fireAndForget {
          dependencies[id]?.player.stop()
          dependencies[id] = nil
        }
      }
    )
  }
}

Hi @voidless, we're certainly open to updating the examples to push the dependencies into the closure, however your proposal and the current code technically work the same.
The value returned from your makeLive() function will live for the entire duration of the application, as you can see here. It is never deallocated, and so the locally scoped dependencies dictionary will not be deallocated, and that is expected. Environments should be created a single time and then propagated to all features via the pullback operation.
The current code does not have a memory leak because the way one deallocates the memory for AudioPlayerClientDelegate is to return the .stop(id:) effect from a reducer. That will deallocate and remove it from the dependencies dictionary.
We understand that having this global data hanging around can seem worrisome, but in practice it can be made reasonable. In fact, SwiftUI must be managing a ton of global data in the background in order to track which view struct values belong to which view being drawn on the screen, amongst other things its tracking.
We are definitely open to ways of reducing any indirection there is with the global data, but we do not think your current suggestion makes any headway in that direction.

Hi @voidless, we're certainly open to updating the examples to push the dependencies into the closure, however your proposal and the current code technically work the same.
The value returned from your makeLive() function will live for the entire duration of the application, as you can see here. It is never deallocated, and so the locally scoped dependencies dictionary will not be deallocated, and that is expected. Environments should be created a single time and then propagated to all features via the pullback operation.
The current code does not have a memory leak because the way one deallocates the memory for AudioPlayerClientDelegate is to return the .stop(id:) effect from a reducer. That will deallocate and remove it from the dependencies dictionary.
We understand that having this global data hanging around can seem worrisome, but in practice it can be made reasonable. In fact, SwiftUI must be managing a ton of global data in the background in order to track which view struct values belong to which view being drawn on the screen, amongst other things its tracking.
We are definitely open to ways of reducing any indirection there is with the global data, but we do not think your current suggestion makes any headway in that direction.


Fix config check after merge of prettier

The verifying of the config file doesnt need the eslint config file to run. SO remove it and jsut check the syntax and not the format. Fixes #2109

could we also get rid of the terrible throw  on approx line 66
			//throw new Error("Wrong syntax in config file!");

It is SO hard to find the actual error with all the noise.
without
><EMAIL_ADDRESS>config:check /home/sam/MagicMirror
> node js/check_config.js

[2020-08-07 17:09:13.924] [INFO]   Checking file...  /home/sam/MagicMirror/config/config.js
[2020-08-07 17:09:13.941] [LOG]    Line 32 col 2  Parsing error: Unexpected token logLevel

with
><EMAIL_ADDRESS>config:check /home/sam/MagicMirror
> node js/check_config.js

[2020-08-07 17:12:20.244] [INFO]   Checking file...  /home/sam/MagicMirror/config/config.js
[2020-08-07 17:12:20.260] [LOG]    Line 32 col 2 Parsing error: Unexpected token logLevel
/home/sam/MagicMirror/js/check_config.js:66
			throw new Error("Wrong syntax in config file!");
			^

Error: Wrong syntax in config file!
    at /home/sam/MagicMirror/js/check_config.js:66:10
    at FSReqWrap.readFileAfterClose [as oncomplete] (internal/fs/read_file_context.js:53:3)
npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR<EMAIL_ADDRESS>config:check: `node js/check_config.js`
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>config:check script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

npm ERR! A complete log of this run can be found in:
npm ERR!     /home/sam/.npm/_logs/2020-08-07T22_12_20_268Z-debug.log

it actually points to the THROW as the cause

Thanks for the input @sdetweil I cleaned up the code a little for some better readability

Thanks!.. so much better.. that will help users a lot..
wish the  linter fixed their error line number  to look back
unexpected token, is 99% probably prior line missing a trailing comma.. but new users don't know js syntax, so are lost..
ah well, one thing at a time..


Add man-db for doc packages

Instead of having users install a -doc package only to discover that man is not installed let's add man-db as a runtime dependency of any -doc package.

I'll leave it for @jonjohnsonjr and/or @xnox to review the SCA code.  But spiritually, I'm very aligned, and this makes perfectly reasonable sense to me.

This assumes that humans are supposed to use manpages by hand.
In general, most places where we build manpages today - is because the build breaks, unless one is building/installing manpages.
We typically don't patch any functionality that is different to upstream builds; and even when we do we often do not backport the matching manpage updates.
I wonder if there is any worth in building our own manpages at all.

If we are packaging the latest versions of upstream software, I think it is also valuable if we package the latest version of the project's documentation. If one searches the internet for the add user man page there are a variety of results and its not clear to me which search result is associated with the upstream project. Additionally, its not always obvious which version of the software the manual applies to which could lead to user confusion.

I think it is still worth building manpages.  But I think we should aggressively (and automatically) move documentation (including manpages and info pages and other forms of HTML docs) always and comprehensively into -docs packages, which are easy and obvious to find, if one needs them.  And those packages, when installed, yes, should drag in man-db.


Create xmtpd API service

tl;dr

Removes EFS mount support from the Fargate task definition module
Creates a new public module for deploying the xmtpd API service with load balancer and security group configurations

[!WARNING]
This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

#5
#4
#3  👈 (View in Graphite)
#2
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

I had this 90% done but got derailed by my networking issues... Oh well. Thanks for finishing it!

Merge activity

Nov 26, 4:22 PM PST: A user started a stack merge that includes this pull request via Graphite.


feat: optionally scope helmfile deps to specific releases

feat: optionally scope helmfile deps to specific releases
I'd like to have more control when updating helmfile.lock. Right now I can update all releases, no releases or do it manually.
use case
I have 20+ releases in a monitoring/observe namespace. Many large and complex charts like Prometheus and Jenkins. Running helmfile deps and updating everything at once is a huge amount of change. I'd like to update one or more at a time and move that change though our environments
examples
helmfile deps jenkins
helmfile deps elastic/elasticsearch
if I'm using some other repo
  - name: elastic
    url: https://helm.elastic.co

Thanks for the request!
I took some time to think about this and realized that this should be better done in the upstream first.
That is, I'd enhance helm dep up to accept a new flag for limiting which chart in the Chart.yaml(v3)/requiremens.yaml(v2) is checked for update.

We've been wanting this feature for while now. @mumoshu, do you still think the change belongs upstream? I would love to be able to use helmfile labels too, e.g. helmfile -l myLabel=foo deps, which seems to require a change on the helmfile side anyway.

@yujunz Hey! Thanks for resurrecting this. I believe enhancing deps to support labels helmfile -l foo=bar deps does make sense. Do you need anything other than that?
What @NelsonJeppesen has requested seemed something totally different than what you suggested, as it was about running helm dep up by chart name, rather than release label or release name.

Ah, I see. I'd like to select by labels and release name.

@yurrriq PTAL at #1764
I'm still scratching my head about how we could achieve what @NelsonJeppesen has originally requested.

@yurrriq PTAL at #1764
I'm still scratching my head about how we could achieve what @NelsonJeppesen has originally requested.

Nice to see activity on this! While my original request was slightly easier for my use case, using a selector achieves the same results.
I think (it's been awhile) my thought process was that updating by chart made more sense because there can be a many to one mapping between chart and releases. We have several releases that use the same helm chart. Just a clarity thing.
That being said, using selector works for me

@NelsonJeppesen Hey! Thanks a lot for your feedback. Glad to hear that selector works for you.
Let me add one thing. I realized that #1764 also enables you to run deps only on releases using a specific chart with helmfile -l chart=elasticsearch deps.
It is still not possible to run deps only on releases using charts from a specific repo, like you've raised initially as helmfile deps jenkins(assuming jenkins is the repo name), though.

Cross-posting here. The selector doesn't quite work yet, see #1900


Incorrect reference to example implementation

Hi @carlosbuenosvinos
I think there is an incorrect reference to an example implementation in the The Command Side section of the Anatomy of CQRS chapter. The example implementation has only one named constructor:

...whereas two different named constructors are being referenced in the following paragraphs:

Thanks!

I'll take a look to it. Thanks!

References do not exist anymore.


python310Packages.svglib: 1.4.1 -> 1.5.1

Automatic update generated by nixpkgs-update tools. This update was made based on information from passthru.updateScript.
meta.description for python310Packages.svglib is: A pure-Python library for reading and converting SVG
meta.homepage for python310Packages.svglib is: https://github.com/deeplook/svglib
Updates performed

Ran passthru.UpdateScript

To inspect upstream changes
Impact

Checks done (click to expand)

built on NixOS
The tests defined in passthru.tests, if any, passed
found 1.5.1 with grep in /nix/store/ph5gigwfl9d3mi4wysghxjk54l53vvnf-python3.10-svglib-1.5.1
found 1.5.1 in filename of file in /nix/store/ph5gigwfl9d3mi4wysghxjk54l53vvnf-python3.10-svglib-1.5.1

Rebuild report (if merged into master) (click to expand)

10 total rebuild path(s)

10 package rebuild(s)

First fifty rebuilds by attrpath
maigret
python310Packages.easy-thumbnails
python310Packages.rmrl
python310Packages.svglib
python310Packages.xhtml2pdf
python39Packages.easy-thumbnails
python39Packages.rmrl
python39Packages.svglib
python39Packages.xhtml2pdf
sasview

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/ph5gigwfl9d3mi4wysghxjk54l53vvnf-python3.10-svglib-1.5.1 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A python310Packages.svglib https://github.com/r-ryantm/nixpkgs/archive/d344bedb19f0efdda5cdf8e6efcdcd2c44a939ca.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/ph5gigwfl9d3mi4wysghxjk54l53vvnf-python3.10-svglib-1.5.1
ls -la /nix/store/ph5gigwfl9d3mi4wysghxjk54l53vvnf-python3.10-svglib-1.5.1/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

10 packages built:

maigret
python310Packages.easy-thumbnails
python310Packages.rmrl
python310Packages.svglib
python310Packages.xhtml2pdf
python39Packages.easy-thumbnails
python39Packages.rmrl
python39Packages.svglib
python39Packages.xhtml2pdf
sasview

Maintainer pings
cc @trepetti for testing.

Result of nixpkgs-review pr 209994 run on x86_64-linux 1

10 packages built:

maigret
python310Packages.easy-thumbnails
python310Packages.rmrl
python310Packages.svglib
python310Packages.xhtml2pdf
python39Packages.easy-thumbnails
python39Packages.rmrl
python39Packages.svglib
python39Packages.xhtml2pdf
sasview


Rewrite Websockets for them to actually work

https://github.com/sopra-fs23-group-39/sopra-server/commit/ff6253edd49ee3f5bf9d4e8dcee9c32835698a6a


Add windows support to bullet3 and more features

This adds the following to bullet3

Windows support
More unneccessary options are disabled
All required files are copied accordingly
Version 3.05
Fixes git checksum

xmake outputs this:
finding bullet3 from xmake ..
{
  version = "3.05",
  includedirs = {
    "/home/runner/.xmake/packages/b/bullet3/3.05/69baf2d1057444629235f213aed5df69/include",
    "/home/runner/.xmake/packages/b/bullet3/3.05/69baf2d1057444629235f213aed5df69/include/bullet",
  },
}

but I wrote this in on_install:
package:add("linkdirs", package:installdir("lib"))
package:add("links", "Bullet2FileLoader", "Bullet3Collision", "Bullet3Common", "Bullet3Dynamics", "Bullet3Geometry", "Bullet3OpenCL_clew", "BulletCollision", "BulletDynamics", "BulletInverseDynamics", "BulletSoftBody", "LinearMath")
package:add("includedirs", "include", path.join("include", "bullet"))

Why are the links and includedirs lines ignored? The snippet, which needs this, compiles successfully. Is this just a display bug?

Why are the links and includedirs lines ignored? The snippet, which needs this, compiles successfully. Is this just a display bug?

not bug, If the library file is not found in the lib directory, links/linkdirs will not be added.


Change the default IGV genome from b37 to b37_1kg

@holtgrewe informed me that the most recent IGV versions have removed b37 and b37_1kg should be used in its stead.
Spec

Replace default genome with b37_1kg
Update existing values in production database

Use a migration

Update release notes in docs
Once deployed, add admin message advising to update to the newest IGV if warnings are raised

Done, to be deployed in production tomorrow.

Hi, all our users in medgen have the issue, that they can't find the b37_1kg genome file. Do you know, where we can find it?

@xiamaz Can you install the most recent IGV version?

IGV 2.16 works. IGV 2.14 doesn't


[Bug](json reader) object should stop processing when encounter error

If DATA_QUALITY_ERROR encountered we should stop processing this document any more.Otherwise there will be UB in simdjson.
Proposed changes
Issue Number: close #xxx

Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

run buildall

run buildall

#31159


main

I am starting to add swahili benchmark

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

@msamwelmollel let's make change this to a draft.

@msamwelmollel let's make change this to a draft.

Should I pull again, or what should I do now since the merging is blocked?

No need to make a new PR. You should have the option to change this PR to a draft. But not changing is also not much of an issue.

Closing bc it appears this was continued in #2031