Encoder does not compile on MacOS 10.15.3 due to lack of std::popcount

Hi!
I'm trying to compile the encoder using make on MacOS 10.15.3 (also tried 10.13.1).
Make simply errors out with "./framebuffer.hpp:260:27: error: no member named 'popcount' in namespace 'std';
did you mean '__popcount'?".
I tried updating to Make 4.3 (from the 3.81 shipped with MacOS). Unfortunately it did not help.
Could you perhaps share a precompiled version of the encoder?
Thanks (this project is beyond cool!)

Solved!
To compile with Make:
Edit "ruler.hpp", "framebuffer.hpp" and "compressor.hpp" to:
#Include "builtin.h" (see https://github.com/nemequ/portable-snippets/tree/master/builtin for details)
#define PSNIP_BUILTIN_EMULATE_NATIVE
and also replace "std::popcount" with "__builtin_popcount" in the same files.
It now compiles and runs fine!

Sorry, I haven't see your defect report sooner.
As std::popcount is standard C++20, I guess your compiler is too old. Is it a C++20 compiant compiler?
It compiles fine on my Mac 11.4, with
Apple clang version 12.0.5 (clang-1<IP_ADDRESS>)
Target: x86_64-apple-darwin20.5.0
Thread model: posix
 InstalledDir: /Library/Developer/CommandLineTools/usr/bin

Can you give me your version of the compiler?
If too old, I can workaround the lack of native popcount in a more standard way (in fact that's what the code used to do), by either using another C++ feature:
std::bitset<32> b{ v };
return b.count();

or computing it "by hand":
int mypopcount( int n ) {
    int count = 0;
    while (n) {
        count ++;
        n &= n-1;
    }
    return count;
}

as modern compiler will substitue the right AVX instruction : https://godbolt.org/z/WvEjWh9oK
Let me know, and have fun in the meantime.

Added a fallback for std::popcount that should run fine on non-std C++20 compilers. Please let me know if stock source code compiles fine now.

With the fallback it now compiles fine with the below versions, thanks!
for your previous question:
I simply tried to compile with "make" in MacOS terminal as per the instructions. I've never compiled anything or written a single line of C so really not an expert here haha. I tried updating make, but looking now it might have been I have to update clang separately? This is the versions I have now (shipped with MacOs 10.15.3 that didn't compile):
make -v
GNU Make 4.3
Built for x86_64-apple-darwin19.6.0
Copyright (C) 1988-2020 Free Software Foundation, Inc.
License GPLv3+: GNU GPL version 3 or later http://gnu.org/licenses/gpl.html
This is free software: you are free to change and redistribute it.
There is NO WARRANTY, to the extent permitted by law.
clang -v
Apple clang version 11.0.0 (clang-1<IP_ADDRESS>)
Target: x86_64-apple-darwin19.3.0
Thread model: posix
InstalledDir: /Library/Developer/CommandLineTools/usr/bin

The Makefile is so trivial, it could probably run with a make from 1990. It is the compiler.
std::popcount is a late C++ addition, and Apple often even diverge from the linux version (because godbolt is telling me that std::popcount works on clang-11.0.0 : https://godbolt.org/z/Kj35E7EKr ).
Don't update clang on OSX, it is not worth the pain. For now, I'll just try not to use bleeding edge features (but I can't guarantee). At worse, I'll build a binary.
Have fun, and don't hesitate to tell me how it goes -- or submit bugs / enhancement requests !

(Unsure how to contact you)
Beware, new player is INCOMPATIBLE with existing flims. You will need to re-encode your old flims with the new version to be able to play. This should not happen again anytime soon. Let me know if this is too much of a burden.

Thank you for letting me know! Do you have any list of changes? The ”old” player works perfectly for me so might just stick to that one. Can also report it works just fine under a 68040 upgrade with no issues whatsoever!

Can also report it works just fine under a 68040 upgrade with no issues whatsoever!

Not a surprise, but good to know anyway!
FYI, there is a list of changes a) in the commits, b) hidden as a 'STR#' resource in the resource fork. I don't think they are easy to follow, though.
The core reason for which I had to change the format is "complicated". I want to get MacFlim working on older macs and in environments where real-time is not too important (ie: having silent flims playing as demos, even if they are not at the "right" speed. Silent flims are much more resilient to I/O issues).
So, in the version you have, the encoder tells the player a lot of details on how to allocate and use memory for playback. This is gone, and, while the player is much more complicated internally, it now supports for the Mac XL (ie: the Lisa 2), the Mac 512K (with non-scsi hard drive), and pave the way for a work in progress on getting (silent) flims to play via ethershare (fingers crossed) and maybe memory-constrained floppy play for the 128K (one can dream). It also have optimized playback on the Macintosh Portable via specific assembly routines.
I also added a version number, so hopefully I should be able to support this format for a long time.
Anyway, just making sure you don't git update the encoder and get into issues. I would suggest you to update, but, if you have created custom flims or if it is difficult to transfer flims to your hardware, you may want to be careful and/or wait a bit.
There is no change that impacts "standard" SE/30 playback, so if that's what you do, you don't miss anything by delaying update ( there is no SE/30 specific player improvment planned, but, as no-one entered any issue, I guess it is just perfect :-) ). Beware that flims on the website are now incompatible with your version, though.
Have flun!


Missing RegionEndpoint for ap-east-1

It appears that the RegionEndpoint is missing entry for APEast1.
https://github.com/aws/aws-sdk-net/blob/master/sdk/src/Core/RegionEndpoint/RegionEndpoint.c
Expected Behavior
var region = RegionEndpoint.APEast1;
Actual Behavior
In Visual Studio 2019:
var region = RegionEndpoint. multiple fists to the keyboard ensuring that the period key is part of the onslaught; however APEast1  does not magically appear

Taking a look

Hello,
we added the APEast1 region in AWSSDK.Core <IP_ADDRESS> (https://github.com/aws/aws-sdk-net/commit/007330c80ba52b674d40a4e0dee9956da95bdd61)


implement custom cache handler logic

resolves #529

Example app: https://github.com/dario-piotrowicz/next-geolocation-pages
(application using a supabase custom cache handler)
Vercel deployment: https://next-geolocation-pages-glqcs9da0-dario-piotrowicz.vercel.app/
Pages deployment: https://8e0d4e38.next-geolocation-pages.pages.dev/

TODO:

[x] Next and next-on-pages seem to be calling the handler inconsistently, they should get aligned (example)
(solved, see: https://github.com/dario-piotrowicz/next-geolocation-pages/commit/a4eb86594cb3978e1efb8a83395f6b954d978eb2)
[x] Add missing tsdocs and comments
[x] Make sure that all different next.config.js files are correctly handled, this means function exports (as mentioned here and .mjs extensions)
[x] Make sure that Cloudflare bindings are accessible from handlers (I can't see why not but it's still worth checking)
(tested and everything seems to be in order, see: https://github.com/dario-piotrowicz/next-geolocation-pages/commit/ac3f05eeb3ce0acdd793190adf29b6df5dad67b3)
[x] Update docs

TODO as a follow up, not to scope-creep this PR:

create a new next-on-pages submodule for caching utilities, it should export the KV handler and make it configurable so that developers can use it and set any binding name they want
explore if bindings in a cache handler can be used in next-dev, I suspect not but it's still worth exploring (if it's not possible it also needs to be properly documented)

Revalidating a tag:

This will be awesome if released!!


Adding a devfile registry index

Signed-off-by: Andrew Mak<EMAIL_ADDRESS>As discuss recently on the Codewind/Appsody interlock call, we would like to submit a devfile registry index.json to be hosted in the stacks repo, so that it can be consumed by Codewind.
The contents of the index.json reflects directly what's currently in index.yaml; generating index.json from the index.yaml can be done at a later time.
(Codewind will be adding ability to process tar.gz file via https://github.com/eclipse/codewind/pull/62)
CC: @neeraj-laad @seabaylea
Checklist:

[x] Read the Code of Conduct and Contributing Guidelines.

[x] Followed the commit message guidelines.

[ ] Stack adheres to Appsody stack structure.

Modifying an existing stack:

[ ] Updated the stack version in stack.yaml

Contributing a new stack:

Describe how application dependencies are managed:

Explain how Appsody file watcher is utilized:

Describe other Appsody environment variables defined by the stack image:

Describe any limitations and known issues:

Related Issues:

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

@makandre It might be best to generate this file and publish as a release asset along with index.yaml. However I have a few questions regarding the contents fo the file itself.

Yes I think ultimately we want this file to be generated whenever index.yaml is updated.  This PR is just to have something hosted initially for us to work with, while the auto-gen gets worked out.
I'm not sure what you mean by publish as a release asset; it's fine as long the file will be accessible to Codewind at some url.  But we also need to keep in mind the relative link to the devfile works (whenever we get to adding that) because that is something that Che uses
And lastly the intent of the file is to list everything; so yes, no filtering.

I meant publishing the assets here: https://github.com/appsody/stacks/releases. You should be able to access the latest indexes here using the latest tag.
I ma not sure what you mean by adding devfiles to relative path. I do not believe we want to add any devfiles to our repo? Did I miss anything?
Also, does CodeWind support multiple repos? We intend to have separate indexes for stable/incubator/expreimental repos.

@neeraj-laad Codewind does have support for multiple repos
With regards to devfiles, I've been told that eventually we'd want an appsody repo to also function as an Eclipse Che devfile registry repo, so then whatever repo we point the CLI to for stacks, we can also point Codewind (or Codewind on Eclipse Che) to it so they are all able to get the same information.

@seabaylea would like your inputs on this.

closing this PR. This will be replaced by https://github.com/appsody/stacks/pull/163


[cartservice] Replace Log API

Fixes #.
https://github.com/open-telemetry/opentelemetry-demo/issues/223
Changes
I have replace Console log statement  as Opentelemetry log API for cartservice
In previous version, the log results is
GetCartAsync called with userId=576b61d0-8e82-43d0-a18e-03cafc026f27

In current version, the log results is

Resource associated with LogRecord:
service.name: cartservice
k8s.namespace.name: hipster
k8s.node.name: <IP_ADDRESS>
k8s.pod.name: cartservice-v1-586479447c-w9bw2

LogRecord.Timestamp:               2022-11-12T11:28:32.1971300Z
LogRecord.TraceId:                 383b76b135a51cbd1a10753999de1df4
LogRecord.SpanId:                  c372930bd099f82d
LogRecord.TraceFlags:              Recorded
LogRecord.CategoryName:            cartservice.cartstore.RedisCartStore
LogRecord.LogLevel:                Information
LogRecord.FormattedMessage:        GetCartAsync called with userId=576b61d0-8e82-43d0-a18e-03cafc026f27
LogRecord.State (Key:Value):
    userId: 576b61d0-8e82-43d0-a18e-03cafc026f27
    OriginalFormat (a.k.a Body): GetCartAsync called with userId={userId}

We discussed this in the sig today. We want to keep the console from getting overloaded with one service and have yet to define our logging story in general.
Ideally we export these type of logs over OTLP and have a consumption story in the UI.
Closing for now but if you're interested in contributing to our log design we'd love the help. We just opened an issue related to this

I think at least we can replace the Console log statements as .Net log API  statements？


[Action Required] Upgrade your App Engine Standard applications to Go 1.11 or 1.12 before October 1, 2019

Today, I received an email like this.

Does anyone know what things I need to update?
cc: @rakyll

cc @broady @zombiezen

Redeploying the app to Go 1.11 should work without change. If you want to use Go 1.12, then you may have to tweak main.go to load your file without giving a command-line argument, but it should still largely work.

@zombiezen , I tried to change the app.yaml to this.
runtime: go111

handlers:
- url: /.*
  script: _go_app

I get this error: File upload done. ERROR: (gcloud.app.deploy) INVALID_ARGUMENT: script field for handler '/.*' must be set to 'auto' for runtime go111.
https://cloud.google.com/appengine/docs/standard/go111/go-differences page seem to recommend some additional changes.

Change script: to auto instead of _go_app and it seems to work fine on go112.

@davidnewhall I think I addressed all of these in https://github.com/GoogleCloudPlatform/govanityurls/pull/34

I don't think this project is getting more updates. You're probably best off forking or picking one of the up to date forks that already exist. I forked and went hard core with the changes. See here https://github.com/golift/turbovanityurls. Good luck!

Closed via #34.
(Note: I added some more contributors including @philips to the repo.)

Sweet!


Move curl and httpie to final layer in dockerfile

Checklist

[x] Add a Changelog entry

#794 attempted to add curl and httpie to the docker image as a tool to be used in health checks. However, it was added to the builder layer, not the runner layer and hence not available at run time. This PR moves this installation.
Before this change:
docker exec -it ta991 bash
root@16a473d8c0e1:/deploy# curl
bash: curl: command not found
root@16a473d8c0e1:/deploy#

After:
docker exec -it a901 bash
root@a90185b67888:/deploy# curl
curl: try 'curl --help' or 'curl --manual' for more information
root@a90185b67888:/deploy#

I should have tested that before merging. Heads up @Kezzsim.


[BUG] - Daemon takes more than 30s to start

Checklist before submitting an issue

[X] I have searched through the existing closed and open issues for eww and made sure this is not a duplicate
[X] I have specifically verified that this bug is not a common user error
[X] I am providing as much relevant information as I am able to in this bug report (Minimal config to reproduce the issue for example, if applicable)

Description of the bug
The daemon takes about a minute to start :
❯ RUST_LOG=DEBUG eww daemon
 2022-04-15T09:15:07.787Z INFO  eww > Initializing Eww server. (/run/user/1000/eww-server_49aefd36c9580d2a)
Run `eww logs` to see any errors while editing your configuration.
 2022-04-15T09:15:07.787Z INFO  eww::server > Loading paths: config-dir: /home/okno/.config/eww, ipc-socket: /run/user/1000/eww-server_49aefd36c9580d2a, log-file: /home/okno/.cache/eww_49aefd36c9580d2a.log

❯ eww logs
┏━━━━━━━━━━━━━━━━━━━━━━━┓
┃Initializing eww daemon┃
┗━━━━━━━━━━━━━━━━━━━━━━━┛

 2022-04-15T09:15:07.856Z DEBUG eww::server > Initializing script var handler
 2022-04-15T09:15:50.588Z INFO  eww::ipc_server > IPC server initialized

Reproducing the issue
I have no idea how to reproduce, I am running on wayland (sway), built eww with the correct features I guess.
Expected behaviour
eww should start faster
Additional context
No response

Alright I found out what was blocking the daemon but I am puzzled still.
I have a systemd unit to automount an external NFS storage :
[Unit]
Description=Automount shared Storage

[Automount]
Where=/mnt/storage

[Install]
WantedBy=multi-user.target

Whenever I start eww daemon I see journald log trying to mount this device. Eww starts once the mount operation fails.
Disabling the systemd unit makes eww starts normaly.

Hmmmm that might be related to magic variables trying to load an initial disk size?

@oknozor I found this issue by accident but observe a slow start of my swayrbar on my work laptop whereas it starts immediately on my private laptop.
Both eww and my swayrbar use the sysinfo crate to access system information.  Maybe that does something which results in blocking until some auto-mounts have been mounted?

hey man.. i have the same issue ... and i can't fix it
eww::ipc_server > ipc server initialize


Remove distance_matrix from ProblemData bindings

This PR:

Removes distance_matrix from ProblemData bindings. We don't need it as we have the dist function, while it causes subtle issues (like #204) because IntMatrix needs to be imported before the method can be used, which does not happen automatically.

[x] Closes #204.
[x] Adds and passes relevant tests.
[x] Has well-formatted code and documentation.

Removing the binding "fixes" the problem, but we probably want to keep duration_matrix exposed so that users can access it. Since we define our own Matrix types, this means that IntMatrix or DoubleMatrix must always be imported before accessing this attribute to avoid a TypeError.
I think that addressing #61 is a better way to address this issue. @N-Wouda what do you think?

I don't see a strong need for exporting the distance_matrix as we already have the dist function? If we have it, it also creates problems with ownership if the ProblemData goes out of scope, or it should return a copy? In any case, we could bring it back as a numpy array with #61 but have this as fix for now? It's not used anywhere except in a test.

Running test_read.py individually also passes without errors now.


Update to new renderers API (Jupyter)

https://github.com/microsoft/vscode/issues/93265#issuecomment-844237859
Jupyter version of the new renderers update. Issue here is that I'm a bit more worried about webpack 4 -> 5 update here. Just more going on with our webpack in Jupyter. Will tackle this after renderer API is updated.

Nothing to valdiate, moving as closed


Feature Request: github_app_installation_repository

https://registry.terraform.io/providers/integrations/github/latest/docs/resources/app_installation_repository
It would be useful to have support for this within the module.

It looks like you beat me to the punch. Thanks!

Hey @anthr76 , we just released v0.16.1 now :) Let me know if there's anything else we can do for you


Issue #9005 fixed.

Issue Reference

Issue #9005 fixed.

Checked and Found that it is working fine now.


[Azure Search] Updating AutoRest config files

Fixed client name in the management plane config.
Split the data plane config into three files:

readme.md: Contains the config settings common to both data plane specs.
readme.index.md: Contains config settings specific to SearchIndexClient.
readme.service.md: Contains config settings specific to SearchServiceClient.

This was necessary in order to get the Swagger validator to run correctly, since otherwise it was combining the specs into one and crashing because they both contain x-ms-parameterized-host. The intent is to have separate specs, since the Azure Search data plane SDK is comprised of two separate clients (one statically-typed for the base resources, and one dynamically-typed for customer-specific index schemas).

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.
PR information

[x] The title of the PR is clear and informative.
[x] There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
[x] Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
[ ] If applicable, the PR references the bug/issue that it fixes.
[x] Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

[x] I have read the contribution guidelines.
[ ] My spec meets the review criteria:

[x] The spec conforms to the Swagger 2.0 specification.
[x] The spec follows the guidelines described in the Swagger checklist document.
[ ] Validation tools were run on swagger spec(s) and have all been fixed in this PR.

Automation for azure-sdk-for-python

Automation for azure-sdk-for-go

This looks reasonable to me, is there something you would like to add @fearthecowboy  ?

Looks good to me.


Issue with Cache-Control response header when Cache-Control request header is set

This issue relates to the Cache-Control filter for support Dispatcher TTLs.
It is unclear why the ACS filter does NOT return a Cache-Control response header, if it sees one it the request [1]. Looking at the HTTP 1.1 specification [2], the client is simply asking for a response that has at most that age. The specification says:
[…] If both the new request and the cached entry include "max-age" directives, then the lesser of the two values is used for determining the freshness of the cached entry for that request. […]
Therefore the filter should still return max-age in the response.
The current behavior might result in "stale" content on the dispatcher, never honoring the configured TTL, if the very first request comes in with a Cache-Control max-age value for instance.
[1] https://github.com/Adobe-Consulting-Services/acs-aem-commons/blob/master/bundle/src/main/java/com/adobe/acs/commons/http/headers/impl/DispatcherMaxAgeHeaderFilter.java#L84
[2] https://www.w3.org/Protocols/rfc2616/rfc2616-sec14.html

@bstopp can you take a look at this?

Sure. I missed that excerpt when designing this; so i'll remove the header check and always return the max-age.
But I suppose there's another question: Should we remove the check that the request is from the Dispatcher, treating the dispatcher as a Shared Cache specifically (therefore using the s-maxage directive [1]) or both?
Removing the dispatcher check would allow the value to be returned for every request. Changing the directive to s-maxage should prevent browser caching while still caching content at the Dispatcher and CDNs. This assumes that the Dispatcher is designed to honor that Cache-Control directive.
Thoughts?
[1]https://www.w3.org/Protocols/rfc2616/rfc2616-sec14.html#sec14.9.3

I'd suggest leaving the Dispatcher check in place. At least for now. I would, however, suggest that we clearly document that this only fires if a request comes via the Dispatcher and maybe even provide a sample curl command to pass the header required to "trick" the filter into thinking it is coming from the Dispatcher (as that would be useful for testing purposes)

On it.

+1 thanks for the quick turnaround. Note that the max-age returned should be the lesser of the two values though (request / response)

@coatpont : Not sure about that. Looking at the relevant HTTP specification, it says:

then the lesser of the two values is used.

So, it's okay for the filter to e.g. return "max-age=60", although the client sent "max-age=15"

ok, then I'm wrongly interpreting what the "lesser of the two values" means.

I think, it means the client will use the lesser of the two values, not the cache when sending its response.

I read it same as @dominique-pfister - the client uses the lesser values (the request max-age and the response max-age) to determine the freshness (or staleness) of the response, and then acts accordingly.
IIUC, if a client could change the max-age written to the response by AEM, then a client could dictate how dispatcher caches requests for all other clients.

See David's response; that's how I read it too. The excerpt is taken from the context of how the cache must handle the processing of conflicting headers.

I don't think that a client's max-age request will affect other client's requests, but any client passing a max-age=0 directive would, by this definition, bypass the dispatcher for every request.

Welcome to DOS-ville, USA :)

PR Merged


🐛 error importing memory from dbmage in development

we're getting this error in the browser on master SyntaxError: The requested module 'blob:http://localhost:8080/bd45f835-7950-43a1-b4e0-a0733d530260' does not provide an export named 'memory'
not sure why...

fixed in 1e14b4d4cb60379f742c99f019f6cdcefb055682


When asking for LAT and LON inform user of format.

When asking for latitude/longitude values during the execution, it might be helpful to specify a format example like (##.####).

When asking for LAT and LON the lines now look like so:
"Feeder Latitude: (Decimal Degrees XX-XXXXXXX) "


License doesn't allow redistribution

Being made aware though the Matrix chat, this software doesn't allow open redistribution and thus we are not allowed to actually host it on conda-forge: https://github.com/Acellera/moleculekit/blob/ba2e8c6cba39ed8f6aa097b9452c90fa41d44fb2/LICENSE#L10
cc @conda-forge/moleculekit @conda-forge/core

Yes, you are right about this. I can discuss this a bit at Acellera if we are willing to relax that condition in the license.

I am also going to archive the feedstock.


Refactoring actors

Another big refactoring around Actors.
Been testing this a lot, but it's possible that I could have broken some things, still, as there are some important changes in there.
This should significantly improve a few things:

Navigation around the whole code base, as Actors are everywhere, and having type annotations makes it much easier to jump around the places where they are used
Checking that we're not relying on some missing/renamed actor properties, as there's a whole bunch of them, and there were quite a few mistakes uncovered by the type annotations
Helping us eliminate complexity around this central piece of the game engine

I renamed runtimeFlags to state so that things are more consistent with the rest of the codebase (adopting react naming conventions), and because it's less of a mouthful. I also removed a whole bunch of properties in there that were copy-pasted names from the original that we don't use at all in our engine. Overall, I think we should really name things our own way instead of sticking to the original names. And I think we should NEVER add variables/properties that we're not gonna use immediately (YAGNI), as it creates a lot of extra confusion as to what is what. Often we're doing things quite differently than the original, so adding the same flags as in there if we're not gonna end up using them is just polluting the code with useless complexity. And we can't know in advance what we're gonna use or not.
I also moved some stuff around between the actor object itself, and the props and state properties so that these things better reflect how we use them, and keep the class definition itself as simple as possible. I think we can go further on that path, especially with the actor props, I think these should be cleaned-up and should be exclusively treated as read-only data, which is not the case right now. I'll probably send another PR with such changes.
Preview here: https://pr-431.lba2remake.net

fwiw I tested a bunch of the newer features I've done and everything seems to be fine

Ok, I'm merging now, will address the remaining suggestions in the next PR.


Extract common code from review jobs

Extracts commonalities from ScssReviewJob and HamlReviewJob into a
new Runner class
Introduces Linters top level namespace
Moves HamlLint::Runner to Linters::HamlLint
Moves ScssLint::Runner to Linters::ScssLint
Moves HamlLint::Violation to Haml::Violation to avoid the
HamlLint namespace collision. The Haml namespace will be removed
in a future commit.
Moves ScssLint::Violation to Scss::Violation to avoid the
ScssLint namespace collision. The Scss namespace will be removed
in a future commit.

https://trello.com/c/tNkpUewT

Seems like a solid refactor so far. Where are we going to put the Violations?

The Violation classes are also very similar, so we'll probably end up with a similar refactoring where the common pieces are pulled out. Wanted to keep the diff for this PR small though, so didn't start on that work yet.

Cool, sounds good. Other than the couple comments I made, LGTM!


no support for python 3.6

When using the library with python 3.6 (default for Ubuntu 18.04), the following stacktrace is printed:
Traceback (most recent call last):
File "./bin/rafcon", line 31, in
from rafcon.gui.config import global_gui_config
File "/home/basti/develop/rafcon/source/rafcon/gui/config.py", line 25, in
from rafcon.utils import storage_utils
File "/home/basti/develop/rafcon/source/rafcon/utils/storage_utils.py", line 24, in
from jsonconversion.encoder import JSONObjectEncoder
File "/home/basti/.local/lib/python3.6/site-packages/jsonconversion/encoder.py", line 12, in
from json.encoder import JSONEncoder, _make_iterencode, encode_basestring_ascii, FLOAT_REPR, INFINITY,
ImportError: cannot import name 'FLOAT_REPR'
Maybe this could be a solution:
https://stackoverflow.com/questions/1447287/format-floats-with-standard-json-module

Was fixed some time ago in 0c493dcd5755adbb37d32d1cfbb26f26c25519de


Configure WES-ELIXIR to point TES requests to proTES

Is your feature request related to a problem? Please describe.
For implementing an end-to-end test of WES-ELIXIR > proTES > TEStribute > TESK or mock-TES, cwl-tes-issued TES requests within WES-ELIXIR should be pointed to a publicly available proTES proxy TES instance.
Describe the solution you'd like
A publicly available proTES instance first needs to be deployed (elixir-europe/proTES/issues/36), parameter tes: url in the app's config file then has to be pointed to the service instance's IP address.
Describe alternatives you've considered
N/A
Additional context
N/A

Done in instance: http://<IP_ADDRESS>:7777/ga4gh/wes/v1/ui/


the mod Taterzen NPCs requires DisguiseLib, and there is no disguiselib 1.19.2 fabric version? what do i do about this

It doesn't require disguiselib, that's just recommendation. Try 1.19.1 version if you need it.


Feature Request - Update/include ISE for PS7

Integrate into PowerShell ISE
Have PowerShell 7 install update the PowerShell ISE as well.
$PSVersionTable.PSVersion does not output version 7 in the ISE.

ISE was deprecated long time ago. Please use VS Code with PowerShell extension.


pyroscope-receiver: remove service label from hists

Prometheus histograms are very expensive. This change removes service_name label from histograms, because it can explode cardinality.

@tomershafir how would correlation be possible without the service labels?

@lmangani You cant, its a tradeoff. (The other options are: a summery that you cant aggregate, or plain sum and count counters that can yield an average)

@tomershafir added some configurations to filter metrics and labels. Please take a look https://github.com/metrico/otel-collector/pull/105/commits/1cf50027b80699155dcd446362dd8548fd486bc4


Error : GithubException: 403 {"message": "You must authenticate via a GitHub App

github.GithubException.GithubException: 403 {"message": "You must authenticate via a GitHub App.", "documentation_url": "https://docs.github.com/rest/reference/checks#create-a-check-run"}

@sri59677 what was the situation where this error occurred and how did you fix it? Or was it transient?

I entered GITHUB TOKEN in secrets thats why i got issue

So this was a typo on your side. Thanks for clarification.

Hi @sri59677 @EnricoMi I am Using this curl command to send results
curl -L
-X POST
-H "Accept: application/vnd.github+json"
-H "Authorization: token $(gitToken)"
-H "X-GitHub-Api-Version: 2022-11-28"
https://api.github.com/repos/$owner/$repo/check-runs
-d '{
"name": "Test Results",
"head_sha": "$(Build.SourceVersion)",
"status": "completed",
"conclusion": "success",
"output": {
"title": "Test Results",
"summary": "Summary of test results",
"text": "'"$(cat $(Build.SourcesDirectory)/TestResults/unitResults.html)"'"
}
}'
but Still, I am getting {"message": "You must authenticate via a GitHub App.", "documentation_url": "https://docs.github.com/rest/reference/checks#create-a-check-run"}

Hi @sri59677 @EnricoMi I am Using this curl command to send results
curl -L
-X POST
-H "Accept: application/vnd.github+json"
-H "Authorization: token $(gitToken)"
-H "X-GitHub-Api-Version: 2022-11-28"
https://api.github.com/repos/$owner/$repo/check-runs
-d '{
"name": "Test Results",
"head_sha": "$(Build.SourceVersion)",
"status": "completed",
"conclusion": "success",
"output": {
"title": "Test Results",
"summary": "Summary of test results",
"text": "'"$(cat $(Build.SourcesDirectory)/TestResults/unitResults.html)"'"
}
}'
but Still, I am getting {"message": "You must authenticate via a GitHub App.", "documentation_url": "https://docs.github.com/rest/reference/checks#create-a-check-run"}


User should only complete the "consent form" ONCE

Story details: https://app.clubhouse.io/brighthive/story/47

@reginafcompton everything is fixed and running now. Please verify and merge when ready.


Minimal Documentation

Hi,
thanks for releasing this repository - it's really cool :+1:
I was just wondering if you would be providing any minimal documentation? The examples are really nice, some extra comments though we be very helpful, especially for folks new to GPs.
Maybe easier for you, perhaps references to tutorials/other learning materials/video lectures? I'm guessing a lot of newbies, will be drawn to this repo :)
Thanks.

Documentation is definitely in the works! We're trying to finish up some features/interface changes first, and then we'll add documentation and release an alpha.
As a GP-newbie myself, this library is definitely designed for those with little GP knowledge (as well as GP experts like @jrg365).
We're shooting for a mid-September alpha, by the way.

Sounds great :)
Just in case folks are looking for resources to help them here's some good links,
GPflow - similar to this repo, but in TF
GPy - a nice place to start if you want to get a feel for GPs without too much technical stuff

I'm going to close this issue for now. Each of the example notebooks is now much more well documented, and we have a README guide to help guide model building.
We hope to have bigger documentation in the future, which will outline more about the internals. For now, this repo should be more usable though.


incorrect section heading

The instructions section heading is "To specify the agents to use for a scenario".  But, shouldn't it be something like "To specify the percentage of new users to use for a scenario"?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: bd31ab32-03e7-3af7-24a8-59c41f099e47
Version Independent ID: ab8d3396-b9ff-306e-d433-845e29b6377d
Content: Specify the Percentage of Virtual Users that Use Web Cache Data for load tests in Visual Studio - Visual Studio
Content Source: docs/test/how-to-specify-the-percentage-of-virtual-users-that-use-web-cache-data.md
Service: unspecified
GitHub Login: @gewarren
Microsoft Alias: gewarren

@joellyons thank you, i'll take a look and fix as necessary.


Blog app - Add forms

I created this PR to check if my project is as requested. 👀 👀
In this project I added forms for adding posts and comments. 💯 💯
Project requirements that are done:

Created form to create a post on behalf of the current_user ☑
Created form to create a comment on behalf of the current_user ☑

Feel free to review 👀  my project and let me know if there are any essential changes 💪

Hi @Donard97 👋,
Your project is complete!  There is nothing else to say other than... it's time to merge it :shipit:
Congratulations! 🎉

Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.

As described in the Code reviews limits policy  you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.


data mapper can't find Java types

Have the data mapper hooked into the UI a bit better, so we get the types out of the flow.  But it can't find the referenced Java types:
{
  "JavaClass": {
    "jsonType": "com.mediadriver.atlas.java.v2.JavaClass",
    "status": "NOT_FOUND",
    "javaEnumFields": {
      "javaEnumField": [

      ]
    },
    "javaFields": {
      "javaField": [

      ]
    },
    "fullyQualifiedName": "org.foo.salesforce.upsert.contact.Contact"
  }
}

Well, maybe it's just that class name in the example :-)  The twitter one fails too, I guess it doesn't yet have access to the project classpath yet?

You want to treat this field as a JSON Blob and not parse it, which is why I had escaped the quotes in it. The Rest layer doesn't have these types either and we will pass it straight on to the DataMapper.  @gashcrumb does that makes sense? It could very well be that I don't understand how this is supposed to work!

I guess this is sort of the same question as https://github.com/redhat-ipaas/ipaas-rest/issues/240
@mattrpav @chirino can you comment?

Are you launching the service using the atlas.itests project? If so, the jars are probably not in the classpath with the atlas.itests project.  These classes should be:

http://localhost:8585/v2/atlas/java/class?className=twitter4j.User
http://localhost:8585/v2/atlas/java/class?className=org.apache.camel.salesforce.dto.Contact

@mattrpav we are talking about the config that the UI layer creates as part of the mapping. So that JSON should not reference Java?

The JSON being returned is the design time list of available fields for mapping to a Java class SFDC.Contact. If this was XML, it'd look different.

Moving this issue to the data mapper ui-services project: https://github.com/redhat-ipaas/ipaas-datamapper/issues/20


Kubectl completion broken after antigen list

The problem only occurs when I'm using antigen. If I uninstall antigen and just run autoload -U compinit; compinit in the shell, kubectl completion works fine.
Problem
kubectl tab completion sometimes gives the following error:
_kubectl:4: bad set of key/value pairs for associative array
Steps to Reproduce (with plugins)

Install software and dotfiles as described in Environment section.
Cleanup rm ~/.zcompdump; antigen reset.
Open a new instance of zsh from the OS (not from inside the old shell).
Type kubectl <tab>.
Observe the error.

Steps to Reproduce (without plugins)

Install the software without any additional plugins, as described in the Environment section.
Cleanup rm ~/.zcompdump; antigen reset.
Open a new instance of zsh from the OS (not from inside the old shell).
Type kubectl <tab>.
Observe that completion appears normally.
Run the command antigen list.
Type kubectl <tab>.
Observe the error.

Workaround
This command appears to solve the problem temporarily:
source /usr/local/share/zsh/site-functions/_kubectl
(that is actually a link to /usr/local/Cellar/kubernetes-cli/1.8.2/share/zsh/site-functions/_kubectl, which is identical to the output of kubectl completion zsh).
The problem is not resolved by adding that exact source line to the end of .zshrc, and the issue will recur when a new shell is opened from the OS, but it will not recur if a new shell is opened from inside the old shell.
Environment
Software
macOS 10.13, zsh 5.4.2, kubernetes-cli 1.8.2 and antigen v2.2.1 installed with Homebrew 1.3.6.
Configuration
.zshrc
export GOPATH=$HOME/go
export PATH=$GOPATH/bin:$PATH

export EDITOR=code

source ~/.antigenrc

.antigenrc (with plugins)
source /usr/local/share/antigen/antigen.zsh
antigen use oh-my-zsh
antigen bundles <<EOBUNDLES
    brew
    cask
    common-aliases
    docker
    encode64
    gem
    git
    history
    jsontools
    kubectl
    osx
    perms
    python
    rails
    ruby
    zsh-users/zsh-completions
EOBUNDLES
antigen theme robbyrussell
antigen apply

.antigenrc (without plugins)
source /usr/local/share/antigen/antigen.zsh
antigen use oh-my-zsh
antigen theme robbyrussell
antigen apply

I was seeing this with a gcloud install without antigen and I fixed it by moving the gcloud lines above the oh-my-zsh declarations - I think the kubectl plugin doesn't load if it can't find the command.
Since I switched to antigen the issue has returned.

Having the problem as well. Still no real workaround.

Per https://github.com/ohmyzsh/ohmyzsh/issues/6323 this can be fixed by adding this to your .zshrc:
# The following two modules (compinit and bashcompinit) are needed to get auto
# completion to work: https://github.com/ohmyzsh/ohmyzsh/issues/6323
autoload -U +X compinit && compinit
autoload -U +X bashcompinit && bashcompinit

You may have to run compaudit and secure some directories to not be prompted each time about insecure directories.

Per https://github.com/ohmyzsh/ohmyzsh/issues/6323 this can be fixed by adding this to your .zshrc:
# The following two modules (compinit and bashcompinit) are needed to get auto
# completion to work: https://github.com/ohmyzsh/ohmyzsh/issues/6323
autoload -U +X compinit && compinit
autoload -U +X bashcompinit && bashcompinit

You may have to run compaudit and secure some directories to not be prompted each time about insecure directories.

I recently ran into the same issue, and I think I've traced it back as far as antigen's cache feature, at least as a contributing factor.  If disabled (via ANTIGEN_CACHE=false prior to loading antigen), then things work as expected.
I believe the cause is in antigen.zsh's cache code setup, line 1822, where a precmd hook is setup to call compinit again.  It looks to be trying to run only once, as it deletes itself from the hook list after it runs, but it's already cleared the kubectl completion defs.
FWIW, I thinks this is also related to #701, and to #698.
HOWEVER, I have no intent on fixing it - this was the last straw for me and antigen.  It fully appears as if this plugin manager is dead (see #725).  I'm moving on to some other tool.


Cannot set events with a user preferred time zone

Cross-posting from https://github.com/plone/plone.org/issues/141
It is not possible to create local events with a local time zone in plone.org or in the Volto demo, but I can in the Classic UI demo.
Classic UI Demo behavior

Login to https://classic.demo.plone.org/en as admin/admin.
Go to Date and Time control panel.
Observe the only available time zone is Europe/Berlin by default.
Add any time zone, such as America/Los_Angeles, and click Save.
Click Home to return home.
Create a new event. The event inherits the site's default time zone.
Go to User Preferences, select the available time zone, America/Los_Angeles, and click Save.

Plone.org and Volto Demo behavior

Repeat all the steps above. Observe that the User cannot set their preferences for a time zone, and must therefore rely upon the site preference for a time zone when creating events.

I don't know whether this is a bug in Volto or some other dependency.

Assign me this issue

@ashvaneetk please read and follow Contributing to Plone and First-time contributors.

@stevepiercy AFAIK, in Volto the datetime is TZ-aware, and it's extracted from the user's browser.

We want to be able to schedule an event in a different time zone than the user's browser, allowing the user to set a preferred time zone. The use cases include traveling outside one's local time zone or scheduling an event that takes place outside one's local time zone. The Volto implement does not allow either use case, whereas Classic UI does allow this. In America this is a serious problem, for example, where an organization is headquartered in the Eastern time zone but wants to schedule an event in the Pacific time zone.

@stevepiercy is adding a timezone options in the user preferences okay ?

@IshaanDasgupta Volto should have feature parity with Classic UI.

@stevepiercy sorry but if I am understanding the problem wrong let me know.

That is half the problem. Once the user sets a preferred timezone, we need to ensure that events that the user creates are in that same preferred time zone.
One more thing that was pointed out to me by @ericof is that Volto does not provide an .ical link for events. That should also be included. But maybe that should be a separate issue? We definitely need that in Volto, especially for PloneConf and sprints.

Yes, I am planning to overwrite the timezone(by getting it from the redux store) whenever the user selects a time also I am planning to add a text below the date-time picker that the time is being selected in the respective timezone. If no preference is selected then that text will not be displayed and the default timezone will be used.
Also, I am not familiar with .ical links so, I'll create a new issue for that and after implementing this, I'll look into that if no one has until then.
Is that alright ?

I don't know whether getting event information from the redux store is the best way to get something that is stored in the backend. Although as @tiberiuichim points out about Volto extracting the timezone from the user's current location, I think that method prevents an editor from creating events in other time zones. I would think the best way would be to use the Plone REST API event endpoint. It would be worth identifying how Classic UI handles events as well.

That is half the problem. Once the user sets a preferred timezone, we need to ensure that events that the user creates are in that same preferred time zone.
One more thing that was pointed out to me by @ericof is that Volto does not provide an .ical link for events. That should also be included. But maybe that should be a separate issue? We definitely need that in Volto, especially for PloneConf and sprints.

I corrected myself, Volto does provide the .ics download link (as can be seen in this image "Baixar evento"
 )

@stevepiercy as you mentioned, I went through the classic UI once again. In the classic
UI the event date-time is always displayed in the timezone in which it was created (so if my preference is Europe/Berlin and the event was created in America/Los_Angeles the date-time in the event would be displayed in the America/Los_Angeles and not be converted to my preferred timezone). Do we want the same in volto ?
Or we could keep all date-times in UTC and when rendering we could convert them to the default/preferred timezone (personally this makes more sense but then it would not be similar to the classic UI).
Also I was referring to getting the preferred timezone from the redux store not any event information.

if my preference is Europe/Berlin and the event was created in America/Los_Angeles the date-time in the event would be displayed in the America/Los_Angeles and not be converted to my preferred timezone

This is exactly what we want. In most use cases, the event's time zone will be that of its location. One exception is where there is no physical location, such as online only events such as Plone Tune Ups. In that use case, it would probably be best for the admin to enable UTC and editors set the event start and end dates and times in UTC.
As an aside, did I just discover something that has been missing in Plone for all time? I think that relying on the user's preferred or site's default time zone setting is wrong, but this issue will work with what exists now in Plone. IMO both Classic UI and Volto should allow an editor to set the event's time zone and location, regardless of their preferred time zone setting, instead of inheriting it from the user's or site's time zone setting. Thus I could create an event in the Eastern US time zone while residing in Pacific US time zone. The event would be displayed in its time zone, not the user's or site's.

@stevepiercy sorry for the late reply, I was a bit caught up.
Yes, I totally agree that an editor should be able to create events in timezone regardless of his preference. So, to implement that, I could add a timezone drop down when creating the event so the editor is able to select any timezone for that event but, then what would be the meaning of having preference ?
We could make the preference the default timezone for the user for example I am in India but if I were to chose a US timezone, all things will be converted to the US time (except for the date-time which have a specific timezone associated with them) or we could skip implementing the user preference timezone for now.
Is the drop-down idea okay or you have any other ideas for the implementation or would you recommend to implement it in a  similar way to Classic UI ?

@stevepiercy when plone.app.event was created, the plan was to support event-related timezones. There would even the possibility to support different time zones for the start and end date.
It wasn't implemented because lack of a design proposal and lack of time.

@stevepiercy https://www.youtube.com/watch?v=XZlPXLsSU2U is a good fairly recent talk on handling timezones in Python, including the new zoneinfo module

@stevepiercy that's not bad news that pytz is obsolete. It's a good library but also importing and loading it took several seconds as the database behind pytz is huge. OK, maybe importing tzdata in core Python is still slow, I don't know. However, having fewer dependencies is always good.
@stevepiercy and having you as a champion on implementing event-related timezone support is definitely good news. I can probably assist if there are any questions. I was back then the main contributor on plone.app.event.
Regarding Volto: I don't think they need this feature implemented in ClassicUI before they can implement it. The foundations are already here. The start and end dates are stored with timezone information (thus, they could also be different). For the catalog everything is translated to UTC. It's mainly an UI issue.
IIRC there is a problem with JavaScript and timezones in general, that core JavaScript has poor timezone support. Date/time only know UTC offsets. But that is not enough to calculate daylight saving time changes, for example, which is regulated by country laws.
Volto therefore needs to separately serialize the timezone information for the REST API endpoints dealing with datetimes. We discussed this issue 5 years ago in Bonn. Something was done, also by myself (cant remember what OTTOMH) but apparently there is still not timezone information in the event's REST API endpoint, looking at the resonse on https://demo.plone.org/test-event

@stevepiercy if its okay, I would like to work on the implementation part in volto.

The issue with the time in volto is more than just the events and recurrences, it also affects effective and expiration, and also volto-form-block

@IshaanDasgupta thank you for stepping up. As @thet and I both mentioned, you will need to enhance the event REST API endpoint, as well as work on the Volto frontend part. Please let me know if you need any direction for how to proceed.
@rnunez80 can you elaborate what you mean? I think you mean the publishing datetimes for "effective" and "expiration" for all content types, but I am not sure. I also don't know what is volto-form-block.

That's right @rnunez80 and @IshaanDasgupta very nice if you want to step up for this, but since this is not a simple bugfix but needs some planning and specification you need to coordinate with the other Volto people.

@stevepiercy and @thet thanks a lot, right now I am looking into the rest APIs as I not familiar with them

I'd like to work on this, at least creating a design proposal or PLIP and being its champion, if not working the code.

The PLIP would help a lot, I know it's quite a large issue and I am totally fine working alongside someone but the issue looks very interesting and I would love to contribute.

@rnunez80 can you elaborate what you mean? I think you mean the publishing datetimes for "effective" and "expiration" for all content types, but I am not sure. I also don't know what is volto-form-block.

Here is a video of the effective date issue
in this video I set the effective date about 27 min before the current time but it shows as effective and will not show on the site for the next ~4 hours due to time zone (utc -4)
Date widget Issue in volto-form-block
date selected 2023-12-04, date on email 2023-12-03 (I believe is because the date selected would be 2023-12-04 12am but due to time zone -4 it is changed to 2023-12-03 8pm)

@rnunez80 The time zone issue with effective and expiration date is a separate issue, not related to this one which is about storing a time zone as part of the Event content type. There is a PR in progress to fix it: https://github.com/plone/plone.restapi/pull/1192
The issue with volto-form-block should be submitted in that repository.

was looking into the code of plone.restapi and finally found the problem, due to the conversion of date to ISO format date, the tz info was lost.
@thet found this commit by you, the problem is in the 'datetimelike_to_iso' function, there is also a comment by @gotcha as to why did you keep the tz code commented out, could you let me know the reason for that. Like will there be any issues if we were to include the tz info which you noticed at the time ?
Apart from this, I wanted to ask a few things :

There are 2 things which we can do to solve this, first is to just make the rest endpoint return dates with tz info but if we were to do that, we would not be able to create event dates which don't need a timezone like online events as @stevepiercy mentioned earlier. If we want that to be possible, is there any other solution apart from adding a separate timezone attribute to the event content type ?
If we were to change the plone.restapi to return datetime with tz info would that cause problems to existing volto or any custom frontends which use plone.restapi ? (I tried to look into this and did not find any problems as the datetime always had the tzinfo internally it was just not returned in the response)

we would not be able to create event dates which don't need a timezone like online events as @stevepiercy mentioned earlier.

That is not correct. All events content types should have timezones, using the fallback scheme, as I mentioned in my earlier comment.

If we were to change the plone.restapi to return datetime with tz info would that cause problems to existing volto or any custom frontends which use plone.restapi ?

Good question. I assume it would be tested in Volto, plone.restapi, and plone.app.event. I'll include that in the PLIP I am drafting as a potential risk.

I just got reminded that we already support per-field timezones. It's done like that:
from plone.app.event.base import default_timezone
from plone.app.z3cform.widget import DatetimeFieldWidget
from plone.autoform import directives
from zope import schema
from plone.supermodel import model

class IExampleDate(model.Schema):
    directives.widget("example_date", DatetimeFieldWidget, default_timezone=default_timezone)
    example_date = schema.Datetime(
        title="Example date",
        required=False,
    )

This renders something like:

Only, it seems like full of bugs. I'm currently evaluating (but not yet fixing) the situation.


Keyboard input no longer works when using convert to text

Hello! I love your little program. It really agrees with the vintage vibe of the remarkable! I'm having a little trouble, though. When I convert to text and want to continue editing, the external keyboard no longer works (the keyboard on the remarkable keeps closing). From consulting other users, I've figured out that this is because it registers the external keyboard as pen strokes now, so I would have to manually stop crazy cow every time I want to edit. Is there a way to automatically stop the program when convert to text launches and restart when I exit convert to text?

I experience this too, but don't see any other option, than to stop crazy cow...


Source map support

I assume VSCode is able to handle source maps by parsing them out of the source code and grabbing them. Is it just a matter of finding the right call in VSC to use source maps from the browser/node based debugger? I wouldn't mind hacking it in, I'm just not sure how much of the work already exists in VSC itself. Has anyone ever looked into this?

I guess source map support would make it possible to work with typescript code on quickjs.

Pretty much! I am using TS currently and given QuickJS' support the generated source is very close to the original source but its still just different enough to be annoying.

FYI, in Zipline we wrote some code to combine compiled QuickJS bytecode and a sourcemap to produce new QuickJS bytecode. It's not currently set up to be reused for typescript, but it should be possible to use that code to achieve this goal. Or just use this implementation strategy.
https://github.com/cashapp/zipline/blob/trunk/zipline-bytecode/src/test/kotlin/app/cash/zipline/bytecode/ApplySourceMapToBytecodeTest.kt

I assume VSCode is able to handle source maps by parsing them out of the source code and grabbing them. Is it just a matter of finding the right call in VSC to use source maps from the browser/node based debugger? I wouldn't mind hacking it in, I'm just not sure how much of the work already exists in VSC itself. Has anyone ever looked into this?

Yes, this debug adapter supports source maps, including typescript source maps. It is unnecessary to have the source maps in the runtime itself.

https://github.com/koush/vscode-quickjs-debug/blob/4984e37c77ed1403dff95ed0accb0ad6a4b1c8b5/package.json#L187


Add note about submitting PRs on master

We got a lot of PRs on stable branches recently, this adds a note about that in CONTRIBUTING that (hopefully) people will read.

By analyzing the blame information on this pull request, we identified @zxcpoiu and @mxstbr to be potential reviewers.

cc @satya164 @mkonicek

@facebook-github-bot shipit


Car "backfire" effect missing when using controllers

I apologize in advance since the only evidence of this bug is from the FXT forums, but a real solution was never implemented as it was reported probably years after the author stopped working on it.
Basically, the cars are missing the backfire effect when upshitting using controllers. It's not missing when playing with a keyboard.
This issue happens on both vanilla and modded versions of the game.
Apparently, it's a bug related to the use of Direct Input devices. Using external programs such as XInput Plus fixes the issue. Or, as the other person said, by assigning accelerate/brake to face buttons (not triggers)
I wonder if there's a way to fix this issue without having to use external programs and/or without having to reassign the controls.

I'm sorry, but i can't test it at the moment.
Looks like i'm missing a .DLL file named api-ms-win-core-winrt-string-l1-1-0.dll (and probably many others)
The problem is that there are many topics about that issue but many solutions and none of them work, they tell to install Windows update that i have already installed, too.

It worked fine here, but I also have an Xbox Series controller.

@lance8765 you can probably remove x1nput fine if you're just using x360 controller, in future this might have something like it built in but it'll be optional, do you know if the backfire fix is working with it removed?

@lance8765 you can probably remove x1nput fine if you're just using x360 controller, in future this might have something like it built in but it'll be optional, do you know if the backfire fix is working with it removed?

I'm sorry, but the game cannot start without the X1nput files installed. It asks for the DLL.

Ah seems the new vibration code made it depend on xinput1_4.dll, looks like that's only available in win8+ for some reason.
Seems I can change it to use xinput9_1_0.dll which win7 should include apparently, maybe see if this build works for you:
OutRun2006Tweaks-0.2.5-FixFullPedalChecks-v3.zip

Ok... this one works! Thank you.
I can confirm that both the backfire and vibration work on my 360 controller.
However... the controls are completely messed up and hard to remap, but that's an old story...

Hm it might be something up with the win7 x360 directinput driver, apparently that might map triggers different to how win10+ maps them.
Guess win7 way might not be compatible, weird though since you'd think a game released around the same time would have supported it fine...
Xidi might be able to change the mapping, if you rename the outrun2006tweaks dinput8.dll to winmm.dll, you could extract xidi as dinput8.dll and use the xidi.ini from https://github.com/emoose/OutRun2006Tweaks/issues/7#issuecomment-2166208309
Not really sure if xidi has win7 support or not though, but worth a try. Will try seeing if there's anything we could do on the game side for it as well.

Well the game sees "Xidi Virtual Controller" instead of Xbox 360 controller, but i don't see any real benefit. Both triggers are still seen as "Z Axis 1".

Hm, maybe one of the other mappers could help, you can change the XInputSharedTriggers in xidi.ini to ExtendedGamepad or XInputNative, hopefully one might work better
There's a couple others at https://github.com/samuelgr/Xidi#built-in-mappers too but those might disable analogs

I've only tried ExtendedGamepad for now. It works! Right trigger is "X-Axis 2" while the left one is "Y-Axis 2". Thanks for the tip.
However i've just discovered a weird thing... Xbox and PS2 have a different button layout. The Xbox controller has the triggers but no LB/RB! But on PS2 you could use both L/R buttons to gear shift up or down (and IIRC, X to accelerate and Square to brake, among other things)
https://archive.org/details/xboxmanual_Outrun_2006_Coast_2_Coast/page/n1/mode/2up
https://segaretro.org/index.php?title=File:OutRun2006_PS2_US_Manual.pdf&page=8
In other words it's impossible to replicate the very same button layout as of console, on PC.
Also, in OutRun2SP mode, if you want a different color for your car, if you use the thumbstick to select the colors, the vertical axis is inverted (i.e. you press up, it goes down). It doesn't happen if you use the directional pad though. This also applies to XInputSharedTriggers (or no Xidi file at all)

Another issue with triggers:
When using an xinput controller with triggers as gas and brakes holding both at the same time cancels both inputs out, the game treats it like neither are pressed. The expected result has the brake lights lighting up which is currently not the case atleast using xinput triggers, using buttons instead allows for both gas and brakes at the same time. I tested this with a wired xbox 360 controller and a ds3 using dshidmini in xinput mode.
On xbox c2c atleast this worked with triggers, I tried xidi with the ini set as ExtendedGamepad to see if dinput would work and it did, but gas and brake axis were also halved in travel, they only started registering midway through. XInputSharedTriggers had the same result as normal XInput and XInputNative had the same result as ExtendedGamepad until it crashed the game when I tried to reconfigure.

Was able to use Xidi to fix the shared triggers:

rename tweaks dinput8.dll to winmm.dll
extract xidi Win32\dinput8.dll file to game folder
create xidi.ini with the following

[Mapper]
Type=OutRunMapper

[CustomMapper:OutRunMapper]
Template=XInputNative

[Workarounds]
ActiveVirtualControllerMask=1

open OutRun2006Tweaks.ini, set ControllerHotPlug to false
run game, start race
at this point the accelerator pedal should be stuck, pressing LT will decelerate and apply brake at the same time
pause game > controls > configuration
the first page should be Xidi Virtual Controller, and it should list Accelerate Axis/Brake Axis/etc
move down to Accelerate axis, press A, then press/release RT a few times until it mentions "will be assigned to: Axis 2 Z", then press A
when it asks for minimum/rest position, press RT and release it a few times, until the bars are empty, then press A
when it asks for maximum/full, press RT and release, then hold RT until bars fill, then press A
do the same for Brake Axis
once Accelerate & Brake are set, press B to exit out, then see if triggers work ingame


AioCoreSDKErrorWrapper.js - const util = require('util') NOT FOUND

AioCoreSDKErrorWrapper.js
Line 12: const util = require('util')
NOT FOUND. Code doesn't compile.

This is a module included in all node releases. https://nodejs.org/api/util.html


[WIP] merging eslint files

RHOAIENG-2534
Description

merging eslint config files
How Has This Been Tested?

Break some rules in various eslint files. It should show, and npm run test should work in root, backend, and frontend directories.
Test Impact

N/A
Request review criteria:

Self checklist (all need to be checked):

[x] The developer has manually tested the changes and verified that the changes work
[x] Commits have been squashed into descriptive, self-contained units of work (e.g. 'WIP' and 'Implements feedback' style messages have been removed)
[x] Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
[x] The developer has added tests or explained why testing cannot be added (unit or cypress tests for related changes)

If you have UI changes:

[ ] Included any necessary screenshots or gifs if it was a UI change.
[ ] Included tags to the UX team if it was a UI/UX change.

After the PR is posted & before it merges:

[ ] The developer has tested their solution on a cluster by using the image produced by the PR to main

@christianvogt made requested changes. For this to work, we will need to notify people to get rid of their working directory eslint setting, since our combined eslintrc file seems to confuse the vscode eslint extension.


E501: Does not count tab characters

The rule E501 (and all other places where we call str.width()) does not account for tab characters because char.width() returns 0 for control characters. This playground shows the problem: Line number four uses tab indention whereas line 5 uses spaces. Ruff only flags line number 5.
This brings up an interesting question... What length should we use for a tab character: 1? 2? 4? 8... I favour either 1 or 4:

1: The closest to pylint that counts the number of characters.
4: To my understanding, the most widely used indention?

I'd vote to treat tabs as length-1.

What do you mean by length - 1?

Sorry, I meant "length of 1" or "length equal to 1".


Alexa dont wake up

I hear Hello! but alexa dont wake up when i say Alexa!. Help me please.

Same here =/

system status looks ok.. but I alexa wont say anything... or wake with alexa word

If you get 0 errors (also with debug), try to say "alexaalexaalexaalexa", more than once.
I use an external speaker (jabra 510) and seems like there are some "blackout" moments when the device starts hearing. From the debug, I can see alexaPi is hearing but still she can't get the first/second time.
If anyone can help resolve this issue, could be usefull.
p.s. please share more info when asking for help..

I was having this issue too, then I switched to use 'snowboy' and set the threshold to '1', which is the max. For some reason 'pocketsphix' wasn't working for me.
All this can be configured in your 'config.yaml' file.

I do not have a config.yaml file at all. Has anybody else had this issue?
I have the config.template.yaml file but I cannot edit it in any way.

Same issue on Pi2, Can somebody help me to fix this!


Give ability to set our own root_unlock_time

Feature Request or Enhancement

Feature [x]
Enhancement []

Summary of Request
It would be nice to be able to set a variable for our own root_unlock_time value.
Suggested Code
The changes would need to be added to RHEL-08-020014,  RHEL-08-020015,  RHEL-08-020016,  RHEL-08-020018,  RHEL-08-020020,  RHEL-08-020022 tasks.

Hi @prestonSeaman2
Thank you for raising this enhancement, could you provide more information please?
There is no root_unlock_time value that can be set that i am able to find.
I am assuming you are asking if you can set whether to lock out root or not?
If that is the case it is set in defaults/main.yml - rhel8stig_pam_faillock.fail_for_root
Which is also associated with rhel-08-020023. I am changing the value from true to match the value of the control number.
Please let us know if we have misunderstood your request?
many thanks
uk-bolly

For the pam_faillock module configuration, we are requesting that a distinct lockout interval value be set for the root user, by explicitly setting root_unlock_time, as appropirate, in /etc/pam.d/system-auth, /etc/pam.d/system-auth, and /etc/security/faillock.conf. Per the pam_faillock documentation, if unspecified ,root_unlock_time defaults to unlock_time.
For example, we might want to configure pam_faillock so that the root account is still locked out after a certain number of failed login attempts, but not for as long as other users.

hi @prestonSeaman2
I believe this issue has been addressed and merged?
I will close this, but feel free to reopen if you are still experiencing this problem.
many thanks
uk-bolly


PR: Improve implementation and UI of console envs menu (IPython console/Main interpreter)

Description of Changes

The IPython console and Main interpreter plugins have repeated functionality to keep track of conda/pyenv envs in the system. This PR consolidates that in Main interpreter, which now emits a signal that the IPython console connects to to display info related to those envs.
To do that it was necessary to move almost all functionality of the Main interpreter status bar widget to its container. That will also allow us to unify that widget with the Completions one in a follow-up PR.
Show custom envs (i.e. those manually added by users in Preferences) in the console envs menu. That's important for people that don't use conda/pyenv for env management.
Break console envs menu into several sections:

Default, which shows the default and internal (i.e. same as Spyder) envs. In case they are the same, the internal env is not shown.
Conda envs
Pyenv envs.
Custom envs.

Except for the first section, the others are added if there are two or more envs per category. I decided to do that to not add many sections with a single env, which makes sections sort of meaningless in menus.

Visual changes
IPython console envs menu

Before
After

Issue(s) Resolved

Fixes #
Affirmation
By submitting this Pull Request or typing my (user)name below,
I affirm the Developer Certificate of Origin
with respect to all commits and content included in this PR,
and understand I am releasing the same under Spyder's MIT (Expat) license.

I certify the above statement is true and correct: @ccordoba12

@dalthviz, this is ready for review. Since I have to move code around in several places, I suggest that you take a look at these changes one commit at a time.

Gave this a check and seems like the menu is working as expected :+1: Also, just in case, an idea that came to my mind while checking this is to use submenus instead of sections (so Consoles > New console in environment > pyenv/conda/custom). In my current setup I have a lot of conda envs but just a couple pyenv/custom envs and I have to go all the way down to get them:

However, the status bar is not showing anything at all or showing a different env name for completions. So, having over preferences the default interpreter selected, I see on Spyder start an empty completions status bar:

If I start changing the interpreter preference between a custom interpreter and the default one, I end up with completions refering with a different interpreter than the default one even when I have set the preferences to just use the default one again:

The tooltip though is showing the correct path to the selected interpreter:

Also, I'm not totally sure to follow the reason to move the main interpreter container to be inside the widgets module, maybe the container is now also a widget? From what I see seems like it still is a PluginMainContainer 🤔

Hello @ccordoba12! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

In the file spyder/plugins/ipythonconsole/widgets/main_widget.py:

Line 78:1: E302 expected 2 blank lines, found 1

Also, just in case, an idea that came to my mind while checking this is to use submenus instead of sections (so Consoles > New console in environment > pyenv/conda/custom). In my current setup I have a lot of conda envs but just a couple pyenv/custom envs and I have to go all the way down to get them

That's a great idea @dalthviz! I implemented it in my last commit like this: if the user has more than 20 envs and there are at least two categories (conda/pyenv/custom) with one env or more, then we submenus. If not, we use a single menu with sections.

However, the status bar is not showing anything at all or showing a different env name for completions. So, having over preferences the default interpreter selected, I see on Spyder start an empty completions status bar
If I start changing the interpreter preference between a custom interpreter and the default one, I end up with completions refering with a different interpreter than the default one even when I have set the preferences to just use the default one again
The tooltip though is showing the correct path to the selected interpreter

My idea for a follow-up PR (to be created after after this one) is to remove the current Completions status bar widget, along with the Main Interpreter one, and leave a single widget that will show the interpreter of the current console (so, that widget will be similar to the Matplotlib status one).
I decided to do that for three reasons:

Now that users will be able to easily open consoles in any environment, it makes little sense to show the default interpreter in the status bar.
The completions and default interpreters were almost always the same. So, it doesn't make sense to have two of them.
This problem is similar to the one we had in Spyder 3 with the directory shown in the Working Directory toolbar. At that time we were showing a global directory, and that was really confusing to users. After we decided to show the cwd of the current console, that confusion disappeared.

Also, I'm not totally sure to follow the reason to move the main interpreter container to be inside the widgets module, maybe the container is now also a widget? From what I see seems like it still is a PluginMainContainer 🤔

I think you're right. Technically, PluginMainContainer is a widget because it inherits from QWidget. But it's not a real widget, i.e. as a dialog or button. So, I reverted that change.

I implemented it in my last commit like this: if the user has more than 20 envs and there are at least two categories (conda/pyenv/custom) with one env or more, then we submenus. If not, we use a single menu with sections.

Gave this another check and seems like things for the menus are working with the extra conditional rendering idea (subsections vs submenus) :+1: The only thing that I'm not sure if needs something to be done is the handling of empty submenus. So for example if I have 20+ conda envs and one custom env I'm seeing something like:

Maybe if no envs are available in a particular submenu, that submenu should be shown in a disabled state?

My idea for a follow-up PR (to be created after after this one) is to remove the current Completions status bar widget, along with the Main Interpreter one, and leave a single widget that will show the interpreter of the current console (so, that widget will be similar to the Matplotlib status one).

I have been thinking about that and the final result makes sense. Still, is kind of weird to leave things in an incoherent/broken state (even if is just while waiting for an immediate follow up PR). So, although is just a mere review process principles technicallity, I would say I can't approve this PR (like literal leave it approved on the GitHub interface). Anyhow, I won't stop you from merging this so feel free to do so when you think is ready :+1:

Maybe if no envs are available in a particular submenu, that submenu should be shown in a disabled state?

Good idea. I amended my second to last commit to implement that, so please check again.

I have been thinking about that and the final result makes sense. Still, is kind of weird to leave things in an incoherent/broken state (even if is just while waiting for an immediate follow up PR).

You're right. That's why I decided to remove the Completions status bar widget in my last commit.

! Gave this a new check and seems like things are working as expected 👍

Great!

However, I'm not seeing the menu in a disabled state, in fact, I'm literally not seeing the menu (the pyenv menu in this case).

That's by design. We only show submenus that have at least one env listed in them. Since you have no Pyenv envs, that's why the menu doesn't show up for you.

There's one small issue in your gifs though: they don't show a Default entry above the Internal / Conda: spyder-dev (Python 3.9.19) one. And that entry should be available because it's the interpreter set in Preferences,
I tried to reproduce that on my Windows VM but I was unable to. So, could you post a screenshot of your Preferences > Python interpreter page? Also, please post the value of get_conf("executable", section="main_interpreter") to check what's saved there.

There's one small issue in your gifs though: they don't show a Default entry above the Internal / Conda: spyder-dev (Python 3.9.19) one. And that entry should be available because it's the interpreter set in Preferences,
I tried to reproduce that on my Windows VM but I was unable to. So, could you post a screenshot of your Preferences > Python interpreter page? Also, please post the value of get_conf("executable", section="main_interpreter") to check what's saved there.

Thanks for the extra info @dalthviz! I was able to reproduce and fix the problem I mentioned above with it.


Can't seem to change providers.json.

I have been trying to add a provider to "%AppData%\Kodi\addons\script.elementum.burst\burst\providers\providers.json", but it seems the settings are not reflected in the Elementum Burst configuration page. Even only modifying an existing one shows no update to the name of the provider.
Am I missing something simple?

Never mind! I found that settings.xml doesn't get generated when adding providers, so it doesn't update the configuration page. Provider gets added though.

in case if you will want to share your provider by creating a PR, here is the script that generates settings:
https://github.com/elgatito/script.elementum.burst/blob/master/scripts/generate_settings.py


Add codepath for development to disable signature digest check

Just annoys me when I'm testing things

I'd rather not do this but rather would prefer making it easier to set the debug key fingerprint.
It could potentially even be set automatically by default.


Job Preview

[ ] Remove the column "See job" from the job list
[ ] This see option should be displayed as "Preview Job" button and should come up in job edit screen.

Followings are  the issues under 315

First to remove the see job from the job list and replace it by the "Preview  Job " button
Same "Preview  Job " button should also come up into job edit screen


Use SPI1 for APA102

Hello,
Can I use SPI1 and pins 20,21 for driving APA102?
I tried to change the port on setupAPA102 but didn't worked because there is a bug in the led.h at the setAPA102 (spi.readWrite selects always 0)
spi.readWrite(0, (unsigned char*)buffer0, 1)
But even after change this to 1, still cannot use pin 20 and 21.
Do you have any recommendation?
thank you

Hi, thanks for this, I just fixed the bug.
for enable SPI1 read this:
http://terminal28.blogspot.it/2016/05/enabling-spi1-on-raspberry-pi-bzero23.html
if you use a raspberry pi 3 with active bluetooth
you have to disable it, to make SPI1 work.

Thank you for the reply.
I manage to used the SPI1 following your advice but I have also to edit the spi2.h. In this header you have restrict the ports to use only SPI0 with this code:
class SPI2 {      public: 	string      spiDev0 = "/dev/spidev0.0" ; 	string      spiDev1 = "/dev/spidev0.1" ;
To solve it quick and dirty, I just edited to this:
string      spiDev0 = "/dev/spidev1.0" ;
and I called the setupAPA102 with the channel to 0:
apa.setupAPA102(0);
Anyway it works for me now, thank you!

later i fix this too, thank you!

I added a second setup method in the SPI class,
where you can pass the device as the first parameter.
and i added a path parameter to the setupAPA102(path,channel,speed) method
with default on SPI0.
unfortunately I can not do tests at the moment because I'm traveling,
if by chance you can do a test, so I close this issues..
Ciao

Yes, it's working!
Thank you for the fast support. Your addon gives to the openFrameworks/Rpi new potential.


Add documentation for selection of multiple columns

I was able to figure this out through experimentation, but it deserves to be explicit in the docs I think.

Sorry for the delay in responding. This looks very helpful -- thanks!


Add banking info - terms request

Is it possible to add "Accept the terms" as a checkbox within the banking information form rather than as a blocker before you enter banking information? The experience is a little awkward and unattractive right now, though it is functional. I realize this would require two distinct API requests, so I'm not sure if it's possible.

If not, let's get @kim to help us clean up the terms modal.


Remove check_nan_option

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 100.00%. Comparing base (ce15c06) to head (d6679cb).
Report is 19 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #281   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files           98        98
  Lines         2366      2362    -4
  Branches       215       214    -1
=========================================
- Hits          2366      2362    -4

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


TypeError moment__WEBPACK_IMPORTED_MODULE_7__ is not a function in v2.25.1

Yesterday Had an issue with build process thankfully it was resolved instantly after upgrading to 2.5.1
Describe the bug
After updating to 2.5.1 from 2.5.0   Moment is not importing functions
 TypeError: moment__WEBPACK_IMPORTED_MODULE_7__ is not a function
Code  implementation
import * as moment from 'moment';
fromDate = moment(from).format('MM/DD/YYYY')
vDate = moment(date, 'DD/MM/YYYY', true).format('MM/DD/YYYY');
toDate = moment(to).format('MM/DD/YYYY');

the import is compiled down to
var moment__WEBPACK_IMPORTED_MODULE_7__ = __webpack_require__(/*! moment */ "./node_modules/moment/src/moment.js");
During Compilation
Module not found: Error: Can't resolve './locale' in '/node_modules/moment/src/lib/locale'

reproducing steps npm install && npm start
open browser localhost:4200
moment-issue.zip

Fixed in Latest Commit


[ThirdEye] Strange behavior for anomaly detection timeframe end date.

System
Thirdeye built from 5f309cff34da802616d92ed361284d95b35ed9b9.
BigQuery as a data source. (should not have any impact here)
Context
My data ingestion system has a 3 hours delay, and has a daily granularity, so I wanted to check how the timeframes (especially the upper limit) were computed for anomaly detection.
In my case below, the upper date limit seems to be wrong.
Detection config:
Dataset config (shortened):
    "dataset": "dataset",
    "dimensions": ["dimension1"],
    "timeColumn": "date",
    "timeUnit": "DAYS",
    "timeDuration": 1,
    "timeFormat": "yyyyMMdd",
    "timezone": "UTC",
    "dataSource": "SqlThirdEyeDataSource",
    "realtime": false,
    "expectedDelay": {
        "size": 24,
        "unit": "HOURS"
    }

Detection config
detectionName: 'detection1'
description: '...'
metric: metric1
dataset: dataset
cron: "0 0 18 ? * * *"
dimensionExploration:
    dimensions:
    - dimension1
rules:
- detection:
  - name: 30percentchange
    type: PERCENTAGE_RULE
    params:
      offset: wo1w
      percentageChange: 0.30
      pattern: UP_OR_DOWN

Detection job run
The following queries were run for the detection job, around October 13th, 18pm UTC:
On 2020-10-13 18:00:23.019159 UTC:
SELECT MAX(date)  FROM dataset

I guess the objective  of this query is to get the most recent data time in the db.
Because my db has a 3 hours delay, the result of the query is: 2020-10-13
On 2020-10-13 18:00:25.735550 UTC:
SELECT dimension1, COUNT(metric1)
FROM dataset
WHERE  UNIX_SECONDS(date) BETWEEN<PHONE_NUMBER> AND<PHONE_NUMBER>
GROUP BY dimension1
LIMIT 100000

I guess the objective of this query  is to get the different values of  dimension1, because my  detection is configured to split by dimension1.
The result  of the query is [value1, value2,value3]
Notice that here the endTime is<PHONE_NUMBER> = 13 October 2020 18:00:00, which seems to corresponds to the cron time.
Finally on 2020-10-13 18:00:30.041758 UTC:
SELECT date, COUNT(metric1)
FROM dataset
WHERE UNIX_SECONDS(date) BETWEEN<PHONE_NUMBER> AND<PHONE_NUMBER>
AND metric1 IN ('value1')
GROUP BY date
LIMIT 100000

The objective of this query is to get the  data for the anomaly detection.
Here the endTime is<PHONE_NUMBER>   = 14 October 2020 00:00:00 !
Problem

14 October is bigger than the observed max date
13 October would not be correct, because at the time the  job is running  (6pm on 13 October),  the data is not complete for 13 October, so it does not  make sense to compare it to  previous daily data (between is inclusive)

--> The correct value I was expecting was 12  October.
This problem (if the implementation is the same) may not be specific to Days granularity or date-precision-only column:

for hours granularity: computing at  16:30 the 16:00 metric will  have the same problem
for datetime column: in my example, most_recent_data_time would  have been 2020-10-13 15:00:00   --> same  problem after I guess

Behavior I would expect:
something like unix_millis(floorBy(most_recent_data_time, timeUnit)) -1
with floorBy a function rounding to the closest smaller timeUnit, and -1  because the between clause is inclusive.
eg1:
most_recent_data_time=13 October, granularity is Days:
--> return  12 October 23:59:59.999
eg2:
most_recent_data_time=13 October 16:30, granularity is Hours:
--> return  13 October 15:59:59.999
Did I miss something in the config ?
Resources
The problem was first discussed on slack: https://apache-thirdeye.slack.com/archives/CGS41AV7T/p1602499674017100

Closing third-eye related issue as the project has been moved out of the pinot repo. For unsolved issue that still applies, please create a new one under third-eye repo: https://github.com/project-thirdeye/thirdeye


Support minimum and maximum protocol version

If for nothing else, they are needed when doing a regression test

This is simply a port of #5662 to master

dito ;-)

Merged.
43110de041b77aef08bf744cba9330969895a321 Support "-min_protocol" and "-max_protocol" in s_server and s_client
2e2faa8c4802f2fcecea699ddda246929b2ca329 In TLSProxy::Proxy, specify TLSv1.3 as maximum allowable protocol
7d7f6834e542e53f604b46a72d57fad773d4b2bc Enhance ssltestlib's create_ssl_ctx_pair to take min and max proto version

Thank you!

 It built fine with Travis here...
I'll like in a few...


test: update node.js versions

:tada: This PR is included in version 2.5.1 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


GH-2878 updated code examples and getting started tutorial

GitHub issue resolved: #2878
Briefly describe the changes proposed in this PR:

updated getting started tutorial and associated code examples
updated maven/eclipse tutorial and screenshots

Screenshot of new getting started tutorial:

Screenshot of new maven/eclipse tutorial:

PR Author Checklist (see the contributor guidelines for more details):

[x] my pull request is self-contained
[ ] I've added tests for the changes I made
[x] I've applied code formatting (you can use mvn process-resources to format from the command line)
[x] I've squashed my commits down to one or a few meaningful commits
[x] every commit message starts with the issue number (GH-xxxx) followed by a meaningful description of the change
[x] every commit has been signed off

Looks good. Added a couple of comments.

I"ll merge this now - if we want to adjust formatting again or add more extensive examples we can do it in a followup.


Getting "Killed" error

I've tested with a 5-minute video and it worked properly, however when I tried on a 1h30min video (800Mb) I get the Killed message.
Is there a way to fix this?
What's the maximum video length I can use?
jumpcutter -i espirito.mp4 -o out.mp4
Running with the arguments:
Namespace(bitrate=None, codec=None, cut='silent', duration_threshold=0.5, failure_tolerance_ratio=0.1, input=PosixPath('espirito.mp4'), magnitude_threshold_ratio=0.02, min_loud_part_duration=-1, output=PosixPath('out.mp4'), silence_part_speed=None, space_on_edges=0.1)
------------------------------------------------------------
Killed

Thank you in advance

Hi! I guess RAM in your machine wasn't sufficient to process the video. After you run the script, could you check your RAM usage? If this is the problem, I am afraid the only solution would be to use a machine with higher RAM.

Thank you. I have 16Gb, so I've restarted the computer to clear some RAM and increased the swap file size in order to avoid any issue and it solved it.


added badges and travis build file

I'm guessing the failing Travis is not something that we should be worried about in this PR, right?

Sadly it is, for some reason the jacoco coverage reports aren't being generated. I think it might be because of how this project overrides the failsafe plugin, I'll look into it and update here.

I've removed coveralls temporarily, will submit a separate PR for sorting out the coverage reports.


v1.0.1

Changes

stack.go around line 1928

Use Stack.IsInit and Condition.IsInit instead of ok variables respectively, which are now shadowed
This resolves a panic reported within go-aci v1.0.1

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (452e4cc) 99.38% compared to head (2aa8466) 99.38%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main       #6   +/-   ##
=======================================
  Coverage   99.38%   99.38%
=======================================
  Files           6        6
  Lines        2915     2929   +14
=======================================
+ Hits         2897     2911   +14
  Misses         14       14
  Partials        4        4

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Clarify RC vs. Blazor distinctions

Check lead-in content.
Clarify component references (or only refer to components by name, not file name. :+1:).

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: e9063eb3-fb65-45ed-2e3d-a7cf1354d523
Version Independent ID: 84390f51-2206-8269-221b-5a20726dab76
Content: Build your first Razor Components app
Content Source: aspnetcore/tutorials/build-your-first-razor-components-app.md
Product: aspnet-core
GitHub Login: @guardrex
Microsoft Alias: riande

I examined the content, and this isn't viable at this time. This will be resolved when Blazor goes to the .razor extension. Let's hold off for now.


Deployment / Architecture Documentation

Provide robust logging documentation explaining that Scale requires ElasticSearch to be set up separately and direct the user to ElasticSearch's docs for more details. Explain the use of the DEPLOY_LOGGING, SCALE_ELASTICSEARCH_URL, SCALE_LOGGING_ADDRESS, and LOGSTASH_DOCKER_IMAGE environment variables.

We need to migrate a bunch of the deployment details and specifics of how Scale exists within DC/OS to the documentation from the README. Logging is just one part of that. We need to cover the following things at a minimum:

What the primary architectural components of Scale are.
What external dependencies we have.
Minimal testing configurations vs optimal production configurations.
Detail on the available Docker environment variables and what they actually mean.

Add some documentation pertaining to getting a development environment up and running.


There's no listed method on how to revert MS Store issue

Thanks for your work.
While I've ran the script and understood the constraints - there doesn't seem like an 'optional' area where the public can opt-in/opt-out to service breaking changes.
While I think running this script is imperative to privacy - there doesn't seem to be documentation relating to 'caveats' where one can run the script and then later re-enable the services they want.
I would suggest that the ordinary home user not use this script - as there doesn't seem to be options available to them to opt-out, not repair or fix what this script implements.
There tends to be issues relating to thing like using chocolatey or MS store, that this repository doesn't explain clearly how to revert nor give the option to opt-out of. I would think these be covered in the readme.md.
In light of that - I hope others read this and don't use the script. This isn't designed for personal use - intent seems to be more corporate or business oriented. While I understand it is covering the standards - it doesn't help those trying for better privacy with options. Looks like this is one way or the high-way.

My issue pertains to being able to use the MS Store - post implementation of the script.
I receive a 'Try that again', 'Page could not be loaded. Please try again later." message with error Code: 0x80131500.

Thanks for your work.
While I've ran the script and understood the constraints - there doesn't seem like an 'optional' area where the public can opt-in/opt-out to service breaking changes.

We appreciate your concerns. We've made this script as configurable as we can reasonably manage.
This is why you can opt in and out to categories of configurations as a whole.
https://github.com/simeononsecurity/Windows-Optimize-Harden-Debloat#manual-install
However this script makes tens of thousands of changes. It would be impractical to do keep track of states of the configurations from both sides.

While I think running this script is imperative to privacy - there doesn't seem to be documentation relating to 'caveats' where one can run the script and then later re-enable the services they want.

This is very much untrue. We've documented some of the issues that users have run into and how to resolve them in the readme by linking to the issues in which they were resolved or by warning people of certain unsupported configurations.
https://github.com/simeononsecurity/Windows-Optimize-Harden-Debloat#additions-notable-changes-and-bugfixes
https://github.com/simeononsecurity/Windows-Optimize-Harden-Debloat#notes-warnings-and-considerations
It should be said, that privacy and security come with compromises. We strive to break as few things as possible. However there are some things that can not exist and still have privacy or security.

I would suggest that the ordinary home user not use this script - as there doesn't seem to be options available to them to opt-out, not repair or fix what this script implements.

Generally speaking yes, home users shouldn't use this. For these configurations to work as expected, you need to be running Enterprise or at least Professional versions of windows. Home edition will be missing the majority of the configurations. Most "at home" users will be running Windows Home or "N" editions, which aren't supported.  Additionally, anyone running this script needs to be capable of reading the readme, able to test the script on a system that isn't their primary, and capable of basic troubleshooting if they do run into issues.
Additionally we should repeat
_This is why you can opt in and out to categories of configurations as a whole.
https://github.com/simeononsecurity/Windows-Optimize-Harden-Debloat#manual-install_

There tends to be issues relating to thing like using chocolatey or MS store, that this repository doesn't explain clearly how to revert nor give the option to opt-out of. I would think these be covered in the readme.md.

The issues with the MS store Chocolatey are documented in their respective issues.
https://github.com/simeononsecurity/Windows-Optimize-Harden-Debloat#additions-notable-changes-and-bugfixes

In light of that - I hope others read this and don't use the script. This isn't designed for personal use - intent seems to be more corporate or business oriented. While I understand it is covering the standards - it doesn't help those trying for better privacy with options. Looks like this is one way or the high-way.

While I appreciate your concerns, we disagree. We do implement a lot of corporate and business security configurations, but we have scripts specifically tailored to that demographic. We agree that this script isn't for everyone. Again, Privacy and Security come with compromises.  At a bare minimum we expect you to read the readme and be capable of testing this script before running it on your primary machine. If you can't do that, we can't say that your our intended demographic with this script.
Lastly, we should note that hardening is usually the cause of most peoples issues. We also maintain a separate version which only contains the debloat and privacy configurations, no hardening. https://github.com/simeononsecurity/Windows-Optimize-Debloat


Update to 0.7.0

Hey guys,
This PR has update to 0.7.0, although I've experienced an issue with it.
Basically, it didn't allow me to login to admin interface, although front-end was working fine.
The solution I come up with was to set secret field in clients table in the database to not_available for both Admin and Frontend clients.
Thanks

Just got an update on this: https://github.com/TryGhost/Ghost/issues/5837
I would recommend not to update to 0.7.0 until this issue will be resolved.
Or, update, but make sure you follow instructions here: https://github.com/TryGhost/Ghost/issues/5815

@coreydaley looks like this one is ready to be merged


fixed text wrapping for category and name

With longer attendee names or categories names, text was cut out, this update fixes this problem

Hi @michalzubkowicz
thank you for the PR!
Can you please give us some examples of problematic texts? Or a screenshot "before / after" your modification?
This would help us evaluate your modification
Thank you in advance!

I don't have "before" screenshot, and I've got some problems running environment to provide one, but I've found and uploaded "after".
Before the change these texts didn't wrap properly.
Documentation:
https://docs.nativescript.org/api/class/Label#textwrap

Merged, thank you! :+1:


Make optsActivityWindow a protocol parameter

The minimum sane value should be MinCommittableAge. It's currently a parameter in the SeatManager implementation.

This is a dup of #519