feature request: ability to create reducer/action creators for a single form with a form-specific action type prefix

I figured out this pattern after a year and a half of banging my head against a wall with janky patterns in my own apps.  It was a facepalm moment.  It took about as long for the pattern to show up in the recipes section of the official Redux docs.
This need not replace the current method of having form state live at state.form.<form name> or wherever; it could just be an alternative choice.
For example, allow the user to create a separate reducer for each form with its own action type prefix:
const reducer = combineReducers({
  profileForm: formReducer('@@profileForm/'), // this reducer responds to @@profileForm/FOCUS etc. actions
  loginForm: formReducer('@@loginForm/'),  // this reducer responds to @@loginForm/BLUR etc. actions
})

const ProfileForm = reduxForm({actionTypePrefix: '@@profileForm/', getFormState: state => state.profileForm})((props) => (
  <form>
    ...
  </form>
))

const LoginForm = reduxForm({actionTypePrefix: '@@loginForm/', getFormState: state => state.loginForm})((props) => (
  <form>
    ...
  </form>
))

Advantages:

redux-logger output is more readable -- now instead of seeing @@redux-form/FOCUS for all forms and having to look at the meta to see which form they're for, you see @@profileForm/FOCUS and @@loginForm/FOCUS in the log
more flexibility in where the state for each form lives in redux

Disadvantages:

hooking up a form component takes a bit more work

Wow. This is certainly not a trivial task... would add too much complexity to make it worth.

If user wants to listen to any Redux Form action, it needs to know its prefix;
Redux Form would need to export the default prefix (for those who don't want to customize it) + maintain a list of all action types without prefix;
Every action creator would take an extra parameter to customize the prefix

It's also a breaking change, so even if @erikras considers it, you won't be seeing it before v7.

I didn't explain myself well I guess...

I'm proposing this as an extra option in addition to the current way of doing things rather than a breaking change
There are easier ways to handle the prefixing than what you imagine.  (The reusable reducers recipe I linked to provides a good example). I'll type up an example of how it would work later when I'm with my computer.

This is how it would all work.  Hell, I should just start working
on a PR...would be pretty easy actually.
actions.js
import mapValues from 'lodash.mapvalues'

export function createFormActionCreators(customizeActionType) {
  const MY_ARRAY_INSERT = customizeActionType(ARRAY_INSERT)
  const MY_ARRAY_MOVE = customizeActionType(ARRAY_MOVE)
  const MY_ARRAY_POP = customizeActionType(ARRAY_POP)
  // ...

  return {
    arrayInsert: (field, index, value) =>
      ({ type: MY_ARRAY_INSERT, meta: { field, index }, payload: value })

    arrayMove: (field, from, to) =>
      ({ type: MY_ARRAY_MOVE, meta: { field, from, to } })

    arrayPop: (field) =>
      ({ type: MY_ARRAY_POP, meta: { field } })

    // ...
  }
}

// Recreate the existing action creators using the above function.
const defaultActionCreators = mapValues(
  // add `@@redux-form/` prefix
  createFormActionCreators(actionType => `@@redux-form/${actionType}`),
  // wrap action creators to accept `form` as first argument, and
  // put `form` in `action`s' `meta`
  actionCreator => (form, ...args) => {
    const action = actionCreator(...args)
    if (!action.meta) action.meta = {}
    action.meta.form = form
    return action
  }
)

const {arrayInsert, arrayMove, arrayPop, ...} = defaultActionCreators

// Export default `@@redux-form` action creators just like before
export {arrayInsert, arrayMove, arrayPop, ...}

reducer.js could be modified like so.  Fortunately, createReducer already creates a reducer that operates directly
on a single form state.
const createReducer = structure => {
  const {
    deepEqual,
    empty,
    getIn,
    setIn,
    deleteIn,
    fromJS,
    keys,
    size,
    splice,
    customizeActionType = actionType => `@@redux-form/${actionType}`,
  } = structure

  // ...

  const MY_ARRAY_INSERT = customizeActionType(ARRAY_INSERT)
  const MY_ARRAY_MOVE = customizeActionType(ARRAY_MOVE)
  const MY_ARRAY_POP = customizeActionType(ARRAY_POP)
  // ...

  const behaviors = {
    [MY_ARRAY_INSERT](state, { meta: { field, index }, payload }) {
      return arraySplice(state, field, index, 0, payload)
    },
    [MY_ARRAY_MOVE](state, { meta: { field, from, to } }) {
      const array = getIn(state, `values.${field}`)
      const length = array ? size(array) : 0
      let result = state
      if (length) {
        rootKeys.forEach(key => {
          const path = `${key}.${field}`
          if (getIn(result, path)) {
            const value = getIn(result, `${path}[${from}]`)
            result = setIn(result, path, splice(getIn(result, path), from, 1))      // remove
            result = setIn(result, path, splice(getIn(result, path), to, 0, value)) // insert
          }
        })
      }
      return result
    },
    [MY_ARRAY_POP](state, { meta: { field } }) {
      const array = getIn(state, `values.${field}`)
      const length = array ? size(array) : 0
      return length ? arraySplice(state, field, length - 1, 1) : state
    },
    // ...
  }
  // ...
}

With this you could use createReducer directly to get a reducer that responds to custom action types and only operates on a single form.
(Or we could export wrappers that pass in the rest of the structure) for Immutable and non-immutable state.)


[CircleGraph] Enable retainContextWhenHidden

This will add retainContextWhenHidden option to revent reloading models.
ONE-vscode-DCO-1.0-Signed-off-by: SaeHie Park<EMAIL_ADDRESS>

from https://github.com/Samsung/ONE-vscode/issues/520#issuecomment-1123083990


Warning appearing for MQTT Connections

Hi There,
I'm getting a strange anomaly in the debug and log for all MQTT connections (tried 2 servers so far, they're both the same.).
I've narrowed it down to the the MQTT input, other Nodes aren't causing it, but cannot figure out what is causing it.
On the MQTT server side, I can see the connection being established fine.
I'm running version v0.13.4
This appears to have started overnight.
log:
28 Mar 23:50:56 - [info] Server now running at http://<IP_ADDRESS>:1880/
28 Mar 23:50:56 - [info] Starting flows
28 Mar 23:50:56 - [info] Started flows
29 Mar 00:13:14 - [info] Stopping flows
29 Mar 00:13:14 - [info] Stopped flows
29 Mar 00:13:14 - [info] Starting flows
29 Mar 00:13:15 - [info] Started flows
29 Mar 00:13:15 - [warn] Communication send error: Error: not opened
29 Mar 00:13:16 - [info] [mqtt-broker:7470c6d4.677748] Connected to broker: mqtt://test.mosquitto.org:1883
29 Mar 00:13:16 - [warn] Communication send error: Error: not opened
29 Mar 00:13:17 - [warn] Communication send error: Error: not opened
29 Mar 00:13:19 - [warn] Communication send error: Error: not opened
29 Mar 00:13:20 - [warn] Communication send error: Error: not opened
and on....

I know you popped up on Slack with the same question, but I don't think we fully resolved it.
That comms message is related to the websocket connection between the runtime and editor. Where are you running? Is it on a local machine or cloud-hosted server?
Whilst we can add some error handling to avoid trying to write to a closed connection, I want to understand how it has got into this state - we already have code to tidy up closed sockets. Any background info you could add would be helpful.

(slack/mailing list... it was one of those...)

@knolleary
It was in Slack.
I don't think it's resolved at all as It's still occurring.
It is on a cloud hosted (Azure-Ubuntu 14.04) server.
I have no idea how it started, It literally happened overnight and when nothing was being done to the servers.
I've tried other Brokers and the same issue occurs. As soon as I remove the MQTT Node from the workflow completely, the message stops.

not sure if I'm hijacking or not, but I started getting the same error when I enabled authentication for node red administration.  Wanted to open up node-red to the outside world - uncommented the adminAuth section in settings.js.  I was then able to login succesfully with my user/pass but started getting those same messages.  I went back and commented out that section again, restarted and the errors went away.  Everything worked perfectly even when the warnings were appearing.
I am on a Raspberry Pi 2:
Welcome to Node-RED
22 Apr 14:45:03 - [info] Node-RED version: v0.13.4
22 Apr 14:45:03 - [info] Node.js  version: v0.12.9
22 Apr 14:45:03 - [info] Linux 4.1.7-v7+ arm LE

@jschuryk not been able to track this one down yet, but your comment is useful, so thanks!

@jschuryk did you reload the editor in your browser after enabling adminAuth?

I now understand the apparent link to the MQTT nodes.
When an MQTT node connects, it sends a status message over comms to indicate this state. The message is set so that whenever an editor's comms link connects, it will get republished so the editor's view is up to date.
Now, for some reason, the websocket connection is in a bad state. When the editor connects, we publish the state message and fail the connection. The editor attempts to reconnect 1 second later and the cycle repeats.
The question is then why have we received a new websocket connection event but the websocket is not ready for writing to.

My initial answer would have been 'of course I reloaded', however I just performed the test again, and coming up from a fresh browser session, I don't see the error messages.
Jerry

Any epiphanies on this topic since last month?  I have the same problem.  My MQTT pub and sub nodes are functional, but I get the warning above once per second on the node window and in the debug window.  Like the above, this started when I enabled basic authentication in settings.js, and also have a flow containing an MQTT config node.

Somehow it stopped coming up for me and I have no clue how/why. I think
maybe it could have been on the sub node.
I'll have a play with it this weekend as I think maybe I bypassed the sub
stage of the project in working on and decided to come back to it later.
On Saturday, 28 May 2016, nsw935<EMAIL_ADDRESS>wrote:

Any epiphanies on this topic since last month? I have the same problem. My
MQTT pub and sub nodes are functional, but I get the warning above once per
second on the node window and in the debug window. Like the above, this
started when I enabled basic authentication in settings.js, and also have a
flow containing an MQTT config node.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/node-red/node-red/issues/851#issuecomment-222273322,
or mute the thread
https://github.com/notifications/unsubscribe/AF2VzkvOtMcCkYs6s6Hn-q_xNV6ZjXa2ks5qF3x6gaJpZM4H6TLg
.

Would like to know if this is still an issue with the latest 0.14.6 release.

This is still an issue for me and I do get it after enabling adminAuth.

Just stumbled across this issue also, again as @kriztoph mentioned, if I disable adminAuth it goes away.

Also getting this issue as soon as adminAuth is turned on.

Hi, also getting the "Communication send error" after enabling adminAuth.
Flow includes johnnyFive nodes (GPIO access) on RPi so I have to run node-red as root, if that helps any. warnings start as soon as node-red starts even without editor or dashboard open on browser

To add on what atsakir said, my installation does NOT use GPIO at all... Everything still seems to WORK right, I just get the flood of warnings. Willing to enable whatever logging, etc., would help here to diagnose.

I am having the exact same issue after enabling auth on mosquito...  Disable auth and errors stop, the connection is  establishing as I can see normal MQTT traffic in between the error messages.

OK...  this is what I have found out, for my issue anyway...  going over the thread and seeing that @knolleary had asked if the browser was closed between getting this error, it got me thinking.  I normally have node-red ui open at my office remotely and my home computer.  I shutdown node-red, closed my browser, enabled auth on mosquito, opened the node-red config and just changed my ui port to make sure anywhere else I had the ui open was unable to connect and started everything back up.  NO WARNINGS..   None...

I've also got the same issue when enabling auth.  Disabling also stops the errors.

I realise it's a closed issue, but... Over the past few days I've been seeing this error popping up in my debug pane too, with 0.18.4 hosted on Azure using the https://github.com/jmservera/node-red-azure-webapp method. MQTT broker is CloudMQTT, adminAuth is enabled. I'm using websockets between a ReactJS web app and Node-Red too, though this is a new feature added only in the past couple of weeks so could conceivably have contributed. I've been running Node-Red this way for almost a year now, starting at v0.16.2, and have never seen this error before the last couple of days. Happy to provide any additional information that might help nail it down.


Why is no one merging PRs?

https://supermarket.chef.io/cookbooks/wordpress shows not updated since 2015
The Fork network shows many many variations of this repo.
Does no one care any more?

Last merge was  Nov 24, 2014
#73 #72 #71 #70 #69 #68 #67 #65 #63 #59 #57 #54

It seems really no-one cares.

If you're interested in maintaining and would like to be a contributor, let me know and we can chat.

@brint let's chat I've got a vested interest in keeping this cookbook alive.

Thanks for the email @Sauraus, I'll post an update to the issue for everyone once we chat!

We're having a Google Hangout at 5PM CST on Tuesday, February 7th. If anyone else is interested in helping maintain or contribute on an ongoing basis, let me know.

@Sauraus has been added as a contributor. He'll be sending over some PRs and helping to maintain this.

@mrjcleaver I will be looking at all those PRs as soon as I have my clean up work ready to go.

Doesn't seem like the issue is fixed ?

@Sauraus any idea when you are going to work on this?

this cookbook would be awesome. but I can't get it to install on RHEL 7.3 /mariadb / nginx...... :( any suggestions?


Revert "Uses install_requires in setup.py, fixes #27"

Hi @PEPEInvest could you explain why this change is required?
I actually added this install_requires because we couldn't install the package otherwise, see https://github.com/corpetty/py-etherscan-api/issues/27

I haven't testing this myself, so I can't merge. I won't have time to test until next week either.  Anyone have any input on this?

Well it's quite easy to test, but it doesn't work, that's why I asked, why he proposed that revert (from one of my previous PR).
See:
$ pip install https://github.com/PEPEcoin/py-etherscan-api/archive/revert-28-feature/setup_install_requires.zip
Collecting https://github.com/PEPEcoin/py-etherscan-api/archive/revert-28-feature/setup_install_requires.zip
  Downloading https://github.com/PEPEcoin/py-etherscan-api/archive/revert-28-feature/setup_install_requires.zip
     | 30kB 325kB/s
    Complete output from command python setup.py egg_info:
    Traceback (most recent call last):
      File "<string>", line 1, in <module>
      File "/tmp/pip-req-build-yvjo8lwu/setup.py", line 13, in <module>
        'requests==2.18.4',
      File "/usr/lib/python3.6/distutils/core.py", line 108, in setup
        _setup_distribution = dist = klass(attrs)
      File "/tmp/trash/venv/lib/python3.6/site-packages/setuptools/dist.py", line 370, in __init__
        k: v for k, v in attrs.items()
      File "/usr/lib/python3.6/distutils/dist.py", line 253, in __init__
        getattr(self.metadata, "set_" + key)(val)
      File "/usr/lib/python3.6/distutils/dist.py", line 1207, in set_requires
        distutils.versionpredicate.VersionPredicate(v)
      File "/usr/lib/python3.6/distutils/versionpredicate.py", line 114, in __init__
        raise ValueError("expected parenthesized list: %r" % paren)
    ValueError: expected parenthesized list: '==2.18.4'

    ----------------------------------------
Command "python setup.py egg_info" failed with error code 1 in /tmp/pip-req-build-yvjo8lwu/

So yes I don't really understand that pull request, I'd like to know more.

Let´s  Go

once again, please provide explanation and reasoning.


Missing support for the -strict flag

Hello,
I think that it would be nice to include support for the ct -strict flag. That would fail the build in case any warning is detected by ct.
If you are okay with this I can submit a PR including it.
Thanks,

Added in https://github.com/poseidon/terraform-provider-ct/pull/53


Strengthens and clarifies questions about shelter, updates related files

A lot of our questions have toggles in a way that is confusing. I'm converting some questions to behave slightly differently. Also, the way some of these properties are stored and used can be made more efficient now that we know a little more about how we need to use them.

Welp, this has gone pear-shaped with the other merges, so I'm redoing it. Keeping this here for now.

This should be ready again. Whew.


0.1.15-beta.0 regression in ssr with initialData: staleness thing doesnt refetch. works fine in 0.1.15

as described, will add a demo asap

the problem for us is that in 0.1.16 initialData is behaving more or defaultData or fallbackData

PR with a code https://github.com/iamstarkov/swr/pull/2
notice how Pokemon profile doesnt change https://zeit-swr-230-demo.iamstarkov.now.sh/demo
with a workaround it does change https://zeit-swr-230-demo.iamstarkov.now.sh/workaround

workaround in the meantime:
const useFixedSWR = (key, fetcher, {initialData, ...config} = {}) => {
  const initial = React.useRef(initialData);
  React.useEffect(() => {
    if(key){
      initial.current = undefined;
    }
  }, [key]);
  return useSWR(key, fetcher, {...config, initialData: initial.current});
}

the problem doesnt exist in 0.1.15

PR with a code https://github.com/iamstarkov/swr/pull/3
notice how Pokemon profile does change https://zeit-swr-230-demo-0115.iamstarkov.now.sh/demo

Looks like regression was introduced in 0.1.15-beta.0

PR with a code https://github.com/iamstarkov/swr/pull/4
notice how Pokemon profile does not change anymore zeit-swr-230-demo-0115.iamstarkov.now.sh/demo

this is the diff https://github.com/zeit/swr/compare/0.1.15...v0.1.15-beta.0

#211 is also in the diff, so maybe maybe

#211 with #186 are both in the diff, so i dunno

I think this PR is issue is not well formatted and described. It might make sense to open a new one with a concise description and not clutter it with references.

I dont agree that is "not well formatted and described". Following sentence describes the problem perfectly:

the problem is that in 0.1.16 initialData is behaving more or defaultData or fallbackData

in regards to reference, I dont control em


feat: support the allowedAttributeAssignments X.509v3 extension

This PR adds support for the allowedAttributeAssignments X.509v3 extension defined in ITU-T Recommendation X.509 for usage in attribute certificates.
allowedAttributeAssignments EXTENSION ::= {
  SYNTAX         AllowedAttributeAssignments
  IDENTIFIED BY  id-ce-allowedAttributeAssignments }

AllowedAttributeAssignments ::= SET OF SEQUENCE {
  attributes              [0]  SET OF CHOICE {
    attributeType           [0]  AttributeType,
    attributeTypeandValues  [1]  Attribute{{SupportedAttributes}},
    ... },
  holderDomain            [1]  GeneralName,
  ... }

Checklist

[x] documentation is added or updated
[x] tests are added or updated

This PR is ready for review. I believe the style validation failure is in error.

Rebased on master, and the new symbols have been added to the HISTORY section of their respective documentation.

@nhorman would you care to review this?


Don't send language params to TransformFriendlyUrlToQueryString

Fixes #2335
Summary
change variable name

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: Mhtshum sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.

Changes pushed as @daguiler, though attribute already present in AssemblyInfo.cs

I haven't reviewed the full code, but please be aware that the culture code in the URL should be part of the portal Alias and might be modified by the admin (e.g. www.domain.com/en or en.domain.com)

@sleupold Right below there is already a logic, to add again the language code which I try to mention by in comment //810

I think I found a better way to fix this issue. Check this out: #2759

Closing this in favor of the other PR


Raspberry Pi Zero unable to import module

I have:

[x] searched open and closed issues for duplicates

Bug description
Steps to reproduce

run python3 -m pip install python-escpos
run python3
type from escpos.printer import Serial
the following error outputs:

root@rpi0w:~# python3
Python 3.7.3 (default, Jan 22 2021, 20:04:44)
[GCC 8.3.0] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> from escpos.printer import Serial
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/usr/local/lib/python3.7/dist-packages/escpos/printer.py", line 21, in <module>
    from .escpos import Escpos
  File "/usr/local/lib/python3.7/dist-packages/escpos/escpos.py", line 25, in <module>
    from escpos.image import EscposImage
  File "/usr/local/lib/python3.7/dist-packages/escpos/image.py", line 17, in <module>
    from PIL import Image, ImageOps
  File "/usr/local/lib/python3.7/dist-packages/PIL/Image.py", line 89, in <module>
    from . import _imaging as core
ImportError: libopenjp2.so.7: cannot open shared object file: No such file or directory

Device info

Printer: Unbranded (Poslab TP-260, good luck finding anything online)

python-escpos version:
root@rpi0w:~# python-escpos version
Traceback (most recent call last):
  File "/usr/local/bin/python-escpos", line 6, in <module>
    from escpos.cli import main
  File "/usr/local/lib/python3.7/dist-packages/escpos/cli.py", line 25, in <module>
    from . import config
  File "/usr/local/lib/python3.7/dist-packages/escpos/config.py", line 16, in <module>
    from . import printer
  File "/usr/local/lib/python3.7/dist-packages/escpos/printer.py", line 21, in <module>
    from .escpos import Escpos
  File "/usr/local/lib/python3.7/dist-packages/escpos/escpos.py", line 25, in <module>
    from escpos.image import EscposImage
  File "/usr/local/lib/python3.7/dist-packages/escpos/image.py", line 17, in <module>
    from PIL import Image, ImageOps
  File "/usr/local/lib/python3.7/dist-packages/PIL/Image.py", line 89, in <module>
    from . import _imaging as core
ImportError: libopenjp2.so.7: cannot open shared object file: No such file or directory

python version: 3.7.3
operating system:
root@rpi0w:~# uname -a
Linux rpi0w 5.10.60+ #1449 Wed Aug 25 14:59:20 BST 2021 armv6l GNU/Linux
root@rpi0w:~# lsb_release -a
No LSB modules are available.
Distributor ID: Raspbian
Description:    Raspbian GNU/Linux 10 (buster)
Release:        10
Codename:       buster

Just ran these two commands:
apt install libopenjp2-7
apt install libtiff5

Now I get this error:
root@rpi0w:~# python3
Python 3.7.3 (default, Jan 22 2021, 20:04:44)
[GCC 8.3.0] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> import escpos.printer as Serial
Illegal instruction

:(

The issue with libopenjp2 seems to be something in your distro. (At least I don't know that issue)
The error message Illegal instruction seems to be the result of a segfault or something similar to me. (So it means that a C lib fails, which should not be the case if your distribution is OK. If it would fail in Python, we should get a stack trace by default)
What you can try is:

install a pre-release version with the pip switch --pre and check if the issue persists
Check if it is an issue with one of the libraries that are used by opening a python shell and importing manually the libraries that are used and ultimately reproducing the constructor of the Serial class. Then you should see when it fails. Since you are just importing in your code and not even calling anything, I suspect it will already segfault during import.
you could try to obtain a stack trace with gdb. This way we might pin down where the issue comes from.


[Bug]: Component, containing a Modal, if rendered by key prevent opening and closing animation

Contact Details
<EMAIL_ADDRESS>What happened?
If the component rendering the modal is mounted/unmounted through a key, the mounting/unmounting process could prevent the opening/closing animations of the Modal component.
This occurs if the Modal tries to open on the first render or reset its key in the onClose callback.
One way to prevent the issue is to set the open state in the useEffect and reset the key in the onAfterClose callback.
That will ensure the component is already mounted before triggering the opening animation and that the component can be unmounted after the animation.
The following gif shows the difference between the usual behavior (no key) and the problematic one (with key).

Component
Modal
Component Version
1.2.3
Which browsers are you seeing the problem on?
Microsoft Edge
Mobile Device
No response
Relevant log output
No response

This issue has been fixed. Check the stories of the Modal in the design system to see how modals work with keys.
https://igloo.officevibe.design/storybook/?path=/docs/components-modal--overview


Inconsistent File Path Separator Display in Drivechain Launcher on Windows 10

Description
The Drivechain Launcher on Windows 10 is displaying file paths with forward slashes (/) instead of the expected backward slashes (\) for Windows file systems. This inconsistency might lead to confusion or issues when users copy and paste these paths in environments that expect the typical Windows path format.
Environment

OS: Windows 10
Launcher Version: 1.2.0
Component: File path display

Steps to Reproduce

Open the Drivechain Launcher.
Navigate to the 'Settings' to view the 'Application Data Directory' and 'Drivechain Data Directory' paths.
Observe the format of the file paths displayed.
Go to the 'BitAssets Info' section and observe the file paths displayed there.

Expected Behavior
File paths should display with backward slashes (\) as is standard on Windows.
Actual Behavior
File paths are displayed with forward slashes (/).
Screenshots

Additional Context
While this has not yet led to any operational issues, it is a deviation from standard Windows path conventions and may cause problems when paths are used in Windows Explorer or command-line interfaces.

On it.

Got it. Pushed. Gonna merge.


Training utilities for custom training loops (progress bar and timer)

Add some training utilities for #2252. This PR supports the progress bar functionality of ProgressBar to be used without requiring the usage of Trainer. A TimerUtility has also been added which allows the printing of training updates or other actions to be triggered at a specified rate, such as every x seconds for example.
Since the existing ProgressBar requires a Trainer object but shared code with this progress bar, the common code has been moved into a new class, ProgressBarPrinter, to avoid code duplication.
Since I suspect the functionality and/or API is still likely to change, I have marked as experimental.
Other utilities such as those provided as trainer extensions can be added later as separate PRs.
The existing "custom training loop" examples for MNIST, CIFAR, and ptb have been modified to use either the new TimerUtility or the timer-based progress bar, IteratorProgressBar.

Thank you for the feedback and sorry for the delay. I am preparing a PR for ProgressBarPrinter and plan to submit soon. I am fine with chainer.utils if you think it is a suitable place to put it. I am not sure I understand your inheritance concern with TimerUtility, but I will think about it.


[todo list] v1 stable

This is a todo list for v1 stable

[x] rename PromiseWrapper on iOS because of possible name clashes (we should use some prefix - lets discuss what prefix)
[x] reformat the native code (at least iOS which is inconsistent with 2 and 4 space indents)
[x] think about the return value of signInSilently - now it always resolves, so if there is an error (eg. network error), user cannot learn what kind of error it was
[x] document using the application:openURL:options: method like this: https://stackoverflow.com/a/37007464/2070942, for ios >= 9
[x] improved error messages: PR https://github.com/react-native-community/react-native-google-signin/pull/533
[x] remove this folder and find reasonable way to replace it
[x] flow + TS typings would be nice (PR https://github.com/react-native-community/react-native-google-signin/pull/554)
[ ] jest mock would be nice (PR wip)
[ ] fix bug with iOS native sign in button which remains in pressed state even after the sign in modal is shown

please comment with more ideas / feel free to pick one and give it a go

closing in favor of https://github.com/react-native-community/react-native-google-signin/issues/566


Automated cherry pick of #5143: check scsi driver on add disk

Cherry pick of #5143 on release/3.1.
#5143: check scsi driver on add disk

Codecov Report

:exclamation: No coverage uploaded for pull request base (release/3.1@9a91bf2). Click here to learn what that means.
The diff coverage is 0%.

@@              Coverage Diff              @@
##             release/3.1   #5144   +/-   ##
=============================================
  Coverage               ?   6.75%
=============================================
  Files                  ?     545
  Lines                  ?   95277
  Branches               ?       0
=============================================
  Hits                   ?    6433
  Misses                 ?   88306
  Partials               ?     538

Flag
Coverage Δ

#aFlag
6.75% <0%> (?)

Impacted Files
Coverage Δ

pkg/compute/models/guest_actions.go
0% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9a91bf2...0d64807. Read the comment docs.

/lgtm

/approve

/approve


support multi compose projects & switching

Attempt implement to support switching between existing compose projects
Detect all compose projects by container label "com.docker.compose.project"
Welcome someone will assist to make it done

It's not showing all the projects i have more than 5 projects running but it shows only 1 project running

Projects block hight is not enough, it is why only one project name is visible

How can i increase the height ?

we really need this great patch!!!

I didn't know this was already worked on! I was re-doing all your great work. :sweat_smile:
Is this code ready @sashaaro, if not how can I help? Im greatly interested in helping making this code reach master !

Is this code ready?

as I remember probably it has a few bugs of determination height of project's list block. I would be glad if you will continue my work.

@sashaaro alrighty, thanks for the heads up, I'll gladly try to have this code reach master. Thanks :)


2024-11-18_16-12-42_master-next_aws-cli

Automatically created.

Backport failed for scarthgap-next, because it was unable to cherry-pick the commit(s).
Please cherry-pick the changes locally and resolve any conflicts.
git fetch origin scarthgap-next
git worktree add -d .worktree/backport-10403-to-scarthgap-next origin/scarthgap-next
cd .worktree/backport-10403-to-scarthgap-next
git switch --create backport-10403-to-scarthgap-next
git cherry-pick -x 679d3eb3d68f073f4bc3ef1d4094ef031775b54a

Backport failed for styhead-next, because it was unable to cherry-pick the commit(s).
Please cherry-pick the changes locally and resolve any conflicts.
git fetch origin styhead-next
git worktree add -d .worktree/backport-10403-to-styhead-next origin/styhead-next
cd .worktree/backport-10403-to-styhead-next
git switch --create backport-10403-to-styhead-next
git cherry-pick -x 679d3eb3d68f073f4bc3ef1d4094ef031775b54a


Active Status?

What is the current maintained status of this? I see an issue fix not merged from 7 days ago...

Apologize for this! Did not get the email notification for it weirdly. Merged it. I'm planning to continue this month!

I obviously know I failed to get back to action, don't @ me on this to whoever is seeing


Functionality on stable

It seems like this is nightly only, but it is probably pretty easy to get it working on stable. Here are some workarounds for the nightly features it uses:

pointer_byte_offsets: just cast it back and forth ptr.cast::<u8>().add(...).cast()
stmt_expr_attributes: looks like you only use this to make #[allow(unused_assignments)] ok. You can probably eliminate this attribute and work around it with something like let _tmp_ptr; before the if block then load_unaligned(_tmp_ptr, ...)
core_intrinsics for likely: you may be able to reverse this and get the same effects with stable #[cold] instead. There is also likely_stable which may work. You also might not even need it - not sure if you've benchmarked but iirc, likely doesn't gain as much in recent LLVM versions
stdsimd for _mm_loadu_epi8. I'm unfortunately not really sure what to do here, maybe you could inline assembly it?

Awesome project by the way!

Thank you @tgross35 for your feedback and idea! Having it work on stable is definitely a must, I'll try to address this as soon as I can 😄

Done :)
'avx2' feature will require unstable toolchain however. I don't know if there is a way to have to work on the stable toolchain, but I think that can be addressed later.
I've added you as a contributor in case you want to review.

It seems to also address another usability issue: I am under the impression that stdsimd required users to build with target-cpu=native otherwise performance would be degraded. Anyway it is much better without all these unstable features now, merging this and releasing.
Thanks a lot!

Glad to be of help! Another option is to add a Cargo feature called nightly and gate anything that needs it under #[cfg(feature = "nightly)], with a fallback implementation under #[cfg(not(feature = "nightly))]. Then anyone who needs the highest performance can enable the feature, everyone else can live with the slightly slower stable version.
Thank you for the invitation, I accepted but don't know how I can help - I know about rust mechanics but not so much about the inner workings of hash algorithms. I suppose feel free to ping me if you need a hand figuring something out.


Delays are shown in seconds instead of minutes

Delays are shown in seconds instead of minutes

I also noticed the problem and reported in in Home Assistant Core to the maintainer of the hvv_departures. See https://github.com/home-assistant/core/issues/81088
It seems like that it won't be fixed in Home Assistant Core, because the hvv api returns the delay in seconds. So it's "worked by design", that the delay is returned in seconds. Therefore we have to fix it in the hvv-card.
I will create a PR once the final decision is made in the linked issue.
Actually I don't know, if the PR will be merged, sadly this repository seems unmaintained.


Internal Server Error After Deployment

Hello @MatthiasSchmalz ,
I followed the instruction and deployed all the apps and the CAP service into BTP. But after deployment I am getting the Internal Server error in the HTML5 Application Section. Please help me to resolve teh issue.
https://github.com/shaancse08/Galactic-Spacefarer-Adventure.git is the Repo address and the latest code is in feat-btp-deployment branch.
Best Regards
Avik

Hi @shaancse08,
please check the error logs of your HTML5 app and your CAP service.
To do this go to HTML5 Applications section in the Cloud Cockpit for your sub account. Find the app which shows the error and open the logs for it.
Also go to your CAP application and view the logs for it. Does the request with 500 error reach the CAP service? If yes, what are the details?
Best regards
Matthias


Blazor AAD B2C additional user flows

From @Alienroid ...

I am not sure where to ask this. So Blazor WebAssembly with Hosted AAD B2C authentication is working. However, there’s no documentation or sample code on how to add an userflow.
The examples from blazor server side only configures in startup.cs and it gets configuration from AppSettings.json. That’s the same as Blazor WebAssembly with Hosted (on the server side). However, the client side, we only have program.cs that configures ‘authentication’ so we can use authentication/login in LoginDisplay. However, no idea how we can do that for other userflow. I am not sure if AAD B2C for Blazor WebAssembly is completed or just lack of documentation? Is there some way we can subscribe to the status of the project? Thanks.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: c9942b0a-a7fb-0d34-9201-af0963affa9e
Version Independent ID: 19770710-5225-a1ea-e082-65da6ba4a49a
Content: ASP.NET Core Blazor authentication and authorization
Content Source: aspnetcore/security/blazor/index.md
Product: aspnet-core
Technology: aspnetcore-security
GitHub Login: @guardrex
Microsoft Alias: riande

Good point @Alienroid ... We do need coverage on those scenarios (reset password and edit profile). I suspect we'll end up linking off to Azure docs for details on setting up the userflow on the Azure portal side.

https://docs.microsoft.com/en-us/azure/active-directory-b2c/user-flow-overview
https://docs.microsoft.com/en-us/azure/active-directory-b2c/tutorial-create-user-flows

Presumably, the Blazor app makes an auth request with the userflow policy ID (similar to their Run user flow/Run now links from their portal examples). I'll need to look into that a bit further. Engineering might have baked something into the auth lib to make it easy.

After starting to look a little closer, it looks more like this scenario is going to be handled by an MVC controller. The component hits up the controller endpoint, and the controller takes care of triggering the flow. I'll try to get to this issue next week and see what's what, but that concept seems likely based on how Identity flows for components are generally customized in Blazor Server apps.

Hi Luke,
I think this ask is regarding blazor WASM how to connect to aadb2c edit profile. If the user flow for signup isn't going through mvc controller, why should edit profile going through this route?
I know I've asked on both server side and wasm... I get confused on my asks too :)
On the side note, I rewrote/port most of the areas/identity to blazor based and no longer razor pages. (With exceptions on login, which requires cookie update that cannot be edited from browser ).
Get Outlook for iOShttps://aka.ms/o0ukef

From: Luke Latham<EMAIL_ADDRESS>Sent: Wednesday, April 8, 2020 4:44:25 PM
To: dotnet/AspNetCore.Docs<EMAIL_ADDRESS>Cc: Alienroid<EMAIL_ADDRESS>Mention<EMAIL_ADDRESS>Subject: Re: [dotnet/AspNetCore.Docs] Blazor AAD B2C additional user flows (#17522)
After starting to look a little closer, it looks more like this scenario is going to be handled by an MVC controller. The component hits up the controller endpoint, and the controller takes care of triggering the flow. I'll try to get to this issue next week and see what's what, but that concept seems likely based on how Identity flows for components are generally customized in Blazor Server apps.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com/dotnet/AspNetCore.Docs/issues/17522#issuecomment-611249752, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AH3FBMXZWMFCCAVGSTBJXELRLUD5TANCNFSM4LWRM6MA.

Sorry ... you're right ... my :eye: must have hit the "Blazor Server" wording at the start of the 2nd paragraph. I'll remove the comment and change the title of this issue.

Actually, I won't change the title. User flows aren't covered for Blazor Server either. I have that issue for working on scaffolding and Identity concepts in Blazor Server, but I think AAD B2C user flows will be a separate issue from that one. I'll probably try to work both WASM and Server sides off of this issue.

Thanks Luke.
I look forward to getting aadb2c works so I can migrate all my clients to it 😉
Sent from Mailhttps://go.microsoft.com/fwlink/?LinkId=550986 for Windows 10
From: Luke<EMAIL_ADDRESS>Sent: Wednesday, April 8, 2020 5:45 PM
To<EMAIL_ADDRESS>Cc<EMAIL_ADDRESS><EMAIL_ADDRESS>Subject: Re: [dotnet/AspNetCore.Docs] Blazor AAD B2C additional user flows (#17522)
Actually, I won't change the title. User flows aren't covered for Blazor Server either. I have that issue for working on scaffolding and Identity concepts in Blazor Server, but I think AAD B2C user flows will be a separate issue from that one. I'll probably try to work both WASM and Server sides off of this issue.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com/dotnet/AspNetCore.Docs/issues/17522#issuecomment-611266229, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AH3FBMVV7VQYF22HXQTZU5LRLULBNANCNFSM4LWRM6MA.

For server-side blazor other userflows should be supported out of the box (the default ones). For blazor webassembly, msal.js doesn't support them, so it is up to the developer to implement them.

Thanks Javier. For blazor wasm, is this feature on the roadmap or MSFT just leave it to us? Any particular reason not supported by msal.Js?
Get Outlook for iOShttps://aka.ms/o0ukef

From: Javier Calvarro Nelson<EMAIL_ADDRESS>Sent: Thursday, April 9, 2020 1:37:21 AM
To: dotnet/AspNetCore.Docs<EMAIL_ADDRESS>Cc: Alienroid<EMAIL_ADDRESS>Mention<EMAIL_ADDRESS>Subject: Re: [dotnet/AspNetCore.Docs] Blazor AAD B2C additional user flows (#17522)
For server-side blazor other userflows should be supported out of the box (the default ones). For blazor webassembly, msal.js doesn't support them, so it is up to the developer to implement them.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com/dotnet/AspNetCore.Docs/issues/17522#issuecomment-611406463, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AH3FBMTG4WIJVHSGYYPPVOTRLWCMDANCNFSM4LWRM6MA.

If the packages are added, is GetOwinContext a viable approach for Blazor WASM? For example ...
public void ResetPassword()
{
        HttpContext.GetOwinContext().Authentication.Challenge(
            new AuthenticationProperties() { RedirectUri = "/" }, "{PW RESET POLICY ID}");
}

https://github.com/AzureADQuickStarts/B2C-WebApp-OpenIDConnect-DotNet-SUSI/blob/complete/WebApp-B2C-DotNet/Controllers/AccountController.cs#L32-L33
... or is it really going to be a manual effort to build the challenges (or use a community package of some sort)?

Given how clear their doc is on forming the challenge, I'll just cross-link their doc in a new section of the two AAD B2C topics. For example, the following works ...
https://XXXXX.b2clogin.com/XXXXX.onmicrosoft.com/oauth2/v2.0/authorize?
client_id=11111111-1111-1111-1111-111111111111
&redirect_uri=https%3A%2F%2Flocalhost%3A5001%2Fauthentication%2Flogin-callback
&response_mode=form_post
&response_type=id_token
&scope=openid
&nonce=10636b65-924d-4456-8c58-3610ddf473e9
&state=12345
&p=B2C_1_passwordreset1

@Alienroid Hack'in around with bits and probably creating some 🙈 giant security holes 🙈  ...

Registered a callback in the portal for a password reset: https://localhost:5001/passwordreset-callback

Have a basic password reset user flow: B2C_1_passwordreset1

In LoginDisplay, I hack up a challenge ...
<button class="nav-link btn btn-link" @onclick="ResetPassword">Reset password</button>

...

private void ResetPassword(MouseEventArgs args)
{
    Navigation.NavigateTo("https://XXXXX.b2clogin.com/XXXXX.onmicrosoft.com/oauth2/v2.0/authorize?" +
        "client_id=11111111-1111-1111-1111-111111111111" +
        "&redirect_uri=https%3A%2F%2Flocalhost%3A5001%2Fpasswordreset-callback" +
        "&response_mode=query" +
        "&response_type=id_token" +
        "&scope=openid" +
        $"&nonce={Guid.NewGuid()}" +
        "&state=12345" +
        "&p=B2C_1_passwordreset1");
}

A component to handle the callback (PasswordReset.razor) ...
@page "/passwordreset-callback"
@inject NavigationManager Navigation

@_errorMessage

@_errorDescription

@code {
    private string _errorMessage;
    private string _errorDescription;

    protected override void OnInitialized()
    {
        var state = QueryStringHelper.GetParameter(new Uri(Navigation.Uri).Query, "state");

        if (state == "12345")
        {
            _errorMessage = $"Error: {QueryStringHelper.GetParameter(new Uri(Navigation.Uri).Query, "error")}";

            if (_errorMessage == "")
            {
                Navigation.NavigateTo("/");
            }

            _errorDescription = $"Description: {QueryStringHelper.GetParameter(new Uri(Navigation.Uri).Query, "error_description")}";
        }
    }
}

I used the QueryStringHelper from the repo at https://github.com/dotnet/aspnetcore/blob/blazor-wasm/src/Components/WebAssembly/WebAssembly.Authentication/src/QueryStringHelper.cs.

... and those 😵 RexHacks!:tm: 😵 seem to work.
Since it all basically ✨ Just Works!:tm: ✨, I think the new tiny section in each doc can just throw the reader over to the Azure doc for how to build the challenge. If I get feedback that devs are having trouble later, then perhaps we can have some example code along these lines for this scenario.

Thanks for the sample Luke, I got the reset user flow to work!
If I do blazor server side, AADB2C only needs to define one application (in Azure portal) and I can use multiple user flows using the same one. The redirect path is the same for /signin-oidc.
On Blazor WASM, I have to define one app for each user flow (SignInSignOut, ResetPassword, etc) because they have different redirect?
Thanks again.

On Blazor WASM, I have to define one app for each user flow (SignInSignOut, ResetPassword, etc) because they have different redirect?

AFAICT, there would be:

One app.
One app registration in the portal with however many callback paths the app needs.
However many user flows are needed, which can be reused across different apps.

Omg, I can’t believe I sent that out after I validated it. I really shouldn’t stayed up until 5.
Thanks again 😉
Sent from Mailhttps://go.microsoft.com/fwlink/?LinkId=550986 for Windows 10
From: Luke Latham<EMAIL_ADDRESS>Sent: Thursday, April 9, 2020 5:58:58 PM
To: dotnet/AspNetCore.Docs<EMAIL_ADDRESS>Cc: Alienroid<EMAIL_ADDRESS>Mention<EMAIL_ADDRESS>Subject: Re: [dotnet/AspNetCore.Docs] Blazor AAD B2C additional user flows (#17522)
On Blazor WASM, I have to define one app for each user flow (SignInSignOut, ResetPassword, etc) because they have different redirect?
AFAICT, there would be:

One app.
One app registration in the portal with however many callback paths the app needs.
However many user flows are needed, which can be reused across different apps.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com/dotnet/AspNetCore.Docs/issues/17522#issuecomment-611823223, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AH3FBMT6I75RCXXEMQ3NW23RLZVNFANCNFSM4LWRM6MA.
From: Luke<EMAIL_ADDRESS>Sent: Thursday, April 9, 2020 5:59 PM
Subject: Re: [dotnet/AspNetCore.Docs] Blazor AAD B2C additional user flows (#17522)
On Blazor WASM, I have to define one app for each user flow (SignInSignOut, ResetPassword, etc) because they have different redirect?
AFAICT, there would be:

One app.
One app registration in the portal with however many callback paths the app needs.
However many user flows are needed, which can be reused across different apps.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com/dotnet/AspNetCore.Docs/issues/17522#issuecomment-611823223, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AH3FBMT6I75RCXXEMQ3NW23RLZVNFANCNFSM4LWRM6MA.


[AzureBlobStorage] Follow up: Optional Event message indexing (#1462)

Update Configuration for tests: Add isEventMessageIndexingEnabled

Pull Request Test Coverage Report for Build 3805

0 of 0   changed or added relevant lines in 0 files are covered.
497 unchanged lines in 16 files lost coverage.
Overall coverage decreased (-0.1%) to 69.863%

Files with Coverage Reduction
New Missed Lines
%

redis-persistence/src/main/java/com/netflix/conductor/dao/dynomite/RedisExecutionDAO.java
4
80.82%

common/src/main/java/com/netflix/conductor/common/metadata/tasks/TaskDef.java
5
95.61%

redis-persistence/src/main/java/com/netflix/conductor/dao/dynomite/RedisMetadataDAO.java
6
93.75%

cassandra-persistence/src/main/java/com/netflix/conductor/dao/cassandra/CassandraBaseDAO.java
7
93.4%

cassandra-persistence/src/main/java/com/netflix/conductor/cassandra/CassandraConfiguration.java
11
0%

core/src/main/java/com/netflix/conductor/metrics/Monitors.java
12
66.97%

core/src/main/java/com/netflix/conductor/service/MetadataServiceImpl.java
13
76.19%

core/src/main/java/com/netflix/conductor/core/execution/DeciderService.java
14
92.64%

postgres-persistence/src/main/java/com/netflix/conductor/dao/postgres/PostgresExecutionDAO.java
17
77.11%

mysql-persistence/src/main/java/com/netflix/conductor/dao/mysql/MySQLExecutionDAO.java
22
67.77%

Totals

Change from base Build 3795:
-0.1%

Covered Lines:
11491

Relevant Lines:
16448

💛  - Coveralls


Adding public ip address -update on Azure?

The instructions above are not exactly aligned to the steps I can actually take to accomplish this task, that is, I didn't need to separately create a public ip address resource. I was able to do that from the NIC IP configurations blade. Steps:
NIC -> IP configurations -> Add -> Public IP address [Enabled] -> IP Address -> Create new
In addition, the screenshot under the Core steps (https://docs.microsoft.com/en-us/azure/virtual-network/virtual-network-multiple-ip-addresses-portal?source=docs#coreadd) differs from current portal (guess this can be attributed to the continuous updates on Azure)...just a comment on observation.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: b3b4d2d7-88a3-c493-68f9-39c89fbbcf96
Version Independent ID: 6dff4842-197d-9e60-3c80-b34cc6aaab3e
Content: Multiple IP addresses for Azure virtual machines - Portal
Content Source: articles/virtual-network/virtual-network-multiple-ip-addresses-portal.md
Service: virtual-network
GitHub Login: @anavinahar
Microsoft Alias: anavin

@aruwo17 Thanks for the feedback! I have assigned the issue to the content author to evaluate and update as appropriate.

Fix has been checked in.

#please-close


Hopefully fixed bug where rand doesn't work.

Changing this value worked for me.

This worked for me as well! Thanks for taking the time to find this fix!

No problem!


Linting Ursula

Add a yaml linter under /test as well as fix
the small nits that were caught.  Running a linter
against the code makes it more standardized
and easier to read.
What was caught:
too few spaces after comma
trailing spaces
too many blank lines (1 > 0)
too many spaces inside braces
no new line character at the end of file

Can one of the admins verify this patch?

"ok to test" to accept this pull request for testing
"test this please" for a one time test run
"add to whitelist" to add the author to the whitelist

Can one of the admins verify this patch?

"ok to test" to accept this pull request for testing
"test this please" for a one time test run
"add to whitelist" to add the author to the whitelist

closing old PRs


[graphiql] Add cookie-to-header token CSRF support

I would like to have Cookie-to-header CSRF tokens as an default feature in GraphiQL.
I'm working on an Angular based SPA with a Spring Boot backend. GraphiQL can be activated in Spring by simply changing a boolean flag. Sadly, when using Spring Security with CSRF protection to secure my endpoints, GraphiQL cannot be used anymore, because it does not set the X-CSRF-TOKEN nor the X-XSRF-TOKEN header as Angular for example does automatically. Therefore, CSRF protection for the GraphQL endpoint must be disabled when GraphiQL is active.
The only solutions that I found online completely disabled CSRF in Spring. Since I don't want to do that I disabled it on the GraphQL path while developing. This isn't a great solution and if done wrong, it would disable CSRF for GraphQL in production as well. But if I don't do that, than I cannot use GraphiQL out of the box.
So in order to increase the security of future GraphQL endpoints, I would like to request the same CSRF cookie-to-header automation that Angular provides for GraphiQL.

This is already possible, I can provide an example if you like?

Sure, that would be great.

const headers = {}
if (typeof document !== undefined) {
// maybe angular has a utility for accessing cookies?
 const getCookie = name => document.cookie.match(new RegExp(`(^| )${name}=([^;]+)`))?.at(2);
 const value = getCookie('CSRF COOKIE NAME')
 headers["X-CSRF-TOKEN"] = value
}

 const root = ReactDOM.createRoot(document.getElementById('graphiql'));
  root.render(
    React.createElement(GraphiQL, {
      fetcher: GraphiQL.createFetcher({
        url: '/graphql,
      }),
      // pass the headers prop programattically
      headers
    }),
  );

Thanks for the example.
I think I didn't explain my problem well enough, because my main problem is that GraphiQL is provided by Spring without me having access to the HTML that Spring returns. I am thinking about implementing a way to catch the GraphiQL HTML response and modify it (with Spring Webfilters) as workaround including the idea of the example you provided, but it would be a hacky solution.
That's why I opened this issue, because I think others could provit as well if GraphiQL provides this out of the box as Angular does. On the other hand it might be more related to the Spring package not including this in the first place, so maybe my request would be more fitting over there.

@Kaemmelot indeed, it may be best to make this feature request to spring's graphql implementation you are using - usually each framework and/or platform implements it's own client authn for graphiql. there are many flavors, headers and cookie names used, etc. there is a plugin API as well that may be of help


[W4.11e][F11-3]Vignesh Shankar

Features

Added test cases for Util.isAnyNull

Thanks for the input, will keep this in mind!


How to not display pod logs?

I don't want to display the pod log in the main program(because it's too much), i set log level to LogLevelError, but still dispaly logs.
job.SetLogLevel(kubejob.LogLevelError)
Is there a method to prevent the main program from displaying the pod log?

DisableContainerLog() method can solve.


Add missing buildscript classpath configuration

What's changed?
Now capturing the buildscript classpath dependency configuration.
What's your motivation?
I was reminded that this configuration was presently not being captured during the review of https://github.com/openrewrite/rewrite/pull/4376, so this means that the GradleDependency trait fails to match buildscript dependencies.
Anything in particular you'd like reviewers to focus on?
I've moved plugin repositories into the GradleBuildscript nested object. The thought is that this more closely aligns the purposes of the repositories from a code discoverability standpoint and the expectation is for the new style to be non-null. Given current serialized LSTs, there's an internal null check to help make sure to avoid some of the possible NullPointerException cases.
Anyone you would like to review specifically?
@sambsnyd
Have you considered any alternatives or workarounds?

Could potentially add the classpath configuration to the existing nameToConfiguration map, but presently this is tracking project configurations. So by doing so we'd be blending the buildscript and project configuration together which is probably not desirable.
Could potentially add a GradleDependencyConfiguration directly on the marker objects themselves to capture the same information, but again we're now capturing more information about the buildscript itself and having to use the naming conventions to differentiate between the buildscript settings and the project settings.

Any additional context
I would have liked to go ahead and drop the mavenPluginRepositories altogether, but I suspected that previously serialized LSTs could cause us some grief.
https://github.com/openrewrite/rewrite-gradle-tooling-model/pull/23
Checklist

[x] I've added unit tests to cover both positive and negative cases
[x] I've read and applied the recipe conventions and best practices
[x] I've used the IntelliJ IDEA auto-formatter on affected files

@sambsnyd @shanman190 I am getting failing tests on main since this merge. All have the same cause
 Caused by:                 java.lang.NoClassDefFoundError: org/openrewrite/gradle/marker/GradleBuildscript                     at org.openrewrite.gradle.marker.GradleProjectBuilder.gradleProject(GradleProjectBuilder.java:76)                     at org.openrewrite.gradle.toolingapi.ToolingApiOpenRewriteModelPlugin$OpenRewriteModelBuilder.buildAll(ToolingApiOpenRewriteModelPlugin.java:53)                     at org.gradle.tooling.provider.model.internal.DefaultToolingModelBuilderRegistry$BuilderWithNoParameter.build(DefaultToolingModelBuilderRegistry.java:264)                     at org.gradle.tooling.provider.model.internal.DefaultToolingModelBuilderRegistry$UserCodeAssigningBuilder.lambda$build$0(DefaultToolingModelBuilderRegistry.java:374)                     at org.gradle.configuration.internal.DefaultUserCodeApplicationContext$CurrentApplication.reapply(DefaultUserCodeApplicationContext.java:109)                     at org.gradle.tooling.provider.model.internal.DefaultToolingModelBuilderRegistry$UserCodeAssigningBuilder.build(DefaultToolingModelBuilderRegistry.java:374)                     at org.gradle.tooling.provider.model.internal.DefaultToolingModelBuilderRegistry$LockSingleProjectBuilder.lambda$build$0(DefaultToolingModelBuilderRegistry.java:304)                     at org.gradle.api.internal.project.DefaultProjectStateRegistry$ProjectStateImpl.lambda$fromMutableState$2(DefaultProjectStateRegistry.java:429)                     at org.gradle.internal.work.DefaultWorkerLeaseService.withReplacedLocks(DefaultWorkerLeaseService.java:360)                     at org.gradle.api.internal.project.DefaultProjectStateRegistry$ProjectStateImpl.fromMutableState(DefaultProjectStateRegistry.java:429)                     at org.gradle.tooling.provider.model.internal.DefaultToolingModelBuilderRegistry$LockSingleProjectBuilder.build(DefaultToolingModelBuilderRegistry.java:304)                     at org.gradle.tooling.provider.model.internal.DefaultToolingModelBuilderRegistry$BuildOperationWrappingBuilder$1.call(DefaultToolingModelBuilderRegistry.java:337)                     at org.gradle.internal.operations.DefaultBuildOperationRunner$CallableBuildOperationWorker.execute(DefaultBuildOperationRunner.java:204)                     at org.gradle.internal.operations.DefaultBuildOperationRunner$CallableBuildOperationWorker.execute(DefaultBuildOperationRunner.java:199)                     at org.gradle.internal.operations.DefaultBuildOperationRunner$2.execute(DefaultBuildOperationRunner.java:66)                     at org.gradle.internal.operations.DefaultBuildOperationRunner$2.execute(DefaultBuildOperationRunner.java:59)                     at org.gradle.internal.operations.DefaultBuildOperationRunner.execute(DefaultBuildOperationRunner.java:157)                     at org.gradle.internal.operations.DefaultBuildOperationRunner.execute(DefaultBuildOperationRunner.java:59)                     at org.gradle.internal.operations.DefaultBuildOperationRunner.call(DefaultBuildOperationRunner.java:53)                     at org.gradle.internal.operations.DefaultBuildOperationExecutor.call(DefaultBuildOperationExecutor.java:78)                     at org.gradle.tooling.provider.model.internal.DefaultToolingModelBuilderRegistry$BuildOperationWrappingBuilder.build(DefaultToolingModelBuilderRegistry.java:334)                     at org.gradle.internal.build.DefaultBuildToolingModelController$AbstractToolingScope.getModel(DefaultBuildToolingModelController.java:82)                     at org.gradle.tooling.internal.provider.runner.BuildModelActionRunner$ModelCreateAction.fromBuildModel(BuildModelActionRunner.java:83)                     at org.gradle.internal.buildtree.DefaultBuildTreeModelCreator.fromBuildModel(DefaultBuildTreeModelCreator.java:57)                     at org.gradle.internal.buildtree.DefaultBuildTreeLifecycleController.lambda$fromBuildModel$2(DefaultBuildTreeLifecycleController.java:81)                     at org.gradle.internal.buildtree.DefaultBuildTreeLifecycleController.lambda$runBuild$4(DefaultBuildTreeLifecycleController.java:98

@sihutch, do you by chance have some old rewrite snapshots published to the mavenLocal() repository? The latest published snapshots or creating a new local snapshot should fix that.


No number shows how many files are found after searching

VSCode Version: 1.6.1
OS Version: Win 10

Steps to Reproduce:

Search specified string in a folder,
Return some results, but there is no number showing how many files are found after searching.

Duplicates #6669

IMHO this is not a duplicate. The poster ask for number of files match the criteria not how many occurrences in the files.

@fascox #6669 also talks about number of files. Hence made it a dup.

sorry but talk not implies the same feature request... should be re-opened as a NEW feature

@fascox Updated the summary of the other one to include both matches count and files count. Since they are very much related, I think one feature request is good enough.
Thanks.

thanks, awesome.


Data Inconsistancy issue

Describe the bug
it's been noticed that when user have signed up. Some of them have zero reputation instead of 1
To Reproduce
Steps to reproduce the behavior:

Go to '...'
Click on '....'
Scroll down to '....'
See error

Expected behavior
A clear and concise description of what you expected to happen.
Screenshots
If applicable, add screenshots or video to help explain your problem.
Platform

Device: [e.g. Desktop, Mobile]
OS: [e.g. macOS]
Browser and version: [e.g. Chrome, Safari]
Version: [e.g. v1.2.0]

@fenbox FYI

observed with sqlite db

If the account is inactive, then their reputation is 0.

can you explain flow of  how an user goes to inactive?
This is what happened. User Signed Up.  User tried explore other sections without finishing activation. (user became inactive). User then done activation via activation mail (Now still user reputation is zero, that a problem)

This is what happened. User Signed Up. User tried explore other sections without finishing activation. (user became inactive). User then done activation via activation mail (Now still user reputation is zero, that a problem, user can't do anything on app. they can't post question, then can't answer, they can't comment)

What's your Answer version?
After the mail is activated, the reputation should go from 0 to 1, and the case where it's still 0 may be something we need to reproduce.

tag: v1.2.5-RC2

This is what happened. User Signed Up. User tried explore other sections without finishing activation. (user became inactive). User then done activation via activation mail (Now still user reputation is zero, that a problem, user can't do anything on app. they can't post question, then can't answer, they can't comment)

What's your Answer version?
After the mail is activated, the reputation should go from 0 to 1, and the case where it's still 0 may be something we need to reproduce.

@LinkinStars can you try messing (hacking) with account before activation. something like before activating go to other sections of page something like like add question (doing stuff which inactive user can't do)

PS note: I have tired doing repro in answer meta, I wasn't able to do that repro again. this time I got reputation as 1.
I guess its fine as long as number of cases is reasonable


Enhancement/Add option to share annotations across users

As discussed in https://github.com/chakki-works/doccano/issues/313, it's useful to have a project configuration that enables users to share annotation progress and annotate collaboratively. This enables a workflow where user A annotates document M and user B sees the annotation and can avoid re-labeling document M.
As such, this pull request adds a new option that enables activation of the "collaborative annotation mode":

Resolves https://github.com/chakki-works/doccano/issues/313

Hi @c-w , I am unable to get your changes if I run python manage.py makemigrations. I get only 1 migration file and your migration file 0004 is not created.

@alohia For ensuring reproducible build environments, I'd recommend to always use the Dockerfile to run the project:
docker build -t doccano .
docker run -p 8000:8000 doccano

When can we expect this feature to be merged into master?

It works well. Thanks!


snpguest verify attestation Error checking Chip ID

Hi,
I got the following error while attempting to verify a (valid) attestation report using snpguest verify attestation:
Reported TCB Boot Loader from certificate matches the attestation report.
Reported TCB TEE from certificate matches the attestation report.
Reported TCB SNP from certificate matches the attestation report.
Reported TCB Microcode from certificate matches the attestation report.
thread 'main' panicked at src/verify.rs:216:21:
Invalid octet length encountered!
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

The error comes from the check_cert_bytes function, called for verifying the Chip ID:
https://github.com/virtee/snpguest/blob/439f4446202567c8fbe89e9322667443427a43ea/src/verify.rs#L313
In my case, the cause of the error was that the Chip ID of the SNP instance started with 0x2, which triggers the first branch of the match ext.value[0] in line 212 and then causes the tool to panic because it gets an unexpected value for the second byte (namely 0xea in my case).
This, however, is not what should happen, because the Chip ID in the VCEK certificate has no "header" (it has a fixed length of 40 bytes), so the content of this X.509 extension should be checked byte-by-byte with what is contained in the attestation report (val), as done at line 236.

@gianlucascopelliti VLEK support was just merged upstream. I will start working VLEK support for the guest, and it should be ready when v3.0.0 of sev is released.


benchmarking: document the process

We need to document the current benchmarking process.

@denisshevchenko has done a good first approach in https://github.com/input-output-hk/cardano-node/wiki/Benchmarking


Service request with multiple array fields seems to fail

Description
For example, when using foxglove studio to connect to foxglove-bridge, the following service call on my_node/set_parameters succeeds:
{   "parameters": [     {       "name": "a",       "value": {         "type": 3,         "double_value": 1.0       }     }   ] }
But once the array contains more than one element, it does not. I.e.:
{   "parameters": [     {       "name": "a",       "value": {         "type": 3,         "double_value": 1.0       }     },     {       "name": "b",       "value": {         "type": 3,         "double_value": 2.0       }     }   ] }
Makes the node crash with the exception:

terminate called after throwing an instance of 'rclcpp::exceptions::InvalidParametersException'
what():  parameter name must not be empty

While the ROS2 CLI equivalent works correctly:
ros2 service call /my_node/set_parameters rcl_interfaces/srv/SetParameters "{"parameters": [{"name": "a","value": {"type": 3,"double_value": 1.0}},{"name": "b","value": {"type": 3,"double_value": 2.0}}]}"
When building foxglove_bridge from source and adding some debug prints here it seems the service request is not received correctly as I get (note the second entry is empty/default):

[INFO] [1735558998.294195957] [foxglove_bridge]: Calling service: /my_node/set_parameters with content:
[INFO] [1735558998.294419992] [foxglove_bridge]: Parameter: a
[INFO] [1735558998.294451375] [foxglove_bridge]: Value: 1.000000
[INFO] [1735558998.294462719] [foxglove_bridge]: Parameter:
[INFO] [1735558998.294488947] [foxglove_bridge]: Value: 0.000000

Version: 0.8.2
Platform: Linux Ubuntu 24.04

Steps To Reproduce
Simply do a service call from foxglove studio to any node's /set_parameters service with more than 1 entry in the parameters list.
Expected Behavior
I expect the service call simply goes through unchanged and thereby applies the two (or more) requested parameter changes.
Note
It might very well be that the actual bug is inside foxglove studio. But since that's closed source nowadays, I cannot easily isolate who is to blame or where stuff goes wrong...

I believe that you have to include all xy_value fields, not just double_value for each parameter. I can successfully set multiple parameters with Foxglove's service call panel when specifying all fields. This does not work when only specifying the double_value field.

Thanks for your swift reply!
I see, that indeed seems to fix the issue.
But isn't it strange that only double_value does work for a single parameter but not for more?
And also works with standard ROS2 cli tools?
i.e. ros2 service call /my_node/set_parameters rcl_interfaces/srv/SetParameters "{"parameters": [{"name": "a","value": {"type": 3,"double_value": 1.0}},{"name": "b","value": {"type": 3,"double_value": 2.0}}]}"
I'd expected the raw json to simply be forwarded to a ROS service call?

Turns out that Foxglove incorrectly serialized the request message when array fields were missing. After applying the fix locally I can set multiple parameters without providing the non-required value fields. I will provide a proper fix for this next year :wink:  (happy new year btw)


OverSubscribe in ParallelCluster 3.8.0 does not work

When trying to use OverSubscribe parameter via CustomSlurmSettings at the Queue level, the pcluster command produces a validation error
  "configurationValidationErrors": [
    {
      "level": "ERROR",
      "type": "CustomSlurmSettingsValidator",
      "message": "Using the following custom Slurm settings at Queue level is not allowed: OverSubscribe"
    },

If setting the same at ComputeResources level, the validator is ok with it but evidently this then leads to a broken SLURM configuration given that the OVERSUBSCRIBE parameter is only allowed at Queue/ Partition level.
In the pcluster source code we are associating OverSubscribe with the Queue level but put it on the DENY_LIST
https://github.com/aws/aws-parallelcluster/blob/develop/cli/src/pcluster/validators/slurm_settings_validator.py#L50
If removing oversubscribe from the DENY_LIST, pcluster will create a valid SLURM configuration, e.g. using this partial YAML code
....
  SlurmQueues:
    - Name: interactive
      ComputeResources:
        - Name: interactive
          InstanceType: t2.xlarge
          MaxCount: 20
          MinCount: 1
          Efa:
            Enabled: FALSE
      CustomSlurmSettings:
        OverSubscribe: FORCE
...

The reason we have OverSubscribe in the deny list is because it is mutually exclusive with the JobExclusiveAllocation parameter.
If you really want to use OverSubscribe, make sure you don't have JobExclusiveAllocation and suppress the validator when creating the cluster.

Fair enough - happy to use the --validation-failure-level WARNING workaround for the time being.
It still would be great to add OverSubscribe on the Queue/Partition level though - adding OverSubscribe there will provide a non-functional SLURM cluster, even with validators as default.


python311Packages.hvac: 2.2.0 -> 2.3.0

Automatic update generated by nixpkgs-update tools. This update was made based on information from passthru.updateScript.
meta.description for python311Packages.hvac is: HashiCorp Vault API client
meta.homepage for python311Packages.hvac is: https://github.com/ianunruh/hvac
meta.changelog for python311Packages.hvac is: https://github.com/hvac/hvac/blob/v2.3.0/CHANGELOG.md
Updates performed

Ran passthru.UpdateScript

To inspect upstream changes
Impact
Checks done

built on NixOS
The tests defined in passthru.tests, if any, passed
found 2.3.0 with grep in /nix/store/6k7g0f05hjqr3n42vjcix4kv5pwnqs4x-python3.11-hvac-2.3.0
found 2.3.0 in filename of file in /nix/store/6k7g0f05hjqr3n42vjcix4kv5pwnqs4x-python3.11-hvac-2.3.0

Rebuild report (if merged into master) (click to expand)

3 total rebuild path(s)

3 package rebuild(s)

First fifty rebuilds by attrpath

python311Packages.hvac
python312Packages.hvac

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/6k7g0f05hjqr3n42vjcix4kv5pwnqs4x-python3.11-hvac-2.3.0 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A python311Packages.hvac https://github.com/r-ryantm/nixpkgs/archive/fbd14e843991044e0300281b99aba70c02f6344b.tar.gz

Or:
nix build github:r-ryantm/nixpkgs/fbd14e843991044e0300281b99aba70c02f6344b#python311Packages.hvac

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/6k7g0f05hjqr3n42vjcix4kv5pwnqs4x-python3.11-hvac-2.3.0
ls -la /nix/store/6k7g0f05hjqr3n42vjcix4kv5pwnqs4x-python3.11-hvac-2.3.0/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review --extra-nixpkgs-config '{ allowInsecurePredicate = x: true; }' run on x86_64-linux 1

4 packages built:

python311Packages.hvac
python311Packages.hvac.dist
python312Packages.hvac
python312Packages.hvac.dist

Maintainer pings

Done in https://github.com/NixOS/nixpkgs/commit/ade3f8ad3f6ccdc893872c5626fff13908490259.


Edge App titles could be unique.

Overview
Similar titles (even though they have the different IDs) could cause confusion among users. Here's a sample console output after running screenly edge-app list:
2023-08-04T02:12:40.651Z DEBUG [reqwest::connect] starting new connection: https://api.screenlyapp.com/
+----------------------------+--------------+
| Id                         | Title        |
+----------------------------+--------------+
| [redacted] | edge-app-1   |
+----------------------------+--------------+
| [redacted] | .            |
+----------------------------+--------------+
| [redacted] | .            |
+----------------------------+--------------+
| [redacted] | .            |
+----------------------------+--------------+
| [redacted] | help         |
+----------------------------+--------------+
| [redacted] | clock-app    |
+----------------------------+--------------+
| [redacted] | weather-app  |
+----------------------------+--------------+
| [redacted] | weather-app  |
+----------------------------+--------------+
| [redacted] | edge-app-2   |
+----------------------------+--------------+
| [redacted] | clock-app    |
+----------------------------+--------------+
| [redacted] | rss-reader   |
+----------------------------+--------------+
| [redacted] | clock-test-1 |
+----------------------------+--------------+

We can notice that there are two occurences of weather-app and clock-app.

Closing this issue in favor of https://github.com/Screenly/cli/pull/94#issuecomment-1701291828.

Closing this issue in favor of https://github.com/Screenly/cli/pull/94#issuecomment-1701291828.

@nicomiguelino #94 doesn't add uniquness to the titles. We probably should have that, allthough it is a bit more complicated as we also have public apps from foreign teams.

@korvyashka. Apologies for the confusion. What I mean is that I closed the issue since uniqueness will only be enforced on the IDs.


Add the ability to download things other than Pivotal tiles

At the moment, the utility seems to restrict you to only downloading Pivotal tiles (things that end with .pivotal).  This PR adds support to download other stuff by adding a fileType option to the utility.  The option defaults to pivotal so the behavior should be as it is now.  However you can change this to other values to get files of different types from PivNet.
This is useful for download stemcells, which end in '.tgz', buildpacks which end in '.zip' or Ops Manager images which have a variety of extensions.
I'm new to golang, so if my code is terrible let me know.  Happy to rework the PR a bit.

Hey,
Thanks for the PR. Change looks good and I merged it.
I didn't look into stemcells initially since I usually grab them from bosh.io.
The current solution works for buildpacks but it feels weird having to specify the version as '-version "Java Buildpack 3.3.1"' or similar.
I'll see if I can come up with a nicer syntax over the weekend.


IP limit

brawlhalla's twitch reward extension limits 5 tracks per IP

Yeah that is a problem one could solve with proxies. I haven't implemented proxy support yet and i probably won't (unless i feel like it in the future).


Step 5 doesn't work: The token automatically populates the Available Token field

Hello, can you add an update of the identification via Oauth ? I have the message "Error: OAuth 2.0 request timed out. Please try again."
I succeed to login in (I can see the popin and the experience cloud) and Postman never retrieve the token


Roll Flutter Engine from fc3267724e1b to 3b6406a52d12 (3 revisions)

https://github.com/flutter/engine/compare/fc3267724e1b...3b6406a52d12
2023-12-13<EMAIL_ADDRESS>Allow tests to run on macOS 13 (flutter/engine#48894)
2023-12-13<EMAIL_ADDRESS>[Impeller] Compute ContextContentOptions key via bit manipulating (instead of hashing each property). (flutter/engine#48902)
2023-12-13<EMAIL_ADDRESS>Roll Skia from f3401c6186c1 to 69c02c9d56b2 (1 revision) (flutter/engine#48992)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com,rmistry<EMAIL_ADDRESS>on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Commit queue failed; closing this roll.


Do light/dark styling with JupyterLab theming system.

This enables the dark theme on JupyterLab:

That is really cool. Thanks!


introduce list.All

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

8 of 14 (57.14%)  changed or added relevant lines in 1 file are covered.
1 unchanged line in 1 file lost coverage.
Overall coverage increased (+0.5%) to 15.21%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

list/list.go
8
14
57.14%

Files with Coverage Reduction
New Missed Lines
%

list/list.go
1
73.18%

Totals

Change from base Build<PHONE_NUMBER>:
0.5%

Covered Lines:
308

Relevant Lines:
2025

💛  - Coveralls


refactor: move enums to the beginning of utils/core.py

SUMMARY
Move the enums in utils.core to the beginning of the file and sort them in alphabetical order.
In general, enums should be placed at the beginning of each file because they are constants and wouldn't depend on anything else, while on the other hand, subsequent functions in the same file may need to use them.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
N/A
TEST PLAN
CI
ADDITIONAL INFORMATION

[ ] Has associated issue:
[ ] Changes UI
[ ] Requires DB Migration.
[ ] Confirm DB Migration upgrade and downgrade tested.
[ ] Introduces new feature or API
[ ] Removes existing feature or API

Would now be a good time to move these to a separate file, like superset/types.py? I would also consolidate the aliases from superset/typing.py into the new file, as that name clashes with the builtin typing.

Do we consider enums part of typing? I thought they are constants as well.
Was debating internally whether to move them into superset.constants, but kind of also feel for less general enums, they should probably be put locally into each submodule. It's a hard choice, so I went with the easiest and smallest change...
Either way, we should definitely find ways to break up the thousand-LOC core.py files.
Could you clarify how does superset.typing clashes with the builtin module?

Codecov Report

Merging #11883 (61f8859) into master (14ea444) will decrease coverage by 2.64%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master   #11883      +/-   ##
==========================================
- Coverage   66.22%   63.57%   -2.65%
==========================================
  Files         937      465     -472
  Lines       45325    28528   -16797
  Branches     4341        0    -4341
==========================================
- Hits        30016    18138   -11878
+ Misses      15177    10390    -4787
+ Partials      132        0     -132

Flag
Coverage Δ

cypress
?

javascript
?

python
63.57% <100.00%> (-0.62%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

superset/utils/core.py
88.81% <100.00%> (ø)

superset/db_engines/hive.py
0.00% <0.00%> (-85.72%)
:arrow_down:

superset/sql_validators/postgres.py
50.00% <0.00%> (-50.00%)
:arrow_down:

superset/db_engine_specs/hive.py
54.61% <0.00%> (-29.62%)
:arrow_down:

superset/db_engine_specs/presto.py
69.95% <0.00%> (-12.45%)
:arrow_down:

superset/examples/world_bank.py
97.10% <0.00%> (-2.90%)
:arrow_down:

superset/db_engine_specs/postgres.py
97.56% <0.00%> (-2.44%)
:arrow_down:

superset/examples/birth_names.py
96.51% <0.00%> (-2.33%)
:arrow_down:

superset/views/database/mixins.py
80.70% <0.00%> (-1.76%)
:arrow_down:

superset/models/core.py
88.04% <0.00%> (-0.82%)
:arrow_down:

... and 481 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 14ea444...61f8859. Read the comment docs.

Would now be a good time to move these to a separate file, like superset/types.py? I would also consolidate the aliases from superset/typing.py into the new file, as that name clashes with the builtin typing.

Do we consider enums part of typing? I thought they are constants as well.

Hmm, I've always thought of enums as being types, and strictly speaking they are in Python, anyway:
>>> from enum import Enum
>>> class MyEnum(Enum):
...     ABC = 1
...
>>> abc = MyEnum.ABC
>>> type(abc)
<enum 'MyEnum'>

But if the general convention is to call them constants I'm fine with that, too.

Was debating internally whether to move them into superset.constants, but kind of also feel for less general enums, they should probably be put locally into each submodule. It's a hard choice, so I went with the easiest and smallest change...
Either way, we should definitely find ways to break up core.py files that have thousands of lines of code.

I agree, the specific types should probably be put in the correct submodule, as right now utils/core.py is really bloated with these. But that can be saved for a later PR.

Could you clarify how does superset.typing clash with the builtin typing?

I've seen quite a few reports where import x from typing is picking up superset.typing. Here's a recent example: https://github.com/apache/incubator-superset/issues/11925 . This once happened to me, too, but not sure what was causing it, probably something with an incorrect PYTHONPATH.

@villebro then is this PR good for merge as is or do you want me to move the enums to typing?


feat: support tagged reference

What?

Support passing in a reference in the format: registry/repository:v1. Before that, only a reference with digest tag is supported.
Refactor the print out format to be more readable.

Test
Success case:

Failure case:

Signed-off-by: Binbin Li<EMAIL_ADDRESS>

Codecov Report

Merging #359 (a9976d1) into dev-rc.1 (4bc23db) will decrease coverage by 0.12%.
The diff coverage is 0.00%.

@@             Coverage Diff              @@
##           dev-rc.1     #359      +/-   ##
============================================
- Coverage     31.26%   31.13%   -0.13%
============================================
  Files            26       26
  Lines          1705     1712       +7
============================================
  Hits            533      533
- Misses         1155     1162       +7
  Partials         17       17

Impacted Files
Coverage Δ

cmd/notation/verify.go
30.00% <0.00%> (-3.97%)
:arrow_down:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

LGTM

Regarding the success case, is there an empty line before the digest? If yes, I suggest removing the empty line.

Regarding the success case, is there an empty line before the digest? If yes, I suggest removing the empty line.

that's the old screenshot, I've updated it.

BTW, could you use cmd.ParseFlagPluginConfig to parse the plugin config? https://github.com/notaryproject/notation/blob/4bc23dbe15dd2e4f60ac96189d939771e8ee9081/cmd/notation/sign.go#L123
We don't need to parse the config string manully.

BTW, could you use cmd.ParseFlagPluginConfig to parse the plugin config?
https://github.com/notaryproject/notation/blob/4bc23dbe15dd2e4f60ac96189d939771e8ee9081/cmd/notation/sign.go#L123
We don't need to parse the config string manully.

Sure, thanks for calling it out.


Small question

I posted it on Quora  aswell.
I don't get why you don't build up a database connection how this tutorial does. And why you don't add
public void onCreate() {
    super.onCreate();
    Firebase.setAndroidContext(this);
    // other setup code
}

as suggested here. Because when I run your code I can't create a new user. The statement task.isSuccessful() in line 128 is always false.
My database rules are set like this:
{
  "rules": {
    ".read": "auth != null",
    ".write": "auth != null"
  }
}

Because when I use your code in my App I can't store any users... and I don't get why it's not working (although it should work like this)

Hi there @LenCewa.  Happy to help here, but in the future please do not disregard the issue template when filing issues.  It's really useful for us!
First of all Firebase.setAndroidContext(this) means you are using the old Firebase SDK (from before May 2016).  The tutorial you linked to is from the old Firebase documentation (which goes with that SDK).
The current docs are here: https://firebase.google.com/docs
And the current SDK is com.google.firebase:firebase-database:10.0.0.  Make sure you use that and then remove all references to the old SDK.  If you can still access the Firebase class, you have the wrong SDK!

Thank you very much. I tried it with the current docs and it didn't work out correctly that's why somehow I found the old Firebase SDK. I'll give it another shot maybe I did something wrong. If you like to, you can close this "issue". What is the best way to ask those problems? Quora? / SO / or would a mail to your inbox be okay aswell?

Since I'd consider this troubleshooting (because it's likely an issue in your particular code rather than in our code or our samples) the best place for this is StackOverflow.  The reason is that once we help you, other people can learn from it.  If we helped over email then other people with the same question couldn't ever know.
Closing (as you suggested).  Good luck!


If previous stats based didn't run successfully, still need to close last log segment

If the stats based compaction has not been kicked off because the details are null, we still need to auto close the last log segment.

Codecov Report

Merging #1917 (bf950a5) into master (b26b7ec) will decrease coverage by 58.53%.
The diff coverage is 0.00%.

@@              Coverage Diff              @@
##             master    #1917       +/-   ##
=============================================
- Coverage     73.96%   15.42%   -58.54%
+ Complexity     9666     2275     -7391
=============================================
  Files           690      690
  Lines         53204    53204
  Branches       6627     6627
=============================================
- Hits          39352     8209    -31143
- Misses        11782    44520    +32738
+ Partials       2070      475     -1595

Impacted Files
Coverage Δ

...java/com/github/ambry/store/CompactionManager.java
93.14% <0.00%> (ø)

.../src/main/java/com/github/ambry/router/Router.java
0.00% <0.00%> (-100.00%)
:arrow_down:

.../src/main/java/com/github/ambry/store/Message.java
0.00% <0.00%> (-100.00%)
:arrow_down:

...rc/main/java/com/github/ambry/named/PutResult.java
0.00% <0.00%> (-100.00%)
:arrow_down:

...rc/main/java/com/github/ambry/quota/QuotaMode.java
0.00% <0.00%> (-100.00%)
:arrow_down:

...rc/main/java/com/github/ambry/quota/QuotaName.java
0.00% <0.00%> (-100.00%)
:arrow_down:

...rc/main/java/com/github/ambry/rest/RestMethod.java
0.00% <0.00%> (-100.00%)
:arrow_down:

...c/main/java/com/github/ambry/config/KMSConfig.java
0.00% <0.00%> (-100.00%)
:arrow_down:

...c/main/java/com/github/ambry/config/SSLConfig.java
0.00% <0.00%> (-100.00%)
:arrow_down:

...c/main/java/com/github/ambry/router/ByteRange.java
0.00% <0.00%> (-100.00%)
:arrow_down:

... and 541 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b26b7ec...bf950a5. Read the comment docs.


Selected package cannot be found in "Selected Components"

Package has been selected to add into blueprint, but it cannot be found in "Selected Components".

I am not able to reproduce this. Maybe it's fixed since Nevember? Can you please confirm and close if that's the case?


[#2606]Dependency management split

#2606 subtask

Hi, all seatunnel-api in connector-v2 the scope should be provided

Hi, all seatunnel-api in connector-v2 the scope should be provided

Hi, thx your reminder. done

seem like ci have some problem should be fixed before merge.

seem like ci have some problem should be fixed before merge.

hi, done.This is due to provide dependency transitivity, so I added the dependency of seatunnel-api in the parent pom


Error code 0x80070422

Missing error code 0x80070422 and related description.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: f76d96ac-5343-20e2-9d99-9c1cea7ccc2e
Version Independent ID: a95c9b39-4a66-d726-4404-de5af60ac982
Content: Windows Update error code list by component - Windows Deployment
Content Source: windows/deployment/update/windows-update-error-reference.md
Product: w10
Technology: windows
GitHub Login: @jaimeo
Microsoft Alias: greglin

Document links:

https://docs.microsoft.com/en-us/windows/deployment/update/windows-update-error-reference
https://github.com/MicrosoftDocs/windows-itpro-docs/blob/public/windows/deployment/update/windows-update-error-reference.md

Different page from issue ticket #9189 (Error code 0x80070422), but the content issue is the same.

@e0i , please close this issue , because  same  issue has been reported  in #9189

Closing this as it's a duplicate of 9189

@LuigiBruno : I apologize on behalf of  @RAJU2529 and @nam31 , they usually don't have time to go into details.
Maybe we should just move the content from this ticket into the other ticket, to make sure that the other ticket deals with multiple pages.

Closing via #9412
Thank you


The file extension .png will be added only if the file has extensions other than .png or .PNG

Pull Request Label:

[ ] Bug
[ ] New feature
[x] Enhancement
[ ] New component
[ ] Typo

Pull Request Checklist:

[x] Have you followed the guidelines for contributing?
[x] Have you checked that there aren't other open pull requests for the same fix or component?
[ ] Have you ran the tests locally with bats tests?

Used grep to identify if the user input of the file includes the .png or .PNG extensions... If it does not, it appends .png to the file name

Looks good to me, any reason you threw the -q flag onto grep, if it works it work just wanting to know for the sake of my own curiosity lol thanks for the contribution :+1:

Mostly because whenever the pattern matching would succeed, it would print the filename out. I added the -q to suppress that.


Resetting/reloading the configuration

Hi,
sometimes when I am using the pomodoro timer I get out of sync and I have to reset the timer to the first session again to restart.
Now I can run uairctl finish several times till I'm at the first session again.
I wish there were some command like uairctl reset or am I missing something?

I think the proper command is uairctl resume, but it seems like nothing happens after I execute it.

@Ziqi-Yang Using uairctl resume works for me very well in this case: after stopping the timer, I can resume it.
I mean resetting the hole configuration to the beginning of first session.

I plan to add session selection options within the next couple of releases. Currently, you can invoke pkill uair to terminate the process and let the caller process restart it automatically. If I recall correctly, polybar does this by default. If it doesn't, then you can wrap uair command in a while loop within a shell script and then call it from polybar(or any other frontend).

Okay. Thank you!

Looking forward to the updates!


Can't find cropformer.yml

Teacher or Senior, I'm using your software for learning at the moment, but I can't find the corresponding cropformer.yml file.

Thanks for your question, we have uploaded cropformer.yml


Copy root readme to packages/chevrotain during the release process

not important enough to devote time for...


feat:  independent prim types

Motivation:
closes #8668
Description:
WIP: tx trait abstraction for TxPool conversions

Missing updated mock impl atm.


Mocha-webpack setup, can't suppress Vue logging

Using the mocha-webpack setup, I have a required file start.js with the following code:
require('jsdom-global')();
const Vue = require('vue');

// disable Vue logging
Vue.config.productionTip = false;
Vue.config.devtools = false;
Vue.config.silent = true;

global.assert = require('chai').assert;
global.expect = require('chai').expect;

However, Vue is still logging out to the console,

Have I missed something?

@eddyerburgh thanks for the quick turn around, will this be included in the next beta release?

Yes


Update sbt-version-policy to 1.2.0

Updates ch.epfl.scala:sbt-version-policy from 1.1.0 to 1.2.0.
GitHub Release Notes - Version Diff
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Files still referring to the old version number
The following files still refer to the old version number (1.1.0).
You might want to review and update them manually.
project/plugins.sbt
website/package.json
website/yarn.lock

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "ch.epfl.scala", artifactId = "sbt-version-policy" } ]

labels: sbt-plugin-update, semver-minor, old-version-remains

Superseded by #58.


Cannot bundle with google cloud modules

I am getting an error when trying to build a super simple library using the google cloud modules.
I have not gotten this error with any other module. Sometimes it will switch between showing pubsub and datastore as the issue (always the same general error). I am uncertain if this is a rollup-plugin-commonjs problem or a google cloud problem. I am happy to move this issue to another repo if we find rollup-plugin-commonjs is not the issue.
index.js → out/app.js...
[!] Error: Unexpected token
<EMAIL_ADDRESS>(2:9)
1: {
2:   "_from": "@google-cloud/pubsub",
            ^
3:   "_id": "<EMAIL_ADDRESS>4:   "_inBundle": false,

Reproduce with:
Install things:
mkdir proj && cd proj && npm init -y && npm i -D rollup rollup-plugin-node-resolve rollup-plugin-commonjs
Install dependencies:
npm i @google-cloud/pubsub @google-cloud/datastore
Make the files:
// rollup.config.js
import resolve from 'rollup-plugin-node-resolve';
import commonjs from 'rollup-plugin-commonjs';

export default [
    {
        input: 'index.js',
        output: {
            name: 'app',
            file: 'out/app.js',
            format: 'umd'
        },
        plugins: [
            resolve(),
            commonjs()
        ]
    },
];

// index.js:
var lodash = require('lodash')
var PubSub = require('@google-cloud/pubsub');
var Datastore = require('@google-cloud/datastore');

Run with this command
npx rollup -c

It looks like the module is trying to import a JSON file. This error is probably not triggered by rollup-plugin-commonjs but by rollup itself. Try adding rollup-plugin-json to your config.

Thanks, I believe that solves the issue!


Create LICENSE

Add a LICENSE file for better discoverability of the LICENSE.

@acdlite What do you think of this? Should we add a license?

@dustyburwell Can you please rebase, so Travis doesn't fail anymore?

@dustyburwell ping

Sure thing

Done

Thanks, merged :)