Degraded quality of rendered content in Viewport in another Viewport

Godot version:
3.0 and 3.1 alpha2
OS/device including version:
Arch Linux, GPU: NVIDIA GTX 770 (415.18.04)
Android, Xiaomi Redmi Note 4
Issue description:
I wrote small script that adapts game UI to match screen DPI:
get_tree().set_screen_stretch(1, 4, new_size)
And everything looks crispy clear. But, when I add new Viewport to the Scene, the content rendered in this Viewport looks very bad.

I've tried multiple things :

enabling/disabling Use Pixel Snap
setting size of the Viewport to match root's size
setting size_override of the Viewport to match root's size_override
setting size and size_override of the Viewport to match root's size and size_override
removing set_screen_stretch, setting the Viewport size and size_override to the same values as root would have if set_screen_stretch was called, and changing stretch mode and stretch aspect in Project Settings to multiple different values
using TextureRect or ViewportContainer to render the Viewport
enabling/disabling Snap Controls To Pixels

In every case something was wrong: blurry or pixelated font, wrong sizes of all UI elements...
So I commented all my code to be sure that this isn't related to some bug in my code. And then, at first everything was looking good. But as it turns out, content rendered in the Viewport looks a little bit different (blurred?) than outside of the Viewport. The difference is very subtle and hard to notice. Look at the TEST and circle. Open image in new tab for bigger version - easier to notice the issue.

Is there some magical combination of settings to fix my issue? I was "debugging" my issue for over a week, and I haven't found any possible combination to fix it.
Steps to reproduce:

Add ViewportContainer to the Scene
Add Viewport to the ViewportContainer
Add Label with some text to the Viewport
Duplicate the Label and add it as a sibling of ViewportContainer (and move somewhere else, so it won't overlap content from Viewport)
Notice the very, very subtle differences between Labels.

Minimal reproduction project:

Running this project will result in the same looking image as in first picture. If you want to see the result of second image, comment get_tree().set_screen_stretch(1, 4, window) in dpi.gd file.
Project for Godot 3.1 alpha2
PS. This project uses wrong DPI values in script on purpose, so the problem will be more noticeable on PC.
PS2. I'm not sure if this will be helpful, but I need to resize the window at startup, to fix the "blocky" text outside of the Viewport. I'm not sure if this is related the issue.

Just looking at the images it seems like the internal Viewport is simply rendering at a lower resolution. Though I can't tell if this is a bug or if the Viewport wasn't used as intended.

@CptPotato I thought the same thing. That is why I set stretch mode to disabled and stretch aspect to expand. This should set the internal Viewport (root) resolution to match the OS.window_size. Then I added new Viewport to the scene, set its size to match OS.window_size, and everything in that new Viewport was a little bit blurred (2nd picture). And yet, both internal Viewport and the Viewport added to the scene had the same sizes, so both viewports should be rendering at the same resolution.
And the 1st picture. It's true - the Viewport added to the scene renders everything at lowered resolution. That is why I tried simulating what set_screen_stretch does to the internal Viewport, when stretch mode is set 2D and stretch aspect is set to expand, but applying the values to the Viewport added in the scene.
So I set the (added to the scene) Viewport size to OS.window_size, I enabled set_size_override_stretch and called set_size_override with my desired resolution (the same as would be set in set_screen_stretch). Here is the difference:

Also noticing this issue as of commit cab97f4b504a67955.
Feels like maybe an option for the rendering for 2D might be missing.

I ran into this issue when trying to run an outline shader on a group of sprites. I found a workaround*:
Instead of rendering directly inside of a ViewportContainer, render to a Sprite. You can set a sprite's texture to a Viewport Texture. Simply doing this makes it look exactly like the result from ViewportContainer. To fix this set the filter flag on the sprite to true.

I wouldn't say that it's perfect, but it's a heck of a lot better - for non text content. I did try it with text as well, and that still looks a bit off.

Currently having this issue, Sprite thing doesn't work for me since I need clickable UI in it.

i think i'm running in the same issue in a project with compute shaders: i'm getting back the data from a viewporttexture after a 2Dshader pass is applied, and obviously the data need to be pixel perfect or it will screw the results.
I'm currently not being able to achieve any reliable result: i'm not 100% sure the cause is the viewport texture, but I also did some tests with different create_from_image() flags and nothing changed, also all objects (rendered sprite, viewport, target sprite) are all the same dimension, so no stretching is needed.
It seems to me the loss of quality is related to floating point errors in the pixel color rgba values.
EG: a simple shader like
COLOR=texture(TEXTURE, UV)*0.95;
if applied recursively (shader pass inside viewport=>take the viewporttexture=>get data of the texture => create new texture from image data=>feed the new texture to the shader again) should bring to the entire texture to be transparent Color(0,0,0,0). Instead, the foating point error bites in and final result is Color(0,0,0,0.035294).
It got even better if i change the shader code to COLOR.rgb=texture(TEXTURE, UV).rgb*0.95; the final results should be Color(0,0,0,1), but it will actually be Color(0.035294,0.035294,0.035294,1)

I ran into this issue when trying to run an outline shader on a group of sprites. I found a workaround*:
Instead of rendering directly inside of a ViewportContainer, render to a Sprite. You can set a sprite's texture to a Viewport Texture. Simply doing this makes it look exactly like the result from ViewportContainer. To fix this set the filter flag on the sprite to true.

I wouldn't say that it's perfect, but it's a heck of a lot better - for non text content. I did try it with text as well, and that still looks a bit off.

Encountered this bug today, noticed that all you really need is to have ViewportTexture with correct flags (i.e Mipmaps and filter) that uses the ViewPort and something that uses the texture like TextureRect or Sprite to get around this. You don't even need to use the TextureRect or Sprite, simply set visible false.
Guessing that ViewPort just ignores (2D) TextureFlags other than ones set in ViewPortTexture.

We are having the same issue in our project. If we put part of our game into the viewport node, we get jagged edges.

As you can see the sprite on the right has jagged edges.
Here is our scene setup with the settings for the viewport.

Enable Filter on the Viewport to prevent this.

I'm not sure if this will help with your case, but I had a similar problem, and bot524 came up with this workaround:
onready var viewportContainer := $viewport_container
onready var viewport := $viewport_container/viewport
onready var viewportUI := $viewport_container/viewport/ui

func _ready() -> void:
	var root := get_viewport()
	root.connect("size_changed", self, "onViewportSizedChanged")

func onViewportSizedChanged() -> void:
	var root := get_viewport()
	var transform := root.get_final_transform()

	viewport.size = root.size
	viewportUI.rect_scale = Vector2(transform.x.x, transform.y.y)
	viewportContainer.rect_scale = Vector2(1.0 / transform.x.x, 1.0 / transform.y.y)

Also entered a potentially related bug about dynamic fonts looking bad if at a different scale from the main window: https://github.com/godotengine/godot/issues/65172

I've added a proposal to make this easier / built in default behavior: https://github.com/godotengine/godot-proposals/issues/5372

I think I found a solution for this problem, all I have to do is use TextureRect, or Sprite, and set there texture to the viewport
then I repress in the texture to edit it, then turn on the "filter" from the flags settings to be like this

and here it the results

and with small code, we can set the TextureRect to resize the viewport whenever we resize the TextureRect itself
(ofc I put the viewport under the TextureRect to simulate the ViewportContainer node)
`tool
extends TextureRect
var viewport = null
func _ready():
for i in get_children():
if i is Viewport:
viewport = i
break
pass
func _process(delta):
if viewport == null: return
viewport.size = rect_size
`

I have a similar problem and for me, changing the the size of the viewport during the runtime results in a much sharper image. But seems that changes that happen on _ready do not fix it, only when i change it in the inspector during runtime (therefore changing the values on runtime):
https://user-images.githubusercontent.com/24807557/201154712-1bbdb0c7-24ed-4ec6-8e61-c52cfa79dc4f.mp4
Also seems that there is a value in the viewport container that could be used to increase the render-size, but seems its capped at 1. If i were able to set this below 1 this maybe could solve my problem.
I also have the filter active via Calinou's example and changing the size on _ready in the parent script doesnt change the size of the viewport as well.
I tried setting the viewport.size in the _process of the parent, but that way the location of the buttons and such get offset inside the map (like it did when setting the viewport size in the inspector on runtime)
https://user-images.githubusercontent.com/24807557/201155580-7a062eff-44c4-4f2c-a386-01b019a04d8e.mp4

Don't know if this is related, but not only does the scaling of the viewport not change it's resolution, but resizing the window frequently leads to a hard crash. This is on Godot 4.0.2 stable on Windows 10

https://user-images.githubusercontent.com/23440295/236984637-6dda3685-5a39-4bf7-af82-a9f4a6674800.mp4


Enable compilation under jdk 11

Tested to compile locally under jdk11

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-PR-Builder/10660/
Test FAILed.

jenkins, test this please

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-PR-Builder/10665/
Test FAILed.

jenkins, test this please

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-PR-Builder/10666/
Test FAILed.

jenkins, test this please

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-PR-Builder/10667/
Test FAILed.

jenkins, test this please

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-PR-Builder/10671/
Test FAILed.

jenkins, test this please

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-PR-Builder/10672/
Test PASSed.

@calvinjia @apc999 PTAL at the change to bump default hdfs client to 3.3.0

@apc999 @calvinjia anymore comments? I'd like to have this merged before today so nightly tests have a chance to run on this.

@apc999 @calvinjia  ping?

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-PR-Builder/10682/
Test FAILed.

jenkins, test this please

Merged build finished. Test FAILed.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-PR-Builder-jdk11/2/
Test FAILed.

jenkins, test this please

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-PR-Builder/10688/
Test PASSed.

alluxio-bot, merge this please.


APIs frozen

I hope this prevents the api server to quit thinking it knows what I'm thinking

Wow


Fix stuck batch writer on OutOfMemoryError (#2331)

@andrewglowacki Am I right in thinking that a finished solution here will only apply to 1.10, and not to 2.1?

@ctubbsii yes, I think so considering 1.10 is the only version that was capable of getting stuck after all.

I submitted #2346 as a solution to this for 2.1.

Closing this based on last https://github.com/apache/accumulo/pull/2337#issuecomment-963101097  and because it has conflicts that are out-of-date, and because it hasn't been updated in awhile. Backporting that change to 1.10 isn't feasible, and the solution in this PR may help with one use case but hurt others. It's probably best to leave 1.10 alone, but feel free to discuss further or reopen if there's more to do here for 1.10.


Crash upon launch

MC: 1.12.2
CR: 1.12.2-1.7.0
Forge: <IP_ADDRESS>81
Log

You seem to have cut out the second half of the log. What version of JEI are you using (if any)? I think I've found the issue, it seems I accidentally made JEI a dependency. I'll have a fix out in a few minutes, until which time just adding JEI should fix it.

JEI was already installed before i even put CR in. Version <IP_ADDRESS>


Antrea Agent sometimes (rarely) fails to query supported OVS datapath features

Describe the bug
On 2 separate occasions, I have observed the antrea-agent container crashing shortly after starting.
In both cases, this was on a new Kind cluster, and Antrea was being installed for the first time in the cluster.
The contents of the logs showed that the Agent had failed to query the supported datapath features from OVS, and hence had exited early with an error:
I0618 18:39:11.300984       1 log_file.go:93] Set log file max size to 104857600
I0618 18:39:11.303689       1 options.go:504] "The Egress feature gate is enabled, but it won't work because it is only applicable to the encap mode"
I0618 18:39:11.304221       1 agent.go:105] "Starting Antrea agent" version="v2.0.0"
I0618 18:39:11.304266       1 client.go:89] No kubeconfig file was specified. Falling back to in-cluster config
I0618 18:39:11.308585       1 prometheus.go:189] Initializing prometheus metrics
I0618 18:39:11.315568       1 ovs_client.go:70] Connecting to OVSDB at address /var/run/openvswitch/db.sock
I0618 18:39:12.323252       1 ovs_client.go:89] Not connected yet, will try again in 2s
I0618 18:39:12.344775       1 agent.go:377] Setting up node network
I0618 18:39:12.353225       1 discoverer.go:82] Starting ServiceCIDRDiscoverer
I0618 18:39:12.456571       1 agent.go:966] "Updating Node MAC annotation"
I0618 18:39:12.649350       1 agent.go:991] "Got Interface MTU" MTU=1500
I0618 18:39:12.658499       1 ovs_client.go:137] Created bridge: 640294ff-f1c4-4816-93f7-72c3fb730dc9
F0618 18:39:13.014321       1 main.go:53] Error running agent: error initializing agent: error listing DP features: ExecError: exit status 2, output: "dpif/show-dp-features" is not a valid command (use "list-commands" to see a list of valid commands)
ovs-appctl: /var/run/openvswitch/ovs-vswitchd.98.ctl: server returned an error
goroutine 1 [running]:
k8s.io/klog/v2/internal/dbg.Stacks(0x0)
	k8s.io/klog/v2@v2.110.1/internal/dbg/dbg.go:35 +0x85
k8s.io/klog/v2.(*loggingT).output(0x4953b00, 0x3, 0x0, 0xc000512af0, 0x1, {0x39b5a60?, 0x1?}, 0x10?, 0x0)
	k8s.io/klog/v2@v2.110.1/klog.go:957 +0x6fa
k8s.io/klog/v2.(*loggingT).printfDepth(0x0?, 0x0?, 0x0, {0x0, 0x0}, 0x0?, {0x2c88231, 0x17}, {0xc0007d6060, 0x1, ...})
	k8s.io/klog/v2@v2.110.1/klog.go:750 +0x1dd
k8s.io/klog/v2.(*loggingT).printf(...)
	k8s.io/klog/v2@v2.110.1/klog.go:727
k8s.io/klog/v2.Fatalf(...)
	k8s.io/klog/v2@v2.110.1/klog.go:1661
main.newAgentCommand.func1(0xc000278300?, {0xc000682e40, 0x0, 0x6})
	antrea.io/antrea/cmd/antrea-agent/main.go:53 +0x2d1
github.com/spf13/cobra.(*Command).execute(0xc000616000, {0xc000146010, 0x6, 0x6})
	github.com/spf13/cobra@v1.8.0/command.go:987 +0xaa3
github.com/spf13/cobra.(*Command).ExecuteC(0xc000616000)
	github.com/spf13/cobra@v1.8.0/command.go:1115 +0x3ff
github.com/spf13/cobra.(*Command).Execute(...)
	github.com/spf13/cobra@v1.8.0/command.go:1039
main.main()
	antrea.io/antrea/cmd/antrea-agent/main.go:32 +0x18

After the automatic restart, the Agent was running correctly as expected. So this is not a major issue in any way, just a small inconvenience.
To Reproduce
It doesn't happen very often, but this was observed during a standard install:
kind create cluster --config ci/kind/config-3nodes.yml
helm install -n kube-system antrea antrea/antrea

You may notice that the logs above show that the Agent was installed in noEncap mode. However, I have observed this same issue once in encap mode and once in noEncap mode, during 2 separate installations.
Versions:
Antrea v2.0.0
Additional context
The matching ovs-vswitchd logs:
root@kind-worker2:/# cat /var/log/antrea/openvswitch/ovs-vswitchd.log
2024-06-18T18:39:12.870Z|00001|vlog|INFO|opened log file /var/log/openvswitch/ovs-vswitchd.log
2024-06-18T18:39:12.965Z|00002|ovs_numa|INFO|Discovered 8 CPU cores on NUMA node 0
2024-06-18T18:39:12.965Z|00003|ovs_numa|INFO|Discovered 1 NUMA nodes and 8 CPU cores
2024-06-18T18:39:12.972Z|00004|reconnect|INFO|unix:/var/run/openvswitch/db.sock: connecting...
2024-06-18T18:39:12.972Z|00005|netlink_socket|INFO|netlink: could not enable listening to all nsid (Operation not permitted)
2024-06-18T18:39:12.973Z|00006|reconnect|INFO|unix:/var/run/openvswitch/db.sock: connected
2024-06-18T18:39:13.163Z|00007|dpif_netlink|INFO|Datapath dispatch mode: per-cpu
2024-06-18T18:39:13.166Z|00008|ofproto_dpif|INFO|system@ovs-system: Datapath supports recirculation
2024-06-18T18:39:13.166Z|00009|ofproto_dpif|INFO|system@ovs-system: VLAN header stack length probed as 2
2024-06-18T18:39:13.166Z|00010|ofproto_dpif|INFO|system@ovs-system: MPLS label stack length probed as 3
2024-06-18T18:39:13.167Z|00011|ofproto_dpif|INFO|system@ovs-system: Datapath supports truncate action
2024-06-18T18:39:13.167Z|00012|ofproto_dpif|INFO|system@ovs-system: Datapath supports unique flow ids
2024-06-18T18:39:13.167Z|00013|ofproto_dpif|INFO|system@ovs-system: Datapath supports clone action
2024-06-18T18:39:13.167Z|00014|ofproto_dpif|INFO|system@ovs-system: Max sample nesting level probed as 10
2024-06-18T18:39:13.167Z|00015|ofproto_dpif|INFO|system@ovs-system: Datapath supports eventmask in conntrack action
2024-06-18T18:39:13.168Z|00016|ofproto_dpif|INFO|system@ovs-system: Datapath supports ct_clear action
2024-06-18T18:39:13.168Z|00017|ofproto_dpif|INFO|system@ovs-system: Max dp_hash algorithm probed to be 1
2024-06-18T18:39:13.168Z|00018|ofproto_dpif|INFO|system@ovs-system: Datapath supports check_pkt_len action
2024-06-18T18:39:13.168Z|00019|ofproto_dpif|INFO|system@ovs-system: Datapath supports timeout policy in conntrack action
2024-06-18T18:39:13.168Z|00020|ofproto_dpif|INFO|system@ovs-system: Datapath supports ct_zero_snat
2024-06-18T18:39:13.168Z|00021|ofproto_dpif|INFO|system@ovs-system: Datapath supports add_mpls action
2024-06-18T18:39:13.168Z|00022|ofproto_dpif|INFO|system@ovs-system: Datapath supports ct_state
2024-06-18T18:39:13.169Z|00023|ofproto_dpif|INFO|system@ovs-system: Datapath supports ct_zone
2024-06-18T18:39:13.169Z|00024|ofproto_dpif|INFO|system@ovs-system: Datapath supports ct_mark
2024-06-18T18:39:13.171Z|00025|ofproto_dpif|INFO|system@ovs-system: Datapath supports ct_label
2024-06-18T18:39:13.171Z|00026|ofproto_dpif|INFO|system@ovs-system: Datapath supports ct_state_nat
2024-06-18T18:39:13.172Z|00027|ofproto_dpif|INFO|system@ovs-system: Datapath supports ct_orig_tuple
2024-06-18T18:39:13.172Z|00028|ofproto_dpif|INFO|system@ovs-system: Datapath supports ct_orig_tuple6
2024-06-18T18:39:13.172Z|00029|ofproto_dpif|INFO|system@ovs-system: Datapath does not support IPv6 ND Extensions
2024-06-18T18:39:13.195Z|00030|bridge|INFO|bridge br-int: using datapath ID 0000fe9402641648
2024-06-18T18:39:13.195Z|00031|connmgr|INFO|br-int: added service controller "punix:/var/run/openvswitch/br-int.mgmt"
2024-06-18T18:39:13.209Z|00002|vlog(monitor)|INFO|closing log file
2024-06-18T18:39:13.209Z|00032|bridge|INFO|ovs-vswitchd (Open vSwitch) 2.17.7
2024-06-18T18:39:16.072Z|00033|bridge|INFO|bridge br-int: added interface antrea-gw0 on port 32769
2024-06-18T18:39:18.042Z|00034|ofproto_dpif_upcall|INFO|Overriding n-handler-threads to 8, setting n-revalidator-threads to 3
2024-06-18T18:39:18.043Z|00035|ofproto_dpif_upcall|INFO|Starting 11 threads
2024-06-18T18:39:23.040Z|00036|memory|INFO|116644 kB peak resident set size after 10.2 seconds
2024-06-18T18:39:23.041Z|00037|memory|INFO|handlers:8 idl-cells:96 ofconns:1 ports:1 revalidators:3 rules:92
2024-06-18T18:39:27.010Z|00038|bridge|INFO|bridge br-int: added interface coredns--d86282 on port 1
2024-06-18T18:39:27.022Z|00001|ofproto_dpif_xlate(handler8)|INFO|/proc/sys/net/core/netdev_max_backlog: open failed (No such file or directory)
2024-06-18T18:39:27.054Z|00039|bridge|INFO|bridge br-int: added interface coredns--49f73e on port 2
2024-06-18T18:39:27.054Z|00040|bridge|INFO|bridge br-int: added interface local-pa-0db489 on port 3
2024-06-18T18:39:27.055Z|00041|bridge|INFO|bridge br-int: added interface antrea-t-e136b1 on port 4
2024-06-18T18:39:27.318Z|00042|connmgr|INFO|br-int<->unix#2: 118 flow_mods in the 9 s starting 10 s ago (113 adds, 1 deletes, 4 modifications)
2024-06-18T18:40:27.304Z|00043|connmgr|INFO|br-int<->unix#2: 14 flow_mods in the 19 s starting 48 s ago (14 adds)

Some more details here:
As you can see from the logs, the CLI call to check supported DP features (error is reported at 18:39:13.014321) happened before the ofproto-dpif provider started checking for supported features (2024-06-18T18:39:13.166Z). Obviously this is an issue in itself. However, the error reported by the Agent indicates that while the CLI server has been started, the CLI command we are invoking has not been registered yet.
This would indicate that the init factory function for ofproto-dpif has not been called yet: https://github.com/openvswitch/ovs/blob/f15de6508ce2ef60bb1a9d5baf0bf4a393a70d37/ofproto/ofproto-dpif.c#L267
I believe that indicates that bridge_init_ofproto has not been called yet: https://github.com/openvswitch/ovs/blob/f15de6508ce2ef60bb1a9d5baf0bf4a393a70d37/vswitchd/bridge.c#L3301-L3305
One possible explanation for this is that ovs-vswitchd is not done retrieving OVSDB contents: https://github.com/openvswitch/ovs/blob/f15de6508ce2ef60bb1a9d5baf0bf4a393a70d37/vswitchd/bridge.c#L3287-L3291
I believe that the solution proposed in #6472 will resolve the issue: it waits for the bridge (br-int) datapath ID to become available in OVSDB before querying supported datapath features.
Here is why:

it means that bridge_configure_datapath_id has been called: https://github.com/openvswitch/ovs/blob/f15de6508ce2ef60bb1a9d5baf0bf4a393a70d37/vswitchd/bridge.c#L1311. You can actually see the corresponding log entry in the ovs-vswitchd logs above.
it means that the necessary ofproto instance has been created: https://github.com/openvswitch/ovs/blob/f15de6508ce2ef60bb1a9d5baf0bf4a393a70d37/vswitchd/bridge.c#L885
it means that ofproto-dpif provider has been constructed: https://github.com/openvswitch/ovs/blob/f15de6508ce2ef60bb1a9d5baf0bf4a393a70d37/ofproto/ofproto.c#L555
which means that we have opened the dpif backer, checked for feature support, and that we have associated the bridge with the dpif backer
of course it also means that the init factory function (which registers the CLI commands) has been called, otherwise calling construct would not be possible

I think that's a better solution that checking the OVS datapath features in a loop until it succeeds, even though that's debatable :P


Now Homebridge loaded up correctly but in Home.app everything is in updating status forever
Thu, 05 Jan 2017 15:34:25 GMT Accessory [Homebridge] Processing characteristic set: [{"aid":11,"iid":9,"ev":true},{"aid":11,"iid":10,"ev":true},{"aid":11,"iid":11,"ev":true}]
Thu, 05 Jan 2017 15:34:25 GMT Accessory [Homebridge] Registering Characteristic "Battery Level" for events
Thu, 05 Jan 2017 15:34:25 GMT Accessory [Homebridge] Registering Characteristic "Charging State" for events
Thu, 05 Jan 2017 15:34:25 GMT Accessory [Homebridge] Registering Characteristic "Status Low Battery" for events
Thu, 05 Jan 2017 15:34:25 GMT EventedHTTPServer [::ffff:<IP_ADDRESS>] HTTP Response is finished
Thu, 05 Jan 2017 15:34:33 GMT EventedHTTPServer [::ffff:<IP_ADDRESS>] HTTP request: /characteristics?id=3.9
Thu, 05 Jan 2017 15:34:33 GMT HAPServer [3C:15:C2:BE:72:30] HAP Request: GET /characteristics?id=3.9
Thu, 05 Jan 2017 15:34:33 GMT Accessory [Homebridge] Getting value for Characteristic "On"
Thu, 05 Jan 2017 15:34:33 GMT Accessory [Homebridge] Got Characteristic "On" value: false
Thu, 05 Jan 2017 15:34:33 GMT EventedHTTPServer [::ffff:<IP_ADDRESS>] HTTP Response is finished
Thu, 05 Jan 2017 15:35:02 GMT EventedHTTPServer [::ffff:<IP_ADDRESS>] HTTP request: /characteristics?id=2.9,4.19,4.15,4.12,4.25,10.9,5.17,5.14,9.9
Thu, 05 Jan 2017 15:35:02 GMT HAPServer [3C:15:C2:BE:72:30] HAP Request: GET /characteristics?id=2.9,4.19,4.15,4.12,4.25,10.9,5.17,5.14,9.9
Thu, 05 Jan 2017 15:35:02 GMT Accessory [Homebridge] Getting value for Characteristic "On"
Thu, 05 Jan 2017 15:35:02 GMT Accessory [Homebridge] Got Characteristic "On" value: false
Thu, 05 Jan 2017 15:35:02 GMT Accessory [Homebridge] Getting value for Characteristic "Current Relative Humidity"
Thu, 05 Jan 2017 15:35:02 GMT Accessory [Homebridge] Getting value for Characteristic "Carbon Dioxide Detected"
Thu, 05 Jan 2017 15:35:02 GMT Accessory [Homebridge] Getting value for Characteristic "Air Quality"
Thu, 05 Jan 2017 15:35:02 GMT Accessory [Homebridge] Getting value for Characteristic "Current Temperature"
Thu, 05 Jan 2017 15:35:02 GMT Accessory [Homebridge] Getting value for Characteristic "Occupancy Detected"
Thu, 05 Jan 2017 15:35:02 GMT Accessory [Homebridge] Got Characteristic "Occupancy Detected" value: false
Thu, 05 Jan 2017 15:35:02 GMT Accessory [Homebridge] Getting value for Characteristic "Current Temperature"
Thu, 05 Jan 2017 15:35:02 GMT Accessory [Homebridge] Getting value for Characteristic "Current Relative Humidity"
Thu, 05 Jan 2017 15:35:02 GMT Accessory [Homebridge] Getting value for Characteristic "Occupancy Detected"
Thu, 05 Jan 2017 15:35:02 GMT Accessory [Homebridge] Got Characteristic "Occupancy Detected" value: true
Thu, 05 Jan 2017 15:35:03 GMT Accessory [Homebridge] Got Characteristic "Carbon Dioxide Detected" value: 0
Thu, 05 Jan 2017 15:35:03 GMT Accessory [Homebridge] Got Characteristic "Current Temperature" value: 6.2
Thu, 05 Jan 2017 15:35:21 GMT EventedHTTPServer [::ffff:<IP_ADDRESS>] Client connection closed
Thu, 05 Jan 2017 15:35:21 GMT EventedHTTPServer [::ffff:<IP_ADDRESS>] HTTP connection was closed
Thu, 05 Jan 2017 15:35:21 GMT EventedHTTPServer [::ffff:<IP_ADDRESS>] HTTP server was closed


Explain the effect of the "Client Secret" setting

It seems like you can use the "Client Secret" setting to switch from implicit flow to hybrid flow.
I found a post on techcommunity that pointed me to that effect. According to my tests, this is true.
If this is so, it would be great if the effect would be mentioned in this documentation.
Thanks a lot
Peter

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 6f1c454d-73bc-5a73-5d3f-1b1ca7625044
Version Independent ID: 552b3f09-6650-e7f7-01f2-a702005b83e9
Content: Configure Azure AD authentication - Azure App Service
Content Source: articles/app-service/configure-authentication-provider-aad.md
Service: app-service
GitHub Login: @cephalin
Microsoft Alias: cephalin

Thanks for the feedback! We are currently investigating and will update you shortly.

I've submitted an update to the doc to better clarify client secret @Peter-B. Thank you for your feedback.

Thanks a lot.


Scene background

https://threejs.org/docs/#api/scenes/Scene.background
Should be an enum of texture/color/none.

Color background is long supported, removing the milestone tag.

Closed in favor #102 and #101


AMBARI-25850 : Need to update com.h2database:h2 dependency

What changes were proposed in this pull request?
Issue:
Need to update com.h2database:h2 dependency
Changes:
Updated com.h2database:h2 dependency to latest available version.
How was this patch tested?
Validated ambari-server started successfully.

+1,


bug(mat-checkbox): Incorrect value ('on') for @Input FormControl

Is this a regression?

[ ] Yes, this behavior used to work in the previous version

The previous version in which this bug was not present was
No response
Description
When using mat-checkbox with [formControl] and providing to it FormControl created inside the same component that implements <mat-checkbox> then value of this control is true/false but when we provide identical FormControl but from @Input in the component then the value of such control after first interaction is set to 'on' and stay that way forever.
Reproduction
Steps to reproduce:

Create component which implements <mat-checkbox> with [formControl] attribute
Add @Input formControl: FormControl to the component and use it to provide FormControl to the mat-checkbox
Observe value of provided FormControl.

StackBlitz: https://stackblitz.com/edit/angular-ivy-6c3wq8
Expected Behavior
Value of FormControl should always be true/false no matter where FormControl was originated.
Actual Behavior
FormControl value (provided via @Input) after first interaction is set to 'on' and stay that way forever.
Environment

Angular: 15.1.1
CDK/Material: 15.1.1
Browser(s): all
Operating System (e.g. Windows, macOS, Ubuntu): all

This appears to be a result of the ngDefaultControl directive you added. That provides an instance of DefaultValueAcessor, but a checkbox should be using a CheckboxValueAccessor Removing the attribute makes it behave normally: https://stackblitz.com/edit/angular-ivy-hqtjk5?file=src%2Fapp%2Fapp.component.html


Fix root-dir-only example

In the README, an example is given for how to match only files in the root directory of the repository.  One crucial character is missing, however, preventing the example from working.  Specifically, the example needs to begin with ./ (not just /) in order to be interpreted as a relative path but not to trigger setting micromatch's matchBase option.  Without that dot, the path is interpreted as an absolute one and fails to match as a relative path.

Thanks!

Done!

:tada: This PR is included in version 10.0.0-beta.4 :tada:
The release is available on:

npm package (@beta dist-tag)
GitHub release

Your semantic-release bot :package::rocket:

:tada: This PR is included in version 9.5.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


UI/UX improvement

Please I would love the UI/UX of eSteem mobile app to be more streamlined with devices. Download latest Gmail app from PlayStore to see what I'm talking about. I have seen couple of apps using that model/material design and their products are great. This is also the reason people still prefers Partiko's interface to eSteem.
PS: It’s like an environment of app where users don't know they are switching from one part of the app to another and in a reality they are doing it.
@feruzm

@horpeyloaded thanks, please do share some screenshots here or on discord to get better idea, because gmail might have slightly different views on different devices.

Waiting for the next release to see what has been improved in eSteem UX/UI. I can't seem to send screenshot of the app UI I'm talking about.
I can only explain, what I notice is that, if a user opens Android App I enjoyed using and Partiko, it will seem as if they were still hovering their phone literally without opened app, user won't feel the effect of app they just opened on their phone, let me just say app flexibility.

Right now, each page being revisited and improved in 2.2.3, if changes are bigger and requires substantial changes it is moved to next major update. What we are doing right now, having dedicated wallet for tokens, more obvious access points, getting rid of some dropdowns, etc. etc.


[FIX] tasks/generateResourcesJson: Handling for sap.ui.integration

Coverage decreased (-0.03%) to 92.8% when pulling 1fd1c62f7a9f5dedec9985a32c603ed5667a34c9 on fix-createResourcesJson-sap-ui-integration into 537cca5365c93dba98b791e5cec85ffd12a8b0ed on master.

Is a new release of builder and cli planned so that we can benefit from this fix in our integration scenario?

I just triggered a release 👍🏻


cpputest.github.com link is dead

The link in the About section is dead:
.
It was probably ported to https://cpputest.github.io/, but it wasn't updated anywhere on this github repo.

Thanks, fixed


Possible handle multithread

Is it possible to build a multithread system to handle the instance of Ghostscript?

This is what say Ghostscript documentation

Create a new instance of Ghostscript. This instance is passed to most other gsapi functions. The caller_handle will be provided to callback functions. Unless Ghostscript has been compiled with the GS_THREADSAFE define, only one instance at a time is supported.
Historically, Ghostscript has only supported a single instance; any attempt to create more than one at a time would result in gsapi_new_instance returning an error. Experimental work has been done to lift this restriction; if Ghostscript is compiled with the GS_THREADSAFE define then multiple concurrent instances are permitted.
While the core Ghostscript devices are believed to be thread safe now, certain devices are known not to be (particularly the contrib devices). The makefiles currently make no attempt to exclude these from builds. If you enable GS_THREADSAFE then you should check to ensure that you do not rely on such devices (check for global variable use).

So as expressd in documentation there are some devices that not support multiple Ghostscript instances, so for now my idea is to be coherent and safe and secure with all the devices.

any possible to make this concurrent?


Error while installing libpq library

Host Environment

OS: Windows 10 Pro 21H1 19043.1348
Compiler: MSVC

To Reproduce
Steps to reproduce the behavior:
./vcpkg install libpq:x64-windows
Failure logs
Computing installation plan...
The following packages will be built and installed:
libpq[core,openssl,zlib]:x64-windows -> 12.2#20
Detecting compiler hash for triplet x64-windows...
Restored 0 packages from C:\Users\Bakel\AppData\Local\vcpkg\archives in 535.2 us. Use --debug to see more details.
Starting package 1/1: libpq:x64-windows
Building package libpq[core,openssl,zlib]:x64-windows...
-- Using cached postgresql-12.2.tar.bz2.
-- Cleaning sources at C:/vcpkg/vcpkg/buildtrees/libpq/src/tgresql-12-ef0b4889ed.clean. Use --editable to skip cleaning for the packages you specify.
-- Extracting source C:/vcpkg/vcpkg/downloads/postgresql-12.2.tar.bz2
-- Applying patch patches/windows/install.patch
-- Applying patch patches/windows/win_bison_flex.patch
-- Applying patch patches/windows/openssl_exe_path.patch
-- Applying patch patches/windows/Solution.patch
-- Applying patch patches/windows/MSBuildProject_fix_gendef_perl.patch
-- Applying patch patches/windows/msgfmt.patch
-- Applying patch patches/windows/python_lib.patch
-- Applying patch patches/windows/fix-compile-flag-Zi.patch
-- Applying patch patches/windows/minimize_install.patch
-- Using source at C:/vcpkg/vcpkg/buildtrees/libpq/src/tgresql-12-ef0b4889ed.clean
-- Copying libpq source files to C:/vcpkg/vcpkg/buildtrees/libpq/x64-windows-rel...
-- Copying libpq source files... done
CMake Deprecation Warning at scripts/ports.cmake:75 (message):
vcpkg_apply_patches has been deprecated in favor of the PATCHES argument
to vcpkg_from_*.
Call Stack (most recent call first):
scripts/cmake/vcpkg_apply_patches.cmake:18 (z_vcpkg_deprecation_message)
ports/libpq/portfile.cmake:127 (vcpkg_apply_patches)
scripts/ports.cmake:142 (include)
-- Applying patch patches/windows/Solution_RELEASE.patch
-- Applying patch patches/windows/python3_build_RELEASE.patch
-- Patches applied!
-- Building libpq x64-windows-RELEASE...
CMake Error at scripts/cmake/vcpkg_execute_required_process.cmake:127 (message):
Command failed: C:/vcpkg/vcpkg/downloads/tools/perl/<IP_ADDRESS>/perl/bin/perl.exe build.pl RELEASE libpq
Working Directory: C:/vcpkg/vcpkg/buildtrees/libpq/x64-windows-rel/src/tools/msvc
Error code: 1
See logs for more information:
C:\vcpkg\vcpkg\buildtrees\libpq\build-libpq-x64-windows-RELEASE-out.log
Call Stack (most recent call first):
ports/libpq/portfile.cmake:223 (vcpkg_execute_required_process)
scripts/ports.cmake:142 (include)
Error: Building package libpq:x64-windows failed with: BUILD_FAILED
Please ensure you're using the latest portfiles with .\vcpkg update, then
submit an issue at https://github.com/Microsoft/vcpkg/issues including:
Package: libpq:x64-windows
Vcpkg version: 2021-09-10-2059ef11aa6067e6f59b0d939c5d17e3c5c47d3e
Additional context
This library was installed with a more general command .\vcpkg install qt:x64-windows

Please do a git pull.

All wors fine now. Thanks for the correction


Image Classification (CNN)

@kabirnagpal Thanks for your contribution. Please integrate MLflow, a project dependency for ai-platform, into this pull request

Closed due to revised pull request: https://github.com/produvia/ai-platform/pull/63


Allow persistence and filtering

Motivation
Allow queue persistence and filtering.
Support use cases when:

Queue should only process mutations
Page was refreshed and queued elements will be removed

Implementation
Using interface that can match local storage or any other platform storage
No extra packages
No change in current behavior (additional object passed to add extra storage and filter )
TODO
More unit tests

Codecov Report

Merging #14 into master will decrease coverage by 25.86%.
The diff coverage is 55.88%.

@@             Coverage Diff             @@
##           master      #14       +/-   ##
===========================================
- Coverage     100%   74.13%   -25.87%
===========================================
  Files           1        1
  Lines          25       58       +33
  Branches        3       12        +9
===========================================
+ Hits           25       43       +18
- Misses          0       15       +15

Impacted Files
Coverage Δ

src/QueueLink.ts
74.13% <55.88%> (-25.87%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f0d77e4...f2a1b24. Read the comment docs.

Thabks for heads up. I haven't checked React Native use case yet. I think I need to improve this PR by:

Adding debug logging
Adding apollo client to reshedule operations (rebuild observer chain after restart)
Test both React Native and Browser use cases

I have done some experiments and I think that this PR will change behavior of the package to such extend that it will need to be renamed to not cause issues with current implementations
If you looking for already functional example of the queue with offline support see https://github.com/aerogear/offline-conflict-strategies/tree/master/web/src/sdk/mutations
Just copy this two classes into your app
I'm going to port that to separate apollo-link-offline-queue

Hi @wtrocki, first off, thanks a lot for the PR and my apologies for not responding sooner.
I agree that this is a fairly significant change that might be better off in a separate package.
Alternatively to this implementation for persisting the queue, how about adding public functions that allow getting and setting the content of the queue? That way, any necessary persistence/hydration for orderly shutdowns can be done by an external function.
If the goal is to provide persistence + replay even in the case of unplanned shutdowns, then I think that concern would be best solved in a separate link which persists operations while they're pending, and replays all operations on startup. However, like I commented in another thread, this will not give you the kind of offline support you may expect when using it with Apollo Client, because it's not enough for the link to replay the requests, the store also needs to know about pending operations if their results should be optimistically showed to the user.

Fully agree. Closing PR.


Capture and handle missing gRPCListenAddr for OTLP/gRPC requests

If a refinery config does not include a GRPCListenAddr and OTLP/gRPC requests are sent, requests use a fallthrough proxy path and produce unuseable data. Logs do not clearly indicate what has happened.
Refinery should reject gRPC requests if the gRPCListAddr is missing and clearly log why requests are rejected.

We have been unable to reproduce the scenario of gRPC requests not being properly rejected when a GRPCListenAddr is missing from the config. If this continues to be an issue please feel free to reopen.


Support for hover over image or location

In Sikuli, sometimes clicks does not work in Graphics Area, the solution for this is to first hover, wait and then click as specified here https://github.com/RaiMan/SikuliX-2014/issues/260
So adding support for hover command

Adding rightClick and dragDrop wrappers. End to End tests are not implemented for these.

Looks good! Also took the right click and drag/drop wrapper.
Small detail; the indentation is tabs everywhere. I added a .editorconfig, this should be picked up by Visual Studio 2017. I already fixed the indentation on your commits.
Thanks!


Support tagged templates in ES5 and ES3

Tagged templates are fairly easy to implement using ES5 and ES3, you simply turn the following:
fn`Hello ${you}! You're looking ${adjective} today!`

into the following:
fn(["Hello ", "! You're looking ", " today!"], you, adjective);

(sample taken from http://updates.html5rocks.com/2015/01/ES6-Template-Strings)

That has already been implemented in #1589. Note that the first argument of the downlevel call should have a raw property. We ended up with the following code:
(_a = ["Hello ", "! You're looking ", " today!"], _a.raw = ["Hello ", "! You're looking ", " today!"], fn(_a, you, adjective));
var _a;

Oh, damn, github search by default only searched open issues :-/.
Babel does more or less the same thing, except it uses a generated helper (and also does some Object.freeze if the browser supports it). I just tested this on the playground on the typescriptlang website, but I guess it hasn't been released yet.

Incoming in 1.5 :)

Great. Thanks. Sorry for duplicate issue :).

No worries - as a note, we thought about Object.freeze but I guess we were leaning towards the extremes of either doing it as correctly as possible (with making a cache of template strings arrays) or as cleanly as possible with ES3 compat (the way it is currently slated for 1.5). I think that the way @ivogabe did it is clean, canonical, and understandable.
Just for documentation, the duplicate issue is #1590.


Support for inserting a line after a matching line is found

It would be great if this cookbook had the ability to search for a matching line of text and then insert another line after it. It would certainly help keep things organized in config files and the like when templates are not a good option.
I'm going to be away for a bit, but if no one tackles it before I have time I can certainly give it a go myself and submit a PR. I think it should be similar to the replace_or_add functionality (insert_or_add perhaps?), but I can think of a number of edge cases that would need addressing.

Current syntax for this request in #101
filters = Line::Filter.new
filter_lines '/some/file' do
filter filters.method(:after)
filter_args [/pattern/, 'insert_line']
end

That looks excellent to me. Way above and beyond what I had been imagining no less. I'm interested to look through the code and see how it all works. Thank you for addressing my request!

Fixed by #121


Error trying too re-add config items that already exist

Puppet: 7.33
Distribution: RHEL8
Module version: 8.0.0

I've punted back to trying to use the openldap-servers RPM that is available in RHEL8 (openldap-servers-2.4.46-19.el8_10.x86_64), and initially the module works OK, but now I've got the problem where it is trying to re-add all of the olcGlobal items again which fails as most of those are single types.  E.g. the error is:
olcTLSProtocolMin: no equality matching rule
The entries are definitely already there:
# /sbin/slapcat -b cn=config -o ldif-wrap=no -H 'ldap:///???(objectClass=olcGlobal)'
dn: cn=config
objectClass: olcGlobal
cn: config
structuralObjectClass: olcGlobal
entryUUID: 7f44c206-0d72-103f-8861-2d25516adbe5
creatorsName: cn=config
createTimestamp:<PHONE_NUMBER>0802Z
olcTLSCertificateFile: /etc/pki/tls/certs/server.pem
olcTLSCertificateKeyFile: /etc/pki/tls/private/server.key
olcTLSProtocolMin: 3.3
olcTLSCipherSuite: HIGH
olcLocalSSF: 128
olcSecurity: ssf=128
olcSecurity: simple_bind=128
olcSecurity: update_ssf=128

This started after adding some schemas, adding modules, and adding ACLs to the basedn.  Slapcat still works via the ldapi:/// and ldap:/// interfaces for root so it doesn't seem to be an ACL issue.
I can't tell from the debug output provided by the module what is missing.

What does puppet resource openldap_global_conf TLSProtocolMin say?  What does your catalog look like?  Anything interesting from puppet resource openldap_global_conf comparing to what you see above?
Ideally a minimal example reproducing the problem would help.

What does puppet resource openldap_global_conf TLSProtocolMin say?

# puppet resource openldap_global_conf TLSProtocolMin
openldap_global_conf { 'TLSProtocolMin':
  ensure   => 'present',
  provider => 'olc',
  value    => '3.3',
}

What does your catalog look like?

The globalconf section is this:
openldap::server::globalconf { 'GlobalConf':
        ensure  => present,
        value   => {
          'TLSProtocolMin' => '3.3',
          'TLSCipherSuite' => 'HIGH',
          'LocalSSF'       => '128',
          'SizeLimit'      => 'size.soft=50000 size.hard=50000',
          'Security'       => [
            'ssf=128',
            'simple_bind=128',
            'update_ssf=128'
           ],
          'ServerID'       => [
            '1001 ldap://server1.XXX.YYY',
            '1002 ldap://server2.XXX.YYY',
            '1003 ldap://server3.XXX.YYY',
          ]
        }
      }

Anything interesting from puppet resource openldap_global_conf comparing to what you see above?

# puppet resource openldap_global_conf
openldap_global_conf { 'LocalSSF':
  ensure   => 'present',
  provider => 'olc',
  value    => '128',
}
openldap_global_conf { 'Security':
  ensure   => 'present',
  provider => 'olc',
  value    => ['ssf=128', 'simple_bind=128', 'update_ssf=128'],
}
openldap_global_conf { 'ServerID':
  ensure   => 'present',
  provider => 'olc',
  value    => ['1001 ldap://server1.XXX.YYY', '1002 ldap://server2.XXX.YYY', '1003 ldap://server3.XXX.YYY'],
}
openldap_global_conf { 'TLSCertificateFile':
  ensure   => 'present',
  provider => 'olc',
  value    => '/etc/pki/tls/certs/server.pem',
}
openldap_global_conf { 'TLSCertificateKeyFile':
  ensure   => 'present',
  provider => 'olc',
  value    => '/etc/pki/tls/private/server.key',
}
openldap_global_conf { 'TLSCipherSuite':
  ensure   => 'present',
  provider => 'olc',
  value    => 'HIGH',
}
openldap_global_conf { 'TLSProtocolMin':
  ensure   => 'present',
  provider => 'olc',
  value    => '3.3',
}

The globalconf section is this:
openldap::server::globalconf { 'GlobalConf':
        ensure  => present,
        value   => {
          'TLSProtocolMin' => '3.3',
          'TLSCipherSuite' => 'HIGH',
          'LocalSSF'       => '128',
          'SizeLimit'      => 'size.soft=50000 size.hard=50000',
          'Security'       => [
            'ssf=128',
            'simple_bind=128',
            'update_ssf=128'
           ],
          'ServerID'       => [
            '1001 ldap://server1.XXX.YYY',
            '1002 ldap://server2.XXX.YYY',
            '1003 ldap://server3.XXX.YYY',
          ]
        }
      }

If I am correct, this should rather match what puppet resource openldap_global_conf output, that is multiple openldap::server::globalconf resources that configure a single item each, e.g.  from my control repo configuration:
  openldap::server::globalconf { 'LogLevel':
    value => 'stats',
  }

  openldap::server::globalconf { 'TLSProtocolMin':
    # 3.3 = TLS 1.2+
    value => '3.3',
  }

OK, I'll try it like that


desktop: Check that icon file from desktop file is actually installed

This should not be breaking as without the correct icon from the desktop file installed, appstream will not create files/share/app-info/icons/{appid}.png.
We already check that files/share/app-info/icons/{appid}.png exists and icons following the flatpak id patterns exist in files/share/icons/hicolor/*/apps/* but not if the icon defined in the main desktop file exist.
This plugs that hole.
See for example https://github.com/flathub/ml.mdwalters.Lemonade/pull/9#issuecomment-2069961956
The linter is saying:
    "errors": [
        "appstream-missing-icon-file",
        "appstream-missing-icon-key"
    ],

but the root cause is, the desktop file icon ml.mdwalters.Lemonade not existing in files/share/icons/hicolor/*/apps/*.
This is not caught by any other checks as the icon that is installed follows the exportable pattern: ml.mdwalters.Lemonade.Devel.svg

Now https://github.com/flathub/ml.mdwalters.Lemonade/pull/9#issuecomment-2069961956 should look like, (which is better than before):
{
    "errors": [
        "desktop-file-icon-not-installed",
        "appstream-missing-icon-file"
    ],
    "warnings": [
        "appstream-screenshot-missing-caption"
    ],
    "message": "Please consult the documentation at https://docs.flathub.org/docs/for-app-authors/linter"
}


DSET-4002: Initial implemntation of the ServerHost

🥅 Goal
Make sure that information about the server host is correctly propagated to the DataSet backend with all its peculiarities.
🛠 Solution

Introduce configuration option to allow specifying ServerHost attribute. Either directly or from the node host name.
Modify events in the following way:
For each event fill in the attribute __origServerHost either from the attribute serverHost or from the global ServerHost attribute.
Modify group_by configuration so that it contains __origServerHost. This will cause that all the events from the same group belong to the same serverHost.
Set SessionInfo.serverHost to contain the value that is shared among events in the same group.
Remove attribute __origServerHost from the events.

This algorithm guarantees, that serverHost is passed on the session level and there is no need to have it per event level.
Implementation is inspired by https://github.com/scalyr/logstash-output-scalyr/blob/master/lib/logstash/outputs/scalyr.rb
🏫 Testing

I have added several unit tests - TestAddEventsServerHostLogic - to check that the serverHost is handled correctly.
When I run: make test-many-times COUNT=10 - it always succeeds.

⏭ Next Step
After this gets merged, we have to increase the library version. Once the new version of library is released, we can implement the logic in the datasetexporter.

Codecov Report

Merging #39 (b29c521) into main (16f9f00) will increase coverage by 0.32%.
The diff coverage is 81.15%.

@@            Coverage Diff             @@
##             main      #39      +/-   ##
==========================================
+ Coverage   75.14%   75.46%   +0.32%
==========================================
  Files          10       11       +1
  Lines        1404     1508     +104
==========================================
+ Hits         1055     1138      +83
- Misses        290      307      +17
- Partials       59       63       +4

Impacted Files
Coverage Δ

pkg/api/add_events/add_events.go
72.97% <0.00%> (-7.62%)
:arrow_down:

pkg/client/client.go
87.08% <73.91%> (-1.81%)
:arrow_down:

pkg/config/config.go
86.67% <84.21%> (-1.94%)
:arrow_down:

pkg/server_host_config/server_host_config.go
85.00% <85.00%> (ø)

pkg/api/add_events/event_bundle.go
100.00% <100.00%> (ø)

pkg/client/add_events.go
87.30% <100.00%> (+3.11%)
:arrow_up:

Besides this (https://github.com/scalyr/dataset-go/pull/39/files#r1258140185), LGTM.
So once we agree on how to proceed there, we can get it merged, implement it in the otel exporter and then go from there - deploy latest version and add some benchmarks (events with many different serverHost values) and see how it behaves / what the throughput is like.


Have Favorites act like a category

Reasoning: we can group games by category, but Favorite doesn't get grouped like the rest. And it'd be pointless to simply create a "Favorite" category. (Also it wouldn't be at the top like Steam, but that's a minor priority)

https://github.com/JosefNemec/Playnite/issues/207


Ray not working with PHP 8.3

On my Windows 10, I use WampServer and Laragon, and on both Ray works fine with PHP 8.2
When I switch to PHP 8.3, with the php.ini identical, I'm getting error:
Error: Error: Call to undefined function ray() in file xxx.php line xxx

OK, I see the problem: you didn't provide:
ray_php_8.3.phar
in https://github.com/spatie/global-ray/tree/main/ray-phars :(
But that's what the global-ray is looking for:
class Ray
{
    public static function getPharPath()
    {
        $phpVersion = PHP_MAJOR_VERSION . '.' . PHP_MINOR_VERSION;

        return __DIR__ . "/../../ray-phars/ray_php_{$phpVersion}.phar";
    }
}

When are you going to update it?

We now support PHP 8.3


Paralyze Field

Paralyze Field
Is there a problem?
When I stand in Paralyze Field, I use the fireball to attack myself.
When I cast a spell to attack myself more than 2 times, Paralyze Field will lose its effect.

First of all, you shouldn't be able to cast a spell if you're paralyzed. Are you testing with GM mode on?

Use marco magic
It is possible to cast spells

field spell are the same problem

Paralyzation field bug reported to be caused by custom scripts


ENH: update package version

Hi! This is the friendly automated conda-forge-webservice.
I've started a version update as instructed in #27.
I'm currently searching for new versions and will update this PR shortly if I find one! Thank you for waiting!
Fixes #27

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.
I do have some suggestions for making it better though...
For recipe/meta.yaml:

ℹ The recipe is not parsable by parser conda-forge-tick (the bot). Your recipe  may not receive automatic updates and/or may not be compatible with conda-forge's infrastructure. Please check the logs for more information and ensure your recipe can be parsed.
ℹ The recipe is not parsable by parser conda-recipe-manager. The recipe can only be automatically migrated to the new v1 format if it is parseable by conda-recipe-manager.

This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/12508684425. Examine the logs at this URL for more detail.

Hi! This is the friendly automated conda-forge-webservice.
I tried to update the version and rerender for you but ran into some issues. Please check the output logs of the GitHub Actions workflow below for more details. You can also ping conda-forge/core (using the @ notation) for further assistance or you can try rerendering locally.
The following suggestions might help debug any issues:

Is the recipe/{meta.yaml,recipe.yaml} file valid?
If there is a recipe/conda-build-config.yaml file in the feedstock make sure that it is compatible with the current global pinnnings.
Is the fork used for this PR on an organization or user GitHub account? Automated rerendering via the webservices admin bot only works for user GitHub accounts.

This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/12508684252. Examine the logs at this URL for more detail.

error
 Error parsing recipe with conda-forge-tick (the bot): AttributeError("'If' object has no attribute 'nodes'")

This PR can be closed as obsoleted by #29


Retry tokens events consistent with FFDX, as we cannot push back nack

Make this consistent with what we did for FFDX, and prevents a scenario on startup as seen in the integration test where a token event comes in before the namespace is started:
firefly_core_0_1  | [2023-04-30T00:35:08.431Z] DEBUG Calling TokenPoolCreated callback. Locator='address=0x8875e026c26cedc2ab9880ac56d31e328428db73&schema=ERC20WithData&type=fungible' TX=token_pool/66fffabe-5b11-4118-abc2-50b95877654d pid=1 proto=fftokens role=event-loop
firefly_core_0_1  | [2023-04-30T00:35:08.431Z] ERROR Event loop exiting (FF10446: Namespace 'default' is not started). Terminating server! pid=1 proto=fftokens role=event-loop

Also made a change to both FFDX and FFTokens to split eventRetry out from retry in the config, as I realized looking at this PR that the config was overlapping with the ffresty config for request retry.

Codecov Report

Merging #1296 (e050024) into main (2c30d54) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##              main     #1296   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files          308       308
  Lines        20678     20692   +14
=========================================
+ Hits         20678     20692   +14

Impacted Files
Coverage Δ

internal/tokens/fftokens/config.go
100.00% <100.00%> (ø)

internal/tokens/fftokens/fftokens.go
100.00% <100.00%> (ø)

https://github.com/hyperledger/firefly/pull/1296#issuecomment-1533252738 appears unrelated to the change, but does need diagnosis. Raised https://github.com/hyperledger/firefly/issues/1297

fixes https://github.com/hyperledger/firefly/pull/1296


Website homepage

Data for examples: https://observablehq.com/d/fa9bfd80157024e7
Content needed:

[x] Time series data - all/scrollable (the panning gesture needs an interpolation function to look decent)
[x] Bar chart w error bars - grouped by month
[ ] Dot plot with tukey behind - grouped by city/series

Other options: svg/canvas, color scheme
Hint to try resizing the window OR additional control to just shrink the plot area

For HomepageTimeseries:

When you hover over a data point, it displays the corresponding data down below the chart. I'd be nice for it to appear next to the hovered data point.
The highlighting of data points feels a bit quirky – it's fine when you're right on top of one data point, but then when you're moving the mouse around it seems to arbitrarily select data points to highlight, not necessarily the closest one. See attached movie. My expectation would be that if you've hovered on something and then move away from it, nothing should be highlighted anymore until you hover over something else.

Just putting the above into a checklist:

[ ] visual indication of where you are within the data (faux scrollbar?)
[ ] ability to zoom (see #81 )
[ ] use tooltips instead of displaying info below the chart (design)


MODULE_NOT_FOUND error after updating to latest CLI version

Note
Before you submit your issue, make sure that:

You're using the latest version of Salesforce CLI.
You've searched both open and closed issues for related posts.
You've used the doctor command to diagnose common issues.
You understand that GitHub Issues don't adhere to any agreement or SLA.

If you require immediate assistance, use official channels such as Salesforce Customer Support.

Summary
I was prompted to update to the latest version of the CLI.  I did so and now when I run the following command:
sf package create --name PACKAGE_NAME --package-type Unlocked --path force-app
I receive an error message (see results)
I have tried the latest version of the CLI, and I installed an older version (2.43.3) and received the same result.
This was working a few weeks ago when I generated a new version of the package I am working with.
Steps To Reproduce
Update to latest version of CLI using
sf update
Try and run the package create command:
sf package create --name PACKAGE_NAME --package-type Unlocked --path force-app

IMPORTANT
Provide a repository that's configured to reproduce the issue. If you are unable to provide a repo, please explain why not. The more info we have from the start, the faster we can resolve your issue.
We may close your issue if you don't include proper instructions.

Generate a project with sf project generate or fork dreamhouse-lwc.
Provide detailed step-by-step instructions on how to reproduce the issue.

[!TIP]
use sf doctor --create-issue to automatically fill the required information

Expected result
Package version is created
File sfdx-project.json is updated with the latest version
Package is ready to be marked as published
Actual result
Error message received:
ModuleLoadError: [MODULE_NOT_FOUND] require failed to load   ›<EMAIL_ADDRESS>Cannot find module 'glob'  ›   Require stack:  ›   -<EMAIL_ADDRESS>›   -<EMAIL_ADDRESS>›   -<EMAIL_ADDRESS>›   -<EMAIL_ADDRESS>›   -<EMAIL_ADDRESS>›   -<EMAIL_ADDRESS>›   -<EMAIL_ADDRESS>›   -<EMAIL_ADDRESS>›   -<EMAIL_ADDRESS>›   -<EMAIL_ADDRESS>›   -<EMAIL_ADDRESS>›   -<EMAIL_ADDRESS>›   Code: MODULE_NOT_FOUND
Additional information

System Information

Terminal = bash
OS Version = Sonoma 14.6.1 (23G93)

{
  "architecture": "darwin-arm64",
  "cliVersion"<EMAIL_ADDRESS>  "nodeVersion": "node-v20.17.0",
  "osVersion": "Darwin 23.6.0",
  "rootPath": "/Users/simonmolloy/.local/share/sf/client/2.58.7-ed27925",
  "shell": "zsh",
  "pluginVersions": [
    "@oclif/plugin-autocomplete 3.2.2 (core)",
    "@oclif/plugin-commands 4.0.13 (core)",
    "@oclif/plugin-help 6.2.10 (core)",
    "@oclif/plugin-not-found 3.2.18 (core)",
    "@oclif/plugin-plugins 5.4.6 (core)",
    "@oclif/plugin-search 1.2.7 (core)",
    "@oclif/plugin-update 4.5.5 (core)",
    "@oclif/plugin-version 2.2.11 (core)",
    "@oclif/plugin-warn-if-update-available 3.1.13 (core)",
    "@oclif/plugin-which 3.2.12 (core)",
    "@salesforce/cli 2.58.7 (core)",
    "apex 3.4.8 (core)",
    "api 1.2.1 (core)",
    "auth 3.6.54 (core)",
    "data 3.6.5 (core)",
    "deploy-retrieve 3.12.3 (core)",
    "info 3.4.3 (core)",
    "limits 3.3.29 (core)",
    "marketplace 1.2.25 (core)",
    "org 4.5.7 (core)",
    "packaging 1.26.3 (user)",
    "schema 3.3.26 (core)",
    "settings 2.3.16 (core)",
    "sobject 1.4.33 (core)",
    "source 3.5.18 (core)",
    "telemetry 3.6.10 (core)",
    "templates 56.3.17 (core)",
    "trust 3.7.27 (core)",
    "user 3.5.29 (core)"
  ]
}

hi @simonhyphen8 -
can you try running
sf plugins uninstall @salesforce/plugin-packaging

it looks like you manually installed that version, and it's quite old. Uninstalling it will make the CLI use the version it ships with rather than your older manually installed version

@WillieRuemmele Thanks for the quick response.
I ran that comment, then tried the package create again.  I now receive:
Error (CANNOT_INSERT_UPDATE_ACTIVATE_ENTITY): entity type cannot be inserted: Package

Hmmm, well that sounds like it's being returned from the server. Do you need to "Enable Unlocked Packages and Second-Generation Managed Packages"? Or anything else in the org?

It's a scratch org connected to our dev hub which we've been using for a few years now, so I don't think it's anything like those settings.  However, I will check the settings of our dev hub right now and come back to you with what I find, just to be sure.

I discovered my access had been changed on the dev hub.  Apologies.  That's been resolve now, my access has been restored and the package / package version is now created.  Thanks for the quick response.

glad we got it working 😄


Feature request: input box

Hi,
Current situation:
At the moment, if I understand correctly the only way to search for a word using this add-on is to put it as is in a field.
The problem:
Sometimes the form that is written in the field doesn’t match the forms that exist on Forvo. Say you learn English and write all infinitives with ‘to’. Your field should have ‘to celebrate’, but Forvo has only ‘celebrate’.
Proposed solution:
The solution I propose is to add the option for users to input an arbitrary string for search. I think it is best if the default value of the search will be the current value of the relevant field, selected. This way the user has a basis to build upon, and it is easy to replace the whole string with something else. This is the behaviour used in browsers when hitting ctrl+L.

Thanks for the feature request! I'll add a shortcut that opens a small dialog box with a text box before opening the pronunciation selector.

Thanks! 🙂


Add new field  alias_of to default endpoint fields

This PR adds a new field alias_of for api. If the page marked as an alias alias_of return original page dictionary contain id and full_url. If not return null. Docs and tests were changed according to this field. Close #7009

Just noticed that this now uses full_url instead of html_url, this is inconsistent with how the urls are serialized in Wagtail. Other places always use the PageHtmlUrlField to serialize the full_url.

Just noticed that this now uses full_url instead of html_url, this is inconsistent with how the urls are serialized in Wagtail. Other places always use the PageHtmlUrlField to serialize the full_url.

@kaedroho Is this something to worry about? I guess this is going to be hard to change retrospectively after it ships.

It could be made more consistent by repeating what is done in PageParentField (declared right above PageAliasOfField) which is more complex, but that might be because of good reasons, i.e.:
class PageAliasOfField(relations.RelatedField):
    """
    Serializes the "alias_of" field on Page objects.
    """
    def get_attribute(self, instance):
        return instance

    def to_representation(self, value):
        serializer_class = get_serializer_class(value.__class__, ['id', 'type', 'detail_url', 'html_url', 'title'], meta_fields=['type', 'detail_url', 'html_url'], base=PageSerializer)
        serializer = serializer_class(context=self.context)
        return serializer.to_representation(value)

@kaedroho Is this something to worry about? I guess this is going to be hard to change retrospectively after it ships.

Sorry I missed this in review. Yes it would be hard for us to change this once it ships

@kaedroho What should I do now? Should I make changes as @jaap3 propose or leave this to somebody with experience.

@scientia-ac-labore That would be great if you can make the changes that @jaap3 described. Thanks!

which is more complex, but that might be because of good reasons, i.e.

I think this was to reuse the serializers for those fields to keep things consistent if we ever changed them


License of the examples.

Hello,
under what license are the examples distributed? If no license is given, it makes usage in other projects impossible, even though the README says that this is the goal of this repo.
Best regards.

It's "LGPL-3.0-or-later" (same as the rest of Gramine), but you're right, we forgot to specify this in this sub-repo. Will fix it in a moment.


multiple transports loosing SPLAT/meta

Please tell us about your environment:

winston version?

[ ] winston@2
[x] winston@3

_node -v outputs: v8.11.3
_Operating System? Windows
_Language? Typescript

What is the problem?
Adding multiple transports to a logger causes the info-object to loose meta field on all but one transport.:
const Winston = require("winston");
Winston.add(new Winston.transports.Console({
    format: Winston.format.combine(Winston.format(info => {
        info.message = info.message + "Console";
        return info;
    })(), Winston.format.splat(), Winston.format.simple(), Winston.format(info => {
        // console.log(info); // meta is there!
        return info;
    })()),
    handleExceptions: true
}));
Winston.add(new Winston.transports.File({
    filename: "test.log",
    format: Winston.format.combine(Winston.format(info => {
        // console.log(info); // meta is gone :(! and so is SPLAT only a array of length 1
        return info;
    })(), Winston.format.splat(), Winston.format.simple())
}));
for (let index = 0; index < 10; index++) {
    Winston.error("test %s" + index, "blub", "metainfo");
}

Output Console:
error: test blub0Console {"meta":"metainfo"}
error: test blub1Console {"meta":"metainfo"}
error: test blub2Console {"meta":"metainfo"}
error: test blub3Console {"meta":"metainfo"}
error: test blub4Console {"meta":"metainfo"}
error: test blub5Console {"meta":"metainfo"}
error: test blub6Console {"meta":"metainfo"}
error: test blub7Console {"meta":"metainfo"}
error: test blub8Console {"meta":"metainfo"}
error: test blub9Console {"meta":"metainfo"}

Output File:
error: test blub0
error: test blub1
error: test blub2
error: test blub3
error: test blub4
error: test blub5
error: test blub6
error: test blub7
error: test blub8
error: test blub9

Sometimes one transport gets the meta and the other doesn't and for the next logentry its the other way around.
What do you expect to happen instead?
Each transport should get a clean "new" info object. At least with a full SPLAT. So {"meta":"metainfo"} is included in File too.
Other information
I tried for a moment to find the issue in debugger, but got lost in the streams. So please excuse me, if this issue belongs more to winston-transports. I try to investigate this further.
It seems the info[SPLAT] is preserved from one Transport to the other, but due to the splat() formatter th metadata is removed. Maybe its more related to the splat() altering the array than i thought...
As a workaround i will push the metadata back to SPLAT after splat():
const splatWorkaround = Winston.format.combine(
  Winston.format.splat(),
  Winston.format(info => {
    if (info.meta && info.meta instanceof Array) info[SPLAT].push(...info.meta);
    else if (info.meta) info[SPLAT].push(info.meta);
    return info;
  })()
);

To get this working i will use this workaround:

I was about to open a new issue regarding this exact same issue, and then I found this one. I'll post my description as well. :)

Please tell us about your environment:

winston version?

[x]<EMAIL_ADDRESS>

node -v outputs: v8.12.0
Operating System? Linux
Language? ES5

What is the problem?

The custom data added by the splat formatter as the field meta in the log message is dropped when all the following conditions are met:

when a transport has already consumed the message (i.e. on a second transport)
when the first log string does not contain any tokens (i.e. %s)
when the custom format is applied on each transport

To replicate the bug, see the code:
https://gist.github.com/avaly/527eee1e061accb7e1f446ca105c3094#file-run-with-bug-js
Which outputs:
{"level":"info","message":"foo","meta":["bar","ham"]}
{"level":"info","message":"foo"}
{"level":"info","message":"with interpolated strings: bar and ham"}
{"level":"info","message":"with interpolated strings: bar and ham"}

What do you expect to happen instead?
Expected output:
{"level":"info","message":"foo","meta":["bar","ham"]}
{"level":"info","message":"foo","meta":["bar","ham"]}
{"level":"info","message":"with interpolated strings: bar and ham"}
{"level":"info","message":"with interpolated strings: bar and ham"}

Other information
If we move the custom format to the top level logger, then the bug does not present itself:
https://gist.github.com/avaly/527eee1e061accb7e1f446ca105c3094#file-run-without-bug-js
But, most of the time, different transports do require different formatting.

i did some digging and i think i found the cause.
The issue is located in the winston stream module:
https://github.com/winstonjs/winston-transport/blob/master/index.js#L90
# index.js#L90
TransportStream.prototype._write = function _write(info, enc, callback) {
    ...
    // We trap(and re-throw) any errors generated by the user-provided format, but also
    // guarantee that the streams callback is invoked so that we can continue flowing.
    try {
      transformed = this.format.transform(Object.assign({}, info), this.format.options);
    } catch (err) {
      errState = err;
    }
    ...
};

They use Object.assign to create a shallow copy of the info object so the "SPLAT" array gets modified by the formatters.
To fix this we would need to do a deep clone here instead of an Object.assign
Proof:
      let clone = Object.assign({}, info);
      clone[SPLAT] = [...info[SPLAT]]
      transformed = this.format.transform(clone, this.format.options);

fixes the splat issue in your test.

i think i figured out a workaround for now. You can try adding this to your scripts to make the transport use a "deepclone" instead of making shallow clone
you can try this as a workaround for now:
const deepcopy = require('deepcopy');
const TransportStream = require('winston-transport');
const { LEVEL } = require('triple-beam');

TransportStream.prototype._write = function _write(info, enc, callback) {
    if (this.silent || (info.exception === true && !this.handleExceptions)) {
        return callback(null);
    }

    // Remark: This has to be handled in the base transport now because we
    // cannot conditionally write to our pipe targets as stream. We always
    // prefer any explicit level set on the Transport itself falling back to
    // any level set on the parent.
    const level = this.level || (this.parent && this.parent.level);

    if (!level || this.levels[level] >= this.levels[info[LEVEL]]) {
        if (info && !this.format) {
            return this.log(info, callback);
        }

        let errState;
        let transformed;

        // We trap(and re-throw) any errors generated by the user-provided format, but also
        // guarantee that the streams callback is invoked so that we can continue flowing.
        try {
            transformed = this.format.transform(deepcopy(info), this.format.options);
        } catch (err) {
            errState = err;
        }

        if (errState || !transformed) {
            // eslint-disable-next-line callback-return
            callback();
            if (errState) throw errState;
            return;
        }

        return this.log(transformed, callback);
    }

    return callback(null);
};

@Fantus nice workaround, thank you!

I have a PR in for this.  Waiting for review from @DABH and @indexzero.  https://github.com/winstonjs/logform/pull/85

Using this as a workaround
const deepCloneSplat = format((info) => {
    const cloned = clone(info)
    return format.splat().transform(cloned)
})

Use deepCloneSplat in place of format.Splat()

I came across this, too, in #1933!

@avaly thanks for including those gists for reproducing this issue. That has made it significantly easier to reproduce the issue described here. I've included this test in a PR of my to verify a lot of the issues we have metadata currently.
I find it most likely that this will be resolved as a part of #2072.


Added support for setting the framework using the public api (#1908)

What does this PR do?
Fixes #1908
Checklist

[x] This is an enhancement of existing features, or a new feature in existing plugins

[x] I have updated CHANGELOG.asciidoc
[x] I have added tests that prove my fix is effective or that my feature works
[ ] Added an API method or config option? Document in which version this will be introduced
[ ] I have made corresponding changes to the documentation

:grey_exclamation: Build Aborted

The PR is not allowed to run in the CI yet

the below badges are clickable and redirect to their specific view in the CI or DOCS

Expand to view the summary

Build stats

Reason: The PR is not allowed to run in the CI yet

Start Time: 2021-07-10T08:55:18.876+0000

Duration: 3 min 1 sec

Commit: c64c7e96cd20abe4e4355d8392e194a99a0f5a87

Trends :test_tube:

Steps errors
Expand to view the steps failures

Load a resource file from a shared library

Took 0 min 0 sec . View more details on here
Description: approval-list/elastic/apm-agent-java.yml

Error signal

Took 0 min 0 sec . View more details on here
Description: githubPrCheckApproved: The PR is not allowed to run in the CI yet. (Only users with write permissions can do so.)

Log output
Expand to view the last 100 lines of log output

[2021-07-10T08:57:51.117Z] using GIT_ASKPASS to set credentials GitHub user @apmmachine User + Personal Access Token
[2021-07-10T08:57:51.118Z]  > git fetch --no-tags --progress -- https://github.com/elastic/apm-agent-java.git +refs/heads/*:refs/remotes/origin/* # timeout=100
[2021-07-10T08:57:51.735Z]  > git config remote.origin.url https://github.com/elastic/apm-agent-java.git # timeout=10
[2021-07-10T08:57:51.744Z]  > git config --add remote.origin.fetch +refs/heads/*:refs/remotes/origin/* # timeout=10
[2021-07-10T08:57:51.758Z]  > git config remote.origin.url https://github.com/elastic/apm-agent-java.git # timeout=10
[2021-07-10T08:57:51.770Z] Fetching upstream changes from https://github.com/elastic/apm-agent-java.git
[2021-07-10T08:57:51.771Z] using GIT_ASKPASS to set credentials GitHub user @apmmachine User + Personal Access Token
[2021-07-10T08:57:51.772Z]  > git fetch --no-tags --progress --prune -- https://github.com/elastic/apm-agent-java.git +refs/pull/1909/head:refs/remotes/origin/PR-1909 +refs/heads/master:refs/remotes/origin/master # timeout=100
[2021-07-10T08:57:52.252Z] Merging remotes/origin/master commit d85c09d6a9fdf0859cc5eb1ec84165264d1f40ae into PR head commit c64c7e96cd20abe4e4355d8392e194a99a0f5a87
[2021-07-10T08:57:52.501Z] Merge succeeded, producing c64c7e96cd20abe4e4355d8392e194a99a0f5a87
[2021-07-10T08:57:52.502Z] Checking out Revision c64c7e96cd20abe4e4355d8392e194a99a0f5a87 (PR-1909)
[2021-07-10T08:57:52.260Z]  > git config core.sparsecheckout # timeout=10
[2021-07-10T08:57:52.273Z]  > git checkout -f c64c7e96cd20abe4e4355d8392e194a99a0f5a87 # timeout=100
[2021-07-10T08:57:52.470Z]  > git remote # timeout=10
[2021-07-10T08:57:52.476Z]  > git config --get remote.origin.url # timeout=10
[2021-07-10T08:57:52.480Z] using GIT_ASKPASS to set credentials GitHub user @apmmachine User + Personal Access Token
[2021-07-10T08:57:52.481Z]  > git merge d85c09d6a9fdf0859cc5eb1ec84165264d1f40ae # timeout=10
[2021-07-10T08:57:52.495Z]  > git rev-parse HEAD^{commit} # timeout=10
[2021-07-10T08:57:52.504Z]  > git config core.sparsecheckout # timeout=10
[2021-07-10T08:57:52.526Z]  > git checkout -f c64c7e96cd20abe4e4355d8392e194a99a0f5a87 # timeout=100
[2021-07-10T08:57:56.441Z] Commit message: "Added support for setting the framework using the public api (#1908)"
[2021-07-10T08:57:56.441Z] First time build. Skipping changelog.
[2021-07-10T08:57:56.463Z]  > git --version # timeout=10
[2021-07-10T08:57:56.475Z]  > git --version # 'git version 2.17.1'
[2021-07-10T08:57:56.491Z] fatal: bad object 6457a1965f1a69b17319a6457550c2aaa347acc0
[2021-07-10T08:57:57.119Z] Masking supported pattern matches of $JOB_GCS_BUCKET or $NOTIFY_TO
[2021-07-10T08:57:57.197Z] Timeout set to expire in 1 hr 0 min
[2021-07-10T08:57:57.229Z] The timestamps step is unnecessary when timestamps are enabled for all Pipeline builds.
[2021-07-10T08:57:57.707Z] [INFO] Number of builds to be searched 10
[2021-07-10T08:57:58.073Z] [INFO] 'shallow' is forced to be disabled when running on PullRequests
[2021-07-10T08:57:58.102Z] Running in /var/lib/jenkins/workspace/_java_apm-agent-java-mbp_PR-1909/src/github.com/elastic/apm-agent-java
[2021-07-10T08:57:58.145Z] [INFO] gitCheckout: Checkout SCM PR-1909 with some customisation.
[2021-07-10T08:57:58.183Z] [INFO] Override default checkout
[2021-07-10T08:57:58.255Z] Sleeping for 10 sec
[2021-07-10T08:58:08.278Z] The recommended git tool is: git
[2021-07-10T08:58:08.405Z] using credential 2a9602aa-ab9f-4e52-baf3-b71ca88469c7-UserAndToken
[2021-07-10T08:58:08.415Z] Cloning the remote Git repository
[2021-07-10T08:58:08.431Z] Cloning repository https://github.com/elastic/apm-agent-java.git
[2021-07-10T08:58:08.455Z]  > git init /var/lib/jenkins/workspace/_java_apm-agent-java-mbp_PR-1909/src/github.com/elastic/apm-agent-java # timeout=10
[2021-07-10T08:58:08.462Z] Using reference repository: /var/lib/jenkins/.git-references/apm-agent-java.git
[2021-07-10T08:58:08.463Z] Fetching upstream changes from https://github.com/elastic/apm-agent-java.git
[2021-07-10T08:58:08.463Z]  > git --version # timeout=10
[2021-07-10T08:58:08.469Z]  > git --version # 'git version 2.17.1'
[2021-07-10T08:58:08.469Z] using GIT_ASKPASS to set credentials GitHub user @apmmachine User + Personal Access Token
[2021-07-10T08:58:08.470Z]  > git fetch --tags --progress -- https://github.com/elastic/apm-agent-java.git +refs/heads/*:refs/remotes/origin/* # timeout=10
[2021-07-10T08:58:08.954Z]  > git config remote.origin.url https://github.com/elastic/apm-agent-java.git # timeout=10
[2021-07-10T08:58:08.957Z]  > git config --add remote.origin.fetch +refs/heads/*:refs/remotes/origin/* # timeout=10
[2021-07-10T08:58:08.969Z]  > git config remote.origin.url https://github.com/elastic/apm-agent-java.git # timeout=10
[2021-07-10T08:58:08.984Z] Fetching upstream changes from https://github.com/elastic/apm-agent-java.git
[2021-07-10T08:58:08.984Z] using GIT_ASKPASS to set credentials GitHub user @apmmachine User + Personal Access Token
[2021-07-10T08:58:08.985Z]  > git fetch --tags --progress -- https://github.com/elastic/apm-agent-java.git +refs/pull/1909/head:refs/remotes/origin/PR-1909 +refs/heads/master:refs/remotes/origin/master # timeout=10
[2021-07-10T08:58:09.443Z] Checking out Revision ebdf1a700e47d22fa2c5c2cf9e30a3a608029cb3 (origin/PR-1909)
[2021-07-10T08:58:09.632Z] Commit message: "Added #1909 to the changelog"
[2021-07-10T08:58:09.632Z] First time build. Skipping changelog.
[2021-07-10T08:58:09.647Z]  > git --version # timeout=10
[2021-07-10T08:58:09.655Z]  > git --version # 'git version 2.17.1'
[2021-07-10T08:58:09.658Z] fatal: bad object 6457a1965f1a69b17319a6457550c2aaa347acc0
[2021-07-10T08:58:09.438Z]  > git rev-parse origin/PR-1909^{commit} # timeout=10
[2021-07-10T08:58:09.446Z]  > git config core.sparsecheckout # timeout=10
[2021-07-10T08:58:09.449Z]  > git checkout -f ebdf1a700e47d22fa2c5c2cf9e30a3a608029cb3 # timeout=10
[2021-07-10T08:58:10.704Z] Masking supported pattern matches of $GIT_USERNAME or $GIT_PASSWORD
[2021-07-10T08:58:11.196Z] + git fetch<EMAIL_ADDRESS>+refs/pull/*/head:refs/remotes/origin/pr/*
[2021-07-10T08:58:12.216Z] Running in /var/lib/jenkins/workspace/_java_apm-agent-java-mbp_PR-1909/src/github.com/elastic/apm-agent-java/.git
[2021-07-10T08:58:12.334Z] Archiving artifacts
[2021-07-10T08:58:13.064Z] + git rev-parse HEAD
[2021-07-10T08:58:13.409Z] + git rev-parse HEAD
[2021-07-10T08:58:13.722Z] + git rev-parse origin/pr/1909
[2021-07-10T08:58:13.779Z] [INFO] githubEnv: Found Git Build Cause: pr
[2021-07-10T08:58:14.202Z] Masking supported pattern matches of $GITHUB_TOKEN
[2021-07-10T08:58:15.382Z] [WARN] githubApiCall: The REST API call https://api.github.com/repos/elastic/apm-agent-java/pulls/1909/reviews return 0 elements
[2021-07-10T08:58:15.455Z] [INFO] githubPrCheckApproved: Title: Added support for setting the framework using the public api (#1908) - User: tobiasstadler - Author Association: CONTRIBUTOR
[2021-07-10T08:58:15.808Z] ERROR: githubPrCheckApproved: The PR is not allowed to run in the CI yet
[2021-07-10T08:58:15.808Z] ERROR: githubPrCheckApproved: The PR is not allowed to run in the CI yet. (Only users with write permissions can do so.)
[2021-07-10T08:58:15.902Z] [INFO] Let's stop build #1. The PR is not allowed to run in the CI yet
[2021-07-10T08:58:15.929Z] Sleeping for 5 sec
[2021-07-10T08:58:17.039Z] Stage "Build" skipped due to earlier failure(s)
[2021-07-10T08:58:17.241Z] Stage "Tests" skipped due to earlier failure(s)
[2021-07-10T08:58:17.439Z] Stage "Unit Tests" skipped due to earlier failure(s)
[2021-07-10T08:58:17.451Z] Stage "Smoke Tests 01" skipped due to earlier failure(s)
[2021-07-10T08:58:17.463Z] Stage "Smoke Tests 02" skipped due to earlier failure(s)
[2021-07-10T08:58:17.475Z] Stage "Benchmarks" skipped due to earlier failure(s)
[2021-07-10T08:58:17.488Z] Stage "Javadoc" skipped due to earlier failure(s)
[2021-07-10T08:58:17.657Z] Failed in branch Unit Tests
[2021-07-10T08:58:17.667Z] Failed in branch Smoke Tests 01
[2021-07-10T08:58:17.676Z] Failed in branch Smoke Tests 02
[2021-07-10T08:58:17.685Z] Failed in branch Benchmarks
[2021-07-10T08:58:17.694Z] Failed in branch Javadoc
[2021-07-10T08:58:17.951Z] Stage "Integration Tests" skipped due to earlier failure(s)
[2021-07-10T08:58:18.046Z] Stage "Stable" skipped due to earlier failure(s)
[2021-07-10T08:58:18.137Z] Stage "AfterRelease" skipped due to earlier failure(s)
[2021-07-10T08:58:18.177Z] Stage "AfterRelease" skipped due to earlier failure(s)
[2021-07-10T08:58:18.992Z] Running on Jenkins in /var/lib/jenkins/workspace/_java_apm-agent-java-mbp_PR-1909
[2021-07-10T08:58:19.274Z] [INFO] getVaultSecret: Getting secrets
[2021-07-10T08:58:19.335Z] Masking supported pattern matches of $VAULT_ADDR or $VAULT_ROLE_ID or $VAULT_SECRET_ID
[2021-07-10T08:58:20.402Z] + chmod 755 generate-build-data.sh
[2021-07-10T08:58:20.402Z] + ./generate-build-data.sh https://apm-ci.elastic.co/blue/rest/organizations/jenkins/pipelines/apm-agent-java/apm-agent-java-mbp/PR-1909/ https://apm-ci.elastic.co/blue/rest/organizations/jenkins/pipelines/apm-agent-java/apm-agent-java-mbp/PR-1909/runs/1 ABORTED 181252
[2021-07-10T08:58:20.402Z] INFO: curl https://apm-ci.elastic.co/blue/rest/organizations/jenkins/pipelines/apm-agent-java/apm-agent-java-mbp/PR-1909/runs/1/steps/?limit=10000 -o steps-info.json
[2021-07-10T08:58:20.652Z] INFO: curl https://apm-ci.elastic.co/blue/rest/organizations/jenkins/pipelines/apm-agent-java/apm-agent-java-mbp/PR-1909/runs/1/tests/?status=FAILED -o tests-errors.json
[2021-07-10T08:58:20.652Z] Retry 1/3 exited 22, retrying in 1 seconds...
[2021-07-10T08:58:21.564Z] Retry 2/3 exited 22, retrying in 2 seconds...

Thanks for this PR @tobiasstadler !
Some things are missing:

document the added API to docs/public-api.asciidoc
providing higher precedence to user-set values, both is set before AND after the automatic setting
the implementation of 2 should include the ability to set null or empty string in order to override the automatically-set value
testing 2 and 3 - before/after automatic, with null/empty and valid value
extend the javadoc and asciidoc to specify the above

You can see examples for all of those in #1788

@eyalkoren I did the requested changes
The javadoc/documentation states
Override the name of the framework for the current transaction.
For supported frameworks,
the framework name is determined automatically,
and can be overridden using this function.

In my opinion this clearly says that a user set value has a higher precedence that an automatic set value (by a plugin). Do you agree?

In my opinion this clearly says that a user set value has a higher precedence that an automatic set value (by a plugin). Do you agree?

Absolutely agree, only a word that setting null or empty value will make the agent omit this field, just as a clarification

run elasticsearch-ci/docs

Thank You!

Thank YOU! 😄


[DNM] Debug failure

Do not merge this. Trying to debug task Ensure ovs services are enabled and running failure which does not reproduce locally

/ok-to-test

/ok-to-test

recheck


Update kvdb-rocksdb again

Build fails

I'm now waiting for the release of the crate, which should happen today :)

which should happen today

It did happen. :)

Yeah, I'm already at updating :D


Fix errors test

@thockin @zmerlynn

@cjcullen found another issue and is going to fix it. Blech.

Fixes #10588

Merging soon, because @cjcullen is awesome. Shippable should go green soon.

Why did this not trigger on my PR?

I think you were actually red on shippable when I merged, and I was just a bad, bad person. (I had been dealing with a huge Shippable latency all morning that then manifested as a failed build, and assumed it was the same failure. But no, it was a real failure. I haven't dug your actual failure out, though.)

oh.  Thanks CJ
On Tue, Jun 30, 2015 at 5:48 PM, Zach Loafman<EMAIL_ADDRESS>wrote:

I think you were actually red on shippable when I merged, and I was just a
bad, bad person. (I had been dealing with a huge Shippable latency all
morning that then manifested as a failed build, and assumed it was the same
failure. But no, it was a real failure. I haven't dug your actual failure
out, though.)
—
Reply to this email directly or view it on GitHub
https://github.com/GoogleCloudPlatform/kubernetes/pull/10589#issuecomment-117380252
.


How to add linting to your Teams Bot?

Steps to reproduce
Copied bug from: https://github.com/OfficeDev/teams-toolkit/issues/11727
Details from original post:
Describe the bug
Discussed in https://github.com/OfficeDev/teams-toolkit/discussions/11674
Originally posted by IAM5K May 21, 2024
We are creating a bot and based on our company coding standard it is mandatory that we implement coding standards or linting in our project what is the standard plugin package or linter that we use for linting bot framework applications.
I have already tried using eslint and prettier but they have some conflicts and package issues.
I found using mslint in a repository but lost it. Is there some guideline that we use to add coding standards and checks (linting) to our bot project.
Expected behavior
NA
Actual behavior
NA
Error details
No response

This issue was tracked here: https://github.com/MicrosoftDocs/msteams-docs/issues/11058


[QUESTION] Lack of listFiles operation on S3

Is there a specific reason for the lack of the listFiles operation? The operation is easily available via the AWS SDK, and implemented in the S3AsyncClientOp[F], so I was wondering why it hasn't been exported.
Will a PR that export some functionalities be appreciated?

it will be, but i'm not sure where do you see listFiles in AWS SDK V2

it will be, but i'm not sure where do you see listFiles in AWS SDK V2

My bad I mean exposing S3AsyncClientOp from S3AsyncClientOp.

It's actually listObjectsV2 not listFiles. But anyway this functionality is missing