QdrantVectorStore: regression with similarity_search

Checked other resources

[X] I added a very descriptive title to this issue.
[X] I searched the LangChain documentation with the integrated search.
[X] I used the GitHub search to find a similar question and didn't find it.
[X] I am sure that this is a bug in LangChain rather than my code.
[X] The bug is not resolved by updating to the latest stable version of LangChain (or the specific integration package).

Example Code
The following code with QdrantVectorStore:
#Ingest docs into Qdrant with QdrantVectorStore
from langchain_core.documents import Document
from langchain_qdrant import QdrantVectorStore

docs = [
    Document(
        page_content="there are cats in the pond",
        metadata={"id": 1, "location": "pond", "topic": "animals"},
    ),
    Document(
        page_content="ducks are also found in the pond",
        metadata={"id": 2, "location": "pond", "topic": "animals"},
    ),
]

collection_name = "test_collection"
qdrant = QdrantVectorStore.from_documents(
    docs,
    embedding=embeddings,
    url=qdrant_url,
    prefer_grpc=False,
    https=True,
    api_key=api_key,
    collection_name=collection_name,
    force_recreate=True
)

query = "Where can I find fruits?"
found_docs = qdrant.similarity_search(query=query, k=3)

Error Message and Stack Trace (if applicable)
Returns the following error:
--------------------------------------------------------------------------
UnexpectedResponse                        Traceback (most recent call last)
Cell In[56], line 3
      1 #Recherche de similarité
      2 query = "Where can I find fruits?"
----> 3 found_docs = qdrant.similarity_search(query=query, k=3)

File /aleia/jplab/.venv/lib/python3.9/site-packages/langchain_qdrant/qdrant.py:468, in QdrantVectorStore.similarity_search(self, query, k, filter, search_params, offset, score_threshold, consistency, hybrid_fusion, **kwargs)
    451 def similarity_search(
    452     self,
    453     query: str,
   (...)
    461     **kwargs: Any,
    462 ) -> List[Document]:
    463     """Return docs most similar to query.
    464
    465     Returns:
    466         List of Documents most similar to the query.
    467     """
--> 468     results = self.similarity_search_with_score(
    469         query,
    470         k,
    471         filter=filter,
    472         search_params=search_params,
    473         offset=offset,
    474         score_threshold=score_threshold,
    475         consistency=consistency,
    476         hybrid_fusion=hybrid_fusion,
    477         **kwargs,
    478     )
    479     return list(map(itemgetter(0), results))

File /aleia/jplab/.venv/lib/python3.9/site-packages/langchain_qdrant/qdrant.py:512, in QdrantVectorStore.similarity_search_with_score(self, query, k, filter, search_params, offset, score_threshold, consistency, hybrid_fusion, **kwargs)
    510 if self.retrieval_mode == RetrievalMode.DENSE:
    511     query_dense_embedding = self.embeddings.embed_query(query)
--> 512     results = self.client.query_points(
    513         query=query_dense_embedding,
    514         using=self.vector_name,
    515         **query_options,
    516     ).points
    518 elif self.retrieval_mode == RetrievalMode.SPARSE:
    519     query_sparse_embedding = self.sparse_embeddings.embed_query(query)

File /aleia/jplab/.venv/lib/python3.9/site-packages/qdrant_client/qdrant_client.py:560, in QdrantClient.query_points(self, collection_name, query, using, prefetch, query_filter, search_params, limit, offset, with_payload, with_vectors, score_threshold, lookup_from, consistency, shard_key_selector, timeout, **kwargs)
    556 # If the query contains unprocessed documents, we need to embed them and
    557 # replace the original query with the embedded vectors.
    558 query, prefetch = self._resolve_query_to_embedding_embeddings_and_prefetch(query, prefetch)
--> 560 return self._client.query_points(
    561     collection_name=collection_name,
    562     query=query,
    563     prefetch=prefetch,
    564     query_filter=query_filter,
    565     search_params=search_params,
    566     limit=limit,
    567     offset=offset,
    568     with_payload=with_payload,
    569     with_vectors=with_vectors,
    570     score_threshold=score_threshold,
    571     using=using,
    572     lookup_from=lookup_from,
    573     consistency=consistency,
    574     shard_key_selector=shard_key_selector,
    575     timeout=timeout,
    576     **kwargs,
    577 )

File /aleia/jplab/.venv/lib/python3.9/site-packages/qdrant_client/qdrant_remote.py:702, in QdrantRemote.query_points(self, collection_name, query, using, prefetch, query_filter, search_params, limit, offset, with_payload, with_vectors, score_threshold, lookup_from, consistency, shard_key_selector, timeout, **kwargs)
    685     lookup_from = GrpcToRest.convert_lookup_location(lookup_from)
    687 query_request = models.QueryRequest(
    688     shard_key=shard_key_selector,
    689     prefetch=prefetch,
   (...)
    699     lookup_from=lookup_from,
    700 )
--> 702 query_result = self.http.points_api.query_points(
    703     collection_name=collection_name,
    704     consistency=consistency,
    705     timeout=timeout,
    706     query_request=query_request,
    707 )
    709 result: Optional[models.QueryResponse] = query_result.result
    710 assert result is not None, "Search returned None"

File /aleia/jplab/.venv/lib/python3.9/site-packages/qdrant_client/http/api/points_api.py:1650, in SyncPointsApi.query_points(self, collection_name, consistency, timeout, query_request)
   1640 def query_points(
   1641     self,
   1642     collection_name: str,
   (...)
   1645     query_request: m.QueryRequest = None,
   1646 ) -> m.InlineResponse20021:
   1647     """
   1648     Universally query points. This endpoint covers all capabilities of search, recommend, discover, filters. But also enables hybrid and multi-stage queries.
   1649     """
-> 1650     return self._build_for_query_points(
   1651         collection_name=collection_name,
   1652         consistency=consistency,
   1653         timeout=timeout,
   1654         query_request=query_request,
   1655     )

File /aleia/jplab/.venv/lib/python3.9/site-packages/qdrant_client/http/api/points_api.py:512, in _PointsApi._build_for_query_points(self, collection_name, consistency, timeout, query_request)
    510 if "Content-Type" not in headers:
    511     headers["Content-Type"] = "application/json"
--> 512 return self.api_client.request(
    513     type_=m.InlineResponse20021,
    514     method="POST",
    515     url="/collections/{collection_name}/points/query",
    516     headers=headers if headers else None,
    517     path_params=path_params,
    518     params=query_params,
    519     content=body,
    520 )

File /aleia/jplab/.venv/lib/python3.9/site-packages/qdrant_client/http/api_client.py:79, in ApiClient.request(self, type_, method, url, path_params, **kwargs)
     77     kwargs["timeout"] = int(kwargs["params"]["timeout"])
     78 request = self._client.build_request(method, url, **kwargs)
---> 79 return self.send(request, type_)

File /aleia/jplab/.venv/lib/python3.9/site-packages/qdrant_client/http/api_client.py:102, in ApiClient.send(self, request, type_)
    100     except ValidationError as e:
    101         raise ResponseHandlingException(e)
--> 102 raise UnexpectedResponse.for_response(response)

UnexpectedResponse: Unexpected Response: 404 (Not Found)
Raw response content:
b''

Description

I am trying to use langchain_qdrant.QdrantVectorStore class to add documents and to search for it
I got an error
But the same code works fine with deprecated langchain_community.vectorstores.Qdrant class

System Info
System Information

OS:  Linux
OS Version:  #165-Ubuntu SMP Tue Apr 18 08:53:12 UTC 2023
Python Version:  3.9.20 (main, Sep  9 2024, 18:01:25)
[GCC 10.2.1 20210110]

Package Information

langchain_core: 0.3.10
langchain: 0.3.3
langchain_community: 0.3.2
langsmith: 0.1.132
langchain_qdrant: 0.2.0.dev1
langchain_text_splitters: 0.3.0

Optional packages not installed

langgraph
langserve

Other Dependencies

aiohttp: 3.8.6
async-timeout: 4.0.3
dataclasses-json: 0.6.7
fastembed: Installed. No version info available.
httpx: 0.25.0
jsonpatch: 1.33
numpy: 1.24.4
orjson: 3.10.7
packaging: 23.2
pydantic: 2.9.2
pydantic-settings: 2.5.2
PyYAML: 6.0.1
qdrant-client: 1.11.3
requests: 2.31.0
requests-toolbelt: 1.0.0
SQLAlchemy: 2.0.22
tenacity: 8.5.0
typing-extensions: 4.11.0

After looking at other close qdrant issues (https://github.com/qdrant/qdrant/issues/5016), I solved this by upgrading the version of my Qdrant cluster


OCM-1233 | fix: The interactive mode should not exit after input invalid ingress label

Related issue: https://issues.redhat.com/browse/OCM-1233

/lgtm


Missing .md extension on two /requests-for-comments/ files

Hi there!
While normally I'd open a PR to apply a fix, in this case it's probably way quicker for someone internal to do it since it's just file renaming :)
These two files don't have .md extensions and so GitHub doesn't render a preview/MD view when looking at them:
https://github.com/PostHog/meta/blob/main/requests-for-comments/2023-01-11-g2-automation
https://github.com/PostHog/meta/blob/main/requests-for-comments/resilient-feature-flags
Cheers :)

Nice catch, thanks!


UI does not update when toggling "done" after editing a todo item

Hi! First off, thank you for making this -- I've been looking for this kind of example project for a while! This will be a really helpful reference.
Wanted to report a small bug: after focusing on a todo item, the strikethrough formatting doesn't update when toggling between "done" and "not-done" states. I think the simplest fix would be to set the SelectedItem to null after saving:
https://github.com/jasontaylordev/CleanArchitectureBlazor/compare/main...erinnmclaughlin:CleanArchitectureBlazor:main
I could make a PR if you'd like?

Hi @erinnmclaughlin - you're welcome + thanks for raising this issue. Please raise a PR and I'll push the fix through. Happy coding! 😀


test: fix printf formating

extracted from this patch:
https://github.com/baresip/re/pull/758

hi @maximilianfridrich
Could you please run your LLVM vararg tool after this, and see if it can find any issues ?

It did not find an issue. The tool is quite simple: It checks if the last non-variable argument to a variadic function is non-constant string. If that is the case, it prints a warning.
So some of these warning are actually okay to ignore, but the origin of such a non-constant argument needs to be carefully checked by hand if it can be (partially) controlled by an external user. E.g. that was the case in the multipart sdp decoding function, because the boundary string is controlled externally and was then passed to the re_regex function.
Here is the core of the LLVM pass:
void visitor(Function &F) {
  for (auto &BB : F) {
    for (auto &Ins : BB) {

      auto *CB = dyn_cast<CallBase>(&Ins);
      if (nullptr == CB) {
        continue;
      }
      // If CB is a direct function call then DirectInvoc will be not null.
      auto *DirectInvoc = CB->getCalledFunction();
      if (nullptr == DirectInvoc) {
        continue;
      }
      if (DirectInvoc->isVarArg()) {
        int LastIndex = DirectInvoc->arg_size() - 1;
        Value *LastArg = CB->getArgOperand(LastIndex);

        if (!isa<Constant>(LastArg) && !isa<ConstantDataSequential>(LastArg)) {
          errs()
              << "Warning: In function " << F.getName() << " calling function "
              << DirectInvoc->getName()
              << " where the last non-variable argument is not a constant "
                 "string\n";
        }
      }
    }
  }
}


we should sanitize v-html props in components or remove them

There are many places that accept v-html input and the input isn't sanitized for xss attacks, we leave this to the user. I think we should remove all the v-html places since we have slots everywhere that the user can use to shoot them self in the foot.

@VividLemon any thoughts on this one?

Tbh I agree with this one. It seems safest to force slot usage instead so v-html can be flagged by people using eslint-plugin-vue

@VividLemon do you also agree that we should remove this from popover/tooltip?
some people might be using v-tooltip="very important tooltip".
I think we should guide these people to use a component instead. popover has a sanitize function lifted from bootstrap that only allows a limited html: https://github.com/bootstrap-vue-next/bootstrap-vue-next/blob/8bfc3c3d9fc4abb9bee39632d0ff8d1a1f03a5e3/packages/bootstrap-vue-next/src/utils/sanitizer.ts#L59-L91
the component btw only uses v-html if html prop is set to true (which the directives do)
or should we add this same sanitization to other component that have v-html?

I'd prefer to never do any sanitation for the user. It's not up to us on what they should or shouldn't be allowed to do with their code. Maybe they want xss issues, idrk, not my problem


Make tables responsive

@praveen-murali-ind _a

@AbhayVAshokan https://praveen-murali.neetorecord.com/watch/4899684d-b7e7-4401-9068-2c334a05dfad
After

cc @neerajsingh0101

@praveen-murali-ind looks great 👍


Add optional "npmrc" flag to leverage alternative NPM repositories

fixes #252
Allow the CLI to accept an optional --npmrc flag to include additional rules when resolving NPM dependencies for comparing alternate versions of a package. This is required when working with private repositories/packages.

Oops, looks like there are a few test failures do to the new field needing to be explicitly set to empty string in some cases.

🤦🏼♂ this is passing locally now!
I also confirmed that copy worked fine in exchange for copySync, so we'd be good to go for that.

Thanks for the PR!


how to get marker object generated in marker directive?

I would like to achieve an action as this http://jsfiddle.net/7w6gh4we/1/
(when clicking on table, the marker will react, vise versa)
Is there a way to have access to the marker object that I can do other controls to the marker when needed?
Thanks,
Sean

map.markers as in README.md?
app.controller('MyController', function(NgMap) {
  NgMap.getMap().then(function(map) {
    console.log(map.getCenter());
    console.log('markers', map.markers);
    console.log('shapes', map.shapes);
  });
});

I am pretty new to web and programming
Thank you so much for your patient answering all the questions
NgMap is a very helpful and easy to use module.
Many thanks again
Sean

On Apr 11, 2016, at 7:55 PM, Allen Kim<EMAIL_ADDRESS>wrote:
map.markers as in README.md?
app.controller('MyController', function(NgMap) {
NgMap.getMap().then(function(map) {
console.log(map.getCenter());
console.log('markers', map.markers);
console.log('shapes', map.shapes);
});
});
—
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub


As a manager, ability to undo previous actions in a workflow or on content, or revert back to previous states for proposals

I am writing to request this feature enhancement for rapid response applications. Manager also need to send undetermined messages during every workflow status. This issue is in related to #1449

User could revert back to previous action for all statuses except when the status is Accept. Test is complete, please release. Thank you!


text.at object

According to this: https://github.com/objectionary/eo/issues/979

@kerelape Thanks!


demo page can't work

Mixed Content: The page at 'https://lipten.link/projects/slidePage/demo.html' was loaded over HTTPS, but requested an insecure script 'http://cdn.bootcss.com/jquery/2.1.4/jquery.min.js'. This request has been blocked; the content must be served over HTTPS.
browser ：desktop chrome

我暂时移除了ssl，现在可以直接访问http://lipten.link/projects/slidePage/demo.html


[CI] Colab link update fails if branch name is missing

The current colab badge link update (reasonably) assumes a branch name, e.g. .../blob/branch-name/..., to find and replace with master. However, in the event no branch name is present in the (invalid) link, e.g. .../blob/..., the regex fails and doesn't update.
It's not entirely clear how the branch name got dropped in the observed case (https://github.com/NeuromatchAcademy/course-content/pull/549), but we should probably try to cover this edge case.

I think the problem is that the regex assumes branch names will be made of up "word" characters, which includes _ but not - (which was what was used on that branch.
Should be a trivial fix to make it match on [-\w]+ but I guess you'd want to test it....

I think we ran into a couple of similar issues last year when someone (you, maybe?) were using a hierarchical branch naming scheme (e.g. fix/W2D5) which is a trickier pattern to match in the context of a url...


Microsoft.FlightSimulator_<IP_ADDRESS>_x64__8wekyb3d8bbwe taking forever on executable.

I'm attempting to dump the latest version of MSFS2020 for my own archival purposes, but it appears to hang on the executable which is actually the only encrypted file in the folder. Is this process supposed to take this long or am I doing something wrong?

Also something to note is that It is also creating a tremendously large file in the DUMP folder.

This seems to happen to me too on Minecraft Dungeons. It eventually moves on, but the resulting file is just a little bit less than 509x the original file size!


non-open keyboardDidShowWithFrame

Hey guys,
I've seen that you've changed all methods in UIViewController extension, but keyboardDidShowWithFrame is public still, not open.
Could you make it open as well? Because I can't use it right now.
I will change it to open, but hope that you will do the same, so my change will not missed in next update.
Thank you.

https://github.com/goktugyil/EZSwiftExtensions/pull/402


small tweak to the discharge error spec because we made a schema chan…

…ge eliminating the subsite_id from the table


Localize-ability and German localization

Made the app localizable and added a German localization.

Thanks for jumping in and taking on localization!
This is a new project and we’re still doing our best to get it off the ground. Any help kicking off localization is appreciated as we’ve been focusing on shipping core features first.
The team will take a look at your PR on Monday and provide feedback. We’ve been hoping to standardize the custom phrases and categories into JSON that can be shared between the iOS and Android version of Vocable, but haven’t gotten to that yet.
Thank you again,
The Vocable team.

Thanks! I might be able to work on putting the presets in a JSON over weekend.

I welcome this Pull Request, because I just wanted to see if there is already work on a German version. However, as a native speaker, I would translate some of the statements differently. May I offer myself as a linguistic reviewer?

I’m a native speaker. What would you translate differently?

I suggest the following changes.
Please don't take it personal. I only corrected some phrases for better more clear understanding and fixed typos.
At best copy and paste my versions to git to see what I changed:
/* Contact developers cell title */
"Contact developers" = "Entwickler kontaktieren";

/* Head tracking cell title */
"Head Tracking" = "Steuerung per Kopfbewegung";

/* Category: My Sayings */
"My Sayings" = "Meine Sätze";

/* Pagination Control: page 1 of x */
"Page %d of %d" = "Seite %1$d von %2$d";

/* Warning: Please move closer to the device. */
"Please move closer to the device." = "Bitte näher ans Gerät kommen.";

/* Privacy policy cell title */
"Privacy Policy" = "Datenschutz";

/* Saved to My Sayings */
"Saved to My Sayings" = "In Meine Sätze gespeichert";

/* Select something below to speak Hint Text */
"Select something below to speak" = "Wähle unten etwas aus, um zu sprechen";

/* Title: Settings */
"Settings" = "Einstellungen";

/* Tune cursor cell title */
"Tune Cursor" = "Feineinstellung des Zeigers";

/* Alert: You're about to be taken outside of the Vocable app. */
"You're about to be taken outside of the Vocable app. You may lose head tracking control." = "Dieser Link wir ausserhalb der Vocable App geöffnet.

I adopted most of your suggestions and made a few changes.
In terms of transparency of stylistic decisions here's my process:

The app should use informal speech to make it a less distancing experience (e.g. no "Sie")
Requests in a care context should not sound overly harsh to facilitate a good relationship between care giver and patient (Not "Ich muss" but "Ich möchte")
Don't use "Okay" because German Siri cannot pronounce it. Use "OK" instead.

PS: Just realised we could have used a Gist for the change requests. Next time! ;)

Thanks so much for your nice feedback! Just made the changes requested.

@m4p Could you resolve these merge conflicts? We'd like to merge in your PR.

On it!

and again...

And done! Ready to merge!

Thank you for your work, @m4p. I'm really looking forward to see it in the app.
(And I apologise for this non topic-related post.)

@m4p The Vocable team wants to thank you for your contribution to the project. Thanks to your help, the latest release of Vocable is now localized in German! Your PR was the very start of our localization effort, and has inspired us to start adding support for many other languages as well.
If you have any other feedback on Vocable, please don’t hesitate to reach out again. We appreciate your support!


Add IsAttributePathSupersetOf in ClusterInfo

Problem
What is being fixed?  Examples:
Need IsAttributePathSupersetOf to filter duplicate path in Read
Change overview
Add IsAttributePathSupersetOf in ClusterInfo
Testing
Add unit test for IsAttributePathSupersetOf

/rebase


fix(webhook/logging): log response code only if response is not none

Thanks for submitting a PR! Please check the boxes below:

[x] I have run pre-commit to check linting
[ ] I have added information to docs/ if required so people know about the feature!
[x] I have filled in the "Changes" section below?
[x] I have filled in the "How did you test this code" section below?
[x] I have used a Conventional Commit title for this Pull Request

Changes
Handle call_integration_webhook returning None in case of failure
details: https://flagsmith.sentry.io/issues/4874822372/?project=5544478&query=is%3Aunresolved&referrer=issue-stream&statsPeriod=24h&stream_index=0
How did you test this code?

I have tested it manually but writing a test for this will involve unit testing a private method. Keen to get some input on this

Codecov Report
Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (61537ce) 95.96% compared to head (d0f8162) 18.00%.

Files
Patch %
Lines

api/integrations/webhook/webhook.py
0.00%
2 Missing :warning:

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #3354       +/-   ##
===========================================
- Coverage   95.96%   18.00%   -77.96%
===========================================
  Files        1071      990       -81
  Lines       32743    28561     -4182
===========================================
- Hits        31421     5143    -26278
- Misses       1322    23418    +22096

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Issue 94: CDC flat forecaster for ED visits

This PR adds the CDC flat forecaster to the timeseries forecast script. This PR closes #94.
Approach
After some consideration I've gone for the alternative approach described in #94. That is the cdc flat forecaster is forecasting numbers of ED visits for the target pathogen.
This was not my initial favoured approach, however, the data frequency is daily and the natural forecast output was in quantiles. One approach could be to weekly bin the numerator and denominator, then generate weekly proportions and then forecast using flat forecaster, but I think this method is more straightforward.
Other additions

epipredict and epiprocess need to be installed with pak. I've added pak and these to the hewr deps and added a conditional install step in the script. If this is unnecessary or a smoother option exists please point this out.
Coercion to as_tsibble has been moved into fit_and_forecast because the cdc flat forecaster does a different coercion to epi_df.

Not modified
This PR does not include post-processing of the cdc flat forecaster. The numerator forecast is unchanged so this is not necessary and will be done in a follow up PR.
Potential pain points
I've inferred the data schema for this PR, and this PR does not commit a unit test for the modified function.

Closing this as it now forms part of #102


Update style.css

changed values to my-paragraph and my-heading in style.css to decrease space between heading and paragraph


Add Sentence Segmenter

en_blackstone_proto, the model that ships with the prototype release of Blackstone, did not come with a sentence segmentation module. By and large, the current model does an okayish job splitting sentences, but it will get baffled on older material where punctation had a tendency to be crop dusted over the text.
We did sketch a sentence pipeline out during the development of the proto model (primarily to help with the data extraction for training the model itself), but it was put together in a bit of a flap.
I rather like scispaCy's implementation, which makes use of a list for abbreviations and section contractions.

Sentence segmenter added https://github.com/ICLRandD/Blackstone/blob/master/blackstone/segmenter.py


[#3600] Add new Bundler/OrderedGems cop

Implementing some part of https://github.com/bbatsov/rubocop/issues/3600.
Actually, I couldn't a good wording for the "groups" of gems as groups are a specific Gemfile notion already

Before submitting the PR make sure the following are checked:

[x] Wrote good commit messages.
[x] Commit message starts with [Fix #issue-number] (if the related issue exists).
[x] Used the same coding conventions as the rest of the project.
[x] Feature branch is up-to-date with master (if not - rebase it).
[x] Squashed related commits together.
[x] Added tests.
[x] Added an entry to the Changelog if the new code introduces user-observable changes. See changelog entry format.
[x] All tests are passing.
[x] The new code doesn't generate RuboCop offenses.
[x] The PR relates to only one subject with a clear title
and description in grammatically correct, complete sentences.
[x] Updated cop documentation with rake generate_cops_documentation (required only when you've added a new cop or changed the configuration/documentation of an existing cop).

This Cop checks that all gem entries belonging in consecutive lines in
the Gemfile appear in alphabetically sorted order.

I actually couldn't figure out how to run rubocop on the code. Could someone explain that?

Ping @bbatsov

I don't see the part that makes this only look at the Gemfile. Multiple calls to a gem method elsewhere would be weird, but still.

The files the cop operates on should just be listed in the default config under -Include.

See #3638 for reference.

@bbatsov Just made the changes and rebased onto master. What should I do about the extra doc that doesn't relate to this cop?

What should I do about the extra doc that doesn't relate to this cop?

Rebase on top of the current master and add those to a separate commit.

@bbatsov I just rebased that on master again

The doc is out-of-sync. Now we finally check for this automatically. Drop the second commit and rebase one more time. Sorry about this.

@bbatsov Just droped the extra documentation changes.

There is one thing missing: the reason why it is necessary to order gems this way.

It's not necessary, just a style convention


Keep getting Cannot GET /api

Hello,
I have a lando drupal 8 installation set up using the contenta distro. The domain on my local http://colony.lndo.site.
I have followed the contenta js installation instructions from the you page.
Steps:

Downloaded zip
run npm install
create local.yml
add cms->host to http://colony.lndo.site.

When I visit http://localhost:3000/api i get the response Cannot GET /api. What's interesting is if I visit the domain without the /api. so...http://localhost:3000/ It looks like it's trying to load my contenta site.
Is there a piece that I am missing?

Hi,
Can someone advise on the issue above? I am getting the same, not sure what's wrong.
Thanks


Graph paritioner input order bug fix

Description
We observed on the python side when initializing the input parameters, sometimes the input ndarray are mismatched with the input args. Here is why the problem occurs.
Here is the process before the data is initialized using the new subgraph API:

Python side call maintains a list of arguments used to construct the symbol and expects the ndarray used for initialization are in the same order. So this problem most likely occurs when we try to initialize custom values to the input parameters.
input symbol S is copied to S' in PartitionGraph() in graph_executor.cc. A nnvm::Graph object g is created and all forward attributes inferred. Then a PartitionGraph pass is ran, which calls PartitionGraph() in partition_graph.cc
In PartitionGraph() in partition_graph.cc, an IndexedGraph is built on g. This IndexedGraph is built based on DFS, thus the order of various data members (such as nodes_, input_nodes_, etc.) are DFS traversal dependent.
Once subgraphs are identified, new subgraph nodes are created and connected with the various inputs. Thus a new graph g' is constructed. The new graph's output nodes are copied back to the copied symbol S'.
S' is passed onto Init() to initialized mainly the ndarray data associated with the input parameters.
During initialization, a new IndexedGraph is built on g', again based on DFS order. This means we will have different ordering in various data objects like nodes_ and input_nodes_. This is due to the topologies of g and g' are different. The construction of ndarray was based on the order of input_nodes_ of g'.
This ndarray returned to the Python side caused shape mismatch with expected input arguments on python side.

We expect the input nodes of g and g' are the same, except due to the DFS traversal enforced on IndexedGraph construction, they can not be consistent (unless we don't use DFS). The simple fix here is essentially capture the original input nodes order in g, and while constructing the ndarrays, we construct them in the order of input nodes in g.
I'm not sure about the side effects, please review and let me know any problems you might find.
Checklist
Essentials
Please feel free to remove inapplicable items for your PR.

[ ] The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
[ ] Changes are complete (i.e. I finished coding on this PR)
[ ] All changes have test coverage:
Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
[ ] Code is well-documented:
For user-facing API changes, API doc string has been updated.
For new C++ functions in header files, their functionalities and arguments are documented.
For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
Check the API doc at http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
[ ] To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

[ ] Feature1, tests, (and when applicable, API doc)
[ ] Feature2, tests, (and when applicable, API doc)

Comments

If this change is a backward incompatible change, why must this change be made.
Interesting edge cases to note here

@ashokei For sure we could force input orders intact if we don't have to follow DFS traversal order for the whole graph, but I don't know how much of their code is written based on that assumption.

if there is a simple unittest that can reproduce this issue, we could add that to subgraph tests.


Spring Boot JDBC tutorial

Related to #6046.
Fixes #3238.
This PR includes:

An end-to-end tutorial on developing a basic Spring Boot application on CRDB with Spring Data JDBC for the data access layer.
An additional entry in the "Sample Apps" ToC section for "roach-data" apps.
Some of the .java files that make up the application project. Those files are included in the tutorial.

The code referenced by this tutorial is located here: https://github.com/cockroachlabs/roach-data/tree/master/roach-data-jdbc. I made a couple minor changes to the application that are reflected in the .java files in this PR and in the tutorial:

Removed follower reads from the application. This feature is a little too advanced for a simple tutorial, and is really meant to be used in the context of a multi-region application.
Simplified some annotation/imports.

Those changes are reflected in a fork of the repo: https://github.com/ericharmeling/roach-data/tree/no-follower-reads.

This change is

Online preview: http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/e60cf60ea8b109e590b59fc9949c0e4606b6667c/
Edited pages:

v20.1/build-a-spring-app-with-cockroachdb-jdbc.md

Online preview: http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/066578d83636979aba2eadc1c71f3a92c99e9547/
Edited pages:

v20.1/build-a-spring-app-with-cockroachdb-jdbc.md

@kai-niemi
Friendly ping on review :)

Online preview: http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/066578d83636979aba2eadc1c71f3a92c99e9547/
Edited pages:

v20.1/build-a-spring-app-with-cockroachdb-jdbc.md

Online preview: http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/aad9fe5f73dc5f9d496837561795de45945ee24f/
Edited pages:

v20.1/build-a-spring-app-with-cockroachdb-jdbc.md

Online preview: http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/2a7382e49a44b795d6f5078a909055594bdeb6fe/
Edited pages:

v20.1/build-a-spring-app-with-cockroachdb-jdbc.md

@kai-niemi
I just added a section on Liquibase. Please review when you get the chance. Thanks! :)

Is it worth renaming the roach-data repo to something like java-samples? Eric, we should merge your roach-data changes?
If the code sample uses Liquibase, can we add beta support here?

Is it worth renaming the roach-data repo to something like java-samples?

I don't think we should rename the app to something as generic, for a few reasons:

These apps are Spring apps, not just Java apps, which is an important distinction a little muddled by having "java" in the project name.
There are other apps that we use for docs and testing that are written in Java (e.g. https://github.com/cockroachlabs/hello-world-java-jdbc and https://github.com/cockroachdb/examples-orms/tree/master/java, to name two). Naming this project "java-samples" could cause some confusion with those samples.
This app is slightly more complex than a Hello World tutorial (like the Spring MyBatis tutorial), but not as complex as our multi-region app, or Kai's roachbank app. Even if we were to name the app "spring_samples", I think that distinction of complexity would also be muddled.
There is a possibility that we mimic this application's design in other languages. A project name like "Roach Data" would be easier to port to other languages.

Eric, we should merge your roach-data changes?

Kai already reviewed the changes I list above, and I merged them. I do have another PR open (https://github.com/cockroachlabs/roach-data/pull/2), but it's not critical.

If the code sample uses Liquibase, can we add beta support here?

Does Liquibase fit our working definition of "beta" support? If not, we might be able to add another support level (e.g., "Experimental) until it does. Customers have been asking about Liquibase for a while now, and I know that many people actually use Liquibase with CRDB without issue.

I don't think we should rename the app to something as generic, for a few reasons:

Reasons make sense to me. As we increase the number of code samples in a specific language, let's think about how we can connect the dots for an AppDev

Does Liquibase fit our working definition of "beta" support? If not, we might be able to add another support level (e.g., "Experimental) until it does.

I think current Liquibase support matches the beta defintion here. It'll be a good exercise to create a checklist like this for schema migration tools. Personally, I'm not a fan of Experimental because I'm not sure what the distinction would be with Beta. To me, one reason to add a 3rd support level would be to indicate tools we're aware of but have no intention of supporting. Liquibase, however, doesn't fall into that cateogory

I don't think we should rename the app to something as generic, for a few reasons:

Reasons make sense to me. As we increase the number of code samples in a specific language, let's think about how we can connect the dots for an AppDev

Sounds good!

Does Liquibase fit our working definition of "beta" support? If not, we might be able to add another support level (e.g., "Experimental) until it does.

I think current Liquibase support matches the beta defintion here. It'll be a good exercise to create a checklist like this for schema migration tools. Personally, I'm not a fan of Experimental because I'm not sure what the distinction would be with Beta. To me, one reason to add a 3rd support level would be to indicate tools we're aware of but have no intention of supporting. Liquibase, however, doesn't fall into that cateogory

Awesome. I'll open a PR to update the tooling page, and then I'll update this PR to link to the Schema Migration Tools section on that page.

I think Liquibase qualifies for beta level support. It doesn't implement retry logic, so in some cases having to re-run the changesets are needed (app launch fails in that case). This app also use a very limited part of the feature set.

Online preview: http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/5d51a7e61a08d4d38c63da03c3f94a0a5f9e2fc8/
Edited pages:

v20.1/build-a-spring-app-with-cockroachdb-jdbc.md

Online preview: http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/7a72472052da7b67f668836573493692acb57a8b/
Edited pages:

v20.1/build-a-spring-app-with-cockroachdb-jdbc.md

@kai-niemi

Worth mentioning perhpas that spring profiles can be used to run different Liquibase changesets for testing or different environments. In that case its only a matter of linking the same name of the spring profiles with the Liquibase 'contexts'. There's only one profile+context in this application for simplicity.

I just added a commit that includes a couple paragraphs about Spring profiles and Liquibase contexts.

I think Liquibase qualifies for beta level support. It doesn't implement retry logic, so in some cases having to re-run the changesets are needed (app launch fails in that case). This app also use a very limited part of the feature set.

That commit also adds Spring to the list of third-party tools. We point to the drivers/ORMs for support level.

@kai-niemi
Thank you so much for your reviews, Kai. I'm moving this to writer review.

Online preview: http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/6e27be0dd251c05aeec948b4c21ffad2ce5abd62/
Edited pages:

v20.1/build-a-spring-app-with-cockroachdb-jdbc.md

Online preview: http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/7f37fa12c9326c16b52dde870cbc6d9d02d81c7c/
Edited pages:

v20.1/build-a-spring-app-with-cockroachdb-jdbc.md
v20.2/build-a-spring-app-with-cockroachdb-jdbc.md


Experiment with dylint to generate a list of all css values

It's really annoying to maintain the css generation process, without a more robust process, this crate is not that usable.
An idea is to find all the class! macro usages, then gather a list of all used css values, then use that information to run the tailwindcss build process.
One way is to find all the class! calls with regex matching, though it'll be tedious, and not easy to handle all modifiers properly. It might be possible to create a certain lint rule, then use dylint to run that and generate the needed information.
If that can work, then there is no special works needed to generate the final css files when using dioxus-class, which will be really nice.
https://github.com/trailofbits/dylint

dylint's way is a bit too heavy, end up borrowed logic from procout, update the emoji-browser demo to use this way, not perfect, but much nicer than before. will update document and publish to crates.io later.

https://github.com/plasticartsshow/procout


arkmanager status command says server is offline when it is online

hi, here is the output from arkmanager status
Running command 'status' for instance 'grounded'
 Server running:   Yes
 Server listening:   Yes
Server Name: [NZ-AU] Grounded (http://grounded.trivial.nz)  - (v251.3)
Players: 1 / 70
Active Players: 1
 Server online:   No
 Server build ID:   1470493
 Server version:   251.3

It says "Server online:   No"  while it is on.  Not sure if this is arkmanager error or if the server is miss-reporting it's status.

Server online: no means that it is not listed on the Steam master server under the configured IP address and port.

@rob-bb
Maybe i can be of help here. So i have had this issue before on ark where you install a server boot it and even after 24h still not showing up online.
Can you show the code for the .cfg ?
ark_Port=
ark_bRawSockets=
ark_QueryPort=
i'm sure it will be that kind of issue !

Hi, I have ark_bRawSockets=true, and am forwarding both tcp and udp for the ports used by  ark_Port and ark_QueryPort

@rob-bb
I see more then one thing that can interfere.
When Klightspeed says "not listed on the Steam master server" this can be one of the next reasons :
Steam Master server don't like --> http://grounded.trivial.nz/ --> for the // and : in the links
Or Steam Master server does not recognize the port you are using.
My configs are like this :
serverMap="TheIsland"
ark_RCONEnabled="True"
ark_RCONPort="32330"
ark_Port="7782"
ark_bRawSockets="True"
ark_QueryPort="27015"
serverMap="TheVolcano"
ark_RCONEnabled="True"
ark_RCONPort="32430"
ark_Port="7780"
ark_bRawSockets="True"
ark_QueryPort="27016"
serverMap="TheCenter"
ark_RCONEnabled="True"
ark_RCONPort="32530"
ark_Port="7778"
ark_bRawSockets="True"
ark_QueryPort="27017"
With the RawSockets you must then open up ports :
Island
Forward 7777 to 7778
Allow Traffic on 7778
Volcano
Forward 7779 to 7780
Allow Traffic on 7780
Center
Forward 7781 to 7782
Allow Traffic on 7782
Works Fine for my Linux Debian 8
Also i use UFW and not direct IP tables, turns out to be more easy to get configs up
If you want some help we could talk it over on teamspeak or so.

Ok, I am forwarding all the ports from my router direct to the server, I will try removing the http:// and double check the ports/firewall settings and see if that helps, after that I might take you up on the team speak chat.

Sure thing ! You helped me with Cron so the least i could do is offer to try and help you out with this !

It seems you were rights, I removes the http:// stuff and now it is showing up in the lists again.

Happy to help out ! <3

@klightspeed
"Server online: No" could also mean there was a problem with the security certificate on https://api.ipify.org/. I had the same problem until I edited the command to http://api.ipify.org/. This does not show up when using the -s (silent) switch in curl. I am not a wiz at http but does this impact any security protocols when processing the command?


Add Docker Compose file for Swift 5.9.0

Motivation
As we approach 1.0 we want to make sure that we compile without warnings (or remarks) on all the Swift versions we claim to support. As discussed in https://github.com/apple/swift-openapi-urlsession/pull/35, this turns out to be subtly different between 5.9.0 and 5.9.1. We cannot drop support for 5.9.0 because the latest released (non-seed) Xcode still uses 5.9.0. However 5.9.1 is the latest release for Linux.
While we don't expect to do this for all patch versions of Swift, in this instance we'd like to add a pipeline for Swift 5.9.0 until such a time that we can expect everyone to be using 5.9.1, which will be some time after an Xcode release with this version.
This will allow us to progress squashing the remarks on 5.9.1 with confidence that we aren't introducing warnings on 5.9.0, which could result in an error for adopters if they compile our generated code with warnings-as-errors.
Modifications
This PR adds a new Docker Compose file to explicitly use 5.9.0.
It leaves the existing 5.9 pipeline to pull 5.9-jammy which resolves to 5.9.1, and will continue to resolve to the latest 5.9.x version.
Result
We can now stand up a new CI pipeline for Swift 5.9.0 explicitly, which we can use this PR to validate.

@yim-lee Please could you help us here too (same as https://github.com/apple/swift-openapi-generator/pull/411). 🙏

@swift-server-bot test this please

@simonjbeaumont Added pipeline for 5.9.0

@czechboy0 just needs an approval for the auto merge.


Switch the steps of post-analysis and publish artifact. Convert sarif file extension to csv

The PR is to have the right order for post-analysis and publish step.
Also, add csv step into published artifacts, so people can check the errors easily.
https://dev.azure.com/azure-sdk/internal/_build/results?buildId=855108&view=logs&s=96ac2280-8cb4-5df5-99de-dd2da759617d

/check-enforcer override


chore: expand pull request template with action items

Which problem is this PR solving?

From Sep 29th, 2021 meeting. This Pr introduces some Action Items to remind contributors and help reviewers with broader changes that might include documentation updates and perhaps how to replicate something.

It might make sense to incorporate the hidden/commented messages in this PR somehow?

The commented lines only show up to the person who is authoring the PR. They are hidden if the PR author leaves it it when they click submit.


network plugins

It was decided that the runtime should manage network plugins, so we should use the kubenet/cni packages that exist in Kubernetes in order to keep compatibility.
For compatibility with other Kubernetes runtimes, we should be able to support kubenet/cni, or something very like it.
For the current rkt integration, we depended entirely on the Kubenretes-CNI, but the reasons are largely outdated (pod ip not available prior to running apps; rkt-CRI fixes that).
The main consideration now is configuration-directory compatibility and any other differences kubenet has from pure CNI.
We might be able to get away with rkt-cni now. cc @squeed

Cool.
We can definitely get away with most of the work done in CNI, but there are a few things not currently supported there:
-traffic shaping
-firewalling
-port forwarding (though rkt handles this)
Also: there are a few connection tunables, such as MTU, that need to be injected in to the CNI config on disk :-/


clearCachedProvider doesn't remove walletconnect localStorage (auto signs-in last WC acct)

Hi,
Even with cachedProvder: false clicking WC will auto-sign-in the previous account because the walletconnect localStorage item is still present.
Would be a nice improvement not to have to do that manually :)
Thanks for developing this modal!

Please fix this

try this
localStorage.removeItem('walletconnect')

With stable version 2.0.0 of Web3Modal now released, we are officially dropping support for version 1.x
Due to this this issue/pr was marked for closing. It is highly recommended to upgrade as 2.x will be receiving further updates that will enable functionality for some of our newer sdks like auth and push as well as support for WalletConnect v2 (See this post about WalletConnect v1 being deprecated https://medium.com/walletconnect/walletconnect-v1-0-sunset-notice-and-migration-schedule-8af9d3720d2e)
If you need to continue using Web3Modal 1.x and require this feature/fix implemented, we suggest adding it via forking V1 branch.


Solvers have an incorrect namespace

Reality Collective - Reality Toolkit Bug Report
Describe the bug

The Solvers (residing in core) currently have an SDK namespace, this should be corrected.

Resolved via - https://github.com/realitycollective/com.realitytoolkit.core/pull/13


RealtimeStereo - new improvement

Issue Type
Support
OS
Ubuntu
OS architecture
x86_64
Programming Language
Python
Framework
TensorFlowLite
Model name and Weights/Checkpoints URL
https://github.com/PINTO0309/PINTO_model_zoo/tree/main/165_RealtimeStereo
Description
Hi author,
As I know so far, you had some improvement about RealtimeStereo, which are ONNX and Blob models. (https://github.com/luxonis/depthai/issues/173#issuecomment-1134806408)
Could you please share the convert script or public the Tensorflow Lite model ? Many thanks in advance !
Relevant Log Output
No response
URL or source code for simple inference testing code
No response

https://github.com/PINTO0309/PINTO_model_zoo/blob/main/165_RealtimeStereo/convert_script.txt


Use em dash

Pretentious quotes should be pretentious. (:

Just having some fun! Here's a good read: https://en.wikipedia.org/wiki/Dash#En_dash_versus_em_dash

I updated based on your requested changes and signed the agreement, btw.

I love a good em-dash — I use them all the time.


The default source of nuget is not available, but the custom source is available

Have you ever encountered such a problem?

Configured a new source (CDN network), which can display a list, but cannot load and display details in pages. The installed and updates tabs are also unavailable
Extended Configuration：

Default Source，Installed tab：

Default Source，Updates tab：

CDN Source：

CDN Source，Installed tab：

CDN Source，Updates tab：

Custom Source：

Hello,
I cannot reproduce this issue.
I have added that cdn source on my side and it works fine. All the tabs load correctly.
Are you still experiencing this?

Close as cannot reproduce


Build machine appears to run out of memory building LLVM

I noticed that LLVM wasn't available in the binary cache, but built fine on machine. It looks like the build machine is running out of memory:
g++: fatal error: Killed signal terminated program cc1plus

See https://hydra.nixos.org/build/110563745

Closing since this is no longer a problem.


feat: add secrets backend relation

Description
This PR introduces the Vault-kv relation to vault-k8s.
The vault-kv interface can be discussed here
This interface is a port from the machine charm interface with some note worthy differences:

Secret role id is no longer access by the requirer through a wrapped token
The provider side shall fill in the vault_url in the app databag
isolated is not allowed anymore as this concept is not really translatable to k8s charms

Note worthy change to Vault charm:

The default vault k8s svc is no longer patched to become a load balancer type, instead a new one is created. This results in a ClusterIP svc and a LoadBalancer svc (allows for outside access). A ClusterIP svc is necessary to allow ACLs based on related units' IP addresses

Checklist:

[X] My code follows the style guidelines of this project
[X] I have performed a self-review of my own code
[ ] I have made corresponding changes to the documentation
[X] I have added tests that validate the behaviour of the software
[X] I validated that new and existing unit tests pass locally with my changes
[ ] Any dependent changes have been merged and published in downstream modules

Convert to draft to make sure interface PR is merged first

Force push is only rebasing on main, with no noticeable change (except the part on vault SVC to align with main).
Will now take into account the comments on interface, and on this pull request. Thank you for all your feedback.

Still WIP, mainly a rebase over main branch + integration of charm-relation-interface

Rebase on main to get Ingress address into vault server's certificate.
Adding ca_certificate as relation data, cf: https://github.com/canonical/charm-relation-interfaces/pull/105
Storing secret ids in peer relationship because getting secret by label only lead you (after a grant) to get a secret id in short form, which does not work over CMRs


Class of 2020 picture

I'll leave that to @NischalLalShrestha to manage. Headline banner!

@InfoDevkota , I will leave that to you!!


Three changes

Make InboundLedgers tracking of recent failures more accurate and better reported in fetch_info.
Avoid lock overlap in InboundLedgers.
Don't be so quick to disconnect a peer that takes some time to respond to pings.

:+1:

:+1:

:+1:


Add support for the newly us-east-2 (Ohio) region.

Add support for the new Ohio region.
This adds a few ERROR: Trouble generating reserved price: KeyError('yrTerm3.partialUpfront-quantity',).

+1
Clearing those errors should just be a matter of building the reseved_prices dict entry by entry, leaving it out or None if a key is missing.


Menu :none doesn't work as documented

The docs say you can do menu :none, but it's actually menu none: true. Should we update the docs to reflect that? Or do you want to fix the old behavior?

This is fixed in pull request #293. Don't know where @smpallen99 is. :(


ios Doesn't work with use_frameworks! on 0.61.0 version of ReactNative

React native version is 0.61.0
steps are the same as in link ios documentation.

Hi dekameron22,
I solved this by adding s.static_framework = true to react-native-agora.podspec and running pod install again

Hello @mmatheusmmiguel , that worked like a charm!
thanks a lot!


Save filters and sorters to profile

Closes #3

There appears to be an upstream bug related to sortedInfo so waiting for conclusion of that before merging this
I wrote on discord:

Found a bug with sortedInfo
Change the sort order of any item, reload the page and the sort is not re-applied. See attached log, seems invalid JSON is saved.
Looks to me like it is doubled parsed?
try {
  const storedSortedInfo = JSON.parse(localStorage.getItem('sortedInfo'));
  if (storedSortedInfo) {
    setSortedInfo(JSON.parse(storedSortedInfo));
  }
} catch (error) {
  // Handle the error
  console.error('Error parsing stored sortedInfo:', error);
  // Remove the key from localStorage
  localStorage.removeItem('sortedInfo');
}

Comparing to
const storedFilteredInfo = localStorage.getItem('filteredInfo');

if (storedFilteredInfo) {
  setFilteredInfo(JSON.parse(storedFilteredInfo));
}

https://discord.com/channels/1220524110090600599/1220524223068635156/1263653657472143452


Fix the appBundleId for MacOS build to give out the custom BundleID to the electron-packager

Currently the natifier MacOS package generates package with default com.electron.appName
Fix for 712
Fix to support below
https://github.com/electron-userland/electron-packager/blob/master/docs/api.md#appbundleid

@lmssrinivas sure, but two things:

Again, please explain why. What does this bundleId do? In https://github.com/jiahaog/nativefier/issues/712#issuecomment-442176356 you say "appBundleID is the key/AppID for the build we are creating for the store"; what does that mean? Who uses this id and to do what?
Documentation and command-line flag, please. See https://github.com/jiahaog/nativefier/pull/627/files for inspiration.

This article explains what app ids are for: https://cocoacasts.com/what-are-app-ids-and-bundle-identifiers/
Basically, they are required to be set to specific values for Mac App Store submissions.

@lmssrinivas if you're still interested in getting this merged: doc and command-line flag, please. See jiahaog/nativefier/pull/627/files for inspiration 🙂.

Closing, as stale with requested changes. Feel free to fix/rebase and ping me for a re-open!


Fix app store loading and error messages

The pull request fixes two issues related to the app store.
The first commit removes a non-resolving URL that was causing the app store refreshing to take more than 15 seconds.
The second commit prevents the flashing of an "Unknown error" message when the index is loaded but the main menu is not created.

Ugh I definitely had a short timeout on that first one at one point. Thanks!


Question: Which version of postgres does pg-mock have?

as per title

The latest version (as of 2024-07-31) is running PostgreSQL 14.5.
Executing SELECT version(); in the web demo returns the following:
PostgreSQL 14.5 on i686-buildroot-linux-musl, compiled by i686-buildroot-linux-musl-gcc.br_real (Buildroot 2022.08) 12.1.0, 32-bit


Render example error in Ember 1.13

The following example
{{#each flashMessages.queue as |flash|}}
  {{#flash-message flash=flash as |component flash|}}
    {{#if flash.template}}
      {{render flash.template flash.context}}
    {{else}}

{{component.flashType}}

{{flash.message}}

    {{/if}}
  {{/flash-message}}
{{/each}}

throws the following error.
Uncaught Error: Assertion Failed: The first argument of {{render}} must be quoted, e.g. {{render "sidebar"}}.

It would seem one cannot use render in this way. Another possibility would be to replace this line with a component helper, available since 1.11.
...
    {{#if flash.componentName}}
      {{component flash.componentName content=flash.content}}
    {{else}}
...

Ah thanks, I haven't updated the readme! Would you like to submit a PR for it? :)

Sure! I'll do that now.

I think this can be closed as a result of #97

Agreed.


Redis memory increases linearly

Been running on production now for a day, and our Redis memory usage has only gone up, never down.  Is there a way to evict completed jobs from redis once they're completed to avoid our storage simply growing forever @behrad ?
Thanks, would be super helpful.

https://github.com/Automattic/kue#job-cleanup

Thanks @tjsail33


php artisan schema:dump throws an error on Windows

Laravel Version: 8.0.0
PHP Version: 7.4.9
Database Driver & Version: mysql Ver 15.1 Distrib 10.4.14-MariaDB

There's a PR open that'll fix this shortly: https://github.com/laravel/framework/pull/34233


Add migration guide for v2 + fix outdated docs

2 problems:

provisioning of packageName should be simplified. Putting this in app/build.gradle in testInstrumentationRunnerArguments works only when running tests with Gradle. This breaks on e.g. cloud device farms:
testInstrumentationRunnerArguments clearPackageData: "true", "packageName": "com.example.myapp"

Specifying packageName in MainActivityTest.java is probably a better idea:
@RunWith(Parameterized.class)
public class MainActivityTest {
    @Parameters(name = "{0}")
    public static Object[] testCases() {
        PatrolJUnitRunner.setPackageName("com.example.myapp");
        PatrolJUnitRunner.waitForPatrolAppService();
        return PatrolJUnitRunner.listDartTests();
    }

    // ...
}

We could also try getting it from BuildConfig – see here.

setting clearPackageData: "true" (see above) causes behavior to be differ between Android and iOS. There's no equivalent of clearing all app's data on iOS.


Test / fix bugs outgoing calls

Right now only the webclient -> cli call path has been tested - due to my limited Windows WSL2 setup not being able to access the webcam. TODO test outgoing calls from cli, id & report (or just fix) bugs.

Need to test for Mac and Windows.
Found bug with outgoing calls when no video device can be found - call cannot be completed. Will write up new bug.


[FABCE-149] Receipt logs should default to empty array

Resolves issue FABCE-149

I see three issues

gofmt the change
fix the unit tests
the integration tests aren't going to work until we make a change or update our base to 2.0 (or maybe 1.4.6)

And thanks for the contribution. It may take us a bit to fully evaluate and merge it.

Okay. I'll work on unit tests and formatting

Commenting to keep the PR fresh (noticed it went stale). Unit tests fixed and formatting fixed.

Thanks again for the patch. The update looks good for the two mentioned issues.
We're going to need this rebased on master to pick up a9d103e9f8c7353c84ba6f26862f16fccb717985 and get the results of the integration tests. After which there is probably going to be another update needed to fix any test failures there.
Thanks for your patience.

Excellent. Okay I will work on making this an output marshaller. Thank you!

It would require a new test in that package.
Something like https://github.com/hyperledger/fabric-chaincode-evm/blob/2b037c904e99c7b965f166259c62cdbeaadfdf28/fab3/types/types_test.go#L187-L214 would correspond to the marshaller previously discussed..

@MHBauer
Hi,
Sorry, I'm wondering if you can answer a question I have.
First, I have defined the marshaller as you've suggested, and written a test, but now I'm confused as to where or how these marshallers are being used in code. I've done a grep on the codebase and I can only find them called in their corresponding test file types_test.go
Can you show me as an example how Transaction.MarshalJSON() is being used? Or maybe this is something I don't need to worry about?
Thanks!

Actually nvm my last question. I've learned that they are automatically called whenever their structs are marshalled into json. I'll push my changes shortly.

If we want to ensure that this particular issue does not reoccur, we should also add to the integration test https://github.com/hyperledger/fabric-chaincode-evm/blob/master/integration/fab3/fab3_test.go#L123-L139 a check for an empty array at receipt.Logs, right?

One other change I would recommend is updating the documentation so it corresponds with your change: https://github.com/hyperledger/fabric-chaincode-evm/blob/master/Fab3_Instructions.md#eth_getTransactionReceipt.

Agree, specifically to add an example of the logs entry, or the empty array value, https://github.com/hyperledger/fabric-chaincode-evm/blame/master/Fab3_Instructions.md#L297

The integration tests were working after I rebased, but are now failing again after my last commit.

Also, I'll add the integration test and documentation as suggested.

Okay. Looks like my latest change broke integration tests. Unfortunately I'm unable to run integration tests locally. I'm running into this issue: https://jira.hyperledger.org/browse/FAB-15665
I'll work through that and then revisit here once I have things working again.

@abrinckm if you're on a mac, I have a patch for that. https://github.com/MHBauer/fabric/commit/59a54bea995fad11090ce8b323bbcc215aec0905

@abrinckm if you're on a mac, I have a patch for that. MHBauer/fabric@59a54be

that worked

@MHBauer @swetharepakula
Alright, I think it's good for another review. I modified the integration test so we don't see a reoccurrence and changed the examples to reflect logs as an empty array.
Reverting the unit tests causes them to fail. I believe those changes are still required for the tests to pass even with the new output marshaller. This is because the receipt structures we compare against are simply constructed inline and never marshalled. So the constructor needs the logs field set for it to be correct.

@MHBauer @swetharepakula No worries! I'm determined to get this fixed.
I've tried your suggestion. I've reverted my changes in the ethservice.go, but the receipt logs are returned as nil which reintroduces the original bug.

Made an example branch and pr on my fork to check the outupt
https://github.com/MHBauer/fabric-chaincode-evm/pull/4
build it
https://dev.azure.com/mbauer0254/fabric/_build/results?buildId=18&view=results

As an example, if I turn on verbose test output
{"jsonrpc":"2.0","id":16,"method":"eth_getTransactionReceipt","params":["98060ced4d3faf8666d38538400e1c7e002ba90c10233390184d9599c857f57f"]}
[e][Org1.peer0] 2020-04-15 08:52:23.241 PDT [endorser] callChaincode -> INFO 08a [testchannel][a1f602bf] Entry chaincode: name:"qscc"
[e][Org1.peer0] 2020-04-15 08:52:23.241 PDT [endorser] callChaincode -> INFO 08b [testchannel][a1f602bf] Exit chaincode: name:"qscc"  (0ms)
[e][Org1.peer0] 2020-04-15 08:52:23.241 PDT [comm.grpc.server] 1 -> INFO 08c unary call completed {"grpc.start_time": "2020-04-15T08:52:23.241-07:00", "grpc.service": "protos.Endorser", "grpc.method": "ProcessProposal", "grpc.request_deadline": "2020-04-15T08:55:23.241-07:00", "grpc.peer_address": "<IP_ADDRESS>:33336", "grpc.code": "OK", "grpc.call_duration": "800.188µs"}
{"jsonrpc":"2.0","result":{"transactionHash":"0x98060ced4d3faf8666d38538400e1c7e002ba90c10233390184d9599c857f57f","transactionIndex":"0x0","blockHash":"0x62167e704c96f8ff19556c72b8ffaa79ffd3d4ffd30e1d195d012c67dd7a3972","blockNumber":"0x5","contractAddress":"0xd0fe8897d3ffb144a374788dd20e0048dd8dc956","gasUsed":0,"cumulativeGasUsed":0,"to":"","logs":[],"status":"0x1","from":"0xc2c468b207d68e0ca079e45eb3eefef2ecb0810d"},"id":16}

in the last line, I can see raw json is ,"logs":[],

Yup, squash the last two and drop the first two, and this is merged.

Not sure why checks are yellow, but I would ignore them and do the update.

@MHBauer Okay done!

@MHBauer @swetharepakula  Thanks for your patience!

Thanks @abrinckm! I hope you continue contributing to our project!


HdfsDataSegmentPusher bug fix

Fixes https://github.com/druid-io/druid/issues/3997
Hdfs namespace optimization changes #3877 introduced a bug in HdfsDataSegmentPusher causing exceptions during segment push (if an interval has more than one shard.)

:+1:

Taking a look now. @akashdw have you tried this on a live cluster to confirm the fix?

@gianm  tested puller pusher and it worked, but found a small correction to be made. Uploading a new patch.

@akashdw  what is the "small correction" ?

Written descriptor file in hdfs is missing load spec https://github.com/druid-io/druid/pull/4003/files#diff-43eb9286d827e862f82f83f06e495fe1R137. Adding a test to actually read the value of descriptor file instead of only relying on returned DataSegment object after the push.

thanks for testing and catching that. :+1:

@akashdw is the PR updated with the new patch? If so I'll take a look

@gianm I tested out the puller/pusher with the last version and both worked. Found load spec is missing while doing manual validation of descriptor file stored in hdfs.
Sorry for missing out that check and creating this PR without validating actual content of the file.


Increase timeout on join for preemption test

The use of less powerful machines for testing can result in //tensorflow/python/distribute/failure_handling:failure_handler_test failing with an internal timeout while waiting for threads to join(). Add a timeout of 300s to override the default 200s in this case.

@cfRod @nSircombe

How close are you to the new 300 timeout (i.e. is 300 enough?)


feat: support stringified lists and dicts

Some components will require lists or dicts to be passed, that are defined in the template (for example, a list of options for a dropdown component). This makes that possible

[sc-47945]


Provide examples to collect Web Vitals from AMP enabled Websites using GA and GTM

I use Google Tag Manager for AMP enabled wordpress site. And it currently has a generic page view tracking thanks to Google Site Kit Plugin.
I can't place web-vitals script from GTM anymore as it is not supported in AMP container. But I recently found out that you can use amp-analytics with built in variables like this.
<amp-analytics type="googleanalytics">
	<script type="application/json">
        {
          "vars": {
            "gtag_id": "UA-XXXXXXXXX-X",
            "config": {
              "UA-XXXXXXXXX-X": {
                "groups": "default"
              }
            }
          },
          "triggers": {
            "default pageview": {
              "on": "visible",
              "request": "pageview",
              "vars": {
                "title": "{{title}}"
              },
              "extraUrlParams": {
                "lcp": "${largestContentfulPaint}",
                "cls": "${cumulativeLayoutShift}",
                "fid": "${firstInputDelay}"
              }
            }
          }
        }
	</script>
</amp-analytics>

But honestly, I have no idea how this value gets mapped on the google analytics. Also, I don't have enough knowledge to fit the same setting in Google Tag manager.
So If you could add instructions for AMP enabled websites as well it would be a great addition to the documentation.
The AMP enabled websites are only 0.1% of total websites in the web. But people like me switched to AMP mainly for Core-Web-Vitals benefit. So If you could provide a consistent way to test the results, It would be helpful.

Sorry for the slow response. I'm actually not familiar with how AMP reports this data through GTM either. @kristoferbaxter any idea who we can route this to?

I'm on my phone right now, but will ask Mica from the AMP Project to take a look tomorrow.
Know there is a guide for supporting CWV metrics reporting, but am less familiar with GA integration.

The example in my issue description is taken from AMP documentation. Even though it is helpful in terms of sending these metrics as custom dimensions, I was hoping to send these metrics as Events. This way I could plot them directly in https://web-vitals-report.web.app/.
With that being said, I raised this request when AMP was lacking features to convert these decimal points to integers by multiplying them by 1000 or rounding them. But I and @micajuine-ho worked this out via PR ampproject/amphtml#33383 a few weeks back.
This is how I use the amp-analytics module on my website at the moment.
<amp-analytics  type="googleanalytics">
<script type="application/json">
{
  "vars": {
    "account": "UA-123456-1"
  },
  "triggers": {
    "capture CLS": {
      "on": "visible",
      "request": "event",
      "vars": {
        "eventCategory": "Web Vitals",
        "eventAction": "CLS",
        "eventLabel": "${clientId}-${pageViewId}-CLS",
        "eventValue": "$CALC(${cumulativeLayoutShift},1000,multiply,true)"
      }
    },
    "capture FID": {
      "on": "visible",
      "request": "event",
      "vars": {
        "eventCategory": "Web Vitals",
        "eventAction": "FID",
        "eventLabel": "${clientId}-${pageViewId}-FID",
        "eventValue": "$CALC(${firstInputDelay},0,add,true)"
      }
    },
    "capture LCP": {
      "on": "visible",
      "request": "event",
      "vars": {
        "eventCategory": "Web Vitals",
        "eventAction": "LCP",
        "eventLabel": "${clientId}-${pageViewId}-LCP",
        "eventValue": "$CALC(${largestContentfulPaint},0,add,true)"
      }
    }
  }
}
</script>
</amp-analytics>

We just need to document this somewhere.

And for Google Tag Manager for AMP, the AMP Variables setup in GTM escapes the $ signs by default.

Guess we can ignore GTP for now.

Closing this as seems less related to this repo and more for AMP.


Replacing "Host" with "Machine" in API

Our current API references both VM and physical machines as "Host".  However, since we are closely aligning to Docker, this might cause confusion given that they use "Machine" to describe this.  By changing the API to "Machine", you would not need to explain what a Host vs a Machine is anymore.

I agree. It also does not make sense for a host to be a VM, while a machine can be a physical or virtual machine.
Sheng
From: will-chan<EMAIL_ADDRESS>Sent: Wednesday, February 4, 2015 6:35 PM
To: rancherio/rancher
Subject: [rancher] Replacing "Host" with "Machine" in API (#83)
Our current API references both VM and physical machines as "Host". However, since we are closely aligning to Docker, this might cause confusion given that they use "Machine" to describe this. By changing the API to "Machine", you would not need to explain what a Host vs a Machine is anymore.
—
Reply to this email directly or view it on GitHubhttps://github.com/rancherio/rancher/issues/83.

Where did this come from?  This doesn't make sense in the context of our API.  We can't try to align our API with Dockers marketing names.  A host in our API is not even the same as a machine.

How is a host in our API not the same as a machine?
Sheng
From: Darren<EMAIL_ADDRESS>Sent: Wednesday, February 4, 2015 6:44 PM
To: rancherio/rancher
Cc: Sheng Liang
Subject: Re: [rancher] Replacing "Host" with "Machine" in API (#83)
Where did this come from? This doesn't make sense in the context of our API. We can't try to align our API with Dockers marketing names. A host in our API is not even the same as a machine.
—
Reply to this email directly or view it on GitHubhttps://github.com/rancherio/rancher/issues/83#issuecomment-72984799.

A host in our API is basically the same as the docker daemon.  We have a separate type that is already called something like dockerMachine.  That's is why I'm confused here, where did this issue come from?  @cjellick and I already discussed this and host is a seperate.
But yes,

Sorry, accidentally closed

But yes, our API does not perfectly match Docker, but that is fine.

@will-chan Do you want to call a host a machine in the UI?  That seems odd to me.  Again, "machine" is a product name.  People either call them servers or hosts, but if we really want we can make the UI be machine.

Also I don’t think machine is a Docker marketing term. It is being used to generically describe physical and virtual machines in the context of containers. Cadvisor, for example, also has a machine construct:
https://github.com/google/cadvisor/blob/master/docs/api.md
Machine Information
The resource name for machine information is as follows:
/api/vX.Y/machine
This resource is read-only. The machine information is returned as a JSON object containing:

Number of schedulable logical CPU cores
Memory capacity (in bytes)
Maximum supported CPU frequency (in kHz)
Available filesystems: major, minor numbers and capacity (in bytes)
Network devices: mac addresses, MTU, and speed (if available)
Machine topology: Nodes, cores, threads, per-node memory, and caches
The actual object is the marshalled JSON of the MachineInfo struct found in info/machine.gohttps://github.com/google/cadvisor/blob/master/info/machine.go

From: Darren<EMAIL_ADDRESS>Sent: Wednesday, February 4, 2015 6:44 PM
To: rancherio/rancher
Cc: Sheng Liang
Subject: Re: [rancher] Replacing "Host" with "Machine" in API (#83)
Where did this come from? This doesn't make sense in the context of our API. We can't try to align our API with Dockers marketing names. A host in our API is not even the same as a machine.
—
Reply to this email directly or view it on GitHubhttps://github.com/rancherio/rancher/issues/83#issuecomment-72984799.

@ibuildthecloud the fact you need to explain that a host in Rancher API is synonymous with a docker daemon can already be a bit confusing.  I'm not as tied to the definition of a host vs a machine as @sheng-liang is but I am more concerned that once the API is out, Rancher will end up having to explain what adding a host is if we expect our users to continue to use Docker natively.  In Docker, they are using the term of adding a Machine as a "Docker host" for their containers.  That is exactly what adding a Host in Rancher means.  Is it different?

@will-chan @sheng-liang @ibuildthecloud Can we call this resolved since we have already shipped the functionality with "a computer created by docker machine" === machine and "a docker daemon running on a computer" == host?

FYI there's a similar discussion in the Machine upstream; https://github.com/docker/machine/issues/727

Yes the community seems fine with the term host.
Sheng
From: Sebastiaan van Stijn<EMAIL_ADDRESS>Sent: Tuesday, March 31, 2015 12:54 PM
To: rancherio/rancher
Cc: Sheng Liang
Subject: Re: [rancher] Replacing "Host" with "Machine" in API (#83)
FYI there's a similar discussion in the Machine upstream; docker/machine#727https://github.com/docker/machine/issues/727
—
Reply to this email directly or view it on GitHubhttps://github.com/rancherio/rancher/issues/83#issuecomment-88226394.


Added SQLite3 unrelocatable text files

Testing: https://travis-ci.org/ingenue/hunter/builds/146954345

Uploading:

https://travis-ci.org/ingenue/hunter/builds/146958043


Installation suggestion via composer

Hello
Good afternoon

What would be the procedure that indicates you to install your module in Magento2?

I have not found your module in
https://packagist.org/search/?q=umc
To install via composer
It is my suggestion to release the module via composer

@hackin88 I will release this on packagist as soon as I have a stable version that I'm satisfied with.
Right now it's in the dev stage and I'm a little behind on the testing.

@hackin88  you should be able to install this extension via composer. The package is not on packagist, but it should work anyway via git.

@hackin88 The extension is not on packagist, but you should be able to install it via composer anyway.

Hello good afternoon
Thanks for answering
Please what is the procedure to install your module via composer?

@cerebrumgit I forgot to post the link. Sorry: https://github.com/UltimateModuleCreator/Umc_Base/wiki/installation


Swift 3: NSURL to URL

Swift 3 drops the NS prefix for a lot of classes, including NSURL. I think that the URL extension in the the 3.0.0 release has not yet been updated to use URL instead of NSURL.

Just merged https://github.com/SwiftyJSON/SwiftyJSON/pull/652
Will be part of 3.1 release.


Tutorial: namespaces

We need to write a definitive tutorial on how namespaces work in ClojureScript.
Namespaces in CLJS are different than in Clojure and they are one of the first things that a new CLJS dev has to deal with.
The tutorial should be comprehensive, covering all of the keywords that can be used in an (ns) form (:require, :refer, :as, :import, etc)

I started this in the ns special form doc by listing all possible forms there, but stopped short of explaining each of them.
More resources:

require vs import - blogpost
official cljs wiki section on namespaces


[RFR] Add doc on input date requirement for format

Following a discussion with @jamespsterling on Gitter.


Reuse Cpython bots

I'm not sure it's practical, but CPython has tons of bots to do various tasks.
E.g. https://github.com/python/bedevere/ labels PRs etc, we might want to reuse them, or at least some of the logic they have?
(The other two bots are less relevant, one checks whether the CLI is signed by the contributor, and the other is for backports)

At a glance, it does not seem as easily customizable as baldrick here, but worth exploring if we happen to encounter CPython devs in one of the conferences and they are willing to provide consultation.

Well, the appropriately cunning plan could be to get them use and contribute baldrick :)


Error: inserting target into state: inserting target ip:port for upstream xxx: entity already exists

Kong Version 2.1.2
decK Version 2.2
When using upstreams with targets in my kong configuration deck fails with this error when using --select-tag in command line or select_tags in yaml file.
With routes, services, plugins and upstreams without target there is no problem. Only if i add targets to the upstreams.
If i don't use tags everything works fine, also with targets.
First time the configuration will be synct to kong without any problem. But after that every dump, diff or sync shows this error.
Is this a known bug?

Can you please share the yaml file so that we can reproduce this error?

ok, added  2 sample files, with these 2 yaml files i could reproduce the problem on a 2nd environment:
upstream.zip
added v-proxy.yaml to ./master_config and sync:
./deck sync --select-tag deck-managed -s ./master_config
creating upstream webhost
creating target <IP_ADDRESS>:443 for upstream ff8dedff-a544-42c7-abd2-6204f5f3eb38
creating target <IP_ADDRESS>:443 for upstream ff8dedff-a544-42c7-abd2-6204f5f3eb38
creating service v-proxy
creating route v-routes
Summary:
  Created: 5
  Updated: 0
  Deleted: 0

added w-proxy.yaml also to ./master_config and sync again:
./deck sync --select-tag deck-managed -s ./master_config
creating upstream webhost2
creating target <IP_ADDRESS>:8443 for upstream 157eb1aa-efa7-4331-a32c-8d6d9cd59f44
creating target <IP_ADDRESS>:8443 for upstream 157eb1aa-efa7-4331-a32c-8d6d9cd59f44
creating service w-proxy
creating route w-routes
Summary:
  Created: 5
  Updated: 0
  Deleted: 0

after that:
./deck diff --select-tag deck-managed -s ./master_config
Error: inserting target into state: inserting target <IP_ADDRESS>:8443 for upstream 157eb1aa-efa7-4331-a32c-8d6d9cd59f44: entity
already exists

./deck dump --select-tag deck-managed
Error: building state: inserting target into state: inserting target <IP_ADDRESS>:8443 for upstream 157eb1aa-efa7-4331-a32c-8d6d9cd59f44: entity already exists

Don't know if select-tag is needed in command because it is still in config
_info:
select_tags:

deck-managed

but this makes no difference.

This is potentially a bug in decK and needs further investigation. We will look into it and report back soon.

There is nothing new about the bug?

There is nothing new about the bug?

@mflendrich Let's get this re-prioritized for investigation.

tested with deck 1.5.1 where #280 should be fixed.
Error already exists.
Seems that #280 don't fix this problem.

@michaelhsk I tried to reproduce this based on the files in https://github.com/Kong/deck/issues/233#issuecomment-728766614 but I couldn't.
Can you please provide a new set of reproduction steps? Or if I'm missing something, please let me know.

Meanwhile we are using Kong 2.2.1, deck 1.5.1, same problem on 5 similar environments. All use cassandra as database. Maybe that this makes the difference?

Ah, C*. What would help us is if you could use --verbose 2 and record an entire sync/diff event in an environment where this is happening. That would tell us if Kong's API is violating a contract which is causing this failure in decK. That seems unlikely but worth exploring because I don't have more ideas of what's wrong in decK.

Hi, tried it also on a testinstallation with postgres DB, the problem does not seem to arise there.
Again similar installation with cassandra db. the problem occurs again.
Attached you find the output with --verbose 2.
deck_output_verbose2.zip

@hbagdi , wasn't there a kind of flag to generate a throttling for Cassandra? Could it help?

@mmorel-35 Good idea. @michaelhsk could you try this again with --db-update-propagation-delay and see if it changes the situation?

tried, unfortunately, does not solve the problem.

Seems that the error  has to do with the tags table.
I deleted the rows for the 4 targets in the tags table, after that the following occured:
diff shoes no error, only that 4 targets will be created.
Summary:
Created: 4
...
1st sync: no error,  4 targets will be deleted, 4 targets will be created.
Summary:
Created: 4
Deleted: 4
In cassandra DB i can see that only the delete was done.
2nd sync: no error, 4 targets will be created.
Summary:
Created: 4
After the 2nd sync the targets are really created, and i can see them in the targets table and the rows to the tags table where also addded.
So all entries are completely available again in database.
And now next sync shows the error again.

Can you remove tags from your configuration and verify if the error occurs or not?

See my first post ;-).
"If i don't use tags everything works fine, also with targets."
So if i don't use tags as parameter and at _info section in yaml everything works fine.

@fffonion probably has some ideas as to why this happens.

Meanwhile we have migrated our test environments to Kong 2.4.1 and it looks that the problem no longer occurs.  It seems that it is fixed in kong and not really a deck problem.

It seems that it is fixed in kong and not really a deck problem.

Yes, this is a problem in Kong and not decK because it violates the API contract (hence the ping to @fffonion earlier).
Going to close this, please report back if the problem persists and we will re-open.


TS code generation bug for classes???

Please sync up to avrcodegen, jake and then
node.js built\pxt.js
to see the error:
C:\Users\tball\Documents\GitHub\pxt\built\pxt.js:54205
d.prototype = b === null ? Object.create(b) : (__.prototype = b.prototype, new __());
^
TypeError: Cannot read property 'prototype' of undefined
at __extends (C:\Users\tball\Documents\GitHub\pxt\built\pxt.js:54205:68)
at C:\Users\tball\Documents\GitHub\pxt\built\pxt.js:59294:13
at ts.pxtc.ts.pxtc (C:\Users\tball\Documents\GitHub\pxt\built\pxt.js:59327:10)
at ts (C:\Users\tball\Documents\GitHub\pxt\built\pxt.js:59329:7)
at Object. (C:\Users\tball\Documents\GitHub\pxt\built\pxt.js:59330:3)
at Module._compile (module.js:409:26)
at Object.Module._extensions..js (module.js:416:10)
at Module.load (module.js:343:32)
at Function.Module._load (module.js:300:12)
at Function.Module.runMain (module.js:441:10
It comes from the file backavr.ts, which simply defines a class. I am at a loss about the error.

You need to define classes in the right order. You can do that with <reference...> - just pushed a fix

Thanks, Michal.


Reading config values without sales channel id

The documentation links to this project and shows the same code as in src/Subscriber/MySubscriber.php. Generally that was a good starting point for me to get a plugin with its own configuration running. But as we have more than one sales channel in our installation, the read values seem to be empty, if there is a value (vor any setting) on a sales channel, but not globally.
This is not even me failing here, there seem to be plugins expecting SystemConfigService->get() to automatically use the current sales channel for reading config values, leaving away the second argument.
Reading the code in SystemConfigService->load(), the settings are read from the global context instead, if the second parameter is left away. Is that right?
If yes, this should be stated clearly in the documentation, before many others scratch their head about their non working sales channel configuration.

hey @ansgarbecker
I will transfer the issue to the platform repo, as it aims for the core code and documentation


Doctrine 2.5 is stable

Doctrine 2.5 is stable

@tubssp thanx! Sorry for didn't merge it, was not on Internet.


[Question] How do I release an iOS build that was set not to auto release but has been approved?

Question
I couldn't find this in the docs anywhere so I'm sorry if I'm asking this in the wrong place !
I've got an iOS build that I successfully uploaded and released for review with fastlane deliver.
I set automatic_release to false as I need to control when it's released after it's been reviewed.
fastlane deliver submit_build --username<EMAIL_ADDRESS>--app_identifier com.myco.myapp --submit_for_review true --automatic_release false --skip_metadata false --force true --skip_binary_upload true
The build has now been approved by Apple and is Pending developer release.  How do I now tell it to release with fastlane?
On Android I just use fastlane supply --package_name com.myco.myapp --track alpha --track_promote_to production
How do I do this for iOS?

I don't think the fastlane env will help here :)

Anyone?


120fps framerate

I need to see the 120fps framerate in the gui v3.1 file please

Please upload the example video somewhere and I can take a look.

Closing due to inactivity. Please upload the video next time and check out the new release.

Closing due to inactivity. Please upload the video next time and check out the new release.


distro: add 'polkit' to the distro features

meta-openembedded commit 97a1a55f4755 [polkit: add polkit as a
required distro feature] requires us to include 'polkit' as a distro
feature. This is due to libvirt including the 'polkit' PACKAGECONFIG
as a result of the 'x11' distro feature that we already have set.
Fixes:
[21:33:32-0800] ERROR: Nothing PROVIDES 'polkit' (but meta-virtualization/recipes-extended/libvirt/libvirt_4.9.0.bb DEPENDS on or otherwise requires it)
[21:33:32-0800] polkit was skipped: missing required distro feature 'polkit' (not in DISTRO_FEATURES)
[21:33:32-0800] NOTE: Runtime target 'libvirt-python' is unbuildable, removing...
[21:33:32-0800] Missing or unbuildable dependency chain was: ['libvirt-python', 'polkit']
Signed-off-by: Mark Asselstine<EMAIL_ADDRESS>

merged


How to 'disable' the website? Meaning, generating a landing/under-construction/under-maintenance page?

I am using Hugo site generator for my site.
Problem
Sometimes you are in the need of disabling a website; in this case, Hugo should generate a different index.html and do not generate any other page. The content of public/ should only be the landing page and its dependencies.

Can this be achieved in the Hugo environment?
Is this scenario even included in Hugo?

Scenarios
Some, but mainly when the site undergoes maintenance and we want to display just a bare landing page with some basic info, alerting the visitor that the site is temporarily down.

Please use https://discourse.gohugo.io/ for questions/troubleshooting. Also see  Hugo Documentation.


Histology data

@anhtuduong I just create histology data folder in my repository. There are histology data of the first 300 cases.
I also extract useful informationtumor_histologic_subtype to a text file name:tumor_subtype
Please check !
https://github.com/thuhoainguyen/kits23/tree/main/histology_data

@thuhoainguyen I just extract the information about this histology data, and make a graph that you may need for your thesis:

The graph shows that there are 14 different tumor_histologic_subtype and how many case in the dataset labeled with that.
This is just for your reference. I'm making a big change and refactoring the whole code. Please standby, and of course goodluck with your final exam 😸


Component composition

Is there a way to do component composition, defining smaller components to be used within larger components?
For example, is it currently possible to refactor the To-do app into a structure of components like this, each with its own rendering logic and events handling:

TodoApp

TodoList

TodoItem

TodoForm

No there's not (by design). You can use nested functions that return HTML strings to provide a bit more structure to your code if you'd like, but this library is deliberately different from how something like Vue or React might handle UI.

This answer might be valuable in this case.


Improve docs/Contribute.md

One of the ways we can make new contributors feel more welcome and onboard more quickly is by creating a friendly, comprehensive contribution guide. We have a basic start at docs/Contribute.md but it could be improved significantly.
A few thoughts about what to add:

"Tour" of the repositories (this one, plus -data and -deploy)
Link to our contact information (probably just linking to our README, but this could be improved too by adding a link to our calendar and maybe other places?)

Hello @pleia2 ,
I would like to contribute to this issue. I came across this repository while searching for a LFX mentorship program, and I'm delighted to inform you that I have applied for the same.I'm eager to contribute to the project in any way I can.
Could you please provide me with a list of sections to add in the CONTRIBUTING.md file?
Thank You!

Thanks for your interest, @deadaf!
The "tour" I referenced above was explaining that there are 3 repositories for the Software Discovery Tool.

https://github.com/openmainframeproject/software-discovery-tool
https://github.com/openmainframeproject/software-discovery-tool-data
https://github.com/openmainframeproject/software-discovery-tool-deploy

For the first two you can use a version of the README for the documentation to explain what each repository does. For -deploy you can borrow some language from this gist https://gist.github.com/rachejazz/de39c09612788635d5d0f491dcf8571a
The idea with this "tour" is we first want to get developers familiar with the structure of the project so they understand that there are 3 repositories, and that they each serve a specific purpose.
The next is explaining that these projects are part of the Linux Foundation Open Mainframe Project and so abide by the Contribution Guidelines set forth at https://tac.openmainframeproject.org/process/contribution_guidelines.html and also mention that contributions are always reviewed by another member of the project.
In the conclusion of this document, you can link back to the README for how to collaborate with the rest of the team.
Additionally, this is where having fresh eyes to the project will really help out. When you learned about this project, what did YOU want to know about contributing? If you have any questions, I'm happy to answer them so we can either incorporate them into this document (if applicable) or other documentation in the project.

Thanks for the clarification @pleia2 ,
This issue clearly makes sense as when I first visited this project, it wasn't really clear to me what's going on and where should I even begin, the major reason for all this acc to me is the incomplete README which clearly requires a rewrite.
The README explains the project in just one line and mentions terms like zArchitecture/s390x and  Z operating system and doesn't really explain what they are, making it confusing for developers who are new to the project.
Generally we find a CONTRIBUTING.md file in root dir of repositories which makes a lot of sense because it makes understanding contributing guidelines very easy for new developers, but in this case the file is actually inside the docs dir and that too isn't mentioned anywhere in the README.
I suggest the following changes:

In README

Improving the Overview section by adding more information about the project itself.
Add a section about contributing that links to the docs/Contribute.md.

In docs/Contribute.md

Add the "tour" section as you suggested.
Moving the existing info under a separate section maybe Getting Started.
Mentioning the openmainframe contributing guidelines as you suggested.
Add a new section "Code Standards" suggesting code standards (maybe mentioning PEP 8 style guide), a state of the art linter maybe, flake8 and a formatter like black.

Please let me know if I am on the right track and the changes I suggested aligns with your expectations. If so I will be more than happy to work on the issue and open a PR.
Thank You!

This all sounds great! The only thing I'd hold off on is the part about Code Standards since the details of what approach we want to follow are still being discussed in #117.

Thanks @pleia2, I will soon make a PR with the discussed changes.


Update budget using OS events or non-polling based.

Replaces use of QueryVideoMemoryInfo with RegisterVideoMemoryBudgetChangeNotificationEvent.

Fixed.


Leave blank to use the default Category label function is not working

On Applications forms when you add a category the label field in the form states that "Leave blank to use the default Category label". This does not work.
If you in the Application form set labels they are rendered as they should. But if left blank the default labels do to show up.

I tried replicating the issue. However it seems this is now working as expected. The name of the category is displayed if the label field for the category block is kept blank. This issue can be closed.

Yes, this works now. Closing.


Gemini Crash on Materialized Views Validation

When running gemini with features=normal, this activates checking of materialized-views and indexes. There is an issue when validating materialized-views rows against oracle (that's a bug), but the gemini crashes when it tries to print the resulting CQL query with a missing field access.
....

 {"L":"INFO","T":"2024-08-27T12:08:11.574Z","N":"work cycle.validation_job","M":"starting validation loop"}
{"L":"INFO","T":"2024-08-27T12:08:12.353Z","N":"work cycle.validation_job","M":"Validation failed. Error: unable to load check data from the oracle store: gocql: expected 4 values send got 5"}
{"L":"INFO","T":"2024-08-27T12:08:12.354Z","N":"work cycle.validation_job","M":"ending validation loop"}
panic: runtime error: index out of range [5] with length 5

goroutine 257576 [running]:
github.com/scylladb/gemini/pkg/typedef.prettyCQL({0xc022c02660, 0x57}, {0xc00b8c14a0, 0x5, 0xcdbb71?}, {0xc023acf040, 0x5, 0x0?})
	/home/runner/work/gemini/gemini/pkg/typedef/typedef.go:214 +0x4c5
github.com/scylladb/gemini/pkg/typedef.(*Stmt).PrettyCQL(0xc011ab38c0)
	/home/runner/work/gemini/gemini/pkg/typedef/typedef.go:97 +0x9e
github.com/scylladb/gemini/pkg/jobs.validationJob({0xe03d60, 0xc0227291d0}, 0xc000450000, _, {0xc000070088, 0xc000070098, {0x1305460, 0x0, 0x0}, 0x1, ...}, ...)
	/home/runner/work/gemini/gemini/pkg/jobs/jobs.go:246 +0x385
github.com/scylladb/gemini/pkg/jobs.List.Run.func2()
	/home/runner/work/gemini/gemini/pkg/jobs/jobs.go:136 +0x10f
golang.org/x/sync/errgroup.(*Group).Go.func1()
	/home/runner/go/pkg/mod/golang.org/x/sync@v0.8.0/errgroup/errgroup.go:78 +0x50
created by golang.org/x/sync/errgroup.(*Group).Go in goroutine 1
	/home/runner/go/pkg/mod/golang.org/x/sync@v0.8.0/errgroup/errgroup.go:75 +0x96

This is currently reproduced in https://github.com/CodeLieutenant/gemini/actions/runs/10577735511/job/29306371031
The current suggestion (as discussed with @fruch) is to disable materialized-views with a CLI flag and make gemini usable (done in #424), but this should be tackled differently (probably rewrite of the materialized views code in gemini)

Continues with #431, Duplicatee


Introduce a document describing Param and credential wiring

WIP document showing how to use parameter, credentials and outputs in bundles. Also covers how to wire things up.

The preview is available here: https://deploy-preview-168--porter.netlify.com/wiring/


ssl error

on windows xp error:

Support requests do not belong on GitHub, please open a support ticket or idea on https://imagesweserv.uservoice.com/forums/144259-images-weserv-nl-general
About SNI-errors, please see: https://imagesweserv.uservoice.com/forums/144259-images-weserv-nl-general/suggestions/6834713-moving-to-server-name-indication-ssl-certificates
You're using a browser that's 10-15 years old. We do not support browsers that don't support SNI. Please update your browser, or use another one.


[ES6 class]  Update UserStore to es6 class

ℹ   This branch depends on features that will be introduced with #275, thus it will fail until the respective branch is merged.

Update store to es6 class – this is part of series of PRs to update all the stores as discussed in https://github.com/dcos/dcos-ui/pull/246/files/b4b52fcdb5f899fd74f9bd68cfa3d216177fcecf#r64962494

Reviewer: @aldipower

Good job! 🚢