Implement conversion from PartialMerkleTree to TieredSmt

There are a few things I don't like about the current implementation. This PR serves to get the conversation going about the best way to implement the PMT -> TSMT conversion.
Problem statement
It is not possible to convert a PartialMerkleTree into a TieredSmt because the PMT stores only values (accessed by NodeIndex), whereas the TieredSmt associates a key to every value. Therefore, to convert PMT -> TSMT, we must provide the key associated with each value in the PMT.
Current solution
The current solution uses TryFrom<(PMT, BTreeMap)> for TieredSmt, where the BTreeMap provides the "value -> key" information.
I also used an iterator-based approach (with a helper from itertools), as it is the most efficient approach; for all other solutions I tried, I was forced to create one or more Vec<> along the way, or traverse pmt.leaves() twice. However, the downside is that the expression in the try_from() is a little difficult to parse.
Finally, it is not clear from the type BTreeMap<Digest, Digest> what it is supposed to do. The problem I faced was that Word (the actual type for values in the tree) doesn't implement Ord, and so cannot be used as the key to a BTreeMap. The workaround is to store values as Digest, and convert them back to Word at some point in the process. I think we need a better solution for that.

This is for the block producer in miden-node, right? If so, I think there is an alternative approach which may not require this change. The core idea is to perform TSMT update inside Miden VM and in this case, we won't need to construct the TSMT object explicitly.
Performing TSMT update within the VM would require the following:

We need to load the Merkle store in the advice provider of the VM with the partial Merkle tree containing the relevant Merkle paths. For this, we should be able to use extend() method of MerkleStore and pass inner nodes of PartialMerkleTree into it (we can get these via PartialMerkleTree::inner_nodes() method).
We need to load the advice map in the advice provider of the VM with the set of key-value pairs for each of the relevant leaves of the TSMT. For this, we need to have a mapping of the form leaf |-> (key, value), where leaf is the node value of a leaf in the partial Merkle tree, and (key, value) is the key value pair stored at that leaf (e.g., (account_id, account_hash) for the account TMST.
We need to execute a program which uses std::collections::smt::insert (for nullifiers) and std::collections::smt64::set (for accounts) to update their corresponding TSMTs.

Closing, as no longer necessary


Honor chef_server_url for sandbox uploads

Description
Chef uploads cookbooks transactionally by generating a unique sandbox
URL to upload all the associated files to using a "POST
/organizations//sandboxes" operation.
This POST operation returns the URL of the sandbox that should then be
used to PUT the cookbook's files to. This URL is pre-resolved, based on
the configuration of the chef server, which can be different from what
is configured in the client.
In special cases of network configuration, this discrepancy forces the
client to use a URL with a non-resolvable or unreachable host for
uploading cookbooks, rather than the scheme/host/port configured with
chef_server_url.
This change parses the sandbox URL returned by the server "POST
/organizations//sandboxes" operation, and rewrites
it honor the chef_server_url configuration for subsequent cookbook PUT operations.
Issues Resolved

Does not resolve, but is semi-related to https://github.com/chef/chef-server/issues/50

Check List

[ ] New functionality includes tests
[ ] All tests pass
[x] RELEASE_NOTES.md has been updated if required (not required for bugfixes, required for API changes)
[x] All commits have been signed-off for the Developer Certificate of Origin. See https://github.com/chef/chef/blob/master/CONTRIBUTING.md#developer-certification-of-origin-dco

Ah. I understand the use case with the cookbook storage back-end; thank you for pointing that out.
Would a pull request for a new setting be acceptable? It could be something like "cookbook_upload_proxy", that we could configure in our client.rb/knife.rb to allow us to over-ride the host/port of the sandbox URLs provided from the server. This would also ensure continuing compatibility for the various storage back-ends by default.
I agree that this problem is ultimately a deficiency in the server code, however, the server can't (and probably shouldn't) know about every potential client configuration used to connect to it.  A cookbook proxy setting on the client side could also be used to create compatibility with various chef server configurations, as the API itself would have to change in order to fix chef/chef-server#50.


Fix the GetKerningPairAdjustments API.

Description of Change
The SkTypeface::getKerningPairAdjustments API states:

If count is non-zero, then the glyphs parameter must point to at least [count] valid glyph IDs, and the adjustments parameter must be sized to at least [count - 1] entries. If the method returns true, then [count-1] entries in the adjustments array will be set. If the method returns false, then no kerning should be applied, and the adjustments array will be in an undefined state (possibly some values may have been written, but none of them should be interpreted as valid values).

However, SkTypeface.GetKerningPairAdjustments returns count entries and further in the case where getKerningPairAdjustments returns false it may return invalid values to the caller. This PR:

Adds a Span-based overload of GetKerningPairAdjustments that:

correctly expects glyphs.Length - 1 output entries (but will accept and ignore more),
returns true if SkTypeface::getKerningPairAdjustments wrote valid data into the output span,
otherwise clears the output span to zero so that even if invalid data was written, the caller won't see it and will get sensible results even when ignoring the return value.

Rewrites the original GetKerningPairAdjustments in terms of the new overload.

For backwards compatibility, an extra zero element is returned at the end of the array.
However, partial/invalid results will no longer be returned (the caller will receive zeroes instead).

Some typefaces are known to never support kerning. Calling this method with all zeros (e.g. getKerningPairAdustments(NULL, 0, NULL)) returns a boolean indicating if the typeface might support kerning. If it returns false, then it will always return false (no kerning) for all possible glyph runs. If it returns true, then it may return true for somne glyph runs.

This patch adds a HasGetKerningPairAdjustments that callers can use to query whether the font contains any kerning information or whether GetKerningPairAdjustments will always return zeroes.
API Changes
Added:

public bool SkTypeface.HasGetKerningPairAdjustments { get; }
public bool GetKerningPairAdjustments (ReadOnlySpan<ushort> glyphs, Span<int> adjustments)

Behavioral Changes
public int[] GetKerningPairAdjustments (ReadOnlySpan<ushort> glyphs) will now return zeroes in places where it previously returned partial/invalid data that the Skia documentation says to ignore.
PR Checklist

[ ] Has tests (if omitted, state reason in description)
[x] Rebased on top of main at time of PR
[x] Merged related skia PRs
[x] Changes adhere to coding standard
[x] Updated documentation

Apologies if this isn't quite up to the project standards. I was initially going to just submit a bug report, but then I thought it might be nicer (and likelier to actually get fixed) if I made a quick PR instead of just complaining. I fully acknowledge that I'm not invested enough in this project to learn all of the conventions properly, and I apologize if this wastes anyone's time cleaning up what I've misunderstood. Y'all can do with this patch whatever you will.
I just think it'd be nice if I could be rid of this abomination:
private unsafe delegate bool SkApi_GetKerningPairAdjustments(IntPtr typeface, UInt16* glyphs, Int32 count, Int32* adjustments);
private static SkApi_GetKerningPairAdjustments s_GetKerningPairAdjustments;

private static SkApi_GetKerningPairAdjustments GetKerningPairAdjustmentsFunc()
{
    if (s_GetKerningPairAdjustments == null)
    {
        var apiBindingsType = typeof(SKTypeface).Assembly.GetType("SkiaSharp.SkiaApi");
        var apiFunc = apiBindingsType.GetMethod("sk_typeface_get_kerning_pair_adjustments", System.Reflection.BindingFlags.Static | System.Reflection.BindingFlags.NonPublic);
        s_GetKerningPairAdjustments = apiFunc.CreateDelegate<SkApi_GetKerningPairAdjustments>();
    }

    return s_GetKerningPairAdjustments;
}

private static unsafe bool HasKerningPairAdjustments(SKTypeface typeface)
{
    var func = GetKerningPairAdjustmentsFunc();
    return func(typeface.Handle, null, 0, null);
}

private static unsafe void GetKerningPairAdjustments(SKTypeface typeface, ReadOnlySpan<ushort> glyphs, Span<int> adjustments)
{
	Debug.Assert(glyphs.Length >= 2 && adjustments.Length == glyphs.Length - 1);

	var func = GetKerningPairAdjustmentsFunc();

	bool res;
	fixed (ushort* g = glyphs)
	fixed (int* a = adjustments)
		res = func(typeface.Handle, g, glyphs.Length, a);

	if (!res)
		adjustments.Clear();
}

@dotnet-policy-service agree

I don't understand why the tests are failing. The stuff in the logs doesn't look like stuff that I've broken, so I'm taking this PR out of draft.
Again, I made this PR since it seemed a better thing to do than just opening a ticket and hoping someone else would write code for me. But I don't have time to learn what's going on with Run the bootstrapper for tests-android and so on. Do whatever y'all want with the patch. (And sorry again if you'd have preferred a ticket to a half-baked PR.)

@pdjonov no, thanks for this PR. It looks very good.
CI is a bit temperamental and I am still trying to figure out why macos and Android keep failing the first run. Android has additional issue with the emulators not always booting and macOS has random test crashes.
But, if the other test platforms all pass then it is highly likely it is just a random failure.
Also, the test were all failing before since main had been broken for some time. But it is all fixed now.

Going to merge this as tests are hard for this scenario and we can add them later. Even skia does not have tests...


ConfigMap cannot overwrite wavefront freemium account creation

I developed a spring boot application on my local laptop with the following application.properties
wavefront.application.name=demo
wavefront.application.service=HelloRest

As a natural use case, when I move to kubernetes env, i want to use configmap to override the auto freemium config.
So i created the following config map.
kind: ConfigMap
apiVersion: v1
metadata:
  name: hellorest
  namespace: demo8
data:
  wavefront.tracing.enabled: "false"
  wavefront.freemium-account: "false"
  management.metrics.export.wavefront.enabled: "false"
  spring.sleuth.enabled: "false"

However I still see the freemium account being configured.
When enabling debug log, i see that the configmap is getting loaded properly during start up
2020-07-10 01:44:33.302 DEBUG [hellorest,,,] 1 --- [           main] o.s.c.e.PropertySourcesPropertyResolver  : Found key 'management.metrics.export.wavefront.enabled' in PropertySource 'bootstrapProperties-configmap.hellorest.demo8' with value of type String
2020-07-10 01:44:33.330 DEBUG [hellorest,,,] 1 --- [           main] o.s.c.e.PropertySourcesPropertyResolver  : Found key 'wavefront.tracing.enabled' in PropertySource 'bootstrapProperties-configmap.hellorest.demo8' with value of type String

However the i don't see any wavefront.freemium-account being loaded.
root@ubuntu18:~/wavefront-demos/demo8/kube-demo# kubectl logs helloworld-86bfb659b9-g6m52 -n demo8 | grep freemium
root@ubuntu18:~/wavefront-demos/demo8/kube-demo#

By the way, adding the above parameters directly in application properties to application.properties, i see that freemium account creation get's disabled.

@mhoshi-vm thanks for reaching out and for the report.
Account negotiation happens very early on in the application lifecycle. The environment has been prepared and the application configuration has been read. I understand from the log (though I am note sure) you're using Spring Cloud and the bootstrap context. Unfortunately, the way this is designed at the moment does not respect Spring Boot's application lifecycle and such configuration is loaded too late for the account negotiation to know.
As a workaround for that problem, you could switch to an env variables or configuring your startup script to set a system property or a command-line switch. This will be applied. Or you could enable a profile and have a application-k8s.properties in your project.
Regarding the 4 properties above, it looks like you want to disable exporting metrics altogether. If that's what you want, management.metrics.export.wavefront.enabled:false is all that you need (post-RC1 we haven't released 2.0.0 yet) as account negotiation will back off if that property is set. If such property is disabled, no configuration of Wavefront will occur and tracing won't be enabled either.
Please give this a try and let us know how it goes.

@snicoll Thank you.

As a workaround for that problem, you could switch to an env variables

Yes this worked. The follow yaml file disabled the freemium account creation
apiVersion: apps/v1
kind: Deployment
metadata:
...
spec:
  replicas: 1
...
  template:
...
    spec:
...
      containers:
...
        env:
        - name: WAVEFRONT_FREEMIUM-ACCOUNT
          value: "false"

If that's what you want, management.metrics.export.wavefront.enabled:false is all that you need

I am using 2.0.0-SNAPSHOT but that parameter alone does not prevent the freemium account creation.
I still see the following during startup with just that.
A Wavefront account has been provisioned successfully and the API token has been saved to disk.

To share this account, make sure the following is added to your configuration:

        management.metrics.export.wavefront.api-token=xxxx
        management.metrics.export.wavefront.uri=https://wavefront.surf

Connect to your Wavefront dashboard using this one-time use link:
https://wavefront.surf/us/xxxx

Thanks for the feedback and glad to hear that env works for you.

I am using 2.0.0-SNAPSHOT but that parameter alone does not prevent the freemium account creation.
I still see the following during startup with just that.

I can't reproduce the behaviour you've described. Perhaps you're using an older snapshot or something? Just to make sure that we're talking about the same thing, I've created a sample project with only that property and the account creation is disabled for me.
You can try it out as follows:
git clone https://github.com/snicoll-scratches/wavefront-disable-metrics.git
cd wavefront-disable-metrics
./mvnw spring-boot:run

@snicoll thanks for the sample code.
So here is what i see from your code.

Yes, management.metrics.export.wavefront.enabled=false stops freemium account creation if defined at application.properties.
The problem happens when combining with Spring Boot Kubernetes and overwrite with configmaps. The following will not prevent the freemium account creation. The solution that i found was to add WAVEFRONT_FREEMIUM-ACCOUNT: false to the env

kind: ConfigMap
apiVersion: v1
metadata:
  name: hellorest
  namespace: demo8
data:
  management.metrics.export.wavefront.enabled: "false"

BTW, In my scenario, I created my app on a non-k8s env, and i want to move it to kubernetes + istio, which i want to let istio handle the traces, not spring.

Thanks for the feedback. If WAVEFRONT_FREEMIUMACCOUNT works, there is no reason why MANAGEMENT_METRICS_EXPORT_WAVEFRONT_ENABLED wouldn't. I am still quite confused as what you're trying to do. If you disable the freemium account (and only that) the application won't start as metrics are not disabled and a token is mandatory.
In any case, it looks like this issue has run its course. We also have a slack channel if you want to chat with the community.


Making collision bit width configurable,

Collision buffer will cause overflow at 417 days of server uptime (not
JVM). Making it configurable, so users can choose between precision and
longer period of time without having to reboot physical node to reset
up time

@ryantenney would you consider making the buffer bit width configurable?

That's a reasonable. I'll look it over tomorrow.

Can you look into the build failure?

@ryantenney I'm not sure why this test fails, but it fails the same way without my changes. Those changes should be fully backwards compatible with the same default values, so there should be no impact to existing tests. Once you get this branch build without my changes, it should build with those changes as well. If not, I'll review and fix any issues.

Okay I'll look into what's failing in that branch.


Add function: compose HTTP request body

Codecov Report

Merging #4 into main will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##              main        #4   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files            3         5    +2
  Lines           37        66   +29
=========================================
+ Hits            37        66   +29

Impacted Files
Coverage Δ

src/core/apiCall.js
100.00% <100.00%> (ø)

src/core/apiCallToCreate.js
100.00% <100.00%> (ø)

src/core/composeHttpRequestBody.js
100.00% <100.00%> (ø)

src/core/dataValidation.js
100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 84b624a...4522900. Read the comment docs.


Deployments tag filter shows only one tag

Tag type was not correctly specified in deployment interface, the change in REST endpoint went unnoticed.


Support for Criteo

This PR also already includes the changes from #16   After that one is merged the changes should be more readable.

looks good

please remove pry-debug as this is not a runtime dependency

can this PR be merged?

please add it to the readme, then lets merge it

@jhilden ping? :)

updated the README.  i think this can be merged now.


Merry Christmas - we're now TravisCI-compliant!
@co1in Some of these changes were made to the PartyListV2 code; none of them should change the logic you've written though. Could you give this a glance-over when you have the chance to make sure I didn't break anything?


Discussion / Draft: Support trailing commas for JSON parsing

Hi,
Thanks for all the work on `yojson! I've been using it in a ton of projects - it's great 🎉
I'm using it to parse user-crafted configuration files, and in those cases, I'd like more 'resiliency' - forgiving of comments and trailing commas. A use case for this is here: https://github.com/onivim/oni2/issues/836
I know this is likely the implementation is likely incorrect - it looks like the preference for this was to fulfill the RFC 8259 spec: https://github.com/onivim/oni2/issues/836 and this change breaks some of the currently-passing RFC 8259 compliances tests, as the RFC doesn't support trailing commas.
Based on the details in #81 , it sounds like there is still some thought about where a resilient-parser like this would belong (ie, Yojson.Standard.t for RFC 8259 standards compliant parsing, and some other module - maybe Yojson.Safe.t or Yojson.Resilient.t?)
In any case, I wanted to put it up here as a draft in case there was anyone else looking for this-

We had a discussion on this and there was also a proposal to support the complete JSON5 specification, which, along with some other minor quality of life improvements, also brings support for trailing commas.

@Leonidas-from-XIV - thanks for the update! That sounds great.

Fixed by #152.


[--------------------] ERROR do-request: Dispatching on object: f

current-builder returns f if select-tuple isn't able to lookup a builder with the specified os and cpu... looks like the URL is for "openbsd-x86.64" which hasn't been valid for awhile... maybe we should handle that case better.

Also "winnt-x86-32" and "openbsd-x86-32" so at least it's easy to test.

Fixed in a9f842430291384fe8b6ce3718610261c927729a.


merge from arlac77/npm-package-template-esm-only

README.md

docs(README): update from template

Codecov Report

Merging #623 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #623   +/-   ##
=======================================
  Coverage   89.16%   89.16%
=======================================
  Files           9        9
  Lines         757      757
  Branches       64       64
=======================================
  Hits          675      675
  Misses         82       82

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5fa15db...ea45dba. Read the comment docs.

:tada: This PR is included in version 6.1.2 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Add Icon

Add Application Icon that is displayed instead of the Java default icon
On MacOS, change the application name tooltip to Bibles

I wanna take this issue

Sounds Good

On MacOS, change the application name tooltip to Bibles ? I need clarification with this issue

When the application is running, the Icon is the Java generic. If you hover the mouse pointer over the icon it will display the application name in a popup text window. Right now it will display Java, I was wanting to change the 'Java' to 'Bibles'

ok got it

bible.jpg should be in the image right?

you can check the last second dock ..

It should pop up above it when you hover the mouse over it icon

Hi I was sick . I am active now


NET Core support.

According to report generated by .NET Portability Analyzer the major issue with portability is usage of WebRequest, so it was replaced with HttpClient.
I've also added support for netstandard1.5 and netcoreapp1.0 targets (LtiLibrary.Core). .NET 4.5 and 4.6 are supported as well. Now you can use separated LtiLibrary.NetCore.sln solution to compile for multiple targets. LtiLibrary.AspNet and Tests will be updated in the future.

@xferra - This is a big pull request...I just want to double check that you think it is ready.

@xferra - The changes in LtiLibrary.Core force cascading package changes in all the other projects: add Microsoft.Bcl and Microsoft.Bcl.Build, and updates to Microsoft.Net.Http. Do these look right? Did you expect these changes?
I'll go through the samples over the next week or so to make sure they all work.

@andyfmiller As you can see Microsoft.Net.Http v2.2.29 depends on Microsoft.Bcl & Microsoft.Bcl.Build, so it was expected.
If you would like to avoid this dependency we can leave old WebRequest in place and use HttpClient only for .Net Core.

@xferra I don't think it will be a problem. I just need a few days to make sure all the samples work.

Hello @andyfmiller , do you need any help?

Hello @xferra , yes. It seems I just cannot make the time to merge this locally and test the samples. Please go ahead with the merge.

@andyfmiller yeah, it's a big problem for me as well. I will merge and prepare some samples next week.

@andyfmiller I decided to postpone the merge until I will be able to convert and run unit tests for LtiLibrary.Core project.

@andyfmiller Now LtiLibraryCore.Tests supports netcoreapp1.0 target. I'm ready to merge.

@xferra Would you like me to merge the pull request?

Hi @xferra and @andyfmiller ... when will you guys release this library for the for the ASP.net Core and update it on the Nuget?

Hey @emcyborg, Lti.Library.Core and Tests are ready for .NET Core (now it supports netstandard1.5, netcoreapp1.0, net45, net46). I will merge this PR right now, @andyfmiller, @emcyborg, @jeroenhabets please feel free to test it. Your feedback is welcome!
Today I also updated LtiLibrary.AspNet project and compiled it for netstandart and netcore, but please give me some time to test it and prepare samples. Please also note that ASP.NET Core has some major changes in API (at least middleware), so it may take some days to finish testing and converting.
Thank you all for your input and support.
PS: Nuget package should be updated by @andyfmiller (as far as he is the owner), but I suppose it will happen only when ASP part and samples will be ready. I will also try to prepare some docs to help him.

I will be very glad to update the packages in NuGet.

@andyfmiller, so I expect the updated packages on NuGet very soon?

@emcyborg ASP.NET Core is not ready (see xferra's earlier reply). But when it is ready, I will be glad to update the package in NuGet.

@emcyborg @xferra While testing the LtiSamples, I made some changes to LtiLibrary. I am collecting the changes in the NetCore branch.


feat/gs-tabs

Fixed the issue with tab indicator, all the foundation level stuff are working.

Since Gluestack.io has this feat marked as api-draft, it's subject to change. So will have to update this too accordingly.


[QUESTION] Is there a way to specify fluentd to use a private gem repository for plugins?

Is there a way to specify fluentd to use a private gem repository for plugins?

It depends on your environment.
specify source in gem command or something.
Googling gem is better.


Add static library different way?

https://stackoverflow.com/questions/14077611/how-do-i-tell-cmake-to-link-in-a-static-library-in-the-source-directory

https://youtu.be/SYgESCQeGJY?si=f77QjRBWptx0xpqn


Updating repeating tasks to include LICENSE copyright information

Fixes #298

This change is

@PlagueHO Can you review this too when you have a chance? 😃

Just some minor grammar tweaks.

Review status: all files reviewed at latest revision, all discussions resolved.

Maintainers.md, line 161 at r1 (raw file):

#### License

This is how the copyright information looks like for 2017.

This is how the copyright information looks like for 2017. -> This is how the copyright information looks for the year 2017.

Maintainers.md, line 167 at r1 (raw file):

Beginning of year 2018 (and so on) the copyright information should be updated

At the beginning of the year 2018 (and so on) the...

Comments from Reviewable

Review status: 0 of 1 files reviewed at latest revision, 2 unresolved discussions.

Maintainers.md, line 161 at r1 (raw file):
Previously, PlagueHO (Daniel Scott-Raynsford) wrote…
This is how the copyright information looks like for 2017. -> This is how the copyright information looks for the year 2017.

Done.

Maintainers.md, line 167 at r1 (raw file):
Previously, PlagueHO (Daniel Scott-Raynsford) wrote…
At the beginning of the year 2018 (and so on) the...

Done.

Comments from Reviewable

When you write the correct text it looks so obvious. Aren't there any proof reading BOT I could use? 🤔 😃 Machine learning and all that 😉


Protect ingester against very large queries.

This is Conference Driven Development from #PromCon2018 :)
We had an outage where a very large query took out the ingesters.  Quick patch protecting it.

Already discussed on Slack, but it seems 100,000 is too low for our typical queries.


Add tests

closes : https://github.com/zakodium-oss/dom-to-html/issues/2
closes : https://github.com/zakodium-oss/dom-to-html/issues/3

We added a failing testcase that 'matchSnapshot' and once the snapshot contains the base64 encode images (for the jpg and the svg converted to png) it is ok. (actually it pass but the snapshot is wrong).
For your other testcases you can also 'matchSnapshot'.

To make the snapshots work on GitHub CI, we need to do them with Linux. There is documentation here about how to do it using Docker: https://playwright.dev/docs/test-snapshots

@lpatiny i used toHaveScreenshot which ido the same work as toMatchSnapshot (if you perfer using toMatchSnapshot  i can change it)
await expect(result).toHaveScreenshot( './src/__tests__/snapshots/canvas.png');
<=>
expect(await  result.screenshot()).toMatchSnapshot({name:'./src/__tests__/snapshots/canvas.png'});

The goal is that you can copy paste the HTML to word and google docs and than all the images appear.
This means:

inline SVG
canvas
<img src png
<img src jpg
<img src svg

Could you test the current status of the project with those 5 cases and copy / paste to google docs ?

If you can share the google docs (read only mode) I would be convinced ;)

If you can share the google docs (read only mode) I would be convinced ;)

i created this doc that contain test and the html result to test
https://docs.google.com/document/d/1TplZt64fC5kMalhnNTjTY8xsNjK3OuFkAEu3fhkXrpM/edit?usp=sharing

https://docs.google.com/document/d/1TplZt64fC5kMalhnNTjTY8xsNjK3OuFkAEu3fhkXrpM/edit?usp=sharing
@lpatiny the doc is updates with the clipboard please check it

Do you know why they are failing?

i fixed imgs dimensions bug
the only problem left is convert svg image in firefox that i'm tryin to solve it
i found a solution which is convert it into image/svg+xml base64 data, but it doesn't work when copy it in a doc using html clipboard

Do you know why they are failing?

i fixed imgs dimensions bug the only problem left is convert svg image in firefox that i'm tryin to solve it
i found a solution which is convert it into image/svg+xml base64 data, but it doesn't work when copy it in a doc using html clipboard so i converted it into image/png base64 data


consolidate advanced chunker notebook

Main improvements with this PR:

Set chunk.text directly to updated text (including any headings, captions)
Add typing
switch to list comprehensions where possible
encapsulate all methods within new chunker implementation
use dataclass instead of unmanaged dictionary
list dependencies in setup installation line

Changes directly merged to https://github.com/DS4SD/docling/tree/advanced-chunking-example as part of https://github.com/DS4SD/docling/commit/ce38baf7f7e477c06ec315167a900e5fe07c991a.


Amount of bytes written/read for rpc

see: https://github.com/NethermindEth/juno/pull/1520#discussion_r1425952980

Cloud providers, most out the time, provide traffic metrics anyways. I am not sure how useful this is.

Those metrics aren't detailed enough when there are multiple services on 1 server and when each service can work on multiple layers (p2p, rpc, etc.)


[ALLUXIO-1823] Support for running on Google Compute Engine

https://alluxio.atlassian.net/browse/ALLUXIO-1823

Can one of the admins verify this patch?

@ericmand thank you very much for adding GCE support into the deploy module ... I left a bunch of small comments

Thank you @ericmand for adding the GCE support, I also left some comments.
I'll try out Running-Alluxio-on-GCE shortly, and will let you know if I got any questions.

@ericmand  Awesome, with this PR, I managed to setup a Alluxio cluster on GCE. Great job!
A few additional question:

Regarding the instances name, I left the "Name:" section in gce.yml to be empty. So the instances names are default  i-2016032216-*, which makes it hard to tell which one is Alluxio Master. Is it possible to make the default instance name as the Vagrant instance name, i.e. AlluxioMaster AlluxioWorker1, etc ?

The Alluxio cluster is running in GCE, however, I failed to access the Alluxio Web UI at http://{MASTER_IP}:19999 on my browser. Is there any additional firewall configuration to set? similar as AWS Security Groups?

Regarding naming, let me poke around and see what we can do there.
Regarding the web UI. Yes, I didn't add instructions for that. Will do that soon.

I think I've addressed everything. Let me know if you have anymore questions!

@ericmand , thank you very much for the improvement!
Overall looks good to me! Left a few additional comments, mostly nits.

LGTM

LGTM. Thanks for this important integration, @ericmand. Looking forward to the integration with GCS.


Fix failed importing of MLDHT

Couldn't import MLDHT for use as dependency because of case-sensitivity
renamed in multiple locations:

MlDHT —> MLDHT
(lowercase —> uppercase 'L')

Hey,
could you give me an example how you use mldht as a dependency? I tried it with {:mldht, "~> 0.0.1"} and  {:mldht, github: "cit/MLDHT"} and both work for me.
Thanks!

Sorry for the phrasing - it can be imported, but module names are case sensitive, and the error message is not very explicit, so the function call MLDHT.start(…) will throw this error
** (UndefinedFunctionError) function MLDHT.start/2 is undefined (module MLDHT is not available)

17:25:21.197 [error] Loading of /Users/lewis.knoxstreader/GitHub/peer-monitor/peer_monitor/_build/dev/lib/mldht/ebin/Elixir.MLDHT.beam failed: :badfile

17:25:21.197 [error] beam/beam_load.c(1412): Error loading module 'Elixir.MLDHT':
  module name in object code is Elixir.MlDHT

MlDHT.start(…) will work
MLDHT.start(…) will not
Because the repo title is all caps and the difference is visually very hard to make out, I thought changing the module name for consistency would help prevent these kind of mix-ups.
The repo title could be changed instead, changing the module case was just my preference.

Thanks for your comment. Your are right, it would be better to be more consistent here. To follow the naming convention from Elixir and not to break any working code, I would rather prefer to rename the repository instead of changing the module name. Thanks for bringing this problem to my attention.


[AutoRelease] t2-containerregistry-2023-02-03-15534(can only be merged by SDK owner)

https://github.com/Azure/sdk-release-request/issues/3745
Live test success
https://dev.azure.com/azure-sdk/internal/_build?definitionId=981
BuildTargetingString
azure-mgmt-containerregistry
Skip.CreateApiReview
true

issue link:https://github.com/Azure/sdk-release-request/issues/3745


Add getting started section to README

##README Update
Please add a getting started section to the README

Getting started section added!


[NetCore] Enable support for messages/warnings related to Deployment Items for languages other than English

Will be tracked as part of the CPS move.


test(ReporterOrchestrator): Make test less strict

Test would break when adding the html reporter. Use global state for now, instead of mocking the dependency away.

Could you fix the build?

The build is failing based on the lodash types. This can be ignored as it's solved in the master branch.


Can the script be loaded using the async attribute?

The README.md file contains this sample code:
<!DOCTYPE html>

I would like to know if this script will still function as expected if I add an async attribute to it, like this:

This allows the browser to continue rendering the rest of the document even before downloading and executing the script, and it's a recommended practise for web performance.

Yes, async scripts are supported. But beware it may lead to noticeable "pop-in" as the icons will appear significantly after other content on the page, causing layout shifts.


Refactor yacfg Codebase and Update Project Dependencies

Description
This pull request encompasses a wide range of refactoring updates for various yacfg modules aimed at improving code readability, maintainability, performance, and type safety. Updates include the addition of type annotations to function parameters and return types, simplification of code logic, reorganization of import statements, and improved exception handling.
Here is an overview of the changes made:

Dependencies in pyproject.toml have been updated, and the script entry for yacfg has been modified.
Various modules such as yacfg_cli, yacfg_batch_cli, cli_arguments, yacfg_batch, output, query, profiles, output, exceptions have been significantly refactored for improved readability, maintainability, and performance.
Improved handling of file paths, output files, and profile in files.py, output.py, profiles.py modules respectively.
Changes to the metadata and descriptions for the yacfg and yacfg-batch packages.
The README.md file and documentation have been updated with accurate information.
The poetry config file has been updated and the version has been bumped to 0.10.0.
poetry.lock file updated to ensure compatibility and stability of the project dependencies.

Each commit message has further details of the changes made.

cant say i understood it all, but i did look at it and it seems legit

Thanks for checking out the stuff, If there's something you didn't understand or if you have any questions, just let me know. I'm happy to explain things better or give you more info. I've been refactoring and refactoring... It would deserve even more sincere attention, but we don't have the time to completely rewrite it from scratch.

but we don't have the time to completely rewrite it from scratch.

Somebody (@gtully, et al) will rewrite this in Java anyways, to configure broker from properties, without init image that carres python...
Ideally, being able to configure fully a standalone instance (or cluster) conveniently, with single config file, and have the tool understand the schema defined in Java code would be nice... not sure if there's something to build it upon, though. I do not want to have to have the top level template in XML ;(
Maybe there would be some desire for ansible for this? I know that skupper resolved the Python 3.9 vulnerability on RHEL 8 by upgrading the image to RHEL 9, where Python 3.9 is patched (which IMO would've been sensible for broker too, but 3.8 there, that's already done deal). And skupper will have or has some ansible in upstream repo. So, that actually means it's back to jinja and python, because ansible ;P


The compiler consumes a lot of memory

Compiling the standard library test suite on latest master with the compiler built in release mode takes approximately 4 GB of memory. That means we currently have a really low upper bound for the size of a compiled program, and we should try to reduce that memory consumption.
Most of that memory is allocated by the lookup and reify functions during reachability analysis and code generation, as these functions often duplicate the ASTs they work on. Here are some ideas to try out:

Lookup/reify only one function at a time
Avoid duplicating during lookup. This will need some careful AST management to ensure we don't modify a shared AST
Reify type parameters "ad hoc". Instead of reifying entire functions (and thus duplicating them), we could do reachability/code generation on the original AST and reify type parameters when we encounter them. This will complexify both the reachability analysis and the code generation as they'll have to handle non-reified ASTs

Number 1 shouldn't be too hard but I expect that it will have some bad results on compilation times. I think the optimal solution would be a combination of number 2 and number 3. It should reduce both memory usage and compilation times.

@Praetonus - I'm not finding any calls to ast_dup in lookup.c.  Can you point me toward them?
Also, I'm going to mark this for discussion during today's sync.

@jemc It's in the call to viewpoint_replacethis in lookup.c l.161. That function calls viewpoint_replace, which duplicates the AST.

Some ideas discussed on the sync call:

Implementing the AST trees as persistent/immutable, reference-counted, copy-on-write trees, so that ast_dup would not cause an allocation unless/until the new "copy" needed to be mutated (at which point it would actually be copied.
We could cut memory usage roughly in half by figuring out how to trim down the members of the ast_t struct.  Adding annotations in #1485 added a new field that pushed us over the boundary, causing the allocated size of each node to effectively double.  If we could find a different way to store the annotations, or some other field, it would make a drastic improvement.

I'm doing some work on #666 - I'd be interested to see how it affects your memory benchmarking after I come up with an improvement.

See #1560 - @Praetonus how were you measuring memory for this investigation?  I'd imagine that #1560 helps a bit, but not sure by how much without testing.

Last night I was experimenting with an implementation for option 2.
Basically, my idea is to store the annotation as the sibling of the type, so we can eliminate the extra annotation pointer added in #1485 and hopefully cut memory usage in half.

I've assigned myself to this ticket because I'm working on that angle, but if anyone wanted to work on one of the other approaches for reducing memory (the more the better!), then we can assign you at the same time (more than one person can be assigned to an issue).

Between @jemc's work on reducing the size of ast_t and my recent work on deferred reification, this is now fixed. To get some idea of the improvement, compiling the standard library test suite now uses approximately 900 MB of memory instead of 4 GB previously.


Any way to keep a minimal Install floating button after dismiss?

Hello, and thank you for this great fork!
At first, I thought permanentlyHideOnDismiss would leave some kind of small floating header/button that would allow the user to see the instructions again, but I don't think that's the case.
Is there any possibility this package could provide that feature?
Thank you

Do you have a UI mock up of what you have in mind (any form will do)? I'll definitely consider something if its non-obtrusive and the layout would work for most applications.
If its not a generic solution that will work by default in most sites, my opinion is a re-prompt label is the duty of the calling application.
Some context:
permanentlyHideOnDismiss when set to false in this context will still dismiss the prompt until the user refreshes the page, but the prompt will reappear once the user has refreshed.
A potential alternative solution:
I do export the local storage key used, the types used to store the object, as well as all components used.
You can manually reset the values stored in local storage to re-prompt.
Meaning your application could re-prompt using a button, or some other piece of your UI.
Or use the exported components to compose your own prompt with an additional floating label that can manipulate the local storage values.

Looks like I'll need to make some adjustments to make a solution like what's mentioned above work.
Let me see if I can't get a branch going as I wait for your UI mock

@mcosti with version 1.1.0 coming from the PR above you should now be able to accomplish what you need in terms of making your own floating button to re-show the prompt to the user.
You can do this by using the isOpen prop on the component to control re-prompting yourself in your application, as well as using useShouldShowPrompt or usePromptStorage if you need more fine grained control or insight into the values the prompt is using.
See the updated storybook demo for a very basic example of this feature in action, and feel free to let me know if this doesn't give you all that you need 😎
I went this route as not all applications will agree on where/how the re-prompt button/icon should be implemented, so decided to make it the responsibility of the calling code how it the display and logic of a re-prompt.
I may also add a boolean representing if the user has manually dismissed the prompt in the near future for ease of use.

Hi, @thenick775. That is absolutely amazing.
I feel a bit guilty though, as meanwhile I've managed to release native apps for both iOS and Android, so I cannot make use of this package anymore. (Also, iOS removed PWA support in the 17.4)

For anyone following this issue, and/or worried about PWAs, I'm hopeful that this will remain true:
Apple says iOS 17.4 won’t remove Home Screen web apps in the EU after all


Bugfix of multiple calls

Coverage increased (+0.2%) to 40.506% when pulling b1f2307d929eaa6e44797a72959a56e9c15d53b1 on embbnux:bugfix/multi-calls into 6f82ceccc84fc0541b116419bb774983bb3d844f on ringcentral:master.

Coverage increased (+0.2%) to 40.506% when pulling b1f2307d929eaa6e44797a72959a56e9c15d53b1 on embbnux:bugfix/multi-calls into 6f82ceccc84fc0541b116419bb774983bb3d844f on ringcentral:master.


Unable to use .IN and .NOT_IN with dynamic values

Describe the bug

.IN(...) and .NOT_IN(...) can not be used in conjuction with a slice of values (Int, Float, String, etc).
The Expression type as well as Int, Float, String, etc. are living within the internal package, thus creating a slice of e.g. jet.IntegerExpression is not possible.

Environment (please complete the following information):

OS: macosx
Database: sqlite
Database driver: github.com/mattn/go-sqlite3
Jet version: 2.8.0

Code snippet
import (
	. "myapp/table"

	"github.com/go-jet/jet/v2/internal/jet" // for jet.IntegerExpression, fails to compile
	. "github.com/go-jet/jet/v2/sqlite"
)

func demo() {
	var userIDs = []int64{1, 2, 3} // could be user provided
	var sqlIDs []jet.IntegerExpression

	for _, userID := range userIDs {
		sqlIDs = append(sqlIDs, Int(userID))
	}

	SELECT(Users.AllColumns).FROM(Users).WHERE(Users.UserID.IN(sqlIDs...))
}

Compilation error
use of internal package github.com/go-jet/jet/v2/internal/jet not allowed

Expected behavior
Defining a slice of jet.IntegerExpression should not result in a compilation error.

Hi @philippta . All the internal types of interest are exported through dialect package(for instance). There is no need to use internal package. In this case you should only import github.com/go-jet/jet/v2/sqlite.
IN/NOT_IN method does not accepts list of IntegerExpression, but list of Expression objects. This is a bug, but it can't be fixed before V3, because it is a part of the public API.
import (
	. "myapp/table"

	. "github.com/go-jet/jet/v2/sqlite"  // !!! Always import only the dialect package !!!
)

func demo() {
	var userIDs = []int64{1, 2, 3}         // could be user provided
	var sqlIDs []Expression                // !!! sqlite.Expression list !!!

	for _, userID := range userIDs {
		sqlIDs = append(sqlIDs, Int(userID))
	}

	SELECT(Users.AllColumns).FROM(Users).WHERE(Users.UserID.IN(sqlIDs...))
}

Thanks for clarification. This definitely helps solving my problem. Maybe it‘s worth adding this example to the wiki.
Issue can be closed then.

wiki


fix a typo in i6_rgn.h

The enumeration type i6_common_pixfmt should be i6_rgn_pixfmt in i6_rgn_cnf

Well spotted! Thank you very much!


Password Protected Files

If I got a file which is password protected, how do I parse it for metadata and content?
Given the fact that I have a password of the file.

Check out some of the results here, in particular what system properties you would need to set. In Tika-Python you would set those before tika-python is called and your Java server is started so it picks them up.
https://www.google.com/search?q=tika+encrypted+pdf&oq=tika+encrypted+pdf&aqs=chrome..69i57j69i60j69i64.2199j0j4&sourceid=chrome&ie=UTF-8


Fixed IllegalFlagValueError in NSynth_generate.py

Fixed "IllegalFlagValueError: flag value must be string" caused by line 28 in nsynth_generate.py because of TF Flags expecting string but getting Boolean. Instead set the TF Flag type to boolean

I signed it!

Hey I just updated the branch to reflect the latest commits in master. Kind of forgot that I had this pull request open haha. Do I need to do something or will you merge it now?


Duplicate dependency export

[x] I am on the latest Poetry version.
[x] I have searched the issues of this repo and believe that this is not a duplicate.
[x] If an exception occurs when executing a command, I executed it again in debug mode (-vvv option).

OS version and name: elementary OS 5.0 Juno
Poetry version:1.0.3
Link of a Gist with the contents of your pyproject.toml file:

pyproject.toml
[tool.poetry]
name = "tmpoetry"
version = "0.1.0"
description = "sdfg"
authors = ["Author<EMAIL_ADDRESS>
[tool.poetry.dependencies]
python = "^3.6"
mypy = "^0.701"
pylint = "^2.3"

Issue

When a (sub)dependency has different requirements for different python versions, it appears twice in poetry.lock. In itself this is no problem, but poetry export generates duplicate entries.

In this use case, the command poetry add fails because said library has "conflifting"  versions.
(try poetry add astroid)

Today, locking and exporting the given pyproject.toml does not give any duplicates in the output.
So I suppose this is fixed:
astroid==2.3.0 ; python_version >= "3.6" and python_version < "4.0"
colorama==0.4.4 ; python_version >= "3.6" and python_version < "4.0" and sys_platform == "win32"
isort==4.3.21 ; python_version >= "3.6" and python_version < "4.0"
lazy-object-proxy==1.7.1 ; python_version >= "3.6" and python_version < "4.0"
mccabe==0.6.1 ; python_version >= "3.6" and python_version < "4.0"
mypy-extensions==0.4.3 ; python_version >= "3.6" and python_version < "4.0"
mypy==0.701 ; python_version >= "3.6" and python_version < "4.0"
pylint==2.4.4 ; python_version >= "3.6" and python_version < "4.0"
six==1.16.0 ; python_version >= "3.6" and python_version < "4.0"
typed-ast==1.3.5 ; python_version >= "3.6" and python_version < "4.0" or implementation_name == "cpython" and python_version >= "3.7" and python_version < "3.8"
wrapt==1.14.1 ; python_version >= "3.6" and python_version < "4.0"

I don't think it's fixed: https://stackoverflow.com/q/69810820/562769

That stack overflow question has nothing to do with export, and this still is fixed

I am also observing this behaviour. I am using poetry version 1.8.3. Prefect is installed on my system via pipx. I am working on WSL with Ubuntu 22.04.
See my pyproject.toml file below:
[build-system]
requires = [ "poetry-core",]
build-backend = "poetry.core.masonry.api"

[tool.poetry]
name = "ghb_process_flow"
version = "2.9.14"
description = ""
authors = ["some author<EMAIL_ADDRESS>readme = "README.md"
packages = [{include = "ifrs9_atlas_implementation"}]

[tool.poetry.dependencies]
python = "^3.11"
polars = "1.0.0"
sas7bdat-converter = {extras = ["parquet"], version = "^2.0.0"}
python-dotenv = "^1.0.0"
tqdm = "^4.66.1"
pyodbc = "^4.0.39"
sqlparse = "^0.4.4"
numpy-financial = "^1.0.0"
numpy = "1.26.4"
tabulate = "^0.9.0"
wonderwords = "^2.2.0"
prefect = "2.20.2"
slack-sdk = "^3.27.1"
psycopg2-binary = "^2.9.9"
azure-identity = "^1.16.0"

[tool.poetry.dev-dependencies]
pytest = "^7.4.0"
pytest-cov = "^4.1.0"
pytest-html = "^4.0.2"
sphinx = "^7.2.6"
sphinx-rtd-theme = "^1.3.0"
sphinx-code-include = "^1.1.1"
interrogate = "^1.5.0"

[tool.ruff]
select = [
    "D",
]

[tool.ruff.pydocstyle]
convention = "numpy"

[tool.poetry.scripts]
purgedb = "ifrs9_atlas_implementation.data.ad_hoc_db_management:purge_database_contents"
dbtocsv = "ifrs9_atlas_implementation.data.ad_hoc_db_management:write_database_contents_to_csv"
quickflow = "ifrs9_atlas_implementation.flow_management.cli:run_ecl_flow_cli"

[tool.pytest.ini_options]
markers = [
    "dependency",
]

I am using the following command on by bash shell to create a requirements.txt file without the hashes and python version number.
poetry export --without-hashes --format=requirements.txt > requirements.txt
sed -i 's/ *;.*//' requirements.txt

It produces the below requirements.txt file where pendulum is stated twice with 2 different versions.
aiosqlite==0.20.0
alembic==1.13.3
annotated-types==0.7.0
anyio==4.6.0
apprise==1.9.0
asgi-lifespan==2.1.0
async-timeout==4.0.3
asyncpg==0.29.0
attrs==24.2.0
azure-core==1.31.0
azure-identity==1.18.0
cachetools==5.5.0
certifi==2024.8.30
cffi==1.17.1
charset-normalizer==3.3.2
click==8.1.7
cloudpickle==3.0.0
colorama==0.4.6
coolname==2.2.0
croniter==2.0.7
cryptography==43.0.1
dateparser==1.2.0
dnspython==2.6.1
docker==7.1.0
email-validator==2.2.0
exceptiongroup==1.2.2
fsspec==2024.9.0
google-auth==2.35.0
graphviz==0.20.3
greenlet==3.1.1
griffe==0.47.0
h11==0.14.0
h2==4.1.0
hpack==4.0.0
httpcore==1.0.5
httpx[http2]==0.27.2
humanize==4.10.0
hyperframe==6.0.1
idna==3.10
importlib-resources==6.1.3
itsdangerous==2.2.0
jinja2-humanize-extension==0.4.0
jinja2==3.1.4
jsonpatch==1.33
jsonpointer==3.0.0
jsonschema-specifications==2023.12.1
jsonschema==4.23.0
kubernetes==29.0.0
mako==1.3.5
markdown-it-py==3.0.0
markdown==3.7
markupsafe==2.1.5
mdurl==0.1.2
msal-extensions==1.2.0
msal==1.31.0
numpy-financial==1.0.0
numpy==1.26.4
oauthlib==3.2.2
orjson==3.10.7
packaging==24.1
pandas==2.2.3
pathspec==0.12.1
**pendulum==2.1.2
pendulum==3.0.0**
polars==1.0.0
portalocker==2.10.1
prefect==2.20.2
psycopg2-binary==2.9.9
pyarrow==12.0.1
pyasn1-modules==0.4.1
pyasn1==0.6.1
pycparser==2.22
pydantic-core==2.23.4
pydantic[email]==2.9.2
pygments==2.18.0
pyjwt[crypto]==2.9.0
pyodbc==4.0.39
python-dateutil==2.9.0.post0
python-dotenv==1.0.1
python-multipart==0.0.10
python-slugify==8.0.4
pytz==2024.2
pytzdata==2020.1
pywin32==306
pyyaml==6.0.2
readchar==4.2.0
referencing==0.35.1
regex==2024.9.11
requests-oauthlib==2.0.0
requests==2.32.3
rfc3339-validator==0.1.4
rich==13.8.1
rpds-py==0.20.0
rsa==4.9
ruamel-yaml-clib==0.2.8
ruamel-yaml==0.18.6
sas7bdat-converter[parquet]==2.0.1
shellingham==1.5.4
six==1.16.0
slack-sdk==3.33.1
sniffio==1.3.1
sqlalchemy==2.0.35
sqlalchemy[asyncio]==2.0.35
sqlparse==0.4.4
tabulate==0.9.0
text-unidecode==1.3
toml==0.10.2
tqdm==4.66.5
typer==0.12.5
typing-extensions==4.12.2
tzdata==2024.2
tzlocal==5.2
ujson==5.10.0
urllib3==2.2.3
uvicorn==0.30.6
websocket-client==1.8.0
websockets==12.0
wonderwords==2.2.0

I ... create a requirements.txt file without the hashes and python version number.

of course if you mangle the requirements.txt that poetry creates you risk getting nonsense
the actual poetry output for pendulum in your case is
pendulum==2.1.2 ; python_version >= "3.11" and python_version < "3.12"
pendulum==3.0.0 ; python_version >= "3.12" and python_version < "4.0"

which is correct
this issue has been fixed at least since https://github.com/python-poetry/poetry-plugin-export/issues/28#issuecomment-1140243677 and should be closed

My bad! Thanks for getting back to me David.
On Tue, 24 Sep 2024 at 12:33, David Hotham @.***> wrote:

I ... create a requirements.txt file without the hashes and python version
number.
of course if you mangle the requirements.txt that poetry creates you risk
getting nonsense
the actual poetry output for pendulum in your case is
pendulum==2.1.2 ; python_version >= "3.11" and python_version < "3.12"
pendulum==3.0.0 ; python_version >= "3.12" and python_version < "4.0"
which is correct
this issue has been fixed at least since #28 (comment)
https://github.com/python-poetry/poetry-plugin-export/issues/28#issuecomment-1140243677
and should be closed
—
Reply to this email directly, view it on GitHub
https://github.com/python-poetry/poetry-plugin-export/issues/28#issuecomment-2371007822,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AW7JCDK3URS7JTXXFDJXH2DZYFE2LAVCNFSM6AAAAABOX53LV6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGNZRGAYDOOBSGI
.
You are receiving this because you commented.Message ID:
@.***>


Validation Accuracy Aggregation

Currently, our validation_step method on the BaseEncoderDecoder computes a per batch accuracy and aggregates them at the end of each epoch. Because of this, we get a macro average accuracy that will depend on the batch size.
I noticed something must be strange when using evaluation sets of size 1000 and getting validation accuracies to many decimal places (like 0.9247395...). I think we probably want to accumulate raw counts of correct/incorrect dev samples per batch, and then aggregate those into an accuracy at the end of each epoch.
The impact of this should be small, but still, I believe we are getting slightly incorrect accuracies according to the expected micro accuracy.

Yes, I agree we want micro-accuracy not macro even though the only way I think they can differ is w.r.t. a partial batch.

Oh yeah good point. I guess we could also get some loss of precision too. Anyway, micro certainly seems preferable.


GCC High specific URLs for Defender ATP API to be added

There are a handful of docs that would benefit from including the GCC High specific URLs for Defender ATP API.

Service category
Service name
Azure Public
Azure Government GCC High
Notes

Windows Defender ATP
Integration, Response, Entities, and Streaming APIs
api.securitycenter.windows.com
api-gov.securitycenter.microsoft.us

Windows Defender ATP
SIEM API
wdatp-alertexporter-{region}.windows.com
wdatp-alertexporter-us.securitycenter.us
Public {region} options: eu/us/uk

https://docs.microsoft.com/en-us/azure/azure-government/compare-azure-government-global-azure
https://docs.microsoft.com/en-us/windows/security/threat-protection/microsoft-defender-atp/commercial-gov
https://docs.microsoft.com/en-us/windows/security/threat-protection/microsoft-defender-atp/exposed-apis-create-app-webapp
https://docs.microsoft.com/en-us/windows/security/threat-protection/microsoft-defender-atp/pull-alerts-using-rest-api

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 0893ad8a-cb5e-71cd-c706-700c5917db0c
Version Independent ID: e7b1c8a9-b147-4f7d-60ee-0f0ffddc76b0
Content: Microsoft Defender ATP for US Government GCC High customers - Windows security
Content Source: windows/security/threat-protection/microsoft-defender-atp/commercial-gov.md
Product: w10
Technology: windows
GitHub Login: @mjcaparas
Microsoft Alias: macapara

Duplicate of #8311


unable to upload app

I keep getting this error when I try using appcenter. Please advise
ERROR [2017-12-20 16:47:49.92]: fastlane finished with errors
ERROR [2017-12-20 16:47:49.92]: -----------------------------------------------------------------------
ERROR [2017-12-20 16:47:49.92]: SSL_connect returned=1 errno=0 state=error: certificate verify failed
ERROR [2017-12-20 16:47:49.92]:
ERROR [2017-12-20 16:47:49.92]: SSL errors can be caused by various components on your local machine.
ERROR [2017-12-20 16:47:49.92]:
ERROR [2017-12-20 16:47:49.92]: The best solution is to use the self-contained fastlane version.
ERROR [2017-12-20 16:47:49.92]: Which ships with a bundled OpenSSL,ruby and all gems - so you don't depend on system libraries
ERROR [2017-12-20 16:47:49.92]:  - Use Homebrew
ERROR [2017-12-20 16:47:49.92]:     - update brew with `brew update`
ERROR [2017-12-20 16:47:49.92]:     - install fastlane using:
ERROR [2017-12-20 16:47:49.92]:       - `brew cask install fastlane`
ERROR [2017-12-20 16:47:49.92]:  - Use One-Click-Installer:
ERROR [2017-12-20 16:47:49.92]:     - download fastlane at https://download.fastlane.tools
ERROR [2017-12-20 16:47:49.92]:     - extract the archive and double click the `install`
ERROR [2017-12-20 16:47:49.92]: -----------------------------------------------------------
ERROR [2017-12-20 16:47:49.92]: for more details on ways to install fastlane please refer the documentation:
ERROR [2017-12-20 16:47:49.92]: -----------------------------------------------------------
ERROR [2017-12-20 16:47:49.92]:         🚀       https://docs.fastlane.tools          🚀
ERROR [2017-12-20 16:47:49.92]: -----------------------------------------------------------
ERROR [2017-12-20 16:47:49.92]:
ERROR [2017-12-20 16:47:49.92]: You can also install a new version of Ruby
ERROR [2017-12-20 16:47:49.92]:
ERROR [2017-12-20 16:47:49.92]: - Make sure OpenSSL is installed with Homebrew: `brew update && brew upgrade openssl`
ERROR [2017-12-20 16:47:49.92]: - If you use system Ruby:
ERROR [2017-12-20 16:47:49.92]:   - Run `brew update && brew install ruby`
ERROR [2017-12-20 16:47:49.92]: - If you use rbenv with ruby-build:
ERROR [2017-12-20 16:47:49.92]:   - Run `brew update && brew upgrade ruby-build && rbenv install 2.3.1`
ERROR [2017-12-20 16:47:49.92]:   - Run `rbenv global 2.3.1` to make it the new global default Ruby version
ERROR [2017-12-20 16:47:49.92]: - If you use rvm:
ERROR [2017-12-20 16:47:49.92]:   - First run `rvm osx-ssl-certs update all`
ERROR [2017-12-20 16:47:49.92]:   - Then run `rvm reinstall ruby-2.3.1 --with-openssl-dir=/usr/local`
ERROR [2017-12-20 16:47:49.92]:
ERROR [2017-12-20 16:47:49.92]: If that doesn't fix your issue, please google for the following error message:
ERROR [2017-12-20 16:47:49.92]:   'SSL_connect returned=1 errno=0 state=error: certificate verify failed'
ERROR [2017-12-20 16:47:49.92]: -----------------------------------------------------------------------

I have done all what is stated in the error message but error still persist

@liaogz82 could you please provide your Fastfile?
I see that you have similar issue with sentry-fastlane-plugin, seems like you have some problem with your local setup.


WIP: Remove ExecutionProps from OptimizerRule trait

Which issue does this PR close?

Part of https://github.com/apache/arrow-datafusion/issues/2599 and https://github.com/apache/arrow-datafusion/issues/2535
Rationale for this change

The logical optimizer rules should not depend on execution properties and only one of them currently does (SimplifyExpressions - which also depends on the physical query planner).
What changes are included in this PR?

Remove ExecutionProps from OptimizerRule
Add execution_props to SimplifyExpressions rule

Are there any user-facing changes?

No

Does this PR break compatibility with Ballista?
No

I'm moving this back to draft for now.
The SimplifyExpressions rule needs to access the "query execution start time" but the rule is created before the query starts executing so we need some way to get this dynamically.
Perhaps we need to provide the optimizer rules with a trait for accessing certain system state.


support alternate unique keys

for example:

short url is unique by slug as well as separately by forUrl

export class ShortUrl extends DomainValueObject<ShortUrl> implements ShortUrl {
  public static schema = schema;
  public static unique = [['slug'], ['forUrl']];
}

sms is unique by externalId as well as separately by apiMessageId

export class Sms extends DomainEntity<Sms> implements Sms {
  public static schema = schema;
  public static unique = [['externalId'], ['apiMessageId']];
  public static updatable = ['status'];
}

may want to make the exposed dao method:
findByUnique(args: { slug: string } | { forUrl: string }) => { ... }

so that its clear its unique on both - and to continue the expectation that each domain object can be "foundByUnique"

another example:
export class Lot extends DomainEntity<Lot> implements Lot {
  public static unique = [
    ['requestUuid'], // ensures retried client requests do not result in more than one lot (since lotNumber is generated inside of the service)
    ['auctionUuid', 'lotNumber'] // ensures a lot number is used max once per auction
  ];
}


[embedded] Start building and including lld even in Darwin toolchains

We already include lld in the Linux and Windows toolchains. For embedded Swift development, it's common to (need to) use ELF even on a macOS host, but the Xcode-provided linker is Mach-O only. Let's start including a linker capable of linking ELF binaries (for embedded cross-compilation use cases) even in the Darwin toolchains.

@swift-ci please test

@swift-ci Please Build Toolchain macOS Platform

@swift-ci Please Build Toolchain macOS Platform

@shahmishal This will have Darwin toolchain size impact (should be no change on Linux/Windows toolchains).

@swift-ci please test

@swift-ci build toolchain macOS

I don't see lld getting installed in the toolchain, not sure if we are missing something.

We will need to change this to include lld
https://github.com/apple/swift/blob/main/utils/build-presets.ini#L22

@kubamracek I am a change to your PR to see if this fixes the issue.

@swift-ci build toolchain macOS

@kubamracek If you have the time, could you start another macOS toolchain build for me? Or do you have an idea when this PR will be merged? I have a feeling it's the only remaining blocker to have a working SwiftPM-based build for our RP2040 experiment, and I'd love to try this out.
It seems the last Mac toolchain build is no longer available? Because the CI server only keeps those around for a limited time? (I have no idea how this works.)
Thanks!

@swift-ci build toolchain macOS

@kubamracek If you have the time, could you start another macOS toolchain build for me? Or do you have an idea when this PR will be merged? I have a feeling it's the only remaining blocker to have a working SwiftPM-based build for our RP2040 experiment, and I'd love to try this out.
It seems the last Mac toolchain build is no longer available? Because the CI server only keeps those around for a limited time? (I have no idea how this works.)

Kicked off another toolchain build. You're right, the CI server only keeps a limited number of build logs and build artifacts.
I still need to figure out a few things about the inclusion of lld, there might be a bit more delays. I wonder, if all you need is a working lld on macOS, then if a possible short-term workaround for you would be to grab lld from llvm.org? The releases of LLVM for macOS do include it.

I wonder, if all you need is a working lld on macOS, then if a possible short-term workaround for you would be to grab lld from llvm.org? The releases of LLVM for macOS do include it.

Thank you! Thanks for the llvm.org tip. I've been using the Clang from the ARM embedded LLVM toolchain, and that seems to work too, but it's obviously a little inconvenient for users.
Here's roughly my SwiftPM setup (not public yet, I have to write it all up):

One library target/product for the RP2040 boot2 bootloader. This is a bunch of assembly files, copied from the Pico SDK.

One library target for the RP2040 crt0. This is also some assembly files, plus one or two C files, copied from the Pico SDK.

A SwiftPM static library target/product for the actual RP2040 executable, written in Swift. This target depends on (2), but not on (1) because we need to postprocess the bootloader before linking (see below).
This should be an executable, but I don't think SwiftPM can build embedded Swift executables yet (I forget the exact error message I get when I try that)? And even if we can build an executable in this step, it wouldn't be enough because we need to inject our custom linker scripts etc.

A SwiftPM command plugin that does the following:

Build products (1) and (3) separately.
Postprocess (1), the bootloader: compute a checksum over the assembled binary, write the checksum into the binary, link everything to the correct location.
Call Clang to link the postprocessed bootloader together with (3) into an executable.

I have this working on Linux with the default Swift Docker images, so you can write something like this to build your executable:
swift package --triple armv6m-none-none-eabi link-executable

On macOS, it also works with a current toolchain as long as you have the ld.lld from the ARM embedded LLVM toolchain in your PATH.

Very cool, please do write it up, or even post this as is to the forums :) There are folks (like me) who are eager to read about doing cool stuff with Embedded Swift.

Thank you! Thanks for the llvm.org tip. I've been using the Clang from the ARM embedded LLVM toolchain, and that seems to work too, but it's obviously a little inconvenient for users.

I found lld that comes with a plain brew install llvm is sufficient when cross-compiling from macOS.

@MaxDesiatov Thank you, I'll try that.

Note that the Homebrew install doesn't add it to the usual PATH locations, on Apple Silicon it's /opt/homebrew/opt/llvm/bin/ld.lld and on Intel it should be different from that.


knexfile migration path not working properly when in subfolder

Environment
Knex version: 0.19.5
Database + version: SQLITE3
OS: OSX 10.14.6
Knexfile:
// Update with your config settings.
require('dotenv').config();

module.exports = {
  development: {
    client: 'sqlite3',
    useNullAsDefault: true,
    connection: {
      filename: './dev.sqlite3'
    },
    migrations: {
      directory: "./migrations"
    }
  },
  production: {
    client: 'mysql2',
    connection: {
      host: process.env.DB_HOST,
      database: process.env.DB_NAME,
      user: process.env.DB_USER,
      password: process.env.DB_PASSWORD
    },
    pool: {
      min: 2,
      max: 10
    },
    migrations: {
      tableName: 'migrations'
    }
  }
};

Bug
Knexfile is in config/knexfile.js
When running knex migrate from CLI in the root folder with a path to the knexfile, it uses the migration path relative to the knexfile, which is incorrect.
When running the application and passing the knexfile contents to knex when initializing, it uses the migration path relative to the project root folder, which is correct.
Tried using the cwd parameter to change this when running it from CLI , it seems to be working relative to the actual process cwd; However the migration path is again always relative to the knexfile location.
Expecting it to always use the path relative to the current working directory.

Expecting it to always use the path relative to the current working directory.

I don't think this is desirable. This will always require people to run knex cli from the project root where as currently I can run a run knex commands wherever I am in the directory tree.
In general having relative paths behave same as require is a reasonable choice IMHO.

The issue here is that it's not behaving in a consistent way.

@pepsivontwist Why was this closed?
I run into this issue, because my .env with my local environment variables, are in the project root, and they only get recognized when I run a command like knex migrate:make create_waitlist_users --knexfile=./src/libs/db.ts if I copy the /.env to /src/libs/.env. This is frustrating and not expected behavior.

I solved this problem by placing knexfile where it would normally be used in the application ( src/config/knexfile.js ) and using an auxiliary file at the root ( also knexfile.js ) , just importing import knexConfig from src/config/knexfile.js and directly exporting. This way, when I run npx knex migrate:make initial, migrations directory is placed in the right spot. And I can still use the same config in the application knex(knexfile.development).migrate... using knexfile from subfolder src/config/knexfile.js


perf: Remove redundant subprocess calls

Description
Closes #1265
A performance improvement when checking the lastUpdated time.
Render times for docs using lastUpdated = true are reduced from ~800ms to ~200ms.

Thanks for your contribution :raised_hands:
I have not yet had time to test the changes or give much thoughts to them but I wonder what would be the result in the same setup if instead of removing the checks, we:

Check only once if git is installed and cache the result. I think it's a nice error to have and gives a good hint to the user.
Instead of using execa and the test command to check if a path exists and is a file, we use fs.accessSync, fs.existsSync or something similar.

Hey @HiDeoo I had the same thinking in my original issue I raised. However, I opted for just removing the code which checks whether git is installed and also whether the file path exists as in the original implementation it was raising an exception which was immediately caught and not re-raised. As such the code (I believe) wasn't really doing anything.
If we'd rather have explicit error messages when git isn't installed, or the filepath can't be found then I can look into doing so. However, the current implementation doesn't do so due to the catch-all exceptions?
I agree that using the fs module will be a better fit to checking if a file exists, rather than relying on a sub-command so happy to replace if we move forward with explicit checks.
Along the same lines of thinking as yourself, I think one other way we could improve the performance is to gather the last updated dates for all files under the content directory and cache them so we aren't performing costly sub-process calls for each document. This changeset will likely be much larger though so it may take a lot longer for me to investigate and implement.
I can have a look into the above if you think it's useful? The current changes I've made were a quick win but happy to look further into optimisation where I can  :smile:

as in the original implementation it was raising an exception which was immediately caught and not re-raised

Oh, you are right, I totally missed that. I quickly read that on my phone and based my assumption on the JSDoc but didn't realize that GitNotFoundError was actually never bubbled up. Good catch!
Considering this worked like that for a long time, I would then assume this is a safe change to make indeed.
Altho, now it makes me wonder, if GitNotFoundError was explicitly created, I guess the original intent was to not catch it and let it bubble up to the user and if we should either remove it as suggested or actually tweak the code to make it work as intended (and maybe cached) :thinking:
I wonder what Chris thinks about this.

It looks like the implementation was copied directly from docusaurus as per the comment, including the GitNotFoundError: https://github.com/withastro/starlight/pull/1266/files#diff-dbaa2909a7c752ba9604ed8f39fa172a91057d4dd370a18fed5531f86394ab84L3
There is also no references to GitNotFoundError so it should be safe to remove?
Again happy either way (To keep as is, or to refactor to remove the catch-all and correctly raise the Exception) - Just let me know what you'd rather and I'll get to work!


Update/py kmip usage demo

I've been able to run the new test with accumulo and pykmip.
I'll add some comments on the PR now for typos and suggested script improvements.


dllistnode.<prev()|next()> incorrect behaviour

Hey,
Tried the following:
`import pyllist
dllist = pyllist.dllist
a = dllist([2.0])
a.appendleft(1.0)
a.appendright(3.0)
b = a.nodeat(1)
print(b)
c = b.prev()
print(c)`
The documentation makes it sound like next and prev should return the adjacent dllistnodes, but they seem to be returning the value stored in the node instead. Maybe this is intentional, maybe not, but how do I get the node instead of the value? I want to walk along the list!

Oh, forgot to mention, same thing with first() and last().

Ah, sorry, this is my fault; I shouldn't have put () at the end of things, it seems to make them give the value contained. An odd Python behaviour I'm not used to! Really sorry if I wasted your time!


Blazor project tracking 2021

This issue will ...

Maintain a set of doc ideas for Blazor topics that we either don't want to (or can't) address in the near-term or are just ideas for consideration that don't warrant an issue at this time.
Track work on topic UE (user experience) passes (i.e., topic overhauls).

Doc ideas

[ ] Confirm with the PU that runtime relinking is a publish-and-Release config gesture. Building only produced 51.5 MB. Publishing in Debug was 9.3 MB without relevant console compiler output. Publishing in Release was 6.6 with console compiler output that looked like runtime relinking was taking place.
[ ] When https://github.com/dotnet/docs/issues/27395 is resolved and Mono/WASM MSBuild props are covered, update the cross-links from the targets file to the new official doc. Links can be located on the PR that added them at https://github.com/dotnet/AspNetCore.Docs/pull/24493.
[ ] It seems like everyplace that we have hosted WASM, we should call out that the project must be run from the Server project. The errors for not doing so can be quite cryptic 😵. For example, the File Uploads topic example throws a "JSON token" error when the solution is run from the client app. It's not at all clear that it was simply run from the wrong project.
[x] The pivots for the Handle Errors topic were dropped, then the content was reorganized on https://github.com/dotnet/AspNetCore.Docs/pull/24195 for its final layout. However, the Prerendering section is currently only for Blazor Server apps. That section should be made to generically cover both WASM and Server prerendering. https://github.com/dotnet/AspNetCore.Docs/pull/24211
[x] For NavLink components in examples: It will harden docs against past and future deltas to merely mention adding example components to the NavMenu and not actually show the markup, which seems to change quite a bit. #24130
[x] A number of spots show project file XML markup for adding packages to apps. There are also Package Manager and CLI commands. I think mentioning the package would be better and having an INCLUDE for the options: edit the project file, use the Package Manager, or use the CLI add package command. I should be able to filter the locations for these updates with <PackageReference. https://github.com/dotnet/AspNetCore.Docs/pull/24212
[ ] In the Prerender and Integrate topic, clarify the line that speaks to the dev starting with RP/MVC and then including Blazor Server app in order to render components from pages/views. https://github.com/dotnet/AspNetCore.Docs/issues/23948#issuecomment-974559793 Related: I add a HeadOutlet component to the layout at Line 212 for the scenario of an RP/MVC app that embeds components from a hosted WASM app (render-mode="ServerPrerendered") to allow components to control head content. Due to time constraints at the moment, the coverage is going in. When I address this item and touch that line :point_up: also run a quick test and confirm the scenario for Line 212 actually works ... or did I just make up a new Blazor feature all by myself?! 🙈😄
[X] Drop the images added by https://github.com/dotnet/AspNetCore.Docs/pull/23959. They're provided by the PU for quick coverage, but we don't want images of the Azure portal unless absolutely necessary given the UI churn of the portal. Also, improve the naming (e.g., app name) ... and this will require text changes (e.g., https://bwhappsettingsasdf-staging.azurewebsites.net is in the doc text). https://github.com/dotnet/AspNetCore.Docs/pull/24234
[ ] InputFile component preview guidance (6.0) is in the new Blazor Images topic and probably should be better cross-linked. https://github.com/dotnet/AspNetCore.Docs/issues/23802
[x] Drop hosting model pivots from a few topics where they aren't needed, especially in Fundamentals node topics b/c readers are probably consuming all of these docs early and without regard to an explicit choice of hosting model. https://github.com/dotnet/AspNetCore.Docs/pull/23736 PR for Call web API Demo 3 test (live now) & Additional updates for Call web API
[x] Sub-app hosting: Let's firm up a prohibition on the use of IIS virtual folders and firm up recommendation to host separate apps in separate app pools, including for sub-apps. https://github.com/dotnet/AspNetCore.Docs/pull/24235
[x] Clarify use case/config for Blazor Server MapFallbackToPage configuration. Started on: https://github.com/dotnet/AspNetCore.Docs/pull/23698 Finished up on (but it's rather draftish and needs more work later): #23735 Later, ask about https://github.com/dotnet/aspnetcore/issues/32333#issuecomment-831159066 relative to what I did here with my ordering of the fallbacks. PU Issue PU Issue (vaguely related without full discussion)
[ ] Ask Pranav about https://github.com/dotnet/AspNetCore.Docs/pull/23566#issuecomment-947503152.
[x] Test some solutions for the content-hidden-in-a-pivot and search-results-don't-link-to-visible-content problems:

Demo 1: Show version using the old style, where each section calls out what hosting model is applies to.
Demo 2: Show a stacked H1 version where the hosting model is the H1 section and it's following sections are H2s or lower.
Demo 3: Show a version where the section content of each pivot is displayed at the top of the alternate pivot.

[ ] Ask RA for an internal issue on pivot search results. The problem is that the whole topic is indexed but the links to the topics don't point to the pivot where the content lives ... the topic loads with whatever default pivot the user has selected earlier (or the default). I think the search results should be by-pivot with a clear pivot indication and with a pivot-specific landing link. This would mean that it's possible for the reader to receive two or more search result links, but the reader would be taken directly to the pivot and not get confused when the land to find no content for what they searched.
[ ] For Blazor AOT, add remark ... https://github.com/dotnet/aspnetcore/issues/37092#issuecomment-930356311 ... also see :point_right: https://github.com/dotnet/aspnetcore/issues/35302
[ ] Ping Steve to take a look at the new guidance on https://github.com/dotnet/AspNetCore.Docs/pull/23223. The guidance+example might be incorrect, but the pattern was signed off by Artak at https://github.com/dotnet/aspnetcore/issues/17886#issuecomment-566158668. I tried not to totally make something up 😆, but I may have done so in this case. Ping back Darragh Jones on the outcome.
[x] Confirm that in spots where we're running a hosted WASM project in a command shell that the Server project is where the dev runs the app (https://github.com/dotnet/AspNetCore.Docs/issues/23166). Although VS gets a fix (Preview 4, https://github.com/dotnet/aspnetcore/issues/35356) not to default the startup project to the Client project for VS 2022, confirm it with VS 2022 at GA. Update: Done! #23227
[x] Explicit example of lazy loading (e.g., in the snippet sample apps). I'm rejecting on the grounds that its a straight-forward, well-described scenario in the topic and there isn't a lot of time to include it in the snippet sample app. #20154
[x] Check on the feature request for Support WebSocket connections on Azure Front Door in the Threat Mitigation topic added on https://github.com/dotnet/AspNetCore.Docs/pull/23033: Update the text and/or kill the link when they either close it out as a won't-fix or decide to proceed with implementing the feature. #23279
[x] Dashes in filenames for Security node projects. See https://github.com/dotnet/aspnetcore/issues/35337#issuecomment-900459109. Docs PR
[x] Check on encoding in query strings: We want %20 for spaces everywhere. Checked 8/25: No instances found to update.
[x] Bit concerned about 3.1 (not 3.2 ... 3.1) coverage for Blazor loc. The MSBuild prop isn't involved, and framework churn might have led to poor guidance for 3.1. It will be low priority, but I'll check if I can find time 🏃😅. Update 8/25: Checking this one off as a wont-fix: Given the arrival of 6.0 soon and the sunset of 3.1 LTS in 12/2022, this is a low enough priority item to merely see if reader feedback indicates a problem with 3.x coverage.
[x] Target-typed new expressions. See :point_right: https://devblogs.microsoft.com/dotnet/announcing-net-5-0-preview-8/#target-typed-new-expressions — First pass on https://github.com/dotnet/AspNetCore.Docs/pull/21934. Additional opportunities will be addressed as I go forward with UE passes after 3/31/21.
[x] Move the Layouts topic into the Components node? UPDATE: Done ... https://github.com/dotnet/AspNetCore.Docs/pull/22368
[x] ShouldRender referenced in the Rendering topic looks to be based in the perf topic, also appears in the Lifecycle topic, but perhaps would be better in the Rendering topic itself with cross-links from perf and Lifecycle topics. https://github.com/dotnet/AspNetCore.Docs/pull/22475
[x] Call out heuristic scanner false positives with an INCLUDE. We've had ~3 issues now opened on (probably) false positives (for example, https://github.com/dotnet/AspNetCore.Docs/issues/21829). Include strong lingo that it's the dev's responsibility to manage scanner exceptions, since we can't really know if the local copy of a file was modified after it was pulled down from somewhere where the source isn't infected. Also, there's something at https://docs.microsoft.com/en-us/aspnet/core/blazor/host-and-deploy/webassembly?view=aspnetcore-5.0#troubleshoot-integrity-powershell-script to address for this item. PR: https://github.com/dotnet/AspNetCore.Docs/pull/22338
[x] The MVC scenarios in the Prerender and Integrate topic weren't fully tested due to time constraints. Perform local testing of those aspects to confirm the guidance. Update 8/25: Checking this one off here because it's going to be tracked by the 6.0 tracking issue. I plan to verify all scenarios in the doc for 6.0 at RC1 and not further test prior releases unless a dev writes in with a problem with 3.1 or 5.0.
[x] Review https://github.com/dotnet/AspNetCore.Docs/issues/21277 in the context of all Blazor doc set docs. Originally, components could only be used in Blazor apps (and the content was written that way), but they can be used in ASP.NET Core apps now. UPDATE (7/19): We won't be able to address this unless the PU were to move Razor components away from WASM/Server ... e.g., they become part of Razor formally and not just be based on Razor syntax ... which doesn't seem like its going to happen. Components will be Blazor framework objects made available to other frameworks in parallel with those frameworks, so they'll continue to be documented that way AFAICT. The Components node will stay in the Blazor node. The inclusion of "Blazor" as a web tech tho is a bit funky now tho with MAUI, which doesn't have to be a web tech.
[x] Re-evaluate the RCL topic for snippet app use. Overkill, or good i-dear? UPDATE: Done ... Let's not given the workload. It can be done the next time the RCL topic is overhauled in a few years.
[x] Document that <head> element interaction is only supported via JS interop? See: https://github.com/dotnet/AspNetCore.Docs/issues/22121. UPDATE: Done ... This has been placed on the 6.0 tracking issue to resolve when the <head> element features are added to the doc set (see: https://github.com/dotnet/AspNetCore.Docs/issues/22045).
[x] Take a look at https://docs.microsoft.com/en-us/aspnet/core/blazor/hosting-models?view=aspnetcore-5.0#comparison-to-server-rendered-ui and further sections in light of the discussion on https://github.com/dotnet/AspNetCore.Docs/issues/22165. There are probably opportunities for improving the coverage that compares and contrasts RP/MVC and Blazor frameworks. Update 8/25: Checking off because this is going to be tracked by https://github.com/dotnet/AspNetCore.Docs/issues/23120 as part of the 6.0 updates.
[x] Address the use of Bootstrap JS in a suitable spot. We warn off of interacting with the DOM in the JS interop topic, but Bootstrap guidance (for styles) appears earlier in the doc set. It's bound to be a question in devs' minds. See :point_right: https://github.com/dotnet/AspNetCore.Docs/issues/22213. https://github.com/dotnet/AspNetCore.Docs/pull/22489
[ ] Create an Overview in the Fundamentals node with a bare bones explanation of a component in order to understand fundamental concepts+examples better, orient on any doc consumption features (e.g., use of working examples, sample apps, use of the this keyword, resolve #14216, etc.), and any other prelim remarks before the reader gets into the meat of the coverage. https://github.com/dotnet/AspNetCore.Docs/issues/22230#issuecomment-875910670
[x] Consistency of Razor component directive order — https://github.com/dotnet/AspNetCore.Docs/pull/22357
[x] Confirm/update topic redirection is correct (e.g., check for double-redirection) — https://github.com/dotnet/AspNetCore.Docs/pull/22358
[x] WRT the early use of the snippets sample app: I'm not favoring using partial components that require mocked pieces and inlined <snippet> tags. This approach is generating a lot of local DocFX build warnings that are clouding real (important) warnings that I need to address. It's slowing me down 🐌. Either move these snippets back into the topics or recompose them or relink them without the use of <snippet> tags in their markup. — https://github.com/dotnet/AspNetCore.Docs/pull/22359
[x] Confirm null check in object disposal (e.g., objRef?.Dispose();). https://github.com/dotnet/AspNetCore.Docs/pull/22597
JS interop

[ ] Call JS from .NET doesn't demo cancellation token use. I think a working cut-'n-paste example wouldn't take up much space and would be nice to show.
[ ] The Call .NET from JS topic mentions but doesn't show an example of calling an open generic method ... include one? Cross-ref: PU InteropComponent.razor and GenericType<TValue>
[x] The JS interop topics have no guidance on reporting explicit exceptions from JS (e.g., wrap the invoke and then catch (JSException e)) ... include a section and one or more examples? Cross-ref: PU InteropComponent.razor Docs PR: #22772
[ ] Is there anything else in the family of JS interop JS function calls that should be mentioned or explained out with examples? Cross-ref: PU Microsoft.JSInterop.ts
[x] React to https://github.com/dotnet/AspNetCore.Docs/pull/19734#issuecomment-683922820. Update: A fix was made at the time, and no further negative feedback has been received. AFAIK, the sections+examples are composed correctly.

[x] "server API" and "web API" are both in use across Blazor docs. Stabilize on "web API" to match general terminology in ASP.NET Core docs. https://github.com/dotnet/AspNetCore.Docs/pull/22410
[x] For the file upload topic (and perhaps the one in the main doc set, too), consider adding a blurb about how PS can create dummy test files. https://github.com/dotnet/AspNetCore.Docs/pull/22591
[x] Confirm/add null checks on element references (ElementReference, @ref) before calling methods on them. https://github.com/dotnet/AspNetCore.Docs/pull/22771
[ ] Obtaining v2.0 JWT tokens. See convo at :point_right: https://github.com/dotnet/aspnetcore/issues/35794#issuecomment-906809847
[ ] Old sample apps dropped on #23228. Do we want to make the snippet sample apps into running apps and link them in the Blazor docs? Related ?: Whether or not we make snippet samples for download, should sample apps in general be kept/cross-linked in the official MS samples repo for easy download. This was a long-range plan for all ASP.NET Core sample apps AFAIK, but it hasn't taken place due to constant higher-priority work. We could at least make the Blazor Server-EF Core final app and the two Blazor-SignalR tutorial final apps available via that mechanism for easy download.
[ ] Do we want to make the Static files topic hosting model agnostic and get into static asset caching behavior, including how to control/manage it during development. Alternatively, we could document caching behaviors/scenarios in the Environments topic at https://docs.microsoft.com/aspnet/core/blazor/fundamentals/environments. The (possibly temporary) PR that focuses on JS file caching went in on https://github.com/dotnet/AspNetCore.Docs/pull/23235.

UE pass tracking
🔴 = Snippets update complete

[x] Overview — 🔴
[x] Supported platforms 🔴
[x] Tooling — 🔴
[x] Hosting models — #20868 🔴
[x] Tutorials

[x] Build a Blazor todo list app — #20941 🔴
[x] SignalR with Blazor WebAssembly — #21271 🔴

[x] Project structure — #21247 🔴
[x] Fundamentals

[x] Routing — #20900 🔴
[x] Configuration — #20908 🔴
[x] Dependency injection — #20920 🔴
[x] Startup — #22279 🔴
[x] Environments — #20929 🔴
[x] Logging — #20929 🔴
[x] Handle errors — #21601 🔴
[x] SignalR — #21620 🔴
[x] Static files — #21331 🔴

[x] Components

[x] Overview — #22053 🔴
[x] Cascading values and parameters — #21366 🔴
[x] Data binding — #21678 🔴
[x] Event handling — #21755 🔴
[x] Lifecycle — #21822 🔴
[x] Rendering — #21766 🔴
[x] Component virtualization — #21623 🔴
[x] Templated components — #21666 🔴
[x] CSS isolation 🔴
[x] Prerender and integrate components — #21881 🔴
[x] Component libraries — #21946

[x] Globalization and localization — #22525 🔴
[x] Layouts — #21636 🔴
[x] Forms and validation — #22106 🔴
[x] File uploads — #22161 🔴
[x] JS interop

[x] Overview
[x] Call JavaScript from .NET — #22229 🔴
[x] Call .NET from JavaScript — #22304 🔴

[x] Call a web API from WebAssembly — #22410 🔴
[ ] Security and Identity — See :point_right: #20708, #19807, and #19226. I placed an ellipsis in the App component example INCLUDE(s) to cover 6.0 churn. See: https://github.com/dotnet/AspNetCore.Docs/issues/23696

[ ] Overview — Either here or in the Blazor Server Overview: #22405
[ ] Blazor WebAssembly — See :point_right: #20512 & https://github.com/dotnet/AspNetCore.Docs/issues/21816#issuecomment-803152089. Also, consider surfacing a smidgen of WebAssembly "sandbox" content in a new section with a cross-link or two (e.g., https://webassembly.github.io/spec/core/intro/introduction.html#security-considerations, https://webassembly.org/docs/security/). It would be nice to clarify that WebAssembly (as a non-MS technology) is constantly undergoing security patching, and there is a place (I'll find the link) where devs can see potential security vulnerabilities, work on WebAssembly security, and patches being put into place.

[ ] Overview — See :point_right: https://github.com/dotnet/AspNetCore.Docs/issues/21741 (cross-link to an Azure doc from all of our AAD/B2C docs)
[ ] Standalone with Authentication library — See :point_right: https://github.com/dotnet/AspNetCore.Docs/issues/21510, https://github.com/dotnet/aspnetcore/issues/30068, https://github.com/dotnet/AspNetCore.Docs/issues/23712
[ ] Standalone with Microsoft Accounts
[ ] Standalone with AAD
[ ] Standalone with AAD B2C — "custom user flows" language https://github.com/dotnet/AspNetCore.Docs/issues/21144. Take a look at signup-signin Azure UI per https://github.com/dotnet/aspnetcore/issues/39401#issuecomment-1009511236.
[ ] Hosted with AAD — See :point_right: https://github.com/dotnet/AspNetCore.Docs/issues/21983
[ ] Hosted with AAD B2C — "custom user flows" language https://github.com/dotnet/AspNetCore.Docs/issues/21144; see :point_right: https://github.com/dotnet/AspNetCore.Docs/issues/21640. Take a look at signup-signin Azure UI per https://github.com/dotnet/aspnetcore/issues/39401#issuecomment-1009511236.
[ ] Hosted with Identity Server — See :point_right: https://github.com/dotnet/AspNetCore.Docs/issues/21842 and also see https://github.com/dotnet/AspNetCore.Docs/issues/22753 (Was it just VS not creating the project with the correct Identity config to run OOB when deployed to Azure directly from VS?) Consider splitting out custom domains from IdS, and check on the B1 requirement IdS-only scnearios (it might not be a requirement in that case). See :point_right: https://github.com/dotnet/AspNetCore.Docs/issues/24067#issuecomment-980033383.
[ ] Additional scenarios - Look for split-out opportunities. Possibly add an introductory ToC with section descriptions. Consider if the Unauthenticated or unauthorized web API requests in an app with a secure default client section could be better cross-linked/mentioned explicitly in the individual WASM security topics (https://github.com/dotnet/AspNetCore.Docs/issues/22217 and https://github.com/dotnet/AspNetCore.Docs/pull/22220). Consider making an INCLUDE out of the prerendering guidance and shooting a copy of that into the Prerendering and Integration topic (https://github.com/dotnet/AspNetCore.Docs/issues/23441).
[ ] AAD groups and roles — https://github.com/dotnet/AspNetCore.Docs/pull/20856; do we need a Blazor Server pivot, or can we cross-link? See :point_right: #22422
[ ] Graph API — See :point_right: #22657

[ ] Blazor Server

[ ] Overview — Review, work was done on :point_right: https://github.com/dotnet/AspNetCore.Docs/pull/20119 and mention https://github.com/dotnet/AspNetCore.Docs/issues/19797#issuecomment-779294104.
[ ] Threat mitigation
[ ] Additional scenarios — Review, work was done on :point_right: https://github.com/dotnet/AspNetCore.Docs/pull/20119. Also, see :point_right: https://github.com/dotnet/AspNetCore.Docs/issues/22122.

[ ] Content Security Policy

[x] State management 🔴
[ ] Debug WebAssembly &mdash: Resolve :point_right: #23373 ... and we'll probably need to show full files everywhere we refer to tasks.json/launch.json due to https://github.com/OmniSharp/omnisharp-vscode/issues/4542. See :point_right: https://github.com/dotnet/AspNetCore.Docs/issues/23777
[x] Lazy load assemblies with WebAssembly — #22603 🔴
[x] WebAssembly performance — #23135
[x] Test components 🔴
[ ] Progressive Web Applications — See :point_right: https://github.com/dotnet/AspNetCore.Docs/issues/21100
[ ] Host and deploy: Apache for hosted WASM/sub-app scenarios might need more work. See 👉 https://github.com/dotnet/AspNetCore.Docs/pull/24519#issuecomment-1008480134.

[ ] Overview — Perhaps for Routing, too, but clarify the navigation behavior of NavigationManager.NavigateTo. See :point-right: https://github.com/dotnet/AspNetCore.Docs/pull/22146#issuecomment-827802596.
[ ] Blazor WebAssembly — See :point_right: https://github.com/dotnet/AspNetCore.Docs/issues/19979 and https://github.com/dotnet/AspNetCore.Docs/issues/21829#issuecomment-803192673
[ ] Blazor Server — See :point_right: https://github.com/dotnet/AspNetCore.Docs/issues/21226
[x] Configure the Trimmer — https://github.com/dotnet/AspNetCore.Docs/pull/21480 🔴

[ ] Blazor Server and EF Core
[x] Advanced scenarios — https://github.com/dotnet/AspNetCore.Docs/pull/21768 🔴
[ ] Scaffolding topic sections that pertain to Blazor — See :point_right: https://github.com/dotnet/AspNetCore.Docs/issues/8434#issuecomment-808893911
[ ] File downloads topic: Use fully-working examples, place code into snippet sample apps, and see the cross-linked discussion and bits mentioned in https://github.com/dotnet/AspNetCore.Docs/pull/24560#issuecomment-1011301931.
[ ] Images topic: Use fully-working examples.

Closing out and moving to a new streamlined issue for '22 ...
https://github.com/dotnet/AspNetCore.Docs/issues/24615


#151 refactoring frame

Summary
It closes #151
Extra info

Needs more than 2 reviewers? n
Needs more than 10 minutes for review? y
Needs to execute in order to review? y

@GrasshopperBears 리뷰 감사합니다!! 😄


Possible incorrect statment.

In the section "HttpContext.Items", this sentence doesn't seem right ... "For middleware that's only used in a single app, fixed string keys are acceptable. Middleware shared between apps should use unique object keys to avoid key collisions." It seems to me that any middleware needs to use a unique key so that it won't conflict with any other middleware in the same app. What does some other app have to do with collision around this object?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 76e22150-f1f1-5e4f-0e97-39b1ac089297
Version Independent ID: 687172c3-b7d8-525d-39dc-658b4a0f526f
Content: Session in ASP.NET Core
Content Source: aspnetcore/fundamentals/app-state.md
Product: aspnet-core
Technology: aspnetcore-fundamentals
GitHub Login: @Rick-Anderson
Microsoft Alias: riande

The difference is object, should use unique object keys to avoid key collisions
I think unique threw you off. Perhaps unique should be dropped as object keys are unique.
cc @serpent5

@JamesKiddSmyth thanks for reporting this. The update will be live soon.