JUNIT reporter doesn't mark test as failed if the beforeAll throws error

Describe the bug
When a beforeAll hook throws an error, the generated JUNIT report will report all tests in that describe block as without failiure, ergo succeeded.
That doesn't seem right to me.
Reproduction
I set up a minimal example in this stackblitz:
https://stackblitz.com/edit/vitest-dev-vitest-brpfrz
System Info
See the stackblitz example

Used Package Manager
npm
Validations

[X] Follow our Code of Conduct
[X] Read the Contributing Guidelines.
[X] Read the docs.
[X] Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
[X] Check that this is a concrete bug. For Q&A open a GitHub Discussion or join our Discord Chat Server.
[X] The provided reproduction is a minimal reproducible example of the bug.

What is your expectation here? Do you expect all tests to have the same error? I am not actually sure what JUNIT spec defines this situation

Reading this it seems junit allows only failed testcases, not suites.
However not reporting the failiures at all does seem worse to me instead of reporting the same failiure to each testcase affecte by the bad beforeAll. That is also the behaviour if beforeEach throws an error.

However not reporting the failiures at all does seem worse to me instead of reporting the same failiure to each testcase affecte by the bad beforeAll. That is also the behaviour if beforeEach throws an error.

I do agree that we need to show them, I am just not sure how. Maybe jest has an answer.

It looks like a failure in afterAll doesn't make relevant test cases as failed. I made a repro to compare all four cases of
afterAll/afterEach/beforeAll/beforeEach.
https://stackblitz.com/edit/vitest-dev-vitest-m7bw4w?file=junit.xml


Add Gradient-Background

What is the change?
Add Gradient Background on Background components.
Related issue?
No.
How was it tested?
It's pure HTML and CSS, so just opening the index.html on a browser.
Checklist:
Before you create this PR, confirm all the requirements listed below by checking the checkboxes [x]:

[x] Have you followed the Contribution Guidelineswhile contributing.
[x] Have you checked there aren't other open Pull Requests for the same update/change?
[x] Have you made corresponding changes to the documentation?
[x] Have you tested the code before submission?
[x] Have you formatted your code ? (You can use any html,css beautifier)
[x] My changes generates no new warnings.
[x] I'm Hacktoberfest'21 contributor.
[x] I have commented my code, particularly in hard-to-understand areas.

GIF/video of the working of component you created:

Create a issue first

@siddhi-244 #104.

We need a designed one this is so simple

We need a designed one this is so simple

More colors? What do you mean?


Assign task - Reply Activity Not Displayed in "Share Somewhere" Section

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number: 1.4.65-0
Reproducible in staging?: Y
Reproducible in production?: Y
**If this was caught during regression testing, add the test name, ID and link from TestRail:**N/A
Issue reported by: Applause - Internal Team
Action Performed:

Write a message in any chat
Reply to the message
Navigate to the Left Hand Navigation (LHN) and observe the displayed activity
Access the FAB menu, choose "Assign Task," add a title, and proceed to "Share Somewhere"
Notice that the replied message is not displayed; instead, "No activity yet" appears

Expected Result:
The replied message should be visible in both the LHN and the "Share Somewhere" section
Actual Result:
While the message appears with its reply in the LHN, in the "Share Somewhere" section, it displays "No activity yet," leading to inconsistency
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android: Native
[ ] Android: mWeb Chrome
[ ] iOS: Native
[ ] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[ ] MacOS: Desktop

Screenshots/Videos
Add any screenshot/video evidence

https://github.com/Expensify/App/assets/78819774/e73114b8-4cf8-4c3d-a213-28b38f20af8c
View all open jobs on GitHub

We think that this bug might be related to #vip-vsp

@abekkala  FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

@suneox your proposal for adding the lastMessageText to getAlternateText function looks good to me, and it's working fine when I am testing,
you are suggesting that we should use reportOption.lastMessageText as lastMessageTextFromReport, but in createOption, we are using the getLastMessageTextForReport(report, lastActorDetails) for setting the lastMessageTextFromReport value, so what difference is in these two, and if there be any inconsistency in these two?

We should pass lastMessageText to getAlternateText function

@suneox I am unsure about the root cause of your proposal; we are not passing the lastMessageText in getAlternateText for the normal 1:1 chat. Why is it working fine for the chat message?
But when we reply in a thread and send a message, that message does not show as the alternate text. By the way, this same issue can be reproducible on the search page.

Thanks for the details @suneox. Let's pass lastMessageTextFromReport to getAlternateText, and it will fix the issue. We can go with @suneox 's Proposal.
🎀 👀 🎀 C+ reviewed

We need Jasper's approval for this Proposal, but they are sick today.

@jasperhuangg now I can't reproduce this issue with the latest version. @lanitochka17  Can we please get it tested for the QA team and confirm if they are getting this issue now?

applied retest label for weekly testing

Issue not reproducible during KI retests. (First week)

@jasperhuangg is payment only eligible for @suneox? Or anyone else in regards to this issue?

Or anyone else in regards to this issue?

As a C+ on the issue, I am also eligible for payment here.

@abekkala Please cancel the Upwork offer for me, I will make the request on NewDot

Requested on ND as per https://github.com/Expensify/App/issues/40891#issuecomment-2302144105

$250 approved for @jayeshmangwani


Add prettier pre-commit hook

https://github.com/prettier/prettier#pre-commit-hook

:clap: Pre-commit hooks rock!


docs(using_deis): clarify proxy for Vagrant

closes #3045

That does clarify things, LGTM.

:ship:


Add WebGPU whisper large and llama 3.2

@NingW101 @ibelem PTAL.

LGTM~ @ibelem Could you please help to merge this patch, thank


fix: Oauth authorize will now redirect to the correct git branch (#21188)

Description

The redirect url fetched from the /datasources/authorize endpoint didn't consider the branch query parameter.
Save and authorize will pass the branch name as query parameter to the token request
The token request will pass the branch name in oauth state which will be used by the redirect url to redirect to the correct page and branch.
If there is no git branch connected, the earlier implementation will work as it is without the branch name in request param or oauth state.

PR fixes following issue(s)
Fixes #21188
Type of change

Bug fix (non-breaking change which fixes an issue)

Testing

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Also list any relevant details for your test configuration.
Delete anything that is not relevant

[ ] Manual
[ ] Jest
[ ] Cypress

Test Plan

Add Testsmith test cases links that relate to this PR

Issues raised during DP testing

Link issues raised during DP testing for better visiblity and tracking (copy link from comments dropped on this PR)

Checklist:
Dev activity

[ ] My code follows the style guidelines of this project
[ ] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes
[ ] PR is being merged under a feature flag

QA activity:

[ ] Speedbreak features have been covered
[ ] Test plan covers all impacted features and areas of interest
[ ] Test plan has been peer reviewed by project stakeholders and other QA members
[ ] Manually tested functionality on DP
[ ] We had an implementation alignment call with stakeholders post QA Round 2
[ ] Cypress test cases have been added and approved by SDET/manual QA
[ ] Added Test Plan Approved label after Cypress tests were reviewed
[ ] Added Test Plan Approved label after JUnit tests were reviewed

/ok-to-test

Moving back to in progress because:
(1) Many conflicts due to multiple env related changes need to be addressed.
(2) Some optimizations seem possible in the test case.


Location Constraint Info is invalid.

Anyone seeing this error when trying to upload an object?  Getting it with CloudBerry and S3Browser and latest build (7 days ago.)
{"name":"S3","clientIP":"::ffff:<IP_ADDRESS>","clientPort":19601,"httpMethod":"PUT","httpURL":"/kscott1/A79F758FD4.DIF","time":1490722748203,"req_id":"7d4208edd8b87f01cd8c","level":"info","message":"received request","hostname":"22370bf410a8","pid":49} {"name":"S3","bucketName":"kscott1","objectKey":"A79F758FD4.DIF","bytesReceived":2052592,"bodyLength":2052592,"accessKey":"accessKey1","bytesSent":200,"clientIP":"::ffff:<IP_ADDRESS>","clientPort":19601,"httpMethod":"PUT","httpURL":"/kscott1/A79F758FD4.DIF","contentLength":2052592,"httpCode":400,"time":1490722748206,"req_id":"7d4208edd8b87f01cd8c","elapsed_ms":3.303361,"level":"info","message":"responded with error XML","hostname":"22370bf410a8","pid":49}

Hey @amarcionek - Has <IP_ADDRESS> been listed in the restEndpoints section in your config.json?
Exemple:
in S3/config.json
"restEndpoints": {
     "<IP_ADDRESS>": "us-east-1"
},

Note: Please make sure that "us-east-1" is listed in your S3/locationConfig.json
More info: https://github.com/scality/S3#location-configuration

I should have been a bit more specific. This is from the latest docker image built 7 days ago: https://hub.docker.com/r/scality/s3server/tags/
I could probably find a way to edit the locationConfig.json file inside of it after running the image (although neither nano nor vi is in the container), but shouldn't the container really be immutable? IOW, you would want people to run it out of the box without any configuration? The prior image (e2a2574) doesn't exhibit this issue.

@amarcionek - Ok - we are going to update it so you won't need to change the config.

Thanks for the help!

@amarcionek The Docker image has been updated with a fix - please pull the latest (1fcb189) S3 server Docker image.
Keep us updated - thanks.

I can confirm this now works. THANKS!


Parse iOS builds page being updated?

Anyone updating the builds page for the iOS sdk, or are we now stuck to using cocoapods or building this ourselves?  It was nice to have the package build for download because it included other utils and the fb framework.

It's also available on the releases page on this repo here. Since we are moving to more and more open source - we would love to actually cross-link the releases page and the downloads page on parse.com


chore(release): update release 1.0.0-alpha.1

:tada: This PR is included in version 1.0.0-alpha.4 :tada:
The release is available on npm package (@alpha dist-tag)
Your semantic-release bot :package::rocket:

:tada: This PR is included in version 1.0.0-alpha.6 :tada:
The release is available on npm package (@alpha dist-tag)
Your semantic-release bot :package::rocket:

:tada: This PR is included in version 1.0.0-alpha.1 :tada:
The release is available on npm package (@alpha dist-tag)
Your semantic-release bot :package::rocket:


Parsing Style programs

UPDATE: good to merge now.
Current status:

Built dictionary from Substance id to style shape. For now I only deal with Shape commands, which is not correct. The actual type that the dictionary is mapping to is not clear yet. I do not think C.StyLine will be very appropriate because there is no one-to-one relationship from Substance objects to a StyLine. We will probably need a more comprehensive type for "Substance objects with style information".

Added square class and Subset energy functions and inObj function for
Sets

Added render functions for squares, and two other styles for dot
(commented out as if now)

[170611] Intersection functions:

Preview:

Support for map is now completed. We can have arrows going from/to circles/squares now!
Previews:

Nice refactoring! Looks like the boilerplate is greatly reduced. Were you able to test all of the changed objective functions? (One thing about our codebase is that it's hard to automatically test--right now we need to manually test each program, compile into diagrams, and drag things around to verify the layout behaves correctly. One day I'd like to add automatic unit testing, perhaps on optimization positions with a set seed for the rng.)

I would love to a have regression test suite in the near future. Assuming all parameters to the optimizer are the same, I think positions might just work. But the question is, what is the our ground truth here?

Added a simple objective function: when a set has a subset, it should not place its own label inside of that subset.


Routing.Context.Write() not marshaling JSON as expected

I have a struct Person with custom JSON MarshalJSON and UnmarshalJSON methods. When I use the the Write() in a routing handler, it skips these custom methods and use the default JSON marshal/unmarshal.
func GetPerson (c *routing.Context) error {
    // ...
    return c.Write(p) // print JSON with default JSON method, expect custom marshal to be used
}

However, if I wrap the struct in another struct or slice, e.g. :
type User struct {
    UserID  int    `json:"userID"`
    Details Person `json:"details"`
}

Or
[]Person{}

and c.Write(...) these values, the custom marshal methods is used.
E.g.
func GetPerson (c *routing.Context) error {
    u := User{}
    // ... more code
    return c.Write(u) // the custom marshal methods in Person is used (e.g. Birthday in Person have the correct time format)
}

func GetPeople (c *routing.Context) error {
    people := []Person{}
    // ... more code
    return c.Write(people) // the custom marshal methods is being used too (e.g. time format is converted as expected)
}

Is it a bug?* I guess it is something related to http Writter*... Hmmm... may please have a look? :)
Note: the Person struct is included below
type Person struct {
	Name     string    `json:"name"`
	Birthday time.Time `json:"birthday"`
	Hobbies  []Sharing `json:"hobbies"`
}

// MarshalJSON marshal struct.
// - Convert empty slice to "[]" instead of "null"
// - Custom manipulation to certain fields
// - Output time.Time in specific time format used by the app
func (m *Person) MarshalJSON() ([]byte, error) {
	type Alias Person
	if m.Hobbies == nil {
		m.Hobbies = make([]Sharing, 0) //convert to empty array if slice is nil
	}

	return json.Marshal(&struct {
		Name     string `json:"name"`
		Birthday string `json:"birthday"`
		*Alias
	}{
		Name:     "Oh, you need to guess it!",  //custom manipulation
		Birthday: app.TimeToString(m.Birthday), //change time format
		Alias:    (*Alias)(m),
	})
}

// UnmarshalJSON unmarshal JSON to struct data
func (m *Person) UnmarshalJSON(data []byte) error {
	type Alias Person
	aux := &struct {
		Birthday string `json:"birthday"`
		*Alias
	}{
		Alias: (*Alias)(m),
	}
	if err := json.Unmarshal(data, &aux); err != nil {
		return err
	}

	t, err = app.StringToTime(aux.Birthday)
	if err != nil {
		return err
	}
	m.Birthday = t

	return nil
}

Declare your MarshalJSON as this: func (m Person) MarshalJSON() ([]byte, error)
(the method is bound to the struct, not struct pointer)

OK, it works... many thanks... ^_^


fix: mediation routing keys as did key

This PR is a minor rethink to #2502; as discussed in my comment on that PR, I think I/we went a bit too far with base58 to did:key normalization. This is the minimum set of changes required to fix the two issues.
Fixes #2492.
Fixes #2357.
These changes also cause did:keys to be sent out in mediation grant messages and, subsequently, connections/did exchange as the routingKeys in the DID Document. This has interop implications. A big motivator for these changes however is to enable AFJ/Bifold based agents to connect through a public DID with mediation where AFJ/Bifold is expecting did:keys in the routing keys in the endpoint attrib. So this should help push us towards "good" interop and should only break "bad" interop.

I've got some integration test issues to sort out.

I've got some integration test issues to sort out.

Ok,  that's good to hear actually. My run of BDD wasn't working (hanging?) but I figured you had run them and that it was just my machine acting up (as it did earlier today) and figured it was time for a reboot. I'll cancel the review/approval and try running BDD after your updates.

A new development: given our recent tightening up of DID Doc semantics and using PyDID to interact with DID Documents, it came to my attention that we were out of spec with the routingKeys values we were sending and accepting previously. Old validation required did:keys without a fragment. The only place we really call out what we're expecting in routingKeys is in the OOB RFC under the description for the services. The text says that they should be DID key references but the examples show just did:keys. It is also mentioned in the DID Doc conventions RFC.
This might present an interop challenge. I'll see if I can check in with AFJ's DID Exchange/OOB implementation and see what it is expecting.

My investigation suggests that AFJ will accept either a DID Key or a DID Key reference.

Ran changes locally...BDD tests look good by pytests are failing.

My investigation suggests that AFJ will accept either a DID Key or a DID Key reference. However, it will emit just a DID Key, not a DID Key reference, in OOB invitations but sends references in the DID Docs it forms for DID Exchange...

We ran into this issue in the AFJ implementation of OOB, but as the RFC just used keys (no reference) and ACA-Py's implementation also did that we went for the non-key reference. I think there is an issue somewhere (but it could also be that this was discussed in discord)

FYI -- when I ran the AATH acapy run set, the following two tests fail:
Failing scenarios:
  features/0211-coordinate-mediation.feature:50  Request mediation with the mediator accepting the mediation request and creating a connection using the mediator -- @2.1 0160 connection
  features/0211-coordinate-mediation.feature:149  Two agents creating a connection using a mediator with overlapping transports -- @2.1 Acme and Faber creating a 0160 connection using Bob a mediator with overlapping transports

To run the specific tests use, update requirements-main.txt to use the branch to be merged and then:
./manage run -d acapy-main -t @T002-RFC0211,@T004-RFC0211,@T005-RFC0211 -t @RFC0160
Example error from run:
     Assertion Failed: FAILED SUB-STEP: And "Faber" receives the connection invitation
      Substep info: Assertion Failed: resp_status 422 is not 200; {"routingKeys": {"0": ["Value did:key:z6MkfDd4T7QAeuLrjeigXe8HfdvqNHWA5KGmMjkrLceE27Bz#z6MkfDd4T7QAeuLrjeigXe8HfdvqNHWA5KGmMjkrLceE27Bz is not a raw Ed25519VerificationKey2018 key"]}}
      Traceback (of failed substep):
        File "/usr/local/lib/python3.7/site-packages/behave/model.py", line 1329, in run
          match.run(runner.context)
        File "/usr/local/lib/python3.7/site-packages/behave/matchers.py", line 98, in run
          self.func(context, *args, **kwargs)
        File "features/steps/0160-connection.py", line 152, in step_impl
          assert resp_status == 200, f"resp_status {resp_status} is not 200; {resp_text}"

      Captured stdout:
      Data table in step contains an unrecognized role 'recipient', must be inviter, invitee, inviteinterceptor, issuer, holder, verifier, prover, requester, responder, mediator, and recipient
      Data table in step contains an unrecognized role 'sender', must be inviter, invitee, inviteinterceptor, issuer, holder, verifier, prover, requester, responder, mediator, and recipient

This PR is now ready for review. I ended up trimming out some additional unused code relating to the previously removed old routing protocol and "inbound connection" handling on the create_did_doc method. Also, I cleaned up some items relating to the route managers to further abstract out multi-tenancy from connection protocols.

Lots of poking around today and running tests and AATH.
Something on my local dev doesn't like running pytests, but can run ./scripts/run_tests successfully and that's what counts.
Moving on to AATH... there are issues that we need to address in that repo.
We need to update 0160-connection.py to handle recipient and sender - those are not in the case/switch statement so it raises that error when it shouldn't. What I did to bypass this probably isn't proper but it got me further down the call stack to uncover other issues.
Next there is an actual issue with the tests. When there are no inbound transports, the backchannel code doesn't create an endpoint parameter, so we hit an ACA-py config error.
aries_cloudagent.config.error.ArgsParseError: -e/--endpoint is required.
Simple enough to add a default http endpoint.
However, then you hit another config error: aries_cloudagent.config.error.ArgsParseError: -it/--inbound-transport is required.
I am not sure how this scenario ever ran successfully since the test is to not have inbound transport and for 3 years that configuration has been required. At least from what I can see.
WIth ALL of that being said, this branch/PR does have an issue to address that is uncovered in AATH... routing keys not Ed25519VerificationKey2018.
  features/0211-coordinate-mediation.feature:50  Request mediation with the mediator accepting the mediation request and creating a connection using the mediator -- @2.1 0160 connection

fails with:
      Assertion Failed: FAILED SUB-STEP: And "Faber" receives the connection invitation
      Substep info: Assertion Failed: resp_status 422 is not 200; {"routingKeys": {"0": ["Value did:key:z6MkrSmucdbqKmWhVxJM4q2nyAFD1pCLNrfQWttos4ntoqMj#z6MkrSmucdbqKmWhVxJM4q2nyAFD1pCLNrfQWttos4ntoqMj is not a raw Ed25519VerificationKey2018 key"]}}
      Traceback (of failed substep):
        File "/usr/local/lib/python3.7/site-packages/behave/model.py", line 1329, in run
          match.run(runner.context)
        File "/usr/local/lib/python3.7/site-packages/behave/matchers.py", line 98, in run
          self.func(context, *args, **kwargs)
        File "features/steps/0160-connection.py", line 152, in step_impl
          assert resp_status == 200, f"resp_status {resp_status} is not 200; {resp_text}"

  features/0211-coordinate-mediation.feature:149  Two agents creating a connection using a mediator with overlapping transports -- @2.1 Acme and Faber creating a 0160 connection using Bob a mediator with overlapping transports

fails with:
      Assertion Failed: FAILED SUB-STEP: And "Acme" receives the connection invitation
      Substep info: Assertion Failed: resp_status 422 is not 200; {"routingKeys": {"0": ["Value did:key:z6MkrSmucdbqKmWhVxJM4q2nyAFD1pCLNrfQWttos4ntoqMj#z6MkrSmucdbqKmWhVxJM4q2nyAFD1pCLNrfQWttos4ntoqMj is not a raw Ed25519VerificationKey2018 key"]}}
      Traceback (of failed substep):
        File "/usr/local/lib/python3.7/site-packages/behave/model.py", line 1329, in run
          match.run(runner.context)
        File "/usr/local/lib/python3.7/site-packages/behave/matchers.py", line 98, in run
          self.func(context, *args, **kwargs)
        File "features/steps/0160-connection.py", line 152, in step_impl
          assert resp_status == 200, f"resp_status {resp_status} is not 200; {resp_text}"

That seems like a long comment, but think it boils down to a routing keys fix, and we add issues to AATH for some other things.

Thanks for the testing @usingtechnology! I'll dig into this when I get a chance.

I'm able to reproduce the issue in my own test environment. Interestingly, it's specific to the connection protocol Admin API. DID Exchange is working fine. Looks like it's a matter of the connection invitation schema being picky about what the routing keys look like.

@usingtechnology @swcurran this PR is ready for review!

Yeah, I think another round of testing is appropriate.

AATH update requirements-main.txt
aries-cloudagent[indy, bbs, askar]@git+https://github.com/hyperledger/aries-cloudagent-python@de09845e4ac32081b2825b448dbb1485c5dbdf5d
acapy-resolver-universal<EMAIL_ADDRESS>
BUILD_AGENTS=acapy-main ./manage build
./manage run -d acapy-main -t @T002-RFC0211,@T004-RFC0211,@T005-RFC0211 -t @RFC0160

Still get the errors like:
      Assertion Failed: FAILED SUB-STEP: And "Acme" receives the connection invitation
      Substep info: Assertion Failed: resp_status 422 is not 200; {"routingKeys": {"0": ["Value did:key:z6MkfsqtL1nN8Rj94LXBxYXRrbYZfz9kvac4Br3LZkJXRDAr is not a raw Ed25519VerificationKey2018 key"]}}
      Traceback (of failed substep):
        File "/usr/local/lib/python3.7/site-packages/behave/model.py", line 1329, in run
          match.run(runner.context)
        File "/usr/local/lib/python3.7/site-packages/behave/matchers.py", line 98, in run
          self.func(context, *args, **kwargs)
        File "features/steps/0160-connection.py", line 152, in step_impl
          assert resp_status == 200, f"resp_status {resp_status} is not 200; {resp_text}"

@usingtechnology I think the commit to checkout should be a8cf6ad684892ff49453662b4843509afc63de89

FYI — when I run PR tests in AATH, I update the requirements-main.txt file to:
aries-cloudagent[indy, bbs, askar]@git+https://github.com/<user>/aries-cloudagent-python@<branch in user’s fork>
acapy-resolver-universal<EMAIL_ADDRESS>
So for this one:
aries-cloudagent[indy, bbs, askar]@git+https://github.com/dbluhm/aries-cloudagent-python@fix/mediation-routing-keys-as-did-key
acapy-resolver-universal<EMAIL_ADDRESS>

When I use the correct commit hash, all looks good. pytests and AATH all check out. Great work!


People Picker doesn't search for groups

Category

[ ] Enhancement
[x] Bug
[ ] Question

Version
Please specify what version of the library you are using: [1.17.0]
Expected / Desired Behavior / Question
People Picker control return SharePoint groups
Observed Behavior
People Picker control doesn't return SharePoint groups
Steps to Reproduce
PropertyFieldPeoplePicker('people', {
  label: 'PropertyFieldPeoplePicker',
  initialData: this.properties.people,
  allowDuplicate: false,
  principalType: [PrincipalType.Users, PrincipalType.SharePoint, PrincipalType.Security],
  multiSelect: true,
  onPropertyChange: this.onPropertyPaneFieldChanged,
  context: this.context,
  properties: this.properties,
  onGetErrorMessage: (value: IPropertyFieldGroupOrPerson[]) => {
    const users = value.filter(u => u.fullName.toLowerCase().indexOf("elio") !== -1);
    return users.length === 0 ? 'Please use a person with "Elio" in its name' : "";
  },
  deferredValidationTime: 0,
  key: 'peopleFieldId',
  targetSiteUrl: this.context.pageContext.site.absoluteUrl
})

hey @AJIXuMuK , can I pick this up ?

The version has been released.


Can you use 'Download Build Artifacts' to download artifacts from a different collection?

Note
Issues in this repo are for tracking bugs, feature requests and questions for the tasks in this repo
For a list:
https://github.com/Microsoft/azure-pipelines-tasks/tree/master/Tasks
If you have an issue or request for the Azure Pipelines service, use developer community instead:
https://developercommunity.visualstudio.com/spaces/21/index.html )
Required Information
Entering this information will route you directly to the right team and expedite traction.
Question, Bug, or Feature?
Type: Question
Enter Task Name: Download Build Artifacts
list here (V# not needed):
https://github.com/Microsoft/azure-pipelines-tasks/tree/master/Tasks
Environment

Server - Azure Pipelines or TFS on-premises? On premise

If using TFS on-premises, provide the version: 18.170.30910.2 (Azure DevOps Server 2020.0.1)

If using Azure Pipelines, provide the account name, team project name, build definition name/build number:

Agent - Hosted or Private:

If using Hosted agent, provide agent queue name:

If using private agent, provide the OS of the machine running the agent and the agent version: Windows Server 2016 1607. Agent version is 2.170.1

Issue Description
I want to download artifacts produced by a build pipeline that is in another collection on the same server. I don't see how to do that. Is it possible?
Task logs
[Enable debug logging and please provide the zip file containing all the logs for a speedy resolution]
Troubleshooting
Checkout how to troubleshoot failures and collect debug logs: https://docs.microsoft.com/en-us/vsts/build-release/actions/troubleshooting
Error logs
[Insert error from the logs here for a quick overview]

Hi @nadcraker could you please create ticket on https://developercommunity.visualstudio.com/search?space=22 to get right eyes on it? This seems to be more related to server-side, rather than task itself.
Could you please also share the link to created ticket here for visibility?

Let me close this ticket here since it's more to be server-side question


Add maps to shuttles tab

Summary of changes
Asana Ticket: Shuttles | Pull shapes (Subway/Shuttles) onto map and Shuttles | Station detail map
All shapes are pulled into the two maps. Second map is zoomed into the selection from the station selector, and both maps filter all shapes based on the selected direction.
This needs one more bit of code to take into account the correct line colors from the latest merge to master. With corrected line colors the end result looks like this:

I love this! I have a few changes I'd like to see, but already I love how this is shaping up.

red X-icon: I don't think we should use that red color + icon to show the affected subway stations. In the shuttle diagram in the sidebar, we're using the same icon to mean something different. I prefer to continue to show a T logo icon for stations, even if they are closed to for that line's service they are still T stations and it makes them clearer against the shuttle icons.
The terminus stops for the subway line shapes should not show an X icon, but use the T station icon. Technically the are open, to the active part of the line.
Stroke changes: in addition to color, I think the width is a little chunky, especially compared to the existing line map. This makes it tough to read some of the street names under the shuttle shapes at different zoom levels. Can we try:

Reduce subway lines stroke-width to 6px.
Update shuttle lines stroke-width: 4px, and stroke-dasharray: 4px, 8px.

Also thought I'd note it, though I don't know what it means: locally I get quite a lot of error output in my server complaining about undefined shapes, though the console in Chrome is clean.

Would it be quite difficult to get a tooltip for each icon?
For example, here's a really rich tooltip in use on the transit-near-me maps.

And the much simpler one on /schedules/../line:

I think we could cause customer confusion if we don't help label these stops somehow.

@ingridpierre Haven't updated this branch yet but I tried the suggested stroke widths and dasharrays, as seen here:

Oh check this out -- on the Green route, the polylines are filtered but the stops are not! @digitalcora might you know what's behind this?
In this case only the D line has shuttle service -- @ingridpierre, I'm guessing we should still show the B, C, and E lines here?

@thecristen I think I do, unfortunately... this synthesized "combo" green line is quite the headache. We need some extra logic to detect if, when multiple routes are requested, only a subset of the routes have diversions — and if so, add in the normal non-diverted shapes for the other routes to the returned collection.


HARVESTER: Cloud provider enhancement

Summary
Cloud provider enhancement

Remove health check
Add annotations when create LB

Occurred changes and/or fixed issues

Harvester PR: https://github.com/harvester/dashboard/pull/309
https://github.com/harvester/harvester/issues/1580
https://github.com/harvester/harvester/issues/1458
https://github.com/harvester/harvester/issues/1762
https://github.com/harvester/harvester/issues/1834

Technical notes summary

Areas or cases that should be tested

Areas which could experience regressions

Screenshot/Video

@n313893254  This pr also needs to be submitted to the release-2.7.4-harvester branch。


Support ORACLE_DATABASE

Should work similar to MYSQL_DATABASE
This variable is optional and allows you to specify the name of a database to be created on image startup. If a user/password was supplied then that user will be granted superuser access (corresponding to GRANT ALL) to this database.

Hey @bahusoid, thanks for that ER, I like it! Just came across a use case for that as well when trying to get some GitHub Actions to run. Will look into it, should not be too hard.

Implemented, new pluggable databases can now be created via the -e ORACLE_DATABASE=<your_DB_name> option at container startup.


Default behavior for DKIM and Microsoft 365 - "period of time"

Under "Default behavior for DKIM and Microsoft 365" it states:

Also, if you disable DKIM signing after enabling it, after a period of time, Microsoft 365 will automatically apply the default policy for your domain.

How long is that period of time?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 249c059f-c3ce-a382-b99e-795a0c1f646a
Version Independent ID: 5656c114-ae16-6194-cd9f-353b33f4a1e1
Content: How to use DKIM for email in your custom domain - Office 365
Content Source: microsoft-365/security/office-365-security/use-dkim-to-validate-outbound-email.md
Service: o365-seccomp
GitHub Login: @MSFTTracyP
Microsoft Alias: tracyp

@Staja Thank you for your feedback. I'm currently testing this and will update the document accordingly.
Thanks
Sri

@MSFTTracyP The document states that if you disable DKIM signing after enabling it, after a period of time, Microsoft 365 will automatically apply the default policy for your domain. However, it doesn’t state what that time is. I disabled DKIM signing last Friday and it has still not applied default policy for my test domain. Could we get this information (the exact amount of time it takes for M365 to automatically apply the default policy) so that the document can be updated?
Thanks
Sri

@MSFTTracyP Please reply to this query. Thanks.

Because this issue was submitted almost two years ago, and there are no comments from the submitter or the author, we will close this issue.
FYI: @yogkumgit


GitHub Issue Validation is not working

The flow is not working on Production.
It has something to do with conection references.

According to the history and the monitor logs I have, this is working correctly now.


Use something other than "types" for action types

Now that we are adding flow, I think we should change types to actions to prevent confusion.
Snippet:
import * as types from "constants/action_types";
reducers[types.FETCH_AVAILABILITY_STARTED] = function(state, action) {
    ....
};

import * as actions from "constants/action_types";
reducers[actions.FETCH_AVAILABILITY_STARTED] = function(state, action) {
    ....
};

See https://github.com/lbryio/lbry-app/pull/652#discussion_r154789628 for my thoughts on approach here


UI should summarise results by default

When constructing operations the UI should default to setting the 'groupBy' field for each element to an empty array. This will mean the result elements will be summarised.

Merged into develop.


PR: Use Preact in production for faster initialization

Willing to make a PR for this.

Could you, please, elaborate more on it? What's some pros and cons? 😅

Preact is a lightweight implementation of the public react API. It is able to initialize faster because its much lighter in weight because it doesnt support older react APIS.
@developit

its much lighter in weight because it doesnt support older react APIS.

That's neat

I had a branch here. Seemed to be working quite nicely:
https://github.com/developit/hyperterm/tree/preact
Would need to be updated/rebased since this was forked a few weeks back.

It sounds interesting. Is there any existing case study of doing something similar?

@krzkaczor There are quite a few examples. Here are three:
https://github.com/ubilabs/react-geosuggest/pull/103
https://github.com/developit/hn_minimal
https://github.com/developit/preact-compat-example
Certainly not exhaustive case-studies, but the conclusion is unanimously the same.

I'e got a small amount of experience with Preact.
One big downside that I've encountered is that Preact offers none of the Synthetic Event normalisation you get in React.  Preact also doesn't offer the ES6 class based API for components, nor flow-type definitions.
I don't know how important any of these are for HyperTerm, but I think those are a couple caveats to be aware of.

Sorry for dropping this issue on the floor! I just felt I should try to clarify a couple things:
I think the recommendation was to use preact-compat, which includes PropType validation, and supports an identical interface to React allowing the use of the existing Flow definitions.
Synthetic Events is indeed an implementation difference. However, it's actually rather unnecessary for web content - particularly in the case of Electron where the target browser is controlled and constant. In this case (and in most evergreens), using a completely custom event system is simply unnecessary complexity.
The branch I linked above, though now quite outdated, demonstrates that there are no issues in porting the code over.
Not meaning to push for anything here since I'm prone to bias, just wanted to clear those things up!
I recall chatting with @rauchg a while back and he noted that there are a relatively small number of actual React components in Hyperterm, since the terminal rendering is handled by hterm (maybe this has changed). I would imagine the value of preact here would be that, if component rendering is a small part of the application compared to state management and the terminal emulation, it might make sense to use a correspondingly small component rendering implementation.
Just my random thoughts on the matter!

afaik preact doesnt implement synthetic events system, so we cant talk about 100% match

can someone try to bench current react implementation? just so we know performance statistics at the start

If what you are looking for is pure performances then Inferno blows both React and PReact out of the water.

@lucsky where did you infer this was a performance suggestion? The goal was to load less script.

@developit Oh, damn, you're right, I was way too quick reading the title of this issue, I stopped at "faster" and missed the "initialization"... Ooops. Sorry about the noise.

Yeah for the tests we ran, Preact yielded much faster initialization due to smaller script. Probably not a noticeable diff for render, since hterm uses a different non-diff system.
I'm interested in revisiting Preact, insofar we can maintain good compatibility with plugins.

yup yup. I can take a crack at an updated PR for this once I've published 7.2.

There hasn't been activity on this issue for quite some time. Unless someone wants to take a shot at this, I think we should close it.

I think we should explore switching to preact now that the renderer (xterm) is canvas based. Our UI is the only thing being rendered by react, so we could probably get a nice speedup and size reduction by switching to Preact.
However there could plugins that depend on full React being available, so this should be tested/thought through before switching.
Are the slight startup time reduction worth breaking some plugins?


Bump Magnum

Bump magnum_tag - support for k8s 1.27 fc38 Calico installed with Helm: Tigera Operator

Is this supposed to be marked as a draft?

Is this supposed to be marked as a draft?

Yes, we're going to rebuild the images once more to fix one issue.

@darmach close in favor of this? #964

Superseded by #964


Babbage header CDDL possibly incorrect

In the CDDL we have:
header_body =
  [ block_number     : uint
  , slot             : uint
  , prev_hash        : $hash32 / null
  , issuer_vkey      : $vkey
  , vrf_vkey         : $vrf_vkey
  , vrf_result       : $vrf_cert ; New, replaces nonce_vrf and leader_vrf
  , block_body_size  : uint
  , block_body_hash  : $hash32 ; merkle triple root
  , operational_cert
  , protocol_version
  ]

operational_cert =
  ( hot_vkey        : $kes_vkey
  , sequence_number : uint
  , kes_period      : uint
  , sigma           : $signature
  )

protocol_version = (major_protocol_version, uint)

which would correspond to a size 14 array for header_body as operational_cert and protocol_version are basic groups (note them having only ( and ) instead of [ and ] or [( and )]).
However I am encountering a size 10 array for all babbage blocks where it is treated as if they were written instead as:
operational_cert =
  [ hot_vkey        : $kes_vkey
  , sequence_number : uint
  , kes_period      : uint
  , sigma           : $signature
  ]

protocol_version = [major_protocol_version, uint]

i.e. they are encoded as array groups instead of raw basic groups.
All previous eras seem to have them encoded as basic groups (i.e. their fields are inlined into the header body). It's possible that there's something going on somewhere in the stack I'm receiving it from but it's supposed to be the raw bytes without changes. If that's the case I'll close the issue, but if not we need to update the babbage.cddl file.

Block serialization logic has moved over to consensus repository starting with Babbage, so that's why CDDL spec can't be checked in ledger code for the block header.
I just looked at the implementation and at a glance it does seem the cddl spec is off. We'll do a proper investigation into this and adjust the spec accordingly.
Thanks for reporting this issue.

This issue also seems to affect the sancho testnet so conway.cddl will need updating as well unless that gets changed before making it to mainnet.

Fixed in #3762


Improve maven build

I've improved the maven pom by

define version in properties block
use maven-bundle-plugin to add osgi mete-data
upgrade dependencies
remove unused dependencies

@lburgazzoli maybe we should use jdk version 1.7 now.

@AdoHe no problem, it was reflecting what was in the build before, I'll amend it

@AdoHe fixed, I've also added a profile to disable doclint on java8


[BUG] update Microsoft.Azure.WebJobs.Extensions.EventGrid to newer version of Microsoft.Extensions.Azure to fix CVE-2024-29992 (transitive via Azure.Identity)

Library name and version
Microsoft.Azure.WebJobs.Extensions.EventGrid v3.4.1
Describe the bug
Microsoft.Azure.WebJobs.Extensions.EventGrid v3.4.1 references Microsoft.Extensions.Azure v1.7.3 which references Azure.Identity v1.11.0 which has a security vulnerability CVE-2024-29992
Azure.Identity >= 1.11.4 contains the fix and is referenced by Microsoft.Extensions.Azure v1.7.4

Expected behavior
using Microsoft.Azure.WebJobs.Extensions.EventGrid does not result in any CVE issues
Actual behavior
Microsoft.Azure.WebJobs.Extensions.EventGrid v3.4.1 results in CVE-2024-29992
Reproduction Steps
any reference to this version results in the CVE being flagged
Environment
No response

@JoshLove-msft:  Would you please take point on getting a new release out?


Roll engine 22522c0b3e69..ee53ae1ea2a3 (1 commits)

https://github.com/flutter/engine/compare/22522c0b3e69...ee53ae1ea2a3
git log 22522c0b3e69..ee53ae1ea2a3 --no-merges --oneline
ee53ae1ea Roll src/third_party/skia 932759e9b414..9c37cd96e4c8 (1 commits) (flutter/engine#6498)
The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

@rmistry @liyuqian : New roll has been created by https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Trybots failed. These were the failed builds: https://cirrus-ci.com/task/5866727759937536 , https://cirrus-ci.com/task/5303777806516224

Commit queue failed; closing this roll.


DOC Add some extra details to the changelog about toast notification and DataObject hydration

@maxime-rainville One more thing - these sections need to be added to the table of contents at the top of the doc.


Build Issue on windows - cd command does not change drive without /d flag

Please make sure that this is a build/installation issue. As per our GitHub Policy, we only address code/doc bugs, performance issues, feature requests and build/installation issues on GitHub. tag:build_template
System information

Windows 10:
TensorFlow installed from (source or binary): building
TensorFlow version: Master
Python version: 3.6
Bazel version (if compiling from source):23.0
GCC/Compiler version (if compiling from source):VS2015
CUDA/cuDNN version:7.1
GPU model and memory:GTX970

Describe the problem
When building with bazel the it fails with the following
`ERROR: D:/phil/python/tensorflow/tensorflow/core/BUILD:2676:1: Executing genrule //tensorflow/core:version_info_gen failed (Exit 1): bash.exe failed: error executing command
cd C:/users/username/_bazel_username/frxyltss/execroot/org_tensorflow
SET CUDA_TOOLKIT_PATH=C:/Program Files/NVIDIA GPU Computing Toolkit/CUDA/v10.1

C:/msys64/usr/bin/bash.exe -c source external/bazel_tools/tools/genrule/genrule-setup.sh; bazel-out/x64_windows-opt/bin/tensorflow/tools/git/gen_git_source.exe --generate external/local_config_git/gen/spec.json external/local_config_git/gen/head external/local_config_git/gen/branch_ref "bazel-out/x64_windows-opt/genfiles/tensorflow/core/util/version_info.cc" --git_tag_override=${GIT_TAG_OVERRIDE:-}
Execution platform: @bazel_tools//platforms:host_platform
D:\Phil\Virtual Environments\tensorflow_compilation\Scripts\python.exe: can't find 'main' module in 'C:\users\yvann'
Target //tensorflow/tools/pip_package:build_pip_package failed to build`
The cause of this is that the tensorflow source directory is on the D drive, but the temporary files are created in the windows user directory that is on the C drive. On windows the cd command does not change drive by default. Thus the line
cd C:/users/username/_bazel_username/frxyltss/execroot/org_tensorflow
will not change the directory if the current working directory is on the D drive. This can be fixed by making the above line cd /d  which will then change drive. Alternatively you can insert cd D:
This command appears to be autogenerated but i cannot easily see how to change it.

Thanks for the reporting, this is a Bazel issue.
I created an Bazel issue at https://github.com/bazelbuild/bazel/issues/7904

As explained in https://github.com/bazelbuild/bazel/issues/7904

What "bazel build -s" prints is decorational.
Bazel doesn't actually shell out to cmd.exe (or Bash, or cd) to change the directory.

So Bazel didn't actually run any cd command, so the build error is caused by some other problem, probably in some TF script.

Where does C:\users\yvann come from?

@phil20686,
We are checking to see if you still need help on this issue. We recommend that you upgrade to 2.6 which is latest stable version of TF and let us know if the issue still persists in newer versions. You can use this guide as a reference while building TF for windows.Thanks!


'NoneType' object has no attribute 'get'

Rasa version:
rasa-nlu            0.14.6
rasa-core           0.13.7
rasa-core-sdk       0.12.2
Python version:
3.6.5
Operating system (windows, osx, ...):
MacOSx, Linux both OS has this issue
Issue:
I was able to train nlu and core without any issues but when i test it using REST as well as cli channel i get the following error
Bot loaded. Type a message and press enter (use '/stop' to exit):  Your input ->  hi                                                                                Exception in thread Thread-13: Traceback (most recent call last):   File "/usr/local/Cellar/python/3.6.5_1/Frameworks/Python.framework/Versions/3.6/lib/python3.6/threading.py", line 916, in _bootstrap_inner     self.run()   File "/usr/local/Cellar/python/3.6.5_1/Frameworks/Python.framework/Versions/3.6/lib/python3.6/threading.py", line 864, in run     self._target(*self._args, **self._kwargs)   File "/usr/local/lib/python3.6/site-packages/rasa_core/channels/channel.py", line 324, in on_message_wrapper     on_new_message(message)   File "/usr/local/lib/python3.6/site-packages/rasa_core/agent.py", line 303, in handle_message     return processor.handle_message(message)   File "/usr/local/lib/python3.6/site-packages/rasa_core/processor.py", line 80, in handle_message     self._predict_and_execute_next_action(message, tracker)   File "/usr/local/lib/python3.6/site-packages/rasa_core/processor.py", line 300, in _predict_and_execute_next_action     action, policy, confidence = self.predict_next_action(tracker)   File "/usr/local/lib/python3.6/site-packages/rasa_core/processor.py", line 161, in predict_next_action     probabilities, policy = self._get_next_action_probabilities(tracker)   File "/usr/local/lib/python3.6/site-packages/rasa_core/processor.py", line 473, in _get_next_action_probabilities     tracker, self.domain)   File "/usr/local/lib/python3.6/site-packages/rasa_core/policies/ensemble.py", line 321, in probabilities_using_best_policy     probabilities = p.predict_action_probabilities(tracker, domain)   File "/usr/local/lib/python3.6/site-packages/rasa_core/policies/fallback.py", line 97, in predict_action_probabilities     nlu_confidence = nlu_data["intent"].get("confidence", 1.0) AttributeError: 'NoneType' object has no attribute 'get'
Content of configuration file (config.yml):
language: "en"

pipeline: spacy_sklearn
policies:
  - name: KerasPolicy
    epochs: 100
    max_history: 5
  - name: FallbackPolicy
    fallback_action_name: 'action_default_fallback'
  - name: MemoizationPolicy
    max_history: 5
  - name: FormPolicy

Content of domain file (domain.yml) (if used & relevant):
actions:
  - utter_unclear
  - utter_greet
intents:
  - greeting
templates:
  utter_unclear:
    - text: "Sorry i dont know"
    - text: "I dont know"
    - text: "I didnt get it"
  utter_greet:
    - text: "hi how are you"
    - text: "great thanks"
    - text: "how are you"

Content of domain file (nlu_data.md) (if used & relevant):
## intent:greeting <!--- The label of the intent -->
- hi
- hello
- hey
- hi hi
- hey hey
- hey hi

Please let me know

Hey @karthikbalu, thank you for raising this issue! This is a known bug which is fixed in the master branch and new versions. If you need to fix this in you version, replace line 96 of rasa_core/policies/fallback.py to nlu_confidence = nlu_data.get("intent", {}).get("confidence", 1.0)


String Translation for "User Reacted with"

Cannot find the  string for translation of "Reacted With" when you mouseover on a reaction.

I've just added these in as translations in 1.1.10, try updating to latest!


Make slurm container start on boot

Slurm is started when install.sh script is run, but after reboot the slurm container will not be running.
Using a systemd service like here to start the slurm container during boot.

Decided to let attendees start Docker containers


[APPLE-3198] Remove Parkinson code from AppCore

Overview
APCDataArchiver contains Parkinson specific code which should be in subclasses of APCBaseTaskViewController. APCDataArchiver does not use new upload components, and relies upon generating filenames by extracting arguments from [ORKFileResult fileURL] which no longer supports containing a resultIdentifier or stepIdentifier.
Actions

Deprecate all public methods in APCDataArchiver.
Move any code to retain from APCDataArchiver to APCBaseTaskViewController.
Make ORKFileResult+Filename public in case of use by subclasses of APCBaseTaskViewController.
Update APCDataArchive method signatures to remove extension parameters. Pass a complete filename instead.
Remove methods in APCDataArchive which were intended to handle extracting filenames from a fileURL.
Use APCDataArchiveUploader in APCBaseTaskViewController to upload APCDataArchive instances.

Tests
Tested by running all activities in Parkinson, Cardio, and Diabetes and confirming successful data upload compliant to database scheme using APCDataVerificationDaemon. Some changes are required at the app level which will be supplied in forthcoming pull requests.

r=me.


UID is changed after token refresh

Discussed in https://github.com/mobizt/Firebase-ESP-Client/discussions/201

Originally posted by sNapppppp December  2, 2021
Hi,
I'm new to this and this might be a stupid question. So, I'm using Email/Password for authentication. In the first hour my code is working perfectly, until there is this message on serial monitor:
Token info: type = id token, status = on refreshing
Token info: type = id token, status = ready

Anything after that will give me an error message: Permission denied.
I tried to see what is inside auth.token.uid variable by print it to serial monitor, turns out it was changed from 3AqbIKT8nXYzXYKfOLGZGhhS9dG2 to 3600 after token refreshed.
Here is my Firebase RTDB rules:
{
  "rules": {
    "UsersData": {
      "$uid": {
        ".read": "auth != null && auth.uid == $uid",
        ".write": "auth != null && auth.uid == $uid"
      }
    }
  }
}

Now I understand that I get Permission denied because of uid was changed, but I don't understand why it become 3600? Can anyone help me, please?
On readme I also found that authentication using email and password is not require token generation and time setup, but how to disable token generation?
Here is my firebase setup code:
  config.api_key = API_KEY;
  auth.user.email = USER_EMAIL;
  auth.user.password = USER_PASSWORD;
  config.database_url = DATABASE_URL;
  Firebase.reconnectWiFi(true);
  fbdo.setResponseSize(4096);
  config.token_status_callback = tokenStatusCallback;
  config.max_token_generation_retry = 5;
  Firebase.begin(&config, &auth);

and this is the loop:
    if (millis() - dataMillis > 60000 && Firebase.ready()) {
        dataMillis = millis();
        String path = "/UsersData/";
        path += auth.token.uid.c_str(); //<- user uid of current user that sign in with Email/Password

        String distancePath = path + "/Distance/" + String(epochTime);
        Serial.printf("Upload distance: %s\n", Firebase.RTDB.setInt(&fbdo, distancePath.c_str(), distance) ? "Success!" : fbdo.errorReason().c_str());

        String tempPath = path + "/Temperature/" + String(epochTime);
        Serial.printf("Upload temperature: %s\n", Firebase.RTDB.setFloat(&fbdo, tempPath.c_str(), temp) ? "Success!" : fbdo.errorReason().c_str());
    }

Fixed in v2.7.1.


Secondary classes in Java files aren't included in builds

For example:
public class Foo {
}
class Bar {
}

Looks like the trouble was actually to do with signatures, not the compiler as such.

Looks like the trouble was actually to do with signatures, not the compiler as such.


Add stack blockchain client tutorial

This PR

adds a new tutorial for the Stacks Blockchain API client
addresses #779

Thank you for the feedback. I will update the tutorial.
I would like to keep it as one tutorial. With some recent improvements of the libs, some parts will be simplified a bit. Also I can cut the read-only part a bit.

I have reduced the content and addressed most of the comments.
For the screenshots, I am waiting for a response from @jasperjansz

@agraebe do you want to prioritize the relevant design work here with @jasperjansz on the DevX side since you're managing docs? Or prefer we take it on UserX since we created the Todos app originally?

Hey @friedger, let me know if this helps you out.
UI for the "new registration" message:
https://www.figma.com/file/Edt4xQgxC8Q1fM87qsn1Jy/Tutorials-and-sample-apps?node-id=133%3A111
In your tutorial, you can reuse the markdown from the docs homepage to copy this section:

It will look better than just text:

authorize it

@aulneau could you look into that please?

I have added screenshots and reduced the length of the tutorial.
@agraebe The screenshots don't look good. What are the requirements for the size?

I have added screenshots and reduced the length of the tutorial.
@agraebe The screenshots don't look good. What are the requirements for the size?

I just had a quick look at the preview deploy and I think they look ok. What issue do you see? @aulneau might be able to tell if there are some clear requirements

@friedger I'd love to finalize this and merge it in. what was the issue you saw?

@agraebe In my preview my screenshots looked squeezed, but if this is fine here. I am happy to merge it!

@friedger I just checked it out locally and the images seem fine. I fixed some content issues though!
@markmhx, @jasperjansz and @hstove. I will merge this by EOW - please have one last look at this and let me know if there's something that needs to be updated

It appears Vercel needs a kick to test this on staging:

It appears Vercel needs a kick to test this on staging:

@aulneau could you authorize if it makes sense?

I addressed the comments, the PR should probably be squashed.

:tada:


Self-signed URLs for upload

Similar to S3, would be nice to be able to get a self-signed URL, so my application could upload directly an image to PictShare without going via backend.
I don't want to expose the secret to upload the images on my frontend application.
So right now to solve that issue, I upload the image to my backend, and then the backend uploads to the pictshare.
My suggestion would be a way to accept uploads from the frontend without having the secret in there.

Not quite sure what you mean. You want the ability to upload to pictshare without using pictshare?

@daminufe , what is the difference between to use  'UPLOAD_CODE' and the 'self-signed URL'?.  If i have your  'self-signed URL' ,  can i upload images in your server?

@chrisiaut it's exactly like AWS S3 allows to do.
http://docs.aws.amazon.com/AmazonS3/latest/dev/PresignedUrlUploadObject.html
Look at this schema:

In a nutshell, my backend only creates a signed token that is known on the PictShare, to upload directly to it without making the image going to my backend.

@chrisiaut any idea on that?

imho not worth it at the moment unless you want to send a pull request


Need separate place on tutorial page for teacher workflows

These need to be separated out so that the teachers can clearly see them and get access.

no update after 2015. i am closing it.


Regression in display logic

The change to src/ActionsGridFieldItemRequest.php in https://github.com/lekoala/silverstripe-cms-actions/pull/22/files#diff-b7a004efabbd9cbfe65185f34b596f2aa2af6736d611d4a034b76f7b2e4f42b5R107 from @Firesphere  had introduced a breaking change - action buttons stopped being displayed for fresh and readonly items.
There may be any number of reasons to continue displaying the action buttons for the readonly records:

provide some external links
some programmatic actions on the object itself
shorthand actions for the related objects
...etc

However, the above mentioned change stopped displaying the buttons altogether.
I'm suggesting to revert the changes related to the introduced checkCan() method.

@gurucomkz so hopefully this is fixed in https://github.com/lekoala/silverstripe-cms-actions/releases/tag/1.3.10


Tweak build (FW8)

This PR is for running the build over and over and seeing what happens.

This change is

Finally found the real issue, and opened #248 and #249 to deal with it. So this PR can be closed now.


Set the next version to Data Prepper 1.3.0.

Description
Updated the version to 1.3.0-SNAPSHOT in preparation for the the 1.3.0 release.
Issues Resolved
[List any issues this PR will resolve]
Check List

[x] New functionality includes testing.
[x] New functionality has been documented.

[x] New functionality has javadoc added

[ ] Commits are signed with a real name per the DCO

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Codecov Report

Merging #670 (8ec7efc) into main (fd09fb5) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##               main     #670   +/-   ##
=========================================
  Coverage     91.65%   91.65%
  Complexity      606      606
=========================================
  Files            75       75
  Lines          1834     1834
  Branches        152      152
=========================================
  Hits           1681     1681
  Misses          117      117
  Partials         36       36

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fd09fb5...8ec7efc. Read the comment docs.


fix kafka start without data

Codecov Report

Merging #226 into master will increase coverage by 0.02%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #226      +/-   ##
==========================================
+ Coverage   69.22%   69.25%   +0.02%
==========================================
  Files         155      155
  Lines       20700    20702       +2
==========================================
+ Hits        14330    14337       +7
+ Misses       5267     5263       -4
+ Partials     1103     1102       -1

Impacted Files
Coverage Δ

datanode/bootstrap/options.go
0% <ø> (ø)
:arrow_up:

redolog/kafka_redolog_manager.go
75.14% <100%> (+0.29%)
:arrow_up:

subscriber/common/job/driver.go
71.27% <0%> (+0.7%)
:arrow_up:

memstore/cuckoo_index.go
91.27% <0%> (+1%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 97653ad...6af3741. Read the comment docs.


When parsing 'all_sources' should be a list of unique dirs

resolves #5120
Description
When two (or more) of the "-paths" settings point to the same directory, the "all_sources" method will return duplicate directory names, causing the attempt to parse the same files twice.
Checklist

[x] I have read the contributing guide and understand what's expected of me
[x] I have signed the CLA
[x] I have run this code in development and it appears to resolve the stated issue
[x] This PR includes tests, or tests are not required/relevant for this PR
[x] I have opened an issue to add/update docs, or docs changes are not required/relevant for this PR
[x] I have run changie new to create a changelog entry

@leahwicz or @jtcohen6 should this be backported to 1.1.latest for the next patch?

I would be ok backporting this since its a bug and it's a minimal change (most changes are involving test conversion)

Yeah, it's only a couple of lines. I'll backport without the tests.


Use a custom Filer that doesn't have things Bramble doesn't use

Filer isn't small, and there's no point in us including bits of it we don't use in Bramble.  I'd like to see us figure out the set of things we need from fs and shell and do a custom version for Bramble.  This can either be done upstream or we can just fork it (Filer is pretty much done at this point).

Here's what we use:
impls/filer/FilerFileSystem.js:        fs.stat(path, function(err, stats) {
impls/filer/FilerFileSystem.js:        fs.exists(path, function(exists) {
impls/filer/FilerFileSystem.js:        fs.readdir(path, function (err, contents) {
impls/filer/FilerFileSystem.js:        fs.mkdir(path, mode, function (err) {
impls/filer/FilerFileSystem.js:        fs.rename(oldPath, newPath, _wrap(updateBlobURL));
impls/filer/FilerFileSystem.js:        fs.readFile(path, encoding, function (_err, _data) {
impls/filer/FilerFileSystem.js:        fs.writeFile(path, data, encoding, function (err) {
impls/filer/FilerFileSystem.js:        fs.readFile(path, encoding, function (_err, _data) {
impls/filer/FilerFileSystem.js:        fs.stat(path, function(err, stats) {
impls/filer/FilerFileSystem.js:        watchers[path] = fs.watch(path, {recursive: true}, function(event, filename) {

That's stat, exists, readdir, mkdir, rename, readFile, 'writeFile, and watch.  At the moment, we don't use anything in the Shell; however, when I do the zip/unzip stuff, I'll need some things, so we shouldn't remove the Shelltotally--as long asFiler` still has it, I can extend it when I need to use that stuff.
Probably the best way to approach this problem is to use dead-code removal with the Closure compiler in a build step.  It lets you define a set of function/variable names to keep, and kills off anything else that doesn't have a caller.

https://developers.google.com/closure/compiler/docs/api-tutorial3 shows how to do this.

I don't think this is worth doing.  I did an experiment with aggressive dead code removal, and even then it only saved 15K or 20K.  Closing.


Posting with mashmallow schema

@incognick @timothycrosley How can I map the body json with a mashmallow schema like:
def post(input: userschema, response): and use input instead of body

@jshwelz I believe you could use something like this to map params:
@hug.post("/test", map_params={"body": "input"})
def post(input: userschema, response):
    return input

@jshwelz I believe you could use something like this to map params:
@hug.post("/test", map_params={"body": "input"})
def post(input: userschema, response):
    return input

that works thanks


Enable deprecation logging for deprecated methods currently used by Android plugin

Android plugin uses the following methods that are being deprecated:

DependencySubstitutions.Substitution.with
AbstractCompile.setDestinationDir(Provider<File>)
CompileOptions.setAnnotationProcessorGeneratedSourcesDirectory(File)

When a new version of Android plugin is released, update the tests and reevaluate whether deprecation logging can be enabled for those methods.
This requires 7.0.0 line of the Android plugin.

If the corresponding Android Plugin release does not happen before the 7.1 release branching, please move the milestone to 7.2 RC1.

CompileOptions removal: https://github.com/gradle/gradle/pull/17105
AbstractCompile removal: https://github.com/gradle/gradle/pull/21660
DependencySubstitutions removal: https://github.com/gradle/gradle/issues/21661
As these deprecated methods are already removed/being addressed by other 8.0 issues, I'm closing this issue.


Release 1.12.0

coverage: 36.569%. remained the same
when pulling 571e01541554d258e81e63edf5a9cd4358a76bd9 on release_1.12.0
into e373131ae1ed39475c6b9910b12e823bd39d7ab4 on master.


Add a command to get the current synced version from cros-sdk directory

We can query the synced version by portageq-${board} envvar PORTAGE_BINHOST.
This is good for synced up the DUT with currently checked out cros-sdk.

I'd like to try this one, but I need clarifications.
The following is an example output for brya on my local workstation
 gs://chromeos-prebuilt/board/amd64-generic/postsubmit-R116-15505.0.0-52093-8778090689467554065/packages gs://chromeos-prebuilt/board/amd64-generic/postsubmit-R116-15505.0.0-52094-8778089119028579249/packages gs://chromeos-prebuilt/board/amd64-generic/postsubmit-R116-15505.0.0-52095-8778086878663453457/packages gs://chromeos-prebuilt/board/amd64-generic/postsubmit-R116-15505.0.0-52096-8778085176293458977/packages gs://chromeos-prebuilt/board/brya/postsubmit-R116-15505.0.0-83679-8778090996123150033/packages gs://chromeos-prebuilt/board/brya/postsubmit-R116-15505.0.0-83680-8778090645377985841/packages gs://chromeos-prebuilt/board/brya/postsubmit-R116-15505.0.0-83681-8778089074903851649/packages gs://chromeos-prebuilt/board/brya/postsubmit-R116-15505.0.0-83682-8778086834597103329/packages gs://chromeos-prebuilt/board/amd64-generic/cq-R116-15502.0.0-52012-8778246588928878481/packages

Can I just pick the version string (R116-15505.0.0) from the first entry?
How does the CLI look like? (under sync? or a new command like repo?)

@mhiramat I found that I filed the bug already, so please close this once the implementation is done!!!!


Add assets weights to get_monte_carlo() output

Now method get_monte_carlo() returns risk/return DataFrame.
For practice purposes it is important to have weights for every randon portfolio.

Resolved with https://github.com/mbk-dev/okama/commit/1d8b479c983d6c7725c747e957e698670f033b5a


.Center class needs space after running Inky

See: https://github.com/zurb/foundation-emails/issues/7#issuecomment-166670665
This could have a larger effect on other classes within the framework.

Should be fixed via zurb/inky#2


Test fails in date module

Since the data in the tests is chosen randomly, it's possible for a test not to work every time, and for a bug to remain undiscovered if the tests are only run a few times.
The following test failed while I was coding other tests for issue #153:
[ RUN      ] DateTest.shouldGenerateBirthDateByRangeYear
/path/faker-cxx/src/modules/date/DateTest.cpp:150: Failure
Expected: (birthdate.tm_year + 1900) >= (1990), actual: 1989 vs 1990

In theory it's not my code that's causing it to fail, but I'm still investigating to be sure.

By spamming make test command, I've managed to find another test from the date module that sometimes fails:
[ RUN      ] DateTest.shouldGenerateBirthDateByExactYear
/home/plouc/faker-cxx/src/modules/date/DateTest.cpp:141: Failure
Expected equality of these values:
  birthdate.tm_year + 1900
    Which is: 1995
  1996

Ok thanks for investigating that, I will take a look.

I found the problem!
In this function, the tm_mday attribute is set to 0 for the lower bound (line 87). However, a month starts on the 1st, so the lower bound is set to midnight on 31 December when it should be on 1 January at midnight.
Setting the variable to 1 definitely solves the problem. I'll do the PR.

Good job, I was also looking at the problem right now, and there was a problem with parsing ISO date in tests in parseISOFormattedStringToTm() and parseISOFormattedStringToTimePoint() functions, I fixed it: https://github.com/cieslarmichal/faker-cxx/pull/168. It took local time instead of UTC and shifted hours but we dont want that,
So we managed to find two bugs in there, nice :smile:

Marking as resolved


Fast style transfer demo

Here's my initial PR for fast style transfer demo.
Few things:

I have no idea why the demo-header and demo-footer won't show up on my demo... I've checked for any difference with the other demos and I can't figure it out. Can't shake the feeling I'm missing something super obvious.
The checkpoints are not included in this commit. Should probably upload it to your Google Cloud instead of directly to this repository.
Let me know if the FAQ and credits below the whole thing should be removed to make it more similar to the other demos.

This change is

This is a wonderful contribution, thank you for taking the time to check it into demos. Great work!
 I really regret adding it in the first place. Daniel and I will debug header / footer stuff after this is checked in.
Yup, uploading to Google Cloud SGTM. Can you upload the weights / manifest somewhere zipped up for me to download (Google Drive should work).
FAQ seems reasonable to me! :)

Other high level comments:

Unfortunately the typescript files need license headers, can you copy the license headers from the other TS files?
Once you check this in - do you care if I change a few things? We have a designer in house that we can consult to make it pretty. I can also see if live webcam style transfer is reasonable (even if it's laggy, it will still be cool, and on beefy graphics card it may not be super unreasonable).

Reviewed 2 of 13 files at r1.
Review status: 2 of 13 files reviewed at latest revision, 7 unresolved discussions.

demos/fast-style-transfer/fast-style-transfer.ts, line 274 at r1 (raw file):

  }

  private drawOnCanvas(ndarray: Array3D) {

Ah, here is where you're going to see a bottleneck. We have utilities that let you draw a texture directly to canvas, without ever doing a CPU download. This should improve performance. We do this in a couple demos, imagenet & nn-art
What you should do is the following:

Construct your GL from the canvas that you want to draw to like this:
https://github.com/PAIR-code/deeplearnjs/blob/master/demos/nn-art/cppn.ts#L75

In the constructor, call this function and save the shader program:
https://github.com/PAIR-code/deeplearnjs/blob/64814ca08c5c4724bdc91c9ccde82893169dcd26/src/math/webgl/render_ndarray_gpu_util.ts#L22
Something like this:
this.renderShader = render_ndarray_gpu_util.getRenderRGBShader(this.gpgpu, destinationWidth where destinationWidth is the width in pixels of the output canvas. If this changes, you may have to build a new render shader.

 You don't have to give it the canvas because you constructed the WebGLRenderContext (this.gl) from the canvas and this method will bind the canvas to the framebuffer and render.

demos/fast-style-transfer/net.ts, line 8 at r1 (raw file):

    document.URL.substr(0,document.URL.lastIndexOf('/')) + '/ckpts/';

export class TransformNet {

can you make this extend Model? Then loadVariables should become load and infer should become predict.

demos/fast-style-transfer/net.ts, line 8 at r1 (raw file):

    document.URL.substr(0,document.URL.lastIndexOf('/')) + '/ckpts/';

export class TransformNet {

can you link to the checkpoint you used / an arxiv paper / website?

demos/fast-style-transfer/net.ts, line 17 at r1 (raw file):

   * variables have all been loaded.
   */
  loadVariables(): Promise<void> {

Can you short circuit if the variables have been loaded (this.variables != null)?
I noticed in your demo that you have to download weights again every time you press style transfer.

demos/fast-style-transfer/styletransfer.html, line 161 at r1 (raw file):

  <input type="file" id="fileSelect" style="display: none" accept="image/x-png,image/gif,image/jpeg"/>

remove the comment

demos/fast-style-transfer/styletransfer.html, line 181 at r1 (raw file):

What is this?

This is an implementation of the Fast Neural Style Transfer algorithm running purely on the browser using the Deeplearn.JS library. Basically, a neural network attempts to "draw" one picture, the Content, in the style of another, the Style.

"Deeplearn.JS" => "deeplearn.js"

demos/fast-style-transfer/styletransfer.html, line 202 at r1 (raw file):

The authors of the paper introducing Real-Time Style Transfer.

The author of the fast-style-transfer Github repository.

The authors of Deeplearn.JS

"Deeplearn.JS" => "deeplearn.js"

Comments from Reviewable

Once you check this in - do you care if I change a few things? We have a designer in house that we can consult to make it pretty. I can also see if live webcam style transfer is reasonable (even if it's laggy, it will still be cool, and on beefy graphics card it may not be super unreasonable).

Sure, no problem! If you go with live webcam style transfer, I would suggest to keep the cam snapshot option. I think the majority of low-power laptops will have trouble if it's continuously processing.
Anyway, I'm currently having a problem with rendering straight to the canvas. Pretty sure I followed all your steps correctly. Right now I'm trying to render not the result image, but the Content image just to debug things. It renders into the canvas but the picture is in black and white so there's definitely something wrong.. If I try to render the actual result image, I don't get anything at all.

The render code expects value between 0 - 1, can you make sure you've normalized the output? If that doesn't work, could you stage the HTML / JS into a github pages so I can step through it?
Sure, I'll make sure we keep static image loading from the webcam.

Review status: 0 of 13 files reviewed at latest revision, 7 unresolved discussions, some commit checks failed.

Comments from Reviewable

Ahh that makes sense, the previous code rendered with 0-255 so I assumed the same. It works now.
I think I've addressed all your comments. Have one problem though, when the short circuit for variable loading "activates", the button for "Start Style Transfer" doesn't become disabled anymore. I've noticed the same problem before - while the image is running through the net, I couldn't change parts of the UI to show the status. I think this has something to do with not being able to render the UI while GPU processing is taking place? Do you have any suggestions to handle this?
PS. Not sure where the Travis error is from, when I run npm run lint --silent on my computer it doesn't error out.

Here's the Drive link with the checkpoints.
https://drive.google.com/drive/folders/1mbC_TC50CIJqOhHPaKnpj9ObJZD6sJsu?usp=sharing

Ah sorry about that, yeah we updated the workflow. Demos have their own package now, so you just have to run npm run prep which will do 2 npm installs. Apologies.
Checkpoints are uploaded under http://storage.googleapis.com/learnjs-data/checkpoint_zoo/transformnet/
For example:
http://storage.googleapis.com/learnjs-data/checkpoint_zoo/transformnet/la_muse/manifest.json
LGTM after this - will merge.
Thank you so much for bearing with me :)

Reviewed 10 of 13 files at r1, 3 of 3 files at r5.
Review status: all files reviewed at latest revision, 3 unresolved discussions, some commit checks failed.

demos/fast-style-transfer/fast-style-transfer.ts, line 259 at r5 (raw file):

  async runInference() {

remove blank line

demos/fast-style-transfer/net.ts, line 68 at r3 (raw file):

      const outTanh = this.math.tanh(convT3);
      const scaled = this.math.scalarTimesArray(Scalar.new(150), outTanh);
      const shifted = this.math.scalarPlusArray(Scalar.new(255./2), scaled);

can you construct these scalars in the constructor, this allocates and uploads a new NDArray each pass through and will leak textures and cause performance issues

demos/fast-style-transfer/net.ts, line 43 at r5 (raw file):

  async load(): Promise<void> {
    if (this.variableDictionary[this.style] == null) {
      console.log('downloading weights for first time');

remove console log

Comments from Reviewable

Done.
Do you have any suggestions for this comment?

Have one problem though, when the short circuit for variable loading "activates", the button for "Start Style Transfer" doesn't become disabled anymore. I've noticed the same problem before - while the image is running through the net, I couldn't change parts of the UI to show the status. I think this has something to do with not being able to render the UI while GPU processing is taking place? Do you have any suggestions to handle this?

There are lots of reasons this can happen, but I don't see any obvious reasons in your code as is.
I can merge this, then I'll start a demo / debug it and we can iterate. Does that sound okay to you?

Review status: 11 of 13 files reviewed at latest revision, 3 unresolved discussions, some commit checks failed.

Comments from Reviewable

Sure!


Upgrade to be compatible with Ngrx 8

I'm still not sure how to test if my updates work.   This one was a little more in-depth than the Ngrx 7 upgrade.    Can you provide any assistance?

thx!!

thx!!

Did I miss something?  I don't see a new npm version out there for the version 8.


Translate Code Splitting

[x] Bundling
[x] Code Splitting
[x] Route based splitting
[x] Named Exports

@Haqverdi are you ready to merge this in? It doesn't seem like there are a lot of you so it might not be a good idea to have two reviewers per page.

@Haqverdi are you ready to merge this in? It doesn't seem like there are a lot of you so it might not be a good idea to have two reviewers per page.

Yes, I checked the main parts, everything seems to be okay, unfortunately we are 2-3 people for now,  therefore have to do so in order to translate as soon as possible.

@tesseralis I have checked the content and there are some issues (typos, grammar issues). I will push them, once they are all fixed.

I think we should translate the main part as soon as possible, then correct the shortcomings


Teva 1899 compare open prs review apps

Jira ticket URL
https://dfedigital.atlassian.net/browse/TEVA-1899
Changes in this PR:

Shell script to query for currently-deployed apps in the teaching-vacancies-review space, and remove if the GitHub Pull Request is not in status open
Add GH Actions workflow to trigger this (initially an on-demand action)

Rather than scripting a reconciliation, will focus on ensuring review apps are created and destroyed through workflows

Rather than scripting a reconciliation, will focus on ensuring review apps are created and destroyed through workflows


Migrate from termcolor to anstream

anstream provides the same feature set as termcolor (including legacy windows support) but with a less awkward API to work with.  Instead of hand-constructing data in a special container with each step requiring setting the style, you use whatever styling library you like (e.g. color-print like in #12578) and then write to the appropriate stream, and you are done.  The stream does all the rest, allowing styling to be decoupled from where it is being rendered.
So anstream would replace

termcolor
fwdansi
strip-ansi-escapes

Benefits

Lower boilerplate way to style text while leaving Shell in control (see cargo adds use of Shell::write_stderr)
Open the door for styling within messages
Lower overhead as it only intercepts when something needs changing.  This will be especially true in switching from fwdansi to anstream
Strip API is significantly faster than strip-ansi-escapes
Centralize color schemes between Shell (currently using termcolor) and clap (using anstyle)

anstream should work fine for how we use termcolor / fwdansi.  There is a locking bug we might run into if we do anything past that and I'm currently working on it, so I'd recommend holding off on this until then.

triage: @rustbot label S-blocked-external
Since epage is working on it from dependency side.


Fix gemspec to include assets directory

Fix current release of rubocop 1.4.0 that not includes the assets directory used by html report.
rubocop --format html --out tmp/rubocop.html

No such file or directory @ rb_sysopen - /Users/javierav/.asdf/installs/ruby/2.5.0/lib/ruby/gems/2.5.0/gems/rubocop-1.4.0/assets/output.html.erb

It seems we overoptimized this. :-) Just add a changelog entry and we're good to go here.

Done @bbatsov, but now some tests failed in CI... 🤔

Those seem like some random failures. Thanks!

@javierav Thanks for the fix!
@bbatsov Sorry for this, I should've grepped the project for assets folder references - I genuinely thought I did. A lesson for the future.


Multi layer screen, element not identified

If you see the inspector shows my listview has an id, but when I try to waitFor() or expect() - it doesn't identify the element and my test fails.
await waitFor(element(by.id('myarray'))).toBeVisible().withTimeout(4000)

I am looking to click on the element GET TO KNOW YOU inside this listview.
I have tried to do element(by.label()) and by.text - even by.accessibilityLabel() but no luck.
When I spoke to the devs they said, that they have a layer-upon-layer for that listview. I am assuming detox is not able to identify that layer.

output log line for the element
send: {"type":"invoke","params":{"target":{"type":"Invocation","value":{"target":{"type":"Class","value":"GREYCondition"},"method":"detoxConditionForElementMatched:","args":[{"type":"Invocation","value":{"target":{"type":"EarlGrey","value":"instance"},"method":"detox_selectElementWithMatcher:","args":[{"type":"Invocation","value":{"target":{"type":"Class","value":"GREYMatchers"},"method":"detoxMatcherForBoth:and:","args":[{"type":"Invocation","value":{"target":{"type":"Class","value":"GREYMatchers"},"method":"matcherForAccessibilityID:","args":["myarray"]}},{"type":"Invocation","value":{"target":{"type":"Class","value":"GREYMatchers"},"method":"matcherForSufficientlyVisible","args":[]}}]}}]}}]}},"method":"waitWithTimeout:","args":[{"type":"CGFloat","value":4}]},"messageId":6}

How can I resolve this? Please help.

Hey @kagalenitin,
What is this inspector ? Looks like an interesting tool.
Detox uses EarlGrey to match views, it only looks on the views which are actually drawn (natively in iOS), try debugging the view hierarchy inside Xcode and see if you can find the view you're looking for.
Additionally, read the following section regarding custom components

@rotemmiz https://github.com/appium/appium-desktop

Hey guys,  this tool is called macaca app inspector:
https://macacajs.github.io/app-inspector/
I believe it uses Xcode underneath. I ll try your idea and see if it shows anything different.

@kagalenitin this happens when your TouchAbleOpacity is accessible true, pls change it as accessible false and you should see all the elements
<TouchableOpacity onPress={this.handleCheckboxPressed}
             accessible={false}
             activeOpacity={1}
             testID={`checkboxIcon_${checkboxState}`}
             accessibilityLabel={`checkboxIcon_${checkboxState}`} >

@kagalenitin @saikrishna321 Hey, guys, try to use a helper to define testIDs:
import { Platform } from 'react-native'

export default function testID(id) {
  return Platform.OS === 'android' ?
    { accessible: true, accessibilityLabel: id } :
    { testID: id }
}

We're using it across all the app. It helps!

@isnifer so whats the client you use to for appium android test?

@saikrishna321 I see "webdriverio": "4.7.1" in our package.json

I tried the steps mentioned by @rotemmiz - And noticed that the XCode shows me the screen elements of previous screens on the app under test. I have reached out to the devs and see if they can help. I would like to know if this is usual? I have used other tools such as uiautomatorviewer and appium android test and they only show the screen elements.

Hello,
We are moving support questions to Stack Overflow. Please ask a question there with the detox tag. This section is only meant for Detox issues and enhancement requests.
Thanks


Ctrl+Alt+Arrow for multi-select fails on laptops and tablets

VSCode Version: 1.2.0
OS Version: Windows 10 10586

I can't use keyboard based multi-select in the editor on my laptop (desktop is fine). Whenever I use Ctrl+Alt+Down instead of multi-select, my screen turns upside down. It's a Windows shortcut key to invert a screen.
Visual Studio doesn't have this problem because it uses Alt+Shift+Arrow as the shortcut for multi-select.

All keybindings can be customized. https://code.visualstudio.com/docs/customization/keybindings#_customizing-shortcuts
This issue is most likely caused by some Display Driver which can be configured to not globally react to these keybindings if you don't find the screen rotation useful.


Added Divisors Algorithms in Mathematical Algorithms folder.

This PR introduces two algorithms implemented in C to efficiently calculate the number of divisors and the sum of divisors for a given integer. Both algorithms leverage the mathematical properties of prime factorization, ensuring optimal performance even for larger integers.
Documentation:
Comprehensive documentation is provided, including a detailed time complexity analysis and explanations of the algorithms.

issue number not found

@pankaj-bind  This PR was related to issue #315 which was assigned to me.
Please look into it.
Thanks!


bugfix: support ESP32

use my fork of AsyncPing that supports ESP32

fixes #3

does not work because the underlying esp-idf forbids raw socket magic.


Extended fails to start under 25 players due to meteors

#28974 seemed to have accidentally made extended require 25 players due to meteors requiring it.
https://github.com/space-wizards/space-station-14/pull/28974/files#diff-0b2783a8b6f2617fdebc3dcf1a266fb09be2ddd7f9bfc4e587f89c9e62fe1b58R33-R35

Will be fixed by #29044


The clear button in the left panel (editor) does not clear the results in the right panel

Appreciate the effort in creating this amazing tool, just found a small user experience glitch which I thought worth notifying!!
Description:
The bin button in the left panel which is used to clear the content of left panel/editor should also clear the adjacent transformed result in the right panel as well instead of persisting it.
Small screen capture: link

I would be more than happy to fix and send a PR


Capture RAISE LOG/WARNING/etc from plpgsql functions using Prisma.TransactionClient

Problem
Some database operations raise warnings or notices during execution, and those can be captured by the other pg clients,. eg node-postgres
client.on('notice', msg => console.warn('notice:', msg))

On prisma, as it has a connection pool by default, I think it will be eaiser to only support this when using the Prisma.TransactionClient
Suggested solution
'ideal' API:
  await this.prisma.$transaction(async (prismaTxn: Prisma.TransactionClient) => {
       prismaTxn.on('notice', msg => console.warn('notice:', msg))
       // other code that will produce warnings
  });

Not so good, but still good
  await this.prisma.$transaction(async (prismaTxn: Prisma.TransactionClient) => {
       // other code that will produce warnings
  }, {
      isolationLevel: 'Serializable',
      onNotice: msg => console.warn('notice:', msg)
  });

Additional context
See discussion at https://github.com/prisma/prisma/discussions/15943#discussioncomment-4167517

On prisma, as it has a connection pool by default, I think it will be eaiser to only support this when using the Prisma.TransactionClient

Can you elaborate why you assume this?

Hello @janpio
I have no knowledge of the internals of prisma, but I think that in order to support this feature on shared connections some kind o a buffer would need to be kept for each node client and keep switching at each statement run on the db which client should get it (I think this may already exists as it's needed to send the results back to the right client) but that could also complicate this feature when running over Data Proxy, should the notices be called back to each client that participate in the query?
This is also very rare to have notices over normal insert/update statements, afaik it's only possible if they have triggers -- on my use-case I'm using stored procedures with queryRaw, and the output has some useful debugging that could be put somewhere in the UI if I had it handy

Hello,
I have a similar need but mainly for migration (even if it could be great to have I on transaction too).
My need is that I write custom SQL migration because prisma can't do typescript migration (another issue but it is needed too) and that I need to update data. And sometimes I have a lot of stuff going on and to debug at least, it's great to have so logs to follow what's going on. And if the migration fails, it would be great to have these logs to be able to debug things further.

Just adding my support for this. It would be really nice to be able to capture the debug statements in the app like other pg clients support.

As reading here, MrVhek said he's using this for migration, I also did ended up capturing those events on migration as well, and ended up using module pg for that, as for migration I also needed support for multiple executes into the same batch/query command
https://github.com/prisma/prisma/discussions/25349
As to get those log's is usually emitted per-connection and not per pool, in the pg-pool it could be handled like this:
    const connection = await pool.connect();
    connection.on('error', function (msg) {
        logger.error(msg);
    });
    connection.on('notification', function (msg) {
        logger.verbose(JSON.stringify(msg));
    });
    connection.on('notice', function (msg) {
        if (msg.severity !== 'NOTICE') logger.error(JSON.stringify(msg));
        if (msg.severity === 'NOTICE') logger.verbose(msg.message);
    });

reference:
https://github.com/AppCivico/smae/blob/homol/backend/bin/pgsql-migrate.ts#L131-L141


EDU-1243 Refer to comments more specifically as documentComments

Closes https://educandu.atlassian.net/browse/EDU-1243
I could not believe how deep this completely unused feature permeates through the codebase. And I did not rename all occurences (I left some local usages of the shorthand "comment" or when used referring to the DOC_VIEW called "comments" rather than to the entity documentComment) :no_good:

Closes https://educandu.atlassian.net/browse/EDU-1243
I could not believe how deep this completely unused feature permeates through the codebase. And I did not rename all occurences (I left some local usages of the shorthand "comment" or when used referring to the DOC_VIEW called "comments" rather than to the entity documentComment) no_good

I noticed the same, how much setup and logic there is for the 10 comments there are in the database... Maybe now with notifications things will change a bit.
Very tedious renaming, thanks for doing this! pray Could not spot anything problematic, at a glance. Looks good to me +1

Cool. Now if we wanna do the same thing with documentRevisions it might get more tedious :grimacing:


zoomIn function not focus to center of the screen

Describe the bug
Please look at the demo here: https://codepen.io/hongquan-vn/pen/bGoKyjg
When we click to ZoomIn, ZoomOut buttons, the hall is zoomed to the right bottom corner, instead of the center of the screen.
Not sure if it is a bug, or I didn't use Panzoom correctly, please help!
Your environment

Version of panzoom: 4.4.3
Browser and browser version: Firefox v95.0.1 Linux

Expected behavior
When clicking to ZoomIn, ZoomOut buttons, the hall should be zoomed at the center of the screen.
Actual behavior
It is zoomed at the right bottom corner.
Steps to reproduce
https://codepen.io/hongquan-vn/pen/bGoKyjg

Thanks for opening an issue. It looks like your image is starting out with it's left at 0. zoomIn and zoomOut don't set translations by default. They rely on the native browser behavior. In this case, the transform-origin is already set to "50% 50%". In other words, it is zooming in and out on the center of the Panzoom element, but because the image is so large and because it's left is at zero, the center of the Panzoom element is down and to right. If re-orient the element to center from the start, you should start seeing zoomIn and zoomOut centered on the image. Hope that helps.

@timmywil I think you misunderstood me. I don't mean to be center at the image, but the center of the screen. Like in this demo https://timmywil.com/panzoom/demo/, no matter where you put the image, the zoom is still centered at viewport.
Another way to understand the issue is that, in the https://codepen.io/hongquan-vn/pen/bGoKyjg, you scroll the mouse wheel until the image is smaller than the viewport, then you click the zoom buttons, you still see that the center of the zoom is somewhere very far to the right bottom, outside the image.

I understand, but I should have been more clear. The zoom doesn't happen towards the center of the image wherever it is. The zoom happens there because that's where the center of the image was at its original position and size. You can change that by starting the image centered, or you can zoom in on the point at the center of the viewport using the zoomToPoint method.


Node-sass is outdated

The installed version of node-sass is outdated and has a reference to an invalid location for the prebuilt bindings, causing the style compilation to fail. Currently the only way is to look the file up in it's new location and download it.
I would much appreciate either fixing this problem with additional scripts or a newer version of node-sass (gulp-sass).

Thanks for the issue report. Should be fixed in v0.11.4.