[BUG] Two nodes upgrade failed in Pre-drained the first node then lost VIP connectivity

Describe the bug

When we upgrade from v1.1.0 to v1.1.2-rc4, the process stuck in the Pre-drained the first node

We notice the node 1 IP change to <IP_ADDRESS> instead of the original fixed IP <IP_ADDRESS>
The node 1 display error kubelet stop posting node status

After a while, we lost the VIP connection to Harvester dashboard

The console UI display Setting up Harvester and the Management URL is Unavailable

We can still ssh to node 1 and node2, but unable to use kubectl command

To Reproduce
Steps to reproduce the behavior:

Prepare fixed node IP and VIP on dhcpd config file
Provision the two v1.1.0 nodes Harvester on bare machines
Create the vlan 1 network on management interface
Create a cluster network and network config bind on ens 7 and ens8
Create the vlan 101 network with manual route <IP_ADDRESS>/24 , <IP_ADDRESS>
Integrate Harvester to Rancher v2.6.11 and provision a RKE2 guest cluster
Set node and disk tag on Host page
Create a new storage class and set as the default one
Create three virtual machines separate on each node and use different network we created before
Setup backup target
Backup all VMs
Perform offline upgrade to v1.1.2-rc4

Expected behavior

Can successfully pass all upgrade process to the end without losing VIP connectivity.
Support bundle

Failed to get support bundle since we lost the VIP connectivity
Also the k9s and kubelet command not working on each node
Environment

Harvester ISO version: v1.1.0 to v1.1.2-rc4
Underlying Infrastructure (e.g. Baremetal with Dell PowerEdge R630): two nodes on bare machines

Additional context
Add any other context about the problem here.

The network environment consist of one isc-dhcp service for handling Harvester installation config file

IPv4 allocation range: <IP_ADDRESS> - <IP_ADDRESS>

And one Asus Router to provide tagged vlan network

IPv4 allocation range: <IP_ADDRESS> - <IP_ADDRESS>

In the /etc/dhcpd.conf, we set fixed IP assignment of the following pattern
group {
  # create group
  if exists user-class and option user-class = "iPXE" {
    # iPXE Boot
    if option architecture-type = 00:07 {
      filename "http://<IP_ADDRESS>/ipxe-create-efi";
    } else {
      filename "http://<IP_ADDRESS>/ipxe-create";
    }
  } else {
    # PXE Boot
    if option architecture-type = 00:07 {
      # UEFI
      filename "ipxe.efi";
    } else {
      # Non-UEFI
      filename "undionly.kpxe";
    }
  }

  host node1 {
    hardware ethernet e4:54:e8:7c:f3:d4;
    fixed-address <IP_ADDRESS>;
    server-name "node1";

  }

}

Here is the IP state on failed node 1

node1:~ # ip a
1: lo: <LOOPBACK,UP,LOWER_UP> mtu 65536 qdisc noqueue state UNKNOWN group default qlen 1000
    link/loopback 00:00:00:00:00:00 brd 00:00:00:00:00:00
    inet <IP_ADDRESS>/8 scope host lo
       valid_lft forever preferred_lft forever
2: enp4s0f0: <NO-CARRIER,BROADCAST,MULTICAST,UP> mtu 1500 qdisc mq state DOWN group default qlen 1000
    link/ether 00:1b:21:38:57:30 brd ff:ff:ff:ff:ff:ff
3: eno1: <BROADCAST,MULTICAST,SLAVE,UP,LOWER_UP> mtu 1500 qdisc pfifo_fast master mgmt-bo state UP group default qlen 1000
    link/ether e4:54:e8:7c:f3:d4 brd ff:ff:ff:ff:ff:ff
    altname enp0s31f6
4: enp4s0f1: <NO-CARRIER,BROADCAST,MULTICAST,UP> mtu 1500 qdisc mq state DOWN group default qlen 1000
    link/ether 00:1b:21:38:57:31 brd ff:ff:ff:ff:ff:ff
5: enp179s0f0: <BROADCAST,MULTICAST,UP,LOWER_UP> mtu 1500 qdisc mq state UP group default qlen 1000
    link/ether 00:1b:21:38:5c:78 brd ff:ff:ff:ff:ff:ff
6: enp179s0f1: <BROADCAST,MULTICAST,UP,LOWER_UP> mtu 1500 qdisc mq state UP group default qlen 1000
    link/ether 00:1b:21:38:5c:79 brd ff:ff:ff:ff:ff:ff
7: mgmt-br: <BROADCAST,MULTICAST,UP,LOWER_UP> mtu 1500 qdisc noqueue state UP group default qlen 1000
    link/ether e4:54:e8:7c:f3:d4 brd ff:ff:ff:ff:ff:ff
    inet <IP_ADDRESS>/24 brd <IP_ADDRESS> scope global mgmt-br
       valid_lft forever preferred_lft forever
8: mgmt-bo: <BROADCAST,MULTICAST,MASTER,UP,LOWER_UP> mtu 1500 qdisc noqueue master mgmt-br state UP group default qlen 1000
    link/ether e4:54:e8:7c:f3:d4 brd ff:ff:ff:ff:ff:ff

The dhcp server log

Mar 28 15:53:50 localhost.localdomain dhcpd[2771]: DHCPREQUEST for <IP_ADDRESS> from e4:54:e8:7c:f3:d4 via eth2: lease <IP_ADDRESS> unavailable.
Mar 28 15:53:50 localhost.localdomain dhcpd[2771]: DHCPNAK on <IP_ADDRESS> to e4:54:e8:7c:f3:d4 via eth2
Mar 28 15:53:51 localhost.localdomain dhcpd[2771]: DHCPDISCOVER from e4:54:e8:7c:f3:d4 via eth2
Mar 28 15:53:51 localhost.localdomain dhcpd[2771]: DHCPOFFER on <IP_ADDRESS> to e4:54:e8:7c:f3:d4 via eth2
Mar 28 15:53:51 localhost.localdomain dhcpd[2771]: Dynamic and static leases present for <IP_ADDRESS>.
Mar 28 15:53:51 localhost.localdomain dhcpd[2771]: Remove host declaration node1 or remove <IP_ADDRESS>
Mar 28 15:53:51 localhost.localdomain dhcpd[2771]: from the dynamic address pool for <IP_ADDRESS>/24
Mar 28 15:53:51 localhost.localdomain dhcpd[2771]: DHCPREQUEST for <IP_ADDRESS> (<IP_ADDRESS>) from e4:54:e8:7c:f3:d4 via eth2
Mar 28 15:53:51 localhost.localdomain dhcpd[2771]: DHCPACK on <IP_ADDRESS> to e4:54:e8:7c:f3:d4 via eth2

The dhcp lease record on Asus RT-AC86U Router

The node initially has the IP <IP_ADDRESS> and after rebooting its IP is changed to <IP_ADDRESS>. Thus RKE2 can't start:
Mar 28 07:56:35 node1 rke2[2084]: time="2023-03-28T07:56:35Z" level=info msg="Defragmenting etcd database"
Mar 28 07:56:35 node1 rke2[2084]: time="2023-03-28T07:56:35Z" level=info msg="Waiting for etcd server to become available"
Mar 28 07:56:35 node1 rke2[2084]: time="2023-03-28T07:56:35Z" level=info msg="Waiting for API server to become available"
Mar 28 07:56:35 node1 rke2[2084]: time="2023-03-28T07:56:35Z" level=info msg="Tunnel server egress proxy waiting for runtime core to become available"
Mar 28 07:56:36 node1 rke2[2084]: time="2023-03-28T07:56:36Z" level=info msg="Failed to test data store connection: this server is a not a member of the etcd cluster. Found [node1-babfd130=https://<IP_ADDRESS>:2380], expect: node1-babfd130=https://<IP_ADDRESS>:2380"

After fixing the network issue, the node has its IP back, but the etcd still can't start:
Mar 28 18:16:59 node1 rke2[26263]: time="2023-03-28T18:16:59Z" level=info msg="Starting rke2 v1.24.11+rke2r1 (23bdc987de9658eb80a5e03862ab34efdecf6d4e)"
Mar 28 18:16:59 node1 rke2[26263]: time="2023-03-28T18:16:59Z" level=info msg="Managed etcd cluster bootstrap already complete and initialized"
Mar 28 18:16:59 node1 rke2[26263]: time="2023-03-28T18:16:59Z" level=info msg="Starting temporary etcd to reconcile with datastore"
Mar 28 18:16:59 node1 rke2[26263]: {"level":"info","ts":"2023-03-28T18:16:59.495Z","caller":"embed/etcd.go:131","msg":"configuring peer listeners","listen-peer-urls":["http://<IP_ADDRESS>:2400
"]}
Mar 28 18:16:59 node1 rke2[26263]: {"level":"info","ts":"2023-03-28T18:16:59.495Z","caller":"embed/etcd.go:139","msg":"configuring client listeners","listen-client-urls":["http://<IP_ADDRESS>:
2399"]}
Mar 28 18:16:59 node1 rke2[26263]: {"level":"info","ts":"2023-03-28T18:16:59.495Z","caller":"embed/etcd.go:308","msg":"starting an etcd server","etcd-version":"3.5.4","git-sha":"Not provide
d (use ./build instead of go build)","go-version":"go1.19.6 X:boringcrypto","go-os":"linux","go-arch":"amd64","max-cpu-set":8,"max-cpu-available":8,"member-initialized":true,"name":"node1-b
abfd130","data-dir":"/var/lib/rancher/rke2/server/db/etcd-tmp","wal-dir":"","wal-dir-dedicated":"","member-dir":"/var/lib/rancher/rke2/server/db/etcd-tmp/member","force-new-cluster":true,"h
eartbeat-interval":"500ms","election-timeout":"5s","initial-election-tick-advance":true,"snapshot-count":10000,"snapshot-catchup-entries":5000,"initial-advertise-peer-urls":["http://127.0.0
.1:2400"],"listen-peer-urls":["http://<IP_ADDRESS>:2400"],"advertise-client-urls":["http://<IP_ADDRESS>:2399"],"listen-client-urls":["http://<IP_ADDRESS>:2399"],"listen-metrics-urls":[],"cors":["*"]
,"host-whitelist":["*"],"initial-cluster":"","initial-cluster-state":"new","initial-cluster-token":"","quota-size-bytes":2147483648,"pre-vote":true,"initial-corrupt-check":true,"corrupt-che
ck-time-interval":"0s","auto-compaction-mode":"","auto-compaction-retention":"0s","auto-compaction-interval":"0s","discovery-url":"","discovery-proxy":"","downgrade-check-interval":"5s"}
Mar 28 18:16:59 node1 rke2[26263]: {"level":"info","ts":"2023-03-28T18:16:59.541Z","caller":"etcdserver/backend.go:81","msg":"opened backend db","path":"/var/lib/rancher/rke2/server/db/etcd
-tmp/member/snap/db","took":"45.458124ms"}
Mar 28 18:17:00 node1 rke2[26263]: {"level":"info","ts":"2023-03-28T18:17:00.184Z","caller":"etcdserver/server.go:508","msg":"recovered v2 store from snapshot","snapshot-index":140015,"snap
shot-size":"7.5 kB"}
Mar 28 18:17:00 node1 rke2[26263]: {"level":"warn","ts":"2023-03-28T18:17:00.197Z","caller":"snap/db.go:88","msg":"failed to find [SNAPSHOT-INDEX].snap.db","snapshot-index":140015,"snapshot
-file-path":"/var/lib/rancher/rke2/server/db/etcd-tmp/member/snap/00000000000222ef.snap.db","error":"snap: snapshot file doesn't exist"}
Mar 28 18:17:00 node1 rke2[26263]: {"level":"panic","ts":"2023-03-28T18:17:00.197Z","caller":"etcdserver/server.go:515","msg":"failed to recover v3 backend from snapshot","error":"failed to
 find database snapshot file (snap: snapshot file doesn't<EMAIL_ADDRESS>cdserver/server.go:515\ngo.etcd.io/etcd/server/v3/embed.StartEtcd\n\t/go/pkg/mod/github.com/k3s-io/etcd/server/v3@v3.5.4-k3s1/embed/etcd.go:245\ngithub.com/k3s-io/k3s/pkg/daemons/executor.(
*Embedded).ETCD\n\t/go/pkg/mod/github.com/k3s-io/k3s@v1.24.11-0.20230214211922-74ed4bef6191/pkg/daemons/executor/etcd.go:30\ngithub.com/k3s-io/k3s/pkg/etcd.(*ETCD).StartEmbeddedTemporary\n\
t/go/pkg/mod/github.com/k3s-io/k3s@v1.24.11-0.20230214211922-74ed4bef6191/pkg/etcd/etcd.go:890\ngithub.com/k3s-io/k3s/pkg/cluster.(*Cluster).reconcileEtcd\n\t/go/pkg/mod/github.com/k3s-io/k
3s<EMAIL_ADDRESS><EMAIL_ADDRESS>server.go:267\ngithub.com/k3s-io/k3s/pkg/daemons/control.Server\n\t/go/pkg/mod/github.com/k3s-io/k3s@v1.24.11-0.20230214211922-74ed4bef6191/pkg/daemons/control/server.go:34\ngithub.com/k3s-
io/k3s/pkg/server.StartServer\n\t/go/pkg/mod/github.com/k3s-io/k3s@v1.24.11-0.20230214211922-74ed4bef6191/pkg/server/server.go:59\ngithub.com/k3s-io/k3s/pkg/cli/server.run\n\t/go/pkg/mod/gi
thub.com/k3s-io/k3s<EMAIL_ADDRESS>1-0.20230214211922-74ed4bef6191/pkg/cli/server/server.go:46\ngithub.com/rancher/rke2/pkg/rke2.Server\n\t/source/pkg/rke2/rke2.go:123\ngithub.com/rancher/rke2/pkg/cli/cmds.ServerRun\n\t/sour
ce/pkg/cli/cmds/server.go:162\ngithub.com/urfave/cli.HandleAction\n\t/go/pkg/mod/github.com/urfave/cli@v1.22.9/app.go:524\ngithub.com/urfave/cli.Command.Run\n\t/go/pkg/mod/github.com/urfave
/cli@v1.22.9/command.go:173\ngithub.com/urfave/cli.(*App).Run\n\t/go/pkg/mod/github.com/urfave/cli@v1.22.9/app.go:277\nmain.main\n\t/source/main.go:23\nruntime.main\n\t/usr/local/go/src/run
time/proc.go:250"}
Mar 28 18:17:00 node1 rke2[26263]: panic: failed to recover v3 backend from snapshot
Mar 28 18:17:00 node1 rke2[26263]: goroutine 1 [running]:
Mar 28 18:17:00 node1 rke2[26263]: go.uber.org/zap/zapcore.CheckWriteAction.OnWrite(0x1?, 0x0?, {0x0?, 0x0?, 0xc00098e220?})

Mar 28 18:17:00 node1 rke2[26263]:         /go/pkg/mod/github.com/k3s-io/k3s@v1.24.11-0.20230214211922-74ed4bef6191/pkg/server/server.go:59 +0x93
Mar 28 18:17:00 node1 rke2[26263]: github.com/k3s-io/k3s/pkg/cli/server.run(0xc000397ce0, 0x4faa900, {0x0, 0x0, 0x9?}, {0xc000a4c878, 0x0, 0x0?})
Mar 28 18:17:00 node1 rke2[26263]:         /go/pkg/mod/github.com/k3s-io/k3s@v1.24.11-0.20230214211922-74ed4bef6191/pkg/cli/server/server.go:459 +0x2b71
Mar 28 18:17:00 node1 rke2[26263]: github.com/k3s-io/k3s/pkg/cli/server.RunWithControllers(...)
Mar 28 18:17:00 node1 rke2[26263]:         /go/pkg/mod/github.com/k3s-io/k3s@v1.24.11-0.20230214211922-74ed4bef6191/pkg/cli/server/server.go:46
Mar 28 18:17:00 node1 rke2[26263]: github.com/rancher/rke2/pkg/rke2.Server(_, {{0xc0003b2f14, 0x43}, {0x0, 0x0}, {0x0, 0x0}, {{0x0, 0x0}, {0x0, ...}, ...}, ...})
Mar 28 18:17:00 node1 rke2[26263]:         /source/pkg/rke2/rke2.go:123 +0x545
Mar 28 18:17:00 node1 rke2[26263]: github.com/rancher/rke2/pkg/cli/cmds.ServerRun(0xc000397ce0?)
Mar 28 18:17:00 node1 rke2[26263]:         /source/pkg/cli/cmds/server.go:162 +0xa5
Mar 28 18:17:00 node1 rke2[26263]: github.com/urfave/cli.HandleAction({0x2bbe200?, 0x32f4168?}, 0x6?)
Mar 28 18:17:00 node1 rke2[26263]:         /go/pkg/mod/github.com/urfave/cli@v1.22.9/app.go:524 +0x50
Mar 28 18:17:00 node1 rke2[26263]: github.com/urfave/cli.Command.Run({{0x31624b4, 0x6}, {0x0, 0x0}, {0x0, 0x0, 0x0}, {0x318d6e0, 0x15}, {0xc000610768, ...}, ...}, ...)
Mar 28 18:17:00 node1 rke2[26263]:         /go/pkg/mod/github.com/urfave/cli@v1.22.9/command.go:173 +0x65b
Mar 28 18:17:00 node1 rke2[26263]: github.com/urfave/cli.(*App).Run(0xc000afea80, {0xc0000b4d80, 0x11, 0x12})
Mar 28 18:17:00 node1 rke2[26263]:         /go/pkg/mod/github.com/urfave/cli@v1.22.9/app.go:277 +0x8a7
Mar 28 18:17:00 node1 rke2[26263]: main.main()
Mar 28 18:17:00 node1 rke2[26263]:         /source/main.go:23 +0xb3e
Mar 28 18:17:00 node1 systemd[1]: rke2-server.service: Main process exited, code=exited, status=2/INVALIDARGUMENT
Mar 28 18:17:00 node1 systemd[1]: rke2-server.service: Failed with result 'exit-code'.
Mar 28 18:17:00 node1 systemd[1]: rke2-server.service: Unit process 2307 (containerd-shim) remains running after unit stopped.
Mar 28 18:17:00 node1 systemd[1]: Failed to start Rancher Kubernetes Engine v2 (server).
Mar 28 18:17:05 node1 systemd[1]: rke2-server.service: Scheduled restart job, restart counter is at 42.
Mar 28 18:17:05 node1 systemd[1]: Stopped Rancher Kubernetes Engine v2 (server).


Update intro.md

H1 had a space missing

Docs Build status updates of commit d5a4880:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

teams/docs-conceptual/intro.md
:white_check_mark:Succeeded
View (teams-ps)

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

Docs Build status updates of commit bc8adef:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

teams/docs-conceptual/intro.md
:white_check_mark:Succeeded
View (teams-ps)

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


update lexicons (2023-02-02)

This is a bigger change, deprecates/deletes some custom code, and isn't complete, so passing along for review.
The main thing is updates of api/bsky/* and api/atproto/* based on today's upstream Lexicon files. I didn't run lexgen on the new com.atproto.admin and com.atproto.reports schemas, because lexgen failed on some new corner cases and features. I did update lexgen to handle a subset of new patterns (like CAR file output, with corresponding mimetype). I also used the atproto and bsky package names, respectively, getting rid of schemagen.
One the destructive changes here is removing a bunch of "peering" lexicons, which are not in upstream. The codegen'd files are in git history, so we could pull these back in the future. It seems like these lexicons were not wired up, though maybe there just isn't any test coverage touching on dynamic typing code paths.
There is also a breaking change going from com.atproto.sync.getRoot to com.atproto.sync.getHead; will need to update (or deprecate) some hand-rolled code to finish that transition.
I didn't (yet) update ./gen/main.go to do CBOR gen on any new types.

Changes to lexgen look good to me, assuming the rest is just running the codegen, yeah?

@whyrusleeping: yeah, basically a clean codegen (wiping all existing codegen code first), then small tweaks to get things to compile.
@devinivy: right! should have thought to do that before: https://github.com/bluesky-social/indigo/issues/10

(rebased and merged manually)


Entity Search - limits ignored - can't pass in "body"

So this all pertains to the core/discovery/purview.py (PurviewDiscoveryClient)
Current desire
Search for entities using particular attributes to get a list returned, using either the "body" argument or specifying individual arguments.
All my tests have been using the search_entities method;
With the current code it seems that I cannot pass in a "body" parameter to search_entities and have it work. There is mention on other methods of being able to do this. If that was the intention, I have code to correct that already.
The specifying of a limit  doesn't seem to limit the number of records returned. It seems it return groups at a time, but the client still gets all of the records. This is primary a function of the _search_generator method. Again, I don't know if this is a bug or is intentional and my assumptions are wrong. If the intention is to use the limit to control the API calls but still return everything then it's working as you intended.
I have some changes to make this perform as I would expect, I just don't know if it is already operating as you intended.
I'm happy to submit a PR for my changes but want to ensure it's not going against your original intentions.
Regards,
Nick Jacobsen

Hi, @nickjacobsen - search_entities is a general convenience wrapper that tries to make it easier to use the /query Purview API without having to implement paging yourself and support existing, older code that was written prior to updating the PurviewDiscoveryClient that PurviewClient defaults to.
You should be able to pass the same search filter body to the filter field. body supersedes keywords and filters.
You are absolutely right, though, I see the gap in search_entitites. Normally, you should have been able to pass the body parameter and argument as a kwarg but I cut it off!  That can definitely be revised. If you already have code written up for it, awesome!  Otherwise, I'm thinking of something like the following in the _search_generator method. Pop the known / no side effect kwargs and then pass any along otherwise.
_offset = kwargs.pop("starting_offset") if "starting_offset" in kwargs else 0
_keywords = kwargs.pop("keywords") if "keywords" in kwargs else None
_filter = kwargs.pop("filter") if "filter" in kwargs else None
_facets = kwargs.pop("facets") if "facets" in kwargs else None
_taxonomySetting = kwargs.pop("taxonomySetting") if "taxonomySetting" in kwargs else None
_limit = kwargs.pop("limit") if "limit" in kwargs else 1000

while True:
    results = self.query(
        keywords=_keywords,
        filter=_filter,
        facets=_facets,
        taxonomySetting=_taxonomySetting,
        api_version=kwargs["api_version"],
        limit=_limit,
        offset=_offset,
        **kwargs
    )

Lastly, with respect to limit, what were your expectations?  If you say "limit=100" do you expect it to only return the top 100 results?  The docstring and the Purview REST API doc say that limit is for the number of results per page or per API call. If you set a limit of 100, you will get (at most) 100 results per page and if there are more than 100 results remaining from your offset, you can query the next page by incrementing your offset.
So, "limit" acts on the page level and not on the total number of search results. I hope that helps clarify. Looking forward to any additional feedback or PRs!

Hi @wjohnson,
Thanks for getting back to me so promptly. I like your idea about popping the known kwargs, that did catch me out, I worked around it a different way. But I'm happy to revisit my code and submit it back as a PR.
When using the limit parameter on search_entities I would expect to get back that many records. ie If I had set limit to 100 I would expect to get 100 records back. Then I can control it with the starting_offset to do paging.
When calling seach_entities with a limit of x, it loops in _search_generator (in pages of limit size x), each a separate call to the API,  until no records are returned and then finishes the loop, which seems contrary to what you are saying.

Re: Limit - If you want to control when you call the next batch, you should
use the query method instead. Search_entities is a convenience wrapper over
query.
If it’s any consolation, since it’s a generator, it still processes one
batch at a time and then calls the query api to fetch the next results
after you’ve completed processing a given batch.
Re: PR, if you felt comfortable sharing, I’d be happy to take a look
enabling the kwargs approach!
On Sun, Jan 23, 2022 at 11:02 PM nickjacobsen @.***>
wrote:

Hi @wjohnson https://github.com/wjohnson,
Thanks for getting back to me so promptly. I like your idea about popping
the known kwargs, that did catch me out, I worked around it a different
way. But I'm happy to revisit my code and submit it back as a PR.
When using the limit parameter on search_entities I would expect to get
back that many records. ie If I had set limit to 100 I would expect to
get 100 records back. Then I can control it with the starting_offset to
do paging.
When calling seach_entities with a limit of x, it loops in
_search_generator (in pages of limit size x), each a separate call to the
API, until no records are returned and then finishes the loop, which seems
contrary to what you are saying.
—
Reply to this email directly, view it on GitHub
https://github.com/wjohnson/pyapacheatlas/issues/184#issuecomment-1019721767,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAICLF5YYQR2ZMGVGUMWFF3UXTMPDANCNFSM5MT4Y3BA
.
You are receiving this because you were mentioned.Message ID:
@.***>


GTK# integration disabled

When using the AddinMaker, the GTK# integration is disabled.
The project types {86F6BF2A-E449-4B3E-813B-9ACC37E5545F};{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC} prevents the project to add a New Dialog for example; the command New Dialog is still there but the AddFile dialog does not show them.
The workaround is to temporarily remove the ProjectTypes from the .proj file, do the integration and re-enable the project types again.

Happy to take patches to fix this, but I don't generally use the GTK# designer myself. I'd recommend XWT for new code.


Search Function no longer works

Can’t reproduce this. Search appears to work fine on mobile and desktop.

I guess it's just specific to my machine then


Akismet not working

I have added akismet configuration to the _config.yml file,but it seems not to work.TOTAL API CALLS is always zero.

sorry:smile:,my bad,didn't read the document carefully

just want to note that after adding akismet variables to the config.production.json
"AKISMET_SITE": "https://website.com"
"AKISMET_API_KEY": "akismetapikey"

I had to set an environment varable to tell node to use the production config
I added this line to /etc/environment
NODE_ENV=production


Time picker

Time picker  is needed with date or separately
I use your date picker and it's better than other Persian packages in some ways.
But it doesn't have date picker.
I think, the ability of pick date and time in just one picker is good but if we could have this optional and can separate time and date picker it is a perfect one.

Hi @ahmadmrj, sorry for the latency in response. Would publishing a separate time picker with lots of dedicated features resolve your issue? or it should be integrated to this date picker?

Thanks for your reply.
As I mentioned before, the ideal case would be having both options. but
currently I need separate timepicker element.
Regards.
On Sat, Feb 22, 2020 at 2:25 PM Kiarash Zarinmehr<EMAIL_ADDRESS>wrote:

Hi @ahmadmrj https://github.com/ahmadmrj, sorry for the latency in
response. Would publishing a separate time picker with lots of dedicated
features resolve your issue? or it should be integrated to this date picker?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/Kiarash-Z/react-modern-calendar-datepicker/issues/115?email_source=notifications&email_token=ACQ3Y6PQFSJ7MGFKULM5DVLREEADZA5CNFSM4KYHLGC2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEMU5HGA#issuecomment-589943704,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ACQ3Y6OUESUGZK5GRPZLSGDREEADZANCNFSM4KYHLGCQ
.

I would consider publishing a rich separate time picker with some integrating options to this date picker! BTW, you said that

it's better than other Persian packages in some ways.

Do you have any specific suggestions to improve this date picker?  It would be massively appreciated

Yes, I do. The date picker popup should  be able to open on top or bottom
of the input field depending on the page and form design. Your popup just
can be open on bottom. Having an option or being fluid according to space
around the input can improve your package.
On 22 Feb 2020 2:39 p.m., "Kiarash Zarinmehr"<EMAIL_ADDRESS>wrote:

I would consider publishing a rich separate time picker with some
integrating options to this date picker! BTW, you said that
it's better than other Persian packages in some ways.
Do you have any specific suggestions to improve this date picker? It would
be massively appreciated
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/Kiarash-Z/react-modern-calendar-datepicker/issues/115?email_source=notifications&email_token=ACQ3Y6NGHHYGT3ZKWSDRPCTREEBXTA5CNFSM4KYHLGC2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEMU5WXI#issuecomment-589945693,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ACQ3Y6LBVX4MQDUYIEKJCB3REEBXTANCNFSM4KYHLGCQ
.

That's nice. I will consider it in the following version for sure.

@ahmadmrj In the latest version(3.0.1), the date picker aligns perfectly from any side. Check it out! 🎉

Hey Kiarash,
Is it any config key to set align?

On 11/03/2020, at 8:08 PM, Kiarash Zarinmehr<EMAIL_ADDRESS>wrote:
3.0.1

@ahmadmrj Yes, you can change align manually by calendarPopperPosition  prop.


How to get ElasticsearchDomainArn and ElasticsearchDomainEndpoint output?

Is this related to a new or existing Amplify category?
api
Is this related to another service?
ElasticSearch
Describe the feature you'd like to request
I have created a lambda with the command amplify add function called syncUserByRole. To this function, I want to pass it the ElasticSearchDomainEndpoint and Arn, so I tried this:
In the backend-config.json I added as attributes to the dependsOn the ElasticSearch outputs from the Stack SearchableStack which is found in amplify/backend/api/[MyAPI]/build/stacks/SearchableStack.json, like this:
"syncUserByRole": {
  "build": true,
  "providerPlugin": "awscloudformation",
  "service": "Lambda",
  "dependsOn": [
    {
      "category": "api",
      "resourceName": "ecommerceproject",
      "attributes": [
        "GraphQLAPIIdOutput",
        "GraphQLAPIEndpointOutput",
        "ElasticsearchDomainArn",
        "ElasticsearchDomainEndpoint"
      ]
    }
  ]
}

Then, in the cloudformation of the function (syncUserByRole-cloudformation-template.json) I added:
"Parameters": {
    "CloudWatchRule": {
      "Type": "String",
      "Default": "NONE",
      "Description": " Schedule Expression"
    },
    "deploymentBucketName": {
      "Type": "String"
    },
    "env": {
      "Type": "String"
    },
    "s3Key": {
      "Type": "String"
    },
    "apiecommerceprojectGraphQLAPIIdOutput": {
      "Type": "String",
      "Default": "apiecommerceprojectGraphQLAPIIdOutput"
    },
    "apiecommerceprojectGraphQLAPIEndpointOutput": {
      "Type": "String",
      "Default": "apiecommerceprojectGraphQLAPIEndpointOutput"
    },
    "apiecommerceprojectElasticsearchDomainArn": { // new param added manually
      "Type": "String",
      "Default": "apiecommerceprojectElasticsearchDomainArn"
    },
    "apiecommerceprojectElasticsearchDomainEndpoint": { // new param added manually
      "Type": "String",
      "Default": "apiecommerceprojectElasticsearchDomainEndpoint"
    }
}

So I thought it should work, the main stack (amplify/backend/awscloudformation/nested-cloudformation-stack.yml) has the right params:
"functionsyncUserByRole": {
  "Type": "AWS::CloudFormation::Stack",
  "Properties": {
    "TemplateURL": "https://s3.amazonaws.com/amplify-ecommerceproject-develop-100856-deployment/amplify-cfn-templates/function/syncUserByRole-cloudformation-template.json",
    "Parameters": {
      "deploymentBucketName": "amplify-ecommerceproject-develop-100856-deployment",
      "s3Key": "amplify-builds/syncUserByRole-554c5652485157444c35-build.zip",
      "apiecommerceprojectGraphQLAPIIdOutput": {
        "Fn::GetAtt": [
          "apiecommerceproject",
          "Outputs.GraphQLAPIIdOutput"
        ]
      },
      "apiecommerceprojectGraphQLAPIEndpointOutput": {
        "Fn::GetAtt": [
          "apiecommerceproject",
          "Outputs.GraphQLAPIEndpointOutput"
        ]
      },
      "apiecommerceprojectElasticsearchDomainArn": {
        "Fn::GetAtt": [
          "apiecommerceproject",
          "Outputs.ElasticsearchDomainArn"
        ]
      },
      "apiecommerceprojectElasticsearchDomainEndpoint": {
        "Fn::GetAtt": [
          "apiecommerceproject",
          "Outputs.ElasticsearchDomainEndpoint"
        ]
      },
      "env": "develop"
    }
  }
},

But It does not :(.
The Stack of the API does not have the outputs of ElasticSearch, How can I add them? This is important for me please :(.
Thank you!
Describe the solution you'd like
Just share the outputs of ElasticsearchDomainArn and ElasticsearchDomainEndpoint among stacks, something very similar to this solution https://github.com/aws-amplify/amplify-cli/issues/1047
Describe alternatives you've considered
Also, for now, the solution to pass the ElasticSearch stuff as an output would be a great solution for me, but something greater would be to add it automatically with the CLI.
Additional context
No response
Is this something that you'd be interested in working on?

[ ] 👋 I may be able to implement this feature request
[ ] ⚠ This feature might incur a breaking change

Or maybe as a fast alternative, is there a way to use ElasticSearch with a Trigger lambda with DynamoDB? Because I just need that, I have a DynamoDB Table triggered with a lambda and I need to save these values to ElasticSearch, but the Lambda created with the CLI for this task, it's not enough for what I need to do :(.

@MontoyaAndres I have roughly speaking the same need as you and I am not aware amplify has the functionality for plain search endpoints (e.g. easy to use ES in REST API lambdas).
I implemented following setup myself (needs some maintenance over time):

ES Cluster using terraform to control the nodes/speed/costs of the cluster in a VPC
amplify function which triggers to more or less all my dynamodb tables and deals with indexes/documents
manual cloudformation policy which allows lambda to configure its own network and attach itself to VPC (so it can access the ES cluster)
https://www.npmjs.com/package/dynamodb-stream-elasticsearch <- my indexing implementation is based on this

In theory, depending on your needs and security setup, you could keep your ES out of VPC and reduce the configuration work across the board.

@MontoyaAndres thanks for your input - we've marked this as a feature request and will pass along to the product team.


WSL Cargo reads undesirable configs on host

Problem
I'm using sccache installed by Scoop on my Windows machine, and specified my sccache path as absolute path on my config.
However when I use cargo on my WSL installation, it reads rustc-wrapper property of my Windows cargo config and fails to do basically any rustc-related stuff.
Steps

Specify rustc-wrapper in Windows cargo settings.
Open up any Rust project on WSL
Run cargo check

Possible Solution(s)
Letting users override some WSL-specific settings on their WSL home could be a nice solution without changing Cargo's behaviour too much.
Notes
Output of cargo version:
cargo 1.46.0 (149022b1d 2020-07-17)

Well it was because of my messy configs. Not a bug, closed.


Feat/funding stream dropdown

funding stream dropdown form added to the project create view

Should a couple of funding streams be added to our dev data in schema/data/dev ?

Should a couple of funding streams be added to our dev data in schema/data/dev ?

EP and IA rows are added in the funding_stream.sql deploy


RELIST + UNLIST action buttons

List the nft when while minting i’ve already chosen to list it?

to relist it for a different price. Make sense to adjust it for different verb once has some price set and I also notice we don't have that "Unlist" button there
Originally posted by @yangwao in https://github.com/kodadot/nft-gallery/issues/3595#issuecomment-1198187387
following up from the comment above:

let's change the wording of LIST button to reflect the action, I propose RELIST once the NFT is already listed (let's change this cross-chains)
let's add option to UNLIST the listed NFT (seems to be missing on Basilisk)

👋

I’d go for a bit user friendly term and that would be "Change price" or "Adjust price" instead of relist. The term itself isn’t very explaining for end-user

Why are these price values not shown the same?

It’s a bit missleading to see 2 different numbers ? (comma or dot missing down there)
I belive this is listed for 10k BSX, but it shows something else?

the nft is listed afaik for

When i try to explore and look for the minted nft, it’s not anywhere - ( not sure if related, is this logged? )
LOG:
Access to fetch at 'https://app.gc.subsquid.io/beta/snekk/003/graphql' from origin 'https://deploy-preview-3617--koda-nuxt.netlify.app' has been blocked by CORS policy: Response to preflight request doesn't pass access control check: No 'Access-Control-Allow-Origin' header is present on the requested resource. If an opaque response serves your needs, set the request's mode to 'no-cors' to fetch the resource with CORS disabled.
app.gc.subsquid.io/beta/snekk/003/graphql:1          Failed to load resource: net::ERR_FAILED
cabe47c.modern.js:2 Uncaught (in promise) Error: Network error: Failed to fetch
at new t (cabe47c.modern.js:2:2668514)
at cabe47c.modern.js:2:2689352
at cabe47c.modern.js:2:2695409
at Set.forEach ()
at cabe47c.modern.js:2:2695385
at Map.forEach ()
at e.broadcastQueries (cabe47c.modern.js:2:2695335)
at cabe47c.modern.js:2:2687980


[Bug]: Failed to launch the browser process! but i dont have any error stderr for debug

Steps to reproduce
I have bug when launch pdf save file
Error: Failed to launch the browser process!
but i dont have any thing information about that
I deploy production in Almalinux 8.9
NodeJs version: v20.17.0
Puppeteer version: ^23.3.0
i was set up chromium and fully step
when i run via cli PATH=$PATH:..... run ok but when i call puppeteer that was problem !
i check pdf file was saved but why that failed

the command generate is
PATH=$PATH:/usr/local/bin:/opt/homebrew/bin NODE_PATH=npm root -g node '/xxx/vendor/spatie/browsershot/src/../bin/browser.cjs' '{"url":"file:///tmp/619073741-0111098001725473430/index.html","action":"pdf","options":{"path":"/xxx/storage/app/contracts/2024-09-05-72c79b75-993e-4c98-aac5-fbbdc7be4057.pdf","args":["--no-sandbox"],"viewport":{"width":800,"height":600},"displayHeaderFooter":false,"executablePath":"/xxx/storage/puppeteer/chrome-headless-shell/linux-128.0.6613.119/chrome-headless-shell-linux64/chrome-headless-shell","format":"A4","printBackground":true}}'
and result i get on linux cli is array buffer
but i run in code was failed with log but no stderr out ! please help me
Expected results
Let me how to debug stderr
Actual results
!!

Chrome does not explicitly support that Linux distribution System requirements.
What you can do to debug this issue is use dumpio: true when running puppeteer.launch. That will give you the logs from the browser and you can see if there are any errors there.
Also to see Puppeteer debug logs you can run your command with prefix env DEBUG=puppeteer:*.


Making Search movie feature

Description:
I would like to request the addition of a Movie Search feature to the repository. This functionality will enable users to search for movies on the site, enhancing user experience and accessibility to the movie database.
Proposed Feature Details:
[ ] - Search Input: A search bar should be available on the homepage (or a designated search page), allowing users to input movie titles.
[ ] - Search Functionality: The search feature should query the movie database, returning relevant results based on the entered title. Results should include movie names, posters, release dates, and any other key information that enhances usability.
[ ]- Search by tag - Like Malayalam etc , which help user to search movies through relevant tags
Improved user experience by allowing efficient access to specific movies.
Easier navigation through the movie database, particularly for users with specific movie preferences.
Thank you for considering this feature request. I believe it will significantly improve the usability of the site.

sir can you assign level in this project

sir can you assign level in this project

Based on your PR I will give you a level. So fix this issue first.

Hi @maniyaom  ,
I would like to work on this issue. Could you please assign it to me?
Thank you!

Hi @maniyaom ,
I would like to work on this issue. Could you please assign it to me?
Thank you!

@anuragbansall assigned.


Extended PublicKey class API with two new methods, allowing to get publicKey tag type or its corresponding signature algo type

Problem:
Currently, it's very hard for consumers to get the signature type of a public key stored in a string representation which is the primary way of storage for JS web apps, and also how Signer is representing and providing public keys.
Solution:
Extended PublicKey class API with two new methods, allowing to get the public key tag type or its corresponding signature type. The use case will enable consumers to streamline usage of the many casper-js-sdk APIs requiring signature type as an argument, deriving it directly from a string representation of the public key instead of writing custom and complex logic by consumers that can easily break when casper-js-sdk is updated in the future.
Additional info:

Added test cases for new APIs.
Fixed incorrect uses of TypeScript types packages convention, causing compile error when executing tests using ts-node, refactored blake.d.ts types to use the supported way following the TypeScript Docs: "A types package is a folder with a file called index.d.ts or a folder with a package.json that has a types field. -- TypeScript Handbook"

@hoffmannjan PR discussed on Friday is ready for review. Cheers!

@piotrwitek thanks. I will merge it this week and we will release new version (most likely by the end of the week). Cheers

Awesome, thanks @hoffmannjan 👍
I saw tests failed for build 18.x but the error seems unrelated to my changes. Did you have a look?

Yeah this is something related to one of the dependencies, will be addressed later :)

Thanks @hoffmannjan 👍 When are you planning a new release?


v4.4.1: packaging error

Hi,
When packaging using rollup the build currently breaks because the module property is still set in the package.json (https://github.com/STRML/react-draggable/blob/v4.4.1/package.json#L6) but the build/module directory isn't in the npm package anymore.
My assumption is that this line should have been deleted in fa030e27f3130e1077da58720f5449d3dd36986e

Same error here. Rollup build is broken now.

Thanks -- published 4.4.2 which fixes this.


"ICP transfers"  link broken

https://internetcomputer.org/docs/current/developer-docs/defi/tokens/token-standards#icp-tokens

Hi there,
I tried to reproduce your issue but it didn't work. But it seems like you need to take immediate action to keep your wallet safe.
Please write to us using the “Chat Support” icon located on the Dfinity Help Center
You can include a link to this issue in your message.
Alternatively, you can also search for answers in our help documentation or get help from other users on our community forum.
This issue will be closed.
Thanks!


Feature request: Search movies by cast

As a user who is a fan of many actors/actresses, I want to find a movie by its cast so that I can find the movie that has my favorite star.
Acceptance Criteria:

This program can be run without crashing under the EC2 terminal with Python 3.10.
The user can enter any search term.

I would like to be able to search the movie database by cast, to see what movies have the actors I like in them. This would also benefit those who want to avoid movies that have actors that they don't like, or server as a way for people to learn if a movie does or does not have a certain actor.
Task list

Add the menu option for this feature
Add the function to search and print matching movies by cast search

Acceptance Tests

Run the program with the new code in an EC2 terminal
Check that all functions behave as expected
Ensure there are no crashes are warnings printed out

This has been added in PR #8


WasmThemis 0.13.11

Cut a hotfix release that should make WasmThemis actually usable in browsers (at least when bundled by webpack, at least for 2 users).
  :)

Uh, yeah. Releases are numbered sequentially. I don't want to explain how come 0.13.2 got released on both 2020-08-20 and whatever date this release will happen on and what's the difference between them. (You can also think that the next release will be 0.13.111. Not that far from impossible, given your appetite for Apple stuff hotfixes and reluctance to do 0.14.0...)
By the way, is that release date realistic? Someone who isn't me should push the button on a certain CI to start the pipeline for WasmThemis publishing, and @shadinua is not really available at the moment.

Just a note: the 0.13.x branch is still using the old Emscripten toolchain:
https://github.com/cossacklabs/themis/blob/2cbce205b775a8ac3ce5ddee7baa54eb37c82fcc/.github/workflows/test-wasm.yaml#L69-L70
That's what you'll need to use for building wasm-themis on this branch, not the new version from master. If you use Emscripten 2.0.x, the build will still be successful, but libthemis.wasm file will be basically empty and not usable.
Please be cautious, @vixentael, @shadinua

That's what you'll need to use for building wasm-themis on this branch, not the new version from master

Gotcha. Use old EMSDK.


updated migration script for shared customers

Coverage decreased (-0.03%) to 75.995% when pulling 94088e4b3e44060e1167bcac14578919ca601108 on migration-script-fixes into cdb4100c7785a7594040da88db6ed7c2ad0b4a2e on master.


WDI Melb 2015-03-09 :: Luke Shillabeer

w00t, got the test-suite working!... I think ^_^
A huge shout-out to @lady3bean and whichever of the dev's helped her out editing the karma test-stuff so it would pass the Travis thingy. I owe my pass to your edits.

You're welcome :wink:

Though if you have the time I would go a few steps further and make sure that there is good directions for how to run the tests in the browser because then you can actually use the debugger.  It was really frustrating trying help @lady3bean get her tests passing without the ability to run the tests in the browser.
Also, nyancat reporter is cute, but it doesn't show you the names of the each passing test (which is really useful when forced to run it from the console)


Message to CircleCI users about reducing image sizes

Background

We should communicate to users about reducing their image sizes to help reduce costs.
Questions / Assumptions

How much can we influence team image sizes?
Should we target specific teams?
Are there any best practices we should be pointing users to?

Acceptance Criteria

[ ] Comms created

Reference
How to write good user stories

Potentially might need to ping individual teams, but it is possible that the teams cannot do anything about this. Circle's only suggestion is to prune the dependency tree and remove "unnecessary" ones, but it is entirely possible all the dependencies are necessary, so teams might not be able to do anything, or even more likely, it won't make a difference.

No longer required. No further action to be taken.


Docs branch with basic documentation structure

should include all the changes you suggested in the other PR.

You should add a docs/Project.toml which adds Documenter, like in DiffOpt, this allows us not to depend on Documenter in the main package

Codecov Report

Merging #184 (94b8694) into master (f6f895b) will decrease coverage by 0.43%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #184      +/-   ##
==========================================
- Coverage   67.66%   67.22%   -0.44%
==========================================
  Files          13       13
  Lines        1670     1666       -4
==========================================
- Hits         1130     1120      -10
- Misses        540      546       +6

Impacted Files
Coverage Δ

src/afw.jl
65.29% <ø> (ø)

src/blended_cg.jl
50.26% <ø> (-2.09%)
:arrow_down:

src/fw_algorithms.jl
76.77% <ø> (+0.30%)
:arrow_up:

src/types.jl
64.44% <0.00%> (-0.40%)
:arrow_down:

src/polytope_oracles.jl
100.00% <0.00%> (ø)

src/active_set.jl
79.20% <0.00%> (+0.62%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f6f895b...94b8694. Read the comment docs.


Added type check for 'dragStarted' variable as this is causing thousa…

Added type check for 'dragStarted' variable as this is causing thousands of console errors in Chrome, Firefox, Edge, IE, Safari before the first drag.
This change is harmless because it is just checking if the variable dragStarted is declared before using it.
Tested across all of the above browsers and working fine after this change.

What is the error? The variable is declared as false at the start of the file.

What is the error? The variable is declared as false at the start of the file.

Error:
Uncaught ReferenceError: dragStarted is not defined
This is noticed before performing the first drag action on the Sortable elements. If the user clicks anywhere else in the neighbouring elements, then the above error is seen.
Once the user drags one of the Sortable elements, then the error doesn't appear.

@owen-m1 any updates on merging this pull-request ?
Thanks in advance.

Do you need any more information to merge this pull request. Please let me know.


Invalid Item when creating a Botania flower recipe with NBT

That's my script:
recipes.addShaped(<BuildCraft|Builders:machineBlock>, [[<BuildCraft|Robotics:robot>, <Botania:specialFlower>.onlyWithTag({type: "orechid"}), <BuildCraft|Robotics:robot>],
	[<ImmersiveEngineering:metalDevice:14>, <BuildCraft|Factory:miningWellBlock>, <ImmersiveEngineering:metalDevice:14>],
	[<IC2:blockMachine:12>, <ThermalDynamics:ThermalDynamics_0:4>, <IC2:blockMachine:12>]]);

When using this, I get a flower with invalid NBT in the recipe:

If I use the withTag instead onlyWithTag, I get the right recipe:

recipes.addShaped(<BuildCraft|Builders:machineBlock>, [[<BuildCraft|Robotics:robot>, <Botania:specialFlower>.withTag({type: "orechid"}), <BuildCraft|Robotics:robot>],
	[<ImmersiveEngineering:metalDevice:14>, <BuildCraft|Factory:miningWellBlock>, <ImmersiveEngineering:metalDevice:14>],
	[<IC2:blockMachine:12>, <ThermalDynamics:ThermalDynamics_0:4>, <IC2:blockMachine:12>]]);

uh yea. ".withTag" is for inputs, "withOnlyTag" is for outputs

But, when using .withTag in a input, I can use any flower with any NBT in the recipe, not the one that I specified.

Sorry by the mistake. Yes, you're right, It's working, but NEI won't display the right flower in the recipe, kinda ignoring all NBT... Do you know how to fix?

no idea.


virt-handler, network setup: Do not create podNIC for SR-IOV networks

What this PR does / why we need it:
Kubevirt expects SR-IOV interfaces to be set with userspace driver (vfio-pci) in order to attach them to VMs.
The interfaces are passthroughed to the VM using Libvirt API.
Thus SR-IOV networks should not be part of the network setup.
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #
Special notes for your reviewer:
This is a follow-up PR to resolve https://github.com/kubevirt/kubevirt/pull/9268#discussion_r1199753143
Release note:

/test pull-kubevirt-unit-test

/cc @EdDev @orelmisan

Thank you for the PR @ormergi. Please consider creating a map of spec network names to spec interfaces (before iterating over the networks to create podNICs).
It will enable two improvements:
1. The lookup of interface by network name inside the loop will be in O(1) instead of O(N).

2. We could pass the interface to `newPhase1PodNIC` and later to `newPodNIC()` to eliminate the need to call `LookupInterfaceByName` [again](https://github.com/kubevirt/kubevirt/blob/0d30186ee2e6105ade46fc6f42718645aacc553a/pkg/network/setup/podnic.go#L112).

Edit: We could also apply this suggestion to getPhase2NICs().

Please note that such optimization around network/interfaces spec may end up neglectable because Kubevirt uses q35 machine type by default, which can have put to 31 PCI slots.
In terms of time complexity, where N is the VMI spec ifaces count, O(N) => O(32) => O(1).
Meaning it will always take the same time to tell which iface is SR-IOV iface, given max number of ifaces.
Regarding (1), its true that it will take O(1) to realize if an iface is SR-IOV at the podNIC creation loop, but it depends on a map that takes O(N) to build with additional O(N) in memory complexity.

/cherry-pick release-1.0


Pasting R code into the integrated terminal is broken

VSCode Version: 1.11.2
OS Version: macOS Sierra 10.12.4

Steps to Reproduce:

Open VS Code GUI, open up the integrated terminal.
Start an R session in the integrated terminal by tying R.
Paste the following text into the integrated terminal

idx.training <- sample(seq(1:nrow(df)), 0.6 * nrow(df))
df.train  <- df[idx.training,]
df.test   <- df[-idx.training,]
df.tr <- df.train[,c("home","vst","year","day_of_week","day_night","attendance","lagged_att","fci","vst_pop", "home_pop", "vst_income","home_income","prcp_matched","aptmp_matched","wind_matched","cloud_matched","home_avg_runs_5","vst_avg_runs_5")]
df.te <- df.test[,c("home","vst","year","day_of_week","day_night","attendance","lagged_att","fci","vst_pop", "home_pop", "vst_income","home_income","prcp_matched","aptmp_matched","wind_matched","cloud_matched","home_avg_runs_5","vst_avg_runs_5")]

df.model.lm <- lm(attendance ~ year+day_of_week+day_night+attendance+lagged_att+vst_pop+home_pop+vst_income+home_income+prcp_matched+aptmp_matched+wind_matched+cloud_matched+home_avg_runs_5+vst_avg_runs_5+home+vst,df.tr)
df.predict.lm <-  predict(df.model.lm,df.te)
df.predict.lm.rmse <- sqrt(mean((df.predict.lm - df.te$attendance)^2,na.rm=TRUE))
print(paste("Root Mean Squared Error (RMSE):", df.predict.lm.rmse))
pdf('lm_model.pdf',8,8)
plot(df.predict.lm, df.te$attendance, main="Linear Regression Preditions vs. Actual",
     xlab="Predicted", ylab="Actual")
abline(0, 1, lty=2)
legend("topleft", c("Data", "Perfect Model"), pch=c(1, NA), lty=c(NA, 2))
dev.off()

An excerpt of the output is
> print(paste("Root Mean Squared Error (RMSE):", df.predict.lm.print(paste("Root Mean Squared Error (RMSE):", df.predteprint(past
e("Root Mean Squareression Preditions vs. Actual",
+      xlab="Predicted", ylab="Actual")
+ abline(0, 1, lty=2)
Error: unexpected symbol in:
"     xlab="Predicted", ylab="Actual")
abline"
> legend("topleft", c("Data", "Perfect Model"), pch=c(1, NA), lty=c(NA, 2))
Error in strwidth(legend, units = "user", cex = cex, font = text.font) :
  plot.new has not been called yet
> dev.off()
null device
          1

Now, if I paste it into Terminal.app with an R session launched inside it, the error Error: unexpected symbol in does not occur. Notice that in the example I did not import the dataset so there is a bunch of errors, but that shouldn't matter. If I load the correct dataset, Terminal.app will execute my R code successfully in an interactive R session while the integrated fails at the error Error: unexpected symbol in. I did not change any settings in VS Code.

Could you provide a screenshot of the input/output in Terminal.app?


Texture system

When I was learning to work with the Cube 2 editor, I always got frustrated at how hard it was to work with vcommands and blendmapping. Both of these things are really powerful if used correctly, but not even the most intelligent newcomer will understand it and do it right before having studied the reference for a few days. I don't have superclear ideas on how it should be, but these are some thoughts:

When selecting the face of a cube, show useful information about the texture on that face at the bottom of the screen: filename, textureslot, scale, rotation, offset, shader related stuff, colour and so on (this is basically #57 ).
Make the way you can change those parameters (scale, colour etc.) like the way you change entities: hold number and scroll. It is immensely useful to see the offset changes you make, change in real time. Saves so much time! Same for the other parameters.
Always think about the n00bies and add a gui to edit those texture parameters. This should also happen for entities I think (but I suppose you're already working on that).

continue contributing that stuff is good

This should be easy to accomplish using CEF :+1:
We should also look around fanaticclient and zombie-menu as well as get in touch with editors, because there is a lot of room to be improved about the usabillity!

I am planing a new UI for editing which gives you full control of just everything!
I will check out the fanatic client btw.

The Fanatic Edition is mostly developed by Nyne. Unfortunately, he is gone for personal reasons, so it's impossible (atm) to get in contact with him. The zombie menu has good ideas, but due to the very strict possibilities of Cubescript I don't suppose it can help us for a reference in this case.

Related to #587 #299
I think keybindings are only the beginning.


Design Guidelines for Contributing New Icons

It would be great if there are guidelines for contributors in the documentation.
Examples could be found at Feather Icons or Simple Icons
Any information on dimensions and constraints for current icons would be great.
Also setting guidelines for icon requests would make it easier to submit and clear any ambiguity.
Setting up a project for adding new icons based on those requests will enable faster checking when adding new icons in the future.

Will work on this soon

@atisawd How does this look?

@atisawd How does this look?

@binyamin were you ever able to contribute somehow? I'd like to but not sure if there was ever a guideline released.

@calvinomiguel honestly, I don't use this project anymore. I go with feather icons, or its community-driven counterpart lucide.

Hi @binyamin please do tell me what needs to be done , because i am just one person working on this project since the start, except for npm . I have my own work to take care of , this is just a side project but i still want to improve it.

Hi @binyamin and @calvinomiguel please do tell me what needs to be done , because i am just one person working on this project since the start, except for npm . I have my own work to take care of , this is just a side project but i still want to improve it.

Hi there, well we just want to have guidelines. A small tutorial so that we know how you create the icons. If we habe that we could help with the creations of icons. I could be crrating pull requests then and if you like ghe work, you'd integrate it to the main branch. This way the project can grow faster. But again, we need guidlines for the code part but as well for the design, to make sure the visuals of the icons are consistant to the existing library.

Hi @calvinomiguel , i follow the material icon guidelines of
24px x 24px artboard and 2 px padding
the cap for the strokes used are butt cap
the corner for the strokes used are round join
the corner radius used for regular icons are 1px
for solid icons the corner radius is 2px
the spacing between different elements is usually 2px
I will make a comprehensive guide taking other icon sets as an example but for now this should work. You can add the svg in the folders in the repository according to the style.
The naming system for the icons are a prefix of "bx" for regular , "bxs" for solid and "bxl" for logos. Do check that the names aren't repeated.


Drop support for auto-creating GCS buckets

Why remove it?

Since buckets names are globally unique, they should be created very deliberately. It's unlikely that anyone would just hard-code a bucket name in their configuration and expect it to be auto-created.
We can revisit this in the future, if anyone finds a convincing use-case for it. For now, I think requiring users to explicitly create buckets, is less error-prone.

But this feature already exists, and I disagree about this point. It's parentalism. The client lib already so easily lets users programaticaly create buckets. Furthermore, the client lib already trivially lets people create buckets for names generated at run time! Whereas our code uses the Value annotation and requires hard coding in config.
Furthermore, the functionality already was written.


Two instances of two SecretStr subclasses are not the same

Initial Checks

[X] I have searched GitHub for a duplicate issue and I'm sure this is something new
[X] I have searched Google & StackOverflow for a solution and couldn't find anything
[X] I have read and followed the docs and still think this is a bug
[X] I am confident that the issue is with pydantic (not my code, or another library in the ecosystem like FastAPI or mypy)

Description
That's a regression from 1.9 where the code snippet works fine.
The reason is this change in SecretField:
# v1.10
class SecretField(abc.ABC):
    ...

    def __eq__(self, other: Any) -> bool:
        return isinstance(other, self.__class__) and self.get_secret_value() == other.get_secret_value()

# v1.9
class SecretStr:
    ...
   def __eq__(self, other: Any) -> bool:
        return isinstance(other, SecretStr) and self.get_secret_value() == other.get_secret_value()

Example Code
import pydantic

class SecretOne(pydantic.SecretStr):
    ...

class SecretTwo(pydantic.SecretStr):
    ...

def test_eq():
    assert SecretOne("secret") == SecretTwo("secret")

Python, Pydantic & OS Version
pydantic version: 1.10.2
            pydantic compiled: True
                 install path: /Users/cleancoder/Library/Caches/pypoetry/virtualenvs/xxx/lib/python3.9/site-packages/pydantic
               python version: 3.9.12 (main, May 25 2022, 10:42:02)  [Clang 13.1.6 (clang-13<IP_ADDRESS>.5)]
                     platform: macOS-12.6-arm64-arm-64bit
     optional deps. installed: ['devtools', 'dotenv', 'email-validator', 'typing-extensions']

Affected Components

[X] Compatibility between releases
[ ] Data validation/parsing
[ ] Data serialization - .dict() and .json()
[ ] JSON Schema
[ ] Dataclasses
[ ] Model Config
[ ] Field Types - adding or changing a particular data type
[ ] Function validation decorator
[ ] Generic Models
[ ] Other Model behaviour - construct(), pickling, private attributes, ORM mode
[ ] Plugins and integration with other tools - mypy, FastAPI, python-devtools, Hypothesis, VS Code, PyCharm, etc.

I would argue it could be seen as a correction, not a regression.
There's nothing that says instances of two different classes should ever be equal.
But I agree it's unfortunate that it changed in a minor release, sorry.
I don't intend to change this behaviour. You can always implement your own custom __eq__ method if you like.

I would argue from the observable behaviour point of view.
SecretStr used to be a string type. For a string, it does not matter how often you subclass it, the value is what matters for equality. Changing this observable behaviour is indeed unfortunate.
Now, SecretStr implements SecretField and no longer str. I do understand that in this case,  you do not want to keep the str semantics in this case, either.


Universal listings - (rebased) POC of updating filters dialog in response to removing active filters

Rebase of #11515 now that #11477 is in. Replace the SwapController hack in favour of reusing TeleportController with a new reset value to allow clearing the target element before appending the controlled element.
There's still a few issues:

Date pickers don't work after refresh, as mentioned in #11477
If you close the drilldown without going back to the top-level, then clear a filter, opening the drilldown and selecting the last selected filter doesn't work. You need to select a different filter and go back for it to work.

Likely because the DrilldownController isn't aware of its elements being replaced, and still remembers that the filter was still open.

Not really an issue but the filters_fragment query param is now also reflected to the address bar

Out-of-scope for this PR, but we also still need to update e.g. export links in the header buttons with the filter params. I made a POC in https://github.com/laymonage/wagtail/commit/b0a2a0729dc0136871f3f752426d85bea3773f75
Please check the following:

[ ] Do the tests still pass?[^1]
[ ] Does the code comply with the style guide?

[ ] Run make lint from the Wagtail root.

[ ] For Python changes: Have you added tests to cover the new/fixed behaviour?
[ ] For front-end changes: Did you test on all of Wagtail’s supported environments?[^2]

[ ] Please list the exact browser and operating system versions you tested:
[ ] Please list which assistive technologies [^3] you tested:

[ ] For new features: Has the documentation been updated accordingly?

Please describe additional details for testing this change.
[^1]: Development Testing
[^2]: Browser and device support
[^3]: Accessibility Target

Not really an issue but the filters_fragment query param is now also reflected to the address bar

For background - the reason I added the query param at all, rather than always serving the fragment as part of the index_results response, was to avoid replacing the filter HTML more often than necessary, and in particular, avoid it happening while the user was interacting with the filter dialog itself. For this reason, we'd ideally want to avoid it 'leaking out' to other URLs besides these specific button actions. I guess the pagination and reordering links also suffer from this...

I'm trying to see if it's possible to pass the corresponding <input> element's ID in ActiveFilter instead, then clear the input's value and let the drilldown component re-submit the form and swap the results. That way we won't even need get_url_without_filter_param and filter_fragment etc

Sorry for the slow progress, some updates cc @gasman:

If you close the drilldown without going back to the top-level, then clear a filter, opening the drilldown and selecting the last selected filter doesn't work. You need to select a different filter and go back for it to work.

This has been fixed, and the drilldown now also correctly resets to the top-level menu when the popup is closed as per the desired behaviour.

Not really an issue but the filters_fragment query param is now also reflected to the address bar

I've renamed this to _w_filters_fragment to be more cautious, and the drilldown won't reflect any params prefixed with _w_ to the browser.
I moved the _w_filters_fragment=1 setting to get_url_without_foo() methods. I get why they weren't there in the first place (those methods are supposed to be generic, and the active_filters property should be responsible for _w_filters_fragment. However, I noticed that the param would get applied multiple times as you clear the filters one by one. A way to avoid this is to be more smart when applying the param, but it requires parsing the URL again which is unfortunate, meanwhile we still have a hold of a QueryDict in the other methods. Alternatively maybe allow the methods to accept additional parameter to be applied, similar to how the set_query_params util function. Anyway, I just decided to avoid all that and pick the simplest solution for now....
Remaining issue

Date picker doesn't seem to work (the widget from the external library does seem to render now, but entering anything would reset everything for some reason (similar to the bug we saw when Thibaud did a demo). I thought I tested it when reviewing #11477...
Still need to do something like https://github.com/laymonage/wagtail/commit/b0a2a0729dc0136871f3f752426d85bea3773f75 to fix the header button links on AJAX refresh, but at least now that the browser reflects the URL, users can do a full reload to fix those buttons' links...

I moved the _w_filters_fragment=1 setting to get_url_without_foo() methods. I get why they weren't there in the first place (those methods are supposed to be generic, and the active_filters property should be responsible for _w_filters_fragment). However, I noticed that the param would get applied multiple times as you clear the filters one by one. A way to avoid this is to be more smart when applying the param, but it requires parsing the URL again which is unfortunate, meanwhile we still have a hold of a QueryDict in the other methods. Alternatively maybe allow the methods to accept additional parameter to be applied, similar to how the set_query_params util function. Anyway, I just decided to avoid all that and pick the simplest solution for now....

That seems fair enough!

OK, I've fixed the date picker issue. Tricky situation but it's basically similar to why I added 30d2672942d208a5da3323e3a7440ed53ad8e5c7 in #8901: the datepicker popup is rendered within the <body> element. Clicking anywhere inside the datepicker popup would make Tippy.js think that you're clicking outside of the drilldown component, so it closes. When it closes, the DOM is destroyed so the form is left with the search input only, and then the form gets submitted – which means the filters aren't applied, at least not until you reopen the drilldown and interact with it again.
Setting parentID or the datepicker's undocumented insideParent option would solve the issue, but then the date picker is rendered inside the drilldown and get bounded/cropped off within the drilldown component.
I fixed it by disabling Tippy's hideOnClick option (which defaults to true), and then implementing our own solution for the "hide on click away". Not sure how robust this solution is, it seems to work well but I'm being cautious and decided to only apply this custom method for the drilldown and not other dropdowns.
I noticed that we also have a hideOnClick stimulus value for hiding the dropdown when you click inside the dropdown, which was added to close the choosers dropdown when you trigger the chooser modal. However, this name unfortunately causes ambiguity with Tippy's hideOnClick option, so I added a few comments to explain the situation.
I think this can be reviewed now, I'll try to create a PR for https://github.com/laymonage/wagtail/commit/b0a2a0729dc0136871f3f752426d85bea3773f75 to fix the header buttons, but if I can't get it good enough for a review we can probably postpone that to post-RC.

Thanks @gasman, of course 🤦 Sorry, I didn't notice that the fragment weren't actually replaced so the datepicker still worked. Let me look into it.


Model CNN using Private Test Dataset in your code do learning too or not?

Hi,
Do model CNN using Private Test dataset in your code do learning too?
As far as I know, model CNN using Private Test dataset don't need learning. Sorry if I am wrong.
Can you explain it for me?
Thanks.
Best,
Adhitya

hi, this code only use training set in the training stage.

So, the PublicTest and PrivateTest set are only used to test the model, not for learning the model?


chore: bdd-spring-1575477432 to 0.0.1

chore: Promote bdd-spring-1575477432 to version 0.0.1

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approvers:
If they are not already assigned, you can assign the PR to them by writing /assign  in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


support for parameters in native and criteria queries

This patch extends @gbadner's work on query parameters by adding:

positional + named parameters in native queries
named + anonymous parameters in criteria queries

But for now I could not figure out how to add support for parameters in update/delete queries or criteria.

I've created a new issue for update queries parameters: https://github.com/hibernate/hibernate-reactive/issues/220


virustotal

https://www.virustotal.com/#/file/abf2ed55d6f7dbff0638a29fd16604d47ee8fdd92060f74ee6e6db3299d0c617/detection

This appears to be a false positive. Reactivate if you're convinced this is for real.


API chat queries does not return correct response with basic auth

Description
API chat queries does not work with basic auth

Steps to Reproduce
Prerequisites
Create an API and enable Basic level security under runtime configurations
Deploy the API
Steps

Login to devportal
Subscribe to API
Navigate to API chat
Open Configure key side panel
Provide Basic auth credentials
Execute a query

Affected Component
APIM
Version
4.3.0
Environment Details (with versions)
No response
Relevant Log Output
No response
Related Issues
No response
Suggested Labels
No response

Closing as this issue is fixed with https://github.com/wso2/apim-apps/pull/658


[Question] Is it possible to encode and decode with AutoTokenizer.from_pretrained and keep spaces?

 [/INST]`
const tokens = model.encode(textInput)
const tokenizedText = model.batch_decode(
  tokens.map((token) => [token]),
  { clean_up_tokenization_spaces: false }
)
console.log(tokenizedText)

And get:
0: "<s>"
1: "["
2: "INST"
3: "]"
4: "<<"
5: "SYS"
6: ">>"
7: "\n"
8: "You"
9: "are"
10: "a"
11: "friendly"
12: "L"
13: "l"
14: "ama"
15: "."
16: "\n"
17: "<"
18: "</"
19: "SYS"
20: ">>"
21: "\n"
22: "\n"
23: "Do"
24: "you"
25: "sp"
26: "it"
27: "at"
28: "people"
29: "?"
30: "["
31: "/"
32: "INST"
33: "]"

So while newlines are there, all the spaces are gone. Is there any way to get the original text back but with token boundaries for visualisation?

Hi there 👋 So, although the library is functioning correctly (it is treating each new word as a separate sentence, and as a result, it is removing the initial space, if it is present). This logic can be found in the tokenizer.json from the repo:
  "decoder": {
    "type": "Sequence",
    "decoders": [
      {
        "type": "Replace",
        "pattern": {
          "String": "▁"
        },
        "content": " "
      },
      {
        "type": "ByteFallback"
      },
      {
        "type": "Fuse"
      },
      {
        "type": "Strip",
        "content": " ",
        "start": 1,
        "stop": 0
      }
    ]
  }

(see the Strip decoder).
 [/INST]`
const tokens = model.encode(textInput)
const tokenizedText = model.batch_decode(
  tokens.map((token) => [token]),
  { clean_up_tokenization_spaces: false }
)
console.log(tokenizedText)

which produces:
0: "<s>"
1: " ["
2: "INST"
3: "]"
4: " <<"
5: "SYS"
6: ">>"
7: "\n"
8: "You"
9: " are"
10: " a"
11: " friendly"
12: " L"
13: "l"
14: "ama"
15: "."
16: "\n"
17: "<"
18: "</"
19: "SYS"
20: ">>"
21: "\n"
22: "\n"
23: "Do"
24: " you"
25: " sp"
26: "it"
27: " at"
28: " people"
29: "?"
30: " ["
31: "/"
32: "INST"
33: "]"

Hope that helps! Also, I worked on a similar thing in the past, which you might find useful:

Demo
Code

Ah, that makes sense, thanks a lot for a quick and comprehensive answer!
Also thanks for sharing your web version, haven't come across it – probably Google isn't indexing HF Spaces?
Anyway, I was thinking of adding some extra features like models side by side and loading any model from HF, not just a preselected few. Though now seeing that each model might need some workarounds it could get tricky 🤔
Will close this issue for now, might come back and share if I got it working!


[dockerfile] Add debug symbol test + gdb support

Adds a test to check debug symbols are always generated and extracted.
Places debug symbols in a hierarchy under /usr/lib/debug that matches the
expected location embedded in the binaries. That way gdb can find the symbol
files and we can eliminate  a symlink that dlv will no longer require.
Without this change:
root@f62055ef662f:/home/cilium# gdb /usr/bin/cilium-agent-bin
…
Reading symbols from /usr/bin/cilium-agent-bin...
(No debugging symbols found in /usr/bin/cilium-agent-bin)
…

With this change:
root@0a1bedcaf638:/home/cilium# gdb /usr/bin/cilium-agent-bin
…
Reading symbols from /usr/bin/cilium-agent-bin...
Reading symbols from /usr/lib/debug//usr/bin/cilium-agent.debug...
warning: Missing auto-load script at offset 0 in section .debug_gdb_scripts
of file /usr/lib/debug/usr/bin/cilium-agent.debug.
Use `info auto-load python-scripts [REGEXP]' to list them.
…

And dlv still works: (no "symbols not found" error)
root@244fcaf145a1:/home/cilium# dlv exec /usr/bin/cilium-agent-bin
Type 'help' for list of commands.
(dlv)

Please ensure your pull request adheres to the following guidelines:

[x] For first time contributors, read Submitting a pull request
[x] All code is covered by unit and/or runtime tests where feasible.
[x] All commits contain a well written commit description including a title,
description and a Fixes: #XXX line if the commit addresses a particular
GitHub issue.
[x] If your commit description contains a Fixes: <commit-id> tag, then
please add the commit author[s] as reviewer[s] to this issue.
[x] All commits are signed off. See the section Developer’s Certificate of Origin
[x] Provide a title or release-note blurb suitable for the release notes.
[x] Are you a user of Cilium? Please add yourself to the Users doc
[x] Thanks for contributing!

Add test for generation and extraction of debug symbols.
Add debug symbol support for gdb.

/test

Checked the 3 test failures: it isn’t clear to me how they’d relate to my change, can we rerun them?


Need to use the bootstrap badge class in the No-Contract tag.

Describe the task

Go to CRM -> Projects
The No-Contract tag in the project module is currently displayed as normal text. We need to fix this tag's alignment and UI. Due to this, the UI looks a bit strange.

Expected behavior

[ ] We need to use the bootstrap badge class in the No-Contract tag. And the tag needs to be center aligned. As shown in the image below.

References

Bootstrap Badges:- https://getbootstrap.com/docs/4.0/components/badge/

Working Fine.


stress test error: running with ts resulted in inconsistent values

running blackbox_crash_test_with_ts resulted in the following error:
error : inconsistent values for key 0x000000000001257900000000000000927878: expected state has the key, GetEntity returns NotFound.
Verification failed :(

further docs in ~/exp_err/ in instance 30.

https://github.com/facebook/rocksdb/pull/12264
Added a fix to this issue . There still some gap handling correctly ts in db bench / db stress
I suggest cherry pick this commit and rerun or add a release note


Is there a way to share classes in queries?

In the pokemon example we have:
pokemon.schema.graphql:
type Pokemon {
    ...
    evolutions: [Pokemon]
}

fragments_glob.query.graphql
{
  pokemon(name: "Pikachu") {
    ...Pokemon
    evolutions {
      ...Pokemon
    }
  }
}

Yet, the generated code in
lib/graphql/fragments_glob.dart
@JsonSerializable(explicitToJson: true)
class FragmentsGlob$Query$Pokemon
    with EquatableMixin, FragmentsGlob$PokemonMixin {
  // ...
  // Could this be a List<FragmentsGlob$Query$Pokemon> instead?
  List<FragmentsGlob$Query$Pokemon$Pokemon> evolutions;
  // ...
}

Do not split between files. You'll get all code in one file with shared classes.
There is no way of sharing classes between multiple output files for now.

I tried putting the fragments and the query in the same file but I still get 2 classes:

FragmentsGlob$Query$Pokemon
FragmentsGlob$Query$Pokemon$Pokemon

I forked the repo and created a pokemon branch. It's available here.
Here's the content of graphql/fragments_glob.query.graphql
{
  pokemon(name: "Pikachu") {
    ...Pokemon
    evolutions {
      ...Pokemon
    }
  }
}

# copy pasted the below from graphql/fragments_glob.fragment.graphql
fragment Pokemon on Pokemon {
  id
  weight {
    ...weight
  }
  attacks {
    ...pokemonAttack
  }
}

fragment weight on PokemonDimension {
  	minimum
}

fragment pokemonAttack on PokemonAttack {
  special {
    ...attack
  }
}

fragment attack on Attack {
  name
}

I removed the this line in build.yaml: fragments_glob: graphql/**.fragment.graphql.
And final ran flutter pub run build_runnner build. But in lib/graphql/fragments_glob.graphql.dart, I still have:
@JsonSerializable(explicitToJson: true)
class FragmentsGlob$Query$Pokemon
    with EquatableMixin, FragmentsGlob$PokemonMixin {
  FragmentsGlob$Query$Pokemon();

  factory FragmentsGlob$Query$Pokemon.fromJson(Map<String, dynamic> json) =>
      _$FragmentsGlob$Query$PokemonFromJson(json);

  List<FragmentsGlob$Query$Pokemon$Pokemon> evolutions; // why not List<FragmentsGlob$Query$Pokemon>?

  @override
  List<Object> get props => [id, weight, attacks, evolutions];
  Map<String, dynamic> toJson() => _$FragmentsGlob$Query$PokemonToJson(this);
}

Actually I think it might be link to this answer.

I see. It seems to be an expected behaviour.
As far as fragment naming is not very easy we decided to prepend the class name with types or class names.
In your code you can refer to the classes via FragmentsGlob$PokemonMixin or List<FragmentsGlob$PokemonMixin>. I use this approach in my code


Favicon:Add an favicon to the website

🎮 feature Request
to add a favicon to the website
Point down the features
A favicon enhances brand recognition, aids visual identification of browser tabs, and contributes to the overall user experience on websites.
Select program in which you are contributing
GSSoC24
Code of Conduct

[X] I follow CONTRIBUTING GUIDELINE of this project.

plz assign me these issue under GSSOC'24

@Pratik2401 If you have any doubt you can directly send message on our discord (https://discord.gg/rZb46cCMmK), we have created seprate chennals for all projects...
Thank you :)

Hey I can work on this
Please assign it to me

Feature: Add a Favicon to the website
Description:
A favicon enhances brand recognition, aids visual identification of browser tabs, and contributes to the overall user experience on websites.
Benefits:

Improves brand recognition
Enhances visual identification of browser tabs
Improves overall user experience

Selected Program: GSSoC24
Code of Conduct:
I follow the CONTRIBUTING GUIDELINES of this project.
Status:
I have already resolved this issue and created the PR. Kindly review and approve my PR.

Hi, @JAYESH-BATRA  please assign this issue to me under GSSoc'24.

can you please assign me under GSSOC.'24 .


Experimental feature to import field content with a JSON string

Not production ready or anything ... just a sketch of something that (barely) works ... just as an idea, for issue #37

Hmm, realizing some changes. Getting back with a new PR later.


Why is mapping_justification a required field?

Given that this can be populated with semapv:UnspecifiedMatching, why not just have null value mean unspecified, which is literally one of the things null means
as it is, we have

A whole bunch of files in the mapping-commons org that fail parsing because schema checking fails
inflation of sizes of already potentially large uncompressed TSV files communicating zero bits of information

Perhaps we could at least have an option in the parser to auto-populate this so it's possible to work with legacy files?

you are deliberately exposing your ignorance over how the mappings came into being

My 3 decades of observing the social dynamics of how people interact with required fields begs to differ. Remind me to tell you the Pray For Elves celera story.
Anyway, I firmly believe this was the wrong decision but if the majority is against, so be it.


Add authScreenLaunchMode

Feature request:
Add authScreenLaunchMode to https://pub.dev/packages/supabase_auth_ui package
Is your feature request related to a problem? Please describe.
Yes. Current experience when using social logins for Google, Facebook, and Apple is an internal browser to login and then to display redirect. However, the onSuccess function and session data is not provided until the user redirects back to the app. With the current experience users have to pull up on the internal browser before they can see the iOS redirect link (assume similar experience with Android) which triggers onSuccess and session data to be sent to app. However, the user then also needs to click done to finish and be navigated to the post login app page.
This requires high cognitive load on users to understand they need to pull down on internal browser, click redirect link which is not intuitive because they are already in the app, and then click done to finish logging in.
Instead if authScreenLaunchMode option was available I could assign LaunchMode.externalApplication and the redirect would automatically prompt user to return to app after logging in. Have tested and this solves the issue above.
A clear and concise description of what you want and what your use case is.
Describe the solution you'd like
Add authScreenLaunchMode as a parameter to SupaSocialsAuth Widget and allow user to assign LaunchMode.externalApplication type.
A clear and concise description of what you want to happen.
Describe alternatives you've considered
Manually create own socials login UI and use supabase.auth.signInWithOauth which has authScreenLaunchMode: LaunchMode.externalApplication capability.
A clear and concise description of any alternative solutions or features you've considered.
Additional context
Add any other context or screenshots about the feature request here.

Hi,
Would you be willing to send in a PR for this since you've tested out a working solution already? 🙂


Cannot filter on negative numbers

import lance
import pyarrow as pa
import numpy as np

tab = pa.table({"x": [-1.0, 1.0, 0, np.nan, np.inf, -np.inf]})
dataset = lance.write_dataset(tab, "lance_values")

dataset.scanner(filter="x = -1.0").to_table()

ValueError: LanceError(IO): Unary operator 'Minus' is not supported

Additionally, but maybe less important: there is no way to filter for the NaN, Inf, or -Inf values either.

As a workaround for any of these cases, we can cast from a string:
dataset.scanner(filter="x = cast('-1.0' as double)").to_table()


Make the 'stream settings' box only show if you are a moderator in the channel.

What should be added?

Make this option only show if you are a moderator in the channel. No point in having it show on channels you aren't modded in.
Why should it be added?

Could confuse people thinking they have mod permissions. Also just cleans up the menu by removing an option that you can't use (if you aren't a mod)

I think you can be an editor without being a moderator. I'll make sure to test this :)


Allow using normal parentheses when calling functions

Functions.getSomething{} should be Functions.getSomething().

@myhau I believe this has already been done?


The give_velocity component acts like a move component

Currently, give_velocity just moves the spell every time it's called instead of actually giving it a velocity.

Fixed in commit d294ba4.


first work for BaseRepo

@tsiegleauq As I said, you can work on on this PR; Shouldn't be much more todo, some comments I think.

@FinnStutzenstein yes I am on it


Improve startup time

In a workspace with ~650 packages, I have a significant delay on startup— about 5-6 seconds when cold, and still almost 4 seconds on an immediate re-invocation. Here's a flamegraph of what colcon list looks like when run on a warm workspace (this is on a SAN-backed VM):

Of the 4 seconds, about half is package discovery/identification, and a third is plugin loading. I'm wondering about some possible strategies for improving this— normal asyncio isn't going to help here, since the parsing is CPU bound and native filesystem IO isn't async anyway. But plugin discovery could use a cache for the 99% case where there is nothing new to discover, and package discovery should be possible to heavily parallelize by walking the workspace breadth-first and pushing work onto other threads/processes, perhaps using ProcessPoolExecutor? Recursive gathering of the subdirectories might work for this?

package discovery should be possible to heavily parallelize by walking the workspace breadth-first and pushing work onto other threads/processes

I have tried that in the past with no significant benefit.

Interesting; I shall experiment a bit with it on my end and see if I find anything new.
It's also interesting to note from the flamegraph that topological ordering seems to be relatively quite expensive; perhaps there is an opportunity there to do some caching, especially now that the Dependency is an object to which metadata may be attached, rather than just a string.

topological ordering seems to be relatively quite expensive

I think performance improvements to similar code in catkin_pkg have been merge recently. Maybe something similar can be applied here.

I don't think the approach from https://github.com/ros-infrastructure/catkin_pkg/pull/280 would work exactly here as the bulk of colcon-core logic for this lives inside the PackageDescriptor object. However, an easy way to do it if we didn't want to directly annotate the DependencyDescriptors themselves might be to pass some kind of cache dict/object into the PackageDescriptor.get_recursive_dependencies function, then the persistence would only be one layer up, and it could be thrown away immediately after, avoiding any mutation or long-term memory implications.

Here's a first stab at a process pool package crawler:
https://github.com/mikepurvis/colcon-multiprocess-recursive-crawl/blob/0cfd01dd28f88181569bb2d77435ee00a6426284/colcon_multiprocess_recursive_crawl/package_discovery/recursive_crawl.py#L59-L81
All of the scandir recursion still takes place in coroutines on the main thread; only the identification portion is run on the executors. A potential other angle to try here would be feeding the subdirectory scanning jobs into some kind of a work-queue, though that would be potentially a lot more complexity for modest gains.
In any case, I haven't tried to profile just how much it's actually fanning out and taking advantage of the concurrency, nor have I looked at the fixed impact on small workspaces. But at least in my 650 package workspace, it cuts the scanning time approximately in half— relative to the baseline given in the initial post, we're now clearly being dominated by topological ordering and the entry_point/exec calls associated with plugin loading:

The implementation is a little janky, but here's a go at a simple dep caching scheme: https://github.com/colcon/colcon-core/compare/master...mikepurvis:package-deps. If you think there are legs here, I can open a PR and we can discuss further how to better structure it.
Also, I cleaned up two other sources of delay from the flamegraph:

There were some duplicate checkouts in my workspace, which is why those realpath calls were happening during recursive dependency discovery.
Several of the items on the right hand side of the chart were heavyweight dependencies that were being pulled in at module level in some of my experimental plugins. I've now restructured those so that the imports are lazy.

With these changes, I can colcon list my 650 packages in ~2.0s. The new flamegraph is:

This is what the startup time looks like running colcon --help in an empty repository.

Not trying to gold-plate anything (and improvements here would definitely be useful), but since you mention running WSL2: it could this is the file system performance of Linux-in-WSL2 bottlenecking performance.
Colcon does a bunch of entry-point detection and other work which needs to access the file system. That makes it mostly IO bound in my experience, at least until it gets to actually starting a build. Performance under Windows (with or without WSL) has never been comparable to any Linux.

Thanks for the follow up here, @alecGraves! I think I ended up getting a bit discouraged that in a large workspace, the startup time was about evenly split between package crawling and plugin discovery— both of these could be cached in various ways, but it came to feel like entry-point caching is more of a Python ecosystem problem, potentially to be solved that way: https://github.com/takluyver/entrypoints/issues/16
And it wasn't clear that startup time for large workspaces even matters much, to anyone other than me haha.
Ultimately, if we really care about colcon having a snappy CLI experience, it probably needs to go the way of Bazel— fork off a tiny "server" process that hangs out with the plugins already loaded, and can avoid re-crawling packages by monitoring the source directory with inode watchers. But that's a lot of potential complexity and it's not clear to me how cleanly it could be done without a major upheaval in the design of colcon.

Idk, what IO-bound operations would be needed running colcon --help in an empty directory? It should just be (and is, based on the import graph I made) only time wasted importing python libraries. Some of the problem could probably be alleviated if colcon knew what keywords different extensions operated on and only loaded extensions if necessary (thus, --help would import nothing).
Agreed, the large directory structure and module/estension structure make colcon very difficult to modify in a way that would improve the startup time. It could be time for a large refactor of the python code (which necessarily includes all of the extensions as well), a specialized C program, or a nice old-fashioned Makefile for ros2 projects.

Idk, what IO-bound operations would be needed running colcon --help in an empty directory?

at the very least it needs to figure out what verbs are installed/available. Plugins can contribute to the --help output as well.

All the operations that do meaningful work have to discover and load the plugins anyway, so I don't see a ton of value in special-casing --help in that regard just to make it fast.
The fix has got to be either making plugin loading dramatically faster with some kind of caching scheme, or else finding a way to do it ahead of time—whether that's a full client-server model for colcon, or perhaps something more minimal like a little daemon that forks inself as a "warm" colcon with some way of injecting the proper argv and wiring up stdout/stderr.


Dynamax not working

Describe the bug
A clear and concise description of what the bug is.
To Reproduce
Steps to reproduce the behavior:

Go to '...'
Click on '....'
Scroll down to '....'
See error

Expected behavior
A clear and concise description of what you expected to happen.
Screenshots
If applicable, add screenshots to help explain your problem.
Username: Fadida3
Server name (all applicable): Orion
Logs:
Where needed, please find your logs with the method down below. Make sure to include the file, or better yet, use a site like https://pastebin.com/ to add it to the ticket without copy pasting all the contents of the file.
For the Minecraft Launcher : C:\Users\USER\AppData\Roaming.minecraft\logs
For the Technic Launcher: C:\Users\USER\AppData\Roaming.technic\modpacks\pixelmon-reforged\logs
For the ATLauncher: C:\Users\USER\AppData\Roaming\ATLauncher\Instances\PixelmonCraft\logs
For the Twitch Launcher: C:\Users\USER\Documents\Curse\Minecraft\Instances\PACK\logs
Additional context
Add any other context about the problem here.
Since yesterday I can’t use Dynamax for some reason I wear the ring and everything it’s shows me the icon to Dynamax but when I try to dynamax and click Dynamax move nothing happens the Pokémon not Dynamaxing they just stay like they are

Can you add some detail please?
Does it not work in battle when you attempt it, or under certain conditions?

Can you add some detail please?
Does it not work in battle when you attempt it, or under certain conditions?

Hi yes it’s not working in battle when I attempt it not in battle against wild Pokémon raids boss Pokémon’s nothing

Dynamax now works, thank you for reporting!


[Android] Implement the embedding API for setDownloadListener.

This patch is to implement the API for setDownloadListener in XWalkView.
Customer will implement the download listener as needed and override the
default listener in XWalkViewInternal.
BUG=XWALK-3647

LGTM. Thanks hengzhi.

can this be covered by a test?

@axinging Yes, it's no need to implement XWalkView.setDownloadListener.
@rakuco If we add test case for onDowanloadStart, we should override onDownloadStart in XWalkDownloadListenerImpl, but XWalkDownloadListenerImpl is not public.
Two other ways:

Extends from XWalkContentsClient, override onDowanloadStart.
Extends from DownloadListener like as XWalkDownloadListenerImpl, override onDowanloadStart.
Does these two ways make sense? Thanks.

I'd appreciate some feedback from @lincsoon here.
On a broader level, isn't the JIRA ticket you reference in the PR message about making the API public anyway?

The code is LGTM. But as @rakuco saied, the description of the ticket is confusing, please update it.

Can you please describe what's changed? The latest version of the patch is much bigger than the original one, so what's new? Can the last two commits be squashed together?

The last two commits is to implement XWalkView.setDownloadListener and add test case. They can be squashed together. Thanks.

I'm confused too. We'll expose a listener, then implement the interface internally, and expose the class of the internal implementation as well? Let's just submit bug fixing and new API separately.

I will split this PR, thanks.

@lincsoon This PR could first be merged. Thanks.

does it need to be backported?

Yes, I will backport to Crosswalk-14 and Crosswalk-13.


"colors" setting in "add_track"

Thank you for the development of Plot1Cell. This issue is related to issue #6.
Here, I set the collor for plot_circlize and add_track. The plot_circlize works perfectly. But the add_track only use the ordered colors for each clusters, rather than use the correct color for each subsets clusters.
The code is as the following :
`
Order_Celltype_Main <- c(
"EC","VSMC",
"FC","CPC","PreHTC","RegC",
"M1 macrophage"
)
color_Celltype_Main <- c(
"#F8766D","#C49A00",
"#53B400","#00C094","#00B6EB","#A58AFF",
"#FB61D7"
)
names(color_Celltype_Main) <- Order_Celltype_Main
Seurat.object$Celltype_Main <- factor(
x = Seurat.object$Celltype_Main,
levels = Order_Celltype_Main
)
Order_Celltype_Subset <- c(
"EC (SELE)",
"VSMC (IL6)","VSMC (RGS5)",
"FC (AQP3)","FC (CFH)",
"FC (ECRG4)","FC (FOS)",
"FC (HSPB1)","FC (POSTN)",
"FC (PRG4)","FC (THBS4)",
"FC (LOC119877775)","FC (MAGI2)",
"FC (MMP3)","FC (MT1E)",
"FC (RBP4)","FC (S100A12)",
"CPC (STMN1)",
"PreHTC (MMP3)",
"RegC (PTGS2)",
"M1 macrophage (CCL23)","M1 macrophage"
)
color_Celltype_Subset <- c(
"#F8766D",
"#e0b311", "#b4900e",
"#9DB400", "#90B405", "#84B40B", "#78B411",
"#6CB417", "#60B41D", "#54B423", "#48B428", "#3CB42E",
"#30B434", "#24B43A", "#18B440", "#0CB446", "#00B44C",
"#00C094",
"#00B6EB",
"#A58AFF",
"#dd40b8", "#df74c6"
)
names(color_Celltype_Subset) <- Order_Celltype_Subset
Seurat.object$Celltype_Subset <- factor(
x = Seurat.object$Celltype_Subset,
levels = Order_Celltype_Subset
)
Plot1Cell.object <- prepare_circlize_data(Seurat.object, scale = 0.8 )
Plot1Cell.object$Celltype_Main <- factor(
x = Plot1Cell.object$Celltype_Main,
levels = Order_Celltype_Main
)
Plot1Cell.object$Celltype_Subset <- factor(
x = Plot1Cell.object$Celltype_Subset,
levels = Order_Celltype_Subset
)
Plot1Cell.object$Sample <- factor(
x = Plot1Cell.object$Sample,
levels = Order_Sample
)
plot_circlize(
Plot1Cell.object,
do.label = T,
contour.levels = c(0.1, 0.5, 0.9),
pt.size = 0.25,
col.use = color_Celltype_Main ,
bg.color = 'white',
kde2d.n = 1000,
repel = T,
label.cex = 0.7)
add_track(
Plot1Cell.object,
group = "Celltype_Subset",
colors = color_Celltype_Subset,
track_num = 2)
`

The left two figures show the correct color I set. the right figure shows the correct color of "Celltype_Main" by plot_circlize and the wrong color of "Celltype_Subset" by add_track.
Could you please help me?

@HaojiaWu

@grimwoo The issue should have been fixed. Please reinstall the package:
devtools::install_github("HaojiaWu/plot1cell")

Then, use these lines:
color_Celltype_Subset <- c(
"#F8766D",
"#e0b311", "#b4900e",
"#9DB400", "#90B405", "#84B40B", "#78B411",
"#6CB417", "#60B41D", "#54B423", "#48B428", "#3CB42E",
"#30B434", "#24B43A", "#18B440", "#0CB446", "#00B44C",
"#00C094",
"#00B6EB",
"#A58AFF",
"#dd40b8", "#df74c6"
)
add_track(
Plot1Cell.object,
group = "Celltype_Subset",
colors = color_Celltype_Subset,
track_num = 2)

Let me know if it doesn't work.

@HaojiaWu Thank you for your quick reply. However, after your guidance, I still  cannot get the correct color of the sub-cell types.
My package version is <IP_ADDRESS>00 after reinstall.
Or could you help me with the annotation of the plot ? I can accept the default colors, if the plot shown me which color reference to which sub-celltype.


Compilation of vm fails on debian

We build a debian package for release on linux, and it fails with a new compiler warning in
the vm compilation.  This happened in the commit of https://codereview.chromium.org/1439483003
I can get details of the compiler and version with the warning, and add them to the bug.
We can't release a new dev version until this is fixed.
runtime/vm/parser.cc: In static member function ‘static dart::RawObject* dart::Parser::ParseMetadata(const dart::Class&, intptr_t)’:
runtime/vm/parser.cc:1011:11: error: variable ‘thread’ might be clobbered by ‘longjmp’ or ‘vfork’ [-Werror=clobbered]
cc1plus: all warnings being treated as errors

https://codereview.chromium.org/1484653002/

@whesse if the Debian build is good now, could you go ahead and close this? Thanks!


Fix problem with topic title

This page is taking a long time to load and I can only guess it's because of the colon in the title.

Red herring.


Upgrade

The computer becomes very stuttering after the version upgrade

@hcj-life can you provide more detaisl?