New app: A Speech Timer

Nice idea - thanks!
In future, when naming your apps please could you avoid putting a_ in front of them, and ideally not underscores? None of the other apps do it and it's going to mean that when someone goes to https://github.com/espruino/BangleApps/tree/master/apps they see all your apps right up the very top of the list, rather than just being able to look down to s for speechtimer :)


Unnecessary spacing in github.io footer

Describe the bug
The style of the footer on github.io pages does not look right
To Reproduce
Steps to reproduce the behavior:

Go to https://uber.github.io/ludwig/ and https://uber.github.io/ludwig/examples/
Scroll to the bottom
See error

Expected behavior
They should have the same style.
Screenshots
Wrong:

Right:

Environment (please complete the following information):

Browser: Firefox 67.0.1 (64-bits) (also happens in MS Edge and Google Chrome)
Screen: 1440 x 600
OS: Windows 10

Additional context
This was probably optimized for another device/screen size. I would like to know if would be useful to implement some responsive styles or just change padding/font size etc.

If this issue is valid I'd like to work on it. Thanks!

@IgorWilbert thanks for letting us know!
Actually the problem is a little bit more complex: the landing page has a custom css and html that doesn't really fit with the rest of the website, which is built with mkdocs-material.
So at the moment the footer fits well with the style of the homepage, but as you noticed it is different from the style of the other pages because of spacing.
You are welcome to give it a try to make them behave in the same way, but in general it would be better if someone with frontend skills would be willing to undertake the task of making the landing and the other pages use the same css and look more similar.
Unfortunately this is as far as my frontend skills go, so if there's someone else who wants to undertake the task i would be really glad to support their work as much as possible.

Thank you @w4nderlust ! To be honest, I believe I have more experience with front-end than back-end, so I'd be glad to help you with this task. However, I've some doubts:

Would you like them all to have the style of the homepage, the other pages or something in between?
What are the steps to run the documentation website? (I could not find them) I have python and pip installed, so I guess I only need to run pip install mkdocs, cd into some part of the project and run mkdocs serve? Thanks!

The instructions are here: https://github.com/uber/ludwig/tree/master/mkdocs
To begin with I believe making the mkdocs and the landing page parts more similar would be great.
In particular having the footer and the top nav bar in the landing page cover all the width like the other pages will make them more consistent, and also have the same font size.
Another important thing is that now the assets for the two are scattered in different directories, consolidating would be great. Finally, when mkdocs generates its js and css files, sometimes it changes their names including some codes, I believe those are hashes of the mkdocs version or something similar. In the landing page I import them manually, but it would be great to find a way to import them automatically to avoid having to change the html of the landing page manually every time.
If you could help with those things, it would amazing.


npm  package for Vue 3.x does not include utils

Installing npm package using:
$ npm i vue-dndrop@next
does not provide utils

There are multiple references to './utils' and './utils/helpers' in the examples and those paths don't exist? Am I missing something?

@CultivateCreate those are just utils for the documentation. You can find them here


High CPU usage issues

Describe the bug
I'm currently working on a program that draws audio plots.
I'm aware of the high CPU utilization because of the work of drawing cool animations.
However, the program seems to be constantly drawing new frames on a still screen (even when there is no user input).
CPU seems to be being wasted unnecessarily due to continuous frame refreshes.
How can we improve it?
To Reproduce
Steps to reproduce the behavior:

Apply the Suki library and run the program.

Expected behavior
CPU utilization should be close to 0% on a still screen without events
Screenshots
without SukiUI

CPU usage: 0% ~ 1%
with SukiUI

CPU usage: 5% ~ 6%
Environment

OS: Windows 11
Avalonia-Version: 11.0.10

The plotting library used ScottPlot

Hi,
Unfortunately I noticed this behavior a few times ago. The problem is that it does not seem to be one thing in particular that trigger this, but the overall complexity of the logical tree. It's not just removing the dynamic background, or the dialog grid, that can solve this, everything that we use "add" a little complexity and it ends at 4-5%, even on my machine.
Well, it was my observation at least. But performance is a feature, and I kept that problem in my mind, it does not seem normal anyway. I think you maybe found more with the rendering observations, so if I summary well, SukiUI suddenly renders insane amount of frame there and there when normally it would cap at 30 fps ?
Moreover, can you try to use SukiUI theme without using SukiWindow to see what it produces ? just to see if it changes something, I suspect that the SukiWindow is the source of 90% of the performance problem.
It would be great if we find a way to fix this actually 👍

Thank you for your answer. 👍
I also want to continue using this wonderful library.
After the development of the core BM, I will investigate it.
This is just my guess... I think it's related to background animation. (when I see a lot of GC calls at the beginning of the program running)

Thanks for your kind words.
I don't think it's related to the background animation because it's just at startup, and removing it doesn't change anything, but maybe the fps mystery is related

Just did a few test. The weird thing is that if you create a new project and add just one button without even suing SukiWindow, the CPU usage will already be +/- 3%.
So the +/-5% of the SukiDemo project is quite normal after seeing that. It just seems that the existence of SukiUI trigger this 😶🌫
I wonder if it's about how styles or resources are declared or included ? Maybe there is a more optimized way ?
Can you confirm that just using a button in a blank window produce +/-3% CPU too ?

My guess would be the BlurBackground.
I’ve just done a search in code to see if there was any ICustomDrawOperation. I used this in the past to draw a component with skia, and it also resulted in such CPU usage. It does not seem to execute only when the component is invalidated, it’s constantly being called to draw.

The work around I found at the time is here: https://github.com/CyLuGh/HierarchyGrid/blob/main/src/HierarchyGrid.Avalonia/SKXamlCanvas.axaml.cs
It's a control that behaves mostly like the WPF SKCanvas. If I manage to find some time, I'll see if it solves the problem here, but you're free to try if I'm too slow ;)

The BlurBackground isn't use anymore because it wasn't as efficient as I wanted it to be. So basically the file can be completely removed, and I've just tested SukiDemo whith it removed it logically doesn't change anything, so unfortunately it's not the reason.
The weird thing is that just using a button in a "normal avalonia" window already trigger 3-4%.

I did few tests. It's interesting to create a simple window with a button and switch from simpletheme to SukiTheme in App.axaml without changing anything. The Suki variant needs more CPU, +/- 1.5 while SimpleTheme needs +/- 0.5%.
Just for a button. I noticed that few details could be optimized. I probably should remove some boxshadow in some controls because removing shadow from the button free a little percentage. Removing the custom font release some, removing cornerradius too .. Actually every single thing adds a little percentage.
So, it's more a bad news actually, because there is no miracle. At this point I think there are 3 things that could help :

optimizing some controls with heavy not essentials features like shadows
optimizing some resources - removing the old resource of roboto font that is not used anymore seems to free some 0.2 % :|
Investigate the FPS problem raised by @Cardroid which seems to be the only real issue, investigating if SukiUI triggers sudden high fps and why

For reference/reminder, slight performance optimisation could be achieved by using more CompositionAnimations instead of transitions, like this example for GlassCard :

The main problem is that not everything can be animated with CompositionAnimations, but it is reasonable to think about :

modifying every opacity transitions to CompositionAnimation
reworking every popup opening (combobox, etc ..) and the Dialog opening animation to CompositionAnimations

It's good to see it improving little by little. 👍
I'm also attempting to trace the cause of this issue, but it seems like high CPU utilization and redrawing the frame are other issues.
As you mentioned, the complexity of the visual tree seems to be the main culprit for increasing CPU utilization. (Even if I removed the controls that I estimated would be heavy, such as background controls, etc., from the demo project, the same results were seen.)
Unfortunately, I couldn't find where the trigger to redraw the frame was coming from. Tracking stack traces didn't provide any useful clues. 🥲

I've spent a little time looking into this as well, took a variety of snapshots in dotTrace and nothing jumps out at me. Even after the inclusion of the ICustomDrawOperation needed to render the new dynamic background, I noticed little to no increase in CPU usage. I would've agreed that it was just broadly "the complexity of the visual tree" but that would tend to light up some hot paths either with invalidate/measure calls or something similar.
I'm not hugely concerned as we seem to be able to increase complexity and add more features with no real worsening of performance, it's just annoying that we can't seem to make it any better. I think the most productive use of time would be to try and convert every existing control and style to use the ControlTheme to minimise the need for selectors to be so widely used and flatten the visual tree wherever it's possible.
I always keep an eye on CPU/Memory utilisation as I'm working and so far I've not found myself hugely concerned but this is still an issue I'd love to see fixed.

Hi, I on the other hand don't have an unusual CPU load but more GPU load.
I open the demo and the GPU load jumps from 2%->6~7%.
Something is constantly triggered to repaint.

I then looked further for fun, and ended up with "SukiBackground". If I comment out the code in the "SukiWindow" - the GPU load still remains low. I also don't know if there are different loads for the users due to different CPU's and GPU's. Maybe I am completely wrong. I just wanted to throw it into the room.

Yep GPU utilisation for the SukiBackground is much more preferable to CPU load, it was a conscious choice to start offloading some of the heavier visual aspects off to something much more designed for it. The GPU scales much, much better for things like this and leveraging hardware acceleration I believe was the right choice.
Really our only focus should be on the CPU and getting that as low as possible. There are probably optimisations that will improve GPU utilisation in SkiaSharp 3 but I'm not that concerned. SukiUI is very visually rich and as long as the appropriate hardware is being used to do a lot of heavy lifting then I'm a lot more comfortable with that personally.
At some point I'll try and get the SkiaSharp 3 preview running locally for SukiUI to see if we can look forward to any improvements but there are quite a few breaking changes so it might take a while.

<suki:SukiWindow xmlns="https://github.com/avaloniaui"         xmlns:x="http://schemas.microsoft.com/winfx/2006/xaml"         xmlns:d="http://schemas.microsoft.com/expression/blend/2008"         xmlns:mc="http://schemas.openxmlformats.org/markup-compatibility/2006"         mc:Ignorable="d" d:DesignWidth="800" d:DesignHeight="450"         xmlns:suki="https://github.com/kikipoulet/SukiUI"         x:Class="STC.Suki.MainWindow"         Title="STC.Suki">     Welcome to Avalonia! </suki:SukiWindow>
An empty application，only use SukiWindow，CPU usage exceeds 30%, GPU usage exceeds 40%。…(⊙＿⊙；)…

@kikipoulet I think i find what ploblem,but i'm not sure changing that will making another issues, I try it by myself the Cpu and Gpu nearly 0.
SukiUI.Controls.SukiBackground in this file Render function is over and over to call Dispatcher.UIThread.InvokeAsync(InvalidateVisual, DispatcherPriority.Background),if return before the issues will gone!
So is there any reason to call it ? if use DispatcherTimer to call it with 1s is great?

Hi @ShawnXu97 ,
This is a great discovery ! Thank you very much for your work.
Actually, removing the call doesn't seem to change anything, except for the "animated background" functionality I think. @sirdoombox do you confirm ? Maybe we should just call the function when AnimationEnabled property is True ? Or I completely miss it ? During my test I don't notice any changes when removing it.

I notice that the loading control have an incomplete animation if removing this, it seems to be the only problem.

@kikipoulet I'm happy it helped~ about animation doesn't work maybe can try to add some Timer refresh the call to active it, I think the call is keep to draw new frame .but that will be low performance,maybe rebuild a new loading controll is better?

Initially, SkiaSharp was used to draw our custom background. I guess this line is for the "Animated Background" option that is not a big problem to drop or render like that only in this case. It's a feature not even referenced in our documentation because honestly not a lot of peoples will use it.
However, we recently used SkiaSharp too for the loading control because of a memory leak bug when using Inifinite Animation in Avalonia ( https://github.com/AvaloniaUI/Avalonia/issues/17192 ) which, by the way, is quite a problem for the framework.
But I'm not worried, the consistent CPU % leak was more a problem than a loading control, we'll just wait for sirdoombox who knows this part way better than me to see if there is a way to render loading at 60fps only, and correct the background to render only when a style change occurs, or if we look for another solution for the loading control to let the background render only at style changes and solve this issue.

@sirdoombox Cpu using isn't the worse,When i use it the Gpu will 20%~30% on some device , I know the device is not very well but if i want to use it ,this is a big ploblem.
I'm try debug the code,I think the call making Render is a loop ,the render isn't finish, the next render call is running , Is there any way to make the Render only render it self?
PS: In this way i think it will refresh the whole window.

The Render call in ICustomDrawOperation should wait for the GPU to finish it's frame, as the SkiaSharp call to draw the rect with the shader is a blocking one, it also relies on managed memory so that holds. I just double checked and I get ~20% GPU utilisation on a 4070 super and ~5% CPU as-is. Removing the InvalidateVisual call whilst still rendering the frames drops that down to ~3% GPU and ~1% CPU. (Not a perfect test, I have other things running on my system)
Unfortunately the problem is solely the InvalidateVisual call to update animations, to my knowledge there is no way around that and my attempts to run a Task which calls InvalidateVisual less frequently actually resulted in worse performance, not better.
Dispatcher.UIThread.InvokeAsync(InvalidateVisual, DispatcherPriority.Background); switching the priorities for this also doesn't seem to help at all, and it's called pretty much as fast as your system can handle no matter what.
Unless there's something obvious I'm missing, Animation support will necessarily come with a pretty hefty performance hit because of that invalidate visual call, and any attempted solutions to disable the invalidate visual call when animations are disabled causes worse performance again as a separate UI thread invocation to grab the state of the AnimationEnabled property is a big hit.
The only solution to this particular performance woe is removal of animations entirely for the background, and of course a new approach to Loading that doesn't rely on it.

The only solution to this particular performance woe is removal of animations entirely for the background, and of course a new approach to Loading that doesn't rely on it.

Completely agree, thanks for your time and sorry for the skia loading control we're already dropping 🫣
We can then disable skiasharp animations because of performance priority, disable the background animation in SukiDemo, and I'll just find a new trick for a loading control, I'm not worried about that.
@ShawnXu97 if you want you can make the PR that just comment the InvalidateVisual call as you found it, otherwise I'll do it later.

I will investigate SkiaSharp 3.0 as well if I get some time and go a bit more in depth to see if there are any improvements there, though I doubt it.
I am happy to either strip out animations entirely from the underlying API or simply add some extra steps to allow people to force them on if they are happy to eat the performance cost (and I'll put this in the docs too) - it will also allow us to keep trying fixes and track improvements going forward.

We must be careful with SkiaSharp 3.0 because when I tried it it was incompatible with some important libraries like LiveCharts that a lot of peoples use that are still on 2.8, it's kind of annoying

I certainly wouldn't bring it into production but it would be nice to know if it's an issue that will eventually be solved or if it's a limit in Avalonia, would help plan around the feature for the future.
I should have some time maybe this evening to fix up the underlying API to make animations a bit harder to enable with more warnings, I might also look to switch to attached properties for the background because duplicating properties in SukiWIndow is obviously causing maintenance headaches now.

https://github.com/AvaloniaUI/Avalonia/discussions/16357

@sirdoombox @kikipoulet Unfortunately, we were working in the wrong direction from the beginning. After re reading the code, I found that ShaderToyrenderer and Loading are both inherited from Avalonia We don't need to deal with the issue of dynamic background anymore, just remove Dispatcher UIThread.InvokeAsync(InvalidateVisual,  DispatcherPriority.Background); And by continuously calling the InvalidateVisual() method in ShaderToyrenderer and Loading, all issues were resolved!
I didn't submit the PR directly because the method I wrote may not be very good, and I need to determine whether it is in rendering, otherwise it should not be called again, so I still need to trouble the two of you to handle it.

@sirdoombox @kikipoulet Unfortunately, we were working in the wrong direction from the beginning. After re reading the code, I found that ShaderToyrenderer and Loading are both inherited from Avalonia We don't need to deal with the issue of dynamic background anymore, just remove Dispatcher UIThread.InvokeAsync(InvalidateVisual, DispatcherPriority.Background); And by continuously calling the InvalidateVisual() method in ShaderToyrenderer and Loading, all issues were resolved!
I didn't submit the PR directly because the method I wrote may not be very good, and I need to determine whether it is in rendering, otherwise it should not be called again, so I still need to trouble the two of you to handle it.

It seems to move the problem. As a loading control is embedded in every Button control, the same behavior will happen in every page with a button.
InvalidateVisual in Loading :

Invalidate Visual disabled :

However, it's normal that disabling the animation use less CPU, it's just that it seems a little excessive and maybe a pure avalonia animation will cost less, or maybe embed it better in the button. I will take a look and compare it with Avalonia animations to have more informations to base our decision on.

@sirdoombox @kikipoulet @sirdoombox I am not familiar with exact implementation of rendering effects for SukiUI, but I might be able to share some useful information.

Don't use Dispatcher UIThread.InvokeAsync(InvalidateVisual, DispatcherPriority.Background); to trigger next render. It's an old approach, which tied to dispatcher timings. Also overloads dispatcher itself. Instead, use topLevel.RequestAnimationFrame API, where you can call InvalidateVisual from the callback.

Generally speaking, any custom rendering should do as much work as possible on Render thread, and as less as possible on UI thread. Control.Render method is executed on the UI thread, where it collects drawing operations. ICustomDrawOperation.Draw is executed on the Render thread.

ICustomDrawOperation is good for custom rendering, but it still requires manual invalidation on UI thread, as well as re-trigger of Render method. Potentially invalidating way too much. In 11.0 we have a new API to solve this problem - CompositionCustomVisual. We have a sample here. The main difference is that you register this custom visual once when control is attached to the tree. And optionally you send sync-messages via visual.SendHandlerMessage. CompositionCustomVisualHandler then can render itself and invalidate itself, if necessary, without even touching UI thread.

And of course, if re-triggering rendering is not necessary, it's much desired to avoid invalidating anything.

So I compared with a loading control animated with Avalonia Animationand it seems to be quite comparable with skiasharp implementation :

So I guess the plan can be :

Delete animated background for performance
Keep SkiaSharp loading control and improve its implementation if possible thanks to @maxkatz6  advices
Change Button loading system to not keep an invisible Loading control inside, because it affects performance even if not shown, and whatever animation system is used.

@sirdoombox @kikipoulet @sirdoombox I am not familiar with exact implementation of rendering effects for SukiUI, but I might be able to share some useful information.
1. Don't use `Dispatcher UIThread.InvokeAsync(InvalidateVisual, DispatcherPriority.Background);` to trigger next render. It's an old approach, which tied to dispatcher timings. Also overloads dispatcher itself. Instead, use `topLevel.RequestAnimationFrame` API, where you can call InvalidateVisual from the callback.

2. Generally speaking, any custom rendering should do as much work as possible on Render thread, and as less as possible on UI thread. `Control.Render` method is executed on the UI thread, where it collects drawing operations. `ICustomDrawOperation.Draw` is executed on the Render thread.

3. `ICustomDrawOperation` is good for custom rendering, but it still requires manual invalidation on UI thread, as well as re-trigger of Render method. Potentially invalidating way too much. In 11.0 we have a new API to solve this problem - `CompositionCustomVisual`. We have a [sample here](https://github.com/AvaloniaUI/Avalonia/blob/3e3d434cf229a3f4dd0d18b1ba4bd5b72b1d41a6/samples/ControlCatalog/Pages/CompositionPage.axaml.cs#L193-L316). The main difference is that you register this custom visual once when control is [attached to the tree](https://github.com/AvaloniaUI/Avalonia/blob/3e3d434cf229a3f4dd0d18b1ba4bd5b72b1d41a6/samples/ControlCatalog/Pages/CompositionPage.axaml.cs#L203-L210). And optionally you send sync-messages via `visual.SendHandlerMessage`. `CompositionCustomVisualHandler` then can render itself and invalidate itself, if necessary, without even touching UI thread.

And of course, if re-triggering rendering is not necessary, it's much desired to avoid invalidating anything.

Utilising the topLevel.RequestAnimationFrame for invalidating the visual had a minor but not insignificant improvement when it came to performance, the problem seems to be that InvalidateVIsual call and without it the background simply doesn't update unless another control on top of it invalidates. My understanding is that the Render method of ICustomDrawOperation isn't called until the invalidation happens. Obviously any time Invalidate is called the GPU gets hit relatively hard.
I've taken a quick look at the CompositionCustomVisual sample you provided and whilst it's a little confusing I broadly see how it works, however I'm concerned that the end result would still require a per-frame InvalidateVisual to actually cause the background to update though I'm not sure about that.
I feel as if I'm getting a bit out of my wheelhouse here, rendering is not really something I'm super familiar with.

however I'm concerned that the end result would still require a per-frame InvalidateVisual to actually cause the background to update though I'm not sure about that.

If you need your background to continuously render, i.e. animating, then yes - you will need to invalidate it each frame.
But the deal is how you invalidate that.
Normal Control.InvalidateVisual() invalidates UI control, potentially causing whole app to re-collect render draw operations (i.e. call Control.Render() method everywhere, just in case if any of these controls overlap).
But if you call CompositionCustomVisualHandler.Invalidate(), from the inside of the render thread, this thread will keep the same scene graph of draw operations from the previous frame, while invalidating operations of this particular composition visual.
It still will re-draw the app, but this time all work will be done on Render thread only, reusing most of the operations from previous frames.

It still will re-draw the app

Note, it's forced by modern GPU based rendering APIs, like DX11/OpenGL, where it's easier to re-draw whole scene, then re-draw particular rectangle. But we do support the latter for embedded devices with framebuffer rendering.

I quickly switched over to CompositionCustomVisual this morning to see if it would have any major effect on performance but unfortunately it made no difference whatsoever - though the ability to easily control invalidation really helped with preventing Invalidate calls when animations were disabled.
The underlying Invalidate call is just a killer for us, there's no getting away from that 4-5% CPU and 20-30% GPU utilisation it seems like, even when I only use canvas.Clear(SKColors.Gray); so that none of our effects are running and nothing actuallly changes between each frame, the GPU usage remains equally high because of the Invalidate call. It's also telling that even when running a relatively complex shader on top on the ShaderToy style Effects page, GPU usage remains high, but completely flat.
I think animated backgrounds are pretty much an impossibility in Avalonia at the moment, the need to redraw the entire window when a control at the very back covering the entire window is invalidated is just too big of a performance hit, 20% utilisation on a high end modern GPU isn't really reasonable for a simple visual feature on a desktop app.
I'll rewrite everything internally to use CompositionCustomVisual and retain the ability to use animations, but I will mark it with warnings both in XMLDocs and in our other documentation that it's highly experimental and comes with a huge performance cost.

This should be largely resolved at this point. Obviously enabling animations still has a pretty big impact on performance but the default state of SukiUI should now be significantly more performant with the switch to CompositionCustomVisual allowing us to only invalidate what we need when we need.
The only outstanding issues are that the Loading control still uses animated effects and causes some performance issues.
I think the issue should stay open until Loading is dealt with and we get some follow ups from people confirming that the performance is more in line with what they are expecting.


Contact Us page is not responsive

The Contact US page isn't responsive, so can I work on this under Hacktoberfest '22?

@MohitNamdev22 You can work on it


Scrolling using mouse doesn’t work in left panel

Browser: Firefox on macOS

When you scroll far away from your cursor in editor, the cursor stays where it was. When you then start typing or start to navigate via keyboard (arrows, home/end etc.) which might result in a confusing skip, but it seem to me as standard behavior. Is this related?
If not, I was not able to reproduce. Watched the GIF several times. Can you write down the steps needed to replicate the bug?
Tried scrolling with scroll in preview, and scroll, arrows (navigating out of visible) and ctr+arrows for keyboard scrolling in editor. All of those seem to be working in Chrome as well as in Firefox.

It's not visible in the gif - first I scroll using mouse in the right panel, then I move cursor to the left panel and scroll again, but nothing happen.

Still could not reproduce on current master (deployed Fri, 08 Dec 2017 13:39:25 GMT) on Linux FF 57.0.1 (64-bit).
You experienced the issue somewhat near the time it was reported? (#46 has been merged and deployed several hours before.)

Yes, few minutes before report. Try it on Firefox LTS (52).

Tested on 52.5.2 (64-bit) Linux. It does behave strangely. I am using touchpad scroll and sometimes scrolling in editor is somewhat ignored when swiping too fast. Perhaps this behavior is always triggered using mousewheel.
This is probably an issue related to a sloppy (as it turns out... :crying_cat_face:) implementation of safeguard to prevent infinite scroll propagation amidst the columns. (onscroll editor scrolls preview, which has an onscroll which scrolls editor, which has an onscroll that was triggered initially theoretically running in loop).


Search input ARIA role error

In the header of the site we have the 'search documentation' input. When @molant runs the site through Sonar, we're getting a warning that says "Certain ARIA roles must contain particular children"
I don't have a role assigned to that input but a role is being assigned to it after the fact, and I'm assuming this is through however Algolia is configured.

I believe the role=combobox that is being added to the input is causing the error because this input isn't a combobox, and I believe a role isn't required here but will need to confirm that.
@qzhou1607 I think you researched Algolia, but let me know who I should assign to this if it's not you.

@ststimac I will take a look again at Algolia's documentation again. I'll remove it if role is not needed.

@ststimac @molant It seems that this combobox thing is a false detection in axe-core. See https://github.com/dequelabs/axe-core/issues/160. Unfortunately these accessibility attributes came with Algolia's autocomeplete library and is not configurable. Here is the source code (options contains the data for configuration). Any suggestion?


issue paypal in context

Hi,
I have an error, when i try used in context. I make official paypal module on prestashop addons.

The exact browser version
Version 61.0.3163.100 (Build officiel) Built on Ubuntu , running on Ubuntu 16.04 (64 bits)
A link to your page with the issue, if possible
https://paypal_422.work.202-ecommerce.com (user : paypal / pwd : support_paypal)
All console logs during the time of the issue, especially error messages
VM1721 checkout.js:327 ppxo_xc_ppcheckout_unexpected_listener_init {origin: "https://www.sandbox.paypal.com", domain: "https://www.paypal.com", timestamp:<PHONE_NUMBER>619, windowID: "7e19c85a00", pageID: "c1fed88b25", …}
print @ VM1721 checkout.js:327
log @ VM1721 checkout.js:423
error @ VM1721 checkout.js:458
error @ VM1721 checkout.js:7810
Component.logError @ VM1721 checkout.js:4658
(anonymous) @ VM1721 checkout.js:3958
(anonymous) @ VM1721 checkout.js:2836
ZalgoPromise.try @ VM1721 checkout.js:8263
_RECEIVE_MESSAGE_TYPE.(anonymous function) @ VM1721 checkout.js:2832
receiveMessage @ VM1721 checkout.js:2765
messageListener @ VM1721 checkout.js:2786
VM1721 checkout.js:327 ppxo_paypal_legacy_component_error {error: "Error: Unexpected init message from domain https:/…://www.paypalobjects.com/api/checkout.js:2786:13)", timestamp:<PHONE_NUMBER>622, windowID: "7e19c85a00", pageID: "c1fed88b25", referer: "paypal_422.work.202-ecommerce.com", …}

Does the issue occur consistently, or intermittently?
consistently

Steps to reproduce
Add a product to cart
go to checkout
Create an account
valide your address
choose a shipping
Select paypal and click on

Affected browsers

[X] Chrome
[ ] Safari
[X] Firefox
[ ] Edge
[ ] IE
[ ] Chrome Mobile/Tablet
[ ] Safari Mobile/Tablet
[ ] Web View / Safari ViewController
[ ] Other

Looks like you have the following code:
window.paypalCheckoutReady = function() {
        paypal.checkout.setup(merchant_id, {
            environment: environment,
            container: 'paypal_in_context_container'
        });
    };

This is being called when the paypal button is clicked, but really you need to call this and set window.paypalCheckoutReady when the page is loaded. Otherwise the environment is not set soon enough.
Also -- this is an old, deprecated integration pattern. Ideally you should be using the new style checkout.js button which avoids many of this problems:
https://developer.paypal.com/docs/integration/direct/express-checkout/integration-jsv4/add-paypal-button/
https://developer.paypal.com/demo/checkout/#/pattern/server


more gui not available for localization

This is a server message error directly shown there. The server is not returning the structured data to detect the type of error and show this translated in the interface. So... or the server adds structured data identifying the error, or the server translates the message or we accept that server error messages are untranslated. @mariano54 @hoffmang9 What is the expectation about this?

Good point. In the server rpcs, we usually throw a ValueError("random error message str"), which is caught by rpc server.
Instead, we should probably throw one of the values in the Err class (src.util.error).
And in the rpc server we can catch that and turn it into an integer.
This might be kind of hard to do because there are many places where exceptions are thrown, in many parts of the code. But we can start with some, like this error.


filters: autosuggest to pick fkey values in filter UI

related to #2 - #2 is about showing the label after a user has picked it
It would also be nice to make it easier to pick the right entry, eg you start typing and you get a dropdown that shows the choices that match

see also https://github.com/simonw/datasette/issues/1890, which I think I broke by making facets lazy.

The datalist autosuggest is something, gonna close this. If we do anything, it'll be in the omnibox.


[Community Tutorial] Forest vegetation condition

Turns out this is my first PR, so I'm not sure if I'm getting this right. Looking forward to review comments.
Closes #184

Thanks for your patience, Pradeep! Here are the next steps for publishing:

[ ] Editorial review - @gino-m
[ ] Subject matter review - @n-clinton
[ ] Final production review for publishing - @gino-m

Giving it a first pass now.

Thanks for your comments, Gino!
I have addressed them all I think, and this is to alert you to it. I'm not sure if I'm supposed to do anything else to get these changes back to you for checking. If so, please point me to it? (I noticed there is a "Submit Review" under "Review Changes" in this page but wasn't sure what it'll do)
I tried but couldn't understand the errors presently on the Travis CI by following the red 'x' on the latest commit. Help, please?

I have addressed them all I think, and this is to alert you to it. I'm not sure if I'm supposed to do anything else to get these changes back to you for checking. If so, please point me to it?

You could click "re-request review" next to my username under reviewers () but your message is also sufficient. Thanks for the heads up!

I tried but couldn't understand the errors presently on the Travis CI by following the red 'x' on the latest commit. Help, please?

Sorry for the obscure error message. I think it expected a final "." on the description in the header. Could you try adding one there?
Thanks for all the edits! Over to @n-clinton for technical review.

@pskoulgi great tutorial - thanks for submitting!
The premise and logic are good, however, there are a few things that I recommend changing/adding to improve it. Instead of trying to address them all in the PR .md file review interface, I've listed them below. Additionally, I included a suggested script that resolves them. Please try to integrate the provided script into the .md file.

[ ] Avoid building collections by mapping over a list. It works fine in your case, but when possible, it is better to use a join.
[ ] Use a forest mask to exclude pixels that are not forest.
[ ] Add histogram charts of slope for each region to more easily convey the distribution of slope values. The map display sort of does this, but the histogram is more quantitative. It would be nice to add the two histograms as a side-by-side image in the .md file as a .png figure.
[ ] Set the year and max EVI bands in the order you want them for the slope calculation instead of selecting them later to define the order. (nit)
[ ] For the table, convert sq m to sq km to make more relatable, also provide greening and browning as a fraction of forested area.
[ ] Use a color palette for the slope map that has a greater brightness range and increase the min/max range to show more variability.
[ ] Use a keyword dictionary for functions with many inputs so users know what each one is.
[ ] Treat comment style more like sentences - capital letters and periods. (nit)
[ ] Use clang Google style format. (nit)

These things are all done in this script: https://code.earthengine.google.com/2c67926067c0c2efa679fe5425d54c58
Please use this list in comments accompanying PR edit commits to let me know what you've addressed in your .md file and/or what you would like to discuss.

@jdbcode Thank you so much for your thoughtful review and helpful comments! I feel like they improve the tutorial a great deal. I have addressed, I think, all of them except one, which I'd like to discuss more about.
Each of your comments are addressed in (mostly) one commit, see inline below for which specific ones.

* [ ]  Avoid building collections by mapping over a list. It works fine in your case, but when possible, it is better to use a join.

Done in commit 30dfeb6.

* [ ]  Use a forest mask to exclude pixels that are not forest.

I feel doubtful of using the MODIS percent tree cover product to define where the analysis is run, in this landscape. Hence, I have not made this change, and (for now) have calculated percent of total area in response to your other comment below.
The landscape these national parks occur in has a good mix of vegetation types, including dry deciduous forests and tree-grass mosaics with relatively sparse tree cover, and scrub. So even areas not clearing the 10% tree cover threshold can have vegetation making up important natural habitat, and hence might warrant condition trends evaluation. Also, I worry that at the low end of 10, the accuracy of percent tree cover estimate might drop too.
In the spirit of tutorials as guides for what is possible to do and how, I agree integrating percent tree cover threshold here might be useful. If we decide to do so, I would prefer to take a couple of lines to mention the caveats in using this metric and state that it is a choice to be made with careful consideration to the landscape and goals of the analysis. On the other hand, I'm happy to leave it out too! :)
I look forward to your thoughts on this.

* [ ]  Add histogram charts of slope for each region to more easily convey the distribution of slope values. The map display sort of does this, but the histogram is more quantitative. It would be nice to add the two histograms as a side-by-side image in the .md file as a .png figure.

Done in commit 86c8a29.

* [ ]  Set the year and max EVI bands in the order you want them for the slope calculation instead of selecting them later to define the order. (nit)

Done between commits 216e5db and 30dfeb6.

* [ ]  For the table, convert sq m to sq km to make more relatable, also provide greening and browning as a fraction of forested area.

Done in commit bd6f196.
I have done fraction of total feature, instead of "forest"ed, area because of my doubts with using MODIS percent tree cover to define "forest" (see response to point above for more).

* [ ]  Use a color palette for the slope map that has a greater brightness range and increase the min/max range to show more variability.

Done in commit 088e7bc.

* [ ]  Use a keyword dictionary for functions with many inputs so users know what each one is.

Done across previous commits and b6bf73e.

* [ ]  Treat comment style more like sentences - capital letters and periods. (nit)

Done across previous commits and 5458123.

* [ ]  Use clang Google style JS code formatting. (nit)

Done, I think, across previous commits where I borrowed heavily from your suggested code.
I had to look for what exactly is the style and landed here, which seems like a complete guide. Instead of getting lost reading through it, I have tried to consistently apply the style in your suggested code. Let me know if I have missed anything.

These things are all done in this script: https://code.earthengine.google.com/2c67926067c0c2efa679fe5425d54c58

This was most helpful, thank you!!

Please use this list in comments accompanying PR edit commits to let me know what you've addressed in your .md file and/or what you would like to discuss.

I've done this, as best as I could, learning as I go about how to correctly link things up. I hope this came out right. (I @ you in each commit description, not sure if that was excessive @ ing! :))

Yes, thank you! :)

Thank you, @gino-m !
Unknowingly I started this work on the 'master' branch of my fork, and I now have a vague feeling that that's not the recommended thing to do. What, if anything, do I need to do to fix that?

Unknowingly I started this work on the 'master' branch of my fork, and I now have a vague feeling that that's not the recommended thing to do. What, if anything, do I need to do to fix that?

No worries at all! It's only an issue if you want to submit more than one PR at a time, since GitHub associates each PR with the branch where it was created. Since you're only submitting one at the moment, no action is required.

Thank you, @gino-m and @jdbcode , for your all help, even as I navigated this process for the first time! It was a pleasure working with both you on this submission!

Absolutely! Check now?

@pskoulgi - your tutorial has been published - congratulations! 🎉
https://developers.google.com/earth-engine/tutorials/community/forest-vegetation-condition
I'll post a link to it on Twitter - do you have an account that I can use to tag you?

Congrats, @pskoulgi, nice job!

I'll post a link to it on Twitter - do you have an account that I can use to tag you?

Thank you @jdbcode ! :) I'm over at @\pklgeez


Remove 'Life as a phoenix' section in aside-nav

It is expected behaviour since it is present in stage.phoenix asideNav html


[PyTorch] Check network interface name when initializing Userbuffers

Description
te.initialize_ub() constructs a list of ranks on the same physical node by comparing hostnames from network interfaces defined by NVTE_UB_SOCKET_IFNAME, NCCL_SOCKET_IFNAME or GLOO_SOCKET_IFNAME environment variables, in that order of priority. If none are defined, it falls back on using os.gethostname() instead.
This approach fails when NCCL_SOCKET_IFNAME is set to a base name like eth while the actual network interfaces are named eth0, eth1, and so on.
This PR avoids the error by checking the detected interface name against interfaces found in socket.if_nameindex() and falling back onto os.gethostname() with a useful warning message when the detected name is not valid.
Fixes #1170
Type of change

[ ] Documentation change (change only to the documentation, either a fix or a new content)
[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Infra/Build change
[ ] Code refractor

Checklist:

[x] I have read and followed the contributing guidelines
[x] The functionality is complete
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[x] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes

/te-ci pytorch


Bug 2053582: Track static pod lifecycle

Effort based on https://github.com/openshift/cluster-kube-apiserver-operator/pull/1317 and including the following gists written by @p0lyn0mial to address a comment regarding the termination grace period:

https://gist.github.com/p0lyn0mial/363f5f1c04c1ff6b607d8358a123dc53
https://gist.github.com/p0lyn0mial/abd14f30fe1f83b849e5f7f9f9811275

proof: https://github.com/openshift/cluster-kube-apiserver-operator/pull/1319

/retitle Bug 2053582: Track static pod lifecycle

cc @deads2k

/lgtm
/approved
/hold
(once the proof PRs have a few greens on the runs, we can cancel the hold)

/approve

(results in proof PRs look good)
/hold cancel

/cherry-pick release-4.0

/cherry-pick release-4.10


Sorting: WIP see desc

getting the following error for the
employee.component.html:
Property '$sortEvent' does not exist on type 'EmployeesComponent'.
unsure where exactly specific to this but thought I would commit  and submit a pr and I could update

Taking a look at now

awesome


[Bug] When the sampling rate is 0 and the code exists across goroutine, ExitSpan has a problem of failure to create. err: span type is wrong

Search before asking

[X] I had searched in the issues and found no similar issues.

Apache SkyWalking Component
Go Agent (apache/skywalking-go)
What happened
In the following scenario, Gin handler serves as the entry point and calls 2 mongo operations through goroutine.
Gin --  EntrySpan  (NewNoopSpan() -> SET_GLS(NoopSpan{stackCount: 1}))
|
(sync.Group)
MongoClient  ExitSpan  (GET_GLS() ->  NoopSpan{stackCount:0} -> noop.enterNoSpan() -> span.End() -> SET_GLS(nil) )
|                                                                 (Why stackCount is 0 ?)
MongoClient  ExitSpan  (GET_GLS() -> nil)
In the 2nd ExitSpan, ctx.ActiveSpan() returns nil, Then createSpan0() returns NoopSpan.

The following is debug mode:
Gin CreateEntrySpan，ctx:

The first CreateExitSpan within the goroutine, ctx:

Second CreateExitSpan inside goroutine, ctx:

What you expected to happen
In the first ExitSpan, The stackCount of ActiveSpan() obtained by GetTracingContext() should be 1.
in the 2nd  ExitSpan, getTracingContext() -> ActiveSpan() Should not be nil.
How to reproduce
After changing the sampling rate to 0, run the following test code.
package main

import (
    "fmt"
    _ "github.com/apache/skywalking-go"
    "github.com/gin-gonic/gin"
    "go.mongodb.org/mongo-driver/bson"
    "go.mongodb.org/mongo-driver/mongo"
    "go.mongodb.org/mongo-driver/mongo/options"
    "golang.org/x/sync/errgroup"
)

type ErrorGroup struct {
    errgroup.Group
}

func main() {
    r := gin.Default()
    r.GET("/mongo_get", mongoGet)
    r.Run()
}

func mongoGet(c *gin.Context) {
    var e ErrorGroup
    var m, _ = mongo.Connect(c, options.Client().ApplyURI("mongodb://<IP_ADDRESS>:27017"))
    filter := bson.D{{"name", "test"}}
    e.Go(func() (err error) {
       collection := m.Database("demo").Collection("testCollection")
       _, err = collection.Find(c, filter)
       if err != nil {
          return err
       }
       fmt.Println("first Find Done")
       _, err = collection.Find(c, filter)
       if err != nil {
          return err
       }
       fmt.Println("second Find Done")
       return nil
    })
    err := e.Wait()
    if err != nil {
       fmt.Println(err)
    }
}

Observe the log, you can find that the log will print the following error:
cannot create exit span on mongo client: span type is wrong
Anything else
No response
Are you willing to submit a pull request to fix on your own?

[ ] Yes I am willing to submit a pull request on my own!

Code of Conduct

[X] I agree to follow this project's Code of Conduct

Which version are you using? There was a relative fix in 0.4 release, https://github.com/apache/skywalking-go/pull/161

Which version are you using? There was a relative fix in 0.4 release, apache/skywalking-go#161

version 0.4.0

Please check gmail to discuss the same issue，ty

Recheck 0.5. It should have been fixed.


nitro-cli: Fix Docker pull image logic

Check if the Docker image used for building the enclave image is only
locally available, when trying to pull the Docker image. Do not return
an error in that case.
Update the tests to use the locally built Docker image of the command
executer, instead of the remote one, to cover this test case.
Signed-off-by: Andra Paraschiv<EMAIL_ADDRESS>Issue #239
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Thanks @andraprs, I think this is a great solution.

You are welcome.


Can't change brightness because another app is controlling it

Hello, thank you for your library.
It's not problem of this exactly library but when we are control brightness we can't change it via System settings and see "Can't change brightness because another app is controlling it" warning until app is closed.
Maybe possible to avoid this behaviour and release it after unmount for example?
Thank you in advance.

@indapublic
I assume such behavior happens on Android?

@reeq-dev Correct

@reeq-dev Yes, it was first thing in your library I tried


Reducing files in Root dir

Summary of the Pull Request
I'm a big advocate of keeping the root dir as clean as possible.  As moving items can be highly disruptive, this will be a slow process.

PR Checklist

[ ] Closes: #xxx
[ ] Communication: I've discussed this with core contributors already. If work hasn't been agreed, this work might be rejected
[ ] Tests: Added/updated and all pass
[ ] Localization: All end user facing strings can be localized
[ ] Dev docs: Added/updated
[ ] New binaries: Added on the required places

[ ] JSON for signing for new binaries
[ ] WXS for installer for new binaries and localization folder
[ ] YML for CI pipeline for new test projects
[ ] YML for signed pipeline

[ ] Documentation updated: If checked, please file a pull request on our docs repo and link it here: #xxx

Detailed Description of the Pull Request / Additional comments

Validation Steps Performed

I'm a big advocate of keeping the root dir as clean as possible.

This feels a lot like a (personal) opinion. I don't think there's any problem with having these files at the root of the repo. Actually, I think they belong in their current place. These things are not part of the source for the app at all, they are circumstantial.

@crutkas
I know it's out of scoope. But I wonder if it makes sense to add the pipeline directory to the CODEOWNERS file for protection too.

I need to lock down other files too. But yeah, outside this

Trying to move a few more into this.  I can't seem to get it quite right ...


Review a11y outlines across Zen

Outlines are important for a11y, so users who are tabbing through the site know what elements they're interacting with.

The purpose of this issue is to review these instances where we can perhaps replace the outline with other visual cues that the element is in focus. Any suggestions are very much welcomed.

I think the most important is to see where outlines occur, but no real interaction is connected. E.g. around the entire container of a dojo when opened. Only the purple arrow closes the panel.

Another example is around a user, it already has visual queues with changing background colors so the outline is pretty much overkill:


[bug]  Qhub install steps missing or incorrect

Describe the bug
I installed Qhub on AWS today, using my own domain provider and using github authentication.   I expect this is a common use case.
I found a few issues with the documentation:
In the github actions setup section it's not clear that env variables should be set.   I think it should be this, right?
export GITHUB_USERNAME=
export GITHUB_TOKEN=

also if you are using github auth, I don't think it's mentioned that you will need to go to github developer settings and set up an oauth application, that will generate a client_id and client_token, and that you should use specify your callback url as <cname><domain>/hub/oauth_callback, like https://jupyter.qhub.earthmap.us/hub/oauth_callback
Is it necessary to set this?
export REPOSITORY_ACCESS_TOKEN=

It should also be mentioned that your github user should have a ssh keypair set up (I didn't, and couldn't put to main, even though the REPOSITORY_ACCESS_TOKEN was set)
Also, if you don't choose to use cloudflare, the instructions say (or could be misinterpreted?) that you should set
qhub deploy -c qhub-config.yaml --dns-provider none

but that complains.  I think it's:
qhub deploy -c qhub-config.yaml

@rsignell-usgs, we just finished the process of deploying qhub on AWS as well.  And by "we" I mostly mean @iameskild, and I think he also has some notes on improvements for the documentation.
We ran into a variety of issues, most notably #644, which severely limited the number of dask workers we could scale out, we were only able to get 9 workers, although this did get resolved in #645.  But for now to make use of that change we are having to install qhub from either that commit or the master branch.  This unfortunately breaks the GitHub Actions workflow, so let me take this opportunity to plug my suggestion in #113.
To one of your points, the instructions incorrectly indicate:

If an alternate DNS provider is desired, change the --dns-provider flag from cloudflare to none on the qhub deploy command.

But that command line option does not include none (or None) as an option as seen here.  So either the docs need to be updated or the appropriate choice added to the command line option, both of which should be trivial changes.
I'll also gratuitously take this opportunity to plug #325, which I think would be a great integration offering wide DNS provider support based on ExternalDNS.
Also thought it might be worth noting that it is no longer necessary to prepend jupyter. to the domain name, since that was addressed by #383.
Happy hubbing!  :)

Not sure, but this probably hasn't been fixed yet.


Error First step installing

Hello,
when I type intall.ps1 I get this message

Hope Its a stupid thing but I don´t know how can I solve it

That's because 'https://boxstarter.org/bootstrapper.ps1' the file is missing , response 404. You can replace the url to a avaliable one. Just modify the install script

@Redcell202 make sure in github you are downloading the source for the file, it looks like you downloaded the HTML along with the install script. There is a little button that says "Raw"

You should be using that button if you want to just download the script. Otherwise, you can download the full zip and unzip. the install script will be in there

Make sure you are following the install instructions carefully 😄 https://github.com/mandiant/commando-vm#instructions

I just run successfully , replace the url by 'https://raw.githubusercontent.com/chocolatey/boxstarter/master/BuildScripts/bootstrapper.ps1'  in line 196 , or just run
iex ((New-Object System.Net.WebClient).DownloadString('https://raw.githubusercontent.com/chocolatey/boxstarter/master/BuildScripts/bootstrapper.ps1')); get-boxstarter -Force  and comment out the line 196 , then run.

您好请关注一下https://github.com/mandiant/commando-vm/issues/276 ，急需解决方案谢谢
Hello, please pay attention https://github.com/mandiant/commando-vm/issues/276 , urgent solutions thank you

Hello, please pay attention https://github.com/mandiant/commando-vm/issues/276 , urgent solutions thank you

确保您仔细遵循安装说明😄 https://github.com/mandiant/commando-vm#instructions

Hello, please pay attention https://github.com/mandiant/commando-vm/issues/276 , urgent solutions thank you

Feel free to open another issue if you're still running into problems. Closing because of age


Discoverability of the docs

I've been looking for Travis CI integration information, and it appears that the docs have a great section on them. However on the linked page Installation, those pages are not discoverable. Eventually I discovered them through additional Google searches. Then it becomes apparent that 'Installation' is just a chapter and by clicking "swiftenv" in the upper-left corner shows the other chapters.
Thanks for your work!

Hi @Bouke, thanks for the suggestion, I've updated the README in 3c82014 to link to the integrations too. If you have any other suggestions on improving the visibility let me know (or feel free to make a pull request).


Acroform Date field format not working

Bug Report
Description of the problem
Just trying to create a form with a date field. Setting a formText() format doesn't seem to do much. In Chrome and MacOS Preview the date field doesn't support or isn't prompted to show the date picker, and the format param isn't honoured. In Acrobat Reader there's a drop down date picker, but picking a date doesn't set the field value to display using the param format. Changing the year in the date picker doesn't show the date either. So I can have 2 dates from 2024 and 2023 and they're not displaying correctly.

doc.fontSize(10).formText(field.name, xOffset, lOffset, fieldWidth - 10, lfieldHeight, {
    format: { type: 'date', param: 'yyyy-mm-dd' },
})

I'm not sure if I'm doing something wrong or what to expect. The docs don't set much in the way of expectations.
The pdfkit docs (https://pdfkit.org/docs/forms.html#text_field_formatting) Acrobat SDK link is broken as well:
"When needing to format the text value of a Form Annotation, the following options are available. This will cause predefined document JavaScript actions to automatically format the text. Refer to the section Formatting scripts in Acrobat Forms Plugin of the Acrobat SDK documentation for more information."
Code sample

I wasted enough time with repl.it accessing my GitHub account and it doesn't build a pdf correctly. Try this:
const Document = require('pdfkit')
const fs = require('fs');

const doc = new Document();

doc.pipe(fs.createWriteStream('output.pdf'));

doc.initForm();
doc.fontSize(10).formText("date", 100, 100, 100, 25, {
    format: { type: 'date', param: 'yyyy-mm-dd' }
})

doc.end();

Your environment

pdfkit version: 0.13.0
Node version: 20.12.1
Browser version (if applicable): Chrome (Linux), Chrome (Mac), Preview (Mac), Acrobat DC Reader 2022.002.20212
Operating System: Linux, macOS

Nobody? Is this the extent of what PDF offers for date fields? Is there another correct date field or usage that'll unlock something similar to what typical browser offer?


[CARBONDATA-3457][MV] Fix Column not found issue with Query having Cast Expression

Problem:
For Cast(exp), alias reference is not included, hence throws column not found exception for column given inside cast expression.
Solution:
AliasMap has to be created for CAST[EXP] also and should be replaced with subsmer alias map references.

[ ] Any interfaces changed?

[ ] Any backward compatibility impacted?

[ ] Document update required?

[ ] Testing done

[ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.

Build Success with Spark 2.1.0, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder2.1/3730/

Build Success with Spark 2.3.2, Please check CI http://<IP_ADDRESS>:8080/job/carbondataprbuilder2.3/12006/

Build Success with Spark 2.2.1, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder1/3942/

Build Success with Spark 2.1.0, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder2.1/3738/

Build Success with Spark 2.3.2, Please check CI http://<IP_ADDRESS>:8080/job/carbondataprbuilder2.3/12014/

Build Success with Spark 2.2.1, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder1/3950/

@ravipesala @akashrn5 please review

LGTM

retest this please

Build Success with Spark 2.3.2, Please check CI http://<IP_ADDRESS>:8080/job/carbondataprbuilder2.3/12037/

Build Success with Spark 2.2.1, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder1/3973/

Build Success with Spark 2.1.0, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder2.1/3765/

retest this please

Build Success with Spark 2.1.0, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder2.1/3802/

Build Success with Spark 2.3.2, Please check CI http://<IP_ADDRESS>:8080/job/carbondataprbuilder2.3/12080/

Build Failed with Spark 2.2.1, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder1/4013/


Unexpected type inference on array fields

Describe the bug
SafeQL infers any type on fields that returns an array, leading to a Query has incorrect type annotation error when type any is not passed to this field.
The example below will throw the above error on FoodNames because a type other than any is being passed
type AnimalWithFoodName = {
  firstName: string;
  foodNames: string[];
};

export async function queryJsonAgg() {
  return await sql<AnimalWithFoodName[]>`
    SELECT
       first_name,
       (SELECT json_agg(name) FROM foods) AS food_names
    FROM
      animals
  `;
}

To Reproduce
Steps to reproduce the behavior:

Setup SafeQL
Use this code in .ts file

type AnimalWithFoodName = {
  firstName: string;
  foodNames: string[];
};

export async function queryJsonAgg() {
  return await sql<AnimalWithFoodName[]>`
    SELECT
       first_name,
       (SELECT json_agg(name) FROM foods) AS food_names
    FROM
      animals
  `;
}

Expected behavior
A clear and concise description of what you expected to happen.
I expect that SafeQL doesn't throw an error when the correct type is being passed and should infer the correct type
Using type any is not encouraged in TypeScript and should also be discouraged in SafeQL
Screenshots
If applicable, add screenshots to help explain your problem.
Incorrect type annotation error when the correct type is passed

No error when any type is passed

Desktop (please complete the following information):

OS: MAC OS
PostgreSQL version 15
Version [e.g. 22]

Additional context
Add any other context about the problem here.

json_agg method returns a json, which by default I map to any since the majority of the Typescript community prefer any over unknown. But you could change that behavior in the overrides.types.
What you want is array_agg instead:
type AnimalWithFoodName = {
  firstName: string;
  foodNames: string[];
};

export async function queryJsonAgg() {
  return await sql<AnimalWithFoodName[]>`
    SELECT
       first_name,
       (SELECT array_agg(name) FROM foods) AS food_names
    FROM
      animals
  `;
}

Thank you, @Newbie012, I will give this a try


Proper CancellationToken handling for ListPrompt. Fixes #1076.

Proper CancellationToken handling for ListPrompt.

This is definitely an issue in TextPrompt, possibly also MultiSelectionPrompt. Ideally a fix would cover all of the possible prompts.


[move-prover] Ported Prover's test cases

Ported test cases from MVIR Prover
Updated Prelude to resolve a few issues

Motivation
To port test cases from old MVIR prover's
Have you read the Contributing Guidelines on pull requests?
Yes
Test Plan
cargo test
Related PRs

@bors-libra r=wrwg

:pushpin: Commit 3daeccd has been approved by wrwg

:hourglass: Testing commit 3daeccdde307efeb35f2ac150ef1ce20879651e6 with merge 151cfde08be7c1b127972a304cfc0cee05795418...

:sunny: Test successful - checks-actions_land_blocking_test, checks-circle_commit_workflow
Approved by: wrwg
Pushing 151cfde08be7c1b127972a304cfc0cee05795418 to master...


Any simple JS to activate a step????

Looks like I have everything loaded correctly - but cannot figure out how to set a step or segment to active - all help is appreciated - TIA!

Anyone?


Image map should update links automatically

If content URL has changed the image map links should follow the change

The wagtail-svgmap application already should do this...


Try to switch to another Node from the list https://github.com/tarassh/fairy-wallet/wiki/Connect-to-Mainnet

Try to switch to another Node from the list https://github.com/tarassh/fairy-wallet/wiki/Connect-to-Mainnet
Originally posted by @tarassh in https://github.com/tarassh/fairy-wallet/issues/52#issuecomment-429673565

My new fairy wallet shows a balance but no transaction history.  I have connected though different nodes but still no history is shown.  I have just 2 transactions for 1 eos each which was received from Coinbase.  What is the problem with my fairy wallet?

I am using a ledger nano s

I'm experiencing the same issue intermittently.
I think it's a bug in the wallet, hopefully new release will solve this problem.


Proposal: Add exposure, source, and model metadata to dim_ tables

I would like to be able to leverage the package to present data source information in downstream tools, including object descriptions, tags, and metadata.
Proposal would be to add the following columns to dim_dbt__sources, dim_dbt__models and dim_dbt__exposures:

meta (variant type)
description (text)
tags (array type)

Has this been considered before? I may have some time to contribute this if it's desired.

After playing around with the package for a while, I am guessing that the reason for not including this is due to a potential explosion in the size of the tables over time since the descriptions may be too large. Perhaps having a table with the latest_metadata for each node_id would make this possible.

Resolved by https://github.com/brooklyn-data/dbt_artifacts/pull/66


Split v2ray-plugin-linux-arm-v1.1.0.tar.gz to three file.

Because github redirect assert url to AWS, which cause download file is slow.
And, this file size is 8.54 MB, which bigger and need quite long time when
network is not good, for performance, if we can split this file to three file
(arm5, arm6, arm7), will got more ideal download time.
Thanks

No

@LiveChief , definitely you don't live in China.
@zw963 , good suggestion for people who are behind the GFW

@colibris79 NYC, United States

yr


Compile without CGO?

I was looking for a pure Go implementation of an embedded SQL database since mattn/go-sqlite3 requires CGO. This project looks perfect.
However I tried to install the package on Windows where I don't have gcc, and we seem to have a CGO dependency via cznic/zappy:
>go get github.com/cznic/ql
# github.com/cznic/zappy
exec: "gcc": executable file not found in %PATH%

I tried setting CGO_ENABLED=0 but this doesn't seem to do anything. Perhaps I need to rebuild the standard library?

@mbergin Plase see the documentation for building QL without CGO.

Oops. Thank you.


gitlab-integrator fails with "failed to retrieve SSL cert..."

Hello.
It seems that the issue gitlab integrator charm connecting to gitlab.com issue originates from the cert = ssl.get_server_certificate((host, port)) call in the charm, which hits an issue. More specifically, an error is encountered here:
(Pdb) where
  /usr/lib/python3.8/bdb.py(638)runcall()
-> res = func(*args, **kwds)
  /var/lib/juju/agents/unit-finos-legend-gitlab-integrator-k8s-0/charm/src/charm.py(391)_on_config_changed()
-> self._update_charm_status()
  /var/lib/juju/agents/unit-finos-legend-gitlab-integrator-k8s-0/charm/src/charm.py(372)_update_charm_status()
-> gitlab_relation_data = self._get_gitlab_relation_data()
  /var/lib/juju/agents/unit-finos-legend-gitlab-integrator-k8s-0/charm/src/charm.py(311)_get_gitlab_relation_data()
-> cert_b64 = self._get_gitlab_host_cert_b64()
  /var/lib/juju/agents/unit-finos-legend-gitlab-integrator-k8s-0/charm/src/charm.py(285)_get_gitlab_host_cert_b64()
-> cert = ssl.get_server_certificate((host, port))
  /usr/lib/python3.8/ssl.py(1484)get_server_certificate()
-> with context.wrap_socket(sock) as sslsock:
  /usr/lib/python3.8/ssl.py(500)wrap_socket()
-> return self.sslsocket_class._create(
  /usr/lib/python3.8/ssl.py(1040)_create()
-> self.do_handshake()
> /usr/lib/python3.8/ssl.py(1309)do_handshake()
-> self._sslobj.do_handshake()

(Pdb) s
OSError: [Errno 0] Error
It seems that is a known error (https://bugs.python.org/issue31122), and some bugfixes have been merged in Python 3.8.6 (https://github.com/python/cpython/pull/21889). However, the Python version usedin the gitlab integrator charm is 3.8.5:

root@finos-legend-gitlab-integrator-k8s-0:/var/lib/juju# python3 --version
Python 3.8.5

I'm going to try with a charm that has Python 3.8.6, and see how it goes. Any pointers to doing that would greatly help.
Also, an entirely different error is encountered if the gitlab_host is prefixed by https://, but the unit status is the same, so that's something we should treat as well.

gitlab-integrator fails with "failed to retrieve SSL cert for GitLab host 'https://gitlab.com:443'. SSL is required for the GitLab to be usable by the Legend components

Just an FYI, I managed to get gitlab.com's SSL certificate through python's requests like this:
import requests
import ssl
import sys

HTTPResponse = requests.packages.urllib3.response.HTTPResponse
_HTTPResponse__init__ = HTTPResponse.__init__

HTTPAdapter = requests.adapters.HTTPAdapter
_build_response = HTTPAdapter.build_response

def new_HTTPResponse__init__(self, *args, **kwargs):
    _HTTPResponse__init__(self, *args, **kwargs)

    # We need the cert binary data, we process it the same way
    # the ssl library does.
    self.peer_cert = None
    try:
        binary_data = self.connection.sock.getpeercert(True)
        self.peer_cert = ssl.DER_cert_to_PEM_cert(binary_data)
    except AttributeError:
        pass

def new_build_response(self, request, resp):
    response = _build_response(self, request, resp)
    try:
        response.peer_cert = resp.peer_cert
    except AttributeError:
        pass
    return response

HTTPResponse.__init__ = new_HTTPResponse__init__
HTTPAdapter.build_response = new_HTTPAdapter_build_response

def get_server_certificate(host, port):
    url = "https://%s:%s" % (host, port)
    response = requests.get(url)
    return response.peer_cert

if __name__ == '__main__':
    print(get_server_certificate(sys.argv[1], sys.argv[2]))

Using that certificate, the rest of the juju units became active. Will look into integrating this code into the charm.

Awesome work @claudiubelu. Thank you.


USSD Registration - mother/household messages

a message receiver needs to be registered for either "Mother" or "Household" messages based on selection made at state 1 (state_msg_receiver):

option 2 --> "Mother" messages
options 1, 3-4 --> "Household" messages

@imsickofmaps Please review

:+1:


[fixed] Remove required flag from contentLabel propType in Modal

Fixes #479.
Changes proposed:
ARIA spec, "If the label text is visible on screen, authors SHOULD use aria-labelledby and SHOULD NOT use aria-label."
Changing contentLabel propType to not be required; reference id for aria-labelledby will now be supported.
Upgrade Path (for changed or removed APIs):
Won't affect existing code.
Acceptance Checklist:

[X] All commits have been squashed to one.
[X] The commit message follows the guidelines in CONTRIBUTING.md.
[X] Documentation (README.md) and examples have been updated as needed.
[X] If this is a code change, a spec testing the functionality has been added.
[X] If the commit message has [changed] or [removed], there is an upgrade path above.

Coverage remained the same at 87.24% when pulling 83ad71a82cf8115272055b6d74cbd1d64f662604 on bluSCALE4:master into b9080425fefff692e4bb9549d8d1c8549a704168 on reactjs:master.

Coverage remained the same at 87.24% when pulling 83ad71a82cf8115272055b6d74cbd1d64f662604 on bluSCALE4:master into b9080425fefff692e4bb9549d8d1c8549a704168 on reactjs:master.

Hi @bluSCALE4, can you check if it is needed to update the docs?

Coverage remained the same at 87.24% when pulling 7c8085c222f02b9fe7686095747a3d4e7c1503fd on bluSCALE4:master into b9080425fefff692e4bb9549d8d1c8549a704168 on reactjs:master.

Coverage remained the same at 87.24% when pulling 7c8085c222f02b9fe7686095747a3d4e7c1503fd on bluSCALE4:master into b9080425fefff692e4bb9549d8d1c8549a704168 on reactjs:master.

Coverage remained the same at 87.24% when pulling c7f79b209bf4851b93f549ed6172ef580e5992c1 on bluSCALE4:master into b9080425fefff692e4bb9549d8d1c8549a704168 on reactjs:master.

Coverage remained the same at 87.24% when pulling c7f79b209bf4851b93f549ed6172ef580e5992c1 on bluSCALE4:master into b9080425fefff692e4bb9549d8d1c8549a704168 on reactjs:master.

@diasbruno sorry about that.

Coverage remained the same at 87.24% when pulling bc7a2c0abd6f714485165086eb761d4470b3c06c on bluSCALE4:master into b9080425fefff692e4bb9549d8d1c8549a704168 on reactjs:master.

Coverage remained the same at 87.24% when pulling bc7a2c0abd6f714485165086eb761d4470b3c06c on bluSCALE4:master into b9080425fefff692e4bb9549d8d1c8549a704168 on reactjs:master.

Coverage remained the same at 87.24% when pulling e879eff0f239defbb0541e3db99be6f962079865 on bluSCALE4:master into b9080425fefff692e4bb9549d8d1c8549a704168 on reactjs:master.

Oh, my bad. Totally forgot this PR. Sorry, @bluSCALE4. I'll get this merged soon.


[WIP] Add layout support of all backbones + Transformer

@MoisesHer
After this PR, we will support the input of encoder/decoder to be either NTC or TNC. We are seeing that TNC usually achieves better throughput.
The technical insights behind why TNC is better for attention is the following (also documented here https://github.com/dmlc/gluon-nlp/blob/cd48efdd51cf26b47791c0329e1092fb5fc658f7/src/gluonnlp/attention_cell.py#L540-L546):
When the layouts of memory and query are "TNC", they have the shape:

query: (L_query, B, N, C_Q)
memory: (L_mem, B, N, C_Q)

One step in the AttentionCell is to obtain the multi-head attention scores, which can be written as follows:
(L_query, B, N, C_Q) X (L_mem, B, N, C_Q) -> (B, N, L_query, L_mem)
This layout structure can be implemented very efficiently because B, N are consecutive to each other.
To have a clear picture of what's happening, we may consider the (i, j)th element of the output, i.e.,
out[i, j, :, :] = query[:, i, j, :] X key[:, i, j, :].T

This is just one GEMM call. We can thus implement the whole kernel via a single call of batched GEMM by correctly specifying the strides.

Now I'm waiting for https://github.com/dmlc/gluon-nlp/pull/1261. We added two flags:

layout
It means the layout of the input + output
compute_layout
It means the layout of the inner computation. By default, we will always use compute_layout=auto, which will automatically determine the best compute layout based on our heuristic.

@dmlc/gluon-nlp-committers  @MoisesHer @ZheyuYe   Should be ready for review.


Add Bower support

Hi!
Can you publish Leaflet.Illustrate to bower?
BR.
Julien

Coverage remained the same at 80.78% when pulling a4153f4f73d235d89656c5bb2735d4333423499a on julien-noblet:master into 7e5622df84267344292267c1279cb1bd8b4a8996 on manleyjster:master.

Coverage remained the same at 80.78% when pulling 956b30b7e55a01e3ad94c646ab4691ae62c295f8 on julien-noblet:master into 7e5622df84267344292267c1279cb1bd8b4a8996 on manleyjster:master.

Coverage remained the same at 80.78% when pulling b002dd231b412668841ad1b95e424a517e46dc62 on julien-noblet:master into 7e5622df84267344292267c1279cb1bd8b4a8996 on manleyjster:master.

Done! I just published it to the bower registry.

thanks :+1:


Nuget availability

I'm successfully using this great library in our project via referencing a .DLL. But it would be much better to have it referenced from Nuget.
Could you please publish it to Nuget?

I will try 👍 I will have a look of nuget publishing this week !

Job done (seems to work): https://preview.nuget.org/packages/Tiny-Workflow/.
If there is any problem, re-open this ticket :)


Checksum doesn't match

According to https://github.com/OpenBazaar/OpenBazaar-Installer/releases
OpenBazaar-1.0.6.dmg
721ade108dd7bc49f6068ad83097f6b24b87e9e8136d689445759c7e32636a87
What command did you use to get THAT checksum?
shasum and openssl sha1 both spit out
2c76fd110de6728d387d26ce920e666fb6a1d517
md5 & openssl md2&5 spit out
d76e54766be117f42c7aae710a52480e

openssl dgst -sha256 ~/.../OpenBazaar-1.0.6.dmg
Finally matches.

Sorry should have included the hash type


refactor: move jest configs into a preset

This could significantly reduce the size of default jest boilerplate,
and gives us more control on the internal config details, thus
potentially making future upgrades easier.

What kind of change does this PR introduce? (check at least one)

[ ] Bugfix
[ ] Feature
[ ] Code style update
[x] Refactor
[ ] Docs
[x] Underlying tools
[ ] Other, please describe:

Does this PR introduce a breaking change? (check one)

[ ] Yes
[x] No

Other information:

Instead of adding a standalone @vue/jest-preset package, I chose to bundle the presets inside the plugin itself, mostly for easier dependency management, including peer dependency resolutions and compatability with yarn pnp & pnpm.
Unfortunately, the preset paths now become very long: '@vue/cli-plugin-unit-jest/preset/typescript-and-babel'. But as most users won't manually type this path, I think it's an acceptable tradeoff.


Missing /bin/ toplevel area upon installing wmagent pypi package

Impact of the bug
Python based deployment
Describe the bug
Similarly to https://github.com/dmwm/WMCore/issues/11583 there is yet another top level directory missing in the pypi installation. This time the directory is /bin , but this time the directory is actually present in the pypi package: [1], but is not install with pip. The bellow command returns no result:
(WMAgent.dock) [cmst1@unit01:/data/srv/wmagent/current]$ find / -name adhoc-scripts

[1]
(WMCore.venv3) [user@unit02 wmagent-<IP_ADDRESS>]$ tree -L 2
.
├── bin
│   ├── acdcserver-tools
│   ├── adhoc-scripts
│   ├── attempt-to-patch.sh
...
│   ├── wmcore-new-config
│   └── wmcore-new-flow
├── LICENSE
├── MANIFEST.in
├── NOTICE
├── PKG-INFO
├── README.md
├── requirements.txt
├── setup_build.py
├── setup.cfg
├── setup_dependencies.py
├── setup.py
└── src
    ├── couchapps
    ├── css
    ├── javascript
    ├── python
    └── templates

How to reproduce it
Setup the wmagent pypi package with:   pip install wmagent==<IP_ADDRESS> and try to find the WMCore bin directory or anything from its contents.
Expected behavior
Everything included in the pypi package to get deployed at the destination
Additional context and error message
This together with the already mentioned issue are blockers for completing the python based deployment for the wmagent package:
https://github.com/dmwm/WMCore/issues/8797

@todor-ivanov I think it would make more sense to actually incorporate this content into the other ticket that you opened today, this:
https://github.com/dmwm/WMCore/issues/11583
Given that it's the same package and same development, just a different directory, can you please update the title and description of #11583 and close this ticket? Thanks

Hi @amaltaro , I agree we can merge those. Even though it would have been better to resolve them separately. And here is my motivation why I created  them as two issues, rather than a single one.

Because one of them has more severe impact than the other - The lack of /etc in the package concerns only the missing agent config templates, which are a matter of a single download from source at build time for the docker image. While the lack of /bin in the package is a blocker, because it is preventing any $manage command to be executed at the agent and is a matter of several files rather than a single template.
Then,  the solutions of them both (if I am not wrong) must happen at different places:

for /etc  in setup_build.py
for /bin/ in setup.py`

Anyway, since I already implemented a nasty workaround in deployment repo (which BTW must go away ASAP, because it is really NOT the way how we should do this), I am willing to merge these issues here ins a single one as you suggested.
The issue: https://github.com/dmwm/WMCore/issues/11583 has been updated to explain the two different use cases and I am closing this one.

@amaltaro Why did you close that issue ?


[Agri] All the timestamp metadata in NGSIv2 examples is wrong

The metadata type is missing ... and it should be "DateTime"  ...

Do you mean in DateTime attributes, right? Not createdAt and modifiedAt ones

it is in NGSI v2 metadata. You need to add "type": "DateTime"
thanks!

I think this one can be closed

@fdelavega can you reference the PR on which this was fixed?

is the #542


[TACHYON-935] Added the usage of links in the documentation for some of the tests in the tachyon-servers module

https://tachyon.atlassian.net/browse/TACHYON-935

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Tachyon-Pull-Request-Builder/7197/
Test PASSed.

LGTM, thanks for the PR @HorizonNet


Provisioning feature as provision-block in config file

Change content and motivation
Adds provisioning feature (ansible-playbook, helm or bash) as provision-block in config file.

I guess it is ready to merge?

@andersla @carmat88 there are still two echoes to fix, see my comments above. After we sort out these wear ready to go!

:-)


Preliminary Data Analysis

Do another more thorough data analysis. The goals are:

identification of potential blind spots
develop data analysis scripts
a preliminary report of the performance of our 3 clients
use that data as a basis for an extended roll-out

Covered with #31


Login

Paulo - FYI, Holly and I are both having issues logging in.  For any user we pick, we get a message that pops up stating "User already logged in another device".  Are all of the users currently logged in on your devices?

@coderReview see above.

Sorry for the distraction - I realized I wasn't connected to our wifi.  Once I was connected, I'm able to log in using any of the users.  However, I'm still getting a message that comes up saying "Error.  We are unable to sync this iPad with the central food repository.  Don't worry! You can still use...".  So it appears to let me connect in order to log in, but not to the food repository.  Could this be a NASA firewall issue like we had in the past?

@szwart can you try on a non-NASA network? If it works then it's the NASA firewall.

I tried connecting using my phone hotspot and it’s still giving me that message.
From: Rashid Sial<EMAIL_ADDRESS>Sent: Wednesday, January 11, 2017 10:25 AM
To: NASA-Tournament-Lab/NTL-ISS-Food-Intake-Tracker<EMAIL_ADDRESS>Cc: Zwart, Sara (JSC-SK)[WYLE LABORATORIES, INC.]<EMAIL_ADDRESS>Mention<EMAIL_ADDRESS>Subject: Re: [NASA-Tournament-Lab/NTL-ISS-Food-Intake-Tracker] Login (#151)
@szwarthttps://github.com/szwart can you try on a non-NASA network? If it works then it's the NASA firewall.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com/NASA-Tournament-Lab/NTL-ISS-Food-Intake-Tracker/issues/151#issuecomment-271915550, or mute the threadhttps://github.com/notifications/unsubscribe-auth/ALUpUobYIVqQynp8UFqqUbBjk0WcxX16ks5rRQJXgaJpZM4LgwIR.

@szwart I will check the server is up and running.

@szwart Server is running fine. Will check the iPad app.

Holly says hers is not giving her that error message.  So it appears to only be mine.  Maybe I should try to reload the app?
From: Paulo Vitor Magacho<EMAIL_ADDRESS>Sent: Wednesday, January 11, 2017 9:53 PM
To: NASA-Tournament-Lab/NTL-ISS-Food-Intake-Tracker<EMAIL_ADDRESS>Cc: Zwart, Sara (JSC-SK)[WYLE LABORATORIES, INC.]<EMAIL_ADDRESS>Mention<EMAIL_ADDRESS>Subject: Re: [NASA-Tournament-Lab/NTL-ISS-Food-Intake-Tracker] Login (#151)
@szwarthttps://github.com/szwart Server is running fine. Will check the iPad app.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com/NASA-Tournament-Lab/NTL-ISS-Food-Intake-Tracker/issues/151#issuecomment-272069677, or mute the threadhttps://github.com/notifications/unsubscribe-auth/ALUpUmPN2r5IWeskQmJ5o016YEPFusHRks5rRaOvgaJpZM4LgwIR.

Can you paste the app config?
Em qui, 12 de jan de 2017 às 11:40, szwart<EMAIL_ADDRESS>escreveu:

Holly says hers is not giving her that error message. So it appears to
only be mine. Maybe I should try to reload the app?
From: Paulo Vitor Magacho<EMAIL_ADDRESS>Sent: Wednesday, January 11, 2017 9:53 PM
To: NASA-Tournament-Lab/NTL-ISS-Food-Intake-Tracker <
<EMAIL_ADDRESS>Cc: Zwart, Sara (JSC-SK)[WYLE LABORATORIES, INC.]<EMAIL_ADDRESS>Mention<EMAIL_ADDRESS>Subject: Re: [NASA-Tournament-Lab/NTL-ISS-Food-Intake-Tracker] Login
(#151)
@szwarthttps://github.com/szwart Server is running fine. Will check the
iPad app.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub<
https://github.com/NASA-Tournament-Lab/NTL-ISS-Food-Intake-Tracker/issues/151#issuecomment-272069677>,
or mute the thread<
https://github.com/notifications/unsubscribe-auth/ALUpUmPN2r5IWeskQmJ5o016YEPFusHRks5rRaOvgaJpZM4LgwIR>.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/NASA-Tournament-Lab/NTL-ISS-Food-Intake-Tracker/issues/151#issuecomment-272165453,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AFpqQqI-k3vwbEvwdBhmIko4OBqjAEnHks5rRi1dgaJpZM4LgwIR
.

@coderReview can you confirm how to do that? Do you mean from the Settings app?

Yes.

Thanks Paulo.
@szwart can you upload the screenshot please.

Let me know if this is not what you were looking for...

@szwart that seems correct. I've provided a new version of the iPad app. Can you try a fresh install?

It works now!  I don't get that error anymore.  Thanks!!


Angular: Cannot set property 'classNames' of undefined

This is a (multiple allowed):

[x] bug

[ ] enhancement

[ ] feature-discussion (RFC)

Swiper Version: 6.4.8

Platform/Target and Browser Versions: Windows, CHROME

Live Link or JSFiddle/Codepen or website with isssue: https://stackblitz.com/edit/angular-swiper-classname?file=src/app/app.component.ts

What you did
Create new slide after swiper init, by button
Expected Behavior
Create slide like usual
Actual Behavior
Slide create, but in console write: Cannot set property 'classNames' of undefined
And the usual slider operation breaks down

@nolimits4web when release date?

@nolimits4web when release date?

@LikKirill released in 6.4.9

@LikKirill released in 6.4.9


[BUG] GetChatCompletionsStreamAsyncSample code not working

Describe the bug
I am not able to get to a working asynchronous chat stream example using GPT-4 through Azure SDK for Java.
I started from the example code provided here
https://github.com/Azure/azure-sdk-for-java/blob/azure-ai-openai_1.0.0-beta.9/sdk/openai/azure-ai-openai/src/samples/java/com/azure/ai/openai/usage/GetChatCompletionsStreamAsyncSample.java
but it does not work out of the box.
When I executed that code, providing the necessary parameters, I got an error.
Exception or Stack Trace
There was an error getting chat completions.java.lang.NullPointerException: The mapper [it.celi.dialog.GetChat$$Lambda$143/0x00000008002a0000] returned a null value.
To Reproduce
Just execute the example code provided here:
https://github.com/Azure/azure-sdk-for-java/blob/azure-ai-openai_1.0.0-beta.9/sdk/openai/azure-ai-openai/src/samples/java/com/azure/ai/openai/usage/GetChatCompletionsStreamAsyncSample.java
Code Snippet
I tried to fix the issue by modifying these lines:
if (CoreUtils.isNullOrEmpty(chatCompletions.getChoices())) {                         return null;                     }
this way
if (CoreUtils.isNullOrEmpty(chatCompletions.getChoices())) {                         return "";                     }
This change allowed me to execute the code without NPE errors, but the final behavior is different from what I expected it to be.
Expected behavior
I expected to get the response token by token in an asynchronous way, but I instead received only
Role = assistant
Then I increased the timeout from 10 to 60 seconds
TimeUnit.SECONDS.sleep(60);
This way I got:
Role = assistant immediately
... the full response after more or less 15 seconds.
So the streaming is not working in an asynchronous way.
Screenshots
Setup (please complete the following information):

OS: macOS Sonoma 14.4.1
IDE: IntelliJ IDEA 2024.1.3
Library/Libraries: com.azure:azure-ai-openai:1.0.0-beta.9
Java version:  17.0.9 Temurin
App Server/Environment: -
Frameworks: -

Additional context
Information Checklist
Kindly make sure that you have added all the following information above and checkoff the required fields otherwise we will treat the issuer as an incomplete report

[x] Bug Description Added
[x] Repro Steps Added
[x] Setup information Added

Update: I managed to get the asynchronous streaming working by using another deployment even if I have not yet understood what is the difference between the two deployments.
Is there something I can check to understand why one is not working in asynchronous mode and the other it is, using the same exact Java code?
Anyway the example code contains at least a bug in the return null line.

Update: we finally understood what was wrong with the first deployment. It had a custom filter that was not configured in "async mode" so it was blocking the asynchronous response.
I leave the issue open just to fix the return null line error.

Thank you reporting this issue.


Notification get marked as read even if they were not loaded

Describe the bug
Notifications in Artemis are marked as read by opening the sidebar and waiting a bit.
However, the notifications are not refreshed when the sidebar is opened.
Details
Given you know that you a group notification was generated:

The Notification Icon does not show that there is a new notification
You open the sidebar
Still no notification visible
You reload
The Notification Icon still does not show that there is a new notification
You open the sidebar again
There is the new notification, but it is not displayed as new.

But given the same situation:

The Notification Icon does not show that there is a new notification
You do not open the sidebar
You reload
The Notification Icon does show that there is a new notification
You open the sidebar again
There is the new notification and it is displayed as new.

Solution
We should only mark notifications as read if they actually got read, meaning they got displayed.
The client should send the IDs of the read notifications, not just use the current time because it will never be guaranteed that all notifications have been sent to the client at that time (e.g. connection could break temporarily).
Improvement
It would be a good intermediate solution to load new notifications when opening the sidebar and only start marking them as read if this operation was successful.

Our current database structure does not allow to store for each user when a particular notification was read, therefore we have a limited functionality with the last timestamp a user has accessed the notifications.
We could extend this, but this would take quite some time as the database structure would need to be adapted.

Our current database structure does not allow to store for each user when a particular notification was read, therefore we have a limited functionality with the last timestamp a user has accessed the notifications.
We could extend this, but this would take quite some time as the database structure would need to be adapted.

Ok, then we should at least make sure that all new notifications go to a certain time are loaded and displayed.

Ok, then we should at least make sure that all new notifications go to a certain time are loaded and displayed.


Update health-checks.md

passive health checks don't work in hybrid or db-less mode
Description
What did you change and why?
Include any supporting resources, e.g. link to a Jira ticket, GH issue, FTI, Slack, Aha, etc.
Testing instructions
Netlify link:
Checklist

[ ] Review label added
[ ] PR pointed to correct branch (main for immediate publishing, or a release branch: e.g. release/gateway-3.2, release/deck-1.17)

mistakenly said this was not supported in db-less, which was incorrect.


Issues create issue bug

the method create_issue filtered the params for a milestone. additionally when committing an issue with an empty string for assignee, github returned a validation error. therefore i added a function to remove empty hash values.

Hi Dominik,
Thanks a lot for you work on this. I did not end up merging your pull but instead wrote specs for full coverage of issues api and fixed the bug you found. I believe that I need whole sale solution for clearing the the keys with empty values, I am in two minds about it cuz on one hand I don't see anything wrong with client receiving error status codes if they submit
optional parameter with blank values, it's their choice to do so (when the parameter is optional), on the other hand it would make using the gem easier if it prevented on the gem level any call to external service that is blatantly invalid.
Anyways I will need to apply/revisit this issue across all api modules.
Prompted by your issue report, I have also included RDoc link under gem name for easy method reference, especially useful if many parameters are involved in the call. On top of that I've added readme file for specs to make testing and future bug fixing more robust.
Thanks a ton for your effort!
The ultimate goal is to have production ready gem. If you are running your app using it in production please let me know.
Best
Piotr

hi piotr,
first of all, thanks for this great gem. i've tried a couple of different github api v3 gems but none of them comes close to your. we are using your gem for an internal project management tool used by our young agency bleech. we concentrate on using github to manage our project iterations. so we mainly use the issues model.
i would really like to help you with the development but we are really short on time right now, because we just founded our agency. if i stumble upon other bugs, i will try to make more complete fixes including specs and docs.
the issue with empty optional values i found rather strange how github handles them. in my rails app, empty strings are passed if no values are entered for certain fields.  and because i don't want to pollute my controllers with variable clean up i thought it would be nice to have the gem take care of this. i don't understand however that github returns a validation error for empty strings on certain values…
a full featured variable clean up would probably also have to include a solution for nested hashes, if not normalized, and for other variables then strings. some objects unfortunately don't have an empty? method (like fixnums).
if we decide to make our app public we would definitely like to help you finishing a production ready version of your gem. but a that point we don't really know where our app is going.
however, thanks a lot for the effort you put in developing this gem. it has been great help so far.
best wishes, dominik.
Am 17.12.2011 um 16:12 schrieb Piotr Murach:

Hi Dominik,
Thanks a lot for you work on this. I did not end up merging your pull but instead wrote specs for full coverage of issues api and fixed the bug you found. I believe that I need whole sale solution for clearing the the keys with empty values, I am in two minds about it cuz on one hand I don't see anything wrong with client receiving error status codes if they submit
optional parameter with blank values, it's their choice to do so (when the parameter is optional), on the other hand it would make using the gem easier if it prevented on the gem level any call to external service that is blatantly invalid.
Anyways I will need to apply/revisit this issue across all api modules.
Prompted by your issue report, I have also included RDoc link under gem name for easy method reference, especially useful if many parameters are involved in the call. On top of that I've added readme file for specs to make testing and future bug fixing more robust.
Thanks a ton for your effort!
The ultimate goal is to have production ready gem. If you are running your app using it in production please let me know.
Best
Piotr

Reply to this email directly or view it on GitHub:
https://github.com/peter-murach/github/pull/2#issuecomment-3189765

Hi Dominik,
Glad you are using the github_api gem in your internal application, this should give it a good test by fire. I am gonna keep on working improving the gem but in the meantime, even if you don't have time for fixes, any feedback as to any failures/feature request would be good.
In order for the gem to be production ready I will need to work on testing it and bringing the test coverage for all the classes close to 100%. I have plans for expanding the gem but first my regression test suite needs to be finished. One of the things I really need to do is to add request caching but you will need wait and watch this space.
Thanks,
Piotr


Projects should be generated in a folder

When unzipping a project, the contents are extracted into the current directory. Example:
$ unzip -t my-app.zip
Archive:  my-app.zip
    testing: src/main/java/           OK
    testing: src/test/java/           OK
    ...

Project content should be extracted into a folder based on the project name:
$ unzip -t my-app.zip
Archive:  my-app.zip
    testing: my-app/src/main/java/           OK
    testing: my-app/src/test/java/           OK
    ...

Hey @jclingan can you check that this is fixed 😁: https://code.quarkus.io/

@jclingan up?

Sorry, was traveling. Verified, it works. Thx!


SCRIPTS-53 - Folder Filter for GCP AppsScripts and GSuite Projects

Added folder filter variable
Updated getProjects: When scanning all projects, check for filter variable definition.
When present, filter out projects with a parent.id field set to a value in the filter list.
When not present, return all projects.
Updated based on shellcheck recommendations.

https://github.com/lacework-dev/scripts/issues/53


No ticking warscore for puppet cb wars

alexmart: As Azerbaijan, I started a war with Georgia to vassalize. They were sphered by the US, but I was confident enough in my total army size. What happened is I needed 85 warscore to win, and I couldn't get any more than 56 (50 from battles, the rest from occupation - blockade). There was no ticking warscore. When the US came, I beat them and they retreated to Turkey, where I have no military access. There, they reinforced their armies and attacked again. When they got BTFO, they retreated back to Turkey. Repeat cycle. Over, and over, and over, and over again. For probably at least 5 years. All of Georgia was occupied during this time

Changed the TWS_BATTLE_MAX_ASPECT = 8.0, to correlate with vanilla Victoria 2.