Improvements to common video use-cases, using @albanie's shot-detection-benchmarks

This issue is for the discussion of PySceneDetect's performance with respect to the shot-detection-benchmarks repo by @albanie, which includes a variety of shot detection benchmarks with real-world footage (e.g. movies, sports, TV shows).
The discussion here should focus on (but is certainly not limited to) determining the optimal parameters for current and any future detection methods, for each of the test cases in the shot-detection-benchmarks repo.  The parameters listed will include those that both improve the accuracy of PySceneDetect for a particular test case, as well as the run-time performance where possible.
Furthermore, any other algorithm-specific changes or issues specifically pertaining to issues with the test footage will be added to this post for tracking and future reference.  In the resources branch, I will eventually include a downloaded .MP4 version of the test cases and incorporate them as unit tests for PySceneDetect.  The test cases may be expanded in the future should additional benchmarks be included in @albanie's shot-detection-benchmarks repo.

Our discussion from the previous comment thread in another issue, also serving as a reminder to update the nomenclature in the documentation (perhaps including a section on definitions of terms, especially those that differ between cinematography and what PySceneDetect denotes as a "scene".

@albanie commented:
Do you think pyscenedetect should work well for shot detection (rather than scene detection) under content aware mode?

@Breakthrough commented:
@albanie each shot already is a "scene" in content-aware mode, as in the following example in the documentation:
http://pyscenedetect.readthedocs.org/en/latest/examples/usage-example/
As you can see from the output images on that page, the Youtube clip gets split on each shot cut (this is what PySceneDetect calls a "scene"), so in this case, a shot and a scene are equivalent terms.
Is this what you meant? If so, do you think it would be worth explicitly stating that content-aware mode detects individual shots as opposed to scenes?
In the future I may add additional detection modes to group individual shots into bundles/"scenes" based on some similarity metric, but right now, PySceneDetect will generate a new scene every time the current shot changes.

@albanie commented:
@Breakthrough Thanks - I figured that was the meaning but I've noticed that sometimes the two are considered distinct (e.g. in this explanation http://production.4filmmaking.com/cinematography1.html).
In case it's of interest to others, I've benchmarked some shot detection tools (including PySceneDetect) on a few videos: https://github.com/albanie/shot-detection-benchmarks

Currently, the threshold value is set manually for the entire duration of the video.  After examining the statistics on the current videos in the set, I think exploring either an adaptive/dynamic threshold selected automatically using some kind of peak detection, or allowing a deviation from the threshold/sensitivity value by a user-defined amount (either absolute +/-, or different values for the positive/negative shifts).
This would be found manually for now, by analyzing the mean and deviation/variance of the peaks in the videos, and using those as the threshold/sensitivity and absolute +/- values, respectively.  In the future, this could also be combined with peak detection to attempt to compute the values automatically.

@albanie, I've also heard of people using PySceneDetect for automated commercial/advertisement removal.  Do you think it would be possible to include a clip of a television or news show, interlaced with real commercials?  (I don't think this would pose any copyright issues for this purpose, although I am certainly not an expert on the topic.)

@Breakthrough That sounds like an appropriate use case - I'll add a test that includes commercials.


azure-pipelines: Fix release pipeline

Fix a bug where the deployment job could've downloaded different artifacts from the verification job. To prevent this I combined them into a single job so that only one artifact download happens.

It worked 😄 https://dev.azure.com/devdiv/DevDiv/_build/results?buildId=10206225&view=results


Replaced deprecated pick_types with raw.pick

PR Description
closes #151
This PR:
changes all instances of pick_types with raw.pick.
removes "import mne" from pyprep/utils.py and  pyprep/tests/test_prep_pipeline.py as they are no longer in use
Merge Checklist
[ ] the PR has been reviewed and all comments are resolved
[ ] all [CI][what-is-ci] checks pass
[ ] (if applicable): the PR description includes the phrase closes #<issue-number> to automatically close an issue. [auto-close-documentation]
[ ] (if applicable): bug fixes, new features, or [API][what-is-api] changes are documented in [whats_new.rst][whats-new-file]
[ ] (if applicable): new contributors have added themselves to the authors list in the CITATION.cff file

Yes sorry, I got a bit distracted in passing those tests. Thanks for the review, it will be fixed soon.
Apart from that, I was not very confident with the amount of changes I needed to do before commiting.
Is this normal or should I change my approach. I did try to minimize the changes but the tests kept on failing.

Apart from that, I was not very confident with the amount of changes I needed to do before commiting.

It is generally better to do small but meaningful commits rather than big commits that mix a lot of things

I did try to minimize the changes but the tests kept on failing.

It is best to test locally and figure out the root cause of the failure, and then commit a small change that fixes precisely what needs fixing.


docs(#2276): testing examples recovered to new syntax

Q
A

Fixed Issues?
#2276

Docs updated?
Yes

Any Dependency Changes?
No

Regarding to answer from discussion from this PR https://github.com/redux-saga/redux-saga/pull/2277, I updated code examples everywhere

Greetings, I'm going to close this PR due to inactivity.  If you want to continue progress on this PR please say so and I'll open it up!


Startup error involving stone tablet circuits (and also potential bob's compatibility)

Chunk of code it's referencing (was changing all of them between true and false, no difference)
Unsure if you meant to reference stone tablet, or if you're referring to something else. Additionally, with bob's mods installed, your mod overwrites bob's changes as well, making the effective mod priority your mod > se > bobs (ie green circuit reverted to 1 iron plate 3 copper wire instead of however bob's does it)
local stone_circuit = data.raw.recipe["electronic-circuit-stone"]
stone_circuit.normal.enabled = false
stone_circuit.normal.allow_as_intermediate = false
stone_circuit.normal.allow_decomposition = false
stone_circuit.expensive.enabled = false
stone_circuit.expensive.allow_as_intermediate = false
stone_circuit.expensive.allow_decomposition = false

This mod does not have the explicit compatibility code it would need for Bob's Mods, in part because I assumed Bob's Mods were incompatible with SE. Could you provide a list of what mods you're using?

SE sort of auto-flags a lot of mods as incompatible, whether there's some legitimate issue or if they conflict with how SE is supposed to be played. Either way, a lot of mods, including bob's work just fine most of the time with it.
Mod list:
AAI Industry/signal transmission
Actual craft time
Alien biomes
Angel's addons - storage options
Auto deconstruct
Base mod (obviously)
Beautiful bridge railway
Big brother
Bioluminescence
Biterbias
Bob's adjustable inserters, assembling machines, electronics, library, logistics, metals/chemicals/intermediates, mining, ores, personal equipment, power, revamp, technology, and vehicle equipment mods
Bottleneck
Bullet trails
Chokepoint
Clock
Combat mechanics overhaul
Deadlock's crating machine, stacking beltboxes/compact loaders, and mod integrations
Dew point aggregator
Dirtymining
Dragon industries - nauvis division
Endgame combat
EvoGUI
Factorio library
Fast furnaces
Flare stack
Flow control
FNEI
FTweaks
Fully automated rail layer
Geothermal
Ghost scanner
Grappling gun
Helicopterrevival
Honk
Infitech
Informatron
Inventory sensor
Itemfinder
Jetpack
Loss prevention
Nauvis day
Oreverhaul
Orphan finder
Pheromones
Radionetwork
Realistic decoration cleanup
Robot attrition
Robot256's library
Shield projector
Smarter trains
Space exploration + all 5 graphics parts, and postprocess
Squak through
Turmoil
Vanilla loaders
Vehicle radar
Vehicle wagon 2
Walls block spitters
Wire shortcuts
YARM resource monitor
and of course, Aivech's SE simplifier

I'm uncertain how I feel about adding compatibility for a set of mods that SE itself is nominally incompatible with. Would you mind enabling the setting to use AAI recipes aivech-ssx-use-aai (may require editing the config manually) and see if the game launches?

Also, if you get the game running, can you tell me what items have the wrong recipes, and what mods are touching those recipes (other than mine?) I can add overrides if i know what mods to detect and what the recipes are.


semantic-ui: Update dependency restriction to be compatible with reac…

…t-searchkit
:heart: Thank you for your contribution!
Description
Update the dependency on the version of semantic-ui to be compatible with the requirements from react-searchkit

@ntarocco this was not consistent with https://github.com/inveniosoftware/invenio-theme/blob/master/invenio_theme/webpack.py#L66 and it was failing to install RSK due to the bump of the minimum version for semantic-ui-css. I guess when we merge your PR for updating the merging algorithm that would not be an issue. Can you also have a second look please?

Yes when we merge this, it should solve this kind of issues.


gioteck ps3 controller not working without steam

i was told to copy this text here into the issue request so here
"SDL_GamepadBind"		"03000000f025000031c1000000000000,dev:gen:Gioteck PS3 Controller,platform:Windows,a:b2,b:b1,y:b0,x:b3,start:b9,back:b8,leftstick:b10,rightstick:b11,leftshoulder:b4,rightshoulder:b5,dpup:h0.1,dpleft:h0.8,dpdown:h0.4,dpright:h0.2,leftx:a0,lefty:a1,rightx:a2,righty:a3,lefttrigger:b6,righttrigger:b7,

Thank you. From where were you pointed here ?

da44d1947c9e2041ebf6ce7aa12d4a95675f84c3


Blocking web vitals

Current Behavior
Performing an performance test on a website which includes this library shows the website has blocking elements. Looking further into it, you'll notice that almost all requests made by the react-player library are blocking the website from loading.
Expected Behavior
The requests being made are less on non-blocking
Steps to Reproduce

Create a project with this library
Load a video from YouTube (don't know if it's YouTube specific)
Perform an webvitals test on the project
Notice the requests that are blocking, making the web-vitals slower

Environment

URL attempting to play: https://www.youtube.com/watch?v=5znCkkCSU7c
Browser: Chrome
Operating system: Windows
jsFiddle example: https://jsfiddle.net/3sxzqyLh/

This is something the light prop probably helps with. We don’t have much control over how third party libraries load resources.


CQ-4307443 :Normalize OSGI configs (except RepoInit configs) to the preferred .cfg.json format

CQ-4307443 :Normalize OSGI configs (except RepoInit configs) to the preferred .cfg.json format
Description

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):
Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[ ] I have signed the Adobe Open Source CLA.
[ ] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[ ] I have read the CONTRIBUTING document.
[ ] I have added tests to cover my changes.
[ ] All new and existing tests passed.

Added feedbacks


Added SVG image serving support under /image and /image/svg

Added /image/svg route that serves svg_logo.svg file with Content-type: image/svg+xml.
/image route now also serves svg_logo.svg file when given Accept: image/svg+xml header.
The sampe svg_logo.svg is from Wikipedia and licensed under CC BY 2.5.
Example calls with httpie:
$ http head http://<IP_ADDRESS>:5000/image Accept:image/svg+xml
HTTP/1.0 200 OK
Access-Control-Allow-Credentials: true
Access-Control-Allow-Origin: *
Content-Length: 8984
Content-Type: image/svg+xml
Date: Wed, 09 Sep 2015 13:10:44 GMT
Server: Werkzeug/0.9.4 Python/2.7.10

$ http head http://<IP_ADDRESS>:5000/image/svg
HTTP/1.0 200 OK
Access-Control-Allow-Credentials: true
Access-Control-Allow-Origin: *
Content-Length: 8984
Content-Type: image/svg+xml
Date: Wed, 09 Sep 2015 13:10:50 GMT
Server: Werkzeug/0.9.4 Python/2.7.10

+1 from me


Azure Files AAD Preview - Service Principal Update Commands

Good Morning Microsoft Team!
I was using the procedure in this document to update the service principal password for the first time, the following line didn't produce any results:
$servicePrincipal = Get-AzureADServicePrincipal | Where-Object {$_.AppId -eq $($application.AppId)}
After a little digging, I found that I needed to add the -All $true in order for my Service Principal to appear.
$servicePrincipal = Get-AzureADServicePrincipal -All $true | Where-Object {$_.AppId -eq $($application.AppId)}
Am I unique in this, or should we add this to the docs page?
Thank you!
Adam

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 25ccb59e-98fc-0382-030a-c3805494afd2
Version Independent ID: ed04168c-41ba-e6c6-fe83-f6e5c760ba5a
Content: Create an Azure file share with Azure Active Directory (preview)
Content Source: articles/virtual-desktop/create-profile-container-azure-ad.md
Service: virtual-desktop
GitHub Login: @Heidilohr
Microsoft Alias: helohr

Thanks for the feedback! We are currently investigating and will update you shortly.

Can you please share exactly where in the document are you seeing this command? Thanks.


update mmctl migrate-auth docs

Summary
Adds more examples and info to the migrate auth command (this is pulled from mmctl directly)

@justinegeffen would love some suggestions on the proper formatting for this as I'm not too familiar with RST

@justinegeffen would love some suggestions on the proper formatting for this as I'm not too familiar with RST

Sure! Are you open to me editing the file directly?

@justinegeffen would love some suggestions on the proper formatting for this as I'm not too familiar with RST

Sure! Are you open to me editing the file directly?

absolutely, have at it!

@svelle - I've updated the example formatting. The reason it wasn't displaying is because the code directive must be followed by a blank line before the code example starts. I've also adjusted indentation to display the example in line with the text directly above it.


Add backpack signatures support

Ref to #190

@waddlaw Hi, thank you for taking the time to open this PR.
Can you please do the following:

Squash all commits into a single commit
Rebase on latest master
Add a test to test/EndToEndSpec.hs (this may render some of the other tests superfluous)

In addition, do we want to infer signatures by looking for .hsig-files (similar to what we do for modules)?

WIP.

[x] Squash all commits into a single commit
[x] Rebase on latest master
[ ] Add a test to test/EndToEndSpec.hs (this may render some of the other tests superfluous)

In addition, do we want to infer signatures by looking for .hsig-files (similar to what we do for modules)?

OK, I'll try.

In addition, do we want to infer signatures by looking for .hsig-files (similar to what we do for modules)?

OK, I'll try.

Please feel free to open a separate PR for this.


Can you add support for this please?

Player.spigot().sendMessage(BaseComponent) method
Either it's not supported correctly or something, I get an error when I reload one of my custom plugins. It comes up with this: http://i.imgur.com/IArdxhL.png

Are you using the latest Denizen developmental build? The line that error points to should never error unless you're not even using Spigot.

I updated to the latest spigot build before that error happened (I've ha spigot for the last 3 years) & I already had that denizen build on my server.

That is this line: https://github.com/mcmonkey4eva/Denizen/blob/master/src/main/java/net/aufdemrand/denizen/utilities/packets/intercept/PacketOutHandler.java#L41
chat_message is the only thing that can NPE there... and it's just a pre-read Field reference.
IE, something that should never be null without a minimum of there being an error earlier than that.
Either you're not using latest builds somewhere, or there was another error earlier in your logs that is the true error source.

As author of this plugin in logs ;)
@mcmonkey4eva @Morphan1
Nah... This is spigot, spigot DON'T use vanilla field for chat packets when using sendMessage(BaseComponent) method, as this will have bigger impact on performance, so it use own field and serialize it directly do buffer.
public class PacketPlayOutChat
  implements Packet<PacketListenerPlayOut>
{
  private IChatBaseComponent a;
  public BaseComponent[] components;
  private byte b;

So field "a" is null.
Hope that will help.

@GotoFinal regardless of whether field "a" is null, the error appears to be saying that when sending the packet, field "a" does not exist. The only way that would be possible (that I can think of at the moment) is if:

Something is sending a custom packet that extends PacketPlayOutChat (which is stupid to do)
The Spigot brand (Paper or whatever else) being used decided to remove/rename that field entirely? or
Something big is going wrong with the way we're doing that reflection (doubtful but not impossible I guess)

If no error is happening far earlier than that NPE (for example, immediately when someone logs in) then the last 2 can pretty much be ruled out, I think.

@Morphan1
Or he isn't using latest version of denizen:
https://github.com/mcmonkey4eva/Denizen/blob/70557ad0de5d1cd5d378727c4b17ccc76acc0422/src/main/java/net/aufdemrand/denizen/utilities/packets/intercept/PacketOutHandler.java#L41
So you have 2 options:

Believe in black magic that field disappeared for no reason or other weird stuff.
He have this version, and update will not fix this, as error is caused by null value of "a" field.

@GotoFinal but that second option means that @Devillion lied and wasted both of our time :(

@Morphan1 I downloaded latest denizen directly from the link you posted

This should be fixed in the latest development build.

@Devillion can you confirm this fix?


WiP - Fix for Attachment Filtering on Unavailable Vols

This patch should fix the issue where volumes are not filtered with a mask of 31 if they're unavailable.
This is related to #382.

Current coverage is 30.89% (diff: 100%)

Merging #383 into master will increase coverage by 0.05%

@@             master       #383   diff @@
==========================================
  Files            29         29
  Lines          1719       1719
  Methods           0          0
  Messages          0          0
  Branches          0          0
==========================================
+ Hits            530        531     +1
+ Misses         1131       1130     -1
  Partials         58         58

Powered by Codecov. Last update ec7b258...ede1721


Is repo required?

The README states SEARCH_QUERY "must contain a repo: entry or an org: entry.", but when only supplying an org, an error occurs:

ValueError: The search query for issues/prs must include a repository owner and name

Is this expected?

This is not expected behavior so I'll look into what is causing the problem.

Does this mean the search query can actually search an entire organisation?

@paul-uz Yes, the search query can search an entire organization but the results are limited to 1000 items due to the github API.


[MiscDiagnostics] Diagnose passing a non-@objc dynamic KeyPath property to KVO observe

Passing a KeyPath to a property which is not marked @objc dynamic to the KVO observe method can cause unexpected behavior or a runtime trap.
Resolves SR-5115
Resolves SR-5159
Resolves SR-5177
Resolves rdar://problem/32593787
Resolves rdar://problem/32775952

@swift-ci please smoke test

@swift-ci please smoke test

@swift-ci please smoke test


Cannot see .exe, .py, etc. files.

Describe the bug
I cannot see these files. I cannot do programming.
Desktop (please complete the following information):

OS Version: [e.g. Windows 10 20H2 19613]
App version: [v0.7.8]

Have you given the app permissions to access the file system?

How can I give the app permissions?

@seohyun1108 Go to the settings app on Windows 10 > Privacy > File System, make sure to toggle the option for Files UWP.

@seohyun1108 Did this settings toggle fix your issue?

I recently installed this app and i'm meeting the same problem. The thing is, in the settings page for File System, Files UWP is not there and yes, i have 'Allow apps to access the file system' toggle on.

@YourDailyLlama @seohyun1108 Thanks for reporting this. Can you confirm on the latest update that the items in this folder which are missing are NOT shortcut files?

Thanks again for your feedback.
Since we didn't hear from you on this topic for 7+ days, we'll assume everything is worked out and close this feedback item soon. If you had more feedback to provide, please re-open this and help the owners by describing the current status and any steps taken to troubleshoot this.


Design groups

Create and use design groups in the API

Going to create a case on FogBugz.
It is a MUST have feature

Going to create a case on FogBugz.
It is a MUST have feature

I agree! 😎

https://strusoft.fogbugz.com/f/cases/121605/Design-Group-API


Adding some useful utility tiles

Adding some tiles to the miscellaneous category.

If anyone has any other ideas for tiles, let me know and I'll add them. I haven't "tested" this, because it needs to be merged before I can import it into the editor.

should we put them in a separate category? like "placeholder" (but a better name) or something? it does seem a little different from the rocks/buttons/etc in misc

I'm thinking, maybe some tiles that just have the numbers 1-9? And maybe some icon tiles, like heart, question mark, etc.

I would love to but we hardcoded the tilemap editor categories

.......... right. yes. argh.

yeah maybe like, heart, triangle, circle, square.... question mark, exclamation point.... asterisk? and i like the number ones as well. maybe one that's just zebra stripes?

could we sell "extra tilemap category" as a point fix?

I'll make a PR and if it's small enough we can try to sell it

With that other PR, can these placeholders be an extension?
I agree some symbols and icons would be useful.
I wonder if one of the four colors could be transparent? That would be useful in situations where users specify a background color or image themselves (e.g. 2cat2curious)
Awesome set so far however!

They might be pretty difficult to read on a transparent background with the checkerboard behind it.
I can make it a separate extension, but I would prefer it to come with pxt-tilemaps. It's very easy to ignore if you don't want it and I don't think it's useful without the tilemaps extension. Also, I don't want to flood the extensions dialog.

ship it!!

Hmm they're all in the "Miscelanous" category. How do we move them to their own category?

Woot! Fixed it. Looks fantastic:


Update sentry dep to support 10.x

Updates mix file to support latest sentry major version 10.x.
refs #7

Thanks!


DJSR labels added

Added DJS Racing's labels and documentation

Hi Smruti, I will probably go through the PR tomorrow in the evening. I will keep you posted.

Thanks a lot
On Fri, Mar 27, 2020, 5:10 AM David Dodel<EMAIL_ADDRESS>wrote:

Hi Smruti, I will probably go through the PR tomorrow in the evening. I
will keep you posted.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/ddavid/fsoco/pull/68#issuecomment-604741465, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/ALD4GOMF7JNRKABCPTUX3ZTRJPRX5ANCNFSM4LSK7L4Q
.

Hi there,
so unfortunately there are a few issues so far.
I've only gone through the first ~300 images because at image pwd117-cockpit00001038.jpg there's a wrong class index. Your classes file has three classes, so please check that all the indices are in the range from [0-2].
There are also a few misclassified cones, here are two examples:

Furthermore, I appreciate the info.txt on what cones were left out, but please be more specific.

Hi David,
I have made the following changes:

Updated info file per your suggestions
Fixed the wrong class index and checked other labels for the same
Fixed incorrectly classified cones

Thanks
Best Regards,
Smruti
On Sat, Mar 28, 2020 at 5:29 AM David Dodel<EMAIL_ADDRESS>wrote:

Hi there,
so unfortunately there are a few issues so far.
I've only gone through the first ~300 images because at image
pwd117-cockpit00001038.jpg there's a wrong class index. Your classes file
has three classes, so please check that all the indices are in the range
from [0-2].
There are also a few misclassified cones, here are two examples:
[image: boxes_pwd117-cockpit00000777]
https://user-images.githubusercontent.com/18621443/77808775-113afe80-708d-11ea-9fc8-ccbb5c84fd3c.jpg
[image: boxes_pwd117-cockpit00000816]
https://user-images.githubusercontent.com/18621443/77808791-1e57ed80-708d-11ea-9d5c-469dd91c7a1a.jpg
Furthermore, I appreciate the info.txt on what cones were left out, but
please be more specific.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/ddavid/fsoco/pull/68#issuecomment-605361564, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/ALD4GOLSOYXHLZWP4KPYU33RJU4VHANCNFSM4LSK7L4Q
.

Hi Smruti,
thank you for the summary of the changes made. I will let you know as soon as I have feedback on the current version of the labels.

Hi Smruti,
the issues from the first comment are fixed, thank you.
I'm afraid I wasn't specific enough with my feedback on the info.txt file, though. The purpose behind it is for other teams to be able to pre-process the files to better fit their algorithms.
What a very small cone is might vary from team to team, your file should be clear as to what that means for yours. As a rule of thumb, if you can't put the information in quantifiable terms somehow, it won't be of much use for the other teams.
An example of this would be the size of the bounding boxes in Pixels, e.g. labeling all cones with a height > 10 Pixels.
Another example would be to set a height on the image plane up to which you've labeled. This cutoff line would only make sense if all images were taken with the camera in the same pose, more or less, making the assumption of a fixed horizon possible.
Regarding the quality of the labels, I will send you a sample with good examples, the bounding boxes should be tighter around the cones.


Added MySQL conditional for post-install script

I ran into an issue when setting up an external database as part of this Helm chart. Even though I had disabled the MySQL pod from being created, the post-install script would error out since Drush was trying to install against it.
Adding this conditional fixed the issue for me.

Thanks a bunch!!! This looks great to me! 👍

Amending the last commit so you get attribution sorry about that :P boourns squash and merge

No worries at all. Just wanted to help as others might run into this same issue 😀


I would like to apply the project to Chinese calligraphy. I wonder if it is feasible?

For example: I have 3000 character pictures of a calligrapher, I am now looking for a ttf font as a source, with the calligrapher character pictures as the destination for training.
A little bit different from this project, it will appear, the same character, calligrapher will have a variety of writing.
Generated images with ttf font when generated.
Can you predict whether such training can achieve the desired result?
Thank you very much for the project. It was great!

I found the code below.
filter_hashes = set(filter_recurring_hash(charset, dst_font, canvas_size, x_offset, y_offset))
Filtering is done according to the dst font.
Does this mean that the same font, one char can be written in a variety of ways?

if you mean only one calligrapher, I think is possible。you should add some random input when generating image。
""" Some characters are missing in a given font, filter them by checking the recurring hashes    """

Thanks very much!
When I create images with fonts, I find that some words are blank. I will filter them.
I have two questions:

Calligraphers have made great changes in their calligraphic works. Do I need to filter out pictures that are totally different when preparing for training pictures?
Can I train multiple fonts into one font?

Thanks again for your reply

yeah,I think that would help, you can read the description of   'constant loss '
I think it's possible,but what's the meaning?

Thanks very much。
It seems that I need to try a little more and see the effect.


Fallback to embedded font when system font is unsupported

Fixes #69.
This PR embeds Lato in iced_wgpu and uses it when the default system fonts cannot be handled by rusttype. This is a dirty fix and should increase binary size a bit. It's meant to be a workaround while we move the text pipeline in iced_wgpu to something that offers more support (see #33).
Additionally, the PR also removes the loading of a monospace font, reducing memory footprint. We can use the default font instead for the debug/overlay view.

I just ran into this issue trying to run the examples, found this PR, switched to this branch and recompiled. Still getting a panic.

@safijari Thanks for testing it!
Could you share a backtrace?

    Finished dev [unoptimized + debuginfo] target(s) in 0.06s
     Running `target/debug/examples/tour`
thread 'main' panicked at 'called `Option::unwrap()` on a `None` value', /rustc/412f43ac5b4ae8c3599e71c6972112e9be4758fa/src/libcore/macros/mod.rs:15:40
stack backtrace:
   0: backtrace::backtrace::libunwind::trace
             at /cargo/registry/src/github.com-1ecc6299db9ec823/backtrace-0.3.40/src/backtrace/libunwind.rs:88
   1: backtrace::backtrace::trace_unsynchronized
             at /cargo/registry/src/github.com-1ecc6299db9ec823/backtrace-0.3.40/src/backtrace/mod.rs:66
   2: std::sys_common::backtrace::_print_fmt
             at src/libstd/sys_common/backtrace.rs:84
   3: <std::sys_common::backtrace::_print::DisplayBacktrace as core::fmt::Display>::fmt
             at src/libstd/sys_common/backtrace.rs:61
   4: core::fmt::write
             at src/libcore/fmt/mod.rs:1030
   5: std::io::Write::write_fmt
             at src/libstd/io/mod.rs:1412
   6: std::sys_common::backtrace::_print
             at src/libstd/sys_common/backtrace.rs:65
   7: std::sys_common::backtrace::print
             at src/libstd/sys_common/backtrace.rs:50
   8: std::panicking::default_hook::{{closure}}
             at src/libstd/panicking.rs:188
   9: std::panicking::default_hook
             at src/libstd/panicking.rs:205
  10: std::panicking::rust_panic_with_hook
             at src/libstd/panicking.rs:464
  11: std::panicking::continue_panic_fmt
             at src/libstd/panicking.rs:373
  12: rust_begin_unwind
             at src/libstd/panicking.rs:302
  13: core::panicking::panic_fmt
             at src/libcore/panicking.rs:82
  14: core::panicking::panic
             at src/libcore/panicking.rs:50
  15: core::option::Option<T>::unwrap
             at /rustc/412f43ac5b4ae8c3599e71c6972112e9be4758fa/src/libcore/macros/mod.rs:15
  16: wgpu_request_adapter
             at /home/jari/.cargo/registry/src/github.com-1ecc6299db9ec823/wgpu-native-0.4.0/src/instance.rs:474
  17: wgpu::Adapter::request
             at /home/jari/.cargo/registry/src/github.com-1ecc6299db9ec823/wgpu-0.4.0/src/lib.rs:545
  18: iced_wgpu::renderer::Renderer::new
             at wgpu/src/renderer.rs:51
  19: <iced_wgpu::renderer::Renderer as iced_native::renderer::windowed::Windowed>::new
             at wgpu/src/renderer.rs:417
  20: iced_winit::application::Application::run
             at ./winit/src/application.rs:115
  21: iced::application::Application::run
             at ./src/application.rs:140
  22: iced::sandbox::Sandbox::run
             at ./src/sandbox.rs:128
  23: tour::main
             at examples/tour.rs:10
  24: std::rt::lang_start::{{closure}}
             at /rustc/412f43ac5b4ae8c3599e71c6972112e9be4758fa/src/libstd/rt.rs:61
  25: std::rt::lang_start_internal::{{closure}}
             at src/libstd/rt.rs:48
  26: std::panicking::try::do_call
             at src/libstd/panicking.rs:287
  27: __rust_maybe_catch_panic
             at src/libpanic_unwind/lib.rs:81
  28: std::panicking::try
             at src/libstd/panicking.rs:265
  29: std::panic::catch_unwind
             at src/libstd/panic.rs:395
  30: std::rt::lang_start_internal
             at src/libstd/rt.rs:47
  31: std::rt::lang_start
             at /rustc/412f43ac5b4ae8c3599e71c6972112e9be4758fa/src/libstd/rt.rs:61
  32: main
  33: __libc_start_main
  34: _start
note: Some details are omitted, run with `RUST_BACKTRACE=full` for a verbose backtrace.```

Hey @safijari, thanks for reporting back.
Your issue is not related to font loading. It seems [wgpu] is not able to find a suitable graphics adapter. A related issue is #72.
My advice is to check that your Vulkan drivers are installed correctly. I am also working on a renderer alternative that should be able to fallback to software mode in this cases.


WIP: Add log-enricher e2e test

What type of PR is this?
/kind cleanup
What this PR does / why we need it:
Adding a first e2e test for the log enricher feature.
Which issue(s) this PR fixes:

None
Does this PR have test?
Yes

Special notes for your reviewer:
None
Does this PR introduce a user-facing change?

None

Codecov Report

Merging #483 (d959907) into master (25f633c) will not change coverage.
The diff coverage is 0.00%.

@@           Coverage Diff           @@
##           master     #483   +/-   ##
=======================================
  Coverage   37.79%   37.79%
=======================================
  Files          23       23
  Lines        1114     1114
=======================================
  Hits          421      421
  Misses        678      678
  Partials       15       15

So far so good! Enabling it and this not breaking is a good step :D What else do you plan to test?

So far so good! Enabling it and this not breaking is a good step :D What else do you plan to test?

I have to check if we wan emit a seccomp log to /dev/kmsg and will enhance the test case around that :grin:

/test pull-security-profiles-operator-test-e2e

Requires https://github.com/kubernetes-sigs/security-profiles-operator/pull/491

/retest

/retest

/retest

Test seems to work :tada:
I0621 15:38:25.417893   46527 enricher.go:99] log-enricher "msg"="audit"  "container"="enrichercontainer" "executable"="/usr/sbin/nginx" "namespace"="default" "node"="<IP_ADDRESS>" "pid"=47276 "pod"="enricherpod" "syscallID"=50 "syscallName"="listen" "timestamp"="1624289904.762:9277" "type"="seccomp"
I0621 15:38:25.439005   46527 enricher.go:99] log-enricher "msg"="audit"  "container"="enrichercontainer" "executable"="/usr/sbin/nginx" "namespace"="default" "node"="<IP_ADDRESS>" "pid"=47276 "pod"="enricherpod" "syscallID"=50 "syscallName"="listen" "timestamp"="1624289904.762:9278" "type"="seccomp"
I0621 15:38:25.515222   46527 enricher.go:99] log-enricher "msg"="audit"  "container"="enrichercontainer" "executable"="/usr/sbin/nginx" "namespace"="default" "node"="<IP_ADDRESS>" "pid"=47276 "pod"="enricherpod" "syscallID"=50 "syscallName"="listen" "timestamp"="1624289904.762:9279" "type"="seccomp"
I0621 15:38:25.631251   46527 enricher.go:99] log-enricher "msg"="audit"  "container"="enrichercontainer" "executable"="/usr/sbin/nginx" "namespace"="default" "node"="<IP_ADDRESS>" "pid"=47276 "pod"="enricherpod" "syscallID"=50 "syscallName"="listen" "timestamp"="1624289904.762:9280" "type"="seccomp"
pod "enricherpod" deleted

Green tests, PTAL @JAORMX @jhrozek


Added copy constructor

I added a test, but it can be omitted.

Also run the formatter to make CI happy


feat: support no data within BigNumber viz

🏆 Enhancements
Support an empty array being passed in as data. This is precursor work to making "No data" not an error within Superset.

to: @kristw

I think code-wise looks good.
Would you add checks like this to all charts? Would be nice to have some design consistency.
Wonder if design would have any suggestion.

The plan is to make all charts support this, and keep the design consistent with however the chart looks today. For example, all NVD3 charts already have a no data available treatment, so i'll keep that around. For other types of charts (like geovis) i'd probably keep the map visible and overlay the no data message


SyntaxError: f-string: unmatched '['

Attempting to run the python3 furaffinity-dl.py for favorites, with a cookie file I am seeing the following:
Traceback (most recent call last):
File "/home/jurrel/Pictures/FA-Favs-Downloads/furaffinity-dl-python/furaffinity-dl.py", line 9, in
from Modules.download import download
File "/home/jurrel/Pictures/FA-Favs-Downloads/furaffinity-dl-python/Modules/download.py", line 9, in
from Modules.functions import DownloadComplete
File "/home/jurrel/Pictures/FA-Favs-Downloads/furaffinity-dl-python/Modules/functions.py", line 144
page_num = f"{parse_next_button.parent.attrs["action"].split("/")[-2]}/next"
^^^^^^   ##Broken spacing, this is under "action"##
SyntaxError: f-string: unmatched '['
Using Python 3.10.12

Hello, can you provide username for which this is happening? Also, do you use modern theme?

Sure under jurrel and yes I am using modern layout, dark theme.

hmm, strange, it seems to work fine for me. What command did you use? And in what page number does it happen?
I tried with this command: python .\furaffinity-dl.py jurrel favorites  --dry -c .\cookies.txt

I am getting it as soon as I run the command.  Attaching here everything from the command prompt:
python3 furaffinity-dl.py jurrel favorites -c www.furaffinity.net_cookies.txt
Traceback (most recent call last):
File "/home/jurrel/Pictures/FA-Favs-Downloads/furaffinity-dl-python/furaffinity-dl.py", line 9, in
from Modules.download import download
File "/home/jurrel/Pictures/FA-Favs-Downloads/furaffinity-dl-python/Modules/download.py", line 9, in
from Modules.functions import DownloadComplete
File "/home/jurrel/Pictures/FA-Favs-Downloads/furaffinity-dl-python/Modules/functions.py", line 144
page_num = f"{parse_next_button.parent.attrs["action"].split("/")[-2]}/next"
^^^^^^
SyntaxError: f-string: unmatched '['
I tried your command and got the same error, this is on linux, not that it should make a difference.
For what it is worth, I used an older version of this scripting before and it would work, but only ever get page 1 of favorites then say it could not find the next button.

ooh, I maybe understand why that is happening. It seems like on python 3.12 double quotes inside double quotes are working fine, but in older versions like 3.10 they are not. I will try to replace them with single quotes, and give it another try, should be fixed shortly

Can you update and try it again?

That was it!  It is now pulling properly for several pages.

Thanks for the issue. And sorry I didn't catch it sooner


BAU: Supress SASS warnings

Government Frontend is currently supporting LibreSass and Ruby Sass
alongside Dart Sass. math.div is not available in either. So the
deprcation warning / preference does not have a clear mitigation path
until the design system is able to remove these conflicting support
requriements (aimed at October 2022, or so I hear).
Source: https://github.com/alphagov/govuk-frontend/issues/2238
In the meantime, we get a ton of noise everytime we spin up an app.
Theoretically Dart Sass (which we're using here) can silence these
errors since v1.34.0:
https://github.com/sass/dart-sass/releases/tag/1.34.0
Other folks who have encountered this have even left handy PRs we can
:eye:
https://github.com/DanCorderSoftwire/govuk-design-system-dotnet/commit/eb12d7553b865b5e7f5c4d6f428b5b7e230a54a6#diff-7bca01eb707ebcc19f259555d952675647510b2155a9a313960a8470ea0f85a6R7
However my attempts to reproduce here have not resulted in any success.
Noting the Dart docs
(https://sass-lang.com/documentation/cli/dart-sass#quiet-deps) I
expected any of the following to have an impact:

--load-path=node_modules --quiet-deps
--load-path=node_modules/govuk-frontend --quiet-deps

But alas no joy. I even tried shuffling them around after the sass
command wondering if there was something funky with flag order
precidence.
--quiet does change things however.
Not ideal, as I would like to know if we have errors, just not those
inherited from our deps...
On the other hand, if we did have an error right now, not sure we'd see
it through all the noise.
So... The eternal sunshine of the spotless server log? Or overkill?
Or... what's wrong with the real solution anyway?
Thought we could discuss on this PR

Yeah good idea, I agree it's pretty annoying to see all those deprecation warnings.
The only CSS we have comes from GOV.UK Frontend, so we can't do anything about them. We also know they're aware of the problem and have a plan to mitigate it eventually.
I think that means I'm in favour of adding --quiet to silence all warnings. If we had our own CSS then I'd feel differently since there would be something useful to monitor or fix if needed, but as is I don't think we gain anything from the warnings.

You happy to ✅ ?


Wrap 2.0

This PR is the proposal for a 2.0 release of Wrap, which is the release that will bring master onto Swift 3 (compatibility with Swift 2.x will be kept through the 1.1.1 release). It contains the contents of the swift3 branch, as well as some API refinements:

Wrap(..) is now wrap(..)
Wrap(objects:) is now wrap()
keyForWrapping(propertyName:) is now keyForWrapping(propertyNamed:)
wrap(propertyName:originalValue:) is now wrap(propertyNamed:originalValue:)
All enums use a lower case leading character

Sounds reasonable to me.   One issue that is probably worth looking into is Int64 support.  The objective c bridgeable trick mentioned here: https://github.com/JohnSundell/Wrap/issues/13 does not work with Swift 3.0.
I think this might work with your new code.  Haven't been able to test fully yet though.
extension Int64: WrapCustomizable {
    public func wrap() -> Any? {
        return NSNumber(value: self)
    }
}

Have done further testing, and the code in my previous comment seems to be working well.  Without it, if you include a Int64 in your object, the resulting wrap dictionary will cause the Foundation JSON serialization code to fail because it does not recognize Int64.
https://developer.apple.com/reference/foundation/jsonserialization
I think the other numbers are covered because they are objectivecbridgeable.

@awclives That's awesome, will add it onto this PR!

OK let's 🚢 this! 🎉


feat: proper types for rows (#46)

feat: use proper type for row related properties

fix: detect update in rows automatically if row identity changed

perf: only detect changes in rows on real changes

docs: use row related types in examples

What kind of change does this PR introduce? (check one with "x")

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Other... Please describe:

What is the current behavior? (You can also link to an open issue here)
What is the new behavior?
Does this PR introduce a breaking change? (check one with "x")

[x] Yes
[ ] No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...
Other information:

@spike-rabbit I left some comments.

@spike-rabbit Not sure but shouldn't we add a breaking change note here? otherwise LGTM

breaking change added

There is one conflict which needs to be resolved locally.


EventGrid: 2020-04-01-preview refresh

Update the cli extension commands to include the new properties added as part of the preview API version 2020-04-01-preview (For example, partner registration metadata update such as customer service info and expiration time) as well as update event channel info with publisher filter.

Fix typo in help text as response to issue https://github.com/Azure/azure-cli-extensions/issues/1572

Update help text for new properties.

Fix current test for newer behavior and also add test for new properties.

Swagger review: https://github.com/Azure/azure-rest-api-specs/pull/9402

This checklist is used to make sure that common guidelines for a pull request are followed.

For new extensions:

[ ] My extension description/summary conforms to the Extension Summary Guidelines.

About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your PR is merged into master branch, a new PR will be created to update src/index.json automatically.
The precondition is to put your code inside this repo and upgrade the version in the PR but do not modify src/index.json.

hello @qwordy @Juliehzl  Can you please help review and merge this PR ASAP? thanks

add to S169


Shape Selection And Move

Connects to #246

This PR adds the ability to select and move a shape (no ReactGUI for it yet, so I've only added it to the core demo page).
Some things:

This is not currently an undoable action. It would be good to make this an action in the future, but not for every step of the way, just start and end.
I'm currently using the bounding rectangle as the 'select area' for each shape. I like this because for the whiteboard application that I'm working on we want something simple and this way you don't have to get fiddly with little bits to select something and move it out of the way. An earlier implementation was closer to shape outlines, so if you had transparent shapes you could select what's underneath them by clicking the visible bits, etc, by having each shape draw itself exactly on the select canvas (but in the proper color). I don't know which way we want the main library to go though, so let me know if the bounding rectangle select area isn't ok for now :)

(getting rid of the merge commit)

It's looking good! We would be glad to have this feature soon =)

The behavior you describe is a great start and I would have no problem merging your changes (once I've looked over the code tomorrow).

Thanks!

Doesn't work for me. Somehow I clicked a selection box for a shape that isn't there:

Here's the JSON of the drawing: https://gist.github.com/irskep/8db1b5715be7e1c33932

Oh, I just realized: I was selecting the eraser!
Selecting the polygons didn't seem to work though.

I also couldn't select the red line, or the line with the arrow on the end.

Yeah, selecting with the eraser as a possible tool is weird (as you mentioned in the issue). :/ Not sure what to do about it? The app that I have that's using this doesn't have an eraser, so it's not an issue there...
I'll try to figure out what's going on with your shapes and why some of them aren't selecting correctly...

No problem about the eraser. I think I said before, that ship sailed with SVG support. If people want erasers they have to give up some features. (In the future, I might implement a raster-based selection box tool that makes images instead of moving shapes, but that's out of scope for you.0

Thank you so much for doing this. It's well thought out and follows the project's conventions, as well as providing a feature that people have been asking for since the beginning. You have clearly taken the time to really understand what's going on.

No problem! This is a super fun project to work on, I'm happy when I get a chance to :)

I'm going to try to do a release today BTW (since I finally have time...) which means this probably won't make it in. One of us might have to edit the changelog entry.

BTW, @irskep -- one of the reasons we chose this library was because my coworkers and I were very amused by The New Dork Times.

OK, @irskep -- I believe I addressed everything, and I tested with your .json and everything selected OK! (My hex to int was all kinds of wonky -- better now.)

Hello guys, any idea if and when this PR will be merged? Would love to be able to move shapes also.

@MandaBrown merge whenever you like

(Sorry for forgetting about this)

I forgot about it too! Will look at the conflicts and then merge. Thanks!


(Slightly) expand executable check to include os.stat

Use of virtualized platforms is increasing in popularity. This includes using them to
create consistent environments for local development, despite underlying platforms
potentially varying widely. Even within a single organization of non-trivial size, it's
not unusual to have developers running several different versions of a single OS on
several different hardware revs from the same manufacturer. Containerization is a
popular way to attempt to eliminate environmental differences to achieve consistency.
Some virtualization layers confuse permissions checks inside virtualized environments
when those environments have access to host filesystems. docker/for-mac#5509 is a prime
example.
This expands the ways in which file executability is detected slightly. The prior
os.access check remains. If that should fail, this change includes an os.stat fallback.
Together, these should get closer to detecting whether the file is truly executable on
systems where such confusion is present.
Fixes #289.

@asottile, I understand you don't want to accept this, but can you offer some insight as to why?

I did search. I thought I made a case for why your response to #189 should be revisited, and offered, what I thought were novel arguments in favor of accommodating your users with minimal intrusion into code integrity. I accept those may not have been persuasive, but I have no insight into your reasoning. You closed the issue and this PR so quickly, that I'm not even sure they were considered?

I hope you understand that questioning past decisions for revisiting without providing new arguments is a waste of everyones time.  please do not do that

I'm a bit confused about this. From my perspective, my arguments were novel, as was my proposed solution. If you look at my proposed diff and compare it to that which was rejected in #189, you'll see it's different. I attempted to walk a line between not offering a solution to users (your default position) and something less of a deviation in #189 that preserved original behavior. I think you closed each of this PR and the corresponding issue within like 60 seconds of their respective filings. Maybe they weren't novel after all, or maybe I didn't make the differences or nuances I presented accessible, but providing something new was my understanding of what I was doing.

the decision in the duplicate is "we're not hacking around a mistake made by docker inc"


New release on pypi

Would it be possible to package up a new release on pypi? Looking forward to using the lib with the new Django 3.0 fixes.
Thank you!

9.1 is out.

9.1 is out.


Problems implementing routing with ui-router

On read me:
$auth.validateUser
This method returns a promise that will resolve if a user's auth token exists and is valid. This method does not accept any arguments.
Later on read me:
The following API methods accept a config option that can be used to specify the desired configuration.
$auth.authenticate
$auth.validateUser
$auth.submitRegistration
$auth.submitLogin
$auth.requestPasswordReset
All other methods ($auth.signOut, $auth.updateAccount, etc.) derive the configuration type from the current signed-in user.
I have:
.config(($stateProvider) ->
  $stateProvider
    .state('admin', {
      url: '/admin'
      abstract: true
      template: '

'
      resolve: {
        auth: ($auth) -> $auth.validateUser({config: 'admin'})
      }
    })
    # Invoice states
    .state('admin.invoices', {
      url: '/facturas'
      templateUrl: '/app/components/admin/invoices/invoices.html'
      controller: 'AdminInvoicesController'
    })

But if I log in not as and admin user (i.e. A dispatcher user), then this promise is being resolved anyway allowing the user to access routes that he shouldn't. Is there any kind of solution for this?

I came up with a workaround to this problem. I created a service that checks the user role.
auth-helper.coffee
angular.module('shared').factory('AuthHelper', ($q, $auth, $log) ->
  hasRole = (role) ->
    deferred = $q.defer()

    onValidateSuccess = (userData) ->
      if userData.configName is role
        $log.debug "Access allowed"
        deferred.resolve("Allowed")
      else
        $log.debug "Access denied. User doesn't have role " + role
        deferred.reject("Denied")

    onValidateError = ->
      $log.debug "Access denied. User couldn't be validated"
      deferred.reject("Denied")

    $auth.validateUser({config: role}).then(onValidateSuccess, onValidateError)

    deferred.promise

  return {
    hasRole: hasRole
  }
)

And in the configs..
.config(($stateProvider) ->
  $stateProvider
    .state('admin', {
      url: '/admin'
      abstract: true
      template: '

'
      resolve: {
        auth: (AuthHelper) -> AuthHelper.hasRole('admin')
      }
    })


Statement::query doesn't accept empty lists

As of 0.15, one can't use this kind of code:
let mut stmt = db.prepare(...);
stmt.query(&[]);

because type inference can't work on the &[].
There's no clear way to resolve this problem for a user.

It seems to not accept heterogeneous types, also:

130 |   stmt.execute(&[domain, format!("{}", today).as_str(), bytes]).unwrap();
|                                                         ^^^^^ expected &str, found struct std::vec::Vec

When parameters have different types, you need to force the type of the first one.
Something like:
stmt.execute(&[domain &ToSql, format!("{}", today).as_str(), bytes]).unwrap();

Would you mind closing the issue ?

I actually think the situation isn't usable right now, but ok.

Maybe we should ask for help ?
For example, we can ask: why https://github.com/sfackler/rust-postgres/issues/265 is still open ?

@gwenn I've read the linked discussions and code, but I'm not clear on why this became required? What new feature or bugfix caused the compiler to no longer be able to infer the type when providing an unadorned &[] as the argument?

With rusqlite < 0.15, SQL parameters can only be passed using &[&ToSql].
If you have a Vec<String> or a Vec<i32>, you cannot used it directly (see https://github.com/jgallagher/rusqlite/issues/312 and https://github.com/jgallagher/rusqlite/pull/409).
Now (rusqlite >= 0.15), you can use anything which can be transformed into an iterator of ToSql items.
The drawback is you cannot use &[] when there is no param.

Thanks.


fix acl magic code when creating acl with empty topicPerms or groupPerms

Which Issue(s) This PR Fixes

Fixes #8229
Brief Description
How Did You Test This Change?

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 42.91%. Comparing base (a430796) to head (a965569).
Report is 12 commits behind head on develop.

Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #8234      +/-   ##
=============================================
- Coverage      42.96%   42.91%   -0.05%
+ Complexity     10393    10382      -11
=============================================
  Files           1271     1271
  Lines          88785    88785
  Branches       11408    11408
=============================================
- Hits           38143    38103      -40
- Misses         45949    45973      +24
- Partials        4693     4709      +16

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

this pr has been approved, can it be merged?


Re-authenticate on every Request

Hi,
I used "RubyCasClient" 'authenticate_on_every_request' its keep authenticate with server but while sending a post request to server with parameters, after authentication of this request am not getting the post method parameters. i don't know why ?
Regards
Thiyagu.

Why you closed this issue

There is no issue, or at least no valuable evidence to the dev team what is it that warrants an open issue here. I suggest posting a question to CAS user mailing list and or to ruby CAS client maling list.


Uncaught TypeError: Cannot read property 'insertBefore' of null when (mis?)use v-if with 3rd-party JS library

Version
3.1.4
Reproduction link
https://codesandbox.io/s/error-when-option-v-if-choicesjs-forked-uoxq4?file=/src/components/Select.vue
Steps to reproduce
Take library Choices.js for example:

Use v-if in <option> (This is what the doc of choices.js ask user to do)

<template>
<select>
  <option value="" v-if="OPTIONS.length === 0">I'm a placeholder</option>
</select>
</template>

Initialize Choices.js instance.
Dynamically add options from Choices.js instance. Exploded.

What is expected?
No error, or a comprehensible error message emitted by Vue.
What is actually happening?
Uncaught (in promise) TypeError: Cannot read property 'insertBefore' of null

Some other libraries which manipulate DOM, such as the famous select2 jQuery plugin, have similar error.
I don't sure if this is a bug, or user indeed should not use v-if like this. If it is the later one, I also don't sure whether the error message emitted by Vue could be more comprehensible to user to know what exactly happened. (I spent 4 hours to find out where exactly this problem is.)

The rule of thumb is: if the element is consumed by an external library, let the external library completely handle it, so no elements inside of it that are handled by Vue. Otherwise, Vue will try to manipulate assuming it's the only one doing so to be able to apply the correct updates.


Create detailed milestone files and link them in README

There needs to be some milestone files containing the progress on cards and characters.
You should probably create the path readme/milestones/
Create two markdown files "cards_milestone.md" and "characters_milestone.md", each containing the progress on each character/card using a similar style as in "README.md" milestones section.
Refer to https://genshin-impact.fandom.com/wiki/Genius_Invokation_TCG/Card_List to find the list of all available cards. (note that we only want to implement cards obtainable by players for now)
If you have any questions regarding on the actual progress of the cards/characters, contact Jarvis-Yu, the repo owner.

Hi Jarvis-Yu, May I contribute to this issue ?

Sure, just fork the repo and make a pull request, appreciate your help.

Thanks Jarvis-Yu

No longer needed


Kerning on italic fonts is off

\mathit{i32}
Yields strange kerning between the 3 and the 2.

Indeed, this is a duplicate of #1250 which I just reported.


feat: add hints for schema config expr

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

[ ] N
[x] Y
fix #1244

2. What is the scope of this PR (e.g. component or file name):
kclvm/sema/src/advanced_resolver/node.rs

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

[x] Affects user behaviors
[ ] Contains syntax changes
[ ] Contains variable changes
[ ] Contains experimental features
[ ] Performance regression: Consumes more CPU
[ ] Performance regression: Consumes more Memory
[ ] Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

[x] N
[ ] Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

[ ] Unit test
[ ] Integration test
[ ] Benchmark (add benchmark stats below)
[ ] Manual test (add detailed scripts or steps below)
[ ] Other

How to check for the scope of config expr here? @He1pa @Peefy

Hello @shruti2522
What I mean in #1575 is to add hints to schema arguments, just like function parameters, rather than schema config expr.

Okay. I was initially working on adding hints for this, so I misunterstood. Will add hints for schema arguments.

Hello @shruti2522
What I mean in #1575 is to add hints to schema arguments, just like function parameters, rather than schema config expr.

Okay. I was initially working on adding hints for this, so I misunterstood. Will add hints for schema arguments.
From what I understand it is supposed to be like this? @Peefy @He1pa
schema Name:
    name: str
n: Name = [Name]{  // provide hint of anonymous schema name here
    name: “”
}

These are two features. Do not associate this PR with #1575, but #1244.

currently, hints are also added to schema config where schema name is alraedy defined, for example,

Since config_expr doesn't have a schema name field associated with it, how can we add a check for the name declaration here?  Should I do a schema_expr check here or maybe check for identifier expr.
cc @He1pa @Peefy

hints for anonymous schema expr:

no hints otherwise:

PTAL @Peefy @He1pa

Pull Request Test Coverage Report for Build<PHONE_NUMBER>7
Details

57 of 58 (98.28%)  changed or added relevant lines in 2 files are covered.
177 unchanged lines in 3 files lost coverage.
Overall coverage increased (+0.02%) to 70.606%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

kclvm/sema/src/advanced_resolver/node.rs
56
57
98.25%

Files with Coverage Reduction
New Missed Lines
%

kclvm/sema/src/advanced_resolver/node.rs
2
83.53%

kclvm/tools/src/LSP/src/inlay_hints.rs
3
92.31%

kclvm/sema/src/core/symbol.rs
172
52.54%

Totals

Change from base Build<PHONE_NUMBER>0:
0.02%

Covered Lines:
51039

Relevant Lines:
72287

💛  - Coveralls

Hello @shruti2522
Have you been working this issue?

Yes @Peefy


fix(composer): refetch nonce on submission failure

Summary
This adds handling for sequencer responses to transaction submission. Failures caused by invalid nonce reset the stored nonce and resubmit the transaction.
Background
See #293 and #307
Changes

Executor methods have been cleaned up and moved around a bit to make error handling more ergonomic
ExeuctionError type added to make error handling more ergonomic inside the Executor
Transactions that fail with AbciCode::InvalidNonce lead to resetting the Executor's stored nonce to None and are resubmitted.
Submitting a transaction when the stored nonce is None causes the Executor to fetch a new nonce from the sequencer.
Successful transaction submissions are logged

Testing

[x] Failed transaction submission due to invalid nonce results in nonce being refetched and the transaction resubmitted.

Related Issues
Link any issues that are related, prefer full github links.
closes #293
closes #307

I pushed a change replacing the ping-pong in the select! loop with a typed future that goes between the states NotStarted -> WaitForSubmit <-> WaitForNonce. Rather than cloning around tracing spans I realized that it would be easiest to just have everything run under one future.
All of this was also necessary because expressing retries (using tryhard) was much easier by tucking everything into one future.

Addressed all comments. Waiting for the @itamarreif as the original author to give the ok to merge this.
The PR text should be updated before merge.


DynamicAperture Softening parameter is dependent on the pixel scale

The softening parameter is meant to be agnostic to the physical scale of the aperture itself, but this is not the case.
Example:
import dLux as dl
import matplotlib.pyplot as plt

radius = 1e-6
aper = dl.CircularAperture(1e-6)
plt.imshow(aper.get_transmission(256, 2*radius))

We need to set softening to a very small value to get sensible results
aper = dl.CircularAperture(1e-6, softening=1e-5)
plt.imshow(aper.get_transmission(256, 2*radius))

This will be an issue for coronagraphs that have small angular pixel scales in the occulter plane.

@Jordan-Dennis would love your thoughts. I briefly tried to add a scale parameter to the _soften method taken from the coordinates but it seems the solution will be a little more involved than that.

Fixed with #246


Checkpoint: We do not always need a data_dir

This is still a good idea... or maybe get rid of data_dir entirely, and insist that input be supplied via envvars? The particular PR will probably not be merged, but it serves as a reminder.

Superseded by #195.


Handle strand creation for erroneous self-payment

Codecov Report

Merging #2112 into develop will decrease coverage by <.01%.
The diff coverage is 50%.

@@             Coverage Diff             @@
##           develop    #2112      +/-   ##
===========================================
- Coverage    68.84%   68.83%   -0.01%
===========================================
  Files          684      684
  Lines        50367    50369       +2
===========================================
- Hits         34674    34672       -2
- Misses       15693    15697       +4

Impacted Files
Coverage Δ

src/ripple/app/paths/RippleCalc.cpp
81.65% <0%> (ø)
:arrow_up:

src/ripple/app/paths/impl/PaySteps.cpp
72.92% <66.66%> (+0.12%)
:arrow_up:

src/ripple/beast/asio/io_latency_probe.h
97.01% <0%> (-1.5%)
:arrow_down:

src/ripple/server/impl/BaseWSPeer.h
67.5% <0%> (-0.63%)
:arrow_down:

src/ripple/core/impl/JobQueue.cpp
85.71% <0%> (-0.47%)
:arrow_down:

src/ripple/app/main/Application.cpp
60.82% <0%> (-0.13%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1dbc5a5...cda7fff. Read the comment docs.

@wilsonianb The old code handles this situation differently. It would not have an one-element pes (pes is similar to normPath in V1), however it would try to create a direct step from alice->alice and the error would be caught here: https://github.com/seelabs/rippled/blob/to-step/src/ripple/app/paths/impl/DirectStep.cpp#L823-L828

Squashed

Merged as 7dc2fe9ce79de22a0aa8657f90673efb0514bf04


Don't allow a user to etch a rune if a valid reveal is in the mempool

How do we handle low fees transactions that can be excluded from mempool or get stuck?

I think this is probably relatively low priority, so not necessarily worth doing right away if it's too hard. The best option would probably be to only warn the user if a valid reveal is in the mempool with a higher feerate than the one the user selected, so they can out-bid it.

Hello,
Did you removed wallet etch command? It can find it anymore and there are only 3 runes deployed. I need to make some deployment tests. Should I rewrite all the tx worklflow?

Runes are now etched with ord wallet inscribe --batch <BATCHFILE>.

Any specific structure for the batchfile?

Any requirements for batchfile? Also  it will increase the confusion between Runes protocol and ordinal protocol no?

Should we maintain a separate index with mempool transactions? I guess it'll take too long if we'll do it on demand.


Docs for v0.56.3

Signed-off-by: John Schnake<EMAIL_ADDRESS>Related to #1640

Just reviewed site docs and waiting for build basics to pass. Merging.


Addition of AFSSLPinningModeCA

Addition of AFSSLPinningModeCA and tests. But wasn't able to run them though!

@rafaelc0sta could you close this and create the PR off of the 3_0_0 branch? That branch will soon be master, and this feature wouldn't go until 3.0.0 is available.

@kcharwood Sure thing man!


Improve  handling of permissions using "sharing" field

Permissions are only stored if SharingMode is custom( "sharing" field is present). This will help with delta incrementals as well.

Does this PR need a docs update or release note?

[ ] :white_check_mark: Yes, it's included
[x] :clock1: Yes, but in a later PR
[ ] :no_entry: No

Type of change

[x] :sunflower: Feature
[ ] :bug: Bugfix
[ ] :world_map: Documentation
[ ] :robot: Test
[ ] :computer: CI/Deployment
[ ] :broom: Tech Debt/Cleanup

Issue(s)

closes https://github.com/alcionai/corso/issues/2459

Test Plan

[ ] :muscle: Manual
[ ] :zap: Unit test
[ ] :green_heart: E2E

The PR should be good to go if the design is good.


STRATEGY_REFERENCE does not work on windows.

Using @airbnb/nimbus with webpack option doesn't work with create-config webpack --silent.
this will create config path with looks like this:
module.exports = require('./node_modules\@airbnb\nimbus\configs\webpack.js');.
In wsl it works great.
This can be due to this line. Possible fix can be with path.normilize.

@rajzik Thanks for the report! I haven't had a change to do a Windows pass, but luckily this should be pretty easy to fix with normalize.

Fixed. Will be updated upstream soon.


Update policy generator build

ref: https://issues.redhat.com/browse/ACM-5803
Waiting on:

https://github.com/open-cluster-management-io/policy-generator-plugin/pull/123

[x] I have taken backward compatibility into consideration.

/approve
/lgtm
feel free to unhold whenever.


no "given name" if not assigned

historically we populated this column with the "sys id"
I think we might need to, because if you download with this column and is unassigned it will be blank?
@mah11 @Antonialock  thoughts?

Let's "leave  it and see".
The only issue might be if you do a query and only download primary names....

The only issue might be if you do a query and only download primary names....

Yeah I think people might moan for that reason. Then again, the primary names are just really an extra for people's heads when reading papers/talking about genes. People should be encouraged to use sys IDs as far as possible when dealing with gene lists.

Yeah that's what I was thinking.... they should use sys IDs really...let's wait and see...

ignoring for now


Python requirements: Remove casks

Neither python nor python3 are available from Caskroom.
Signed-off-by: Bob W. Hogg<EMAIL_ADDRESS>
[x] Have you followed the guidelines in our Contributing document?
[x] Have you checked to ensure there aren't other open Pull Requests for the same change?
[x] Have you added an explanation of what your changes do and why you'd like us to include them?
[ ] Have you written new tests for your changes? Here's an example.
[x] Have you successfully run brew tests with your changes locally?

Relevant discussion: https://github.com/homebrew/legacy-homebrew/pull/35257

Thanks again @rwhogg!


add ICEES PCD API / Problem with that API

The team behind ICEES APIs recently released a "PCD" (primary ciliary dyskinesia?) API. perhaps we would want to incorporate it into BTE?
https://smart-api.info/registry?q=4153c947a32e2e2a55a320d0bee22077
Example query:
{
    "message": {
        "query_graph": {
            "nodes": {
                "n0": {
                    "ids": ["MONDO:0009061"],
                    "categories": [
                        "biolink:DiseaseOrPhenotypicFeature"
                    ],
                    "name": "Cystic Fibrosis"
                },
                "n1": {
                    "categories": [
                        "biolink:ChemicalEntity"
                    ]
                }
            },
            "edges": {
                "e0": {
                    "subject": "n0",
                    "object": "n1",
                    "predicates": ["biolink:has_real_world_evidence_of_association_with"]
                }
            }
        }
    }
}

when I try to add PCD to the config file and run this query, I get console + TRAPI logs saying that the query failed. However the query will seem to successfully run when I post directly to the api (https://icees-pcd.renci.org/query)
It looks like there was an issue when BTE was trying to process the api's response...something about failing to

Here's the query I'm actually using for testing
{
    "message": {
        "query_graph": {
            "nodes": {
                "n0": {
                    "ids": ["MONDO:0009061"],
                    "categories": [
                        "biolink:DiseaseOrPhenotypicFeature"
                    ],
                    "name": "Cystic Fibrosis"
                },
                "n1": {
                    "categories": [
                        "biolink:Disease"
                    ]
                }
            },
            "edges": {
                "e0": {
                    "subject": "n0",
                    "object": "n1",
                    "predicates": ["biolink:has_real_world_evidence_of_association_with"]
                }
            }
        }
    }
}

The log...
  bte:call-apis:query Failed to make to following query: {"url":"https://icees-pcd.renci.org/query","data":{"message":{"query_graph":{"nodes":{"n0":{"ids":["MONDO:0009061"],"categories":["biolink:DiseaseOrPhenotypicFeature"]},"n1":{"categories":["biolink:Disease"]}},"edges":{"e01":{"subject":"n0","object":"n1","predicates":["biolink:has_real_world_evidence_of_association_with"]}}}},"submitter":"infores:bte"},"method":"post","timeout":50000,"headers":{"Content-Type":"application/json","User-Agent":"BTE/dev Node/v16.10.0 darwin"}}. The error is TypeError: Cannot use 'in' operator to search for 'message' in {"terms and conditions":"The Translator Integrated Clinical and Environmental Exposures Service (ICEES)

Update from lab meeting: no need for a dev yet, need to talk to Translator team developing ICEES and figure out what's going on with this API

update: seems to be related to this https://github.com/NCATS-Tangerine/icees-api/issues/225

update: I suggest waiting to work on this issue, due to the problems those APIs are having. we can return to this once those APIs are fixed

note update here https://github.com/biothings/BioThings_Explorer_TRAPI/issues/421#issuecomment-1092140340. ICEES PCD and Asthma are having issues

And I'll describe what I'm seeing with ICEES PCD again:

put only ICEES PCD in the config file

 exports.API_LIST = [
    {
        id: '4153c947a32e2e2a55a320d0bee22077',
        name: 'ICEES PCD Instance API - production'
    },
];

Compare ICEES PCD response (use the same queries and POST to https://icees-pcd.renci.org/query) to BTE (console logs and response)

Fever -> Disease: ICEES PCD returns 46 results when queried directly, BTE seems to handle this fine
{
    "message": {
        "query_graph": {
            "nodes": {
                "n0": {
                    "ids": ["PUBCHEM.COMPOUND:5865"],
                    "categories": [
                        "biolink:ChemicalEntity"
                    ],
                    "name": "Prednisone"
                },
                "n1": {
                    "categories": [
                        "biolink:DiseaseOrPhenotypicFeature"
                    ]
                }
            },
            "edges": {
                "e0": {
                    "subject": "n0",
                    "object": "n1",
                    "predicates": ["biolink:has_real_world_evidence_of_association_with"]
                }
            }
        }
    }
}

Cystic Fibrosis -> chem: ICEES PCD returns 121 results when queried directly, PROBLEM: BTE removes all records and terminates without any results
Note that some sub-queries fail, so BTE skips the rest of the sub-queries.
{
    "message": {
        "query_graph": {
            "nodes": {
                "n0": {
                    "ids": ["MONDO:0009061"],
                    "categories": [
                        "biolink:DiseaseOrPhenotypicFeature"
                    ],
                    "name": "Cystic Fibrosis"
                },
                "n1": {
                    "categories": [
                        "biolink:ChemicalEntity"
                    ]
                }
            },
            "edges": {
                "e0": {
                    "subject": "n0",
                    "object": "n1",
                    "predicates": ["biolink:has_real_world_evidence_of_association_with"]
                }
            }
        }
    }
}

Screenshot of BTE's console logs, showing the removal of "undefined records"

Similarly to my other findings, the issue here seems to be that the subject coming back is a mismatch - in this case MESH:C026422, which resolves to cystic fibrosis serum factor instead of cystic fibrosis. If this is expected/intended behavior, then we may need to add additional special handling for these sorts of cases?
Note that this query also returns the occasional object D, which I doubt is intended.

oops I only now realized that I didn't provide the right query for Fever -> Disease >.<. Now fixed.

Just providing more info to what Jackson said above: the QNode ID MONDO:0009061 (cystic fibrosis) is in the ICEES PCD response as a Node with the primary ID MESH:C026422, which Node Normalizer says is a chemical entity called cystic fibrosis serum factor.
Vs for the fever query, the QNode ID is used in the expected way: it's used in edges' subject fields and a node's primary ID / key.

I have the same response as I had on the related issue: https://github.com/biothings/BioThings_Explorer_TRAPI/issues/421#issuecomment-1136546681

Closing: based on Kara's Slack post in Translator's internal Slack (pasted below), these APIs are now non-Translator and are replaced by automat-icees-kg (Translator service) which we already ingest as of October.

Kara Fecho (Exposures Provider, SRI)
[2:14 PM] Jan 5 2023
channel: I wanted to alert folks to a few changes to ICEES. Specifically, shortly before the September relay, we deployed a new service, icees-kg, to the ITRB production environment. (I had announced this, but I think my message was lost in pre-relay preparations. :slightly_smiling_face:) icees-kg provides a graphical representation of four ICEES datasets, asthma, PCD, DILI, and COVID, each containing one or more years of integrated patient + exposures data. icees-kg is intended to replace icees-asthma, icees-pcd, and icees-dili as the sole ICEES-related Translator KP. The fully featured icees-asthma, icees-pcd, icees-dili, and icees-covid services remain available, just not as Translator services.
Note that icees-kg should represent an improvement in our previous approach in that: (1) it provisions new data on COVID; (2) response time should be super quick and reliable; and (3) it is fully compliant with all regulatory and institutional requirements for ITRB cloud deployment.
Please feel free to reach out to me, should you have questions.
Thanks! (edited)


Iterative parser

Description
Results are being streamed
GitHub Issues

#38

Coverage decreased (-1.9%) to 91.667% when pulling ae8c08f4d348ddb31486e5165def79322b1db6c6 on mcrowson:iterative-parser into 48b7ab0d677347fbaf001dce70ce24bce244dabd on refindlyllc:master.

Coverage decreased (-2.0%) to 91.649% when pulling a80c022bfdaff15f7ee5632b4b0e39d5b1b2d53a on mcrowson:iterative-parser into 48b7ab0d677347fbaf001dce70ce24bce244dabd on refindlyllc:master.


feat(nodebuilder/state): Provide stubbed state module if a core endpoint not provided

This is a pre-requisite for #2511
It makes a check in CoreAccessor constructor to see if a core endpoint was provided, and returns nil CoreAccessor if not. A stubbed state module will then be provided if no core endpoint was provided so that errors are more readable.
Previously, node start logic relied on the fact that the grpc Dial inside CoreAccessor.Start was non-blocking so it could silently fail under the hood and any calls made on state Module would return errors from the inability to reach the address that is the default for the core config (which was confusing).

Codecov Report

Merging #2577 (1b24356) into main (79a195c) will decrease coverage by 0.24%.
Report is 5 commits behind head on main.
The diff coverage is 90.00%.

@@            Coverage Diff             @@
##             main    #2577      +/-   ##
==========================================
- Coverage   51.23%   50.99%   -0.24%
==========================================
  Files         158      158
  Lines       10409    10444      +35
==========================================
- Hits         5333     5326       -7
- Misses       4613     4653      +40
- Partials      463      465       +2

Files Changed
Coverage Δ

nodebuilder/settings.go
49.60% <80.00%> (-1.56%)
:arrow_down:

state/core_access.go
27.97% <100.00%> (+1.02%)
:arrow_up:

... and 4 files with indirect coverage changes


fix dockerfiles

Description
Changes proposed in this pull request:

...
...
...

Related issue(s)

/retest


Delay object parsing exceptions, reraise on object retrieval

This catches any exceptions thrown by from_didl_string during event handling. Instead an ErrorDescriptor is created, which rethrows the exception when the user tries to retrieve it from the variable dict. This avoids an exception in the event thread, instead letting the user handle it when he needs the object. To make this possible, a DescriptorDict data structure is created, which handles descriptor items like descriptor attributes.
Compare with #567 for another implementation of the same proposal.
See #566 for information on why this is needed.
Closes #566, closes #567.

I'll close this one in favor of #567


Signify CS "violators" vs. common intervals

E-shaped comma — Today at 1:23 PM

if it's nontrivial to implement then dw about it but i'd suggest only highlighting the "violators", judged by what the more common mapping for an interval is by # of occurrences

Was nontrivial so nw about it.


PHPLIB-808: Leave fullDocument change stream option unset by default

https://jira.mongodb.org/browse/PHPLIB-808

@aleksandr-rudo: This can be squash-merged. Please remember to delete the adjust the commit message to remove anything not relevant to the final commit.


Change error message when launching a second admin instance

Previously it said "second instance" to refer to the already-running instance, which came first.
Furthermore, as a user I don't enumerate my instances of VSCode.

👍 , meanwhile noticed a hardcoded Code here that we should also replace:
https://github.com/microsoft/vscode/blob/ef415578d1b1019db585718968a303eeca4b8979/src/vs/code/electron-main/main.ts#L380


Do you mind if modify for Paper server?

Do you mind if I modify this library for the Paper server?

Don't need to. This library feature is spigot(bukkit) only. We can use it as it as if we use it on Paper.
p.s. The issue title was not good. So I changed.

If we use this library on forked Spigot, rewrite dependencies in build.gradle like this;

    dependencies {
        // ...
        implementation("com.github.sya-ri:easy-spigot-api:1.0.0") // not yet support
        implementation("net.pl3x.purpur:purpur-api:1.16.5-R0.1-SNAPSHOT") // e.g. Purpur
    }


error reporting

ATM errors are handled entirely inside api-v1. It would be neat to have a hook when an error occurs so we can intercept it and in case of welovekpop.club report it via bugsnag.
I'm thinking of having an option for custom error handler middleware, since error reporting libraries usually know how to make nice stack traces from express middleware and maybe not from an 'error' event (not sure). for bugsnag that would be something like:
app.use(Bugsnag.requestHandler)
createWebApi(uw, {
  // options
  errorHandler: Bugsnag.errorHandler
})

maybe can re-emit the errors after writing the response using next… that seems bad style, but idk


Set up the bootstrap instrumentation plugin framework

Hi, All
This PR is following #2932, in these days, I work on building the bootstrap instrumentation plugin framework by not breaking any existing plugin. Look like it works.
For plugin developer, one line required only in plugin define.
     // This is the only change for plugin developer
    @Override public boolean isBootstrapInstrumentation() {
        return true;
    }

If you want to understand how I do this, follow BootstrapInstrumentBoost class, it will link the things together. Also, plugin interceptor point definitions have been as public, as BootstrapInstrumentBoost needs to access it.
Also, I add a demo jre-HttpUrlConnection plugin for demo, and instrumen the following application codes.
import java.io.BufferedReader;
import java.io.IOException;
import java.io.InputStreamReader;
import java.net.HttpURLConnection;
import java.net.URL;

public class Main {
    public static void main(String[] args) throws IOException {
        URL obj = new URL("http://www.baidu.com");
        HttpURLConnection con = (HttpURLConnection)obj.openConnection();

        con.setRequestMethod("GET");

        int responseCode = con.getResponseCode();
        System.out.println("Response Code : " + responseCode);

        BufferedReader in = new BufferedReader(
            new InputStreamReader(con.getInputStream()));
        String inputLine;
        StringBuffer response = new StringBuffer();

        while ((inputLine = in.readLine()) != null) {
            response.append(inputLine);
        }
        in.close();

        //print result
        System.out.println(response.toString());
    }
}

Like the existing plugins, the bootstrap intrumentation only requires you to declare it in plugin define, such as following codes I included in this PR
/**
 * @author wusheng
 */
public class HttpUrlConnectionInstrumentation extends ClassEnhancePluginDefine {
    private static String CLASS_NAME = "java.net.HttpURLConnection";

     // This is the only change for plugin developer
    @Override public boolean isBootstrapInstrumentation() {
        return true;
    }

    @Override protected ClassMatch enhanceClass() {
        return byName(CLASS_NAME);
    }

    @Override public InstanceMethodsInterceptPoint[] getInstanceMethodsInterceptPoints() {
        return new InstanceMethodsInterceptPoint[] {
            new InstanceMethodsInterceptPoint() {
                @Override public ElementMatcher<MethodDescription> getMethodsMatcher() {
                    return named("setRequestMethod");
                }

                @Override public String getMethodsInterceptor() {
                    return "org.apache.skywalking.apm.plugin.jre.httpurlconnection.Interceptor";
                }

                @Override public boolean isOverrideArgs() {
                    return false;
                }
            }
        };
    }
}

Also, I haven't finished construct and static method plugin, but they are very similar, as we have this, they are simple. I will push those later.
I hope you could test this new mechanism in other demo codes, Spring Boot and Tomcat especially, in case I miss anything.
@ascrutae Please lead the tests.

This PR is ready to review and test. I have used it to instrument URL and HttpURLConnection successfully. But just a demo code, of course.
Part of my test codes are posted here, https://gist.github.com/wu-sheng/25a8877971db089e196ada0fe4395813
In this PR, there is no real plugin. But further pull request is welcome.

I have tested in bootstrap class and 3rd part class,both work well.
I have a question,the classes in HIGH_PRIORITY_CLASSES still will be loaded by two classloader,right?
but I debug found, eg.EnhancedInstance is loaded by bootstrap classloader in bootstrap interceptor (generated by InstanceMethodInterTemplate),and  in normal InstMethodsInter it is loaded by application classloader .is it right?
I think EnhancedInstance will be find in bootstrap classloader first .

I have tested in bootstrap class and 3rd part class,both work well.
I have a question,the classes in HIGH_PRIORITY_CLASSES still will be loaded by two classloader,right?
but I debug found, eg.EnhancedInstance is loaded by bootstrap classloader in bootstrap interceptor (generated by InstanceMethodInterTemplate),and in normal InstMethodsInter it is loaded by application classloader .is it right?
I think EnhancedInstance will be find in bootstrap classloader first .

You do the tests quickly :) Thanks.
To your question, from my understanding, when bootstrap instrumentation actived, EnhancedInstance should only be loaded in Bootstrap classloader. Otherwise, you will face Class Cast Exception, because you can't cat Bootstrap's EnhancedInstance to ApplicationClassLoader's EnhancedInstance.
Load the generated class to class loader w/o initialization should be safe. That is why I use #injectRaw rather than #inject.
This is my guess and understanding from test results, I used to try #inject, which cause that cast exception. :)

@candyleer If you are OK, please approve this PR.

@candyleer If you are OK, please approve this PR.

is this file (debug/org.apache.skywalking.apm.agent.core.plugin.interceptor.enhance.bootstrap.Interceptor_internal.class) committed by mistake?

is this file (debug/org.apache.skywalking.apm.agent.core.plugin.interceptor.enhance.bootstrap.Interceptor_internal.class) committed by mistake?

Yes. Removing it.

@candyleer Have you tested Tomcat? And JDK 6?

/run ci

@candyleer Have you tested Tomcat? And JDK 6?

I have test Tomcat .but JDK 6 not test ,maybe tomorrow I can run a test manually.

It seems not support JDK6 for the error:

Look like javassist has an error.

I have tested ,javassist v3.21.0-GA is the last version support jdk6,and we can work well by using it

@candyleer Updated.

@ascrutae Please run our autotests, let's see whether this breaks anything.

/run ci

/run ci

From the test report, it is same as before. After CI pass, I will merge this to the core. The new plugin is welcome, especially for HttpUrlConnection.


Error using Chrome and Edge drivers

This is a fantastic resource - if only I could get it working!
I've attached screenshots of the errors I have received while attempting to run this code with the driver set to Chrome and then Edge. I have also amended #ru to #jp. I am running Windows 11.

Thank you for all your hard work; any support in resolving this would be much appreciated.

I was able to resolve this issue by using the Firefox driver. This may be an issue with Chrome and Edge.


Minecraft crashes during forge loading sequence

I am currently trying to play my own mod pack (89 total), and I can't even get to the Minecraft screen because every time during the forge mod loading sequence It crashes. Now, what I can tell from the crash log is that my issue probably has something to do with Advent of Ascension 3 (file name AoA3-3.3.3.jar). I believe this from this line in the report:
java.lang.NoClassDefFoundError: net/tslat/aoa3/entity/boss/horon/EntityHoron
If anyone can please explain how to fix this I will be eternally grateful as this is my first attempt of making my own mod pack. I am using the twitch app to download and set up this back FYI and I will also attach the full crash log.
One last thing, if I am on the wrong help page I ask for someone to point me in the right direction.
Thanks,
Sincerely, DaddyGunXTC
crash-2020-08-20_23.38.15-client copy.txt

This issue is not related to NetherEx, but I tried to take a look into it and I couldn't find the cause. It'd be best to ask on the Advent of Ascension GitHub here.


x/crypt: package does not support yescrypt algorithm

x/crypt: package does not support yescrypt algorithm

Duplicate of #49898


Solidarity with TestFlight

I heard about Solidarity on React Native Radio, and appreciate the work you've done on solving a big problem.  A React Native app works on my phone with TestFlight, but much more slowly and crashes (possibly because of rapidly repeated presses) on a key stakeholder's phone.  The key stakeholder is not technical.  Would Solidarity be able to help me understand why it doesn't work as well on the stakeholder's phone?  I looked through the Solidarity repo and Googled "Solidarity with TestFlight" before posting this.

Hrmmm, it's more of the developer environment than differences on phones.  Solidarity will be a poor tool for helping this.   I'm thinking instruments for iOS?
BTW, what phone does your stakeholder have?

Thanks for letting me know, GantMan.  The stakeholder has an iPhone X and I have an iPhone 8.  The issue seems to be that I have the most current iOS version on my phone and the stakeholder didn't.


return full message instead of truncated with guzzle exceptions

Fixes: https://github.com/GoogleCloudPlatform/google-cloud-php/issues/145

@tmatsuo @cedricziel @bshaffer PTAL

LGTM

LGTM! Thanks @dwsupplee

Thank you!


is it true this library is not been maintained anymore ?

is it true this library is not been maintained anymore ?

@scorlingonzalez no that's not true!    It is true that we don't have any new planned features or obvious bugs, but please file issues for changes you'd like to see.


Use classList.toggle

With Angular dropping IE11 support in version 13, we can now use classList.toggle with the second force param. Related to #7374

Updated to remove tslint check

this has a merge conflict, please resolve the conflict so we can run presubmit

@zarend rebased

This failed some targets because either the list of classes to add/remove is an empty array or the array contains an empty string, which produces SyntaxError: Failed to execute 'add' on 'DOMTokenList': The token provided must not be empty.
You can test this locally in the devtools by trying to add an empty list/token.
To fix, you'll want to filter out empty strings and only apply add/remove if the array has length != 0

To make this pass internally, only overlay needs to be changed to something like:
  /** Toggles a single CSS class or an array of classes on an element. */
  private _toggleClasses(element: HTMLElement, cssClasses: string | string[], isAdd: boolean) {
    const classes = coerceArray(cssClasses || []).filter(c => !!c);

    if (classes.length) {
      isAdd ? element.classList.add(...classes) : element.classList.remove(...classes);
    }
  }

@andrewseguin updated PR with the fix for overlay, including additional checks in the unit tests for this case.


Remove lombok.val and lombok.var

As it causes some compile issues if we use different JDK versions to compile, better to remove the lombok.val and lombok.var in the whole codebase

Just FYI, we won't use lombok.val and lombok.var in new code anymore @yampml @axblueblader @haphananhtuan @the123saurav


wrong totalBatteryCapacity for MG4 standard

Hi!
I'd say totalBatteryCapacity need some kind of parsing.
I found it is throwing me 72,5 kWh (as per 725/10) but I have a MG4 standard which only has 51,8 kWh. I was unable to find a conversion that makes any sense so I'll keep triying to find the factor or base transformation to reach the right figure.
Thank u for your amazing job! :muscle:

My 64kWh Trophy also shows that 72.5 figure, so it's not a question of conversion. I get these figures
saic/.../drivetrain/lastChargeEndingPower 65.4
saic/.../drivetrain/totalBatteryCapacity 72.5

which give the correct post-charge (but not live) % SoC as a ratio, but I don't see anything that looks like the actual kWh capacity.
Under the "511" JSON response, I see an applicationData.basicVehicleStatus.extendedData1 value of 90 which matches my current % SoC but I don't know if that's a coincidence.

It seems not to be a coincidence, my figures also match. extendedData1 and actual soc, I mean. But not always. Sometimes I got 128. I'd say when car is not in active mode but I have to double check. I've put a filter in my nodered to avoid this 128 meanwhile

extendedData1 is the SOC. Verified in the original ISMART app source code.

Hello, has this already been corrected? I use the Docker Image on my Synology NAS and unfortunately I get the wrong data displayed as the SOC.
extendedData1 is not sent to my broker. It would be great if that was adjusted.
Thanks for the great work and regards

Hallo,
my Marvel-R schould have( in specification )  a  70 kWh HV Battery. I think it is a problem with SAIC.

Here are my values now.

Maybe i don't understand the API / DOCs but at the moment my SoC ist 77,9 ( % ), that is correct. Sometime i get a value of 102,3 ( % ).
When "totalbatteryCapacity" = 72,5 then soc_kwh cannot be 74,2, it should be 56,5 ( % )
Also ( i hope ) the values for "current", "voltage" and "power" are not real.
Keep up the great work. This is getting better with every new version.

Total battery capacity is always 72.5. That is a wrong value coming from the SAIC API. I have not found a value in the API that corresponds to the real battery capacity.
current = bmsPackCrnt * 0.05d - 1000.0d
voltage = bmsPackVol * 0.25
power = current * voltage / 1000d
https://github.com/SAIC-iSmart-API/saic-java-client/blob/d02d83da71d41a51a0a52cd19ba132b47febe9c2/saic-java-mqtt-gateway/src/main/java/net/heberling/ismart/mqtt/VehicleState.java#L376-L394

Hello,
that with Battery capacity is not really a problem.
Sorry, i was not questioning your calculations, but the values. When the cat is of, my normal values are  375V Voltage, 0,0A current  and 0,0 power. Why are the values for current and power so high? I don't think that 2300A really flowing in the car.


Feature 123 move release notes

Pull Request Testing

[x] Describe testing already performed for these changes:
Updated Chapter formatting
Renamed some sections (especially the beta sections)
Removed version sections
added returns to stay under 79 characters per line

[x] Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:
Please review the below web page.  Make sure the chapter names and sub sections are correct.
https://metdataio.readthedocs.io/en/feature_123_move_release_notes/Users_Guide/release-notes.html

[x] Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [No]

[x] Do these changes include sufficient testing updates? [No]

[x] Will this PR result in changes to the test suite? [No]
If yes, describe the new output and/or changes to the existing output:

[x] Please complete this pull request review by 10/20/22.

Pull Request Checklist
See the METplus Workflow for details.

[x] Review the source issue metadata (required labels, projects, and milestone).
[x] Complete the PR definition above.
[x] Ensure the PR title matches the feature or bugfix branch name.  feature_123_move_release_notes
[x] Define the PR metadata, as permissions allow.
Select: Reviewer(s)
Select: Organization level software support Project or Repository level development cycle Project
Select: Milestone as the version that will include these changes
[x] After submitting the PR, select Development issue with the original issue number.
[ ] After the PR is approved, merge your changes. If permissions do not allow this, request that the reviewer do the merge.
[ ] Close the linked issue and delete your feature or bugfix branch from GitHub.

All changes have been made