Add version check command

Related Issue(s)
https://github.com/nasa/fprime/issues/2407

Has Unit Tests (y/n)
n

Documentation Included (y/n)
y

Change Description
Adds a version check command for

Python version
Pip version
CMake version and
Toolchain version info

Rationale
Help debug things
Future Work
Unit tests preferably.

I also added a skeleton unit test for commands (as asked above in the PR), it's pretty empty as of now but I would be happy to write tests for special-parser commands.

Looks like you also need to run the formatter -
pip install black
black ./path/to/file_to_format.py

I figured you might want to take this across the finish line yourself, but let me know if you want me to help make some changes.

All the requested changes were made including the unused import one and it works as intended in local settings.

Thanks! Note to myself: add OS and processor architecture information as well

Rather than using sys, I utilized the platform library for retrieving all system info.

Any updates on this @thomas-bc?

Apologies for the delay, I was out for a bit. LGTM! Thank you very much for this, we want to add this command to our bug_report.md issue template over on https://github.com/nasa/fprime. Feel free to make the PR yourself there if you want to! e.g. add a section/checkmark

[] Please paste the output of fprime-util version-check:


ease testability by removing references of 'state'

previously, the state was referenced multiple times by the
questionnaireAnalyzer which made it difficult to write unit tests
for some functions

I face an error by sending the questionnaire. Could you please check this @mbastian93 ?

I face an error by sending the questionnaire. Could you please check this @mbastian93 ?

I accidentally swapped parameters in a method call; should be fixed with 6f3ea4a


[feature/removeVariable] replace Variable on BehaviourRelay

Hi, thank you for your great work!
This PR allows migrate ReactorKit on Behavior & Publish Relays instead of own types.

Codecov Report

Merging #16 into master will not change coverage.
The diff coverage is 100%.

@@          Coverage Diff          @@
##           master    #16   +/-   ##
=====================================
  Coverage     100%   100%
=====================================
  Files           4      4
  Lines          78     78
=====================================
  Hits           78     78

Impacted Files
Coverage Δ

Sources/RxExpect/RxExpect.swift
100% <100%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c3a3bb3...9432f9c. Read the comment docs.


Add email validation for Python using regex

Add email validation following rules for Python using regular expression.

Thank you for your contribution, @shresthalucky ! @all-contributors please add @shresthalucky  for code.


Erronous import of identically named files

Reproduction
So, this has started happening recently, so I assume due to an automatic ^ upgrade. I have an environment where we use modules that have directory and file structures that are identical. So, each module will have a file config.ts with a config.path representing the route for this module.
The problem is that if a single route loads various components that end up using config files from different modules on different import paths. remix will end up referencing a config file different than the one being imported inside a single file. So, using the "wrong" import path. I debugged this and found that the block context would contain multiple config file references within the block context for a file, and it would pick the first one available. Which will end up being the wrong one for some files.
The workaround is importing a config file with a different name import { config as clazzConfig } from ~my-package/module/config.ts
Not sure if this easily reproduceable but it started occurring only recently. I think this only happens in dev but I didn't verify that.
System Info
System:
    OS: macOS 14.2.1
    CPU: (11) arm64 Apple M3 Pro
    Memory: 80.53 MB / 18.00 GB
    Shell: 5.9 - /bin/zsh
  Binaries:
    Node: 20.11.1 - ~/.nvm/versions/node/v20.11.1/bin/node
    Yarn: 1.22.22 - ~/.nvm/versions/node/v20.11.1/bin/yarn
    npm: 10.2.4 - ~/.nvm/versions/node/v20.11.1/bin/npm
  Browsers:
    Chrome: 124.0.6367.201
    Safari: 17.2.1

Used Package Manager
yarn
Expected Behavior
Any imported file should get the reference file contents.
Actual Behavior
Remix references an identically named file import on a different import path

Could be. If you guys have a base repo I can copy and customize, that would save me the time I don't have to do it from scratch

The easiest would be to create a stackblitz. https://remix.new will create a basic Remix app.


IconButton cannot skip focus traversal

Use case
In a list of widgets an IconButton will get focus when requesting next focus and currently there is no way to prevent this since it only sets the focusnode of the Focus widget but not the skipTraversal propery.
And the focus widget overrides the skipTraversal property of the focusnode given.

Proposal
Add a skipTraversal property to IconButton that passes it on to the Focus widget.

The part about overriding skipTraversal from what is set on the focusNode is already fixed, I'm pretty sure, in which case you should be able to set that on the node and have it act the way you want. I'd prefer not to add every Focus attribute to every control that can take focus if we can help it: the API is already pretty viral.
If the Focus widget is still overriding the focusNode's notion of skipTraversal, then we should fix that, however. I think it properly sets it here in didUpdateWidget, so that if the widget's skipTraversal is null (as it is in IconButton), then it should take the one from the focusNode:

Ah I see, that's probably why skipTraversal no longer has a default value.
Then we just need to update that part of the documentation, (it currently states that it cannot be null)


Make Model Builder Open Source

Could you please let me know where is the source code for Machine Learning Model Builder? Or is that private?
I see only this:

It's private at the moment. We're looking into the option of making it open source.
Why do you ask? Would you be interested in contributing? Are there certain features you'd like to see added?

It's private at the moment. We're looking into the option of making it open source.
Why do you ask? Would you be interested in contributing? Are there certain features you'd like to see added?

I would like to contribute if I can. (I hope it's C#).
In my opinion, the Model Builder has a big impact on adopting ML.NET by developers who don't have Data Science background.
I would like to see more options in preparing the data (this was the point I decided to ask about the repository).
Thank you for your answer.

Thanks! We'll look into Open Sourcing.

Yes, I'm also interested in knowing the plans to open-source Model Builder.  I doubt I would be much help in contributing.  Mainly curious on how the extension works when adding the mbconfig and related files to project.  Thx

Closing this in favor of the linked epic.


Support fixed opacity

This library scales the opacity of the color with the heat of the color.  For bubble heatmaps that does not work well.  In the screenshot below, the hotspot in the upper right is completely opaque and blocks the underlying map.  The library should support optionally displaying all colors at the same opacity.

The following image sets fixedOpacity to 100.


Use conda provided ld

Checklist

[ ] Used a fork of the feedstock to propose changes
[ ] Bumped the build number (if the version is unchanged)
[ ] Reset the build number to 0 (if the version changed)
[ ] Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[ ] Ensured the license file is being packaged.

cc @mingwandroid.
Fixes issues seen in https://github.com/conda-forge/arpack-feedstock/pull/34

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

I’m happy to merge this but I know you can too. I have no idea what is going on here so do feel free to merge when you are ready!

Is this build failure here related to this PR @isuruf?
https://github.com/conda-forge/glmnet-feedstock/pull/11

Error message is
      "_main", referenced from:
         implicit entry/start for main executable
    ld: symbol(s) not found for architecture x86_64


Add BitScreener Token (BITX)

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

[x] Filename in the lowercase format
[x] Image format: png
[x] Image size: 256 by 256 px

@tobernguyen
Also, you can use these graphics to say that your ERC20 token fully compatible with Trust Wallet (https://trustwalletapp.com/logo-assets). Tokens will show up automatically once the user receives them.
Feel free to share this on social media and tag Trust Wallet:

Twitter: @trustwalletapp

Facebook: @trustwalletapp


zf (create manual fold command) is broken

Hey, just noticed this issue: when using your plugin I can't create manual folds anymore. zf triggers f-navigation. Disabling the plugin makes it work again.

I cannot reproduce this. Let's see what could be the problem on your side... 1. Are you using the plugin with the default settings? 2. Do you use zf literally, or maybe you have an alias/shortcut defined for that with nmap (recursive)? 3. Do zF and zt work as expected?

I'm using the plugin with the default settings.
:map zf returns:

o  z             <Plug>Lightspeed_s
x  z             <Plug>Lightspeed_s

zF and zT don't work either.

Then map f/F/t/T to anything else, and let's try whether that breaks zf too...

:unmap f alone is not enough. Also had to :unmap z to get zf back working.

So if you unmap z only, then both the plugin and zf work again?

Oh, okay, you're using it in Visual mode... Well, yeah, the plugin maps z/Z (because s/S are more adequate for surround plugins in that case). My bad, I forgot that z is used in zf and the like, I just wanted to make the mappings more consistent compared to Sneak. So, for the moment, xmap something else to <Plug>Lightspeed_s/S (before the plugin is loaded) - and I will reconsider the default mappings...


NamingSystem for identifiers

Currently, any identifiers in mimic-fhir reference a custom URLs such as http://mimic.fhir.mit.edu/identifier/patient, but nothing is defined for that. It was brought up that a NamingSystem could make sense here. Will look into this further!

@jpwiedekopf any experience with NamingSystems?

Not really, but the resource is actually designed for that purpose: it defines a namespace for identifiers independent of its usage in the resource, thus adding metadata to the canonical URL of the identifier. I think they would look somewhat like this example from the FHIR spec for us: https://hl7.org/fhir/namingsystem-example-id.json.html

Okay ya that makes sense. Once the mimic-ed branch is wrapped up I'll look to update the identifier links to NamingSystems


Incorrect delegate signature Silk.NET.OpenCL.NotifyCallback

Summary
The Silk.NET.OpenCL.NotifyCallback delegate type is used everywhere a callback function can be specified in the OpenCL API, however the callback functions used in he OpenCL API methods each have different signatures.
The currently implemented NotifyCallback appears to have the signature used by the clCreateContext API, which is quite different from the callback signature used by the setEventCallback API. This causes callback arguments to be misplaced and possibly worse.
One solution might be to use different delegate types for each of the callbacks. Another option might be to just allow a pointer to
be specified so the user can use Marshal.GetFunctionPointerForDelegate to a delegate type of their own.
Steps to reproduce

Platform: Desktop
Framework Version: .NET 4.8
API: OpenCL
API Version: OpenCL 1.2

I queued a memory read (EnqueueReadBuffer) with an event
I registered a callback function (SetEventCallback)
I noticed the user data I passed to SetEventCallback was not in the userData parameter, but shifted one position to the cb parameter in the callback.

If you know how to fix this issue, please submit a pull request instead!
Unfortunately it is not yet clear to me how the OpenCL code is generated, otherwise I would have considered submitting a pull request instead.

I have no idea about OpenCL, but I highly doubt this is a ST issue. Likely an issue with upstream (wherever that is) definitions.

Fixed by #1251


Rename "complete-task" to "start-worker"

Is your feature request related to a problem? Please describe.
The action "complete-task" is misleading. It sounds as if I could complete a single activated job. However, what is actually happening is that a worker is started which is waiting for jobs to get activated and then completing all of them.
Describe the solution you'd like
I would like to have a name that is clear.

I'm happy to make the change. I just wanted to create the issue as a reminder, so we can talk about and decide whether this shall be changed or not.

I'm supporting the intention of having clear names. When we talk about Zeebe then it would be more exact to call it "start-worker".
But I'm not sure about changing the name because the tool should be agnostic to the concrete BPMN engine. Another engine may call it differently. The name "complete-task" is more general. So, the concrete test runner can implement it in a proper way.


[RFC] Make @opentelemetry/api opt-in

Context:
@azure/core-tracing depends on @opentelemetry/api. While analyzing bundle size, this dependency contributes ~20kb which is big for small libraries such as REST clients which would be ~20kb otherwise. Since core-rest-pipeline dependes on core-tracing we get this extra 20kb in virtually all our libraries.
We could make the dependency on @opentelemetry/api an optional one if we can dynamically import it only when it has been installed by our library consumers, otherwise provide noop operations from core-tracing.
@xirzec mentioned that by default, core-tracing uses a noop tracer, and customers that want to use tracing on our libraries would need to install @opentelemetry in their projects to configure it (here's an example). So it makes sense to treat it as a peer dependency. (@xirzec feel free to correct me if I misunderstood this).
Proposal:
In order to achieve this we'd need to address the following:

Make sure npm install doesn't install @opentelemetry/api
Handle the scenario where @opentelemetry/api is not installed and provide a set of noop functions/classes

Optional @opentelemetry/api
We could use npm's peerDependecies and peerDependenciesMeta to achieve optionallity on this dependency. For npm versions > 3 and < 7 just having it as a peer dependency sufices. However starting npm 7 peer dependencies are installed by default. However it seems like marking a dependency as optional in peerDependenciesMeta would stop npm from installing the dependency
in @azure/core-tracing we could add this
  "peerDependencies": {
    "@opentelemetry/api": "^1.0.1"
  },
  "peerDependenciesMeta": {
    "@opentelemetry/api": {
      "optional": true
    }
  },

Handling missing @opentelemetry/api
For this we could dynamically try to import the actual implementation. By default loading noop implementations of core-tracing function that depend on opentelemetry such as createSpanFunction, getSpan, setSpan, etc.
It would look like this in core-tracing index.ts
// index.ts
let createSpanFunction: CreateSpanFunction = createSpanNoop;

try {
  require("@opentelemetry/api");
  createSpanFunction = require("./createSpan").createSpanFunction;
} catch {}

export { createSpanFunction };

Note: I was thinking on using an actual dynamic import("@opentelemetry/api"), however  this seems to only be supported in node >= 13.2.0

Can't we still use the dynamic await and let TS downlevel it to require? Or does it not do that for cjs module output?

Update, this should be handled by the core-tracing changes we are making. Keeping this open, but added to the correct epic

@joheredi  the new core-tracing APIs will have support for this as they will not depend on OTel directly. I am going to close this in favor of #19299 - is that ok with you? Feel free to reopen if you think this should be separate


Fix issue with Content-Length header being calculated incorrectly

As mentioned in #25, the Content-Length header is not calculated correctly for strings containing certain unicode characters. Here's a summary of the issue:

… the issue here is that the blockscore-node package is relying on String.length to determine the Content-Length header but the header needs to be the byte length, not string length, e.g. 'Zürich' is 7 bytes, not 6. This package should use Buffer.byteLength() instead of String.length to determine the content length header.
For example, this request fails: (note Content-Length: 345)
curl -X POST https://api.blockscore.com/candidates \
  -u "$BLOCKSCORE_API_KEY:" \
  -H 'Accept: application/vnd.blockscore+json;version=4' \
  -H 'Content-Type: application/json' \
  -H 'Content-Length: 345' \
  -d '{"birth_day":"xx","birth_month":"xx","birth_year":"xxxx","document_value":"Fxxxxxxx","document_type":"passport","name_first":"First","name_middle":"","name_last":"Last","address_street1":"Weststrasse xxx","address_city":"Zürich","address_subdivision":"ZH","address_postal_code":"xxxx","address_country_code":"CH","phone_number":"00xxxxxxxxxxxx"}'

with the response,
{
  "error": {
    "type": "invalid_request_error",
    "message": "Poorly formed JSON request body."
  }
}

while this request succeeds: (note Content-Length: 346)
curl -X POST https://api.blockscore.com/candidates \
  -u "$BLOCKSCORE_API_KEY:" \
  -H 'Accept: application/vnd.blockscore+json;version=4' \
  -H 'Content-Type: application/json' \
  -H 'Content-Length: 346' \
  -d '{"birth_day":"xx","birth_month":"xx","birth_year":"xxxx","document_value":"Fxxxxxxx","document_type":"passport","name_first":"First","name_middle":"","name_last":"Last","address_street1":"Weststrasse xxx","address_city":"Zürich","address_subdivision":"ZH","address_postal_code":"xxxx","address_country_code":"CH","phone_number":"00xxxxxxxxxxxx"}'

Closes #25.

Tests are also failing locally on master, so let me know if I need to do anything on that front.

Hey, @ezekg, thanks for the fix! Sorry for the oversight on our part (and the flaky CI).
I pulled your branch and rebased it so you wouldn't have to do anything else to get the fix in. Closing this PR and using #30 instead since I don't have access to your fork. :)


fix: non security related findings

https://github.com/zeta-chain/protocol-private/issues/189
https://github.com/zeta-chain/protocol-private/issues/183

Codecov Report
Attention: Patch coverage is 7.69231% with 24 lines in your changes missing coverage. Please review.

Project coverage is 3.37%. Comparing base (2533cc1) to head (75c76c9).

Files with missing lines
Patch %
Lines

programs/gateway/src/lib.rs
7.69%
24 Missing :warning:

Additional details and impacted files
@@           Coverage Diff            @@
##            main     #71      +/-   ##
========================================
- Coverage   5.85%   3.37%   -2.48%
========================================
  Files          1       1
  Lines        410     385      -25
========================================
- Hits          24      13      -11
+ Misses       386     372      -14

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Implement pretty inspect of sails.helpers

The current implementation of pretty printing is buggy mostly due to the breaking change in how custom inspects are implemented in newer versions of Node.js.
Spots this fix needs to be made on:

Node machine's index.js
Node machine's pack.js
sails.helpers = {}

This issue has been resolved with #7282


Catch errors accessing localStorage

It's actually possible that reading window.localStorage fails in some circumstances. Notably in Electron preload script (page is not loaded yet and localStorage is bound to the page origin and does not exist on about://blank), where it fails with Failed to read the 'localStorage' property from 'Window': Access is denied for this document.
Just moving the try/catch block up to catch this.

Coverage decreased (-1.5%) to 87.931% when pulling b317a84d94806187fe6fee67a473f261b04da1c0 on tgds:master into f663c23ac41beff094378738843584c5754cd6cf on bigpipe:master.


how to get its xyxrgb value

In scannet, the _vh_clean_2.ply is mesh file, I don't know how to get their xyzrgb attribute, can you please tell me how to get its xyzrgb value from mesh. thanks

Hi @bonbonjour , it's simple to get it.
from plyfile import PlyData, PlyElement
scene_full_3d_mesh = PlyData.read(in_raw_scans_folder+scene_name+'/'+scene_name+'_vh_clean_2.ply')
scene_full_3d_pc = np.asarray((scene_full_3d_mesh['vertex'].data).tolist(), dtype=np.float32).reshape([-1, 7])  ##  the 7 channels represent [ x-y-z-r-g-b-a]

thanks for your help！ and there is another problem, I have trouble in generating ins label, I use "python export_train_mesh_for_evaluation.py --scan_path /home/data/scannetv2/scans/scene0000_00 --output_file /home/data/scannetv2/output.txt  --label_map_file /home/data/scannetv2/scannetv2-labels.combined.tsv --type instance"  to get the ins lable, the output.txt is like this(67 lines in all):
pred_mask/output_1.txt 9 1.000000
pred_mask/output_2.txt 9 1.000000
pred_mask/output_3.txt 7 1.000000
pred_mask/output_4.txt 12 1.000000
pred_mask/output_5.txt 38 1.000000
pred_mask/output_6.txt 16 1.000000
pred_mask/output_7.txt 16 1.000000
pred_mask/output_8.txt 14 1.000000
pred_mask/output_9.txt 3 1.000000
pred_mask/output_10.txt 2 1.000000
under pred_mask folder, there are output_1.txt-- output_72.txt.
after obtaining these files, I don't know how to get the final ins label file, can you please help me

can anybody please help me?

Hi @bonbonjour , the script "export_train_mesh_for_evaluation.py" is to generate formatted results for ScanNet online evaluation.  If you want to generate the ins labels for training the network, check out the script below.
https://github.com/Yang7879/3D-BoNet/blob/master/helper_data_scannet_prepare.py

thanks very much!


[pcl] Build error

Host Environment

OS: Windows 11
Compiler: Standard windows Visual C++  compiler
install-x86-windows-rel-out.log

To Reproduce
Steps to reproduce the behavior:
./vcpkg install pcl
Failure logs
-- Building x86-windows-dbg
-- Building x86-windows-rel
CMake Error at scripts/cmake/vcpkg_execute_build_process.cmake:155 (message):
Command failed: D:/vcpkg/downloads/tools/cmake-3.21.1-windows/cmake-3.21.1-windows-i386/bin/cmake.exe --build . --config Release --target install -- -v -j9
Working Directory: D:/vcpkg/buildtrees/pcl/x86-windows-rel
See logs for more information:
D:\vcpkg\buildtrees\pcl\install-x86-windows-rel-out.log
Additional context
Tried re-installing Cmake, Visual Studio, Vcpkg

"Internal compiler error"

Maybe duplicate of: #19561

Yes, this issue is duplicate with #19561, I am closing this issue for now. Please pay attention of issue #19561.


Urchin compatible with certain pebbles?

Does urchin work on specific pebble watches or all?  Pebble time steel?

Yes, it works with Pebble Time Steel. The only watches it doesn't support are the Round series, and that is changing soon thanks to #60.


Problems with file system calls from tinygo based WASM component

I am unable to get file system calls to work from a tinygo based WASM component. All calls return "errno 76" "capabilities insufficient".
I've created a test case available at
https://github.com/rbackhouse/component-go-fs-test
The README details the prereqs and how to build and run.
This originally started as a discussion on Zulip with Pat Hickey.
https://bytecodealliance.zulipchat.com/#narrow/stream/217126-wasmtime/topic/Problem.20with.20WasiCtxBuilder.2Epush_preopened_dir.20for.20component
Additional I'm attaching a built version of the component WASM files
testfswasm.zip

Ignore I should have opened on the wasmtime repo :-(


MNT: use unordered bulk inserts

Minor change which could (?) allow parallel inserts with mongo. Indices should take care of the ordering upon insert.

Have you checked whether this is faster @klauer ?

I haven't done any significant testing with this. It probably should be investigated further prior to merging.

Does this actually make it faster?

Straight from mongo docs:
Ordered vs Unordered Operations

Bulk write operations can be either ordered or unordered.

With an ordered list of operations, MongoDB executes the operations serially. If an error occurs
during the processing of one of the write operations,
 MongoDB will return without processing any remaining write operations in the list.
With an unordered list of operations, MongoDB can execute the operations in parallel,
but this behavior is not guaranteed.
 If an error occurs during the processing of one of the write operations, MongoDB
will continue to process remaining write operations in the list.

That last line is probably why it was ordered_insert.  Does this raise on failure?

It will raise on failure. I have seen mdstore raise bulk write errors

What causes those failures?

Me getting curious and killing the server

I see.

Is insertMany function helpful?
https://docs.mongodb.com/manual/reference/method/db.collection.insertMany/#db.collection.insertMany

@arkilic why are we using the bulk object like this?  https://api.mongodb.com/python/current/examples/bulk.html#bulk-write-operations makes it look like insert_many would be simpler as it looks like the bulk objects are meant for mixed operations, but we are only doing inset.

As you might see the New in version 2.6 tag above the insert_many(), this is a new feature. Until a few weeks ago, we were maintaining a variety of mongo instance from 2.0 to 3.2.6 There are tons of new features out there, especially after the latest pymongo rewrite. We gotta keep updating as we go along

The bulk objects are new in 2.7


i18n

Summary by CodeRabbit
Release Notes

New Features

Added a "Support" section in the README.md for donations.
Introduced localization support with new language files for English, Japanese, Chinese, and French.
Added a language selection option in user settings and admin forms.
Enhanced user interface with localized strings for various templates, including pagination controls and form labels.

Bug Fixes

Updated terminology from "Deny" to "Rejected" across various templates and user roles.

Documentation

Enhanced documentation to reflect new language and support features.

Style

Improved HTML structure for better semantic meaning in templates.

Chores

Updated configuration files to support new features and localization.

@coderabbitai full review

@coderabbitai full review

@coderabbitai summary

@coderabbitai full review

@coderabbitai summary


Adjustable dates in report

First of all, thanks for a great website !
Can we change the dates on the report ?
For example, the following map has dates from Jan 21 to Mar 22, but dates from Jan 21 to Mar 03 is meaningless as there is no data, in addition the curve looks much steep,

Can user change the dates from Mar 03 to Mar 23 ?
Or does it require code changes ?
Thank you

Thanks, we are aware of this issue, but it seems the zoom function of c3.js does not work, and we have been working on it.

Ok, thanks for sharing :+1:


Create a deployment guide for security hardening

Documentation for https://github.com/zowe/security-reports/issues/245

The link to this issue is broken.

It's not, the security reports is private repository and it's possible that you don't have access.

Close with PR #2776


Issue saving non-string fields - Encrypted date test must be a value encrypted using SymmetricEncryption.encrypt

I'm evaluating this gem for a project and have set up some fields on an existing model and running tests in console on a Ruby 2.4.2/Rails 5.0.6, SE 4.0.0 system in development mode. I'm having issues saving/encrypting non-string fields. Example on date field follows.
symmetric-encryption.yml:
development:         &development_defaults
  key:<PHONE_NUMBER>ABCDEF
  iv:<PHONE_NUMBER>ABCDEF
  cipher_name:       aes-128-cbc
  encoding:          :base64strict

model:
attr_encrypted :date_test, random_iv: true, type: :date
validates :encrypted_date_test, symmetric_encryption: true

rails console:
2.4.2 (main):0 > loan = Loan.new
=> #<Loan:0x00007f02646a0578
 id: nil,
 amount: 0.0,
.
.
.
 encrypted_date_test: nil>
2.4.2 (main):0 > loan.date_test = Date.parse("Nov 11 2017")
=> Sat, 11 Nov 2017
2.4.2 (main):0 > loan.save
   (0.2ms)  BEGIN
  Validation failed  #<Loan id: nil, amount: 0.0,...,encrypted_date_test: nil>
    => Encrypted date test must be a value encrypted using SymmetricEncryption.encrypt
   (0.3ms)  ROLLBACK
=> false

I tried encrypting the return on the Date.parse method using SymmetricEncryption.encrypt and then setting loan.date to that but also failed.
String fields work fine. I'm sure I've miss-configured something. Help is much appreciated.

Sorry, I realized all encrypted fields must be of string type. Seems fairly obvious now. Comments in the mock User model here explain this.


Bug fix on Syntax error when the last line in the template is code

When code is inserted within a template, if the last line of the template is code there is a syntax error and the template is not processed.
In buildTmplFunction, when the nodes are being processed and the code string is created, if the last line of the template is code and as such it contains {{*, at the end of the code string it is added "result+=", but that variable will not have any value as there is no more code nor template items.
Checking if it is really the last line before adding the string "result+=" avoids the syntax error.
In this example, there'd be a syntax error:

Fixed in https://github.com/BorisMoore/jsrender/commit/df3e1e22a48b13aaf181ae04932467ea12f78d46. Let me know/reopen if the fix does not work for you...


reworked config to start from DL1 and add slurm options to better man…

Hi @abhishekabhi063
I remade the config to use the DL1ab step, no need to restart from R0 here.
I also added a few options that will smooth things regarding cluster usage.
Fixes #482

The production has been scheduled ⏳
(but be aware the cluster is very much used so it could take ~1 week)

Hi @abhishekabhi063
The production is done under ID 20240906_v0.10.9_GC_dec_min_2924_tuned.

Thank you


Failing to release due to v4.16 index image

Trying to release something with:
  com.redhat.openshift.versions: "v4.15"

(see https://github.com/redhat-openshift-ecosystem/community-operators-prod/pull/4138 ) for instance,
is  currently failing to to the lack of permissions on the v4.16 index image.
see:
[get-supported-versions : supported-version-check] {
[get-supported-versions : supported-version-check]   "versions_annotation": "v4.15",
[get-supported-versions : supported-version-check]   "indices": [
[get-supported-versions : supported-version-check]     {
[get-supported-versions : supported-version-check]       "end_of_life": "2028-07-21T08:40:42.484000+00:00",
[get-supported-versions : supported-version-check]       "ocp_version": "4.16",
[get-supported-versions : supported-version-check]       "path": "registry.redhat.io/redhat/community-operator-index:v4.16"
[get-supported-versions : supported-version-check]     },
[get-supported-versions : supported-version-check]     {
[get-supported-versions : supported-version-check]       "ocp_version": "4.15",
[get-supported-versions : supported-version-check]       "path": "registry.redhat.io/redhat/community-operator-index:v4.15"
[get-supported-versions : supported-version-check]     }
[get-supported-versions : supported-version-check]   ],
[get-supported-versions : supported-version-check]   "max_version_index": {
[get-supported-versions : supported-version-check]     "end_of_life": "2028-07-21T08:40:42.484000+00:00",
[get-supported-versions : supported-version-check]     "ocp_version": "4.16",
[get-supported-versions : supported-version-check]     "path": "registry.redhat.io/redhat/community-operator-index:v4.16"
[get-supported-versions : supported-version-check]   },
....

and:
[add-bundle-to-index : add-bundle-to-index] + ENV=prod
[add-bundle-to-index : add-bundle-to-index] + INDEX_IMAGES=registry.redhat.io/redhat/community-operator-index:v4.16
[add-bundle-to-index : add-bundle-to-index] + [[ prod == \d\e\v ]]
[add-bundle-to-index : add-bundle-to-index] + [[ prod == \q\a ]]
[add-bundle-to-index : add-bundle-to-index] + [[ prod != \p\r\o\d ]]
[add-bundle-to-index : add-bundle-to-index] + EXTRA_ARGS=
[add-bundle-to-index : add-bundle-to-index] + [[ true == \t\r\u\e ]]
[add-bundle-to-index : add-bundle-to-index] + EXTRA_ARGS+=' --authfile /workspace/credentials/.dockerconfigjson'
[add-bundle-to-index : add-bundle-to-index] + [[ -8fa00b39fb75a9629865fc67b1ee462601c52927 != '' ]]
[add-bundle-to-index : add-bundle-to-index] + EXTRA_ARGS+=' --index-image-destination-tag-suffix=-8fa00b39fb75a9629865fc67b1ee462601c52927'
[add-bundle-to-index : add-bundle-to-index] + [[ semver != '' ]]
[add-bundle-to-index : add-bundle-to-index] + EXTRA_ARGS+=' --mode semver'
[add-bundle-to-index : add-bundle-to-index] + index --iib-url https://iib.engineering.redhat.com --indices registry.redhat.io/redhat/community-operator-index:v4.16 --bundle-pullspec quay.io/community-operator-pipeline-prod/community-kubevirt-hyperconverged:1.11.0-8fa00b39fb75a9629865fc67b1ee462601c52927 --index-image-destination quay.io/community-operator-pipeline-prod/catalog --image-output index-image-paths.txt --authfile /workspace/credentials/.dockerconfigjson --index-image-destination-tag-suffix=-8fa00b39fb75a9629865fc67b1ee462601c52927 --mode semver
[add-bundle-to-index : add-bundle-to-index] 2024-03-06 15:35:10,562 [operator-cert] ERROR IIB POST query failed with https://iib.engineering.redhat.com/api/v1/builds/add-rm-batch - 403 - {"error":"\"graph_update_mode\" can only be used on the following index image: ['registry.stage.redhat.io/redhat/community-operator-index:v4.10', 'registry.stage.redhat.io/redhat/community-operator-index:v4.11', 'registry.stage.redhat.io/redhat/community-operator-index:v4.12', 'registry.stage.redhat.io/redhat/community-operator-index:v4.13', 'registry.stage.redhat.io/redhat/community-operator-index:v4.14', 'registry.stage.redhat.io/redhat/community-operator-index:v4.15', 'registry.redhat.io/redhat/community-operator-index:v4.10', 'registry.redhat.io/redhat/community-operator-index:v4.11', 'registry.redhat.io/redhat/community-operator-index:v4.12', 'registry.redhat.io/redhat/community-operator-index:v4.13', 'registry.redhat.io/redhat/community-operator-index:v4.14', 'registry.redhat.io/redhat/community-operator-index:v4.15', 'registry-proxy-stage.engineering.redhat.com/rh-osbs-stage/iib-qe:empty-iib-pub-pending-v4.9', 'registry-proxy-stage.engineering.redhat.com/rh-osbs-stage/iib-qe:empty-iib-pub-pending-v4.14']"}
[add-bundle-to-index : add-bundle-to-index] Traceback (most recent call last):
[add-bundle-to-index : add-bundle-to-index]   File "/home/user/.venv/lib/python3.11/site-packages/operatorcert/iib.py", line 51, in add_builds
[add-bundle-to-index : add-bundle-to-index]     resp.raise_for_status()
[add-bundle-to-index : add-bundle-to-index]   File "/home/user/.venv/lib/python3.11/site-packages/requests/models.py", line 1021, in raise_for_status
[add-bundle-to-index : add-bundle-to-index]     raise HTTPError(http_error_msg, response=self)
[add-bundle-to-index : add-bundle-to-index] requests.exceptions.HTTPError: 403 Client Error: FORBIDDEN for url: https://iib.engineering.redhat.com/api/v1/builds/add-rm-batch
[add-bundle-to-index : add-bundle-to-index] Traceback (most recent call last):
[add-bundle-to-index : add-bundle-to-index]   File "/home/user/.venv/bin/index", line 8, in <module>
[add-bundle-to-index : add-bundle-to-index]     sys.exit(main())
[add-bundle-to-index : add-bundle-to-index]              ^^^^^^
[add-bundle-to-index : add-bundle-to-index]   File "/home/user/.venv/lib/python3.11/site-packages/operatorcert/entrypoints/index.py", line 234, in main
[add-bundle-to-index : add-bundle-to-index]     iib_response = add_bundle_to_index(
[add-bundle-to-index : add-bundle-to-index]                    ^^^^^^^^^^^^^^^^^^^^
[add-bundle-to-index : add-bundle-to-index]   File "/home/user/.venv/lib/python3.11/site-packages/operatorcert/entrypoints/index.py", line 153, in add_bundle_to_index
[add-bundle-to-index : add-bundle-to-index]     resp = iib.add_builds(iib_url, payload)
[add-bundle-to-index : add-bundle-to-index]            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[add-bundle-to-index : add-bundle-to-index]   File "/home/user/.venv/lib/python3.11/site-packages/operatorcert/iib.py", line 51, in add_builds
[add-bundle-to-index : add-bundle-to-index]     resp.raise_for_status()
[add-bundle-to-index : add-bundle-to-index]   File "/home/user/.venv/lib/python3.11/site-packages/requests/models.py", line 1021, in raise_for_status
[add-bundle-to-index : add-bundle-to-index]     raise HTTPError(http_error_msg, response=self)
[add-bundle-to-index : add-bundle-to-index] requests.exceptions.HTTPError: 403 Client Error: FORBIDDEN for url: https://iib.engineering.redhat.com/api/v1/builds/add-rm-batch

in https://gist.github.com/rh-operator-bundle-bot/487ec129fa4bef61916b5b04c465eb18

Many operators are now impaceted: #4148 , #4147 , #4137 ...

Hey @tiraboschi thank you for reporting the issue. We are aware of this issue and we are working on a fix now. The fix should be ready in a couple of minutes. After that, I am going to restart the failed pipelines.

All failed PRs affected by the 4.16 issue have been fixed. You you still see some PRs feel free to reopen this issue.


fix(material/tabs): ensure the ink bar realigns when the tab header changes dimensions

This should fix #6130. It uses ResizeObserver to ensure we get notifications about the dimensions of the tabs when they change. The layout change will fire synchronously.

So the change LGTM, but for some reason the CI didn't run. Can you try cherry-picking the commit to a new branch and opening another PR?

The CI system says it's missing some labels. Do I need to add some labels on the new PR? Or this one perhaps?

The label checks are separate. Usually it queues up another 11 jobs that don't show up here for some reason. This has happened for other people and CircleCI haven't been able to figure out why. There was a theory that it might be because you aren't watching the fork that you're opening the PR from.

Opened https://github.com/angular/components/pull/24932. I'll adjust the description etc if the CI runs.

(It also tells me that the CI workflow is pending approval and links me to https://docs.github.com/en/actions/managing-workflow-runs/approving-workflow-runs-from-public-forks -- claiming a maintainer has to approve my CI run on this PR)

Did you try clicking the "Watch" button on your fork? Also the "Approve and run" button is only for deploying the dev app, it doesn't affect any of the other checks. You can check what other PRs look like, e.g. https://github.com/angular/components/pull/24931

I swapped the watch to "All Activity" just now.

Then I really don't know why it didn't run 😕. Anyway, I ran it locally and the only problem is this lint failure:
src/material/tabs/paginated-tab-header.ts:258:3
ERROR: 258:3  jsdoc-format  jsdoc is not formatted correctly on this line

I tried fix it locally. Want me to run something else? Should I abandon https://github.com/angular/components/pull/24932?

Yeah, you can abandon the other one.


[Client/Server] Invalid data from the server

Description
If JSON parsing fails on the server side, the request id etc. are not valid data from client.

How to reproduce this bugs ?

@anttijuu can you help me with this one please?

Yes I can. So when you look at the server code, at line 52 onwards:
		JSONObject root = (JSONObject) new JSONParser().parse(receivedData);

		id = ((Long) root.get("id")).longValue(); // id of the operation, for async operations.
		operation = (String) root.get("operation"); // request/response

If the parse() call fails, id and operation is never extracted from the client request. That means, when creating the response to the client...:
} catch (ParseException e) {
	e.printStackTrace();
	response = createResponse(operation, id, new EasyCryptoAPI.Result(EasyCryptoAPI.ResultCode.EError, e.getLocalizedMessage()));

...the id and operation parameters are null. Thus, the client can not see from the response, which of the requests it sent failed. Client could send several requests quickly and they could be executed by the server in different order, and different requests might take different time to fulfil. So client cannot be sure that responses are received in the same order than the requests were sent.
This can be tricky to solve, since if parse fails, it means the JSON is not valid for some reason. The JSON data from client might contain the request id, but maybe it doesn't even have that.
You could try to investigate the string and look for the id without using the JSON parser to extract the request id in this case. Or return some more informative response to the client, telling it that the JSON it sent was garbage and the client probably has a bug and/or the data was corrupted during transmission from client to the server. Or something.


It's simple feature, not sure if already exist,

Is this a bug report or a feature request?
It's a question as start.

Have you read the guidelines regarding bug report?
Link not working
Have you read the documentation in its entirety?
yes
Have you made sure that your issue hasn't already been reported/solved?
almost
Is the bug specific to iOS or Android? Or can it be reproduced on both platforms?
(Write your answer here and specify the iOS/Android versions on which you've been able to reproduce the issue.)
Is the bug reproductible in a production environment (not a debug one)?
(Write your answer here.)

Have you been able to reproduce the bug in the provided example?
(Write your answer here.)

Environment

(Write your answer here.)
Steps to Reproduce

(Write your steps here:)

Expected Behavior

(Write what you thought would happen.)
Actual Behavior

(Write what happened. Add screencasts/screenshots!)
Reproducible Demo

(Paste the link to an example project or paste the entirety of the relevant source code. Then provide instructions to reproduce the issue.)

Hi @Jaafar-abusair,
I don't see any question in your post; have I overlooked something?

I'm sure I wrote it somewhere, but i can't find it here anymore,
Any way, What I was asking about, you have activeSlideAlignment: 'start', 'center', 'end' and it's working as expected, What I'm asking for is to have all items as 'start' except the last item as 'end', so in this way I will not have a white margin at the end

Unfortunately, it is not possible at the moment.
If you want more info about the issues at stake, you can read #102, and particularly this comment as well as this one.


Speed up the travis build

With the addition of more unit and integration tests and new store implementations, currently Travis takes approximately 35 minutes to build the project. As this will increase over time (as new features are added), any efforts to reduce the running time of the tests (for example, by using the build matrix to run the unit tests and integration tests separately or by running tests for each store in parallel) would be of benefit.

I've split out the unit tests, integration tests and code analysis into separate builds so they can be run in parallel on different travis VMs. We should monitor the builds and check whether we need to split them out further.

I've split out the code base into separate sections so they can be run in parallel on different travis VMs. We should monitor the builds and check whether we need to split them out further. Currently:

code analysis of whole code base
test everything except hbase and accumulo
test accumulo
test hbase

Closing this for now as the build seems to be ok.


Bug: When running npm run format:fix it fails

When I run npm run format:fix I get the following error.
$ npm run format:fix

><EMAIL_ADDRESS>format:fix machinelabs\client
> npm run format:base -- --write

><EMAIL_ADDRESS>format:base machinelabs\client
> npm run prettier -- '{src,e2e}/**/*{.ts,.js,.json,.css,.scss}' "--write"

><EMAIL_ADDRESS>prettier machinelabs\client
> prettier --config ../.prettierrc --ignore-path ../.prettierignore "'{src,e2e}/**/*{.ts,.js,.json,.css,.scss}'" "--write"

[error] No matching files. Patterns tried: '{src,e2e}/**/*{.ts,.js,.json,.css,.scss}' !**/node_modules/** !./node_modules/**
npm ERR! code ELIFECYCLE

This is already discussed via gitter with @PascalPrecht. His initial thoughts:

I fear this has to do with the globbing patterns. They are prolly not supported on windows as they use \ instead of /

Is there anything else we should know?
Please execute the following commands in your terminal and post the output here
OS: Windows
Node: v9.11.1
Yarn: 1.6.0

@d3lm can you look into this please?

Will take a look. My bet is the glob too, as @PascalPrecht already mentioned. I'll have a look on how to make this work on both operating systems.

Thanks if you want me to reproduce things let me know.

@d3lm what's the status of this?

Instead of the single quotes around the globs, can you try double quotes?
'{src,e2e}/**/*{.ts,.js,.json,.css,.scss}'
->
"{src,e2e}/**/*{.ts,.js,.json,.css,.scss}"
Escape the double quotes in the npm script. I don't have a Windows machine so can't test if this works.

Hi @SamVerschueren just checked this one my machine and changing it resolves the issue.
I changed it to: "format:base": "npm run prettier -- \"{src,e2e}/**/*{.ts,.js,.json,.css,.scss}\""
If this also works on a other OS (not windows) I can make the PR for it?

I believe it does as it's in the docs of Prettier, feel free to make the PR and I'll verify it afterwards.

You rock! Thanks for pushing this forward.


Bottom side rotates still not quite right

Inverting around 360 degrees looked fine for angles, even 45 degrees and 10 degrees and so on, but turns out it actually needs inverting around 180 degrees else your diodes are all backwards. Arrrg. Sorry about that.
Screen shots of some diodes, all done with no JLCPCB Rotation Offset set, comparing view on JLCPCB with 3D view from KiCad.

Nice catch, Tnx.


make raw.plot() behave under MPL 3.4.x

closes #8955
I'd rather figure out why this problem arose, but the allure of a fairly inexpensive one-line fix was too seductive... we'll see if it slips past the code-quality censors :)

Weird, but if it works why not!

thx @drammock


Why「ppo_trainer.generate 」report the following error？ Please help.

response_tensors = ppo_trainer.generate(         question_tensors,         return_prompt=False,         length_sampler=output_length_sampler,         **generation_kwargs,     )

Hi @xuyingjie521
You are probably using some input ids that are out of the vocabulary, what model are you using and which tokenizer are you using?

Hmm, can you try to run the same script on CPU? Usually the error traces are much better if you re-run the same script on CPU when getting CUDA device side assert errors

Hmm, can you try to run the same script on CPU? Usually the error traces are much better if you re-run the same script on CPU when getting CUDA device side assert errors

I haven't tried it yet. Have you run the rl_trianing.py script, what model do you use, can it run on the GPU? How is the effect?


create big cannons causes forge to fail sorting mods

latest.log

known issue will be fixed next update


Top level end-to-end performance infra checklist

Baseline perf:

Use "performance" cpu freq governor: https://github.com/tenstorrent/tt-metal/issues/5281

at the minimum on perf regression machines & developer BMs, but if we ran it on all CI it may speed up all pipelines

Fix Release build on CI: https://github.com/tenstorrent/tt-metal/issues/4255
Pick optimal compiler (GCC vs Clang): https://github.com/tenstorrent/tt-metal/issues/8460

Improving python -> C++ interface:

Upgrade to Python 11: https://github.com/tenstorrent/tt-metal/issues/7451
#4258

CC: @TT-billteng @davorchap @tt-rkim

closing as I own the remaining issue


Beta eqMac crash at startup

On my Mac Book Pro with Catalina (10.15.2), eqMac (Beta) keeps crashing with the following error whe I try to start it:
 Fatal error: Unable to bridge NSNumber to Bool: file /BuildRoot/Library/Caches/com.apple.xbs/Sources/swiftlang_overlay_Foundation/swiftlang-1100.8.280/swift/stdlib/public/Darwin/Foundation/NSNumber.swift, line 571
BTW: The Slack invitation link mentioned in the Issue panel is out of date.

Hey everyone 👋
I will be open sourcing the new version of eqMac, therefore, I am closing this issue and repository as I will be transfering nodeful/eqMac2 repo to bitgapp/eqMac
Please bear with me for the next couple of days as I setup that new repo. The eqMac2 code will be living in the old-eqMac2 branch if anyone is interested in referencing it for whatever reason.
Please try out the new version and report bugs to the new repo.
Thanks for using eqMac.

This error should have been fixed a couple weeks ago with the v0.0.1 update


KryptonMessageBox missing in Visual Studio Toolbox

I have installed Krypton Suite successfully in Visual Studio 2017. However the KryptonMessageBox is missing in the Toolbox. Why?

It's not a designer or designerable element.
As it is expected (Like a normal MessageBox) to be called directly from code.

Thank you, I understand and I found how to do it now. You have to Import ComponentFactory.Krypton.Toolkit first, otherwise KryptonMessageBox cannot be called (not showing in the list).

Dear Smurf-IV, one more question: where and how can i change the Global Palette for the shown Krypton Messagebox?

Simple put: It uses the "Application Palette"
If you want to roll your own palette just for the KryptonMessageBox, then copy the code elements you need and create your own MyKryptonMessageBoxForm with a palette assigned to it.

Thank you, but I'm a newbie.
I just don't know where I have to copy the needed code elements and which code elements to create my own KryptonMessageBoxForm.
I'm afraid also I have to add a new Class or Component to the project?
I don't know if you can help me further?

What are you trying to do with the KMB to make it independent of the "Used" Palette ?
Could the things you are trying to do be covered by the extensions requests covered here:
https://github.com/Wagnerp/Krypton-Toolkit-Suite-Extended-NET-4.7/issues

I just want to apply another Palette for my KMB. The "Global Palette" is set to Sparkle-Blue, but I don't like that Palette for my KMB. I'm preferring Professional-Office 2003 Palette for the KryptonMessageBox. There should be an easy way to change the Palette for the KMB just as it exists for controls.
By the way I tried to create a custom 'Krypton MessageBox Form',  by adding a new Krypton Form, but I noticed that I cannot find the Krypton Form in the Visual Studio (2017) ToolBox nor in the Menu "Add Windows Form", "Add New Item", etc. Where do I find the Krypton Form?

If you are wanting to stick the "ComponentFactory" then you will have to manually change it in code;
Otherwise switch to the "WagnerP" Toolkit and Extensions and it has the Form in the Designer and the code is maintained / updated / fixed as we find issues with Win10 and other incompatibilities.

@Smurf-IV & @redseujac
Thanks for mentioning the extended toolkit. As @Smurf-IV mentioned, I have started developing a Krypton MessageBox using a Form with a designer, which will be re-sizeable, and will offer greater customisation over the original, however it's not completed yet. If you want to contribute & use this project in your own projects, then that would be great!

OK, but how to install this Extended Tookit? I downloaded and extracted. Beyond the (new?) Krypton Suite DLL's I don't find any DLL for that extended toolkit, such as the "KryptonExtendedToolkit.dll". Is it so that have to open/load the .sln from the source folder in Visual Studio and then Build the solution or Start Debugging to create the DLL? Now in the extracted files from the website the BIN folder is empty.

You will need to reference the binaries from Krypton-NET-4.7 and restore the Nuget package 'Windows API CodePack' in order for it to build successfully. It's not just one DLL.


terminal warning actions cannot be selected if only one terminal is open

Testing #21102
with settings
  "python.terminal.activateEnvInCurrentTerminal": true,
  "python.terminal.activateEnvironment": true,

activate the python extension and select an interpreter.
open a single terminal, python environment gets activated
change the active interpreter
:bug: a warning shows but I can't get to the actions unless I open a second terminal

also you can tell that I struggled a bit to actually click the actions in the dialog :/

Thanks for the feedback, this is actually dup of https://github.com/microsoft/vscode/issues/180739.


findComponent functions return undefined

Subject of the issue
when I user wrapper.findComponent({ref: 'input'}) in two it functions, the second wrapper.findComponent({ref: 'input'}) return undefined

Hi! Would you mind adding an example of the component and the failing test?

Hi! Would you mind adding an example of the component and the failing test?

Hi! Would you mind adding an example of the component and the failing test?

I've solved it, mainly because the component's if condition is false, thanks!


Build scripts try to set EXEC_OUTPUT_PATH and LIB_OUTPUT_PATH

From robotiq_s_model_control/CMakeLists.txt fi:
#set the default path for built executables to the "bin" directory
set(EXECUTABLE_OUTPUT_PATH ${PROJECT_SOURCE_DIR}/bin)
#set the default path for built libraries to the "lib" directory
set(LIBRARY_OUTPUT_PATH ${PROJECT_SOURCE_DIR}/lib)

Afaik, this is not supported anymore in catkin. I think it is even 'illegal'.

Closing this issue as these lines are not in the CMakeLists.txt anymore.


[Migrated] Fix when no expressions or keep_warm is false

Originally from: https://github.com/Miserlou/Zappa/issues/2185 by manycoding
When I set keep_warm_expression it fails with
    events=events
  File "/Users/valery/.local/share/virtualenvs/document_data_extract_zappa-j8vc3Vbe/lib/python3.6/site-packages/zappa/core.py", line 2783, in schedule_events
    print("Could not create event {} - Please define either an expression or an event source".format(name))
UnboundLocalError: local variable 'name' referenced before assignment

So I fixed it.

Description

GitHub Issues

Looks like related code has been updated, considered fixed.
closing.


Add npm package

Is it possible to add npm package so we can use it node.js ?

$ npm install lunr

I've added this to the README now.


panic: send on closed channel in github.com/pion/ice.(*Agent).updateConnectionState

panic: send on closed channel

goroutine 2270100 [running]:
github.com/pion/ice.(*Agent).updateConnectionState(...)
        /root/go/pkg/mod/github.com/pion/ice@v0.7.13/agent.go:642
github.com/pion/ice.(*controlledSelector).ContactCandidates(0xc001e74ba0)
        /root/go/pkg/mod/github.com/pion/ice@v0.7.13/selection.go:214 +0x21c
github.com/pion/ice.(*Agent).startConnectivityChecks.func<IP_ADDRESS>(0xc000f2e000)
        /root/go/pkg/mod/github.com/pion/ice@v0.7.13/agent.go:615 +0x3a
github.com/pion/ice.(*Agent).run(0xc000f2e000, 0xe4d648, 0x0, 0x0)
        /root/go/pkg/mod/github.com/pion/ice@v0.7.13/agent.go:194 +0xfd
github.com/pion/ice.(*Agent).startConnectivityChecks.func1.1.1()
        /root/go/pkg/mod/github.com/pion/ice@v0.7.13/agent.go:614 +0x3f
github.com/pion/ice.(*Agent).startConnectivityChecks.func1.1(0xc000f2e000)
        /root/go/pkg/mod/github.com/pion/ice@v0.7.13/agent.go:626 +0x110
created by github.com/pion/ice.(*Agent).startConnectivityChecks.func1
        /root/go/pkg/mod/github.com/pion/ice@v0.7.13/agent.go:612 +0x186

I'm running a very active instance of https://github.com/anacrolix/confluence, which makes frequent and implicit use of several webtorrent trackers. There's probably 100s or 1000s of webrtc PeerConnections being opened and closed, so unless I'm using the API incorrectly, this is probably a very elusive race condition in pion code somewhere.

seems caused by ContactCandidates() called after Agent.Close()

@anacrolix I think #183 will fix this.

Thanks!


Component tree navigation with arrow keys not working

Version
6.0.0-beta.9
Browser and OS info
Edge 90 / Windows 10
Steps to reproduce
Looks like the arrow navigation in the component tree is not (yet?) implemented in the new v6 version.
What is expected?
Arrow keys to work for component navigation (with left & right for collapse & expand, and up & down for up & down). See also #665/#638/#283.
What is actually happening?
The arrow keys don't do anything...

Yup, it's not implemented yet.


Port fix

Fixed the fact that the proxy port was registered to proxy instead of the ide port.
Implemented random ide port if no specific port is set (or zero).

If you think this is ok, could you merge it to your master and let's ping felixbecker again? I'd really like this to land in the official plugin.

From a quick gander, it appears that these changes would require an update or two to the corresponding tests. @zobo @towhidabsar  thoughts?

I did some small updates to tests so that they should still work, but did not introduce any new ones. Will look at it, but as the upstream author isn't reponding much...

Sorry didn't get a chance to look into it. I will take a look at it and put in my feedback by end of day tomorrow. Thanks for the patience.

Looked at it again, and not really sure what extra tests you had in mind. The dynamic port can hardly be tested, as it's not even exported back out of class. If you have a specific wish let me know and I'll try to work on it.


MissionController2 to GitHub

@malkuth1974 once this is merged the current release and future releases of your mod will automatically be indexed (provided they're not marked as "pre-release").

LGTM. Merging with thanks!


[bug]: Generated form controller missing form listener

Describe the bug
See "To reproduce" section.
To reproduce

follow the mini-tutorial here: https://stacked.filledstacks.com/docs/getting-started/form-basics
observe that key pressed are not registering with the controller

Expected behavior
No response
Screenshots
No response
Additional Context
Stacked stack:
stacked: ^3.2.0
stacked_services: ^1.0.0
stacked_generator: 1.0.0
It seems that   void listenToFormUpdated(FormViewModel model) was deprecated in 3.2.0 but it's successor void syncFormWithViewModel(FormViewModel model) never  found its way to the new version.
If possible, please consider modifying your bug reports to require the version submitted against. Case in point: this must have worked in v. 3.1.0 :)

A material omission: stacked_cli: 1.5.1

Hi @vladchuk I don't quite know what the problem is since there's no problem statement.
What is not working? What were you expecting to happen instead of what is happening?

Hm... I thought there was enough information. I'll try again: form input/edit events are not being listened to and, therefore, no form processing (reversing) or validation is happening. Hacking the following (not sure it's the correct fix) fixes it:

@override
  TextReverseViewModel viewModelBuilder(
    BuildContext context,
  ) {
    var m = TextReverseViewModel();
    syncFormWithViewModel(m);
    return m;
  }

That's not a great fix. It is working fine our side when we call syncFormWithViewModel in the onViewModelReady override. Can you create a project with stacked_cli that reproduces the issue. I can take a look at it and see if we broke something in a recent release.


Reorganize MAC generation functions

We have more than one function doing the same thing

Signed-off-by: Alessandro Boch<EMAIL_ADDRESS>

LGTM


Measure relative to fetchStart?

My application is behind authentication which is handled via redirects to another domain outside my control. I've implemented logging of navigation and paint timing metrics recently and noticed the redirect time introduces significant variance in the data (depending on if a redirect for auth was needed or not).
Looking at the Navigation timing model, it also seems inappropriate to include unload time from the previous site because that is out of my app's control.
Based on this I adjusted our perf measurements to be relative to the fetchStart instead of startTime.
I wanted to get your team's input - does this seem like a reasonable thing to do for performance metrics? or am I missing some value here?
Maybe this could be added as an option to this lib.

The getTTFB() documentation addresses this issue and shows an example of how to measure things related to navigation timing—in addition to TTFB. Does that address your concern?
My recommendation would be to track TTFB (as defined here), but then also track additional metrics that you might have more control over fixing.

Thanks, it's helpful to see there's some precedent to adjust these measurements relative to different points in the navigation timing.
I'd want to shift values for all metrics that are measured from navigation start time (LCP, TTFB, FCP) so without support for offsets in the library I think the cleanest way would be to get the navigation timing data manually for use in the report handlers. (Using the nav timings from TTFB in other metrics seems error prone because of potential race conditions)

Ciao @deasems
do the redirects in your app also influence FCP and LCP?
I ask because if it is, this would be something interesting to report also with the W3C Performance Timeline Committee

@Zizzamia My understanding is that paint timings intentionally do include the the redirect time (just like the navigation timings do) because their 'time origin' is the navigation startTime

Yes, the web APIs all measure relative to the time origin, which includes unload, DNS, connection, etc.

Unless you think this pattern is viable? not sure if some of these metrics would get missed by waiting for TTFB to fire first.
getTTFB(metric => {
  const timingOffset = metric.entries[0].fetchStart;
  getFCP(fcp => {
    log(fcp.value - timingOffset);
  });
  getLCP(...)
  ...
});

That would work, though I'd strongly encourage you to at minimum track both versions of the metric, or track them separately so you could do the math on the back end but still report both values.
I'd also encourage you to call the metrics by a different name of you're going to change their definition. Otherwise it could lead to confusion if you were going to compare those scores to the scores reported by other Google tools (and keep in mind that within Chrome, these values are always measured relative to the time origin).

I'm going to close this issue as I don't think there's any additional changes that need to be made in the library or docs. Please let me know if I've missed something though, and I can reopen.

Thanks for the guidance @philipwalton


Rustup

@bors r+

:pushpin: Commit 4313ef3da083d566907840c5ff8d7e1f278a5d94 has been approved by RalfJung
It is now in the queue for this repository.

:hourglass: Testing commit 4313ef3da083d566907840c5ff8d7e1f278a5d94 with merge 42fbb708ad59cf60c533708d9c473a47c8366c53...

:sunny: Test successful - checks-actions
Approved by: RalfJung
Pushing 42fbb708ad59cf60c533708d9c473a47c8366c53 to master...


added more Keywords

added all missind Keywords I could find in Prelude.carbon

@Zockedidock Thank you! Could you share the link of Prelude.carbon?

Yes, it's in the carbon-lang repository: click


Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.9.0

执行命令peer lifecycle chaincode install hyperledger-fabric-contract-java-demo.tar.gz
报错如下：
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.9.0:compile (default-compile) on project hyperledger-fabric-contract-java-demo: Fatal error compiling: java.lang.NoSuchFieldError: Class com.sun.tools.javac.tree.JCTree$JCImport does not have member field 'com.sun.tools.javac.tree.JCTree qualid' -> [Help 1]
[ERROR]
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR]
[ERROR] For more information about the errors and possible solutions, please read the following articles:
[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoExecutionException
尝试了JDK8 JDK11 JDK17 然后均无法编译成功

This does not look like any of the samples from this repository. You should report an issue to the owner of the hyperledger-fabric-contract-java-demo smart contract.


Add galera based podified job

It is a new scenario job to test podified control plane with 3 galera replicas.
The same will run against install_yamls repo.
Depends-On: https://github.com/openstack-k8s-operators/ci-framework/pull/373
As a pull request owner and reviewers, I checked that:

[x] Appropriate testing is done and actually running

/approve
Note that #373 has an alignment issue.

recheck

recheck

recheck

recheck

recheck

/lgtm
I was wondering if we should add more scenarios(like this) in periodic and keep the check light.


New version: DiffEqProblemLibrary v4.6.0

Registering package: DiffEqProblemLibrary
Repository: https://github.com/JuliaDiffEq/DiffEqProblemLibrary.jl
Created by: @ChrisRackauckas
Version: v4.6.0
Commit: b5a7a3f298ca6922c182ff26df1b806d4a52f791
Reviewed by: @ChrisRackauckas
Reference: https://github.com/JuliaDiffEq/DiffEqProblemLibrary.jl/issues/47#issuecomment-559935039

@DilumAluthge check the manual commit for fixing the last version issue.


IResolvedUrl equivalent to IFluidResolvedUrl

Description
In @fluidframework/driver-definitions IResolvedUrlBase and IWebResolvedUrl have now been removed.
This makes IResolvedUrl and IFluidResolvedUrl equivalent. Since all ResolvedUrls are now FluidResolvedUrls we no longer need to differentiate them. In @fluidframework/driver-utils isFluidResolvedUrl and
ensureFluidResolvedUrl have been removed due to this.
related #14589

in addition to cleaning up some unused typing, it also gets use some bytes back

@anthony-murphy Can I add a change set before you merge?

@anthony-murphy Can I add a change set before you merge?

seems fine to me, but not sure what i need to do? just notify you before merge?

@tylerbutler this is ready for a changeset. you can merge when you've done the needful.


Data for Osaka is missing

The data has shown Osaka at zero for the last few days. I'm fairly sure this is incorrect.

Thanks for the report. We have been struggling with the lower case numbers where corrections to past numbers haven't been applied (prefecture corrects older reported numbers) or that the numbers between agencies that we get info from don't match.
I've done a pass over the numbers last night and it should now be accurate. Will monitor this in the next few days to see if it still goes wrong.


Cannot create a list of objects

Hello,
I have a piece of code where I need to create a list of empty objects with the keys from -8 to 8 and values for these keys needs to be {value: i} objects. For the most part, the code works fine until suddenly the edge browser stops the creation of the object lists.
Normally the object always has keys from -8, -7, -6 .... 0 .... +6, +7, +8 with corresponding objects.
But after the (kind of) crash the map only has 1 key as 8 with corresponding value.
I suspect it is a bug in the Chakra Engine. See picture below:

Please keep in consideration that this happens only in case of extremely fast execution scenarios like dragging an object for continuous calculations.

@ravisharma1987 thanks for the report! That's a weird issue and I find it hard to repro... @LouisLaf maybe someone on the JIT team can look into it a bit?

@liminzhu Hi, So finally I figured it out myself. The chakra-engine is not crashing if I keep the for loop index always positive. So It seems to me that the problem only happens when I have a for loop with negative indices.

@ravisharma1987 I am unable to repro locally with the snippet of code above with SnapDistance == 8.
Can you provide a small repro that will demonstrate the problem.
Also what version of Edge are you using?

@ravisharma1987, we can't make progress on this without a repro.  Please let us know if you're unable to provide one.  Thanks.

Closing for now, since bug isn't actionable without a repro. Please reopen if this is still an issue/you can provide a repro.


Unreal 5.1 Support

Unreal 5.1 was released on November 15, 2022, release notes: https://www.unrealengine.com/en-US/blog/unreal-engine-5-1-is-now-available

Yep thanks I am aware. It should already work in 5.1 but will port the examples this weekend hopefully.

LogPluginManager: Mounting Project plugin RustPlugin
LogTemp: Warning: Unable to copy File from C:/Users/FengWeiyi/Documents/Unreal Projects/Spark/Binaries/rustplugin.dll to C:/Users/FengWeiyi/Documents/Unreal Projects/Spark/Binaries/rustplugin.dll-1675103967
LogClass: Error: UInt64Property FEntity::Id is not initialized properly. Module:RustPlugin File:Public/EntityComponent.h
LogClass: Error: IntProperty FRustProperty::Tag is not initialized properly. Module:RustPlugin File:Public/RustProperty.h
LogClass: Error: FloatProperty FRustProperty::Float is not initialized properly. Module:RustPlugin File:Public/RustProperty.h
LogClass: Error: BoolProperty FRustProperty::Bool is not initialized properly. Module:RustPlugin File:Public/RustProperty.h
LogClass: Error: StructProperty FRustProperty::Vector is not initialized properly. Module:RustPlugin File:Public/RustProperty.h
LogClass: Error: StructProperty FRustProperty::Rotation is not initialized properly. Module:RustPlugin File:Public/RustProperty.h
LogAutomationTest: Error: LogClass: UInt64Property FEntity::Id is not initialized properly. Module:RustPlugin File:Public/EntityComponent.h
LogAutomationTest: Error: LogClass: IntProperty FRustProperty::Tag is not initialized properly. Module:RustPlugin File:Public/RustProperty.h
LogAutomationTest: Error: LogClass: FloatProperty FRustProperty::Float is not initialized properly. Module:RustPlugin File:Public/RustProperty.h
LogAutomationTest: Error: LogClass: BoolProperty FRustProperty::Bool is not initialized properly. Module:RustPlugin File:Public/RustProperty.h
LogAutomationTest: Error: LogClass: StructProperty FRustProperty::Vector is not initialized properly. Module:RustPlugin File:Public/RustProperty.h
LogAutomationTest: Error: LogClass: StructProperty FRustProperty::Rotation is not initialized properly. Module:RustPlugin File:Public/RustProperty.h


fix: use the creds in config.json when publishing images

I think this should have a flag involved if you want wanting to use this script from your own system. I don't think we should merge this as is.

This was based on the current master failures of:
./.ci/publish-tags.sh: line 30: DOCKERHUB_USERNAME: unbound variable

I took a look at the other scripts in the .ci folder and they all seem to use this method of authenticating.

wouldn't it be easier to set DOCKERHUB_USERNAME and DOCKERHUB_PASSWORD on ci.j.io and trusted.ci? at the moment we use a config.json

The publish-tags script needs to be fixed to not do this.

@olblak @slide happy to go with whatever you think is best.  I can change this PR to use the variables if you think thats best

We already have DOCKER_CONFIG being set on ci.j.io and trusted. So, I think this docker login call should be wrapped with a check if DOCKER_CONFIG is empty or not set.
https://github.com/jenkins-infra/pipeline-library/blob/5b6efab292955b7cd73760a4cc9d4546f5f50525/vars/infra.groovy#L18

@olblak @slide I'm going to close this PR until we can get some consensus on a way forward.


WAC-Pull container images

The containers extension on Windows Admin Center should enable users to pull container images from OCI compliant repositories into the targeted container host.

This feature is now in preview. Please add bugs as new issues.


Notify issuer about registrations

Issuers don't get notified (via mail) when a participant registered for an opportunity. This functionality should be added to enhance the usability of Gentlestudent for issuers.

Fixed with #90


DDPB-3163: Allow users to queue a document for upload

Purpose
We need to add a way to manually put a document in that state.
In early days of the integration, this will allow us to test that it works as anticipated with a small number of clients. Going forward, it will also allow us to retry failed documents if/when we fix the reason for failure.
Fixes DDPB-3163
Approach
I added a new "Synchronise" button alongside the current report submission options. If clicked it will use a new API endpoint to synchronise documents of all selected report submissions.
It will only synchronise null, TEMPORARY_ERROR and PERMANENT_ERROR documents. The rest will be left as-is.
Checklist

[ ] I have performed a self-review of my own code
[x] I have updated documentation (Confluence/ADR/tech debt doc) where relevant

N/A

[x] I have added tests to prove my work

No Behat test because the setup doesn't lend itself well to Behat (need a submitted report, with a document which has failed) and it would only duplicate unit tests

[ ] The product team have approved these changes

Nice work


fix(app): Improve ODD "run again" behavior

Closes RQA-1972, RQA-1973

Overview
This PR adds a loading state to the "Run Again" button on the ODD.
It also fixes a routing bug in which pressing "run again" would send the user to the protocol setup page, back to the /protocols page, then back to the protocol setup page. Changes to TopLevelRedirect did not account for ODD "run again" routing logic. By removing the onResetSuccess callback, we avoid the superfluous redirect.
Current Behavior
https://github.com/Opentrons/opentrons/assets/64858653/2b5fcbf6-d6ab-43e7-b1be-9cd59889e832
Fixed Behavior
https://github.com/Opentrons/opentrons/assets/64858653/92bcfa5e-6564-4792-9272-6229a959bf6d

Test Plan

Follow the video flow above. Just verify that there's loading state and there is no redirection to the /protocols route after pressing "run again".

Changelog

Added loading state to the "Run again" button the ODD.
Fixed a routing issue when pressing "Run again" on the ODD.

Risk assessment
low

lgtm, I think we should definitely refactor LargeButton to support a spinner and the spinner css state. Looks like LargeButton is only used in this component so I think it'd be a quick refactor. But feel free to make a follow up ticket for that instead to do post-launch!

Thanks for your feedback! I didn't notice that we are using LargeButton only here (which seems weird to me...). I think I am going to ticket this out separately, because the more I think through it, the more it seems like this should involve some architecting. 🎨


🐛 Bug Report: Receive HttpError: fetch failed when creating GitHub Repo with Documentation Template

📜 Description
When trying to use the documentation template available under software templates and trying to push it to public github the operation breaks during the publishing process.
👍 Expected behavior
I wanted to create a GitHub Documentation Repository with the documentation template.
👎 Actual Behavior with Screenshots
After inserting all information in the form and clicking create the process starts and throws the following error:

Analyzing the process with the web-developer tool, I received the following logs:

👟 Reproduction steps
Configured GitHub integration in app-config.yaml:

Use the documentation template available at software templates.
Add the template to the catalog:

📃 Provide the context for the Bug.
No response
🖥 Your Environment
No response
👀 Have you spent some time to check if this bug has been raised before?

[X] I checked and didn't find similar issue

🏢 Have you read the Code of Conduct?

[X] I have read the Code of Conduct

Are you willing to submit PR?
None

Hey @ChiaraKr , did you end up fixing this issue? I've encountered something similar and logged here https://github.com/backstage/backstage/issues/22206


Form helper: set_radio default value

I'm not sure whether this is a bug or intentional, so if anyone could please shed some light on it.
The function "set_radio" does not work properly when used with a default value and 2 forms on the same page.
To reproduce:

Create a form with radio buttons where set_radio is used (form 1)
Create another form with a single textbox input (form 2)

When the page is opened, or when form 1 is submitted, everything works properly. A radio button is automatically set to checked based on its default value or the posted value.
When form 2 is submitted, the radio button has no checked attribute and thus is unchecked. If you reload the page (without submitting the form again) the radio button is populated again.
I suspect set_radio detects if a form has been submitted at all and if so - it checks its posted values. When form 2 has been submitted the radio values are not posted at all - so it doesn't check either of the radio buttons at all.
Expected result:
The provided default value, even when another form, which doesn't contain the radio buttons, has been posted.
Used code:
<input type="radio" id="profile-salutation-sir" name="profile_salutation" class="styled" value="0" {{set_radio('profile_salutation', '0', ($user->salutation == 0) ? TRUE : FALSE)}}>

<input type="radio" id="profile-salutation-madam" name="profile_salutation" class="styled" value="1" {{set_radio('profile_salutation', '1', ($user->salutation == 1) ? TRUE : FALSE)}}>

I suspect set_radio detects if a form has been submitted at all and if so - it checks its posted values. When form 2 has been submitted the radio values are not posted at all - so it doesn't check either of the radio buttons at all.

Right on the money. However, there's no way around that.


trivy-action for scanning kubernetes cluster

Is there any GitHub action to scan kubernetes cluster from trivy-action.

hi @muddassir-r - what are you trying to accomplish? You could use Trivy-operator to scan your k8s workloads.

@simar7 I was trying to use trivy-action to scan kubernetes cluster, I realize that the scope of trivy-action would be scanning the image build from the docker file which is placed in the repo.


Add HiDPI support

Screenshots of before and after on 4k monitor with 150% scaling:
Before:

After:

Thank you very much for this pull request.
I've merge it in master branch.


GitHub Action to compile binaries / perform a release

Release on a tag, e.g. https://github.com/taiki-e/upload-rust-binary-action
Or build / upload a binary on every merge to master

Done. We're not publishing to crates.io because we're using some unpublished dependencies, but we can use https://github.com/crate-ci/cargo-release for that and to bump versions.


Continuity of shell history

In step N, run shell command X
Then the "Up" arrow key can be used to re-run the same command X
Move forward to step N+1, which also features a web-term
The "Up" arrow key doesn't remember X

it would be nice if it did

There are few possibilities about how to achieve such behavior:

Don't create any bash_history temp file and write the history into the .demoit/.bash_history, code here : https://github.com/tomor/demoit/commit/a54874ec569add556e9622cff2624265ac418d58
Create only one temp history file during the demo - history shared  between slides
Create only one temp history file during demo per slide - history not shared between slides


Email owner on decommission

Why was this change made? 🤔
Resolves #2332.
How was this change tested? 🤨
Unit. (Will be tested in prod by Amy)
⚡ ⚠ If this change involves consuming from or writing to another service (or shared file system), run integration test create_object_h2_spec.rb and/or test manually in [stage|qa] environment, in addition to specs. ⚡

@lwrubel looks like a rebase is needed.

Rebased and squashed. Will merge once checks pass green.


Make js-tracer optional in rpc

Describe the feature
It's not possible to use rpc without having to compile all the boa stuff which takes a VERY long time to compile.
This was already reported in #10441, but partially implemented in #10444 for the rpc-eth-types and the revm-inspectors, but we're still missing in rpc: https://github.com/paradigmxyz/reth/blob/c35b8beb35594bb3192caec7d4335ca567d45539/crates/node/builder/Cargo.toml#L49
Additional context
No response

Hello @mattsse, can I work on this one?

it's not possible to use rpc

can you clarify here, because this is already a feature that we enable:
reth-rpc = { workspace = true, features = ["js-tracer"] }

so not 100% sure what you're exactly looking for here

it's not possible to use rpc

can you clarify here, because this is already a feature that we enable:
reth-rpc = { workspace = true, features = ["js-tracer"] }

so not 100% sure what you're exactly looking for here

It is not possible to use the node builder without bringing boa.
That permalink is for the reth/crates/node/builder/Cargo.toml.
So, ideally the user could opt-in into js-tracer and boa and not have that as a default feature in the reth-node-builder crate.
Is that helpful?

gotcha, let's lower this to the individual node crates first, if this is still insufficient, then we need to lower this to the cli itself but then we need some proper docs


Uploading large PDFs (> 5 MB) to S3 corrupts file

PLEASE NOTE: make sure the bug exists in the latest patch level of the project. For instance, if you are running a 2.x version of Apostrophe, you should use the latest in that major version to confirm the bug.
To Reproduce
Step by step instructions to reproduce the behavior:

Connect Apostrophe to an external S3-service (not running locally, in my case it was Scaleway)
In "Files" or in an object, where an apostrophe-attachment is used, upload a larger PDF file (my test file has a size from over 10 MB)
Click on "View file" --> External S3-Service tries to open the file in a new tab, but the file is broken

Expected behavior
An uploaded PDF file should have the original file size and be viewable
Describe the bug
See reproduce steps
Details
Version of Node.js:
Latest LTS (14)
Server Operating System:
Linux with Docker
Additional context:
Is also reproducable when running Apostrophe locally and connecting to an S3 service running on an external server

Do you believe this to be a bug in the gzip handling in general for large files? Is the bug reproducible with actual Amazon S3?

What platform (windows, mac, linux) is uploadfs running on when you experience this problem?

Can't tell about Amazon S3 as we're currently using Scaleway for S3 handling. It was perfectly reproducable when running a local Apostrophe 2.x instance on Ubuntu with Node 14 and setting the S3 values to our Scaleway credentials (when going for a local MinIO-Instance it is working). When uploading a large PDF file Scaleway doesn't seem to be able to handle the gzipped content. In my pull request I added pdf files to the noGzipContentTypes and it started to work with my local Apostrophe instance. But nevertheless I'm still experiencing the same trouble on our hosted Apostrophe instance (on a Node 14 Docker image also on Linux) - here an uploaded PDF file still gets corrupted (but for instance a zip file with the same size does not) - still investigating that issue...

I don't think it makes sense to remove gzip support for a file type from uploadfs without a deeper understanding of what is going wrong with Scaleway, particularly since it sounds like it is specific to them and not to Amazon. It could make sense to add additional configurability for those who want to work around this issue.

Good point. I was playing around with copying my modified s3.js file directly over the file from the node_modules folder and got it working in my special use case. A good solution would be in my opinion the possibility to set an optional array for the noGzipContentTypes in the uploadfs options (e.g. in my case "additionalGzipContentTypes": ["application/pdf"]). I could integrate that in the next few days. What do you think about that?

I'd say that "noGzipContentTypes" and "addNoGzipContentTypes" options could
be added... the former would replace the standard array, the latter would
just append to it.
Also if you can send me the offending PDF I can test it with actual S3 to
rule out a bug in the gzip handling in uploadfs (or more likely libraries
it's built on).
On Wed, Jan 5, 2022 at 1:56 PM Ryam BaCo @.***> wrote:

Good point. I was playing around with copying my modified s3.js file
directly over the file from the node_modules folder and got it working in
my special use case. A good solution would be in my opinion the possibility
to set an optional array for the noGzipContentTypes in the uploadfs options
(e.g. in my case "additionalGzipContentTypes": ["application/pdf"]). I
could integrate that in the next few days. What do you think about that?
—
Reply to this email directly, view it on GitHub
https://github.com/apostrophecms/uploadfs/issues/75#issuecomment-1005993784,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAAH27JCUJQDOVYQO2GGHLTUUSH7NANCNFSM5LG5536Q
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
You are receiving this because you commented.Message ID:
@.***>

--
THOMAS BOUTELL | CHIEF TECHNOLOGY OFFICER
APOSTROPHECMS | apostrophecms.com | he/him/his

As the PDF shouldn't be posted for the whole public I sent it to you via mail. Please don't spread it accross the whole internet ;)

Pull request #76 should now include that options.


Revert pluck behavior

Restore ActiveHash::Relation#pluck to execute the specified method on the record.
Background:

Through v3.1.x: Executed method names given as symbols.
In v3.2.x: Change impacted data retrieval by directly referencing attributes[key], affecting compatibility.

https://github.com/active-hash/active_hash/pull/269 broke functionality of gems like enumerize which rely on casting values accessed by column names.
Reproduce

Save following file as issue.rb.
Please switch version with uncomment line of gem "active_hash", "3.2.1" # fail test.
Run in terminal $ ruby issue.rb

#!/usr/bin/env ruby

begin
  require "bundler/inline"
rescue LoadError => e
  $stderr.puts "Bundler version 1.10 or later is required. Please update your Bundler"
  raise e
end

gemfile(true) do
  source "https://rubygems.org"
  gem 'enumerize'
  # gem "active_hash", "3.1.1" # pass test
  # gem "active_hash", "3.2.1" # fail test
  gem "active_hash", github: "active-hash/active_hash", ref: "6c51fa6d" # == master # fail test
  # gem "active_hash", github: "iberianpig/active_hash", branch: "fix/revert-pluck-behavior" # pass test
end

require "active_hash"
require "minitest/autorun"
require "logger"

class Country < ActiveHash::Base
  extend Enumerize
  enumerize :continent, in: { north_america: 1, south_america: 2, europe: 3, asia: 4, africa: 5, oceania: 6 }
  self.data = [
      {
        "id": 1,
        "name": "US",
        "custom_field_1": 1,
        "continent": 1
      },
      {
        "id": 2,
        "name": "Canada",
        "custom_field_2": 2,
        "continent": 1
      }
    ]
end
class BugTest < Minitest::Test
  def test_pluck_with_enumerize
    assert_equal "north_america", Country.find(1).continent  # continent is enumerized
    assert_equal [["US", "north_america"], ["Canada", "north_america"]], Country.all.pluck(:name, :continent)
  end
end

3.1.1
Fetching gem metadata from https://rubygems.org/.........
Resolving dependencies...
Run options: --seed 37444

# Running:

.

Finished in 0.000997s, 1002.6591 runs/s, 2005.3181 assertions/s.

1 runs, 2 assertions, 0 failures, 0 errors, 0 skips

3.2.1
Fetching gem metadata from https://rubygems.org/.........
Resolving dependencies...
Run options: --seed 14751

# Running:

F

Finished in 0.004705s, 212.5528 runs/s, 425.1055 assertions/s.

  1) Failure:
BugTest#test_pluck_with_enumerize [issue.rb:43]:
--- expected
+++ actual
@@ -1 +1 @@
-[["US", "north_america"], ["Canada", "north_america"]]
+[["US", 1], ["Canada", 1]]

1 runs, 2 assertions, 1 failures, 0 errors, 0 skips

@iberianpig see #300 for the Rails 7.1.3 fix

kicking now that 300 was merged

looking like the tests introduced by 299 are still passing.
We had introduced a few other changes around a symbol or string column access, so maybe the changes in 299 are no longer needed?

@kbrock Please confirm Reproduce section in this issue. You can reproduce this issue  in your terminal.

looking like the tests introduced by 299 are still passing.

I rebased and pushed this branch, then CI is all passed.
However it's still failing with $ ruby issue.rb .
  1) Failure:
BugTest#test_pluck_with_enumerize [issue.rb:44]:
--- expected
+++ actual
@@ -1 +1 @@
-[["US", "north_america"], ["Canada", "north_america"]]
+[["US", 1], ["Canada", 1]]

1 runs, 2 assertions, 1 failures, 0 errors, 0 skips

@iberianpig Sorry, I was not clear. Let me try again.
Good job. after this change, the tests introduced by #269 are still passing.
This makes me feel that the code change introduced in #269 is no longer needed.

Thank you for your feedback.
I've already add tests for #pluck that it does not rely on enumerize. Could you please take a moment to review them in This PR?

@kbrock When is the release likely to include the contents of this pull request? :smile:


disable BulkChangeTable cop

While this cop can offer faster migrations for very large databases, it also leads to more complex, more error-prone, and less understandable migrations for smaller (most) projects. For example, change_table with bulk: true does not properly reverse migrations that add columns and indices on those columns. The columns are dropped first and it then attempts to drop the indices, which were automatically dropped when the columns were dropped, resulting in an error. Furthermore, this situation is harder to debug with bulk: true as the standard rails migration logging just logs change_table(:bulk=>true), not the individual columns and indices being added/dropped. Finally, it only alerts on a subset of alter table statements, allowing some to be outside a change_table but forcing others to be inside the change_table block.

That does indeed seem bad!

Wow, that was quick! I spotted a typo in my commit message and amended it (hence the force push). I just barely got it in :wink: Thanks for the fast response and merge!


Fix NPE in ProcessCommonJsModules

Fixes #2308

Importing and testing...

Tests passed. Doing internal review.

Submitted internally.


maven clean does not work after using the plugin

For some reason after I use the plugin to update, I can not run maven again. The jar is taken by intellij. Close and open intellij solves the problem.
[INFO] Scanning for projects...
[INFO]
[INFO] ------------------------------------------------------------------------
[INFO] Building "project"0.1.0
[INFO] ------------------------------------------------------------------------
[INFO]
[INFO] --- maven-clean-plugin:2.5:clean (default-clean) @ project---
[INFO] Deleting E:\zzzz\xxxx\workspace\project\target
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE

Hi, thanks for your response.
I tried the indicated version, but the problem continues.
I describe my actions, I execute mvn clean package for the first time. Once the jar is created, I use the plugin to update the lambda in aws. So far so good. When making a change to the source and when rerunning mvn clean package, it gives the following error:
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-clean-plugin:2.5:clean (default-clean) on project XXXXXXX: Failed to clean project: Failed to delete E:\CCCC\RRRR\workspace\PPPPPPPP\target\XXXXXXXXX-0.1.0.jar -> [Help 1]
org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute goal org.apache.maven.plugins:maven-clean-plugin:2.5:clean (default-clean) on project XXXXXXX: Failed to clean project: Failed to delete E:\CCCC\RRRR\workspace\PPPPPPPP\target\XXXXXXXXX-0.1.0.jar
at org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:212)

Hi
I did not try “clean” - only “compile” and “package” (I’m not such familiar
with the maven workflow). Let me try this way also.
At least now it tells in the log - delete file, not entire “target” folder
(corrected this today).
Thank you, will keep you updated.
On Wed, 10 Oct 2018 at 15:53, rcastillosuazo<EMAIL_ADDRESS>wrote:

Hi, thanks for your response.
I tried the indicated version, but the problem continues.
I describe my actions, I execute mvn clean package for the first time.
Once the jar is created, I use the plugin to update the lambda in aws. So
far so good. When making a change to the source and when rerunning mvn
clean package, it gives the following error:
[ERROR] Failed to execute goal
org.apache.maven.plugins:maven-clean-plugin:2.5:clean (default-clean) on
project XXXXXXX: Failed to clean project: Failed to delete
E:\CCCC\RRRR\workspace\PPPPPPPP\target\XXXXXXXXX-0.1.0.jar -> [Help 1]
org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute
goal org.apache.maven.plugins:maven-clean-plugin:2.5:clean (default-clean)
on project XXXXXXX: Failed to clean project: Failed to delete
E:\CCCC\RRRR\workspace\PPPPPPPP\target\XXXXXXXXX-0.1.0.jar
at
org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:212)
[image: image]
https://user-images.githubusercontent.com/5520358/46741011-7c66fa00-cc7a-11e8-9596-efa02458466b.png
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/satr/intellij-idea-plugin-connector-for-aws-lambda/issues/17#issuecomment-428580660,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAq5jG7Nn2zy9nDI6NI_9AMuSZw2W233ks5ujfvxgaJpZM4XTU0g
.

--
BR
Sergey Smolnikov

Hi
So far I did not manage to make plugin fail as described - all the time after clean, compile, package it reports SUCCESS and can update the Lambda on AWS.
Probably I do this different or wrong way (as I mentioned, I'm not much familiar with Maven projects).
I will look at this more.

I'm using version 2018.1 Community Edition, I do not think that's it.
I will update intellij and try.
Greetings thank you

I also for not think it is a version issue. Which OS do you use (I tested
on MacOS). I can check on Windows and Linux as well.
Maybe you can put a sample project to github or attach an archive with it
here?
On Thu, 11 Oct 2018 at 16:23, rcastillosuazo<EMAIL_ADDRESS>wrote:

I'm using version 2018.1 Community Edition, I do not think that's it.
I will update intellij and try.
Greetings thank you
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/satr/intellij-idea-plugin-connector-for-aws-lambda/issues/17#issuecomment-428968306,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAq5jE48feUTJOb4I2iK1Fvz9KzSMso4ks5uj1RmgaJpZM4XTU0g
.

--
BR
Sergey Smolnikov

On Windows it works ok. Please check out how I tested it video. Maybe you can see the difference with the way you do it (maybe I do it wrong).

Here you can see how I get the error.video

Thank you fo the video. Seems I perform the process a bit different. I tried to reproduce with some maven example project from github, but still do not fail. I will check more about maven workflow and test again. It would be helpful if you could create a simple maven project, which is failing on your IDEA and share it, so I can reproduce this more accurate. Also please let me know if you use some plugins for Maven.


MH-12473, update the mediapackages's seriesTitle from the series service

The mediapackage is only updated from the eventUI metadata and so is missing the series title. Go get it from the series service.
(note though the event/{id}metadata is given a collection of series id=>title, this information is not extracted from the json).

@JamesUoM any movement on this?

This didn't make 3.6, and is fixed upstream.  Since no further releases are planned for 3.x and it's fixed upstream, let's just decline this.