Error using iOS OpenVPN

I've successfully installed PiVPN and have generated an ovpn file I would like to use on my phone.  I've imported the ovpn into OpenVPN 1.0.7 build 199 for iOS successfully.
When I attempt to connect the following error appears:
OpenVPN error: PolarSSL: error parsing config private key : PK - Bad input parameters to function.
Can anyone tell me what I've done incorrectly?
Thanks,
Bob

PiVPN Issue Template

Console output of curl install.pivpn.io | bash

Console output of pivpn add or pivpn add nopass

Console output of pivpn debug
::: Generating Debug Output
:::					:::
::		PiVPN Debug		 ::
:::					:::
::	Latest Commit			 ::
:::					:::
commit 6b406ffb27fad7edaae4fee3e6ccafa523c1ed9f
Author: Kaladin Light<EMAIL_ADDRESS>Date:   Sun Dec 11 10:04:33 2016 -0500

    Fix type for moving client script
:::					:::
::	Recursive list of files in	 ::
::	/etc/openvpn/easy-rsa/pki	 ::
:::					:::
/etc/openvpn/easy-rsa/pki/:
test.ovpn
ca.crt
Default.txt
dh4096.pem
index.txt
index.txt.attr
index.txt.attr.old
index.txt.old
issued
private
serial
serial.old
ta.key

/etc/openvpn/easy-rsa/pki/issued:
test.crt
server.crt

/etc/openvpn/easy-rsa/pki/private:
test.key
ca.key
server.key
:::					:::
::	Output of /etc/pivpn/*		 ::
:::					:::
:: START /etc/pivpn/DET_PLATFORM ::
Raspbian
:: END /etc/pivpn/DET_PLATFORM ::
:: START /etc/pivpn/INSTALL_PORT ::
1194
:: END /etc/pivpn/INSTALL_PORT ::
:: START /etc/pivpn/INSTALL_PROTO ::
udp
:: END /etc/pivpn/INSTALL_PROTO ::
:: START /etc/pivpn/INSTALL_USER ::
pi
:: END /etc/pivpn/INSTALL_USER ::
:: START /etc/pivpn/NO_UFW ::
1
:: END /etc/pivpn/NO_UFW ::
:: START /etc/pivpn/REVOKE_STATUS ::
0
:: END /etc/pivpn/REVOKE_STATUS ::
:::					:::
:: /etc/openvpn/easy-rsa/pki/Default.txt ::
:::					:::
client
dev tun
proto udp
remote (hostname) 1194
resolv-retry infinite
nobind
persist-key
persist-tun
key-direction 1
remote-cert-tls server
tls-version-min 1.2
verify-x509-name server name
cipher AES-256-CBC
auth SHA256
comp-lzo
verb 1
:::					:::
::	Output of iptables		 ::
:::					:::
Chain PREROUTING (policy ACCEPT 0 packets, 0 bytes)
 pkts bytes target     prot opt in     out     source               destination

Chain INPUT (policy ACCEPT 0 packets, 0 bytes)
 pkts bytes target     prot opt in     out     source               destination

Chain OUTPUT (policy ACCEPT 0 packets, 0 bytes)
 pkts bytes target     prot opt in     out     source               destination

Chain POSTROUTING (policy ACCEPT 0 packets, 0 bytes)
 pkts bytes target     prot opt in     out     source               destination
:::					:::
::	Debug Output Complete		 ::
:::					:::
:::
::: Debug output completed above.
::: Copy saved to /tmp/debug.txt
:::

Issue

@0-kaladin: have we switched to ECDSA yet?

This same question seems to have been asked on the OpenVPN form.   Unfortunately, no one has answered it over there, either.
https://forums.openvpn.net/viewtopic.php?t=22129

@redfast00 No.  Read Issue #161 and the bottom comments i have in the orig Issue #53

I’m also getting this, did a few fresh installs and get the exact same message. And it's not just on iOS, also tried adding client to Android tablet and got the exact same message.

There is some chatter on other groups that some OpenVPN implementations cannot handle client keys that are encrypted with RSA.
If your client key is encrypted, you might try a different client that is unencrypted, or re-encrypting your current client key using 3DES.
openssl rsa -in Client1.key -des3 -out Client1.3des.key
and then replace your old client key with the new client key in your configuration.

Thanks for the response @fyellin
I tried but no success running your command. I was running it against my .ovpn files in replace of your .key example.
The error that followed was:
1995929696:error:06065064:digital envelope routines:EVP_DecryptFinal_ex:bad decrypt:evp_enc.c:516:
1995929696:error:23077074:PKCS12 routines:PKCS12_pbe_crypt:pkcs12 cipherfinal error:p12_decr.c:108:
1995929696:error:2306A075:PKCS12 routines:PKCS12_item_decrypt_d2i:pkcs12 pbe crypt error:p12_decr.c:139:
1995929696:error:0907B00D:PEM routines:PEM_READ_BIO_PRIVATEKEY:ASN1 lib:pem_pkey.c:138:

Better instructions.
If you look inside your .ovpn file, you'll see a line <key>, many lines of text, and then a line </key>.  Everything in between those two markers (but not the two markers themselves) is your encrypted secret "key" and should be copied to Client1.key as described above.  Once you then have Client1.3des.key as described above, replace the text between the old key with the new key.
Keep a backup of your original .ovpn.

Yes! working. Huge thanks for the info @fyellin, re-encrypting did the trick.

So... this issue can be closed, right?

For me, yes as a workaround, hopefully a more permanent solution will be written into an update.
Thanks

I can verify that the directions @fyellin provided do work on OpenVPN 1.0.7 build 199 (iOS 64-bit).  I had to follow this to get my phone to connect to my pivpn installation.

The commands you guys run that fix it for you the script also runs. So what I need to figure out is why that doesn't stick for you

I stumbled across this as I'm having a similar issue.
I have a raspberry pi I had installed OpenVPN on. The SD card crapped out, so I started to rebuild from scratch. I came across PiVPN, and it looked a heck of a lot easier (more automated) than what I had originally done, so I gave it a go. Everything went smoothly. I created .ovpn profiles.
I went to import one into my android phone, and it gave me the same openvpn error mentioned above.
Long story short, I stumbled across these posts and opened a .ovpn file, copied the key, pasted it into a new .key, ran the command above, created a 3des.key, then copied that key back into an .ovpn profile.
It works great. I was able to get my android phone connected.
I can use the original .ovpn key with the OpenVPN Android app by Arne Schwabe without issue, but I know I will also be putting these profiles on android and apple devices.
My concern is, how secure is re-encrypting the keys with 3DES? Is that something I need to be concerned about?

You don't need to be concerned: the triple DES encrypted keys just adds an extra layer of security in case your .ovpn files get compromised.

Ok, thanks. I had suspected it was just more with the encryption of the actual .ovpn file itself and not the encryption between the client and server, but wanted to double check and not assume.

so interestingly enough... I tried creating a user with the pivpn -a nopass option. I imported it into the Android OpenVPN app, and it connected right away without the need to modify and reencrypt the key in 3des. Could the issue be that I'm using 4096 bit encryption? I believe when I had my other OpenVPN server on a raspberry pi, I was using 2048 bit encryption and didn't have these issues with the ovpn profiles.

Also, regardless if I re-encrypt the key to 3des, and then copy the key back over to the ovpn profile, I still can't get the profile to work on IOS. it keeps asking me for a password to extract the keys (if I try the modified ovpn), or if I try the original, I get the parse error.

Hi There,
I encountered this problem and have found a solution based on the advice above.  the steps I followed were as follows
1.) SSH into your RaspberryPi -> ssh username@piaddress -> enter pi password
2.) Create a new OpenVPN profile ->  sudo pivpn add -> enter profile name -> enter password -> confirm password
3.) Navigate to directory ->  cd /etc/openvpn/easy-rsa
4.) pen up created key in nano -> sudo nano pki/private/profile.key
5.) In nano add a new line at the top of the file by pressing enter ->  then save and quit by -> ctrl X -> Y -> delete filename and directory and replace with just the file name -> delete pki/private/profile.key -> type profile.key -> save with new file name -> Y
What you've just done is modify the original profile to allow you to save it to an unprotected directory.
6.) Now remove the additional line -> sudo nano profile.key
delete the additional line and -> ctrl x -> y -> enter
7.) You can now run the openssl command to change the format. -> sudo openssl rsa -in profile.key -des3 -out profile.3des.key -> enter profile password -> enter a password for new file -> confirm password
8.) You can now SFTP the new profile.3des.key file onto your computer.  Open it in any text editor and copy all of the content including  -----BEGIN RSA PRIVATE KEY----- all the way to the end of -----END RSA PRIVATE KEY-----
9.) Open up the profile.ovpn file you originally copied from the OVPNS folder under your user (the file you'd normally use to access your OpenVPN profile before this error happened.  Delete everything between the   markers and paste in the content of the profile.3des.key file so it looks like

-----BEGIN RSA PRIVATE KEY-----
Proc-Type: 4,ENCRYPTED
DEK-Info: DES-EDE3-CBC,0717308C6286B5D5
aYxAF+8FQ87nNbQPHYkUOTXjGZ+nnMzT76MyMJGHyP5Lq9FaCXNAY59Kjey67WHv
RNXqc5bZyOKuLOzBqi0W9oTJM31iMmBcaZBCiEsTAZadTz8TqXDQE9sI6p4sh5DM
SNTCjWDTcpIfXc77lQJEtzTOFRKAyx8bKgNNUulY2rr1SqTKH2zykefx/GrSKyia
eY69W6uob1nlxyWqH+uAk4y+dhC4mDEATqMI7c6xHYf27ixqD9fJ+0OY9NGce1YI
vJuh7Rvo1xdUnyvMl4G2BgDzT180unP/HQYBFHX//GDgxt11auaAhO6bpq3H1P2j
-----END RSA PRIVATE KEY-----

save the profile.ovpn file
10.) And you are done.  copy this file to your device and it should work.  it did for me.:-)

@WardPC  Thanks for posting, I made an account tonight just because I needed to say thanks. This was killing me and I just used the openvpn app you suggested by Arne Schwabe and it worked immediately. Very glad not to be messing with the .ovpn files.

Credit to @fyellin and @WardPC for leading me to the command openssl rsa -in Client1.key -des3 -out Client1.3des.key. I was able to rectify the "OpenVPN Error : PolarSSL: error parsing config private key : PK - Bad input parameters to function" error on an iPad (iOS 11.something).
I pasted the 3DES key contents into the unified OVPN profile and the error went away. Bonus that this also fixed the same error on my Android phone.

I am also having bad input issue on my iphone open vpn when using a password protected key that has been fixed with the command above openssl rsa -in Client1.key -des3 -out Client1.3des.key
Im not sure if I need to worry about this or not, but openvpn status log reports that this is insecure because of the block size:
Tue Oct 17 11:07:19 2017 Outgoing Data Channel: Cipher 'BF-CBC' initialized with 128 bit key Tue Oct 17 11:07:19 2017 WARNING: INSECURE cipher with block size less than 128 bit (64 bit).  This allows attacks like SWEET32.  Mitigate by using a --cipher with a larger block size (e.g. AES-256-CBC). Tue Oct 17 11:07:19 2017 Outgoing Data Channel: Using 160 bit message hash 'SHA1' for HMAC authentication Tue Oct 17 11:07:19 2017 Incoming Data Channel: Cipher 'BF-CBC' initialized with 128 bit key Tue Oct 17 11:07:19 2017 WARNING: INSECURE cipher with block size less than 128 bit (64 bit).  This allows attacks like SWEET32.  Mitigate by using a --cipher with a larger block size (e.g. AES-256-CBC). Tue Oct 17 11:07:19 2017 Incoming Data Channel: Using 160 bit message hash 'SHA1' for HMAC authentication Tue Oct 17 11:07:19 2017 WARNING: cipher with small block size in use, reducing reneg-bytes to 64MB to mitigate SWEET32 attacks. Tue Oct 17 11:07:19 2017 interactive service msg_channel=676
Is this the result of the -des3 or does this have something to do with my openvpn-ca setup?
Is this something that I need to worry about?

@gonetoplaid74
3.) Navigate to directory -> cd /etc/openvpn/easy-rsa
I did this just fine.
4.) pen up created key in nano -> sudo nano pki/private/profile.key
This brought up a blank screen. The file had no text or data whatsoever. I wasn't sure if I was missing something or not. When I create ovpn files using PiVPN, it puts them in the home directory in an "ovpns" folder.

Ran into the same blank screen for the pki/private/profile.key.  Then I realized I needed to use the name of the VPN profile I had used.
Try sudo ls /etc/openvpn/easy-rsa/pki/private to see the names of the profile key files.
Another approach is simply to copy the profile key file out of the 'private' directory sudo cp /etc/openvpn/easy-rsa/pki/private/myprofilefile.key and then use sudo chown pi:pi myprofilefile.key to make it easier to work with.
The instructions to use the 3DES private key have worked great for me!  Got it up and running on two iPhones and a Windows 10 laptop.
Thanks!

@keithele Yes! sudo ls /etc/openvpn/easy-rsa/pki/private to see the key names, and then copying them over works great.
I simply just did a sudo cp /etc/openvpn/easy-rsa/pki/private/myprofilefile.key over to my home/pi/ovpns folder, converted to 3des, then used winscp32 to copy the newly created .3des.key, opened it up in notepad++, copied the entire
`-----BEGIN RSA PRIVATE KEY-----
-----END RSA PRIVATE KEY-----`
and overwrote what was already in the .ovpn profile.

Just as a note to future readers, the method by @fyellin (still) works! 👍
My combination of hard- and software was the following. On a Raspberry Pi running Debian Stretch and having set up PiVPN, I could also successfully establish a connection on my iPhone 8 running iOS 11.1.
The only thing really worth mentioning is that I had to run the openssl command on my Pi, whereas I initially was trying to do this on my Mac. That approach gave me errors, which may be logical seen that my Mac hadn't anything to do with generating the keys and whatnot before. At least, that's what I guess.
The question remains, if the script is already configured to execute this workaround automatically, why does this remain a problem for so many?
Anyway, I'm glad I stumbled upon this tool. I've set up OpenVPN manually myself in the not so distant past, and friggin' hell, this makes it a lot easier 😊

For your information, the definitive solution for this problem consist in patching mbedTLS to accept keys encrypted by openssl. A PR has been opened at https://github.com/ARMmbed/mbedtls/pull/1219

i wrote a little script for this problem ...
https://git.gastier.net/berzerking/outbound/


gherkin java: Extended the languages list to include a column with the language name and a column with the native name

Summary
I updated the language list to include not just the language code but also the language name in English as well as the native language name.
Details
The list of languages looked like this:
af
am
ar
ast
az
bg
…

There are 73 languages supported. It isn't easy to know which language is which.
I extended the list to look like this:
af            Afrikaans               Afrikaans
am            Armenian                հայերեն
ar            Arabic                  العربية
ast           Asturian                asturianu
az            Azerbaijani             Azərbaycanca
bg            Bulgarian               български
…

Motivation and Context
This will make it easier to understand what language a language code is supporting.
How Has This Been Tested?
I added a unit test that verifies that the list contains one row
sv            Swedish                 Svenska

Screenshots (if appropriate):
Types of changes

[ ] Bug fix (non-breaking change which fixes an issue).
[X] New feature (non-breaking change which adds functionality).
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected).

Checklist:

[X] I've added tests for my code.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.

I'm not sure that this logic belong in the Gherkin library. Cucumber-Ruby already implements this logic locally (right here). If this logic belong int the Gherkin library, then all Gherkin language version should implement this logic.

Unfortunately, the Gherkin library only exposes a String with the language. If it exposed something richer that include language code, name, and native name then I would agree.
Would it be a better idea to expose a list of Language objects that holds all values necessary for creating the list? That would move most of the logic to Cucumber and possibly make better sense.

The return value of getLanguages() is a list of things (which happens to be strings - the exact strings that should be but in a feature file to specify the language of the feature file), which can be passed as arguments to getDialect() to get a GherkinDialect object. With this change the semantic of getLanguages() changes from returning a list of something that can be used to pass to getDialect() to something useful to display to a human user. That makes this change a non-backward compatible change. It would be possible to add a new method getLanguageListForDisplay(), but I still question if such a method belong in the Gherkin library. Shouldn't Cucumber-JVM instead use the getLanguages() output to iterate over the GherkinDialect object to construct the list to display to the user (as Cucumber-Ruby does).

I think it would be better to expose a public List<GherkinDialect> getDialects() method and leave it to the consumer to decide how to format them. We'd probably also have to add a getter to get the native translation of each dialect.
What do you think @tsundberg ?

If we do this we should also deprecate List<String> getLanguages().

@brasmusson I agree with your concern about semantics and backwards compatibility.
@aslakhellesoy I agree, exposing public List<GherkinDialect> getDialects() and let the consumer decide on it's usage is better. That was pretty much what I had in mind when talking about a richer object.
Deprecating  List<String> getLanguages() in the process seems reasonable.
I'll fix that.

As suggested, I introduced a method List<GherkinDialect> getDialects() that exposes all dialects.
I added getters for name and native name on GherkinDialect to allow a consumer to extract the values and display them as needed.
I also deprecated List<String> getLanguages() and recomend to use List<GherkinDialect> getDialects() in its Javadoc.
This allows me to implement the desired list with language, name and native name in Cucumber-JVM instead.

The test described above is obsolete. There are three unit tests that verifies

the returned list contains the dialect Swedish
it is possible to get the name Swedish from the dialect
it is possible to get the native name Svenska from the dialect

What code will be calling the new method? Who's the consumer?
@brasmusson made a comment above that this should be implemented in all the other ports. I agree, and nobody has taken the time to do that.
I don't know exactly what use case this is supposed to support, but I wonder if it's easier to just parse the JSON directly.
For example: cat gherkin-languages.json | jq -r 'to_entries[] | [.key, .value.name, .value.native] | @tsv'

This is intended to support: https://github.com/cucumber/cucumber-jvm/pull/1290
Parsing the json is possible but it seems to be an implementation detail of the gherkin library.

In Cucumber-JVM v1.2.x the option --i18n help printed a list of language codes:
af
am
...

The GherkinDialectProvider.getLanguages() was introduced to enable the same behavior in Cucumber-JVM v2.x.x.
In Cucumber-Ruby the corresponding option --i18n-languages prints a list with the code, name and native name for each language:
  | af        | Afrikaans           | Afrikaans             |
  | am        | Armenian            | հայերեն               |
...

This is basically the behavior @tsundberg want Cucumber-JVM to also have in https://github.com/cucumber/cucumber-jvm/pull/1290.
Cucumber-Ruby implements this behavior by by direct access to the DIALECTS in Gherkin-Ruby. With the stronger typing and encapsulation of Gherkin-Java, https://github.com/cucumber/cucumber-jvm/pull/1290 needs this PR to be able to implement something similar.
I opposed the first version of this PR (https://github.com/cucumber/cucumber/pull/313/commits/1821623c3bb814b786660de4d52ab9c96f2c5af6) where GherkinDialectProvider.getLanguages() was change to return a strings like "af         Afrikaans            Afrikaans" for each language, and pointed out that such a behavior should be available also in the other language implementations of Gherkin if available in Gherkin-Java. The current version of this PR, where the there is an accessor for the list of GherkinDialect object available in Gherkin-Java, on the other hand is more a consequence of the Java language. In Gherkin-Ruby there is not GherkinDialectProvider class, in the more flexible Ruby language the Gherkin::Dialect class and the module variable DIALECT suffice.
I think this PR can be merged.

API for what?. I think that creating of tables like:
 | af        | Afrikaans           | Afrikaans             |

should be kept out of the gherkin library, so the gherkin library can be focused on parsing and compiling feature files.
As I see it the only thing missing in the gherkin library for java to support cucumber/cucumber-jvm#1290 is accessor for the name and native name in the GherkinDialect class. The GherkinDialectProvider.getLanguages() and GherkinDialectProvider.getDialect() enables Cucumber-JVM to iterate over all the GherkinDialect object, and with accessors for the name and native name, Cucumber-JVM can produce the extended language table.

Would something like this address the problem you're trying to solve @tsundberg? (The page is regenerated whenever there is a new Gherkin release).
This is the new docs website some of us have been working on for the past months. It obviously needs some more styling, but you get the idea.

I believe the intent was to improve the commandline output.
The difference with the page is that the commanline refelects the current state of the app rather then the latest.

I think the intent was to improve the documentation of the dialects.
One way to do that is through the command line. Another way is through a web page.
I think a web page is sufficient, but I’m not going to object if someone wants to implement this change in 8 implementations.

I just reverted the change in the Gherkin API. The current API should be compatible with the rest of the implementations.
I had to keep the addition of getting the name and the native name from GherkinDialect so the Java implementation can pick up name and native name. These properties wasn't exposed earlier.

I'm closing this pull request and suggest that the changes are included from #366


v0.11.0-beta4 vaadinRun does not support dependsOn ???

In my build script, i set the dependsOn of the vaadinRun task and it works fine in the 0.10.x versions, but in the new 0.11.x versions I get the following error:

The vaadin.widgetset property has been deprecated and is scheduled to be removed in Gradle Vaadin Plugin 0.12. This property has been replaced by automatic widgetset detection. You should be able to remove this property definition completely. If you do need to set it manually you can set vaadinCompile.widgetset.
The vaadin.plugin.logToConsole property has been deprecated and is scheduled to be removed in Gradle Vaadin Plugin 0.12. This property has been replaced by vaadin.logToConsole.
The vaadin.debugPort property has been deprecated and is scheduled to be removed in Gradle Vaadin Plugin 0.12. This property has been replaced by vaadinRun.debugPort.
The vaadin.testbench property has been deprecated and is scheduled to be removed in Gradle Vaadin Plugin 0.12. This property has been replaced by vaadinTestbench

FAILURE: Build failed with an exception.

* Where:
Build file '/Users/SeanS/repos/federated-console/build.gradle' line: 304

* What went wrong:
A problem occurred evaluating root project 'consoleorchestrator'.
> Could not find method dependsOn() for arguments [task ':war'] on fi.jasoft.plugin.configuration.ApplicationServerConfiguration_Decorated@213a61f0.

* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output.

BUILD FAILED

Total time: 11.226 secs

This is the line in question:
vaadinRun.dependsOn war
Thanks in advance!
Sean

Problem is that with 0.11 vaadinRun can both reference the task and the task configuration. When you define vaadinRun.dependsOn you are trying to invoke the dependsOn property on the vaadinRun configuration not the task.
Instead you want to use tasks.vaadinRun.dependsOn war to do the same.

Thanks! That looks like it fixed it.
Sean


Skip tests that depend upon the unittest user to pass.

@thetorpedodog I just saw #312, will update wording :)


Online doc for DataLoader2/ReadingService and etc.

📚 The doc issue
As we are preparing the next release with DataLoader2, we might need to add a few pages for DL2, ReadingService and all other related functionalities in https://pytorch.org/data/main/

[x] DataLoader2
[x] ReadingService
[x] Adapter
[ ] Linter
[x] Graph function
[ ]

Suggest a potential alternative/fix
No response

Potential duplicate issues of:

#649
#655
#661

We should keep one and close the other ones?

Do we plan to add some demo runs in the colab linked in the TorchData README.md
https://colab.research.google.com/drive/1x1ESG0_N02txFuQwyTfCnjhqzS-PzQjA
Thanks.

Do we plan to add some demo runs in the colab linked in the TorchData README.md

@dahsh
It would be great if we can update it with DataPipe + DataLoader2.


Added support for displaying time taken by each player & also Blitz mode Chess

The time played by each player is being displayed along with the user name . Also , one can set a timeout ,  inorder to play in Blitz mode (to be specified in chesshub.js file)

Cool! Thank you for this addition :+1:
But I think your fork is not up to date with last commits in the master branch.
I have added some comments on outdated code parts. Please make sure to update your branch.
I'll merge your pull request asap.
Thank you for your contribution :-)
Cheers

A side note, you added handlebars-v2.0.0.js but you didn't imported it in the project.
I'm not sure this is needed since handlebars is already imported:
https://github.com/benas/gamehub.io/blob/master/package.json#L19
https://github.com/benas/gamehub.io/blob/master/app.js#L28
That's all for my review.
Do not hesitate to add your comments.
If it is ok for you, please update the pull request and I'll merge it asap.

Hi ,
I just updated the fork to the latest .
I have added codes to display the time played by each player along with the user name . Also , support to Blitz mode chess is also provided .
Cheers

Cool! this goes straight to the master branch :-)
Thank you for your contribution! :+1:
Regards
Mahmoud


WritableComputed doesn't find getters for Vue2 testing

Reproduction
https://github.com/heykc/pinia-test
Steps to reproduce the bug

pull down the repo above
run the test
notice test fails with a warning of [Vue warn]: Write operation failed: computed value is readonly.

Expected behavior
The test should successfully reassign the double getter to a new value, and the expectation following should pass.
This test is nearly identical to the test inside of @pinia/testing called allows overriding computed properties but runs with a Vue 2 instance instead.
Actual behavior
The test fails with a warning of [Vue warn]: Write operation failed: computed value is readonly.
Additional information
I believe this is due to the fact that the WritableComputed function in @pinia/testing/testing.ts only looks for refs when checking for computed properties. In Vue 2, there are no refs and therefore none of the getters within a given store are spotted within this function.
I have a proposed solution which is to check for Vue2 specifically and confirm there are getters within the options of the store. The code below is an example of my solution:
function WritableComputed({ store, options }: PiniaPluginContext) {
  const rawStore = toRaw(store)
  for (const key in rawStore) {
    const value = rawStore[key]
    // Vue 2 pinia getters are not refs and have to be found a different way than isComputed()
    const isVue2Getter = isVue2 && options.getters?.[key]
    if (isComputed(value) || isVue2Getter) {
      rawStore[key] = customRef((track, trigger) => {
        let internalValue: any
        return {
          get: () => {
            track()
            // since Vue2 getters are just functions and not refs, they don't have a value property
            return internalValue !== undefined ? internalValue : (isVue2Getter ? value : value.value)
          },
          set: (newValue) => {
            internalValue = newValue
            trigger()
          },
        }
      })
    }
  }
}

I'd be happy to put in a pull request but I couldn't figure out a way to reproduce this test directly in the pinia/testing repo. It would have required a way to switch vue-demi to vue2 which caused a lot of peer dependency conflicts. I'd love to find out the best way to write a test for this particular instance to go along with this code fix.
I'm also not married to the isVue2Getter variable name or the nested ternary. Open to code suggestions on this.

Currently, is there a way to mock getters in Vue 2?

Since Vue2.7, any news on this matter ?

@stephanos-square you need to set the state instead, in order to make the getter generate the value you want

@stephanos-square you need to set the state instead, in order to make the getter generate the value you want

Didn't work for me, the state was changed, but the related getters didn't react to that change

@stephanos-square you need to set the state instead, in order to make the getter generate the value you want

Didn't work for me, the state was changed, but the related getters didn't react to that change

Do you have an example repo? It could be something related to the lifecycle of your test case. If you could share the code I can check it

@stephanos-square you need to set the state instead, in order to make the getter generate the value you want

Didn't work for me, the state was changed, but the related getters didn't react to that change

Do you have an example repo? It could be something related to the lifecycle of your test case. If you could share the code I can check it

Here is an abridged version of what I have:
I have a factory:
const factory = () => {
	return mount(myComponent, {
		pinia: createTestingPinia(),
		localVue
	});
};

Then in the tests:
it("Shows the footer button as disabled when loading", async () => {
		wrapper = factory({});
		const loadingStore = useLoadingStore();
		loadingStore._loadingStack = ["loadingContext"];
		console.log(loadingStore._loadingStack , loadingStore.isLoading ) // logs "["loadingContext"], false"
		const footer = wrapper.find('[data-testid="footer"]');
		expect(footer.findComponent(ButtonComponent).classes("disabled")).toBe(true);
});

The console log I inserted yields the _loadingStack  state which I can effectively modify, but the resulting computed isLoading checks for the length > 0 of the _loadingStack  array, but, as you see, it still returns false. I have tried inserting some nexTicks in the process, but with no results.

What about the code in your component and in the loadingStore? Maybe there's something strange there. Can you share the repo or a (not)working example?

This is a work around for Vue2 with setup setup (not tested with option) working like official documentation.
You just have to create a plugin with the following code
`
/* eslint-disable no-underscore-dangle,@typescript-eslint/explicit-function-return-type */
import {
customRef,
isRef,
toRaw,
} from 'vue'
import type { ComputedRef, WritableComputedRef } from 'vue'
import {
PiniaPluginContext,
} from 'pinia'
function isComputed(
v: ComputedRef | WritableComputedRef | unknown,
): v is ComputedRef | WritableComputedRef {
return !!v && isRef(v) && 'effect' in v
}
/**

This plugin is a modified fork ok WritableComputed plugin of @pinia/testing
The actual version of plugin provides by @pinia/testing does not work to stub getters with Vue2
https://github.com/vuejs/pinia/pull/1201
https://github.com/vuejs/pinia/issues/1200
The modified plugin allowed developers to modify getter return value like documentation of Pinia
https://pinia.vuejs.org/cookbook/testing.html#Mocking-getters
*/
export function WritableComputedPlugin({ store }: PiniaPluginContext) {
const rawStore = toRaw(store)

for (const key in rawStore) {
if (rawStore._hmrPayload.getters[key] && isComputed(rawStore._hmrPayload.getters[key])) {
const originalComputed = Object.assign({}, rawStore._hmrPayload.getters[key])
const originalFn = originalComputed.effect.getter
const defaultValue = originalComputed.value
originalComputed._value = originalComputed.value
rawStore[key] = customRef((track, trigger) => {
// override the computed with a new one
const overriddenFn = () => originalComputed._value
    return {
      get: () => {
        track()
        return originalComputed._value
      },
      set: (newValue) => {
        // reset the computed to its original value by setting it to its initial state
        if (newValue === undefined) {
          originalComputed.effect.fn = originalFn
          originalComputed._value = defaultValue
          originalComputed._dirty = true
        } else {
          originalComputed.effect.fn = overriddenFn
          originalComputed._value = newValue
        }
        // this allows to trigger the original computed in setup stores
        trigger()
      },
    }
  })
}

}
}
`
then add the plugin to your renderer
pinia: createTestingPinia({         plugins: [WritableComputedPlugin],       }),
You can now stub your getters result then reset it by passing undefined value.


Refactor __callStatic() method

Currently it is close to impossible to understand what is going on there:(
But it works properly!:)
Should be done after #3, otherwise it will be a nightmare...

Actually fixed long time ago:)


Miscellaneous UI fixes

Overview

Fix contributor form troubleshooting type / Connects #381
Left-align facility list items guide text snippet / Connects #382
Show country name in facility details address / Connects #375
Reroute to facilities on login / Connects #376
Conditionally redirect to facilities map on logout / Connects #343
Restrict map bounds to tile extent / Connects #365
Autofocus first user input on forms / Connects #273
Update Guide tab panel text / Connects #383

Testing

for each of the issues above, verify that the UI issue has been remedied by the changes here.

@designmatty for https://github.com/open-apparel-registry/open-apparel-registry/pull/385/commits/57a4836d1e3d2e7a91c5a8854354e634a2b064a4 I had to disable an ESLint rule about not using the autoFocus prop.
In this case, I am using it to focus the first field of form inputs -- which is, I think, the correct behavior -- but can you concur that it's okay from an accessibility perspective for me to disable the linting rule for that specific line in this specific circumstance?

Seeing this error in the console:

That error's from a bug or quirk of how react-router sees the NoRouteMatch component. I fixed it in a commit on this PR:
https://github.com/open-apparel-registry/open-apparel-registry/pull/353

Specifically: https://github.com/open-apparel-registry/open-apparel-registry/pull/353/commits/669d756b9720b70eebcf07facfb422f7c95eef86
Unfortunately that error is also currently on develop, but it's non-breaking and it's coming from a library, not our code.

This may be worth its own card, but here's an odd behavior I noticed:

Be logged out
Search for a facility
See it in the search results
Log in
Be redirected to search results, but now they are empty
Search again to see them populated

If instead of being redirected to the search results, I was redirected to an empty state, that would've been better. Or, the search results should've stuck around.

This may be worth its own card, but here's an odd behavior I noticed:

Makes sense. Can you write this up as its own card? This is how things work on develop, too.

I think the fix might be to reset the selected tab in the UIReducer when necessary so it'll default back to the search tab.

I don't see a login link when going to a facility detail page if I'm logged out, as asked for in #343

I don't see a login link when going to a facility detail page if I'm logged out

Thanks for catching. I added this in
c6b80cc8bf15fd18660d4fafc22c02782813d936

Cool, thank you for testing!

I updated the commit message for the commit which includes the autoFocus prop and turns off the jsx-a11y linting for the relevant line. We checked into it and because we are using the prop to make the forms behave as normal forms, it appears to be a blessed use of the autoFocus prop there.


No access to amazon-reviews-pds

In data-science-on-aws/03_automl/01_Prepare_Dataset_Autopilot.ipynb
I am unable to access the customer reviews data set. Clicking the link at the top produces this:
This XML file does not appear to have any style information associated with it. The document tree is shown below.
<Error>
AccessDenied
<Message>Access Denied</Message>
<RequestId>QRXT02TA3FDC5GSK</RequestId>
<HostId>nxtkdIXXwvCLIZnwGOvaWF2cAA21pSWr6mb1ZmbCKUf37c4kwhFo5Sdfk58Ybaln+gARNpNm1Zg=</HostId>
</Error>

And the aws s3 command fails:
!aws s3 cp 's3://amazon-reviews-pds/tsv/amazon_reviews_us_Digital_Software_v1_00.tsv.gz' ./data/
fatal error: An error occurred (403) when calling the HeadObject operation: Forbidden

Hi, thanks for the great work. I get the same error, Is there still a way to continue using the notebooks after the workshop as i logged in with the root user. I did even added Access controls as recommended while setting up the domain.

Change s3://amazon-reviews-pds/ => s3://dsoaws/

Thanks for your help. Somehow another category was working as below. In addition I had to change the permissions for S3 bucket in Policies. Would this effect if I continue with the Video category below?
!aws s3 --no-sign-request cp s3://dsoaws/tsv/amazon_reviews_us_Digital_Video_Download_v1_00.tsv.gz ./data/

How about https://s3.amazonaws.com/amazon-reviews-pds/readme.html ?
On Sat, Aug 12, 2023 at 5:30 PM Chris Fregly @.***>
wrote:

Change s3://amazon-reviews-pds/ => s3://dsoaws/
—
Reply to this email directly, view it on GitHub
https://github.com/data-science-on-aws/data-science-on-aws/issues/249#issuecomment-1676106673,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ACDEFM6UZX5W6W4OHFGRS5DXU7YVTANCNFSM6AAAAAA26PKMVU
.
You are receiving this because you authored the thread.Message ID:
@.***>


remove allowed failures from test suite

This updates the automated test suite to remove allowed failures from the Travis configuration.

The build timed out :-1:


Mindful Eating-Fabric crash w/ Farmer's Delight

Mod Name
mindfuleating
Mod Homepage
https://modrinth.com/mod/mindful-eating-fabric
Minecraft version
1.20.1
Describe the bug
Crash on worldload in survival
Steps to reproduce

Load Sinytra Connector, FFAPI, Farmer's Delight, Diet API Fabric & Mindful Eating - Fabric
Loads game successfully, regardless of 1.20.1 forge version
Game crashes with crash report on worldload due to a gui rendering error
"java.lang.NoClassDefFoundError: com/nhoryzon/mc/farmersdelight/registry/EffectsRegistry
at com.minecraftabnormals.mindful_eating.client.HungerOverlay.drawHungerIcons(HungerOverlay.java:96) ~[mindful_eating-1.1.0_mapped_srg_1.20.1.jar%23327!/:?] {re:mixin,re:classloading}"
...
Crash report:
https://gist.github.com/Liamgrayskull/24e10fbf7680fbf2b684594613ce80f5

Debug.log:
https://gist.github.com/Liamgrayskull/3cf0a5d513c9eb47e28dedf1c6f56ddf
Latest.log:
https://gist.github.com/Liamgrayskull/a2cf510ba7371bdcd456c0917d95e312
Logs
https://gist.github.com/Liamgrayskull/3cf0a5d513c9eb47e28dedf1c6f56ddf
Additional context
occurs regardless of connector extra's presence, and using the forge version of Diet API causes an instantaneous crash

Mindful eating fabric is not compatible with Farmer's Delight for Forge. You should be able to disable this integration by hiding FD's presence using Connector's hidden mods config option. The modid for Farmer's Delight is farmersdelight.


[terminal] Buffer created by :terminal does not hide when quit

According to the (WIP) docs, buffers created by :terminal should hide when they are closed.
Steps to reproduce

vim -u DEFAULTS
:terminal (optionally ^D the shell)
<C-w>:close<CR>
:ls and see the buffer listed!

David Ben Knoble wrote:

According to the (WIP) docs, buffers created by :terminal should hide when they are closed.
Steps to reproduce

vim -u DEFAULTS
:terminal (optionally ^D the shell)
<C-w>:close<CR>
:ls and see the buffer listed!

I was just starting to work on buffer behavior for terminals.
I added this to the docs (tentative):
When the buffer associated with the terminal is wiped out the job is killed,
similar to calling job_stop(job, "kill")
So long as the job is running: If the window is closed the buffer becomes
hidden.  The command will not be stopped.  The :buffer command can be used
to turn the current window into a terminal window.  If there are unsaved
changes this fails, use ! to force, as usual.
When the job has finished and no changes were made to the buffer: closing the
window will wipe out the buffer.
Before changes can be made to a terminal buffer, the 'modifiable' option must
be set.  This is only possible when the job has finished.  At the first change
the buffer will become a normal buffer and the highlighting is removed.
You may want to change the buffer name with |:file| to be able to write, since
the buffer name will still be set to the command.
There might be a few more situations to take care of...
I just implemented the behavior of the last paragraph.
--
Shit makes the flowers grow and that's beautiful
/// Bram Moolenaar --<EMAIL_ADDRESS>-- http://www.Moolenaar.net   \
///        sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \
\\  an exciting new programming language -- http://www.Zimbu.org        ///
\\            help me help AIDS victims -- http://ICCF-Holland.org    ///

It's possible patch ~838 fixes this (I only have through 823 currently).

This should work properly now.  Please file a new issue if you still see a problem.


V.23 Shadowrun: Sixth World - now compatible with new sheet code

Changes / Comments
Updated to work with new roll20 Enhanced Sheet code
Updated nuyen to be the nuyen symbol
Updated roll template background color to be the matching purple to the tabs to more fit the SR6WE theme
Roll20 Requests
Comments are very helpful for reviewing the code changes. Please answer the relevant questions below in your comment.

[ YES ] Does the pull request title have the sheet name(s)? Include each sheet name.
[ YES ] Is this a bug fix?
[ YES ] Does this add functional enhancements (new features or extending existing features) ?
[ NO ] Does this add or change functional aesthetics (such as layout or color scheme) ?
[ N/A ] If changing or removing attributes, what steps have you taken, if any, to preserve player data ?
[ N/A ] If this is a new sheet, did you follow Building Character Sheets standards ?

If you do not know English. Please leave a comment in your native language.

Character Sheet Info Roll20 Internal Use only.


Update ibrowse version

ibrowser v4.1.1 or lower cannot work on Erlang R18 by using deprecated API.
See also

https://github.com/cmullaparthi/ibrowse/issues/129

Thanks!


define attributes even if not present in the data

I have a scenario where I have data with a "week commencing" attribute, and for most weeks there is at least one data row. However, I want to ensure that the cross tab includes every week, even ones that will have a blank column. Is there a way to specify a list of attributes that must be used?

I think I mean attribute values rather than attributes. I am thinking of something like the inclusions parameter, but that actually includes values not necessarily present in the data.

This is not possible at the moment, no. The only rows and columns that get displayed are the ones which contain at least one matching cell in the input. If you want to force columns or rows to appear, you must have some kind of dummy row in the input.


Error in mixture properties

Caleb
Your efforts in producing Thermo is much appreciated. However, it appears that there is an error in your method for calculating the properties of a gas mixture. If I use a mixture and N2 & H2O of 0.9 & 0.1 as mol fractions and a total pressure of 100kPa then I find that there a dramatic drop in enthalpy at approx. 100degC to a level which is somewhat higher than N2 only. Dalton's law of partial pressures says that water should start to condense at 45.8C. Further cooling would reduce the vapour fraction of H2O along the saturation line.
Kind regards
Allan

Hi Allan,
Please see the updated documentation on the new Flash and Phase classes:
https://thermo.readthedocs.io/thermo.flash.html
If you use the new way you shouldn't run into any more problems.
Sincerely,
Caleb

CalebThanks for that, much appreciated.RegardsAllanOn 17/04/2021 2:19 pm, Caleb Bell @.***> wrote:
Hi Allan,
Please see the updated documentation on the new Flash and Phase classes:
https://thermo.readthedocs.io/thermo.flash.html
If you use the new way you shouldn't run into any more problems.
Sincerely,
Caleb
—You are receiving this because you authored the thread.Reply to this email directly, view it on GitHub, or unsubscribe.


Bug 1979263: [release-4.8] revert: creation of thick provisioned storage class in 4.8

Thick provisioning feature is now dev preview, hence removing
the sc creation.
Signed-off-by: Mudit Agarwal<EMAIL_ADDRESS>

/retest

/retitle Bug 1979263: [release-4.8] revert: creation of thick provisioned storage class in 4.8

/retest

Hi @agarwal-mudit , the changes look good...
Just for my clarification, you mentioned that 3 commits are reverted, but the whole Thick provision SC creation/implementation itself is removed. Do we really need to remove the implementation part, can we not just use the false parameter and not create Thick Provision SC?

Hi @agarwal-mudit , the changes look good...
Just for my clarification, you mentioned that 3 commits are reverted, but the whole Thick provision SC creation/implementation itself is removed. Do we really need to remove the implementation part, can we not just use the false parameter and not create Thick Provision SC?

Good idea, but I am not sure if that will create two instances for thin provisioned SC?
I will wait for @jarrpa also to comment, we can do whatever looks good to everyone.

Let me explain the commits here for the ease of review:

One go fmt commit, just to satisfy golang-ci
Two commits related to external storage are straight forward as the PRs for these had only these commits.
PR for the third commit (https://github.com/openshift/ocs-operator/pull/1140/commits) has 4 commits:

CSV changes for ManageCephDashboard  - Not included in this PR
CSV changes for metricsExporter -> monitoring  - Not included in this PR
refactor SC unit test to loop over SCs - Not reverted just fixed the expected number of sc
Create RBD StorageClass with thick provisioning  - Reverted without any issues.

Didn't face any merge conflict while taking the reverts.

/retest

/cherry-pick release-4.9


Top button in any set won't highlight on hover

See title

Fixed this one too, it was due to 'grab_focus' line in the toolbox


Demo execution

Hi,
I want to execute the demo, but I can't because many functions are commented. It is not clear how I can test the code.
Thank for your work. Regards.

I have found a temporary solution: revert 3 commits (to 61d8a2e91dd26db1b8a6b5a38d1e36b6303a24b7) where the demo code can be compiled.


Community Progress Report - Delete

As an analyst
I want to be able to delete a Community Progress Report row
So that I can correct for my mistakes
Description:
This ticket is to allow the user to delete a CPR record from the view
Acceptance Criteria:

Wireframe

[ ] When user clicks on the red x on the view page for the CPR, user sees Modal asking for confirmation
[ ] When user clicks 'Yes Delete' then modal disappears and the row with the CPR is deleted (soft delete in backend)
[ ] All data that were imported from the Excel file to the database are archived
[ ] When user clicks 'No Keep' then the modal disappears and the row with the CPR stays the same

Implementation Details

Hey team! Please add your planning poker estimate with Zenhub @AntBush @marcellmueller @rafasdc

@elliottSlee @Alifath57
I went to start this ticket but realized we have nothing linking the community progress report excel data to the form data unlike the SoW which has the original SoW and then the amendment numbers.
Is just a generic id linking the data okay or should we link them by the due date? What would we like to see in metabase?

@marcellmueller I think an id would work fine. Maybe ask @Alifath57 ?

@marcellmueller I think a generic id linking the data is ok.


Use message id as a identifier for duplication check mechanism

Currently, the client JSON RPC duplication mechanism uses the client JSON RPC ID as a unique identifier to detect duplicated client JSON RPC requests.
Since this approach doesn't guarantee the uniqueness of IDs and there's a chance of conflicts a new approach with higher entropy is introduced.
The new id is a sha256 function of the decrypted payload of the client request:
message_id = sha256(decrypted_payload)
Testing:

Make sure that backward compatibility is not broken
Cross-platform testing (js, swift, kotlin, flutter)

Shouldn't this issue be moved to WalletConnectSharp, since JSON RPC IDs are generated inside the Core and Network module? The Unity project cannot access/modify this behavior directly.
Here is where the id is currently generated in WalletConnectSharp:

TypeMessageHandler.SendRequest
JsonRpcRequest constructor (if id is null)
RpcPayloadId.Generate (can be replaced with new logic)

Yeah, I'm not aware of the Unity repo structure, so if it makes more sense to put this issue into Sharp repo, let's do it.

Moved it into WalletConnectSharp #130


[Bug]: Mappings are ignored when using stored procedures

What happened?
When REST enabling a stored procedure and using a mapping, it is ignored and an error is returned where it cannot find the column name. For example I have a stored procedure with 2 inputs name and job. If i put into the mapping that name is full_name, and pass full_name to the stored procedure, it cannot find that column where in a table, it would map full_name to name.
Version
0.8.52
What database are you using?
Azure SQL
What hosting model are you using?
Local (including CLI), Static Web Apps (SWA)
Which API approach are you accessing DAB through?
REST
Relevant log output
No response
Code of Conduct

[X] I agree to follow this project's Code of Conduct

hi @JetterMcTedder, thank you for reporting this issue! This was by design - mappings feature is currently only supported for views/tables. Stored Procedures do have some usage limitations as mentioned in this section:
https://learn.microsoft.com/en-us/azure/data-api-builder/views-and-stored-procedures#stored-procedures
That said, we can definitely enhance this as an improvement.


Any chance for a straightforward way to run some pipelines via CLI? Would be greatly appreciated.

Hi! Thanks for your interest in our work. Usually we recommend using the APIs provided by the Gradio demo as described in README.md. We will also add some example python scripts to show the direct usage of the pipelines, but this may not cover all the functionalities in the Web UI.

Thanks for the explanation!


Insert specific colors - HEX | RBG | HSL?

Is possible to insert specific colors in style2paints? Either in Hex, RGB or HSL?

The following feature may help you, which is not introduced in the official tutorial.
This feature is very useful for non-artist users.
After uploading a customized reference image, users can pick color from the thumbnail of the reference image at the upper left corner, by clicking a specific pixel of the thumbnail.

While the cursor moving across the reference image, current color under the cursor is shown here (at upper right corner):

And note that before using this feature, please try to pick color from the canvas (auto colorization result) first.

Thank you very much, this will be a great help for my next Recolored, it would be nice if made a little comment on this in the next tutorial update.
But it would be good that in the future versions will added a input for insert a specific color (code HEX).
In the end I did it through a command in the web browser console, I leave it here in case someone specifically requires it:
window.minecraft.set_cur_color([198, 164, 218]) // it's in RBG


"Clone as Yaml" for a Configmap fails with Internal Server Error

Version: master-head(dd102af17)
Steps:

Create a configmap "cmap1" by providing key/value
Clone the configmap using "Clone as Yaml" option
The Yaml file is displayed as below, change the name to "cmap2"

apiVersion: v1
data:
  k1: v1
kind: ConfigMap
metadata:
  creationTimestamp: "2020-05-12T18:06:28Z"
  name: cmap2
  namespace: default
  resourceVersion: "6064"
  selfLink: /api/v1/namespaces/default/configmaps/cmap1
  uid: 27ad9b9b-1eae-4dcf-9cb1-4063a87c3dbc

Hit "Create" button

Result:
It fails with "Internal Server Error" as below
{"type":"error","links":{},"code":"","message":"resourceVersion should not be set on objects to be created","status":500,"type":"error"}

Note: If the resourceVersion is removed from the yaml file, clone succeeds.

@codyrancher Based on outside convos, when cloning yaml, in metadata, we are only going to clone metadata.namespace field.

This will be resolved by https://github.com/rancher/dashboard/pull/650

Validated with master-head(1f4a2c388)
Steps:

Create a configmap "cmap1" by providing key/value
Clone the configmap using "Clone as Yaml" option
The Yaml file is displayed as below.

apiVersion: v1
binaryData:
  keyfile: azE9djE=
data:
  test1: val1
kind: ConfigMap
metadata:
  annotations:
    k2: v1
  labels:
    k1: v1
  name: ' '
  namespace: newns

Provide a name and the clone succeeds as expected.


Update container version to 23.01 in DFP docker-compose

Add dask
fixes #577

it's weird that some of the examples can use the dev container, but examples like DFP have to use a custom docker image based on a published image. it's also strange that we re-copy the example directory to the new image rather than using the example directory that is already published in the official release container.

it's weird that some of the examples can use the dev container, but examples like DFP have to use a custom docker image based on a published image. it's also strange that we re-copy the example directory to the new image rather than using the example directory that is already published in the official release container.

The DFP example is more complicated than the other examples since it requires starting other services like ML flow and we support running it from a Jupyter notebook. Because of this, it has it's own docker image and docker-compose.

@gpucibot merge


Add support for type erasures

This is a:

[ ] Bug Report
[x] Feature Request
[ ] Question
[ ] Other

Which concerns:

[ ] flow-runtime
[x] babel-plugin-flow-runtime
[ ] flow-runtime-validators
[ ] flow-runtime-mobx
[ ] flow-config-parser
[ ] The documentation website

What is the current behaviour?
Every function and binding gets tested for its type.

What is the expected behaviour?
Only functions and bindings that cannot be proven to already be correct needs to test the types.
For example, if the code is a Module, only the entry points should need to have type assertions (not entirely true, if there are any types involved there are more cases that needs checks).
For example:
export function f(x: number) {
  return g(1);
}

function g(x: number) : number {
  return x;
}

g does not need any assertions since the only way to get there is through f which already does the assertion.
Motivation: Performance. This would allow most code to ship with flow-runtime to production without any real performance issues.

hey @arv, we actually went down this road with babel-plugin-typecheck which removes any typechecks it can prove unnecessary at compile time. The problem is that you basically have to reinvent Flow proper to do this with any degree of certainty. It's not impossible but it's really a lot of work. Another alternative would be to have a mode that produces checks only on arguments to exported or specially commented functions


AutoTest edge cases

[x] If the requested deliverable doesn't exist (e.g., d71, input.delivId can become inconsistent with input.pushInfo.delivId).

[x] Cached results are not being returned for multiple requests to the same commit. Could be related to #61.

[x] pushInfo.timestamp is not correct; is the time of the commit, not the push event (see repoId: d0_s2z0b; took (waiting + execution): 20 hours and 50 minutes; commit: b40463e89c731cfd1cbc64c0345dafd4e541cd57)

These are now fixed; we can open more specific issues in the future for new problems.


doc: porting/arch: misc fixes

doc: porting/arch: add missing sections to overview list
doc: fixed already renamed _Cstart to z_cstart
doc: porting/arch: fixed missing stack object memory map

lol @nashif you had just requested my review and I probably would have had a couple suggestions 😅


Pull request workflows fail in test stage

Describe the bug
CI/CD workflows when triggered by pushing to a pull request will always fail in the Test stage since the push and pull request pipeline are in conflict to the API Rate limits. They should not be executed in parallel.

Fixed since since #40


Framepacing Issues Since Aquamarine Merge

Regression?
Yes
System Info and Version
 System/Version info
Issue present on latest commit: 57371b93a058d17affb0ca92f13b8d40582b3ea0
Not present on: f642fb97df5c69267a03452533de383ff8023570
Did not try any versions in between as I just wanted to play my game lol but I'm happy to help narrow this down further

Description
Something is amiss with frames being drawn to the screen. Certain groups of frames are drawn several times in a row,causing a stuttering effect in Elden Ring, but the stutter is not present in recordings when gameplay is captured via obs-vkcapture.
I tried different proton versions, disabling tearing and immediate window rules (I have them both enabled usually), and running the game without feral gamemode or obs-gamecapture running. The issue is present under all conditions. Rolling back to the last commit before the aquamarine merge makes the problem disappear so it's definitely a regression.
How to reproduce

Install hyprland
Run game
???
Profit

Crash reports, logs, images, videos
https://github.com/user-attachments/assets/18867845-5a2f-4283-afea-66ddff85b98c
This was captured using PipeWire screen capture since obs-vkcapture produced footage without the stutter.
The stutter in this particular clip may have been caused by some combination of using PipeWire and the notification that popped up, but this is the closest I could get to a recording of what actually happens. The stutter is not quite as egregious as what's seen in this clip but it is still quite noticeable and very annoying. It seems to trigger during specific attack animations and only last for a few seconds each time it happens, but it's really hard to confirm that since I can't get a proper video of it.

its probably #6964 and #6980

yes


log observed messages

Description
add logging to the observe package, assume that
every instance where a message is observed, it
also gets logged.
Merger may want to wait until logging to a file is the standard behavior, else the terminal might get messy/buggy.
Does this PR need a docs update or release note?

[x] :no_entry: No

Type of change

[x] :broom: Tech Debt/Cleanup

Issue(s)

closes #2061

Test Plan

[x] :muscle: Manual

@meain - can you file a ticket and look into enabling logging to a file by default? This will allow us to merge additional logging PRs such as this one.

Added https://github.com/alcionai/corso/issues/2076 to track writing logs to disk by default.

https://github.com/alcionai/corso/pull/2082 is now in, we can probably merge this in now. @ryanfkeepers


Unexpected asset names for some of ASP .Net Targeting Pack assets

At the aspnetcore "3.0.0-preview4-19172-03" blob storage drop point: https://dotnetcli.blob.core.windows.net/dotnet/aspnetcore/Runtime/3.0.0-preview4-19172-03
Some assets appear to be inconsistent with current naming conventions:
aspnetcore-targeting-pack-3.0.0-preview4-19172-03.deb
aspnetcore-targeting-pack-3.0.0-preview4-19172-03.tar.gz
aspnetcore-targeting-pack-3.0.0-preview4-19172-03.zip
I expected the assets' names to be:
aspnetcore-targeting-pack-3.0.0-preview4-19172-03-x64.deb [see the RPM asset name]
aspnetcore-targeting-pack-3.0.0-preview4-19172-03-linux-x64.tar.gz
aspnetcore-targeting-pack-3.0.0-preview4-19172-03-win-x64.zip
aspnetcore-targeting-pack-3.0.0-preview4-19172-03-win-x86.zip

cc @dougbu @mkArtakMSFT can you guys please assign?

@johnbeisner this issue is similar to #8806. Could you please help us understand the priority and urgency of this issue?

@dougbu
There is no urgency for this as we have implemented a work-around: https://github.com/dotnet/core-sdk/pull/1122

@anurse or @mkArtakMSFT I suggest we put this into a late-ish 3.0 milestone as a P1 or P2 bug.

I don't think it should be necessary to separate the targeting pack installers on non-Windows by RID / architecture. On Windows, the whole dotnet directory installs to different locations based on architecture, but I don't think we ever have this situation on non-Windows.

It is weird, though, if RPM and deb have different conventions.

On another side. Since there is no "feed" and we only have a flat folder with installers. The only way to discover the latest aspnet produced installers is by naming convention. It is extra complexity for some aspnet deb file has "x64" and some doesn't even though the content is agnostic.

I think making the change in this direction is the wrong way. The Windows installers are the odd ones, due to side-by-side x86/64 installs. Core-Setup should change instead.
Adding x64 to the names of the arch-agnostic artifacts (in particular Linux) could even go all the way to confuse end users. If someone wants to install an arm SDK from deb files, they would have to grab the deb named aspnetcore-targeting-pack-3.0.0-preview4-19172-03-x64.deb. They might assume x64 is a typo and look for an arm artifact which doesn't exist. (Then complain.)
Instead, I think we should drop the arch in Core-Setup for non-Windows Targeting Pack installers/packages. Not that I think it's urgent in that direction either.

Triage: Closing as won't fix. The naming here is intentional. Targeting packs are not RID, or even CPU arch, specific, so the RID was not included in the file name.
If targeting packs for NETCore.App or WindowsDesktop have RIDs in the file name, I would recommend they be removed for consistency.
cc @dagood

Forgot to mention -- I'm fixing the RPM for aspnetcore so it doesn't include "-x64". See https://github.com/aspnet/AspNetCore/pull/10593


Add country_code expectation for page

Increase Coveralls score...

Coverage increased (+0.3%) to 100.0% when pulling f61e195f7bd6ebe77ce029e53e9f6bed17d9f411 on add-page into e8e424e639559b658e73d89b87e505939c564272 on master.

@bruce-fs If, for all we know, the method always returns nil, then we don't need the method at all.
Either find a page that returns a non-nil country_code or remove the method from the repo.
Thanks.

Coverage increased (+0.3%) to 100.0% when pulling 275331c9957238891f774e526251417288496d52 on add-page into e8e424e639559b658e73d89b87e505939c564272 on master.

@bruce-fs Please also remove country_code from the CHANGELOG.
And meanwhile, you can change this line
## 0.2.14 - 2017/01/31

to
## 0.2.14 - unreleased

? Thanks.

Coverage increased (+0.3%) to 100.0% when pulling 7eb5dd409acaec079101489a6fa7f18dce9f0485 on add-page into e8e424e639559b658e73d89b87e505939c564272 on master.


[cherry-pick 7386] fix lm query fail when there are generated columns

ref #6518Signed-off-by: Lloyd-Pottiger<EMAIL_ADDRESS>What problem does this PR solve?
Issue Number: close #7383 #7385
Problem Summary:
What is changed and how it works?
when there are generated columns, the size of columns_to_read is less than table_column_infos, due to table_column_infos contains generated columns.
Add generated columns to analyzer.
Check List
Tests

[ ] Unit test
[ ] Integration test
[ ] Manual test (add detailed scripts or steps below)
[ ] No code

Side effects

[ ] Performance regression: Consumes more CPU
[ ] Performance regression: Consumes more Memory
[ ] Breaking backward compatibility

Documentation

[ ] Affects user behaviors
[ ] Contains syntax changes
[ ] Contains variable changes
[ ] Contains experimental features
[ ] Changes MySQL compatibility

Release note

None

/run-all-tests

/run-all-tests

/merge

/merge


Passenger: set module source path correctly for Passenger 5

Passenger 5 changed the location of its nginx module source, so Nginx fails to compile with Passenger 5. This fixes #360 — for me anyway.
Note that the other pull request on the same topic (inexplicably) does a version check for Passenger >= 5.0.19 — this will break for previous Passenger 5 versions, since the change in module location is at 5.0.0.

Sorry, @alambike's pull request at https://github.com/miketheman/nginx/pull/387 is better.


Issue with k8s.io/docs/tutorials/kubernetes-basics/explore-interactive/

This is a...

[ ] Feature Request
[x] Bug Report

Problem:
Missing an 'R' on Step 2 of Module 3 first paragraph.
Proposed Solution:
Add an 'R' to "ecall that Pods are running in an isolated, ... "
Page to Update:
https://kubernetes.io/docs/tutorials/kubernetes-basics/explore-interactive/

/cc @BenHall

@nikhita thanks - content is hosted with Katacoda, including the content here - so it's not obvious to find. For the record, the content for those tutorials is hosted at https://github.com/katacoda-scenarios/kubernetes-bootcamp-scenarios

@jekstrom thanks for the report! I'll get a fix up immediately and provide a PR link here

@BenHall I think we need you to look at the underlying content - the content in question is at https://github.com/katacoda-scenarios/kubernetes-bootcamp-scenarios/blob/master/4/step2.md - and appears to have the R that's missing in this report... I did verify that the R is missing in the deployed content.

@heckj Sorry, that looks like a bad merge/update on my side. Let me double check how that happened.
It's fixed now. Thanks for the report and looking into it.

@BenHall awesome, thank you!


Google Cloud SQL w/ PostgreSQL

The spring-cloud-gcp-starter-sql is easily configured for MySQL databases.
I was able to get it working against PostgreSQL too:
pom.xml:
        <dependency>
            <groupId>org.springframework.cloud</groupId>
            <artifactId>spring-cloud-gcp-starter-sql</artifactId>
            <version>1.0.0.BUILD-SNAPSHOT</version>
        </dependency>
        <dependency>
            <groupId>org.postgresql</groupId>
            <artifactId>postgresql</artifactId>
            <version>42.1.4</version>
        </dependency>
       <dependency>
            <groupId>com.google.cloud.sql</groupId>
            <artifactId>postgres-socket-factory</artifactId>
            <version>1.0.4</version>
        </dependency>

Then, application.properties:
spring.cloud.gcp.projectId=[[PROJECT-ID]]
spring.cloud.gcp.sql.instanceName=[[INSTANCE-ID]]
spring.cloud.gcp.sql.jdbcDriver=org.postgresql.Driver
spring.cloud.gcp.sql.jdbcUrl=jdbc:postgresql://google/[[DATABASE-NAME]]?socketFactory=com.google.cloud.sql.postgres.SocketFactory&socketFactoryArg=[[CONNECTION-NAME]]
spring.cloud.gcp.sql.userName=[[DATABASE-USER]]
spring.cloud.gcp.sql.password=[[DATABASE-PASSWORD]]

//cc:@joaoandremartins

This is really really cool, Daz! Thanks for trying it out.
I wonder if we need two different starters for MySQL and PostgreSQL, or just switch auto-configuration based on org.postgresql.Driver on the classpath. Or, include both drivers and select based on a user property.

It's almost (!) trivial to flip between MySQL and PostgreSQL instances.
The MySQL JDBC URL is the default (not needed) and IIUC takes the form:
jdbc:mysql://google/[[DATABASE-NAME]]?socketFactory=com.google.cloud.sql.mysql.SocketFactory&cloudSqlInstance=[[CONNECTION-NAME]]
The PostgreSQL JDBC URL must be specified:
jdbc:postgresql://google/[[DATABASE-NAME]]?socketFactory=com.google.cloud.sql.postgres.SocketFactory&socketFactoryArg=[[CONNECTION-NAME]]
and the code currently requires re-stating the following properties even though these are either explicitly or indirectly (in the connection) specified by the URL:
spring.cloud.gcp.sql.projectID=[[PROJECT-ID]]
spring.cloud.gcp.sql.instanceName=[[INSTANCE-ID]]
spring.cloud.gcp.sql.databaseName=[[DATABASE-NAME]]

Perhaps there should be an additional property:
spring.cloud.gcp.sql.databaseType=[MySQL|PostgreSQL]
spring.cloud.gcp.sql.databaseVersion=[[VERSION]]

and then it should be possible for it to construct the JDBC URL for all flavors of database that Cloud SQL supports.
Wrote up my (positive) experience on Medium:
https://medium.com/@DazWilkin/google-cloud-sql-4-ways-spring-a4f13ad32714

Submitted FR for "Cloud SQL Socket Factory for JDBC drivers" to be consistent in referencing Cloud SQL Connections: https://github.com/GoogleCloudPlatform/cloud-sql-jdbc-socket-factory/issues/49

Great stuff! Thanks Daz.
One thing is that if you use spring.cloud.gcp.sql.jdbcUrl, spring.cloud.gcp.sql.instanceNameisn't used, along withregionandinstanceConnectionName`.
It seems that [[CONNECTION_NAME]] is the same as [[INSTANCE_ID]].
I like the databaseType property to distinguish between MySQL and PostgreSQL. However, our starter will only specify one version of a database provider at a time (e.g, MySQL 5.x, not 8).

Ah... My mistake. Yes, you are correct on both:
spring.cloud.gcp.projectId=[[PROJECT-ID]]
spring.cloud.gcp.sql.jdbcDriver=org.postgresql.Driver
spring.cloud.gcp.sql.jdbcUrl=jdbc:postgresql://google/[[DATABASE-NAME]]?socketFactory=com.google.cloud.sql.postgres.SocketFactory&socketFactoryArg=[[CONNECTION-NAME]]
spring.cloud.gcp.sql.databaseName=[[DATABASE-NAME]]
spring.cloud.gcp.sql.userName=[[DATABASE-USER]]
spring.cloud.gcp.sql.password=[[DATABASE-PASSWORD]]

The provider requires databaseName even though it's duplicative of  jdbcURL.

Yep, that needs to be fixed, too...


Detect musicbots and demote them

Detect clients which sends over x minutes straight and claim them as musicbot.
MusicBots will be demoted and can be kicked out of the channel by verified clients (members)

Done by #32


JA3 and JA4 test adjustments and additions - v8

Previous PR: #1682
This PR introduces test cases for TLS and QUIC JA4 calculation, as well as some adjustments for JA3.
Changes to previous PR:

Rebased against current master.
Removed suricata.yaml where a simple --set is sufficient.
Add README.mds for JA4 tests that benefit from more explanation.
Remove superfluous file requirements.
Add requires in simple JA4 rules test.

Ticket
Redmine ticket: https://redmine.openinfosecfoundation.org/issues/6379

Why is CI green ?

Why is CI green ?

Hmm, why wouldn't it? I made sure that all the tests that require the new branch are skipped when the new JA3/4 features are not present in the Suricata version the tests are run with.


Test Conference

Conference Name
Test Conference
URL
https://examples.com
Conference Dates
06 Sept 2022
Conference Type
both
Conference Location
No response
CFP URL
No response
CFP Dates
No response
Conference Description
No response

Thank you for adding this event! \n We'll happily consider it for the next episode. \n\n The Issue autocloses but we'll be reviewing it at https://github.com/users/kjaymiller/projects/4/views/3


Enemy notes not glow

Describe your problem here.
How do I make the opponents notes not glow?
Are you modding a build from source or with Lua?
Lua
What is your build target?
Windows x64
Did you edit anything in this build? If so, mention or summarize your changes.
No response

like not glow?
Be more specific.

No animation on the character or have the notes go straight past the opponent's strumline

like not glow? Be more specific.

Yes that is what I mean.

You mean when the opponent hit the note then then the notes won't flash ?
if it is, then its kinda impossible

you can only do that in source

i did it without sorce and im not teaching cuz stupid

i did it without sorce and im not teaching cuz stupid

Bruh

Only thing I could think of is use some new note sprites that don't have the animations.


0.16.1

Fixes

(#46) Correctly locate common proto files.

Codecov Report

Merging #47 into master will not change coverage.
The diff coverage is n/a.

@@         Coverage Diff          @@
##           master   #47   +/-   ##
====================================
  Coverage      84%   84%
====================================
  Files           3     3
  Lines          75    75
====================================
  Hits           63    63
  Misses         12    12

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3854fcd...f417cef. Read the comment docs.


Fix overriding of cdef by cpdef method in .pxd file

See https://github.com/cython/cython/issues/543

@scoder, @robertwb: I am currently reviewing a Sage ticket by @jdemeyer which depends on this pull request. It would be helpful to have feedback, to know whether we can move on with it without having to maintain a Cython patch in the long run.
Thanks in advance!
Cheers,

The issue should be fixed in the long run; I haven't had a chance to look at the patch yet.

Yes, I think this is fine. Thanks for the fix Jeroen!


get_vertices requires rdp package

I don't know what is the optimal solution here. The rdp package makes the get_vertices function significantly faster but it does add a dependency.
The rdp package is only 5 functions and 180 lines of code. The last release of the rdp package was in 2016 but it is still working. It has an MIT license so we could also add the code to nlmod.
We could also optimize the get_vertices function and see what parts of the rdp package we actually need in this function.
What do you think is the best solution here?

add rdp as a depedency
add rdp code to nlmod
optimise the get_vertices function further and only use the parts of rdp that are actually necessary
....

1 vote for solution 3

Second vote for option 3

In the end went for option 2 for simplicity, by adding one file called rdp.py. Closing the issue.


Remove PCB from BOM generation

Closes #55.
This change removes the pcbdoc_file path from the generate_bom_for_altium util, and updates the logic to build and traverse the hierarchy of schdoc files instead. This is a breaking change, as the public api of the library has changed. This change also introduces the usage of configparser to read the PrjPcb file instead of using a regex, as this will be useful for future changes to the BOM generation. This is the first of three PRs that will change the BOM generation function.
The test file has to be updated because the new method produces the CSV in a different order.

@shrik450 did you try running this on any other test files? Searching for .PrjPcb on GitHub should provide some results.

Also, this is a bit out of scope of this PR, but the logic behind grouping and attributes is a bit flawed, at least with how we output the json data from tools.
Altium hard-codes a few attribute names, including one we use as part_id (see below) and one for "description". But we don't include it in attributes in the json, so the user can't access them using the attributes_map json. However, these are almost certainly what the user will want to group by (if they want to group components).

Also, this is a bit out of scope of this PR, but the logic behind grouping and attributes is a bit flawed, at least with how we output the json data from tools.

This is resolved in #84, including the part_id and description.

Currently, this will fail with schematics that are nested in a directory relative to the project file. I believe it's because the sheet reference in schematic we're using to build the hierarchy is relative to the schematic file (usually in the same directory, though not necessarily), but the file locations in the project file are relative to the project file.
So, I believe we just need to prepend the relative path from project file to the schematic file in the graph.
I added you to a demo here: https://test.allspice.dev/app_path/test/TestHierarchy

Thanks for the example - I tried this out myself and see the issue. I think resolving all paths to be relative to the project at all times is probably the best solution for this.
Do you mind if I clone that repo to AllSpice Mirrors and use it as a test case? It's a good case in general for relative paths.

@kdumontnu I've fixed the issue with the relative paths. Can you confirm if I can use that repo as a test case? If so, I will update this PR to include the test.

@kdumontnu I've fixed the issue with the relative paths. Can you confirm if I can use that repo as a test case? If so, I will update this PR to include the test.

Oh, yeah feel free to use that file in a test.


update back button

I can handle this, so please assign it to me.

 I can handle this, so please assign it to me.

go for it , Remember don't raise multiple issue.
got through this issue and update restart and back button.

@iamparas0 would like to work on it

@iamparas0 in your file something error please check
ERROR in ./src/App.css

i can fix this if you assign me


Fix an issue in SPDXCreatorInformation.equals

This request resolves issue #41 by adding the missing logic in the check for non-null, unequal create date values
My contributions are licensed under the Apache 2.0 License as required for contributions to this project

Pulled. Syncing.


fix: retrieve default value for non-string parameters

Should solve #59 and this issue from mkdocstrings-python

We should test simple defaults like strings, integers, floats and booleans, but also more complex expressions like DEFAULT_DICT["key1"], as you showed in #59 :slightly_smiling_face:


move_resource can use iswap hotel mode on STAR

lh.move_plate(plate, dest, use_arm="iswap_hotel_unsafe") to use commands PO and PI instead of PP and PR when using the STAR backend

based!

it is nice to be able to set open_gripper_position precisely, it can help avoid crashes on a tight hotel

added


Skipping it.each tests?

Is it possible to skip tests like a normal it test?
I don't seem to have any luck with it;  Doesn't appear to be a it.each.skip or a it.skip.each method.

There isn't, sadly.
I can take a look at adding it.each.skip, it should be possible; unless you'd like to take a shot at it?

Hopefully https://github.com/whitfin/it.each/pull/6 is acceptable. Please review pull request and provide feedback.

Closed by #6.


HtmlProcessingInstruction type missing

See title. There's no type annotation for HtmlProcessingInstruction (just a comment here: https://github.com/abelcheung/types-lxml/blob/main/lxml-stubs/html/_element.pyi#L228).
This class seems to be supported by lxml, and the project I'm working on uses this in our test cases (see https://github.com/PrairieLearn/PrairieLearn/pull/9356#discussion_r1474979010). I think the annotation for this should be added back to the stubs here.

It's fine for me, just that I'm really surprised it's actually been used. Will create a release after this change.


StackReference tutorial: formatting broken

File: docs/tutorials/aws/aws-ts-stackreference.md
Source in the examples repo.

Hi @Dominik-K
What do you mean broken? Does the code not work or is there some other issue you are running into?
I can fix up the issue
Paul

@Dominik-K yes I see the formatting issues :) I will fix those up! Thanks for pointing them out

This and several other tutorial formatting issues are due to https://github.com/pulumi/docs/issues/1091.  Closing this one to track there.


Gulp version

New Gulp Version

Hi @movibe , thanks for this PR.
I have looked at it but I am afraid it changed too much for my liking. For instance the move from client to public is not something I like to see.
All in all it is too big to merge right away. I am sorry for the effort you put into it.
For in the future it will be better to open an issue to discuss how to implement this.

It would make a good fork for someone who wants a GULP version :D

Hello @beeman , actually I'm changing all the original concept in the way the project is currently, according to some experiences in work I have done with AngularJS.
I think we can always improve a job that is already at an optimum level, but I think from now on we are moving on different paths.
Despite having made the suggestion to use the version Gulp instead of Grunt, which becomes much easier to understand and separation of duties responsibilities, you wished to continue the Grunt and I decided to continue the evolution of Gulp version only this change has become difficult to merge the two projects.
Some issues such as file structure and standards of the codes are not well defined and I really want to fix it, and make several improvements in the way the project is today.
So I'm unlinking my changes and making a Gulp version of the project, which will continue without merge requests.
I hope that my efforts will inspire other contributors participate in our projects.
I am very grateful that you have started this project that helped me and I hope that in the future we can get in a concession to join forces again.
A big hug

@movibe thanks a lot for your help on the project so far and I wish you good luck with your fork.
This project will most probably switch to gulp somewhere in the future, it's just not the right time for me to do it now. I understand you want to move on :)
Grande abraço!


CDI.setCDIProvider() throwing on a repeated set is inconvenient

The CDI.setCDIProvider() method has been documented to throw IllegalStateException on repeated call since version 1.0, but since version 2.0, the implementation in fact didn't honor this documentation. Multiple implementations started to silently depend on repeated setCDIProvider() being allowed.
Now that we actually fixed that for 4.1 (see #619 and #690), it turns out that this is very inconvenient. I know @manovotn and @Azquelt had problems with Weld, I stumbled upon this problem with ArC today as well.
We briefly discussed this on the CDI call yesterday and there was no objection to actually making this officially allowed (it was practically allowed since CDI 2.0).

(it was practically allowed since CDI 2.0).

Just to expand, the code allowed this starting CDI 4 until and including CDI 4.
The only part forbidding it was a piece of javadoc text IIRC.
The problems I encountered were mostly related to testing and I think it was similar for @Ladicek in Arc impl.
I am also +1 to make it allowed, we just need to look through docs in case there are other mentions of this.

Good point. The only place in the specification that talks about CDIProvider is https://jakarta.ee/specifications/cdi/4.0/jakarta-cdi-spec-4.0.html#provider, and that doesn't mention repeatable calls of setCDIProvider() at all. So I believe you're correct in that the only place mentioning this is the setCDIProvider() method javadoc.


saveAs Tool

Some way of "saving" the transformed image to PNG, etc.
For example, see:

http://stackoverflow.com/questions/11112321/how-to-save-canvas-as-png-image
https://github.com/eligrey/FileSaver.js

Technically this should not be hard to do - can you propose a UI design for this?

Closing since #34 was merged


dose not pause or stop wallpaper in background

love this app but it does not pause or stop wallpaper in background even when i playing games which means i'm using more ram im using wallpaper engine i also made a custom rule that when not focused to to pause/stop the app but it does not work

But TaskbarX hasn't anything to do with your wallpaper :/ You can enable "Pause TaskbarX in fullscreen mode" option inside the configurator... to pause the application while gaming.


Issue with k8s.io/docs/concepts/workloads/controllers/deployment/  Rolling Back a Deployment not right for k8s v1.11.3

This is a...

[ ] Feature Request
[x] Bug Report

Problem:
in "Rolling Back a Deployment" section, the number of new failed replicas has been to 1 but not 2 for k8s v1.11.3, I think the issue which "note" mentioned has been amended, the default maxUnavailable has been to 25%, not 1, so the new failed replicas not 2 but 1 as well.
Proposed Solution:
I think we need to fix the doc place between $ kubectl rollout status deployments nginx-deployment and To fix this, you need to rollback to a previous revision of Deployment that is stable.
also:
The Deployment is now rolled back to a previous stable revision. As you can see, a DeploymentRollback event for rolling back to revision 2 is generated from Deployment controller........

need to fix for rollback return.
Page to Update:
https://kubernetes.io/docs/concepts/workloads/controllers/deployment/#rolling-back-a-deployment

v.1.11.3

:+1:  I will fix this.


NSUncaughtExceptionHandler warning when using Crashlytics

Goals
Using Realm and Crashlytics in the same app
Expected Results
Should work
Actual Results
Code does seem to work, but throws [Crashlytics:Crash] Warning: NSUncaughtExceptionHandler is '_ZZ34RLMInstallUncaughtExceptionHandlervEN3$_08__invokeEP11NSException' on first access to Realm
Steps to Reproduce
See code sample -- dropping that into AppDelegate throws the warning
Code Sample
Fabric.with([Crashlytics.self])
let realm = try? Realm()
if let realm = realm {
    let test = realm.objects(TestEntity.self)
}

Version of Realm and Tooling
Realm version: 1.0.1
Xcode version: 7.3.1
iOS/OSX version: iOS 9
Dependency manager + version: pod 1.0.0

I guess this is happening because Crashlytics checks whether the uncaught exception handler is overridden, because it is relying on that itself, but it is commonly misused for purposes where there would be less dangerous solutions. 🐉
Realm is using this for good reasons: we need to tear down open write transactions. While we are doing that, we still ensure to call the previously configured exception handler as you can see here. So Crashlytics won't loose it's ability to report any exceptions in your app.

I don't think we actually need the uncaught exception handler anymore, as it was just a partial workaround for not having robust mutexes. Crashing while holding a write transaction shouldn't cause any problems now.

I think this is sufficiently resolved. While Crashlytics does throw a warning, Realm makes sure it passes on previously set exception handlers, so there's nothing broken here.
I'm closing this issue now. Feel free to re-open it if you want to discuss it further.

I think we should remove the uncaught exception handler if we don't need it anymore. So let's keep track of that by this issue. Promoted to T:Enhancement.


Time generator improvements

Add option to enable PeclUuidTimeGenerator via FeatureSet
Enable use of custom TimeGenerator implementations

Removes now unnecessary timeConverter and timeProvider
properties, setters, and getters in both FeatureSet and
UuidFactory as those are now exclusively used by the default
TimeGenerator
Adds a setTimeGenerator method on UuidFactory to override the
default time generator

:+1:


Suggestion: Remove metallb and use kube-vip for both control plane and for service loadbalancing

Kube-vip now can do both jobs so no need for metallb. This will simplify the install. also it will avoid arp spam from two different layer2 loadbalancers on the same network.
For reference: https://kube-vip.io/docs/about/features/

Thanks!  I am aware however due to MetalLB's popularity we are going to stick with it for now!


[Snyk] Security upgrade ubuntu from focal-20220801 to focal-20221019

This PR was automatically created by Snyk using the credentials of a real user.Keeping your Docker base image up-to-date means you’ll benefit from security fixes in the latest version of your chosen image.
Changes included in this PR

Dockerfile

We recommend upgrading to ubuntu:focal-20221019, as this image has only 8 known vulnerabilities. To do this, merge this pull request, then verify your application still works as expected.
Some of the most important vulnerabilities in your base image include:

Severity
Priority Score / 1000
Issue
Exploit Maturity

300
Double Free SNYK-UBUNTU2004-GNUTLS28-2965992
No Known Exploit

300
Improper Verification of Cryptographic Signature SNYK-UBUNTU2004-PERL-1930907
No Known Exploit

150
Time-of-check Time-of-use (TOCTOU) SNYK-UBUNTU2004-SHADOW-577863
No Known Exploit

150
Time-of-check Time-of-use (TOCTOU) SNYK-UBUNTU2004-SHADOW-577863
No Known Exploit

300
Out-of-bounds Write SNYK-UBUNTU2004-ZLIB-2975631
No Known Exploit

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.
For more information:
🧐 View latest project report
🛠 Adjust project settings

Learn how to fix vulnerabilities with free interactive lessons:
🦉 Learn about vulnerability in an interactive lesson of Snyk Learn.

closed as focal-20230308 is newer version.


How do you change the playback speed while video is playing

Current Behavior
I am trying to change the video playback speed while a video is playing but using a 'useState()' property results in the whole video screen refreshing and playback suspends or gets stuck.
Is there an example somewhere using React on how to do this.  I am not very familiar with React but setting any state properties seems to cause the ReactPlayer to refresh its screen which is no desirable.
Expected Behavior
I expect to be able to change the 'playbackRate' state property and react-player should change the playback speed accordingly without refreshing its screen and stalling playback.  And I say 'stalling' because the pause button is still showing but the video playback is stopped
Steps to Reproduce
Here is the essence of my code
const [playbackRate, setPlaybackRate] = useState(1);
  const handleSpeed = (event, newSpeed) => {
    setPlaybackRate(newSpeed)
  };
  const setPlayBack = () => {
    videoRef.current.playbackRate = playbackRate;
  };
  return (
    <AppCard height={1}>
      <Box mt={-5} mx={-6} position="relative" >
        <ReactPlayer
          ref={videoRef}
          onCanPlay={() => setPlayBack()}
          className={classes.reactPlayer}
          controls={true}
          url={authLink}
          playbackRate={playbackRate}
        />
        <Box zIndex="tooltip" position="absolute" right={0} top={0} >
        <ToggleButtonGroup orientation="vertical" value={playbackRate}
        exclusive onChange={handleSpeed}
        position="absolute" right={0} top={50}
        >

          <ToggleButton value={0.5} aria-label="list">
            <SlowMotionVideoIcon />
          </ToggleButton>
          <ToggleButton value={1} aria-label="module">
            <PlayCircleOutlineIcon />
          </ToggleButton>
          <ToggleButton value={2.0} aria-label="quilt">
            <FastForwardIcon />
          </ToggleButton>
        </ToggleButtonGroup>
        </Box>
      </Box>

Environment
N/A
Other Information
N/A

I am not very familiar with React but setting any state properties seems to cause the ReactPlayer to refresh its screen which is no desirable.

It sounds like something weird is happening here outside of ReactPlayer. Updating state should not cause a complete refresh. What type of URL are you trying to play? Are there any errors in the JS console?
Here is a very basic example of using useState to change the playback rate, which may help: https://jsfiddle.net/wm5L4oek/
Your use of videoRef and setPlayBack might be causing issues. You do not need to call setPlayBack at all as this happens internally when a video starts playing.
Also, videoRef is not a reference to the <video> element so doing videoRef.current.playbackRate = playbackRate will not achieve anything.


local deployment:  'utf-8-validate' module not found

When yarn start,
itmat-interface: Module not found: Error: Can't resolve 'utf-8-validate' in '/home/nguyentb/workspace/IDEA-FAST/ideafast_repo/ideafast-portal/node_modules/ws/lib'

That isn't important as we do not presently rely on web-sockets for IDEAFAST. I would suggest tracking this in the ITMAT repo.


Issue 471: Changing ascertainment to transform x and y vs just y

As the title this PR partially addresses #471 by changing the structure of Ascertainment to take a transform function rather than a link. It also updates the default here to use LogExpFunctions. This is then propagated through the ascertainment day of week helper. I've slightly expanded the test suite and added a check in the Ascertainment struct that just checks for the input having two arguments - these could be expanded at a later date.

Codecov Report
Attention: Patch coverage is 87.50000% with 1 line in your changes missing coverage. Please review.

Project coverage is 89.60%. Comparing base (1cb9530) to head (67026ee).

Files with missing lines
Patch %
Lines

...ObsModels/modifiers/ascertainment/Ascertainment.jl
83.33%
1 Missing :warning:

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #495      +/-   ##
==========================================
+ Coverage   89.56%   89.60%   +0.04%
==========================================
  Files          51       51
  Lines         738      741       +3
==========================================
+ Hits          661      664       +3
  Misses         77       77

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Will there be an image with Node 16.19.1?

The latest Node 16 LTS release is 16.19.1, but there isn't a cypress/base image with that version. cypress/factory doesn't honor the Node version argument (https://github.com/cypress-io/cypress-docker-images/issues/861) so there's no way currently to get the latest version of Node 16 in a Cypress image.

@kaiyoma, using the cypress/factory image would be the best way to get an image with this older version of node.


Modified DateField to allow input type to be set in props

Checklist:

[X] Documentation
[X] Tests
[X] Ready to be merged

Deploy preview for govuk-react processing.
Building with commit ddb86fb7044a75c0cfd24fab3105d87296a14817
https://app.netlify.com/sites/govuk-react/deploys/5ce712b51fb9530008da5d80

Codecov Report

Merging #666 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #666   +/-   ##
=======================================
  Coverage   99.67%   99.67%
=======================================
  Files         104      104
  Lines         607      607
  Branches       71       71
=======================================
  Hits          605      605
  Misses          2        2

Impacted Files
Coverage Δ

components/date-field/src/input.js
100% <ø> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c0b1c54...69606bd. Read the comment docs.

I'd ideally like to see an accompanying test.
Ideally with react-testing-library else with a snapshot.
Other than that, all good! Thanks for the contribution

also please rebase of master to resolve the yarn.lock file

Ok great, I'll add a test. Should I squish my commits?

Shouldn't be too much of a problem @jlrodney as they'll get squashed when merged.

I think the intention here was so you don't need type=number, which I've now fixed in another PR so closing this


File names get truncated too aggressively on mobile version

Description
This is especially bad with nested directories. It looks like ui is trying to fit in commit message which isn't shown in mobile version, looks like a hard 15 character limit.
I don't actually know why github removed commit messages for mobile version, i dislike that change, gitea does the same now
Screenshots

Gitea Version
1.18.0+dev-5-gcc42c6488
Can you reproduce the bug on the Gitea demo site?
Yes
Operating System
Android
Browser Version
Chromium 102 based

The issue appears to be:
https://github.com/go-gitea/gitea/blob/05a74e6e22984d31c61f38b1174882cf19b1f81c/web_src/less/_repository.less#L355
I'm not sure what the purpose of this 150px is...

I'm not sure what the purpose of this 150px is...

https://github.com/go-gitea/gitea/pull/6867
🤷🏽 I've tried to change it to dynamic width, seems like the HTML/CSS specification allows td elements to stretch to it's content, so enforcing the width of the parent has no luck and I'd prefer to not make this table scrollable on the y-as. So max-width probably would need something like calc(...) or just a higher limit.

gitea does the same now

There's really no room at all on mobile to show a proper commit message with the new actual proper mobile design of the file view. It will look cramped and messy. Otherwise we end up with max two words or with more vertical space.

I'm not sure what the purpose of this 150px is...

#6867
🤷🏽 I've tried to change it to dynamic width, seems like the HTML/CSS specification allows td elements to stretch to it's content, so enforcing the width of the parent has no luck and I'd prefer to not make this table scrollable on the y-as. So max-width probably would need something like calc(...) or just a higher limit.

yeah calc might work better. Maybe a max-width: 33% or something like that?

gitea does the same now

There's really no room at all on mobile to show a proper commit message with the new actual proper mobile design of the file view. It will look cramped and messy. Otherwise we end up with max two words or with more vertical space.

Perhaps it needs to be an accordion like <details>

yeah calc might work better.

Yeah but it will be a nightmare solution tbh because you cannot use anything relative to the parent, because HTML/CSS specification allows td elements to stretch to it's content in theory the parent can become infinity amount of width.

Maybe a max-width: 33% or something like that?

^ So that won't work.

Perhaps it needs to be an accordion like <details>

Seems like a good idea to me.

same thing happens when file is opened even though limit seem slightly higher there