Remove setuptools from the dependency list

https://github.com/FAIRmat-NFDI/pynxtools/blob/aaf3c50b18956b76b710cdb1525589bf9a36b81e/pyproject.toml#L38C6-L38C16
setuptools should not be listed as dependency, and this propagates to downstream projects and breaking the installation.
Please remove it.
See details and discussion via the following issue.
https://github.com/jazzband/pip-tools/issues/522

@lukaspie

Seems like setuptools is used directly in the tests here.
Maybe it can be moved to a dev dependency instead?

If setuptools is not installed, you cannot import pynxtools:
>>> import pynxtools
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/mnt/pcshare/users/Laurenz/AreaB/sed/poetry_envs/virtualenvs/sed-processor-3qnpZCFI-py3.9/lib/python3.9/site-packages/pynxtools/__init__.py", line 23, in <module>
    from pynxtools._build_wrapper import get_vcs_version
  File "/mnt/pcshare/users/Laurenz/AreaB/sed/poetry_envs/virtualenvs/sed-processor-3qnpZCFI-py3.9/lib/python3.9/site-packages/pynxtools/_build_wrapper.py", line 10, in <module>
    from setuptools import build_meta as _orig
ModuleNotFoundError: No module named 'setuptools'

So I would argue it needs to be in dependencies, or am I missing something? Actually, I had the issue recently that under certain conditions, poetry would remove setuptools if it is not mentioned explicitly by pynxtools.

If setuptools is not installed, you cannot import pynxtools:
>>> import pynxtools
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/mnt/pcshare/users/Laurenz/AreaB/sed/poetry_envs/virtualenvs/sed-processor-3qnpZCFI-py3.9/lib/python3.9/site-packages/pynxtools/__init__.py", line 23, in <module>
    from pynxtools._build_wrapper import get_vcs_version
  File "/mnt/pcshare/users/Laurenz/AreaB/sed/poetry_envs/virtualenvs/sed-processor-3qnpZCFI-py3.9/lib/python3.9/site-packages/pynxtools/_build_wrapper.py", line 10, in <module>
    from setuptools import build_meta as _orig
ModuleNotFoundError: No module named 'setuptools'

So I would argue it needs to be in dependencies, or am I missing something? Actually, I had the issue recently that under certain conditions, poetry would remove setuptools if it is not mentioned explicitly by pynxtools.

This is our build wrapper which assumes that it's build with setuptools. This should only occur when installed from the git repo (because it already build for the package), but I think we can also import setuptools conditionally there or ditch the build wrapper entirely (we added the nexus-version.txt as a fixed file anyways - the only difference would be that when you clone, change the definitions, don't update the file and install it in non-editable mode then the retrieved nexus version would be wrong... a slim but possible (and hard to debug) problem)

If setuptools is not installed, you cannot import pynxtools:
>>> import pynxtools
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/mnt/pcshare/users/Laurenz/AreaB/sed/poetry_envs/virtualenvs/sed-processor-3qnpZCFI-py3.9/lib/python3.9/site-packages/pynxtools/__init__.py", line 23, in <module>
    from pynxtools._build_wrapper import get_vcs_version
  File "/mnt/pcshare/users/Laurenz/AreaB/sed/poetry_envs/virtualenvs/sed-processor-3qnpZCFI-py3.9/lib/python3.9/site-packages/pynxtools/_build_wrapper.py", line 10, in <module>
    from setuptools import build_meta as _orig
ModuleNotFoundError: No module named 'setuptools'

So I would argue it needs to be in dependencies, or am I missing something? Actually, I had the issue recently that under certain conditions, poetry would remove setuptools if it is not mentioned explicitly by pynxtools.

It will be installed anyway since the following
requires = ["setuptools>=64.0.1", "setuptools-scm[toml]>=6.2"]

Poetry's behavior is annoying and arguable.
Making it an optional dependency is okay  I guess, at least it's not going to pollute downstreams.

Seems like setuptools is used directly in the tests here.
Maybe it can be moved to a dev dependency instead?

It seems it is only used for file copying. It can be done by stdlibs. The dependency is not compulsory in this regard if I am correct.

This should only occur when installed from the git repo (because it already build for the package),

This is also happening if installing directly from pypi. But @lukaspie is fixing it, no?

I was able to install an older commit hash which did not have setuptools listed as a direct dependency with poetry.
❯ poetry show
anytree             2.12.1                             Powerful and Lightweight Python Tree Data Structure with various plugins
ase                 3.23.0                             Atomic Simulation Environment
click               8.1.7                              Composable command line interface toolkit
click-default-group 1.2.4                              click_default_group
contourpy           1.2.1                              Python library for calculating contours of 2D quadrilateral grids
cycler              0.12.1                             Composable style cycles
fonttools           4.53.0                             Tools to manipulate font files
h5py                3.11.0                             Read and write HDF5 files from Python
importlib-metadata  8.0.0                              Read metadata from Python packages
kiwisolver          1.4.5                              A fast implementation of the Cassowary constraint solver
lxml                5.2.2                              Powerful and Pythonic XML processing library combining libxml2/libxslt with the ElementTree API.
matplotlib          3.9.1                              Python plotting package
mergedeep           1.3.4                              A deep merge function for 🐍.
numpy               1.26.4                             Fundamental package for array computing in Python
packaging           24.1                               Core utilities for Python packages
pandas              2.2.2                              Powerful data structures for data analysis, time series, and statistics
pillow              10.4.0                             Python Imaging Library (Fork)
pynxtools           0.3.2.post1.dev8+g273a0a14 273a0a1 Extend NeXus for experiments and characterization in Materials Science and Materials Engineering and serve as a NOMAD parser implementation for NeXus.
pyparsing           3.1.2                              pyparsing module - Classes and methods to define and execute parsing grammars
python-dateutil     2.9.0.post0                        Extensions to the standard Python datetime module
pytz                2024.1                             World timezone definitions, modern and historical
pyyaml              6.0.1                              YAML parser and emitter for Python
scipy               1.13.1                             Fundamental algorithms for scientific computing in Python
six                 1.16.0                             Python 2 and 3 compatibility utilities
tzdata              2024.1                             Provider of IANA time zone data
xarray              2024.6.0                           N-D labeled arrays and datasets in Python
zipp                3.19.2                             Backport of pathlib-compatible object wrapper for zip files

Thanks @TLCFEM, I agree that having setuptools in the dependencies is not great.
I fixed it with https://github.com/FAIRmat-NFDI/pynxtools/pull/370.
I replaced setuptools.disutils by nativ shutil and moved the build_wrapper out of the src folder.


How to Convert an nn model to nngraph model

As the title say, How to Convert nn model to nngraph model? Can anyone give a solution? thanks

Is there any tools can do this conversion automatically?


Fix zoom distortion

Now the background-position in the magnifier depends on the offset of the cursor within the image on the page. This allows us to place a picture of any shape on the page, and display a picture of another shape without distortion when enlarged. This allows us to load compressed small images onto the page, and display them in uncompressed large versions when zoomed in.
Issue: #10

Thank you very much.

Hi, I published v2.0.0 with these changes.


Knife bootstrap install_sh changed to url

Documentation is outdated. The option --bootstrap-install-sh changed to --bootstrap-url.

Can you open this against http://github.com/chef/chef-docs instead?


label microsoftteamsnew appNewVersion command errors

The following doesn't return a version string. When separating the components, xpath is issuing usage instructions indicating incorrect arguments
https://github.com/Installomator/Installomator/blob/0e3080e3408d89fe373fa6703e57f1eb2b7b6fe4/fragments/labels/microsoftteamsnew.sh#L8C21-L8C191
the following should work:
curl -fs https://macadmins.software/latest.xml | xmllint --xpath '/latest/package[id="com.microsoft.teams2.standalone"]/version/text()' - | awk '{print $1}'

Actually, Installomator do get the version in that line. The thing is that Installomator add -e to path as it is a function in Installomator.
So the line will be: curl -fs https://macadmins.software/latest.xml | xpath -e '//latest/package[id="com.microsoft.teams2.standalone"]/version' 2>/dev/null | sed -E 's/<version>([0-9.]*) .*/\1/'
Returning:
23272.2708.2452.9689

Ah cool - either or 🙂 (I'm used to xmllint --xpath so easier for me to troubleshoot).
does xpath have the concept of /text() to return the tag value rather than use sed to strip it out? Doesn't really matter I guess if it works but just curious.

We have a comment in the code to make the switch, but I think we found out it would break some labels, and would not work out. I know certain functions exist, but not certain how to add it, in a a line like this:
curl -fs "https://update.mactracker.ca/appcast-b.xml" | xpath -q -e '//rss/channel/item[last()]/enclosure/@url'

I found it:
curl -fs "https://update.mactracker.ca/appcast-b.xml" | xpath -q -e 'string(//rss/channel/item[last()]/enclosure/@url)'
I know it is string() but the descriptions I find, mentions that text() is a search tool.
Is that different in xmllint?


Fetch and mutate data from custom hook that uses React Query

:tada: This PR is included in version 1.5.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Utility to get all available ResourceBundles at runtime

A utility to get a list of all available ResourceBundles and PropertyResourceBundles at runtime.


Sharing: good Docz Example

Hey @pedronauck, just wanted to share the docz that I have for my project so that you could add those to a list of sites using docz. https://dfee.github.io/rbx
Cheers

Awesome example. Thank you for this. Any way to add things like typography and color pallets? Like it's possible in Catalog

In case anyone hasn't seen this in a related issue thread (https://github.com/zicodeng/docz-iframe-playground)
An iframe playground component :D https://github.com/zicodeng/docz-iframe-playground

cool. closing this for now. iframe looks cool https://github.com/pedronauck/docz/issues/789


When the starting point of an edge appears outside the canvas, the edge's animation will disappeared!

[x] I have searched the issues of this repository and believe that this is not a duplicate.

Reproduction link

Steps to reproduce
open the link, the animation between node3 and node4 is stoped, drag canvas to right, the node3 will show, and the animation will be fine.
打开链接, 节点3和4之间的动画停止了, 拖拽画布节点3出现时动画又正常了!
What is expected?
if the edge is inside of the canvas, the animation will play.
只要边没有完全隐藏  动画都应该正常播放.
What is actually happening?
when the starting point of an edge appears outside the canvas, the animation will stoped!
当边动画起始点落在画布之外, 动画就不能正常播放了!

Environment
Info

g6
3.4.10

System
mac 10.15.4

Browser
81.0.4044.138

I need an anmation from one node to another.
给边添加动画时出现了这种问题

暂时可以通过关闭局部渲染来解决：
graph.get('canvas').set('localRefresh', false)

v3.5.3 已解决。


Support doctrine/orm v3

Release notes: https://github.com/doctrine/orm/releases/tag/3.0.0
doctrine/orm:3 comes with some BC breaks which need to be considered in this module.

Fixed by: https://github.com/Codeception/module-doctrine/pull/26


chore(ci): Update builder to 24.04

Thank you for contributing to the Universal Blue project!
Please read the Contributor's Guide before submitting a pull request.

As long as everything builds with a checkmark, I'm happy to merge this. Unless there is a reason it shouldn't be due to kernel skew.


Guides - Use with third party tools

Stub.
Feel free to comment here if you have ideas on what this guide should cover. Link to potential resources too.

What does it mean to use third party tools? As webpack plugin? Or in the bundle?

Grunt, Gulp, Mocha, Karma. I guess it would be better to have specific how to for each. This is more like a seed article that can be split up.

Ok got it. Thanks.

There's actually already a corresponding guides page with [TODO]s for each of those tools already in case anyone is interested in pr-ing them.

I may try to tackle this. I feel like a fairly simple page with links to things like gulp-webpack and grunt webpack would do.


install Pillow 2.9

This fixes issues with Pillow
see output https://gist.github.com/aleksandra-tarkowska/11dd9cc0d8ec7b70f289fe33f7460f21
test training server deployed on http://<IP_ADDRESS>

Certainly looks good. Will test agains infra-testpr.

Are there any options for this that would prevent the gcc installation?

the only option is to give a param to disable scripts. then python-pillow will be chosen. Note pip installed pillow is needed to run script which is pretty much server dependency. I was also planning to refactor and decouple web (as manic suggested omero-python role).

Have you tested this on a native openstack cento7 image?

Another question: will any changes in the training playbook be needed re: https://trello.com/c/wEh5uadW/2134-re-do-pillow-on-frog-o-org?

@joshmoore I am not sure if I understand the question. This PR is to fix training playbook training-server.yml. I understand that will affect others, but as it is possible to disable scripts optionally, then person running playbook will be able to decide. I don;t know any other option to install pillow 2.9 without gcc.

Heads up. If we are not happy for bcc on prod then how you want to pop install zeroc-icepy ? https://github.com/ome/omero-install/blob/develop/linux/step01_centos7_ice_deps.sh#L23

Think we're into gcc/g++ regardless. Might just be something to make clear upfront.

This is being migrated to gh-105


feature request:

see https://github.com/nvim-telescope/telescope.nvim/issues/2688

Similar to https://github.com/gbprod/yanky.nvim/issues/116


catkin build error: ‘getMeshIntegratorConfigFromRosParam’ is not a member of ‘voxblox’

catkin build get error:
error: ‘getMeshIntegratorConfigFromRosParam’ is not a member of ‘voxblox’
voxblox::getMeshIntegratorConfigFromRosParam(nh_private)) {}
I search the function in voxblox and find nothing. Is there any version matching request for voxblox and c-blox?

Ah damn, I forgot I have an open PR on voxblox with this function. I will try to get this merged today. For the time being you will have to check out this branch on voxblox.
Thanks for drawing this to my attention.

This should be fixed now!


onDragging not working

Repro: https://codesandbox.io/p/sandbox/react-resizable-panels-forked-y7ncvz?file=%2Fsrc%2FResizeHandle.tsx%3A12%2C9-12%2C19
Originally reported in discussion #278

This regressed with 3eaf2f6c2690eb44ee5d104bac9ce783773f6bd0


add light weight ElfFeatureExtractor

Add a basic ELF feature extractor similar to the pefile one in support of #699.
Checklist

[ ] No CHANGELOG update needed

[x] No new tests needed

[x] No documentation update needed

merging so i can get a medium-scale run against ELF files before v3


Move website into own repo

In the interest of making Kue smaller, can we move the admin page into a second repo that connects to kue proper?

this has been discussed in other issues also, please search it and drop your comments, however I'm interested to see what would you get from this?

So I've just read over #339 and #153, and I don't see the core reason why we can't have a second repo. The present state of things feels like shipping MySql with PHPMyAdmin, where a great many people really don't want PHPMyAdmin installed even though some people find it useful (so they go install it).
This is also helpful for scaling up microservices that just do one thing rather than running many services with a walled off feature. For instance, this could even be taken to a place where the worker and promoters are their own packages (ie, kue-promoter, kue-worker, kue-web-gui) which can be composed into "kue" if need be to run all of these in the same node script execution.
After reading the tickets I'm not sure I can sway you on this. Until you can be brought around I'll try to keep a fork of the project.

simplicity is my high priority.
I won't resist separating the JSON API/Web console into another project, however then for small, simple installations user should be aware of installing two projects, with two configuration points...


feat: New Test Runner Model

Now we can easily select exactly which tests we want to run and what order to run the tests in.

:tada: This PR is included in version 0.324.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


[plot3d] Fix model when colormap has no name

The case where the colormap has no name (i.e., defined with a color LUT) was not handled in the parameter tree model

LGTM


If turn off the stream, the Bot will also be destroyed.

It is inconvenient if the Bot is destroyed when changing performers using a single stream key, so it should be kept idle.

This can be solved by adding the pause and unpause processes, maybe...

TopazBot 0.2.0
At least it worked, so that's good! But Idk...


Where can I find the source code for the REST API?

I'm a newbie :)

Source for the REST APIs is in the server namespace, under the controllers directory. Specifically, you can go to here.


Make 'cache = null' to help PoolThreadCache GC finalizer in PoolByteBuf.

Motivation:
PoolByteBuf deallocate not make cache = null, and recycle PoolByteBuf, so the PollThreadCache is always reachable by GC root. It is reachable until the cache is overridden at the next init.

@horizonzy can you please sign our icla and let me know once done ? https://netty.io/s/icla

@horizonzy can you please sign our icla and let me know once done ? https://netty.io/s/icla

done

@horizonzy thanks a lot!


refactor(ModmailConversationAuthor): convert to TS

This converts ModmailConversationAuthor to TypeScript

Failed Travis is a fluke - Reddit issues

Docs doesn't seem to work yet, would need to fix.
Atm it puts ModmailConversationAuthor into Global isntead of Classes

Docs are fixed. Though I noticed an issue with ModmailConversation that needs to be addressed with that conversion


Exclude rector configuration from code coverage report

Q
A

Is bugfix?
✔

New feature?
❌

Breaks BC?
❌

Fixed issues
-

Not need.


[DB Import] Replace bq mk by SQL in deploy command

The deploy command can automatically create the destination table in bigquery if it didn't exist beforehand. So far it was using the bq command line tool for that.
This change replaces the bq call by a SQL command because we will need the SQL command anyway for automatically creating tables with the bigquery emulator.

This is in preparation of #72 which is already using the sql_create_table YAML field to create tables in the bigquery-emulator.


Bug:

What happened?
A bug happened!
Steps to reproduce

step one...
step two...

What OS are you seeing the problem on?
No response
Relevant log output
Error while downloading file

Caused by:
   0: request or response body error: error reading a body from connection: An existing connection was forcibly closed by the remote host. (os error 10054)
   1: error reading a body from connection: An existing connection was forcibly closed by the remote host. (os error 10054)
   2: An existing connection was forcibly closed by the remote host. (os error 10054)

Location:
    D:\a\vibe\vibe\core\src\downloader.rs:55:30
App Version: 2.0.6
Commit Hash: 0ef5d7cb8e8b3e34a0dcce4f443b08ad9089efe2
Arch: x86_64
Platform: windows
Kernel Version: 10.0.22621
OS: windows
OS Version: 10.0.22621
Cuda Version: n/a
Models: ggml-medium.bin
Default Model: Not Found

{
    "avx": {
        "enabled": true,
        "support": true
    },
    "avx2": {
        "enabled": true,
        "support": true
    },
    "f16c": {
        "enabled": true,
        "support": true
    },
    "fma": {
        "enabled": true,
        "support": true
    }
}

תודה על הדיווח!
יש תקלה ברשת, או חסימה. נסה להוריד על רשת אחרת


Question about ACID support .

Hi
does Apache Hudi enable ACID transactions on the same table with separate spark/hive/presto clusters on S3 or hdfs ?
I am not able to find this kind or information  in the documentation.
Thanks

Hudi enables ACID on both S3 and HDFS, you would find some info about ACID under these talks http://hudi.apache.org/docs/powered_by.html#talks--presentations,  and we would highlight this feature in the website.

@leesf : Added https://issues.apache.org/jira/browse/HUDI-1111 to track. Assigned to you for now. Please feel free to reassign as you see fit.
Thanks,
Balaji.V


Update Examples

Delete old examples, add new & better ones, dot dot dot.
Untagged old commits:
https://github.com/cnguy/kayn/commit/6eab42e7e101182564ba2e483619747ef259670e refactor: prettier everything / clean up examples folder
https://github.com/cnguy/kayn/commit/e6aada48331384436cbe2456c142abdcb7350f78 docs (examples): Add verification example
https://github.com/cnguy/kayn/commit/c80a636ded87c2a42c98b88344f32faba64b74b3 fix (examples): beginIndex should start at 100 since we already proce…

Also going to separate ES6+ examples from ES5. Not sure why I didn't do that earlier.

https://discussion.developer.riotgames.com/questions/5645/totalgames-seems-incorrect.html
gonna add this impl to the examples too if it works, i would much prefer batch processing like this

Needs more v4 examples


Create pattern for clouds.name verification

Add a pattern configuration to the clouds.name CRD interface to limit
the available length and naming convention verification.
Adds some additional small verification components to the
ServiceTelemetry CRD.
Resolves: rhbz#2011603
Signed-off-by: Leif Madsen<EMAIL_ADDRESS>

No CI currently, but did an independent verification prior to merging this down.


net/http: transport closes healthy connections when pool limit is reached

What version of Go are you using (go version)?

$ go version
go version go1.15.5 linux/amd64

Does this issue reproduce with the latest release?
Yes
What operating system and processor architecture are you using (go env)?
go env Output
$ go env
GO111MODULE=""
GOARCH="amd64"
GOBIN=""
GOCACHE="/root/.cache/go-build"
GOENV="/root/.config/go/env"
GOEXE=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="linux"
GOINSECURE=""
GOMODCACHE="/go/pkg/mod"
GONOPROXY=""
GONOSUMDB=""
GOOS="linux"
GOPATH="/go"
GOPRIVATE=""
GOPROXY="https://proxy.golang.org,direct"
GOROOT="/usr/local/go"
GOSUMDB="sum.golang.org"
GOTMPDIR=""
GOTOOLDIR="/usr/local/go/pkg/tool/linux_amd64"
GCCGO="gccgo"
AR="ar"
CC="gcc"
CXX="g++"
CGO_ENABLED="1"
GOMOD=""
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -fmessage-length=0 -fdebug-prefix-map=/tmp/go-build196270523=/tmp/go-build -gno-record-gcc-switches"

What did you do?
When the http transport connection pool is full (no idle connections) and new client side requests are attempted, new connections fail (as expected), and long established connections start being closed.
The following code can be used to reproduce the problem
Server side (not really important, you can use any http server so long as the response is enough for the pool to eventually be full)
Sample server code
package main
import (
"fmt"
"io"
"io/ioutil"
"net/http"
"time"
)
type testHandler struct {
}
func (h *testHandler) ServeHTTP(w http.ResponseWriter, r http.Request){
fmt.Println("request received from", r.Host)
// simulates some processing. It can be any value that is high enough to allow the client connection pool to not have any idle connections
time.Sleep(time.Millisecond100)
io.Copy(ioutil.Discard, r.Body)
r.Body.Close()

w.Write([]byte("pong"))

}
func main(){
h := &testHandler{}
s := &http.Server{
	Addr:           "localhost:8053",
	Handler:        h,
}

s.ListenAndServe()

}

Client side code - here is where the problem can be seen
Example client side code
package main
import (
"bytes"
"context"
"fmt"
"io"
"io/ioutil"
"net"
"net/http"
"net/http/httptrace"
"time"
)
const (
dialTimeout = 1000 * time.Millisecond
clientTimeout = 200 * time.Millisecond
)
func main(){
c := getClient()
const numGoRoutines = 5

for {
	for i := 0; i < numGoRoutines; i++ {
		go makeRequest(c)
	}
	time.Sleep(time.Second*2)
}

}
func makeRequest(c *http.Client) {
rawRequest := []byte("ping")
ctx, cncl := context.WithTimeout(context.Background(), clientTimeout)
defer cncl()
endpoint := "http://localhost:8053/test"
trace := &httptrace.ClientTrace{
	DNSDone: func(dnsInfo httptrace.DNSDoneInfo) {
		fmt.Printf("DNS info %+v\n", dnsInfo)
	},
	GotConn: func(connInfo httptrace.GotConnInfo) {
		fmt.Printf("Got conn %+v\n", connInfo)
	},
	GetConn: func(hostPort string){
		fmt.Printf("Get conn %s\n", hostPort)
	},
	ConnectStart: func(network, addr string){
		fmt.Printf("Connect start %s %s\n", network, addr)
	},
	ConnectDone: func(network, addr string, err error){
		fmt.Printf("Connect done %s %s - %v\n", network, addr, err)
	},
}

req, err := http.NewRequestWithContext(ctx, "POST", endpoint, bytes.NewBuffer(rawRequest))
req = req.WithContext(httptrace.WithClientTrace(req.Context(), trace))

if err != nil {
	panic(err) // should never happen
	return
}

response, err := c.Do(req)
if err != nil {
	fmt.Println(err)
	return
}

io.Copy(ioutil.Discard, response.Body)

response.Body.Close()

}
func getClient() *http.Client {
t := http.DefaultTransport.(*http.Transport).Clone()

t.MaxIdleConns = 0
t.MaxIdleConnsPerHost = 5
t.MaxConnsPerHost = 5

t.DialContext = (&net.Dialer{
	Timeout:   dialTimeout,
	KeepAlive: 30 * time.Second,
}).DialContext

httpClient := &http.Client{
	Timeout:   clientTimeout,
	Transport: t,
}

return httpClient

}

What did you expect to see?
Note that I'm setting numGoRoutines = 5, matching the number of allowed idle and max connections per host
	t.MaxIdleConns = 0
	t.MaxIdleConnsPerHost = 5
	t.MaxConnsPerHost = 5

This is the healthy and stable case and trace shows  initial connection being established for each one allowed
Connect start tcp <IP_ADDRESS>:8053
DNS info {Addrs:[{IP:<IP_ADDRESS> Zone:} {IP:<IP_ADDRESS> Zone:}] Err:<nil> Coalesced:true}

and subsequently, as the program runs,
Got conn {Conn:0xc000386000 Reused:true WasIdle:true IdleTime:1.897671367s}
Got conn {Conn:0xc000010078 Reused:true WasIdle:true IdleTime:1.897726907s}
Got conn {Conn:0xc000216018 Reused:true WasIdle:true IdleTime:1.897619693s}
Got conn {Conn:0xc000010070 Reused:true WasIdle:true IdleTime:1.897554908s}
Get conn localhost:8053
Got conn {Conn:0xc0002bc008 Reused:true WasIdle:true IdleTime:1.898069612s}
Get conn localhost:8053
Got conn {Conn:0xc000010078 Reused:true WasIdle:true IdleTime:1.899032093s}
Get conn localhost:8053
Got conn {Conn:0xc0002bc008 Reused:true WasIdle:true IdleTime:1.899184074s}
Get conn localhost:8053
Got conn {Conn:0xc000010070 Reused:true WasIdle:true IdleTime:1.899394391s}
Get conn localhost:8053
Got conn {Conn:0xc000386000 Reused:true WasIdle:true IdleTime:1.899517661s}
Get conn localhost:8053
Got conn {Conn:0xc000216018 Reused:true WasIdle:true IdleTime:1.899666507s}
...

Reused:true is always the case for all "Got conn" message
The output of netstat also shows that the ports in use on both server and client side are always the same.
What did you see instead?
Now, say that numGoRoutines is set to 8 (you can also reduce the pool size, higher than the pool size. Anything that forces all connections to be in use), the trace output shows frequent reconnects
Longer trace logs
...

I noticed that goroutines trying to make a request block on the select in Transport::getConn, indicating that, by the time a connection is made available, there isn't enough time for the entire operation to complete and the context eventually expires in the write or read loops.
This causes a connection that is already in established to be closed and replaced, creating a cycle that rotates connections all the time.
The output of netstat confirms this behaviour
Is there a way around this? Can we control the timeout waiting for a connection from the pool separately from request/response timeouts?
Or even not blocking when the pool is full? Thanks

CC @bradfitz, @rsc, @empijei per owners.

i get the same problem, i find the connecttion pool is no usefull  when the request  timeout by context,because timeout will close the connection. can you have some methods to solve it？ @dmitshur

It's been two years any update? @dmitshur  @bradfitz @rsc @empijei


Update 2023-01-17-BB_Hospital_Districts.md

Add the zoom to this post because this is the one that is showing on the website.  I also had to add the ) after the image file name.  I forgot that and the pic wasn't showing.

I merged because it looked to have no conflicts.  I just copied what Helen had for zoom info on the other post.


Black noise in GLES2 when rendering on Oculus Quest

Godot version:
3.2.3
OS/device including version:
Android/Oculus Quest 1 GLES2
Issue description:
Black noise appears on surfaces. Enabling high precision (Enable High Float.Andoid) turns the noise into smoothened black areas. The issue only appears when deployed on the Oculus Quest. It doesn't show up in the editor or in desktop builds. The tiled rendering strategy of the Quest is clearly visible as the noise seems to be different on each tile.
A youtube demonstration with standard precision
A youtube demonstration with high precision
Minimal reproduction project:
GodotGuardian.zip
Related issues:
https://github.com/godotengine/godot/issues/43667
The artifacts look similar but this issue is not related to reflections. It appears even if I disable specularity on the material.
https://github.com/GodotVR/godot_oculus_mobile/issues/68
Again similar looking artifacts but this issue doesn't seem to be related to the material's roughness.

I first reported this issue in this forum thread: https://godotforums.org/discussion/comment/44401

This may be fixed by https://github.com/godotengine/godot/pull/44489.

Yes, #44489 should solve this issue. In fact, I first encountered this issue on Oculus Quest, and the fix was tested on Oculus Quest.)

Duplicate of https://github.com/godotengine/godot/issues/43667
Will be fixed by https://github.com/godotengine/godot/pull/44489


node-fetch - failed, reason: self signed certificate in certificate chain

When I run: node src/index.js GH-org -o SUSS -s
I get the following error:
FetchError: request to  failed, reason: self signed certificate in certificate chain
at ClientRequest. (C:\gh-migration-analyzer\node_modules\node-fetch\lib\index.js:1491:11)
at ClientRequest.emit (node:events:526:28)
at TLSSocket.socketErrorListener (node:_http_client:442:9)
at TLSSocket.emit (node:events:526:28)
at emitErrorNT (node:internal/streams/destroy:157:8)
at emitErrorCloseNT (node:internal/streams/destroy:122:3)
at processTicksAndRejections (node:internal/process/task_queues:83:21) {

Thanks for the report! Is your GHES instance using a self-signed certificate?

It is signed with an internal CA
On Wed, Mar 1, 2023 at 1:13 PM Sarah LeNguyen @.***>
wrote:

Thanks for the report! Is your GHES instance using a self-signed
certificate?
—
Reply to this email directly, view it on GitHub
https://github.com/github/gh-migration-analyzer/issues/18#issuecomment-1450787122,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABJHMHRCSIXFRKKMIMHYNFLWZ6UUXANCNFSM6AAAAAAVMLAPEI
.
You are receiving this because you authored the thread.Message ID:
@.***>

I did try number of possible fixes including export NODE_TLS_REJECT_UNAUTHORIZED='0'.  I also think the issue is coming from node-fetch. It looks to me like a Custom Agent needs to be used to support a self-signed certificate.

We'd be happy to take a look at a patch if you're open to giving it a shot.

Yes, I'm definitely open to testing a patch.

To be clear, we won't prioritize patching this, but if someone else wrote and patch, we'd be happy to take a look and consider merging. I'll leave this issue open in case someone else is open to writing a patch.


fix: update with pgrx upstream and remove compilation warning

What kind of change does this PR introduce?
After merged PR #205, there are some compilation warnings in supabase-wrappers, we need to deal with them.
What is the current behavior?
N/A
What is the new behavior?
N/A
Additional context
When upstream pgrx merged this PR, we need to remove the temporary warning stopper.

Thanks! Sorry for the trouble


Interference between autosave and eofnewline

By enabling both the features, one could ensure, that their work won't be accidentally lost and it also looks pretty. However, enabling both of them would insert newlines randomly while typing some text, as the automatic save is triggered every 8 seconds, and if one happens to type on the end of the file, the cursor jumps to the new line automatically, and text will be magically broken into two separate line.

Sorry if I’m here by mistake, but @zyedidia should know that micro, being launched as is with no configuration file present, does not add EOL after Ctrl+S is pressed. However the manual assures ```…will automatically add a newline to the end of the file if one does not exist”. That’s why I’m confused.


Fix enabling NavigationRegion3D saved disabled

This PR fixes issue #83364 by always registering the region when it enters the tree, and instead using region_set_enabled to control whether its enabled. The same logical changes have been applied to NavigationRegion2D.

Bugsquad edit, fixes: #83364

In the past a region was being removed entirely from the map when not enabled. These checks are leftovers from that time.

Thanks!


Fix trying to decode string token

When trying to create a token I was getting following error:
app_1       |   File "/usr/local/lib/python3.8/site-packages/applemusicpy/client.py", line 33, in __init__
app_1       |     self.generate_token(session_length)
app_1       |   File "/usr/local/lib/python3.8/site-packages/applemusicpy/client.py", line 59, in generate_token
app_1       |     self.token_str = token.decode()
app_1       | AttributeError: 'str' object has no attribute 'decode'

This should fix that error

Came here looking for exactly this - I too had to make this change for this to work. Python 3.9. Would also like to see this PR accepted.

Came here looking for exactly this - I too had to make this change for this to work. Python 3.9. Would also like to see this PR accepted.

Thanks for this. Merged.

Thanks for this. Merged.


Dynamics repeating groups error

Description of the bug
Values in the first repeating group affects the readonly and required properties of the second group
Steps To Reproduce

Clone the repository https://altinn.studio/repos/krt/krt-1230a-1
Start the app and log in as Sophie Salt
Go down to the repeating group "4 Forsikringsforetak som agenten formidler forsikringer for"
Click "Ja" on "4.1 Har forsikringsforetaket et norsk organisasjonsnummer?" and add a second group
Click "Nei" on "4.1 Har forsikringsforetaket et norsk organisasjonsnummer?" in the second group
Change the value of "4.1 Har forsikringsforetaket et norsk organisasjonsnummer?" in the first group and see that the field "4.5 Ev. annen ID" in the second group changes readonly and required status

Additional Information
Changing (1) should not affect readonly and required status of (3)

Link tt02: https://krt.apps.tt02.altinn.no/krt/krt-1230a-1/
Link to layout json: https://altinn.studio/repos/krt/krt-1230a-1/src/branch/master/App/ui/layouts/Innsending.json#L355-L575

Sadly, this looks to me like it's caused by your component IDs clashing with our internal state-keeping in app-frontend. When in a repeating group, a component can appear multiple times (i.e. have multiple instances), and for some reason we keep that state inside a mutated component id, in order to keep component IDs unique across multiple groups. So, if you have defined a firstName component, it gets the id firstName-0 in the first group and firstName-1 in the second group.
This is documented in detail here. When you've chosen to name your components like 4-5 and 4-5-1, app-frontend looks up the component 4-5-1 and finds it in the first group, as it's ambiguous if you meant the component 4-5-1 or 4-5 in the second group (which also has the generated id 4-5-1). The first one to be found here is probably the component in the first group, meaning your expression that should be evaluated in the context of the second group is actually evaluated in the first group (as that is where the first instance of your component ID was found).
This is part of the reason why I want to create a validator, as described in #648 (see As long as app-frontend-react puts the repeating group indexes into the component ID, we should show warnings when component IDs could be misunderstood as having repeating group indexes (i.e. matching <something>-<short number>)). Yes, this is a code smell. Yes, we want to fix this. No, it's too ingrained in how app-frontend works in regards to repeating groups right now to really fix properly right now, and we'd like to fix this once and for all in something long-term, like #345.
For now, I suggest (as I believe I've suggested before) that you name your component something else that does not clash with our internal state. Sorry!

I agree that the long term goal would be to not have these kind of requirements on user supplied ids. Would it be hard to change the "reserved" suffix from -{index} to -internal--repeatingGroup#{index}? Seems like that will make this kind of clashes much less likely, and work great as a stop-gap-messure.

@ivarne Sadly, yes, that would be hard. It's mostly about test coverage and safety (i.e. try search-replacing a single dash in the entire codebase and make sure you caught all the code paths that used a dash for this thing). It could absolutely be a short-term solution, but right now it's much easier to just change the component IDs. I belive this wasn't caught as a likely problem, since Studio always used to generate long UUIDs as IDs at the point in time this was first implemented.

In #758 I try to indicate which component IDs are problematic via the regex in the layout JsonSchema. I hope this will be somewhat helpful, at least!


send: flush stdout after displaying code

Fixes https://github.com/warner/magic-wormhole/issues/108
Apparently python defaults to buffering stdout when not outputting to
the terminal. It would be better IMHO if every line of stdout were
autoflushed, but based on
http://stackoverflow.com/questions/107705/disable-output-buffering
there's not a really good way to accomplish that in python.

Current coverage is 85.87% (diff: 100%)

Merging #109 into master will increase coverage by 0.10%

@@             master       #109   diff @@
==========================================
  Files            20         20
  Lines          2894       2895     +1
  Methods           0          0
  Messages          0          0
  Branches        411        411
==========================================
+ Hits           2482       2486     +4
+ Misses          311        310     -1
+ Partials        101         99     -2

Powered by Codecov. Last update ec3599f...8bec792

Rats, even with from __future__ import print_function, python2.7 rejects flush=True. I want to keep this py2+py3-compatible, so that's out.
Happy to land this, although I think I'll change it to args.stdout.flush() to support the case where it's not writing to the real stdout. I'll have to test that first, make sure the StringIOs used in testing support flush.

Setting PYTHONUNBUFFERED=1 also causes Python to not buffer stdout (also, with -u). ...but I think you still have to do "something complicated" like re-opening stdout to get the currently-running Python to change its behavior:
sys.stdout = os.fdopen(sys.stdout.fileno(), 'w', 0)

(from http://stackoverflow.com/questions/107705/disable-output-buffering/1736047#1736047)


Vagrant: Use salt_call_args instead of minion_id

The hacky minion_id method to pass file-root and pillar-root to
salt-call does not work since Vagrant 1.8.3.
If Vagrant accepts mitchellh/vagrant#7836 , this PR will use the new
argument. It also sets the hostname using the appropriate option,
superseeding #248.
DO NOT MERGE until Vagrant accepts the PR, and releases a new version.

This change is

The upstream PR mitchellh/vagrant#7836 was superseded by mitchellh/vagrant#8927, which has been merged, so this should be available when the next version of Vagrant is released.
@jarondl, are you interested in reviving this PR when that happens? It will need to be updated and rebased on top of master, and the docs will need to be updated (the docs/salt.md file in this repo) as welll.

:umbrella: The latest upstream changes (presumably #729) made this pull request unmergeable. Please resolve the merge conflicts.

Superseded by #729. Thanks again @jarondl for your initial work here!


Unsupported array dtype in compute forward

Describe the bug
When computing a forward solution on HCP MEG data (following the tutorial), Numba complains about a dtype.
Steps to reproduce
I'm copying and pasting code from the MNE-HCP tutorial here
https://mne.tools/mne-hcp/auto_tutorials/plot_compute_forward.html#sphx-glr-auto-tutorials-plot-compute-forward-py
Expected results
I expected the mne.make_forward_solution call to succeed.
Actual results
>>> fwd = mne.make_forward_solution(info, trans=head_mri_t, bem=bem_sol, src=src_subject)
...
TypingError: Failed in nopython mode pipeline (step: nopython frontend)
non-precise type pyobject
During: typing of argument at /Users/duke/miniforge3/lib/python3.9/site-packages/mne/forward/_compute_forward.py (132)

File "../../miniforge3/lib/python3.9/site-packages/mne/forward/_compute_forward.py", line 132:
def _do_lin_field_coeff(bem_rr, tris, tn, ta, rmags, cosmags, ws, bins):
    <source elided>
    """
    coeff = np.zeros((bins[-1] + 1, len(bem_rr)))
    ^

This error may have been caused by the following argument(s):
- argument 1: Unsupported array dtype: >i4

I guess this may be an m1 arm64 issue about integer sizes but not sure.  This is Numba running natively and not through Rosetta 2 x86_64 emulation.
Additional information
Platform:         macOS-12.3.1-arm64-arm-64bit
Python:           3.9.7 | packaged by conda-forge | (default, Sep 29 2021, 19:24:02)  [Clang 11.1.0 ]
Executable:       /Users/duke/miniforge3/bin/python3
CPU:              arm: 10 cores
Memory:           Unavailable (requires "psutil" package)
mne:              1.0.2
numpy:            1.20.3 {blas=NO_ATLAS_INFO, lapack=lapack}
scipy:            1.7.3
matplotlib:       3.5.0 {backend=module://matplotlib_inline.backend_inline}

sklearn:          1.0.1
numba:            0.54.1
nibabel:          3.2.2
nilearn:          Not found
dipy:             Not found
cupy:             Not found
pandas:           1.3.4
pyvista:          Not found
pyvistaqt:        Not found
ipyvtklink:       Not found
vtk:              Not found
PyQt5:            Not found
ipympl:           Not found
pooch:            v1.6.0

mne_bids:         Not found
mne_nirs:         Not found
mne_features:     Not found
mne_qt_browser:   Not found
mne_connectivity: Not found

Does your jit wrapper default to nopython mode?

Yes and this is intentional. I think we should make sure that the bins[-1] is a type Numba can handle. It's not immediately clear to me why it wouldn't be, but it should be easy enough to fix.
If you put the @jit decorator back in place, but one stack level up you pass bins.astype(int) or bins.astype(np.int64) does it work? If so, this is effectively what we want to accomplish, and we need to figure out why bins is not one of these types for the HCP data...

bins.dtype is int64, and passing bins.astype('i') doesn't work either. The relevant code up stack calls this with a genexpr which doesn't work in the debugger.

ah, the error-message explains why: >i4 is a big-endian dtype.

Oh I can't count/read, it's not the bins it's the tris that have >i4 (this is arg 1). If you .astype(int) or .astype(np.int64) this does it work?

yes, surf['tris'].astype('i') does the trick.


chore(deps): remove unused concurrently dependency

Description:
Remove unused concurrently dependency
Motivation and Context:
Keep codebase as lean as possible
How Has This Been Tested?
Manually
Types of changes:
Deps update
Checklist:

[x] My code follows the code style of this project.
[x] I have reviewed and updated the documentation accordingly.
[x] I have read the CONTRIBUTING document.
[ ] I have added tests to cover my changes where needed.
[x] All new and existing tests passed.
[x] My commits have been squashed into a concise set of changes.

Coverage remained the same at 20.132% when pulling 535a12c7715829c1041ec06d083d41c88e9ceeba on mrfelton:chore/remove-concurrently into 3d963f46e952db48bb5e260349d65a44817852a3 on LN-Zap:master.


gRPC plugin framework should be able to recover from panics

Requirement - what kind of business use case are you trying to solve?
We are implementing a custom gRPC-based storage plugin as per this doc.
Problem - what in Jaeger blocks you from solving the requirement?
There are two related problems:

When gRPC plugin panics the reason for panic is not shown in Jaeger logs, making the cause very hard to identify (related to: #1529)
When plugin panics it is not restarted, so Jaeger enters an unusable state

Impact:

Makes it very hard to make any plugin prod-ready
Makes developer experience of writing a plugin very frustrating
Plugin code becomes littered with defer/recover to prevent it from fully crashing and display helpful debug info

Proposal - what do you suggest to solve the problem or improve the existing situation?
Reason and a stacktrace should be already dumped into stderr of a plugin process at the time of panic, so Jaeger should be able to capture and log it.
Crashed plugins should be restarted.
Any open questions to address

Plugin framework is just https://github.com/hashicorp/go-plugin
I don't know if it supports recovery from plug-in crashes.

I'd like to pick this one up. I have some experience with this.

Having some issues with a gRPC storage plugin I'm writing and really struggling to get good reason/stack data out.
@radekg or anyone else -- any suggestions on how to better get visibility?

@radekg what solution were you thinking about?
I'm wondering if it would be best to simply crash/exit with an error code, so k8s/systemd would restart jaeger and normal alerting would detect the issue.

We would know that nothing is left behind after the crash, the state would be clean
We do not have to think about backoff, delay, metrics or anything like that

On the other hand, since the plugins are isolated, one could argue that we don't have to worry about the first case, and the second case might not be relevant because the process can't do anything useful without a working storage plugin any way.

Hi @chlunde. It's been a while since the last time I looked at this. The go-plugin implements a ping message in the protocol. Apparently that message can be used to find out if the plugin is running. That would have been the route I would have taken.
IMHO, restarting the complete collector seems to be a bit heavy handed.


Use of auto to prevent collisions between std and boost shared pointers in Kinematics

This PR addresses the issue I opened here: #128

Thanks, I tried this on my setup as well and it worked (Ubuntu 18.04, ROS Melodic, kinetic-devel branch of the repository)!


[Burn-P3+ Bug]: Projecting the entire fuel grid is inefficient, can be sped up with a spot check

Contact Details
<EMAIL_ADDRESS>What happened?
Across all three modules we check that the fuel grid can achieve WGS 84, unfortunately we do that by projecting the entire grid. This can be greatly enhanced with the following.
# Ensure fuels crs can be converted to Lat / Long
test.point <- vect(matrix(crds(fuelsRaster)[1,],ncol=2), crs = crs(fuelsRaster))

# Ensure fuels crs can be converted to Lat / Long
if(test.point %>% is.lonlat){stop("Incorrect coordinate system. Projected coordinate system required, please reproject your grids.")}
tryCatch(test.point %>% project("epsg:4326"), error = function(e) stop("Error parsing provided Fuels map. Cannot calculate Latitude and Longitude from provided Fuels map, please check CRS."))

PRs to come.
What component are you seeing the problem on?
No response
Relevant log output
No response
Approvals Process

[ ] Testing For Issue
[ ] Merge

Fixed in #35


Various tweaks for 1.2.0

All of these are low-risk changes, I'm comfortable with merging them for 1.2.0 final.

Higher risk changes will be part of another PR :)


Capture traffic from a specific interface

Is there any way to capture traffic from a specific interface with NetfilterQueue?

Yes, netfilter_queue will give you the packets matched by your iptables rule. So where the readme says:
iptables -I <table or chain> <match specification> -j NFQUEUE --queue-num <queue number>

then <match specification> is something like:
-i eth0

For example:
iptables -I INPUT -i eth0 -j NFQUEUE --queue-num 0

Thank you very much.


Token finder

how to find token for add in .env

All the keys that are necessary in .env can be found in env.template, in the root of the project!


Display elapsed Time in minutes

Hi,
For tests that take a long time, the Time variable in seconds is not very useful. Is it possible to display the elapsed time in minutes?
For instance, right now my comment is displayed like this:

Tests
Skipped
Failures
Errors
Time

199
0 :zzz:
0 :x:
0 :fire:
595.039s :watch:

It would be nice if there was an option when setting up the workflow to have it displayed like this:

Tests
Skipped
Failures
Errors
Time

199
0 :zzz:
0 :x:
0 :fire:
9.91min :watch:

Add this feature, you can just run MishaKav/pytest-coverage-comment@main or use<EMAIL_ADDRESS>
Thank you

That's awesome, thank you very much!


[BUG] Community Partners

Description of the bug
When we hover on Community Partners cards . It goes on top of navbar . Technically it should be under navbar on hovering also.
Please add screenshots (if applicable)
https://github.com/WebXDAO/WebXDAO.github.io/assets/85991449/f02cb6a6-d9b2-4ab9-bd77-f85d1300ae93
Add any other context about the problem here
No response
Code of Conduct

[X] I agree to follow this project's Code of Conduct

Assign this issue to me under GSSOC'23.

@parthpathakpp1 assigning it to you.

I have raised a PR https://github.com/WebXDAO/WebXDAO.github.io/pull/410


bug: regex anti pattern

Hey all, can take a stab to fix this but this seems like an anti pattern here to wrap a regex that could contain a bunch of specific regexes into a literal string in this line. Currently giving me an issue where I am explicitly building my strings for a .re_search call with escape characters and groups.
Essentially I am trying to query on a column value that has ( and ) in it that is in the column field with name some_message_((&some_signal)))
SELECT *
FROM `my_project.my_dataset.my_table`
WHERE REGEXP_CONTAINS(`field`, '(some_message_\\(\\(&some_signal\\)\\))')

is the bigquery query I can write and it works totally fine in the console (and the regex I build in python also works fine), but when I pass the regex into ibis, which is everything in the right string in the regexp_contains call,
it spits out a query like:
SELECT *
FROM `my_project.my_dataset.my_table`
WHERE REGEXP_CONTAINS(`field`, r'(some_message_\\(\\(&some_signal\\)\\))')

which is not helpful.

Not sure if this is an anti pattern.
Per https://cloud.google.com/bigquery/docs/reference/standard-sql/lexical#literals

Raw string | R"abc+"r'''abc+'''R"""abc+"""r'f\(abc,(.*),def\)' | Quoted or triple-quoted literals that have the raw string literal prefix (r or R) are interpreted as raw/regex strings.Backslash characters () do not act as escape characters. If a backslash followed by another character occurs inside the string literal, both characters are preserved. A raw string cannot end with an odd number of backslashes.Raw strings are useful for constructing regular expressions.

Are you finding that ibis is basically double-escaping these characters?

I explicitly build the string '(some_message_\\(\\(&some_signal\\)\\))' and then pass it into the ibis re_search and when I compile the query ibis creates it puts an "r" infront of the string, which doesn't match any strings in the column I am searching for. Maybe should be a flag in that function to ensure the user knows the string they are passing into ibis will be interpreted as a raw string vs not?


feat(DXP-761): remove multiple type properties from models

Description
Remove multiple types from models and test
Story
JIRA-XXX
Related PR's
Generator
Verify

[x] Code runs without errors
[x] Tests pass with 100% coverage

Closed in favor of #105


fix: support auth without tls

Redis's auth is not related with SSL, a non-ssl connection can have auth too.

added a integration test for auth without tls.

Need reopen this pull request


x/tools/refactor/satisfy: LHS reports a named Type, not an interface

Go version
go version go1.22.0 darwin/amd64
Output of go env in your module/workspace:
GO111MODULE=''
GOARCH='amd64'
GOBIN='/Users/aggnolek/go/bin'
GOCACHE='/Users/aggnolek/Library/Caches/go-build'
GOENV='/Users/aggnolek/Library/Application Support/go/env'
GOEXE=''
GOEXPERIMENT=''
GOFLAGS=''
GOHOSTARCH='amd64'
GOHOSTOS='darwin'
GOINSECURE=''
GOMODCACHE='/Users/aggnolek/go/pkg/mod'
GONOPROXY='*'
GONOSUMDB='*'
GOOS='darwin'
GOPATH='/Users/aggnolek/go'
GOPRIVATE='*'
GOPROXY='https://proxy.golang.org,direct'
GOROOT='/Users/aggnolek/sdk/go1.22.0'
GOSUMDB='sum.golang.org'
GOTMPDIR=''
GOTOOLCHAIN='auto'
GOTOOLDIR='/Users/aggnolek/sdk/go1.22.0/pkg/tool/darwin_amd64'
GOVCS=''
GOVERSION='go1.22.0'
GCCGO='gccgo'
GOAMD64='v1'
AR='ar'
CC='clang'
CXX='clang++'
CGO_ENABLED='1'
GOMOD='/Volumes/workplace/TwitchMako/src/TwitchMako/go.mod'
GOWORK=''
CGO_CFLAGS='-O2 -g'
CGO_CPPFLAGS=''
CGO_CXXFLAGS='-O2 -g'
CGO_FFLAGS='-O2 -g'
CGO_LDFLAGS='-O2 -g'
PKG_CONFIG='pkg-config'
GOGCCFLAGS='-fPIC -arch x86_64 -m64 -pthread -fno-caret-diagnostics -Qunused-arguments -fmessage-length=0 -ffile-prefix-map=/var/folders/x7/2f8ynt3954s4y78yt_54v9fr0000gs/T/go-build3901012278=/tmp/go-build -gno-record-gcc-switches -fno-common'

What did you do?
go.mod
module scratchpad

go 1.21

require (
	github.com/stretchr/testify v1.8.4
)

example2/main.go
// Code generated by mockery v0.0.0-dev. DO NOT EDIT.
package main

import (
	context "context"

	mock "github.com/stretchr/testify/mock"
)

type ExampleType struct {
	mock.Mock
}

func (_m *ExampleType) ExampleFunction(ctx context.Context, param1 string) bool {
	ret := _m.Called(ctx, param1)

	var r0 bool
	if rf, ok := ret.Get(0).(func(context.Context, string) bool); ok {
		r0 = rf(ctx, param1)
	} else {
		r0 = ret.Get(0).(bool)
	}

	return r0
}

func NewExampleTypeChecker(t interface {
	mock.TestingT
	Cleanup(func())
}) *ExampleType {
	mock := &ExampleType{}
	mock.Mock.Test(t)

	t.Cleanup(func() { mock.AssertExpectations(t) })

	return mock
}

func main() {

}

I ran the refactor/satisfy tool against this example2 package in the scratchpad module. The code looks roughly as below:
	cfg := &packages.Config{
		// omitted for brevity
		Mode:  packages.NeedModule | ...,
		Tests: true,
		Dir:   ".",
	}
	pkgs, err := packages.Load(cfg, packagesToCheck...)
	if err != nil {
		return nil, err
	}
	if packages.PrintErrors(pkgs) > 0 {
		return nil, fmt.Errorf("packages contain errors")
	}

	f := satisfy.Finder{}
	for _, pkg := range pkgs {
		f.Find(pkg.TypesInfo, pkg.Syntax)
	}

What did you see happen?
From the refactor/satisfy docs:
Package satisfy inspects the type-checked ASTs of Go packages and reports the set of discovered type constraints of the form (lhs, rhs Type) where lhs is a non-trivial interface, rhs satisfies this interface, and this fact is necessary for the package to be well-typed.

A Constraint records the fact that the RHS type does and must satisfy the LHS type, which is an interface. The names are suggestive of an assignment statement LHS = RHS.

However, one of the constraints returned is actually the opposite (LHS = *types.Named, RHS = *types.Interface) as compared to the expected (LHS = *types.Interface, RHS = *types.Named).
Printing this returns:
{github.com/stretchr/testify/mock.TestingT interface{Cleanup(func()); github.com/stretchr/testify/mock.TestingT}}

The LHS is: *types.Named
github.com/stretchr/testify/mock.TestingT

The RHS is: *types.Interface
methods: Cleanup
embeddeds.obj.object:
    name: TestingT
    pkg: github.com/stretchr/testify/mock

What did you expect to see?
Honestly, I'm not sure. mock.TestingT is actually an interface (and you can see this via a call to Underlying() on the named type).
type TestingT interface {
	Logf(format string, args ...interface{})
	Errorf(format string, args ...interface{})
	FailNow()
}

I see two options:

My assumption based on the existing documentation that LHS be a *types.Interface was correct, and the code for refactor/satisfy should be updated to ensure that this holds.
My assumption that LHS be a *types.Interface was unfounded, and I should update my code to account for potentially receiving a types.Named for LHS and then accessing the underlying interface.

CC @golang/tools-team

In this case, the LHS type, mock.Testing.T, is a named interface type, so I think the code is working as intended.  (It would be very surprising if it were not, as the only place in the code that inserts an entry into the Results set is Finder.assign, and it is dominated by an if isInterface(lhs) check; the isInterface predicate strips off types.Named and types.Alias constructors as needed.)
When we describe something as "an interface type", we usually intend that to include aliases and named types whose underlying type is an interface type, though it sometimes depends on the context, and the difference is often significant. In this instance, the fact that Constraint.LHS has type Type, not *Interface, is a tiny hint that it may be a named or alias type too. Preserving the Named/Alias constructors leads to much better error messages in tool such as gopls' Rename operation.
I hope that makes sense.

Thanks for the context and clarification, that makes sense.


Try to release the GVL while gumbo parsing, for better concurrency

What problem is this PR intended to solve?
Parsing html documents in threads has no performance benefit; there is no concurrency.
I have just learned today about the "nogvl" ruby API, described in thread.c, as a way to permit concurrent/parallel execution of non-ruby code by releasing the GVL (Global VM Lock).
So I tried experimenting a bit with wrapping gumbo_parse_with_options and build_tree inside rb_thread_call_without_gvl, and the results are promising. As seen in the table below, originally we have the same number of operations per second no matter the concurrency. By releasing the GVL during gumbo_parse_with_options we increase the number of operations per sec. Here the increase maxes out around 4 threads (the number of cores). 2x operations per sec is not bad at all I think. By also releasing the GVL during build_tree we get a bit of extra concurrency.
parsing N times a 216k html file
0: original with GVL, and therefore no concurrency
1: release GVL for gumbo_parse_with_options
2: release GVL for gumbo_parse_with_options and build_tree
|   | 0 | 0 | 1 | 1 | 2 | 2
-- | -- | -- | -- | -- | -- | -- | --
threads | parse calls | time | parse/s | time | parse/s | time | parse/s
1 | 100 | 2.34 | 42.81 | 2.31 | 43.25 | 2.40 | 41.74
2 | 200 | 4.97 | 40.20 | 3.00 | 66.60 | 2.89 | 69.24
3 | 300 | 7.26 | 41.34 | 4.01 | 74.78 | 3.71 | 80.82
4 | 400 | 9.61 | 41.63 | 5.02 | 79.64 | 4.62 | 86.58
5 | 500 | 12.10 | 41.34 | 6.17 | 81.04 | 5.73 | 87.20
6 | 600 | 14.60 | 41.08 | 7.25 | 82.79 | 7.08 | 84.74
7 | 700 | 17.20 | 40.69 | 8.51 | 82.25 | 7.86 | 89.02
8 | 800 | 19.41 | 41.21 | 9.76 | 82.00 | 8.92 | 89.71
9 | 900 | 21.85 | 41.18 | 10.83 | 83.13 | 9.73 | 92.51
10 | 1000 | 24.21 | 41.30 | 11.92 | 83.91 | 11.09 | 90.15
What do you think?
Some caveats: I don't know very much about this nogvl API, so I'm not sure if I should have used rb_thread_call_without_gvl2, if the RUBY_UBF_IO unblock function is appropriate to use here, if the code would crash on some other input, etc. Also I'm assuming (at least it looked that way to me) that gumbo_parse_with_options and build_tree are pure gumbo/libxml functions that don't invoke any of the Ruby API that depends on the GVL.
Ideally there would only be one call to rb_thread_call_without_gvl instead of two, but that would require pulling  build_tree inside perform_parse somehow and I have no idea if that's feasible, why build_tree is executed inside rb_ensure, etc.

I forget why we needed to use rb_ensure. It might not be needed any longer. But there was some reason at some point. :)
I'll try to take a look at that code again soon.


epicov branch

Feature addition for GISAID EpiCoV branch:

[ ] annotate samples by age and gender (in tooltip for beads)
[x] use GISAID location instead of country to region map, see #205
[ ] check for valid session ID

Pushed new branch epicov to repo

Use testdata.xz on Orolo

art@orolo:~/git/covizu$ python3 batch.py --dry-run --infile working/testdata.xz --ft2bin fasttree
🏄 [0:36:56.929693] All done!

Screwed up, forgot that adding location changes index of accession in pipe-delimited labels:
[{"nodes": {
"unsampled0": [],
"Asia / China / Shandong / Qingdao": [["2020-01-19", "Asia / China / Shandong / Qingdao", "EPI_ISL_408482", "hCoV-19/Shandong/IVDC-SD-001/2020"]],
"Asia / China / Hubei / Wuhan": [["2019-12-30", "Asia / China / Hubei / Wuhan", "EPI_ISL_402127", "hCoV-19/Wuhan/WIV02/2019"]],
"Asia / Singapore": [["2020-02-02", "Asia / Singapore", "EPI_ISL_410719", "hCoV-19/Singapore/11/2020"]],

Problem with lineage with only one variant:
🏄 [0:11:30.682536] start B.1.76, 2 entries
Traceback (most recent call last):
  File "batch.py", line 137, in <module>
    result = make_beadplots(by_lineage, args, cb.callback, t0=cb.t0.timestamp())
  File "/home/art/git/covizu/covizu/utils/batch_utils.py", line 84, in make_beadplots
    beaddict = beadplot_serial(lineage, features, args)
  File "/home/art/git/covizu/covizu/utils/batch_utils.py", line 32, in beadplot_serial
    variant = labels[0]['accession']  # use earliest sample as key
TypeError: list indices must be integers or slices, not str

Script runs without errors, but output still contains dicts and not lists:
[{"nodes":
{"EPI_ISL_426179": [
  {"name": "hCoV-19/India/UN-c31/2020", "coldate":
"2020-03-02", "location": "Asia / India", "accession": "EPI_ISL_426179", "gender
": "Male", "age": "15", "status": "unknown"},
  {"name": "hCoV-19/Scotland/EDB057/
2020", "coldate": "2020-03-18", "location": "Europe / United Kingdom / Scotland"
, "accession": "EPI_ISL_425861", "gender": "unknown", "age": "unknown", "status"
: "unknown"},
  {"name": "hCoV-19/Iceland/464/2020", "coldate": "2020-03-20", "loc
ation": "Europe / Iceland / Reykjavik", "accession": "EPI_ISL_424487", "gender":
 "Female", "age": "48", "status": "unknown"},

Seems to be working now:
[{"nodes": {"EPI_ISL_426179": [["hCoV-19/India/UN-c31/2020", "EPI_ISL_426179", "Asia / India", "2020-03-02", "Male", "15", "unknown"]

Try replacing all unknown values with empty string to reduce file size.
Clusters JSON on test file working/reduced.2021-02-15.json.xz is currently 1990471 bytes.

Number of cases has no value in tooltips

Got table populated with metadata
Also trying to provide visual feedback, when user mouseovers a table row, the corresponding bead is highlighted - however this is not working for rows that represent samples subsumed into a larger bead (multiple samples in same bead).  Not sure how to deal with this.

I think I need to pass the variant field from beaddata.points to the table row level, preferably without displaying it.

Replace with #246

Reopening, need to require users to connect to epicov site via HTTPS

Need to write a script that modifies clusters.json to epicov format by drawing information from provision xz file.  This would make our lives easier!


define timeout when using xctest

I really like the way of fastlane to simply run a lane to generate what it needs to test and deploy my apps.  For me this means that many times fastlane fails to successfully run xctest. I didn't find an option to tell the launch timeout to xctest/xcodebuild from the Fastfile.
So I wonder if there isn't such an option to use with fastlane or if you can integrate it easily?
Thanks in advance!

Sorry, right now there is no option for that yet.

Bummer! Any plans to add that in the next versions?
I think options like for simulator timeout handling, fresh simulator, fresh install might be a really handy improvement, especially for a syntax like:
xctest(
....
testOptions: {
freshSimulator: true,
freshInstall: true
},
launchTimeout: 240 # seconds
}

No plans for it right now. Here is the source code for the xctest action: https://github.com/KrauseFx/fastlane/blob/master/lib/fastlane/actions/xcodebuild.rb#L387
if you have some time to implement this, I'll happily merge a pull request.

I had a short look at the code. As far as I can see, xcodebuild only supports a destination-timeout.
xctool for example would offer some more options for a test/run-test (like freshSimulator, resetSimulator etc.).
How do you think about integrating xctool for the XctestAction or in general?

This is now implemented thanks to @samsonjs with https://github.com/KrauseFx/fastlane/issues/374 :+1:


CanJS Inspector

VOTE HERE
I'd like to make something like Ember Inspector but for CanJS
I was thinking about the following features:

Inspecting the component scope
Inspecting the controls bound to an element
Inspecting the current model requests
Inspecting the app state object (whatever is bound to can.route map)

Can you think of any other features we could need?

Closing as we now have an alpha inspector with its own repository: https://github.com/canjs/can-devtools


Keyboard shortcuts

Allow the user to use the keyboard to access input fields are other UI Items quicker.
For example:
1: Name input
2: Initiative input
3: HP
4 Max HP
5 temp HP...
(Not sure if it is possible to make sure that the user does NOT change input fields when entering integers, because entering "12" in an HP field might trigger these events. I might also use other keybinds)

Allow the user to let them choose their keybinds?


feat: make image builder timeout configurable

Description

How has this been tested?

Checklist

[ ] changelog was updated with notable changes
[ ] documentation was updated

/e2e --tests sdk,substrafl,frontend,mnist,camelyon

End to end tests: :hourglass_flowing_sand: STARTING

/e2e --tests sdk,substrafl,frontend,mnist,camelyon

End to end tests: :hourglass_flowing_sand: STARTING

/e2e --tests doc

End to end tests: :hourglass_flowing_sand: STARTING


'.' syntax not supported for "az network lb update" command to set tags

I am using the command "az network lb update " to set tags for load balancer.
Ex: az network lb update -g MyResourceGroup -n MyLb --set tags.CostCenter=MyBusinessGroup
Any tags containing a '.' is not supported in this.
For ex: Ex: az network lb update -g MyResourceGroup -n MyLb --set tags.sample.test=myvalue
And I am getting error as below:
"Couldn't find 'sample' in 'tags'.
Could you please suggest.

network

@thakurmishra21, do you have existing tags before updating? If not, please update them after created.

@thakurmishra21, do you have existing tags before updating? If not, please update them after created.

No this has nothing to do with updating a tag. I am trying to add a new tag.

@thakurmishra21, thanks for your detailed explanation. I do think for this scenario, we should use --add instead of --set.

@necusjz :
I tried your suggestion and I got the below error.
az network lb update -g tagLoadBalRG -n tagLoadBalIns --add tags.test.sample=val4
Couldn't find 'test' in 'tags.test'. Available options: ['Dept.test.kl', 'Status']

@thakurmishra21, could you share the command you created the load balancer? I'll compose the update command for you.

@thakurmishra21, we can leverage az rest to do it, e.g.,
az rest
--method patch
--uri "https://management.azure.com/subscriptions/xxxx/resourceGroups/ethan-rg/providers/Microsoft.Network/loadBalancers/ethan-lb?api-version=2021-08-01"
--body '{\"tags\":{\"Dept.test.kl\":\"val2\",\"Status\":\"val3\",\"test.sample\":\"val4\"}}'

Even so, I would suggest using "_" instead of "." in a key, it will do make our life much easier. : )


Correction for raw affiliation Movement - Interactions, Performance, Faculty of Sciences and Technologies, Le Mans University, Le Mans, France

Correction needed for raw affiliation Movement - Interactions, Performance, Faculty of Sciences and Technologies, Le Mans University, Le Mans, France
raw_affiliation_name: Movement - Interactions, Performance, Faculty of Sciences and Technologies, Le Mans University, Le Mans, France
new_rors: 01mtcc283;04q2ax456
previous_rors: 01mtcc283
works_examples: W4391443391
contact: 3ea74fd452203abcc328cea5de57fc6d:720d6e9ea3d5e9ac0513164b3d38ee @ univ-nantes.fr

This issue was accepted and ingested by the OpenAlex team on 2024-11-18. The new affiliations should be visible within the next 7 days.


Add seed without server restart

When a seed is added, the server needs to be restarted. Can it be possible to enable a seed without a restart.

When the WebGME reads the available seeds, it reads all the seed projects in the seed base paths. When you want to share a seed from a project, the new project will use the same seed base path. However, if all the seeds share a directory, then all the seeds will be shared (basically, an all-or-none situation).
To avoid this, the seeds are placed in their own directory. The benefit of this is that it allows users to share individual seed projects. However, this also means that the base paths need to be changed in the config to add the seed project to the project.
tl;dr - Not without a change to the webgme or the current design.


Issue/2876 recompile button (#2920)

Pull request opened by the merge tool on behalf of #2920

Processing this pull request


Feature Request: Support for Shared Examples and Shared Contexts

This may just be something I'm overlooking in the docs -- or that could use an example -- but is there a way to do RSpec-style shared contexts and shared examples?
For example, I just wrote my first test using Spectrum, which looked like this:
@RunWith(Spectrum.class)
public class EnumsTest {
  {
    describe(".findValueOrThrow", () -> {
      context("when given an Enum that has no values", () -> {
        final Supplier<Class<EmptyEnum>> enumClass = let(() -> EmptyEnum.class);

        it("throws an IllegalArgumentException", () -> {
          assertThatExceptionOfType(IllegalArgumentException.class)
            .isThrownBy(() -> {
              Enums.findValueOrThrow(enumClass.get(), (value) -> true);
            })
            .withMessage(
              "No `com.rosieapp.util.EnumsTest.EmptyEnum` was found that matched the specified " +
              "filter.")
            .withNoCause();
        });
      });

      context("when given an Enum that has values", () -> {
        final Supplier<Class<Colors>> enumClass = let(() -> Colors.class);

        context("when the predicate does not match any of the values", () -> {
          final Supplier<Predicate<Colors>> predicate = let(() -> (color) -> false);

          it("throws an IllegalArgumentException", () -> {
            assertThatExceptionOfType(IllegalArgumentException.class)
              .isThrownBy(() -> {
                Enums.findValueOrThrow(enumClass.get(), predicate.get());
              })
              .withMessage(
                "No `com.rosieapp.util.EnumsTest.Colors` was found that matched the specified " +
                "filter.")
              .withNoCause();
          });
        });

        context("when the predicate matches one of the values", () -> {
          final Supplier<Predicate<Colors>> predicate = let(() -> (color) -> color.name().equals("WHITE"));

          it("returns the matching value", () -> {
            assertThat(Enums.findValueOrThrow(enumClass.get(), predicate.get()), is(Colors.WHITE));
          });
        });

        context("when the predicate matches multiple values", () -> {
          final Supplier<Predicate<Colors>> predicate = let(() ->
            (color) -> !Arrays.asList("RED", "WHITE").contains(color.name()));

          it("returns the first matching value, according to the order within the enum", () -> {
            assertThat(Enums.findValueOrThrow(enumClass.get(), predicate.get()), is(Colors.BLUE));
          });
        });
      });
    });
  }
  // ...
}

Two of those scenarios are expected to throw the same exception with nearly the same error message. In RSpec, I'd abstract that out into a shared example group and then control what's provided using let. If shared example groups are out of the question, what would be the best practice when using Spectrum for this?

We have support for something similar via the Gherkin syntax - https://github.com/greghaskins/spectrum/blob/master/docs/GherkinDSL.md - but could not yet decide how to make it look for the RSpec style syntax.
Can you give an example of how you do it in RSpec, especially relating to the overloading of let.

Note - this is essentially the same as #80

In our case, the request is a bit different than #80. The way we usually handle this in RSpec is by defining a shared example group:
class Cat
  def make_sound
    "Meow!"
  end
end

class Dog
  def make_sound
    "Woof!"
  end
end

shared_examples_for 'an animal' do
  it 'makes a sound' do
    expect(animal.make_sound).not_to be_nil
  end
end

describe Cat do
  let(:animal) { Cat.new }

  it_behaves_like 'an animal'
end

describe Dog do
  let(:animal) { Dog.new }

  it_behaves_like 'an animal'
end

I was able to get a workable but verbose solution using a functional interface and lambda declared in the test. The lambdas are invoked from within the context of each overall test.
@RunWith(Spectrum.class)
public class MyTest {
  {
    final Supplier<Object> someObject = let(() -> new Object());

    final Supplier<MyObject> testObject = let(() -> new MyObject(object.get()));

    final ComparisonSharedExample<Model> behavesLikeRegularEquality = (testMethod) -> {
      it("returns the match", () -> {
        assertThat(testMethod.get()).isSameAs(someObject.get());
      });
    };

    final ComparisonSharedExample<Model> behavesLikeOppositeEquality = (testMethod) -> {
      it("does not return the match", () -> {
        assertThat(testMethod.get()).isNotSameAs(someObject.get());
      });
    };

    describe("#compare1", () -> {
      behavesLikeRegularEquality.run(
        () -> {
          return testObject.get().compare1();
        });
    });

    describe("#compare2", () -> {
      behavesLikeOppositeEquality.run(
        () -> {
          return testObject.get().compare2();
        });
    });

    describe("#compare3", () -> {
      behavesLikeRegularEquality.run(
        () -> {
          return testObject.get().compare3();
        });
    });

    describe("#compare4", () -> {
      behavesLikeOppositeEquality.run(
        () -> {
          return testObject.get().compare4();
        });
    });
  }

  interface ComparisonSharedExample<M extends Model> {
    void run(final Runnable testMethod);
  }
}


[DO NOT MERGE] Misha/test logcheck 3.73

Description
A detailed explanation of the changes in your PR.
Feel free to remove this section if it is overkill for your PR, and the title of your PR is sufficiently descriptive.
Checklist

[ ] Investigated and inspected CI test results
[ ] Unit test and regression tests added
[ ] Evaluated and added CHANGELOG entry if required
[ ] Determined and documented upgrade steps
[ ] Documented user facing changes (create PR based on openshift/openshift-docs and merge into rhacs-docs)

If any of these don't apply, please comment below.
Testing Performed
TODO(replace-me)
Use this space to explain how you tested your PR, or, if you didn't test it, why
you did not do so. Valid reasons include, for example, "CI is sufficient",
"No testable changes". Feel free to attach JSON snippets, curl commands,
screenshots.
In addition to reviewing your code, reviewers must also review your testing
instructions and make sure they are sufficient.

/test ?

No version compatibility tests are available. Not sure I'll catch anything here, but let's see.


J2L refuses to load images in titles list

1.8.2.play

J2L has a bug where value of Gauge always resets to 0, you need to go to settings and manually change covers size


Issue with NHS.UK survey banner when the screen is magnified

Hi all,
Spotted this in the user research lab today. When the screen size is magnified 200x (and upwards), the survey banner takes up pretty much the entire screen. Fixed element at the bottom of the window - see screenshot.

Unfortunately, due to it's stickiness design, there probably isn't anything we can do about this when zoomed in. Maybe reduce padding in smaller viewports? If this is considered a real problem, then may have to look at it being redesigned. @davidhunter08 - thoughts?

We're going to revisit the design of feedback banner because we don't think it's very good in general. It was just a redesign of the legacy survey banner on the NHS website. There is also no guidance published in the NHS digital service manual about the usage of this component.
We've created an issue on the NHS digital service manual backlog to revisit it: https://github.com/nhsuk/nhsuk-service-manual-backlog/issues/114


Search with comparator does not handle OperationOutcomes correctly (FI-1622)

Hello,
I think that comparator-based searches ( params_with_comparators ) do not filter out OperationOutcomes when checking if everything in the Bundle matches the provided parameters. As a result, a Bundle that has all valid results as well as a non-fatal OperationOutcome will fail due to "not matching the search parameters".
I believe the relevant code is in search_test.rb. Non-comparator searches use the resources_returned array, which is filtered down to only the requested resource, but perform_comparator_searches does not.
Here's an example failure:

The Bundle response is here: DiagnosticReport_Bundle_json.txt
.

@jwjahns Thank you for raising this issue to us. It is a bug in our code. We will fix that.

@jwjahns I create a copy of this issue in onc-certification-g10-test-kit repo for easy tracking. The link is shown above. I will close this one as duplicate.


Update angular-material typing to clarify type of controller

The type of the controller property for a few of the option objects was
listed as (Function|string|undefined), this updates that to reflect that
it can any injectable type rather than just function.  Injectable type
is pulled from existing angular typings.

Imported and running through tests.
Sent to @jelbourn for internal Google review.

Got internal approval for this, but having some trouble getting all the necessary tests run.
I expect them to run overnight tonight.

To be clear, trouble with tests is not due to the content of this PR.

Submitted internally this morning.
If all goes well, it'll get pushed out to github later today.


Fix broken link in docs.rs

Fixed #1172

cc @ChrisDenton can you take a look at this please?
There're some broken links in our docs.rs, on how to build on windows.


[Android] Scroll to new message after sending or receiving.

Have a look at the commit I did a couple of days ago.
Very likely this functionality will be implemented similarly, and only in JS.

@borisyankov Updated 👍
Ready for review.
if do it on native, there are almost zero chances of getting crash due to scroll (due to listComponent not mounted, undefined etc). And , we have control on really how much to scroll. (and chances of getting white screen is also less.)


Transition the FV tests to use Microfab

As the the Java Chaincode, the Node.js FV tests need to transition to use the better approach of microfab.
Rather than the reliable but long widened pulling of the fabric-samples test-network

Microfab is no longer maintained and the repository has been archived so is not a good platform on which to base FV testing.


[Err] Error in socket shutdown: Transport endpoint is not connected

This fills my logs, one every second:
23.03.20 18:37:42 (+0100)  snapcast-client  2020-03-23 17-37-42 [Err] Error in socket shutdown: Transport endpoint is not connected
Running balenaOS 2.46.1+rev1 on a Raspberry Pi v1.

Hello @bphermansson can you share a bit more context? Besides this errors showing on your log, is the project working correctly?  Are you seeing this errors pop up even if you are not streaming audio?
Also, what version of the Pi 1 do you have (A, A+, B, B+)?

@bphermansson i will close your issue for now. Without more information we are not able to resolve this issue.

I have this same issue and I believe it takes up a lot of CPU.
Everything works fine (bluetooth and Airplay (except for Spotifyconnect but I think it's another issue). I also do not use snap cast client (as far as I am aware. Is it possible to disable it, or fix this another way? Thanks! What information do you need?

Hi, i have the same thing now. Is there a solution so far?

I have still the same error but it doesn’t affect the performance. For what I use it for.
Sent from Proton Mail for iOS
Op EE, MMM d, jjjjj om HH:mm, Sungod3000 @.***> schreef:

Hi, i have the same thing now. Is there a solution so far?
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you commented.Message ID: @.***>


Disable Rake::TestTask warnings

This will avoid noisy tests with lots of warnings introduced with
ruby/rake@8078bb6

I'd suggest to merge #233 first to make this pass travis, but I don't know what the PR/merge habits/requirements/policies in this repos are right now.

I don't support libraries suppressing warnings. I'd rather have noisy tests myself. If you need to quiet the log output for your mind, write a logger or change the file for yourself, I don't believe a library benefits from hiding warnings.

This commit just reinstates the behavior of rake before ruby/rake@8078bb6. The library itself doesn't suppress warnings, it's just the warnings thrown by code of (older) gems sneakers is depending on. Warnings aren't disabled when sneakers is used in production code.

BTW, the warnings are mainly coming from: amq-protocol (2.0.1), bunny (2.5.0), minitest (5.9.0), guard (2.14.0).


fix build issues

Fixed build issues.

Hi, thanks for the contribution.
Could you please include some information as to what errors you get during compile? It 'just works' locally.

I simply ran cargo install --path . and got following error:
error[E0277]: the trait bound `surf::Error: std::error::Error` is not satisfied
   --> src/data.rs:171:15
    |
171 |         .await?;
    |               ^ the trait `std::error::Error` is not implemented for `surf::Error`
    |
    = note: required because of the requirements on the impl of `std::convert::From<surf::Error>` for `anyhow::Error`
    = note: required by `std::convert::From::from`

error: aborting due to previous error

For more information about this error, try `rustc --explain E0277`.
error: failed to compile `instantly v0.1.0 (/home/jojii/tmp/instantly)`, intermediate artifacts can be found at `/home/jojii/tmp/instantly/target`

May be a symptom of not locking down versions tightly enough. Merging, thanks!


Precision Snap should be called something else as it's confusing

in relation to https://github.com/thestonefox/SteamVR_Unity_Toolkit/issues/478#issuecomment-243609860
It's not an actual snap but a precise grab.
Perhaps should be renamed via custom inspector to avoid breaking underlying changes?

Seems weird to have it called precisionSnap in the code but the inspector (and docs to reflect) would be precision grab this is probably going to cause more confusion than just explaining what is meant by precision snap.


Browser "born on" date?

Would it be possible to add a browser version's release date/year?

Dup of #202?

Yup. Slowly working on this.


Newly added "escape" module missing in package.d

...so right now we can't just
import mysql;

to access them until it's imported explicitly by
import mysql.escape;

I think I might have been slightly hasty in merging the escape module, as I'm having trouble compiling and running the unittest. That will need to get sorted out first, before adding it to package.d

My fault, I am using a function in the unittest that isn't imported


Added "clone" action to docs

fixed issue #1286
Checklist

[x] I have added tests
[x] I have updated the docs and cheatsheet
[x] I have not broken the cheatsheet

@pokey  perfect!