Suggestions for fixing issues #15 Renaming API and #16 Extract Error formatting code from AssertOrder

Hello Homa,
These are suggested fixes for

Issue #16 Renaming API .Here's a snapshot of the name changes
once() -> runOnce()
some() -> runAtleastOnce()
all() -> repeatExactCount()

Issue #15 Extract Error formating code from AssertOrder.

Thanks,
Ashwini

Coverage remained the same at 100.0% when pulling 0dfd478f7732d3d3cdf6972f727b6dd327e89324 on ashwinimanjunath:fixing-issues into 0ac5e03fdbcc7b724b55f8120ea8817d5b068f65 on unional:master.

Coverage remained the same at 100.0% when pulling 098008f50ffa259385bf857f91b50ecca7aa727e on ashwinimanjunath:fixing-issues into 0ac5e03fdbcc7b724b55f8120ea8817d5b068f65 on unional:master.

Coverage remained the same at 100.0% when pulling 6d4f115dd1b742dd40ededa2a4f08c3de7f1e3dc on ashwinimanjunath:fixing-issues into 0ac5e03fdbcc7b724b55f8120ea8817d5b068f65 on unional:master.

@ashwinimanjunath thanks.
I need to think about this a bit. Generally, I like the direction, and it help brings up another use case: optional(), that a particular step may or may not be executed at a certain time.
On the other hand, I think repeatExactCount() may be not as nice as runExactly().
Don't have to make changes to the code right now, let's discuss it.
On the other hand, it would be nice to put the #15 to a separate PR, that can go in without the rename.

Closing for #21


More tile map providers

Hello,
Following #5, a large number of online map providers can be found in
https://github.com/leaflet-extras/leaflet-providers/blob/master/leaflet-providers.js (JavaScript code)
or also in https://github.com/tumic0/GPXSee-maps (XML data with corresponding URL).
or in MOBAC
https://sourceforge.net/p/mobac/code/HEAD/tree/trunk/MOBAC/mapsources/ (Java code or BeanShell)
https://sourceforge.net/p/mobac/code/HEAD/tree/trunk/MOBAC/mappacks/
Maybe an approach could be to have this kind of data outside of Julia code but simply as data in a repository which could be shared accross several projects (in differents languages).
Any opinion about it?
Kind regards

Maybe an approach could be to have this kind of data outside of Julia code but simply as data in a repository which could be shared accross several projects (in differents languages).

I don't mind using depending on such a package if it exists and has a clear owner and maintainer in its roadmap. In the meantime, I don't mind sticking to the current approach.

I think we could combine the providers here with those in Leaflet.jl in a TileProviders.jl package.
This would also be useful in GeoMakie.jl: https://github.com/MakieOrg/GeoMakie.jl/issues/67

We now automatically parse the leaflet providers in TileProviders.jl, so closing this.


feat: add config operation, config ls, config storage --sdk-path=D:/vfox/

add config operation, config ls, config storage --sdk-path=D:/vfox/
command:
vfox config ls
vfox config storage --sdk-path=D:/vfox

Perhaps it could support all configurations, not just sdkPath, similar to git config.

Is setting the configuration through commands really simpler than modifying the configuration file directly?
What if we want to cancel the original configuration? Do we need to add the --unset option?

Perhaps it could support all configurations, not just sdkPath, similar to git config.

Now, the configs contains proxy, storage and register;
Want all support?
vfox proxy --url=http://xx.com
vfox proxy -- enable=true
vfox registry --address=http://xx.com

other command
show the vfox run path
vfox config path

Is setting the configuration through commands really simpler than modifying the configuration file directly?
What if we want to cancel the original configuration? Do we need to add the --unset option?

First of all, when I use vfox, I really feel confus that I donot know where are the config path;
I often set a frequently used sdkPath, firstly for easy access, and secondly because some SDKs tend to become larger in size. By using commands, I can install VFox, set corresponding parameters, and install the necessary SDKs without switching tools.
command --unset is good option; I have no idea how to realize him; Set default config file or config strut to reset them?

vfox proxy --url=http://xx.com
vfox proxy -- enable=true
vfox registry --address=http://xx.com

other command show the vfox run path
vfox config path

I don't like any of the above command designs, and if I were to do this, I'd prefer the following command design:
vfox config proxy.enable true
vfox config proxy.url http://xxxx

vfox config registry.address http://localhost

vfox config --unset registry.address

It might be a little more troublesome to implement.

command --unset is good option; I have no idea how to realize him; Set default config file or config strut to reset them?

Only reset targeted property to default value. For example, vfox config --unset registry.address will reset registry.address property to
https://github.com/version-fox/vfox/blob/8abc625fef9d6ee419f7896f9bc592b98091d3f0/internal/config/registry.go#L23-L25

vfox proxy --url=http://xx.com
vfox proxy -- enable=true
vfox registry --address=http://xx.com

other command show the vfox run path
vfox config path

I don't like any of the above command designs, and if I were to do this, I'd prefer the following command design:
vfox config proxy.enable true
vfox config proxy.url http://xxxx

vfox config registry.address http://localhost

vfox config --unset registry.address

It might be a little more troublesome to implement.

command --unset is good option; I have no idea how to realize him; Set default config file or config strut to reset them?

Only reset targeted property to default value. For example, vfox config --unset registry.address will reset registry.address property to
https://github.com/version-fox/vfox/blob/8abc625fef9d6ee419f7896f9bc592b98091d3f0/internal/config/registry.go#L23-L25

Example:
config --unset-all
config --unset proxy.url
config --unset proxy.enable
config --unset storage.sdk-path
config --unset registry.address

config proxy.url http://x.com
config proxy.url ""

config proxy.enable true
config proxy.enable false

config storage.sdk-path D:/app/vfox/sdk
config storage.sdk-path ""

config registry.address http://x.com
config registry.address ""

This is not the effect I want. I want something like git config, without needing to set subcommands.

This is not the effect I want. I want something like git config, without needing to set subcommands.

Do you want to the effect like vfox config proxy.enable=true
I really refer to the git config; This effect tha command plugin is not supported.
The git config effect have to parse it by yourself, so I implemented this format first.

This is not the effect I want. I want something like git config, without needing to set subcommands.

Now, support 2 styles like
vfox config proxy.enable=true
vfox config proxy.enable true

It's different from what I had in mind. If you don't mind, can I implement a version according to my own ideas? We can then compare them.

It's different from what I had in mind. If you don't mind, can I implement a version according to my own ideas? We can then compare them.

Yes, that's better. I can learn, too

Closing in favor of PR #211


Ignore rules in yaml config

include: package:pedantic/analysis_options.yaml

linter:
  rules:
    - camel_case_types

This would add camel_case_types rule.
Is there any way to ignore some rules?

You should be able to disable a lint with a : false
include: package:pedantic/analysis_options.yaml

linter:
  rules:
    - camel_case_types: false

See https://dart.dev/guides/language/analysis-options#disabling-individual-rules

Thanks!

Seems we should remove the - before items:
include: package:pedantic/analysis_options.yaml

linter:
  rules:
    camel_case_types: false

That's strange, - should be valid in yaml, but remove - did work for me, too. I just confused with why flutter's analysis_options.yaml is working, or It should work without -.
Here is my enviroment:
[√] Flutter (Channel stable, v1.12.13+hotfix.8, on Microsoft Windows [Version 10.0.18362.592], locale zh-TW)

[√] Android toolchain - develop for Android devices (Android SDK version 28.0.3)
[√] Android Studio (version 3.5)
[√] VS Code, 64-bit edition (version 1.41.1)
[!] Connected device
    ! No devices available

pedantic: ^1.8.0+1


CodeMirror horizontal scrollbar not accounting for bookmark width

The Firefox DevTools Debugger now proudly boasts an inline preview feature to show variable values while paused -- a really awesome feature!  We've run into an interesting issue with the CodeMirror horizontal scrollbar when trying to use setBookmark:

Despite the inline preview bookmark block/text starting within the viewport, the horizontal scrollbar never grows to accommodate the entire preview element.  In doing some investigating of my own, CodeMirror's updateScrollbars function is never called after injecting the previews into the line.
Since we're using the CodeMirror setBookmark API to inject the bookmark, it seems reasonable to assume that the scrollbar should be aware that the length of the line that the bookmark was injected into has changed an thus kick off a resize/scrollbar check.

Here are some links to the implementation

InlinePreview
InlinePreviewRow

includes the element the preview component is inject in
includes the left attribute, which determines the component's position

Thank you for adding additional info @jasonLaster!  The above is the current implementation which uses a line widget and a calculated left style along with a negative top margin; the reason I'm trying to move to a setBookmark implementation is to avoid the costly perf hit of numerous left calculations by simply add the bookmark inline, and allowing CodeMirror to do the scrollbar calculation.
You can get an idea of what I'm trying to do here:  https://phabricator.services.mozilla.com/D44532
The original "bug" remains the same, in that I would expect that CodeMirror would see a bookmark and adjust the horizontal scrollbar accordingly.

I'm not seeing this happen when I use addBookmark to add a widget at the end of a line that would introduce or extend the horizontal scrollbar—the editor seems to immediately adjust the scrollbar. Looking over the patch in phabricator, I can't figure out what you might be doing differently.
Are you using the current version? If so, can you set up a small script that reproduces the issue?

Thank you for the response @marijnh.  The issue is really interesting to try to nail down. As for a test script, I'll see what I can do; since we're using React, it may be difficult to put together a simple script.
My first thoughts were timing issues.  I see that endOperation_R2 appears to be the sizer shifting, so I've been trying to trigger that function in a variety of ways, including fake operations, manually setting cm.display.maxLineChanged, cm.refresh() or simply setting that conditional to if(true)but the scroll scroller size remains the same.
Is there a hack way to trigger that scroll size change?  The only real CSS on the resulting bookmark is display: inline-block which shouldn't be doing anything weird to effect scrollbars.

We're currently on 5.40.0. which is a couple of versions back
@darkwing it might be worth trying to upgrade docs.

5.40.0 isn't that old, I don't remember anything related to this changing, so upgrading might not do a lot.
Is the widget being initialized asynchronously by React? It it doesn't have its final shape/size when it's inserted that might cause this.

this seems likely and definitely a good place to investigate

Consider the following reduced demo I've created:  https://jsfiddle.net/4eLjmbwr/6/
In this demo I continually inject a bookmark with text and no explicit width.  A few notes:

While the scrollbar does move, the marker quickly starts being cut off on the right . That partially supports my feeling that the bookmark width isn't accurately portrayed in the scrollbar

Note that the .CodeMirror-sizer doesn't appear to ever move, which supports my feeling that the debug line (the blue-outlined element in my original image) never stretches to full width once a bookmark is introduced.

I've studied the Chrome DevTools source code and they also use addLineWidget with a negative top margin and calculated left CSS value to align the previews properly and force the editor to scroll far enough that the full preview is seen.  They also have the issue triggered by the .CodeMirror-sizer not moving, which makes their blue debug line not stretch to full scroll width.

That test is running CodeMirror 5.4 for some reason. It seems to get a lot better with 5.49.

Thank you for checking it out!  Updating to 5.8 shows no improvement, unfortunately; https://jsfiddle.net/px9rsh52/1/

I really have no idea why you upgraded to 5.8 when I mentioned 5.49 in my comment.

My apologies @marijnh, that does appear to work much better.  Closing this issue -- thank you!


🪲 GROUP BY name collisions

Thank you for taking the time to report a problem with Opteryx. To help us to respond to your request we ask that you try to provide the below detail about the bug.
Describe the bug  A clear and specific description of what the bug is.
Expected behaviour
A clear and concise description of what you expected to happen.
Sample Code/Statement
If you can, please submit the SQL statement or Python code snippet, or a representative example using the sample datasets.
SELECT COUNT(*) AS Missions, Company FROM space_missions.parquet GROUP BY Company ORDER BY Missions DESC

SqlError: SELECT statement contains multiple references to the same column, perhaps as aliases or with qualifiers.

Additional context
Add any other context about the problem here.

using a sample dataset:
SELECT COUNT(*) AS planets, id FROM $planets GROUP BY id ORDER BY planets DESC


The repetition operator reports one repetition less.

When using the curly braces to indicate repetition, it looks like the number of repetition is one short. For example:
^+1(?:\d){10}$
(http://regexper.com/#^\%2B1(%3F%3A\d){10}%24)
Indicates that the (?:\d) should repeat 9 times while it should be 10.

Sorry, just read the doc :-S
"The values are one less than specified in the expression since the pattern would have to be matched once before repeating it is an option."


Triage and fix intermittent errors in Chrome tests

The test sometimes becomes stuck and is killed by Travis

This was fixed in commit 3db8b4eda578be4bfecb6ede234f4cff072f18d1


LUCENE-10428: Avoid infinite loop under error conditions.

What can we do to get this change into the next version of Lucene?

I was hoping for a :+1: from Ankit before merging.
Regarding tests, I was not able to identify the case that would break the existing logic, so I'm not sure what new test to add. There are existing tests for this class in TestMaxScoreSumPropagator.

@jpountz I'd write a test that uses invalid input to do more than 2 iterations and expect IllegalStateException with the right values/description.

@jpountz I'd write a test that uses invalid input to do more than 2 iterations and expect IllegalStateException with the right values/description. Otherwise no test confirms that it can't loop infinitely.

@dblock I guess @jpountz's is trying to say that we don't have an existing case (set of inputs / repro) which runs for more than 2 iterations. But, I agree with @dblock's point as well to test this code somehow.
Should we parameterize the number of iterations parameter and use it as test hook for getting the method to throw IllegalArgumentException? Also, does this exception reflect as 4xx or 5xx on the client side?

@jpountz Out of curiosity, what is the implication of returning whatever minScore get's computed after 2 iterations? Like we do a best case effort to converge, but return with whatever we get after n attempts?
I guess it could be bad if the function doesn't keep converging with every iteration, and stopping abruptly at n iters can land in some random, divergent values.. I'm not sure how this works.
Also, do you have any pointers on what user should look at once she gets this exception? I understand it's too early as we're not able to repro the issue, so is the plan to keep a jira open to collate more data around how frequently people run into this exception?

Should we parameterize the number of iterations parameter and use it as test hook for getting the method to throw IllegalArgumentException?

I'm not sure how useful that is as a test. Would also avoid parameterizing a value (maxIterations) that is not supposed to change across different callers. But I like the idea of collating data from users who run into this exception (via the params printed in stacktrace). Maybe add a ToDo to test/repro/fix the edge case later?

Should we parameterize the number of iterations parameter and use it as test hook for getting the method to throw IllegalArgumentException?

I'm not sure how useful that is as a test.

I won't argue, but I have hard time accepting that we can fix a real bug, and write no new tests.

I won't argue on this specific approach, but I have hard time accepting that we can fix a real bug, and write no new tests.

Please feel free to contribute one, this is open source after all. Nobody is here to do your bidding.

Out of curiosity, what is the implication of returning whatever minScore get's computed after 2 iterations? Like we do a best case effort to converge, but return with whatever we get after n attempts?

@vigyasharma This might cause Lucene to miss some top hits. The point of this code is to propagate minimum competitive scores to child clauses. For instance imagine that you have a disjunction with 3 clauses, whose max scores are 1, 2 and 3. If the collector sets a min competitive score of 5.5 on the disjunction at some point, then we can deduce that the first clause must have a score that it at least 5.5-2-3=0.5, the second clause must have a score that is at least 5.5-1-3=1.5 and the 3rd clause must have a score that is at least 5.5-1-2=2.5. This is very simple in principle but the fact that operations on floating-point numbers produce rounded values makes it a bit tricky, hence the current logic. The risk with your proposal is that we would return a score that is too high, e.g. 0.6 on the first clause instead of 0.5, which would in-turn make Lucene skip hits whose score is between 0.5 and 0.6 on the first clause even though some of them might be top hits. The only "safe" return value would be 0, which would in-turn disable skipping on the child clause.

@dblock Yeah I'm unhappy about this change too. FWIW this isn't really a bug fix, this mostly turns a potential bug that we haven't managed to understand into a different bug that has less severe implications and would make the root cause easier to identify.

I think we have a case of floating point here.
If you change getMinCompetitiveScore to take a double or minScoreSum, it becomes easy to reproduce. It also almost always starts tripping testNClausesRandomScore and often test2ClausesRandomScore.
private float getMinCompetitiveScore(double minScoreSum, double sumOfOtherMaxScores)

  public void testGetMinCompetitiveScore() throws Exception {

    List<FakeScorer> scorers = new ArrayList<>();
    scorers.add(new FakeScorer(0.39404958f));
    scorers.add(new FakeScorer(0.0028006434f));
    scorers.add(new FakeScorer(0.24155897f));

    float minScoreSum = 2.7810444831848145f;
    MaxScoreSumPropagator p = new MaxScoreSumPropagator(scorers);
    p.setMinCompetitiveScore(minScoreSum);
  }

I wasn't able to trip it with a float minScoreSum though with the values in the issue, but it has to exist, given that it happened in production.
It looks like converging in getMinCompetitiveScore relies on truncating (rounding?) doubles to floats, so this looks suspicious to me.
Any ideas of what we can do next?

It looks like converging in getMinCompetitiveScore relies on truncating (rounding?) doubles to floats, so this looks suspicious to me.

I certainly wish it was simpler, but it's done this way on purpose. The way that boolean queries combine scores of their sub clauses together is by summing up the float scores into a double and finally casting back that double back to a float. So this method undoes this operation by taking the float score sum and subtracting the sum of other scores as a double as a first approximation of the minimum score that this clause must have.

If you change getMinCompetitiveScore to take a double or minScoreSum, it becomes easy to reproduce.

That's expected. If minScoreSum is a double then we end up subtracting ulps of a double from a float, which doesn't make much sense.

it has to exist, given that it happened in production.

Right, it's bad. My current thinking is that there are 3 main options:

A bug in this code,
A bug in other code that breaks assumptions that this code is making, e.g. a query that produces negative or NaN scores.
A problem in something external like a JVM bug or bad RAM.

Thank you for the detailed explanation, this makes a lot of sense.

A bug in other code that breaks assumptions that this code is making, e.g. a query that produces negative or NaN scores.

This gave me the idea that we can use negative values for a test at least. I PRed https://github.com/jpountz/lucene/pull/2 into your branch: it replicates this issue with negative scores and can now validate the expectation.

I won't argue on this specific approach, but I have hard time accepting that we can fix a real bug, and write no new tests.

Please feel free to contribute one, this is open source after all. Nobody is here to do your bidding.

https://github.com/jpountz/lucene/pull/2

This gave me the idea that we can use negative values for a test at least. I PRed jpountz#2 into your branch: it reproduces this issue with negative scores, and can now validate the new expectation of an IllegalStateException being thrown.

Thats great! and much better than parameterizing for testing IllegalStateException

Thanks all for the feedback and contributions!

Thanks for fixing the issue @jpountz and everyone for your support and ideas!


Draft project structure documentation

/cc @linki @iterion @justinsb

@ideahitme What's the purpose of documenting the alternatives?
How do you want to procede after we merge this? Are we going to decide something? Then we should list the pros and cons so people can understand our decision. Or should we rather involve the community?

@linki in my opinion choice of which library to use for logging or flag parsing is not really critical, just wanted to make sure we are on the same page. Probably will just remove alternatives and briefly explain why use what we use :)

@iterion @linki please take a look again and I think we can merge this for now

lgtm


 Have been puzzling over it, too!

Hello @emanuele-leopardi , @pete-woods,
I also noticed the debug option is not working properly.
Will check to resolve this issue.
Greetings,
@quintush


can we get a release?

Can you please compile the mod and upload it as a release?

https://modrinth.com/mod/votelistener


feat: add new iOS session replay configuration

Problem
Add new session replay configuration:

maskPhotoLibraryImages
maskAllSandboxedViews

Changes

Release info Sub-libraries affected
Bump level

[ ] Major
[ ] Minor
[ ] Patch

Libraries affected

[ ] All of them
[ ] posthog-web
[ ] posthog-node
[ ] posthog-react-native

Changelog notes

Added support for X

For releasing you need to update the changelog and version file https://github.com/PostHog/posthog-js-lite/blob/main/RELEASING.md
Do not merge before releasing the plugin as well


Bug: ImgBot deletes Jupyter Notebook

As seen in: RohanNagar/datasciencelab-utaustin#2 and RohanNagar/datasciencelab-utaustin#1
lab10/lab10.ipynb is completely deleted in the PR. It's interesting that only that .ipynb file is deleted, and not any of the others.
It's not an issue for me as I don't maintain that project any more, but I thought it would be a good idea to open a bug report in case others are having this issue too.

Thanks for reporting this. Glad it's not an issue for you right now, but this a pretty critical problem.
I wonder if it is related to #103 at all?
When I clone https://github.com/RohanNagar/datasciencelab-utaustin on my laptop it marks a file as modified right away
modified:   lab10/Lab10.ipynb

Will have to do some research into these file types

When I clone https://github.com/RohanNagar/datasciencelab-utaustin on my laptop it marks a file as modified right away

That's interesting.. I wonder why that is happening. I just tried to clone it from a clean machine and don't see it marked as modified by git.. I'll see if I can figure out more about that.

fixed in #123


Improve linear gradient component

User Story:

As a developer,
I want to be able to use the linear gradient component in more situations,
So that we don't duplicate our code unnecessarily

The linear gradient component currently only supports a horizontal format, but we can extend it to be usable in either a horizontal or in a vertical context
Acceptance Criteria:

[x] Update LinearGradient.js to accept a height prop as well as width, and use it to set a height css value just like we're doing with the width.
[x] Adjust the css so that the line component has a width property that can be fell back on if one isn't provided in the component props
[x] To test, use the LinearGradient component, and pass in height for props instead of width. You should see a vertical line now!

I tested the code, but it seems like the code overrides the width and height that I put into the component and takes in the width and height from the CSS file first.


Update CODEOWNERS

What does this PR do?
Add @DataDog/software-integrity-and-trust to the build process around Agent integrations.
Motivation
So that we can be kept informed about build changes.
Additional Notes
N/A
Possible Drawbacks / Trade-offs
Slightly slows down review process only for the Agent integrations.
Describe how to test/QA your changes
N/A
Reviewer's Checklist

[ ] If known, an appropriate milestone has been selected; otherwise the Triage milestone is set.
[ ] The appropriate team/.. label has been applied, if known.
[ ] Use the major_change label if your change either has a major impact on the code base, is impacting multiple teams or is changing important well-established internals of the Agent. This label will be use during QA to make sure each team pay extra attention to the changed behavior. For any customer facing change use a releasenote.
[ ] A release note has been added or the changelog/no-changelog label has been applied.
[ ] Changed code has automated tests for its functionality.
[ ] Adequate QA/testing plan information is provided if the qa/skip-qa label is not applied.
[ ] If applicable, docs team has been notified or an issue has been opened on the documentation repo.
[ ] If applicable, the need-change/operator and need-change/helm labels have been applied.
[ ] If applicable, the config template has been updated.

@trishankatdatadog Do you mind rebasing this PR so that we can merge it? We seem to be carrying it over every release since 7.35.

Done. PTAL? Thx!

Merging this PR since we had all the relevant parties sign off on it. Tests failures are not related since the PR doesn't change any code.


Dendencies Update

Problem: useless lodash , lodash-es and loose-envify
In redux package.json this packages is included as dependencies and obviously is installed each time.
Those packages are used in examples I think it makes sense to make them as devDependecies.
What do you think?
Also, I have a  question. What is the use case of symbol-observable?  Is there any doc to find information about that?

loose-envify needs to be a dependency for browserify to work properly. lodash is used in some places in the source, and redux can be built with lodash-es.

The entire lodash is depended on, but the only thing it's used for is isPlainObject
node_modules/redux//es/combineReducers.js:import isPlainObject from 'lodash-es/isPlainObject';
node_modules/redux//es/createStore.js:import isPlainObject from 'lodash-es/isPlainObject';
node_modules/redux//lib/combineReducers.js:var _isPlainObject = require('lodash/isPlainObject');
node_modules/redux//lib/createStore.js:var _isPlainObject = require('lodash/isPlainObject');
node_modules/redux//src/combineReducers.js:import isPlainObject from 'lodash/isPlainObject'
node_modules/redux//src/createStore.js:import isPlainObject from 'lodash/isPlainObject'

I would recommend switching to lodash.isplainobject to skip the weight of the full lodash and lodash-es

@Munter There's no full lodash. 'lodash-es/isPlainObject' means the same as separate package, but this case won't let to switch in es modules version.

@Mamoru1234 it's used in package.json.
  "browserify": {
    "transform": [
      "loose-envify"
    ]
  },

Browserify reads the package.json and runs any transforms mentioned there on the code in the redux package.

@brigand But redux is library and you running browserify only during development(you know what kind of dep i mean).

@Mamoru1234 npm install redux doesn't install redux's dev deps, so loose-envify wouldn't be installed, and then browserify wouldn't work correctly. Redux having it as a regular dep is both required and harmless.

Note that installing lodash/lodash-es only incurs a size and install penalty on your local machine. When built, the entirety of that library is not included.


[Stable] Add support for Python 3.10

Add support for Python 3.10

Summary
backport of #285
Details and comments

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.09%) to 82.185%

Totals

Change from base Build<PHONE_NUMBER>:
0.09%

Covered Lines:
2768

Relevant Lines:
3368

💛  - Coveralls


Layer shape mismatch when loading pretrained weight when using Keras included in Tensorflow

I wanted to load YOLOv3 model and retrain it using provided pre-trained model.
I got stuck for a while on this error :
ValueError: Layer #1 (named "conv2d_1"), weight <tf.Variable 'conv2d_1/kernel:0' shape=(3, 3, 32, 64) dtype=float32> has shape (3, 3, 32, 64), but the saved weight has shape (32, 3, 3, 3).
It is actually an easy to fix error, so I share what I learnt here so nobody have to get stuck on it like me :) .
Here is how to reproduce the error :
git clone https://github.com/qqwweee/keras-yolo3.git
cd keras-yolo3
wget https://pjreddie.com/media/files/yolov3.weights
python convert.py yolov3.cfg yolov3.weights model_data/yolo.h5

I created the file pretrain-model-minimal.py, which contains a minimal version of train.py to reproduce my error.
from tensorflow.python.keras import backend as K
from tensorflow.python.keras.layers import Input

from yolo3.model import yolo_body
from train import get_classes, get_anchors

def _main():
	classes_path = "model_data/coco_classes.txt"
	pretrained_weights = "model_data/yolo.h5"
	anchors_path = "model_data/yolo_anchors.txt"

	class_names = get_classes(classes_path) # Reuse the function from train.py
	num_classes = len(class_names)
	anchors = get_anchors(anchors_path) # Reuse the function from train.py

	create_model(anchors, num_classes,weights_path=pretrained_weights)

def create_model(anchors, num_classes, weights_path='model_data/yolo_weights.h5'):
	'''create the training model'''
	K.clear_session()  # get a new session
	image_input = Input(shape=(None, None, 3))
	num_anchors = len(anchors)

	model_body = yolo_body(image_input, num_anchors // 3, num_classes)
	print('Create YOLOv3 model with {} anchors and {} classes.'.format(num_anchors, num_classes))

	model_body.load_weights(weights_path, by_name=True)
	print('Load weights {}.'.format(weights_path))

if __name__ == '__main__':
	_main()

When running this code, the line model_body.load_weights throw the error about layer shape mismatch.
You might have noticed from the imports that I use the Keras included in Tensorflow (I also modified the imports on the other files). And this is the source of the error.
When running the exact same code using Keras out of Tensorflow, everything work well.
I hope it will help some people.
Have a nice day !

I have solved the kind of issue as follows. Hope the solution would be helpful.
1. Delete "by_name=True"
# -model.load_weights(weights_path, by_name=True)
model.load_weights(weights_path)

2. Change the number of class
While it throws another throwing "ValueError: Shapes (1536, 1000) and (1536, 1001) are incompatible", I change num_classes from 1000 to 1001. And then it shows the correct model summary.
# -num_classes = 1000
num_classes = 1001


SAML automatic user creation

If the request contains the identity but it doesn't match any organization user, the user will be automatically created.
Please note that the same organization signup rules still apply. The normal SAML scenario would be that no domain is whitelisted so signup page will be disabled.

I've divided this task in 2:

[ ] Refactor SAML service so it doesn't return a user but an email, and fetch user outside (https://github.com/CartoDB/cartodb/pull/11129)
[ ] Create user outside if user with returned email doesn't exist. (Pending development)

Developed both in the same PR.


feat(builder): add ignore lines comment

PR Checklist
Please check if your PR fulfills the following requirements:

[ ] Tests for the changes have been added (for bug fixes/features)
[x] Docs have been added/updated (for bug fixes/features)

PR Type
What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no API changes)
[ ] Build related changes
[ ] CI-related changes
[ ] Documentation content changes
[ ] Other... Please describe:

Issue Number

Issue Number: #83
Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information
Now you can use ng-doc-ignore-line comment to remove some lines from the code of your demos or code blocks.
@Component({/* ... */})
export class DemoComponent {
  // ng-doc-ignore-line
  constructor() {}

  onClick(): void {
    console.log('Hello world');
  }
}

:tada: This PR is included in version 16.11.0 :tada:
The release is available on:

v16.11.0
GitHub release

Your semantic-release bot :package::rocket:


Fix missing values handling average

[x] Replaces #204
[x] Tests added
[x] Passes black .
[ ] User visible changes (including notable bug fixes) are documented in whats-new.rst

I totally messed up #204 and since the changes are minor, I decided to start over fresh.
This PR replaces our internal logic for the weighted average with xarrays weighted. This prevents errors, which arise when the processed data has missing values which are not found in the metric needed for the operation. I have turned my simple example into a test, which failed with the current version.
As mentioned in #204 this also allows to compute averages on subsets of the dataset (due to weighted's internal alignment). This addresses #193, but I would like to treat is as a bugfix only, since we still need to discuss a more consistent handling of subsets with all available functions.

Also here I dont think we need to point to this in the whats-new.rst? Thoughts?


a problem when you respawn

I discovered a bug when you don't take the same weapon, the game thinks you took the same one and as soon as you shoot it, it merges with the other weapon, do you think you can fix it?

 Do you think that you can create a video for that? Or at least a step by step to reproduce it?

https://youtu.be/NVEDpYb48vU
sorry for the late and the quality of the video , i will try to do my best to get better quality

I still didn't understand what is happening

well i fix it

Closing the issue


[Test Proxy] Maps Timezone migration

Updated test classes to use Test Proxy and migrated recordings to the assets repo. Also had to modify the base test class to improve HttpPipeline creation for test clients.

API change check
API changes are not detected in this pull request.


Allow clicking on URLs in the virtual terminal

If you print an http(s) URL to the terminal, you can click on it to open a browser. It would be nice to have that functionality in the virtual terminal as well, especially I want to use Konsole for starting up a web server.

Need this sooner than later, will definitely be using this feature in Kobweb


Errors in third party reporters get swallowed by Mocha

I've been working on building a reporter for Mocha but it can be difficult to debug errors in the reporter because Mocha eats them up. Would be great if Mocha could at least log the reporter error before throwing an invalid reporter error. Something like this?
Mocha.prototype.reporter = function(reporter, reporterOptions){
  if ('function' == typeof reporter) {
    this._reporter = reporter;
  } else {
    reporter = reporter || 'spec';
    var _reporter;
    try { _reporter = require('./reporters/' + reporter); } catch (err) {};
    if (!_reporter) try { _reporter = require(reporter); } catch (err) {
      console.warn(err);
    };
    if (!_reporter && reporter === 'teamcity')
      console.warn('The Teamcity reporter was moved to a package named ' +
        'mocha-teamcity-reporter ' +
        '(https://npmjs.org/package/mocha-teamcity-reporter).');
    if (!_reporter) throw new Error('invalid reporter "' + reporter + '"');
    this._reporter = _reporter;
  }
  this.options.reporterOptions = reporterOptions;
  return this;
};

I see. I'm not sure why we aren't currently logging the reporter load errors. 'invalid reporter' doesn't really say much. I guess the code's author didn't expect the reporter to blow up during the require.

It would be nice to differentiate between missing reporter and broken reporter, in the end.

I would think it wouldn't be too hard to make that distinction.

Not at all, just checking the value of err in catch. And as messages, I could see something like:
"nyan" reporter not found.
"unstable" reporter blew up, and show stack trace.

Fixed in https://github.com/mochajs/mocha/pull/1543 :) Thanks a lot @adamgruber!


FE: Call get-room-permission edge function when entering a room

Call get-room-permission when a user enters a room in order to get its role.

Update:
The edge function is already implemented (https://github.com/montevideo-tech/hybrid-meetup-platform/pull/96/files). It just need to be called every time a user joins a room.
For that a new function needs to be implemented on frontend/actions/index.js and it should be called after the JWT is provided on joinRoom.


fix: zetaDelta := false regression

See new test. It is a mwe for an issue blocking Mathlib.

Just recording here that it turns out that it turns out mathlib was relying on the sources in structure instance notation introducing local instances.
We're testing out a temporary workaround to have the spread syntax introduce let bindings itself, using a special let binder that changes the kind to be an implementation detail after introducing any local instances. (Spread syntax is that {...; __ := a; __ := b} is equivalent to {a, b with ...}. It's nice because it works with where syntax.) https://github.com/leanprover-community/mathlib4/commit/77711ed99e5eabb25ab7ddc5a80f3816846df9a5


How do I add more pages?

Hello! I really like your theme and it's the only I've found that will work perfectly with this communal site I'm developing, the only thing is I'm not sure how to add more pages or sections (not sure what you call them lol).
The communal site I am developing is for me and some friends to showcase our books. What I want to do is add a section for each book that shows the book cover, description, and author name, how do I do that?
Sorry if this is an easy question with a simple answer, I'm just starting out with web development and Jekyll and don't know a lot.

@Aspiring-Writer Hello! Sorry, it's been too many years that I don't even remember Jekyll myself. I don't really have much to look into this, but you are interested, feel free to check out the source code and take a look.

Thanks, I'm actually not using Jekyll right now either.


block/ladder.go: Change Direction to Face to allow states 0 and 1

Fixed a bug where ladder wasn't being added to creative inventory. It was happening due to ladder in dragonfly not allowing facing_direction to be 0 and 1. We already discussed this in Discord:

wait ive just noticed a typo in my commit name... why did i write commend instead of commend.....

womp womp

I went to the aquarium this weekend, but I didn’t stay long. There’s something fishy about that place.


Attaching the Authorization Header to Apollo Client Instance

Trying to attach the auth token to the httpLink in apollo.js file am Using Ember 3.28 Octane, Glimmer apollo. My apollo.js file looks like
import { setClient } from 'glimmer-apollo';
import {
  ApolloClient,
  InMemoryCache,
  createHttpLink,
} from '@apollo/client/core';
import { setContext } from 'apollo-link-context';

export default function setupApolloClient(context) {

  // HTTP connection to the API
  const httpLink = createHttpLink({
    uri: 'http://localhost:4000/',
  });

  // Cache implementation
  const cache = new InMemoryCache();

  let session = context.lookup('service:session');

  let authLink = setContext((request, context) => {
      return this._runAuthorize(request, context);
    });
    return authLink.concat(httpLink);
  }

  _runAuthorize() {
    if (!'session.isAuthenticated) {
      return {};
    }
    return {
      headers: {
        Authorization: `Bearer ${session.data.authenticated.token}`
      }
    };
  }

  // Create the apollo client
  const apolloClient = new ApolloClient({
    link: authLink,
    cache,
  });

  // Set default apollo client for Glimmer Apollo
  setClient(context, apolloClient);

}
Can't inject the service using the decorator because Leading Decorators can only be used with class declarations.

Hello @anyuruf,
How did you resolved this? I'm facing the exact same question. I have a session service provided by Ember Simple Auth, which manages the authentication. It provides access to the access token, which needs to be used for the GraphQL requests made with Apollo. But it seems that I'm not able to access the service from that place.
I could read the access token from localStorage to which Ember Simple Auth syncs the token (in my setup). But using local storage to communicate between different parts of the app seems to be weird. Also the way the access token is stored in local storage feels like a private API of Ember Simple Auth's LocalStorageStore and the authenticator used. Long story short: That would feel very hacky.
Wondering if I'm missing something obvious, how I can access the Ember service outside of a class, which is managed by Ember framework.
If you found a solution, it would be great if you could share that.
Best
Jeldrik

I found the solution in this Discord chat: https://discord.com/channels/480462759797063690/925422411145424896/925429727039213628
Let me quickly summarize it to make it easier to find it coming from Google:

The ApplicationInstance is passed as context argument to setupApolloClient function if you follow the documented setup for Ember applications.
You can lookup a service on that ApplicationInstance using the lookup method. To lookup the session service, it looks like this:context.lookup('service:session');

You now have access to the session service and can consume any property on it as you are used to.

@josemarluedke shared a full code example in the Discord thread mentioned above.

That is as type script implementation but I have re-implemented with normal JavaScript check check my https://github.com/anyuruf/broember repository


ImageMagick 6.9 not supported?

Hey folks, I'm trying to convert my pdf to images, and it seems setGMClass(true) is going to help me, however, it seems it only supports ImageMagick version >=7, since mine failed with version 6.9.
My code:
const pdf2picConvert = pdf2pic.fromBuffer(fileBuffer, {
    format: 'png',
    preserveAspectRatio: true,
    density: dpi // output pixels per inch
  })
  pdf2picConvert.setGMClass(true) // Use ImageMagick - this is the key line, so you don't have to touch return type

  const pageNumber = 1
  const imageBufferResponse = await pdf2picConvert(pageNumber, {
    responseType: 'buffer'
  })

Asking because I'm using vercel serverless api, and they only have ImageMagick 6.9 available in their image, they don't have graphicsmagick. Hence my struggle here

Have you ever found something for this? having the same issue.

Yea, I opted to use Docker Image + Render for deployment so I can use higher versioned ImageMagick. Not using Serverless API for this anymore


MudAutocomplete

Bug type
Component
Component name
MudAutocomplete
What happened?
MudAutocomplete prevent Typing in search box  when add onkeypress  event to MudAutocomplete parent (like div) just allow me to type one character only
Expected behavior
...Expected behavior
Reproduction link
https://try.mudblazor.com/snippet/GawxYDwNJqtHNvmR
Reproduction steps

example url attached

Relevant log output
no log output

Version (bug)
6.10.0
Version (working)
No response
What browsers are you seeing the problem on?
Chrome, Microsoft Edge
On what operating system are you experiencing the issue?
Windows
Pull Request

[X] I would like to do a Pull Request

Code of Conduct

[X] I agree to follow this project's Code of Conduct

Hello,
Similar to https://github.com/MudBlazor/MudBlazor/issues/6590 but onkeydown event.
Can you see it too, please? Thank you,


[Bug]:Incorrect role in Ollama_model ChatWrapper causing missing assistant messages

AgentScope is an open-source project. To involve a broader community, we recommend asking your questions in English.
Describe the bug
The docstring for the function OllamaChatWrapper.format states that the role should be "user" in the input messages list. However, the actual implementation sets the role to "system", causing the LLM to only receive system messages and no user messages, and ollama_chat_llama3.1 seems to not respond to system messages in isolation
To Reproduce
Steps to reproduce the behavior:
/examples/conversation_basic/conversation.py
add model_config in agent.scope.init:
agentscope.init(
    model_configs=[
            {
                "model_type": "ollama_chat",
                "config_name": "ollama",
                "model_name": "llama3.1",
            },
    ...
    ]

Start a conversation:
2024-09-13 16:31:17.378 | INFO     | agentscope.models.model:__init__:203 - Initialize model by configuration [ollama]
Assistant:
User input: Hello
User: Hello
Assistant:
User input: what's ur name
User: what's ur name
Assistant:

Debugging found that the message returned by LLM was an empty string.
If OllamaChatWrapper.format is modified according to the documentation string, the content can be output normally.
OllamaChatWrapper.format docstring
https://github.com/modelscope/agentscope/blob/6c823a955c7be783a2a34c64d13b74aee8c552bf/src/agentscope/models/ollama_model.py#L288-L302
but the actual implementation is:
https://github.com/modelscope/agentscope/blob/6c823a955c7be783a2a34c64d13b74aee8c552bf/src/agentscope/models/ollama_model.py#L361-L369
When I use ollama_chat_llama3, this problem does not occur.
Perhaps a more general solution can be adopted, such as:
Fix the role in the implementation to be "user" as described in the docstring.
(Optional) Update the logic to follow a more common pattern where system messages are in the "system" role and conversation history is included in the "user" role. This might improve clarity and consistency.

According to ollama official documentation, there is not much difference between the templates of
llama3 and llama3.1  when there is only one message with the role set to "system".
We successfully tested Llama2, Llama3, Qwen:0.5, and Phi  when the role was changed from "system" to "user" in #443 .
Regarding the suggestion to split into system message and user message, we need to conduct more testing before making any modifications.


"GET /whatever/trent.mick" messes up on "GET /whatever/:login" route: "login" is "trent"

{code}
2011-11-22 23:13:42Z TRACE: GET /pub/trent.mick route found -> { method: 'GET',
url: '/pub/:login',
regex: false,
handlers:
{ pre: [ [Function: setup] ],
post: [ [Function: w3cLog] ],
main: [ [Function: getAccount] ] },
version: '1.0.0',
semver: true,
urlComponents: [ 'pub', ':login' ] }
2011-11-22 23:13:42Z TRACE: _parseRequest: params parsed as: {}
XXX login is 'trent'
XXX req.uriParams is: { login: 'trent' }
{code}
MarkC said:
oh crap.
i remember what this was now.
this was some goofy shit to handle .json or .xml at the end.
i.e. if you specified /foo/type that would allow /foo/type.json /foo/type.xml, etc.
and override the content-type, but make sure the uriParam was 'type'.
grr...

Will be in<EMAIL_ADDRESS>


Add support for a main input placeholder

It goes in the input you click to open the multiselector dialog.

:rabbit:


⚠ Fortnite has degraded performance

In dbb3f35, Fortnite (https://fortnite.com) experienced degraded performance:

HTTP code: 200
Response time: 1558 ms

Resolved: Fortnite performance has improved in 1755c57.


Move config files around to clean up root

Please review @tgolen
cc @marcaaron
Details
Moving the various config files around to make the root have less files.
Fixed Issues
Fixes https://github.com/Expensify/Expensify/issues/146267
Tests
Make sure all platforms build successfully
Tested On

[x] Web
[x] Mobile Web
[x] Desktop
[x] iOS
[x] Android

@marcaaron has a PR here that is handling the eslint file.


No activity types

None of the example statements have activity types. I think they'd benefit from activity types.

should be addressed in https://github.com/adlnet/xAPI-SCORM-Profile/pull/30...
see https://github.com/creighton/xAPI-SCORM-Profile/commit/5be96ed8ee34dc9e679178d82cfd60b6b57b9951
in particular


JavaFX HostServices "Open Link in Browser" doesn't work on macOS in GraalVM/Gluon

This has been fixed by https://bugs.openjdk.java.net/browse/JDK-8214158, which should be appearing in a JavaFX 18 Early Access build soon.  Thanks @mipastgt !

You are welcome :-)

I think Supernaut.FX will wait until JavaFX 18 is final to upgrade our (transitive) dependency. But applications needing this fix are free to update to newer/EA OpenJFX releases at any time.
I'll update the supernaut-fx-sample-maven to OpenJFX 18 EA once the fix is released, see: https://github.com/SupernautApp/SupernautFX/issues/25

JavaFX 18 is released, but Supernaut.FX will not update its transitive dependency to 18, though the two sample apps (https://github.com/SupernautApp/supernaut-fx-sample-maven, https://github.com/SupernautApp/supernaut-fx-sample-gradle) have done so.

Closing. (As this is fixed upstream and requires no changes to Supernaut.FX to use the newer version.)


[3.x]Adding FsxFileCacheSettings/FileCacheId Config Option under SharedStorage

Description of changes

Adding Unmanaged Fsx File Cache Config Option under SharedStorage section

Tests

Unit Tests for Validating the Config Options
Manual Local Tests for Validation of Config Options

Checklist

[x] Make sure you are pointing to the right branch and add a label in the PR title (i.e. 2.x vs 3.x)
[x] Check all commits' messages are clear, describing what and why vs how.
[x] Make sure to have added unit tests or integration tests to cover the new/modified code.
[ ] Check if documentation is impacted by this change.

Please review the guidelines for contributing and Pull Request Instructions.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Looking at the Failing Tests/Checks

I suggest to use the following prefix for every PR title and commits related to this feature: [FSxFileCache].
In this way it will be easier to search for PRs and commits related to the feature when we are going to release it or look for issues to address

Working on solving the pycov checks


⚠ Hartman Foundation has degraded performance

In cdc0f1b, Hartman Foundation (https://gordonhartman.com/) experienced degraded performance:

HTTP code: 200
Response time: 2538 ms

Resolved: Hartman Foundation performance has improved in 15c5493.


Fix CLI syntax for local deploy

#sign-off
cc: @ktoliver

@j-martens: I'm sorry - only the author of this article, @jpe316, can sign off on your changes. But we do have an exception process - if you are on the Microsoft content or product team for this product area, you can ask the PR review team to review and merge it by sending mail to the techdocprs alias.


Only run migrations on one instance

The AWS rolling update [1] stuff does not work as expected and as such
migrations can run at the same time on more than one instance. This
makes beanstalk only run migrations on one instance.
[1] http://docs.aws.amazon.com/elasticbeanstalk/latest/dg/using-features.rollingupdates.html

Looks good - have you tried this out at all? Or we believe the documentation in this case?

Good call. Closing while I test it thoroughly

I have tested this and confirmed that it does behave as we expect.


Inexplicably "flipped" cards in the Deck Manager.

I'm not even sure how to accurately describe it (...vertical "mirroring"?):

Only occurred once (despite my attempts to reproduce it), so I have no idea what it may have been related to... but I figured I should still mention it "just in case". ¯\_(ツ)_/¯
-TM

GO HOME DECK, YOU'RE DRUNK !

Seems that the reason I couldn't "reproduce" the effect is that it only occurs once-per-launch.
It's actually quite consistent:

Launch HSTracker.
Open the Deck Manager window.
Click on a deck to preview the cards.
Close the Deck Manager window.
Re-open the Deck Manager window.
Laugh at drunk deck! 😜

-TM

That's a hilarious bug, and as a developer I wonder how something like this can be even possible? I mean, it is a library problem, right?

It's hilarious, but I can't reproduce :'(
How do you open/close the deck manager ? mouse / shortcut ?

That's a hilarious bug, and as a developer I wonder how something like this can be even possible?

That was my exact reaction... literally mind-boggling!

I mean, it is a library problem, right?

Given that it's apparently a rare, odd, display bug... my (un-informed) impulse would be to blame it on "graphics card drivers", somehow?
Perhaps a "distant relative" of #364?

It's hilarious, but I can't reproduce :'(
How do you open/close the deck manager ? mouse / shortcut ?

Both / either...
-TM


Is the Royalties NFT ready or abandoned?

Status:
The royalty pull request hasn't been merged nor has there been any update to it in months. https://github.com/tqtezos/minter-sdk/pull/40
Background:
We are in the process of building out a system to cater to artists who want to sell NFTs. An example real life use case would be as follow: Musicians may create songs for movies where they earn royalties from for life of that song. We would like to do something similar with NFTs. They have a limited edition song or asset sold by NFT. Any resell would cause a resell royalty fee. Any use of it would require the owner to call the royalty contract to pay the reuse royalty fee.
Questions:
How close is the current royalty contract to being production ready?
Has it been dropped from the minter-sdk?
How may I help to move it forward? (still learning tezos ecosystem)

Is there any progress on this?

Hi, thank you for your question.
IMO the barrier to having a token contract that enforces royalties on any secondary marketplace sale is a lack of royalty standards for secondary marketplaces to support (See post 15 in https://forum.tezosagora.org/t/fa2-1-fa3-its-time/3704/15). Maybe you can move this forward by commenting on that thread. It probably doesn't make sense to work on this PR until there are standards established


feat(monaco): add language service and delta decorations hook

Overview

PR Checklist

[ ] Related to designs:
[ ] Related to JIRA ticket: ABC-123
[ ] I have run this code to verify it works
[ ] This PR includes unit tests for the code change

📬Published Alpha Packages<EMAIL_ADDRESS>
🚀 Styleguide deploy preview ready!https://60f9c1d7101ca0395c8972e6--gamut-preview.netlify.appDeploy Logs

📬Published Alpha Packages<EMAIL_ADDRESS>
📬Published Alpha Packages<EMAIL_ADDRESS>
🚀 Styleguide deploy preview ready!https://60f9c54cd9fd813d594ea0d4--gamut-preview.netlify.appDeploy Logs

📬Published Alpha Packages<EMAIL_ADDRESS>
🚀 Styleguide deploy preview ready!https://60feb5398d064d36f04adb82--gamut-preview.netlify.appDeploy Logs

📬Published Alpha Packages<EMAIL_ADDRESS>
🚀 Styleguide deploy preview ready!https://6101605ca5da7108aba6a47e--gamut-preview.netlify.appDeploy Logs

📬Published Alpha Packages<EMAIL_ADDRESS>
🚀 Styleguide deploy preview ready!https://610176969ab169244c49f7c0--gamut-preview.netlify.appDeploy Logs

📬Published Alpha Packages:@codecademy/gamut-icons@5.8.0-alpha.c27cac.0@codecademy/gamut-illustrations@0.17.13-alpha.c27cac.0@codecademy/gamut-kit@0.4.71-alpha.c27cac.0@codecademy/gamut-labs@19.16.9-alpha.c27cac.0@codecademy/gamut-patterns@0.4.8-alpha.c27cac.0@codecademy/gamut-styles@11.7.0-alpha.c27cac.0@codecademy/gamut-tests@2.4.16-alpha.c27cac.0@codecademy/gamut@36.0.0-alpha.c27cac.0@codecademy/konamimojisplosion@0.2.47-alpha.c27cac.0@codecademy/markdown-overrides@0.5.59-alpha.c27cac.0@codecademy/monaco@0.0.2-alpha.c27cac.0@codecademy/styleguide@43.0.0-alpha.c27cac.0@codecademy/tracking@0.14.0-alpha.c27cac.0<EMAIL_ADDRESS>
🚀 Styleguide deploy preview ready!https://61018aa902a5334b89c5aa9e--gamut-preview.netlify.appDeploy Logs

📬Published Alpha Packages<EMAIL_ADDRESS>
🚀 Styleguide deploy preview ready!https://6101a1d165e3121e931ff506--gamut-preview.netlify.appDeploy Logs

📬Published Alpha Packages<EMAIL_ADDRESS>
🚀 Styleguide deploy preview ready!https://6102e4e82ff7b4483f9819f6--gamut-preview.netlify.appDeploy Logs

🚀 Styleguide deploy preview ready!https://610aea2693ac88129cea2cf5--gamut-preview.netlify.appDeploy Logs

📬Published Alpha Packages<EMAIL_ADDRESS>
🚀 Styleguide deploy preview ready!https://610c52668b6c2e00a7be38a4--gamut-preview.netlify.appDeploy Logs

📬Published Alpha Packages<EMAIL_ADDRESS>
📬Published Alpha Packages<EMAIL_ADDRESS>
🚀 Styleguide deploy preview ready!https://610c556c17193a00c4d202c4--gamut-preview.netlify.appDeploy Logs

📬Published Alpha Packages<EMAIL_ADDRESS>
🚀 Styleguide deploy preview ready!https://610d40eafef152be84b640d0--gamut-preview.netlify.appDeploy Logs


Any fix for Error BL9986: Component attributes do not support complex content (mixed C# and markup).

I am trying to upgrade one of my blazor app built on 0.1 (CRUD App using Blazor) to 0.3 but I am getting  the "Error BL9986: Component attributes do not support complex content (mixed C# and markup). " I understand the error but not able to find the solution. This used to work previously.
 <input<EMAIL_ADDRESS>style="display:none;">
But now it gives me mixed c# and markup error.  How would such use cases needs to be handled. Another practical use case is of applying CSS class to the element like,
<button class="btn btn-success @(SelectedID == todo.ID ? "ShowControl" : "HideControl")"> Update </button>
This also gives me the same error but interestingly it works for the HTML span element. The following code works,
<span id="spn_<EMAIL_ADDRESS>Any ideas how to fix this error and why Blazor is not allowing this.

Sorry for the inconvenience. This is already fixed in our dev branch so should be resolved in 0.4.0.
In the meantime one workaround is to make the whole attribute a single C# expression, e.g.:
<input id="@($"txt_{todo.ID}")" style="display:none;">


fix zstd conditional cfg

zstd being optional in the implementations while being necessary in the tests caused errors
this change allows oscar-tools to build successfully again.

i accidentally added sha384 change into it..


Question about the object detection

When encoding the image to prompt, you mentioned captions and bounding boxes, I wonder which object detection model you utilized to generate the bounding boxes?

When encoding the image to prompt, you mentioned captions and bounding boxes, I wonder which object detection model you utilized to generate the bounding boxes?

I think the bounding boxes come from ground truth in coco dataset

Hi @Richar-Du both annotations come from the original COCO dataset: captions from coco-caption-2014 annotation, and boxes from coco-instances-2014 annotations.
Thanks @wanxinzzz for answering!

Got it, thanks for your explanations :)


Error on Log In and Log Out on GL EN

BUG
Current Behavior
Clicked Log In on GL EN homepage (in Canada via TorGuard), logged in with non-admin account, was brought to the screenshot below. I cleared cache and cookies, and got the same error. Hitting back in the browser brought me back to the homepage which looked fine, and I was logged in. If I tried to log out, I was shown the same screen as when I tried to log in.
Desired Behavior
Homepage should simply refresh if I log in from the homepage.
Steps to Replicate
Go to somewhere outside the US (not Brazil or MX) and try to log in via the homepage.
Why This Matters
Users should be able to log in and out.
Countries Affected (optional)
At least GL EN, need to test BR and MX. US EN seems fine.
Need to test if this happens from pitch page as well.
OS/Browser (optional)
Chrome.
Relevant Screenshots + Links
https://www.dosomething.org/user/logout

May be related to: https://github.com/DoSomething/phoenix/issues/5924
cc @mnelson338

So one suspicion I had is that somewhere in the code, because it's a country we don't specifically account for, there's probably an error with it trying to do something with the Canada prefix and it can't because technically that should just be global.
Did some testing locally and this seems to be the case. On loading any page, even within the CMS, I see errors for:
Notice: Undefined index: en-ca in dosomething_global_get_prefix_for_language() (line 477 of /var/www/dev.dosomething.org/lib/modules/dosomething/dosomething_global/dosomething_global.module).

Not necessarily sure if this is the root cause of the above issue, but could be related. Needs to be fixed anyhoo!

So it looks like Canada is a very specific case.
I believe that for languages that we don't support on the site they get designated to en-global, so for example when we've tested spoofing loading the site from Japan which doesn't have en in its language code, we default that to en-global somewhere in the code and then all works fine with that. But for Canada which can have a language code of en-ca along with probably something like fr-ca it seems to throw our logic for a loop and doesn't default it to en-global. Instead it tries to find en-ca in our list and craps out.
I'm updating some of the functions in the dosomething_global.module to provide better "safety" in the logic so if it encounters something it doesn't expect, like en-ca it can be handled better and defaults to something more useful 😉
Something we'll need to consider for other countries that have an option for english in their code...
Anyhoo, just documenting process on troubleshooting this issue which is seemingly a bit obscure but starting to show some reasoning behind what's happening.
cc: @namimody @angaither

In case this issue relates to some stuff that was fixed in #6521 PR, adding a reference to it here!

@deadlybutter mind picking up this issue?

👍


testing of setState call fails when compound component has few child components

Describe the bug
Test fails with strange setState error when multiple childs are rendered and callback is passed to each of them. The strange thing is that setState is called from the production code.
Method “setState” is only meant to be run on a single node. 2 found instead.

      79 |       return React.Children.map(this.props.children, child => {
      80 |         return React.cloneElement(child, {
    > 81 |           onPress: () => this.setState({ name: '::any name::' })
         |                                                       ^
      82 |         })
      83 |       })
      84 |     }

To Reproduce

  class MyComponent extends React.Component {
    render() {
      return React.Children.map(this.props.children, child => {
        return React.cloneElement(child, {
          onPress: () => this.setState({ name: '::any name::' })
        })
      })
    }
  }

  class MyChildComponent extends React.Component {
    render() {
      return <Text>Hello!</Text>
    }
  }

// Test
 const wrapper = shallow(
      <MyComponent>
        <MyChildComponent />
        <MyChildComponent />
      </MyComponent>
    )
    wrapper
      .find(MyChildComponent)
      .first()
      .props()
      .onPress()

    expect(wrapper.state()).toEqual({ name: '::any name::' })

Expected behavior
Test to pass
Desktop (please complete the following information):

OS: macOS Sierra
Jest Version 23.6.0
Enzyme 3.6.0
react-native 0.57

What's the output of wrapper.find(MyChildComponent).first().props().onPress.toString())?
What happens if you add a wrapper.update() before trying to check the state?

What's the output of wrapper.find(MyChildComponent).first().props().onPress.toString())?

function onPress() {return _this.setState({ name: '::any name::' });}

What happens if you add a wrapper.update() before trying to check the state?
Actually the test doesn't fail in the expectation, as it fails when onPress callback is called.

I've tried and with update but the error message is same as code doesn't get to this point at all.
it('bad case', () => {
    const wrapper = shallow(
      <MyComponent>
        <MyChildComponent />
        <MyChildComponent />
      </MyComponent>
    )

    console.log(
      wrapper
        .find(MyChildComponent)
        .first()
        .props()
        .onPress.toString()
    )

    wrapper
      .find(MyChildComponent)
      .first()
      .props()
      .onPress()

    wrapper.update()

    expect(wrapper.state()).toEqual({ name: '::any name::' })
  })

Output:
● (Tabs) Component › bad case

    Method “setState” is only meant to be run on a single node. 2 found instead.

      79 |       return React.Children.map(this.props.children, child => {
      80 |         return React.cloneElement(child, {
    > 81 |           onPress: () => this.setState({ name: '::any name::' })
         |                                                       ^
      82 |         })
      83 |       })
      84 |     }

ahhh this is because enzyme does not yet support components that return non-nodes - ie, an array. If you wrap the React.Children.map in a React.Fragment everything will work.
See #1149; closing this one in favor of that.


openPullRequestsLimit: 0 - Does it work to get security updates only?

Should this work for the taks parameter openPullRequestLimit too?

@piejanssens security only updates are currently not supported by this extension. Contributions are welcome.
Closing as duplicate of #161


Jailbreak failed

I jailbroken and installed NewTerm3 2 days ago, and today when I rebooted and jailbroken again, this error appeared

1: What version are you currently using?
2: Have you ever used the apt command in the terminal?

1: What version are you currently using?
2: Have you ever used the apt command in the terminal?

I use Dopamine version <IP_ADDRESS> (Latest version)
In NewTerm3, I used apt and sudo to install Python3

apt sometimes breaks the roothide symbolic links, you need to use filza(trollstore version) to manually fix them:
in /var/containers/Bundle/Application/.jbroot-xxxx:
bin/.jbroot -> "../.jbroot"
bin/sh -> ".jbroot/usr/bin/dash"

1: What version are you currently using?
2: Have you ever used the apt command in the terminal?

I use Dopamine version <IP_ADDRESS> (Latest version)
In NewTerm3, I used apt and sudo to install Python3

apt sometimes breaks the roothide symbolic links, you need to use filza(trollstore version) to manually fix them: in /var/containers/Bundle/Application/.jbroot-xxxx:
bin/.jbroot -> "../.jbroot" bin/sh -> ".jbroot/usr/bin/dash"

I went to /var/containers/Bundle/Application/.jbroot-81ACE0E1DF8D5826/bin and I couldn't find the .jbroot folder only finded .jbroot file

I will unjailbreak then jailbreak again. Thank you for your support


proxy_context_path does not work as expected

Description:
The configuration "proxy_context_path" which is toml equivalent for "ProxyContextPath" in XML based configs; is not working as expected. The carbon management console does not work due to a hardcoded CSRF guard javascript path. All the react web apps are not working because they have not taken this config into account.
Steps to reproduce:

APIM configurations made on deployment.toml

[server]
hostname = "apim-320.wso2.com"
node_ip = "<IP_ADDRESS>"
mode = "single" #single or ha
base_path = "${carbon.protocol}://${carbon.host}:${carbon.management.port}"
server_role = "default"
proxy_context_path = "apim"

[transport.https.properties]
proxyPort = 443

Nginx configurations (Generate certificates by following "Create SSL certificates" topic of https://docs.wso2.com/display/CLUSTER44x/Configuring+NGINX)

server {
	listen 443 ssl;
	server_name apim-320.wso2.com;
	client_max_body_size 100M;

	ssl_certificate /Users/lakshant/Documents/WSO2/server.crt;
	ssl_certificate_key /Users/lakshant/Documents/WSO2/server.key;

	location /apim/ {
		proxy_set_header X-Forwarded-Host $host;
		proxy_set_header X-Forwarded-Server $host;
		proxy_set_header X-Forwarded-For $proxy_add_x_forwarded_for;
		proxy_set_header Host $http_host;
		proxy_read_timeout 5m;
		proxy_send_timeout 5m;

		proxy_pass https://apim-320.wso2.com:9443/;
		proxy_cookie_path / /apim;
		proxy_redirect https://apim-320.wso2.com/ https://apim-320.wso2.com/apim/;

		proxy_http_version 1.1;
		proxy_set_header Upgrade $http_upgrade;
		proxy_set_header Connection "upgrade";
	}
}

Try logging into any of the followings using the base URL as https://apim-320.wso2.com/apim/

carbon
devportal
publisher

Couldn't find documentation as well for this, but it is referred in carbon.xml.j2 and added the below configurations to the carbon.xml,
<MgtProxyContextPath>apim</MgtProxyContextPath>
<ProxyContextPath>apim</ProxyContextPath>

Affected Product Version:
3.2.0

Similar issue is there in the APIM-4.0.0 as well. It will be better to fix this on APIM-4.0.0 as well.

The fix is explained in the following hypothetical scenario.
This scenario is explained with the context of an all-in-one deployment of the API manager.
The domain is knnect.lk and the carbon console, admin, publisher, and devportal apps should be accessible via the following URLs respectively.

https://knnect.lk/apim/carbon/
https://knnect.lk/apim/admin/
https://knnect.lk/apim/publisher/
https://knnect.lk/apim/devportal/

In order to achieve the above, it's required to do the following configuration changes.
Nginx configuration
server {
        listen 443 ssl default_server;
        listen [::]:443 default_server ipv6only=on;
        server_name  knnect.lk office.knnect.com;
        access_log  /var/log/nginx/proxy.log;

        ssl_certificate /etc/nginx/ssl/server.crt;
        ssl_certificate_key /etc/nginx/ssl/apim.key;

        ssl_session_timeout  5m;
        ssl_protocols       TLSv1 TLSv1.1 TLSv1.2;
        ssl_ciphers  HIGH:!aNULL:!MD5;
        ssl_prefer_server_ciphers   on;

        rewrite \w*(admin|devportal|publisher)$ $1/ permanent;

         location /apim/ {
            proxy_set_header X-Forwarded-Host $host;
            proxy_set_header X-Forwarded-Server $host;
            proxy_set_header X-Forwarded-For $proxy_add_x_forwarded_for;
            proxy_set_header Host $http_host;
            proxy_read_timeout 5m;
            proxy_send_timeout 5m;

            proxy_pass https://localhost:9443/;
            proxy_redirect https://knnect.lk/authenticationendpoint/ https://knnect.lk/apim/authenticationendpoint/;
            proxy_redirect https://knnect.lk/oauth2/ https://knnect.lk/apim/oauth2/;
            proxy_redirect https://knnect.lk/carbon/ https://knnect.lk/apim/carbon/;

            proxy_http_version 1.1;
            proxy_set_header Upgrade $http_upgrade;
            proxy_set_header Connection "upgrade";
        }
}

Hosts file entries
Add the following host entries
<IP_ADDRESS> knnect.lk

Update the APIM manager configuration - deployment.toml
Open repository/conf/deployment.toml and add or update the following configurations.
[server]
hostname = "knnect.lk"
node_ip = "<IP_ADDRESS>"
mode = "single" #single or ha
base_path = "${carbon.protocol}://${carbon.host}:${carbon.management.port}/apim"
server_role = "default"
proxy_context_path = "/apim"

[apim.devportal]
url = "https://knnect.lk/apim/devportal"

[transport.https.properties]
proxyPort = 443

Update the APIM manager configuration - web.xml.j2
repository/resources/conf/templates/repository/conf/tomcat/carbon/WEB-INF/web.xml.j2
Update the APIM manager web app configurations
Add the following configuration to each web application.
devportal/site/public/theme/settings.js
context: '/apim/devportal',
proxy_context_path: '/apim',

publisher/site/public/conf/settings.js
context: '/apim/publisher',
proxy_context_path: '/apim',

admin/site/public/conf/settings.js
context: '/apim/admin',
proxy_context_path: '/apim',

This issue is fixed in the latest update level for 3.2.0 and 4.0.0 and master.

This issue is fixed in the latest update level for 3.2.0 and 4.0.0 and master.

Hi @chanaka3d,
As mention in above comment, Can you please confirm whether this issue has been merged in wso2am-3.2.0 and new wso2am-3.2.0 image has been committed on docker-hub or not.
I've confirmed the modified files in the the wso2am-3.2.0 image and "product-apim-3.2.0" binary but I did not get the fix in the image. If my findings are correct can you please commit the updated wso2am-3.2.0 image on docker hub.


Add support for userfrosting-sprinkle installer

Installer for UserFrosting sprinkle system (userfrosting-sprinkle type). The sprinkle installation will be supported from version 4.1 of UF (currently in develop branch).

@niksamokhvalov Unit tests and Readme has been updated. Let me know if something else is required. Thanks !


Failure in  vm/dart/gc/chunked_binary_trees_array_test/1 (Flaky failures turning to timeouts]

The tests
vm/dart/gc/chunked_binary_trees_array_test/1 Timeout (expected Pass)

are failing on configurations
vm-win-debug-x64

//cc @rmacnak-google

This test is meta-flaking: https://dart-ci.web.app/#showLatestFailures=false&test=vm/dart/gc/chunked_binary_trees_array_test/1&configurations=vm-win-debug-x64


[bug] can't continue to use the program after opening dropdown and closing it.

after troubleshooting, i found that a style pointer-events: none; was added to the body after the button was clicked.


Got some GIT merge conflict lines in source

https://github.com/ivmarcos/react-to-pdf/commit/8404d09f8acafa70f39479335a6e7d8b858e4d0b#diff-6d186b954a58d5bb740f73d84fe39073R58

Thanks! Fixed in #33, v0.0.12.


Add Hash/Indexable#dig/dig?

Followup to #3536.

It would be also great to have #dig(keys : Enumerable), where keys represents a variable sequence of keys.

Thought we decided against this. It was .dig  or JSON::Any and JSON::Any won because my proposal forgot that JSON::Type included more than Hash and Array. I proposed it could be solved by making JSON.parse return Hash | Array because the 95% usecase for json is arrays or hashes at the top level, but that idea wasn't well recieved.
@j8r that method would just produce insane types.

@RX14 I understood differently, also according to your own https://github.com/crystal-lang/crystal/pull/3536#issuecomment-403773699.
@j8r That would forgo all compile-time safety, ditto what @RX14 said.
I still see it as a very handy addition to stdlib and see no reason not to implement it.

I was against dig because I thought the implementation would make the return type be the union of everything. But this implementation is brilliant.
a = {1 => [[1, 2], [3, 4]]}

p typeof(a.dig(1, 0)) # => Array(Int32)
p a.dig(1, 0) # => [1, 2]

p typeof(a.dig(1, 0, 1)) # => Int32
p a.dig(1, 0, 1) # => 2

So I see it as a very nice, convenient way, to traverse deep structures. Now we would just need to add it to JSON::Any and YAML::Any... or remove those ugly Any wrappers altogether (I'd start by adding dig/dig? to those types, and eventually decide how to remove them).

So I see it as a very nice, convenient way, to traverse deep structures.

Exactly.

... or remove those ugly Any wrappers altogether (I'd start by adding dig/dig? to those types, and eventually decide how to remove them).

Yes, please! 🎉

@Sija Do you want to add dig/dig? to Any then? At least that way this PR will be "complete".

@asterite Done.
@codenoid Indeed, good to c u back! :)

Is it GTG now? CI fails seems not related, btw.

@Sija CircleCI had a bad week in their servers.
In darwin is still failing because it trying to compile the compiler with llvm 7, which is still not supported. The dependency of the formula is llvm plain and that leads to llvm 7 right now.


Do not allow any connections inbound by default

We do not want to inadvertently increase attack surface, especially for self-managed deployments. This PR defaults inbound CIDR blocks to [] for both the load balancer and the EKS API. What might be a better UX is to not have a default and ensure the user enters their own CIDR block.

This PR is included in version 1.0.0 :tada: