multimc: unstable-2021-09-08 -> 0.6.14

Motivation for this change
Update to 0.6.14
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
22.05 Release Notes (or backporting 21.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

The launcher couldn't create a log file - the data folder is not writable errors with this when I try to run bin/DevLauncher

Yeah, that's why this PR is still in draft status. I am waiting for upstream to resolve this issue.

The multimc debranding is a breaking change. Save files are now located at ~/.local/share/DevLauncher and the config file is now called devlauncher.conf instead of multimc.conf, breaking existing installations unless manual steps are taken to migrate the save files. I think this kind of change is acceptable for the unstable branch but I will create a release note entry before publishing this PR.

Result of nixpkgs-review pr 150285 run on x86_64-linux 1

1 package built:

multimc

LGTM, MultiMC works great, thank you for this patch!
Two questions:

If we rename MultiMC to DevLauncher in Nixpkgs, can we distribute it in Hydra?
Is there a compilation option to set devlauncher.conf name back to multimc.conf?

After a bit of testing, I noticed that we cannot use Microsoft accounts if we recompile from sources, see https://github.com/MultiMC/Launcher/issues/4087.
Maybe the best option would be:

Update/rename multimc to devlauncher, a version recompiled from sources that cannot use Microsoft login.
Add another non-free package named multimc-bin which uses the upstream binary https://files.multimc.org/downloads/mmc-stable-lin64.tar.gz.

After a bit of testing, I noticed that we cannot use Microsoft accounts if we recompile from sources, see MultiMC/Launcher#4087.
Maybe the best option would be:
1. Update/rename multimc to devlauncher, a version recompiled from sources that cannot use Microsoft login.

2. Add another non-free package named `multimc-bin` which uses the upstream binary https://files.multimc.org/downloads/mmc-stable-lin64.tar.gz.

It is possible to log in to Microsoft accounts, this has been documented on the Wiki. For that reason, there is no need for multimc-bin, see this comment.
Also I can confirm that this PR works with Microsoft Accounts. (At least it did last week)

Is it ok for us to keep the package name multimc? Upstream is very clear about the name being only legaly used when refering to the prebuilt binaries from multimc.org and never for any custom builds.
Maybe creating multimc-bin and DevLauncher (we could also brand the latter ourselfes to give it a better name) could coexist as a package and multimc could fail to evaluate with an explanation and a reference to both?
Also a nice addition could be to detect on startup, that there is no config for the variant of the launcher, but for the other one, so the config could be copied over the ease the migration.

It is possible to log in to Microsoft accounts, this has been documented on the Wiki. For that reason, there is no need for multimc-bin, see this comment.

My bad, I did not realize sooner that this was possible. I just put my msaClientID and it's working fine, thanks!
I believe it's important to let the final user choice if they prefer to use a binary with upstream msaClientID (which would be non-free?) or if they rather prefer to supply their own msaClientID with the fully-opensource variant.

Maybe creating multimc-bin and DevLauncher (we could also brand the latter ourselfes to give it a better name) could coexist as a package and multimc could fail to evaluate with an explanation and a reference to both?

I mostly agree with what @thelegy proposed, but to simplify the transition I would keep the name multimc (rather than multimc-bin) for the binary distribution and mark this package as non-free (to warn users).

Also a nice addition could be to detect on startup, that there is no config for the variant of the launcher, but for the other one, so the config could be copied over the ease the migration.

Maybe we could patch the opensource variant so that it uses the same configuration as multimc to keep things simple for users.

It tried to package multimc-bin but it looks like it can't find the $HOME directory and tries to write to nix store.

I pushed the derivation in my PR but i run out of ideas about fixing this.
Also multimc doesn't push their binary tarballs with versioned names. So with every version update the package will be broken.

Superseded by https://github.com/NixOS/nixpkgs/pull/154051


Fix int mistakenly used as unsigned long

This was detected by building on FreeBSD 10.x i386
This has only been build tested and not yet verified further.

I fudged my build test and built on i386 twice. Doing this in turn breaks the build on amd64.


Two Incorrect Configurations found in app/build.gradle

implementation "org.jetbrains.kotlinx:kotlinx-coroutines-test:$coroutinesVersion" needs to be testImplementation. As for right now, it is very unneeded libraries because it wouldn't break anything.

implementation "androidx.arch.core:core-testing:$lifecycleVersion" needs to be testImplementation too.

Thanks for pointing it out. I recently noticed the same. I'll push fixes to both the issues in couple of days


network-plugin is mandatory when using userDefinedRouting

Hi,
When creating an aks cluster with UDR, it is mandatory to use the --network-plugin, even if we are using the default one (kubenet).
We get this error when not using that flag:
"ValidationError: --vnet-subnet-id must be specified for userDefinedRouting and it must         be pre-configured with a route table with egress rules"

@mracfa -
Thank you for your question.
Can you please share with us the URL of the document that you are having issues with?
Please note that we scope issues on this repo to feedback related to the docs. If you have a product question, please post it on Microsoft QnA or Stack Overflow. Thank you for your understanding.

Please add to this document that there is a need of using the flag network-plugin when creating an AKS cluster with UDR
https://docs.microsoft.com/en-us/azure/aks/egress-outboundtype

@mracfa -
Thanks again for bringing this to our attention. We have updated the Doc and it will be live once its merged.  We will now proceed to close this thread. If there are further questions regarding this matter, please tag me in your reply. We will gladly continue the discussion and we will reopen the issue.

@MonikaReddy-MSFT, After about 1 year, this document hasn't updated yet. I encounter the same issue. Thank you for your help, @mracfa !


[Admin Extension UI] Order Index AdminAction modal button won't open Shopify Admin links

Project Dependencies:

@shopify/ui-extensions: ^2024.7.0
ui-extensions-react: ^2024.7.0
react": 18.3.1

Action target: admin.order-index.selection-action.render
Describe the bug
Primary and secondary buttons the AdminAction component do not open links to Admin Panel Order page. After clicking the button, a download dialogue is opened. Other URLs seem to open with no issue.
Below is the AdminAction component
<AdminAction
            title="title"
            primaryAction={
                <Button
                    to="/orders/5199742501072"
                    target="_blank"
                    download={false}
                >
                    Link
                </Button>
            }
        >
    <ActionComponent />
</AdminAction>

Steps to reproduce the behavior:

Create Admin Action for order index page.
Add a primary action to the AdminAction component with the to/href prop set to an order detail page in Admin Panel

Expected behavior
Page relating to the URL should be opened.

This applies to all targets, any Admin Action's primary and secondary button, they will automatically download file if the target href is set to Shopify Admin links, either using HTTP or Admin protocol format

Hi! This should now be fixed--no ui-extensions update required. Let us know if you have any other issues.


Fix bug in docassert while importing an object

Codecov Report
Patch coverage: 51.22% and project coverage change: +17.04% :tada:

Comparison is base (b853b32) 42.44% compared to head (5bd42db) 59.48%.

Additional details and impacted files
@@             Coverage Diff             @@
##             main      #17       +/-   ##
===========================================
+ Coverage   42.44%   59.48%   +17.04%
===========================================
  Files          26       27        +1
  Lines        2450     3446      +996
===========================================
+ Hits         1040     2050     +1010
+ Misses       1410     1396       -14

Files Changed
Coverage Δ

sphinx_runpython/sphinx_rst_builder.py
47.87% <47.87%> (ø)

sphinx_runpython/process_rst.py
76.92% <76.92%> (ø)

sphinx_runpython/gdot/sphinx_gdot_extension.py
74.59% <83.33%> (+74.59%)
:arrow_up:

..._runpython/docassert/sphinx_docassert_extension.py
26.17% <88.88%> (+26.17%)
:arrow_up:

... and 11 files with indirect coverage changes

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Add test suite to the project

We need a standard test suite, particularly as we add new capabilities.
@sglanzer I prefer mocha and have some boilerplate that makes it easier to test addons - any strong preference for mocha vs qunit?

Definitely fine with mocha - I prefer the language, but stuck with qunit in my last project (ember-cli-mocha wasn't available at the time).  More than happy to see some examples/try it out in this project.

cool - I’ll also publish a test project with the lcov-writing branch so folks can check it out - I’m wrapped on other stuff for a day or two but will get back to it

On Apr 1, 2015, at 11:55 PM, Steven Glanzer<EMAIL_ADDRESS>wrote:
Definitely fine with mocha - I prefer the language, but stuck with qunit in my last project (ember-cli-mocha wasn't available at the time). More than happy to see some examples/try it out in this project.
—
Reply to this email directly or view it on GitHub https://github.com/sglanzer/ember-cli-blanket/issues/39#issuecomment-88719229.

Fantastic, thanks!

closed by #38


Release 1.6

Description
merge release-1.6 into master
Issue reference

Please reference the issue this PR will close: #[issue number]
Checklist
Please make sure you've  completed the relevant tasks for this PR, out of the following list:

[ ] Code compiles correctly
[ ] Created/updated tests
[ ] Unit tests passing
[ ] End-to-end tests passing
[ ] Extended the documentation / Created issue in the https://github.com/dapr/docs/ repo: dapr/docs#[issue number]
[ ] Specification has been updated / Created issue in the https://github.com/dapr/docs/ repo: dapr/docs#[issue number]
[ ] Provided sample for the feature / Created issue in the https://github.com/dapr/docs/ repo: dapr/docs#[issue number]

@dmitsh do not use release branch to merge to master ... Create a branch off of release branch and then merge that to master via a PR ....


Maybe one additional step could be added...

As it relates to the Exchange Zero-Day (which is how I got directed to this page (https://msrc-blog.microsoft.com/2022/09/29/customer-guidance-for-reported-zero-day-vulnerabilities-in-microsoft-exchange-server/)), aren't we missing steps to only setup allowed access for a specific user or a set of users so that a connection can't be made by anyone other than those that have been specified. I understand this comes with risks (lock-out) but as long as the risk is known users can decide the right direction. I feel like what needs to be shared are the steps to setup approved access and then how to block all other non-approved access.

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: d03c6ce2-687b-e138-939b-413014d1c81a
Version Independent ID: 9fe6c492-d0fe-e454-6574-06de8cd31a21
Content: Control remote PowerShell access to Exchange servers
Content Source: exchange/docs-conceptual/control-remote-powershell-access-to-exchange-servers.md
Service: exchange-powershell
GitHub Login: @chrisda
Microsoft Alias: chrisda

@Phantom-309, don't the options in Use the Exchange Management Shell to disable remote PowerShell access for many users meet the needs of the scenario you're describing? I'm not exactly sure what's missing in that regard.
Just yesterday I added the following note to the Exchange Online version of this topic:

[!IMPORTANT]
Don't run commands like Get-User | Set-User -RemotePowerShellEnabled $false to universally remove remote PowerShell access without considering admin accounts. Use the procedures in this article to selectively remove remote PowerShell access, or preserve admin access for at least one account by using the following syntax in your removal command: Get-User | Where-Object {$_.UserPrincipalName -ne<EMAIL_ADDRESS>| Set-User -RemotePowerShellEnabled $false.
If you accidentally lock yourself out of remote PowerShell access, create a new admin user account, and then use that account to give yourself remote PowerShell access.

Would adding something like that help?

I was looking at it from more of a firewall policy perspective. The how-to steps to ensure only authorized access is allowed could be more of a 2 step process. Step 1 - setup approved access for one or more users. Step 2 - block all other access. Step 2 (if it can even be done this way) is the part I was suggesting would be quite risky, but I see it as needing to follow more of a firewall policy type perspective (add a policy for what should be allowed, below the allowed rule block everything that didn't match the allowed access).

What you're describing makes sense, but I think the firewall configuration analogy gets a little messy here. Keep in mind: PowerShell access is already on by default for everyone, so you don't need to do anything to specify who should have it. The only action required is to turn it off for those who shouldn't have it (and possibly the addition of "don't go crazy turning it off for everyone all at once without considering admin accounts, service accounts, etc.", as I previously described).

I understand and thank you. I guess it's more of a desire for it be configurable in another way. Allow only those you setup and by default block everyone else thereafter.

I did added the "don't shoot yourself in the foot" information and did a bit of other clean-up. Hopefully, that helps.

@Phantom-309 Hope this update is helpful for you. Thanks for taking out some time to open the issue. Appreciate and encourage you to do the same in future also.


terminate called after throwing an instance of 'std::bad_alloc'   what():  std::bad_alloc Aborted (core dumped)

Hi, great work so far! I've been experimenting with fastbox and have been able to get the demo to work. However, when I try to retrain my own model with the same Kitti dataset I'm getting the following error message when I run: python train.py
terminate called after throwing an instance of 'std::bad_alloc'
what():  std::bad_alloc
Aborted (core dumped)

This sounds like you don't have enough memory to hold a batch. What is your batch_size value? How much memory do you have on GPU? Try to decrease your batch_size until tensorflow stop complaining about it.

Closed due to inactivity. Should be fixable with a smaller batch size or bigger GPU memory. I recommend using 1080 TI for deep learning.


add destination argument to load_file

For our uses in file sharing it would be great if load_file implemented the same dest=filepath optional argument as in kachery-client.

Hmm. I'm not actually sure. The code I had written was
           # load the file and save it in the nwb_file_path location             kc.load_file(uri=nwb_uri, dest=nwb_file_path)
With the idea that the file would be downloaded to the local system and saved as nwb_file_path
I hadn't tested it, though. What would you suggest here?

@lfrank this is now available in version >= 0.1.23


Cursor loses horizontal position

Cursor loses horizontal position on short lines when plugin is active
To reproduce, open bug.jsx with the plugin active (the only plugin, installed natively, no vimrc, vim 8.1.610).
Place your cursor on the '2'.
Press j twice.
Without the plugin installed (or in a non-js file), your cursor will be on the '5'. With the plugin, it will be on the '4'
bug.jsx
123

456

Thank you report 👍
Right reproduced the problem.
Broken horizontal place of cursor when handle ICursorMove event in ftdetect.vim.
https://github.com/MaxMEllon/vim-jsx-pretty/blob/master/after/ftplugin/javascript.vim#L18-L21
i try fix to the timing of update highlighting.

workaround:
-augroup jsx_comment
-  autocmd! CursorMoved <buffer>
-  autocmd CursorMoved <buffer> call jsx_pretty#comment#update_commentstring(b:original_commentstring)
-augroup end

But apply this, vim-jsx-pretty dont update highlighting when cursor moved.

This implemented a feature which can automatically update the comment string in the JSX file (#51).

@mnbroatch This issue should have been fixed now, you can verify it by yourself.

Thanks guys!


Update for the nuget package

Please update the nuget-package to catch up with the latest version, including support for .NET Core

I spoke with Samuel, and he does not have control over the NuGet. I also emailed the maintainer of the NuGet and he was unresponsive. Maybe a little more noise would help the NuGet updated.

As a last resort we could publish an alternative nuget package and make it official

An alternate nuget has been created: MediaTypeMap.Core


Update ixa - Closes issue #28

As described in issue #28, removed unnecessary module name in ixa imports, updated main to use ixa runner with custom args, and use sample_person. A couple of things to highlight:

sample_person does not yet allow to filter by a person property, so making a safe assumption here that everyone is alive at time t = 0.
It's a bit confusing to use custom_args for boolean values. For instance, I used the force_overwrite flag to determine whether or not to overwrite reports. If not specified, I would assume the value is false, but if not specified, custom_args would not exist, so I still need to do if let Some(custom_args) = custom_args {}else{}, which seems a bit unnecessasry.

I can see that my tests aren't working, probably pre-commit issue. Working on fixing that.

I just added sample_person() with a query

I just added sample_person() with a query

Thanks! Just updated the code.

As described in issue #28, removed unnecessary module name in ixa imports, updated main to use ixa runner with custom args, and use sample_person. A couple of things to highlight:

sample_person does not yet allow to filter by a person property, so making a safe assumption here that everyone is alive at time t = 0.
It's a bit confusing to use custom_args for boolean values. For instance, I used the force_overwrite flag to determine whether or not to overwrite reports. If not specified, I would assume the value is false, but if not specified, custom_args would not exist, so I still need to do if let Some(custom_args) = custom_args {}else{}, which seems a bit unnecessasry.

All my initial comments about sample_person and custom boolean args have been solved with ixa updates.


Figure(s)/table(s) that appear in your report should be generated programmatically for maximum reproducibility

Hi @ericlee0920, our script have been edited to generate the figures programmatically as advised. Thank you for your feedback👍


using AffectNet8_Swin_VA without the pretrained model from AffectNet8_Swin_Combined, the validation ccc only is 0.51

not using the pretrained model from AffectNet8_Swin_Combined, the codes are as following on AffectNet8_Swin_VA,
MODEL = models.swin_v2_t(weights="DEFAULT")
# MODEL.head = torch.nn.Linear(in_features=768, out_features=10, bias=True)
# MODEL.to(DEVICE)
# MODEL.load_state_dict(torch.load("../AffectNet8_Swin_Combined/model.pt"))
MODEL.head = torch.nn.Linear(in_features=768, out_features=2, bias=True)
The performance on NUM_EPOCHS = 25 only has  0.51

for AffectNet8_Maxvit_VA, it is close to the report result, I got 0.75 of ccc after using the default  NUM_EPOCHS = 20

Hi @tempbrucefu, thanks for sharing your information.
Your metholody of not using a fine-tuning approach and your insights are very interesting.
Without a dedicated pre-trained model, we also noticed quite unstable gradients for only VA.
As known from literature, keep in mind that such training could require way more epochs than 25 to achieve similar results and especially different architectures operate different.
Best regards


Document newsletter processes

Thanks @nlharris ! I'll leave this open until I complete this newsletter cycle, as I'm sure I'll need to add items/amendments as it all plays out.


Group events listing by location

http://coderetreat.org/events has several events in Istanbul at the moment, but they are not grouped together.
It would be awesome to have a quick alphabetical sort or something in the view model to visually organise same-city (or same-country) events together!

I agree, there's a very crude listing here but we could totally use a bigger map. We've opened a somewhat related ticket at #26 a few weeks ago.
OpenLayers seems to have pretty good support for clusters, I'm sure we could come up with something like this.
Marking this as Help Wanted for the moment as it's fairly isolated and makes for a nice first contribution.

I was able to make the list sort by location, but the built in Liquid sort operation doesn't support nested properties so it only sorts the city.
I guess one way to fix it is to use a jquery tool that does the sorting...in fact I think I'll get that done.

There is also this page that displays past events on a map, including listing the events by year.
http://coderetreat.org/events/past-events/

So here is what I did to cluster the events on the map:
https://github.com/coderetreat/coderetreat.github.io/tree/clusteredMap
@rradczewski, please have a look. If it looks good, we can merge it to master.

Looks good @apandichi. Would've been easier if you would've opened a PR because netlify automatically adds the deployment to the PR.
Still left would be some more organization to the table and maybe adding the map there again 👍

Now that the pull request #85 is merged into master, I would say this issue is dealt with.
@mdizzy, does the latest code conflict with what you had going on regarding sorting the events? If so, let me know if I can help in any way.

no doesn't conflict at all. Is there a preference on a JS library? I think Knockout should be able to handle this without a problem.
Also, Heroku has a free tier that should be able to handle the load for the website. If not I'd be willing to donate monthly dynos for the site. This would let us run the site with a full database and backend framework.

I consider this fixed

Hi @mdizzy, thanks for the offer! We discussed Heroku briefly but decided that adding a backend would mean adding a lot of complexity that we don't really need. I will create an issue about migrating to netlify next year as that would give us much more control about the build process, but that's about all we need right now.


error in _jstrans.js

Hello,
there is an error in the _jstrans.js file: an extra ";" at line
babel.plural = function(n) { return ((n != 1);); }
compiled from
js.append(c2js(m.lower().split("plural=")[1]))
Flask-Babel==1.0.0
Flask-Babel-Js==1.0.2

I had the same issue.
It was due to my po file. I used poedit to edit it, and it added a semi-colon to "Plural-Forms".
I removed it and it work as intended now.

Same problem, tried to edit .po file with Poedit and Lokalize, same results in both programs. As far as I understand, when .po file compiles into .mo version, compiler adds semicolon at the end of plural=...
If you open .mo version with some text editor, you will see something like this:
Plural-Forms: nplurals=3; plural=(n%10==1 && n%100!=11 ? 0 : n%10>=2 && n%10<=4 && (n%100<10 || n%100>=20) ? 1 : 2);

I created a PR  with the suggested fix from @solsticedhiver.

I have the same problem... no correction after 2 years??

Fixed with #5. Sorry for not taking a look for a long time.

@BornSupercharged @bbird81 I just released 1.0.3 to PyPI. Could you please test and let me know? I currently don't have the means to set up a test project for this (see #9 for future plans once I do).

@emdemir yes 1.0.3 works properly thank you!


Upgrade to ruby 2.1.5

Addresses #219.
Uh, the tests pass, so surely that means the upgrade was a success.

Doh! Travis file! Do you prefer squashing commits or you want this separate?

I'm fine with either — lemme know if you wanna squash (feel free to do) and I can merge. Thanks! :+1:

Ok, squashed.

Sorry for falling down on this! Without support I haven't had time to act as a proper maintainer. Luckily with help from others this issue's now resolved so closing.


Add a new configuration to set a custom cache key.

Description:
Add a new configuration to set a custom cache key.
Justification:

I have a workflow that touch the pom leading to invalidate the cache after each run.
Some of my other projects use native compilation, meaning compiling in Windows, Mac, and Linux and I would like to share maven local cache.
optionally i don't understand why the cache key is per platform / packager / pom hash. Java is multiform, we have one maven central whatever the platform you are using, cache should reflect that.

If you thing your cache is corrupted (really rare), just trash it.

Are you willing to submit a PR?
why not, I'm a coder but no strong skills with ts.
Chris.

Hi, @ouaibsky 👋 Thanks for the issue! Cache strategy in our action is chosen according to the recommendations from the cache action. If you need other behavior, you can turn off the caching in our action and instead rely on actions/cache which you can configure by yourself. I'm closing this issue now, If you have any questions feel free to ask me.


Right sidebar in model form

Hello,
It would be great to be able to put form elements into a right sidebar in backend.
(See an example with this plugin)[https://octobercms.com/plugin/netsti-frontend]
I looked at the module, actually, it's done by "hacking" the secondary tabs element. It would be great to have a real sidebar wrapper in model form to create interfaces like this without any hacking.

Closing as it has been over a month since any activity on this occurred.


Ensure the dbadmin and any other admin areas are secured

We now have a role based system. We should make sure only "Administrators" can get to the ddadmin.

Fixed by 9d9162c35948515939f97c2eaa8fceb3c2c947be and amended by 52b53c71cc93048b3402c90eb3214820c728d92f


Syntax for adding other HTTP methods to URLFETCH

Currently the URLFETCH fonction only support GET method. The signatures are:
url:STRING headers:MAP<STRING> URLFETCH
urls:LIST<STRING> headers:MAP<STRING> URLFETCH

with headers being optional.
To support additional methods, I suggest:
request:MAP<STRING> headers:MAP<STRING> URLFETCH
requests:LIST<MAP<STRING>> headers:MAP<STRING> URLFETCH

where request shall have the fields 'url', 'method' and optionally 'message', and headers are still being optional.
Is that signature good ?

It looks good, even if I think the keys of the map could have a different name (url, verb and body or payload).
Too bad I added the header signature without thinking about that kind of signature before because it would definitively make sense to have also a header key in the map you want to define. As it is a fresh addition (2.7.0) maybe should should consider breaking the header signature to allow
request:MAP<STRING> URLFETCH
requests:LIST<MAP<STRING>> URLFETCH

with requests containing a header key.

Not sure about verb, I think method is more explicit. I agree with body or payload instead of message though. I think body is better.
Putting a MAP inside a MAP makes for a bit clunky codes.
Maybe, we can add only the signature request:MAP<STRING> headers:MAP<STRING> URLFETCH, and not the second one, since anyway, the second signature is not that much of a gain compared to using FOREACH or LMAP, and it doesn't always make sense to use the same headers for all requests.

Agreed on url/method/body keys.
I'm not convinced that maps of maps are a problem but breaking the 2.7.0 is more of a problem, I think @hbs is best to arbitrate on that. If we want to keep backward-compatibility I think both
request:MAP<STRING> headers:MAP<STRING> URLFETCH
requests:LIST<MAP<STRING>> headers:MAP<STRING> URLFETCH

are nice to have, even if, I do agree, it can be done with FOREACH or LMAP.

Also,there might be an issue for the signature request:MAP<STRING> headers:MAP<STRING> URLFETCH. Since headers is optional, URLFETCH would have to check if the first map it retrieves from the stack is a headers or request. I don't see a way to do this without limiting the names of the fields that are allowed in headers.

I intend to run many URLFETCH at once (it's a data platform and users can run their scripts as they please) which can quickly hog all memory so a streaming option could be really useful. Otherwise, I need to limit URLFETCH maxsize which is not ideal.
Maybe something like requests:LIST<MAP<STRING>> headers:MAP<STRING> chunk_size:LONG URLFETCH. chunk_size can be -1 by default but if set, it returns chunks of content with that size as an iterator.
Another way could be requests:LIST<MAP<STRING>> headers:MAP<STRING> start_byte:LONG end_byte:LONG URLFETCH end:BOOL content:STRING. When start_byte and end_byte are defined URLFETCH reads and drops all data before start and reads until end_byte. If the end of the stream is reached, end is set to True.
I expect it to be slower but scales much better.

Maybe an idea similar to https://github.com/senx/warp10-platform/pull/855 can be used with a byte delimiter (or a chunk size) and a macro to be run for each of these chunks.
The other way around, for POST, a macro could create chunks to be sent, but that may be overengineering.

This suggestion was added in PR #891

Solved by PR #891


FAQ instructions

In the FAQ instructions it says: Text purpose to provide specific information about something or instructions on how to do something. Perhaps this sentence about instructions could be removed so that it won't confuse the annotators. Unlike CORE, we haven't used FAQ about how-tos in our annotations.

edited.


[wip] fix: always assign a trace ID to each request

Fixes #1025
We already store untraced requests (via a single object representing ALL untraced requests) in CLS, this changes it so that these objects also have a trace ID (and span ID, though not sure if it is useful).

Actually, marking this as WIP (don't review) while I figure out what to do when we call Tracer#createChildSpan.


tcmalloc: pthread_atfork and dynamic linking

Hello.
I have an application using tcmalloc and fork.
I experienced random deadlocks after forking and after some investigating it turned out that pthread_atfork is nullptr.
Production OS is CentOS 6 or 7.
Then I tested it on my laptop with Ubuntu 18.04 Linux 5.1 and result was non-null. Dynamic linking on my computer works.
LD_PRELOAD doesn't have any effect on CentOS.
pthread is linked after libtcmalloc.a
I've made some code to show this result.
In maybe_threads.cc I added fprintf to get value of function pointer
  fprintf(stderr, "POINTER: %p\n", pthread_atfork);
  if (pthread_atfork) {
    int rv = pthread_atfork(before, parent_after, child_after);
    CHECK(rv == 0);
  }

Then I wrote simple CMake project:
cmake_minimum_required(VERSION 2.8)
project(tcmalloc_weak)

link_libraries(***PATH TO libtcmalloc.a*** pthread)
add_executable(tcmalloc_weak main.cpp)

and main.cpp:
#include <unistd.h>
#include <thread>

int main()
{
	std::thread([] { while (true); }).detach();
	return 0;
}

If I run this binary on my laptop result is something like that:
POINTER: 0x7f1c18dcd8f0

If I run on CentOS:
POINTER: (nil)

Tests were on Ubuntu laptop and in centos 6 and 7 docker containers on the same laptop.
GCC-8
Solution is to remove weak attribute from pthread_atfork and link tcmalloc with pthread.
But I don't want to live forever with patched tcmalloc library, maybe you can help me find better solution?
I don't know why function is not linked on CentOS.

It turned out that there were no any pthread_atfork symbols at executable.
I found that order of symbols in libtcmalloc.a in maybe_thread.cc is different on Ubuntu and CentOS, then I decided to add --with-fpic on configuration gpreftools.
It solved my problem and symbols were added to executable.
A couple days of testing new binary will show if deadlocks are gone.

@smirnov-vs , are you running on ARM? I can see this issue too, but only on ARM.
It seems that pthread_atfork does not exist on libpthread.so.0 but instead it's present in  /usr/lib64/libpthread_nonshared.a which is implicitly linked in when you add -lpthread because /usr/lib64/libpthread.so is a linker script.
The implementation of pthread_atfork just calls __register_atfork as far as I can tell.
So the trick of marking the declaration as weak and relying on dynamic linking won't work for this case.

aha, thanks. Very interesting. Also unsure what is going on. On my very up-to-date debian sid I do get:
user@big:~/src/External/gperftools# objdump -T /lib/x86_64-linux-gnu/libc.so.6 | grep atfork
0000000000090b50 g    DF .text<PHONE_NUMBER>00000c (GLIBC_2.2.5) pthread_atfork
00000000000d39b0 g    DF .text<PHONE_NUMBER>0001bd  GLIBC_2.3.2 __register_atfork

But also yes nonshared thingy too:
root@big:~# objdump -t /usr/lib/x86_64-linux-gnu/libc_nonshared.a | grep atfork
pthread_atfork.oS:     file format elf64-x86-64
0000000000000000 g     F .text<PHONE_NUMBER>00000c .hidden __pthread_atfork
0000000000000000         *UND*<PHONE_NUMBER>000000 __register_atfork
0000000000000000  w    F .text<PHONE_NUMBER>00000c .hidden pthread_atfork

Hm, I guess worth checking what other mallocs do. Ours might be one of few that tries to avoid libpthread dependency (this is because some libraries, most notably c++ bits, occasionally enable more expensive codes when threading is activated (and btw they're likely spending more on overheads than actual stuff like atomics but well...))
I.e. it is not huge deal, but I would like us to find way to keep optional-ness of pthread dependency.

Aha. Indeed glibc does the static library thing so that atfork can also silently pass DSO handle. So that when library is unloaded, it's atfork handlers get dropped as well.
As for pthread dependency being optional, yes, worth dropping that.
Original idea for that is that some libraries tweak their behavior if threading is active or not. And that could/does affect performance. Way way back, libc was one of these. This days libstdc++ has some bits that depend on threadiness. Most notable is shared_ptr bits which do refcounting non-atomically in single threaded programs (but code bloat is imo worse). clang's c++ library doesn't do that runtime code bloat thingy and they're right.
However:
a) glibc (but not musl) already has sys/single_threaded.h with __libc_single_threaded variable and stdc+++ check this. It becomes true after threads are actually created as opposed to -lpthread linked in. And this days libc's libpthread is empty anyways. So us pulling -lpthread as dependency won't affect libstdc++
b) on musl pthread symbols are always available and my understanding is libstdc++ will always behave as if threading is active (bit still have code bloat I think). Same appears to be the case for osex, but they do clang's libc++ anyways.
c) various BSDs and perhaps solaris could benefit from us not pulling -lpthread, but we already do somehow. I checked that libtcmalloc already depends on threading library
So, yes, time to simplify everything and just do threads all the time


Root CA not added to certlm.msc(Local Machine Cert), just added to certmgr.msc(Current User Cert)

Operating system: Windows 10/11
mkcert version : v1.4.4

When I use it in Windows Services, the certificate becomes invalid,
and I found the reason, Windows Services run as SYSTEM not current user，
use certmgr.msc  and certlm.msc to compare differences

then I copy the mkcert Root CA from certmgr.msc  to certlm.msc，problem solved.
Can mkcert -install add Root CA to both of them？Administrator privileges may be required.

Same issue here, not on all machines though


Pulsar to py3k

:us::fireworks::us::fireworks:

https://github.com/galaxyproject/ansible-pulsar/pull/6 needs to be merged / tagged 1.0.0 (breaking changes)

This almost works, pending the issues with requests currently being debugged.

Are we not using the pip install so as to get the latest changes Marius was working on?

Are we not using the pip install so as to get the latest changes Marius was working on?

no, per some discussion it was removed from the role, figuring that we could just use the proper release procedure, but I guess we'll need to use a workaround here.

We can pip install from git+https github, right?

Should be. If not i get to back out my changes in ansible-pulsra.

pulsar_package_name: git+https://github.com/galaxyproject/pulsar@commit#egg=pulsar-app


v1.2.4 breaks filterFields behavior

Winter CMS Build
Other (please specify below)
PHP Version
8.1
Database engine
MySQL/MariaDB
Plugins installed
No response
Issue description
The following PR breaks existing filterFields behavior: https://github.com/wintercms/winter/pull/927
Steps to replicate
Try to access a model attribute via $this, e.g. $this->someAttribute, in the filterFields method. Before v1.2.4 the model attributes are populated but after v1.2.4 they are all null.
Example use case:
public function filterFields($fields, $context = null)
{
    if($this->someExistingAttribute) {
        throw new \ApplicationException('some message');
    }
}

The above never evaluates to true because $this->someExistingAttribute is null.
Workaround
No known workaround.

Are you saying that commenting out the call in PR #927 fixes the problem?

@mjauvin Yes it did

In your filterFields method, just use the $context argument to make sure you're in update context. In create context, the model's fields have not been set yet.

@mjauvin I need this to work in the create context as well. It worked pre 1.2.4.

The only thing different is the call to applyFiltersFromModel() in getSaveData().
And the only thing this does is call your model's filterFields() method:
    protected function applyFiltersFromModel()
    {
        /*
         * Standard usage
         */
        if (method_exists($this->model, 'filterFields')) {
            $this->model->filterFields((object) $this->allFields, $this->getContext());
        }

Could it be that at this point the model attributes are not yet populated? Like I said, reverting this change fixes the issue

In create context, the model has not been created yet, so this is expected behavior.

@msimkunas could you in your listener just check to see if the relevant attributes are set yet and return early if they are not? It will still be fired where it was before, this change just added another point in the request lifecycle where it could be fired.

That's my take as well, unless we're missing something.


Subtitles download

from pytube import YouTube

yt = YouTube(https://youtu.be/nI9BL4AB5Y0)
caption = yt.captions.get_by_language_code('en')
caption.xml_captions
'well i&#39...'
all =caption.generate_srt_captions()
print (all)

In this video , there is two subtitles
1.English automatically generated (code="en")
2.English (code="en")
I want to download only English caption, not English automatically generated. So can't download english. It's always download automatically generated. Help me.

Just use the following function
def get_caption_by_language_name(yt, lang_name):
	for caption in yt.caption_tracks:
		if caption.name == lang_name:
			return caption

get_caption_by_language_name(YouTube(url), 'English') will return the English caption. Replace 'English' with 'English (auto-generated)' for the auto generated caption. Do a print(YouTube(url).caption_tracks) to see all available captions and their language names.

Thanks it's work


#162618072 Add create a parcel button to get a quote page

What does this PR do?
Add create a parcel button to get a quote page
Description of Task to be completed?
To allow users to create a parcel using information provided to the parcel quotation page
How should this be manually tested?

Login
Navigate to Get a Quote page
Fill the required information to see Make order button appear

What are the relevant pivotal tracker stories?
#162618072

Codecov Report

Merging #39 into develop will increase coverage by 0.79%.
The diff coverage is 100%.

@@             Coverage Diff             @@
##           develop      #39      +/-   ##
===========================================
+ Coverage    81.37%   82.16%   +0.79%
===========================================
  Files           25       25
  Lines          451      443       -8
===========================================
- Hits           367      364       -3
+ Misses          84       79       -5

Impacted Files
Coverage Δ

server/src/models/Parcel.js
69.81% <ø> (+1.29%)
:arrow_up:

server/src/controllers/parcels.js
96.29% <ø> (ø)
:arrow_up:

server/src/controllers/users.js
60.37% <ø> (+1.11%)
:arrow_up:

server/src/models/User.js
87.09% <ø> (+2.72%)
:arrow_up:

server/src/models/BaseModel.js
73.49% <100%> (+1.4%)
:arrow_up:

server/src/helpers/getPrice.js
100% <100%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d67d6ca...0be54ff. Read the comment docs.


Backend: Featured Content Molecule

Backend model for Featured Content
Testing

Create a sublanding page and include featured content in the header section

Review

@jimmynotjim
@kurtw

You need to add a migration file.

The Featured Content block won't render because the template is looking specifically for either the Hero or the Text Introduction. Before @kave knows where to actually put the rendering, @sebworks should the Featured content be rendered here?

@kurtw hah yea i forgot the migrations. i'll add that in
@jimmynotjim @sebworks is this wiki image still valid for including featured content in the header?

@kurt, it is my understanding that it should just be using the Text Introduction molecule.

@sebworks @kurtw sounds good. heres an example of what it looks like:

That seems like it would go in there hero block? @kave

Yeah, the FCM does not go in the hero space, it goes in the left content below the text intro

alright i'll swap their locations

@kave Re-posting since it probably got lost in your later commits:

users dont want to add an alt on the cms end

Wait, what? Where is it going to be added, then?

@kave Sorry if it wasn't clear, it should be included with the rest of the content in the main content area. It shouldn't span the entire width of the page. Check the landing-page demo on the flapjack branch to see it locally.

@Scotchester it won't be added at all. i think @jimmynotjim maybe able to give you some more clarification

after some discussion it was decided to move FCM to main content

Sorry, but I'm confused. I included an alt in the prototyped data because as @Scotchester says, there should be one. All images uploaded in the CMS should include a field for an alt tag, it's standard for us to be in compliance with Section 508.

@jimmynotjim alright then there was previous miscommunication on the image atom on the content editing side of things. i'll update all the molecules to have an alt field

Should the background color be entered with a color picker instead of a text box/

@sebworks i think thats a broader discussion on what colors are our "official" colors to use. lets create an issue to resolve that

What happens when you attempt to upload a large image in the hero?

@sebworks it gets resized

Can you attempt to upload this image in the hero?

@sebworks looks like wagtail has an issue with uploading gifs. can you create an issue to be looked into.

:+1:

Tried another gif and it worked fine so I'm not sure what is the real issue. Looks good to go though.

:+1:


Clarify README regarding location of include Devise::TestHelpers

I spent hours in frustration googling various Devise and Warden error messages I was getting while running tests for a Rails project, and it turns out the issue is that I had added the line include Devise::TestHelpers to the bottom of ActiveSupport::TestCase (the class which is by default already reopened in test_helper.rb), rather than reopening ActionController::TestCase and adding it there.
And my investigation into google results revealed that I am far from the only person who made this mistake. I found a number of other instances, and a lot of people seemed to going down rabbit holes and following false leads trying to figure out why Devise testing wasn't working as it's supposed to. It's apparently an easy mistake to make.
I think it would be good to explicitly state in the README that this mixin should not be included ActiveSupport::TestCase. It's too easy to overlook that the README is showing ActionController::TestCase instead.

Hey, I am happy to look into that and will get back to you asap.

Fixed and made PR https://github.com/plataformatec/devise/pull/3941

PR merged, gonna close this issue.
Tks for your report @cartrdgeengineering!

Wow, impressive response time! Thank you!


Bump version 1.3.7

@zabil here you go -- don't forget the label ;).

It's supposed to trigger this pipeline https://github.com/getgauge/taiko/actions/workflows/release.yml
And for some reason that's not happening. Need to 🔍

Does it need to be tagged too for it to run or does that happen automatically during the build?

There's a bot that monitors all PR merges and triggers the release workflow. I suspect the bot maybe down.

I think I know why.
Gauge bot was running on heroku at https://gauge-bot.herokuapp.com
And they've stopped supporting a free tier.
Will need to make alternate arrangements for automatic release.

Ah I see. That makes sense. Maybe a google function in the always free tier?
On Sat, Dec 17, 2022 at 9:38 AM Zabil Cheriya Maliackal <
@.***> wrote:

I think I know why.
Gauge bot was running on heroku at https://gauge-bot.herokuapp.com
And they've stopped supporting
https://blog.heroku.com/next-chapter#:~:text=Starting November 28%2C 2022%2C we plan to stop offering free product plans and plan to start shutting down free dynos and data services. We will be sending out a series of email communications to affected users.
a free tier.
Will need to make alternate arrangements for automatic release.
—
Reply to this email directly, view it on GitHub
https://github.com/getgauge/taiko/pull/2673#issuecomment-1356350430, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AAFQVOXNJHHVSHR5QWUDQGDWNX275ANCNFSM6AAAAAATARIA4Q
.
You are receiving this because you authored the thread.Message ID:
@.***>

Gauge bot is built using probot and it has an option to for deployment as netlify function
This looks like the best option as netlify graciously gave us an open source license and it's free. We can also use github logins to manage access.
Netlify functions can pull from the https://github.com/getgauge/gauge-bot repo. Will explore that option.

Nice! That’s very cool of them 👍🏼
On Sat, Dec 17, 2022 at 11:27 AM Zabil Cheriya Maliackal <
@.***> wrote:

Gauge bot is built using probot and it has an option to for deployment as netlify
function https://probot.github.io/docs/deployment/#netlify-functions
This looks like the best option as netlify graciously gave us an open
source license and it's free. We can also use github logins to manage
access.
Netlify functions
https://www.netlify.com/blog/2021/12/11/serverless-functions-made-simple-just-add-files/#:~:text=How to add serverless functions,That's it.
can pull from the https://github.com/getgauge/gauge-bot repo. Will
explore that option.
—
Reply to this email directly, view it on GitHub
https://github.com/getgauge/taiko/pull/2673#issuecomment-1356403648, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AAFQVOTRFM3AWXQZ5XL66DDWNYH2JANCNFSM6AAAAAATARIA4Q
.
You are receiving this because you authored the thread.Message ID:
@.***>

Still working on a PR to fix this on Gauge bot. Will be a bit slow because of the holiday season.

@marques-work
Managed to deploy the bot as a netlify function at https://bot.gauge.org
Can you raise a PR upgrading packages and the version number? I'll label it as a release candidate and merge it to trigger a release.

Sure, thanks Zabil!
On Wed, Jan 11, 2023 at 2:20 PM Zabil Cheriya Maliackal <
@.***> wrote:

@marques-work https://github.com/marques-work
Managed to deploy the bot as a netlify function at https://bot.gauge.org
Can you raise a PR upgrading packages and the version number? I'll label
it as a release candidate and merge it to trigger a release.
—
Reply to this email directly, view it on GitHub
https://github.com/getgauge/taiko/pull/2673#issuecomment-1379559406, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AAFQVOWSBB2BG6OYGPDYW53WR4W2HANCNFSM6AAAAAATARIA4Q
.
You are receiving this because you were mentioned.Message ID:
@.***>


"Cenade" is listed in the drop-down menu

Description:
"Cenade" is listed in the drop-down menu alongside its corresponding county and commune, according to the law
Precondition:
The website is up an running.

Step 1
Type "Cenade" in the search bar.

Expected results
The location is listed in the drop-down menu as "Cenade, Alba".


Poll for all running activities on a day from Strava and suggest the fastest 5km segment of these

A single user may have several running activities in Strava for a single day; a 5km segment from the first one is only suggested by the app
example:
Run 1
Sat, Nov 11, 2023, 10:12 AM
Huawei Health activity
Run 2023-11-11 10:12:43
Distance	5.06 km
Avg Pace	8:28 /km
Moving Time	42m 52s
Run 2
Sat, Nov 11, 2023, 1:04 PM
Huawei Health activity
Run 2023-11-11 13:04:42
Distance	5.06 km
Avg Pace	5:49 /km
Moving Time	29m 29s
The app selects
Huawei Health activity
11.11.2023
5.00/5.06 km
43:24/43:47
as best result for the weekly selfie rating

@shteryana  Can you add a link to the Strava profile with those runs?

I guess this issue can be closed; the second running activity was missing due to Map Visibility set to "Hide Entire Map" for the specific route in Strava

Actually, I have a better idea - this is something that often confuses people thinking that the application doesn't work correctly. We can do something to address that:
When there is a run that is excluded from the list due to not having a map - a message should be added on top stating that "N runs were skipped due to not having a visible map in Strava" or something like this.
This will be a great first task for somebody who wants to be onboarded on the project.


Error: Error while waiting for Protractor to sync with the page: "both angularJS testability and angular testability are undefined.  This could be either because this is a non-angular page or because your test involves client-side navigation, which can interfere with Protractor's bootstrapping

Hi there!
Thanks for submitting an issue to Protractor.
To help us help you better, please do the following before submitting an issue:

Review the questions section of CONTRIBUTING.md.
Make sure you are not asking a usage or debugging question. If you are, use StackOverflow, Google Group discussion list, or Gitter to get help.
Provide a minimally reduced test case. This makes it much more likely that your bug will be fixed. Protractor has a test Angular application available at http://www.protractortest.org/testapp which you can use for the reproducible test case.
Fill in the information that corresponds to your type of issue below.
Delete this intro and any unrelated text :smile: (if you do not we'll assume you haven't read these instructions and automatically close the issue.)

Bug report

Node Version: ``
Protractor Version: ``
Angular Version: ``
Browser(s): ``
Operating System and Version ``
Your protractor configuration file
A relevant example test
Output from running the test
Steps to reproduce the bug
The URL you are running your tests against (if relevant)

Feature Request

Reasons for adopting new feature
Is this a breaking change? (How will this affect existing functionality)

Please provide repo steps, configuration file, console log etc. Simplying providing an error message is not helpful.

Hi! This looks like a support question. Please ask your support questions on StackOverflow, Google Group discussion list, or Gitter. For more information please reference https://github.com/angular/protractor/blob/master/CONTRIBUTING.md#questions
Thank you!

This was not a support question, it is a re-occurring unfixed bug/defect. See #5177


Allow select text from a container

It is not possible to select text that is inside of a draggable element even if you set ng-prevent-drag directive

+1

Anyone got this working yet?

Found a temporary fix at least:
In ngDraggable.js, theres an absorbEvent-function. Just add element.focus(); before return false;

Could you please share a gist or plunker to show an example? Thank you.


make request id header name comparison case insensitive

Description
Request headers should be compared case insensitive. We noticed X-Request-Id was being ignored at controller, due to the configured header being X-Request-ID

Related issue and scope

[ ] I opened an issue to propose and discuss this change (#????)

My changes affect the following components

[ ] API
[x] Controller
[ ] Message Bus (e.g., Kafka)
[ ] Loadbalancer
[ ] Invoker
[ ] Intrinsic actions (e.g., sequences, conductors)
[ ] Data stores (e.g., CouchDB)
[ ] Tests
[ ] Deployment
[ ] CLI
[ ] General tooling
[ ] Documentation

Types of changes

[x] Bug fix (generally a non-breaking change which closes an issue).
[ ] Enhancement or new feature (adds new functionality).
[ ] Breaking change (a bug fix or enhancement which changes existing behavior).

Checklist:

[x] I signed an Apache CLA.
[x] I reviewed the style guides and followed the recommendations (Travis CI will check :).
[ ] I added tests to cover my changes.
[ ] My changes require further changes to the documentation.
[ ] I updated the documentation where necessary.

Codecov Report

Merging #3889 into master will decrease coverage by 4.76%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##           master    #3889      +/-   ##
==========================================
- Coverage   75.72%   70.96%   -4.77%
==========================================
  Files         145      145
  Lines        6901     6901
  Branches      417      417
==========================================
- Hits         5226     4897     -329
- Misses       1675     2004     +329

Impacted Files
Coverage Δ

...a/src/main/scala/whisk/http/BasicHttpService.scala
0% <0%> (ø)
:arrow_up:

...core/database/cosmosdb/RxObservableImplicits.scala
0% <0%> (-100%)
:arrow_down:

...core/database/cosmosdb/CosmosDBArtifactStore.scala
0% <0%> (-95.08%)
:arrow_down:

...sk/core/database/cosmosdb/CosmosDBViewMapper.scala
0% <0%> (-92.6%)
:arrow_down:

...whisk/core/database/cosmosdb/CosmosDBSupport.scala
0% <0%> (-81.82%)
:arrow_down:

...abase/cosmosdb/CosmosDBArtifactStoreProvider.scala
0% <0%> (-58.83%)
:arrow_down:

...la/whisk/core/database/cosmosdb/CosmosDBUtil.scala
92% <0%> (-4%)
:arrow_down:

...rc/main/scala/whisk/common/ForcableSemaphore.scala
88.46% <0%> (+3.84%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1b8ffcd...82036b0. Read the comment docs.


Error with Babel in versions 1.2.8 and 1.2.9

When running in development mode with Vite, any of the versions mentioned in the title causes the following error related to the Babel dependency:
Could not resolve "babel-runtime/helpers/inherits"

    node_modules/react-lottie/dist/index.js:27:25:
      27 │ var _inherits2 = require('babel-runtime/helpers/inherits');
         ╵                          ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

  You can mark the path "babel-runtime/helpers/inherits" as external to exclude it from the bundle,
  which will remove this error and leave the unresolved path in the bundle. You can also surround
  this "require" call with a try/catch block to handle this failure at run-time instead of
  bundle-time.

Please review this dependency. I suggest checking out the new features of Babel, as many things have changed, and some functionalities may have been deprecated.

When running in development mode with Vite, any of the versions mentioned in the title causes the following error related to the Babel dependency:
Could not resolve "babel-runtime/helpers/inherits"

    node_modules/react-lottie/dist/index.js:27:25:
      27 │ var _inherits2 = require('babel-runtime/helpers/inherits');
         ╵                          ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

  You can mark the path "babel-runtime/helpers/inherits" as external to exclude it from the bundle,
  which will remove this error and leave the unresolved path in the bundle. You can also surround
  this "require" call with a try/catch block to handle this failure at run-time instead of
  bundle-time.

Please review this dependency. I suggest checking out the new features of Babel, as many things have changed, and some functionalities may have been deprecated.

Me too： "react-lottie": "^1.2.3"

When running in development mode with Vite, any of the versions mentioned in the title causes the following error related to the Babel dependency:
Could not resolve "babel-runtime/helpers/inherits"

    node_modules/react-lottie/dist/index.js:27:25:
      27 │ var _inherits2 = require('babel-runtime/helpers/inherits');
         ╵                          ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

  You can mark the path "babel-runtime/helpers/inherits" as external to exclude it from the bundle,
  which will remove this error and leave the unresolved path in the bundle. You can also surround
  this "require" call with a try/catch block to handle this failure at run-time instead of
  bundle-time.

Please review this dependency. I suggest checking out the new features of Babel, as many things have changed, and some functionalities may have been deprecated.

I install babel-runtime in dependencies then fixed it;
Here are some comments：https://github.com/babel/babel/issues/10584#issuecomment-544725354

Hi @ashen114 @naml14 @larixk @tpae  bebel-runtime is back in<EMAIL_ADDRESS>


Why android export so slow

Godot version:

Godot 3.1.2-devel (e766b16e9)
OS/device including version:

MacOSX 10.14.5
Issue description:

When I export my game it takes:

5 min 8 sec for android
1 min 45 sec for iOS
10 seconds for HTML5

All release builds. I think the most of time it just copying files from one folder to another. Building APK (in the end of process) takes less time then building IPA as far as I could notice.
Steps to reproduce:
Minimal reproduction project:

Is it faster if you create one APK per architecture (by checking only one architecture in the Android export preset)?

@Calinou Selected only one architecture - armv7. Exporting time = 5 min 11 sec.

Building an APK requires zipping everything, so that's very likely the issue.

I unpacked the content of APK file and do time zip -r -9 ga-apk.zip ga-apk/:
real	0m31.531s
user	0m29.432s
sys	0m0.890s

If my computer can pack all files in 31 seconds, why it takes 5 minutes?

Ok, I have found function _should_compress_asset in file godot3/platform/android/export/export.cpp and changed it that it always returs false.
The original APK was 104 Mb, the new one is 108 Mb. The export time for non-packed APK is 5 min 13 secs. So packing costs nothing!
Also I saw that most types of files _should_compress_asset already consider as packed and not pack it twice.
So, the question is - what process takes that all time?

In my previous experiment I didn't consider non-resource files. Now I totally disabled all types of compression in export.cpp.
The APK became 208 Mb, export time = 5 min 01 sec.

In my next experiment I used Z_BEST_COMPRESSION for all files. The APK file became 83 Mb. Export time = 5 min 30 sec.
Really compression costs only this 30 seconds. Other 5 minutes - I don't know what it takes.

more than 4 minutes takes this string:
 621|        ed->ep->step("File: " + p_path, 3 + p_file * 100 / p_total);

I commented out only this one string and get release APK in 43 seconds! I even can enable Z_BEST_COMPRESSION for all files and I will get APK in 5 times faster then before!
Why it so slow?

The secret of other platforms exporters is - do not call this step function. iOS exporter calls it only 5 times. HTML5 exporters doesn't call it at all.

When running the editor on Linux, I couldn't notice a difference when exporting the Platformer 2D demo to Android with the step() function commented. Maybe it's only noticeable when having a lot of assets in the project?

@Calinou I have 4140 files in .import folder. When the project was small I also didn't see the difference when exported on iOS and on Android.


Add JsonPath support for Spring Hateoas (EnableHateoas)

From<EMAIL_ADDRESS>on December 05, 2013 12:39:09
https://github.com/spring-projects/spring-hateoas#enablehypermediasupport
Original issue: http://code.google.com/p/rest-assured/issues/detail?id=287

From<EMAIL_ADDRESS>on January 27, 2014 04:29:30
Can you please elaborate a little on the support needed here?

From<EMAIL_ADDRESS>on January 27, 2014 04:35:08
I actually meant this link: https://github.com/spring-projects/spring-hateoas#linkdiscoverer-api And the issue doesn't have much to do with rest assured. Rather what I wanted to do was to add support to LinkDiscoverer when using the JsonPath defined in the the rest assured project and submit it to Spring.

From<EMAIL_ADDRESS>on January 27, 2014 04:37:28
Status: Duplicate
Mergedinto: 286


Add config option

Would it be an idea to add the option to supply a config object?
.saveMP3(text, filename, ?config)

// For example
.saveMP3('Test sentence', 'my-file', { tl: 'fr-FR' })

Like https://github.com/enricoaleandri/text-to-mp3/issues/1 I set the voice to English by editing node_modules/text-to-mp3/index.js:
TextToMp3.prototype.attributes = {
  ie: 'UTF-8',
  client: 'tw-ob',
  tl: 'en-us'
};

Available languages: Google Language Support.

Thanks for your advice, it's a good idea, to let users customize API call. I will add configuration object asap.


React.createFactory()-created factories with no arguments not checked

There seems to be a bug in the declaration of React.createFactory() in that it does not match factory calls made with zero arguments or null as the props:
const createA = React.createFactory(A)
// This works as expected. Props are correctly type-checked.
createA({ a: 123 })
// These two are not checked.
createA()
createA(null)

I looked at the declaration and it should probably be changed in a way similar to the following:
   declare function createFactory<Config>(
     name: ReactClass<Config>
-  ): (config: Config, children?: any) => React$Element<Config>;
+  ): (config?: ?Config, children?: any) => React$Element<Config>;

Here is a demo in flowtype/try: https://flowtype.org/try/#0JYWwDg9gTgLgBAJQKYEMDG8BmUIjgcilQ3wChS0AbFAZxrgEE4kAPGJAOwBN7l0YAdAGFckDp3gBvUnDhgcYGgC4402bPZsVNGFGAcA5jLgBfcrKLckUABQBKVcYtIYAVygdExQQBEA8gCyAlzAAG72xmZmFBAcOnBoRCjscAC8XvwCiajsAGL80ACeNgx2FEnsNpImZdnJSBF1lRyulJRlQA

This is fixed as of Flow 0.53. I now get errors on all three bad calls to the factory.
import React from 'react'

class A extends React.Component<{text: string}, *> {
  render() {
    return React.DOM.div()
  }
}

const create = React.createFactory(A)
create({})// error
create() // error
create(null) // error


PR for eslint-plugin-flowtype-errors

This plugin reports flow errors as ESLint errors.

https://github.com/amilajack/eslint-plugin-flowtype-errors
Would a PR for this be welcome?

Honestly, I don't know. Why we should want this?

Workflow. The plugin makes it so that you can get flow errors without having to run flow from the command line every time. Also all you need is ESLint. The only text editor/IDE that has good flow support is Nuclide at the moment, and I'm pretty sure that most people in this project don't use it.

Ohh I see. Este recommends Nuclide and I don't know why we should not use it. It just works. https://github.com/este/este/wiki/Recommended-Atom.io-Settings
Thank you anyway.


verifyCode trouble

Hi, RobThree
I actually implement TwoFactorAuth on my PHP project.
I debug the QRcode & secret in my phone via Google Authenticator and response good.
The problem is when I want to validate code.  I create a input field that capture value but not matches.
see more details : https://imgur.com/EDqzVes
you can check my project : https://github.com/networksoft/erp.playerbitcoin
Hope your Orientation.
thanks.

First thing to check: are you sure your time is correct? Second; don't point people to your source/project. Provide (relevant!) code in the issue itself instead of saying: "here's my code, you figure it out!". So please provide a Minimal, Complete, and Verifiable example.

hi, I've verified thst my time is correct.
Please enter in this site: https://mesadejuego.playerbitcoin.com
username 2 password Qnh6rIekdd
next type in url /ov/networkprofile/profile & enter
and click on secret field, paste this :<PHONE_NUMBER>
hope your attention
thanks

next type in url /ov/networkprofile/profile & enter

I'm getting:
Fatal error: Class 'CI_Controller' not found in /home/playerbitcoin/erp.playerbitcoin/system/core/CodeIgniter.php on line 233
But this is not what an MCVE, which is what I asked for, is.
Also: I don't understand why you think that telling me the secret<PHONE_NUMBER>, which is usually only 6 digits but OK) would work? The secret changes at regular intervals? Are you sure you understand how a TOTP works?
Anyway; I can't see the problem since the page gives me an error anyway. Again; please provide an MCVE; don't send me instructions which site to visit and what to click/do/enter. That isn't helpful.

Ok, I shouldn't be dong this nor should I be required to put this much effort in but I found out that the page should be: /ov/networkProfile/profile
I got to enter the secret ONCE (which turned out not to be a TOTP code but a code to 'reset' the 2FA I guess) and I then got a QR code which I could scan & verify fine. However, I couldn't try a second time because now each time I click the secret field I get a pop-up "PLEASE ENTER CORRECT SECRET FOR RESET!!!" before I can even enter the secret.
Again; this shouldn't be this hard. You can't expect people to go through this much trouble and jump through your hoops trying to help you. You need help. Then help me help you. Make it as easy as possible for me to help you.

Hi.
I've verified that my time is correct.
Please explain (or better: show) how you verified this. Did you call the ensureCorrectTime() method?
R: YES I DO IT.
Ok, I shouldn't be doing this nor should I be required to put this much effort in but I found out that the page should be:
/ov/networkProfile/profile
R: please try again.

No this isn't going to work. Please read my comments again and open a new issue that follows the instructions that I provided in the comments (at the very least an MCVE).


Support noncopyable sync objects

What problem does this PR solve?
Issue Number:
Problem Summary:
使用bthread_mutex、bthread_cond_t时，一旦不小心发现了拷贝，就会出现未定义行为。
What is changed and the side effects?
Changed:
在C++环境中，禁止bthread_mutex、bthread_cond_t拷贝。
Side effects:

Performance effects(性能影响):

Breaking backward compatibility(向后兼容性):

Check List:

Please make sure your changes are compilable(请确保你的更改可以通过编译).
When providing us with a new feature, it is best to add related tests(如果你向我们增加一个新的功能, 请添加相关测试).
Please follow Contributor Covenant Code of Conduct.(请遵循贡献者准则).

LGTM


Update NYC_Taxi_KQL_Notebook.ipynb

i think the proposed change fixes an error, but i'm not sure...
when i tried to run from the instructions (did not download notebook) it failed until I added the % in front of the reload_ext command

I'm not getting the next step to work either.  KqlEngineError: invalid connection string: kusto://code;, mandatory key database is missing

@cmaneu change matches what we have in our docs https://learn.microsoft.com/en-us/azure-data-studio/notebooks/notebooks-kqlmagic


ARROW-15389: [C++][Dev] Improve Array preview in GDB plugin

When printing a arrow::Array or arrow::ArrayData, try to print the array contents as well as its metadata.
This is implemented for all primitive and binary-like types.
Other types will only display the array metadata.
Example:
(gdb) p *heap_binary_array.get()
$23 = arrow::BinaryArray of length 3, offset 0, null count 1 = {[0] = null, [1] = "abcd", [2] = "\000\037\377"}

@wjones127


Allow CIMODE as a language and list it in a language selector.

PT-1015. CIMODE is now allowed by the router and it is selectable from a list of languages if the feature flag is set on.
PT-1015. useLocale cannot be used for history pushes, because it does not handle the cimode. If the cimode would be added to useLocales languages, all the datepickers, autosuggest fields, etc would stop working, because they don't support the cimode at all. To fix the issue, router needs to be controlled with i18next instances language instead of useLocal hook.

I'm not happy of that I needed to change the history pushes locale set. useLocale would be a really great hook to use everywhere as it was earlier, but the problem is that I couldn't find a way to make it support the cimode. Listing cimode there, would break all the "widgets".

Codecov Report

Merging #177 (784bd8a) into master (92ce4dd) will increase coverage by 0.03%.
The diff coverage is 77.77%.

@@            Coverage Diff             @@
##           master     #177      +/-   ##
==========================================
+ Coverage   75.31%   75.34%   +0.03%
==========================================
  Files         191      191
  Lines        3423     3432       +9
  Branches     1059     1032      -27
==========================================
+ Hits         2578     2586       +8
- Misses        818      819       +1
  Partials       27       27

Impacted Files
Coverage Δ

...rc/common/components/menuDropdown/MenuDropdown.tsx
71.60% <ø> (ø)

src/domain/app/i18n/i18nInit.ts
100.00% <ø> (ø)

src/domain/app/routes/LocaleRoutes.tsx
91.66% <ø> (ø)

src/domain/events/EventsPage.tsx
87.09% <50.00%> (ø)

src/domain/event/EventSummaryPage.tsx
83.92% <57.14%> (+0.29%)
:arrow_up:

src/domain/app/mobileMenu/MobileMenu.tsx
57.44% <66.66%> (+0.92%)
:arrow_up:

src/domain/occurrence/CreateOccurrencePage.tsx
57.02% <66.66%> (+0.35%)
:arrow_up:

src/domain/event/EditEventPage.tsx
83.58% <71.42%> (ø)

...n/app/header/languageDropdown/LanguageDropdown.tsx
81.25% <88.88%> (-2.09%)
:arrow_down:

src/constants.ts
100.00% <100.00%> (ø)

... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 92ce4dd...784bd8a. Read the comment docs.

Rebased to master.

1 test fails here in Github, but not on my local machine =/ It needs some investigation

1 test fails here in Github, but not on my local machine =/ It needs some investigation

It seems that it can fail in local development env also, like once with 5 tries.


Fail build if docker GID isn't 1950

Issue #, if available:
Description of changes:
Some users rely on the GID of the docker group, and the build should fail if that expectation isn't met. The -f flag causes groupadd to succeed when the docker group already exists:
       -f, --force
           This option causes the command to simply exit with success status if the specified group already exists.
           When used with -g, and the specified GID already exists, another (unique) GID is chosen (i.e.  -g is
           turned off).

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

I build a 1.21 AMI from this branch (make 1.21); the build succeeded. I then launched a t2.micro with it, and verified that the docker GID was correct:
> cat /etc/passwd | grep docker
docker:x:1001:1950::/home/docker:/bin/bash


Missing failure case in SchemaError when coercing integer-like strings to datetime

Describe the bug
There is an issue when validating and coercing to datetime type for integer-like strings, for example "123": the validation raises a SchemaErrors as expected, but the index of the errors are not present in the SchemaErrors.failure_cases.
This is due to the fact than when coercing the full Series of the column, the function pandas.to_datetime is used. If this function fails, then to check which index in particular is failing, all elements are tested using the function numpy.datetime64. And pandas.to_datetime and numpy.datetime64 do not have the same behaviour: numpy.datetime64("123") will return  numpy.datetime64('0123'), whereas pandas.to_datetime("123") will raise a ValueError. Thus, the coercing of the whole Series fails using  pandas.to_datetime, but coercing each element with numpy.datetime64 does not fail, hence no individual failure cases are found.
EDIT: this is related to the change to pandera.engines.utils.numpy_pandas_coerce_failure_cases in version 0.10.0, the example below is working fine for version 0.9.0.
I think that the same function should be used for coercing both the Series and each of its elements.

[x] I have checked that this issue has not already been reported.
[x] I have confirmed this bug exists on the latest version of pandera.
[ ] (optional) I have confirmed this bug exists on the master branch of pandera.

Code Sample, a copy-pastable example
import pandera
import pandas

schema = pandera.DataFrameSchema({"datetime_col": pandera.Column("datetime64[ns]", coerce=True)})
dataframe = pandas.DataFrame({"datetime_col": ["2022-01-01", "123"]})

try:
    schema.validate(dataframe, lazy=True)
except pandera.errors.SchemaErrors as schema_errors:
    print(schema_errors.failure_cases.failure_case)

Expected behavior
In the example above, the validation fails and there should be "123" printed as a failure case. However, even if the validation is failing, there's no failure case in the pandera.errors.SchemaErrors.
So either "123" should be coerced to a datetime object and the validation should pass, or the validation should fail and "123" should be listed as a failure case. I think the latter is the expected behaviour, since it is pandas.to_datetime behaviour.
Desktop (please complete the following information):

OS: Debian

Thanks for the bug report @Messlow. Your pointers were very useful, there was indeed a regression in 0.10.0.
I pushed a fix, once it's accepted you can try it out from the dev branch or wait for the next minor release.

this should be fixed in dev branch, gonna cut a bugfix release next week! closing this now


Update README.md for DevTools plugin

Hey, I just made a Pull Request!
I did a little correction in the README.md for DevTools plugin. To configure the package dependencies, you have to add in app-config.yaml the list of packages prefixes you want to be listed (by default only @backstage and @internal are listed).
If you follow the doc, you will have a problem when you start Backstage with yarn dev:
[0]
[0] YAMLParseError: Plain value cannot start with reserved character @ at line 89, column 9:
[0]
[0]       - @immobiliarelabs/backstage-
[0]         ^
[0]
[0]
error Command failed with exit code 1.

You have to add single quotes around packages prefixes.
I updated the doc for that.
:heavy_check_mark: Checklist

[X] A changeset describing the change and affected packages. (more info)
[X] Added or updated documentation
[ ] Tests for new functionality and regression tests for bug fixes
[ ] Screenshots attached (for UI changes)
[X] All your commits have a Signed-off-by line in the message. (more info)

I rudely added a comment to that effect to get the change in for the release! Hope that's OK.

Thanks again for this contribution @jeanlouisferey! 🚀
Thanks for the reviews and merge @freben @vinzscam 👍


Our spec defines a general data model for demographies, not a yaml format

In popsim-consortium/demes-python#105, there's some discussion relating to nested python dicts, or json format. The yaml format we've ended up with is fine and all, but could just as easily use json, or some other arbitrary format that lets us define the nested data structues and their attributes. So just how tied to yaml are we? If folks find other formats useful for interchange, presumably they'll proliferate instead (e.g. json). Should we be clearer with our framing of the spec, and just say we define a general model structure (with yaml as our intended interchange format)?
(Fun fact, json is a proper subset of the yaml spec, so valid json is valid yaml!).

I don't think there's anything actionable left in this issue.


Make robust to singularities in the covariance

https://github.com/tek5030/lab-segmentation/issues/8


fix: escape file special chars

This PR contains some fixes needed to handle files with special characters correctly (#92):

escape special characters file names in "flow coverage" commands (with the same regular expression used in the flow-annotation-checks dependency to fix the same issue).
update flow-annotation-checks dependencies (which contains the fix for the "extract flow annotation" phase).
added an additional integration test that execute flow-coverage-report on a fake project with special characters in the file names.

Thanks to @ryan953 for tracking down the issue and for fixing for it.

I forgot to add a test for the backtick ` character! it's the sixth char that the regex escapes.
idk if you want to add that, or if there's a better way to escape things that doesn't rely on a crummy regexp.


controller.php - not appearing in 'awaiting installation'

Have extracted and renamed the folder to "msv_table" and copied to /packages folder in a test 5.7 installation.  It is not showing as "Awaiting Installation" is there a way to execute the controller.php from concrete5 ?

I'm not having an issue installing, I've been able to down the zip, unzip it to the top level packages folder, rename it to msv_table and install it.
The only thing I can think of is that you've perhaps not copied in a file. It should like the attached.  (just ignore the .gitignore file)


MicroProfile 4.1 Compatible Certification Request - Quarkus MicroProfile 2.4.1.Final

[x] Organization Name ("Organization") and, if applicable, URL:
RedHat

[x] Product Name, Version and download URL (if applicable):
Quarkus MicroProfile 2.4.1.Final (https://github.com/quarkiverse/quarkus-microprofile)

[x] Specification Name, Version and download URL:
MicroProfile 4.1

[x] Public URL of TCK Results Summary:
https://github.com/quarkiverse/quarkus-microprofile/releases/download/2.4.1.Final/tck-results.html

With the following exceptions:

org.eclipse.microprofile.fault.tolerance.tck.interceptor.xmlInterceptorEnabling.FaultToleranceInterceptorEnableByXmlTest
org.eclipse.microprofile.rest.client.tck.cditests.HasConversationScopeTest
org.eclipse.microprofile.rest.client.tck.cditests.HasSessionScopeTest

Due to:

https://github.com/eclipse/microprofile-fault-tolerance/pull/596

https://github.com/eclipse/microprofile-rest-client/issues/330

[x] Any Additional Specification Certification Requirements:
No

[x] Java runtime used to run the implementation:
11

[x] Summary of the information for the certification environment, operating system, cloud, ...:
GH Actions, Ubuntu

[x] By checking this box I acknowledge that the Organization I represent accepts the terms of the EFTL.

[x] By checking this box I attest that all TCK requirements have been met, including any compatibility rules.
With the exceptions detailed in the TCK Results Summary.

@radcortez We have standardised the TCK process. Here is the certification process. Please follow the process and move this issue to dedicated repo, which will kick off the approval process automatically.


Feature request: Ability to order vehicles

Describe the feature
When you have multiple vehicles in a single Teslamate instance, the main Teslamate web interface shows the vehicles in "order added". For example if you acquire vehicles called "B", then "A", then "C" then that is the order you'll see them in (top-to-bottom) on the main Teslamate screen.
On the grafana reports though the cars are displayed in alphabetical order, so you see car "A", then "B", then "C" .
Rather than just fixing that inconsistency though, it would be great if we could set a "priority", or "order" for vehicles. In my case, the car that I'm interested in 90% of the time always appears second due to naming, and it would be super helpful if I could change those to appear in my chosen order.
Expected behavior
Ability to set an explicit order for all vehicles, or ability to set a "priority" value against each vehicle on the Teslamate settings page, and have both the teslamate web screen, and Grafana dashboards honour it.

Feature requests belong here: 💡 Ideas. I'll move it.


Curved Depth Map

Hi, I am trying to create a visualizer that allows me to visualize the room layout. I am using a custom image for inference.
The results look good, when i check the segmentation overlayed on my image. The main issue I have is when I try to use open 3d to plot, it looks like the depth map is curved. Do you have any explanation for this?
This is the overlayed image

This is my Open3d visualization of the polygons:

The main issue is the curvature, and that is due to the depth map extracted by the network. Any idea of how to solve it?
Thanks

Hi @marcomiglionico94
I think this may be due to the incorrect depth distance we used. You may try two different depths: i) distance from the point to the image plane or ii) distance from point to the camera center.
Best,
Jia

Hi @marcomiglionico94
I think this may be due to the incorrect depth distance we used. You may try two different depths: i) distance from the point to the image plane or ii) distance from point to the camera center.
Best, Jia

Hi thanks for the quick answer, where exactly I can find that distance parameter that you used? Can you refer to the file or line of code where I can find it

For a point (x,y,z) in 3D space, the depth map extracted by network is the z coordinate, not the  np.sqrt(x^2+y^2+z^2).

Hi @marcomiglionico94
I think this may be due to the incorrect depth distance we used. You may try two different depths: i) distance from the point to the image plane or ii) distance from point to the camera center.
Best, Jia

Is it possible to know at least what kind of visualization you use for the paper? Did you use Open3D or something else?

For a point (x,y,z) in 3D space, the depth map extracted by network is the z coordinate, not the np.sqrt(x^2+y^2+z^2).

I know that, but in the code the depth map is basically created in ConvertLayout function, in particular in this part of code:
n_d = param[:3] / np.clip(param[3], 1e-8, 1e8)  # meter n/d             n_d = n_d[np.newaxis, np.newaxis, :]             inverdepth = -1 * np.sum(np.dot(n_d, K_inv) * ixy1map, axis=2)             depth[mask] = inverdepth[mask]
My question is which parameters can I change so that the depthmap is not curved? I imagine that in the reconstruction you show in the paper you used a depth map, to make the 3d visualization. But not a curved one otherswise your results will look like the image I posted at the beginning of this issue.

Hi @marcomiglionico94
I think this may be due to the incorrect depth distance we used. You may try two different depths: i) distance from the point to the image plane or ii) distance from point to the camera center.
Best, Jia

Is it possible to know at least what kind of visualization you use for the paper? Did you use Open3D or something else?

We use Open3D to visualize the reconstructed 3D model.

Hi, @marcomiglionico94
There is a mistake about the variable name. The returned depth in code is the inverse of depth. So the actually depth is by 1/depth.

Hi thanks for your reply. I am not very sure about this. When i return 1/depth the results of the depthmap are very strange since only a small part of the scene is included, the rest is missing

Hi, @marcomiglionico94 There is a mistake about the variable name. The returned depth in code is the inverse of depth. So the actually depth is by 1/depth.

Hi thanks for your reply. I am not very sure about this. When i return 1/depth the results of the depthmap are very strange since only a small part of the scene is included, the rest is missing. Trying to figure out what is the problem

We add an example on NYU303 dataset.  The actually depth is 1/depth, not  depth = np.ones_like(depth) - depth.

Using depth = np.ones_like(depth) - depth I was able to obtain the following visualization, which seems correct.

Using 1/depth instead, this is what i was getting for the same image:

We add an example on NYU303 dataset. The actually depth is 1/depth, not depth = np.ones_like(depth) - depth.

Hello, I realized that if I use 1/depth it only works if then I divide the values of the depthmap by the max value of it, only to scale the values between 0 and 1 so that I can visualize them. Do you know if that is the correct approach? or is there another way to scale the values of the depthmap between 0 and 1 so that I can visualize it?

@marcomiglionico94 I wonder if it could be possible for you to briefly discuss how you solve the problem?

@bertjiazheng
Could you please share with us the code you implemented to visualise the 3D model?

hey @marcomiglionico94, can you share the code you have implemented for 3D visualization.  Also, I am trying to implement this function DisplayMeshLayout in reconstruction.py for my custom images in test.py
It needs these as input def DisplayMeshLayout(ups, downs, attribution, pwalls, pceiling, pfloor, ixy1map, K_inv)
I am still figuring out to feed these inputs but I dont think I will have ixy1map [what is it? it only shows in training]


Improve CPU shares and RAM allocation generation

Currently, I generate CPU shares and used RAM for each request using a Gaussian distribution with some fixed parameters obtained from Pracucci's thesis and source code of his experiments:
https://github.com/unimib-datAI/marl-dfaas/blob/8963aef47625c83d7063568758aeacb4d6d9e0d9/dfaas_env.py#L763-L790
This can be improved: instead of generating synthetic CPU shares and RAM resources, I could use the real data from the Azure Functions 2019 dataset (note that I already use this dataset for the real requests type). This dataset has the execution times (from which I can somehow extract the shares) and the memory allocations for each function.

Actually, this is a good idea.


How to train RCG with small-scale dataset?

Hi, I have a small-scale dataset of 10k+ images, and they are mainly about human crowd. I trained RDM with these images only, and generated images using pretrained mocov3 and MAGE model on imagenet, but the FID of the results is very high ~50, and I have no idea what is wrong with it, maybe the scale of dataset?

One thing that might affect the performance is the VQGAN tokenizer: the provided tokenizer is pre-trained on ImageNet, and may not achieve good reconstruction performance on your dataset. The provided moco v3 is also pre-trained on ImageNet, which might affect performance. Dataset scale might be a problem, but you have 10k+ images already, which should produce reasonable results.

Maybe I should finetune all these models with my custom data, is there any difference between finetuning moco, rdm, pixel generator and other common deep learning models, such as freezing layers, reduce learning rate?

Unfortunately I don't have any experience about this -- maybe first try fine-tuning with a small learning rate and look at the losses.

Ok, I will try it myself, thank you.


Create a "more natural to use" Vala interface over the SQLite bindings

This should naturally happen over time as you write more sqlite code in this app

Note: feel free ti use variadic arguments and optionals. The code used is only intended for Vala


Allow for configuration signals without a backend

ophyd devices provide configuration through Signal objects, which have a default implementation using a dict within the object.
ophyd_async devices are bounded by SignalR, which does not have an implementation that does not require a backend.
A simple SignalR implementation would make adding configuration to devices simpler, allowing this data to propagate through documents.

Superceded by #94


Implement Trace and Finalize traits in features

Currently, having an issue with using aHash with usage in rust-gc, an issue has been raised with adding support for more crates usage, which in turn states that this should be added as a feature in these other crates, currently using FxHash, which incorporates STL and so works with the gc's STL Traits, however, this does not occur with aHash.
This also links to #42 as the trait implementation is due to this.

@neeldug What do you propose?

I propose that a feature be added which enables this Trait for gc, similar to how it’s implemented for STL collections, i.e. Hashmap and Hashset, which can be found here. I’m unsure to the specifics of implementing a feature in crates, however, I’ll have a quick look.

By the orphan rules, the trait impl must either live in aHash code in which case aHash would need a dependency on rust-gc (which is understandable because most users of aHash aren't using rust-gc). Or it could live in rust-gc and rust-gc could depend on aHash.
I think the later probably makes more sense.
I would love to get traits like this auto derived as discussed in #42 but I don't know how to do that and preserve the constructors. If you can think of a way I would be happy to hear it.

I understand what you mean by preserving constructors but isn’t it at all possible to create a gc feature with the optional dependency of rust-gc and add a trait impl for the feature itself?

Actually @tkaitchuck, just realised exactly what you meant by this, however, couldn't it be possible to use features and modify the constructor based on the feature that's active? By using the cfg! macro. However, I haven't had a specific look at the constructors and whether or not this would be feasible.

Closing in favor of Manishearth/rust-gc#68

impl<T> Finalize for Deref<Target = T> where T: Finalize would be an implementation for the trait object (dyn Deref), which isn’t useful.
Perhaps impl<T> Finalize for T where T: Deref, T::Target: Finalize is the blanket implementation you meant, but that would conflict with every other implementation of Finalize.


Deprecate for loops without END or \ indentation with pipe separated format

Currently it's possible to use for loops with the pipe separated by indenting the for loop block like this:
| *** Test Cases ***
| Example
| | :FOR | ${x} | IN | 1 | 2
| |      | Log  | ${x}

In the normal space separated format the above would need explicit indentation with \:
*** Test Cases ***
Example
    :FOR    ${x}    IN    1    2
    \    Log    ${x}

Using for loops without an explicit END introduced in RF 3.1 (#3009) will be deprecated in RF 3.2 in general (#3078) similarly as using :FOR and not FOR (#3080). Both of the above examples would thus need to be changed in the near future.
A problem with the pipe separated format is that the new test data parser in RF 3.2 (#3076) won't be able to (easily) recognize for loop indentation without the explicit \. As a result we've decided to deprecate the syntax in the first example already in RF 3.1.2. The pipe separated format isn't that widely used and thus this shouldn't use big problems. There are also easy ways to avoid the deprecation explained below.
The recommended way to handle deprecation is switching to the new for loop syntax and explicitly close the loop with END:
| *** Test Cases ***
| Example
| | FOR | ${x} | IN | 1 | 2
| |     | Log  | ${x}
| | END

The only drawback of this approach is that it's not compatible with earlier versions than RF 3.1. If old versions still need to be supported, then explicit escaping with \ like in the plain text format is needed:
| *** Test Cases ***
| Example
| | :FOR | ${x} | IN | 1 | 2
| | \    | Log  | ${x}

This syntax works with RF 3.1 and earlier but will be deprecated in RF 3.2.

Deprecating this functionality turned out to be pretty complicated. Considering how little the pipe separated format is used, I don't consider it worth the effort. Much better just update documentation and mention this change both in RF 3.1.2 and RF 3.2 release notes.


Using a service connection with a management group throws an error

Question, Bug, or Feature?: Bug
Enter Task Name: AzureRmWebAppDeployment@4
Environment

Server - Azure Pipelines or TFS on-premises? Azure Pipelines
Agent - Hosted or Private: Hosted

Issue Description
When using a service connection with a managment group instead of a subscription id it throws following error  'subscriptionId' cannot be null.'.
Task logs
Got service connection details for Azure App Service:'exs-thola-tst-api'
##[debug]Deployment Failed with Error: Error: 'subscriptionId' cannot be null.
##[debug]task result: Failed
##[error]Error: 'subscriptionId' cannot be null.
##[debug]Processed: ##vso[task.issue type=error;]Error: 'subscriptionId' cannot be null.
##[debug]Processed: ##vso[task.complete result=Failed;]Error: 'subscriptionId' cannot be null.
Error logs
##[error]Error: 'subscriptionId' cannot be null.
(node:4808) UnhandledPromiseRejectionWarning: Unhandled promise rejection (rejection id: 2): TypeError: Cannot read property 'getApplicationURL' of undefined
This is not blocking as we resolved it by creating multiple service connection with the same principle.

Management group level service connections are not supported currently for this task.
@N-Usha Can you check this enhancement request?

Hi @AmrutaKawade,
I think documenting the limitation would be a great first step. Add some more information in Prerequisites. It could be added under the required subscription id. That this requirement implicitly means that service connections should be scoped at subscription level and not with group management.
Just my 2 cents of course. I only wanted to point this out.
At the moment, with some additional configurations, our builds are working just fine.

@verbedr Thanks for the feedback. We will update the documentation. Regarding the enhancement we have taken a note and are looking for more requests on this. I would recommend posting this feature ask in our developer community feedback so that others also can vote for it and we can prioritize it better.


Feature request : Moore-Penrose pseudoinverse

System information

Have I written custom code (as opposed to using a stock example script provided in TensorFlow): Yes
OS Platform and Distribution (e.g., Linux Ubuntu 16.04): Linux Ubuntu 16.04
Mobile device (e.g. iPhone 8, Pixel 2, Samsung Galaxy) if the issue happens on mobile device: No
TensorFlow installed from (source or binary): binary
TensorFlow version (use command below): v1.8.0-0-g93bc2e2072
Python version: 2.7
Bazel version (if compiling from source): N/A
GCC/Compiler version (if compiling from source): N/A
CUDA/cuDNN version: N/A
GPU model and memory: N/A
Exact command to reproduce: N/A

Describe the problem
Due to its importance in various fields in applied math, it would be beneficial to have a TensorFlow version of NumPy's pinv function that calculates the Moore-Penrose pseudoinverse of an array : https://docs.scipy.org/doc/numpy-1.14.0/reference/generated/numpy.linalg.pinv.html
Of course, it is possible to create such function with current existing TensorFlow's functionality (e.g. using tf.svd), but it would be more appropriate to have it as an optimized core function.
Source code / logs
N/A

We currently don't have anybody working on this. It would be great if you could help us by working on this and submitting a PR. Let us know if you need further clarification. Thanks!

I could write a simple python script for the operation. This could serve as a temporary solution while there is no corresponding optimized core function written in C++. If this is acceptable, I would gladly help.

Nagging Assignee @bignamehyp: It has been 15 days with no activity and this issue has an assignee. Please update the label and/or status accordingly.

Hi @bignamehyp , can you assign this issue to me ? Thank you.

Nagging Assignee @jpohanka: It has been 14 days with no activity and this issue has an assignee. Please update the label and/or status accordingly.

Nagging Assignee @jpohanka: It has been 29 days with no activity and this issue has an assignee. Please update the label and/or status accordingly.

Nagging Assignee @jpohanka: It has been 44 days with no activity and this issue has an assignee. Please update the label and/or status accordingly.

Nagging Assignee @jpohanka: It has been 59 days with no activity and this issue has an assignee. Please update the label and/or status accordingly.

Nagging Assignee @jpohanka: It has been 74 days with no activity and this issue has an assignee. Please update the label and/or status accordingly.

Nagging Assignee @jpohanka: It has been 89 days with no activity and this issue has an assignee. Please update the label and/or status accordingly.

It has been 14 days with no activity and the awaiting response label was assigned. Is this still an issue?

@tensorflowbutler Yes, it is still an issue.

@tensorflowbutler This feature has already been incorporated. This issue can be closed.

@jpohanka Where is this op in tensorflow? I can't find it. I just found an unofficial implementation in tensorflow_probability. Will this feature be implemented officially in tensorflow?