Next alpha release for MIT folks

Could we plan on what else to do to cut the next release for folks to try out? E.g. should following still open ATM issues be addressed first

#53
#54

?

For #53, it depends on what exactly's causing the crash.  If it's just running out of memory normally, then #64 should fix that, but if it's some side effect of building with musl, then I don't know.

For #54, I've added more logging in order to help diagnose the problem.  Other than doing more test runs, I'm not sure what to do for that.

ok, I closed #53 .  @jwodder please do the needed run to check for #54 on drogon (not enough space on typhon I think ATM) with desired level of verbosity etc to track down/resolve that issue.

FWIW, I freed up typhon space enough to run it there too now

@yarikoptic I believe #83 fixes #54.  I ran the code on drogon with --path-filter '^zarr/aa', and it successfully ran for over ten hours before failing due to an error on S3's end.

Great, thanks!
Re error on S3 end -- I think all kinds of 500s could happen. Do we have retries in place for whenever interactions with S3 fail for some 5xx reason?

Great, thanks!
Re error on S3 end -- I think all kinds of 500s could happen. Do we have retries in place for whenever interactions with S3 fail for some 5xx reason?

@yarikoptic No.  I'm not even sure how to discern 5xx from other errors with this SDK.

What particular SDK? (sounds "too bad to be true")

I see them testing retries on 500 for some components e.g.
https://github.com/awslabs/aws-sdk-rust/blob/7791b008320b70ea59880079ba901908f3712f5c/sdk/aws-config/src/imds/client.rs#L809
and issues like

https://github.com/awslabs/aws-sdk-rust/issues/1163

hinting that in general it should be retried.  What specific error did you receive?   might need an issue to be reported against SDK.

@yarikoptic The error was:
Error: failed to get object at s3://dandiarchive/zarr/aae64bf8-594e-4c7b-a1a2-9bcbc8638186/0/0/0/4/8/156?versionId=o_N.RxYr0iL73ZNug020YtzrSaWoJce2

Caused by:
    0: service error
    1: unhandled error (InternalError)
    2: Error { code: "InternalError", message: "We encountered an internal error. Please try again.", aws_request_id: "XB0VWDXJH3351P6T", s3_extended_request_id: "QdlprriTEB4HT9v6CzktdTBJUZf8XFecTws0XGaTVEJ6rjRukIxT2Pu+/NdMBOq8fNRzsAHGTk9cK3GmDAFjvXxREvGj0+rcb6P/AEpNYkY=" }

ah, so it looks very similar to that

https://github.com/awslabs/aws-sdk-rust/issues/1163

and IMHO should be retried for this GET object. Could you please report an issue?  meanwhile -- wouldn't it be possible to configure retries on any InternalErrors?

@yarikoptic The SDK uses a default retry config, so it's possible it did retry but it just didn't show up in the logs due to a low log level.  I seem to recall from working on dandidav that the AWS SDK logs a lot of noise at DEBUG and TRACE level, so increasing the logs might not be such a good idea.

do you know if it logs at INFO or WARNING level when initial fail before retry happens?  I failed to track it down in the code there

@yarikoptic So what, if anything, should we do about retrying?

if you think that it didn't retry at all -- we better submit an issue against SDK
if you think that it did retry but not enough, and I think that is what we could do anyways to robustify, let's change default retrying policy to retry up to e.g. 10 times with exponential backoff like they describe in https://docs.aws.amazon.com/sdk-for-rust/latest/dg/retries.html .

if we encounter similar problem after introducing this change to retry policy, it would almost definitely mean it didn't retry and we must report.


20171018 Update

Fix some indentation.
Use the existing Chromedriver.
Update libimobiledevice.

lgtm

I abandon this, I filed RET-1984 to follow-up


Resizing Block Volumes

Files can already be resized and appended to; this is just a nice enhancement for the block volume driver. The admin can then run resize2fs, and, magically, it works.
Another great starter bug. Touches one package (block) but uses concepts from the root torus package as well.

@barakmich would this be to just increase the size of the volume, or allow resizing up and down? I have most of increasing done, I think decreasing could be supported, I'm just not sure if we can do it while the volume is mounted.

Yeah, that makes sense. Truncate() will decrease size too -- doing any
resize operation, however, is probably worth doing when not mounted (ie, it
takes the lock)
On Mon, Jun 27, 2016 at 3:01 PM, Blake Howell<EMAIL_ADDRESS>wrote:

@barakmich https://github.com/barakmich would this be to just increase
the size of the volume, or allow resizing up and down? I have most of
increasing done, I think decreasing could be supported, I'm just not sure
if we can do it while the volume is mounted.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/coreos/torus/issues/177#issuecomment-228889361, or mute
the thread
https://github.com/notifications/unsubscribe/AAGANNonhIzeS9P4qyJmrCDM8stSZMbVks5qQEg7gaJpZM4IrIyj
.


Create Sequelize table associations

Created new tables for issue# 41. Need to add table foreign keys (associations) in Sequelize.

Associations were done in week 5-8.


How to use placeholder to feed values to arguments of an operation in Tensorflow?

Hi @ageron,
I am trying to use tf.keras.layers as in my code to see how it works. While trying to forecast time series in Tensorflow using RNN, I am using dropout method. If I hard-code the values of dropout and recurrent_dropout, my program runs perfectly. However, I need to perform inference on the model and for that the dropout needs to be turned off. I am using tf.placeholder_with_default but this throwing an error. The entire code and the corresponding error is -
TimeSeriesDropout_graph = tf.Graph()
with TimeSeriesDropout_graph.as_default():
  keep_prob_input_default = np.array(1.0,dtype='float32')
  keep_prob_input = tf.placeholder_with_default(keep_prob_input_default,shape=())
  keep_prob_state_default = np.array(1.0,dtype='float32')
  keep_prob_state = tf.placeholder_with_default(keep_prob_state_default,shape=())
#   keep_prob_input = 0.5
#   keep_prob_state = 0.5
  X = tf.placeholder(dtype=tf.float32,shape=(None,n_steps,n_inputs))
  y = tf.placeholder(dtype=tf.float32,shape=(None,n_steps,n_outputs))
  multiple_rnn_cell = [tf.keras.layers.SimpleRNNCell(units=n_neurons,activation='relu',dropout=keep_prob_input,recurrent_dropout=keep_prob_state)
                     ,tf.keras.layers.SimpleRNNCell(units=n_neurons//2,activation='relu',dropout=keep_prob_input,recurrent_dropout=keep_prob_state)
                     ,tf.keras.layers.SimpleRNNCell(units=n_neurons//4,activation='relu',dropout=keep_prob_input,recurrent_dropout=keep_prob_state)
                     ,tf.keras.layers.SimpleRNNCell(units=n_neurons//8,activation='relu',dropout=keep_prob_input,recurrent_dropout=keep_prob_state)]
  stacked_rnn_cell = tf.keras.layers.StackedRNNCells(multiple_rnn_cell)
  rnn_output = tf.keras.layers.RNN(stacked_rnn_cell,return_sequences=True,return_state=True)(X)
  outputs_reshaped = tf.reshape(rnn_output[0],(-1,n_neurons//8))
  output = tf.keras.layers.Dense(units=n_outputs)(outputs_reshaped)
  output_stacked = tf.reshape(output,(-1,n_steps,n_outputs))
  loss = tf.reduce_mean(tf.square(y-output_stacked))
  optimizer = tf.train.AdamOptimizer(learning_rate=learning_rate)
  training_op = optimizer.minimize(loss)
  init = tf.global_variables_initializer()
  saver = tf.train.Saver()

The error stack is:
TypeError                                 Traceback (most recent call last)
<ipython-input-29-fd7e00c85d84> in <module>()
      8   X = tf.placeholder(dtype=tf.float32,shape=(None,n_steps,n_inputs))
      9   y = tf.placeholder(dtype=tf.float32,shape=(None,n_steps,n_outputs))
---> 10   multiple_rnn_cell = [tf.keras.layers.SimpleRNNCell(units=n_neurons,activation='relu',dropout=keep_prob_input,recurrent_dropout=keep_prob_state)
     11                      ,tf.keras.layers.SimpleRNNCell(units=n_neurons//2,activation='relu',dropout=keep_prob_input,recurrent_dropout=keep_prob_state)
     12                      ,tf.keras.layers.SimpleRNNCell(units=n_neurons//4,activation='relu',dropout=keep_prob_input,recurrent_dropout=keep_prob_state)

1 frames
/usr/local/lib/python3.6/dist-packages/tensorflow/python/framework/ops.py in __bool__(self)
    651       `TypeError`.
    652     """
--> 653     raise TypeError("Using a `tf.Tensor` as a Python `bool` is not allowed. "
    654                     "Use `if t is not None:` instead of `if t:` to test if a "
    655                     "tensor is defined, and use TensorFlow ops such as "

TypeError: Using a `tf.Tensor` as a Python `bool` is not allowed. Use `if t is not None:` instead of `if t:` to test if a tensor is defined, and use TensorFlow ops such as tf.cond to execute subgraphs conditioned on the value of a tensor.

What am I doing wrong here?

Hi @kusur ,
The simplest option is to build a Keras model, since it automatically turns dropout off at inference time.
import numpy as np
from tensorflow import keras

n_neurons = 128
learning_rate = 1e-3
keep_prob_input = 0.5
keep_prob_state = 0.5
n_steps = 20
n_inputs = 4
n_outputs = 1

X_train = np.random.rand(1000, n_steps, n_inputs)
y_train = np.random.rand(1000, n_steps, n_outputs)
X_valid = np.random.rand(500, n_steps, n_inputs)
y_valid = np.random.rand(500, n_steps, n_outputs)
X_test = np.random.rand(500, n_steps, n_inputs)
y_test = np.random.rand(500, n_steps, n_outputs)
X_new = np.random.rand(1, n_steps, n_inputs)

model = keras.models.Sequential([
    keras.layers.SimpleRNN(units=n_neurons, return_sequences=True,
                           dropout=keep_prob_input, recurrent_dropout=keep_prob_state,
                           input_shape=[n_steps, n_inputs]),
    keras.layers.SimpleRNN(units=n_neurons // 2, return_sequences=True,
                           dropout=keep_prob_input, recurrent_dropout=keep_prob_state),
    keras.layers.SimpleRNN(units=n_neurons // 4, return_sequences=True,
                           dropout=keep_prob_input, recurrent_dropout=keep_prob_state),
    keras.layers.SimpleRNN(units=n_neurons // 8, return_sequences=True,
                           dropout=keep_prob_input, recurrent_dropout=keep_prob_state),
    keras.layers.Dense(units=n_outputs),
])
optimizer = keras.optimizers.Adam(lr=learning_rate)
model.compile(loss="mse", optimizer=optimizer)
history = model.fit(X_train, y_train, epochs=10,
                    validation_data=[X_valid, y_valid]) # optional
history = model.save("my_model.h5")
generalization_error = model.evaluate(X_test, y_test)
y_pred = model.predict(X_new)

Oh! does it? I wasn't aware of this. Thanks for this information. However, I am still trying to figure out the solution to my problem. Is there a way that this can be solved?

Oh! does it? I wasn't aware of this. Thanks for this information. However, I am still trying to figure out the solution to my problem. Is there a way that this can be solved?

Hi @kusur,
I ran your code and the full stacktrace is this (in the future, please copy full stacktraces, as the important part is not always at the end or at the beginning):
---------------------------------------------------------------------------
TypeError                                 Traceback (most recent call last)
<ipython-input-6-b4bd1513a34c> in <module>
     14   X = tf.placeholder(dtype=tf.float32,shape=(None,n_steps,n_inputs))
     15   y = tf.placeholder(dtype=tf.float32,shape=(None,n_steps,n_outputs))
---> 16   multiple_rnn_cell = [tf.keras.layers.SimpleRNNCell(units=n_neurons,activation='relu',dropout=keep_prob_input,recurrent_dropout=keep_prob_state)
     17                      ,tf.keras.layers.SimpleRNNCell(units=n_neurons//2,activation='relu',dropout=keep_prob_input,recurrent_dropout=keep_prob_state)
     18                      ,tf.keras.layers.SimpleRNNCell(units=n_neurons//4,activation='relu',dropout=keep_prob_input,recurrent_dropout=keep_prob_state)

~/miniconda3/envs/tf1/lib/python3.7/site-packages/tensorflow/python/keras/layers/recurrent.py in __init__(self, units, activation, use_bias, kernel_initializer, recurrent_initializer, bias_initializer, kernel_regularizer, recurrent_regularizer, bias_regularizer, kernel_constraint, recurrent_constraint, bias_constraint, dropout, recurrent_dropout, **kwargs)
   1061     self.bias_constraint = constraints.get(bias_constraint)
   1062
-> 1063     self.dropout = min(1., max(0., dropout))
   1064     self.recurrent_dropout = min(1., max(0., recurrent_dropout))
   1065     self.state_size = self.units

~/miniconda3/envs/tf1/lib/python3.7/site-packages/tensorflow/python/framework/ops.py in __bool__(self)
    651       `TypeError`.
    652     """
--> 653     raise TypeError("Using a `tf.Tensor` as a Python `bool` is not allowed. "
    654                     "Use `if t is not None:` instead of `if t:` to test if a "
    655                     "tensor is defined, and use TensorFlow ops such as "

TypeError: Using a `tf.Tensor` as a Python `bool` is not allowed. Use `if t is not None:` instead of `if t:` to test if a tensor is defined, and use TensorFlow ops such as tf.cond to execute subgraphs conditioned on the value of a tensor.

As you can see, in recurrent.py, line 1063, the code is:
self.dropout = min(1., max(0., dropout))

This uses Python's max() built-in function, which performs if 0 < dropout, and Tensors don't like this. In other words, apparently it's not meant to be a tensor. :(
I suggest you file a bug for TensorFlow.


Add app response to input binding event

This PR adds the ability for an app to response with a payload in response to an input binding event.
Part of https://github.com/dapr/dapr/issues/2628

LGTM
Was surprised there are not existing input bindings that would return a payload.
Dare I ask if the []byte should have a content type or metadata and be encapsulated in a ReadResponseResponse struct... No. No. I won't ask that. :)

Since each input binding can be prescriptive about the type and format and data it expects, we can keep this as a byte array and let each binding validate the format. In the future we can change it if we feel the need.


STREAMS-494: improve streams-util tests and use third-party library

lazy consensus merge in 24 hours


Removed control tower code for the start page

For #12919

[x] Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR).
[x] Title summarizes what is changing.
[x] Has a news entry file (remember to thank yourself!).
[ ] Appropriate comments and documentation strings in the code.
[ ] Has sufficient logging.
[ ] Has telemetry for enhancements.
[ ] Unit tests & system/integration tests are added/updated.
[ ] Test plan is updated as appropriate.
[ ] package-lock.json has been regenerated by running npm install (if dependencies have changed).
[ ] The wiki is updated with any design decisions/details.

Codecov Report

Merging #13195 into master will decrease coverage by 0.00%.
The diff coverage is 66.66%.

@@            Coverage Diff             @@
##           master   #13195      +/-   ##
==========================================
- Coverage   59.54%   59.54%   -0.01%
==========================================
  Files         669      669
  Lines       36788    36783       -5
  Branches     5182     5181       -1
==========================================
- Hits        21907    21902       -5
+ Misses      13784    13783       -1
- Partials     1097     1098       +1

Impacted Files
Coverage Δ

src/client/common/experiments/groups.ts
100.00% <ø> (ø)

src/client/common/startPage/startPage.ts
31.21% <66.66%> (-0.67%)
:arrow_down:

src/client/common/utils/platform.ts
64.70% <0.00%> (-5.89%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eed52c5...74a90e9. Read the comment docs.


Full-screen immersion

Is there a way have an article in 'readability mode' so that everything is hidden by the content?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 6079073a-0dd9-3b9b-c160-76e0dd525a3c
Version Independent ID: 631788a5-f4bc-7df0-0540-2a0f67b631de
Content: Introducing docs.microsoft.com
Content Source: teamblog/introducing-docs-microsoft-com.md
Product: team-blog
GitHub Login: @jeffsand
Microsoft Alias: jeffsand

@AlexA-1976 Thanks for taking the time to give us your feedback and ask about new display features. At present, there isn't a way to hide all navigation and only display content on the platform.
In the meantime, I've tagged your request to a member of the relevant team for review and consideration. We really appreciate your contribution to our user community!


Navigates to Omnivore Page on scheduled sync

Just noticed it pulls me out of my notes during the scheduled sync. Not sure if you can do it in the background.

Thanks @briansunter we just discovered this one too and are working on a fix.

Hey @briansunter , this has been fixed now in v1.4.3. So now it will sync in background and you can disable the automatic sync by updating the settings to have frequency: 0
If you click on the Omnivore icon on the toolbar, it will still redirect you to the Omnivore page.
Please let me know if it makes sense and works for you!


Migrate platform/macos/objc_wrap.rs to using objc2 crate, drop objc crate

Drop our dependence on the objc crate in favor of objc2. This will allow us to build docs for macos on docs.rs.
There are a few warning to clean up, but all the macos features seem to be functional.

This PR Fixes https://github.com/AugmendTech/CrabGrab/issues/10


cpp solution class code for leetcode search-insert problem

Notes for Reviewers
This PR fixes #
Signed commits

[ ] Yes, I signed my commits.

It's not often that we get to use the Block User feature of GitHub.


ICM: Enable dynamic environment keyvault secret exchange for customer projects

E.g.:
environmentsFromProjectSecrets:
- datadogLabel
- ebayKey

and
{{- range .Values.environmentsFromProjectSecrets }}
- name: {{.}}
  valueFrom:
    secretKeyRef:
      name: project-secrets
      key: {{.}}
{{- end -}}

This issue is connected to our internal infrastructure deployment (see #93578).

Closed this ticket as it's possible with #550


Svg Pattern Tag Removed using ngSanitize

On the documentation in $sanitize code there is no mention as to why <pattern> is removed when sanitizing svg elements. Something similar happens when using <clipPath>. Is this indented? I believe it should be mentioned in the docs that they are not on the list if it's for some purpose.
https://developer.mozilla.org/en-US/docs/Web/SVG/Element/pattern
https://developer.mozilla.org/en-US/docs/Web/SVG/Element/clipPath

I assume this is just an oversight, although I don't know if it can be a security issue.

The sanitize svg whitelist seems to be based on the feedparser whitelist (https://pythonhosted.org/feedparser/html-sanitization.html#svg-sanitization), which doesn't contain these elements. I can't say why though.

As pointed out by @Narretz, you can manually work around this with #13282.


Dispatcher.js does nothing with the options parameter

The dispatcher function of dispatcher.js takes a parameter options. But it is just passed around, but ignored. This is probably a todo.

Yes. I'm not sure what is correct behavior when the same action is dispatched before previous is done. It's not a severe issue, because I'm disabling UI with pending actions, so user can't submit form two times for example. But some actions should be probably allowed to be called as offten as possible... I planned some flag like "forceDispatch" or something like that, but I have flags. They are to magic. Haven't time to think about it more yet.

There was a discussion in Flux repository about that I believe. I had the same issue earlier today and ended up with an error Cannot dispatch an action when another action is being dispatched (something like that). I've ended up wrapping my action in a setTimeout that was actually suggested by Flux guys to run the action out of the current iteration. In my case, I was sending an action on componentDidMount and that was making a conflict with other actions during initial load of the whole app (in case of refresh).

That's not exactly the same issue with promised based async dispatching, but probably should be consistent, which already is...


UI should redirect if you have an invalid token

Feature Request
If the UI has an invalid token, and you go to to My Workflows, My Tools, or My Account, the pages come up, but without the important content, e.g., no workflows, no tools, no profile info, etc.
Also the button at the top right is in a funny state; it has blank text.
The UI should instead redirect to you to the sign in page if you go to one of those pages, and button at the top right should say Login/Register.
This is fix would mainly be a local dev nicety, as when I reinitialize my local database, my previously issued token becomes invalid. But if we revoke a token, it would become an issue there as well.
┆Issue is synchronized with this Jira Bug
┆Fix Versions: Dockstore 2.X
┆Issue Number: DOCK-247
┆Sprint: Backlog
┆Issue Type: Bug

Can simulate when restoring a different database

Could use same mechanism as https://github.com/dockstore/dockstore-ui2/pull/740

Relates to #3361, perhaps.

You can manually "invalidate" your token by logging in, changing your token's value in your browser's LocalStorage, and then refreshing.

Confirmed it logs me out with an invalid token on dev.
Webservice - 5390433
UI - 2.8.5-131-g14afbd25
Compose Setup - 5454f4a
Deploy - <IP_ADDRESS>-125-gb72dba0
galaxyParsingLambdaVersion: 0.0.6


when will the 5.0 stable version be released?

What problem does this feature solve?
for the Npm security vulnerabilities, when will the 5.0 stable version be released?
What does the proposed API look like?
as soon as possible

I know it's frustrating, but I don't think opening new issues will make the process go faster.
There is already a pinned issue about the V5 release

I just want to know the approximate time

Is there a business requirement for that or can you wait for an official update? I highly doubt asking will give an answer.

No answer as usual.


Draft Donation Service

Create draft donation entities holding the upcoming donation information
A matcher service to match pending draft donations with transactions has happened on the network

@jainkrati

The backend service with the support of EVM donations is merged into staging. @MohammadPCh is testing with modified version of FE on his machine.

@maryjaf can you test and complete this? Post that we can deploy latest backend @mohammadranjbarz @mhmdksh

Please check below video: @aminlatifi @MohammadPCh
-Tap on reject on metamask modal
-After that by taping again  on donate button ""transaction rejected" is shown
https://github.com/Giveth/impact-graph/assets/111529185/a0aca4ef-c022-4098-baf2-3f01b8ae6059

Please check below video: @aminlatifi @MohammadPCh -Tap on reject on metamask modal -After that by taping again on donate button ""transaction rejected" is shown
Screen.Recording.2024-02-14.at.1.38.35.PM.mov

@MohammadPCh Can you take a look?

I couldn't complete a solana donation, please take a look
https://github.com/Giveth/impact-graph/assets/111529185/63893c46-e257-4ff6-8d13-e0146675f40c

@maryjaf let's have a call together. I will ping you in discord.

Please check below video: @aminlatifi @MohammadPCh -Tap on reject on metamask modal -After that by taping again on donate button ""transaction rejected" is shown

@aminlatifi

I couldn't complete a solana donation, please take a look
Screen.Recording.2024-02-14.at.2.08.58.PM.mov

I couldn't complete a solana donation, please take a look

@alireza-sharifpour helped me and did a test on solana donation and everything was ok for him, it seems this problem is related to my network

Please check below video: @aminlatifi @MohammadPCh -Tap on reject on metamask modal -After that by taping again on donate button ""transaction rejected" is shown

 @aminlatifi

Thanks @aminlatifi this problem has been resolved
there is no more problem on draft donation, it's ready to be deployed


Matrix chain multiplication

Description
Implementation of Matrix chain multiplication

LGTM ✅
Thank you for your contribution 💖

#1


[BUG] With Console open I get an error "DevTools failed to load source map: Could not load content for app://obsidian.md/styles.css.map: System error: net::ERR_FILE_NOT_FOUND"

What happened?
When enabling Projects with Console open the following error is generated "DevTools failed to load source map: Could not load content for app://obsidian.md/styles.css.map: System error: net::ERR_FILE_NOT_FOUND"
What did you expect to happen?
Loaded message without error
How can we reproduce it (as minimally and precisely as possible)?
Disable and Enable plugin with Console open
Anything else we need to know?
No response
Plugin version
1.17.2
Obsidian version
1.5.12
OS
Windows

Close as duplication of #773. Thanks for reporting as I can't stablely reproduce this, and you've provided an evidence that this is not a platform related problem. Will look into this when I next have time.


[FEATURE] Custom replay buffers

Sparse rewards are a problem for everyone in RL dealing with robotics and such.
Just like its possible to create your own networks (which is awesome), I think it could be useful be able to create your own replay buffers to implement things like Hindsight Experience Replay and others.

Hi, this framework is designed to be customizable for all parts, including the buffer, just implement your own buffer by inheriting the Buffer class in https://github.com/iffiX/machin/blob/master/machin/frame/buffers/buffer.py
And pass the buffer to whichever "TorchFramework" you would like to plug in through its init arguments, take A2C as an example:
https://github.com/iffiX/machin/blob/7fa986b1bafdefff117d6ff73d14644a5488de9d/machin/frame/algorithms/a2c.py#L51
Currently I don't have time to provide the HER implementation myself, however I can provide any technical support you need.


sendTypingIndicator: make callback optional, fix end function

I was getting this error:
Unhandled rejection TypeError: callback is not a function
    at /var/www/node/messenger/node_modules/facebook-chat-api/src/sendTypingIndicator.js:39:18
    at tryCatcher (/var/www/node/messenger/node_modules/facebook-chat-api/node_modules/bluebird/js/main/util.js:26:23)
    at Promise._settlePromiseFromHandler (/var/www/node/messenger/node_modules/facebook-chat-api/node_modules/bluebird/js/main/promise.js:510:31)
    at Promise._settlePromiseAt (/var/www/node/messenger/node_modules/facebook-chat-api/node_modules/bluebird/js/main/promise.js:584:18)
    at Promise._settlePromises (/var/www/node/messenger/node_modules/facebook-chat-api/node_modules/bluebird/js/main/promise.js:700:14)
    at Async._drainQueue (/var/www/node/messenger/node_modules/facebook-chat-api/node_modules/bluebird/js/main/async.js:123:16)
    at Async._drainQueues (/var/www/node/messenger/node_modules/facebook-chat-api/node_modules/bluebird/js/main/async.js:133:10)
    at Immediate.Async.drainQueues [as _onImmediate] (/var/www/node/messenger/node_modules/facebook-chat-api/node_modules/bluebird/js/main/async.js:15:14)
    at processImmediate [as _immediateCallback] (timers.js:383:17)

when using:
end = api.sendTypingIndicator(event.threadID, function() {});
// run some background process
api.sendMessage(msg, event.threadID, end);

and it turned out that function end(cb) was called with cb being an object instead of a function.

Is this behaviour consistent with code you're seeing elsewhere in the api? I don't think I understand why we would want to allow people to pass in objects or other types that get silently swapped for an empty callback.
Do you think you could change this so that we explicitly fail when they pass something in that isn't a function?  That seems to make more sense to me, if anything.

Ahh sorry, I reread the example and see what you were trying to do.  Not sure what the right option is here.  More of a design question at this point.

how about adding some warning when swapping for an empty callback?

Ok sure.  I talked to @bsansouci and he thought this is a usecase worth supporting.  Let's go with the warning rather than failing.

Is everything okey now?

Thanks.


Add org-roam doctor check for the dot executable

Actually, let me change the phrasing

What about if users are using neato? Just a thought, but I think the doctor warning that the default won't work is enough, and we don't need to cover users who read the docs and figured out the switch.

Thanks!

What about if users are using neato?

I could change it later to check org-roam-graph-executable instead of "dot".

I don't think this is a huge issue, since neato is usually packaged with dot in graphviz, but covering all cases is probably best.


Update README.rst

Fix typo

Pull Request Test Coverage Report for Build 590

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 100.0%

Totals

Change from base Build 584:
0.0%

Covered Lines:
6772

Relevant Lines:
6772

💛  - Coveralls


storage-resize-images: Resize images by covering the desired dimensions rather than fitting them

storage-resize-images
This feature request is for extension: \storage-resize-images
What feature would you like to see?
I would like to be able to specify a strategy to resize the images that will indicate whether the image should cover the target dimensions or fit them. These are analogous to the object-fit property in CSS.
How would you use it?
I would use it to create images that are guaranteed to fit certain size. The current resize ensures an image doesn't exceed the dimensions, but doesn't guarantee that space will be covered.

Hey @phinatic, thanks for the request! I don't have a problem with this request, it is easy enough to implement changes in how images ought to fit given dimensions &updating this hardcoded input. My slight pause for concern is another input for the user to select. Currently, there are 6 & with this PR there will be 8. This feature request will bump it to 9.
What do you think, @jhuleatt?

Hey there, the extensions team is still discussing this and #474 internally. As @russellwheatley said, it would be great to have more customization, but we want to be careful with the number of params for this extension, given the level of customization that Sharp allows. I'm going to move this to the "blocked" state while we consider it.

This option would be fantastic as it was an immediate disappointment I couldn't do this natively right now.
A better approach though would be to use some kind of extra string modifier in your current dimensions list (e.g. 200?x400?) so the image fits into at least one of these dimension values. This is really important when creating something like 40x40 user avatar image or 200x200 gallery preview image as we wouldn't want a user to manually select their own previews on upload (particularly during mass uploads)

Hello, I would also like to be able to choose my "fit" type as well as being able to set the "withoutEnlargement" boolean. This makes sense because when I'm already setting the width and height of the desired output (ex. 300x300), but depending on the image if it's square or not, I'm getting unexpected results and not getting the image size that I've requested. Being able to set these two options would keep the current functionality of just sizing the image down, but also get more accurate results that I'm request, even if it's making the image bigger than the original.
As per the sharp documentation, I should be able to choose the "fit" to be either cover, contain, fill, inside, or outside. The "withEnlargement" would be either true/false.
https://github.com/firebase/extensions/blob/master/storage-resize-images/extension.yaml


Uplift Dependencies and Java Version

Hello - this plug in is awesome!  However, there are medium-level vulnerabilities in it's dependencies.  For example, with the Spring core 4.3.7: https://snyk.io/vuln/maven:org.springframework%3Aspring-core.  Can we update the dependencies and bring this to Java 8.

If you grant me access to create a branch, I will do a pull request.

@csherida you can fork the repo and then create PR from your fork.


(UDS) Don't ask user to remove IP setting for VNC connection

This is related to #2207 and #2233
With #2233, the ip parameter has been restored for VNC connections. However, the following erroneous warning is logged:-
[20220324-15:41:40] [WARN ] [xrdp_wm_log_msg(xrdp_wm.c:2183)] xrdp_wm_log_msg: Parameter 'ip' is obsolete for sesman connections. Please remove from config
[20220324-15:41:40] [INFO ] [add_string_to_logwindow(xrdp_wm.c:2074)] Parameter 'ip' is obsolete for sesman connections. Please re
[20220324-15:41:40] [INFO ] [add_string_to_logwindow(xrdp_wm.c:2074)] move from config

The ip parameter is still needed for VNC connections.
This PR retains the warning for Xorg connections, where the ip parameter is not required, but ignores it for Xvnc connections. The warning is also simplified to fit on one line.
@Nexarian, @jsorg71 - do you think this is reasonable thing to do, or am I overthinking this? I could just remove the warning entirely.

Thanks @Nexarian
I'll take a look at this tomorrow now.
Sadly I see that #2233 has caused a conflict with this, so you'll need to rebase again at some stage.


Talkback screen reader can't read some messages

Checklist

[x] I have used the search function to see if someone else has already submitted the same bug report.
[x] I will describe the problem with as much detail as possible.

App
Thunderbird for Android
App version
8.1
Where did you get the app from?
Google Play
Android version
14
Device model
Samsung Galaxy A54
Steps to reproduce

open Thunderbird with Talkback enabled; 2. open a message; 3 swipe to the right 9-10 times to move the focus to the web views which containse the text of the message. Sometimes the screen can't read the message and announces "no next default element".

Expected behavior
The screen reader should read the text of the message like in other apps.
Actual behavior
The screen reader says: "no nex default element".
Logs
I am a blind Android user on a Galaxy A54 with Android 14. It happens that when scrolling through an open message with the appropriate gestures of the Talkback screen reader, the text content in the web view is sometimes not spoken. The screen reader announces something like: "no next default element". This happens both when using swipes to move to the next element or paragraph, and when using the continue reading command. A sighted person told me that in some messages, when this problem occurs, a few characters per line or one or two words are shown. The problem occurs sometimes when opening messages one at a time, other times when scrolling to the next message with two fingers, but having disabled the Thunderbird scrolling gestures. Sometimes, but not always, closing the message and reopening it is possible to read it. I have not detected a regularity in the occurrence of the problem or even a specific type of message in which this happens more frequently, except perhaps the very long ones. It can happen that I can read many messages before the screen reader can't read the content, but sometimes it's two or three messages in sequence that aren't read. The other parts of the screen in a message are read correctly and it's only the web view that gives problems. The app is very good for me and could replace the others I use as an alternative, but unfortunately I can't rely on it for now. I hope it can be solved even if I'm not sure I've provided enough information. Thanks.

Thank you for letting us know. If you swipe back and forth, is it always the same message that does not work? Or is it just every 9-10 messages where it randomly does not work?

I offer this comment in case it is helpful in  pointing to this report being a more general, non-Thunderbird one.
I am involved in the development of another Android App and its interaction with the TalkBack screen-reader.
We observe that when our App launches a webview, there is some chance (perhaps 20% ) that TalkBack regards the webview as empty.  (On my Samsung phone, TalkBack says "No next default", whereas on another, Nokia phone, it is completely silent.)
We assume that this is the result of some Race Condition and are investigating on that basis.
We fear that sometimes the content is not loaded before TalkBack examines and builds some accessible map of the page.  And, that TalkBack does not look again once the page completes loading.
We want to try to have the webview complete loading of is content BEFORE making it available to TalkBack.  Or, to find some method of calling on TalkBack to re-examine the web-view content once it has completed loading (and, indeed if it refreshes its content with a page-reload - something our App does and which causes TalkBack to lose track of the webbview content internals).
Hope this helps.

@louderpages This is great context, thanks for sharing your expertise! I'm very interested to hear the results of your experiments, do let us know what you find. Your explanation sounds very plausible.

Hi.  @kewisch and @coppelletti. More findings, but no solution for you.  There seems to be one or more bugs related to Android Chrome's tracking of the accessibility focus for screen-readers.  There are two features, and they seem like they might stem from different bugs.
First feature is the screen-reader reporting an empty web-page. We find this both in Chome Web-views and in the stand-alone Chrome Browser.  It seem to occur only on a page refresh.  This discounts the race condition theory based on http request delay.
One of our team came across this in Gmail on her Android phone.  Perhaps it had happened before but now she was aware of this bug.
The second. more insidious bug is where parts of the page were not found by the screen-reader.  Onlyy parts.  Without visual comparison, a screen-reader user will be unaware of this. Very dangerous. Connected with this is that sometimes those parts disappear and re-appear without a page reload.
We have a couple of logged error messages but then there are hundreds of Android error messages logged every second on a phone.
I have never submitted a bug report to Chrome  - any advice?
Also, would a Thunderbird bug report provoke more attention?


De-dupe locations returned from the defintions request

We might end up with duplicate locations when performing a definition request on eg. MyStruct() when no explicit initializer is declared. In this case we get two symbol infos, one for the declaration of the MyStruct type and one for the initializer, which is implicit and thus has the location of  the MyStruct declaration itself.
rdar://123036565
Fixes #1055

@swift-ci Please test

In which version this fix is expected?

This is included in SourceKit-LSP bundled with Swift 6.0.


v2.7.3 failed with test_build_query_string_complex

Hi， when I run the test, I get a fail at test_mechanize_util:139，
the input_params is
    input_params = {
      number: 7,
      name: "\u{6B66}\u{8005}",
      "ids[]" => [1, 3, 5, 7],
      words: ["Sing", "Now!"],
      params: { x: "50%", y: "100%", t: [80, 160] },
    }

however when run @MU.build_query_string(input_params)
the params I got is
{:x=>"50%", :y=>"100%", :t=>"160"}
I think this maybe a bug.
The last change was made by @knu in 62f337b0648b3a2bc5857b223b4570d708d7fc82
I need some help, thank you~~~

Thanks for the report.  It's a shame I didn't notice the breakage and have left it broken for a long time.

Oops, sorry for the force-push.


[RFC] Trying a RFC to be withdrawn

Summary
A very bad idea Proposed : let's give up python for julia everywhere in DESC
Insert Descriptive Summary
Julia kicks _ss, python s_cks
Description
Descriptive summary is descriptive enough
Insert brief background on why this proposal is being made. Ensure that you clearly state your actual, actionable, proposal.
I want to test the RFC system
Planned End Date
at least 72 hours in the future for ordinary issues or 1 week ahead for major issues.
Immediate

So I cannot assign to anyone, not even me. Label withdrawn does not exist, and I cannot create it. I presume that this is because we are testing on a GH repo in Heather"s space, without the proper credentials for collaborators.

Ok I can close and reopen an issue without any labeling constraints. Is there a way to forbid closing an issue based on what label is set for instance?


After i install cleverhans by pip, i can't import any function from it

The way that i install cleverhans: pip install cleverhans
The version of python: 3.7.2
The version of cleverhans: 3.0.1
Problem:
from cleverhans.compat import reduce_max
error: Unresolved reference reduce_max
There are many such problems， what should i do??

Hi @Nyn2019, the CleverHans on PyPI is pretty old. Please clone from Github and install from your local clone. Something like
git clone https://github.com/tensorflow/cleverhans.git
cd cleverhans
pip install .

Thanks.

Hi @Nyn2019, the CleverHans on PyPI is pretty old. Please clone from Github and install from your local clone. Something like
git clone https://github.com/tensorflow/cleverhans.git
cd cleverhans
pip install .

Thanks.

Thanks a lot 🙂

@Nyn2019 no problem! Please close the issue if you think it's been resolved. Thanks :)


Bug: shared Observables not actually repeatable/retryable

var source = Rx.Observable.interval(100).take(3)
  .concat(Rx.Observable.throw(new Error('BOOM')))
  .share();

source.retry(3).subscribe(
  x => console.log(x),
  e => console.error(e.message),
  () => console.log('|'));

source.retry(3).subscribe(
  x => console.log('   '+x),
  e => console.error('   '+e.message),
  () => console.log('   |'));

Runs as
0
   0
1
   1
2
   2

while we expected
0
   0
1
   1
2
   2
0
   0
1
   1
2
   2
0
   0
1
   1
2
   2
BOOM
   BOOM

I'm investigating some solutions in ConnectableObservable to be able to support @blesh's use cases for retryable/repeatable Observables, but it seems like this is a bug.

Weird, I thought I had tests around that from the beginning. It's probably my most recent changes to that that broke the behavior. I was using share and retry in my AngularConnect example (alpha.7 I think), and it was fine.

We have this test:
  it('should retry just fine', function () {
    var e1 =  cold('---a--b--c--d--e--#');
    var expected = '---a--b--c--d--e-----a--b--c--d--e--#';

    expectObservable(e1.share().retry(1)).toBe(expected);
  })

But notice how there is just one subscriber in this case.

Also, this test doesn't have multiple subscribers: https://github.com/ReactiveX/RxJS/blob/master/spec/operators/multicast-spec.js#L88

Hmm... it looks like retryWhen works fine, but the other two do not. My example was using retryWhen.
It doesn't seem like a problem with ConnectableObservable, my suspicion lies with the Subscribers for repeat and retry. I suspect they're being disabled by a flag when the error or completion hits them.

Also, this test doesn't have multiple subscribers: https://github.com/ReactiveX/RxJS/blob/master/spec/operators/multicast-spec.js#L88

It looks like it resubscribes whenever it completes: https://github.com/ReactiveX/RxJS/blob/e9b13d0178a7ebad2cccd217fc0249449804831d/spec/operators/multicast-spec.js#L102
(also, pro-tip: Hit Y before you copy a link in GitHub to get the SHA in the URL so it doesn't change over time.)

Ok, I'm narrowing down the problem. RetryWhen works because it usually retries asynchronously some time later. Retry is synchronous, and a race condition happens with RefCounting:

First subscribe to the refCount().retry(2) (refCount counter becomes 1)
Second subscribe to the refCount().retry(2) (refCount counter becomes 2)
Error happens, First subscribe is unsubscribe (refCount counter becomes 1)
Retry kicks in and re-subscribes the first (refCount counter becomes 2)
Second subscribe is unsubscribed, because of the error (refCount counter becomes 1)
Retry kicks in and re-subscribes the second (refCount counter becomes 2)

As you can see, the refCount counter never goes to zero, which means the cold source is not resubscribed.
Working on a solution...

I tried a solution where the RefCountSubscriber resets the counter when it encounters an error, but I still have problems with retry's synchronous behavior kicking in too soon (because Subject errors are propagated depth-first to observers, not breadth-first):

First subscribe to the refCount().retry(2) (refCount counter becomes 1)
Second subscribe to the refCount().retry(2) (refCount counter becomes 2)
Subject raises error to first subscriber, which unsubscribes (refCount counter is RESET to 0)
First retry kicks in and re-subscribes the first (refCount counter becomes 1)
Subject raises error to second subscriber, which unsubscribes (refCount counter is RESET to 0)
Second retry kicks in and re-subscribes the second (refCount counter becomes 1)

Conclusion: only the second subscriber actually performs a retry, the first one doesn't because it gets interrupted by the subject.observer[1].error() of the second subscriber.
A sloppy solution for this would be to change retry to resubscribe on next tick. But it's sloppy. Any suggestions @trxcllnt @blesh ?

Update to this issue:
I've been exploring how does RxJava solve this problem. (I verified that RxJava gives the correct expected output for the same code snippet in this issue)
My current guess is it has all to do with refCount and ConnectableObservable, we might need to treat synchronous Observables as a special case. E.g.
public final class OnSubscribeRefCount<T> implements OnSubscribe<T> {
    @Override
    public void call(final Subscriber<? super T> subscriber) {

        lock.lock();
        if (subscriptionCount.incrementAndGet() == 1) {

            final AtomicBoolean writeLocked = new AtomicBoolean(true);

            try {
                // need to use this overload of connect to ensure that
                // baseSubscription is set in the case that source is a
                // synchronous Observable
                source.connect(onSubscribe(subscriber, writeLocked));
            } finally {
                // need to cover the case where the source is subscribed to
                // outside of this class thus preventing the Action1 passed
                // to source.connect above being called
                if (writeLocked.get()) {
                    // Action1 passed to source.connect was not called
                    lock.unlock();
                }
            }
        } else {
            try {
                // ready to subscribe to source so do it
                doSubscribe(subscriber, baseSubscription);
            } finally {
                // release the read lock
                lock.unlock();
            }
        }
    }
}

Also, confirmed that I have to "RefCountSubscriber resets the counter when it encounters an error", because RxJava does it too, see cleanup():
public final class OnSubscribeRefCount<T> implements OnSubscribe<T> {
    void doSubscribe(final Subscriber<? super T> subscriber, final CompositeSubscription currentBase) {
        // handle unsubscribing from the base subscription
        subscriber.add(disconnect(currentBase));

        source.unsafeSubscribe(new Subscriber<T>(subscriber) {
            @Override
            public void onError(Throwable e) {
                cleanup();
                subscriber.onError(e);
            }
            @Override
            public void onNext(T t) {
                subscriber.onNext(t);
            }
            @Override
            public void onCompleted() {
                cleanup();
                subscriber.onCompleted();
            }
            void cleanup() {
                // on error or completion we need to unsubscribe the base subscription
                // and set the subscriptionCount to 0
                lock.lock();
                try {
                    if (baseSubscription == currentBase) {
                        baseSubscription.unsubscribe();
                        baseSubscription = new CompositeSubscription();
                        subscriptionCount.set(0);
                    }
                } finally {
                    lock.unlock();
                }
            }
        });
    }
}

Another mind dump:
I noticed RxJava does the following, and RxJS doesn't, but should. Seems very obvious the refCount producer should emit synchronously to the first subscriber everything it has, then error, then retry, and only after that, start the same for the second subscriber. In other words, RxJS subscribers are interleaved but should execute serially when the source is entirely synchronous.

A subscribes to ...refCount().retry(1) (refCount counter becomes 1)
Subject1 is created and cold source is subscribed.
Subject1 raises error to A's RefCountSubscriber (refCount counter is RESET to 0)
A's Retry kicks in and re-subscribes (refCount counter becomes 1)
Subject2 is created and cold source is re-subscribed.
Subject2 raises error to A's RefCountSubscriber (refCount counter is RESET to 0)

B subscribes to ...refCount().retry(1) (refCount counter becomes 1)
Subject3 is created and cold source is re-subscribed.
Subject3 raises error to B's RefCountSubscriber (refCount counter is RESET to 0)
B's Retry kicks in and re-subscribes (refCount counter becomes 1)
Subject4 is created and cold source is re-subscribed.
Subject4 raises error to B's RefCountSubscriber (refCount counter is RESET to 0)

0
1
2
0
1
2
0
1
2
BOOM
   0
   1
   2
   0
   1
   2
   0
   1
   2
   BOOM

@staltz In other words, RxJS subscribers are interleaved but should execute serially when the source is entirely synchronous.

Yes, I was wondering about this myself. Let me know if you'd like me to take a look at this as well.

I solved that one already, using this:
  /**
   * Instructs the ConnectableObservable to begin emitting the items from its
   * underlying source to its Subscribers.
   *
   * @param onSubscribe a function that receives the connection subscription
   * before the subscription to source happens, allowing the caller to
   * synchronously disconnect a synchronous source.
   */
  _callbackConnect(onSubscribe: (subscription: Subscription<T>) => void): void {
    let subscription = this.subscription;
    if (subscription && !subscription.isUnsubscribed) {
      onSubscribe(subscription);
      return;
    }
    this.subscription = subscription = new Subscription();
    onSubscribe(subscription);
    subscription.add(this.source.subscribe(this._getSubject()));
    subscription.add(new ConnectableSubscription(this));
  }

As per RxJava.
Now I'm onto solving still the main bug described in this issue.

@staltz and @trxcllnt ... we have a big of unfinished business with the es7 observable spec that relates to this I think.
We need to add a start event to Observer interface that fires on subscription and provides the subscriber. This seems pretty related to the onSubscribe event in the commit above.

@staltz, once #726 lands, we may be able to leverage the start handler and create a different approach to this. Also @abersnaze had mentioned a method of doing multicast refCounting that used a custom subject with some special logic in the start method. Food for thought.

@staltz are you satisfied that this can be closed now?

Definitely can be closed.


"mailto:" url doesnt work on mobile devices in Viva Connections Card

Target SharePoint environment
SharePoint Online
What SharePoint development model, framework, SDK or API is this about?
not applicable
Developer environment
No response
What browser(s) / client(s) have you tested

[ ] 💥 Internet Explorer
[ ] 💥 Microsoft Edge
[X] 💥 Google Chrome
[ ] 💥 FireFox
[ ] 💥 Safari
[X] mobile (iOS/iPadOS)
[X] mobile (Android)
[ ] not applicable
[ ] other (enter in the "Additional environment details" area below)

Additional environment details

browser version
SPFx version
Node.js version
etc

Describe the bug / error
When adding a web link card to the Viva Connections Dashboard and setting the url to<EMAIL_ADDRESS>if works on desktop browsers but fails on mobile devices
Steps to reproduce

Setup a web link card in viva dashboard
2.Set url to "mailto:emailaddress"
3.Click on desktop or phone browsers

Expected behavior
Open email with the relevant email address

@jwatts25 Are you still facing this issue?

Hi, this seems ok now


Add VZLOM by GLYCKOZA

Song Name
VZLOM
Artist Name
GLYCKOZA
Source
Direct file download
Youtube Link
No response
Direct File Link
https://open.spotify.com/track/75feEPMGpyT5CzdmUP5sbL?si=2ea84601b7c04d21
Song ID
659212
Start Offset [ms]
1
Extra
Created from Auto Nong.

reject
spams from same submission


Define code style for sourcecode

In addition to the https://github.com/MovingBlocks/Terasology/wiki/Checkstyle definition, the project should define an common source code style guide.
In eclipse an code formatter could be used to keep the code always clean. I don't know if idea supports such a feature?!
Starting from the default java code style i would prefer such an environment:

always spaces, no tabs, ident = 2, tab == 2 space
max line length increase from 80 to 120 (widescreen monitors g)  - also for comments
automatic cleanup import statements, remove unused imports
use "final" where possible
remove trailing whitespaces
correct indentation
sort class members (methods, constructors, no fields)
add missing @Override and @Deprecated

My experience: with such a style guide it's easy to keep the code clean
For eclipse i can provide a configuration file

Closing this from age, partial completion, and replacement elsewhere


Start of building the governance out

Signed-off-by: John Mertic<EMAIL_ADDRESS>

This is superseded by egeria-governance branch that took this input and combined it with the feedback from the Data Governance PMC


chore: update SDK specs based on latest development observations

This attempts to capture some things we discovered, changed,
or tried to standardize on as a result of the C# and PHP work.

LGTM

@pgautier404 i know that this isn't in a completed state but I'd like to merge it because it moves some things forward.  Any objections?


ntp time sync

This works for SIM800 only, so not sure if you want to merge it.
It adds a methods to synchronize time with an NTP server via GRPS data connection.
Check commit messages for details

Nice PR. Thanks.


Fix issue using str for dataset creation

Description

When a str was passed to RadarDataset, it would fail because it was expecting a pathlib.Path.
All tests used the fixture tmp_path, so this was unnoticed.
This PR adds a test and fixes the issue.
Related issues:

#47

Instructions to review the pull request

The CI tests are enough

Failing because pre-commit.ci tries to run prospector which is configured using a local hook. Created #54 to fix it.


change blindedBlockCreatorCache keys from slot to slotAndBlockRoot.

PR Description
Part of fixes for SSV compatibility. Switch cache key from slot to slotAndBlockRoot.
Fixed Issue(s)

Fixes #8625
Documentation

[x] I thought about documentation and added the doc-change-required label to this PR if updates are required.

Changelog

[x] I thought about adding a changelog entry, and added one if I deemed necessary.

I'll ask to one of you why this is needed :)

I'll ask to one of you why this is needed :)

Essentially, it is a bit of protection for future enhancements for zero cost. If we implement replays, best block produced from multiple BN functionalities. Also I think it's more concise.

I'll ask to one of you why this is needed :)

Essentially, it is a bit of protection for future enhancements for zero cost. If we implement replays, best block produced from multiple BN functionalities. Also I think it's more concise. Similar to isLocallyCreatedBlock in the ValidatorApiHandler.

ok, sold


Fixes #6 removed unused event_catcher

Should also remove app/models/manageiq/providers/autosde/storage_manager/event_catcher


BuscaCEP.Providers.Correios.Utils

No such pas file
BuscaCEP.Providers.Correios.Utils

Is it generating any errors? The library uses the file BuscaCEP.Providers.Correios.Utils.dcu for compilation.

If you did not know dcu are per Delphi version
This dcu is not my version
Unless we have PAS file your software is usless

Released in version v2.1.0

Thanks but errors as I compile with D10.2.3 so good luck

Thanks but errors as I compile with D10.2.3 so good luck

Thank you for the feedback! I have already made the necessary changes, and the minimum version is now Delphi 10 Seattle.


Delete namespace cli command

Codecov Report
Patch coverage: 7.07% and project coverage change: -1.98 :warning:

Comparison is base (ac44dde) 38.60% compared to head (d5189ad) 36.62%.

:exclamation: Current head d5189ad differs from pull request most recent head 6c021ad. Consider uploading reports for the commit 6c021ad to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #424      +/-   ##
==========================================
- Coverage   38.60%   36.62%   -1.98%
==========================================
  Files          49       49
  Lines        2961     3159     +198
==========================================
+ Hits         1143     1157      +14
- Misses       1697     1880     +183
- Partials      121      122       +1

Impacted Files
Coverage Δ

pkg/environment/applier.go
0.00% <0.00%> (ø)

pkg/util/util.go
58.40% <0.00%> (-9.20%)
:arrow_down:

pkg/environment/environmentApply.go
13.35% <10.21%> (-1.65%)
:arrow_down:

... and 1 file with indirect coverage changes

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


fix: with item precedence for multiple context managers with brackets

Currently when parsing code like the following:
with (open('d') as d,
      open('e') as e):
  f

tree-sitter is converting it into a with_statement which has one with_item, which contains a tuple of as_pattern.
In the Python specification multiple context managers should each be represented by a WithItem, each of which has a single (possibly aliased) context manager.
This was causing problems for us when using tree-sitter to parse such structures into an AST.
This PR adjusts (correctly I hope, though open to being wrong!) the precedence of the with_item to fix this issue and bring it into line with the Python AST.

No other objections, it seems, so I'll go ahead and merge this.
Thanks for the fix!


Remove OS X unique entry in https://raw.githubusercontent.com/StevenBlack/hosts/master/hosts line 22

Hi, in the list: https://raw.githubusercontent.com/StevenBlack/hosts/master/hosts, it seems line 22 is just for OS X unique and it can't be recognized in DNSMASQ or other well-known DNS systems in /etc/hosts. I can see the same record has been commented in line 159276.

Thank you for this @WFANG12719.
We've talked about this many times before in various guises.
You can safely ignore warnings raised by whatever you're using.
Closing.


Throw an error if a product declared in a package is also used as a dependency

A product declared in a package should not be used as a dependency. This PR prevents such use case.
Motivation:
Resolves rdar://71912826 ([SR-13913]: Library product name must match target name??)
Modifications:
This PR checks if a target dependency includes a product declared in the same package, checks the targets of that product, and throws an error if invalid.
Result:
With this change, it throws an error to prevent using a product declared in the same package as a dependency.

@swift-ci smoke test

Wouldn't this prevent, for example, a dependency on a command line executable that needs to be built so it can be accessed at runtime by a library?

Wouldn't this prevent, for example, a dependency on a command line executable that needs to be built so it can be accessed at runtime by a library? Or is this just improving the error message in a case that would already have caused a failure?

It's the latter. It's already throwing an error. This change improves it by adding an extra check to see if there's any dependency to a product that's declared in the package (there shouldn't). Would we also need to check if that product is a library? If it's an executable, could it possibly be used as a dependency of, say, a test target?

Would we also need to check if that product is a library? If it's an executable, could it possibly be used as a dependency of, say, a test target?

I think the executable product won't work, but the executable target would. We should probably just add a few more test cases for the different permutations of scenarios and check whether we are hitting anything that's allowed today with the new check just to be safe?

Would we also need to check if that product is a library? If it's an executable, could it possibly be used as a dependency of, say, a test target?

I think the executable product won't work, but the executable target would. We should probably just add a few more test cases for the different permutations of scenarios and check whether we are hitting anything that's allowed today with the new check just to be safe?

The check verifies if a dependency is a declared product, not a target, by comparing the names. In case a product and its target have the same name, regardless of its type (exec or lib), it will then not throw an error (see the 2nd test), as the dependency should map to the target, not the product. If their names are different and the dependency name is same as the product name, then it will throw an error with the new message (see the 1st test).  Lmk if there's anything else missing that should be covered in tests.

Would we also need to check if that product is a library? If it's an executable, could it possibly be used as a dependency of, say, a test target?

I think the executable product won't work, but the executable target would. We should probably just add a few more test cases for the different permutations of scenarios and check whether we are hitting anything that's allowed today with the new check just to be safe?

Hmm... today, though, a test target can definitely depend on an executable, which results in a linked executable product that it can shell out to (in addition to linking against the executable's main module, as was recently added). Doesn't that require a dependency on the executable product?

Just to clarify, do you mean an executable product can be declared in the same package and also used as a dependency for a test target?

Would we also need to check if that product is a library? If it's an executable, could it possibly be used as a dependency of, say, a test target?

I think the executable product won't work, but the executable target would. We should probably just add a few more test cases for the different permutations of scenarios and check whether we are hitting anything that's allowed today with the new check just to be safe?

Hmm... today, though, a test target can definitely depend on an executable, which results in a linked executable product that it can shell out to (in addition to linking against the executable's main module, as was recently added). Doesn't that require a dependency on the executable product?

Just to clarify, do you mean an executable product can be declared in the same package and also used as a dependency for a test target?

Yes, exactly.
But there seems to be something interesting going on here, because it only works if the dependency is on the product that is implicitly created for each executable target.  If everything worked regularly, a test target with a dependency on an executable target would only be able to count on the module having been compiled but not the executable having been linked, since it's a dependency on the target and not the product.  But the product is produced in this case.
This can be seen with swift package init --type=executable, where the unit test shells out to the linked executable to test it.   However, if I change the test target's dependency to be on the executable product, then I get an error.  So it doesn't appear to actually work, since there is no way now to specify a product dependency on a product in the same package.  It just works in the implicit case for some reason.

Lmk if there's anything else missing that should be covered in tests.

So it seems that I was wrong about general dependencies on products from the same package, but the executable case definitely does work.  So I think the only additional thing interesting here would be to add an executable to the test case and make sure nothing unexpected happens there, given that there seems to be some special logic to make that work (so that the test has access to the linked executable product)

@swift-ci smoke test


Write before job document.

So we can incorporate your pull request, please share the following:

What issue are you addressing with this pull request? https://project.marklogic.com/jira/browse/DHFPROD-1468
Are you modifying the correct branch? (See CONTRIBUTING.md)
Have you run unit tests? (See CONTRIBUTING.md)
Version of MarkLogic Java Client API (see Readme.txt)
Version of MarkLogic Server (see admin gui on port 8001)
Java version (java -version)
OS and version
What Changed: What happened before this change? What happens without this change?

Its was merged by mistake but I have reverted it back.

Opened a new pull request - https://github.com/marklogic/java-client-api/pull/1027 which includes the changes of this pull request and the after job document.


Output is not mentioned in the streams-patterns sample

Description:
Output is not mentioned in the streams-patterns sample
Actual output:
alertRoomAction function invoked for Room:2 and the action :stop
alertRoomAction function invoked for Room:2 and the action :stop

Affected Product Version:
Ballerina Platform - beta1
OS, DB, other environment details and versions:
In-built JAVA
Windows 7

This sample is removed.


[Java 24.10]: Importants methods of string buffer

Description
Add audio, documentation, and video regarding the Importants methods of string buffer

Location of File to be added
The files should be added inside the String Buffer Methods which will be inside String Handling folder which will be inside of Java folder. If the folder is not present, create the folder with this exact name.

The documentation file can be in the .md/.py/.ipynb format.
Audio should be in .mp3 format and to be submitted through a Google drive link.
Video can be in any format and should be submitted through a Google Drive link.

Note:
You are required to comment with \assign CONTENT_TYPE, so that other content types can be created at the same time.
Failing to comment in the above manner will lead to the removal of assignment from the issue even if the bot assigns.
You are required to do a PR within 7 days otherwise you will be unassigned and others will be assigned.
Issues will be assigned on a first come first serve basis.
Domain
Java_Domain
Type of Contribution
Audio, Video, Documentation
Code of Conduct

[X] I follow Contributing Guidelines & Code of conduct of this project.

/assign Documentation

/assign Documentation

/assign audio

\assign audio


Fixing Callback clearing issue

When Called internally form auto session it used to remove the callback
with null (if user already called intisession() from anywhere else )
@Sarkar @aaustin

looks good to me - tested as well :+1:

:+1:


Coverage flag

Still needs docs

Changes Unknown when pulling 6616b62167efb0621734b587dd25e29b6ae5e719 on coverage into ** on master**.

Coverage decreased (-1.2%) to 67.755% when pulling 96ed7262d128b0e92849bf9ab4edfd57c4fd338a on coverage into d4951b215811741494eb677c11c6abe9b7c3fdf1 on master.

Coverage decreased (-1.2%) to 67.755% when pulling 3bc233896429c9771f0281e4d0e7885bb4c8012d on coverage into d4951b215811741494eb677c11c6abe9b7c3fdf1 on master.

Coverage decreased (-1.2%) to 67.755% when pulling cf8287d40fdedad0c2fed292391fe037ee842dcf on coverage into d4951b215811741494eb677c11c6abe9b7c3fdf1 on master.

Coverage decreased (-1.2%) to 67.755% when pulling 70da4586a6c4f83327a0038b17130062fbfc11f7 on coverage into d4951b215811741494eb677c11c6abe9b7c3fdf1 on master.

Coverage decreased (-1.2%) to 67.755% when pulling 3b0535f100122b95f365ca5d674e3dd635d3ce71 on coverage into d4951b215811741494eb677c11c6abe9b7c3fdf1 on master.

Coverage decreased (-1.2%) to 67.755% when pulling 791bf1172fbedf697ab457d4204b40485123fc6a on coverage into d4951b215811741494eb677c11c6abe9b7c3fdf1 on master.


Edit the checks-conditionals directory lessons

Most of the files have minor changes around:

f-string usage
python style/best practices
parameters in functions

This is great!! let's merge!! thank you @willingc


[feat] Support Dead Letter Topic.

Master Issue: #114
Motivation
#77, #114
Modifications

Add DeadLetterPolicy. When the message redeliveryCount > DeadLetterPolicy.maxRedeliveryCount, the message is sent to the DLQ topic and ack this msg.

Verifying this change
This change added tests and can be verified as follows:

Add DeadLetterQueueTest to verify Send to DLQ, according to the following scenarios(Cartesian product of the following conditions):

Producer batch [enabled, disable]
Topic is [single, multi]
Consumer sub type [Shared, Key_Shard]
Trigger by [unack, ack_timeout]

Add DeadLetterQueueTest.testInitSubscription to cover init DLQ topic subscription: https://github.com/apache/pulsar/pull/13355

Add DeadLetterQueueTest.testAutoSetDLQTopicName to cover default DLQ topic name.

Add DeadLetterQueueTest.testDLQWithSchema  to cover producer and consumer with the schema scenario.

If a topic has a schema, and the consumer uses AUTO_CONSUME schema, and DLQTopic also has the same schema. In this case, the DLQ producer fails to create(IncompatibleSchema).  Refer to java client same issue: https://github.com/apache/pulsar/issues/9935.
Solution: Depending on #157, After this, DLQ producers use the autoDownloadSchema param when consumers use AUTO_CONSUM.

Documentation

[ ] doc-required
(Your PR needs to update docs and you will update later)

[x] doc-not-needed
(Please explain why)

[ ] doc
(Your PR contains doc changes)

[ ] doc-complete
(Docs have been already added)

@BewareMyPower @Anonymitaet Thanks for your reviews. All suggestions have been fixed. PTAL.

Thanks! LGTM from the doc perspective.

BTW, let's address comments in this PR in priority to #157.

I have left the last comments. This PR overall LGTM. Please avoid committing such a huge patch next time. If a PR contains many code changes, it would be very hard to review all of them. Some potential issues might not be exposed.


Reset errno in lwt jobs before invoking job function

Otherwise, APIs which rely on errno to resolve exit code ambiguity (e.g. readdir) are not bindable correctly. See dsheets/ocaml-unix-dirent#17 for an example/work-around in that
particular case.

Thank you.


Switch away from string refs?

The itemsRenderer callback is defined as accepting a string ref. However, according to this article, string refs are deprecated and may be removed from React at some point.

The legacy way of creating refs in a React application is using string refs. This is the oldest method and is considered legacy or deprecated because it will be removed in future releases of React.

I can across this when I was having trouble using a Material UI component in itemsRenderer because it explicitly does not accept string refs. I did find a solution, but it raised this question in my mind.

The itemsRenderer callback is defined as accepting a string ref.

Not sure where you see this? It is passed a function.
https://github.com/caseywebdev/react-list/blob/d955cc19ae5edc48c9f404981bd4398c4adb763c/react-list.es6#L507


How to Use in A Django App

Hi,
I have a Django application that user can query an ontology. I would like to know how I could visualize my ontology using Ontospy using Django. I see where there is Ontowebspy that is now archived.

Ontospy does not include any out of the box functionality for Django, but you can use the library like any other Python data processor.
For example
#
# in views.py
#

def ontology_page(request, uri=""):

    context = {}

    templatee = "my-ontology-template.html"

    # ..
    # .. set ontospy opts
    #

    g = Ontospy(
        URI,
        verbose=verbose,
        pref_title=preflabel,
        pref_lang=preflang,
        hide_base_schemas=hide_base_schemas,
        hide_implicit_types=hide_implicit_types,
        hide_implicit_preds=hide_implicit_preds,
        hide_individuals=hide_individuals)

        context_data = {
            "topclasses": g.topclasses,
            "classes": g.all_classes,
            "properties": g.all_properties,
        # etc...
        }

    return render(request, templatee, context)

Then in the template you simply render the ontology properties using HTML.
For example, see https://github.com/lambdamusic/Ontospy/blob/v<IP_ADDRESS>/ontospy/ontodocs/media/templates/html-single/html-single.html - this template is used by the ontospy gendocs command but that's basically a Django template..


Infer other addresses from SystemConfig once MCP L1 is launched

          The goal of this file to serve as a reference and source of truth, which we verify in the `CheckSecurityConfigs` script? I ask because as of https://github.com/ethereum-optimism/optimism/pull/6555, we can now only define a chain's `SystemConfig` and then discover everything else. Wondering if we can leverage that in this repo (once everyone is on MCP L1 contracts)

Originally posted by @mds1 in https://github.com/ethereum-optimism/superchain-registry/pull/69#discussion_r1471464207

The downside of this is that the other addresses will no longer be tracked in the repository, and therefore not inspectable by humans / services / software packages that want to read them.

@geoknee What do you mean exactly? We can, for example, only ask for their SystemConfig address if it simplifies the add chain process, but still generate output files that contain all other system addresses for humans / services / software packages that want to read them.

Yeah you're right that should work well. I think I was skipping all the way to "only store the SystemConfig address" which is not what this ticket is about.


Libp2p access logs

Add libp2p event handling logs to help debug and investigate incidents. Where applicable, logs should include eventName, sourceNodeId, targetNodeID, jobID, shardIndex, error message, datetime, and duration.
Logs should be in json format to help with post processing if needed

#819


bad interaction: implicit downcast + inferred instantiated guarded type args

I ran into this scenario where the implicit downcast warning comes at play, but where it doesn't feel right as a user:
class A {}
class B<T extends A> {}

test() {
  Object x = new B<A>();
  B b = x;
  return b;
}

This produces a warning in B y = x:
[warning] Unsafe implicit cast from 'Object' to 'B<A>'. This usually indicates that type information was lost and resulted in 'dynamic' and/or a place that will have a failure at runtime.

I was expecting this case to be treated the same as List<dynamic> or types with no-type args: the fact that the guard is implicitly injected shouldn't add more warnings to me as a developer. In fact, I also expect the runtime cost to be the same: there should be an implicit check for B, but by construction all B's are created with a type-arg that is a subtype of A, so I don't expect extra checks for the type arguments here either.
/cc @leafpetersen @vsmenon

I don't understand what you expect here.  In particular:
I was expecting this case to be treated the same as List<dynamic> or types with no-type args:

I think this is treated the same as List<dynamic>.  What do you see as different?
In fact, I also expect the runtime cost to be the same: there should be an implicit check for B, but by construction all B's are created with a type-arg that is a subtype of A, so I don't expect extra checks for the type arguments here either.

It is certainly a valid optimization not to check the type arguments when casting to B<dynamic>, but why do you raise this here?  It's an implementation issue, it doesn't affect the user facing static or dynamic semantics in any way.

It looks like a completely plain down-cast ,which shouldn't cause a warning.
If the line B b = x; is changed to List b = x;, the warning goes away.
So,a cast from Object to B<A> causes a warning and to List<dynamic> does not - that sounds like a bug.

Ah, fair enough.  I wasn't factoring in the bound.  This warning is going away anyway ASAP (https://github.com/dart-lang/sdk/issues/28588), except possibly as a lint.  We should reconsider exactly what the lint should be, but at least for now that's a linter issue and now a language issue.

Thanks @lrhn for clarifying - that's exactly the underlying issue. My claim here is that even if we had the downcast-composite warning, we shouldn't show it in cases where the type argument is a bound.
So if something is added in the linter regarding downcast-composite, this is one case that I believe should be excluded or treated differently.

So, a cast from Object to B causes a warning and to List does not - that sounds like a bug.

No, this is the point of the downcast composite warning.  Downcast composite was added to try to point out casts that might pass on the VM/dart2js and fail on DDC.  There are no types such that the cast from Object to List<dynamic> would pass on non-strong platforms but fail on strong platforms.  Ignoring the bound, there are types such that the cast from Object to B<A> will pass on the VM/dart2js but fail on DDC (specifically, B<dynamic>).  So, again, ignoring the bound, the warning is working as intended.
Siggi's point is fair, that on DDC we will prevent you from creating a B<dynamic> in the first place, so in fact that cast isn't dangerous.  So it's a reasonable feature request, to factor in the bound into the reasoning for that.


baseURL for Alamofire.Manager

set the baseURL for all request

Hi @mattt ,
Could you please provide the link for documentation about constructing URLs with enum here. So that everybody come here can easily navigate to right place.
Regards,
Johny

https://github.com/Alamofire/Alamofire#crud--authorization


path to typings in package.json is wrong

in package.json it pointing to /dist/index.d.ts in reality it is /dist/src/index.d.ts

I will fix it today and release a patch version :)


add GUI for filtering your BIOM table

Currently we can filter via the where parameter within the analysis but having a GUI will be great

At the minimum for a short-term fix, could we add a display like the sample summary one so users can easily see what metadata is available to them?

A good starting point from @adswafford will be to add examples or discussion.

How about something like this? http://querybuilder.js.org

Looks really cool, thanks for sending. This could be an improvement but will it be sufficient? Basically is a guided SQL writing widget not a "nice" GUI for filtering. If you think it's sufficient we could figure out how to put it together ...

I think it's good as a stop-gap the way we discussed last week since it will at least prevent user-driven typos from wrecking the calls. @wasade might want to put something similar in the redbiom section for constructing searches there? Flagged for group discussion at the meeting tomorrow.

Could be interesting as a component of the js library, biocore/redbiom#47


Add pars3d to data.toml

Add github repository for 3D file format parsing to data.toml.

Should I update the PR or is it fine that you moved the entry?

Sorry, forgot to re-run CI after editing it!

Cheers, ty!


snow_records.py - Updated Status

Are there plans to expand snow_records.py and get it certified for Hub?
Some SNOW administrators are hesitant or resource limited and are not as willing/able to install the EDA app in an instance of SNOW, and having a SNOW polling source would be very useful in our environment.  However, without the collection/source being in HUB I do not know if I can get it installed in our environment.

I personally haven't heard of any plans to certify this plugin or create a polling plugin for SNOW at this time.

Good enough response for me. LoL
Thanks for getting back to me.


Program conflicts

Hi,
I currently maintain and build ZVM https://github.com/tristanisham/zvm and we use the same directory path for programs and installations.
I'm all for more Zig version managers, but would you consider changing the directory your version manager uses to not conflict with mine? If users ever switch it may result in both of our programs malfunctioning.

Hello @tristanisham,
Firstly, thank you for reaching out and making aware of the potential conflict. I appreciate the collaborative spirit! To ensure that users have a smooth experience when using both of our tools, I'll create a PR to adjust the directory path. Let's ensure compatibility and a great user experience for everyone! 👍


Small erro in tutorial

Change:" Inject  'flex-calendar' and ..."
To:        " Inject 'flexcalendar' and ..."
The  name correct of module. :D

There's also a typo at README.md file:
<script type="text/javascript" src="bower_components/angular-translate/angular-translate.min.js.js"></script>
note it the double .js.js extension

in fact none of the bower references is right. They should be:
<link rel="stylesheet" href="bower_components/flex-calendar/dist/flex-calendar.css">
<script type="text/javascript" src="bower_components/angular-translate/angular-translate.min.js"></script>
<script type="text/javascript" src="bower_components/flex-calendar/dist/flex-calendar.js"></script>


Catch push event in angular app

How can i catch the push event in service worker in angular app. Is there any way to $watch on "push" event of service worker...?

Service Worker is totally different entity, it has nothing to do with AngularJS. neither you can watch on any service worker variables.
Solution:

Write a AngularJS Service which listen on all the message event from your service worker.
Now this service will be your contact person to your service worker. Make it like a utility service for Service Worker.
Whenever service worker pushes any notification, it will inform your service, and then you can broadcast it wherever you require(or use a publisher subscriber model).

@amitparrikar  Can you share some code for creating service of service worker in angularjs ?
Thank you.

This is not an issue.


Installing jupyter after installing cellpose[gui] breaks the ability to use cellpose gui

After installing cellpose gui by running
python -m pip install cellpose[gui]
If I do:
conda install jupyter
it breaks the ability to bring up cellpose gui by using the command cellpose in the cellpose environment. I can get around this by using two different environments, one for the gui and the other to use the API, but is there a way to have both functionalities in one environment?

what operating system and python version is this? can you please print the error message?
you could also try
pip install notebook

this installs jupyter-notebooks without conda

I am running Windows 10 and Python 3.8. The error message was:
QObject::moveToThread: Current thread (0x1ddc84c2ed0) is not the object's thread (0x1ddcad69e00).
Cannot move to target thread (0x1ddc84c2ed0)

qt.qpa.plugin: Could not load the Qt platform plugin "windows" in "" even though it was found.
This application failed to start because no Qt platform plugin could be initialized. Reinstalling the application may fix this problem.

Available platform plugins are: minimal, offscreen, webgl, windows.

I tried to reinstall it, but that led to further errors.
Nevertheless, your suggestion to try pip install notebook worked for me. Thank you!

great! added it to the readme, closing the issue


Update dt.md

Fixed example output, as it is supposed to be lower case.

Status
Ready
Related Issues
fixes: N/A
Description
Small typo in expected output of mutator
Screenshots

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


XPF start failed with error: (Failed to open kernelcache) ---- Patchfinding

XPF start failed with error: (Failed to open kernelcache)
Patchfinding
iPhone x 16.3.1

If your version does not have an IPSW, you need to install the Dopamine app with TrollStore for it to work


Sass support in jest test files appear to be broken

Is this a bug report?
Yes

Did you try recovering your dependencies?
Yes

(Write your answer here.)
Which terms did you search for in User Guide?
Sass support

(Write your answer here if relevant.)
Environment

node -v:
npm -v:
yarn --version (if you use Yarn):
npm ls react-scripts (if you haven’t ejected):

Then, specify:

Operating system:
Browser and version (if relevant):

Steps to Reproduce

(Write your steps here:)
1: Update react-scripts to latest release
2: Import styles from 'component.module.scss' in component file
3: Import styles from 'component.module.scss' in component.test.js
Expected Behavior

(Write what you thought would happen.)
Classnames are imported for component file and test file correctly for comparison
see #3815
Actual Behavior

(Write what happened. Please add screenshots!)
Component imports classNames correctly, test file classnames are undefined
Reproducible Demo

(Paste the link to an example project and exact instructions to reproduce the issue.)

This is because we don't have scss preprocessor configured for jest. And I am guessing the same problem will be there when we use .module.css files.
Can I work on this?

I'm going to attempt a PR too :)

This is odd, because we already configured that for CSS Modules (and I believe we even have tests); I wonder why Sass isn't working (or is just not what's expected)?

Ah, it appears we need to add {sass,scss} to these locations:
https://github.com/facebook/create-react-app/blob/789b856b13693f14d89cb9c4622ae7c8f08a6069/packages/react-scripts/scripts/utils/createJestConfig.js#L46-L49
https://github.com/facebook/create-react-app/blob/789b856b13693f14d89cb9c4622ae7c8f08a6069/packages/react-scripts/scripts/utils/createJestConfig.js#L52

I'd be happy to make a PR on this, one question however (I cannot seem to find an answer in the documentation I have searched), How am I supposed to test my change with the cloned repo? I cannot see any way to test the changes with a generated create-react-app. Also if I were able to generate an app using the changes, shall I just have the extra generated files not committed then make a PR? Sorry in advance if these are dumb questions. Fairly new to the contributing thing.

You can test your changes by running yarn create-react-app my-app from the base of your cloned repo. That will create a new app called my-app using your local changes.
You should not commit my-app when submitting a PR. You can create my-app outside of your cloned repo by doing something like this instead: yarn create-react-app ../my-app.

It appears that after modifying createJestConfig.js and generating an app, doing the following:
import styles from test.module.scss
results in:
console.log(styles) // 'test.module.scss'
So it appears to be importing the sass module as a string of the file name. I'm going to continue looking into this, if this pops out to you as something obvious then feel free to let me know. :)

I think I have an idea, going to test it tomorrow as generating the node_modules folder every time for CRA is murdering my mobile internet.

it also appears that importing css modules is not working as expected either.
import styles from './test.module.css';
import sass from './sass.module.scss';

it('should handle css modules', () => {
  console.log(styles) // => {}
})

it('should handle sass modules', () => {
  console.log(styles) // => 'sass.module.scss'
})

Using this configuration:
transformIgnorePatterns: [
      '[/\\\\]node_modules[/\\\\].+\\.(js|jsx|mjs)$',
      '^.+\\.module\\.{css,sass,scss}$',
    ],
    moduleNameMapper: {
      '^react-native$': 'react-native-web',
      '^.+\\.module\\.{css,sass,scss}$': 'identity-obj-proxy',
    },

Accidental close and comment*

I'm unsure how to continue this unfortunately, if anyone has some ideas as to the strange behaviour above, otherwise i'll keep this here to see if anyone else wants to pick this up. :)

it also appears that importing css modules is not working as expected either.
import styles from './test.module.css';
import sass from './sass.module.scss';

it('should handle css modules', () => {
  console.log(styles) // => {}
})

it('should handle sass modules', () => {
  console.log(styles) // => 'sass.module.scss'
})

Using this configuration:
transformIgnorePatterns: [
      '[/\\\\]node_modules[/\\\\].+\\.(js|jsx|mjs)$',
      '^.+\\.module\\.{css,sass,scss}$',
    ],
    moduleNameMapper: {
      '^react-native$': 'react-native-web',
      '^.+\\.module\\.{css,sass,scss}$': 'identity-obj-proxy',
    },

Hello, this is still an issue which basically prevents me from testing conditional class assginment as in:
const Tile = ({ tilePlacement }) => (
  <div className={styles[`tile_${tilePlacement}`] || styles.default} />
)

will, in Jest, never return default but tile_[tilePlacementValue


Where are problems 1-5 ?

Midways in the Introduction page there is a reference to problems 1-5:

Problems
Try problems 1-5 in the Basic Problems.

Not sure which is the Basic Problems page,  there is a Starter Problems page, but it has only four problems, which are not numbered. Also, the Starter Problems page requires the understanding of functions, which are only referenced afterwards in the Introduction.
It might be useful to link from the Introduction page to the actual place where these problems are described.

Fixed in the new notebooks


Directory.EnumerateDirectories ignore case on directory #134

EnumerateDirectories was fixed

Fixing issue #134

Hi @ericnewton76
Test Move_DirectoryExistsWithDifferentCase_DirectorySuccessfullyMoved was changed to be less specific

Will be published to NuGet within a few minutes. Thanks.


unable to overwrite sails.config.paths

Hello there,
I'm not able to overwrite sails.config.paths.
I'm trying to overwrite it on my env config, but moduleloader hook seems to ignore my config.
What could I be doing wrong?
Thanks in advance!
japel

This might be a bug, or just wrong documentation, but:
as opposed to https://github.com/balderdashy/sails/blob/master/lib/hooks/moduleloader/README.md
where it says:
"This hook loads modules from your configured directories in sails.config.paths."
Sails ignores any config changes and always loads default paths.
The only way to overwrite those seems to be to change them in .sailsrc file

post a gist or jsfiddle of your code so we can see what you’re doing.

On Oct 23, 2015, at 3:08 AM, Jan Viktor Apel<EMAIL_ADDRESS>wrote:
Hello there,
I'm not able to overwrite sails.config.paths.
I'm trying to overwrite it on my env config, but moduleloader hook seems to ignore my config.
What could I be doing wrong?
Thanks in advance!
japel
—
Reply to this email directly or view it on GitHub https://github.com/balderdashy/sails/issues/3325.

Issue will be re-opened with OP can provide a complete example.

reopening this with an easy to test repo:
https://github.com/japel/sailsConfigPathsTest
files added:
./config/paths.js
module.exports.paths = {
  "models": "api/my/new/models/path"
};

api/my/new/models/path/User.js
module.exports = {

  attributes: {
    name: 'string',
    age: 'integer',
    active: 'boolean'
  }
};

how to test:

clone
npm install
sails console

console.log(sails.config.paths);

outputs:
{ models: 'X:\\sailsConfigPathsTest\\api\\models',
  tmp: 'X:\\sailsConfigPathsTest\\.tmp',
  config: 'X:\\sailsConfigPathsTest\\config',
  controllers: 'X:\\sailsConfigPathsTest\\api\\controllers',
  policies: 'X:\\sailsConfigPathsTest\\api\\policies',
  services: 'X:\\sailsConfigPathsTest\\api\\services',
  adapters: 'X:\\sailsConfigPathsTest\\api\\adapters',
  hooks: 'X:\\sailsConfigPathsTest\\api\\hooks',
  blueprints: 'X:\\sailsConfigPathsTest\\api\\blueprints',
  responses: 'X:\\sailsConfigPathsTest\\api\\responses',
  views: 'X:\\sailsConfigPathsTest\\views',
  layout: 'X:\\sailsConfigPathsTest\\views\\layout.ejs',
  public: 'X:\\sailsConfigPathsTest\\.tmp\\public' }


Some permissions restore after reboot

Excellent list of permissions, but many rights are re-enabled after a reboot.
Sample - wifi network & mobile network.
Fix please!
<:-((

Yes, really problem, because android iptables will be lost after a reboot, then it became so unreliable, but you can use manually export and restore features.

#21


Num.div by 0 on Dec should crash, but doesn't

To reproduce, in the repl:
» 1/0

<PHONE_NUMBER>000000000 : Frac *

Expected behavior: a crash report on division by zero, like you get for integer divide by zero.
(This can't return something like infinity or NaN because it's a Dec, not a float, and Dec's fixed-point representation is based on integers; it doesn't have an equivalent concept.)

Ill give this a shot

Looks like there is a difference for this on the local vs web repl
If you run the dev repl locally i see
  The rockin' roc repl
────────────────────────

Enter an expression, or :help, or :q to quit.

» 1/0
thread 'main' panicked at 'not yet implemented: NumDiv: layout, Builtin(Decimal)', crates/compiler/gen_dev/src/generic64/mod.rs:1603:18
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

building the site of off main and using the repl there was the original issue mentioned.
I will work on a fix for both cases


Unfriendly names

Seems like some of the names are not friendly -- they're most likely variable names. Here is what it  currently shows:
Select Country >
About
Country: Canada
Cases: 113515
Cases Today: 309
Deaths: 8885
Deaths Today: 4
Recovered: 99111
Active: 5519
Critical: 2221
Per Million: 3006
deathsPerOneMillion: 235
totalTests: 3717483
testsPerOneMillion: 98442
Updated at 14:34
Quit

As you can see: deathsPerOneMillion instead of Deaths Per Million or something. Restarting the app does nothing. Switching back to the US does nothing. :thinking:
PS Great app!

Hey @TheTechRobo, I have created a new release of the mac app that includes changes to those names, and human readable numbers to make reading easier.
@lapisdecor can you please update the linux version as well? (all new changes should be in app.py)

I will do it asap.
A terça, 28/07/2020, 10:40, Duarte OC<EMAIL_ADDRESS>escreveu:

Hey @TheTechRobo https://github.com/TheTechRobo, I have created a new
release https://github.com/duarteocarmo/coronabar/releases/tag/v2.5.0
of the mac app that includes changes to those names, and human readable
numbers to make reading easier.
@lapisdecor https://github.com/lapisdecor can you please update the
linux version as well? (all new changes should be in app.py)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/duarteocarmo/coronabar/issues/7#issuecomment-664926887,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABG53C6LYVRA2RL5Z6UI6QTR52MILANCNFSM4PHSU62A
.

@lapisdecor thanks a lot. Let me know if you have any issues.

In the meantime @lapisdecor  I will leave this issue open. If you don't mind closing it when you have patched things on the linux side I would greatly appreciate it!
Um abraço

Ok. Abraço.
 If you don't mind closing it when you have patched things
on the linux side I would greatly appreciate it!
Um abraço
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/duarteocarmo/coronabar/issues/7#issuecomment-664935958,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABG53C4NYRMYNZD3YUZFFULR52M6BANCNFSM4PHSU62A
.

Hello!

created a new release
I'll test it in a bit :)

Works fine for me! :D
PS Awesome program

Thanks for testing and for the feedback. I’ll leave this open for @lapisdecor to apply the same changes in the linux version!

Thanks for testing and for the feedback. I’ll leave this open for @lapisdecor to apply the same changes in the linux version!

I think I've done before on a previous PR. Please run the Linux version and tell me if everything is ok.

@lapisdecor hey, can you link me to that PR? I have updated some components I think you haven't updated on the linux side of things.

Here for example - I implemented a human readable format of the numbers.
And here I added additional mappings for strings

Let me know if that makes sense!

I think I have only the additional mappings for strings
Let me check.

It's not exactly like your, I think.
I can try to make it uniform on both versions but not right now.

Fair enough!