Procedures can't be updated and created

We found a new issue with Procedures on both versions (dev react and dev angular)
Could you check it please:
http://prntscr.com/iepp3o
http://prntscr.com/ieppjm
But then new Procedure isn't displayed with GET request (it doesn't appear even later, so it is not response issue)
Related issue: https://github.com/PulseTile/PulseTile-React/issues/121

The issue was solved on React by Ian. But for some reason, it doesn't work for all react versions.


Fix failed Pandas tests

Issue #, if available: https://github.com/aws/sagemaker-distribution/issues/110
Description of changes: Fix failed Pandas tests
Latest failures in 2.x images:
FAILED pandas/tests/indexes/object/test_indexing.py::TestSliceLocs::test_slice_locs_negative_step[in_slice13--string[pyarrow_numpy]]
FAILED pandas/tests/plotting/frame/test_frame.py::TestDataFramePlots::test_plot_scatter_shape
FAILED pandas/tests/plotting/test_datetimelike.py::TestTSPlot::test_mpl_nopandas
ERROR pandas/tests/io/test_clipboard.py::TestClipboard::test_round_trip_frame_sep[delims-None-None]
ERROR pandas/tests/io/test_clipboard.py::TestClipboard::test_round_trip_frame_sep[delims-None-\t]
ERROR pandas/tests/io/test_clipboard.py::TestClipboard::test_round_trip_frame_sep[delims-None-,]
ERROR pandas/tests/io/test_clipboard.py::TestClipboard::test_round_trip_frame_sep[delims-None-|]
...
= 3 failed, 200972 passed, 21585 skipped, 7049 deselected, 1971 xfailed, 88 xpassed, 26 warnings, 327 errors

The 3 test failures can be fixed by upgrading from pandas-2.2.2 to pandas-2.2.3. The 327 errors are due to missing of dependency pyqt. Given that this package is not a marquee package in SDM images, we should disable such tests that require this dependency.
After the above changes, all tests passed:
200970 passed, 21732 skipped, 1971 xfailed, 88 xpassed, 26 warnings in 376.44s (0:06:16)

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Note: You can still install pyqt as part of the test dockerfile and run those tests. Our goal is to ensure that all features of Pandas are working correctly (even if it has optional dependencies)


The fill handler border is sometimes not shown

In this case, it doesn't work:
https://github.com/glideapps/glide-data-grid/assets/2852129/055f8329-b815-4db4-a91c-d963a95ad970
In this case, it works:
https://github.com/glideapps/glide-data-grid/assets/2852129/1aea6748-95e2-4ea1-b202-f704f857885b
Maybe it has to do something with it being a single column?

Fixed in main


[RAC] Virtualized GridList jumping around when tab in

Provide a general summary of the issue here
When tab into a virtual GridList, the scroll jumps around even though the GridListItem is in view.
🤔 Expected Behavior?
The scroll position should remain if the focused item is in view.
😯 Current Behavior
The scroll position jumps around. Provided a sandbox, but I also see this happens in the storybooks in closed PRs.
💁 Possible Solution
No response
🔦 Context
No response
🖥 Steps to Reproduce
https://codesandbox.io/p/sandbox/27hddn
Version
1.3.3
What browsers are you seeing the problem on?
Firefox, Chrome, Microsoft Edge
If other, please specify.
No response
What operating system are you using?
Windows 11
🧢 Your Company/Team
No response
🕷 Tracking Issue
No response

Thanks for the issue, I'm able to see the unpredictable scroll into view.
Note for anyone trying to reproduce, make sure to focus an item that requires some scrolling to get to initially. It won't have an issue if you just leave it as the first item.


[Overview] Models differences

I want to know the differences between the Ukbench, photo, RGB, and Y-model and what do you think is the best model in your opinion thanks..

Here is the results of internal benchmark.
TL;DR: For photo, models/photo is best. For artwork, models/anime_style_art_rgb  is best.
dataset
photo_test: 300 various photos.
art_test  : 90 artworks (PNG only).

2x upscaling model

Dataset/Model
anime_style_art(Y)
anime_style_art_rgb
photo
ukbench

photo_test
29.83
29.81
29.89
29.86

art_test
36.02
36.24
34.92
34.85

The evaluation metric is PSNR(Y only), higher is better.
Denosing level 1 model

Dataset/Model
anime_style_art
anime_style_art_rgb
photo

photo_test Quality 80
36.07
36.20
36.01

photo_test Quality 50,45
31.72
32.01
32.31

art_test Quality 80
40.39
42.48
40.35

art_test Quality 50,45
35.45
36.70
36.27

The evaluation metric is PSNR(RGB), higher is better.
Denosing level 2 model

Dataset/Model
anime_style_art
anime_style_art_rgb
photo

photo_test Quality 80
34.03
34.42
36.06

photo_test Quality 50,45
31.95
32.31
32.42

art_test Quality 80
39.20
41.12
40.48

art_test Quality 50,45
36.14
37.78
36.55

The evaluation metric is PSNR(RGB), higher is better.

I am going to release new models/anime_style_art(Y only) model. It might be able to beat the RGB model.

Thanks what does it mean when using photo model? Can I use photo model for upscaling anime (video) screenshots?

Yes.
anime_style_art_rgb is specialized for digital illustration. Anime is made by video recording.
anime_style_art_rgb sometimes makes weird contour line for Anime(includes video frames and screenshots).
source:

anime_style_art_rgb:

photo:

But I think in terms of noise reduction RGB is better than Photo for denoising video frames (anime)

Hi, I'd like to know the differences between vgg_7 and upconv_7 in pre-trained models?

vgg_7 and upconv_7  have different network architectures.
vgg_7: 1. 2x the input image with nearest neighbor upscaler. 2. Repair the image with CNN
upconv_7: 1. end-to-end 2x with CNN (it uses deconvolution layer).
upconv_7 is 2~3x faster than vgg_7, and its upscaling quality is better than vgg_7.
Simply, upconv_7 is the new version, vgg_7 is the older version. But upconv_7 has checkboard artifact  problem. It happens very seldom, though.

Thanks. I've read the  ESPCN paper. Is upconv_7's last layer like that (sub-pixel convolution)?

The purpose is the same, but the algorithm is different.
I tried subpixel convolution before the ESPCN paper was published(github log) but eventually I chose deconvolution.

The purpose is the same, but the algorithm is different. I tried subpixel convolution before the ESPCN paper was published(github log) but eventually I chose deconvolution.

Why did you choose deconvolution eventually? Is there any cases for comparision?


Distance to camera and surface normal at each pixel

 Issue by benjamin-heasly
Friday Nov 07, 2014 at 14:53 GMT
Originally opened as https://github.com/DavidBrainard/RenderToolboxDevelop/issues/14

For each Ward Land rendering, we would like to read out additional facts about the object underneath each pixel:

the surface distance to the camera
the surface normal vector

Mitsuba might have a depth map plugin already.  It also might have documentation about writing plugins for outputting data like depth maps.  We should check.

 Comment by benjamin-heasly
Friday Nov 14, 2014 at 22:26 GMT

The documentation for Mitsuba 0.5 contains a detailed developer documentation that shows how to write a custom integrator which reports the distance to the camera from each visible scene surface.  It also gives thorough explanations of the code.  Nice.
To get surface distances to camera, I think we could implement this integrator almost exactly as documented.  One change we might make would be to output the distance to the camera in raw scene units, instead of normalizing distances into the range [0 1].  Depending of the film type we write to, raw distances might require special encoding for large numbers.
To get the surface normal vector, we might be able to implement a very similar integrator.  But we would need to figure out where the surface normal vector is stored and how to "dig it out" when we need it.  This would require spending some time getting into the Mitsuba code.

 Comment by benjamin-heasly
Friday Dec 05, 2014 at 22:40 GMT

I built a spectral version of Mitsuba 0.5 and played around with the Mitsuba "field integrator".  This integrator actually does a lot of what we want, right out of the box.
One really nice thing about the field integrator is it collects all of our data and factoids in one rendering pass.  For example, it can produce one big multi-channel openexr image which contains "distance-to-camera", "albedo", and the usual 31 spectral slices.
Distance-To-Camera
I was able to make a distance-to-camera image pretty easily by modifying an existing WardLand Mitsuba scene and pulling out one slice by hand.  It would take a bit of thinking and wiring to integrate this into the rest of our Render Toolbox and Virtual Scenes code.
For example, we probably want a nice syntax and automatic scene file generation for this kind of factoid output, which would be new.
Also, we'd need to make sure this kind of output doesn't mess up the processing of regular spectral output.  In the case of the big openexr file, the expected channels are all there, but the names are changed to avoid naming collisions.
Surface Normals
I also tried getting out the object surface normal at each pixel.  But this was not so easy.  I get a disappointing error:
"The field integrator implementation requires renderings to be done in RGB when extracting positional data or surface normals / UV coordinates."
So to get surface normals I think we'd have to do one of two things: either keep two builds of Mitsuba side by side, one RGB and one spectral, or modify Mitsuba to overcome this "implementation requirement" somehow.


Problems with latest Teams VTT

The sample Example.vtt.txt doesn't convert properly. Some angle brackets get left. [N.b. remove .txt extension for testing]

Docx seems to work fine, so please use that instead for now!


Changed project fields

removed scope and milestones
renamed objectives to overall goal
added new helper text to measures
added branch for whether or not we are on vagrant for https

Looks good. I fixed the merge conflicts


Invisibility Cloak using Python

This is a beginner friendly project for
people who want to start working in Computer Vision.
By using OpenCV library, we can create a real time,
invisibility cloak. I have used the values for
masking red color. So we will be using a red colored
cloth. It is a fun project and also great for diving into
concepts of Computer Vision and Image Processing
Description
A short summary of what is included in your Pull Request.
Fixes #(issue_no)
Replace issue_no in the above line, with the issue related to this PR.
Type of change
Choosing one or more options from the following as per the nature of your Pull request.

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Documentation Update

Checklist:
Please tick all the boxes that are fulfilled by your Pull Request.

[x] I have named my files and folder, according to this project's guidelines.
[x] My code follows the style guidelines of this project.
[x] My Pull Request has a descriptive title. (not a vague title like Update index.md)
[x] I have commented on my code, particularly in hard-to-understand areas.
[x] I have created a helpful and easy to understand README.md, according to the given README_TEMPLATE.
[x] I have included a requirements.txt file (if external libraries are required.)
[x] My changes do not produce any warnings.
[x] I have added a working sample/screenshot of the script.

please refer to #282


Feedback: Generating documentation & default configuration

I'm currently working on a new detekt module that will parse the detekt-rules module and gather all RuleSetProviders and their Rules.
The goal in the end is to generate *.md files for documentation of each RuleSet and its rules as well as generating the default-detekt-config.yml automatically.
So far I've gathered the following parameters for the items:
RuleSets:

name
description (for documentation)
List

Rules:

name
description (for documentation)
rationale (for documentation)
configuration options (including their name, description for documentation and default value)

If you can think of more parameters I should consider adding to those entities, feel free to let me know.
The biggest question I'm thinking about right now is: Where to put these parameters. I will comment with 2 comments to this issue for solutions I've come up with. Feel free to leave thoughts or more solutions as well.

Solution 1: KDoc
/**
 * @name example
 * @description This is an example
 * @rules ExampleRule, .., ..
 */
class ExampleProvider : RuleSetProvider {

	override val ruleSetId: String = "example"

	override fun instance(config: Config): RuleSet {
		return RuleSet(ruleSetId, listOf(
				ExampleRule(config),
				..,
				..
		))
	}
}

/**
 * @name ExampleRule
 * @description Super cool description
 * @rationale Explanation as to why this rule exists, examples, ways to solve it, links to benchmarks, discussions, etc.
 * @configuration `excludeSomething` - Explanation of the config option (default: `something`)
 * @configuration ...
 * @configuration ...
 */
class ExampleRule(config: Config = Config.empty) : Rule(config) {
   ...
}

This gives each RuleSet and Rule some great KDoc documentation already and we can parse that from the documentation generation script.
However it requires us to keep the KDoc always exactly up-to-date with the code. Especially looking at configuration options I fear that we might get out of date KDoc very quickly.

Solution 2: Code
class ExampleProvider : RuleSetProvider {

	override val ruleSetId: String = "example"

  override val description: String = "This is an example"

	override fun instance(config: Config): RuleSet {
		return RuleSet(ruleSetId, listOf(
				ExampleRule(config), // Parsing list of rules from here
				..,
				..
		))
	}
}

class ExampleRule(config: Config = Config.empty) : Rule(config) {
    override val issue = Issue("ruleName we can parse",
    			Severity.Defect,
        "rule description we can parse.")

    override val rationale: String = "Rationale for the rule, maybe also in Issue?"

    override val configurationOptions: List<ConfigurationOption> = listOf(...)
}

This option requires some work to get all Rule classes updated to contain the necessary properties so that we can parse all configuration options correctly. But it ensures that the generated documentation/default config can never become out of sync with the code itself.

Fantastic job so far! I really like the idea of generation documentation automatically.
Regarding the first comment I think the rule description belongs into the comment above the respective class.
Regarding the documentation of the options I think that detekt should implement a check at build time which checks if all config options have a comment.
I don't like the idea of having a List<ConfigurationOption> in the second comment.

Another thing I realized just now: If we want to generate the default-detekt-config.yml we need some way to mark a rule as active/inactive. Maybe with a @since v1.0.0-RC5 annotation and then we can automatically decide that new rules are turned off by default, but older rules might be enabled automatically.

@Mauin
Yes. You will also need one for the default value of the config options.

Great job!
My suggestions:
@name can be extracted from the class name
@description could be just the Kdoc without a tag ->
/**
 * Super cool description
 *
 * @rationale Explanation as to why this rule exists, examples, ways to solve it, links to benchmarks, discussions, etc.
 * @configuration `excludeSomething` - Explanation of the config option (default: `something`)
 * @configuration ...
 * @configuration ...
 */
class ExampleRule(config: Config = Config.empty) : Rule(config) {
   ...
}

With tags it will be easiest to directly address those parts of the KDoc. Otherwise we can't distinct the description from actual code documentation that might be in the KDoc.
With the KDoc approach I'm just a bit scared that we'd have rules that don't match the correct formatting and even worse: That the configuration documentation gets outdated, we generate a faulty default config and don't realize it until after we released something.

@Mauin Detekt has a test which checks the config option. I've recently committed this.

For the default values we could introduce a convention that all property names and their default values must be in an companian object, which can clash with other constants because of DRY ...
For the active rules, I do not have a solution now. A predefined lookup table?

@arturbosch maybe with an annotation @active

Thanks for all the feedback. I'll close this issue for now and will try to finish the prototype with the KDoc approach this week.


repeating the answer to the older questions in the chat

Description
verba keeps responding to older messages in the chat, ignoring newer ones
Is this a bug or a feature?

[x] Bug
[ ] Feature

Steps to Reproduce
start a chat, ask one question, then move to the next question
Additional context

ollamaembeder
On Thu, 23 May 2024 at 14:07, Edward @.***> wrote:

What model are you using for conversation?
—
Reply to this email directly, view it on GitHub
https://github.com/weaviate/Verba/issues/193#issuecomment-2127062658,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AIMPOFEFUO4UAFVGKA2ONU3ZDXSXLAVCNFSM6AAAAABIFOOLSCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMRXGA3DENRVHA
.
You are receiving this because you authored the thread.Message ID:
@.***>

What specific Ollama Model are you using? Might be that the issue is related to the model you're using

llama 3
On Mon, 27 May 2024 at 12:24, Edward @.***> wrote:

What specific Ollama Model are you using? Might be that the issue is
related to the model you're using
—
Reply to this email directly, view it on GitHub
https://github.com/weaviate/Verba/issues/193#issuecomment-2133267963,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AIMPOFH5CKYLI67TXCIFU7DZEMJVFAVCNFSM6AAAAABIFOOLSCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMZTGI3DOOJWGM
.
You are receiving this because you authored the thread.Message ID:
@.***>

Have you tried other models as well?

This is happening to me as well. Using Ollama and OllamaImbedder. Once I turned off chat caching it seems to have stopped.

Should be fixed in the latest release! 😄


Handle exceptions when auto-aligning start time

It is currently possible to set values for the attachment range that are valid length-percentage values, but that are not supported in the polyfill yet.
This will cause en error to be thrown when we try to auto-align the start time, preventing tickAnimation from completing as expected.
We should probably add a stricter validation when setting the range, but for now I think we should catch the exception and fall back to using the full animation range.
Merging this PR should prevent the timeouts that occurred in the WPT subtests in #153

It is currently possible to set values for the attachment range that are valid length-percentage values, but that are not supported in the polyfill yet.

What are some examples of these values?

Merging this PR should prevent the timeouts that occurred in the WPT subtests in https://github.com/flackr/scroll-timeline/pull/153

Perfect!

What are some examples of these values?

Currently we don’t support relative units such as em or vh as we can not resolve them. They will parse fine as length-percentage values, but will not resolve to px values, yet.

Currently we don’t support relative units such as em or vh as we can not resolve them. They will parse fine as length-percentage values, but will not resolve to px values, yet.

Maybe we should add a console.warn() to notify the developer about this. This would be helpful to help them debug, thereby reducing frustration along the way.

Maybe we should add a console.warn() to notify the developer about this. This would be helpful to help them debug, thereby reducing frustration along the way.

Maybe 🤔
I considered this, but this procedure can be run quite often and it would spam the logs. Maybe if we add a flag per timeline and only issue the warning once? 🤔

I considered this, but this procedure can be run quite often and it would spam the logs.

Hmm, good call. Spamming the console with message is infeasible indeed.

Maybe if we add a flag per timeline and only issue the warning once?

Another way to bypass this could be to error out entirely for that specific Scroll-Timeline: instead of adding an animation with the default (wrong) timeline offset, remove the scroll-animation altogether.

Another way to bypass this could be to error out entirely for that specific Scroll-Timeline: instead of adding an animation with the default (wrong) timeline offset, remove the scroll-animation altogether.

Hmmm.. I think we can leave the timeline active, as the range is set and calculated for the animation and not the timeline. The timeline might be used for multiple animations, and we should leave the others playing.
I think we can either

cancel the current animation after a console.warn()
reset the animation range start/end to the default "normal" after a console.warn(), leaving the animation playing.

I'm not sure which would be the best, but I'm slightly leaning towards the latter.
It could look something like this:

  try {
    startOffset = CSS.percent(fractionalStartDelay(details) * 100);
  } catch (e) {
    // TODO: Validate supported values for range start, to avoid exceptions when resolving the values.

    // Range start is invalid, falling back to default value
    startOffset = CSS.percent(0);
    details.animationRange.start = 'normal';
    console.warn("Exception when calculating start offset", e);
  }

It would be better to validate the range when it's set. It might be hard to detect whether a CSSNumericValue contains unsupported units, but we might be able to leverage  CSSNumericValue toSum() to check which units are used. This is something we should solve in a separate PR though.

@bramus I implemented the change I suggested in the comment above.


aws-config (0.56) depends on tokio+mio - breaks on WASM

mio is not wasm-compatible, which is a dep of tokio.
In the latest version of aws-config (0.56) I believe there was a change, specifically around tls, which started to bring this in.
Here's whats in my toml:
aws-config = { version = "0.56", default-features = false, features = [
  "rustls",
] }

Here's my cargo tree:
├── aws-config v0.56.0
│   ├── aws-credential-types v0.56.0
│   │   ├── aws-smithy-async v0.56.0
│   │   │   ├── futures-util v0.3.28 (*)
│   │   │   ├── pin-project-lite v0.2.12
│   │   │   ├── tokio v1.31.0
│   │   │   │   ├── bytes v1.4.0 (*)
│   │   │   │   ├── libc v0.2.147
│   │   │   │   ├── mio v0.8.8
│   │   │   │   │   └── libc v0.2.147
│   │   │   │   ├── num_cpus v1.16.0
│   │   │   │   │   └── libc v0.2.147

If you try to run a wasm-pack test you'll get this exact heap of errors:
https://github.com/seanmonstar/reqwest/issues/1300

I opened this issue in aws-sdk-rust instead.


Bulk PRs for CI

#13187
#13185
#13182
#13180
#13173
#13160
#13147
#13121
#13071

Dependency Tree Analyzer Output:
New Dependencies:

xml-resolver:xml-resolver:jar:1.2:compile

CC @wildfly/prod


stuff that gives worse bounds than it could because the alternatives seem complicated

the context that gets added when a choice is applied is the sum of all choice entry's contexts, not only the context of the choice that actually gets picked. that's because keeping track of which contexts to include is very complicated especially with higher order things. potential reliefs are putting a sensitivity annotation on all types (yuck!) and doing dual-pass typechecking where first julia types are determined to resolve choices and then duet typechecking is used for sensitivity analysis.
we did not find a way of expressing tuples that contain privacy terms and can be used with a "tuple bind"/privacy TLet term. this means as of now if something is in a tuple it has to come from return and hence have infinite privacy.

In the current approach of #22 we cannot solve this issue.

The first statement of OP is still true.


Can't force-quit or command-tab Electron app in kiosk mode if run via AppleScript

I have an Electron app (client-side JavaScript only, no nodejs)  where I set mainWindow this way:
mainWindow = new BrowserWindow({width: 800, height: 600, kiosk: true});
I've been executing by putting the app folder in Electron.app/Contents/Resources/ and double-clicking Electron and it always works fine.
However, oddly enough, if I execute the application via an AppleScript that I have:
tell application "Electron" run
the app runs, but I can't get out of it or regain control of my Mac. I can't force-quit by trying command-option-escape, or bring up the menu bar by moving the mouse to the top of the screen, or use command-tab to tab through the list of applications. The only thing I'm able to do is press the power button to bring up the restart/shutdown/sleep menu and try and restart, and there, restart is cancelled by Electron.
Electron: v0.28.2-darwin-x64
Mac OS: v10.9.5

The kiosk mode of Electron disables menu and keyboard shortcuts for quitting, you should provide a way to quit in your app.

Given that it is a kiosk application (used by customers in a showroom), I can't provide a method on the screen for it to quit, or else customers will have the ability to stop the kiosk from running.

You can add a secret shortcut or some password for quitting, I think a real kiosk application should not be able to quit without the ways provided by the developers?

Well, we can agree to disagree. I build these touchscreen kiosk applications in many retail scenarios, and in almost every case, customers (and often kids) tap around on touchscreens looking for ways to mess up the application or in rare occasions, hack it somehow. So we typically do not afford away to quit a kiosk anywhere in the interface itself. Keyboards, mice and other input devices are not available to the customers in the touchscreen scenarios, only to us as the developers. So we quit the applications when necessary by force-quit via the keyboard, or in remote access/screen sharing.
At any rate, I found the workaround for me was to simply use fullscreen: true instead of kiosk: true, and that is fine for my purposes. Thanks for your response.


For a 0.4.3 release

#64 #39

Codecov Report

Merging #65 (dc37547) into master (226d02f) will decrease coverage by 0.75%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master      #65      +/-   ##
==========================================
- Coverage   98.73%   97.98%   -0.76%
==========================================
  Files           7        7
  Lines         237      248      +11
==========================================
+ Hits          234      243       +9
- Misses          3        5       +2

Impacted Files
Coverage Δ

src/coerce.jl
98.07% <100.00%> (+0.40%)
:arrow_up:

src/convention/coerce.jl
97.40% <100.00%> (-1.27%)
:arrow_down:

src/schema.jl
97.05% <0.00%> (-2.95%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 226d02f...dc37547. Read the comment docs.


mopidy: Create a mopidyPackages set

Motivation for this change
Currently installing Mopidy plugin packages is using inconsistent python versions.
This may work just by chance in some cases but certainly not all.
This PR ensures a consistent python package is used across all Mopidy plugins.
Note: I'm not a Mopidy user myself so it would be great if someone who is can test these changes. I'm merely acting on an issue reported in IRC in #nixos.
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[ ] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[ ] Fits CONTRIBUTING.md.

cc @fpletz @jgillich @rvolosatovs @spwhitt @jluttine

Interesting, I was doing the same for octoprint. Let's sync the approaches.

I think creating a new scope with plugins is better than extending the Python packages set with plugins (like I did for octoprint). What is still needed however is a way to create a composition (mypackage.withPlugins).

Thanks for the pull request! I cherry picked these two commits. This fixed the original issue I was complaining about in IRC (incompatible Python versions) but now I'm getting the following failure:
FAILED (errors=14)
Test failed: <unittest.runner.TextTestResult run=14 errors=14 failures=0>
error: Test failed: <unittest.runner.TextTestResult run=14 errors=14 failures=0>
builder for '/nix/store/99gc95ysrwygjl3n422dp9mwy22bna8l-mopidy-local-sqlite-1.0.0.drv' failed with exit code 1
cannot build derivation '/nix/store/y9yzbaa8sjgk32s7qx7skk3wbn16kybl-mopidy-with-extensions-3.0.1.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/vyjfglydhsf1av6azrk6is9385i7xfhr-unit-mopidy-scan.service.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/sqdh210j5647zxfl8r8g5qnp9ifj9gmb-unit-mopidy.service.drv': 1 dependencies couldn't be built

To reproduce:
nix-build '<nixpkgs>' -A mopidy-local-sqlite

For reference/completeness, here's my mopidy config:
  config = let
    dataDir = config.services.mopidy.dataDir;
  in {

    services.mopidy = {
      enable = true;
      configuration = ''
      [mpd]
      hostname = <IP_ADDRESS>
      [local]
      enabled = true
      library = sqlite
      media_dir = ${dataDir}/library
      scan_timeout = 1000
      scan_flush_threshold = 100
      scan_follow_symlinks = false
      excluded_file_extensions =
        .directory
        .html
        .jpeg
        .jpg
        .log
        .nfo
        .png
        .txt
      '';
      extensionPackages = [
        pkgs.mopidy-local-sqlite
      ];
    };

    # The default doesn't set permissions correctly
    systemd.services.mopidy.preStart = "mkdir -p ${dataDir} && chown -R mopidy:mopidy  ${dataDir} && chmod -R o-rwx ${dataDir}";

    networking.firewall.allowedTCPPorts = [
      6600 # MPD server
    ];
  }

as @gebner pointed out, the package set needs to be updated. I intend to merge this PR soon and leave it to the users (such as yourself) to update the plugins.

@jluttine The mopdy-local-* plugins have been deprecated upstream and rolled into a new plugin called https://github.com/mopidy/mopidy-local.
It would be much better if someone who is actually using these plugins update them than if I do it since I don't know what to test.

@FRidh Ok, so I shall not update those plugins now. I'll wait until this PR is merged and then open separate PRs for them. Is that what you meant?

@adisbladis I tested Mopidy quickly with a minimal setup and it seems to work, thanks!
Just for reference, here's my config:
    config.services.mopidy = let
      dataDir = config.services.mopidy.dataDir;
    in {
      enable = true;
      configuration = ''
      [mpd]
      hostname = <IP_ADDRESS>
      [audio]
      output = pulsesink server=<IP_ADDRESS>
      '';
      extensionPackages = [
        pkgs.mopidy-iris
      ];
    };

    # Allow Mopidy to play sound via Pulseaudio that might be running under some
    # other user.
    hardware.pulseaudio.extraConfig = ''
      load-module module-native-protocol-tcp auth-ip-acl=<IP_ADDRESS>
    '';

    # The default doesn't set permissions correctly
    systemd.services.mopidy.preStart = "mkdir -p ${dataDir} && chown -R mopidy:mopidy  ${dataDir} && chmod -R o-rwx ${dataDir}";

I could then try to look into the extensions once this PR is merged.


Added some locations

Please review our Contribution Guidelines to ensure your changes abides by it.
Changes should be made to the end of the file.
Review your changes and complete the checklist below.

[ ] Company name
[ ] Industry
[x] Company location
[ ] Company description
[ ] How Elixir is used
[ ] GitHub / blog links
[ ] Job listings

Thank you @matthiaz!


Envoy gateway runs oom

Description:

The following is an envoy gateway flame diagram. Whether DeepCopy has problems?

Repro steps:

After the EG runs for a period of time, the oom will appear

Environment:

the latest version

may be releated to https://github.com/envoyproxy/gateway/issues/3698

hey @hemenghong how many relevant resources (xRoutes, Gateway and related Secrets, Services etc) have been  applied ?
the default limits value is 1G, please consider increasing it in the helm chart

hey @hemenghong how many relevant resources (xRoutes, Gateway and related Secrets, Services etc) have been applied ? the default limits value is 1G, please consider increasing it in the helm chart

eg limit mem has been set to 2G.
httproute has 90 and node has 100 and secret has 900 and service has 270 and endpointslice has 270.

closing this issue in favor of https://github.com/envoyproxy/gateway/issues/3860


Fixes issue #538 (create-report button design)

Please give suggestions!

@mariobehling @Orbiter @aneeshd16


chore(node-sdk): use warn log level when enabled plugin arent installed

Fixes #1124

Closing because @obecny will refactor the plugin loader and it will not be a problem (ref https://github.com/open-telemetry/opentelemetry-js/issues/1124#issuecomment-692224338)


Merge with other the omniauth strategy

Hey @podman! CTO of Drip here, glad to see you folks integrating with us! As chance would have it, @j-mcnally created an Omniauth strategy for Drip the same day as you. When we went to rename his gem from omniauth-getdrip to omniauth-drip, we discovered your gem: waitlisted/omniauth-drip#1
I'd like to link out to an Omniauth strategy from our official API docs, and ideally there would be one official source for this. Would you be willing to merge efforts with @j-mcnally?
I'd be happy to place the official source under the DripEmail organization, credit both of you for your work there, and help maintain it.

Hi, @djreimer! I'm happy to do whatever is easiest. I can transfer ownership to DripEmail and then you guys can do whatever you'd like. Is that the ideal outcome as you see it?

I'd say we can merge efforts from a code perspective you actually have
tests so id be in favor of using yours as a base.
On Wednesday, July 22, 2015, Adam Podolnick<EMAIL_ADDRESS>wrote:

Hi, @djreimer https://github.com/djreimer! I'm happy to do whatever is
easiest. I can transfer ownership to DripEmail and then you guys can do
whatever you'd like. Is that the ideal outcome as you see it?
—
Reply to this email directly or view it on GitHub
https://github.com/SproutVideo/omniauth-drip/issues/1#issuecomment-123794177
.

--
http://www.kohactive.com
Justin McNally
Technology Director / Principal
p:<PHONE_NUMBER> <+13122733074> | e<EMAIL_ADDRESS>| skype:
justinmcnally211 http://is.gd/UuXAGG
https://github.com/j-mcnally https://twitter.com/j_mcnally
https://www.linkedin.com/profile/view?id=143776726

Great! @podman that would we probably be the easiest way to go. Also, could you add me as a gem owner on Rubygems? Email address is derrickreimer at gmail.

@djreimer OK, you're now added as an owner for the gem. I'm about to transfer ownership of the repository to DripEmail.

@djreimer I got the following error when trying to transfer the repository: You don’t have admin rights to DripEmail.
I guess I can transfer it directly to you first and then you can transfer it to the organization?

@podman interesting, yeah that should work

@djreimer Looks like this is all set now. Let me know if I can do anything else to help.

Merged and tested.  Prepping a 0.0.2 release.


ci: getting go version from go.mod

The actions/setup-go action can extract the go version from go.mod. This will ensure consistency of the go version.

@jonapich My inattention! Fixed


Song: Rewrite song function

Rewrite song function to check process list once instead of multiple times. This speeds up the entire function.
Testing:

[ ] mpd
[x] cmus
[x] mocp
[ ] Spotify
[ ] Google Play Desktop
[ ] iTunes.app
[x] rhythmbox
[x] banshee
[x] amarok
[x] deadbeef
[x] audacious

I would appreciate it if you guys could test out the remaining players, I don't have them installed and some of them don't run on Linux.
Thanks

Not working for iTunes or Google Play Music Desktop Player, the output of the two awk command on my mac and linux computer are:
iTunes (macOS): /Applications/iTunes.app/Contents/MacOS/iTunes  (space at end)
GPMDP (macOS): /Applications/Google Play
GPMDP (Arch Linux, installed from AUR): /usr/share/gpmdp/Google Play

It looks like I'm assuming there won't be a path in the field, should be an easy fix.

Try now.

GPMDP is working fine on both computers now, iTunes still isn't working. It looks like the new case statement is making it iTunes instead of iTunes.app. Removing the .app portion makes it work fine.

Ah alright

Fixed.

Oops I forgot to specify that the change should be on line 1173 and not 1124

Lol, np

Fixed.

All working perfectly here 👍

Thanks!


app name and path defaults to current directory if not defined

fixes #183 #233 #56, potentially #320

I think this will confuse if we are using this in different environment.
For example when different using deploying the app.
So, what we do can do it this.
When we do mup init, let's do this an fill the config file.
Default, appUrl can be ./ or we can detect the root of the app.

Yeah, it's up to you. It could work with #337 to handle the case of different deployments.
This doesn't affect the init yet. It could have the same effect as a default ./. But really this just makes the fields optional. It's backwards compatible and the fields can remain in the intial mup.json.


Problem with tony2001/pinba docker container

Hi all,
I tried to connect pinboard with pinba docker container tony2001/pinba and got following error:
[PDOException]                                                                                SQLSTATE[HY000]: General error: 1005 Can't create table 'doctrine_migration_versions' (errno: 13)
Seems to pinba database is read only.
I changed db.name to test and migrations were ran successfully.
Does pinba db really should be read only or there some misconfiguration on my side?

Hi all,
I had the same issue here.
[PDOException] SQLSTATE[HY000]: General error: 1005 Can't create table 'doctrine_migration_versions' (errno: 13)
I believe the pinba database is read only.
But I don't know why!
Maybe this database files was binary incompatible with MySQL version at docker.
To solved this, I removed the pinba database (SQL: drop pinba) at mysql docker and run the default_tables.sql to re-create the pinba database.


Add non-variadic version of _d_arraycatnT

Much much cleaner than the varargs version, which now forwards to the non-varargs version until the compiler has been updated by https://github.com/D-Programming-Language/dmd/pull/4305

Thx

Thankyou.  The best part about this PR is how it results in less code despite adding a new function.


Add Snyk.io as a package checker

Adds Snyk as an alternative package vulnerability database.
Will check each package individually.
User registration and a paid subscription is currently required

@lirantal @snyksec this API implementation is complete.
Is there any way to make test "api/v1/test" API endpoint available to other user tiers? The current model seems out-of-reach for most developers.

@tonybaloney we're working out on APIs to be available for freemium users, so users would just need to register so they can get an API token and use that. In the meanwhile, one workaround you can do is use the Snyk CLI by bundling it with the plugin and then once users go through the authentication process there's nothing extra needed (no API either). Do you think this could work as a temporary solution?


Switches to using webcrypto everywhere.

globalThis.crypto is available in all major browsers, deno, and NodeJS 19+. It is also available behind experimental flag in NodeJS 16-18, and exists at import {webcrypto} from 'node:crypto'.
Updated tests to polyfill webcrypto so they can run in NodeJS 16+ without experimental flags.
Bumped @types/node to v18 so it has the latest subtlecrypto definitions.

The tests run properly for me.

Removed the changes to tests, they are working for me now and run fast.  🤷

Updated with failing tests.  Current branch results in a timeout for me.  If I increase the timeout from default 5 seconds to 20 seconds the tests pass:

√ should handle RFC 6979 vectors (12213 ms)

3401ms for the RFC test on my machine, compared to 3406ms in the main branch.

3 notes

fails on node 19, so need to at least do if (!globalThis.crypto)
will prob fail in web workers, which have self instead of globalThis
main branch tests took 12 seconds in CI, and did not fail - not sure why it timeouts now

Hmm, it seems the test takes about as long for me on 1.7.1 as it does on this branch, but it only times out on this branch and doesn't timeout on 1.7.1.  Tests should timeout after 5 seconds according to jest defaults, so this test should timeout on both branches and in CI, but for some reason it doesn't.
Hypothesis
Perhaps a switch from sync to async when moving to webcrypto results in jest correctly timing out where previously it would not have timed out?  It is possible that jest can only trigger a timeout when it gets an opportunity to execute, and if everything is sync then jest will not get an opportunity to execute the timeout until after the test has passed.
Supporting evidence for this hypothesis, this test doesn't timeout:
it('timeout', () => {
  const startTime = Date.now()
  while (Date.now() < startTime + 6000) {}
})

Recommendation
Either split the test into individual tests or increase the timeout to ~20 seconds so it can pass on a variety of hardware (including CI).
Data
This Branch:
Benchmarking
Initialized: 51ms
RAM: rss=45.0mb heap=11.4mb used=7.4mb ext=0.5mb

getPublicKey(utils.randomPrivateKey()) x 1,717 ops/sec @ 582μs/op ± 1.48% (min: 409μs, max: 2ms)
sign x 1,099 ops/sec @ 909μs/op
signSync (@noble/hashes) x 1,586 ops/sec @ 630μs/op
verify x 315 ops/sec @ 3ms/op
recoverPublicKey x 311 ops/sec @ 3ms/op
getSharedSecret aka ecdh x 196 ops/sec @ 5ms/op
getSharedSecret (precomputed) x 2,229 ops/sec @ 448μs/op
Point.fromHex (decompression) x 4,484 ops/sec @ 223μs/op
schnorr.sign x 238 ops/sec @ 4ms/op
schnorr.verify x 348 ops/sec @ 2ms/op

RAM: rss=62.3mb heap=27.3mb used=9.8mb ext=0.5mb

√ should handle RFC 6979 vectors (12016 ms)

1.7.1:
getPublicKey(utils.randomPrivateKey()) x 1,536 ops/sec @ 650μs/op ± 1.70% (min: 412μs, max: 2ms)
sign x 1,384 ops/sec @ 722μs/op ± 1.05% (min: 569μs, max: 2ms)
signSync (@noble/hashes) x 1,515 ops/sec @ 659μs/op
verify x 315 ops/sec @ 3ms/op
recoverPublicKey x 307 ops/sec @ 3ms/op
getSharedSecret aka ecdh x 195 ops/sec @ 5ms/op
getSharedSecret (precomputed) x 1,889 ops/sec @ 529μs/op ± 1.43% (min: 428μs, max: 1ms)
Point.fromHex (decompression) x 4,088 ops/sec @ 244μs/op ± 1.22% (min: 203μs, max: 1ms)
schnorr.sign x 193 ops/sec @ 5ms/op ± 4.38% (min: 3ms, max: 13ms)
schnorr.verify x 273 ops/sec @ 3ms/op ± 3.80% (min: 2ms, max: 12ms)

RAM: rss=62.5mb heap=28.4mb used=12.2mb ext=0.5mb

√ should handle RFC 6979 vectors (11816 ms)

Either split the test into individual tests

Jest is a mess and it should be replaced with micro-should, which supports ESM correctly, doesn't use dependencies, and is just a few hundred LOC.
noble-curves already executed the switch. The amount of test vectors has been increased massively.
If you care about supply chain security, not using jest is as important as not using rollup/etc.
Increasing timeout sounds fine.

fails on node 19, so need to at least do if (!globalThis.crypto)
will prob fail in web workers, which have self instead of globalThis
main branch tests took 12 seconds in CI, and did not fail - not sure why it timeouts now

Fixed (1) with globalThis.crypto || (globalThis.crypot = webcrypto) in the tests and benchmark.
For (2) I believe workers have globalThis.  The whole point of globalThis was to specifically resolve the problem of global vs window vs self being differently available in various environments.  globalThis should be available in all JS execution environments.
See above post about (3).

I believe workers have globalThis

Nope.

Hmm, i'm mistaken: seems like workers have it...

If you care about supply chain security, not using jest is as important as not using rollup/etc.

Yeah, I 💯% agree on this.  I have plans to slowly migrate my projects to this over time (at least new projects will use it).

Increasing timeout sounds fine.

Pushed update with 20 second timeout.

As of today Bun exposes WebCrypto for both globalThis.crypto and require("crypto") / import from "node:crypto".
(I just filed the bug earlier and it was fixed immediately, so now this works with that too :) )

We won't break backwards compatibility in v1.0. For v2.0 which is in a pr now, that seems like a good option. However the pr switched to "require" so not sure if it's still needed.
Not having any stable node.js version supporting it is a big one.

=> gh-92


show_src_lines parameter is not used in list(ing)

Hello debug team
I am checking your new gem which I like very much. I didn't know how to categorize the question so I am posting it as open one
Currently I have set config in .rc file for show_src_lines to be 20
and somehow I was expecting(intuition) that when I try to list (with 'l')
that i will see result of 20 rows not the default **10
as it looks it really show the parametrized rows on a breakpoint
but can this be made to work for listing or to add another config parameter for listing too as I find it useful from my point of view

**

yeah I also think show_src_lines should be applied on the list command. wdyt? @ko1


fix commands that break argument.

When argument is leading number like '123.txt', 'Vxxx' commands break the filenames.
See issue #47

Okay, so I like this feature and want to keep it, although you wouldn't know that by looking because it's apparently broken. Easy to fix, though.
As for the issue at and, it looks like it can be fixed without dropping the feature by using -range=1 instead. Right? I've pushed it up if you want to check for further issues with it.


[Event Request] Codeunit 80 Sales-Post - procedure PostUpdateOrderLine - OnPostUpdateOrderLineOnBeforeGetQuantityShipped

Please add an Event OnPostUpdateOrderLineOnBeforeGetQuantityShipped in procedure PostUpdateOrderLine in Codeunit 80 Sales-Post
[Event Request] Codeunit 80 - Sales-Post - procedure PostUpdateOrderLine
    var
        TempSalesLine: Record "Sales Line" temporary;
        SetDefaultQtyBlank: Boolean;
        IsHandled: Boolean;
    begin
        OnBeforePostUpdateOrderLine(SalesHeader, TempSalesLineGlobal, SuppressCommit, SalesSetup);

        ResetTempLines(TempSalesLine);
        with TempSalesLine do begin
            SetRange("Prepayment Line", false);
            SetFilter(Quantity, '<>0');
            if FindSet() then
                repeat
                    OnPostUpdateOrderLineOnBeforeInitTempSalesLineQuantities(SalesHeader, TempSalesLine);
                    if SalesHeader.Ship then begin

                        IsHandled := false;
                        OnPostUpdateOrderLineOnBeforeGetQuantityShipped(TempSalesLine, IsHandled); // <-- NEW EVENT
                        if not IsHandled then begin

                            "Quantity Shipped" += "Qty. to Ship";
                            "Qty. Shipped (Base)" += "Qty. to Ship (Base)";
                        end;
                    end;
            ...

[IntegrationEvent(false, false)]
local procedure OnPostUpdateOrderLineOnBeforeGetQuantityShipped(TempSalesLine: Record "Sales Line"; var IsHandled: Boolean)
begin
end;

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. Please do not reply to this, as we do not monitor closed issues. If you have follow-up questions or requests, please create a new issue where you reference this one.
Build ID: 45169.


[feature] CUE support

Is your feature request related to a problem? Please describe.
From https://github.com/moonrepo/moon/pull/1598 and https://github.com/moonrepo/moon/issues/1569#issuecomment-2245765700 I see that you're planning on migrating the config files from yaml to pkl. We've been using CUE as our source-of-truth configuration format in our monorepo, for moon.yml, package.json, etc. Have you considered CUE before settling on pkl? Is supporting both an option?
Describe the solution you'd like
Using CUE directly to configure moon. I think that it has a strong set of core abstractions behind it, in particular https://cuelang.org/docs/concept/the-logic-of-cue/
Describe alternatives you've considered
I haven't yet looked into pkl deeply, and currently we have a manual build step, but the fact that we generate the moon files themselves does cause some paper cuts with things like caching and package installation

See also: Pulumi supports CUE, and essentially anything that compiles to yaml, via a compile field that lets you specify how to generate the yaml
https://www.pulumi.com/blog/extending-pulumi-languages-with-yaml-cue-jsonnet-rust/

I haven't used cue really but the main reasons I'm looking forward to Pkl is:

It is owned by a large company. Apple in this case.
It is backed by a schema (kind of like JSON schema).
It is programmable. Each data type has methods to mutate/operate with.
The base config file isn't something like YAML or JSON, it's Pkl.
I just like the syntax. It's kind of a mix of TOML, Terraform, and Gradle.

I don't really plan to support more than 1 config format, so if Pkl is a success, YAML will be removed entirely in v2.

@iyefrat I have no idea what pulumi is or what it does, but after a brief glance, I don't see how this would work for moon? moon isn't infrastructure, and a lot of pulumi's APIs are infra centric.
It also seems like a maintenance burden on me (when something breaks) if users are configuring things in whatever format they want. Most support requests are based around config issues.

Oh sorry i think i was vague with my wording - I meant the approach linked here https://github.com/moonrepo/moon/issues/1599#issuecomment-2266932875, where you support yaml but let users specify how they want to compile to yaml (via pkl for example), and delegate features like inheritance to the compilation step.
on the moon level you only support the yaml, anything inheritance based is out of scope and delegated to pkl/cue/whatever support.
The main reason I'm concerned about this change is that we use cue to in our monorepo to solve the same class of problems you want to solve here: to define variables, allow shared logic across workspace, not have to reinvent inheritance logic, etc. The issue is that if moon moves to only supporting pkl, we're essentially forced to migrate away from moon, or migrate the monorepo from cue to pkl, and we don't want to be forced in to either of those moves for that reason.

where you support yaml but let users specify how they want to compile to yaml (via pkl for example)

Pkl wouldn't be used to compile to YAML, it would just be Pkl itself. I'm looking for a new configuration format that is stand-alone, and doesn't have a compilation step or intermediary format, but has far more functionality than static formats (JSON, YAML). Something like Starlark is too much, so Pkl feels like a good choice at the moment. I'm not 100% sold on it though, it's still experimental.

The main reason I'm concerned about this change is that we use cue to in our monorepo to solve the same class of problems you want to solve here: to define variables, allow shared logic across workspace, not have to reinvent inheritance logic, etc.

It looks like CUE doesn't even support Rust, so that means it's immediately off the table.

@milesj I am trying to find a feature or discussion on the topic of pkl/configuration language, where you can share your thoughts on this topic and get feedback on the experimental pkl feature. I can see a lot of potential in using Pkl, but for our users, it is "yet another language" to learn. The starlark language looks more attractive to use, because of the familiar syntax to Python developers (and we have a number of things already that are python based). So, it would be interesting to have a place where we can see your reasoning behind statements like "starlark is too much".


[Feature-13331][Remote Logging] Add support for writing task logs to OSS

Purpose of the pull request

close: #13331
A sub-task of #13017

Add support for writing task logs to OSS
Brief change log

Task log writing

master / worker will send the task log to the remote storage asynchronously after the task is finished if remote.logging.enable=true (By default it's false)

Task log reading

master / worker will first read the task log if the log file exists on the local file system
if the task log file does not exist, master / worker will download the task log file from the remote storage to the local file system and then read the task log file

Log retention

Log retention can be directly configured using the retention policy provided by the remote storage
E.g., log retention on OSS

Verify this pull request
manually tested

Configure related variables in common.properties

# Whether to enable remote logging
remote.logging.enable=true
# if remote.logging.enable = true, set the target of remote logging
remote.logging.target=OSS
# log base directory
remote.logging.base.dir=logs
# oss access key id, required if you set remote.logging.target=OSS
remote.logging.oss.access.key.id=<access.key.id>
# oss access key secret, required if you set remote.logging.target=OSS
remote.logging.oss.access.key.secret=<access.key.secret>
# oss bucket name, required if you set remote.logging.target=OSS
remote.logging.oss.bucket.name=<bucket.name>
# oss endpoint, required if you set remote.logging.target=OSS
remote.logging.oss.endpoint=<endpoint>

Create a shell task

View the task log

Check that the task log is sent to OSS

delete the local task log file

View the task log again. The task log will be download from OSS.

Codecov Report

Merging #13332 (952fff4) into dev (ccad56e) will decrease coverage by 0.13%.
The diff coverage is 0.00%.

@@             Coverage Diff              @@
##                dev   #13332      +/-   ##
============================================
- Coverage     39.55%   39.42%   -0.14%
+ Complexity     4294     4288       -6
============================================
  Files          1072     1074       +2
  Lines         40565    40641      +76
  Branches       4656     4652       -4
============================================
- Hits          16045    16022      -23
- Misses        22734    22831      +97
- Partials       1786     1788       +2

Impacted Files
Coverage Δ

...e/dolphinscheduler/common/constants/Constants.java
75.00% <ø> (ø)

...heduler/common/log/remote/OssRemoteLogHandler.java
0.00% <0.00%> (ø)

...ler/common/log/remote/RemoteLogHandlerFactory.java
0.00% <0.00%> (ø)

.../server/master/runner/WorkflowExecuteRunnable.java
10.03% <0.00%> (-0.13%)
:arrow_down:

...duler/remote/processor/LoggerRequestProcessor.java
0.00% <0.00%> (ø)

...lphinscheduler/plugin/task/api/utils/LogUtils.java
26.96% <ø> (ø)

...erver/worker/runner/WorkerTaskExecuteRunnable.java
33.92% <0.00%> (-3.09%)
:arrow_down:

...erver/master/processor/queue/TaskEventService.java
69.64% <0.00%> (-10.72%)
:arrow_down:

...er/master/dispatch/host/assign/RandomSelector.java
77.77% <0.00%> (-5.56%)
:arrow_down:

...e/dolphinscheduler/remote/NettyRemotingClient.java
50.00% <0.00%> (-2.78%)
:arrow_down:

... and 24 more

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

Hi, @zhongjiajie , thanks a lot for your review and comments.
I will carefully modify according to the suggestions and add related UT and documents.

Hi, @zhongjiajie @Radeity, thanks again for your kind review. I have modified this PR according to your comments and suggestions.
Here are some brief changes:

Remove the Thread.sleep() in WorkerTaskExecuteRunnable

send the task log to the remote storage in clear() method in AbstractCommandExecutor, so there is no need to sleep anymore.

Note that not all tasks will use logHandle and FINALIZE_SESSION_MARKER, such as ZEPPELIN task and the tasks executed on master. So this PR also sends the task log to the remote storage in afterExecuted() and afterThrowing() on worker (if the task does not use logHandle) and taskFinished on master (if the task is executed on master).

Here is some examples:

Shell Task (use logHandle)

Zeppelin Task (does not use logHandle)

Add the doc

I am not sure if the location of this doc is appropriate.

In order to prevent remote logging from affecting the execution process of tasks, logs are written to remote storage in an asynchronous manner.

Hi, @zhongjiajie , could you please help review this again?

Hi, @caishunfeng , thanks a lot for your review and comments. I've modified it according to your suggestions, could you please help review this again?

Sure, and please resolve the conflicts.

Hi, @caishunfeng , I've resolved the conflicts.

https://github.com/apache/dolphinscheduler/blob/dev/docs/configs/docsdev.js

Sure, I'll look into it.

Hi, @zhongjiajie , I've add configs in docsdev.js


fix a corner case of list add

Allow adding a BaseListVariable and a ConstantVariable together if the latter is an iterable. It happens in detectron2 which adds a BaseListVariable with an empty tuple.
The PR also fix a few other small things

fix the usage of json.loads in autotune.py
in autotune.py, graph_name is hidden by the last backend name iterated
in the for loop
a typo in bytecode_transformation.py

cc @jansel


Tumangaonline does not download some manga

Source information
Tumangaonline 1.51
Source language
Spanish
Steps to reproduce
1.I start downloading some mangas like the manga chapter "Contrato de esclavitud obsceno" of that length
2.They are not downloaded due to Cloudfire failure
3.Since it doesn't download, I try to read it directly without downloading it with the application
4.The same thing happens and it doesn't let me read it due to Cloudfire's failure
5.I try the same steps with another manga of that length (Example: "Yakusoku No Neverland) and if it works
Expected behavior
You should have downloaded and/or let me read those mangas in the app
Actual behavior
The chapters should have been downloaded and/or it should be possible to read but strangely it could not be
Mihon/Tachiyomi version
TachiyomiSY Stable 1.10.2
Android version
Android 13
Other details
No response
Acknowledgements

[X] I have searched the existing issues and this is a new ticket, NOT a duplicate or related to another open or closed issue.
[X] I have written a short but informative title.
[X] I have updated the app to version 0.15.3.
[X] I have updated all installed extensions.
[X] I have tried the troubleshooting guide.
[ ] I have admitted that I am a clown by having checked this box, as I have not read these acknowledgements.
[X] If this is an issue with the app itself, I should be opening an issue in the app repository.
[X] I will fill out all of the requested information in this form.

Refer to the Cloudflare section at the troubleshooting guide

I'm here because I already tried to do that but it didn't work for me. Or maybe I didn't know how to do the user agent thing well.

The only thing you can do is keep trying different user agents or wait for the site to lower its protection. Also, in the latest version of the extension an option was added so that if you have a cloudflare error when opening a chapter, you can open the manga in WebView to show the captcha

I just don't know how to test that... I mean I don't understand how testing different user agents works, I just don't know what to do. As for the other thing you say, I have already tried opening it in webview, when I open it I get the check box but once I do it it gives an error and asks me to verify myself again

You just need to try different ones until one works. Try using your browser's user agent (the one that appears on this page), and then change the user agent string in the app as the guide says


Argsort Adaptation

Amazing work! I was wondering if it would be possible to adapt the qsort kernels for an argsort. So also returning the indices that would make the original array sorted. (I believe you can do this with std::sort by sorting pair<value, size_t> where size_t is the original index) Would love to help out if it's feasible!

Hi, we are working on adding key-value sort (see PR https://github.com/intel/x86-simd-sort/pull/2) and I want to add argsort as well. Pull requests are welcome if you want to work on it!

@r-devulap Amazing! I'll wait till that lands and then help out

See #34 @samster25

Thanks @r-devulap Will looking into integration!

@samster25 argsort for 32-bit and 64-bit dtype has been merged. Were you able to integrate it? Just curious to hear your feedback and what sort of workload you are using it in.

Closed, as completed.

Hi @r-devulap, Sorry for the delay. I was planning on taking a look in our next sprint! Our plan is to build a Rust crate that wraps this code base. Our use case is we're building a Distributed DataFrame called daft (built in Rust) and we would love to leverage SIMD for our sorts and partitioning algorithms. Thanks again for the hardwork! :)

@samster25 quick ping to check if you have had time to use any of the simd sort methods in daft?


Dashing Strike Charges condition prevents simulation

If I try to add a condition of Charges - Dashing Strike - > - 0 the simulation never works. No value for charges ever works.

Fixed.


Update jgrapht-core to 1.5.0

Updates org.jgrapht:jgrapht-core from 1.3.1 to 1.5.0.
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "org.jgrapht", artifactId = "jgrapht-core" } ]

labels: library-update, semver-minor

Superseded by #214.


integration test for name resolution shadowing

Fix: #82
The actual fix is actually in prost-reflect, MR coming soon

I've published prost-reflect version 0.14.1 which will hopefully make this test pass 🤞

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 92.63%. Comparing base (cc3712e) to head (68d80f4).

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #84      +/-   ##
==========================================
- Coverage   92.67%   92.63%   -0.05%
==========================================
  Files          19       19
  Lines        2430     2430
==========================================
- Hits         2252     2251       -1
- Misses        178      179       +1

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Add @apply tests for polymer-like elements

Tests for #518

Thanks for this PR. We've added similar tests in lit-html 0.14.0 and confirmed that #518 has been fixed so going to close this PR.


Add option of not fetching images using newspaper library and make default for commoncrawl

This patch adds an option to NewsPlease.from_warc(...) to not download images when running newspaper. This is also set to be the default when using commoncrawl. The principled reason for this default is that the archive WARCs is historical, but then images are downloaded immediately: so the text and images could be out of sync if there were updates for example. The pragmatic reason for this default is that servers can respond to these requests really slowly, so that the whole extraction process gets held up. Downloading from news-crawl is much faster, so the images should only be fetched if the user opts-in.

This is a good one. I'm not sure, though, whether we should change the previous default behavior without a major version change. Maybe it'll be better to prominently display this behavior and how one can change it if needed.


Add email replacement to Git configure step

The problem
The Configure Git steps mention replacing the name in the example but doesn't mention replacing the email.
Describe the solution you'd like
I suggest making the email replacement a specific instruction.
Screenshot

@caabernathy @elinguiuriel I would like to work on this issue.

Awesome @PrashanthPuneriya🎉! I assigned it to you 🙏 do not hesitate to ping us for any clarifications.
Looking forward to your PR.

@aboullaite Can I fix this too if the person assigned has not created a PR yet?

@vj-codes i think @PrashanthPuneriya is working on it! Let's give him more time :)

@vj-codes i think @PrashanthPuneriya is working on it! Let's give him more time :)

Yes sure:)

@aboullaite I could create a PR right now without understanding the codebase. But, I am learning bit by bit about GraphQL and messenger bot to get a greater understanding of the codebase. So, it is taking me longer than anticipated to create a PR.
@vj-codes I will inform you when I don't expect myself of creating a PR.

Hey @PrashanthPuneriya, graphql is great, but i dont see why ypu need it here ?

@aboullaite Oh! Don't we need it here? I came across webhooks and tokens terms within this project. So, I thought of learning GraphQL as well. Anyway,
I learned GraphQL not knowing that we won't require them in this project. There is no harm in learning. :)

@PrashanthPuneriya absolutely! Just wanted to know if I missed something 👍


Add pull request template and issue templates

This is an automatic batch pull request.

This change is

Codecov Report

Merging #279 into dev will increase coverage by 1.02%.
The diff coverage is n/a.

@@           Coverage Diff            @@
##             dev    #279      +/-   ##
========================================
+ Coverage   1.45%   2.48%   +1.02%
========================================
  Files         36      38       +2
  Lines       3974    4424     +450
========================================
+ Hits          58     110      +52
- Misses      3916    4314     +398

Impacted Files
Coverage Δ

Modules/xExchangeHelper.psm1
13.85% <0%> (ø)

Modules/xExchangeDiskPart.psm1
1.21% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cb6fc94...7bca35a. Read the comment docs.

Pull-request updated, HEAD is now b9d74637305fde1c4e67bb4beda332f86bcf4ef3

I totally missed this one, fixing this now.

@mhendric could you review this when you have a chance?

Looks good to me!


Configuring derived trunks

"Sbc1.customers.adatum.biz – the derived trunk in a customer tenant that does not need to be created in PowerShell. You can simply add the name of the derived trunk in the customer tenant in the online voice routing policy without creating it.""
To me its unclear how I go about and do this. What command should I use to configure the derived trunk for the tenant?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 1cb0c2ef-6274-9167-ecc6-3695d7460a8d
Version Independent ID: aacf7318-02fc-a1c3-369c-65e6936fdb3c
Content: Configure a Session Border Controller for multiple tenants
Content Source: Teams/direct-routing-sbc-multiple-tenants.md
Service: msteams
GitHub Login: @CarolynRowe
Microsoft Alias: crowe

@lagerstedt Thank you for submitting feedback and contributing to the docs. We are currently investigating this.

Any updates about this?

Hi all. Any update on this case? I'm facing the same confusion when dealing with the derived trunk.

Hi @lagerstedt and @fanzhangrob, thank you for your feedback.
"You can simply add the name of the derived trunk in the customer tenant in the online voice routing policy without creating it."
You need to create a Online Voice Routing Policy using New-CsOnlineVoiceRoutingPolicy.
Please check this article:
https://docs.microsoft.com/en-us/microsoftteams/direct-routing-configure#enable-users-for-direct-routing-service
You should follow the steps under "Enable users for Direct Routing Service" for each customer tenant and you shouldn't apply the steps under "Pair the SBC to the Direct Routing Service of Phone System".

Hi Dario,
Thanks for your attention but I am still quite confused. As I understand to
create a Online Voice Routing Policy I need to create a  Online Voice
Route. However in the  Online Voice Route I need to specify the FQDN of the
Gateway which is not required to be created. I tested it and the
New-CsonlineVoiceRoute command returns a alert saying " Cannot find
specified Gateway"
[image: image.png]
Could you explain a little more on that?
Regards,
Rob Zhang
Dario Woitasen<EMAIL_ADDRESS>于2019年9月28日周六 下午10:51写道：

Hi @lagerstedt https://github.com/lagerstedt and @fanzhangrob
https://github.com/fanzhangrob, thank you for your feedback.
"You can simply add the name of the derived trunk in the customer tenant
in the online voice routing policy without creating it."
You need to create a Online Voice Routing Policy using
New-CsOnlineVoiceRoutingPolicy.
Please check this article:
https://docs.microsoft.com/en-us/microsoftteams/direct-routing-configure#enable-users-for-direct-routing-service
You should follow the steps under "Enable users for Direct Routing
Service" for each customer tenant and you shouldn't apply the steps under
"Pair the SBC to the Direct Routing Service of Phone System".
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/MicrosoftDocs/OfficeDocs-SkypeForBusiness/issues/2954?email_source=notifications&email_token=ANG4QSZ5W76V7FFQ5ZLDQN3QL5VPRA5CNFSM4IUJ6R72YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD723JZI#issuecomment-536196325,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ANG4QS2B2NVP4ZTXAMOBL2LQL5VPRANCNFSM4IUJ6R7Q
.

Yes, you have to run:
New-CsOnlineVoiceRoute -Identity  -NumberPattern  -OnlinePstnGatewayList sbc1.customers.domain.com -Priority 1 -OnlinePstnUsages
Then:
New-CsOnlineVoiceRoutingPolicy  -OnlinePstnUsages
If it doesn't work please put the screenshot again here.
Thanks!
@CarolynRowe could you kindly help with this? Thanks!

Hi Dario,
As I said it does not work.
[image: image.png]
Regards,
Rob Zhang
Dario Woitasen<EMAIL_ADDRESS>于2019年9月29日周日 上午1:42写道：

Yes, you have to run:
New-CsOnlineVoiceRoute -Identity -NumberPattern -OnlinePstnGatewayList
sbc1.customers.domain.com -Priority 1 -OnlinePstnUsages
Then:
New-CsOnlineVoiceRoutingPolicy -OnlinePstnUsages
If it doesn't work please put the screenshot again here.
Thanks!
@CarolynRowe https://github.com/CarolynRowe could you kindly help with
this? Thanks!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/MicrosoftDocs/OfficeDocs-SkypeForBusiness/issues/2954?email_source=notifications&email_token=ANG4QS6IMXECLVQ3POW6LELQL6JSDA5CNFSM4IUJ6R72YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD726WQA#issuecomment-536210240,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ANG4QSZJCAELHXNVXODVM3DQL6JSDANCNFSM4IUJ6R7Q
.

@fanzhangrob You still need to configure the domain in the customer tenant. When I looked in to this I got Teams configured but I never got it to work. Teams would fail on incoming INVITEs (error indicated a broken setup). I have an open case with support about that but it does not seem to be going anywhere (been several weeks now).

Hi Carl,
Thanks for your kind reply.
I did exactly what the document tells me to do: domain in the carrier and
customer's tenant, txt DNS record... but the result is what I've captured.
I'm doing it in the old-school way now for my hoisting project. At least it
works.
Carl-Emil Lagerstedt<EMAIL_ADDRESS>周一下午4:24写道：

@fanzhangrob https://github.com/fanzhangrob You still need to configure
the domain in the customer tenant. When I looked in to this I got Teams
configured but I never got it to work. Teams would fail on incoming INVITEs
(error indicated a broken setup). I have an open case with support about
that but it does not seem to be going anywhere (been several weeks now).
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/MicrosoftDocs/OfficeDocs-SkypeForBusiness/issues/2954?email_source=notifications&email_token=ANG4QS4UH6QUMYLVPIFQSA3QMGZUPA5CNFSM4IUJ6R72YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD743BTQ#issuecomment-536457422,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ANG4QS4AMNYHFKWAC6UEU2DQMGZUPANCNFSM4IUJ6R7Q
.

I came to the same conclusion. Derived trunks does not seem to really work.
On Sep 30 2019, at 2:28 pm, fanzhangrob<EMAIL_ADDRESS>wrote:

Hi Carl,
Thanks for your kind reply.
I did exactly what the document tells me to do: domain in the carrier and
customer's tenant, txt DNS record... but the result is what I've captured.
I'm doing it in the old-school way now for my hoisting project. At least it
works.
Carl-Emil Lagerstedt<EMAIL_ADDRESS>周一下午4:24写道：

@fanzhangrob https://github.com/fanzhangrob You still need to configure
the domain in the customer tenant. When I looked in to this I got Teams
configured but I never got it to work. Teams would fail on incoming INVITEs
(error indicated a broken setup). I have an open case with support about
that but it does not seem to be going anywhere (been several weeks now).
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/MicrosoftDocs/OfficeDocs-SkypeForBusiness/issues/2954?email_source=notifications&email_token=ANG4QS4UH6QUMYLVPIFQSA3QMGZUPA5CNFSM4IUJ6R72YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD743BTQ#issuecomment-536457422,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ANG4QS4AMNYHFKWAC6UEU2DQMGZUPANCNFSM4IUJ6R7Q
.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub (https://link.getmailspring.com/link/E065A81C-216E-41BD-80FE-2FC9845292A6@getmailspring.com/0?redirect=https%3A%2F%2Fgithub.com%2FMicrosoftDocs%2FOfficeDocs-SkypeForBusiness%2Fissues%2F2954%3Femail_source%3Dnotifications%26email_token%3DAAPX2CLOWZ65DJKOUM2E37TQMHWH3A5CNFSM4IUJ6R72YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD75O4LQ%23issuecomment-536538670&recipient=cmVwbHkrQUFQWDJDSUs3QkxKRUUzV09JNVJBRzUzVDRUWDNFVkJOSEhCMk9VQ1dNQHJlcGx5LmdpdGh1Yi5jb20%3D), or mute the thread (https://link.getmailspring.com/link/E065A81C-216E-41BD-80FE-2FC9845292A6@getmailspring.com/1?redirect=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAAPX2CMQHJ5TR7TZWVONLDTQMHWH3ANCNFSM4IUJ6R7Q&recipient=cmVwbHkrQUFQWDJDSUs3QkxKRUUzV09JNVJBRzUzVDRUWDNFVkJOSEhCMk9VQ1dNQHJlcGx5LmdpdGh1Yi5jb20%3D).

I was struggling with the setup of a derived trunk for a few days now, but I finally was able to create a VoiceRoute without adding a PSTNGateway.
I do agree that Doc could be clear, but it as all there.
Assuming my carrier domain sbc.carrier.com, and customers domains being cust1.sbc.carrier.com, cust2.sbc.carrier.com....
sbc is working with FQDN sbc.carrier.com

On Carrier Tenant: create a subdomain sbc.carrier.com

On Carrier Tenant: create a user in this subdomain and assign a E5 license

On Carrier Tenant: wait for the user to appear on get-csonlineuser

On Carrier Tenant: Create PSTNGateway and verify SIP Options are working (tip to use a SSL Verification Utility to make sure TLS will work)
... set-csonlineuser
... create PSTNUsage, VoiceRoute, VoiceRoutingPolicy, Grant-CsOnlineVoiceRoutingPolicy ...

On Tenant domain: create a subdomain cust1.sbc.carrier.com

On Carrier Tenant: create a user in this subdomain and assign a E5 license

On Carrier Tenant: wait for the user to appear on Get-CsOnlineUser -Identity "" | fl RegistrarPool

Set-CsUser -Identity "" -EnterpriseVoiceEnabled $true -HostedVoiceMail $true -OnPremLineURI tel:<E.164 phone number>

step 8 was prereq to step 10

Set-CsOnlinePstnUsage -Identity Global -Usage @{Add="Carrier"}

New-CsOnlineVoiceRoute -Identity "Carrier" -NumberPattern ".*" -OnlinePstnGatewayList cust1.sbc.carrier.com -OnlinePstnUsages "Carrier"

New-CsOnlineVoiceRoutingPolicy "Carrier" -OnlinePstnUsages "Carrier"

Grant-CsOnlineVoiceRoutingPolicy  ....

@hsbsandrecv:
"On Carrier Tenant: create a user in this subdomain and assign a E5 license"
Is that possible? That domain is not registered in your carrier tenant but int the customer tenant?

This doc needs update. I struggled at first and then I can confirm that you dont have to create PSTNGateway (New-CsOnlinePSTNGateway) on the customer powershell. Here is how:
In the carrier tenant, you add domain for the direct routing, for example, domain.tld. Then create dummy user to assign O365 + Phone Systsem, for example<EMAIL_ADDRESS> In the carrier tenant powershell, we add gateway as usual with New-CsOnlinePSTNGateway, then add the PSTNUsage, adding CSOnlineVoiceRoute, and last create CSOnlineVoiceRoutingPolicy. Remember, these all happen in Carrier tenant powershell.
Now at the client tenant, add the derived domain, eg client1.domain.tld, add the TXT dns, and so on until it verified. And then add user dummy, eg<EMAIL_ADDRESS>Best thing is, you dont have to assign any office365 and phone system. In the customer tenant powershell, you dont have to add PSTNGateway, just go straight creating Set-CsOnlinePstnUsage, create New-CSOnlineVoiceRoute with client1.domain.tld as parameter, and then creat CSOnlineVoiceRoutingPolicy. Assuming all users are ready with EnterpriseVoice enabled and DID, Grant the newly created CSOnlineVoiceRoutingPolicy to users. You should be able to make call without having PSTNGateway. If you dont, sometimes msteams cloud need sometimes between creating user dummy and create csonlinevoiceroute, ranging from minutes to days, to let the change kicks in. Just wait.  Downside is in TAC you wont see any SBC status in the Voice menu.
Good luck.

@hsbsandrecv
I agree with @donlassini - I think steps 5, 6 and 7 and onwards should be for 'Customer Tenant', since you have the steps for 'Carrrier Tenant' in 1 to 4?

Hi @donlassini and @solarmon, I cannot find the section you are talking. Could you please copy and paste it?

@dariomws
We are talking about the steps listed in the last post by @hsbsandrecv - https://github.com/MicrosoftDocs/OfficeDocs-SkypeForBusiness/issues/2954#issuecomment-547672717

Thanks @solarmon. I think step 2 is right, if you miss this step you will get an error. You must create a user and assign a license for the final activation of the base domain. It´s documented here:
https://docs.microsoft.com/MicrosoftTeams/direct-routing-sbc-multiple-tenants#activate-the-domain-name


Combile errors

Hi,
Got two compile errors when installing using integrated HomeAssistant ESPHome add-on (latest 2022.9.4). Didn't have yet time to dig deeper on possible fixes..

"/config/esphome/esphome-ensto1.yaml:548:23: error: 'round' is not a member of 'std'"

"error: 'class esphome::ble_client::BLEClient' has no member named 'remote_bda'"

Related compile log entries:
/config/esphome/esphome-ensto1.yaml: In lambda function:
/config/esphome/esphome-ensto1.yaml:548:23: error: 'round' is not a member of 'std'
int16_t value = std::round(temperature_offset * 10);
^
/config/esphome/esphome-ensto1.yaml:548:23: note: suggested alternative:
In file included from /data/cache/platformio/packages/toolchain-xtensa32/xtensa-esp32-elf/include/c++/5.2.0/cmath:44:0,
from /data/cache/platformio/packages/toolchain-xtensa32/xtensa-esp32-elf/include/c++/5.2.0/random:38,
from /data/cache/platformio/packages/toolchain-xtensa32/xtensa-esp32-elf/include/c++/5.2.0/bits/stl_algo.h:66,
from /data/cache/platformio/packages/toolchain-xtensa32/xtensa-esp32-elf/include/c++/5.2.0/algorithm:62,
from src/esphome/core/optional.h:19,
from src/esphome/components/socket/socket.h:6,
from src/esphome/components/api/api_frame_helper.h:13,
from src/esphome/components/api/api_connection.h:3,
from src/esphome.h:3,
from src/main.cpp:3:
/data/cache/platformio/packages/framework-arduinoespressif32/tools/sdk/include/newlib/math.h:278:15: note:   'round'
extern double round _PARAMS((double));
^
/config/esphome/esphome-ensto1.yaml: In lambda function:
/config/esphome/esphome-ensto1.yaml:570:23: error: 'round' is not a member of 'std'
int16_t value = std::round(boost_offset * 100);
^
/config/esphome/esphome-ensto1.yaml:570:23: note: suggested alternative:
In file included from /data/cache/platformio/packages/toolchain-xtensa32/xtensa-esp32-elf/include/c++/5.2.0/cmath:44:0,
from /data/cache/platformio/packages/toolchain-xtensa32/xtensa-esp32-elf/include/c++/5.2.0/random:38,
from /data/cache/platformio/packages/toolchain-xtensa32/xtensa-esp32-elf/include/c++/5.2.0/bits/stl_algo.h:66,
from /data/cache/platformio/packages/toolchain-xtensa32/xtensa-esp32-elf/include/c++/5.2.0/algorithm:62,
from src/esphome/core/optional.h:19,
from src/esphome/components/socket/socket.h:6,
from src/esphome/components/api/api_frame_helper.h:13,
from src/esphome/components/api/api_connection.h:3,
from src/esphome.h:3,
from src/main.cpp:3:
/data/cache/platformio/packages/framework-arduinoespressif32/tools/sdk/include/newlib/math.h:278:15: note:   'round'
extern double round _PARAMS((double));
^
/config/esphome/esphome-ensto1.yaml: In lambda function:
/config/esphome/esphome-ensto1.yaml:81:38: error: 'class esphome::ble_client::BLEClient' has no member named 'remote_bda'
esp_ble_set_encryption(client->remote_bda, ESP_BLE_SEC_ENCRYPT_MITM);

Thanks, looks like there were breaking changes done for active connection support for Bluetooth Proxy in 2022.9.3. Should work now.

Works ok, that was fast. Kiitos!


Can't ask for GitHub permission after revoking access

Dev Home version
<IP_ADDRESS>
Windows build number
10.0.22621.1702
Other software
OS Build Version: 10.0.22621.1702.amd64fre.ni_release.220506-1250
.NET Version: .NET 6.0.16
Steps to reproduce the bug

Link GitHub account to Dev Home
Revoke access to account inside GitHub
Try to link again, or add repositories

Expected result
I would be able to link my account again.
Actual result
Dev Home just closes.
Included System Information
CPU: AMD Ryzen 7 5800H with Radeon Graphics
Physical Memory: 15.35GB (5.54GB free)
Processor Architecture: x64
Included Extensions Information
Extensions:
Microsoft.Windows.DevHome_<IP_ADDRESS>_x64__8wekyb3d8bbwe
Microsoft.Windows.DevHomeGitHubExtension_<IP_ADDRESS>_x64__8wekyb3d8bbwe

Encountered this issue as well, even re-installing Dev Home and Dev Home Github Extension doesn't fix it.
You need to open Credential Manager, and delete the GithubDevHomeExtension credential entry.

I signed out, reset the app under settings -> apps and even uninstalled Dev Home and installed it again.
After trying all of this, the only way to fix it was by manually deleting the GithubDevHomeExtension credential entry on Credential Manager, as @UltimateZero mentioned.

Logging out and logging in will work to display the autorization page of  the Dev Home GitHub Extension OAuth app while signing in to GitHub since v0.4


map has 3 markers,but show 2 markers

there are tree markers in the picture

but it only show two markers

and i find three elements in  dom  , two markers is a same marker

i need your helps,this bug @jperelli

I delete this and show normal

I had the same problem and deleting that line works! Thanks for that!

The problem seems to be related to vue2-leaflet, not to this package. I had this same problem with v1.0.2 of vue2-leaflet, but it seems to be fixed in v1.1.1 and newer, so the workaround of removing the line from the leaflet.markercluster package is no longer necessary.

ok, I'll try updating the package, thanks!

I updated the dependencies and published to npm, you can upgrade now to<EMAIL_ADDRESS>I tested it and the issue got fixed.
Please also test it if you can and let me know if there is any problem.
Sorry for the delay, merry christmas :santa:

Seems that this is fixed, closing


⚠ ClamAV has degraded performance

In eea7745, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 72 ms

Resolved: ClamAV performance has improved in 3f918a1.


Expand configured input and output paths

Hi! Thanks for Aniseed! (And Conjure!)
I've recently started doing a little Neovim configuration in Fennel, but because I'm an oddball, I wanted to keep it under ~/.vim with the rest of my vim stuff.
While trying to make that work, I realized that the docs didn't quite match what's happening in the code. The input and output arguments were treated as full paths if given, but never expanded.
This PR tweaks the docs to reflect that, and it also runs the paths through vim's path expander to handle stuff like ~.

Nice, thank you!


The following two commands are a temporary workaround because for the first time of running it gives eq=1, so there is a need to tun it for the second time in order to get eq=0 so that the rest of the statements are executed. id:1

FIXME:  The following two commands are a temporary workaround because for the first time of running it gives eq=1, so there is a need to tun it for the second time in order to get eq=0 so that the rest of the statements are executed. id:1 gh:3
ubuntuafterconf.sh:803
@imdone commenter. The developer's task board. imdone.io

FIXME:  The following two commands are a temporary workaround because for the first time of running it gives eq=1, so there is a need to tun it for the second time in order to get eq=0 so that the rest of the statements are executed. id:1 gh:3
ubuntuafterconf.sh:803
@imdone Issue Closer. The developer's task board. imdone.io


Regarding Various input devices (Keyboard, Mouse, Touch, Motion(Comming Soon)…)

Hi there
Looking fwd to the support for input devices, great to see they're on the roadmap.
Have done some research to find a performant solution and this is very well done indeed!
As an accessibility feature for users who don't immediately grasp the ability to manipulate the image sequence, would be nice to have an HTML range slider that can then be dragged to have the 360 move in sync.
Thanks

@vilav Thank you for your interest! 👍
First, related with input devices. spin viewer currently supports touch and mouse only but we will support others(motion, keyboard) as soon as possible.
I will review the function of the Range slider you mentioned.
Thank you again!

Hi @jongmoon, need to build a prototype for this slider that can move the 360. is there a temporary code / demo you have where a slider is usable with the 360?

@vilav Sorry for late! I was not able to get your request properly due to other service development work. Until tomorrow, I will reflect the code and demo in my master branch. And I want you to review our codes.
Thank you very much for your long wait.

Thank you @jongmoon, looking forward to it!

@vilav I just PR for this issue. #140
As I mentioned above, I added setTo method. (named spinTo)
And I added range slider to control spinning on manual test code(/test/manual/SpinViewer/SpinViewr.html)

Is this an implementation that fits your intentions? If not, please provide feedback and we will reflect it as much as possible.
After reviewing code, I'll merge it.

Resolved by #140


examples: cleancss v4 support

Signed-off-by: Lars Holm Nielsen<EMAIL_ADDRESS>

Depends on inveniosoftware/invenio-assets#65

Depends on Depends on inveniosoftware/invenio-assets#65 and Depends on inveniosoftware/invenio-theme#82


Class fields are now created to be lower camel case. Added interation test.

Fix for issue #563. Made fields lower camel case.
Thanks

Looks to me. i'm surprised you had to make a new method in nameutils... so I'm not sure that there's a test for schema either. I just had a look but couldn't find anything. Could you perhaps add a test for that input type too? I would probably expect it to be in PropertyIT

Yes, agreed. @MungoRae could you move your integration test to PropertiesIT? We can merge this for the next release.

I updated the integration test to be inside of PropertiesIT and I changed it to use a schema instead to fit in with the rest of the tests in that set.

Great, thanks!


Sorting on detailed service page doesn't work for hosts, IPs, State

v0.47.0-rc3
Steps to Reproduce:

Create GlusterFS Catalog  on different hosts

Problem 1: Host
2. Click on "Host" on detailed service page
Result: Containers sorted by something else
Expected Result: Containers sorted by host

Problem 2: IPs
3. Click on IPs
Result: Containers are sorted by first digit and then second digit of the third number in the 10.42.x.x IP.
Expected Result: Containers to be sorted by the whole number of the third number.

Problem: State
4. Click on "State"
Result: Not all containers are sorted by State
Expected Result: All containers to be sorted by state.

Version - master 3.20
Verified fixed


Basilisk v0

[ ] change background to snek eye https://github.com/galacticcouncil/Basilisk-assets

Indexer:

[ ] Implement base nft subsquid indexer
[ ] Add ability to set price https://github.com/kodadot/snek/issues/10
[ ] Chance to add royalties https://github.com/kodadot/snek/issues/8
[ ] Possilibity to manage offers https://github.com/kodadot/snek/issues/9

UI:

[ ]  Make a page dedicated to creating a unique (NFT) with a simple workflow
[ ]  Ability to create a Class (collection)
[ ]  Show class detail with metadata
[ ]  Show minted NFTs in explorer mode
[ ]  Show user's profile
[ ]  Display metadata for particular NFT (instance)
[ ]  Burn an instance
[ ]  Implement a page to teleport KSM between Kusama and Basilisk
[ ]  Extend vue-polkadot/api to handle multiple (parallel connections).
[ ]  Provide check if a user has enough balance on Basilisk / Kusama to be able to mint and transfer a collection.

Marketplace

[ ] Buy
[ ] SetPrice
[ ] Make offer
[ ] Accept offer

Not implemented:

[ ] Auctions (it will go for V1)

remove whole text from frontpage ambasador & github &c

Why ?

How high priority is this and are the tasks the same :)

How high priority

p1 for @vikiival

What we are missing to make it run for testing?

Things I had to make to make it running and can break stuff

remove max from queries/fragments/collectionDetails.graphql`

Let's push some version, others can help you out so we can make things faster:)

Slightly rugged by #2975

as discussed, I've moved the unfinished issues from this one into

#3648

since we're moving forward


Does not respect .eslintignore file

The one missing feature that makes this unusable for me is that it doesn't respect my project's .eslintignore file :(. Could we fix that? I may do it myself and send a PR if I have time in the next couple weeks :).

I think it's working (at least for me).

It seems to be working now.. strange :3

Good to know !


Update user guide

This change is

Coverage remained the same at 85.714% when pulling dc72805eac79bb25faf148ac44b678dae47346fe on updateUserGuide into 5efab12b4e95b99746c0a4441e474067162ff78f on master.


Added the NumberListAttribute attribute

This adds a List attribute that only supports numbers (i.e. integers). In general, DynamoDB will support a heterogeneous list of types under the List ('L') type:
AWS Documentation » Amazon DynamoDB » API Reference » Data Types » AttributeValue
But, developing that more general case will take additional time to build and test. For now, this very
specific attribute will answer the needs of some PynamoDB users.

Coverage decreased (-0.2%) to 97.234% when pulling 99fc13ca91b7f328c34132fccc761961ac7487df on digitizdat:devel into 8106eb151c3d76bd844875645256ee1984fca794 on jlafon:devel.

Coverage decreased (-0.2%) to 97.247% when pulling 7bfb2c057d9edc04f5e8eacdd97ab0a45f5e8123 on digitizdat:devel into 8106eb151c3d76bd844875645256ee1984fca794 on jlafon:devel.

Coverage increased (+0.03%) to 97.473% when pulling 74a2723873c1fc8a1a9b3bcb288c9ae9ef9484f2 on digitizdat:devel into 8106eb151c3d76bd844875645256ee1984fca794 on jlafon:devel.

@jlafon, would you please merge this PR to add the NumberListAttribute attribute, and to address issue #122?

@digitizdat apologies for the slow response. I'll review this now.

@jlafon Defined constants are now used in place of the actual characters. Let me know if there's anything else.

@jlafon Was this ^^ the change you were looking for in your request that I use constants for 'L' and 'N' to keep the style consistent?

Changes Unknown when pulling 8e193bb156bf3142340c6d3a799c6ef7694c7b85 on digitizdat:devel into ** on jlafon:devel**.

@jlafon Just checking in to see if this can be merged yet. I have added all of the most recent changes up to today, which did include some conflicts I had to manually resolve.
I would still like to get this PR merged so that I don't need to keep manually updating my fork.

Closing this PR to open it with a new PR that includes a cleaner implementation of NumberListAttribute that also includes an implementation of UnicodeListAttribute.


Remove jest.runAllTicks() note about promises

Promises use their own micro-queue for resolution, which Jest has no control over.
Also re-generated README.md via cd website && npm start; has some changes unrelated to the docs/API.md change.

thanks!

@facebook-github-bot shipit

Thanks for importing. If you are an FB employee go to Phabricator to review.


[fela-plugin-custom-property] Avoid deleting resolved custom properties

Description
This pull-request fixes a minor bug with the fela-plugin-custom-property plugin.
When naming a custom property after one of the CSS properties it eventually outputs, that very property gets deleted. It works well in the case of the size example as size should not be present in the output object, but when using this plugin a custom enhancer or validator, it doesn’t yield expected results.
Example
const shorthand = property => value => {
  console.warn(`The \`${property}\` should not be used because of lack of reusability of shorthand properties in Fela. Use the sub-properties instead.`)

  return { [property]: value }
}

export default createRenderer({
  plugins: [ customProperty({ padding: shorthand('padding') }) ],
  enhancers: [ … ]
})

Versioning
fela-plugin-custom-property should be bumped to 6.0.4.
Checklist
Quality Assurance

You can also run yarn run check to run all 4 commands at once.

[x] The code was formatted using Prettier (yarn run format)
[x] The code has no linting errors (yarn run lint)
[x] All tests are passing (yarn run test)
[x] There are no flow-type errors (yarn run flow)

Changes
If one of the following checks doesn't make sense due to the type of PR, just check them.

[x] Tests have been added/updated
[x] Documentation has been added/updated
[x] My changes have proper flow-types

Yey, thank you for fixing this :)

I hope I didn’t break anything. ;)


⚠ Openweb Service - Jenkins has degraded performance

In 6c225cd, Openweb Service - Jenkins ($OPENWEB_HEALTH_LIVE/jenkins) experienced degraded performance:

HTTP code: 200
Response time: 23055 ms

Resolved: Openweb Service - Jenkins performance has improved in b0ac738.