Change Home Assistant's depracated forecast property.

Fixes #68

Friendly reminder @anand-p-r - this will break in next month's Home Assistant release.

Hi
it seems that there is a fix for that.
https://github.com/cruwaller/fmi-hass-custom GitHub - cruwaller/fmi-hass-custom: Home Assistant Custom Component Supporting FMI Based Weather and Sensor Platforms
at least it works for me.
Lähettäjä: Sebastian Lövdahl @.>
Lähetetty: lauantai 10. helmikuuta 2024 20.11
Vastaanottaja: anand-p-r/fmi-hass-custom @.>
Kopio: Subscribed @.***>
Aihe: Re: [anand-p-r/fmi-hass-custom] Change Home Assistant's depracated forecast property. (PR #69)
Friendly reminder @anand-p-r https://github.com/anand-p-r  - this will break in next month's Home Assistant release.
—
Reply to this email directly, view it on GitHub https://github.com/anand-p-r/fmi-hass-custom/pull/69#issuecomment-1937086101 , or unsubscribe https://github.com/notifications/unsubscribe-auth/A4L22BBPPBL77KDKM7LL2MTYS6Z27AVCNFSM6AAAAABBFRN3VKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMZXGA4DMMJQGE .
You are receiving this because you are subscribed to this thread.  https://github.com/notifications/beacon/A4L22BB4OKQNETMCGW3CHIDYS6Z27A5CNFSM6AAAAABBFRN3VKWGG33NNVSW45C7OR4XAZNMJFZXG5LFINXW23LFNZ2KUY3PNVWWK3TUL5UWJTTTOWLJK.gif Message ID: @.*** @.***> >

I hope so as well.
I can collect PRs for now if @anand-p-r is not willing to maintain the og version anymore... I would like to create a group to keep all in one place but hopefully @anand-p-r could create it 👌

Seems @anand-p-r does not visit this place anymore :(
Would it be possible for anyone, e.g. @cruwaller, to fork the repo and continue maintenance of the integration?
Or what would be the best way to procced here?

I created a new organization to keep this maintained. Please let me know if any of you wanna join the party :)
Fork can be found from here https://github.com/fmi-hass/fmi-hass-custom
I will merge and push modifications in to get this work ongoing...

I created a new organization to keep this maintained. Please let me know if any of you wanna join the party :) Fork can be found from here https://github.com/fmi-hass/fmi-hass-custom
I will merge and push modifications in to get this work ongoing...

This repo will be moved for easier user actions. I deleted the for now.... Sorry for the inconveniences!

@cruwaller @anand-p-r are you planning to make a new release of the integration as well? Home Assistant 2024.3 is being released later tonight.

Oh, very good point! I will trigger a release now with these changes.
Thanks


add a generic proxy for UI to make CORS requests to cloud providers

@ibuildthecloud

@ibuildthecloud Updated it.

@vincent99 FYI, in master


Remove module placeholder

I believe the gossipsub integration along with dependency injection module for go-f3 will live outside of this repo. Regardless, the existing module is not fully implemented, and it's unclear if it remains useful in future Lotus integration.
Remove it from the codebase for now to simplify refactoring, code organisation and dependencies.

@Kubuxu I'd love your eyes on this PR please. My sense is that by the time we are done getting this repo ready for integration with Lotus the module.go as it is today would look very different. Considering its current state I'd like to remove it and revisit later.

To be discussed further when there are more concrete details on how F3 is going to be integrated in lotus.
For now leave place holders be.


--importCorpus Option Error

HI
The basic jsc fuzzing command works fine.
(swift run FuzzilliCli --profile=jsc /Users/user/Fuzz/WebKit-releases-Apple-Safari-16.4-macOS-13.3/FuzzBuild/Debug/bin/jsc)
but, If I add the following option statement to use the importCorpus option... an error occurs.
--importCorpus=/Users/user/Fuzz/fuzzilli/test

* In the folder "test", there is basic_variable.fzil where I compiled the sample code (basic_variables.js) using FuzzILTool.

The contents of the error are as follows.
(It doesn't seem to recognize it in the importPrograms function. What additional commands should I use?)
...
[Fuzzer] Corpus import finished:
[Fuzzer] 0/1 programs executed successfully during import
[Fuzzer] 0/1 programs timed out during import
[Fuzzer] 1/1 programs failed to execute during import ---------------> Fail....
[Fuzzer] Corpus now contains 0 programs
[Fuzzer] Changing state from corpusImport to fuzzing
Swift/Integers.swift:2665: Fatal error: Can't get random value with an empty range

@BruteKoon i have the same problem ? have you resolved it ?


Cursor moves to @code brace if edited too quickly.

This is issue is based on the repro steps here: https://github.com/dotnet/razor-tooling/issues/5826#issuecomment-987787642.
@code {
    private int currentCount = 0;

    private void IncrementCount()
    {
        currentCount++;

        var p = new PersonModel()
        {

        };|
    }
}

Based on the @code block above with the cursor | in position, if I quickly hit the backspace key 3 times and then add an ending brace } I expect the following:
@code {
    private int currentCount = 0;

    private void IncrementCount()
    {
        currentCount++;

        var p = new PersonModel()
        {

        }|
    }
}

but actually I get what I expected except for the cursor | has jumped to the opening brace { next to the @code:
@code {|
    private int currentCount = 0;

    private void IncrementCount()
    {
        currentCount++;

        var p = new PersonModel()
        {

        }
    }
}

N.B. If I slow down the typing steps I can get the expected result without the cursor jumping.
Screenshots
Fast typing:

Slow typing:

This is likely the same as https://github.com/dotnet/razor-tooling/issues/5596 which has been fixed. If you have 17.0.2 installed, that version has the fix already.
Can you confirm what version you're seeing this in?

I'm seeing this in VS 2022 17.1.0 Preview 1.1

Ah actually the fix actually slipped to 17.0.3 and 17.1-Preview2

Confirmed this no longer repros with the fix from #5596 so going to close this as a duplicate. Thank you for the report and repro.


further work on #154 - better trip generator

use single trip mode selection function
(still extremely primitive, based on a distance)
border-to-border traffic is now more varied
rewrite TODOs

Thanks for the improvements!


Right-click issues on machine walls

I partially reverted 9696598 to fix the tunnel side issue #368.
My reasoning is the following: when the player main-hand is empty it should let minecraft check the off-hand (return false) and when the world is remote it should stop the propagation if the item in hand is a tunnel but not with other items to let minecraft trigger their right-click event (return playerStack.getItem() instanceof ItemTunnelTool).
The other commit fixes something weird I found while debugging the other issue, when I right-clicked with the PSD having torches in my off-hand, a torch was placed on the wall but it was only visible from client-side.

Hey, sorry for the late reply.
This looks good to me. Thanks!


Memory Leak due to TimeSegment widget

flatpickr, the module used for timeSegment widget creates a div element every time it is instantiated but never disposes of itself
As a result any state change will generate more unused divs in the dom.
This is extremely problematic combined with undo/redo which causes a state change every operation.

I can remove leftover divs when I create a new one with the same id using the layer name as the id
However, the layer name is not accessible when creating a layer via the add layer button for some reason
Additionally, GraphOperationLayerView is not disposed of correctly which means that timewidget can't remove the leftover div.
The partial solution mentioned at the beginning removes leftover diivs but all seg w/ graph layers created using the add layerbutton will share a timestamp widget which will lead to unintended behavior.


bug: getProvider returns undefined on mobile

Is there an existing issue for this?

[X] I have searched the existing issues

Package Version
1.0.5
Current Behavior
I'm using wagmi and web3modal to connect via walletconnect v2
wagmiConfig.args.connectors[1].getProvider() works fine on desktop, returning metamask provider (the same as window.ethereum)
doing the same on mobile results in getProvider() returning undefined

Expected Behavior
No response
Steps To Reproduce
No response
Link to Minimal Reproducible Example (StackBlitz, CodeSandbox, GitHub repo etc.)
No response
Anything else?
No response

Thanks for reporting. This issue is temporarily closed due to lack of information. Please provide a minimal reproducible example and reopen this issue.

@tmm Just made a minimal repo. Again, works fine on desktop and breaks on mobile. I used ngrok for test deployment


v3.0 has not been published on the marketplace

To publish to the marketplace, it seems that tagging is not enough, you need to create a release.
https://docs.github.com/en/free-pro-team@latest/actions/creating-actions/publishing-actions-in-github-marketplace#publishing-an-action
I'm not troubled because I can use v3.0, but new users will mistakenly think #15 is unresolved because v3.0 does not exist in the marketplace.

Thanks, done.


Throw exceptions for testing purposes

It would be a very useful feature, regarding tests for exception handling, when you could throw custom exceptions on method calls (just like using when(...).thenThrow(...) in the mockito package).

This would be very useful if we could somehow simulate Network and other exceptions to better structure the tests. I'm not sure whether considering the package is a fake and not a mock (see this issue:  #34 ) whether this could come under its scope or not.
Not sure with so many nested modules in Firestore (e.g.
instance.collection('info').where("week", isEqualTo: week).getDocuments()), whether Mockito too would be a viable option for this or not.
@atn832 would love some insights on this. If this is indeed possible, I would be happy to try raise a PR.

It's a great idea!
Regarding the scope, it's indeed a bit fuzzy. If we build this, we could think of it as the fake behaving like the real Firestore for failures as well.
Since we don't use Mockito's Mocks (the fakes technically still inherit Mock but I'll remove that soon), I wonder how we could implement the feature cleanly though.
I'm also not familiar with the Firestore behaviors on failure. What are the most common cases where calls fail? Which cases would you like the library to be able to throw?

Yes, currently we use cloud_firestore_mocks for  actual implementation test and use Mockito for testing exceptions. Having same scenario in both packages would help test better.
Few common areas I could think of:

Security Rules related issue, such as permission denied to access doc
No internet error while performing get/set and getting data from listening to a stream
Other server errors thrown due to excessive calls to 1 document etc.

Another issue here is that currently Firestore's exhaustive Exception handling documentation doesn't exist yet and a big revamp is in progress there: https://github.com/FirebaseExtended/flutterfire/issues/2582

Is there any workaround for throwing exceptions right now?

@atn832
I had the same necessity. The DocumentReference.set method, for instance, will throw a FirebaseException that will contain a code. Here's a list of possible codes: https://firebase.google.com/docs/reference/kotlin/com/google/firebase/firestore/FirebaseFirestoreException.Code
In my opinion, we could simply have a field in the fake Firestore that receives a FirebaseException (for the set method for instance, it could be called setException. If the value is present, then upon DocumentReference.set being called, we simply throw the provided exception.
I would be up for implementing this for the DocumentReference's set method, then we can just replicate to the others as needed. Tell me if this sounds like a good idea and I'll do it.

We used that approach in firebase_auth_mocks, but it quickly became quite verbose. See:

https://github.com/atn832/firebase_auth_mocks/blob/master/lib/src/auth_exceptions.dart
https://github.com/atn832/firebase_auth_mocks/blob/d8dee460643cb263b40bc13e5ab786f05868428e/lib/src/firebase_auth_mocks_base.dart#L64-L109

Because of this, I was wary of going down the same path for fake_cloud_firestore, which is much larger project.
So I took a look at how Mockito does it, and went ahead and built and published a lightweight Mockito lookalike (https://pub.dev/packages/mock_exceptions). it

Thank you so much @atn832 !
This really is a better solution.
So if I understood this correctly:
Exceptions that depend on the internal state of the FakeFirebaseFirestore instance will be faked.
Exceptions that go beyond its internal state, such as exceptions related to security rules and service availability will need to be mocked.
I'll contribute soon to the other methods if no one gets there before. Cheers!

I just released a big update for Fake Cloud Firestore regarding security rules. You can now initialize FakeFirebaseFirestore with:

the security rules that you use in production in Firebase.
a Stream of sign-in events from Firebase Auth Mocks.

Then FakeFirebaseFirestore will automatically verify access on documents based on your rules and the sign-in state (signed in or not, uid, claims) in your tests. Later we'll implement access verification for collections and queries. You can read the details in the README.
So now you may want to mock exceptions only to simulate service unavailability.

With fake_cloud_firestore 2.2.0, it is now possible to mock exceptions on DocumentReference.set with the whenCalling(invocation).on(document).thenThrow(exception). See an example of how to use it:
https://github.com/atn832/fake_cloud_firestore/blob/7dc8bcffa1617969aa27a4c62453b73376706ee4/test/fake_cloud_firestore_test.dart#L46-L63
Since supporting all the methods by myself would be unfeasible, I'll write down a little guide on how to support an exception for a method and encourage you to contribute PRs. If you are unable to contribute a PR, feel free to file a ticket for the specific exception and method you'd like to use so that we can keep track of it.
First, figure out if the exception you're working with should be faked or mocked. For example, throwing an exception when calling DocumentReference.get on a non-existing document or missing field should be faked because it should throw that exception automatically depending on the actual state of the FakeFirebaseFirestore. If you want to simulate an arbitrary server failure, it should be mocked. If we take a look at this list of errors, I'd say ALREADY_EXISTS, NOT_FOUND, INVALID_ARGUMENT should be faked. The others such as ABORTED, CANCELLED, DATA_LOSS, DEADLINE_EXCEEDED, UNAVAILABLE should be mocked.
If it should be faked, you can write something similar to how it's been done. Don't forget to include unit tests in your PR.
If it should be mocked, make something similar to PR-258:

Go to the method you want upgrade to throw exceptions. On the first line, add a call to maybeThrowException with the right Invocation settings. You can take a look at these examples in mock_exceptions. They cover most use cases: methods, getters, setters, positional parameters, named parameters, type parameters.

Write the unit tests.

Find the place where the method's regular behavior is being tested. Since fake_cloud_firestore_test.dart contains the most tests, perhaps it is there.
Add a new test to check that the upgraded method can indeed throw exceptions. One or two basic tests will suffice.

Send a pull request. I'll review it and if all is well, merge and eventually release an update.

Thank you all in advance, and thanks for your patience thus far!

@atn832 whenCalling doesn't seem to be defined... 🤔

whenCalling is defined in the package mock_exceptions. If your project depends on fake_cloud_firestore v2.2.0 or higher, you will automatically have it as an indirect dependency. Just make sure you import it in the file that you need it:
import 'package:mock_exceptions/mock_exceptions.dart';

See fake_cloud_firestore's dependencies:
https://github.com/atn832/fake_cloud_firestore/blob/d89417b80ac718ea6b67fad74503401e25bd8145/pubspec.yaml#L19

@atn832 thank you!

any idea what's wrong with this code? I'm trying to mock fail on update
test('should return [DataFetchException] when call is unsuccessful',
        () async {
      var docRef = mockFirestoreClient.collection('users').doc();
      await docRef.set(
        AppUserModel.empty().copyWith(id: docRef.id).toMap(),
      );
      var tException = FirebaseException(
          plugin: 'firestore',
          message: 'unable to update',
          code: 'server-unavailable');
      whenCalling(Invocation.method(#update, [
        {'userType', 'worker'}
      ])).on(docRef).thenThrow(tException);
      expect(() => docRef.update({'userType': 'worker'}), throwsA(isA<FirebaseException>()));

@rajjeet Looks like you set up whenCalling with a Set ({'userType', 'worker'}) instead of a Map ({'userType': 'worker'}). See this example:
https://github.com/atn832/fake_cloud_firestore/blob/7dc8bcffa1617969aa27a4c62453b73376706ee4/test/fake_cloud_firestore_test.dart#L58-L62

@atn832 Thanks for catching that!

CollectionReference.add() isn't supported yet?

can anyone give me a hint with this please ( FakeFirebaseFirestore is the type of  fakeFirestore )
const mail = AnswerMailModel.empty();
  // arrange
  final collection = fakeFirestore.collection('answers');
  whenCalling(
    Invocation.method(
      #add,
      [
        {
          'request': '',
          'answer': '',
          'requestId': '',
          'createdAt': '',
          'answerUserId': '',
          'requestUserId': '',
          'icon': 0,
        }
      ],
    ),
  ).on(collection).thenThrow(FirebaseException(plugin: 'firestore'));

  expect(
      () => collection.add({
            'request': '5',
            'answer': '',
            'requestId': '',
            'createdAt': '',
          }),
      throwsA(isA<FirebaseException>()));
});

i am getting this error

Expected: throws <Instance of 'FirebaseException'>
Actual: <Closure: () => Future<DocumentReference<Map<String, dynamic>>>>
Which: returned a Future that emitted <Instance of 'MockDocumentReference<Map<String, dynamic>>'>
or it is all updated ? and changed now

@kazerdira The way you set up your test was:

if someone calls collection.add with { 'request': '', ... }, then throw an exception.
then you call collection.add({ 'request': '5' ... }).

As you can see above, the parameters don't match. So no exception will be thrown. If you want to throw an exception next time someone calls collection.add, you can write it more simply like so:
  whenCalling(Invocation.method(#add, null))
    .on(collection).thenThrow(FirebaseException(plugin: 'firestore'));

If you're curious about to use whenCalling/thenThrow, you can read more here: https://pub.dev/packages/firebase_auth_mocks#throwing-exceptions.
Finally since this feature is essentially built, I'll close this thread. Otherwise all of the previous participants will keep getting notified for no reason. Whoever has any issues can create a new ticket.

HI @atn832,
I am struggling a bit with having an exception thrown for firebase collection and couldn't quite figure it out.
My setup is, I have a Flutter widget, where there is an "add" button. When I click on the button it calls a class method which simply does this -
Future<void> add(LabelEntry entry) async {
    await firestore.collection('Labels').add(entry.toJson());
  }

The firestore var used above is the FirebaseFirestore which I plug-in during unit-testing with FakeFirebaseFirestore.
Now, my unit-test looks something like this -
testWidgets('failure', (widgetTester) async {
      // given
      final firestore = FakeFirebaseFirestore();
      final collectionRef = firestore.collection('Labels');

      // when
      whenCalling(Invocation.method(#add, null))
          .on(collectionRef)
          .thenThrow(FirebaseException(plugin: 'firestore'));

      // pump the widget in widgetTester
      await widgetTester.tap(find.text('add'));
      await widgetTester.pump();

      // then
      expect(find.byType(ListTile), findsNothing); // this fails, since the click on the 'add' button adds this successfully
    });

Would highly appreciate any help or hints. Thanks.


Error when writing with parser attached

SerialPort version: 5.0.0-beta2
NodeJS Version: v6.9.1
Operating System and Hardware Platform: Windows 10 home 64-bit
Are you using an alternative NodeJS runtime? (eg Electron): No
Summary of Problem
Running the code in next section produces the following error upon port.write.
Error is not thrown if the parser is not attached.

events.js:160
throw er; // Unhandled 'error' event
^
Error: Writing to COM port (GetOverlappedResult): Operation aborted
at Error (native)

Steps and Code to Reproduce the Issue
var SerialPort = require('serialport');
var Readline = SerialPort.parsers.Readline;
var port = new SerialPort('COM3');
var parser = new Readline();

port.pipe(parser); //Comment out this line and no error occurs
parser.on('data', console.log);
port.write('ROBOT PLEASE RESPOND\n');

Perhaps I spoke to soon - may just be a local issue.
I'll reopen if necessary.

In serialport_win.cpp I had changed a line locally to force flow control on since it doesn't get set from parameters.
It worked in the last beta. I assume it is not yet supported by the streams rewrite that's taking place.
serialport_win.cpp
  dcb.fOutxCtsFlow = TRUE;


[admin] Update resources to reflect Outlook documentation move

Docs Build status updates of commit 1aaee28:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/resources/resources-links-help.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

Docs Build status updates of commit 535658f:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/resources/resources-links-help.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


outlier detection

What did you have in mind here? I have use a custom test that checks whether values are within ±n standard deviations from some prior n-day rolling average that could apply here.

Interested to also know more about what this feature in testing is! 🙏

Interested to also know more about what this feature in testing is! 🙏

The testing label is for work related to dbt's data tests, not stuff that's in testing and near release, sadly 😞
You could check out the dbt_expectations package though, maybe https://github.com/calogica/dbt-expectations#expect_column_values_to_be_within_n_moving_stdevs would be useful?

Interested to also know more about what this feature in testing is! 🙏

The testing label is for work related to dbt's data tests, not stuff that's in testing and near release, sadly 😞
You could check out the dbt_expectations package though, maybe https://github.com/calogica/dbt-expectations#expect_column_values_to_be_within_n_moving_stdevs would be useful?

😞 all good, thanks for the reply!


use  WeakReferenceCache  when create a new aggregate throws NullPointerException

Axon Framework version:4.4.5
java.lang.NullPointerException
at java.util.concurrent.ConcurrentHashMap.putVal(ConcurrentHashMap.java:1011)
at java.util.concurrent.ConcurrentHashMap.put(ConcurrentHashMap.java:1006)
at org.axonframework.common.caching.WeakReferenceCache.put(WeakReferenceCache.java:81)
at org.axonframework.eventsourcing.CachingEventSourcingRepository.doCreateNewForLock(CachingEventSourcingRepository.java:89)
at org.axonframework.eventsourcing.CachingEventSourcingRepository.doCreateNewForLock(CachingEventSourcingRepository.java:42)
at org.axonframework.modelling.command.LockingRepository.doLoadOrCreate(LockingRepository.java:137)

Hi, this might already be fixed. Could you upgrade to 4.6.8 or 4.7.5 to see if that fixes the problem? It includes some fixes that might resolve the issue already.

thanks it works


The SF11/C is not publish the distance data when the PX4Flow Smart Camera is connected.

Describe the bug
Hello, I'm using SF11/C for distance sensor and PX4Flow Optical Flow Camera in Pixhawk 2.1 (Cube). I don't have an ultrasonic module on PX4Flow. My setup is shown below.

Like images PX4Flow Camera is connected to I2C and SF11/C is connected to Telemetry 1.
The bug is revealed when I connected both of sensor to Pixhawk. SF11/C publishes distance sensor when PX4FLow Camera isn't connected. But, When I connect the PX4Flow to Pixhawk, PX4Flow publishes Zero distance which mentioned before this issue https://github.com/PX4/Flow/issues/101. In addition SF11/C cannot communicate Pixhawk when PX4Flow is connected.
Without PX4Flow Camera sf0x test and Current Distance Analyze

With PX4Flow Camerasf0x test and Current Distance Analyze

In documentations, Laser Altimeters sensor can be connect instead of Ultrasonic module. But, I didn't find any schematic for this.
I examined the drivers of PX4Flow and SF0X. They have same definition for Uorb distance_report topic.
PX4FLOW:
https://github.com/PX4/Firmware/blob/14ef009aabf5723b1a9f8fe5489844c961f05fab/src/drivers/px4flow/px4flow.cpp#L554-L566
SF0X:
https://github.com/PX4/Firmware/blob/14ef009aabf5723b1a9f8fe5489844c961f05fab/src/drivers/distance_sensor/sf0x/sf0x.cpp#L514-L528
Also they have same id for publishing. I tried to give different ID but it didn't work.
Furthermore, I just commented lines on PX4Flow. However, it didn't work as well.
To Reproduce
Steps to reproduce the behavior:

Connect SF11/C to Pixhawk Telemetry 1 and configure
Can be able to see Current Distance
Connect PX4FLow to Pixhawk I2C
See Current Distance Value Zero

Expected behavior
Pixhawk can be able to see correct distance values when PX4Flow and SF11/C are connected.

@dagar fyi.
I wasn't able to test on I2C bus with same setup (I don't have 1 more I2C connector for this). But today I able to test with poor connection on I2C bus.
The problem is that PX4Flow and SF11/C must connect on same I2C bus because of PX4Flow driver. So, it can be close.
Here correct setup:

In addition, maybe it can be add for future request. (PX4FLow on I2C, SF11/C on Uart) Should I open new Issue or can we continue on this?

This also looks related: https://github.com/PX4/Firmware/issues/11227

As far as I understand, it is not same issue. @60ericleal60 couldn't get any data from PX4Flow camera but I could. I just have problem with distance sensor.

There is a solder bridge you need to fill to power the distance sensor.

You are right. I saw that bridge and I tried to connect SF11/C to it with poor connection but data didn't come Qgroundcontrol. I'll try again with solder.

This issue is fixed at #11724 by @DanielePettenuzzo .  I'm closing and will continue on #11689


loggerd: run clear_locks() asynchronously

Is there a clear benefit? Is this operation slowing down loggerd start significantly?

Is there a clear benefit? Is this operation slowing down loggerd start significantly?

I'm not sure,still testing.I have encountered it running for 0.5 seconds

I'm not sure,still testing.I have encountered it running for 0.5 seconds

Why do we want to clear the locks up in the first place? In case loggerd didn't shut down cleanly?

Why do we want to clear the locks up in the first place? In case loggerd didn't shut down cleanly?

this seems to be the reason.

this seems to be the reason.

Closing this for now. I think we re-evaluate whether we really want to clear the locks. If anything, the uploader should probably do this.


Better but simpler random

This pull request aims to improve the random function used in the "That Coin Flip Tho" application. The current random function may not be providing a truly random result, which can affect the fairness of the coin flip.
Changes include:
Replacing the current random function with a more reliable one that uses a better randomization algorithm.
Simplifying the function to make it easier to understand and maintain.
Adding comments to explain how the new random function works.
The new function has been thoroughly tested to ensure it provides a truly random result. This will improve the user experience by making the coin flip feel more fair and unpredictable.
Please review the changes and let me know if you have any questions or suggestions.

Hi Célien,
Thank you for your contribution and the changes you've made in this pull request! Overall, everything looks great, and your modifications align well with the goals of the project.
I've reviewed your changes thoroughly and everything seems to be in order. Your code is well-structured and follows our coding standards. Additionally, the functionality you've added/improved resolves the issue/feature effectively.
I will proceed with merging this pull request into the main branch. If there are any further changes needed or if you have any additional points to discuss, please let me know.
Thanks again for your valuable contribution!
Best regards,
Jonathan

Apologies for the oversight regarding the missing comments in the initial commit. The comments have now been added to the code to improve readability and maintainability. With these changes, the pull request is now ready for review and merge. Thank you for your patience and understanding.

Great to hear that you've added the comments to improve readability and maintainability! Thank you for addressing that. I'll re-review the code to ensure everything aligns well with our standards and goals. If everything looks good upon this re-review, I'll proceed with merging it into the main branch.
Thanks for your prompt action and dedication to enhancing the codebase. I'll get back to you shortly after re-evaluating the changes.
Best regards,
Jonathan

Hi Célien,
Your patience is appreciated! After a thorough re-evaluation, everything appears to be in great shape. We're excited to proceed with merging your pull request into the main branch.
I want to underscore the crucial importance of this coin flip software. It may seem small, but it serves a fundamental purpose in ensuring fairness and reliability, pivotal in decision-making processes. Your work on enhancing this tool is noteworthy and something you should take pride in—it contributes significantly to the integrity of our applications.
Your commitment to improving this specific tool showcases your dedication to detail and quality, traits that immensely benefit our projects.
If you have any further questions or need assistance, don't hesitate to reach out.
Thank you once again for your valuable contribution!
Best regards,
Jonathan


add semicolon in ng-stomp.js file ; cause error while production

I am using this file and download using bower and it cause error in console and my project stopped working; after debugging for 5 hours I found that semicolon is missing in it's ng-stomp.js fie.
can you please add semicolon in end of the function  or suggest me how do I use it and add semicolon while copying these JS file from gulp serve:dist

+1

+1

Merge with #22


Harmonize Styling

Added styling to nav, counter and about page.
Misc code cleanup

related to @alanthai 's #50
Connected to rangle/rangle-starter#17

Excellent start.

:shipit:


Show by service

Closes #10

Todo

[x] Show breakdown by service
[x] Filter out empty rows
[x] Sort Services by highest cost
[ ] Discuss: Should this be hidden behind a cli flag? It prints out quite a bit of data.
[ ] 👀 Review @mrchrisadams

This looks really nice @vsmart !
I've created #9 for hiding this behind the tags.
https://github.com/thegreenwebfoundation/green-cost-explorer/issues/9
My preference is to merge this in, and then sketch out the design for breaking the bits of this into separate objects responsible for only their own job.
So we might move some of the CLI parsing into a separate file, using something like commander, and some of the filtering and grouping into one, and the renderer into it's own, so we can write tests for these respectively.
Sound good?

My preference is to merge this in, and then sketch out the design for breaking the bits of this into separate objects responsible for only their own job.

👍 :shipit:


Please make MailHog mobile friendly

Please make MailHog mobile friendly.
it is not possible to open an email on a mobile device right now

is there any hope for this issue to be solved any soon?

When this fix will be available for users on smartphone?

bruh


test ghprb hook

test ghprb hook

\test-with-operator 292

closing. opened upstream by mistake

\test-with-operator 292

\test-with-operator 292

\test-with-operator 292

\test-with-operator 292

\test-with-operator 292

\test-with-operator 292

\test-with-operator 292

\test

\test-with-operator 292

\test-with-operator 292

\test-with-operator 292

\test-with-operator 292

\test-with-operator 292

\test

\test

\test

\test

sample untested

test

\test

@pranavgaikwad are you still using this PR, or should we close it out?

\test

@djwhatle closing this PR. I am not using it anymore. Just wanted this to be an example usage of build.


Issue 378 Support linux/arm docker builds for SecretsManagement

Details see issue #378.

BDD tests were successful:
https://reports.cucumber.io/reports/11537d09-ae72-4c84-9c04-c545675b634a


⚠ Mobitopup has degraded performance

In 235a486, Mobitopup (https://napcard.voz.tech) experienced degraded performance:

HTTP code: 200
Response time: 3312 ms

Resolved: Mobitopup performance has improved in 0814625.


Fix ini escaping

What this PR does / why we need it:
Fix ini escaping by going back to simple text templates as the used lib was not compatible.
NONE

/test test

lgtm

/lgtm

/lgtm

/meow

/woof

/joke

/hold

/lgtm
/hold cancel


RestClient CookieContainer always empty  after response that sets cookies

Hi, I have a question about CookieContainer.
Maybe i'm doing something wrong but in latest version of restsharp.portable CookieContainer after response that sets cookies always empty. In previous version all worked fine.
Thanks)

Which version exactly? 2.4.3 or the 3.0 alpha?

2.4.3

I added a unit test for this issue in the commit 1cc962ac75fdde58bc1f38dd01514834c866f6dd and I was unable to reproduce the problem.

Maybe you can provide a test case where I can see the problem?

i'v tried to get cookies from restclient.CookieContainer, not from response.Data.Cookies. Thanks)

So did I as you can see here

Thanks now i see where i'v made mistake now i fixed it and all works fine.Sorry for disturb.

No problem :smile: . Glad that I could help you.


Bump dependencies versions

@jordigh Thanks for your review. Do you wait for another review before merging?
Otherwise I do not have the rights to merge myself.

@fflorent I need to first verify deploying to our own Grist SAAS before I merge.

@jordigh Sounds good! :+1:

Thanks for your patience. After some internal testing, we are satisfied with the state of this PR.


Cant' deploy service with service configuration that was generated via DB introspection

Describe the bug
I'm trying to deploy a service where the data model was generated via introspection, the DB is hosted on Heroku.
Here is my Docker Compose file for the Prisma server (was generated by prisma init -> Use existing database):
version: '3'
services:
  prisma:
    image: prismagraphql/prisma:1.14
    restart: always
    ports:
    - "4466:4466"
    environment:
      PRISMA_CONFIG: |
        port: 4466
        # uncomment the next line and provide the env var PRISMA_MANAGEMENT_API_SECRET=my-secret to activate cluster security
        # managementApiSecret: my-secret
        databases:
          default:
            connector: postgres
            host: ec2-174-129-247-1.compute-1.amazonaws.com
            port: '5432'
            database: daanchftb1sji4
            schema: public
            user: ikijzbkoakrlql
            password: __PASSWORD__
            migrations: false

This is the generated data model:
type User @pgTable(name: "User") {
  id: Int! @unique
  name: String!
}

This is the output when trying to deploy the service:
~/D/passive-test $ prisma deploy
Deploying service `default` to stage `default` to server `local` 82ms

Errors:

  User
    ✖ The field `id` is reserved and has to have the format: id: ID! @unique or id: UUID! @unique.

Deployment canceled. Please fix the above errors to continue deploying.
Read more about deployment errors here: https://bit.ly/prisma-force-flag

Here is wha the DB schema public looks like:

To Reproduce

Setup a new Postgres DB on Heroku
Add a User table with id and name (see Postico screenshot above)
Run prisma init and select Use existing database
Provide your DB connection details (afterwards the service configuration and Docker Compose file are generated)
Run prisma deploy

Expected behavior
I expect the Prisma service to be available on the Prisma server.

@nikolasburk : Can you please provide the SQL of Postgres schema that was introspected? I am particularly interested in the SQL field type of the id column. Thanks!

A hunch is that server is not running in passive mode and this could be a configuration issue. We will revisit this soon.

As for your first point, this happens when using A beta CLI version and is documented here: https://github.com/prismagraphql/prisma/issues/2577. Currently, this requires a manual update of the string.

At the moment, the problem remains.
prisma/1.29.1 (linux-x64) node-v11.10.0

DDL schema
CREATE TABLE product (
  id         serial PRIMARY KEY UNIQUE
, product    text NOT NULL
);

CREATE TABLE bill (
  id       serial PRIMARY KEY UNIQUE
, bill     text NOT NULL
);

CREATE TABLE bill_product (
  bill_id    int REFERENCES bill (id) ON UPDATE CASCADE ON DELETE CASCADE
, product_id int REFERENCES product (id) ON UPDATE CASCADE
, some_other_column text NOT NULL
);

To Reproduce
https://www.prisma.io/docs/datamodel-and-migrations/introspection-POSTGRES-soi1/
help me please !!!


Lsd long output is not properly aligned

os: Linux kali 6.6.15-amd64 #1 SMP PREEMPT_DYNAMIC Kali 6.6.15-2kali1 (2024-05-17) x86_64 GNU/Linux (also observed on Ubuntu under WSL)
lsd --version: 1.1.2 (also observed with 1.0.0)
echo $TERM: tmux-256color (also observed with alacritty)
echo $LS_COLORS: (empty)

Expected behavior
The output should be properly aligned as it is with vanilla ls.

Actual behavior
The output is not aligned properly.

I'm having same issue on OSX Terminal.app
But it worked good when I put --color=never.

is there any chance I can reproduce this?

I have this bug too, it reproduces easily macOS and Linux on every folder I've tried.

same issue. version 1.1.2, installed today with
cargo install --git https://github.com/lsd-rs/lsd.git --branch master

KDE Neon (Ubuntu) 6.0
Plasma 6.1.2
KDE Framework 6.3.0
Qt 6.7
Kernel 6.5.0-41-generic 64bit
Wayland
terminal: Kitty 0.21.2
font: Fira Code Nerd Font Mono Regular

@efvincent Add --locked to your command and the issue will go away

@efvincent Add --locked to your command and the issue will go away

That did it... didn't notice the related issue that had the answer - thanks for pointing it out! 👍🏽

Hi,
just to add another data point.  In my case I get the directories to be misaligned with the files or is it the other way around 😕
lsd --version
lsd 1.1.2

❯ lsd
.rw-r--r--    larkins larkins  10 KB Fri Jul  5 10:49:45 2024  dot_alias
.rw-rw----    larkins larkins 4.5 KB Tue Jul 16 12:15:09 2024  dot_bashrc.common
drwxr-xr-x larkins larkins 4.0 KB Fri Jul  5 10:49:45 2024  dot_cargo
drwxr-xr-x larkins larkins 4.0 KB Fri Jul  5 10:49:45 2024  dot_config
.rw-r--r--    larkins larkins  19 KB Tue Jul 16 12:11:09 2024  dot_gdbinit
.rw-r--r--    larkins larkins 8.3 KB Tue Jul 16 12:12:17 2024  dot_gitconfig
.rw-r--r--    larkins larkins 910 B  Fri Jul  5 10:49:45 2024  dot_gotz.config.json
.rw-r--r--    larkins larkins  52 B  Fri Jul  5 10:49:45 2024  dot_inputrc
.rw-r--r--    larkins larkins 1.3 KB Fri Jul  5 10:49:45 2024  dot_screenrc
.rw-r--r--    larkins larkins 125 B  Fri Jul  5 10:49:45 2024  dot_tigrc
.rw-r--r--    larkins larkins  13 KB Tue Jul 16 12:02:48 2024  dot_tmux.conf
.rw-r--r--    larkins larkins 967 B  Fri Jul  5 10:49:45 2024  dot_toprc
.rw-rw----    larkins larkins  17 KB Tue Jul 16 12:19:56 2024  dot_vimrc
.rw-rw----    larkins larkins 409 B  Fri Jul  5 15:38:28 2024  README.md

I recompiled the same version with --locked and the issue went away
❯ lsd
.rw-r--r-- larkins larkins  10 KB Fri Jul  5 10:49:45 2024  dot_alias
.rw-rw---- larkins larkins 4.5 KB Tue Jul 16 12:15:09 2024  dot_bashrc.common
drwxr-xr-x larkins larkins 4.0 KB Fri Jul  5 10:49:45 2024  dot_cargo
drwxr-xr-x larkins larkins 4.0 KB Fri Jul  5 10:49:45 2024  dot_config
.rw-r--r-- larkins larkins  19 KB Tue Jul 16 12:11:09 2024  dot_gdbinit
.rw-r--r-- larkins larkins 8.3 KB Tue Jul 16 12:12:17 2024  dot_gitconfig
.rw-r--r-- larkins larkins 910 B  Fri Jul  5 10:49:45 2024  dot_gotz.config.json
.rw-r--r-- larkins larkins  52 B  Fri Jul  5 10:49:45 2024  dot_inputrc
.rw-r--r-- larkins larkins 1.3 KB Fri Jul  5 10:49:45 2024  dot_screenrc
.rw-r--r-- larkins larkins 125 B  Fri Jul  5 10:49:45 2024  dot_tigrc
.rw-r--r-- larkins larkins  13 KB Tue Jul 16 12:02:48 2024  dot_tmux.conf
.rw-r--r-- larkins larkins 967 B  Fri Jul  5 10:49:45 2024  dot_toprc
.rw-rw---- larkins larkins  17 KB Tue Jul 16 12:19:56 2024  dot_vimrc
.rw-rw---- larkins larkins 409 B  Fri Jul  5 15:38:28 2024  README.md

Same issue here, as describes ehwan, in kitty 0.35.0 on Ubuntu 22.04. --locked not working. Built from source : lsd 1.1.3.
> .cargo/bin/lsd --locked
error: unexpected argument '--locked' found

  tip: a similar argument exists: '--blocks'

Usage: lsd <FILE|--all|--almost-all|--color <MODE>|--icon <MODE>|--icon-theme <THEME>|--classify|--long|--ignore-config|--config-file <PATH>|--oneline|--recursive|--human-readable|--tree|--depth <NUM>|--directory-only|--permission <MODE>|--size <MODE>|--total-size|--date <DATE>|--timesort|--sizesort|--extensionsort|--gitsort|--versionsort|--sort <TYPE>|--no-sort|--reverse|--group-dirs <MODE>|--group-directories-first|--blocks <BLOCKS>|--classic|--no-symlink|--ignore-glob <PATTERN>|--inode|--git|--dereference|--context|--hyperlink <MODE>|--header|--truncate-owner-after <NUM>|--truncate-owner-marker <STR>|--system-protected|--literal|--help>

@pj-connect --locked is a compile time flag, not a runtime flag

@pj-connect can you try the binary on github release page

I have merged https://github.com/lsd-rs/lsd/pull/1064, let's see if v1.1.5 helps

FWIW, this might be https://github.com/unicode-rs/unicode-width/issues/55. Adding --locked uses its "locked" version, 0.1.11, which is before the problematic 0.1.13.

this should now be fixed in 1.1.5
/close