Doubts and help to replicate wiki methods

Hi, I'm currently studying some of the proposed methods found in your code,
however, I find some difficult to replicate some of your stated tests.
Here is the implemented code:
`import cv2
import polanalyser as pa
import matplotlib.pyplot as plt
import NumPy as np
def normarize(image, dtype=np.uint8, gamma=2.2):
"""
Thie function processes image for exporting.
1. apply gamma
2. clip
3. convert dtype
"""
max_val = np.iinfo(dtype).max if (dtype==np.uint8 or dtype==np.uint16) else np.finfo(dtype).max
img_gamma_applied = ((image/max_val)**(1.0/gamma))*max_val
img_normarized = np.clip(img_gamma_applied, 0, max_val).astype(dtype)
return img_normarized
img_raw = cv2.imread('.../dataset/spoons.png',0)
img_demosaiced = pa.demosaicing(img_raw)
fig=plt.figure(figsize=(8, 8))
for i in range(0,4):
fig.add_subplot(1, 4, i+1)
plt.imshow(img_demosaiced[:,:,i],cmap='gray')
plt.title('Img_'+str(i))
plt.axis('off')
plt.show()
radians = np.array([0, np.pi/4, np.pi/2, np.pi*3/4])
img_stokes = pa.calcStokes(img_demosaiced, radians)
img_S0, img_S1, img_S2 = cv2.split(img_stokes)
img_intensity = pa.cvtStokesToIntensity(img_stokes)
img_DoLP      = pa.cvtStokesToDoLP(img_stokes)
img_AoLP      = pa.cvtStokesToAoLP(img_stokes)
img_Imax = pa.cvtStokesToImax(img_stokes)
img_Imin = pa.cvtStokesToImin(img_stokes)
dtype_raw = img_raw.dtype
plt.subplot(331)
plt.axis('off')
plt.subplot(332)
plt.imshow(normarize(img_intensity, dtype_raw),cmap='gray')
plt.title('Int')
plt.axis('off')
plt.subplot(333)
plt.imshow(normarize(img_DoLP*255, np.uint8,gamma=1),cmap='gray')
plt.title('DoLP')
plt.axis('off')
plt.subplot(334)
plt.imshow(pa.applyColorToAoLP(img_AoLP))
plt.title('AoLP')
plt.axis('off')
plt.subplot(335)
plt.imshow(pa.applyColorToAoLP(img_AoLP, saturation=img_DoLP))
plt.title('AoLP(Hue) + DoLP(Saturation)')
plt.axis('off')
plt.subplot(336)
plt.imshow(pa.applyColorToAoLP(img_AoLP, value=img_DoLP))
plt.title('AoLP(Hue) + DoLP(Value)')
plt.axis('off')
plt.subplot(337)
plt.imshow(normarize(img_Imin, dtype_raw),cmap='gray')
plt.title('Imin')
plt.axis('off')
plt.subplot(338)
plt.imshow(normarize(img_Imax, dtype_raw),cmap='gray')
plt.title('Imax')
plt.axis('off')
plt.subplot(339)
plt.imshow(normarize((img_Imax-img_Imin), dtype_raw),cmap='gray')
plt.title('Specular')
plt.axis('off')
plt.suptitle(str((np.sum(img_DoLP)/(img_DoLP.shape[0]*img_DoLP.shape[1]))))
plt.show()`
Some of the problems I'm facing are obtaining the specular and diffuse reflections as you can see in line 81, I attempt to obtain it however,
I suppose this is wrong. If you see the attached picture is the result of the image of the spoon located on your dataset. As you can see the generated image of the AoLP has a different colourmap than the test located in the wiki, any suggestion about the issue?
Moreover, in line 84, you can see a little estimation of a coefficient of the DoLP, I'm assumpting that the \frac{\sum{DoLP_{values}}}{\#pixels} based on:

Degree of Linear Polarization (DoLP) represents how much the light is polarized. The value is 1 for perfectly polarized light and 0 for unpolarized light. The angle of Linear Polarization (AoLP) represents the polarization angle of the incident light relative to the camera sensor axis. The value ranges from 0 to 180 degrees.

since I'm currently working on an image taken from a polarized or not polarized light those images are compressed, so the question is the DoLP and AoLP are affected by compression such as JPEG?
Also, I'm assuming that the values of the AoLP of the statement are pixel-wise, I'm right?
Finally, let me thank you for share this work and hoping to hear from you...

@elerac, thanks for your quick reply, I corrected the last image with your advice, now I think I had the correct response, please see the attached images.
Also, I find that the gamma correction launch a Warning:

/.../polat.py:14: RuntimeWarning: invalid value encountered in power
img_gamma_applied = ((image/max_val)**(1.0/gamma))*max_val

Since I'm using the scikit-image gamma function I suggest rewriting the used function.

Any other questions?

A lot really, since this is not my area of expertise there are some doubts about the polarization methods. Let me list some of it, also if you could provide a good source to begin will be great!!

So the AoLP and DoLP are pixel-wise if you build a coefficient of AoLP or DoLP should be stated as

or in other words np.sum(img_DoLP)/img_DoLP.size if the obtained value is near 0 means the light is unpolarized and nearby 1 is polarized (if you are doing research you could add this approximation) in the case of DoLP and ((np.sum(img_AoLP)/img_AoLP.size)*(180/(np.pi))) to obtain the AoLP of all image, the idea is obtain the type of polarization and angle.

For this, I post some images from the dataset to obtain the polarization angle and degree.
To obtain the specular and diffuse reflections I attempt to do the following (img_Imax-img_Imin) is this correct?
Thanks for your kind support and help.

I don't know if that's a question you really want to ask, but I'll answer it.

To obtain the specular and diffuse reflections I attempt to do the following (img_Imax-img_Imin) is this correct?

Yes! The specular component is Imax-Imin and the diffuse component is Imin. You can use  cvtStokesToSpecular and  cvtStokesToDiffuse to get the same result.

if you could provide a good source to begin will be great!!

I am not an expert in all areas of polarization, but here are some good resources for beginners in the field of polarization in computer vision.

Beyond Conventional Imaging: Sony's Polarized Sensor (LUCID) will help you to visually understand how polarization is used in machine vision.
You can learn more basic principles and applications of polarization in computer vision from lecture presentations of Physics based Methods in Vision, Spring 2016.

Thanks for your response, I will review the stated literature to begin, I had a final question for you and close the initial issue.
Let's suppose we have an image of an object to be specific a sample from a microscope, this image has been taken from a common digital camera we assume that the taken picture is 90 degrees from the object. But, We want to know first if the light used in that photo is polarized (90 degrees) or not (0 degrees), if it is not polarized we need to recreate or estimate the polarized image. So the question is if we can get the estimated image from the Stokes Matrix or we need to use the Muller Matrix.
In advance, thanks for the provided help.

What you want to do is find out whether the light is polarized or not.
As you may know, Imax-Imin (Specular) contains the polarized component, and Imin (Diffuse) contains the unpolarized component. Therefore, in my opinion, it is enough to get the Stokes vector, and the Mueller matrix is not necessary.

Thanks for your kind support, @elerac expecting to contribute if other issues are found, meanwhile this issue and doubts had been solved.
Thanks a lot


Error when column is reserved keyword

Describe the bug
When a column is a reserver keyword (such as 'time'), I get "Invalid FilterExpression: Attribute name is a reserved keyword; reserved keyword: time"
To Reproduce

Create a table with primary key named time
Select the "time" column condition in records window.
Press SCAN

Expected behavior
No error should occur
Desktop (please complete the following information):
MacOS 10.14.4

I hit the same issue. I haven't looked at the source yet but it's related to using project-expression-names to set the value of the expression to use within the actual projection-expression:
https://docs.aws.amazon.com/amazondynamodb/latest/developerguide/Expressions.ExpressionAttributeNames.html

This is a really annoying bug. Any solution so far?

How about the possibility to define "aliases" as ExpressionAttributeNames?
https://stackoverflow.com/a/36712485

Any update on this issue?


Add theme pehtheme-hugo-lite

My first Hugo theme build with TailwindCSS.

Hi @fauzanmy. Your theme looks great. But you don't have to create a pull request (PR) with all your theme files.
Since it's your first time creating a Hugo theme, I recommend you to go through the README of this repository.
Looking at previous PRs might be helpful for you as well.

Hi @fauzanmy.
Here are the steps that you have to take to add your theme to the list:

Create a fork of this repository
Just have to add your theme's URL in the themes.txt file.
Commit and push to your fork
Create a pull request

I am closing this pull request since, you have included your theme files as well.
Feel free to ask any questions if you are unable to figure out something.


v1.3.0 update ze readme

tiny doc updates
Closes #69
Closes #74

This change is

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @jethror1)

README.md line 46 at r1 (raw file):

The assay config file for the conductor app is designed to be written as a JSON file, with each workflow or apps defined as an executable. For each workflow/app, there are several required and optional keys to add, with a required structure. An example empty template and populated config file may be found [here](example/config_template.json) and [here](example/example_populated_config.json) respectively.

In addition, a GitHub repository of more full production config files may be found [here](https://github.com/eastgenomics/eggd_conductor_configs).

of more full?

me do bad english


Add TextBuffer fnct and others

Add TextBuffer fnct and others:
enum:
CornerType is a representation of GTK's GtkCornerType.
TextSearchFlags is a representation of GTK's GtkTextSearchFlags.
functions:
gtk_text_buffer_get_has_selection
gtk_text_buffer_get_selection_bound
gtk_text_buffer_get_selection_bounds
gtk_text_buffer_get_iter_at_line_offset
gtk_text_buffer_create_tag
gtk_text_buffer_remove_tag_by_name
gtk_text_buffer_register_serialize_tagset
gtk_text_buffer_register_deserialize_tagset
gtk_text_buffer_serialize
gtk_text_buffer_deserialize
gtk_text_buffer_get_insert
gtk_text_buffer_copy_clipboard
gtk_text_buffer_cut_clipboard
gtk_text_buffer_paste_clipboard
gtk_text_buffer_add_selection_clipboard
gtk_text_buffer_remove_selection_clipboard
Update text_iter search
enum: already added in gtk.go
functions:
gtk_text_iter_forward_search
gtk_text_iter_backward_search
Add TextBuffer fnct 3.16
function:
gtk_text_buffer_insert_markup
PS.
I take advantage that nothing is already merged to gather all this in one pull-request.
Regards.

@Bios-Marcel
Hi, I noticed that you merged the commit #401 from: @Aarccoza, but not mine.
I did something wrong with this commit?
If so, could you explain to me what I need to do to solve this problem?
I have some other binding features to submit, but if I'm on the wrong way, I'd like to fix the problem before submitting to merge to avoid wasting your time.
Thank.
Sincerely, H.F.M

No, I just didn't look at it yet. I have a ton of open issues and things to do, not omly in gotk3. I simply lack the motivation to do stuff every day / week.
But anyway, you closed your other PRs and made one big PR. You should avoid that if possible, so that small chunks can be merged instead of a big inseperable chunk.

No, I just didn't look at it yet. I have a ton of open issues and things to do, not omly in gotk3. I simply lack the motivation to do stuff every day / week.

Ok, I understand, it's summer :) ...

But anyway, you closed your other PRs and made one big PR. You should avoid that if possible, so that small chunks can be merged instead of a big inseperable chunk.

Ouch ...
Do I have to do all the work again and split it 1 by 1 instead ? :(
Anyway, next time I'll take care of this detail.

Just a small thing, shouldn't PastClipboard() be called PasteClipboard() or is there as reason for this change?

Just a small thing, shouldn't PastClipboard() be called PasteClipboard() or is there as reason for this change?

No reason, just a mistake ... many thanks for revealing this.

@Bios-Marcel
Hi,
As mentioned before, I've done some examples using these and other functions published here, the time has passed and I finally found a way to make these pieces of code accessible to others until you can merge the commits.
I made a clone of your library that contains my commits and a simple way to switch between the official gotk3 library and my cloned version without modifying anything in the original source files.
I put here the link to my example repository:
https://github.com/hfmrow/misc
I hope it's ok for you about this cloned repository.
regards.

see the spitted PR from @hfmrow

see the spitted PR from @hfmrow

Sorry I don't understand correctly (bad English)
I have made a mistake (with cloned repos) or miss something ?
Why you haven't merged this part ?
thank for explanation.

Oh, it's okay. The course of the conversation no longer fits the current "smaller" changes.

@hfmrow can you fix the merge conflict?

I try to understand conflict reasons (not only for this PR but for all with conflict) and I cannot find anything ...
I will try again, if i can't , I will delete and make new PR ....

all the functions have been redone and put in PR
so, I close this PR since i cannot understand why there is conflicting now and not one month ago ...
Anyway, all must be ok now (I hope)


fix maximize window not working for Ryu

So this didn't work right?

nope

So this didn't work right?

So this didn't work right?

Nope


retraining AE case study with updated prior on mean_sources and flux

Closes #508

[ ] check how probabilities are calculated, at least one is wrong in one of the blend images

wil create another PR and revive later


chore: add actor upgrades to deploys

Fixes RVT-4233

[!WARNING]
This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

#1543  👈 (View in Graphite)
#1542
#1541
#1539
#1535 : 1 other dependent PR (#1538 )
main

This stack of pull requests is managed by Graphite. Learn more about stacking.


Covariance and contravariance in generic types

(spawned from #1294)
Motivating example:
class Base
end

class Child < Base
end

def enumerable_base(x : Enumerable(Base))
end

def array_base(x : Array(Base))
end

base_ary = Array(Base).new
child_ary = Array(Child).new

# Which of the following methods should give an error?
enumerable_base(base_ary)
array_base(base_ary)
enumerable_base(child_ary)
array_base(child_ary)

The questions are:
# 1.
Array(Base).new.is_a?(Enumerable(Base))
Array(Base).new.is_a?(Array(Base))

There are true, not a lot to discuss here.
# 2.
Array(Child).new.is_a?(Enumerable(Base))

This is a bit more difficult to answer. The thing is, you read from an enumerable, you don't put things inside it. So this question should be true, because Child.new.is_a?(Base).
# 3.
Array(Child).new.is_a?(Array(Base))

Now, Child.new.is_a?(Base), but if the above is true, say we replace Array(Child).new with exp, we get:
exp.is_a?(Array(Base)) #=> true

Good, it's an Array(Base) so lets put some elements into it:
exp << Base.new # ERROR

Oops, but exp was Array(Child), we can't put a Base inside it. So maybe the answer to is_a? should be false here.
So, we have two cases of Child vs. Base in generic types, and in one case we'd like the answer to be true and in another one we'd like it to be false.
The "solution" is to mark the T in Enumerable as covariant. In C# they do it like IEnumerable<out T>. There's also in. I think in Scala they use + and -. And, as far as I know, these are difficult to grasp. So, we'll go from an untyped language (Ruby) to a language with some type annotations (generic types, captured blocks), to a language with covariance/contravariance type annotations. I'm not sure I like that idea, but we'll see.
The way it works right now is that Array(Child).is_a?(Array(Base)) will give false, but the call array_base(child_ary) succeeds. And, as long as you only read from the array, everything will compile fine. So, in a way, this is safe, but maybe not very intuitive.
We should decide what to do with this.

So, its a good thing to allow more programs to succeed the type checker if they would be able to run without type restrictions. That's the half of the whole point. (The other half is not make the type system catch all program that would fail in runtime)
With this in mind, allowing Enumerable(T) <: Enumerable(S) when T <: S is a good thing. Specifying per generic param if its <, = or > regarding subtyping rules is an easy way to express them.
But, as we discussed IRL. This will affect the method lookup / is_a? results.
Crystal, due to how class/methods/macros are expanded does not follow some rules as other languages.
That is, type restriction plays in choosing the method but does not restrict which methods can be called. Sounds tricky.
Compare:
http://play.crystal-lang.org/#/r/cyq
http://play.crystal-lang.org/#/r/cyr
So, allowing covariance/contravariance, at least in the first stage, might be "only" about method type restriction. I'm a bit uncertain about the following steps.

Wouldn't something like protocols be an alternative solution?

If your use case doesn't require thinking about variance/covariance, you just keep using your generics as they are today.

If you need to mix different (but related) things inside a generic without resorting to unions (which as far as I understand is the motivation behind exploring this feature), you define a protocol and use that to type the generic. Crystal would be able to check that a given type conforms to a protocol, so as long as you only push instances of types that conform you'd be safe.

I worked mostly with Java and Scala so I am used to using types and relying on them. I can understand that when you come from dynamic languages the approach can be different. (That's why type inference is a great thing) For me, however, having types and inheritance implies that you can rely on them.
Java handled variance in generics by making them invariant.
In Scala as @asterite mentioned there are + and - for denoting covariance and contravariance of type parameter. Invariance is default.
From what I've seen so far in Crystal (and I don't know the whole language yet) type arguments of generics are covariant.
One of more interesting cases where this is not good are functions:
Say you have a function that takes as an argument function from type A to type B
def foo(funct: A -> B)
From signature it's pretty clear that what you expect inside foo is

pass any value that is_a?(A) and
receive value that is_a?(B).

More interesting is the question: what I can pass to foo as funct? or more precisely:
what is_a?(A->B)?
If in A -> B A and B are invariant - it's A ->B only. This is quite restrictive.
If we want to use variance then the it would be good if we could pass any A* -> B* where A < A* (contravariant A) and B* < B (covariant B). Then requirements from foo are still satisfied as

for every input is_a?(A) => is_a?(A*) - passed function will be able to handle it
for every output is_a?(B*) => is_a?(B) - returned value is of expected type.

Currently in Crystal it's not possible and due to covariance on input you can actually pass A*-> B where A* < A and fail compilation on missing method if someone passes value of type A.
I wonder if it will fail if foo would be in a library.
http://play.crystal-lang.org/#/r/d0z
Actually it gets even crazier as Child->Child fails is_a?(Parent->Parent) test but you can still pass it to foo(Parent->Parent). Is this another bug?
So my point is that Crystal already has covariance and this does not work in every case as a person with typed language background would expect it to. So I would suggest approach similar to Scala if it's possible.

+1 for + and - annotations

I was thinkg of using < and > for annotations.
So
class Foo(A<)
end

corresponds to covariance
        A < B
---------------------
   Foo(A) < Foo(B)

And
class Foo(A>)
end

corresponds to contravariance
        A > B                              B < A
---------------------       =      ---------------------
   Foo(A) < Foo(B)                    Foo(A) < Foo(B)

I think +/- is better than in/out thou. But I find >/< more straight forward to the semantics.

Sure, that works too.

I support @asterite!  There is little point in Crystal becoming a "Scala with Ruby syntax" ;-).
Somehow, most programmers think about only reading, when they think of covariance.  And then get tripped by it in endless ways.  In my limited experience, variance is one of the darkest corners of type systems.
If you haven't already seen them, I highly recommend that you watch:

Paul Philips' 2014 talk at LinkedIn (on Scala's collections; he talks a good deal about variance), and
Andrei Alexandrescu's talk at DConf 2015 (about what he called "Design by Introspection").

I request you all to consider a combination of:

type bounds on generic parameters,
separating modules from the class hierarchy (lateral look-up path vs. vertical look-up path), and
normal boolean logic on the above at the time of generic type specification.

Such a combination can address a vast majority of scenarios, without introducing covariance and contravariance.
Remember that a departure from invariance is a one way ticket.  It taints the language and a lot of the standard library irrevocably!

@js-ojus As I already pointed out Crystal is not invariant ATM.
As for Paul Phillips' talk - I would recommend checking every point he makes if it's really valid. There are things worth taking into consideration while in other places he is just incorrect eg. trying to prove that map on Set works incorrectly by using functions with side effects in his example.

@whorbowicz Yes, I realise that Crystal currently has some covariance.  The question that I was trying to surface was: should Crystal embrace invariance or continue down the path to full covariance/contravariance?
We have to remember that covariance is unsound, unless everything is contravariant on the input side and covariant on the output side.  Else, we leak, and become unsound.  This is one of the biggest reasons why delegates in C# are contravariant in their input types.
And, we only need a glance at StackOverflow to see thousands of C# programmers who got tripped by the above.
Also, there is nothing wrong with invariance and existential types.  It has been proved formally to be sound (e.g. Igarashi and Viroli).  Torgersen, Ernst and Hansen's paper "Wild FJ" is a good read, as well.
On the second point, I did not mean to imply that everything that Paul Phillips said was correct :-).  Nonetheless, I am curious about what you say.  Could you point to the specific example of map over a set that you think was incorrect?  Thanks.

@js-ojus I'll give you the details, but let's move this subject to some private channel (eg. G+) - we are drifting away from the topic. :)

For notation the <, > makes sense. However, @js-ojus makes some good points. Generics type bounds and 'concept'-like features could be more helpful practically.

Closed in favor of #2665


how will they be automatically downloaded to Image Diffusion, Audio Diffusion, Video Diffusion?

when execute bash scripts/app.sh, the 3 models were not be automatically downloaded.

according to code/config/base.yaml
downloading the 3 models by myself.

In which directory should I put 3 models after I download them?

@eeric @shiprainJ Same question. In which directory did you put the 3 models after downloading them?


Node dies with "store counter too low" during catchup

2016-09-01 11:18:57 571875 +0200 - perf-roub-03 - 34126/0 - arakoon - 9903 - info - remote_nodestream :: last_seen = Some ("8411362")
2016-09-01 11:18:57 571905 +0200 - perf-roub-03 - 34126/0 - arakoon - 9904 - info - loop_parts done
2016-09-01 11:18:57 571919 +0200 - perf-roub-03 - 34126/0 - arakoon - 9905 - info - catchup_tlog completed
2016-09-01 11:18:57 571929 +0200 - perf-roub-03 - 34126/0 - arakoon - 9906 - info - CATCHUP phase 1 done (until_i = 8411362); now the store
2016-09-01 11:18:57 571933 +0200 - perf-roub-03 - 34126/0 - arakoon - 9907 - info - replaying log to store

2016-09-01 11:25:34 297698 +0200 - perf-roub-03 - 34126/0 - arakoon - 9950 - info - catchup_store completed, store is @ Some ("8408409")
2016-09-01 11:25:34 297759 +0200 - perf-roub-03 - 34126/0 - arakoon - 9951 - fatal - Exception in fsm thread: Catchup.StoreCounterTooLow("Catchup store failed. Store counter is too low: 8408409 < 8411362"); backtrace:; Raised at file "bytes.ml", line 219, characters 25-34; Called from file "string.ml", line 106, characters 2-26
2016-09-01 11:25:34 297794 +0200 - perf-roub-03 - 34126/0 - arakoon - 9952 - fatal - [rc=41] Store counter too low: Catchup store failed. Store counter is too low: 8408409 < 8411362
2016-09-01 11:25:34 297892 +0200 - perf-roub-03 - 34126/0 - arakoon - 9953 - info - waiting for 1 client_threads

at the same time it was also doing a collapse:
2016-09-01 09:16:22 804865 +0200 - perf-roub-03 - 34126/0 - arakoon - 8562 - info - ... Start collapsing ... (n=2)
2016-09-01 09:16:22 804879 +0200 - perf-roub-03 - 34126/0 - arakoon - 8563 - info - Starting collapse
2016-09-01 09:16:22 805625 +0200 - perf-roub-03 - 34126/0 - arakoon - 8566 - info - Going to collapse 371 tlogs
...
2016-09-01 11:13:03 478336 +0200 - perf-roub-03 - 34126/0 - arakoon - 9852 - info - Completed replay of 3886.tlx, took 33.101315 seconds, 84 to go
2016-09-01 11:13:41 398694 +0200 - perf-roub-03 - 34126/0 - arakoon - 9856 - info - Completed replay of 3887.tlx, took 37.920212 seconds, 83 to go
2016-09-01 11:14:18 528197 +0200 - perf-roub-03 - 34126/0 - arakoon - 9859 - info - Completed replay of 3888.tlx, took 37.129387 seconds, 82 to go
2016-09-01 11:14:51 625402 +0200 - perf-roub-03 - 34126/0 - arakoon - 9863 - info - Completed replay of 3889.tlx, took 33.097096 seconds, 81 to go
2016-09-01 11:15:25 910810 +0200 - perf-roub-03 - 34126/0 - arakoon - 9865 - info - Completed replay of 3890.tlx, took 34.285292 seconds, 80 to go
2016-09-01 11:15:57 624861 +0200 - perf-roub-03 - 34126/0 - arakoon - 9875 - info - Completed replay of 3891.tlx, took 31.713918 seconds, 79 to go
2016-09-01 11:16:31 939269 +0200 - perf-roub-03 - 34126/0 - arakoon - 9879 - info - Completed replay of 3892.tlx, took 34.314290 seconds, 78 to go
2016-09-01 11:17:07 843194 +0200 - perf-roub-03 - 34126/0 - arakoon - 9881 - info - Completed replay of 3893.tlx, took 35.903797 seconds, 77 to go
2016-09-01 11:17:40 516819 +0200 - perf-roub-03 - 34126/0 - arakoon - 9885 - info - Completed replay of 3894.tlx, took 32.673508 seconds, 76 to go
2016-09-01 11:18:16 689074 +0200 - perf-roub-03 - 34126/0 - arakoon - 9897 - info - Completed replay of 3895.tlx, took 36.172111 seconds, 75 to go
2016-09-01 11:18:52 52456 +0200 - perf-roub-03 - 34126/0 - arakoon - 9901 - info - Completed replay of 3896.tlx, took 35.363241 seconds, 74 to go
2016-09-01 11:18:57 571933 +0200 - perf-roub-03 - 34126/0 - arakoon - 9907 - info - replaying log to store
2016-09-01 11:19:25 773770 +0200 - perf-roub-03 - 34126/0 - arakoon - 9909 - info - Completed replay of 3897.tlx, took 33.721211 seconds, 73 to go
2016-09-01 11:20:01 682825 +0200 - perf-roub-03 - 34126/0 - arakoon - 9919 - info - Completed replay of 3898.tlx, took 35.908912 seconds, 72 to go
2016-09-01 11:20:36 179315 +0200 - perf-roub-03 - 34126/0 - arakoon - 9923 - info - Completed replay of 3899.tlx, took 34.496399 seconds, 71 to go
2016-09-01 11:21:10 893929 +0200 - perf-roub-03 - 34126/0 - arakoon - 9925 - info - Completed replay of 3900.tlx, took 34.714481 seconds, 70 to go
2016-09-01 11:21:43 904766 +0200 - perf-roub-03 - 34126/0 - arakoon - 9929 - info - Completed replay of 3901.tlx, took 33.010727 seconds, 69 to go
2016-09-01 11:22:18 955609 +0200 - perf-roub-03 - 34126/0 - arakoon - 9931 - info - Completed replay of 3902.tlx, took 35.050726 seconds, 68 to go
2016-09-01 11:22:53 467596 +0200 - perf-roub-03 - 34126/0 - arakoon - 9935 - info - Completed replay of 3903.tlx, took 34.511855 seconds, 67 to go
2016-09-01 11:23:26 803493 +0200 - perf-roub-03 - 34126/0 - arakoon - 9937 - info - Completed replay of 3904.tlx, took 33.335801 seconds, 66 to go
2016-09-01 11:24:00 434317 +0200 - perf-roub-03 - 34126/0 - arakoon - 9941 - info - Completed replay of 3905.tlx, took 33.630692 seconds, 65 to go
2016-09-01 11:24:35 546330 +0200 - perf-roub-03 - 34126/0 - arakoon - 9944 - info - Completed replay of 3906.tlx, took 35.111882 seconds, 64 to go
2016-09-01 11:25:09 159430 +0200 - perf-roub-03 - 34126/0 - arakoon - 9948 - info - Completed replay of 3907.tlx, took 33.612957 seconds, 63 to go

After upstart restarted the process it was running fine again.

(arakoon 1.9.9)

arakoon version: 1.9.10
same issue on flash_roub_nsm_1. (perf-roub-03)
2016-09-02 16:46:20 106874 +0200 - perf-roub-03 - 7636/0 - arakoon - 11812 - info - Replaying tlog file: 3782.tlx [11387316,...] (3331/3390)
2016-09-02 16:46:21 627968 +0200 - perf-roub-03 - 7636/0 - arakoon - 11813 - info - catchup_store completed, store is @ Some ("11616668")
2016-09-02 16:46:21 628024 +0200 - perf-roub-03 - 7636/0 - arakoon - 11814 - fatal - Exception in fsm thread: Catchup.StoreCounterTooLow("Catchup store failed. Store counter is too low: 11616668 < 11616836"); backtrace:; Raised at file "b
ytes.ml", line 219, characters 25-34; Called from file "string.ml", line 106, characters 2-26
2016-09-02 16:46:21 628062 +0200 - perf-roub-03 - 7636/0 - arakoon - 11815 - fatal - [rc=41] Store counter too low: Catchup store failed. Store counter is too low: 11616668 < 11616836
2016-09-02 16:46:21 628153 +0200 - perf-roub-03 - 7636/0 - arakoon - 11816 - info - going to drop outgoing connection as well: Lwt.Canceled; backtrace:; Raised at file "map.ml", line 122, characters 16-25; Called from file "src/core/lwt.m
l", line 161, characters 4-40
2016-09-02 16:46:21 628175 +0200 - perf-roub-03 - 7636/0 - arakoon - 11817 - info - going to drop outgoing connection as well: Lwt.Canceled; backtrace:; Raised at file "map.ml", line 122, characters 16-25; Called from file "src/conv.ml",
line 190, characters 10-37
2016-09-02 16:46:21 628183 +0200 - perf-roub-03 - 7636/0 - arakoon - 11818 - info - waiting for 2 client_threads
2016-09-02 16:46:21 628194 +0200 - perf-roub-03 - 7636/0 - arakoon - 11819 - info - waiting for 1 client_threads
2016-09-02 16:46:21 629050 +0200 - perf-roub-03 - 7636/0 - arakoon - 11820 - warning - exception while closing, too little too late: Unix.Unix_error(Unix.EBADF, "check_descriptor", ""); backtrace:; Raised at file "src/unix/lwt_unix.ml", l
ine 357, characters 14-68; Called from file "src/unix/lwt_unix.ml", line 602, characters 28-47; Called from file "src/core/lwt.ml", line 686, characters 20-24
2016-09-02 16:46:21 629069 +0200 - perf-roub-03 - 7636/0 - arakoon - 11821 - warning - exception while closing, too little too late: Unix.Unix_error(Unix.EBADF, "check_descriptor", ""); backtrace:; Raised at file "src/unix/lwt_unix.ml", l
ine 357, characters 14-68; Called from file "src/unix/lwt_unix.ml", line 602, characters 28-47; Called from file "src/core/lwt.ml", line 686, characters 20-24
2016-09-02 16:46:21 629806 +0200 - perf-roub-03 - 7636/0 - arakoon - 11822 - info - messaging_<IP_ADDRESS>_1: closing
2016-09-02 16:46:21 629818 +0200 - perf-roub-03 - 7636/0 - arakoon - 11823 - info - messaging_<IP_ADDRESS>_2: closing
2016-09-02 16:46:21 630266 +0200 - perf-roub-03 - 7636/0 - arakoon - 11824 - info - Exception in client thread messaging_<IP_ADDRESS>_1: Lwt.Canceled; backtrace:; Raised at file "map.ml", line 122, characters 16-25; Called from file "src/
core/lwt.ml", line 161, characters 4-40
2016-09-02 16:46:21 630289 +0200 - perf-roub-03 - 7636/0 - arakoon - 11825 - info - Exception in client thread messaging_<IP_ADDRESS>_2: Lwt.Canceled; backtrace:; Raised at file "map.ml", line 122, characters 16-25; Called from file "src/
conv.ml", line 190, characters 10-37
2016-09-02 16:46:21 630305 +0200 - perf-roub-03 - 7636/0 - arakoon - 11826 - info - waiting for 0 client_threads
2016-09-02 16:46:21 630311 +0200 - perf-roub-03 - 7636/0 - arakoon - 11827 - info - shutting down server on port 26413
2016-09-02 16:46:21 630373 +0200 - perf-roub-03 - 7636/0 - arakoon - 11828 - info - Crash log dumped
2016-09-02 16:46:21 812288 +0200 - perf-roub-03 - 527/0 - arakoon - 0 - info - --- NODE STARTED ---

seen on CI environment where it was produced by server.left.test_collapse:test_collapse_during_catchup. Have logs.

#150


Incomplete with react 16.0

Hi,
I've just checked on react 16.0 branch and getting many errors,
at least one about using PropTypes as from separate repo.

Getting ready to merge in #12 which is a dependency upgrade to support React 16, which should correct this issue.

We've got 1.1.4 out now which should correct these issues. I'm going to close this; but feel free to reopen if you're still seeing problems.


Implement hooks

Currently, as each scenario is a new tcl interpreter, we have been using inline tcl to perform setup tasks for our tests. However, as there is no order to the files being sourced, we have hit a few problems with dependencies (e.g. trying to call a proc before it has been initialised).
It would be good if we were able to have before/after hooks to allow us to perform the initialisation in the before hook, knowing that everything has been sourced by that point.
@mattwynne, would this require changes to cucumber to allow hooks to be passed through?
Note - we'd need to consider what scope things are being run in if looking at this.

Hi @jowers.
I think we can do this without any changes to Cucumber. Shall we start with a feature file as usual, where you can sketch out the tcl DSL for defining hooks, and we can work our way in from there?

Hi,
Sounds good. I'm actually going to have a go at issue #28 first as it should be a quick one that is causing a little bit of frustration at the moment, then I'll move onto this one.

Created pull request #33


Consider allowing class={{ }} syntax

Passing an object with class names as keys and truthy/falsy as values allows for some pretty slick JSX:
const selected = selection [key]

Any thoughts?

@robbiewxyz interesting, so selected acts as both a key and value in the case it's true, are the values space split, what if you have hyphen-case?
Maybe you can explain some input -> output (HTML) so I can understand the output easier?
The only potential issue with this, is that it will have a negative effect on performance. It will have a lot more logic to deal with on objects passed through, rather than strings like before.
cc/ @Havunen @nightwolfz

Here's some example cases:
{{ 'list-item': true, 'disabled': false, 'is-selected': true }} => "list-item is-selected"

const notificationClasses = { 'badge-error': true, 'badge-important': false  }
{ 'notification': true, ...badgeClasses } => "notification notification-error"

It's inspired by the https://github.com/JedWatson/classnames tool for React.

What's to stop this from turning into a rebuild of classnames?

A couple reasons not to integrate this functionality into core:

This is would introduce a difference from React, etc. I don't think this is necessarily a bad thing, but unless there's a large benefit I'm not sure the tradeoff is worth it.

import cx from 'classnames'

const selected = selection [key]

is barely more verbose (and arguably more clear, I think) than
const selected = selection [key]

You can use that same plugin on your projects, same way as you do with React. Or simply copy paste or fork his repository to create your own version of it. You can also improve performance of that function by dropping features(that's what I have done)

IMO this does not belong to core

Agreed. Closing :)


feat: upload files in parallel

attempt to upload 100 files at once, with retry logic - this greatly speeds up deployments for large websites such as https://js-compute-reference-docs.edgecompute.app/

@harmony7 what do you think to this?


More Details in User Guide

For example, I find no mention about paired-end RNA sequencing which is the most common kind these days. Also, what about stranded and unstranded protocols? I have BAM files from TCGA and they happen to be an unstranded protocol, sadly. How does the performance compare for poly-A RNA versus total RNA which is ribosome-depleted? Why is Bowtie2 mandatory when it's not designed for RNA-seq data, unlike HISAT2 or STAR?

Dear Dario,
I'll break this issue into a few parts:

no mention about paired-end RNA sequencing

This is now a recurrent issue brought up by multiple users. The current implementation of TeXP only supports single-end data. As I mentioned in previous issues and now at the README, if you have paired-end data you can run TeXP independently on both ends and calculate the average. Empirically, if the library quality is good, P1 and P2 have very similar estimates.

what about stranded and unstranded protocols?

TeXP is completely compatible with unstranded RNA-seq. In fact, I have not tested what is the effect of stranded RNA-seq on TeXP estimations, I'll follow up on this next time I work on updating TeXP

How does the performance compare for poly-A RNA versus total RNA which is ribosome-depleted?

I recommend using polyA+ libraries since those libraries should enrich for mRNA, if only ribo- libraries are available, I expect to see a higher amount of pervasive transcription on the estimations. TeXP should be able to handle both of these libraries.

Bowtie2 mandatory when it's not designed for RNA-seq data, unlike HISAT2 or STAR

I'm not really sure I agree with Bowtie2 not being designed for RNA-seq. Nonetheless, LINE-1 does not contain introns, thus the advantage of HISAT2 or STAR for LINE-1 transcription estimations is questionable.
Figure S15 on TeXP: Deconvolving the effects of pervasive and autonomous transcription of transposable elements also addresses this question. Aligners don't seem to have such a large effect on TeXP estimations. We compared STAR, bowtie2 and BWA. I'm not sure about HISAT2.
Therefore, as long as you allow multiple mapping and do not suppress aligners to report multi-mapping reads, TeXP should work seamlessly.
S15 Figure.pdf

This answers all my confusions well. It's a good point that LINE1 is unspliced.


Bug: npm 7 peer vue dep

bug with install npm 7 without --legacy-peer-deps
peer<EMAIL_ADDRESS>from<EMAIL_ADDRESS>for vue 3.1.0-beta.3

Could you create a simple minimal reproduction repo that I can checkout/clone?
Maybe it's just changing the peer dependency from ^3.0.0 to >=3.0.0 <4.0.0 :thinking:, but I'm not sure
Does it work with yarn or other tools? Does it work with npm 6?

Could you create a simple minimal reproduction repo that I can checkout/clone?
Maybe it's just changing the peer dependency from ^3.0.0 to >=3.0.0 <4.0.0 🤔, but I'm not sure
Does it work with yarn or other tools? Does it work with npm 6?

npm 6 ok, this problem only in npm 7 maybe use ">=3.0.0 || ^3.0.0-beta"

So I checked via this site: https://jubianchi.github.io/semver-check/#/^3.0.0/3.1.0-beta.3
that the peer dependency is configured right and that ^3.0.0 also satisfies 3.1.0-beta.3
So I don't what I need to do here :confused:

ok @Shinigami92 see please https://semver.npmjs.com/
you

and  my ^3 || ^3.0.0-alpha || ^3.1.0-alpha

Okay we need to find a version range that includes everything between >=3.* and <4 :thinking:
I don't want to specify for every beta version a 3.X...-alpha
So I don't want to maintain something like ^3 || ^3.0.0-alpha || ^3.1.0-alpha || ^3.2.0-alpha ||  ^3.3.0-alpha || ^3.4.0-alpha ... beyond to infinity ...
How do I do that?

Beside that, I'm not sure if I "want" to support a beta version :thinking:
I mean, yeah it works, but I will not deliver support if there is something broken based on a beta version
Just when it will release officially, I will update an fix the breaking

@Shinigami92

Definitely due instead of >=3.* and <4 use ^3
Support only last beta releases ^3.1.0-alpha It is unlikely that someone needs old beta, and about support - update lazily :)

final result: ^3 || ^3.1.0-alpha

Cause I cannot find a way to specify all beta versions with just one easy range, I'm sorry, but I think I will not support beta versions for now.
If you are using beta versions you are an early adopter and there can be errors with that.
Setting it explicitly in my package.json means I officially support these non-production ready versions.
Also it's not only vue, but also vue-router that could get a beta...
So I would currently need something like
vue: ^3.0.0-a || ^3.1.0-a || ^3.2.0-a ...
vue-router: ^4.0.0-a || ^4.1.0-a || ^4.2.0-a ...

Sorry, but I don't want to create a release just due to there is a new beta release :slightly_frowning_face:
If I understand correctly using --legacy-peer-deps is the correct workaround for now, isn't it? That's cause you rely on a beta version.

ok, I agree


sensor_rpmsg.c:Fix that "stub" will be created when local core only has subscribers.

Summary
Bug fix, After the ap core subscribes to the 25hz batch 120ms data of the sensor core, it switches to the cp core and subscribes to the 50hz batch 120ms sensor core data. At this time, the data subscribed by the AP will be abnormally lost (12.5hz). Mainly because ap subscribes to sensor core data earlier than cp. The subscription of cp will be broadcast to the ap core at the same time, and the corresponding "path" already exists under "/dev/uorb" of ap. Thus the ap will create a "stub".
There are some restrictions on the creation of "stub" to avoid this situation.
Impact
Cross-core communication and persistent topics
Testing

build
PC:ubuntu2004, X86,SIM
rpserver and rpproxy open uorb config

./build.sh nuttx/boards/sim/sim/sim/configs/rpserver -j16
./build.sh nuttx/boards/sim/sim/sim/configs/rpproxy -j16

order:

rpserver
rpproxy

[Experimental Bot, please feedback here]
Yes, the PR generally meets the NuttX requirements, but could use some improvements:
Strengths:

Summary: Clearly describes the bug, its root cause, and the proposed fix.
Impact: Identifies the relevant areas affected (cross-core communication, persistent topics).
Testing:  Provides build environment details and test procedure.

Areas for Improvement:

Impact:

User Impact:  Will this fix change any user-facing behavior? Be explicit (YES/NO) and describe if necessary.
Build Impact: Be explicit (YES/NO). If YES, explain any required build process changes.
Hardware Impact: Be explicit (YES/NO). If YES, specify affected architectures, boards, or drivers.
Documentation Impact:  Be explicit (YES/NO). If YES, clarify what documentation needs updating and whether it's included in the PR.
Security Impact:  Be explicit (YES/NO). Briefly explain any security implications.
Compatibility Impact: Be explicit (YES/NO) for backward, forward, and interoperability. Explain any potential issues.

Testing:

Logs:  The "before" and "after" logs are placeholders. Provide actual log snippets that demonstrate the bug and its resolution. This helps reviewers understand the impact and validate the fix.

Recommendations:

Expand the "Impact" section with explicit YES/NO answers and detailed descriptions where necessary.
Replace the placeholder logs in the "Testing" section with real log output showing the problem before the fix and the correct behavior after.

By addressing these points, you'll provide a comprehensive and informative PR that's easier for reviewers to assess and approve.


[SQLStore]Added Statperk and some performance increases

Those are some changes i did a while ago, and totally forgot about opening a PR for them.
I've added the stat perks to the sqlstore and did some performance related changes to the rest of the store. Those changes should not break anything, but the stat perk changes will only take affect if the related table is deleted or changed by hand.

Thanks!


[ImagePickerIOS] require('NativeModules').ImagePickerIOS is undefined

Hi,
I noticed that with react 0.14.0 ImagePickerIOS is no longer inside require('NativeModules'), resulting in all function calls on it throwing an error.
Couldn't figure out why that is yet. Anyone a idea?
Tested with a fresh project with react 0.14.0

ImagePicker used to be included in RCTImage lib, but is now in RCTCemeraRoll. You need to include the RCTCameraRoll.xcodeproj in your project Libraries, and then make sure libRCTCameraRoll.a is included under "Link Binary With Libraries" in the Build Phases tab.

Oh I didn't know that! That would explain things. Thanks for the speedy answer.


Pagination ignore filters bug

Description
Found a bug where invalid pagination params weren't being ignored even though replace_invalid_params is set to true.
This is because the validation checks the pagination type by looking at the changes in the changeset. However, if the field looking for has an error, then the changeset wont show any changes.
This fix will update get_pagination_type/2 to infer the type by also checking the changeset errors.
Checklist

[x] Updated a test to reflect this.

Thank you!


Apply namespaces to the rest of the model subsystem

The model subsystem has already had namespaces introduced to field types, as part of PHP7 compliance.
Applying namespaces to the rest of the model subsystem is a logical next step.
Note that, as long as we don't yet apply namespaces to any of the subclasses of DataObject, we should be able to do this without having to have #5419 implemented first.

FYI I've been working on scripting this, as a stress test of https://github.com/sminnee/silverstripe-upgrader.

My preference is to get everything namespaced, so I'd like #5419 in alpha 2.


Fixed messed up pip command in notebook

Fixed issue with one cell in notebook.
Was:
!pip install -U pip
!pip accelerate bitsandbytes transformers

Fixed version:
!pip install -U pip
!pip install accelerate bitsandbytes transformers

I had the same issue and this fix worked for me

Huess can close now: https://github.com/Stability-AI/StableLM/commit/a90c89182a5562f35fa15bb43bf5b577e34bef7d


[service-bus] remove ms-rest-nodeauth dependency

This is the 2nd PR to fix #8041 (continuation of #8144).
This removes the @azure/ms-rest-nodeauth dependency in favor of an in-lined interface.

/azp run js - servicebus - tests


Implement lighting effects

Implement shadows and other lighting affects

Maybe alternate light sources like torches would be a good idea


Add drop method to ScriptableCollection.

Not Reviewed.
A drop method drops a collection and returns boolean future.
Returns:
true - when successfully drops a collection.
false - when collection to drop does not exist.

@noraesae @sgkim126 review please.

Referred http://docs.mongodb.org/manual/reference/method/db.collection.drop/ for behavior.

Please seperate commit to (implementation + test drop itself) and use drop method in another testd

PR Updated.
Also updated example for drop method.

LGTM


Module 1.1 Assignment

Given what you have learned about Git, why would you want to use Git in your classroom?

Git is a distributed version control system and GitHub is a remote server that can save repository.
There are number of reason to use Git in our classroom. Few of them are listed below.

Track changes. : It store all our changes as snapshot by commit the changes. This is useful to track changes when required.
Revise made easy: As a developer we save or create so many draft or changes in our code. It is save by committing our work. In future, whenever we require we easily revise our code and correct our
mistake
Brach and Merging: We work independently on our work by creating branch. Once we complete work successfully we merge it with original work.

Also it is very secure and maintain the integrity of our content.


new wheel version break wheel-axle

my autobuild has just started breaking:
Successfully installed filelock-3.15.4 wheel-0.44.0 wheel-axle-0.0.7 wheel-axle-runtime-0.0.5

python3.10 setup.py bdist_axle
Traceback (most recent call last):
File "/setup.py", line 317, in
setup(
File "/venv/lib/python3.10/site-packages/setuptools/init.py", line 108, in setup
return distutils.core.setup(**attrs)
File "/venv/lib/python3.10/site-packages/setuptools/_distutils/core.py", line 171, in setup
ok = dist.parse_command_line()
File "/venv/lib/python3.10/site-packages/setuptools/_distutils/dist.py", line 478, in parse_command_line
args = self._parse_command_opts(parser, args)
File "/venv/lib/python3.10/site-packages/setuptools/dist.py", line 847, in _parse_command_opts
nargs = _Distribution._parse_command_opts(self, parser, args)
File "/venv/lib/python3.10/site-packages/setuptools/_distutils/dist.py", line 537, in _parse_command_opts
cmd_class = self.get_command_class(command)
File "/venv/lib/python3.10/site-packages/setuptools/dist.py", line 692, in get_command_class
self.cmdclass[command] = cmdclass = ep.load()
File "/usr/local/lib/python3.10/importlib/metadata/init.py", line 162, in load
module = import_module(match.group('module'))
File "/usr/local/lib/python3.10/importlib/init.py", line 126, in import_module
return _bootstrap._gcd_import(name[level:], package, level)
File "", line 1050, in _gcd_import
File "", line 1027, in _find_and_load
File "", line 1006, in _find_and_load_unlocked
File "", line 688, in _load_unlocked
File "", line 883, in exec_module
File "", line 241, in _call_with_frames_removed
File "/venv/lib/python3.10/site-packages/wheel_axle/bdist_axle/init.py", line 35, in
from wheel.bdist_wheel import bdist_wheel as _bdist_wheel, python_tag
ImportError: cannot import name 'python_tag' from 'wheel.bdist_wheel' (/venv/lib/python3.10/site-packages/wheel/bdist_wheel.py)

started happening after it started using wheel version 0.44.0.
I can workaround by downgrading to wheel version 0.43.0, but I thought you should know.

Fixed in v0.0.8

great! :)


Whitespaces only lines in a fenced code should also be hashed

See https://spec.commonmark.org/0.30/#example-129

This issue is a duplicate of issue #42.


Xcode Build error on m1 mac (arm)

Bug report
Summary
Xcode build error on M1 mac.
Not using Rosetta (because of performance)
Getting this error:

ld: building for iOS Simulator, but linking in object file built for iOS, file '/Users/xxxxxxxx/ios/Pods/GoogleMaps/Base/Frameworks/GoogleMapsBase.framework/GoogleMapsBase' for architecture arm64

Environment info
Macbook pro 2021 M1 MAX
MacOS 12
react-native: 0.65.1
react: 17.0.2
react-native-maps: "git+https://github.com/react-native-community/react-native-maps.git"
Podfile
pod 'GoogleMaps', '~> 3.5.0'
pod 'Google-Maps-iOS-Utils'

My best guess is that the Pod used is not for ARM architecture. It has been an ongoing problem: https://github.com/googlemaps/google-maps-ios-utils/issues/355
Google JUST release version 6.0 which includes a framework specific for ARM: https://cloud.google.com/blog/products/maps-platform/announcing-version-60-maps-and-places-sdks-ios
--> How feasible it is to target this new version 6.0?

@lelandrichardson

I switched to the pre-release version 0.30.0 (https://github.com/react-native-maps/react-native-maps/releases/tag/v0.30.0) and it builds.


Bump versions in pre-commit config

You can also set up pre-commit.ci, which auto updates the revisions in the config file.

@egeakman Thanks!


Must-gather, Store PIDs of all the subprocesses

/ok-to-test

/cc @mrnold
any comments?

/cc @mrnold
any comments?

I am curious what prompted this? Like is there a bug link or something so I can see what this change fixes?
I really like Tiger's idea of showing the name of the current process being waited on, so we can see if a job is stuck.

I am curious what prompted this? Like is there a bug link or something so I can see what this change fixes?
I really like Tiger's idea of showing the name of the current process being waited on, so we can see if a job is stuck.

Hi @mrnold, Hi opened some PR to must-gather in OCP so I wanted that all MG code will work with the same method  https://github.com/openshift/must-gather/commit/4c685e04ae7dd236782a1b09912bd2f95c3c5690

Hi @mrnold, Hi opened some PR to must-gather in OCP so I wanted that all MG code will work with the same method openshift/must-gather@4c685e0

I see, this should be fine then.

/lgtm

/cherry-pick oadp-1.3


New App: GivEnergy Solar Monitor

Description
GivEnergy Solar Monitor
Description: Energy production and consumption monitor for your GivEnergy system.
Author: pelowj (based on the work of jweier & marcusb in Tesla Solar)
Copilot

🤖 Generated by Copilot at f7bc42b
Summary
🌞🔌📊

This pull request adds a new applet for Tidbyt devices that displays GivEnergy Solar data. The applet consists of a Starlark code file givenergy_solar.star and a manifest file manifest.yaml. The code file uses the GivEnergy API to fetch and render the data, while the manifest file defines the applet metadata and configuration fields.

GivEnergy applet
Shows solar data on screen
Autumn sun and wind

Walkthrough

Create and configure a new applet for displaying GivEnergy Solar data on Tidbyt (link, link)

Write the main logic and rendering code for the applet in givenergy_solar.star (link)
Write the manifest file for the applet in manifest.yaml (link)

I have read the CLA Document and I hereby sign the CLA


Support of BIL images as TerrainProvider ?

Hye,
In France, a public service called Geoportail use WMS flux provided by IGN. Requests are in this format :
https://wxs.ign.fr/an7nvfzojv5wa96dsga5nk8w/geoportail/wmts?LAYER=ELEVATION.ELEVATIONGRIDCOVERAGE.HIGHRES&FORMAT=image/x-bil;bits=32&SERVICE=WMTS&VERSION=1.0.0&REQUEST=GetTile&STYLE=normal&TILEMATRIXSET=WGS84G&TILEMATRIX=12&TILEROW=1012&TILECOL=4228

I would like to use this flux as as CesiumTerrainProvider in CesiumJS.
I tried with https://github.com/kaktus40/Cesium-GeoserverTerrainProvider with no result...
Any idea please ...?

For questions like this one, please post on the Cesium Community Forum, where our engineers and community members can help answer. We limit Github postings to feature requests and bug reports. Thank you!


Align behavior of form- attributes with spec

Types of Changes
Prerequisites
Please make sure you can check the following two boxes:

[x] I have read the CONTRIBUTING document
[x] My code follows the code style of this project

Contribution Type
What types of changes does your code introduce? Put an x in all the boxes that apply:

[ ] Bug fix (non-breaking change which fixes an issue, please reference the issue id)
[ ] New feature (non-breaking change which adds functionality, make sure to open an associated issue first)
[x] Breaking change (fix or feature that would cause existing functionality to change)
[ ] My change requires a change to the documentation
[ ] I have updated the documentation accordingly
[x] I have added tests to cover my changes
[x] All new and existing tests passed

Description
Basically, one of the first tests I wrote for my own project involved reading the formmethod attribute on a <button>, and I noticed it was just giving me the method on the form, which is... not right.
This commit makes the FormAction, FormMethod, etc. properties of HtmlButtonElement and HtmlInputElement behave in better alignment with the living standard. It also brings some similar tweaks to HtmlFormElement.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Looks good to me, but due to the magnitude of changes more unit tests are necessary for this one.
Please at least provide 2 more unit tests, 1 for valid form action and encoding type and 1 for invalid / fallbacks for these values.

Word 🗣
I will take a look at breaking down the possible test scenarios for this.

I'll do some of the remaining tests!

Oh cool... thank you, sorry I am such a scatterbrain.

No problem - all fine! Thanks again for the wonderful PR - much appreciated :beers:


Add License

Can you add a license? I would love to be able to use this as a starting point for something else, and want to provide appropriate/full credit.

For your reference: https://github.com/senior-zero/cuda_jit/community/license/new?branch=master

For your reference: https://github.com/senior-zero/cuda_jit/community/license/new?branch=master

Hello, @dmadisetti! Thank you for this note. I've set the MIT licence. I hope you find it suitable.

Perfect! Thank you


Added missing parameters to GitHub app manifest.

Why:
Closes ISSUE

What's being changed (if available, include any code snippets, screenshots, or gifs):

Check off the following:

[x] I have reviewed my changes in staging (look for the "Automatically generated comment" and click the links in the "Preview" column to view your latest changes).
[x] For content changes, I have completed the self-review checklist.

👋 Hey @OlayinkaAtobiloye! 🎉 🥳
I'll get this triaged for writer review! 💖


chore(package.json): add "exports.types" for strict mode TS support

Without this change i get
TS7016: Could not find a declaration file for module 'hpagent'.
'/Users/bowzee/WebstormProjects/trading.bot/node_modules/hpagent/index.mjs' implicitly has an 'any' type.
Try `npm i --save-dev @types/hpagent` if it exists or add a new declaration (.d.ts) file containing `declare module 'hpagent';`

Would be great if you could edit the description to include closes #95 to link them

I can confirm that I also experience bug described in #95 and indeed the fix introduced in this PR solves it.
It would be nice to merge and release this oneliner already :D


[auth] Fix for External Auth authenticator

For External Authentication, we trust the X-REMOTE-USER coming to us if defined.
It is the source for defining username and does not always equal the
username value for cases like Kerberos ticket principal and such.
https://trello.com/c/kky5CB6r

@abellotti Please address the failing tests on Travis


Add an alias to DM overview doc

First-time contributors' checklist

[ ] I've signed Contributor License Agreement that's required for repo owners to accept my contribution.

What is changed, added, or deleted? (Required)

Which DM version(s) do your changes apply to? (Required)

[x] master (the latest development version, including v3.0 changes)
[ ] v2.0 (TiDB DM 2.0 versions)
[ ] v1.0 (TiDB DM 1.0 versions)

What is the related PR or file link(s)?

This PR is translated from:
Other reference link(s): https://github.com/pingcap/docs-cn/pull/5213/files#diff-4b5153215c5a9499f6944d158847efca0a175a34d9fc5978dfb00bea1b6d1719L10

Do your changes match any of the following descriptions?

[ ] Delete files
[ ] Change aliases
[ ] Need modification after applied to another branch
[ ] Might cause conflicts after applied to another branch

Moved the changes to v2.0


no ConnectedRouter in react-router-redux?

Version
4.0.0
Test Case
https://codepen.io/ReactJSTraining/pen/jyYjeW
Steps to reproduce
Expected Behavior
Actual Behavior

Closed with no reply? Please update the docs: README.md gives an example with ConnectedRouter, and you have to scratch your head a little and read source code to figure out it's being done via syncHistoryWithStore() now.

Make sure you've installed the right version: npm install react-router-redux@next is 5.0 over here. The current lastest dist-tag is 4.0 over on @reactjs/react-router-redux


[UI] Fix credential Icon color in settings

Notes for Reviewers
This PR fixes #
previously credential Icon was not getting right color when it is selected also in not selected state too
Fixed:

Signed commits

[ ] Yes, I signed my commits.

merging this as this is a small change


Use p_prototype also in MPE

In https://github.com/SKopecz/PositiveIntegrators.jl/pull/48, p_prototype is used for MPRK22, but not for MPE. However, I think we could also use the prototype for MPE to get some performance improvement, e.g. for Tridiagonal matrices, there. With this change, I was able to reduce the time from ~15 ms to ~5 ms for an equation with Tridiagonalstructure.

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 76.45%. Comparing base (ccb5b8c) to head (5dbaeef).
Report is 23 commits behind head on main.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@             Coverage Diff             @@
##             main      #58       +/-   ##
===========================================
- Coverage   98.14%   76.45%   -21.70%
===========================================
  Files           4        4
  Lines         378      446       +68
===========================================
- Hits          371      341       -30
- Misses          7      105       +98

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Tests for ensuring podIdentity gets returned when parsingAzureQueueMetadata

Tests to ensure the issue in PR #407, to ensure podIdentity is reliably returned

// cc @tomkerkhove - we discussed adding a test for this on the call

Thanks @stgricci !

Awesome, thanks!


Typesafe commands

Streamlines the dev server workflow in a few ways

Removes the express server in favor of middleware on the Vite server
Removes the altair endpoint in favor of a GraphiQL playground as part of the Admin. This was a necessary change due to the express server going away
Removes the prebuild step for user-provided config
Removes the awkward setup we had in @tinacms/app. Instead, this package is now plain Vite app which exports an index.html, there is no build as that happens as part of the dev and build processes.

@tinacms/graphql no longer writes SDK files to the filesystem, it just returns their strings to the cli
When content is changed from the files directly, they're updated in the database immediately

Couple of questions regrading the graphQL playground.

Is there any reason why  can't or don't serve it from localhost:4001/ anymore?
The link when your run tinacms dev still points you to loclahost:4001 (Maybe it should not link you to your dev URL)
Since we are rendering the GraphQL playground now could we wrap it in our own navigation and link to it in the sidebar

Also getting this error when running the basic starter.
✘ [ERROR] [plugin vite:dep-scan] ENOENT: no such file or directory, open '/Users/logananderson-forestry-mac/dev/tinacms/tinacms/examples/basic-iframe/.tina/__generated__/types.ts'

    ../../node_modules/.pnpm/esbuild@0.16.17/node_modules/esbuild/lib/main.js:1426:27:
      1426 │         let result = await callback({
           ╵                            ^

    at Object.openSync (node:fs:594:3)
    at Object.readFileSync (node:fs:462:35)
    at file:///Users/logananderson-forestry-mac/dev/tinacms/tinacms/node_modules/.pnpm/vite@4.1.4/node_modules/vite/dist/node/chunks/dep-ca21228b.js:42096:37
    at requestCallbacks.on-load (/Users/logananderson-forestry-mac/dev/tinacms/tinacms/node_modules/.pnpm/esbuild@0.16.17/node_modules/esbuild/lib/main.js:1426:28)
    at handleRequest (/Users/logananderson-forestry-mac/dev/tinacms/tinacms/node_modules/.pnpm/esbuild@0.16.17/node_modules/esbuild/lib/main.js:727:19)
    at handleIncomingPacket (/Users/logananderson-forestry-mac/dev/tinacms/tinacms/node_modules/.pnpm/esbuild@0.16.17/node_modules/esbuild/lib/main.js:749:7)
    at Socket.readFromStdout (/Users/logananderson-forestry-mac/dev/tinacms/tinacms/node_modules/.pnpm/esbuild@0.16.17/node_modules/esbuild/lib/main.js:677:7)
    at Socket.emit (node:events:513:28)
    at addChunk (node:internal/streams/readable:315:12)
    at readableAddChunk (node:internal/streams/readable:289:9)

  This error came from the "onLoad" callback registered here:

    ../../node_modules/.pnpm/esbuild@0.16.17/node_modules/esbuild/lib/main.js:1287:20:
      1287 │       let promise = setup({
           ╵                     ^

    at setup (file:///Users/logananderson-forestry-mac/dev/tinacms/tinacms/node_modules/.pnpm/vite@4.1.4/node_modules/vite/dist/node/chunks/dep-ca21228b.js:42092:19)
    at handlePlugins (/Users/logananderson-forestry-mac/dev/tinacms/tinacms/node_modules/.pnpm/esbuild@0.16.17/node_modules/esbuild/lib/main.js:1287:21)
    at buildOrServeImpl (/Users/logananderson-forestry-mac/dev/tinacms/tinacms/node_modules/.pnpm/esbuild@0.16.17/node_modules/esbuild/lib/main.js:974:5)
    at Object.buildOrServe (/Users/logananderson-forestry-mac/dev/tinacms/tinacms/node_modules/.pnpm/esbuild@0.16.17/node_modules/esbuild/lib/main.js:780:5)
    at /Users/logananderson-forestry-mac/dev/tinacms/tinacms/node_modules/.pnpm/esbuild@0.16.17/node_modules/esbuild/lib/main.js:2132:17
    at new Promise (<anonymous>)
    at Object.build (/Users/logananderson-forestry-mac/dev/tinacms/tinacms/node_modules/.pnpm/esbuild@0.16.17/node_modules/esbuild/lib/main.js:2131:14)
    at build (/Users/logananderson-forestry-mac/dev/tinacms/tinacms/node_modules/.pnpm/esbuild@0.16.17/node_modules/esbuild/lib/main.js:1978:51)
    at scanImports (file:///Users/logananderson-forestry-mac/dev/tinacms/tinacms/node_modules/.pnpm/vite@4.1.4/node_modules/vite/dist/node/chunks/dep-ca21228b.js:41785:11)

  The plugin "vite:dep-scan" was triggered by this import

    ../../packages/@tinacms/app/src/Playground.tsx:7:24:
      7 │ import { queries } from 'CLIENT_IMPORT'

Looks good to me. Just two more things I noticed

The GraphQL playground is awesome!

Can we link to it in the playground from the sidebar? (Does not have to block this PR)
Is there anyway to make the popups work? (It is ok if not but I do find it awkward right now without then)

Maybe we could have another entry point to out vite app that build its it totally separate to something like /admin/graphql.html

I noticed that this removes the "isomorphicGitBridge" from the  _schema.json I know this does not matter locally does it matter in TinaCloud @kldavis4 ?

Overall looking really good

I noticed that this removes the "isomorphicGitBridge" from the  _schema.json I know this does not matter locally does it matter in TinaCloud @kldavis4 ?

Tina cloud is no longer expecting any features flags (including the isomorphicGitBridge)

Testing this with a PR deploy, I'm getting this new error on tina init

Testing this with a PR deploy, I'm getting this new error on tina init

I'm guessing this was a missed merge conflict. I'll take a look, thanks.

@jamespohalloran that's been fixed, thanks.

So does this need to be uncommented after this is merged? or before?

This can be uncommented once we know things work on Tina Cloud

Can we link to it in the playground from the sidebar? (Does not have to block this PR)

Yeah I want to let the dust settle first. Mainly because it's a bit buggy with the CSS issues

Is there anyway to make the popups work? (It is ok if not but I do find it awkward right now without then)

I did this initially, but we have our auth wrapper around things, and this actually works in the hosted environment too, which is really handy and I'd like to keep it around. So I think the proper fix is to clean up our admin fixed positioning stuff.

@jeffsee55 I ran yarn add tinacms@typesafe-clipanion @tinacms/cli@typesafe-clipanion
to the basic starter (created with create-tina-app) and got this error in the terminal
(!) Could not auto-determine entry point from rollupOptions or html files and there are no explicit optimizeDeps.include patterns. Skipping dependency pre-bundling.
ready - started server on <IP_ADDRESS>:3000, url: http://localhost:3000
event - compiled client and server successfully in 1288 ms (173 modules)
wait  - compiling / (client and server)...
event - compiled client and server successfully in 463 ms (237 modules)
Transform failed with 1 error:
<stdin>:8:0: ERROR: Unexpected "*"
2:17:46 p.m. [vite] Internal server error: Transform failed with 1 error:
<stdin>:8:0: ERROR: Unexpected "*"
  Plugin: transform-tsx
  File<EMAIL_ADDRESS>      at failureErrorWithLog (/Users/logananderson-forestry-mac/dev/playground/tina-test-march-15/node_modules/esbuild/lib/main.js:1566:15)
      at /Users/logananderson-forestry-mac/dev/playground/tina-test-march-15/node_modules/esbuild/lib/main.js:805:29
      at responseCallbacks.<computed> (/Users/logananderson-forestry-mac/dev/playground/tina-test-march-15/node_modules/esbuild/lib/main.js:671:9)
      at handleIncomingPacket (/Users/logananderson-forestry-mac/dev/playground/tina-test-march-15/node_modules/esbuild/lib/main.js:726:9)
      at Socket.readFromStdout (/Users/logananderson-forestry-mac/dev/playground/tina-test-march-15/node_modules/esbuild/lib/main.js:647:7)
      at Socket.emit (node:events:513:28)
      at addChunk (node:internal/streams/readable:315:12)
      at readableAddChunk (node:internal/streams/readable:289:9)
      at Socket.Readable.push (node:internal/streams/readable:228:10)
      at Pipe.onStreamRead (node:internal/stream_base_commons:190:23)
Transform failed with 2 errors:
<stdin>:1:5: ERROR: Expected "class" after TypeScript decorator but found "-"
<stdin>:1:11: ERROR: Expected ";" but found "{"

and this error in the browser when I went to the /admin page.

Thanks @logan-anderson. This is fixed in the latest commit, and the PR has been redeployed

This can probably move to a separate issue but right now if there is an error during a re-build the entire dev process crashes. Previously it still run with the old version.
See https://www.loom.com/share/fd304f54fbab4a56a6013d22ed8e4789

Hey there, I'm late to the party - sorry for that! Never had my hands on tinacms before the migration from forest.io
While attempting the migration, an issued occurred which - I think - originated in this pull request. Previously there was an Option to expose the Vite server externally (introduced by #3484) - which doesn't seem to be there anymore.
When we run tinacms dev --verbose -c nuxt (which is configured to listen to Port 3000), I have the following processes on those open ports in the container:
# netstat -nltp
Active Internet connections (only servers)
Proto Recv-Q Send-Q Local Address           Foreign Address         State       PID/Program name
tcp        0      0 <IP_ADDRESS>:43609        <IP_ADDRESS>:*               LISTEN      -
tcp        0      0 <IP_ADDRESS>:3000            <IP_ADDRESS>:*               LISTEN      68/node
tcp        0      0 <IP_ADDRESS>:4001          <IP_ADDRESS>:*               LISTEN      31/node
tcp6       0      0 :::9000                 :::*                    LISTEN      31/node

to toy around with and potentially get tinacms up and running, we need the 4001 port configured the same way. I see how the default 4001 port gets passed down in the dev-command (reference) - but the host for Vite needs server.host to be passed as part of their Configuration Object.
So far for my analysis - any suggestions on how to take it further @jeffsee55? I'm not very familiar with tinacms, but would like to help .. if you let me know how.
Thanks
-Stefan

EDIT: does this have anything to do with anything?
https://github.com/tinacms/tinacms/blob/a982b105d685fc343b989462c882d56c72a04007/packages/%40tinacms/app/src/App.tsx#L7-L9

What's your thinking here @wommy? If there would be any error from this, I'd expect it to occur once you request the page in a browser .. but we're talking about the server listening only on a local port that is not exposed to the outside.

even tried passing in tina/config.ts
export default defineConfig({
  build: {
    host: true,
  },
}

this is what #3484 added as functionality, but I don't see a code path anymore where this gets passed down the the vite config as it did before?

nah sorry I was braindead from trying to debug this for a few hours, reaching at straws
but also shouldnt it be
export default defineConfig({
  server: {
    host: true,
  },
}

https://vitejs.dev/config/server-options.html#server-host

@wommy @steffkes You can not currently change the vite config from DefineConfig.
So at the momant
export default defineConfig({
  server: {
    host: true,
  },
}

Does not do anything.
I can make a PR do add back host: true


fixing OrderedDict

This should fix the current issues with the OrderdDict changes in the build. There's a certain amount of complexity in using OrderedDict in older versions of Python (specifically 2.6) that's already been handled in Requests. Since that is a hard dependency I leveraged it's OrderedDict implementation to spare us the headache. Hopefully that's OK.

great idea!


#[must_use = false]

Allow annotating functions with #[must_use = false] to suppress any warning generated due to its return type being marked as #[must_use].
Pre-RFC on IRLO
Rendered

Maybe it is better to use positive logic. not negative and have #[may_unused] instead of #[must_use = false]
Your RFC number is lucky :)

I don't really like this approach because, well, error handling exists for a reason. If the error doesn't matter in a large number of cases, then you should just unwrap it or panic instead of returning it, not outright ignore it.
This also means that people who do want to be pedantic about errors no longer get notified if they forget to use them.
Basically, I think the solution should be to offer methods which don't return an error and then say what they do instead in their name (unchecked, panicking, etc.) rather than returning an error which can be ignored.

Maybe it is better to use positive logic. not negative and have #[may_unused] instead of #[must_use = false]. Or ... #[allow(dead_code)]
Your RFC number is lucky :)

This isn't quite natural English, and honestly, the false flag makes the most sense; any other way of saying "this was marked as must use, but doesn't have to be used" is going to be longer to say and this feels very discoverable.

I don't really like this approach because, well, error handling exists for a reason. If the error doesn't matter in a large number of cases, then you should just unwrap it or panic instead of returning it, not outright ignore it.

I think it's probably a bad idea for things returning Result, but there may be other cases of a function returning type marked must_use and not wanting the function to be must_use.
It'd help to have an example other than Result.

This would be especially interesting if Rust supported making every function must_use by default, since in practice small minority of functions have a discardable result (as demonstrated by Swift's default and @discardableResult).

This would be especially interesting if Rust supported making every function must_use by default, since in practice small minority of functions have a discardable result (as demonstrated by Swift's default and @discardableResult).

This would mean that we must use (), a very common function return value, and I disagree. ;)
I do see where you're coming from, but I do think that it's very important to clarify what you mean by "a small minority of functions" because that's extremely difficult to quantify. I would hesitate to make any sweeping claims about this without actually searching through some kind of dataset.

This would be especially interesting if Rust supported making every function must_use by default, since in practice small minority of functions have a discardable result (as demonstrated by Swift's default and @discardableResult).

This would mean that we must use (), a very common function return value, and I disagree. ;)
I do see where you're coming from, but I do think that it's very important to clarify what you mean by "a small minority of functions" because that's extremely difficult to quantify. I would hesitate to make any sweeping claims about this without actually searching through some kind of dataset.

() would almost certainly be the exception to this rule.
also, this was marked as a future possibility, either via editions or putting must_use on a module.

I don't really like this approach because, well, error handling exists for a reason. If the error doesn't matter in a large number of cases, then you should just unwrap it or panic instead of returning it, not outright ignore it.

I think it's probably a bad idea for things returning Result, but there may be other cases of a function returning type marked must_use and not wanting the function to be must_use.
It'd help to have an example other than Result.

Generally this is useful for any must_use type defined in a different crate that is being returned from a function with side effects.  Another example would be iterators.

Generally this is useful for any must_use type defined in a different crate that is being returned from a function with side effects. Another example would be iterators.

That's fair, although generally, iterator types aren't marked must_use; only functions returning iterators which do nothing unless used. For example, Vec::drain returns an iterator but doesn't mark it must_use, since it's a perfectly reasonable use case to simply drop the iterator instead of reading it.
I think that a good example would be one where a type is marked must_use for a good reason, and similarly, a return value would be worth marking as must_use = false. So far, I haven't found any compelling examples, and I just comment on the Result case, which feels wrong.
To be clear, I think that the feature is perfectly reasonable and well-defined; I just am not sure that it would actually solve a problem as much as it'd encourage people to ignore return values they really shouldn't.

That's fair, although generally, iterator types aren't marked must_use; only functions returning iterators which do nothing unless used. For example, Vec::drain returns an iterator but doesn't mark it must_use, since it's a perfectly reasonable use case to simply drop the iterator instead of reading it.

That's an exception, if you look at any other iterator, such as std::ascii::EscapeDefualt, you will see it is the type that has the annotation, not the function.

I think that a good example would be one where a type is marked must_use for a good reason, and similarly, a return value would be worth marking as must_use = false. So far, I haven't found any compelling examples, and I just comment on the Result case, which feels wrong.

I feel like Result is the perfect example of this, though? It has very good reason to be marked as must_use, but there are some Result returning functions where the best option is almost always to log or ignore it.  indeed, there are some times where an early return would usually be bad, there is no reason to bring down the whole program because of a non-fatal error.
"it feels wrong" is not very useful feedback.

To be clear, I think that the feature is perfectly reasonable and well-defined; I just am not sure that it would actually solve a problem as much as it'd encourage people to ignore return values they really shouldn't.

this is a tool for library authors, not really for applications.  If an application author wants to ignore the unused_must_use lint, they can already do that.

That's fair, although generally, iterator types aren't marked must_use; only functions returning iterators which do nothing unless used. For example, Vec::drain returns an iterator but doesn't mark it must_use, since it's a perfectly reasonable use case to simply drop the iterator instead of reading it.

That's an exception, if you look at any other iterator, such as std::ascii::EscapeDefualt, you will see it is the type that has the annotation, not the function.

Right, I guess that it's weird that the iterator as marked this way instead of the method, but I wouldn't necessarily say that this is an "exception rather than the rule." If an adapter is only returned by one method, then it kind of doesn't matter whether you mark the type or the method, although it does effect downstream uses of that adapter. Perhaps that's a good reason to not mark the adapters as must_use, but the methods instead.
Like, yes, I acknowledge that this would solve this problem now without a change to the standard library, but considering how we're now proposing a language change, it feels worth considering whether a standard library change and an ecosystem change would be more fitting.

I think that a good example would be one where a type is marked must_use for a good reason, and similarly, a return value would be worth marking as must_use = false. So far, I haven't found any compelling examples, and I just comment on the Result case, which feels wrong.

I feel like Result is the perfect example of this, though? It has very good reason to be marked as must_use, but there are some Result returning functions where the best option is almost always to log or ignore it. indeed, there are some times where an early return would usually be bad, there is no reason to bring down the whole program because of a non-fatal error.
"it feels wrong" is not very useful feedback.

It's not just that it feels wrong: the point of returning a Result is to explicitly clarify that an error must be handled. If you think that a majority of your users won't want to handle the error, why return it at all? Plus, this case would prevent particularly pedantic users from ensuring that they do handle the error, and require an entirely separate lint for must_use_even_if_you_think_i_mustnt (name pending) to ensure that they do handle it.

To be clear, I think that the feature is perfectly reasonable and well-defined; I just am not sure that it would actually solve a problem as much as it'd encourage people to ignore return values they really shouldn't.

this is a tool for library authors, not really for applications. If an application author wants to ignore the unused_must_use lint, they can already do that.

I mean, this kind of feels like an either/or situation, since within each binary application is a library application too. I can see a lot of users choosing to add this to helper methods for their applications alongside the actual application (generally, you have more than just main) and so I think it's worth mentioning that case too.
The reason why I mention that case is because it feels much more likely of a use case: if only one application is using a function, then they can tailor the benefits to that one application. Whereas a library has to assume what all of its users want, which feels like a more difficult call to make.

Again, my point is: if a return value is not necessarily useful, why return it at all? If you're expecting users to ignore the entire return value, then it's likely that you have a Result<(), E> case, and you could completely sidestep the issue by using Option<E> instead. This also further conveys to the user that they might not care about the error if it's present, while still offering it.
The point here is that Result conveys not only the literal value of an error, but the semantic implication that the error should be handled as well, which is why it's must_use. If you don't want to have those attached semantics, the solution is to not use Result, not to add in a language feature overriding these semantics.

Right, I guess that it's weird that the iterator as marked this way instead of the method, but I wouldn't necessarily say that this is an "exception rather than the rule." If an adapter is only returned by one method, then it kind of doesn't matter whether you mark the type or the method, although it does effect downstream uses of that adapter. Perhaps that's a good reason to not mark the adapters as must_use, but the methods instead.
Like, yes, I acknowledge that this would solve this problem now without a change to the standard library, but considering how we're now proposing a language change, it feels worth considering whether a standard library change and an ecosystem change would be more fitting.

my point was that you said most iterators had the annotation on the constructor, while the reality is contrary to this fact.
also, it's worth noting that lints are a compiler feature, not a language feature.

I feel like Result is the perfect example of this, though? It has very good reason to be marked as must_use, but there are some Result returning functions where the best option is almost always to log or ignore it. indeed, there are some times where an early return would usually be bad, there is no reason to bring down the whole program because of a non-fatal error.
"it feels wrong" is not very useful feedback.

It's not just that it feels wrong: the point of returning a Result is to explicitly clarify that an error must be handled. If you think that a majority of your users won't want to handle the error, why return it at all? Plus, this case would prevent particularly pedantic users from ensuring that they do handle the error, and require an entirely separate lint for must_use_even_if_you_think_i_mustnt (name pending) to ensure that they do handle it.

it has never been possible to force a Result to be used, let _ = is always a way of suppressing it.  there is absolutely no need for an "opt back in" attribute, and suggesting so is silly.
The point of returning a Result in these situations is to allow error handling (or more likely, to allow logging of the error), but not to require it.

To be clear, I think that the feature is perfectly reasonable and well-defined; I just am not sure that it would actually solve a problem as much as it'd encourage people to ignore return values they really shouldn't.

this is a tool for library authors, not really for applications. If an application author wants to ignore the unused_must_use lint, they can already do that.

I mean, this kind of feels like an either/or situation, since within each binary application is a library application too. I can see a lot of users choosing to add this to helper methods for their applications alongside the actual application (generally, you have more than just main) and so I think it's worth mentioning that case too.

what sort of helper method are you imagining where ignoring the return value is

The reason why I mention that case is because it feels much more likely of a use case: if only one application is using a function, then they can tailor the benefits to that one application. Whereas a library has to assume what all of its users want, which feels like a more difficult call to make.
Again, my point is: if a return value is not necessarily useful, why return it at all? If you're expecting users to ignore the entire return value, then it's likely that you have a Result<(), E> case, and you could completely sidestep the issue by using Option<E> instead. This also further conveys to the user that they might not care about the error if it's present, while still offering it.

and if the Ok value of the Result is not ()?

The point here is that Result conveys not only the literal value of an error, but the semantic implication that the error should be handled as well, which is why it's must_use. If you don't want to have those attached semantics, the solution is to not use Result, not to add in a language feature overriding these semantics.

This is your interpretation of the type, but I have seen no evidence that this is the intent.  If anything, this semantic seems to be a side effect of the must_use annotation on Result.

@lolbinarycat I think the Pre-RFC URL is wrong (currently it links to #[doc(consts)]), it should be https://internals.rust-lang.org/t/pre-rfc-must-use-false/21861 right?


scala-xml no longer part of core library in Scala-3...

but it is excluded by the includeScala=false directive as its file name starts with "scala-".
Unfortunately once excluded there appears to be no way to override the exclusion.  So the logic that decided which .jar files to include when this option is used needs to be updated to use a better way of determining whether to include .jar content.

Hello, we've come across the same issue specifically for scala-xml. It appears the below check is flawed.
We're on Scala 3.3.1, so we would pass the >=2 check put fail the >=13 for the minor version.
https://github.com/sbt/sbt-assembly/blob/56f7e715ac3444237c8f1fd6c88abceeaf641e4a/src/main/scala/sbtassembly/Assembly.scala#L244-L249
As more users take on Scala 3.3 this will likely become more of an issue.

As @TimBloy mentions the logic seems to predate Scala 3.
The Scala 3 artifacts have even different names ("scala3-compiler" and "scala3-library")


[Feature Request] Override index accessor []

I would like to evaluate expressions such as:
myObject[1]

using an Operator override like:
expr.Operator("[]", "At")

with
func (extensions) At(i int)  interface{} {
   ...
}

If you think this is useful then I can try to contribute this

This is very dangerous path what can lead to unmaintainable project. What is problem you are trying to solve?

Well, in my case the variable myObject is not a slice but a custom data structure and I would like to hide that implementation detail in the expression.
Can you share why you think this is dangerous to the project?

Most of the modern programming languages disallow ALL operator overriding.

And for a reason.

It's already complicated with overriddng of binary operators.

Two can overlap each other in unpredictable ways.

And actually you can do what you want already with patch feature of Expr.

Here is an example: https://play.golang.org/p/GS3JRcJBKBX
package main

import (
	"fmt"

	"github.com/antonmedv/expr"
	"github.com/antonmedv/expr/ast"
)

func main() {
	code := `Object[5]`

	program, err := expr.Compile(code, expr.Env(Env{}), expr.Patch(&patcher{}))
	if err != nil {
		panic(err)
	}

	env := Env{"hello, world"}

	output, err := expr.Run(program, env)
	if err != nil {
		panic(err)
	}
	fmt.Print(output)
}

type Env struct {
	Object Object
}

type Object string

func (o Object) Index(i int) string {
	return string(o)[:i]
}

type patcher struct{}

func (p *patcher) Enter(_ *ast.Node) {}
func (p *patcher) Exit(node *ast.Node) {
	n, ok := (*node).(*ast.IndexNode)
	if ok {
		ast.Patch(node, &ast.MethodNode{
			Node:   n.Node,
			Method: "Index",
			Arguments: []ast.Node{
				n.Index,
			},
		})
	}
}

Basically you can replace you done with what you want.
Please take a look at docs:

https://github.com/antonmedv/expr/blob/master/docs/Visitor-and-Patch.md
https://pkg.go.dev/github.com/antonmedv/expr?tab=doc#example-Patch

thank you for the example


rendering is taking too much time

I am using mathjax with my react-native quiz application. But it is taking too much time in loading the question with all four options and downgrading the performance of application.
I tried putting loader when webview loads but loader stays only untill the webview loads and rending of mathematical questions still takes more time to display.
Any way by which we can reduce the rendering time or put a loader/activity indicator on rending too?

Without more information about how your application works, how it interacts with MathJax, and what MathJax configuration you are using, it is not possible to answer your question about reducing rendering time.
As for showing a loader during rendering, consider this post as an example.  You use MathJax.Hub.Queue() to queue a function that turns off the load indicator, and it will not run until after MathJax finishes typesetting the page (since the initial typesetting has been queued before your function).
Finally, note that this is not the best place to ask such questions.  This issue tracker is for reporting errors in MathJax.  Asking questions about how to do things is better done on the MathJax User Forum where more people will see it.


Update Client.php

Hi, it looks like you exposed your consumer key and secret in this PR.
We've suspended the associated API consumer due to a breach of section 3.b in our Application Developer and API License Agreement.
Feel free to create a new application, but please key your credentials secret.


[docs] sync docs/explanation across projects

See discussion over here: https://github.com/textileio/go-textile-wallet/issues/1
There has been some confusion about wording around wallet's and accounts, might be good to converge on some unified and simple text in both repos.

Closing, as this is too vague...


Dockerize

Run frontend as docker
Run backend as docker
Provide instructions to launch using Docker instead of using vagrant

This would resolve #17 and #18

Hello, a new version of the GUI is in development and should be available around February in this repository. It will contain dockerfile as well as vagrantfile for easier deployment.


Remove support for OCPP 2.0

OCPP 2.0 never took of. The specification can't be downloaded from the OCA's website.
In the OCPP 2.0.1 specification, the OCA urges to to update from OCPP 2.0 to 2.0.1:

1.1. OCPP version 2.0.1
This specification defines version 2.0.1 of OCPP.
After the release of OCPP 2.0, some issues were found in OCPP 2.0. Some of these issues could not be fixed issuing errata to the specification text only, as has been done with OCPP 1.6, but required changes to the protocol’s machine-readable schema definition files that cannot be backward compatible.
To prevent confusion in the market and possible interoperability issues in the field, OCA has decided to name this version: 2.0.1.
OCPP 2.0.1 contains fixes for all the known issues, to date, not only the fixes to the messages.
This version replaces OCPP 2.0. OCA advises implementers of OCPP to no longer implement OCPP 2.0 and only use version 2.0.1 going forward.

PR https://github.com/mobilityhouse/ocpp/pull/576 created and approved for addition in 1.0.0, so will close this


File explorer sidebar reopens

VSCode Version: 1.22.2
OS Version: Ubuntu Linux 17.10

Steps to Reproduce:

Open a file. The file is shown in the right side
Collapse the file explorer.
Click with the mouse anywhere inside the file windown
The file explorer sidebar reopens.

Does this issue occur when all extensions are disabled?: Yes/No
After I closed and reopened both with --disable-extensions and without it, It didn't happen again. BUT after some time of working with the IDE it happens again.

This is caused by an extension.
Disable your extensions one by one and try to figure out which one is doing this pesky behavior. Once you find that out file a bug against that extension. Thanks


[Codegen] Make IREEExpandStridedMetadata expand ops

Make IREEExpandStridedMetadata pass expand memref operations also instead of just resolving them.  This makes the pass consistent with what the mlir pass does.
Needed for #14817

Closing as this pass just needs a renaming change to IREEResolveStridedMetadata which i will send as a separate patch.


[#9597] Enable alias operation for field name. Max data of nonHeap is also returned.

[#9597] Enable alias operation for field name. Max data of nonHeap is also returned.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.minwoo.jung seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.