Organisation names with long names is displayed/extends beyond the space allocated  [DESKTOP] [MOBILE]

Environment : https://staging.fightpandemics.work/
Steps to reproduce

Create an organisation whose name is more than 25 characters

After successful creation of organisation profile -> go to org profile ->Click on Create a post - > click Organisation
OR
Help Board - > Post Creation ->continue posting as : Organisation

Here it lists all the organizations so far created .

Actual Results:
The name is displayed beyond the button layer. Affects both Desktop and Mobile.
Expected Results:
It's doesn't look visually appealing. The names when long should adjust accordingly within the button. Shouldn't overflow or there should be text limit to the organisation name.
Screenshot 1  : DESKTOP

Screenshot 2 : MOBILE

@ppagarawal @idjevm do you guys know if there should be a count limit for org names?

@vikjoshi Can you please help here?


Adding an option to edit 'eliteDependencies'

Hi,
Using wiredep (grunt-wiredep) with a polymer based project, I have the same kind of issue as https://github.com/webcomponents/webcomponentsjs/issues/48
After looking at the code, it seems this is the 'eliteDependencies' list in detect-dependencies.js that makes jquery appear before polymer 'webcomponentsjs'.
Do you think it would be possible to add an option to wiredep so that one can specifiy this eliteDependencies list ?
Thanks

This has been removed


Gazebo SITL broken

Iris model takes off, then immediately crashes.

+1.

Duplicate of #3983, closing.


Tests fails in Clock

Hi,
Running tests locally ends with following message:
Testing clock-test

Ran 3 tests containing 50 assertions.
0 failures, 0 errors.

Same tests run on site end up with:
Message:  Invalid arity: 22
Message:  Invalid arity: 22
Location: 24:1
Location: 24:1

----- Stack trace --------------------------------
----- Stack trace --------------------------------
clock-test - <expr>:24:1
clock-test - <expr>:24:1

I have tried various alternatives in solution, depending on version the line where issue is reported differs but error message is the same (Invalid arity: 22).
All the best,
Adrian

This likely related (or similar) to #92! The test forms may incorrectly try to pass too many named arguments to their underlying functions.


Python 3.7 and LightGBM gpu with boost 1.68 windows 10

Environment info
Operating System: Windows 10
CPU/GPU model: Intel Core i7-8700/NVIDIA GeForce GTX 1060 6GB
C++/Python/R version: 3.7.1
LightGBM version or commit hash: 2.2.1
Error message
Error 2 while installing LightGBM gpu according to the tutorial.
https://lightgbm.readthedocs.io/en/latest/GPU-Windows.html
Reproducible examples
I installed CUDA Toolkit 10.1 cause it's only way to install tensorflow 2 on gpu with python 3.7
Steps to reproduce

Make everything same with the tutorial except CUDA Toolkit version (you need to install 10.1):
https://lightgbm.readthedocs.io/en/latest/GPU-Windows.html
Configure Lightgbm with CMake and you'll get message than it's compiled up to boost with version 1.68
Use GitBash to compile Lightgbm and you'll get Error 2 at 49% of installing.

So there is the question - will you change tutorial of LightGBM installation for Windows with Python 3.7 and CUDA Toolkit 10.1.
The point is - you can't use less version of CUDA if you want use GPU versions of LightGBM and tensorflow at the same time cuse second lib works only with CUDA Toolkit 10.1 unfortunatelly.

@dishkakrauch We have a test for GPU-version of LightGBM on CI:
https://github.com/Microsoft/LightGBM/blob/691b842832f511a72b4aaab715b3cb6b00de8f90/.ci/test.sh#L95-L104
and it indicates that everything is OK with Boost 1.68.
Also, we have a case of successful compilation on Windows with Boost 1.69.0 and CUDA 10.0: https://github.com/Microsoft/LightGBM/issues/2081#issuecomment-480504939.
I think you should adjust Boost and CUDA paths. You can read about it here with latest corrections: #2082.
Unfortunately, we are not going to check compatibility of Tensorflow and LightGBM in terms of dependencies. We encourage users to use the latest versions, if nothing special is written.
In case you post your error log, we can dig deeper in the problem.


docs: mention metafora distributed task library

Metafora uses etcd as a task broker, command channel, and state store.

LGTM. Merging.

Thanks! I'll try to get my other docs PR cleaned up ASAP.


ar command fails silently

Related to issue #572
With a project over 3500 files, the createStaticLibrary command fails silently. The failing command is ar used to link the object files, creating a static library.
I've extraced the command, and ran in, I get the Argument list too long error.
If I move the files into Xcode, and compile it there, it is successful. That is, because Xcode uses libtool instead of ar, with the parameter -objectlist file, where file contains the names of the objects to link together (http://www.gnu.org/software/libtool/manual/libtool.html#Link-mode). In essence, libtool acts as a wrapper for the ar library. This is the same solution that we implemented in #572.
My proposal here, is to remove the linking tasks from the native compilation, and use libtool instead, with the same arguments, and using an arg file.
@brunobowden we might want to wait with the new release, until we can find a solution to this problem.

Discussion about the same problem:
https://discuss.gradle.org/t/how-to-work-around-argument-list-too-long-error-when-compiling-library-c-plugin/5000.


fixed an issue where some times taskMaxId dit not avaluate TaskGroups ids

not sufficient to fix the bug. Will submit a new fix.


Dart bindings

hello
cute project
you have different sdks for different platforms
just wondering is it possible to use the rust sdk with dart's ffi
dart has ffigen for c headers
can you guys make a c header from your rust code ?

found this  which maybe helpful for someone who knows rust
i only know dart :)


Bring substrate-demo up to date

Quite a bit of the consensus code is still copy-pasted from polkadot

Offline validator detection should be moved to substrate
Some shared code in runtime/checked_block.rs

Demo extrinsics still use Address instead of AccounId.
Currently it can sync krumme-lanke.json but I expect this to change as the network protocol grows to be incompatible. Protocol id should be different at least.

There's a toolchain problem it seems. :/

yey for the direction :)
would really like to shift all networking logic into substrate libraries with just an extension API that can be used should protocol additions be required like for polkadot.
i guess this can be done in subsequent PRs though.

We want something like a substrate-network-rhododendron crate for dealing with rhododendron networking messages etc. We will want other consensus protocols which have their own messages so it's best not to make the existing ones too first-class in substrate. consensus networking crates will need to be extensible enough to also support things like enabling polkadot sub-agreement messages to be sent via the same channels.

@arkpar needs resolving...


Update changelog for v2.2.0

Update changelog and bump version

Codecov Report

Merging #67 into master will not change coverage by %.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #67   +/-   ##
=======================================
  Coverage   33.25%   33.25%
=======================================
  Files          12       12
  Lines        6006     6006
=======================================
  Hits         1997     1997
  Misses       3641     3641
  Partials      368      368

Impacted Files
Coverage Δ

version.go
77.77% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 382bb12...2b592dc. Read the comment docs.


IndexError: list index out of range (empty good_points)

Hello thank you for the code source, i am making some test but i am getni an error
findCard.py", line xxx, in findAndTransform
uLeft = uLeftOrder[0]
IndexError: list index out of range
good_points is always empty
Can you please help
Regards,

I have solved this issue. Here my solution: In "findAndTransform" function, add one more loop before "for rho, theta in lines[0]" and aslo replae "lines[0]" by "each_line". Fixed code below:
lines = cv2.HoughLines(processed, 1, 2 * np.pi / 180, 33)
my_lines = []

for each_line in lines:
    for rho, theta in each_line:
        a = np.cos(theta)
        b = np.sin(theta)
        x0 = a * rho
        y0 = b * rho
        x1 = int(x0 + 1000 * (-b))
        y1 = int(y0 + 1000 * (a))
        x2 = int(x0 - 1000 * (-b))
        y2 = int(y0 - 1000 * (a))
        # making list of all Hough lines found
        foundLine = line(np.array([x0, y0]), np.array([x1, y1]))
        if foundLine == False:
            continue
        else:
            my_lines.append(foundLine)


Loot Logger just stopped working

Loot Logger has been perfect since downloading from plugin hub, using it for months, however since Tuesday 2nd September it has stopped tracking any kills from anything.
I have uninstalled and reinstalled runelite client, I have also uninstalled and reinstalled the loot logger but still the same, I have tried clearing most tracked kills within the logger but the same issue

The issue was resolved by clearly the loot tracker loot which I didn’t even have enabled.


WebSocket service suggestion still uses WebSocket listener

Description:
The WebSocket service creation suggestion in tooling still uses the WebSocketListener. The WebSocketListener has been removed and http:Listener is used in WebSocket as well.
A similar issue can be observed in Test generation as well
Steps to reproduce:

Affected Versions:
Ballerina 1.0.0 alpha 3

This has been resolved in the 1.0 release


[CP Staging] Fix Hybrid Android crash and bring the custom edge-to-edge module to hybridApp

Reverts Expensify/App#53165
We are adding the correct custom module to Hybrid App in this PR so we do not need this change anymore https://github.com/Expensify/Mobile-Expensify/pull/13308/files
This will also include https://github.com/Expensify/Mobile-Expensify/pull/13308
Straight revert
Fixed Issues
$ https://github.com/Expensify/App/issues/53204
Tests
Same as QA
QA
Test the original crash issue

Launch hybrid app
Log in
Switch to ND if needed
Verify the app does not crash

App does not crash after closing the app with hardware back button

Launch hybrid app.
Go to ND (if in OD).
Close the app by tapping device back navigation (or swipe to exit, not kill the app).
Open the app.
Verify the app does not crash

Reviewer Checklist

[X] I have verified the author checklist is complete (all boxes are checked off).
[X] I verified the correct issue is linked in the ### Fixed Issues section above
[X] I verified testing steps are clear and they cover the changes made in this PR

[X] I verified the steps for local testing are in the Tests section
[X] I verified the steps for Staging and/or Production testing are in the QA steps section
[X] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[X] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[X] I checked that screenshots or videos are included for tests on all platforms
[X] I included screenshots or videos for tests on all platforms
[X] I verified tests pass on all platforms & I tested again on:

[X] Android: Native
[X] Android: mWeb Chrome
[X] iOS: Native
[X] iOS: mWeb Safari
[X] MacOS: Chrome / Safari
[X] MacOS: Desktop

[X] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
[X] I verified proper code patterns were followed (see Reviewing the code)

[X] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[X] I verified that comments were added to code that is not self explanatory
[X] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[X] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
[X] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[X] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
[X] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[X] I verified the JSDocs style guidelines (in STYLE.md) were followed

[X] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[X] I verified that this PR follows the guidelines as stated in the Review Guidelines
[X] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
[X] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[X] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[X] If a new component is created I verified that:

[X] A similar component doesn't exist in the codebase
[X] All props are defined accurately and each prop has a /** comment above it */
[X] The file is named correctly
[X] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[X] The only data being stored in the state is data necessary for rendering and nothing else
[X] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[X] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[X] All JSX used for rendering exists in the render method
[X] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[X] If any new file was added I verified that:

[X] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[X] If a new CSS style is added I verified that:

[X] A similar style doesn't already exist
[X] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)

[X] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[X] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[X] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[X] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[X] If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:

[X] I verified that all the inputs inside a form are aligned with each other.
[X] I added Design label and/or tagged @Expensify/design so the design team can review the changes.

[X] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[X] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[X] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.


JSP capabilities

Hello everyone, I guess it would be nice to have all java features in .jsp files.
Specifically I am talking about to provide jsp files the same features that are available for java according to the specific syntax of that kind of files. I guess that means to apply JDT server capabilities to code parts that are between <% %> or even <%= %>, at least.

The language server protocol and specification doesn't today cope with embedded syntax/grammars.  Unless the language server supports .jsp files directly or the specification changes our hands are tied here.


Extension does not include node_modules

I was trying to generate the init.py from the context menu when I realized it wasn't working since the extension gets activated only after the main command is executed.
I then ran the main command, but it failed to run. So I noticed that the extension only works in the development environment but fails to get activated outside.
After some inspection. I've found this in the Output window under Extension Host the following error:
Activating extension SeeLog.python-init-generator failed due to an error:
2023-01-13 12:12:00.853 [error] Error: Cannot find module 'glob'
Require stack:
- /Users/virgil/.vscode/extensions/seelog.python-init-generator-0.0.10/out/file-controller.js
- /Users/virgil/.vscode/extensions/seelog.python-init-generator-0.0.10/out/extension.js
...

And actually, the node_modules folder inside .vscode/extensions/seelog... is missing.
I have tried the extension on another machine and have the same issue.

@sisoe24 Thank you for reporting this issue.
Maybe same as #1.
Now, I updated some packages and then uploaded the new extension(v0.0.12).
I reinstall the extension from the market, then I confirm it works.
Oddly, sometimes node_modules dir disappears on this project.
This time, I solved this issue by updating packages, but maybe it will occur in the future.
If you couldn't confirm v0.0.12 works, please re-open this issue.


LinearRegression Example in ForwardAccumulator docstring has an error

URL(s) with the issue:
https://github.com/tensorflow/tensorflow/blob/85c8b2a817f95a3e979ecd1ed95bff1dc1335cff/tensorflow/python/eager/forwardprop.py#L234
Description of issue (what needs changing):
I was trying to understand precisely how ForwardAccumulator.jvp works and was working through the example to which I have linked. From computing by hand what I believed to be the correct jvp formula, and comparing it to the linear regression code I found that in the line
...   loss = tf.reduce_sum((dense(x) - tf.constant([1., -1.])) ** 2.)
the target
tf.constant([1., -1.])
which I would call 'y', should be reshaped, for example replaced by
tf.constant([[1.], [-1.]])
The code as it stands introduces a multiplicative factor of n in the loss function where n is the number of samples. This same problem occurs in other places in this docstring.
Would it be possible to include somewhere in this docstring a formula for the jacobian-vector-product?

Nice catch, I have a fix for the broadcasting issue pending.

Would it be possible to include somewhere in this docstring a formula for the jacobian-vector-product?

Are you referring to a formula for the JVP of one of the examples, or just JVPs in general?

Are you referring to a formula for the JVP of one of the examples, or just JVPs in general?

well I thought just in general, write the formula for the JVP. Its a very simple formula but oddly enough I found it hard to find a precise reference. Im not sure how latex is rendered in the documentation environment however. I know github is a bit slack with latex.


Hello World example from readme seems not to work

Hi, I really like the idea of finch, and I'm trying to test it out, but sadly I keep hitting obstacles.
First there was an issue with the versions, ( #1194) but I finally solved that. But now I can't get the example hello world to work either.
I'm trying
import io.finch._
import cats.effect.IO
import com.twitter.finagle.Http

object Server extends App with Endpoint.Module[IO] {
  val api: Endpoint[IO, String] = get("hello") { Ok("Hello, World!") }
  Http.server.serve(":8080", api.toServiceAs[Text.Plain])
}

but all I get is
Aug 12, 2020 1:16:58 PM com.twitter.finagle.Init$ $anonfun$once$1
INFO: Finagle version 20.3.0 (rev=e3fd6d1bd88c9ed7edeb98a6598e23800924c633) built at 20200308-110626

Process finished with exit code 0

I'm not sure if the problem is on my side or with the example.

Hi @KovaxG I believe this is an issue with the docs. I think #1250 fixes it. I will try to take a look and merge it this weekend.
Basically, Http.server.serve is returning a future that represents the life time of the server. Because it is a future it returns immediately and then the program exits. You can wrap it in Await.ready to block it until the server shuts down like so:
Await.ready(Http.server.serve(":8080", api.toServiceAs[Text.Plain]))

I can confirm this is how we use Finch, as well


How to load the local pre-trained checkpoint and then fine-tune with the dataset

Is your feature request related to a problem? Please describe.
I face the problem of loading the local huggingface checkpoint to fine-tune on the etth1. I have to download the model weights because our GPU nodes can't reach the huggingface.  So do how I load the local checkpoint and then fine-tune it? Thanks a lot!

https://github.com/SalesforceAIResearch/uni2ts/blob/main/cli/conf/finetune/model/moirai_1.0_R_small.yaml
https://github.com/SalesforceAIResearch/uni2ts/blob/main/cli/conf/finetune/model/moirai_small.yaml
Please see these 2 files, depending if you want to load the huggingface_hub file or the lightning checkpoint.

https://github.com/SalesforceAIResearch/uni2ts/blob/main/cli/conf/finetune/model/moirai_1.0_R_small.yaml
https://github.com/SalesforceAIResearch/uni2ts/blob/main/cli/conf/finetune/model/moirai_small.yaml
Please see these 2 files, depending if you want to load the huggingface_hub file or the lightning checkpoint.

Thanks for the help, I have solved the problem.


Close eBPF tracker cleanly

Fixes #2536 by pulling in https://github.com/weaveworks/tcptracer-bpf/pull/42

LGTM


Error: ‘entt::registry’ {aka ‘entt::basic_registry<>’} is not a template

Hey there!
I'm trying to use the entt::registry like was solved in this another ticket:
https://github.com/skypjack/entt/issues/197
But it saying that entt::registry is not a template. How to solve it?
Thanks

It's entt::basic_registry. If the goal is to use a custom entity type, it's:
using my_registry_type = entt::basic_registry<my_entity_type>;

After almost a week of inactivity, I guess this one is solved. Feel free to comment or reopen the issue if this isn't the case.


Absence of stable selector for general-module-panel

For the Howe Sound integration I needed to restyle the general module panel to be fixed-sized with a scrollbar overflow, but since it didn't have a stable classname of its own I had to use a "flying blind" selector as so:
#inat-components > div > div:last-child {
....

https://github.com/IMERSS/howe-sound-mapping/blob/main/src/css/howe.css#L96
Most straightforwardly this could be resolved by simply issuing a stable classname like the one emitted for inat-tabs but I notice that there are already plenty of classnames for internal use of the form general-module_panel__WjWzy - I understand the intent here is precisely to stop markup being hit "collaterally" by selectors not written by the original author as part of their build process, but I wonder whether the most economical thing in the long run might be to disable the name mangling which makes them unstable?

Sure, np. I'll add some more classes to the classes prop for the TaxonPanel component, namely:
<TaxonPanel   ...    classes={{     ...      recentObservationsPanel: '...',      commonTaxaPanel: '...',     favouritesPanel: '...',     statsPanel: '...',   }} />
These'll be appended to the same DOM element you mentioned so consumers can add their own styling - that's the purpose of the classes prop. The existing classes with the random suffix are fine - they're for internal styling purposes only.


Issue with switching scenes

System information

OS Platform and Distribution (e.g., Linux Ubuntu 20.04, WSL2): Windows
Target (e.g. desktop cpu, android arm64): android arm64
Bazel version: 4.0.0
Python version: 3.9
GCC/G++ version: 11.1.0
Unity version: 2020.3.8f1
Android NDK version (if building for Android): 4.9
Xcode version (if building for iOS):

Describe the problem
The camera was working fine after being launched on android. However, after I switched to another scene and returned, the camera stopped working and show the error.
Full logs
setView = com.android.internal.policy.DecorView@5e69823 TM=true
Relayout returned: old=(0,0,1080,2280) new=(0,108,1080,2280) req=(1080,2280)0 dur=22 res=0x7 s={true<PHONE_NUMBER>48} ch=true fn=-1
[DP] dp(1) 1 android.view.ViewRootImpl.reportNextDraw:10957 android.view.ViewRootImpl.performTraversals:3845 android.view.ViewRootImpl.doTraversal:2618
[DP] dp(2) 1 android.view.SurfaceView.updateSurface:1311 android.view.SurfaceView$1.onPreDraw:225 android.view.ViewTreeObserver.dispatchOnPreDraw:1124
[DP] pdf(1) 1 android.view.SurfaceView.notifyDrawFinished:577 android.view.SurfaceView.performDrawFinished:564 android.view.SurfaceView.lambda$TWz4D2u33ZlAmRtgKzbqqDue3iM:0
[DP] pdf(0) 1 android.view.ViewRootImpl.performDraw:4809 android.view.ViewRootImpl.performTraversals:3866 android.view.ViewRootImpl.doTraversal:2618
[DP] rdf()
MSG_WINDOW_FOCUS_CHANGED 1 1
MemoryManager: Using 'Dynamic Heap' Allocator.
Relayout returned: old=(0,108,1080,2280) new=(0,108,1080,2280) req=(1080,2172)0 dur=13 res=0x1 s={true<PHONE_NUMBER>48} ch=false fn=2
updateBoundsLayer: shouldReparent = false t = android.view.SurfaceControl$Transaction@1ee2f80 sc = Surface(name=Bounds for - com.yitec.tryon/com.unity3d.player.UnityPlayerActivity@0)/@0x1e369b9 frame = 2
SystemInfo CPU = ARM64, Cores = 8, Memory = 7423mb
SystemInfo ARM big.LITTLE configuration: 2 big (mask: 0xc0), 6 little (mask: 0x3f)
ApplicationInfo com.yitec.tryon version 0.1 build d587582f-aa1f-4f1a-b48f-20685f9d0a8a
Built from '2020.3/staging' branch, Version '2020.3.8f1 (507919d4fff5)', Build type 'Release', Scripting Backend 'il2cpp', CPU 'arm64-v8a', Stripping 'Disabled'
Relayout returned: old=(0,108,1080,2280) new=(0,108,1080,2280) req=(1080,2172)0 dur=29 res=0x1 s={true<PHONE_NUMBER>48} ch=false fn=3
[DP] dp(1) 1 android.view.SurfaceView.updateSurface:1311 android.view.SurfaceView.setFrame:646 android.view.View.layout:24472
[DP] pdf(0) 1 android.view.SurfaceView.notifyDrawFinished:577 android.view.SurfaceView.performDrawFinished:564 android.view.SurfaceView.lambda$TWz4D2u33ZlAmRtgKzbqqDue3iM:0
[DP] rdf()
MSG_RESIZED_REPORT: frame=(0,108,1080,2280) ci=(0,0,0,0) vi=(0,0,0,0) or=1
[DP] dp(1) 1 android.view.ViewRootImpl.reportNextDraw:10957 android.view.ViewRootImpl.access$1200:256 android.view.ViewRootImpl$ViewRootHandler.handleMessage:6101
Company Name: Yitec
Product Name: TryOn
Relayout returned: old=(0,108,1080,2280) new=(0,108,1080,2280) req=(1080,2172)0 dur=24 res=0x1 s={true<PHONE_NUMBER>48} ch=false fn=5
[DP] pdf(0) 1 android.view.ViewRootImpl.performDraw:4809 android.view.ViewRootImpl.performTraversals:3866 android.view.ViewRootImpl.doTraversal:2618
[DP] rdf()
Relayout returned: old=(0,108,1080,2280) new=(0,0,1080,2280) req=(1080,2172)0 dur=20 res=0x21 s={true<PHONE_NUMBER>48} ch=false fn=8
updateBoundsLayer: shouldReparent = false t = android.view.SurfaceControl$Transaction@1ee2f80 sc = Surface(name=Bounds for - com.yitec.tryon/com.unity3d.player.UnityPlayerActivity@0)/@0x1e369b9 frame = 8
[DP] dp(1) 1 android.view.SurfaceView.updateSurface:1311 android.view.SurfaceView.setFrame:646 android.view.View.layout:24472
[DP] pdf(0) 1 android.view.SurfaceView.notifyDrawFinished:577 android.view.SurfaceView.performDrawFinished:564 android.view.SurfaceView.lambda$TWz4D2u33ZlAmRtgKzbqqDue3iM:0
[DP] rdf()
ViewPostIme pointer 0
ViewPostIme pointer 1
WebCamDevice Changed: Camera 0
WebCamDeviceSelectorController:OnValueChanged(Dropdown)
d__2:MoveNext()
UnityEngine.SetupCoroutine:InvokeMoveNext(IEnumerator, IntPtr)
WebCamTexture Graphics Format: 88
d__16:MoveNext()
UnityEngine.SetupCoroutine:InvokeMoveNext(IEnumerator, IntPtr)
SceneDirector:ResetCamera(Nullable1) SceneDirector:ChangeWebCamDevice(Nullable1)
WebCamDeviceSelectorController:OnValueChanged(Dropdown)
d__2:MoveNext()
UnityEngine.SetupCoroutine:InvokeMoveNext(IEnumerator, IntPtr)
EGL Context Found<PHONE_NUMBER>36)
SceneDirector:SetupGpuResources()
SceneDirector:StartGraph()
SceneDirector:ChangeWebCamDevice(Nullable`1)
WebCamDeviceSelectorController:OnValueChanged(Dropdown)
d__2:MoveNext()
UnityEngine.SetupCoroutine:InvokeMoveNext(IEnumerator, IntPtr)
hand_landmark is saved to /storage/emulated/0/Android/data/com.yitec.tryon/files/Cache/hand_landmark.bytes (length=3792620)
Mediapipe.AssetBundleManager:WriteCacheFile(TextAsset, String, Boolean)
HandTrackingGraph:PrepareDependentAssets()
DemoGraph:Initialize()
DemoGraph:Initialize(GpuResources, GlCalculatorHelper)
d__25:MoveNext()
UnityEngine.SetupCoroutine:InvokeMoveNext(IEnumerator, IntPtr)
hand_recrop is saved to /storage/emulated/0/Android/data/com.yitec.tryon/files/Cache/hand_recrop.bytes (length=123792)
Mediapipe.AssetBundleManager:WriteCacheFile(TextAsset, String, Boolean)
HandTrackingGraph:PrepareDependentAssets()
DemoGraph:Initialize()
DemoGraph:Initialize(GpuResources, GlCalculatorHelper)
d__25:MoveNext()
UnityEngine.SetupCoroutine:InvokeMoveNext(IEnumerator, IntPtr)
handedness is saved to /storage/emulated/0/Android/data/com.yitec.tryon/files/Cache/handedness.txt (length=11)
Mediapipe.AssetBundleManager:WriteCacheFile(TextAsset, String, Boolean)
HandTrackingGraph:PrepareDependentAssets()
DemoGraph:Initialize()
DemoGraph:Initialize(GpuResources, GlCalculatorHelper)
d__25:MoveNext()
UnityEngine.SetupCoroutine:InvokeMoveNext(IEnumerator, IntPtr)
palm_detection is saved to /storage/emulated/0/Android/data/com.yitec.tryon/files/Cache/palm_detection.bytes (length=3877888)
Mediapipe.AssetBundleManager:WriteCacheFile(TextAsset, String, Boolean)
DemoGraph:Initialize()
DemoGraph:Initialize(GpuResources, GlCalculatorHelper)
d__25:MoveNext()
UnityEngine.SetupCoroutine:InvokeMoveNext(IEnumerator, IntPtr)
Loaded dependent assets
DemoGraph:Initialize()
DemoGraph:Initialize(GpuResources, GlCalculatorHelper)
d__25:MoveNext()
UnityEngine.SetupCoroutine:InvokeMoveNext(IEnumerator, IntPtr)
ViewPostIme pointer 0
ViewPostIme pointer 1
ViewPostIme key 0
ViewPostIme key 1
ViewPostIme pointer 0
ViewPostIme pointer 1
HANDEDNESS:Right
HandTrackingAnnotationController:Draw(Transform, List1, List1, List1, List1, Boolean)
HandTrackingGraph:RenderOutput(WebCamScreenController, TextureFrame)
d__25:MoveNext()
UnityEngine.SetupCoroutine:InvokeMoveNext(IEnumerator, IntPtr)
HANDEDNESS:Right
HandTrackingAnnotationController:Draw(Transform, List1, List1, List1, List1, Boolean)
HandTrackingGraph:RenderOutput(WebCamScreenController, TextureFrame)
d__25:MoveNext()
UnityEngine.SetupCoroutine:InvokeMoveNext(IEnumerator, IntPtr)
ViewPostIme key 0
ViewPostIme key 1
HANDEDNESS:Left
HandTrackingAnnotationController:Draw(Transform, List1, List1, List1, List1, Boolean)
HandTrackingGraph:RenderOutput(WebCamScreenController, TextureFrame)
d__25:MoveNext()
UnityEngine.SetupCoroutine:InvokeMoveNext(IEnumerator, IntPtr)
ViewPostIme pointer 0
ViewPostIme pointer 1
ViewPostIme pointer 0
ViewPostIme pointer 1
WebCamDevice Changed: Camera 0
WebCamDeviceSelectorController:OnValueChanged(Dropdown)
d__2:MoveNext()
UnityEngine.SetupCoroutine:InvokeMoveNext(IEnumerator, IntPtr)
WebCamTexture Graphics Format: 88
d__16:MoveNext()
UnityEngine.SetupCoroutine:InvokeMoveNext(IEnumerator, IntPtr)
SceneDirector:ResetCamera(Nullable1) SceneDirector:ChangeWebCamDevice(Nullable1)
WebCamDeviceSelectorController:OnValueChanged(Dropdown)
d__2:MoveNext()
UnityEngine.SetupCoroutine:InvokeMoveNext(IEnumerator, IntPtr)
EGL Context Found<PHONE_NUMBER>36)
SceneDirector:SetupGpuResources()
SceneDirector:StartGraph()
SceneDirector:ChangeWebCamDevice(Nullable`1)
WebCamDeviceSelectorController:OnValueChanged(Dropdown)
d__2:MoveNext()
UnityEngine.SetupCoroutine:InvokeMoveNext(IEnumerator, IntPtr)
The AssetBundle 'mediapipe' can't be loaded because another AssetBundle with the same files is already loaded.
Mediapipe.AssetBundleManager:LoadAssetBundle()
Mediapipe.AssetBundleManager:PrepareAsset(String, String, Boolean)
HandTrackingGraph:PrepareDependentAssets()
DemoGraph:Initialize()
DemoGraph:Initialize(GpuResources, GlCalculatorHelper)
d__25:MoveNext()
UnityEngine.SetupCoroutine:InvokeMoveNext(IEnumerator, IntPtr)
[ line -1123386392]
NullReferenceException: Object reference not set to an instance of an object.
at Mediapipe.AssetBundleManager.PrepareAsset (System.String name, System.String uniqueKey, System.Boolean overwrite) [0x00000] in <00000000000000000000000000000000>:0
at HandTrackingGraph.PrepareDependentAssets () [0x00000] in <00000000000000000000000000000000>:0
at DemoGraph.Initialize () [0x00000] in <00000000000000000000000000000000>:0
at DemoGraph.Initialize (Mediapipe.GpuResources gpuResources, Mediapipe.GlCalculatorHelper gpuHelper) [0x00000] in <00000000000000000000000000000000>:0
at SceneDirector+d__25.MoveNext () [0x00000] in <00000000000000000000000000000000>:0
at UnityEngine.SetupCoroutine.InvokeMoveNext (System.Collections.IEnumerator enumerator, System.IntPtr returnValueAddress) [0x00000] in <00000000000000000000000000000000>:0

I have the fixes for this, in Webcamscreencontroller, add
`    private void OnApplicationQuit()
{
webCamTexture.Stop();
webCamTexture = null;
pixelData = null;
}
private void OnDisable()
{
if (webCamTexture != null)
{
webCamTexture.Stop();
webCamTexture = null;
}
    pixelData = null;
}`

Then also swap these files out in your project to see if it works, if not then look at what I did in them, I just made sure to unloadassetbundles when the scene is left so they can be reloaded
tofix.zip

Thank you, it works perfectly.

@homuler rather than me making a new issue for this, I was noticing crashes in editor/build when reloading scenes until I made these changes:

Disable Glog in Bootstrap.cs
In ResourceManager.cs, comment out line 36 as                    //throw new InvalidOperationException("ResourceManager can be initialized only once");
In WebCamSource.cs, add the following lines to clean up WebcamTexture on destroy:

        private void OnDestroy()
        {
            if (_webCamTexture != null)
            {
                _webCamTexture.Stop();
                _webCamTexture = null;
            }
        }
        private void OnApplicationQuit()
        {
            _webCamTexture.Stop();
            _webCamTexture = null;
        }

Is this the correct way to deal with reloading a scene? We are only using Hand tracking across scenes and by doing this it works fine.

@ROBYER1

Is this the correct way to deal with reloading a scene?

The sample scenes (and code under Assets/MediaPipeUnity) are implemented for demonstration purposes and not intended to be reused in different contexts, so if you're reloading the scene in a different way than the sample app does, it would be wrong.
With that in mind, in order to reuse the code, you should note that what Bootstrap does must be executed only once (cf. https://github.com/homuler/MediaPipeUnityPlugin/issues/446#issuecomment-1033793353).
As for WebCamSource, I think you should stop it before reloading the scene.


ALE's color_averaging option is on by mistake

I need to turn it off to make the environment more equivalent to theirs.

Turned it off with https://github.com/muupan/async-rl/commit/a9c02fd292ec04a4e3e110d87622d68b79b993db


[JS unit tests] Not pull libusb tests in Connector

Exclude libusb's JS unit tests when compiling Connector's JS unit tests, so that the former aren't executed twice in both targets.
As a drive-by, fix accidentally added excessive exclamation mark in one of the file patterns.

Thank you!

yeah unfortunately this tedious include-exclude story continues :unamused:


Rabin-Karp Algorithm and KMP Algorithm

I want to add Rabin-Karp Algorithm and KMP algorithm (for pattern searching in a String) in Strings Folder. Please assign me this issue..

Sure @dhanashreeg368 , you can go ahead !

Can I work on this issue?

I am already working on it.

Which language are you contributing in @dhanashreeg368 ?

@smv1999 Can I work in C++.

I am contributing in C++ language.

@harshita9621 you can work on the same problem in some different language, please raise a different issue for that.


refactor: change CookieSameSite to be an enum

This changes the CookieSameSite type to be an enum, which allows us to be more consistent when using the SameSite value across the codebase.
/cc @markcellus @koddsson

Maybe we should remove Travis at this point since it's a lot slower than GitHub Actions 🤔

Yeah I noticed that. should be fine to just remove it right?


Remove Circular Build Dependency

Resolves https://github.com/hotwired/turbo/pull/1026#issuecomment-1782605125

Thanks!

@seanpdoyle I think removing the StreamActions export broke the turbo-rails system tests, as they are using it here.
See https://github.com/hotwired/turbo-rails/actions/runs/6971461623/job/18971576977


Can't capture the output

myip ipsb > file.txt

gives an empty file,  how do I capture the output?

It output the STDERR, so try:
myip ipsb 2> file.txt

Ahhh and I thought I had tried that, thank you!!


validator string coercion

pre 5.x.x this code worked great in validator:
validator = require 'validator'
t =
 hello:
   how: 'how'

param = validator.trim(validator.stripLow(t.hello.nope))

now it throws TypeError: This library (validator.js) validates strings only
Ok, whatever. I coerce my string as the docs suggest:
param = validator.trim(validator.stripLow(t.hello.nope + ''))

param used to have an empty string if the parameter was missing, but now I always get undefined as a string.
This is kind of a big issue for optional parameters in an interface.

It's true that undefined + '' === 'undefined'.
If you know that your param is either a string or undefined then you could either:
param = t.hello.nope
if (param) {
    param = validator.trim(validator.stripLow(param))
} eles {
    // param was not specified
}

Or use a ternary:
param = t.hello.nope
param = validator.trim(validator.stripLow(param ? param : ''))

This is a low-level string validation library and handling coercion or optional parameters is outside the scope of the library. There are plenty of higher-level libraries that you might find more suitable, e.g. https://github.com/nettofarah/property-validator or https://github.com/ctavan/express-validator.


The Client can't seem to invoke the methods on the server even after passing the correct name of the methods

Hi, Sorry I'm having issues with the front end not being able to call the method on the server to retrieve message history even after authentication is approved.

Please re-open this issue using the This page feedback button and form at the bottom of the English-US topic. Use of the This page feedback form adds metadata to your GitHub issue that cross-links the topic and automatically pings the author.


Fail ffmpeg.so.56 on Ubuntu 20.04

[x] I have read the FAQ.
[x] I have searched in existing issues.

Environment

OS: Ubuntu 20.04 64 bits
scrcpy version: last in apt
installation method: apt install scrcpy

Describe the bug
When executing the command scrcpy the error occurs as shown below.
When ubuntu 16.04 worked normal, however in 20.04 with the recent version it doesn't work anymore.
USER:~$ scrcpy
scrcpy: error while loading shared libraries: libavformat-ffmpeg.so.56: cannot open shared object file: No such file or directory

Because you used a version compiled against libs in an old Ubuntu. You should delete/rebuild.

I delete scrcpy:
sudo apt remove scrcpy
and instal again:
sudo apt install scrcpy
The error remains the same.
But I think apt installed version 1.12
see the terminal:
~$ sudo apt-get install scrcpy

Reading package lists... Done
Building dependency tree
Reading state information... Done
The following additional packages will be installed:
  scrcpy-server
The following NEW packages will be installed:
  scrcpy scrcpy-server
0 upgraded, 2 newly installed, 0 to remove and 0 not upgraded.
Need to get 56,4 kB of archives.
After this operation, 132 kB of additional disk space will be used.
Do you want to continue? [Y/n] Y
Get:1 http://archive.ubuntu.com/ubuntu focal/universe amd64 scrcpy-server all 1.12.1+ds-1 [27,0 kB]
Get:2 http://archive.ubuntu.com/ubuntu focal/universe amd64 scrcpy amd64 1.12.1+ds-1 [29,4 kB]
Fetched 56,4 kB in 1s (46,3 kB/s)
Selecting previously unselected package scrcpy-server.
(Reading database ... 269770 files and directories currently installed.)
Preparing to unpack .../scrcpy-server_1.12.1+ds-1_all.deb ...
Unpacking scrcpy-server (1.12.1+ds-1) ...
Selecting previously unselected package scrcpy.
Preparing to unpack .../scrcpy_1.12.1+ds-1_amd64.deb ...
Unpacking scrcpy (1.12.1+ds-1) ...
Setting up scrcpy-server (1.12.1+ds-1) ...
Setting up scrcpy (1.12.1+ds-1) ...
Processing triggers for man-db (2.9.1-1) ...

You probably have some binary in /usr/local.
which scrcpy

GREAT, that's works !
Deleted the file and did it again.
Thanks!
but I still think apt is using version 1.12,
~$ scrcpy
INFO: scrcpy 1.12.1 <https://github.com/Genymobile/scrcpy>
/usr/share/scrcpy/scrcpy-server: 1 file pushed. 5.2 MB/s (24773 bytes in 0.005s)
INFO: Initial texture: 720x1440

But it's working now!

Yes, for the latest version, I suggest you build from sources :)
Even better, if you could build from the version in #1598, then you could beta-test the future version and give feedbacks :)


[FT] Memory improv

Memory interface improved a lot to have a client cast free malloc and realloc. Now the functions to use are:

malloc -> allocate
realloc -> reallocate
free -> delete

Do not use Allocators anymore and also old use memory should be changed to new one.
For more functions and documentation have a look at the file documentation

@Mogball we have to clean up the code to remove Allocators and use Memory.h everywhere

Roger that @dhillondeep, I was planning a cleanup of some of the classes soon anyway and I can do that as well (after I fixup the state machine I shamelessly stole borrowed from the dude we also took Allocator from lol)

Labelling as in progress until improper usage of Allocator is purged


EnableAccountManager in text on Intune says that only for HoloLens devices

When I go to the Shared Multi-user device in Device configuration Profiles in Intune at the configuration of options there is a text that is saying the following:
Configure access, account deletion, maintenance, and power management settings for your shared Windows 10 device used by multiple users in your organization.
In organizations where multiple OS versions are supported, these settings may not apply across all versions the same. Account manager settings are the only settings applicable to HoloLens devices.
But on the doc's page I don't find anything about this so what is right the Intune portal or the docs?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: e3329b98-7e66-aa67-d27e-d14471cf63b3
Version Independent ID: e6c88589-b252-4e9c-6016-8b53154dce96
Content: SharedPC CSP
Content Source: windows/client-management/mdm/sharedpc-csp.md
Product: w10
GitHub Login: @MariciaAlforque
Microsoft Alias: maricia

@officedocsbot assign @mypil

@aavdberg Thank you for sharing your feedback. Can you please share more details and screenshots so that we can better help you and make the necessary changes in the doc.
For Hololens devices, please visit https://docs.microsoft.com/en-us/hololens/ for details. You will find details regarding hololens and managing it using MDM.
Thanks.

@aavdberg - From our understanding, the issue you raised has been answered by joinimran. If you feel it hasn't been answered, please re-open this issue.
Thank you for your contribution to make the docs better! Much appreciated!

@officedocsbot close


Add yaml make_safe function

closes #203

Coverage increased (+0.03%) to 85.841% when pulling f7debe577269081e0ef73cb07fbe56ef63c26758 on fix-yaml into 7516e234211202fe369cdaba2599e793bd86457c on dev.


Add regex or asterisk support

It would be really convenient to be able to specify the URL not only by specific domain, but also by more general terms. Either full regex or just * in the name.
git*b.com - this would block Github and Gitlab at the same time

Seems reasonable, but it might take some time to implement.

This was added in 2.0.0


Adjust Code Tab Size to 4 in Markdown Preview

This issue has been created for tracking purposes. I have created a PR for this feature already: https://github.com/microsoft/vscode/pull/77745
Please set the default tab size to 4 in the Markdown preview for code blocks in Markdown documents. I consider a tab size of 4 being standard and the default of 8 being unbearable. The few people, if any, using a different tab size than 4 can use the custom markdown preview style feature, if it is going to be fixed anytime (https://github.com/microsoft/vscode/issues/77290).

Fixed by #77745


In Releases page, point to plugin docs when mentioning a plugin

Pull Request Checklist

[x] implement the feature
[x] write the documentation
[x] include a release note

I think it's worth to mention the new docs best practices in the release notes as well, done in 88b6434a.


CB-9623 Add WorkloadAnalitycs + Log collection features

See detailed description in the commit message.

how will this overlap with AccountTelemetry settings?

If the account-level settings are reflected in the environment level settings then they will be logged, otherwise we won't log them


Update README.md

Corrected a few typos that could potentially upset the description of this fantastic repo!

Good catches!


Update examples to built in board MidiHandlers

Added a MidiHandler and Init to each breakout board (among other things) here.
This PR will update the three relevant examples to use those new handlers.

this works, and fixes some issues that exist in the current implementation (i.e. Clock messages stalling the state machine, etc.).
I do want to add unit tests to validate the parser functionality before we make further changes, or rework any of the MidiEvent stuff, but I don't want to leave MIDI partially broken in the meantime. So I think for now this is good to go.


The CheckPaddingOverflow function missed checking some padding values

op_context->dims refers to the input tensor's dimensions. The shape of paddings_data should be op_context->dims * 2.

Google CLA signing has been completed


Introduce DtabStore.Proxy type to support store-agnostic validation

We'll need to be perform write validation in an interface- and store-agnostic
way.
In order to support this, a DtabStore.Proxy type can be used to wrap DtabStores
with behavior. A special DtabStore.Validator type is introduced to provide a
basis for write validation.
Furthermore, type aliases are introduced to make the interface somewhat purer -- the interface should talk about Namespaces and Versions not Strings and Bufs.

nice

LGTM pending @adleong's note about the type alias duplication between io.buoyant.namerd.DtabStore.Namespace and io.buoyant.namerd.Ns.

:star: 🐙

will merge once 0.3.1 is tagged


How to change the new "game library banner" image?

Feature Description
Hi there, love your theme so much! I also really like the new feature you just added recently, that shows a game banner above the box art in grid view. You call it "game library banner".
I have a question, I have many games manually added to my Playnite library which are not synced from an integration. I have my own organization to separate the sources of these manually installed games (VR, Emulators, etc) as separate Source and Platform.
Anyway, I cant seem to find a way to change the banner for these manually added games. It seems that all manually added games are given the same banner, orange with a playnite logo on the left. All the games added via an Integration do in fact have their own image and banner color.
Is there any way to change the banner image for manually added games? I would love to be able to change it based on either Source, or Platform.
If this is outside the scope of your addon, but there is another way to handle this with another addon or directly in Playnite, please let me know if you know how. Thanks!
PS- I dont mind manually editing xml/yaml files, and adding my own images to the Images/Banners folder (within your skin subfolder).
Screenshots

I'm afraid that adding support to Sources, Platforms or any other field is a no go from me. It needs to be done using a field that all games always have and can't be changed, like the PluginId in my implementation.
I've seen that other themes do it but with all respect, the solutions are very hacky and have numerous issues that I'm not okay with adding for my themes:

They do it by accessing the game property list by index, for example: game.Platforms[0].Name. This is a bad idea because the list those properties can be Null or not have items. Accessing like this is not a good idea

After getting the Platform name like that, then the theme tries to load an image with that name like C:\ThemePath\Xbox 360.png This results in tons of errors if the expected image is not there

This doesn't take into account if there are invalid characters in the Platform name that can't be used in filenames

This solution requires hardcoded platform names. If the name changes, the banners will break.

After all that, the banner is loaded for every game. This results in a significant performance and memory usage hit.

I implemented banners in a different way to how it's been done before in other themes and doesn't carries these issues but has the limitation of only be able to use PluginIds. I think I'd be a cool feature but for those reasons unfortunately I can't add support for that. This will have to wait until there's native support in Playnite or if someone makes an extension for that.

To change existing banners, you can replace the images in the .\Images\Banners directory https://github.com/darklinkpower/Stardust/tree/master/source/Images/Banners
Only banners for plugins are supported and are references by the Plugin Guid. Here's an example of how to add new ones https://github.com/darklinkpower/Stardust/commit/1fd1579accd3d7e77a4ec30de1c57a29a628f246

The reason why the games you mention use the orange/Generic Playnite banner is because they are handled by Playnite and not by a library plugin.

I see, ok this makes sense the way you've explained it. It's unfortunate that it's this complicated to implement.
So in other words, if a library integration addon (like Steam, Humble, Ichio, etc) imports a game, that game has a Plugin ID associated to it, which your theme uses to reference to show the respective banner. But games added manually do not have a Plugin ID, or they all use the same generic one, which is why they have their own banner.
With this limitation being the case, if I wanted to have specific banners for different types of locally/manually installed games, e.g. manually added Android games, for keeping track of them in Playnite, I (or someone) would need to make a library integration addon, which serves to assign Plugin IDs to specifically chosen games. I'm not sure in the slightest how possible this would be, but following the logic of how other integration addons work, this seems to be the case. I wish this were easier to do on the fly.
One more question that just popped into my head as I typed this out: Let's say the above was possible, creating our own integration plugin to manage manually installed games / non-games, would it be fairly easy to create our own banners within your theme, associate them to the Plugin ID (somehow), and effectively make our own banners?
If you can tell, I am grasping at straws trying to think of any way this might be possible, before I give up on the idea.

But games added manually do not have a Plugin ID, or they all use the same generic one, which is why they have their own banner.

All games have a pluginId. Games handled by Playnite (Including manually added games) have an empty Guid, which is what the theme uses https://github.com/darklinkpower/Stardust/blob/5eb176e81720d7bc4db7bd21c16519a202a02825/source/DerivedStyles/GridViewItemTemplate.xaml#L190

One more question that just popped into my head as I typed this out: Let's say the above was possible, creating our own integration plugin to manage manually installed games / non-games, would it be fairly easy to create our own banners within your theme, associate them to the Plugin ID (somehow), and effectively make our own banners?

In that case, you would need to implement what Playnite does to handle those games again in the plugin, including game handling and it would not be compatible with emulates games, unless you also implement all emulation stuff again. You also would need to implement how to assign pluginIds to specific games, etc. I also don't like the idea of using workarounds/hacks to implement this functionality and I think any additional effort like that should be directed towards either making an extension that handles this in a clean and proper way or to implement it in Playnite itself.

I investigated and found a way to add platform banners in a clean way.
https://user-images.githubusercontent.com/1389286/165879907-a3ed5c44-53c8-4fb9-9cd5-6c888fd18d27.mp4
If you are interested to help please contact me in the Playnite discord.


Fix docs

if you find other problems in josh api reference, feel free to commit 😉

api-docs.md is autogenerated by the script, please take a look at /docs/build.js for that script. The MD output should not be directly modified.

I did not modify it, i ran build.js iirc


replace querystring

Description:
Deprecated libs (querystring)
Code to reproduce:
//this one
var query = querystring.stringify({
  mod, action, apiKey, bool
})

//change into this
const dat = new URLSearchParams({
  mod, action, apiKey, bool
}).toString()

Reason
querystring was deprecated at least since last LTS version 14.
cc @sebs

erm .. yeah ;) sounds like a plan

Sure, can I make a pull request?

sure .. do so

fixed in 10.3.0


link to ESLint repo on source code page.

The Source code page has a link to github in it's opening sentence:
ESLint is hosted at GitHub...
but originally the link simply opened up github.com, which is not as useful or relevant than pointing to the actual source code on github, since this is the "source code" page. So this PR aims to update that link to the actual source code.
Thanks for all the awesome work you do!! I :heart: ESLint.

Thanks!

:+1:


feat(arm): run github actions on arm too

:warning: Please install the  to ensure uploads and comments are reliably processed by Codecov.
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 87.35%. Comparing base (490844e) to head (0feb05d).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #184   +/-   ##
=======================================
  Coverage   87.35%   87.35%
=======================================
  Files          11       11
  Lines         973      973
  Branches      286      286
=======================================
  Hits          850      850
  Misses        123      123

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Remove deprecated bundler option

I think this does the right thing.
With the original code:

And with the PR:

DOC-161

I built the Dockerfile locally and this works as advertised :tada:
I was a bit surprised at the hoops we jump through when calling bundle install here - I'm guessing it's an attempt to make the Dockerfile suitable for production and dev/test workflows. All good, I'm confident it'll work fine in prod.
I might rebase and force push to confirm everything still works with current main.


Can you provide an example of multi-label classification?

Hi! Thank you so much for this great lib! It's awesome!
Could you please provide us an example of multi-label classification such as "toxic comments"?
Thanks a lot!

Will add that to the do list ... but you can probably do this before we do :).
Take a look at the "sequence classification" notebook in the docs.  For multi-classification, you just need to use a MultiCategoryBlock instead of the CategoryBlock (see here for more info).
Everything you need to prepare your data for multi-label is in the fastai docs.

Thank you so much for your reply! :)

Here ya go ... hope its helpful:
https://ohmeow.github.io/blurr/modeling-core/#Example-usage---Multi-label-classification

Great job! Thank you so much! :)


High DPI support

🤔😅

How would this help? I don't know what the hell a DPI is, but I suspect it's related to the screen?

Dots Per Inch, pretty much screen resolution


MSPSDS-764: Remove business tab and partial from products

Tiny change after clarification on a ticket

Pull Request Test Coverage Report for Build 1582

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.9%) to 96.539%

Totals

Change from base Build 1566:
0.9%

Covered Lines:
3236

Relevant Lines:
3352

💛  - Coveralls


Copy pasted Hello texture and named it Hello compute

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: IgrauBezRuk sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.


Add indentation from https://github.com/pangloss/vim-javascript

It's frustrating to require multiple plugins to handle Javascript files in vim. However, this plugin clearly has the better syntax options of the two. Therefore I propose we merge in the indentation settings from pangloss' repo.

Indentation in Vim is a mixed bag, specially in a language like JavaScript. I use this file to test indent files.
With that said, of all the indent files I've encountered (inc. Pangloss'), This one from Preston Koprivica has the least errors while indenting. If any of you find a better one or would like to continue to improved it, please fork it and do so.
Also this project is intended for the syntax file only. But now, with plugin managers (Vundle, VimPlug, etc.) is a lot easier to maintain other files.


Generate credential API docs for the Credential Capabilities

[ ] Generate the API documents for the Credential capabilities of the plugins.
[ ] expose these documents to the end-users.

let me do it


根据文档创建后在ip neigh中没有找到LoadBalancer地址

根据文档创建后在ip neigh中没有找到LoadBalancer地址, 而且为什么ip neigh显示的mac地址都是一样的 ，4台腾讯云服务器
node：

svc:

ip neigh:

不过LoadBalancer地址是可以通的：

You should not check the arp table on the nodes of the kubernetes cluster, you should check it on the client machine.

You should not check the arp table on the nodes of the kubernetes cluster, you should check it on the client machine.

You should not check the arp table on the nodes of the kubernetes cluster, you should check it on the client machine.

yeah , i checked on client machine , it works.

When accessing services within the cluster, the access is achieved through ipvs or iptables instead of openelb.
ok, thanks for answering

the ip neigh show my loadBalancer extenal ip, but can't ping

I think so. You try to find the reason why the mac address of all nodes is the same, and you can use tcpdump to analyze where the packets are lost.


Migrating Trace.V2 to GAPIC v2 and microgenerator

(We have to do this in one step as there's no equivalent of "use common resource names for monolithic generator with gapic v2 config".)

(Ready for review now - sorry for the brokenness before; had forgotten to git add the new files.)


Very large TFS repo —  from a subfolder

Hi folks,
I will tremendously appreciate all advice on how to proceed with the following task at hand. I have read fairly thoroughly the documentation on git-tfs clone, git-tfs quick-clone and git-tfs branch but still haven't been able to break into this problem.
Our TFS codebase is TERRIBLY LARGE (it is so because for odious reasons it contains large BLOBs and such). It is however fairly well organized and has the following structure:
 $/TeamProject/Dev (TERRIBLY LARGE)
  |
  +- $/TeamProject/Dev.EpicX (TERRIBLY LARGE)
  |
  +- $/TeamProject/Dev.EpicY (TERRIBLY LARGE)
  |
  +- $/TeamProject/Dev.EpicZ (TERRIBLY LARGE)

Each one of these branches are branches in TFS (-vs- just branched "folders"). We can think of the Dev branch as the main integration branch. These branches contains our solutions and projects, as well as several other resources (as I mentioned, BLOBs, etc...)
As I said, due to the ridiculous size of these branches, most of us do not even bother fetching the entire branch, but rather only the corresponding solution we are working on. For example, I am working at $/TeamProject/Dev.EpicY/Foo/Bar/SolutionDirectory in the Dev.EpicY branch. The size of these sources is much more manageable (~200MB)
It is under this $/TeamProject/Dev.EpicY/Foo/Bar/SolutionDirectory that I want to work on and use git and enjoy its powerful features under my own local repo with my own branches and without affecting my colleagues by committing to TFS. I also want to be able to forward-integrate by "merging" from the corresponding "parent" $/TeamProject/Dev/Foo/Bar/SolutionDirectory .
What I have tried
First: Clone with all branches
I'm not interest in past history of the project, so I am thinking to use git tfs quick-clone.
git tfs quick-clone http://tfs-server/Collection $/TeamProject/Dev.EpicY/Foo/Bar/SolutionDirectory . --branches=all
git tfs quick-clone http://tfs-server/Collection $/TeamProject/Dev/Foo/Bar/SolutionDirectory . --branches=all
When I do this I didn't get the parent-child branching relationship between Dev and Dev.EpicY. For example:
git tfs branch

Git-tfs remote details:
default -> http://tfs-server/Collection $/TeamProject/Dev/Foo/Bar/SolutionDirectory
refs/remotes/tfs/default - 04ddfd8641096a2d02eed4c087423bc0cdeb4ed7 @ 44016

Second: Initialize the branches explicitly
After cloning. Now I even get an error:
git tfs branch --init --all

error: The use of the option '--branches=all' to init all the branches is only possible
when 'git tfs clone' was done from the trunk!!! '$/TeamProject/Dev/Foo/Bar/SolutionDirectory'
is not a TFS branch!

Third: Go to TFS and convert the sub-folders to branches
It seems that for git tfs the distinction between regular folders vs branches in TFS is significant, so I went to TFS and converted SolutionDirectory to a branch, along with it's hierarchy:
 $/TeamProject/Dev/Foo/Bar/SolutionDirectory
  |
  +- $/TeamProject/Dev.EpicX/Foo/Bar/SolutionDirectory
  |
  +- $/TeamProject/Dev.EpicY/Foo/Bar/SolutionDirectory
  |
  +- $/TeamProject/Dev.EpicZ/Foo/Bar/SolutionDirectory

Now when I ran git tfs branch --init --all there was some progress, but it still failed with a weird error:
git tfs branch --init --all

Tfs branches found:
- $/TeamProject/Dev.EpicY/Foo/Bar/SolutionDirectory
=> Working on TFS branch : $/TeamProject/Dev.EpicY/Foo/Bar/SolutionDirectory
Branches to Initialize successively :
-$/TeamProject/Dev.EpicY/Foo/Bar/SolutionDirectory (43506)
The name of the local branch will be : Dev.EpicY/Foo/Bar/SolutionDirectory
error: an error occurs when initializing the branch. Branch is ignored and continuing...
=> Working on TFS branch : $/TeamProject/Dev/Foo/Bar/SolutionDirectory
warning: Some Tfs branches could not have been initialized:
- $/TeamProject/Dev.EpicY/Foo/Bar/SolutionDirectory

Please report this case to the git-tfs developers! (report here : https://github.com/git-tfs/git-tfs/issues/461 )
warning: Some Tfs branches could not have been initialized or entirely fetched due to errors:
- $/TeamProject/Dev.EpicY/Foo/Bar/SolutionDirectory
   =>error:error: Couldn't fetch parent branch

nobody has answered this yet? I'm having the same problem, the environment where I'm working has the very same characteristics and I'm facing the same odds, have tried the same tricks and got the same results, anybody would mind to chime in?

Did you looked at that?
https://github.com/git-tfs/git-tfs/blob/master/doc/usecases/manage_tfs_branches.md
https://github.com/git-tfs/git-tfs/blob/master/doc/usecases/migrate_tfs_to_git.md


add windows outputstring msvc_sink

[[sink]]
name = "console"
type = "stdout_sink_mt"
[[sink]]
name = "msvc"
type = "msvc_sink_mt"
[[sink]]
name = "rotate_out"
type = "rotating_file_sink_mt"
base_filename = "log/{index}-info/simple-{path}.log"
max_size = "1M"
max_files = 10
level = "info"
optional flag to indicate the set - up to create the log dir first
create_parent_dir = true
[[sink]]
name = "simple_err"
type = "basic_file_sink_mt"
filename = "log/{index}-err/simple-{path}.log"
truncate = false
level = "err"
optional flag to indicate the set - up to create the log dir first
create_parent_dir = true
[[logger]]
name = "root"
sinks = ["console", "rotate_out", "simple_err","msvc"]
level = "trace"

Thanks for this, I have created another replacement PR that is based on this new feature as it was failing the format linting, plus I wanted to update the README too, see #58.
Will be closing this.


[Adaptive] Bake pre-requisite constructs into SDK, set stage to move into master

This item tracks work necessary to identify and move core changes to SDK into master so we can eventually move adaptive dialog into the master branch.

[ ] Impact on data binding - Steve prepping a PR for minimal changes
[ ] Auto ID for dialogs
[ ] Eventing
[ ] inheriting memory from parent
[ ] Missing code on C# side for propagating any thrown exceptions with an event to cancel dialog with payload as the exception

Tom has a PR for this.
Features we wanted in the core libs are in place
No breaking changes to public signatures


Failed to execute goal com.github.eirslett:frontend-maven-plugin:1.15.0:npm (npm install) on project seata-console: Failed to run task: 'npm install' failed.

[ ] I have searched the issues of this repository and believe that this is not a duplicate.

Ⅰ. Issue Description
Failed to execute goal com.github.eirslett:frontend-maven-plugin:1.15.0:npm (npm install) on project seata-console: Failed to run task: 'npm install' failed.
Ⅱ. Describe what happened
When I execute the './mvnw clean install -DskipTests=true' command locally, an error that fails to build the seata-console module will be reported, which prevents me from accessing the dashboard after the project is started.
npm ERR! code ERR_SOCKET_TIMEOUT
[INFO] npm ERR! errno ERR_SOCKET_TIMEOUT
[INFO] npm ERR! network request to https://registry.npmjs.org/slice-ansi/-/slice-ansi-7.1.0.tgz failed, reason: Socket timeout
[INFO] npm ERR! network This is a problem related to network connectivity.
[INFO] npm ERR! network In most cases you are behind a proxy or have bad network settings.
[INFO] npm ERR! network
[INFO] npm ERR! network If you are behind a proxy, please make sure that the
[INFO] npm ERR! network 'proxy' config is set properly.  See: 'npm help config'
[INFO]
[INFO] npm ERR! A complete log of this run can be found in:

367 error code ERR_SOCKET_TIMEOUT
368 error errno ERR_SOCKET_TIMEOUT
369 error network request to https://registry.npmjs.org/slice-ansi/-/slice-ansi-7.1.0.tgz failed, reason: Socket timeout
370 error network This is a problem related to network connectivity.
370 error network In most cases you are behind a proxy or have bad network settings.
370 error network
370 error network If you are behind a proxy, please make sure that the
370 error network 'proxy' config is set properly.  See: 'npm help config'
371 verbose exit 1
372 timing npm Completed in 496313ms

Ⅲ. Describe what you expected to happen
Ⅳ. How to reproduce it (as minimally and precisely as possible)

xxx
xxx
xxx

Minimal yet complete reproducer code (or URL to code):
Ⅴ. Anything else we need to know?
Ⅵ. Environment:

JDK version(jdk8):
Seata client/server version:   branch 2.x latestcode
Database version: mysql8.0
OS(e.g. uname -a): macOS arm64( chip：m2pro)
Others:

It seems like you cannot connect to the registry.npmjs.org
Maybe you can add a mirror registry website.

It seems like you cannot connect to the registry.npmjs.org Maybe you can add a mirror registry website.

How to add npm mirror address, can you tell me in detail? Because the npm environment is generated when the maven command is executed, there is no local npm runtime environment required

It seems like you cannot connect to the registry.npmjs.org Maybe you can add a mirror registry website.

How to add npm mirror address, can you tell me in detail? Because the npm environment is generated when the maven command is executed, there is no local npm runtime environment required

you can check this file

https://github.com/apache/incubator-seata/blob/2.x/console/pom.xml
                        <id>install node and npm</id>
                        <goals>
                            <goal>install-node-and-npm</goal>
                        </goals>
                        <phase>generate-resources</phase>
                        <configuration>
                            <nodeVersion>v19.5.0</nodeVersion>
                            <nodeDownloadRoot>https://mirrors.aliyun.com/nodejs-release/</nodeDownloadRoot>
                        </configuration>
                    </execution>
                    <execution>
                        <id>npm install</id>
                        <goals>
                            <goal>npm</goal>
                        </goals>
                        <phase>generate-resources</phase>
                        <configuration>
                            <arguments>install</arguments>
                            <npmRegistryURL>https://registry.npmmirror.com/</npmRegistryURL>
                        </configuration>
                    </execution>

After I configured it as above, the build still failed.

https://github.com/apache/incubator-seata/blob/2.x/console/pom.xml
                        <id>install node and npm</id>
                        <goals>
                            <goal>install-node-and-npm</goal>
                        </goals>
                        <phase>generate-resources</phase>
                        <configuration>
                            <nodeVersion>v19.5.0</nodeVersion>
                            <nodeDownloadRoot>https://mirrors.aliyun.com/nodejs-release/</nodeDownloadRoot>
                        </configuration>
                    </execution>
                    <execution>
                        <id>npm install</id>
                        <goals>
                            <goal>npm</goal>
                        </goals>
                        <phase>generate-resources</phase>
                        <configuration>
                            <arguments>install</arguments>
                            <npmRegistryURL>https://registry.npmmirror.com/</npmRegistryURL>
                        </configuration>
                    </execution>

After I configured it as above, the build still failed.  stack info as belows:
Caused by: com.github.eirslett.maven.plugins.frontend.lib.TaskRunnerException: 'npm install --registry=https://registry.npmmirror.com/' failed.
Caused by: org.apache.maven.plugin.MojoFailureException: Failed to run task
    at com.github.eirslett.maven.plugins.frontend.mojo.AbstractFrontendMojo.execute (AbstractFrontendMojo.java:100)
    at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo (DefaultBuildPluginManager.java:137)
    at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:210)
    at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:156)
    at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:148)
    at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject (LifecycleModuleBuilder.java:117)
    at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject (LifecycleModuleBuilder.java:81)
    at org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build (SingleThreadedBuilder.java:56)
    at org.apache.maven.lifecycle.internal.LifecycleStarter.execute (LifecycleStarter.java:128)
    at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:305)
    at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:192)
    at org.apache.maven.DefaultMaven.execute (DefaultMaven.java:105)
    at org.apache.maven.cli.MavenCli.execute (MavenCli.java:956)
    at org.apache.maven.cli.MavenCli.doMain (MavenCli.java:288)
    at org.apache.maven.cli.MavenCli.main (MavenCli.java:192)
    at sun.reflect.NativeMethodAccessorImpl.invoke0 (Native Method)
    at sun.reflect.NativeMethodAccessorImpl.invoke (NativeMethodAccessorImpl.java:62)
    at sun.reflect.DelegatingMethodAccessorImpl.invoke (DelegatingMethodAccessorImpl.java:43)
    at java.lang.reflect.Method.invoke (Method.java:498)
    at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced (Launcher.java:289)
    at org.codehaus.plexus.classworlds.launcher.Launcher.launch (Launcher.java:229)
    at org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode (Launcher.java:415)
    at org.codehaus.plexus.classworlds.launcher.Launcher.main (Launcher.java:356)
    at sun.reflect.NativeMethodAccessorImpl.invoke0 (Native Method)
    at sun.reflect.NativeMethodAccessorImpl.invoke (NativeMethodAccessorImpl.java:62)
    at sun.reflect.DelegatingMethodAccessorImpl.invoke (DelegatingMethodAccessorImpl.java:43)
    at java.lang.reflect.Method.invoke (Method.java:498)
    at org.apache.maven.wrapper.BootstrapMainStarter.start (BootstrapMainStarter.java:53)
    at org.apache.maven.wrapper.WrapperExecutor.execute (WrapperExecutor.java:152)
    at org.apache.maven.wrapper.MavenWrapperMain.main (MavenWrapperMain.java:76)
Caused by: com.github.eirslett.maven.plugins.frontend.lib.TaskRunnerException: 'npm install --registry=https://registry.npmmirror.com/' failed.


Feature: broader uses for watch plugins

Summary
As discussed in #6467, watch plugins could be much more useful if they could change a wider range of global config options. This implements a white-listed wider set, tests and docs it.
Two immediate use cases are toggler plugins for tests verbosity and coverage collection. They're already ready and tested on my local machine, but I have no idea how to get them inside the jest-community org, and I'll need the relevant minimum Jest version for a pertinent peerDependency.
Test plan
All tests pass on my machine. Extra tests are located in packages/jest-cli/__tests__/watch.test.js, and focus on confirming white-listing of allowed global config options is effective.
The docs in /docs were also updated (but they don't seem to be used by website/'s yarn start or yarn build, so I only checked their rendering in VS Code's Markdown preview).
This is not semver-major, as there are no breaking changes IMHO, this is more of an extra feature, so looks semver-minor to me.
Hope you like it!
Closes #6467

Codecov Report

Merging #6473 into master will increase coverage by 0.08%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #6473      +/-   ##
==========================================
+ Coverage   63.48%   63.56%   +0.08%
==========================================
  Files         227      227
  Lines        8697     8717      +20
  Branches        4        4
==========================================
+ Hits         5521     5541      +20
  Misses       3175     3175
  Partials        1        1

Impacted Files
Coverage Δ

packages/jest-cli/src/watch.js
79.02% <ø> (ø)
:arrow_up:

packages/jest-cli/src/lib/update_global_config.js
95.45% <100%> (+3.78%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 949a281...1d87a97. Read the comment docs.

@rogeliog this is for your reviewing pleasure 😉

@tdd did you see the CLA comment?

@SimenB I did see the CLA comment and e-mailed to update and renew my CLA status. The online form fails in obscure ways for updates (always has, nobody's fixing it).

Hey @rogeliog!
Here's my update. It addresses the various suggestions you had, and it looks like it's going to greenlight through. Let me know what the next steps would be!

Hey @rogeliog just following up on this. Have you had time to peruse the latest changes? I'd love to know how and when we can move ahead with this 😉

Just pushed a force update to fix upstream merge conflicts over CHANGELOG.md after having rebased on top of it.

@tdd mind resolving conflits? :)

@thymikee dang, there were none when this was originally approved. Also, all checks passed. Checking it now.

Grmbl, this thing stayed too long in limbo, approved but unmerged, as other PRs for watch plugins came in that broke this one. Will need to investigate. (Also, not cool, team 😐 )

I'm pretty sure @rogeliog can help you with figuring out what's wrong now :).
Thanks for your patience though! We try our best to review and merge stuff as early as possible, but there's a lot to do 😅.

Hey @thymikee I sure would appreciate @rogeliog's help on this, the issue is the same across the board, when require'ing watch plugins' paths. jest-resolve b0rks further down the line. This is not code I touched in my PR and I have no idea just now about why the path would be missing here—and not break watch.js in master?

Yes, I'm more than happy to help. I'll take a look

@rogeliog thank you that's great! Any idea when this could get merged in, @thymikee?
Also, does any of you know how I could put two upcoming plugins (that need this to come in), one for toggling verbosity and one for toggling coverage, into jest-community? They're in my own account for now (along with chai-jest-diff, for instance), but they'd be better out there.

Hopefully sometime soon! I'll try to review this today.
You'll need to transfer ownership of the repositories to jest-community. Then we'll be able to make you a collaborator on these projects, so you still can be in charge of them. cc @SimenB

Alright, the moment a public release ships with this merged in, I'll
update the plugins, test again, then transfer.
On Sun, Jul 8, 2018, at 16:01, Michał Pierzchała wrote:

Hopefully sometime soon! I'll try to review this today.

You'll need to transfer ownership of the repositories to jest-
community. Then we'll be able to make you a collaborator on these
projects, so you still can be in charge of them. cc @SimenB[1]> — You are receiving this because you were mentioned. Reply to this
email directly, view it on GitHub[2], or mute the thread[3].
--
Christophe Porteneuve
<EMAIL_ADDRESS>
Links:

https://github.com/SimenB
https://github.com/facebook/jest/pull/6473#issuecomment-403289802
https://github.com/notifications/unsubscribe-auth/AAAOqMXpBnCKuoHRsb-zzkJ3LAU6kaHqks5uEhCtgaJpZM4UpZAi

@tdd I love the idea of these plugins... I have some idea of what we could do to prevent having a separate plugin for each config option. As of<EMAIL_ADDRESS>watch plugins support configs(https://jestjs.io/docs/en/watch-plugins#customization). It would be awesome to just have one plugin jest-watch-toggle-config. And can be used like this.
"watchPlugins": [
  ["jest-watch-toggle-config", { "toggle": "verbose", "key": "v" }],
  ["jest-watch-toggle-config", { "toggle": "coverage" }],
  ["jest-watch-toggle-config", { "toggle": "notify", "key": "n" }]
]

we could add a default key and prompt for each toggle config option, while still allowing the user to override those.... thoughts?

Or even something like https://www.npmjs.com/package/prompt-checkbox, where checked means true, and you could toggle all in the same view

I think making it generic is a nice approach, but I can imagine
scenarios where the toggling is not just true/false, but null/undefined
vs. Something more involved, like an array or string. So the prompt
approach wouldn't be great for that. Also, while I appreciate reserving
a single key, I think a lot of users want single-keypress behavior, not
just opening up a UI, especially for toggling. So I guess multiple
instances with their own keys and parameters values would be better.
I'll try to whip out an implementation later this week, if my
newborn lets me 😁
On Mon, Jul 9, 2018, at 07:45, Simen Bekkhus wrote:

Or even something like https://www.npmjs.com/package/prompt-checkbox,
where checked means true, and you could toggle all in the same view> — You are receiving this because you were mentioned. Reply to this
email directly, view it on GitHub[1], or mute the thread[2].
--
Christophe Porteneuve
<EMAIL_ADDRESS>
Links:

https://github.com/facebook/jest/pull/6473#issuecomment-403366235
https://github.com/notifications/unsubscribe-auth/AAAOqE90Flm-gA7mg-RKAbfPthno3rRrks5uEu4KgaJpZM4UpZAi

Hey @rogeliog @thymikee here's my take at generic boolean setting toggling through watch plugin config: https://github.com/deliciousinsights/jest-watch-toggle#readme
I'll strip the more-specific repos.

Now that I think of it: there's another reason I'm not a fan of @SimenB's suggestion of using an interactive checkbox list UI for toggling settings: this means the list of settings is hardcoded in the plugin. So when Jest whitelists more, the plugin needs maintenance. I'd rather let the end user do the config for them to (a) gain single-key toggling and (b) leverage any latest whitelisted setting.

@rogeliog I like how your demo config for the single plugin lets end users write terse configs by ensuring proper default prompts and keys, but I'm concerned that:

this means hard-coding, and therefore maintaining over time, a list of whitelisted boolean update-config options (we could throw on plugin-unknown settings with no provided key or prompt, but still)
this may conflict with later built-in keys in Jest watch mode (there are more and more…)

Also, I missed your initial name proposal and pushed a jest-watch-toggle repo for now. Do you think …toggle-config is better? Haven't pushed to npm yet anyway, as the matching Jest isn't there yet.

Dammit, something's wrong with the jest-website command apparently.

Just to be clear: master isn't always passing in Jest, is it?

Website failures are unrelated, it's probably some temporary outage on OpenCollective API.

Well, 23.4 shipped without this still… Hence CHANGELOG conflicts. Addressing this.

@SimenB can you have a final look and merge if all good?

I recall @rogeliog having some thoughts around that. To me it's perfectly fine and seems like good DX.

@thymikee now that I think of it, we shouldn't put that burden on plugin authors, when Jest itself can check and bail.

We explicitly want to allow overrides of built-ins, at least. For e.g. https://github.com/jest-community/jest-watch-typeahead

@SmienB that's a good point. Perhaps the new code in watch.js would differentiate like this:

keys reserved by built-in plugins that provide core functionality (think q for quit.js 😉): not overridable
keys reserved by built-in plugins that provide extra functionality (e.g. test_name_pattern.js): overridable
keys reserved by prior third-party plugins: not overridable

We could provide a config option that lets us enable full-scale override, but that seems like providing users with a gun whose only target is their own foot.
What do you think?

I agree with a lot of the comments above, I think we need to find a good way to handle this.
Something within Jest that knows how to handle this conflicts and give the appropriate error message if needed. For plugin authors and consumers, things should just work.

@rogeliog about the toggle-config plugin: I decided to go with…

jest-watch-toggle-config package name
Sane defaults for the four boolean config options that seemed to make sense in watch mode (and not be redundant with other builtin keys): bail, collectCoverage, notify and verbose

See the plugin here (assumes 23.5 will have this PR merged in, not published to npm or moved to jest-community until this lands in a released version)
As for Jest's better DX wrt conflicting keys, I'll set up an issue soon with a detailed spec proposal and ping you all on it; if the spec gels, I'll put up a PR for it.

🎉🙏
On Thu, Jul 12, 2018, at 08:27, Simen Bekkhus wrote:

Merged #6473[1].

— You are receiving this because you were mentioned. Reply to this
email directly, view it on GitHub[2], or mute the thread[3].
--
Christophe Porteneuve
<EMAIL_ADDRESS>
Links:

https://github.com/facebook/jest/pull/6473
https://github.com/facebook/jest/pull/6473#event-1729518014
https://github.com/notifications/unsubscribe-auth/AAAOqMesNg6Us9D-sCPYaJ9Stppg0uuzks5uFuxGgaJpZM4UpZAi

Hey all! FWIW the initial release of the toggle-config plugin is out, now that 23.4.1 includes this.
Will move it to jest-community soon. Check it out: https://github.com/deliciousinsights/jest-watch-toggle-config#readme

Hey @rogeliog @SimenB I added you as admins on my toggle-config plugin so you would transfer it to jest-community. Once you've done so and added me back as contributor to it, I'll update its package.json, set up its Travis CI badge, semver-patch it and republish.

Done, and added you as admin

Awesome, thank you!


Registration Number for domiciliary Care

Could we change the term from OP number to registration number ?

@Jacobjeevan i have updated, could you assign it to me ?

@Jacobjeevan i have updated, could you assign it to me ?

Don't work on issues that weren't assigned to you 👍 All the issues are blocked as they are reliant on changes in form-field-branch.

@athulmanuel can you re-test the form!

@athulmanuel do we have a Registration Number for domiciliary Care? If not we can hide it!

yes, till now there was a registry that is being kept as Nominal register with a continuous numbering for al registration. once we fully digitise the system we can remove it.
To start with we will need it.
Will have to figure out a system as all the facilites that we enter will be running facility and they will have a system to register patient and keep track of the number, we must have a strategy on how to transition it fully into CARE by just keeping the count of patient till now.


[Fix #1244] Fix a false positive for Rails/ActionControllerFlashBeforeRender when returning redirect_to

Closes #1244
Before submitting the PR make sure the following are checked:

[x] The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
[x] Wrote good commit messages.
[x] Commit message starts with [Fix #issue-number] (if the related issue exists).
[x] Feature branch is up-to-date with master (if not - rebase it).
[x] Squashed related commits together.
[x] Added tests.
[x] Ran bundle exec rake default. It executes all tests and runs RuboCop on its own code.
[x] Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.
[ ] If this is a new cop, consider making a corresponding update to the Rails Style Guide.

Thanks!