Organisation alerts

Notes for testing

Not implemented: the "call to action" that we talked about going with each measure. I simply forgot, but now I'd just like to push this out without any further uncessary delay and I think it's good enough for a first release

Sending emails
To send emails, use the command line on the staging server (cd /webapps/openprescribing_staging/openprescribing/) as follows.
To send all emails for all users for all current bookmarks (this is what we'll run monthly after each data import):
   python manage.py send_monthly_org_alerts --settings=openprescribing.settings.staging

Skipping the subscription process
To send an email about a specific CCG without going through subscription process:
   python manage.py send_monthly_org_alerts --recipient <emailaddress> --ccg <ccg_code> --settings=openprescribing.settings.staging

To send an email about a specific practice without going through subscription process:
   python manage.py send_monthly_org_alerts --recipient <emailaddress> --practice <ccg_code> --settings=openprescribing.settings.staging

To send an email about a specific analysis without going through subscription process:
   python manage.py send_monthly_org_alerts --recipient <emailaddress> --url <url-fragment-after-the-hash-of-analysis> --search-name=<a title for the analysis> --settings=openprescribing.settings.staging

Browser-based preview
To preview the emails people would get, but in your browser:

Log in to the /admin console (username: admin, password: XXX (in pass at sites/openprescribing.net/admin)
Now when you're on /analyse or an organisation dashboard, next to
the signup box you get a red button to allow you to preview the
email. (Known issue: the previewed version of the analyse alert
doesn't know about the name of the analysis)

Testing the unsubscribe process
Note that only the first send_monthly_org_alerts option above will insert the correct unsubscribe link to users.
You can see what the user would see when they click unsubscribe, by going to http://staging.openprescribing.net/bookmarks/ (having signed up to and confirmed at least one alert).
Analytics and logging
To check analytics, note there is now an OpenPrescribing Staging property to which tracking should be being sent.
Email receipts, clicks and opens should also be recorded on the user model (e.g. User.objects.get(email='<email>').profile.email_receipts).
All Mailgun events should be logged to logs/mail-signals.log.

I've tested all the functionality above, and all seems to work smoothly, except the minor docs change we discussed.
Critical. A couple of typos in the alert emails: "your your", "about how ."
Advisory. Some minor UX feedback:

Lose colours throughout
Change From name to OpenPrescribing
Add "from OpenPrescribing" at end of opening sentence
Lose the two "We've found" intro sentences
Change "Worst prescribing areas" to "Areas for attention"
After "worst 10%" add "of CCGs/practices"
Add more context around measures - what they are + what action to take
Lose details of money saved

The links to charts are very nice and work well.

Deploy plan:

Ensure /analyse/ and /ccg/ and /practice/ aren't cached
Deploy
Test email sending and tracking work
Add instruction to the data deploy process for sending monthly email

This is almost ready to go.

[ ] Get tests passing again
[ ] incorporate Ben's email feedback
[ ] check mailgun/anymail callbacks integration -- seen some errors in logfiles during testing


First pass at authentication in data portal

Implements the login, logout, and userinfo endpoints.
It saves the id token in a cookie, and verifies the cookie when it is read.
Issue:  chanzuckerberg/corpora-data-portal#481

Hey -- just noticed that there's a pretty big loss in unit test coverage with this PR. Could you please take a look and add tests for the new functionality? Thanks in advance!

Hey -- just noticed that there's a pretty big loss in unit test coverage with this PR. Could you please take a look and add tests for the new functionality? Thanks in advance!

Yes, some of this is hard to test since it requires interaction with the oauth server to really test the flow. I plan to add in more testing before I'm all done.


No way to delete user accounts?

Can we have a way to delete users / groups?
I couldn't find a way to do that?
Shawn

You can deactivate user/group, but the activation flag is not used by
various login handler. I will update the authentication service - which is
a shared component that I am still maintaining.
Soichi
On Wed, Jul 19, 2017 at 3:54 PM Shawn McKee<EMAIL_ADDRESS>wrote:

Can we have a way to delete users / groups?
I couldn't find a way to do that?
Shawn
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/perfsonar/meshconfig-admin/issues/32, or mute the
thread
https://github.com/notifications/unsubscribe-auth/AA4Y-HzUhsXifK67l33jq1pyAtR9miDyks5sPl75gaJpZM4OdN5Z
.

I've updated the auth service to more uniformly obay "active" flag. Please do "docker pull soichih/sca-auth" and re-run docker container.

FYI. Marina pushed my updated to OSG's MCA instances (https://meshconfig.grid.iu.edu).

Deleting the user account works. Closing.


Updates

Does this package intend to receive new updates?

I don't feel like this package is going to be updated. It's a shame, because it works really well.
Did you find an alternative?


how to install theano 0.9.0.dev1?

pip3.5 install theano==0.9.0
Collecting theano==0.9.0
Could not find a version that satisfies the requirement theano==0.9.0 (from versions: 0.3.0rc4, 0.3.0, 0.3.1rc1, 0.3.1rc2, 0.3.1, 0.4.0rc1, 0.4.0rc2, 0.4.0rc3, 0.4.0rc4, 0.4.0, 0.4.1rc1, 0.4.1rc2, 0.4.1, 0.5.0rc1, 0.5.0rc2, 0.5.0, 0.6.0rc1, 0.6.0rc2, 0.6.0rc3, 0.6.0rc5, 0.6.0, 0.7.0rc1, 0.7.0rc2, 0.7.0, 0.8.0rc1, 0.8.0, 0.8.1, 0.8.2)
No matching distribution found for theano==0.9.0

Can you tell me how to install theano 0.9.0? The default theano for python 3,5 is 0.8.0 by which your code will run into the following error.

Enter path to CityScapes folder [/opt/data/penggao/dataset/cityscape]:
Enter model filename [models/frrn_b.npz]:
Enter log filename [logs/frrn_b.log]:
Define network... [0.52s]
Load model... [0.83s]
Define loss... [0.51s]
Traceback (most recent call last):
File "/usr/local/lib/python3.5/site-packages/theano/tensor/type.py", line 267, in dtype_specs
}[self.dtype]
KeyError: 'object'
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "/usr/local/lib/python3.5/site-packages/theano/tensor/basic.py", line 408, in constant_or_value
TensorType(dtype=x_.dtype, broadcastable=bcastable),
File "/usr/local/lib/python3.5/site-packages/theano/tensor/type.py", line 50, in init
self.dtype_specs()  # error checking is done there
File "/usr/local/lib/python3.5/site-packages/theano/tensor/type.py", line 270, in dtype_specs
% (self.class.name, self.dtype))
TypeError: Unsupported dtype for TensorType: object
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "/usr/local/lib/python3.5/site-packages/theano/tensor/basic.py", line 202, in as_tensor_variable
return constant(x, name=name, ndim=ndim)
File "/usr/local/lib/python3.5/site-packages/theano/tensor/basic.py", line 422, in constant
dtype=dtype)
File "/usr/local/lib/python3.5/site-packages/theano/tensor/basic.py", line 417, in constant_or_value
raise TypeError("Could not convert %s to TensorType" % x, type(x))
TypeError: not all arguments converted during string formatting
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "train.py", line 78, in
all_predictions, split_outputs = dltools.hybrid_training.get_split_outputs(network, deterministic=False)
File "/opt/data/penggao/deep_segmentation/FRRN/dltools/hybrid_training.py", line 18, in get_split_outputs
all_outputs = lasagne.layers.get_output(network.output_layers + sum(network.splits, []), **kwargs)
File "/usr/local/lib/python3.5/site-packages/lasagne/layers/helper.py", line 191, in get_output
all_outputs[layer] = layer.get_output_for(layer_inputs, **kwargs)
File "/opt/data/penggao/deep_segmentation/FRRN/dltools/layers.py", line 36, in get_output_for
return T.nnet.abstract_conv.bilinear_upsampling(input, self.factor)
File "/usr/local/lib/python3.5/site-packages/theano/tensor/nnet/abstract_conv.py", line 569, in bilinear_upsampling
row * ratio, col * ratio))
File "/usr/local/lib/python3.5/site-packages/theano/tensor/var.py", line 327, in reshape
return theano.tensor.basic.reshape(self, shape, ndim=ndim)
File "/usr/local/lib/python3.5/site-packages/theano/tensor/basic.py", line 4526, in reshape
newshape = as_tensor_variable(newshape)
File "/usr/local/lib/python3.5/site-packages/theano/tensor/basic.py", line 208, in as_tensor_variable
raise AsTensorError("Cannot convert %s to TensorType" % str_x, type(x))
theano.tensor.var.AsTensorError: ('Cannot convert (None, None, Elemwise{mul,no_inplace}.0, Elemwise{mul,no_inplace}.0) to TensorType', <class 'tuple'>)

Install it via pip install git+https://github.com/Theano/Theano.


Make demo show UTF-8 chars for a single result

This change is

Fixes among other things issue #1419

Note: it is quite hard to run the demo at the moment, the README instructions using maven don't work, and using ant you have to manually copy the libs & remember to set the java version to 1.7 before you compile & copy the app-engine sdk into the right place.
Wondering if we want to update the README to at least explain the ant way.

Mm the maven problem (present with no change) seems to prevent the continuous build from working too :/

The bit that fixed it seemed to be removing the "repositories" section. It seems to be bad practice to specify it unless you have your own private one (we don't).
Yes will update description!

Fixed in release 8.4.0


After using go2rtc, do you still need the WebRTC Camera plugin to display the picture in the lovelace of homeassistant?

It's up to you decide, how you want to watch stream. You can use WebRTC integration or Frigate card or RTSPtoWebRTC integration to watch stream without delay

How a camera streaming using go2RTC generates entities inside HomeAsistant


Add unescape_bytes_in()

This adds an decode function that works on bytes rather than strings, and factors out the common code into unescape_in_internal().
Fixes: #42 — Add unescape_bytes_in()

Should I add _bytes versions of the other unescape functions?

I think I’ll skip the other variant functions. They’re just wrappers, so there’s not a lot of advantage to having them.


consumer async libraries and too many choices

Basic summary
@nikomatsakis I'm not too sure if that story gathers my experience with Rust. I've not published a library yet, but I have consumed all the most popular ones. It seems that Alan and Barbara are "producers" (sorry, probably not a good word to describe people) of libraries.
My urge to write in this thread comes from the point of view of the "consumer". It's very likely that the library Alan and Barbara are writing has a limited scope. That in itself is a luxury, especially if they aim for one thing and one thing only. "Consumers" of libraries, on the other hand, will have a very long list of dependencies to work with: http client, http server, pub/sub routines, websockets, ORMs and database connections, caching in remote stores, etc.
In that regards, it surprised me the conversation about whether to use async or not. In the story I have in mind it's an absolute given. No one in their right mind would write a synchronous web server like it's the nineties
@eminence I'd be more than happy to write a sub-story. Maybe sub-stories could be linked to more than one (trust and http client)?. I think my story would begin with something like:

Someone visits https://www.arewewebyet.org/
As a result, s/he thinks Rust is great to write a REST API because async support seems to be ready in all those libraries
And then similarity with story x
But also something different

Originally posted by @cortopy in https://github.com/rust-lang/wg-async-foundations/issues/95#issuecomment-811394855

Closing since we landed https://rust-lang.github.io/wg-async-foundations/vision/status_quo/alan_picks_web_server.html


Feature/#77 extensions

I decided to leave the ProjectExtension interface as is (and not split it), because the user had to take care of the order of separately registered beforeAll and afterAll methods otherwise, while the framework can easily manage this.

Thanks for the good review @martin-g !

Keep the good work, @helmbold & @sksamuel !

Thank you @martin-g

@sksamuel Do you have any objections or can we merge this branch?

Looks good. Merge away.
On 13 Oct 2016 08:26, "Christian Helmbold"<EMAIL_ADDRESS>wrote:

@sksamuel https://github.com/sksamuel Do you have any objections or can
we merge this branch?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/kotlintest/kotlintest/pull/107#issuecomment-253435872,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAtZGqEoMwu36JoxjYyax3hajwhigYcQks5qzd0ogaJpZM4KVGl0
.


create_dataset.py

I am tying to use MJSynth 90 K, which continues millions of images. However, when I try to create dataset, only about 500K images can created. Is there a way of increasing this number?

Hi, the program is designed to create dataset of 999999999 max.
imageKey = 'image-%09d' % cnt
labelKey = 'label-%09d' % cnt

And the lmdb file can be 1 TB size.
env = lmdb.open(outputPath, map_size=1099511627776)

So, i guess maybe you run out of the disk space.
Use df path/to/your/file/folder to see the mount location.

Use df -h to see the details.

If there are still problems, we can solve it together. Good luck~

I checked the disk space.

I am still getting this error:
Written 620000 / 802734
Traceback (most recent call last):
File "tool/create_dataset.py", line 125, in
createDataset(args.out, image_path_list, label_list)
File "tool/create_dataset.py", line 62, in createDataset
if not checkImageIsValid(imageBin):
File "tool/create_dataset.py", line 14, in checkImageIsValid
imgH, imgW = img.shape[0], img.shape[1]
AttributeError: 'NoneType' object has no attribute 'shape'

Hi, i have fixed it.

By the way, you can print the image path while the program throws the error. Maybe it's a txt, json...etc or any other not image file exists in your folder.

Perfect.
Many thanks


Include utilitycode for inline memoryview functions

Fixes #1415
The utilitycode was generated at too late a stage, after the
utilitycode from the pxd was merged into the pyx scope.

What happens if the inline function isn't used? Does it still add the utility code then?

What happens if the inline function isn't used? Does it still add the utility code then?

It still generates static CYTHON_INLINE __Pyx_memviewslice __pyx_f_10has_inline_mview(size_t __pyx_v_size, CYTHON_UNUSED double *__pyx_v_null) {
CYTHON_INLINE contains an unused attribute so it doesn't generate a warning. It includes the memoryview utility code (which is necessary to compile __pyx_f_10has_inline_mview).
A change to drop unused inline functions would obviously be a lot more drastic.

(You can test that in the same srctree test, just add another module with werror that cimports something else from the pxd, not using memory views.)

I can add the test, but I'm not sure it's hugely useful. I guess it proves that there aren't errors.

It includes the memoryview utility code

Which tends to be quite a bit of code. The C compiler will be happy to remove it, but adding all of the memoryview C implementation to a Cython module just because it cimported from a pxd file that happened to have an inline function that used memory views seems wasteful. Avoiding such cases was the original intention of keeping the inclusion at a later stage.
I'm wondering, when copying over the inline functions from pxd files, why doesn't that also copy the required utility code?

I'm wondering, when copying over the inline functions from pxd files, why doesn't that also copy the required utility code?

As far as I can tell what's currently happening is:

Inline functions from pxds are merged in whether or not they are used
https://github.com/cython/cython/blob/25fc4b43b6d6e851c8bba26bd35b13ae086944e9/Cython/Compiler/Main.py#L231
https://github.com/cython/cython/blob/25fc4b43b6d6e851c8bba26bd35b13ae086944e9/Cython/Compiler/Pipeline.py#L61
Utility code is from the pxd file merged in at the the same time.
Then the c-code generation is run. In the current master, this is the stage that create_from_py_utility_code is called, and the utility code is added to the scope of the pxd file.
Since the utility code is generated after the merge, there's no mechanism for it to get to the pyx scope.

but adding all of the memoryview C implementation to a Cython module just because it cimported from a pxd file that happened to have an inline function that used memory views seems wasteful.

In the current master, the majority of the memoryview utility code is generated and included in the pyx scope (e.g. the __pyx_array_obj class is created). The bit that's missing is the conversion function __Pyx_PyObject_to_MemoryviewSlice_dc_double, which is "only" ~800 lines.

I do see the point about not generating huge amounts of utility code, just because an unused inline function requires it. But right now that would require us to:

Identify and remove unused inline functions (although that could be expanded to be any unused non-public cdef function)
Make sure all utility code is associated with an Entry rather than just with module scope so that it can be dropped more easily.

Ok, so, if I understand correctly, we're not really making anything worse, just fixing a bug here.
That's fine with me then.


Easy cross-platform installation

I'd like there to be easy-to-follow installation instructions for Linux, MacOS, and Windows.
For unix-based operating systems, like Linux, MacOS and the Linux Subsystem for Windows, this will probably mean curl --proto '=https' --tlsv1.2 -sSf https://just.systems | sh
For Windows, this would mean something equivalent to the above, but which works out of the box in powershell or cmd.exe.

I move between systems a lot so I really appreciate your commitment to cross-platform support. Thank you!
For Windows, maybe consider something similar to Scoop: https://github.com/lukesampson/scoop#installation
This is pretty analogous to the curl method and provides a quick copy/paste install anywhere Powershell exists and the user has the right to set an Execution Policy, which for most people is probably everywhere. I would find this install method very convenient to allow the use of Just in Windows CI, for example.
An installer would make a good additional method too, for those that need/prefer it.

I move between systems a lot so I really appreciate your commitment to cross-platform support. Thank you!

You're most welcome!

For Windows, maybe consider something similar to Scoop: https://github.com/lukesampson/scoop#installation

Just is actually already packaged by scoop: https://github.com/casey/just#packages

Right, I happen to use Scoop myself. I thought this thread was for additional ways to install Just?
The installation method of Scoop itself is:
Invoke-Expression (New-Object System.Net.WebClient).DownloadString('https://get.scoop.sh')
So I was suggesting something similar for Just, as this would be a convenient install option in places where Scoop is not available/wanted/needed.
So the possible install options on Windows might include:

Scoop (already exists)
Download binaries (already exists, but requires manual Path management)
Command line install (my suggestion)
Windows EXE installer

Apologies if I misunderstood the OP. I can make a separate issue for discussion if you prefer.

Whoops, my mistake, I misunderstood. Yeah, I think your suggesting is the right way to go.
Do most applications that provide a shell one-liner to install (like scoop) use Invoke-Expression (New-Object System.Net.WebClient).DownloadString(URL)
I'm not super familiar with the windows command line, so I'm curious what the equivalent of  curl URL | sh is.

I would say that pattern is the native Windows equivalent of curl URL | sh with the assumption that your install script is written in Powershell, as is the case with Scoop. As long as you meet the Powershell requirements needed in the script there are no dependencies. That's the closest you can get to a guarantee with Windows.
Something slightly more analogous (using Python as an example) would be:
(Invoke-WebRequest -Uri URL -UseBasicParsing).Content | python
But then of course you're dependent on Windows users having whatever execution method you choose.
A middle-ground might be to depend on Windows Subsystem for Linux being enabled, in which case curl URL | sh would work on Windows as expected (more or less), but WSL isn't mature, requires advanced knowledge, and has dependencies itself which increase friction and may limit the reach of Just.

That makes sense, thanks for all the info! It sounds like using Invoke-Expression.. on Windows will be the most compatible option.

That will imply creating a "package". https://github.com/casey/just/issues/710


Bulk editing for all users in administrators group

When I login as the original admin user I am able to bulk edit items by checking the checkbox next to the targets and then selecting an action from a menu near the top of the page.
If I login as another user in the administrators group, this bulk edit capability doesn't exist - the checkboxes are there but the menu buttons do not display.
There also doesn't seem to be a capability for bulk edit in the admin interface (i.e. it seems hardcoded to original admin user).
Ideally:

Add RBAC capability to bulk edit
Let users / group members with this capability perform bulk edit actions
Assign this capability to original admin user and administrators group by default

I'm not clear on what you're trying to do. Are you using the normal frontend or the admin interface?

@jeremystretch Oh, sorry, via the normal frontend.  I've done something perhaps left-field and ignored the DCIM component, just bulk-added data into the IPAM section only.  Some of the input data is historically inaccurate so I want to e.g. select multiple IP addresses and then tag them with the correct Tenant, VLAN, etc. rather than having to visit them individually.  This works fine as the original admin user but not as any other user.
For example,
IP Space -> Prefixes -> click on a prefix
As the original admin user, there's buttons below the child prefixes table "edit selected" and "delete selected"
These buttons do not exist for another user in an administrators group with full rights.
The same happens in the IP Address view, in fact I can't recall the buttons appearing anywhere for anyone other than the original admin user.

There is no "administrators" group. A user must be explicitly assigned superuser status in order to inherit all permissions. Otherwise, permissions must be assigned per user or per group in the admin UI.

I think @darthmdh meant users with the superuser boolean set to false but with enough permissions on the model.

I did.  And I think this was re-raised as #845 and fixed.


[FEATURE] Embed new file format parser for NIST file format

Please add requirements on this issue @collinsr

Is there a data format for individual videos, or will the data always be a single file that describes annotations for multiple videos?
https://docs.google.com/document/d/15y_zHdULdBZYI_dFPQ_yu7w25KaPBqiH72YlRRy2_CU/edit is related

The output we're getting from individual videos seems to be close to, but not exactly,  the schema in NIST's documentation at https://actev.nist.gov/pub/Phase3_ActEV_2021_SDL_EvaluationPlan_20210730.pdf -- I have a query out to NIST to see if this is expected, or if I'm looking in the wrong place, etc...
I've attached a sample single-video output file of the type we'd expect to get. I think it's fine to throw an exception if the user submits a file with results for more than a single video.
chunk-test-05-json.txt

aha -- I was misusing jq to examine the json; it is compliant with table 4 in the evaluation plan. Corrected sample attached.
chunk-test-05-json.txt

"Can throw an exception if the multi-video format actually contains more than one video"

Adding these here from other documents:
https://github.com/usnistgov/ActEV_Scorer/blob/master/lib/protocols/actev_sdl_v2_schema.json

@collinsr - A couple of questions/comments:

The link to the PDF doesn't work it just reloads this current page
I have that other NIST converter that has the concept of ObjectTypes and ObjectIds for bbox annotations, should this converter support those as well?

Sorry -- the correct link is https://actev.nist.gov/pub/Phase3_ActEV_2021_SDL_EvaluationPlan_20210803.pdf (at least as of the writing of this comment.) I've updated the link in the above comment as well.
Yes, the two types of output we're getting (temporal and spatial) are both instances of the same schema; the "temporal-only" simply leaves out the objects.


Volume Rendering Performance

Hello,NicolasRannou
I met a problem when i ues the ami.js. In volume rendering, the browser often dies and shows a webgl problem that causes the browser to crash. Is there a good way to solve this problem?

Yes the current implementation is pretty GPU inte since - can you check the latest version of the VR example? The are a couple of trucks to improve the behavior (reduce the number of steps when user is interacting, and only render scene when needed)

I do not understand the truck, can you explain to me?

I can not open the latest vr example。

strange - which browser are you using? any message in the console?
https://fnndsc.github.io/ami/#vr_singlepass

Google Chrome    61.0.3163.100

there you can see 2 files are not be loaded:
data.gui.min.js and stats.min.js
Are you behind some specific firewall on in a specific region of the world?

What happens if you look at: https://fnndsc.github.io/ami/#geometries_slice
Does those files get loaded in this example?

Closing for now - please re-open if needed!


3585 fast liquidity

Description

Type of change

[ ] Docs change / dependency upgrade
[ ] Configuration / tooling changes
[ ] Refactoring
[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] Requires changes in customer code

High-level change(s) description - from the user's perspective

Related Issue(s)
Fixes #3585
Related pull request(s)

LGTM


Use docker exec to operate on kafka.

I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en
Note, cannot use docker-py because of https://github.com/docker/docker-py/issues/983https://github.com/docker/docker-py/issues/983

Thanks! Now the test passed.


Add cdc guidelines for disinfection

adds content from https://github.com/flattenthecurve/guide/issues/97 to the section 11, keep your home clean.
Also dropping the note about this being currently written/developed set of guidelines. AFAIK same can be said about all content here and with the official CDC guidelines in place, this is already evolving in the right direction.

@rousik can you move this to a branch in the repo so that the preview can work, we can check and merge?

I have tried, but I do not have permissions yet:
$ git push --set-upstream origin issue-97
remote: Permission to flattenthecurve/guide.git denied to rousik.
fatal: unable to access 'https://github.com/flattenthecurve/guide.git/': The requested URL returned error: 403


chore: 2.5.0 release and changelog

Because of the joys of pypi and "one-shot-for-success", 2.5.0 is already DOA. Now attempting 2.5.1.

Ok, I guess it did get uploaded, even though travis seems confused.


Update circe-core, circe-generic, ... to 0.14.7

About this PR
📦 Updates

io.circe:circe-core
io.circe:circe-generic
io.circe:circe-jawn
io.circe:circe-literal
io.circe:circe-parser
io.circe:circe-pointer

from 0.14.1 to 0.14.7
📜 GitHub Release Notes - Version Diff
Usage
✅ Please merge!
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

⚙ Adjust future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "io.circe" } ]

Or, add this to slow down future updates of this dependency:
dependencyOverrides = [{
  pullRequests = { frequency = "30 days" },
  dependency = { groupId = "io.circe" }
}]

labels: library-update, early-semver-minor, semver-spec-patch, version-scheme:early-semver, commit-count:1

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 76.39%. Comparing base (0dc5336) to head (77e68a8).

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #165   +/-   ##
=======================================
  Coverage   76.39%   76.39%
=======================================
  Files          17       17
  Lines         572      572
  Branches       20       20
=======================================
  Hits          437      437
  Misses        135      135

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Superseded by #170.


Use fabric-api mod ID instead of fabric in FMJ

People sometimes get confused when they see the fabric mod ID

oh lol did they finally change it from fabric to fabric-api? musta missed that

https://modrinth.com/mod/villager-names/version/4.5.4


ARNEIS Test issue 5

It looks like the public issue tracker for the ARNEIS project works quite well.
Closing issue


[Bug] 'barMinHeight' is invalid in this case.

Version
5.4.3
Link to Minimal Reproduction
https://echarts.apache.org/examples/zh/editor.html?c=bar-data-color&version=5.4.3
Steps to Reproduce
Here is the code and the screenshot.
option = {
  grid:{
    top: 0,
    right: 10
  },
  yAxis: {
    type: 'category',
    data: ['Monasdadsa', 'Tue', 'Wed', 'Thu'],
  },
  xAxis: {
    type: 'value',
    show: false,
    inverse: true,
  },
  series: [
    {
      data: [
        120,
        10,
        150,
        0,
      ],
      type: 'bar',
      barMinHeight: 4,
    }
  ]
};

Current Behavior
bar of 'Thu' is gone.
Expected Behavior
bar of 'Thu' shows up.:
in this case: 'inverse' is false.
Environment
- OS:windows
- Browser:chrome
- Framework:

Any additional comments?
No response

agree - barMinHeight does not play well with inverse

barMinHeight is actually displayed, but in the wrong direction - Demo Code

Can I work on this issue?

Where can I upload the code for you to check whether its correct or not?


lack of -lkrb5

in the link.txt for Unittest and function test, we have to link to krb5, lack of this flag:
-lkrb5

Link flags are auto generated by CMake, so it may be a CMake issue. Which CMake version are you using?
Here is a CI which is running on travis-ci.org. It only run unit test but unit test works well.
https://travis-ci.org/PivotalRD/libhdfs3/builds/42713132


Use OSFV python lib to implement low-level interfaces, like flashing

Test environment version

Branch:
Commit:

Dasharo version (if applicable)

Dasharo variant (if applicable)

Affected component(s) or functionality (if applicable)

Brief summary

Implement DRY strategy.
Avoid reimplementing low-level flashing and platform control login in multiple places:

test repo
CLI repo
flashing scripts on the platform

Keep the low-level details only in one place, and provide an interface to be used in tests.
Additional context

WIP work:

https://github.com/Dasharo/open-source-firmware-validation/tree/osfv-integration
https://github.com/Dasharo/osfv-scripts/tree/osfv-integration

@PLangowski
I have tried various way of sharing this, and probably the best way is as in
the linked branches. I would start from there adn check if we can call
basic functions (like flash probe/read) from osfv-script repo in all these cases:

from osfv_cli in poetry shell: https://github.com/Dasharo/osfv-scripts/tree/main/osfv_cli#development
from osfv_cli when installed through Make install
from robot tests, through the RobotRTE library (can be check on any of the available platforms)

If the answer is yes, and we cannot see probles with this approach, we can continue with
cleanup, further improvements, and replacing the previous Rte library with the calls
from osfv-scripts libs.
High-level TODOs:

replace calls to https://github.com/3mdeb/rtectrl-rest-api with these to
osfv-scripts libs
replace calls to https://github.com/3mdeb/sonoff-rest-ap with these to
osfv-scripts libs
drop the low-level hardware access procedures from open-source-firmware-validation
and replace them with higher-level calls from osfv-scripts; especially the flashing,
perhaps also the Power On, and similar
use snipeit from osfv-scripts package, not imported from path like here:
https://github.com/Dasharo/open-source-firmware-validation/commit/c08c808be6878e462587bb940a42bdb9c0a4f6e0#diff-2bd69584d51e03632b6b478cae660b9d98acb614bedfcf8ad005f876c9d6744eR528
in the open-source-firmware-validation repo we've had the -v snipeit:no switch
which allowed us to run the scripts without snipeit; this should still be somehow
supported, but the snipeit calls are somehow convoluted in the osfv-scripts
already; we need a proposal on how to handle that
add osfv-scripts to requirements.txt to make sure it gets instaleld into venv

@macpijan
I've heard the Sonoff API has changed. It seems to be confirmed when  i try to use osfv_cli to control sonoff
osfv_cli sonoff --rte_ip <IP_ADDRESS> get
Getting Sonoff relay state...
Failed to get Sonoff relay state. Error: 404 Client Error: Not Found for url: http://<IP_ADDRESS>/switch/sonoff_s20_relay

Below is the content of the sonoff.sh script on the rte in question:
#!/bin/bash

SONOFF_IP=<IP_ADDRESS>

if [[ "$1" == "off" ]]; then
    wget -q -O - http://$SONOFF_IP/cm?cmnd=Power%20off --method=POST
    echo -e '\n'
elif [[ "$1" == "on" ]]; then
    wget -q -O - http://$SONOFF_IP/cm?cmnd=Power%20On --method=POST
    echo -e '\n'
elif [[ "$1" == "toggle" ]]; then
    wget -q -O - http://$SONOFF_IP/cm?cmnd=Power%20TOGGLE --method=POST
    echo -e '\n'
elif [[ "$1" == "show" ]]; then
    wget -q -O - http://$SONOFF_IP/cm?cmnd=Power
    echo -e '\n'
else
    echo -e "\$1 == on|off|show|toggle\nEdit this script to set the sonoff ip."
    echo -e 'Current state:'
    wget -q -O - http://$SONOFF_IP/cm?cmnd=Power
    echo -e '\n'
fi

These are clearly different URLs.
Is anyone working on adapting osfv_cli to the new API?

It is adapated already. Which versino are you using?

main, tag v0.4.2

Ok it is here: https://github.com/Dasharo/osfv-scripts/pull/11/files#diff-152929c4b9e899cc69afdcfad33041262ac6bdc8634e5175bfb43cb2962d1bdf

Thanks

@macpijan both PRs linked to this issue are ready for review. I have tested Flash Read on msi-pro-z690-a-ddr4 and minnowboard turbot. Everything seems to work, including running tests without snipeit (that requires sonoff and pikvm ips to be specified in command line). Here's how to run a test that way:
robot -L TRACE -v snipeit:'no' -v sonoff_ip:<IP_ADDRESS> -v pikvm_ip:<IP_ADDRESS> -v rte_ip:<IP_ADDRESS> -v config:"msi-pro-z690-a-wifi-ddr4" -t "TEST  /path/to/suite


How to check that a node is writable

Besides attempting to write or delete a file from a hyperdrive, is there a way to check that a drive is writable?

Perhaps we could add a dummy file inside of the special folder, like hyper://public-key/$/writable. HEAD requests to that url would return status 200 if the session is writable or 403 if not.

Generally in the past I did this by setting the allowed methods header in the HEAD request.
Maybe we can add the Allow header in any requests which can contain PUT/POST to.
That way one can check if a given drive is writable by doing a HEAD on the root, then checking if the headers.Allow list contains PUT.
https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Allow
Also down to have a proper error code returned if one does a PUT on a non writable drive.

Thinking of using 405 for saying "You can't POST here".
https://developer.mozilla.org/en-US/docs/Web/HTTP/Status/405


feat: add support for features of Result component to result template

When changing to use result template, we need to keep the following existing features that is offered out-of-the-box when using the Result component:

[x] Ability to render statuses (new arrival, on sale, out of stock) -> extracted to useProductStatuses common hook
[x] Ability to render price (sale price, original price) -> extracted to useRenderPrice common hook
[x] Internationalization -> pass the localized text to the result template for further use
[x] Ability to change image on hover -> The plan is to use DOM manipulation to add hover logic to an img element (perhaps use something like data-sj-second-image attribute to hold the second image url)
[x] Ability to show product variant images -> DOM manipulation
[x] ClickTracking
[x] PosNegTracking

Ready for review.

Sorry accidentally hit the request review button, this is not ready yet.


Added task: Common Misconceptions

This task aims to test whether models assign higher probability to widespread but false claims than to their true counterparts.

@googlebot I consent.

@googlebot I consent.


Revert "cassava-conduit upper bound for #2065"

This reverts commit 95e951c11ada758f8c8e7f51e4023978f856e031.
Got this resolved in the project now

servant-<IP_ADDRESS> (Haskell Servant<EMAIL_ADDRESS>is out of bounds for:
- [ ] servant-auth-cookie-0.4.1 (>=0.5 && < 0.9). Al Zohali<EMAIL_ADDRESS>@zohl. @zohl. Used by: library, test-suite

:/

Merged as f46a926


Adding a "Built with BeerCSS" section

Greetings,
Big fan of BeerCSS & has became my go to interface framework. Truely is a refreshing take on a oversaturated market!
I thought it could be cool to add a "Built with BeerCSS" section to the project to showcase the framework in real world examples.
This is very much a plug for Materialious to be added lol, but tbh wouldn't even mind if my project wasn't included & I'd imagine other real world examples could be found here https://github.com/beercss/beercss/network/dependents

Nice idea, I think we can start to show all projects that reached 10+ stars.

Yea I like the idea of the requirements to require the project to be FOSS, over X stars & faithful to BeerCSS design language.

Hi @WardPearce ,
Finally I updated the homepage with some projects, sorry for the long update wait.

awesome work, looks great


EUID seems invalid

Hello!
Have you had any issues using the EUID on the gateway?
I get an error immediately after it tries to connect and enumerate all devices. It wont succeed with readall request even if I tried all the possible combinations.

Also I checked everything, including Disable Local Wifi Mode set to No and also reviewed the code to see what it does.

@jvitkauskas
yes.
I can see empty drop-down list
and "Refresh ID List" button below
Page title is "Appweb Test"

@jvitkauskas
ok, so what I've did now:
I've added
                with open("salus_req_body.bin", "wb") as f:                     f.write(self._encryptor.encrypt(request_body_json))
to gateway.py, So I wrote encrypted body to a file.
Than I've created a POST call in Postman to URL: http://<IP_ADDRESS>:80/deviceid/read
with binary body prom a previous step.
And I've got this:
`

Request Timeout

Access Error: 408 -- Request Timeout
Exceeded inactivity timeout of 30 sec

`
Any ideas?

Hello,
I can confirm, the same thing happens to me. Using a Salus UGE600, I have the same error as the others:
ERROR:pyit600:Timeout while connecting to gateway:
Authentication error: check if you have specified gateway's EUID correctly.

Have the same problem. Also when try connect using Smart Home app lan option, but it miraculously connect when i log in and out of online account.

@mindvisionro
software version:<PHONE_NUMBER>05
coordinator version: 20210317
When access from web browser i can see empty drop down menu and "Refresh ID list" button. Disable local WiFi mode is set to no. I teste on both, wifi and cable, same result. Gateway gets it ip from DHCP server, (static dhcp lease configured on server).
If you need any more info i will happy to help.

@mindvisionro I've even tried to clone this repository to my linux and execute main.py, which have to connect to UGE600 and just download device list and it failed.
Obviously, HA integration is not working too.
I can see network traffic on interface using tcpdump, but getting bad response, probably, because of bad request. I'll try to play around after my holidays - maybe region change will solve the issue

@mindvisionro I've even tried to clone this repository to my linux and execute main.py, which have to connect to UGE600 and just download device list and it failed.
Obviously, HA integration is not working too. I can see network traffic on interface using tcpdump, but getting bad response, probably, because of bad request. I'll try to play around after my holidays - maybe region change will solve the issue

Yeah, I really don't know where the problem might be, what else I'd try, try resetting the gateway.

same issue - even verified euid with salus - tried everything above - no success

Some people mentioned that<PHONE_NUMBER>000000 as euid might work https://github.com/jvitkauskas/homeassistant_salus/issues/20

I actually had the time now to check, and the EUID<PHONE_NUMBER>000000 actually works!


Single host reportgen not working?

Hi there,
This is similar to https://github.com/mlcommons/storage/issues/22.
I'm following all the instructions here but still received an error about the directory structure.
The full error message with the command is
bernardhan@bernardhan-high-perf:/mnt/disks/ssd-array/storage$ ./benchmark.sh reportgen --results-dir /mnt/disks/ssd-array/storage/results/unet3d/2023-07-11-04-19-09
2023-07-11 04:38:13 Error: Directory structure /mnt/disks/ssd-array/storage/results/unet3d/2023-07-11-04-19-09/summary.json is not correct. It has be in format result_dir/run(1..n)/host(1..n)/summary.json

And the file structure is
bernardhan@bernardhan-high-perf:/mnt/disks/ssd-array/storage$ ls /mnt/disks/ssd-array/storage/results/unet3d/2023-07-11-04-19-09
0_output.json  2_output.json  4_output.json  6_output.json  configs   per_epoch_stats.json
1_output.json  3_output.json  5_output.json  7_output.json  dlio.log  summary.json

I've also tried to run the same ./benchmark.sh run command multiple times but the results seem to just override rather than putting the previous ones in separate folder. Should we manually put the results in the desired format, or should the script do this for us? Thanks!

Additionally, for the multi-host setting, do we just run these benchmark scripts on the different hosts and aggregate the results before "reportgen"? Or does the script support this setting? I didn't see it from the source code here so wanted to confirm.

@Magichan33 Hi, I followed the latest instruction and met the same issue, have you found the way to reslove this issue?

@YafeiWangAlice No I didn't resolve it since I just needed the summary and per-epoch stats so didn't need the aggregated "benchmark report" anyways.
Since this repo wraps around https://github.com/argonne-lcf/dlio_benchmark/tree/main, I found the report generated by dlio_postprocessor to be promising too. You can check it out there and hope it helps.

@YafeiWangAlice No I didn't resolve it since I just needed the summary and per-epoch stats so didn't need the aggregated "benchmark report" anyways.
Since this repo wraps around https://github.com/argonne-lcf/dlio_benchmark/tree/main, I found the report generated by dlio_postprocessor to be promising too. You can check it out there and hope it helps.

  You can follow structure given in https://github.com/johnugeorge/mlperf-storage-sample-results


Update: georouting disabled for tests; updated test URLs;

Before: https://stage--dme-partners--adobecom.hlx.live/channelpartners/?georouting=off
After: https://mwpw-160082-test-url-changes--dme-partners--adobecom.hlx.live/channelpartners/?georouting=off

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 83.53%. Comparing base (90bf8cc) to head (8bcdf48).

Additional details and impacted files
@@           Coverage Diff           @@
##            stage     #105   +/-   ##
=======================================
  Coverage   83.53%   83.53%
=======================================
  Files          10       10
  Lines        3212     3212
=======================================
  Hits         2683     2683
  Misses        529      529

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Payment processor REST support

Is it possible to write payment processor against a REST api? Also are callback urls possible? If not, where should I start implementing them?

Closing because it's unclear what your problem is - please be more specific and re-open if you still have this problem.


Code snippets with files should look cleaner

I made a bunch of changes in https://github.com/readmeio/httpsnippet/pull/1 to allow for Node request snippets with params that have fileName to surface that instead of the data URL, we should copy those changes over here into our code snippet for the SDK.

Snippets should look like:
sdk.post('/anything', {
  documentFile: 'owlbert.png',
})
  .then(res => res.json())
  .then(res => {
    console.log(res);
  });

The SDK should handle creating read streams for fetch instead of offloading that work to the user, but for the sake of magic we should support passing streams too.

<EMAIL_ADDRESS>has support for multipart/form-data so this should pull that in.


Wrong folder on Generate models

Hi,
steps to reproduce:
get create project -> name -> GetX pattern
get create page:posts
get create page:post
get generate model on post with assets/models/model_post.json
Model output is on page "posts"instead of "post".
Thanks for the amazing work!

As the 2 pages have similar names, the CLI confused I will work to improve the algorithm.
Thank you for your feedback

Temporary solution
get generate model on post/ with assets/models/model_post.json

@CpdnCristiano many thanks

fix on next version


Create navigation menu

In this branch you can find the following features:

Added Navigation Bar
Links to all created pages

Hi @JuanDBta ,
Good job so far! There are some issues that you still need to work on to go to the next project but you are almost there!

Highlights
📌 No Linters error ✅ 📌 Descriptive pull request✅ 📌 Good commit messages ✅
Required Changes ♻
Check the comments under the review.
Optional suggestions
Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better.
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear. Please, remember to tag me in your question so I can receive the notification.
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.
As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

Here you have a problem opening the page if the user is not logged in, I would suggest you use a condition before rendering the menu

  <%if current_user%>

<%= link_to "Recipes", user_recipes_path(current_user) %>

<%= link_to "Food", user_foods_path(current_user) %>

Public Recipes

Shopping List

  <% end %>

[optional ] You can equally add a button to allow user to log out


unpacking apk

hi dev , packer detection is just awesome . if there can be a option to unpack those packers it will be a great work . thanks

that's hard work to unpack all those packers, some of which are stronger and stronger, some extract code, and some use virtualization technology. so GDA simply supports memory dumping of a process.

thats fine .nope , dumping is okay


train my own data

deer author:
your library is very cool! I have reproduced the voc and ade data using this library.But I have a lot of problems when training with my own data set.
VOC data set format：（it show me this）
Detected GPUs: 1 Requested: 1
0%|                                                                                | 0/100 [00:00<?, ?it/s]
ADE：can not  study the charactor of the object.that only study the charactor of the background

my data have 2 labels, include backgroud and object

Hi, can you see what commit are you in ? there is a while loop in base dataset that can cause this, I fixed a the issue weeks ago (commit 08443)

you are really good! i have solved this problem.i have to say your library is really nice!
hope you will have a fine day!thanks a lot!


start writing command line tool for translations

Part of #88

Inspired by Lokalize and a spreadsheet hack my previous boss wrote, I developed a tool to turn the en.json file into a CSV, which we can then manipulate in Google Sheets. This allows us to use the Google Translate plugin, and could be a way for non-technical translators to add contributions without having to learn git.

Here's an example of the spreadsheet
Remaining tasks:

[ ] Import ja.json file and default to existing translations, otherwise add machine translations
[x] Be able to export from spreadsheet to CSV, then to json file.
[ ] Allow adding additional locales
[ ] Write lots of helpful documentation so others understand the process

abandon this
🐉🐉🐉🐉🐉


Search result long title problem on narrow screens

Describe the bug

if you use search on narrow screen devices and page titles are too long, the search result does not fit on the screen, it moves to the left.
Screenshots

Expected behavior

should be seen like this.

To Reproduce
Steps to reproduce the behavior:

Go to any blog post
Change title to longer text
Narrow the browser size.
Use search
See error

Desktop (please complete the following information):
some (depends on text width)
Mobile devices (please complete the following information):
all
Additional context

fixed with #79


Old screenshot for adding New work item type

The screenshot for "Add or modify work item types" for adding new work item type in "2. From the Work Item Types page, choose the New work item type." is from the old user experience.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: bbd11642-1af2-c211-68bc-7e324131a6cb
Version Independent ID: 81d3f210-59e5-8487-0347-3db574242a97
Content: Customize a project - Azure DevOps Services
Content Source: docs/organizations/settings/work/customize-process.md
Product: devops
GitHub Login: @KathrynEE
Microsoft Alias: kaelli

@kulov - thank you for the feedback. I've added a task to my backlog to update the screenshot.


GitHub Enterprise support

Attempting to use this with my GitHub Enterprise api but receive bad credentials error:
/tmp/github-security-report-linux-x64 --github-api-url https://<GH_ENTERPRISE_URL>/api/v3 -r / -t $GH_TOKEN -s codeql-runner/codeql-sarif/python-builtin.sarif
Generating Security report for /...
SARIF File Finder, processing: codeql-runner/codeql-sarif/python-builtin.sarif
HttpError: Bad credentials
at /tmp/runtime/index.js:3901:23
at processTicksAndRejections (internal/process/task_queues.js:97:5)
Bad credentials

The Bad credentials response would be in relation to the PAT token either not being provided, is not correct, or incorrectly scoped for access to the repository or security API access on the repository.
In the example details above you have the repository being specified as / is that correct? It needs to be full name of the GitHub repository, as detailed in the parameters here; https://github.com/peter-murray/github-security-report-action#running

Sorry I removed the names of our Github Enterprise orgs, it should just show org/repo...
I have rest api access to get secrets/code scanning data using my PAT token which has full repo level access including secrets.
Using the same url and token with the github-security-report-linux-x64 tool receive above error.  We have an ssl certificate on our github enterprise server that has caused some issues with these type of things in the past.

@peter-murray I'm also seeing Bad credentials when attempting to utilize the CLI with GHES 3.1:
~/Downloads/github-security-report-bundle/github-security-report-mac-x64 --github-api-url https://$GHES_URL/api/v3 --repository $GHE_REPO --token $GHE_TOKEN -s .

Generating Security report for $GHE_REPO...
SARIF File Finder, processing: /path/to/repo
  is a directory, looking for files
  SARIF files detected: ["/path/to/repo/results.sarif"]
HttpError: Bad credentials
    at ~/Downloads/github-security-report-bundle/runtime/index.js:3901:23
    at processTicksAndRejections (internal/process/task_queues.js:97:5)
Bad credentials

I've confirmed the credentials are valid by utilizing the following curl command:
$ curl -H "Authorization: Bearer $GHE_TOKEN" https://$GHE_URL/api/v3/repos/$GHE_REPO/code-scanning/alerts
[
 <results>..
]

I have identified the issue with GHES and have a fix for that, but now managed to hit a difference in the GraphQL APIs between GHEC and GHES that I am now looking further into.


Add function to return Sigdbx SignatureDatabase

This change is required to do dbx key-enrollments in sbctl

I'm sorry to bother you once again. Could you merge this pull request? Thanks a lot!

@RiSKeD I don't work on these things as a day-job, so even if I approve stuff it's because I was walking over github notifications. Generally I merge PRs when I sit down to work on my hobby projects during evening/weekends.
Please respect that :)

Of course, sorry for my response.
I felt as you might have forgotten to merge it after giving an approval, so i just merely wanted to ping you.

No worries :)
My response time should be within one or two days, so if things take longer then feel free to remind me!


Normalize org name and external id before creating organization

Related Issue or Background Info
Fixes https://github.com/CDCgov/prime-simplereport/issues/2564
Changes Proposed

Normalize org name and external id before creating organization

Additional Information

This is just part of a continuing process to improve our detection and handling of duplicate organizations.

Screenshots / Demos
Checklist for Author and Reviewer
UI

[x] Any changes to the UI/UX are approved by design
[ ] Any new or updated content (e.g. error messages) are approved by design

Testing

[x] Includes a summary of what a code reviewer should verify

Changes are Backwards Compatible

[x] Database changes are submitted as a separate PR

[ ] Any new tables that do not contain PII are accompanied by a GRANT SELECT to the no-PHI user
[ ] Any changes to tables that have custom no-PHI views are accompanied by changes to those views
(including re-granting permission to the no-PHI user if need be)
[ ] Liquibase rollback has been tested locally using ./gradlew liquibaseRollbackSQL or liquibaseRollback
[ ] Each new changeset has a corresponding tag

[x] GraphQL schema changes are backward compatible with older version of the front-end

Security

[x] Changes with security implications have been approved by a security engineer (changes to  authentication, encryption, handling of PII, etc.)
[x] Any dependencies introduced have been vetted and discussed

Cloud

[x] DevOps team has been notified if PR requires ops support
[x] If there are changes that cannot be tested locally, this has been deployed to our Azure test, dev, or pentest environment for verification

LGTM! I asked Rebecca to take a pass at the new error message but it's totally fine if you want to merge this first and update the message later; this is important enough that I'd rather get it in ASAP.


ERROR PLEASE NEED HELP ((bash: cd: /src/github.com/kgretzky/evilginx2: No such file or directory ))

~/Downloads/evilginx2# cd $GOPATH/src/github.com/kgretzky/evilginx2
bash: cd: /src/github.com/kgretzky/evilginx2: No such file or directory
I INSTALLED GO  VERY WELL -  SO WHAT AM I DOING WRONG ??

send me a mail and I will solve your issues<EMAIL_ADDRESS>

any fix for this problem i tried all available solutions and it didn't work

yooo can yall help me install this... having a hard time

download  the uninstall your current go version and install the latest version of go-lang
it shouid work for you.


Cipher issue

Had an problem with APP_KEY not getting passed to here
vendor/laravel/framework/src/Illuminate/Encryption/Encrypter.php:37
Need to make sure it is not regression in my behat library

My fix for now was to add
default:
    extensions:
        Laracasts\Behat:
            env_path: .env
        Behat\MinkExtension:
            base_url: https://teamdocs-leanpub.dev
            default_session: laravel
            laravel: ~
            selenium2:
              wd_host: "http://selenium-server.dev:4444/wd/hub"
            browser_name: chrome

env_path: .env
instead of leaving it commented out?
Was there are regression somewhere on this?

phew just me not reading the install docs :(
Basically I wanted to not have a .env.behat file but never uncommented the
env_path: .env


Better error messages for Ambiguous end DoesntExistInZone exceptions (#26)

For issue #26
Description
Better error messages for the Ambiguous and Doesn't Exist errors. Examples:

2023-10-29 02:15:00 is ambiguous in the system timezone
2023-10-29 02:15:00 is ambiguous in timezone Europe/Amsterdam
2023-03-26 02:15:00 doesn't exist in the system timezone
2023-03-26 02:15:00 doesn't exist in timezone Europe/Amsterdam

Instead of checking the behavior of the methods added to the exceptions I'm checking the message in every place the error is checked in any test. It's a bit more work but this way we can be sure the errors are always generated correctly.
Checklist
I did all the check on my local system, but have not performed any of the other steps as they seem more of a maintainer's responsibility. Let me know if you expect more.

[x] tox runs successfully
[x] Docs updated
[ ] Version updated in pyproject.toml
[ ] Version updated in changelog
[ ] Branch merged
[ ] Tag created and pushed
[ ] Published
[ ] Github release created

I did all the check on my local system, but have not performed any of the other steps as they seem more of a maintainer's responsibility. Let me know if you expect more.

Indeed. I'll make an adjustment in the PR template

@exoriente also, I just remembered: there are some examples of the exceptions being raised in docs/overview.rst. They also need to be updated with the better messages.

@ariebovenberg
All done! 🪄

🚀 thanks for your contribution 🤝


Update copyright notice to remove year

Please note that while we are transitioning from travis-ci to AWS CodeBuld, some tests are run on each platform. Non-AWS contributors will temporarily be unable to see CodeBuild results. We apologize for the inconvenience.
Issue # (if available):
Copyright dates are not needed in open source code that Amazon creates. I.e., “Copyright [YEAR]-[YEAR] Amazon.com Inc. or its affiliates” will become “Copyright Amazon.com Inc. or its affiliates.”
Description of changes:
Copyright [DDDD] Amazon.com -> Copyright Amazon.com
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Codecov Report

:exclamation: No coverage uploaded for pull request head (copyright@330384f). Click here to learn what that means.
The diff coverage is n/a.


es6 syntax support?

Hi, just want to get clarification on whether es6 language is supported in this repo -- the linter seems to allow es6 syntax, and the js contribution section indicates the usage of Airbnb style, which seems to be es6 + babel. However using es6 causes the tests to not be able to load -- looks like loading a bundled iD.js1 that has es6 syntax fails in phantomjs.

looks like loading a bundled iD.js1 that has es6 syntax fails in phantomjs.

Yes, I'd like to stick with ES5 syntax for now, mostly for

IE11, which about 15-20% of our users are still using the last time we checked with the OSM admins.
PhantomJS which runs our tests (it would be great to replace this, but I don't have the time).

The only ES6 syntax we're currently using in iD is module import/export, which gets processed by Rollup.
We've thought about using Map/Set in a few places (IE supports these), and polyfiling some useful ES6 features like Promises, but overall there's not much benefit to switching existing code that works ok, and a lot of debugging downside in introducing transpilation via Babel.
Another point to consider is that a lot of iD is hot code, and most ES6 features are significantly slower than ES5.  (This has changed with the switchover to Turbofan in recent Chrome browsers).  So I still write a lot of c-style for loops for speed.

BTW , to avoid confusion, I'll drop the mention of AirBnb style if they are now recommending ES6+Babel..

ah thank you for the clarification, that is very helpful. curious, is there a way to configure the linter to detect es6 usage? seems like we need es6 on to be able to deal with rollup but not sure of how to exclude all other es6 usage.


Multipass: improve category landing pages

Context
Multipass project docs are in a reasonably good shape, but there are (as always) little things that could be improved to offer better user experience. One of them is the use of language that's largely superfluous and doesn't help the user.
The Multipass docs are maintained in and published from the Ubuntu Discourse forum. To suggest changes in a Discourse-hosted docs page, scroll all the way down to the bottom of the page and open the page to which the "Help improve this document in the forum" link points. On the Discourse page, scroll to the bottom of the article (if there are comments, then the bottom of the article is just where the comments start, i.e. not at the very bottom of the page) and click "Edit". (You need an account on Ubuntu Discourse.)
Task
Modify the landing pages for the four Diátaxis topic categories (tutorial, how-to, reference, explanation) to provide more context for the user. Visit Example landing page for an example.
Example
Page: https://multipass.run/docs/tutorials
Old text: "Get started - a hands-on introduction to Multipass for new users."
New text: "Get started - a hands-on introduction to Multipass for new users. These platform-specific tutorials teach you about creating and managing Multipass instances, and offer basic examples on how to use the instances."

Hey @rkratky ! I'm interested in this issue. Can you set me up with the Markdown in this repo so I can work on a fork? I could also address #55 while I'm at it if no one picks it up.

Hi @nielsenjared, your contributions have been incorporated into the official Multipass documentation: https://multipass.run/docs
Thank you so much for your help!


Adding the get started guidance

Through this pull request the getting started guidance is being added

Docs Build status updates of commit fb6fbb8:
:warning: Validation status: warnings

File
Status
Preview URL
Details

secmgmt/docs-conceptual/authenticate.md
:warning:Warning

Details

secmgmt/docs-conceptual/get-started.md
:white_check_mark:Succeeded

secmgmt/docs-conceptual/install.md
:white_check_mark:Succeeded

secmgmt/docs-conceptual/toc.yml
:white_check_mark:Succeeded

secmgmt/docs-conceptual/authenticate.md

Line 9: [Warning-InvalidFileLink] Invalid file link:(~/docs-conceptual/multi-factor-auth.md).
Line 22: [Warning-InvalidFileLink] Invalid file link:(~/docs-conceptual/multi-factor-auth.md).

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel

Docs Build status updates of commit c9a44f6:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

secmgmt/docs-conceptual/authenticate.md
:white_check_mark:Succeeded

secmgmt/docs-conceptual/get-started.md
:white_check_mark:Succeeded

secmgmt/docs-conceptual/install.md
:white_check_mark:Succeeded

secmgmt/docs-conceptual/multi-factor-auth.md
:white_check_mark:Succeeded

secmgmt/docs-conceptual/toc.yml
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel


[possible typo] AdaptiveAvgPool2d or AdaptiveMaxPool2d in NiN?

in Ch09_Modern_Convolutional_Networks/Network_in_Network(NiN).ipynb defines the NiN net model with:

    #Global Average Pooling can be achieved by AdaptiveMaxPool2d with output size = (1,1)
    self.avg1 = nn.AdaptiveMaxPool2d((1,1))

Is it a typo of nn.AdaptiveAvgPool2d or some deeper reasons behind this? Cause using Avg will train a lot slower and get bad train/val accuracy like 0.460 (epoch 5)

Yes, that's a typo in the notebook. Thanks for pointing it out. Would you like to send in a PR fixing it and updating the results after running the notebook?


MONDO:0100244  paroxysmal nocturnal hemoglobinuria (vs. acquired form: MONDO:0100245)

Mondo term (ID and Label):
MONDO:0100245, acquired paroxysmal nocturnal hemoglobinuria seems to have X-refs that belong to the parent concept; and maybe some other X-refs need to be reviewed and maybe moved?
Xref that should be fixed (ID and label):
SCTID 1963002
HP:0004818
Also ORPHA:447 appears to be equivalent to the OMIMPS:300818.
Your nano-attribution (ORCID)
If you don't have an ORCID, you can sign up for one here
Other comments:

Also ORPHA:447 appears to be equivalent to the OMIMPS:300818.
I don't think ORPHA:447 is equivalent to OMIMPS:300818.
Definition of ORPHA:447 suggests that it is an acquired disorder.
OMIMPS:300818 refers to a phenotypic series of inherited disorders.

Here is the source of the confusion:
OMIMPS:300818 refers to a phenotypic series. In this series, the terms (OMIM:300818 and OMIM:615399) are actually "susceptibility terms" (though "susceptibility" is not in name). Therefore variations in the genes associated with these entries conferred susceptibility to the disease, and therefore we cannot say that this disease is "inherited".
@ahamosh :
Does OMIMPS:300818 represent the "susceptibility to Paroxysmal nocturnal hemoglobinuria"?
or does it represent "Paroxysmal nocturnal hemoglobinuria", and  OMIM:300818 and OMIM:615399 are "susceptibility" to that disease?
Thanks!

@ahamosh : could you take a look at the previous comment and give us your opinion, please? Thank you!

300818 is always acquired as a somatic mutation in PIGA.  615399 is an autosomal dominant susceptibility where it looks like a second hit to the other PIGT allele is required for manifestation of disease.  Both are paroxysmal nocturnal hemoglobinuria.  Neither disease is inherited per se.  Does this make sense?

Thank you @ahamosh ! Yes, it make sense, thank you!
I will update the ontology accordingly.

@nicolevasilevsky
I cannot find evidence that we need an "acquired" versus "inherited" version of the disease. I would say that the best thing to do would be to merge these terms.
However, "paroxysmal nocturnal hemoglobinuria" was obsoleted in order to create these more specific 'acquired' and 'inherited' terms. I cannot find a GH issue referring to this splitting.
Can you please advise?

I can't find a ticket as to why these terms were split either. Based on this ticket, merging these terms makes sense to me.

to do:
acquired paroxysmal nocturnal hemoglobinuria (MONDO:0100245) and inherited paroxysmal nocturnal hemoglobinuria (MONDO:0100243) should be merged to paroxysmal nocturnal hemoglobinuria (MONDO:0100244)

There is a lot of reasoning and QC behind terms with relation to a gene and terms with OMIM/OMIMPS x-ref.
This issue requires #4675 to be closed before it can be resolved.
FYI @nicolevasilevsky: I am setting this issue for the next release (hopefully we can get #4675 by then), and I will update the time of obsoletion for these terms merging.

closed with https://github.com/monarch-initiative/mondo/pull/4800#pullrequestreview-950566683


check listFiles client API doc

Done. Made dummy function for document. Document could be generated for listFiles and other APIs that are decorated by @split_calls.


Add CI for alternate shells

@Akianonymus FYI, I added tests for other shells and a note to the readme!


Add missing Neo Coolcam device (INFO ZWAVE: Node 6 ready: Unknown manufacturer 600 - Unknown product 4135 (512))

Describe the bug
Tried to add a Neo Coolcam Plug device. It' results in the information from the logfile:
INFO ZWAVE: Node 6 ready: Unknown manufacturer 600 - Unknown product 4135 (512)
Besides that - the device in it self works.
Any guidance on how to have the right manufactor and product listed?
Device information
Which device(s) is/are affected?  Shenzhen Neo Electronics Co Ltd NAS-WR01Z Power plug 12A.
Link to z-wavealliance.org manual: link
Link to Product page: link
What are the node IDs?
Screendump:

Logfile:
2021-01-04 12:56:47.755 INFO ZWAVE: Controller status: Secure inclusion started
2021-01-04 12:56:47.755 INFO ZWAVE: Success zwave api call startInclusion true
2021-01-04 12:57:21.991 INFO ZWAVE: Controller status: Inclusion stopped
2021-01-04 12:57:21.996 INFO ZWAVE: Node 6: added
2021-01-04 12:57:21.997 INFO ZWAVE: Node added 6
2021-01-04 12:57:22.095 INFO ZWAVE: Node 6 is alive
2021-01-04 12:57:22.096 INFO ZWAVE: Controller status: Driver: Node 006 supports Security, but no network key was configured. Continuing interview non-securely.
2021-01-04 12:57:22.147 INFO ZWAVE: Node 6: value added: 114-0-manufacturerId => 600
2021-01-04 12:57:22.148 INFO ZWAVE: Node 6: value added: 114-0-productType => 512
2021-01-04 12:57:22.148 INFO ZWAVE: Node 6: value added: 114-0-productId => 4135
2021-01-04 12:57:22.208 INFO ZWAVE: Node 6: value added: 134-0-libraryType => 3
2021-01-04 12:57:22.210 INFO ZWAVE: Node 6: value added: 134-0-protocolVersion => 6.4
2021-01-04 12:57:22.211 INFO ZWAVE: Node 6: value added: 134-0-firmwareVersions => 2.23
2021-01-04 12:57:22.793 INFO ZWAVE: Node 6: value added: 134-0-sdkVersion => 6.81.3
2021-01-04 12:57:22.795 INFO ZWAVE: Node 6: value added: 134-0-applicationFrameworkAPIVersion => 4.1.2
2021-01-04 12:57:22.796 INFO ZWAVE: Node 6: value added: 134-0-applicationFrameworkBuildNumber => 52445
2021-01-04 12:57:22.798 INFO ZWAVE: Node 6: value added: 134-0-hostInterfaceVersion => unused
2021-01-04 12:57:22.799 INFO ZWAVE: Node 6: value added: 134-0-hostInterfaceBuildNumber => 0
2021-01-04 12:57:22.800 INFO ZWAVE: Node 6: value added: 134-0-zWaveProtocolVersion => 6.4.0
2021-01-04 12:57:22.801 INFO ZWAVE: Node 6: value added: 134-0-zWaveProtocolBuildNumber => 91
2021-01-04 12:57:22.802 INFO ZWAVE: Node 6: value added: 134-0-applicationVersion => 2.23.0
2021-01-04 12:57:22.802 INFO ZWAVE: Node 6: value added: 134-0-applicationBuildNumber => 52445
2021-01-04 12:57:22.908 INFO ZWAVE: Node 6: value added: 37-0-currentValue => false
2021-01-04 12:57:22.909 INFO ZWAVE: Node 6: value added: 37-0-targetValue => undefined
2021-01-04 12:57:22.970 INFO ZWAVE: Node 6: metadata updated: 50-0-reset
2021-01-04 12:57:23.026 INFO ZWAVE: Node 6: metadata updated: 50-0-value-65537
2021-01-04 12:57:23.027 INFO ZWAVE: Node 6: metadata updated: 50-0-previousValue-65537
2021-01-04 12:57:23.028 INFO ZWAVE: Node 6: metadata updated: 50-0-deltaTime-65537
2021-01-04 12:57:23.028 INFO ZWAVE: Node 6: value added: 50-0-value-65537 => -21474816.39
2021-01-04 12:57:23.029 INFO ZWAVE: Node 6: value added: 50-0-previousValue-65537 => -21474816.39
2021-01-04 12:57:23.030 INFO ZWAVE: Node 6: value added: 50-0-deltaTime-65537 => 12
2021-01-04 12:57:23.081 INFO ZWAVE: Node 6: metadata updated: 50-0-value-66049
2021-01-04 12:57:23.083 INFO ZWAVE: Node 6: metadata updated: 50-0-previousValue-66049
2021-01-04 12:57:23.088 INFO ZWAVE: Node 6: metadata updated: 50-0-deltaTime-66049
2021-01-04 12:57:23.089 INFO ZWAVE: Node 6: value added: 50-0-value-66049 => 0
2021-01-04 12:57:23.090 INFO ZWAVE: Node 6: value added: 50-0-previousValue-66049 => 0
2021-01-04 12:57:23.090 INFO ZWAVE: Node 6: value added: 50-0-deltaTime-66049 => 12
2021-01-04 12:57:23.139 INFO ZWAVE: Node 6: metadata updated: 50-0-value-66561
2021-01-04 12:57:23.141 INFO ZWAVE: Node 6: metadata updated: 50-0-previousValue-66561
2021-01-04 12:57:23.143 INFO ZWAVE: Node 6: metadata updated: 50-0-deltaTime-66561
2021-01-04 12:57:23.144 INFO ZWAVE: Node 6: value added: 50-0-value-66561 => 0
2021-01-04 12:57:23.145 INFO ZWAVE: Node 6: value added: 50-0-previousValue-66561 => 0
2021-01-04 12:57:23.146 INFO ZWAVE: Node 6: value added: 50-0-deltaTime-66561 => 12
2021-01-04 12:57:23.193 INFO ZWAVE: Node 6: metadata updated: 50-0-value-66817
2021-01-04 12:57:23.194 INFO ZWAVE: Node 6: metadata updated: 50-0-previousValue-66817
2021-01-04 12:57:23.195 INFO ZWAVE: Node 6: metadata updated: 50-0-deltaTime-66817
2021-01-04 12:57:23.195 INFO ZWAVE: Node 6: value added: 50-0-value-66817 => 0
2021-01-04 12:57:23.196 INFO ZWAVE: Node 6: value added: 50-0-previousValue-66817 => 0
2021-01-04 12:57:23.196 INFO ZWAVE: Node 6: value added: 50-0-deltaTime-66817 => 12
2021-01-04 12:57:23.904 INFO ZWAVE: Node 6: metadata updated: 113-0-Power Management-Over-load status
2021-01-04 12:57:23.941 INFO ZWAVE: Node 6: value added: 113-0-Power Management-Over-load status => 0
2021-01-04 12:57:23.995 INFO ZWAVE: Node 6: value added 6-37-0-currentValue => false
2021-01-04 12:57:23.996 INFO ZWAVE: Node 6: value added 6-37-0-targetValue => undefined
2021-01-04 12:57:23.996 INFO MQTT: Subscribing to z2m/+/+/+/+/set
2021-01-04 12:57:23.996 INFO ZWAVE: Node 6: value added 6-134-0-libraryType => 3
2021-01-04 12:57:23.997 INFO ZWAVE: Node 6: value added 6-134-0-protocolVersion => 6.4
2021-01-04 12:57:23.997 INFO ZWAVE: Node 6: value added 6-134-0-firmwareVersions => 2.23
2021-01-04 12:57:23.998 INFO ZWAVE: Node 6: value added 6-134-0-hardwareVersion => undefined
2021-01-04 12:57:23.998 INFO ZWAVE: Node 6: value added 6-134-0-sdkVersion => 6.81.3
2021-01-04 12:57:23.999 INFO ZWAVE: Node 6: value added 6-134-0-applicationFrameworkAPIVersion => 4.1.2
2021-01-04 12:57:23.999 INFO ZWAVE: Node 6: value added 6-134-0-applicationFrameworkBuildNumber => 52445
2021-01-04 12:57:24.000 INFO ZWAVE: Node 6: value added 6-134-0-hostInterfaceVersion => unused
2021-01-04 12:57:24.000 INFO ZWAVE: Node 6: value added 6-134-0-hostInterfaceBuildNumber => 0
2021-01-04 12:57:24.001 INFO ZWAVE: Node 6: value added 6-134-0-zWaveProtocolVersion => 6.4.0
2021-01-04 12:57:24.001 INFO ZWAVE: Node 6: value added 6-134-0-zWaveProtocolBuildNumber => 91
2021-01-04 12:57:24.002 INFO ZWAVE: Node 6: value added 6-134-0-applicationVersion => 2.23.0
2021-01-04 12:57:24.002 INFO ZWAVE: Node 6: value added 6-134-0-applicationBuildNumber => 52445
2021-01-04 12:57:24.003 INFO ZWAVE: Node 6: value added 6-114-0-manufacturerId => 600
2021-01-04 12:57:24.003 INFO ZWAVE: Node 6: value added 6-114-0-productType => 512
2021-01-04 12:57:24.004 INFO ZWAVE: Node 6: value added 6-114-0-productId => 4135
2021-01-04 12:57:24.004 INFO ZWAVE: Node 6: value added 6-50-0-value-65537 => -21474816.39
2021-01-04 12:57:24.004 INFO ZWAVE: Node 6: value added 6-50-0-previousValue-65537 => -21474816.39
2021-01-04 12:57:24.005 INFO ZWAVE: Node 6: value added 6-50-0-deltaTime-65537 => 12
2021-01-04 12:57:24.005 INFO ZWAVE: Node 6: value added 6-50-0-value-66049 => 0
2021-01-04 12:57:24.005 INFO ZWAVE: Node 6: value added 6-50-0-previousValue-66049 => 0
2021-01-04 12:57:24.006 INFO ZWAVE: Node 6: value added 6-50-0-deltaTime-66049 => 12
2021-01-04 12:57:24.006 INFO ZWAVE: Node 6: value added 6-50-0-value-66561 => 0
2021-01-04 12:57:24.006 INFO ZWAVE: Node 6: value added 6-50-0-previousValue-66561 => 0
2021-01-04 12:57:24.007 INFO ZWAVE: Node 6: value added 6-50-0-deltaTime-66561 => 12
2021-01-04 12:57:24.007 INFO ZWAVE: Node 6: value added 6-50-0-value-66817 => 0
2021-01-04 12:57:24.007 INFO ZWAVE: Node 6: value added 6-50-0-previousValue-66817 => 0
2021-01-04 12:57:24.008 INFO ZWAVE: Node 6: value added 6-50-0-deltaTime-66817 => 12
2021-01-04 12:57:24.008 INFO ZWAVE: Node 6: value added 6-50-0-reset => undefined
2021-01-04 12:57:24.008 INFO ZWAVE: Node 6: value added 6-113-0-Power Management-Over-load status => 0
2021-01-04 12:57:24.011 INFO ZWAVE: Node 6 ready: Unknown manufacturer 600 - Unknown product 4135 (512)
2021-01-04 12:57:24.012 INFO ZWAVE: Node 6: interview completed, all values are updated

Duplicate of #1221

Duplicate of #1221

Any guidance on how to have the right manufactor and product listed?

We need a config file for that. See also the linked original issue. If you'd like to help out, here are some docs to get you started:
https://zwave-js.github.io/node-zwave-js/#/development/config-files

Any guidance on how to have the right manufactor and product listed?

We need a config file for that. See also the linked original issue. If you'd like to help out, here are some docs to get you started:
https://zwave-js.github.io/node-zwave-js/#/development/config-files


Cannot reach CVL

Describe the problem
During charging from a Multiplus 24/1200 the batteries do not reach CVL (as shown in parameters)

This only happens when Controlling BMS is set to JK under Settings, DVCC

I have a Smartshunt as well and changing this to be Battery monitor the issue still occurs
I have tried Venus 3.01
I have tried VOLTAGE_DROP = 0.12 in the config.ini
I have also tried Bluetooth connection (instead of RS485)
Sorry about the log file format!
Driver version
1.0.20230531
Venus OS device type
Raspberry Pi
Venus OS version
3.00
BMS type
JKBMS / Heltec BMS
Cell count
8
Connection type
Serial USB adapter to RS485
Config file
[DEFAULT]

; If you want to add custom values/settings, then check the values/settings you want to change in "config.default.ini"
; and insert them below to persist future driver updates.

; Example (remove the semicolon ";" to uncomment and activate the value/setting):
; MAX_BATTERY_CHARGE_CURRENT = 50.0
; MAX_BATTERY_DISCHARGE_CURRENT = 60.0

Relevant log output
@4000000064d1309a1e576714 INFO:SerialBattery:Starting dbus-serialbattery
@4000000064d1309a1f74f4a4 INFO:SerialBattery:dbus-serialbattery v1.0.20230531
@4000000064d1309a1fa186cc INFO:SerialBattery:Testing Daly
@4000000064d1309a283fa084 ERROR:SerialBattery:>>> ERROR: No reply - returning
@4000000064d1309a2857cc04 INFO:SerialBattery:Testing Daly
@4000000064d1309a31f45674 ERROR:SerialBattery:>>> ERROR: No reply - returning
@4000000064d1309a31f471cc INFO:SerialBattery:Testing Ecs
@4000000064d1309a364c5e24 ERROR:SerialBattery:>>> ERROR: No reply - returning
@4000000064d1309a364c797c INFO:SerialBattery:Testing HeltecModbus
@4000000064d1309e2bf6d454 ERROR:SerialBattery:>>> ERROR: No reply - returning
@4000000064d1309e2bf6efac INFO:SerialBattery:Testing HLPdataBMS4S
@4000000064d130a310292f24 ERROR:SerialBattery:>>> ERROR: No reply - returning
@4000000064d130a310294e64 INFO:SerialBattery:Testing Jkbms
@4000000064d130a32bedc404 ERROR:SerialBattery:>>> ERROR: No reply - returning
@4000000064d130a32d4ae304 INFO:SerialBattery:Testing Lifepower
@4000000064d130a40e7baa1c ERROR:SerialBattery:>>> ERROR: No reply - returning
@4000000064d130a40f442a3c INFO:SerialBattery:Testing LltJbd
@4000000064d130a42ce86814 ERROR:SerialBattery:>>> ERROR: No reply - returning
@4000000064d130a42e48136c INFO:SerialBattery:Testing Renogy
@4000000064d130a50e0393ec ERROR:SerialBattery:>>> ERROR: No reply - returning
@4000000064d130a50e9c70bc INFO:SerialBattery:Testing Renogy
@4000000064d130a52975fda4 ERROR:SerialBattery:>>> ERROR: No reply - returning
@4000000064d130a52ad1fb94 INFO:SerialBattery:Testing Seplos
@4000000064d130a62bdcff0c ERROR:SerialBattery:>>> ERROR: No reply - returning
@4000000064d130a70e4a64d4 INFO:SerialBattery:Testing Daly
@4000000064d130a716f4a3ec ERROR:SerialBattery:>>> ERROR: No reply - returning
@4000000064d130a716f4bf44 INFO:SerialBattery:Testing Daly
@4000000064d130a72387f85c ERROR:SerialBattery:>>> ERROR: No reply - returning
@4000000064d130a7238f997c INFO:SerialBattery:Testing Ecs
@4000000064d130a805f53ee4 ERROR:SerialBattery:>>> ERROR: No reply - returning
@4000000064d130a805fc99b4 INFO:SerialBattery:Testing HeltecModbus
@4000000064d130ac0126ea0c ERROR:SerialBattery:>>> ERROR: No reply - returning
@4000000064d130ac01270564 INFO:SerialBattery:Testing HLPdataBMS4S
@4000000064d130b023d5fd04 ERROR:SerialBattery:>>> ERROR: No reply - returning
@4000000064d130b023dde474 INFO:SerialBattery:Testing Jkbms
@4000000064d130b02c096e0c INFO:SerialBattery:Connection established to Jkbms
@4000000064d130b02c11f1bc INFO:SerialBattery:Battery Jkbms connected to dbus from /dev/ttyUSB3
@4000000064d130b02c194c8c INFO:SerialBattery:========== Settings ==========
@4000000064d130b02c21f364 INFO:SerialBattery:> Connection voltage: 26.7V | Current: 8.07A | SoC: 100%
@4000000064d130b02c2988cc INFO:SerialBattery:> Cell count: 8 | Cells populated: 0
@4000000064d130b02c30f724 INFO:SerialBattery:> LINEAR LIMITATION ENABLE: True
@4000000064d130b02c39480c INFO:SerialBattery:> MAX BATTERY CHARGE CURRENT: 50.0A | MAX BATTERY DISCHARGE CURRENT: 60.0A
@4000000064d130b02c4123c4 INFO:SerialBattery:> MAX BATTERY CHARGE CURRENT: 50.0A | MAX BATTERY DISCHARGE CURRENT: 200.0A (read from BMS)
@4000000064d130b02c489dd4 INFO:SerialBattery:> CVCM:     True
@4000000064d130b02c508d14 INFO:SerialBattery:> MIN CELL VOLTAGE: 2.9V | MAX CELL VOLTAGE: 3.45V
@4000000064d130b02c582e34 INFO:SerialBattery:> CCCM CV:  True  | DCCM CV:  True
@4000000064d130b02c60f064 INFO:SerialBattery:> CCCM T:   True  | DCCM T:   True
@4000000064d130b02e33899c INFO:SerialBattery:> CCCM SOC: True  | DCCM SOC: True
@4000000064d130b02e33a4f4 INFO:SerialBattery:Serial Number/Unique Identifier: JK_B2A8S20P
@4000000064d130b039a028bc INFO:SerialBattery:DeviceInstance = 2
@4000000064d130b039a84ac4 INFO:SerialBattery:com.victronenergy.battery.ttyUSB3
@4000000064d130b10217c634 INFO:SerialBattery:publish config values = 1

Any other information that may be helpful
No response

I have tried VOLTAGE_DROP = 0.12 in the config.ini

This only works with the latest nightly from the dev branch. Please install it and try again.

I assume it is CCL limiting the charging current to a degree where reaching 27.6 V is not possible. Try disabling SoC based CCL.

I assume it is CCL limiting the charging current to a degree where reaching 27.6 V is not possible. Try disabling SoC based CCL.

Yes I meant to update this - I added to config.ini
CCCM_SOC_ENABLE = False


⚠ Turnos 24x7 has degraded performance

In fd18c12, Turnos 24x7 (https://reservas-dev.alternativasinteligentes.com/) experienced degraded performance:

HTTP code: 200
Response time: 902 ms

Resolved: Turnos 24x7 performance has improved in 9ae5686.


Installation Issue on Ubuntu 22.04

Using the instructions shown here, I am unable to get the libzstd-dev=1.4.4 to replace my current libzstd-dev=1.4.8

adduser --system --group --shell /bin/bash archiveteam echo deb http://deb.debian.org/debian buster-backports main contrib > /etc/apt/sources.list.d/backports.list apt-get update \ && apt-get install -y git-core libgnutls-dev lua5.1 liblua5.1-0 liblua5.1-0-dev screen bzip2 zlib1g-dev flex autoconf autopoint texinfo gperf lua-socket lua-filesystem lua-sec lua-zip rsync automake pkg-config python3-dev python3-pip build-essential poppler-utils \ && apt-get -t buster-backports install zstd libzstd-dev libzstd1 python3 -m pip install setuptools wheel python3 -m pip install --upgrade seesaw zstandard requests su -c "cd /home/archiveteam; git clone https://github.com/ArchiveTeam/imgur-grab.git; cd imgur-grab; ./get-wget-lua.sh" archiveteam screen su -c "cd /home/archiveteam/imgur-grab/; run-pipeline3 pipeline.py --concurrent 2 --address '<IP_ADDRESS>' YOURNICKHERE" archiveteam [... ctrl+A D to detach ...]

apt-get has an error for  apt-get -t buster-backports install zstd libzstd-dev libzstd1 . I've tried install individual packages such as libzstd1 or replacing install with reinstall but I cannot get apt-get to install libzstd-dev=1.4.4 and its dependencies over Ubuntu 22.04 existing packages.  There is always a warning that

Some packages could not be installed. This may mean that you have requested an impossible situation or if you are using the unstable distribution that some required packages have not yet been created or been moved out of Incoming.

Then it proceeds to tell me I have a newer version or libzstd-dev=1.4.4 has to have libzstd1=1.4.4 installed first.
Is there an override this warning and have apt-get install the old version? Especially install libzstd1=1.4.4 ? It seems I need to install that FIRST to meet the dependency for libzstd-dev=1.4.4.

It's not recommended to build Wget+At yourself. Use the Docker containers instead if at all possile.

Currently only Zstd 1.4.4 is supported. This will now not be changed. I do expect newer versions of Zstd to be supported in the near future, likely on other project.
As @TheTechRobo noted, please use Docker.


[admin] merge to live

Docs Build status updates of commit c66321b:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/exchange-web-services/how-to-communicate-with-ews-by-using-the-ews-managed-api.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel


Update README.md

Updates Supported Django Versions section.

Maybe we should just say "all Django versions currently supported by the DSF"? That seems safer than listing exact version numbers. Could also tell people to refer to the Django versions listed in the setup.py?

Thank you so much for your pull request! I've merged it into the branch I'm working on for the new version so I'm going to close this PR.
Feel free to submit a new PR adding yourself to the CONTRIBUTORS.md file.


Merge rubyspec archive

PR to test the build on Travis (try 2).
All ruby between 2.0 and trunk pass locally by running mspec without arguments.

The build is passing, except a couple errors on the "ruby-head" because it more than one week old.
I opened https://github.com/travis-ci/travis-ci/issues/3274 to ask when they will update it.
After that I'll push to master and later delete the ruby branch if that is fine?

@eregon Great work! I will confirm this branch on 2.0.0, 2.1, 2.2, trunk.

ruby-head was updated, now Travis passes, I'll push to master and remove this branch.
@hsbt Tell me when I can push to the ruby branch (if needed at all) and when I can delete it.

@eregon I changed default branch to master from ruby. Please wait to delete ruby branch before confirming to fine on rubyci.org.

OK, thanks!

Now, ruby is the same as master, let's wait for RubyCI.


Q: Self Hosted Mode how to mdns load balancing?  the app_id can't same.

it there has a hello world demo ?

In self hosted mode Dapr will automatically load balance across the different instances running with the same Dapr ID. You can demonstrate this using the existing hello world quickstart by starting multiple instance of the python app with the same app id but different ports.

@jjcollinge thanks

In self hosted mode Dapr will automatically load balance across the different instances running with the same Dapr ID. You can demonstrate this using the existing hello world quickstart by starting multiple instance of the python app with the same app id but different ports.

@jjcollinge Hi, can you tell me how to starting multiple instance of the python app with the same app id but different ports?
I've tried, but it tells "dapr with ID pythonapp is already running", it seems self-hosted mode does not support multiple instances with same app-id ?

@Macrow this is a restriction imposed by the dapr CLI but not by the daprd runtime. I was actually mistaken in my comment above that suggested running multiple instances of the python app. As the python app calls the node app - you in fact want to run multiple instances of the node app. This is do able by running the daprd directly using
~/.dapr/bin/daprd -app-id nodeapp -app-port 3000 -dapr-http-port 3500 -components-path ~/.dapr/components and then running the node app using node app.js. Now that one instance is running you can modify the port in the app.js file to 3001. Then run another instance of the dapr sidecar using ~/.dapr/bin/daprd --app-id nodeapp -app-port 3001 -dapr-http-port 3501 -components-path ~/.dapr/components and finally run the node app using node app.js. If you also run the python app using the dapr CLI as normal you should see that the requests are being distributed across both node instances.

@jjcollinge Thanks for your help, indeed, daprdcould start two instances with same app-id,
~/.dapr/bin/daprd --app-id nodeapp --app-port 3000 --dapr-http-port 3500 node app.js

~/.dapr/bin/daprd --app-id nodeapp --app-port 3001 --dapr-http-port 3501 --metrics-port 9091 --dapr-grpc-port 50002  node app.js

I must specify metrics port and grpc port, if not,  it could not start the second instance

But after that, the dapr can not discovery the two instances, the dashboard( dapr dashboard -p 9999) can not locate the two instances at all,
I try to curl http://localhost:3500/v1.0/invoke/nodeapp/method/order, it responds like {"errorCode":"ERR_DIRECT_INVOKE","message":"invoke API is not ready"}
dapr in  self-hosted mode is not ready for running multiple instances for services, is it right?

@jjcollinge Thanks for you help.
daprdcould help to start two instances indeed.
In this situation, the python app how to decide which instance should be invoke? with load balance?
cur http://localhost:3500/v1.0/invoke/nodeapp/method/order
// or
curl http://localhost:3501/v1.0/invoke/nodeapp/method/order

Daprd will scan for addresses using mDNS - when it receives the first response it will start using that. In the background it will scan for any more addresses. If it finds more addresses, it will start to distribute the requests across the addresses by iterating through them in a linear manner. There is no smart strategy to decide which instance to send the request to at the moment.

Thanks, it helps.
but sorry for one more question, in service invocation

//dependencies
import { DaprClient, HttpMethod, CommunicationProtocolEnum } from 'dapr-client';

//code
const daprHost = "<IP_ADDRESS>";

var main = function() {
  var orderId = 100;
  //Using Dapr SDK to invoke a method
  const client = new DaprClient(daprHost, process.env.DAPR_HTTP_PORT, CommunicationProtocolEnum.HTTP);
  const result = await client.invoker.invoke('checkout' , "checkout/" + orderId , HttpMethod.GET);
}

main();

or use Additional URL formats
curl http://localhost:3602/v1.0/invoke/checkout/method/checkout/100

We need to specify the dapr http port, if I have two dapr http ports, for example 3500 and 3501, I just pick one, dapr will smart to route another one for load-balance?

@Macrow  How did you solve it?

Sorry, I couldn't fix it.
I think the "self hosted" mode is more for testing or learning purpose, if you really want production mode, it better runs in kubernetes.


Take application lock once per run MERGEOK

Old method takes application lock per node, with the default 2 minute timeout.
@hakonhall or @freva

Needed to fix critical deployment issues


The loading screen gets out  of the Safe Area.

The loading screen every time it loads the letters enters and leaves the allowed area.

PlainSubLevelLoading used


503 Service Unavailable

The code designed to retry api connections if Wildfly hasn't started up yet isn't working for me.
Error: /Stage[main]/Profile::Keycloak/Wildfly::Resource[/socket-binding-group=standard-sockets/socket-binding=proxy-https]/Wildfly_resource[/socket-binding-group=standard-sockets/socket-binding=proxy-https]: Could not evaluate: 757: unexpected token at '<title>Error</title>503 - Service Unavailable'
/opt/puppetlabs/puppet/lib/ruby/2.1.0/json/common.rb:155:in `parse'
/opt/puppetlabs/puppet/lib/ruby/2.1.0/json/common.rb:155:in `parse'
/opt/puppetlabs/puppet/cache/lib/puppet_x/wildfly/api_client.rb:58:in `submit'
/opt/puppetlabs/puppet/cache/lib/puppet_x/wildfly/operation_request.rb:40:in `exists?'
/opt/puppetlabs/puppet/cache/lib/puppet/provider/wildfly_resource/http_api.rb:18:in `exists?'

It appears the @http_client.request authz_request get in authz_header works fine, but the post in submit gets a 503.  The service is 'partially' started??
Furthermore, the 503 isn't returned as json so I get the unexpected token exception instead of the "Failed with: #{response['failure-description']} for #{body.to_json}" one.
I'm using the keycloak distribution on CentOS 7 with puppet 4.10.3.  I think you should be able to reproduce the issue with the following and puppet apply.
class { '::wildfly':
    version           => '10.1.0',
    distribution      => 'wildfly',
    config            => 'standalone-ha.xml',
    install_cache_dir => '/tmp',
    install_source    => 'https://downloads.jboss.org/keycloak/3.1.0.Final/keycloak-3.1.0.Final.tar.gz',
    mgmt_user         => {
      username => 'admin',
      password => 'admin',
    },
  }
wildfly::resource { '/socket-binding-group=standard-sockets/socket-binding=proxy-https':
    content => {
      port => 443,
    },
    notify  => Wildfly::Reload['Reload if necessary'],
}

wildfly::reload { 'Reload if necessary':
    retries => 2,
    wait    => 15,
}

Many thanks,
Alex

I have seen this as well using the standard wildfly distribution, so it's not related to keycloak. Could perhaps be solved by checking if response is an instance of Net::HTTPSuccess, and if not trigger a retry?

Just confirmed this.  Don't even need wildfly::reload to reproduce it.
It's not happening during retry - and the retried request needs to return 401 (Net::HTTPUnauthorized) with data to perform digest authentication.
This is happening afterwards during the actual Management Request - as far as I understood, Management API is ready to process authentication, but Wildfly is not ready to receive any management operations, hence the 503.
Sysvinit scripts used to work by checking Wildfly's logs for JBAS015874, but they replaced it with a markerfile approach. Bundled systemd scripts does not use any of this.
I need another way to assert that Wildfly is ready cause I can't retry actual management requests since some of them are not idempotent. It was OK to retry authentication.
One alternative would be to not use bundled systemd script but systemd/sysvinit wrapper (like Wildfly < 10: https://github.com/biemond/biemond-wildfly/blob/master/templates/wildfly.sysvinit.service.epp) or create a new script.


Clarify is classic experience

closes https://github.com/MicrosoftDocs/OfficeDocs-SharePoint/issues/3467

@WayneEwington PR has been copyedited and is ready for final review, could you please check and merge? Thanks!


[bug] Throughput with place-and-adjust assumes a stack size of 1

When holding an inserter and using place-and-adjust, the initial throughput estimation will assume a stack size of 1. Expected (modifying existing inserter):

Actual (place-and-adjust):

(note: this is an inserter crane with stack size 250)

Damn, I thought I was handling this well enough for it to not be noticed. Basically it is using LuaEntity::inserter_target_pickup_count, which seems like a really smart idea, except that this variable only updates when the inserter starts a swing, or something along those lines. I've not figured out the exact timing as to when it updates, but it does tend to be outdated, especially when placing new inserters or researching a new stack size tech level.
I've already implemented manually calculating the real stack size, but I've not used it everywhere since it is more expensive than using the built in variable. I'll likely go ahead and use that calculation basically everywhere unless I can find a better pattern where I can reliably use inserter_target_pickup_count.
Long story short, thank you for the report, I'll look into it more and fix it :+1:

I decided to do some evil cherry picking to get this out sooner. Should be fixed with version 1.1.4, thanks again for the report :)


Fix environments where we rely on .env

In development where we're now mostly using docker, .env isn't as crucial for setup; in production, it's absolutely required.
Dotenv\Dotenv::create() needs to happen before most requires in index.php and some other entry-point files, especially before functions.inc is required. This PR shifts things around to make that work.
We might want to simply pull the environment variables out of docker-compose.yml, to force the two environments to behave more similarly.

GitHub API communication error. Please contact a human. (commit-ID: bdc0bbe6f5cafa747ffe8389b8a2a32f09e9cf51).