feat: Add saveSession option in goture_client signUp method

What kind of change does this PR introduce?
Feature
What is the current behavior?
When the user successfully signup, goture_client will automatically saves the user session.
What is the new behavior?
Ability to set the saveSession option in case we don't want to save the user's session after signup for some app that the user have to login after successful signup.

for some app that the user have to login after successful signup.

Why would one want to add extra steps for the users? I guess it's not the same, but you can set the autoRefreshToken to false if you don't want the session to be refreshed once the token expires.
await Supabase.initialize(
  url: supabaseUrl,
  anonKey: supabaseKey,
  debug: false,
  authOptions: FlutterAuthClientOptions(
    autoRefreshToken: false,
  ),
);

Why would one want to add extra steps for the users?

I think it is just about app behavior. Most apps including GitHub asks a user to login again after successful sign up.
autoRefreshToken will not do this behavior I guess.

@htoopyaelinn56 Hmm, why do you want the user to sign in again when the user is already signed in? There is no real benefit to having them sign out right after they sign up. If you really want to do this today, you could just call signOut() right after you complete the signUp() call, but I really don't see why one would want to do that.

This is about applications' business logic other than benefits. As I mentioned, some apps including even GitHub asks a user to login again after the registration. Justing calling signOut() after signUp() might not be a good practice, it could be better not saving user's session at the first place for those who don't want to save the session of the user and want the user to re-login after signup. I set the newly added parameter saveSession to true so it still works as expected as before without breaking change.

Sorry, my comment here stands and I'm closing this.

hey @htoopyaelinn56 . I can see the use-case for this but I think it's important that it happens on the server and not on the client (since a malicious actor could still access the session token in the API response even if you decide to drop it in the app).
Currently to my knowledge the session token is not returned when awaiting email signup confirmation. Which signup mechanism are you using?

@kangmingtay I have a question. If SECURITY_UPDATE_PASSWORD_REQUIRE_REAUTHENTICATION is set to true, on sign up - will the user be required to re-authenticate? or does this config only affect password resets?
If it doesn't affect signups (for cases where MAILER_AUTOCONFIRM is true), perhaps it could be useful functionality 🤔. Although it may have to be a new config, to give more granular control.

Hi @awalias. Thanks for the response. I'm using email auth and set auto confirmation to true. We have the existing auth service and use supabase auth just to access database. Sorry if my use-case is a bit complex.


Add constructor with pluggable transport

This pull adds a new constructor function that takes in an http.Transport. This would allow users to pass in instrumented transports to support observability efforts and trace API requests to the MAAS backend.
I think a move towards a builder / option pattern would be more elegant here but I'm keeping my changes minimal.
Fixes https://github.com/maas/gomaasclient/issues/32

This should use http.RoundTripper I think, will fix later today.


[Model Training] abrupt change in 'validation_f1'

Hi, @EliHei2! I happen to notice some weird behaviour during training on our larger Xenium dataset (8 sections; 5k panel).
I run following code for the training
# Initialize the Lightning trainer trainer = Trainer(     accelerator='cuda',     strategy='auto',     precision='16-mixed',     devices=1,     max_epochs=100, #or 20     default_root_dir=models_dir,     logger=CSVLogger(models_dir), )
Initially, during 100 epochs it noticed sudden drop in validation_f1 curve so I reduce the #epochs on followin run to 20 epochs
[100 epochs]

However, even with lower number of epochs the drop still occur during training.
[20 epochs]

I observed this on at least two dataset we are having with both with multiple section and large panel within the slide. Any suggestion you might have while developing segger? (e.g., maybe one need to split the dataset into individual section to prohibit model not too confuse)
best,
J

FYI, splitting whole slide into individual section still experience same validation_f1 drop..
[inidivudal section; 100 epochs]

Hey @jpark27, we're aware of this problem. We spotted it recently, it has happened newly after one of our new commits. Training with embedding (not one-hot embeeding) should work fine, but we're working to find the bug resulting in such behaviours. Thanks for your patience.


Wifi AP mode doesn't obtain IP address

Hello,
I'm using esp32 chip with https://github.com/aws/amazon-freertos/blob/master/demos/espressif/esp32_devkitc_esp_wrover_kit/common/application_code/main.c demo code. I wanna start the chip in wifi AP mode, so i changed

xWifiStatus = WIFI_ConnectAP( &( xNetworkParams ) );  (219 row)

to

xWifiStatus= WIFI_StartAP();

And removed code the following code associated with mqtt demos running:
(158-161 rows)

vDevModeKeyProvisioning();
DEMO_RUNNER_RunDemos();

After running the modified code on the device, i have the following behavior:

0 0 [IP-task] prvIPTask started
I (134) wifi: wifi driver task: 3ffd9634, prio:23, stack:3584, core=0
I (134) wifi: wifi firmware version: 8f35e40
I (134) wifi: config NVS flash: enabled
I (144) wifi: config nano formating: disabled
I (144) system_api: Base MAC address is not set, read default base MAC address from BLK0 of EFUSE
I (154) system_api: Base MAC address is not set, read default base MAC address from BLK0 of EFUSE
I (174) wifi: Init dynamic tx buffer num: 32
I (174) wifi: Init data frame dynamic rx buffer num: 5
I (174) wifi: Init management frame dynamic rx buffer num: 5
I (174) wifi: Init static rx buffer size: 1600
I (184) wifi: Init static rx buffer num: 5
I (184) wifi: Init dynamic rx buffer num: 5
1 6 [main] ConfigureMe2 6 [main] WiFi module initialized. Connecting to AP alice_g...
I (1244) phy: phy_version: 4000, b6198fa, Sep  3 2018, 15:11:06, 0, 0
I (1244) wifi: mode : softAP (24:0a:c4:13:44:f5)
I (1244) wifi: Init max length of beacon: 752/752
I (1244) wifi: Init max length of beacon: 752/752
I (1254) WIFI: SYSTEM_EVENT_AP_START
3 112 [main] WiFi AP started...
I (24194) wifi: n:1 0, o:1 0, ap:1 1, sta:255 255, prof:1
I (24194) wifi: station: 88:83:22:a8:4d:9e join, AID=1, bgn, 20
I (24194) WIFI: SYSTEM_EVENT_AP_STACONNECTED
I (25014) wifi: station: 88:83:22:a8:4d:9e leave, AID = 1
I (25014) wifi: n:1 0, o:1 0, ap:1 1, sta:255 255, prof:1
I (25014) WIFI: SYSTEM_EVENT_AP_STADISCONNECTED
I (39114) wifi: n:1 0, o:1 0, ap:1 1, sta:255 255, prof:1
I (39114) wifi: station: 88:83:22:a8:4d:9e join, AID=1, bgn, 20
I (39124) WIFI: SYSTEM_EVENT_AP_STACONNECTED
I (75204) wifi: station: 88:83:22:a8:4d:9e leave, AID = 1
I (75204) wifi: n:1 0, o:1 0, ap:1 1, sta:255 255, prof:1
I (75204) WIFI: SYSTEM_EVENT_AP_STADISCONNECTED
I (79474) wifi: n:1 0, o:1 0, ap:1 1, sta:255 255, prof:1
I (79474) wifi: station: 88:83:22:a8:4d:9e join, AID=1, bgn, 20
I (79474) WIFI: SYSTEM_EVENT_AP_STACONNECTED
I (115164) wifi: station: 88:83:22:a8:4d:9e leave, AID = 1
I (115164) wifi: n:1 0, o:1 0, ap:1 1, sta:255 255, prof:1
I (115174) WIFI: SYSTEM_EVENT_AP_STADISCONNECTED

So, every time I try to connect to the wifi network of the chip, the following happens:

I (79474) WIFI: SYSTEM_EVENT_AP_STACONNECTED
I (115164) wifi: station: 88:83:22:a8:4d:9e leave, AID = 1
I (115164) wifi: n:1 0, o:1 0, ap:1 1, sta:255 255, prof:1
I (115174) WIFI: SYSTEM_EVENT_AP_STADISCONNECTED

The device is trying to connect, but cannot get ip address.
Expected behavior:

I (...) tcpip_adapter: softAP assign IP to station,IP is: 192.168....

Actual behavior:

I (...) WIFI: SYSTEM_EVENT_AP_STADISCONNECTED

Any ideas?
Thank you!

Hi,
softAP mode requires DHCP server running on device and it's currently not supported in ESP32. We value your feedback and will take them into consideration in prioritizing our support for features on ESP32.
Thanks.

Recording a +1 for the same feature on the PIC32MZ port

Is there any update on this ? It is a bit sad to find basic features that worked id idf version to disappear in the AWS version.

at least remove it from the documentation, please.

@tjirsch can you please point me to the documentation that you reference above?

LwIP support for ESP32 has been merged in https://github.com/aws/amazon-freertos/pull/1519
We are doing further testing on its functionality and make sure it works as expected. After that, we will try testing the DHCP server.
Thanks for requesting this feature.


Cannot connect to the host.

The application, which worked for a long time without any problems, started to give this error today. I'm sure I entered the IP and host address correctly, since the wifi is shared, it finds the device without typing. After clicking it says connect to device, after a long time can't connect to host. Then please make sure you type the correct ip address. It says bla bla. I tried to open and close the program on the computer, tried to delete and install it, tried the same on my android, tried turning the computer and android on and off, reset the modem, changed the dns address, nothing worked.

By the way, I tried with a different phone, same error.

This is not a bug. This is always caused by a wrong configuration of your system.
https://github.com/Macro-Deck-App/Macro-Deck/wiki/Frequently-asked-questions


Fair min fees

Note that with the price of ADA being 2x what it was when I proposed this CIP, it is even more critical to adopt this CIP or to prepay min fees.

Note that with the price of ADA being 2x what it was when I proposed this CIP, it is even more critical to adopt this CIP or to prepay min fees.

No it really isn't, unless we implement full fee market, considering we already have large chain utilization, and we're expecting significantly more transactions once dApps go live over next few months.

Note that with the price of ADA being 2x what it was when I proposed this CIP, it is even more critical to adopt this CIP or to prepay min fees.

No it really isn't, unless we implement full fee market, considering we already have large chain utilization, and we're expecting significantly more transactions once dApps go live over next few months.

I don't understand what you mean by "full fee market" in this context or how the number of transactions on the chain is relevant to the issue of the minimum fixed fee (340 ADA( paid to pools that make at least 1 block.

Note that with the price of ADA being 2x what it was when I proposed this CIP, it is even more critical to adopt this CIP or to prepay min fees.

No it really isn't, unless we implement full fee market, considering we already have large chain utilization, and we're expecting significantly more transactions once dApps go live over next few months.

I don't understand what you mean by "full fee market" in this context or how the number of transactions on the chain is relevant to the issue of the minimum fixed fee (340 ADA( paid to pools that make at least 1 block.

Sorry, I confused this (stakepool fees) proposal with a different proposal debated on twitter few weeks back regarding minimal TX fees.

@kevinhammond
Yesterday on the SPO call there were both small and large SPOs advocating for removal of this 340 min fee. It's around half the block reward now making small pools uncompetitive, and we see stake moving from single pool operators to multi-pool operators every epoch.
The response given was that this cannot be removed for "security reasons", but no more information was given (despite several people asking).
If that's true, then I don't understand why this CIP wasn't rejected a long time ago. Why is it being dragged out giving small SPOs the false impression that the playing field might become more level in the future? And where is this documented that we can read about? We wouldn't keep asking about it every SPO call if this information was clear and unambiguous.
If it's not true (and there was some misunderstanding), then how does this progress? IOG said they want us to be in control of parameters, but any time we want a dialog about it, it gets brushed away with vague responses.

@KtorZ according to my notes this PR needed github clean-up before moving it to Last Check. Are we going to wait or shall be added to Last Check for next week meeting?

@shawnim as discussed in the editor meeting, this PR has a weird git commit history (probably due to some merge or rebase from a wrong revision) so I'll clean up the history to keep only the last commit that is actually the change proposed by the PR (moving it to proposed) and proceed with merging it :+1:
Meanwhile, I'll also bring it back to the attention of the core team to see if we can have anyone commenting on its feasibility and inclusion in the ledger or, if we should mark this CIP as obsolete given some rebuttal.

@shawnim as discussed in the editor meeting, this PR has a weird git commit history (probably due to some merge or rebase from a wrong revision) so I'll clean up the history to keep only the last commit that is actually the change proposed by the PR (moving it to proposed) and proceed with merging it +1
Meanwhile, I'll also bring it back to the attention of the core team to see if we can have anyone commenting on its feasibility and inclusion in the ledger or, if we should mark this CIP as obsolete given some rebuttal.

Thanks @KtorZ !


No Proration Modes in current version

I want to use Proration Modes for upgrading and downgrading subscriptions.
BillingFlowParams flowParams = BillingFlowParams.newBuilder()
.setSkuDetails(skuDetails)
.setOldSku(oldSku)
.setReplaceSkusProrationMode(replaceSkusProrationMode)
.build()
int responseCode = billingClient.launchBillingFlow(activity, flowParams);
ProrationMode can be IMMEDIATE_AND_CHARGE_PRORATED_PRICE | DEFERED.
please update it

Hi. I'm unfamiliar with this feature. I am also unsure if the library we wrap supports this feature: https://github.com/anjlab/android-inapp-billing-v3
When was this introduced? PR is welcome for anyone who wants to tackle this.

its introduces in InAppBilling v3: 1.1.+ version
Here is the link reference:
https://developer.android.com/google/play/billing/billing_library_releases_notes

@cbrevik I have created library with proration mode and v3 version as per my functionality demands


[Off-topic / Do not answer] GPU installation pictures

issue used for adding pictures for GPU installation on Windows
Changing PATH:

MinGW install:

Checking whether we are using R's MinGW or stand-alone MinGW (we are using R here):

What you get at the end of Boost installation (this was for MinGW 5.3, while Rtools is not 5.3 currently):

This is what happens when we link to Rtools's MinGW:

Here, downloading Git for Windows:

Here, cmake download:

Here I use cmake on C:/xgboost/LightGBM:

Scroll down, and check USE_GPU:

In Git Bash, we can run make and we clearly see it compiled successfully with GPU!:

Some hack to do on CLI/Python GPU to avoid segmentation fault:

Alternative hack:

When we run it with CLI with GPU support:

We can even compile for Python without any issue:

In Python and Windows, we cannot see the GPU so you have to rely on the delay between the issued command and the real training:

Getting Makeconf in R:

Makevars looks like that:

Installation in R working peacefully:

Now we can try with GPU support in R:

Laurae's LightGBM package:

Debugging:
remove this:

add debug in cmake:

compile with debug:

run:

(ignore this if subscribed)
random stuff (pictures for PR)


Tolerance adjustment unaffected

Hey there
I was trying out this script and it seems to run into some issue with the tolerance adjustment. I tried a directory on the default settings without defining the tolerance and it ended up thinning it down to 500 images from 12000 but for me it was too many removed.
I then set -t 100  to hopefully have it not delete as many images on the same 12000 but when the script finished, it only had shown 500~ like the last one. Is this by design to only keep 500?

I had push a fix to author.

Thank you, trying it now. Seems like a value of 100 will remove all photos except the first one while a value of 0 goes through every image slowly and didn't delete anything after running for a few minutes. I'm guessing the tolerance level is really the strength, So 0 would mean that it would have to be the very exact image if it decides to detect it

Would there be a way of speeding up the processing with the tolerance level being lower? On a level of 2 it took close to 6 hours to process ~3k photos. It would be cool if there could be a min max limit set to check if a duplicate is in 200 files before the current file and 200 files after instead of checking the entirety of the folder versus the one image. Would that be possible, or a scene detection type setup?


Remove Standard Library

Consider moving the logic in the standard library directly into the compiler. This would have two direct benefits. First, it would improve performance because the generated code can be run without first parsing it into a Program. Second, it would make it easier to add additional features to the language because you would only have to change the compiler. However, it would also make the generated code less understandable.
This was the approach taken in early versions of the compiler. We elected to add the standard library because it became difficult to test if the generated code was correct. Because we have shown that it indeed correct, there is no need for the standard library to exist anymore.

Rewriting the compiler to incorporate all the features of the standard library proved extremely difficult.

Built-in functions are difficult to code generate.
Function calls are difficult to code generate.
Testing generated code is difficult.
Understanding generated code is impossible for non-trivial programs.


Update Workflow Permissions

Currently unable to use my computer at the moment
I tried merging but got this error so will try again later.
@0xcodercrane perhaps some config was changed in your CI?
Be sure to post your wallet address on the issue (not this PR) @FibrinLab

Since this PR modifies the workflow, your OAuth token doesn't have workflow modification permission.

More info: How to resolve "refusing to allow an OAuth App to create or update workflow" on git push
@pavlovcik
Originally posted by @Steveantor in https://github.com/ubiquity/ubiquity-dollar/pull/426#issuecomment-1367537438

@Steveantor you seemed knowledgable on this issue. Perhaps I can assign it to you and work with you to test that it is solved?

@Steveantor you seemed knowledgable on this issue. Perhaps I can assign it to you and work with you to test that it is solved?

sure I can be assigned to this.
@pavlovcik

Deep dive down:
GitHub Clients use multiple authentication methods:

OAuth Apps
Personal access tokens: [Fine-grained tokens, Classic tokens]
Traditional Authorization (user: pass)

to communicate with the server to handle
issues, pull_requests, notifications  etc.
The issue here is that both GitHub Desktop and GitHub Mobile (and other git clients) usually use OAuth,
but with a slight variation in the permissions.

GitHub Desktop requests the _update github action workflows_ permission.

GitHub Mobile (Android) doesn't do that.
This causes GitHub Mobile fails to merge any commits that modify the .github/workflows/*.yml,
due to insufficient OAuth permissions.
Unfortunately, GitHub doesn't support modifying OAuth App's permissions.
we could take some alternative approaches to deal with this issue as shown below.
Generate Classic tokens:

Personal access tokens (classic)

workflow: Update GitHub Action workflows
Generate Fine-grained tokens (Beta):

Fine-grained personal access tokens

Workflows: Update GitHub Action workflow files.

Solutions:

Use GitHub Web (or a client that supports user: pass)
Use alternative GitHub clients

⚠GitHub Mobile doesn't support personal access tokens at the time (tested on GitHub for Android)⚠
There are two Mobile clients that work pretty well.
OctoDroid:

OctoDroid for GitHub

ForkHub

ForkHub for GitHub

username: <space>
password: <personal_access_token>
@pavlovcik

@Steveantor thanks for the write up. I'll check out the other clients and we can consider this issue solved. Please share your address. Thanks!

Here's my address:
0x4841e8153a7b9E8B1F218E42d3cBaEb3e99C28eE
@pavlovcik

Here's my address: 0x4841e8153a7b9E8B1F218E42d3cBaEb3e99C28eE @pavlovcik

https://etherscan.io/tx/0x8316371e9de08e28fb08d1ea8f0caa1abcd44c63b5cc13ca2c9654a1f32ecb7c
https://etherscan.io/tx/0xbc267a79fc4966c6d2c8a017de1970cea1d8380784f730edfd82abe9b0a261af


Implement static AR Mode for Configurator and VTO integrations

See Issue #25
Implement new optional ar-mode attribute that can have values of generated or inherited that controls the type of AR to launch

Testing
Testing was performed on previous vto and configurator example code.

VTO Example https://plattar.stoplight.io/docs/plattar/ZG9jOjM5NzUyNDQx-virtual-try-on-embed
Configurator Example https://plattar.stoplight.io/docs/plattar/ZG9jOjM4OTE0MjE2-configurator-embed

Testing ConfiguratorState

Testing ConfiguratorState.decodeScene() - (tbd)
Testing ConfiguratorState.first() - (tbd)
Testing ConfiguratorState.findSceneProduct() - (tbd)
Testing ConfiguratorState.setSceneProduct() - (tbd)

Testing VTO generated Mode
tbd
Testing VTO inherited Mode
tbd
Testing Configurator generated Mode
tbd
Testing Configurator inherited Mode
tbd


Create unit tests for individual features

We need to begin writing unit tests. It was suggested that we do this at a file level (eg. one for all of HomeController.cs) and then within that test the various functions in the class. This can provide some logical grouping for the testing suite.

Selenium not supported in core, so I'm going to begin writing unit tests for backend

Sample unit tests have been written in the JabbR-Core.Tests project. I've written one for HomeController and two for Hubs/Chat.cs, these are pretty rudimentary but can be used as example tests so anyone can write one in the future.
To run:
cd /path/to/project/test/JabbR-Core.Tests/
dotnet test
This is how you can make sure your tests perform as expected, but this is run automatically in the Travis.yml file also on the jj/travis-ci branch. Marking this issue as closed.


Support Snowflake/BigQuery TRIM.

Why
We are getting errors with parsing snowflake TRIM expression including removing characters separated by comma.
Snowflake doc for TRIM
https://docs.snowflake.com/en/sql-reference/functions/trim
BigQuery doc for TRIM
https://cloud.google.com/bigquery/docs/reference/standard-sql/string_functions#trim
Example of real failing sql
WITH sub_coupons AS (
    SELECT
        customer_id,
        subscription_id,
        TRIM(coupons.value:coupon_id, '"') AS coupon_id
    FROM model_staging.subscriptions,
    TABLE(FLATTEN(PARSE_JSON(coupons))) AS coupons
)

There appear to be some small CI errors -- @zdenal  can you please fix them?

@alamb RDY again. I have also added BigQuery to support this syntax (link to BigQuery TRIM doc attached in PR description).

The CI failures do not appear to be related to this PR -- see https://github.com/sqlparser-rs/sqlparser-rs/pull/995
I believe if you merge / rebase this branch with main the CI will pass cleanly

@alamb RDY again.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

50 of 50 (100.0%)  changed or added relevant lines in 5 files are covered.
1 unchanged line in 1 file lost coverage.
Overall coverage increased (+0.03%) to 87.354%

Files with Coverage Reduction
New Missed Lines
%

src/ast/mod.rs
1
78.86%

Totals

Change from base Build<PHONE_NUMBER>:
0.03%

Covered Lines:
16778

Relevant Lines:
19207

💛  - Coveralls


Download failed. Blacklisted URL.

Check ARIA_FILTERED_DOMAINS and ARIA_FILTERED_FILENAMES in your "src/.constants.js". Something in there is matching the link/filename you tried to mirror.
My guess is that one of them is set to [''], which will match everything.

does it have to be filled in? I deleted the string because there was no name or link that I didn't want to filter

Remove the quotes.


checking charm-mysql-router bug

mysql-router < 8.0.23 doesn't support TLS,
and >= 8.0.23, new option is added ( e.g. client_ssl_mode depends on client_ssl_cert )
latest charm has an issue as it inserts client_ssl_mode forcely without checking if there is client_ssl_cert
so, if mysql-router is upgraded from < 8.0.23 to >= 8.0.23, and charm is upgraded to latest, there will be an error.
(as mysql-router bootstrapping creates configuration file, upgraded mysql-router from < 8.0.23 doesn't have proper client_ssl_cert but charm think it is there )
fixing charm is in progress

@xtrusia can you provide the LP bug number for the charm and also, if possible, an example log that we could use to detect if we are affected by this issue.

Actually error msg is this
/var/lib/mysql/mysql-router/log/mysqlrouter.log:2022-07-25 08:25:01 main ERROR [7fdb4b5e6e00] Configuration error: client_ssl_cert must be set, if client_ssl_mode is 'PREFERRED'.
but it is now shown right after charm has issue 'Failed to connect to MySQL'
Above error msg is shown when trying to restart mysql-router inside unit.
so My plan is that to check if there is client_ssl_mode but no client_ssl_cert in /var/lib/mysql/mysql-router/mysqlrouter.conf

ok sounds good. you can find an example of checking mysql config at https://github.com/canonical/hotsos/blob/main/defs/scenarios/mysql/mysql_connections.yaml for ref


F# support and ASP.NET v5 ?

Will F# completely support ASP.NET 5 (old postings like "http://blog.alxandr.me/2014/11/23/f-in-asp-net-5-the-good-the-bad-and-the-really-ugly/" seems to indicate problems) ?

I really hope so and I hope it works on Linux. Great progress was made a couple of weeks ago with getting the compiler to run on CoreClr #646. Over the weekend, I created a Docker container to see how far I could get with getting it to build on Linux #680. Besides ASP.NET, I'd like to get Suave running on CoreClr on Linux.

This should make Suave on Linux worthwhile with or without CoreClr: https://github.com/SuaveIO/suave/pull/306.

@bluemmc the main problem (IMHO), the ANI creation part is moot as ANIs were removed from DNX. F# in DNX works just fine (see https://github.com/YoloDev/YoloDev.Dnx.FSharp/tree/master/sample). There is some manual trickery to get tooling working, but it's not really a problem. Just a slight annoyance upstart. Obviously, there is no CoreClr support yet, but I'll update with that as soon as it's landed.

Hi @Alxandr
How can we (both Microsoft and the F# community) help you move the YoloDev.Dnx work more into a mainstream role as the canonical F# + ASP.NET vNext solution for F#?
For example

Perhaps the work could move to http://github.com/fsprojects or https://github.com/aspnet or a neutral organization like a new http://github.com/fsdnx/?  (I'm not sure whether moving to https://github.com/aspnet is feasible but hat would really be ideal)
Rename it to "Dnx.FSharp" or "FSharp.Dnx" to make it "canonical"?
Bring on some additional contributors? e.g. we can ask on twitter.
Add a front-page design? e.g. something like Ionide

I can help with this if you'd like to move in this direction.

Maybe @davidfowl can comment on the https://github.com/aspnet question.

Highly doubt we're getting it into https://github.com/aspnet. As far as I understand, the ASP.NET team have more than enough work already. Even VB isn't yet supported officially in DNX (not that VB is more important than F# in any way, but given that VB uses Roslyn, adding support for it would be fairly easy compared to F#). This might be something worth investigating post v1 though.
@dsyme I'm not opposed to moving the repo anywhere, nor taking on contributions, but a few things needs to be understood first:

I made the code with the intention of getting F# code running in DNX first and foremost. I'd attempted previously to write the compiler bridge (hereby just called the compiler) in F#, bootstrapping it using another program I created for that very purpose, but because of volatile APIs, this became unfeasible, so I gave up on it. So, as the goal was getting things to work first and foremost, I wrote the new version (abandoning the previous one and doing a complete rewrite) in C#. More than that, I even started with the Roslyn compiler, practically mirroring their API for F#.
As you probably know, the code is written by me and me alone. I can not vouch for it's quality in any way. And there is negligible unit-testing in place (it just tests that an assembly written in F# can actually be loaded through DNX).
The main work needed to get this working better than it already is, isn't work in the DNX F# compiler, but in FSharp.Compiler.Service. Primarily in getting it compiling to memory only. I attempted to do that myself, as you are probably well aware, ran into problems, asked for help, and have heard nothing in about a year. Except that PPDBs might play into this. See https://github.com/fsharp/FSharp.Compiler.Service/pull/271 for more info. Again, in the interest of getting things to just work, I abandoned compiling to memory altogether, resigning myself to having to take the speed penalty of the compilation IO during startup.

These are at least the points I can make at the top of my head. Also note that if you want to transfer the compiler out somewhere, you need a nuget distribution channel (ie. a myget feed), and a ci that can run ~nightly (I use appveyor), because the APIs still break every now and again.

linking https://github.com/aspnet/Home/issues/982

Thanks for all the answers.
@Alxandr So as I understand your answers it is possible to get F# work with ASP.NET 5 but there is no official way to do it. There is only your own hackish approach which is not quality assured. Also there is no support for CoreClr yet which is the most interesting deployment target of ASP.NET 5 IMO (would like to use F# + ASP.NET on CoreClr to write microservices for non-windows targets).

First of all, it's not hackish. It's adding F# compiler support in the way
intended to add language support for other languages, using the same APIs
the C# one does (which just happens to be the default compiler).
Second, the code is all up on GitHub, so you're more than welcome to
quality assure it yourself if you want to. Or even contribute.
Otherwise your statements are correct. Nothing I can do about CoreCLR. It's
not supported by F# yet.
On Wed, Oct 14, 2015, 12:08 bluemmc<EMAIL_ADDRESS>wrote:

Thanks for all the answers.
@Alxandr https://github.com/Alxandr So as I understand your answers it
is possible to get F# work with ASP.NET 5 but there is no official way to
do it. There is only your own hackish approach which is not quality
assured. Also there is no support for CoreClr yet which is the most
interesting deployment target of ASP.NET 5 IMO (would like to use F# +
ASP.NET on CoreClr to write microservices for non-windows targets).
—
Reply to this email directly or view it on GitHub
https://github.com/Microsoft/visualfsharp/issues/682#issuecomment-147999922
.

--
Alxandr

To clarify, my suggestion is to use @Alxandr's work as a unified starting point for those who want to make F# + ASP.NET vNext work well together.  This would include both contributors at Microsoft and the broader community.
The F# community have a good history of getting things off the ground this way: for example the Visual F# Power Tools started as a way to bring various F# refactoring tools together.
There would be much to do, and @Alxandr has described the technical path forward well.  With CoreCLR support coming on line via @KevinRansom's work, I think we could do good things here.
Best
Don

Sure. @dsyme, just let me know if you want me to transfer the repository somewhere. Or you can obviously just fork it if you want to. Also, if there's any license problems or the likes, let me know.

Here is the new home: :)
https://github.com/fsprojects/fsharp-dnx

BTW: Have you all seen this "https://github.com/davidfowl/vNextLanguageSupport" which shows some F# support for the project types in vNext ?

Yes. And it's horribly outdated. The fsharp-dnx project builds on the same APIs (though the newer versions). The project you linked was a proof of concept made by Fowler like a year ago or so.

i am working to use https://github.com/fsprojects/fsharp-dnx in coreclr branch ( add .xproj with parallel solution ), i'll send a pr soon

See also "https://github.com/Microsoft/visualfsharp/issues/788" which raise two major issues that is outside the current fsharp-dnx scope:

Visual studio support.
Interoperability - solutions with mix of C# and F# projects.

Interoperability works. Just not tooling.
On Mon, Dec 14, 2015, 08:08 bluemmc<EMAIL_ADDRESS>wrote:

See also "#788 https://github.com/Microsoft/visualfsharp/issues/788"
which raise two major issues that is outside the current fsharp-dnx scope:

Visual studio support.
Interoperability - solutions with mix of C# and F# projects.

—
Reply to this email directly or view it on GitHub
https://github.com/Microsoft/visualfsharp/issues/682#issuecomment-164364642
.

--
Alxandr

Closing old discussion


Added Reports

:warning: Please install the  to ensure uploads and comments are reliably processed by Codecov.
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Files with missing lines
Coverage Δ

src/pid_controller.cpp
100.00% <ø> (ø)

The reports look good, merge approved


Gangwei/new ui

fixes #181
fixes #203
fixes #204
fixes #224
fixes #226
fixes #238
fixes #241
fixes #242

Codecov Report

Merging #271 (c522966) into master (4843600) will decrease coverage by 5.28%.
The diff coverage is 1.96%.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4843600...c522966. Read the comment docs.


Think about to fix the issues found by adapter checker

I am an automatic service that looks for possible errors in ioBroker and creates an issue for it. The link below leads directly to the test:
https://adapter-check.iobroker.in/?q=https://raw.githubusercontent.com/angelnu/ioBroker.chromecast

[ ] [E301] Tests on Travis-ci.org are broken. Please fix.
[ ] [E605] No actual year found in copyright. Please add "Copyright (c) 2019 [object Object]" or "Copyright (c) 20xx-2019 [object Object]" at the end of Readme
[ ] [E701] No actual year found in LICENSE. Please add "Copyright (c) 2019 [object Object]" or "Copyright (c) 20xx-2019 [object Object]" at start of LICENSE

Thanks,
your automatic adapter checker.
P.S.: There is a community in Github, which supports the maintenance and further development of adapters. There you will find many experienced developers who are always ready to assist anyone. New developers are always welcome there. For more informations visit: https://github.com/iobroker-community-adapters/info

Issues fixed

Thanks, that all bugs have been fixed.


Version for Jupyterlab 2.2

Hi is there a version for Jupyterlab < 3.0 available?
merci

Yes, 2.x is supported. See the older version of the README: https://github.com/deshaw/jupyterlab-execute-time/tree/81a3efa68c7ce9a8298a013ad7eea2982d08a4af#install
jupyter labextension install jupyterlab-execute-time

Yes, 2.x is supported. See the older version of the README: https://github.com/deshaw/jupyterlab-execute-time/tree/81a3efa68c7ce9a8298a013ad7eea2982d08a4af#install
jupyter labextension install jupyterlab-execute-time


Cannot find service to reset

The whole package is missed up,, it is not related to the example

@bdairy Hi,
I have removed the service in latest build for some flexibility.
Published a build with angular 6 upgrade in beta.
Check this stackblitz link to know the breaking changes.
Once testing complete then i will move it to master

@bdairy Now you can use template reference to control carousel in latest version. Thanks

Still don't know how to reset??


Clean up FAM roles

Describe the task
Following admin segregation tasks, cleanup FAM roles and role assignments that have been moved to application admin table
Acceptance Criteria:

[x] Remove the FAM roles from fam_role table
[x] Remove associated role assignments fam-user_role_xref table

Additional context

Separated the task from #888
Or here

Verified with AWS DEV environment db:

fam_role table does not contain FAM roles:

users with application admin have been removed:

application admin management table looks correct. Two records (SILVA_DEV/SILVA_TEST associated with user 15/2) are new.
(The timestamp on date looks correct, but time portion using flyway is always 00:00:00 I think)

verified in test and prod


Test absolute path migrations

Test the following (and maybe more)

Refreshing of existing workflows, migrated with the new paths
launching old workflows both before and after refresh (with cwltool pointing at TRS)

┆Issue is synchronized with this Jira Story
┆Issue Type: Story
┆Fix Versions: Dockstore 1.6
┆Sprint: Seabright Sprint 6 Ferry
┆Issue Number: DOCK-581

existing workflows
do they work 1) before refresh 2) after refresh in the GUI
same thing for launching via CLI
pick workflows that look like they have an odd path structure

Watch out for #2255

Putting my findings into this comment.
-NF core workflows seem to work with just the basic migrations, refresh not needed

Tooltester runs everything fine as expected (/var/cwl/spool problems still present from before)

Might be worth verifying the new releases that have been made, ping @junjun-zhang if you have difficulty identifying appropriate versions. I think all pcawg workflows minus bwa-mem should have fixed versions for the /var/cwl/spool issue

@garyluu oh I see, testing for pcawg workflows can be a new 1.6.X ticket if you're comfortable with the new path code in terms of before/after refresh for existing workflows

Not sure if relevant but...

Shows paths with ../ in it when my repo looks like:
https://github.com/garyluu/one-workflow-many-ways/tree/master/cwl

Looks like it, please find out how widespread the issue is and whether it affects download/execution

Affects download and execution

after/before refresh?
can you tell which of the absolute path commits caused this issue?

before refresh, absolute path looks fine in DB though

For Monday, newest issue boils down to this guess being poor
https://github.com/ga4gh/dockstore/blob/develop/dockstore-webservice/src/main/resources/migrations.1.6.0.xml#L343
And breaking places that depend on it being correct like https://github.com/ga4gh/dockstore/blob/develop/dockstore-webservice/src/main/java/io/dockstore/webservice/helpers/EntryVersionHelper.java#L341 and https://github.com/ga4gh/dockstore/blob/develop/dockstore-webservice/src/main/java/io/swagger/api/impl/ToolsApiServiceImpl.java#L574
Probably https://github.com/ga4gh/dockstore/blob/develop/dockstore-webservice/src/main/java/io/swagger/api/impl/ToolsApiServiceImpl.java#L716 too

Options

Don't guess absolute path, but all code that uses absolute paths now need to work out absolute path if not present
Calculate absolute paths correctly during migration
Refresh workflows without absolute paths to get absolute paths

I added myself as another user of the workflow (user_entry table).  Refreshed the workflow (http://<IP_ADDRESS>.nip.io:4200/my-workflows/github.com/HumanCellAtlas/skylab/HCA_SmartSeq2). It still has the same problem.

@garyluu mentioned that refresh doesn't seem to be working properly with workflows in this state

Last issue seems fixed with https://github.com/ga4gh/dockstore/pull/2334/commits/ed504a999bf20b7bc3c1c71e13d9ee51ac18e323

Reopen with more targeted issues if need be


Sass files not correctly compiled with new ESBuild

Which @angular/* package(s) are the source of the bug?
compiler-cli
Is this a regression?
Yes
Description
When Angular now compiles with the ESBuild option (using Angular 16), sass files no longer import external resources (using the url) correctly.
Essentially, behavior is such that if a Sass file (let's call it module A) imports another sass file (let's call it module B), and module B lives in a different directory than Module A, and Module B uses a url to point to a relative file (like a font file), when Sass compiles everything into a single Sass file, the url that's used from Module B remains the same (which is relative to the original Module B location), resulting in errors around resolving file locations (because the compiled file doesn't have the same file location as the original).
Original behavior didn't care about this, and the compiled output correctly brought linked files up and changed the url paths.
While ESBuild is called a "drop-in" replacement, this needs to be resolved.
Please provide a link to a minimal reproduction of the bug
https://github.com/AStoker/esbuild-font-import
Please provide the exception or error you saw
X [ERROR] Could not resolve "../webfonts/ShadowsIntoLight-Regular.ttf" [plugin angular-css-resource]

    src/styles.scss:6:11:
      6 │   src: url("../webfonts/ShadowsIntoLight-Regular.ttf") format("true...
        ╵            ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Please provide the environment you discovered this bug in (run ng version)
Angular CLI: 16.0.1
Node: 18.15.0
Package Manager: yarn 1.22.19
OS: win32 x64

Angular: 16.0.1
... animations, cli, common, compiler, compiler-cli, core, forms
... platform-browser, platform-browser-dynamic, router

Package                         Version
---------------------------------------------------------
@angular-devkit/architect       0.1600.1
@angular-devkit/build-angular   16.0.1
@angular-devkit/core            16.0.1
@angular-devkit/schematics      16.0.1
@schematics/angular             16.0.1
rxjs                            7.8.1
typescript                      5.0.4

Anything else?
No response

Please see the following comment in a related issue: https://github.com/angular/angular-cli/issues/24470#issuecomment-1366010366
In the specific example within the reproduction, the following code from src/app/foo/blar/imports.scss will also build (and correctly resolve the imported file's relative path):
@font-face {
  font-family: 'Shadows into light';
  font-style: normal;
  font-weight: 400;
  src: url('../webfonts/ShadowsIntoLight-Regular.ttf') format('truetype');
}

Not clear about what you're saying. Are you saying that the repo builds fine for you? With the es-build option enabled? It definitely isn't on my end. If you were to just compile that specific file, sure, it would work. But the fact that it's being imported from a file that exists in a different directory, and that file is being imported from the root, is the reason the url's are all messed up.
But more than that, looking at that linked comment, it's not an acceptable solution unfortunately. First, not every SASS library has a variable that can be set to change links to things like font files. And secondly, if you are able to set the path for those font files, they don't get hoisted, and the resulting SCSS file simply tries to reference files directly inside the node_modules folder, which isn't (and shouldn't) be deployed.

If the code provided in the comment above is used in place of the current file's content, the application should build successfully and the referenced font file should be resolved and provided in the output.
Relative paths directly specified within the Sass files will be rebased based on the imported location.
The reproduction in its original form happens to work with Webpack due to some expensive build time processing and Webpack-specific loader source map manipulation (even when source maps are disabled).  The reproduction also does not work with other bundlers such as Vite.
With either of the two options provided in the referenced comment, the font-awesome package's font files should be processed by the build system and available in the output as expected. With the bare specifier being the preferred option as it is only requires a single statement and avoids expensive and otherwise unneeded Sass preprocessing.
If neither of the options work within a build for your project, please let us know.

Closing as per above explanation. If the problem persists please file a new issue.


Allow using odo inside a firewall

/kind bug

What versions of software are you using?
Operating System:
Output of odo version:
How did you run odo exactly?
Actual behavior
Expected behavior
Any logs, error output, etc?

I have aws account to start a cluster however setting up cluster behind a firewall could be a challenge.
Firewall prereq- https://docs.openshift.com/container-platform/4.5/installing/install_config/configuring-firewall.html

Copy and pasting @kadel comment from bugzila
Use of registry.access.redhat.com is intentional.
Odo doesn't use registry.redhat.io because this registry requires authentication and we want to make sure that the
same odo binary can be used on OpenShift and also on Kubernetes by users without Red Hat account.

Not sure if it makes sense to update OCP documentation to add Firewall rule for registry.access.redhat.com if
 nothing else is expected to use this registry.

But it might be good to add something like "In case you plan to use odo with your cluster whitelist also
 registry.access.redhat.com" to https://docs.openshift.com/container-platform/4.5/installing/install_config/configuring-firewall.html

@girishramnani What is the ask in the issue ?
To reproduce the issue does not add value as this is expected. So do you want to verify odo functionality after adding the registry.access.redhat.com to the firewall whitelist ?

I have pinged the original reporter in bugzila to check it form their end with the suggestion - https://github.com/openshift/odo/issues/3824#issuecomment-683707339

Copy and pasting @kadel comment from bugzila
Use of registry.access.redhat.com is intentional.
Odo doesn't use registry.redhat.io because this registry requires authentication and we want to make sure that the
same odo binary can be used on OpenShift and also on Kubernetes by users without Red Hat account.

Not sure if it makes sense to update OCP documentation to add Firewall rule for registry.access.redhat.com if
 nothing else is expected to use this registry.

But it might be good to add something like "In case you plan to use odo with your cluster whitelist also
 registry.access.redhat.com" to https://docs.openshift.com/container-platform/4.5/installing/install_config/configuring-firewall.html

As per @kadel comment I can see that its a documentation changes needs to be done. And ofcourse as per the above thread I can see we have to verify the suggested change in our test environment as well. So changing the label brom bug to area testing and need doc.
/remove bug
/area testing
/documentation

I have gone through some reference video on how to configure firewall for aws account and whitelisting part as per the comment https://github.com/openshift/odo/issues/3824#issuecomment-690960220 but could not try it.
So i am keeping it for next sprint.

The BZ corresponding to this issue has been inactive since over 2 months. And so is this issue. Is this even relevant? @prietyc123 @girishramnani

@dharmit the bugzilla can be closed: https://github.com/openshift/openshift-docs/pull/27092

/close
https://bugzilla.redhat.com/show_bug.cgi?id=1871160#c7


make cartopy and geopandas louder if not there

This should fix the issue you raised in #35

I appreciate the sentiment, but this doesn't have any impact on the behaviour on my PC...
should I go ahead and merge anyway, assuming that the problems on my machine are triggered by other, more fundamental issues?

Well, we have a few options. One it to figure out why this isn't working as expected on your machine. A second is to make cartopy and geopandas hard dependencies.  Finally, I can reimplement this in a less "elegant" way. I'd like to go with option one if possible. Wait to merge until we can both sit down, if that's ok.

Rebased. I also checked behavior on my side, and it indeed fails without geopandas installed with an import error saying "Requires geopandas".


please update int(value) to int(Decimal(value)) to solve invalid literal error

some Vector tools generated dbc definition like this:

BA_DEF_ SG_ "GenSigStartValue" INT -9.22337203685478E+018 1.84467440737096E+019;

so the code below can raise:

ValueError: invalid literal for int() with base 10: '1.84467440737096E+019'

https://github.com/eerimoq/cantools/blob/6383c883f3faa1661dd97cc83b721de9508012ed/cantools/database/can/formats/dbc.py#L1339-L1343
the same problem happened in another project: https://github.com/ebroecker/canmatrix/issues/168
and the solution might be like:
       if definition.type_name in ['INT', 'HEX']:             value = int(Decimal(value))
I tested it in my dbc and it worked. I hope this may help you. ;-)

Fixed in 32.20.1.


Modify dashboard  status bar to display user progress dynamically

Signed up, joined team, submitted project, etc.

To be implemented as part of #28

This will be implemented on the dashboard, rather than the topbar

Based on firestore database: assign integers to statuses & progress percentages, get integer from database

This is not working. It hangs on 0%.


Keep a record of how many times each sound effect is played

This issue is for a: (mark with an x)

[ ] bug report -> please search issues before submitting
[x] feature request
[ ] documentation issue or request
[ ] regression (a behavior that used to work and stopped in a new release)

Expected/desired behavior

use some kind of database to keep track of the count
send a message when a user activates a sound effect that's never been played before
send a message when a user activates a sound effect and hits a certain count milestone (such as played 100 times)

As suggested by DaymeTV on Twitch, keep track of how many times incorrect sound effects are used.
Maybe when a sound effect command is misspelled it automatically plays a different sound effect in response (like an error horn or something)

@clarkio - Looking at this. @MichaelJolley is using FaunaDB for his awesum.io app for DB storage. That may be an option here or something like CosmosDB if you want to keep it all in Azure.

Link to Fauna to check out further: https://fauna.com/

I'll give a 👍 for FaunaDB.  @clarkio knows I'm very pro-Azure, and actually started with CosmosDB, but its pricing model is not very welcoming for smaller projects.  Same can be done in FaunaDB for free and it was very easy to get rolling.

Created a FaunaDB account to start working on this. This can be expanded to include the other commands to keep track of how many times they are used as well as which !bulb color gets used the most, which was referenced in Issue #92 and it can also be used for Issue #93 .


fix typo words in pod describe.

fix typo words in pod describe.

Hi @yanggangtony, could you please only include one language in a single PR? For example, you can open a PR only including en language firstly.

Hi @yanggangtony, could you please only include one language in a single PR? For example, you can open a PR only including en language firstly.

Thanks for suggestion.
Will rebased.

/remove-language zh

/retitle Fix typo words in pod describe

/approve

Thanks


Feat: React Native Skia Confetti, LTS React Native & LTS Eslint

There has been feedback regarding performance: https://github.com/marcuzgabriel/react-native-reanimated-confetti/issues/2. React Native Skia is the best solution I have found. Additionally, it is now possible to batch the render process and activate it manually. This allows confetti to be rendered in a 'hidden' mode and then displayed based on user interaction.

:tada: This PR is included in version 1.3.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Don't depend on "npm version" for NPMPublishTask

Commit-message for tag needs to include version-number, not just "Bumped version number."

Fixed and in master.


[WIP] Structuring integration test planning

Taking a shot at #333.
This is a stab at a structure for planning / documenting the integration (e2e) tests.  Just started for init.
Start by organizing test_harness directories by command options, in this case:

init/basic
init/skip-tools
init/gopath
init/special-cases

Under each of those, maintain a README.md file with a table describing the cases - setup and expectations.  The tables serve as planning and description of cases for end users.
This is just a beginning of the implementation to show the pattern as well as dive a little deeper on init/basic, but until the new specs finalize, we really can't implement too much.  Ideally, the test cases will fall out of the new specs.
Comments welcome (and encouraged).

Note that the "Passing" column requires some explanation.  Travis wil pass the tests now, as the cases have been -updated with the results, but those results may not match what is expected in the table.  A test is considered to truly pass when the table expected results, the final files, and Travis all line up with a Pass.

@sdboyer any comment here?  If it is too early for this stuff, happy to pull it out.

Okay, shutting down for now


Update AMP PHP Library Integration

Feature Description
Tracking ticket for once we need to update our usage of the AMP PHP library.
Alternatives Considered

Additional Context

Do not alter or remove anything below. The following sections will be managed by moderators only.
Acceptance Criteria

Implementation Brief

There's now https://packagist.org/packages/ampproject/amp-toolbox in the works

I think this is blocked as long as there's no AMP plugin release which also uses that library.


[dashboard]filter mapping modal cosmetic issues

checkbox and label alignment
line overflow
"Collapse all" and Search bar overlap - move search bar to separate line maybe?
section divider
button position - move both to the bottom right, change "CLOSE" to "CANCEL"

tested, a bit too wide but is looking neat! thanks for the fix @kgabryje !!

Regarding the width, that's how it was before - 80% of screen width. Do you think we should make it a bit narrower?

i think we are good for now, we are rolling out a new native configuration modal soon:) also wide modal can be good for long titles.


Support for loading a certain font face from a font file.

TTC file is very important for CJK fonts. For example, Android includes .ttc font files for CJK characters due to the fact that Chinese/Japanese/Korean share a lot of characters. Without a .ttc file, we need four files (each file takes at least 15 MB) to support all of Japanese/Chinese/Korean characters. The Noto-CJK TTC font file included in Android only takes ~25 MB.
Currently, the stb implementation in NanoVG does not support TTC at all as mentioned in #554. And the FreeType implementation only loads the first font face in the TTC. This isn't ideal as the same character may look different in different languages.

Without TTC support, we need to bundle 4 font files to cover all CJK characters, and we can't use the .ttc file included in Android system already. That would make the app super heavy.

@memononen Thanks. I just updated the code. 👍

Thanks or the improvement!

Thanks for merging. Cheers! :)


refactor doc store

refactor cache
expose cache statistics
remove unnecessary arc
unduplicate code

Codecov Report

Merging #1372 (048d6e3) into main (cbd06ab) will decrease coverage by 0.01%.
The diff coverage is 89.70%.

@@            Coverage Diff             @@
##             main    #1372      +/-   ##
==========================================
- Coverage   94.29%   94.28%   -0.02%
==========================================
  Files         234      234
  Lines       42769    42814      +45
==========================================
+ Hits        40331    40369      +38
- Misses       2438     2445       +7

Impacted Files
Coverage Δ

src/store/reader.rs
88.79% <89.70%> (+7.54%)
:arrow_up:

src/query/phrase_query/phrase_scorer.rs
88.54% <0.00%> (-7.77%)
:arrow_down:

src/fastfield/serializer/mod.rs
92.02% <0.00%> (+0.72%)
:arrow_up:

src/indexer/segment_serializer.rs
100.00% <0.00%> (+1.92%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cbd06ab...048d6e3. Read the comment docs.


http2 unconditionally enabled with shared libcurl, ignoring http2 feature

When compiling isahc without the http2 feature and using the system-wide libcurl, HTTP/2 protocol support is enabled anyway, disregarding the feature configuration.
This is a problem because some websites (1000 out of the top million) redirect to HTTP/2 and then fail (at least under libcurl), but work fine if the client doesn't support HTTP/2.
Tested on commit 3a815fe3cb6c2e142cc23731eafde998b9a3cb54. Please be aware of https://github.com/alexcrichton/curl-rust/issues/316 which may complicate testing.

Could you elaborate on this a bit more? I'm not entirely sure what the problem is. Particularly with

redirect to HTTP/2 and then fail (at least under libcurl), but work fine if the client doesn't support HTTP/2.

By redirect do you mean an HTTP/2 upgrade? Perhaps an example of a failed request would help me understand here.

When compiling isahc without the http2 feature and using the system-wide libcurl, HTTP/2 protocol support is enabled anyway, disregarding the feature configuration.

That is correct, there are a number of features that have no effect when using the system-wide libcurl, because we don't have much control over it. Some of them, like http2, we could tweak runtime behavior based on it that would give similar results, but I would be concerned about increasing complexity of the possible behaviors.
Current behavior when using system-wide libcurl is that newer libcurl versions will default to preferring HTTP/2 if supported, older versions default to HTTP/1.1 (even if HTTP/2 support is enabled), and if HTTP/2 support is not available it is never asked for. It all depends at runtime on which version of libcurl is used and how it was compiled.

By redirect do you mean an HTTP/2 upgrade? Perhaps an example of a failed request would help me understand here.

Here's one example of a website that errors out on HTTP2:
$ curl --http2 iomega.com -I
HTTP/1.1 101 Switching Protocols
connection: Upgrade
upgrade: h2c

curl: (92) HTTP/2 stream 1 was not closed cleanly: PROTOCOL_ERROR (err 1)
$ curl iomega.com -I
HTTP/1.1 429 Too Many Requests
cache-control: max-age=0, private, must-revalidate
connection: close
content-length: 17
date: Sat, 04 Jan 2020 18:56:14 GMT
server: nginx
set-cookie: sid=e1d6f644-2f23-11ea-ae09-447ada9a2f3c; path=/; domain=.iomega.com; expires=Thu, 22 Jan 2088 22:10:21 GMT; max-age=2147483647; HttpOnly

There is just over 1000 of those among the top million websites. I can compile a full list if you're interested.

That is correct, there are a number of features that have no effect when using the system-wide libcurl, because we don't have much control over it.

In that case the name of the feature is misleading. It should be static-curl-http2 or similar.

Ah, I think I understand what you are asking now. Basically the problem is that there are some websites which claim to support HTTP/2, and so we attempt to upgrade to it. But it implements HTTP/2 incorrectly and produces the error. So ultimately, regardless of whether HTTP/2 is supported (which is what the compile-time features might do) you would like to not attempt to use HTTP/2 at all.
If my assessment is correct, then the Isahc feature you are looking for is called VersionNegotiation. Here's a tiny but complete example that would work for such a site (like the one you provided):
use isahc::{
    config::VersionNegotiation,
    prelude::*,
};

fn main() -> Result<(), isahc::Error> {
    let mut response = Request::get("http://iomega.com")
        .version_negotiation(VersionNegotiation::http11())
        .body(())?
        .send()?;

    println!("Status: {}", response.status());
    println!("Headers: {:?}", response.headers());
    println!("{}", response.text()?);

    Ok(())
}

Thanks for the code snippet, this looks like it should do the trick!
Could you consider creating an alias static-curl-http2 for the http2 feature and referring to the alias in the docs, to avoid such confusion in the future?

I'll definitely work on significantly improving the documentation for that crate feature. I'm not convinced that this is enough to warrant moving towards changing the feature's name though.

Frankly when selecting features I look at feature names and assume them to be self-explanatory instead of reading the docs. Although a comment in Cargo.toml would definitely help.
Changing the feature's name would be a breaking change, so I suggest simply making a more readable alias for it.

I created #148 to make sure that the docs get improved, and thank you for taking the time to fill out this issue! Specifically I want to make it easy to understand the distinction between compile-time support and runtime selection. Feature flags (even if they behaved how you expected) are not the right place to select HTTP versions. What if you need to talk to more than one server, and they both require different choices of versions? Or multipe crates depend on Isahc and end up in the same binary, but need to use different versions?

Changing the feature's name would be a breaking change, so I suggest simply making a more readable alias for it.

An alias seems like a weird thing to do unless you intend to rename the feature in the next breaking release (though you wouldn't cut a breaking version for that change alone).

It also may be worth considering that the http2 feature upstream is a little more nuanced than simply toggling HTTP/2 support when static curl is enabled. For example, when http2 enabled, even if static-curl is not requested and a system libcurl is available, if the system libcurl does not have http2 enabled, then we actually use a bundled libcurl anyway (so that HTTP/2 can be enabled since we control its compilation).

Closing this question out. Feel free to reach out anytime if you have any more questions or comments!


Fix push example

Hmm, this shouldn't have died on Appveyor.

It's a little worrisome that 1312 died but 1313 didn't.
It seems like we might be missing something cleaning up on windows again @tbranyen @mattyclarkson.

Well done for clearing up the example. I was looking through the generated code and it looks like it could do with an audit. I tried putting valgrind and electricfence around them but it looks like the way node runs stuff they still didn't pick things up. I can look into putting -fsantize=address onto the debug builds so that we get a stack trace if anything references out of scope of the allocated memory. The other thing that would be useful is -fsanitize=thread as that will catch any threading errors due to the way the generated code is using libuv?
Unfortunately the thread and address sanitizers cannot be compiled in together so we'd have to have two build variants. I'd have to look into if that is even supported with node generate and gyp. It'd be great to have a Release, Debug, Address and Thread that instruments the code in certain ways.

That's a good idea. I think that would be great for post 0.3.0 release. I'm going to merge this in since it's unrelated.


The progressBar is missing on 0.5.4 version

The exception I got was AAPT: error: resource android:attr/android:progressBarStyle not found.. I open the source in progress_dialog.xml of the library
            style="?android:attr/android:progressBarStyle" />

This line seems to be the problem.
@hebertialmeida @kjantzer @mahavir155 @thestr4ng3r @n0m0r3pa1n
Supposedly,
  <ProgressBar
            android:id="@+id/loading"
            android:layout_width="wrap_content"
            android:layout_height="wrap_content"
            style="?android:attr/progressBarStyle" />

I have same issue

I have same issue

Sadly the Dev is not actively looking to fix the bug

Did you solve or found other lib? @johnmelodyme

Did you solve or found other lib? @johnmelodyme

I solved it by git clone the source and fix the code myself as I mentioned the solution above


Front end report details download should not include blob folder structure

With the changes in #1416, the blobs are not stored with a folder hierarchy that is reflected in the blob name.  Blobs used to be stored in the root all together, but now they have two levels of folders like ready/Faz-phd.elr-prod/Faz-covid-19-7edf57cf-a6d4-4a3f-98bb-300a2f9a0018-20210714141108.  The problem is that when a user downloads one of the newer blobs uploaded then they will get a filename of ready%2Faz-phd.elr-prod%2Faz-covid-19-7edf57cf-a6d4-4a3f-98bb-300a2f9a0018-20210714141108 instead of just the true filename.  Note that, for a few weeks, older files in the blob store will still be in the root, so you must support both with and without the folder structure.
Acceptance criteria:

The filename of a downloaded report from the front end only reflects the filename in the blob store without the folder names.
For blobs stored before #1416, the filename of a downloaded report from the front end reflects the filename in the blob store.

Current body_url looks like this:   http://blah-blah-blah/reports/hhsprotect-covid-19-dd8d3e53-cba0-4493-915b-77add89b5c29-20210712135017.csv
Seems like this is just a case of grabbing everything after the last / in all cases, both old and new folder structures?

OBE.  Added the changes to #1416

@carlosfelix2 , I think there's still an issue:   the name as it appears on the download website is correct, however if you actually download the file, the downloaded file's name is (for example) ready%2Fpima-az-phd.elr%2Fpima-az-covid-19-9a89c2cb-d1d3-46df-ac90-bcb7f0a4918f-20210719113546.csv
It should be pima-az-covid-19-9a89c2cb-d1d3-46df-ac90-bcb7f0a4918f-20210719113546.csv


GET /_next/webpack-hmr 404

I ran npx serve .   at .../aws_sumerian/packages/amazon-sumerian-hosts-three
I receive error:
 HTTP  10/11/2023 11:06:51 AM ::1 Returned 404 in 0 ms
 HTTP  10/11/2023 11:06:51 AM ::1 GET /_next/webpack-hmr

I did the AWS-Infrastructure-Setup.md step, where I added: const cognitoIdentityPoolId = '....';
module.exports = cognitoIdentityPoolId; in .../aws_sumerian/demo-credentials.js

Hello @flckv, you may have better luck trying to run the version of amazon-sumerian-hosts where I've removed the build, in this branch:
https://github.com/aws-samples/amazon-sumerian-hosts/pull/183
You can clone that fork, then you can run this, and it will simply work without a build:
npm install
npx serve ./any/folder

Additionally, if you look at the package.json script there, you'll see start-three, which does what you did (but using five-server package instead of the serve package).
All code in that branch is plain JavaScript, requires no build at all (unless you want to produce TypeScript declaration files for the Babylon lib, in which case the npm run build script will generate .d.ts file, but it will not build any JS)


WIP - Travis-CI pipeline optimization: multi-stages builds and artifacts caching

!! This is work in progress, please do not merge yet !!
For the last days, I'm been working on improving the DefectDojo build pipeline on Travis-CI, with the idea of the workflow I illustrated in defectdojo_travis-ci-pipeline.svg.
It has now reached a sufficient state to allow demonstration, as for example in ppiotr3k/django-DefectDojo - Build #95, which has the workflow of a build triggered by a merge into 'dev' or 'master'.
On a pull request, promote and deploy are not executed, and thus the builder Docker image is not cached and kept after build images stage, as for example in ppiotr3k/django-DefectDojo - Build #90, which has the workflow of a build triggered by a PR - note the promote and deploy stages are only visible for debug.
Using artifacts caching, each job in integration tests stage saves 5-6 minutes, compared to when rebuilding the images at each stage and for each job. This currently saves 30-36 minutes on the build total time. The more stages/jobs need the images, the more time is saved. Reusing the builder saves also an extra 3-5 minutes in the build images stage.
Also, regrouping prechecks like flake8 and Snyk in a separate stage run at first allows to very rapidly fail and provide feedback, sparing the Travis-CI resources needed to build the images and run integrations tests. In the same spirit, adding in a future a unit tests stage, before the integration tests one, should be considered.
As I won't be able to continue on this for the next days, I just wanted to inform about this work, and the remaining actions I have in mind.
Please don't hesitate to comment and share your thoughts! :smiley:
(Note: I recommend you don't fork my travis branch, as I'm extensively using forced pushes right now)
Remaining actions:

[X] fix problem with docker login and --password, to demonstrate complete cycle and speed improvements added by --cache-from
[ ] dispatch all tasks from existing pipeline to new pipeline, to  completely compare run times with existing pipeline
[ ] ensure disabling caching in the build logic doesn't impact build tasks
[ ] add do not touch DB migrations files check, as discussed in #1112
[ ] add do not PR to 'django-DefectDojo:master', unless it is from 'django-DefectDojo:dev' check
[ ] finish implementing cache_clean properly, otherwise concurrent builds will fail
[ ] update README.md in travis folder

Corrected Build # and link to 95, previously provided link was to a build executed with wrong ENV parameters, thus failing...

@hendrikhalkow, I'm thinking of deleting or fixing this command from the Travis-CI scripts: https://github.com/DefectDojo/django-DefectDojo/blob/6954b9252c024183f7c0f7c16727b103c4eb5941/travis/before-script.sh#L16
Rationale: DD_HOST is never set, as can be seen in this build for example, and everything seems to work well without it since 2+ months.
:question:  Do you see use cases where having this resolution working would be required?

@hendrikhalkow I added some additional exit-value checks to the minikube/helm/kubectl sections of Travis-CI scripts. And I would also like to add automated checks where visual inspection of Travis-CI build logs seems to be required at the moment.
:question: Could you please advise on what must be present in the outputs of the following calls, so I can add the relevant checks:
https://github.com/DefectDojo/django-DefectDojo/blob/6954b9252c024183f7c0f7c16727b103c4eb5941/travis/script.sh#L34
https://github.com/DefectDojo/django-DefectDojo/blob/6954b9252c024183f7c0f7c16727b103c4eb5941/travis/script.sh#L92
https://github.com/DefectDojo/django-DefectDojo/blob/6954b9252c024183f7c0f7c16727b103c4eb5941/travis/script.sh#L95
https://github.com/DefectDojo/django-DefectDojo/blob/6954b9252c024183f7c0f7c16727b103c4eb5941/travis/script.sh#L114-L117
:question: Also, for the last one: my Kubernetes operational experience is modest at the moment, but can a helm delete --purge call actually fail? I'm wondering of having this operation in Travis-CI build scripts, unless something specific is performed when a DefectDojo pod is going to be shutdown; I quickly checked for PreStop hooks/handlers and have no results. Please advise.


Support for RF capture/playback on RM PRO devices

Hi,
Firstly thank you for your great efforts.
Secondly, does your code support the RF features of the RM Pro devices?

Hi, I own a RM 3 pro plus and I am not able to record RF codes using the broadlink-mqtt script.
Recording/replaying IR codes works like a charm, files are being created and reused for each and every recorded remote button press.
After executing a regular "record" mqtt command, when pressing any key on a RF remote control, nothing happens, the Broadlink device does not record anything.
When using the Google Play Broadlink app ("ihc"), you can record RF signals in two steps:

long press the desired button on the RF remote - this is to allow the device to learn the RF frequency
short press the same button for capturing the RF code.

After steps 1 and 2 are performed in the Broadlink ihc app, the command is then available and functional.
Any advice on how to learn RF codes with broadlink-mqtt? Is this function available? If not, will it be?
Thanks a lot

Sorry, format of RF packet doesn't matter
I've rechecked sources of broadlink_cli utility provided by python-broadlink library and see that there is no difference between IR and RF learning as well

OK, thanks.
I've revisited the app and it seems in order to learn RF codes, you need to perform two steps in sequence:

From the two shown options "Learn" or "Sweep frequencies", you must select the 2nd one and then long press on the RF remote button you wish to learn;
Finally short press the same button to finally learn the button.

If the Sweep frequencies function is not performed, the Broadlink device does NOT learn the RF code.
This means that most probably there should be another mqtt topic/command which should put the Broadlink device into "Sweep frequencies" mode.
I've tested with a 433 MHz RF remote Silvercrest (EAN 60494) which controls (on/off) 4 RF sockets individually or grouped.
Meanwhile I found another python script (Broadlink-e-control-db-dump) which decodes a .db file from the e-Control android app and saves all learnt codes from the app into text files.
Thank you,
Cristian

I found similar information for the parent python-broadlink library:
To receive RF commands, “sweep frequency” command is required. However, it is currently not implemented in this library. Therefore, you can only receive IR commands but not RF commands.
There’s a workout for this. You can receive the RF data from a third party like RMBridge and hook the data to the send command.
The string RF data is just a bunch of HEX code which you can deal with b”173e2748290” to convert to byte array.
References:
https://github.com/mjg59/python-broadlink/issues/87
https://github.com/mjg59/python-broadlink/issues/198


[fix] typo on file-system-utilities.html.md

Hi. I love to use dry-rb gems!
I found file is undefined on this page.
https://dry-rb.org/gems/dry-files/0.1/file-system-utilities/
I think this is typo.
This is my first time to contribute to OSS, So I am sorry if I'm being rude or something wrong.
Thank you!

This is my first time to contribute to OSS, So I am sorry if I'm being rude or something wrong.
Thank you!

You're being absolutely perfect and helpful. Thank you for fixing this and congrats on your very first OSS contribution 🙂


Change quotes to curlies and a few other text changes

We could use https://github.com/silvenon/remark-smartypants to do this automatically

Good find, I’ll add that tonight.


Could org.springframework.security.oauth:spring-security-oauth:2.5.3.BUILD-SNAPSHOT drop off redundant dependencies?

Hi! I found the pom file of project org.springframework.security.oauth:spring-security-oauth:2.5.3.BUILD-SNAPSHOT introduced 27 dependencies. However, among them, 1 libraries (3%) are not used by your project. I list the redundant dependencies below (labelled as red ones in the figure):
Redundant dependencies
aopalliance:aopalliance:jar:1.0:compile

Removing the redundant dependencies can reduce the size of project and prevent potential dependency conflict issues (i.e., multiple versions of the same library). More importantly, one of the redundant dependencies aopalliance:aopalliance:jar:1.0:compile induced dependency conflict in the dependency graph. As such, I suggest a refactoring operation for org.springframework.security.oauth:spring-security-oauth:2.5.3.BUILD-SNAPSHOT’s pom file.
The attached PR helps resolve the reported problem. It is safe to remove the unused libraries (we considered Java reflection relations when analyzing the dependencies). These changes have passed org.springframework.security.oauth:spring-security-oauth:2.5.3.BUILD-SNAPSHOT’s maven tests.
Best regards

@Celebrate-future This project has reached it's end-of-life. Please see latest announcement.


Task/01 setup

[ ]  Mentor is added to pr
[ ]  AC copied to pr description
[ ]  link to deployed version added to pr
[ ]  About block (text and image) added to the main page
[ ]  On the widths 390px and 1280px, the site layout corresponds to the design


Stop Spacings Heatmaps

Is your feature request related to a problem? Please describe.
It is helpful to visualize stop spacings that are narrower or wider than the average stop spacings of about 350-400m.
Describe the solution you'd like
Add a plotting function to create a heatmap with bins
Additional context
Can make it interactive with Folium. Diverging colormap schemes are helpful to highlight both extremes of spacings

Added these features in #8


EntityOwnerPicker and OwnershipCard url filter issue with more than 21 owners

Expected Behavior
When I click on the link generated by OwnershipCard with more than 21 owners it should open a catalog page where the EntityOwnerPicker has all the owners selected and the entities filtered.
Actual Behavior
Error: Error in catalog
Message
Minified React error #31; visit https://reactjs.org/docs/error-decoder.html?invariant=31&args[]=...

Steps to Reproduce

Open a catalog page with an EntityOwnerPicker filter.
Select 22 owners, the page url will update accordingly.
Use the generated url to access the page (Note: the same link would have been generated by OwnershipCard).

Context
The problem is due to the qs library that is used to parse the link inside EntityOwnerPicker using EntityListProvider. The parse method has arrayLimit default to 20, meaning that any array with index >20 (i.e. more than 21 elements) is parsed as an object instead of an array breaking the rendering code of the EntityOwnerPicker.
Since this is due to qs.stringify method adding index to array elements, a solution we find is to add the option arrayFormat:'repeat' when using stringify both in OwnershipCard and EntityListProvider link generation. This way the owners array is created without indexes and does not hit the 20 index limit.

Output of yarn backstage-cli info:

OS:   Darwin 21.3.0 - darwin/x64
node: v14.19.0
yarn: 1.22.17
cli:  0.14.0 (installed)

Dependencies:
  @backstage/app-defaults                                  0.1.8
  @backstage/backend-common                                0.10.9
  @backstage/backend-tasks                                 0.1.8
  @backstage/catalog-client                                0.7.1
  @backstage/catalog-model                                 0.10.1, 0.9.10
  @backstage/cli-common                                    0.1.8
  @backstage/cli                                           0.14.0
  @backstage/config-loader                                 0.9.5
  @backstage/config                                        0.1.15
  @backstage/core-app-api                                  0.5.3
  @backstage/core-components                               0.8.9
  @backstage/core-plugin-api                               0.6.1
  @backstage/dev-utils                                     0.2.22
  @backstage/errors                                        0.2.2
  @backstage/integration-react                             0.1.22
  @backstage/integration                                   0.7.4
  @backstage/plugin-api-docs                               0.7.3
  @backstage/plugin-app-backend                            0.3.26
  @backstage/plugin-auth-backend                           0.10.2
  @backstage/plugin-auth-node                              0.1.2
  @backstage/plugin-catalog-backend                        0.21.5
  @backstage/plugin-catalog-common                         0.1.4
  @backstage/plugin-catalog-import                         0.8.2
  @backstage/plugin-catalog-react                          0.6.15
  @backstage/plugin-catalog                                0.8.0
  @backstage/plugin-explore-react                          0.0.12
  @backstage/plugin-explore                                0.3.30
  @backstage/plugin-org                                    0.4.3
  @backstage/plugin-permission-common                      0.5.1
  @backstage/plugin-permission-node                        0.5.1
  @backstage/plugin-permission-react                       0.3.1
  @backstage/plugin-proxy-backend                          0.2.20
  @backstage/plugin-scaffolder-backend-module-cookiecutter 0.2.1
  @backstage/plugin-scaffolder-backend                     0.16.1
  @backstage/plugin-scaffolder-common                      0.2.1
  @backstage/plugin-scaffolder                             0.12.3
  @backstage/plugin-search-backend-module-pg               0.2.8
  @backstage/plugin-search-backend-node                    0.4.7
  @backstage/plugin-search-backend                         0.4.4
  @backstage/plugin-search                                 0.7.0
  @backstage/plugin-tech-radar                             0.5.6
  @backstage/plugin-techdocs-backend                       0.13.5
  @backstage/plugin-techdocs                               0.13.4
  @backstage/plugin-user-settings                          0.3.20
  @backstage/release-manifests                             0.0.2
  @backstage/search-common                                 0.2.4
  @backstage/techdocs-common                               0.11.9
  @backstage/test-utils                                    0.2.5
  @backstage/theme                                         0.2.15
  @backstage/types                                         0.1.3
  @backstage/version-bridge                                0.1.2

Thank you for reporting! The proposed solution sounds sensible, is it something you'd like to contribute?

Sure, I will file a PR for this.


Code block should terminate block quote

Snippet.
According to the CommonMark 0.19 spec,

Laziness only applies to lines that are continuations of paragraphs. Lines containing characters or indentation that indicate block structure cannot be lazy.

http://spec.commonmark.org/dingus/?text=> block quote
    should be code
Invalid. See http://spec.commonmark.org/0.19/#example-65 . "An indented code block cannot interrupt a paragraph."

If you wish - report clarification request to https://github.com/jgm/CommonMark/issues


[bug] Brightness and power on templates cause 100% brightness to exceed valid brightness values

Version
Build/Run method

[ X] Docker
[ ] PKG
[ ] Manually built (git clone - npm install - npm run build )

Zwave2Mqtt version: 4.0.5
Openzwave Version: 1.6.1392
Describe the bug
The hass json for Leviton DZ6HD-1BZ Decora 600W Smart Dimmer has templates that cause 100% brightness to exceed the max value for Home Assistant. 100% brightness is converted to a value of 258, but HA only accepts 0-255. This is because the calculation divides the percent by 99 instead of 100:
{
  "type": "light",
  "object_id": "dimmer",
  "discovery_payload": {
    "schema": "template",
    "brightness_template": "{{ (value_json.value / 99 * 255) | round(0) }}",
    "state_topic": "homeassistant/bedroom/38/1/0",
    "state_template": "{{ \"off\" if value_json.value == 0 else \"on\" }}",
    "command_topic": "homeassistant/bedroom/38/1/0/set",
    "command_on_template": "{{ ((brightness / 255 * 99) | round(0)) if brightness is defined else 255 }}",
    "command_off_template": "0",
    "device": {
      "identifiers": [
        "zwave2mqtt_0xead14a91_node3"
      ],
      "manufacturer": "Leviton",
      "model": "DZ6HD-1BZ Decora 600W Smart Dimmer (0x0001)",
      "name": "bedroom",
      "sw_version": "1.13"
    },
    "name": "bedroom_dimmer",
    "unique_id": "zwave2mqtt_0xead14a91_3-38-1-0"
  },
  "discoveryTopic": "light/bedroom/dimmer/config",
  "values": [
    "38-1-0"
  ],
  "persistent": false,
  "ignoreDiscovery": false,
  "id": "light_dimmer"
}

To Reproduce
Steps to reproduce the behavior:
Set the dimmer to 100% brightness, and HA shows the brightness attribute to be 258
Expected behavior
100% brightness should be 255, not 258.
Additional context
Home Assistant itself seems to be fine with this and doesn't throw an errors, but it causes issues with other integrations which expect the brightness to be 0-255. For example, power menu buttons from the Android app will not function if brightness is above 255. Manually updating the hass json to use 100 instead of 99 corrects the issue.

Hi @ingenium13 ! AFAIK that template has always work, at least until now, could be that if I fix that for you it could break existing templates, what about manually edit it in hass devices table based on your needs? Or even better if you have lot of this devices add the desired template to customDevices.json (in the correct format) and it will be applied to all

The Home Assistant docs specify that brightness should be a value between 0-255 https://www.home-assistant.io/integrations/light/ The current template results in a brightness between 3 and 258. While Home Assistant itself seems to accept 258, other things that integrate with Home Assistant do not. For example, this bug I filed against the Home Assistant Android app https://github.com/home-assistant/android/issues/1179
Is there a reason that 99 was chosen instead of 100?

If I change the template on my end, will this persist across upgrades of the zwave2mqtt docker container?

If you store it in customDevices.js it will persist, yes

Is there a reason that 99 was chosen instead of 100?

Yes but now sincerly I don't remember, when we firstly integrate light dimmers there was some bugs and that template was the final fix. Maybe @jshridha could tell you more

Is there any documentation for customDevices.js? All I've found are a couple bug reports, but I think I can mostly figure it out from those.
I guess my question is, what parts of the hass json have to be added? Some subset of the discovery payload? If so, what is required and what is auto populated? Can I just have the parts that I want to change as an override (basically the two templates)? Or do I need to add everything (ie, it entirely replaces rather than just overlays the existing one)?

Regarding the 99 value: for the GE/jasco dimmers, sending 99 causes the device to go back to the brightness level it was at prior to being turned off. I'm not sure how the Leviton dimmers work regarding their state after they've been turned off.

Regarding the 99 value: for the GE/jasco dimmers, sending 99 causes the device to go back to the brightness level it was at prior to being turned off. I'm not sure how the Leviton dimmers work regarding their state after they've been turned off.

For Leviton and Innovelli de

Is there any documentation for customDevices.js? All I've found are a couple bug reports, but I think I can mostly figure it out from those.

It's explained on readme: https://github.com/OpenZWave/Zwave2Mqtt#custom-components


remove shaded packages from source jar

Resolve Issue 2 mentioned in https://github.com/Azure/azure-docs-sdk-java/issues/1573 by removing sdk unrelevant code from source jar.

LGTM. It won't take effect until the next release on Doc.Ms site.

Thanks, we will check it after this release cycle.

LGTM. It won't take effect until the next release on Doc.Ms site.

Thanks, we will check it after this release cycle.


Wishlist: ppx shortcut to avoid code duplication for printable_fun

Just a small note to suggest we could implement some ppx facility for the graders, to better follow the "DRY" principle :)
Motivation
Currently, when using test_function_against_solution or so to test a higher-order function with manual test cases involving teacher-provided closures, to avoid just printing <fun> in the report, we need to prepend these closures with printable_fun:
let p_even = printable_fun "(fun n -> n mod 2 = 0)" (fun n -> n mod 2 = 0)

Wish
It could be nice to only need to write something like this:
let p_even = [%printable: fun n -> n mod 2 = 0]

(@yurug @fpottier WDYT?)

Closed by PR https://github.com/ocaml-sf/learn-ocaml/pull/403


Resources would be deleted when change resource.

When we change the name of resources in terraform template, resources should be re-created, but the process of recreated is creating after deleting. And we can't find resources after that.

Reproduce issue:

Step 1: Create RBAC resource example:

resource "kafka_topic_rbac" "toan-vo-topic-example-topic-resourceowner" {
  principal     = "User:toan.vo"
  role          = "ResourceOwner"
  resource_type = "Topic"
  pattern_type  = "LITERAL"
  name          = "toanvtt_example_topic"
  cluster_id    = var.cluster_id
  provider      = confluent-kafka.confluent
}

Output
Plan: 1 to add, 0 to change, 0 to destroy.

Step 2: Create RBAC resource with sample properties example:

resource "kafka_topic_rbac" "toan-vo-topic-example-2-topic-resourceowner" {
  principal     = "User:toan.vo"
  role          = "ResourceOwner"
  resource_type = "Topic"
  pattern_type  = "LITERAL"
  name          = "toanvtt_example_topic"
  cluster_id    = var.cluster_id
  provider      = confluent-kafka.confluent
}

Output
Plan: 1 to add, 0 to change, 0 to destroy.

BUT Only 1 resource created in Confluent.

Step 3: Delete RBAC resource:

# resource "kafka_topic_rbac" "toan-vo-topic-example-2-topic-resourceowner" {
#   principal     = "User:toan.vo"
#   role          = "ResourceOwner"
#   resource_type = "Topic"
#   pattern_type  = "LITERAL"
#   name          = "toanvtt_example_topic"
#   cluster_id    = var.cluster_id
#   provider      = confluent-kafka.confluent
# }

Output
Plan: 0 to add, 0 to change, 1 to destroy.

Step 4: Delete RBAC resource:

# resource "kafka_topic_rbac" "toan-vo-topic-example-topic-resourceowner" {
#   principal     = "User:toan.vo"
#   role          = "ResourceOwner"
#   resource_type = "Topic"
#   pattern_type  = "LITERAL"
#   name          = "toanvtt_example_topic"
#   cluster_id    = var.cluster_id
#   provider      = confluent-kafka.confluent
# }

Output
Error: cannot find resource_typeTopic oftoanvtt_example_topic


Add stat checker

port the prod stat checker  to Java and add the results to the debug log
In next PRs, I will:

hook this up with GenMcf and Lint tools and add full end to end tests
add counters from stat checker to the main log counters

Thanks for the review!