AEAD: XChaCha20-Poly1305

The main difference between XChaCha20-Poly1305 and the original ChaCha20-Poly1305 is that the nonce size is 24 bytes instead of 8 bytes. The first 16 bytes of the nonce is used, along with the key, with HChaCha20 to derive a key, which is then used in ChaCha20-Poly1305.
The advantage of this extended-nonce variant is that you can use the same key for 2^96 messages before worrying about nonce reuse (the birthday bound), rather than 2^32 messages.
XChaCha20-Poly1305 is implemented in libsodium.
What would the steps be to get XChaCha20-Poly1305 considered for inclusion in OpenSSL for EVP encryption (i.e. for building application-layer cryptography protocols with OpenSSL)? Do I need to convince the IETF to bless it for inclusion in TLS first, even if that's presently a non-goal of my feature request?

No, it doesn't have to be in TLS, but some external third-party has to review (and approve) this before we will consider it.  And it seems highly doubtful that it will be done in time for the upcoming release.

That's fine, I wasn't aware of an upcoming release and have no qualms about tabling its inclusion until the upcoming release has concluded. I just wanted to open the discussion about its inclusion now so, when it's reviewed/approved/ready, the developers who use OpenSSL have the chance to use an extended-nonce AEAD mode.

Is it standardised? We only accept standardised crypto.

@mattcaswell The CFRG has made it working group item, and an IETF RFC is expected in the near future.

Nothing stops anyone from making a separate provider that provides this.  In fact, there could be a separate project producing a provider with algorithms that haven't been accepted in the OpenSSL main source yet (and possibly never will).  A little like, in the C++ universe, Boost is a set of C++ templates that haven't been accepted into the STL yet (and possibly never will)

Is it standardised? We only accept standardised crypto.

The IETF now has an active Internet-Draft for this protocol:
https://tools.ietf.org/html/draft-irtf-cfrg-xchacha-03
https://datatracker.ietf.org/doc/draft-irtf-cfrg-xchacha/
Does that meet this requirement so that this protocol can be considered to include in OpenSSL? Or would you require it to reach a final RFC first?

It has to reach a final RFC first.

It has to reach a final RFC first.

That wasn't the case for TLS 1.3.

It has to reach a final RFC first.

That wasn't the case for TLS 1.3.

We held the release for the final RFC.
Getting the code in earlier (and incrementally) was okay, because we knew in advance that we were going to hold the release for TLS 1.3.

The key point is the work started well before the RFC was published, and your comment implied, at least to me, that nothing will start until the RFC is published which is not correct.  (We also did some CMS update work IIRC)

It is not going to be "included in OpenSSL" until the final RFC is published.  (Not my decision, for what little it counts.)  Whether it means anything to "consider" it beforehand is probably subjective...

FYI for Go programmers watching this ticket: it's fairly straightforward to get fast* XChaCha20-Poly1305 by combining HChaCha20 from Go x/crypto with EVP_chacha20_poly1305 from OpenSSL.
If there is interest, I can make my implementation importable as a library.
* 5 x faster than x/crypto/chacha20poly1305 on armv7

Hi @rfjakob
Your approach is quite interesting, I was wondering if such approach would support streamed encryption/decryption. That is processing large files that wouldn't normally fit in RAM, whilst using Poly1305 to generate/verify authenticated tag.

Looking at the diagram at
https://pkg.go.dev/github.com/rfjakob/gocryptfs/v2/internal/stupidgcm#hdr-XChaCha20_Poly1305
again, I don't see why not.
On Sat, 28 Jan 2023, 18:31 Tomasz Raganowicz, @.***>
wrote:

Hi @rfjakob https://github.com/rfjakob
Your approach is quite interesting, I was wondering if such approach would
support streamed encryption/decryption. That is processing large files that
wouldn't normally fit in RAM, whilst using Poly1305 to generate/verify
authenticated tag.
—
Reply to this email directly, view it on GitHub
https://github.com/openssl/openssl/issues/5523#issuecomment-1407446348,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AACGA7ZAKYEWYCBRNT5WGG3WUVJW3ANCNFSM4ETXPTUQ
.
You are receiving this because you were mentioned.Message ID:
@.***>

I do not think there is any official standard specifying XChaCha20-Poly1305 so there is no progress. I am going to close the PR. Please re-open or open a new issue if there is any official standard for this algorithm.


Display the blocked requests in the add-on icon.

What do you think about showing the number of requests blocked by the add-on icon instead of the exclamation point currently displayed?.
I realize that of the 7 add-on I have installed, they all show a numerical indicator instead of a symbol, except for 2 and No Coin is one of them. If you don't know what I'm talking about, install ublock origin and look at the number on its icon, that's what I mean. This is not a bug, it's a cosmetic change. I put it over here because you're asking for feature requests to be posted here and nice work!, thanks!.

This has been suggested previously but wasn't added because it doesn't make much sense. I don't think any website would run more than one miner on a page and there's therefore no need to indicate how many requests were blocked. Instead just indicating that a miner has been blocked is enough. This is different to adblockers or some privacy extensions because websites usually have multiple ads or trackers on a page.
I will in the future add stats so you'll be able to see how many requests were blocked per day.
I'll leave this issue open for discussion a few more days.

I think they're good reasons for not doing it, as I say it's just a cosmetic change, although it can be useful in some cases, for example, I just installed another blocker that has this function included, if yours also had it, I could make a visual check about which one is better or more suited to my needs, or if any of them are leaving something to block in the way because I really think that a website can have more than one miner on a page.
If you own the site and someone is blocking you from using one of the miners, you can use another for example.
I include two "temporary" screenshots from my browser:
Case 1  shows two blocks, so I assume the page tries to run two miners. I haven't really checked.
Case 2 shows a good number of blockages, as these blockages increase in time, I assume that there is at least one miner trying to run itself every X time and the add-on is reporting those attempts to me.
Anyway, your code, your decision, you'll always do the right thing.


CPU runs at 100%

This happens whether I'm using it or it's just open.
I've disable auto-updates (which I thought the issue was related to), but this is still happening.
With extensions:
3017 100.0  2.3  5449792 383260   ??  R     9:43AM   2:10.06 /Applications/Visual Studio Code.app/Contents/Frameworks/Code Helper.app/Contents/MacOS/Code Helper /Applications/Visual Studio Code.app/Contents/Resources/app/extensions/node_modules/typescript/lib/tsserver.js --useInferredProjectPerProjectRoot --enableTelemetry --cancellationPipeName /var/folders/s4/ffqt6x516015rf37_gl41sqm0000gn/T/vscode-typescript/tscancellation-02e37620f35c155d56fe.tmp* --locale en --noGetErrOnBackgroundUpdate
Without extensions:
/Applications/Visual Studio Code.app/Contents/Frameworks/Code Helper.app/Contents/MacOS/Code Helper /Applications/Visual Studio Code.app/Contents/Resources/app/extensions/node_modules/typescript/lib/tsserver.js --useInferredProjectPerProjectRoot --enableTelemetry --cancellationPipeName /var/folders/s4/ffqt6x516015rf37_gl41sqm0000gn/T/vscode-typescript/tscancellation-3fad16c5862f653ec1c8.tmp* --locale en --noGetErrOnBackgroundUpdate

VSCode Version: 1.27.1
OS Version: macOS High Sierra 10.13.6

Does this issue occur when all extensions are disabled?: Yes

As a first step, can you please try upgrading your workspace to use typescript@next by following these instructions. Let me know if you still see this problem when using that version of TypeScript


Why do we need to scale img_feat to 0.1 in the stn_head?

https://github.com/ayumiymk/aster.pytorch/blob/36e73daf0808dc6e6bcda64ca497b672da959105/lib/models/stn_head.py#L90
Why need to * 0.1 to img_feat? Thanks!

I refer to the original implement here. The purpose is to make the training more stable.


Rename into flow-packages

@adioo Rename this into flow-packages because it's about a list of packages. :rocket:

done.

:+1:


SDL2_mixer: add "dev" output

SDL2_mixer is a a popular game dependency. Split it's dev output to separate store path to reduce runtime closure size.
While at it amend a few games's include paths.
Description of changes

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
22.11 Release Notes (or backporting 22.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

 Converting to draft to verify if they are directly caused by the change.

33 packages failed to build:

Was not able to reproduce any of the failures. @superherointj , can you extract 1-2 build log failures for failed examples? I wonder if it was something transient (like out-of-space problems).

Was not able to reproduce any of the failures.
I wonder if it was something transient (like out-of-space problems).

Packages as worldofgoo shouldn't error at all because cannot be built.
Irrelevant build failures lead me to do this:
https://github.com/NixOS/nixpkgs/pull/191983

@superherointj , can you extract 1-2 build log failures for failed examples?

Tried to recover logs but was not able to.
The package seemed relevant was lutris. I would test for that.

Result of nixpkgs-review pr 191779 run on x86_64-linux 1

3 packages marked as broken and skipped:

itch
python310Packages.rl-coach
python39Packages.rl-coach

1 package blacklisted:

appimage-run-tests

31 packages failed to build:

anytype
bottles
buttercup-desktop
cataclysm-dda-git
electron-mail
firefly-desktop
flexoptix-app
frescobaldi
keeweb
lutris
marktext
minigalaxy
mobilecoin-wallet
neo4j-desktop
playonlinux
python310Packages.kivy
python310Packages.pyautogui
python310Packages.pysdl2
python310Packages.pytmx
python39Packages.kivy
python39Packages.pyautogui
python39Packages.pysdl2
python39Packages.pytmx
standardnotes
tauon
timeular
trezor-suite
unityhub
worldofgoo
xivlauncher
zettlr

146 packages built:

SDL2_mixer
Sylk
_1oom
_20kly
abbaye-des-morts
altair
anki-bin
appimage-run
apple-music-electron
augustus
beekeeper-studio
betterdiscord-installer
blobwars
blockattack
bloomrpc
bootstrap-studio
brutalmaze
caprine-bin
cataclysm-dda
cdogs-sdl
chocolateDoom
chromium-bsu
chrysalis
cider
commandergenius
cozy-drive
craftos-pc
crawlTiles
crispyDoom
crypto-org-wallet
davinci-resolve
devdocs-desktop
eduke32
electronplayer
endgame-singularity
enigma
eternity
fheroes2
flare
framesh
freeciv (freeciv_gtk)
freeciv_qt
freeciv_sdl2
frogatto
fspy
gemrb
guile-sdl2
haskellPackages.Raincat
haskellPackages.grid-proto
haskellPackages.piyo
haskellPackages.sdl2-mixer
hedgewars
heroic
infra-arcana
instead
instead-launcher
irccloud
ivan
joplin-desktop
julius
jumpnbump
kodiPackages.steam-launcher
lbreakouthd
lbry
ldtk
ledger-live-desktop
lens
liberal-crime-squad
lightspark
lincity_ng
losslesscut-bin
lpairs2
lunar-client
lzwolf
manaplus
mar1d
mathpix-snipping-tool
methane
molotov
mycrypto
notable
notion-app-enhanced
np2kai
nuclear
nxengine-evo
octant-desktop
opendune
opensupaplex
p3x-onenote
passky-desktop
pingus
plexamp
prboom-plus
protontricks
pysolfc
python310Packages.pygame
python310Packages.pygame-gui
python310Packages.pygame_sdl2
python310Packages.pygetwindow
python310Packages.pyrect
python39Packages.pygame
python39Packages.pygame-gui
python39Packages.pygame_sdl2
python39Packages.pygetwindow
python39Packages.pyrect
radicle-upstream
rambox-pro
raven-reader
remnote
renpy
retrofe
rocksndiamonds
ryujinx
saleae-logic-2
session-desktop
sfrotz
sonixd
space-cadet-pinball
srb2
srb2kart
ssb-patchwork
station
steam
steam-rom-manager
steam-run
steam-tui
steamcmd
taisei
the-legend-of-edgar
toppler
trackballs
tusk
uhk-agent
uhk-udev-rules
ultrastardx
vcmi
vengi-tools
via
vial
video2midi
wargus
wesnoth (wesnoth-dev)
wootility
ytmdesktop
zecwallet-lite
zulip

Aha, at least pysdl2 was fixed in 05f43a9321f4c948426f2bd74623720ad31e6062. Does nixpks-review tests merge against master or staging? I tested the build in the branch itself.

Does nixpks-review tests merge against master or staging?

staging (because this PR targets staging). commit for reference: cfe69b2b2f62266983a25da3a81b392d8e9c2d69

Result of nixpkgs-review pr 191779 run on x86_64-linux 1

3 packages marked as broken and skipped:

itch
python310Packages.rl-coach
python39Packages.rl-coach

1 package blacklisted:

appimage-run-tests

33 packages failed to build:

anytype
bottles
buttercup-desktop
cataclysm-dda-git
cdogs-sdl
electron-mail
firefly-desktop
flexoptix-app
frescobaldi
keeweb
lutris
marktext
minigalaxy
mobilecoin-wallet
neo4j-desktop
playonlinux
python310Packages.kivy
python310Packages.pyautogui
python310Packages.pysdl2
python310Packages.pytmx
python39Packages.kivy
python39Packages.pyautogui
python39Packages.pysdl2
python39Packages.pytmx
standardnotes
tauon
timeular
trezor-suite
unityhub
video2midi
worldofgoo
xivlauncher
zettlr

144 packages built:

SDL2_mixer
Sylk
_1oom
_20kly
abbaye-des-morts
altair
anki-bin
appimage-run
apple-music-electron
augustus
beekeeper-studio
betterdiscord-installer
blobwars
blockattack
bloomrpc
bootstrap-studio
brutalmaze
caprine-bin
cataclysm-dda
chocolateDoom
chromium-bsu
chrysalis
cider
commandergenius
cozy-drive
craftos-pc
crawlTiles
crispyDoom
crypto-org-wallet
davinci-resolve
devdocs-desktop
eduke32
electronplayer
endgame-singularity
enigma
eternity
fheroes2
flare
framesh
freeciv (freeciv_gtk)
freeciv_qt
freeciv_sdl2
frogatto
fspy
gemrb
guile-sdl2
haskellPackages.Raincat
haskellPackages.grid-proto
haskellPackages.piyo
haskellPackages.sdl2-mixer
hedgewars
heroic
infra-arcana
instead
instead-launcher
irccloud
ivan
joplin-desktop
julius
jumpnbump
kodiPackages.steam-launcher
lbreakouthd
lbry
ldtk
ledger-live-desktop
lens
liberal-crime-squad
lightspark
lincity_ng
losslesscut-bin
lpairs2
lunar-client
lzwolf
manaplus
mar1d
mathpix-snipping-tool
methane
molotov
mycrypto
notable
notion-app-enhanced
np2kai
nuclear
nxengine-evo
octant-desktop
opendune
opensupaplex
p3x-onenote
passky-desktop
pingus
plexamp
prboom-plus
protontricks
pysolfc
python310Packages.pygame
python310Packages.pygame-gui
python310Packages.pygame_sdl2
python310Packages.pygetwindow
python310Packages.pyrect
python39Packages.pygame
python39Packages.pygame-gui
python39Packages.pygame_sdl2
python39Packages.pygetwindow
python39Packages.pyrect
radicle-upstream
rambox-pro
raven-reader
remnote
renpy
retrofe
rocksndiamonds
ryujinx
saleae-logic-2
session-desktop
sfrotz
sonixd
space-cadet-pinball
srb2
srb2kart
ssb-patchwork
station
steam
steam-rom-manager
steam-run
steam-tui
steamcmd
taisei
the-legend-of-edgar
toppler
trackballs
tusk
uhk-agent
uhk-udev-rules
ultrastardx
vcmi
vengi-tools
via
vial
wargus
wesnoth (wesnoth-dev)
wootility
ytmdesktop
zecwallet-lite
zulip

33 packages failed to build:

I can't seem to repro some of these failures:
$ git rev-parse HEAD
d21052f9a2d830c16342c9cb72a62306fd3e782b
$ nix-build . -A python310Packages.pysdl2
/nix/store/mv4bidwlpd0naiwhg2fhbfsm760528sq-python3.10-PySDL2-0.9.11
$ nix-build . -A xivlauncher
/nix/store/bnqsjflsw6fqdy3hkb8y280x9xb47c7f-XIVLauncher-<IP_ADDRESS>
$ nix-build . -A playonlinux
/nix/store/n3dymrkb9zjcrj9b5g77ijflf76bv91b-playonlinux-4.4
$ nix-build . -A lutris
/nix/store/jv25hmkac1ks076hivfy1l7m9zrwvgpa-lutris

Yeah, python3Packages.pysdl2 is currently already broken on staging.

@ofborg build python310Packages.pysdl2


Span is not terminated properly in Spring Cloud Gateway

This issue is also submitted in Spring Cloud Gateway. https://github.com/spring-cloud/spring-cloud-gateway/issues/2320
There are two example for this phenomenon.
First is to enable AdaptCachedBodyGlobalFilter for a route, then the span will be terminated after the AdaptCachedBodyGlobalFilter  in request chain. For example:
//other filter...
LogFilter1
AdaptCachedBodyGlobalFilter (cache is enabled for this route)
LogFilter2

You would find the log context possess spanId and traceId in LogFilter1 but does not possess in LogFilter2.
The other example is while use RetryGatewayFilterFactory. You can enable RetryGatewayFilterFactory trace log and you would find the log context possess spanId and traceId only before the first request sent out, and there is no spanId or traceId in the log context for the possible subsequent retry.
Maybe we should subscribe some specific filter in Spring Cloud Gateway to solve it. The only subscribe in TraceWebFilter is not enough.

Which version of sleuth are you using?

Which version of sleuth are you using?

3.0.3

Can you please create a sample that replicates this issue?

Can you please create a sample that replicates this issue?

please refer to https://github.com/HashZhang/spring-cloud-gateway-sleuth-test

Is this still an issue?


(Resource: PhysicsEditor Exporter) Add option to prefix shape name and optimize JSON output

Just improving upon the work of @georgiee with an optimized output.
Updated the JavaDoc of Body.addPhaserPolygon()

Nice one, thanks!


Cancelled tasks show as completed in logbook

Describe the bug
Cancelled tasks show as completed.
Alt-clicking a task strikes it through in Things, whereas in Obsidian the task is marked complete like any other complete task.
Steps to reproduce

Open Things
Move focus to a to-do
Alt-click to strike it through
Wait for sync to Obsidian
To-do will display as completed

Expected behavior

To-do is displayed as cancelled

Screenshots

Environment (please specify)
OS
macOS
Obsidian Version (e.g. v0.10.6)
v0.12.19
Theme (if applicable):
Minimal, by Kepano

I second this, would love for cancelled tasks to show up as crossed out or something that is different from completed tasks.

I also ran across this issue and thought it would be useful to have canceled tasks recorded differently.
I created a simple PR that will query the status and mark canceled tasks with a c instead of an x.
https://github.com/liamcain/obsidian-things-logbook/pull/30#issue-1077901415
By default, obsidian will render a task with any character in between the [ ] as complete which includes a strikethrough, so changing the mark does not in itself change the appearance, but now can be targetted with css using the data-task attribute.
I thought about using CSS to replace the icon, but I don't much like that obsidian rendered a strike-through on completed tasks as the checkbox itself is sufficient for me, so I opted to add the following more simple CSS snippet which rendered canceled items with a strikethrough.
ul > li.task-list-item.is-checked[data-task] {
    text-decoration: none;
}
ul > li.task-list-item.is-checked[data-task="c"] {
    text-decoration: line-through;
}

Hi! I just noticed that while I cut a release for your change @kurtharriger, I never bumped the version in the manifest.json.
This fix should finally be released now, sorry for the long wait 😢

If you want, you can modify your data.json inside the plugins/things-logbook folder which keeps track of the last synced time (latestSyncTime). If you remove that line, the plugin will override all historical entries and will automatically fix it so that canceled entries show properly as canceled.


Inlined category types to support correct type inference.

Used type lambdas instead of inner type alias for Category requirements. This moves type declaration to the function level instead of it being on the class instance level.
It allows reusing composite or derived combinators, for example the following method declared outside of trait Iso now compiles:
  def example[A](
    implicit F: Applicative[F],
    G: Applicative[G],
    C1: Category[λ[(α, β) => α => F[β]]],
    C2: Category[λ[(α, β) => α => G[β]]]
  ): Iso[F, G, A, A] = {
    val a1: Iso[F, G, A, A] = id[A]
    val a2: Iso[F, G, A, A] = id[A]
    a1 >>> a2
  }

Codecov Report

Merging #21 into master will not change coverage.
The diff coverage is 100%.

@@          Coverage Diff          @@
##           master    #21   +/-   ##
=====================================
  Coverage     100%   100%
=====================================
  Files           2      2
  Lines          49     49
=====================================
  Hits           49     49

Impacted Files
Coverage Δ

src/main/scala/scalaz/parsers/Iso.scala
100% <100%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f52b545...af75d33. Read the comment docs.


close #24

Added Helios.DedicatedThreadPool and used it to replace the guts of the
default DedicatedThreadPoolFiber - resulted in a massive increase in
throughput.

Benchmark data:
Old Implementation
Comparing System.Threading.ThreadPool vs Helios.Concurrency.DedicatedThreadFiber for 10000 items
DedicatedThreadFiber.NumThreads: 8
System.Threading.ThreadPool
00:00:00.0060000
Helios.Concurrency.DedicatedThreadFiber
00:00:00.0490000
Comparing System.Threading.ThreadPool vs Helios.Concurrency.DedicatedThreadFiber for 100000 items
DedicatedThreadFiber.NumThreads: 8
System.Threading.ThreadPool
00:00:00.0740000
Helios.Concurrency.DedicatedThreadFiber
00:00:00.3020000
Comparing System.Threading.ThreadPool vs Helios.Concurrency.DedicatedThreadFiber for 1000000 items
DedicatedThreadFiber.NumThreads: 8
System.Threading.ThreadPool
00:00:00.6160000
Helios.Concurrency.DedicatedThreadFiber
00:00:04.3650000
Comparing System.Threading.ThreadPool vs Helios.Concurrency.DedicatedThreadFiber for 10000000 items
DedicatedThreadFiber.NumThreads: 8
System.Threading.ThreadPool
00:00:05.5070000
Helios.Concurrency.DedicatedThreadFiber
00:00:39.7220000

DedicatedThreadPool implementation
Comparing System.Threading.ThreadPool vs Helios.Concurrency.DedicatedThreadFiber for 10000 items
DedicatedThreadFiber.NumThreads: 8
System.Threading.ThreadPool
00:00:00.0020000
Helios.Concurrency.DedicatedThreadFiber
00:00:00.0050000
Comparing System.Threading.ThreadPool vs Helios.Concurrency.DedicatedThreadFiber for 100000 items
DedicatedThreadFiber.NumThreads: 8
System.Threading.ThreadPool
00:00:00.0280000
Helios.Concurrency.DedicatedThreadFiber
00:00:00.0470000
Comparing HSystem.Threading.ThreadPool vs Helios.Concurrency.DedicatedThreadFiber for 1000000 items
DedicatedThreadFiber.NumThreads: 8
System.Threading.ThreadPool
00:00:00.2610000
Helios.Concurrency.DedicatedThreadFiber
00:00:00.4580000
Comparing System.Threading.ThreadPool vs Helios.Concurrency.DedicatedThreadFiber for 10000000 items
DedicatedThreadFiber.NumThreads: 8
System.Threading.ThreadPool
00:00:02.6250000
Helios.Concurrency.DedicatedThreadFiber
00:00:05.4990000


Updated implementation

This is an updated version of https://github.com/vaticle/typeql/pull/102
This PR contains workflows for automatically publishing updates to https://plugins.jetbrains.com. You will have to create an account there and update the repository secrets so release.yml works.

Sounds about right :+1:


getTablelist on a .odm File

After updating from Simple Api to ODFDOM the table search doesn't find the underlying tables from the .odf Files anymore.
var count = TextDocument.loadDocument("AFile.odm").getTableList().size() was about 28 Tables
var count = OdfTextDocument.loadDocument("AFile.odm").getTableList(true).size() is now 2
In which way do i need to adjust my code to get a complete Table List?

I did a quick grep on existing regression tests:
find . -name *.java | xargs grep getTableList
revealed e.g.
odfdom/src/test/java/org/odftoolkit/odfdom/doc/table/TableTest.java
Could you please give this test a try and adopt this test with your test file adding it to
odfdom/src/test/resourcestest-input
As the parameter is true in your example it is a recursive search all <table:table> should be found.
Otherwise, you might even give the debugger a try! :-)
Thanks in advance for your help!
Svante

Aye, it is a master document and other documents are external and referenced from the master document, which are likely not being searched.
If you like to add this functionality, you might want to copy/paste it from the Simple API (once added by IBM).
Any pull requests are most welcome! :-)


DO NOT MERGE Use dependencyManagement from Karaf as a bom

Apache Brooklyn uses a lot of the same dependencies are provided by Apache Karaf. However, we redeclare these dependencies and rely on notes and comments to upgrade them when Karaf is upgraded.
Karaf provides a <dependencyManagement> element that we can import into our parent pom.xml.
This PR does this and removes any duplicates. Where we use a conflicting/alternative version they have been grouped together and commented that they are overriding versions in Karaf. All of them are holding back to older versions of the dependency.
Some properties that are not used with a <dependency> are used within a features.xml file to declare a <bundle dependency....>. These have been grouped next to the <karaf.version> property to aid in remembering to update them when Karaf is upgraded.
The intention is to make future upgrades of Karaf easier by reducing the potential for conflicting versions. It also makes it clearer which dependencies are no longer matching those used by Karaf. Removing the relevant entry, and property (if not used in a feature) in our pom.xml would upgrade to the Karaf version.
javax.xml.bind and javax.activation libraries have been replaced with the Apache Servicemix versions that Karaf uses, to avoid the risk of classes being included from different sources.
Features that used jetty dependencies have been updated to use the Karaf-provided feature jetty. This removes the need to maintain a <jetty.version> property.

There are problems being reported by brooklyn-dist when building againt this PR. Need to look into that before going ahead with this.

I like the approach, the changes look good, but brooklyn-dist build fails for me with these changes due to the maven-enforcer-plugin:
[WARNING]
Dependency convergence error for javax.xml.bind:jaxb-api:2.3.0 paths to dependency are:
+-org.apache.brooklyn:karaf-docker-image:1.0.0-SNAPSHOT
  +-org.apache.brooklyn:apache-brooklyn:1.0.0-SNAPSHOT
    +-org.apache.karaf.features:framework:4.2.2
      +-org.apache.karaf.features:base:4.2.2
        +-javax.xml.bind:jaxb-api:2.3.0
and
+-org.apache.brooklyn:karaf-docker-image:1.0.0-SNAPSHOT
  +-org.apache.brooklyn:apache-brooklyn:1.0.0-SNAPSHOT
    +-org.apache.karaf.features:framework:4.2.2
      +-org.apache.karaf.features:base:4.2.2
        +-org.glassfish.jaxb:jaxb-runtime:2.3.1
          +-javax.xml.bind:jaxb-api:2.3.1

[WARNING] Rule 2: org.apache.maven.plugins.enforcer.DependencyConvergence failed with message:
Failed while enforcing releasability the error(s) are [
Dependency convergence error for javax.xml.bind:jaxb-api:2.3.0 paths to dependency are:
+-org.apache.brooklyn:karaf-docker-image:1.0.0-SNAPSHOT
  +-org.apache.brooklyn:apache-brooklyn:1.0.0-SNAPSHOT
    +-org.apache.karaf.features:framework:4.2.2
      +-org.apache.karaf.features:base:4.2.2
        +-javax.xml.bind:jaxb-api:2.3.0
and
+-org.apache.brooklyn:karaf-docker-image:1.0.0-SNAPSHOT
  +-org.apache.brooklyn:apache-brooklyn:1.0.0-SNAPSHOT
    +-org.apache.karaf.features:framework:4.2.2
      +-org.apache.karaf.features:base:4.2.2
        +-org.glassfish.jaxb:jaxb-runtime:2.3.1
          +-javax.xml.bind:jaxb-api:2.3.1
]

Annoyingly, this seems to be a problem in Karaf 4.2.2 itself!
https://search.maven.org/artifact/org.apache.karaf.features/base/4.2.2/jar depends on:
<dependency>
    <groupId>javax.xml.bind</groupId>
    <artifactId>jaxb-api</artifactId>
    <version>2.3.0</version>
</dependency>
<dependency>
    <groupId>org.glassfish.jaxb</groupId>
    <artifactId>jaxb-runtime</artifactId>
    <version>2.3.1</version>
</dependency>

And https://search.maven.org/artifact/org.glassfish.jaxb/jaxb-runtime/2.3.1/jar depends on v2.3.1 of javax.xml.bind:jaxb-api.
Therefore I'm not sure we can merge this! Maybe we could add some excludes or some temporary ugliness like that.
Note that karaf 4.2.3 is recently out as well, which I think will fix that incompatibility between jaxb-api version (to use v2.3.2 throughout). But not suggesting we rush to upgrade to that, and certainly not in this PR.

@aledsage Updated: Overriding the dependency, much as karaf appear to do themselves, fixes this.

I can build Brooklyn and deploy some examples locally and on AWS. It looks great

Previously brooklyn was only doing the stop / restart thing twice during start.
Extra one seems to be related to jetty - but I'm not sure how to interpret the logs for this

retest this please
job missing on jenkins


Drop support for Node.js 8.

By the time v5 stable will be out, 8 will be EOL (December 2019).

Notes:

in order to make Netlify use Node.js 10, we need to use a .nvmrc file. Adding this file might have other implications which I'm not 100% sure since I don't use nvm myself
we need to remove Node.js 8 from the master protection rules before merging this

I dropped the .nvmrc addition. Maybe netlify will properly read the engines version after this is merged on master. If not we add the .nvmrc file then.

@mdo: if we merge this, I need Node.js 8 removed from the master branch protection rules :)
@Johann-S: I assume you agree?

Done!


Feature/image links

This adds to the object information that is used for the web page, and also available through the API. What is added is explicit URLs for the cutout images. The reason to do this now is we are starting a Zooniverse collaboration, and the first thing they will want is images.

The links come though the API and they deliver FITS images. I have made a pull request on lasair-deploy to put in the symlink from the static directory of the webserver to the cephfs where the images are.


Error response body for create payout and approve payout different

resulting in error in unmarshal json when getting the error response body

Hi @richardreynaldo it's expected to create and approve payout has a different payload. You can find the detail docs from iris API documentation
Based on those error screenshots, happened cause you don't send beneficiary_name in create payout request. this is a mandatory field. The minimum request for the body should be like this
{     "payouts": [         {             "beneficiary_name": "John Doe",             "beneficiary_account": "1172993826",             "beneficiary_bank": "bni",             "amount": 100000,             "notes": "Payout April 17"         }     ] }
Also, you can download the Postman collection that covers the Iris API from this page
https://docs.midtrans.com/en/technical-reference/postman-collection?id=midtrans-iris-api-postman-collection
Any related general questions, you can reach out to us via email<EMAIL_ADDRESS>Thank you

hi @Xaxxis I want to know if you do expect the difference in errors of the create and approve error response body is different?
you can see that in the create payout error the errors would be
"errors": {         "0": [             "Beneficiary name can't be blank",             "Beneficiary name only allows space, alphanumeric, non-latin letter, non-latin numeric, \".\" and \",\" characters"         ]     }
meanwhile in the approve payout error the errors would be
"errors": [         "Reference nos 'ce5u4cppr7fkehf45g' are not queued"     ]

Hi @richardreynaldo yes this is expected, those APIs have a different error. On creating payout the error happened due to missing the beneficiary_name field
On the Approve  API, we can't find the reference number ce5u4cppr7fkehf45g. Makes sure you send the correct value reference number. However, if Iris didn't find the reference number,  it will reproduce the error message
"errors": [ "Reference nos 'ce5u4cppr7fkehf45g' are not queued" ]

@Xaxxis but why does the create payout errors have "0" inside the errors json meanwhile the approve payout doesn't have the "0" inside the json?

I think you refers to the difference of errors JSON structure between that 2 API endpoints, in that case, yes it seems like a valid issue. And currently this Go module can't properly parse the errors response from /payouts. (Potential quick workaround is to change this line to accept interface{} )
But for proper parsing, we'll need to check this with our Iris API team first, and get back to you sometimes around next week.
Thanks for reporting.

@rizdaprasetya ah sorry that's my point, my issues before maybe unclear. thanks a lot for the attention.

Sorry late update, few days ago our Iris API team acknowledged the issue, which is a valid issue. They will check & try to improve it. Also the reason why create payout have index as key was because on payout creation, each payout can have more than 1 error.
We are waiting for the proper spec from them to update this Go module accordingly. Thanks!

Hi @richardreynaldo the issue has been solved on the new version v1.2.2 ya
Thank you


Split up commands locales into different files

Related to https://github.com/LorittaBot/Loritta/pull/2371
(Now the files should be fixed, the last PR wasn't using the newest commits from main)

noooo it wasn't finished yet I forgot that the bot auto merges my PRs

I've forced reset master to the commit before this PR, to avoid crowdin pushing the new files before everything is ready.


2770 Fix legend frequency and embedding

Description

Details
URL to issue
https://biomage.atlassian.net/browse/BIOMAGE-2270

Link to staging deployment URL (or set N/A)
https://ui-martinfosco-ui120.scp-staging.biomage.net/

Links to any PRs or resources related to this PR

Integration test branch
master

Merge checklist
Your changes will be ready for merging after all of the steps below have been completed.

Code updates
Have best practices and ongoing refactors being observed in this PR

[ ] Migrated any selector / reducer used to the new format.

Manual/unit testing

[ ] Tested changes using InfraMock locally or no tests required for change, e.g. Kubernetes chart updates.
[ ] Validated that current unit tests for code work as expected and are sufficient for code coverage or no unit tests required for change, e.g. documentation update.
[ ] Unit tests written or no unit tests required for change, e.g. documentation update.

Integration testing
You must check the box below to run integration tests on the latest commit on your PR branch.
Integration tests have to pass before the PR can be merged. Without checking the box, your PR
will not pass the required status checks for merging.

[ ] Started end-to-end tests on the latest commit.

Documentation updates

[ ] Relevant Github READMEs updated or no GitHub README updates required.
[ ] Relevant Wiki pages created/updated or no Wiki updates required.

Optional

[ ] Staging environment is unstaged before merging.
[ ] Photo of a cute animal attached to this PR.

The change requested in the ticket was to remove the limit on the amount of labels (which it seems the spec sets on its own if we set it)


source code of PPLR

When will the source code of PPLR be uploaded?

Hi,
We are planning to release the code as soon as the code refactoring is finished. I'm pretty sure the code will be released before CVPR 2022 starts (June 19).

Hi,
We just released the code now.
Thanks for your interest.


fix(time-format): fix formatting for minute precision

Jira: XDS-102

:tada: This PR is included in version 2.10.1 :tada:
The release is available on:

npm package (@next dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Renaming components can cause crash in editor

In 0.5.1 renaming components in the editor doesn't clear up all references to the old name.  If you then create a new component (or rename something) which is the same as the old name it will crash.
Fixed in dev branch, will be in next release.

Fixed in 0.5.2


Refactor duplicated code to service architecture

This is more for the strategy to refactor some duplicated code out into their own classes. This will make the codebase more testable, easier to reason about, and a lot cleaner.
There are several pieces around the codebase where code is copy-pasted, sometimes identically and sometimes with very minor differences.
For example, building out the category array:
$categories = [];
$categories["none__"] = "-- Select Category --";
$categories = array_merge($categories, Category::all()->pluck('name', 'slug')->toArray());

My suggestion is to refactor this out into a service class architecture. I'd also be happy to tackle this if it's the direction the team wants to go.
What this would look like is:

Creating an app/Services folder to house our services.
Build out classes that are focused on a specific feature, perhaps a CategoryService.php.
In the controller methods where the abstracted code was used, use Laravel's service container to inject the service class:

public function edit(Game $game, CategoryService $categoryService): View
{
    $categories = $categoryService->buildArray();
    ....
}

Then we write a unit test for the CategoryService methods, making sure the outputs are what we expect.

This makes a while lot of sense to me. Likewise with handling images and such there is various copy and paste for that, I did create an ImageUploadController but with banners it's C+P, so yes, I agree with this completely and it should be done.
Can you think of any more uses for it?
On a counter point, should this be in the Modal? For instance Category::dropDown() or do you think it's still best suited outside of the Modal and in it's own service?
We currently use laravel-bootstrap-4-forms and there seems to be a bug in which you can't pass in the key properly to build a select menu, hence why they are also currently using slugs (Not ideal, but I don't see it making a difference right now). Just thought I'd share the backstory on that.

Makes sense, thanks for explaining. You are more than welcome to go ahead with the Service idea. I'll be working on #34 on a new branch in the meantime.


download failed

When I was downloading images,a lot of error as below occured.Is it because of the copyrights?
Could not create PDF of 0001005.
Try to increase the waiting_time and check the log to identify missing latex packages

Hi No, it could not compile the latex file. Do you have texlive-full installed? If yes, please increase the waiting_time
https://github.com/felix-schmitt/FormulaNet/blob/ed8121b09c5db376355fc0b2b3b573a269986e4e/download.py#L71
. If this does not help, please check the latex log file in the temp folder and try to compile it manually.

Thank you! It helps.
But I still have errors as below.
Traceback (most recent call last):
File "download.py", line 100, in
download("urls.txt")
File "download.py", line 88, in download
resize_image(image_list[page_number], {'w': 1447, 'h': 2048}, str(train_img / page))
IndexError: list index out of range


New UAI

The upcoming UAI will be flexible, and generated according to configurations. It will feature both entry and exit animations to capture attention, along with a visual indicator to direct users toward the most appropriate action on the screen. It will be based on the following config
All UAI Configs ->
Signer (Health Check):
1. Trigger Mechanism:
    1. **APP_LOGIN** check for the signer's date last health_check and today's date.
    2. IF more than the threshold (180 days) create a UAI and add it to the stack.

2. UAI Configuration:
    1. Heading: *Health Check due*
    2. Sub Heading: “{DEVICE} was last accessed on {LAST_DATE}. Confirm Access”
    3. CTA Configs:
        1. Primary: *Confirm*
        2. Secondary: *Skip*

3. Indicator Sequence:
    Home Screen (Manage Signers Tile) → Manage Signer (Signer Tile) → HC CTA

4. UAI Modal:
    1. Details:
        1. Title
        2. SubTitle:
    2. CTAs:
        1. Continue:
        2. Manual Confirm:
        3. Cancel:

5. Reset:  Mark it as actioned

Signer (Registration Check):
1. Trigger Mechanism:
    1. **APP_LOGIN** check for all signers and with VERIFYING Signers list .
    2. **ADD_SD** check with same VERIFYING Signers list.

2. UAI Configuration:
    1. Heading: *Signer Registration due*
    2. Sub Heading: “Registration for {DEVICE} for  {VAULT_NAME} is pending”
    3. CTA Configs:
        1. Primary: Add **
        2. Secondary: *Skip*

3. Indicator Sequence:
    Home Screen (Vault  Tile) → Vault Details (Signer Tile) → Signer Details (Settings Icon) → Setting Page (Registration Details)

4. UAI Modal:
    1. Details:
        1. Title:
        2. SubTitle:
    2. CTAs:
        1. Register:
        2. Skip:
        3. Cancel:

 5. Reset:  Mark it as actioned

Recovery Key (Back up and Confirm):
1. Trigger Mechanism:
    1. **APP_LOGIN** check for the key's date last health_check and today's date. .
    2.  IF more than the threshold (180 days) create a UAI and add it to the stack.

2. UAI Configuration:
    1. Heading: _Health Check Due_
    2. Sub Heading: _Key's was done on {LAST_DATE}. Confirm Access_
    4. CTA Configs:
        1. Primary: _Confirm_
        2. Secondary: _Skip_

3. Indicator Sequence:
    Home Screen (App Setting Tile) →App Setting Details (Recovery CTA)

4. UAI Modal:
    1. Details:
        1. Title:
        2. SubTitle:
    2. CTAs:
        1. Register:
        2. Skip:
        3. Cancel:

 5. Reset:  Mark it as actioned

Auto Transfer (Wallet to Vault):
1. Trigger Mechanism:
    1. **APP_LOGIN** check for the balances and threshold value for each wallet,IF more than the threshold and not added to thestack create a UAI and add it to the stack.
    2.  **WALLET_REFESH**, check the same condition

2. UAI Configuration:
    1. Heading: _Auto Transfer for {WALLET_NAME}_
    2. Sub Heading: Auto transfer has been initiated for {WALLET) Please continue.
    4. CTA Configs:
        1. Primary: _Send_
        2. Secondary: _Skip_

3. Indicator Sequence:
    Home Screen (Wallet Tile)

4. UAI Modal:
    1. Details:
        1. Title:
        2. SubTitle:
    2. CTAs:
        1. Register:
        2. Skip:
        3. Cancel:

 5. Reset:  Mark it as actioned

Task Breakdown

[ ] #3835
[ ] #3828
[ ] #3829
[ ] #3830
[ ] #3831
[ ] #3832
[ ] #3833
[ ] #3834
[ ] #3836

Signer (Health Check):
https://xd.adobe.com/view/f1543c84-c25a-4ad6-81ca-1e0c540e956e-a407/screen/dc45f6d5-9cc9-47d9-a93a-735eb859bfd0/specs/
Signer (Registration Check):
https://xd.adobe.com/view/f1543c84-c25a-4ad6-81ca-1e0c540e956e-a407/screen/09f28828-b661-4d05-8717-4dad777502bb/specs/
Recovery Key (Back up and Confirm):
https://xd.adobe.com/view/f1543c84-c25a-4ad6-81ca-1e0c540e956e-a407/screen/59d2a86d-8557-4c55-8dcf-6d4d3bfa02d7/specs/
Auto Transfer (Wallet to Vault):
https://xd.adobe.com/view/f1543c84-c25a-4ad6-81ca-1e0c540e956e-a407/screen/ccbc8902-c589-4b01-9486-7ec374dc32b9/specs/
@ASN-BitHyve content

Verified this issue on keeper app V 1.2.11(381)


[dv/chip] LC_CTRL related chip level coverage

[ ] [cindy] lc_otp_vendor_test_i/o: Move to connectivity test, tied off in open source chip level test.
---> Check if block level checked output from CSR, check if connectivity is done in chip level.
Block level check here: https://github.com/lowRISC/opentitan/blob/master/hw/ip/lc_ctrl/dv/env/lc_ctrl_scoreboard.sv#L163

[ ] lc_otp_program_o.count/program: sparsely encoded. So some of the toggle values are unreachable.
But since we are changing build-seeds to generate different encoding pattern, it is very hard to find the unreachables on the fly.
Are we comfortable to exclude the entire outputs?

[ ] otp_lc_data_i.state/count: same issue as above

[x] [cindy] lc_otp_program_i.err: We have a testbench, but it only forces the value to be 1. Will fix it to release the force.

[ ] kmac_data_i.error: No test currently cover this scenario. Test issue: https://github.com/lowRISC/opentitan/issues/16069

[ ] [cindy] otp_manuf_state_i: design constant, other values can be excluded.

[x] [cindy] hw_rev_o.chip_rev/chip_gen: design constant, can just check connectivity.

FYI @msfschaffner @sriyerg

Are we comfortable to exclude the entire outputs?

This should be OK since we are testing this with life cycle transition tests at the top-level.

The remaining action items above all affect toggle coverage.
Since that is already above 90%, the suggestion is to move this issue to V3/M3.
CC @sriyerg

We decided to merge coverage across nightlies which will have different build constants, which is an M3 task.

Spoke with @vogelpi - unsure if we have time for this.
Discuss later at triage meeting

Discussed in the triage meeting and agreed to place this in Backlog.

@moidx this would be a reason for collecting coverage over time.


Route loader strategy

A better, more flexible approach

I think this is a bit too complicated, since you can always just register your own loader in the DI anyway.

Closed due to inactivity and the fact that this should be handleable via the DI.


SQL Database can't wait on a resource

I'd like to have a SQL Database wait on the SQL server, and in turn have apps wait on that database
var sql = builder.AddSqlServer("Sql").WithHealthCheck();
var db = sql.AddDatabase("Db").WaitFor(sql);

// Yes, I know this isn't an app, but
var app = builder.AddRedis("app").WaitFor(db);

await builder.Build().RunAsync();

This currently doesn't work.  From stepping through the code, the EnvironmentCallbackAnnotation callback never gets executed - presumably because the SQL database is not an executable resource.
For now I can work around this by explicitly adding a health check to the database, but it would feel more natural if we could model this as the DB depending on SQL.  It would also provide clearer hints in the Aspire Dashboard - right now, whilst the DB health checks are running, both SQL Server and the database show as "Running", so it's not entirely clear why the app isn't starting.  If the DB was waiting on SQL, then the DB resoruce would show as "Starting" until the SQL Server health checks pased.
var sql = builder.AddSqlServer("Sql").WithHealthCheck();
var db = sql.AddDatabase("Db").WaitFor(sql).WithHealthCheck();

This isn't possible today because of what you mentioned, we're hacking the environment variable callback to wait on resources. Databases are custom resources that implement IResourceWithConnectionString.
Instead, I can make this work:
var sql = builder.AddSqlServer("Sql").WithHealthCheck();
var db = sql.AddDatabase("Db");

// Yes, I know this isn't an app, but
var app = builder.AddRedis("app").WaitFor(db);

await builder.Build().RunAsync();

Databases have a parent SQL resource, I can find the health check on the parent resource and use that if none is on the child.

It would also provide clearer hints in the Aspire Dashboard - right now, whilst the DB health checks are running, both SQL Server and the database show as "Running", so it's not entirely clear why the app isn't starting. If the DB was waiting on SQL, then the DB resoruce would show as "Starting" until the SQL Server health checks pased.

Agree this would be ideal but that would require changes to the core.

Fixed in https://github.com/davidfowl/WaitForDependenciesAspire/commit/aa9f9d5f3da4b64a0c95f3e160297612f1636f3d. Any resources that wait on the database will automagically use the sql server health check if defined. Nearest health check will win.

Awesome - that looks great.  Will give it a go tomorrow.

Agree this would be ideal but that would require changes to the core.

Understood - I hope this can be improved in future versions, but for now I'm glad the extensibility allows you to get as far as we have.  My remaining moans are really minor things


Update to use new lifecycle method

React has changed their lifecycle methods to this https://reactjs.org/docs/react-component.html. There is a warning being thrown when you are using old lifecycle methods

You can rename the usage of javascript componentWillReceiveProps tojavascript UNSAFE_componentWillReceiveProps to stop the warning but obviously a fix which used a supported lifestyle method (or a refactor to functional code) would be better.


[RT] Bumps everything to .NET 6 and RT 0.7.x

See title. Only issue I can find is UIs being messed up:

Not sure what's going on there.

Cen't reproduce UI issues on my desktop. Wtf?

UI due to net 6 or robust update?


fix: return merkleWhitelist VP as bigint

Summary
Because of incorrect types we were actually returning strings instead of bigints. This became an issue when adding those values together as instead of adding VPs we were concatenating them.
Closes: https://github.com/snapshot-labs/sx-monorepo/issues/492
How to test

Apply following patch to mock address and show VP in the UI on closed proposal.
Go to http://localhost:8080/#/sn:0x071977084d73002fed430d99108da39d241b900099ccc2a4cdcb7d5041d851d2/proposal/15
You should see 110.4 VP (instead of 1.1k).

diff --git a/apps/ui/src/views/Proposal.vue b/apps/ui/src/views/Proposal.vue
index baac6cce..eea11109 100644
--- a/apps/ui/src/views/Proposal.vue
+++ b/apps/ui/src/views/Proposal.vue
@@ -78,7 +78,7 @@ async function getVotingPower() {
       proposal.value.strategies,
       proposal.value.strategies_params,
       proposal.value.space.strategies_parsed_metadata,
-      web3.value.account,
+      '0xeF8305E140ac520225DAf050e2f71d5fBcC543e7',
       {
         at: proposal.value.state === 'pending' ? null : proposal.value.snapshot,
         chainId: proposal.value.space.snapshot_chain_id
@@ -199,12 +199,7 @@ watchEffect(() => {

-

+

             <template v-if="editMode">
               <IH-cursor-click />

@ChaituVR explained this in the original issue, should have specified that it solves computed VP only:

For some reason it show on my vote that my voting power is ~0 NSTR while on the cast your vote section I see 1.1k NSTR.

Looks like you voted before storage proofs were ready (voted on the proposals list) so you only got 1 VP from Whitelist strategy. This would have been improved with vote reason PR (because it shows you confirmation dialog with VP and here it would show it's still pending).


chore(deps): upgrade dependencies

Upgrades project dependencies. See details in workflow run.

Automatically created by projen via the "upgrade-1.x" workflow

⚪ Backport skipped
The pull request was not backported as there were no branches to backport to. If this is a mistake, please apply the desired version labels or run the backport tool manually.
Manual backport
To create the backport manually run:
backport --pr 787

Questions ?
Please refer to the Backport tool documentation


removed repeated word

The word "for" was repeated in line 129

@dowdian : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@dowdian Thank you!

#sign-off


[1x] Bug - Fix InstallPluginCommand to use proper key signatures (#1233)

The public key has changed since the initial release. This PR fixes the
public key and uses the .sig files that are published to the artifacts site for the 1.x branch.

start gradle check


Updated Targets plugin

Updated golang dependencies for the Targets plugin (no functional change)

Let me try that again.


vimPlugins.ranger-vim: Use another ranger.vim

Motivation for this change
I think this one is better, personally. CC @cjpbirkbeck who initially added the current ranger.vim to nixpkgs in #46696. Is this one equal or better for your purposes too?
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[x] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

sadly we won't see another commit from @jD91mzZM2 thus closing


Archived story media feed (archive/reel/day_shells/)

I added "archive/reel/day_shells/" but I cannot get /feed/reels_media/ with "user_ids" ([archiveDay:18014492728127***])
{ 		"timestamp":<PHONE_NUMBER>, 		"media_count": 9, 		"id": "archiveDay:18014492728127***", 		"reel_type": "archive_day_reel", 		"latest_reel_media": 15503425** 	}
{"message": "Invalid reel id list", "status": "fail"}

Also needs : /feed/reels_media/

Hello
we found this issue on this topic
https://github.com/TheM4hd1/SwiftyInsta/issues/25#issuecomment-503646557
We couldn’t still find a way, probably something changes in this endpoint
I can’t give you an exact time, but i’ll work on it.
If you found any solution during this time, let us know


ClipPath not working with Stack and Positioned

Hello @thongdaddy,
I have the same problem. ClipPaths are not displayed when located in Stack > Positioned widgets hierarchy. Do you know how to fix this problem?
Thanks in advance for your reply.
Regards,

@kbups  Sorry I did change user github.
@thongdaddy This is also my github

Hello @thongdaddy,
I have the same problem. ClipPaths are not displayed when located in Stack > Positioned widgets hierarchy. Do you know how to fix this problem?
Thanks in advance for your reply.
Regards,

@kbups Have you solved this issue? I have met the same issue.


Modified Course Manager to adopt a singleton approach.

Coverage increased (+0.009%) to 69.307% when pulling c8a0901b78bf1413f02fb9358ee12575d48f00f4 on m-aslam-mj2:staging into 728aef5ea1681f67c7ee329f35ba72b68fba88b2 on CS2113-AY1819S1-T16-1:master.


parser: add IsTrueWithKeepNull flag

What problem does this PR solve?
https://github.com/pingcap/tidb/pull/19639
What is changed and how it works?
Check List
Tests
Code changes
Side effects
Related changes

Need to cherry-pick to the release branch 3.0,4.0

LGTM


Temperature issue

Hi, the plug-in is great. Really useful. I’m having an issue where the temperature seems to be stuck at 25degC, do you know why that might be?

I'd verify with the blink app directly. sometimes I have found you need to calibrate the device.


Add :focus-ring pseudo-class

Part of CSS Level 4 standard
https://drafts.csswg.org/selectors-4/#the-focusring-pseudo

+1

Duplicate of the now re-opened #3267


[21pt] Fix reach loopback issues for rating curves.

A number of rating curves are showing a sudden drop in discharge value as the stage increases, which is illogical for HAND modeling. Increases in discharge should result in increases in stage level (height). In nature it is technically possible but should not be in HAND. A number, amount to be determined, reaches show this loopback rating curve.  See images and details below.

One example that this behavior can be seen is for HUC 10200203, reach 21490031.  See '/data/previous_fim/fim_3_0_28_1_ms/10200203/hydroTable.csv'.


VENDOREXPERIMENT restoring dependencies with git submodules fails

I created a test project. This project uses a git submodule to add a dependency. Inside that dependency, it is using a git submodule to track its own dependency.
You need GO15VENDOREXPERIMENT=1. go get will error due to the same bug within Go itself. It's fixed on 1.6 branch.
go get github.com/drewwells/godepmodule
go restore ./...

Expects: nothing, successfully restored deps
Actual:
execute: &{Path:/usr/local/go/bin/go Args:[go get -d -v github.com/wellington/go-libsass] Env:[] Dir:. Stdin:<nil> Stdout:github.com/wellington/go-libsass (download)
# cd .; git --git-dir=/Users/drew/src/github.com/wellington/go-libsass/.git submodule update --init --recursive
No submodule mapping found in .gitmodules for path 'libsass-src'
package github.com/wellington/go-libsass: exit status 1
 Stderr:github.com/wellington/go-libsass (download)
# cd .; git --git-dir=/Users/drew/src/github.com/wellington/go-libsass/.git submodule update --init --recursive
No submodule mapping found in .gitmodules for path 'libsass-src'
package github.com/wellington/go-libsass: exit status 1
 ExtraFiles:[] SysProcAttr:<nil> Process:0xc820106200 ProcessState:exit status 1 lookPathErr:<nil> finished:true childFiles:[0xc820030080 0xc820030098 0xc820030098] closeAfterStart:[0xc820030080 0xc820030098] closeAfterWait:[0xc820030090] goroutine:[0x9b510] errch:0xc820018660}
 output: github.com/wellington/go-libsass (download)
# cd .; git --git-dir=/Users/drew/src/github.com/wellington/go-libsass/.git submodule update --init --recursive
No submodule mapping found in .gitmodules for path 'libsass-src'
package github.com/wellington/go-libsass: exit status 1

godep: restore, during download dep: exit status 1
execute: &{Path:/usr/local/go/bin/go Args:[go get -d -v golang.org/x/net/context] Env:[] Dir:. Stdin:<nil> Stdout: Stderr: ExtraFiles:[] SysProcAttr:<nil> Process:0xc820110460 ProcessState:exit status 0 lookPathErr:<nil> finished:true childFiles:[0xc820114008 0xc820114020 0xc820114020] closeAfterStart:[0xc820114008 0xc820114020] closeAfterWait:[0xc820114018] goroutine:[0x9b510] errch:0xc82011a0c0}
 output:

Not sure what is causing this problem. I tried passing only the correct packages, but still got the same error. godep restore -v $(go list -f '{{.ImportPath}}' ./... | grep -v /vendor/).
Calling godep restore ./... a second time succeeds, but the first failure is enough to stop my CI build.

We currently rely on go get, so if it's fixed in go 1.6 (and if we're continuing to rely on get by then) it will be fixed then. Nothing much we can do here aside from re-implement go get, which we may need to do anyway for other reasons. :-( I'm going to leave open for now though as reminder of issues with go get.


Item level permissions broken (dev build)

Category

[X] Bug
[ ] Enhancement

Problem Area
ASP.NET Unit Tests -I get errors context has changed when running tests for transforming between Publishing Site Classic SPO to Modern SPO.
Expected or Desired Behavior
Should work, but getting this error below.
@jansenbe - I am investigating some other issues with transforming from client collecting data atm, just wondering if you have capacity to see if this also breaks in your test rig?
The page doesn't have broken permission inheritance in tests but still get the below errors.
Observed Behavior
ERROR: Summary Message: A critical error occurred - transformation did not complete
	 Source: System.String Transform(SharePointPnP.Modernization.Framework.Publishing.PublishingPageTransformationInformation), Error: The object is used in the context different from the one associated with the object.
ERROR: Stack Trace:    at Microsoft.SharePoint.Client.ClientAction.CheckActionParameterInContext(ClientRuntimeContext context, Object value)
   at Microsoft.SharePoint.Client.ClientAction.CheckActionParametersInContext(ClientRuntimeContext context, Object[] values)
   at Microsoft.SharePoint.Client.ObjectPathMethod..ctor(ClientRuntimeContext context, ObjectPath parent, String methodName, Object[] parameters)
   at Microsoft.SharePoint.Client.RoleAssignmentCollection.Add(Principal principal, RoleDefinitionBindingCollection roleBindings)
   at SharePointPnP.Modernization.Framework.Transform.BasePageTransformator.ApplyItemLevelPermissions(Boolean hasTargetContext, ListItem item, ListItemPermission lip, Boolean alwaysBreakItemLevelPermissions) in C:\Git\contrib\capa-sp-dev-modern\Tools\SharePoint.Modernization\SharePointPnP.Modernization.Framework\Transform\BasePageTransformator.cs:line 217
   at SharePointPnP.Modernization.Framework.Publishing.PublishingPageTransformator.Transform(PublishingPageTransformationInformation publishingPageTransformationInformation) in C:\Git\contrib\capa-sp-dev-modern\Tools\SharePoint.Modernization\SharePointPnP.Modernization.Framework\Publishing\PublishingPageTransformator.cs:line 492

@pkbullock : Let me test this. So you're testing from publishing portal in SPO to modern site in SPO...right?

Yeap, in my reproduction of the other issues the unit tests were failing at this point, just want to make sure that I haven’t introduced a bug.
Get Outlook for iOShttps://aka.ms/o0ukef

From: Bert Jansen<EMAIL_ADDRESS>Sent: Thursday, July 25, 2019 10:18:01 AM
To: SharePoint/sp-dev-modernization<EMAIL_ADDRESS>Cc: Paul Bullock<EMAIL_ADDRESS>Mention<EMAIL_ADDRESS>Subject: Re: [SharePoint/sp-dev-modernization] Item level permissions broken (dev build) (#212)
@pkbullockhttps://eur02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fpkbullock&data=02|01|paul.bullock%40capacreative.co.uk|87e893635d844e6273ad08d710e0fe8d|b65b38dfdc4640ca92b9547172742753|0|0|636996430843950371&sdata=pdCbDTnUDzmBLH747xmY3I9SDQS%2BqXnuLis2%2FFlhVhQ%3D&reserved=0 : Let me test this. So you're testing from publishing portal in SPO to modern site in SPO...right?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://eur02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FSharePoint%2Fsp-dev-modernization%2Fissues%2F212%3Femail_source%3Dnotifications%26email_token%3DACC7Z4NSA7QRIGS5OPDB36TQBFVUTA5CNFSM4IGUEENKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD2Y4MOQ%23issuecomment-514967098&data=02|01|paul.bullock%40capacreative.co.uk|87e893635d844e6273ad08d710e0fe8d|b65b38dfdc4640ca92b9547172742753|0|0|636996430843960366&sdata=1B09Px0mqbi%2FIAhfR3%2BDlqtuUVlRfEbNqv5nQHuuH0w%3D&reserved=0, or mute the threadhttps://eur02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FACC7Z4J26XRCJBVBZGX3I4TQBFVUTANCNFSM4IGUEENA&data=02|01|paul.bullock%40capacreative.co.uk|87e893635d844e6273ad08d710e0fe8d|b65b38dfdc4640ca92b9547172742753|0|0|636996430843960366&sdata=SDMWLLw2gt7ncpugZkz8HgakoaNtzXn0r2miqloPAOY%3D&reserved=0.

I can repro this when there are custom permissions set on the classic publishing page. Will debug and fix.

@pkbullock : Fixed, assume this actually never really worked. The implementation will assign user accounts to the target page, groups are only assigned when the group already exists in the target site collection.


We need to analyze the user search

Problem
We need to analyze every search from every user
Solution

[ ] Create handler on frontend for checking the search query
[ ] After that post it into google analytics

hi @markherringer @nixilla
it seems we already setup the analytics before, but it is using my account
could you provide the analytics ID for your account?
https://blog.hootsuite.com/how-to-set-up-google-analytics/
on the STEP 2
Here is on my analytics

Here is for historic one


Readme updation

**

adding this image in readme make it more attractive please assign me this issue under GSSOC'23

Hello @shraddha761 ,
I would like to solve this issue. Can you please assign me this issue ?

@Anjali2312-Thombare I am not owner of this repo

its currently not needed for website


how do i exec multiple queries as a single query?

I'm using bun with mssql driver, trying to do something simple such as inserting but can't figure out how exactly. Using .Returning("SCOPE_IDENTITY()") doesn't seem to be working properly with mssql.
type Person struct {
  bun.BaseModel `bun:"table:Person,alias:p"`

  PersonID int `bun:"PersonID,pk,autoincrement"`
  Name string `bun:"Name"`
}

// ...

entity := &Person{Name:"John Doe"}
personid := 0
err := db.NewInsert().Model(entity).Scan(context.Background(), &personid) // <-- how do i do that here?

sql that I'm trying to achieve is as below:
INSERT INTO Persons (Name) VALUES ('John Doe'); SELECT SCOPE_IDENTITY()

Hi @qonn! You want to do:
db.NewInsert().Model(entity).Returning("PersonID").Scan(context.Background, &personid)

// Afaik, you could also `.Scan(ctx)`, in which case the ID will be scanned directly into `entity.PersonID`

to get the ID of the newly inserted Person instead of  using scope_identity().
The reason the query wouldn't work correctly is that, in case of MSSQL, .Returning("my_column") appends OUTPUT INSERTED.my_column to the query. Passing something that's not a valid column name would result in a broken SQL statement (i.e. OUTPUT INSERTED.SCOPE_IDENTITY())

Hi @bevzzz, Wonderful! your code example didn't seem to work at first. But I managed to get it working by changing PersonID to INSERTED.PatientID.
So incase if anyone ever stumble upon this problem in the future, here is the working version:
db.NewInsert().Model(entity).Returning("INSERTED.PersonID").Scan(context.Background(), &personid)


Error [ERR_PACKAGE_PATH_NOT_EXPORTED]: No "exports" main defined in /app/node_modules/helia/package.json

Getting error trying to do even basic usage in a node project:
Error [ERR_PACKAGE_PATH_NOT_EXPORTED]: No "exports" main defined in /app/node_modules/helia/package.json
package.json:
....
"dependencies": {
  "@helia/strings": "^1.0.0",
  "helia": "^1.3.2"
  ....

src/lib/ipfs.ts
import { createHelia } from 'helia'
import { strings } from '@helia/strings'

async function addString(text: string) {
    const helia = await createHelia()
    const s = strings(helia)
    const myImmutableAddress = await s.add(text)
    console.log(await s.get(myImmutableAddress))
}

export { stringAdd }

Usage in route:
import express from 'express'
import { addString } from './../lib/ipfs'
const router = express.Router()

router.get('/', async (req, res) => {
    await addString('Test text')
    return res.send(`Test`)
})

Hello, can you please mention the exact steps you took to resolve the issue.
Am facing the same issue
PS: I don't want to install ts-node or any other packages


#1516 introduces loop with "cut" command not found

cos-toolkit version:
master
CPU architecture, OS, and Version:
amd64
Describe the bug
#1516 introduced a loop with cut command not found. System appears to hang until it drops to the rescue prompt.
To Reproduce
Build from latest green amd64 image and attempt to boot.
Expected behavior
Boot normally.
Logs

mount:

Update: I hacked my dracut config to include "cut" and this resolved the problem. Need to add "cut" to initrd or use alternative.

@kcburge thanks much for reporting! We are really sorry you had this issue, this should have never happened as this issue should have been caught by our CI. In fact this raised another issue within our CI setup we are currently fixing in order to prevent something like that to happen again.


Write validation code documentation

In order to help potential contributors and developers of downstream branches of iD, we should add info on how the validation system works to ARCHITECTURE.md.

I'm changing some stuff in #6140, so we can hold off on this

So I added a fair amount about the validation system including issue severities, rules, types, subtypes, and changeset tags. If someone is interested in more details then I'd be happy to write more at a later time.


[Autocomplete] for Voiceover on Mac is reading incorrect labels on any browser

[x] The issue is present in the latest release.
[x] I have searched the issues of this repository and believe that this is not a duplicate.

Current Behavior 😯
Voiceover for Mac is reading the values incorrectly on the  component, after typing characters and triggering the filter. It seems to always read off the same values for after you type in more than one character. After typing in two ore more characters, it sticks with the read labels from typing in one character.
Expected Behavior 🤔
The values should be read correctly, even after typing in multiple characters.
Steps to Reproduce 🕹

Steps:

Use the following example codesandbox: https://codesandbox.io/s/material-ui-issue-with-voiceover-autocomplete-91se7
Enable voiceover, and type in the following: "the dark".
Use the arrow keys to move the cursor down onto the suggestions.
Observe that voiceover is reading it as different values than what is selected.

Context 🔦
I am trying to accomplish a completely a11y website for a client.

Your Environment 🌎

`npx @material-ui/envinfo`
    System:
    OS: macOS 10.15.7
  Binaries:
    Node: 11.10.1 - ~/.nvm/versions/node/v11.10.1/bin/node
    Yarn: Not Found
    npm: 6.14.8 - ~/.nvm/versions/node/v11.10.1/bin/npm
  Browsers:
    Chrome: 87.0.4280.88
    Edge: Not Found
    Firefox: 81.0
    Safari: 14.0
  npmPackages:
    @emotion/styled:  10.0.27
    @material-ui/core: ^4.11.0 => 4.11.0
    @material-ui/icons: ^4.9.1 => 4.9.1
    @material-ui/lab: 4.0.0-alpha.56 => 4.0.0-alpha.56
    @material-ui/styles:  4.10.0
    @material-ui/system:  4.9.14
    @material-ui/types:  5.1.0
    @material-ui/utils:  4.10.2
    @types/react: ^16.9.43 => 16.9.56
    react: ^16.13.1 => 16.14.0
    react-dom: ^16.13.1 => 16.14.0
    styled-components: ^5.2.1 => 5.2.1
    typescript: ^3.9.6 => 3.9.7
```
  Don't forget to mention which browser you used.
  Output from `npx @material-ui/envinfo` goes here.
```

@inform880 Oh wow, this is a good one. I can reproduce it too 🙈. It looks like VoiceOver caches the results per DOM node. What do you think about the following fix?
diff --git a/packages/material-ui/src/useAutocomplete/useAutocomplete.js b/packages/material-ui/src/useAutocomplete/useAutocomplete.js
index a47295e97d..4510f826a4 100644
--- a/packages/material-ui/src/useAutocomplete/useAutocomplete.js
+++ b/packages/material-ui/src/useAutocomplete/useAutocomplete.js
@@ -1005,7 +1005,7 @@ export default function useAutocomplete(props) {
       const disabled = getOptionDisabled ? getOptionDisabled(option) : false;

       return {
-        key: index,
+        key: `${getOptionLabel(option)}-${index}`,
         tabIndex: -1,
         role: 'option',
         id: `${id}-option-${index}`,

Do you want to work on a pull request? :)

Don't we want to remove the index entirely from the key in case these are re-ordered?

@eps1lon From what I understand, having the index in the key means that we are recreating options potentially more often than we might need to. In exchange, we hedge against two options that have the same label but are visually rendered differently. So in the case you are considering, it seems that the worse case is about wasted DOM nodes, but the a11y feature remains intact.

In exchange, we hedge against two options that have the same label but are visually rendered differently.

Why would we do that? It's a mistake.

Why would we do that?

@eps1lon It allows the component to be more versatile. From what I understand it doesn't matter if DOM nodes aren't shared as much as they could have been, at least, we can benchmark the difference once somebody takes on this effort. My assumption is that it's negligible, not worse taking into account.
I think that the best-case scenario would be for us to have a value we can leverage, in which case I think that we can assume uniqueness, maybe it will come with #23708.
Alternatively, we can try to be greedy. We can try to create a new constrain by asking for the label to be unique. Then we can wait and see if it "fly".
diff --git a/packages/material-ui/src/useAutocomplete/useAutocomplete.js b/packages/material-ui/src/useAutocomplete/useAutocomplete.js
index a47295e97d..4510f826a4 100644
--- a/packages/material-ui/src/useAutocomplete/useAutocomplete.js
+++ b/packages/material-ui/src/useAutocomplete/useAutocomplete.js
@@ -1005,7 +1005,7 @@ export default function useAutocomplete(props) {
       const disabled = getOptionDisabled ? getOptionDisabled(option) : false;

       return {
-        key: index,
+        key: getOptionLabel(option),
         tabIndex: -1,
         role: 'option',
         id: `${id}-option-${index}`,

I have a PR up with the most recent suggested fix, and it seems to work. This is my first time contributing to such a big project, any feedback is appreciated.
https://github.com/mui-org/material-ui/pull/24213

@eps1lon It allows the component to be more versatile.

What does this mean?

We can try to create a new constrain by asking for the label to be unique.

Why would you render option with the same label? How would end-users be able to decide which option to choose from?

@eps1lon It allows the component to be more versatile.

What does this mean?

We can try to create a new constrain by asking for the label to be unique.

Why would you render option with the same label? How would end-users be able to decide which option to choose from?

What does this mean?

@eps1lon It means that having unique labels isn't a constraint the Autocomplete enforces. It's possible that some applications have options with identical labels.

How would end-users be able to decide which option to choose from?

Developers can customize how each option is rendered. The notion of "label" was introduced to render a value inside the textbox but it can be bypassed.

How would end-users be able to decide which option to choose from?

Yeah, I agree. Adding this new constraint has the potential to yield a better UX. It's why I called this approach "greedy", which doesn't have a negative connotation, on the contrary, we can try it out, learn, see if we get pushback. Hopefully, we won't.

What does this mean?

@eps1lon It means that having unique labels isn't a constraint the Autocomplete enforces. It's possible that some applications have options with identical labels.

How would end-users be able to decide which option to choose from?

Developers can customize how each option is rendered. The notion of "label" was introduced to render a value inside the textbox but it can be bypassed.

How would end-users be able to decide which option to choose from?

Yeah, I agree. Adding this new constraint has the potential to yield a better UX. It's why I called this approach "greedy", which doesn't have a negative connotation, on the contrary, we can try it out, learn, see if we get pushback. Hopefully, we won't.

The component works (technically, I'm not judging the UX) with duplicates.

Why not?

It's possible that some applications have options with identical labels.

There are infitenitely many possible applications so anything is possible. That isn't an argument for anything.

Developers can customize how each option is rendered. The notion of "label" was introduced to render a value inside the textbox but it can be bypassed.

Should it be bypassed?

I agree, adding this new constraint has the potential to yield a better UX. It's why I called this approach "greedy"

A "greedy" approach is one that yields a better UX? Why do you add this qualifier to your statement when that is literally the whole point of a component library. Why would you use a component library that does not yield a better UX?

The component works (technically, I'm not judging the UX) with duplicates.

Why not?

It's possible that some applications have options with identical labels.

There are infitenitely many possible applications so anything is possible. That isn't an argument for anything.

Developers can customize how each option is rendered. The notion of "label" was introduced to render a value inside the textbox but it can be bypassed.

Should it be bypassed?

I agree, adding this new constraint has the potential to yield a better UX. It's why I called this approach "greedy"

A "greedy" approach is one that yields a better UX? Why do you add this qualifier to your statement when that is literally the whole point of a component library. Why would you use a component library that does not yield a better UX?

Why not?

I think that these two concerns (DX and UX) can be discussed on their own even if interdependent. Improving the two can sometimes be at odds, tradeoffs need to be made.

Should it be bypassed?

In the nominal use case, it seems that we both agree that the answer is no.
In the advanced use cases, I personally don't know the full scope of the valid use cases. Considering one of the biggest pain developers have with the library is customizability (which isn't only about the CSS), I think being able to do such isn't without merit.

Why do you add this qualifier to your statement

The meaning for the adjective I had in mind is "always wanting more". I think that it's healthy for an API to try to impose as many constraints as it can possibly get away with. The more useful constraints an API has, the more valuable properties it can yield in exchange.

Why would you use a component library that does not yield a better UX?

The primary motivation for using a component library is a. saving developers time b. filling the gap of missing design skills (UI & UX) among developers. At least, it's what I think we can conclude from our experience so far. I think that having a pit-of-success for the API to yield a better UX is inside b. I think that at the end of the day, it's all about the developers, they decide what to use.

Why not?

I think that these two concerns (DX and UX) can be discussed on their own even if interdependent. Improving the two can sometimes be at odds, tradeoffs need to be made.

Should it be bypassed?

In the nominal use case, it seems that we both agree that the answer is no.
In the advanced use cases, I personally don't know the full scope of the valid use cases. Considering one of the biggest pain developers have with the library is customizability (which isn't only about the CSS), I think being able to do such isn't without merit.

Why do you add this qualifier to your statement

The meaning for the adjective I had in mind is "always wanting more". I think that it's healthy for an API to try to impose as many constraints as it can possibly get away with. The more useful constraints an API has, the more valuable properties it can yield in exchange.

Why would you use a component library that does not yield a better UX?

The primary motivation for using a component library is a. saving developers time b. filling the gap of missing design skills (UI & UX) among developers. At least, it's what I think we can conclude from our experience so far. I think that having a pit-of-success for the API to yield a better UX is inside b. I think that at the end of the day, it's all about the developers, they decide what to use.


'Could not set up the detector' error

Hi, I am using this plugin with ionic4. It was working fine and suddenly it stops working on a Samsung J1 Ace. 2,33Gb free space. It works on an iPhone.
The phone is connected to internet and has Google Play Services version 19.0.56.
The project has com.google.android.gms:play-services-vision:17.0.2, and there’s an update (version 18.0.1).
My code:
recognizeText(){
this.ocr.recText(OCRSourceType.NORMFILEURL, this.imageData)
.then((res: OCRResult) => {
if(res.foundText){
// DO THINGS
} else {
alert(‘no text’);
}
})
.catch((error: any) => {
console.error(error);
});
}
getPicture(sourceType : PictureSourceType){
this.camera.getPicture({
quality: 100,
destinationType: this.camera.DestinationType.FILE_URI,
sourceType: sourceType,
encodingType: this.camera.EncodingType.JPEG,
mediaType: this.camera.MediaType.PICTURE,
allowEdit: true,
saveToPhotoAlbum: false,
correctOrientation: true
}).then((imageURI) => {
this.imageData = imageURI;
this.recognizeText();
}, (err) => {
console.error(err);
});
}
$ ionic info
`Ionic:
Ionic CLI                     : 5.2.6 (/Users/myuser/.nvm/versions/node/v10.16.3/lib/node_modules/ionic)
Ionic Framework               : @ionic/angular 4.5.0
@angular-devkit/build-angular : 0.13.9
@angular-devkit/schematics    : 7.3.9
@angular/cli                  : 7.3.9
@ionic/angular-toolkit        : 1.5.1
Cordova:
Cordova CLI       : 9.0.0<EMAIL_ADDRESS>Cordova Platforms : android 8.0.0, ios 5.0.1
Cordova Plugins   : cordova-plugin-ionic-keyboard 2.1.3, cordova-plugin-ionic-webview 4.1.0, (and 7 other plugins)
Utility:
cordova-res : 0.6.0
native-run  : 0.2.8
System:
Android SDK Tools : 26.1.1 (/Users/myuser/Library/Android/sdk)
ios-deploy        : 1.9.4
ios-sim           : 8.0.1
NodeJS            : v10.16.3 (/Users/myuser/.nvm/versions/node/v10.16.3/bin/node)
npm               : 6.9.0
OS                : macOS Mojave
Xcode             : Xcode 10.3 Build version 10G8`

Hey @juanpirezsarquis
That is extremely odd. Could you uninstall the app then rebuild / reinstall with the internet on and see if the issue persists? If you are able to reproduce the steps so I can recreate this issue on my end, that would be immensely helpful.
Cheers,
Chris
Neutrinos

I did what you mention @ChrisTomAlx and the issue persists.
I will try on a new project and see what happens.

The same issue.
ionic start mobileOCRtest tabs --cordova
ionic cordova plugin add cordova-plugin-camera
npm install @ionic-native/camera
ionic cordova plugin add cordova-plugin-mobile-ocr
npm install @ionic-native/ocr
Replace the files:
replace.zip
ionic cordova run android
Go to tab2.

Hey @juanpirezsarquis
Can you tell me which version of the plugin you are using ?
It is possible the ionic team updated / haven't updated the plugin on their end, There were a few breaking changes in the last release. This might be why you are seeing this issue. Did you remove and readd plugins or do cordova preapare or cordova platform add <> when this issue first started? Any of these could have changed the plugin version to one that doesn't match the ionic plugin.
Cheers,
Chris
Neutrinos

Also could you refer to issue #16
Looks like the ionic team has made some mistake in the documentation.
Cheers,
Chris
Neutrinos

Hi Chris, thank you for your help.
I don't remember what was the last command before the issue started, but I made a new project from start and has the same issue (https://github.com/NeutrinosPlatform/cordova-plugin-mobile-ocr/issues/18#issuecomment-527941782).
The plugin version is<EMAIL_ADDRESS>and I am aware of issue #16, is not that.

The phone's Google Play Services version is 19.0.56, I think that this could be updated before the issue started.

Okay let me try with both versions of the play services and see if I can reproduce the issue.
Will get back to you soon.
Cheers,
Chris
Neutrinos

According to this there is no 19.0.56 version of the google play services. What is causing the version change of the play services? Is it another plugin or is it a manual change ?
Cheers,
Chris
Neutrinos

I was talking about the version of Google Play Services app installed in the phone. It was updated from Google Play Store automatically. If I uninstall de updates, the app downgrades to version 7 and nothing works (Google Photos, Drive, etc). When updated, the version is 19.0.56.
In my original project, the plugins are:
cordova-plugin-camera 4.0.3 "Camera"
cordova-plugin-device 2.0.2 "Device"
cordova-plugin-file 6.0.2 "File"
cordova-plugin-ionic-keyboard 2.1.3 "cordova-plugin-ionic-keyboard"
cordova-plugin-ionic-webview 4.1.0 "cordova-plugin-ionic-webview"
cordova-plugin-mobile-ocr 3.1.1 "Textocr"
cordova-plugin-splashscreen 5.0.2 "Splashscreen"
cordova-plugin-statusbar 2.4.2 "StatusBar"
cordova-plugin-whitelist 1.3.3 "Whitelist"
Thank you!

Oh I see. I have the same play services app version and I am able to use the plugin with no issues.
If possible could you send over your project folder or atleast reproduce this issue in a new project then send it over? I will test it on my end and see what is causing this issue
Cheers,
Chris
Neutrinos

I also have the same issue on Samsung Galaxy S8 (Android 7.0).
This is a starter with mobile-ocr and camera plugins.
mobileOCRtest.zip
ionic info
Ionic:
Ionic CLI                     : 5.2.7 (/Users/myuser/.nvm/versions/node/v10.16.3/lib/node_modules/ionic)
Ionic Framework               : @ionic/angular 4.9.0
@angular-devkit/build-angular : 0.801.3
@angular-devkit/schematics    : 8.1.3
@angular/cli                  : 8.1.3
@ionic/angular-toolkit        : 2.0.0
Cordova:
Cordova CLI       : 9.0.0<EMAIL_ADDRESS>Cordova Platforms : android 8.0.0
Cordova Plugins   : cordova-plugin-ionic-keyboard 2.2.0, cordova-plugin-ionic-webview 4.1.1, (and 6 other plugins)
Utility:
cordova-res : 0.6.0
native-run  : 0.2.8
System:
Android SDK Tools : 26.1.1 (/Users/myuser/Library/Android/sdk)
NodeJS            : v10.16.3 (/Users/myuser/.nvm/versions/node/v10.16.3/bin/node)
npm               : 6.9.0
OS                : macOS Mojave
Xcode             : Xcode 10.3 Build version 10G8

Running adb logcat
W/DynamiteModule( 4817): Local module descriptor class for com.google.android.gms.vision.ocr not found.
I/DynamiteModule( 4817): Considering local module com.google.android.gms.vision.ocr:0 and remote module com.google.android.gms.vision.ocr:0
E/Vision  ( 4817): Error loading module com.google.android.gms.vision.ocr optional module true: hj: No acceptable module found. Local version is 0 and remote version is 0.
I/Vision  ( 4817): Request download for engine ocr is a no-op because rate limiting
I/Vision  ( 4817): Fallback loading lorry ocr model while waiting for optional module to download.
W/ResourcesManager( 4817): getTopLevelResources: null for user  0
I/Vision  ( 4817): Loading library libocr.so
I/Vision  ( 4817): libocr.so library load status: false
I/Vision  ( 4817): Request download for engine ocr is a no-op because rate limiting
W/CordovaPlugin( 4817): Attempted to send a second callback for ID: Textocr1052557210
W/CordovaPlugin( 4817): Result was: "Error"
W/ActivityManager( 2874): getRunningAppProcesses: caller 10079 does not hold REAL_GET_TASKS; limiting output
W/ResourcesManager( 3735): getTopLevelResources: null for user  0
W/Conscrypt( 3805): 	at com.google.android.gms.org.conscrypt.Platform.setSocketWriteTimeout(:com.google.android.gms<EMAIL_ADDRESS>(020304-262933554):2)
W/Conscrypt( 3805): 	at com.google.android.gms.org.conscrypt.ConscryptFileDescriptorSocket.setSoWriteTimeout(:com.google.android.gms<EMAIL_ADDRESS>(020304-262933554):2)
W/ResourceType( 3735): ResTable_typeSpec entry count inconsistent: given 30, previously 36
W/ResourcesManager( 3735): getTopLevelResources: null for user  0
D/SystemWebChromeClient( 4817): http://localhost/tab2-tab2-module-es2015.js: Line 173 : Could not set up the detector! Try Again!
I/chromium( 4817): [INFO:CONSOLE(173)] "Could not set up the detector! Try Again!", source: http://localhost/tab2-tab2-module-es2015.js (173)
D/ActivityManager( 2874): startService callerProcessName:com.google.android.gms, calleePkgName: com.google.android.gms

Try clearing data in the google services app and see if it helps. Found this solution from here
Cheers,
Chris
Neutrinos

It works.
The first time you use the app, it fails because it is downloading the library. After the download is complete, it works normally.
Thanks for your help and time.


PHP 5.4?

The bundle's composer.json says that the code only works in PHP 5.5+. Is this really the case that it cannot be ran on 5.4 for some objective reason? Not much changed between these versions, if I am not wrong.
It would be good if you changed composer.json to support PHP 5.4 (if that wont break anything, of course).

Ugh. Now I see there are things like ```RouterContext::CLASS`` that will not work in 5.4. Any chance for a workaround?

Yes it possible to downgrade on php5.4 ofc, I don't use advanced feature, only ::class so it ridiculous to keep 5.5 as minimum version for that.
Feel free to send PR.


Support precision touchpad scale zooming

What is the expected behavior?
On systems with precision touchpad, zooming should scale, not reflow, just like Firefox with webpages in recent releases.

Duplicate of #2582

Duplicate of #2582

Oh, yes, did not find that one before, it would be probably a good idea to update it with current details.

Oh, yes, did not find that one before, it would be probably a good idea to update it with current details.


Overview: Layout/Design/CSS Fixes

This issue is for tracking the various areas that will be fixed throughout the product. As part of this work, both Planner and Platform will be touched.
All areas are to be tested on a 1280px wide screen for presentation purposes.
Board View

[x] card highlights
[ ] truncation
[x] column background colors
[x] column borders
[x] assigned user icon sizes
[x] unassigned user icon sizes
[x] tooltip positioning over user/unassigned icons
[x] remove column highlight when drag/drop card - match designs
- [ ] change color of card on drag/drop - match designs
- [ ] fix highlights for target dropdown box (change to blue line) - match designs
cannot match designs due to library limitations-converted to an opaque box
[x] Quick Add to match visuals

Iteration Panel

[ ] tooltip activation
[ ] bottom of titles cut off

List View
Quick Add of Work Item

[x] change type picker to button
[x] fix jumping of quick add bar on selection

Full Add of Work Item

[x] remove description placeholders
[x] remove truncation ellipsis
[x] fix height issues of background

Home Dashboard

[x] Change background color to match color of Board columns
[x] My Work Items card needs alignment fix
[x] Remove 'Create XYZ' from before the '+' in Card headers

Spaces Dashboard

[x] Change background color to match color of Board columns
[x] Remove 'Create XYZ' from before the '+' in Card headers
[x] Codebases card needs alignment fix
[x] My Work Items card needs alignment fix
[x] Stack Reports needs proper empty state to match other cards

Detail Panel

[ ] Assign User dropdown
[ ] Area dropdown
[ ] Iteration Dropdown
[ ] Status dropdown (cursor is incorrect)

Create Space Wizard

[ ] Investigate using medium size modal versus large modal

Can we do hover pop-ups on the icons in these cards on the account homepage and space homepage so the user can get a sense of what the icons are?

Full Add

Quick Add

Cards in Column - Board View

Selected Card in Column - Board View

@mindreeper2420 The arrow on the drop-down for the icons in quick add is pointing up...should be down, right?  Or am I overtired?  Or both?

@Essjaysee Bootstrap uses the up arrow for drop-ups and PatternFly references that, so I went down that rabbit hole :-)

@mindreeper2420 looks like the text on the cards is still justified instead of left aligned here?

@catrobson yes, that is an issue with how the truncation is handled for multi-line items. Once Sukhvir's PR is merged with various fixes, I'm going to take another look at it.

Home Dashboard

Quick Add - Board View

Space Dashboard

Space dashboard - way to decrease the space between top row and second row to be same as space between cards?

Initial PR for Space and Home dashboards filed here: https://github.com/fabric8io/fabric8-ui/pull/1129

Updated Space Dashboard:

Truncation of the list items inside of the cards were broken on 1280px wide screen, but have been remedied with PR https://github.com/fabric8io/fabric8-ui/pull/1144.

Planner update, which includes fixes to the Board view and other visual improvements, can be found here: https://github.com/fabric8io/fabric8-planner/pull/1798.


Multi-context-snippets

Example:
ls.setup_snip_env()

local ms = require("luasnip.extras.multi_snippet").new_multisnippet

ls.add_snippets("all", {
	ms({
		{trig = "a", condition = function(ltc) return ltc ~= "a" end, snippetType = "autosnippet"},
		{trig = "b", condition = function(ltc) return ltc ~= "b" end},
		"c"
	}, {t"a or b"})
}, {
	key = "ab"
})

https://user-images.githubusercontent.com/41961280/219174535-cb570445-c191-41ce-803e-aafbc06f6067.mp4
The main changes/ideas to accomodate this are:

anything inside a table passed to add_snippets is expected to have a function, retrieve_all which returns all "expandable" objects associated with that "addable"

"expandable" objects only have to be able to perform

matches (for match_snippet in snippet_collection)
copy (currently copies the snippet stored in snippet_collection, since we need each of the snippets inserted into the buffer to be unique)
get_docstring (to get docstring shown in completion-engines) and
invalidate (to disable the snippet, but not yet delete it from the collection)

but don't have to be actual snippets, which allows us to point multiple of these "expandables" to just one snippet-object (it just has to be returned on copy)

Missing:

Allow opts (at all, and different ones (maybe only different conditions)). If we allow

Stuff to think about:

current api of ms is not that great, we'd probably want to do some merging of the tables, such that common keys don't have to be repeated. Not sure what's the user-friendliest behaviour here
I also allowed context, the first table passed to s, to contain condition and show_condition. I'd like to make that the default shown in the docs since it makes more sense (conceptually: the first table is for stuff affecting the expansion of the snippet, while the third/[second non-nodes-] table is for stuff affecting the expanded snippet), while still respecting the conditions when set in the opts-table. I'm uncertain whether here, in this new, so-far-unused function, we should also accomodate the conditions when they're set in the opts-table. It would make more sense without knowing too much about the internals ("why does this behave differently from s??"), but would slightly complicate the implementation. Seems better to allow it, but worth thinking about.

Finally:
I think I'll add e88165f not in this PR, but directly to master, since it is completely tangential and I just noticed it while working on this.

Some more changes:
keys common to all contexts can be set in the common-key in the table where
the differen contexts reside.
I believe this is better than

having contexts[1] or contexts[#contexts] be the common table, since this
makes the common table required
merging the tables, such that keys in contexts[2] would be extended by those
in contexts[1], since this seems like it would introduce more cognitive
overhead to use, and would probably include lots of resetting keys to their
defaults.

An example:
ls.setup_snip_env()

local ms = require("luasnip.extras.multi_snippet").new_multisnippet

local first_a = require("luasnip.extras.conditions").make_condition(function(ltc)
	return ltc:sub(1,1) == "a"
end)

ls.add_snippets("all", {
	ms({
		-- this is applied to all of the multiple contexts.
		common = {trig = "a"},
		-- first character not a => autotrigger
		{condition = -first_a, snippetType = "autosnippet"},
		-- otherwise: still allow manual triggering
		{condition = first_a},
		-- override common trigger.
		"c"
	}, {t"a or b"})
}, {
	key = "ab"
})

Also, opts is now passed through. I've thought a bit more about allowing multiple conditions via opts, but it feels wrong, since it's less clear which opts belong to which contexts
ms({"a", "b", {trig="c", hidden = true}}, {<some nodes>}, {{condition = cond_for_a}, {condition = cond_for_b}, {no_condition_for_c = nil}})

OTOH, if we now settle for only a single opts-table (so not a list of opts-tables), it'll be hard to add later :smiling_face_with_tear:

OTOH, if we now settle for only a single opts-table (so not a list of opts-tables), it'll be hard to add later

opts now provides optional argument to the function itself, one of which is the opts-table for all snippets (common_opts).
We can extend this with specific opts later, but I don't think it's important to have right now.

@L3MON4D3 api looks great. I just added a little comment on PR for docs. Sorry for being that late

@L3MON4D3 api looks great. I just added a little comment on PR for docs. Sorry for being that late

Don't worry, thank you for taking a look :D


Create abort download function to stop download

Currently there is no way to prevent the running download. Add some way to stop the downloading.
XHR.abort() can be used to do the trick.

@GrayGalaxy possible to add Pause? (It might be tricky, not a priority, just putting a thought)


Use an e2e plugin to mock no upload capability.

Context

Summary
While we workout https://github.com/google/web-stories-wp/issues/7790 . Create a little plugin to mock upload capabilty is not set.
Relevant Technical Choices

To-do

User-facing changes

Testing Instructions

QA

[ ] This is a non-user-facing change and requires no QA

This PR can be tested by following these steps:

UAT

[ ] UAT should use the same steps as above.

This PR can be tested by following these steps:

Reviews
Does this PR have a security-related impact?

Does this PR change what data or activity we track or use?

Does this PR have a legal-related impact?

Checklist

[ ] This PR addresses an existing issue and I have linked this PR to it in ZenHub
[ ] I have tested this code to the best of my abilities
[ ] I have verified accessibility to the best of my abilities (docs)
[ ] I have verified i18n and l10n (translation, right-to-left layout) to the best of my abilities
[ ] This PR contains automated tests (unit, integration, and/or e2e) to verify the code works as intended (docs)
[ ] I have added documentation where necessary
[ ] I have added a matching Type: XYZ label to the PR

Fixes #

Closing in favor of #7803


Bug(githubactions-golang): GitHub Actions workflow failed with error: Error: Username and password required

Describe the Bug
Test case: GitOps

dtm apply xxx succeeded with NO error
GitHub Actions workflow failed:

/plugin githubactions-golang
/assign @daniel-hutao

There is another point to consider. Currently, DockerHub Username doesn't support passing through configuration files, but uses environment variables, which is unreasonable. I think it can be changed like this:
docker:
  enable: True
  registry:
    type: dockerhub/harbor
    username: NAME
    repository: REPO

/cc @devstream-io/pmc