Feature/edougal/bulk inserter

This pull request introduces a new BulkLoader class to the src/etl/database/bulk_loader.py file. The BulkLoader class is designed to facilitate the bulk insertion of data from a pandas DataFrame into a database table.
Key changes include:

src/etl/database/bulk_loader.py: Added the BulkLoader class, which includes methods for initializing the object and performing bulk inserts. The class uses pyodbc for database connections and pandas for handling data. It also incorporates logging to track the insertion process and handle errors.

This pull request introduces a new FastLoader class in the src/etl/database/fast_loader.py file to facilitate bulk insertion of data into a database. The class includes methods for initializing the loader and performing fast inserts with error handling and logging.
Key additions:

FastLoader class: A new class to handle bulk insertions into a database table, including initialization and insertion methods.
__init__ method: Initializes the FastLoader object with a database connection, schema name, and table name.
fast_insert method: Performs bulk insertion of a DataFrame into the specified table, with support for batching and error handling.

Logging and error handling:

Added logging to track the progress and any errors during the insertion process.


[TypeScript] "error TS2304: Cannot find name 'moment'" when used with "module":"none"

Typescript seems to not be able to resolve the global moment() function when used in a non-module context.
tsc version: 2.1.6
moment version: 2.17.1
Repro (assuming tsc is on your $PATH):
$ mkdir repro && cd repro
$ npm i moment
$ echo 'const now = moment();' > test.ts
$ tsc --module none test.ts
test.ts(1,13): error TS2304: Cannot find name 'moment'.

However, using a module type works as expected:
$ echo 'import * as moment from "moment"; const now = moment();' > test2.ts
$ tsc --module commonjs test2.js

Unfortunately, my project does not use a bundler or module system, so I'm stuck with "module": "none" for now.
Is my only alternative to use something like typings install --save --global dt~moment ?

I'm facing the same problem. It doesn't matter what module type you specify in tsconfig.json. I get the same error as @rossipedia

I reported same issue (https://github.com/moment/moment/issues/3663), but unfortunately it was just closed.

I ended up copying moment.d.ts into my /scripts/app directory and implemented the fix specified in https://github.com/moment/moment/issues/3663#issuecomment-273199291
Hopefully a more permanent fix will make its way into moment.d.ts eventually.

I solved this by specifying "moduleResolution": "node" in my tsconfig. Not sure if this is an option for you guys, but it seems to do the trick.

"moduleResolution": "node" did not fix it for me, unfortunately

@rossipedia Me either.

Would it not help to add export as namespace moment; into d.ts file?
https://github.com/moment/moment/issues/3808

@czb that also did not fix the issue for me, unfortunately :(

I've resolved this using a couple of hacks that others have mentioned around a ton of issues in lots of projects that are having this problem.  Just wrap it up in a custom definition file of your own.  This is using Typescript 2.2.
tsconfig.json
"compilerOptions": {
    "target": "ES5",
    "moduleResolution": "node",
    ...
}

moment.custom.d.ts
import * as _moment from 'moment';
export as namespace moment;
export = _moment;

I'm curious as to why that doesn't work when that code is added directly to moment.d.ts? I can't help but think we're butting into some obscure TypeScript resolution bug, and unfortunately tsc doesn't have a verbose mode (that I know of) that would help pinpoint where things are going wrong.

I think that if you define "module": "none" typescript does not look for d.ts files under the node_modules/moment folder. My experience is that it is only looking under the node_modules/@types folder. So there are basically these options.

Copy moment.d.ts under node_modules/@types/moment
Include /// <reference path="./node_modules/moment/moment.d.ts" /> into your .ts file
Call tsc --typeRoots node_modules test.ts
Put the ./node_modules/moment/moment.d.ts into files section of tsconfig.json

You also need to add export as namespace moment; into the moment.d.ts file.

the Moment team would love any PRs that would fix this, but stay TS 1.x compatible.

I still have yet to find a solution that works at all, but when I do I'll be sure to add a PR

According to #3663 the temporary fix to get it working without any bundler...

Copy moment.d.ts from node_modules/moment/  to node_modules/@types/moment

Change export = moment; in moment.d.ts  to

declare module "moment" {
    export = moment;
}

Rename moment.d.ts to index.d.ts

Just use moment and your editor( in my case vscode ) and tsc shouldn't complain

+1 please fix this

@mtgibbs Where are you putting the moment.custom.d.ts file? Is there any other configuration that needs to happen for your app to find this custom.d.ts file?

@elSteeze
Yeah, I'm adding them to my tsconfig.json.  Here's a scrubbed example:
{
  "compilerOptions": {
    "target": "ES5",
    "moduleResolution": "node",
    "typeRoots": [
      "./node_modules/@types"
    ]
  },
  "compileOnSave": true,
  "exclude": [
    "node_modules",
    "./path/to/typings/**/*.d.ts",
    "./typings"
  ],
  "include": [
    "./path/to/typings/vue.custom.d.ts",
    "./path/to/typings/moment.custom.d.ts",
    "./path/to/src/**/*.ts"
  ]
}

@mtgibbs Hey thanks man! Appreciate the speedy reply. I'll give that a try.

@mtgibbs Sorry for another noob like question, after implementing your solution I started getting editor errors on the moment keyword in my ts code...
'moment' refers to a UMD global, but the current file is a module. Consider adding an import instead
I did some personal research and attempted to implement a solution by rewriting moment.custom.d.ts but unfortunately, that didn't fix my issue.
Sorry, not trying to be one of those pesky dev's who makes everyone else debug their code, I'm a recent grad and I'm new to working with 3rd party libraries in an Angular 2 environment
Here is my updated module.custom.d.ts
declare var moment: any;
declare var module: NodeModule;
interface NodeModule {
    id: string;
}
import * as _moment from 'moment';
export as namespace moment;
export = _moment;

No problem. If you're using Angular 2 you should be on 2.0+ TS. I don't work in Angular so I'm unsure. Mind pasting what you can of your tsconfig.json and I'll take a look after I get back to a real computer.

Sure!
This is my entire tsconfig.es5.json file inside the src directory of my angular 2 module I'm building.
I appreciate the help by the way
{
  "compilerOptions": {
    "declaration": true,
    "module": "es2015",
    "target": "es5",
    "baseUrl": ".",
    "stripInternal": true,
    "emitDecoratorMetadata": true,
    "experimentalDecorators": true,
    "moduleResolution": "node",
    "outDir": "../build",
    "rootDir": ".",
    "lib": [
      "es2015",
      "dom"
    ],
    "skipLibCheck": true,
    "typeRoots": [
      "./node_modules/@types"
    ]
  },
  "compileOnSave": true,
  "exclude": [
    "node_modules",
    "./typings/**/*.d.ts",
    "./typings"
  ],
  "include": [
    "./typings/moment.custom.d.ts",
    "./src/**/*.ts"
  ],
  "angularCompilerOptions": {
    "annotateForClosureCompiler": true,
    "strictMetadataEmit": true,
    "skipTemplateCodegen": true,
    "flatModuleOutFile": "new-version-library.js",
    "flatModuleId": "new-version-library"
  },
  "files": [
    "./index.ts"
  ]
}

What version of TS are you compiling in? You should just be able to import moment at the top without my hack.

@mtgibbs I'm using v2.2, and that's what I thought. Unfortunately, it's not working. I'm almost at the point where I write my own version of the functionality we're taking from momentjs, because I can't seem to get this working.

@elSteeze
Ok, going back here.  I noticed that you said that you've made a custom module.custom.d.ts, but then you refer to my moment.custom.d.ts in your tsconfig.json.  Make sure that you've made moment.custom.d.ts and added it to your compiler, none of that extra stuff that you had declaring it things.  Then make sure that you're referencing it at the top of the file you're wanting to use it in.
/// <reference path="path/to/your/moment.custom.d.ts" />

This should allow you to reference it as a global variable like in my original workaround.

Awesome thank you @mtgibbs ! I really do appreciate the help.
Cheers mate!

This works for me:

comment out // export = moment in the official .d.ts file
add 'node_modules/moment/moment.d.tstotsconfig.json`

Alternately, copy the modified moment.d.ts to a location of your choice and add the path to it in your tsconfig.json
I think the main problem is that when explicitly using "module":"none" in tsconfig.json you can't have any top level import or exports in any libraries. Hence the default moment

you have to first import in component as
import *  as moment from "moment";
it worked well for me

Why don't you fix this issue? It is very important.

Adding "module": "commonjs" fixed it for me

But i have to use "module": "none". Commonjs is not a solution.

If I'm understanding it correctly, this will be resolved with TypeScript 2.9's import types feature, which will allow importing type definitions without affecting the the module / ambient context.

I'm using TS 3.0.1, is this now solved? It doesn't work out of the box at least.

TS 3.0.1 seems to fix this issue (and it's been open for over a year and a half with no traction)

Hi rossipedia,
I am facing same issue in angular-6 project. As per your comments it's resolved in TS 3.0.1 but angular6 CLI doesn't support TypeScript version 3.0.1.
Can you please help to resolve this issue?

Did anyone else also encounter the @types/moment npm package which is just a stub and tells you to use the file that's provided by the normal moment package?
... Why does moment have to differently compared to every other package? This is the reason why this issue exists, and thousands of hours were spent by developers struggling with this.
Sure, @Ciantic's solution works in TS 3.0.1, but I don't have to use something declare var moment: typeof import("moment"); for any of the other packages I'm using.

It doesn't look like Typescript 3.0.1 fix that issue, it looks like it just give us workaround.

it looks like it just give us workaround.

Yup, it's exactly this. This is not an acceptable "fix".
It's only been a day and I just realized that the TS 3.0.1 workaround only imports the moment function, not the namespace/types. So if you want to pass a moment object into a function, this happens:

Please reopen this issue, or better: fix the .d.t.s file.

Specifying the following in tsconfig.json fixed it (typescript 3.3.3 and moment 2.24.0)
{
  "compilerOptions": {
    "module": "commonjs"
  }
}

I'm no longer using moment for much these days, but I'm happy to re-open the issue if it's still valid.

ERROR in src/app/services/get-list.service.ts(22,54): error TS2304: Cannot find                             name '_'.
what is the solution for this??

@nagipogu No solution for that, this issue is for moment.js, please open your issue in underscore.js's Github repository.

I'm running into this issue with latest version of moment with latest version of TS. Does anyone have any successful workaround?

Still not working, the solution for me was to yarn add -W<EMAIL_ADDRESS>When I installed the latest moment version and looked into node_modules/moment/package.json, I saw this: https://github.com/moment/moment/blob/develop/package.json#L29 - but there was no existing directory node_modules/moment/ts3.1-typings, so it's not surprising TS coudln't find it. I think there may be some bug with an installation script (or a package) or so. Yes, we have "module": "esnext" in tsconfig.json.

For me it broke with 2.25.0:
I used pnpm add<EMAIL_ADDRESS>as a temporary workaround.

For me it broke with 2.25.0:
I used pnpm add<EMAIL_ADDRESS>as a temporary workaround.

work good, thank you

For me it broke with 2.25.0:
I used pnpm add<EMAIL_ADDRESS>as a temporary workaround.

Same here added it to : "dependencies" {"moment": "^2.24.0",
}...seems to work thank you.

Downgrading to 2.24.0 also worked for me. Looks like a regression in 2.25.0.

Does 2.25.3 fix your issues?
There are so many different types of situations where Moment.js is used, let alone TS 1.x, TS 2.x, TS 3.x...
I am hesitant to make changes that break any group of these users.
If you think the documentation can be improved, please post at https://github.com/moment/momentjs.com/

Does 2.25.3 fix your issues?

Yes.
Rolled back to 2.24.0 when 2.25.1 failed for me in Angular 9. With 2.25.3 it's back on track again.

Ok, great. I will close for now.
Please re-open (or open a new issue) if you still have concerns.

I lost a lot of time trying to solve a type problem and @oldrich-s comment of include was very useful! Thanks very much.

Would it not help to add export as namespace moment; into the moment.d.ts file?
See: #3808

You shouldn't do that.
Because in case of reinstalling, this will reset to its default.


README: "Adding cron job" is controversial

Hey team,
Reading this: https://github.com/ondrejbartas/sidekiq-cron#adding-cron-job can, and I know it does, incentivise inexperienced developers add calls to Sidekiq::Cron::Job.create directly to their worker classes.
I know it since I saw some doing this.
And this is bad. Although it may pretend to "just work", it'll effectively render performing external, potentially destructive filesystem actions upon Ruby file inclusion, which is bad, bad design. For instance, you run tests or code coverate, worker file gets included and BAM! some files get edited on the filesystem.
I posting this as an issue, not making a pull requst, since I want to exlain it systematically and want us come to a systematic solution.
Options, best to worst:

Remove controversial passage, add a meaningful chapter answering the question "How do I make my worker run every 5 minutes?". Actions: 1, 2, 3...

That's basically what 95% code bashers are looking for. They are not looking for explanations, they look for passage they'll blindly copy and paste. Let's give them one, but let it be a correct one.

Split controversial passage into two, say: "Suppose we have a worker like this: (...)". In order to make it run every 5 minutes, do this and this in a separate file, for example here's a rake task: (...).
Keep controversial passage, supply a warning below it, like "DON'T ADD Job.create TO YOUR WORKER CLASS FILE, THIS IS JUST AN EXAMPLE". This is the worst option since it doesn't give guidance how to achieve the goal correctly. But it could at least make some look for solutions themselves.

Cheers!
Alex

Hello @dadooda
I agree with you.
I suggest correcting the README.md and making a PR.


Updated to work with -rc1-final

Changed Microsoft.Framework namespaces to Microsoft.Extensions
Template matching now uses PathString instead of string
Updated xunit DNX Runner to use -rc1-*
Updated version numbers to -rc1-final

:+1:

Well done!!

Nuget?

When will the nuget be released?


disableAnimation={true} doesn't work for the InputLabel component

[x ] This is a v1.x issue (v0.x is no longer maintained).
[x ] I have searched the issues of this repository and believe that this is not a duplicate.

Expected Behavior

adding disableAnimation={true} to the InputLabel component should prevent the animation.
Current Behavior
animation still occurs.

Steps to Reproduce (for bugs)

Go to https://material-ui.com/demos/selects/
Copy the code for the multiple-select to a Material-Ui React project.
Add 'disableAnimation={true}' to the second Select component.
"npm start" in the command line.

(Can't demonstrate it on codesandebox.io due as I descirbed https://github.com/mui-org/material-ui/issues/11518 )
Your Environment

Windows 10, chrome 66, React 16, Material-Ui 1

@carpben Please provide a full reproduction test case. This would help a lot 👷 .
A live example would be perfect. This codesandbox.io template may be a good starting point.
I have tried your instructions. It's working fine on my end: https://codesandbox.io/s/x3zxypjrww

Assuming "disable Animation" means that the label is supposed to appear above the textbox instead of in the textbox (and then move above it when you focus on the box):
This error is also occurring for me
a) in my own environment
b) in the codesandbox provided by #carben at  https://codesandbox.io/s/x3zxypjrww


Grant Daniel Karlsson reviewer rights

I recommend to add Daniel Karlsson into the reviewers team.
Originally posted by @kruzikh in https://github.com/ehn-dcc-development/ehn-dcc-valuesets/issues/46#issuecomment-1023138015
Handle: danka74

@skounis @ryanbnl Agree to invite Daniel as an outside collaborator? Also agree to give him reviewer rights?

Is he working for one of the MS or EC?
--
Ryan
On Thu, 27 Jan 2022 at 14:14, Meinte Boersma @.***>
wrote:

@skounis https://github.com/skounis @ryanbnl
https://github.com/ryanbnl Agree to invite Daniel as an outside
collaborator? Also agree to give him reviewer rights?
—
Reply to this email directly, view it on GitHub
https://github.com/ehn-dcc-development/ehn-dcc-valuesets/issues/47#issuecomment-1023193597,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AADPLHII5Z6MEG3ZTJNYWITUYFAMLANCNFSM5M53RPEA
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
You are receiving this because you were mentioned.Message ID:
@.***>

Daniel is a member of the semantic subgroup.

Then it's a no brainer, of course he can be added :)
--
Ryan
On Thu, 27 Jan 2022 at 14:20, Hynek @.***> wrote:

Daniel is a member of the semantic subgroup.
—
Reply to this email directly, view it on GitHub
https://github.com/ehn-dcc-development/ehn-dcc-valuesets/issues/47#issuecomment-1023204181,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AADPLHLNPIO45V5PRVCPJHDUYFBDRANCNFSM5M53RPEA
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
You are receiving this because you were mentioned.Message ID:
@.***>

I invited danka74 with “Triage” right which should suffice for reviewing. We can grant more rights at any time.


Fix for #106 Nested dependencies (json field)

Would it be easier to just use data_get instead of splitting out the object vs array access layers? Not sure if that would work but based on previous usage, it might work and be a bit cleaner.


Patch for Windows 10 Anniversary Update

fixes #2
includes a new option "DockMode"
automatically triggers the keyboard tray icon
small refactoring of Open vs OpenUndocked

I will test everything tomorrow, and if nothing is broken i will merge.
In your case this fix resolved issue #2 , and now everything is working as expected?

Yes it works again now. The only thing I experienced are the following two glitches, but I don't know if they existed before as I cannot test it:

switching between two TextBoxes will minimize the OSK
when switching between Docked/Undocked (killing the process after registry update), the OSK will not appear on the first call

no, this is new..
I don't really like this solution, wonder if there is another way around this issue.
And i would like to know what will happen if tray icon is not present? (because you can hide it, and i don't know, maybe it even hidden by default)

Would it be possible for you to give me access to you tablet via TeamViewer tomorrow? I need to at least fix new problems you mentioned. And maybe try and find some other way around this issue.

Sure, I will send you an e-mail with more information. May be I already have an updated version then.

yes, if you could fix it on your own, would be even easier for me)

Hi, I was wondering if the developpement of this patch has been abandoned or if a solution is currently being developped.

This particular pull request does not resolve the issue. It is a good attempt, but it will only work if soft icon is present in the tray. Otherwise nothing will happen. I hope to find a solution for this problem, but i do not currently have a machine where i can reproduce it. And to be honest this project is not in the top of my priorities right now. But if anybody can resolve this issue, i would be very happy)


Masking support in BatchNorm

Keras2 supports masking in its BatchNorm implementation. While Keras3 seems to accept a "mask" param, is it not used anywhere. This seems inconsistent.

Indeed, we should add masking support in the BatchNormalization layer. Is this something you'd be able to open a PR for?

We can close this issue since masking is now supported in BatchNormalization here https://keras.io/api/layers/normalization_layers/batch_normalization/


Feature/breadcrumbs design docs

Related Jira issue: EN-618
Overview
Adds the Breadcrumb design docs
Work carried out

[x] Added the breadcrumb design docs
[x] Added related SVG assets

made some minor edits to the documentation @hxltrhuxze


According to the figure of gpt-3.5, what's wrong with the report?

you'll need to add an array of messages:


add locale/ja.yml

This is very useful gem. I love it.
I added Japanese translation file.
Could you please review it?
If you have any request for me, please contact me.
Thank you for your cooperation in advance.

Same issue as #127. If you two could collaborate on a translation gem for JA. I don't want to put this in the gem where I can't maintain it.

All right. thanks :+1:


bigint_cmp returns RawVal instead of i64

Actually, why is there a bigint_cmp host function separate from the obj_cmp host function? What's the semantic difference here?

@jayz22 Do you know the answer to 👆 ?

@jonjove There is actually no semantic difference between the two. Underneath they both call object.cmp. So you are right. I will remove the bigint_cmp function.

We might like to remove it after https://github.com/stellar/rs-soroban-env/issues/329, since removing it will require bumping the env interface version, which means rebuilding all the examples, which will be easier once all the test vectors are in this repo.


Create a MGIZA wrapper

Done as a separate project, auto-aligner, which wraps sym-GIZA, fast-align and efmaral in a single tool.


Fails with null characters

I have csv like
a,b,c
1,[NUL],3

where NUL is null-byte string ´\0´
trying this with config file
in:
  type: file
  path_prefix: test.csv
  parser:
    type: csv
    stop_on_invalid_record: true
    columns:
    - {name: a, type: string}
    - {name: b, type: string}
    - {name: c, type: string}
out:
  type: stdout

Fails with Too few columns exception on embulk 0.9.7

Hello, @kakoni
Have you ever tried null_string: option?
in:
  type: file
  path_prefix: test.csv
  parser:
    type: csv
    null_string: # <-- here
    stop_on_invalid_record: true
    columns:
    - {name: a, type: string}
    - {name: b, type: string}
    - {name: c, type: string}
out:
  type: stdout

Best regards

Hi @hiroyuki-sato. Yes
I did both
null_string: '\0'

and
null_string:

Hello, @kakoni
It may need to modify the codes.
Could you try the following workaround?

decoder change \0 to NULL.
CSV parse NULL string as NULL.

in:
  type: file
  decoders:
    - type: command
      command: "perl -pe 's/\\0/NULL/g'"
  parser:
    type: csv
    delimiter: ','
    null_string: "NULL"

Note.
I made the sample data with the following command.
ruby -e 'puts "a,b,c"; 1.upto(10){ puts "1,\0,2" }' > sample_01.csv
echo '1,2,3' >> sample_01.csv

in:
  type: file
  path_prefix: csv/sample_
  decoders:
    - type: command
      command: "perl -pe 's/\\0/NULL/g'"
  parser:
    charset: UTF-8
    newline: LF
    type: csv
    delimiter: ','
    quote: '"'
    escape: '"'
    null_string: "NULL"
    trim_if_not_quoted: false
    skip_header_lines: 1
    allow_extra_columns: false
    allow_optional_columns: false
    columns:
    - {name: a, type: long}
    - {name: b, type: string}
    - {name: c, type: string }
filters:
- type: row
  where: b IS NOT NULL
out: {type: stdout}

embulk preview config.yml
+--------+----------+----------+
| a:long | b:string | c:string |
+--------+----------+----------+
|      1 |        2 |        3 |
+--------+----------+----------+

As per the current CSV parser's implementation, \0 is used as a special character, and we have no plans to change that for the time being.

@dmikurube Understood.
Anyway solution proposed by @hiroyuki-sato is quite clever, I didnt know that you could utilize decoders like that.


bug: Latest langchain-experimental support

I'm trying to use the latest langchain-experimental, but only version 0.0.8 of langflow is compatible. Currently version 0.0.38 is the latest, so please add support for it.
ERROR: pip's dependency resolver does not currently take into account all the packages that are installed. This behaviour is the source of the following dependency conflicts.
langflow 0.5.3 requires langchain-experimental<0.0.9,>=0.0.8, but you have langchain-experimental 0.0.38 which is incompatible.

I tried to implement CSV agent as a custom agent. However, the versions are not compatible in Langflow.

We close the issue by confirming that the dependencies have been modified to be compatible with all experimental versions in the latest version.

Hi there : I am also having this issue with CSVAgent ! Was it ever resolved ? Im using 0.6.4 of langflow


Auto-download no longer works

The newest version of Firefox (57) appears to have broken the auto-download image functionality.

Nothing is broken, this functionality was removed.


Defining a different style for a Popover

I have to define a class to a different style bootstrap css?

Remember vue-strap is based on default bootstrap css, if you want to change the style use some theme or your personal styles.

Right. Thank you.


Add CognitoIdentityProvider for Unity

For some reason the CognitoIdentityProvider project is not included for Unity and may help to make User Pools accessible when adding in AWSSDK.Extensions.CognitoAuthentication.

when i call StartWithSrpAuthAsync method in a unity C# script it doesnt return a response, this could be beacause of the fact that is not supported in unity?

@jemgal Did you ever get anywhere with this issue? I'm getting the same result with StartWithSrpAuthAsync() in Unity 2018.2.0f2. No errors, warnings, results, exceptions, the code stops being executed at that line. No way to debug at this point either. I made a couple posts trying to identify the problem at the aws-sdk-net gitter and unity forums

any updates?


Are you able to call subs.subscribe("mySub").stop() ? #28

credit to @haizi-zh

Rebased from master, can only assume https://github.com/kadirahq/subs-manager/pull/66 wasn't merged in because of conflicts. This appears to work perfectly.

any update on this pull request?


bug fixing:the questionmark is lost when logging on and redirecting

Hi Nancy,
This is the fix like what https://github.com/NancyFx/Nancy/issues/1866 said,discard this if you have better way to fix.Thx!

@Tsingbo-Kooboo There's 4 tests failing now. Want to look at them? http://nancy-ci.cloudapp.net/viewLog.html?buildId=2119&buildTypeId=Nancy_Pulls

Several others have mentioned the same on JabbR etc. without filing a bug for it. We'd love to get this bug fixed once and for all, but the tests seem to suggest that the questionmark should be present in the query string. Don't know what's going on.

Ah, I see what's going on. The tests passes a query string containing ? into the request, while the hosts doesn't. So the tests ends up with double %3f. What you could do is just remove the ? from the test query strings.

OK, looks like NancyHandler (the System.Web host) passes the raw Uri.Query to the request, which also should contain the ?. Maybe it's just a matter of normalizing how the query is stored in Url? E.g. make the Query property of url backed by a field and doing
public string Query
{
    get { return this.query; }
    set { this.query = value.TrimStart('?'); }
}

@NancyFx/owners @NancyFx/most-valued-minions What do you think?

I concur.

:+1: for normalizing

@Tsingbo-Kooboo Thanks for providing a potential fix. It turned out to be a deeper problem (how the hosts handles the leading ? in query strings). I sent a PR (#1870) which should solve this problem once and for all. Would you mind trying it out from the CI feed and see if it solves your problem?


[WFLY-12101] Test for EJBCLIENT-335, display host:port on connecting to server error

Issue: https://issues.jboss.org/browse/WFLY-12101
Related Issues: https://issues.jboss.org/browse/EJBCLIENT-335
It depends on the component upgrade https://issues.jboss.org/browse/WFLY-12200
This test verifies that the exception is propagated from the ejb client module to Wildfly, so when Widlfly displays the error "No more destinations are available" you also get the host and port that the ejb client was using to connect, that facilitates the analysis of the problems in the client without looking at the code.

I understand, from the CI runs, that this new test is failing.

@iweiss It will fail until the ejb client is upgraded

@tadamski @chengfang could you please review this PR?

FYI the commit message on the commit is still just showing as "[WFLY-12101] Test for EJBCLIENT-335" - in five years time when someone needs to investigate why this test is failing they won't have any history without manually cross checking.

@darranl sorry, didn't realise, thank you for your comments!

The changes look good.  jboss-ejb-client 4.0.19.Final was released on 2019-06-18, and will be integrated to WildFly with WFLY-12200

retest this please

retest this please


Added: HTML formatter

@dongnhzigexn hey, I'm curious, why did you decide to immediately close the issue? 🙂

Hi @mmozuras, I mistaken to point my target branch to your repo instead of my forked one. This feature basically a fork work from rubocop html formatter. If you are interesting with this feature, I can make another PR.


Proposal: Adjusting Server.xml With Envs

You can vote for this feature. Do you need this?
Adjusting the server.xml connector attributes with envs.
Example:
$ docker run -d -p 80:8090 -p 8091:8091 \
    --name confluence \
    -e "CONFLUENCE_CONNECTOR_PROPERTY1=proxyPort" \
    -e "CONFLUENCE_CONNECTOR_VALUE1=80" \
    -e "CONFLUENCE_CONNECTOR_PROPERTY2=proxyName" \
    -e "CONFLUENCE_CONNECTOR_VALUE2=confluence.example.org" \
    blacklabelops/confluence

Definitely - it would be great to be able to provide the same environment variables as the Jira container... so CONFLUENCE_DATABASE_URL and CONFLUENCE_DB_PASSWORD.

Ditching this feature. No additional gain.


Thanks a lot :)


support letters need to be updated with length of time detained

Bassel Khartabil has been unjustly detained for nearly four months without trial or any legal charges being brought against him.

Ok, looks updated. closing.


Use YALM configuration like Apia

Incorporate this feature to the code base. Most of the job is already done.
partial implementation:
https://gist.github.com/jonaprieto/19d412c6025c4a073716690e36f246e6
yaml:
https://gist.github.com/jonaprieto/d9d8211b63291660dc0883f8e93941f0

This is a better approach to handle Yaml in a general case.
https://gist.github.com/jonaprieto/fa830b8a49fe170d86fbcc27e9e43ff0
but remember that our case must combine three yamls.


IS THERE ANY CHANCE WE CAN CHANGE THE ALL CAPS MENU OPTIONS?

HELLO PEOPLE!
WOULD IT BE ACCEPTABLE IF I SUBMITTED A PULL REQUEST TO CHANGE THE ALL CAPS MENU TO TITLE CASE?
NEED: SANITY
USE CASE: STAYING SANE

🐼

THANK YOU!


Add Bootstrap compiler interview

Adds an interview that compiles bootstrap themes for admin and developers, according to https://suffolklitlab.org/legal-tech-class/docs/practical-guide-docassemble/theming-docassemble/#creating-a-custom-theme-from-source-instead-of-with-a-theme-generator.
Once per server, it installs bootstrap-5.2.3 in the /tmp dir, and then on going through the interview, it will run the css-compile command in the project, returning the standalone CSS file is there were no errors. The users can either upload a SCSS file, or type one directly, if it's shorter, or they want to iterate faster.
Also added to icon to the menu. There are better font-awesome icons (like a bootstrap specific one), but docassemble won't render brand ones correctly, so I'm sticking with a generic but unique file-code for now.
Fixes #73.

FYI, the bootstrap logo issue will be fixed in https://github.com/jhpyle/docassemble/pull/614, which is why I didn't add an image or anything yet. This works though, we can take it out late maybe.

Minor note: the menu label for the bootstrap interview is a bit long. Doesn't matter much now, but if we add more or move it around, we'll have to shorten it or it'll be cut off.

the menu label for the bootstrap interview is a bit long

I know the suggestion was actually to make it longer, but maybe something shorter would be sufficient? For example, some people may not be familiar with Bootstrap or compiling. Custom CSS? Compile CSS? Custom theme? And/or maybe we could reduce the padding in these buttons.

I agree with taking out Compiling, I would guess that more people would recognize Bootstrap over CSS though? Maybe just Custom Bootstrap Theme. Reducing padding would help a bit too.


Same users can be added in a group multiple time

Describe the bug
Add users to a group at once. Again try to add the same users in the same group then we have a 204  status code.
Both endpoints to add members to the group behave in the same way

Adding a single member to a group
Adding multiple members in a single request

Steps to reproduce
Steps to reproduce the behavior:

add users to a group at once

curl --location --request PATCH 'https://localhost:9200/graph/v1.0/groups/bdac72d5-1bfe-42ea-849d-72c52f885980/' \
--header 'Authorization: Basic YWRtaW46YWRtaW4=' \
--header 'Content-Type: application/json' \
--data-raw '{
<EMAIL_ADDRESS>[
        "https://localhost:9200/graph/v1.0/users/4c510ada-c86b-4815-8820-42cdf82c3d51",
        "https://localhost:9200/graph/v1.0/users/058bff95-6708-4fe5-91e4-9ea3d377588b"
    ]
}'

Again add same user to same group

curl --location --request PATCH 'https://localhost:9200/graph/v1.0/groups/bdac72d5-1bfe-42ea-849d-72c52f885980/' \
--header 'Authorization: Basic YWRtaW46YWRtaW4=' \
--header 'Content-Type: application/json' \
--data-raw '{
<EMAIL_ADDRESS>[
        "https://localhost:9200/graph/v1.0/users/4c510ada-c86b-4815-8820-42cdf82c3d51",
        "https://localhost:9200/graph/v1.0/users/058bff95-6708-4fe5-91e4-9ea3d377588b"
    ]
}'

Expected behavior
Some error message should be thrown/
Actual behavior
Gives Http status code 204
Setup
Please describe how you started the server and provide a list of relevant environment variables or configuration files.

OCIS_XXX=somevalue
OCIS_YYY=somevalue
PROXY_XXX=somevalue

Additional context
Add any other context about the problem here.

@ScharfViktor  @kulmann  Is this a bug or feature?

The spec is really clear about the correct behavior here. So we just tried this on the MS Graph APIs, there you get an error:
Status Code: 400
{
    "error": {
        "code": "Request_BadRequest",
        "message": "One or more added object references already exist for the following modified properties: 'members'.",
        "innerError": {
            "date": "2023-03-02T09:01:20",
            "request-id": "5ef365ba-e185-4acb-a980-c15e7fb094fb",
            "client-request-id": "00cac98e-3a83-17cd-98ba-9b7a4775f720"
        }
    }
}

So it's a bug, not a feature. However, likely not a blocker, as long as the user doesn't show up multiple times when listing the members.

This seems to be a duplicate of #5855

Actually I was a bit too quick with closing this as a duplicate. This issue happens when sending the same request twice. The second time the graph service will basically detect that there is nothing to do (both users are already a member of the group) and return a 204. MSGraph otoh treats this as an error and returns a 400.


fixed issue#29 Prevent user selection

Modified Movable.scss

Thanks for the contribution Priyal!

:tada: This PR is included in version 1.2.6 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:

:tada: This PR is included in version 1.3.0-next.2 :tada:
The release is available on:

npm package (@next dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Reduce blink time

https://github.com/google/jetpack-camera-app/assets/125502967/34dbc621-99bf-453c-8c11-5a41d4446379

Looks good, thanks David!


Typo in readme

Hello,
Thanks for this wonderful module that makes it easier to use icons seamlessly in Nuxt.
There is need to fix the typo for icon under the attributes section.

Thank you!


Run TSLint during builds

@illegalprime Is this good to merge now without the changes to Travis?

All good!


Syntax error in manifest.json

I can't update gush using gush core:update, because the http://gushphp.org/manifest.json file has a syntax error (, needed after the sha1)

good catch, my fault will fix now

done, thanks @pierredup for giving a shout about this :+1: :older_man:

I'm now getting the following, but not sure if it's something to do with my local environment or something else

i will take a look
On Thu, Jun 4, 2015 at 9:18 AM Pierre du Plessis<EMAIL_ADDRESS>wrote:

I'm now getting the following, but not sure if it's something to do with
my local environment or something else
[image: screen shot 2015-06-04 at 16 17 34]
https://cloud.githubusercontent.com/assets/144858/7986037/5666a978-0ad5-11e5-9f0a-85f771385ff7.png
—
Reply to this email directly or view it on GitHub
https://github.com/gushphp/gush/issues/456#issuecomment-108911821.

There is no TLS connection possible, gushphp.org has no cert or such.

hmm i wonder what to do in this case, i thought we had it so that the connection was not SSL in this case, until someone generous can get us a certificate. ..

Maybe change the url in the manifest.json to http://gushphp.org/gush.phar (without https) so that the update can work

perhaps this can help @pierredup https://github.com/gushphp/installer
i will fetch from there to deploy from now on


Fix a race in cmd/dockerd/hack.TestHeaderOverrideHack

- What I did
Fixed a race found in #22940
- How I did it
Fixed a thing related to an iterator
- How to verify it
TESTDIRS=cmd/dockerd/hack BUILDFLAGS=-race make test-unit
Signed-off-by: Akihiro Suda<EMAIL_ADDRESS>

LGTM

LGTM 🐯

all 💚 merging

thanks @AkihiroSuda!


Derived datasets: How to deal with typical_input_capacity, electricity_output_capacity?

In the ETE scenario scaling the values of node attributes typical_input_capacity and electricity_output_capacity are never scaled - which seems to be right in most cases, except for the nodes energy_export_electricity, energy_import_electricity and energy_interconnector_imported_electricity.
During the creation of a derived dataset they are, however, scaled - for exactly the above 3 nodes, for which the attributes are set with the gquery AREA(interconnector_capacity).
This leads to differences in the graphs / gquery results produced for a "traditional" scaled scenario and a scenario based on a scaled derived dataset.
Possible solutions:

Deactivate the scaling of the 2 attributes during the creation of a derived dataset.
Pro: Very easy to implement.
Con: Erroneous outcome from old scaling continues with new scaling.

Repair the old scenario scaling, so that the 2 attributes are scaled, but only for the nodes where they are set dynamically from the interconnector_capacity.
Pro: Everything correct.
Cons: a) I have no idea how to find out in ScenarioScaling#scale_graph_dataset! for a node's attribute whether it was dynamically set.
b) The criterion "attribute is set dynamically" might not always be correct for determining whether the attribute needs to be scaled for this node.

cc @grdw

For me this is of lesser priority either way (so option 1 is acceptable). The reasons are that

interconnectors are not that realistic/meaningful for scaled scenarios anyway
the user can decrease the interconnector with the sliders after scaling if needed

interconnectors are not that realistic/meaningful for scaled scenarios anyway

It does, however, seem to influence other gqueries as well.

the user can decrease the interconnector with the sliders after scaling if needed

:+1:

Relates to #80 - although solving that is probably not gonna solve this automatically.

It does, however, seem to influence other gqueries as well.

Which ones? This might tell me if it's important or not.

It does, however, seem to influence other gqueries as well.

Which ones? This might tell me if it's important or not.

https://gist.github.com/ploh/61da97c13fb12559724107eb32095b6e
This is from trial-migrating scenario 530759 (GEA QI (voor)Beeld 2050 V6).
It shows 74 GQueries having different results for the scaled scenario and the scenario based on a newly created derived dataset.
All of these differences disappear when I disable scaling the dynamically-set node attributes  typical_input_capacity and electricity_output_capacity in Atlas.

All of these differences disappear when I disable scaling the dynamically-set node attributes typical_input_capacity and electricity_output_capacity in Atlas.

I think we should not scale the interconnector capacity for now. Make sure to note this in the documentation though!

All of these differences disappear when I disable scaling the dynamically-set node attributes typical_input_capacity and electricity_output_capacity in Atlas.

I think we should not scale the interconnector capacity for now. Make sure to note this in the documentation though!

@ChaelKruip I would suggest to re-enable scaling of the interconnector capacity in Atlas::Scaler, since it gives the more correct solution. The price is some inconsistency with ETE scaled scenarios, but that does not seem to bad a problem anymore: Only Paddepoel is proposed for migration now, and even there it is probably ok if the outcome is a little different from what it is now - especially if it becomes better.

All of these differences disappear when I disable scaling the dynamically-set node attributes typical_input_capacity and electricity_output_capacity in Atlas.

@ChaelKruip I would suggest to re-enable scaling of the interconnector capacity in Atlas::Scaler, since it gives the more correct solution.

I'm confused now... Did your earlier comment say that disabling the scaling of interconnector capacity solved the differences?

All of these differences disappear when I disable scaling the dynamically-set node attributes typical_input_capacity and electricity_output_capacity in Atlas.

@ChaelKruip I would suggest to re-enable scaling of the interconnector capacity in Atlas::Scaler, since it gives the more correct solution.

I'm confused now... Did your earlier comment say that disabling the scaling of interconnector capacity solved the differences?

Yes, that is correct. But I think we should rather aim for correctness of the new system than for zero differences against the old system. And in this case the old system behaves incorrect.

Closing, scaling option has been removed.


Signed Verifiable Credentials

Description
Verifiable credentials are tamper-proof credentials that can be verified cryptographically. A credential is a set of one or more claims made by the same entity (in our case the dataspace participant or the dataspace authority). The IdentityHub is the component that delivers verifiable credentials for a dataspace participant. In the MVD, each participant has an own IdentityHub where its verifiable credentials are stored.
In a dataspace, a participant might present claims signed by different authorities. For example, the claim that a participant is a member of a given dataspace is signed by the dataspace authority, whereas a claim that a participant holds a specific ISO certification is signed by a corresponding certification body.
The dataspace authority is the trust anchor for the MVD. A GAIA-X membership Verifiable Credential signed by external trusted authority (exemplary deployment of a GAIA-X authority with private key and a DID document containing a public key) will be a precondition verified by the dataspace authority for joining the dataspace. Once a participant is accepted into the MVD, a separate dataspace membership Verifiable Credential must be issued for the participant by the dataspace authority.
We will use JSON Web Key format with Elliptic Curve as we will reuse the EDC libraries to manage the decentralised identity (https://github.com/eclipse-dataspaceconnector/DataSpaceConnector/tree/main/extensions/iam/decentralized-identity).
Acceptance Criteria

[ ] Infrastructure to issue and validate verifiable credentials is available
[ ] Certificate infrastructure to be used in MVD is defined and documented in an ADR
[ ] GAIA-X membership Verifiable Credential can be issued by an external authority trusted by dataspace participants and can be verified by the dataspace authority
[ ] MVD Membership verifiable credentials signed by the dataspace authority can be issued and verified by any dataspace participant
[ ] Documentation (ADRs) on how verifiable credentials incl. certificate infrastructure are handled for the MVD

Stories

[ ] #18
[ ] #17
[ ] #151

As decided during the design session I changed the description from:
We will use X.509 certificates (any PKI could be used, X.509 was chosen because of its broad usage).
to
We will use JSON Web Key format with Elliptic Curve as we will reuse the EDC libraries to manage the decentralised identity.


Shadow appearing on both on the wall (correct behaviour) and the other side of wall (incorrect behaviour)

Potentially fixed this by adjusting shadow bias


ENH: add GridSearchCV to _RegCovariance

... for the sake of completeness.

I wish to work on this.How do I start?

before digging into these issues can you build the doc and run all the
tests?

@agramfort might be worth doing this one at the same time as #2687

@dengemann @kingjr @jona-sassenhagen any of you want to work on this in the next month for 0.12? I'll move to 0.13 but feel free to change to 0.12 if someone is up for it

I'll be busy with rerps I hope.

nope

Do we still need this? It has been open for a long time with no action.


Fix version in order to make it work in Ubuntu 14.04

Compiled software is not working in Ubuntu 14.04.
After compilation the masternode can not be changed to running mode.
(Status 2 and no rewards)
Debugging the log helped me to notice that a mismatch of the version was the issue.
Modified the version.h/version.cpp to protocol and version 60027.
Recompiled and tested, after this change the MNs work perfectly and receive the rewards normally.

Already corrected in the main source code tree, therefore I proceed to close my pull request.


Use CmiReference to avoid duplicating TreeLB messages

Closes #2857.

Will be broken until #2862 is merged into master.

Will be broken until #2862 is merged into master.

You could rebase on top of #2862 using the 'chain' app Nitin added.


Javascript formatter is adding spaces  Option Chaining operator, and breaking the syntax.

Does this issue occur when all extensions are disabled?: Yes/No

VS Code Version:  1.74.3
OS Version: Win10

Steps to Reproduce:

create a test.js file
add the following

var a = { b: { c: 1 } };
console.log(JSON.stringify(a?.c));

Save the file - Formatter kicks in and changes the optional chain to

console.log(JSON.stringify(a ? .c));

and breaks the syntax.....

This issue lacks:

mentioning of extension providing formatting edits

disabled all extensions and it save correctly
started removing likely candidate extensions:
es-lint same
ts-lint fixed it!
ts-lint is marked as deprecated in favour of es-lint now...maybe es-lint should warn users - lol

This issue is caused by an extension, please file it with the repository (or contact) the extension has linked in its overview in VS Code or the marketplace for VS Code. See also our issue reporting guidelines. If you don't know which extension is causing the problem, you can run Help: Start extension bisect from the command palette (F1) to help identify the problem extension.
Happy Coding!


protection main view - not showing open positions

main protection shows as if i have no open positions.
checked and i dont see any console error.
tried to refresh several times, but same thing.
(incognito works fine)

@Velua to review the existing spinner system.

seems this is performance related.
will close for now as we are improving the performance.


Revert "Merge pull request #2333 from 2i2c-org/carbonplan-default"

This reverts commit bbb61dce69c2d6fd15753eb007a08c0acee2cbbc, reversing changes made to 1acfd728d84b37f8adb58e2f1d18cac02ffaf3d1.

Rerverting as despite deploying I saw no change in the UX so clearly I don't fully understand how this all hangs together so shouldn't have merged manually


Same table name in different schemas with PostgreSQL

Original author<EMAIL_ADDRESS>(March 14, 2012 03:38:43)
I just started to test activejdbc and I guess I found a bug with postgresql.
I defined a model like this:
@Table("article")
@IdName("aid")
public class Article extends Model
{
}
The problem is, I have 2 tables named article in different schemas. One is in default schema('public') and another is in schema 'audit'. When I use @Table("article"), I can see the model merged the columns from both article tables. The find/get method will succeed but the save method will fail reporting some columns from audit.article don't exist on table 'article'.
If I use @Table("public.article"), activejdbc just simply reports "Failed to retrieve metadata for table: 'public.article'" with all methods.
Original issue: http://code.google.com/p/activejdbc/issues/detail?id=144

Hello,
We have run into an issue because of duplicate table names in different Postgres schemas. Actually, we wouldn't even realize the problem, if not for the "updated_at" functionality. This column is present in one of our tables, but not in the other. And update to the second one failed with an error, because activejdbc tried to update this column.
I tried the solution with system properties that's described above but looks like this functionality is not supported anymore. Is it true? As far as I understood from pull request #196, system properties were replaced with direct schema names in @Table annotation. Unfortunately, this won't work in our case, because we don't know exact schema names at compile time.
I took a look at the code and came up with a solution that would do the job for us, however, I don't know if this will seem reasonable to you.
Column metadata is loaded here: https://github.com/javalite/activejdbc/blob/9f9277ecad035a06c688208e9aea5661f6924242/activejdbc/src/main/java/org/javalite/activejdbc/Registry.java#L168
At this point, we have an open connection. Provided that we use JDBC 4, connection.getSchema() could be called to get the name of the current schema. To avoid this call for lower versions of JDBC, we could use some system property or maybe just check the version. Then this name could be passed to java.sql.DatabaseMetaData#getColumns.
Do you think this solution makes sense?
Thanks in advance for your help. And thanks for creating this wonderful framework, it's really a pleasure to use it :)

@lpld it should be possible to use your suggestion but wrap the call in try/catch like this:
try {
schema = databaseMetaData.getConnection().getSchema();
} catch (Exception ignore) {}
This way, if you have JDBC 4.1,  this call succeeds, and you have a schema. For earlier versions of JDBC you will get an exception, and the schema String stays null, as it is now.
thoughts?

actually, we need to ignore AbstractMethodError, but the rest is true.

@lpld  a fix was pushed to the repo: http://repo.javalite.io/org/javalite/activejdbc/1.4.13-SNAPSHOT/
Give is a spin, see if it works for you.

@ipolevoy thank you!
The fix looks reasonable unless there are JDBC vendors that throw UnsupportedOperationException or some other runtime exception in the implementation of getSchema method. I don't know though if this really can happen. WDYT?
I'm afraid I won't be able to try the fix for the next few days, but when I do, I'll let you know. Thanks.

btw, i looked at the code, and realized that you are catching AbstractMethodError | Exception, so it should be fine in any case

@lpld I started with AbstractMethodError, but older version of PostgreSQL threw some exception, instead of the error, so I added Exception too.

@lpld pull down a snapshot and let me know if it works for you. I will then close  this long running issue

@lpld , I hope it works out for you. Closing...

Sorry, I was on vacation and was not able to check this one before. The fix seems to work for us. Thanks!


[SPARK-8104][SQL] auto alias expressions in analyzer

Currently we auto alias expression in parser. However, during parser phase we don't have enough information to do the right alias. For example, Generator that has more than 1 kind of element need MultiAlias, ExtractValue don't need Alias if it's in middle of a ExtractValue chain.

The tests will fail as we need to fix the complex field order by issue first.  See https://github.com/apache/spark/pull/5659

cc @marmbrus @rxin @chenghao-intel

Merged build triggered.

Merged build started.

Test build #34193 has started for   PR 6647 at commit d471a90.

Test build #34193 has finished for   PR 6647 at commit d471a90.

This patch fails Scala style tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
case class UnresolvedAlias(child: Expression) extends NamedExpression with trees.UnaryNode[Expression]
abstract class ExtractValueWithStruct extends ExtractValue

Merged build finished. Test FAILed.

Merged build triggered.

Merged build started.

Test build #34241 has started for   PR 6647 at commit 13a92da.

Test build #34241 has finished for   PR 6647 at commit 13a92da.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
case class UnresolvedAlias(child: Expression) extends NamedExpression
abstract class ExtractValueWithStruct extends ExtractValue

Merged build finished. Test FAILed.

For DataFrame API, probably we'd better still keep the existed naming pattern, as we don't want to confusing the users when upgrade the spark.

Merged build triggered.

Merged build started.

Test build #34268 has started for   PR 6647 at commit 9f8578e.

Test build #34268 has finished for   PR 6647 at commit 9f8578e.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
class ElementwiseProduct(val scalingVec: Vector) extends VectorTransformer
trait TypeCheckResult
 case class TypeCheckFailure(message: String) extends TypeCheckResult
case class UnresolvedAlias(child: Expression) extends NamedExpression
abstract class ExtractValueWithStruct extends ExtractValue
abstract class UnaryArithmetic extends UnaryExpression
case class UnaryMinus(child: Expression) extends UnaryArithmetic
case class Sqrt(child: Expression) extends UnaryArithmetic
case class Abs(child: Expression) extends UnaryArithmetic
case class BitwiseNot(child: Expression) extends UnaryArithmetic
case class MaxOf(left: Expression, right: Expression) extends BinaryArithmetic
case class MinOf(left: Expression, right: Expression) extends BinaryArithmetic
case class Atan2(left: Expression, right: Expression)
case class Hypot(left: Expression, right: Expression)
case class EqualTo(left: Expression, right: Expression) extends BinaryComparison

Merged build finished. Test FAILed.

Merged build triggered.

Merged build started.

Test build #34353 has started for   PR 6647 at commit 5dcf292.

Test build #34353 has finished for   PR 6647 at commit 5dcf292.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
case class UnresolvedAlias(child: Expression) extends NamedExpression
abstract class ExtractValueWithStruct extends ExtractValue

Merged build finished. Test FAILed.

Merged build triggered.

Merged build started.

Test build #35138 has started for   PR 6647 at commit 02ed8a3.

Test build #35138 has finished for   PR 6647 at commit 02ed8a3.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
case class UnresolvedAlias(child: Expression) extends NamedExpression
abstract class ExtractValueWithStruct extends ExtractValue

Merged build finished. Test FAILed.

Merged build triggered.

Merged build started.

Test build #35226 has started for   PR 6647 at commit 6ac6c0e.

Test build #35226 has finished for   PR 6647 at commit 6ac6c0e.

This patch fails MiMa tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
case class UnresolvedAlias(child: Expression) extends NamedExpression
abstract class ExtractValueWithStruct extends ExtractValue

Merged build finished. Test FAILed.

retest this please.

Merged build triggered.

Merged build started.

Test build #35386 has started for   PR 6647 at commit 6ac6c0e.

Test build #35386 has finished for   PR 6647 at commit 6ac6c0e.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
case class UnresolvedAlias(child: Expression) extends NamedExpression
abstract class ExtractValueWithStruct extends ExtractValue

Merged build finished. Test FAILed.

Merged build triggered.

Merged build started.

Test build #35394 has started for   PR 6647 at commit 3acc43a.

Test build #35394 has finished for   PR 6647 at commit 3acc43a.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
case class UnresolvedAlias(child: Expression) extends NamedExpression
abstract class ExtractValueWithStruct extends ExtractValue

Merged build finished. Test FAILed.

Merged build triggered.

Merged build started.

Test build #35399 has started for   PR 6647 at commit 73a90cb.

Test build #35399 has finished for   PR 6647 at commit 73a90cb.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
case class UnresolvedAlias(child: Expression) extends NamedExpression
abstract class ExtractValueWithStruct extends ExtractValue

Merged build finished. Test FAILed.

Merged build triggered.

Merged build started.

Test build #35407 has started for   PR 6647 at commit 3a66e4b.

Test build #35407 has finished for   PR 6647 at commit 3a66e4b.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
case class UnresolvedAlias(child: Expression) extends NamedExpression
abstract class ExtractValueWithStruct extends ExtractValue

Merged build finished. Test FAILed.

Merged build triggered.

Merged build started.

Test build #35413 has started for   PR 6647 at commit 5b5786d.

Test build #35413 has finished for   PR 6647 at commit 5b5786d.

This patch fails PySpark unit tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
case class UnresolvedAlias(child: Expression) extends NamedExpression
abstract class ExtractValueWithStruct extends ExtractValue

Merged build finished. Test FAILed.

Merged build triggered.

Merged build started.

Test build #35424 has started for   PR 6647 at commit e2fb9e1.

Test build #35424 has finished for   PR 6647 at commit e2fb9e1.

This patch fails Python style tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
case class UnresolvedAlias(child: Expression) extends NamedExpression
abstract class ExtractValueWithStruct extends ExtractValue

Merged build finished. Test FAILed.

Merged build triggered.

Merged build started.

Test build #35432 has started for   PR 6647 at commit be5ee2d.

Test build #35432 has finished for   PR 6647 at commit be5ee2d.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
case class UnresolvedAlias(child: Expression) extends NamedExpression
abstract class ExtractValueWithStruct extends ExtractValue

Merged build finished. Test FAILed.

Merged build triggered.

Merged build started.

Test build #35436 has started for   PR 6647 at commit d464641.

Test build #35436 has finished for   PR 6647 at commit d464641.

This patch fails PySpark unit tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
case class UnresolvedAlias(child: Expression) extends NamedExpression
abstract class ExtractValueWithStruct extends ExtractValue

Merged build finished. Test FAILed.

Merged build triggered.

Merged build started.

Test build #35438 has started for   PR 6647 at commit a0a5401.

Test build #35438 has finished for   PR 6647 at commit a0a5401.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
case class UnresolvedAlias(child: Expression) extends NamedExpression
abstract class ExtractValueWithStruct extends ExtractValue

Merged build finished. Test FAILed.

Merged build triggered.

Merged build started.

Test build #35443 has started for   PR 6647 at commit b048f96.

Test build #35443 has finished for   PR 6647 at commit b048f96.

This patch passes all tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
case class UnresolvedAlias(child: Expression) extends NamedExpression
abstract class ExtractValueWithStruct extends ExtractValue

Merged build finished. Test PASSed.

Merged build triggered.

Merged build started.

Test build #35449 has started for   PR 6647 at commit 552eba4.

Test build #35449 has finished for   PR 6647 at commit 552eba4.

This patch passes all tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
case class UnresolvedAlias(child: Expression) extends NamedExpression
abstract class ExtractValueWithStruct extends ExtractValue

Merged build finished. Test PASSed.

Thanks for cleaning this up.  Merging to master!


The widget seem to be missing titles on left and top

White space is showing in the place where you expect to see the controls.

Thanks for the issue - label generation has been improved in the latest versions. Let us know if the issue persists.


Add SelectedItem property

For few items TabHostView can be used as an alternative to Picker with it's ItemsSource property. Unlike Picker it doesn't have SelectedItem property so we must bind SelectedIndex, take that index and look into the list to retrieve actual Item. For many properties in VM it can produce a lot of boilerplate code.
To make it consistent with other controls containing ItemsSource, it would be nice to have SelectedItem which may be usefull when we bind tabs to list.

Good idea.

Good idea.

Linked to #14


Polygon intersection - unexpected result

Expected behavior and actual behavior.
I have a polygon, and when doing an intersection with iteself, the result is not equal to the same polygon
Steps to reproduce the problem.
Running this:
from shapely.geometry import shape

x = shape(
    {
        "coordinates": [
            [
                [18.133603650419815, 40.46466650013227],
                [18.131371253002584, 40.46011457473489],
                [18.136103935527416, 40.45889161683917],
                [18.138425628841446, 40.46351156318997],
                [18.136907598597702, 40.46595728850892],
                [18.133603650419815, 40.46466650013227],
            ]
        ],
        "type": "Polygon",
    }
)

x_intersection = x.intersection(x)

print(x == x_intersection)
print(x)
print(x_intersection)

and the output is:
False
POLYGON ((18.133603650419815 40.46466650013227, 18.131371253002584 40.46011457473489, 18.136103935527416 40.45889161683917, 18.138425628841446 40.46351156318997, 18.136907598597702 40.46595728850892, 18.133603650419815 40.46466650013227))
POLYGON ((18.133603650419815 40.46466650013227, 18.136907598597702 40.46595728850892, 18.138425628841446 40.46351156318997, 18.136103935527416 40.45889161683917, 18.131371253002584 40.46011457473489, 18.133603650419815 40.46466650013227))

I would expect that x and x_intersection will be the same. I have tried to set the grid_size parameter but it didn't help...
Operating system
Windows 11 Pro
Shapely version and provenance
Shapely 2.0.1 installed from PyPI using pip
(GEOS version: 3.11.1)

It worked! Thanks for the explanation!


Another suggestion:)

Hi,
I think that it would be much bette if You changed textColor attribute to inputClass or something like that. I think that such property may be very helpful.
Besides, you are trying to add a style with textColor even if textColor is not set - and then you get style with color: undefined

Good idea! I'll look into it now


chore(cli): Remove google analytics tracking from CLI

Changes
Removed the Google Analytics tracking from CLI, as firstly it's really not nice to track without at least communicating it and secondly it's also questionable regarding GDPR (tracking without consent).
Personally I definitely do not want every override, build and init in my projects to be tracked.
closes #1090
Checklist

[x] I followed contributing guidelines

I've prepared input for docs, but after internal discussion, we came to conclusion it's not worth it. So I'll paste it just here to clarify our motives. Personally I think it's a pity as stats of usage and product growth is a great team motivator. But if anyone feels that he's rights are violated in any way - no metrics then :)
So the input which will not reach the docs:
Like any other tool, we'd like to know that our project is in use. We need metrics to see project growth and potential areas to improve. However, we're not collecting any personalized data, session tracking or usage statistics by individual entities. Every CLI invocation is not connected to the other one.

What do we collect by Google Analytics is:

- number of `init` invocations - in order to see usage and how many times the project was initialized
- `init` command time invocation - we collect data of that method timing in order to have the ability to improve this timing with proper metrics as a reference
- `components overwrite` - in order to see which components are most often overwritten, it helps us to understand the struggles and provide help with prioritization
- running `dev` command invocation (no additional params) - to see approximately how many developers are using the tool in time, to be able to show some cool stats in future when the project will grow
- running `build` command (no additional params) - to see how many times Shopware PWA was built at all

We're considering to add additional methods for errors tracking or methods invocations timing, to see when CLI/nuxt module is causing some problems and where should we focus our priorities. Google Analytics groups invocations by the Country, but IPs are not stored or tracked by us in any way.
That's it. We **do not** collecting any project names, structures, aby data that would allow us to connect statistics with any specific project/person (no sessions, every invocation is treated as "new user") as it's not our meaning.

Cheers!

Hi Niklas,
thanks for your pull request.
Our assumption was, that everybody would benefit from these statistics as we use them to track down potential bottlenecks within our application, such as:

Most overridden components (indication for improvements)
Init runtime information (to see how it behaves on different environments)

We'd like to point out, that we don't collect any data that will allow us to identify any project, customer, user related data - every tracking event is handled separately and doesn't allow us to draw any cross-references.
However, we agree with your note regarding user consent, even though our license explicitly says, that our product is open source, free of charge and comes without any liability for potential data infringements, we've decided to follow your request.
It doesn't align with our values to silently collect data that people might not be pleased with. We hope you can follow our initial decision making and try to keep the dialog as open as possible!
Thanks for your contribution!
/cc @niklaswolf @andreasemer

@elkmod @patzick
I totally do understand what your motivations were (and I assumed this even before your clarification :) ). I want to point out that I do and did not assume that you were using this for something bad :)
I like your statement

It doesn't align with our values to silently collect data that people might not be pleased with
and I think that corresponds with the general mindset of the whole open source community!

So thanks for treating this seriously and merging this so fast ❤


Spirit box addition

About the Spirit box, when playing solo I believe it is open mic as well.
It's a bit annoying to read this if statement.
if (!this.isOn || this.soundSource.isPlaying || !XRDevice.isPresent && PlayerPrefs.GetInt("localPushToTalkValue") == 0 && (PhotonNetwork.room.PlayerCount > 1 && !GameController.instance.myPlayer.player.pcPushToTalk.isPressingPushToTalk) || GameController.instance.myPlayer.player.isDead)

Also might be useful to add that insurance is 1/2th of the total item cost in amateur difficulty and 1/4th with intermediate. For the other difficulties there is no insurance.

About the Spirit box, when playing solo I believe it is open mic as well.
It's a bit annoying to read this if statement.
if (!this.isOn || this.soundSource.isPlaying || !XRDevice.isPresent && PlayerPrefs.GetInt("localPushToTalkValue") == 0 && (PhotonNetwork.room.PlayerCount > 1 && !GameController.instance.myPlayer.player.pcPushToTalk.isPressingPushToTalk) || GameController.instance.myPlayer.player.isDead)

Yeah, I've updated the Spirit Box section to fix this error.
I'll add in the part about insurance. Thanks!


fix(typing indicator): fix typing indicator when adding new fields to PersistedState

What this PR does 📖

This PR changes how PersistedState is initialized. Previously if the JSON file failed to parse, the Default value would be used for all fields. However, if the JSON file didn't exist, some defaults would be overridden. This PR removes that discrepancy.
This PR also fixes some clippy errors.

Which issue(s) this PR fixes 🔨

Resolve #547

Special notes for reviewers 🗒
Additional comments 🎤

in src/components/main/files/upload/mod.rs, image_thumbnail.as_bytes() doesn't create a correct base64 string. however, a future PR will fix this.


Version of NodeJs to execute

Hi @kysely
I tried to create a nodejs file to run your example.
But looks like the Node version I'm using v8.9.0 is not compatible with ES6 or something like that.
I got the following error
(function (exports, require, module, __filename, __dirname) { import MongoBackup from 'mongodb-atlas-backup';
                                                              ^^^^^^

SyntaxError: Unexpected token import
    at createScript (vm.js:80:10)
    at Object.runInThisContext (vm.js:139:10)
    at Module._compile (module.js:599:28)
    at Object.Module._extensions..js (module.js:646:10)
    at Module.load (module.js:554:32)
    at tryModuleLoad (module.js:497:12)
    at Function.Module._load (module.js:489:3)
    at Function.Module.runMain (module.js:676:10)
    at startup (bootstrap_node.js:187:16)
    at bootstrap_node.js:608:3

Any suggestions, about how to execute your example in command line using node?
Thanks in advance.

Hi @enzolutions
import is a statement from ES6 module syntax that is not natively supported in Node.js yet. You can either use Babel to transpile your code or use the following import instead:
const MongoBackup = require('mongodb-atlas-backup');

Please let me know if that works for you.


Tagging code

We were discussing different ways to make code tagging in Godot in #6371 and, since this idea is a little bit different, I'll make a separate discussion for it.
Why we need code tagging:
As projects grow, you get more and more code you need to manage. It's very likely that you forget about some incomplete, outdated or buggy block of code in some file. Code tagging can help with that, by showing code that needs attention.
How this should work:

By default there should be a list of commonly used tags like [Incomplete], [Needs fixing], [To do] etc.
Users should be able to create their own tags
Tag properties: name, background color
In context menu of highlighted code, there should be [Apply Tag] dropdown menu. After user selects tag from it, background color behind selected lines of code should change to tag color

[Metrics] button on the panel with [Tutorials] and [Classes] could show the window with list of files with tagged code as well as percentage of tagged code in file/project

This approach will need meta data keeping for tags which is hidden but implanted into code. This is not practical IMO. Tags must be written in comments and must be editable with any text editor as well. Thus just a list of user defined words to be highlighted as suggested in https://github.com/godotengine/godot/issues/6371#issuecomment-244493004, is more practical I think.

Still reproducible/relevant in 3.1 master 9ad1800 : there aren't yet support for such functionality.

I think this could be provided as a plugin in the AssetLib. I don't see the demand to have this integrated in the editor (and it's not a regular feature of IDEs AFAIK).

Agreed. This should be done as a plugin. Closing as out of scope.


[Bug] windows - corrosion found no targets in 1 packages

Describe the bug
Hi,
Please help

CMake Error at /flutter_rust_bridge/build/windows/_deps/corrosion-src/cmake/CorrosionGenerator.cmake:287 (message):
Found no targets in 1 packages..
Please keep in mind that corrosion will only import Rust bin targets
orstaticlib or cdylib library targets.The following packages were found
in the Manifest: native
Call Stack (most recent call first):
.../build/windows/_deps/corrosion-src/cmake/Corrosion.cmake:1011 (_generator_add_cargo_targets)
rust.cmake:17 (corrosion_import_crate)
CMakeLists.txt:59 (include)CMake Error at .../build/windows/_deps/corrosion-src/cmake/CorrosionGenerator.cmake:287 (message):
Found no targets in 1 packages..
Please keep in mind that corrosion will only import Rust bin targets
orstaticlib or cdylib library targets.The following packages were found
in the Manifest: native
Call Stack (most recent call first):
.../build/windows/_deps/corrosion-src/cmake/Corrosion.cmake:1011 (_generator_add_cargo_targets)
rust.cmake:17 (corrosion_import_crate)
CMakeLists.txt:59 (include)

Codegen logs with RUST_LOG=debug environment variable
I use basic flutter_rust_bridge_template

To Reproduce
No response
Expected behavior
No response
Generated binding code
No response
OS
No response
Version of flutter_rust_bridge_codegen
No response
Flutter info
No response
Version of clang++
No response
Version of ffigen
No response
Additional context
No response

Hi, this seems like corrosion + rust configuration problem (thus unrelated to frb core indeed). Have you tried the frb_example and the flutter_rust_bridge_template on your machine?

Please keep in mind that corrosion will only import Rust bin targets
orstaticlib or cdylib library targets.The following packages were found

I guess this may because the Cargo.toml needs some modification, e.g. a proper [lib] section.
In addition, you can try v2's flutter_rust_bridge_generate create which automatically setup things.
Without more information, I will close this issue, but feel free to reopen!


Broken Documentation Link

I'm submitting a...

[ ] Regression (a behavior that used to work and stopped working in a new release)
[ ] Bug report
[ ] Performance issue
[ ] Feature request
[x ] Documentation issue or request
[ ] Other... Please describe:

Browser:

[x ] Chrome version 69
[ ] Firefox version XX
[ ] IE version XX
[ ] Edge version XX
[ ] Safari version XX

Library version

Library version: 0.2.3

## Current behavior
The `Library Reference` link on the README.md page is broken.
Directs user to a page with the following text:
```
Error: Cannot load file https://raw.githubusercontent.com/AzureAD/microsoft-authentication-library-for-js/dev/docs/classes/_useragentapplication_.useragentapplication.html
```

## Expected behavior
Expected to be taken to a Web page containing the Library Reference documentation.

## Minimal reproduction of the problem with instructions
From either the [NPM](https://www.npmjs.com/package/msal) or [Github](https://github.com/AzureAD/microsoft-authentication-library-for-js#readme) project pages, click on `Library Reference` link at the top of the README.md document.

PR in progress https://github.com/AzureAD/microsoft-authentication-library-for-js/pull/487

Fixed.


In self hosted/OS, change Audit Log helper text

Currently it states:

It should read:

Audit Logs are not available in our Open Source version. Please contact<EMAIL_ADDRESS>for more information on our licensing options.

Depends on https://github.com/Flagsmith/flagsmith/issues/646, also not sure that audit logs should be enterprise only since it's quite core?


Improve "Open editors" Feature View

Hello, we had an idea to improve the Explorer feature.
When I work on lots of file and I have an enormous workspace, it's difficult to navigate between opened files and folders. The only way I found is the CTRL+P (search file).
I thought that it could be great if you display the "open editors" as a tree view exactly like the workspace explorer (group file by folder).
It should be easier to switch between open files.
Do you think it could be implemented ?

Possible duplicate of #81544

Yes it's exactly the same as #81544!
Thanks I will up it :)


[wip] Created method to add, edit, and remove contributor

Purpose
Allow users to add/remove contributors to nodes in API, view contributor details, and edit permissions and bibliographic status.
Answers https://github.com/CenterForOpenScience/osf.io/issues/3045
Changes
Moved contributor serializer and added contributor detail serializer.
Created special permissions class to determine whether a user can add contributors.
Created another permission class for user to view, edit, and delete individual contributors.
Appended an add contributor option to contributor list page.
Created a user detail page with edit and remove function
Added numerous api-tests
Side effects
Allows users to add, and remove node contributors as well as edit their permission and bibliographic statuses.
Users are added by admins via user id
An admin can remove a user if:

They are not the only admin
They are not the only visible contributor
They are removing a non-admin contributor
A user can remove themselves regardless of admin status providing that they're not the only visible contributor or admin contributor.

An admin can change a users visibility if they are not the only visible contributor
A user can change they're own visibility status from true to false regardless of admin status providing they're the not the only visible contributor
An admin can edit user permissions if they are not eliminating the only admin
A user can change they're own permissions regardless of admin status from 'admin' to 'write' to 'read' but not the other way, providing that they're not the only admin.
JSON
Contributor List
Changes:

Added permissions list field
Added edit contributor link field

Original
{
    "data": [
        {
            "id": "h2pve",
            "fullname": "yarr",
            "given_name": "yarr",
            "middle_name": "",
            "family_name": "",
            "suffix": "",
            "date_registered": "2015-07-12T15:15:36.460000",
            "gravatar_url": "https://secure.gravatar.com/avatar/9d4b9fe9fbb545875c27d974ee5d7523?d=identicon&size=40",
            "employment_institutions": [],
            "educational_institutions": [],
            "social_accounts": {},
            "links": {
                "nodes": {
                    "relation": "http://localhost:8000/v2/users/h2pve/nodes/"
                },
                "html": "http://localhost:5000/h2pve/",
                "self": "http://localhost:8000/v2/users/h2pve/"
            },
            "bibliographic": true,
            "type": "users"
        },
        {
            "id": "zh6ji",
            "fullname": "test",
            "given_name": "test",
            "middle_name": "",
            "family_name": "",
            "suffix": "",
            "date_registered": "2015-06-10T13:31:39.244000",
            "gravatar_url": "https://secure.gravatar.com/avatar/dd46a756faad4727fb679320751f6dea?d=identicon&size=40",
            "employment_institutions": [],
            "educational_institutions": [],
            "social_accounts": {},
            "links": {
                "nodes": {
                    "relation": "http://localhost:8000/v2/users/zh6ji/nodes/"
                },
                "html": "http://localhost:5000/zh6ji/",
                "self": "http://localhost:8000/v2/users/zh6ji/"
            },
            "bibliographic": true,
            "type": "users"
        }
    ],
    "links": {
        "first": null,
        "last": null,
        "prev": null,
        "next": null,
        "meta": {
            "total": 2,
            "per_page": 10
        }
    }
}

Updated
{
    "data": [
        {
            "id": "h2pve",
            "fullname": "yarr",
            "given_name": "yarr",
            "middle_name": "",
            "family_name": "",
            "suffix": "",
            "date_registered": "2015-07-12T15:15:36.460000",
            "gravatar_url": "https://secure.gravatar.com/avatar/9d4b9fe9fbb545875c27d974ee5d7523?d=identicon&size=40",
            "employment_institutions": [],
            "educational_institutions": [],
            "social_accounts": {},
            "links": {
                "nodes": {
                    "relation": "http://localhost:8000/v2/users/h2pve/nodes/"
                },
                "html": "http://localhost:5000/h2pve/",
                "self": "http://localhost:8000/v2/users/h2pve/",
                "edit contributor": "http://localhost:8000/v2/nodes/emdk3/contributors/h2pve/"
            },
            "permissions": [
                "read",
                "write",
                "admin"
            ],
            "bibliographic": true,
            "type": "users"
        },
        {
            "id": "zh6ji",
            "fullname": "test",
            "given_name": "test",
            "middle_name": "",
            "family_name": "",
            "suffix": "",
            "date_registered": "2015-06-10T13:31:39.244000",
            "gravatar_url": "https://secure.gravatar.com/avatar/dd46a756faad4727fb679320751f6dea?d=identicon&size=40",
            "employment_institutions": [],
            "educational_institutions": [],
            "social_accounts": {},
            "links": {
                "nodes": {
                    "relation": "http://localhost:8000/v2/users/zh6ji/nodes/"
                },
                "html": "http://localhost:5000/zh6ji/",
                "self": "http://localhost:8000/v2/users/zh6ji/",
                "edit contributor": "http://localhost:8000/v2/nodes/emdk3/contributors/zh6ji/"
            },
            "permissions": [
                "read",
                "write",
                "admin"
            ],
            "bibliographic": true,
            "type": "users"
        }
    ],
    "links": {
        "first": null,
        "last": null,
        "prev": null,
        "next": null,
        "meta": {
            "total": 2,
            "per_page": 10
        }
    }
}

(New) Contributor Detail Page:
Currently under revision

Nice "To Do" list @PatrickEGorman ! That's a good practice. Thanks.

Thanks.  I copied it off of somebody else because it seemed like a good idea

My apologies for running too many Travis CI tests.  I now know to use [skip ci] in future pull requests

I still have to go through the tests, but consider this a first pass complete. :penguin: There are a couple of big things to fix, and I'll do a more thorough check once you've taken care of those.

Sounds good.  I'll try to get some json samples up here and screenshot the docs today, then go to work on this stuff/ look for other issues tomorrow.

The tests that I see failing are failing incorrectly. If you're doing a request that you are expecting to return with something that's in the 400 or 500 range, you have to tell it expect_errors=True in the request. I didn't check the later ones, but they may be something similar.

I may have misread, so I'm looking a bit closer.

Hmmmm. Okay, that's odd.

It appears that by uncommenting the line, a lot of my previously passing tests fail.  I notice, however that only my tests are failing.  I'll have to look into this more

It appears that by uncommenting the line, a lot of my previously passing tests fail. I notice, however that only my tests are failing. I'll have to look into this more

Documenting discussion with @PatrickEGorman : some of these tests were failing because they changed the object in an API call, but did not fetch the newest data afterwards.
Without DjangoGlobalsMiddleware, they could pass because the API call and the unit test were sharing the same in-memory database cache. So there was no need to get the newest data after the "external" API call was done... but only because, like many old tests, it was relying on a bug.
@PatrickEGorman will use database_object.reload() where appropriate and report back on any remaining test failures.

It might be worth doing a GET on the object and comparing that with the expected value first, then doing the reload() and verifying it's updated in the database, as part of each of these tests.

Spent some time looking things over.  My tests were not looking so good earlier but I fixed them up a lot.  Ready second pass when you are.

ping @lyndsysimon for review. Medium priority.

Closed to create new branch off of develop


page move down or up does not work

title say as it

By not work do you mean nothing happens?
For me it moves up or down by the showamount which I assume was expected behaviour of the person who implemented it.
It has a weird effect when playlist is sliced from beginning and end though. Since the selection is in the middle and the logical page down would be ceiling(showamount / 2) for showamountof odd numbers. Is this what you would expect?
For example:
...
  File10
  File11
->File12
  File13
  File14
...

Would you expect page up and down to always jump to the next file in ...?

Ah I guess I misunderstood, my expectation was that I couldn't see which video to select because the list didn't fit on the screen, so I thought we were going to use pg down to bring that list down, fortunately I solved the problem by changing the size of the font, thank you for the help

Yeah that's an annoying issue. I think maybe I should bring down the default showamount as a quick fix.
There is a duplicate #106 so I'll close this one.

For me, with the last commit it only shows 8 entries instead of 9 by default.

For me, with the last commit it only shows 8 entries instead of 9 by default.

I changed it to count the .... This way the playlist will always be at most showamount lines long. Sometimes it's 1 or 2 less because of the ....


Issues /w Wiki Pages?

It seems there is something going on with the Wiki pages.
Many of them are blank and publicly editable.
These are pages that other resources reference and link to, so I assume they had content at one point.

Hi @micodel, thanks for the issue!
The wiki is maintained by the community. It usually contains articles and instructions that worked for someone in the past, and they decided to share with the community - since it might be useful for other people too. That being said, we don't review any of the articles.
The wiki system keeps its history, so if you think that the content that was there before is still relevant please feel free to bring them back on.
Thanks again!


APIs for WebJobs, Functions, SiteExtensions and Processes

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.
PR information

[x] The title of the PR is clear and informative.
[x] There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
[x] Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
[ ] If applicable, the PR references the bug/issue that it fixes.
[x] Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

[x] I have read the contribution guidelines.
[x] My spec meets the review criteria:

[x] The spec conforms to the Swagger 2.0 specification.
[x] The spec follows the guidelines described in the Swagger checklist document.
[x] Validation tools were run on swagger spec(s) and have all been fixed in this PR.

@EricSten-MSFT,
Thanks for your contribution as a Microsoft full-time employee or intern. You do not need to sign a CLA.
Thanks,
Microsoft Pull Request Bot

@ravbhatnagar new apis, please take a look, thanks!

@veronicagg - I've made the requested changes.  Can you unblock this PR?

@EricSten-MSFT Semantic validation is still failing due to duplicate operatoin IDs: https://travis-ci.org/Azure/azure-rest-api-specs/jobs/265357585#L656 (please check CI and under the "allowed failures section" mode=semantic, PR-only=true.
The AutoRest Linter Azure bot (you can see a message pasted above) indicates there's an increase of errors and warnings introduced by this PR, could you please review the validation tool output? https://travis-ci.org/Azure/azure-rest-api-specs/jobs/265357584#L658
You can also run the linter tool locally using https://marketplace.visualstudio.com/items?itemName=ms-vscode.autorest or running "autorest --validation --azure-validator --message-format=json specification/web/resource-manager/readme.md --tag=package-2016-09"

@EricSten-MSFT since there are new apis added in the PR, ARM team sign-off is required, @ravbhatnagar needs to review and approve. Thanks!

@EricSten-MSFT are these API changes deployed to ARM already?

@veronicagg Update #2 should fix the duplicate operation IDs.
These changes are to simply document existing functionality.  So, uh, yeah, the API changes have been in ARM for a while.

Oh, and about the removed APIs (https://travis-ci.org/Azure/azure-rest-api-specs/jobs/265746191): Upon review, the ".../instance/{instanceId}..." variants of the deployments APIs should not have been exposed.  Only the /slots/{slot} versions should be exposed.

@veronicagg Regarding The AutoRest Linter Azure bot deltas:  These all appear to be R3019 errors, which are on all of the existing APIs.  I'm told it's an artifact of how the Azure Web Apps APIs were created, and is by design.

Thanks @EricSten-MSFT for making the updates.
Need @ravbhatnagar to sign-off on this PR from ARM side.

@jianghaolu thanks for picking up this PR!

Yes.  Each function has its own secrets.
Sent from my Windows Phone

From: Jianghao<EMAIL_ADDRESS>Sent: 8/21/2017 18:23
To<EMAIL_ADDRESS>Cc: Eric<EMAIL_ADDRESS><EMAIL_ADDRESS>Subject: Re: [Azure/azure-rest-api-specs] APIs for WebJobs, Functions, SiteExtensions and Processes (#1551)
@jianghaolu commented on this pull request.

In specification/web/resource-manager/Microsoft.Web/2016-08-01/WebApps.jsonhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FAzure%2Fazure-rest-api-specs%2Fpull%2F1551%23discussion_r134366335&data=02|01|ericsten%40microsoft.com|00a74990e78d464d9d6608d4e8fc747a|72f988bf86f141af91ab2d7cd011db47|1|0|636389618380491477&sdata=RdhHuDLgTG4C4%2F%2BCMJkvwCLgotMnHtOdG3gF6htibGg%3D&reserved=0:

 "type": "object",

 "properties": {

   "value": {

     "description": "Collection of resources.",

     "type": "array",

     "items": {

       "$ref": "#/definitions/FunctionEnvelope"

     }

   },

   "nextLink": {

     "description": "Link to next page of resources.",

     "type": "string"

   }

 }

},
"FunctionSecrets": {

So a function can only have one secret?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FAzure%2Fazure-rest-api-specs%2Fpull%2F1551%23discussion_r134366335&data=02|01|ericsten%40microsoft.com|00a74990e78d464d9d6608d4e8fc747a|72f988bf86f141af91ab2d7cd011db47|1|0|636389618380491477&sdata=RdhHuDLgTG4C4%2F%2BCMJkvwCLgotMnHtOdG3gF6htibGg%3D&reserved=0, or mute the threadhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAaaqjPwwEUykIz_Ui2RX-ZxgN961G2Ojks5sai2qgaJpZM4O5bCd&data=02|01|ericsten%40microsoft.com|00a74990e78d464d9d6608d4e8fc747a|72f988bf86f141af91ab2d7cd011db47|1|0|636389618380491477&sdata=%2BpVrU76x%2FWLGCTE93AkRnOs503lqJW02gV7NLXgQ%2FjQ%3D&reserved=0.

          "$ref": "#/definitions/Object",

We shouldn't really end up with a definition called "object". I will look into Eric's API changes to see why it is generating this definition. It might be returning a json object which gets mis-translated.

Refers to: specification/web/resource-manager/Microsoft.Web/2016-08-01/WebApps.json:16109 in 97237d2. [](commit_id = 97237d25cf84dd759f468b5d2ced668048838d55, deletion_comment = False)

Ping!  I believe I've addressed all the items in the code review.  What is the next step here?

@EricSten-MSFT Thanks for addressing the feedbacks - what about the annotations Navy requested you to add in your RP? Thanks.

@jianghaolu Yes, I've added the annotations.  The current PR version has the right types.

@EricSten-MSFT I left a few more comments where you might have overlooked. I understand the gap between Kudu and ARM and the complexities within - but if we can bridge it then the developers don't have to. Thanks!

@ravbhatnagar @veronicagg All my concerns have been addressed. Is there anything you'd like to add before I merge this?

Thank you!  Let's put this puppy to bed...please merge!

@jianghaolu I've dismissed my review, since I transferred this one to you, thanks for picking it up!

Just checking: Will this be merged in soon?  I have a PM that needs to report that APIs that were Red (undoc'd) are now Green (doc'd).

Looks like pull request 1566 went in, and it required some rather tricky hand-merging.

  But for the sake of expediency, it was just easier to edit the WebApps.json directly.

@jianghaolu And now it appears the hand-merge has broken things.  Hold while I fix things.

@jianghaolu Okay, fixed merge is in.  It's what we generate.  Unfortunately, there's a ton of documentation fixes (adding '.', etc.) that makes the last commit look a little noisy.

@EricSten-MSFT LGTM. Merging.

No modification for AutorestCI/azure-sdk-for-node

 https://github.com/Azure/azure-sdk-for-ruby/pull/941

 https://github.com/Azure/azure-sdk-for-python/pull/1405


Quoted values issue

{"fontFamily": "Open Sans"} becomes font-family: Open Sans;. Should not remove quotes here.

It works though. Valid css.


[Config] 'window_border_placement' unknown

If I am trying to set window_border_placement, Yabai says it doesn't know this setting. Any changes here?
❯ yabai -m config window_border_placement exterior
unknown command 'window_border_placement' for domain 'config'

Big Sur, SIP disabled, recent yabai

There is no option window_border_placement.
All options are in src/messages.c
These are related to border:
#define COMMAND_CONFIG_BORDER                "window_border"
#define COMMAND_CONFIG_BORDER_WIDTH          "window_border_width"
#define COMMAND_CONFIG_BORDER_ACTIVE_COLOR   "active_window_border_color"
#define COMMAND_CONFIG_BORDER_NORMAL_COLOR   "normal_window_border_color"

When was this removed? I cannot read anything in the changelog:
https://github.com/koekeishiya/yabai/blob/master/CHANGELOG.md#210---2019-11-09

It was a part of the old window border system, removed in v3.0.0: https://github.com/koekeishiya/yabai/blob/master/CHANGELOG.md#300---2020-05-01

Are you sure it ever existed?
In yabai? Not chunkwm?

Ok. I will close this for now as it is not supported anymore.


All notifications in Android app

I would love to see an "All notifications" in the Android app (as seen in the web-app)

Ditto. Was just looking for this feature.
As I've added more topics, in order to better organize them, I've found I occasionally need a list of all notifications. This works great on the web app, but missing it on Android is unfortunate.

@wunter8 and I discussed this at length and decided that for now, we will not do it. It's significant effort with very little reward. This may change in the future, but for now we'll punt.
Discussion: https://discord.com/channels/874398661709295626/874398661709295629/989678289054498886