DS-679 Profile view

Jira
https://pegadigitalit.atlassian.net/browse/DS-679
Spawned from: https://pegadigitalit.atlassian.net/browse/DS-590
Summary
Added Profile and Info Section components.
Details

Profile component created to handle user profiles
Info Section component created to handle sections within a user profile
Removes text-align behaviors in Tooltip component to simplify the code and make the behavior more predictable
Misc. docs changes that enhance or re-organize existing docs
Fixes Image element CSS so that when fill prop is used, the image's display is set to block, which removes undesired white space from inline-block

How to test
Run the branch locally and check the Profile and Info Section component docs. There's also a Profile View demo under Pages > User > User Profile, Drupal devs will use this mockup to build out the page. Review it as well.

@danielamorse Need JS help with the Info Section component, convert the JS in index.js to be production ready in info-section.js.
const infoSectionToggleButtons = document.querySelectorAll(
  '.js-bolt-info-section-toggle-button',
);

infoSectionToggleButtons.forEach(button => {
  button.addEventListener('click', e => {
    const el = e.target;
    const isExpanded = el.getAttribute('aria-expanded') === 'true';
    const otherButtons = [...infoSectionToggleButtons].filter(
      button => button !== el,
    );

    if (isExpanded) {
      el.setAttribute('aria-expanded', false);
    } else {
      otherButtons.forEach(el => {
        el.setAttribute('aria-expanded', false);
      });
      el.setAttribute('aria-expanded', true);
    }
  });
});

@danielamorse Need JS help with the Info Section component, convert the JS in index.js to be production ready in info-section.js.

@mikemai2awesome, done in https://github.com/boltdesignsystem/bolt/pull/2383/commits/9c58bf858c259636c5561f26c3189cccdb66312d


idid: init at 2.1.0

Adds a new package idid to nixpkgs.

Motivation for this change
Adds a new package that I wrote and use (it was a script in my personal nix config so far)
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[x] Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[x] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

Notify maintainers
cc @

@ajs124 told me you should package it on hackage ;)

@Lassulus Thanks! I'll try to include it via hackage.


Prometheus version used by Prometheus receiver

Many times we see a valid prometheus scrape config fails when given to collector due to some part of config being either new to the later prometheus versions used by receiver or other way as well. It will be useful to make the prometheus version that receiver has taken dependency on in our docs (as well as a header), so config authors can ensure they are adhering to the config schema as published by the receiver/collector.
Bringing this issue from collector backlog to WG-Prometheus backlog.
https://github.com/open-telemetry/opentelemetry-collector/issues/3732

Can you please clarify other way as well?
Prometheus 2.x has been there for 3 years I think and the configuration should be forward compatible with 2.x releases. Did we miss something on the prometheus side?

@roidelapluie - i meant to say only the first way :). i edited the comment.

Is there a hard dependency on 1.x? E.g. in our use case the required configuration object was added from 2.29 and indeed having the compatibility in the proximity of the latest prometheus release would be very beneficial.

Can a generic comment be added that the user needs to check the version of the Collector that they're using (by checking gomod). This is a partial solution since Prometheus follows its own guidelines for versioning and maintaining backwards compatibility.


Issues with Matter Transmitter/Reciever and frame moving mods

Hi!
I've encountered an issue with mods that add frames (funky locomotion, framez,...)
Placing a Matter Transmitter on frames and move it allows you to connect to a reciever, the animation shows up, but stepping on it does nothing. Replacing works fine.
A Matter Reciever produces the following issue: only the original position remains in the dialing list, the new one does not appear. The position stays in the list, even if the transmitter is removed. So after a while, your list gets crowded with invalid destinations. If a transmitter was connected during movement, you still can use it and land on the original position without a reciever beeing there.

Matter Transmitters and Receivers have internal cached positional information which external block movers cannot update. This is not easy to solve unfortunatelly but for now I will leave this ticket open so that I don't forget about it if I find a solution.

I think the biggest problem is the Matter Reciever remaining in the dialing list. Maybe you could add a refresh button (or auto-refresh) to the list, so it updates the position/remove invalid targets?
Other issues can be solved with replacing the blocks.

There is currently an /rfttp cleanup console command that you can use to clean up invalid receivers. That's half of the solution :-)

This will be fixed in 2.51


[WIP] Improving Page Speed with GraphQL

Hm definitely still a draft on this, but I'm feeling pretty close! Any tips, suggestions, edits would be highly appreciated!

Proselint found issues
_posts/2016-11-02-improving-page-speed-with-graphql.markdown

Line
Message
Severity

22
Minimize your use of corporate catchphrases like this one.
warning

28
Substitute 'damn' every time you're inclined to write 'very;' your editor will delete it and the writing will be just as it should be.
warning

Spell Checker found issues
_posts/2016-11-02-improving-page-speed-with-graphql.markdown

Line
Typo

11
en focused on page speed as a KPI. With so many ways of measuri

26
## Enter GraphQL and JoiQL

28
Our very own [Craig Spaeth](https://twitter.com/craigspa

28
ut of this project is called [JoiQL](http://github.com/muraljs/jo

28
s/joiql). The main purpose of JoiQL is to convert [Joi](http://gi

28
rpose of JoiQL is to convert [Joi](http://github.com/hapijs/joi

30
We already use Joi in Positron so creating a Gra

30
sed endpoint was trivial with JoiQL. Note that while JoiQL is cur

30
l with JoiQL. Note that while JoiQL is currently used in producti

30
elow is an example of how the JoiQL setup works.

74
convert apps that already use Joi with JoiQL. It's less JSON bl

74
pps that already use Joi with JoiQL. It's less JSON blobs to hand

74
handle and we also get a nice Koa 2 style middleware pattern th

74
le and we also get a nice Koa 2 style middleware pattern that

90
ing speed. Just after October 27 we switched over to using Gra

96
r an article, there are up to 5 fetches that can occur. If we

96
response using a client like [Lokka](http://github.com/lokka/lokk

  Generated by :no_entry_sign: danger

This is great.

I'd say a bit what JoiQL is in the post the first time it's mentioned.
Low hanging fruit seems to be hanging a bit late and out of context of the whole GraphQL thing. Maybe it belongs closer to the intro as a pre-requisite for all of this?
mobile articles landing page link is broken, reverse [] and ().
 I would separate and clarify, maybe list out the improvements in a more bullet-like way and simplify the message.
It's not clear what mutations are.
Definitely pay attention to proselint, there're many adjectives and it could use more meat replacing adjectives ;)

Thanks for the feedback! Will update shortly.

https://goo.gl/JBljdR

W00t! This is awesome! Very excited to see this published. Great job!

Oops, forgot about this. I think this is ready to publish! What are the steps @ashfurrow ? Just merge?

Yeah, that's it
and we need a tweet about it


Message pack

SteamDB app page links to a few games using this
https://steamdb.info/app/1781030/
https://steamdb.info/app/1783360/
Brief explanation of the change
Find "msgpack" files.

missing non matching tests


Do not work if the location previously was turn off and we turn on during the app usage

Bug Report
Problem
Something very strange is happening to me, If I run my app (in which I'm using this plugin) directly it doesn't works, but just before launching my app, If I run google maps and locate my self, then run my app again it works without any issue, otherwise it keep falling into error method of  getCurrentPosition method
Command or Code

   this.locationAccuracy.request(this.locationAccuracy.REQUEST_PRIORITY_HIGH_ACCURACY).then(() => {
        Geolocation.getCurrentPosition({ enableHighAccuracy: true }).then(loc => {
          alert('Position detected successfully' + loc.coords.accuracy);
        }).catch(err => {
          alert(err);
        });
      }).catch(deny => {
        alert('You denied the location');
      });

Environment, Platform, Device

Oneplus 3T
Version information

Checklist

[x] I searched for existing GitHub issues
[x] I updated all Cordova tooling to most recent version
[x] I included all the necessary information above

Try
Geolocation.getCurrentPosition(   {      enableHighAccuracy: true,     maximumAge: 0 /* Force the plugin to request the positon  and not use cached positions */   })

Closing as stale.


fix: use cesrnumber when parsing sn in rotate event

So it does the same as the "interact" function. See https://github.com/WebOfTrust/signify-ts/blob/fddaff20f808b9ccfed517b3a38bef3276f99261/src/keri/core/eventing.ts#L533-L537
Closes #220
Also related #138

Accidentally deleted the branch on my fork. Did not intend to close the PR.


Django plans cause error in sqlite3 backend

i have a web app hosted on pythonanywhere.com and i have installed django plans in a virtualenv. my python version is 3.8 and django is 3.2.12. My app and plan section works fine, but recently my app encouter some nasty errors in django and plans as bellow:
Internal Server Error: / Traceback (most recent call last):   File "/home/SocialAI/.virtualenvs/expertenv/lib/python3.8/site-packages/django/core/handlers/exception.py", line 34, in inner     response = get_response(request)   File "/home/SocialAI/.virtualenvs/expertenv/lib/python3.8/site-packages/django/core/handlers/base.py", line 115, in _get_response     response = self.process_exception_by_middleware(e, request)   File "/home/SocialAI/.virtualenvs/expertenv/lib/python3.8/site-packages/django/core/handlers/base.py", line 113, in _get_response     response = wrapped_callback(request, *callback_args, **callback_kwargs)   File "/home/SocialAI/.virtualenvs/expertenv/lib/python3.8/site-packages/django/views/generic/base.py", line 71, in view     return self.dispatch(request, *args, **kwargs)   File "/home/SocialAI/.virtualenvs/expertenv/lib/python3.8/site-packages/django/views/generic/base.py", line 97, in dispatch     return handler(request, *args, **kwargs)   File "/home/SocialAI/.virtualenvs/expertenv/lib/python3.8/site-packages/django/views/generic/list.py", line 157, in get     context = self.get_context_data()   File "/home/SocialAI/.virtualenvs/expertenv/lib/python3.8/site-packages/plans/views.py", line 120, in get_context_data     context['plan_table'] = self.get_plan_table(self.object_list)   File "/home/SocialAI/.virtualenvs/expertenv/lib/python3.8/site-packages/plans/views.py", line 74, in get_plan_table     for plan in plan_list:   File "/home/SocialAI/.virtualenvs/expertenv/lib/python3.8/site-packages/django/db/models/query.py", line 276, in __iter__     self._fetch_all()   File "/home/SocialAI/.virtualenvs/expertenv/lib/python3.8/site-packages/django/db/models/query.py", line 1263, in _fetch_all     self._prefetch_related_objects()   File "/home/SocialAI/.virtualenvs/expertenv/lib/python3.8/site-packages/django/db/models/query.py", line 782, in _prefetch_related_objects     prefetch_related_objects(self._result_cache, *self._prefetch_related_lookups)   File "/home/SocialAI/.virtualenvs/expertenv/lib/python3.8/site-packages/django/db/models/query.py", line 1651, in prefetch_related_objects     obj_list, additional_lookups = prefetch_one_level(obj_list, prefetcher, lookup, level)   File "/home/SocialAI/.virtualenvs/expertenv/lib/python3.8/site-packages/django/db/models/query.py", line 1764, in prefetch_one_level     prefetcher.get_prefetch_queryset(instances, lookup.get_current_queryset(level)))   File "/home/SocialAI/.virtualenvs/expertenv/lib/python3.8/site-packages/django/db/models/fields/related_descriptors.py", line 635, in get_prefetch_queryset     for rel_obj in queryset:   File "/home/SocialAI/.virtualenvs/expertenv/lib/python3.8/site-packages/django/db/models/query.py", line 276, in __iter__     self._fetch_all()   File "/home/SocialAI/.virtualenvs/expertenv/lib/python3.8/site-packages/django/db/models/query.py", line 1261, in _fetch_all     self._result_cache = list(self._iterable_class(self))   File "/home/SocialAI/.virtualenvs/expertenv/lib/python3.8/site-packages/django/db/models/query.py", line 74, in __iter__     for row in compiler.results_iter(results):   File "/home/SocialAI/.virtualenvs/expertenv/lib/python3.8/site-packages/django/db/models/sql/compiler.py", line 1095, in apply_converters     value = converter(value, expression, connection)   File "/home/SocialAI/.virtualenvs/expertenv/lib/python3.8/site-packages/django/db/backends/sqlite3/operations.py", line 286, in converter     return create_decimal(value).quantize(quantize_value, context=expression.output_field.context) decimal.InvalidOperation: [<class 'decimal.InvalidOperation'>]
I post this error in pythonanywhere forum also,but so far no solution found for this issue.

No help!? no any idea or suggestions?!

Finally i found the solution and it was presaved records in database! So by deleting related records in datbase problem solved.
Just enabling "DEBUG=True" in app setting was required to control which data and value passed to functions


MM-13669: Fix stutter on long reaction lists

Summary

This PR resolves an issue where an Emoji Reaction List of over ~12 or so would stutter/jitter when swiping up at the end of the list (as if trying to scroll further).
There are cases where the  onHandlerStateChange function leaves destSnapPoint to be undefined. An edge case which has this outcome is when the user swipes up on the Pan component so far, as to release their touch beyond the safe area. The subsequent swipe will then have the jitter. This PR attempts to cover these scenarios.
Ticket Link

Ticket: https://mattermost.atlassian.net/browse/MM-13669
Fixes:  https://github.com/mattermost/mattermost-server/issues/13028
Checklist

Device Information
This PR was tested on: moto g7 play (Android 9), iPhone 7 (iOS 13.2), iPhone 11 Simulator (iOS 13)
Screenshots

Building app in separate branch.

Successfully building:
https://circleci.com/gh/mattermost/mattermost-mobile/3772
https://circleci.com/gh/mattermost/mattermost-mobile/3771

Artifact links:
https://3772-70265724-gh.circle-artifacts.com/0/~/mattermost-mobile/Mattermost_Beta.apk
https://3771-70265724-gh.circle-artifacts.com/0/~/mattermost-mobile/Mattermost_Beta.ipa

Building app in separate branch.

Successfully building:
https://circleci.com/gh/mattermost/mattermost-mobile/3772
https://circleci.com/gh/mattermost/mattermost-mobile/3771

Artifact links:
https://3772-70265724-gh.circle-artifacts.com/0/~/mattermost-mobile/Mattermost_Beta.apk
https://3771-70265724-gh.circle-artifacts.com/0/~/mattermost-mobile/Mattermost_Beta.ipa

Very cool indeed.


elim-multi-store: only patch loop header phis that we created

There can already be OpPhi instructions in a loop header that
are unrelated to the optimization.  We should not be patching those.
Fixes https://github.com/KhronosGroup/SPIRV-Tools/issues/826

@greg-lunarg Please take a look.

Looks good.

Thanks.
I'll wait for bots to go green.  There was a hiccup on the OSX bot not being able to check out the code, so I restarted the job.


Improved shell task execution result log information, adding process.…

…waitFor() and process.exitValue() information to the original log

Purpose of the pull request
improved for issuse-5469。
 所以没有增加process.waitFor的返回庄家。
Brief change log
Improved shell task execution result log information,
Verify this pull request
This pull request is code cleanup without any test coverage.

Codecov Report

Merging #5691 (3d549ef) into dev (bae047e) will increase coverage by 0.04%.
The diff coverage is 0.00%.

@@             Coverage Diff              @@
##                dev    #5691      +/-   ##
============================================
+ Coverage     45.30%   45.34%   +0.04%
- Complexity     3676     3680       +4
============================================
  Files           607      607
  Lines         24787    24788       +1
  Branches       2803     2803
============================================
+ Hits          11229    11240      +11
+ Misses        12486    12476      -10
  Partials       1072     1072

Impacted Files
Coverage Δ

...er/server/worker/task/AbstractCommandExecutor.java
21.46% <0.00%> (-0.10%)
:arrow_down:

...inscheduler/common/task/sqoop/SqoopParameters.java
74.00% <0.00%> (ø)

...olphinscheduler/plugin/alert/email/MailSender.java
74.30% <0.00%> (+1.38%)
:arrow_up:

...dolphinscheduler/remote/future/ResponseFuture.java
83.05% <0.00%> (+1.69%)
:arrow_up:

...he/dolphinscheduler/common/enums/SqoopJobType.java
88.88% <0.00%> (+88.88%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bae047e...3d549ef. Read the comment docs.


The run() method has been implemented. At first the focus was on

establishing the connection, creating the necessary inputs and outputs for communication with the server. Conditional statements were introduced to determine the question option chosen by the client, and eventually the connection was successfully closed.

The code is correct and it is implementing the exceptions and the functions well. Let's create the main of each project


canal-etcd.yaml linked in docs uses removed config key KUBECONFIG_FILENAME

Expected Behavior
The Install Calico for policy and flannel (aka Canal) for networking documentation asks you to download
https://docs.projectcalico.org/manifests/canal-etcd.yaml and apply it to your cluster with kubectl.
This should install necessary calico-kube-controller and canal-node  replica/daemon sets. The pods should be able to run.
Current Behavior
Everything gets installed in the cluster, but the mentioned pods crash or the readiness/liveness probes fail.
Possible Solution
The cni_network_config template defined in https://docs.projectcalico.org/manifests/canal-etcd.yaml lines 55 ff. uses the removed config key __KUBECONFIG_FILENAME__. See also #4024.
If I replace "/etc/cni/net.d/__KUBECONFIG_FILENAME__" with "__KUBECONFIG_FILEPATH__", everything works as expected.
I am sorry that the information isn't more detailed. I was doing this a couple days ago; don't have the details anymore; and just wanted to post this and the solution to you. Should be a very straightforward affair.

Thanks for the heads up! I've raised a PR to fix.


no attribute 'guess_file_info'

An unexpected error occurred, processing of this file has failed
'module' object has no attribute 'guess_file_info'
I have had this error for a few months.  the script was working before this happened.

had guessit 2 not guessit 1 installed


V0.4 Bernard

closes #156 - Precursor at commandBox
closes #153 - Hover CSS
closes #136 - Menu Bar highlights color
#140 - Collation of GUI Codes with James

Coverage increased (+0.02%) to 89.867% when pulling 4391f86bf6eaac6e4ca9b057ba264c8636b62110 on V0.4-bernard into b027b9ebeb1ad71a30963bc2620ca76914c2e2ae on V0.4.

Coverage decreased (-5.3%) to 84.583% when pulling d4fa383df1ce45816437a4aaf92091511b0f0c10 on V0.4-bernard into b027b9ebeb1ad71a30963bc2620ca76914c2e2ae on V0.4.

Coverage decreased (-5.3%) to 84.583% when pulling f34a5795b0503d8ca88a7511dbe893f80b3f5616 on V0.4-bernard into b027b9ebeb1ad71a30963bc2620ca76914c2e2ae on V0.4.


Smarter completer for strings that are not file paths

Filesystem paths are strings for parameters.  So for any string parameter that doesn't have ValidateSet, tab completion defaults to using the filesystem provider.  For compatibility, we can't ask everyone to decorate parameters that are filesystem paths to indicate they should use the filesystem provider for tab completion.  Instead, we can introduce a new attribute to declare it's NOT a filesystem path so that tab complete doesn't start showing filesystem paths where it isn't appropriate.
Steps to reproduce
Add-Content -Path ./foo.txt -Value # hit tab

Expected behavior
Tab completion here should do nothing as the parameter is any arbitrary string

Actual behavior
Tab completion enumerates files/folders in the current path

Environment data

Name                           Value
----                           -----
PSVersion                      6.2.0-preview.1
PSEdition                      Core
GitCommitId                    6.2.0-preview.1
OS                             Darwin 18.0.0 Darwin Kernel Version 18.0.0: Wed Aug 22 20:13:40 PDT 2018; root:xnu-4903.201.2~1/RELEASE_X86_64
Platform                       Unix
PSCompatibleVersions           {1.0, 2.0, 3.0, 4.0...}
PSRemotingProtocolVersion      2.3
SerializationVersion           <IP_ADDRESS>
WSManStackVersion              3.0

Why use a whole new attribute? I think predefining some behaviours for ArgumentCompleter would be much more extensible.
Param(
    [Parameter(Position = 0)]
    [

^^^ Totally agree with the above.
This to me makes more sense than a new attribute

So for any string parameter that doesn't have ValidateSet, tab completion defaults to using the filesystem provider.

It is fallback. How many we have or can have such fallbacks? My thoughts here is about something like ArgumentCompleter(SuppressFallback = $true)

For compatibility, we can't ask everyone to decorate parameters that are filesystem paths to indicate they should use the filesystem provider for tab completion.

Do we really need the fallback and why?
As minimum I think it would be best practice to do this (to decorate path parameters) for future. We could use ArgumentCompleter(filesystem) for path parameters in the repo.

Problem with that is that would throw an immediate error in earlier versions. Ideally, I think we should try to have a solution that simply doesn't function in earlier versions / windows PowerShell, without throwing errors.

A new attribute or named argument will be an error in older versions when you call the function.

Yes, but passing it a type that doesn't exist will also be an error as well, so I don't see it being any better, unless you plan on backporting the proposed types.
I would think that simply being able to specify a specific PSProvider would be much more streamlined in this case; given a string that matches a provider name, it can lookup against available PSProviders and apply completion for that instead of the standard filesystem only completion.
Otherwise, every single new and existing PSProvider would need its own argumentcompleter attribute class, which strikes me as awkward and unnecessary.

If you add a named argument, you allow something that is probably nonsense:
[ArgumentCompleter([CompleterType], Provider = 'OtherThing')]

You could use an unnamed argument so the constructor is overloaded, but I think a new attribute would be clearer than an unnamed argument to ArgumentCompleter.
Providers should probably opt-in to completion anyway by implementing System.Management.Automation.IArgumentCompleter because some providers are really slow, should use a cache, etc. Then you could write:
[ArgumentCompleter([Microsoft.PowerShell.Commands.FileSystemProvider])]

But if you really want a single type doing all path completion and supports specific providers, the ArgumentCompleterAttribute could support passing arguments to the types constructor, e.g.:
[ArgumentCompleter([PathCompleter], "FileSystemProvider")]

I will also point out that some people would like a global option to disable the fallback completion e.g. see this StackOverflow question.
I think the trivial implementation of such a global setting would not be a good experience, but such an option might make sense once the core commands have an the necessary annotations to complete paths where it makes sense. I do think we'd still need to complete paths for native commands that have no registered argument completers, or maybe this global option has different levels, like Off, NativeCommandsOnly, On.

I do think we'd still need to complete paths for native commands

We could implement default ArgumentCompleter for native commands. It allows to create custom completers for native commands. (Could we use here your idea with proxy classes (psmore)?)

Providers should probably opt-in to completion anyway by implementing

I like this most. This goes well with previous suggestion.
I do not like the idea of creating new attributes so we already have a lot of ones. IArgumentCompleter allow address all scenarios in modern way.

For reference https://github.com/dotnet/runtime/issues/75826


Update SuperCars II AGA

SuperCars II AGA has a new version (latest as of this writing is v0.89, released 22 days ago):
https://jotd666.itch.io/supercars-2-aga

Done


topics in snsTopics has incorrect indentation in documentation

https://awslabs.github.io/landing-zone-accelerator-on-aws/classes/_aws_accelerator_config.GlobalConfig.html#snsTopics
snsTopics:
depoymentTargets:
organizationalUnits:
- Root
topics:
- name: Security
emailAddresses:
-<EMAIL_ADDRESS>topics definition indentation needs to be aligned with depoymentTargets. This example causes build stage failure.

@ashmeetp Thank you for your interest in Landing Zone Accelerator on AWS! Thank you for identifying this, this will be resolved in our next upcoming release. I will keep this issue open until the documentation has been updated.

Hi @ashmeetp, this has been resolved with the release of version 1.3.2 so I'll be closing this issue.


Improve test

Codecov Report

Merging #5 (4bc0d70) into master (0f30e23) will increase coverage by 46.15%.
The diff coverage is 50.00%.

@@             Coverage Diff             @@
##           master       #5       +/-   ##
===========================================
+ Coverage   11.15%   57.30%   +46.15%
===========================================
  Files           7        7
  Lines         260      260
===========================================
+ Hits           29      149      +120
+ Misses        225       89      -136
- Partials        6       22       +16

Flag
Coverage Δ

unittests
57.30% <50.00%> (+46.15%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

gocovdiff.go
67.79% <50.00%> (+62.71%)
:arrow_up:

git.go
0.00% <0.00%> (-40.91%)
:arrow_down:

diff.go
22.22% <0.00%> (-22.23%)
:arrow_down:

github_annotations.go
10.00% <0.00%> (+10.00%)
:arrow_up:

profile.go
65.71% <0.00%> (+60.00%)
:arrow_up:

report.go
75.00% <0.00%> (+75.00%)
:arrow_up:

func.go
90.00% <0.00%> (+90.00%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0f30e23...4bc0d70. Read the comment docs.


Layout issues in documentation (horizontal navbar)

https://mne.tools/stable/index.html

Version chooser doesn't display current version
Something is wrong with the placement of the navbar elements
Line breaks where they shouldn't be needed

This is with Safari on macOS.

The line breaks in the navbar only occur for me when the browser window is too narrow. But yes, I also think that our website is currently not very nice for the following reasons:

Structure

The sidebar is (1) too wide and (2) duplicates some things from the navbar (e.g. version, Get help). I see two options: either remove the sidebar completely (and restructure the navbar), or make it narrower and remove duplicated entries (i.e. restructure). Furthermore, the sidebar still shows a vertical scrollbar for no reason.
The navbar entries should be restructured. For example, no one currently manages our Mastodon and X accounts. We might just as well remove those links to conserve some horizontal space if we're not planning to use these accounts anytime soon.
The Search entry could just be a magnifying glass. I don't think it is that important to show the keyboard shortcut.

Visual clutter

The Contributors should be mentioned on a separate page, not on the homepage. There is already too much visual clutter even without this list.
Similarly, the funders and supporting institutions sections are getting a bit overboard. I understand that this is probably required by the funders, but presumably only for current ones. Therefore, past funders could be moved to a less prominent part of the website.
The six feature boxes (not sure what to call them) do not have any text if you hover over them. This is a bit questionable from a UX perspective.
Who really needs to access all of these previous versions? My guess is probably almost no one, because users should be using the latest version. We've discussed this previously, and maybe now is the time to move everything < 1.0 to the archives.

Personally, I'd switch to Material for MkDocs, because it is visually just so much better. But I guess this is too big of a change that it won't be an option (and I don't know how easy it is to import existing Sphinx stuff).

The six feature boxes (not sure what to call them) do not have any text if you hover over them. This is a bit questionable from a UX perspective.

From an a11y perspective, they also don't honor "reduce motion" settings of my OS/browser (in that case, the zooming motion should be disabled).

Personally, I'd switch to Material for MkDocs, because it is visually just so much better.

Not an option because we're stuck with Sphinx …
Main advantage of Material for MkDocs for me is the search-as-you-type feature, it's such an essential thing to have these days and it's embarrassing our theme doesn't support this yet. Our search is horrendous.

Right, please just ignore my remark about MkDocs, this is just wishful thinking. All other points (sidebar, navbar, organization) still stand though.

Version chooser doesn't display current version

This should now be fixed, the overnight builds just had'nt completed yet

For all the UI/UX stuff yes it would be great to improve any problems. PRs welcome to improve things. FWIW I can replicate the top bar stuff once I shrink my window on Linux so that part at least seems to have to do with window size and when things break (so maybe removing some social icons would already help)

vs

FWIW I can replicate the top bar stuff once I shrink my window on Linux so that part at least seems to have to do with window size and when things break (so maybe removing some social icons would already help)

Unfortunately this doesn't seem to fix it for me on Safari on macOS: tried different screen sizes and window widths, always getting the same result

I can confirm that Safari on macOS always renders the navbar in two rows.

Re the version chooser, for me it still shows "Choose version" instead of the actual version number.

Re the version chooser, for me it still shows "Choose version" instead of the actual version number.

Same, I tried the devel docs

https://pydata-sphinx-theme.readthedocs.io/en/latest/user_guide/layout.html#overview-of-theme-layout

Version chooser doesn't display current version

I think this is because our "last updated" JS uses $ (JQuery) but JQuery isn't available, and that error causes the theme's JS that would check version and replace that text in the dropdown to not get run.

Something is wrong with the placement of the navbar elements

html_theme_options = {..., navbar_align="left"} might fix this. https://pydata-sphinx-theme.readthedocs.io/en/latest/user_guide/layout.html#configure-the-navbar-center-alignment

Line breaks where they shouldn't be needed

Not sure what this refers to?

The sidebar is (1) too wide and (2) duplicates some things from the navbar (e.g. version, Get help).

This is not a bug, and not about the theme. Open a separate issue if you want to discuss MNE's choices about website content.

the sidebar always shows a vertical scrollbar for no reason (see https://github.com/pydata/pydata-sphinx-theme/issues/1238).

Did you try the workaround in that thread? https://github.com/pydata/pydata-sphinx-theme/issues/1238#issuecomment-1463465620  If it works, PR welcome.

The navbar entries should be restructured. For example, no one currently manages our Mastodon and X accounts. We might just as well remove those links to conserve some horizontal space if we're not planning to use these accounts anytime soon.

This is not a bug, and not about the theme. Open a separate issue if you want to discuss MNE's choices about website content.

The Contributors should be mentioned on a separate page, not on the homepage. There is already too much visual clutter even without this list.

This is not a bug, and not about the theme. Open a separate issue if you want to discuss MNE's choices about website content.

Similarly, the funders and supporting institutions sections are getting a bit overboard. I understand that this is probably required by the funders, but presumably only for current ones. Therefore, past funders could be moved to a less prominent part of the website.

This is not a bug, and not about the theme. Open a separate issue if you want to discuss MNE's choices about website content.

The six feature boxes (not sure what to call them) do not have any text if you hover over them. This is a bit questionable from a UX perspective.

They do have text when you aren't hovering though... Do you mean there's no "alt" text?  That said, I agree with @hoechenberger that they should respect the "minimal motion" browser setting.

Who really needs to access all of these previous versions? My guess is probably almost no one, because users should be using the latest version. We've discussed this previously, and maybe now is the time to move everything < 1.0 to the archives.

Can you link to the previous discussion / reopen it there?  These omnibus issues make it really hard to keep track of everything. (Also: this is not a bug, and not about the theme).

The highlight color (e.g. for links and active elements like the search box) seems to have changed to purple, which doesn't look great with the rest of the colors.

For context on why it is purple, I invite you to read through:

https://github.com/pydata/pydata-sphinx-theme/issues/1052
https://github.com/pydata/pydata-sphinx-theme/issues/1079
https://github.com/pydata/pydata-sphinx-theme/pull/1174

As I said in https://github.com/mne-tools/mne-python/pull/12565#issuecomment-2072491173 I'm open to customizing the colors we use, but not casually and not at the expense of a11y guideline compliance.

Line breaks where they shouldn't be needed

Not sure what this refers to?

The top-center red circle, where it displays for me:
API
Reference

and
Get
Help

Main advantage of Material for MkDocs for me is the search-as-you-type feature, it's such an essential thing to have these days and it's embarrassing our theme doesn't support this yet. Our search is horrendous if you don't already know what you're looking for. Progress on this feature in pydata-sphinx-theme seems to be stalled.

@hoechenberger respectfully: Words like "embarrassing" and "horrendous" are not helpful here. I know that you know how OSS works, and that features like this will only ever get implemented if someone finds (almost certainly volunteers) the time to make it happen. As a maintainer of the theme I can tell you with certainty: there are only a few of us, we all have other higher-priority responsibilities, and the backlog of bugs and feature requests is a huge source of stress. Bitter complaints like this do not help.

As a maintainer of the theme I can tell you with certainty: there are only a few of us, we all have other higher-priority responsibilities, and the backlog of bugs and feature requests is a huge source of stress. Bitter complaints like this do not help.

I don't question that.
I question our use of this theme when there's such obvious usability problems and lack of resources to fix this, though.

The top-center red circle

OK, so

Something is wrong with the placement of the navbar elements

and

Line breaks where they shouldn't be needed

are the same issue / should have the same solution I offered above (navbar_align="left")

are the same issue / should have the same solution I offered above (navbar_align="left")

That could be, I honestly don't remember exactly what I meant :( Sorry about the confusion!!! your proposed fixed seems like a good idea!

I do question our use of this theme when there's such obvious usability problems and lack of resources to fix them, though.

Fair enough. Please do so politely (and in a separate issue) if you want to have a serious discussion about dropping Sphinx / Pydata Sphinx Theme.

Thanks @drammock, I've fixed the navbar and sidebar scrollbar in #12571. I'll open a new issue to discuss the content/structure of the website.

The line breaks in the navbar only occur for me when the browser window is too narrow.

Just FYI I am on a 13 inch MacBook, and the Navbar line breaks occur even when setting the safari browser to full screen.  So for folks like me with smaller MacBooks, the browser window will always be too narrow.

@scott-huberty did you try #12571?

@scott-huberty did you try #12571?

No, sorry, wasn't sure if the topbar line breaks were being addressed there!

Just FYI I am on a 13 inch MacBook, and the topbar line breaks occur even when setting the safari browser to full screen. So for folks like me with smaller MacBooks, the browser window will always be too narrow.

Just out of curiosity, do you use a "scaled resolution"? I'm on a 14" MBP and I use this setting ("one bigger than default"):

Thanks For the tip @hoechenberger - Looks like I'm just using the Default resolution, though I tried all the resolution options listed below, and none of them changed the topbar line break behavior : (

Can you hover over that "Default" tile and let us know which resolution is displayed?

Can you hover over that "Default" tile and let us know which resolution is displayed?

Yes, 1440 x 990
And if needed, my available resolutions (left to right) are: [1024 x 640, 1280 x 600, 1440 x 900, 1680 x 1050]

thanks!

The navbar issue has been resolved by #12571. The only thing remaining is the version chooser. Just to be clear, the versions are correctly shown in the drop-down menu, but the issue here is that the title of the chooser should include the currently selected version (e.g. "1.7.0") as opposed to "Choose version" (please correct me if I'm wrong @hoechenberger).


feat(build): make goreleaser work on macos aswell

@georgettica This looks great to me, but I'm not sure why the go.mod and go.sum were updated for a Makefile change.  Can you drop those changes, and we can merge this?

I am not here really, but I will do that next week

/lgtm
/approve


Add IOS_FCM_ENABLED variable to allow disabling FCM functionality on iOS

PR Type
What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Documentation  changes
[ ] Other... Please describe:

PR Checklist
Please check your PR fulfills the following requirements:
New features/enhancements:

[x] Exhaustive testing has been carried out for the new functionality
[ ] Regression testing has been carried out to ensure no existing functionality is adversely affected
[x] Documentation has been added / updated
[ ] The example project has been update to validate/demonstrate the new functionality.

What is the purpose of this PR?
There is a conflict on iOS in case push notifications are handled by another plugin (Airship), i.e. when FCM functionality of the plugin is not used. Even with FIREBASE_FCM_AUTOINIT_ENABLED set to false the plugin still would set its delegate for UNUserNotificationCenter however preventing regular flow of notifications. This PR is allows to disable FCM on iOS via IOS_FCM_ENABLED variable.
Does this PR introduce a breaking change?

[ ] Yes
[x] No

What testing has been done on the changes in the PR?
Checked in an isolated example and used in a production app.
What testing has been done on existing functionality?
Other information

Thanks!


add "Persisting the current_spree_user section" to readme

I can go either way with this. If we're going to support telling people to do these steps via the readme, we'd almost be better to attempt to add it to the gem itself as some kind of additional optional functionality.

This is quite fair. I do not trust my extension abilities enough to do this at the moment. Maybe in a few months.

I didn't feel this information really belonged in the README, since it's not something the extension currently supports out-of-the-box. However, I didn't want to lose the fantastic write-up.
As a compromise, I've added a wiki entry for it. I'll push up a change to the README to link to the wiki for some additional exposure.


no les

Hi,
The program 'les' is currently not installed.  To run 'les' please ask your administrator to install the package 'atm-tools'
Working on a LSF cluster, any workarounds?

Sorry, les is not used by picardmetrics. I don't know what it is.
More generally, you can download and install packages as you wish (that's what I do most of the time on all of the servers that I use), or you can contact the administrator if you prefer to have them do the download and installation for you.


Implement dbt snapshot nodes

The classes exist for it but they're not implemented in the rendering part of the project.

@MikeWallis42 are you envisioning that we make a DbtSnapshotOperator that unlocks this functionality to our end users?

@pohek321 yes I'm suggesting that a DbtSnapshotOperator be created and then added as part of the rendering process so that the cosmos rendering process offers support for a broader range of dbt models.


Can't find executable

I installed the Conda package using Package Control with Sublime Text 4126 on my work machine, but can't get it to work.
Anaconda was installed by my system administrator for all users on my machine under C:\ProgramData\Anaconda3.
First, the Conda package wouldn't list my environments, but I fixed that by overwriting the default package setting "environment_directory" with "C:\\ProgramData\\Anaconda3\\envs" (under Preferences / Package Settings / Conda / Settings).
But I can't get it to build my files. When open Anaconda Prompt and run where python, I get C:\ProgramData\Anaconda3\python.exe, which I enter in the package settings as "C:\\ProgramData\\Anaconda3\\python.exe".
All in all, my custom package settings are
{
  "executable": "C:\\ProgramData\\Anaconda3\\python.exe",
  "environment_directory": "C:\\ProgramData\\Anaconda3\\envs",
}

When I try to build, I get the following error message:
[WinError 2] The system cannot find the file specified
[cmd: ['C:\\Users\\frpa8185\\Anaconda3\\python', '-u', 'C:\\Users\\frpa8185\\Dropbox\\tmp\\tmp.py']]
[dir: C:\Users\frpa8185\Dropbox\tmp]
[path: C:\Program Files\ImageMagick-7.0.8-Q16;C:\Windows\system32;C:\Windows;C:\Windows\System32\Wbem;C:\Windows\System32\WindowsPowerShell\v1.0\;C:\Windows\System32\OpenSSH\;C:\Program Files\MiKTeX 2.9\miktex\bin\x64\;C:\Program Files\PuTTY\;C:\Program Files\nodejs\;C:\Program Files\MATLAB\R2021b\runtime\win64;C:\Program Files\MATLAB\R2021b\bin;C:\Users\frpa8185\AppData\Local\Microsoft\WindowsApps;C:\Users\frpa8185\AppData\Local\GitHubDesktop\bin;C:\Users\frpa8185\AppData\Local\Programs\Git\cmd;C:\Users\frpa8185\AppData\Local\Programs\Microsoft VS Code\bin;C:\Users\frpa8185\AppData\Local\Programs\Julia-1.7.2\bin]
[Finished]

Hi Fredrik. Thanks for reporting this issue.
I am not able to replicate this issue. Is your build system set to Conda, and are you activating the environment via Conda: Activate Environment prior to running your build?


Added operator contract balance checks to the pricing test script

We can use operator contract balance check to make sure the value of
rewards stored in the contract matches the total ETH balance stored on
the contract.

That looks much cleaner than mine 😄
What do you think of adding an error message just in case there's a mismatch? i.e.
if (!operatorContractBalance.eq(rewardsSum.add(dkgSubmitterReimbursementFee))) {
    console.log("ERROR: Operator Contract balance mismatch");
}

Working on this one. Should have it ready pretty soon.

We now have both service and operator contract checks so I put them in the table:

One sec, something is wrong here...


Is Elm 0.19 and latest Json.Decode.Pipeline supported?

I got a few compilation errors using Elm 0.19, and I'm not sure if this is just me or what Elm and Json.Decode.Pipeline package version is currently supported?
Would be nice to have that specifically mentioned somewhere.
If I have time I'll try and figure out what changes are required for Elm 0.19 support...

(Thanks for this amazing tool BTW!)

We haven't touched Elm in a long time, so I wouldn't be surprised if quicktype breaks for 0.19.  We'd love to help you fix Elm support.


Enhancement Request: Support for CSV-Based Configuration Upload

Work on https://github.com/hyperledger/aries-endorser-service/issues/38


DO NOT MERGE - Pseudo PR - community review for initial release

Do not merge - pseudo PR to give review interface for entire pipeline

Community review for initial release. Aim is to get at least two PR approvals from people in the nf-core community who are not the main developers of this pipeline ✅
https://nf-co.re/developers/adding_pipelines#making-the-first-release

Sorry for the recreation of this PR, but it was merged prematurely, as it was still under-reviewing, and also should not have been merged to begin with...
I created a PR, so we can start thinking about having stricter permissions -> https://github.com/nf-core/nf-co.re/issues/608, but that's a separate topic.
Anyhow, disclosure, I'm not familiar with the dualrnaseq world, so I might have some strange comments.
I understand that you're not using igenomes, but then, I can see for example that with the test data, you provide the genome references (host and pathogen) with the test data, I'd assume it's because you need a GFF3?
Why not putting that information in a conf/genomes.config file?
Especially since you're still using the params.genomes map to access the files from the host and pathogen?
(cf the rnafusion pipeline which is not using igenomes either: https://github.com/nf-core/rnafusion/blob/dev/conf/genomes.config)
There should be some warning when using --run_htseq_uniquely_mapped without --run_star.
I'm amazed by the amount of custom script that you guys wrote.
I think some bash script are quite tiny and could actually be incorporate in the main.nf, but I have no problem having them separated.
It's a little sad that the test profile is not running any. I think some more CI here will be welcome.
The profile test_full is not working, I'm assuming it hasn't been actually touched.
Apart from that, it is an impressive job.
I'll have a more closer look, but if you can fix the genomes file, that will be a good start.

Sorry for the recreation of this PR, but it was merged prematurely, as it was still under-reviewing, and also should not have been merged to begin with...
I created a PR, so we can start thinking about having stricter permissions -> https://github.com/nf-core/nf-co.re/issues/608, but that's a separate topic.
Anyhow, disclosure, I'm not familiar with the dualrnaseq world, so I might have some strange comments.
I understand that you're not using igenomes, but then, I can see for example that with the test data, you provide the genome references (host and pathogen) with the test data, I'd assume it's because you need a GFF3?
Why not putting that information in a conf/genomes.config file?
Especially since you're still using the params.genomes map to access the files from the host and pathogen?
(cf the rnafusion pipeline which is not using igenomes either: https://github.com/nf-core/rnafusion/blob/dev/conf/genomes.config)
There should be some warning when using --run_htseq_uniquely_mapped without --run_star.
I'm amazed by the amount of custom script that you guys wrote.
I think some bash script are quite tiny and could actually be incorporate in the main.nf, but I have no problem having them separated.
It's a little sad that the test profile is not running any. I think some more CI here will be welcome.
The profile test_full is not working, I'm assuming it hasn't been actually touched.
Apart from that, it is an impressive job.
I'll have a more closer look, but if you can fix the genomes file, that will be a good start.

Why the downgrade to MultiQC v1.8? ;-)

Why the downgrade to MultiQC v1.8? ;-)


File Explorer and Outline left padding are inconsistent

Does this issue occur when all extensions are disabled?: Yes/No

As shown above, the indentation in the outline is consistent while there are some additional left padding in the file explorer, pushing the tree view to the right side a bit more.

I believe this is by design and only the case with the file explorer. @lramos15 probably knows more about this. What is the main reason for this?

I'm not sure maybe @isidorn knows since he owned explorer before me.
I know that when we have a file icon theme that has folders the indentation can also change, so maybe that accounts for some of it.

Yes, I think it was related to the file icon theme change. I know @aeschli was looking into the alignment with and without icons.


Wrong favicon shown in Safari

Safari shows the default NextJS/Vercel favicon on polar.sh. Chrome/Firefox/Edge all load the correct favicon.

This was a caching issue.


Avoid init to null

Ha! that's a lot of commits for a one-line change. 😁

I’m probably using Git wrong. I blame it on the main repo squashing commits and thus ditching my history. 😜


Workshop 141 added Note to OAC lab in COMMON repository to allow reinstating green button

Workshop ID#141
Attention William Masdon and Kaylien Phan; I discusse this with Anoosha.
Added Note to OAC lab that is in COMMON repository, to READ but not PERFORM the OAC lab if running the workshop in green button sandbox. This will enable us to reinstate the green button that was deactivated when we replaced OAD with OAC.

@greenrick there are two conflicts - can you please check? thanks


Pixel Streaming Audio not working on IOS

I have a pixel streaming application running in which we are using Linux containers to run it . There are 2 containers 1 is signaling an the other runs the project. For signaling  we are using https://github.com/orgs/epicgames/packages/container/package/pixel-streaming-signalling-server image .. The application seems to work fine every browser and OS , but when it comes to IOS the audio is missing. This is not specific to one single browser on IOS. Even if host it Windows server we get the same issue. Is there a fix for it ??
If yes then is the issue on the server level or the application level

Hi, I'd been looking into this myself. The fix for this is here:
https://github.com/EpicGames/PixelStreamingInfrastructure/blob/d31bfc0e613245ad82f993e2989bea2900b25ed8/SignallingWebServer/scripts/app.js#L1007-L1014
I've tried it myself and it works on iOS. I have no idea if this fix made it into the image you're using (I guess it didn't).

@sheepsteak Does this require projects to be build with UE 5 ? I tried this with ones built on 4.27 - it showed following error and terminated the streamer.
LogPixelStreamingSS: <- SS: {"type":"playerConnected","playerId":"101","dataChannel":true,"sfu":false} [2022.08.23-12.15.48:284][370] LogPixelStreamingSS: Error: Unsupported message playerConnected received from SS

It might not be well advertised, but we do have a UE4.27 branch in this repo which works with 4.27

@sheepsteak Does this require projects to be built with UE 5 ? I tried this with ones built on 4.27 - it showed following error and terminated the streamer. "LogPixelStreamingSS: <- SS: {"type":"playerConnected","playerId":"101","dataChannel":true,"sfu":false} [2022.08.23-12.15.48:284][370]" "LogPixelStreamingSS: Error: Unsupported message playerConnected received from SS"

This is unrelated to this issue in the title. For using the 4.27 version of the engine there is a UE4.27 branch in this repository which resolves Unsupported message error

Hey there @reckless007,
This issue has since been fixed here in this repository with the reason for your error being explained by @sheepsteak. Unfortunately, the signalling server container images haven't been updated yet as there hasn't been an Unreal Engine release since the fix has been implemented.
You could however build your own signalling server container image based off of the Dockerfile found here: https://github.com/EpicGames/UnrealEngine/blob/release/Engine/Extras/Containers/Dockerfiles/linux/signalling-server/Dockerfile.
This file will a few modifications to get it to work for your case:

Delete lines 1 and 2
Change line 3 to FROM node:16
Update line 6 to copy your local signalling server. eg COPY /path/to/your/SignallingWebServer /opt/SignallingWebServer

Let us know how that goes.

@Belchy06 Thanks for the solution it worked.


On some requests, the awake-wav trigger sound plays again after the done-wav sound, then OWW gets stuck

I'm noticing that occasionally, I'll hear the wakeword trigger awake sound play a second time.  After saying the wake word, I'll hear the awake trigger sound, speak my question, and hear the done sound.  Then, immediately after, I hear the awake trigger sound play again.  Then I get my answer, and from that point on the OWW wyoming satellite seems stuck.  If i go into home assistant and tweak any of the mic settings (auto gain, mic level, noise suppression level) it will then play the trigger sound again and get unstuck.
Anecdotally, it seems to be on longer requests, or ones where ive asked two questions such as "What is the pool temperature, and what is the temperature outside"
I'm not sure what's causing this, or how I could debug it.  Playing back my recordings of the command it heard me say, the mic recording seems clean and clear.
Any suggestions?

For what its worth, even though a reboot didnt seem to help, I restarted only the wyoming-openwakeword service and it seems to have stopped doing it for now.

That didn't help for me. Once it starts playing back TTS data from Home Assistant, the debug log shows the microphone immediately unmuting, and the lights turn yellow on my hat.

the same here i have ... @spdustin thanks for suggestion, using built it wake words seems works as expected

I have the same experience... none of the custom wakewords work

I've got it to work via the comments from #217. I had to copy the custom wake word model to the default model location: <dir>/wyoming_openwakeword/models  (See this comment).
In case of the docker container, this was located at: /usr/src/.venv/lib/python3.11/site-packages/wyoming_openwakeword/models/.
This is also the directory I set as the custom model directory.
Then, I had to rename my custom wake word by adding _v0.1, so from example.tflite to example_v0.1.tflite (see this comment).
I have not the slightest idea of why this would work, but it does.
Having to copy a file into a Python package installed in a virtual environment is obviously an ugly workaround, though.
From my testing, I think there's also a second bug, that makes the wyoming-speaker docker container crash, if the --done-wav is still playing when the satellite wants to play the TTS response, that may or may not have anything to do with this problem in the broader sense.


Case-Sensitive Collation

The database in Microsoft SQL use a case-sensitive collation and this can´t be change :-(
And I´m getting this error: Invalid object name 'INFORMATION_SCHEMA.tables'
Are there some parameter to setup? Because the query must be 'INFORMATION_SCHEMA.TABLES' to work.

Hi Leandro - are you able to change the SQL to TABLES and COLUMNS in this file and see if that fixes it? https://github.com/rickbergfalk/sqlpad/blob/master/lib/get-schema-for-connection.js
I wasn't aware case-sensitive collation impacted the table name references - I thought it was only for the values...
If upper case TABLES/COLUMNS works I think we'd be safe to make the change since the case insensitive dbs shouldn't care

Works!!
function getStandardSchemaSql(whereSql = '') {
return     SELECT        (CASE t.table_type WHEN 'BASE TABLE' THEN 'Tables' WHEN 'VIEW' THEN 'Views' ELSE t.table_type END) AS table_type,        t.table_schema,        t.table_name,        c.column_name,        c.data_type,        c.is_nullable      FROM        INFORMATION_SCHEMA.TABLES t        JOIN INFORMATION_SCHEMA.COLUMNS c ON t.table_schema = c.table_schema AND t.table_name = c.table_name      ${whereSql}     ORDER BY        t.table_type,        t.table_schema,        t.table_name,        c.ordinal_position
}

Thanks for checking on this @LeandroFavero! I've made this change and published to npm as version 2.4.2.


recent_topics: Handle no rows case on r keypress.

When there are no rows for user to reply on r keypress,
we open compose box with everything empty.
Traceback:

This is great, merged, thanks @amanagr!
(The CI failure is the known drafts puppeteer flake).


feature(ColorPicker) Added color picker

Color picker added
Main story for color picked added
4 color picker options are available
Readme with the props we have available for the different pickers

@esuarezz Missing colon in title


Add shader_cache_dir_valid check to _save_to_cache

Fixes https://github.com/godotengine/godot/issues/87079
Alternatively one could argue that we should add the check to the call site instead of inside the function, but I think add a protection inside it is harmless and prevent future mistakes.

Alternatively one could argue that we should add the check to the call site instead of inside the function, but I think add a protection inside it is harmless and prevent future mistakes.

I think it might need to do both.
Usually we would use ERR_FAIL_COND if the contract of a function is not respected. Here, I think _save_to_cache should never be called if there's no valid shader cache dir, so it should raise an error.
And then the call site where it's not properly doing the check should be changed. _save_to_cache is called in three files, and two of them properly check:
if (shader_cache_dir_valid) {
_save_to_cache(p_version);
}

But that check is missing in shader_gles3.h:
Version::Specialization *spec = version->variants[p_variant].lookup_ptr(p_specialization);
if (!spec) {
	if (false) {
		// Queue load this specialization and use defaults in the meantime (TODO)

		spec = version->variants[p_variant].lookup_ptr(specialization_default_mask);
	} else {
		// Compile on the spot
		Version::Specialization s;
		_compile_specialization(s, p_variant, version, p_specialization);
		version->variants[p_variant].insert(p_specialization, s);
		spec = version->variants[p_variant].lookup_ptr(p_specialization);
		_save_to_cache(version);
	}

But that check is missing in shader_gles3.h

Yes I noticed that too, you are right, it need to do both, an if guard at the call site and ERR_FAIL_COND in the function .

Thanks!

Cherry-picked for 4.2.2.

Could we see this on 4.1.5 too? We have a released mobile game using 4.1 and we need to get rid of many annoying errors when shader cache is off in the project settings.


to fix issue Target llvm is not enabled

Issue:
I was building TVM4J and got error bf != nullptr Target llvm is not enabled when generating shared library. The issue is similar to https://github.com/dmlc/tvm/issues/1020
Solution:
enable LLVM in config.cmake
Thanks for contributing to TVM!   Please refer to guideline https://docs.tvm.ai/contribute/ for useful information and tips. After the pull request is submitted, please request code reviews from Reviewers.

I think we shouldn't do this change.  As the comment said:
/path/to/llvm-config: enable specific LLVM when multiple llvm-dev is available.

We should let the user specify the correct path. The doc always said what the condition and how to turn it on:
https://docs.tvm.ai/install/from_source.html Users should read the manual carefully firstly.
Meanwhile, when we compile the runtime only, we don't need LLVM on. So TVM just depend on LLVM optionally.

I see. Maybe a better way is to put it explicitly in TVM4J's README saying we need to turn on LLVM support for TVM4J?

I see. Maybe a better way is to put it explicitly in TVM4J's README saying we need to turn on LLVM support for TVM4J? It will help beginners to save a lot of time to troubleshooting, won't it?

The TVM4J Readme in fact have listed the doc I mention before:

However, I think you could PR the TVM4J readme and emphasize users should notice turning LLVM on.


Use uv to install our tools

Let's see if we can gain some speed.

We have gone from 44–46s to 30–39s.
The action itself from 30–31s to 18-23s

Look at all the caching @hugovk! (I circled back tohttps://mastodon.social/@hugovk/111952441742169511)
I wonder if it would make sense to cache pipx too, but I doubt it.

Nice! 📦


[bugfix] turboOCI commit with uuid

What this PR does / why we need it:
UUID is missed when using overlaybd-commit with the option --uuid and --turboOCI, instead of a random uuid in the committed file. After this fix, we can reproduce turboOCI files.
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #
Please check the following list:

[ ]  Does the affected code have corresponding tests, e.g. unit test, E2E test?
[ ]  Does this change require a documentation update?
[ ]  Does this introduce breaking changes that would require an announcement or bumping the major version?
[ ]  Do all new files have an appropriate license header?

please add a UT to check the UUID if empty when creating a new LSMTFile

Added. With the unit tests, I checked the following cases:

LSMTFile is created with a random non-empty UUID
This UUID will be empty after committing without specifying CommitArgs.uuid
This UUID will be a specific UUID after committing with specific CommitArgs.uuid

LGTM


Training crashes if intent name contains more than 1 slash

Rasa version: 1.5.1
Python version: 3.6.8
Operating system (windows, osx, ...): Linux
Issue:
If given a file with any intent name containing more than 1 slash ("/"), Rasa raises an exception
Training file that reproduces this bug :
{
    "rasa_nlu_data": {
        "common_examples": [{
            "text": "Hello you !",
            "intent": "My/Intent/Name"
        }],
        "entity_synonyms": [],
        "regex_features": [],
        "lookup_tables": []
    }
}

If you replace "My/Intent/Name" with "My/IntentName", everything works as expected.
Error (including full traceback):
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/usr/lib/python3.7/site-packages/rasa/nlu/training_data/loading.py", line 67, in load_data
    data_sets = [_load(f, language) for f in files]
  File "/usr/lib/python3.7/site-packages/rasa/nlu/training_data/loading.py", line 67, in <listcomp>
    data_sets = [_load(f, language) for f in files]
  File "/usr/lib/python3.7/site-packages/rasa/nlu/training_data/loading.py", line 138, in _load
    return reader.read(filename, language=language, fformat=fformat)
  File "/usr/lib/python3.7/site-packages/rasa/nlu/training_data/formats/readerwriter.py", line 10, in read
    return self.reads(rasa.utils.io.read_file(filename), **kwargs)
  File "/usr/lib/python3.7/site-packages/rasa/nlu/training_data/formats/readerwriter.py", line 32, in reads
    return self.read_from_json(js, **kwargs)
  File "/usr/lib/python3.7/site-packages/rasa/nlu/training_data/formats/rasa.py", line 59, in read_from_json
    msg = Message.build(ex["text"], ex.get("intent"), ex.get("entities"))
  File "/usr/lib/python3.7/site-packages/rasa/nlu/training_data/message.py", line 72, in build
    split_intent, response_key = cls.separate_intent_response_key(intent)
TypeError: cannot unpack non-iterable NoneType object

Command or request that led to error:
from rasa.nlu import load_data
load_data("/path/training_file")

Thanks for the issue, @btotharye will get back to you about it soon!
You may find help in the docs and the forum, too 🤗

@Nicky31 character / is reserved for defining retrieval intents as mentioned here in the docs https://rasa.com/docs/rasa/nlu/training-data-format/#markdown-format.

I didn't notice that part, thank you for the information. If that doesn't noticeably affects training performance, a clear error message indicating forbidden characters would have been greatly appreciated in such situation, saving the time I spent truncating my training dataset to find the faulty intent.
From what I understand, even if having 1 character / in my intent name doesn't raise any exception, the intent might be impossible to learn for rasa ?

If you 1 character / it would have been interpreted as a retrieval intent https://rasa.com/docs/rasa/core/retrieval-actions/#training-data


In the search provider, share results between invocations

https://phabricator.endlessm.com/T32557

Thanks for the review @danigm! That helped a bunch. I took care of those details you flagged :)


Crunchyroll extractor look break

Hi, yesterday it work without problems but today seem very strange.
Youtube-dl version : youtube-dl is up-to-date (2015.07.18)
I try a premium episode (I'm premium and use netrc to authentification).
https://zerobin.net/?a3502ee8836b8993#BIRmMlQHk4sxM0H/KQb1FD1HRclw0JWYsSfK8lNhJEM=
I try a older episode
https://zerobin.net/?76bb6004c2087c74#cZqSxHbmAPJxH/ilzIwjtpP5pcu6hMOiCHOqBYem47I=
Thanks for all.

Post the *.dump files you'll get when running youtube-dl with --write-pages.

Here the dump file for episode 3 and episode 2
https://zerobin.net/?bdbaf1c4241da595#mxMbokuANqbI+TIpdstwSLby5MQZZ5DROpW82jppBpg=
https://zerobin.net/?e70be5715a93e27a#jHly/+qwRcpWpYK+/+3FBdORb/1AInn2tFjpSsjVta8=
https://zerobin.net/?7cabfd35feb7c38f#qoGY5+T79vT4Fsh53212OlsuzKcUgq2EMZ5Os3+xZdU=
https://zerobin.net/?f98047d290cebd77#nCEHkrzIG5fI9esYoF7zyiXpVv+djZ8mDa3GmaW0m8w=
https://zerobin.net/?70d0a77e25a0457a#F+u5AC8O0n2czQnE30pjH3C5ir0jt9BPeg10b1J88/E=

Sorry I missed one for episode 2
https://zerobin.net/?0c09adab55d0a07c#U68/EschZqDX6lDzqpsVb+8AGjXvevUqqeyM2ab+GXA=

Can you download another premium videos? Doesn't your premium expired or so?

Strange I juste tried this => http://www.crunchyroll.com/ace-of-the-diamond/episode-16-chain-reaction-678619
It work without problems (online and with youtube-dl).
But the episode 3 of gansta not work with youtube-dl (it work well online).

Late me know if you need something other to determine the problem for gangsta's episodes.

Can you try with latest version from master?

I just tried.
First I update:
$ sudo youtube-dl -U
youtube-dl is up-to-date (2015.09.03)
I test the last epidode of this week:
https://zerobin.net/?b1309516db2de9eb#/+Hvto+fWG0Llcdsw/NWXfbLZnHpDC94/vGXY5iNujg=
I test the older episode too:
https://zerobin.net/?68ff8f3079ab5903#xxb/gUVI2Agy6Q1ZahVG3ZSF2SONnCowsoEI4xMzT2E=
(I tried an other episode too to verify my netrc auth)
https://zerobin.net/?19110985f9146305#/YNnp/Xavcehs0iZmYq2VpMRvzci6oPAxy+p4qpHQNg=

It's not yet released. You need to check with version from repository.

Ah ok, I try again.

It's good I think.
I late you keep a look at the debug to be sure.
https://zerobin.net/?373734ac01d20f06#YycHEPI09Ymqf1duHOBQttWqY9N/cDEUFx5lJYP6e7k=

And for http://www.crunchyroll.com/gangsta/episode-3-ergastulum-682687?

It's ok, thanks for all ^^ !!!
https://zerobin.net/?89f677872b8a86b9#b48ijP+1HRY8q667cMgXg44yYD+Y4cGzTYb6fL/0fjA=

Ok, I'm closing this then.


Fix for pit window beeing 1 minut off in timed races.

This also included changes to auto updater so if you dont want to merge that yet just let me know and i'll reverse or I guess you can cherry pick what you want.

That should be it.


NodeJS Memory Optimizations

Configuring both NodeJS instances (API and APP) to use a maximum of 1Gb memory. As opposed to the default 4GB.

I see there's no need to update the docker files, I was thinking that we could leave our locals to use the default and the containers to have the mem reduction.

Yes... No need to update Docker.
Once everything is moving to Openshift I can test lowering the Memory even more.


Helm upgrade not working as expected

Hi,
I am trying to upgrade one of my packages. But the changes which I  have made in the "deployment.yaml" template in the chart is not there after the upgrade. I added the following lines in the spec of my kubernetes deployment.yaml file
spec:
     containers:
     - env:
        - name: LOGBACK_DB_ACQUIRE_INCREMENT
           value: "1"
        - name: LOGBACK_DB_MAX_IDLE_TIME_EXCESS_CONNECTIONS
           value: "10"
        - name: LOGBACK_DB_MAX_POOL_SIZE
           value: "2"
        - name: LOGBACK_DB_MIN_POOL_SIZE
           value: "1"

I tried upgrading using the following command
helm upgrade ironic-molly spring-app-0.1.2.tgz --recreate-pods
Where "ironic-molly" is the release-name and spring-app-0.1.2.tgz is my chart with changes.
Helm output says that the package is upgraded , but the changes which i have made is missing in the deployment.yaml . What might be causing this issue.?
Regards,
Muhammed Roshan

Hi @roshan-mr,
Thanks for bringing this issue to our attention. Could you please post your Helm and Kubernetes versions so we can make sure we are testing the correct versions?

We are experiencing the same behaviour.
Description
Changed imagePullSecrets in template cluster-service-chart/templates/deployment.yaml  (not variable)
      imagePullSecrets:
      - name: cluster-service-pull-secret

then applying new chart with
helm upgrade -f some_values.yaml --install cluster-service <NEW_CHART>

helm get cluster-service shows new deployment, but
Expected:
kubectl get deploy/cluster-service -o yaml will show new imagePullSecrets value
Actual:
kubectl get deploy/cluster-service -o yaml shows old imagePullSecrets value. And whole deployment looks old.
Version
helm version
Client: &version.Version{SemVer:"v2.5.0", GitCommit:"012cb0ac1a1b2f888144ef5a67b8dab6c2d45be6", GitTreeState:"clean"}
Server: &version.Version{SemVer:"v2.5.0", GitCommit:"012cb0ac1a1b2f888144ef5a67b8dab6c2d45be6", GitTreeState:"clean"}

We are experiencing similar behaviour.
When changing the image hash in the deployment template:

helm upgrade succeeds
tiller manifest shows the new image hash
kubectl describe shows the old image hash
the deployment is not updated

Client: &version.Version{SemVer:"v2.6.2", GitCommit:"be3ae4ea91b2960be98c07e8f73754e67e87963c", GitTreeState:"clean"}
Server: &version.Version{SemVer:"v2.7.0", GitCommit:"08c1144f5eb3e3b636d9775617287cc26e53dba4", GitTreeState:"clean"}
Kubernetes version: 1.8.1-gke.1

We are see the same issue as @matthewrj. It worked with multiple deploys yesterday, but this morning will not deploy. helm get <deployment> manifest shows the correct yaml file. We were able to change another item in our template, deployed again and it worked. Not sure why the first update didn't deploy, but changed manifest in helm.
Client: &version.Version{SemVer:"v2.5.1", GitCommit:"7cf31e8d9a026287041bae077b09165be247ae66", GitTreeState:"clean"}
Server: &version.Version{SemVer:"v2.6.0", GitCommit:"5bc7c619f85d74702e810a8325e0a24f729aa11a", GitTreeState:"clean"}

I tested this on latest 2.7.1 and i still see same issue as @phillydogg28

I discovered the issue was we somehow had got into a state where we had 4 releases with the same name. Deleting all of the duplicate releases and recreating the original fixed the problem. Although we have got into the duplicate release state multiple times now.

I'm also seeing this. helm get shows correct output but deployment is never updated.

I'm getting this too.

Same here when changing an environment variable. With helm 2.8.1

We still haven't identified the underlying issue that's causing this... Typically we only escalate to a bug once someone has actually pinpointed how to reproduce the problem.
If someone can provide some steps to reproduce this with a public chart that would be helpful to diagnose the issue. Thanks!

Easy to duplicate with https://github.com/kubernetes/charts/tree/master/stable/nginx-ingress deployed to an Azuer ACS engine version of Kubernetes and tied to a static load balancer IP.
What I've been seeing for the last 8 months is that any k8s resource "tied" into Azure through the ACS engine will NOT be updated by helm during deployment regardless if the values.yaml has changed or if the checksum annotation's hash mutates. In this case an Azure load balancer is spun up and the static IP assigned.
custom-values.yaml
controller:
  ingressClass: "common-ingress"
  electionID: "ingress-controller-leader-common"

  service:
    loadBalancerIP: "<IP_ADDRESS>"
    externalTrafficPolicy: "Local"

  kind: "DaemonSet"

  # changes to the cpu or memory and re-deploying succeeds but the definition is not actually updated
  resources:
    requests:
      cpu: 200m
      memory: 200Mi

helm upgrade -i live-nginx-ingress-zipkin mycompany/nginx-ingress --namespace live --set environment=live  --values custom-values.yaml
Note the up-time of these controllers are 39+ days even though I just deployed which means they were not updated even though helm claims they were.
kubectl -n live get po

live-nginx-ingress-common-nginx-ingress-controller-6dkds          1/1       Running   135        40d
live-nginx-ingress-common-nginx-ingress-controller-8npgm          1/1       Running   44         39d
live-nginx-ingress-common-nginx-ingress-controller-l5p68          1/1       Running   6          39d
live-nginx-ingress-common-nginx-ingress-controller-scqrs          1/1       Running   10         39d
live-nginx-ingress-common-nginx-ingress-default-backend-99dnhp8   1/1       Running   0          45m
live-nginx-ingress-zipkin-nginx-ingress-controller-lcsbh          1/1       Running   3          40d
live-nginx-ingress-zipkin-nginx-ingress-controller-nf8jr          1/1       Running   5          39d
live-nginx-ingress-zipkin-nginx-ingress-controller-wthtg          1/1       Running   2          40d
live-nginx-ingress-zipkin-nginx-ingress-controller-wvd22          1/1       Running   2          40d
live-nginx-ingress-zipkin-nginx-ingress-default-backend-9db8hx5   1/1       Running   0          44m

Resulting yaml of ingress has not changed. Still contains the old cpu and memory limits.
kubectl -n live get po live-nginx-ingress-common-nginx-ingress-controller-6dkds -o yaml

apiVersion: v1
kind: Pod
metadata:
  annotations:
    checksum/config: 7218e23babc64900ba678c5c348d22347610f2275f1177e0c3d05131f3d9c23e
    kubernetes.io/created-by: |
      {"kind":"SerializedReference","apiVersion":"v1","reference":{"kind":"DaemonSet","namespace":"live","name":"live-nginx-ingress-common-nginx-ingress-controller","uid":"7b5c4680-28ca-11e8-a7ff-000d3a73b731","apiVersion":"extensions","resourceVersion":"8215546"}}
  creationTimestamp: 2018-03-16T03:31:15Z
  generateName: live-nginx-ingress-common-nginx-ingress-controller-
  labels:
    app: nginx-ingress
    chart: nginx-ingress-0.404.0
    chart-version: 0.404.0
    component: controller
    controller-revision-hash: "3665246960"
    environment: live
    heritage: Tiller
    pod-template-generation: "1"
    project: designer
    provider: mycompany
    release: live-nginx-ingress-common
    release-name: pickle-jiggles
  name: live-nginx-ingress-common-nginx-ingress-controller-6dkds
  namespace: live
  ownerReferences:
  - apiVersion: extensions/v1beta1
    blockOwnerDeletion: true
    controller: true
    kind: DaemonSet
    name: live-nginx-ingress-common-nginx-ingress-controller
    uid: 7b5c4680-28ca-11e8-a7ff-000d3a73b731
  resourceVersion: "15355150"
  selfLink: /api/v1/namespaces/live/pods/live-nginx-ingress-common-nginx-ingress-controller-6dkds
  uid: 7b836f6e-28ca-11e8-b490-000d3a73bdea
spec:
  containers:
  - args:
    - /nginx-ingress-controller
    - --default-backend-service=live/live-nginx-ingress-common-nginx-ingress-default-backend
    - --election-id=ingress-controller-leader-common
    - --ingress-class=common-ingress
    - --configmap=live/live-nginx-ingress-common-nginx-ingress-controller
    env:
    - name: POD_NAME
      valueFrom:
        fieldRef:
          apiVersion: v1
          fieldPath: metadata.name
    - name: POD_NAMESPACE
      valueFrom:
        fieldRef:
          apiVersion: v1
          fieldPath: metadata.namespace
    image: quay.io/kubernetes-ingress-controller/nginx-ingress-controller:0.9.0-beta.19
    imagePullPolicy: IfNotPresent
    livenessProbe:
      failureThreshold: 3
      httpGet:
        path: /healthz
        port: 10254
        scheme: HTTP
      initialDelaySeconds: 10
      periodSeconds: 10
      successThreshold: 1
      timeoutSeconds: 1
    name: nginx-ingress-controller
    ports:
    - containerPort: 80
      name: http
      protocol: TCP
    - containerPort: 443
      name: https
      protocol: TCP
    readinessProbe:
      failureThreshold: 3
      httpGet:
        path: /healthz
        port: 10254
        scheme: HTTP
      periodSeconds: 10
      successThreshold: 1
      timeoutSeconds: 1
    resources:
      limits:
        cpu: 500m
        memory: 200Mi
      requests:
        cpu: 500m
        memory: 200Mi
    terminationMessagePath: /dev/termination-log
    terminationMessagePolicy: File
    volumeMounts:
    - mountPath: /var/run/secrets/kubernetes.io/serviceaccount
      name: default-token-kh8lr
      readOnly: true
  dnsPolicy: ClusterFirst
  nodeName: k8s-agent-b9a90342-2
  restartPolicy: Always
  schedulerName: default-scheduler
  securityContext: {}
  serviceAccount: default
  serviceAccountName: default
  terminationGracePeriodSeconds: 60
  tolerations:
  - effect: NoExecute
    key: node.alpha.kubernetes.io/notReady
    operator: Exists
  - effect: NoExecute
    key: node.alpha.kubernetes.io/unreachable
    operator: Exists
  - effect: NoSchedule
    key: node.kubernetes.io/disk-pressure
    operator: Exists
  - effect: NoSchedule
    key: node.kubernetes.io/memory-pressure
    operator: Exists
  volumes:
  - name: default-token-kh8lr
    secret:
      defaultMode: 420
      secretName: default-token-kh8lr
status:
  conditions:
  - lastProbeTime: null
    lastTransitionTime: 2018-03-16T03:31:15Z
    status: "True"
    type: Initialized
  - lastProbeTime: null
    lastTransitionTime: 2018-04-25T08:04:03Z
    status: "True"
    type: Ready
  - lastProbeTime: null
    lastTransitionTime: 2018-03-16T03:31:18Z
    status: "True"
    type: PodScheduled
  containerStatuses:
  - containerID: docker://8c5496d108185c373f50ce15b06dad1a06e29cc2b21c8f4bb383de4ee1cbe259
    image: quay.io/kubernetes-ingress-controller/nginx-ingress-controller:0.9.0-beta.19
    imageID: docker-pullable://quay.io/kubernetes-ingress-controller/nginx-ingress-controller@sha256:580bbf70930992897c43a439e1e444ae160320c17c517eaf2fe02fdbbaad56c1
    lastState:
      terminated:
        containerID: docker://d9f99a3e4cd7105ed7d5f80a2b15697140ad9f7b6c3e4d7e8b09f78497b9503e
        exitCode: 137
        finishedAt: 2018-04-25T08:03:56Z
        reason: OOMKilled
        startedAt: 2018-04-25T01:46:17Z
    name: nginx-ingress-controller
    ready: true
    restartCount: 135
    state:
      running:
        startedAt: 2018-04-25T08:03:58Z
  hostIP: <IP_ADDRESS>
  phase: Running
  podIP: <IP_ADDRESS>
  qosClass: Guaranteed
  startTime: 2018-03-16T03:31:15Z

Unfortunately I do not know how to reproduce either. However we see a behaviour that seems to also fit this. helm get show something different that is actually applied to Kubernetes - seeing this both for deployment and config-map resources.

I'm also seeing the same issue here, I even did delete all things and releases before, and do uninstall and then install with the new configuration rather than upgrade, but it still apply the old configuration to the new deployment. It worked previously but just suddenly started to not working, and couldn't get it back to work again. I'm using stable/prometheus-postgres-exporter.

Is there any update on this? We are facing the same while updating our resources via helm upgrade in our brigade pipeline. The values get updated but the resources remain the same. It's a deal breaker and is preventing us from taking brigade and helm to production. Using v2.10.0

I'm also facing the same issue when installing the stable/jenkins chart using v2.10.0. After the initial installation, the kube resources would not reflect the change in Agent.resources after calling helm upgrade -f values.yaml [RELEASE] stable/jenkins. Calling helm get values [RELEASE showed that the values were correctly set in the chart, however the resources do not reflect the change. I also tried adding the --force and --recreate-pods options to the helm upgrade command however produced the same results (--force didn't even recreate the deployment). Lastly, I tried manually deleting the jenkins deployment and then calling update again (with those same options), but that did not work. Without being able to change Agent.resources, the Jenkins executer dies with an OOM during every build.
The solution was to entirely delete the chart and reinstall, but this time having my desired values set in values.yaml first. Luckily my org was not reliant on Jenkins before I ran into this problem, otherwise this solution would not have been feasible.
helm upgrade performs inconsistently; sometimes updated values propagate all the way down to the resources, and sometimes they don't. It's unclear whether this problem is solely within helm upgrade, or if it's chart dependent. However it's clear from this thread that the same problem has appeared for various charts and more investigation should be given.

same with me on helm 2.10.0

values.yaml

node:
  image:
    repository: quay.io/image
    tag: v1

statefulset

apiVersion: apps/v1
kind: StatefulSet
...
    spec:
      containers:
      - name: container1
        image: {{ index .Values "node" "image" "repository" }}:{{ index .Values "node" "image" "tag" }}
....
      - name: container2
        image: {{ index .Values "node" "image" "repository" }}:{{ index .Values "node" "image" "tag" }}

As the result only one (random) container takes value, the other leaves the old one

Currently experiencing the same issue as https://github.com/helm/helm/issues/2735#issuecomment-319941359 above
versions:
Client: &version.Version{SemVer:"v2.11.0", GitCommit:"2e55dbe1fdb5fdb96b75ff144a339489417b146b", GitTreeState:"clean"}
Server: &version.Version{SemVer:"v2.11.0", GitCommit:"2e55dbe1fdb5fdb96b75ff144a339489417b146b", GitTreeState:"clean"}

Maybe related, a self-contained example with kubernetes-dashboard is provided https://github.com/helm/helm/issues/3030

I am finding myself in the same situation at the moment: when I decided to switch to helm I had a service and deployment configuration applied to my cluster, I then created my own chart that was targeting that very set of service and deployment.
When I had to install it, after reading the docs I opted for the command:
helm upgrade --install --force $SERVICE_NAME  $SERVICE_NAME/ -f configs/$SERVICE_NAME/env-configs/dev_config.yml --tls

This created the new release with the name I provided, deleted all pods that were running and redeployed them via tiller.
So far so good, only thing is that when manually changing a resource via the k8s api with kubectl - deployment config for example, changing the replicas - helm does not show that the resource has been changed.
Furthermore, as someone stated above, if I do helm get $SERVICE_NAME the result is what the original release was, as I would expect, but no matter what command I use, helm won't rollback to the original "source of truth".

DaemonSet updates might be related to updateStrategy.type=OnDelete
kubectl get ds <DS-NAME> -o go-template='{{.spec.updateStrategy.type}}{{"\n"}}'
See https://kubernetes.io/docs/tasks/manage-daemon/update-daemon-set/

Same problem here. With --debug, the deployment output is correct but kubectl get deployment -o yaml shows another thing. Also helm manifest shows the expected deployment yaml, but not the one deployed in the k8s cluster.
$ helm version
Client: &version.Version{SemVer:"v2.12.2", GitCommit:"7d2b0c73d734f6586ed222a567c5d103fed435be", GitTreeState:"clean"}
Server: &version.Version{SemVer:"v2.12.0", GitCommit:"d325d2a9c179b33af1a024cdb5a4472b6288016a", GitTreeState:"clean"}

$ kubectl version
Client Version: version.Info{Major:"1", Minor:"13", GitVersion:"v1.13.2", GitCommit:"cff46ab41ff0bb44d8584413b598ad8360ec1def", GitTreeState:"clean", BuildDate:"2019-01-10T23:35:51Z", GoVersion:"go1.11.4", Compiler:"gc", Platform:"linux/amd64"}
Server Version: version.Info{Major:"1", Minor:"12", GitVersion:"v1.12.4", GitCommit:"f49fa022dbe63faafd0da106ef7e05a29721d3f1", GitTreeState:"clean", BuildDate:"2018-12-14T06:59:37Z", GoVersion:"go1.10.4", Compiler:"gc", Platform:"linux/amd64"}

K8s cluster deployed on premise.

careful with helm template | kubectl apply because if you have hooks defined, they will be executed as well. (you don't want a rollback job to be executed during an upgrade for example).

$ helm version
Client: &version.Version{SemVer:"v2.12.0", GitCommit:"d325d2a9c179b33af1a024cdb5a4472b6288016a", GitTreeState:"clean"}
Server: &version.Version{SemVer:"v2.12.0", GitCommit:"d325d2a9c179b33af1a024cdb5a4472b6288016a", GitTreeState:"clean"}

$ kubectl version
Client Version: version.Info{Major:"1", Minor:"11", GitVersion:"v1.11.3", GitCommit:"a4529464e4629c21224b3d52edfe0ea91b072862", GitTreeState:"clean", BuildDate:"2018-09-10T11:44:36Z", GoVersion:"go1.11", Compiler:"gc", Platform:"darwin/amd64"}
Server Version: version.Info{Major:"1", Minor:"11", GitVersion:"v1.11.3", GitCommit:"a4529464e4629c21224b3d52edfe0ea91b072862", GitTreeState:"clean", BuildDate:"2018-09-09T17:53:03Z", GoVersion:"go1.10.3", Compiler:"gc", Platform:"linux/amd64"}

Purposely made helm upgrade failed by pointing Deployment to a non-existent ConfigMap.
apiVersion: apps/v1
kind: Deployment
...
        envFrom:
          - configMapRef:
              name: templateapi-env1                # non-existent
          - secretRef:
              name: templateapi-secrets
...

Even after reverting the commit, and did helm upgrade again, it still failed. When I checked the deployment. It is still looking for the non-existent ConfigMap. Can't even rollback to last DEPLOYED release.

 The key is to never run helm upgrade if latest release is in FAILED state. So, let's say your latest release is in DEPLOYED state and then you merge a bad PR and run helm upgrade causing it to fail. Before you revert the PR and run helm upgrade again (roll-forward), do a helm rollback to the last DEPLOYED release first and then run helm upgrade.

Very Sad 😢

I was having this issue in the 3.0.0-alpha1 release but solved by installing Helm 2.14.0

We are seeing this with non-errored DEPLOYED releases being upgraded with a change in values. Helm says all went well, but the DaemonSet was not updated. Specifically, this was via Weaveworks Flux (some Google keywords there for anyone looking for this problem), and we spent some time thinking it was that that was not pushing on changes.
Client: &version.Version{SemVer:"v2.13.0", GitCommit:"79d07943b03aea2b76c12644b4b54733bc5958d6", GitTreeState:"clean"}
Server: &version.Version{SemVer:"v2.13.0", GitCommit:"79d07943b03aea2b76c12644b4b54733bc5958d6", GitTreeState:"clean"}

consolidating this into #5915. Helm 3 recently has implemented a three-way merge patch strategy which should alleviate some of the issues here. Please follow up with that ticket so we can keep the conversation relevant and all in one place. Thanks!

Not a fair decision IMHO to close this 2.x.x related issue with "see ya in 3.0" resolve message:

All the cases here are related to 2.x.x, and I'm far from thinking that everyone is OK to apply this migration right away
People using the 2.x.x may search for opened issues and find nothing (though this one still exists in almost all 2.x.x version of helm, at least according to the discussion thread).

@bacongobbler could you please reopen the issue, in order to make the it's state relevant and the issue itself transparent to all people coming to the repo page?

Not a fair decision IMHO to close this 2.x.x related issue with a "see ya in 3.0" resolve message:

All the cases here are related to 2.x.x, and I'm far from thinking that everyone is OK to apply this migration right away
People using the 2.x.x may search for opened issues and find nothing (though this one still exists in almost all 2.x.x version of helm, at least according to the discussion thread).

@bacongobbler could you please reopen the issue, in order to make the it's state relevant and the issue itself transparent to all people coming to the repo page?

I don't think reopening the issue is the appropriate solution here. https://github.com/helm/helm/issues/5915 should be updated to say
...
This issue is meant to consolidate is #1844, #3933, and #2735.

People using the 2.x.x may search for opened issues and find nothing (though this one still exists in almost all 2.x.x version of helm, at least according to the discussion thread).

That's the point of the new issue, to group up common issues like this one into #5915. People can still find this issue via google/closed-issues and see the reference to #5915 and continue the discussion there.

@KadenLNelson ok, so do I get it right that #5915 will stay open till we get to a root cause/fix for helm 2.x.x? I mean I agree it makes sense to keep some entry point for these similar misbehaving upgrade issues; just not a fan of resolving all of them via fixed in helm 3.0.0.

till we get to a root cause/fix for helm 2.x.x?
If that ever happens, this is a community driven project, and most of the resources are going towards making Helm3 a better product and not towards providing backwards compatibility support for Helm2.

I have had several problems using helm upgrade, including this one, I recommend that you avoid using it, Helm is good for installing a component but not for maintenance.
At the moment I don't know how to solve this, that I don't update my Kubernetes kinds.  In my case the client already has everything designed to use it in this way, I hope we change that soon.
Someone here found a solution? Thanks so much!

@GloriaPG can you please share what issues you are experiencing, optimally in a new ticket? We need test cases to help verify whether you found a bug, and if we need to clarify something in the documentation or if there's something else we can do to help.

@GloriaPG can you please share what issues you are experiencing, optimally in a new ticket? We need test cases to help verify whether you found a bug, and if we need to clarify something in the documentation or if there's something else we can do to help.

Sure, I will, thanks for your reply.


⚠ Secret Website 2 has degraded performance

In a29a618, Secret Website 2 ($SECRET_WEBSITE_2) experienced degraded performance:

HTTP code: 200
Response time: 12498 ms

Resolved: Secret Website 2 performance has improved in 651b081.


Tests for invalid poly order

Proposed changes

Modifies high_parser/types.py, which adds min/max constants and checks for out-of-bounds or non-power of two poly order.
Adds a new test function to test_kerngen.py to test for various invalid poly order.

Types of changes
What types of changes does your code introduce to the HE Toolkit project?
Put an x in the boxes that apply

[ ] Bugfix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Documentation update (if none of the other choices apply)

Checklist
Put an x in the boxes that apply. You can also fill these out after creating
the PR. If you are unsure about any of them, do not hesitate to ask. We are
here to help! This is simply a reminder of what we are going to look for before
merging your code.

[x] I have read the CONTRIBUTING agreement
[x] Current formatting and unit tests / base functionality passes locally with my changes
[x] I have added tests that prove my fix is effective or that my feature works (if appropriate)
[x] I have added necessary documentation (if appropriate)
[x] Any dependent changes have been merged and published in downstream modules

Further comments
In a future PR, NATIVE_POLY_MOD, MIN_POLY_SIZE, and MAX_POLY_SIZE will be parameters that are user configurable rather than constant variables.

See suggested changes Thanks

I accepted the changes you proposed. Thanks for providing clarity about minimum poly order.


feature: support basic authentication when using a proxy

closes #1067

Thanks for all the cleanup changes! I know I'm guilty of it, but for future PRs, maybe put them in a separate PR. Makes it a lot easier to review.

Yah. The refactor was needed for this PR, which is why I did it. I couldn't easily get the proxy creds to the web parts otherwise.


mate/mate-screensaver: fixed unixAuth

Without this fix, it's not possible to unlock the mate-screensaver.

18.03:
[detached HEAD 41a9722917f] mate/mate-screensaver: fixed unixAuth
Author: Johannes Lötzsch<EMAIL_ADDRESS>Date: Sun Apr 1 18:27:55 2018 +0200
1 file changed, 2 insertions(+)


Virus detector misrecognizes Krita files as viruses

Downloads for .kra files are registered as viruses by McAfee

Okay. I mean, that's not too surprising :P Virus detectors misrecognize files all the time. This would be a security issue.. if the files were actually executable viruses. But they're just Krita files, and I'll be shocked if McAfee is looking at ways that a Krita file might attack your computer if you were to open it in Krita. If you're worried, though, you can open the files in a virtual machine.
It would be nice to get this fixed so you don't get the warning, though. I don't have experience with McAfee - could it be that the issue is that the file was downloaded from florrie.ed1.club, which isn't a domain McAfee recognizes as "trustworthy"? Does downloading the file from GitHub (e.g. by clicking "View Raw" on this page) still show the warning? (Or maybe McAfee doesn't look at download locations at all; that wouldn't be too surprising.)
I'm pretty sure this issue is totally out of my control, though. You'll probably just have to dismiss the warning.

It said in the download thing at the bottom left corner in chrome "virus detected". McAfee scans all downloaded files to make sure they are safe.

@amazinigmech2418 Okay, good to know. I don't think I can do anything about this but give you my word that the files are safe, as long as you're opening them with Krita. There's not much I can do about McAfee seeing my files as not safe. It's sort of like if people were asking me to add a lock to my (imaginary) safe, but they just can't see the lock, which is on the bottom of the safe. So my safe ends up looking not secure to them, even though it is secure. Same deal with McAfee - it thinks my files are viruses, because they look like viruses to it, but they aren't.


JSON.parse is much faster

As titled. I did something wrong?
const jitson = require("./");

const testPayload = JSON.stringify({ hello: "world", number: Math.random() });

// make an instance
const parse = jitson();
console.time("jitson");
for (var i = 0; i < 100; i++) {
  parse(testPayload);
}
console.timeEnd("jitson");

// Check if the compiler found a matching schema.
// If so it is using an optimised parser to parse the JSON
console.log(parse.schema);

console.time("JSON.parse");
for (var i = 0; i < 100; i++) {
  JSON.parse(testPayload);
}
console.timeEnd("JSON.parse");

Result:
jitson: 3.855ms
{ type: 'object',
  ordered: true,
  properties: { hello: { type: 'string' }, number: { type: 'number' } } }
JSON.parse: 0.070ms

Your benchmark run is too small. Try running it longer using fx 10000 instead of 100. Jitson is fast because it produces code that is easy for v8 to optimise. However for v8 to optimise it the function needs to be "hot", ie called many times.

I tried it with 10000 but JSON.parse is still faster. Firstly with a benchmark of 55000 jitson will be faster than the native method. In theory my http server would need to handle at first 55000 requests (much slower than with the native method) until jitson (more precisely V8 makes the right assumption about the function) gets fast?
In my opinion this information should be added to the readme in order to make clear that the performance optimization depends on other factors not only jitson, turbo-json-parse.


Factorial program using BigInteger class in Java

Description
The program will be able to print the factorial of a number of any length using the BigInteger class in Java.
Important Checklist

[x] I have read the contribution guidelines before making this issue.
[x] I have verified this issue program is not already implemented
[x] I have not pushed this code anywhere else (even my repo)

Languages and Assignees:

[ ] Python: @
[x] Java: @prateekrai123
[ ] C: @
[ ] C++: @

We are done with any type of factorial!