[5.0] Add parameters back into middleware

EDIT: See my comment for the resolution:
In 4.2, you could create a really elegant permission system by attaching filters to routes, without having to include anything in controllers:
Route::post('/admin/users/{id}/ban', [
            'before' => 'can:ban.users',
            'uses' => 'AdminUserController@ban' ]);

But the above is not possible using middleware - it is effectively impossible to use a permission class via  middleware because of it, unless you want to couple your permission key to a route name, which is not desirable (and not as flexible).
It would be enormously beneficial if middleware could accept parameters.
And if the answer is to continue using filters, then the filter service provider and folder for filters should be re-included by default, along with documentation for it. As of now, legacy filter support is a hidden feature which is also undesirable.

We're open to pull requests. :)

What status of this task?

Unsolved. Closed because nobody was interested in writing a solution.

I'm interested, but I have't match experience with Laravel for solving this task.
I think if filters is deprecated we should able to have same functionality. Now middleware is filters except passing parameters.

So because no one has written a solution yet, you close the ticket out? Seems like an odd way to manage feature requests. Usually feature requests remain open until solved or decided it will never be added.
This is still a feature that has been asked for numerous times on IRC.

So apparently there is a solution to this that works perfectly fine. You can define any arbitrary array key => value in your route
Route::get('/foo/bar', [
	'as'   => 'foo',
	'uses' => 'FooController@bar',
	'middleware' => 'authorize',
	'permission' => 'foo.bar'
]);

Then in the middleware's handle() method you can do:
$request->route()->getAction()['permission']; //foo.bar

Or you can even pass in an array:
Route::get('/foo/bar', [
	'as'   => 'foo',
	'uses' => 'FooController@bar',
	'middleware' => 'authorize',
	'permission' => ['array', 'of', 'many', 'permissions']
]);

Or a full object if you want:
Route::get('/foo/bar', [
	'as'   => 'foo',
	'uses' => 'FooController@bar',
	'middleware' => 'authorize',
	'permission' => new Permission('foo.bar')
]);

So this behavior of route actions is actually BETTER than the old filter parameters by miles. Not sure why Taylor never really mentioned this when it's a fantastic solution.

@GRAgmLauncher Yep, but when I use middleware in Controller I do not able to set parameters.
...
public function __construct() {
  $this->middleware('rolechecker', ['only'=>['index']]);
}
...

I can only set scope of actions where I can use this middleware, but can't set: what roles have access to this actions.
How I can pass parameters to middleware from controller?

@GRAgmLauncher this might be OK for your own middleware. But if you develop middleware as part of a package, you can't just dictate to your users to use some random key in their route action - eventually it's bound to clash with someone else's middleware.
Unless you would advise them to use a package-specific naming convention, which is pretty ugly if you ask me - and there's nothing visually tying the two together.
It's a nice temporary workaround, but it's not a solution. At all.

I think we need same way to pass params as params in filters.
class BirthdayFilter
{
    public function filter($route, $request, $first, $second, $third)
    {
        echo "{$first} - {$second} - {$third}";
    }
}

Filter called from Route:
Route::get('/', array(
    'before'    => 'birthday:foo,bar,baz',
    function()
    {
       return View::make('hello');
    }
));

Filter called Controller:
public function __construct() {
  $this->beforeFilter( 'birthday:foo,bar,baz');
}

How it maybe can look for Middleware.
class Birthday {
	public function handle($request, Closure $next, $first, $second, $third)
	{
		echo "{$first} - {$second} - {$third}";
		return $next($request);
	}
}

Middleware called from Route:
Route::get('/', array(
    'middleware' => ['birthday:foo,bar,baz'],
    function()
    {
       return View::make('hello');
    }
));

Middleware called Controller:
public function __construct() {
  $this->middleware( 'birthday:foo,bar,baz');
}

Agree, it's a common feature that must be implemented. I'm really dont understand why Taylor need to remove awesome filters, and REPLACE it with Middleware. We NEED filters back, but not instead of middleware, but both.

I tried to implement middleware parameters like in filters, but common problem in algorithm that call middleware - Pipeline. I can't pass parameters to each middleware separately. Only can pass one params to all call's. Maybe someone can advice how to pass parameters through Pipeline for each middleware separately?

@dominikveils Filters are still there actually, the documentation just doesn't really mention them.

@bastiaan89 filters are deprecated, so I can't rely on them for a long term. Next commit @taylorotwell will remove them, and what will I do?

@dominikveils Oh right sorry, I didn't know about that. Actually I'm in the same boat then, I have converted a project to L5 but it relied on filters with parameters. To be honest I don't really get the point of middleware over filters anyway. The global middleware is fine, but the route ones don't make much sense to me.

@bastiaan89 yes, global middleware are perfect, but an idea to make route-middleware instead of - is crappy. Taylor need to return filters back... it's useless to use middleware for filters.

@dominikveils I only need parameters for middleware (for mw called from controllers and routers). I think filters and middleware is competing approaches. If filters are deprecated I do not think that it will be roll back in future.

Well, I think the most guys want this because they just need a simple permission check. and put all permissions to a middleware is not so accurate.  So we created a facade do this:
class RoutePermissions {

    /**
     * @var array of controller => [action => permission]
     */
    protected $actions = [];

    /**
     * add a controller's action permission
     *
     * @param \App\Http\Controllers\Controller $controller
     * @param array $permissions
     */
    public function addPermission(Controller $controller, $permissions)
    {
        $this->actions[get_class($controller)] = $permissions;
    }

    /**
     * get permission name according to the controller and action
     *
     * @param string $controller
     * @param string $action
     * @return null|string permission name or null
     */
    public function permission($controller, $action)
    {
        if(isset($this->actions[$controller]))
        {
            if(isset($this->actions[$controller][$action]))
                return $this->actions[$controller][$action];
        }

        return null;
    }

this class will store each route on each controller with action's permission, so with this, I can set permissions for each action.
and in each controller who need some permissions:
        \RoutePermissions::addPermission($this,
            ['create' => 'announce.create']);

this means in this controller's create action, we need to check the announce.create permission, and all other actions don't need to check the permission.
after that,  in our middleware handle function:
                $action = explode('@', $request->route()->getActionName());
                $perm = \RoutePermissions::permission($action[0], $action[1]);

so with these codes, we can get permissions on each action in each controller, if some actions don't have permissions, $perm will be null.
I can say that no matter how large is your application, you won't have thousands of permissions, so the memory of course will be less than the compiled.php file, and string compare is also fast.
I think this is another simple solution to middleware permission check.
and of course, say if you want to check announce.system permission in create action, that's because you will need to check different permission when user post different options. and that is also easy: custom validation rules.

What I don't understand is that I can pass parameters when doing some like.
Route::group( [ 'middleware' => 'license.permissions', 'permissions' => ['document'] ], function () {
    ...
} );

This then gives me.
Array
(
    [middleware] => Array
        (
            [0] => auth
            [1] => license.permissions
        )

    [permissions] => Array
        (
            [0] => document
        )

    [as] => permissions
    [uses] => HRPulse\Http\Controllers\PermissionsController@getDisplay
    [controller] => HRPulse\Http\Controllers\PermissionsController@getDisplay
    [namespace] => HRPulse\Http\Controllers
    [prefix] =>
    [where] => Array
        (
        )

)

But when doing $this->middleware() there is no way to pass in that 'action'. There just needs to be a way to take in extra parameters. Maybe a new option in the middleware method that will put this in the actions of the request?

I may be looking at the wrong middleware definition here, but in ./framework/src/Illuminate/Routing/Controller.php there is:
/**
 * Register middleware on the controller.
 *
 * @param  string  $middleware
 * @param  array   $options
 * @return void
 */
public function middleware($middleware, array $options = array())
{
    $this->middleware[$middleware] = $options;
}

Which should be able to be passed an array?

But $options do not passed to middleware. $options only for internal
framework usage.
On 31 March 2015 at 23:18, James Brooks<EMAIL_ADDRESS>wrote:

I may be looking at the wrong middleware definition here, but in
./framework/src/Illuminate/Routing/Controller.php there is:
/** * Register middleware on the controller. * * @param  string  $middleware * @param  array   $options * @return void */public function middleware($middleware, array $options = array()){    $this->middleware[$middleware] = $options;}
Which should be able to be passed an array?
--
Reply to this email directly or view it on GitHub
https://github.com/laravel/framework/issues/6470#issuecomment-88231870.

--
Mobile: +38 099 669 15 06

Done in 5.1.

:ship: :rocket: :ship: :tada: :trophy:

:+1:

Great, thank you!

Awww yisss
On Thursday, April 23, 2015, jmas<EMAIL_ADDRESS>wrote:

Great, thank you!
—
Reply to this email directly or view it on GitHub
https://github.com/laravel/framework/issues/6470#issuecomment-95695428.

:+1:

Awesome @taylorotwell :+1:

Trying it soon! :+1:

Works like a charm!


multi: don't ignore node announcement of channel peer

Fixes #8870.
Due to unfortunate timing, it's possible for a node announcement of the peer we just opened an unannounced channel with to come in before we've added them to our graph.
But because the link is already present, we can just ask the switch if we know the peer, making sure this still isn't a DoS vector (in-memory lookup instead of channel database query).

We found another workaround for unblocking the integration tests. So this will be fixed in a more clean way (see https://github.com/lightningnetwork/lnd/issues/8870#issuecomment-2192464477).


Add documentation

Codecov Report

Merging #3 (f0d12fe) into master (f0778c6) will decrease coverage by 0.06%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master       #3      +/-   ##
==========================================
- Coverage   25.64%   25.57%   -0.07%
==========================================
  Files           6        6
  Lines         390      391       +1
==========================================
  Hits          100      100
- Misses        290      291       +1

Impacted Files
Coverage Δ

src/transformation.jl
0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f0778c6...f0d12fe. Read the comment docs.


What is the reason for installing WindiCSS as a dev dependency?

Simply curious about this choice. I am getting this error:

in shims.d.ts as suggested by https://github.com/windicss/windicss/pull/322
I know this is an eslint rule.

maybe it's related to how you use the package? If you manually import it in your files that suppose to be working in production instance - ESLint will warn you about such thing because your code will just break if you will install dependencies with a --production flag


Set up test producers/consumer

Overview
Task
Set up two test producers (one which produces a constant stream of messages and one which produces a batch of several thousand messages and then disconnects) as well as a test consumer to consume those messages. This allows the generation of messages in the background while running the application for testing purposes.

[ ] Bug
[x] Feature

Description
Created a consumer, producer, and massProducer from the old test.js test producer/consumer, refactoring all to Typescript.
Ticket
Trello
Feature Validation / Bug Reproduction Steps

npm run demo-cluster; give the cluster a minute to spin up.
Navigate to localhost:3000 and log into Grafana using the credentials in the docker-compose-cluster.yml
Navigate to localhost:5175/cluster to view the Kafka Sonar front end.
In VSCode, open 3 terminals side-by-side.  (The clients can be run in parallel). As messages are produced, they should dynamically log in the terminal running the consumer. The terminal running the producer also logs its messages to the console, but the mass producer does not in order to facilitate repeated runs without having to kill it and restart it manually.
From the Kafka Sonar front end, observe the metrics in the cluster under Broker I/O update in real-time. Note: these metrics will only be visible if you have the (still WIP) Grafana dashboards on your local machine, which are not included in the repo as of this PR. I believe most of you already do, but if not just send me a message and I'll send them to you.

Previous Behavior
The producer/consumer were run out of one file. The producer produced one message and disconnected, and then the consumer consumed it and disconnected, making it difficult to produce large volumes of messages for stress testing the cluster and/or populating the cluster for testing purposes.
Expected Behavior
The producer and consumer have been separated, and two different producers have been written. Now a constant stream of messages can be produced to the cluster with the ability to easily manufacture a massive influx of messages by running the mass producer one or more times in a row.
Screenshots & Videos

Messages in per sec should spike shortly after running the mass producer. As long as the terminal running the normal producer is not killed, these metrics should not drop to zero.

In the Grafana search bar -> Kafka Topics / Logs, set the topic to test-topic and you should observe the total log size increasing over time.

@mjsway Excellent work here, and thank you for the explanations about steps to reproduce.
About the Grafana dashboards, I'm not certain what you mean by we need them on our local machines. Per our discussion yesterday, I tried commenting out demo-cluster/configs/grafana from the .gitignore file and then composing up the containers. When I logged into Grafana through the Docker link to localhost:3000, I couldn't see the project dashboards. The FE iframes also say the various Grafana panels / metrics / time series are not available. Lmk if I'm missing something here.

@unatarajan Just to clarify, does your demo-cluster directory look like this?

These are the files I meant when I said you need them on your local machine because we haven't PR'd them into the repo yet as they're still in development. Without these, Grafana does't know what to do with the metrics we expose to it via Prometheus.

@mjsway Thanks for clarifying! Makes sense now - my demo-cluster/configs/grafana subdirectories are empty. If you can share the files, I will re-test.

@unatarajan Done! Check Slack.


DPO微调InternVL2-2B时报错

    loss = self.compute_loss(model, inputs)
  File "/home/tiger/.local/lib/python3.9/site-packages/trl/trainer/dpo_trainer.py", line 1408, in compute_loss
    loss, metrics = self.get_batch_loss_metrics(model, inputs, train_eval="train")
  File "/mnt/bn/arnold-ghh-test/mlx/users/guihonghao/playground/ghh_swift/swift/swift/trainers/dpo_trainer.py", line 115, in get_batch_loss_metrics
    forward_output = self.concatenated_forward(model, batch)
  File "/mnt/bn/arnold-ghh-test/mlx/users/guihonghao/playground/ghh_swift/swift/swift/trainers/dpo_trainer.py", line 235, in concatenated_forward
    outputs = model(
  File "/usr/local/lib/python3.9/dist-packages/torch/nn/modules/module.py", line 1518, in _wrapped_call_impl
    return self._call_impl(*args, **kwargs)
  File "/usr/local/lib/python3.9/dist-packages/torch/nn/modules/module.py", line 1527, in _call_impl
    return forward_call(*args, **kwargs)
  File "/home/tiger/.local/lib/python3.9/site-packages/deepspeed/utils/nvtx.py", line 15, in wrapped_fn
    ret_val = func(*args, **kwargs)
  File "/home/tiger/.local/lib/python3.9/site-packages/deepspeed/runtime/engine.py", line 1846, in forward
    loss = self.module(*inputs, **kwargs)
  File "/usr/local/lib/python3.9/dist-packages/torch/nn/modules/module.py", line 1518, in _wrapped_call_impl
    return self._call_impl(*args, **kwargs)
  File "/usr/local/lib/python3.9/dist-packages/torch/nn/modules/module.py", line 1547, in _call_impl
    args_kwargs_result = hook(self, args, kwargs)  # type: ignore[misc]
  File "/mnt/bn/arnold-ghh-test/mlx/users/guihonghao/playground/ghh_swift/swift/swift/llm/utils/template.py", line 323, in _pre_forward_hook
    res_extra.append(self._post_encode(d))
  File "/mnt/bn/arnold-ghh-test/mlx/users/guihonghao/playground/ghh_swift/swift/swift/llm/utils/template.py", line 1922, in _post_encode
    inputs_embeds[selected] = vit_embeds.reshape(-1, vit_embeds.shape[-1])
RuntimeError: shape mismatch: value tensor of shape [3840, 2048] cannot be broadcast to indexing result of shape [3628, 2048]

这段代码处报错。
打印了几行结果看，input_embeds应该是包含了文本和图片token，所以vit_embeds.reshape(-1, vit_embeds.shape[-1])后的第一维应该小于inputs_embeds的第一维。6 * 256 = 1536 < 2549。但是上面的例子里面 3840 = 15 * 256 > 3628，vit_embeds第一维>inputs_embeds第一维导致错误，这是什么原因呢？
inputs_embeds.shape torch.Size([2549, 2048])
selected.shape torch.Size([2549])
vit_embeds.shape torch.Size([6, 256, 2048])
inputs_embeds.shape torch.Size([1057, 2048])
selected.shape torch.Size([1057])
vit_embeds.shape torch.Size([1, 256, 2048])

This is due to pixel values being padded when batch_size > 1.
Pull the latest code, this issue should have been fixed.

但是我的batch_size设置的是1啊

I guess it's because the input_ids were truncated due to insufficient length, try increasing the --max_length parameter.

https://github.com/modelscope/ms-swift/pull/1975

fixed


Integrate Youtube and SoundCloud in search

It would be awesome to be able to search these to services, perhaps even create somekind of custom playlist, where you can add YT, SC and Spotify tracks.

Agree - at some stage it would be good to implement more sources. I have also considered Google Music. At this stage the focus is on Spotify and local files, but will start thinking about the best way to expand to these media sources.

Great!
I actually think that mopify has basic implementation of youtube, so perhaps possible to get inspiration from there :)

It looks like the Mopidy-Youtube extension is quite basic, so I'm wary of the level of involvement to get this running to the same quality as Spotify and Local files.  I'll flag this functionality for a future release when that extension becomes a bit more stable.

PS. I have integrated the Soundcloud backend into the player functionality. You can now add items via URI (across all supported backends) as at 2.6.2 1ec26f7. I'll continue to explore what the best way is to integrate into the UI itself.

Basic integration in place for Soundcloud as at 2.6.3. This will be improved as we go to add browsing etc.


[gettext] build failure (WASM)

Host Environment

OS: Linux (Ubuntu 20.04)

To Reproduce
Steps to reproduce the behavior:
./vcpkg install gettext:wasm32-emscripten
Failure logs
➜ ./vcpkg install gettext:wasm32-emscripten
Computing installation plan...
The following packages will be built and installed:
    gettext[core]:wasm32-emscripten -> 0.21#2
Detecting compiler hash for triplet wasm32-emscripten...
Could not locate cached archive: /home/remi/.cache/vcpkg/archives/8e/8ea4abe0df24f0d55d258c7c7bfab3795863a5ea.zip
Starting package 1/1: gettext:wasm32-emscripten
Building package gettext[core]:wasm32-emscripten...
-- Using community triplet wasm32-emscripten. This triplet configuration is not guaranteed to succeed.
-- [COMMUNITY] Loading triplet configuration from: /home/remi/Documents/Projects/vcpkg/triplets/community/wasm32-emscripten.cmake
-- Using cached /home/remi/Documents/Projects/vcpkg/downloads/gettext-0.21.tar.gz
-- Cleaning sources at /home/remi/Documents/Projects/vcpkg/buildtrees/gettext/src/0.21-508c311661.clean. Use --editable to skip cleaning for the packages you specify.
-- Extracting source /home/remi/Documents/Projects/vcpkg/downloads/gettext-0.21.tar.gz
-- Applying patch 0002-Fix-uwp-build.patch
-- Applying patch 0003-Fix-win-unicode-paths.patch
-- Applying patch rel_path.patch
-- Using source at /home/remi/Documents/Projects/vcpkg/buildtrees/gettext/src/0.21-508c311661.clean
-- Configuring wasm32-emscripten-dbg
-- Configuring wasm32-emscripten-rel
-- Configuring wasm32-emscripten-dbg
-- Configuring wasm32-emscripten-rel
-- Building wasm32-emscripten-dbg
-- Installing wasm32-emscripten-dbg
-- Building wasm32-emscripten-rel
-- Installing wasm32-emscripten-rel
CMake Error at scripts/cmake/vcpkg_build_make.cmake:236 (file):
  file RENAME failed to rename

    /home/remi/Documents/Projects/vcpkg/packages/gettext_wasm32-emscripten_tmp/home/remi/Documents/Projects/vcpkg/installed/wasm32-emscripten

  to

    /home/remi/Documents/Projects/vcpkg/packages/gettext_wasm32-emscripten

  because: No such file or directory

Call Stack (most recent call first):
  scripts/cmake/vcpkg_install_make.cmake:26 (vcpkg_build_make)
  ports/gettext/portfile.cmake:68 (vcpkg_install_make)
  scripts/ports.cmake:142 (include)

Error: Building package gettext:wasm32-emscripten failed with: BUILD_FAILED
Please ensure you're using the latest portfiles with `./vcpkg update`, then
submit an issue at https://github.com/Microsoft/vcpkg/issues including:
  Package: gettext:wasm32-emscripten
  Vcpkg version: 2021-05-05-unknownhash

Additional context
I found a comment thread from the PR where the code at the stacktrace got introduced, where someone had a similar issue: https://github.com/microsoft/vcpkg/pull/10402#discussion_r399664529
I tried replacing vcpkg_install_make with vcpkg_build_make in  gettext/portfile.cmake as is mentioned there, which results in a different error (The folder /include is empty or not present ...)
The vcpkg/packages/gettext_wasm32-emscripten_tmp/ is empty. In vcpkg/packages/gettext_wasm32-emscripten there is a share/gettext directory containing vcpkg_abi_info.txt

After looking further into the comment I mentioned earlier, and reading the gettext install docs, I got it to build by adding
set(ADDITIONAL_INSTALL_OPTIONS DESTDIR "${CURRENT_PACKAGES_DIR}/share/gettext")
after set(ADDITIONAL_INSTALL_OPTIONS SUBPATH "/intl") in https://github.com/microsoft/vcpkg/blob/master/ports/gettext/portfile.cmake#L56

Thanks for posting this issue. wasm32-emscripten is a community triplet, and I saw you have resolve this issue. I am closing this issue for now.


Dev: error psalm analysis

ERROR: UndefinedClass - src/Controllers/MagicLinkController.php:39:27 - Type array<array-key, mixed> cannot be called as a class (see https://psalm.dev/019)
        $this->provider = new $providerClass();

ERROR: UndefinedClass - src/Controllers/MagicLinkController.php:39:27 - Type null cannot be called as a class (see https://psalm.dev/019)
        $this->provider = new $providerClass();

ERROR: UndefinedClass - src/Controllers/MagicLinkController.php:39:[27](https://github.com/codeigniter4/shield/actions/runs/4960040682/jobs/8876233136?pr=736#step:9:28) - Type scalar cannot be called as a class (see https://psalm.dev/019)
        $this->provider = new $providerClass();

see https://github.com/codeigniter4/shield/actions/runs/4960040682/jobs/8876233136?pr=736
Temporary solution:
-$providerClass  = setting('Auth.userProvider');
+$providerClass  = service('settings')->get('Auth.userProvider');

In the $providerClass variable above, try putting an inline PHPDoc:
/** @var class-string<UserModel> $providerClass */
$providerClass = ...

paulbalandan thank you!


Mocking class with constructor arguments

Say we have a class like so:
export default class FileLoader {
  private fileToLoad: string
  public constructor(fileToLoad: string) {
    this.fileToLoad = fileToLoad;
    this.loadFile();
  }

  private loadFile() {
    ...
  }
}

I don't see any way to create a mock of the FileLoader and and instantiate it and pass parameters to the constructor.

Why you want to pass arguments to mock? Mock has no implementation so constructor code would not be executed even if you pass arguments. Can you give an example what you try to do?

Sure, given the example above, I would like to stub out the implementation of loadFile to test whether the fileToLoad property has been set correctly.
// In my test
const fileLoaderMock = mock(FileLoader);
when(fileLoaderMock.loadFile).thenExecute( /* Verify that fileToLoad property has been set */)
instance(fileLoaderMock) // And here I'd need to pass in the constructor parameters.

Hi again. First of all you can use syntax like:
public constructor(private fileToLoad: string) { and then you don't have to worry about this if fileToLoad has been set.
Secondly fileToLoad so you would not be able to check if loadFile has been set.
And finally if you want the constructor to be called you should use spy instead of mock.


'latest' tag seems to be broken - docker

Gitea version (or commit ref): 'latest' docker image as of >1.5
Operating system: photonOS by vmware
Can you reproduce the bug at https://try.gitea.io:

[ ] Yes (provide example URL)
[ ] No
[x] Not relevant

Description
docker run --name=Gitea -v gitea-data:/data -p 22:22 -p 3000:3000 --net=DMZ --ip=<IP_ADDRESS> -d gitea/gitea:latest
bails out as follows:
docker: Error response from daemon: chown /var/lib/docker/volumes/gitea-data/_data: invalid argument.
See 'docker run --help'.

while
docker run --name=Gitea -v gitea-data:/data -p 22:22 -p 3000:3000 --net=DMZ --ip=<IP_ADDRESS> -d gitea/gitea:1.5
just works fine.
Details about the image tagged as 1.5:

sha256:cf381b60bc302b6a484b677d547af73f289365a023879a53c5b8ca513b5f0156
Size: 75.4 MB
Created:  2018-07-12 18:13:34
Build on Docker 17.12.0-ce on linux, amd64

gitea-data is a named volume living on a NFS server.

How do you mount the nfs volume into the docker container?

I think your problem could be somehow related to https://github.com/moby/moby/pull/33695

That shouldn't be able to break things that hard. It's got to do with chown... at least in some way as I squash root on NFS as usual.

anything I am able to help here?

I don't know how gitea docker image would have broken as not much has changed either in build process nor dockerfile. Did you try nocopy? I found this recommendation in multiple places for such problem

I use nocopy. But the main question still remains: 1.5 and 1.5.1 work perfectly.

I have no explanation for that :(

Okay. Back to the root(s): I'm going to build it locally.


Change default UI to v3

After resolving this issue, the default UI will be v3, implemented in React, which we have been trying to enhance the UI/UX in general. There are a few things missing in v3 yet(we are working on it) so if you look up those features, you can still use them in the previous ui(aka. v2).
There is a navigation button on the left-bottom of the sidebar for switching back and forth between v2 and v3 like below.

https://github.com/pinpoint-apm/pinpoint/pull/11034


feat(dotenv) add dotENV icon

Fixes #1563 #2278
Adds the official dotENV icon for all supported .env files.
Changes proposed:

[x] Add
[ ] Delete
[ ] Fix
[ ] Prepare

Icon Source:

normal icon
light icon

)

@voidei not sure what happened with this PR but somehow, when I was about to review it, I saw it had no changes and it was automatically merged with 0 changes. Do you know something?

@robertohuertasm I have no idea, I got a notification for it several hours ago but it came up with nothing new on this end. I can recreate the PR and reopen it easily, I really don't understand where the changes I made went :thinking:

@jerone good catch!

@kurucaner this has not been released yet. We had an issue in this PR. There's another one with these changes. Hopefully I will prepare another release by the end of the week.


Component is not showing after ng build --prod

using ng serve the app is working fine
but when i make a build using ng build --prod then a comonent is not showing in the ui
all component elements showing as hidden
sometimes with normal build using 'ng build' the component is showing in the ui.
and there is no error in console and while making the build
Angular cli version -> 1.7.3

It's because of the CSS.
There is some kind of bug right now in prod versions which reverses the order of the CSS imports:
https://github.com/angular/angular-cli/issues/8577

I am having the same problem, even with new update, I have read that the default is with dev, see if running your build with —prod helps you

@BranCounts i tried with ng build --prod but it doesn't work for me. My component still not showing in the build.

Not sure what the problem is, are you using express to serve it?

Thanks for reporting this issue. However, you didn't provide sufficient information for us to understand and reproduce the problem. Please check out our submission guidelines to understand why we can't act on issues that are lacking important information.
If the problem persists, please file a new issue and ensure you provide all of the required information when filling out the issue template.


Edits for miscellaneous improvements

@alkohli @dansisson
IMPORTANT: When the changes are ready for publication, add a #sign-off comment to signal that the PR is ready for the review team to merge.
#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team


cmd/compile: use &runtime.zerobase for static pointer-to-zero-sized-thing

package p

type I interface{ F() }

var V = []I{
	T{},
}

var P = &T{}

type T struct{}

func (t T) F() {}

go tool compile -S x.go includes:
"".V SDATA size=24
	0x0000 00 00 00 00 00 00 00 00 01 00 00 00 00 00 00 00  ................
	0x0010 01 00 00 00 00 00 00 00                          ........
	rel 0+8 t=1 ""..stmp_0+0
"".P SDATA size=8
	0x0000 00 00 00 00 00 00 00 00                          ........
	rel 0+8 t=1 ""..stmp_2+0
""..stmp_0 SDATA static size=16
	0x0000 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00  ................
	rel 0+0 t=24 type."".T+0
	rel 0+8 t=1 go.itab."".T,"".I+0
	rel 8+8 t=1 ""..stmp_1+0
""..stmp_1 SNOPTRBSS static size=0
""..stmp_2 SNOPTRBSS static size=0

Note that we're making static tmp symbols for zero-sized things. We should be able to omit stmp_1 and stmp_2 here and use a pointer to runtime.zerobase instead.
This happens a handful of times in std, but not enough for significant wins. Low priority.

The linker would combine all the zero-size static tmps and even with other static tmps. Does it actually matter?
Maybe not because it is not marked readonly? Maybe we could mark all zero-size data read-only.

The linker would combine all the zero-size static tmps and even with other static tmps. Does it actually matter?

Realistically, not very much.


Switch issue templates to use new-style issue types

Summary
Qiskit is part of the new-style GitHub issues beta^1, which gives us access to a special kind of "super" label: the issue "type".  We've previously used two special labels ("bug" and "type: feature request") to categorise the resulting issues from the issue template.  This commit leans into this new system, setting the issue type, rather than the custom labels.
The new issues also specifies that the templates will be displayed in sorted order by file name.  This commit makes that ordering more explicit for us.

Details and comments
If we choose to merge this, I can bulk update all our issues to use the new "types" rather than the magic labels, so we'll have a more consistent experience across our tracker.  The new "subissues" system is pushing us towards using these types, so it feels cleaner to centralise.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>3
Warning: This coverage report may be inaccurate.
This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

For more information on this, see Tracking coverage changes with pull request builds.
To avoid this issue with future PRs, see these Recommended CI Configurations.
For a quick fix, rebase this PR at GitHub. Your next report should be accurate.

Details

0 of 0   changed or added relevant lines in 0 files are covered.
3 unchanged lines in 1 file lost coverage.
Overall coverage increased (+0.01%) to 88.883%

Files with Coverage Reduction
New Missed Lines
%

crates/qasm2/src/lex.rs
3
92.48%

Totals

Change from base Build<PHONE_NUMBER>8:
0.01%

Covered Lines:
74468

Relevant Lines:
83782

💛  - Coveralls

Eli: is there going to be any advantage to that over just using the "blank issue"?  I think of the issue templates as being for external contributors to use slightly more than the core team doing internal tracking, and I can't imagine a situation where an external contributor would be / should be empowered to set us an epic. I'm also not sure there'd be any standard structure to an epic that the form would help with.

My main motivation is to facilitate organizing tasks in a more hierarchical fashion now that we have the sub-issues feature available. So given a template like the below, I think that having a template Epic issue type in the Create new issue list which explicitly mentions sub-tasking would help that. Of course it's minor and just a convenience tool but still nice to have.
Background
Summary
Subtasks
In any case and regardless, I agree with your statement about epics being more of the core team responsibility to set up.

I don't feel strongly, and I feel like we could adjust the documentation of the template to make it clear that an "Epic" template is not intended for general use.  If you think that structure's useful, I can write up a template for it (maybe a separate PR, then we can play with it more separately?).

Sounds good.

Eli: do you want to approve / review this PR as-is, then, then I'll get to updating the issue metadata for the repo and make the new template?


ACM-12098: Implement CSV export for credentials page

Regarding: ACM-12098
Holding PR so #3681 can merge ahead of it.

Example output:
credentials-1721436369263.csv

/hold

/unhold

/retest-required

/retest


Update Readme.md contribution

It is not clear that our LTS chart is frozen, be more explicit

Hello @krmichelos, thanks a lot for taking the time to participate in the community.
For your question regarding the LTS policy, it is described here
If i try to summarize it, we will do changes to the LTS only if major blocker are detected. That is even more true now that we are close to releasing the next LTS.
May you excuse us for the inconvenience, we are aware this is not an optimal situation for our helm chart and will try our best to make the life of our user easier.

With the upcoming release of the new LTS, the release model will change, that comment in the README is irrelevant for now.


Admin login redirect to a localized url on default install

What is going on ?
From a new install project with DjangoCMS 3.2.3, the recent cms homepage
behavior for an empty project is to redirect to admin to be able to login then
create the home page.
But this try to redirect to a localized homepage using settings.LANGUAGE_CODE like:

http://<IP_ADDRESS>:8001/admin/login/?next=/fr/?edit

With LANGUAGE_CODE setted to "fr".
What was expected ?
Since i don't have any other language code defined in settings.LANGUAGES than used locale "fr" in settings.LANGUAGE_CODE, and since i don't mount cms using i18n_patterns, i expected to be redirected to a neutral homepage like this:

http://<IP_ADDRESS>:8001/admin/login/?next=/

Project details:
This is an install "by hand" (not using the "Django CMS installer") although i use a pre configured project template for django cms since a long time and never encountered this behavior before.
And i need to use settings.LANGUAGE_CODE setted to fr because some apps and templates use it to expose written language.
Settings related to DjangoCMS:

TIME_ZONE = 'Europe/Paris'

LANGUAGE_CODE = 'fr'

LANGUAGES = (
    ("fr", gettext(u"France")),
)
USE_I18N = True

USE_L10N = True

USE_TZ = True

MIDDLEWARE_CLASSES = (
    'django.contrib.sessions.middleware.SessionMiddleware',
    'django.middleware.locale.LocaleMiddleware',
    'django.middleware.common.CommonMiddleware',
    'django.middleware.csrf.CsrfViewMiddleware',
    'django.contrib.auth.middleware.AuthenticationMiddleware',
    'django.contrib.auth.middleware.SessionAuthenticationMiddleware',
    'django.contrib.messages.middleware.MessageMiddleware',
    #'django.contrib.sites.middleware.CurrentSiteMiddleware',
    'django.middleware.clickjacking.XFrameOptionsMiddleware',
    'django.middleware.security.SecurityMiddleware',
)

ROOT_URLCONF = 'project.urls'

INSTALLED_APPS = (
    'django.contrib.admin',
    'django.contrib.auth',
    'django.contrib.contenttypes',
    'django.contrib.sessions',
    'django.contrib.sites',
    'django.contrib.messages',
    'django.contrib.staticfiles',
    'cms',
    'treebeard',
    'menus',
    'sekizai',
    'djangocms_snippet',
)

TEMPLATES = [
    {
        'BACKEND': 'django.template.backends.django.DjangoTemplates',
        'DIRS': (
            os.path.join(PROJECT_PATH, "templates"),
        ),
        'APP_DIRS': True,
        'OPTIONS': {
            'debug': DEBUG,
            'context_processors': (
                'django.contrib.auth.context_processors.auth',
                'django.contrib.messages.context_processors.messages',
                'django.template.context_processors.request',
                'django.core.context_processors.debug',
                'django.core.context_processors.i18n',
                'django.core.context_processors.request',
                'django.core.context_processors.media',
                'django.core.context_processors.static',
                'django.core.context_processors.tz',
            )
        }
    },
]

Urls:
urlpatterns = patterns('',
    url(r'^admin/', include(admin.site.urls)),
    url(r'^', include('cms.urls')),
)

Well i'm sorry, i found too late that this is a duplicate of #5070


isListening public API

Makes the existing var isListening: Bool property of HTTPServer public as suggested by @aayush9029 in https://github.com/swhitty/FlyingFox/issues/58
While this is very similar to the existing throwing method:
try await server.waitUntilListening()

I think the Bool property can read nicer than throws in some scenarios:
await server.isListening

You’re awesome ❤


Do we have the Python sample code for 'Use dynamic configuration in an Azure Functions app'?

[Do we have the Python sample code for 'Use dynamic configuration in an Azure Functions app'? Please refer
to https://docs.microsoft.com/en-us/azure/azure-app-configuration/enable-dynamic-configuration-azure-functions-csharp]

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 22237330-6826-5a33-80b9-73c9beb5417a
Version Independent ID: 5aadf141-63c8-9f12-e010-939ef4b9958c
Content: Tutorial for using Azure App Configuration dynamic configuration in an Azure Functions app
Content Source: articles/azure-app-configuration/enable-dynamic-configuration-azure-functions-csharp.md
Service: azure-app-configuration
GitHub Login: @zhenlan
Microsoft Alias: zhenlwa

@gary918 -
Thanks for brining this to our attention. We will investigate it further and update you shortly.

@gary918 we don't have a document of such. We don't have a similar 'config provider' in Python like the .NET Core one discussed in the document you referred to. In Python, you will have to use the Python SDK and write your code to retrieve key-values from App Configuration. Here is a quickstart for Python.
https://docs.microsoft.com/en-us/azure/azure-app-configuration/quickstart-python

@zhenlan  - Thank you for providing your insights.
@gary918 - I hope @zhenlan has answered your question.
At this moment, Since there is no doc update required, We will now proceed to close this thread. If there are further questions regarding this matter, please tag me in your reply. We will gladly continue the discussion and we will reopen the issue.

Got it. Thanks for your help! @zhenlan @MonikaReddy-MSFT


Upgrade to Go 1.23

This PR introduces no code change. The primary purpose is to upgrade to Go 1.23. Other changes include:

Removed Node.js dependencies.
Migrated to Goreleaser
Updated deprecated AWS Go SDK functions to non-deprecated functions (Test code)
Updated deprecated Localstack functions to non-deprecated functions (Test code)
Updated YAML validation to use v3
Updated Contribution doc.
Updated CI to use Goreleaser.
Added GitHub Actions to dependabot checks.
Updated Dockerfile to use Go 1.23 and Alpine 3.20

Closes #126


Mummy familiar

https://user-images.githubusercontent.com/67878524/144742090-90bd3b90-0cff-48ab-96b1-12d61cd52a31.mp4
The mummy familiar is here to fight for you!

Martial arts expert
Blacksmith upgrade to deal even more damage
Give owner dodge effect

Haha oh gosh that one is fantastic! Beware the martial mummy


chore: remove tidb-community-bots/ti-prow-external-plugins-config

Codecov Report

Merging #10 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #10   +/-   ##
=======================================
  Coverage   42.46%   42.46%
=======================================
  Files           4        4
  Lines          73       73
=======================================
  Hits           31       31
  Misses         39       39
  Partials        3        3

Flag
Coverage Δ

#unittests
42.46% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3cdfcda...08721b7. Read the comment docs.


Move odb schemes

Move schemes of odb-boost and odb-mysql into the new layout under their respective projects

Testing:

https://travis-ci.org/ingenue/hunter/builds/123650942


Fix user authentication dependency

During dome refactoring (id argument replaced by entry_id) and get_current_user (deps.py) might have been skipped

I have fixed the issue in the device PR (hence the conflict). I added entry_id as keyword argument label. I think we can close this PR.

@jeanpasquier75 can you confirm this was solved and that we may close the PR?

Yes it is now fixed in master, we can close this PR


Add Church & Murray Business Site Selection to Refs

xref https://github.com/pysal/spopt/pull/374#issuecomment-1589061609
See this entry in spaghetti
@book{Church2009,
  address = {Hoboken},
  author = {Church, Richard L. and Murray, Alan T.},
  publisher = {John Wiley {\&} Sons, Inc.},
  title = {{Business Site Selection, Locational Analysis, and GIS}},
  year = {2009}
}

@rongboxu This entry should go into spopt/docs/_static/references.bib

Resolved via #382


synth.tcl should call autoname function (and opt_clean -purge)

The autoname function converts the internal _<random number>_ names into something a bit more useful based on the inputs / outputs.

Before;

After;


Black ocean from certain viewpoints

This is an odd one, and it's been happening since we first brought Crest into our project.  I haven't mentioned it because I thought it was related to the old version of the Unity Post Processing stack we were using, but it turns out that isn't the case.
Basically, the ocean will occasionally go completely black, with powerful bloom around the edges (which is why I thought it was the Post Processing stack).  However, it seems to be view dependent, in that if you move the camera to another location, it will pop back to normal.  I've attached some screenshots.
Example 1
Example 2 ('Add Directional Light' disabled)
Example 3 ('Add Directional Light' + 'Sub-Surface Scattering' disabled)
Since it makes the bloom go crazy, I wonder if it's some value that isn't being clamped?  We're using deferred rendering and have HDR enabled.  I'm not exactly sure what other info to give you, but I'll let you know if I can isolate the issue further.  We're using what is currently the latest data on GitHub.

Thanks Midda! Thats pretty severe! I have not seen that behaviour before. I tried a few things here to find repro steps but did not get too far.
On clamping, i yesterday found a couple of unclamped bugs which caused bright fireflies and triggered bloom. You said you have latest but thought I'd mention it a I pushed it 12hrs ago. 26a2d7b8d2d5c76bf6d3f4e04049a89551850d69 . This issue looks more severe though.
I assume this is happening in editor - let me know if not though.
Thanks for trying the debug flags. Could you try disable transparency? I've added another debug flag "Debug Disable Multiply by LightColor0" - with this flag, everything involved in computing the ocean colour is disabled.
I've also added another debug flag "Debug Disable Shape Textures" - this will stop it from touching the shape textures, which i suspect are messed up for some reason.
Along that line of thought, it could be useful to enable the debug GUI and see the shape textures. Its not in the core crest files by default (but maybe it should be..) but its in the example content here: https://github.com/huwb/crest-oceanrender/blob/master/src/unity/Assets/Crest-Examples/Scripts/OceanDebugGUI.cs
All of the above would be interesting to see, but there is a more powerful debugging tool which will give me a complete view of the render and should direct me straight to the problem - a renderdoc capture. this would capture some data used in the frame (geometry, textures), so you may not want to post it online. if you are up for going down that route, the steps are:

install renderdoc (freely available)
uncomment this line in Ocean.shader for maximum debuggage:  // #pragma enable_d3d11_debug_symbols
in the Game view dropdown menu, select Load Renderdoc
press play and repro the issue, then click the little Renderdoc icon at the top of the Game view (see tooltip)
renderdoc should open. right click the capture thumbnail that should appear and select save, and email it to me.

thanks!

Emailed that through.  Let me know if I can do anything else to help track this down!

Our world is lit by a directional light, but we do have other lights in the world (e.g. campfires have point lights on them).
So I just tested this by disabling the objects in my scene that have point lights on them, and yep, the issue disappeared.
I grabbed latest, and it mostly addresses the issue, but I can now see that when the point light sources are in view, the ocean tiles seem to be tinted by the point light colour, even though they are quite far away.  It usually affects all the ocean tiles in view, but at some viewpoints, you can see a sharp line where a few tiles remain unaffected by the point lights.

I think I fixed it. (Havent tried your latest changes though)
you need to change the tag to "LightMode"="ForwardBase"
with LightMode=always as you have now unity thinks its not doing any
lighting in the shader so isnt setting the _WorldSpaceLightPos0 value, so
its set to whatever value for what was drawn previously, so if it was a
forwardAdd shader or something then its value might be a point light
position.
On Mon, May 28, 2018 at 10:24 PM, Huw Bowles<EMAIL_ADDRESS>wrote:

Thanks for that! Yes that helped a lot, although I'm a bit confused by
what I saw:
Unity has passed in a light position instead of a direction into the
shader. Are you guys using a light type that is not a directional light?
This should be fine normally of course, but my code made the (bad)
assumption that it was always a directional light. The issue was i was
assuming this would be unit length, and doing some exponentiation on it,
which made it blow up to infinity when its a large world position vector. I
now detect if unity has given the shader a position instead of a direction
and normalize appropriately. Could you please try latest?
I'm a bit surprised by this. I am half-expecting that there is actually a
deeper or secondary issue at play here. However the stuff i described above
is a legit issue and that is generating the INF values that I'm seeing, so
I'm definitely interested to hear what happens with that fix!
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/huwb/crest-oceanrender/issues/19#issuecomment-392513323,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AOU9GPlvB6LOqj_StMruDjgtCulpajsoks5t2-x8gaJpZM4UPrN4
.

Nice find!! This actually fixes #15 as well in one fell swoop. It looks great to me here so I pushed it.
I kept the previous change i did, which at least would support one big point light in the world. Regarding supporting multiple lights, I would consider it in-scope but I'm not geared up to comment on what it would take/if its possible etc. Do you have requirement for this, such as local lights at night time or such?
Thanks a bunch!

To support point lights you do the same shader again with a tag of
forwardadd, now you calc the lighting uisng the point light info, and
output a pixel that is added to the result from forwardBase.
I will do it at  some point if you dont beat me to it.
The mesh is rendererd multiple times depending on how many lights overlap
it. thats the downside of using forward over deferred. Fortunately your
method of building the wave heights as a separate texture is a big win here
not having to recalc the vert heights.
On Tue, May 29, 2018 at 6:40 PM, Huw Bowles<EMAIL_ADDRESS>wrote:

Nice find!! This actually fixes #15
https://github.com/huwb/crest-oceanrender/issues/15 as well in one fell
swoop. It looks great to me here so I pushed it.
I kept the previous change i did, which at least would support one big
point light in the world. Regarding supporting multiple lights, I would
consider it in-scope but I'm not geared up to comment on what it would
take/if its possible etc. Do you have requirement for this, such as local
lights at night time or such?
Thanks a bunch!
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/huwb/crest-oceanrender/issues/19#issuecomment-392698622,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AOU9GFN25wukFsfLmiPS5oCq8sOps1etks5t3QmQgaJpZM4UPrN4
.


fix(overlays): focus overlay when presented

Pull request checklist
Please check if your PR fulfills the following requirements:

[x] Tests for the changes have been added (for bug fixes / features)
[todo] Docs have been reviewed and added / updated if needed (for bug fixes / features)
[x] Build (npm run build) was run locally and any changes were pushed
[x] Lint (npm run lint) has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, renaming)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] Documentation content changes
[ ] Other (please describe):

What is the current behavior?

Issue Number: https://github.com/ionic-team/ionic/issues/19882
https://github.com/ionic-team/ionic/issues/17126
What is the new behavior?

Overlay components now have tabindex="-1" so that they can be focused.
Automatically focus overlay component so users can tab to inputs/buttons in overlay.

Does this introduce a breaking change?

[ ] Yes
[x] No

Other information

Talked with the team offline and decided to scale back the scope of this. The focus behaviors differ across ios, android, and web so going to take the simpler approach and just focus the overlay for now.


Consistent L1/L2 names between EvoLinear and EvoTrees

In EvoTrees, the L1/L2 regularizations are called gamma and lambda, respectively; would it be better to have consistent names for these between the two packages?

Arguments naming have emerged from different considerations. Notably, EvoTrees got inspired by existing libraries naming practices (XGBoost), while I approached EvoLinear more as a clean slate. The interpretation of the gamma is also different as it can also be interprated as a tree pruning argument. I prefer not to bring changes to these names unless it comes with some material changes to their logic, justifying adpotions of new names. Otherwise, I prefer applying some L1 to API changes and not bring changes only for the sake of naming.


Drop the component filtering for the autoclosing of intermittents

Currently, we filter out  Firefox::New Tab Page and  Firefox::Messaging System. We should check with their triage owners if this filtering is still needed.

I've asked @dmose.


Dart 2.17 #89

@lykhonis Would indeed be nice if this could be merged in for a new version for Flutter 3 support :)


[dy] Support custom logging level

Description

Pass mage block logger through block kwargs and also redirect stderr to the StreamToLogger object. Some logs will get logged to stderr by default such as the loguru module.
How Has This Been Tested?

[x] Tested locally

Checklist

[x] The PR is tagged with proper labels (bug, enhancement, feature, documentation)
[x] I have performed a self-review of my own code
[ ] I have added unit tests that prove my fix is effective or that my feature works
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation

cc: @wangxiaoyou1993

please add label to the PR


Loading modules with extension cjs instead of js

I try to figure out a way on how to load .cjs files instead of .js files.
Background: I try to integrate prosemirror (https://prosemirror.net/) into an OpenUI5 application. I manage to load from the NPM packages the dist/*.js files into my application - however - those are ES moduels and then I get the error:
Uncaught SyntaxError: import declarations may only appear at top level of a module

Now, prosemirror has also commonjs modules, but with the extension .cjs and not .js
I have not found a way to load the .cjs via sap.ui.loader.config({.
Alternatively, if it would be possible to load a ES modules via sap.ui.loader

@petermuessig do you have an idea? thanks!

OMG - I missed to reply here as well
Using the ui5-tooling-modules tooling extension should do the trick that you don't need to take care about the input format of the OSS library and it finally converts it into UI5 AMD-like modules which can be just required/imported in your application without shimming.
A new/updated showcase for this one can be found here: https://github.com/ui5-community/ui5-ts-modules-showcase/


Typo in Python package: Nump has no attribute RandomState

I just cloned the code, and had to modify line 239  in engine.py from
randidx = np.RandomState(seed).random.permutation(num_data)
to
randidx = np.random.RandomState(seed).permutation(num_data)
to get it running correctly in Python 3.5 (Anaconda)

@jfpuget fixed in PR #377 , thanks for reporting it


updated proto

Yo kwee @BumminZ , Shall we remove unnecessary Proto Message  ?
And also the go files were missing. Can you please checkin the generated go files 🙇


Self signed certs

Allows a cert to be passed at docker run time that gets added to the java truststore.
Tests

[x] Verified this with https://self-signed.badssl.com

Thanks for taking this on and figuring it out for us.


Configure Azure Pipelines

This configuration builds the application and produces builds for both Debug and Release configurations.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: Doombrew sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.


⚠ Processors has degraded performance

In ad84299, Processors ($STATUS_URL) experienced degraded performance:

HTTP code: 200
Response time: 54 ms

Resolved: Processors performance has improved in e293a09.


EDGCSOFT-53 : Implement RTR in edge-caiasoft

EDGCSOFT-53 : Implement RTR for edge-caiasoft
Purpose
This module has a direct dependency on authn/login. We need to replace that dependency with new shared code in edge-common-spring.
Approach
integrated edge-common-spring library, which internally uses folio-spring-system-user library from folio-spring-support
TODOS and Open Questions

Test Evidence

Pre-Merge Checklist:
Before merging this PR, please go through the following list and take appropriate actions.

Does this PR meet or exceed the expected quality standards?

[X] Code coverage on new code is 80% or greater
[X] Duplications on new code is 3% or less
[X] There are no major code smells or security issues

As discussed with @gurleenkaurbp , it is decided to merge this PR in the scrum call (18th Sep 2023).


Stubbing "multipart-form-data" request with part array

Description
Hi 😁, here's the issue:
In a multipart-form-data, you can have an array of parts by specifing the same partname multiple times.
Here is how it looks in the OpenApi definition (pdfFiles):
requestBody:
  content:
    multipart/form-data:
      schema:
        type: object
        properties:
          sendMessageRequest:
            $ref: "#/components/schemas/SendMessageRequest"
          pdfFiles:
            type: array
            items:
              type: string
              format: binary
        required:
          - sendMessageRequest
          - pdfFiles

We expect this to be an array of pdfFiles:

If i send this request to the Specmatic Stub, i get the following error:

This happens because Specmatic thinks a multipart part of type array should contain an array, and not be one:
Internally this is interpreted as a ListPattern which matches only if the value is an array.
Snippet from ListPattern.kt

If i change my part value to an array, it works, but that's not the behaviour i expected:

Steps to reproduce

Create a stub using the following OpenApi Definition:

openapi: 3.0.3
info:
  title: Multipart With Array Example
  description: Service to add context to a github issue
  version: 1.0.0

servers:
  - url: "http://{hostname}:{port}/{basePath}/"
    variables:
      hostname:
        default: localhost
      port:
        default: "8080"
      basePath:
        default: rest
tags:
  - name: UploadFile
paths:
  "/message":
    post:
      tags:
        - UploadFile
      operationId: sendMessage
      requestBody:
        content:
          multipart/form-data:
            schema:
              type: object
              properties:
                sendMessageRequest:
                  $ref: "#/components/schemas/SendMessageRequest"
                pdfFiles:
                  type: array
                  items:
                    type: string
                    format: binary
              required:
                - sendMessageRequest
                - pdfFiles
            encoding:
              sendMessageRequest:
                contentType: application/json
      responses:
        "200":
          description: "Send Message Response"
          content:
            multipart/form-data:
              schema:
                type: object
                properties:
                  filename:
                    type: string
                    description: filename for associated file content
components:
  schemas:
    SendMessageRequest:
      type: object
      title: SendMessageRequest
      properties:
        foobar:
          type: string
          maxLength: 255
          minLength: 1
      required:
        - foobar

Make an HTTP POST request to the /message endpoint containing the following parts:

Expected behavior
I expect to receive a 200 OK generated response
System Information:

OS & version: Windows 11
Browser & version: Postman 10.16.0
Specmatic version: 0.73.0
JDK version: OpenJDK 17

Additional context
To fix it, we'll need to change the way Specmatic interprets "type: array" on multipart parts. Changing the meaning from "contains a json array" to "expect to have the same part multiple times"

Thanks for reporting this @aeoncl.
We'll have a look at this and get back to you.

Hi guys, i've started working on this. i'll submit a PR in the coming days for you to review

Hi @aeoncl, really appreciate the initiative.
Please do let us know if you have any queries regarding the code.

@aeoncl Thank you for your patience. The reason we were taking time on this PR is to make sure we also understood the http RFC around this. And it does look like the expected behaviour in your bug description is valid as per this section in RFC 7578. We are now reviewing your PR in this regard.

Hi, I seem to be running into similar issue trying to upload a file in request body where content type is multipart/form-data


Update usage.mdx

Provide better Next.js 13 options for using the Chakra UI Link

Closes #
📝 Description
This is just a documentation update to provide better Next.js 13 options for using the Chakra UI Link
⛳ Current behavior (updates)

Please describe the current behavior that you are modifying

🚀 New behavior

Please describe the behavior or changes this PR adds

💣 Is this a breaking change (Yes/No):

📝 Additional Information

Thanks @aacevski - I just accepted your changes


Add helpers for generating result/error

@devoncarew Not sure if this is exactly what you had in mind (or if you think it's worthwhile). It would be nicer if we could accept "an object that can be JSON encoded" to resultFor/errorFor (to avoid the caller having to call .toJson()), and it also seems like we could merge errorFor+RpcError, however then it wouldn't me symmetrical with the result one.

It turns out my original investigation was bad. The VM service doesn't require a type field, it only requires that result is a map (not a literal, for ex. a bool as I tried).
It also looks like _routeRequest is already catching errors and converting them to errors, so I don't see why our errors weren't working. I'm going to do more testing tomorrow and come back to this (but probably I'll abandon this if it works as it looks like it should).

Ok, I tracked down the real source of errors not being handled correctly. The catch block here is not wrapping the response into an object with an error field (compare the Method not found and the catch blocks here):

With this fixed, we don't need to explicitly format errors ourselves, so I'm going to abort this one and open a new PR to fix this issue.


Particle Gibbs (PG)

Hi all !
Would you have a bit of documentation or insights about what's implemented behind PG ? By reading the code I understood that it looks more like a conditional SMC.
In the article Particle Markov chain Monte Carlo methods section 2.4.3, Particle Gibbs is defined as

a Gibbs sampler which samples iteratively from p(θ|y1:T, x1:T) and p(x1:T |y1:T, θ) [...] with a special type of PMCMC update called the conditional SMC update.

but that's not what PG is doing. Base on the paper, the syntax could looks like
sampler = PG(1000, SMC(1, :x), HMC(1, 0.2, 3, :θ))

But maybe this is what is done in Turing with:
sampler = Gibbs(1000, PG(1, :x), HMC(1, 0.2, 3, :θ))

Is it ? If so, PG could be renamed CSMC.
Thanks for your help

Is it ? If so, PG could be renamed CSMC.

That's quite right. PG in Turing actually refers to CSMC. Gibbs is slightly more general than PG, since it allows combination of samples like Gibbs(HMC, HMC).
@xukai92 Do you think we can change the name of PG to CSMC? Or perhaps we can create an alias CSMC to PG to keep backward compatibility?

@yebai I feel having a type alias CSMC for PG is better.

Like this ?
typealias CSMC PG

typealias CSMC PG

Yes, that should work.

Ok, I'll create a PR with that line added in src/sampler/pgibbs.jl.
How can I modify the wiki to make that clearer for everyone ?

How can I modify the wiki to make that clearer for everyone ?

I'll added you to collaborators, so you can edit the wiki.

PR for review: https://github.com/yebai/Turing.jl/pull/342


Remove need for Postgres DB

Migrated from GitLab: https://gitlab.com/meltano/meltano/-/issues/235
Originally created by @jschatz1 on 2018-12-19 20:52:42

Currently you need to install postgres to get a api db for meltano.
Via https://gitlab.com/meltano/meltano/issues/209 we now support Hocon via .ma file. They compile to one JSON file with all the models and their accompanying views in there.
We have 2 choices to rid ourselves of postgres dependency.

Store model files as .mac files. Which would just be each model file in it's own file to query without a DB. It's all JSON so easy to load. Create helpers around it.
Use SQLite and load the files into that DB. Don't create tables and just store JSON in the DB.

Storing JSON in the DB is a bad idea.
We will go with option 1 per this video with @stanhu
https://youtu.be/SGcKy8xga8w

View 3 previous comments from the original issue on GitLab


Finalize draft not aware diagnostics for getRelatedListRecords and getRelatedListCount

Finalize the diagnostic UI for getRelatedListRecords and getRelatedListCount as below:

Skip LSP diagnostics if opened project is not sfdx or opened document is not under LWC folder.

I messed up the change while rebase, will close this one and create a new pr.


EarlGrey.framework location in the App Bundle

Hi there,
I was wondering why EarlGrey.framework is put right in the Main Bundle folder. This is a bit abnormal because Apple expects .frameworks extensions to be in Frameworks folder for codesigning. This can be also seen in the technical note below in table 2-5.
https://developer.apple.com/library/archive/documentation/CoreFoundation/Conceptual/CFBundles/BundleTypes/BundleTypes.html#//apple_ref/doc/uid/10000123i-CH101-SW1
The content I'm referencing here is basically this section:
(Required) Contains the application’s standalone executable code. Typically, this directory contains only one binary file with your application’s main entry point and statically linked code. However, you may put other standalone executables (such as command-line tools) in this directory as well.
I would be really happy if someone could explain me that. Thanks a lot

We just need it to be injected into the app bundle and then use DYLD_INSERT_LIBRARIES to inject it into the app. Feel free to send a PR to change the paths, I don't think there should be any issues with it.

It's been that way from the beginning before embedded frameworks were officially supported by Apple. Are you running into issues with codesigning it because it's not under Frameworks folder? And is it due to cocoapods?
If you decide to change it, you'd have to change it in multiple locations thoughout our xcode projects, cocoapods, etc.

It haven't had a problem with codesigning. My concern is more towards resigning. Resigning services might fail resigning EarlGrey tests due to the framework being in the App Bundle Folder. This is not a problem with XCode since the extra frameworks to be copied and to be signed are specified in the settings and due to that, XCode knows what extra to sign. However, I don't think this would work with fastlane for example.
If you follow this line, you will see that they expect the frameworks to be in the framework folder
https://github.com/fastlane/fastlane/blob/master/sigh/lib/assets/resign.sh#L540
Thank you for your answers btw

Understood. Since we're preparing open sourcing for EarlGrey 2.0, we'll address it there and leave it the way it is for EarlGrey 1.0


Can't convert the format of credential parameters into string

Hi, this is Leon from OpenSDS team, again (you can find me at https://github.com/kubernetes-incubator/service-catalog/issues/1058). At this time I want to seek some help for converting the value of secret data into a normal string format.
Firstly I implement our CreateServiceInstance method here:
func (c *openSDSController) CreateServiceInstance(
	id string,
	req *brokerapi.CreateServiceInstanceRequest,
) (*brokerapi.CreateServiceInstanceResponse, error) {
	capInterface, ok := req.Parameters["capacity"]
	c.rwMutex.Lock()
	defer c.rwMutex.Unlock()
	if ok {
		capacity := capInterface.(float64)
		vol, err := client.CreateVolume(id, int64(capacity))
		if err != nil {
			return &brokerapi.CreateServiceInstanceResponse{}, err
		}
		c.instanceMap[id] = &openSDSServiceInstance{
			Name: id,
			Credential: &brokerapi.Credential{
				"volumeId": vol.GetId(),
				"pool":     "rbd",
				"image":    "OPENSDS:" + vol.GetName() + ":" + vol.GetId(),
			},
		}
	} else {
		return &brokerapi.CreateServiceInstanceResponse{}, fmt.Errorf("Capacity not provided in request!")
	}

And Bind method is implemented like this:
func (c *openSDSController) Bind(
	instanceID,
	bindingID string,
	req *brokerapi.BindingRequest,
) (*brokerapi.CreateServiceBindingResponse, error) {
	c.rwMutex.RLock()
	defer c.rwMutex.RUnlock()
	instance, ok := c.instanceMap[instanceID]
	if !ok {
		return nil, errNoSuchInstance{instanceID: instanceID}
	}
	cred := instance.Credential
	return &brokerapi.CreateServiceBindingResponse{Credentials: *cred}, nil
}

But when I run our broker and show the secret, the output is like this:
apiVersion: v1
data:
  image: T1BFTlNEUzpjYzNlMWNhZi05MGFkLTQwODYtYmEzMS1iMjI5YmM1NDUyNTQ6M2QyZGQ0ZjItMmE0ZC00Mjk2LTg4OWEtOGE5MWY1ZWYzOGFj
  pool: cmJk
  volumeId: M2QyZGQ0ZjItMmE0ZC00Mjk2LTg4OWEtOGE5MWY1ZWYzOGFj
kind: Secret

As you can see, it was supposed to three useful variables here, but the output seems to be useless. I am not sure if I have done something in the wrong way, and I would appreciate it if anyone could offer some help.

@leonwanghui
What values did you expect to see for the secret keys?  The fields of secret data are byte arrays, which are treated as base-64 encoded strings in json and yaml.  When I base64-decode the values you posted, I get:
image: OPENSDS:cc3e1caf-90ad-4086-ba31-b229bc545254:3d2dd4f2-2a4d-4296-889a-8a91f5ef38ac
pool: rbd
volumeId: 3d2dd4f2-2a4d-4296-889a-8a91f5ef38ac

...which looks usable.
Does that help?

@Paul, yeah, it helps a lot. I just didin't know what's the format of this
kind of things.
BTW, have you tried converting it before storing it in the Credential
object so that I could directly understand the meaning of the kubectl
output?
Thanks,
Leon Wang
Paul Morie<EMAIL_ADDRESS>周一04:29写道：

@leonwanghui https://github.com/leonwanghui
What values did you expect to see for the secret keys? The fields of
secret data are byte arrays, which are treated as base-64 encoded strings
in json and yaml. When I base64-decode the values you posted, I get:
image: OPENSDS:cc3e1caf-90ad-4086-ba31-b229bc545254:3d2dd4f2-2a4d-4296-889a-8a91f5ef38ac
pool: rbd
volumeId: 3d2dd4f2-2a4d-4296-889a-8a91f5ef38ac
...which looks usable.
Does that help?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/kubernetes-incubator/service-catalog/issues/1072#issuecomment-318927445,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AXkALatj21PaQPvaGLTLFMBArNikaFn1ks5sTOe7gaJpZM4OmD9S
.

--
Hui (Leon) Wang
Standard Engineer
IT Standard & Patent/IT Prooduct Line
Huawei Technologies Co,. Ltd
Email<EMAIL_ADDRESS>Office: Huawei Industrial Base, Longgang, Shenzhen

BTW, have you tried converting it before storing it in the Credential object so that I could directly understand the meaning of the kubectl output?

I'm not sure what you mean - would you clarify?

Sorry for my poor English.
I have tried decoded the format of these strings according to base64. But
what I expect is that when I run "kubectl get secret
opensds-instance-secret -o yaml", I can directly get the correct format,
rather than converting it after.
Does that make sense?
Paul Morie<EMAIL_ADDRESS>周一22:47写道：

BTW, have you tried converting it before storing it in the Credential
object so that I could directly understand the meaning of the kubectl
output?
I'm not sure what you mean - would you clarify?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/kubernetes-incubator/service-catalog/issues/1072#issuecomment-319089394,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AXkALXGY08thNxQGTqylpWVW2xVcyCWWks5sTej2gaJpZM4OmD9S
.

--
Hui (Leon) Wang
Standard Engineer
IT Standard & Patent/IT Prooduct Line
Huawei Technologies Co,. Ltd
Email<EMAIL_ADDRESS>Office: Huawei Industrial Base, Longgang, Shenzhen

We don't do that, because secrets can contain binaries, which might not
display correctly and/or destructively change your terminal.
On Mon, Jul 31, 2017 at 10:53 AM, Leon Wang<EMAIL_ADDRESS>wrote:

Sorry for my poor English.
I have tried decoded the format of these strings according to base64. But
what I expect is that when I run "kubectl get secret
opensds-instance-secret -o yaml", I can directly get the correct format,
rather than converting it after.
Does that make sense?
Paul Morie<EMAIL_ADDRESS>周一22:47写道：

BTW, have you tried converting it before storing it in the Credential
object so that I could directly understand the meaning of the kubectl
output?
I'm not sure what you mean - would you clarify?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<https://github.com/kubernetes-incubator/service-catalog/issues/1072#
issuecomment-319089394>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/
AXkALXGY08thNxQGTqylpWVW2xVcyCWWks5sTej2gaJpZM4OmD9S>
.

--
Hui (Leon) Wang
Standard Engineer
IT Standard & Patent/IT Prooduct Line
Huawei Technologies Co,. Ltd
Email<EMAIL_ADDRESS>Office: Huawei Industrial Base, Longgang, Shenzhen
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/kubernetes-incubator/service-catalog/issues/1072#issuecomment-319091517,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAWXmEPXwYuTOuHUQSq1fCPfzbivtbUrks5sTeqFgaJpZM4OmD9S
.

Got it, thx : )
Paul Morie<EMAIL_ADDRESS>周一23:23写道：

We don't do that, because secrets can contain binaries, which might not
display correctly and/or destructively change your terminal.
On Mon, Jul 31, 2017 at 10:53 AM, Leon Wang<EMAIL_ADDRESS>wrote:

Sorry for my poor English.
I have tried decoded the format of these strings according to base64. But
what I expect is that when I run "kubectl get secret
opensds-instance-secret -o yaml", I can directly get the correct format,
rather than converting it after.
Does that make sense?
Paul Morie<EMAIL_ADDRESS>周一22:47写道：

BTW, have you tried converting it before storing it in the Credential
object so that I could directly understand the meaning of the kubectl
output?
I'm not sure what you mean - would you clarify?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<https://github.com/kubernetes-incubator/service-catalog/issues/1072#
issuecomment-319089394>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/
AXkALXGY08thNxQGTqylpWVW2xVcyCWWks5sTej2gaJpZM4OmD9S>
.

--
Hui (Leon) Wang
Standard Engineer
IT Standard & Patent/IT Prooduct Line
Huawei Technologies Co,. Ltd
Email<EMAIL_ADDRESS>Office: Huawei Industrial Base, Longgang, Shenzhen
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<
https://github.com/kubernetes-incubator/service-catalog/issues/1072#issuecomment-319091517
,
or mute the thread
<
https://github.com/notifications/unsubscribe-auth/AAWXmEPXwYuTOuHUQSq1fCPfzbivtbUrks5sTeqFgaJpZM4OmD9S
.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/kubernetes-incubator/service-catalog/issues/1072#issuecomment-319100885,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AXkALeDPLwCwppLg_AlbHNS00E0ugnNmks5sTfFSgaJpZM4OmD9S
.

--
Hui (Leon) Wang
Standard Engineer
IT Standard & Patent/IT Prooduct Line
Huawei Technologies Co,. Ltd
Email<EMAIL_ADDRESS>Office: Huawei Industrial Base, Longgang, Shenzhen

Okay, closing this issue.


Not compatible with pip

Minecraft version: 1.20.6
Mod Version: 2.1.0+1.20
What happen rn:

What can happen if supporting pip:

(This instance is using mod:Borderless Mining, which doesnt support 1.20.6 not 1.21)

wait nevermind


White Scroll Bars with Dark Mode

Is your feature request related to a problem? Please describe.
Scroll bars do not adapt to the dark theme as shown in the screenshot. Is there a way to change this behavior?
Describe the solution you'd like
Scroll bars to look like VS Code or WhatsApp (or many other apps) where they adapt to the theme.
Describe alternatives you've considered
I have tried both the Microsoft Store version (22.2.0) and the installer version (22.2.1).
OS information:
Edition	Windows 11 Pro
Version	22H2
Installed on	28/09/2022
OS build	22621.521
Experience	Windows Feature Experience Pack 1000.22634.1000.0
Additional context

Hello @hozdenoren
Thanks for the report.

This issue starts happening after Windows 11 22H2. The menus are also white now in dark mode. Previously both scrollbars and menus were dark with dark theme.
As I understand, Microsoft has made some changes to their dwmapi for 22H2. This could be a reason why dark mode is not working right for dbeaver.

@hassaanmasood thank you for investigation

Connected to #17508

Hey, even though this is marked for the 22.3.5 update, the scroll bars are now black for me on 22.3.3.

Thank you for feedback. It's a good news.

@hassaanmasood could you check if this issue is still reproducible for you?

@E1izabeth this issue seems to have resolved with version <IP_ADDRESS>301060755

Thank you for checking. Then I'm closing this issue. Please, let me know if you meet this bug again.

Still happening in 24.2.4 in a clean install of Windows 11 24H2:

Menus are light as well

Just tagging @E1izabeth


Consider Host Networking mode for pods

Currently the game server pods are using host port mapping to accept communication. This process incurs performance overhead from the NAT translations from the host network to the container network. Switching the game server pods to use the host network  directly will remove this overhead.
However, given the current architecture there are some complications that need to be handled. For example the side car container would also be on the host network, thus exposing it externally on the node's IP.  As currently the controller communicates to the side car for state changes, this will need to be secured first.

#31 fixes the issue mentioned on the last sentence "controller communicates to the side car for state changes", since it introduces Kubernetes watch for the sidecar.

this will be possible by #97, which eliminates the sidecar in favor of a DaemonSet


[Feature]: Moving custom category items to bank / inv with one click

Describe the feature
So, in adibags you could put certain custom item set items into bank with one click / or take them out. This was super convenient to retrieve specialty items from bank, like frost/fire resistance gear.
Describe the implementation
by clicking the custom category name it would move items to or from bank, depending if you clicked the name in bags or bank.

Came here to request the same thing.  Would be an amazing addition

Definitely needs this function.

This has been released with v0.1.90.


Data collection process

Hi, Twibot-22 staff. First of all, congratulations for the work You have done!.
I have some questions about the data collection process. A brought the A.2 part of the paper, so We can go through It together.
"For the first stage of user network collection, we adopt @NeurIPSConf as the starting user. We use the Twitter API to retrieve 1,000 followers and 1,000 followees as the user’s neighborhood for BFS expansion. We randomly adopt one of the two sampling  strategies (distribution diversity or value diversity) and randomly select one metadata from Table 6 to include 6 users from its neighborhood into the TwiBot-22 dataset. We then randomly select one unexpanded user in TwiBot-22 for a new round of neighborhood expansion. "

What I understood was that from 2k neighbors (followers + followees) of @NeurlPSConf, 6 of them were chosen to retrieve tweets, retweets, hashtags, and all of the data Twibot-22 provides. Besides, the next round was done from 1 of the 1994 remaining users in the neighborhood of @NeurlPSConf. Yet, 6 more neighbors were selected and their information was retrieved.  Is that correct? Sorry, but I could not figure out how you achieved 1MM users in this process. Could You please provide more details? Even a picture to illustrate this process?

Thank you for your interest in our work.
For each crawling user, (e.g. @NeurIPSConf), we collect 2k neighbors(followers and followees) and crawl the whole related information (profile, timeline, related lists) of them. To extend the graph, we sample 6 followers and 6 followees and crawl their neighbors. Namely, we consider these 12 users as new crawling users.  We consider the steps above as an extension. For an extension, we can get 2k users and 12 new crawling users. The figure may help you.

As this figure shows, T0 has 1 user, T1 has 2k users, and T2 has around 24k users. Namely, we can get 1MM users by around 1000 extensions (around 5 Tiers).

Thank you for your explanation, now everything is clear to me.


CustomOp error with latest master

We are observing crashes with Sockeye transformer models using the latest build from mxnet master (1.2.0b20180411). The error we are seeing is this:
Error in positional_encodings.infer_type: Traceback (most recent call last):
  File "/Users/fhieber/miniconda3/lib/python3.6/site-packages/mxnet/operator.py", line 831, in infer_storage_type_entry
    ret = op_prop.infer_storage_type(stypes)
  File "/Users/fhieber/miniconda3/lib/python3.6/site-packages/mxnet/operator.py", line 556, in infer_storage_type
    return in_stype, [in_stype[0]]*len(self.list_outputs()), \
IndexError: list index out of range

[ERROR:__main__] Uncaught exception
Traceback (most recent call last):
  File "/Users/fhieber/miniconda3/lib/python3.6/site-packages/mxnet/symbol/symbol.py", line 1513, in simple_bind
    ctypes.byref(exe_handle)))
  File "/Users/fhieber/miniconda3/lib/python3.6/site-packages/mxnet/base.py", line 149, in check_call
    raise MXNetError(py_str(_LIB.MXGetLastError()))
mxnet.base.MXNetError: Error in operator target_pos_embed_positional_encodings: [14:33:09] src/operator/custom/custom.cc:523: Check failed: reinterpret_cast<CustomOpInferStorageTypeFunc>( params.info->callbacks[kCustomOpPropInferStorageType])( stypes.size(), stypes.data(), params.info->contexts[kCustomOpPropInferStorageType])

The corresponding Sockeye issue is here: https://github.com/awslabs/sockeye/issues/354
I believe this might be related to this commit/PR #10374 as the crash is not observed with mxnet==1.2.0b20180410.
Note that the custom op in Sockeye does not use input data (https://github.com/awslabs/sockeye/blob/master/sockeye/layers.py#L644).
We observed an issue with this type of op before in an earlier version of mxnet: https://github.com/apache/incubator-mxnet/pull/7967 (This PR also contains a minimum reproducible example).
It'd be great to fix this before the 1.2 RC.

Same problem occurs based on mxnet_cu90-1.2.0b20180411  and the latest master branch.

My (uneducated) guess would be that the new code for storage type inference needs to guard against in_stype being an empty list to avoid the index error when trying to access in_stype[0].

@fhieber Thanks a lot for bringing this up. You are right, the use case for empty input lists was not considered. Working on a fix now.

@fhieber the fix is currently merged. Can you please check if this issue is good to close ?

In commit dbe5c14ca6daa3e607ef8293735d33106f47a697 I'm seeing the same crash in sockeye.
Error in operator source_pos_embed_positional_encodings: [10:49:15] /home/kellen/Development/incubator-mxnet/src/operator/custom/custom.cc:523: Check failed: reinterpret_cast<CustomOpInferStorageTypeFunc>( params.info->callbacks[kCustomOpPropInferStorageType])( stypes.size(), stypes.data(), params.info->contexts[kCustomOpPropInferStorageType])

I've verified updating to ceb810ccc17a712c375d55418a0ba45ae91714b5 fixes the issue.  I think we can consider this one fixed, thanks for the quick work.  @fhieber you ok with closing?


When using customHTMLRenderer to replace image, It report an error "Cannot read property 'walker' of undefined"

Describe the bug
When I repeat this operating, I got an error "Cannot read property 'walker' of undefined":
https://github.com/nhn/tui.editor/blob/master/apps/editor/docs/custom-html-renderer.md#skipchildren
To Reproduce
See https://codesandbox.io/s/tuieditor-bug-cannot-read-property-walker-of-undefined-et5cs?file=/src/App.vue
<template>
  <div id="app">
    <base-editor ref="tui" :options="$editorOptions" />
  </div>
</template>

<script>
import "codemirror/lib/codemirror.css";
import<EMAIL_ADDRESS>
import { Editor as BaseEditor } from "@toast-ui/vue-editor";

export default {
  name: "App",
  components: { BaseEditor },

  created() {
    this.$editorOptions = {
      customHTMLRenderer: {
        image(node, context) {
          const { destination } = node;
          const { getChildrenText, skipChildren } = context;

          skipChildren();

          return {
            type: "openTag",
            tagName: "img",
            selfClose: true,
            attributes: {
              src: destination,
              alt: getChildrenText(),
            },
          };
        },
      },
    };
  },

  mounted() {
    const editor = this.$refs.tui.editor;
    editor.setMarkdown("Hello\n![](/logo.png)");
  },
};
</script>

Expected behavior
No error and normal work.
Screenshots

Desktop (please complete the following information):

OS: Windows 10
Browser Chrome
Version 87.0.4280.141

It also happens when we replace the heading tag.

It also happens when we replace the heading tag.

@richex-cn Could you give this example code by making it CodeSandbox?

@richex-cn Could you give this example code by making it CodeSandbox?

@richex-cn @ats1999 Oops... the document was wrong. It should have been called by passing node to the getChildrenText  function as a parameter. You can modify the code as follows. The documentation has been updated. Thanks for reporting the issue.
// ...

return {
  // ...
  attributes: {
    // ...
-  alt: getChildrenText(),
+  alt: getChildrenText(node),
  },
};

@richex-cn @ats1999 Oops... the document was wrong. It should have been called by passing node to the getChildrenText  function as a parameter. You can modify the code as follows. The documentation has been updated. Thanks for reporting the issue.
// ...

return {
  // ...
  attributes: {
    // ...
-  alt: getChildrenText(),
+  alt: getChildrenText(node),
  },
};


Externalise "MediaType" build in dedicated class

Hello!
I want to document some weird APIs.
Some are legacy and I cannot change the Java signature, but still want to document them. For example, they return some Foo object, but I want to document them as returning "Bar" object.
Some can for example return differents Schema depending on content-type. I don't think that your com.github.jrcodeza.Response can handle that, but OpenApi3 authorise that: https://swagger.io/docs/specification/describing-responses/
To allow users to handle all weird cases they might encounter, I propose to externalise all methods that can build MediaType in a public class that could be used by custom Interceptors.
For now, the com.github.jrcodeza.schema.generator.OperationsTransformer#createMediaType is private in OperationsTransformer and cannot be used outside this class.
WDYT?

Hi,
yes you're right there are section which could be extracted and reused this way in interceptors for example. I think we can do this, the only implementation problem I see is that createMediaType uses generationContext but that can be refactored, because generationContext is used here only to retrieve if class is in allowed package.
Do you also want to perform this change?

Hi,
Yes I can propose a PR for that! I think I can have something to show you today or monday.
Regards.

Hello @jrcodeza
I think I'm lost with the GenerationContext refactoring...
Do you have an idea how to do that?
I don't know how to do that properly :/
Thanks

Hi @aromanet42 ,
this is sketch of my idea :) https://github.com/jrcodeza/spring-openapi/commit/74df63940fc9d9bcd5508d942f045ff0f5b60e28

Hi @jrcodeza
I finally came up with https://github.com/jrcodeza/spring-openapi/pull/46
WDYT?

Hi @aromanet42 ,
looks good. Only I would rename MediaTypeBuilder to something else, but looks better now when the complex methods are extracted to a dedicated class.
thanks

PR merged

@aromanet42  both issues you've worked on are released in 1.4.6 ;)

@jrcodeza so nice! thanks a lot!


[0.1.0-beta.1] SaplingBuild(AnchorMismatch) when 2 transactions in a row

Reproduce

with more than 1 note
send funds that would leave available balance for a subsequent transaction
after balance has updated send another transaction

expected: both transactions should be created w/o problems
result: second transaction fails (see image above)
update 1: quick-rescan to oldest unspent note does not fix it
update 2: wiping the wallet and rescanning does not fix it either.

I've tracked the issue down to this: https://github.com/zcash/librustzcash/blob/main/zcash_client_backend/src/data_api/wallet.rs#L310-L314
This is not going to do the right thing when using change notes.


Adds support for capturing RDLogs in Python StdErr streams

Adds four basic logging functions to Chem that log through the C++
logging mechanism:
Chem.LogWarningMsg(msg)
Chem.LogInfoMsg(msg)
Chem.LogErrorMsg(msg)
Chem.LogDebugMsg(msg)
And a Wrapper to enable logs to be mirrored in Python SysStderr.  One of
the nicer features of this logging system, is that Threaded logging is
synchronized to Python where it is interleaved in raw C++ logging.
Chem.WrapLogs()
This allows:
 Chem.WrapLogs()
 sys.stderr = StringIO()
 ... rdkit stuff ...
 # sys.stderr has now captured all the RDKit Logs so we can do stuff with them
 errors = sys.stderr.getvalue()

Ug, I didn't notice the new conflicts, I may need to close and reopen.

Closed to fix line endings


[testsuite] Add retries to test_startup_sync_state

Summary
test_startup_sync_state was flaky probably because we were
not waiting for sync to complete.
This adds logic to retry and verify that the balances that
we expect are the actual balances in the wallet
#Test Plan
Test succeeds locally

That probably should not be prefixed with [cluster_test]

@bors-libra delegate+

:v: @ankushagarwal can now approve this pull request

@bors-libra r+

:pushpin: Commit bba979a has been approved by ankushagarwal

:hourglass: Testing commit bba979a1f3db1f256bc797f90520827c34b663ef with merge 0c5a53fe5c57c03df2a3b2ae92e46e1687eaa82f...

:broken_heart: Test failed - checks-circle_commit_workflow

We already have added this as a dependency for cluster-test[1] . We not only use the retry function, but also the Fixed delay iterator [2].
I am not sure where to draw the line for adding a dependency v/s rolling our our own module. In this case I think it's reasonable to add this dependency as retries are very common logic which I expect to be used in various parts of the codebase and the retry dependency adds value here.
[1] https://github.com/libra/libra/blob/8e2375914339e61dd6a51c77b49aaf30e93edd39/testsuite/cluster-test/Cargo.toml#L18
[2] https://github.com/jimmycuadra/retry/blob/ab48d2b467b04300414bf8cb0063ac074df43632/src/delay.rs#L107

I generally of agree with @huitseeker tbh.
I did not push for it in cluster test, but if we could have retry as our own function instead of pulling dependency, I would like it more. However to me this is not a blocker, so I'll leave it to you guys

Agree, we need to stop pulling non-std dependencies that are minor.
BTW I'm surprised we didn't get a warning from some bot, @metajack  ?

Yes, cargo-dep-bot should have commented on this. I'll see if I can find the logs tomorrow.

@bors-libra r+

:pushpin: Commit 8e4f938 has been approved by ankushagarwal

:hourglass: Testing commit 8e4f938c88d85341ea65c68f397c6010a760eec6 with merge 2b3ddd29c95e9288d45cd2f3b31f4495f24832e8...

:sunny: Test successful - checks-circle_commit_workflow
Approved by: ankushagarwal
Pushing 2b3ddd29c95e9288d45cd2f3b31f4495f24832e8 to master...

btw thx for addressing this @ankushagarwal


Long time waiting for a job to schedule: 'Node is not ready'

This issue is a: (mark with an x)

[X] bug report -> please search issues before submitting
[ ] documentation issue or request
[ ] regression (a behavior that used to work and stopped in a new release)

Issue description
When a new Container Apps Job is scheduled, sometimes it takes a long time for the job to start.
In the environment logs it looks like this (at least 7 minutes of waiting):

The jobs are configured with Workload Profiles (Consumption): 2 cpu, 4Gi
Region: westeurope
Steps to reproduce
It bites sometimes when using the jobs as build agents.
Expected behavior [What you expected to happen.]
Jobs are scheduled faster.
Actual behavior [What actually happened.]
Sometimes it takes a long time for the job to start.

hi @nosalan, we would need more information to investigate this.
Can you please send an email to acasupport at microsoft dot com with your subscription id, environment name, job name and approximate date time when this happened?

Hi @vinisoto, email sent.

hi - closing the loop here. We addressed the issue with @nosalan over email.


Add rarity colors

This PR adds rarity levels to card images using loot-rarity. I made Divine Robes appear in cyan, but feel free to change this to anything else of course.
The images are cached so that we don’t need to fetch them every time. There are not that many so I don’t think keeping them in cache would be an issue. An alternative would be to decode the data URI of the JSON to pass the source SVG without fetching anything else, let me know if you prefer doing that.

sweet, let's give this a shot


need to add image zoom button needed to improve sharpness for users

Uploaded photos are sometimes quite blurry which annoys users, so I suggest adding a photo zoom button so they can have a better visual experience

This repository is for the Twitter Open Source website https://opensource.twitter.dev/ - it is not for suggesting features or changes to Twitter.com. Thank you.


Check for improved landcover resolution

Currently we're using the 5'x5' MODIS landcover from here: http://glcf.umd.edu/data/lc/ That's a raster of 1776 rows x 4320 columns.
That source also has a link to "native resolution" tiles, but it doesn't say what resolution those tiles are. Are they better resolution? We should find out.

Also, when we've settled on the final source, we should add the appropriate citation. From that page, here's how we should cite:

How to Cite This Data Set
Data set development attribution:
Channan, S., K. Collins, and W. R. Emanuel. 2014. Global mosaics of the standard MODIS land cover type data. University of Maryland and the Pacific Northwest National Laboratory, College Park, Maryland, USA.

MODIS standard data product attribution:
Friedl, M.A., D. Sulla-Menashe, B. Tan, A. Schneider, N. Ramankutty, A. Sibley and X. Huang (2010), MODIS Collection 5 global land cover: Algorithm refinements and characterization of new datasets, 2001-2012, Collection 5.1 IGBP Land Cover, Boston University, Boston, MA, USA.

Intellectual Property Rights
University of Maryland, Department of Geography and NASA; use is free to all if acknowledgement is made. UMD and NASA hold ultimate copyright.

Okay that makes sense. Is the landcover data used for the original terrain tiles for the U.S. better resolution? Should we stick to that for the U.S.?

I looked at that a bit in #3... because at first I thought our North America data was higher resolution... but I've subsequently found better resolution global data, so we'll just use that. Plus, the landuse classes in the original North America raster are different from the classes in the global MODIS data. So the landcover areas wouldn't exactly line up with each other when you switch from one area to another. So that's another reason to use a single source for landcover.

Oh wait, or did I download it from here? http://landcover.usgs.gov/global_climatology.php I'm not sure anymore.

@almccon I'm closing this for now as it seems we are settled on using the USGS 0.5 km MODIS data.