[Bug]: Triton Error with GatedDeltaNet in Triton 2.2.0 and 2.3.x

Describe the bug
I encountered an error when trying to run the GatedDeltaNet model with Triton 2.2.0 and versions 2.3 and 2.3.1. The error message states: "error: operand 1 does not dominate this use". However, the code works fine with Triton version 3.0.

The full error log
loc(fused["/root/miniconda3/lib/python3.10/site-packages/fla/ops/gated_delta_rule/wy_fast.py":160:16, "/root/miniconda3/lib/python3.10/site-packages/fla/ops/gated_delta_rule/wy_fast.py":160:29]): error: operand #1 does not dominate this use
Traceback (most recent call last):
  File "/gpfs/public/pretrain/zhoufan/moba/moba/gated_delta_net.py", line 17, in <module>
    print(model(input_ids))
  File "/root/miniconda3/lib/python3.10/site-packages/torch/nn/modules/module.py", line 1553, in _wrapped_call_impl
    return self._call_impl(*args, **kwargs)
  File "/root/miniconda3/lib/python3.10/site-packages/torch/nn/modules/module.py", line 1562, in _call_impl
    return forward_call(*args, **kwargs)
  File "/root/miniconda3/lib/python3.10/site-packages/fla/models/gated_deltanet/modeling_gated_deltanet.py", line 398, in forward
    outputs = self.model(
  File "/root/miniconda3/lib/python3.10/site-packages/torch/nn/modules/module.py", line 1553, in _wrapped_call_impl
    return self._call_impl(*args, **kwargs)
  File "/root/miniconda3/lib/python3.10/site-packages/torch/nn/modules/module.py", line 1562, in _call_impl
    return forward_call(*args, **kwargs)
  File "/root/miniconda3/lib/python3.10/site-packages/fla/models/gated_deltanet/modeling_gated_deltanet.py", line 270, in forward
    hidden_states, attentions, past_key_values = layer(
  File "/root/miniconda3/lib/python3.10/site-packages/torch/nn/modules/module.py", line 1553, in _wrapped_call_impl
    return self._call_impl(*args, **kwargs)
  File "/root/miniconda3/lib/python3.10/site-packages/torch/nn/modules/module.py", line 1562, in _call_impl
    return forward_call(*args, **kwargs)
  File "/root/miniconda3/lib/python3.10/site-packages/fla/models/gated_deltanet/modeling_gated_deltanet.py", line 131, in forward
    hidden_states, attentions, past_key_values = self.attn(
  File "/root/miniconda3/lib/python3.10/site-packages/torch/nn/modules/module.py", line 1553, in _wrapped_call_impl
    return self._call_impl(*args, **kwargs)
  File "/root/miniconda3/lib/python3.10/site-packages/torch/nn/modules/module.py", line 1562, in _call_impl
    return forward_call(*args, **kwargs)
  File "/root/miniconda3/lib/python3.10/site-packages/fla/layers/gated_deltanet.py", line 246, in forward
    o, recurrent_state = chunk_gated_delta_rule(
  File "/root/miniconda3/lib/python3.10/site-packages/fla/ops/gated_delta_rule/chunk.py", line 1195, in chunk_gated_delta_rule
    o, final_state = ChunkDeltaRuleFunction.apply(
  File "/root/miniconda3/lib/python3.10/site-packages/torch/autograd/function.py", line 574, in apply
    return super().apply(*args, **kwargs)  # type: ignore[misc]
  File "/root/miniconda3/lib/python3.10/site-packages/fla/utils.py", line 18, in wrapper
    return fn(ctx,
  File "/root/miniconda3/lib/python3.10/site-packages/torch/amp/autocast_mode.py", line 455, in decorate_fwd
    return fwd(*args, **kwargs)
  File "/root/miniconda3/lib/python3.10/site-packages/fla/ops/gated_delta_rule/chunk.py", line 1051, in forward
    g, o, Aw, Au, final_state = chunk_gated_delta_rule_fwd(
  File "/root/miniconda3/lib/python3.10/site-packages/fla/ops/gated_delta_rule/chunk.py", line 880, in chunk_gated_delta_rule_fwd
    w, u, Aw, Au = fwd_prepare_wy_repr(
  File "/root/miniconda3/lib/python3.10/site-packages/fla/ops/gated_delta_rule/wy_fast.py", line 343, in fwd_prepare_wy_repr
    fwd_fn[(NT, B*H)](
  File "/root/miniconda3/lib/python3.10/site-packages/triton/runtime/autotuner.py", line 305, in run
    return self.fn.run(*args, **kwargs)
  File "/root/miniconda3/lib/python3.10/site-packages/triton/runtime/autotuner.py", line 143, in run
    timings = {config: self._bench(*args, config=config, **kwargs) for config in pruned_configs}
  File "/root/miniconda3/lib/python3.10/site-packages/triton/runtime/autotuner.py", line 143, in <dictcomp>
    timings = {config: self._bench(*args, config=config, **kwargs) for config in pruned_configs}
  File "/root/miniconda3/lib/python3.10/site-packages/triton/runtime/autotuner.py", line 122, in _bench
    return do_bench(kernel_call, warmup=self.warmup, rep=self.rep, quantiles=(0.5, 0.2, 0.8))
  File "/root/miniconda3/lib/python3.10/site-packages/triton/testing.py", line 102, in do_bench
    fn()
  File "/root/miniconda3/lib/python3.10/site-packages/triton/runtime/autotuner.py", line 110, in kernel_call
    self.fn.run(
  File "/root/miniconda3/lib/python3.10/site-packages/triton/runtime/jit.py", line 532, in run
    self.cache[device][key] = compile(
  File "/root/miniconda3/lib/python3.10/site-packages/triton/compiler/compiler.py", line 543, in compile
    next_module = compile_kernel(module)
  File "/root/miniconda3/lib/python3.10/site-packages/triton/compiler/compiler.py", line 437, in <lambda>
    stages["ttgir"] = (lambda path: parse_mlir_module(path, context), lambda src: optimize_ttgir(
  File "/root/miniconda3/lib/python3.10/site-packages/triton/compiler/compiler.py", line 151, in optimize_ttgir
    pm.run(mod)
RuntimeError: PassManager::run failed

Steps to reproduce the bug
from fla.layers.gated_deltanet import GatedDeltaNet
import torch

hidden_size = 1000
seq_len = 128
layer = GatedDeltaNet(hidden_size=hidden_size).to(torch.bfloat16).to("cuda")

x = torch.randn(1, seq_len, hidden_size).to(torch.bfloat16).to("cuda")

layer(x)

Expected behavior
The model should run without errors.
Environment info

torch: 2.4.0
triton: 2.2.0

hi, is there a specific reason to use Triton 2.2 or 2.3?  Or we would focus on supporting Triton 3.0 instead.

hi, is there a specific reason to use Triton 2.2 or 2.3? Or we would focus on supporting Triton 3.0 instead.

We can focus on supporting Triton 3.0. I noticed that you previously mentioned Triton 2.2 as being reliable for chunk parallelism in the README. However, I see that this section has been removed, and the README now requires Triton 3.0 instead.

removed

Thank you. We just updated the README due to this issue. Triton 3.0 is now stable and  the default version when calling pip install triton. We don't have plans to ensure the compatibilities for Triton 2, instead, we encourage users to use Triton 3.


Manipulate the bottom cards

Is there a way to show the stacked cards waiting to be swiped below instead of behind?
I've tried manipulating cardContainerStyle but no luck.

Currently, no.


feat: more tools for detecting unused imports

Hopefully also improves performance significantly.

@kim-em when adding features I think it would be good if you updated the README (Commands section), too.


Is it possible to have multiple separate functions for a workflow workspace?

Describe the issue
Is it possible to have 2 separate functions (in 2 separate files) in my Functions dir which can be found by the designer? I've tried to go through the wizard to add an azure function but I receive this error:
spawn C:\WINDOWS\system32\cmd.exe ENOENT
Are there any resources available for me to read about where the designer looks for these functions?
Here's my current dir structure:

I can see that when I dotnet build that my additional function generates metadata inside bin\Debug\net8\functions.metadata
Let me know if you need more info
Are you using new designer or old designer
New Designer (With action panels)
Screenshots or Videos
No response
Browser
na - using vscode
Additional context
No response

HI @Andrew-Lahikainen I had a chat with the custom code team and there is a bug today that makes the contract to not be updated. The fix for that is underway, but a workaround for that is do a dotnet clean before your dotnet build. According to the team, this will make the right contracts appear in the logic apps bin folder, which is what drives the designer to find them.  Let us know if that solves your problem for now.

This worked, thank you!


Consider rebasing Manage Files menu on a dialog

Overview
Similar to the "Create" menu:

Bug buttons are more non-tech users friendly so we can use this pattern for other drop-downs as well

WONTFIX


Integrate OpenAPI Specification generator from masseelch/elk into ent/contrib

The last CI fail is because of entproto.

🥳 🥳


System.Collections.Immutable.dll APIs are reported as not supported on .NET Framework

I think that they are reported as not compatible with .NET Framework is a bug in API Catalog. I guess due to the fact it was released OOB, it’s not counted as part of the .NET Framework, but counted belong to .NET Core. issue #400 tracked the similar problem with .NET Core and .NET Standard and it was fixed. Can we fix it for .NET Framework?

It is known issue or by design in the API catalog since API catalog only logs .NET Framework binaries shipped as part of .NET Framework release, not OOB components.

ApiPort was created for multiple purposes, there are primary ones amount them, one is identifying breaking changes from an older .NET Framework to newer .NET Framework (with option -b or -u), the other one is identifying missing APIs when porting apps/libs to .NET Core from .NET Framework. For identifying breaking change purpose, we have strong definition of which assemblies belong to .NET Framework (basically the .NET Framework assemblies shipped with .NET Redist or inbox of windows), the OOB released ,NET assemblies by .NET team are not defined as .NET Framework assemblies as of bydesign. However since .NET Core assemblies are all "OOB", .NET Core assemblies scope in some case is bigger than .NET Framework, like System.Collections.Immutable.dll was released OOB on .NET Framework and is not counted as .NET Framework assemblies, it is counted as .NET Core assemblies. This is why the reported issue. Due to two purpose sharing the same API catalog, we don't have a good short term solution. To make it less confusing, .NET Framework has been removed from the default Target platforms list for porting scenario since the porting scenario is primarily for estimating the gap from .NET Framework to .NET Core platforms anyway.
Please feel free to reopen the issue if you still have concern with this problem


Increased page size for REST API

Can one of the admins verify this patch?

@zhiyuli Can you review this small change?

constant setting changed.  +1


Animated pseudo effects?

Hi guys, I'm sure you've thought about how to achieve pseudo effects that could animate a property of the SVG - rather than a full replacement graphic.
This would require embedding the svg into the html, and some css declaration of said transition. So is probably out-of-scope for the project. But I'm still curious as to what type of thoughts/ideas you have for this?
Thx!

hey @joelataylor,
well, you're pretty much answering the question yourself: Stuff like this is definitely out of the scope of iconizr. ;)
iconizr's primary purpose is to provide full replacements (i.e. PNG fallbacks) for clients that don't support SVG. Another side effect is that iconizr creates SVG sprites for you. You wouldn't need a tool like this to do these animation effects you're talking about (and in fact I can't imagine how a tool could help you with that at all). You're right, you will have to embed the SVG inline into your HTML document, and you will need to specify the animations manually.
You might have noticed that this (PHP-based) version of iconizr is pretty outdated and unmaintained. You should have a look at svg-sprite, which is the base of the Node-based iconizr version. svg-sprite has lots of additional features, e.g. support for inline SVG sprites. I'm considering adding features for dynamically embedding the SVGs into HTML source for quite a while now, but so far I'm just lacking the time for that.
Hope this helped a little.
Cheers, Joschi


Gramatical fix to kompose introduction

I just spotted a small bit of the Kompose documentation that didn't read very well.
As much of the original sentence has been preserved as possible; primarily to ensure the kompose web address is see both in text and as a href link, this way people can copy and paste it easily.

@BlueHatbRit Thanks!
/lgtm

Brilliant, thanks for the merge :)


Code/Comment Percentage Pie Chart

The raw lines of comment and code are inconsistent with the final project data (on the most recent checkin).

The query to get the total amount of code and comments were different. The correct query was updated for the Pie chart and is now the same as the graph in 0dac939992ab7de03314ccd30c9d8d95b83bf721.


Use curve: false when rendering charts

I think the curves "smooth" the reality, making it harder to view the changes if there is a sudden drop.
From chartckick docs:
Straight lines between points instead of a curve
<%= line_chart data, curve: false %>

Looks much better now. Thanks!


xbox one controller malfunctioning on ps2

Good afternoon
I have a problem using an xbox one controller on the esp32 on the ps2, if I use a ps3 controller it works perfect, but the xbox one controller has problems, the buttons are uneven, some do not react, the only thing that works well is the cross

BlueRetro only support latest xbox Firmware, update with Update via the Xbox accessories Win10 app.

Thank you very much, I will update, greetings friend good day.


Unable to download the previous releases elasticsearch and kibana

Query
Unable to download the previous releases elasticsearch and kibana
Expected Behavior
From the version history page, if a specific version is chosen, it should take to download of the installer of the respective version.
Current Behavior
Irrespective of any release/version, the download page always takes to the latest version.

@logztechstuff , Currently we do not have a page to download previous versions but as a workaround please use the below download URL's (after replacing the version placeholder) to download previous versions
https://d3g5vo6xdbdb9a.cloudfront.net/tarball/opendistro-elasticsearch/opendistroforelasticsearch-[version].tar.gz
https://d3g5vo6xdbdb9a.cloudfront.net/tarball/opendistroforelasticsearch-kibana/opendistroforelasticsearch-kibana-[version].tar.gz

thanks, @bbarani. Whether this build is compatible with macOS?

Kibana doesn't run on the macOS as the node binary bundled with Kibana is for Linux, not compatible with macOS. To run the Kibana in macOS, I followed the below steps.

Remove node and node_modules from OpenDistro Kibana
Download the macOS compatible Kibana from Elasticsearch where the Kibana version must be the same as the version used in OpenDistro. For each version of OpenDistro corresponding Elastic version can be referred https://opendistro.github.io/for-elasticsearch-docs/version-history/
Extract the installer, copy the node and node_modules directories from Elastic's Kibana to OpenDistro Kibana.
Remove the installer and extracted directory


Add a LOCATION conveniance parser

I propose to add a static parser named LOCATION to Parsers, similar to the INDEX parser.
This does not add any new functionality to jparsec, But it would, IMHO, enhance the usability.
The location information can be recomputed using the source string and the index returned by the INDEX parser. But doing so is not really trivial. I mention SourceLocator as an example.
Also , from my own experience, I was a little frustrated when I realized that the functionality must exist within jparsec and there's no way to access it. So I looked into the source, found SourceLocator and copied it. But it still feels dirty to have to do it,
I think any user who's interested in line/offset information would appreciate having a LOCATION parser instead of doing the work himself..
There are alternatives how to help the user with location information,

Make SourceLoacator public. A user won't have to reinvent the wheel. To me this option is a mismatch with the jparsec philosophy to provide functionality as a parser.
Make ParseContext public. A user can just write his own location parser. This option opens many cans of worms that should maybe better be left unopened ...

I think API-wise, it makes perfect sense. The reason LOCATION hasn't been added is for efficiency.
JParsec's evaluation is eager. Each time it tries a parser object, the value is evaluated, and when parser backtracks, the previously evaluated values are discarded.
This however doesn't perfectly align with SourceLocator, which is slower than O(1). At time of constructing the parser exception, this is fine because we do it just once.
But to be able to compute the location all the time as the parser advances the cursor or backtracks, a more efficient implementation may be needed.

One possibility is maybe to make the Location class an interface, and then create a lazy implementation of it.
This way merely constructing Location object at backtrack won't be expensive.
Although, I'm not super confident about the performance difference difference. SourceLocator uses binary search so it may not be all that bad. If you have some time to do some benchmarking that'd be super useful for us to decide whether it's worth it to pull the lazy-calculation trick.

OK, I'll give it a try.

Thanks for doing the benchmark!
Given that parsers with backtracking could be negatively impacted by LOCATION, I wonder if we should implement a lazy Location parser?
For example, we could add a SourceIndex class as such:
public final SourceIndex {
  private final int index;
  private final SourceLocator locator;
  private Location location;

  public int getIndex() {
    return index;
  }

  // call it only after the parser has succeeded.
  public synchronized Location getLocation() {
    if (location == null) location = locator.locate(index);
    return location;
  }
}

Once we have it, we can deprecate INDEX parser, and add public static final Parser<SourceIndex> SOURCE_INDEX as the new way to get either the index or the location and perhaps even more functionalities, such as the tokens before and after it if we need them.

An unrelated observation: The snapshot javadoc is not available at the moment,

Fixed javadoc.
Added SOURCE_LOCATION parser. Please give it a try and let me know what I may be missing?
Thanks!

Performance is within measurement error of INDEX parser.
I'd call it a good job :-)


fix error in variational_classifier.ipynb

[NbConvertApp] ERROR | Error while converting '/home/buildslave/nightly_default/build/doc/ipython-notebooks/gaussian_process/variational_classifier.ipynb'
Traceback (most recent call last):
  File "/usr/local/lib/python2.7/dist-packages/nbconvert/nbconvertapp.py", line 357, in export_single_notebook
    output, resources = self.exporter.from_filename(notebook_filename, resources=resources)
  File "/usr/local/lib/python2.7/dist-packages/nbconvert/exporters/exporter.py", line 165, in from_filename
    return self.from_file(f, resources=resources, **kw)
  File "/usr/local/lib/python2.7/dist-packages/nbconvert/exporters/exporter.py", line 183, in from_file
    return self.from_notebook_node(nbformat.read(file_stream, as_version=4), resources=resources, **kw)
  File "/usr/local/lib/python2.7/dist-packages/nbconvert/exporters/html.py", line 65, in from_notebook_node
    return super(HTMLExporter, self).from_notebook_node(nb, resources, **kw)
  File "/usr/local/lib/python2.7/dist-packages/nbconvert/exporters/templateexporter.py", line 200, in from_notebook_node
    nb_copy, resources = super(TemplateExporter, self).from_notebook_node(nb, resources, **kw)
  File "/usr/local/lib/python2.7/dist-packages/nbconvert/exporters/exporter.py", line 130, in from_notebook_node
    nb_copy, resources = self._preprocess(nb_copy, resources)
  File "/usr/local/lib/python2.7/dist-packages/nbconvert/exporters/exporter.py", line 302, in _preprocess
    nbc, resc = preprocessor(nbc, resc)
  File "/usr/local/lib/python2.7/dist-packages/nbconvert/preprocessors/base.py", line 47, in __call__
    return self.preprocess(nb,resources)
  File "/usr/local/lib/python2.7/dist-packages/nbconvert/preprocessors/execute.py", line 145, in preprocess
    nb, resources = super(ExecutePreprocessor, self).preprocess(nb, resources)
  File "/usr/local/lib/python2.7/dist-packages/nbconvert/preprocessors/base.py", line 70, in preprocess
    nb.cells[index], resources = self.preprocess_cell(cell, resources, index)
  File "/usr/local/lib/python2.7/dist-packages/nbconvert/preprocessors/execute.py", line 176, in preprocess_cell
    raise CellExecutionError(msg)
CellExecutionError: An error occurred while executing the following cell:
------------------
#Since inducing points are generated by random, decision boundary of SingleFITCLaplace could be different if random seed is different
np.random.seed(3)
input_path=os.path.join(SHOGUN_DATA_DIR, 'toy/banana.dat)'
n_inducing_points=8
plot_large_scale_with_inducing_points(input_path,n_inducing_points)
------------------

SyntaxError: invalid syntax (<ipython-input-15-7dcd9a5a5525>, line 4)

I ran the ipython notebook in jupyter and got the following error.

I think Error code(5) means access is denied somewhere but I don't know where...

@minxuancao  this is not an error. It is a warning. The minimizer stops due to some reason. The reason is coded in NLOPT. Please see the error code (e.g. 5 in this case) defined in NLOPT.

@vigsterkr is it because of a misplace in position of " ' " in this line?
input_path=os.path.join(SHOGUN_DATA_DIR, 'toy/banana.dat)'

@deveshnag1 most probably... then again the task is to check and solve this issue :)

@vigsterkr How do I check it? In a jupyter notebook?

@deveshnag1 i'm not so sure how you've tested that notebook as although the particular error is gone from the notebook but there's other now:
[NbConvertApp] ERROR | Error while converting '/home/buildslave/nightly_default/build/doc/ipython-notebooks/gaussian_process/variational_classifier.ipynb'
Traceback (most recent call last):
  File "/usr/local/lib/python2.7/dist-packages/nbconvert/nbconvertapp.py", line 357, in export_single_notebook
    output, resources = self.exporter.from_filename(notebook_filename, resources=resources)
  File "/usr/local/lib/python2.7/dist-packages/nbconvert/exporters/exporter.py", line 165, in from_filename
    return self.from_file(f, resources=resources, **kw)
  File "/usr/local/lib/python2.7/dist-packages/nbconvert/exporters/exporter.py", line 183, in from_file
    return self.from_notebook_node(nbformat.read(file_stream, as_version=4), resources=resources, **kw)
  File "/usr/local/lib/python2.7/dist-packages/nbconvert/exporters/html.py", line 65, in from_notebook_node
    return super(HTMLExporter, self).from_notebook_node(nb, resources, **kw)
  File "/usr/local/lib/python2.7/dist-packages/nbconvert/exporters/templateexporter.py", line 200, in from_notebook_node
    nb_copy, resources = super(TemplateExporter, self).from_notebook_node(nb, resources, **kw)
  File "/usr/local/lib/python2.7/dist-packages/nbconvert/exporters/exporter.py", line 130, in from_notebook_node
    nb_copy, resources = self._preprocess(nb_copy, resources)
  File "/usr/local/lib/python2.7/dist-packages/nbconvert/exporters/exporter.py", line 302, in _preprocess
    nbc, resc = preprocessor(nbc, resc)
  File "/usr/local/lib/python2.7/dist-packages/nbconvert/preprocessors/base.py", line 47, in __call__
    return self.preprocess(nb,resources)
  File "/usr/local/lib/python2.7/dist-packages/nbconvert/preprocessors/execute.py", line 145, in preprocess
    nb, resources = super(ExecutePreprocessor, self).preprocess(nb, resources)
  File "/usr/local/lib/python2.7/dist-packages/nbconvert/preprocessors/base.py", line 70, in preprocess
    nb.cells[index], resources = self.preprocess_cell(cell, resources, index)
  File "/usr/local/lib/python2.7/dist-packages/nbconvert/preprocessors/execute.py", line 176, in preprocess_cell
    raise CellExecutionError(msg)
CellExecutionError: An error occurred while executing the following cell:
------------------
#an example for the sonar data set
train_size=108
(x_train, y_train, x_test, y_test, B)=extract(os.path.join(SHOGUN_DATA_DIR, 'uci/sonar/sonar.all-data', train_size))
inference_methods =[
                  KLDualInferenceMethod,
                  SingleLaplaceInferenceMethod,
                  SingleLaplaceInferenceMethod,
                  KLDiagonalInferenceMethod,
                  #KLCholeskyInferenceMethod, #this method takes too long to run
                  #KLCovarianceInferenceMethod, #this method takes too long to run
                  ]

likelihoods =[
            LogitDVGLikelihood(), #KLDual method uses a likelihood class that supports dual variational inference
            LogitLikelihood(),
            LogitVGLikelihood(), #KL method uses a likelihood class that supports variational inference
            LogitVGLikelihood(), #KL method uses a likelihood class that supports variational inference
            #LogitVGLikelihood(), #KL method uses a likelihood class that supports variational inference
            #LogitVGLikelihood(), #KL method uses a likelihood class that supports variational inference
            ]

minimizers =[
            KLDualInferenceMethodMinimizer,
            None, #using default minimizer
            LBFGSMinimizer,
            LBFGSMinimizer,
            #LBFGSMinimizer,
            #LBFGSMinimizer,
            ]

linesearches=[
            BACKTRACKING_ARMIJO,
            None, #using default line search method
            BACKTRACKING_STRONG_WOLFE,
            BACKTRACKING_STRONG_WOLFE,
            #BACKTRACKING_STRONG_WOLFE,
            #BACKTRACKING_STRONG_WOLFE,
            ]

col_size=8
lscale_min=0.0
lscale_max=5.0
lsigma_min=0.0
lsigma_max=5.0
delta=0.5
scale=5.0

lscale_list = np.arange(lscale_min, lscale_max, delta)
lsigma_list = np.arange(lsigma_min, lsigma_max, delta*scale)
lScale, lSigma = np.meshgrid(lscale_list, lsigma_list)
width=len(likelihoods)/2
f, plots =plt.subplots(width, 2, figsize=(col_size*2,col_size*width))

approx_bit_plot(inference_methods, minimizers, linesearches, likelihoods, x_train, y_train,  x_test, y_test, plots, lScale, lSigma, B)

plt.show()
------------------

AttributeError: 'int' object has no attribute 'startswith'

@vigsterkr It seems there was another error that I overlooked towards the end. I'll send a PR ASAP. Sorry for the mistake.


Add kustomize overlay for kubeflow

/kind feature
Currently Standalone KFServing installs in kfserving-system namespace while kubeflow installs kfserving in kubeflow namespace, the difference between standalone and kubeflow installation for KFServing is really minor with the gateway configuration besides the namespace. So we'd like to publish the kfserving deployment manifest for kubeflow along side with standalone manifest, this gives user an easy upgrade experience by applying the KFServing release yaml directly if they want to get onto the edge of KFServing.
Describe the solution you'd like
We can create a kubeflow kustomize overlay under KFServing config directory and publishes the yaml for every KFServing release.

Kustomize namespace to kubeflow
Kustomize KFServing configmap gateway to kubeflow-gateway.kubeflow.

Anything else you would like to add:
[Miscellaneous information that will assist in solving the issue.]

/assign


Installing and cli command

Can I install this code as a package on Centos?   i am new on linux

Hi @web-apply
cgif is relatively new, so it's not yet packaged for many distributions. But you may want to have a look here:
https://repology.org/project/cgif/versions
If cgif is not yet available for your Linux distribution, you can compile/install cgif as a shared library from source:
Requirements:

C compiler (e.g. gcc, clang)
meson build system

Steps:
For Centos the commands for building and installing cgif from source should look like this:

sudo yum install meson gcc
git clone https://github.com/dloebl/cgif
cd cgif/
meson setup build --prefix=/usr
sudo meson install -C build

I've also added general notes on the installation/compilation of cgif to INSTALL.md. I hope this information is helpful.


Bolt 2.0 is using old version of reboot module

Describe the Bug
When trying to run the reboot plan with Bolt 2.0 it fails with:
{
  "kind": "bolt/pal-error",
  "msg": "reboot:\n  has no parameter named 'targets'\n  expects a value for parameter 'nodes'",
  "details": {
  }
}

Expected Behavior
This plan should accept targets as a parameter.
Steps to Reproduce
plan mymodule::myplan (
  TargetSpec $targets,
) {
  run_plan('reboot', targets => $targets)
}

Environment

Version: Bolt 2.0

Additional Context
Looks like the change was merged into the reboot module's master branch, but a release wasn't done: https://github.com/puppetlabs/puppetlabs-reboot/blob/master/plans/init.pp
The lastest release of this module is 2.4.0 and does NOT contain the updated plan. Looks like we're including version 2.2.0 in Bolt: https://github.com/puppetlabs/bolt/blob/master/Puppetfile#L28
I've created a ticket in JIRA for the Modules team: https://tickets.puppetlabs.com/browse/MODULES-10569

Closed by #1638


Keep annotations while type checking

We have
data TypeError a = InternalError -- ^ This is thrown if builtin lookup fails
                 | KindMismatch a (Type TyNameWithKind ()) (Kind ()) (Kind ())
                 | TypeMismatch a (Term TyNameWithKind NameWithType ()) (Type TyNameWithKind ()) (NormalizedType TyNameWithKind ())
                 | OutOfGas
deriving (Show, Eq, Generic, NFData)

but that is inconsistent with how we usually deal with annotations: they're propagated further into what is stored in constructors. And I needed that latter representation, so I changed TypeError to
data TypeError a = InternalError -- ^ This is thrown if builtin lookup fails
                 | KindMismatch a (Type TyNameWithKind a) (Kind a) (Kind a)
                 | TypeMismatch a (Term TyNameWithKind NameWithType a) (Type TyNameWithKind a) (NormalizedType TyNameWithKind a)
                 | OutOfGas
                 deriving (Show, Eq, Generic, NFData)

and updated the TypeSynthesis module to preserve annotations. This all is straightforward except we have things like
kindOf (TyBuiltin x b) = do
    (BuiltinTable tyst _) <- ask
    case M.lookup b tyst of
        Just k -> pure $ x <$ k
...
typeOf (Constant x (BuiltinName _ n)) = do
    (BuiltinTable _ st) <- ask
    case M.lookup n st of
        Just k -> pure $ x <$ k

i.e. the inferred kind/type of a built-in is annotated with the same thing the built-in is annotated with.
Later I realized that I it's not necessary for me to have annotations propagated in the TypeError, but I think it's a fine change anyway.

I thought about this too, but I actually think they shouldn't be there. Or at least not for the synthesized types - it's not clear that these can have a sensible annotation at all, since they're synthetic, so having the type be () seems right.

I am on the fence about this. If you need it later on for some reason, that is fine, but as it stands synthesized types don't necessarily have a location, as Michael said.

Or at least not for the synthesized types

Synthesized types with annotations are used when throwing errors with types with annotations. We can have a typeOf that keeps annotations and another one, defined in terms of the former, that removes them.

I am on the fence about this. If you need it later on for some reason, that is fine, but as it stands synthesized types don't necessarily have a location, as Michael said.

Yeah, I do understand this, but if we always propagate annotations everywhere except TypeError that seems like an inconsistency and very ad hoc. I may need the consistent TypeError later, but that's another discussion.
Annotations are also not senseless. A synthesized type is annotated by the locations of subterms that caused to produce that type. This can be potentially useful for debugging. Imagine you've synthesized a big type and you want to figure out why some part of it looks like it looks.

Annotations are also not senseless. A synthesized type is annotated by the locations of subterms that caused to produce that type.

This makes sense for locations, I'm not sure it makes sense for other kinds of annotations, which might have semantics more closely tied to the exact thing they're annotating. The TypeError already has the location in it - why do we need to add it again?

This makes sense for locations, I'm not sure it makes sense for other kinds of annotations, which might have semantics more closely tied to the exact thing they're annotating.

True.

The TypeError already has the location in it - why do we need to add it again?

We are more specific there, it's not just a single location in an inferred type.
Okay, so I do agree with you, I just don't like that TypeError has annotations that do not follow what seemed to be a rule for me. I can live with that, though.

Okay, so I do agree with you, I just don't like that TypeError has annotations that do not follow what seemed to be a rule for me. I can live with that, though.

I agree that it's weird on the face of it, but I do think there's a good reason in this case.


Modify documentation on the Injecting Extra Context.

ref: #863
@hackebrot here it is. Thoughts?

Current coverage is 100% (diff: 100%)

Merging #864 into master will not change coverage

@@           master   #864   diff @@
====================================
  Files          16     16
  Lines         661    661
  Methods         0      0
  Messages        0      0
  Branches        0      0
====================================
  Hits          661    661
  Misses          0      0
  Partials        0      0

Powered by Codecov. Last update 03dc984...d0692a5

:bell: @karantan

@michaeljoseph I'll fix it at the end of the week (I just created reminder for this). I've been swamped with other stuff.

@michaeljoseph PR fixed. Sorry it took so long.

I think this PR is good to merge! @michaeljoseph

:+1: Thanks @karantan!


Submodel.SubmodelElements, SubmodelElementCollection and Entity.statements should be ordered

For all cases, where a generic implementation tries to visualize multiple attributes, it is very inconvenient, when the order of the attributes differs between multiple instances of the same class (Attribute as generic synonym for SubmodelElement or Statement).
There are many examples of standardized Submodel templates with more than ten SubmodelElements. When browsing over multiple AAS with the same standardized Submodel, it would be very unhandy, if the viewed position of the same SubmodelElement is in one case at the top of the page, in another at the bottom. Or even worse, when viewing the same object multiple times, the order of elements is always shuffled - which is really annoying.
Sorting the SubmodelElements in a Viewer by alphabetical order of the idShort doesn't make sense, since it leads to technical, disfigured names like: ConnectionEndpoint, ConnectionEndpointCredName, ConnectionEndpointCredPass (to enforce, that you see first the endpoint, then username and password in the correct order (u > p)).
So please consider to specify, that the order of SubmodelElements in Submodel.SubmodelElements, SubmodelElementCollection and Entity.statements should be preserved, so that the elements can be visualized in a recurring way.
To be clear - I'm not stating, that SubmodelElements of e.g. Submodels with the same SemanticId should have always the exact index - that would foil the flexibility of Submodels and the ability to extend/adapt them. But preserving the order, once they are initialized, would be very helpful.

@FrankSchnicke @mjacoby Issue created as discussed

@alexgordtop I probably lack the context -- could you please clarify which version of the meta-model you are referring to?
In the current V3RC02, the attribute Submodel/submodelElements is indeed an (ordered) list. This is also reflected in the schemas (e.g., a JSON array, see https://github.com/admin-shell-io/aas-specs/blob/ee3cdf493601f0f7f4b8c258285d324701a8c0eb/schemas/json/aas.json#L1127).

@mristin Ah, thanks for clarification - we couldn't figure that out from the specification document of part 1.
Would be nice, if there would be a sentence about that in the metamodel description (table). The same applies for Entity and SubmodelElementCollection. That is, because for SubmodelElementList, it is explicitly stated, that this list is ordered - that implicates a difference to SubmodelElementCollection.
Specifically, page 78, table of SubmodelElementCollection - Explanation - It has a fixed number of submodel elements, that must keep their order, unless explicitly changed.
Page 71, table of Entity, attribute statement (missing an "s", since that are multiple ones?) - Please add "Statements must keep their order, unless explicitly changed."
Page 61, table of Submodel, attribute submodelElement (missing an "s", since that are multiple ones?) - Please add "SubmodelElements must keep their order, unless explicitly changed."

@BirgitBossI think this is a finding for the next version?
@alexgordtop I only help out with the schemas -- please discuss the matter with @BirgitBoss who maintains the book.

@mristin Ah, thanks for clarification - we couldn't figure that out from the specification document of part 1.
Would be nice, if there would be a sentence about that in the metamodel description (table). The same applies for Entity and SubmodelElementCollection. That is, because for SubmodelElementList, it is explicitly stated, that this list is ordered - that implicates a difference to SubmodelElementCollection.
Specifically, page 78, table of SubmodelElementCollection - Explanation - It has a fixed number of submodel elements, that must keep their order, unless explicitly changed.
Page 71, table of Entity, attribute statement (missing an "s", since that are multiple ones?) - Please add "Statements must keep their order, unless explicitly changed."
Page 61, table of Submodel, attribute submodelElement (missing an "s", since that are multiple ones?) - Please add "SubmodelElements must keep their order, unless explicitly changed."

w.r.t. "s": no, all elements are described as singular in the specification, i.e. independent of the cardinality

w.r.t ordering I will take the requirement to the specification team

Since this issue seems to be done, I will close it. Feel free to reopen it, if this was a mistake.

Although I did not create this issue it is based on the discussion within the IDTA AAS Cloud Repository Group where I have been part of the underlying discussion.
It is still not 100% clear to me what the current situation on these issues is.
I did analyze the latest version of the specification IDTA Number: 01001-3-0 March 2023  available here https://industrialdigitaltwin.org/en/wp-content/uploads/sites/2/2023/06/IDTA-01001-3-0_SpecificationAssetAdministrationShell_Part1_Metamodel.pdf and this is what I came up with

SubmodelElementCollection.value not ordered (see p. 77)
SubmodelElementList.value (always) ordered, but order not always relevant (see p.78)
Submodel.submodelElement no detailed information, therefore default clause (p. 139 Annex E) takes effect which says it is an unordered set
Entity.statement no detailed information --> unordered set

However, this seems to be in conflict with previous answers given here, e.g. https://github.com/admin-shell-io/aas-specs/issues/248#issuecomment-1344159107 from @mristin stating that Submodel.submodelElement is an ordered list.
Please provide a definitive answer to these questions and for each point me to the corresponding section in the spec where this is defined.

Finally I became involved into this discussion with Alexander and Michael.
I haved learned, that SubmodelElementList has an attribute "orderRelevant".
Within our 3 person discussion we concluded, that SubmodelElementList must always have an order, since the list is addressed in the API by "[index]" instead of idShort.
This needs to be discussed in the specification team.

Any updates on this? @aorzelskiGH


Release tasks 0.1.0

This pull request was generated using releasetool.

Release is at https://github.com/GoogleCloudPlatform/google-cloud-python/releases/tag/tasks-0.1.0


Add convenience function to set trace-Id/span-Id

In tools/mod.rs line 86 there is the convenience function find_current_trace_id() defined. This is nice to get the Trace-Id from from context (for the Span-Id is basically the same).
It would be nice to have a counterpart to set the Trace-Id and Span-Id from a string.
set_trace_id_in_context(trace_id: String) { ... }

My use-case is the following:
I send a message with kafka where i add the Trace-Id and Span-Id in b3-format in the message:
pub fn get_b3_trace_id() -> Option<String> {
    use opentelemetry::trace::TraceContextExt;
    use tracing_opentelemetry::OpenTelemetrySpanExt;
    let context = tracing::Span::current().context();
    let span = context.span();
    let span_context = span.span_context();

    let span_id = span_context
        .is_valid()
        .then(|| span_context.span_id().to_string());

    let trace_id = span_context
        .is_valid()
        .then(|| span_context.trace_id().to_string());

    if trace_id.is_none() || span_id.is_none() {
        None
    } else {
        // https://github.com/openzipkin/b3-propagation
        Some(format!("{}-{}-1", trace_id.unwrap(), span_id.unwrap()))
    }
}

On receiver side i have problems though to set the context correctly so all instrumented functions (with their spans) are tracked as children under the received Trace-Id.
I've tried different approaches but all implementations have the  problem that only the directly instrumented code block is mapped to the correct Trace-Id (i only see a span under the trace for the block where I call the .instrument(span).
I use code similar to this:
let span = span!(Level::TRACE, "");
let context = get_context_from_b3(tracing_propagator.clone(), trace_id.to_string());
tracing_opentelemetry::OpenTelemetrySpanExt::set_parent(&span, context);
{
    ...
   // Problem: functions that are called here, that are annotated with #[instrument(name = "xyz"]
   // have a different Trace Id and are not correlated to the span that instruments the current block
}.instrument(span);

pub fn get_context_from_b3(propagator: Arc<Propagator>, b3_trace_id: String) -> Context {
    let mut extractor: HashMap<String, String> = HashMap::new();
    extractor.insert(B3_SINGLE_HEADER.to_string(), b3_trace_id);

    let context = propagator
        .extract_single_header(&extractor)
        .expect("Couldn't extract trace header");

    use opentelemetry::trace::TraceContextExt;

    Context::new().with_remote_span_context(context)
}

I would appreciate if you can provide a convenience function that simplifies setting the trace-id / (parent-)span-id or if you could explain how to solve it.
Thanks in advance!

Hi,
Disclaimer: I'm not a tracing expert, and maybe I don't fully understand your issue.
Trace-id is not a mutable information.
My hypothesis is that your code block doesn't use the right parent span, aka calling }.instrument(span) is too late. Did you try to enter (activate the span) before your code block (see https://docs.rs/tracing/latest/tracing/span/index.html#entering-a-span) ?
Maybe something like
let span = span!(Level::TRACE, "");
let context = get_context_from_b3(tracing_propagator.clone(), trace_id.to_string());
tracing_opentelemetry::OpenTelemetrySpanExt::set_parent(&span, context);
span.in_scope(|| {

  // call other instrumented function
});

Thank you for the hint to enter a span and the link to the documentation about entering a span.
span.in_scope(|| {...}) doesn't work in my case as i have asynchronous code and according to the documentation only synchronous code should be put into the closure.
The documentation about entering a span though lead me to the span.enter() function documentation. My use-case is there not 100% covered, but it lead my on the right path. I figured out that I have to instrument nested async function calls with the same span (I'm not sure if this is really the correct way to do it, but it works as intended).
The code looks like the following now:
let span = init_span_with_parent_from_kafka_message(kafka_message.headers(), tracing_propagator);
let _ = span.enter();
let _ = {
  //do something

  //Call nested async function that has #[instrument] attribute.
  //
  //It is not so nice, that the span has to be cloned, but at least it works as expected.
  //
  //Further instrumented nested functions that are called within "call_async_function"
  //are correctly correlated to the parent span / trace-id without further adjustments.
  call_async_function(..).instrument(span.clone()).await;

  // do more things
}.instrument(span);

With this adjustment all nested spans are correctly sent to jaeger and displayed at the correct position.
The ticket can be closed as there is no further adjustment need in the library. Thanks again for your help!


Minor vulnerabilities in npm audit

Laravel Mix Version: #.#.# (npm list --depth=0): 4.1.4
Node Version (node -v): 10.15.2
NPM Version (npm -v): 6.14.1
OS: Debian GNU/Linux 10 (buster)

Description:
Since 20th of March 2020, npm prints message with vulnerabilities
npm audit --json
{
"actions": [
{
"action": "review",
"module": "minimist",
"resolves": [
{
"id": 1179,
"path": "laravel-mix>babel-loader>mkdirp>minimist",
"dev": false,
"optional": false,
"bundled": false
},
{
"id": 1179,
"path": "laravel-mix>optimize-css-assets-webpack-plugin>cssnano>cssnano-preset-default>postcss-svgo>svgo>mkdirp>minimist",
"dev": false,
"optional": false,
"bundled": false
},
{
"id": 1179,
"path": "laravel-mix>terser-webpack-plugin>cacache>mkdirp>minimist",
"dev": false,
"optional": false,
"bundled": false
},
{
"id": 1179,
"path": "laravel-mix>webpack>terser-webpack-plugin>cacache>mkdirp>minimist",
"dev": false,
"optional": false,
"bundled": false
},
{
"id": 1179,
"path": "laravel-mix>terser-webpack-plugin>cacache>move-concurrently>copy-concurrently>mkdirp>minimist",
"dev": false,
"optional": false,
"bundled": false
},
{
"id": 1179,
"path": "laravel-mix>webpack>terser-webpack-plugin>cacache>move-concurrently>copy-concurrently>mkdirp>minimist",
"dev": false,
"optional": false,
"bundled": false
},
{
"id": 1179,
"path": "laravel-mix>terser-webpack-plugin>cacache>move-concurrently>mkdirp>minimist",
"dev": false,
"optional": false,
"bundled": false
},
{
"id": 1179,
"path": "laravel-mix>webpack>terser-webpack-plugin>cacache>move-concurrently>mkdirp>minimist",
"dev": false,
"optional": false,
"bundled": false
},
{
"id": 1179,
"path": "laravel-mix>webpack>mkdirp>minimist",
"dev": false,
"optional": false,
"bundled": false
},
{
"id": 1179,
"path": "laravel-mix>webpack-dev-server>portfinder>mkdirp>minimist",
"dev": false,
"optional": false,
"bundled": false
},
{
"id": 1179,
"path": "laravel-mix>webpack-dev-server>webpack-dev-middleware>mkdirp>minimist",
"dev": false,
"optional": false,
"bundled": false
},
{
"id": 1179,
"path": "laravel-mix>chokidar>fsevents>node-pre-gyp>mkdirp>minimist",
"dev": false,
"optional": true,
"bundled": true
},
{
"id": 1179,
"path": "laravel-mix>webpack>watchpack>chokidar>fsevents>node-pre-gyp>mkdirp>minimist",
"dev": false,
"optional": true,
"bundled": true
},
{
"id": 1179,
"path": "laravel-mix>webpack-dev-server>chokidar>fsevents>node-pre-gyp>mkdirp>minimist",
"dev": false,
"optional": true,
"bundled": true
},
{
"id": 1179,
"path": "laravel-mix>chokidar>fsevents>node-pre-gyp>tar>mkdirp>minimist",
"dev": false,
"optional": true,
"bundled": true
},
{
"id": 1179,
"path": "laravel-mix>webpack>watchpack>chokidar>fsevents>node-pre-gyp>tar>mkdirp>minimist",
"dev": false,
"optional": true,
"bundled": true
},
{
"id": 1179,
"path": "laravel-mix>webpack-dev-server>chokidar>fsevents>node-pre-gyp>tar>mkdirp>minimist",
"dev": false,
"optional": true,
"bundled": true
},
{
"id": 1179,
"path": "laravel-mix>chokidar>fsevents>node-pre-gyp>rc>minimist",
"dev": false,
"optional": true,
"bundled": true
},
{
"id": 1179,
"path": "laravel-mix>webpack>watchpack>chokidar>fsevents>node-pre-gyp>rc>minimist",
"dev": false,
"optional": true,
"bundled": true
},
{
"id": 1179,
"path": "laravel-mix>webpack-dev-server>chokidar>fsevents>node-pre-gyp>rc>minimist",
"dev": false,
"optional": true,
"bundled": true
}
]
}
],
"advisories": {
"1179": {
"findings": [
{
"version": "0.0.8",
"paths": [
"laravel-mix>babel-loader>mkdirp>minimist",
"laravel-mix>optimize-css-assets-webpack-plugin>cssnano>cssnano-preset-default>postcss-svgo>svgo>mkdirp>minimist",
"laravel-mix>terser-webpack-plugin>cacache>mkdirp>minimist",
"laravel-mix>webpack>terser-webpack-plugin>cacache>mkdirp>minimist",
"laravel-mix>terser-webpack-plugin>cacache>move-concurrently>copy-concurrently>mkdirp>minimist",
"laravel-mix>webpack>terser-webpack-plugin>cacache>move-concurrently>copy-concurrently>mkdirp>minimist",
"laravel-mix>terser-webpack-plugin>cacache>move-concurrently>mkdirp>minimist",
"laravel-mix>webpack>terser-webpack-plugin>cacache>move-concurrently>mkdirp>minimist",
"laravel-mix>webpack>mkdirp>minimist",
"laravel-mix>webpack-dev-server>portfinder>mkdirp>minimist",
"laravel-mix>webpack-dev-server>webpack-dev-middleware>mkdirp>minimist"
]
},
{
"version": "0.0.8",
"paths": [
"laravel-mix>chokidar>fsevents>node-pre-gyp>mkdirp>minimist",
"laravel-mix>webpack>watchpack>chokidar>fsevents>node-pre-gyp>mkdirp>minimist",
"laravel-mix>webpack-dev-server>chokidar>fsevents>node-pre-gyp>mkdirp>minimist",
"laravel-mix>chokidar>fsevents>node-pre-gyp>tar>mkdirp>minimist",
"laravel-mix>webpack>watchpack>chokidar>fsevents>node-pre-gyp>tar>mkdirp>minimist",
"laravel-mix>webpack-dev-server>chokidar>fsevents>node-pre-gyp>tar>mkdirp>minimist"
]
},
{
"version": "1.2.0",
"paths": [
"laravel-mix>chokidar>fsevents>node-pre-gyp>rc>minimist",
"laravel-mix>webpack>watchpack>chokidar>fsevents>node-pre-gyp>rc>minimist",
"laravel-mix>webpack-dev-server>chokidar>fsevents>node-pre-gyp>rc>minimist"
]
}
],
"id": 1179,
"created": "2019-09-23T15:01:43.049Z",
"updated": "2020-03-18T19:41:45.921Z",
"deleted": null,
"title": "Prototype Pollution",
"found_by": {
"link": "https://www.checkmarx.com/resources/blog/",
"name": "Checkmarx Research Team",
"email": ""
},
"reported_by": {
"link": "https://www.checkmarx.com/resources/blog/",
"name": "Checkmarx Research Team",
"email": ""
},
"module_name": "minimist",
"cves": [],
"vulnerable_versions": "<0.2.1 || >=1.0.0 <1.2.3",
"patched_versions": ">=0.2.1 <1.0.0 || >=1.2.3",
"overview": "Affected versions of minimist are vulnerable to prototype pollution. Arguments are not properly sanitized, allowing an attacker to modify the prototype of Object, causing the addition or modification of an existing property that will exist on all objects.  \nParsing the argument --__proto__.y=Polluted adds a y property with value Polluted to all objects. The argument --__proto__=Polluted raises and uncaught error and crashes the application.  \nThis is exploitable if attackers have control over the arguments being passed to minimist.\n",
"recommendation": "Upgrade to versions 0.2.1, 1.2.3 or later.",
"references": "- GitHub commit 1\n- GitHub commit 2",
"access": "public",
"severity": "low",
"cwe": "CWE-471",
"metadata": {
"module_type": "",
"exploitability": 1,
"affected_components": ""
},
"url": "https://npmjs.com/advisories/1179"
}
},
"muted": [],
"metadata": {
"vulnerabilities": {
"info": 0,
"low": 20,
"moderate": 0,
"high": 0,
"critical": 0
},
"dependencies": 15087,
"devDependencies": 0,
"optionalDependencies": 301,
"totalDependencies": 15388
},
"runId": "28917476-b8fd-4237-aa38-61bcc9164612"
}
found 20 low severity vulnerabilities in 15388 scanned packages
20 vulnerabilities require manual review. See the full report for details.

hunted by this issue


refactor(linter): replace the old parse_expect_jest_fn.rs file

Current dependencies on/for this PR:

main

PR #1267   👈

This stack of pull requests is managed by Graphite.


Experiment with immutablejs

Was able to successfully skip styles iteration with this, but creating immutablejs dependency list & style map turned out to have too much overhead.

May be worth exploring again if https://github.com/bloomberg/record-tuple-polyfill ever becomes standardized.


Saving a previously-unnamed Query loses the connection/database setting

Azure Data Studio Version: 1.9.0

Steps to Reproduce:

Create a new query, connect to a database.
Go to File:Save, enter a filename, and save the query.

Expected behavior:
Query continues to be connected to the same server and with the same database connection.
Actual behavior:
Query is immediately disconnected, requiring the user to connect the query to the desired server and database again.
This may be related to #4539, but I don't recognize the terms "Notebook," "Spark," and "cell" in the context of this tool (I'm only using it to run queries on Azure/MSSQL).

Thanks for the report! This is already being tracked with #5155 so I'm closing this as a duplicate.


Expose unminified JS files in the jspm config?

Hi there. I'm not sure about the decision to expose the JS files in components as minified files in JSPM.
"jspm": {
    "main": "prism",
    "registry": "jspm",
    "jspmPackage": true,
    "format": "global",
    "files": [
      "components/**/*.min.js",
      "plugins/**/*",
      "themes/*.css",
      "prism.js"
    ]
}

Considering that JSPM is often used alongside the SystemJS module bundler, which takes care of minification as well, this could cause issues like a difficult source to read. I know Bower adopts this approach of exposing an unminified code for the sake of giving developers the control they might need, and I'm pretty sure this approach can be applied here.
Happy to make a PR if there's an agreement. Thanks in advance!

@eriklieben, since you originally added special configuration for JSPM, do you have any opinion on this?

I must honestly say that I haven't been using JSPM/SystemJS in the last year or so and that knowledge faded away. It sounds like a good thing to do, so the dev using it is in charge of the way to do minification to the files.

@eriklieben Ok, thanks!


astroid: 0.7 -> 0.8

Motivation for this change
Upgraded astroid to 0.8 and uses the upstream changes to properly
propagate environment without a patch.  Note that this still uses an
unsupported version of webkitgtk and thus will fail to build, but if
allow webkitgtk to install, astroid will run.
Things done

[x] Tested using sandboxing
(nix.useSandbox on NixOS,
or option build-use-sandbox in nix.conf
on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] Linux

[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[x] Fits CONTRIBUTING.md.

@SuprDewd I finally got around to this ;)

Well, that's strange:
=== Reviewing PR 24593 : astroid: 0.7 -> 0.8
==> Creating nixpkgs repo in /home/travis/.nox/nixpkgs
==> We're in a git repo, trying to fetch it
==> Fetching base (master)
==> Fetching PR
==> Fetching extra history for merging
==> Merging PR into base
Removing pkgs/applications/networking/mailreaders/astroid/propagate-environment.patch
Nothing changed


That’s a link to a Google image search page, not a direct link to an image file.


Adding a Release Action in the build-release flow

Generate a release with notes using https://github.com/marvinpinto/action-automatic-releases.

Fixes: #338

Did we ever figure out what we are going to do with automatic_release_tag?

I'm taking this back to the drawing board and will put up a detailed issue & design.


Fix JSON parsing issue with trailing content.

Fix #19611

It's not related to this PR, just a side note: the email you currently use to author your commits is not linked to your GitHub accounnt, which is why your commits don't appear attributed to @pbrunet. It's fine, but if you want to fix that, you can add your git email as secondary email in your GitHub profile.

Thanks for the report, I added this email as secondary email.

See @reduz's comment on https://github.com/godotengine/godot/issues/19611#issuecomment-465570341

Could you squash the commits together?

Ok, It is done

Please check my approach on #19611, actual code is fine and your PR will most likely cause a crash if it runs short of the expression.

I think it is what I did here : https://github.com/godotengine/godot/pull/25977/files#diff-8af5ca245defe71d8cbfbaf99eead7aeR475
Did I missed something?

Is this still desired? This PR might be superseded by #37238

This PR has not received any new commits for over a year, and may be superseded, so closing.


bin/accumulo-util load_jars_hdfs does not set NUM_TSERVERS from cluster.yaml

Describe the bug
The load_jars_hdfs function in accumulo-util does not use the new cluster.yaml file, it uses the old tservers file.
Versions (OS, Maven, Java, and others, as appropriate):
To Reproduce
Expected behavior
load_jars_hdfs should parse the cluster.yaml configuration like accumulo-cluster does.
Screenshots
Additional context

load_jars_hdfs seems like a cluster-management function and should probably be moved to accumulo-cluster, or deleted entirely, as people can upload their own jars without our help; we don't necessarily need to be responsible for a basic file copy tool that isn't directly related to Accumulo's functionality. I believe this was primarily used with the VFS classloader, which was offloaded into a separate pluggable SPI


In a future release, we should compute ISO parameters

I think that many users would like to see ISO parameters, such as Rq, Ra, Wa, etc.
I think it would be useful to implement those (as defined by ISO 4287)

This needs to go into the backend. I've created a companion issue here: https://github.com/ComputationalMechanics/SurfaceTopography/issues/54

The problem is that those are not unique. There are different filter cutoffs, but I believe the standard defines a limited set of cutoffs.


Update joda-time to 2.12.4

About this PR
📦 Updates joda-time:joda-time from 2.12.2 to 2.12.4
📜 GitHub Release Notes - Version Diff
Usage
✅ Please merge!
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

⚙ Adjust future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "joda-time", artifactId = "joda-time" } ]

Or, add this to slow down future updates of this dependency:
dependencyOverrides = [{
  pullRequests = { frequency = "30 days" },
  dependency = { groupId = "joda-time", artifactId = "joda-time" }
}]

labels: library-update, early-semver-patch, semver-spec-patch, commit-count:1

Superseded by #628.


Invariant Violation: Element type is invalid: expected a string (for built-in components) or a class/function (for composite components) but got: undefined. You likely forgot to export your component from the file it's defined in.

I keep getting this when I run the react-native run-android on this template.
It outputs:
This error is located at:
in RTCView (at View.js:113)
in View (at AppCountainer.js:102)
in RTCView (at View.js:113)
in View (at AppContainer.js:126)
in AppContainer (at renderApplication.js:34)
I am really not sure what this is.

I solved it by following this: [https://github.com/react-native-material-design/react-native-material-design/issues/165]


Fix svg getClosestPoint()

Changes:

Add missing var in kute-svg.js getClosestPoint()

Since the svg plugin is written inside of a strict mode function, the global declaration of i is causing the following error when invoking getClosestPoint() in line 65:
ReferenceError: i is not defined
    at getClosestPoint (http://localhost:4200/vendor.bundle.js:75601:13)
    at Tween.computePathCross (http://localhost:4200/vendor.bundle.js:75692:18)
    at Tween.crossCheck.path (http://localhost:4200/vendor.bundle.js:75738:30)
    at Tween.start (http://localhost:4200/vendor.bundle.js:51842:66)

All other for loops in this file seem to be ok.
Thanks, great library!
Side note: the github editor automatically adds a trailing blank line, let me know if this is an issue and I'll create a different PR without it.

Thanks for the report, I will commit this change along with other of my other changes.

https://github.com/thednp/kute.js/releases/tag/1.6.1


Error running tests using Karma

Which version of PhantomJS are you using? Tip: run phantomjs --version.
2.1.1

What steps will reproduce the problem?

using it from karma via the karma-phantomjs-launcher

Which operating system are you using?
Windows

Did you use binary PhantomJS or did you compile it from source?
Binary

Please provide any additional information below.

This is an Angular 5 project.
This is the error I'm getting.  I have no idea what it means so I can't troubleshoot the issue.  Just need to know what this means so I know where to look to fix it.
PhantomJS 2.1.1 (Windows 8.0.0) ERROR
  {
    "message": "TypeError: pre,template,textarea,script,style is not iterable!\nat http://localhost:9876/_karma_webpack_/polyfills.bundle.js:792:83",
    "str": "TypeError: pre,template,textarea,script,style is not iterable!\nat http://localhost:9876/_karma_webpack_/polyfills.bundle.js:792:83"
  }

It looks like it is the problem in your polyfills.bundle.js file - not phantomjs related issue.
Maybe you should change import section in polyfills typescript files :)

Like @tray2002 wrote, the problem seems to lie somewhere else. Try to strictly target ES5 as PhantomJS doesn't support ES6 yet until #15342 is implemented. Thank you!

Just follow up, I switched to using ChromeHeadless as the browser.


Folder structure refactoring

❓ Questions and Help
@kne42 and I have been looking into moving forward with our refactoring - and one issue that is coming up is around separating out the "model", "view", and "controller" parts of our components. Right now we have a loose separation of "model" and "view" with our non-UI and UI peer classes, see discussion in #92 for some more info. The "view" parts live inside a folder called qt and the "model" parts live in the main folder. This is nice because it keeps all the qt stuff in one place, but it is less desirable as it splits up parts of the same component into different places, makes it harder to have component specific auxiliary files (where should they live?) and may make it more confusing to add new components (as files have to get added in multiple places). These comments apply to both our layer components (image / markers / shapes) and our main components (viewer, dimensions, control_bars).
Instead here is a proposal to reorganize our files by component instead. The folder structure would now look like the following
elements/viewer/viewer.py
elements/viewer/viewer_qt.py
elements/dimensions/dimensions.py
elements/dimensions/dimensions_qt.py
etc.
and
layers/base_layer/base_layer.py
layers/base_layer/base_layer_qt.py
layers/image_layer/image_layer.py
layers/image_layer/image_layer_qt.py
etc.
OR
another way to do it would be
elements/viewer/model.py
elements/viewer/view.py
elements/dimensions/model.py
elements/dimensions/view.py
etc.
and
layers/base_layer/model.py
layers/base_layer/view.py
layers/image_layer/model.py
layers/image_layer/view.py
etc.
(or some other similarly generic words - I can see pros/cons to either or those two approaches, but lean towards the later)
We would then use __init__.py to make all the importing nice and work as before.
What I like about this approach is that say for the shapes layer I have some crazy triangle calculating function that can live inside the shapes_layer folder but in a different file from all the model code (i.e. utils). If we want to add a separate controller.py class to use a real MVC like approach we can now do this too. It makes it particularly clear what to do to add new layer types - add a new folder that has all the necessary stuff in it. Also it seems like we might be moving towards allowing a layer to define multiple views - one for the layer properties boxes on the right, and one for the control_bars space on the left (see #107 for discussion). This would allow both those files to live in the same folder properties_view and controls_view for example. Whereas now they'd all live jumbled up in the "qt" folder.
This is a pretty major refactor so want to get some input before going ahead!

I don't have the time to think about this in depth at the moment but I think we really need to clarify the space that we want the model to live in. For example, the dimensions sliders depend on the image layers that are present, so should they be independent "models" and "views" in a different part of the layout?
I think this is somewhat related to our ability to display objects of different dimensionality in the same space, which I still find weird but @royerloic assures me makes sense. =P And no, I get it, you can have markers in some global, time-static space and have some time-varying thing happening relative to those. But I still think we need to come up with some global "model" concept that might help sort out the right hierarchy for our modules.

yeah, i think it's still a little unclear to me if we are making the right choice separating out the dimensions, and whether control bars will really be significant enough to be it's own thing if layers are defining what they want displayed there. I think though that the reorganization will help make things more clear - but would love for @AhmetCanSolak and @royerloic to weigh in too.

We have moved in this direction with PR #113 though as discussed in the PR the refactoring is still not complete


Remove restriction on vc version

Need a vc 9 build on Windows for compatibility with PySparse

Checklist

[x] Used a fork of the feedstock to propose changes
[x] Bumped the build number (if the version is unchanged)
[ ] Reset the build number to 0 (if the version changed)
[x] Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[x] Ensured the license file is being packaged.

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@conda-forge-admin, please rerender

@conda-forge-admin, please rerender

@conda-forge-admin, please rerender

@conda-forge-admin, please rerender

@conda-forge-admin, please rerender

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.
I do have some suggestions for making it better though...
For recipe:

License is not an SPDX identifier (or a custom LicenseRef) nor an SPDX license expression.

Documentation on acceptable licenses can be found here.

Not sure if this PR is still relevant, but it is ready for review @guyer @isuruf

@conda-forge-admin, please rerender


Capturing exposure events

Hello,
I am writing because you are the only repo on Github I could find that was actively maintaining a project that utilizes the Amscope API. I'm using the AMCAM_EVENT_EXPO_START and AMCAM_EVENT_EXPO_END events, respectively, but they are not triggered when using pull mode, at least not when the camera is in video mode. Have you tried to use these events or other events besides AMCAM_EVENT_IMAGE in your work?

Our project has only used AMCAM_EVENT_IMAGE so far so I’m sorry to say we can’t help you. If we learn anything new, we’ll make sure to send it your way.

It's not supported with our camera. Closing, but thank you for replying.


feat: [IAC-2624]: Add module registry to terraform provider

Title:
Add module registry to terraform provider
Summary:
Adding new resource to the terraform provider
Details:
We are adding module registry as part of IACM and one of the resources that customers can create now is module entry in the module registry. This change is to allow customers to use the provider to create those resoruces
Related Issues:
Reference any related issues or tickets
Testing Instructions:
Describe how the changes were tested. Include any test cases or steps to verify the functionality.
Please include the below test scenario with your changes.

Create the resource and execute terraform apply. (Verify the resource is created)
Execute terraform apply again without any changes. (Verify no changes should be done)
Update the resource and execute terraform apply. (Verify the resource updated successfully)
Remove the content from resource file and execute terraform apply. (Verify the resource has been deleted)
Add again the resource and execute the terraform apply. (Verify the resource is created)
Verify the import the resource file is working fine.
In case of remote entity, Verify for both default and non default branch.

Screenshots:
Include before and after screenshots to visually demonstrate the changes.
Checklist:

[x] Code changes are well-documented.
[x] Tests have been added/updated.
[x] Changes have been tested locally.
[x] Documentation has been updated.

PR Check triggers

Build: trigger build
Sub Category Field Check: trigger subcategoryfieldcheck
gitleaks: trigger gitleaks

@mteodor I do need a review in the golang-sdk before merging this, do you know who owns that project?

trigger build


Feature/ou free text question

Pull Request Check List

Unit Tests & Regression Tests Added (Optional)
[ ] Removed Unnecessary Logs/System.Outs/Comments/TODOs
[ ] Added enough Logging to monitor expected behaviour change
[ ] Security - Injection - everything run by an interpreter (SQL, OS...) is either validated or escaped
[ ] Security - Data Exposure - PII is not stored or sent unencrypted
[ ] Security - Access Control - Check authorisation on every new endpoint
[ ] Security - New dependency - configured sensibly not relying on defaults
[ ] Security - New dependency - Searched for any know vulnerabilities
[ ] Security - New dependency - Signed up team to mailing list
[ ] Security - New dependency - Added to dependency list
[ ] Updated Release Procedure & Documentation (& Considered Implications to Previous Versions)
[ ] Peer-Reviewed

I'd like to ensure that we only use one of the wildcard syntaxes, and automatically escape the other syntax under the hood. So I'd use just * and ., and escape & and # to allow them as ordinary characters. That's much more future proof and consistent.


Puppet 6 support

Coverage remained the same at 88.235% when pulling 955d86c5abaa354d99b553fb8b0caacc9672fcdd on raphink:puppet6 into 18fb1e232ffb9e1ab7a34cd00513da1c33fd7af2 on hercules-team:master.

Coverage remained the same at 88.235% when pulling 955d86c5abaa354d99b553fb8b0caacc9672fcdd on raphink:puppet6 into 18fb1e232ffb9e1ab7a34cd00513da1c33fd7af2 on hercules-team:master.


Possible to render in a Angular2 component?

Hello,
Is it possible to render the file manager in an Angular2 component. Assuming everything could install, can we just place it inside a Angular2 component html via:
<angular-filemanager></angular-filemanager>
Thanks!

+1 for ^^


v3.4.0 - release

@DABH @wbt I pushed a tag to v3.4.0
Planning to push this to NPM when I get a chance. Last thing after that is to promote the tag to a release.
Thoughts? Concerns?

Thanks for the note!
I did a release on winston-transport earlier today (incl. publishing to npm), landing some other long-awaited patch-level changes.  If I got anything wrong there, I hope someone corrects me soon, but it seemed to go pretty well.
Based on the diff, I was thinking it'd be a patch-level release but after you merged in Seq transport, bumping the feature version seems more appropriate.  I was hoping for a little additional clarity on #1952 and #1973 before doing a release, but those were my only remaining to-do items.
Don't forget to update package.json and package-lock.json before creating the release tag, so the tag has the versions with those numbers.  (You might need to go to 3.4.1 now for a distinction.)

Oh - and don't forget to update the changelog before the version tag too.

I removed the tag to do more planning. I changed the version to 3.4.x to draw a distinct line in the sand more than for semver reasons.

I agree with doing a 3.4 release.  I think enough has been merged already that a release is warranted.  We'll probably want to do at least one more release in the near future as we burn through the remaining PRs (or, e.g., if we update logform or winston-transport and need to get that newer version into winston).  Thanks for taking the lead on this!

You might want to look at dropping the diagnostics package.  It has not been updated in three years and has transient dependencies with vulnerabilities.
https://github.com/3rd-Eden/diagnostics/issues/24

Issue for tracking that last post is #1995

Folks, due to the compromised versions of colors, I went ahead and released Winston 3.3.4.  Sorry to jump the gun but I figured getting something out would cause is less headache than waiting to do a bigger release…

Wow, I'm not even sure if this is the same issue or not.   Just happened to come up in my news feed just now. (colors related)
https://www.theverge.com/2022/1/9/22874949/developer-corrupts-open-source-libraries-projects-affected

@DABH Thanks for the quick response.
At this point in the aftermath of that, what exactly was released? There is no release tag for 3.3.4 enabling an easy comparison.  Did you go back to the 3.3.3 release, update the dependency, and release that as 3.3.4 (similar to this suggestion) or was it just publishing master to npm (current diff here)?
If it's the latter case, we probably should be calling it 3.4.0 to better respect semantic versioning.
I see your appropriate warning in the changelog, but now that we've gotten past that we should discuss what really happened and get it right.

We should probably also add a 3.3.4 tag on just what was released, so we have that for reference.

@wbt Apologies the release tooling didn’t make a GH release.  Master at HEAD is 3.3.4 (“fix npm audit vulnerabilities”).  I’m happy to release a 3.4.0 (and create a GH release properly — will use np instead of vbump I think) with better release notes etc. But really the most help I need is figuring out why this test started failing even on older commits, I’m banging my head against a wall and don’t have enough time to keep investigating today.  I do have enough time to make a new release if we can stabilize the tests…

Oh if there’s not even a 3.3.4 tag I’ll fix that, the tooling definitely indicated a tag was made :/

OK, I retract my prior statement about semver - having looked through the diff to master, it looks like a patch-level release.  I was distracted into thinking it should be a feature-level release by the introduction of the Seq transport but that's actually just a documentation change referencing an externally maintained library, rather than an addition of functionality here.

Looking at the project history, I see the following timeline from yesterday, times in EST:
5:03 PM: issue fixed with merge of #2008, tests passing.
8:54 PM: 'v3.3.4' commit directly to master. This commit updates the changelog with a semver warning, updates the version number of Winston in package.json, drops two inactive maintainers from the list, and updates the minimum patch version of logform and winston-transport.  package-lock.json is updated. Tests start failing.
8:54 PM: The tag '3.3.4' is created, lacking a v at the start of the tag like others have.  No Github release is created from this tag.
9:13 PM: In another direct-to-master commit "fix all high-severity vulnerabilities from npm audit", the major version of mocha and the feature versions of three @babel packages as well as async are updated, though only the first should really make a difference because the others use a caret range.
9:35 PM assuming I did timezone conversion right: winston is published on npm.
Next day 11:51 AM: I merge #2012 with improved release notes.
Going on npm and clicking 'try with RunKit' to browse the files as currently published to npm, looking specifically at package.json, it looks like the 9:13 PM commit made it into the publish, but not the tag, so the tag lacking the v is misplaced by one commit.  I will remove that and add the v two commits after where it was, to include the updated release notes, and make a Github release from that.

Sounds good, thank you for helping sort this out.  There are always issues with getting things back running smoothly after such a long time with no releases, but hopefully we (I) will be able to avoid these issues with subsequent releases.

Note that it's not possible to overwrite the published package on NPM with the updated release notes. However, we're probably not too far from a 3.3.5.

Yeah.  I think due to #2006 we'll probably want the next release to be 3.4.0 just in case.  But anyway, we can do another release pretty soon, e.g. as soon as we figure out why tests are not stable.

I agree that a feature update number would be appropriate after the #2006 merge.

It looks like there's one more unhandled rejection listener than the test expects, and that's why it's failing.
Interestingly, the 3-year-old commit containing the failing test says near the top

// This is an awful and fragile hack that
// needs to be changed ASAP.
// https://github.com/mochajs/mocha/issues/1985

The referenced issue is twice that age.

Uh oh 🙃 If this is just an issue with mocha, maybe the right move is to do something like relax our test to loop over all unhandled rejection listeners and see if any of them has the desired properties?  Fixing mocha is probably more than what we signed up for :)

Released per comment by @DABH here.
If there's more to include, another release can be done, but I've been all day on this and need to return to other work.

Thanks again @wbt , hopefully this keeps Winston happy for quite some time :) Cheers!!


main.scss - not work

Styles from this file do not work. Most likely, it needs to be connected separately?

fix: add  to main.vue

You can also use putting the scss reference on main.js file like this:
import AppStyles from './assets/sass/main.scss'
Main.js example


New posts do not show correctly on the console

Hi, Dain. I've been trying TinyPress out these days. I ran across this problem as in the screenshot -- new posts in the draft mode. In fact, the posts exist, and can be viewed on a new browser tab. However, when I want to re-edit them from the console, both the title and the content are empty.
Since I take great interest in your TinyPress, I want to join you improving it. I'll fork your repo and try to contribute.

Dain, I've corrected the errors by hacking TinyPress: (1) git clone the repo, (2) edit the corresponding posts locally and commit them, and (3) git push. Done! Voila, the draft indications disappeared!
Also, I found out that the locally created posts will appear correctly on the console, too. Hence, creating posts locally and then pushing them to the repo is the way I like to use TinyPress.
By the way, I use the following HTML tag to embed images: , which supports the auto-resizing.


Tiberiturbureanu branch

added firstname lastname tasks

added Tiberiu TUrbureanu tasks

Hey Tibi! All looks good. Add me as reviewer.

Cristi and Alina, please check the changes you requested and let me know if you approve them. Thanks!


Feat/boilerplate

About
Created a Hathora/Demos/Boilerplate/ dir you can move to your own project for a place to minimally start from scratch using the SDK wrapper.
Start with the scene, or just grab the HathoraBoilerplate and toss it in your existing scene (ensuring an EventSystem already exists).
Snippets

Important
This is a branch based off https://github.com/hathora/hathora-unity/pull/22
Keep this a draft until that PR is merged and we merge main into here


Add 'silenced' query param to /alerts endpoint

This adds the silenced query parameter to the /alerts API endpoint.
@stuartnelson3 @w0rm In addition it changes the default in the UI. Previously silenced alerts were displayed by default. This PR hides silenced alerts by default. @fabxc and I thougth this would improve the UX as most users are probably looking for firing alerts. What do you think? Is the way I implemented it in AlertList/Parsing.elm ok?
Fixes #797

I'm cool with initially hiding silenced alerts

@stuartnelson3 @w0rm I have addressed your comments. Thanks for the input. I have reverted the changes on the boolParam parser and instead added it to the generateQueryString function.
In the long run, what do you think of the idea of having the filter not in the global modal but in the model of each view. E.g. the SilenceView does not need the showSilenced parameter in it's filter object. Sorry if I brought this up before.

Also, if the alerts are filtered on the backend, should we remove the filtering on the frontend? cc @stuartnelson3

Good point -- that filtering code still exists. Let's get rid of that.

@stuartnelson3 @w0rm Removed the browser side filtering code.


Displays element and vertex numberings, but not dof numberings

It should probably display dof numberings as well.  Maybe something like this for Q2. :)

I agree this could be useful :).
It could also be nice to be able to display the DOF numbering for the GridFunction that is being visualized.

Yes, I'm grabbing the DOFs from the GridFunction.  Here's an L2 GridFunction.  Still some work to complete this.  I'll push a branch.

ping: @rw-anderson

@rw-anderson, do you want to add this as part of the upcoming glvis-4.1 or should we postpone it to the next release?

Just wanted to say this would be extremely helpful for debugging feature additions in mfem. Even more useful if it would be able to handle NC dofs.


feat: add preferences for jill drops

Not certain that maps cap at 3 drops, but that's the highest currently reported. It might be unlimited.
Preference for LED candle setting / command / modifiers to come later.

Not certain that maps cap at 3 drops, but that's the highest currently reported. It might be unlimited.

I know nothing about the item and am just looking at the code but I don't understand why we count map drops per day but maps used is a boolean.  Is the information I am missing is that only one map can be used per day?

Is the information I am missing is that only one map can be used per day?

Yes.


deps: x/tools and gopls ff9f1409240a

internal/lsp/source: fix renaming of SuggestedFixes in experimental file ff9f1409
internal/lsp: process configuration per workspace folder fc6e2057
internal/lsp: compare mod file versions used in imports db2fa46e
internal/lsp: format files in packages with errors 1bd56024
internal/import: strings.Trim expects a cutset, not a string 2e34cfcb
gopls: update x/tools vesion in mod file 8aa4eac1
internal/lsp: swallow hover error over identifier not found 4e8ec5a3
internal/lsp: fix lockup for packages with many files 8bb11ff1
internal/lsp: add an ocagent exporter for the telemetry system e377ae9d
internal/imports: disable go/packages-incompatible tests 72478f39
internal/lsp: the json wire format of the open cencus agent 87e92536
internal/lsp: have tests report a different application name to the main gopls binary 625c92e4
internal/lsp: new tracing system 38daa656
internal/imports: save scanned module cache results 82a3ea8a
go/packages, internal/lsp: modify tests to expose overlays bug c81b7487
internal/lsp: purge the remains of the xlog system now it is not used 7caf8110
internal/lsp: convert logging calls 73497f05
internal/lsp: add a new telemetry based logging system 7ec096a1
internal/lsp: use a background context for the background worker f2838559
internal/lsp: fixed broken tracing 128ec6df

Currently blocked on https://github.com/golang/go/issues/33347

This will be superseded by #444


use SqlSession instead of SqlSessions

@harawata Thanks for your suggestion, I have applied it.

Thank you, @donhui !


Text on lines beneath choice

User story
As a user I would like to be able to add choice option text such as "Yes" and "No" without having to write this text on the choice card itself.
Describe the solution you'd like
Reactflow has the option to add text to lines. We can solve this issue by making it possible for users to add text to lines that are beneath choices.
Describe alternatives you've considered
We could alternatively have a new type of card that contains only text. Users could then add this card beneath choices.
Additional context
Fix to user request: same info, different look. Can user steer line shifts to control how text looks on card? (see process 2147)
Development checklist

[ ] Threat Modeling

Duplicate of #185


How to create a request of Extends Query Type

Thanks for your efforts on the amazing lib.
I have a problem on how to use it, Please have a look.
Below graphql schema exported by command get-graphql-schema [ENDPOINT_URL] > schema.graphql
type Account {
  userProfile(token: String!): AuthenticationResult
}

"""Create APIs that do not involve updating data by extends Query."""
type Query {
  account: Account
}

Then I create a request like this
query Account($token:String!){
    account{
        userProfile(token:$token){
            userId
        }
    }
}

after run commond "flutter pub run build_runner build --delete-conflicting-outputs"
I got errors like this
[SEVERE] ferry_generator:graphql_builder on lib/src/graphql/account_query.graphql:

Bad state: No element
dart:collection                                          ListBase.firstWhere
package:gql_code_builder/src/operation/data.dart 457:8   _getFieldTypeNode
package:gql_code_builder/src/operation/data.dart 153:24  buildSelectionSetDataClasses.<fn>
dart:core                                                Iterable.toList
package:gql_code_builder/src/operation/data.dart 169:5   buildSelectionSetDataClasses
package:gql_code_builder/src/operation/data.dart 235:22  buildSelectionSetDataClasses.<fn>
dart:core                                                List.addAll
package:gql_code_builder/src/operation/data.dart 234:10  buildSelectionSetDataClasses
package:gql_code_builder/src/operation/data.dart 235:22  buildSelectionSetDataClasses.<fn>
dart:core                                                List.addAll
package:gql_code_builder/src/operation/data.dart 234:10  buildSelectionSetDataClasses
package:gql_code_builder/src/operation/data.dart 24:10   buildOperationDataClasses
package:gql_code_builder/data.dart 36:17                 buildDataLibrary.<fn>
dart:core                                                Iterable.toList
package:gql_code_builder/data.dart 46:8                  buildDataLibrary
package:ferry_generator/graphql_builder.dart 104:22      GraphqlBuilder.build

Could you please help me to create a right request ?
Thanks

your schema seems not to contain a type for AuthenticationResult

your schema seems not to contain a type for AuthenticationResult

Thank for your reply, the type AuthenticationResult was contained in the schema.graphql file, I am sorry to missed it in the issue description.
type AuthenticationResult{
    token: String
    model: String!
    remainingMileagePercentage: Int!
    remainingMileage: Int!
    carImageUrl: String!
    status: CarStatus!
}

enum CarStatus {
  AVAILABLE
  UNAVAILABLE
}

I think all related schemas have been displayed, please check again, thank you.


Autosifter in WAILA shows negative values?

That is intended; it can rotate either direction.

Closing as this is intended.


Introduce a variable for PIMT extra arguments

Remove redundant --latest false argument to PIMT
Introduce a variable for PIMT extra arguments
Version 0.1.33

FWIW, the motivation of this change is to allow us to pass --latest-specified to PIMT when generating the plugins.yaml file with our Python script. Otherwise, we end up with broken dependencies.


fix samples broken by file exists check

The commit:
https://github.com/Microsoft/BotBuilder-Samples/commit/351c4747a32b2e40c1fe2db6c73203720dea3e2b
Appears to have broken the following samples. This PR fixes them.

03.welcome-user
04.simple-prompt
05.multi-turn-prompt
06.using-cards
19.custom-dialogs

Adding a couple of other reviews if @cleemullins doesn't see this this evening


[ISSUE #1464] Fix the issue that master node route info was lost when the node joined the group in dledger mode

What is the purpose of the change
Fix #1464
Brief changelog
Set brokerId defaults to -1 in dledger mode and do not register wtih nameserver until brokerId is changed.
Verifying this change
Follow this checklist to help us incorporate your contribution quickly and easily. Notice, it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.

[x] Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
[x] Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
[x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
[x] Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
[x] Run mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test  to make sure integration-test pass.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

Coverage increased (+0.1%) to 49.627% when pulling 21511da384dea69b734ca1d5a3bd5c84267ecea2 on RongtongJin:apache_develop into 61f4f99b884d6b1d716414b14ed2e494d201bebe on apache:develop.


feat(littlefs): bump to v2.9.3

Please consider accepting this patch, as current included littlefs version is a bit old.
I'm testing this change on Renesas RA with internal data flash, and so far it seems working.
There is a matching pull request in littlefs2 crate:
https://github.com/trussed-dev/littlefs2/pull/59

Hi,
Thank you for your PR.
I think we will replace it by #19, which exposes the new multiversion feature, and also fixes some bindings generations issues on my end.


'

'

'

I apologize about what I wrote on your page. I wasn't really meaning to
screw your page. So could you delete what I wrote? I can't find the delete
button. Sorry again.
2023년 3월 15일 (수) 오전 12:02, Etherealxx @.***>님이 작성:

Closed #278
https://github.com/camenduru/stable-diffusion-webui-colab/pull/278.
—
Reply to this email directly, view it on GitHub
https://github.com/camenduru/stable-diffusion-webui-colab/pull/278#event-8744810747,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/A6PPHE7HBMYGLDV7CU6TM33W4CCBVANCNFSM6AAAAAAV2OOAUM
.
You are receiving this because you authored the thread.Message ID:
<camenduru/stable-diffusion-webui-colab/pull/278/issue_event/8744810747@
github.com>

I apologize about what I wrote on your page. I wasn't really meaning to
screw your page. So could you delete what I wrote? I can't find the delete
button. Sorry again.

don't worry, i was just like you when at my first time learning how to use github.😁
Though, you can join the discord server of this repo, in case you need help or something else to ask. https://discord.gg/k5BwmmvJJU

I really appreciate! Thanks for replying my message so kindly :)
2023년 3월 15일 (수) 오전 1:17, Etherealxx @.***>님이 작성:

I apologize about what I wrote on your page. I wasn't really meaning to
screw your page. So could you delete what I wrote? I can't find the delete
button. Sorry again.
don't worry, i was just like you when at my first time learning how to use
github.😁
Though, you can join the discord server of this repo, in case you need
help or something else to ask. https://discord.gg/k5BwmmvJJU
—
Reply to this email directly, view it on GitHub
https://github.com/camenduru/stable-diffusion-webui-colab/pull/278#issuecomment-1468409039,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/A6PPHE72J237JRKW3OXIQG3W4CKZZANCNFSM6AAAAAAV2OOAUM
.
You are receiving this because you commented.Message ID:
@.***>


open source license

I would like to suggest adding an open source license (MIT or BSD3, or something in the GPL family) before we open this up to contributions from others (and myself!) Here are a list of options --> https://opensource.org/licenses. If you let me know which is your preference, I'd be glad to add in a PR.

Let's do the MIT license.  Thanks again for helping with all this!

okay done!
yeah I'm working on it this morning! Having fun so far :)


Text align/justify mismatch between online and notion-app-enhanced

Hello all,
I do not know if this intended behaviour or a bug. If it is intended behaviour please point me to where it needs to be fixed/change in the settings to get the same behaviour as the notion website.
A few things I've tried:

Install, reinstalled and used the details in #116 to get the app to run.
I've installed via a) sudo apt install, b) using the portable .zip and using the .deb. All produce the same behaviour over multiple reinstalls.
Tried replacing all possible "justify" and/or "center align" items with "left" and/or "left align" text pieces in the code and rebuilding but that does not work.
Tried adding a CSS snippet to left align items, that did not work (I could be doing this wrong as I'm unfamiliar with it but I followed this https://github.com/notion-enhancer/notion-enhancer/issues/75.
Tried multiple themes, all have the same behaviour (so my conclusion its notion-app-enhanced default behaviour).
What helped "somewhat" was logging out completely and then logging back in to notion in notion-app-enhanced. The app would display the notes the same way as online immediately after a log in. However, this only persists until I restart the notion-app-enhanced and then the text is center justified again. See the last few pictures in the screenshots section.

Any help would be appreciated.
What is happening?
Text in the center or side peek mode is center justifying text. This looks particularly bad when the app is snapped to the sides.
What should be happening?
I expect notion-enhancer to reproduce the same output I am seeing on the notion website.  That is the text should not be center aligned / justified and should be left aligned and not justified.
Screenshots (if applicable):
Center peek (left is https://notion.so and right is notion-app-enhanced):

Side peek (notion-app-enhanced):

From notes:

Immediately after logging in again to notion (notion-app-enhanced):

After restarting the app after logging in again (notion-app-enhanced):

Operating system/browser name & version:

Ubuntu 23.10
Firefox 124.0 (64-bit)

notion-enhancer and/or notion-repackaged version:

notion-enhancer v0.11.0-dev
notion-app-enhanced-2.0.18-1
Notion <IP_ADDRESS>.0.151

notion-enhancer configuration (enabled/disabled mods and their settings):

All mods disabled.

Thanks for the detailed report, you can use this CSS snippet to fix this until I can finish the next release (paste it into text file ending in .css and upload it via the tweaks mod):
.notion-page-content {
    --theme--page_preview-padding: 0;
}

Thank you @dragonwocky - that worked perfectly!


Adjusted the colors in range and timerange facet to have more contrast

Fixes #3319
Adjusted the numeric and timeline facet histogram bin colors to improve the contrast so that it is 3 to 1 between the three colors: background (white), bin color 1, and bin color 2.
Previously, timeline facet was using a separate color palette. This change makes numeric and timeline use the same colors. See the pictures below to see the difference.
Before and After:

Contrast:

LGTM
Do the "change" and "reset" labels now meet the accessibility guidelines? My comment from a couple of years ago indicated that they didn't at the time.


Change flexShrink type to float to match flexGrow type; fixes #109

An earlier PR (#106 ) was merged that changed flexGrow type from int to float. This commit matches that change for flexShrink.
This fixes issue #109 .

Thank you. covered by PR #127