test(e2e): use env for FQDN in Cira config

Codecov Report

Merging #232 (fd63069) into master (b54f8f9) will not change coverage.
The diff coverage is n/a.

:exclamation: Current head fd63069 differs from pull request most recent head 6e1f18f. Consider uploading reports for the commit 6e1f18f to get more accurate results

@@           Coverage Diff           @@
##           master     #232   +/-   ##
=======================================
  Coverage   50.06%   50.06%
=======================================
  Files          33       33
  Lines         825      825
  Branches       86       86
=======================================
  Hits          413      413
  Misses        379      379
  Partials       33       33

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b54f8f9...6e1f18f. Read the comment docs.


Fix -bamout HaplotypeCaller argument

The HaplotypeBamWriter was being created in the wrong place,
causing the bam produced by -bamout to be truncated.
Fixed this and added an integration test for the -bamout
argument.
Resolves #465

@akiezun please review

results are different by a few hundred reads compared to 3.4. Is that expected ?

👍 if the differences are expected

It's more like a hundred or so reads, and yes, it's expected that the haplotypes are slightly different between GATK 3 and 4, since the variant calls are slightly different. It's irrelevant anyway to this test, which is testing whether the -bamout option is functional, not whether we discover the same haplotypes as GATK 3.


Upgrading from v0.1.1 to v1.0.0 brings some breaking change(s) with tg markdown syntax parsing

I used to include telegram-action into my Github workflows in that manner:
uses: appleboy/telegram-action@master

Some weeks ago I noticed that my Github actions workflows stopped to send notifications to telegram.
While investigating, I found that telegram-action was updated some time ago.
By replacing uses: appleboy/telegram-action@master with uses<EMAIL_ADDRESS>and uses<EMAIL_ADDRESS>I discovered, that my workflow works fine on v0.1.1 and don't work with v1.0.0.

Has anything changed in the way telegram-action parses tg markdown syntax in messages after upgrading from v0.1.1 to v1.0.0?

could be explicitly fixed by replacing all _ symbols with \_, like this:
    - name: Send telegram notification v1.0.0
      id: notify_tg_v100
      if: ${{always()}}
      uses<EMAIL_ADDRESS>      with:
        to: ${{secrets.TELEGRAM_DEBUG_CHAT}}
        token: ${{secrets.TELEGRAM_DEBUG_TOKEN}}
        disable_web_page_preview: true
        format: markdown
        message: |
          some text with @tg\_link

However, the issue of the behavior unexpectedly changing when upgrading from v0.1.1 to v1.0.0, remains relevant.


Method zif_abapgit_object~serialize - components udate and utime not available

Hi all,
While trying to activate the current release in our ECC6 EHP8 system I got 4 syntax errors (see screenshot below).

There are no components "udate" and "utime" in the objects "<ls_objects>" and "<ls_objects_text>".
"ls_objects" is referencing database table "TCDOBS".
"ls_objects_text" is referencing database table "TDCOBTS".
Both database tables do not have columns called "udate" or "utime".
There are no date or time columns in those tables at all.
What are "udate" and "utime" supposed to be used for?
Should they reference the columns "datum" and "uzeit" of database table "TCDRPS" maybe?
Is there an older build available which doesn't have that issue?
Please assist.
Best regards
Dominik

Interesting. No problem here with ECC6 EHP7 (NW 740 SP16). UTIME and UDATE are there.

I suggest that we clear the fields dynamically.

Strange.
I checked two IDES systems (ECC6 EHP4 / NW 7.01 and S/4HANA 1610 / NW 7.51) which we have here and those fields are in neither one available.
Wondering when they got added and removed again.

Very strange, I have those fields in ECC6 EHP8 and in NW 7.52

If I see it right, the tcds tables are shadow tables and could be from other releases (depending on previous upgrades). Function 'CDNAMES_GET' returns tcdrp, tcdob, tcdobt (without S). ty_change_document is therefore incorrect as well as the insert and delete statements into the tables with tcds.
tcdrps > tcdrp
tcdobs > tcdob
tcdobts > tcdobts
Then you can adjust the cleared fields accordingly ie remove the udate, utime loops.

@mbtools yes, they're shadow tables used by the transport system and function AFTER_IMP_CHDO to generate all depending objects

I investigated the difference.
It looks like SNOTE #2324651 "CD: Enhancement of program RSSCD_CHECK_GEN" (or SAP_BASIS 750 support package SAPK-75006INSAPBASIS) are adding fields "udate" and "utime" to the shadow tables "tcdobs" and "tcdobts".


Publish build artifacts as assets on release page

Publish artifacts as release assets when we do a release.
Why
We want to use these for pinning, in order to enable multi-platform workflows. See https://github.com/OpenAssetIO/OpenAssetIO/issues/1181#issuecomment-1810176081 as to why this is higher prio now.
ACs

Every tag (ie release) publishes the build artifacts to the release artifacts page, with separate artifacts for:

./build/dist

The "release" trigger is used to ensure they can be published to a release page which bypasses retention (unless there is also a way to do this for tags)
Publish ./build/dist variants for debug, rel, rel with debug etc...
Assets are named with build, platform and relevant platform and project versions.

We didn't appear to have a task in the epic to actually use these release builds in downstream projects, so I've added https://github.com/OpenAssetIO/OpenAssetIO/issues/1235


[gold] New goldens compared to the wrong browser

There are several cases of Skia Gold comparing a new golden from browser X to a previous golden of browser Y. Here's one example (Safari vs Chrome): https://flutter-engine-gold.skia.org/detail?grouping=name%3Ddraw_3d_rect_clipped%26source_type%3Dflutter-engine&digest=006f1f8307e05e7ee14d8b08d4ac13cc
Is there a way to disable this? We would like for Safari goldens to only be compared with the previous Safari goldens, not the Chrome ones.
As part of the investigation, we tried to see what happens if Skia Gold was forced to compare that Safari golden with the previous Safari one: https://flutter-engine-gold.skia.org/diff?grouping=name%3Ddraw_3d_rect_clipped%26source_type%3Dflutter-engine&left=006f1f8307e05e7ee14d8b08d4ac13cc&right=40433d185cd2f5d3c5838e7ffffffdc6
Why does Gold think there's a 97.51% diff? Manually inspecting the pixels (by clicking the "zoom" button), we found that the majority of the image is made up of a gray background. Those gray pixels are identical in both images (pixel diff is rgba(0, 0, 0, 0)).

@kjlubick do you have ideas on what might be going on?

Huge +1. I'm wondering if I need to give it a different unique name? That would be unfortunate.

Also /cc @Piinks if we're just holding it wrong

My guess is there is something going on with colorspaces. The diff metrics you see in the interactive tool are computed by the browser, but the diff image itself (as well as the metrics presented) are calculated with golang.
If you want to force images into separate buckets based on the browser, then the browser name must be part of the test.

@kjlubick here's what's puzzling me: why did Gold decide to compare Safari vs Chrome instead of Safari vs Safari? Safari vs Chrome were different enough that it failed our fuzzy matching. But it would've succeeded the fuzzy matching if it had picked Safari vs Safari.
This may have to do with the algorithm used to determine the Closest Positive, right? Based on some metric, it may have decided that the Chrome variant was the Closest Positive. It would be great to get a better understanding of how this works, and whether we (as users of the API) have any control over it.

That is quite puzzling. Fuzzy matching should only compare to the latest positive image for a given trace, so I would have expected it to do Safari vs Safari at the fuzzy step.

It is my understanding that Gold's comparison works in 2 steps:

Find the Closest Positive (regardless of the chosen comparison algorithm).
Use the chosen algorithm/parameters (e.g. fuzzy) to compare the new image against Closest Positive.

I think the issue discussed here lies in step 1. @kjlubick would you mind sharing some insights on how Gold picks the Closest Positive? Specifically, I'm interested in the following:

Does it only look at the last N images?
Does it look at the number of different pixels?
Does it look at the RGB diff between the images?
Does it prioritize images with a similar trace?
If it uses multiple of the above, how does it combine them and come up with a result?

Having a better understanding of how this works will help us identify the mismatch in expectation and may help us make changes to minimize the occurrence of such mismatch.

Fuzzy matching picks the most recent, positively triaged image produced for that trace, that is for the same test, os, browser, whatever keys are set.
This is different than when the web UI shows the closest positive digest, which searches across all images for that grouping (corpus + test) and finds the image with the smallest "diff metric" which tries to incorporate number of pixels and magnitude of difference.


Allow to move between Slices using mouse wheel

Fixes #180
Proposed Changes

Users are now able to move between Slices using mouse wheel.

Manually tested and it works great! ❤
Just a thought to consider - maybe it would be a good idea to throttle scrolling events to slow it down in case of "fast" scrolling? A little debounce would be fine I think. Here I found some examples:
https://www.sitepoint.com/throttle-scroll-events/

@jpowie01 I have mixed feelings about the debounce thing - created a separate branch where it's implemented - https://github.com/jpowie01/MedTagger/tree/use_scrollwheel_to_change_slices_debouce - IMO it just doesn't feel good. Give it a try and let me know what you think ;)

Yeah... You're right. Let's leave it as is :)


Wildcard * filter doesnt work

Doing a SETFILTER like the this doesnt work:
Item.SETFILTER(Description, '*%1*', 'door');
The filter set to the field Description is literally "*%1*"

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 3c6bafa7-ca3f-87f1-872c-c74cf6ef8294
Version Independent ID: 066b6f8b-6444-3f1f-6e31-ecd8047cc8aa
Content: SETFILTER Function (Record) - Dynamics NAV
Content Source: dynamics-nav/SETFILTER-Function--Record-.md
Product: dynamics-nav-2018
GitHub Login: @jswymer

Item.SETFILTER(Description, '%1', 'door');

Could you explain you answer a little bit?

Item.SETFILTER(Description, '%1', '' + door + '');

Ah, thanks - I will try that

Hello, sorry for the long wait. I think you've come across an error in the product and I suggest that you file a bug for this. Thanks for catching this.

@SusanneWindfeldPedersen - how about you filing a bug report... would be faster.


Weird concurrency issue with oauth2 authentication

I've been hunting this thing for a month now, i'm trying to build my custom web application with both identityServer and identityManager. I've started from the sample in the identitymanager repository.
The issue is that i can't login in identity manager using oauth2, but if i open F12 chrome dev tools and i put a breakpoint in line 1403 "if (idmTokenManager.access_token) {" then the issue disappears (follow the link below for the video ), this makes me point to some concurrency issue in angular. To prove that i've commented the line 1410 and the issue disappears even without breakpoints. Looks like the first failing request is handled too late, removing the access_token.
I'm sorry i can't diagnose it further but i can't really stand angular, i wish this was done in classical server side html, i see no value in making it client side dynamic, but i guess it's easier to embed it in a package. Btw thanks for the great work !
https://onedrive.live.com/redir?resid=71E9B251FD64E3AB!43788

Can you share OAuth2Configuration in idSrv

I have similiar problems after enabling oauth in idm. I can log in, menu is shown. But later when I try to access anything from menu I get 401.

Yep, I finally found this -- dup of #104


Why does the model predict bbox offset twice?

The model predicts bbox offsets twice,
in DAB-DETR/blob/main/models/DAB_DETR/transformer.py, Line 255-265,
in DAB-DETR/blob/main/models/DAB_DETR/DABDETR.py, Line 171-184.
The difference is that the input of the second predict is normed.
The second predict seems unnecessary.
Am I right?

Our implementations work better than predicting bbox offset once only in our experiments.

Thank you for your quick reply! Could you kindly provide the detailed performance? I'm interested in it since an intuition is that normalized input would work better.

Both updates work in unnormalized space. The main difference is the detach() operation, which may affect the performance.

Got. Thanks!


 I added the logic to create widgets, layers and elements (this two last items will be available in the future)

Ping?

Now that the add-button is added to the tab-pane context, shouldn't the add-button in the widgets listing be removed? AFAIK that was just a temporary thing until this was to be done.

You are right, @viddo, I'll get rid of those buttons.

BTW, I've realized that button should appear only when there is any element already added to the current context, right @piensaenpixel?

Yes @xavijam

What I was referring to was the temporary add-widget-button, not only the layer one

@viddo: I'm afraid that method is called from the other button

LGTM :ship: :it: after reviewing my last comment about .length :palm_tree:

Merging this since the frontend builds are :green_apple:

:+1:


server: also update parent on create term

An idea for fixing #560

This won't resolve the issue since the parent's cache is still not set. This changes only the behavior of the legacy system itself (that worked correctly so far to my understanding).


feat: ingress annotations support enable websocket

Type of change:

[ ] Bugfix
[x] New feature provided
[ ] Improve performance
[ ] Backport patches

What this PR does / why we need it:

In our daily usage scenarios, we expect to be able to directly open websocket support for routing on ingress
Pre-submission checklist:

[x] Did you explain what problem does this PR solve? Or what new features have been added?
[x] Have you added corresponding test cases?
[x] Have you modified the corresponding document?
[x] Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first

Codecov Report

Merging #1101 (fd975fd) into master (5756273) will increase coverage by 0.04%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #1101      +/-   ##
==========================================
+ Coverage   32.08%   32.13%   +0.04%
==========================================
  Files          78       78
  Lines        8795     8801       +6
==========================================
+ Hits         2822     2828       +6
  Misses       5666     5666
  Partials      307      307

Impacted Files
Coverage Δ

pkg/kube/translation/ingress.go
78.24% <100.00%> (+0.43%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0f95dbe...fd975fd. Read the comment docs.

Thanks,
you should add e2e test cases for this one. you can ref to https://github.com/apache/apisix-ingress-controller/blob/master/test/e2e/suite-features/websocket.go and add test cases to https://github.com/apache/apisix-ingress-controller/tree/master/test/e2e/suite-annotations directory

ok, i'll take a look

ci failed

Let me take a look

Please help, I have no problem running make unit-test locally
go version go1.18.3 linux/amd64
Linux seven <IP_ADDRESS>-microsoft-standard-WSL2+ #1 SMP Mon Jun 13 04:56:19 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
make unit-test
go test -cover -coverprofile=coverage.txt ./...
?       github.com/apache/apisix-ingress-controller     [no test files]
?       github.com/apache/apisix-ingress-controller/cmd [no test files]
ok      github.com/apache/apisix-ingress-controller/cmd/ingress 10.027s coverage: 80.0% of statements
ok      github.com/apache/apisix-ingress-controller/pkg/api     0.037s  coverage: 85.7% of statements
ok      github.com/apache/apisix-ingress-controller/pkg/api/router      0.045s  coverage: 81.8% of statements
ok      github.com/apache/apisix-ingress-controller/pkg/api/validation  0.050s  coverage: 19.3% of statements
ok      github.com/apache/apisix-ingress-controller/pkg/apisix  0.366s  coverage: 49.3% of statements
ok      github.com/apache/apisix-ingress-controller/pkg/apisix/cache    0.010s  coverage: 83.8% of statements
ok      github.com/apache/apisix-ingress-controller/pkg/config  0.013s  coverage: 64.7% of statements
ok      github.com/apache/apisix-ingress-controller/pkg/id      0.014s  coverage: 100.0% of statements
ok      github.com/apache/apisix-ingress-controller/pkg/ingress 0.031s  coverage: 2.1% of statements
?       github.com/apache/apisix-ingress-controller/pkg/ingress/gateway [no test files]
ok      github.com/apache/apisix-ingress-controller/pkg/ingress/gateway/translation     0.226s  coverage: 77.3% of statements
?       github.com/apache/apisix-ingress-controller/pkg/ingress/namespace       [no test files]
ok      github.com/apache/apisix-ingress-controller/pkg/ingress/utils   0.052s  coverage: 37.9% of statements
?       github.com/apache/apisix-ingress-controller/pkg/kube    [no test files]
?       github.com/apache/apisix-ingress-controller/pkg/kube/apisix/apis/config/v1      [no test files]
?       github.com/apache/apisix-ingress-controller/pkg/kube/apisix/apis/config/v2      [no test files]
?       github.com/apache/apisix-ingress-controller/pkg/kube/apisix/apis/config/v2beta2 [no test files]
?       github.com/apache/apisix-ingress-controller/pkg/kube/apisix/apis/config/v2beta3 [no test files]
?       github.com/apache/apisix-ingress-controller/pkg/kube/apisix/client/clientset/versioned  [no test files]
?       github.com/apache/apisix-ingress-controller/pkg/kube/apisix/client/clientset/versioned/fake     [no test files]
?       github.com/apache/apisix-ingress-controller/pkg/kube/apisix/client/clientset/versioned/scheme   [no test files]
?       github.com/apache/apisix-ingress-controller/pkg/kube/apisix/client/clientset/versioned/typed/config/v2  [no test files]
?       github.com/apache/apisix-ingress-controller/pkg/kube/apisix/client/clientset/versioned/typed/config/v2/fake     [no test files]
?       github.com/apache/apisix-ingress-controller/pkg/kube/apisix/client/clientset/versioned/typed/config/v2beta2     [no test files]
?       github.com/apache/apisix-ingress-controller/pkg/kube/apisix/client/clientset/versioned/typed/config/v2beta2/fake        [no test files]
?       github.com/apache/apisix-ingress-controller/pkg/kube/apisix/client/clientset/versioned/typed/config/v2beta3     [no test files]
?       github.com/apache/apisix-ingress-controller/pkg/kube/apisix/client/clientset/versioned/typed/config/v2beta3/fake        [no test files]
?       github.com/apache/apisix-ingress-controller/pkg/kube/apisix/client/informers/externalversions   [no test files]
?       github.com/apache/apisix-ingress-controller/pkg/kube/apisix/client/informers/externalversions/config    [no test files]
?       github.com/apache/apisix-ingress-controller/pkg/kube/apisix/client/informers/externalversions/config/v2 [no test files]
?       github.com/apache/apisix-ingress-controller/pkg/kube/apisix/client/informers/externalversions/config/v2beta2    [no test files]
?       github.com/apache/apisix-ingress-controller/pkg/kube/apisix/client/informers/externalversions/config/v2beta3    [no test files]
?       github.com/apache/apisix-ingress-controller/pkg/kube/apisix/client/informers/externalversions/internalinterfaces        [no test files]
?       github.com/apache/apisix-ingress-controller/pkg/kube/apisix/client/listers/config/v2    [no test files]
?       github.com/apache/apisix-ingress-controller/pkg/kube/apisix/client/listers/config/v2beta2       [no test files]
?       github.com/apache/apisix-ingress-controller/pkg/kube/apisix/client/listers/config/v2beta3       [no test files]
?       github.com/apache/apisix-ingress-controller/pkg/kube/apisix/const       [no test files]
ok      github.com/apache/apisix-ingress-controller/pkg/kube/translation        1.951s  coverage: 49.7% of statements
ok      github.com/apache/apisix-ingress-controller/pkg/kube/translation/annotations    0.009s  coverage: 38.8% of statements
ok      github.com/apache/apisix-ingress-controller/pkg/log     0.021s  coverage: 88.5% of statements
ok      github.com/apache/apisix-ingress-controller/pkg/metrics 0.028s  coverage: 59.5% of statements
ok      github.com/apache/apisix-ingress-controller/pkg/types   0.008s  coverage: 87.0% of statements
?       github.com/apache/apisix-ingress-controller/pkg/types/apisix/v1 [no test files]
ok      github.com/apache/apisix-ingress-controller/pkg/version 0.003s  coverage: 100.0% of statements

You can try to merge the latest code

Thanks.
It's on my list. I will finish review today.


Makepbcore audio bit depth

The video bit depth is showing up instead of audio. I think audio needs an overhaul in general.

Turns out the audio codec was being misrepresented as well. All should be fixed now.


YML file referenced is incorrect

The YML file referenced in this section does not line up with previous sections. Previous section names the file differently.
release-solution-to-prod-with-inputs.yml

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 59ea9b81-aed6-cf71-becc-305d2e87936f
Version Independent ID: 0fa54745-8952-a630-6b35-0db1971c0275
Content: Tutorial: Automate solution deployment using GitHub Actions for Microsoft Power Platform - Power Platform
Content Source: power-platform/alm/tutorials/github-actions-deploy.md
Service: power-platform
Sub-service: alm
GitHub Login: @mikkelsen2000
Microsoft Alias: pemikkel

I also tried this file (release-solution-to-prod-with-spn-auth.yml) and having the same kind of problem. I definitely have the GUIDs and Azure creds correct. Any ideas?


Add terms regarding the load of vehicles

Description of the issue
Add some terms for the number of passengers/amount of goods in a vehicle including a maximum capacity.
Ideas of solution

vehicle load: A vehicle load is a quantity value indicating the magnitude of the load (passengers or goods) of a vehicle.

passenger load: A passenger load is a vehicle load that results from passengers.

passengers per vehicle: Passengers per vehicle is a passenger load averaged over a number of vehicles.

freight load: A freight load is a vehicle load that results from freight.

freight per vehicle: Freight per vehicle is a freight load averaged over a number of vehicles.

vehicle capacity: A vehicle capacity is a maximum value that indicates the maximum load of a vehicle.

For the units I suggest:
'passenger load' 'has unit' some ('mass unit' or 'count unit')
'freight load' 'has unit' some ('mass unit')
'vehicle capacity' 'has unit' some ('mass unit' or 'count unit')
Workflow checklist

[ ] I discussed the issue with someone else than me before working on a solution
[ ] I already read the latest version of the workflow for this repository
[ ] The goal of this ontology is clear to me

I am aware that

[ ] every entry in the ontology should have a definition
[ ] classes should arise from concepts rather than from words

This issue is a bit beyond the scope of the OEO, but it might be something for the planned transport ontology (working name "Open Transport and Trade Ontology", OTTO).


Realm-obj-c can't use with Swift ios 7, Cocoapods

Hi Guys,
I have read the other threads of people having the same issue, but none of the solution worked for me.
I have installed Realm-obj-c using cocoa pods. I support ios 7, so can't use the "use frameworks!".
I tried adding #import Realm/Realm.h and #import <Realm/Realm.h> , but the bridge doens't want to compile with either of them.
Every thing works perfectly when used in Objective-c classes. I haven't added the RLMSupport.swift, because it can't compile, even when I remove the import realm inside it.
I tried added Pod/** to my User Header , in recursive mod....but it screws up the Pod of Realm, basically finds errors when trying to compile.
I have no idea what to do to make it work in my Swift classes.
The project was originally in pure Objective-C, but I have started moving onto Swift, since it's what Apple wants and is forcing people to do.
I can do a work around by cloning all of my RLMObject classes into regular NSObject, and use them in Swift...but I'm pretty sure I should be able to use Realm in swift out of the box, I just don't get why it doesn't work :-(

Could you please try again the following setup steps?

Create Podfile and add pod 'Realm' like below:

platform :ios, '7.0'
target 'ObCSwiftRealm' do
pod 'Realm'
end

2. Run `pod install` from command line
3. Create bridging header file
4. Add `#import <Realm/Realm.h>` to the bridging header file.

Now, you can use Realm Objective-C from Swift. Please try to write like below:

let realm = RLMRealm()

I've also shared sample project that is setup by above steps. Please refer it:
https://github.com/kishikawakatsumi/ObCSwiftRealm

Thanks for the prompt reply.
I tried what you said, but still not working, giving me the :
Realm/Realm.h file not found for the line #import <Realm/Realm.h>
Forgot to mention I am using ABFRealmMapView, so that might be conflicting ?

@Chris59160 Could you please share your project? I could more appropriate advice if I see it.

It is a professional project....so I can't put it on git, but I could send you a zip of the project ? If you give me your email, I'll zip it to you

@Chris59160 Thanks, could you please send your project to<EMAIL_ADDRESS>? Then I'll investigate it.

@kishikawakatsumi I just sent the email with the archive to the email you gave me.
I checked both settings, and every thing looks the same....so it's really weird

@kishikawakatsumi You can cancel your progression, I have recreated a project from scratch, copy/pasted the files from my main project....and now it is actually fine in this new project...No idea why the original one is not working....
Thank you any way. IF you find something though, I'd be interested in knowing what was wrong

@Chris59160 Sounds great. I'm going to close this since your problem is solved. I'm also interested in what is wrong. Let you know if I figure out the problems.


WIP - Storage rw lock

- What I did
Vendor the latest containers/image and vrothberg/storage to test if the reader-writer locks from https://github.com/containers/storage/pull/278 cause any regressions.
- How to verify it
Running the CI :)
This is work in progress. Please do not merge.

@rhatdan @runcom @mrunalp can you drop an "/ok-to-test" to let me play with the CI?

/retest

/ok-to-test

/ok-to-test
/approve

/retest

crio.service is failing due to -
-- Logs begin at Mon 2019-02-04 12:40:02 UTC, end at Mon 2019-02-04 12:44:46 UTC. --
Feb 04 12:44:29 ip-172-18-16-114.ec2.internal systemd[1]: Starting Open Container Initiative Daemon...
Feb 04 12:44:29 ip-172-18-16-114.ec2.internal crio[26706]: time="2019-02-04 12:44:29.294599584Z" level=fatal msg="overlay: Unknown option overlay.override_kernel_check"
Feb 04 12:44:29 ip-172-18-16-114.ec2.internal systemd[1]: crio.service: main process exited, code=exited, status=1/FAILURE
Feb 04 12:44:29 ip-172-18-16-114.ec2.internal systemd[1]: Failed to start Open Container Initiative Daemon.
Feb 04 12:44:29 ip-172-18-16-114.ec2.internal systemd[1]: Unit crio.service entered failed state.
Feb 04 12:44:29 ip-172-18-16-114.ec2.internal systemd[1]: crio.service failed.

Did containers/storage remove that option recently?

Yes, it did.  It had been unnecessary for some time.

@vrothberg You can remove the overlay option as part of this PR and the tests shouldn't fail on that anymore.

This is a bug in containers/storage. We should just print a debug message if a user uses this option, it should not fail.

That's happening for btrfs since I know the tools. Shall all drivers (not just overlay) throw a deprecation debug message?

/test e2e_fedora

/test e2e_rhel
/test e2e_fedora

/test e2e_rhel
/test e2e_fedora

@mrunalp I think the bot is running wild. It's flooding with failed-test messages.

/test e2e_rhel

I restarted the test to stop the bot from spamming.

Can we close this temporarily?

On Feb 5, 2019, at 12:51 PM, OpenShift CI Robot<EMAIL_ADDRESS>wrote:
@vrothberg: The following test failed, say /retest to rerun them all:
Test name	Commit	Details	Rerun command
ci/openshift-jenkins/e2e_rhel	445ee36	link	/test e2e_rhel
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

Can we close this temporarily?

On Feb 5, 2019, at 3:12 PM, OpenShift CI Robot<EMAIL_ADDRESS>wrote:
@vrothberg: The following test failed, say /retest to rerun them all:
Test name	Commit	Details	Rerun command
ci/openshift-jenkins/e2e_rhel	445ee36	link	/test e2e_rhel
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

Closing to prevent bot spam.

I'll open a new PR to continue poking CI. The bot must have had a bad day.


Set: Add unit test for New with entries

Raven
Number of Findings: 0

lgtm

+1

RM +1 manually reviewed dependencies


kernel: spinlocks: clean up struct k_spinlock

Is your enhancement proposal related to a problem? Please describe.
The existing workaround for struct k_spinlock occasionally being 0 bytes does not always work around things. In particular when you do pointer arithmetic, which is semi important in C, but triggers some warnings now that are showing up in gcc (not just g++).
Is there a simple change that can be made so this just works better?
Maybe some compiler experts know if it can be considered a size / runtime optimization? 🤷
Describe the solution you'd like
Is there is another solution that works with like array indexing or one that does not require others to modify their source to make workarounds?
Perhaps there are some Macrobatics.
Describe alternatives you've considered
Patching API consumers whenever this issue is hit in the future.
Additional context
While working on #59911

@cfriedt What do you find unsatisfactory about the workaround by the char dummy?

@cfriedt What do you find unsatisfactory about the char dummy workaround?

It's in the description / screenshots / linked PR

Sorry, I asked because I couldn't figure it out after reading through the whole thing. I want to know specifically what problem  remains after the workaround PR is merged.

@itagagaki - the issue in this ticket is that pointer arithmetic does not work on spinlocks if they are zero bytes. So an array of spinlocks will not be addressable.
Another issue is that spinlocks are quite large these days, in particular with ticket spinlocks and spinlock validation.
Ideally, we could use only the bits required. However, Zephyr's atomics API only operates on longs.
The stdatomic.h API use C11 generics to support atomic operations on single bits, bytes, shorts, ints, and longs. So there is a significant opportunity to improve space-wise.

I see. Thanks for the explanation.
The first problem, that if the size of struct k_spinlock is zero, data of that type is not be addressable, you solved this with your patch. To prevent this from happening, you made it so that it has 1 byte of dummy data if there is no other data. This data is useless, but there's no better way, right?
And another problem is that Zephyr's atomic API only implements long, right? If char is also supported, for example, the size of this structure can be shrunk, right?
If so, I think it would be better to have a separate topic to extend atomic, don't you?

The first problem, that if the size of struct k_spinlock is zero, data of that type is not be addressable, you solved this with your patch. To prevent this from happening, you made it so that it has 1 byte of dummy data if there is no other data. This data is useless, but there's no better way, right?

I think there probably are better ways. E.g. using a union. Possibly a Kconfig option. Maybe K_SPINLOCK_ARRAY_DEFINE() or something along those lines.
It would be kind of good for k_spinlock to be addressable in general, otherwise it's getting into undefined behaviour. I do realize that there are maybe speed benefits to having zero size, but also being a core part of the kernel, it's important to be safe for safety critical systems.
Would be good to get a quantitative idea of the performance implications of making the size minimally 1 byte.

And another problem is that Zephyr's atomic API only implements long, right?

There is a separate issue for that already (#39641)


false postivie, unused variable, table expressions

CONSTANTS loki_url TYPE zale_config-ale_key VALUE 'LOKI_URL'.
export_target-url = configurations[ ale_key = loki_url ]-ale_value.

hmm, cannot really reproduce
TYPES: BEGIN OF ty,
         field TYPE i,
       END OF ty.
DATA tab TYPE STANDARD TABLE OF ty WITH DEFAULT KEY.
CONSTANTS index TYPE i VALUE 1.
DATA(sdfsd) = tab[ field = index ]-field.

hmm, cannot really reproduce
TYPES: BEGIN OF ty,
         field TYPE i,
       END OF ty.
DATA tab TYPE STANDARD TABLE OF ty WITH DEFAULT KEY.
CONSTANTS index TYPE i VALUE 1.
DATA(sdfsd) = tab[ field = index ]-field.

probably a side effect of something else, closing for now

probably a side effect of something else, closing for now


Error on install

$ npm install react-native-canvas@latest --save
npm ERR! git rev-list -n1 webview-improvements: fatal: ambiguous argument 'webview-improvements': unknown revision or path not in the working tree.
npm ERR! git rev-list -n1 webview-improvements: Use '--' to separate paths from revisions, like this:
npm ERR! git rev-list -n1 webview-improvements: 'git <command> [<revision>...] -- [<file>...]'
npm ERR! git rev-list -n1 webview-improvements:
npm ERR! Darwin 15.6.0

Currently working on a whole revision of the source code. I hope it will fix your issue

Same Issue Again

Not yet to push any updates. So it does make sense.

Hello @Mr aniddan I want to need Canvas to React native.. Its installation Failure
Please Give any Suggestion

Hello @ Iddan Ahahronson  Actually i need to React-native -canvas. But,
its,not working ,Is there any other Possible case right now.
On Tue, Jan 24, 2017 at 4:01 PM, Iddan Ahahronson<EMAIL_ADDRESS>wrote:

Not yet to push any updates. So it does make sense.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/aniddan/react-native-canvas/issues/4#issuecomment-274766200,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ATmTnMuV6S1CC3FvGIa5LktnuJqiR7oVks5rVdL_gaJpZM4LKDvM
.

I'll try to make this work ASAP. Right now I can't find an equivalent.

Okay Thank u
On Wed, Jan 25, 2017 at 12:44 AM, Iddan Ahahronson<EMAIL_ADDRESS>
wrote:

I'll try to make this work ASAP. Right now I can't find an equivalent.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/aniddan/react-native-canvas/issues/4#issuecomment-274905571,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ATmTnPQKLoLuxUM99UrQQssNKlstQy37ks5rVk2MgaJpZM4LKDvM
.

any updates?

any updates?

We're soon to release a new version supporting the latest RN and React versions. Please stay tune

The new version has been released


staging/podsecuritypolicy/rbac/README.md: update paths to YAML files

Update paths in examples to reflect the current place of the YAML files.
CC @simo5

PTAL @eparis

Could you add a note in the README that one needs to clone the repo to be able to run the kubectl  commands ? otherwise the manifests are no in the path.
thanks

@sebgoa Updated. PTAL.

Ping.

Ping.

/lgtm

/lgtm


emacsNativeComp: nearly half native-compiled eln files for builtin libs are missing

Describe the bug
The issue is what the title says.
By half, I mean
$ ls /nix/store/waklcv94vzffa36qpfghs8c1yd0080wk-emacs-28.1/lib/emacs/28.1/native-lisp/28.1-8618a055 | wc -l
1349

and for my previously used emacsGcc from emacs-overlay
$ ls /nix/store/hndnv6w8bzmw7vi5b1rcbkwf68la8lmy-emacs-gcc-28.0.92/lib/emacs/28.0.92/native-lisp/28.0.92-6a100051 | wc -l
2727

Steps To Reproduce

add emacsNativeComp to environment.systemPackages
rebuild your system
clean the eln cache in your home, e.g. mv ~/.emacs.d/eln-cache ~/.emacs.d/eln-cache.bak
use emacs -q to open emacs
look for the manual for cl-pushnew by M-x describe-function and inputing cl-pushnew
check the eln cache in your home: ls ~/.emacs.d/eln-cache/28.1*/, you will find cl-lib-*.eln together other eln cache. I think this is a bug since cl-lib is builtin for emacs and it's eln cache should be distributed together with emacsNativeComp.

Expected behavior
Uses of emacsNativeComp will not need to native-compile builtin libraries themselves.
Additional context
cl-lib-*.eln does distributed together with emacsGcc from emacs-overlay I used before.
It's /nix/store/hndnv6w8bzmw7vi5b1rcbkwf68la8lmy-emacs-gcc-28.0.92/lib/emacs/28.0.92/native-lisp/28.0.92-6a100051/cl-lib-8b938900-82325715.eln.
Notify maintainers
@lovek323 @jwiegley @adisbladis
might be related to the bump of 28 #168076 , so @azahi
Metadata
 - system: `"x86_64-linux"`
 - host os: `Linux 5.15.34, NixOS, 22.05 (Quokka), 22.05.20220426.e120fd5`
 - multi-user?: `yes`
 - sandbox: `yes`
 - version: `nix-env (Nix) 2.8.0pre20220411_f7276bc`
 - nixpkgs: `/nix/store/xjycb37n2mxmhw03fy75xrz7lrlc0wrc-source`

The difference between the two versions is that one is built from the tarball, while the other is built from Git. The tarball includes byte-compiled (.elc) files but not native-compiled (.eln) files. The build notices the .elc files and does not rebuild them, but native-compilation is a side-effect of byte-compilation and so the .eln files aren't built either.
(Almost all of the .eln files you see for the new version are trampolines, there are only 3 non-trampoline files.)

ideally we'd run make maintainer-clean, which is the expected way of deleting such things (or perhaps even make bootstrap). But the tarball only has a Makefile.in, so we'd need to run ./configure, then make maintainer-clean, then ./configure again, which is super ugly. Hopefully deleting the .elc files the naïve way is enough?

@collares I think maybe we should just skip the tarball entirely and fetch it from git instead.

@collares I think maybe we should just skip the tarball entirely and fetch it from git instead.

There are other side-effects caused by skipping the tarball. This comment by an emacs maintainer claims, for example, that bootstrapping is only expected to happen to emacs developers. Part of bootstrapping is converting the Japanese input method dictionaries, and this takes some amount of time. They're in the tarball at lisp/leim/ja-dic/ja-dic.el, but are absent in the git checkout.

There are other side-effects caused by skipping the tarball. This comment by an emacs maintainer claims, for example, that bootstrapping is only expected to happen to emacs developers. Part of bootstrapping is converting the Japanese input method dictionaries, and this takes some amount of time. They're in the tarball at lisp/leim/ja-dic/ja-dic.el, but are absent in the git checkout.

That's a good point, I would still rather inflate build times a bit and exercise bootstrapping as a part of our regular build though to completely avoid these types of issues.

There are other side-effects caused by skipping the tarball. This comment by an emacs maintainer claims, for example, that bootstrapping is only expected to happen to emacs developers. Part of bootstrapping is converting the Japanese input method dictionaries, and this takes some amount of time. They're in the tarball at lisp/leim/ja-dic/ja-dic.el, but are absent in the git checkout.

That's a good point, I would still rather inflate build times a bit and exercise bootstrapping as a part of our regular build though to completely avoid these types of issues.

I'm hesitant about building things in a way that upstream doesn't expect, unless necessary to adapt for nixpkgs. For a related example, using the repo instead of the tar distribution for Ruby caused a subtle problem where the commit hash was not propagated, which broke the bootsnap gem's cache invalidation (fixed in #161801, by using the tarball). The real question here, I think, is how upstream expects native compilation to be used if their tarball doesn't support it.


Feat/inject envfile into prod server

PR Details

prod-server supports that load server env from assign file
Description

the server can load env when prod-server  init
Related Issue

Motivation and Context

How Has This Been Tested

Types of changes

[ ] Docs change / refactoring / dependency upgrade
[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist

[x] My code follows the code style of this project.
[x] I have updated changeset
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[x] I have read the CONTRIBUTING document.
[ ] I have added tests to cover my changes.
[ ] All new and existing tests passed.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.xieqixuan seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.


Need script and directory tags in pxe_stack role

When deploying services like dhcp, tftp, http, dns etc. inside containers running on various bare metal nodes, we used the ansible "chroot" connector to generate the configuration files on a shared file system mounted on all nodes.
We want to use the standard roles (dhcp, dns, pxe_stack ...) for that purpose, but we do NOT want to start the services on the bare metal management node. So we use the template tag , but we need also for pxe_stack role to create the output directories and to copy the bootswitch cgi script. So, a directory and a script tag are needed for that.

Is this PR still valid after discussion in #59?

I think notm qs the solution you proposed does the trick.

Closing.


Bug - Trying to craft 4095 Ultimate Induction Coils freezes Minecraft

Issue description:
Trying to build a max size Induction Matrix from Mekanism (18x18x18), trying to make the 4095 (4096 minus one for the Provider) and it locks up before giving me the Crafting Preview window, wait several minutes and Minecraft locks up. Even at half of that number, 2048, it still locks up everything.
What happens:
Minecraft locks up while waiting for the Autocrafter to pull up the Crafting Preview window.
What you expected to happen:
It to pull up Crafting Preview window for making the 4095 Ultimate Induction Coils and give me the option to Start or Cancel.
Steps to reproduce:

Make all the patterns for the Ultimate Induction Coils part of the multi block Induction Matrix, build up the crafting infrastructure with Crafters.
Go into the Grid and select the Ultimate Induction Coil, click +64 enough times to get to 4096, click -1 once,
Click Start
...

Version (Make sure you are on the latest version before reporting):

Minecraft: 1.10.2
Forge: <IP_ADDRESS>5
Refined Storage: 1.2.17

Does this issue occur on a server? [yes/no] No idea, I am playing in a local world.
If a (crash)log is relevant for this issue, link it here:
[pastebin/gist/etc link here]
Oh, and before anyone asks, I have the client configured to give Minecraft 4gb of memory out of the 16gb total system memory and my processor is a Phenom X6 1045T. So it's not a system issue, it has the grunt to do it. >.<

sigh not even a crash log...and it occured on a single player. so it is not on a server.(in non technical terms)

Nope, it froze Minecraft forcing me to kill it (the Java instance) in the Task Manager.

@llloyd4 it will be VERY helpful if you posted your fml latest log. in pastebin or gist.github.com

Uh... looks at the size of the file Thank God I took the Christmas special opportunity and went Pro on Pastebin. O.o 3.6mb, so be warned. - http://pastebin.com/SPy840qC

How deep is this recipe? As in how many steps does it have to make for just one?

Honestly? No idea, never made one manually, I spent an hour setting up the infrastructure, mostly trying to work out why the Metalurgic Infuser wasn't working (user error) and why the Transfer Nodes / Pipes / Transfer Filters / Retrieval Nodes wasn't working (put in two bug reports with them on it, the retrieval nodes were ignoring the filter and the transfer nodes weren't connecting to the pipes). But once I got them together it was a matter of minutes to put up two more Crafters and make all the patterns. Let me see... Have to load up Minecraft again. Reminds me, need to put in a Feature Request, a dedicated crafter block with a lot more pattern storage than the Crafter. I have an entire wall of Crafters just for all the crafting patterns. 9 slots isn't enough for the Direwolf20s of the Minecraft world. :dagger:
Alright, Ultimate requires 4 energy tablets, an Ultimate energy cell and 4 Elites, Elite requires 4 tablets, an Elite energy cell, and 4 Advanced, an Advanced requires 4 energy tablets, an Advanced energy cell, and 4 Basics, a Basic requires 4 energy tablets, a Basic energy cube, and 4 lithium. The tablets might be an issue, they don't stack in inventory which makes them a real bug bear to work with manually. Like the cooling cells from IC2, if I remember right. But that's why we have autocrafting.

So it is a depth issue, I know what I can do to fix it. But I don't have the time right now. I guess you'll have to order smaller amounts for now.

Ok. I've wound it down to 512 with no luck. O.o I might have to do each component once I work out the math on exactly how much of each item I need.

For now I suggest using for instance an RF Tools Crafter and Detector for the smaller parts of complex recipes that require insane amounts(Like the energy tablets, control circuits and so on). Also more kind to your TPS when auto-crafting it :)

hmms You mean use a processing pattern, not crafting pattern, and Crafter on a RF Tools Crafter, put in 3 gold, 2 enriched alloy, 4 redstone and get out an energy tablet?

Output necessary items to chest(or better, drawers, so it doesn't fill up with one item), output to an RF Tools Crafter and have it make the energy tablets depending on redstone signal. Attach a detector with redstone/conduit and configure it to either send or stop sending a redstone signal when your RS system has over X amount of energy tablets and thereby stopping the crafter from making more.
It's going to be a little while until way2muchnoise can properly fix this issue, so look for alternative ways of doing massive recipes for now ;)

Duplicate of #838


Feature Request: Selective Icon Assignment for Option Menu

Hi,
I would like to request an enhancement to the streamlit-option-menu component that would allow for more flexible icon assignment. Specifically, I would like to see the following features:
Selective Icon Assignment: The ability to assign icons to only specific options within the menu. Currently, the icons list must match the length of the options list, and providing empty strings or None still results in default icons being displayed.
No Icon Option: An option to specify that no icon should be displayed for certain menu items. This could be implemented by allowing a specific value (e.g., None or an empty string) in the icons list to explicitly indicate that no icon should be shown for that particular item.
Example Use Case:
I have a menu where I want to display an icon only next to the "SEARCH" option and no icons next to other options. Here’s a simplified version of the menu configuration:
selector = option_menu(
    None,
    ["SEARCH", "ALL", "5Y", "1Y", "YTD"],
    icons=['search', None, None, None, None],
    menu_icon=None,
    default_index=0,
    orientation="horizontal",
)

Thank you!

Away from my pc now, but as far as I remember any nonexistent name gives you no icon, like "-"

Away from my pc now - can't check for sure, but as far as I remember any nonexistent name gives you no icon, like "-"

Thank you!


[PyOxidizer] Pull pre-2.10 Pants updates

Waiting for 2.10 to be officially released, and I'll grab the rest to stay in sync with the latest release


From multi-turn to single turn

Thanks for the wonderful work! It is mentioned in the paper that the dataset contains 68k multi-turn samples which correspond to  192K single-turn sample. I tried to directly split the multi-turn sample and got 220k. How can I obtain the 192k single-turn sample?

I'm sorry for the confusion. After submitting our paper, we performed an incremental update on the dataset in the Interaction_Simulation section by appending additional rounds of human feedback to some samples. This was done to enhance our model's multi-turn capabilities. We will update this information in the next version of our paper.

@THINK2TRY Thanks for your response. My question is that when using the dataset for training, should I calculate the loss for the tokens in responses in each turn, or only focus response of the final turn?


Adding option to not use exteded_j_range in DWaveCliqueSampler

Current Problem
The clique sampler by default uses extended J range (when possible), disabling the ability to perform spin reversal transformations.
Proposed Solution
if the parameter num_spin_reversal_transforms is passed to the sample method, we should use j_range instead of extended_j_range and maybe raise a warning.
Alternatives Considered
The alternative is using FixedEmbeddingComposite with minorminer.find_clique_embedding, and set things by hand, but adds a level of complexity in the script.

You can also do SpinReversalTransfromComposite(DWaveCliqueSampler()), is SRTs on the logical problem good enough or do you need them on the embedded problem?

I kinda wanted to have them on the embedded problem, but I'll test it first.

I don't love the switching behavior of not using the extended J range based on a seemingly unrelated parameter - we know the relation but the user probably wouldn't intuit it.
One solution would be to emit a warning, but I find that unsatisfying as well.


Feature/hue bugfix

Description
Fixes a bug where new connections could not be established due to the username not being stored correctly.
Checklist

[x] I read the extension guidelines
[x] I read the documentation about publishing
[x] I ran npm run build and tested this distribution build in Raycast
[x] I checked that files in the assets folder are used by the extension itself
[x] I checked that assets used by the README are placed outside of the metadata folder

@sxn since you approved the last PR, do you see the opportunity to approve this bug fix before it starts affecting a lot of users?


Cache calulation

Hi Guys,
Version 5.0.0 on linux.
I'm trying to understand how to calculate the max-chunks size.
I assumed it would be (chunk-size *  max-chunks), with a small provision for overhead but that doesn't seem to be the case.
If I would like to consume 20GB of RAM, and have a chunk size of 6MB, how would I calculate the max-chunks value?

20gb = 20.000mb / 6mb = max-chunks
If it consumes more than 20gb this is due to the fact that the garbage collection did not started yet, so e.g. I've set mine to consume 5gb ram, but it will use up to 25gb ram because, my system has the amount of ram. As soon as my system needs the ram for other processes it drops down to ~5gb ram (as you already mentioned, there is a small overhead).


Change curl URLs to https:// in the templates.

I don't know if we should hard code https. It could be a setting or left as-is for now considering on dev/local instances, we will likely not be using https whereas in production http will redirect to https.

This has been addressed in (#16)[https://github.com/unt-libraries/django-edtf/pull/16]


AZ distance update

AZ distance is not aligned with the AWS docs.
https://aws.amazon.com/about-aws/global-infrastructure/regions_az/
"AZ’s are physically separated by a meaningful distance, many kilometers, from any other AZ, although all are within 100 km (60 miles) of each other."

I don't think we should change this - the current description is not wrong - it is within 350mile of distances. And we should not quote AWS - that could change at anytime in the future if we are brining in new AZs or AWS is opening new regions.

Closing per Terry's comment.


x/website/internal/dl: provide json listing in version order

https://go.dev/dl/?mode=json gives all the current stable versions in descending order. Because they're sorted, this makes it easy to do things with tools like jq, without having to work out any finicky custom version-sort comparer.
https://go.dev/dl/?mode=json&include=all, however, gives all versions -- stable, archived, unstable -- out of order. This makes it very annoying to deal with from little tools like jq, since it's not trivial to sort version numbers.
Instead, we should sort the latter URL in the same descending order as the former URL.
CC @dmitshur

Since the suggestion here is to make &include=all give versions in sorted order, I think that means #47367 needs to be fixed first. Otherwise when there's more than 1 pre-release version, it won't be possible to rely on their order.

Didn't know about that; thanks. I'll look into it.

@dmitshur - The CL should now handle everything mentioned. Is there anything else needed?

Thanks. In general it looks good, I left minor comments.
As I mentioned on the CL, I expect this change to not to be disruptive, and one that we can make, but it's hard to know for sure in advance how smoothly it'll go. Since we're in a quiet week and right before holidays, let's defer next steps here to January.

Okay. Addressed your comments. Will plan on this being merged in January.


vi mode indicator missing

I've been using slimline for a while now and I feel the only piece that's missing for me is a vi modal indicator.
Could such a feature be added to the roadmap?
Thanks,
Sonnius

I added a vi_mode section in the develop branch. It is active by default and its format can be customized.

mgee, that looks like the exact thing I wanted!
Switched to develop for now, will report bugs if I find them.
Thanks!
Sonnius


Testing Precompiles Using Foundry results in Unknown error invoking RPC

Description
I am using the Hedera Precompiles to create a simple fungible token. I set up a smart contract that imports the precompiles and create a function called createFungible(). I then set up a test and used foundry to test the create fungible token function.
When running the test, it fails with the following error:
% forge test --fork-url https://testnet.hashio.io/api -vvvv
[⠆] Compiling...
No files changed, compilation skipped
2023-01-06T00:23:10.655008Z ERROR sharedbackend: Failed to send/recv `storage` err=GetStorage(0x7109709ecfa91a80626ff3989d68f67f5b1dd12d,<PHONE_NUMBER>6495007027972728677917914892729792999299745830475596687180801507328,
(code: -32603, message: [Request ID: 8fd7fec6-5fc5-40eb-9288-343083ef40c7] Unknown error invoking RPC, data: None)) address=0x7109709ecfa91a80626ff3989d68f67f5b1dd12d index=46308022326495007027972728677917914892729792999299745830475596687180801507328

Running 1 test for test/foundry/MyContract.t.sol:MyContractTest
[FAIL. Reason: Assertion failed.] test_CreateFungible() (gas:<PHONE_NUMBER>516744731)
Logs:
  Error: a == b not satisfied [int]
    Expected: 22
      Actual: 21

Traces:
  [8937393460516744731] MyContractTest::test_CreateFungible()
    ├─ [8937393460516724677] 0x0000000000000000000000000000000002eF1D37::339d1f60(000000000000000000000000000000000000000000000000000000000000008000000000000000000000000000000000000000000000000000000000000000c0000000000000000000000000000000000000000000000000000000000000000800000000000000000000000000000000000000000000000000000000006acfc00000000000000000000000000000000000000000000000000000000000000006546573744654000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000035446540000000000000000000000000000000000000000000000000000000000)
    │   ├─ [0] 0x0000000000000000000000000000000000000167::c23baeb6(000000000000000000000000000000000000000000000000000000000000006000000000000000000000000000000000000000000000000000000000000000070000000000000000000000000000000000000000000000000000000000000008000000000000000000000000000000000000000000000000000000000000016000000000000000000000000000000000000000000000000000000000000001a00000000000000000000000000000000000000000000000000000000002ef1d3700000000000000000000000000000000000000000000000000000000000001e0000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000020000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000002ef1d3700000000000000000000000000000000000000000000000000000000006acfc0000000000000000000000000000000000000000000000000000000000000000654657374465400000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000003544654000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000)
    │   │   └─ ← ()
    │   └─ ← 0x00000000000000000000000000000000000000000000000000000000000000150000000000000000000000000000000000000000000000000000000000000000
    ├─ emit log(: Error: a == b not satisfied [int])
    ├─ emit log_named_int(key:   Expected, val: 22)
    ├─ emit log_named_int(key:     Actual, val: 21)
    ├─ [0] VM::store(VM: [0x7109709ECfa91a80626fF3989D68f67F5b1DD12D], 0x6661696c65640000000000000000000000000000000000000000000000000000, 0x0000000000000000000000000000000000000000000000000000000000000001)
    │   └─ ← "Failed to get storage for 0x7109709ecfa91a80626ff3989d68f67f5b1dd12d at<PHONE_NUMBER>6495007027972728677917914892729792999299745830475596687180801507328:
(code: -32603, message: [Request ID: 8fd7fec6-5fc5-40eb-9288-343083ef40c7] Unknown error invoking RPC, data: None)"
    └─ ← ()

Test result: FAILED. 0 passed; 1 failed; finished in 27.41s

I expect to be able to test my contracts functions which utilize the hedera precompiles.
Steps to reproduce
1.Unzip the project below and open it in vscode
hedera_precompile_foundry.zip
2. edit the .env file
3. Open a terminal in the project's dir
4. run forge test --fork-url https://testnet.hashio.io/api -vvvv
Additional context

Hedera network
testnet
Version
2.18.5
Operating system
macOS

The Foundry EVM doesn't support the precompiles, you'll have to run it against the hedera local node, which is much slower as it currently stands.

The Foundry EVM doesn't support the precompiles, won't you have to run it against the hedera local node, which is much slower as it currently stands. The hardhat local node would have the same issue. It would be nice if we could run it against the Foundry or Hardhat node as they're much faster and they implement debugging methods not currently available on the hedera relay.

Yes, you can run tests against hedera-local-node which supports precompiles.

Given that there is no action item here other than the option to use local-node, I'm closing this issue.

I ran this test against the local node (current main branch) and had the same issue.  I looked at the output in the local-node docker compose logs and found it was trying to get data on a contract at address 0x7109709ecfa91a80626ff3989d68f67f5b1dd12d.

That address appears to be related to foundry 'cheat codes'  contract that performs different functions for testing.
https://github.com/foundry-rs/foundry/blob/master/forge/README.md

Hey @vea-vecturne
Unfortunately, it looks like what you're trying to achieve is currently impossible.
There are two setups you can use to execute tests:

Using the local node would run the tests in the Hedera EVM - the Hedera precompiled contracts will work, but the Foundry custom cheat codes contract won't be available
Using the Foundry EVM - the cheat codes contract will be available, but the Hedera system contracts will not be there

There is no Foundry support currently in Hedera.


Logbook 1

Logbook : 1
Meeting No: 	1						               Date:  11/10/2024
Start Time:  10 AM							End Time:  10:30 AM
Items Discussed :

[x]  Business rules for Gymify application.
[x] Entity Relationship Diagram (ERD).
[x] Setup and configuration of the PostgreSQL database using init.sql script.
[x] Proposal and marking scheme.

Achievements:

[x] Completed comprehensive documentation of business rules for Gymify application.
[x] Completed the Entity Relationship Diagram (ERD) after feedback from teacher.
[x] Successfully set up the PostgreSQL database with all necessary tables, ENUM types, and relationships.
[x] Setup Github repository for the project and uploaded all the necessary documents

Problems (if any):
1.	Database Schema Planning
•	Initial complexity in optimizing database structure
•	Required multiple iterations to achieve optimal design
2.	ERD Development
•	Identified and resolved several structural issues
•	Refined relationships between entities for better efficiency
Tasks for the Next Meeting:

Initialize Node.js backend environment
Configure Prisma ORM integration
Establish database connectivity with Node.js
Install and configure Language Server Extension (VS Code)
Develop user registration API endpoints
Set up debugging environment with breakpoints.


How to override icons that start with a dot?

require'nvim-web-devicons'.setup {
    -- your personnal icons can go here (to override)
    -- DevIcon will be appended to `name`
    override = {
        lua = {icon = "", color = colors.nord15, name = "lua"},
        .gitignore = {icon = "", color = colors.nord4, name = "GitIgnore"},
    },
    -- globally enable default icons (default to false)
    -- will get overriden by `get_icons` option
    default = true
}

This gives an error.
How do i properly override the .gitignore icons? (And others that start with a dot)

@hrqmonteiro you need to but .gitignore in quotes like ['.gitigore'] non alphabetical keys in lua need to be put in braces and quoted

@hrqmonteiro you need to put .gitignore in quotes like ['.gitigore'] non alphabetical keys in lua need to be put in braces and quoted

Thanks, man!


[Fix][Docker] Add write permissions to /pulsar subdirectories to enable running as non-root user

Fixes #15230
Motivation
The Quickstart/Getting Started in Docker example does not work with Pulsar 2.10.0:
docker run -it -p 6650:6650  -p 8080:8080 --mount source=pulsardata,target=/pulsar/data --mount source=pulsarconf,target=/pulsar/conf apachepulsar/pulsar:2.10.0 bin/pulsar standalone

When you run the command, you get a permissions error:
ERROR org.apache.pulsar.PulsarStandaloneStarter - Failed to start pulsar service.
java.nio.file.AccessDeniedException: /pulsar/data/standalone

This is because the Docker image is running as a non-root user but does not have permissions to write to the volume being mounted at /pulsar/data
I think this issue is an important concern because it frustrates prospective/new Pulsar users (like me!) with their first impression of trying the project
Modifications

Previously the Docker image was adding write permissions (for the root group) to the /pulsar/conf directory
This PR updates that RUN instruction with a shell script loop that creates and sets write permissions on the following directories:

/pulsar/conf
/pulsar/data
/pulsar/download
/pulsar/logs

Verifying this change
This change is a trivial rework / code cleanup without any test coverage.

It can be verified by running the Getting Started in Docker example code listed above, which currently fails with Pulsar 2.10.0

Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): no
The public API: no
The schema: no
The default values of configurations: no
The wire protocol: no
The rest endpoints: no
The admin cli options: no
Anything that affects deployment: yes

This PR updates the Docker image by creating empty, writeable subdirectories (data, download, logs) inside of /pulsar that did not previously exist to enable mounting of volumes that will be writeable by a non-root user at run-time. Potentially this may affect users who were relying on these directories not existing, however I'd contend that the image is broken for new users who are trying out Pulsar for the first time.

Documentation
Check the box below or label this PR directly.
Need to update docs?

[ ] doc-required
[X] no-need-doc

This PR fixes an issue that is already covered by existing "Getting Started in Docker" documentation, it does not require any updates to the existing documentation.

[ ] doc
[ ] doc-added

This PR will also address #15746 which is effectively a duplicate of #15230

cc @michaeljmarshall for your advice because of your work on #11269

@drianpauL - thanks for your contribution! I should be able to review this tomorrow.

Fixes #15647

Thank you @michaeljmarshall for the prompt review and acceptance of this patch 🍰

Is this fix released? I'm still getting errors.


Issues/77879

#77879

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: mayaswrath sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.

Thanks for your PR. It looks good and it works fine.
However I have left some comments in the code so we improve this. Once you tackle that let me know and I can merge this. Thanks a lot!

Looks great, thanks a lot for your contribution! Merging in 👏


WSL is unoperable (all non built-in commands segfault or throw I/O error)

Version
Microsoft Windows [Version 10.0.22593.1]
WSL Version

[X] WSL 2
[ ] WSL 1

Kernel Version
<IP_ADDRESS>
Distro Version
Ubuntu 21.10?
Other Software
No response
Repro Steps

Have installed php 3.7.4 and apache2 with default everything from using apt
download PHP 3.8.1 to \wsl.localhost\Ubuntu\tmp\mozilla_daniel0
extract it to that place (I used 7zip and I needed to fix executibility by chmod +x on relevant files and miss ./build/shtool)
run ./configure
install missing library using adb
repeat untill ./configure does not need anything to install
run make
run make test
fix executability of ./build/shtool
repeat 6 and 7
run make test
only builtin commands works.

Expected Behavior
I can run any command and copy files from windows or create them.
Actual Behavior
make test
...
SKIP sapi_windows_set_ctrl_handler() [sapi/cli/tests/sapi_windows_set_ctrl_handler.phpt] reason: this test is for Windows platforms only
PASS Testing ftell() on std streams [sapi/cli/tests/std_streams.phpt]
TEST 12580/12696 [sapi/cli/tests/upload_2G.phpt]
Warning: file_put_contents(/tmp/mozilla_daniel0/php-8.1.4/sapi/cli/tests/upload_2G.exp): Failed to open stream: Read-only file system in /tmp/mozilla_daniel0/php-8.1.4/run-tests.php on line 2748
ERROR: Cannot create expected test output - /tmp/mozilla_daniel0/php-8.1.4/sapi/cli/tests/upload_2G.exp
rm: cannot remove '/tmp/mozilla_daniel0/php-8.1.4/tmp-php.ini': Read-only file system
make: *** [Makefile:204: test] Error 1
daniel@DANIEL-NTB:/tmp/mozilla_daniel0/php-8.1.4$ make test > tst.log
-bash: tst.log: Read-only file system
daniel@DANIEL-NTB:/tmp/mozilla_daniel0/php-8.1.4$ touc a
-bash: /usr/lib/command-not-found: Input/output error
daniel@DANIEL-NTB:/tmp/mozilla_daniel0/php-8.1.4$ touch a
Segmentation fault
daniel@DANIEL-NTB:/tmp/mozilla_daniel0/php-8.1.4$ touch ad
Segmentation fault
daniel@DANIEL-NTB:/tmp/mozilla_daniel0/php-8.1.4$ mv ../php-8.1.4 ~
Segmentation fault
daniel@DANIEL-NTB:/tmp/mozilla_daniel0/php-8.1.4$ cp ../php-8.1.4 ~
Segmentation fault
daniel@DANIEL-NTB:/tmp/mozilla_daniel0/php-8.1.4$ cd ~
daniel@DANIEL-NTB:~$ touch a
Segmentation fault

When copying from wsl: cannot read from source dics

when copying to the disc: Disc protected agnist rewrite

It is also not possible to get exact ubuntu version which I do not remember.
Diagnostic Logs
strace -ff touch -bash: /usr/bin/strace: Input/output error

It might be helpfull that I had very little space left on drive C:. I freed some space, but it did not fix anything.

appears to be fixable by reinstalling/updating wsl
Microsoft Windows [Version 10.0.22593.1]
(c) Microsoft Corporation. Všechna práva vyhrazena.

C:\Windows\System32>wsl.exe --status
Default Distribution: Ubuntu
Default Version: 2

Windows Subsystem for Linux was last updated on 28.03.2022
WSL automatic updates are on.

Kernel version: <IP_ADDRESS>

C:\Windows\System32>wsl.exe --update
Installing: Windows Subsystem for Linux
Windows Subsystem for Linux has been installed.

C:\Windows\System32>wsl.exe --status
Výchozí distribuce: Ubuntu
Výchozí verze: 2
Verze WSL: <IP_ADDRESS>
Verze jádra: <IP_ADDRESS>
Verze WSLg: 1.0.32
Verze MSRDC: 1.2.2924
Verze Direct3D: 1.601.0
Verze Windows: 10.0.22593.1

C:\Windows\System32>

Thanks for reporting this @mcDandy.
Low disk space shouldn't cause segfaults, but low memory can.
I'm closing for now since the issue appears to be fixed, but please reopen and collect some logs if it happens again (see https://github.com/Microsoft/WSL/blob/master/CONTRIBUTING.md#record-wsl-logs-manually )

It is happening again, but I cannot reopen it.

@OneBlue can you reopen it?
the way I used does no longer fix it becouse I am the latest version and I have 3GB of RAM free.
The main problem is that I cannot read or write to wsl drive.

It appears I cannot create profile manually. And I might have clicked on something that is not other in centrum feedback, but I am not sure.
PS D:\Users\Daniel Martinek\Documents\wprp> wpr -start wsl.wprp -filemode
PS D:\Users\Daniel Martinek\Documents\wprp>  wpr -stop wsl.etl
Press Ctrl+C to cancel the stop operation.

        There are no trace profiles running.

        Error code: 0xc5583000
PS D:\Users\Daniel Martinek\Documents\wprp> wpr -start wsl.wprp -filemode

        The profiles are already running.

        Profile Id:

        Error code: 0xc5583001
PS D:\Users\Daniel Martinek\Documents\wprp> wpr -stop wsl.etl
Press Ctrl+C to cancel the stop operation.

        There are no trace profiles running.

        Error code: 0xc5583000
PS D:\Users\Daniel Martinek\Documents\wprp>

Sometimes it works and sometimes not.

RAM is above 5GB free, disk got filled and error is back.

can be fixed by restart of ubuntu, but it can be as easily back by running php 8.1.4 checker.

Hmm I'm wondering if the issue is that there's just no more space to write the log file. In that case I'm not sure how we can gather logs for this.
Maybe the log capture automatically stops once the machine runs out of space. What's the output of 'dmesg' once the message gets into that state ?

Thats wierd... Now the trace works.

Windows does not know that message and when wsl is in that broken state it doesnot premit of running any program which is not built-in. I am trying to recreate the broken state with profiller running. No luck yet.

I managed to recreate it. It is caused by full disc.
wsl2.zip

Thank you @mcDandy.
Looking at the logs, this looks like the root cause of the segfault you're seeing:
[69281.945980] sd 0:0:0:2: Device offlined - not ready after error recovery
[69282.310303] EXT4-fs (sdc): failed to convert unwritten extents to written extents -- potential data loss!  (inode 119429, error -30)

Which makes sense since the Windows disk is full.
Unfortunately, this is not something that WSL can fix easily, if there's no space left on disk and the WSL guest tries to write to its virtual disk, things will inevitably start failing.

It is happening to me also, Windows 10, wsl2.


15+ emails per day with title [Django] zulip: (451, b'4.3.0 pymilter: untrapped exception in pythonfilter')

Hello,
we receive about 15 mails per day with this mail body:
Logger root, from module zerver.worker.queue_processors line 265:
Error generated by Anonymous user (not logged in) on zulip deployment

Traceback (most recent call last):
  File "/home/zulip/deployments/2020-08-01-22-06-40/zerver/worker/queue_processors.py", line 217, in do_consume
    consume_func(events)
  File "/home/zulip/deployments/2020-08-01-22-06-40/zerver/worker/queue_processors.py", line 246, in <lambda>
    consume_func = lambda events: self.consume(events[0])
  File "/home/zulip/deployments/2020-08-01-22-06-40/zerver/worker/queue_processors.py", line 151, in wrapper
    func(worker, data)
  File "/home/zulip/deployments/2020-08-01-22-06-40/zerver/worker/queue_processors.py", line 525, in consume
    send_email_from_dict(copied_event)
  File "/home/zulip/deployments/2020-08-01-22-06-40/zerver/lib/send_email.py", line 170, in send_email_from_dict
    send_email(**dict(email_dict))
  File "/home/zulip/deployments/2020-08-01-22-06-40/zerver/lib/send_email.py", line 165, in send_email
    if mail.send() == 0:
  File "/home/zulip/deployments/2020-08-01-22-06-40/zulip-py3-venv/lib/python3.6/site-packages/django/core/mail/message.py", line 291, in send
    return self.get_connection(fail_silently).send_messages([self])
  File "/home/zulip/deployments/2020-08-01-22-06-40/zulip-py3-venv/lib/python3.6/site-packages/django/core/mail/backends/smtp.py", line 110, in send_messages
    sent = self._send(message)
  File "/home/zulip/deployments/2020-08-01-22-06-40/zulip-py3-venv/lib/python3.6/site-packages/django/core/mail/backends/smtp.py", line 126, in _send
    self.connection.sendmail(from_email, recipients, message.as_bytes(linesep='\r\n'))
  File "/usr/lib/python3.6/smtplib.py", line 888, in sendmail
    raise SMTPDataError(code, resp)
smtplib.SMTPDataError: (451, b'4.3.0 pymilter: untrapped exception in pythonfilter')

Deployed code:
- git: None
- ZULIP_VERSION: 3.1

Request info: none

What we've tried but didn't change anything:

Upgrade vom Zulip 2.1.7 to 3.1

What is this causing and how can we stop it?

I've never seen this exception before. The code path is Zulip trying to send outgoing email.
Googling, it looks like your email server is running https://pythonhosted.org/pymilter/ and that is throwing an exception (I.e. the bug is on the mail server side).  So I'm going to close this as likely not an issue with Zulip; let us know if you find anything suggesting Zulip could better handle this issue.

Thank you @timabbott  - I did some more investigation on mail server log and the error there was:
...domain zulip.my-domain.tld is not owned by.....

It's just strange because mails have already worked some time ago...
So setting the NOREPLY_EMAIL_ADDRESS =<EMAIL_ADDRESS>in /etc/zulip/settings.py fixed it.

In the config is written:
# The noreply address to be used as the sender for certain generated
# emails.  Messages sent to this address could contain sensitive user
# data and should not be delivered anywhere.  The default is
# e.g<EMAIL_ADDRESS>(if EXTERNAL_HOST is
# zulip.example.com).

Maybe the better default behavior is to use the EMAIL_HOST_USER instead of<EMAIL_ADDRESS>

Well, it's a bit of a security problem if the "noreply" role email address can receive email, which could be the case for EMAIL_HOST_USER.  So it seems risky to create that default; we'll shift the consequence of missing the noreply documentation details from "emails don't arrive" to "potential security problem".
So I think there's not a simple change we can make here to help avoid other users having outgoing email misconfigurations of this form.


Files extended attributes seem to be erased

I've run a couple of rootfs mounts using this tool and it seems like the Extended attributes which include Capabilites don't appear in the mounted state

Looking at the code it's actually very obvious that the XATTR are ignored
There are no signs of Header.Xattrs or Header.PAXRecords


Fix version options when installed from pip

Currently, sim = cv.Sim('version='1.7.0') only works when installed from GitHub, not pip, it seems (noted by @msosnovskaya).

Fixed in 2.0.1

Fixed in 2.0.1


doesn't working on Rails 4.2

Jasny doesn't working on Rails 4.2

sorry. I've found error in my own code.


[BEAM-1231] Add missed "kind:bytes" to CloudObjectKinds/CloudObjectTranslators

Be sure to do all of the following to help us incorporate your contribution
quickly and easily:

[x] Make sure the PR title is formatted like:
[BEAM-<Jira issue #>] Description of pull request
[x] Make sure tests pass via mvn clean verify.
[x] Replace <Jira issue #> in the title with the actual Jira issue
number, if there is one.
[x] If this contribution is large, please file an Apache
Individual Contributor License Agreement.

R: @tgroh


feat/Extract images in partition_html

Is your feature request related to a problem? Please describe.
I process HTML files and uses the partition_html function to do so. However, I noticed that this function is capable of extracting Tables as an elements, but not Images.
Describe the solution you'd like
I would like partition_html to be able to extract Images, like how shared.PartitionParameters is able to.
Describe alternatives you've considered
I have tried parsing the same HTML file into shared.PartitionParameters, but this also do not extract Images. One alternative I explored was to convert the HTML file to PDF. While this might be possible, it is not guaranteed that the conversion will still yield the same expected output.
Additional context
nil

Hi @jiarongkoh - thanks for the issue! We haven't supported image extraction from HTML in the past because images in HTML are linked rather than embedded directly in the document. We'll revisit internally though and follow up.

@MthwRobinson do you plan to implement this feature anytime soon?

This feature is not on the roadmap, primarily due to security concerns related to downloading arbitrary binaries (images) from the internet. We may consider it again at a later time. More likely is we'll capture image URLs in metadata such that a user can make downloading safety decisions themselves.


feat: add haptics support to Pressable

Part of LEA-659
Adds haptics support to Pressable and a hook to invoke haptics in isolation:
Basic usage – triggers on press by default:
<Pressable haptics="soft" />

Fine-grained usage – on press, on long press, or both
<Pressable haptics={ onPress: 'soft', onLongPress: 'rigid' } />

The hook
Simple, safe-wrapper around expo-haptics.
const triggerHaptics = useHaptics()

triggerHaptics('success');

This really only exists for few  reasons:

Ability to normalize haptic feedback across platforms in the future: Android vibrations equivalent can be often much stronger. Will test soon enough.
Add ability to disable hooks in app settings in the future. This is actually the only reason why this is a hook and not a simple factory.
Avoid importing enums from expo-haptics every time we need to use it.
Gracefully handle possible errors, currently by simply silencing them. Not sure yet if these are at all worth logging or keeping track of at the moment.

Added a setting for toggling haptics. Ironically the react-native switch that toggles it has haptic feedback baked in that cannot be disabled. Would be a nice a touch to replace it with our own that vibrates when turning on this particular setting, and doesn't when turning it off.


Fix incorrect key name in ThemeSettings spec JSON

Summary
The ThemeSettings.spec.json file specifies that the key under theme for the dictionary of colors is colors. However, when used in practice, the correct key is color; colors does not work. This corrects the spec to match the implementation.
(In truth, it seems like colors would be both more accurate and more consistent, but changing the implementation to match the spec would be considerably wider-ranging and have significant compatibility implications.)
Testing
N/A, documentation-only change
Checklist
Make sure you check off the following items. If they cannot be completed, provide a reason.

[ ] Added tests N/A, documentation-only change
[ ] Ran the ./bin/test script and it succeeded N/A, documentation-only change
[x] Updated documentation if necessary

@swift-ci Please test

Linux CI failure was known issue, fixed by https://github.com/apple/swift-docc/pull/875

@swift-ci Please test


Is this project dead?

Hi @Idered, thanks so much for making this. I'm a big fan of what you've got so far, and the mockups for the remake (?) looks wonderful. I hate to be "that guy" who asks if a project is dead, but I wonder if there's anything the community can do to help or keep the momentum going.
The app still works as-is, tho it is somewhat unstable (frequent random slowness, crashes and hotkey ignoring) at least on Win 11. Unfortunately, the current baked-in shortcut conflicts with various other shortcuts that are commonly used across other apps in my system and are indeed muscle-memorized at this point. Examples include pasting in WSL terminals and IDE shortcuts for various specialized paste actions.
Looking for info about changing the hotkeys and other issues led me to wonder if the project was dead given the lack of recent updates and engagement.
Given that you've ostensibly got some work underway on a refactor/remake for which there appear to be no active branches (in this repo), but a fleshed out vision/mockup nonetheless, I wonder if you'd be open to opening up the development of that. Otherwise a status update or something would be nice!
Please don't take my requests as entitlement - I love snatch even if I end up not using it, as it's clearly a labor of love and something shockingly lacking in competition on Windows. So thanks again!

@riotrah Hey, thanks for push, I've restarted my work on Snatch 2.0. You can follow updates on my twitter https://twitter.com/Idered/status/1584661019309142016

I'd encourage those interested to check out that thread. Really wild stuff honestly.
It also looks gorgeous, at least on your Mac. I currently use RayCast as a launcher on Mac and use its rich built-in clipboard manager - your new design looks a lot like it coincidentally.
One feature I especially really miss from that manager is that it detects colors in hex format (maybe other formats, I only ever copy in hex so I wouldn't know), and displays them in the preview - killer.
I am curious however, how snappy your new one is with all those extra features - no doubt the more intensive stuff will be optional, but a frame of reference might be nice. Would love to be able to set and forget those features bc they seem sick!

Double post sorry:
I wanna also volunteer to be a beta tester! Meaning, would be sick to see the app develop every time new commits come out


fix #1711: layout is more responsive on small devices

alternatively show menu items as dropdown menu for small screen size
selective hide unimportant table columns for small screen size
more reasonable column size for small screen size
blue loading bar (at top) will shown when a request takes longer than 1s (previously was 200ms)
fixed a sorting table flicker issue

+1


Finish write-content span before completing delegate

Finish write-content span before completing delegate to ensure it is terminated before the span for the HTTP request itself.
Signed-off-by: Santiago Pericas-Geertsen<EMAIL_ADDRESS>

Is it possible that the method sendHeadersIfNeeded throws an exception?

New version pushed that addresses @tomas-langer concern.

LGTM


Toggle based on background value?

Is there a way to hook Catppuccin to auto toggle when the background of nvim changes?
the docs has this

Remember that if you want to switch your Catppuccin flavour "on the fly" you may use the :Catppuccin  command.
Note: the command has autocompletion enabled, so you can just press tab to cycle through the flavours

but I want latte if the background is light, and mochais the background isdark`.
How can I make this happen?
thanks you guys!

also, am happy to update the docs on how to do this if that makes sense!

You can try this, cheers!
vim.api.nvim_create_autocmd("OptionSet", {
	pattern = "background",
	callback = function()
		vim.cmd("Catppuccin " .. (vim.v.option_new == "light" and "latte" or "mocha"))
	end,
})

also, am happy to update the docs on how to do this if that makes sense!
Pull requests are welcome, thank you so much :)

I have created a FAQ section, let me know what you think!
https://github.com/catppuccin/nvim/tree/dev#toggle-lightdark-theme-based-on-background-value
Pull requests to improve it are welcome :)


Refactor BERTScore tests

What does this PR do?
Fixes #1110
Following on this PR, I'd also suggest a refactor of BERTScore itself as its implementation is a bit obscure.
Before submitting

[x] Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
[x] Did you read the contributor guideline, Pull Request section?
[x] Did you make sure to update the docs?
[x] Did you write any new necessary tests?

PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃

@Borda Tests should be hopefully refactored and fixed now. I would also suggest slightly refactoring functional and class metrics themselves. :]

@stancld, how is it going here? :)

@Borda Currently trying to resolve why the tests freeze on ddp=True, dist_sync_on_step=True... It doesn't happen always but definitely most of the time 🤔

@SkafteNicki @justusschock, mind having a look? :rabbit:

Currently trying to resolve why the tests freeze on ddp=True, dist_sync_on_step=True... It doesn't happen always but definitely most of the time

pls @SkafteNicki ^^

@Borda @SkafteNicki I found out the problem is very likely on the side of reference score, where data are processed within a Pool:
def get_idf_dict(arr, tokenizer, nthreads=4):
    """
    Returns mapping from word piece index to its inverse document frequency.
    Args:
        - :param: `arr` (list of str) : sentences to process.
        - :param: `tokenizer` : a BERT tokenizer corresponds to `model`.
        - :param: `nthreads` (int) : number of CPU threads to use
    """
    idf_count = Counter()
    num_docs = len(arr)

    process_partial = partial(process, tokenizer=tokenizer)

    with Pool(nthreads) as p:
        idf_count.update(chain.from_iterable(p.map(process_partial, arr)))

    idf_dict = defaultdict(lambda: log((num_docs + 1) / (1)))
    idf_dict.update({idx: log((num_docs + 1) / (c + 1)) for (idx, c) in idf_count.items()})
    return idf_dict

which eventually likely results in those errors we're facing 😬

tm [[0.8306975  0.8739164  0.72068065 0.8306975 ]
 [0.8475447  0.83431923 0.69224256 0.8475447 ]
 [0.80905366 0.81940556 0.6781949  0.80905366]
 [0.7635116  0.81414014 0.650942   0.7635116 ]
 [0.7138042  0.77494    0.63750863 0.7138042 ]
 [0.6709998  0.73885846 0.6477587  0.6709998 ]
 [0.6260605  0.7129422  0.64940983 0.6260605 ]
 [0.5878769  0.6894183  0.64766484 0.5878769 ]
 [0.57530874 0.69059736 0.6506037  0.57530874]
 [0.5705996  0.6988218  0.6483182  0.5705996 ]
 [0.57114387 0.71416587 0.6398848  0.57114387]
 [0.61254483 0.7734972  0.6539489  0.61254483]
 [0.66501355 0.7811058  0.6300469  0.66501355]]
reference tensor([[0.7207, 0.8307, 0.8307, 0.8739],
        [0.6922, 0.8475, 0.8475, 0.8343],
        [0.6782, 0.8091, 0.8091, 0.8194],
        [0.6509, 0.7635, 0.7635, 0.8141],
        [0.6375, 0.7138, 0.7138, 0.7749],
        [0.6478, 0.6710, 0.6710, 0.7389],
        [0.6494, 0.6261, 0.6261, 0.7129],
        [0.6477, 0.5879, 0.5879, 0.6894],
        [0.6506, 0.5753, 0.5753, 0.6906],
        [0.6483, 0.5706, 0.5706, 0.6988],
        [0.6399, 0.5711, 0.5711, 0.7142],
        [0.6539, 0.6125, 0.6125, 0.7735],
        [0.6300, 0.6650, 0.6650, 0.7811]])

It looks like when DDP=True and dyst_sync_on_step=False, the order of batches is sometimes different between TM and reference metric. Would it be viable solution to take an average over examples? I believe, in a real scenario, one would be mainly interested in an aggregated metric. Actually, dunno which implementation tends to switch example order 🤔

@stancld I also noticed that sometimes the order of the batches is not the same, and it is due to the gathering over multiple processes on torchmetrics side. It usually does not matter because we do aggregation but for some metrics it is hard to get the tests right. I would suggest we also just check that the aggregated value works in this case.

Hey @Borda @SkafteNicki -- Do you know if there's been recently any update to dist_sync_on_step method? There are several failing tests with dist_sync_on_step=True, but I don't understand why. Also, they look to be a bit flaky according to my testing on local 🤔

@justusschock could you pls have look? :otter:

Those failing tests are also pretty peculiar as from printed results it looks to me the results from our metric and a reference one are equivalent.

@stancld do you think we can get this land? :otter:

@stancld, how is it doing, can I help somehow? :chipmunk:

@stancld, how is it doing, can I help somehow? 🐿

Actually, I'm really unsure how to debug those failing tests due to multiprocessing :/ Do you have any tips please? 🙏

running doctests gives:
Some weights of the model checkpoint at roberta-large were not used when initializing RobertaModel: ['lm_head.layer_norm.bias', 'lm_head.dense.weight', 'lm_head.dense.bias', 'lm_head.bias', 'lm_head.layer_norm.weight', 'lm_head.decoder.weight']
- This IS expected if you are initializing RobertaModel from the checkpoint of a model trained on another task or with another architecture (e.g. initializing a BertForSequenceClassification model from a BertForPreTraining model).
- This IS NOT expected if you are initializing RobertaModel from the checkpoint of a model that you expect to be exactly identical (initializing a BertForSequenceClassification model from a BertForSequenceClassification model).

it is strange as the metric init docstring passes and fails with the second one as at that time if shall be using an already cached version...


Flow Modern target does not create types for operation arguments

In this example:
mutation DoFoo($someId: ID!, $someText: String, $clientMutationId: String) {
  doFoo(input: {
      someDefault: "FOO",
      id: $someId,
      text: $someText,
      clientMutationId: $clientMutationId}) {
    someResult
  }
}

The old flow target would generate a DoFooVariables type including someId, someText, and clientMutationId.
That appears to be missing from the flow-modern target. In flow-modern, only referenced mutation input type are generated (as in—if there is an additional input type referenced in the mutation), independent of the arguments needed for the operation.
This is related to:

(#318) Feature request: flow types incorporating operation name and associated variables
(#320) Flow Modern does not export "input" types

Thanks for filing! I'll take a look at implementing this when I get the chance.


Dwinkel3/issue152

Fixes #152

This workflow publishes the entire repo as a static GH page? Wouldn't it be better for Soldeer if we published to npm or drafted a release with artifacts?


Ignoring undefined namespaces?

julia> str = """<cn type="e-notation" cellml:units="molar_per_minute">5   <sep/>-2</cn>"""
"<cn type=\"e-notation\" cellml:units=\"molar_per_minute\">5   <sep/>-2</cn>"

julia> parsexml(str)
EzXML.Document(EzXML.Node(<DOCUMENT_NODE@0x0000000002880610>))

julia> parsexml(str).root
ERROR: AssertionError: isempty(XML_GLOBAL_ERROR_STACK)

I have snippets of an XML Document resulting from a findall("//x:math", node, ["x"=>"http://www.w3.org/1998/Math/MathML"]), but these nodes have references to namespaces defined elsewhere.
I'm wondering if I can ignore the undefined namespace, basically remove all cellml: attributes from a Document.
I suppose I could do findall("//*[@cellml:*]", node) and then just delete! the attributes.
This is sort of an annoying hack, as other documents might have other namespaces.

Another frustrating issue with XML_GLOBAL_ERROR_STACK is that it requires a restart of Julia to clear. I don't really see why though. If I call the above MWE, then try to parsexml a valid XML string with no namespace, I cannot parse it.

Another frustrating issue with XML_GLOBAL_ERROR_STACK is that it requires a restart of Julia to clear. I don't really see why though. If I call the above MWE, then try to parsexml a valid XML string with no namespace, I cannot parse it.

I've run into the same issue when parsing something as simple as <p :foo="bar">content</p>, and I've found that you can circumvent the Julia restart requirement by using empty!(EzXML.XML_GLOBAL_ERROR_STACK) though this is hardly an ideal solution.

Ooh thanks @jvkerckh I didn't put together than the global stack never is cleared. This is pretty tricky because I was reading through XML files in a loop (parallelized to make it more complicated) with a try catch block to let errors go. But as soon as one document errored, the rest in that session would as well.
I feel like it would be very helpful if that was documented, or in the @assert when the error is declared, reminding people to clear the variable before parsing a new document.
Otherwise a very useful package :-)


fix: add jsonc-parser

launch.json is jsonc and we crash trying to patch it.

dragons trying to compile in this module.


Fix Hubot restart command

In my ST2 installation (Ubuntu 14.04, using 'curl -sSL https://install.stackstorm.com/ | sudo sh'), the Hubot instance runs in a Docker container, and is controlled via /etc/init.d/docker-hubot.

Since Docker is our default now, makes sense.

@saintaardvark Thanks!


Add mac customization

I have missed it but it seems an automatic formatter messed around a bit, for example:
  if [[ -n $long_usage ]]; then
    printf "dcu logo - Insert custom logo boot splash into firmware image\n"
    echo

  else
    printf "dcu logo - Insert custom logo boot splash into firmware image\n"
    echo

  fi

changed to:
  printf "dcu logo - Insert custom logo boot splash into firmware image\n\n"

Should I restore those changes?

Merged (forgot to push this branch before fastforwarding main, so github didn't count is as a merge...)


[UPDATE] - Robolectric Version Update

This is a minor release, in which ShadowActivityManager contained a reference to android.app.ApplicationExitInfo, introduced in SDK 30, in public method. This caused shadowOf to fail if the target SDK was < 30.

Thx. I do need to set up CI for this lib I think

Thx. 👍🏼


Refactor services usage report query to use derived tables

Services usage query
Services usage JIRA ticket in UXPROD

Work is done on this, but will wait to commit and PR until PR adjusting directory structure is approved (https://github.com/folio-org/folio-analytics/pull/213)


Add fileName to json response for submission history

For end points:

/history/{organization}/submissions
/history/submissions

The web app needs the file name for each submission. For cases where there is no file name, the field can be left out or set to an empty string

The field is called external_name and is in the action table as a column.   (For some reason I forgot to put its in the action_response json; it needs to go there too; we could do that as part of this ticket, or as a follow-on)
Please call it externalName not fileName.   Its just a descriptive string, useful to the sender, that they attach to the POSTed payload.   Usually that's a filename, but doesn't have to be.

Hey @jh765 I’m using ZenHub in GitHub, click this link to join my workspace and see other features available in GitHub or download the ZenHub extension and sign up with your GitHub account.
Posted using ZenHub

First Comment - this is from github.com.  I'll also try from Zenhub.  If you read this, it worked.


Updated with new callback functionality using callback holding

Updated to document new functionality, approved by Brian Spencer

Need to clean up and redo this PR.


Tweaks to the code from work done at ATF

This adds e.g. an optional trigger delay to let the beam feedback system update

The commits were included in #45.