etcdserver: adjust proposal timeout based on config

It uses heartbeat interval and election timeout to estimate the
expected commit delay and reasonable timeout to wait for a request to be
committed. This PR helps etcd to have reasonable timeout under high
roundtrip-time environment, e.g., globally-deployed cluster.
For fully runnable global etcd cluster, etcd needs to extend rafthttp timeout too. I will follow up it.
for #964

I change the way to calculate the value based on discussion. moreover, set child context that use maxOpTimeout to fail the request, so there is no need to let externals know about details about request timeout.

LGTM

updated based on comments. Could you double-check it meets your expectation? /cc @xiang90

I am totally confused. This pull request should simply change the previous fixed timeout to a tick based timeout. Why do we have to change other stuff?

make it separate now:
etcdserver: adjust commit timeout based on config …
It uses heartbeat interval and election timeout to estimate the
commit timeout for internal requests.
etcdhttp: adjust operation timeout based on config …
It uses heartbeat interval and election timeout to estimate the
expected operatioin timeout to commit request.

LGTM


Notebook document metadata: optional execution count

Issue Type: Feature Request
Currently we always the execution count placeholder [ ] when a cell is not focused/hovered, and switch to a play button when it's focused/hovered. However for GitHub issues notebook, the execution count doesn't matter at all, you can declare a macro in one cell and use it in another cell, the second cell doesn't depend on the first cell being executed.
My proposal is having a document level metadata to control if execution_count will be ever set. If no, then we don't show the [ ] placeholder.
VS Code version: Code - OSS Dev 1.44.0 (Commit unknown, Date unknown)
OS version: Darwin x64 19.2.0

Could also just not show [  ] when executionOrder is undefined, then that notebook could never set it. I don't know if the placeholder brackets are that helpful


[1566] Search again employing schools results

Context
https://trello.com/c/rKMIFqCd/1566-s-search-again-employing-schools-results
Changes proposed in this pull request

Split app/views/trainees/employing_schools/index.html.erb into partials: results and no_results
Add search again field to no_results partial
Update EmployingSchoolsController to handle search again operations via PUT request
Add validation to search fields
Create SchoolForm to remove code duplication in LeadSchoolForm and EmployingSchoolForm
Update rake task example_data:generate to generation fake non-lead schools

Guidance to review
Run the following code to seed the schools table and enable the feature:
Pre-steps
require_relative "config/environment"
require "factory_bot_rails"
require "faker"
FactoryBot.find_definitions rescue nil
FactoryBot.create_list(:school, 20, lead_school: true)

Add the rollowing settings to your development.local.yml:
features:
  routes:
    school_direct_salaried: true

Create a new “School direct (salaried)” trainee
Visit /trainee/<trainee_id>/employing-schools

Scenario 1 (submit form without choosing an option)

Click "Continue"
It should display the validation message "You must choose a school"

Scenario 2 (search again with no term)

Click "Search again" and click "Continue"
It should display the validation message "You much enter a search term"

Scenario 3 (search again with term)

Search again and enter say "foo"
It displays the no results page with the search again field
Click "Search again" without entering a term
It should display the validation message "You much enter a search term"
Enter the term "urn_1"
It displays a number of results

 [S] Search again (employing schools results)


RTD: Add configuration file for Read the Docs, which is mandatory now

(cherry picked from commit 0682b19872219365917d7a35390c74fc07caad21)
Backport of: #14768

After bumping to Python 3.8 (d63f458c11), and mitigating another warning (b7b40c934e4f), what's left is this
WARNING: html_extra_path entry '_extra' does not exist

-- https://readthedocs.org/projects/crate/builds/22073465/

Yay.

Can you please manually merge what is here now, @seut?

Both a18ae9f and 6321b92 address further woes around crash, so the testing process appears to be starting successfully now.
It now trips this test case, and I think it is enough for now to bring in the changes in this PR.
- Your CrateDB license is valid. Enjoy CrateDB!
+ CrateDB enterprise is not enabled. Enjoy the community edition!

-- https://jenkins.crate.io/blue/organizations/jenkins/CrateDB%2Fcrate_on_pr/detail/crate_on_pr/10354/pipeline

@mfussenegger Can you please merge this (since tests are failing, we need admin privs), please check https://github.com/crate/crate/pull/14777#issuecomment-1746398293

@mfussenegger Can you please merge this (since tests are failing, we need admin privs), please check #14777 (comment)

Can't we fix the failures? We shouldn't have release branches where tests are broken

I've fixed some other issues with sphinx

Thank you.

so what do we do with the enterprise version vs community msg, should we simply replace it in the .rst as expected result?

When there are no objections, and there are chances to fix it easily like this, please do. /cc @seut

Can't we fix the failures? We shouldn't have release branches where tests are broken.

I agree. About whether 3.3 is actually still active or not, would probably have a need to be discussed. Because there are still many people out there running CrateDB 3.3 (is it true?), it probably deserves having the documentation published at least.
So, I think fixing different kinds of build errors on 3.3 can also be scoped into a different patch, no?

Dear Marios,
your d1740f68a5d removes my b7b40c934e4fb67, which is needed to satisfy RTD, which was the original intention of this patch, see https://readthedocs.org/projects/crate/builds/22121409/.
The reason for this is another recent fixup commit on 3.3, which did not take RTD into consideration, see c2471ea15.
With kind regards,
Andreas.

Dear Marios,
your d1740f6 removes my b7b40c9, which is needed to satisfy RTD 1, which was the original intention of this patch.
The reason for this is another recent fixup commit on 3.3, which did not take RTD into consideration, see c2471ea.
With kind regards, Andreas.
Footnotes
1. https://readthedocs.org/projects/crate/builds/22121409/ [↩](#user-content-fnref-1-127d26a5eae47e4648e4cab4b3d52c18)

Then we cannot satisfy both builds?

Then we cannot satisfy both builds?

That's true, unless we dig deeper.

My proposal would be to fix RTD here, and postpone other fixup commits to make all 3.3 workflows build successfully to a subsequent patch.

Closing this in favor of masking the RTD build for CrateDB 3.3.

https://github.com/crate/distribute/pull/633


fix: Round radius token inverting

Description
Note: The original ticket is a combo of 1410 & 1409 but 1410 was closed as a duplicate with all information migrated to 1409 which is why the branch was originally named 1410.
Created a getMaxRoundRadius() util to prevent the border-radius from inverting on multiple components.
To recreate the issue navigate to the Button component in the open-source LUI storybook. In the "Component Style Theme Values" tab edit the radius to 150 and observe border-radius inversion.
References
LUI-1409
Testing

Automation

Checklist

[x] all commented code has been removed
[x] any new console issues have been resolved
[x] code linter and formatter has been run
[x] test coverage meets repo requirements
[x] PR name matches the expected semantic-commit syntax

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Test Execution Failed.

yarn lint:fix should fix any linter issues for you

@erautenberg when I take the 0 out it breaks, the behavior I'm seeing is the radius not adjusting and console errors

@ctoddy in the radius function you need to add a default, like this
export function getMaxRoundRadius(radius, width, height, offset = 0)

Test Execution Failed.

Test Execution Failed.

Test Execution Failed.

Test Execution Failed.

Test Execution Failed.

:tada: This PR is included in version @lightningjs/ui-components-v2.21.3 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Wrong test behavior of PDSUseSecHubCentralMappingInJobScenario16IntTest on local IDE execution

Situation
We test inside PDSUseSecHubCentralMappingInJobScenario16IntTest that the white list entries for reduced script environment variable inheritance work as expected.
But when the integration test PDS server is started from an IDE and not from the gradle scripts, ,the test cannot be executed, because the variables to inherit are not defined.
Currently pds_script_does_have_the_mappings_from_sechub_injected_as_environment_variables
ist just skipped in this case and a log message is done - but the test is green.
This is extreme irritating (at least for myself and I wrote this test... :flushed: )
Wanted
Throw an exception with an info about the problem. The details shall be described still in the log

Is done with
https://github.com/mercedes-benz/sechub/commit/2fc629d909c6da88387f9b5cd02ee180cfdc4936#diff-9506b523590eab82270f46c033f16d9049b5aedecf3746e1f460abf2e3bd3934


Filtering system broken

After the last updates, filtering system has broken. Whenever we scroll in the map filter paramaters doesn't apply.

Bug fixed further information can be found in the details of the commit.


AWS lib is verbose when using S3

I'm using latest version of Tensorflow with AWS S3 as a backend for models and I have those annoying logs:
[tensorflow-server-pr-14-585f869b5f-2wln8] 2018-08-27 13:51:41.183378: I external/org_tensorflow/tensorflow/core/platform/s3/aws_logging.cc:54] Found secret key
[tensorflow-server-pr-14-585f869b5f-2wln8] 2018-08-27 13:51:41.183471: I external/org_tensorflow/tensorflow/core/platform/s3/aws_logging.cc:54] Connection has been released. Continuing.
[tensorflow-server-pr-14-585f869b5f-2wln8] 2018-08-27 13:51:41.194855: I external/org_tensorflow/tensorflow/core/platform/s3/aws_logging.cc:54] Found secret key
[tensorflow-server-pr-14-585f869b5f-2wln8] 2018-08-27 13:51:41.194963: I external/org_tensorflow/tensorflow/core/platform/s3/aws_logging.cc:54] Connection has been released. Continuing.
[tensorflow-server-pr-14-585f869b5f-2wln8] 2018-08-27 13:51:41.206484: I external/org_tensorflow/tensorflow/core/platform/s3/aws_logging.cc:54] Found secret key
[tensorflow-server-pr-14-585f869b5f-2wln8] 2018-08-27 13:51:41.206714: I external/org_tensorflow/tensorflow/core/platform/s3/aws_logging.cc:54] Connection has been released. Continuing.
[tensorflow-server-pr-14-585f869b5f-2wln8] 2018-08-27 13:51:41.212817: E external/org_tensorflow/tensorflow/core/platform/s3/aws_logging.cc:60] No response body. Response code: 404
[tensorflow-server-pr-14-585f869b5f-2wln8] 2018-08-27 13:51:41.212852: W external/org_tensorflow/tensorflow/core/platform/s3/aws_logging.cc:57] If the signature check failed. This could be because of a time skew. Attempting to adjust the signer.
The server is working as expected though. I set the log level to ERROR only but still the 404 error is happening more than every second.
I saw that there is an issue open in tensorflow/serving but this seems to be core/3rd party issue.
https://github.com/tensorflow/serving/issues/615
Have I written custom code: No
OS Platform and Distribution: Kubernetes 1.8 running on CENTOS
TensorFlow installed from: Docker image tensorflow/serving:1.10.1
TensorFlow version: 1.10.1
Bazel version: ??
CUDA/cuDNN version: N/A
GPU model and memory: N/A
Exact command to reproduce:
if [ -f /etc/secrets/AWS_SECRET_ACCESS_KEY.secret ]; then
    export AWS_SECRET_ACCESS_KEY=$(echo -e $(cut -d ":" -f 2 <<< $(cat /etc/secrets/AWS_SECRET_ACCESS_KEY.secret)))
fi

tensorflow_model_server --port=8500 --tensorflow_session_parallelism=1 --enable_model_warmup=true --model_config_file=${MODEL_CONFIG}

Example of model_config_file:
model_config_list: {
  config: {
    name: "model1",
    base_path: "s3://tensorflow-models/model1",
    model_platform: "tensorflow"
  },
  config: {
    name: "model2",
    base_path: "s3://tensorflow-models/model2",
    model_platform: "tensorflow"
  }
}

Mobile device: None
Thank you

Thank you for your post. We noticed you have not filled out the following field in the issue template. Could you update them if they are relevant in your case, or leave them as N/A? Thanks.
Have I written custom code
OS Platform and Distribution
TensorFlow installed from
TensorFlow version
Bazel version
CUDA/cuDNN version
GPU model and memory
Exact command to reproduce
Mobile device

Updated.

Nagging Assignee @bignamehyp: It has been 15 days with no activity and this issue has an assignee. Please update the label and/or status accordingly.

Yeah we disabled the logs completely because it was logging way too much and so we are loosing all the logging purpose now because "good" logs are being lost in false positive.
thank you.

Nagging Assignee @bignamehyp: It has been 14 days with no activity and this issue has an assignee. Please update the label and/or status accordingly.

Any update on this?

Nagging Assignee @bignamehyp: It has been 14 days with no activity and this issue has an assignee. Please update the label and/or status accordingly.

Nagging Assignee @bignamehyp: It has been 29 days with no activity and this issue has an assignee. Please update the label and/or status accordingly.

Nagging Assignee @bignamehyp: It has been 44 days with no activity and this issue has an assignee. Please update the label and/or status accordingly.

I am getting this :
2019-03-19 14:14:15.095336: I tensorflow/core/platform/s3/aws_logging.cc:54] Connection has been released. Continuing.
2019-03-19 14:14:15.609993: I tensorflow/core/platform/s3/aws_logging.cc:54] Connection has been released. Continuing.
2019-03-19 14:14:16.813516: I tensorflow/core/platform/s3/aws_logging.cc:54] Connection has been released. Continuing.
2019-03-19 14:14:17.289853: I tensorflow/core/platform/s3/aws_logging.cc:54] Connection has been released. Continuing.
2019-03-19 14:14:17.804022: I tensorflow/core/platform/s3/aws_logging.cc:54] Connection has been released. Continuing.
2019-03-19 14:14:18.303771: I tensorflow/core/platform/s3/aws_logging.cc:54] Connection has been released. Continuing.
2019-03-19 14:14:19.577461: I tensorflow/core/platform/s3/aws_logging.cc:54] Connection has been released. Continuing.
2019-03-19 14:14:20.058953: I tensorflow/core/platform/s3/aws_logging.cc:54] Connection has been released. Continuing.
2019-03-19 14:14:20.533169: I tensorflow/core/platform/s3/aws_logging.cc:54] Connection has been released. Continuing.
2019-03-19 14:14:21.008386: I tensorflow/core/platform/s3/aws_logging.cc:54] Connection has been released. Continuing.

Actually more than 500 of these. Can anybody let me know how do I disable this log? or a workaround for this?

I am getting this : :cry:
2019-03-19 14:14:15.095336: I tensorflow/core/platform/s3/aws_logging.cc:54] Connection has been released. Continuing.
2019-03-19 14:14:15.609993: I tensorflow/core/platform/s3/aws_logging.cc:54] Connection has been released. Continuing.
2019-03-19 14:14:16.813516: I tensorflow/core/platform/s3/aws_logging.cc:54] Connection has been released. Continuing.
2019-03-19 14:14:17.289853: I tensorflow/core/platform/s3/aws_logging.cc:54] Connection has been released. Continuing.
2019-03-19 14:14:17.804022: I tensorflow/core/platform/s3/aws_logging.cc:54] Connection has been released. Continuing.
2019-03-19 14:14:18.303771: I tensorflow/core/platform/s3/aws_logging.cc:54] Connection has been released. Continuing.
2019-03-19 14:14:19.577461: I tensorflow/core/platform/s3/aws_logging.cc:54] Connection has been released. Continuing.
2019-03-19 14:14:20.058953: I tensorflow/core/platform/s3/aws_logging.cc:54] Connection has been released. Continuing.
2019-03-19 14:14:20.533169: I tensorflow/core/platform/s3/aws_logging.cc:54] Connection has been released. Continuing.
2019-03-19 14:14:21.008386: I tensorflow/core/platform/s3/aws_logging.cc:54] Connection has been released. Continuing.

Actually, more than 500 of these. :face_with_head_bandage:
Can anybody let me know how do I disable this log (Only this, if possible)? or a possible workaround for this?
Thanks.

This issue seems to be quite stale by now, but the problem still persists, at least for me. Has there been any kind of fix yet?

@prameshbajra As a workaround, I just filter these messages with grep :)
python train.py 2>&1 | grep -v "Connection has been released. Continuing."

2>&1 | grep -v "Connection has been released. Continuing."

Nice workaround. Do you know how I could extend this to filter out multiple messages (e.g. "Found secret key", "No response body. Response: code 404" etc. also pop up for me)

https://github.com/tensorflow/tensorflow/pull/24088#issuecomment-484648955

See also https://github.com/tensorflow/serving/issues/789

@ymodak this can be closed since #24088

Closing this issue since the PR has been merged. Thanks!

The solution here is to set the logging level for AWS, taken from the PR:
export AWS_LOG_LEVEL=3

I use TF_CPP_MIN_LOG_LEVEL=3 and it works too.

Hi,
I have the same problem during training, using 1.15. I'm saving logs and checkpoint to s3 bucket, because I use sagemaker for training and want to use tensorboard in real time. Are you sure that increasing the log level is the right solution? What I  understand  from that errors is that tensorflow is continuously polling the S3 filesystem.. is that right? Problem is that s3 charge you for this read operations, and can lead to unexpected high bills from AWS.. Is there any way to stop this polling during training ?


Problem with multiple database connections

I have a strange problem if I add config/database.php file to my Lumen installation. Even if I don't use any database connection my service returns an invalid image.
I have route:
$router->get('photo', function () use ($router) {
  // create a new empty image resource
  Image::configure(array('driver' => 'imagick'));
  $img = Image::canvas(200, 200, '#ff0000');
  return $img->response('png');
});

in my basic lumen installation and everything works as expected.
When I try to add config/database.php file to tailor my database connections (I need to connect to 2 databases at once), even if it is an empty file or copy of vendor/laravel/lumen-framework/config/database.php my route return an invalid base64 encoded image and I can't display it anymore.
It is easy reproducable. Just create new lumen project,
require intervention/image and register ImageServiceProvider in the bootstrap/app.php and add route.
I'm using php 7.4 with Apache on Arch Linux (updated).
My composer.json:
{
    "name": "laravel/lumen",
    "description": "The Laravel Lumen Framework.",
    "keywords": ["framework", "laravel", "lumen"],
    "license": "MIT",
    "type": "project",
    "require": {
        "php": "^7.3|^8.0",
        "intervention/image": "^2.5",
        "laravel/lumen-framework": "^8.0"
    },
    "require-dev": {
        "fzaninotto/faker": "^1.9.1",
        "mockery/mockery": "^1.3.1",
        "phpunit/phpunit": "^9.3"
    },
    "autoload": {
        "psr-4": {
            "App\\": "app/"
        }
    },
    "autoload-dev": {
        "classmap": [
            "tests/"
        ]
    },
    "config": {
        "preferred-install": "dist",
        "sort-packages": true,
        "optimize-autoloader": true
    },
    "minimum-stability": "dev",
    "prefer-stable": true,
    "scripts": {
        "post-root-package-install": [
            "@php -r \"file_exists('.env') || copy('.env.example', '.env');\""
        ]
    }
}

returns an invalid image.

Any errors? Exceptions? Anything in the logfile?

Nothing at all. I', using Firefox's extension RESTClient to test my services and, without database.php file it displays the image as it should, but just with the
<?php
?>

code in the config/database.php file, response changes from:
data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAAMgAAADIAQMAAACXljzdAAAABGdBTUEAALGPC/xhBQAAACBjSFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAABlBMVEX/AAD///9BHTQRAAAAAWJLR0QB/wIt3gAAABxJREFUWMPtwYEAAAAAw6D5U1/hAFUBAAAAAHwGFFAAAQCfIxUAAAAASUVORK5CYII=
to:
data:image/png;base64,DQqJUE5HDQoaCgAAAA1JSERSAAAAyAAAAMgBAwAAAJeWPN0AAAAEZ0FNQQAAsY8L/GEFAAAAIGNIUk0AAHomAACAhAAA+gAAAIDoAAB1MAAA6mAAADqYAAAXcJy6UTwAAAAGUExURf8AAP///0EdNBEAAAABYktHRAH/Ai3eAAAAHElEQVRYw+3BgQAAAADDoPlTX+EAVQEAAAAAfAYUUAABAJ8jFQAAAABJRU5ErkJggg==
Very strange.

Here is my bootstrap/app.php file content just in case:
<?php

require_once __DIR__.'/../vendor/autoload.php';

(new Laravel\Lumen\Bootstrap\LoadEnvironmentVariables(
    dirname(__DIR__)
))->bootstrap();

date_default_timezone_set(env('APP_TIMEZONE', 'UTC'));

/*
|--------------------------------------------------------------------------
| Create The Application
|--------------------------------------------------------------------------
|
| Here we will load the environment and create the application instance
| that serves as the central piece of this framework. We'll use this
| application as an "IoC" container and router for this framework.
|
*/

$app = new Laravel\Lumen\Application(
    dirname(__DIR__)
);

$app->withFacades();

$app->withEloquent();

/*
|--------------------------------------------------------------------------
| Register Container Bindings
|--------------------------------------------------------------------------
|
| Now we will register a few bindings in the service container. We will
| register the exception handler and the console kernel. You may add
| your own bindings here if you like or you can make another file.
|
*/

$app->singleton(
    Illuminate\Contracts\Debug\ExceptionHandler::class,
    App\Exceptions\Handler::class
);

$app->singleton(
    Illuminate\Contracts\Console\Kernel::class,
    App\Console\Kernel::class
);

/*
|--------------------------------------------------------------------------
| Register Config Files
|--------------------------------------------------------------------------
|
| Now we will register the "app" configuration file. If the file exists in
| your configuration directory it will be loaded; otherwise, we'll load
| the default version. You may register other files below as needed.
|
*/

$app->configure('app');
$app->configure('database');

/*
|--------------------------------------------------------------------------
| Register Middleware
|--------------------------------------------------------------------------
|
| Next, we will register the middleware with the application. These can
| be global middleware that run before and after each request into a
| route or middleware that'll be assigned to some specific routes.
|
*/

// $app->middleware([
//     App\Http\Middleware\ExampleMiddleware::class
// ]);

// $app->routeMiddleware([
//     'auth' => App\Http\Middleware\Authenticate::class,
// ]);

/*
|--------------------------------------------------------------------------
| Register Service Providers
|--------------------------------------------------------------------------
|
| Here we will register all of the application's service providers which
| are used to bind services into the container. Service providers are
| totally optional, so you are not required to uncomment this line.
|
*/

// $app->register(App\Providers\AppServiceProvider::class);
// $app->register(App\Providers\AuthServiceProvider::class);
$app->register(Intervention\Image\ImageServiceProvider::class);

if (!class_exists('Image')) {
    class_alias('Intervention\Image\Facades\Image', 'Image');
}

/*
|--------------------------------------------------------------------------
| Load The Application Routes
|--------------------------------------------------------------------------
|
| Next we will include the routes file so that they can all be added to
| the application. This will provide all of the URLs the application
| can respond to, as well as the controllers that may handle them.
|
*/

$app->router->group([
    'namespace' => 'App\Http\Controllers',
], function ($router) {
    require __DIR__.'/../routes/web.php';
});

return $app;

I'm sorry, I just accidentally  closed it.

I have just discovered that if I remove first blank line from the config/database.php file everything works fine. I have no idea why this is happening and I find it very odd. I have lost few days trying to figure it out.
I'm closing this thread.


[FEATURE] Enhance UI and functionality of the landing page and integrate docs and blogs into a docusaurus project to enhance docs capabilities

Is there an existing feature request for this?

[X] I have searched the existing feature requests

Is your feature request related to a problem or use-case? Please describe.
shipwright.io has a very static landing page that doesn't serve much functionality or information regarding the Shipwright Project. Docs website is written in Hugo but it can be better written in documentation oriented frontend frameworks like Docusaurus.
Describe the solution that you would like.

Enhance UI of the landing page
Convert the docs portion into a docusaurus project
add additional functionalities like search, indexing, light/dark mode, easy navigation etc. (all easily achievable out of the box in docusaurus)

NOTE - Our goal is to utilize as much of the existing project and documentation and hence we want to have a .md file parser kind of approach, where simply adding a new .md file in the folders will add a new page and any changes in the files should automatically be reflected in the website (might need to setup a small deployment pipeline)
Describe alternatives you have considered.
No response
Anything else?
No response

/assign

/assign NAMANIND

I dont think there is consensus on Docusaurus, so this should not be a goal at the moment, neither moving out of Docsy. @ayushsatyam146 please rewrite your issue with more clear goals.

I took a quick look at Docusaurus - I'm a bit ambivalent to be honest. Its feature set is more or less identical to our current Hugo + Docsy stack. Our site provider - Netlify - supports Docusaurus as a static site generator, so there's no sysadmin blocker there. My quick pros + cons:
Pro:

React based, thus technical contributions from front-end web designers might be easier. Also supports more sophisticated content pages with MDX.
Primary support for multi-versioned docs. For Docsy + Hugo this is kind of bolted on and free-form.
Stronger support for internationalization.

Con:

Switching cost - someone needs to port what we have over to Docusaurus
Contributor base - many CNCF projects use the Hugo + Docsy stack. Technical writers/UX experts may be less familiar with Docusaurus (use of React mitigates this?)

@adambkaplan thanks for handling this the proper way :) . I'm meeting tomorrow with @Adarsh-jaiss  , we will work on a document to have a UI proposal based on my recent work and his investigations for next Monday. @ayushsatyam146 do you want to join us?

Hi @qu1queee it would be hard for me to join. I will connect with @Adarsh-jaiss later on for the updates. Thanks

Here's the summary website call 20th september : https://docs.google.com/document/d/1Hnpv8zow-Lg9DiqaNRFonQlZSUbZyF6hTVRHYdJ_3xw/edit?usp=sharing

Hello Team, We had another call for the website design on 27th September in which we discussed about the Front page design which includes header, navbar and homepage. Feel free to check it out the meeting minutes here : https://docs.google.com/document/d/1Hnpv8zow-Lg9DiqaNRFonQlZSUbZyF6hTVRHYdJ_3xw/edit?usp=sharing


HttpClient Factory docs should talk about alternatives

We frequently get feedback from users that they want a way to avoid socket exhaustion issues without using HttpClient Factory. We should add information about how to do this to the docs.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 881cef77-11ef-ac11-06d0-0996a1ccfa1b
Version Independent ID: 3d356334-e672-7e8b-1fef-7944ebee99eb
Content: Make HTTP requests using IHttpClientFactory in ASP.NET Core
Content Source: aspnetcore/fundamentals/http-requests.md
Product: aspnet-core
Technology: aspnetcore-fundamentals
GitHub Login: @stevejgordon
Microsoft Alias: scaddie

@rynowak can you provide a draft how to do that?

I sent a PR 😁


Class Module ServiceProvider not found

hi,
I would like to ask about this problem.
I able to create a module named Teacher using this command php artisan module:make Teacher. However, when I create another module or even run php artisan serve it shows me this error.
[Symfony\Component\Debug\Exception\FatalThrowableError]
Class 'Modules\Teacher\Providers\TeacherServiceProvider' not found
Every command I tried but it shows me the same error I even tried php artisan.
I already added this  'Module' => Nwidart\Modules\Facades\Module::class, to aliases and Nwidart\Modules\LaravelModulesServiceProvider::class, to  provider.
please help me , thank you.

Hello,
That means your module was created, the package found your service provider, but composer wasn't able to load the service provider.
Meaning you probably forgot to add the psr-4 part of the documentaiton.

Thank you for the response.
Im done with psr-4 but the error is still there.
This is my code in composer.json
{
"name": "laravel/laravel",
"description": "The Laravel Framework.",
"keywords": ["framework", "laravel"],
"license": "MIT",
"type": "project",
"require": {
"php": ">=5.6.4",
"laravel/framework": "5.4.",
"laravel/tinker": "~1.0",
"nwidart/laravel-modules": "^1.27"
},
"require-dev": {
"fzaninotto/faker": "~1.4",
"mockery/mockery": "0.9.",
"phpunit/phpunit": "~5.7"
},
"autoload": {
"classmap": [
"database/seeds",
"database/factories"
],
"psr-4": {
"App\": "app/",
"Modules\": "Modules/"
}
},
"autoload-dev": {
"psr-4": {
"Tests\": "tests/"
}
},
"scripts": {
"post-root-package-install": [
"php -r "file_exists('.env') || copy('.env.example', '.env');""
],
"post-create-project-cmd": [
"php artisan key:generate"
],
"post-install-cmd": [
"Illuminate\Foundation\ComposerScripts::postInstall",
"php artisan optimize"
],
"post-update-cmd": [
"Illuminate\Foundation\ComposerScripts::postUpdate",
"php artisan optimize"
]
},
"config": {
"preferred-install": "dist",
"sort-packages": true,
"optimize-autoloader": true
}
}

'composer update' should fix your issue.

or dump autoload (which is run after an update).

I found same issue https://github.com/nWidart/laravel-modules/issues/4, same solution as you have just suggested,this fixed my problem. Thank you

Cool.
I've added this info on the readme and documentation website. 👍

hi,
i have this problem in my app laravel5.4 itried to display the output but i get an error of app\Instructor not found still i define it at the top
<?php
namespace App\Http\Controllers;

use Illuminate\Http\Request;
use app\Instructor;

class CreatesController extends Controller
{
   public function home(){
       $instructors=Instructor::all();
       print_r($instructors);

          }
   }

Arguments
"Class 'app\Instructor' not found"

Oh, i had this same issue, as @nWidart  pointed out, I forgot to add "Modules\\": "Modules/" to my composer.json. As soon as i added it and did composer dump-autoload, it works.
Thanks for the awesome package @nWidart

Great...I had the same issue but it is all fixed now. Thanks @nWidart

nice guys

Hey Guys, I have a question regarding the usage of namespace (with the laravel-module package). Is that we're tied to using the namespace "Modules" instead of the Developer's name as per below;
"Modules\Activity\Providers\ActivityServiceProvider" instead of "DeveloperName\Activity\Providers\ActivityServiceProvider"

return [

    /*
    |--------------------------------------------------------------------------
    | Module Namespace
    |--------------------------------------------------------------------------
    |
    | Default module namespace.
    |
    */

    'namespace' => 'Modules',

You can config namespace before create new module, It is DeveloperName

return [

    /*
    |--------------------------------------------------------------------------
    | Module Namespace
    |--------------------------------------------------------------------------
    |
    | Default module namespace.
    |
    */

    'namespace' => 'Modules',

You can config namespace before create new module, It is DeveloperName

Thanks @SocolaDaiCa. That's what I thought but when I change it I get Class "KerwinEllis\Listing\Providers\ListingServiceProvider" not found.

{
  "autoload": {
    "psr-4": {
      "App\\": "app/",
      "Modules\\": "Modules/",
      "KerwinEllis\\": "Modules/"
    }
  }
}

you need config autoload

after that, maybe need run composer dumpautoload

,
"KerwinEllis\": "Modules/"

Aha, it worked, @SocolaDaiCa thanks a million

Thank you.It worked for me also

Hi, i have  problem when testing my laravel api in postman
i am getting this error"
Error: Class "App\Models\ServiceProvider" not found in file C:\xampp\htdocs\GMS\adminS-laravel\app\Http\Controllers\Api\FormSubmissionController.php on line 22" however i have configured everything that needs to be configured .please help me fix this error

how to fix it Class "Modules\Products\Providers\ProductsServiceProvider" not found in laravel 11

how to fix it Class "Modules\Products\Providers\ProductsServiceProvider" not found in laravel 11

ensure you've updated composer:

from v11.0 autoloading "Modules\": "modules/", is no longer required.

By default, the module classes are not loaded automatically. You can autoload your modules by adding merge-plugin to the extra section:
"extra": {
    "laravel": {
        "dont-discover": []
    },
    "merge-plugin": {
        "include": [
            "Modules/*/composer.json"
        ]
    }
},

Tip: don't forget to run composer dump-autoload afterwards

how to fix it Class "Modules\Products\Providers\ProductsServiceProvider" not found in laravel 11

same issue on laravel 11

"merge-plugin": {
"include": [
"Modules/*/composer.json"
]
}

its work , Thank you

Run the command: artisan module:publish
Add the "namespace" variable to the items in the "generator" array.

The team forgot about PSR-4 with PHP 8.2.

Done, tnks
On Thu, Mar 28, 2024, 12:22 PM Jonatas Miler Oliveira <
@.***> wrote:

Run the command: artisan module:publish
Add the "namespace" variable to the items in the "generator" array.
image.png (view on web)
https://github.com/nWidart/laravel-modules/assets/18699320/77055a84-2507-4e01-8613-87670d25a8fc
The team forgot about PSR-4 with PHP 8.2.
—
Reply to this email directly, view it on GitHub
https://github.com/nWidart/laravel-modules/issues/283#issuecomment-2024368539,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ATCCOZAWISR4QTWZHURY2OTY2OLG5AVCNFSM4DUFBMEKU5DIOJSWCZC7NNSXTN2JONZXKZKDN5WW2ZLOOQ5TEMBSGQZTMOBVGM4Q
.
You are receiving this because you commented.Message ID:
@.***>

In Laravel 11 and Laravel Module 11,
ensure that "wikimedia/composer-merge-plugin" is set to true in composer.json,
like this:
    "config": {
        "optimize-autoloader": true,
        "preferred-install": "dist",
        "sort-packages": true,
        "allow-plugins": {
            "pestphp/pest-plugin": true,
            "php-http/discovery": true,
            "wikimedia/composer-merge-plugin": true
        }
    },

PS C:\Users\MagamyGBANEADJA\OneDrive - FINACTU INTERNATIONAL\Bureau\example-modulaire-app> composer update
Loading composer repositories with package information
Updating dependencies
Nothing to modify in lock file
Installing dependencies from lock file (including require-dev)
Nothing to install, update or remove
Generating optimized autoload files
Class Modules\Auth\Http\Controllers\AuthController located in ./Modules/Auth/app/Http/Controllers/AuthController.php does not comply with psr-4 autoloading standard (rule: Modules\ => ./Modules). Skipping.
Class Modules\Auth\Providers\AuthServiceProvider located in ./Modules/Auth/app/Providers/AuthServiceProvider.php does not comply with psr-4 autoloading standard (rule: Modules\ => ./Modules). Skipping.
Class Modules\Auth\Providers\EventServiceProvider located in ./Modules/Auth/app/Providers/EventServiceProvider.php does not comply with psr-4 autoloading standard (rule: Modules\ => ./Modules). Skipping.
Class Modules\Auth\Providers\ModuleServiceProvider located in ./Modules/Auth/app/Providers/ModuleServiceProvider.php does not comply with psr-4 autoloading standard (rule: Modules\ => ./Modules). Skipping.
Class Modules\Auth\Providers\RouteServiceProvider located in ./Modules/Auth/app/Providers/RouteServiceProvider.php does not comply with psr-4 autoloading standard (rule: Modules\ => ./Modules). Skipping.
Class Modules\Auth\Database\Seeders\AuthDatabaseSeeder located in ./Modules/Auth/database/seeders/AuthDatabaseSeeder.php does not comply with psr-4 autoloading standard (rule: Modules\ => ./Modules). Skipping.

Illuminate\Foundation\ComposerScripts::postAutoloadDump
@php artisan package:discover --ansi

Error
Class "Modules\Auth\Providers\AuthServiceProvider" not found
at vendor\laravel\framework\src\Illuminate\Foundation\ProviderRepository.php:206
202▕      * @return \Illuminate\Support\ServiceProvider
203▕      */
204▕     public function createProvider($provider)
205▕     {
➜ 206▕         return new $provider($this->app);
207▕     }
208▕ }
209▕
1   vendor\laravel\framework\src\Illuminate\Foundation\ProviderRepository.php:142
Illuminate\Foundation\ProviderRepository::createProvider("Modules\Auth\Providers\AuthServiceProvider")
2   vendor\laravel\framework\src\Illuminate\Foundation\ProviderRepository.php:61
Illuminate\Foundation\ProviderRepository::compileManifest()


Added deviceOrientationsDuringFullScreen

Hi, could you please resolve this conflicts and maybe this will be merged? :)

Duplicate of: https://github.com/brianegan/chewie/pull/289
Please follow that PR for updates 👍

Resolved till version 0.10.0: https://github.com/brianegan/chewie/pull/289#discussion_r425863038


Hedge/ Fixes

Before submitting this PR, please make sure:

[X] Your code builds clean without any errors or warnings
[X] You are using the approved title ("feat/", "fix/", "docs/", "refactor/")

A description of the changes proposed in the pull request:
Add more info to facilitate debugging.

Refactor the status screen and add more information and log
fixed position name referring to True and False to ONE-WAY and HEDGE
Fixed issues related to typing
for hedge by amount,
a. change the matching of pairs from the match by trading pair to match by base asset
b. change hedge price calculation for hedge by amount to use mid price instead of vwap price.

Tests performed by the developer:
Tips for QA testing:

@JeremyKono @rapcmia Can I check what is the process to get this merged now?

Hi @leastchaos good day to you,
Apologies I may have overlooked this PR and added to the board earlier. I assume we can have this merge since its fix for community strategy however I have to confirm with the team. I will get back to you

In behalf of Foundation team we merged this PR to development and will be included on the next Hummingbot version 1.12.0


Value for some settings are cut off (regardless of the window size)

Describe the Bug
See screenshot. Setting: 'Icon scale'
Steps to reproduce the behavior:

Go to 'Settings' tab.
Click on 'Center Appearance' (for example).

Expected Behavior
Full view of setting.
System
Please complete the following information:

Fedora 32
Fly-Pie version: Can't find it in the settings but the current one from extensions.gnome
Gnome Shell version: 3.36.6

Which GTK-Theme are you using?  I looks good on my end with all themes I tried smile

I am using Vimix but switching to Adwaita fixed it. So I am closing this issue.


perf(mempool/cache): clear map in Reset

instead of allocating a new one
Closes #2243
It should not be backported onto <= v0.37 because their min Go version is 1.20, and clear was introduced in Go 1.21.

PR checklist

[ ] Tests written/updated
[ ] Changelog entry added in .changelog (we use unclog to manage our changelog)
[ ] Updated relevant documentation (docs/ or spec/) and code comments
[x] Title follows the Conventional Commits spec

Thanks for this change @melekes!


python310Packages.aiobotocore: 2.4.0 -> 2.4.1

Automatic update generated by nixpkgs-update tools. This update was made based on information from passthru.updateScript.
meta.description for python310Packages.aiobotocore is: "Python client for amazon services"
meta.homepage for python310Packages.aiobotocore is: "https://github.com/aio-libs/aiobotocore"
meta.changelog for python310Packages.aiobotocore is: ""
Updates performed

Ran passthru.UpdateScript

To inspect upstream changes
Impact

Checks done (click to expand)

built on NixOS
The tests defined in passthru.tests, if any, passed
found 2.4.1 with grep in /nix/store/38p4n575l1lmv90fff8qsn52bgfa1cr8-python3.10-aiobotocore-2.4.1
found 2.4.1 in filename of file in /nix/store/38p4n575l1lmv90fff8qsn52bgfa1cr8-python3.10-aiobotocore-2.4.1

Rebuild report (if merged into master) (click to expand)

6 total rebuild path(s)

6 package rebuild(s)

First fifty rebuilds by attrpath
dvc-with-remotes
home-assistant-component-tests.aws
python310Packages.aiobotocore
python310Packages.s3fs
python39Packages.aiobotocore
python39Packages.s3fs

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/38p4n575l1lmv90fff8qsn52bgfa1cr8-python3.10-aiobotocore-2.4.1 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A python310Packages.aiobotocore https://github.com/r-ryantm/nixpkgs/archive/16b5c395b3ec41d1c2f344caefa763612d00fddc.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/38p4n575l1lmv90fff8qsn52bgfa1cr8-python3.10-aiobotocore-2.4.1
ls -la /nix/store/38p4n575l1lmv90fff8qsn52bgfa1cr8-python3.10-aiobotocore-2.4.1/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

6 packages built:

dvc-with-remotes
home-assistant-component-tests.aws
python310Packages.aiobotocore
python310Packages.s3fs
python39Packages.aiobotocore
python39Packages.s3fs

Maintainer pings
cc @teh for testing.

Result of nixpkgs-review pr 204215 run on x86_64-linux 1

6 packages built:

dvc-with-remotes
home-assistant-component-tests.aws
python310Packages.aiobotocore
python310Packages.s3fs
python39Packages.aiobotocore
python39Packages.s3fs


[Needs 🕵♂] Combatify forge mod - Incompat with BetterEnd

Mod Name
Combatify
Mod Homepage
https://legacy.curseforge.com/minecraft/mc-mods/combatify
Describe the bug
Bug Listed Below
Steps to reproduce
https://github.com/Alexandra-Myers/Combatify/issues/44#
Logs
n/a
Additional context
No response

Still persists in beta.11
There isn't a crash-report provided since 'Exit Code: 1' occurred.
Needs further investigation as title suggests, perhaps Sinytra has a debugger that logs more info?
The debug log is all the info I got, sadly.. but I still believe it has something to do with

MobEffectMixin from mixins.atlascombat.json into net.minecraft.world.effect.MobEffect

debug from today using beta.11:
https://gist.github.com/Cixon/74c5abf3c05cd35f515f370922ede738


Possible bug in Recurrence class

Hi all,
here is a possible bug in Recurrence class:
https://github.com/OfficeDev/ews-java-api/blob/master/src/main/java/microsoft/exchange/webservices/data/property/complex/recurrence/pattern/Recurrence.java
MonthlyPattern and YearlyPattern methods try to read XML value using int.class instead of Integer.class.
reader.readElementValue(int.class);

Correct form should be (used everywhere else in the class):
reader.readElementValue(Integer.class);

This had caused errors in my tests by getting this types of recurrence pattern.
Methods using int.class to read XML

MonthlyPattern

https://github.com/OfficeDev/ews-java-api/blob/master/src/main/java/microsoft/exchange/webservices/data/property/complex/recurrence/pattern/Recurrence.java#L557

https://github.com/OfficeDev/ews-java-api/blob/master/src/main/java/microsoft/exchange/webservices/data/property/complex/recurrence/pattern/Recurrence.java#L586

YearlyPattern

https://github.com/OfficeDev/ews-java-api/blob/master/src/main/java/microsoft/exchange/webservices/data/property/complex/recurrence/pattern/Recurrence.java#L1370

https://github.com/OfficeDev/ews-java-api/blob/master/src/main/java/microsoft/exchange/webservices/data/property/complex/recurrence/pattern/Recurrence.java#L1370

@itbw will you provide a PR?


support rocket mq plugin

Here is the sync call:

Here is the async call:

Coverage increased (+0.2%) to 18.142% when pulling 51b6d906b35333dcc01f630b851def423608cae0 on ascrutae:feature/support-rocketMQ-plugin into a1276c86a5f78e3a104510b0c5bc009667ab4f55 on OpenSkywalking:master.

I had change the operation name and pull the snapshots of trace segment

Coverage increased (+0.2%) to 18.147% when pulling 30dbdc82645ef4a538dffb125d9bddaf063cc47e on ascrutae:feature/support-rocketMQ-plugin into a1276c86a5f78e3a104510b0c5bc009667ab4f55 on OpenSkywalking:master.

@ascrutae You are facing a conflict.

@ascrutae Since PMC has decided to move on 5.x , @hanahmily will lead the new UI, so I will merge this as a provided plugin.

Coverage increased (+0.1%) to 23.133% when pulling bfbf7aebc9014aac3b90c4309c89694d639f49a1 on ascrutae:feature/support-rocketMQ-plugin into 986700ea2f18e34a2c071a0b9764a17330f615bb on OpenSkywalking:master.

Coverage increased (+0.1%) to 23.125% when pulling 1fa81783f79483ea95ef8113cf812578f1d003a3 on ascrutae:feature/support-rocketMQ-plugin into 986700ea2f18e34a2c071a0b9764a17330f615bb on OpenSkywalking:master.


Using MS Graph to fetch email

I am a beginner of using SPFX but i want to learn.
I have followed the instructions in this example but it does not work OK.
I can add the webpart in a SharePoint page but I get no emails from my inbox.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 642064a1-1971-d88b-6eeb-3bcde4333383
Version Independent ID: 11fbb2ac-f682-e963-a07a-a28c9cb3d9d8
Content: Building SharePoint Framework solutions, which use Microsoft Graph APIs
Content Source: docs/spfx/web-parts/get-started/using-microsoft-graph-apis.md
Product: sharepoint
Technology: sharepoint-framework
GitHub Login: @spdevdocs
Microsoft Alias: spdevdocs

Hi, thank you for the comment. Can you provide a bit more information about your environment (What version of SharePoint, What Version of SPFx).
Also if possible, could you provide any errors in your console that may be present in your developer tools when the web part loads? (Access Developer tools by using F12 in your browser)

Hi
I have just started to learn about SPFx so any help is appreciated.
I use SharePoint Online.
Please see SPFx info below.

I get error when using F12. But I am not sure how to correct them.

Hi
One further notice is that it differs depending on what browser I use.
So far I have only tested in new Edge browser.
But when I use Google Chrome then the values for subject is present.

To confirm: You are saying that the Graph Calls when using Edge are not working?

Hi
The webpart works like this:
I get the email address back but not the subject value.
This is the same in both Microsoft Edge as well in Chrome.

It's strange if the email comes back, but not the subject. Sounds like it may be more of a solution issue, than a Graph issue.
Can you share your source to compare to the tutorial?

Hi, I still have the problem that I only get e-mail address back. The subject field is not returned.

Hi, it would be helpful if you could screen shot the requests in Dev Tools (F12) in both Chrome and IE. If you could, provide the Request being sent, and the response coming back in the Network Tab of Dev Tools.

Hi, I couldn't see it on my Apps Gallery to add it to my site. Why?


Packagist must be update for Laravel 5.8

As of now, the packagist supports the Laravel 5.7 version in the latest release. I ask that this be corrected.

@GrahamCampbell

I'm no longer maintaining this package. It's been handed over to new maintainers.

@GrahamCampbell - you are the account linked at Packagist - I believe you are the only one who can change the Packagist settings to the new way github requires.

@srmklive - are you the main maintainer now for this repo?
If so could you contact @GrahamCampbell & between you work out how to update the package on Packagist please.

Package is already updated for Laravel 5.8

@srmklive - https://packagist.org/packages/htmlmin/htmlmin is still at 5.7 not 5.8

It is not updated on packagist https://packagist.org/packages/htmlmin/htmlmin

@srmklive most developers use packagist to install packages from composer,
please create a new one or update previous.
thanks!

Sorry for responding late. In

@srmklive Please go to https://packagist.org/trigger-github-sync/. This should fix the issue with packagist.

Packagist is updated & is showing 5.8.0 as latest version.

Packagist is still reporting the webhook has not been updated.

This should not be so difficult to create a new release that should be done
git tag -a 5.8.0 -m "v5.8.0"
git push --tags

Webhook has been updated for Packagist.

God thank u


Feature Request: Add history for pages too

I can get at the revision data for a page by doing a custom query, which is fine, but it would be very helpful to add history data to the WikiPage class so it is easily accessible, similar to what is being done with files in the WikiFile class.
I can currently access history information for a page by doing a custom query, but if the history data can optionally be collected as part of of the getPage functionality, that would reduce the number of API calls needed if someone actually needs to collect revision data on a large number of records.

The main reason why file history was easy to add in WikiFile is that it required just a few additional parameters to the existing prop=imageinfo API call, and the results fit within the same WikiFile model.
With page revisions, although I haven't studied it in detail yet, the rvprop= API call supports its own myriad of parameters. It would take a good look at which ones fit into the WikiPage model (e.g. rvdir doesn't, I think).
I may be able to look into this further when I have time and inspiration, but since I don't need this feature myself, I won't make any promises. :wink:

You're welcome. But I prefer to keep this open as incentive to add revision support within the Wikimate library itself.


Change config location to respect XDG

This includes a fallback to the deprecated config location. Essentially it uses that if it's present else uses the new location, making this not a breaking change.
This seems to work locally but I'm not terribly familiar with Go so hopefully I didn't do anything too silly. :see_no_evil:
Closes #187.

Hi @samhh, thanks for your contribution. Hope to find some time soon to review it and hopefully merge it!
Cheers,
Claudio

Hello @samhh, thanks for your contribution! It's now part of release 0.8.0, thanks!


fix: dialog overlay scroll

This PR fixes the scroll block problem on dialog component.
I added some classes to DialogPrimitive.Overlay to keep content centered and moved DialogPrimitive.Content into DialogOverlay which worked in my case.
Also this is described in docs here
This problem is also described in some issues here.
https://github.com/shadcn/ui/issues/16 and https://github.com/shadcn/ui/pull/18

Closing this PR and opening another one with better solution. Problem from current is that it does not give much control over content. Particularly in my case my-x works for top and not. And for cases when content is small it should be positioned in the center of the screen. The current solution does not work for this case.


403 Forbidden Error

I've followed the readme and set up the monitor, however, we're seeing this error when running the app. Any ideas?

Check you API keys

I got same issue I double checked all api keys


How to export functions?

Is there any way to write something like
exports.fn = function() {
  return 1 + 2;
}

in roy? It would allow to write modules for node etc.

oh, I see, #17

#17 is for giving types to JS natives. This relates to exporting for CommonJS.
I've been working on modules for the past week. I'm hoping to come up with a way to unify the popular JS module systems and have Roy code work across them all.
You can generate a .roym (type information) file from other_module.roy:
 exports x y
 let x = 100
 let y = 10

The generated other_module.roym:
x: Number
y: Number

And you can import it:
exports doubleX
import other_module

console.log other_module.x

let doubleX = other_module.x * other_module.x

This code should be able to compile to Modules/1.0, AMD and browser globals.

Pushed a commit which makes modules work in Roy: 85304e1eee4c3886c39299099e8bcbf08d0cfe47


Add Camellia support

I added a Camellia implementation in RustCrypto/block-ciphers#293. So, I think rPGP can support this cipher. If support this, I think it should be done after #165 is finished.

Very cool, #165 is merged and released, so should be easy to add now


AMBARI-25344 : Provide graceful start/stop option for RegionServer

What changes were proposed in this pull request?
Providing RegionServer with graceful start/stop options to move regions to other RegionServers before stopping and move regions back in after getting started. This avoids necessitating using HBase Balancer manually.
How was this patch tested?
The patch is manually tested

@jonathan-hurley Could you please review this patch?

Could you please review @dlysnichenko @hapylestat

Please review @dlysnichenko @hapylestat @Akhilsnaik

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/Ambari-Github-PullRequest-Builder/5595/
Test FAILed.
Test FAILured.

Build failure not relevant, it was aborted

Please review @mpapirkovskyy
This might be good to include for 2.7.5 release? Because so far, Ambari is not using graceful start/stop for RegionServers and hence causing some amount of availability issue for HBase during Rolling Upgrades.
@dlysnichenko

Please review @Akhilsnaik

Could you please review @hapylestat

retest this please

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/Ambari-Github-PullRequest-Builder/5627/
Test FAILed.
Test FAILured.

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/Ambari-Github-PullRequest-Builder/5629/
Test FAILed.
Test FAILured.

retest this please

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/Ambari-Github-PullRequest-Builder/5630/
Test FAILed.
Test FAILured.

build is timed out, retest this please

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/Ambari-Github-PullRequest-Builder/5631/
Test FAILed.
Test FAILured.

past 3 builds were aborted, let me try one more time: retest this please

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/Ambari-Github-PullRequest-Builder/5632/
Test FAILed.
Test FAILured.

retest this please

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/Ambari-Github-PullRequest-Builder/5633/
Test FAILed.
Test FAILured.

retest this please

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/Ambari-Github-PullRequest-Builder/5639/
Test FAILed.
Test FAILured.

Could you please review this @hapylestat ?

@virajjasani as i understood, this change is needed only for Start/Stop sequence during Rolling upgrade, right?

@virajjasani as i understood, this change is needed only for Start/Stop sequence during Rolling upgrade, right?

Yes @hapylestat , that is one of the reasons but the other one is also to provide 2 more action buttons for RegionServer i.e. graceful start and graceful stop. Hence, clients can decide which one to execute based on their own logic. For test cluster, using normal start/stop might be fine. However, for production clusters, they can use graceful start/stop.

looks fine for me, @dlysnichenko  can you check that all you previous concerns were resolved and we can merge the pull request?


Python without async

Are there any plans to provide a non-async version or some guidelines around how to use it in a non-async fashion?

Hi @estahn
Thanks for your interest in Kiota and for reaching out.
No, we try as much as we can to generate async APIs (only exceptions being Go and CLI for the time being). In general async APIs allow for better concurrency and a higher throughput, leading to a better experience for the end user.
Is there anything specific you'd like to share about this choice for python?


On having multiple IDs in one key

More a question than an issue:
I have a private/public-keypair that I use for my private email address (user@private.com).
In Kleopatra/pgp4win, I have added another user ID to this key, namely<EMAIL_ADDRESS>which is my work address.
The reason for this is that I want to use the same key for my work address.
Now, when I sign and encrypt an email from<EMAIL_ADDRESS>in Outlook with the OutlookPrivacyPlugin, my friend receives it and it is correctly encrypted, but it shows to him that it is signed with<EMAIL_ADDRESS>and not<EMAIL_ADDRESS>Therefore, he cannot send an encrypted reply to<EMAIL_ADDRESS>but only to<EMAIL_ADDRESS>which is not what I want. He somehow does not get the public key of user@work.com?!
How can I configure OutlookPrivacyPlugin so that it signs it with<EMAIL_ADDRESS>Excuse my lack of general knowledge of PGP...

Currently this plugin maps your account email to a pgp key. Currently there is not support for forcing the key to a specific one.

I'm not sure if this is related, but I am attempting to send an email to the Adele test bot using the adele-en @ g n u . de address using the public key that it provided me. There are two emails in that key. I saved the public key to an .asc file and imported it into Kleopatra. After certifying and trusting both, I cannot send emails to them. When I go to send the encrypted email, I do not see either of them as available recipients.

I believe this is a duplicate of issue #30.


How to Select multiple CAN database?

Is there a way to load multiple CAN database and plot them on different CAN channels? I have a 2 channel peak can tool but I have to open two instances of PJ and load a SAE and a custom .dbc files to see the graphs.
I am using the AppImage of PlotJuggler (v3.7.1), which btw is super helpful since I was not able to compile the linux version on my machine. Thank you for that.

It's nice to hear the release is useful.
Loading multiple instances of plugins is required since a single plugin can only attach to a single can channel. So, this is not a plugin issue but a main app one. Previously, I had similar requirements that I had mentioned in https://github.com/facontidavide/PlotJuggler/issues/451 and also worked on tackling it myself (with some PoC results), but I couldn't invest much time to create a clean PR.
I still want to work on that, but I am unsure about its timeline.
As a somewhat workaround, if it is possible to evaluate the values later on, i.e. you are not working on tuning some variables and observing the results; I can recommend recording them using candump and using DataLoadCAN to load the recorded CAN logs one by one. This way, you can plot signals from both channels using different databases and compare them.

Thanks ozzdemir. I did find a work around that allows me to merge two dbc files together, and able to load the merged dbc file in PJ and use only one can channel and plot them together. it's quite useful. For anyone who's interested the link is: https://github.com/ebroecker/canmatrix/blob/development/docs/cli.rst
$ canconvert --merge=second.dbc source.dbc target.dbc


Ebiten does not launch on Android Emulator

We are trying to  run our app on Android emulator. However it appears in black screen.

 It worked (Pixel 2 x86)

ping? @wasedaigo

I let you know when I try next time

Okay, it launched successfully, however the rendering sometimes shows a weird artifact.

Let me close this. Let's revisit this later when we find the problem.

Oops, I missed your report, sorry.
What device did you emulate?

ping

Let's revisit later when we need. This looks like MacBook Pro 2013's issue (which I believe is your machine)


[baseline] [gz-math7] Disable python bindings

Fix vcpkg pipeline issues gz-math7:x86-windows and gz-math7:x64-windows installation failed with following error:
LINK : fatal error LNK1104: cannot open file 'python310.lib'
ninja: build stopped: subcommand failed.

This issue only occurs when pybind11 is installed, when pybind11_FOUND is ON, gz-math7 will generate Python bindings via pybind11, pybind11_add_module links the incorrect python3.
I added patch to disable python bindings.

[x] Changes comply with the maintainer guide
[ ] SHA512s are updated for each updated download
[ ] The "supports" clause reflects platforms that may be fixed by this new version
[ ] Any fixed CI baseline entries are removed from that file.
[ ] Any patches that are no longer applied are deleted from the port's directory.
[x] The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
[x] Only one version is added to each modified port's versions file.

Closed as duplicate of https://github.com/microsoft/vcpkg/pull/31277.


Error connecting to Spark Instance

I am getting the following error on trying to connect to Spark Instance
Error in spark_connect() : could not find function "spark_connect".
I had successfully installed sparlyr, dplyr and h2o. The spark instance is already running on the machine. I am able to view help when I execute the command ?spark_connect.
Using Sparkling water version - 2.1.2
Spark version : 2.1.0
H20 :<IP_ADDRESS>

@ArunLakhotia have you run library(sparklyr) before spark_connect(master ="local")?
You can view help with ?spark_connect.

This issue is most likely caused by missing to run library(sparklyr) before spark_connect(), closing.


Fix link protocol handling

Bug Description

When adding a link, if I type https:// it gets changed to http://https:// which is not valid.
From @swissspidy : "Even when I type http very slowly, it turns it into http://http"
Expected Behaviour

User input shouldn't be updated while the user is still entering a URL.
Do not prepend http:// to a user if it has another valid protocol such as https://

Steps to Reproduce

See gif

Additional Context

Plugin Version:
Operating System:
Browser:

Do not alter or remove anything below. The following sections will be managed by moderators only.
Acceptance Criteria

Implementation Brief

Verified in QA


Bug: Query customization doesn't apply to the count SQL query

I created a reproduction repository: https://github.com/mikeconley12/feathers-objection .
See the changes: https://github.com/feathersjs-ecosystem/feathers-objection/compare/master...mikeconley12:master
Steps to reproduce

git clone https://github.com/mikeconley12/feathers-objection.git
cd feathers-objection/
npm i
DEBUG=knex:query npm run example
Open http://localhost:3030/todos?text=foo in a browser

In your terminal, you should see the following:
  knex:query select count(`todos`.`id`) as `total` from `todos` where `text` = ? undefined +5s
  knex:query select `todos`.* from `todos` where `text` = ? and `complete` = ? limit ? undefined +3ms

The first SQL query doesn't have the  `complete` = ? condition, but the second SQL query has this condition.

Please open bugs with informative description and examples.

I'm sorry if I'm not clear. Let me explain.
I customize the query in my example (this is an undocumented feature, but the documentation says: "It works like the Knex service adapter", and the Knex service adapter has customizing the query  feature).
But my modifications to the query don't apply to the count SQL query. See logs:
  knex:query select count(`todos`.`id`) as `total` from `todos` where `text` = ? undefined +5s
  knex:query select `todos`.* from `todos` where `text` = ? and `complete` = ? limit ? undefined +3ms

I think the problem may be this:
You use params.objection here,
const q = params.objection || this.createQuery(params);

But in the count query, you don't use params.objection
const countQuery = this._createQuery(params);

"It works like the Knex service adapter" - in no point this lib was ment to
be like the Knex service adapter.
This lib was forked from the Knex service lib years ago and was built in a
different way.
Please read the docs (README).
בתאריך שבת, 17 באוק׳ 2020, 15:27, מאת mikeconley12 <
<EMAIL_ADDRESS>
I'm sorry if I'm not clear. Let me explain.
I customize the query in my example
https://github.com/feathersjs-ecosystem/feathers-objection/compare/master...mikeconley12:master
(this is an undocumented feature, but the documentation says: "It works
like the Knex service adapter", and the Knex service adapter has customizing
the query
https://github.com/feathersjs-ecosystem/feathers-knex#customizing-the-query
feature).
But my modifications
https://github.com/mikeconley12/feathers-objection/blob/master/example/app.js#L47
to the query don't apply to the count SQL query. See logs:
knex:query select count(todos.id) as total from todos where text = ? undefined +5s
knex:query select todos.* from todos where text = ? and complete = ? limit ? undefined +3ms
I think the problem may be this:
You use params.objection here
https://github.com/feathersjs-ecosystem/feathers-objection/blob/master/src/index.js#L474
,
const q = params.objection || this.createQuery(params);
But in the count query, you don't use
https://github.com/feathersjs-ecosystem/feathers-objection/blob/master/src/index.js#L511
params.objection
const countQuery = this._createQuery(params);
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
https://github.com/feathersjs-ecosystem/feathers-objection/issues/120#issuecomment-710889250,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABB5E3N6FS62XZGT2EV6RILSLGEUXANCNFSM4SE5VXEQ
.

Thanks for the answers!


MethodArgumentSpaceFixer - Skip body of fixed function

This fixer is supposed to fix arguments, not the body of the function
itself, so just skip it, be it when parsing or when fixing.
Fixes #2958

@eclipxe13 please review

It works great. I add a double check in test just to make sure that a fix inside an anonymous function has been done and no change was made to the upper call, share to you.
            'test fix call inside function does not change upper call' => [
                <<<'EXPECTED'
<?php
call_user_func(function ($arguments) {
    xecho(
        'a',
    'b'
    );
}, $argv);
EXPECTED
                ,
                <<<'INPUT'
<?php
call_user_func(function ($arguments) {
    xecho('a',
    'b');
}, $argv);
INPUT
                ,
                ['ensure_fully_multiline' => true],
            ],

PHPUnit pass. I also run the fix on the code base where I found the issue and it works as expected.
I hope it reach the master branch soon.

Thanks for your thorough testing and bug reports, much appreciated!

Please change target branch to 2.2

@greg0ire , probably 2.4 instead of 2.2, as on 2.2 there were no ensure_fully_multiline option.
or, even without this option, some fix has to gone to 2.2 ?

No it should be 2.4 indeed I think.

Should be fine now, sorry for the mixup.

Thank you @greg0ire.

Thanks for this! It helped me with a [$a, $b, $c] = explode(); call being put on multiple lines when in the body of a closure used as an argument.
Could you please release a patch version with this? Thank you!

Hi. That's great to hear !
For next patches releses (2.2.x, 2.4.x) I want to have https://github.com/FriendsOfPHP/PHP-CS-Fixer/pull/2987 resolved first.


Add stubs for text field types

https://github.com/mglaman/phpstan-drupal/issues/360

Hm, that's odd. I don't know why they're all returning *ERROR*

🙌 looks like renaming stub files fixed the error. 11.x-dev run is unrelated

Thanks!


Updated marc languages mapping from lcc source

The language code map that ships with Traject is either incomplete or out-of-date; it doesn't include a bunch of newer stuff (Croatian/Serbian is what triggered it for me). Updated with new map pulled from the LCC XML dump.

Merging. Just put this here as documentation.

thanks!  I forget if we already have an automated script to pull, we could potentially create one, and even make a rake task for it, or even have something that warns you if the included one is "too old" and you should check for an update.

The problem with an automated script is that currently the tmap is "locked"
inside the traject gem itself. So, we'd have to make sure people are
putting a new version of the file somewhere it's going to be found before
traject itself; I need to revisit that logic to see how you implemented it.
On Tue, Jan 13, 2015 at 1:22 PM, Jonathan Rochkind<EMAIL_ADDRESS>
wrote:

thanks! I forget if we already have an automated script to pull, we could
potentially create one, and even make a rake task for it, or even have
something that warns you if the included one is "too old" and you should
check for an update.
—
Reply to this email directly or view it on GitHub
https://github.com/traject-project/traject/pull/66#issuecomment-69792463
.

--
Bill Dueber
Library Systems Programmer
University of Michigan Library

Oh yeah, I was thinking mainly about the automated script for use by we
traject devs.
But there is a way to make it so a local copy of the tmap in a certain
location will take precedence over the one in the traject gem -- in fact, I
think this may work already, there is a load path that traject uses to look
up tmap definitions, it will use the first one it finds, and the local app
file system paths should be first in the list before the gem file system
paths. I think it may do that already -- I constructed it with that sort of
thing in mind. But if it doesn't, it can be made to.
On Tue, Jan 13, 2015 at 1:47 PM, Bill Dueber<EMAIL_ADDRESS>wrote:

The problem with an automated script is that currently the tmap is
"locked"
inside the traject gem itself. So, we'd have to make sure people are
putting a new version of the file somewhere it's going to be found before
traject itself; I need to revisit that logic to see how you implemented
it.
On Tue, Jan 13, 2015 at 1:22 PM, Jonathan Rochkind <
<EMAIL_ADDRESS>
wrote:

thanks! I forget if we already have an automated script to pull, we
could
potentially create one, and even make a rake task for it, or even have
something that warns you if the included one is "too old" and you should
check for an update.
—
Reply to this email directly or view it on GitHub
<
https://github.com/traject-project/traject/pull/66#issuecomment-69792463>
.

--
Bill Dueber
Library Systems Programmer
University of Michigan Library
—
Reply to this email directly or view it on GitHub
https://github.com/traject-project/traject/pull/66#issuecomment-69796429
.

It does do that already -- I'm doing it right now -- so I think we're
good to go. I'll look for a good place to document it, too. I don't know
how often those files (language, geographic, etc.) change -- we may want to
take out the shipped versions, and throw an error saying, "Hey, if you want
to use that, you need to create a lib/translation_maps directory and run
traject generate marc_language or whatnot. But as I type that, it seems
horribly difficult to explain.
For the moment, maybe we'll just try to keep up and generate new point
releases when those files change.
On Tue, Jan 13, 2015 at 4:34 PM, Jonathan Rochkind<EMAIL_ADDRESS>
wrote:

Oh yeah, I was thinking mainly about the automated script for use by we
traject devs.
But there is a way to make it so a local copy of the tmap in a certain
location will take precedence over the one in the traject gem -- in fact,
I
think this may work already, there is a load path that traject uses to
look
up tmap definitions, it will use the first one it finds, and the local app
file system paths should be first in the list before the gem file system
paths. I think it may do that already -- I constructed it with that sort
of
thing in mind. But if it doesn't, it can be made to.
On Tue, Jan 13, 2015 at 1:47 PM, Bill Dueber<EMAIL_ADDRESS>wrote:

The problem with an automated script is that currently the tmap is
"locked"
inside the traject gem itself. So, we'd have to make sure people are
putting a new version of the file somewhere it's going to be found
before
traject itself; I need to revisit that logic to see how you implemented
it.
On Tue, Jan 13, 2015 at 1:22 PM, Jonathan Rochkind <
<EMAIL_ADDRESS>
wrote:

thanks! I forget if we already have an automated script to pull, we
could
potentially create one, and even make a rake task for it, or even have
something that warns you if the included one is "too old" and you
should
check for an update.
—
Reply to this email directly or view it on GitHub
<
https://github.com/traject-project/traject/pull/66#issuecomment-69792463>

.

--
Bill Dueber
Library Systems Programmer
University of Michigan Library
—
Reply to this email directly or view it on GitHub
<
https://github.com/traject-project/traject/pull/66#issuecomment-69796429>
.

—
Reply to this email directly or view it on GitHub
https://github.com/traject-project/traject/pull/66#issuecomment-69824600
.

--
Bill Dueber
Library Systems Programmer
University of Michigan Library

Cool. I would definitely not want to take out the shipped versions -- making everyone personally and locally keep updating their mapping files is no benefit over having traject do it. Most people are no more likely to be more up to date themselves than traject is (and people can choose to do that if they want anyway).  Traject should do these things out of the box -- and for most people most of the time, being a bit out of date is no disaster. When someone notices, traject can be updated (once for everyone, instead of telling all users to do it for themselves separately!)


delete_activity missing?

I'd like to delete some activities, but I don't see an API for that. Am I missing something or is it not implemented yet?

Indeed! -- Apparently this is missing.  I'll add it in.
https://strava.github.io/api/v3/activities/#delete
In the short-term, you can work around this lack using the protocol method attached to the Client:
# client = Client() .. etc.
client.protocol.delete('/activities/{id}', id=activity_id)

Hope that helps most immediately and thanks for pointing out the oversight.  I guess not many have actually gone to delete activities.

Yep that was my exact workaround. Thanks for the quick add!

I also went ahead and added client.delete_activity() method in master branch. This is not tested yet (we're still lacking a good functional testing framework unfortunately).


PREfast check concluded as neutral

After the check concluded and the Sarif file is generated, I receive the following message from Github
GitHub Code Scanning / PREfast
completed 16 minutes ago in 2s
Error when processing the SARIF file
This check concluded as neutral.

Additional Information
PR
Code scanning PREfast

I have validated your analysis completes successfully in a personal fork. You will need to update your workflow to target this fix:
      - name: Build CMake
        run: cmake --build ${{ env.build }} --config ${{ env.BUILD_TYPE }}

      - name: Run MSVC Code Analysis
        uses: microsoft/msvc-code-analysis-action@main
        # Provide a unique ID to access the sarif output path
        id: run-analysis
        with:
          cmakeBuildDirectory: ${{ env.build }}
          buildConfiguration: ${{ env.BUILD_TYPE }}
          # Ruleset file that will determine what checks will be run
          ruleset: NativeRecommendedRules.ruleset
          ignoredPaths: third_party;build/buildcc/schema/generated

I confirm it fixed #10. Thank you!

@d-winsor I see the same problem here, https://github.com/igraph/igraph/pull/1957/checks?check_run_id=5613512302 Do you have any suggestion on fixing this?


[IntelliJ Plugin] Update test resources and release notes

Purpose
This PR updates plugin release notes and test resources.
Check List

[x] Read the Contributing Guide
[ ] Required Balo version update
[ ] Updated Change Log
[x] Added necessary tests

[ ] Unit Tests
[ ] Spec Conformance Tests
[ ] Integration Tests
[ ] Ballerina By Example Tests

[ ] Increased Test Coverage
[x] Added necessary documentation

[ ] API documentation
[ ] Module documentation in Module.md files
[ ] Ballerina By Examples

Closing in favor of #14988.


fix: Make popups absolutely positioned AND children of the toolbar (fix #151, #155)

I can't seem to be able to reopen https://github.com/nhnent/tui.editor/pull/195, this is a continuation of that PR that makes popups be children of the toolbar (I tried absolutely positioning the toolbar and both headings and table popups work correctly).
If you have any other issues with this PR, please don't close it so I can resolve them. I will try my best to see this fixed in the end :)

Thank you @jkelin
I changed some code from you.
merging it.

I noticed you made changes on the master of your repo.
Making changes on fix branch make your life easier to follow our master.
I always squash merge onto the master branch. 🥂

Awesome, thank you for very much for seeing this through.
Your suggestions are very sound, it is obvious that I don't contribute to OSS as much as I should :)

I'm looking forward to another contribution from you 😉
Have a good day @jkelin


⚠ Bofrost.de has degraded performance

In 9531fd7, Bofrost.de (https://www.bofrost.de) experienced degraded performance:

HTTP code: 200
Response time: 902 ms

Resolved: Bofrost.de performance has improved in f100018 after 9 minutes.


VCS: Error-[CNST-CIF] Constraints inconsistency failure

Occassionally seeing no output assembly for some tests. Running with --verbose reveals the following:
Error-[CNST-CIF] Constraints inconsistency failure
./src/riscv_amo_instr_lib.sv, 133
Constraints are inconsistent and cannot be solved.
Please check the inconsistent constraints being printed above and rewrite
them.
UVM_FATAL ./src/riscv_amo_instr_lib.sv(133) @ 0: reporter [riscv_amo_instr_stream_0] Check failed (amo_instr[i].randomize()) Randomization failed!
This is with vcs_mx.P-2019.06-SP1, and I would not rule out a VCS issue at this point.
Is there a known good version of VCS to test against?

I ran the test 100 times but cannot reproduce the issue. Can you provide more information about the failure. I believe VCS could extract the conflict constraints to a separate file.

Thank you.
I failed to mention I was not using the standard riscv_core_setting.sv configuration, so this is probably a function of my settings. I have reverted the setting file to original and the test passes (or at least the script runs to completion without reporting any errors)
My failing setup has the following changes to settings:
parameter int XLEN = 32;
parameter satp_mode_t SATP_MODE = BARE;
privileged_mode_t supported_privileged_mode[] = {USER_MODE};
riscv_instr_group_t supported_isa[$] = {RV32I, RV32M, RV32C};
bit support_sfence = 0;
Which I now recognise is invalid since MACHINE_MODE is the only mandatory mode, not USER_MODE.

yes, if you add MACHINE_MODE to the list, do you still see this issue?

No, that resolves this issue, but then most of the tests timeout running spike sim.
Could this be because I have not removed User and Supervisor variants from implemented_csr[], implemented_interrupt[] and implemented_exception[]?
I'll try this next

Just search for "exception" in the spike log to see if there's any exception raised.

implemented_csr[], implemented_interrupt[] and implemented_exception[] shouldn't matter, they are mostly used for coverage purposes.

Yes, about 1 million instances of this:
core   0: exception trap_load_access_fault, epc 0x0000000080012338

Can you let me know which test are you running, and paste a few lines of spike log before the first failure?

Sure. I'm running the full regression (I.e. simply python3 run.py). The first test to fail is:
Tue, 15 Oct 2019 18:31:07 ERROR    Timeout[25s]: /usr/julien/riscv-gnu-toolchain/install/bin/spike --isa=rv64gc -l out_2019-10-15/asm_tests/riscv_machine_mode_rand_test_0.o &> out_2019-10-15/spike_sim/riscv_machine_mode_rand_test.0.log
Here is the leadup to the first 2 exceptions:
core   0: 0x0000000080005768 (0x02588a33) mul     s4, a7, t0
core   0: 0x000000008000576c (0x01caa533) slt     a0, s5, t3
core   0: 0x0000000080005770 (0x00000661) c.addi  a2, 24
core   0: 0x0000000080005772 (0x0049a083) lw      ra, 4(s3)
core   0: 0x0000000080005776 (0x340378f3) csrrci  a7, mscratch, 6
core   0: 0x000000008000577a (0x0089a283) lw      t0, 8(s3)
core   0: 0x000000008000577e (0x000082a9) c.srli  a3, 10
core   0: 0x0000000080005780 (0x03898993) addi    s3, s3, 56
core   0: 0x0000000080005784 (0x340bb8f3) csrrc   a7, mscratch, s7
core   0: 0x0000000080005788 (0x03a6b8b3) mulhu   a7, a3, s10
core   0: 0x000000008000578c (0x00008d85) c.sub   a1, s1
core   0: 0x000000008000578e (0x00000001) c.nop
core   0: 0x0000000080005790 (0x00008082) ret
core   0: exception trap_instruction_access_fault, epc 0xffffffff800043b6
core   0:           tval 0xffffffff800043b6
core   0: 0x0000000080009000 (0x340999f3) csrrw   s3, mscratch, s3
core   0: 0x0000000080009004 (0x000289b3) add     s3, t0, zero
core   0: 0x0000000080009008 (0xf8498993) addi    s3, s3, -124
core   0: 0x000000008000900c (0x0019a223) sw      ra, 4(s3)
core   0: exception trap_store_access_fault, epc 0x000000008000900c
core   0:           tval 0xffffffff8001de04
core   0: 0x0000000080009000 (0x340999f3) csrrw   s3, mscratch, s3
core   0: 0x0000000080009004 (0x000289b3) add     s3, t0, zero
core   0: 0x0000000080009008 (0xf8498993) addi    s3, s3, -124
core   0: 0x000000008000900c (0x0019a223) sw      ra, 4(s3)

Is --isa=rv64gc expected given my setting file:
riscv_instr_group_t supported_isa[$] = {RV32I, RV32M, RV32C};

Can you run with "--isa rv32imc"?

That results in:
cc1: error: ABI requires -march=rv64
So trying with --mabi ilp32 also ...

GCC is still being called with -march=rv64im so we now get:
cc1: error: ABI requires -march=rv32
Also adding --gcc_opts='-march=rv32imc' is looking promising on a single test

Mmm,  then this one fails "riscv_non_compressed_instr_test", presumably because we forced the 'C' extension...

What's the failure for riscv_non_compressed_instr_test?

I am closing issue as the original problem is solved. Please file a new issue if needed.

python3 run.py -tn riscv_non_compressed_instr_test --isa rv32imc -m ilp32 --gcc_opts='-march=rv32imc'
:
cc1: error: ABI requires -march=rv32


Separate "Max Breeding Steps" into Steps + Iterations limit

Max Breeding Steps is used as the iteration limit and the max breeding step limit, since I assumed that, by the time we do "Max Steps" iterations, it would no longer be possible to produce results which exceed that limit. i.e., iterating more than "Max Steps" would never yield results which exceed "Max Steps". Turns out this isn't necessarily true.
This can generally be mitigated by just bumping the current setting, but Pal Calc claims to find the optimal path within the given constraints, and one of the constraints is not behaving as expected. These conditions (max iterations and max breeding steps) should be separated.

Updated with ffbd8975c95e8faf335b5674111077191f4e6243


placeholder text doesn't disappear if the user leaves first line of editor blank

I'm guessing your query selector checks for an empty

 on the first line of the editor :) the bad news is, that doesn't necessarily mean the editor is empty haha!

Whilst I agree this is a bit clumsy, the practical applications seem a little unlikely. Most systems would strip out the empty tags before saving to the database etc.

It wouldn't even get to the server as it's content rendered from a ::before tag! Given tiptap is arguably the best solution to content-editable in vue, I think it's worth the fix. Tell you what, I'll fork and have a look see if I can spot the problem :)

In this moment I try to fix that :) What would you expect?

the placeholder should be visible if the editor is completely empty?
the placeholder should be visible only on the current line (where the cursor is active)?
or should I add classes for each of these cases?

If the editor is completely empty, like a regular placeholder on an input, I reckon. 👍

As code potato says. I think it should work like the placeholder on the text boxes we're currently having this conversation with! :D
Thank you for such a quick response Phillip!

Hmm. I've seen a use case for line based placeholders at Notion!

Maybe I should provide classes for each cases.

Hiya, related theme, some more weird behaviour!

The placeholder is only visible for completely empty documents for now. @jaysaurus with v0.12.1 you also do not have to change any CSS.

Good job! Thanks!

Are you sure of what you said ? 🤔  Still very weird behavior ....


Miscellaneous bugfixes.

Put back the standard makefile targets.
Fixes: #722
The GUI can open flux and image files for writing.
Fixes: #721
Make the build system saner.
Fixes: #701
Also, strip out the broken tpi stuff in favour of something much simpler (and more working).

Hi David, unfortunately the GUI disk writing still isn't working for me with this latest build. (fb9f7fe from 45 minutes ago)  Same error on picking any disk image to write.
I tested with 1440k IBM format images and a Mac 800k disk image.

Windows 10.0.19045.3570 + Greaseweazle

Huh. I've just tried it and it works here. Can you describe your exact process?

I made a short video:
https://youtu.be/b4I3EudYpTU
The error is the same with IBM disks -- hadn't tried others but I assume it's the same with all. As you mentioned before, the command line work fine.

I, too, I still seeing this issue with the GUI program. I'm using the 2-day old release, so I know it's the latest version. I'm getting the same "cannot open file" error. I've also tried installing it as administrator and I've run the program as administrator. Same error. Just like the video. Doesn't seem to matter what formats I select or what file I choose.
I also tried the FluxEngine command-line version. I got this output:
.\fluxengine.exe write C:\Users\micro\Desktop\System3.2_Journal.Mac400.img
[libprotobuf ERROR ../../src/google/protobuf/text_format.cc:335] Error parsing text-format ConfigProto: 1:3: Message type "ConfigProto" has no field named "LK".
Error: couldn't load external config proto
I hope that helps!

In addition to my earlier comment, I have a little bit of possibly useful observations. In my comment I listed the problem with the command-line version and saw it was related to the google/protobuf/ stuff. But in the GUI version the error seems to be generated here:
wxMessageBox(e.message, "Error", wxOK | wxICON_ERROR);
if (_state == STATE_WRITING_WORKING)
SetState(STATE_WRITING_FAILED);
That seems to imply that auto filename = wxFileSelector works but then
if (filename.empty())
return;
returns, which gets us to the final error message.
So it seems like there is some problem with the library used to either get the file from Windows 10 (in my case) or a problem with something that maybe is in google/protobuf but I'm not sure.
BUT!!!!
When I choose a file called Untitled.png it gives me the error:
unrecognized image filename
C:\Users\micro\Desktop\Untitled.png
So... I took an floppy disk image file and renamed it to Untitled.png just to see what would happen. It gives the same error as the actual file that was an actual .png file.
This is also true with files like .exe or .jpg in that whenever I try to open them, it clearly gets a full path and filename but then looks at the extension and decided it's not an actual image filename. Because I would guess that if it were reading inside the file it would figure out that the wrongly named disk image file would have worked.
Clearly it's getting as far as analyzing the filename to determine if it's a valid image, but then failing when it tries to start reading the actual file.
I'm using Greaseweazle with FluxEngine and reading works just fine. But this seems more like an issue with FluxEngine and local file access and does not seem to even get as far as accessing Greaseweazle, since the drive doesn't make any noise or get accesses in any way and the error message seems to be presented instantly.
I hope this helps even if it's maybe too much information!

One more detail: I can format a disk using the format button in the FluxEngine GUI.


Cannot abort DFU controller

When trying to abort my DFU controller like this, I'm getting a runtime error:
 var controller: DFUServiceController!
 let selectedFirmware = DFUFirmware(urlToZipFile:firmwareURL)
 let initiator = DFUServiceInitiator(centralManager: self.central, target: self.peripheral).withFirmwareFile(selectedFirmware!)

initiator.logger = self
initiator.delegate = self
initiator.progressDelegate = self

self.controller = initiator.start()

_ = self.controller.abort()

@mostafaberg Could I get your thoughts on this?

if you try to abort the controller before it starts it has not discovered at that moment yet if it's a Secure or Legacy DFU so there's nothing to abort per se, however we should handle this more gracefully
does this happen during the even if you abort in the middle of the DFU operation ?

Hmm, that makes sense @mostafaberg, I haven't had this issue when trying to abort mid-DFU but have tried to use the .abort() function when hanging in the "disconnecting" state as noted in #43, which is where I noticed this behaviour.

True, i can confirm this happens, i'll try to get that resolved as soon as I can, will have much more time soon assigned to fixing all those bugs ! thanks for your patience

Not a problem, thank you @mostafaberg ! 👍

Hi, the Version 3 is now published on our Version3 branch. You can edit your Profile and give the whole repo and branch path there. This bug has been fixed in this version, I hope :)
Version 3 is now in beta phase and we will publish it when we get some feedback.
Thanks!

Version 3 seems to be working for us! Going to close this issue for now. 😄


Object published with inaccurate TF

An issue has been identified with the published TF of the object. It appears that the TF is being published slightly above the actual object, but the published coordinate seems to be in the correct "z" position. However, there is a significant error in the "x" position.

On line 126, there was an error in the coordinates of the transformation, as the y-axis was inverted. To fix the issue with the tf's being above the objects when they should actually be below, I simply removed the negative sign from the y-axis.


Changes send_confirm and send_final views to have a nighthawk drawing on them…

…. Confirm is yellow on black blackground. Send final is now a yellow to black gradient with black nighthawk

Thanks a bunch for the contribution, @imichaelmiers, and the review, @gmale! :smiley:
I'll ask @nighthawk24 to take a look.


BoM web service data upgrade breaks our code

Error is in dea_bom.py in Scripts folder.
XMLSyntaxError: Opening and ending tag mismatch: HR line 2 and body, line 2, column 189
"Apparently the problem is caused by changes to  string cleaning to remove the newline characters since they upgraded their SOS service. A temporary solution is adding the following line: body = body.replace('\n', '')"

Should be fixed with PR #646


Rechart vertical BarChart not working

Describe the bug
i want vertical barchart like this img

but displaying empty chart..
layout="vertical" not working
what should i do??

Reproduction
https://stackblitz.com/edit/react-pdf-charts-starter-5byukq?file=src%2FApp.tsx
Validations

[X] Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
[X] Check that you're confident that this is a legitimate bug. To ask a question open a GitHub Discussion.
[X] The provided reproduction is a minimal reproducible example of the bug.

@BaaSidDev Looks like this is is not a bug with react-pdf-charts but rather with your recharts code. Your chart configuration in the web version of recharts also doesn't render anything: https://stackblitz.com/edit/recharts-example-4nwyda?file=index.js
I think the issue is that your XAxis and YAxis values aren't specifying which data to use. If you change those to:
<XAxis dataKey="amt" type="number" />
<YAxis dataKey="name" type="category" />

then you'll get the result I think you want:

And it also works in react-pdf-charts:

this is my mistake..
Thank you very much.


PHPStorm NoInspections duplicated when writing to models

Laravel: 7.x
Ide-helper: 2.7.0
If you run the below TWO times :
php artisan ide-helper:models --write --phpstorm-noinspections

You end up with the @noinspection params being duplicated each run:
/**
 * App\Client.
 * ...
 * @mixin \Eloquent
 * @noinspection PhpFullyQualifiedNameUsageInspection
 * @noinspection PhpUnnecessaryFullyQualifiedNameInspection
 * @noinspection PhpFullyQualifiedNameUsageInspection
 * @noinspection PhpUnnecessaryFullyQualifiedNameInspection
 */
class Client extends Model ...

This was added in PR https://github.com/barryvdh/laravel-ide-helper/pull/905

@mzglinski can you take a look?

Adding -r refreshes doc blocks for me with @noinspection only once, I'm guessing if you want to append then --phpstorm-noinspections should be excluded from the command?


Improve bicycle state merge

We currently do the following during simulation of the bicycle:

Kalman filter update to obtain a new state estimate
integrate full state using a full bicycle model (dynamics + kinematics)
merge the two by overwriting the dynamic states (yaw, roll, steer, roll rate, steer rate) that we obtain from the Kalman filter

We should look into a better method for doing this or determine if this is sufficient.

We could use the full bicycle model with Kalman filter but it doesn't seem to be worth it right now.