Need better error reporting if outdir does not exist.

When running on our build server no ETL file is created and an exception is thrown in  ETWLogging.StartAsync(). If I copy the dll with the tests (built on the build server) and the xunit.performance.run.exe with it dependencies to a directory on my local machine everything works as expected. My machine is running WIndows 8.1 and the build server Windows Server 2012 R2.
What should I do to continue investigate the issue? Where can the difference be?
Here's the stack trace:
The system cannot find the path specified. (Exception from HRESULT: 0x80070003) [C:\Builds\3\Common components\AwtSG.CommonComponent.PerformanceTests\src\Common components\build\performancetests.proj]             at Microsoft.ProcessDomain.ProcDomain.<ExecuteAsync>d__26``1.MoveNext()          --- End of stack trace from previous location where exception was thrown ---             at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)             at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)             at Microsoft.Xunit.Performance.ETWLogging.<StartAsync>d__4.MoveNext()          --- End of stack trace from previous location where exception was thrown ---             at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)             at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)             at Microsoft.Xunit.Performance.EtwPerformanceMetricLogger.StartLogging(ProcessStartInfo runnerStartInfo)             at Microsoft.Xunit.Performance.ProgramCore.RunTests(XunitPerformanceProject project)             at Microsoft.Xunit.Performance.ProgramCore.Run(String[] args)

I found the issue. To input the search path to the -outdir  I had to add a space after the \ before the ". (Unfortunately we have a space in the path.)
By changing
arguments.Push(args[i]);
to
arguments.Push(args[i].Trim(' '));
in ProgramCore.ParseCommandLine() the issue is resolved.

I'm not sure I'd want to trim spaces off of the directory name; spaces in paths are valid, after all.  Can you explain the scenario that lead to the issue in a little more detail?

I didn't think of the case when a directory name ends with a space. I call the runner in the following way
xunit.performance.run.exe "D:\Some folder with space\bin\MyProject.PerformanceTests.dll" -runid MyProject.PerformanceTests_20151112.3 -outdir "D:\Some folder with space\bin\ " -runner "D:\Some folder with space\tools\Xunit.Performance\xunit.console.exe"
D:\Some folder with space\bin\ is actually a variable that is re-used, hence the ending backslash in the outdir. If I omit the space before the " Windows argument parser (I'm not 100% if it's .NET or Windows) assumes I want to escape the " with the backslash which makes the arguments completely invalid.
Now that I know about the problem I can think of many ways to work around it, but it was a real pain to find it, especially when the exception is thrown in a different part of the code and it didn't occur on my local machine (I've no idea why it didn't throw there too).

Thanks!  I'll leave this open for now, as a note to report this error in a better way.

The more serious issue here is that you should be allowed to do
-outdir "D:\Some folder with space\bin"
on a command line.    The standard way of quoting “ on a windows command line is to repeat the quote  (thus “” becomes “).
However I suspect that on UNIX machines the \ is used to quote escapes.
   Going half way is bad.
Eric: Do you know who owns the run.exe (and how it does command line parsing.
Vance
From: Erik Ovegård<EMAIL_ADDRESS>Sent: Wednesday, December 2, 2015 10:35 AM
To: Microsoft/xunit-performance<EMAIL_ADDRESS>Subject: Re: [xunit-performance] ETL file not created (#109)
I didn't think of the case when a directory name ends with a space. I call the runner in the following way
xunit.performance.run.exe "D:\Some folder with space\bin\MyProject.PerformanceTests.dll" -runid MyProject.PerformanceTests_20151112.3 -outdir "D:\Some folder with space\bin\ " -runner "D:\Some folder with space\tools\Xunit.Performance\xunit.console.exe"
D:\Some folder with space\bin\ is actually a variable that is re-used, hence the ending backslash in the outdir. If I omit the space before the " Windows argument parser (I'm not 100% if it's .NET or Windows) assumes I want to escape the " with the backslash which makes the arguments completely invalid.
Now that I know about the problem I can think of many ways to work around it, but it was a real pain to find it, especially when the exception is thrown in a different part of the code and it didn't occur on my local machine (I've no idea why it didn't throw there too).
—
Reply to this email directly or view it on GitHubhttps://github.com/Microsoft/xunit-performance/issues/109#issuecomment-161391909.

Whatever translation happens with backslashes seems to happen before the managed Main method is called.  I just tried this simple program:
using System;

namespace PrintArgs
{
    class Program
    {
        static void Main(string[] args)
        {
            foreach (var arg in args)
                Console.WriteLine(arg);
        }
    }
}

If I invoke it thusly (directly from the console):
> printargs hello "there\"

The output is:
hello
there"

If I "escape" the backslash, I get the desired result:
> printargs hello "there\\"
hello
there\

I'm not sure what xunit.performance.run can do, given that this translation seems to happen somewhere before Main is even called.

I agree that it is not xunit.performance.run’s issue.  How was that EXE generated?   I assume this is CoreCLR based, which imply it is an issue in CoreCLR (since it owns argument parsing).
Vance
From: Eric Eilebrecht<EMAIL_ADDRESS>Sent: Wednesday, December 2, 2015 2:48 PM
To: Microsoft/xunit-performance<EMAIL_ADDRESS>Cc: Vance Morrison<EMAIL_ADDRESS>Subject: Re: [xunit-performance] Need better error reporting if outdir does not exist. (#109)
Whatever translation happens with backslashes seems to happen before the managed Main method is called. I just tried this simple program:
using System;
namespace PrintArgs
{
class Program

{

    static void Main(string[] args)

    {

        foreach (var arg in args)

            Console.WriteLine(arg);

    }

}

}
If I invoke it thusly (directly from the console):

printargs hello "there"

The output is:
hello
there"
If I "escape" the backslash, I get the desired result:

printargs hello "there\"

hello
there\
I'm not sure what xunit.performance.run can do, given that this translation seems to happen somewhere before Main is even called.
—
Reply to this email directly or view it on GitHubhttps://github.com/Microsoft/xunit-performance/issues/109#issuecomment-161458376.

I tried running this C++ program from MSDN.
`
#include "stdafx.h"
#include
using namespace std;
int main(int argc,      // Number of strings in array argv
char *argv[],   // Array of command-line argument strings
char *envp[])  // Array of environment variable strings
{
int count;
// Display each command-line argument.
cout << "\nCommand-line arguments:\n";
for (count = 0; count < argc; count++)
	cout << "  argv[" << count << "]   "
	<< argv[count] << "\n";
return 0;

}
`
and had the same behavior:
`Debug>PrintArgs.exe hello "there"
Command-line arguments:
argv[0]   PrintArgs.exe
argv[1]   hello
argv[2]   there

PrintArgs.exe hello "there"

Command-line arguments:
argv[0]   PrintArgs.exe
argv[1]   hello
argv[2]   there"`
Hence it's a Windows and not a .NET/CoreCLR thing.
I would suggest to just give an error message if the outdir path doesn't exist. If the error message contains the path that was used it is easy to fix the problem for the user.

Closing prior to archive.

Closing prior to archive.


[sqlitecpp] build failure

Describe the bug
Adding the library as a dependency (without any usage in the code) prevents building the project
Environment

OS: Windows 10
Compiler: MSVC 2019

To Reproduce
Steps to reproduce the behavior:

Install package ./vcpkg install sqlitecpp
Add package to CMakeList:
find_package(SQLiteCpp CONFIG REQUIRED)
target_link_libraries(main PRIVATE SQLiteCpp)

My program doesn't build anymore.
Expected behavior
Build successfully
Failure logs
.../vcpkg/scripts/buildsystems/vcpkg.cmake:349 (_add_executable):  Target "main" links to target "unofficial::sqlite3::sqlite3" but the target was not found.  Perhaps a find_package() call is missing for an IMPORTED target, or an ALIAS target is missing?

@remz1337, thanks for reporting this issue!
I have summited PR #13108 to fix this issue.


package cms scanners

[ ] https://github.com/samjoan/droopescan
[ ] https://github.com/whoot/typo3scan
[ ] https://github.com/dionach/cmsmap

Replaced by #43 and #44


1.8+ breaks tests running with phantomJS

This line (463 in superagent.js) breaks jasmine/karma unit tests we're running with phantomJS:
require('./request').bind(null, Request);
We get this error:
TypeError: 'undefined' is not a function (evaluating 'require('./request').bind(null, Request)')
Apparently phantomJS does not support .bind() so I'm not sure if this is really a superagent issue or a phantomjs issue but I figured I'd report the issue.

PhantomJS 1 is stuck with a very old and oddly incomplete JS engine. If you have to use it, then polyfill .bind(), but I suggest switching to anything else.


ERROR: from element /GstPipeline:pipeline0/GstGvaDetect:gvadetect0: base_inference plugin intitialization failed

Hello Everyone,
I am trying to run below pipeline in docker container "gst-video-analytics:latest" (reference_link)  -
GST_DEBUG=3 gst-launch-1.0 -v filesrc location=video-examples/test.mp4 ! decodebin ! videoconvert ! video/x-raw,format=I420  ! gvadetect model=/root/intel_models/root/models/intel/person-vehicle-bike-detection-crossroad-0078/FP16/person-vehicle-bike-detection-crossroad-0078.xml device=MYRIAD ! fpsdisplaysink video-sink=fakesink sync=false async-handling=true
and I am getting this error -
ERROR: from element /GstPipeline:pipeline0/GstGvaDetect:gvadetect0: base_inference plugin intitialization failed
Additional debug info:
/root/gst-video-analytics/gst/inference_elements/base/inference_singleton.cpp(137): acquire_inference_instance (): /GstPipeline:pipeline0/GstGvaDetect:gvadetect0:
Failed to construct OpenVINOImageInference
        Failed to allocate graph: NC_ERROR

Execution ended after 0:00:16.944330724

While running the same pipeline but with device=CPU and changing model to FP32 I am getting desired output.
I have also followed steps mentioned in this issue to connect NCS2 with the host(Ubuntu 18.04).
Please help me to understand how to resolve this issue.
Thanks in advance

@devdastl,
Could you describe your hardware platform? Are you using NCS2 in a Docker environment?
If yes, you have to make sure NCS2 is enabled in the environment, could you do "lsusb" and post the output?
Mark

hello @mliu2020,
Yes I am using NCS2 with Docker environment. I got this output from "lsusb" command in my host environment -
Bus 002 Device 001: ID 1d6b:0003 Linux Foundation 3.0 root hub
Bus 001 Device 005: ID 03f0:094a Hewlett-Packard Optical Mouse [672662-001]
Bus 001 Device 083: ID 03e7:2485
Bus 001 Device 003: ID 0424:2240 Standard Microsystems Corp.
Bus 001 Device 002: ID 413c:2107 Dell Computer Corp.
Bus 001 Device 001: ID 1d6b:0002 Linux Foundation 2.0 root `hub`

I am running my docker image with this command -
 docker run -it --privileged -v /dev:/dev --network=host -v ~/.Xauthority:/root/.Xauthority -v /tmp/.X11-unix:/tmp/.X11-unix -e DISPL=$DISPLAY -e HTTP_PROXY=$HTTP_PROXY -e HTTPS_PROXY=$HTTPS_PROXY -e http_proxy=$http_proxy -e https_proxy=$https_proxy -v ~/gva/data/models/intel:/root/intelodels:ro -v ~/gva/data/models/common:/root/common_models:ro -e MODELS_PATH=/root/intel_models:/root/common_models -v ~/gva/data/video:/root/video-examples:r-e VIDEO_EXAMPLES_DIR=/root/video-examples gst-video-analytics:latest

@devdastl,
I can see NCS2 is enabled in host but there might be problem when you use it in Docker.
Please refer to the following OpenVINO docker image and see if you can get clues:
https://hub.docker.com/r/openvino/ubuntu18_dev
Mark

@devdastl,
The other way to check NCS2 enabling is to check whether OpenVINO’s benchmark_app (or any other sample) works with MYRIAD device in docker environment.
If OpenVINO sample works but DL Streamer sample doesn't, we can check if there is an issue.
Mark

Hello @mliu2020,
I am really sorry for such a late replay.
I tried running the sample application on OpenVino docker image "openvino/ubuntu18_dev:latest" but got this error -
E: [global] [     23629] [Scheduler00Thr] dispatcherEventSend:53        Write failed (header) (err -1) | event XLINK_PING_REQ

E: [xLink] [     23629] [Scheduler00Thr] sendEvents:1027        Event sending failed
E: [global] [     24630] [interactive_fac] XLinkOpenStream:73   Got wrong package from device, error code = X_LINK_ERROR
E: [ncAPI] [     24630] [interactive_fac] ncDeviceOpen:1100     can't open deviceMonitor stream due to unknown error
E: [global] [     24630] [Scheduler00Thr] dispatcherEventSend:53        Write failed (header) (err -4) | event XLINK_CREATE_STREAM_REQ

E: [xLink] [     24630] [Scheduler00Thr] sendEvents:1027        Event sending failed

I tried the same sample application with CPU and it was working fine. Below is the sample application execution commad -

For Myraid -
./interactive_face_detection_demo -i /home/openvino/head-pose-face-detection-female-and-male.mp4 -m /opt/intel/openvino_2021.1.110/deployment_tools/tools/model_downloader/intel/face-detection-adas-0001/FP16/face-detection-adas-0001.xml -d MYRIAD -no_show

For CPU -

./interactive_face_detection_demo -i /home/openvino/head-pose-face-detection-female-and-male.mp
4 -m /opt/intel/openvino_2021.1.110/deployment_tools/tools/model_downloader/intel/face-detection-adas-0001/FP32/face-detection-adas-0001.xml -d CPU -no_show

Docker run commad-
docker run -u 0 -it --device-cgroup-rule='c 189:* rmw' -v /dev/bus/usb:/dev/bus/usb --rm openvino/ubuntu18_dev:latest

Thanks a lot for the help

Yes, this seems like a NCS2 installation/configuration error. I don't have much experience on this. But I don't know where the correct installation guide is.
I find the following page the most closest one I can think of:
https://docs.openvinotoolkit.org/latest/openvino_docs_install_guides_movidius_setup_guide.html
Let me know if this helps.
Mark

@devdastl,
I checked issue #54 and @umed mentioned NCS2 must use FP16, can you also double check if the same sample you failed in FP32 can run under FP16?
Mark

Hi @devdastl,
I apologized for the late response. I was trying to find a NCS2 device so I can try and help you.
First correct my error in previous message, the docker image I referenced is ubuntu18_data_dev, "ubuntu18_dev" doesn't include GST dependencies so you can't run DL Streamer. Since the latest release of 2021.2, this image becomes "ubuntu18_data_dev:2021.1"
I can run the command in your original question in 2021.1 release successfully with following steps:

Install udev rule by following this instruction.
Insert NCS2 and confirm with lsusb command, I got the output exactly like you did.

Let me know if this solves your problem.
Mark

Hi @devdastl,
I didn't get your respond, was the issue solved?
Let me know if you need more help or I can close this issue in a few days.
Mark Liu

@devdastl ,
Let me close it for now and please feel free to reopen or submit a new issue.
Mark


Edit Swedish translation

Adding missing translations and adjusting some previous translations.

coverage: 61.025%. remained the same
when pulling 88e7c2d5834a428f814df896c4c067fa46b38879 on deob83:edit-swedish-translation-241215
into c13943af80e2b7ec5f531e2312d37cde9f9654aa on newsboat:master.


FlutterMacOS build error

Launching lib/main.dart on macOS in debug mode...
Running pod install...
CocoaPods' output:
↳
Preparing
Analyzing dependencies

Inspecting targets to integrate
  Using `ARCHS` setting to build architectures of target `Pods-Runner`: (``)

Fetching external sources
-> Fetching podspec for `FlutterMacOS` from `Flutter/ephemeral`
-> Fetching podspec for `ffmpeg_kit_flutter` from `Flutter/ephemeral/.symlinks/plugins/ffmpeg_kit_flutter/macos`
-> Fetching podspec for `ffmpeg_kit_flutter_min_gpl` from `Flutter/ephemeral/.symlinks/plugins/ffmpeg_kit_flutter_min_gpl/macos`
-> Fetching podspec for `path_provider_macos` from `Flutter/ephemeral/.symlinks/plugins/path_provider_macos/macos`

Resolving dependencies of `Podfile`
  CDN: trunk Relative path: CocoaPods-version.yml exists! Returning local because checking is only performed in repo update
[!] CocoaPods could not find compatible versions for pod "ffmpeg_kit_flutter/https":
  In Podfile:
    ffmpeg_kit_flutter (from `Flutter/ephemeral/.symlinks/plugins/ffmpeg_kit_flutter/macos`) was resolved to 5.1.0, which depends on
      ffmpeg_kit_flutter/https (= 5.1.0)

Specs satisfying the `ffmpeg_kit_flutter/https (= 5.1.0)` dependency were found, but they required a higher minimum deployment target.

/Library/Ruby/Gems/2.6.0/gems/molinillo-0.8.0/lib/molinillo/resolution.rb:317:in `raise_error_unless_state'
/Library/Ruby/Gems/2.6.0/gems/molinillo-0.8.0/lib/molinillo/resolution.rb:299:in `block in unwind_for_conflict'
/Library/Ruby/Gems/2.6.0/gems/molinillo-0.8.0/lib/molinillo/resolution.rb:297:in `tap'
/Library/Ruby/Gems/2.6.0/gems/molinillo-0.8.0/lib/molinillo/resolution.rb:297:in `unwind_for_conflict'
/Library/Ruby/Gems/2.6.0/gems/molinillo-0.8.0/lib/molinillo/resolution.rb:682:in `attempt_to_activate'
/Library/Ruby/Gems/2.6.0/gems/molinillo-0.8.0/lib/molinillo/resolution.rb:254:in `process_topmost_state'
/Library/Ruby/Gems/2.6.0/gems/molinillo-0.8.0/lib/molinillo/resolution.rb:182:in `resolve'
/Library/Ruby/Gems/2.6.0/gems/molinillo-0.8.0/lib/molinillo/resolver.rb:43:in `resolve'
/Library/Ruby/Gems/2.6.0/gems/cocoapods-1.11.3/lib/cocoapods/resolver.rb:94:in `resolve'
/Library/Ruby/Gems/2.6.0/gems/cocoapods-1.11.3/lib/cocoapods/installer/analyzer.rb:1078:in `block in resolve_dependencies'
/Library/Ruby/Gems/2.6.0/gems/cocoapods-1.11.3/lib/cocoapods/user_interface.rb:64:in `section'
/Library/Ruby/Gems/2.6.0/gems/cocoapods-1.11.3/lib/cocoapods/installer/analyzer.rb:1076:in `resolve_dependencies'
/Library/Ruby/Gems/2.6.0/gems/cocoapods-1.11.3/lib/cocoapods/installer/analyzer.rb:124:in `analyze'
/Library/Ruby/Gems/2.6.0/gems/cocoapods-1.11.3/lib/cocoapods/installer.rb:416:in `analyze'
/Library/Ruby/Gems/2.6.0/gems/cocoapods-1.11.3/lib/cocoapods/installer.rb:241:in `block in resolve_dependencies'
/Library/Ruby/Gems/2.6.0/gems/cocoapods-1.11.3/lib/cocoapods/user_interface.rb:64:in `section'
/Library/Ruby/Gems/2.6.0/gems/cocoapods-1.11.3/lib/cocoapods/installer.rb:240:in `resolve_dependencies'
/Library/Ruby/Gems/2.6.0/gems/cocoapods-1.11.3/lib/cocoapods/installer.rb:161:in `install!'
/Library/Ruby/Gems/2.6.0/gems/cocoapods-1.11.3/lib/cocoapods/command/install.rb:52:in `run'
/Library/Ruby/Gems/2.6.0/gems/claide-1.0.3/lib/claide/command.rb:334:in `run'
/Library/Ruby/Gems/2.6.0/gems/cocoapods-1.11.3/lib/cocoapods/command.rb:52:in `run'
/Library/Ruby/Gems/2.6.0/gems/cocoapods-1.11.3/bin/pod:55:in `<top (required)>'
/usr/local/bin/pod:23:in `load'
/usr/local/bin/pod:23:in `<main>'

Exception: Error running pod install

Actually this plugin is not compatible with MacOS since this lib does not support it -> https://pub.dev/packages/video_thumbnail


Snapcraft: create how-to documentation for review-tools

Write a how-to guide on using review-tools to check a snap is consistent and secure.
Background
The review-tool command can be used to test whether a freshly built snap will pass Store tests permitting the snap to be published. The Store runs reviews tools whenever a new snap is uploaded. The following is a common command, for example:
review-tools.snap-review cameractrls_0.5.6-0-gd8136d1_amd64.snap

This how-to should cover how to install the review-tools snap, how its most important functions are accessed, and how some of the most common problems could be mitigated.
Prerequisites
You will need some experience building snaps.
See also Contribute to our documentation.

I would like to work on this

Hello @degville , thanks. Working on this!

Hi @degville ,
I have a draft ready but would welcome your eye, and especially suggestions particularly on the other commands/errors/warnings etc.
I have created a gist here, and can also share in any other way that's convenient.
Thanks

@tawandamoyo Thank you so much for this - I'll take a look.

Provided some feedback -- I'm selfish and want this 👀


add peft generation example

What does this PR do?

Fixes # (issue)
Before submitting

[ ] This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
[ ] Did you make sure to update the documentation with your changes?
[ ] Did you write any new necessary tests?

@libinta

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.


New parser Security code scan (DotNet Security Scanner)

Security Code Scan - static code analyzer for .NET
https://security-code-scan.github.io/

After some Exchanges with @damiencarol and tests on m’y codebase, it seems this parler is not useful as we can have SARIF export. So I close this PR and we can use SARIF format to import SecurityCodeScan Findings
Thanks @damiencarol  for the HEADS Up !


Update hyper, url and anymap

Update hyper, url and anymap to the latest versions.
This is a breaking change, since it changes some dependencies.

I'll assume that this works on Windows. These dependency updates are copy-pasted from the async branch, where they have been tested before, so the odds are relatively good.
@homu r+

:pushpin: Commit 72c0fa4 has been approved by Ogeon

:zap: Test exempted - status


Add PackageDescription.Context API

Create PackageDescription.Context, which encapsulates context information available only at runtime.
Motivation:
This will permit package manifests to access their source files, which supports dependency generation activities such as dynamic creation of exclusion paths.
Modifications:
Adds a new struct Contextwhich provides two properties:  packageDirectory which points to the root directory of the current package; and environment which returns a Dictionary<String, String> that contains a snapshot of the build-time environment variables. The Context struct is backed by the internal struct ContextModel which is serialized by the manifest loader as JSON which is passed as a command line argument -context to the manifest process.
Result:
Packages will be able to use Context.current.packageDirectory to determine their package source directory at runtime. Environment variables are formally provided via Context.current.environment.

I've tested this working on Linux and Windows too. Currently the unit test doesn't work on Windows (times out), but I've tried Context.current.packageDirectory in some actual projects, and it does work.

Thanks for your work on this @pcbeard!  This is looking really good, I think, and it's mostly details to discuss.

@swift-ci please smoke test

@swift-ci please smoke test


Track tier group for restage when using a common archive

When storage tiering is configured to use a common archive tier, once the file goes to the common archive, it is not clear which tier group should be used when restaging the file.
It would make sense to track the initial group that the file was written to so that when it is restaged it can go to the appropriate resource that is in that group..

additionally... replicas of the same file could be in different groups?
and then would all end up in the same archive?


Improve the feedback on the cookie banner when the OK button is clicked

Currently, we have a delay between the time you click on the OK button of the cookie banner and the time the banner disappears. This is because we wait for the response of clicking before taking the banner off.
Acceptance Criteria
We don't want to have to wait for the response of clicking the OK button. Do not display the cookie banner immediately the OK button is clicked.

Done


fix "main" in package.json

https://github.com/getify/fpo/blob/master/scripts/build-core.js#L13 writes to './dist'

Oooops, great catch, thanks!


update export overview language

🚀 Deployed on https://62f3cb838a2c4f6260f1bef5--cozy-fox-0defec.netlify.app


v0.9.1_04: ‘?’ is not aligned with Y-axis description after clicking “Present”

SEVERITY: Minor
MODULE: Stage
Platform:

Windows 7 / Chrome 46.0
Windows 7 / Firefox 43.0
MAC / Safari 9.0

STEPS TO REPRODUCE:

Navigate to URL: https://stage-tools.gapminderdev.org/tools/
Tools page is loaded.
Select bubble map chart
Click “Present” icon which is at right bottom
Note that ‘?’ is not aligned with Y-axis description after clicking “Present”

ACTUAL RESULTS:
‘?’ is not aligned with Y-axis description after clicking “Present”
EXPECTED RESULTS:
‘?’ should be aligned with Y-axis description after clicking “Present”
SCREENSHOT:

Retest Result: Pass
Platform: Windows 7 / Chrome 46.0
Testing Environment: http://static.gapminderdev.org/vizabi/develop/preview/bubblemap.html

@angieskazka
This issue can be reproduced.
Module: Bubble map chart
Platform: Nexus 9 (5.1) / Chrome 47.0
Testing Environment: http://static.gapminderdev.org/vizabi/release/v0.9.2/preview/bubblemap.html

@jdk137 see how the alignment is done in mountain chart and just copy the solution (with constants in sizing profiles in updateSize method). it should work even if not reproduced =)
(try many contexts, like browsers and OS)


Update uploader documentation

Thanks the for the details instructions @pakhomov-dfinity. I left a few minor comments.

We have recently updated the bootstrapping logic to address the issues mentioned in this PR, so we can close this now.


Can we use react native ui kitten with nativewind?

NativeWind uses Tailwind CSS as scripting language to create a universal style system for React Native.
Can we mix the library with react native ui kitten?
If it's possible what's the potential incompatibility?

@universegalaxy1112 yes you can
Here is how you  can mix 2 theme providers (the example is with @shopify/restyle but the logic is the same)
https://github.com/akveo/react-native-ui-kitten/issues/1618#issuecomment-1125137347

what's the potential incompatibility?
I guess you will have some issues with dark mode and probably custom fonts but they are not blockers. You probably will need to wrap your own solution and export again components from UIKitten.

If your problem is solved can you please close the issue?
It sparks joy for maintainers ✨

Thank you, @flexbox


Include user list to cluster.yml

cluster.yml should have list of users which are added to htpasswd secret for htpasswd based auth. Also one of those users should be labeled cluster-admin.

Something like this
users:
- user1:pass1
- user2:pass2
cluster_admin: user1

Something like this
cluster_admin: user1

I did the same in my cluster operator, but I think something is better and more flexible:
cluster_role_binding:
- cluster_role: cluster-admin
  username: user1
- cluster_role: sudoer
  username: user2

Ok, having this in operator is better

Right, we can move a lot of post-install stuff into a generic post-install operator. It would be also a great demo. But first I prefer to add the stuff to our playbooks. And later one we move the playbooks into an ansible operator.

All done since https://github.com/RedHat-EMEA-SSA-Team/hetzner-ocp4/commit/2147b7092666fdc7a2062bf90c614157e884231f
Add to cluster.yml:

auth_htpasswd:
  - admin:$apr1$81BkJ4dI$XGcaDat/h529tjbf4SNH//
  - local:$apr1$81BkJ4dI$XGcaDat/h529tjbf4SNH//

auth_redhatsso:
  client_id: "xxxxxxx.apps.googleusercontent.com"
  client_secret: "xxxxxxxxxx"


LZA-Pipeline Organisation Limits and Container Memory Leak errors

Describe the bug
When Releasing the LZA pipeline I find that for large organisation I can encounter the following two errors at almost all stages of the pipeline, greatly extending the deployment time, with not possible means of resolving these issues other than retrying the failed stages until successful completion.
To Reproduce
Release an LZA pipeline
Expected behaviour
LZA to validate the stage and proceed to the next stage.
Please complete the following information about the solution:

[x] Version: 1.5.2

[x] Region: eu-west-2

[x] Was the solution modified from the version published on this repository? No

[ ] If the answer to the previous question was yes, are the changes available on GitHub?

[x] Have you checked your service quotas for the services this solution uses? Yes

[x] Were there any errors in the CloudWatch Logs? No

Screenshots

Additional context
As both of the errors highlighted in the screenshots show this action is taking place within an AWS container, hence there are no actions that I can undergo to mitigate them from occurring, furthermore, I am unsure what actions could be taken to prevent these errors from blocking future LZA actions.

Hello!
Thank you for utilizing the Landing Zone Accelerator on AWS (LZA) solution. We addressed this bug in our 1.8.0 version as you can see from our change log.
fix(organizations): throttling on ListAccounts call

Please upgrade your LZA version and let us know if you continue to have the same issue.


Support disabling misplaced_load lint

Bazel WORKSPACE files require load statements to be interspersed between invocations of repository rules, rather than all being at the top. This results in this lint being triggered erroneously.
My immediate thought is to add some kind of flag to Dialect, although maybe there is a better way.

Nevermind, we can easily filter out these lints via the LspContext.


Fixes #14542: Ensured only ASCII characters are in CSRF cookie value

Since binary data causes issues with ModSecurity and some browsers...

Q
A

Is bugfix?
yes

New feature?
no

Breaks BC?
no

Tests pass?
yes

Fixed issues
#14542

This may also fix #14302.


fix: oracle EndBlocker must be before gov and staking

Description
Oracle EndBlocker must be before gov module, otherwise, when oracle param.AcceptList will change we will misscalculate FX votes.

Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...

[ ] included the correct type prefix in the PR title
[ ] added ! to the type prefix if API or client breaking change
[ ] added appropriate labels to the PR
[ ] targeted the correct branch (see PR Targeting)
[ ] provided a link to the relevant issue or specification
[ ] added a changelog entry to CHANGELOG.md
[ ] included comments for documenting Go code
[ ] updated the relevant documentation or specification
[ ] reviewed "Files changed" and left comments if necessary
[ ] confirmed all CI checks have passed

Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...

[ ] confirmed the correct type prefix in the PR title
[ ] confirmed all author checklist items have been addressed
[ ] reviewed state machine logic
[ ] reviewed API design and naming
[ ] reviewed documentation is accurate
[ ] reviewed tests and test coverage
[ ] manually tested (if applicable)

Codecov Report

Merging #1434 (9a25844) into main (1f8bc6f) will not change coverage.
The diff coverage is 60.00%.

@@           Coverage Diff           @@
##             main    #1434   +/-   ##
=======================================
  Coverage   52.80%   52.80%
=======================================
  Files          70       70
  Lines        6751     6751
=======================================
  Hits         3565     3565
  Misses       2916     2916
  Partials      270      270

Impacted Files
Coverage Δ

ante/fee.go
78.35% <33.33%> (ø)

app/upgrades/v3/min_commission.go
85.71% <100.00%> (ø)

x/oracle/client/tests/suite.go
98.38% <100.00%> (ø)


First version of "import" page is ready

Some "todo" remaining: left for later in #24 #25 and #26
Fixes #17

Well, I have requested changes, but I didn't know that it would block merging. :sweat_smile: Of course, no changes are required, my comments were only suggestions. :+1:

On top of the comments by Hugo that I also mostly agree to (I am not sure about the place of the mapping part), here are the typos I saw in the document :

l. 42 --> I think the correct term is "manifest" and not "manifesto" ; I also think that "metadata" is plural and not singular so it should be "are visible" instead of "is visible"
l. 51 --> I think it should be a present "can" and not a conditional "could" as you also already used "can" right before
l. 79 --> it should be "Known" and not "Knwon"
l. 83 --> "useful" only has one 'l' at the end and "targeting" is written with only one 't' at the end

Also, around the lines 25-30 about the import of images, I have a recommendation for the tip related to a problem I sometimes encountered but you don't have to add it if you don't find it relevant --> when I upload big load of images (like 100 at the same time), it can make eScriptorium bug sometimes and it will not be able to upload one or two images in the mix, even though it load the images before and after. This is not a big issue as you can upload them afterwards but when you care about image orders, this is frustrating. So the advice regarding that would be to upload by little chunk (25 by 25 or something like that).

Thank you both for your feedback! They are all very good remarks, I'll make the changes

Also, around the lines 25-30 about the import of images, I have a recommendation for the tip related to a problem I sometimes encountered but you don't have to add it if you don't find it relevant --> when I upload big load of images (like 100 at the same time), it can make eScriptorium bug sometimes and it will not be able to upload one or two images in the mix, even though it load the images before and after. This is not a big issue as you can upload them afterwards but when you care about image orders, this is frustrating. So the advice regarding that would be to upload by little chunk (25 by 25 or something like that).

@FloChiff : you know that you can reorder images by dragging the "image" card in /images?

@alix-tz Well I do now !!! I discover a new thing everyday about eSc thanks to this tutorial 😄 !!!

I had to rebase because the config in mkdocs.yml was not up-to-date (the rendering of admonitions was not good).

Well, I have requested changes, but I didn't know that it would block merging. 😅 Of course, no changes are required, my comments were only suggestions. 👍

@HugoSchtr I don't understand why it's still requesting the validation of the reviews...


Add a QUIC adapter

List of candidates:

quiche (CANDIDATE) mio based: example
quinn Seems to be used on top on tokio.

We found quiche and the mozilla one overly specialized, so we'll adopt quinn whenever we bother making progress on this.

@burdges just curiosity,
how is quiche/mozilla one(probably neqo) is specialized? This is just a question cause I'm also interested in QUIC ... 🙏


v1.5.0 resulting in much lower umi counts than v1.4.4 with same settings..?

Dear @Hoohm ,
I'm sorry for opening yet another issue... I know the v1.5.0 is still under development, so hopefully my feedback can be useful. Although this problem may sound a bit vague.
I've tried running a single dataset through both v1.4.4 and v1.5.0 with the same settings, but it gives very different results. After the 1.5 run the large majority of cells have a raw umi count of zero for all 6 CITEseq-tags, whereas for the v1.4 run the raw umi counts are overall much higher and definitely not zero. Notably, the number of corrected UMIs is very different when comparing the run reports (below). I don't understand what causes this difference?
The 1.4.4 results fit much better with what I would expect from this experiment.

Thank you very much for all these tests.
Lower umi correction is expected as 1.4.* were "correcting" the unmapped feature, which doesn't really make sense.
Lower umi counts is not expected and a bit worrisome. Are you using the same whitelist/top_cells arguments?

And more specifically, are you using a 10xV3 chemistry?

Thank you for the quick reply!
Sorry, this problem actually seems to occur only with a slightly older version of 1.5.0... after your latest commit that also fixed my previous issue with the "translation" column in the whitelist being a requirement instead of being optional, the umi counts are very similar to what v1.4.4 gives me. Sorry that I muddled this up!!
Not sure what caused the difference I observed (I was using same number of expected cells and same whitelist file) but it does seem linked to the difference in number of umis corrected, as after the latest 1.5.0 updates this number also went up to almost match the number from the v1.4.4 run.

I'm closing this since it seems to be fixed.


[benchmark] Add a benchmark for floating point parsing performance

Add benchmarks for floating point parsing to test the improvements from https://github.com/apple/swift/pull/24198.
I've used two test sets to match the FloatingPointPrinting benchmark, but both have identical performance locally so I'm not convinced they're needed.
@milseman

@stephentyrone, any thoughts on the workload formulation?

@swift-ci please benchmark

Performance: -O

TEST
OLD
NEW
DELTA
RATIO

Regression

ObjectiveCBridgeStubNSDateRefAccess
371
400
+7.8%
0.93x (?)

Added

FloatingPointParsing_Double_small
11000
11400
11133
—

FloatingPointParsing_Double_uniform
14800
15500
15033
—

FloatingPointParsing_Float80_small
13716
14148
13860
—

FloatingPointParsing_Float80_uniform
15900
16500
16100
—

FloatingPointParsing_Float_small
13500
13932
13644
—

FloatingPointParsing_Float_uniform
3400
3500
3433
—

Performance: -Osize

TEST
OLD
NEW
DELTA
RATIO

Improvement

ObjectiveCBridgeStubFromNSDateRef
4480
3940
-12.1%
1.14x (?)

SortLettersInPlace
564
508
-9.9%
1.11x (?)

ObjectiveCBridgeStubNSDateRefAccess
400
371
-7.2%
1.08x (?)

Added

FloatingPointParsing_Double_small
11500
11800
11600
—

FloatingPointParsing_Double_uniform
15400
16000
15633
—

FloatingPointParsing_Float80_small
14148
14580
14292
—

FloatingPointParsing_Float80_uniform
16400
17000
16600
—

FloatingPointParsing_Float_small
13932
14256
14040
—

FloatingPointParsing_Float_uniform
3500
3600
3533
—

Performance: -Onone

TEST
OLD
NEW
DELTA
RATIO

Regression

ObjectiveCBridgeStubFromNSDate
6260
7240
+15.7%
0.86x (?)

ObjectiveCBridgeStubDateAccess
5400
6023
+11.5%
0.90x (?)

ObjectiveCBridgeStubNSDateRefAccess
5120
5639
+10.1%
0.91x (?)

Added

FloatingPointParsing_Double_small
14600
15100
14767
—

FloatingPointParsing_Double_uniform
18000
18700
18233
—

FloatingPointParsing_Float80_small
18576
19008
18720
—

FloatingPointParsing_Float80_uniform
20400
21200
20667
—

FloatingPointParsing_Float_small
18144
18684
18324
—

FloatingPointParsing_Float_uniform
7000
7400
7167
—

✅
Benchmark Check Report

⛔🔤
FloatingPointParsing_Float80_uniform name doesn`t conform to benchmark naming convention.  See http://bit.ly/BenchmarkNaming

⛔🔤
FloatingPointParsing_Float_uniform name doesn`t conform to benchmark naming convention.  See http://bit.ly/BenchmarkNaming

⛔🔤
FloatingPointParsing_Float80_small name doesn`t conform to benchmark naming convention.  See http://bit.ly/BenchmarkNaming

⛔🔤
FloatingPointParsing_Float_small name doesn`t conform to benchmark naming convention.  See http://bit.ly/BenchmarkNaming

⛔🔤
FloatingPointParsing_Double_uniform name doesn`t conform to benchmark naming convention.  See http://bit.ly/BenchmarkNaming

⛔🔤
FloatingPointParsing_Double_small name doesn`t conform to benchmark naming convention.  See http://bit.ly/BenchmarkNaming

How to read the data
The tables contain differences in performance which are larger than 8% and
differences in code size which are larger than 1%.
If you see any unexpected regressions, you should consider fixing the
regressions before you merge the PR.
Noise: Sometimes the performance results (not code size!) contain false
alarms. Unexpected regressions which are marked with '(?)' are probably noise.
If you see regressions which you cannot explain you can try to run the
benchmarks again. If regressions still show up, please consult with the
performance team (@eeckstein).

Hardware Overview
  Model Name: Mac Pro
  Model Identifier: MacPro6,1
  Processor Name: 12-Core Intel Xeon E5
  Processor Speed: 2.7 GHz
  Number of Processors: 1
  Total Number of Cores: 12
  L2 Cache (per Core): 256 KB
  L3 Cache: 30 MB
  Memory: 64 GB

If you change the names and drop the legacyFactor, I think we're good to go

Agreed. I'm OK with the input distribution; it can probably be adjusted some down the road, but it's a great start.

I've pushed those naming changes.
On a side note, those results seems strange to me. Why would the small workload be faster for Double and Float80 but significantly slower for Float? The results do match what I get locally, though, and I can't see any issues in the test code that would cause this, so I guess that's just the performance profile.
TEST                                     SAMPLES MIN(μs) Q1(μs) MEDIAN(μs) Q3(μs) MAX(μs) MAX_RSS(B)
531 ParseFloat.Double.small                      200     105    106        111    116     133      90112
532 ParseFloat.Double.uniform                    201     141    142        148    156     176      94208
533 ParseFloat.Float.small                       200     117    118        123    130     145      98304
534 ParseFloat.Float.uniform                     193      28     28         28     31      33      98304
535 ParseFloat.Float80.small                     200     119    120        125    131     151      90112
536 ParseFloat.Float80.uniform                   201     150    151        158    166     187      98304

Why would the small workload be faster for Double and Float80 but significantly slower for Float? The results do match what I get locally, though, and I can't see any issues in the test code that would cause this, so I guess that's just the performance profile.

That's easy to answer. Most of the uniform inputs are out of the representable range for Float, and can be immediately returned based on the exponent alone. For Double and Float80 they require processing the significand and careful rounding.

If it'd be worth using different test sets for each type, that would be simple enough to do; I just used the FloatingPointPrinting code to generate it for Double and hadn't considered that. For future extension, this post about Rust's parsing contains links to a few test suites that might be useful, although I'm not sure how licensing considerations would come into play. Otherwise, if we're fine with this as a starting point, this should be ready to merge.

@swift-ci please smoke benchmark

@swift-ci please smoke test

@swift-ci please smoke benchmark

@swift-ci Please smoke test

@swift-ci please benchmark

@swift-ci please benchmark

I’ve changed the benchmark names to follow the casing rules (lowerCase is reserved for methods only). Naming convention rule clarification is pending in #24237.

@stephentyrone

most of the uniform inputs are out of the representable range for Float, and can be immediately returned based on the exponent alone. For Double and Float80 they require processing the significand and careful rounding.

This does bother me a bit. Is there anything that would complicate the “simplistic” tweak of just clamping the exponents in the uniform workload to fit into Float range?

Performance: -O

TEST
OLD
NEW
DELTA
RATIO

Regression

ObjectiveCBridgeStubNSDateRefAccess
371
400
+7.8%
0.93x (?)

Added

ParseFloat.Double.Small
112
114
113
—

ParseFloat.Double.Uniform
151
156
153
—

ParseFloat.Float.Small
127
130
128
—

ParseFloat.Float.Uniform
35
36
35
—

ParseFloat.Float80.Small
131
134
132
—

ParseFloat.Float80.Uniform
164
167
166
—

Performance: -Osize

TEST
OLD
NEW
DELTA
RATIO

Improvement

ObjectiveCBridgeStubFromNSDateRef
4730
3940
-16.7%
1.20x (?)

ObjectiveCBridgeStubNSDateRefAccess
400
371
-7.2%
1.08x (?)

Added

ParseFloat.Double.Small
116
117
116
—

ParseFloat.Double.Uniform
155
159
156
—

ParseFloat.Float.Small
125
127
126
—

ParseFloat.Float.Uniform
34
35
34
—

ParseFloat.Float80.Small
131
133
132
—

ParseFloat.Float80.Uniform
164
168
165
—

Performance: -Onone

TEST
OLD
NEW
DELTA
RATIO

Regression

ObjectiveCBridgeStubFromNSDate
6250
7260
+16.2%
0.86x (?)

Improvement

ObjectiveCBridgeStubFromNSDateRef
5450
4420
-18.9%
1.23x (?)

TypeFlood
207
193
-6.8%
1.07x (?)

Added

ParseFloat.Double.Small
153
156
154
—

ParseFloat.Double.Uniform
190
196
192
—

ParseFloat.Float.Small
172
176
174
—

ParseFloat.Float.Uniform
73
75
74
—

ParseFloat.Float80.Small
168
171
169
—

ParseFloat.Float80.Uniform
200
204
203
—

✅
Benchmark Check Report

How to read the data
The tables contain differences in performance which are larger than 8% and
differences in code size which are larger than 1%.
If you see any unexpected regressions, you should consider fixing the
regressions before you merge the PR.
Noise: Sometimes the performance results (not code size!) contain false
alarms. Unexpected regressions which are marked with '(?)' are probably noise.
If you see regressions which you cannot explain you can try to run the
benchmarks again. If regressions still show up, please consult with the
performance team (@eeckstein).

Hardware Overview
  Model Name: Mac Pro
  Model Identifier: MacPro6,1
  Processor Name: 12-Core Intel Xeon E5
  Processor Speed: 2.7 GHz
  Number of Processors: 1
  Total Number of Cores: 12
  L2 Cache (per Core): 256 KB
  L3 Cache: 30 MB
  Memory: 64 GB

On second thought, I’d think it would be better to not store the workloads as [String]. @troughton could you please generate the workloads in the setUpFunction for each type?

Performance: -O

TEST
OLD
NEW
DELTA
RATIO

Regression

DataAppendDataLargeToLarge
37600
50400
+34.0%
0.75x (?)

ObjectiveCBridgeStubNSDateRefAccess
371
400
+7.8%
0.93x (?)

Added

ParseFloat.Double.Small
110
113
111
—

ParseFloat.Double.Uniform
148
153
150
—

ParseFloat.Float.Small
125
129
127
—

ParseFloat.Float.Uniform
34
36
35
—

ParseFloat.Float80.Small
127
132
129
—

ParseFloat.Float80.Uniform
159
166
161
—

Performance: -Osize

TEST
OLD
NEW
DELTA
RATIO

Improvement

ObjectiveCBridgeStubFromNSDateRef
4480
3940
-12.1%
1.14x (?)

ObjectiveCBridgeStubNSDateRefAccess
400
371
-7.2%
1.08x (?)

Added

ParseFloat.Double.Small
115
118
116
—

ParseFloat.Double.Uniform
154
160
156
—

ParseFloat.Float.Small
128
133
130
—

ParseFloat.Float.Uniform
35
37
36
—

ParseFloat.Float80.Small
133
136
134
—

ParseFloat.Float80.Uniform
164
170
166
—

Performance: -Onone

TEST
OLD
NEW
DELTA
RATIO

Improvement

ObjectiveCBridgeStubFromNSDateRef
5460
4430
-18.9%
1.23x (?)

Added

ParseFloat.Double.Small
148
160
152
—

ParseFloat.Double.Uniform
180
188
183
—

ParseFloat.Float.Small
173
179
175
—

ParseFloat.Float.Uniform
70
73
71
—

ParseFloat.Float80.Small
170
176
172
—

ParseFloat.Float80.Uniform
200
208
203
—

✅
Benchmark Check Report

How to read the data
The tables contain differences in performance which are larger than 8% and
differences in code size which are larger than 1%.
If you see any unexpected regressions, you should consider fixing the
regressions before you merge the PR.
Noise: Sometimes the performance results (not code size!) contain false
alarms. Unexpected regressions which are marked with '(?)' are probably noise.
If you see regressions which you cannot explain you can try to run the
benchmarks again. If regressions still show up, please consult with the
performance team (@eeckstein).

Hardware Overview
  Model Name: Mac Pro
  Model Identifier: MacPro6,1
  Processor Name: 12-Core Intel Xeon E5
  Processor Speed: 2.7 GHz
  Number of Processors: 1
  Total Number of Cores: 12
  L2 Cache (per Core): 256 KB
  L3 Cache: 30 MB
  Memory: 64 GB

@stephentyrone

For Double and Float80 they require processing the significand and careful rounding.

If I understand correctly, this would imply to me, that when we generate the .Small and .Uniform variant workloads by printing them to [String], these would be fitting exactly, without any rounding.  So there should be another (.Oversized ?) variant, that would stress that part of the parsing?

If we're going to attempt come up with better distributions now, I would like to see the following:

Values following a truncated exponential distribution on 0...1000, each rounded to a number of significant digits uniformly selected from 1...6 (Float), 1...15 (Double) and 1...18 (Float80). This is a good representative sample of "well-scaled" values humans actually write in programs--in particular, it includes good coverage for integer values and values with short decimal parts.

Values made up of uniform decimal significands with 9, 17 and 21 digits and exponents uniform on the valid range. This is a stress test for rounding, and covers all the worst cases for tables generated by programs.

I would prefer to have these stored as strings in the source for the test (to protect us against system differences in underlying math functions that are used to generate them and any runtime bugs that may be fixed), but include the code to generate them.

@palimondo

On second thought, I think it would be better to not store the workloads as precomputed [String] in the source file. @troughton could you please generate the workloads in the setUpFunction with proper ranges for each type? See here for an example.

Out of curiosity, why is this better?

If we're going to attempt come up with better distributions now, I would like to see the following...

This is a pretty significant scope-creep for this benchmark. @stephentyrone, how significant would this improve our performance tracking? Do you think you can help @troughton form these workloads?

This is a pretty significant scope-creep for this benchmark. @stephentyrone, how significant would this improve our performance tracking? Do you think you can help @troughton form these workloads?

Agreed, which is why I'm OK with taking them as is now and fixing it later =).
I'm happy to help with that, but likely won't have bandwidth until after WWDC.

How does the latest revision look?
Local results:
       TEST                                     SAMPLES MIN(μs) Q1(μs) MEDIAN(μs) Q3(μs) MAX(μs) MAX_RSS(B)
531 ParseFloat.Double.Exp                        194      63     64         67     70      79     106496
532 ParseFloat.Double.Uniform                    200     110    111        116    121     138     106496
533 ParseFloat.Float.Exp                         198      40     41         43     45      52      94208
534 ParseFloat.Float.Uniform                     199      90     90         94     99     112     106496
535 ParseFloat.Float80.Exp                       200      86     86         88     95     108      98304
536 ParseFloat.Float80.Uniform                   204     767    788        813    845     928     110592

@milseman:

Out of curiosity, why is this better?

To avoid the need to store separate workloads for each tested type. I thought a single generator is easier to understand than a large set of precomputed strings.
I also think we don't need to be that much defensive against minor implementation and runtime changes as @stephentyrone described, since this is not a unit test. If we obtain the floats from pseudorandom generator (say SplitMix64), we'll be stable between benchmark runs and provided the statistical properties of the underlying distribution hold, such changes should have unmeasurable impact on performance.

@swift-ci please smoke test

@swift-ci please smoke benchmark

@swift-ci please benchmark

@swift-ci please benchmark

Linux smoke test failed because of missing Dispatch?! 🤷♂

@swift-ci please benchmark

@swift-ci please smoke test linux platform

@swift-ci please benchmark

@swift-ci please benchmark

Performance: -O

TEST
MIN
MAX
MEAN
MAX_RSS

Added

ParseFloat.Double.Exp
62
63
62
—

ParseFloat.Double.Uniform
116
120
117
—

ParseFloat.Float.Exp
43
45
44
—

ParseFloat.Float.Uniform
96
98
97
—

ParseFloat.Float80.Exp
96
99
97
—

ParseFloat.Float80.Uniform
1022
1025
1024
—

Performance: -Osize

TEST
OLD
NEW
DELTA
RATIO

Improvement

ObjectiveCBridgeStubFromNSDateRef
4480
3940
-12.1%
1.14x (?)

ObjectiveCBridgeStubNSDateRefAccess
400
371
-7.2%
1.08x (?)

Added

ParseFloat.Double.Exp
66
68
67
—

ParseFloat.Double.Uniform
122
127
124
—

ParseFloat.Float.Exp
45
46
45
—

ParseFloat.Float.Uniform
98
100
99
—

ParseFloat.Float80.Exp
98
101
99
—

ParseFloat.Float80.Uniform
1026
1027
1027
—

Performance: -Onone

TEST
OLD
NEW
DELTA
RATIO

Regression

ObjectiveCBridgeStubFromNSDate
6250
7260
+16.2%
0.86x (?)

ObjectiveCBridgeStubNSDateRefAccess
5688
6281
+10.4%
0.91x (?)

ObjectiveCBridgeStubDateAccess
6043
6641
+9.9%
0.91x (?)

Improvement

ObjectiveCBridgeStubFromNSDateRef
5460
4450
-18.5%
1.23x (?)

ObjectiveCBridgeStubFromNSString
913
844
-7.6%
1.08x (?)

Added

ParseFloat.Double.Exp
93
96
94
—

ParseFloat.Double.Uniform
153
159
155
—

ParseFloat.Float.Exp
80
82
81
—

ParseFloat.Float.Uniform
136
139
137
—

ParseFloat.Float80.Exp
137
141
139
—

ParseFloat.Float80.Uniform
1062
1065
1064
—

✅
Benchmark Check Report

⚠⏱
ParseFloat.Float80.Uniform execution took at least 1019 μs.  Decrease the workload of ParseFloat.Float80.Uniform by a factor of 2 (10), to be less than 1000 μs.

How to read the data
The tables contain differences in performance which are larger than 8% and
differences in code size which are larger than 1%.
If you see any unexpected regressions, you should consider fixing the
regressions before you merge the PR.
Noise: Sometimes the performance results (not code size!) contain false
alarms. Unexpected regressions which are marked with '(?)' are probably noise.
If you see regressions which you cannot explain you can try to run the
benchmarks again. If regressions still show up, please consult with the
performance team (@eeckstein).

Hardware Overview
  Model Name: Mac Pro
  Model Identifier: MacPro6,1
  Processor Name: 12-Core Intel Xeon E5
  Processor Speed: 2.7 GHz
  Number of Processors: 1
  Total Number of Cores: 12
  L2 Cache (per Core): 256 KB
  L3 Cache: 30 MB
  Memory: 64 GB

I wonder why the CI widget wasn’t showing the benchmarks run as pending. But the benchmark report looks fine. 👍

Performance: -O

TEST
OLD
NEW
DELTA
RATIO

Regression

ObjectiveCBridgeStubToNSDate2
460
640
+39.1%
0.72x (?)

Added

ParseFloat.Double.Exp
56
58
57
—

ParseFloat.Double.Uniform
104
109
106
—

ParseFloat.Float.Exp
40
42
41
—

ParseFloat.Float.Uniform
88
91
89
—

ParseFloat.Float80.Exp
86
89
87
—

ParseFloat.Float80.Uniform
918
936
925
—

Performance: -Osize

TEST
OLD
NEW
DELTA
RATIO

Improvement

DataAppendDataLargeToLarge
45200
32400
-28.3%
1.40x (?)

ObjectiveCBridgeStubNSDateRefAccess
359
333
-7.2%
1.08x (?)

Added

ParseFloat.Double.Exp
60
62
61
—

ParseFloat.Double.Uniform
111
116
113
—

ParseFloat.Float.Exp
39
43
41
—

ParseFloat.Float.Uniform
86
90
87
—

ParseFloat.Float80.Exp
88
91
89
—

ParseFloat.Float80.Uniform
919
922
920
—

Performance: -Onone

TEST
OLD
NEW
DELTA
RATIO

Regression

ObjectiveCBridgeStubFromNSDate
5720
6640
+16.1%
0.86x (?)

ObjectiveCBridgeStubNSDateRefAccess
4817
5358
+11.2%
0.90x (?)

ObjectiveCBridgeStubDateAccess
5221
5687
+8.9%
0.92x (?)

Improvement

ObjectiveCBridgeStubFromNSDateRef
4890
4000
-18.2%
1.22x (?)

Added

ParseFloat.Double.Exp
89
92
90
—

ParseFloat.Double.Uniform
140
145
142
—

ParseFloat.Float.Exp
72
75
73
—

ParseFloat.Float.Uniform
121
125
122
—

ParseFloat.Float80.Exp
125
130
127
—

ParseFloat.Float80.Uniform
959
962
960
—

✅
Benchmark Check Report

How to read the data
The tables contain differences in performance which are larger than 8% and
differences in code size which are larger than 1%.
If you see any unexpected regressions, you should consider fixing the
regressions before you merge the PR.
Noise: Sometimes the performance results (not code size!) contain false
alarms. Unexpected regressions which are marked with '(?)' are probably noise.
If you see regressions which you cannot explain you can try to run the
benchmarks again. If regressions still show up, please consult with the
performance team (@eeckstein).

Hardware Overview
  Model Name: Mac Pro
  Model Identifier: MacPro6,1
  Processor Name: 8-Core Intel Xeon E5
  Processor Speed: 3 GHz
  Number of Processors: 1
  Total Number of Cores: 8
  L2 Cache (per Core): 256 KB
  L3 Cache: 25 MB
  Memory: 64 GB

Hmm… I really have to fix run_smoke_bench.py to gather multiple samples for new benchmarks. It looks like these new benchmarks have quite large variability between independent executions. ParseFloat.Float80.Uniform went from 1022 to 918, that’s about 10% if I’m not mistaken.

After looking at SwiftDtoa.cpp I think I now better understand why @stephentyrone recommend the workload storage in precomputed [String] to guard against possible runtime changes. I haven’t realized it is still an active research area. I’m leaving this here as a breadcrumb for anyone who's learning about that complexity as I did, via forum post referenced in @milseman’s Pitch: Offsetting Indices and Relative Ranges.


Can't install on a clean macOS without git installded

Install nvm on a clean macOS will fail as below:
$ curl -o- https://raw.githubusercontent.com/creationix/nvm/v0.33.8/install.sh | bash
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100 12540  100 12540    0     0  43532      0 --:--:-- --:--:-- --:--:-- 43693
=> Downloading nvm from git to '/Users/peter/.nvm'
=> xcode-select: note: no developer tools were found at '/Applications/Xcode.app', requesting install. Choose an option in the dialog to download the command line developer tools.
Failed to clone nvm repo. Please report this!

It'll also open a dialog to ask about installing Xcode with command line tools or not:

The problem is because the path /usr/bin/git is actually the built-in Xcode, so nvm can find git successfully and assume git is installed and working.

I'm not sure how this can be addressed; typically the first thing you always have to do (manually) when setting up a new Mac is install the Xcode command line tools.

I haven't found a method to suppress the GUI dialog asking to install Xcode command line tools, otherwise we can at least escape from that failure without providing useful info :(

I think that installing those prior to doing anything else - including installing nvm - is just something Mac devs need to know how to do.

Maybe I can send a PR to just mention that README.md?

I suppose, but i still think it’s something that a Mac dev just needs to know, and I’m not sure why they’d be learning it at the point of installing nvm.

I'll like to mention that also because we can't properly handle it, we don't know if anyone would install nvm first ;)

i suppose, sure


bug correction on the satellite hardware code bias computation.

I noticed discontinuities in the residuals of a solution. They were due to wrong satellite code bias (total group delays) computation.

@jtec do note review yet, I would like to add some other tests.

@jtec, ready for review. After one night, I feel like I captured better the essence of the bug 😂.

@jtec, this one is ready :)


[SQLLab] cannot scroll to bottom of table using scrollbar

Make sure these boxes are checked before submitting your issue - thank you!

[x] I have checked the superset logs for python stacktraces and included it here as text if any
[x] I have reproduced the issue with at least the latest released version of superset
[x] I have checked the issue tracker for the same issue and I haven't found one similar

Superset version
0.18.5
Expected results
Regardless of the width of the Results table in SQLLab, the whole table can be scrolled though vertically using the scrollbar handle.
Actual results
Depending on whether the table width requires a horizontal scroll bar or not, the vertical scroll bar has much different length and thus much different travel.
When the horizontal scroll bar is shown, the vertical bar hanlde is very long, resulting on a tiny travel that makes manual scrolling to the bottom of the table impossible. Only by using the mouse scroll wheel, all rows can be scrolled through.
Steps to reproduce
Taking the url table from superset's main database as example:

Small width of Results table:

Larger width by including the url field:

Issue is still present in 0.19.1.
Actually, a functioning vertical scrollbar is there, however, it is only visible when scrolling to the far right of the horizontal scroll range.

So, as soon as there is a horizontal scrollbar present, we happen to have two vertical scrollbars, of which the outer one ist the one which is always visible, but the inner one ist the one that actually works.

Notice: this issue has been closed because it has been inactive for 235 days. Feel free to comment and request for this issue to be reopened.

@mistercrunch please reopen


"minDate" and "maxDate" still seem have no any real affect in Android 4.4.2

"minDate" and "maxDate" still seem have no any real affect in Android 4.4.2

this should be documented. In the docs it doesnt say that maxDate is a number and not an actual date.


Meraki Review - Notion Page

here the list of bugs
https://www.notion.so/platformatic/Meraki-Review-fdb91c79711c499f91150371eeaf2428

Can we close this now @tonysnowboardunderthebridge ?

@marcopiraccini I need to double check the remaining points on notion page

Please do, and if there are remaining stuff, please open a separate issue. Otherwise is not clear what is left and the priority of what is left

I'll close it and open a new issue with the remaining stuff


AsyncEnumerable support

Only for netstandard2.1 and above, adds support for IAsyncEnumerable as an input stream

Since you're bumping to 4.0, then we need a quick note on the README and the docs to talk about what's different.

README.md
docs/index.md

Added docs

@garoyeri look good now?

@jbogard  Looks good, Bill took a look too and didn't find any issues. We'll discuss it at the next Tech Lead meeting tomorrow and we can close it out unless someone has a blocking issue with it. Thanks!


There is no way to remove the event listeners once they are added

I noticed that there is no way to add and remove nativesortable's functionality "easily" on the fly - the only way I have been able to remove the functionality is by cloning the element I added it to, and replacing the original with the clone (removes all listeners).  I believe this is because the functions attached to the listeners are private, and are treated as anonymous by the browser - so I have no way to remove them directly.
There might be something I'm missing, though. Is there any way to add this to an element and remove it without recreating the element?

You are right, there isn't a way to destroy the functionality right now.  If someone would be interested in adding this, I'd accept a PR.  We could make nativesortable return an object with a destroy function that cleans up after itself.


Add hunspell token filter #8061

Description
Add hunspell token filter
Issues Resolved
Closes https://github.com/opensearch-project/documentation-website/issues/8061
Version
all
Checklist

[x] By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and subject to the Developers Certificate of Origin.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

I did not include "dedup" parameter, as it does not seem to work. The duplicates are always returned.
Also the configuration for indices.analysis.hunspell.dictionary.ignore_case, does not seem to have any impact.
Also was unable to see any difference in behaviour when adding indices.analysis.hunspell.dictionary.lazy: true
If there is a difference I can add it back in.

@udabhas Will you see this PR's comments from the technical writer RE: dedup parameter and provide your feedback? Thank you.

@AntonEliatra I would enter this as a bug in the main OpenSearch repo.

Bug issue added https://github.com/opensearch-project/OpenSearch/issues/15417
and parameter added to the PR

@varun-lodaya The documentation is awaiting tech review and approval, which is delaying progress. Could you please suggest alternative reviewers who can assist with this task in a timely manner? We're eager to move this forward. Thank you.

@varun-lodaya The documentation is awaiting tech review and approval, which is delaying progress. Could you please suggest alternative reviewers who can assist with this task in a timely manner? We're eager to move this forward. Thank you.

@varun-lodaya This is over a month old. We need tech review approval to move it forward in the documentation process. Please review this week or provide a peer who can review it. Thank you.


Make separate files of tables

Instead of putting them all in a single tables.py file

Solved by #17


Sign grinder requests to gngr with the auth key

I am merging this with #13 because they are more closely tied than I thought initially.


FORCE_COLOR=0 does not disable

I did some simple experiments, and FORCE_COLOR=0 does not disable colors.
For example:
// a.js
const chalk = require('chalk');
console.log(chalk.red('foobar'));

//b.js
process.stdin.resume().pipe(process.stdout);

#!/usr/bin/env bash
FORCE_COLOR=0 node a.js | node b.js

color will be used in b.js, whether it's FORCE_COLOR=1 or FORCE_COLOR=0

Even if I do this, it still still doesn't work as documented:

Which version of chalk are you using?

v1.1.3

FORCE_COLOR=0 was not introduced until v2 IIRC.

ok got it thx

We had a lengthy discussion over at chalk/supports-color#31. :) You're welcome to go see some of the discussion and decision making there.

thanks yeah, seems like it's a noisy room over there so I will let it go :)


 description of the BlazorOptions class in Razor Components is wrong...

In the  tag for the BlazorOptions class

should be

Note: I've previously posted issues about similar mistakes, to which the Asp.Net team responded with the suggestion that I should post a Pull request. Unfortunately, I can't post Pull requests. You guys should do it yourselves.

In the <summary> tag for the BlazorOptions class
<see cref="ComponentsApplicationBuilderExtensions.UseBlazor(IApplicationBuilder, BlazorOptions)"/>
should be
<see cref="BlazorApplicationBuilderExtensions.UseBlazor(IApplicationBuilder, BlazorOptions)"/>
Note: I've previously posted issues about similar mistakes, to which the Asp.Net team responded with the suggestion that I should post a Pull request. Unfortunately, I can't post Pull requests. You guys should do it yourselves.

Thanks for contacting us, @enetstudio.
Sure, we'll fix it.


Upstream kevm hooks v2

This PR is identical to #886 but the branch lives in the evm-semantics repo directly instead of on my forked repo. See #886 for discussion on relevant issues for this PR.
Moving the PR here resolves an issue with testing modified Jenkinsfiles --- as a security precaution, Jenkins CI does not test Jenkinsfiles updates from forks.

@ehildenb @dwightguth So, continuing the discussion from #886, this PR integrates the blockchain plugin currently into evm-semantics in the following manner:

In the Makefile, the K include path was updated as follows:
K_INCLUDE_PATH     := $(BUILD_LOCAL)/include/kframework/

The blockchain plugin was updated with an install target:
PLUGIN_NAMESPACE := blockchain-k-plugin
install:
        @mkdir -p $(PREFIX)/$(PLUGIN_NAMESPACE)
        cp plugin/* $(PREFIX)/$(PLUGIN_NAMESPACE)

The Makefile target plugin-deps was extended with an action:
cd deps/plugin && \
    make PREFIX=$(K_INCLUDE_PATH) install

The requires krypto.md clauses in kevm source files were updated to requires blockchain-k-plugin/krypto.md

The Jenkinsfile was updated to do make plugin-deps before make build ...

Questions:

With regards to step (5), it is possible to have the Makefile build-XXX targets depend on the plugin directly, so an extra build step in the Jenkinsfile is not needed. Do you guys have preferences?
With regards to step (4), we have a potential issue that local includes and not distinct from global includes, i.e. the #include "file.h" vs. #include <file.h> --- and that package directory names (such as blockchain-k-plugin) could overlap with subdirectories included in user-defined semantics. Obviously, there are basically no packages now, so this isn't a big deal, but it seems like an potential future issue to me and I'd rather we all be aware of it.


How specified template in Sails 1.1.0?

old version i can use sails new sails-jade --template=jade.

Hi @ncc0706,
Jade (now known as Pug) is still supported though consolidate.
Were you able to install consolidate to your new project?


flush cloudflare cache of collective's page after refunding

this Pr solves: https://github.com/opencollective/opencollective/issues/2354

Can you rebase and push the result?


📝 Remove model_config.md page

Related to https://github.com/pydantic/pydantic/issues/7322

@Kludex can we close this? I assume this was done in the big docs refactor we did a few weeks back...

We need to get this in. I'll rebase tomorrow.


Add reference to ProduceReferenceAssembly

[Enter feedback here]
reference ProduceReferenceAssembly to make this discoverable from search

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: d5ca424e-247c-138d-1c41-9c2b116862df
Version Independent ID: adc585dd-e215-4c70-f9a6-38a0e91e46da
Content: Breaking change: Write reference assemblies to IntermediateOutputPath - .NET
Content Source: docs/core/compatibility/sdk/6.0/write-reference-assemblies-to-obj.md
Product: dotnet-fundamentals
GitHub Login: @gewarren
Microsoft Alias: gewarren

@redwyre It looks like ProduceReferenceAssembly defaults to true for projects that target .NET 5 and later, so most people wouldn't be setting it explicitly. But I'm interested in why you think people would be searching on it.

@baronfel Do you think a reference to ProduceReferenceAssembly should be added, and if so, in what context?

The option is already quite well documented in the c# compiler options so I'm inclined to say we shouldn't need to add anymore. I'm definitely amenable to changing that feeling based on @redwyre's context, though. The wording of this page might be changed to suggest that reference assemblies aren't required to be generated from a given build? They're a performance optimization, after all.

I enable ProduceReferenceAssembly because we ship them, and the new change broke the build, but ProduceReferenceAssembly is all I was setting in my csproj so there's nothing to link that you now need ProduceReferenceAssemblyInOutDir to get the same behaviour when you were relying on it. So just adding that to the page would make it discoverable for people like me that were wondering "why isn't ProduceReferenceAssembly working any more?"

Proposed new verbiage for the Old behavior section:

Old behavior
Since reference assemblies were added, the .NET SDK has written reference assemblies to the ref directory in the OutDir directory of the compilation. In .NET 5, the ProduceReferenceAssembly property was introduced and defaulted to true for .net5.0 and higher applications, so many applications began generating reference assemblies to this directory implicitly.

@redwyre you set this property to true explicitly, so I'm gathering that you're not targeting net5.0+ for these projects?

The projects have been updated from .net core -> net5 -> net6, but I set it to true originally because I explicitly use the reference dlls as build outputs (which is why it's a breaking change).


Request for vim9: Cast to boolean implicitly

Is your feature request about something that is currently impossible or hard to do? Please describe the problem.
The doc of vim9 says "Any type of variable can be used as a condition", but they cannot be assigned or returned as a boolean unless they are cast explicitly.
Moreover, every vim builtin functions returns 1 or 0 instead of a boolean, so you frequently need to cast them to boolean.
I wonder if this implicit casting will be implemented to vim9.
Following script works only when g:foo exists AND is v:true or v:false, otherwise E1029 is thrown.
def s:is_foo(): bool
  return exists('g:foo') && g:foo
enddef

echo s:is_foo()

Describe the solution you'd like
Cast any expressions to boolean implicitly.
Describe alternatives you've considered
!!(exists('g:foo') && g:foo) does work, but I feel it's redundant.

Yes, there is a balance to be found here between type-safety and convenience.
We have already made it so that when a function argument is true/false one can also use zero and one.
It is also unlikely that this leads to mistakes, so long as we don't accept other numbers.
bool flag = 1  # looks like true
bool flag = 99 # must be a mistake, type should be number
bool flag = -1  # not sure what the intention was here
For conditions it's clear that we need a true/false outcome.  Here we could also be strict, but following Typescript, like we do in several other places, loose type checking makes it easier to write.  This uses the concept of Truthy and Falsy.  Personally I have a slight preference to be more strict, but keeping in line with Typescript is more important.
We do fix one inconsistency of Typescript: an empty string is Falsy while an empty list/array is Truthy.  This is a mistake, probably based on historical reasons.

I didn't address your specific return statement.  I wonder if we can say that if && or || is used, then the user clearly intends to get a boolean result, thus we can allow for automatic conversion to a bool type.
Not sure how to implement that though.  Could probably make it work in compiled code, but we also need to be able to do this in Vim9 script. Hmm, perhaps we can use a flag in the v_lock field.  Then we can do this:
let flag: bool = 99  # error!
let flag: bool = 'yes'   # error!
let flag: bool = 99 && 'yes'  # OK
Or is that going in the direction of being weird again?

Thank you! Sounds good solution!


Can't use the arrow keys to scroll up/down during the diff

Not sure if this is even fixable since you're piping the output but it would be nice :)

Doesn't happen on my machine. I believe it's related to your core.pager

Same issue, I lose paging capabilities when using it. Workaround is to add a  | less -R on the git alias.
My pager is set to less -FRSX which seems to be pretty standard.

@chubas @stringbeans The readme already mentions git config --global core.pager "diff-so-fancy | less --tabs=1,5 -R", this should work?

I fixed it by removing the X from the less flags on the instructions:
git config --global pager.diff "diff-so-fancy | less --tabs=1,5 -RF"
git config --global pager.show "diff-so-fancy | less --tabs=1,5 -RF"


Remove Go Module for forked code

How to categorize this PR?

/area open-source
/kind bug
/priority normal
What this PR does / why we need it:
This PR removes the Go Module of the forked K8s sources in third_party/forked/kubernetes because it caused vendor issues in repositories depending on Gardener (https://github.com/gardener/gardener/pull/2627#issuecomment-716804575).
Special notes for your reviewer:
/cc @timebertt @rfranzke
Release note:

NONE

/retest

@timuthy
Can you check the CI failure?
> Install
pkg/apiserver/admission/initializer/initializer.go:22:2: cannot find package "." in:
	/go/src/github.com/gardener/gardener/third_party/forked/kubernetes/pkg/quota/v1
cmd/gardener-apiserver/app/gardener_apiserver.go:54:2: cannot find package "." in:
	/go/src/github.com/gardener/gardener/third_party/forked/kubernetes/pkg/quota/v1/generic
cmd/gardener-apiserver/app/gardener_apiserver.go:55:2: cannot find package "." in:
	/go/src/github.com/gardener/gardener/third_party/forked/kubernetes/plugin/pkg/admission/resourcequota
make: *** [Makefile:100: install] Error 1


Will help maintain the repo

Hey @thomasdavis
If your okay with it I will help maintain the repo , as I do alot of work in this area. If not feel free to close it .

Don't have to ask me twice, welcome to the team! =D

woooo :) awesome stuff


[Feature Request]: Extract test cases from test_api.py

Describe the problem
test_api.py is a kitchen sink file of a variety of tests, with uncertain coverage and overlap with property tests.
Describe the proposed solution
Extract relevant test cases from test_api and add them to the property testing framework, deprecating it in the process.
Alternatives considered
No response
Importance
nice to have
Additional Information
No response

Discussed offline - lets leave the kitchen sink but never add to it.


[Bug]: TagEditor does not trigger keysRequest

Browser
No response
Package version
^3.0.95
React version
^17.0.2
Description
Hi,
keysRequest should be triggered on every click on Key autocomplete field.
In my case the keys for tags are depended on another (select) field, If I change it then available tags (for autocomplete) should be re-fetched. But currently the keysRequest is getting triggered only on first input focus and after a input is received from user.

A user could first focus on tag key field (triggering a keysRequest with empty [])
Then user could change the value of a Select field (that should possibly have some tags values)
Then user could again focus on tag key field (this time the tags should be fetched accordingly to value from Select field, but keysRequest is not getting invoked)

Thanks!
Source code
No response
Reproduction
No response
Code of Conduct

[X] I agree to follow this project's Code of Conduct
[X] I checked the current issues for duplicate problems

Hi,
the TagEditor intentionally does not fire the keysRequest event every time the input is focused, since this would cause an unnecessary overhead of requesting the same keys again and again. If the keys depend on an outside state like in your case, I would recommend to render a new instance of the TagEditor by using React's key property. This way the internal state of the component will be reset.
For example:
const [selectValue, setSelectValue] = useState(...);

...

return <TagEditor
               key={selectValue}
               ...
            />

Hi @connorlanigan ,
Thanks for the explanation and workaround, you are right this will do, different key will force react to re-render the component.
But TagEditor component itself has a fade in effect for the text and it is quite noticeable when it re-render often (due to key linked to an input state).
Here is an example - https://codesandbox.io/s/sparkling-waterfall-djssgj?file=/src/App.js

@gethinwebster yes, thank you, issue solved 😄


Update data-factory-use-custom-activities.md

added using System.Linq; name space

@pradipsnet : Thanks for your contribution! The author, @douglaslMS, has been notified to review your proposed change.

@pradipsnet The "using System.Linq;" statement is already in this sample on line 136. Did you intend to add this using statement to a different code sample?

@douglaslMS  Thanks for clarification.

#please-close


stm32 i2c driver has problems with AHB_PRESCALER, APB1_PRESCALER, APB2_PRESCALER

I am running Zephyr on my own board. This is based on the stm32f412.
After having problems with setting up the AHB prescalors, I am now ran into I2C problems.
@erwango fixed the AHB prescalors problems in: https://github.com/zephyrproject-rtos/zephyr/pull/17938
Now having this fix put into action I am facing I2C errors.
it comes down that:
CONFIG_CLOCK_STM32_AHB_PRESCALER=1
CONFIG_CLOCK_STM32_APB1_PRESCALER=8
CONFIG_CLOCK_STM32_APB2_PRESCALER=8

fails
but
CONFIG_CLOCK_STM32_AHB_PRESCALER=2
CONFIG_CLOCK_STM32_APB1_PRESCALER=4
CONFIG_CLOCK_STM32_APB2_PRESCALER=4

works
The rest cfg is set to:
CONFIG_I2C=y
CONFIG_I2C_STM32=y
CONFIG_I2C_STM32_V1=y
# CONFIG_I2C_STM32_INTERRUPT=y
CONFIG_I2C_1=y

# clock configuration
CONFIG_SYS_CLOCK_HW_CYCLES_PER_SEC=96000000

CONFIG_CLOCK_CONTROL=y

# Clock configuration for Cube Clock control driver
CONFIG_CLOCK_STM32_HSE_CLOCK=24000000
CONFIG_CLOCK_STM32_SYSCLK_SRC_PLL=y

# use HSE as PLL input
CONFIG_CLOCK_STM32_PLL_SRC_HSE=y

# the board have an external oscillator
CONFIG_CLOCK_STM32_HSE_BYPASS=n

# produce 96MHz clock at PLL output
CONFIG_CLOCK_STM32_PLL_M_DIVISOR=12
CONFIG_CLOCK_STM32_PLL_N_MULTIPLIER=96
CONFIG_CLOCK_STM32_PLL_P_DIVISOR=2
CONFIG_CLOCK_STM32_PLL_Q_DIVISOR=4

In the error case I get:
i2c_ll_stm32_v1.msg_end: stm32_i2c_msg_write: ERR 1
The stack trace look like:
__udivmoddi4() at libgcc2.c:1,024 0x80002d8
__aeabi_uldivmod() at bpabi.S:258 0x80002c4
z_impl_k_busy_wait() at sys_clock.h:50 0x8011650
k_busy_wait() at kernel.h:25 0x80160e2
stm32_i2c_wait_timeout() at i2c_ll_stm32_v1.c:311 0x80160e2
stm32_i2c_msg_write() at i2c_ll_stm32_v1.c:335 0x800f81a
i2c_stm32_transfer() at i2c_ll_stm32.c:145 0x80161a8
z_impl_i2c_transfer() at i2c.h:252 0x8011ece
i2c_transfer() at i2c.h:15 0x8011ece
i2c_write_read() at i2c.h:454 0x8011ece
i2c_reg_read_byte() at i2c.h:541 0x8011ece

enabling the isr
CONFIG_I2C_STM32_INTERRUPT=y
solves the error with
CONFIG_CLOCK_STM32_AHB_PRESCALER=1
CONFIG_CLOCK_STM32_APB1_PRESCALER=8
CONFIG_CLOCK_STM32_APB2_PRESCALER=8

Tested I2C(w/o interrupts) ok on nucleo_f412zg with similar clock settings.
Difference would be the use of external HSE, bypassing the HSE Oscillator.

@StefJar , is this issue still valid?

@StefJar , is this issue still valid?

thx for asking. I don't see this issue any longer. So I am closing it


Set up image release pipeline

/kind feature
Describe the solution you'd like
Releases need to be fast and painless
Anything else you would like to add:

/priority important-soon
/lifecycle active
/assign

/remove-lifecycle active
/unassign
@liztio did all the hard work i was going to do
The next steps for this ticket are modifying the Makefile to push to the staging bucket found here:
https://github.com/kubernetes/k8s.io/blob/master/groups/groups.yaml#L111
/good-first-issue

Are there any more detailed instructions? Or some examples about this?

@SataQiu I added some additional context above, please let me know if you have any more questions

/lifecycle active
/remove-help

@chuckha I think we can call this done (except for the automatically pushing to prod part, which we haven't done in any of our repos)?

for sure
/close


Change modes to string values

Currently deploying a MON fails with "bad symbolic permission for mode"
errors due to the file/directory modes not being interpreted as octal
values.  This commit updates roles/ceph-common/tasks/main.yml to set
the file/directory modes to strings so they can be interpreted
correctly.
Closes issue #525

Apparently this isn't an issue for CI or anyone else, which is odd!  Perhaps I need to figure out why this is failing for me before we merge and I introduce an issue for everyone else.  :)

@mattt416 are you running on containers?

Hi @leseb, that is correct -- we are putting our MONs in LXC containers.

@mattt416 let me quickly test this patch locally with 1.9.4 if this is good I'll merge this.

Works for me on 1.9.4, merging.


Refactored the 'Get Active Scalar Section.vi'

Also a few unrelated VIs were arranged and cleaned up

[x] This contribution adheres to CONTRIBUTING.md.

What does this Pull Request accomplish?
Refactored the 'Get Active Scalar Section.vi'. Also, all VIs which are used by the 'Reload Bitfile.vi' were re-arranged for better readability.
Why should this Pull Request be merged?
Currently it's hard to track what happens inside 'Get Active Scalar Section.vi' due to the numerous cases and complex wiring.
What testing has been done?
Built the Custom Device and went through all the test cases which were applied during for the original implementation of the 'Bitfile Reload' functionality.

Remove Invalid Scalars - please change the radix of the constant to "hex".

Remove Invalid Scalars - please change the radix of the constant to "hex".

Some of the VIs appear as changed, but without any actual changes.

Some of the VIs appear as changed, but without any actual changes.

The implementation looks good, however I have a bunch of comments:

The names for these VIs are not reflecting the actual functionality:

"Build Scalar Channel.vi" does not actually build a channel. It simply repacks the data from one cluster to another. I think it should be rather along the lines of "Generate Scalar Channel Data.vi" ...or something similar. Otherwise, I think the name is misleading.

"Get Valid Item Ref.vi" - this is not an actual "Get" ... this is more of a search function, since this is what it does. You give it a bitfile name, and it returns a channel reference. It should be along the lines of "Find Channel Ref.vi" ... or something similar.

I think that this implementation should be revised since it can be rather misleading:

This function checks for null reference returned by the "Get Bitfile Object ref.vi". "Get Bitfile Object ref.vi" will return a null reference only if a channel reference for a given bitfile name is not found in the input array - so the condition is known. It makes more sense to simply have "Get Bitfile Object ref.vi" return a boolean "Found" that would directly validate the returned reference, rather than checking one more time that reference outside the function to get the boolean. In this case, the "Not a ref" output actually is used to tell if a channel reference was found, and not to actually validate the reference.  Validating a reference with "Not a ref.vi" would make sense only if the source of the reference would be unknown (a VI takes in a reference, and we don't know where does that reference comes from of if it's valid)

The above comments apply here as well:

The implementation looks good, however I have a bunch of comments:

The names for these VIs are not reflecting the actual functionality:

"Build Scalar Channel.vi" does not actually build a channel. It simply repacks the data from one cluster to another. I think it should be rather along the lines of "Generate Scalar Channel Data.vi" ...or something similar. Otherwise, I think the name is misleading.

"Get Valid Item Ref.vi" - this is not an actual "Get" ... this is more of a search function, since this is what it does. You give it a bitfile name, and it returns a channel reference. It should be along the lines of "Find Channel Ref.vi" ... or something similar.

I think that this implementation should be revised since it can be rather misleading:

This function checks for null reference returned by the "Get Bitfile Object ref.vi". "Get Bitfile Object ref.vi" will return a null reference only if a channel reference for a given bitfile name is not found in the input array - so the condition is known. It makes more sense to simply have "Get Bitfile Object ref.vi" return a boolean "Found" that would directly validate the returned reference, rather than checking one more time that reference outside the function to get the boolean. In this case, the "Not a ref" output actually is used to tell if a channel reference was found, and not to actually validate the reference.  Validating a reference with "Not a ref.vi" would make sense only if the source of the reference would be unknown (a VI takes in a reference, and we don't know where does that reference comes from of if it's valid)

The above comments apply here as well:

The implementation looks good, however I have a bunch of comments:

The names for these VIs are not reflecting the actual functionality:

"Build Scalar Channel.vi" does not actually build a channel. It simply repacks the data from one cluster to another. I think it should be rather along the lines of "Generate Scalar Channel Data.vi" ...or something similar. Otherwise, I think the name is misleading.

"Get Valid Item Ref.vi" - this is not an actual "Get" ... this is more of a search function, since this is what it does. You give it a bitfile name, and it returns a channel reference. It should be along the lines of "Find Channel Ref.vi" ... or something similar.

I think that this implementation should be revised since it can be rather misleading:

This function checks for null reference returned by the "Get Bitfile Object ref.vi". "Get Bitfile Object ref.vi" will return a null reference only if a channel reference for a given bitfile name is not found in the input array - so the condition is known. It makes more sense to simply have "Get Bitfile Object ref.vi" return a boolean "Found" that would directly validate the returned reference, rather than checking one more time that reference outside the function to get the boolean. In this case, the "Not a ref" output actually is used to tell if a channel reference was found, and not to actually validate the reference. Validating a reference with "Not a ref.vi" would make sense only if the source of the reference would be unknown (a VI takes in a reference, and we don't know where does that reference comes from of if it's valid)

The above comments apply here as well:

Changes were made and the suggested items were implemented.

The implementation looks good, however I have a bunch of comments:

The names for these VIs are not reflecting the actual functionality:

"Build Scalar Channel.vi" does not actually build a channel. It simply repacks the data from one cluster to another. I think it should be rather along the lines of "Generate Scalar Channel Data.vi" ...or something similar. Otherwise, I think the name is misleading.

"Get Valid Item Ref.vi" - this is not an actual "Get" ... this is more of a search function, since this is what it does. You give it a bitfile name, and it returns a channel reference. It should be along the lines of "Find Channel Ref.vi" ... or something similar.

I think that this implementation should be revised since it can be rather misleading:

This function checks for null reference returned by the "Get Bitfile Object ref.vi". "Get Bitfile Object ref.vi" will return a null reference only if a channel reference for a given bitfile name is not found in the input array - so the condition is known. It makes more sense to simply have "Get Bitfile Object ref.vi" return a boolean "Found" that would directly validate the returned reference, rather than checking one more time that reference outside the function to get the boolean. In this case, the "Not a ref" output actually is used to tell if a channel reference was found, and not to actually validate the reference. Validating a reference with "Not a ref.vi" would make sense only if the source of the reference would be unknown (a VI takes in a reference, and we don't know where does that reference comes from of if it's valid)

The above comments apply here as well:

Changes were made and the suggested items were implemented.

The implementation looks good, however I have a bunch of comments:

The names for these VIs are not reflecting the actual functionality:

"Build Scalar Channel.vi" does not actually build a channel. It simply repacks the data from one cluster to another. I think it should be rather along the lines of "Generate Scalar Channel Data.vi" ...or something similar. Otherwise, I think the name is misleading.

"Get Valid Item Ref.vi" - this is not an actual "Get" ... this is more of a search function, since this is what it does. You give it a bitfile name, and it returns a channel reference. It should be along the lines of "Find Channel Ref.vi" ... or something similar.

I think that this implementation should be revised since it can be rather misleading:

This function checks for null reference returned by the "Get Bitfile Object ref.vi". "Get Bitfile Object ref.vi" will return a null reference only if a channel reference for a given bitfile name is not found in the input array - so the condition is known. It makes more sense to simply have "Get Bitfile Object ref.vi" return a boolean "Found" that would directly validate the returned reference, rather than checking one more time that reference outside the function to get the boolean. In this case, the "Not a ref" output actually is used to tell if a channel reference was found, and not to actually validate the reference. Validating a reference with "Not a ref.vi" would make sense only if the source of the reference would be unknown (a VI takes in a reference, and we don't know where does that reference comes from of if it's valid)

The above comments apply here as well:

Changes were made and the suggested items were implemented.

I believe that the process can further be improved. For example:

The "boolean" output of this VI is still called "Not a ref" - I think this should not longer be the case, since in fact it returns whether or not a reference was found. Moreover, it is misleading, considering how this output is used:

so, if ("Not a ref" == True) than do stuff to that reference ... I think this should be addressed, since it is incorrect/reversed logic.

I think that this could be simplified:

This VI is essentially just an  Error Case Structure around another VI, which makes one of the two redundant. I would recommend keeping "Find Valid Item Ref.vi".

It seems that the project is missing the "FPGA Addon Reload Bitfile" unit tests ... I think you should sync-up with the main branch of this repo.

The implementation looks good, however I have a bunch of comments:

The names for these VIs are not reflecting the actual functionality:

"Build Scalar Channel.vi" does not actually build a channel. It simply repacks the data from one cluster to another. I think it should be rather along the lines of "Generate Scalar Channel Data.vi" ...or something similar. Otherwise, I think the name is misleading.

"Get Valid Item Ref.vi" - this is not an actual "Get" ... this is more of a search function, since this is what it does. You give it a bitfile name, and it returns a channel reference. It should be along the lines of "Find Channel Ref.vi" ... or something similar.

I think that this implementation should be revised since it can be rather misleading:

This function checks for null reference returned by the "Get Bitfile Object ref.vi". "Get Bitfile Object ref.vi" will return a null reference only if a channel reference for a given bitfile name is not found in the input array - so the condition is known. It makes more sense to simply have "Get Bitfile Object ref.vi" return a boolean "Found" that would directly validate the returned reference, rather than checking one more time that reference outside the function to get the boolean. In this case, the "Not a ref" output actually is used to tell if a channel reference was found, and not to actually validate the reference. Validating a reference with "Not a ref.vi" would make sense only if the source of the reference would be unknown (a VI takes in a reference, and we don't know where does that reference comes from of if it's valid)

The above comments apply here as well:

Changes were made and the suggested items were implemented.

I believe that the process can further be improved. For example:

The "boolean" output of this VI is still called "Not a ref" - I think this should not longer be the case, since in fact it returns whether or not a reference was found. Moreover, it is misleading, considering how this output is used:

so, if ("Not a ref" == True) than do stuff to that reference ... I think this should be addressed, since it is incorrect/reversed logic.

I think that this could be simplified:

This VI is essentially just an  Error Case Structure around another VI, which makes one of the two redundant. I would recommend keeping "Find Valid Item Ref.vi".

It seems that the project is missing the "FPGA Addon Reload Bitfile" unit tests ... I think you should sync-up with the main branch of this repo.

I would recommend that if you changed the name of the VIs, than please update the names of the controls to reflect the functionality:

... I think it should be for example "scalar channel data out"
similarly here:


update warning message

When source path does not exist, I think it's better to clarify that it's the source path.

Because of merge conflicts I applied the same change in PR #13


Updated code to works when email failed and log the error

In this case if we do not send email it is shame, but user should see his order in order to continue.

Current coverage is 94.65% (diff: 22.22%)

Merging #230 into master will decrease coverage by 0.32%

@@             master       #230   diff @@
==========================================
  Files            46         46
  Lines          1433       1440     +7
  Methods           0          0
  Messages          0          0
  Branches          0          0
==========================================
+ Hits           1361       1363     +2
- Misses           72         77     +5
  Partials          0          0

Powered by Codecov. Last update 8d757fd...db9bcc2


How to use local SD model?

CMD : iopaint start --model Sanster/AnyText --model-dir=F:\iopaint_model --local-files-only
Which path should the SD model be placed in?
I put the model to ~\huggingface\hub. But it can't start.
And when I use --no-local-files-only ,It can't download the model automatically from huggingface.(I can access this website on Chrome.)

Executing the command iopaint start --model Sanster/AnyText --model-dir=F:\iopaint_model will automatically download the model from huggingface. If it does not download automatically, it may be due to a proxy issue, and you need to set up a proxy in the command line.
The purpose of --local-files-only is to prevent connecting to the HuggingFace server after downloading the model.(Because regardless of whether the model has been downloaded or not, the underlying projects that iopaint depends on will first go to huggingface to obtain the meta information of the model. Adding this parameter can prevent this operation. )
If you want to load a local single file ckpt/safetensors file, you can refer to this document: https://www.iopaint.com/models#load-ckptsafetensors.


guest user docs missing

over here https://help.keboola.com/management/#user-management

https://keboola.atlassian.net/jira/software/projects/DOC/boards/15?selectedIssue=DOC-25


Fixes div closed in wrong place in settings/store

Before:

After:

@jjeffryes I feel like I'm at the pub playing 'Spot the differences' and I'm failing. What is the difference between those two screenshots?

@rmisio the before one is missing the gap between the save box and the box above it.


Workaround for random crashes with some webpages

Issue #1112

@TAKeanice , can you verify if issue #1119 is still present with the latest commits that I pushed ?