Create Concept for Add Parts View for notifications

As a user ,
I want to add parts to notifications ,
so that i dont have to recreate new notifications if i forgot some parts .
Result Issue and Concept
https://github.com/eclipse-tractusx/traceability-foss/issues/622
Concept in PR : https://github.com/catenax-ng/tx-traceability-foss/pull/977
Hints / Details

Miro UI Concept Board : LINK
Create a concept for add Parts to Notifications View
• Which parts should be listed
• Sorting/filtering searching of parts

Acceptance Criteria

[ ] Concept existing for Add Parts View including mock
[ ] BE API definition to support adding Parts to notifications <= queued

Out of Scope

...

Discussion from Pull Request: catenax-ng#977

Changes are considered by not working on the issue from this concept before the changes are completed.
So far the concept describes only the partListid updates. This can be expanded by more properties if wanted. Shouldnt change much, can be discussed in a review.

Created a Concept for FE and BE:
https://github.com/catenax-ng/tx-traceability-foss/blob/2eaadc8d0aefddaedd32bb06894d7540d9d2fd4f/docs/concept/%23621-add-parts-to-notifications/%23621-add-parts-to-notifications.md
Can also be viewed and reviewed in this Pull request: https://github.com/catenax-ng/tx-traceability-foss/pull/977

Review done on Miro

Hi @ds-mmaul,
the concept looks good to me! IMO only the problem statement could be more precise since we only want to add new parts to notifications and not delete parts or adjust the description, deadline or severity which could be understood with "editable notifications".
Thank you!

@jzbmw Here I have some answers to your open questions (post-its) to the concept:

What is a toast?

Sure, I can use Option 2 of the View

And a clarifications needed:

regarding the problem Alex mentioned: Indeed its confusing that my concept does not only reflect adding parts, but more "editing parts". Should I quickly rework the concept to only support adding?

Pull request with concept have been reviewed.

Rework of @ds-mmaul done. Therefore ready for your final review. @jzbmw

Review Discussion:

Change to existing selection of Parts (instead of plus)
Change to edit Parts instead of Add Parts since we do more than adding (removing)

Changed the Concept in Miro (see link in description)
Edit Concept in Repo from "Add" to "Edit"


New Tx Types: Send with Receipt Request, Send with Receipt (to prevent loss of misdirected funds, and other uses)

There's a longstanding and ongoing problem where owners of Omni Layer smart property tokens (mainly USDT, property id 31) mistakenly send tokens to an address who's owner doesn't use the Omni Layer protocol (typically an account deposit address at an exchange). That means the tokens end up sitting at the receiving address and the sender has no way to reclaim them - because the receiving address owner won't issue an OL transaction to send them back.
This proposal describes a mechanism to prevent future instances of this problem, where tokens languish in such addresses because the address owner won't submit an OL transaction to send them back (or anywhere else). It could also be used where an OL-aware exchange chooses to accept only a particular OL smart property at each deposit address.
Introduction
The mechanism involves two new OL transaction types. The first proposed new transaction type is Send with Receipt Request. It has the same fields as Simple Send, plus a timelimit field (in blocks) that specifies how long the recipient has to generate a receipt. The recipient then uses the new Send with Receipt transaction type within the specified timelimit to acknowledge that the tokens have been accepted.
Flow
The Send with Receipt Request (SwRR) tx type moves the specified number of tokens from the sender's available balance to the sender's reserved balance (TBD: or maybe to the recipient's reserved balance, if that makes more sense). The recipient then has to submit a Send with Receipt (SwR) tx referencing that SwRR so it is processed as valid within the specified timelimit number of blocks. If the SwR tx is processed as valid, then the referenced tokens are moved from the reserved balance to the available balance of the recipient specified in the SwR. In the case of an exchange, the new recipient address will likely be the the exchange's sweep address for that property.
If there is no corresponding valid SwR tx processed within the specified timelimit number of blocks, then the tokens are moved from the reserved balance back to the available balance of the original sender. This eliminates the risk that's associated with current misdirected OL sends.
Details
The SwR transaction message can specify either the txid of the corresponding SwRR or the address of the sender and the OL property type (in order to affect multiple SwRR transactions from the sending address). If a txid is specified and the SwR is valid, then all the tokens from that txid are transferred. If the txid doesn't refer to a valid SwRR to the address submitting the tx, or the_timelimit_ in the referenced SwRR has expired, then the SwR is invalid.
If an address and OL property type are specified, then all referenced tokens  in unexpired SwRR transactions from the specified address to the address submitting the SwR tx will be transferred. (TBD: if there are no unexpired SwRR tx's, is that an invalid transaction, or is it valid and the number of tokens affected is 0?)
The tokens don't have to be moved to a third address. The recipient of the SwRR transaction can specify itself as the recipient of the SwR transaction.
As with US Postal Service return receipt requests, an  exchange could choose to charge a fee to generate a receipt (the txid of the related SwR tx). That fee could be paid as an additional bitcoin output to the recipient address (which could be used by the exchange to pay the SwR transaction fee). If the SwRR doesn't include the necessary additional bitcoin output, the exchange could choose to not submit the SwR tx, thereby refusing and ultimately returning the account holder's deposit.
This proposal will require OmniCore to be efficient in how it is able to retrieve data associated with unexpired SwRR transactions - for providing status feedback to users and for returning the tokens to the sender's available balance when a timelimit expires.
I expect there will be other uses for SwRR and SwR.

I think the response should be called Send Receipt or SR (the "with" is confusing to me)
I think this is a novel and interesting solution to the I-accidentally-sent-Tether-to-Coinbase problem, but will only really be helpful if we make SwRR the default send transaction type in all/most wallets.

@msgilligan I added "with" because the tx is primarily a Send that happens to also serve as an acknowledgement. I'm not wedded to the names of either proposed tx.
As for making SwRR the default send - the unintended consequence there is that sends would be undone if a recipient isn't diligent about checking and acknowledging the send. I think the wallet UI/UX could ask the user if she wants to use the mechanism when constructing each send.

the tx is primarily a Send that happens to also serve as an acknowledgement.

That makes sense. I will admit to skimming over that paragraph rather quickly.

As for making SwRR the default send - the unintended consequence there is that sends would be undone if a recipient isn't diligent about checking for and acknowledging the send. I think the wallet UI/UX could ask the user if she wants to use the mechanism when constructing each send.

I think the complexity you just described is probably a deal-breaker for this mechanism as a solution to the Tether-to-Coinbase problem. (The TtC problem?)  If we don't make it the default, people won't use it and they'll still send their Tethers to Coinbase. If we do make it the default, we'll have the above problems you just described.

Hi @marvgmail,
it's a really interesting concept. I think you're onto something. :)
I'm currently wondering:

What are the use cases? Can you name a few examples?

If it's to avoid sending unintentionally tokens to Coinbase or other exchanges, then I think it won't work as intended, because people who unintentionally send tokens to Coinbase don't know they don't accept it, so may not think "Ah, this receiver may not create a receipt transaction, so I don't send my USDT!".

If it's intended to avoid sending unintentionally tokens to Coinbase or other exchanges, what benefit does it have over Omni specific addresses?

@marvgmail I second @dexX7 's comments however i would add that from a functionality point of view if/when the time limit expires the tokens do not 'automatically' move back to the sender but instead the sender then is 'allowed' (if they so choose) to broadcast their own SwR (or whatever we call it) to 'reclaim/return' the tokens to themselves. This allows the receiver at least a guaranteed time frame to claim the transfer but does not allow the tokens to just 'disappear' from the destination address  without either party performing an explicit transaction.
I actually see very similar functionality in this and my other proposal of using CHECKLOCKTIMEVERIFY for the BTC/Token dex payments

@dexX7 @msgilligan The general use case is where someone wants to get a timely acknowledgement from the recipient for sending OL tokens, and if the ack doesn't happen within the time limit then they get their tokens back. It's not a perfect solution - nothing is, it requires trust that the recipient will do the right thing within the right time, but it eliminates risk for the sender. Simple Send is obviously more risky because there's no recovery mechanism.
Wallets/apps could make it the default Send transaction, with appropriate UI/UX to use Simple Send instead. It's just like sending an insured letter or pkg that requires a signature by the recipient. No signature --> no risk of loss due to an unresponsive or incorrect recipient. And, no claim has to be filed in order to get the sender's funds back.
I think it's simpler than Omni-specific addresses, especially for OL-aware exchanges because the routine case is handled the same as now, just with a different version of Send.

@achamely A reclaim/return tx would be fine, but note that the tokens were not delivered to the recipient. They were basically in escrow, waiting for the recipient to claim them within the specified time.
It is definitely similar to your proposal for using CHECKLOCKTIMEVERIFY for the BTC/Token dex payments.

I see this as similar to a check that says "Invalid after 60 days".

Other use cases are time-limited vouchers to be redeemed by the recipient. This would likely include the use of NFTs to uniquely identify the voucher - e.g.:

a ticket for admittance to an event

a limited time to pick up something, physical or digital, that was purchased online

indicating acceptance of an agreement

I think it's simpler than Omni-specific addresses, especially for OL-aware exchanges because the routine case is handled the same as now, just with a different version of Send.

Except it needs an extra transaction and action from the receiver?

maybe the names should be something like Send Pending an Acknowledgement and Acknowledge and Send. These describe the behavior but not necessarily the user transaction.


Anthropic (Claude) provider

This PR adds the Anthropic provider as a chat model.
It does not include completion.

I added a first trial on code completion, the idea is to give a context to the AI, and to send the current prompt as a message to complete.
The 2 issues I have so far are:

it is really slow on my side
anthropic raises if there is a space at the end of the prompt. Currently this PR is removing it, but it can lead to wrong suggestions

Thanks @brichet for looking into this :+1:
I just tried this PR locally and there seems to be many requests made to the anthropic API, so maybe there is indeed something not expected happening:
jupyterlite-anthropic.webm

Interestingly when testing with Jupyter AI, completions don't seem to work and trigger some warnings in the dev tools console:
jupyter-ai-lab-434-anthropic.webm
The Jupyter Server logs also show some long response time for the inline completer:

Thanks for testing it @jtpio
Using Anthropic completion with jupyter-ai do not trigger error on my side, but the suggestions are not really reliable (most of the time):

Indeed, you're right about the extra requests, I'll take a closer look.

Using Anthropic completion with jupyter-ai do not trigger error on my side, but the suggestions are not really relevant (most of the time):

Indeed according to your screenshot there seems to be an issue with how Jupyter AI handles the inline completer suggestions. So likely an issue in Jupyter AI (we could open one if non exists already)


Interactive should print status when launched

Status should include region, space name and id, and the values of the configuration variables (type, size, etc)

It is of course possible to run the 'status' command at the beginning of each session. But this is very ugly, and will be most often useless. So I didn't implement that.
On the other hand, more logging about the URL and space name may be interesting...

The log already has the space id (if this id was specified in the credentials) or the name of the space. So that part is fine.


Debug footer display

Closes #3
Comments
Add the 80px margin of the nav onto the min-height of the #page element.

Better now! 👍


Please add support for TinyBMS

I love your project! Could you please add support for TinyBMS: https://www.energusps.com/shop/product/tiny-bms-s516-150a-750a-36?category=4
There's a communication protocol PDF here too: https://www.energusps.com/web/binary/saveas?filename_field=datas_fname&field=datas&model=ir.attachment&id=21208
Many thanks!! :)

Good morning, thank you very much for your excellent work.
I have a victron system with multiplus and cerbo gx and 4 mercedes batteries in parallel on a bus bar and each one with a Tiny BMS. You could contact me and give me a price to be able to integrate these bms. I'm waiting. Greetings and thanks.

Hi,
I woud love to see your driver working with Tiny BMS too. Can we hel you somehow in order to make it possible?
Thanks a lot!


Data Encryption and Decryption in Node.js using Crypto

We ask that you please be patient as our team works through approving and publishing all articles/tutorials in a timely manner. Allow 1-3 days for a topic to be reviewed and/or approved - allow 3-7 days for an articles to be reviewed and/or published.
Be sure to visit our Resources Page for tools, resources, and example articles to go over.
NOTE: (Please ensure that you have only one open issue + linked pull request at a time. This will ensure that we complete the article in a timely manner from inception to publishing.)
NOTE: We tend to stray away or tend not to publish reviews/comparisons of commercial product offerings.
We're looking for the first 2-3 paragraphs of the article that appropriately summarize what your article will be about.
Proposed title of article
Data Encryption and Decryption in Node.js using Crypto
Introduction paragraph (2-3 paragraphs):
Cryptography and encryption are techniques used to secure and protect data stored in databases or being transferred over a network. Most data security operations are executed in the back-end of an application. Therefore we will use Node.js to implement encryption and decryption of data.
Node.js provides a built-in module called crypto to implement cryptographic operations on data.
In this article, we will learn basic cryptographic and Node.js techniques to secure data. Also, we will learn how to use Node.js 'crypto' module to perform encryption and decryption operations on data.
Key takeaways:

Cryptography in Node.js
Node.js Crypto Module
Encrypting data in Node.js
Decrypting data in node.js

References:
https://nodejs.org/api/crypto.html
https://www.w3schools.com/nodejs/ref_crypto.asp
Templates to use as guides

How To Guide Template
Software Review Template
Tutorial Template

closing for now

@hectorkambow please reopen this issue

Hello @hectorkambow, please reopen this issue.


chore(CHANGELOG): update to v4.9.0

What is missing is the actual library version bumps.

Two minor comments. This release is 🧨

Thanks for your review. Hints appreciated.


tests: generate coverage reports using tox

yay for CI tests. It looks like the older ubuntus don't have tox v4. I'll take a stab at getting the CI tests to install tox v4 before running the tox tests.

Let me know if I should split out another PR from this one -- 5973b26b2f2fc21abbfa2d3af03fcef244f80cce and the commits leading up to it could be split out into a PR that only handles the python3.12-related changes.


(fix) Dropdown menu visibility #515

Proposed changes
Current behaviour
Since the dropdown content is currently being appended to the container element of the latest triggering element, the dropdown content might get appended to a container that is currently in invisible state, this happens in the context where the dropdown component has multiple trigger elements, where triggering elements containers might become invisible because of a toggling visibility state (tabbable content, expandables, media queries, ...)
Implemented changes
Updated the dropdown content to be attached to the current clicked/hovered triggering element
Screenshots (if appropriate) or codepen:
Example of bug using a dropdown in nav/sidenav

Example of bug using a dropdown with multiple triggers in tabs context

Types of changes

[X] Bug fix (non-breaking change which fixes an issue).
[ ] New feature (non-breaking change which adds functionality).
[ ] Breaking change (fix or feature that would cause existing functionality to change).

Checklist:

[X] I have read the CONTRIBUTING document.
[X] My commit messages follows the conventional commit format
[ ] My change requires a change to the documentation, and updated it accordingly.
[X] I have added tests to cover my changes.
[X] All new and existing tests passed.

Awesome. Well written and documented PRs!


Enable full DNS names

Description:
Expanding the field for the collection of DNS names and by extension workload names in metric labels. The names of workloads can get long, for example if there is a certain service running on a certain pod in a certain namespace all that information gets concatenated into this string. It was limited to 80 characters before, while 256 characters is the actual theoretical limit.
This branch was migrated from https://github.com/open-telemetry/opentelemetry-network/pull/260
Link to tracking Issue: https://github.com/open-telemetry/opentelemetry-network/issues/256
Testing: Manual testing, running in devbox
Documentation: none

Just leaving it here that I cannot merge the PR myself as I do not have write access 😄


Fixes linter error

This code got merged without passing gofmt in the linter and is now failing (see https://github.com/istio/istio/pull/18528). This PR just runs gofmt.

@brian-avery: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

integ-istioio-k8s-tests_istio
a6c9de832c1ad61a67949c6cc2a8bbe3125cf07d
link
/test integ-istioio-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.


Feature/passthroughsubject

Codecov Report

Merging #27 (95cd55e) into main (59932cd) will increase coverage by 19.78%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##             main      #27       +/-   ##
===========================================
+ Coverage   77.57%   97.36%   +19.78%
===========================================
  Files          66       35       -31
  Lines        1895      796     -1099
  Branches      736      328      -408
===========================================
- Hits         1470      775      -695
+ Misses        412       19      -393
+ Partials       13        2       -11

Flag
Coverage Δ

QAMenu
97.36% <100.00%> (+0.04%)
:arrow_up:

QAMenuUIKit
?

QAMenuUtils
?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

Sources/QAMenu/Public/Data Structure/Group.swift
100.00% <ø> (ø)

Sources/QAMenu/Public/Data Structure/Item.swift
100.00% <ø> (ø)

...urces/QAMenu/Public/Data Structure/ItemGroup.swift
100.00% <ø> (ø)

...ic/Data Structure/Capabilities/DialogTrigger.swift
100.00% <100.00%> (ø)

...ic/Data Structure/Capabilities/Invalidatable.swift
100.00% <100.00%> (ø)

...ata Structure/Capabilities/NavigationTrigger.swift
100.00% <100.00%> (ø)

...nu/Public/Data Structure/Items/ChildPaneItem.swift
97.72% <100.00%> (-0.06%)
:arrow_down:

...blic/Data Structure/Items/EditableStringItem.swift
100.00% <100.00%> (ø)

Sources/QAMenu/Public/Data Structure/Pane.swift
100.00% <100.00%> (ø)

...ces/QAMenu/Public/Data Structure/PickerGroup.swift
100.00% <100.00%> (ø)

... and 32 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 59932cd...95cd55e. Read the comment docs.


Ignore higher resolution of Tumblr note avatars

Tumblr increased the resolution of note avatars at some point in the past few months from 16 x 16 px² to 64 x 64 px² on some stylesheets.
Unfortunately, this change has the side effect that the blogger's avatar might also be ignored on some pages. For example on this blog, the avatar appears as _64.png on the individual posts; however, it is also included as _128.png at the top of the page.
The only way to solve this properly would be to have conditional ignores depending on where on the page the image was found. I suppose this could be implemented in the dupespotter, similarly to the (currently broken) Drupal handling, but that would obviously be a lot more work.

What's the cost of grabbing higher-resolution note avatars?  Can we just leave them as-is?

Note that this is a separate ignore set specifically for ignoring avatars, not a general Tumblr ignore set. The problem is that archiving Tumblr blogs with many followers usually leads to grabbing millions of avatars, inflating the job massively. To avoid that, one can choose to add the notumblrnoteavatars igset. But because of the resolution change (on some blogs), the igset isn't working properly anymore, which is why I made this PR to also ignore the higher resolution avatars.


Add torch package variation to nimtorch

We renamed the .nimble file into torch.nimble
Would be wise to keep both flavors the old nimtorch (not so correct API wise but works) and the new flavor torch

Should be fixed! thanks for pointing this out! @dom96


Battery Temperature

Hello,
First of all, this is awesome.  Thanks for putting this together, worked like a charm.
I have a VictronSmartShunt with a temperature sensor connected to the aux, would it be possible to pull temperature?
Cheers,
Dick

Hello,
First of all, this is awesome.  Thanks for putting this together, worked like a charm.
I have a VictronSmartShunt with a temperature sensor connected to the aux, would it be possible to pull temperature?
Cheers,
Dick

hello, nothing is impossible😉 I will try to look at it on the weekend, so please remind me on the telegram https://t.me/KinDR007cz

As with icdragon I am really liking using this and would really love to see something similar their request.
In particular I use this in a van so would love to use the Aux to monitor my started battery voltage if you ever find time to implement it.
Cheers,
Stefan

As with icdragon I am really liking using this and would really love to see something similar their request.
In particular I use this in a van so would love to use the Aux to monitor my started battery voltage if you ever find time to implement it.
Cheers, Stefan

I will merge all sensors from Python integration:
https://github.com/birdie1/victron/blob/master/lib/victron_serial/victron_smartshunt.py

I opened a small PR to add this 🤗.


CodecNotFoundException

I'm using this driver with RJDBC (https://cran.r-project.org/web/packages/RJDBC/index.html), and am able to successfully connect to my local Cassandra instance and retrieve a list of tables. When I try to run a query, I get
com.datastax.driver.core.exceptions.CodecNotFoundException: Codec not found for requested operation: [int <-> java.lang.Double]

Actually I haven't added a codec for int -> Double.
Quick fix would be to provide a float instead of an int in your query.
Long fix is me adding a codec for that, which should be doable in the coming days.

I'm interested in this too. Any progress?

But, Before pass the value you can do the cast, right?


chore:  compile error due to markdown changed AST struct

branch main has compile errors
eg:
BlockQuote to Blockquote
and MdxJsxExpressionAttribute  type

That seems unlikely? markdown-rs is alpha. So the breaking change should not be pulled in?

That shouldn’t happen. When you clone, you should get 1.0.0-alpha.18: https://github.com/wooorm/mdxjs-rs/blob/d57c0cadbfe6b24057da1f6a7bdd7bcf1906eab8/Cargo.toml#L19

according to  https://doc.rust-lang.org/cargo/reference/resolver.html
1.0.0-alpha.18 is equivalent to ^1.0.0-alpha.18,  so 1.0.0-alpha.21 matches the semver constrai.
if you want lock to 1.0.0-alpha.18 the semver should be =1.0.0-alpha.18
and you cargo lock file is not versioned in git,  you can add it to git, so someone else cloned the repo will get the same version.
you can try cargo update or  remove the cargo lock, then cargo build again.

Thank you!


Updating the custom git-subtree script to current version

@BobaFetters is this an update based on feedback from the git team?

@calvincestari Yea, this is the current (and likely final) version of the updated script that I worked on based on feedback to move some code around and tweak a few usages of things.


Feature/ctest update

Description
Update  Orion modulefiles as well as the test_ufs_datm_land scripts to reflect recent changes of Orion role account and ufs_datm_land model updates.
How to test:
In your build folder:
../test/retrieve_data.sh/work2/noaa/epic-ps/ycteng/case/20230808/land-DA_workflow
salloc --ntasks 8 --exclusive --qos=debug --partition=debug --time=00:30:00 --account=epic
module use ../modulefiles && module load landda_orion.intel
export JEDI_EXECDIR=${JEDI_INSTALL}/fv3-bundle/build/bin
export RTPWD=/work2/noaa/epic-ps/ycteng/case/20230808/inputs/NEMSfv3gfs/develop-20230804/INTEL
export INPUTDATA_ROOT=/work2/noaa/epic-ps/ycteng/case/20230808/inputs/NEMSfv3gfs/input-data-20221101
ctest
Tests have been done on both Hera and Orion. Just be aware that the retrieve_data.sh step will take a while on Hera due to its extremely slow external internet connection.
Anticipated changes to regression tests:

[x] Is baseline change expected ?

Subcomponents involved:

[ ] DA_update
[ ] vector2tile
[ ] ufs-land-driver
[x] none

Linked PR's and Issues:

Testing (for CM's):

RDHPCS

[x] Hera
[x] Orion
[ ] Jet
[ ] Gaea
[ ] Cheyenne

CI

[ ] Completed

PW-Clouds

[ ] AWS
[ ] AZURE
[ ] GCP

I tested this on Orion and it is successful. @clouden90 @rhaesung

I tested this on Orion and it is successful. @clouden90 @rhaesung

@rhaesung I can confirm hera is successful as well. Let me know if you want the steps I used to run the tests.

I tested this on Orion and it is successful. @clouden90 @rhaesung

I can confirm hera is successful as well. @rhaesung let me know if you want the steps I used to run the tests.

Thanks, @zach1221! Yes, please share the steps on Hera.

@rhaesung see below.
git clone -b feature/ctest_update --recursive https://github.com/ufs-community/land-DA_workflow.git
cd land-DA_workflow
module load intel/2022.1.2 impi/2022.1.2
module use modulefiles
module load landda_hera.intel
mkdir build && cd build
ecbuild ../ && make -j4
cd ..
./test/retrieve_data.sh $PWD
cd build
export JEDI_EXECDIR=${JEDI_INSTALL}/fv3-bundle/build/bin
export RTPWD=/scratch1/NCEPDEV/stmp2/role.epic/jenkins/workspace/inputs/NEMSfv3gfs/develop-20230804/INTEL
export INPUTDATA_ROOT=/scratch1/NCEPDEV/stmp2/role.epic/jenkins/workspace/inputs/NEMSfv3gfs/input-data-20221101
ctest

@clouden90 This pr was combined with pr23 (https://github.com/ufs-community/land-DA_workflow/pull/23) and merged. Can we close this one?

Close now


fix(zigbee2mqtt-edge/config.json): Add missing support for adapter zs…

Added the support of the serial.adapter thas was missing in the config validation.
Fixes #336

Why is this failing @danielwelch? and when can this be merged?

Any updates on when we can expect this PR to be merged @danielwelch ?
Thanks

Ping @danielwelch :)
This would fix #315 #336 #356 ... I'm pretty sure a bunch of people would be very happy ;)
Thanks !

Thank you Daniel !


20191130号合并源作者代码

NOTE: Please read the Contributing.md guidelines before submitting your patch:
https://github.com/apache/incubator-apisix/blob/master/Contributing.md#how-to-add-a-new-feature-or-change-an-existing-one
Summary
SUMMARY_HERE
Full changelog

[Implement ...]
[Add related tests]
...

Issues resolved
Fix #XXX

1


 How about embedding them as the miniplayer background, or putting them somewhere where you can see them and still use the app ?

@Xedecimal The less windows we launch the more resource efficient the app is.  If we launch another window then it spawns another renderer process.
We have a PlaybackAPI that exposes the lyrics we fetch so if you want the lyrics in a separate window it would be best if you or someone else wrote a dedicated lyrics viewing application.
The goal with this application is too keep it small and lightweight, spawning multiple renderer processes doesn't help with that mission 😆


[Feature Request] Delete after conversion

Is it possible having the possibility to delete the file after conversion ? It would really be helpful

@HamzaM
command line and GUI?

I used GUI and i didn't see it, if it's available as a command I'll do that then

That option doesn't exists yet.
I was asking if you would like that feature in the GUI too?

Oh yes both would help ! I've seen other people being interested in this as well

@HamzaM
added in command line, but not in GUI yet.
Will be available in next release

@HamzaM
added in command line, but not in GUI yet.
Will be available in next release

Can't wait to try that out !


Jagged Textures using Pixel Art Textures

Godot version:
Godot 3.2.1
OS/device including version:
Tested on Dell XPS 13:

Intel Core i5-8520U CPU
8 GB RAM
1920 x 1080 resolution

Issue description:
Hello. I added a 32 x 32 texture to a 3d model and the lines come out very jaggy despite
using MSAA and Anisotropic Filtering (I tested this on various settings). Have a lovely day!
Here are some images:

Steps to reproduce:

Create a 32 x 32 texture and add it to a 3d model in Godot

Minimal reproduction project:
Jagged Pixel Art Texture Recreation.zip

This is a limitation of multi-sample antialiasing. MSAA cannot smooth out the "insides" of textures, since it only uses triangles for smoothing, not transparency.

Thank you, have a nice day!


Move Go files to subfolder for cleaner import path.

Unfortunately this isn't backwards compatible even though it's trivial to fix for a user.

So why do it? How does it make the import path cleaner?

You can already to import "github.com/renstrom/go-jump-consistent-hash" (no import alias).

So why do it?

I probably won't, that's why I put it in a pull request. I know Gophers aren't big fans of backwards incompatible changes, just testing the water...

You can already to import "github.com/renstrom/go-jump-consistent-hash" (no import alias).

Sure but it's not immediately obvious from that import path what the package name is, which is what I disliked about it. You have to either check the docs/readme or read the code.

Ah yes. And the repository name is indeed a bit unfortunate. I've opened #3 as an alternative solution to this that is backwards compatible.

It's also true for the other way around. If you come across jump.Hash(a, b) in some file it's not obvious it belongs to github.com/renstrom/go-jump-consistent-hash even though it probably won't take much effort or time to figure out it still has some cognitive overhead.

Totally agree, that's why I think #3 is a good solution. Although I have not checked cross-platform compatibility. (!)

I'm gonna have to let this sink in a little. To be honest, I would love to strip the "go-" part from the URL as well (thinking of this tweet by Rob Pike), but that would probably mess up more things than what this pull request does. My dream:
import github.com/renstrom/jump-consistent-hash/jump

I wonder how many are actually using this library...? I mean, better make breaking changes early on.

A search for the import on GitHub reveals no uses. That doesn't mean private projects don't use it though.


Create Java If-Else.java

This file contains the solution of Java If-Else question given in hackerrank.
This question checks basics of If-Else condition in java.
the task is :
-print Weird if given integer is odd
-print Not Weird if given integer is even and inclusive of 2 to 5.
-print Weird if given integer is even and inclusive of 6 to 20.
-print Not Weird if given integer is even and greater than 20.
Hey there!, Thanks for submitting a PR to this repo
Please complete the following checklist for your PR to be approved. Mark the items by adding an x.
Example:  - [ ] Mark me as completed
To mark: - [x] Mark me as completed

[ ] My Pull Request adheres to the Contribution guidelines.
[ ] I have added readme.md and solution files in the appropriate folder.
[ ] The solution I have given is my own and not plagiarized in any form.
[ ] My solution passes all the testcases.
[ ] I have properly indented and documented my solution using comments.

If any of the above is unmarked, please make the necessary changes and then mark them so that you're PR can be approved and merged.

Please refer the Contributing guidelines and send a valid PR.


Enforce named imports and remove unnecessary React imports

Changes
https://github.com/bluesky-social/social-app/pull/4362#pullrequestreview-2097354883

fwiw using default exports for React is kind of wrong and i think the plan is to eventually drop support for it. instead we should move to named imports for Hooks (and types). for JSX, we shouldn't need to import React at all — something is wrong in our setup if this is required. the new JSX transform should not need that.

Noting the JSX rule is coming from here: https://www.npmjs.com/package/@react-native-community/eslint-config?activeTab=code
Not sure what repo that's in anymore, doesn't look like it's in facebook/react-native or any of the react-native-community repos at a first glance, though it definitely might be in one of those - I didn't look very closely. The package.json still has facebook/react-native listed though.

Thanks for the feedback and additional context, @gaearon!

Use named imports everywhere (you can use a codemod for that):  Done using update-react-imports codemod. However, I want to ensure that I haven't missed any imports. Is there a way to test this properly?

Remove React imports altogether: Done using update-react-imports codemod.

Figure out why JSX requires React and fix that "why" — it shouldn't:  The @react-native-community/eslint-config package has been renamed to @react-native/eslint-config since React Native 0.72. For now, I've disabled the 'react/jsx-uses-react' rule.

Add a lint rule that enforces named usage going forward: I've added the 'no-restricted-imports' rule to the ESLint config, which restricts the default import of react. This should help enforce the usage of named imports.


V-71961 grub2 Configuration File

Update control based on discussion in #61
Closes #61

Just to discuss this further, the text appears to be:
The grub2 boot loader should have a superuser account and password protection enabled to protect boot-time settings.

To do so, select a superuser account and password and add them into the /etc/grub.d/01_users configuration file.

Since plaintext passwords are a security risk, generate a hash for the pasword by running the following command:

$ grub2-mkpasswd-pbkdf2

When prompted, enter the password that was selected and insert the returned password hash into the /etc/grub.d/01_users configuration file immediately after the superuser account. (Use the output from grub2-mkpasswd-pbkdf2 as the value of password-hash):

password_pbkdf2 superusers-account password-hash

NOTE: It is recommended not to use common administrator account names like root, admin, or administrator for the grub2 superuser account.

To meet FISMA Moderate, the bootloader superuser account and password MUST differ from the root account and password. Once the superuser account and password have been added, update the grub.cfg file by running:

grub2-mkconfig -o /boot/grub2/grub.cfg

NOTE: Do NOT manually add the superuser account and password to the grub.cfg file as the grub2-mkconfig command overwrites this file.

So, more may need to be done here.

We need to make sure that the superuser is explicitly not root
We need to make sure that the superuser password is not the root password (no idea how we do this, may just need to mark it as 'todo' or something)

The prose seems to indicate a singular superuser account so we may need upstream clarification on more than one particularly since I don't think that there's really any significant monitoring/auditing when you use multiple accounts.

I would say we fail it and then make part of the test say the user
should_not cmp 'root' so it is clear in the reporting.
Aaron Lippold
<EMAIL_ADDRESS>260-255-4779
twitter/aim/yahoo,etc.
'aaronlippold'
On Mon, Mar 11, 2019 at 4:15 PM Trevor Vaughan<EMAIL_ADDRESS>wrote:

@trevor-vaughan commented on this pull request.
In attributes.yml
https://github.com/simp/inspec-profile-disa_stig-el7/pull/67#discussion_r264410395
:

@@ -217,8 +217,8 @@ exempt_home_users: []

main grub boot config file
grub_main_cfg: '/boot/grub2/grub.cfg'
-# superusers for grub boot ( array )
-grub_superusers: ['root']
Soooo....it turns out that it's specifically not recommended to use root,
'admin, or administrator` as your superuser name.
Should that be marked as a warning and/or failure?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/simp/inspec-profile-disa_stig-el7/pull/67#discussion_r264410395,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABauaGBiKomR8lLDrJdngF4QTbiI4Fm_ks5vVrlrgaJpZM4bc5e_
.

@djhaynes @trevor-vaughan This is what Trevor was mentioning:
NOTE: It is recommended not to use common administrator account names like root, admin, or administrator for the grub2 superuser account.
So we need to make a call - I think this makes it clear that we should actually make it NOTROOT in the inputs and put a NOTE in the README that this needs to follow the recommendation above.

At the very least - inspec does allow us to throw a warn right? We could - in the interest of moving forward - pass the test with root for now AND throw a warn message referencing this guidance. In the end - most folks will choose to ignore this and just use root so we should at least shake a finger at them but not outright FAIL?

@aaronlippold Well, if we take the 'shake a finger' approach, then we might as well do that for all of the checks. I mean, a lot of people turn a LOT of them off.
That's why inspec is nice, you can go tell it to do something else if you really want to and you can do it pretty easily.

What needs to be done in order to resolve this PR?

I would just say we make it a non-root account name. Just to align with the recommendation. But in the end, it should be an input that we allow the user to set.

@trevor-vaughan where did this text come from?
NOTE: It is recommended not to use common administrator account names like root, admin, or administrator for the grub2 superuser account.

Ok. So the above Note came from RHEL8 guidance which we can implement when we get to RHEL8. For RHEL7 at this current revision, the test should test for the guidance. For now, let's just go with the strait guidance and we can make the adjustment in RHEL8. If we want, we can put this 'recommendation' as feedback in the test but still pass the test. But even that will cause confusion from a testing POV. I would say we just keep it simple on this and move this conversation to the RHEL8 baseline.

LGTM.


self hosted etcd has a circular dependency on service ip.

With self hosted etcd we see that significant memory pressure on the masters will cause the cluster to become unstable.
This will mean that the kubelet will eventually mark all the etcd pods unhealthy and thus the kube-proxy will rejecting packets headed for the kube-system/etcd-service:client
At this point the apiserver is unable to start as it is configured to connect to etcd cluster with the service ip address of the self hosted cluster. The service continues to have no health endpoints because the kubelet can't talk to the apiserver and tell it that the service has healthy endpoints.
So now we have a healthy etcd cluster and no way to update the record in etcd via the apiserver.

https://github.com/coreos/etcd-operator/issues/622 seems related.

Tolerate unreadiness is not enough. We also need to take into account restarts.

From this comment: https://github.com/kubernetes/kubernetes/issues/25283#issuecomment-264099193
Seems the tolerate-unready feature might be able to tolerate restart (rolling upgrade). We need to test out though

Further when you restart a node in this condition we aren't checkpointing the sh etcd cluster. So there is no way to get the cluster back in a reboot.

ref: https://github.com/kubernetes/kubernetes/issues/47880

We are going to enable alpha annotation TolerateUnreadyEndpointsAnnotation in etcd service. Will submit a PR shortly.


Feature Request: Support using constants in documentation

Hi, I would like to be able to use constants within documentation like this, please let me know if this can be supported!
before

after

both of these should produce the same result, but the second way would use a constant value and substitute it during generation
Thanks,
Rahul

Of course it can be supported, but should be another style, just a { } may conflicts with the above line you give.
Meanwhile, the const you give is just a simple case,  it may be an complex expression.
In the other hand, it will add complexity, for every comments line, we have to first check whether it contains varibles and then replace them.


first setup of ruff for python linting

Description
This PR sets up ruff for python linting. It also enables isort from within ruff and removes the standalone isort.
Related Issue(s)
closes #1149

Thanks for the pointers @roeap & @wjones127!


No source code links present for reference

No source links for the Git Hub repository present, to follow the folder structure how do I get to "/libraries/python/dbxdemo/test*.py" ?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 56b86f59-7a22-90c6-9aa6-652b85975612
Version Independent ID: b333ab7b-847b-7129-9b62-4b9b934747d7
Content: Continuous integration and delivery on Azure Databricks using Azure DevOps - Azure Databricks
Content Source: databricks/dev-tools/ci-cd/ci-cd-azure-devops.md
Service: azure-databricks
GitHub Login: @mamccrea
Microsoft Alias: mamccrea

Thanks for the feedback . At this we  have assigned the issue to the content author .

One more question that I have w.r.t to execution of  the DataBricks Unit test cases is that if I am executing the Unit Test cases as described in the article
**Where exactly do my unit tests run ?

in the databricks cluster that I connected to or
in the python environment that we have set up installing the Python Versions**

If I am to execute my test cases on the Databricks Cluster is there any other configurations to be done ?

Any update on this ? Also looking for
from dbxdemo.spark import get_spark
from dbxdemo.appendcol import with_status

Hi @prajyot2909 and @ssharmaz. dbxdemo is not available. The code in this article is only a sample.

I will now proceed to close this issue. If you have any additional questions, please reopen the issue.
#please-close

This is still an issue. I understand that the code in the article is an example but without a complete resources to the example the code will not work. Please either supply the solution in its entirety or provide references to information on how to complete the solution.


Add Uber

I'm surprised we didn't have it already. Thanks!

I only realized yesterday that I still needed to delete my account on top of deleting the app itself. Glad to help! :)


remove vendor deps in favour of go modules

A suggestion to remove the vendors folder and fully adopt go modules.

hey @jackyzhen ! good to hear from you and hope you're doing alright! sorry that it took a while for me to resume work on my github projects, but the pr looks perfect - thanks a lot!


relax pin to allow for installing with mamba 0.18

Checklist

[x] Used a personal fork of the feedstock to propose changes
[x] Bumped the build number (if the version is unchanged)
[ ] Reset the build number to 0 (if the version changed)
[ ] Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[x] Ensured the license file is being packaged.

Hooray mamba 0.18!
Boo no clear upstream pin in boa's setup.py on the mamba version!
Figured I'd try this here... I don't know what i don't know about the validity of it!

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@conda-forge-admin please rerender

Niooooooooooooooo

Api changed a lot actually so we need to fix boa. Thanks for the effort though!
There are a bunch of import statements that have moved from mamba_api to libmambapy :)

Can't say i didn't try!

We'll try to get this sorted early tomorrow :)


fix forecast_start date computation for multivarite R forecasts.

Issue #, if available:
N/A
Description of changes:
Computes the number of sequential observations in the target using shape[0] instead of len() as the former is valid for multi-dimensional arrays as well.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Job PR-63/1 is complete.
Docs are uploaded to http://gluon-ts-staging.s3-accelerate.dualstack.amazonaws.com/PR-63/1/index.html

Codecov Report

Merging #63 into master will not change coverage.
The diff coverage is 0%.

@@           Coverage Diff           @@
##           master      #63   +/-   ##
=======================================
  Coverage   77.81%   77.81%
=======================================
  Files         108      108
  Lines        6189     6189
=======================================
  Hits         4816     4816
  Misses       1373     1373

Impacted Files
Coverage Δ

src/gluonts/model/r_forecast/_predictor.py
19.51% <0%> (ø)
:arrow_up:


Update README.md

We created a logo to help the clarify the difference between js-ipfs and js-ipfs-api. Would you like to add to your client library as well? You can see how it looks here: https://github.com/ipfs/js-ipfs-api
This design is from @akrych 🌟

@diasdavid Thanks! It's lovely. 👍


[QA] eslint reports error at solarApiJson.js

eslint .

/home/runner/work/ioBroker.fronius/ioBroker.fronius/test/solarApiJson.js
3:20  error  Parsing error: Unexpected token =
✖ 1 problem (1 error, 0 warnings)

As an intermediate solution this file has been excluded from linting

In addition I would suggest to check whther this file could be migrated to a pure data file.
Currently it contains a class which exports several json strings referenced by variable names. It should be easy to migrate this to a pure json file read using require('filename')

I just fixed this issue.
plain variables at classes seems to be ruther new feature. So the eslint parser must be set to 2022 mode (was 2020 mode)
See https://stackoverflow.com/questions/60046847/eslint-does-not-allow-static-class-properties
I've fixed the other eslint issues like unneede escapes too.
This issue can be closed. No need to spent time to migrate to json file - unless you are interested for knowledge.

@mcm1957 i just did the move to the file. It is working. I also fixed the eslint issues with the hasOwnProperty as well

@nkleber78
OK, thanks a lot. Thats (in my opinion) the cleanest solution - especially in reard of future maintanance.

But unfortunately this cases issues for the build as the folder is "test". Is there a way to make this import and the rest of the code only availlable when needed or ignore the "module not found" in case the module is not in test

Sorry for the late reply.
What kind of problems do you have?
I think one or more of the following should work:
-) you can move the solarApiJosn.json to lib directory. Its does not harm. And it would open the possibility to add a flag "testmode" to config to run the testmode at user systems too.
-) I do not see a reason why keeping the require inside the if statement just like curent code should not wiork. So the require will be executed only if configured in source
-) I assume require raises an exception if the file does notz exist. This could be cateched and ignored using try{} catch(e){} construct.
Please let me know if I can help more - feel free to ask at telegram as I will note this faster

can you help me by adding the testmode flag to the config. I think this is a good idea. I moved the JSON to the lib directory. I would propose to do a merge of the PR and adding the testmode to the config

For a first test please simply use a boolean variable (i.e. testMode) in main.js.
You can later set it by reading config.xxx. (But as far as I know there was some sort of such a variable anyway. But I did not scan last code)
I will add the test flag when providing jsonConfig as I cannot write (good) html / react code.

Perfect, it is already a variable in the code so we can use that later in the jsonConfig

fixed with 2.0.0-alpha.4


Current release in not installable on windows

Hi all,
thanks for the release of the updated version. But I am not able to install it on my Windows 10 machine.

Can you tell me which library I miss?
Thank you in advance.
Best regards,
Master Lamps

@MasterLamp Is your windows 32 bit or 64 bit? Because I think our latest build only supports 64bit windows

@MasterLamp Is your windows 32 bit or 64 bit? Because I think our latest build only supports 64bit windows

A 64bit machine made it do for me. Thank you.


I want to know how to start learning to modify the model?

For example,SSD+FPN。
Seeing the source code is not explained, some places are confused。 Thanks for your help.

Please be specific, e.g., which part you are not clear with so that we can help you more efficiently.

https://mmdetection.readthedocs.io/en/latest/GETTING_STARTED.html#develop-new-components


[Feature Request] Batch Renormalization

Hi,
The renorm parameter in theBatchNormalization layer is available in Keras 2 (link), but not in Keras 3.
Is there any intention to migrate this option to Keras 3 as well? It's very good for training with mini-batches.
In any case, thank you in advance.

renorm flag was removed in Keras 3 to make Keras compatible across all backend and we don't have any plan to add it in Keras 3.
For more context refer: https://github.com/keras-team/keras/issues/19063#issuecomment-1915518601


Interactive logs

I'd like to support a more interactive log UI with saved searches, mouse/keyboard field expansion etc.

[ ] click log to expand fields
[ ] click field values to filter further
[ ] add saved searches

It would be nice if you could quickly show me the CW log group and AWS console URL from the cli, so I can quickly share with my colleagues.


[Question] How can I achieve ClickHouse synchronization between two Kubernetes clusters?

I have successfully deployed ClickHouse using clickhouse-operator-altinity in one of the Kubernetes clusters (Cluster A), utilizing clickhouse-keeper for replica synchronization. The deployment configuration is as follows:
apiVersion: clickhouse.altinity.com/v1
kind: ClickHouseInstallation
metadata:
  name: my-clickhouse
spec:
  defaults:
    templates:
      dataVolumeClaimTemplate: default-volume-claim
      logVolumeClaimTemplate: default-volume-claim
  configuration:
    users:
      user1/networks/ip: "::/0"
      user1/password: abc098pmdd
      user1/profile: default
    clusters:
      - name: replicas-only
        templates:
          podTemplate: clickhouse-v23.8
          dataVolumeClaimTemplate: default-volume-claim
          logVolumeClaimTemplate: default-volume-claim
        layout:
          # shardsCount not specified, assumed = 1, by default
          replicasCount: 3
    zookeeper:
      nodes:
        - host: clickhouse-keeper.clickhouse.svc.cluster.local
          port: 2181
  templates:
    volumeClaimTemplates:
      - name: default-volume-claim
        provisioner: StatefulSet
        reclaimPolicy: Retain
        spec:
          storageClassName: csi-rbd-sc
          accessModes:
            - ReadWriteOnce
          resources:
            requests:
              storage: 20Gi
    podTemplates:
      - name: clickhouse-v23.8
        spec:
          containers:
            - name: clickhouse
              image: clickhouse/clickhouse-server:23.8
              volumeMounts:
                - name: default-volume-claim
                  mountPath: /var/lib/clickhouse
              resources:
                requests:
                  memory: "256Mi"
                  cpu: "200m"
                limits:
                  memory: "4096Mi"
                  cpu: "2000m"

The current operational status is:
kubectl get all -n clickhouse
NAME                                                                 READY   STATUS    RESTARTS        AGE
pod/chi-my-clickhouse-replicas-only-0-0-0                            2/2     Running   0               4h35m
pod/chi-my-clickhouse-replicas-only-0-1-0                            2/2     Running   2 (3h27m ago)   4h19m
pod/chi-my-clickhouse-replicas-only-0-2-0                            2/2     Running   8 (3h27m ago)   9d
pod/clickhouse-keeper-0                                              1/1     Running   6 (3h52m ago)   15d
pod/clickhouse-keeper-1                                              1/1     Running   4 (3h58m ago)   15d
pod/clickhouse-keeper-2                                              1/1     Running   3 (3h58m ago)   15d
pod/clickhouse-operator-altinity-clickhouse-operator-6964d78-ptfxq   2/2     Running   6 (23h ago)     16d

Now, how should I write the deployment configuration file for my second Kubernetes cluster (Cluster B)?
Should I first install clickhouse-operator-altinity in Cluster B without deploying clickhouse-keeper? Then, referring to the ClickHouse configuration in Cluster A, should I change the zookeeper connection information to connect to the clickhouse-keeper in Cluster A, while keeping all other information, including usernames, passwords, etc., unchanged?
I have seen samples related to zones and distribution, such as:
zones-04-advanced-04-pod-per-host-local-storage.yaml
13-distribution-02-3x3-circular-replication.yaml
However, I'm not sure if these are applicable to my scenario of having two separate Kubernetes clusters, and I'm not using Amazon cloud Web Services. My Kubernetes clusters are deployed on bare metal in two separate data centers.

first of all,
you need to apply something solutions which allow access clickhouse-server from cluster B to keeper in cluster A
try look to
https://github.com/liqotech/liqo
https://github.com/submariner-io/submariner
after keeper serivce will available in cluster B
then you can try to install kind: ClickHouseInstallation
with
spec:
 configuration:
   clusters:
   - name: cluster-b
     shardsCount: 1
     replicasCount: 1
   zookepeer:

which reference to keeper service in cluster A
use engine=ReplicatedMergeTree('/clickhouse/tables/{shard}/{database}/{table}','{replica}') in your table schemas
in this case your cluster-b will have same data with replicas-only in cluster A

@Slach  I have a general understanding of the approach you mentioned.
Currently, I am able to expose the ClickHouse service in Kubernetes cluster A to the outside using MetalLB, which allows services outside the cluster to access it.

kubectl get svc -n clickhouse
NAME                                                       TYPE           CLUSTER-IP       EXTERNAL-IP    PORT(S)                                        AGE
clickhouse-keeper                                          LoadBalancer      <IP_ADDRESS>    <IP_ADDRESS>        2181:32234/TCP,7000:31862/TCP                              15d

As for Kubernetes cluster B, would it be feasible to install ClickHouse with a configuration that specifies the use of the keeper in Kubernetes cluster A, while keeping all other information unchanged?

apiVersion: clickhouse.altinity.com/v1
kind: ClickHouseInstallation
metadata:
name: my-clickhouse
spec:
defaults:
templates:
dataVolumeClaimTemplate: default-volume-claim
logVolumeClaimTemplate: default-volume-claim
configuration:
users:
user1/networks/ip: "::/0"            #####  unchanged
user1/password: 123qeoesrgt     #####  unchanged
user1/profile: default              #####  unchanged
clusters:
- name: replicas-only      #####  unchanged
templates:
podTemplate: clickhouse-v23.8
dataVolumeClaimTemplate: default-volume-claim
logVolumeClaimTemplate: default-volume-claim
layout:
# shardsCount not specified, assumed = 1, by default
replicasCount: 3
zookeeper:
nodes:
- host: <IP_ADDRESS>   ####keeper in cluster A
port: 2181
templates:
...

yes, following config section looks good
    zookeeper:
      nodes:
        - host: <IP_ADDRESS>   ####keeper in cluster A
          port: 2181

check availability for <IP_ADDRESS>:2181
new clickhouse cluster in k8s cluster-B shall have different name with clickhouse cluster in k8s cluster-A to avoid conflicts of {replica} macros values

@Slach
Cluster A remains unchanged as per the above deployment. Now, I have linked Cluster B with Cluster A using the capabilities of cilium clustermesh. I have created a new svc for clickhouse-keeper in Cluster A as follows:
`apiVersion: v1
kind: Service
metadata:
annotations:
service.cilium.io/global: "true"
service.cilium.io/shared: "true"
labels:
app: clickhouse-keeper
name: clickhouse-keeper-global
namespace: clickhouse
spec:
ports:

name: client
port: 2181
protocol: TCP
targetPort: 2181
name: prometheus
port: 7000
protocol: TCP
targetPort: 7000
selector:
app: clickhouse-keeper
what: node
sessionAffinity: None
type: ClusterIP`

At the same time, I also created the same svc in Cluster B with the same configuration. Now, I can query and access the clickhouse-keeper of Cluster A by starting the zookeeper cli in Cluster B. The information is as follows:
`[zk: clickhouse-keeper-global.clickhouse.svc.cluster.local:2181(CONNECTED) 20] ls /clickhouse
[my-clickhouse, replicas-only, table, tables]`
I want to achieve that after Cluster B starts, the clickhouse can synchronize all data with the original Cluster A.
So, what changes should be made in the clickhouse of Cluster B? Please see below:
apiVersion: clickhouse.altinity.com/v1
kind: ClickHouseInstallation
metadata:
name: my-clickhouse ###Should this naming be consistent with Cluster A？
spec:
defaults:
templates:
dataVolumeClaimTemplate: default-volume-claim
logVolumeClaimTemplate: default-volume-claim
configuration:
users:
user1/networks/ip: "::/0"
user1/password: ckadmin2024
user1/profile: default
clusters:
- name: replicas-only  ###Should this naming be consistent with Cluster A？
templates:
podTemplate: clickhouse-v23.8
dataVolumeClaimTemplate: default-volume-claim
logVolumeClaimTemplate: default-volume-claim
layout:
# shardsCount not specified, assumed = 1, by default
replicasCount: 3
zookeeper:
nodes:
- host: clickhouse-keeper-global.clickhouse.svc.cluster.local
port: 2181
templates:
volumeClaimTemplates:
- name: default-volume-claim
provisioner: StatefulSet
reclaimPolicy: Retain
spec:
storageClassName: csi-rbd-sc
accessModes:
- ReadWriteOnce
resources:
requests:
storage: 20Gi
podTemplates:
- name: clickhouse-v23.8
spec:
containers:
- name: clickhouse
image: clickhouse/clickhouse-server:23.8
volumeMounts:
- name: default-volume-claim
mountPath: /var/lib/clickhouse
resources:
requests:
memory: "256Mi"
cpu: "200m"
limits:
memory: "4096Mi"
cpu: "2000m"

@Slach
I have successfully deployed Cluster B using different parameters from Cluster A as per the following configuration.
apiVersion: clickhouse.altinity.com/v1
kind: ClickHouseInstallation
metadata:
  name: my-clickhouse-b  ### different name
clusters:
      - name: replicas-only-b  ### different cluster name

A month ago, I created a database and data table in my Cluster A and imported one piece of data. It can run normally under Cluster A. The statements to create the database and table are as follows:
CREATE DATABASE test_db ON CLUSTER 'replicas-only';

CREATE TABLE IF NOT EXISTS test_db.za_history ON CLUSTER 'replicas-only' (
    za_name String,
    za_data_id UInt64,
    itemid Int64,
    create_time DateTime
)
ENGINE = ReplicatedMergeTree('/clickhouse/tables/01/{database}/{table}', '{replica}')
PARTITION BY toYYYYMMDD(create_time)
ORDER BY create_time

Now, I have also created the corresponding database and data table in Cluster B, but the parameters use the name of Cluster B, as follows:
CREATE DATABASE test_db ON CLUSTER 'replicas-only-b';

CREATE TABLE IF NOT EXISTS test_db.za_history ON CLUSTER 'replicas-only-b' (
    za_name String,
    za_data_id UInt64,
    itemid Int64,
    create_time DateTime
)
ENGINE = ReplicatedMergeTree('/clickhouse/tables/01/{database}/{table}', '{replica}')
PARTITION BY toYYYYMMDD(create_time)
ORDER BY create_time

Now, I find that the data of Cluster A has not been synchronized to Cluster B. When I query the information through the ZooKeeper CLI, there is information about Cluster B.
[zk: clickhouse-keeper-global.clickhouse.svc.cluster.local:2181(CONNECTED) 35]
 ls /clickhouse/tables/2/test_db/za_history/replicas
[chi-my-clickhouse-b-replicas-only-b-0-0, chi-my-clickhouse-b-replicas-only-b-0-1, chi-my-clickhouse-b-replicas-only-b-0-2, chi-my-clickhouse-replicas-only-0-0, chi-my-clickhouse-replicas-only-0-1, chi-my-clickhouse-replicas-only-0-2]

Is there something wrong with my configuration? Or, to trigger data synchronization, have I missed any steps, such as inserting one or two pieces of data into za_history to activate synchronization?

@Slach
Thank you for your correction, my database creation statement was wrong. The query for Cluster A found that it is using ReplicatedMergeTree(‘/clickhouse/tables/2/{database}/{table}’, ‘{replica}’).
So Cluster B should also use
ReplicatedMergeTree(‘/clickhouse/tables/2/{database}/{table}’, ‘{replica}’).
Because my cluster does not plan to use the sharding feature, so shardsCount is set to 1, so {shard} uses a fixed value. Previously, I arbitrarily filled in 2, so I have been using 2 as the directory structure.
In this way, the node path of the same set of clickhouse-keeper is adapted. At this time, using the query statement you provided, I see the synchronization progress.
I found that in the cluster synchronization information, the replication_queue indicates that DNS cannot resolve the host corresponding to the replica, and the connection times out. It should be that the local cluster cannot know the information across clusters.
The solution I found:
Declare the svc of my-clickhouse in Cluster A to be deployed in Cluster B Declare the svc of my-clickhouse-b in Cluster B to also be deployed in Cluster A. At the same time, add the following in these svcs:
annotations:
   service.cilium.io/global: “true”
   service.cilium.io/shared: “true”

Finally, the data synchronization was successful.
Thank you for your guidance!


[FIREBASE_STORAGE]: java.lang.OutOfMemoryError after repeated use of putData()/putFile()

Is there an existing issue for this?

[X] I have searched the existing issues.

Which plugins are affected?
Storage
Which platforms are affected?
Android
Description
Running what is essentially the following:
Uint8List buffer = Uint8List(5000000);
Reference ref =  FirebaseStorage.instance.ref();
UploadTask? uploadTask = await ref.child(path/to/file.pcm).putData(buffer);

seems to leave behind a ByteBuffer of length 5,000,000, and a second ByteBuffer of length ~4,190,000 each time it is called. The source of these two according to the Android Studio profiler are as follows:

I have an application which would expect to upload ~300 5MB chunks over the course of a session and am seeing OOM of the following kind: Fatal Exception: java.lang.OutOfMemoryError: Failed to allocate a 2576 byte allocation with 1020864 free bytes and 996KB until OOM, target footprint 268435456, growth limit 268435456; giving up on allocation because <1% of heap free after GC. for some users after around 40 calls of the putData function.
Note: I have also tried writing the data to a file and using putFile instead of putData, but I see exactly the same behaviour.
I am also getting the following warning every time an upload finishes successfully:
W/StorageTask(11365): unable to change internal state to: INTERNAL_STATE_CANCELED, INTERNAL_STATE_CANCELING isUser: true from state:INTERNAL_STATE_SUCCESS
which seems to imply that after the upload has been successful, a cancel function is being called, but that cancel function is unable to complete.
Reproducing the issue
Create a button which has the following onPressed
Uint8List buffer = Uint8List(5000000);
Reference ref =  FirebaseStorage.instance.ref();
UploadTask? uploadTask = await ref.child(path/to/file.pcm).putData(buffer);

Each time it is tapped data is allocated to the java heap that is never deallocated.
Firebase Core version
3.2.0
Flutter Version
3.22.2
Relevant Log Output
D/UploadTask(11365): Waiting 0 milliseconds
W/StorageUtil(11365): Error getting App Check token; using placeholder token instead. Error: com.google.firebase.FirebaseException: No AppCheckProvider installed.
D/UploadTask(11365): Increasing chunk size to 524288
D/UploadTask(11365): Waiting 0 milliseconds
W/StorageUtil(11365): Error getting App Check token; using placeholder token instead. Error: com.google.firebase.FirebaseException: No AppCheckProvider installed.
D/UploadTask(11365): Increasing chunk size to 1048576
D/UploadTask(11365): Waiting 0 milliseconds
W/StorageUtil(11365): Error getting App Check token; using placeholder token instead. Error: com.google.firebase.FirebaseException: No AppCheckProvider installed.
D/UploadTask(11365): Increasing chunk size to 2097152
D/UploadTask(11365): Waiting 0 milliseconds
W/StorageUtil(11365): Error getting App Check token; using placeholder token instead. Error: com.google.firebase.FirebaseException: No AppCheckProvider installed.
D/UploadTask(11365): Increasing chunk size to 4194304
D/UploadTask(11365): Waiting 0 milliseconds
W/StorageUtil(11365): Error getting App Check token; using placeholder token instead. Error: com.google.firebase.FirebaseException: No AppCheckProvider installed.
W/StorageTask(11365): unable to change internal state to: INTERNAL_STATE_CANCELED, INTERNAL_STATE_CANCELING isUser: true from state:INTERNAL_STATE_SUCCESS

Flutter dependencies

Expand Flutter dependencies snippet

Dart SDK 3.4.3
Flutter SDK 3.22.2

dependencies:
- android_intent_plus 5.1.0 [flutter platform meta]
- async 2.11.0 [collection meta]
- audio_session 0.1.21 [flutter flutter_web_plugins rxdart meta]
- cloud_firestore 5.2.1 [cloud_firestore_platform_interface cloud_firestore_web collection firebase_core firebase_core_platform_interface flutter meta]
- community_material_icon 5.9.55 [flutter]
- connectivity_plus 5.0.2 [flutter flutter_web_plugins connectivity_plus_platform_interface js meta nm]
- convert 3.1.1 [typed_data]
- cupertino_icons 1.0.8
- firebase_analytics 11.2.1 [firebase_analytics_platform_interface firebase_analytics_web firebase_core firebase_core_platform_interface flutter]
- firebase_auth 5.1.4 [firebase_auth_platform_interface firebase_auth_web firebase_core firebase_core_platform_interface flutter meta]
- firebase_core 3.3.0 [firebase_core_platform_interface firebase_core_web flutter meta]
- firebase_crashlytics 4.0.4 [firebase_core firebase_core_platform_interface firebase_crashlytics_platform_interface flutter stack_trace]
- firebase_storage 12.1.3 [firebase_core firebase_core_platform_interface firebase_storage_platform_interface firebase_storage_web flutter]
- flutter 0.0.0 [characters collection material_color_utilities meta vector_math sky_engine]
- flutter_blue_plus 1.14.11 [flutter]
- flutter_hooks 0.20.5 [flutter]
- flutter_localizations 0.0.0 [flutter intl characters clock collection material_color_utilities meta path vector_math]
- flutter_sound 9.2.13 [path_provider recase uuid provider path synchronized logger flutter flutter_sound_platform_interface flutter_sound_web]
- flutter_sound_platform_interface 9.2.13 [flutter meta plugin_platform_interface logger]
- flutter_svg 2.0.10+1 [flutter http vector_graphics vector_graphics_codec vector_graphics_compiler]
- flutter_widget_from_html_core 0.15.1 [csslib flutter html logging]
- hooks_riverpod 2.5.1 [collection flutter flutter_hooks flutter_riverpod riverpod state_notifier]
- html 0.15.4 [csslib source_span]
- html_unescape 2.0.0
- http 1.2.2 [async http_parser meta web]
- internet_connection_checker_plus 2.2.0 [connectivity_plus flutter http]
- logger 1.4.0
- path_provider 2.1.4 [flutter path_provider_android path_provider_foundation path_provider_linux path_provider_platform_interface path_provider_windows]
- permission_handler 11.3.1 [flutter meta permission_handler_android permission_handler_apple permission_handler_html permission_handler_windows permission_handler_platform_interface]
- sanitize_html 2.1.0 [html meta]
- shared_preferences 2.3.1 [flutter shared_preferences_android shared_preferences_foundation shared_preferences_linux shared_preferences_platform_interface shared_preferences_web shared_preferences_windows]
- stop_watch_timer 3.2.0 [rxdart]
- url_launcher 6.3.0 [flutter url_launcher_android url_launcher_ios url_launcher_linux url_launcher_macos url_launcher_platform_interface url_launcher_web url_launcher_windows]
- uuid 3.0.7 [crypto]
- wakelock_plus 1.2.7 [flutter flutter_web_plugins meta wakelock_plus_platform_interface win32 dbus package_info_plus web]
- webview_flutter 4.8.0 [flutter webview_flutter_android webview_flutter_platform_interface webview_flutter_wkwebview]

dev dependencies:
- flutter_launcher_icons 0.13.1 [args checked_yaml cli_util image json_annotation path yaml]
- flutter_lints 4.0.0 [lints]
- flutter_test 0.0.0 [flutter test_api matcher path fake_async clock stack_trace vector_math leak_tracker_flutter_testing async boolean_selector characters collection leak_tracker leak_tracker_testing material_color_utilities meta source_span stream_channel string_scanner term_glyph vm_service]
- mockito 5.4.4 [analyzer build code_builder collection dart_style matcher meta path source_gen test_api]

transitive dependencies:
- _fe_analyzer_shared 67.0.0 [meta]
- _flutterfire_internals 1.3.40 [collection firebase_core firebase_core_platform_interface flutter meta]
- analyzer 6.4.1 [_fe_analyzer_shared collection convert crypto glob meta package_config path pub_semver source_span watcher yaml]
- archive 3.6.1 [crypto path]
- args 2.5.0
- boolean_selector 2.1.1 [source_span string_scanner]
- build 2.4.1 [analyzer async convert crypto glob logging meta package_config path]
- built_collection 5.1.1
- built_value 8.9.2 [built_collection collection fixnum meta]
- characters 1.3.0
- checked_yaml 2.0.3 [json_annotation source_span yaml]
- cli_util 0.4.1 [meta path]
- clock 1.1.1
- cloud_firestore_platform_interface 6.3.1 [_flutterfire_internals collection firebase_core flutter meta plugin_platform_interface]
- cloud_firestore_web 4.1.1 [_flutterfire_internals cloud_firestore_platform_interface collection firebase_core firebase_core_web flutter flutter_web_plugins]
- code_builder 4.10.0 [built_collection built_value collection matcher meta]
- collection 1.18.0
- connectivity_plus_platform_interface 1.2.4 [flutter meta plugin_platform_interface]
- crypto 3.0.3 [typed_data]
- csslib 1.0.0 [source_span]
- dart_style 2.3.6 [analyzer args collection path pub_semver source_span]
- dbus 0.7.10 [args ffi meta xml]
- fake_async 1.3.1 [clock collection]
- ffi 2.1.2
- file 7.0.0 [meta path]
- firebase_analytics_platform_interface 4.2.1 [_flutterfire_internals firebase_core flutter meta plugin_platform_interface]
- firebase_analytics_web 0.5.9+1 [_flutterfire_internals firebase_analytics_platform_interface firebase_core firebase_core_web flutter flutter_web_plugins]
- firebase_auth_platform_interface 7.4.3 [_flutterfire_internals collection firebase_core flutter meta plugin_platform_interface]
- firebase_auth_web 5.12.5 [firebase_auth_platform_interface firebase_core firebase_core_web flutter flutter_web_plugins http_parser meta web]
- firebase_core_platform_interface 5.2.0 [collection flutter flutter_test meta plugin_platform_interface]
- firebase_core_web 2.17.4 [firebase_core_platform_interface flutter flutter_web_plugins meta web]
- firebase_crashlytics_platform_interface 3.6.40 [_flutterfire_internals collection firebase_core flutter meta plugin_platform_interface]
- firebase_storage_platform_interface 5.1.27 [_flutterfire_internals collection firebase_core flutter meta plugin_platform_interface]
- firebase_storage_web 3.9.12 [_flutterfire_internals async firebase_core firebase_core_web firebase_storage_platform_interface flutter flutter_web_plugins http meta web]
- fixnum 1.1.0
- flutter_riverpod 2.5.1 [collection flutter meta riverpod state_notifier]
- flutter_sound_web 9.2.13 [flutter_sound_platform_interface flutter logger flutter_web_plugins meta js]
- flutter_web_plugins 0.0.0 [flutter characters collection material_color_utilities meta vector_math]
- glob 2.1.2 [async collection file path string_scanner]
- http_parser 4.0.2 [collection source_span string_scanner typed_data]
- image 4.2.0 [archive meta xml]
- intl 0.19.0 [clock meta path]
- js 0.6.7 [meta]
- json_annotation 4.9.0 [meta]
- leak_tracker 10.0.4 [clock collection meta path vm_service]
- leak_tracker_flutter_testing 3.0.3 [flutter leak_tracker leak_tracker_testing matcher meta]
- leak_tracker_testing 3.0.1 [leak_tracker matcher meta]
- lints 4.0.0
- logging 1.2.0
- matcher 0.12.16+1 [async meta stack_trace term_glyph test_api]
- material_color_utilities 0.8.0 [collection]
- meta 1.12.0
- nested 1.0.0 [flutter]
- nm 0.5.0 [dbus]
- package_config 2.1.0 [path]
- package_info_plus 8.0.2 [ffi flutter flutter_web_plugins http meta path package_info_plus_platform_interface web win32 clock]
- package_info_plus_platform_interface 3.0.1 [flutter meta plugin_platform_interface]
- path 1.9.0
- path_parsing 1.0.1 [vector_math meta]
- path_provider_android 2.2.9 [flutter path_provider_platform_interface]
- path_provider_foundation 2.4.0 [flutter path_provider_platform_interface]
- path_provider_linux 2.2.1 [ffi flutter path path_provider_platform_interface xdg_directories]
- path_provider_platform_interface 2.1.2 [flutter platform plugin_platform_interface]
- path_provider_windows 2.3.0 [ffi flutter path path_provider_platform_interface]
- permission_handler_android 12.0.8 [flutter permission_handler_platform_interface]
- permission_handler_apple 9.4.5 [flutter permission_handler_platform_interface]
- permission_handler_html 0.1.2 [flutter flutter_web_plugins permission_handler_platform_interface web]
- permission_handler_platform_interface 4.2.2 [flutter meta plugin_platform_interface]
- permission_handler_windows 0.2.1 [flutter permission_handler_platform_interface]
- petitparser 6.0.2 [meta]
- platform 3.1.5
- plugin_platform_interface 2.1.8 [meta]
- provider 6.1.2 [collection flutter nested]
- pub_semver 2.1.4 [collection meta]
- recase 4.1.0
- riverpod 2.5.1 [collection meta stack_trace state_notifier]
- rxdart 0.28.0
- shared_preferences_android 2.3.1 [flutter shared_preferences_platform_interface]
- shared_preferences_foundation 2.5.1 [flutter shared_preferences_platform_interface]
- shared_preferences_linux 2.4.1 [file flutter path path_provider_linux path_provider_platform_interface shared_preferences_platform_interface]
- shared_preferences_platform_interface 2.4.1 [flutter plugin_platform_interface]
- shared_preferences_web 2.4.2 [flutter flutter_web_plugins shared_preferences_platform_interface web]
- shared_preferences_windows 2.4.1 [file flutter path path_provider_platform_interface path_provider_windows shared_preferences_platform_interface]
- sky_engine 0.0.99
- source_gen 1.5.0 [analyzer async build dart_style glob path source_span yaml]
- source_span 1.10.0 [collection path term_glyph]
- stack_trace 1.11.1 [path]
- state_notifier 1.0.0 [meta]
- stream_channel 2.1.2 [async]
- string_scanner 1.2.0 [source_span]
- synchronized 3.1.0+1
- term_glyph 1.2.1
- test_api 0.7.0 [async boolean_selector collection meta source_span stack_trace stream_channel string_scanner term_glyph]
- typed_data 1.3.2 [collection]
- url_launcher_android 6.3.8 [flutter url_launcher_platform_interface]
- url_launcher_ios 6.3.1 [flutter url_launcher_platform_interface]
- url_launcher_linux 3.2.0 [flutter url_launcher_platform_interface]
- url_launcher_macos 3.2.0 [flutter url_launcher_platform_interface]
- url_launcher_platform_interface 2.3.2 [flutter plugin_platform_interface]
- url_launcher_web 2.3.3 [flutter flutter_web_plugins url_launcher_platform_interface web]
- url_launcher_windows 3.1.2 [flutter url_launcher_platform_interface]
- vector_graphics 1.1.11+1 [flutter http vector_graphics_codec]
- vector_graphics_codec 1.1.11+1
- vector_graphics_compiler 1.1.11+1 [args meta path_parsing xml vector_graphics_codec path]
- vector_math 2.1.4
- vm_service 14.2.1
- wakelock_plus_platform_interface 1.2.1 [flutter plugin_platform_interface meta]
- watcher 1.1.0 [async path]
- web 0.5.1
- webview_flutter_android 3.16.6 [flutter webview_flutter_platform_interface]
- webview_flutter_platform_interface 2.10.0 [flutter meta plugin_platform_interface]
- webview_flutter_wkwebview 3.14.0 [flutter path webview_flutter_platform_interface]
- win32 5.5.3 [ffi]
- xdg_directories 1.0.4 [meta path]
- xml 6.5.0 [collection meta petitparser]
- yaml 3.1.2 [collection source_span string_scanner]

Additional context and comments
No response

Hi @CloudMountain , after further digging, I've discovered that this has to do with the native underlying sdk. It should be worth mentioning here. I'll go ahead and close this for now

Hi @CloudMountain , sorry for the late response. This is being looked into.

Hello guys,
Any update on this ?
Is there any workaround ?
Regards

I can take a look at this. Thank you for the investigation, @CloudMountain 🙏

On our side, this problem happens on some Android devices, especially Xiaomi devices, while trying to upload videos to Firebase Storage.
Already tried to add :
       android:largeHeap="true"
In AndroidManifest.xml
And also :
org.gradle.jvmargs=-Xmx4608m
on gradle.properties
No problem on iPhone.

Hey @CloudMountain  - I have created a PR to fix the out of memory exception on android: https://github.com/firebase/flutterfire/pull/13508
Could you please test this on your app and let me know if it resolves your issue? 🙏  Also - if anyone else wants to try it out, it's on this branch: https://github.com/firebase/flutterfire/tree/storage-13385

@CloudMountain - Could you create a new issue? Thanks for the confirmation 🙏


Too many categories in auto-generated function docs

When you regenerate the functions page based on the current cockroach master, you get this:

This is what we had before:

cc @dt


fix!: move mimc to hash submodule

Description
Problem*
Resolves #3342
Summary*
Move mimc to a submodule of hash module. This is a breaking change because people using mimc will need to update the mimc path.
Additional Context
Documentation*
Check one:

[ ] No documentation needed.
[X] Documentation included in this PR.
[ ] [Exceptional Case] Documentation to be submitted in a separate PR.

PR Checklist*

[X] I have tested the changes locally.
[X] I have formatted the changes with Prettier and/or cargo fmt on default settings.

cc @signorecello for the added docs.


[BrokenLinksH2] Fix path in link

Fixing breadcrumb TOC links

Learn Build status updates of commit 5314e92:
:bulb: Validation status: suggestions

File
Status
Preview URL
Details

microsoftgraph/breadcrumb/toc.yml
:bulb:Suggestion

Details

microsoftgraph/breadcrumb/toc.yml

Line 14, Column 18: [Suggestion: preserve-view-not-set - See documentation] You've pinned this link to a specific version of content with the view parameter. It's recommended not to pin a version unless that version is A) not the default view and B) the context is about that version specifically. To proceed with pinning a version add the &preserve-view=true to the URL.  Otherwise, remove the view parameter. URL: /powershell/module/Microsoft.Graph.Applications/?view=graph-powershell-1.0
Line 17, Column 18: [Suggestion: preserve-view-not-set - See documentation] You've pinned this link to a specific version of content with the view parameter. It's recommended not to pin a version unless that version is A) not the default view and B) the context is about that version specifically. To proceed with pinning a version add the &preserve-view=true to the URL.  Otherwise, remove the view parameter. URL: /powershell/module/Microsoft.Graph.Applications/?view=graph-powershell-beta

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching the learn.microsoft.com contributor guidesPost your question in the Learn support channel

@msewaweru - The C+E Skilling team is fixing broken links on docs.microsoft.com. This will eliminate potential accessibility, security, and usability issues. This PR includes only link fix and does not change other content. This PR is ready for approval and merge. Thank you!

Thanks @DhurataJ, I will review this.


webrtc ios build failed: mac osx sdk is incompatible

Does the webrtc build script not work on Mojave (10.14.1)?
python build-webrtc.py --setup --ios ~/src/
cd ~/src/build_webrtc/webrtc/ios/src/
git checkout -b build-M57 refs/remotes/branch-heads/57
git cherry-pick 0e22a4cfd3790d80ad1ae699891341fe322cb418
python build-webrtc.py --build --ios ~/src/

Observerd behavior

WARNING: The Mac OS X SDK is incompatible with the version of Xcode. To fix,
either upgrade Xcode to the latest version or install the Mac OS X
10.11 SDK. For more information, see https://crbug.com/620127.
Current SDK Version:   10.14
Current Xcode Version: 0101 (10B61)

ERROR at //build/config/mac/mac_sdk.gni:104:3: Assertion failed.
assert(false, "SDK is incompatible with Xcode")
^-----
SDK is incompatible with Xcode
See //build/toolchain/mac/BUILD.gn:14:1: whence it was imported.
import("//build/config/mac/mac_sdk.gni")
^--------------------------------------
See //BUILD.gn:11:1: which caused the file to be included.
group("default") {
^-----------------
Steps to reproduce the problem
Follow the documentation for ios webrtc build.
Platform information

React Native version:
Plugin version: master
OS: OSX 10.14

Have you tried a newer branch? 57 is ancient.

Build-57 is specified in the docs, I will have to give a newer branch a shot.
https://github.com/oney/react-native-webrtc/blob/master/Documentation/BuildingWebRTC.md

Well, that's an example. You need to pick the branch you want. Why are you building WebRTC yoursef BTW?

Right, I should have understood it was an example, but I was following it as instructions, my mistake.
I was trying to build webrtc myself, because I was unable to get any app, no matter how basic, to successfully build/run.
I wasn't sure if there was something specific with my setup that was preventing react-native + webrtc to work, so I was going to build it on my machine to see if it made a difference. Since this post I have uninstalled and reinstalled react-native, and now things are working. So, there must have been something wrong with my install.

Good to hear! If you think the docs need some clarification, a PR would be most welcome.


!!cookie as false won't work in lifecycle hook

for some reason it will produce true value if false with double ! to convert null value of cookie not created.

using base library there're no bugs.

@janat08 Could you please elaborate? ie. show some example code a use case where the problem occurs.

mounted: function () {
this.romanized = !(!(Cookie.get('romanized')))
console.log('romanized', this.romanized, !!Cookie.get('romanize'))
},

Hmm, its seems you are using the Global Cookie function provided by tiny-cookie try doing
this.$cookie.get('romanized');

No, using your package for global variant is what will fail
On Tue, Apr 11, 2017 at 11:59 PM, Alf<EMAIL_ADDRESS>wrote:

Hmm, its seems you are using the Global Cookie function provided by
tiny-cookie try doing
this.$cookie.get('romanized');
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/alfhen/vue-cookie/issues/16#issuecomment-293347410,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AKz-gT3r27uONNtp5ou_CNEmIbxJbQKoks5ru7-CgaJpZM4M4Brp
.

@janat08, If you want to use the global Cookie.get() function, then I suggest that you use the tiny-cookie package directly in your project rather than relying on this package. This package supports two ways of interacting with cookies through either this.$cookie or Vue.cookie as described in the documentation.

would you try !!this.$cookie.get('stuf') yourself
On Fri, Apr 21, 2017 at 2:31 PM, Alf<EMAIL_ADDRESS>wrote:

Closed #16 https://github.com/alfhen/vue-cookie/issues/16.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/alfhen/vue-cookie/issues/16#event-1052043221, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AKz-gU0IvTsqDOWx9J9phurgmssWqohgks5ryGl9gaJpZM4M4Brp
.


make s3 release for go scripts executable

Issue #, if available:
Description of changes:
make script executable
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

/approve


Outdated Package Spotted - litecoin

So I look through the packages maintained by dgtm, to see if there is some packages that are outdated and GitHub projects, that I could maintain.
The package  litecoin seems to meet those criteria:

The version 0.15.1 is the latest version on Chocolatey while the version <IP_ADDRESS> is available on GitHub

TODOs:

[ ] Becoming a Maintainer of the package

[ ] Leave a comment to notify the current maintainer about the fact that the package is outdated
[ ] If there is no answer after one week, Then send a message via the option Contact Maintainers
[ ] If there is no answer after another week, Then contact the Site Admins to assess the situation

[ ] After becoming a maintainer, then, we can create the package in chocolatey-package repository
[ ] Once the package is uploaded and integrated, see if it is possible to specify the Chocolatey installation in litecoin repository

maintained by me ;-)


Questions about "best practices" or NOT to do's

Question
I found this library by looking for a way to enhance/improve the functionality of  React.Context
So I have some questions about what not to do, best practice usage, etc.

Is there a performance issue if I implement "helper" hooks similar to these:

export const useMainStoreState = <T extends keyof State>(resource: T) => {
  return useContextSelector(context, (v) => v[0][resource]) as State[T];
};

export const useMainStoreDispatch = () => {
  return useContextSelector(context, (v) => v[1]);
}

Is there any performance issue if I setup/access state and dispatch in "Object" instead of  a "Tuple" ?

export const context = createContext<{ state: State, dispatch: Dispatch }>({ state: initialState, dispatch: () => null });

// then in component
const resource = useContextSelector(context, (v) => v.state.resource);
const dispatch = useContextSelector(context, (v) => v.dispatch);

// this may also be combined with the code on top about `useMainStore()`

1: No
2: No

As useContextSelector RFC is basically rejected, I would generally suggest the following.

Use global state library such as Zustand and Jotai
Or, use a simpler impl with uSES: https://github.com/dai-shi/use-context-selector/issues/109#issuecomment-1785147682

This library exists as an internal library for React-Tracked and has been maintained. Its purpose is to make it compatible with Concurrent Rendering, but it's not often the capability people need.


Unable to install on Linux Mint

Hi, I can't figure out this problem.
Version of Nuitka (nuitka --version):
<IP_ADDRESS>
2.7.12 (default, Dec  4 2017, 14:50:18)
[GCC 5.4.0 20160609]
/usr/bin/python

nuitka3 --version:
<IP_ADDRESS>
3.7.0 (default, Sep  2 2018, 11:21:38)
[GCC 5.4.0 20160609]
/usr/local/bin/python3.7

python -V: Python 2.7.12
python3 -V AND python3.5 -V: Python 3.5.2
python3.6 -V: Python 3.6.6
python3.7 -V: Python 3.7.0
My gcc version: gcc -v returns gcc version 5.4.0 20160609 (Ubuntu 5.4.0-6ubuntu1~16.04.10)
My platform is Linux Mint 18.1 Serena: cat /etc/linuxmint/info
RELEASE=18.1
CODENAME=serena
EDITION="Cinnamon 64-bit"
DESCRIPTION="Linux Mint 18.1 Serena"
DESKTOP=Gnome
TOOLKIT=GTK
NEW_FEATURES_URL=http://www.linuxmint.com/rel_serena_cinnamon_whatsnew.php
RELEASE_NOTES_URL=http://www.linuxmint.com/rel_serena_cinnamon.php
USER_GUIDE_URL=help:linuxmint
GRUB_TITLE=Linux Mint 18.1 Cinnamon 64-bit

I attempted to follow the instructions provided at the downloads page for Debian/Ubuntu. My $CODENAME was serena (lsb_release -c -s), however, which didn't appear in the index. I figured that since the package base of Serena was Xenial, Xenial could be used as a substitute. In addition, I also installed Nuitka via pip (python3 -m pip install nuitka).
I have an example program that looks like:
"""Runs the primary application."""
import sys
print("Hello.", sys.version)

I try to compile it with nuitka3 --recurse-all --output-dir=build source/test.py && ./build/test.exe and it worked; it compiled and was successfully run. However, it was using Python 3.5, which is not wanted. I want it to use Python 3.7. Curiously, after a restart, the command no longer works; I don't know why. However, python3.5 -m nuitka --recurse-all --output-dir=build source/test.py && ./build/test.exe seems to bring the same result as from before the restart.
I tried doing python3.5 -m nuitka --recurse-all --python-version=3.7 --output-dir=build source/test.py && ./build/test.exe. This brings a weird error:
Traceback (most recent call last):
  File "/usr/lib/python3/dist-packages/nuitka/__main__.py", line 218, in <module>
    main()
  File "/usr/lib/python3/dist-packages/nuitka/__main__.py", line 60, in main
    from nuitka import Options                  # isort:skip
ModuleNotFoundError: No module named 'nuitka'

I tried running python3.7 -m nuitka --recurse-all --python-version=3.7 --output-dir=build source/test.py as well. This produced a 2960-line-long error log, so I put it on pastebin.com. Running nuitka3 --recurse-all --python-version=3.7 --output-dir=build source/test.py produced a similar, if not identical, result. Running either with --verbose --debug as well gets this smaller(?) pastebin.
Alternatively, running nuitka --recurse-all --python-version=3.7 --output-dir=build source/test.py produced RuntimeError: Bad magic number in .pyc file.
What should I do?

The "--python-version" parameter is not what you ought to use. It can only work well if Nuitka is not installed to the system and I am going to remove it. It works under too limited circumstances.
I think for you though, the package will have installed Nuitka into a shared spot for all Python3 versions, and "python3.7 -m nuitka" is exactly how it should work.
However, your Python 3.7 fails to link against libpython from what it seems. It works on my Debian testing machine. I am pretty sure that it works if it comes come Debian alikes.
Your Python 3.7 might be a statically linked one, and thus not supported yet. See issue #95 which would deal with that. It was probably not built with "--enable-shared", which Debian normally does, it definitely is not standard part of the release, or is it?
Yours,
Kay

Thanks. I solved the problem. I installed Python 3.7 some time ago, but I compiled it myself and for whatever reason it wasn't installed to /usr/bin/python3.7, but some /usr/local/bin directory. I uninstalled it by reinstalling with checkinstall (which nearly broke Python because when it reinstalled it decided to overwrite Python2.7, and aptitude was telling me to uninstall all the dependent packages), and then uninstalling it with dpkg. Then I reinstalled it the correct way by adding the correct PPA and installing with aptitude instead of compiling it myself.
Running python3.7 -m nuitka --recurse-all --output-dir=build source/test.py now works and gives the correct output:
Hello. 3.7.0 (default, Aug  6 2018, 20:07:46)
[GCC 5.4.0 20160609]

Thanks! I have little experience with git issues and etiquette, but I think this needs to be "closed" or "solved" now.


Problem trying to execute atests

I tried to execute atest windows_tests.robot, but I keep getting
[ ERROR ] Error in file 'C:\Users\User\Desktop\robotframework-imagehorizonlibrary\tests\atest\windows_tests.robot': Importing test library 'ImageHorizo nLibrary' failed: SyntaxError: 'return' with argument inside generator (init.py, line 168)                                                          Traceback (most recent call last):                                                                                File "c:\python27\lib\site-packages\ImageHorizonLibrary_init_.py", line 8, in                                                                  import pyautogui as ag                                                                                File "c:\python27\lib\site-packages\pyautogui_init_.py", line 84, in                                                                           import pyscreeze                                                                                PYTHONPATH:

I found the solution to this problem.
Running outside robot, the error message show that the problem is in the PyScreeze==0.1.20 python lib. Downgrading to 0.1.19 the problem does not happen.
Is possible that the lib pyautogui==0.9.42 should be downgraded too.
--

Tests have been rewritten, please track this PR: https://github.com/eficode/robotframework-imagehorizonlibrary/pull/46

Closing this issue since a) dependencies will be updated in the next release, b) this is pyscreeze issue, not IHL


Added GitHub Actions

First attempt at GitHub Actions simply builds the project with Analytical Astra-Sim on Ubuntu, installs Boost, compiles with cmake, and then executes three sample runs.
No other tests or validation is being done. Correctness of output is not tested, only if things return error codes.

Do we want the clang format tidy to automatically format and then change the commit? I need to look at it for pull requests and how that would work, but for things that get pushed it would just do a push, I believe.

I will consolidate these, since I am continuing to work on it.


is Foo in polymer expression should cause an error message

This issue was originally filed by @zoechi

What steps will clearly show the issue / need for enhancement?
1.
    <template if="{{model is Foo}}">
      {{model.fooSpecificProperty}}
    </template>
    <template if="{{model is Bar}}">
      {{model.barSpecificProperty}}
    </template>
2.
As far as I know Types like Foo/Bar can't be used in expression.
This should produce an error message in the Polymer linter.
3.
What is the current output?
template if evaluates to true in both cases.
What would you like to see instead?
Either is Foo should be supported or cause an error message
What version of the product are you using? On what operating system?
Dart VM version: 1.7.0-edge.40314 (Tue Sep 16 05:31:11 2014) on "linux_x64"
Polymer 0.14.0+1
Please provide any additional information below.
see also http://stackoverflow.com/questions/25878785

This issue has been moved to dart-lang/polymer-dart#302.


Deriche

Deriche filters Implementation

:+1: thank you for the contribution, when all checks pass, do not forget to merge your commit history :)

@StevenPuttemans there is new contribution possible "Detecting step edges in noisy SAR images: a new linear operator  IEEE Transactions on Geoscience and Remote Sensing  (Volume:35 ,  Issue: 1 )  1997". You can try it here https://github.com/LaurentBerger/FilterChoice. Is it interesting?

@LaurentBerger every functionality should have its value in the library. So if you want to add more, go ahead and do so! Just seperate them in 2 pull requests. If one depends on the other, mention so in the designated PR.