Update app icons for NewDot branding

cc @AndrewGable this should be a good head start on getting all of the app icons updated.
Details

Fixed Issues
$ https://github.com/Expensify/Expensify/issues/161805
Tests

QA Steps

Tested On

[x] Web
[x] Mobile Web
[x] Desktop
[x] iOS
[ ] Android

Screenshots
Web

Mobile Web

Desktop

iOS

Android

Hey @shawnborton, I see this is a [WIP]. Are you wanting to add more icons?

Hey @Luke9389 - thanks for the speedy review! I'm mostly just curious for Andrew's input on what to do for app store descriptions, etc. Stay tuned - we'll let you know if there are more changes coming.

The app store pulls the app icon for some of the listing and then the other part of the listing I have to go and upload manually myself (similar to the app store screenshots)

Okay cool, I think that means we're all good here then.

Hmm I am having a hard time getting the iOS app up and running for testing. Seeing this:
The following build commands failed:
        CompileC /Users/shawnborton/Library/Developer/Xcode/DerivedData/ExpensifyCash-hfttzailbkhegigkkorhlarxjpit/Build/Intermediates.noindex/Pods.build/Debug-iphonesimulator/Flipper-Folly.build/Objects-normal/x86_64/DistributedMutex.o /Users/shawnborton/Expensify/Expensify.cash/ios/Pods/Flipper-Folly/folly/synchronization/DistributedMutex.cpp normal x86_64 c++ com.apple.compilers.llvm.clang.1_0.compiler
(1 failure)

Is someone able to help me test?

Have you pulled from master and then reinstalled Pods  (cd iOS && rm -rf ./Pods && pod install && cd ..)? That's usually my go-to

Still getting the same error :( going to post in Slack and see if anyone has any ideas.

Oh also doing the same thing with node_modules can be helpful. Total shot in the dark though

Sure, I'll give it a spin 👍

The icons are looking good but my emulator has been stuck on the loading screen (second pick) for a few mins now. Not seeing any errors in the Metro console though. @AndrewGable have you seen this before?

Adding a quick hold to this until some discussion about the timing of this is sorted out.

Closing this one as we are no longer going to use this new icon.

Ok to reopen as part of N6?

I think it's okay to reopen, but perhaps @Luke9389 or someone can help clean this up and take it over the finish line for me?

Hey @shawnborton, happy to pick this up.
So @AndrewGable you mentioned above that you'll need to manually upload this icon to the app store. When should that happen? Do you want to coordinate with me so that this PR gets deployed and the icons get updated at the same time? I can ping you when this is ready for merge.
My game plan for this PR is to clean up the merge conflicts and test on all the platforms.

Good question, I'm not entirely sure the best way to time things but I know we will be changing the name of the app as well, which causes us to push to the app store for this newsletter launch. For more context: https://github.com/Expensify/Expensify/issues/170114

@Luke9389 - Feel free to change/merge any icons, names, colors, etc all in this PR. We will update the assets (including new icons) in the issue @shawnborton linked 👉 https://github.com/Expensify/Expensify/issues/170114 when we publish the app to the "live" store which requires a mobile deployer to configure the release.

OK, I've tested this on all platforms. Gonna assign pullerbear to get this merged.

somehow double-dipped on pullerbear 😬

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

🚀 Deployed to staging         in version: 1.0.77-6🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
failure ❌

🕸 web 🕸
success ✅

UI looks different in landing page of  e.cash app
Expected Result:
The start/login page .cash should be same as shown in PR
Actual Result:
UI looks different for start/login page .cash
Actions Performed:

Launch App
Verify the icons and page

Platform:
iOS ✔
mWeb
Android
Build:
1.0.78-0
Notes/Images/Video:

Title:
PR2635 - UI looks different for start page .cash
Expected Result:
The start/login  page .cash should be same as shown in PR2635
Actual Result:
UI looks different for start/login  page .cash
Action Performed:

Launch App

Workaround:
Unknown
Platform:
Where is this issue occurring?
Web
iOS ✔
Android
Desktop App
Mobile Web
Version Number: 1.0.78-0

We recently merged a PR that changed the formatting of the log in page, so everything should be good here.

🚀 Deployed to production         in version: 1.0.79-4🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


Request: Add arguments to affect the "strictness" in determining the DB difference between "silent" / audible content

Is your feature request related to a problem? Please describe.
The videos I am attempting to edit do have some low-volume background music and sound effects that are significantly quieter than my voice/commentary.  This tool generally does a good job of distinguishing them but if the background music spikes slightly in volume (louder, but still nowhere near as loud as my voice) the fast forward will briefly stop during the mini-spike.
Describe the solution you'd like
I'd like to be able to specify an argument that affects the "silence" determination, where not specifying an argument uses the current default behavior and specifying a value makes the silence determination more or less strict based on the average volume of the entire file.
Other solutions
I could specify the exact dB threshold I'd like to use for "silent" vs. "audible" content, but I could see that ending up buggier than specifying a "strictness" variable, where a strictness of 5 = the default behavior (no arguments).
Additional context
I could share sample pre- & post-processed files showing points where small spikes in the background music that are much quieter than my commentary are treated as "audible" when I'd prefer them to be treated as "silent"; let me know the best way to share these!

Hey, I think there already are 2 arguments that can achieve the same thing:
 parser.add_argument("-sl", "--silence-level", type=float, default=-35,
                        help="Minimum volume in decibel to be classified as audible")
 parser.add_argument("-stt", "--silence-time-threshold", type=float, default=0.5,
                        help="Resolution of the silence detection (seconds)")

If your background music is louder than the threshold specified in --silence-level (default -35db), it is classified as "audible" eventhough there is no voice. You could try increasing this volume to e.g. -30 or -25 db, that should solve it.
The other parameter, --silence-time-threshold, is used to specifiy the minimal length an audible interval has to be in order to be classified as audible, so small spikes should be filtered out (by default these spikes can be up to 0.5 s long to be filtered out, but you can easily increase this value by passing the parameter to unsilence)

Thanks again for your help on this one -- I'll take a look and possibly close this later today, but it sounds like you're describing exactly what I need.
I just now saw the "for many more settings, type -h or -help" in the readme; I assumed the example arguments in the command line usage section represented the only arguments. Is there any chance a linked with a list of arguments and their explanations could be added to the Readme? Might help block future frivolous feature requests 😂

Sure, I could add a table of arguments. If you want, you could start doing so and do a pr to this repo.

I confirmed that the -sl and -stt arguments solved my use case. Thank you so much for your help!


Pass an error instance to the error listener

Right now the error listener is invoked with a string.
It is usually expected to receive an error instance in the error listener.

Nice nice :)


clearFirestoreData isn't deleting subcollections

is it possible to remove and export sub collections, the collection in config file are
{"collection": "users", "doc": "UID_VARIABLE"} but a sub collection of the user users/uid/likes will not delete. Also think if you delete the user information subcollection have to be checked if exists delete them

I am having the same issues

Uploading GITHUB-20230922-GitHubDataProtectionAgreement (1).pdf…


Add support for markdown files

In case of .md file, use pandoc instead of ogmarkup

Added in efee12e6a071669836249872f0ece98985366f00


Should merge the AWS_SECRET_ACCESS_KEY and AWS_ACCESS_KEY_ID into the script

The AWS_SECRET_ACCESS_KEY and AWS_ACCESS_KEY_ID are specified in the credentials.template file as duplicates of the TF_VAR_* equivalents. They are used for the aws cli login credentials. Having to duplicate entries in the credentials file is not a good customer experience, we should merge these into the scripts which use the aws cli by passing the TF_VAR variables to those scripts and setting the environment variables only for those scripts.

Updated launch script to append  the environment AWS_SECRET_ACCESS_KEY and AWS_ACCESS_KEY_ID  variables to the ENV_VARS based on the TF_Var equivalents.


[Bug] 🐛 Align image and text/CTA

EXPECTED BEHAVIOUR: text or button shows the opposite side of the image
CURRENT BEHAVIOUR: text shows underneath, the side is blank

Example current behaviour:

Example expected behaviour:

@George-Cleal  I can see the texts are opposite to the images in the current application , can we close this?


getTextContent() text items have wrong height

pdfJS Version: 1.7.290
nodeJS Version: v6.9.3
Test PDF file: test.pdf
TL;DR: textContent.height is way off compared to rendered PDF, I'm not sure if this is a bug, an invalid PDF file or if this is intended behaviour.
One some PDF files (see attached file for example) the textContent items seem to have a wrong value for the 'height' property.
Consider the following example, which is the text 'Uw rekening' just below the top-right logo:
{
  "str": "Uw rekening",
  "dir": "ltr",
  "width": 98.928,
  "height": 0.54,
  "transform": [
    18,
    0,
    0,
    18,
    441.81,
<PHONE_NUMBER>999999
  ],
  "fontName": "g_d9_f21"
}

Here the 'height' property value is 0.54, whilst Math.sqrt(t[2]*t[2] + t[3]*t[3]) = 18 is expected.
When looking at the rendered PDF, we can also confirm that the text in question is actually rendered as 18px high.
I traced the code backwards in the PDFJS source, this is what I found:
In flushTextContentItem(), the height is 18, but then multiplied with textContentItem.textAdvanceScale, which has a value of 0.03 for the attached PDF.
If we look at ensureTextContentItem(), we see that textAdvanceScale is calculated as follows:
textAdvanceScale = Math.sqrt(ctm[0]*ctm[0] + ctm[1]+ctm[1]) * Math.sqrt(tlm[0]*tlm[0] + tml[1]*tlm[1])

Where ctm is the content transform matrix, and tlm the text line matrix.
The text line matrix looks just fine, but (in case of this PDF example), the ctm seems very unlikely:
[
  0.03,
  0,
  0,
  0.03,
  0,
  0
]

Eventually I found that a cm operator is encountered with args [0.03, 0, 0, 0.03, 0, 0], which is then handled in preprocessCommand() and triggers stateManager.transform(args), where the ctm is updated to [0.03, 0, 0, 0.03, 0, 0].
But this is where my debugger threw in the towel as it crashes when trying to navigate through the massive 57k LOC PDFJS library.
When inspecting the PDF, I find this part:
q
0.03 0 0 0.03 0 0 cm
BT
/F9 600.00 Tf
0.89 0.00 0.10 rg
14727 23615 TD
(Uw rekening) Tj
*snip*
ET Q

So yes, the graphic static is modified right before the text portion, but that's about where my knowledge of the PDF format ends. I don't know if the 'graphic state' is supposed to influence text size?
So, in conclusion: I don't know if this is a bug, an invalid PDF document or an intended behaviour. But I do know that height 0.54 is not how the document is actually rendered.
To get the actual rendered height of a text item, can I safely assume that the 'real' height is equal to Math.sqrt(t[2]*t[2] + t[3]*t[3]) ?

Looks like this may be a regression from #7879

Same deal here using pdfjs-dist 1.8.412
Heights are greatly exaggerated:
{ str: 'Y',
  dir: 'ltr',
  width: 4.335500000000001,
  height: 42.25,
  transform: [ 0, 6.5, -6.5, 0, 488.4, 611.8 ],
  fontName: 'Helvetica' }

For a single "Y" at a 6.5pt font, I would expect this to be near 6.5pt in height, not multiplied by 6.5.

If it helps, this worked correctly in 1.6.210, which I have reverted back to.

@LeonMelis @Saltallica @chadkirby If you don't mind sharing, what are you using getTextContent for? I've recently been thinking about cleaning up a few things, but don't want to remove things people are using.

@brendandahl In a nutshell, I am trying to draw rectangles around certain paragraphs. I search through each page for target strings, then when I find the target, I need to compute the paragraph's bounding box so that I can annotate that portion of the page.

I use it to extract text from a document, with coordinates and dimensions of the textboxes. This allows me to parse documents and extract relevant data. I'm also using it to draw rectangles around certain text elements (highlighting them), like chadkirby does.

I am working with version 1.8.418 and also getting heights that are greatly exaggerated.In my document i get height of 144 instead of  what i expected is  about 20 . The function getTextContent returns wrong  height value . Any solution beside changing version to 1.6.210 ??

I use getTextContent to extract the text and map text items to groups roughly representing paragraphs. Our company uses this to prepare documents for localization/translation.

This is still a problem in 1.10.97.  And like other - I'm using PDF.js not just as a viewer, but as a way to extract data by getting text boxes from certain areas of a document - without having accurate heights it doesn't work.

Also... is there a way we can get someone to look in to this particular issue?

If it worked in 1.6.210, you could try using git bisect to find out the commit where it regressed if it's indeed a regression. That would help to speed up the resolution process.

I have the same problem but i get height: 195.4404 it should be something somewhere between 12 and 15 (i guess).
I use pdfjs to index a pdf, and then open the pdf with pdfjs with the correct page and y coordinate.
I'm using pdfjs-dist: 1.9.638, upgrading to 2.0.943 did not help, i also tried to revert back to 1.6.210 but that did not solve my issue. (it might be a faulty pdf, but it renders correctly in all pdfs readers i have tried including pdfjs).
Is there some other way i can calculate the top position? i'm currently using item.transform[5] + item.height.
2008-005.pdf

I found problem in commit https://github.com/mozilla/pdf.js/commit/4537590033169915e68f6480e2463bc4b2175f78
before this commit height multiply to textAdvanceScale only for vertical fonts
after multiply in any cases


Schema migration claims to have failed

The schema migration script shows an error, and no error messages. Apparently, Directus returns a 204, and this is interpreted as non-successful. Is this correct behavior? It seems like the schema was applied correctly, so I would expect the script output to reflect that.
We are using Directus 10.1.1
Command:
directus-migrator -s dev -t staging --schema

Output:
2023-05-24 info: Migrating Schema Started
2023-05-24 info: response status: 200
2023-05-24 info: Schema Migration Snapshot Successful
2023-05-24 info: response status: 200
2023-05-24 info: Schema Migration Diff Successful
2023-05-24 info: response status: 204
2023-05-24 error: Schema Migration Failed

I believe this has been fixed in my most recent patch.

I believe this has been fixed in my most recent patch.


[Bug]: CI failure, API rate limit exceeded

Is there an existing issue for this?

[X] I have searched the existing issues

Current Behavior
Sometimes CI fails with the following error
API rate limit exceeded for <IP_ADDRESS>. (But here's the good news: Authenticated requests get a higher rate limit. Check out the documentation for more details.)

It could be easily solved just by re-running CI pipeline.
Expected Behavior
No response
What operating system are you seeing the problem on?
Other (specify in Anything else section)
What browsers are you seeing the problem on?
Not Applicable
Relevant log output
Run earthly/actions-setup@v1
  with:
    version: latest
    prerelease: false
    use-cache: true
Configured range: latest; allow prerelease: false
Error: API rate limit exceeded for <IP_ADDRESS>. (But here's the good news: Authenticated requests get a higher rate limit. Check out the documentation for more details.)

### Anything else?

Failed job link:
https://github.com/input-output-hk/catalyst-ci/actions/runs/6911060366/job/18805130579

### Code of Conduct

- [X] I agree to follow this project's Code of Conduct

The long-term solution is to introduce a pass-through image cache which will work around the rate limiting. In the short term, it's been on my list to add automatic retries, and that will help alleviate the need to manually rerun the failed jobs.


fix: correct operator precedence!

Now both (j < (umubare_wimibare - i - 1)) and (j < umubare_wimibare - i - 1) will work

Fixes #54


Replace sklearn by scikit-learn

What does this PR do?
The sklearn package on PyPI is an historical thing and will start failing from December 1st 2022, see https://github.com/scikit-learn/sklearn-pypi-package for more details.
Before submitting
I checked the first one as this seems the one more applicable here:

[x] This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
[ ] Did you make sure to update the documentation with your changes?
[ ] Did you write any new necessary tests?

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.

The CI failure can be seen in the main branch e.g. https://github.com/huggingface/optimum/actions/runs/3532632818/jobs/5927225408, so this does not seem related to this PR.

LGTM, thank you for the fix!
@JingyaHuang Is examples/onnxruntime/training/docker/conda/requirements.yml used anywhere?

@fxmarty These dockerfiles are outdated, I will remove them.


"Fix" for jasmine-node "hang"

Regarding https://github.com/mhevery/jasmine-node/issues/71 , I've added a --forceexit flag.  Would be awesome if you'd consider pulling this back into the main sources.
--forceexit will do a process.exit() after all tests finish, even if there are still outstanding timeouts / whatever that are keeping the node event loop alive.

+1

Thanks for the fix!


Attachment Handler

A middle ware handler to parse the form-data based on the header and put the content into an attachment. It is an optional handler that you can wire into your handler chain for a specific endpoint.

Will take a look

This is being addressed in: https://github.com/networknt/light-4j/pull/329

@thirtysixmm It is scheduled to be released this weekend.
https://trello.com/b/189msq9S/release-schedule


MongoDB client is not disconnected on shutdown

Thanks @rogermadjos, that's definitely an oversight on my part.  Do you want to take a crack at a fix?  Otherwise, I will try to get to is sometime over the weekend


SASL GSSAPI bind was not being completed.

Apologies but I realized that I broke the GSSAPI login when cleaning up the code for the patch.  I do not have a reliable general way to test GSSAPI connections.  The test I have does not catch incomplete binds.  I will need to give some thought to a better test for this.   I have tried the SASL patch now in a real application with GSSAPI and it does appear to be working correctly with this patch.

I have no way to test either, so I'm leaving it all up to you :)


Fix the musl build

It was failing due to GC collecting functions we want to expose to the linker.
@Anton-4, this should fix the musl build while still enable a small binary with garbage collection.  So we have to explicitly protect them.
When we eventually have effect interpreters, this should all go away and become a simple switch statement that uses the functions. This will stop them from getting GCed in general. (hmm, may still need it for roc_alloc and friends)

If we were to add a new roc_fx function and we forgot to add it to this list would we get an error at build time?

Sadly no. The musl build will just silently not include the symbol....it is quite inconvenient.


Create action to display test results on Github | test

Nice errors:

@jcwchen could you take a look? Thanks!

After approval I will revert the test changes


Unable to use ProfilingSummary to interpret Timeline summary with profiling data

https://github.com/flutter/flutter/issues/58803 has added the interpretation of timeline summary and we should be able to fetch CPU, GPU, Memory measurements from it.
Per it requires, firstly I need to filter timeline summary by category flutter::profiling,  but I end up getting nothing with this condition. In local debugging, I printed all the trace events, and I found profiling data appearing there. The category is embedder instead.
In trace_event.cc, I notice category was not picked up when generating trace event to the Dart land. I guess that's where flutter::profiling was dropped.
@iskakaushik

Triage: Is this something you are working on right now? If so, can you assign a priority and a customer label? Thanks.

@rmacnak-google , currently we generate all our profiling events through Dart_TimelineEvent, would it be feasible to have an api in dart that lets an embedder specify a category? This will let us develop tooling based on categories of events. If you think that is a reasonable request, I'm happy to file an issue in the dart repo.

I believe the timeline machinery requires the set of categories to be a VM-build-time constant. Separate from the VM's own reasons, IIRC the underlying APIs for macOS and Fuchsia tracing require static strings for categories (so they don't need to copy).

Thanks @rmacnak-google. @AlbertWang0116 given this, i'll tweak the driver to filter by the event names rather than the categories. Should be a reasonable workaround.


Update bugbug to 0.0.4

You'll need to:
pip3 uninstall en-core-web-sm

Before reinstalling dependencies.


Move redis out of api dependencies list

What would you like to be added:
Currently, redis is counted as web_api and piped_api dependency but we should move it out of those API dependencies list to keep the API logic flexible.
ref:
https://github.com/pipe-cd/pipecd/blob/master/pkg/app/server/grpcapi/web_api.go#L72
https://github.com/pipe-cd/pipecd/blob/master/pkg/app/server/grpcapi/piped_api.go#L65
Why is this needed:

/assign @Hosshii


  NLA is checked on remote pc.  You can log in.  pull hair out. wash rinse repeat.  Please tell us what we need to do for this scenario that applies to majority of small businesses.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 5581a04a-e204-4a19-3eba-0852d2eb5d8e
Version Independent ID: 820c77b6-2182-7e92-bbe6-0819f727d207
Content: Remote Desktop clients FAQ
Content Source: WindowsServerDocs/remote/remote-desktop-services/clients/remote-desktop-client-faq.md
Service: unspecified
GitHub Login: @lizap
Microsoft Alias: elizapo

Troubleshooting issue, likely outdated too (page has been updated quite a lot since this ticket).

#please-close


refactor(gateway): use mock to test skip_validate

This change is

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 82.01%. Comparing base (088ce7f) to head (69a8034).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #524      +/-   ##
==========================================
- Coverage   82.61%   82.01%   -0.61%
==========================================
  Files          39       43       +4
  Lines        1789     1890     +101
  Branches     1789     1890     +101
==========================================
+ Hits         1478     1550      +72
- Misses        237      255      +18
- Partials       74       85      +11

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Opened the PR in the mono-repo: https://github.com/starkware-libs/sequencer/pull/131


docker-py package breaks using docker-compose

Issue Type

Bug report

Molecule and Ansible details

Molecule installation method: One of source, pip
pip
Ansible installation method: One of source, pip, OS package
os package

Desired Behaviour
I can use docker-compose and molecule on the same machine
Actual Behaviour (Bug report only)
Installing docker-py conflicts with the new package docker
Traceback (most recent call last):
  File "/bin/docker-compose", line 7, in <module>
    from compose.cli.main import main
  File "/usr/lib/python2.7/site-packages/compose/cli/main.py", line 20, in <module>
    from ..bundle import get_image_digests
  File "/usr/lib/python2.7/site-packages/compose/bundle.py", line 13, in <module>
    from .network import get_network_defs_for_service
  File "/usr/lib/python2.7/site-packages/compose/network.py", line 7, in <module>
    from docker.types import IPAMConfig
ImportError: cannot import name IPAMConfig

See:
https://github.com/docker/compose/issues/4401
https://github.com/docker/docker-py/issues/1431
docker-py appears to be obsoleted and docker is the new pip package

Docker changed the name of the Docker Python SDK to just docker when they bumped to version 2. The last docker-py version is 1.10.6.  Molecule is only capable of using docker-py due to changes that have been to the API in v2. AFAIK we won't be supporting the v2 docker b/c molecule is going to transition to using the Ansible implementation of Docker.
As you've discovered you can't have both docker-py and docker installed which is by design by Docker.

Thinking about this more... in order to use docker-compose and molecule together you will likely need to install docker-compose via a method other than pip. On a Mac or Windows machine docker-compose comes with the installation of Docker Engine. You can also pull down the docker-compose binary by itself via a curl command documented here... https://docs.docker.com/compose/install/

AFAIK we won't be supporting the v2 docker b/c molecule is going to transition to using the Ansible implementation of Docker.

Also, these docker_ modules require docker-py, so I probably wont be spending effort porting Molecule to the docker pip package.

Thinking about this more... in order to use docker-compose and molecule together you will likely need to install docker-compose via a method other than pip. On a Mac or Windows machine docker-compose comes with the installation of Docker Engine. You can also pull down the docker-compose binary by itself via a curl command documented here... https://docs.docker.com/compose/install/

Good point as well.  I can run Molecule and the entire docker toolchain, since I have installed docker using the Docker installer.  Not through pip.

Won't be moving to docker anytime soon.  See workarounds above.

In case anyone is interested ansible devel branch supports both docker-py and docker
Here is the commit that introduced support:
https://github.com/ansible/ansible/commit/e2a1ce2916e9b87fe1ad4a1011c04ef8d2faf046

@abtreece @retr0h The workaround of installing the compose binary from somewhere other than pip no longer works.
docker-compose has added a check to see if docker-py exists and fails fast with:
ERROR: Dependency conflict: an older version of the 'docker-py' package is polluting the namespace. Run the following command to remedy the issue:
pip uninstall docker docker-py; pip install docker

Is there another workaround?

Is there another workaround?

Run molecule in a virtualenv?  Since the bug report is about running docker-compose and molecule on the same system, you simply need to run molecule in a venv.

@kireledan Would you be interested in porting Molecule to the new docker package vs docker-py?

Sure. I'll take a look


Pull request with type [CREATE] for user [anthonylamark] and object type [ConsoleExtension] - titled [Removable Media Security (secRMM) ConfigMgr console extension]

Automated pull request from the Endpoint Configuration Manager Community hub.

Hi Microsoft.  Could I trouble someone else to review/approve this pull request?  Thank you very much


Microsoft Defender

When I attempt to download JwlMediaWinSetup Microsoft Defender intercepts it stating it contains a Trojan:MSIL/Masslogger.VN!MTB.
I know I could bypass it don't know if it's a false positive or not.
Terry

@mobiletrainer1 please see #19 and #20

Sorry about that. I'm new to github. I didn't know to look at the closed comments. Keep up the good work, brother.

@mobiletrainer1 no problem. Thanks for the report


fix: updating references to Identus

Description:
https://input-output.atlassian.net/browse/ATL-6470
Some visible and non-functional wording updates to Identus.
Checklist:

[ ] My PR follows the contribution guidelines of this project
[ ] My PR is free of third-party dependencies that don't comply with the Allowlist
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] I have checked the PR title to follow the conventional commit specification

@essbante-io can u please validate?


Add unittest to check JSON resource formats

This PR proposes to add a unittest to check for malformed JSON resources.
The goal is to ensure valid JSON resources, even though ST might forgive some format errors.
The great test itself was created by @facelessuser. I merged his two files used in mdpopups to get one test_json.py out of it.

The maintainers of this repo require that all pull request submitters agree and adhere to the following:

[x] I have read and agree to the contribution guidelines.
(required)
[ ] All related documentation has been updated to reflect the changes made. (required)
[x] My commit messages are cleaned up and ready to merge. (required)

The maintainers of this repository require you to select the semantic version type that
the changes in this pull request represent.  Please select one of the following:

[ ]  major
[ ]  minor
[x]  patch
[ ]  documentation only

Can you squash the 3. commit into the first one?
Then I will merge

Done.

Ops, I see that I could have been misunderstood.
What I meant was
Can you squash the 3th commit into the 1st commit, so we will have two commits?
Sorry
Can you fix that? You can use reflog and go to the state before the squash.

Wait. Fixup! was wrong commit.

Now it should be ok


update tago.io links in python documentation

replace tago.elevio.help by docs.tago.io

Thank's @jeovanevs.
Also I would like to invite to check out our new python sdk (still in construction some parts). https://github.com/tago-io/sdk-python


Add arm: and intel: arguments to cask sha256 stanza

As discussed in https://github.com/Homebrew/homebrew-cask-versions/pull/14494#discussion_r945865830, this PR adds arm: and intel: names arguments to the cask sha256 stanza. This will allow us to simplify the common pattern where sha256 stanzas are the only elements inside on_intel and on_arm blocks.
For example, instead of this:
cask "foo" do
  arch arm: "arm", intel: "intel"

  version "1.2.3"

  on_intel do
    sha256 "21d28f0bfd4129a5e394990e981ad79d27c4613f3da9f171417c17af785ebcba"
  end
  on_arm do
    sha256 "1b6bdf86fee03525b1978b4312624bcc522796bbf5675f370797c5f21e189e5d"
  end
end

We can do:
cask "foo" do
  arch arm: "arm", intel: "intel"

  version "1.2.3"
  sha256 arm:   "1b6bdf86fee03525b1978b4312624bcc522796bbf5675f370797c5f21e189e5d",
         intel: "21d28f0bfd4129a5e394990e981ad79d27c4613f3da9f171417c17af785ebcba"
end

Review period skipped due to critical label.


Circumvent "Open Download" pop-up

Would it be possible to create an option that allows for the downloaded file to be opened on the double click, thus circumventing the need to also click the pop-up prompt "Open Download"?

This isn't possible, that prompt is there because of Firefox's security restrictions. If they ever implement a toolbar API then I can probably get rid of it.


Bulk edit, batch 3 of today's validation fixes for column headers.

Docs Build status updates of commit f136863:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/web-service-reference/creationtime.md
:white_check_mark:Succeeded
View

docs/web-service-reference/getfederationinformationrequest-soap.md
:white_check_mark:Succeeded
View

docs/web-service-reference/getfolder.md
:white_check_mark:Succeeded
View

docs/web-service-reference/globalhasattachments.md
:white_check_mark:Succeeded
View

docs/web-service-reference/instancekey.md
:white_check_mark:Succeeded
View

docs/web-service-reference/mailbox-availability.md
:white_check_mark:Succeeded
View

docs/web-service-reference/maximumnonworkhourresultsbyday.md
:white_check_mark:Succeeded
View

docs/web-service-reference/missedcallnotificationenabled-um-web-service.md
:white_check_mark:Succeeded
View

docs/web-service-reference/noendrecurrence.md
:white_check_mark:Succeeded
View

docs/web-service-reference/notesfolderpermissionlevel.md
:white_check_mark:Succeeded
View

docs/web-service-reference/outlookruleblobexists.md
:white_check_mark:Succeeded
View

docs/web-service-reference/pageitemcount.md
:white_check_mark:Succeeded
View

docs/web-service-reference/performreminderaction.md
:white_check_mark:Succeeded
View

docs/web-service-reference/permissionlevel.md
:white_check_mark:Succeeded
View

docs/web-service-reference/previoushopserver.md
:white_check_mark:Succeeded
View

docs/web-service-reference/recurringmasteritemid.md
:white_check_mark:Succeeded
View

docs/web-service-reference/removecontactfromimlistresponse.md
:white_check_mark:Succeeded
View

docs/web-service-reference/requestedextensionids.md
:white_check_mark:Succeeded
View

docs/web-service-reference/requestserverversion.md
:white_check_mark:Succeeded
View

docs/web-service-reference/resetpin-um-web-service.md
:white_check_mark:Succeeded
View

docs/web-service-reference/resources.md
:white_check_mark:Succeeded
View

docs/web-service-reference/response-getorganizationrelationshipsoap.md
:white_check_mark:Succeeded
View

docs/web-service-reference/responsecode-invalidrecipientresponsecodetype.md
:white_check_mark:Succeeded
View

docs/web-service-reference/setruleoperation.md
:white_check_mark:Succeeded
View

docs/web-service-reference/standardtime.md
:white_check_mark:Succeeded
View

docs/web-service-reference/targetapplicationuri-soap.md
:white_check_mark:Succeeded
View

docs/web-service-reference/timezonedefinition.md
:white_check_mark:Succeeded
View

docs/web-service-reference/tokentype.md
:white_check_mark:Succeeded
View

docs/web-service-reference/updatedelegateresponse.md
:white_check_mark:Succeeded
View

docs/web-service-reference/yomifirstname.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

@lindalu-MSFT, Please review and thanks. : )


Update GitHub Action Versions

GitHub Actions Version Updates

codecov/codecov-action published a new release v5.0.7 on 2024-11-21T12:28:45Z

@malik-irain could you check this update in version is fine?


WFLY-10158 upgrade eclipse.yasson to 1.0.1 to address failure while unmarshalling protected constructor

Thanks for submitting your Pull Request!
Please make sure your PR meets the following requirements:

[ ] Pull Request title is properly formatted: [WFLY-XYZ] Subject or WFLY-XYZ Subject
[ ] Pull Request contains link to the JIRA issue(s)
[ ] Pull Request contains description of the issue(s)
[ ] Pull Request does not include fixes for issues other than the main ticket
[ ] Attached commits represent units of work and are properly formatted

For bigger changes, major and minor component upgrades make sure your PR also meets following requirements:

[ ] Pull Request requires a change to the documentation
[ ] Documentation have been updated accordingly
[ ] Tests were added to cover changes

For new features ensure as well:

[ ] Analysis was done
[ ] Test Plan has been done
[ ] Tests were verified in advance

If you are not an active contributor of the WildFly project you can request sponsorship by one of the members to help guide you through the process.

@asoldano Please approve. The only use of this I see is:
feature-pack/src/main/resources/modules/system/layers/base/org/jboss/resteasy/resteasy-json-binding-provider/main/module.xml:


winpr: fix unitary test when CreateProcess is CreateProcessW

As the second argument of CreateProcessW is modified to split with spaces and so this can not be a const arg.

Changes done


add new api methods captureAll and getProperties

Tested on a Mac

You can probably close this one now since the other PR included the methods


calico-node not ready after node reboot with WireGuard enabled

With WireGuard enabled calico-node pod fails to start after node reboot. Readiness probe fails with the following message: calico/node is not ready: felix is not ready: readiness probe reporting 503.
Expected Behavior
Calico-node pod should start normally after node reboot even with Wireguard enabled.
Current Behavior
Calico-node pod fails to start after node reboot. After deactivating Wireguard again pod gets ready immediately. This only happens when there is no calico-typha pod running on the same node. Otherwise pod starts normally even with Wireguard enabled.
Possible Solution
Steps to Reproduce (for bugs)

Activate Wireguard as described here: https://docs.projectcalico.org/security/encrypt-cluster-pod-traffic
Reboot node

Context
Trying to encrypt in-cluster pod traffic
Your Environment
Azure AKS
Kubernetes version: v1.21.2
Node image: AKSUbuntu-1804gen2containerd-2021.11.06
Calico version: v3.20.0

This sounds like it might be a problem with calico/node being able to access Typha in some way - perhaps due to the way wireguard is configured.
@mikestephen could you help diagnose this one? What sort of diagnostics should we look for?

Hi @Cloud5000 , do you see anything suspicious in the calico-node logs?
I'll try and reproduce this issue in the next day or two.

[INFO][471] tunnel-ip-allocator/discovery.go 163: Found ready Typha addresses. addrs=[]string{"xx.xx.xx.xx:5473", "xx.xx.xx.35:5473", "xx.xx.xx.82:5473"}
[INFO][471] tunnel-ip-allocator/discovery.go 166: Chose Typha to connect to. choice="xx.xx.xx.82:5473"
[INFO][471] tunnel-ip-allocator/startsyncerclient.go 56: Connecting to Typha. addr="xx.xx.xx.82:5473"
[INFO][471] tunnel-ip-allocator/sync_client.go 71:  requiringTLS=true
[INFO][471] tunnel-ip-allocator/sync_client.go 200: Starting Typha client
[INFO][471] tunnel-ip-allocator/sync_client.go 71:  requiringTLS=true
...
[INFO][471] tunnel-ip-allocator/sync_client.go 252: Connecting to Typha. address="xx.xx.xx.82:5473" connID=0x0 type="tunnel-ip-allocation"
[WARNING][441] felix/health.go 188: Reporter is not ready. name="int_dataplane"
[INFO][441] felix/health.go 196: Overall health status changed newStatus=&health.HealthReport{Live:true, Ready:false}
[WARNING][441] felix/health.go 154: Health: not ready
[WARNING][441] felix/health.go 188: Reporter is not ready. name="int_dataplane"
[ERROR][441] felix/daemon.go 488: Failed to connect to Typha. Retrying... error=dial tcp xx.xx.xx.35:5473: i/o timeout
[INFO][441] felix/health.go 133: Health of component changed lastReport=health.HealthReport{Live:true, Ready:true} name="felix-startup" newReport=&health.HealthReport{Live:true, Ready:false}
[INFO][441] felix/sync_client.go 200: Starting Typha client
[INFO][441] felix/sync_client.go 71:  requiringTLS=true
...
[INFO][441] felix/sync_client.go 252: Connecting to Typha. address="xx.xx.xx.35:5473" connID=0x0 type=""
[FATAL][471] tunnel-ip-allocator/startsyncerclient.go 73: Failed to connect to Typha error=dial tcp xx.xx.xx.82:5473: i/o timeout

We don't use wireguardHostEncryptionEnabled.
Thanks!

Hey @Cloud5000 , do you use the tigera-operator or are you configuring Calico manually?

Hi @aaaaaaaalex,
we are using managed kubernetes from Azure. We only selected Calico as network policy and did not configure anything manually except for enabling wireguard. But tiger-opeator pod is deployed automatically (by Azure) and running.

Thanks @Cloud5000
With this in mind, it seems likely that Felix cannot communicate with Typha on another node due to the two nodes' WireGuard configurations being out-of-sync with one-another. It's possible that a Felix restart could cause this. We're attempting to reproduce this now and verify that is the cause

I can confirm the exact same behavior with the following configuration:
AWS EKS
Kubernetes v1.20.7-eks-d88609
Node AMI ubuntu-eks/k8s_1.20/images/hvm-ssd/ubuntu-focal-20.04-amd64-server-20211110
Tigera Operator v1.20.1 / Calico v3.20.0
wireguardEnabled: true but wireguardHostEncryptionEnabled not set
restarting the typha instances after a node reboot seems to correct the issue without having to disable wireguard, otherwise calico-node pods will remain in not ready state indefinitely.

@aaaaaaaalex Are there any news on this topic? I am facing the same behavior.
Thx.

Azure AKS
Kubernetes version: v1.21.2
Node image: AKSUbuntu-1804gen2containerd-2021.11.06
Calico version: v3.20.0

Hi all, thanks for your patience!
I've managed to reproduce this issue on both AKS and EKS clusters with calico version v3.20.0, operator version v1.20.1.
From what I can tell, updating the operator patch number resolves the issue.
The latest patch of tigera-operator for calico v3.20.x can be found here. Applying this upgrades calico to version v3.20.3, as-of the time of writing.
Would someone who is experiencing this issue be able to validate that this works?
Thanks

Hi @aaaaaaaalex,
thanks for analyzing. Does anyone know how to force an update of tigera-operator in Azure AKS. Otherwise we have to wait until Azure provides the new version.

Tried on a new cluster with:
AWS EKS
Kubernetes v1.20.7-eks-d88609
Node AMI ubuntu-eks/k8s_1.20/images/hvm-ssd/ubuntu-focal-20.04-amd64-server-20211110
Tigera Operator v1.20.5 / Calico v3.20.3
Still experiencing the same issue when rebooting a node that is not hosting a calico-typha instance.
After reboot, calico-node on rebooted node has event:
Readiness probe failed: calico/node is not ready: felix is not ready: readiness probe reporting 503

And logs show:
2021-12-08 16:32:50.941 [INFO][97] tunnel-ip-allocator/discovery.go 166: Chose Typha to connect to. choice="xxx.xxx.xxx.37:5473"
2021-12-08 16:32:50.941 [INFO][97] tunnel-ip-allocator/startsyncerclient.go 56: Connecting to Typha. addr="xxx.xxx.xxx.37:5473"
...
2021-12-08 16:32:50.941 [INFO][97] tunnel-ip-allocator/sync_client.go 252: Connecting to Typha. address="xxx.xxx.xxx.37:5473" connID=0x0 type="tunnel-ip-allocation"
2021-12-08 16:32:51.082 [ERROR][43] felix/daemon.go 488: Failed to connect to Typha. Retrying... error=dial tcp xxx.xxx.xxx.37:5473: i/o timeout
...
2021-12-08 16:32:57.173 [WARNING][43] felix/health.go 188: Reporter is not ready. name="felix-startup"
2021-12-08 16:32:57.173 [WARNING][43] felix/health.go 188: Reporter is not ready. name="int_dataplane"
2021-12-08 16:32:57.173 [WARNING][43] felix/health.go 154: Health: not ready
2021-12-08 16:33:00.248 [WARNING][43] felix/health.go 188: Reporter is not ready. name="felix-startup"
2021-12-08 16:33:00.248 [WARNING][43] felix/health.go 188: Reporter is not ready. name="int_dataplane"
2021-12-08 16:33:00.941 [FATAL][97] tunnel-ip-allocator/startsyncerclient.go 73: Failed to connect to Typha error=dial tcp xxx.xxx.xxx.37:5473: i/o timeout

Additionally, with Calico v3.20.3 I had to configure with
  wireguardEnabled: true
  wireguardHostEncryptionEnabled: true

as running with
  wireguardEnabled: true
  wireguardHostEncryptionEnabled: false

caused lots of networking issues even before attempting a reboot. (pod to pod communication failed when pods where on different nodes).

:cry: thanks for trying that @artificiosus, not sure why the issue seemed to disappear when I tried it... I'll dig into this some more.


Adding textCapitalization property

Adding textCapitalization property
#77 feature added
Pre-launch Checklist

[x] I read the Contributor Guide and followed the process outlined there for submitting PRs.
[x] I listed at least one issue that this PR fixes in the description above.
[x] I updated/added relevant documentation (doc comments with ///).
[x] I added new tests to check the change I am making, or this PR is [test-exempt].
[x] All existing and new tests are passing using flutter test

If you need help, consider pinging the maintainer @maheshmnj

Thanks for the PR @TomJFox, Can you also add a test? Here's a similar test for your reference
https://github.com/maheshmnj/searchfield/blob/1f5f20de648abe9638a3261f674104f9c28f1e18/test/searchfield_test.dart#L62

@maheshmnj  I have created 2 tests and updated the readme.  Please take a look

Thanks @TomJFox will review it tonight.

@TomJFox see my review comments above

@TomJFox see my review comments above

@maheshmnj I can see the request for a test to be added.  This has been completed.  Was there something else?
Apologies if I missed it, I am new to GitHub.

@TomJFox I have added two review comments above which asks to update the doc comments do you see it?
Heres a screenshot for your reference

You should see a commit suggestion button which you can click to resolve it

Apologies if I missed it, I am new to GitHub.

No problem at all, I have been there and I understand.

@maheshmnj Thanks for the screen shot.  I still don't see those requests, but I have updated the description of the test.  Let me know if anything else is needed.

Sorry My bad I did not submit the review.

Thank you so much for your contribution @TomJFox


Fix problem with headings that use HTML entities

This is to remind me to fix problems with headings that use HTML entities, like this:
https://github.com/google/WebFundamentals/edit/master/src/content/en/updates/posts/2016/07/autoplay.markdown
https://developers.google.com/web/updates/2016/07/autoplay?hl=en

Could you be more explicit about the issue here? Is this a content issue or a problem with the infrastructure?

HTML entities in headings is causing problems (it used to be OK).
For example, on the page linked to above, this is in the Markdown:
title: "Muted autoplay on mobile: say goodbye to <canvas> hacks and animated GIFs!"
This is in the HTML:

Muted autoplay on mobile: say goodbye to <canvas> hacks and animated GIFs!</canvas>

That file points to master, which we're not using any more, we're working from the next-version branch currently.
You'll need to fix it at https://github.com/google/WebFundamentals/blob/next-version/src/content/en/updates/2016/07/autoplay.md
It should have been caught in one of the tests, but looks like it wasn't. Will add a test to make sure it doesn't happen again.

Thanks for the correct source link!
I've done a PR ay #3602.


adds CAE support

related https://github.com/microsoft/kiota/issues/1179
depends on https://github.com/microsoft/kiota-abstractions-dotnet/pull/23

Disabling auto merge as the content stream need to be rewound


D100 should be ignored on test modules (at least with Google convention)

I have:
$ ruff --version
ruff 0.3.4

# pyproject.toml
[tool.ruff.lint.pydocstyle]
convention = "google"

(I wasn't certain how to provide this config with --config <something> --isolated)
$ ruff check  --select D100 tests/
tests/fooutil/fooutil_test.py:1:1: D100 Missing docstring in public module

But the Google style guide says for this case:

Module-level docstrings for test files are not required. They should be included only when there is additional information that can be provided.

So I think D100 shouldn't be generated for test modules by default. I can configure this with per-file-ignores, but perhaps this should be implied by convention = "google".
I'm not sure what pydocstyle's intended behavior was in this case. The pydocstyle hosted docs site isn't loading for me right now. But pydocstyle is fully deprecated (in favor of ruff) and archived, so perhaps there's no value in replicating their behavior.

Perhaps D104 should be disabled for tests as well. The Google style guide does say that packages should have top-level docstrings, and does not call out that this is not required for test packages, but IMHO I can't imagine the authors intended for boilerplate to be required for packages but not for modules.

I like the idea
I think one part that ruff lacks today to implement this is an understanding of what a test-module is, because that depends on your project structure. That's why per-file-ignores is the recommended solution for now.


Stage 2: Trailing commas in function call expressions

https://github.com/jeffmo/es-trailing-function-commas
https://github.com/tc39/tc39-notes/raw/master/es6/2014-09/trailing_comma_proposal.pdf
Also do we already support trailing commas in objects and have tests for that?

Looks like you already did trailing commas for ArrayExpression, ArrayPattern, ObjectExpression, ObjectPattern
                children.skipNonCode();
                if (children.isToken('Punctuator', ',')) {
                    children.moveNext();
                    children.skipNonCode();
                }


[zlib:x64-windows-static] build failure

Host Environment

OS: [Windows]
Compiler: revision

To Reproduce
Steps to reproduce the behavior:
vcpkg install cpr
Failure logs
CMake Error at scripts/cmake/vcpkg_execute_required_process.cmake:127 (message):
Command failed: ninja -v
Working Directory: D:/dev/vcpkg/buildtrees/zlib/x64-windows-static-rel/vcpkg-parallel-configure
Error code: 1
See logs for more information:
D:\dev\vcpkg\buildtrees\zlib\config-x64-windows-static-out.log
Call Stack (most recent call first):
scripts/cmake/vcpkg_configure_cmake.cmake:368 (vcpkg_execute_required_process)
ports/zlib/portfile.cmake:23 (vcpkg_configure_cmake)
scripts/ports.cmake:142 (include)
Additional context
Error: Building package zlib:x64-windows-static failed with: BUILD_FAILED
Please ensure you're using the latest portfiles with .\vcpkg update, then
submit an issue at https://github.com/Microsoft/vcpkg/issues including:
Package: zlib:x64-windows-static
Vcpkg version: 2021-09-10-2059ef11aa6067e6f59b0d939c5d17e3c5c47d3
config-x64-windows-static-out.log

Looks same issue with #7067 (comment), could you try the solution provided in the issue and see if it works?
I looked into my system path variable and couldn't find any paths to anything visual studio related, so i added C:\Program Files (x86)\Windows Kits\10\Lib\10.0.19041.0\ucrt\x64;C:\Program Files (x86)\Microsoft Visual Studio\2019\Community; , rebooted and tried running vcpkg install zlib:x64-windows-static --debug with no success and the same error.
error.txt

reinstalling the windows sdk 10.0.19041.0 has also not changed anything

Are we STILL having issues with zlib? We haven't been able to reproduce this issue locally.
@Sariaki Most probably your environment is broken somehow!

@Sariaki, sorry for the late response, from your failure log, it looks the latest windows sdk version is 10.0.20348.0 in your machine, so reinstalling windows sdk 10.0.19041.0 doesn't work.
Could you install 10.0.20348.0 VS installer and try again? I double confirmed, zlib built successfully with it. Just for curious, why do you install multi windows sdks?
WindowsLibPath=C:\Program Files (x86)\Windows Kits\10\UnionMetadata\10.0.20348.0;C:\Program Files (x86)\Windows Kits\10\References\10.0.20348.0
WindowsSdkBinPath=C:\Program Files (x86)\Windows Kits\10\bin\
WindowsSdkDir=C:\Program Files (x86)\Windows Kits\10\
WindowsSDKLibVersion=10.0.20348.0\
WindowsSdkVerBinPath=C:\Program Files (x86)\Windows Kits\10\bin\10.0.20348.0\
WindowsSDKVersion=10.0.20348.0\

@Sariaki, sorry for the late response, from your failure log, it looks the latest windows sdk version is 10.0.20348.0 in your machine, so reinstalling windows sdk 10.0.19041.0 doesn't work.
Could you install 10.0.20348.0 VS installer and try again? I double confirmed, zlib built successfully with it. Just for curious, why do you install multi windows sdks?
WindowsLibPath=C:\Program Files (x86)\Windows Kits\10\UnionMetadata\10.0.20348.0;C:\Program Files (x86)\Windows Kits\10\References\10.0.20348.0
WindowsSdkBinPath=C:\Program Files (x86)\Windows Kits\10\bin\
WindowsSdkDir=C:\Program Files (x86)\Windows Kits\10\
WindowsSDKLibVersion=10.0.20348.0\
WindowsSdkVerBinPath=C:\Program Files (x86)\Windows Kits\10\bin\10.0.20348.0\
WindowsSDKVersion=10.0.20348.0\

I tried looked into my visual studio installer and it said i only have the windows sdk 10.0.19041.0 installed, installing 10.0.20348.0 didn't change anything.
I'm beginning to suspect that this issue is somehow being caused by me installing and uninstalling visual studio 2022 a while back, since i remember using vcpkg at one point before.

It looks your environment is broken, I suggest you uninstall all windows sdks, and only install the latest windows sdk that provided by VS installer and try again.

this fixed it, thank you!


fix(react): make useAtomSelector rerender components when the selector value becomes undefined

Description
When a non-inline selector goes from a defined value to undefined, useAtomSelector wasn't triggering component rerenders because the skipState ref that we have to use for selector ref swapping with useSyncExternalStore is undefined by default.
Use the special internal destroyed symbol (which is becoming a pretty thorough misnomer at this point and we should rename. Later) as the default value and set the ref back to that after one use.
Also create a test case that reproduces the issue and confirms the fix. We shall not regress.

I wonder if this is related to #83 as well?


The information for play mode remoting is not latest after MR openxr plugin 1.0 released

The information on this page is not latest, such as the "menu" screenshot, or the dialog titles.
The feature now is named as "Holographic Remoting for Play Mode".
@yl-msft

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 96964557-d6ea-4d0f-e3b8-2a4976860590
Version Independent ID: ace2aa93-4c83-bbfa-a063-e5550f60e8be
Content: Unity Play Mode - Mixed Reality
Content Source: mixed-reality-docs/mr-dev-docs/develop/unity/unity-play-mode.md
Product: mixed-reality
Technology: mr-dev
GitHub Login: @keveleigh
Microsoft Alias: kurtie

@thetuvix Were these addressed in your latest update, or was that just the text?

@hferrone they still look out of date. I'll open a PR!


Remove broken indented-code-wrapping

indented-code-wrapping has been disabled for 9 months and probably needs a rewrite/rethink.
No need to keep it around in the readme while we wait.
https://github.com/sindresorhus/refined-github/issues/2729 will stay open.

I hope to see it back. It was useful


rename "Quality of Life Changes" to "QOL Features"

i promise this is the last rename
probably

King of renaming your mods

Personally I think it would be better to name it "Quality of Life Features"

yeah you right

The name doesnt match the manifest tho bc here its "Quality of Life" but in the manifest its "QOL"

Does that mess with the database or something? I was just gonna change the manifest name in the next update. I thought that "name" just changed the display name of the mod in the manager. I haven't changed the uniqueName or anything like that.

no, just the name will change when u download it and thats weird! but ok

don't worry i fix it, thanks


Memory management

I wrote many things to deal with memory, like frames, pages, etc. The frame allocator seems to work and translating a phy address seems to work too. I can get a page, a frame, etc. I think unmapping works too. I can handle page faults (more ore less).
The problem is I have no clue about what to do next. It seems like I need some sort of allocator to build a heap so that I can write kmalloc/kfree and then I am done, but I don't really know how to reuse what I have so far.
The multiboot info contains memory areas, so I should probably use that as well. I actually pass such info to the mmu but...
In the phil'os tutorial, the idea was to remap the kernel. I don't have that, so maybe I should?
I am thinking about restarting from scratch because obviously I cant remember what I did 2 years ago

more or less done, this is still unsafe but it works.


domains does not work on mac

Hi,
I am merrily using the proxy on my prod server (ubuntu 16.04) but the domains I set on my local machine does not get resolved in the browser, eg test.localhost, but resolve fine by IP.
If I do a curl -H "Host: test.localhost" localhost however, outputs the whole website on my terminal.
This means to me, that nginx proxy does its job, but somehow Safari/Chrome doesn't resolve the domain.
Could you advise me what to look at as I'm struggling to resolve this.

clearly out of the jwilder/nginx-proxy scope. What I would do is to add such domains to the hosts file. I don't own a Mac, but a quick search on Google reveals it is /private/etc/hosts. I suggest you search for tutorial on how to alter this file.
You might also want to clear your Mac DNS cache and Internet browser DNS cache.

Slightly out of scope I would say, as I'd run into this if I'd have a mac server. But otherwise apologies.
I will try cleaning the DNS cache as simply adding it to the hosts file did not work.

You could also setup dnsmasq to have all .localhost domains resolve locally.  Something like: https://passingcuriosity.com/2013/dnsmasq-dev-osx/

as it works out of the box on Linux, I expect the same on macOS. Was wondering where is the difference. Thanks for the help anyway.


Fix failing test_order_refund_success_with_ref_num

What are the relevant tickets?
None
There was another commit in the release that made tests in another commit fail.
What's this PR do?
Fix tests.
All tests should pass.

Codecov Report

Merging #948 (4047824) into main (6c364bf) will decrease coverage by 0.07%.
The diff coverage is 92.30%.

@@            Coverage Diff             @@
##             main     #948      +/-   ##
==========================================
- Coverage   84.56%   84.49%   -0.08%
==========================================
  Files         139      139
  Lines        6604     6610       +6
  Branches     1109     1111       +2
==========================================
  Hits         5585     5585
- Misses        840      845       +5
- Partials      179      180       +1

Impacted Files
Coverage Δ

ecommerce/views/v0/__init__.py
90.04% <ø> (-0.44%)
:arrow_down:

sheets/plugins.py
0.00% <ø> (ø)

ecommerce/api.py
80.10% <90.90%> (+0.54%)
:arrow_up:

conftest.py
57.14% <100.00%> (+2.14%)
:arrow_up:

main/settings.py
93.39% <100.00%> (ø)

ecommerce/discounts.py
80.70% <0.00%> (-1.76%)
:arrow_down:

ecommerce/models.py
88.85% <0.00%> (-1.21%)
:arrow_down:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


Enhancing the Testimonials section

I will enhance the Testimonials section for website, so it will look appealing to the website both in dark and light theme.
Please assign me this issue under Gssoc'24

Go for it , i want to see some appealing UI though :)


Reading from files in simulated binaries is not functioning correctly.

Describe the bug
Reading from files in simulated binaries is not functioning correctly.
To Reproduce
Any file open/read from a simulated file should fail.
Expected behavior
TBD

Clarify: this is specific to RISC-V core


Please provide a branch in flathub for nightlies

I'm hit by #555, and I'd like to test the fix from #748 but I'm using the flatpak.
Any chance to make nightlies available as flatpak via a "nightly" "dev" or whatever branch on flathub ?
Thanks!

Hi,
@lhw maybe you could take care of this since you provide the stable via flathub ?
Or just close this if you won't. I'll live :)
Thanks !

Flathub only supports stable and beta builds. Nightlies are not on my list currently. I would need to implement from-source compiles first.

Right, thanks!
Closing, then.


Reduce -r command recording size?

Is there anyway to reduce the size of the recordings produced by the -r command? I'm currently looking at over 4GB per hour of recording, I'd like to knock that down to 4-500 MB if possible.

The encoding size is determined by the --bitrate parameter (8Mbps by default). But I suggest to keep a high value, because real-time (hardware) encoders must encode quickly at the cost of efficiency.
You could then re-encode the resulting file with ffmpeg:
# higher values of crf gives smaller size, lower values of crf gives better quality
ffmpeg -i file.mp4 -c:v libx264 -crf 25 out.mp4
# you can also resize if necessary
ffmpeg -i file.mp4 -c:v libx264 -crf 25 -s 800x450 out.mp4

I'd prefer to not have to re-encode, so ill try lowering the bit rate. If that doesnt work out I will attempt re-encoding but that will end up being very time consuming.

A low bitrate for real-time encoding gives poor quality. If you reencode, you could reduce the file size by a factor of 10 (depending on the efficiency of your device encoder) without obvious quality drop.

Yeah for sure, the issue is I'm gonna have dozens, if not hundreds of files in the long term. I also don't have a dedicated machine to do the re-encoding.


Introduce a company-wide CSS module standard

We have standards for virtually everything else, but CSS. It was a little bit neglected, so we need to come up together with a solution to this problem.
There're a couple of solutions widely used:

Radium
JSS
styled-components
styletron
aphrodite
glamor

Here's a great comparison of most popular technologies:
https://github.com/MicheleBertoli/css-in-js
And of course, known and tested solutions:

"webpack" CSS Modules
Global CSS classes (old school)

@mikeqcp @wojciech-panek

Webpack CSS modules are great. Me and @mkleszcz used this in Shopthat and other projects, the bad part is that we needed to figure out how to handle it for the tests since the styles weren't processed to increase performance. For our case, @mkleszcz implemented a way to mock the styles:
import { keys, unset } from 'lodash';

const mock = {};

const resetClasses = () => {
  keys(mock).filter(k => k !== 'registerClasses').forEach(key => unset(mock, key));
};

const registerClasses = (clss) => {
  clss.map(value => {
    mock[value] = value;
  });
};

afterEach(resetClasses);

mock.registerClasses = registerClasses;

export default mock;

And because we were overwriting Module.prototype.require we could do
  if (path.search(/\.s?css/) !== -1) {
    return styleLoaderMock;
  }

So to use in the tests, we still would need to
  beforeEach(() => {
    styles.registerClasses(['my-class']);
  });

I know that we are not overwriting require anymore in current version of boilerplate, so maybe it's not a viable solution anymore.

@cpBurn
CSS modules are certainly a viable option since they still offer the most mature environment available.
The only thing I don't like is the weird notation of retrieving specific classes in a project you mentioned.

I think it would be good to have some decision criterias here... For me the right tool should be/have:

compatibile with React and React Native but not tightly coupled (not every project will be based on React)
support for server render + would be good to have ATF out of the box
quick!
full CSS support (best to avoid things like mimic :hover state using onMouseEnter events - @Radium)
syntax highlight (at least for jetbrains) and linting

Do you see anything else?

@mkleszcz

compatibile with React and React Native but not tightly coupled (not every project will be based on React)

React Native is out of the discussion since it is not a CSS. There is a built-in Stylesheet solution there.

support for server render + would be good to have ATF out of the box

As far as I know, all mentioned solutions support SSR (ATF is a much more complex thing than just a styling issue, so we might even treat it separately)

full CSS support (best to avoid things like mimic :hover state using onMouseEnter events - @radium)

Well, then we can't use SCSS either, since it's not a "full CSS" by this definition.
And honestly, since we would be using JS there are no limits to what we can do. This is an example of how material-ui does media queries:
[theme.breakpoints.up('sm')]: {
    container: {
      paddingTop: theme.spacing.unit * 8,
    },
  },

syntax highlight (at least for jetbrains) and linting

In CSS in JS you, of course, have a JS syntax highlight. The clue is in changing approach, and instead of using complex shorthand notation you introduce helper functions which can produce specific result. This also applies for

Please, don't reject CSS in JS just because you are used to CSS. Just treat CSS as a regular code, and a lot of doors open up :)

I'm not that experienced in this issue but when it comes to voting I'm in for the styletron. Apart from all basic functionality it is designed to work with react and I really like the the idea to use props inside styles and extract some behaviour from regular components. Even if it is not that mature I think it is worth giving it a try.
The one think that I'm missing in styletron is the possibility to use some more sophisticated linters for example to force ordering props inside stylesheets in certain way to improve readability.
I've noticed that people tend to use styles as components more deliberately instead of just copy-pasting some css so I think it is good way to go.
Furthermore I think that no matter which tool we will choose we should provide solid example with themes, helper functions and so on. Maybe we can ask Kuba for help and make it look a little better?

There is one more big con which I haven't noticed writing post above: it is really hard to debug things when named cases are not present in DOM tree. I'm not sure if it is a trade-off which we are willing to take.

Please, don't reject CSS in JS just because you are used to CSS. Just treat CSS as a regular code, and a lot of doors open up :)

True, but I think approaches that moves away from the traditional separation of files .js and .css or .scss, will introduce more complexity and it will be harder to board in new people. Maybe our best approach here would be somewhere between JS and CSS, and for that case I think JSS is the best.
We can still separate things in a simple way:
export const styles = {
  button: {
    fontSize: 12,
    '&:hover': {
      background: 'blue'
    }
  },
  ctaButton: {
    extend: 'button',
    '&:hover': {
      background: color('blue').darken(0.3).hex()
    }
  },
}

And can be used as similar as we use CSS Modules now:
render() {
    return <button className={styles.ctaButton} >Click me</button>;
}

Although it's not CSS/SCSS, it has a structure that reminds a well SCSS file so that wouldn't cause a big impact on people who never saw that.

I don't have one winner from the list, but just couple thoughts based on my experience.
I usually go with "webpack CSS modules" and I think it is a good option that offers quite good flexibility for adjustments while still being separated into plain ".scss" files instead of merged with JS.
In terms of testing, it's not that hard like Daniel wrote - you can just use libraries like this instead: https://github.com/bmatcuk/mock-css-modules. And then after you want to access styles.button in your code, you get "button" string returned there.
On the other hand, regarding weird notation @pziemkowski mentioned - for me personally I like using https://github.com/gajus/react-css-modules to be able to provide module classes through separate attribute, so instead of:
<button className={`class-one ${styles.classTwo}`}/>

you can use equivalent:
<button className="class-one" styleName="class-two"/>

Second option that I've already used is styled-components and I think it's pretty good solution too. It also feels like quite mature already and supports all CSS features like hovers, transitions etc with standard notation while still being able to modify CSS based on props or use any JS variables inside the CSS code.
The only important thing (which can be a pro or con) is that it forces a specific approach for separating presentation elements which need to be created separately and shouldn't contain any logic inside.

In terms of testing, it's not that hard like Daniel wrote - you can just use libraries like this instead: https://github.com/bmatcuk/mock-css-modules. And then after you want to access styles.button in your code, you get "button" string returned there.

@mikeqcp we didn't wanted to rely on that library, seems to be old and not maintained :/
React CSS Modules seems pretty cool though!

To sum it up:
On a face to face meeting, everyone in the thread so far included, we decided to go with styled-component library and build styling ecosystem around it.
We will revise this approach after a couple of projects.


Is it possible to write the command you are executing using a color that distinguishes it from the rest of the output?

It would be nice to have a way to distinguish the command from the output of the same when there are so many one after the other.
Is it possible to write the command you are executing using a color that distinguishes it from the rest of the output?

Commands are echoed in bold, but that doesn't stand out a ton, and I can see how they would get lost in other output.
I wouldn't be opposed to a setting that changed the highlight color, e.g.:
set highlight := blue

foo:
  echo foo

Yes, please. On Windows 10 all lines are the same, bold doesn't work.

It would be amazing to have something like {{blue}}{{custom_variable}}{{/blue}}.

Yes, please. On Windows 10 all lines are the same, bold doesn't work.

Ah, I didn't know that. If you do just -v RECIPE on Windows, does it print out ===> Running recipe RECIPE… in cyan? I want to make sure that colors aren't just generally broken on Windows.

Yep, the cyan works! The bold not!

It's quite easy to do it in nushell with just, here is a example: https://github.com/hustcer/setup-nu/blob/main/Justfile#L44
you can use (ansi xx) to set colors

OK. Thank you. But this is impossible for me because:

each team member should not be forced to install a new shell;
we'll use justfile for CI too; this means native shell only.

It's quite easy to do it in nushell with just, here is a example: https://github.com/hustcer/setup-nu/blob/main/Justfile#L44 you can use (ansi xx) to set colors: ansi g for green ansi gb for green and bold, etc.

This is nice, and I love nushell, but this requires you to explicitly define the colored print messages.
I think rust has some libraries to facilitate colored printing. I'm still a newbie at rust, but maybe I'll try my hand at this issue.


Allow passing of tuples to methods

Closes https://github.com/spring-projects/spring-data-relational/issues/1323
To be honest, I'm not sure if this is the right way to fix this. Could you take a hard critical look, please?

#1569 seems related.


shorten --indent and --max-inline-length

releated to #14

Thanks for the PR. Would you mind adding a test to test_console_script.py? When pytest runs it'll run coverage too so you should end up with 100% coverage at the end (actually it's 99.x% as there's one line not covered).


cleanup tempdir

Hi,
I noticed bundler sometimes left (empty) temporary directories behind. Not quite the end of the world of course, but still. I'm not very familiar with the codebase and am therefore not quite sure this is the best way to fix it, so please tell me what you think.
- Felix

Still running into the same issue.


Key equivalence relations and synchronization to prevent user from having to move keys

NOTE: @nk-the-crazy, @zubaidullo this will involve you guys as well.
Right now users are creating key pairs on different machines and even on the same machine with different browsers via the browser plugin. There are going to be situations where this could become a serious problem: for example when using different keys with the Hub and a peer. It certainly already presents a usability issue to have to move (export then import) a key pair and doing so is a security risk.
Also right now the Hub and the peer have one key to identify the user. There should probably be more than one key associated, and those keys should be deemed equivalent. The Hub should provide a means for the user to add keys that are considered equivalent. There could be one master key, and the others considered equivalent keys.
This mechanism we can use is to have the master key sign an relation document stating that another key is considered equivalent to it. The Hub could provide a REST service for accessing these relationships when authenticated to determine key equivalence. This should be a two way relation for security purposes. Meaning one key must sign that it is equivalent to the other and vice versa. So a user with two keys on separate browsers (same machine or different machine) will have to sign such a relationship document. Peers registered with the Hub should push these signed documents to the Hub via authenticated REST calls. This will also require some plugin work.
I think if authenticated to the Hub and a user is using a key different than the one they have registered with the Hub. Then they can be notified that they have a key different than the one they originally used to register. And they can be asked if they want to begin the process of making them equivalent. The user will then need to use both key pairs to sign each directional relation.

Current implementation of browser plugin, SS and Hub is based on usage of single key which is reflected throughout the entire chain starting from browser cookie thru SS and till Hub and Kurjun. This would require a complete change of the security core.

Also, SS already allows to define which key to use in settings. So user can set any key on a given peer, thus having different keys on different peers.
However for this feature to work we need Hub side to handle different keys that are associated with the main key in Hub account. Also this should propagate from Hub to Kurjun because peer uses Kurjun directly.
And if user decides to use multiple keys this should be handled in one place on Hub and get reflected in Kurjun automatically. Otherwise is user is ok and uses default single key option then everything stays as it is.

For one peer there should be one key at a given moment of time, but this can should be changeable (as is now). On Hub, however, user keys might be numerous. So moving this issue to Hub.


The firewall rules command no longer works with unblocking ntttcp traffic

[Enter feedback here]
This command no longer works with win10 with latest defender updates:
netsh advfirewall firewall add rule program=c:\tools\ntttcp.exe name="ntttcp" protocol=any dir=in action=allow enable=yes profile=ANY
Disabling firewall altogether does allow for ntttcp traffic but this is of course not the correct resolution :)
If needed, i can provide the relevant defender versions
Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 42423f75-6611-2ff6-135d-cd0a11bab7c2
Version Independent ID: ae7c8bd5-2eb5-1c4d-af63-def403a4a574
Content: Testing Azure VM network throughput
Content Source: articles/virtual-network/virtual-network-bandwidth-testing.md
Service: virtual-network
GitHub Login: @steveesp
Microsoft Alias: steveesp

@scaramushe , this is the first I'm hearing that the netsh command doesn't work. What happens when it is entered as it is now?
Can you suggest an updated command line that works with the latest defender?

@scaramushe , could you please provide the requested information?

Sure, copying from direct communication with the author:
The ntttcp is the tool used to test throughput, i haven't used it for a couple of weeks and this week it stopped working.
After disabling firewall altogether, the tests started passing again.
Enabling firewall, running the "Allow ntttcp" command again - the incoming packets are dropped again (verified in the OS TCP logs)
Disable firewall - pass again
From: Gitarani Sharma @.>
Sent: Tuesday, 19 April 2022 6:19
To: MicrosoftDocs/azure-docs @.>
Cc: scaramushe @.>; Mention @.>
Subject: Re: [MicrosoftDocs/azure-docs] The firewall rules command no longer works with unblocking ntttcp traffic (Issue #91314)
@scaramushehttps://nam12.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fscaramushe&data=04|01||fd52483208e2451e507208da21b357ce|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|637859351413991231|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000&sdata=aBdsG21%2FOFoOyJccw7FTjjIFIH1auVrblfJjLeq8bZQ%3D&reserved=0 , could you please provide the requested information?
—
Reply to this email directly, view it on GitHubhttps://nam12.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FMicrosoftDocs%2Fazure-docs%2Fissues%2F91314%23issuecomment-1101952117&data=04|01||fd52483208e2451e507208da21b357ce|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|637859351413991231|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000&sdata=PM19Zd3W77mx5wbS2IhCy7%2ByIZWrlzeRsajNYzqLqZk%3D&reserved=0, or unsubscribehttps://nam12.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FARJRTYQPMDJL7SYOE6Z7JVDVFYQ2DANCNFSM5TDCM2RQ&data=04|01||fd52483208e2451e507208da21b357ce|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|637859351413991231|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000&sdata=muKfa7AERqqDIrYW6k3LKiTiHXN7hAmjFZaokNQSRRc%3D&reserved=0.
You are receiving this because you were mentioned.Message ID: @.***>

@steveesp , could you please review the last comments and provide some insights on this issue?


Missing className property in datepicker component

How to apply custom style on datepicker component? There is no className property :(

Hi! I did not include className because I didn't think it would be needed any customization if you use the standard. Apart from that, is a quite complex component. What would you exactly want to personalize in order to provide an option or something?

I would like to personalize background color of header and active date style. Can I accomplish it with toolbox-loader?

With toolbox loader you can personalize almost everything but it mostly focused on color changing. To do so you can check the configuration variables used for each component in the source code. Then you can override those variables in your theme using toolbox loader.
Another option, would be to browse the HTML focusing on data-react-toolbox attributes to apply styles from an upper className.

I've added className property to pickers so you can use it to target more specific elements and give a custom look to your picker. If you just want to modify colors (which is the most likely case) you can use the toolbox-loader.
Thanks!


Problem with 'docker-compose up'

Hi all,
I am currently trying to run a test application in my local Kubernetes cluster with Devon4Quarkus-Reference (https://github.com/devonfw-sample/devon4quarkus-reference). Unfortunately, I get some error messages already with the command 'docker-compose up', which I can't explain even after research.

The first error, that PostgreSql could not start, was solved by deleting line 12 in docker-compose.yaml.

command: [-cmax_prepared_transactions=100]

The other error is with Matric. See screenshots:

Is there also a solution for this as with the database?
Thanks a lot.
Patrick

Hi Patrick,
We discussed in Teams Channel and other than the known issues (Monitoring/Logging), you are able to check the application running after deployment. Please confirm.
Thanks,
Sundhar

Hi Sundhar,
i can run the Application on my local machine, but now  i try it to run on a local kubernetes/minicube cluster for test reasons and this is not working yet. I am working on.
Thanks
Patrick

For Kubernetes deployment use the files from the k8s folder and for the OpenTelemetry components have a look at the documentation. The docker file can not be used just like this I think. The application and the database should work, but the configuration for the other components needs to be adjusted.

Hi Julian,
now it's working :)
Thanks
Patrick


Milestone 2 Feedback

Congratulations on finishing milestone 2! We can see you put a lot of work into this project, nice work!
Below we list some specific feedback you can use to improve your project.
We provide tick boxes for you to use in the future as you address these concerns to improve the final grade of your project.
If anything is unclear, please feel free to ask questions in this issue thread.

1. Write test cases and code iteratively
rubric={accuracy:20,quality:10,mechanics:10}

[ ] The documentation for one of the test functions is missing. - quality -2

2. R package checklist
1. Create project structure for the R project
rubric={mechanics:20}
Well done!
3. R package function specifications
rubric={quality:10}
Well done!
4. Specific expectations for this milestone are:
rubric={mechanics:10}
Well done!
5. Submission instructions
rubric={mechanics:10}
Well done!

Hello,
Re (3), would you let us know which documentation is it? In the roxygen comments, we have examples for each function.
Re (5), we have a project board. You may find it here https://github.com/orgs/UBC-MDS/projects/34. You may check, for example, the issue with the tag R.

Thanks. After consulting Florencia, we are going to leave it as it is.
Closing this issue.


Using Logger to implement --verbose functionality

New PR with identical changes as in PR #176.
Added a logger for both fpgaperf.py and exhaust.py, that is turned on if --verbose is specified. Also added messages that will be printed through the logger under the DEBUG level.
Also changed the directory to which exhaust runs are saved from build to build/_exhuaust-runs.

Thanks for the enhancement


MangaGeko SSLPeerUnverifiedException

Steps to reproduce

Open MangaGeko Source

Expected behavior
It should show the List of Manga
Actual behavior
It is showing SSLPeerUnverifiedException

Crash logs
No response
Tachiyomi version
1.10.3
Android version
Android 11
Device
Realme 3 Pro
Other details
No response
Acknowledgements

[X] I have searched the existing issues and this is a new ticket, NOT a duplicate or related to another open or closed issue.
[X] I have written a short but informative title.
[X] If this is an issue with an extension, I should be opening an issue in the extension's repository.
[X] I have gone through the FAQ and troubleshooting guide.
[X] I have updated the app to version 1.10.2.
[X] I have updated all installed extensions.
[X] I will fill out all of the requested information in this form.

Report source issues where you got the extension.

Report source issues where you got the extension.

Where ?

¯\(ツ)/¯

Report source issues where you got the extension.

Where ?

Google bro


WIP: Feature/binance v2 refactoring

Description
Refactoring of PyCryptoBot class to be more readable. Stripping out configuration into its own class.
As a bonus, configuration can now be specified in both JSON and YAML.

Type of change
Please make your selection.

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update
[ ] This change requires a new dependency
[X] Code Maintainability / comments
[X] Code Refactoring / future-proofing

How Has This Been Tested?
Unit Tests and simulations.
Checklist:

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[x] I have added pytest unit tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes
[ ] Any dependent changes have been merged and published in downstream modules
[x] I have checked my code and corrected any misspellings

@loomsen, thanks mate. Looks great.
If you run "python3 pycryptobot.py" does it look for a config.json or config.yaml or both? If both exist which one is preferred?
We have some conflicts in, "models/PyCryptoBot.py". Can you help me resolve them please? It's not a straight forward replace of mine for yours as there is code for the Binance migration which will get lost. I added code to allow you to pass "---recvWindow [num]" as an argument. And in the BAuthAPI you pass the recv_window to the API. This is to allow for people to adjust the recvWindow from the default if they are having problems with slow connectivity. I like your update but need to make sure my updates from last night are not lost.

closing in favor of #414


Added erf and erfc to scipy.special

Thanks!
Is it better to write the constant inv_root_pi = 0.56418958354775627928 in the code instead of just writing 1./np.sqrt(np.pi)?

IIUC a sqrt is a relatively expensive operation so instead of computing it every single time you call the gradient I tend to factor out such constants, especially where they're reusable.
I try not to go overboard though as it can rapidly make your code unintelligible, also without benchmarking it might be a redundant micro-optimisation
In [2]: f = lambda x: 2.*np.exp(-x**2)/np.sqrt(np.pi)

In [3]: g = lambda x: 2.*inv_root_pi*np.exp(-x**2)

In [4]: %timeit f(3.14)
The slowest run took 14.95 times longer than the fastest. This could mean that an intermediate result is being cached
100000 loops, best of 3: 2.83 µs per loop

In [5]: %timeit g(3.14)
The slowest run took 15.00 times longer than the fastest. This could mean that an intermediate result is being cached
1000000 loops, best of 3: 1.65 µs per loop

In [6]: from math import sqrt, pi

In [7]: f = lambda x: 2.*np.exp(-x**2)/sqrt(pi)

In [8]: %timeit f(3.14)
The slowest run took 23.36 times longer than the fastest. This could mean that an intermediate result is being cached
1000000 loops, best of 3: 1.89 µs per loop

...so the biggest takeaway from above is to not use numpy-vectorized functions for scalar args. For the scalar math functions the benefit in only 15%. Whether or not that's important probably depends on the application.
I'm probably a little obsessive about avoiding redundant calculations/allocations as I'm often pushing python/numpy to its limits to avoid having to drop down into compiled code. Consequently I'm also very interested in issue #47

...and also in-place numpy operations or operations supporting the out= parameter. In my application each operation will be allocating an array hundreds of Mb in size so reusing existing memory can provide huge speed-ups.

Ah I see. But maybe we could compute it just once as 1./np.sqrt(np.pi) once at the module level instead of hardcoding the number.
Supporting real in-place operations is fundamentally hard with reverse-mode autodiff because, as David recently explained to me, you often need most of the intermediate forward values to evaluate the gradients on the backward pass (and you can't just regenerate them in the backward pass, at least not in general, though Dougal and David have a paper on reversible learning). The best we could hope for is to allow in-place syntax but collect forward values behind the scenes, discarding ones we don't need to look up on the backward pass.

Yeah, computing it once at the module level would prob be better as it  is self-documenting then - more so than the awkward variable naming :P
I thought it might be difficult to achieve. If it's not going to help with memory utilisation it's probably not so useful to have in-place syntax excepting for completeness' sake.


Minor: fix Aggregation Docs from review

Which issue does this PR close?

Closes #.
Rationale for this change

What changes are included in this PR?
Implements the changes from the review in #12861 by @Omega359

Are these changes tested?

Are there any user-facing changes?

LGTM, thx!

@findepi Does it look good?

Does it look good?

per https://github.com/apache/datafusion/pull/12880#discussion_r1797440377, i would prefer to have these "The" removed. Would you like to add a commit for this?

Does it look good?

per #12880 (comment), i would prefer to have these "The" removed. Would you like to add a commit for this?

I think we may need to update the with_standard_argument in some manner or have another method to clean that up. I was toying with either "" == "Expression to operate on....", Change the arg to an option, or `with_standard_argument_<something_here>(..)

I think we can improve the argument handling as follow on PRs