renamed jQuery import to match module name.

Prevents incompatibilities with web pack and other packagers.

Please modify the uncompiled file if you want this to be mergable.

You didn't modify the source file so this can't be merged. However this is now fixed so don't worry about it.


Enumerable#any?, one? and all? with multiple yield

Assuming the original intent for these tests was to test the behavior of #all?, #none?, and #one? with array elements, these changes fix https://github.com/ruby/spec/issues/554.

@marcandre Could you review this PR?

Thanks for the PR @ivanoblomov
I'm sorry, I wasn't very clear in my original issue. I'm even more sorry that I've since learned more about the issue and now believe we should spec it, since it is so inconsistent. It's inconsistent to the point of being magical and I don't see how alternate implementations could implement it properly.
So I think the best here is to leave things as is and hope that we make things more consistent in CRuby...
I'm sorry about the confusion I created.

No worries, thanks for the clarification @marcandre.


start of a reference implementation and the hello_world example from P2300

This gets all the CPOs and most of the concepts in place, as well as the execute, lazy_then, and sync_wait algorithms. More to come in future PRs. This should be enough to get started writing examples.

What sort of license/ copyright notice do we want on these files?


Commit need signing off

(https://github.com/kuberhealthy/kuberhealthy/pull/1026)

There is one commit incorrectly signed off. This means that the author of this commit failed to include a Signed-off-by line in the commit message.

There is no reference in the CONTRIBUTING.md re signing off the commits, eg what does it signify and why is it required.

This is due to the DCO bot requiring your git commits to be signed.  This is required by the CNCF to ensure that the committer's name can not be spoofed.

If you hit details on this, it will tell you how to sign your commits.

Hi, the dco bot tells me to "sign off" (lowercase -s), not to Sign (capital -S). Sign is with a gpg key and has some level of authentication (and gices the green verified). Sign off is just some text added to a commit text, which can be easily spoofed.
Neither is mentioned in the CONTRIBUTING.md, nor see i something mentioned in the CNCF CLA regarding this. The DCO details only tells me how to do it, not why.
Quite happy to sign a CLA, but would like to know up front what i'm signing off for.

It is interesting that you don't use a capital S when signing commits and instead use a lowercase "sign off" that basically only puts something in the commit message.  I can tell you that we had to enable this as per the CNCF guidelines, but I can't really tell you what the exact legal pretense for it is.  It does look like there are some clues on developercertificate.org.
It was either this or a CLA bot.  I was originally preferring the CLA bot, but ended up having trouble getting it enabled and thus went with the DCO bot.
I will add this to the CONTRIBUTING.md file.  It looks like that file still mentions the CLA agreement and not the DCO bot.


Added method to model to filter by city

Description

Added a method to filter by city to model the customers
Type of change

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

[x] I have performed a self-review of my code
[ ] I have made corresponding changes to the documentation
[x] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes

Codecov Report

Merging #69 (3edda86) into master (0651677) will increase coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master      #69      +/-   ##
==========================================
+ Coverage   98.54%   98.56%   +0.02%
==========================================
  Files           7        7
  Lines         275      279       +4
==========================================
+ Hits          271      275       +4
  Misses          4        4

Impacted Files
Coverage Δ

service/models.py
100.00% <100.00%> (ø)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Token router

As discussed in #56, initial hybrid radix tree router submission. There is some refactoring to do and one test fails but need to understand test as I'm not sure why url encoding is being tested.
Failed test is:

Failed   Giraffe.TokenRouterTests.GET "/foo/blah blah/bar" returns "blah blah"
Error Message:
Expected: blah%20blah
Actual:   blah blah

Readme updates are basic so feel free to tweak & refine.

@dustinmoris  let me know if you have any questions on the implementation. I am open to tweaking it to ease usage/adoption.
Let me know on the Blah Blah test if you would like me to update to expect space instead of URL encoded %20 so that the tests pass, or would like to leave failed as is.
This is not my final planned PR on performance Router but thought I would start integrating it asap so namespace usage of BasicRouter vs TokenRouter would be less breaking later on.

Hi @gerardtoconnor,
I have to admit that I still haven't gotten my head fully around this PR, but generally I think it looks good. It needs a lot of tidy up though (seen a lot of comments indicating that you still need to finish a few things) and I'd prefer to keep the basic routes in the current namespace and then let a user override them by opening up the TokenRouter namespace.
Since the token router implementation is an opt-in feature which would get enabled through namespace opening I see little risk with this PR.
Few things which I'd like you to ask as part of this PR:

Keep basic routes in original namespace (up for debate if you can convince me otherwise :D)
Add to the README a bit of a description what the TokenRouter is (as in how it works under the covers) and when a user should opt in for it instead of the normal routes (basically make it more clear for less experienced users which to pick).
Perhaps make it mandatory/optional for a user to configure a 404 handler for the TokenRouter, as I can imagine that many people will want to be able to customise the 404 response with performance routing as well
Make helper functions such as rtrn, between, etc. private or perhaps move into a sub module of TokenRouter so that these functions do not accidentally override the same named functions by a user who uses TokenRouter.
Restore all the metadata of the Giraffe.fsproj which has been removed in this PR
Fix the last broken unit test :)

Overall great work and really appreciate your many contributions!

On comments, given the complexity of execution, is it ok to leave the non-issue related pure documentation ones in there? I normally wouldn't but given its complexity, debugging without the comments will be tough for me let along someone else?
On the issue comments, don't think there is anything serious, just need to tidy up (and works as is) but will have tidied up on next commit.

Keep basic routes in original namespace (up for debate if you can convince me otherwise :D)

I'll amend to overload as suggested and test the override has no bugs (I had split them as subRoute is little different across two ... but that actually shouldn't make any difference really).

Add to the README a bit of a description what the TokenRouter is (as in how it works under the covers) and  when a user should opt in for it instead of the normal routes (basically make it more clear for less experienced users which to pick).

Will do, won't get too technical but explain basic radix node tree traversal & hand rolled parsers

Perhaps make it mandatory/optional for a user to configure a 404 handler for the TokenRouter, as I can imagine that many people will want to be able to customise the 404 response with performance routing as well

OK, I can add an initial first argument to router before route list that is the "not found" handler to run if not matched in the tree.

Make helper functions such as rtrn, between, etc. private or perhaps move into a sub module of TokenRouter so that these functions do not accidentally override the same named functions by a user who uses TokenRouter.

Oversight on my part, yes will re-review and ensure all internal helpers set to private as should be, and most are already

Restore all the metadata of the Giraffe.fsproj which has been removed in this PR

Oops, missed that, not sure how that happened, yeah may re-checkout master and then and re-create/copy TokenRouter & Tests file to make sure properly re-aligned

Fix the last broken unit test :)

I don't know how this is broken though!? I would expect the result of the test to be "blah blah" not "blah%20blah" as we have used NSubstitute and not passed it through any middleware that would have re-encoded the space to a %20 ... I mean I can Hack and pass through a url encode function but that's just as contrived as changing the initial expected result of "blah%20blah". How is the %20 getting in there in the original tests without server on UNIT tests?
Thanks for the preliminary review and good spot on metadata, will have updates committed in next few days ... Just guidance on url encoding test is all I need final clarification on.

Comments in the code are fine and I totally agree, when the code is complex
then comments are always desired.
Re unit test I think something has changed in the unit testing framework
and I had to fix the same test on develop as well, but don't remember it
from the top of my head now. I think it has nothing to do with your
implementation so don't worry about it for now and I'll try to look into it
again to figure out what it was.
I'll be back checking on issues by end of this week again, hope you've got
everything you need until then!
Many thanks!
On 18 Oct 2017 19:57, "Gerard"<EMAIL_ADDRESS>wrote:

Reopened #104 https://github.com/dustinmoris/Giraffe/pull/104.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/dustinmoris/Giraffe/pull/104#event-1300144999, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AEXlamEh8-Id9U0M-e_MdtWMAKVG8ZtQks5stpBNgaJpZM4PxcHP
.


Create dummyang

my first angular

Looks like this pull request was unintentional? Closing as there are no changes.

yes, sorry. I was going through your lecture.


Document title not translated after reload

This is  a bug.
Description
After reload of browser window the document title is not translated
Steps to Reproduce
Open enso and reload page
Expected behavior

Actual behavior

Yeah, that happens because on page reload the document title is displayed before the app initialises. It needs to be that way in order to have doc.title in auth pages too.
Anyway when you click the next link, the localisation works as expected.
I will think of something..


SciQA image Evaluation on InstructBLIP (Vicuna-7B) Help

Hello,
If I understand the process from the paper correctly, we are using the 2017 images with their corresponding questions from the test set of Science QA to evaluate the InstructBLIP (Vicuna-7B) model. However, after trying out for a day, I can only achieve 48.04 using the pre-trained weights as opposed to what the paper claimed as 60.5. Could anyone help me see if my prompt format is off?
I use the below format to feed into the model (an example of 2877 in the test set of Science QA):
Question: {Think about the magnetic force between the magnets in each pair. Which of the following statements is true?} Options: {(a) The magnetic force is weaker in Pair 2. (b) The strength of the magnetic force is the same in both pairs. (c) The magnetic force is weaker in Pair 1.}. Answer:

I think I have closely followed the Instructions for Zero-shot Inference in the appendix, so any help is greatly appreciated!

Did you try adding the vocab constraints and ranking?

你好，你能简单的说一下怎么复现的instructblip的呢，是需要编写lavis的yaml文件吗？如果是的话，可以给个示例吗

I have the same question. Maybe 'Context' is the import key in scienceqa task, but I don't know how to construct it.

Could the authors provide evaluation script or  implementation guideline for ScieceQA?


Can't find variable GithubActivity

I am newbie to JS, I followed instructions in the readme file. But i wasn't able to get the activity feed. I attached my html file in which i also included javascript just for testing.
index.html.zip
Thanks :)

You reference many files that are not in the file system (at least, they aren't in the file system that you provided).


Fix golangci-lint 1.60.1 issues

To unblock https://github.com/cilium/cilium/pull/34412. Separate branch because I cannot force-push to that branch. See commits for details.

/test

/test

/test


do not work for all populartimes

Thank you for this module. Very cool!
But when can't get popularity from all shops and malls
In google maps i can see graphics of the popularity, but can't get it. What's wrong?

Can you provide an example (name and address of a place where this happens)?

Ulitsa Azovskaya, 24, к. 3, Moskva, Russia, 117452
Azovsky
plac id: ChIJSdUNRyezSkERk9ina6nigxM

I cannot reproduce your problem. As far as I can see, the populartimes data is returned correctly:
>>> import populartimes
>>> populartimes.get_id(myapikey, "ChIJSdUNRyezSkERk9ina6nigxM")
{'id': 'ChIJSdUNRyezSkERk9ina6nigxM', 'name': 'Azovsky', 'address': 'Ulitsa Azovskaya, 24, к. 3, Moskva, Russia, 117452', 'types': ['shopping_mall', 'point_of_interest', 'establishment'], 'coordinates': {'lat': 55.647468, 'lng': 37.59548189999999}, 'rating': 4.2, 'rating_n': 1895, 'international_phone_number': '+7 495 310-77-10', 'current_popularity': 46, 'populartimes': [
  {'name': 'Monday', 'data': [0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 31, 43, 52, 56, 57, 58, 65, 77, 91, 95, 84, 61, 0, 0]},
  {'name': 'Tuesday', 'data': [0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 30, 42, 53, 58, 59, 59, 64, 77, 91, 94, 82, 58, 0, 0]},
  {'name': 'Wednesday', 'data': [0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 34, 48, 59, 63, 63, 64, 72, 87, 99, 100, 84, 58, 0, 0]},
  {'name': 'Thursday', 'data': [0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 36, 47, 56, 60, 61, 63, 71, 84, 95, 95, 81, 57, 0, 0]},
  {'name': 'Friday', 'data': [0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 38, 49, 57, 60, 61, 64, 71, 84, 94, 94, 83, 62, 0, 0]},
  {'name': 'Saturday', 'data': [0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 39, 57, 72, 82, 84, 84, 84, 85, 84, 78, 65, 47, 0, 0]},
  {'name': 'Sunday', 'data': [0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 29, 47, 65, 78, 84, 85, 86, 86, 84, 77, 63, 45, 0, 0]}
], 'time_spent': [20, 120]}

How does your response look like?

populartimes.get_id(myapikey, 'ChIJSdUNRyezSkERk9ina6nigxM')
{'id': 'ChIJSdUNRyezSkERk9ina6nigxM', 'name': 'Azovsky', 'address': 'Ulitsa Azovskaya, 24, к. 3, Moskva, Russia, 117452', 'types': ['shopping_mall', 'point_of_interest', 'establishment'], 'coordinates': {'lat': 55.647468, 'lng': 37.59548189999999}, 'rating': 4.2, 'international_phone_number': '+7 495 310-77-10'}

So. Can you explain what's wrong?

This is likely related to language/country specific changes to Google Maps. I also could not reproduce the issue.
My suggestion would be to use a VPN and check if you still don't receive data from this place.


[Doc-Improvement][Obsolete-files-links]

Fix bad/broken links from the PR6702. Delete/Redirect files obsolete after the merging of Teams Toolkit for Visual Studio Code revamp.

Acrolinx Scorecards
We currently enforce a minimum score of 80.
Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology:

Article
Score
Issues
Scorecard
Processed

msteams-platform/get-started/glossary.md
94
21
link
:white_check_mark:

More info about Acrolinx
Use the Acrolinx extension, or sidebar, in Visual Studio Code to check spelling, grammar, style, tone, clarity, and key terminology when you're creating or updating content. For more information, see Use the Visual Studio Code extension to run Acrolinx locally.

Docs Build status updates of commit b2e8cdd:
:warning: Validation status: warnings

File
Status
Preview URL
Details

msteams-platform/get-started/glossary.md
:warning:Warning
View
Details

msteams-platform/get-started/glossary.md

Line 22, Column 3: [Warning: file-not-found - See documentation] Invalid file link: '../concepts/design/understand-use-cases'.

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Acrolinx Scorecards
We currently enforce a minimum score of 80.
Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology:

Article
Score
Issues
Scorecard
Processed

msteams-platform/get-started/glossary.md
94
21
link
:white_check_mark:

More info about Acrolinx
Use the Acrolinx extension, or sidebar, in Visual Studio Code to check spelling, grammar, style, tone, clarity, and key terminology when you're creating or updating content. For more information, see Use the Visual Studio Code extension to run Acrolinx locally.

Docs Build status updates of commit c690b20:
:warning: Validation status: warnings

File
Status
Preview URL
Details

msteams-platform/get-started/glossary.md
:warning:Warning
View
Details

msteams-platform/get-started/glossary.md

Line 22, Column 3: [Warning: file-not-found - See documentation] Invalid file link: '../concepts/design/understand-use-cases'.

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Acrolinx Scorecards
We currently enforce a minimum score of 80.
Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology:

Article
Score
Issues
Scorecard
Processed

msteams-platform/get-started/glossary.md
94
21
link
:white_check_mark:

More info about Acrolinx
Use the Acrolinx extension, or sidebar, in Visual Studio Code to check spelling, grammar, style, tone, clarity, and key terminology when you're creating or updating content. For more information, see Use the Visual Studio Code extension to run Acrolinx locally.

Docs Build status updates of commit bed0847:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

msteams-platform/get-started/glossary.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Acrolinx Scorecards
We currently enforce a minimum score of 80.
Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology:

Article
Score
Issues
Scorecard
Processed

msteams-platform/get-started/glossary.md
94
21
link
:white_check_mark:

msteams-platform/mstdd-landing.yml
100
0
link
:white_check_mark:

msteams-platform/sbs-tabs-and-messaging-extensions-with-sso.yml
83
35
link
:white_check_mark:

More info about Acrolinx
Use the Acrolinx extension, or sidebar, in Visual Studio Code to check spelling, grammar, style, tone, clarity, and key terminology when you're creating or updating content. For more information, see Use the Visual Studio Code extension to run Acrolinx locally.

Docs Build status updates of commit 05a4d25:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

msteams-platform/get-started/glossary.md
:white_check_mark:Succeeded
View

msteams-platform/mstdd-landing.yml
:white_check_mark:Succeeded
View

msteams-platform/sbs-tabs-and-messaging-extensions-with-sso.yml
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Acrolinx Scorecards
We currently enforce a minimum score of 80.
Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology:

Article
Score
Issues
Scorecard
Processed

msteams-platform/get-started/glossary.md
94
21
link
:white_check_mark:

msteams-platform/mstdd-landing.yml
100
0
link
:white_check_mark:

msteams-platform/sbs-tabs-and-messaging-extensions-with-sso.yml
84
34
link
:white_check_mark:

msteams-platform/tabs/what-are-tabs.md
93
7
link
:white_check_mark:

More info about Acrolinx
Use the Acrolinx extension, or sidebar, in Visual Studio Code to check spelling, grammar, style, tone, clarity, and key terminology when you're creating or updating content. For more information, see Use the Visual Studio Code extension to run Acrolinx locally.

Docs Build status updates of commit 6d215c4:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

msteams-platform/get-started/glossary.md
:white_check_mark:Succeeded
View

msteams-platform/mstdd-landing.yml
:white_check_mark:Succeeded
View

msteams-platform/sbs-tabs-and-messaging-extensions-with-sso.yml
:white_check_mark:Succeeded
View

msteams-platform/tabs/what-are-tabs.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Acrolinx Scorecards
We currently enforce a minimum score of 80.
Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology:

Article
Score
Issues
Scorecard
Processed

msteams-platform/get-started/glossary.md
94
21
link
:white_check_mark:

msteams-platform/mstdd-landing.yml
100
0
link
:white_check_mark:

msteams-platform/sbs-tabs-and-messaging-extensions-with-sso.yml
84
34
link
:white_check_mark:

msteams-platform/tabs/what-are-tabs.md
93
7
link
:white_check_mark:

More info about Acrolinx
Use the Acrolinx extension, or sidebar, in Visual Studio Code to check spelling, grammar, style, tone, clarity, and key terminology when you're creating or updating content. For more information, see Use the Visual Studio Code extension to run Acrolinx locally.

Docs Build status updates of commit 3917fe6:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

msteams-platform/get-started/glossary.md
:white_check_mark:Succeeded
View

msteams-platform/mstdd-landing.yml
:white_check_mark:Succeeded
View

msteams-platform/sbs-tabs-and-messaging-extensions-with-sso.yml
:white_check_mark:Succeeded
View

msteams-platform/tabs/what-are-tabs.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Acrolinx Scorecards
We currently enforce a minimum score of 80.
Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology:

Article
Score
Issues
Scorecard
Processed

msteams-platform/get-started/glossary.md
94
21
link
:white_check_mark:

msteams-platform/mstdd-landing.yml
100
0
link
:white_check_mark:

msteams-platform/sbs-tabs-and-messaging-extensions-with-sso.yml
84
34
link
:white_check_mark:

msteams-platform/tabs/what-are-tabs.md
93
7
link
:white_check_mark:

More info about Acrolinx
Use the Acrolinx extension, or sidebar, in Visual Studio Code to check spelling, grammar, style, tone, clarity, and key terminology when you're creating or updating content. For more information, see Use the Visual Studio Code extension to run Acrolinx locally.

Docs Build status updates of commit 50877c6:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

.openpublishing.redirection.json
:white_check_mark:Succeeded

msteams-platform/get-started/glossary.md
:white_check_mark:Succeeded
View

msteams-platform/mstdd-landing.yml
:white_check_mark:Succeeded
View

msteams-platform/sbs-tabs-and-messaging-extensions-with-sso.yml
:white_check_mark:Succeeded
View

msteams-platform/tabs/what-are-tabs.md
:white_check_mark:Succeeded
View

msteams-platform/toolkit/accounts.md
:white_check_mark:Succeeded
n/a (file deleted)

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Acrolinx Scorecards
We currently enforce a minimum score of 80.
Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology:

Article
Score
Issues
Scorecard
Processed

msteams-platform/TOC.yml
98
6
link
:white_check_mark:

msteams-platform/get-started/glossary.md
94
21
link
:white_check_mark:

msteams-platform/mstdd-landing.yml
100
0
link
:white_check_mark:

msteams-platform/sbs-tabs-and-messaging-extensions-with-sso.yml
84
34
link
:white_check_mark:

msteams-platform/tabs/what-are-tabs.md
93
7
link
:white_check_mark:

More info about Acrolinx
Use the Acrolinx extension, or sidebar, in Visual Studio Code to check spelling, grammar, style, tone, clarity, and key terminology when you're creating or updating content. For more information, see Use the Visual Studio Code extension to run Acrolinx locally.

Docs Build status updates of commit deaf4e7:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

.openpublishing.redirection.json
:white_check_mark:Succeeded

msteams-platform/get-started/glossary.md
:white_check_mark:Succeeded
View

msteams-platform/mstdd-landing.yml
:white_check_mark:Succeeded
View

msteams-platform/sbs-tabs-and-messaging-extensions-with-sso.yml
:white_check_mark:Succeeded
View

msteams-platform/tabs/what-are-tabs.md
:white_check_mark:Succeeded
View

msteams-platform/TOC.yml
:white_check_mark:Succeeded
View

msteams-platform/toolkit/accounts.md
:white_check_mark:Succeeded
n/a (file deleted)

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Acrolinx Scorecards
We currently enforce a minimum score of 80.
Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology:

Article
Score
Issues
Scorecard
Processed

msteams-platform/TOC.yml
98
6
link
:white_check_mark:

msteams-platform/get-started/glossary.md
94
21
link
:white_check_mark:

msteams-platform/mstdd-landing.yml
100
0
link
:white_check_mark:

msteams-platform/samples/integrate-web-apps-overview.md
89
14
link
:white_check_mark:

msteams-platform/samples/integrating-web-apps.md
95
4
link
:white_check_mark:

msteams-platform/sbs-tabs-and-messaging-extensions-with-sso.yml
84
34
link
:white_check_mark:

msteams-platform/tabs/what-are-tabs.md
93
7
link
:white_check_mark:

More info about Acrolinx
Use the Acrolinx extension, or sidebar, in Visual Studio Code to check spelling, grammar, style, tone, clarity, and key terminology when you're creating or updating content. For more information, see Use the Visual Studio Code extension to run Acrolinx locally.

Acrolinx Scorecards
We currently enforce a minimum score of 80.
Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology:

Article
Score
Issues
Scorecard
Processed

msteams-platform/TOC.yml
98
6
link
:white_check_mark:

msteams-platform/get-started/glossary.md
94
21
link
:white_check_mark:

msteams-platform/mstdd-landing.yml
100
0
link
:white_check_mark:

msteams-platform/samples/integrate-web-apps-overview.md
89
14
link
:white_check_mark:

msteams-platform/samples/integrating-web-apps.md
95
4
link
:white_check_mark:

msteams-platform/sbs-tabs-and-messaging-extensions-with-sso.yml
84
34
link
:white_check_mark:

msteams-platform/tabs/what-are-tabs.md
93
7
link
:white_check_mark:

More info about Acrolinx
Use the Acrolinx extension, or sidebar, in Visual Studio Code to check spelling, grammar, style, tone, clarity, and key terminology when you're creating or updating content. For more information, see Use the Visual Studio Code extension to run Acrolinx locally.

Docs Build status updates of commit 659fc02:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

.openpublishing.redirection.json
:white_check_mark:Succeeded

msteams-platform/get-started/glossary.md
:white_check_mark:Succeeded
View

msteams-platform/mstdd-landing.yml
:white_check_mark:Succeeded
View

msteams-platform/samples/integrate-web-apps-overview.md
:white_check_mark:Succeeded
View

msteams-platform/samples/integrating-web-apps.md
:white_check_mark:Succeeded
View

msteams-platform/sbs-tabs-and-messaging-extensions-with-sso.yml
:white_check_mark:Succeeded
View

msteams-platform/tabs/what-are-tabs.md
:white_check_mark:Succeeded
View

msteams-platform/TOC.yml
:white_check_mark:Succeeded
View

msteams-platform/toolkit/accounts.md
:white_check_mark:Succeeded
n/a (file deleted)

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Acrolinx Scorecards
We currently enforce a minimum score of 80.
Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology:

Article
Score
Issues
Scorecard
Processed

msteams-platform/TOC.yml
98
6
link
:white_check_mark:

msteams-platform/get-started/glossary.md
94
21
link
:white_check_mark:

msteams-platform/mstdd-landing.yml
100
0
link
:white_check_mark:

msteams-platform/samples/integrate-web-apps-overview.md
91
12
link
:white_check_mark:

msteams-platform/samples/integrating-web-apps.md
95
4
link
:white_check_mark:

msteams-platform/sbs-tabs-and-messaging-extensions-with-sso.yml
87
28
link
:white_check_mark:

msteams-platform/tabs/what-are-tabs.md
93
7
link
:white_check_mark:

More info about Acrolinx
Use the Acrolinx extension, or sidebar, in Visual Studio Code to check spelling, grammar, style, tone, clarity, and key terminology when you're creating or updating content. For more information, see Use the Visual Studio Code extension to run Acrolinx locally.

Docs Build status updates of commit 0a2b21f:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

.openpublishing.redirection.json
:white_check_mark:Succeeded

msteams-platform/get-started/glossary.md
:white_check_mark:Succeeded
View

msteams-platform/mstdd-landing.yml
:white_check_mark:Succeeded
View

msteams-platform/samples/integrate-web-apps-overview.md
:white_check_mark:Succeeded
View

msteams-platform/samples/integrating-web-apps.md
:white_check_mark:Succeeded
View

msteams-platform/sbs-tabs-and-messaging-extensions-with-sso.yml
:white_check_mark:Succeeded
View

msteams-platform/tabs/what-are-tabs.md
:white_check_mark:Succeeded
View

msteams-platform/TOC.yml
:white_check_mark:Succeeded
View

msteams-platform/toolkit/accounts.md
:white_check_mark:Succeeded
n/a (file deleted)

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Acrolinx Scorecards
We currently enforce a minimum score of 80.
Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology:

Article
Score
Issues
Scorecard
Processed

msteams-platform/TOC.yml
98
6
link
:white_check_mark:

msteams-platform/get-started/glossary.md
94
21
link
:white_check_mark:

msteams-platform/mstdd-landing.yml
100
0
link
:white_check_mark:

msteams-platform/samples/integrate-web-apps-overview.md
91
12
link
:white_check_mark:

msteams-platform/samples/integrating-web-apps.md
95
4
link
:white_check_mark:

msteams-platform/sbs-tabs-and-messaging-extensions-with-sso.yml
87
28
link
:white_check_mark:

msteams-platform/tabs/what-are-tabs.md
93
7
link
:white_check_mark:

More info about Acrolinx
Use the Acrolinx extension, or sidebar, in Visual Studio Code to check spelling, grammar, style, tone, clarity, and key terminology when you're creating or updating content. For more information, see Use the Visual Studio Code extension to run Acrolinx locally.

Docs Build status updates of commit 80597e8:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

.openpublishing.redirection.json
:white_check_mark:Succeeded

msteams-platform/get-started/glossary.md
:white_check_mark:Succeeded
View

msteams-platform/mstdd-landing.yml
:white_check_mark:Succeeded
View

msteams-platform/samples/integrate-web-apps-overview.md
:white_check_mark:Succeeded
View

msteams-platform/samples/integrating-web-apps.md
:white_check_mark:Succeeded
View

msteams-platform/sbs-tabs-and-messaging-extensions-with-sso.yml
:white_check_mark:Succeeded
View

msteams-platform/tabs/what-are-tabs.md
:white_check_mark:Succeeded
View

msteams-platform/TOC.yml
:white_check_mark:Succeeded
View

msteams-platform/toolkit/accounts.md
:white_check_mark:Succeeded
n/a (file deleted)

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel


isDraggable: false disallows drop

When I add DragItem and set isDraggable: false I then can't drag it (good in my use case) and I can't drop on it (bad in my use case).
I have a use case where I have items to drag to and drop on other items that themselves are not draggable.
I have three use cases in my situation:

Item is draggable and drobonable
Item is not draggable but is droponable
Item is not draggable and not droponable

BTW Thanks for the Sticky headers. They work very well..
Two documentation updates.
Example 6 where you introduce DragItem you have DrarItem
Also you should indicate that you need to include drag.dart to get DragItem.
Thanks.

Thank you for your feedback. We will work on this and release a new update as soon as possible.

Hi,
Thank you for reaching out to us with your query. We have added a new parameter in DragItem called isDropable, by default it is set to true allowing you to achieve the result that you want,
i.e.

when isDraggable = true & isDropable = true you are allowed to drag and drop child in that spot.

When you pass isDraggable = false but want to accept drops on that spot and it will accept the drop on that spot.

when isDraggable = false & isDropable = false you are not allowed to either drag or drop the child in that spot.

Note: If you want to validate drop on a specific spot please take advantage of the OnWillAccept function.
I hope it solves all of your scenarios. If there is any doubt feel free to reach out to us.

GridView.builder 中没有这个dragStartBehavior属性

@mrLIHUAN I am sorry but we can not understand what you are trying to say. We only understand English.
Thank you


fix calculateWeeksNumber error

because Week of 2020/3 should be 6 but previous algorithm return 5.

Hi @heesung6701 :)
This PR seems big but could you explain more about the error you faced ?

Oh... Sorry, i have mistake during on my job.
I'll remake PR!


[Discuss] Achieving Failover/Failback

Open Questions:

[ ] What RPO guarantees would we serve? Should be as close as possible to 0.
[ ] Do we need quorum based writes to all secondaries? If not, Let's document the reasons.
[ ] How to reconcile state during failover and failback? how to handle conflict resolution?

RPO guarantees haves been discussed here already.
It also talks about why we don't want to go towards a quorum based writes to secondaries(sync replication)

With the current proposal, we want to allow user to configure RPO & RPO for the cluster.

During Failover, secondary cluster will ensure that the latest changes have been pulled from primary's remote store. We can also further enhance this by pulling the latest translog from remote store to ensure minimal data loss during failover.
After old Primary is up, it'll start tracking the new Primary for all the changes.
In the rare cases where follower isn't able to contact primary's remote store, follower needs to decide whether it can failover with configured RPO guarantee(requires a mechanism to track the exact replication lag). If follower can't meet the RPO guarantee, it'll wait for remote store to be available till configured RTO and failover only after applying latest changes. - If we're not able to meet the RPO and RTO, we should still allow user to override & let failover to the secondary.


C Media driver will not work if missing both POLL and EPOLL

Hi,
aeron_udp_transport_poller_poll will always return 0 (work count) when there is more than 5 (AERON_UDP_TRANSPORT_POLLER_ITERATION_THRESHOLD) file descriptors if both poll & epoll are not available.
This happen (at least) on windows.
I think it could be good to add a check that at least one of poll or epoll is available

This is a good idea. Will add it to the TODO list. Or feel free to send a PR.


Unstable repomap breaks caching when nothing has changed

Issue
I'm learning how to minimize costs with aider's caching.  A big part of this is ensuring the read-only files and repo-map do not change between subsequent invocations unless I want them to.
# I want these to share cache for read-only files and repomap.
# They won't share cache for writable files since that's lumped with the prompt, which is different.  But repomap should be identical.
aider <flags> <fileA> -m 'Try ABC'
aider <flags> <fileA> -m 'Try alternative XYZ'

Unfortunately, repomap generation appears to be non-deterministic because it changes between subsequent invocations even when nothing has changed.

First add *.txt to .aiderignore so that creation of repo-map-*.txt can't affect the repomap.  Then generate repomap twice in a row:
$ aider --show-repo-map --encoding utf-8 --no-pretty > repo-map-1.txt
$ aider --show-repo-map --encoding utf-8 --no-pretty > repo-map-2.txt

Or with a read-only file:
$ aider --show-repo-map --encoding utf-8 --no-pretty --read CONVENTIONS.md > repo-map-3.txt
$ aider --show-repo-map --encoding utf-8 --no-pretty --read CONVENTIONS.md > repo-map-4.txt

Diff the output of the two adjacent invocations, ignoring the Updating repo map ⠋ logs which are not part of the repomap.
When not specifying any writable files, I see differences in the set of files it chooses to include in the repomap.  When I specify --read, I see it including method A in the first repomap, omitting it in place of method B in the second.
These differences go away when I specify a very large --map-tokens so that it's not summarized.
Version and model info
aider: running from git clone of 9789668ca4d14d3b6c24e56f3fe956147ea78039
model: N/A, since the repro above does not talk to any model

I found the culprit:
https://github.com/paul-gauthier/aider/blob/12578c0388d1440e573218d86abcc8d411c39bdf/aider/repomap.py#L422
The ordering is not deterministic if items have identical ranks.  Adding a fallback sort by x[0] makes it deterministic.

This should be fixed in the latest version. You can get it like this:
aider --upgrade

# or...

python -m pip install --upgrade aider-chat

If you have a chance to try it, let me know if it works better for you.
I'm going to close this issue for now, but feel free to add a comment here and I will re-open. Or feel free to file a new issue any time.


configurable pod annotations

users may want to provide pod annotations and currently there is no option to configure this in the helm chart.

This can be closed. Thanks.


Always show all tooltips

Hi!
I need always show my tooltips, but (if I understand) I can only hide all tooltips or show only one. Maybe who have any idea?

Hi. Not sure you can do something easier than append html elements with d3js and position them based on coordinates from .c3-event-rects.

@SergeyPensov Do you want to not hide tooltip shown?
In that case you can override hide method, which even after mouseout the tooltip layer will maintained diplayed.
c3.chart.internal.fn.hideTooltip=function(){};

Here it is. maybe ugly but enough?
https://jsfiddle.net/yasu47b/kkr9a8tg/

Workaround provided with no response from submitter.
Seems like such an edge case it's not worth supporting by default.


update image repo

This pr attempts to update the container repository to ghcr and renames the containers.
old >> new
quay.io/kubecost1/kubecost-cost-model >> ghcr.io/opencost/opencost
quay.io/kubecost1/opencost-ui >> ghcr.io/opencost/opencost-ui
Another specific change is the move from prod-vX.Y.Z to X.Y.Z

LGTM, the opencost repo needs to be updated too.

https://github.com/opencost/opencost/pull/2564

I've rolled this up in https://github.com/opencost/opencost-helm-chart/pull/179

This one was merged as part of: https://github.com/opencost/opencost-helm-chart/pull/179


[bug] iOS Came import file name

All the files uploaded from iOS Camera are named the same: „file.jpg”. The file uploaded let you upload only one file with the same name which is clearly a bug in this use case.
Remove the limitation for file names OR rename files when uploading (or do both)

Moreover - the record form should distinguish while adding attachments the type of them; every PDF should be added as a separate record but images should be done within single record because the subsequent images are probably the next pages of the same document


gitignore: Ignore package-lock.json generated by npm.

Refer to https://chat.zulip.org/#narrow/stream/code.20review/subject/pull.20request for discussion.

@aero31aero thanks for fixing this!  In the future, I'd include the references to details about why we did something in the commit message (I just copied it in there when merging), so future developers can read that history.


Preact + Styled Components + Storybook

Posted by @phunkren in slack:
I managed to reproduce the Preact | Styled Components | Storybook issue we spoke about yesterday. For the repro, I created a project with preact-cli and upgraded preact to X.
Repo: https://github.com/phunkren/preact-storybook-sc
npm i
npm run storybook

It turns out it was just a compat issue for styled-components. Defining a ./storybook/webpack.config.js file with the proper aliases solved it.
Here's the webpack config:
module.exports = ({ config }) => {
    config.resolve.alias = Object.assign({}, config.resolve.alias, {
        react: "preact/compat",
        'react-dom': 'preact/compat'
    })

    return config;
}

All in all, preact x works great with storybook! 😄


Feature for Queryresult, to return primary key

It would be nice to have second parameter as array of Primary keys
var df = db.values('sales');
  df.done(function (items) {
	console.log(items);
  });

to smth
var df = db.values('sales');
  df.done(function (items,pks) {
	console.log(items);
        console.log(pks); // Echo primary keys
  });

It is not possible with Promise. You have to use db.open or db.scan to get both value and key.


ILX cleanup Part 2

More cleanup like #1236, gradually eliminating the unnecessary ILX --> IL phase and doing it directly during  codegen  in IlxGen.fs

Merging as this is cleanup and all is green

:heart:


Infinite loop in gpr

What version of gRPC and what language are you using?
1.24.2, C++11
What operating system (Linux, Windows,...) and version?
$ uname -a
Linux xps 4.19.85-1-MANJARO #1 SMP PREEMPT Thu Nov 21 10:38:39 UTC 2019 x86_64 GNU/Linux

What runtime / compiler are you using (e.g. python version or version of gcc)
$ clang -v
clang version 9.0.0 (tags/RELEASE_900/final)
Target: x86_64-pc-linux-gnu
Thread model: posix
...

CC=clang CXX=clang++
What did you do?
Our code is very simple. Just connect from C++ client to java server with InsecureChannelCredentials.
std::string ip = "<IP_ADDRESS>";
std::string port = "19012";
std::shared_ptr<Channel> channel = grpc::CreateChannel(ip + ":" + port, grpc::InsecureChannelCredentials());

CreateChannel hangs forever (in infinite loop), both with java service being online/offline.
Bug can be reproduced with or without GRPC_* env vars defined.
If we define these ENV vars:
export GRPC_VERBOSITY=DEBUG
export GRPC_TRACE=all

And run our binary, you can see this:
D1123 20:20:56.903306023   25004 ev_posix.cc:174]            Using polling engine: epollex
D1123 20:20:56.908538708   25004 dns_resolver_ares.cc:503]   Using ares dns resolver

htop shows 100% CPU load, and process hangs (even CTRL+C does not kill it).
I tried all options for GRPC_POLL_STRATEGY (epoll, poll, legacy), but only poll seems to be working.
Also I tried GRPC_DNS_RESOLVER (ares, native), both stuck on the same place.
This bug can be reproduced on Linux and can not be reproduced on Windows. We did not test MACs.
We did not investigate this bug in details, but it seems that it comes from the GRPC_TRACE or GPR_DEBUG env var processing code, as this little hack solves the issue (only if GRPC_TRACE=all):
diff --git a/src/core/lib/debug/trace.cc b/src/core/lib/debug/trace.cc
index 84c0a38..b3d742f 100644
--- a/src/core/lib/debug/trace.cc
+++ b/src/core/lib/debug/trace.cc
@@ -39,9 +38,11 @@ namespace grpc_core {
 TraceFlag* TraceFlagList::root_tracer_ = nullptr;
 bool TraceFlagList::Set(const char* name, bool enabled) {
+gpr_log(GPR_DEBUG,"TraceFlagList::Set '%s'", name);
   TraceFlag* t;
-  if (0 == strcmp(name, "all")) {
+  if (0 == strcmp(name, "all")) { return true;
     for (t = root_tracer_; t; t = t->next_tracer_) {
+gpr_log(GPR_DEBUG,"enabling tracer");
       t->set_enabled(enabled);
     }
   } else if (0 == strcmp(name, "list_tracers")) {

Anything else we should know about your project / environment?
std=C++11
Protobuf - v3.10.0
gflags - v2.2.2
cares - cares-1_15_0

I tried earlier version of GRPC. This bug exists in v1.21.1

Found this comment

GRPC library contains tracing subsystem, and initialization of trace flags is done as static init (init of static variables). Internally, each init code adds trace flag metadata to shared linked list. For some reason, in my app, before main(), each static init is called twice (I admit i have to spend some efforts to investigate, but unfortunately I have other things to do). Linked list, due to reinvention of the wheel, is written the way which is causing circular references if same elements are added twice, and any subsequent internal effort to traverse resulting list causes infinite loop. Had to patch it. If I link against libraries provided by system package manager, it shows same behavior. Note that grpc init is first stuff in my app main() function, and I don't use static init in my own code.

https://gitter.im/grpc/grpc?at=5d91cda8086a72719e8baaa7

grpc::InsecureChannelCredentials()

is the cause of infinite loop. digging further..

+1
CentOS 6, grpc 1.25x, g++ 6.0+

Same issue

#21507
#21552
#21548

Please fix this issue.

This issue should be P1.
Same issue here: https://github.com/grpc/grpc/issues/21213
Please fix !


Update documentation

The readme needs to be updated to the current usage
$ python3  -m junit2htmlreport -h

usage: junit2html [-h] [--summary-matrix] [--report-matrix REPORT] [--max-failures FAILURES] [--max-skipped SKIPPED] [--merge NEWREPORT] REPORT [REPORT ...] [OUTPUT]

positional arguments:
  REPORT                Test file to read
  OUTPUT                Filename to save the html as

optional arguments:
  -h, --help            show this help message and exit
  --summary-matrix      Render multiple result files to the console
  --report-matrix REPORT
                        Generate an HTML report matrix
  --max-failures FAILURES
                        Exit non-zero if FAILURES or more test cases are failures (has no effect with --merge)
  --max-skipped SKIPPED
                        Exit non-zero if SKIPPED or more test cases are skipped (has no effect with --merged)
  --merge NEWREPORT     Merge multiple test results into one file

Question

Should the gitlab links be changed to github links in both readme and the pypi?

Hiya @kishaningithub I will refresh the readme a little, the gitlab links are accurate, this is just a mirror of the gitlab repo


Upgrade to latest thermodynamics

This PR upgrades to the latest Thermodynamics, which uses RelativeSolutionTolerance.

Results look fine

bors r+


Shortcut for toggle location list

Please add a new command, something like :ToggleErrors, so people can map a key to open/close the Location window.

Just a quick snippet I put together for future references. Someone might find it useful. I wanted to have a Toggle Button to open and close the location list and managed to get it working like this
    map <F8> <ESC>:call SyntasticToggle()<CR>

    let g:syntastic_is_open = 0
    function! SyntasticToggle()
    if g:syntastic_is_open == 1
        lclose
        let g:syntastic_is_open = 0
    else
        Errors
        let g:syntastic_is_open = 1
    endif
    endfunction

This way my location list open and closes everytime I press F8 in Normal Mode.

Just a quick snippet I put together for future references. Someone might find it useful. I wanted to have a Toggle Button to open and close the location list and managed to get it working like this
    map <F8> <ESC>:call SyntasticToggle()<CR>

    let g:syntastic_is_open = 0
    function! SyntasticToggle()
    if g:syntastic_is_open == 1
        lclose
        let g:syntastic_is_open = 0
    else
        Errors
        let g:syntastic_is_open = 1
    endif
    endfunction

This way my location list open and closes everytime I press F8 in Normal Mode.

Nice function to toggle the loc_list @macskay
The only problem that I saw with it is that if you have let g:syntastic_check_on_open = 1 and let g:syntastic_always_populate_loc_list = 1 and your file has errors or warnings when you open it the loc_list will show up automatically. When that happens and you press F8, this will not trigger the loc_list to disapear as you assigned 0 as the first value in your function. When you press F8 again, everything starts working fine. That is not a big issue but I decided to play with it a little and came up with the followingm, which toggles the loc_list every time.

map <F8> <ESC>:call SyntasticToggle()<CR>

function! SyntasticToggle()
  let g:wi = getloclist(2, {'winid' : 1})
  if g:wi != {}
    lclose
  else
    Errors
  endif
endfunction


TabFolder should have more styling capabilities

Currently we are only able to set textColor and background on a tabfolder. The textColor color does not provide enough information to provide the desired styling on ios and android.
We should be able to set individual colors for active tab, inactive tab, tabs background and an "accent color". Some more discussion is required for the exact properties.
For Android see http://www.google.com/design/spec/components/tabs.html. On ios the uisegmentedcontrol is used.

+1

+1

Hiding the tab bar would also be very useful and could make this an alternative to the swipe widget.

+1 for hiding tabs as an alternative for a swipe widget

In Tabris 1.5, it will be possible to hide the tab bar by setting tabBarLocation: "hidden" (commit b4ba9b3cfdf80b8f060c10ebb144ec7e8dbe0284).

On Android, we could support these additional properties:

active and inactive text color, we could add textInactiveColor in addition to textColor
active and inactive icon color, we could add iconColor and iconInactiveColor
color of the indicator on selected tab, indicatorColor
elevation of the tab bar, which is different from the elevation of the tab folder, tabBarElevation
alignment of tabs, e.g. alignment or tabBarAlignment, values could be "left", "fill", ...

The additional properties are out of scope for 1.5, since the implementation would be based on a newer Android widget.

We could also add a tabBarBackground property which colorizes the background of the tab bar. Currently You have to set the regular background on the tabfolder and than set the background of each page back to eg "white".

+1
It would be great to be able to affect the tab alignment on the tab bar.

@exocom What styling properties would you like to see for the alignment?

@mpost Would like to see left/right aligned tabs.
Example on android when TabFolder only has 1 Tab it is in the center. It doesn't look right.
||TAB 1||
Being able to left align would look much better
|TAB 1|_________|

@exocom Are you referring to the left keyline as demonstrated by the first image from Android's Material design guidelines?

versus

We are using the TabLayout from the material design library to render the tab strip. It has the two modes scrollable and fixed while we settled on fixed as the default since it is more in line of the typical dashboard/start page pattern we see in android apps.
https://developer.android.com/reference/android/support/design/widget/TabLayout.html#setTabMode(int)

@cookieguru Exactly!

Setting the indention of the Tab bar is currently not possible. We have discussed to separate the TabFolder into two seperate widgets but haven't gotten around to that yet.

indicatorColor for tabFolder : is it possible ? - currently it is showing only default green tinge.

@natanraj Currently you can only set the textColor which affects the underline color as well.
If you want to customize it completely you can provide your own android theme which overrides the look of the default TabFolder.

I think the textColor is  more than enough for time being.

Covered by https://github.com/eclipsesource/tabris-js/issues/1676


react native web support

I'd like this repo to support react-native-web. I put in a PR for it.

Any movement on this that you know of @raarts ? It would be a wonderous day for this to work on web!

Working on it, but web support for Expo has my priority, see this PR: https://github.com/expo/expo-sdk/pull/107

That is OUTSTANDING @raarts , I like where your head is at!


raftstore, backup: fix test_read_hibernated_region & test_writer

Signed-off-by: 5kbpers<EMAIL_ADDRESS>
What have you changed?
TiKV 3.x disables hibernate regions by default.😢
Fix the test by enabling hibernate regions.
What is the type of the changes?

Bugfix (a change which fixes an issue)

How is the PR tested?

Unit test

Close #6974

/run-all-tests

/merge


Realm Groups not importing

Current Behavior
  "groups": [
    {
      "attributes": {},
      "clientRoles": {},
      "id": "4034db60-e18c-49fc-b024-92b38b094874",
      "name": "group-name",
      "path": "/group-name",
      "realmRoles": [
        "role1",
        "role2",
        "role3",
        "role4"
      ],
      "subGroups": []
    }
  ],

Groups config isn't imported
in Keycloak UI (for the correct realm) I see the following message when opening grroups:
No groups in this realm
You haven't created any groups in this realm. Create a group to get started.

Expected Behavior
When importing the config, I expect the groups to be imported as well.
If I import the same config with the Keycloak UI (partial import) and select groups it correctly imports the groups. I expect the CLI to also import groups.
Steps To Reproduce
1) import a config with groups
2) notice groups are not imported
3) ensure the groups config is correct by importing the config with keycloak UI
4) notice groups are imported correctly

Environment
Eveything is dockerised:

Keycloak Version: quay.io/keycloak/keycloak:23.0.7
keycloak-config-cli Version: adorsys/keycloak-config-cli:latest-23.0.7

Anything else?
No response

Apologies, I mixed up the logs, this is a duplicate of #877


feat: add logger to parse functions

add logger param to parse function
update description in the UI
unrelated: change 'Save' to 'Update' (no save done here

@ahochsteger I would also add the node object, before the logger :) ALso remember to update docs

@ahochsteger I would also add the node object, before the logger :) ALso remember to update docs

@ahochsteger I would also add the node object, before the logger :) ALso remember to update docs

Good idea, will add it and have a look at the docs ...

@ahochsteger I would also add the node object, before the logger :) ALso remember to update docs

Good idea, will add it and have a look at the docs ...

@ahochsteger I would also add the node object, before the logger :)

How would I get the node object in evalFunction() as it just has access to code, valueId and value?
Or did you mean the valueId object?

@ahochsteger I would also add the node object, before the logger :)

How would I get the node object in evalFunction() as it just has access to code, valueId and value?
Or did you mean the valueId object?

Ok, I can add it to evalFunction as 4th argument.
Does it make sense to provide valueId as well as it may contain more interesting information?

Ok, I can add it to evalFunction as 4th argument.
Does it make sense to provide valueId as well as it may contain more interesting information?

@ahochsteger Yep I would add in order (value, valueId, node, logger)

@ahochsteger Yep I would add in order (value, valueId, node, logger)

@ahochsteger Yep I would add in order (value, valueId, node, logger)

Done locally.
What about the receive parse function?
There doesn't seem to be a node object available in parsePayload(payload, valueId, valueConf).
Should I pass an empty object ({}) or null?

@ahochsteger Yep I would add in order (value, valueId, node, logger)

Done locally.
What about the receive parse function?
There doesn't seem to be a node object available in parsePayload(payload, valueId, valueConf).
Should I pass an empty object ({}) or null?

Pull Request Test Coverage Report for Build 503842072

1 of 11 (9.09%)  changed or added relevant lines in 1 file are covered.
4 unchanged lines in 1 file lost coverage.
Overall coverage decreased (-0.005%) to 23.377%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

lib/Gateway.js
1
11
9.09%

Files with Coverage Reduction
New Missed Lines
%

lib/Gateway.js
4
18.15%

Totals

Change from base Build 503786044:
-0.005%

Covered Lines:
2009

Relevant Lines:
8795

💛  - Coveralls

Pull Request Test Coverage Report for Build 503842072

1 of 11 (9.09%)  changed or added relevant lines in 1 file are covered.
4 unchanged lines in 1 file lost coverage.
Overall coverage decreased (-0.005%) to 23.377%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

lib/Gateway.js
1
11
9.09%

Files with Coverage Reduction
New Missed Lines
%

lib/Gateway.js
4
18.15%

Totals

Change from base Build 503786044:
-0.005%

Covered Lines:
2009

Relevant Lines:
8795

💛  - Coveralls

I'm using an empty object for node for now at the receive part.

I'm using an empty object for node for now at the receive part.


disable Pic-In-Pic for Slides

There are many congress recordings e.g. LoraWAN where the operator selected Pic in pic in favor of super source. The pic of the speaker always overlays the content of the slides. As this makes no sense we could disable pic in pic for any combination where A is the grabber.

Related: https://github.com/voc/voctomix/issues/120


filter ccs.bam on predicted accuracy?

With the old isoseq the bam had a tag which could be used for filtering on accuracy:
-tag "rq:>0.999"
In the Isoseq3 ccs.bam I do not see such a tag. There is a tag for the number of subreads(=passes) for each read "np:i", but not a accuracy tag.
Is it still possible to filter on this tag?
I am asking this because in that way I can run the ccs creation once, with numpasses=1. For any other analysis later I could filter the ccs output. Currently I run the ccs part multiple times, which is quite expensive.

This is because we do not polish ccs reads in our workflow. Feel free to run ccs the way you want and then either use datasets to filter on the rq tag or wait until I implemented the rq-filter in isoseq3 cluster.

After consideration, please use our lightweight dataset filters. If you don't have SMRTLink installed
conda install pbcoretools

And then filter based on the consensusreadset.xml (implicitly using the pbi):
dataset filter ccs.consensusreadset.xml ccs.filtered.consensusreadset.xml "rq>0.999"

Which adds following block to the xml:
	<pbds:Filters>
		<pbds:Filter>
			<pbbase:Properties>
				<pbbase:Property Name="rq" Operator=">" Value="0.999"/>
			</pbbase:Properties>
		</pbds:Filter>
	</pbds:Filters>

This file can be used as input for isoseq3, which respects dataset filters.
Keep in mind, predicted accuracy is stored as a float.
Let me know if that does not work. I'll close it for now, but will be informed by mail if you comment.


api_documentation: Update rate limit error description.

Moves details about the rate limit error object and handling to the OpenAPI documentation description for that common error. Previously, this information was on the general rest error handling documentation page without clear connection to the specific rate limit error. See this CZO chat for more context.
Also, fixes a typo in the change log (feature 36) for that same error and a misplaced colon in the description of the error
for missing request parameters.
Screenshot of updated error description:

Updated screenshot with HTTP header text removed:

Merged, thanks @laurynmm!


SplitLineCollection attempt to access a newer model

Sorry @alexandrudima I have no steps, just the stack trace and I can not reproduce
Feel free to close, opening more as a FYI
SplitLinesCollection: attempt to access a 'newer' model: Error: SplitLinesCollection: attempt to access a 'newer' model
    at SplitLinesCollection._ensureValidState (file:///Users/isidor/Development/vscode/out/vs/editor/common/viewModel/splitLinesCollection.js:82:23)
    at SplitLinesCollection.getViewLineMinColumn (file:///Users/isidor/Development/vscode/out/vs/editor/common/viewModel/splitLinesCollection.js:403:18)
    at ViewModel.getLineMinColumn (file:///Users/isidor/Development/vscode/out/vs/editor/common/viewModel/viewModelImpl.js:286:31)
    at new ViewportData (file:///Users/isidor/Development/vscode/out/vs/editor/common/viewLayout/viewLinesViewportData.js:20:92)
    at View._actualRender (file:///Users/isidor/Development/vscode/out/vs/editor/browser/view/viewImpl.js:275:32)
    at file:///Users/isidor/Development/vscode/out/vs/editor/browser/view/viewImpl.js:252:56
    at safeInvokeNoArg (file:///Users/isidor/Development/vscode/out/vs/editor/browser/view/viewImpl.js:418:20)
    at View._renderNow (file:///Users/isidor/Development/vscode/out/vs/editor/browser/view/viewImpl.js:252:13)
    at View._flushAccumulatedAndRenderNow (file:///Users/isidor/Development/vscode/out/vs/editor/browser/view/viewImpl.js:127:18)
    at View.render (file:///Users/isidor/Development/vscode/out/vs/editor/browser/view/viewImpl.js:367:22)

Duplicate of #44805


Logging in when already logged in redirects to front page

Description
When you log in on one browser tab, and then press the login button on another tab, it redirects to the front page.

Open https://try.gitea.io/drSybren/skyfill in a browser tab.
Open https://try.gitea.io/drSybren/skyfill in another browser tab.
In the first tab, log in. This redirects you to the same URL you pressed the login button on.
In the second tab, click the login button.
You're now redirected to the front page, https://projects.blender.org/.

I would expect to end up on the same URL, just like the first login did.
Note that this behaviour is always seen, not just when using two the same URLs in those tabs. It just made testing easier.
Screenshots
This is not a graphical glitch, so can't be caught in a screenshot.
Gitea Version
1.20.0+dev-1026-ge29ab5442
Can you reproduce the bug on the Gitea demo site?
Yes
Operating System
No response
Browser Version
Brave 1.52.126

Checked in latest version 1.22.0+dev-1113-g99d7ef509, it seems that this issue has been fixed.
Can you confirm it again? Thanks.

Oh yes, it should have been fixed by " Make "/user/login" page redirect if the current user has signed in #29583 " (and backported to 1.21)
Feel free to reopen if there is still any problem. Thank you!

I can confirm this was fixed, thanks!


Theme Storage toggle failed in Content script example

Describe the bug
In Chrome Devtool, the theme toggle failed: the initial theme and toggled theme are both "light"
To Reproduce
Steps to reproduce the behavior:

Go to 'Chrome Devtool'
Click on 'Console' tab

Expected behavior
'toggled theme light' should be shown as 'toggled theme dark'
Screenshots

Desktop (please complete the following information):

OS: [Mac]
Browser [chrome]
Node Version [18.12.0]

#339


cdk synth error on generated code

I started with this template: https://github.com/awslabs/aws-cloudformation-templates/blob/master/aws/solutions/LambdaStaticIP/lambda-static.cfn.yaml
Downloaded it locally and run "cdk migrate --stack-name "evgeny" --language "typescript" --from-path lambda-static.cfn.yaml"
The CDK app was generated successfully.
Run "cdk synth" generates "Error: There is already a Construct with name 'PublicSubnetOne' in EvgenyStack [evgeny]"
cdk version: 2.106.1 (build a2e5f65)

The source template: lambda-static.cfn.yaml.txt
Auto-generated code: evgeny-stack.ts.txt


[feat] Dynamic Bash/Fish tab completion for CLI

Is your feature request related to a problem? Please describe.
It can be tricky to remember all package names and tasks when using the CLI. This results in me digging through files or trying to guess.

Describe the solution you'd like
A tab completion function, similar to this git-completion.bash script that would dynamically use the data in moon.yml files.

Describe alternatives you've considered
I'm not sure there is an alternative.

Additional context
If this already exists I was having a hard time finding it, so maybe I'm using the wrong keywords.

@GarthDB We have moon completions but that's just for the built-in commands. I'm assuming you want it to also auto-complete all the available tasks/projects/etc? If so, it's blocked on this currently (unless we build our own engine): https://github.com/clap-rs/clap/issues/3166


Horizontal Scroll is missing in document editor

Is your feature request related to a problem? Please describe.
When editing documents with long strings, there is no horizontal scroll.
Describe the solution you'd like
I'd like a horizontal scrollbar that displays when the line is longer than the input container.
Describe alternatives you've considered
I can use my keyboard to navigate, but it's not that efficient.
Additional context

The horizontal scrollbar is also missing in (storage) Table View after you've entered a Query. When the result of the query is shown, the horizontal scrollbar and the count-summary is missing. Resize the (main) window and it reappears. Bloody annoying. [2c]

Azure Storage Explorer support for Azure Cosmos DB has been discontinued as of v1.24.0. We recommend users to use Azure Cosmos DB’s Data Explorer, which can be found in Azure Portal or as a stand-alone version in http://cosmos.azure.com/ for the best Azure Cosmos DB experience. You can also find additional Azure Cosmos DB tooling here: Azure Cosmos DB Tools


v0.2-update-modules: feat: define Device Type at build time

chore: added utility macro IS_NULL_OR_EMPTY
feat: define Device Type at build time

Porting #85

@larsewi Generally speaking, when porting PRs to other branches unless there are substantial conflicts that were resolved and need a re-review, we can just merge as soon as we get a :green_circle:


Failed to align when lengths of PID are greater than 5.

The application is very convenient but I ran into alignment issues when the PID is too long.
+-----------------------------------------------------------------------------+
|  GPU   PID     USER    GPU MEM  %CPU  %MEM      TIME  COMMAND               |
|    0  3753     root       4MiB   0.0   0.0  18:13:36  /usr/lib/xorg/Xorg v  |
|    0 164425     xxxx   10647MiB   106   0.3     35:59  python main.py -i 6   |
|    1  3753     root       4MiB   0.0   0.0  18:13:36  /usr/lib/xorg/Xorg v  |
|    1 161143     xxxx   10923MiB   100   0.6     59:46  python main.py -i 1   |
|    2  3753     root       4MiB   0.0   0.0  18:13:36  /usr/lib/xorg/Xorg v  |
|    2 161102     xxxx   10731MiB   100   0.6  01:00:02  python main.py -i 1   |
|    3  3753     root       4MiB   0.0   0.0  18:13:36  /usr/lib/xorg/Xorg v  |
|    3 160197     xxxx   10195MiB   141   0.6  01:00:49  python main.py -i 1   |
|    4  3753     root       4MiB   0.0   0.0  18:13:36  /usr/lib/xorg/Xorg v  |
|    4 160481     xxxx   11099MiB   101   0.4  01:00:40  python main.py -i 3   |
|    5  3753     root       4MiB   0.0   0.0  18:13:36  /usr/lib/xorg/Xorg v  |
|    5 159486     xxxx   10761MiB   101   0.4  01:01:59  python main.py -i 3   |
|    6  3753     root       4MiB   0.0   0.0  18:13:36  /usr/lib/xorg/Xorg v  |
|    6 159424     xxxx   10623MiB  98.2   0.5  01:02:30  python main.py -i 5   |
|    7  3753     root       4MiB   0.0   0.0  18:13:36  /usr/lib/xorg/Xorg v  |
|    7 159383     xxxx   10311MiB  98.7   0.5  01:02:53  python main.py -i 5   |
+-----------------------------------------------------------------------------+

I patched this with the following starting on line 167:
+ max_pid_length = max([len(x) for x in pid])
+ if max_pid_length >= 6:
+     command_length -= (max_pid_length - 6)

+ format = ("|  %3s %" + str(max_pid_length) + "s %8s   %8s %5s %5s %9s  %-" + str(command_length) + "." + str(command_length) + "s |")
- format = ("|  %3s %5s %8s   %8s %5s %5s %9s  %-" + str(command_length) + "." + str(command_length) + "s  |")

This worked for me.

Thanks, the proposed patch looks good. Do you want to send it as a pull request to get the proper credit for it?

Thanks. But I install nvidia-htop through pip and it is inconvenient to modify the code on multiple machines. I really appreciate it if you send it as a pull request.

I patched this with the following starting on line 167:
+ max_pid_length = max([len(x) for x in pid])
+ if max_pid_length >= 6:
+     command_length -= (max_pid_length - 6)

+ format = ("|  %3s %" + str(max_pid_length) + "s %8s   %8s %5s %5s %9s  %-" + str(command_length) + "." + str(command_length) + "s |")
- format = ("|  %3s %5s %8s   %8s %5s %5s %9s  %-" + str(command_length) + "." + str(command_length) + "s  |")

This worked for me.

No problem, I just wanted to give you the opportunity to claim the credit. I'll make the release shortly

You're good! I was in a meeting. I don't care about the credit, it's just an if statement.

The release is out. I needed to do a bit more changes to satisfy the automated tests.
I also added a test for your case with longer PIDs. Could you please review files https://github.com/peci1/nvidia-htop/blob/master/test/FAKE_STDIN_LONG_PIDS and https://github.com/peci1/nvidia-htop/blob/master/test/FAKE_PS_LONG_PIDS and report to me whether your output looks similar (mostly regarding to the number of spaces/lengths of rows). The first one corresponds to the output of nvidia-smi, the latter one to the output of ps -o "pid,user,%cpu,%mem,etime,command".

The PIDs I have are in the 7-digits while @rookielxy had 6-digits, so I think it's good. Here's my nvidia-smi:
Tue Aug 31 12:10:51 2021
+-----------------------------------------------------------------------------+
| NVIDIA-SMI 460.91.03    Driver Version: 460.91.03    CUDA Version: 11.2     |
|-------------------------------+----------------------+----------------------+
| GPU  Name        Persistence-M| Bus-Id        Disp.A | Volatile Uncorr. ECC |
| Fan  Temp  Perf  Pwr:Usage/Cap|         Memory-Usage | GPU-Util  Compute M. |
|                               |                      |               MIG M. |
|===============================+======================+======================|
|   0  GeForce RTX 3090    Off  | 00000000:01:00.0  On |                  N/A |
|  0%   43C    P8    25W / 350W |  19515MiB / 24265MiB |      4%      Default |
|                               |                      |                  N/A |
+-------------------------------+----------------------+----------------------+
|   1  GeForce RTX 3090    Off  | 00000000:21:00.0 Off |                  N/A |
|  0%   44C    P8    25W / 350W |  16219MiB / 24268MiB |      0%      Default |
|                               |                      |                  N/A |
+-------------------------------+----------------------+----------------------+

+-----------------------------------------------------------------------------+
| Processes:                                                                  |
|  GPU   GI   CI        PID   Type   Process name                  GPU Memory |
|        ID   ID                                                   Usage      |
|=============================================================================|
|    0   N/A  N/A    658723      C   .../jupyterNLPenv/bin/python    18887MiB |
|    0   N/A  N/A   1429000      G   /usr/bin/gnome-shell               57MiB |
|    1   N/A  N/A    658723      C   .../jupyterNLPenv/bin/python    16201MiB |
+-----------------------------------------------------------------------------+

Here are my PIDs from ps -o "pid,user,%cpu,%mem,etime,command" as well:
    PID USER     %CPU %MEM     ELAPSED COMMAND
1429344 sjwhitak  0.0  0.0       52:42 bash
1429538 sjwhitak  9.1  0.8       52:00 /usr/lib/firefox/firefox
1429624 sjwhitak  6.5  0.8       52:00 /usr/lib/firefox/firefox -contentproc -c
1429671 sjwhitak  0.4  0.2       52:00 /usr/lib/firefox/firefox -contentproc -c
1429760 sjwhitak  0.0  0.1       51:52 /usr/lib/firefox/firefox -contentproc -c
1429824 sjwhitak  0.0  0.0       51:46 /usr/lib/firefox/firefox -contentproc -p
1440708 sjwhitak  0.0  0.0       00:00 ps -o pid,user,%cpu,%mem,etime,command

and this is nvidia-htop without the header (it's the same as nvidia-smi):
+-----------------------------------------------------------------------------+
|  GPU     PID     USER    GPU MEM  %CPU  %MEM      TIME  COMMAND             |
|    0  658723  xxxxxxx   18887MiB   1.1  10.1    2 days  /home/xxxxxxx/jupyt |
|    0 1429000 sjwhitak      36MiB   1.5   0.4     56:20  /usr/bin/gnome-shel |
|    1  658723  xxxxxxx   16201MiB   1.1  10.1    2 days  /home/xxxxxxx/jupyt |
+-----------------------------------------------------------------------------+

I'm not really sure what you want me to verify, sorry. I'd say the test files look good to me, though.


Support a serialization_configuration option for native_image

Fixes #465

Thanks @chrismgrayftsinc for this contribution and for that edit; I hate to ask and might even remove the requirement. This will make it into the next release and of course you'll be credited. Cheers!


Need slides for Developer Intermediate content

Site had broken links to gist content. We need to provided slides and a link with the equivalent content:

[ ] Code analysis
[ ] Image registry
[ ] Artifact management
[ ] Inventory Backend
[ ] Inventory BFF

In progress. Will put it in onedrive and then update dev intermediate agenda for the first Code Analysis,Artifact Management & Image Registry


Switch to realtime gameplay instead of turn-based gameplay

Maybe world will be more alive this way. See also #5.

Definitely not in near future.


Refactor cluster.py

The cluster.py module in interfaces/ in the master branch needs refactoring to work with refactored f5-common-python code. It should be ported over wherever makes sense in the new common python structure.

Below are notes from @swormke relating to this module:
There are multiple objects in there we need to create.

  • `cm/` - Which looks like it has a new method called `sync()` that we will need to support in addition to `CURDL` methods.
  • `cm/device`
  • `cm/device-group`
  • `cm/traffic-group`

There is also this SOAP helper, that we need to figure out if we can have equivalent functionality in REST.
self.mgmt_trust = self.bigip.icontrol.Management.Trust

In v12 we now have the ability to set and reset device trusts. Requests would be sent to the following 2 URIs:
/mgmt/tm/cm/addToTrust
/mgmt/tm/cm/removeFromTrust
Resource links only support POST,OPTIONS.
I have attached some examples of the REST calls in python to this comment (it will contain my additional observations that may/may not be helpful)
example.py.txt
Additionally  the v12 REST API reference indicates that we should also support configuring of custom cert/key pairs to be used with trust setup, as well as whole trust domains. The certificate files need obviously need to be present in file store first. Rest endpoints for this are as follows:
/mgmt/tm/cm/cert
/mgmt/tm/cm/key
/mgmt/tm/cm/trustDomain

One other thing of note, in regards to the closed Issue #302. It seems the following REST endpoint provides much more information regarding failover status,  it actually shows the unit's fail-over state per traffic-group, which could be useful with N+1 cluster deployments. Might be worthwhile looking at implementing this, while reworking CM module:
/mgmt/tm/cm/failoverStatus

I think this is in the scope of @pjbreaux 's current effort.

Issue Review: I believe this can be closed as most of the above has been addressed and rest is worked via #400

Another duplicate of #400.

Agreed commenting in #400, and closing.


Attempted merge

This is an attempted merge from the 1.4.5 hotfix into develop

Coverage decreased (-11.4%) to 53.463% when pulling 8b7174882449363a221e72100a2b55db6016aa9e on 1.4.5_merge into 41d9c785ae05a8340e06a77f4f0d542008de3615 on develop.


Base64 decoding for JSON byte data

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Clipper-PRB/435/
Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Clipper-PRB/436/
Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Clipper-PRB/437/
Test FAILed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Clipper-PRB/438/
Test PASSed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Clipper-PRB/448/
Test FAILed.

jenkins test this please

LGTM. Waiting for the tests to pass.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Clipper-PRB/451/
Test PASSed.


go get -u github.com/kgretzky/evilginx2 give me error

I CONFIRM
I have this error :
package evilginx2/core: unrecognized import path "evilginx2/core" (import path does not begin with hostname)
package evilginx2/database: unrecognized import path "evilginx2/database" (import path does not begin with hostname)
package evilginx2/log: unrecognized import path "evilginx2/log" (import path does not begin with hostname)

Fixed with https://github.com/kgretzky/evilginx2/commit/5afb6d95a32f64adf28a861118faa9f489bc90d9


Make pills require biomass to produce

About the PR

ChemMaster now requires biomass to produce pills (1 biomass per pill).
Why: to stop chems from making unhealthy amount of pills and instead use bottles and other solutions to heal people.
realism

Media

Changelog

:cl:

tweak: Pills require biomass to produce (1 to 1) in ChemMaster.

hardcore mode

also realistically biomass might need a secondary source of being obtained for this to reasonably go through due to player skissue

also realistically biomass might need a secondary source of being obtained for this to reasonably go through due to player skissue

Maybe plant source even? Like compost.

Is there a design doc for all the changes you intend to make.

please make a design doc smiley face emoji exclamation point

please make a design doc smiley face emoji exclamation point

Do we use hackmd.io for this? I don't have access tho.

This is basically a poor solution to the widespread ghetto chem rework that is planned. As outlined in various issues, chems should be obtainable by various means through different departments. This implementation has quite a few core issues with how it works.

Biomass isn't something that can be acquired from multiple places. The only way to get biomass is from reclaiming bodies, which departments can't actually supply (besides cargo, but cargo can supply anything). This means that chems becomes like cloning: linked directly to the amount of death on station. This doesn't work for cloning though, because chemicals are meant to be for living players, and thus shouldn't be tied to the amount of dead ones.

All chemicals are equal in supply. This doesn't solve the issue of chemical supply other than putting a hard limit. Individual chemicals are still of equal rarity, which makes recipes difficult to balance.

This exacerbates the nullification of body management. Current cloning and biomass gameplay already makes morgue and body storage irrelevant; this only makes it worse.

Maybe making a separate replenishable resource, e.g. a box of 50 pill capsules from cargo, would be good to prevent pill spam but not actively discouraging any pill use.

I guess you made good points I will wait until rework.

not entirely opposed to this, i just think it needs to be bundled with more biomass options/pill options to not be horrifically punishing to the playerbase atm. please dont abandon the idea because of response to initial pr i think its got a good direction

not entirely opposed to this, i just think it needs to be bundled with more biomass options/pill options to not be horrifically punishing to the playerbase atm. please dont abandon the idea because of response to initial pr i think its got a good direction

Yeah we need Biogenerator first as other source of biomass

The most insane thing about pills for me is that you can put up to 50u of chems. Note that a cup holds 20u so average pill should be the size of cup???

In this case it's just the pills so the delivery method of chems, without touching the chems themselves.

In this case it's just the pills so the delivery method of chems, without touching the chems themselves.

What? What's even the point then?  People are just going to leave the chemicals out on the counter. If pills are too strong right now, just make them hold less chems.

In this case it's just the pills so the delivery method of chems, without touching the chems themselves.

What? What's even the point then?  People are just going to leave the chemicals out on the counter. If pills are too strong right now, just make them hold less chems.

Then can we remove the glass requirement to make bottles please for the love of God I want to play doctor again but it's impossible with pill meta of 500 pills made for free sitting on the chemist counter

i think this is a good concept if we have 1 or 2 more sources of biomass

Then can we remove the glass requirement to make bottles please for the love of God I want to play doctor again but it's impossible with pill meta of 500 pills made for free sitting on the chemist counter

Second this, whenever I play CMO my hypospray is effectively useless because my chemists will either ignore or outright deny my requests for bottled chems, and I don’t blame them since most chem labs only are stocked with a total of twelve glass bottles

You can make chems by yourself but I feel the same.
Also bottles have only 30u outclassed by drinking glass with 50u (and you can get 30 from bar). Imo they should have more capacity.


Feat(eos_designs): Add support for setting mgmt_gateway under the node settings.

Change Summary
Add support for setting mgmt_gateway under the node settings.
Related Issue(s)
Fixes #3635
Component(s) name
arista.avd.eos_designs
Proposed changes

How to test

Checklist
User Checklist

N/A

Repository Checklist

[x] My code has been rebased from devel before I start
[x] I have read the CONTRIBUTING document.
[x] My change requires a change to the documentation and documentation have been updated accordingly.
[x] I have updated molecule CI testing accordingly. (check the box if not applicable)

Closed in favor of #3867


duplicate files when there are circular symlinks

Category

[x] fzf binary
[ ] fzf-tmux script
[ ] Key bindings
[ ] Completion
[ ] Vim
[ ] Neovim
[ ] Etc.

OS

[X] Linux
[ ] Mac OS X
[ ] Windows
[ ] Windows Subsystem for Linux
[ ] Etc.

Shell

[ ] bash
[ ] zsh
[ ] fish

ln -s foo foo
fzf, search for something, see duplicate results everywhere

This works also with longer chains of links, e.g., foo -> bar -> foo. Of course, these shouldn't exist in the first place, but they can exist.

This is a duplicate of #1120. I'm going to fix this, but for now, you can workaround the problem by setting up a custom $FZF_DEFAULT_COMMAND.

Will be fixed in the next release.


fix(CX-3318): Update hardcore redirects for settings app

The type of this PR is: Fix

This PR solves CX-3318
Description
This PR is a follow-up on #11685
This PR updates the hardcore redirects of the Settings app to reflect the new change after introducing the Collector Profile on Web

This PR should not be merged before releasing the Collector Profile

Merging this since we released the Collector Profile now ..


Fix #1280

[x] You've read the Contributor Guide and Code of Conduct.
[x] You've included unit or integration tests for your change, where applicable.
[x] You've included inline docs for your change, where applicable.
[x] There's an open issue for the PR that you are making. If you'd like to propose a new feature or change, please open an issue to discuss the change or find an existing issue.

For PRs which target a specific extension within UA, changes won't be approved by a member of the dotnet-upgrade-assistant-admin group until a member of the code owners of the extension has approved, when required.

Description
Removing 'if-condition' from method 'GetPackagesSources' of class 'NuGetPackageSourceFactory' so that computer and user specified configurations for NuGet gets considered.
This PR addresses just the needed change without unit tests.
I made another branch (birgos/1280-nuget-proxy-error-with-tests) to test the affected method/class but it would take a bit more code changes...
Addresses #bugnumber (in this specific format)
#1280

@dotnet-policy-service agree

@twsouthwick
Hello,
have I possibly missed a policy that blocks the review of this pull request?
Kindly Regards


[Question] - Caching and attaching

I have two DbContext instances.
The first instance is a singleton.
This instance creates an entity:
_database.Foo.Add(new Foo()
                    {
                        Name="Test",
                        Bar= 4
                    });
 _database.SaveChanges();

The second instance is scoped to a particular operation happening elsewhere.
The scoped instance updates the same record Foo and sets it's Bar property from 4 to 5 and commits.
If the scoped instance re-queries Foo it sees the change - as expected.
Sometime after that operation commits, back on the singleton instance, it needs to update the same Foo record a second time. So it does:
 var foo = _database.Foo.FirstOrDefault(a => a.Name== "Test");
 foo.Name = "Live";
_database.SaveChanges();

However it sees the old value of the entity that it originally created, not the most up to date record from the database that was just committed by the other dbcontext instance. So it ends up saving changes to the Foo record and reverting the value of 5 back to 4 again.
What is the correct way to handle this situation?
I would like for my query to with the singleton instance to pull back the latest values from the database - but not for read only purposes - I plan to make modifications.
I saw AsNoTracking() but the the use case for that looks primarliy read only purposes. Do I have to use this and then attach the entity somehow? Should I be using TrackGraph() ? It seems there should just be a shorthand for my scenario. Is there a way to clear the cached / tracked state for a given entity so that I can be sure that the next query hits the database without using AsNoTracking?
Further technical details
EF Core version: 2.0.2
Database Provider: sqlite
Operating system:
IDE: (e.g. Visual Studio 2017 15.4)

@dazinator The recommended approach is not use a long-lived context instance. Instead, create a new instance for each unit-of-work. That being said, you can use context.Entry(foo).Reload() to refresh values of an entity from the database, or use context.Entry(foo).GetDatabaseValues() and related APIs to do similar things. However, these are designed more for things like optimistic concurrency within a single unit-of-work; I would strongly recommend a short-lived context over this approach.

Ok thank you. I will look at refactoring the code. There are a few singleton services in this xamarin app that have a DbContext instance injected, so will have to inject those with a Factory method instead so they can create short lived instances on demand.
However good to know the other ways to achieve this functionality.

@ajcvickers - I can't see a context.Entry() method at all in 2.0.2.. ?

I can't see a context.Entry() method at all in 2.0.2.. ?
Ignore me. Blind as a bat.


The examples need to cover the usage of each element described on this page or in the schema

The current examples are missing a bunch of elements.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 06a19d7d-253d-f17f-6421-624c9867473d
Version Independent ID: cc37eb17-f715-080c-7bfc-9eae868d50ba
Content: .nuspec File Reference for NuGet
Content Source: docs/reference/nuspec.md
Product: nuget
GitHub Login: @karann-msft
Microsoft Alias: karann

I would like to use the releaseNotes field but have no real idea how to handle multi-line notes. Is this   text? Does it handle CDATA?

@Miles-Davies-HORIBA - if you can find an existing nuget package that displays with multiline release notes, you can unzip it and check what the nuspec uses for line breaks

DependencyGroups is conspicuously absent;

Why would it ever be OK to close an unfulfilled documentation request?   Just backlog it.


[core] Running a raylib application could breaks other running applications

Running my application using either statically or dynamically linked raylib causes other programs like nano or apt to crash. nano crashes with "SIGTERM or SIGHUP". apt just aborts right away when asking the "Proceed to install [y/N]" question.
The application using raylib continues to work after the first start.
Happens on raspbian stretch.
uname -a:

Linux raspberrypi 4.14.79-v7+ #1159 SMP Sun Nov 4 17:50:20 GMT 2018 armv7l GNU/Linux

Can anyone else confirm this? This problem is consistent for multiple raspbian installations and is valid for 2.0.0 release as well as 2.3-dev. I don't know who the bad boy is in this case, raylib or raspbian itself, and don't know what to look for exactly.

Are you running both programs in native mode at the same time? Running though SSH?
No previous report but it could be related to raylib reconfiguring raw keyboard input...

It's the same application mentioned in the other issue and it's only running once at a time.
It occurs without SSH and with SSH, doesn't matter.
What I forgot to mention: It's "fixed" when using a new shell.

Does it happen with a simple raylib example?

Most probably related to keyboard input mode...

So it's related to raylib? You don't seem to be very excited about that ;-)
If I can do anything else to help, tell me. I'm happy to help if I can.

Thank you very much @Morvs, I was working long time on RPI keyboard input system trying to find the best approach and, unfortunately, doesn't seem to work properly (not only this issue but also https://github.com/raysan5/raylib/issues/379). It seems it requires a major redesign... falling back to the standard input_event mechanism.

Hmm.. in that case maybe i should not have left the old STDIN keyboard methods in when moving to the new keyboard method in #785
It possibly has to do with changing modes on STDIN to get a more direct keyboard input, perhaps this leaves the console window in a weird state.
Even if i don't manage to reproduce the issue i think it might be a good idea to simplify the STDIN keyboard method to only listen to STDIN and not attempt to reconfigure it into any special modes. For keyboards physicaly connected to the Pi the new evdev method works better and SSH consoles (where evdev does not work) fail to switch modes anyway so we might as well just use STDIN in its default mode.
@raysan5 Do you agree with this change?

It possibly has to do with changing modes on STDIN to get a more direct keyboard input, perhaps this leaves the console window in a weird state.

Yeah, that's it, running a raylib program reconfigures STDIN for it... and other programs running in background, it could also derive into some weird behaviour...
I think there is no alternative for it, listening to STDIN in a passive way requires reconfiguring it, in any other case (i.e. getchar()) end-line is required to send data.
I'd keep current implementation and let the user choose under it's own risk. By default, now it uses evdev, most users shouldn't have problems with that.

I am experiencing the same issue using raylib git f37e55a77bd6177dbaea4d7f484961c09104e104 on Raspbian Stretch Lite (without X11).

in case it's unclear: this is still an issue, it has not been fixed.


metal device create produces facility deprecation warnings even when metro is used

What happened?

❯ metal device create -p $METAL_PROJECT_ID -P c3.medium.x86 -m da -H github-runner-test -O ubuntu_22_04

2023/06/06 17:18:52 WARNING: "POST /metal/v1/projects/abcdefg-ee51-447d-87ce-068c57846508/devices" reported deprecation on Tue, 30 May 2023 00:00:00 GMT

How can we reproduce it?

CLI version (metal --version): 0.14.1
Create a device using the metro flag

This was closed by an upstream fix


Add a Flux Backed Stream Implementations

Many serialization libraries allow for streams to be passed in addition to byte[] and String. Our network responses are presented as Flux<ByteBuffer> which doesn't work with these APIs. We should look into adding InputStream and OutputStream implementations which are backed by a Flux<ByteBuffer to allow for lazy reading during serialization and deserialization.

Closing as won't be done until there is more need for this. We're moving away from Flux<ByteBuffer> being the only way to represent the request and response body to allowing more representations, making this change less useful.


Avoid duplicate foreign_key values when do eager loading (preloading)

Example:
$posts = Post::all(array('include' => array('author'));

foreach($posts as $post){
    echo $post->author->name;
}

After loading the posts, It will collect the author_id from each one and load all the referenced authors with one query.
But some posts may have the same author_id so we should avoid them being duplicated (in select query).

:+1:
Or is this the wrong approach?


CLA signing from PR

Describe the solution you'd like
Have a way to easily sign a CLA from a PR.
What is the added value?
Avoiding legal problems regarding code ownership when PRs are up but not merged. Also like this we follow CNCF standard.

I created the link between this CLA and our PRs for now, using https://cla-assistant.io/
Lets see how this goes.

I don't think it would make sense to have corporate CLA signing in the Pull request, right? Since for corporate the person needs to be legally entitled to grant the license in the Company's name..
I created the Gist anyway: https://gist.github.com/knelasevero/f172d48ec1f262e4645ea462cf5790eb

We discussed in the community meeting. In the end doesn't make much sense to keep the CLA for individual contributors. In a fork this would become a problem only if someone forks and removes the license, and this is a very weird edge case.
For corporate, it does not make sense to have automation, because of what I said in the comment above. We just need normal signature from someone legally entitled in the said company. We would have to do that without automation anyways.