HW-Emulation taking too long

Hello,
I was trying to run the original SDx Project with only 1 memory bank active i.e. I used "XCL_MEM_DDR_BANK0" for all the input buffers namely "buffer_cin", "buffer_weight", "buffer_bias", and "buffer_config". The simulation took almost 35ms and it still didn't finish. I have the following questions regarding the above use case:

Is the runtime of the "hw-simulation" expected to be 24.7ms?
Also, if I use 1 memory bank as suggested above will it take more time?

Also, I used the default memory bank configuration (multiple memory banks) as posted in the source code and tried building the system configuration,
and I encountered a routing error.
Can you please comment on the above questions?
Regards

The time to run the HW emulation depends on the number of layers you are using and the resolution of each, but generally, it should be much longer than what you got. For the network in the paper, it will take several days.
Yes, using 1 memory bank reduces the performance as you will access memory for all the inputs serially.

What is your target FPGA? Probably, you are overfitting it. You may either reduce the resource consumption or move to a bigger FPGA.

Thanks for your reply.
I wanted to ask you if I am using the same network as suggested in the paper, should the expected runtime be 24.7ms?
Because I tried running the network suggested in the paper with 1 memory bank and ran it for 35ms, but it didn't finish.
Also, the FPGA I used was the VU9P (AWS F1 instance) with the same resources as suggested in the paper. So I don't think so I am overfitting it, because I am using the same resources as suggested in the paper.

24.7ms is for when you are running it on-board, not the emulation time. The HW emulation takes much longer.
When you are using the FPGA on AWS, you should decrease the resource utilization as the tool uses more logic for the interface.


Null safety migration tool doesn't explain why it sometimes add explicit types

I'm trying to migrate some code that looks like:
    seriesList.forEach((MutableSeries<D> series) {
      final domainFn = series.domainFn;

The migration tool wants to add explicit types:
    seriesList.forEach((MutableSeries<D> series) {
      final D Function(int)? domainFn = series.domainFn;

but the details pane doesn't provide any rationale.  It'd be really helpful if it could (like DartPad) show me what type it thinks a particular variable is (or rather, what it would be without the explicit type).  While I could click on the right-hand-side to see the corresponding declaration, in this case it's not obvious since the declaration is for a generic type.
Dart SDK version: 2.13.361763185-edge+google3-v2 (google3) (google3) on "linux_x64"

That assignment might be a bug; I know that was (and may still be) a bug where it unnecessarily adds a cast for function types.

I seriously doubt that any further work will ever be done on dart migrate since it's been removed in Dart 3.


Debugger - Keyboard Shortcuts

Idea: add keyboard shortcuts to the debugger.
i.e F8 triggers continue, F10 step, etc.
We could also consider "friendlier" keys.
If implemented, we should make sure they work with focus on simulator as well.

My vote is to use the same keys as the browser debugger -- whatever those are.

Closing.


Allow prefix and suffix wildcard tag search

Improve on wild: true option for wildcard tag searches to also allow:

placing the wildcard only at the suffix with wild: :suffix to search for SQL awesome%

(would be called prefix search, wildcard is the suffix, hence wild: :suffix)

placing the wildcard only at the prefix with wild: :prefix to search for SQL %awesome

(would be called suffix search, wildcard is the prefix, hence wild: :prefix)

Let me know what you think, thanks!

Can you rebase this PR please.

I have rebased the branch to latest master.


Add minWidth and height parameter into FlatButton widget

Description
The FlatButton widget extends from MaterialButton but it does not provide a way to change the button's minWidth and height. This PR fixes this by providing those two parameter for the FlatButton.
Related Issues
Fixes https://github.com/flutter/flutter/issues/29220
Tests

[x] Verify that the minWidth value is passed to the parent widget
[x] Verify that the height value is passed to the parent widget

Checklist

[x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
[x] I signed the [CLA].
[x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
[x] I read the [Tree Hygiene] wiki page, which explains my responsibilities.
[x] I updated/added relevant documentation (doc comments with ///).
[x] All existing and new tests are passing.
[x] The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
[x] I am willing to follow-up on review comments in a timely manner.

Breaking Change
Did any tests fail when you ran them? Please read [Handling breaking changes].

[x] No, no existing tests failed, so this is not a breaking change.

@HansMuller can you review this? because you touched this file before.

This looks like a reasonable change however we're trying to shift the toolkit's emphasis to the new button classes (like TextButton) per https://github.com/flutter/flutter/pull/59702. On the other hand, this is a simple change that makes the, now outdated, API a little more consistent.
As always, thanks for the contribution. Please take a look at the "new button universe" :-).

This looks like a reasonable change however we're trying to shift the toolkit's emphasis to the new button classes (like TextButton) per #59702. On the other hand, this is a simple change that makes the, now outdated, API a little more consistent.
As always, thanks for the contribution. Please take a look at the "new button universe" :-).

Thank you. I will do that. Will the current button be deprecated soon? THat would be a big breaking changes :)

We're not going to deprecate the existing button widgets for a while however we'll be shifting use and development to the new ones.

We're not going to deprecate the existing button widgets for a while however we'll be shifting use and development to the new ones.

Great


[SPARK-25533][CORE][WEBUI]AppSummary should hold the information about succeeded Jobs and completed stages only

What changes were proposed in this pull request?
Currently, In the spark UI, when there are failed jobs or failed stages, display message for the completed jobs and completed stages are not consistent with the previous versions of spark.
Reason is because, AppSummary holds the information about all the jobs and stages. But, In the below code, it checks against the completedJobs and completedStages. So, AppSummary should hold only successful jobs and stages.
https://github.com/apache/spark/blob/66d29870c09e6050dd846336e596faaa8b0d14ad/core/src/main/scala/org/apache/spark/ui/jobs/AllJobsPage.scala#L306
https://github.com/apache/spark/blob/66d29870c09e6050dd846336e596faaa8b0d14ad/core/src/main/scala/org/apache/spark/ui/jobs/AllStagesPage.scala#L119
So, we should  keep only completed jobs and stage information in the AppSummary, to make it consistent with Spark2.2
How was this patch tested?
Test steps:
bin/spark-shell
sc.parallelize(1 to 5, 5).collect()
sc.parallelize(1 to 5, 2).map{ x => throw new RuntimeException("Fail")}.collect()

Before fix:

After fix:

Can one of the admins verify this patch?

Can one of the admins verify this patch?

Can one of the admins verify this patch?

Spark 2.2.1 output:

cc @vanzin @srowen

ok to test

Test build #96580 has started for PR 22549 at commit 7fe7812.

Test build #96582 has finished for PR 22549 at commit f3c12b4.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/96582/
Test PASSed.

Hi @vanzin , The build has passed.

Merging to master / 2.4 / 2.3.

(Small conflict in 2.4 that I'm fixing myself and testing locally.)

There's a separate issue with the test in master / 2.4 that I'll fix before I push your change to 2.4 / 2.3.

Thank you @vanzin for merging.


the example section is empty

can you please review the example section as it is empty

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: e8cb1ce3-02eb-3219-cfbd-c2ee9e686ec3
Version Independent ID: 76cbff88-ed92-b07a-4242-78e6d21eb1b2
Content: Remove-SPDistributedCacheServiceInstance (sharepoint-server)
Content Source: sharepoint/sharepoint-ps/sharepoint-server/Remove-SPDistributedCacheServiceInstance.md
Service: unspecified
GitHub Login: @techwriter40
Microsoft Alias: kirks

@FadJee Thank you for your feedback
It looks like this issue has been resolved by Trevor. I am going to close this issue. If this is not resolved please reopen the issue.


Automated cherry pick of #9920

Cherry pick of #9920 on release-6.5.
/cc  @BenCookie95
NONE

Will try to auto merge this PR once all tests and checks are passing. This might take up to an hour.

Trying to auto merge this PR.

Pull Request successfully merged
SHA: 207e01d91fb31e29be3178d2215b5fff630eaa7f


Creating a CORS enabled SAM deployment

Hi @vincentsarago,
The SAM deployment is awesome and amazingly simple for getting up and running. I've been digging into setting up a CORS deployed instance of TiTiler. It seems like the only reference to TiTiler within the repository is in the arns.json. Is deploying another version of TiTiler a matter of creating an ARN resource and referencing it here.
Is this something that had already been done? Do you have any specific recommendations?
Not too familiar with the whole process and thought it would interesting to get your input before moving forward. If it is something of interest to the community, I will be happy to share.
Bonne journée!

Works if the HTTP requests methods are explicitly defined on the API gateway.

I tried to get CORs restrictions happening so only requests from a single domain would work, but unfortunately I couldn't get it going. I tried setting request methods and domains but doesn't seem to have any impact 🤷

Rest of the deployment was very straight forward!
Any other tips @zacharyDez ?


Harvey doesn't like my name (ć)

I get the following result when I run harvery mit:
Traceback (most recent call last):
  File "/usr/local/bin/harvey", line 11, in <module>
    sys.exit(main())
  File "/usr/local/lib/python2.7/site-packages/harvey/harvey.py", line 163, in main
    print(_get_license_description(arguments['<NAME>'].lower()))
  File "/usr/local/lib/python2.7/site-packages/harvey/harvey.py", line 86, in _get_license_description
    license = re.sub(r'\[(.+)\]', replace_string, s)
  File "/usr/local/Cellar/python/2.7.10_2/Frameworks/Python.framework/Versions/2.7/lib/python2.7/re.py", line 155, in sub
    return _compile(pattern, flags).sub(repl, string, count)
UnicodeDecodeError: 'ascii' codec can't decode byte 0xc4 in position 16: ordinal not in range(128)

The reason is the character ć in my name. Would be nice if harvey was able to handle unicode characters.

So I read that python3 doesn't treat unicode characters specially anymore which is why I upgraded:
pip uninstall harvey
brew install python3
pip3 install harvey

But then I still had trouble with harvey, which errored with this message:
Traceback (most recent call last):
  File "/usr/local/bin/harvey", line 11, in <module>
    sys.exit(main())
  File "/usr/local/lib/python3.5/site-packages/harvey/harvey.py", line 163, in main
    print(_get_license_description(arguments['<NAME>'].lower()))
  File "/usr/local/lib/python3.5/site-packages/harvey/harvey.py", line 81, in _get_license_description
    name=_get_config_name())
  File "/usr/local/lib/python3.5/site-packages/harvey/harvey.py", line 58, in _get_config_name
    return _stripslashes(output[0])
  File "/usr/local/lib/python3.5/site-packages/harvey/harvey.py", line 48, in _stripslashes
    r = re.sub(r"\\(n|r)", "\n", s)
  File "/usr/local/Cellar/python3/3.5.0/Frameworks/Python.framework/Versions/3.5/lib/python3.5/re.py", line 182, in sub
    return _compile(pattern, flags).sub(repl, string, count)
TypeError: cannot use a string pattern on a bytes-like object

In order to get it working, I had to convert the bytes into a string using that code:
53: def _get_config_name():
xx:   ...
59:   return _stripslashes(output[0].decode('utf8'))

The tool works perfectly now. It would however be nice to see it work seamlessly with unicode characters in python2 and python3 without having to make any patches.

Same problem, work with python3 and this patch.


synchronize event not clear enough

Code of Conduct

[X] I have read and agree to the GitHub Docs project's Code of Conduct

What article on docs.github.com is affected?
pull_request section of this article
https://docs.github.com/en/actions/learn-github-actions/events-that-trigger-workflows#pull_request
What part(s) of the article would you like to see updated?
In the article, the pull request events are listed. Among those, the synchronize event doesn't have a clear meaning.
I have found out thanks to some forums that it means on push of the PR.
It would be much easier for users if it was clearly explained when it's triggered, like this:

The syncronize event is triggered...

Additional information
No response

@marcofugaro
Thanks so much for opening an issue! I'll triage this for the team to take a look :eyes:

Ho, I just found out that the synchronize event is not triggered if the PR has conflicts. You probably want to explicitly document this.

Thanks for opening this issue! We have some internal improvements to this article in progress that should address this issue (and that should make it more clear that you can find more info about the event activity types in the webhook event docs: https://docs.github.com/en/developers/webhooks-and-events/webhooks/webhook-events-and-payloads#pull_request).
Since this is being addressed internally, I am going to close this issue.

Thanks @skedwards88.
Any idea about what event to use to run an action on any commit push on the PR?
I am using this to deploy a PR preview, but it doesn't get triggered if the PR has conflicts.
on:
  pull_request:
    types: [opened, synchronize]

I can't use the push event because I need the github.event.pull_request info.


WIP: Use READONCE for SEGMENT files.

Just testing if an else clause is needed for segment files in ResourceHandler (see: https://github.com/crate/crate/pull/16791)


Feature: Integrate with audit log plugin

Ticket
https://github.com/VirtusLab/strapi-plugin-navigation/issues/-<your-ticket-#>
Summary
Integration with audit log
Test Plan
How are you testing the work you're submitting?

@Kronos66 can you please extend the Readme.md for enabling the integration and put some recipe in separated section?

Codecov Report

Merging #14 (3607062) into master (393a989) will decrease coverage by 1.33%.
The diff coverage is 9.90%.

@@            Coverage Diff             @@
##           master      #14      +/-   ##
==========================================
- Coverage   15.92%   14.59%   -1.34%
==========================================
  Files           4        5       +1
  Lines         226      281      +55
  Branches       77       90      +13
==========================================
+ Hits           36       41       +5
- Misses        156      198      +42
- Partials       34       42       +8

Flag
Coverage Δ

unittest
14.59% <9.90%> (-1.34%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

services/navigation.js
13.50% <9.27%> (-1.30%)
:arrow_down:

utils/NavigationError.js
25.00% <25.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 393a989...3607062. Read the comment docs.


Default "hello world" app moved to some embedded linux -> failing FlutterEngineInitialize

Steps to Reproduce

Execute flutter create sampleapp, cd sampleapp and `flutter
Copy to the target system:
build/linux/x64/debug/bundle/sampleapp
build/linux/x64/debug/bundle/lib/libflutter_linux_gtk.so
Running on the target system:
LD_LIBRARY_PATH=. ./sampleapp

Expected results:
The application running.
Actual results:
While the app works without any issues on the development machine, on the target embedded machine, an empty windows opens and on the console the error is written:
embedder.cc (1218): 'FlutterEngineInitialize' returned 'kInvalidArguments'. Not running in AOT mode but could not resolve the kernel binary.

** (sampleapp:5512): WARNING: **: 15:42:23.915: Failed to start Flutter engine: Failed to initialize Flutter engine

Flutter version: 3.3.4
If I found the correct location in the code: https://github.com/flutter/engine/blob/flutter-3.3-candidate.12/shell/platform/embedder/embedder.cc#L1218
Is there any chance to narrow down the cause for you flutter devs?
Maybe I could bring GDB to work on that embedded device, but not sure wether that would deliver additional information?

@bwofsi
Please check this answer and see if it helps in your case.

Whoa, that was surely one of the fastest solved issues for me!
Thank you so much!
(And I promise I won't overlook misspelled Google results!)


Update Composer dependencies (2021-10-12-00-07)

Visual regression test passed!
View the visual regression test report


More Altair fork transition tests

Adds the following tests to further exercise various chain conditions leading into the Altair fork boundary:

[x] finality across the fork
[x] randomize attestation participation across the fork boundary

~edit: intend to add the second test before wanting to merge this~

believe i've addressed all the above feedback and added some more test cases -- thanks for the review!


fixed undefined property stdClass::$bcc

fixed the error:
[PHPUnit\Framework\Exception] Undefined property: stdClass::$bcc

also fixed new api issue, see: https://github.com/ericmartel/codeception-email-mailtrap/issues/8


Add Profile: Dinesh

paste a screenshot of your GitHub profile here
enter category to label your profile
category:
then comment @all-contributors please add @<username> for review

@all-contributors please add @ for review

@all-contributors please add @dinxsh  for review

https://github.com/all-contributors please add @dinxsh for review

@all-contributors please add @dinxsh for review


angband: fix darwin build

Description of changes
fixes build for darwin targets
closes #282926

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[x] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

@wegank: thank you for reviewing

The package fails to build on x86_64-darwin: probably darwin.apple_sdk_11_0.stdenv could help?

The package fails to build on x86_64-darwin: probably darwin.apple_sdk_11_0.stdenv could help?

I did some extra testing.

master builds fine on x86_64-darwin (vm),  fails on my aarch64-darwin (2021 M1 MacBook Pro 14')
this pr fails to build on x86_64-darwin, succeeds on my aarch64-darwin

maybe there is something sketchy going on with darwin toolchain

Master fails to build on both aarch64-darwin and x86_64-darwin for me, though.

@ofborg build angband angband.passthru.tests

I ran nix run nixpkgs#angband on a clean macOS 14.3 install inside a VM and it worked just fine. Albeit it has only curses interface, no Cocoa.
It also built successfully after nix-store --gc and checking out latest master.
I guess we can close this issue?

This shouldn't be merged. Building from master works again for some reason. (although code didn't change)
Closing to make sure we are on the same page.

I'm suffering from the same error in #282926.

@wegank: Ok, let's keep this open to track it. I don't know why but it went away on my machine. I'll try later to reproduce it again. Could you post entire build log so we got more eyes on it?

@wegank from the log you posted
angband> checking for X... libraries /usr/X11/lib, headers /usr/X11/include

check if those paths exist on your system, if so, that may mean configure script tries to make the toolchain hold dependencies outside of the Nix ecosystem, which is  very bad and needs to be fixed

These paths do exist. I suppose the sandbox being relaxed by default on macOS isn't pleasant...

In any case, thanks a lot! I think I'm OK with this PR closed if you'd like to, but I'd prefer meta.platforms to be set, so that Hydra builds and caches the package on darwin.

I'll update the PR to include meta.platforms and use finalAttrs pattern with old build instructions - since what we have now borks out on x86_64-darwin.

I guess I've already made the changes in https://github.com/NixOS/nixpkgs/pull/283592/commits/115850eb98f1e93b749a268345cce8657e1a4814?

115850eb98f1e93b749a268345cce8657e1a4814 has build instructions that failed for me on x86_64-darwin


Invite Tracker - KeyError: guild.id

When A user joines the guild and the on_member_join event runs, whenever it gets to inviter = await tracker.fetch_inviter(member) then it says Keyerror: {guild.id}
Is there something I should do or is it a problem with DiscordUtils?

When A user joines the guild and the on_member_join event runs, whenever it gets to inviter = await tracker.fetch_inviter(member) then it says Keyerror: {guild.id}
Is there something I should do or is it a problem with DiscordUtils?

hmmm, KeyError, that means in a dictionary there is some key which is not even found. Show your entire code please?

Its a cache issue, make sure you use all the caching methods and your bot has manage server permissions


Proposal : restart policies "validations"

As wrote in runconfig/parse_test.go (https://github.com/docker/docker/blob/master/runconfig/parse_test.go#L458 and https://github.com/docker/docker/blob/master/runconfig/parse_test.go#L472), it's currently possible to set invalid restart policies and the result is kinda weird :

with always: docker run --restart=always:1 } will not work as expected but docker run --restart=alwasy:1:1 … or even docker run --restart=always:a:b will.
with on-failure: docker run --restart=on-failure:5:anything will not fail but the value of on-failure will be 0 which is worse.

I'ld propose we do a little more validation on these so those invalid inputs will result in an error at run or at least make it that on-failure:5:1 result the same as on-failure:5.
What do you think ?

We definitely should do this. I think it's a bug.

:+1: great suggestion

Great suggestion, working on that :)


Avoid timeouts for cancelling command

Make sure that:

[x] You have read the contribution guidelines.
[x] You use the code formatters provided here and have them applied to your changes. Don’t submit any formatting related changes.
[x] You submit test cases (unit or integration tests) that back your changes.

When an AsyncCommand was cancelled in another thread, LettuceFutures#awaitOrCancel() waited for long time and a timeout exception occured. So, I updated AsyncCommand#cancel() method using latch#countDown(), it'll occured an cancelled exception directly without meaningless waiting.
Previously:
Caused by: com.lambdaworks.redis.RedisCommandTimeoutException: Command timed out
    at com.lambdaworks.redis.LettuceFutures.await(LettuceFutures.java:98)
    at com.lambdaworks.redis.LettuceFutures.awaitOrCancel(LettuceFutures.java:77)
    at com.lambdaworks.redis.commands.AsyncCommandInternalsTest.cancelWhileAwaitWithException(AsyncCommandInternalsTest.java:89)
    at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
    at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
    at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
    at java.lang.reflect.Method.invoke(Method.java:497)
    at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50)
    at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
    at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:47)
    at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
    at org.junit.internal.runners.statements.ExpectException.evaluate(ExpectException.java:19)
    ... 19 more

Coverage increased (+0.2%) to 93.056% when pulling a8e2219df03ed7efe3563d694426fc8ffc95a93f on jongyeol:feature/add-latch-for-cancel into 92cd88b7015792660c4c4925a54d93b6c5f63aae on mp911de:master.

Thanks for your pull request. Lettuce uses/relies currently on java.util.concurrent.CancellationException to signal canceled commands. Releasing the wait semaphore to avoid timeouts is the right approach but I'm not convinced of introducing another exception. java.util.concurrent.CancellationException is raised by the Future and would require exception translation in other places, too.

@mp911de , I agreed about it. then, I'll update this soon. :)

No need to rush. I'm traveling this week, won't be able to do much.

I don't want to disturb your travel. Please check it after your travel~

Coverage increased (+0.2%) to 93.1% when pulling b635f763dac3fffcf58d19117b29873e3a44ab29 on jongyeol:feature/add-latch-for-cancel into 92cd88b7015792660c4c4925a54d93b6c5f63aae on mp911de:master.

Thanks for the PR. That's merged with ee3a2f7ae1015272e2b7f7628dc457c27ab38878.


make stop_words optional

This feature would allow us to stop creating empty fst (which are slow to create) on milli.
See https://github.com/meilisearch/milli/issues/111

bors try


The progress of the still video screen seems to change in milliseconds

Version
Media3 main branch
More version details
No response
Devices that reproduce the issue
Samsung S21+, AOS 13
Devices that do not reproduce the issue
No response
Reproducible in the demo app?
Yes
Reproduction steps

disable release/initialize player on stop/start the activity (from sample)

select 'Clear DASH' -> 'HD (MP4, H264)' (or other MP4 example)
click the pause button
go background and back to foreground
repeat step4 and check the video

Expected result
The progress of the still screen should remain unchanged.
Actual result
The progress of the still screen appears to change in milliseconds.
Media
https://github.com/androidx/media/assets/98582953/a6fce97b-3926-4398-915d-7326d4bdfc2c
Bug Report

[ ] You will email the zip file produced by adb bugreport to<EMAIL_ADDRESS>after filing this issue.

I found this issue when I tried to re-use a view in RecyclerView.
And it looks similar to this issue - https://github.com/androidx/media/issues/1278

Thanks for your explanation.
And I totally understand your concern( keeping the player (and the codec in particular) while the app is in background may cause unexpected side effects)
But my service has a requirement which is focused on visibility not on performance.
Because there is flicker of screen when I release and initialize the player.
(The screen is black while the player load media file.)
So isn't this supposed to be fixed? I mean, should I explain to my team member that this is not a problem.

So isn't this supposed to be fixed?

Could you highlight what exactly you are trying to achieve? There may be alternatives to your current usage pattern.
But generally, the way codecs work is that they release frames to a surface and there is no way to get the last released frame back again. To avoid this, you need to either recreate the codec or not destroy the surface:

New codec, new (or same) surface -> some initial delay during set up, but can start with the previous frame precisely. This is what the Media3 demo is doing by default.
Same codec, new surface -> current test setup as described above, can only release the next frame
Same codec, same surface -> keeps content, but there is no guarantee you can keep the surface. Surfaces are automatically destroyed when the Activity is stopped or they are no longer connected to the view hierarchy. If you handle them in RecyclerView, you may be able to move an existing Surface to an out-of-screen position while you don't need it, or you try SurfaceControl to reparent an exiting Surface in another View.

The screen is black while the player load media file

The typical solution to this is to show a placeholder image. You may be able to achieve this by using TextureView and then call getBitmap when the surface is destroyed. Or preferably, you can start preparing the output early enough so that it's already ready when it comes into view.

Thank you, you already suggested alternative solution for me.
Actually I wanted to keep the surface even if it was disconnected from the view hierarchy.
I used "TextureView" and the "TextureView" was destroyed when detached from window (as you mentioned)
I think "SurfaceControl" or "Placeholder image"(from "getBitmap") can be a solution.


Add support for SnakeYaml to be able to parse timestamps correctly when timezone is set or not

Impact

[x] Bug fix (non-breaking change which fixes expected existing functionality)
[ ] Enhancement/New feature (adds functionality without impacting existing logic)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Description
A new ConstructYamlTimestamp class was created to identify whether a date time should be returned with the timezone included or not.
Fixes #5499

Things to be aware of

None

Things to worry about

None

Additional Context
N/A

Hey @filipelautert,
This is pretty much all snakeyaml code. I don't think it's worth spending time on it, since we are going to revert/update this code soon (when they get their code updated).
Thanks,
Daniel.


Recorded tests break due to scope filtering issue

https://github.com/node-nock/nock/blob/master/lib/intercept.js#L164
Why does the code exit the _.each directly after finding the first match? My tests make thousands of calls to the same host, and the early exit causes them to break if I change the order of the calls, even if the same end result is achieved. Is this intentional behavior?
If I comment out this line, my tests all work, so I'm not sure if I'm writing my tests wrong and this behavior is intentional or if this line could be removed.
Thanks!

hey @maxGreenblatt I recently join the nock maintainers team and still finding my ways around the code, so I can’t tell why it’s done as it is. Could you check out the nock repository, run tests to make sure they all pass, then comment that line out and see if it breaks any tests? That’s how I usually find out why a code is there :)

Doesn't break any tests - 758 passing, 1 pending, then 6 passing in install_sub_deps with and without the line commented.

thanks for checking!
That means that the tests are not as good as they should be to help with issues like yours, this will require a bigger investigation. Maybe @ierceg can help?
I’ll be out the next two weeks but hope to have more time for the rest of October. If you could do some more research to find out why the code has been added, that’d be very helpful. Until then I suggest you fork the repo, make your fix, and install nock from your fork until we have it figured out

https://github.com/node-nock/nock/commit/18ab73f3a04d6b525b2203e43050bd14ece6e82f - looks like it was part of the initial commit for Scope filtering 3 years ago

@maxGreenblatt The return false is there because we have found a match and we no longer need to keep searching. Request scopes shouldn't be ambiguous so the first match should actually be the only match (or you should always have the exactly same response and it's the count of requests that matters - in which case there is no reason to prefer the last match rather than the first match) So my first suspicion would be that your scopes might be ambiguously defined and thus more than a single match exists for every request.
Could you try to isolate the issue?
When I get some time I'll try to add missing tests.

Are you sure every scope is intended to be different?
filteringScope(basePath) is just sending the host string, not even the path. By that logic that would mean we are only allowed to have one scope per host?
https://github.com/node-nock/nock/blob/master/lib/intercept.js#L156

I think you are right - I stand corrected.
Let's try to work through how this should work and then compare it to how it actually does work.

Define scopes that are different (have different matching parameters) in whatever order you want.
Define scopes that are the same in the precise order in which they will be executed.
Run tests - every requests will go through scopes, find the matching one starting from the front (which is why order matters), remove it from the list of available scopes and so on until the test ends.

Does this sound reasonable?
Btw, have you managed to isolate the issue in a smallest test?

I haven't created a smallest test that isolates the issue, but I could pretty easily if that's helpful.
As the user, I would assume option (3) is the default behavior. And to get the behavior in option (1) you would call .persist() on the scope.
I think another quirk about the way it is currently coded is that it says this is filtering the scope which is an object that contains a lot of information, but as its implemented scopeFiltering is really just filtering the hostname/basePath


Add whisper support

make a new file, spice/whisper.py. Model it after spice/embeddings.py. It should contain a class SpiceWhisper that has a method kinda like this:
    async def call_whisper_api(self, audio_path: Path) -> str:
        audio_file = open(audio_path, "rb")
        transcript = await self.async_client.audio.transcriptions.create(
            model="whisper-1",
            file=audio_file,
        )
        return transcript.text

expose SpiceWhisper from the __init__. use async openai / azure clients, not sync ones like spice/embeddings does.

@abanteai-butler please take a stab at this thanks


Integration with Biometric authentication systems

Describe the improvement
Integration with Biometric authentication systems

Veridium
Imprivata
BioID
Typing DNA (behavioural typing biometrics): https://github.com/wso2/product-is/issues/10179
BehavioSec

This issue is being closed due to extended inactivity. Please feel free to reopen it if further attention is needed. Thank you for helping us keep the issue list relevant and focused!


Add scroll to pages

@comlaterra can you also please mention the issue which you are solving ?

This is not necessarily an issue fix, but a new feature. ( despite in my case was )
With the previous version, if the content was longer than the container, an overflow was happening.
I believe that behaviour is not ideal, so I think is way better to enable the scroll in the container, so the content won't overflow.

Nice catch :+1: will push it in the next release

@comlaterra can you please remove merge conflicts?

My apologies for not taking care of this earlier. Is this still relevant?
Should I still take care of the merge conflicts?


Automated spellchecking

This is a script and custom dictionary to allow for running ispell. It won't catch everything as I had to add a lot of strange things to the dictionary to cover crypto hashes, bitbake variables, etc but it is a bit easier than spell checking by hand.

@michaelatmender @GregorioDiStefano @estenberg what do you guys think of this?  I've got similar changes in the other branches I can submit if we like this approach.

good idea, we should have used this earlier on!


feat(Split-Button): Added split button UI

Summary

Split button UI ( derived from button)
Sizes : small, medium, large
Variants: default and withIcon

ADO Story
https://dev.azure.com/Kyndryl/Shidoka - Bridge Design System/_workitems/edit/1770711
To Do

UI / UX design decision for focus, hover etc. mode

Checklist

[x] Used Conventional Commit messages as outlined in the contributing guide.

[x] Noted breaking changes (if any).

[ ] Documented/updated all props, events, slots, parts, etc with JSDoc.

[ ] Ran the analyze command to update Storybook docs.

[ ] Added/updated Stories with controls to cover all variants.
[x] Ran test locally to address any failures.
[ ] Added/updated the Figma link for the Story's Design tab.
[x] Added any new component exports to the src/index.ts file

Testing Instructions
Provide guidance to reviewers/testers here.
Screenshots
(if any)

UX approved by @kaanhsu

Closing this as this is moved to foundation.


phande.md

Why:
Closes [issue link]

What's being changed:

Check off the following:

[ ] I have reviewed my changes in staging (look for the latest deployment event in your pull request's timeline, then click View deployment).
[ ] For content changes, I have completed the self-review checklist.

Writer impact (This section is for GitHub staff members only):

[ ] This pull request impacts the contribution experience

[ ] I have added the 'writer impact' label
[ ] I have added a description and/or a video demo of the changes below (e.g. a "before and after video")

@phande93
This seems to be opened accidentally, I am going to close it now :yellow_heart: Take a look at the contributing.md to learn how to contribute in this repo. You can open a discussion if you have any questions :sparkles:


09- Palindrome Number

Description of the Problem
Determine whether an integer is a palindrome. An integer is a palindrome when it reads the same backward as forward.
Code
class Solution:
    def isPalindrome(self, x: int) -> bool:
        """
        Checks to see if argument is a palindrome
        :param : int
        :returns : Bool
        """
        x = str(x)
        if x[::-1] == x:
            return True
        else:
            return False

main = Solution()

if __name__ == "__main__":
    print(main.isPalindrome(-101))

Link To The LeetCode Problem
LeetCode

Hi, may I work on this?

Hey i think the repo owner has to assign it to you specifically, I just need him to accept this as a valid issue for my hacktoberfest profile,

hey @Curiouspaul1 i would love to work on this . Can you please assign this to me ?

Closed - Problem already solved! Make Sure to read Contribution Guideline before creating an Issue!

I'm confused when you say check to see if the problem hasn't been implemented do you mean to check whether abosolutely no one has written and submitted a soultion to the problem on leetcode?


[README.md] Update Options Link

Please follow the guide below

You will be asked some questions, please read them carefully and answer honestly
Put an x into all the boxes [ ] relevant to your pull request (like that [x])
Use Preview tab to see how your pull request will actually look like

Before submitting a pull request make sure you have:

[ ] At least skimmed through adding new extractor tutorial and youtube-dl coding conventions sections
[ ] Searched the bugtracker for similar pull requests

What is the purpose of your pull request?

[ ] Bug fix
[ ] New extractor
[ ] New feature

Description of your pull request and other information
Explanation of your pull request in arbitrary form goes here. Please make sure the description explains the purpose and effect of your pull request and is worded well enough to be understood. Provide as much context and examples as possible.
The link references a bad anchor. The updated link now references the correct anchor.

Cherry-picked in d21a661bb4cbdb92f4db588e3801bb19d4fa96b2, thanks.


Navbar: Logo doesn't appear in storybook examples

Prerequisites

[X] I have searched for duplicate or closed issues
[X] I have read the contributing guidelines

Describe the issue
Examples in storybook aren't showing the Trimble logo
Reduced test cases
View storybook for navbar.  Incorrectly using logo prop instead of logoOptions prop.
What operating system(s) are you seeing the problem on?
Windows
What browser(s) are you seeing the problem on?
Chrome
What is the issue regarding ?
@trimble-oss/modus-web-components
What version of npm package are you using ?
v0.18.0
Priority
Medium
What product/project are you using Modus Components for ?
Modus
What is your team/division name ?
Modus
Are you willing to contribute ?
Yes
Are you using Modus Web Components in production ?
No response

Fixed with: #2207


Render date field content with format like strftime

Is your feature request related to a problem? Please describe.
Now the content of the date field is rendered with %Y/%m/%d %H:%M
{%= sample-post_date %}
=> 2021/11/12 00:00
I want to be able to do other date formats as well
=> 2021/11/12
=> 2021年
Describe the solution you'd like
How about passing the format as an argument, referring to strftime?
{%= sample-post_date, '%Y/%m/%d %H:%M' %}
=> `2021/11/12 00:00`

{%= sample-post_date, '%Y/%m/%d' %}
=> 2021/11/12

`{%= sample-post_date, '%Y年' %}`
=> 2021年

Or a format that can acquire only numbers
{%= sample-post_date, '%Y' %}年
=> 2021年

Describe alternatives you've considered
Additional context

@pandaulait
Thank you for filing this issue 🚀
I think we had better to provide several approach this features.

strtime function support

As you mentioned,  Spear has strtime like syntax like bellow:
<time>{%= strtime('{%= sample-post_date %}', 'YYYY/MM/DD hh:mm:ss') %}</time>

In your suggested syntax doesn't contain the operation code. (Meaning function)
So we had better to provide strtime function.

Provide the time unit syntax

If Embed syntax has year, month, day, hour, minute, second,  we cannot use the function like (1).
<time>{%= sample-post_date#year %}年{%= sample-post_date#month %}月{%= sample-post_date#day %}日</time>

I'm concern that this way is redundant. Developer should many embed syntax code.

Provide the date convert function via spear.config.mjs

We can specify the date convert function via spear.config.mjs. spearly-cms-js-core has this option. (options.dateFormatter)
If we don't specify this function, spearly-cms-js-core use the default formatter. This default formatter will convert datetime as Japanese unit.
export default {
  "dateFormatter": function(date) {
    // return converted string
    return `${date.getFullYear().toString()}年${date.getMonth() +1}月${date.getDate()}日`;
  },
}

@mantaroh I feel that strtime is more user friendly, easy and understandable to use 🤔
However, I also like the option 3 for more advanced users.

I think a combination of 1 and 3 would be a good idea. 🤔
Easy to use is 1, but if we want to use it universally, it would be nice to have a setting like 3. 😄

I think a combination of 1 and 3 would be a good idea. 🤔 Easy to use is 1, but if we want to use it universally, it would be nice to have a setting like 3. 😄

I agree with this!
about 3, the default function should not be fixed to Japanese. Using toLocaleString() method without any arguments would be nice, I think 🤔


Give the access of this project

@tushargupta1504 Hii, i am new mentor assigned to your project can I get the access for this to make this project more beautiful

i have given you the access kindly assign the issue which are true and close the previous one same with pr

@tushargupta1504 received


Add sphinx-lint pre-commit (and some docs fixes)

Companion PR to https://github.com/rapidsai/cugraph/pull/4771, because if we want sphinx-lint pre-commit there, then we probably want it here too.
The docs in this repo are out of date and were updated to make sphinx-lint happy.

Conflicts must be resolved before merging.

/merge


Add .error() method or similar to Coreg class

There should be a quick way to figure out how well the coregistration went. NMAD is one alternative, but it could hide potential biases. I like RMSE's, but they often look dauntingly big!
The .error() (or similar) method could alternatively take an argument to choose (metric="nmad").
Opinions?

Maybe we should have a method .residuals() that returns the residuals and then one can run whatever calculation one wants on them?


Inconsistent information on which version of Flocker the driver was tested against

Hi @stmcginnis,
I hope you're about to take some well deserved time off this year.  In the meantime,  I noticed the readme says both
"Certified against Flocker 1.7.0"
and
"This driver has been tested against Flocker 1.4.0."
Could you remove the reference to 1.4.0?  Also, could you add this note at the top of the repo so that people see it first?
Also, do you think that you could set up a CI system for testing the driver against new version?  Like outlined here: https://docs.clusterhq.com/en/1.8.0/gettinginvolved/plugins/building-driver.html#certifying-your-driver
Thanks!
Michael

Good catch Michael, I will get rid of that inconsistency.
I've been working towards setting up a CI reporting results, but there are
many challenges with that, especially with the way systems are set up right
now. I am hoping to have something in place soon.
On Fri, Dec 18, 2015 at 2:46 PM, Michael Ferranti<EMAIL_ADDRESS>wrote:

Hi @stmcginnis https://github.com/stmcginnis,
I hope you're about to take some well deserved time off this year. In the
meantime, I noticed the readme says both
"Certified against Flocker 1.7.0"
and
"This driver has been tested against Flocker 1.4.0."
Could you remove the reference to 1.4.0? Also, could you add this note at
the top of the repo so that people see it first?
Also, do you think that you could set up a CI system for testing the
driver against new version? Like outlined here:
https://docs.clusterhq.com/en/1.8.0/gettinginvolved/plugins/building-driver.html#certifying-your-driver
Thanks!
Michael
—
Reply to this email directly or view it on GitHub
https://github.com/dellstorage/storagecenter-flocker-driver/issues/1.


[atip] Improve atip for crosswalk webdriver of python

MEMO PAD8:
webapi-devicecapabilities-w3c-tests:
Impacted TCs num(approved): New 0, Update 0, Delete 0
Unit test Platform: Crosswalk Project for Android 18.46.465.0
Unit test result summary: Pass 6, Fail 0, Blocked 0
tct-webstorage-w3c-tests:
webapi-devicecapabilities-w3c-tests:
Impacted TCs num(approved): New 0, Update 0, Delete 0
Unit test Platform: Crosswalk Project for Android 18.46.465.0
Unit test result summary: Pass 1, Fail 1, Blocked 0

What's the reason of the failed test?

Please file a task to track this fix.

LGTM


[BUG] Application returns client-side exception when a charge input becomes null or undefined

Issue Description
Problem:
When a charge input is set to null or undefined, the application is throwing a client-side exception, causing unexpected behavior and potentially breaking the user experience.
Expected Behavior:
The application should gracefully handle null or undefined values for charge inputs, providing appropriate error handling or validation to prevent client-side exceptions and ensure a smooth user experience.
Steps to Reproduce

Open the application.
Navigate to the relevant section where charge inputs are accepted (Final notes step).
Interact with the charge(discount, tax, shipping) input fields and delete their initial value.
Observe the client-side exception that occurs.

Actual Results
A client-side exception occurs when charge inputs are deleted, which can disrupt the application's functionality and negatively impact the user experience.
Expected Results
The application should handle null or undefined charge inputs gracefully, providing clear error messages or validation to guide users and prevent client-side exceptions.

Fixed here 7622818


Update paw to 3.0.11

Checklist

[x] The commit message includes the cask’s name and version.
[x] brew cask audit --download {{cask_file}} is error-free.
[x] brew cask style --fix {{cask_file}} left no offenses.

Thank you for the contribution. It needed some fixes, so they were made in 54146d37e5be428de9481eab6817d7d76b7bf725. Your contribution is still included (and still credited to you), with the appropriate modifications. Please feel free to ask about any of the changes.


Push notifications

Hi guys, can anyone shed any light on push notifications integration.

Maybe this one would solve your problem: http://plugins.cordova.io/#/package/com.clone.phonegap.plugins.pushplugin
The plugin is NOT included in the tabris.js app that you may have download from the app stores. BUt you can integrate it easily in your own app, just follow this blog: http://eclipsesource.com/blogs/2015/04/01/your-own-javascript-mobile-app-with-tabris-js-in-10-minutes/

Tried that but requires webview.
Going to try this https://github.com/avivais/phonegap-parse-plugin
Have you guys got plans to have your own service?

the above plugin will not install.
A bit stuck now I can find a plugin that works :(

No plans so far. But I will add this topic to the next planing.

Get this trying to install parse plugin
Error during processing of action! Attempting to revert...
Error during reversion of action! We probably really messed up your project now, sorry! D:
Error during reversion of action! We probably really messed up your project now, sorry! D:
Error during reversion of action! We probably really messed up your project now, sorry! D:
Error during reversion of action! We probably really messed up your project now, sorry! D:
Error during reversion of action! We probably really messed up your project now, sorry! D:
Error during reversion of action! We probably really messed up your project now, sorry! D:
Error during reversion of action! We probably really messed up your project now, sorry! D:
Error during reversion of action! We probably really messed up your project now, sorry! D:
Error during reversion of action! We probably really messed up your project now, sorry! D:
Error during reversion of action! We probably really messed up your project now, sorry! D:
Failed to install 'org.apache.cordova.core.parseplugin':TypeError: Uh oh!

"A reversion action failed: Object "$(PROJECT_DIR)/CordovaLib/Tabris" has no method 'filter'" seems to be the error.

Is this a bug on the tabris-ios cordova platform?

Yes. The stack trace you were getting was caused by our Xcode-Project-Template which contained an unexpected value - the Cordova build could not handle it. This is fixed now an will be available soon. (Version > 0.9.4)

awsome :)

btw. by tomorrow evening we will have updated the online build service to be able to build nightly versions. So, you should be able to build your own developer app including this fix than.

kk when is 0.9.4  available with the platforms to download and build locally?

Is this issue relevant for iOS? The parse-plugin seems to be android only.
I also had a look on com.clone.phonegap.plugins.pushplugin - this plugin does some nasty things with the Objective-C runtime (e.g. rewriting and swap default constructors during runtime, ...) which will install, but not work out-of-the-box with Tabris.js.

https://github.com/avivais/phonegap-parse-plugin/tree/master/src
Is both IOS and Android works fine on android but it fails and shown above on IOS.
tried com.clone.phonegap.plugins.pushplugin but does not work depends on webview anyway

ok. I'll check if  parse-plugin will work for the next release.

ok cheers

So I have a question can I extend mainActivity class?
Notifications only fire if app is open or minimised not if closed and from what I have found extending main activity with a bit of code seems to solve the issue.
Is it possible to guide me on how to solve this as I do need my users to receive notifications even if app is off.

You would need an Organization plan for tabris.js to get access to the sources. With that in mind, yes it would be possible.
We are also working to improve compatibility with various cordova plugins.

humm, in that case than can I flag this as a feature request?

Of course :)

How do I flag this as feature request?

simply use the feature label

Isnt that feature just availble for colaborators?

public class MainApplication extends Application {
private static MainApplication instance = new MainApplication();
public MainApplication() {
    instance = this;
}

public static Context getContext() {
    return instance;
}

@Override
public void onCreate() {
    super.onCreate();
    Parse.initialize(this, "r7aHNhWLVVZeLMj36TngO5j8pUrgAtx3CkwhGuW6", "WXBNgQEIplGqUfDGQliScPXvPo21mzWPi1Z2wttb");
    PushService.setDefaultPushCallback(this, FabulaClient.class);
    PushService.subscribe(this, "Barca", FabulaClient.class);
    ParseInstallation.getCurrentInstallation().saveInBackground();
}

}
This seems to be an example of how to implement receiving notifications if app is off

So at the moment is impossible to apply the code above in anyway?

Well, you could use a cordova hook to integrate native android specific parts.

well I have done this:
/*
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements.  See the NOTICE file
distributed with this work for additional information
regarding copyright ownership.  The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License.  You may obtain a copy of the License at
     http://www.apache.org/licenses/LICENSE-2.0

   Unless required by applicable law or agreed to in writing,
   software distributed under the License is distributed on an
   "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
   KIND, either express or implied.  See the License for the
   specific language governing permissions and limitations
   under the License.

*/
package com.coachioapp.coachio;
import android.app.Activity;
import android.app.AlertDialog;
import android.content.Intent;
import android.content.SharedPreferences;
import android.net.Uri;
import android.os.Bundle;
import android.preference.PreferenceManager;
import com.eclipsesource.tabris.android.OpenUrl;
import com.eclipsesource.tabris.android.TabrisActivity;
import com.eclipsesource.tabris.android.internal.javascript.JavaScriptApp;
import com.eclipsesource.tabris.js.launcher.utils.DownloadService;
import com.eclipsesource.tabris.js.launcher.utils.LauncherApp;
import com.eclipsesource.tabris.js.launcher.utils.LoadRequest;
import com.eclipsesource.tabris.js.launcher.utils.LoadingIndicator;
import com.eclipsesource.tabris.js.launcher.utils.LocalResourcesLoader;
import com.eclipsesource.tabris.js.launcher.utils.PackageJson;
import com.eclipsesource.tabris.js.launcher.utils.RemoteLauncher;
import com.eclipsesource.tabris.js.launcher.utils.fragment.MainFragment;
import com.google.common.base.Joiner;
import com.google.common.base.Splitter;
import java.io.FileNotFoundException;
import java.io.IOException;
import java.util.ArrayList;
import java.util.List;
import static com.eclipsesource.tabris.android.TabrisActivity.RESULT_EXTRA_URL;
import static com.eclipsesource.tabris.js.launcher.utils.Preferences.*;
import org.apache.cordova.*;
public class PushApp extends MainActivity implements RemoteLauncher {
}
and created as well:
/*
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements.  See the NOTICE file
distributed with this work for additional information
regarding copyright ownership.  The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License.  You may obtain a copy of the License at
     http://www.apache.org/licenses/LICENSE-2.0

   Unless required by applicable law or agreed to in writing,
   software distributed under the License is distributed on an
   "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
   KIND, either express or implied.  See the License for the
   specific language governing permissions and limitations
   under the License.

*/
package com.coachioapp.coachio;
import android.app.Activity;
import android.app.AlertDialog;
import android.content.Intent;
import android.content.SharedPreferences;
import android.net.Uri;
import android.os.Bundle;
import android.preference.PreferenceManager;
import com.eclipsesource.tabris.android.OpenUrl;
import com.eclipsesource.tabris.android.TabrisActivity;
import com.eclipsesource.tabris.android.internal.javascript.JavaScriptApp;
import com.eclipsesource.tabris.js.launcher.utils.DownloadService;
import com.eclipsesource.tabris.js.launcher.utils.LauncherApp;
import com.eclipsesource.tabris.js.launcher.utils.LoadRequest;
import com.eclipsesource.tabris.js.launcher.utils.LoadingIndicator;
import com.eclipsesource.tabris.js.launcher.utils.LocalResourcesLoader;
import com.eclipsesource.tabris.js.launcher.utils.PackageJson;
import com.eclipsesource.tabris.js.launcher.utils.RemoteLauncher;
import com.eclipsesource.tabris.js.launcher.utils.fragment.MainFragment;
import com.google.common.base.Joiner;
import com.google.common.base.Splitter;
import java.io.FileNotFoundException;
import java.io.IOException;
import java.util.ArrayList;
import java.util.List;
import static com.eclipsesource.tabris.android.TabrisActivity.RESULT_EXTRA_URL;
import static com.eclipsesource.tabris.js.launcher.utils.Preferences.*;
import org.apache.cordova.*;
import android.app.Application;
import org.apache.cordova.*;
import com.parse.Parse;
import com.parse.ParseAnalytics;
import com.parse.ParseInstallation;
import com.parse.PushService;
public class MainApplication extends Application {
@Override
public void onCreate() {
  super.onCreate();
  Parse.initialize(this, "XXXX", "XXXX");
     PushService.setDefaultPushCallback(this, PushApp.class);
     ParseInstallation.getCurrentInstallation().saveInBackground();
}

}
and finally:
android:name="com.coachioapp.coachio.MainApplication"
and works amazingly well :)

would be awsome to have this as a hook, no idea how to write hooks, need to read how to :)

@paulocarvalhodesign Good to hear. Let us know if you could do it via a hook as well.

created something like this:
#!/usr/bin/env node
//
var fs = require('fs');
var path = require('path');
// no need to configure below
var rootdir = process.argv[2];
module.exports = function(context) {
context.opts.platforms.forEach(function (platform) {

    if (platform === "ios") {

    }

    else if (platform === "android") {

        var filestocopy = [
            {
                "packages/com/yourpackage/yourapp/MainApplication.java": "platforms/android/src/com/yourpackage/yourapp/MainApplication.java"
            },
            {
                "packages/com/yourpackage/yourapp/PushApp.java": "platforms/android/src/com/yourpackage/yourapp/PushApp.java"
            }
        ];

        filestocopy.forEach(function (obj) {
            Object.keys(obj).forEach(function (key) {
                var val = obj[key];
                var srcfile = path.join(rootdir, key);
                var destfile = path.join(rootdir, val);
                console.log("copying " + srcfile + " to " + destfile);
                var destdir = path.dirname(destfile);
                if (fs.existsSync(srcfile) && fs.existsSync(destdir)) {
                    fs.createReadStream(srcfile).pipe(
                        fs.createWriteStream(destfile));
                }
            });
        });

    }
});

};

Closing this issue since it ended with a happy outcome.


terraform-providers.github: 2.8.0 -> 3.1.0

Motivation for this change
Prior versions only support orgs.
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[ ] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 101418 1

4 packages built:
- terraform-full
- terraform-providers.github
- terraform_0_11-full
- terragrunt


Map different ring names to git branches

As a:
SPK User
I want:
To map different ring names to git branches
So that:
My ring names don't have to be the same as the git branch names
Describe the solution you'd like:
Perhaps some sort of mapping in bedrock.yaml that allows a ring name to target a git branch name, allowing a user to specify a git branch to use for a ring ie
rings:
  prod:
    targetBranch: "master"
  develop:
    targetBranch: "develop"
  qa:
    targetBranch: "test"
etc.

Though perhaps the ideal schema should be inverted to be branch name as the key, and the target ring name as the value ie - we should spend some time figuring out what makes sense here
rings:
  master:
    targetRing "prod"
  develop:
    targetRing: "develop"
  test:
    targetRing: "qa"

Acceptance Criteria:

[ ] SPK cli should allow me to specify which target branch i would like to use
[ ] Bedrock yaml schema should be updated to accommodate a target branch for rings
[ ] Lifecycle pipeline should accommodate creating ingress routes using the targetRing parameter as the header ring
[ ] Integration tests
[ ] Documentation

Describe alternatives you've considered:
This is a preliminary investigation into how we might map different rings to branches - there may exist other methods of solving this.
Additional context:
Customer request
Does this require updates to documentation?:
Yes

@samiyaakhtar if the branch name is now different from the ring name you would need to look at bedrock.yaml to retrieve
@bnookala @evanlouie The customer said this is low priority. I think so too at the moment so we  can take our time to think about this. I would put other refactoring and testing ahead of this.

@evanlouie @andrebriggs Just created https://github.com/microsoft/bedrock/issues/1396 as a follow up task

After deeper investigation and attempts at a not too intrusive solution, I believe this cannot be completed without very heavy refactoring of the service build-update pipeline.
Looking for feedback to see if this feature is worth such refactoring.
Notes on what would need to be done captured in: https://github.com/microsoft/bedrock-cli/pull/36

Putting this back in the backlog it becomes a higher priority. Requires deeper design review to come up with solution to address whats mentioned above


wsproto docs should move to python-hyper.org

I've got the docs up at wsproto.readthedocs.org but they should probably move under python-hyper.org at some point.

\o/ Ok, so getting this to work involves some dancing on RTD. To do it I'll need to be made a maintainer on the wsproto RTD so I can add it as an appropriate sub-project. Do you mind?

Hrm, actually that didn't go as planned at all.
@ericholscher, tagging you in. I just attempted to add wsproto as a subproject of hyper-documentation. RTD rightly rejected that attempt because I don't have admin on wsproto, but now visiting https://python-hyper.org/wsproto/ does in fact redirect to the wsproto docs. That...doesn't seem right. What's going on there?

@agjohnson is doing a refactor of this page today, so will call this a bug :(

@ericholscher Sounds reasonable to me. It's cool, bugs happen, and this one is pretty benign as they go.

As it turns out - I had the same idea two weeks ago: https://github.com/python-hyper/wsproto/issues/71
Any progress on this?

Done via 0b60eadb7a3e016256ebe5f541679a21a7e3c9e7


Menu with selectable property doesn't display the selected value

I'm using menu as a dropdown component because I'd like to use a <MenuDivider />, but the setting the selectable property to true doesn't keep the selected value

Hi @mvanlonden! You can use it like that but the component doesn't keep the state, like other components, the Input for example, this component is stateless. You can pass the selectable property with the value you want to select but when it changes you have to capture the new value with a wrapper component and pass the new one.
Recall a reimplementation of the Dropdown is coming and with that you will be able to customize the appearance by adding separators and custom rendering items to do so. Patience!

:) ok thanks! Wasn't aware of the reimplementation of dropdown. No problem,
worked around by using button in combination with menu. Awesome library,
thanks so much for putting it together
On Sun, Jan 22, 2017 at 10:37 AM Javi Velasco<EMAIL_ADDRESS>wrote:

Hi @mvanlonden https://github.com/mvanlonden! You can use it like that
but the component doesn't keep the state, like other components, the Input
for example, this component is stateless. You can pass the selectable
property with the value you want to select but when it changes you have to
capture the new value with a wrapper component and pass the new one.
Recall a reimplementation of the Dropdown is coming and with that you will
be able to customize the appearance by adding separators and custom
rendering items to do so. Patience!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/react-toolbox/react-toolbox/issues/1166#issuecomment-274349481,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABo6BxY1u78uh6MUcZuiW-HCX0gD6nDIks5rU6HzgaJpZM4LqPA4
.


Updates Endpoints Frameworks v2 sample with service management.

Adds service management and auth dependencies and filters.
Uses exec-maven-plugin to generate the swagger spec.
Updates README for swagger generation.

LGTM - with required changes.

I'm marking LGTM and DO NOT MERGE - until all is ok.

Current coverage is 48.92% (diff: 100%)

Merging #316 into master will not change coverage

@@             master       #316   diff @@
==========================================
  Files            73         73
  Lines          2242       2242
  Methods           0          0
  Messages          0          0
  Branches        158        158
==========================================
  Hits           1097       1097
  Misses         1115       1115
  Partials         30         30

Powered by Codecov. Last update ace9bdb...d7962d8

@tswast FYI - BQ Samples are failing.

Merging. LGTM, and it sounds like this is ready from chat.


Slow to load

I’m currently using this in my project, however it seems like it takes about 10-20 seconds toinstantiate this class. Is that normal or might there be something wrong with my installation?
nlp = spacy.load('en')
emoji = Emoji(nlp)

^ Takes about 21 seconds

Hi @ohenrik,
I have same issues and I investigated this around, the problem is just one line in https://github.com/ines/spacymoji/blob/6bc4e44545d50d642baaba8b5ad36a050e1eb221/spacymoji/init.py#L59
It takes time to parse the EMOJI list. in emoji package, it is roughly 3k item list. When you feed with nlp language model en, it will make it worse, where if you do None language "nlp = Language(Vocab())", it will parse quickly. Here is my changes adapted from the original emoji.
I hope contributor will remove the PhraseMatcher, it is not efficient to have in the pipeline. We all know emoji is always one token, so it is suitable to just normal string match like described in function "get_emoji_desc". I changed so it will be cached when you do emoji_desc multiple times.
import spacy
from spacy.tokens import Doc, Span, Token
from emoji import UNICODE_EMOJI

# make sure multi-character emoji don't contain whitespace
EMOJI = {e.replace(' ', ''): t for e, t in UNICODE_EMOJI.items()}

class Emoji2(object):
    name = 'emoji2'

    def __init__(self, nlp=None, merge_spans=True, lookup={}, pattern_id='EMOJI',
                 attrs=('has_emoji', 'is_emoji', 'emoji_desc', 'emoji')):
        self._has_emoji, self._is_emoji, self._emoji_desc, self._emoji = attrs
        self.merge_spans = merge_spans
        self.lookup = lookup
        # Add attributes
        Doc.set_extension(self._has_emoji, getter=self.has_emoji)
        Doc.set_extension(self._emoji, getter=self.iter_emoji)
        Span.set_extension(self._has_emoji, getter=self.has_emoji)
        Span.set_extension(self._emoji, getter=self.iter_emoji)
        Token.set_extension(self._is_emoji, default=False)
        Token.set_extension(self._emoji_desc, default=None)

    def __call__(self, doc):
        for token in doc:
            emoji_desc = self.get_emoji_desc(token)
            if emoji_desc:
                token._.set(self._is_emoji, True)
                token._.set(self._emoji_desc, emoji_desc)
        return doc

    def has_emoji(self, tokens):
        return any(token._.get(self._is_emoji) for token in tokens)

    def iter_emoji(self, tokens):
        return [(t.text, i, t._.get(self._emoji_desc))
                for i, t in enumerate(tokens)
                if t._.get(self._is_emoji)]

    def get_emoji_desc(self, token):
        if token.text in self.lookup:
            return self.lookup[token.text]
        if token.text in EMOJI:
            desc = EMOJI[token.text]
            # Here we're converting shortcodes, e.g. ":man_getting_haircut:"
            return desc.replace('_', ' ').replace(':', '')
        return None

nlp = spacy.load('en_core_web_sm')
emoji = Emoji2(nlp)
nlp.add_pipe(emoji, first=True)
print(nlp('🎀 🐈')._.has_emoji)

@kororo, I don't think that's quite correct.
Firstly, as Ines explains in the README, there are emoji that contain multiple characters, and Spacy doesn't always tokenize them into a single token by default. For example:
from emoji import UNICODE_EMOJI

EMOJI = {e.replace(' ', ''): t for e, t in UNICODE_EMOJI.items()}
nlp = sp.load("en_core_web_sm")

long_emoji = [e for e in EMOJI.keys() if len(e) > 4]
txt = f"This is one emoji: {long_emoji[0]} and this another: {long_emoji[1]}."
print(f"Original text:\n'{txt}'")

doc = nlp(txt)
print("\nTokens:")
for t in doc: print(f"'{t}'")

will produce this:
Original text:
'This is one emoji: 🏴 and this another: 🏴.'

Tokens:
'This'
'is'
'one'
'emoji'
':'
'🏴'
''
'and'
'this'
'another'
':'
'🏴'
'.'

So I think Ines's way of merging is the correct one. However, I found that a simple change from
emoji_patterns1 = [nlp(emoji) for emoji in EMOJI.keys()]

to
emoji_patterns2 = list(nlp.pipe(EMOJI.keys()))

reduces the execution time on my laptop from ~25s to <4s, without changing the result:
def docs_equal(d1, d2):
    attribs = ["ORTH", "LEMMA", "POS", "TAG"]
    return (d1.to_array(attribs) == d2.to_array(attribs)).all()

all([docs_equal(emoji_patterns1[i], emoji_patterns2[i]) for i in range(len(emoji_patterns1))])

>> True

I think in principle it could be sped up even more by not executing the whole pipe, e.g. using: nlp.tokenizer.pipe(EMOJI.keys()). I haven't tried that yet, but I don't think information from the tagger, parser etc. is needed for the PhraseMatcher to work correctly here.

I just confirmed that Ines's test:
doc = nlp(u"This is a test 😻 👍🏿")
assert doc._.has_emoji == True
assert doc[2:5]._.has_emoji == True
assert doc[0]._.is_emoji == False
assert doc[4]._.is_emoji == True
assert doc[5]._.emoji_desc == u'thumbs up dark skin tone'
assert len(doc._.emoji) == 2
assert doc._.emoji[1] == (u'👍🏿', 5, u'thumbs up dark skin tone')

passes with the change to
emoji_patterns = list(nlp.tokenizer.pipe(EMOJI.keys()))

which takes 155ms instead of 25s on my laptop.
If I haven't overlooked anything this could probably be included as a change.

Thanks so much for looking int to this – I can confirm that we need to match both single and multiple tokens for emoji, and that using nlp.pipe is definitely much better than calling just nlp on each string. No idea why I didn't do this properly (especially since this is something I recommend to others a lot) 🤦♀
Would you like to submit a PR with your fix?

Ok. Will do. I think the way to go then would be with
emoji_patterns = list(nlp.tokenizer.pipe(EMOJI.keys()))

When I have a moment I will create the PR.


Dreambooth finetuning support

please check https://github.com/huggingface/optimum-habana/pull/881 . it seems have more coverage

Please sync your PR with main/upstream and fix any merge conflicts. Thank you.


pre-commit hook does not work in Visual Studio

Environment

ggshield version: 1.14.2
Operating system (Linux, macOS, Windows): Windows
Operating system version: 11
Python version: any

Describe the bug
Visual Studio (Not VS Code!) fails to execute our pre-commit hook because it cannot execute our shebang (#!/usr/bin/env bash).

One can workaround that by replacing the shebang with #!/bin/sh. However it's not a correct fix because the hook uses bash-specific syntax so it would fail on OS where /bin/sh is not bash, such as Ubuntu.
TODO

[ ] Replace all our hook shebangs with #!/bin/sh. Note that using #!/usr/bin/env sh does not fix the problem
[ ] Fix the bashims
[ ] If possible, setup a check like checkbashisms in the CI

I am not sure to understand why this issue is limited to Visual Studio users ?
From my understanding, any user with the global pre-commit hook installed but without bash available will fail to execute the hook ?

I think that's because VS ships with its own version of Git, which wrongly assumes that a script to be executed with bash must be Linux only, so it must go through WSL.


[Packager][Testing] Best way to get react native running with mocha

I'm trying to get React Native working with Enzyme (https://github.com/airbnb/enzyme) and am running into issues getting the project into a state where I can actually import the react-native module.
I'm trying to run mocha with the --compilers flag like so:
mocha --compilers js:babel-core/register

Additionally, i have the .babelrc that's in the packager folder in the root folder, with the following:
{
  "retainLines": true,
  "compact": true,
  "comments": false,
  "plugins": [
    "syntax-async-functions",
    "syntax-class-properties",
    "syntax-trailing-function-commas",
    "transform-class-properties",
    "transform-es2015-arrow-functions",
    "transform-es2015-block-scoping",
    "transform-es2015-classes",
    "transform-es2015-computed-properties",
    "transform-es2015-constants",
    "transform-es2015-destructuring",
    ["transform-es2015-modules-commonjs", {"strict": false, "allowTopLevelThis": true}],
    "transform-es2015-parameters",
    "transform-es2015-shorthand-properties",
    "transform-es2015-spread",
    "transform-es2015-template-literals",
    "transform-flow-strip-types",
    "transform-object-assign",
    "transform-object-rest-spread",
    "transform-react-display-name",
    "transform-react-jsx",
    "transform-regenerator",
    "transform-es2015-for-of"
  ],
  "sourceMaps": false
}

But it is throwing an error as soon as it runs into the object-rest-spread operator:
Users/leland_richardson/code/rn_enzyme_test_project/node_modules/react-native/Libraries/react-native/react-native.js:112
  ...require('React'),
  ^^^

SyntaxError: Unexpected token ...
    at exports.runInThisContext (vm.js:53:16)
    at Module._compile (module.js:404:25)
    at Module._extensions..js (module.js:432:10)
    at Object.require.extensions.(anonymous function) [as .js] (/Users/leland_richardson/code/rn_enzyme_test_project/node_modules/babel-register/lib/node.js:138:7)
    at Module.load (module.js:356:32)
    at Function.Module._load (module.js:311:12)
    at Module.require (module.js:366:17)
    at require (module.js:385:17)
    at Object.<anonymous> (/Users/leland_richardson/code/rn_enzyme_test_project/test/MyComponent.js:1:80)
    at Module._compile (module.js:425:26)
    at loader (/Users/leland_richardson/code/rn_enzyme_test_project/node_modules/babel-register/lib/node.js:130:5)
    at Object.require.extensions.(anonymous function) [as .js] (/Users/leland_richardson/code/rn_enzyme_test_project/node_modules/babel-register/lib/node.js:140:7)
    at Module.load (module.js:356:32)
    at Function.Module._load (module.js:311:12)
    at Module.require (module.js:366:17)
    at require (module.js:385:17)
    at /Users/leland_richardson/code/rn_enzyme_test_project/node_modules/mocha/lib/mocha.js:216:27
    at Array.forEach (native)
    at Mocha.loadFiles (/Users/leland_richardson/code/rn_enzyme_test_project/node_modules/mocha/lib/mocha.js:213:14)
    at Mocha.run (/Users/leland_richardson/code/rn_enzyme_test_project/node_modules/mocha/lib/mocha.js:453:10)
    at Object.<anonymous> (/Users/leland_richardson/code/rn_enzyme_test_project/node_modules/mocha/bin/_mocha:393:18)
    at Module._compile (module.js:425:26)
    at Object.Module._extensions..js (module.js:432:10)
    at Module.load (module.js:356:32)
    at Function.Module._load (module.js:311:12)
    at Function.Module.runMain (module.js:457:10)
    at startup (node.js:136:18)
    at node.js:972:3

I'd assume that since the transform-object-rest-spread is in the babelrc that this would work fine?  What am I missing?  Any help would be appreciated.

cc @martinbigio or @amasad

OK, I figured it out...  I forgot that babel-core/register ignores node_modules by default. Since RN's files arent compiled, this doesn't work out very well.
I was able to run this file on startup which got it done:
var fs = require('fs');
var path = require('path');

function getBabelRC() {
  var rcpath = path.join(__dirname, '..', '.babelrc');
  var source = fs.readFileSync(rcpath).toString();
  return JSON.parse(source);
}

var config = getBabelRC();

config.ignore = function(filename) {
  if (!(/\/node_modules\//).test(filename)) {
    return false; // if not in node_modules, we want to compile it
  } else if ((/\/node_modules\/react-native\//).test(filename)) {
    // its RN source code, so we want to compile it
    return false;
  } else {
    // it's in node modules and NOT RN source code
    return true;
  }
};

require("babel-register")(config);

global.__DEV__ = true;

Hi Leland, thanks for this and your great work on Enzyme.
Can you elaborate on: "I was able to run this file on startup which got it done:"?
I'm currently trying to setup mocha as well, but also having an issue with babel and node modules.

Looks like this code is actually running as intended based on my previous post, but gets stuck on external node modules. The error I'm getting:
.../node_modules/@exponent/react-native-navigator/ExSceneConfigs.js:193
Fade:_reactNative.Navigator.SceneConfigs.FadeAndroid,
                                        ^
TypeError: Cannot read property 'FadeAndroid' of undefined

I've gotten past the spread issue, but now I'm having an issue with Platform
Error: Cannot find module 'Platform'
    at Function.Module._resolveFilename (module.js:337:15)
    at Function.Module._load (module.js:287:25)
    at Module.require (module.js:366:17)
    at require (module.js:385:17)
    at Object.Platform (react-native.js:95:27)
    at Object.<anonymous> (activity-indicator.js:4:19)
    at Module._compile (module.js:425:26)
    at loader (/Users/esauter/Code/Peach/DropBot/node_modules/babel-register/lib/node.js:126:5)
    at Object.require.extensions.(anonymous function) [as .js] (/Users/esauter/Code/Peach/DropBot/node_modules/babel-register/lib/node.js:136:7)
    at Module.load (module.js:356:32)
    at Function.Module._load (module.js:311:12)
    at Module.require (module.js:366:17)
    at require (module.js:385:17)
    at Object.<anonymous> (button.js:14:1)
    at Module._compile (module.js:425:26)
    at loader (/Users/esauter/Code/Peach/DropBot/node_modules/babel-register/lib/node.js:126:5)
    at Object.require.extensions.(anonymous function) [as .js] (/Users/esauter/Code/Peach/DropBot/node_modules/babel-register/lib/node.js:136:7)
    at Module.load (module.js:356:32)
    at Function.Module._load (module.js:311:12)
    at Module.require (module.js:366:17)
    at require (module.js:385:17)
    at Object.<anonymous> (button-test.js:7:1)
    at Module._compile (module.js:425:26)
    at loader (/Users/esauter/Code/Peach/DropBot/node_modules/babel-register/lib/node.js:126:5)
    at Object.require.extensions.(anonymous function) [as .js] (/Users/esauter/Code/Peach/DropBot/node_modules/babel-register/lib/node.js:136:7)
    at Module.load (module.js:356:32)
    at Function.Module._load (module.js:311:12)
    at Module.require (module.js:366:17)
    at require (module.js:385:17)
    at /Users/esauter/Code/Peach/DropBot/node_modules/mocha/lib/mocha.js:219:27
    at Array.forEach (native)
    at Mocha.loadFiles (/Users/esauter/Code/Peach/DropBot/node_modules/mocha/lib/mocha.js:216:14)
    at Mocha.run (/Users/esauter/Code/Peach/DropBot/node_modules/mocha/lib/mocha.js:468:10)
    at Object.<anonymous> (/Users/esauter/Code/Peach/DropBot/node_modules/mocha/bin/_mocha:403:18)
    at Module._compile (module.js:425:26)
    at Object.Module._extensions..js (module.js:432:10)
    at Module.load (module.js:356:32)
    at Function.Module._load (module.js:311:12)
    at Function.Module.runMain (module.js:457:10)
    at startup (node.js:136:18)
    at node.js:972:3

Did either of you have an issue with this? Maybe it's not including the Platform modules because of the platform specific extensions .ios.js and .android.ios?

I'm having the same issue with tests and platform specific extensions. Do you have any workaround for that?

At the suggestion of @lelandrichardson, I started using his library https://github.com/lelandrichardson/react-native-mock. Not sure if it's a long term solution for me, but I was able to successfully run tests for now with it :+1:

Any solutions using react-native-packager?
Of course I know passing ignore regex to babel-register, but the essential solution should be using the same packager.

Having the same issue with tests and platform specific extensions.


Some enhancements for developer experiences

Replaced println! macro with tracing logging framework, which brought fancy logging text:
Use clap crate to parse arguments for launcher, now you can get a pretty help message, passing config file through an argument without polluting the environment variable:

Replaced lazy_static crate with once_cell crate, which is safer and faster.
Upgraded some crates
...other minimal changes you can review.

You are my hero. 😭


Uno theme bug in its baseurl setup

Hello,
This fix looks like it will fix my blog issues. How would go about merging all the changes from the last year so my theme is up to date?
Thank you.
https://github.com/joshgerdes/jekyll-uno/pull/71
https://dfinke.github.io/#blog
https://github.com/dfinke/dfinke.github.io

You would pull the latest and, depending on what you changed, you would copy/merge the files over.


BETA: OnHold and OnLongRelease forget settings on InputShifters

When setting events for OnHold or OnLongRelease, the settings work, but if you go back to the configwizard, the events are empty.
They work if they are configured on a regular button input

same for inputmultiplexer


updated for godot 4, and added support for AudioStream2d, 3d, and Spr…

updated for godot 4 and gdscript 2, and added support for AudioStream2d, 3d, and Sprite3D

Wow. I appreciate your work. Sorry you had to face my beginner's code.
Unfortunately my gpu doesn't support Vulkan so testing this PR is impossible until a development version of Godot reimplements OpenGL, or at least a fork that does so.
I'll keep this PR open for the time being. I want to keep master related for stable releases, so this'd better fit a new branch.

Haha. I didn't realise it was "beginner" code. It taught me to use yield aka await. I never use yield, and it solves a lot of editor plugin problems..
Yes! What's the easiest way for me to make this a branch? I actually still struggle with git a little :p this is my first actual pr ever! :P

It's the first addon I made so there might be some things I'd write differently and approaches I wouldn't take.
I'm not advanced but I'm at a personally comfortable level regarding addon development.
Yield is actually something to be careful to use, if the yield awaits for a node's signal and the node gets freed, it causes some errors.
It's been a while since I last used git, but I usually write:
git branch (new-branch-name)
git checkout (new-branch-name)

Sometimes I use https://gitexplorer.com/ when I forget a command.

P.s. the plugin is great! :) So simple yet so effective. Gonna save me a lot of lipsync time.
I'm thinking about trying to mod it for runtime/real-time use... But that might be a bit too ambitious

Oh. Didn't come to me at first that you meant to pr the branch. I only messed with PRs once so I do not know the command to do so. Maybe there's options to change the target branch on the github site? But you shouldn't expect it'll be soon to merge because I'd have to wait for a godot4 fork with gles2/3 to test it.
Thanks. I was afraid after some Engine updates it'd stop working but I'm glad it didn't.
Realtime is impossible because rhubarb needs some time to process the audio. But runtime was actually a scope-creep goal I had at the beginning, though didn't find a use for it so shelved.
I think it's possible to implement though. I just don't know if the binary folder for rhubarb can be exported within a project.

@AniMesuro As now Godot 4 comes with a GLES backend, have you got any plan for testing and merging this?

Unfortunately not. I still use only Godot3 so I'll have to relearn gdscript from Godot4 to finally update the addon.
Although I do want to honour rossunger's contribution, so eventually it's possible for me to set time for studying when I get free-ish time from my job.

I didn't put a lot of time into it, so don't worry about my contribution :)
I also think godot4 gdscript has changed a bit since I made this pr. I
actually find it SO much more enjoyable than the original gdscript. Would
highly recommend learning. Didn't take me long at all to switch, and the
new features make life much better :)
If there's any way I can help let me know :) I haven't looked into lipsync
technology lately, but I think this might still be the best option for
godot users. Would love to have a real-time/run-time version of this for
multiplayer experiences.
On Thu, Aug 24, 2023, 1:31 p.m. AniMesuro @.***> wrote:

Unfortunately not. I still use only Godot3 so I'll have to relearn
gdscript from Godot4 to finally update the addon.
Although I do want to honour rossunger's contribution, so eventually it's
possible for me to set time for studying when I get free-ish time from my
job.
—
Reply to this email directly, view it on GitHub
https://github.com/AniMesuro/rhubarb-lipsync-tp-integration-godot/pull/13#issuecomment-1692136586,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ACGZ2R2SOMW63A7ANQUNYHDXW6FV3ANCNFSM5OWPPSWA
.
You are receiving this because you authored the thread.Message ID:
@.***
.com>

Hey all, unfortunately it looks like this PR is no longer working in Godot 4. I'd really love to be able to use this as I seem to have pretty much 0 other options available for Godot 4!

Hey all, unfortunately it looks like this PR is no longer working in Godot 4. I'd really love to be able to use this as I seem to have pretty much 0 other options available for Godot 4!

Same. It seems majority of the systems need a rewrite with new contributors, Maybe using reddit/alt platforms can redirect them. (I hope 3d lip syncing gets added if this happens!)

i've decided to create my own derivative of this plugin for godot 4.2+. it's still early on in it's development, but is in a usable state. If you want to check it out, here's a link to it https://github.com/Pheubel/Rhubarb-Lip-Sync-Tool-for-Godot-4


QueenConstructorDeclarationNode.java: Handle constructor parameters...

The puzzle 903553397 originating from #10 has to be resolved:
https://github.com/jvmqueen/queen-of-java/blob/6275c7b1502de217d5b92f103529ff5c008339ec/src/main/java/org/queenlang/transpiler/nodes/QueenConstructorDeclarationNode.java#L47-L47
"Handle constructor parameters (between parantheses).".
The puzzle was created by amihaiemil at 2022-12-04 18:15:11 +0200.
Estimation is 60 minutes.
If you have any technical questions, don't ask me, I won't be able to help. Open new issues instead.

@amihaiemil this is your task now, please go ahead. Deadline (when this ticket should be closed) is 2022-12-14T16:20:33.426036.
Estimation here is 60 minutes, that's how much you will be paid.
Remember, you don't have to solve everything in this ticket - you can solve it partially and leave todo markers in the code, which will become future tasks.
If you have any questions don't ask me, I'm not a technical person. Open new tickets instead.
If you don't have time or simply don't want to work on this, you can always resign.

@amihaiemil Don't forget to close this ticket before the deadline (2022-12-14T16:20:33). You are past the first half of the allowed period.

Puzzle disappeared from the code, that's why I closed this ticket.

@amihaiemil thank you for resolving this ticket. I've just added it to your active invoice. You can always check all your invoices and more on the Contributor Dashboard.


Migrating from trove, fixing some resource leakage in unit tests and correcting markdown errors due to new github markdown processor.

Great library!  I am looking to integrate byteseek into Apache Metron as a dependency, but sadly you depend on a LGPL library (trove), which isn't a permissive license and against the rules for the Apache Software Foundation.
In this PR, I migrated the library from trove to org.apache.mahout.mahout-math, which is based on Colt, under active development and poses no license challenges.
I also corrected a few other small things:

Github markdown has shifted over the years, so I made the README.md conform
One of the unit tests wasn't cleaning up resources and, as a result, when running all the tests in the same JVM in the IDE, it bombs.

I ran the tests in Intellij and also ran the build in maven with mvn clean package.  I figured the test coverage around the trove stuff was pretty well covered, so I didn't add any new tests.

Also, if you like this PR and would be willing, it'd be great to cut a new release and push it to mvnrepository with this change.  :)

Hi Casey, thanks for the PR! I'll review it and get back to you.
No problem in principle with replacing Trove, as long as the replacement offers similar performance and primitive collections.
Regards
Matt

I've had a quick review, and the changes look good.  I'll need to run some tests, and maybe some performance tests before I can merge.
I notice on your METRON-870 you state that you don't need these changes any more, as you're not using the parts of byteseek which rely on the primitive hash map.  I will probably still merge in these changes if they're OK, as the fix some issues and I would prefer to use a supported library with a more permissive license in any case.
I'm currently working on a release of byteseek 2.1, which has some much faster search algorithms (ShiftOR and QgramFiltering), bug fixes, and a specialised sequence searcher interface which avoids creating a list of search results on each search (reduces garbage when you can only have a single result or none, which is the case for sequences).
Let me know if you still want a release with your PR - otherwise I'll defer release until byteseek 2.1
Regards,
Matt

I certainly don't have a problem with that.  We're just using the bytestream searcher stuff.  Can you confirm that my supposition was correct and that the Trove library is used only in the I/O infrastructure?

Yes, the Trove library is only used in the I/O infrastructure.  There is a collection LongLinkedHashMap in the utils package, but that's only used by the I/O. It reduces garbage when processing lots of data by avoiding lots of Long objects for the positions of the cached data.

I've decided I'm not going to merge the PR because I have now implemented my own primitive hash map, optimised for byteseek usage.  Trove was only ever used as a stop-gap, so it doesn't make sense to depend on yet another library for that one function.
I have already fixed the markdown, and I will fix the resource leaks in the tests as you suggest.  Once again, many thanks for the PR, byteseek is now in a much better place.

By the way, you get a copyright credit on the FileReaderTest, since those were extensive changes which I've adopted wholesale.

It's actually not clear to me how to track copyright on patches to the project.  You definitely own the copyright to the patch.  I wanted to credit your work, and this is just one test file in the project...


[Bug]: Selected Border Radius & Box shadow are not visible for the widgets added inside List widget

Is there an existing issue for this?

[X] I have searched the existing issues

Description

Steps To Reproduce

Add List widget into canvas
Add Button widget onto List widget
Observe Button widget's property pane that Box Radius & Shadow are not visibly selected.

Note: This bug also happens for primary columns in table widget
Public Sample App
No response
Version
Cloud / Production

The table widget's issue is different from this. Created a separate issue for that #14999

@aswathkk what is the issue here?

@dilippitchika The value sent to these property controls is undefined somehow. I couldn't dig deeper. Someone with more context about ListWidget will be able to figure out the reason.

Ok, assigning this to @jsartisan to check

Removing the issue from reskinning epic. We will fixing this in list v2
cc: @dilippitchika


[0.1.0] Crashes chrome in production build on Netlify

Describe the bug
The production build is crashing on netlify in Chrome. The same production build does not crash locally.
To Reproduce
Steps to reproduce the behavior:

https://next.nostr.watch
Crash

Expected behavior
Does not crash
Screenshots

Desktop (please complete the following information):

MacOS Mojave
Chome:latest

Smartphone (please complete the following information):
n/a
Additional context

Resolved with hotfixes


Add Base (under review)

The messaging is not clear here regarding TVL, we show 0$, which probably is not true

LGTM


I can not join the airdrop

Hey.  What can be connected with the fact that I can not join the drop?  I have a UK country.  Number confirmed.  But he will not let him drop.

Same from France since more than 3 monthes. I first think about airdrop was just blocked but there is no answer despite some bug reports, I don't understand, I get success verification message, and as I click on Join, I get 'sorry you're not qualified " and on both Android, PC, and professional PC...


docs: Suggest clearer ReadMe for collaborators

Rework the ReadMe to be more easy and helpful, and erase the boiler plate.

[x] Documentation added
[x] Ready to be merged

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 2.42%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
90

Relevant Lines:
2825

💛  - Coveralls


grab JRE from minecraft folder on Mac

Will attempt to grab the Minecraft launcher's included JRE from ~/Library/Application Support/minecraft. Checks for runtime/jre-x64/jre.bundle/Contents/Home/bin/java, runtime/jre-legacy/jre.bundle/Contents/Home/bin/java, runtime/java-runtime-alpha/macos/java-runtime-alpha/jre.bundle/Contents/Home/bin/java, and runtime/java-runtime-beta/macos/java-runtime-beta/jre.bundle/Contents/Home/bin/java. Tested (lightly) and working!

@TheGlitch76 not sure I'm gonna have time to set up a proper app bundle build for a bit :<


Python script v2

updated script with generated files

Closed, since this branch is discontinued.

Closed, since this branch is discontinued.