Please publish alpine-parent before dependency-track

<artifactId>alpine-parent</artifactId>
<packaging>pom</packaging>
<version>2.2.6-SNAPSHOT</version>

You cannot build without downloading this version from Maven or go back to latest available release and hope it will run.

2.2.6 was never released. Due to various breaking changes it was renamed to 3.0.0-SNAPSHOT, and finally got released yesterday: https://github.com/stevespringett/Alpine/releases/tag/alpine-parent-3.0.1
Dependency-Track has already switched to the release version as of today.


Print: Entry, ":CFBundleIdentifier", Does Not Exist in react-native run-ios

** BUILD FAILED **
The following commands produced analyzer issues:
Analyze /Users/developer/AwesomeApp/node_modules/react-native/ReactCommon/yoga/yoga/YGNodeList.c
Analyze /Users/developer/AwesomeApp/node_modules/react-native/ReactCommon/yoga/yoga/Yoga.c

(2 commands with analyzer issues)
The following build commands failed:
Ld build/Build/Products/Debug-iphonesimulator/AwesomeApp.app/AwesomeApp normal x86_64
(1 failure)
Installing build/Build/Products/Debug-iphonesimulator/AwesomeApp.app
An error was encountered processing the command (domain=NSPOSIXErrorDomain, code=22):
Failed to install the requested application
The bundle identifier of the application could not be determined.
Ensure that the application's Info.plist contains a value for CFBundleIdentifier.
Print: Entry, ":CFBundleIdentifier", Does Not Exist
Command failed: /usr/libexec/PlistBuddy -c Print:CFBundleIdentifier build/Build/Products/Debug-iphonesimulator/AwesomeApp.app/Info.plist
Print: Entry, ":CFBundleIdentifier", Does Not Exist

+1

Same issue for me:
Environment:
Os: Mac Os High Sierra 10.13.1 (17B1003)
Node: 8.9.0
npm: v5.5.1
Watchman: 4.7.0
Xcode: Version 8.3 (8E162)
React Native: 0.55.3
create-react-native-app: 1.0.0

Steps to Reproduce
create-react-native-app appName
cd appName
npm run eject then select React Native: I'd like a regular React Native project
npm run ios
Expected Behavior
A successful build.
Actual Behavior
** BUILD FAILED **

The following build commands failed:

CompileC /Users/ksquarelabs/dev/courses/yucatan/ios/Build/Intermediates/React.build/Debug-iphonesimulator/React.build/Objects-normal/x86_64/RCTShadowView+Internal.o Views/RCTShadowView+Internal.m normal x86_64 objective-c com.apple.compilers.llvm.clang.1_0.compiler
(1 failure)

Installing build/Build/Products/Debug-iphonesimulator/yucatan.app
An error was encountered processing the command (domain=NSPOSIXErrorDomain, code=2):
Failed to install the requested application
An application bundle was not found at the provided path.
Provide a valid path to the desired application bundle.
Print: Entry, ":CFBundleIdentifier", Does Not Exist

Command failed: /usr/libexec/PlistBuddy -c Print:CFBundleIdentifier build/Build/Products/Debug-iphonesimulator/yucatan.app/Info.plist
Print: Entry, ":CFBundleIdentifier", Does Not Exist

+1

Please Fix this. I have the same problem, other similar issues did not work

+1
Os: Mac Os El Capitan 10.11.6
Node: 8.11.1
npm: 5.6.0
Watchman: 4.9.0
Xcode: Version 8.2.1
React Native: 0.55.3

I fixed this with updating my macOs and xcode.

I had this same problem... using:
Mac High Sierra
react-native-cli: 2.0.1
react-native: 0.57.3
Pulled my hair out, and could not find a solution.... Untill I went like this:
react-native init projectname
cd projectname
react-native start (this does the trick)
react-native run-ios
It will take a while, don't do Ctrl-c, the project will build.
:-)

npm uninstall react-native
delete ios and android folder
then run :
npm install react-native
react-native upgrade


Implement XA transaction JOIN logic

Description:
We always pass the TMNOFLAGS regardless of whether the current XAResource belongs to the same RM as any previous XAResource in the same XA transaction. Instead, in such a case need to pass TMJOIN flag.
Related Issues (optional):
https://github.com/ballerina-platform/ballerina-lang/issues/7963

We may need to consider this with the new transaction implementation.

@mohanvive  Does MySQL support JOIN/RESUME in XA START command?

In Swan Lake, we have introduced Atomokis based transactions for XA cases, thus above issue is avoided. Hence, closing the issue.

In Swan Lake, we have introduced Atomokis based transactions for XA cases, thus above issue is avoided. Hence, closing the issue.


Node API - Platform management and operations

create apis for all needed activities for data management and operations

This was closed as part of https://github.com/Project-Herophilus/DataSynthesis/tree/45-feature-revalidate-backend-data-tier-for-additional-needs-and-requirements. We included the work in this feature


Rename repository

The empty nlesc Python project could have a better name.
Ideas:

nlesc-python

Suggestions are welcome!

how about this?

new-python-package

I really would like to include a reference to the eScience Center in the name (so probably include 'nlesc'), @lodekulik do you have suggestions?

I agree that when the repository is under the NLeSC organization on github that is probably enough reference to the eScience center. At the moment I can't transfer the repository because I'm not allowed to create repos under the NLeSC organization. But when we have somehow done that, I think the name should indeed reflect that it's about creating a new python project/package.

Since we're trying to make the guide useful for all scientific software developers in the Netherlands (instead of NLeSC internal) and this package implements what we recommend in the guide, it would be good if we could avoid making this package too NLeSC specific.

It is exactly the intention to make it as non-nlesc-specific (and as useful for others) as possible. I would like to have the name nlesc attached, because it says something about quality (we help scientists to make high quality software) and helps the center to be recognized as having impact.
I also think having the repository in the nlesc organization is sufficient to achieve these goals.


'%20' caractere turning into '%2b'

Versions

nuxt: v2.14.12
node: v15.2.0

Reproduction
https://7yf7h.sse.codesandbox.io/?email=some aemail.com
What is Expected?
output: some aemail.com
What is actually happening?
output: some+aemail.com

Hi @pedrolages-hotmart. I can confirm this bug. Since we use same encoding of vue-router (plus as space) but i guess we need to also do decoding with respect to it currently it uses decodeURI

Hi @pedrolages-hotmart. I can confirm this bug. Since we use same encoding of vue-router (plus as space) but i guess we need to also do decoding with respect to it currently it uses decodeURI

Hi @pedrolages-hotmart. I can confirm this bug. Since we use same encoding of vue-router (plus as space) but i guess we need to also do decoding with respect to it currently it uses decodeURI

@pi0 hello, I also encountered a related problem #8690

Hi @pedrolages-hotmart. I can confirm this bug. Since we use same encoding of vue-router (plus as space) but i guess we need to also do decoding with respect to it currently it uses decodeURI

@pi0 hello, I also encountered a related problem #8690

@danielroe I am able to see this in nuxt v2.16.3. Under which version shall I expect this fix? If not yet released, is there a workaround I could use?

It should have been fixed in 2.15.0. If you are still experiencing an issue, feel free to open a new issue with a reproduction.


When I hit the right arrow to complete the suggestion .. characters in the beginning are deleted

When I use the default script few letters at the beginning of the suggestion gets deleted.
Steps to reproduce:
a) let say I had entered
echo $SHELL
b) now with the suggestion I will see as soon as I press letter 'e'
echo $SHELL
however, when I hit the right arrow for completion, the cursor will move on $SHELL, and the letter 'e' at the beginning is deleted and if I hit the right arrow again, I will lose another character and cursor will reach end.
cho $SHELL
ho $SHELL
I am using ZSH on MAC OS BIG sur latest version.

This sounds a little like #570 and #578. I would look into your prompt as a possible cause. See if you can reproduce with zsh -df and sourcing the plugin manually. If you can't reproduce in that environment, it's likely something your ~/.zshrc is causing the trouble. Try commenting out your whole ~/.zshrc and incrementally adding chunks back in to track down the cause of the problem.


target.page() returns a stale page

Puppeteer version<EMAIL_ADDRESS>Platform / OS version: MacOS Mojave/10.14.6
URLs (if applicable):
Node.js version: v12.16.1

Problem Description
I am trying to automate page actions using Selenium while trying to capture pages/requests using Puppeteer. My selenium script is really simple. It tries to load two pages one after the other.
Steps to reproduce

Open the browser via Selenium-Webdriver.
Attach to the browser via Puppeteer.
Start the puppeteer instrumentation script.

Puppeteer code that reproduces the issue is here:
    browser.on('targetchanged', function(target) {
        if (target.type() === "page") {
            writer.writeTargetEvent('targetchanged', target);
            target.page().then(function(page) {
                writer.writeLog('New page: ' + page.url());
            });
        }
    });

What is the expected result?
target.url() and target.page.url() must match.
What happens instead?
You can see these logs:
1585654628828	Connected to browser: Chrome/80.0.3987.149
1585654629932	{"eventType":"targetchanged","targetType":"page","targetURL":"https://www.marvel.com/"}
1585654629979	New page: https://www.marvel.com/
1585654635584	{"eventType":"targetchanged","targetType":"page","targetURL":"https://www.smashingmagazine.com/"}
1585654635584	New page: https://www.marvel.com/
page.target() returned https://www.marvel.com/ although the URL had been changed to https://www.smashingmagazine.com/. I think it takes some time for target change to get reflected in the target's page object. Since the page is returned almost immediately, the returned page does not have that change.

This looks very similar to https://github.com/puppeteer/puppeteer/issues/4382. It can be closed as a duplicate but I will let maintainers have a look. <- @aslushnikov


Add a hint to the important upgrade notes

Inspired by the discussion in this thread:
https://community.mattermost.com/core/pl/epfetybuxjniiq8mwjh6ffw3gh

Summary

Ticket Link

Hello @anx-ag,
Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here.


cargo fmt doesn't pass arguments to rustfmt when ran through rustup

└─ rustup run nightly cargo fmt -- --write-mode=diff
Unrecognized option: 'write-mode'
<help for cargo fmt>

└─ cargo +nightly fmt -- --write-mode=diff
<works>

Originally mentioned here where it was confirmed by @CraZySacX.

Rustup uses clap when not in proxy mode, and it removes --.
let res = App::new("")
    .arg(
        Arg::with_name("command")
            .required(true)
            .multiple(true)
            .use_delimiter(false),
    )
    .get_matches_from_safe(vec!["cargo", "fmt", "--", "--write-mode=diff"]);
println!(
    "{:?}",
    res.unwrap()
        .values_of("command")
        .unwrap()
        .collect::<Vec<_>>()
); // prints ["cargo", "fmt", "--write-mode=diff"]

Does anyone happen to have a workaround for this one? I'm trying to put rustfmt in a precommit hook, but this problem unfortunately makes it impossible as far as I can tell (without making nightly my default toolchain I mean).

It seems that there is no technical solution here and we just need to document the difference and the work around.

I don't think this is an issue anymore. I can run rustup run nightly cargo fmt -- --emit=stdout in the root of the rustfmt repo and it seems to pass the --emit=stdout to rustfmt just fine.
The workaround for the original issue cargo +nightly fmt -- --emit=stdout also works just fine.


[feature request] Can add top 100 list?

Top 100 list is also usefull. I know the current version has have some list. Add another may be quick.

I have added in my repo. So I closed it now


page selection dropdown menu: highlight current

The current implementation makes the dropdown menu for page selection somewhat ineffective: It does not highlight the page which is currently active, and one cannot just click out of the menu to make it disappear again. Thus, one is forced to jump somewhere and (unless one still remembers exactly the current page name) the current position gets lost.

It does not highlight the page which is currently active
Good idea, will get added.
one cannot just click out of the menu to make it disappear again. Thus, one is forced to jump somewhere and (unless one still remembers exactly the current page name) the current position gets lost.
Clicking anywhere but on the canvas or pressing the "ESC" key should work.
Deselect on canvas click will get added though.

Clicking anywhere but on the canvas or pressing the "ESC" key should work.

Ah, thanks!

The page selection dropdown was reimplemented using Select2. The dropdown now highlights the currently selected page, allows "free text" search and is auto-adjusts its width to the longest file name.


Using a custom dataset

I'm having OOM issues trying to run a custom dataset of 256x256 resolution. Apart from creating a YAML config file for my dataset does anything else need to implemented for this to work?

You can try to reduce the batch size first, depending on your GPU memory size.
Since gpu_options.allow_growth is set to True, you can first set the batch size to a very small size (such as 4 or 8), and see what is the portion of the GPU memory is occupied (with nvidia-smi). Then you can decide the maximum batch size your GPU can accommodate.
In a more advanced way, if you are sure that your images have less dependency between patches that are far away, you can try to tune the micro patch size and macro patch size a bit. Such as setting them both to a smaller value (such as 32x32 and 64x64, respectively, for your 256x256 images), but I am not entirely sure about how Tensorflow will deal with it in the backend.
Lastly, a brute-force solution is resizing your images to a smaller size (such as 128x128), do the training and generation, then upsample the results back to 256x256. It will get your training a lot faster, requires less memory, and the resulting quality will still be good (though a bit blurry).


[Bug]: page client.on doesn't works

Bug description
client.on("Network.webSocketFrameSent", ({ requestId, timestamp, response }) => {
^
TypeError: client.on is not a function
why?
var puppeteer = require("puppeteer");

(async () => {
    var browser = await puppeteer.launch({
        args: [
            "--no-sandbox",
            "--disable-setuid-sandbox",
            "--disable-infobars",
            "--window-position=0,0",
            "--window-size=1366,768"
        ],
        defaultViewport: null,
        ignoreHTTPSErrors: true,
        headless: false
    });
    var MainPage = await browser.newPage();
    var client = MainPage._client;
    client.on("Network.webSocketFrameSent", ({ requestId, timestamp, response }) => {
        console.log("[1]");
    });
})();

Puppeteer version
14.4.0
Node.js version
16.13.0
npm version
8.1.2
What operating system are you seeing the problem on?
Windows
Relevant log output
No response

You can use _client(), but please remember all internal APIs are subject to breakage without notification.

FROM 👍:
await page._client.send("Page.setDownloadBehavior", {             behavior: "allow",             downloadPath: folderName,           });
LATEST:
await page._client().send("Page.setDownloadBehavior", {             behavior: "allow",             downloadPath: folderName,           });


Generic interface registration

How can I make container able to resolve for example ILogger? I cannot inherit from IContainer<ILogger<>>.

See https://github.com/YairHalberstadt/stronginject#generic-factory-methods


Static route "nexthop_type" doesn't support None as PAN-OS

Describe the bug
In Static Route class (panos/network). There are no options to implement static route with "None" or Discard.
class StaticRoute(VersionedPanObject):
... info deleted ...
def _setup(self):
... info deleted ...
params.append(
VersionedParamPath(
"nexthop_type",
default="ip-address",
values=["discard", "ip-address", "next-vr"],
path="nexthop/{nexthop_type}",
)
)
Expected behavior
Expected behavior is to support static routes with options for "None" and Discard. None is required to route traffic in IPSec tunnel interfaces or P2P interfaces. Discard is required to send the packet to null ..
Current behavior
Current behavior supports only (ip, fqdn, next-vr) next-hop.
Possible solution
Add None option, where NO "path="nexthop/{nexthop_type}"" is send
Add discard option, where xpath "nexthop/discard" is send
Steps to reproduce
Deploy static route with no next-hop like below ..
virtual_router = fw.add(
    pannet.VirtualRouter(
        name="default",
    )
)
static_route = pannet.StaticRoute(
    name="test-subnet",
    destination="<IP_ADDRESS>/24",
    interface="tunnel.100",
)
virtual_router.add(static_route)
static_route.apply()

below errors is received ..
panos.errors.PanDeviceXapiError:  routing-table -> ip -> static-route -> test-subnet -> nexthop is invalid

Sometimes none in the GUI is implemented as python None, sometimes none is "none", sometimes none is "None".  In this particular case, you want to do nexthop_type=None, so do python None.
To discard, you do nexthop_type="discard".


endpoint end_session -- error 404 - not found

Describe the bug
We have our own instance and when we tried to access the end session endpoint, we got http 404 error.
In this link you can see the available endpoints: https://auth.stolzlabs.com/.well-known/openid-configuration
We only got the 404 error at https://auth.stolzlabs.com/oidc/v1/end_session.
what are we doing wrong?
Version
Zitadel version v2.0.0-v2-alpha.43
The same happened in the older versions.

Hi
I think there could be a bug how the endpoint reacts. Currently you should receive a 302 that redirects to a broken link instead of returning a 200 code.
If you invoke the endpoint you should be logged out even thought the redirects makes no sense.
@livio-a lets us have a look on this on Monday.

@MLStoltzenburg
I can confirm there is a 🐞 if you directly call the end_session endpoint 😁
However your application normally will call the endpoint while supplying at least the id_token_hint while optionally specifying additional params post_logout_redirect_uri, state. We built on the draft spec of OpenID Connect RP-Initiated Logout 1.0

Hi,
You are right!
When I put the id_token_hint I got 302 where the redirecting to logout page was done, but I have a question.
How to know if the token has been invalidated? Because when I went back to the login page the user was still active.
BTW, I request the end_session endpoint directly and not using AppAuth or Webview.
I don't like when I open another screen over the App, so I developed the PKCE standard within the App and I got successful in the login process through webview.
I've been using the same routine with Keycloak for months and it's working great. My problem with Zitadel is when I need to log out.
Another situation:
I ran the same command couple times via cURL and realized that it always returns 302, I believe that after the first logout with the same token the result should be "not permission" or "invalid token", but I'm not sure.
Thanks!

When I put the id_token_hint I got 302 where the redirecting to logout page was done, but I have a question.
How to know if the token has been invalidated? Because when I went back to the login page the user was still active

So you were able to login without any need for authentication?

BTW, I request the end_session endpoint directly and not using AppAuth or Webview.
I don't like when I open another screen over the App, so I developed the PKCE standard within the App and I got successful in the login process through webview.

That's good to know. ZITADEL stores a cookie for each user-agent to handle the sessions of multiple users.
So what acutally work besides sending the id_token_hint is to just call the end_session endpoint with that cookie (__Secure-zitadel.useragent) present. This should invoke a 302 to the default post_logout_redirect (this is where we have the bug)

I ran the same command couple times via cURL and realized that it always returns 302, I believe that after the first logout with the same token the result should be "not permission" or "invalid token", but I'm not sure.

This is somewhat undefined in the spec but I think it would be worth to return an error directly instead of redirecting
What are your thoughts on this @livio-a

@fforootd

So you were able to login without any need for authentication?

Yes!
I noticed that even running the endession endpoint, the __Secure-zitadel.useragent is still active, but remember I ran it outside of the webview, so the Zitadel Cookies was not updated.
I believed that the token would be revoked after the session ended.
I tested another weird thing:
I opened a browser and executed the end session endpoint link with another user's id_token_hint and my active session disconnected!
For example: "In my browser I was logged in with user A, I opened a new tab and ran the end session endpoint with user B's token, so user A was also logged out"
In my opinion this cannot happen. Right?

I believed that the token would be revoked after the session ended.

The token should be immediately invalid, but since the session of the user persist you get a new one easily

I opened a browser and executed the end session endpoint link with another user's id_token_hint and my active session disconnected!
In my opinion this cannot happen. Right?

Hm this sounds like a precedence bug, @livio-a we should look into this one

The token should be immediately invalid, but since the session of the user persist you get a new one easily

I understood! So, do I need to update   __Secure-zitadel.useragent to work fine?
I have an idea! Once I get the response, I'll update the cookie in my webview and check the result!
I know when I clear cookies in the webview the user has to enter a username again, but I would like the user don't do that, just enter their password, like on browser.
Question: What the cookies do i need update, only __Secure-zitadel.useragent or something else?

I understood! So, do I need to update __Secure-zitadel.useragent to work fine?

It only must be present during the call to end_session.

Question: What the cookies do i need update, only __Secure-zitadel.useragent or something else?

I think you need to allow csrf cookies as well but only the cookie above is relevant for the user session.

@fforootd
It works!
I got successful now!
I put the cookie in my direct command and I could do logout in right way.
The user now is inactive!
Thank you very much for your help!

Awesome 👏

fixed with #4054


Moved to Ruby 2.7.0 [EXPERIMENT, NOT READY FOR MERGE]

.travis/docker-test.sh passes (using custom passenger image), but still lots of errors when running whole test suite and lots of warnings. Sending pull requests to have a record in Travis CI of all problems.

Coverage remained the same at ?% when pulling 1b3e7aa762f9f5843698f570ef899bf94e582631 on ruby27 into 30dfbc41323e9c6793c2a0f429e2042870a74ad8 on development.


Create a cask for CleanMyMac #

CleanMyMac3 is out :D
See http://macpaw.com/cleanmymac

It's on the way... see #10465 :wink:


Show notes locations on the map chooser panel

in micromapping and amenity modes, current location pointer in the middle of the screen (black inverted raindrop image) is shown at all times, allowing for precise position that is shared between modes.
Alas, in Notes screen current location pointer is shown only when adding a new note. That makes one unable to make it point to note exactly, and then switch to another mode to use information from note to update/create amenity.
e.g. it is hard from the first picture to determine which amenity (second picture) needs to be edited here:

The problem is additionally exacerbated by non-persistent zoom issue (https://github.com/Zverik/every_door/issues/230)
So, could we have a location pointer shown at all times in Notes mode (as it is shown in Amenity/Micromapping modes)?

Showing the location marker in the notes mode does not solve this issue directly. Instead, I'm changing this issue to displaying notes locations on the map chooser screen when adding a new object/amenity.

Done in 3.0.


the scroll stable branch

issues:

check_rw_lookup does not work well for RETURN.
we must use parallel iter to calculate witness of keccak circuit

RLP circuit PR: #233

Tx circuit PR: #220,
PI circuit PR: #220

the CI is becoming slower and slower... We may need to re-pick this: https://github.com/scroll-tech/zkevm-circuits/pull/193

Yeah, I think so. Running make test on my local machine(with 72 threads) needs about 9min to finish.

tx_circuit_1tx_2max_tx failed

@silathdiir oh each action run twice... in my above commit (push directly to scroll-stable). Can you help fix that?

wait me to fix this..


More useful summaries

Example:

The Dockerfile contains the following contents,
FROM postgres:15.2

ENV POSTGRES_USER=${POSTGRES_USER}
ENV POSTGRES_PASSWORD=${POSTGRES_PASSWORD}

EXPOSE ${POSTGRES_PORT}

A better summary would highlight the Dockerfile instantiates a containerized Postgres database.

Some ideas in addition to #23:

Get rid of extraneous spaces in prompt
Add the fully expanded directory tree into the prompt
Prime the model with a few examples
Add the summaries generated so far to generate the next summary


Slow initial s/w install is a pain during migration to Ploutos

When initially migrating a repo to use Ploutos the config you use won't be perfect or won't work at all and will need refining. However, even if the first action run installed dependent s/w such as cargo-deb and cargo-generate-rpm, subsequent runs while refining will redo those slow install steps. This is because actions/cache won't save the installed s/w to cache if the job fails.
This is a known issue with actions/cache. Recently https://github.com/actions/cache/discussions/1020 proposed a solution, for us this would meaning using the new actions/cache/save action, once it becomes available, to save the cache earlier in the job.

An initial (succesful!) test of the still-WIP upstream branch can be seen here: https://github.com/NLnetLabs/rotonda-runtime/actions/runs/3676767416/jobs/6217846003

Fixed in the v5.2.0 release.


No reaction on Redeploy

No reaction to php composer.phar run-script post-install-cmd -- --redeploy
One first deploy with shared vendor has magento core files. Others don't.

There is no such --redeploy option here. Core is only installed when it is initially required or the version is updated. Please see the readme: https://github.com/AydinHassan/magento-core-composer-installer/blob/master/README.md

How I copy once again ? after installing ?

I'm not sure, I don't really think a shard vendor is a great idea. If some update or install fails, your site is basically broken.

ok, thanks

I would accept a PR to add such functionality but I'm a bit busy with other projects to do this myself now, sorry. Do you definitely need to share the vendor folder? How do you deploy?
Sent from my iPhone

On 7 Sep 2015, at 20:53, Nikita<EMAIL_ADDRESS>wrote:
ok, thanks
—
Reply to this email directly or view it on GitHub.

You are right about shared vendor.
btw I am deploying via mina and used shared vendor to speed up installations, but now I can't understand why I didn't noticed possible problems.

@luckyraul I learn from experience also. We did it for the exact same reasons. Most of the time composer's cache should suffice. It usually makes a lot of difference!


fix imports (to be vendoring compatible) in client refactor

Current behavior:
There are imports like import tuf.settings which are not compatible with vendoring
Expected behavior:
Use from tuf import settings (or import specific names from the module if the case requires it)

Fixed in #1328


[Feature]: Refine interval tree implementation

Description about the feature
The interval tree at #656 is a rough implementation currently, restricted to internal use only. It could be refined to improve code readability and offer a more user-friendly API.
Code of Conduct

[X] I agree to follow this project's Code of Conduct

Please assign to me:)

/assignme


Use dotnet core instead

As the project is very light, use dotnet core instead.
Convert the .net framework projects to use .net core instead.

After this task is done, we can modify the travis yml to run the unit tests.


remove excess decimal places from y axis

Documentation of method
I can provide a visual of what I'm trying to fix if needed.


Move stats and qr mods from iapyx to catalyst-toolbox

I've developed some utils needed for tests or for business stakeholders with stats regarding active voters or total amount of ada used in voting. This PR is an attempt to move qr decoding/verifying cli command as well as snapshot/block/fragment logs statistics

everything should be treated as new, since there were used in test code only and review only partially


ARROW-11125: [Rust] Logical equality for list arrays

This is blocking my work on the nested parquet list writer. I had left out list logical equality due to the M:N nature of lists, which requires iterating over the parent list to create the child null buffer/bitmap.

@jorgecarleitao @alamb this is in substance ready for review,, I'd like some feedback on the approach if you get the time.
There's a few TODOs that I left for myself, which I'll address in the coming hours.

@jorgecarleitao @alamb this is in substance ready for review,, I'd like some feedback on the approach if you get the time.
There's a few TODOs that I left for myself, which I'll address in the coming hours.

I saw the clippy warning, I'll fix it

I saw the clippy warning, I'll fix it

Thanks for the review @jorgecarleitao. I've addressed your queries and comments, and cleaned up the TODOs

Thanks for the review @jorgecarleitao. I've addressed your queries and comments, and cleaned up the TODOs


Added getNativeWindowHandle method

As discussed here https://github.com/atom/electron/issues/3219
Returns the native OS window handle in a buffer.
Not sure about the Mac implementation, if someone could double-check me.

Updated the docs.

Thanks!

I think I have an issue with this metthod on Windows. I can't get back the original HWND of the Chrome window. Would it be an issue with the Node Buffer ? I saw that the buffer is create using node::Buffer::New which directly use given pointer. I would be better to use node::Buffer::Copy that is doing a copy of the given bytes to a new memory location. Your view ?


Remove right shifting by 4 on palette number when computing the spn_bits

The palette number is computed for 16 color palettes by shifting by either 5 or 6 when calling VDP2_SCRN_PND_MODE_0_PAL_NUM / VDP2_SCRN_PND_MODE_1_PAL_NUM or VDP2_SCRN_PND_MODE_2_PAL_NUM. This leaves the remaining 3 bits in the palette_number by the time this is used for calculating the supplementary palette number in vdp2_scrn_pnd_set. This changes removes shifting the value by a further 4 bits, as currently this deteriorates bank numbers that sit in this range.
Currently to access the second 16 color CRAM bank you have to set an offset using for example VDP2_CRAM_MODE_0_OFFSET(0, 16, 0) after this change you can access the second bank using VDP2_CRAM_MODE_0_OFFSET(0, 1, 0). This change only affects 16 color palettes, although I am not sure if any further parts of yaul touch the spn_bits, or there is a related change required for the cram_offset calculation.

Thank you for the PR.
Do you have an example that I could run that reproduces the issue?

Jumping in to mention that would be nice to have a reproducible example so we can start automating tests in the future

Jumping in to mention that would be nice to have a reproducible example so we can start automating tests in the future

Agreed. One day🤞🏽


Use new Pester syntax: -Parameter for Pester tests in engine.

PR Summary
Use new Pester syntax: -Parameter for Pester tests in engine.
PR Checklist

[ ] PR has a meaningful title

Use the present tense and imperative mood when describing your changes

[ ] Summarized changes
[ ] Change is not breaking
[ ] Make sure all .h, .cpp, .cs, .ps1 and .psm1 files have the correct copyright header
[ ] This PR is ready to merge and is not Work in Progress.

If the PR is work in progress, please add the prefix WIP: to the beginning of the title and remove the prefix when the PR is ready.

User-facing changes

[ ] Not Applicable
OR
[ ] User-facing Documentation needed

[ ] Issue filed - Issue link:

Testing - New and feature

[ ] Not Applicable or can only be tested interactively
OR
[ ] Make sure you've added a new test if existing tests do not effectively test the code changed

[ ] Add [feature] if the change is significant or affects feature tests

Accidentally the branch was not based on master and contained changes for other issue.


Prepare for multiple weathers in a response

Currently, obtain_weather_from_response parses the JSON response from OpenWeatherMap and it returns the first element in the "weather" array, that contains the weather requested. This isn't a problem in most situations, because weather will be a 1 element array, but if it has more than one element (i.e. rain + wind) we will only get the first one.
Update the method weather.obtain_weather_from_response and the methods that call it to prepare them to get multiple weather elements.

Solved in commits 89c0266f74fbc2e7ddd90ef487249867bdc7fdd0 and fffc5cff3a18d17b1261b9d30c6a44bff8839882


Carpark tab portrait

The carpark tab should: use larger font; printed portrait; include only Rider number, first/last name and have space for odo & time

Done


How i put filters above or below column's names ?

Hello,
I use vuetable-2 that I find very well, and i start with vuejs 2, i would like add my filters above or below column's names with html tag thread tr td. (like this grid example : http://grids-demo.herokuapp.com/demo/example4)
I have this  http://imgur.com/a/I9laA and it's work.
Does somebody have an idea ?
Thank you in advance for your help.

@germ1f Have you check out this tutorial lesson?

Yes, i see your tutorial and it's work but i would like add my filter under colum's name in vuetable but i don't know if it's possible.

Sorry, it's not possible. The only way right now is to fork it and try to implement that.

ok, thanks ! I try this !

@ratiw Would you be open to a pull request for the column search fields?  I can go ahead and add them and show them by using  a prop.

@SimplyCorey You are very welcome and a very nice of you to share it.
However, please don't feel bad if it doesn't get merged. But I'll make it will be linked to when someone asks about this.

I made an extended version of @germ1f  with simultaneously multiple column filter. Also added 3 types of filter a simple input, a datepicker or a dropdown menu which accepts dynamic data. Until you release your next major version I believe is a solution. @ratiw thank you for your implementation.
Multiple column filters


Run tests on Travis directly with xcodebuild instead of fastlane

With this PR, tests should still fail, but at least Travis will give a hint of which test(s) failed.

Executed 161 tests, with 1 failure (0 unexpected) in 3.722 (4.230) seconds

Failing tests:
InCoordinatorTests.testShowRequstFlow()
** TEST FAILED **

The failing test(s) themselves have been fixed in #589


Hide irrelevant crossing:markings values

Describe the bug
Not all values of the crossing:markings are used in each country. It would be good to show only ones which are used in the currently edited country. For example, in Bulgaria you will find only dashed, dotted and zebra
To Reproduce
Steps to reproduce the behavior:

Go to https://www.openstreetmap.org/node/5337183644
Click "Edit"
Select the crossing markings field

Expected behavior
Only relevant values should be present for each country (if that's even possible).
Screenshots

It is possible to implement this for Bulgaria, by creating a redundant field that applies just to Bulgaria and excluding Bulgaria from the global one. You might need to create a redundant set of crossing presets as well.
There are also countries where some values are extremely rare but do exist occasionally. If these values are omitted, then they’ll be undiscoverable, but the field should still show the value if you select a feature that already has the value.
Addressing this issue more broadly would require a change to iD rather than just the schema files here. I’ve been wondering if Geofabrik’s country-specific taginfo instances would be able to handle load from integration into iD. If so, we could hook up iD to those instances instead of the global one, so that the values can be sorted by regional prevalence. I think this would only be prudent for certain keys like crossing:markings that inherently vary by region; we wouldn’t want to fragment the tagging scheme in general.

I was thinking of something like include and exclude for each option. I'm also not a big fan of the regional presets/fields.

Addressing this issue more broadly would require a change to iD rather than just the schema files here. I’ve been wondering if Geofabrik’s country-specific taginfo instances would be able to handle load from integration into iD. If so, we could hook up iD to those instances instead of the global one, so that the values can be sorted by regional prevalence. I think this would only be prudent for certain keys like crossing:markings that inherently vary by region; we wouldn’t want to fragment the tagging scheme in general.

That may be a better idea, assuming we have enough data for each country.

I'm also not a big fan of the regional presets/fields.

May I ask you why?

You might need to create a redundant set of crossing presets as well.

Actually, for cases like this one (where only the field values depend on a specific region) this is not necessary. It's sufficient to just change the default field to exclude the region for which a new regional version is to be created, and to include the new field in addition to the default field wherever that one is already used.

There are also countries where some values are extremely rare but do exist occasionally. If these values are omitted, then they’ll be undiscoverable

This is actually a valid downside of the regional fields approach. :thinking: It's however not something that could not be fixed, though: for example, there could be a new property added to the schema which allows one to customize the order of the options, or alternatively to hide extra options in an ellipsis … entry.

I’ve been wondering if Geofabrik’s country-specific taginfo instances would be able to handle load from integration into iD. If so, we could hook up iD to those instances instead of the global one, so that the values can be sorted by regional prevalence.

Interesting idea. I'd be hesitant to solely rely on regional taginfo data, because especially for small regions and/or rare-ish tags, there might just not be sufficiently much data to be useful. But for sorting entries by regional usage it could definitely be nice. :+1:
//cc @woodpeck @joto: how would you assess the possibility of accessing geofabrik's regional taginfo API from iD?
PS: note to self: this josm ticket contains some useful info about matching geofabrik regions: https://josm.openstreetmap.de/ticket/18729

I'm also not a big fan of the regional presets/fields.

May I ask you why?

They seem to create yet another field to translate in Transifex. It may have changed since last time I checked.

There are also countries where some values are extremely rare but do exist occasionally. If these values are omitted, then they’ll be undiscoverable

This is actually a valid downside of the regional fields approach. 🤔 It's however not something that could not be fixed, though: for example, there could be a new property added to the schema which allows one to customize the order of the options, or alternatively to hide extra options in an ellipsis … entry.

I think that the elipsis ... option may be better and it should remove the scroll bar for most (if not all) countries.

[Regional presets] seem to create yet another field to translate in Transifex. It may have changed since last time I checked.

Since version 5, one can cross reference strings between presets (e.g. the regional presets/fields can implicitly reuse the name, aliases, placeholder text and value strings from the main preset/field), solving this problem. :blush:


thread 'main' panicked at 'Max out 5 attempts to launch swarm', libra_swarm/src/swarm.rs:255:9

🐛 Bug

I ran the command

cargo run -p libra_swarm -- -s

and got the error about
thread 'main' panicked at 'Max out 5 attempts to launch swarm', libra_swarm/src/swarm.rs:255:9
To reproduce
I am running on Ubuntu 18.04 behind a corporate proxy . I ran the command

cargo build --all --bins

It gave an issue of missing zlib libraries and i had to install

sudo apt-get install zlib1g-dev

# Your code goes here
# Please make sure it does not require any external dependencies

** Stack trace/error message **
Finished dev [unoptimized + debuginfo] target(s) in 0.23s
Running target/debug/libra_swarm -s
Faucet account created in file "/tmp/keypair.LYCFh8HC7tOC/temp_faucet_keys"
Base directory containing logs and configs: "/tmp/.tmpN0aKAY"
Base directory containing logs and configs: "/tmp/.tmpDAPOvJ"
Base directory containing logs and configs: "/tmp/.tmphgjnz0"
Base directory containing logs and configs: "/tmp/.tmp6myTVs"
Base directory containing logs and configs: "/tmp/.tmpMnnmdc"
thread 'main' panicked at 'Max out 5 attempts to launch swarm', libra_swarm/src/swarm.rs:255:9
note: Run with RUST_BACKTRACE=1 environment variable to display a backtrace.

## Expected Behavior

<!-- A clear and concise description of what you expected to happen. -->

## System information

**Please complete the following information:**
- <!-- Libra Version -->
- rustup 1.18.3 (435397f48 2019-05-22)
- Ubuntu 18.04 4.15.0-51-generic #55-Ubuntu SMP Wed May 15 14:27:21 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

## Additional context

I checked the /tmp directory . I see other .tmp files containing the metrics folder being created . But I do not see the keypair directory or the logs and config directory ( the permissions exist ) . I assumed the directories were cleaned up on exit but even while the server was running I do not see any of these directories getting created

Thanks for the report. The keypair and logs are probably deleted after the run failed libra swarm run. Does it always fail? One or some of the 5 validators might not start successfully. Could you check the log and see why the validators failed to start?

Could you tell me where the logs are present ?
On Wednesday, June 26, 2019, xfyfb<EMAIL_ADDRESS>wrote:

Thanks for the report. The keypair and logs are probably deleted after
the run failed libra swarm run. Does it always fail? One or some of the 5
validators might not start successfully. Could you check the log and see
why the validators failed to start?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.<
https://ci6.googleusercontent.com/proxy/Uv9XSC2TVxye-nyimQHqlgrpUM-DM7cWmuKbBHtaP9Wn4wEH-Tm5t9I5bQdaV4PIljTHl5Hrn4CFir91RYHRqUuoJQ561Z-RVXDzD6b70iASU9-CRMrY_GiB2p5AIoA7fev300tWkPqUOc0198r9d7lDNOBS8rVwHR6nNintVIZCqZ8VYG2RRuQo5PmDOAPzwU581hqod1ucvH_FFNu1SiJlDITFqLoCEx66C5BAyQ=s0-d-e1-ft#https://github.com/notifications/beacon/AADNEDHVTEPFKDBFRRWTY4DP4OT2FA5CNFSM4H3QH3Y2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODYUJZZI.gif>

And yes it always fails
On Wednesday, June 26, 2019, xfyfb<EMAIL_ADDRESS>wrote:

Thanks for the report. The keypair and logs are probably deleted after
the run failed libra swarm run. Does it always fail? One or some of the 5
validators might not start successfully. Could you check the log and see
why the validators failed to start?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.<
https://ci6.googleusercontent.com/proxy/Uv9XSC2TVxye-nyimQHqlgrpUM-DM7cWmuKbBHtaP9Wn4wEH-Tm5t9I5bQdaV4PIljTHl5Hrn4CFir91RYHRqUuoJQ561Z-RVXDzD6b70iASU9-CRMrY_GiB2p5AIoA7fev300tWkPqUOc0198r9d7lDNOBS8rVwHR6nNintVIZCqZ8VYG2RRuQo5PmDOAPzwU581hqod1ucvH_FFNu1SiJlDITFqLoCEx66C5BAyQ=s0-d-e1-ft#https://github.com/notifications/beacon/AADNEDHVTEPFKDBFRRWTY4DP4OT2FA5CNFSM4H3QH3Y2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODYUJZZI.gif>

Oh, I forgot the log might be deleted in your case. It should be under base_dir/logs.
Can you try to use -n parameter of libra swarm to start with fewer nodes, e.g
cargo run -p libra_swarm -- -n 1
to run with 1 node.

I ran this in a different machine but the same configuration ( Ubuntu 18.04 ) .
The only difference was that this was not behind a corporate proxy
And it works without any issues .
There could be a possibility that the files were committed during this time . The current version of my git clone is

git rev-parse HEAD
737839b744794c0ca3be3db2934de7ebf056639a

I do not have access to the other environment currently . I will do a check and update the git rev-parse version of the other installation .
BTW the logs directory does not seem to exist in the base_dir/logs

This seems to be an issue with the proxy settings . I had to set the http_proxy and the https_proxy variables for the cargo command to work . But using this causes the libra_swarm to fail to connect to the localhost . I solved the problem by

unset http_proxy; unset https_proxy ; cargo run -p libra_swarm -- -s

and things work .

Glad that it is resolved. Could you close it if there is no other isssue?

I have encountered the same issue but not behind a corporate proxy and without http*_proxy enviroment variables set, so the solution above would not work in my case.
The panic message (same as this issue) has no indication of what went wrong, the stack trace is not helpful too(all from core:: or std::). Still investigating.

It turns out the logs are in temp location and deleted when panicked. Take a look at the code, just change the parameter tee_logs of LibraSwarm::launch_swarm from false to true, the log will be printed to stderr.
The relevant part of the log looks like this:
[8deeeaed] I0629 15:36:17.832982<PHONE_NUMBER>89792 execution/executor/src/lib.rs:85] Startup info is empty. Will start from GENESIS.
[8deeeaed] D0629 15:36:17.833728<PHONE_NUMBER>89792 execution/executor/src/lib.rs:172] Received request to execute block. Parent id: 5052455f47454e455349535f424c4f434b5f4944000000000000000000000000. Id: 47454e455349535f424c4f434b5f494400000000000000000000000000000000.
[8deeeaed] D0629 15:36:17.837146<PHONE_NUMBER>89792 execution/executor/src/block_processor.rs:627] Execution status: [Keep(Execution(Executed))]
[8deeeaed] D0629 15:36:17.841612<PHONE_NUMBER>89792 execution/executor/src/lib.rs:204] Received request to commit block 47454e455349535f424c4f434b5f494400000000000000000000000000000000.
[8deeeaed] D0629 15:36:17.842989<PHONE_NUMBER>89792 storage/storage_service/src/lib.rs:259] [GRPC] Storage::save_transactions
[8deeeaed] I0629 15:36:17.848332<PHONE_NUMBER>89792 execution/executor/src/lib.rs:162] GENESIS transaction is committed.
[8deeeaed] D0629 15:36:17.863191<PHONE_NUMBER>89792 libra_node/src/main_node.rs:226] Execution service started in 33 ms
[8deeeaed] D0629 15:36:17.866759<PHONE_NUMBER>89792 network/src/peer_manager/mod.rs:528] listening on "/ip4/<IP_ADDRESS>/tcp/50462"
[8deeeaed] D0629 15:36:17.867859<PHONE_NUMBER>89792 network/src/peer_manager/mod.rs:545] Incoming connections listener Task started
[8deeeaed] D0629 15:36:17.868415<PHONE_NUMBER>89792 libra_node/src/main_node.rs:237] Network started in 5 ms
[8deeeaed] D0629 15:36:17.877199<PHONE_NUMBER>89792 libra_node/src/main_node.rs:242] AC started in 8 ms
[8deeeaed] E0629 15:36:17.877394000<PHONE_NUMBER>83616 wakeup_fd_pipe.cc:40]         pipe creation failed (24): Too many open files

while other applications work well on my MBP without complaining Too many open files.

I've faced the same problem and this one doesn't work for me.

unset http_proxy; unset https_proxy ; cargo run -p libra_swarm -- -s

Then I printed out the log some attempt got this:
[8deeeaed] D0630 09:42:40.041255<PHONE_NUMBER>31232 libra_node/src/main_node.rs:219] Storage service started in 247 ms
[8deeeaed] D0630 09:42:40.043770<PHONE_NUMBER>31232 storage/storage_service/src/lib.rs:271] [GRPC] Storage::get_executor_startup_info
[8deeeaed] E0630 09:42:40.044950<PHONE_NUMBER>31232 common/grpc_helpers/src/lib.rs:20] Failed to reply error due to RemoteStopped
[8deeeaed] C0630 09:42:42.446081<PHONE_NUMBER>31232 common/crash_handler/src/lib.rs:68] reason = 'Failed to read startup info from storage.: ErrorMessage { msg: "grpc error: RpcFailure(RpcStatus { status: Unknown, details: Some(\"Stream removed\") })" }'

and some got this:
[8deeeaed] D0630 09:42:43.073476<PHONE_NUMBER>95936 libra_node/src/main_node.rs:219] Storage service started in 234 ms
[8deeeaed] D0630 09:42:43.075404<PHONE_NUMBER>95936 storage/storage_service/src/lib.rs:271] [GRPC] Storage::get_executor_startup_info
[8deeeaed] C0630 09:42:45.472870<PHONE_NUMBER>95936 common/crash_handler/src/lib.rs:68] reason = 'Failed to read startup info from storage.: ErrorMessage { msg: "grpc error: RpcFailure(RpcStatus { status: Unknown, details: Some(\"Stream removed\") })" }'

I also try and still cannot run it locally even I'm not behind a corporate proxy.

ulimit -n 8192

It turns out that the logs are in temp location and deleted when panicked. Take a look at the code, just change the parameter tee_logs of LibraSwarm::launch_swarm from false to true, the log will be printed to stderr.
The relevant part of the log looks like this:
[8deeeaed] I0629 15:36:17.832982<PHONE_NUMBER>89792 execution/executor/src/lib.rs:85] Startup info is empty. Will start from GENESIS.
[8deeeaed] D0629 15:36:17.833728<PHONE_NUMBER>89792 execution/executor/src/lib.rs:172] Received request to execute block. Parent id: 5052455f47454e455349535f424c4f434b5f4944000000000000000000000000. Id: 47454e455349535f424c4f434b5f494400000000000000000000000000000000.
[8deeeaed] D0629 15:36:17.837146<PHONE_NUMBER>89792 execution/executor/src/block_processor.rs:627] Execution status: [Keep(Execution(Executed))]
[8deeeaed] D0629 15:36:17.841612<PHONE_NUMBER>89792 execution/executor/src/lib.rs:204] Received request to commit block 47454e455349535f424c4f434b5f494400000000000000000000000000000000.
[8deeeaed] D0629 15:36:17.842989<PHONE_NUMBER>89792 storage/storage_service/src/lib.rs:259] [GRPC] Storage::save_transactions
[8deeeaed] I0629 15:36:17.848332<PHONE_NUMBER>89792 execution/executor/src/lib.rs:162] GENESIS transaction is committed.
[8deeeaed] D0629 15:36:17.863191<PHONE_NUMBER>89792 libra_node/src/main_node.rs:226] Execution service started in 33 ms
[8deeeaed] D0629 15:36:17.866759<PHONE_NUMBER>89792 network/src/peer_manager/mod.rs:528] listening on "/ip4/<IP_ADDRESS>/tcp/50462"
[8deeeaed] D0629 15:36:17.867859<PHONE_NUMBER>89792 network/src/peer_manager/mod.rs:545] Incoming connections listener Task started
[8deeeaed] D0629 15:36:17.868415<PHONE_NUMBER>89792 libra_node/src/main_node.rs:237] Network started in 5 ms
[8deeeaed] D0629 15:36:17.877199<PHONE_NUMBER>89792 libra_node/src/main_node.rs:242] AC started in 8 ms
[8deeeaed] E0629 15:36:17.877394000<PHONE_NUMBER>83616 wakeup_fd_pipe.cc:40]         pipe creation failed (24): Too many open files

while other applications work well on my MBP without complaining Too many open files.
$ sysctl kern.maxfiles
kern.maxfiles: 49152
$ sysctl kern.maxfilesperproc
kern.maxfilesperproc: 24576

They seem fine.
$ ulimit -a
core file size          (blocks, -c) 0
data seg size           (kbytes, -d) unlimited
file size               (blocks, -f) unlimited
max locked memory       (kbytes, -l) unlimited
max memory size         (kbytes, -m) unlimited
open files                      (-n) 8192
pipe size            (512 bytes, -p) 1
stack size              (kbytes, -s) 8192
cpu time               (seconds, -t) unlimited
max user processes              (-u) 1418
virtual memory          (kbytes, -v) unlimited

Here it is. Just set ulimit -n 8192 and it's up and running! 👏
TODO:

[ ]  The reason for panicking should be reflected in the panic message.
[ ]  The parameter tee_logs should be exposed to CLI.
[ ]  The need for opening many files should be documented and there should be a recommended value for it.
[ ]  Proxy issue should be either documented or addressed.
[ ]  The logs are overwhelming even when no command is issued, takes up space really fast, ~17M/min.

Might create PRs for them later, but I've noticed that libra hasn't merged a single PR yet.
P.S. Just noticed that my report is almost a duplicate of #81 .

It's working for me now after running "ulimit -n 8192".  Thank you very much! (MacOS Mojave)


Do not reuse the same image for all pr jobs

Because all jobs were using the same tag for the docker image, they
would end up writing over the image that was in use by another pr job.
This could cause code that didn't even exist in the PR to exist in the
test docker image.
Use an image named for the specific pr to avoid this contention.
Fixes #174

LGTM


display notifications are now generated from options

Coverage increased (+0.04%) to 93.12% when pulling 55eb0bdf1db1ea06301ab911c7c206ed3148a1d0 on notifications into c5ef622a332301e335b27d9d287947960bf9b631 on master.


logo is not showing in deployment

I didn't manage to get it working... probably some simple error (but not so obvious)


fix: hides fallback locale checkbox when field localization is set to false

Description
The recent 'Fallback to default locale' checkbox on Array and Block fields shows up even when the field localization is set to false.
Flagged in this discussion: https://github.com/payloadcms/payload/discussions/1868

[X] I have read and understand the CONTRIBUTING.md document in this repository

Type of change

[X] Bug fix (non-breaking change which fixes an issue)

Checklist:

[ ] I have added tests that prove my fix is effective or that my feature works
[X] Existing test suite passes locally with my changes
[ ] I have made corresponding changes to the documentation

Let's adjust the rendering of the NullifyField and the checkSkipValidation functions to check if localization.fallback is true, if it's false we don't want to allow this functionality.

@JarrodMFlesch changes made


Update component base definitions for WISDEM tools

@implement_base in interface references outdated bases. Examples include HubBase output variables hub_system_mass, hub_system_cm, and hub_system_I whose calculations have been moved to a separate component in DriveSE in order to avoid circular dependency issues at turbine level.

this is a WISDEM issue and was fixed by Taylor in his latest DriveSE updates; closing issue


Async run is messing up with stdout after :exec is run

Information
VIM version
VIM - Vi IMproved 8.0 (2016 Sep 12, compiled Jan  3 2017 05:43:41)
MacOS X (unix) version
Operating System:

:ALEInfo
Current Filetype: vim
Available Linters: ['vint']
  Enabled Linters: ['vint']
 Linter Variables:

let g:ale_vim_vint_show_style_issues = 1
 Global Variables:

let g:ale_cache_executable_check_failures = 0
let g:ale_change_sign_column_color = 0
let g:ale_command_wrapper = ''
let g:ale_completion_delay = 100
let g:ale_completion_enabled = 0
let g:ale_completion_max_suggestions = 50
let g:ale_echo_cursor = 1
let g:ale_echo_msg_error_str = 'Error'
let g:ale_echo_msg_format = '%code: %%s'
let g:ale_echo_msg_info_str = 'Info'
let g:ale_echo_msg_warning_str = 'Warning'
let g:ale_enabled = 1
let g:ale_fix_on_save = 0
let g:ale_fixers = {}
let g:ale_history_enabled = 1
let g:ale_history_log_output = 1
let g:ale_keep_list_window_open = 0
let g:ale_lint_delay = 200
let g:ale_lint_on_enter = 1
let g:ale_lint_on_filetype_changed = 1
let g:ale_lint_on_save = 1
let g:ale_lint_on_text_changed = 'never'
let g:ale_lint_on_insert_leave = 0
let g:ale_linter_aliases = {}
let g:ale_linters = {}
let b:ale_linters = {'ruby': ['ruby', 'rubocop']}
let g:ale_linters_explicit = 0
let g:ale_list_window_size = 10
let g:ale_loclist_msg_format = '%code: %%s'
let g:ale_max_buffer_history_size = 20
let g:ale_max_signs = -1
let g:ale_maximum_file_size = 0
let g:ale_open_list = 0
let g:ale_pattern_options = {}
let g:ale_pattern_options_enabled = 0
let g:ale_set_balloons = 0
let g:ale_set_highlights = 1
let g:ale_set_loclist = 1
let g:ale_set_quickfix = 0
let g:ale_set_signs = 1
let g:ale_sign_column_always = 1
let g:ale_sign_error = '>>'
let g:ale_sign_info = 'W'
let g:ale_sign_offset = 1000000
let g:ale_sign_style_error = '>>'
let g:ale_sign_style_warning = 'W'
let g:ale_sign_warning = 'W'
let g:ale_statusline_format = ['%d error(s)', '%d warning(s)', 'OK']
let g:ale_type_map = {}
let g:ale_warn_about_trailing_blank_lines = 1
let g:ale_warn_about_trailing_whitespace = 1
  Command History:

(executable check - failure) vint
(executable check - failure) vint

What went wrong
I run my tests (e.g Ruby) from within Vim, which shows results by starting with :silent !echo; to make the screen black (very common pattern), then:
:silent !echo "Using bundle exec"
exec ":!bundle exec rspec --color --order rand " . a:filename

which gives me something like this:

After adding Ale, it runs Rubocop async when I save the current file and it's pretty good, but if I save the file and run the tests, the following will happen (grey rectangle is just to hide proprietary code):

some other times this:

Reproducing the bug
Steps for repeating the bug:

Setup Ale as:

let g:ale_sign_error = '>>'
let g:ale_sign_warning = 'W'
let g:ale_sign_column_always = 1
let g:ale_lint_on_text_changed = 'never'

Save the current file (e.g Ruby code): :w|:!ls
The ls result will, after a second or so, get broken with Rubocop results

I suspect the solution will be a combination of stopping a job before it outputs and executing some code on ALELintPost to check whether the buffer is still visible. I have no idea what that function would look like.

Is the problem that you see some highlights in the buffer for the test output? Does the buffer has its own filetype or something?

No. Let me use an example without tests (just regular code and shell). It's really just a race condition.
Scenario: good
The buffer contains a Ruby file, just like any other source code. When I enter something bad e.g double-quote according to Rubocop, it will highlight the source code and this is good:

This is good. I saved the file and 1 second later the highlight showed up.
Scenario: bad
However, now consider that the file had no highlights in the first place, like the following:

Now, say I add an offending double-quote, but instead of saving and waiting for it to highlight, I ran :w|:!ls at once. The following will happen:

immediately, instantaneously:

after 1 second, the Rubocop that wasn't running in the background will have an output and then the following will happen:

It's basically a race-condition. The highlighting part should have a check whether it's outputting to the same buffer (e.g is the buffer still showing up?)
In my personal case, it's not :w|:!ls that I'm running, it's more like :w|:TestCurrentFile, which runs tests in shell, but the ls example is just as good.

Try updating Vim to a newer version. This looks like this bug in Vim: https://github.com/vim/vim/issues/1907

Nice! Had Vim 8.0 w patch 1350. Now at 1600 it seems to be fixed 🎉


chore (Data.Fintype.Basic): de-simp Fintype.univ_ofSubsingleton

In principle, Fintype.univ_ofSubsingleton could be a simp theorem but it applies to any occurence of univ and requires unification of the (possibly very complex) Fintype instances. It appears to not be needed in simp. So we remove the attribute. We get some performance gains as a benefit.

See the Zulip topic for an example of it causing problems in the wild.

!bench

bors merge


Add odatatype for Url Signing Action

MSFT employees can try out our new experience at OpenAPI Hub  - one location for using our validation tools and finding your workflow.

Contribution checklist:

[x] I have reviewed the documentation for the workflow.
[x] Validation tools were run on swagger spec(s) and have all been fixed in this PR. How to fix?

If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist

[ ] Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.

adding/removing APIs.
adding/removing properties.
adding/removing API-version.
adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

[ ] If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Please follow the link to find more details on API review process.

You don't have permission to trigger SDK Automation.
Please add yourself to Azure group from opensource portal if you are MSFT employee,
or please ask reviewer to add comment *** /openapibot sdkautomation ***.
Please ask<EMAIL_ADDRESS>(or NullMDR in github) for additional help.

Can one of the admins verify this patch?

/openapibot sdkautomation

/azp run automation - sdk

/azp run automation - sdk

/azp run automation - sdk

/azp run automation - sdk

@gubalasu is this property readonly?

@gubalasu is this property readonly?

This is a property that the customers have to supply when they are making this call. And the value of the property is the one mentioned in the enum. I am not very sure what you meant by readonly. But I hope this answers your question

@gubalasu readonly means the property could only be return by service, and could not change by the client side.
Since there is only one possible value for the enum, (And could not add new enum value due to it is not modelAsString) I think it is no need for the sending by client side.

@gubalasu readonly means the property could only be return by service, and could not change by the client side.
Since there is only one possible value for the enum, (And could not add new enum value due to it is not modelAsString) I think it is no need for the sending by client side.

We are checking for the odatatype in the Resource Provider. We do this because the action can have multiple different types. One such type is UrlSigning. For other action types we have different odatatype and they are defined seperately. So this field is a required field.


WIP: New modules PoC with Cart Module

Work in progress.
New (and final) version of VS modules. After long discussion with @pkarw we agreed that proposed architecture for modules can be improved which will end up with much better approach and make refactoring to modules easier.
What changed

We are leaving the features idea. Instead of creating granular micro-mixins we will go again with bigger components. The purpose of features was to provide a granular and feature-oriented approach to composing components. We agreed that such functionality should be provided by Vuex stores instead of a mixins so instead of splitting whole app into granular features that are provided by mixins we will focus on encapsulating most of business logic into Vuex stores and providing easy to use API with it's actions, getters and mutations.
Added -module-name postfix to all components from a given module. Just a minor tweak to navigate through components easier with Vue Devtools.
...more to come

Backward compatibility plan

Even tho a lot of components will change due to refactoring and moving to modules which we will use in theme 2.0 we still need to remain backward compatible with theme 1.0 This is why we will treat core/components folder as a backward-compatible layer that proxys new API to the old one. This proxys will be maintained in the future so everything will be backward compatible BUT some new features may not be introduced to them.

To better undestand this proxing you can take a look at core/components/Microcart/Product.js or smaller core/components/Header/MicrocartIcon.js file

We need to have @igloczek and @DavidRouyer opinion on that

I’ve put some open questions regarding modules future and if they replace extensions one day (they should) and if they interoperate with npm (they should)

@pkarw please don't comment directly here since I'm applying changes every 10 mins, just discuss it on slack to not confuse others ;)

and @DavidRouyer @Igloczek please take a look at this, think but comment after I'll mark it as done :)

I'd consider most of stuff done. What's left

[] rewrite tests for components
[] typings

I think we should agree on the structure and align other modules at first then add missing parts (like tests) because what was the most misleading part of current modules was that unclear / duplicated / messy structure (old vs new)

Vuex Store should be ported at the very very end of the process

Filip let me also know regaridng the questions on npm and extensions vs modules question

What about class-based components for components? https://alligator.io/vuejs/typescript-class-components/ Much nicer syntax and we'll be ready for Vue.js 3.x

@pkarw to your questions 3x Yes but registration will happen without the index file (just one entry for every module) so we have more control over how it's registered

@DavidRouyer this will add unnecessary complexity with decorators etc. Vue 3 will still use object syntqx by default so I will stick with it

FYI I'm moving to another modules. I will refactor the tests at the end since it's super time-consuming

For me - @filrak this is accepted. I like this approach, let's go with it.
Component options / props is much better for module path than name with postfix (it's messy for me).
Can You add example of:

package.json
registration mechanism as You've described

@pkarw I'll add the registration after finishing the refactoring

Most of the current modules (except wishlist) ar refactored. They'll need some more work and poslihment later but for now they are acceptable. I also rewrote newsletter totally since it was mixed between extension, core and theme + completely not working (it still needs some work tho, it's more like a MVP)

Nice work @filrak! 🎉


Update store state

#85

I really like this one, actually, because the docs imply that replaceReducer actually does something, which it doesn't.


feat(vocabulary) : support multiple terms per concept/property

Closes #645

Changes

Flags

Screenshots or Video

Related Issues

Issue #
Pull Request #

Author Checklist

[ ] Ensure you provide a DCO sign-off for your commits using the --signoff option of git commit.
[ ] Vital features and changes captured in unit and/or integration tests
[ ] Commits messages follow AP format
[ ] Extend the documentation, if necessary
[ ] Merging to main from fork:branchname

Hi @dselman
Here is the PR fixing the bug and I've new test cases.

@dselman I had to fix tests for the changes made, here is PR for that https://github.com/accordproject/concerto/pull/667
I had signed off the previous commits, but not sure why DCO check is failing.

@dselman I had to fix tests for the changes made, here is PR for that #667
I had signed off the previous commits, but not sure why DCO check is failing.

@sanketshevkar can you please resolve the merge conflicts?


Shader sampler2D uniforms doesn't show up properly on inspector

Operating system or device - Godot version:
Ubuntu 16.04
Godot custom build from commit 6d0568d
Issue description:
See title
Steps to reproduce:
Create shader material that is have two or more sampler2D uniforms, and back to the inspector panel..

There should be three sampler2D uniforms, but it doesn't..

:cry:

Duplicate of #8353

@nunodonato Right, thanks.
Closing as duplicate of #8353, as per comment above.


HTTP probe doesn't change TLS ServerName for discovered resources

We use only resolve_first option to decide if we should change TLS config's server name. That's not sufficient. Now we resolve targets first for all discovered resources. We should fix this behavior.
Discussed in https://github.com/cloudprober/cloudprober/discussions/412

Also added tests to detect this/similar issue next time.


Adjust UI for better fit, add "small mode" for tight spots.

This makes the main UI even wider, to accommodate wider fonts such as Meiryo.
Also it adds a "small mode", where if the width of the preview window is less than 400 pixels wide, the UI will shrink a bit to try to stay within bounds.
Fixes #190.

I have confirmed that the UI displays correctly in a Japanese font environment.

mode
image

large mode

small mode

Version 2.3.1 published.


Analytic sampling for conditional posterior instances trained with MDNs.

Hey,
I added code to analytically sample and condition DirectPosterior instances trained on MDNs. Wrapping a DirectPosterior instance that has been trained using an MDN in this way, replaces the .log_prob() and .sample() methods with analytical ones. This means it should be compatible with the rest of sbi.
Example
After training the posterior...
inference = SNPE(prior, density_estimator='mdn')
density_estimator = inference.append_simulations().train()
posterior = inference.build_posterior(density_estimator)
posterior.set_default_x(x=x_o)

...it can be wrapped, ...
analytic_posterior = MDNPosterior(posterior)

...and conditioned.
condition = torch.tensor([[theta_1, theta_2, 'nan']])
cond_posterior = analytic_posterior.conditionalise(condition)

Variables of interest are represented by 'nan's.
Then cond_posterior can be sampled and evaluated as before.
cond_posterior.sample((1,))
cond_posterior.log_prob(theta)

I am sure this could somehow be integrated into the DirectPosterior class directly as well, since the MDNPosterior inherits from it.
Let me know of any issues, I'd be happy to help integrating it into sbi. :)

You can track progress here

Codecov Report

:exclamation: No coverage uploaded for pull request base (main@83640bc). Click here to learn what that means.
The diff coverage is 6.66%.

@@           Coverage Diff           @@
##             main     #458   +/-   ##
=======================================
  Coverage        ?   66.38%
=======================================
  Files           ?       55
  Lines           ?     3626
  Branches        ?        0
=======================================
  Hits            ?     2407
  Misses          ?     1219
  Partials        ?        0

Flag
Coverage Δ

unittests
66.38% <6.66%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

sbi/inference/posteriors/direct_posterior.py
53.84% <6.66%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 83640bc...06c3dc5. Read the comment docs.

I have just addressed your latest comments. Hope that it can be merged now. :)

Can be merged once merge conflicts are resolved.

I just resolved all conflicts, if it passes the tests, I guess you can merge it :)


Fix webhook API endpoint

Oops...
s/webhook/webhooks/

Nice catch; that's what I get for reviewing on no sleep : sweat_smile:

Whoops, forgot to publish this.  Just released as v2.4.0.


How to use DbContextFactory in Blazor Server when using database per tenant?

I moved from a single databases to the per-tenant database in a Blazor Server-side app. Currently I have:
services.AddDbContextFactory<AppContext>(options =>
{
    options.UseSqlServer(configuration.GetConnectionString("App"));
});

But now how am I going to change the above service registration to use the per-tenant connection string?

Hi, it's not using dbcontext factory but if you want to spin up a multitenant db context instance for a given tenant a static create factory method was recently added. Here is the link to the docs:
https://www.finbuckle.com/MultiTenant/Docs/v9.0.0/EFCore#factory-instantiation
Does that get you what you want?

Also, there is an overload of AddDbContextFactory which accepts a service provider. Using that you can get the tenant by resoving IMultiTenantContextAccessor<TTenantType> then getting the connection string from the current tenant and plugging it into you UseSqlServerLine. That might be better for your use case unless you need to spin up a dbcontext for multiple tenants at once, then the option I described in the prior response will be better.


A0-2200: contracts-upgradeability

Description
Adds upgradeability to contracts

I haven't read the PR but have you read the https://docs.openbrush.io/smart-contracts/upgradeable where they explain how to make storage layout upgradeable as well?

I think something like "versioning" storage with upgradable_storage(VERSION_KEY) macro might be a good idea, as (I think) it makes storage migration process more clear. But it shouldn't really matter that much, so it's up to you.

Another thing to consider is enabling upgrade + migration to be "atomic", by taking Option<Selector> in the upgrade message, so migration function's selector can be called right after the upgrade. It might help us avoid downtime, when all calls to contract produce errors, or might even potentially break something, depending on the nature of the migration.

This might be a trivial question, but why some of the added set_code messages get custom selectors and others don't?

cargo culted, some contracts custom, some resort to the defaults so I just followed whatever the convention was so far :shrug:

I think something like "versioning" storage with upgradable_storage(VERSION_KEY) macro might be a good idea, as (I think) it makes storage migration process more clear. But it shouldn't really matter that much, so it's up to you.

Added - not sure what I think of adding the reserved fields - intuitively it's OK I guess, I don't see us reaching for it too often.
Token contracts - they all have just one proprietary field - access_control contract address, which has it's value "upgradeable" with a simple message, so I reckon it's not worth wrapping it in it' s own storage type... But YMMV and I can be easily persuaded otherwise.

I think something like "versioning" storage with upgradable_storage(VERSION_KEY) macro might be a good idea, as (I think) it makes storage migration process more clear. But it shouldn't really matter that much, so it's up to you.

1. Added - not sure what I think of adding the reserved fields - intuitively it's OK I guess, I don't see us reaching for it too often.

2. Token contracts - they all have just one proprietary field - access_control contract address, which has it's value "upgradeable" with a simple message, so I reckon it's not worth wrapping it in it' s own storage type... But YMMV and I can be easily persuaded otherwise.

I think that if it's likely the only field that will ever be there, then it's fine to leave it as is.

Another thing to consider is enabling upgrade + migration to be "atomic", by taking Option<Selector> in the upgrade message, so migration function's selector can be called right after the upgrade. It might help us avoid downtime, when all calls to contract produce errors, or might even potentially break something, depending on the nature of the migration.
I don't follow - are you saying we should add an optional argument to set_code, that let's one invoke migration functionality in the same tx as setting contract pointer to a new hash?
Correct me if I'm wrong but set_code will always be invoked in the context of the "old" contract code, so it cannot self-migrate, since there are no stored instructions on how to?

When you are doing set_code then you have code hash available, so you can make a delegate call.
If you anticipate that upgrades are only made after contract is stopped, then you can ignore this suggestion.

Another thing to consider is enabling upgrade + migration to be "atomic", by taking Option<Selector> in the upgrade message, so migration function's selector can be called right after the upgrade. It might help us avoid downtime, when all calls to contract produce errors, or might even potentially break something, depending on the nature of the migration.
I don't follow - are you saying we should add an optional argument to set_code, that let's one invoke migration functionality in the same tx as setting contract pointer to a new hash?
Correct me if I'm wrong but set_code will always be invoked in the context of the "old" contract code, so it cannot self-migrate, since there are no stored instructions on how to?

When you are doing set_code then you have code hash available, so you can make a delegate call.
If you anticipate that upgrades are only made after contract is stopped, then you can ignore this suggestion.

I have no idea what/if the upgrades would look like :) IMHO it's best to make it general and open-ended. Check how you like this solution - as per your suggestion added a delegate call to "new me". Since it's a no ABI delegate-call the callback function will have to adhere to some conventions (like take no arguments, be access controlled etc), which i left as a comment

The overall structure of upgradeability looks good to me now.


ConfigureTracerProvider doesn't need a logger

All the errors getting logged could simply be returned to users of this package so they may log it if they see fit.
https://github.com/xmidt-org/candlelight/blob/26649f5fb0827273399b2057188fb145786cac70/candlelight.go#L45

Resolved this issue and raised a PR for the same: https://github.com/xmidt-org/candlelight/pull/15


Book VS Source Code

Issue: I have been going through your new book, however am completely lost because the book has incomplete examples and when looking at the source code it doesn't match what is in the book.
Some of the code on here is still using Vapor 3, other chapters are completely empty. The chapter on building the template and the source found here is incomplete.
Is this still a work in progress?

Hey,
I'm so sorry, some chapter folders were severely out of date. The book was written as Vapor 4 was still in Alpha, so certain parts of it were originally Vapor 3 but have since been updated to Vapor 4.
I just pushed the most recent updates that contain all Vapor 4 and are working with the beta. Let me know if you encounter any problems there!

@detectedstealth As a note though: As Vapor develops there might be some minor issues with the code that you find in the book and what Vapor expects. We are updating the book when Vapor 4 is fully released.
In the meantime, I'm doing my best to keep this code here in Github up to date with Vapor 4. Ping me if you find something not making sense.
I appreciate all the feedback!


Feature Request: Display useful information for a current/nearby bounding box structure

This is a feature request instead of an issue.  Generally it would nice to have additional information shown concerning nearby bounding box structures.  I specifically have Villages in mind, and would find it extremely helpful if it could list things like the following:

Village Id
Center Point
Villager Population (count/limit)
Golem Population (count/limit)
House count
Breeding status
Player Reputation

Then thinking of this generally, if information like this would be helpful for other structures, it'd be nice to display that data as well.

Instead of adding a new feature request, I'll add to this one.
1 - Make the village sphere horizontal lines instead of dots (or at least an option for lines, unless I don't know if one exists already. Sometimes the dark blue dots "disappear" up close - that is, hard to see).
2 - Add a 64 block radius sphere for the "return to village" zone where the villager AI will always try and pathfind back. This will be good for villager auto-farming placement.

With villages going away as a concept in 1.14 it's unlikely that I'll invest in adding new features.


Fix squashed up Component diagrams

When no participant type is specified for several participants the generated component diagram uses a strange default type which is usually very small and bunches up the text (names) of the participants and becomes unreadable.
One solution is to default to component type in the component diagrams if none is provided.

It seems that the default arrow should be --> which is horizontal but also allows better automated layouts. When using the -> format it seems to prevent automated arrangements since this explicitly hints at a horizontal layout. Switching to the default type should allow for some improvement. (initial experiments suggest it does).


[Frontend] Fix AutoGraph not converting functions wrapped by 'adjoint', 'grad', etc.

The following example would fail before the fix:
 def inner(n):
    for i in range(n):
      qml.T(i)

  @qjit(autograph=True)
  @qml.qnode(qml.device("lightning.qubit", wires=5))
  def f(n: int):
      adjoint(inner)(n)
      return qml.state()

The tests look good. I have noticed that some tests use the variable backend while others are hard coded to be lightning. I think it is best if we always use backend.

I deliberately didn't use it here because I'm only testing frontend functionality. I just had to use a QNode to use adjoint, otherwise I wouldn't have. I agree that most tests should use backend, unless they are not testing execution functionality.


The Photos does not refresh

The Photos does not refresh until we close app or wait for a long time just add a refresh button to refresh imgs fast

Duplicate:

#760


Broken date handling in careeropportunity display date

What kind of an issue is this?

[x] Bug report
[ ] Feature request

What is the expected behaviour?
A careeropportunity should be displayed from the start date.
What is the current behaviour?
If the start date is in the past, but sufficiently close to the current date, the careeropportunity is not displayed. Setting the start date to an earlier date fixes the problem.

How do you reproduce this problem?
Set start date to the middle of the night the day before the current day.

This has nothing to do with how much in the future the event is set.
The queryset attribute is evaluated when the process starts. If an opportunity object is set to start after the server evaluated the queryset, it won't make the cut, since timezone.now() was evaluated at the first execution and then stored.
A simple fix is to override the get_queryset method which will evaluate timezone.now() every time the request is run rather than the first time it is evaluated.


Programmatic clicks and SwiftClick

We are performing automated tests in the cloud using Perfecto Mobile. But, the tests fail because the programmatic clicks need to performed twice for the desired action to be performed. This is because of the ghost click prevention mechanism of SwiftClick.

First click goes fine. _clickedAlready is set to true
Second click is prevented. Because _clickedAlready is set to true. _clickedAlready is set to false
Third click goes fine.

Now my question is, is this ghost click prevention still necessary? Or can we remove that chunk of code. From my tests on iOS devices, that block of code is redundant. Can you perform some tests on Android devices?

Hey thanks for the report. Currently I don't have access to any Android devices, but will look into potentially removing the ghost click code, as it is – as you mention – most probably redundant by now. And, if I recall correctly, Chrome on Android no longer has a click event delay anyway.


SpatialVision implementation of street connectivity doesn't use 'clean_intersections_12m'

It just occurred to me, looking over spatial vision's code, that it doesn't appear to use the clean intersections we pre-prepared; nor does it use OSMnx to re-generate these (that I can tell).
Here is the function they wrote:
def neigh_stats(G_proj, hexes, length, rows, node, index):
    """
    This function is for multiprocessing.
    It uses hexes to calculate pop and intersection densiry for each sample point,
    it will create a subnetwork, and use that to intersect the hexes,
    then read info from the intersected hexes.
    -------
    average densities of population and intersections

        G_proj {networkx} --  read from osmnx
        hexes {GeoDataFrame} -- hex
        length {int} -- distance to search
        rows {int} -- the number of rows to loop
        nodes {list} -- the osmid of nodes
        index {int} -- loop number
    """
    if index % 100 == 0:
        print('{0} / {1}'.format(index, rows))
    subgraph_proj = nx.ego_graph(G_proj,
                                 node,
                                 radius=length,
                                 distance='length')
    subgraph_gdf = ox.graph_to_gdfs(subgraph_proj,
                                    nodes=False,
                                    edges=True,
                                    fill_edge_geometry=True)

    # use subgraph to select interected hex250
    if len(subgraph_gdf) > 0:
        intersections = gpd.sjoin(hexes,
                                  subgraph_gdf,
                                  how='inner',
                                  op='intersects')

        # drop all rows where 'index_right' is nan
        intersections = intersections[intersections['index_right'].notnull()]
        # remove rows where 'index' is duplicate
        intersections = intersections.drop_duplicates(subset=['index'])
        return [
            node,
            float(intersections['pop_per_sqkm'].mean()),
            float(intersections['intersections_per_sqkm'].mean())
        ]
    else:
        return [node]

So that appears to be naively taking the network nodes within the walkable neighbourhood subgraph of each node, and using these as though they represent street connections.  In reality, we always use a process of cleaning to ensure that structures the function for network routing or representation purposes using OSM (e.g. roundabouts) don't result in overcounting of intersections.  In our national Australian work, we moved to using the OSMnx clean intersections function for this - based on our experimentation we used a parameter of 12m for the cleaning (however, it is noted that the optimality of this parameter depends on context.... we could not that as a limitation).
Anyway - I pre-prepared these intersections for each study region; and, what we originally requested of spatial vision was that these neighbourhood statistics would be calculated for sample points not nodes.  So that would be a nice thing for us to add too.
However, the first thing we should at least do (assuming we agree that this is the issue I think it is) is ensure that 'clean intersections' rather than the un-prepared network nodes are used so we don't over-count street connectivity.  Currently, I believe the estimates will be highly inaccurate in some areas.

okay - I might be being over-sensitive on a Monday morning and posting issues too soon before thought through, I think on re-reading the code, they are taking the intersection of the 1600m network with hexes and then using the pre-calculated intersection counts and densities I prepared as per this post.  So i'll close this issue; apologies for false alarm.


Menu: add menu attribute - collapseTransition

Sometime we dont need collapse transition
Please make sure these boxes are checked before submitting your PR, thank you!

[x] Make sure you follow Element's contributing guide (中文 | English | Español).
[x] Make sure you are merging your commits to dev branch.
[x] Add some descriptions and refer relative issues for you PR.

What's the situation now? Is there any problem?

😅I don't know, the poor PR.


Classification resets _interpretation property

After running a classification all the objects on which a label was set have _interpretation set to null.

There is already a check that says "don't overwrite existing _underscore props": https://github.com/semi-technologies/weaviate/blob/6f256e74482f3f3f2e96b0acb18cd3421c0df789/usecases/classification/classifier_run.go#L155-L158
So it's not something as obvious as I was hoping for.

Maybe we need to explicitly specify all underscores when reading, i.e. the check always returns nil, because we never ask for the props when reading them?

Can be. I just know that the _interpretation is gone after a classification was executed on the specific object.

In @etiennedi explicitly setting the additional parameters fixed the issue. This PR #1421 fixes this issue

In @etiennedi explicitly setting the additional parameters fixed the issue. This PR #1421 fixes this issue


can you switch back to xorg in an existing chroot

is thier a way to switch back to the old way of launching xfce4

try doing an update with the -txorg target and -n [name of your chroot] -u

i tried that and it dint do anything
On Sat, May 2, 2015 at 10:03 AM, tedm<EMAIL_ADDRESS>wrote:

try doing an update with the -txorg target and -n [name of your chroot] -u
—
Reply to this email directly or view it on GitHub
https://github.com/dnschneid/crouton/issues/1704#issuecomment-98369624.

@giliammc - If that 'dint' work, then it didn't complete successfully or was entered incorrectly.

Please post the output of the failing commands if you want people to help you without just guessing what your problem is.

it turns out that it was just an issue with my chroot, i fixed it and now it works fine, is there a way to switch between the two methods with out having to update every time

@giliammc If you mean switch between xiwi and xorg you can add the -X xiwi or  -X xorg to your command. So for example sudo startxfce4 -X xorg

that worked great thanks

one more question i have both xfce and unity can i set xfce to open by default in xiwi but unity start by default in xorg

@giliammc - Sure, you could with aliases, like:
alias startxfce4='sudo startxfce4 -X xiwi'
alias startunity='sudo startunity -X xorg'
and then add those two commands to your .bashrc or .bash_aliases file.

thanks that worked great


Add net461 target to clean up issues with system.* nuget dependencies

Reason for change
.NET has a few known issues for libraries that depend on System.* and only ship a netstandard2.0 target

.NET has different assembly versions for netstandard2.0 versus net461 (see #591). Unless assembly binding redirects are carefully applied, there will be runtime errors.
The build output will have tons of "façade" assemblies (see the blogpost in reference 2)

Given the two issues above official guidance is (see reference 1)

✔ CONSIDER adding a target for net461 when you're offering a netstandard2.0 target.
Using .NET Standard 2.0 from .NET Framework has some issues that were addressed in .NET Framework 4.7.2. You can improve the experience for developers that are still on .NET Framework 4.6.1 - 4.7.1 by offering them a binary that is built for .NET Framework 4.6.1.

So this PR takes the above guidance to make it easier for those of us still stuck on .NET Framework < 4.7.2 :-)
Example from my recent experience
Due to the recent CVE, I upgraded SharpCompress to version  0.29. Our code is mostly .NETFramework, so we unfortunately have PackageReferences to System.Memory and System.Buffers. Everything appeared to be fine, however at runtime things were failing left and right because most of our projects/nuget dependencies require the latest System.Memory and System.Buffers while SharpCompress requires older versions. This is all avoid requiring a netstardard2.0 assembly that has an assembly version of <IP_ADDRESS> (see #591 ) .
After making my change, I found that .NETFramework projects work flawlessly without any tricky assembly binding redirects.
References

https://docs.microsoft.com/en-us/dotnet/standard/library-guidance/cross-platform-targeting
https://weblog.west-wind.com/posts/2019/Feb/19/Using-NET-Standard-with-Full-Framework-NET

Happy to add this back in since someone on legacy framework is testing :)

That's right! I work on Microsoft Power BI. We'll let you know if something is broken :-)

Oops forgot hit review on a comment.  Letting the build run but it all looks good.  I'll get another release out soon

Released here https://www.nuget.org/packages/SharpCompress/0.30.0


PP-5455: Map MANDATE_CANCELLED_USER_NOT_ELIGIBLE event -> mandate USE…

…R_SETUP_CANCELLED state
WHAT YOU DID
A brief description of the pull request:
How to test

How should it be reviewed?
What feedback do you need?
If manual testing is needed, give suggested testing steps.

Code review checklist
Logging

[ ] only emit log lines at ERROR level which require immediate attention from a support engineer. These will trigger a zendesk alert.

Documentation

[ ] Updated README.md for any of the following ?

Introduced any new environment variables / removed existing environment variable
Added new API / updated existing API definition

THIS IS A DRAFT PR


[ceres] Build error

Host Environment

OS: [e.g. Windows/Linux etc...]
Compiler: revision

To Reproduce
Steps to reproduce the behavior:
./vcpkg install xxxx
Failure logs

Cut and paste the appropriate build messages from the console output.
Attach every failure log file mentioned in the console output.

Additional context
Add any other context about the problem here, such as what you have already tried to resolve the issue.

@DarrenLu666888 Please provide the repro steps and failure logs.

build ceres in windows for :
vcpkg install ceres[eigensparse]:x64-mingw-static  --recurse
error:
error: building ceres:x64-mingw-static failed with: BUILD_FAILED
error: Please ensure you're using the latest port files with git pull and vcpkg update.
Then check for known issues at:
https://github.com/microsoft/vcpkg/issues?q=is%3Aissue+is%3Aopen+in%3Atitle+ceres
You can submit a new issue at:
https://github.com/microsoft/vcpkg/issues/new?template=report-package-build-failure.md&title=[ceres]+Build+error
Include '[ceres] Build error' in your bug report title, the following version information in your bug description, and attach any relevant failure logs from above.
vcpkg-tool version: 2022-12-14-7ae0d8527fb488fde10a89c2813802dc9b03b6f9
vcpkg-scripts version: ecce05107 2022-12-28 (5 days ago)

This issue hasn’t been updated in 3 months, if it is still an issue, please reopen this issue.


Mesh quality metric Pick Through Time issue

Describe the bug
The Pick Through Time method fails for mesh quality metrics when tracking the element rather than the coordinates. The issue appears to be that the variable being passed down the pipeline is the name of the mesh rather than the name of the variable.
Helpful additional information

Did VisIt crash: No
Did you get wrong results: Yes. VisIt should be able to plot this curve.

To Reproduce
Steps to reproduce the behavior. For example:

Launch visit
Open wave.visit
Add a pseudocolor plot of any verdict metric
Issue a Pick Through Time tracking the element

Expected behavior
We should get the time curve.
Desktop

OS and version: mac
VisIt Version: develop branch

I believe this has to do with the fact that we're using our expression system to calculate the verdict variables, so the DirectDatabaseQOT has no way of retrieving these variables directly from the database. Removing the verdict metric expressions from compatibility with DirectDatabaseQOT should fix this issue.

I suppose its worth asking, however, if it is possible for the DDQoT stuff to tease a tiny bit of the mesh+var primals (e.g. leaves in expression tree) from the database and perform the expressions on these tiny bits and pieces (minimally just the domains containing the QoT relevant bits) to service a QoT. Thats obviously re-working more internal stuff in VisIt but is potentially worth discussing because it may offer other advantages for other kinds of functions.

@markcmiller86 Hmm I'm not quite sure I follow. Do you mean allowing the DDQoT to retrieve some info from the database needed for a particular expression, allowing the expression to act on that info, and then returning the post-expression data for that query?

@markcmiller86 Hmm I'm not quite sure I follow. Do you mean allowing the DDQoT to retrieve some info from the database needed for a particular expression, allowing the expression to act on that info, and then returning the post-expression data for that query?

Yes, basically. The ability to do it on an element-by-element basis would be ideal. Of course, for expressions involving neighbors (e.g. gradients), the DDQoT would need to request more than just the elements of interest.
Was aiming to just capture the idea somewhere and this seemed like the right place. Not suggesting its the right answer to this issue ticket though. For this issue, removing any variables which are expressions (which would include Mesh Quality variables) from compatibility with DirectDatabaseQOT is definitely the right action to take I think.

Yeah, that would be a really cool feature. I'm curious what other types of QoT could benefit from this. I'll create a ticket for further discussion.


[TASK][TRIVIAL] Upgrade Spark 3.4.3

Code of Conduct

[X] I agree to follow this project's Code of Conduct

Search before asking

[X] I have searched in the issues and found no similar issues.

Why do we need to upgrade this artifact?
Regular Updates
Artifact Name
https://mvnrepository.com/search?q=spark
Target Version
3.4.3
Notable Changes
https://spark.apache.org/releases/spark-release-3-4-3.html
Are you willing to submit PR?

[ ] Yes. I would be willing to submit a PR with guidance from the Kyuubi community to fix.
[ ] No. I cannot submit a PR at this time.

please assign to me