Unhandled exception when fail to resolve canonical name.

Hey,
Latest version introduced a regression in displaying an error message when canonical name cannot be resolved.
Trace.getLoadRecord is passed undefined which causes an exception. It's given undefined because the canonical name was unable to be found for a given module.

@MeoMix i get the same error: see https://github.com/systemjs/builder/issues/318 : well documented when it happens !

@SerkanSipahi thanks for the test case - I tried your example from #318, and got the correct output:
jspm bundle src/main dist/bundle.js --inject
     Building the bundle tree for src/main...

<EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS>       src/app.js
       src/core.js
       src/main.js

ok   dist/bundle.js added to config bundles.
ok   Built into dist/bundle.js with source maps, unminified.

Are you sure you are running on the latest jspm 0.16.6? Any help with replication here is appreciated.

yes sure (jspm v0.16.6), see my package.json
{
  "name": "...",
  "version": "1.0.0",
  "description": "...",
  "main": "index.js",
  "scripts": {
    "test": "test"
  },
  "author": "Serkan Sipahi<EMAIL_ADDRESS>  "license": "ISC",
  "dependencies": {
    "jspm": "^0.16.6"
  },
  "jspm": {
    "dependencies": {},
    "devDependencies": {
      "babel"<EMAIL_ADDRESS>      "babel-runtime"<EMAIL_ADDRESS>      "core-js"<EMAIL_ADDRESS>    }
  }
}

further more see:
/Users/serkansipahi/node_modules/jspm/package.json
{
  "_args": [
    [
<EMAIL_ADDRESS>      "/Users/serkansipahi/Dropbox/Works/Projects/vocabularytrainer/extension-youtube"
    ]
  ],
  "_from"<EMAIL_ADDRESS><0.17.0",
  "_id"<EMAIL_ADDRESS>  "_inCache": true,
  "_location": "/jspm",
  "_nodeVersion": "0.12.7",
  "_npmUser": {
    "email"<EMAIL_ADDRESS>    "name": "guybedford"
  },
  "_npmVersion": "2.11.3",
  "_phantomChildren": {},
  "_requested": {
    "name": "jspm",
    "raw"<EMAIL_ADDRESS>    "rawSpec": "^0.16.6",
    "scope": null,
    "spec": ">=0.16.6 <0.17.0",
    "type": "range"
  },
  "_requiredBy": [
    "/"
  ],
  "_resolved": "https://registry.npmjs.org/jspm/-/jspm-0.16.6.tgz",
  "_shasum": "904fc5c52d193350f9b61e9f6026a2ed81185b8c",
  "_shrinkwrap": null,
  "_spec"<EMAIL_ADDRESS>  "_where": "/Users/serkansipahi/Dropbox/Works/Projects/vocabularytrainer/extension-youtube",
  "author": "",
  "bin": {
    "jspm": "./jspm.js"
  },
  "bugs": {
    "url": "https://github.com/jspm/jspm/issues"
  },
  "dependencies": {
    "chalk": "^1.0.0",
    "core-js": "^0.9.17",
    "glob": "^5.0.10",
    "graceful-fs": "^3.0.8",
    "jspm-github": "^0.13.3",
    "jspm-npm": "^0.25.0",
    "jspm-registry": "^0.4.0",
    "liftoff": "^2.1.0",
    "minimatch": "^2.0.8",
    "mkdirp": "~0.5.1",
    "ncp": "^2.0.0",
    "request": "^2.58.0",
    "rimraf": "^2.4.0",
    "rsvp": "^3.0.18",
    "semver": "^5.0.1",
    "systemjs": "0.19.0",
    "systemjs-builder": "0.14.3",
    "traceur": "0.0.91",
    "uglify-js": "~2.4.23"
  },
  "description": "Registry and format agnostic JavaScript package manager",
  "devDependencies": {
    "istanbul": "^0.3.13",
    "jshint": "~2.8.0",
    "mocha": "~2.2.5"
  },
  "directories": {
    "test": "test"
  },
  "dist": {
    "shasum": "904fc5c52d193350f9b61e9f6026a2ed81185b8c",
    "tarball": "http://registry.npmjs.org/jspm/-/jspm-0.16.6.tgz"
  },
  "gitHead": "3e7ec881b4bcfeb46388f9218e5612b0f2203832",
  "homepage": "https://github.com/jspm/jspm",
  "ignore": [
    "sandbox",
    "test",
    "testlibs"
  ],
  "installable": true,
  "license": "Apache 2.0",
  "main": "./api.js",
  "maintainers": [
    {
      "name": "guybedford",
      "email"<EMAIL_ADDRESS>    }
  ],
  "name": "jspm",
  "optionalDependencies": {},
  "registry": "npm",
  "repository": {
    "type": "git",
    "url": "git+https://github.com/jspm/jspm.git"
  },
  "scripts": {
    "coverage": "npm run istanbul -- --report html",
    "istanbul": "istanbul cover ./node_modules/.bin/_mocha -i='lib/**/*.js'",
    "jshint": "jshint api.js cli.js jspm.js lib test",
    "mocha": "mocha",
    "test": "npm run jshint && npm run mocha"
  },
  "version": "0.16.6"
}

// System, Tools
MacOS v10.10.1
iojs v3.2.0
npm v3.3.1

I upgrade nodejs to v4.1.0 and npm to stable 2.14.3 . Nothing has changed.

@SerkanSipahi perhaps you can share a git repo that reproduces this?

@guybedford the repo with all installed( node_modules, jspm_packages ) dependencies? or just classic repo with package.json and app src files, etc. I think for reproducing its better with installed node_modules and jspm_packages. ok?

Sure, that works.

it took some time with the upload, so now ready, see -> https://github.com/SerkanSipahi/test-repo-jspm

@can you share your repo( package.json and src files ) , thanks.

@guybedford which node version do you use?

@guybedford : something goes wrong on my env (?!?mac,node,npm?!?) :( this is totally annoying!!
jspm bundle src/main dist/bundle.js --inject
jspm v0.16.6 -> err  TypeError: Cannot read property 'substr' of undefined
jspm v0.16.5 -> err  TypeError: Cannot read property 'substr' of undefined
jspm v0.16.4 -> err  TypeError: Cannot read property 'substr' of undefined
jspm v0.16.3 -> err  Error: ENOENT: no such file or directory, open '/Users/serkansipahi/jspm_packages/.dependencies.json'
jspm v0.16.2 -> err  TypeError: Cannot read property 'substr' of undefined
jspm v0.16.1 -> err  TypeError: Cannot read property 'substr' of undefined
jspm v0.16.0 -> err  TypeError: Cannot read property 'substr' of undefined
jspm v0.15.7 -> err  Error: Error loading "node_modules/core-js/library/fn/object/define-property" at file:/Users/serkansipahi/node_modules/core-js/library/fn/object/define-property.js
jspm v0.15.6 -> err  Error: Error loading "node_modules/core-js/library/fn/object/define-property" at file:/Users/serkansipahi/node_modules/core-js/library/fn/object/define-property.js
jspm v0.15.5 -> err  Error: Error loading "node_modules/core-js/library/fn/object/define-property" at file:/Users/serkansipahi/node_modules/core-js/library/fn/object/define-property.js
jspm v0.15.4 -> err  Error: Error loading "node_modules/core-js/library/fn/object/define-property" at file:/Users/serkansipahi/node_modules/core-js/library/fn/object/define-property.js
jspm v0.15.3 -> err  Error: Error loading "node_modules/core-js/library/fn/object/define-property" at file:/Users/serkansipahi/node_modules/core-js/library/fn/object/define-property.js
jspm v0.15.2 -> err  Error: Error loading "node_modules/core-js/library/fn/object/define-property" at file:/Users/serkansipahi/node_modules/core-js/library/fn/object/define-property.js
jspm v0.15.1 -> ok   Built into dist/bundle.js with source maps, unminified.
jspm v0.15.0 -> ok   Built into dist/bundle.js with source maps, unminified.

@SerkanSipahi are you using jspm_packages or node_modules? I tried the test case but couldn't get it to work unfortunately.

@guybedford what do you mean with jspm_packages or node_modules?
Info: Im using jspm for 6 month, systemjs, system-builder over 1 year at "work/company" but at home on my mac will work nothing :(

@SerkanSipahi your paths in the errors above are calling into node_modules, which will not easily load through jspm without manual package configurations. Your environment seems to have quite a bit going on, I can't help without a specific issue to look at. I'm certainly looking into the canonical issue now though.

I know it was just a reporting for you. I need jspm greater than or equal v0.16.0. Can i help you? What does canonical? For what is it?

Fixed in https://github.com/systemjs/builder/commit/5cf6d0e8768ad7c2bcd91f03f0465fb3d0a29cc8.

@guybedford "fixed pending release" for jspm 0.16.7 ?

Released in 0.14.4.

@guybedford : after installing jspm 0.16.8 i get now a different error on jspm bundle src/main dist/bundle.js --inject:
     Building the bundle tree for src/main...

err  Error tracing<EMAIL_ADDRESS>at<EMAIL_ADDRESS>	Error: Unable to calculate canonical name to bundle file:///Users/serkansipahi/Dropbox/Works/Projects/vocabularytrainer/node_modules/core-js/library/fn/object/define-property.js
         at getCanonicalNamePlain (/Users/serkansipahi/Dropbox/Works/Projects/vocabularytrainer/extension-youtube/node_modules/jspm/node_modules/systemjs-builder/lib/utils.js:177:13)
         at getCanonicalName (/Users/serkansipahi/Dropbox/Works/Projects/vocabularytrainer/extension-youtube/node_modules/jspm/node_modules/systemjs-builder/lib/utils.js:88:19)
         at /Users/serkansipahi/Dropbox/Works/Projects/vocabularytrainer/extension-youtube/node_modules/jspm/node_modules/systemjs-builder/lib/trace.js:305:32
         at process._tickCallback (node.js:356:9)

@SerkanSipahi yes that would be because it can't calculate the name to bundle /node_modules/core-js/library/fn/object/define-property.js. You need to ensure that that file path sits within the baseURL or a paths configuration so that jspm knows how to name it and refer to it equally between browser and server.

sorry @guybedford , before i used "jspm" i configured my System.config manually and bundled the apps over "Systemjs-Builder". That has always worked well. But now with jspm is something difficult, complicated, not clearly. What i want is just write an app( see problem https://github.com/systemjs/systemjs/issues/795 ) with jspm (it decreases a lot work).
// Folder-Structure
root
   | -- dist
   | -- src
   |    | - app.js
   |    | - core.js
   |    | - index.js
   |    | - main.js
   | -- package.json
   | -- manifest.json

// package.json
{
  "name": "...",
  "version": "1.0.0",
  "description": "...",
  "scripts": {
    "test": "test"
  },
  "author": "Serkan Sipahi<EMAIL_ADDRESS>  "license": "ISC",
  "devDependencies": {
    "jspm": "0.16.9"
  }
}

npm install
generate this:
// Folder-Structure
root
   | -- node_modules
   | -- dist
   | -- src
   |    | - app.js
   |    | - core.js
   |    | - index.js
   |    | - main.js
   | -- package.json

What now?
user$ node_modules/.bin/jspm init
Would you like jspm to prefix the jspm package.json properties under jspm? [yes]:
Enter server baseURL (public folder path) [./]:
Enter jspm packages folder [./jspm_packages]:
Enter config file path [./config.js]:
Configuration file config.js doesn't exist, create it? [yes]:
Enter client baseURL (public folder URL) [/]:
Do you wish to use a transpiler? [yes]:
Which ES6 transpiler would you like to use, Babel, TypeScript or Traceur? [babel]:

@SerkanSipahi your issue is simply that file:///Users/serkansipahi/Dropbox/Works/Projects/vocabularytrainer/node_modules/core-js/library/fn/object/define-property.js is not in jspm_packages it is in node_modules, so jspm can't bundle it. Somehow you must have told jspm to use that file.

@guybedford i told jspm nothing. Just use "jspm init" according wiki. No matter what I type in "jspm init" prompt, it makes no difference. Jspm produce always the same url in<EMAIL_ADDRESS>root
  | -- node_modules
  | -- jspm_packages <----
  |    | - npm
  |    |   |-<EMAIL_ADDRESS>  |    |      |- core-js
  |    |         |- object
  |    |         |- define-property.js
  | -- dist
  | -- src
  |    | - app.js
  |    | - core.js
  |    | - index.js
  |    | - main.js
  | -- package.json

/* */
module.exports = {
/**
 * jspm try to require define-property.js outside from root !
 **/
 "default": require("../../../../../../node_modules/core-js/library/fn/object/define-property"),
 __esModule: true
};

This is what i do:
cd root & node_modules/.bin/jspm init
I tested several options:
Enter server baseURL (public folder path) [./]: /
Enter client baseURL (public folder URL) [/]: src

// or
Enter server baseURL (public folder path) [./]: ./
Enter client baseURL (public folder URL) [/]: /

// even
Enter server baseURL (public folder path) [./]: blabla
Enter client baseURL (public folder URL) [/]: blabla

????

This example https://github.com/jspm/jspm-cli/blob/master/docs/getting-started.md does not work if is any ES6 features in use e.g. class with method
Created everything according to instructions:

Install jspm CLI
Create a project
Install any packages from the jspm Registry, GitHub or npm
Write application code
Run the code
Bundle for production

root
   | -- node_modules
   | -- jspm_packages <----
   |    | - npm
   |    |   |-<EMAIL_ADDRESS>   |    |      |- core-js
   |    |         |- object
   |    |         |- define-property.js ( try to load from  "require("../../../../../../node_modules/core-js/.........")
   | -- lib
   |    | - bootstrap.js
   |    | - main.js
   |    | - testclass.js
   | -- package.json

// bootstrap.js
import _ from 'lodash-node/modern/lang/isEqual.js';
import $ from 'jquery';
import underscore from 'myname';
import testclass from './testclass'; // <= my testclass.js

export function bootstrap() {

}

// testclass.js
export default class testclass {
    foo(){

    }
}

@SerkanSipahi this is definitely working fine for me. Are you running jspm 0.16.10 here? Also try running jspm update -f babel babel-runtime to ensure there isn't any cache issue.

@guybedford it does not make sense with  jspm update -f babel babel-runtime ! i get the same error. Yesterday i debug with node-inspector jspm but cant find the issue. Yes, its running jspm 0.16.10.
Well, sorry, but i will give up with jspm. For me its better to use the old-school way => manually setting up system.js ( config.js) + systemjs-builder, that works fine :)
Thank you for your help. Maybe i will try next time jspm :)

Note that we use core-js as a separate package in jspm not the version nested inside of babel-runtime (whic your code seems to be running). It sounds like you have custom map configs that may be interfering with the jspm defaults somehow. If it's difficult to upgrade your config in this way certainly stick with plain SystemJS.

@guybedford i really want to resolve this issue !
1.) What you mean with "custom map configs" ! Which / What kind of -file do mean?
2.) When JSPM has nothing to do with the path, who makes => require("../../../../../../node_modules/core-js/......... ? babel? core-js?

@SerkanSipahi core-js does not uses node_modules directly.

@guybedford i deleted my global node_modules folder but even that did not help. Can you tell me which npm and node version do you use?

@SerkanSipahi the problem here is certainly that require("../../../../../../node_modules/core-js/........ statement. If you can share with me any way to reproduce how you got that statement to show inside of babel-runtime on a fresh install I can help, but without the ability to replicate it's very difficult to know what to suggest here.

@guybedford I shared before. Here is what you want, a fresh install: https://github.com/SerkanSipahi/test-repo-jspm

@SerkanSipahi I tried that out already and had no problems. Perhaps share a repo with everything checked in if you can, and not containing a zip file?

@guybedford with "everything" inside ./jspm_packages and /node_modules after installation?

Yes exactly!
On Sat, 03 Oct 2015 at 7:30 PM Bitcollage<EMAIL_ADDRESS>wrote:

@guybedford https://github.com/guybedford with "everything" inside
./jspm_packages and /node_modules after installation?
—
Reply to this email directly or view it on GitHub
https://github.com/systemjs/builder/issues/317#issuecomment-145271139.

@guybedford ok, this will take a some time because there are a lot of files !

@SerkanSipahi if you can reduce the test case to only the bare minimum number of files that is also a big help. Isolation and replication are the goals for issues / bugs.

@guybedford ok

sorry @guybedford, after our last talk i have reinstalled my mac because this issue has taken a lot of time. Well, now works everything fine with jspm. Many thanks for your help :)

@SerkanSipahi haha sure! Well glad to hear it's working.

Yes!

@guybedford good man :+1:


chore(deps): upgrade compiler dependencies

Upgrades project dependencies. See details in workflow run.

Automatically created by projen via the "upgrade-compiler-dependencies-k8s-28-main" workflow

⚪ Backport skipped
The pull request was not backported as there were no branches to backport to. If this is a mistake, please apply the desired version labels or run the backport tool manually.
Manual backport
To create the backport manually run:
backport --pr 4448

Questions ?
Please refer to the Backport tool documentation


fix: handle invalid value on fieldByIndex

When using deep Relation() with Scan(ctx), if the value we're scanning is invalid (usually zero), then bun currently panics when attempting v.Field(idx)
Let's handle that correctly before trying to apply it.

Thanks! Any chance you can add a test or demonstrate how to reproduce this?

Shall do that next week on my midsummer break! Things have been busy; sorry for the delayed reply

@tinyfluffs thank you in advance!

Hello! Is it possible to hope that this PR will get into the release?

We are waiting for a test that demonstrates why we need this PR. @lakkinzimusic perhaps you have one?

We are waiting for a test that demonstrates why we need this PR. @lakkinzimusic perhaps you have one?

	"context"
	"database/sql"
	"encoding/json"
	"fmt"
	"log"

	"github.com/uptrace/bun"
	"github.com/uptrace/bun/dialect/sqlitedialect"
	"github.com/uptrace/bun/driver/sqliteshim"
	"github.com/uptrace/bun/extra/bundebug"
)

func main() {
	ctx := context.Background()

	// Open an in-memory SQLite database.
	sqlite, err := sql.Open(sqliteshim.ShimName, "file::memory:?cache=shared")
	if err != nil {
		panic(err)
	}

	// Create a Bun db on top of it.
	db := bun.NewDB(sqlite, sqlitedialect.New())

	// Print all queries to stdout.
	db.AddQueryHook(bundebug.NewQueryHook(bundebug.WithVerbose(true)))

	// create and insert data
	db.NewCreateTable().Model((*SampleTable)(nil)).Exec(ctx)
	db.NewInsert().Model(&Data).Exec(ctx)

	var st []SampleTable

	err = db.NewSelect().Model(&st).
		Relation("FirstChild").
		Relation("FirstChild.FirstChild").
		Scan(ctx)
	if err != nil {
		log.Println(err)
	}

	res, _ := json.MarshalIndent(st, "", "  ")
	fmt.Println(string(res))
}

type SampleTable struct {
	bun.BaseModel `bun:"table:sample_table"`
	ID            int `bun:",autoincrement,pk"`
	FirstChildID  int
	FirstChild    *SampleTable `bun:"rel:has-one,join:first_child_id=id"`
}

var Data = []SampleTable{
	{FirstChildID: 0},
}

Hi @vmihailenco , above I have pasted the reproducible program.
I also have some data, which is causing this problem.
I think it's better to check for m.struct.IsValid() in m.scanColumn() along with m.isNil(), before calling field.ScanValue().
Thank you.

@nilsocket this is what I get when I run your program
[bun]  10:51:32.521   CREATE TABLE           1.07ms  CREATE TABLE "sample_table" ("id" INTEGER NOT NULL, "first_child_id" INTEGER, PRIMARY KEY ("id"))
[bun]  10:51:32.521   INSERT                  143µs  INSERT INTO "sample_table" ("first_child_id") VALUES (0) RETURNING "id"
[bun]  10:51:32.521   SELECT                  132µs  SELECT "sample_table"."id", "sample_table"."first_child_id", "first_child"."id" AS "first_child__id", "first_child"."first_child_id" AS "first_child__first_child_id", "first_child__first_child"."id" AS "first_child__first_child__id", "first_child__first_child"."first_child_id" AS "first_child__first_child__first_child_id" FROM "sample_table" LEFT JOIN "sample_table" AS "first_child" ON ("first_child"."id" = "sample_table"."first_child_id") LEFT JOIN "sample_table" AS "first_child__first_child" ON ("first_child__first_child"."id" = "first_child"."first_child_id")
[
  {
    "ID": 1,
    "FirstChildID": 0,
    "FirstChild": null
  }
]

Is there anything worng?


Allow use of App Insights Query API

It would be very useful if there was an option to allow queries to be entered (free text) and ran against the App Insights query API.   This would allow advanced queries, filtering, grouping, etc., without as much work being required as a full query builder.

+1
would be very helpful

+1... have spent a ton of time writing custom queries in Application Insights Analytics... would love to be able to leverage those queries in Grafana... maybe an option to just copy/paste those queries in so you can filter/group/etc.

I haven't got it working yet, but is this already possible with Azure Log Analytics?

Analytics queriers for Application Insights is works.

More info in readme (section "Writing Analytics Queries For Application Insights"): https://github.com/grafana/azure-monitor-datasource/blob/master/README.md


Add support for JPEG and WEBP background images

Most of the code is copy-pasted from hyperpaper (with some changes).
Ideally, the jpeg / webp loading code would be shared in some common library. However, I couldn't find a fitting candidate in hyprwm.
fixes #221

I'll tag @fufexan for the nix part, unless you can do it yourself, though IIRC he's gone for 2 ish days now so we might have to wait

yoo nice


Dynamic skip threshold

The hard-coded threshold of 3s for skipping to the previous segment instead of skipping to the start of the segment can be too long for short videos, where visually, you are far away from the actual cut mark.

This patch fixes the problem by making this a dynamic threshold based on the video duration with a minimum of 0.5s (guarding against a non-set video duration) and a maximum of 3s.

Thanks for the fix! It looks good to me.
Note: The maximum threshold of 3 seconds is reached with a video duration of 5 minutes. Otherwise it will be shorter.

Thanks for the review. Merging this so I can prep the new release…


Enum-keyed Records should be generated as Partials

Right now we generated Enum-keyed maps (map<MyEnum, string>) as Record<MyEnum, string | undefined>.
This is because in typescript if you do Record<Enum, Value> then typescript doesn't let you make an object that's missing any of the enum values. this makes backcompat really hard and also a lot of the time people don't want to include every enum in the keys.
However, in our implementation all the keys are required.
We should instead generated Partial<Record<MyEnum, string>>

closing as we haven't gotten a customer request for this


samples: remove disabling AUDIT_LOG partition in samples with TFM_IPC

The AUDIT_LOG partition cannot be used in TF-M builds
with the IPC mode (CONFIG_TFM_IPC=y); we have added a
relevant dependency for this. So we can cleanup the
CONFIG_TFM_PARTITION_AUDIT_LOG=n from the configuration
files of the samples.
Signed-off-by: Ioannis Glaropoulos<EMAIL_ADDRESS>

Thanks!


Rebase/update PRs out of schedule

If users (a) define schedules for PRs, but (b) also require branches to be kept up-to-date with master, then currently that's a problem because branches will become stale and won't get updated until the next schedule window.
This feature proposes that branches get rebased out of schedule as default behaviour.

For the same reasons, we may want to still automerge out of schedule too.

Also - delete merged branches

@mbrevda I think Renovate should already delete merged branches out of schedule now anyway

I beg to differ

Just tested again. Ill PM you a link

Rebasing has one big challenge - right now we don't actually rebase, i.e. we don't directly use the git command. Instead, we basically just regenerate the branch and swap it out with the old one. So this scenario would be challenging:

On monday, React 16.0.0 is released and a branch created
On tuesday, React 16.0.1 is released.. not updated due to out of schedule
On wednesday, master is updated with a commit

Expected scenario: The existing branch is rebased with React 16.0.0, not 16.0.1
Right now that's quite different to how Renovate's logic works. We'd need a way to detect and apply only the changes from the existing branch and not the latest available updates.

This could be easily implemented at first if we allow new updates to be swept up with a rebase. i.e.

Only create branches during schedule
If a branch already exists, and is set for rebasing when stale, and it becomes stale.. update it with whatever is the current/latest for that branch

i.e. you'd get React 16.0.1 in the above-described scenario.
We also need to consider the scenario where a branch is created in schedule with prCreation=not-pending, and the tests finish outside of schedule. I think we should still create the PR then.

To implement fully:

Retrieve existing package.json
Retrieve package.json from the parent master commit for that branch
Compare dependencies between them
Reapply the same changes against the latest master

@brevda I checked the logs and found the cause:

dependency a is updated on a schedule
version 0.5.4 was raised as a PR during schedule
version 0.5.5 was released after schedule, so no update made
version 0.5.4 PR was merged and the branch left in place (renovate/a-0.x)
renovate does not delete renovate/a-0.x because it thinks that branch "should exist"

If 0.5.5 didn't exist at the time of merging then the branch would have been deleted.
But yes, this is related to this topic of "what should we do out of schedule?" and could/should be fixed.

First iteration:

Do not create branches out of schedule. If schedule is not met, then skip

Unless it's a rollback?

Do everything else even if it's out of schedule

Update versions in branch
Rebase branches
Create PRs (e.g. if statuses turned green)
Automerge

Second iteration:

Don't update versions in branch unless schedule is met, but do everything else


[deploy-board] Added maxlength attributes to environment page

Adds maxlength attributes to input boxes to fix chatroom 500 Error.
Adds .venv to .gitignore

r+


AssertionError running train.py

AssertionError: images should be in the range of [-1.0,1.0]!
What is this mean??
work is stop at 100th Inner Epoch Loop with that error message
I changed nothing just run with your modules
help me plz

@ojc970117 What type of your data is?

<tf.Tensor 'input_4:0' shape=(None, 256, 256, 3) dtype=float32>
this is my input datatype

@ojc970117 I have tested the code and everything works. The code is updated to TF2.2, and you can just follow the newest README file to create the proper environment.

<tf.Tensor 'input_4:0' shape=(None, 256, 256, 3) dtype=float32>
this is my input datatype
i was testing horse2zebra datasets

Happened to me too when I've tried the code with the wgan-gp option on.
The activaions are too strong and the image values are nan (which is not in the range of +-1).

@OriYitzhaki WGAN-GP with this code doesn't work, I guess WGAN-GP is not suitable for this architecture.


fix: --20220207 remove unsed files in CONTRIBUTION.md

Related Issue
Follow: #64
Propose changes
remove NOOBGUIDE.md
remove NOOBGUIDTOGIT.md
update CONTRIBUTION.md
Additional information
Checklist

[x] remove unused files in docs/global
[x] remove unused links in docs/global/CONTRIBUTION.md

Screenshoot
null
@Jacob953

This pr is only for test


DB unnecessary ordering

Hi, I've noticed this SQL SELECT * FROM items ORDER BY RANDOM() LIMIT 1 in your database.
What it does, as far as I know, is it orders WHOLE database in some random way, then selects first element. This is really slow way of fetching one random row.
Faster way of doing this is generating random number (between 0 and table size) and then doing something like SELECT * FROM items WHERE ID = <generated number>".  (It seems you don't have ID column, but column Unnamed: 0 looks like ID-like column, so making it primary key is a good idea)

Hey, thanks for your reply!
Yes I agree that it's not the most efficient way to do it!
Will fix this in the next update and close the issue.
Cheers!


[bug?]: contacts API not working

Hello!
So far I've been able to send emails via the resend.emails.send method which works great, but using the resend.contacts.create method doesn't seem to work at all? On the free plan test driving the value but I'm not seeing anywhere that this should be an issue?
Just double checking in case it's me? Thanks!
Code:
const { error: audienceError } = await resend.contacts.create({
      email,
      audienceId: "<General-audience-id>",
    });

I have the same issue, Trying to add a newsletter form to my website and it errors out like this
Error {     stack: 'Error: Failed to fetch\n' +       '    at http://localhost:4321/src/components/Newsletter.tsx?t=1709032440876:43:21',     message: 'Failed to fetch'   }

This was a user error. I fixed it by changing my API key to use "full access". Closing.


Spike migrating the TTA service into the website

⚠ WIP do not merge

Trello card
Trello-4444
Context
Changes proposed in this pull request
Guidance to review

Looks good in general @ethax-ross!
I've been through the funnels to test different branching and have hit the following issues:
1) Overseas telephone - 500 error

/teacher_training_adviser/sign_up/returning_teacher -> choose Yes
/teacher_training_adviser/sign_up/stage_interested_teaching -> choose Secondary
continue with any answers to next few questions
/teacher_training_adviser/sign_up/uk_or_overseas -> choose Overseas
/teacher_training_adviser/sign_up/overseas_country -> choose any country
/teacher_training_adviser/sign_up/overseas_telephone -> get 500 error

This step is reached through other branches - but always gives a 500 error
2) Overseas time zone - 500 error

/teacher_training_adviser/sign_up/returning_teacher -> choose No
/teacher_training_adviser/sign_up/have_a_degree -> choose I am not a UK citizen.....
continue with any answers to next few questions
/teacher_training_adviser/sign_up/uk_or_overseas -> choose Overseas
/teacher_training_adviser/sign_up/overseas_country -> choose any country
/teacher_training_adviser/sign_up/overseas_time_zone -> get 500 error


chore(wasm): reuse kong.dns object for DNS bridge

The overall goal of this PR is to make the Wasm subsystem a better citizen of Kong.
Summary
The original code used the kong.tools.dns module to attempt* to instantiate its own DNS client:
https://github.com/Kong/kong/blob/b7d50b01f4c69cbf7bbad5329f6d9947de61045b/kong/runloop/wasm.lua#L838-L839
This has not caused any problems that we are aware of, but it's not the correct behavior and could potentially lead to problems further down the line with the DNS client rewrite looming.
Reusing the global kong.dns object necessitates moving this initialization code to the init_worker phase to workaround some order-of-operations challenges (wasm.init() needs to run before core entity schemas are loaded, which is also before kong.dns is initialized).
Additionally, I have added some checks around our special ngx.IS_CLI flag to avoid setup steps in CLI mode. This means that test code that uses kong.runloop.wasm will not be expected to mock global objects that are effectively unused in this context.
*I use the word "attempt" here because the DNS client code uses a singleton pattern with state kept at the module level, so it does not in fact create a "new" DNS client--it merely re-configures the existing one in-place.
Checklist

[x] The Pull Request has tests (there are existing tests for DNS queries within Wasm filters)
[x] A changelog file has been created under changelog/unreleased/kong or skip-changelog label added on PR if changelog is unnecessary. README.md
[ ] ~There is a user-facing docs PR against https://github.com/Kong/docs.konghq.com~

Issue reference
KAG-3644

NOTE: this is not expected to be merged in time for 3.6.0

Please merge at your discretion.


Allow permissions to put the leases in the trust-manager namespace, not the trust namespace

This pull request separates the lease permissions to their own role and role binding in the namespace where trust-manager will be installed. See #224 for more details.

/ok-to-test

Sounds good. Is there anything I need to do in order to mention this in the release notes, or will it be taken care of in the release?

/lgtm

/cc @wallrj @SgtCoDFish @inteon
I am tempted to approve this as well, but since my approver status is very fresh, I don't want to do anything wrong. 👼

/cherrypick release-0.7


feat: Show bluesheets using Attended tables

Fixes #6898

Closing this PR - requirements have shifted, and it's better to start out on a clean branch.


ContentDialog's new SmokeLayerBackground template part should not be visible on OS prior to 21H1

Description:
The new ContentDialog control template in \dev\ContentDialog\ContentDialog_themeresources.xaml unconditionally uses a new SmokeLayerBackground part. It should only be used on the 21H1 OS and later.
Repro Steps:
To make it more obvious, in the file dev\ContentDialog\ContentDialog_themeresources.xaml, use a repro brush
   <Rectangle x:Name="SmokeLayerBackground" Fill="{StaticResource ReproBrush}"/>
and declare
   <SolidColorBrush x:Key="ReproBrush" Color="#AA00AA00" />
Run the MuxControlsTestApp and bring up a ContentDialog in its dedicated test page.
Result:
The green smoke layer appears.
Expected:
The old smoke layer with the "SystemControlPageBackground***MediumBrush brush should appear.
Expected Behavior:
On OS versions prior to 21H1, the SmokeLayerBackground template part should not be visible.
I think the declaration in \dev\ContentDialog\ContentDialog_themeresources.xaml should be
<Rectangle x:Name="SmokeLayerBackground" Fill="{ThemeResource ContentDialogSmokeFill}"
  contract13Present:Visibility="Visible"
  contract13NotPresent:Visibility="Collapsed"/>

instead of
<Rectangle x:Name="SmokeLayerBackground" Fill="{ThemeResource ContentDialogSmokeFill}"/>

Ideally SmokeLayerBackground would not be present at all on older systems.
Version Info:
WinUI 2.6 + 19041 OS.

What is the purpose of the ReproBrush and what is the visual and behavioural result of the new Smoke Layer Background?


CLI command "ionic g directive" points to invalid Angular docs location in comments

From @jgfet on May 18, 2017 20:2
Ionic version:  (check one with "x")
[ ] 1.x
[ ] 2.x
[x] **3.1.2
I'm submitting a ...  (check one with "x")
[x] bug report
[ ] feature request
[ ] support request => Please do not submit support requests here, use one of these channels: https://forum.ionicframework.com/ or http://ionicworldwide.herokuapp.com/
Current behavior:

ionic g Directive
generates incorrect link in comments to Angular
https://angular.io/docs/ts/latest/api/core/index/DirectiveMetadata-class.html
Expected behavior:

https://angular.io/docs/ts/latest/api/core/index/Directive-decorator.html
Steps to reproduce:

Related code:
insert any relevant code here

Other information:

Ionic info: (run ionic info from a terminal/cmd prompt and paste output below):
insert the output from ionic info here

ionic info
global packages:
@ionic/cli-utils : 1.1.2
Ionic CLI        : 3.1.2

local packages:
@ionic/app-scripts              : 1.3.7
@ionic/cli-plugin-ionic-angular : 1.1.2
Ionic Framework                 : ionic-angular 3.2.1

System:
Node       : v7.10.0
OS         : macOS Sierra
Xcode      : Xcode 8.3.2 Build version 8E2002
ios-deploy : 1.9.1
ios-sim    : 5.0.13

Copied from original issue: driftyco/ionic#11722

@jgw96 The generator templates are in the framework repo: https://github.com/driftyco/ionic/blob/master/scripts/templates/directive/ts.tmpl#L6


When this SBOM is ingested it seems to be missing matching purl table entries

I am assuming that an sbom that denotes packages with package relationships should result in matching entries into purl tables ... the following analysis graph warnings show that
https://anchore.com/syft/image/registry.access.redhat.com/ubi9/ubi-768a701e-12fb-4ed1-a03b-463b784b01bf

seems to be 'special'
2024-09-12T19:41:36.185283Z  WARN ingest{format=Unknown labels=("source", "TrustifyContext") issuer=None}: trustify_module_analysis::service: sbom:https://anchore.com/syft/image/registry.access.redhat.com/ubi9/ubi-768a701e-12fb-4ed1-a03b-463b784b01bf has packages with no pURL.
2024-09-12T19:41:36.200964Z  WARN ingest{format=Unknown labels=("source", "TrustifyContext") issuer=None}: trustify_module_analysis::service: sbom:https://anchore.com/syft/image/registry.access.redhat.com/ubi9/ubi-768a701e-12fb-4ed1-a03b-463b784b01bf has packages with no pURL.
2024-09-12T19:41:36.201046Z  WARN ingest{format=Unknown labels=("source", "TrustifyContext") issuer=None}: trustify_module_analysis::service: sbom:https://anchore.com/syft/image/registry.access.redhat.com/ubi9/ubi-768a701e-12fb-4ed1-a03b-463b784b01bf has packages with no pURL.
2024-09-12T19:41:36.201066Z  WARN ingest{format=Unknown labels=("source", "TrustifyContext") issuer=None}: trustify_module_analysis::service: sbom:https://anchore.com/syft/image/registry.access.redhat.com/ubi9/ubi-768a701e-12fb-4ed1-a03b-463b784b01bf has packages with no pURL.
2024-09-12T19:41:36.201086Z  WARN ingest{format=Unknown labels=("source", "TrustifyContext") issuer=None}: trustify_module_analysis::service: sbom:https://anchore.com/syft/image/registry.access.redhat.com/ubi9/ubi-768a701e-12fb-4ed1-a03b-463b784b01bf has packages with no pURL.
2024-09-12T19:41:36.201105Z  WARN ingest{format=Unknown labels=("source", "TrustifyContext") issuer=None}: trustify_module_analysis::service: sbom:https://anchore.com/syft/image/registry.access.redhat.com/ubi9/ubi-768a701e-12fb-4ed1-a03b-463b784b01bf has packages with no pURL.
2024-09-12T19:41:36.201123Z  WARN ingest{format=Unknown labels=("source", "TrustifyContext") issuer=None}: trustify_module_analysis::service: sbom:https://anchore.com/syft/image/registry.access.redhat.com/ubi9/ubi-768a701e-12fb-4ed1-a03b-463b784b01bf has packages with no pURL.
2024-09-12T19:41:36.201150Z  WARN ingest{format=Unknown labels=("source", "TrustifyContext") issuer=None}: trustify_module_analysis::service: sbom:https://anchore.com/syft/image/registry.access.redhat.com/ubi9/ubi-768a701e-12fb-4ed1-a03b-463b784b01bf has packages with no pURL.
2024-09-12T19:41:36.201170Z  WARN ingest{format=Unknown labels=("source", "TrustifyContext") issuer=None}: trustify_module_analysis::service: sbom:https://anchore.com/syft/image/registry.access.redhat.com/ubi9/ubi-768a701e-12fb-4ed1-a03b-463b784b01bf has packages with no pURL.
2024-09-12T19:41:36.201187Z  WARN ingest{format=Unknown labels=("source", "TrustifyContext") issuer=None}: trustify_module_analysis::service: sbom:https://anchore.com/syft/image/registry.access.redhat.com/ubi9/ubi-768a701e-12fb-4ed1-a03b-463b784b01bf has packages with no pURL.
2024-09-12T19:41:36.201208Z  WARN ingest{format=Unknown labels=("source", "TrustifyContext") issuer=None}: trustify_module_analysis::service: sbom:https://anchore.com/syft/image/registry.access.redhat.com/ubi9/ubi-768a701e-12fb-4ed1-a03b-463b784b01bf has packages with no pURL.
2024-09-12T19:41:36.217760Z  WARN ingest{format=Unknown labels=("source", "TrustifyContext") issuer=None}: trustify_module_analysis::service: sbom:https://anchore.com/syft/image/registry.access.redhat.com/ubi9/ubi-768a701e-12fb-4ed1-a03b-463b784b01bf has packages with no pURL.
2024-09-12T19:41:36.217850Z  WARN ingest{format=Unknown labels=("source", "TrustifyContext") issuer=None}: trustify_module_analysis::service: sbom:https://anchore.com/syft/image/registry.access.redhat.com/ubi9/ubi-768a701e-12fb-4ed1-a03b-463b784b01bf has packages with no pURL.
2024-09-12T19:41:36.217870Z  WARN ingest{format=Unknown labels=("source", "TrustifyContext") issuer=None}: trustify_module_analysis::service: sbom:https://anchore.com/syft/image/registry.access.redhat.com/ubi9/ubi-768a701e-12fb-4ed1-a03b-463b784b01bf has packages with no pURL.

will root cause this as well as quiet down the warnings. And if we go through the trouble of generating warnings make them actually useful.

cargo test -p trustify-module-fundamental syft_rerun

it's really just this line: https://github.com/trustification/trustify/blob/9722fdc474071b54fde7ec1792723fb1bc13ba24/modules/fundamental/tests/sbom/reingest.rs#L287
Therefore, it's something about this file: https://github.com/trustification/trustify/blob/main/etc/test-data/syft-ubi-example/v1.json.xz

Not all packages have purls. That's a file generated by syft, a tool we expect to support. So, that's just the data we have I guess.

that seems to be a gap that needs addressing ... in these instances should we attempt to construct a purl ? otherwise in our system if a package has relationships but no purl I think there are implications right ?

that seems to be a gap that needs addressing ... in these instances should we attempt to construct a purl ? otherwise in our system if a package has relationships but no purl I think there are implications right ?

I am sure there are implications. However, I am not sure creating artificial PURLs will do the trick. Maybe, but maybe that causes more trouble than just admitting there has CPEs, hashes, and maybe other ways of identifying packages/components.

ok will adjust analysis graph to cater for all forms of ID ... though it does make me wonder how consistent we are internally addressing components


Content.fix—cross contract comments test

Minor cleanup on an awesome article. I also removed a warning about the gas being exceeded because I see this issue has been addressed and closed here:
https://github.com/nearprotocol/nearlib/issues/176

I've reverted that atomic commit removing the warning, and must confess I am quite confused now. I followed the directions in the cross-contract page using Studio. In the instructions, we start from the ready-made Token Smart Contract. Now I see that the package.json doesn't include nearlib. So I'm unsure how the nearlib issue with new BN('… plays into this.
This might be a question that's worth filing away in the back of our heads. There are some very minor changes in this PR that still add a teeny bit of value.

oh i think you were right to remove that warning, it was my misunderstanding in the end and @vgrichina just suggested we wrap the gas with BN to make sure it's handled properly.

oh i think you were right to remove that warning, it was my misunderstanding in the end and @vgrichina just suggested we wrap the gas with BN to make sure it's handled properly. i mean, doesn't it just work once you make this recommended edit? no gas limit warning at runtime?

I doesn't work when I add the new BN(… edit because it couldn't find BN. So then I looked at the imports for nearlib and didn't see it there. BN lives in nearlib as is discussed in the other issue. Then I went to the git blame for NEARStudio's Token Smart Contract dependencies to see if it used to have nearlib as a dependency at some point. (Thinking, perhaps, that it was updated.) Didn't see that either.
So I'm confused as to the how the mentioned issue (https://github.com/nearprotocol/nearlib/issues/176#issuecomment-577064933) has a link between nearlib and the smart contract in the tutorial, which is based on the Token Smart Contract as a base.
I feel like I just said a bunch of words that may weaved into tangled spaghetti. Happy to jump on a video chat to discuss if this is confusing.

Perhaps I can summarize with this picture. I don't get how nearlib plays into this issue, as specified in the linked issue.

When I go to Studio and create the Token Smart Contract, where we start, not seeing nearlib. So perhaps we add that as a dependency and then use new BN(?

@amgando did we decide to keep the gas warning in there and incorporate the rest of the comments?

did we decide to keep the gas warning in there and incorporate the rest of the comments?

@mikedotexe -- sure, let's merge this and revisit


Allow CanonicizeSql to change tabs to spaces

A PostgreSQL function using tabs as white space will currently never match the expected canonicizedSql created by Marten.
The CanonicizeSql() function should be updated to support having tabs as whitespace.

Closed by @awedekind 's PR.


Angular-multipage sample: missing $

Category

[ ] Question
[x] Bug
[ ] Enhancement

Expected or Desired Behavior
Hey guys, just a small correction: there's a tiny mistake in the angular-multipage example, the VoteController.ts is missing the Angular dollar sign ($) before the event word on line 55.
Please compare with line 75 for reference.
The web part doesn't work during the voting phase because of the missing $.
Thanks much for the samples!

Ah, good catch. Sorry for that. I will submit a PR asap.


New Python3 port!

Hi!
Based on your work, I've released a Python3 port with some minor improvements!
Check it out here if you are interested.
I leave this issue here in case someone drops by here and needs the Python3 version.
Thanks for this work!

Thanks @iitzco !


[WIP] Revert lower tvm builtin change

I’m not actually an expert in vta or opencl. CC @tmoreau89 if you are interested :-)

Thanks for the WIP PR, please let me know when it's ready for review @zhanghaohit  - and also please provide a short summary of the PR in the description box, thanks!

@zhanghaohit looks like the CIs are green! Let me know when you'd like to change this PR to not WIP

@zhanghaohit looks like the CIs are green! Let me know when you'd like to change this PR to not WIP

Hi @tmoreau89, this PR is actually the same as #8274 proposed by @mbrookhart . It is to show how to pass the CI if we want to revert the lower_tvm_builtin_change.
I think it is better to let @mbrookhart apply the changes to his PR  #8274, which has already much discussion and context there.
I'll close this PR first, in order not to confuse.

Ah no problem, my reaction times have been slow lately, I'm glad we're making forward progress.


Allow giving the buffers names

I also now unconditionally name shaders and compute pipelines.
Naming buffers however is an additional feature, as it potentially has consequences for buffer reuse efficiency, since we specify buffers with the given names.
I can confirm that this works in renderdoc.

The Xcode crashes are happening on main, it doesn't seem like this patch is responsible. It might just be that my machine is in a bad state.


build: update connect

Updates connect to latest, and updates the authOptions to use onFinish and the default authOrigin.

@hstove I just merged a PR, can you rebase off master with these changes before I review?

@aulneau yep, all set.

@hstove I tried the preview link and there is something off with Connect:

@aulneau cool, looks like the resolution fixed it. Weird issue.
Sometimes the way node/npm supports multiple versions of a dep is nice, and sometimes it can be a pain in the butt (like here). I remember "fun" times in Ruby trying to coerce my gems so that they'd be able to resolve to the same version of a dependency.

@hstove there is still a bug here that once someone logs in, the connect modal does not dismiss. Could it be a regression in connect somewhere?

@aulneau mind creating an issue in the UX repo with the problem you see and linking to here?

updating this issue based on the sprint meeting: this should be based on the latest version (with stenciljs)


Fix iTerm2 light colour scheme bold and cursor guide colours

The iTerm2 Bold and Cursor Guide colours are the same as the background, which means those elements are invisible when their preferences are enabled:

Before:

After:

May fix #26 if the issue there is due to the use of Bold


onefuzz cli discards stderr output from azcopy

Information

Onefuzz version: 4.0.0
OS: Windows

Provide detailed reproduction steps (if any)

Submit onefuzz job
have azcopy fail
observe output from CLI

because onefuzz cli uses subprocess.check_output() to run azcopy, stderr gets discarded.
Expected result
If azcopy fails, the data from stderr should be passed back to the user
Actual result
Only stdout is shown to the user, discarding error messages potentially useful for troubleshooting.
Example:
ERROR:main:Failed to execute command "['C:\Users\comcma\.azcopy\AzCopy.exe', 'sync', 'C:\_work\22\XXXXX\plugin\continuous-fuzzing\onefuzz-deploy\onefuzz-setup', 'XXXXX', '--recursive=true']". stdout: "b"INFO: Any empty folders will not be processed, because source and/or destination doesn't have full folder support
Job b3a3b9c7-fc30-954a-6137-fe6604946d58 has started
Log file is located at: C:\Users\comcma\.azcopy\b3a3b9c7-fc30-954a-6137-fe6604946d58.log
0 Files Scanned at Source, 0 Files Scanned at Destination
INFO: AzCopy.exe: A newer version 10.13.0 is available to download
0 Files Scanned at Source, 0 Files Scanned at Destination
0.2 %, 28 Done, 1 Failed, 11 Pending, 40 Total, 2-sec Throughput (Mb/s): 1845.4263
4.1 %, 35 Done, 1 Failed, 4 Pending, 40 Total, 2-sec Throughput (Mb/s): 3860.1553
4.9 %, 36 Done, 1 Failed, 3 Pending, 40 Total, 2-sec Throughput (Mb/s): 2814.9933
8.7 %, 36 Done, 1 Failed, 3 Pending, 40 Total, 2-sec Throughput (Mb/s): 3474.0406
11.7 %, 36 Done, 1 Failed, 3 Pending, 40 Total, 2-sec Throughput (Mb/s): 2563.0196
15.1 %, 36 Done, 1 Failed, 3 Pending, 40 Total, 2-sec Throughput (Mb/s): 3207.0888
19.0 %, 36 Done, 1 Failed, 3 Pending, 40 Total, 2-sec Throughput (Mb/s): 3501.1619
21.7 %, 36 Done, 1 Failed, 3 Pending, 40 Total, 2-sec Throughput (Mb/s): 2488.6603
24.9 %, 36 Done, 1 Failed, 3 Pending, 40 Total, 2-sec Throughput (Mb/s): 2984.8678
28.7 %, 36 Done, 1 Failed, 3 Pending, 40 Total, 2-sec Throughput (Mb/s): 3527.8311
32.4 %, 36 Done, 1 Failed, 3 Pending, 40 Total, 2-sec Throughput (Mb/s): 3363.0054
36.0 %, 36 Done, 1 Failed, 3 Pending, 40 Total, 2-sec Throughput (Mb/s): 3374.8095
40.1 %, 36 Done, 1 Failed, 3 Pending, 40 Total, 2-sec Throughput (Mb/s): 3639.0506
43.6 %, 36 Done, 1 Failed, 3 Pending, 40 Total, 2-sec Throughput (Mb/s): 3204.426
46.5 %, 36 Done, 1 Failed, 3 Pending, 40 Total, 2-sec Throughput (Mb/s): 2709.4768
49.5 %, 36 Done, 1 Failed, 3 Pending, 40 Total, 2-sec Throughput (Mb/s): 2756.3732
52.7 %, 36 Done, 1 Failed, 3 Pending, 40 Total, 2-sec Throughput (Mb/s): 3021.2756
56.5 %, 36 Done, 1 Failed, 3 Pending, 40 Total, 2-sec Throughput (Mb/s): 3494.6863
58.7 %, 36 Done, 1 Failed, 3 Pending, 40 Total, 2-sec Throughput (Mb/s): 2059.5965
62.0 %, 36 Done, 1 Failed, 3 Pending, 40 Total, 2-sec Throughput (Mb/s): 3077.1736
66.0 %, 36 Done, 1 Failed, 3 Pending, 40 Total, 2-sec Throughput (Mb/s): 3628.0642
69.1 %, 36 Done, 1 Failed, 3 Pending, 40 Total, 2-sec Throughput (Mb/s): 2906.1173
70.6 %, 36 Done, 1 Failed, 3 Pending, 40 Total, 2-sec Throughput (Mb/s): 1408.3869
72.9 %, 36 Done, 1 Failed, 3 Pending, 40 Total, 2-sec Throughput (Mb/s): 2097.6759
75.8 %, 36 Done, 1 Failed, 3 Pending, 40 Total, 2-sec Throughput (Mb/s): 2663.3646
78.9 %, 36 Done, 1 Failed, 3 Pending, 40 Total, 2-sec Throughput (Mb/s): 2830.7833
82.4 %, 36 Done, 1 Failed, 3 Pending, 40 Total, 2-sec Throughput (Mb/s): 3269.9332
87.1 %, 36 Done, 1 Failed, 3 Pending, 40 Total, 2-sec Throughput (Mb/s): 4375.3138
87.9 %, 36 Done, 1 Failed, 3 Pending, 40 Total, 2-sec Throughput (Mb/s): 788.9237
89.8 %, 37 Done, 1 Failed, 2 Pending, 40 Total, 2-sec Throughput (Mb/s): 1743.9527
92.6 %, 37 Done, 1 Failed, 2 Pending, 40 Total, 2-sec Throughput (Mb/s): 2526.4545
95.1 %, 37 Done, 1 Failed, 2 Pending, 40 Total, 2-sec Throughput (Mb/s): 2266.9438
97.5 %, 37 Done, 1 Failed, 2 Pending, 40 Total, 2-sec Throughput (Mb/s): 322.2314
99.5 %, 37 Done, 1 Failed, 2 Pending, 40 Total, 2-sec Throughput (Mb/s): 0
100.0 %, 38 Done, 1 Failed, 1 Pending, 40 Total, 2-sec Throughput (Mb/s): 0
Job b3a3b9c7-fc30-954a-6137-fe6604946d58 Summary
Files Scanned at Source: 40
Files Scanned at Destination: 0
Elapsed Time (Minutes): 1.2102
Number of Copy Transfers for Files: 40
Number of Copy Transfers for Folder Properties: 0
Total Number Of Copy Transfers: 40
Number of Copy Transfers Completed: 39
Number of Copy Transfers Failed: 1
Number of Deletions at Destination: 0
Total Number of Bytes Transferred:<PHONE_NUMBER>2
Total Number of Bytes Enumerated:<PHONE_NUMBER>0
Final Job Status: CompletedWithErrors
"", stderr: "None"
Traceback (most recent call last):
File "C:_work\22\XXXXX\onefuzz\XXXXX.py", line 238, in main
setup_shared_containers(
File "C:_work\22\XXXXX\onefuzz\XXXXX.py", line 555, in setup_shared_containers
job_helper.onefuzz.containers.files.upload_dir(
File "C:\Program Files\Python39\lib\site-packages\onefuzz\api.py", line 229, in upload_dir
client.upload_dir(dir_path)
File "C:\Program Files\Python39\lib\site-packages\onefuzz\backend.py", line 378, in upload_dir
azcopy_sync(dir_path, self.container_url)
File "C:\Program Files\Python39\lib\site-packages\onefuzz\azcopy.py", line 29, in azcopy_sync
subprocess.check_output([azcopy, "sync", src, dst, "--recursive=true"])  # nosec
File "C:\Program Files\Python39\lib\subprocess.py", line 424, in check_output
return run(*popenargs, stdout=PIPE, timeout=timeout, check=True,
File "C:\Program Files\Python39\lib\subprocess.py", line 528, in run
raise CalledProcessError(retcode, process.args,
subprocess.CalledProcessError: Command '['C:\Users\comcma\.azcopy\AzCopy.exe', 'sync', 'C:\_work\22\XXXXX\plugin\continuous-fuzzing\onefuzz-deploy\onefuzz-setup', 'XXXXXXX', '--recursive=true']' returned non-zero exit status 1.
INFO:main:Deleting job f25a00f8-1345-4136-805

note:
check_output can capture stderr if configured to do so:
"To also capture standard error in the result, use stderr=subprocess.STDOUT" - https://docs.python.org/3/library/subprocess.html?highlight=subprocess#subprocess.check_output


Cannot add Friendica account anymore.

59.15 from fdroid seems to have issues adding Friendica 2022.12 accounts. Chose Mastodon, entered my instance name (loma.ml) and ended up with "entity could not be processed". Known problem?

@kr428 Please check if this problem is caused by an upgrade. Previous versions may be downloaded e.g. from history of changes here: https://github.com/andstatus/andstatus/issues/456

I just checked if adding an account at mastodon.social works with current code: yes, it does.
So this looks like a problem that may need friendica developers for a fix.

@yvolk I downgraded to 59.10, re-added the account - which worked - and upgraded to 59.15 afterwards - which left it working, on the same Friendica instance. So it feels like this is somehow related to changes in between 59.10 and 59.15 for the initial signup / auth procedere? Any info I can provide to debug this?

@kr428 The problem is probably related to this improvement of compatibility with OAuth 2.0 specification. That fix may affect services that followed Mastodon's implementation instead. See https://github.com/andstatus/andstatus/issues/561
Please note that even after this change AndStatus still can successfully add an account at Mastodon instance (I tested this yesterday at mastodon.social ).
Please read that thread with our notes on testing.
In order for me look at this, I need to have a test account at the Friendica server having the latest development version. Could you provide such an account for me?

Trying to ping @annando here. I think squeet.me runs latest development version of Friendica; maybe however (looking at #561) this might require changes in Friendica as well?

Squeet.me is on dev, but not the current one.

@kr428

this might require changes in Friendica as well?
Maybe this will be Friendica-side change only...

@annando

Hi @annando , I checked Squeet.me and I don't see any registration link there.
Anyway, I tried to log into squeet.me, and got similar response from a server as @kr428 there during opening authorization web page:

AndStatus opens the web page:

https://squeet.me/oauth/authorize?response_type=code&client_id=62149b5c194dff7b20644d36599624386475b9efb668bf5bb08fed0c3235ca63&redirect_uri=http%3A%2F%2Foauth-redirect.andstatus.org&scope=read%20write%20follow&state=state_65_1673634926129

and instead of an HTML response gets this:
{
    "error": "Unprocessable Entity"
}

Probably this is caused by addition of "client_id" to the Access Token Request as required by OAuth 2.0 spec, see my comment https://github.com/andstatus/andstatus/issues/561#issuecomment-1355571970
Friendica code should be adapted to handle this normally as this conforms to the spec.

BTW: I just saw that you still has got a test account on my machine that I use for developing: pirati.ca.

Yes, I tried pirati.ca yesterday also. Didn't remember that it is also yours :-)
I my old AndStatus setup Pirati.ca is still "GnuSocial" type of social network... tried now and got that even your old profile there currently is mapped to some other person... (consequence of using numbers as local users' IDs...)

I try to work on it this weekend. So possibly you can even test it before I created the PR.

I just saw that on creating the app the redirect_uris is transmitted as array. Currently we only support a string here.

@annando Thank you for information.
Regarding Client registration please see https://github.com/andstatus/andstatus/issues/561#issuecomment-1356223928
Currently AndStatus makes up to two attempts to register:

OAuth 2.0 - compliant (see https://www.rfc-editor.org/rfc/rfc7591#section-3.1 )  - please see that "redirect_uris" IS an array according to the spec.
If the registration fails, AndStatus makes the second attempt, this time - with a hack for Mastodon.

See the metadata for these attempts: https://github.com/andstatus/andstatus/blob/17891408454e06c27ea8539e27ee729c9a1a2d86/app/src/main/kotlin/org/andstatus/app/net/http/HttpConnectionOAuth2.kt#L96

@annando I would suggest for Friendica to support standard OAuth 2.0 also, not only Mastodon's custom variant.
OR fail at the first attempt (as Mastodon itself does)

What about the missing client_secret upon requesting the token?

@annando
I see that Access Token Request (POST) to https://pirati.ca/oauth/token does have "client_id" body parameter yet the sever responds with 401 Unauthorized.

Probably your OAuth 2.0 implementation fails due to absence of client_secret?! As was noted here: https://github.com/andstatus/andstatus/issues/561#issuecomment-1354596980

that's weird, it looks like Mastodon token endpoints require both client_id and client_secret: https://docs.joinmastodon.org/methods/oauth/#token

I think we better not add client_secret here bacause it's not even an optional parameter, see https://datatracker.ietf.org/doc/html/rfc6749#section-4.1.3

Concerning the client_secret I found this: https://www.oauth.com/oauth2-servers/access-tokens/authorization-code-request/

If the client was issued a client secret, then the server must authenticate the client. One way to authenticate the client is to accept another parameter in this request, client_secret. Alternately the authorization server can use HTTP Basic Auth.

and: https://www.oauth.com/oauth2-servers/access-tokens/client-credentials/

The client needs to authenticate themselves for this request. Typically the service will allow either additional request parameters client_id and client_secret, or accept the client ID and secret in the HTTP Basic auth header.

So for me it seems as if the client_secret has to be provided all the time.

@annando Aha-ha :-) I've started to remember that we had similar discussions some time ago... And yes, I see that you and me discussed exactly the same thing two years ago :-)
Please look here: https://github.com/andstatus/andstatus/issues/537

AFAIK that discussion had been about where to fetch these values, see the code here:
https://github.com/friendica/friendica/blob/develop/src/Module/OAuth/Token.php#L56-L72

I see where I think the bug is. From your code:
if (empty($request['client_id']) && substr($authorization, 0, 6) == 'Basic ') {

Since recently AndStatus started to post client_id in the request body of the "Access Token Request", which is allowed according to the specification. But I see that your code, seeing this "client_id" in the body, doesn't even try to look in the header,  where both client_id and client_secret, I think, are still present (I didn't change that).

The PR is merged. It should work now again.

I tested that I can add an account at pirati.ca (as a Mastodon Social Network). And can post...
Thank you, @annando !


Look into enabling UI development in the clouds

Setup continuous deployment to a test environment
Make it easy for UI developers to directly use this test environment instead of relying on complex local setup.
@markpatton could you fill in the details for this ticket please?

Initial approach is to see if ember can be run locally and everything else run in pass-docker. If that works, the docker stack could be put in the cloud.

@jaredgalanis / @markpatton I use an ubuntu cloud server (managed with bash scripts to install the necessary components) so we could look into moving those scripts into a Dockerfile and then having a setup like
Build the image (possibly built and availble within GH registry)
docker build -t pass-ui-dev .

Run the image (note that mapping to the current project)
docker run -v "$PWD":/usr/app -it --entrypoint bash pass-ui-dev)

And within the docker file we have the pass-ui in a VOLUME
VOLUME /usr/app

Closing in favor of https://github.com/eclipse-pass/main/issues/245 and https://github.com/eclipse-pass/main/issues/246.


Large refactor

This refactor makes the following changes:

The crawler is now called with scrapy crawl edx (as per Scrapy's documention) instead of the custom pa11ycrawler script
Settings and complexity have been drastically cleaned up, so the whole thing is simpler to read and understand
Functionality to transform JSON into HTML has been pulled out of the crawler into a separate script (pa11ycrawler-html), and also simplified
The existing tests have been removed, and new ones added to replace them
README has been updated
No need to install pa11y globally -- this project now uses the local npm install
The crawler will now ignore the following kinds of URLs:

URLs where the path starts with /xblock/
URLs where the path starts with /api/ (part of Django Rest Framework) -- these pages will be scraped for further links, but not checked for accessibility violations
URLs containing /logout/ (this was there before)
URLs containing ?_accept=application/x-tgz, so the crawler doesn't try to download course exports

This will need to be coordinated with https://github.com/edx/edx-platform/pull/13225
@clrux @cptvitamin do either of you want to do a code review? If you want me to just merge it, I'll need the permissions -- I don't seem to have merge permissions on this repo. :(

Nice work! I might ping @jzoldak or @benpatterson on this one.

@jzoldak can you lend a hand with review? I will take a pass now but will be largely unavailable tomorrow (just a heads up)

Done with my pass.
I do have some questions that I'd appreciate your feedback on.
In general, nothing particularly stuck out to me; the changes make sense on my first read of them. I haven't looked at the corresponding job output yet, though. I defer to @cptvitamin on whether or not that will be better for him. Also it's worth noting that we have a splunk report that looks at console output to find our pa11y count trends. I wonder if that will need to be changed...could you look at that @singingwolfboy ? I only wrote it recently; so we don't need to refactor the crawler to make it put in the same output; moreso I'd want to refactor the splunk report so it keeps giving us trends. (If it needs to be refactored, that is.)
For the test file, I think you should also add testcases for whatever pa11y returns. We should be able to handle errors, and success, for example.  I realize it's outside the bounds of the tool (e.g., it's a dependency), but it would probably help us out in the long run if we had some end-to-end test, so that whenever the pa11y node library is updated, it's giving us the same results we expect. I don't have a quick answer for you on that, but I'd like to hear your ideas.
Thanks for putting this together; I'll stand by for feedback/comments. I'll be offline much of tomorrow but will try to reply if I can.

For the test file, I think you should also add testcases for whatever pa11y returns. We should be able to handle errors, and success, for example. I realize it's outside the bounds of the tool (e.g., it's a dependency), but it would probably help us out in the long run if we had some end-to-end test, so that whenever the pa11y node library is updated, it's giving us the same results we expect. I don't have a quick answer for you on that, but I'd like to hear your ideas.

I understand your rationale here, but I don't think it's necessary. First of all, pa11y's return format is totally dependent on which formatter you choose to use. Right now, it's using the 1.0-json reporter, which exists primarily to support tools that are dependent on the older output format. It would be nice to be able to upgrade to the newer JSON output format, which has a bit more information. (It just didn't seem worthwhile to do that in this pull request, which is already plenty large enough.)
Second, there is a cost to writing tests. Those tests must be maintained, understood, upgraded, etc, and that puts a tax on new development. For something like this, errors are easy to spot (since pa11ycrawler-html script won't run properly), and should be easy to revert. I don't really feel it's necessary.
That being said, if you tell me to write more tests for this, I can do that -- I'm just giving you my thoughts and perspective here. Let me know what you'd like.

@singingwolfboy I'm done with my second pass.
The only must for me at this point is the data clean-up. I'm not as concerned with the implementation (I understand your arguments), but my main issue here is having some way of programmatically cleaning out the data.
I also think a couple explicit asserts on the dropped items would be good, but admittedly is not a must for me.

@benpatterson I added a commit that changes the default data directory to /var/opt/pa11ycrawler, and updated the make clean task to run rm -rf /var/opt/pa11ycrawler. Does that do what you want?

Thanks @singingwolfboy. That's a step in the right direction. I had imagined it living under the project directory somewhere. (Again in that case, I'm picturing what would happen if we ran it in automation and had multiple instances running against different sites.) Could you change it to something within the project directory? Perhaps instead of data/ it could be data/reports/pa11ycrawler/ Something like that? If you want to have a different make target for the report output vs the *.pyc files, that would be fine IMO.

Last change looks good to me @singingwolfboy
Overall I give 👍 assuming tests pass

I say we're good to merge. @jzoldak if you end up reviewing and giving feedback, I suggest we put that in a separate, follow-up PR.

👍

@singingwolfboy @benpatterson Thx for your patience, and apologies for not getting to this PR sooner. LGTM 👍


Create Group

How can I create group? Thanks

Fixed in #316, in release v1.4.0. The method is called createGroup


Fix#261 Replace vars with lets

All vars in price.js can be replaced with lets since they are used within the declaration scope. However, some of the variable names are exact the same for function parameters and local variables, which might cause confusion. You might want to file an issue to rename some of them.
For file purge.js, I moved variable "newamount" declaration outside the if/else block so it can be declared with let.
In conclusion, the fix replaced all vars with lets. Only two files price.js and purge.js are involved. There is no "var" left in any file. Let me know if any issues or further changes needed.

Thank you, this looks good to me. I haven't checked the codebase for other vars yet, but as soon as I do so I'll merge this.
I'll then consider if the renaming issue is worth filing

Just confirmed through Github repo search that vars only existed in the two files mentioned above. LGTM.

@haichuan0424 , thanks for the PR!
Can we show you some appreciation for the contribution?
Also, we're giving away some Hacktoberfest bonuses and goodies for this month. We'll get it all figured out after you shoot us an email after this is reviewed/merged.

Already merged

@tzarebczan
Glad I could help! It would be great to get some bonuses.


New "add component" menu item on component

We want a new + menu item on the small menu that sits underneath the menu like so

Pressing it opens the component browser connecting a new component to the existing one.
If the visualisation is open the + button needs to move down under the visualisation

When the new component is added it should be positioned

vertically in line with where the + button is when it is pressed
horizontally left aligned with component it is being added from

I think the + should be grey to match the other wheel icons. Not blue like in the screenshots and the existing + button.

When the new component is added it should be positioned
vertically in line with where the + button is when it is pressed
horizontally left aligned with component it is being added from

What if the place is already occupied? Also, I think the node appearing in place of + button will be very close to the node above - much closer than it is today, when you press enter with node selected.

This is the enter button spacing today

Not sure we will be far out. Can always move the + button down a bit.
In terms of collisions. I think we just put it on top for first pass. The user can see where it is going to go so it is their choice.


[SFTTrainer] Fix the sequence length check of SFTTrainer

What does this PR do?
Fixes https://github.com/lvwerra/trl/issues/467
Replaces https://github.com/lvwerra/trl/pull/481
The original code lead to having examples that were filtered out by the previous check. This ultimately lead to having examples being ignored when processing the data. Probably a copy-pasta from: https://huggingface.co/learn/nlp-course/chapter7/6?fw=pt where I borrowed the original code
The fix is to remove completely that check
cc @lvwerra

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.

We should also set padding=False and  return_length=False. Otherwise looks good.


Add market parameter to 'getArtistAlbums' methods

When retrieving an artist's albums via SpotifyService's getArtistAlbums(...), duplicate albums are returned (a copy per available market). This pull request includes getArtistAlbums(...) methods with the option to include a market to ensure that only albums available in the provided country are returned.

The most recent pull request contains QueryMap annotations on each method that contains more than one optional query filter. I retained default methods (no filter options) for each applicable method and removed redundant methods (explicit filter options). This cleans up the SpotifyService class a bit and makes it more scalable. However, the Retrofit @QueryMap annotation does make it less intuitive, so we may want to include documentation or a link to the Web API console if we decide to take the full QueryMap route.

I like the direction of this change, it should simplify the API. But you are correct about QueryMap being less readable. I also find it quite bad that you need to set numerical values as strings on a HashMap,
so I'd like to work on it a bit more before releasing.
My suggestion is to merge this to a different branch and work on it there. I created one called query_map for this purpose.
If you open this new PR please remove the first commit (not needed anymore) and squash the remaining two (tests breaking).

@ryandt we have now updated the wrapper and the getArtistAlbums method now supports the market parameter through QueryMap. I will close this PR as its content is included in the change we just made.

+1


Notification drawer: __body flex-basis bug with flex shorthand declaration

Using flex: 1 1 0 is resulting in inconsistent behavior as reported by @jcaianirh and flex-basis is evaluating as 0px instead of 0% and is giving __body a 0px height.

:tada: This issue has been resolved in version 2.47.2 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Prevent certain maker args from silently vanishing

In some rare cases, args passed to the maker (such as colon separated
classpaths) can be overidden to become an empty string by expand()
This commit fixes this by employing a utility function that is then
passed to map

You can escape special characters so expand() interprets them literally.
I guess I'm not sure how you're getting your classpath from java into your maker args, so you may need to tweak this, but here's what I'm thinking:
let g:neomake_java_javac_args = ['-classpath', 'some\:pie\:here']

@benekastah makes sense - I encountered this issue when pulling the classpaths from the JavaComplete2 plugin. I'll fiddle with a way to programatically escape the strings - I just wasn't having any luck with built in escaping mechanisms.
The main reason I opened this is that I haven't encountered similar problems with syntastic, but I understand the need for this kind of workaround :)


failed install alexander

There was an error jumped out when I try to install alexander. I just delete that xivalex.chaindll.0\d3d11.dll manually because I have no idea what is this. But maybe it cause a serious problem. How to fix that?

Update: I changed the name of FFXIV to FFXIV-2 to change the path of the game and it worked, alexander has been installed successfully. But there is another problem that every time when I start the game

But I can just click ignore and the game will run normally with alexander. It has no affection on my game but I don't know what happens here


Added encoding option, and Set default encoding to ASCII-8BIT

Fixed https://github.com/sensu/sensu-community-plugins/issues/802.
Default is set to ASCII-8BIT instead of US-ASCII to handle all characters even if it is not the right encoding (unicode). It allows check-procs.rb to not generate exception even if encoding is unicode.

Who decides to accept this pull? :-)

You are everywhere :-)

Hi, can you open a PR against https://github.com/sensu-plugins/sensu-plugins-process-checks/blob/master/bin/check-process.rb ? I'll merge it, thanks!!

Moved PR to new home: https://github.com/sensu-plugins/sensu-plugins-process-checks/pull/19


feat(primitive): add generics version container/list

Go container/list with generics.

Is casbin's golang version support generics?

As a Casbin compatible policy store, we may need to consider it.

As a Casbin compatible policy store, we may need to consider it.

As an independent engine, I think no need to consider whether casbin supports the generics.

As a Casbin compatible policy store, we may need to consider it.

As an independent engine, I think no need to consider whether casbin supports the generics.

🤔 But if casbin cannot support generics, then how does it uses our engine🤔
I think our goal are just an embedded policy store rather than a policy store service


Watch-Only Address

Possible to add a watch-only address with public key but no private key stored?

I don't hate this and I especially love it for the Chrome Extension. However, perhaps on a new tab or make it so stupidly explicit they they are just viewing a wallet.
I'm becoming jaded because I've literally spent 6 hours today helping people (PLEASE DO NOT CALL MY CELL PHONE!!!!! Also, I have a real job!) who have "lost" a key piece of information that they need to access their wallet. I say "lost" because they didn't even know they needed it! They thought they had access because they saw their balance on etherchain. I hate to design for the lowest common denominator but seeing people "lose" thousands of ETH in this way is so freaking painful.
Anyone else feel free to chime in. We should be pushing an update ~Monday and may include this.

New Tab sounds viable. Maybe titled something like "Expert Settings" or
"Advanced Configuration" or some other scary sounding technical term with
all sorts of BIG RED WARNING words all across the top of it.
On Thu, Feb 11, 2016 at 6:41 PM, Taylor Van Orden<EMAIL_ADDRESS>wrote:

I don't hate this and I especially love it for the Chrome Extension.
However, perhaps on a new tab or make it so stupidly explicit they they are
just viewing a wallet.
I'm becoming jaded because I've literally spent 6 hours today helping
people (PLEASE DO NOT CALL MY CELL PHONE!!!!! Also, I have a real job!) who
have "lost" a key piece of information that they need to access their
wallet. I say "lost" because they didn't even know they needed it! They
thought they had access because they saw their balance on etherchain. I
hate to design for the lowest common denominator but seeing people "lose"
thousands of ETH in this way is so freaking painful.
Anyone else feel free to chime in. We should be pushing an update ~Monday
and may include this.
—
Reply to this email directly or view it on GitHub
https://github.com/kvhnuke/etherwallet/issues/22#issuecomment-183153935.

@hawks5999 - This was implemented and pushed a couple days ago!

Thanks! It works great in the full page view.
I got it setup and working with an address.
Two bits of feedback.

As a nice-to-have feature, parsing and accepting addresses without the leading 0x.... might be helpful to others. For example, I have a json file with presale wallet and the address is expressed without the leading 0x (snip: "ethaddr": "2a59e4...."). I received invalid address errors a couple times trying to add the address before realizing my mistake. Yep, even with the help text in the address field.
The watch address doesn't show in the popup view from the extension button in the browser bar.

Thanks!


fix: when determine new submission, find just by confirmation id

Backend coverage reportCoverage after merging fix/check-new into dev will be3.66%
Coverage ReportFileStmtsBranchesFuncsLinesUncovered Linessrc   app.controller.ts100%100%100%100%   app.module.ts0%0%100%0%1, 14, 14, 16, 16–17, 17, 2, 28, 3–7   app.service.ts100%100%100%100%   main.ts0%0%0%0%1, 11–12, 14, 14, 14, 14–15, 2, 23, 25, 3, 31, 33, 33, 33–34, 36, 4, 43, 45, 5, 8src/email   email.module.ts0%100%100%0%1, 12, 2–4src/email/controllers   email.controller.ts0%100%0%0%1, 11, 13, 2–4, 8–9src/email/model   email.entity.ts0%100%100%0%1, 10, 16, 22, 28, 3, 34, 4src/email/services   email.service.ts0%0%0%0%1, 10, 102, 108, 13, 2, 20, 22, 22, 22, 22, 22–23, 26, 3, 34–35, 35, 35–36, 36, 36–37, 37, 37–38, 38, 38–39, 39, 39, 41, 41–42, 42, 42, 46, 53, 53–54, 6, 60, 62, 62–63, 63, 63–64, 87, 9, 90, 96src/form   form.module.ts0%100%100%0%1, 18, 2–7src/form/controllers   form.controller.ts0%100%0%0%1, 10–11, 2, 23, 25, 28, 30, 33, 37, 4, 44, 46, 6src/form/entities   emailSubmissionLog.entity.ts0%100%100%0%1, 16, 2, 23, 30, 33, 36, 39, 47, 5–6, 9src/form/services   form.service.ts0%0%0%0%1, 10, 100–101, 101–102, 102, 102–103, 106, 106, 106, 106–107, 113, 113–114, 116, 12, 120, 120–121, 121, 121, 125, 134, 138–140, 15, 150–151, 151–152, 157, 16, 162–164, 175–176, 178, 180–182, 190, 193, 193–194, 194, 194, 194, 194, 194, 194, 2, 20, 201–202, 21, 210, 214, 214–215, 215, 215, 215, 215, 215, 215, 215, 215, 215, 215, 227–229, 234, 236, 242–243, 25, 252, 26, 263, 263, 263, 263, 263–265, 268–269, 271, 279, 285, 298, 3, 304, 304, 304–305, 305, 305–306, 31, 311–312, 314, 317, 317, 317–319, 319, 32, 320, 320, 323, 325–326, 33, 334, 338–339, 34, 348–349, 35, 355, 364–365, 368, 375, 377, 38, 380, 387, 390, 398–399, 4, 40, 406–408, 41, 410, 415–416, 42, 421–422, 424, 43–44, 48, 5, 57, 6, 63, 71, 8, 80, 92–98

Backend coverage reportCoverage after merging fix/check-new into dev will be3.66%
Coverage ReportFileStmtsBranchesFuncsLinesUncovered Linessrc   app.controller.ts100%100%100%100%   app.module.ts0%0%100%0%1, 14, 14, 16, 16–17, 17, 2, 28, 3–7   app.service.ts100%100%100%100%   main.ts0%0%0%0%1, 11–12, 14, 14, 14, 14–15, 2, 23, 25, 3, 31, 33, 33, 33–34, 36, 4, 43, 45, 5, 8src/email   email.module.ts0%100%100%0%1, 12, 2–4src/email/controllers   email.controller.ts0%100%0%0%1, 11, 13, 2–4, 8–9src/email/model   email.entity.ts0%100%100%0%1, 10, 16, 22, 28, 3, 34, 4src/email/services   email.service.ts0%0%0%0%1, 10, 102, 108, 13, 2, 20, 22, 22, 22, 22, 22–23, 26, 3, 34–35, 35, 35–36, 36, 36–37, 37, 37–38, 38, 38–39, 39, 39, 41, 41–42, 42, 42, 46, 53, 53–54, 6, 60, 62, 62–63, 63, 63–64, 87, 9, 90, 96src/form   form.module.ts0%100%100%0%1, 18, 2–7src/form/controllers   form.controller.ts0%100%0%0%1, 10–11, 2, 23, 25, 28, 30, 33, 37, 4, 44, 46, 6src/form/entities   emailSubmissionLog.entity.ts0%100%100%0%1, 16, 2, 23, 30, 33, 36, 39, 47, 5–6, 9src/form/services   form.service.ts0%0%0%0%1, 10, 100–101, 101–102, 102, 102–103, 106, 106, 106, 106–107, 113, 113–114, 116, 12, 120, 120–121, 121, 121, 125, 134, 138–140, 15, 150–151, 151–152, 157, 16, 162–164, 175–176, 178, 180–182, 190, 193, 193–194, 194, 194, 194, 194, 194, 194, 2, 20, 201–202, 21, 210, 214, 214–215, 215, 215, 215, 215, 215, 215, 215, 215, 215, 215, 227–229, 234, 236, 242–243, 25, 252, 26, 263, 263, 263, 263, 263–265, 268–269, 271, 279, 285, 298, 3, 304, 304, 304–305, 305, 305–306, 31, 311–312, 314, 317, 317, 317–319, 319, 32, 320, 320, 323, 325–326, 33, 334, 338–339, 34, 348–349, 35, 355, 364–365, 368, 375, 377, 38, 380, 387, 390, 398–399, 4, 40, 406–408, 41, 410, 415–416, 42, 421–422, 424, 43–44, 48, 5, 57, 6, 63, 71, 8, 80, 92–98

DEV deployments have completed successfully!
Backend: https://nrog-101-backend.apps.silver.devops.gov.bc.ca/

DEV deployments have completed successfully!
Backend: https://nrog-101-backend.apps.silver.devops.gov.bc.ca/

Your Pull Request code is being promoted!  Please follow the link below.
Main Merge Workflow


need author access

I logged in, then I signed up for Power BI.
Then, it shows:

My bad, this worked out.
The trial started

But does that mean, after 60 days, I won't be able to access the dashboard?

Were you able to access the report after you got the trial?

Yes.

I am trying to work out how to publish it publicly.


Step status display

Individual steps in the runs list now display their status pass/fail/not run
To test login as limitedruns goto UAV sample set/Combind SW/Cycle 3/Swarming this profile should have some steps passed, failed, and not run yet.

Looks great! Hits all acceptance criteria, ready to merge when Travis is happy.


Crash when selecting multiple TextureFrames with SHIFT pressed on MAC OSX.

Maybe other node will crash too with SHIFT pressed. I just tried TextureFrame and HBoxContainer in my case.

make example scene that crashes please

This is the crash scene:
CrashScene.zip

@lizistorm
for me it works fine both on the beta from the site and my own godot build i compiled today.

@lizistorm  since you have osx could you test out this problem as well  https://github.com/godotengine/godot/issues/3552

@trollworkout I tried your problem, the SHIFT and CONTROL key not work.
Maybe this issue is the SHIFT key not trigger the SHIFT event.

@lizistorm  so they don't work for you either?

@trollworkout Yes I have the same problem as yours on OSX.

I think I have a similar problem but simply with 2 sprites (godot v2.0.beta.custom_build) I made a video here:
https://www.youtube.com/watch?v=vg_98ZKzfOQ&feature=youtu.be
If it helps I can submit the full stack trace if necessary.

More complete stack if it helps:
Thread 0 Crashed:: Dispatch queue: com.apple.main-thread 0   libsystem_kernel.dylib        	0x9074058a __pthread_kill + 10 1   libsystem_pthread.dylib       	0x92c45448 pthread_kill + 101 2   libsystem_c.dylib             	0x94c7dc34 abort + 156 3   libsystem_c.dylib             	0x94c46009 __assert_rtn + 393 4   libunwind.dylib               	0x91d62ebc _Unwind_Resume + 121 5   org.godotengine.godot         	0x0000cef1 InputDefault::parse_input_event(InputEvent const&) + 1201 6   org.godotengine.godot         	0x00002deb -[GodotContentView mouseDown:] + 363 7   com.apple.AppKit              	0x9a83a5b7 -[NSWindow _handleMouseDownEvent:isDelayedEvent:] + 6266 8   com.apple.AppKit              	0x9a83c0ea -[NSWindow _reallySendEvent:isDelayedEvent:] + 2303 9   com.apple.AppKit              	0x9a0df927 -[NSWindow sendEvent:] + 567 10  com.apple.AppKit              	0x9a0db942 -[NSApplication sendEvent:] + 2919 11  org.godotengine.godot         	0x000027d4 -[GodotApplication sendEvent:] + 148 12  org.godotengine.godot         	0x000069e8 OS_OSX::run() + 200 13  org.godotengine.godot         	0x0000848d main + 365 14  org.godotengine.godot         	0x000026f5 start + 53

This still does happen for me with the latest 2.0 version.
Weirdly enough when I compile the software by hand, the crash doesn't happen. Anything I can do to help?

Yes it still happens with 2.0 STABLE and will crash to click any node with SHIFT pressed.

Weirdly enough when I compile the software by hand, the crash doesn't happen.

Thanks, that's quite interesting. It might indicate that something is wrong due to the official binaries being cross-compiled from Linux with OSXCross.
Any idea @punto-?

Any updates? As far as I remember we aren't using OSXCross lately, but I might be wrong as well.

I don't think I understand the issue (but that's just because I wasn't around when Godot was in 2.0 beta): is the crash related to selecting multiple nodes (with Shift)?
If so, it doesn't crash on my end. Using 2.2-legacy.

Ok, closing then as fixed (somehow). If anyone runs into it again, we might reopen.


D365 table that contains metadata on D365 Export to Data Lake table list, status and errors

CDM Util relies on a Synapse event trigger to detect new manifest files when a table is activated. This in turn triggers a series of processes to populate a control table, generate the external views or tables associated with this table, etc.
Are there D365 tables that can be accessed or other methods that can:
(1) Show when a table was deactivated. The CDM Util code does not support this directly. It is also important to know when a table has been reinitialized, i.e, when it changes from running to deactivated to activated (running).
(2) Show a list of all running tables (activated tables). These are tables that have CDC enabled in D365.
(3) Capture error codes associated with the Export to Data lake process, for example, those arising from corrupted CSV files, or when new columns are added to an activated tables.
While the above is not strictly related to existing CDM Util code- any assistance in approach

The best way to solve this will be Business events preview feature that is in preview .. check the yammer thread for more details.
https://www.yammer.com/dynamicsaxfeedbackprograms/threads/1581288875966464


Extended routing functionality

Currently, route definitions look as follows:
{
    method: [ 'GET' ],
    path: '/api/v1/default/info',
    handler: 'DefaultController.info'
}

Which is a it cumbersome, especially if you need to define lots of routes. Would be nice to be able to have a more succinct syntax, perhaps something like so?
Router
   .post( '/user', UserCtl.create)
   .put( '/user', 	auth.isAuthenticated(), UserCtl.update)

Just an example, but you get my point I hope.
Also nested routes would be really nice, mostly for convenience, so stuff like this can be done:
{
    method: [ 'GET' ],                         // this here would/could be optional
    path: '/api/v1/default',
    handler: 'DefaultController.info'  // so would this guy

    subRoutes: [{
         method: [ 'GET' ],
         path: '/info',   // this then becomes /api/v1/default
         handler: 'DefaultController.info'
     }]
}

Also just an example, but I hope the general idea comes through.
That should be all, I'll add updates if anything else comes to mind
:)

This has nothing to do with docs ^^ it's a feature request, can you move the issue to trails repo please ?
Also having a Router object is not possible, or more something like:
Router
   .post( '/user', 'UserCtl.create')
   .put( '/user',   'auth.isAuthenticated', 'UserCtl.update')

Because middleware are in classes and need to be instantiate, Trails do it during launch process so you can't call them before.
Also this notation give less configuration possibilities:

how do you do GET and POST request ? you'll have to duplicate the router entry
how do you allow configuration per route like this for acl, or cors ect... you'll need to add another parameter to the router call and it will become unreadable with a lot of routes
how do you do sub routing like you want ?

At the end this notation is more complicated... I'll rather use the current notation :) but I'm 100% for the subrouting feature !
I'm closing this one please open a new one into trails repo and reference this issue for history. Thanks!


Add linters and GHA job to run them on PRs

Signed-off-by: Pavel Macík<EMAIL_ADDRESS>

Would it be worth adding something like shellcheck for the testing infrastructure we have?

Would it be worth adding something like shellcheck for the shell scripts we have?

Good suggestion, will take a look. Thx

Would it be worth adding something like shellcheck for the shell scripts we have?

@sadlerap I've included the shellcheck, PTAL

Looks like yamllint is trying to lint our github actions infrastructure (.github/workflows/pr-checks.yaml); is it possible to disable checking for this particular file? We're probably going to get more false positives than actual problems.

@sadlerap It can be disabled via this, however I'd like to have it checked as well as the other YAMLs. I don't see a reason why not to.
Anyway, I have tweaked yamllint configuration (to disable line-lenght check) as we usually ignore those kind of warnings. So with the current state it runs without errors and warnings.


Alternatives to the "-DConnectPluginsPath" command line arg

The problem with a command line arg is that the user has to launch tableau with it each time, instead of using the shortcut created by the installation.
We provide a batch script to simply this, which the user can shortcut, but it's a compromise.
Suggestion: if "-DConnectPluginsPath" is not specified, scan for plugins at "%USERPROFILE%\Documents\My Tableau Repository\Plugins" - standard tableau folder which does not require elevated permissions.

We are working on packaging and signing solutions that will allow a clean user experience for installing connector plugs with version 1.0 of the SDK.

The default path is not a bad idea but I think we want to keep loading connectors an explicit user action for the time being. The packaging work that Patrick mentioned will be a better long term solution for this and will be seamless and unobtrusive to the end user once the connector is installed.


Adjust excluded files section of _config.yml

A few minor tweaks to the _config.yml file to deal with which files are included/excluded in the _site build directory.
Exclude list:

Add package.json and package-lock.json, NPM configuration files.
Add screenshot.png, which is only referenced by the already-excluded
README.md.

Remove the keep_files section of the configuration. It's purpose is to
list files that should not be clobbered when the _site directory is
being rebuilt. It currently only contains README.md, and this file
is already explicitly excluded from the build by the exclude section, so
this configuration directive has no effect.
This PR also updates Gemfile.lock to the latest version of the github-pages gem (which is in-sync with the version used in production by GitHub).

Thanks!


[BugFix][Cherry-pick] Fix column case sensitive bug for mv view delta join rewrite for 2.5  (#19639)

fix column case sensitive bug for mv view delta join rewrite

What type of PR is this：

[ ] BugFix
[ ] Feature
[ ] Enhancement
[ ] Refactor
[ ] UT
[ ] Doc
[ ] Tool

Which issues of this PR fixes ：

Fixes #19617
Problem Summary(Required) ：

Fix column case sensitive bug for mv view delta join rewrite
Checklist:

[ ] I have added test cases for my bug fix or my new feature
[ ] This pr will affect users' behaviors
[ ] This pr needs user documentation (for new or modified features or behaviors)

[ ] I have added documentation for my new feature or new function

Bugfix cherry-pick branch check:

[ ] I have checked the version labels which the pr will be auto backported to target branch

[ ] 3.0
[ ] 2.5
[ ] 2.4
[ ] 2.3

run all

run starrocks_fe_unittest


UWP app with MahApps.Metro.IconPacks crash at startup

Describe the bug
When building an UWP application in release mode targeting x64, the application crashes due to a StackOverflow exception. The debugger in Visual Studio just hangs for me but I managed to find the exception via WinDbg.
(37d0.1da8): Stack overflow - code c00000fd (first chance)
First chance exceptions are reported before any exception handling.
This exception may be expected and handled.
App2!$9_MahApps::Metro::IconPacks::MahApps_Metro_IconPacks_XamlTypeInfo::XamlTypeInfoProvider.CreateXamlType+0x2:

To Reproduce

Create a new UWP project targeting min version 10.0.17763.0
Add a reference to version 3.0.0-alpha0169 of MahApps.Metro.IconPacks (newer versions makes the project uncompilable for some reason)
Change configuration to Release and architecture to X64
Run the project

Expected behavior
The window should show some icons.
Desktop Environment (please complete the following information):

IconPacks Version: 3.0.0-alpha0169
Visual Studio: 2019 16.1.3

Additional context
The application runs as expected under Release|x86  and correctly for all architectures when building the Debug configuration.

@patriksvensson I tried this again with 3.0.0-alpha0212 and can not reproduce this. So I'll close this for now. Feel free to re-open this or create a new issue if you still get this error.

@punker76 Hmm, I thought I reported back that 3.0.0-alpha0200 works as expected both with x86 and x64 but I seem to have forgotten to do that for some reason... Sorry about that. This can absolutely be closed!