Allow optional generation of AKS Azure Active Directory Pod ID Bindings

Azure Active Directry Managed Identities, while a new feature, alleviates many from the burden of dealing with secrets (for the price of a SPOF?).
It is becoming a security standard in many organizations. In the one I belong to, we've been using a custom version of tye to comply with this regulation.
In AKS, Azure's managed Kubernetes offering, enabling this feature involves the steps documented there aadpodidbing
This pull requests allows to control the generation of the necessary labels directly using two documented settings.
At the project level:
aksGenerateAadPodIdBindings (boolean)
AKS specific. Using Managed Identities requires the generation labels for aadpodidbing.
When set to true these labels will be generated by convention, unless overriden at the project or ingress level.
The convention is:
$"{application.Name}-{project.Name}-service"; // for services
$"{application.Name}-{ingress.Name}-ingress"; // for ingresses
At the service or ingress levels
aksPodIdentityName (string)
An optional name of pod identity to use for the service when generating the aadpodidbinding label.

This PR would resolve #1051

@Hylaean Thanks for the submission!  While I can see the benefit in having integration with AKS and AAD Pod Identity, I'm a bit reluctant to fold something so coupled to a vendor specific target platform into the general Tye configuration schema.
My initial thought is that this feature would be better done as a Tye extension (like Dapr), which, when configured, adds the labels to the ingress- and project-service-builders, which are then copied over into the Kubernetes manifests by the existing manifest generator step.  The ProjectServiceBuilder already has a ManifestInfo property where annotations/labels could be added by an extension (which will then find their way into the YAML).  That could be brought over to IngressBuilder, so the extension could do the same for those.

Hi @philliphoff , thanks for the tip, I hadn't thought of that, although I had the same reticence regarding design impact, it was basically a small cleanup of an internal hack, I'll try to do it in the suggested way when I "find time".

+1 @philliphoff This seems a little azure specific, not sure this belongs in tye.


fix: tailwind clarity in readme

fixes #15
except for this line:

make sure usage guide includes best practices for custom css, new components, and updates to the design system

@joshuagraber I'm fine to consider that issue closed, but if you want to add anything, go for it!

Looks good to me  @josh-chamberlain I don't think I have anything at the moment.


BigTextStyle for notification

I have added the bigTextStyle to Android notification. Now we can read long messages.

Has anyone verified this change? I make the indicated changes to GCMIntentService.java and get a notification with an empty message.


Add Faker::Internet.uuid

UUIDs are incredibly common. Many databases, APIs, etc will use them to identify resources. Being able to generate these easily is paramount to having a productive development environment.
So, why not just use SecureRandom.uuid?
The beauty of faker is that is can be used to generate deterministic sequences of numbers in a non-deterministic world. This makes debugging much easier, as we have one less thing to reason about.
This patch uses fakers PRNG to build a UUID, which solves this problem.
supersedes https://github.com/stympy/faker/pull/943

:confetti_ball:


Users can comment on tasks

/api/tasks/[taskID]/comment

POST to create a new comment thread on a task with body of shape { text: string }

Error if the task already has a root comment
In a transaction, create the comment thread and initial comment and add the comment thread id to the task in the DB.
Return the comment thread id with the task on the task API where it exists or null otherwise.

Complete


Fix crashes due to auto-type in Python

These two commits do fix crashes caused by auto-type feature in Python. We expect instance of one type, however Python automatically creates instance of int/str which doesn't have or isn't capable of wanted operations.

Sorry, I have to agree with @drawks here. If there's a problem with https://github.com/graphite-project/carbon/blob/megacarbon/bin/ceres-maintenance we should try to fix it at the source. Note that Ceres support has not yet been merged over to master from the megacarbon branch yet. /cc @mleinart

Absolutely the right call.


Loosen rake, rubocop versions

Closes: n/a
Goal
Loosen Gemfile requirements (which are for dev purposes only since .gemspec governs production).
Approach

Pessimistically require current major versions for rake and rubocop.
Unrelated: Remove redundant Buy Me a Coffee link (since the Sponsor button consolidates all available options).

Signed-off-by: Roderick Monje<EMAIL_ADDRESS>

Merging without review as changes are trivial.


visualizing affinity map between a seed token and other patch features

Hi, I find a beautiful heatmap visualization in the fig. 4 of the paper, the affinity map between a selected seed token and other patch features. Could you please provide the code for visualizing affinity map？

Hi, thanks for your interest! please take a look at: https://github.com/wysoczanska/clip_dinoiser/issues/9

Hi, thanks for your interest! please take a look at: #9

Thank you! I successfully generate the visualized affinity map.

Closing the issue then :)


release a 0.7.0

Heyho,
I think there was no release since the last PR, i would propose a 0.7.0 as there are incompatibilities with 0.6.1 and it could break users code otherwise :)
best regards,
xMAC94x

done


ADDED LOGO/IMAGE

BEAUTIFUL LOGO FOR YOUR WEBSITE

Issue Title:
resolve issue: #81
Type of change ☑
ADDED A LOGO FOR WEBSITE
What sort of change have you made:

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Code style update (formatting, local variables)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

Checklist: ☑

[ ✅] My code follows the guidelines of this project.
[ ✅] I have performed a self-review of my own code.
[ ] I have commented my code, particularly wherever it was hard to understand.
[ ] I have made corresponding changes to the documentation.
[ ] My changes generate no new warnings.
[✅ ] I have added things that prove my fix is effective or that my feature works.
[ ] Any dependent changes have been merged and published in downstream modules.

How Has This Been Tested? ⚙
Describe how have you verified the changes made.

Sir, Due to some issue, I was not able to add logo ,but createad one
I have added source code for logo in your file,
Sorry for trouble , but if you think ,this is up to satisfaction, Please consider it

Also  great thanks for assigning me this issue.

@Nih1tGupta I appreciate your efforts, but if the logo will be simple then It will be much more attractive as our applications theme is simple and clean.

Link:
https://i.im.ge/2024/05/15/KM2Q4a.Logosimple.png

@Nih1tGupta The logo is not looking appealing and cleaning.
& also resolve conflicts of your PR.

@Nih1tGupta It's been 2 days since you haven't replied, So I'm closing the PR. Thanks for your efforts to contribute.


fix: remove duplicated types

from: https://github.com/t3-oss/create-t3-app/pull/133#issuecomment-1177332751

Done @MWhite-22 ! Thanks for the feedback

Is it just me who get a bunch of type-errors?

Maybe instead of running build --onsuccess tsc or tsc on pre_commit, we can do it on pre-push? is that possible?

Still the problem of getting stuff onto GitHub to share if they aren't 100% ready, but again that might just be me doing that?

Makes sense to do it on CI. Let's remove it from husky. Typescript can become an issue if you're doing some experimental work and you want to commit your stuff

would you be open to resubmitting the pr so we can test the CI?

Done! All green

perfect 👍🏼


⚠ Bofrost.at has degraded performance

In a205516, Bofrost.at (https://www.bofrost.at) experienced degraded performance:

HTTP code: 200
Response time: 1294 ms

Resolved: Bofrost.at performance has improved in 99e19ae.


Platform/jvm

Add support for the Admin SDK on a pure JVM platform. The Firestore and Realtime Database modules map very well between the client and admin SDK, so I have added them in this PR. The other modules do not map as well, so a different solution may be better to handle those. I attempted to minimize changes to the common code as much as possible, but had to do a minor refactor on the FirebaseOptions definition to support both mobile and admin. Please let me know if any changes should be made or if this would be better as a separate library.

As of now, the Admin SDK has less support for emulators than the client SDKs, so I have set it up using a real Firebase Project. The credentials would have to be replaced in order to set up tests with a different Firebase Project

Hi @LandryNorris thanks for this PR! After looking through the code I believe it would be best to put this into a separate module, we could use dev.gitlive.firebase-admin
Reasoning for this is:

A major goal for this library is to provide a single API for firebase that can be consumed directly from common code in a kotlin multiplatform project. A single project is likely to either be clientside (mobile/desktop/web app) or serverside not both.
If you expanded the support to the node firebase admin sdk, you would have a clash between jt targets
Adding it to the existing modules is a breaking change and extra api noise for client library consumers

I see value in adding a seperate firebase-admin module with targets for jvm and node as serverside kotlin depending on firebase-admin could more easily shared by java and node environments (although somewhat less valuable than client side multiplatform)

I can see the lack of value in sharing the code on the server side. The primary thing I'm looking for is the serialization and coroutine integrations y'all have added, which makes coding for firebase faster. I can switch the design to use modules for admin (perhaps a firebase-admin, firebase-admin-database, firebase-admin-firestore or something similar?) unless making it a separate project would be a better way to do that, leaving this codebase for client side.

@LandryNorris Can this PR be used for jvm targets in a multiplatform project? We're after supporting android, iOS web and (JVM) desktop variants, this looks like it can help?

In theory, yes, but it uses the admin SDK under the hood, since there's no non-Android client SDK for jvm as far as I can tell, so I personally wouldn't use it for a desktop app available to the public, but if that's OK or if this app is for internal use, desktop jvm should work just fine.

Actually it uses a pure JVM port of the Android SDK which we haven't open sourced yet as it's got some rough edges

is there any info on this?


Tweak / fix deploy instructions

https://www.pivotaltracker.com/story/show/180900091
The original cherry-pick commit for manually testing changes no
longer works, so this updates it to a fresh version.
I also think it's worth includes the Hackney sample PDF for visual
checks as it's one of the few representative PDFs we have.
👉 Rendered version
👉 Rendered version (new visual testing doc)

Is 4-5 a good time?

Usually it's quieter, but not by much (looking at some recent stats). I'm up for removing it and agree the longer time to sort any immediate issues is an advantage over a slightly reduced average impact.
I've added a commit to relax this: https://github.com/alphagov/notifications-template-preview/pull/633/commits/dab335bc93a18be598dd33172b45e27c159b2815

Do we want to encourage branch deploy, vs merging but being prepared to pin/roll back via concourse?

The complication here is the multi-day lag between doing a trial deployments and getting feedback from DVLA. If we merge as part of doing a trial deployment, then we'll be blocking deployments for quite a while.
I can't think of any good options here:

Stop doing trial deployments. If https://github.com/alphagov/notifications-template-preview/pull/632 doesn't show up any issues, then I'm increasingly tempted by this one based. We have a recovery process, after all.

Do high volume, representative load testing in Staging to emulate the trials in Production. This would involve analysing our Production PDFs in more detail to figure out what a good sample looks like.

Possible actions:

Remove (or largely cut) this guidance if the redaction trial has no issues.

As promised, I've added a further commit to relax the guidance further: https://github.com/alphagov/notifications-template-preview/pull/633/commits/4038f9c0cd457d26147a1419815b1614f3b153c3
I think the question is now: do we want to make it entirely optional? I still think that would be unwise, given that we've no good way of doing E2E testing for this app, other than what the guidance says. If we did this card, then I think we'd have a viable E2E testing strategy (albeit still a manual one) and removing these requirements would be safe.


[CWS] groundwork of removing SYSCALL_KPROBE[^0] where possible

What does this PR do?
The goal of this PR is to ease the possible transition to fentry/fexit hook types instead of kprobes (on supported kernels). We hit some issues trying to query the args syscalls when in fentry hooks and when the syscall wrapper is enabled.
One easy solution to help with this is to move some hook points to non-syscall functions, this is what this PR is doing.
TODO (priority):

[x] chmod (0)
[x] chown (0)
[ ] execve (0)
[ ] creat/openat2 (0)
[ ] unlinkat (0)
[ ] setxattr (0)
[ ] bind (1)
[ ] bpf (1)
[ ] mkdir (1)
[ ] delete_module (1)
[ ] unshare (1)
[ ] ptrace (1)
[ ] kill (1)

Motivation

Additional Notes

Possible Drawbacks / Trade-offs

Describe how to test/QA your changes

Reviewer's Checklist

[ ] If known, an appropriate milestone has been selected; otherwise the Triage milestone is set.
[ ] Use the major_change label if your change either has a major impact on the code base, is impacting multiple teams or is changing important well-established internals of the Agent. This label will be use during QA to make sure each team pay extra attention to the changed behavior. For any customer facing change use a releasenote.
[ ] A release note has been added or the changelog/no-changelog label has been applied.
[ ] Changed code has automated tests for its functionality.
[ ] Adequate QA/testing plan information is provided if the qa/skip-qa label is not applied.
[ ] At least one team/.. label has been applied, indicating the team(s) that should QA this change.
[ ] If applicable, docs team has been notified or an issue has been opened on the documentation repo.
[ ] If applicable, the need-change/operator and need-change/helm labels have been applied.
[ ] If applicable, the k8s/<min-version> label, indicating the lowest Kubernetes version compatible with this feature.
[ ] If applicable, the config template has been updated.


Fix JAVA_HOME discovery on OS X

The path structure on OS X JDKs is :hankey:

Have you tried using /usr/libexec/java_home -v ${version} with version equal to 1.7 or 1.8 or 9 to get the clean path to the JDK home?

@jasontedor That's one way, yes, but then it's tied to OS X.  We do some more introspection that's platform-independent we can reuse here.


aligned navbar elements

I edited the header to be responsive addressing this issue #197 . Attached is the new header

With that long menu item "Cloud Native Sustainability Week" and reduced margins, it's hard to tell the difference between one menu item and the next. Is there any way you could reduce the length of that menu item and keep the original styles? Otherwise I think we need to adjust the styles so that we keep the spacing between items. Here it is on mobile for example:

Incidentally I've just been making similar changes to the Contribute site to accommodate more menu items and a longer menu. You can see the changes in this PR.

Thanks for the suggestions, however, I just needed to copy over styles from the Contribute site and fixed the header in this PR.


Add hooks via pre-commit

https://pre-commit.com
mypy and black will now be run automatically before contributors can commit their changes. This should reduce issues where PRs have type issues and bad formatting.

one more question - is there a version of this that is pre-push? if we're going to squash and merge, then i'd like to allow folks to do interim commits that don't necessarily pass mypy


Update for AlphaWallet; update pickup URL and icon

Description

Checklist

[ ] The version field in package.json is incremented following semantic versioning
[ ] The box that allows repo maintainers to update this PR is checked
[ ] I tested locally to make sure this feature/fix works
[ ] This PR passes the Circle CI checks

@JamesSmartCell Thanks for your contribution! Could you provide some additional context for this change?

@JamesSmartCell Thanks for your contribution! Could you provide some additional context for this change?

James is travelling for a bit. Not sure if he would respond timely during then. But there 2 reasons:

Our app icon has changed (a lot)
The deep-link to trigger AlphaWallet was wrong

(we both work on AlphaWallet)


Settlement Report Dates

Bug Fixes

Correcting settlement dates

Delivers #134259557

@EvanBarbour3 can you please check these fixes are urgent


Support "EmailId" message property name

Added support for the EmailId MessagePropertyName.
This resolves issue  #285 where an error is thrown when deploying an image for a plugin step registered against the Send, DeliverIncoming or DeliverPromote messages.

Excellent - I'll get this in the next beta.

This is released as https://www.nuget.org/packages/spkl/1.0.370


Dose TensorFlow has tf.sparse.segment_max? how to code it by customer?

Please make sure that this is a feature request. As per our GitHub Policy, we only address code/doc bugs, performance issues, feature requests and build/installation issues on GitHub. tag:feature_template
System information

TensorFlow version (you are using):
Are you willing to contribute it (Yes/No):

Describe the feature and the current behavior/state.
Will this change the current api? How?
Who will benefit with this feature?
Any Other info.

@wangshang19911011
Please provide details about what platform you are using (operating system, architecture). Also include your TensorFlow version. Also, did you compile from source or install a binary?
please share simple stand alone code for us to replicate the issue.
Make sure you also include the exact command if possible to produce the output included in your test case. If you are unclear what to include see the issue template displayed in the Github new issue template.
We ask for this in the issue submission template, because it is really difficult to help without that information. Thanks!

@wangshang19911011
i looked up for "tf.sparse.segment_max" in tensorflow website and do not find anything related to this, there is no such module in case you are looking to use it. tf.math.segment_max is present.

@wangshang19911011
please update on the above comment

@Saduf2019 Thanks for reply. I'm working with sparse input, tf.math.segment_max is not so good with sparse input. I tried code  tf.math.segment_max by myself, but it is too hard. Hope tensorflow will has this module.

Is this feature going to be supported?

Hi,
Thank you for opening this issue. Since this issue has been open for a long time, the code/debug information for this issue may not be relevant with the current state of the code base.
The Tensorflow team is constantly improving the framework by fixing bugs and adding new features. We suggest you try the latest TensorFlow version with the latest compatible hardware configuration which could potentially resolve the issue. If you are still facing the issue, please create a new GitHub issue with your latest findings, with all the debugging information which could help us investigate.
Please follow the release notes to stay up to date with the latest developments which are happening in the Tensorflow space.


feat: add @shapeshiftoss/logger/no-native-console rule

Description

Notice

[ ] Have you followed the guidelines in our Contributing guide?
[ ] Have you checked to ensure there aren't other open Pull Requests for the same update/change?

Pull Request Type

[ ] :bug: Bug fix (Non-breaking Change: Fixes an issue)
[ ] :hammer_and_wrench: Chore (Non-breaking Change: Doc updates, pkg upgrades, typos, etc..)
[ ] :nail_care: New Feature (Breaking/Non-breaking Change)

Issue (if applicable)

closes #
Risk

Testing

Engineering

Operations

Screenshots (if applicable)

Current dependencies on/for this PR:

develop

PR #2453

PR #2448
PR #2574   👈

This comment was auto-generated by Graphite.

TODO once package is published:
-"@shapeshiftoss/eslint-plugin-logger": "../shapeshiftLib/packages/eslint-plugin-logger",
+"@shapeshiftoss/eslint-plugin-logger": "^1.0.0",


Update CI.yml

@yramachers Small incremental change towards better CI. Code now runs and verifies the resulting code can be read. No checking on correctness yet.

Closing this as these changes will be incorporated into another PR.


Property "shortName" is missing on types for Event and Effect

I wanted to provide a pull request for this, but I couldn't make heads or tails of where your types are defined (or generated).
Code to reproduce the issue:
const RootDomain = createDomain("my-application")

RootDomain.onCreateEvent(event => {
  console.log(event.shortName)
})

RootDomain.onCreateEffect(effect => {
  console.log(effect.shortName)
})

Expected behavior:
It should work without errors.
Actual behavior:

Property 'shortName' does not exist on type 'Event'.ts(2339)

Property 'shortName' does not exist on type 'Effect<unknown, unknown, unknown>'.ts(2339)

Versions of packages used:
<EMAIL_ADDRESS>

https://github.com/zerobias/effector/tree/master/packages/effector

Fix is ready and will be published in version 20.1.2


Updated getHex, getColor, onClick, onRel function in main.py

i have add all algorithm needed according to the guide,
and i hope you can give feedback to me about my code.
and please give label hacktoberfest-accepted if accepted, Thank you!.

i have follow your instructions in "getting started" section at "readme.md", but i can't do the 5th steps that is "git push origin my-amazing-feature" the git says "remote: Permission to IEEE-VIT/spectra.git denied to zkazharan.
fatal: unable to access 'https://github.com/IEEE-VIT/spectra.git/': The requested URL returned error: 403" so i commit the new branch from github. do you think what i did was right?

Hey, thanks for showing interest in contributing. You will need to fork the repository, and then make the changes you want to add.


Expose MemoryLocation (and BrowserLocation too) again

In b32bc00 MemoryLocation and HistoryLocation (later renamed to BrowserLocation which I like that rename) were no longer exposed. In tests for my app, I would setup the location before hand. I can still do that by passing in the initial location, but before it was the same API to change location before and after the app started, now it's different, rather than being the same API. I ended up creating a dummy object like this:
  var startLocation
  scenario.location = {
    setURL: function(l) {
      startLocation = l
    },
    getURL: function() {
      return startLocation
    }
  }

  //  .... various config from tests, often by a setup function callback

  // start new instance of app and get it's router
  var app = Scenario.app()
  scenario.router = app.router

  // app normally calls `listen` but not under test
  scenario.router.listen(startLocation)
  // replace dummy location with real MemoryLocation
  scenario.location = app.router.location

Also it's nice to have these exposed to let people extend them for any reason.
Another option is have router.location available right away and not just after listen()

Do these help?
a) You can change location before calling listen by changing the value of router.options.location: https://github.com/QubitProducts/cherrytree/blob/2dd94635811fb95c2a5ae904729657f2dd33dc3b/tests/unit/routerTest.js#L140. I guess this is not very obvious as well as undocumented. But you could always have a function that creates a router createRouter({location}) for your tests.
b) You can still require in base location implementations via require('cherrytree/locations/browser') and require('cherrytree/locations/memory') if you want to customize.

a) That helps a bit, but It's still a different API
b) That only works if you're using Harmony modules
I'm not suggesting to change the initialization of cherrytree, just have cherrytree.MemoryLocation available.

I guess if you're using the standalone build, those are no longer exposed. Yeah, we could readd the cherrytree.MemoryLocation and cherrytree.BrowserLocation.
Regarding your first issue, I'm not fully following what that code snippet is demonstrating and why the API change made it worse for you? Could you show me a before/after example?
The reasoning for the API change was to make all options be passed to the cherrytree constructor function as well as making switching between 'memory' and 'browser' locations easier via an option to the constructor. And yeah, it's a breaking change, but one I wanted to add in before 2.0.0.

Previous code
scenario.location = new Scenario.cherrytree.MemoryLocation()

// start new instance of app and get it's router
  var app = Scenario.app()
  scenario.router = app.router

// configure code calls location.setURL() as normal.
scenario.router.listen(scenario.location)

Moreover I had sugar helper methods around setURL like goToFooPage. Those methods can called before and after test setup, and rather spread alot of if blocks around I just made a dummy wrapper like I had before. Pretty ugly.

I've address the cherrytree.MemoryLocation issue in #120.
Regarding the other issue however, my current thinking is now that it just so happens in your tests that location is the only thing you want to change in your tests after calling Scenario.app(), but really it's only 1 of several options to the router. What if you wanted to change or stub the behaviour of qs, logger or interceptLinks options, for example. In that case you would have to refactor how the tests are done anyway.
tl;dr - location is just one of several options to the router, I made this change (moving location to options) to make all options consistent.
Could something like this not work for your tests:
scenario.location = new Scenario.cherrytree.MemoryLocation()

var app = Scenario.app({
  router: {
    location: scenario.location
  }
})
scenario.router = app.router

Or if those are done in different parts of the test:
scenario.location = new Scenario.cherrytree.MemoryLocation()

var app = Scenario.app()

// sets scenario.router and also sets up app.router
scenario.router = app.initRouter({location: scenario.location })

Closing now as this has been partially addressed. The .listen() issue is a bit more contentious, but I do think making listen a method that just starts the routing makes for an overall simpler design..

Exposing the two location classes fully addresses this for me (IIRC, its been a bit). I dont think i wa arguing for a change to listen... I can set the location before hand. Location changing is not an option of cherrytree - its a fundamental property of the browser. (I take a black box approach to testing, mocking only inputs to the whole as much as possible, which is just mainly browser location and ajax responses)


[348] Refactoring Map component + using Mapbox markers

This PR refactors the Map component to start using Mapbox markers rather than HTML markers.
This should help the map load more performant.
Instead of adding a new DOM element for every marker, we add all the points as a data source and a layer on top of the Mapbox map.
All other changes are needed to re-bind existing events on to the new Mapbox markers. For Popups, I created a new JSX component that encapsulates its markup. There are a few changes here to how popups close and open, but I'm now keeping track of what active popup is open in the component state. Then I use that information for displaying or closing popups, since we only display 1 active popup at a time.
Since we programatically close pop ups now when we open a new one, I created a new custom click handler for a custom close button on the popups. (There was no way to attach directly to just the close button of the popup, in React without refs. This seemed the best/cleanest solution). When closing a popup through the close button (as opposed to being closed since you clicked on a new one), we'll clear out all the filtered stories.
To test these changes:

Pull my branch down
Visit the Story map
Click around on Points, Stories, etc. everything should be working the same as it was before!

@mirandawang i thiiink this would work for offline mode, but did you confirm this?
would be my only concern with a mapbox marker

I can now confirm this works perfectly with offline mode.


Feature 5312 - Adds directions for .py code completion in Pycharm and Rider

Description

IDEs should be able to provide programming assistance in python development. This adds directions to the .idea/readme.md file on how to set up code-completion for local development using JetBrains IDEs.
Related Issue

Closes #5312
Motivation and Context

Whereas stub generators do exist (https://pypi.org/project/quantconnect-stubs/) and it used to be the case that because the stubs were kept in the source, JetBrains IDEs were able to incorporate them into automatic completion, the separation of the stubs into their own project makes incorporation of them a non-automatic affair.
Requires Documentation Change

no
Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] Refactor (non-breaking change which improves implementation)
[ ] Performance (non-breaking change which improves performance. Please add associated performance test and results)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ x] Non-functional change (xml comments/documentation/etc)

Checklist:

[ x] My code follows the code style of this project.
[ x] I have read the CONTRIBUTING document.
[ x] I have added tests to cover my changes.
[ x] All new and existing tests passed.
[ ] My branch follows the naming convention bug-<issue#>-<description> or feature-<issue#>-<description>

Closing for now based on previous comments 👍


[HUDI-7201] Schema Evolution: use target schema if source is empty

Change Logs
If the incoming df is empty, the commit schema will be empty. Now, it will be the current table schema.
Impact
Currently if a user does an empty commit, we won't be able to detect invalid schema evolution in the next commit
Risk level (write none, low medium or high below)
low
Documentation Update
N/A
Contributor's checklist

[ ] Read through contributor's guide
[ ] Change Logs and Impact were stated clearly
[ ] Adequate tests were added if applicable
[ ] CI passed

@nsivabalan @danny0405
Seeing that there are still 34 issues to be fixed in release 0.14.1, we are very looking forward to it.
We hope it can be speeded up. We also hope to switch the prod business to version 0.14.1 as soon as possible.
It is best to be done before the year end. Version 0.14.1 should be the best and most complete version ever.
I am also looking forward to the official version 1.0. thanks everyone.


Multiregion is not supported

When try to install two cluster with the same name in different region, I got an error about resources that already exist.
{"@level":"error","@message":"Error: Error creating IAM User eks-barebone-bootstrap: EntityAlreadyExists: User with name eks-barebone-bootstrap already exists.\n\tstatus code: 409, request id: 37b52aa1-a837-445a-acda-a683d7f65070","@module":"terraform.ui","@timestamp":"2023-02-15T15:58:24.356264+01:00","diagnostic":{"severity":"error","summary":"Error creating IAM User eks-barebone-bootstrap: EntityAlreadyExists: User with name eks-barebone-bootstrap already exists.\n\tstatus code: 409, request id: 37b52aa1-a837-445a-acda-a683d7f65070","detail":"","address":"module.vpc-and-vpn.aws_iam_user.furyagent","range":{"filename":".terraform/modules/vpc-and-vpn/modules/vpc-and-vpn/vpn.tf","start":{"line":123,"column":37,"byte":3669},"end":{"line":123,"column":38,"byte":3670}},"snippet":{"context":"resource \"aws_iam_user\" \"furyagent\"","code":"resource \"aws_iam_user\" \"furyagent\" {","start_line":123,"highlight_start_offset":36,"highlight_end_offset":37,"values":[]}},"type":"diagnostic"}
{"@level":"error","@message":"Error: error creating IAM policy eks-barebone-bootstrap: EntityAlreadyExists: A policy called eks-barebone-bootstrap already exists. Duplicate names are not allowed.\n\tstatus code: 409, request id: 3bf901a6-5829-4f9a-845d-1fca44b2cc7c","@module":"terraform.ui","@timestamp":"2023-02-15T15:58:24.364677+01:00","diagnostic":{"severity":"error","summary":"error creating IAM policy eks-barebone-bootstrap: EntityAlreadyExists: A policy called eks-barebone-bootstrap already exists. Duplicate names are not allowed.\n\tstatus code: 409, request id: 3bf901a6-5829-4f9a-845d-1fca44b2cc7c","detail":"","address":"module.vpc-and-vpn.aws_iam_policy.furyagent","range":{"filename":".terraform/modules/vpc-and-vpn/modules/vpc-and-vpn/vpn.tf","start":{"line":140,"column":39,"byte":4043},"end":{"line":140,"column":40,"byte":4044}},"snippet":{"context":"resource \"aws_iam_policy\" \"furyagent\"","code":"resource \"aws_iam_policy\" \"furyagent\" {","start_line":140,"highlight_start_offset":38,"highlight_end_offset":39,"values":[]}},"type":"diagnostic"}

Additional information:
Some resources are at account level and the naming convention uses the cluster name + some ide. but it does not consider the case of two clusters with the same name in different regions, colliding the resource names. The naming convention should consider this and add some uniqueness to the name.


RPP Glitch Tensor on HOST and HIP

Add glitch tensor implementation

@HazarathKumarM Where are we on this? Pls resolve conflicts and mention which comments are done. @sampath1117 Do we need to talk on this?

@HazarathKumarM Where are we on this? Pls resolve conflicts and mention which comments are done. @sampath1117 Do we need to talk on this?

I Need to resolve the conflicts in this branch and need to the clean up. I will complete it today

I have addressed all the review comments and updated the branch with the latest changes from the develop branch. Could you please review the latest changes.

@HazarathKumarM I have updated my glitch branch to be in sync with master after today's merge.
There are 144 files changed currently showing in this PR.
Could you do a git pull upstream master on yours too so only the files you touched in this PR are showing as changed?

@HazarathKumarM I have updated my glitch branch to be in sync with master after today's merge. There are 144 files changed currently showing in this PR. Could you do a git pull upstream master on yours too so only the files you touched in this PR are showing as changed?
Done

@HazarathKumarM or @sampath1117 Please comment something on all comments above if they have been addressed or cannot address, or if they were fixed with algorithm change.
I have added a reply-comment on some that are not yet changed that came up under files changed.

Pls resolve merge conflicts against develop.

@sampath1117 @HazarathKumarM ToT merge needed. Please put this in a reviewable state


Use correct branch name in json schema ids

The $id fields in all JSON schemas were wrongly referring to a non-existent master branch. This isn't too bad because GitHub has some magic to fall back to the default branch when non-existent master branches are requested, but it is still incorrect. Fix it.

@microsoft-github-policy-service agree

Thanks!


Create a description of the project

and how to start learning it.

@simonaho isn't the current README enough? Is there something else that need to be written?

For most people not :-)
Some UML and file description can be helpful for people with less experience.


Not injecting our api keys into the chains' RPCs when using the SDK + Wallets packages directly.

In react-core we do inject the api key: https://github.com/thirdweb-dev/js/commit/e2ea5a716fe686c76e833048e6fb1125e2dc5f61#diff-d3dcbbb591129ef12e6c5e21da[…]04f223658c36163e6f06d36ddfcR121.
Solutions for this:
At wallet construction, when all the chains are passed we need to overwrite the chains rpcs by calling getChainRPC : https://github.com/thirdweb-dev/js/blob/2221f97ddc997d864db3a5f00e82862ece574922/packages/chains/src/utils.ts#L95, which injects the correct api key
OR
Call getChainRPC to inject the api key at connection/switching chains time if possible

Ditto seeing same issue

This has been fixed in latest version. You can now pass clientId to Wallet to inject apiKeys in chains


Record batch access from table instances - probably typo

It looks like both the record_batch and record_batches methods on Table are gated behind the 'recordBatch' feature (as opposed to 'record_batch') - that's a typo, right?

I also had to prepend crate:: to the 4 references to RecordBatch, similar to the schema method.

Yeah, that's a typo. Are you able to make a quick pr fix?

Yup, easy

Closed by #93


CLI Validate Build Files

Run validation over all build files (schema, wasm modules, manifest).

This is being handled by:

Schema Validation
Manifest Validation
WASM Build File Validation


a gap between conctrol pane and content pane

a gap between conctrol pane and content pane, how to remove it

?

@qiuchsh https://magpcss.org/ceforum/viewtopic.php?f=17&t=18972&sid=84361f84b1a55cca9d96cd785286b1d8 ;)


HIVE Connector - Execution Time Too Long.

Affected module
Ingestion - HIVE
Describe the bug
HIVE repositories with a great number of schemas an entities (views/tables) metadata ingestion time exceeds afordable time.
To Reproduce
HIVE metastore with 9000 schemas filtered by regex to retrieve metadata of only 450 and 8000 views/tables schemas from total: 19 hrs first exec., 24+ second
Screenshots or steps to reproduce

Expected behavior
A clear and concise description of what you expected to happen.
Version:

OS: REHEL
Python version: 3.8
OpenMetadata version: 1.0.1
OpenMetadata Ingestion package version: 1.0.1

Additional context
Add any other context about the problem here.

@jromandv some data that would help us evaluate this:

Number of ingested tables in total
Time that it takes to execute a DESCRIBE FORMATTED for a few of these tables

Also, do you have this Hive instance connected to an external Hive Metastore we could try to use?
Thanks

hi @jromandv we'll need this information to evaluate this further. Thanks

Hi, @TeddyCr
DESCRIBE FORMATTED query against a few tables and views and SHOW CREATE TABLE {viewName}.
https://openmetadata.slack.com/archives/C02B6955S4S/p1685523570973869?thread_ts=1684924826.031689&cid=C02B6955S4S
https://openmetadata.slack.com/archives/C02B6955S4S/p1685525710488899?thread_ts=1684924826.031689&cid=C02B6955S4S

@ulixius9 @ayush-shah you are referencing this ticket in one of the PRs. Can we close this?

hi  @ulixius9 @harshach,
I see your code change on commit "Fix #11778: Add support for hive metastore ingestion #12599" but this only support on metastore with mysql or postgres, do you have plan to  support metastore with oracle?


[ISSUE] - Multiple Host Configuration Inheritance not working as expected

Hi all,
First of all, thanks for the tool, it's really helpfull! :)
With the rewrite of the code, it seems that sshs is not parsing the ssh configuration as before and does not work like OpenSSH does.
My file structure looks like this :
.ssh
├── config
└── zones
    ├── infra1
    ├── infra2
    └── cust
        ├── cust1
        └── cust2

With a simple ssh config file that contains Include to other ssh config files located in the `zones' subdirectory. This allow me, like many people, to structure and separate ssh configuration for every different infrastructure.
My ssh zones files looks like this:
Host device01.domain.tld
        Hostname <IP_ADDRESS>

Host device02.domain.tld
        Hostname <IP_ADDRESS>

Host device03.domain.tld
        Hostname <IP_ADDRESS>

Host *.domain.tld
    User bob
    ProxyJump jump01
    IdentityFile ~/path/to/private/key/cust1_id_ed25519

In version 3.4.0, this configuration was handled correctly and all the Host matching block where read by sshs and I was able to connect to device01.domain.tld using the proper user, ssh key, cipher, command and proxy jump.
Since version 4.0.0 and more specifically with 4.1.0, sshs to device01.domain.tld will not read other Host block and will only apply the configuration of the individual Host block. This mean that using sshs to connect to device01.domain.tld will not use bob as user, not use the specified IdentityFile neither the Proxy Jump configuration.
To make it works in version 4.1.0 my ssh zone file need to look like this:
Host device01.domain.tld
    Hostname <IP_ADDRESS>
    User bob
    ProxyJump jump01
    IdentityFile ~/path/to/private/key/cust1_id_ed25519

Host device02.domain.tld
    Hostname <IP_ADDRESS>
    User bob
    ProxyJump jump01
    IdentityFile ~/path/to/private/key/cust1_id_ed25519

Host device03.domain.tld
    Hostname <IP_ADDRESS>
    User bob
    ProxyJump jump01
    IdentityFile ~/path/to/private/key/cust1_id_ed25519

It works, but it makes the configuration heavier and more complex to maintain.
Looks like a bug in the parser as it does not read any other Host blocks.
Thanks for your help :)
Saldru

Before opening an issue I wanted to followup
I found a way throw off the the parser
but weidly enough only in wsl2 (arch 5.10, sshs compiled from source) the sshconfig works perfectly in powershell (installed via chocolatey)
.ssh/config :
# SSH Configuration File
# Location: C:\Users\<YourUsername>\.ssh\config

# ============================
# Global defintition
# ============================
#Global JumpHost config
#jumphost-access read-only
Host jumphost.*-ro
    IdentityFile ~/.ssh/id_rsa
#jumphost-access read-write
Host jumphost.*-rw
    IdentityFile ~/.ssh/id_rsa-adm
#jumphos global configuration
Host jumphost*
    IdentitiesOnly yes
    ForwardAgent yes
#
# Global prehistorical equipement ssh specification
# swiib global configuration ond for old tech
Host swiib* rc* rh* rv*
    KexAlgorithms +diffie-hellman-group1-sha1,diffie-hellman-group14-sha1,diffie-hellman-group-exchange-sha1
    HostKeyAlgorithms +ssh-rsa,ssh-dss
    PubkeyAcceptedAlgorithms +ssh-rsa,ssh-dss
    MACs +hmac-sha1,hmac-sha1-96
#
# password authentication hosts
Host r* sw* fw* proxy* syslog*
    PreferredAuthentications password

# USER Definition
# Replace YourUsernames here! <<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<
######################################################################
# ro rw
Host *-ro
    User usr01
Host *-rw
    User adm.usr01
Host *-local
    User local
######################################################################

#starship user specification
Host starship*
  PreferredAuthentications password
  User admin

# isp-adm user
Host *-isp
  User isp
#
# oob access or admin
Host *-oob *-admin
  User admin
#
# Port Definition
#default
Host *
    Port 22

I have narrowed down the issue to this block
Host swiib* rc* rh* rv*
    KexAlgorithms +diffie-hellman-group1-sha1,diffie-hellman-group14-sha1,diffie-hellman-group-exchange-sha1
    HostKeyAlgorithms +ssh-rsa,ssh-dss
    PubkeyAcceptedAlgorithms +ssh-rsa,ssh-dss
    MACs +hmac-sha1,hmac-sha1-96

unless I comment it out or change the host match it to example -old-
the parser goes haye wire and throws an 'expected \n, at pos xxx' where pos is like way off my file length.
I pretty sure issue might on my side on condition mixup and me missunderstanding how your parsing logic.
But the fact that it works on the preloaded one from choco (in powershell) vs the compiled one encouraged me reporting it  here


Fix extension formatting

Description
This PR fixes a very minor formatting issue in the samples readme, with two extensions not being properly highlighted.
General Checklist:
Please ensure the following points are checked:

[ ] My code follows the coding style
[ ] I have reviewed file licenses
[ ] I have updated the header Copyright to reflect the current year (CI build will fail if Copyright is out of date)
[ ] I have commented any added functions (in line with Doxygen)
[ ] I have commented any code that could be hard to understand
[ ] My changes do not add any new compiler warnings
[ ] My changes do not add any new validation layer errors or warnings
[ ] I have used existing framework/helper functions where possible
[ ] My changes build on Windows, Linux, macOS and Android. Otherwise I have documented any exceptions
[ ] My changes do not add any regressions
[ ] I have tested every sample to ensure everything runs correctly
[ ] This PR describes the scope and expected impact of the changes I am making

Merging as this is a very small change to documentation and does not affect any functional aspect of the project


Question about pushing to main repo

Since i am now able to push straight to this repo without having to do a pull request ever now and then, should i still leave creating the download/pre-built executables to you or do them myself?

Go can build the .exe and upload it. Include a virustotal link at least. We should never be building .exe for security reasons (but then no one would download the app)


no-skin is removed.

It removes device configuration when emulator initializes. It causes the device to be 320x480 with 240 or 320 display density. Which makes effective screen width about 160dp. Emulator becomes almost useless.
More info here. https://github.com/travis-ci/docs-travis-ci-com/pull/466

What size will be used by default? In the linked issue you talk about explicitly specifying a skin.

When creating the emulator you can specify a skin. If you don't it uses a default skin. When created there is always skin for an emulator.
When starting it with emulator command -no-skin skips everything and uses 320x480 as the size.

The default skin should be 480x800.

Works for me. Now to go and update 30 projects...

Actually -no-skin causes problems for heavy Espresso tests. I have been testing this on googlesamples/android-topeka app. Out of 58 Espresso tests, 9 fails because it cannot find the button on the screen. When -no-skin is removed, it just works.
Running that many Espresso tests on Travis is not good either. Emulator on Travis is flaky anyways.


Add benchmark

Closes #48

Codecov Report

Merging #50 into master will not change coverage by %.
The diff coverage is n/a.

@@            Coverage Diff            @@
##            master       #50   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files           16        16
  Lines           84        84
=========================================
  Hits            84        84

Flag
Coverage Δ

#unittests
100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e30e0f6...0e8fba6. Read the comment docs.


Image not in IDocument.Images collection

Hello,
Document, opened with BrowsingContext from the url "http://www.businessinsider.com/sean-hannity-fires-back-at-megyn-kelly-after-she-criticizes-trump-for-only-going-on-hannitys-show-2016-10",  is missing some images. I can not find main image in the Images collection. Same for url "http://www.businessinsider.com/hurricane-matthew-south-carolina-evacuations-florida-2016-10". All of the images in text are not present in the collection.
Could you please look into this and say why?

Please provide some code to reproduce first. Thanks!

Oh, sorry sorry, my bad. Accidentally delete this element from the DOM.
PS Thanks for the lib, use it for several months and this is the best thing that happened to me during that time!

It's alright - thanks for looking at it in detail. Also much welcome on the kudos - appreciated 👍


Design and implement a config for distributed execution setup

Currently k6-operator supports only the simplest straight-forward distributed setup when 100% of execution is spread in equal chunks 100% / N to N runners. But k6 is far more versatile which is fully utilized by k6 Cloud in distribution parameter. It would be good to include this versatility into k6-operator as well.
Setup of k6-operator already allows passing all necessary options; the main caveat is in how best to configure distribution. Sample options to consider:

N fraction numbers

parallelism: 4
distribution: 1/3, 1/6, 1/6, 1/3

N percentages

parallelism: 4
distribution: 0.33, 0.17, 0.17, 0.33

Since number of runners can be large, more generalized approach to defining distribution may be necessary. E.g., for 30 runners with 1/60 load and 10 runners with 1/20 load:

parallelism: 40
distribution: 30:1/60, 10:1/20

Something else?

No matter what config option is chosen, validation will be needed for:
a) the format of distribution is sufficient, e.g. exactly N numbers
b) final distribution adds up to 1

@evanfpearson sorry for the delay but here are the clarifications on the above :sweat_smile:

In order to implement this, wouldn't the main changes be to https://github.com/grafana/k6-operator/blob/main/pkg/segmentation/segmentation.go ? I don't understand what logic you were talking about needing to hack?

Here I meant the lower-lever code in k6 itself, i.e. https://github.com/grafana/k6/tree/master/lib
k6-operator should not re-implement what is already present in k6, like dynamic calculation of execution segments.

https://github.com/grafana/k6/issues/140 sounds great, but this would surely affect more about the operator than just this issue right?

Yes, absolutely. There will be some changes in k6-operator but I hope we'll be able to keep them to the minimal, i.e. without impacting the core logic of controllers.
But beyond 'simple' switch to distributed mode, https://github.com/grafana/k6/issues/140 might potentially open up new approaches to explore.


vsr: add reconfiguration request

This adds the basic boilerplate to handle reconfiguration:

.reconfigure operation
Corresponding ReconfigurationRequest which forms the body of the request.
Basic validation logic (the bit where primary makes a judgement call whether reconfiguration is a good idea based on status of the cluster is yet TODO)
Skeleton of request handling by the primary (during prepare and commit).

The ReconfigurationRequest is somewhat future proof --- it includes facilities for changing the number of standbys/actives, although we don't support actual changes here yet (only permutations are allowed). I think we could re-use the same request shape for both:

logical reconfiguration (this PR; advance epoch, permute members, but keep the member set the same).
physical reconfiguration (keep the epoch and active replicas, but add or remove a standby).

Status: waiting for @jorangreef to take a look as well


Clean HASS Urls that come from UniFi Protect

This automatically applies the recommended configuration for UniFi cameras. This could possibly be moved to the Home Assistant component when passing the URL, but I'm starting here to get your thoughts.
Closes #81

I don't think this is good solution.

RTSPX should't be necessary, because latest go2rtc won't check TLS for IP-address as host.
Removing enableSrtp necessary. But I don't think this should be automatically. It's better to add SRTP support, but I don't have access to any UniFi camera

It didn’t seem that you were interested in adding SRTP support because it was only useful for UDP and go2rtc only used TCP. Is the scenario changed? I am not very familiar with the protocol, but I can poke around at it.

You right. I think it's unnecessary to use SRTP over HTTPS. But looks like this is default option for UniFi.

Probably doesn't make sense anymore
https://github.com/home-assistant/core/pull/129852

Yes. Thanks! I was about to get to work to write a patch like that and remove the parameter there but saw this first.


[run-tests] [feat] Added Debezium DB2 connector for Pulsar

This PR is for running tests for upstream PR https://github.com/apache/pulsar/pull/19821.

/pulsarbot rerun-failure-checks


[Event Modification] Codeunit 12: Change OnAfterVendLedgEntryInsert's IntegrationEvent to [true, false]

I am in a middle of implementing something in the purchase and the sales process until I notice the OnAfterCustLedgEntryInsert's IntegrationEvent is currently sets to [true, false] while the OnAfterVendLedgEntryInsert is not. I don't know what the reason behind the differences, but I need the OnAfterVendLedgEntryInsert's IntegrationEvent also to be the same as OnAfterCustLedgEntryInsert.
In short: change this in the Codeunit 12
    [IntegrationEvent(false, false)]
    local procedure OnAfterVendLedgEntryInsert(var VendorLedgerEntry: Record "Vendor Ledger Entry"; GenJournalLine: Record "Gen. Journal Line"; var DtldLedgEntryInserted: Boolean)
    begin
    end;

Into this:
    [IntegrationEvent(true, false)]
    local procedure OnAfterVendLedgEntryInsert(var VendorLedgerEntry: Record "Vendor Ledger Entry"; GenJournalLine: Record "Gen. Journal Line"; var DtldLedgEntryInserted: Boolean)
    begin
    end;

I really appreciate if this request is granted.

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. We will update this issue with information about availability. Please do not reply to this, as we do not monitor closed issues. If you have follow-up questions or requests, please create a new issue where you reference this one.


initialization of mu vector

@ntchen ,  shall we maybe also do a hyper-parameter search for its intilization value of multiplier mu?  maybe it does not make sense to set all mu to be 1?  Maybe you could give some thoughts?
https://github.com/marrlab/DomainLab/blob/593c34499d96c6c84cfe5b4a809d800260bc5d41/domainlab/algos/trainers/fbopt_alternate.py#L34
To sample that, we need to set those hyper-parameters.

we can try 1- 1000

But mu is a vector, for diva, the hyper parameters from the paper are
rather different scale . Some are 1 some are 1e5
On Fri, 22 Sep 2023 at 22:34, Nutan Chen @.***> wrote:

we can try 1- 1000
—
Reply to this email directly, view it on GitHub
https://github.com/marrlab/DomainLab/issues/441#issuecomment-1732003424,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAELKRV3IN345NMPP5TM67TX3XY3VANCNFSM6AAAAAA5DRYJOY
.
You are receiving this because you were assigned.Message ID:
@.***>

it is quite high. If R is not extremely low, I doubt the performance of other loss terms. but to follow the diva, we can set the initial mu to 1~1e5 and max mu to 1e6.

As discussed, it might be totally ok to set all components of the mu vector to be 1.0, we have to see


Always consume the no_throttle keyword argument.

The current code relies on the assumption that the first invocation will never specify no_throttle=True.
However that puts us in a pickle when writing unit tests: if we had a fictitious:
def setup_platform():
update()
@Throttle(MIN_TIME_BETWEEN_SCANS)
def update():
pass
Then given multiple tests, the second and some of subsequent tests would be throttled (depending on timing).
But we also can't change that code to call `update(no_throttle=True)' because that's not currently accepted.
This diff shouldn't change the visibile behavior of any component, but allows this extra flexibility.
Description:
Related issue (if applicable): fixes #11125
Pull request in home-assistant.github.io with documentation (if applicable): home-assistant/home-assistant.github.io#<home-assistant.github.io PR number goes here>
If the code communicates with devices, web services, or third-party tools:

[x] Local tests with tox run successfully. Your PR cannot be merged unless tests pass

@balloob this fixes a bug in my previous diff, would you merge?


We Got ####ed Over Again.  Out of seriousness, we're supporting long term development of Alpha Authority's bots.
Win moment.


Implement Flatpickr

Attempt to implement Flatpickr on calendar fields.
Refer to #301

Super nice! A couple of things to think about:

Should we format the date that is displayed to the user after it is selected? Seems like Flatpickr has support for this. We could just add the format to /locales/xx.json.
@adriaanvanrossum ok to use the CDN, or should we host the files ourselves?
Could you try to fix the input field on iOS devices? Don't know if it looks the same on Androids.

Let's just put it on our CDN. It's privacy friendly and they don't track anything.
https://cdn.coronastatus.eu. It's backed by BunnyCDN.

Also, for each new resource we add in <head> the time before something is displayed to user increases. Some resources are not required on all pages, and we should either:

Load them in the footer
Only load them on the pages where they are required, but then we have to change head.ejs a bit.

We can look at that in a separate issue, not crucial for this PR:

Added it to our CDN:

https://cdn.coronastatus.eu/libraries/flatpickr-4.6.3.js
https://cdn.coronastatus.eu/libraries/flatpickr-4.6.3.css

Please still use https://www.srihash.org and these attributes, just to be sure:
<script
  src="https://cdn.coronastatus.eu/libraries/..."
  integrity="sha384-..."
  crossorigin="anonymous"
  referrerpolicy="no-referrer"
></script>

Should we format the date that is displayed to the user after it is selected? Seems like Flatpickr has support for this. We could just add the format to /locales/xx.json.

We should. However, need to load the respective i10n .js files for the localisation. Not very sure how I can do this.

Could you try to fix the input field on iOS devices? Don't know if it looks the same on Androids.

I do not have an iOS mobile device. But it looks fine on Safari for me.
I am pretty new to building a site on node... Pardon me if my skills are limited at this time 😆. I can help within my limit, but I am contributing to help and learn more about node..

Should we format the date that is displayed to the user after it is selected? Seems like Flatpickr has support for this. We could just add the format to /locales/xx.json.

We should. However, need to load the respective i10n .js files for the localisation. Not very sure how I can do this.

Could you try to fix the input field on iOS devices? Don't know if it looks the same on Androids.

I do not have an iOS mobile device. But it looks fine on Safari for me.
I am pretty new to building a site on node... Pardon me if my skills are limited at this time 😆. I can help within my limit, but I am contributing to help and learn more about node..

Ok np, I can take a look at the iOS-date later :) You can render the date-format backend like this:
<script src="https://cdn.jsdelivr.net/npm/flatpickr"></script>
<script src="/static/form.js?v=<%= locals.cacheKey %>"></script>
<script>
  flatpickr(document.querySelectorAll('[type=date]'), {
    altInput: true,
    altFormat: '<%= __('F j, Y') %>',
    dateFormat: 'Y-m-d'
  });
</script>

Then people can change the value of 'F j, Y' as they see fit


Set Version 0.2.8

⚠ We've moved the voting strategies to another repository, if you want to add or edit strategy you must do it here: https://github.com/snapshot-labs/snapshot-strategies

@bonustrack ok 👍 will do that from next version


2 Gang Switch Module

Zemismart Switch DIY Breaker Module
https://nl.aliexpress.com/item/4001093548153.html?spm=a2g0o.productlist.0.0.13457af7G7ZTBT&algo_pvid=04b003e9-22ae-46bf-9773-bf68edeae307&algo_expid=04b003e9-22ae-46bf-9773-bf68edeae307-1&btsid=0ab6f81e15944663651576788e6ef3&ws_ab_test=searchweb0_0,searchweb201602_,searchweb201603_

Because these modules are used for different purposes it would be nice to change the application from lamp, switch, fan and so on. Like it is for the plug

Already added.


Update Processing Controller UI

From backlog item:347
Scrumwise Status:To do
Allow the user to set processing ranges within the Processing Controller dialog.  This will affect OpendTect and standalone implementations.
NOTE: The attribute processing mechanisms of both Opendtect and Petrel will not be affected by this as they use different mechanisms to perform the processing.
Questions:
-Should the results be visible in GV?
-Should the range be stored in the session file?
-Documentation - Best not to do this until closer to release as then all new fetueres can be included at the same time. - Also, there will be no risk of the wrong version of the documentation going out with a different release.

A seismic survey (SeismicCollection) must be extant before horizon import can occur.
The imported horizons will be imported into the first 'Interpretation Folder' that is present within the seismic survey.
If no interpretation folders are present, a folder 'Interpretation folder 1' will vbe created, and horizons imported.

The spec has been changed slightly.  An Interpretation folder must already exist.


CONTRIBUTING: Add how to edit rbs

Added a description of how to contribute to a Gem that is already type-defined in gem_rbs_collection.

Personally, I think we do not need to describe how to contribute to the existing gem because the process is obvious with the existing documentation. I do not want to increase the documentation to keep it simple if the existing documentation is enough.
If this document confused you, could you explain your confusion? I'd like to know why we should add this section to the documentation. I'd like to update this document if it's reasonable.

@pocke

Personally, I think we do not need to describe how to contribute to the existing gem because the process is obvious with the existing documentation. I do not want to increase the documentation to keep it simple if the existing documentation is enough.

As pocke said, it is not necessary to know how to contribute to an existing gem, as I think you can find it in the existing documentation. Thanks for your comment!

I close this PR but thanks for your suggestion!


[Fix #6746] Avoid offense on $stderr.puts with no arguments.

This PR closes issue #6746. The applied changes will avoid offense on $stderr.puts with no arguments.

Before submitting the PR make sure the following are checked:

[x] Wrote good commit messages.
[x] Commit message starts with [Fix #issue-number] (if the related issue exists).
[x] Feature branch is up-to-date with master (if not - rebase it).
[x] Squashed related commits together.
[x] Added tests.
[x] Added an entry to the Changelog if the new code introduces user-observable changes. See changelog entry format.
[x] The PR relates to only one subject with a clear title
and description in grammatically correct, complete sentences.
[x] Run bundle exec rake default. It executes all tests and RuboCop for itself, and generates the documentation.

Thanks!


Rollback does not work as expected

Environment
Knex version:  0.95.6,
Database + version: MYSQL 8.0.25
OS: Manjaro
Bug

Explain what kind of behaviour you are getting and how you think it should do

Config:
const config: Knex.Config = {
    client: 'mysql',
    connection: {
        host: process.env.DB_HOST,
        port: process.env.DB_PORT ? parseInt(process.env.DB_PORT) : undefined,
        user: process.env.DB_USER,
        password: process.env.DB_PASSWORD,
        database: process.env.DB_DATABASE,
    },
    migrations: {
        tableName: 'migrations',
        directory: 'src/db/migrations',
        schemaName: 'test',
    },
};

const db = knexLib(config)
db.migrate.latest()
    .then(() => logger.info("DB Migration success"))
    .catch(ex => {
        logger.error(`DB Migration error:\n${ex}`)
        db.migrate.rollback()
            .then(() => logger.warn("DB migration rolled back"))
            .catch(ex => logger.error(`DB migration rolled back failed: ${ex}`))
            .finally(() => process.exit(1))
    })

Two migration files
export async function up(knex: Knex): Promise<void> {
    return knex.schema
        .createTable('users', t => {
            t.bigIncrements('id').primary().unsigned()
        })
}

export async function down(knex: Knex): Promise<void> {
    return knex.schema.dropTable('users')
}

export async function up(knex: Knex): Promise<void> {
    return knex.schema
        .createTable('orders', t => {
            t.bigIncrements('id').primary().unsigned()
            t.bigInteger('user_id').references('id').inTable('users').index('idx_user_orders_user_id')

        })
}

export async function down(knex: Knex): Promise<void> {
        return knex.schema.dropTable('orders')
}

t.bigInteger('user_id').references('id').inTable('users').index('idx_user_orders_user_id') - is a bug, user_id is signed while users.id is not. This will fail migration.
Expected - rollback is executed  for failed migration file (the one that creates orders table)
Actual - rollback is executed on the users migration script, users table is deleted and orders table remains. Even If I run users migration first, and only afterwards I run orders on a second run.

Error message

Error: alter table `orders` add constraint `orders_user_id_foreign` foreign key (`user_id`) references `users` (`id`) - UNKNOWN_CODE_PLEASE_REPORT: Referencing column 'user_id' and referenced column 'id' in foreign key constraint 'orders_user_id_foreign' are incompatible.

EDIT (1):
The confusion comes from the fact that orders.user_id foreign constraint creation fails, but for whatever reason, the table is created. My understanding is that every migration file is suppose to run in transaction and if it fails it is rolled back. It does not happen. It seems that Table orders and foreign key constraint are executed in separate transactions.

If running migration fails, then its down script is implicitly called and migration is not written to database. So you should not call .rollback() on migration fail.


Generate markdown from help

Checklist

[X ] Are you running the latest v3 release? The list of releases is here.
[ X] Did you check the manual for your release? The v3 manual is here.
[ X] Did you perform a search about this feature? Here's the GitHub guide about searching.

What problem does this solve?
Easy generate documentation for command line app

@bricekams This has been removed in v3 to decrease the size of cli executable. We are still exploring options as to how to do this.

It has been removed in v3, meaning that it's available in v2? can I have a link?

Look at docs.go App.ToMarkdown


feat: hubs must have an fid to peer with other hubs

What is the feature you would like to implement?
A hub will only accept a peer if it has a valid fid
Why is this feature important?
Requiring a unique identifier for hubs prevents spam, because an abusive hub can easily be identified and blocked and there is a cost to acquiring a new identifier.
Will the protocol spec need to be updated??
Yes, section 2.4 will need to be updated and a new section about Hub authentication may need to be added.
How should this feature be built? (optional)
TBD
Additional context
TBD

we don't need this for v2.0.0 given that all hubs are trusted

Note that hubs can now specify an optional operator FID via the --hub-operator-fid flag, though this ticket's original goal was to make it a requirement and not optional.

How would a hub find/get its fid? There's nothing in the docs about actually obtaining a fid


Addressing JOSS installation issues

Fixing Installation issues #228

Update the documentation to inform users about the optional dependencies. Made sure that requests and sunpy[map] are included in the install_requires section. Addressing JOSS review issue: Installation issues #228. Close #228


Fix: Entity IDs collision due to immutable: true inclusion

Fixes #34
Description
This PR adds a check to avoid creating entities that already exist, so there are no unique key constraint issues. This only applies to immutable entities.
Considerations

Most of the if (ev !== null) return are unreachable code. However, there are some cases in which it is expected that we'll try to save an entity that's already saved, so having protection in all of them sounds like the right thing to me to avoid unexpected errors.
Examples of common places where the if (ev !== null) ... will get triggered and is expected are:

With AccessControl, it was being created each time we called fetchAccessControl, which is in every access control event handler
With Role, there are several places calling fetchRole that created the same role each time.

hello @ernestognw
I'm not sure this check is something we want, for 2 reasons:

it is technically ok to save an immutable entity twice, as long as the values being pushed are identical. So we don't need to protect ourselves against that if we are confident in the consistency of the object
doing a load is really an expensive operation. It's a database read, which requires synchronization. We should avoid loading elements just for fun ... as it would slow down indexing.

It might be counterintuitive, be overwriting an object (which is ok for immutable if you overwrite with the same data, is significantly faster than loading, and writing if not found. That is why the code is the way it is today, and I don't think it should change.

See discussion in #34

hello @ernestognw

Hey @Amxx 😳

I'm not sure this check is something we want, for 2 reasons:

it is technically ok to save an immutable entity twice, as long as the values being pushed are identical. So we don't need to protect ourselves against that if we are confident in the consistency of the object

Do you have any link to documentation about that? What I see from the graph docs is that it can only be changed during the same block in which it was created, so my understanding is that although they're identical, they conflict, and make sense to me.

doing a load is really an expensive operation. It's a database read, which requires synchronization. We should avoid loading elements just for fun ... as it would slow down indexing.

It might be counterintuitive, be overwriting an object (which is ok for immutable if you overwrite with the same data, is significantly faster than loading, and writing if not found. That is why the code is the way it is today, and I don't think it should change.

I agree. We can remove almost every check I'm doing, but at least I'm pretty sure it happens with Role and AccessControl entities, so I'd advocate to keep it for those 2 at least, but I see in #34 you've been able to replicate and is happening with ERC1155, so my feeling is that there are some others not in my radar as well.

Do you have any link to documentation about that? What I see from the graph docs is that it can only be changed during the same block in which it was created, so my understanding is that although they're identical, they conflict, and make sense to me.

Documentation is really lacking. I contacted the graph devs to confirm.

I agree. We can remove almost every check I'm doing, but at least I'm pretty sure it happens with Role and AccessControl entities, so I'd advocate to keep it for those 2 at least, but I see in https://github.com/OpenZeppelin/openzeppelin-subgraphs/issues/34 you've been able to replicate and is happening with ERC1155, so my feeling is that there are some others not in my radar as well.

I'd avoid the load for events for sure. For the Role and ERC1155 I'll wait for the graph team to answer (I pinged them about this issue)

is happening with ERC1155

Is it? I don't see why it would happen for Role and not for ERC1155, but I never saw it happen for ERC1155.

Documentation is really lacking. I contacted the graph devs to confirm.
I'd avoid the load for events for sure. For the Role and ERC1155 I'll wait for the graph team to answer (I pinged them about this issue)

Amazing, please let me know what they say. I'm fine changing the PR and avoid the load, but I'm pretty sure there's something that's not working. If we can fix it removing the loads, that'd be amazing

Is it? I don't see why it would happen for Role and not for ERC1155, but I never saw it happen for ERC1155.

Ah sorry, I misread one of your comments in #34. I've only seen this happening with access control

I'd advocate for keeping the immutable for performance reasons.

Well, this is a balance between:

immutable + load
mutable + no load

I honestly don't know which one is faster. I'm not sure what the immutable saves ... I know the load cost a lot.


Basic implementation of chat (#57)

Implements handling of the ChatMessageServerbound packet, and broadcasting the ChatMessageClientbound packet. Largely based on how player animations are implemented.
Closes #57 (unless there is more work in that scope, like chat-components).

Looks good! Thanks again for the help :)


@qualweb/best-practices: fix up unit tests

This issue covers the actual unit tests of the package, and the general structure of the validation tests - not necessarily the design/implementation of the validation tests.
npm -w @qualweb/best-practices test seems to hang after the first test passes. It's possible that the tests don't finish up properly.
Consider this issue solved when we have a PR that passes (and runs) all unit tests without issue, and runs validation tests (but may fail them).

Closing, the PR #138 has been merged.


name resolution failure when running prover_options.textpb

ed@ed-Aspire-E5-575:/tmp/deepmath/deephol$ sudo docker run -it --network=holist_net -v /tmp/deepmath:/data gcr.io/deepmath/deephol --prover_options=/data/deephol/example/prover_options.textpb --output=/data/prooflog.textpb --proof_assistant_server_address=holist:2000
W0521 16:32:38.697212<PHONE_NUMBER>06464 prover_flags.py:122] builtin_library is deprecated. Do not provide.
I0521 16:32:38.697877<PHONE_NUMBER>06464 prover_flags.py:137] Using prover_options:
path_theorem_database: "/data/deephol/theorem_database_v1.0.textpb"
path_model_prefix: "/data/deephol/checkpoints/loop_tac_depend_5210000/model.ckpt-5210000"
path_tactics: "/data/deephol/example/hollight_tactics.textpb"
path_tactics_replace: "/data/deephol/example/hollight_tactics_replacements_nogen.textpb"
theorem_embeddings: "/data/loop_tac_depend_5210000__model.ckpt-5210000__v1.0__embedding.npy"
prover: "bfs"
bfs_options {
max_top_suggestions: 20
max_successful_branches: 5
max_explored_nodes: 120
}
splits_to_prove: VALIDATION
timeout_seconds: 120.0
model_architecture: PARAMETERS_CONDITIONED_ON_TAC
library_tags: "clifford.ml"
I0521 16:32:38.698731<PHONE_NUMBER>06464 prover_flags.py:155] Splits to prove: VALIDATION
I0521 16:32:38.698900<PHONE_NUMBER>06464 prover_flags.py:170] Library tags to prove: clifford.ml
I0521 16:32:38.709361<PHONE_NUMBER>06464 io_util.py:85] Successfully read tactics from "/data/deephol/example/hollight_tactics.textpb"
I0521 16:32:38.709577<PHONE_NUMBER>06464 io_util.py:118] Found 41 tactics.
I0521 16:32:38.711959<PHONE_NUMBER>06464 io_util.py:85] Successfully read replacements from "/data/deephol/example/hollight_tactics_replacements_nogen.textpb"
I0521 16:32:38.712185<PHONE_NUMBER>06464 io_util.py:123] Found 3 tactic replacements.
I0521 16:33:40.346311<PHONE_NUMBER>06464 io_util.py:134] Successfully read theorem database from /data/deephol/theorem_database_v1.0.textpb (31680 theorems).
I0521 16:33:40.346585<PHONE_NUMBER>06464 prover_util.py:490] Generating task list for theorem database.
I0521 16:33:40.412294<PHONE_NUMBER>06464 prover_flags.py:189] Number of prover tasks: 16
I0521 16:34:41.991417<PHONE_NUMBER>06464 io_util.py:134] Successfully read theorem database from /data/deephol/theorem_database_v1.0.textpb (31680 theorems).
I0521 16:34:42.002013<PHONE_NUMBER>06464 io_util.py:85] Successfully read tactics from "/data/deephol/example/hollight_tactics.textpb"
I0521 16:34:42.002218<PHONE_NUMBER>06464 io_util.py:118] Found 41 tactics.
I0521 16:34:42.003573<PHONE_NUMBER>06464 io_util.py:85] Successfully read replacements from "/data/deephol/example/hollight_tactics_replacements_nogen.textpb"
I0521 16:34:42.003768<PHONE_NUMBER>06464 io_util.py:123] Found 3 tactic replacements.
2019-05-21 16:34:42.014507: I external/org_tensorflow/tensorflow/core/platform/cpu_feature_guard.cc:142] Your CPU supports instructions that this TensorFlow binary was not compiled to use: SSE4.1 SSE4.2 AVX AVX2 FMA
I0521 16:34:42.015912<PHONE_NUMBER>06464 holparam_predictor.py:78] Importing from metagraph in /data/deephol/checkpoints/loop_tac_depend_5210000/export/best_exporter/1549098420/saved_model.pb.
W0521 16:34:45.323910<PHONE_NUMBER>06464 deprecation.py:323] From /home/main.runfiles/org_tensorflow/tensorflow/python/training/saver.py:1277: checkpoint_exists (from tensorflow.python.training.checkpoint_management) is deprecated and will be removed in a future version.
Instructions for updating:
Use standard file APIs to check for files with this prefix.
I0521 16:34:45.324696<PHONE_NUMBER>06464 saver.py:1281] Restoring parameters from /data/deephol/checkpoints/loop_tac_depend_5210000/model.ckpt-5210000
I0521 16:34:45.540045<PHONE_NUMBER>06464 embedding_store.py:86] Reading embeddings from "/data/loop_tac_depend_5210000__model.ckpt-5210000__v1.0__embedding.npy"
I0521 16:34:46.395910<PHONE_NUMBER>06464 prover.py:357] Setting up and registering theorems with proof assistant...
Traceback (most recent call last):
File "/home/main.runfiles/deepmath/deepmath/deephol/main.py", line 28, in
tf.app.run(main)
File "/home/main.runfiles/org_tensorflow/tensorflow/python/platform/app.py", line 40, in run
_run(main=main, argv=argv, flags_parser=_parse_flags_tolerate_undef)
File "/home/main.runfiles/absl_py/absl/app.py", line 300, in run
_run_main(main, args)
File "/home/main.runfiles/absl_py/absl/app.py", line 251, in _run_main
sys.exit(main(argv))
File "/home/main.runfiles/deepmath/deepmath/deephol/main.py", line 24, in main
prover_runner.run_pipeline(*prover_flags.process_prover_flags())
File "/home/main.runfiles/deepmath/deepmath/deephol/prover_runner.py", line 31, in run_pipeline
this_prover = prover.create_prover(prover_options)
File "/home/main.runfiles/deepmath/deepmath/deephol/prover.py", line 348, in create_prover
hol_wrapper = setup_prover(theorem_database)
File "/home/main.runfiles/deepmath/deepmath/deephol/prover.py", line 361, in setup_prover
proof_assistant_pb2.RegisterTheoremRequest(theorem=thm))
File "/home/main.runfiles/deepmath/deepmath/deephol/public/proof_assistant.py", line 42, in RegisterTheorem
return self.stub.RegisterTheorem(request)
File "/usr/local/lib/python3.5/dist-packages/grpc/_channel.py", line 549, in call
return _end_unary_response_blocking(state, call, False, None)
File "/usr/local/lib/python3.5/dist-packages/grpc/_channel.py", line 466, in _end_unary_response_blocking
raise _Rendezvous(state, None, None, deadline)
grpc._channel._Rendezvous: <_Rendezvous of RPC that terminated with:
status = StatusCode.UNAVAILABLE
details = "Name resolution failure"
debug_error_string = "{"created":"@1558456486.421764398","description":"Failed to create subchannel","file":"src/core/ext/filters/client_channel/client_channel.cc","file_line":2267,"referenced_errors":[{"created":"@1558456486.421761906","description":"Name resolution failure","file":"src/core/ext/filters/client_channel/request_routing.cc","file_line":166,"grpc_status":14}]}"

Do you have the proof assistant running? From the website:
docker network create holist_net
docker run -d --network=holist_net --name=holist gcr.io/deepmath/hol-light

Thank you. Yes and no. Problem was I had several dead docker containers all of the same thing. I cleaned up docker and restarted it and all is working.


Remove 6.0/v2.1/pcaps

Ticket
Redmine ticket: follow up on #2013 to move pcaps to directories where they actually get used after removal of tests only used by version 6
cc @jasonish should we do this for the 5 other dns tests ?

This doesn't fix all of them?

cc jasonish should we do this for the 5 other dns tests ?
This doesn't move all of them?

I take that as a yes, see https://github.com/OISF/suricata-verify/pull/2019


Add BCBSNC Foundation as a Platinum sponsor to all three websites.

Logo is in sponsorship folder.

NC Open Pass is done.

Completed on NC Datapalooza.


Add conda build

Add conda build for zppy. (Note this was initially to be included as part of #30 / #36).

I think even if this is done separately, it should be tested before #36 gets merged.  So I don't see a big advantage of doing it separately personally.

The reason I say this is that it is only this way that you will discover files missing from the package (e.g. slurm_header.sh is currently missing).
It is also not a difficult task and isn't, in my view, clearly separate from making zppy a python package.

Hey @forsyth2, if you are going to take this forward in #36 I've provided some references for you:

Building conda packages from scratch
My example

Tip: If you include a build section in the meta.yaml, you don't need a build.sh file.

Closed as part of merging #36.


Add a CLI with arguments for each client for one-off usage

Implement CLI argument lists for each of the following plugins:

[ ] ndbench-cass-plugins
[ ] ndbench-dynamodb-plugins
[ ] ndbench-dyno-plugins
[ ] ndbench-es-plugins
[ ] ndbench-evcache-plugins
[ ] ndbench-geode-plugins
[ ] ndbench-janusgraph-plugins
[ ] ndbench-sample-plugins

Can archaius-annotated config interfaces be used to pull configuration from the command line? Is there an example of this someplace?

@vinaykumarchella I will pull from System properties with Archaius.


GPC is not allowing clicks on screen

Hi
This is a quite odd issue and never happened to me before, actually I got various Foundry Instances and it only happens to me in one of them.
I can´t effectively click any elements in the canvas that are placed anywhere over the largest clock created. Is like there was nothing there. Attached you´ll see a couple of screenshots where you can see what I can highlight and what I cant .

Anything that is on the right of the red line is not clickable

I think I know what's causing that, and that's definitely my bad. I'll fix this today.


Add gocover checks for PR's

Description
This PR is to add gocover and coverall- code coverage check for unit tests for any PR opened against main branch.
Type of change: Feature

[x] New feature (non-breaking change which adds functionality)

How Has This Been Tested?

[x] Github actions via forked repo

Checklist:

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my code
[x] I have commented my code, particularly in hard-to-understand areas
[x] My changes generate no new warnings
[x] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes
[x] Any dependent changes have been merged and published in downstream modules

/ok-to-test sha=e4338bb

/ok-to-test sha=d6f1eb5


add permissive flag to fix g++-7 compiler issue

same as here: https://github.com/schulzchristian/KaHIP/commit/2a84135e97be9cad2b2ee2e5360def4915d15d19

thanks!


Don't assume the type we read was the type we expected

i2v_GENERAL_NAME and GENERAL_NAME_print were assuming that the type of of a GENERAL_NAME (OTHERNAME) that we read in was the type we expected it to be. If its something else then this can cause unexpected behaviour. In the added fuzz test case an OOB read was occurring.
This issue was recently added by commit 4baee2d.
Credit to OSSFuzz for finding this issue.
In fixing this problem I also ran into a mem leak on a failure path in i2v_GENERAL_NAMES which I have also fixed.
The first commit (mem leak fix) is for both master and 1.1.1. The second commit is for master only.

@beldmit

In the original report, we had a NULL-pointer dereference at
BIO_printf(out, "othername:UPN:%s", gen->d.otherName->value->value.utf8string->data);
(gdb) p gen->d.otherName->value->value.utf8string $1 = (ASN1_UTF8STRING *) 0x0
What happens when we have a valid type and NULL here?

No crash now on Kurt's examples.

Pushed to master, and the first commit additionally to 1.1.1.


fix: threaded class error handler

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

Bugfix

What is the current behavior? (You can also link to an open issue here)

There is no error event handler registered on the device threads, meaning that if a device throws a thread-level error, nothing is there to catch it and log it.

What is the new behavior (if this is a feature change)?

Add an event handler to catch the errors. This should also improve the stability, because an uncaught error in the threadedClass could crash the entire playout gateway.

Other information:

Codecov Report
Base: 30.06% // Head: 100.00% // Increases project coverage by +69.93% :tada:

Coverage data is based on head (68904e2) compared to base (c99090c).
Patch has no changes to coverable lines.

Additional details and impacted files
@@               Coverage Diff               @@
##           release46      #221       +/-   ##
===============================================
+ Coverage      30.06%   100.00%   +69.93%
===============================================
  Files             54        19       -35
  Lines           8172       519     -7653
  Branches        2088        50     -2038
===============================================
- Hits            2457       519     -1938
+ Misses          5201         0     -5201
+ Partials         514         0      -514

Impacted Files
Coverage Δ

packages/timeline-state-resolver/src/conductor.ts

...line-state-resolver/src/devices/deviceContainer.ts

...te-resolver/src/integrations/quantel/connection.ts

...-state-resolver/src/devices/transitions/easings.ts

...-state-resolver/src/devices/transitions/animate.ts

...te-resolver/src/integrations/shotoku/connection.ts

...-state-resolver/src/integrations/httpSend/index.ts

...e-state-resolver/src/integrations/tcpSend/index.ts

...line-state-resolver/src/integrations/atem/index.ts

...ate-resolver/src/integrations/httpWatcher/index.ts

... and 25 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Feature/bolt 154 headlines

@mikemai2awesome I just finished merging the latest in from develop onto your feature branch here. We still need to get documentation written up (among the million other things in flight right now) but this should be good to merge into develop for the demo tomorrow while we're wrapping up any loose ends, etc.
CC @theSadowski


[SPARK-1537] [YARN] Add history provider for YARN Application Timeline Server

This is the successor to PR #5423 ; it incorporates SPARK-11315 (PR #8744), which was split out for easier review.
It adds a history provider which uses the YARN timeline server for histories, reading the events published in the application by way of the #8744 publisher. It's very efficient at getting attempt summary data, as that is server
It also contains preparatory support for history server metrics (SPARK-11373 / #9571) (i.e. it collect metrics, but does not publish them), and the cache updating of incomplete work of SPARK-7889 /#6935, (the #8744 publisher includes an incrementing counter, which is used in the history server to determine updates to histories.)
In comparison to the FS history provider, bootstrap time is fast as there is no need to replay histories to extract that metadata. It does place load on the timeline server, hence various options to configure the frequency of probing for updates, including disabling background refreshes until users actually reload pages. Because the  YARN ATS service has different failure modes from HDFS, there's some more startup checking of service availability, with failure information collected and reported —as well as noted in metrics. (More succinctly, the FS history provider assumes HDFS doesn't fail).
The new history server provider is added in yarn/src/history, along with its various tests. The code is only included in compiles, tests and scalastyle checks on Hadoop 2.6+, so does not cause any compatibility issues when Spark is built against previous Hadoop versions.

Test build #48568 has started for PR 10545 at commit 21e0c76.

Test build #48568 has started for PR 10545 at commit 21e0c76.

Test build #48568 has finished for PR 10545 at commit 21e0c76.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test build #48568 has finished for PR 10545 at commit 21e0c76.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/48568/
Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/48568/
Test PASSed.

I should add that i'm thinking of moving the core rest package from yarn/src/history to yarn/src/main. Why? It adds Hadoop authentication to Jersey Client, so allows general REST access to any of the Hadoop services. The ATS client simply uses this to talk to ATS —it can just as easily be used to talk to anything (including spark apps) through the YARN RM proxy even when kerberos/SPNEGO auth is enabled in YARN. This makes it more generic and useful elsewhere.

Test build #48767 has started for PR 10545 at commit 8d781db.

Test build #48767 has finished for PR 10545 at commit 8d781db.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/48767/
Test PASSed.

Merged build finished. Test PASSed.

Test build #49241 has started for PR 10545 at commit 690b686.

Test build #49241 has finished for PR 10545 at commit 690b686.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/49241/
Test FAILed.

Test build #50201 has started for PR 10545 at commit 83560db.

Test build #50201 has finished for PR 10545 at commit 83560db.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/50201/
Test FAILed.

Test build #52326 has started for PR 10545 at commit b6f3b99.

Test build #52326 has finished for PR 10545 at commit b6f3b99.

This patch passes all tests.
This patch does not merge cleanly.
This patch adds no public classes.

Build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/52326/
Test PASSed.


chore: align the tx_hash parameter in the account tx creator test util

This change is

#749
#747
#1073  👈
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @ArniStarkware and the rest of your teammates on  Graphite


add support for CloudLinux

this is a normal centos fork, we just need to adjust the repo detection
for this module to work:
# facter -p operatingsystem operatingsystemrelease
operatingsystem => CloudLinux
operatingsystemrelease => 6.6

Thanks!


Start Up Error - "TypeError: Cannot assign to read only property 'Intl' of [object global]"

/Users/kylegermaine/apps/node/mern-test/Intl/setup.js:51
global.Intl = _intl2.default;
^
TypeError: Cannot assign to read only property 'Intl' of [object global]
at Object. (/Users/kylegermaine/apps/node/mern-test/Intl/setup.js:19:1)
at Module._compile (module.js:460:26)
at loader (/Users/kylegermaine/apps/node/mern-test/node_modules/babel-register/lib/node.js:146:5)
at Object.require.extensions.(anonymous function) [as .js] (/Users/kylegermaine/apps/node/mern-test/node_modules/babel-register/lib/node.js:156:7)
at Module.load (module.js:355:32)
at Function.Module._load (module.js:310:12)
at Module.require (module.js:365:17)
at require (module.js:384:17)
at Object. (/Users/kylegermaine/apps/node/mern-test/client/modules/Intl/IntlReducer.js:1:1)
at Module._compile (module.js:460:26)
at loader (/Users/kylegermaine/apps/node/mern-test/node_modules/babel-register/lib/node.js:146:5)
at Object.require.extensions.(anonymous function) [as .js] (/Users/kylegermaine/apps/node/mern-test/node_modules/babel-register/lib/node.js:156:7)
at Module.load (module.js:355:32)
at Function.Module._load (module.js:310:12)
at Module.require (module.js:365:17)
at require (module.js:384:17)
This was my first time running the Quick Start. Any help would be greatly appreciated.  Do I need to update Babel?
Thanks,
Kyle

I don't think the problem is related to babel. This code is related to Intl polyfilling. I was polyfilling even if Intl was present. Now, I've updated the code in b7c79f44db7db07495d208c045fe7f41cc8391fb. Try doing a fresh install now and let me know if the problem still persists?

Awesome, thanks @somus. I'm up and running now!


[Filters] Store filter as comp instance

Notes for Reviewers
This PR fixes #
Signed commits

[x] Yes, I signed my commits.

@MUzairS15 Let's discuss this on Meshery Dev call. Please add this as an agenda item in the meeting minutes if you would. :)

Merging this. // @Abhishek-kumar09


Issue with execution of the script

I have problem with execution of the script.
I have uploaded script onto: http://domain.ru/example/Phantomjs/:
I am trying to

use index.php to get screenshot of the page (enter url of the page to the form ,etc) , however it just reloads the page and nothing else.
use shot.php with different parameters, however it does not work as well. Also it seems that shot.php has error(s), however I cannot see them.I tried ini_set('display_errors', 1) and error_reporting(E_ALL) at the beginning of the page, however none of the errors appeared.

Am I correct that command chmod +x bin/phantomjs is the same if I will do 0655 file permission for the file? I tried to make permission of chmod via the SSL connection to my server and seemed to change them (as it did not show any errors, when I was doing it). But I am not sure how to check if chmod of phantomjs file has changed to +x.
PS. exec() function is enabled.
Please help me to solve this issue.
Thank you in advance.

Hello @bologer
Have you solved the problem? Does it still persists?

@MASNathan hello, no. I even tried to contact the owner of the plugin, however he did not reply.
Have you find any solution?

The lib has been changed to OOP. You can try the following:
// run $ composer require microweber/screen

require_once 'vendor/autoload.php';

$websiteUrl = 'https://github.com/microweber/screen';
$fileLocation = 'screen.jpg';

$screen = new Screen\Capture($websiteUrl);
$screen
    ->save($fileLocation, true);

You should also try to change the file permittions to 755. Here is a quick explanation [Understanding File Permissions] (https://www.maketecheasier.com/file-permissions-what-does-chmod-777-means/) .
If that still doesn´t work, check your PHP version and use this lines on the top of the file to do some debugging
error_reporting(E_ALL);
ini_set('display_errors', 1);


Patchy scrolling - Lags a bit when scrolling

VSCode Version: Code 1.7.2 (7ba55c5860b152d999dda59393ca3ebeb1b5c85f, 2016-11-21T22:06:37.428Z)
OS Version: Windows_NT ia32 10.0.14393
Extensions:

Extension
Author
Version

vscode-clang
mitaki28
0.2.1

Steps to Reproduce:

Just scroll up and down in the editor.

Twas a duplicate - Not sure how to delete


AR Fails to launch on IOS Chrome browsers

Using the example as found in https://plattar.docs.stoplight.io/web-sdk/plattar-ar-adapter/getting-started/launch-ar-button works on IOS Safari browsers however it fails to launch AR on IOS Chrome browsers and falls back to printing the QR Code.

Confirmed testing results

Confirmed working on Chrome Browser on Iphone device
Confirmed working on Safari Browser on Iphone device
Confirmed working on Chrome Browser on Android device (no regression)

This issue can now be closed.