Improvements to import document / troubleshooting

Graeme reported an issue where document import hung while reading / updating the DB, causing some downstream problems when the document was re-imported.
It would be nice to add some troubleshooting and robustness code to the document import section of the code. Some ideas:

Adding a timeout value, so that the user isn't stuck on a hung import screen (might need to be adjustable).
Alternately -- a way for users to cancel the import if it's hanging
If the import operation fails the timeout / is cancelled, rolling back the import
Better / more fine-grained status updates when importing (e.g., reporting the number of batches created / returned if possible)

Hi Erik,
I’m trying to remember other apps where a potentially “hangable” process is running, but haven’t recalled any specific examples.
Would it be possible to have a small window / pane / popover that had a text summary that provided a bit of progress information along with a Cancel button?
The verse number would change as each verse is completed. The user would have a reasonable indication of how long it would take, and would easily see if the import had hung.
Hope this idea helps,
Graeme

On 3 Feb 2023, at 03:28, Erik Brommers @.***> wrote:
Graeme reported an issue where document import hung while reading / updating the DB, causing some downstream problems when the document was re-imported.
It would be nice to add some troubleshooting and robustness code to the document import section of the code. Some ideas:
Adding a timeout value, so that the user isn't stuck on a hung import screen (might need to be adjustable).
Alternately -- a way for users to cancel the import if it's hanging
If the import operation fails the timeout / is cancelled, rolling back the import
Better / more fine-grained status updates when importing (e.g., reporting the number of batches created / returned if possible)
—
Reply to this email directly, view it on GitHub https://github.com/adapt-it/adapt-it-mobile/issues/479, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACLAQIAPI3EDAZIB2KF7ZUDWVPOD5ANCNFSM6AAAAAAUPHUVCI.
You are receiving this because you are subscribed to this thread.

This is kind of an open-ended issue (yeah, my fault for writing it up that way!). Here's what was done to improve document import:

Adding a timeout value, so that the user isn't stuck on a hung import screen (might need to be adjustable).
Not done (see next item)

Alternately -- a way for users to cancel the import if it's hanging
Done. Added a Cancel button to the import screen

If the import operation fails the timeout / is cancelled, rolling back the import
Partially done. The issue here is that the version of SQLite we rely on does not do rollbacks. So if the document has not started importing, no items are added to the database; but if Adapt It Mobile has started adding items to the database, it needs to delete the entire book. This means that merges can be particularly dangerous -- if hung/cancelled, they will delete the old book altogether!
This is probably something to revisit in the next release. It might be possible to duplicate the book in the database before the merge attempt: if it fails, AIM uses the saved duplicate; if it succeeds, the saved duplicate can be removed.

Better / more fine-grained status updates when importing (e.g., reporting the number of batches created / returned if possible)
Done. Adapt It Mobile batches the document in groups of 10,000 source phrases (roughly 10,000 words), so the number of batches will vary from document to document. However, Adapt It Mobile now lists the total batches in the document as well as the number of batches that have completed the import (e.g., "3 of 8 batches completed.")


Not working

Hi,
with the HC-SR04 ultrasonic distance sensor and the pxt.microbit,org editor for the BBC Microbit the Package don't work.
The output is always "0".
The hardware works fine (tested with an Arduino Uno)
Shure that this package should work?
Best regards

HC-SR04 works with 5V, microbit works with 3V - are you powering the HC-SR04 with 5V and reducing the voltage on the "echo" output with resistors or other from 5V to 3V?

No, i didn't. I'm sorry, thanks for the hint! ;) I will try this.

So here is one with 3V (if any one is interessted)
http://www.ebay.de/itm/3V-5-5V-HC-SR04-Ultrasonic-Module-Distance-Measuring-Sensor-for-Arduino-UNO-MCU-/381496724507


Add subscriptionValidation toggling capability to apk-conf

Purpose

Related to https://github.com/wso2/apk/pull/1783

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (efb1c39) 25.68% compared to head (98d2e66) 28.40%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1847      +/-   ##
==========================================
+ Coverage   25.68%   28.40%   +2.72%
==========================================
  Files         134       61      -73
  Lines       15100     4150   -10950
  Branches     2453     2208     -245
==========================================
- Hits         3879     1179    -2700
+ Misses      11090     2971    -8119
+ Partials      131        0     -131

Flag
Coverage Δ

adapter
?

common-controller
?

config-deployer-service
28.40% <ø> (+0.02%)
:arrow_up:

idp-domain-service
?

router
?

Flags with carried forward coverage won't be shown. Click here to find out more.
see 75 files with indirect coverage changes

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Implement monitoring of new emails

Resolves #4
This PR implements notifications of unread emails.
The emails are marked as seen when discovered, because you would not want to be notified every minute that there is new mail. The default check my email intent will not mark them as seen.
The monitoring is implemented via repeating events and will therefore look for new mail every 60 seconds.
When stopping mycroft and reopening again, the notification settings are preserved and the skill will continue to look for new mail if it was instructed to do so.
It's also possible to supplement an email-address or name and the skill will only notify of emails by that sender. However you have to speak very clearly to get a good speech to text translation for emails.
Signed-off-by: florian<EMAIL_ADDRESS>

It's not possible to collect arguments with intent_file_handlers, e.g. "tell me when I get an email from bob" is impossible without intent builders
Will change that so it can accept emails and sender names. They should be matched case insensitive and when it's part of a name, e.g. Bob Smith will be matched by bob.
What is your preferred method for doing that? I don't know of another way than polling.

I don't know when I'll be able to do this, but will probably start working on this tomorrow.

Thanks for responding.

Yes it is:
In a .intent file:
tell me when I get email from {name}
Then, in the intent:
name = message.data.get("name")
The fuzzy matching method might help with this: Mycroft Core docs
Sorry for not making this clear - polling is a great way to find unread email - I just didn't think about enabling polling and having an intent for that - just about tell me when I have email from bob without the enable polling intents

I hope I addressed most of your concerns.
However I still could not figure out how you expected the intent to work?

If you've only got tell me when I have email from bob, how would you turn it off, if you don't want to be notified anymore?

Oh, sorry I forgot about that.
Keep the intents - just take out the parts of looking for all new messages.
Thanks!

I'd like to get notified of every email (I get very few mail).
What is the reason you want it removed? If you'd want it to be more explicit (e.g. Hey mycroft, look for **all** new mail), that would be possible too.

Okay, thanks I'll merge this now, but I'm going to merge it into a feature branch, because I want to clean a few things up before I upload it to the skill store.
Thanks again for this!


AQCU-785: "Secondary" TS Nomenculture Modification

Modified the UV Hydrograph R code to remove all instances of "Secondary" TS and replace them with "Reference" (or "Upchain" in the case of the Q Hydrograph) and added code for rendering the "Upcahin" TS in the same manner as "Reference."

Coverage decreased (-9.4%) to 77.99% when pulling 4adf8cecc63a325b3b92ac6ed47fa84e3f0aa498 on zmoore-usgs:feature/nomenculture-modification into a55155790c81cdd9e6579b98708ba180f16fd520 on USGS-R:master.

I'm not quite sure I wanted to go this far on the renaming @lindsaycarr and @zmoore-usgs. We just wanted to be able to consume the new incoming parameters (upchain and reference params), but still place them on either the primary and/or secondary plots. That is, in our code, we should still have two plots (primary/secondary), and our logic should pick and choose where to place upchain and reference series.

Ok, I thought that is where we had left that discussion but I thought I might have missed a change last week. So really the only difference in our R code is where it is referencing the name of data within the JSON because that name will be different now.

That is correct, for now we would like to plot either/or upchain/reference json fields onto the secondary plot. We have upcoming work dynamically choose the primary/seconary plot for the reference json, but that can be ignored for now.

Oh okay, the wording on the ticket made it sound like the renaming of all "secondary" to "reference" should continue into the R code but yeah having one function to handle both with just a little added logic definitely makes sense to me. I'll make those changes, thanks for the feedback!

Yeah, I don't remember if the ticket was updated based on our discussion on 8/4 or not

Coverage decreased (-8.7%) to 78.654% when pulling 26438ddca26fcb245e532fda102c222d5a7eb8e7 on zmoore-usgs:feature/nomenculture-modification into f72f29a0d1a1f6bf65d5a26b847e563d3515b141 on USGS-R:master.

Coverage decreased (-0.7%) to 86.664% when pulling a8a1fbc1826d3c2c8d6ed343944280262b6bc645 on zmoore-usgs:feature/nomenculture-modification into f72f29a0d1a1f6bf65d5a26b847e563d3515b141 on USGS-R:master.

Coverage decreased (-0.7%) to 86.664% when pulling 87248d7e5fc5f25d6c9dac323233a6d7823a0144 on zmoore-usgs:feature/nomenculture-modification into f72f29a0d1a1f6bf65d5a26b847e563d3515b141 on USGS-R:master.

:+1: just want to get clarification on the logic for determining whether or not to render a plot based on what data is present. Then, good to go! So, I'll pass to PT since he has more knowledge about that :)

Coverage decreased (-0.7%) to 86.647% when pulling ed9ea102224d5368bd4a209d5b618727e82bea28 on zmoore-usgs:feature/nomenculture-modification into f72f29a0d1a1f6bf65d5a26b847e563d3515b141 on USGS-R:master.


OK-2568-optimize error tips when updating firmware

What does this implement/fix? Explain your changes.
optimize error tips when updating firmware
Does this close any currently open issues?
OK-2568 OK-2649
Pull request type

Put an x in the boxes that apply

[] Bugfix
[ ] Feature
[ ] Code style update (formatting, renaming)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] Documentation content changes
[x] Other (please describe):

Where has this been tested?
local
Any other comments?
none

描述上面那条review的评论不认...好矬...
[OK-2568]


hi

How to install in Kali Linux
启动 afrog 出错，rerverse CeyeApiKey or CeyeDomain is Empty in your /home/[yourname]/.config/afrog/afrog-config.yaml
thx

Open the website http://ceye.io/ and register an account, CeyeApiKey and CeyeDomain  in your account profile.
vim ~/.config/afrog/afrog-config.yaml， edit api-key and domain

┌──(kali㉿kali)-[~]
└─$ /home/kali/Desktop/afrog_linux_amd64 -t http://testphp.vulnweb.com/ -o result.html
A tool for finding vulnerabilities - afrog V1.2.2
Default Conf  /home/kali/.config/afrog/afrog-config.yaml
Default Pocs  /home/kali/afrog-pocs v0.0.1
输出文件  result.html
442/442 | 100%
is invulnerable?

sorry, afrog does not support scanning for generic vulnerabilities, Acunetix Web Vulnerability Scanner(AWVS) does a better job.
afrog is good at scanning non-universal vulnerabilities, such as CVE, CNVD, etc., to make up for the shortcomings of AWVS


Do not report setting initial values for fields that are not in the census year

Code added. Deployed to test3

@geoffj-FUG if you have tested this, can you confirm and comment here.

Rich
I have now tested the broad functionality of CSVProc using 1871 and have extended this to the other years (I expect the same results but it has to be done). This all looks OK. Any problems can be handled within the testing regime.
This story can therefore be closed.
Geoff
From: Rich Pomfret<EMAIL_ADDRESS>Sent: Tuesday, 7 July 2020 2:17 AM
To: FreeUKGen/FreeCENMigration<EMAIL_ADDRESS>Cc: geoffj-FUG<EMAIL_ADDRESS>Mention<EMAIL_ADDRESS>Subject: Re: [FreeUKGen/FreeCENMigration] Do not report setting initial values for fields that are not in the census year (#896)
@geoffj-FUG https://github.com/geoffj-FUG  if you have tested this, can you confirm and comment here.
—
You are receiving this because you were mentioned.
Reply to this email directly,  https://github.com/FreeUKGen/FreeCENMigration/issues/896#issuecomment-654333257 view it on GitHub, or  https://github.com/notifications/unsubscribe-auth/AKCPIFNLE3M773GTYIXGXADR2H2GXANCNFSM4NMVSPKA unsubscribe.  https://github.com/notifications/beacon/AKCPIFKV4HPNZU4G3ZCTRGLR2H2GXA5CNFSM4NMVSPKKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOE4AFKSI.gif


Add style & className props support

As a developer I need a possibility to style root element over usage style and className properties.

Hi @ljharb! Please review and give me a feedback, when you have time! Thanks!

Similar to #12; #13, #8, #2.

Thanks for feedback @ljharb! Looks like it worth checking closed PR's before submitting a new one. Sorry, my bad.

No problem at all! Sorry we couldn't accommodate you.

Do you think it would make sense to refactor this component to avoid rendering a DOM node and use forwardRef instead? (obviously this would be a breaking change)

@lencioni i'm not sure how that would help if the wrapped component didn't directly render a DOM node - i don't think introducing a requirement that everything OutsideClickHandler wraps is either a DOM node or a forwardRef would be worth it.

Yeah that makes sense. Perhaps it could be added as an option, so folks who want this type of control can opt in to it safely?

I don't think the added complexity of such an option is really worth it - either way this is something we should discuss on a separate issue; it's off topic for this PR.


Can't compile bevy

Compiling bevy for the web fails, but works using wasm-pack, unless CARGO_TARGET_DIR is set to web-target. I've made a minimal example. Seems like something about the target dir causes certain builds to fail, but I haven't been able to figure it out yet.
The error messages are a bunch of messages like this:
  error[E0433]: failed to resolve: use of undeclared crate or module `imp`
    --> /Users/username/.cargo/registry/src/github.com-1ecc6299db9ec823/libloading-0.6.7/src/lib.rs:66:20
     |
  66 | pub struct Library(imp::Library);
     |                    ^^^ use of undeclared crate or module `imp`

Hi @edmellum. I've tried building your minimal example, and I agree it doesn't compile. However, it doesn't work for me when I tried to build it using wasm-pack directly either, so I'm not sure if web-bundler is really the problem here.
As far as I can see, the problem is that Bevy, with all of its features enabled, doesn't compile for WebAssembly. Some libraries it depends on, like libloading which isn't compiling in your example, don't really make sense in WebAssembly.
I found this example of building Bevy to WebAssembly: https://github.com/mrk-its/bevy_webgl2_app_template/blob/master/Cargo.toml. Importantly, it includes default-features=false in its Bevy dependency and then manually turns on different features for the 'web' and 'native' versions.

I'm sorry you're totally right! My minimal example was way too minimal and doesn't match my project at all, the errors didn't even match my project, I don't know what I was thinking. I've updated it now and the errors completely match my project while still compiling with wasm-pack if cding into the frontend directory and running wasm-pack build. A bunch of errors like this from glam:
error[E0119]: conflicting implementations of trait `std::hash::Hash` for type `f32::vec4_mask::Vec4Mask`:
    --> /Users/username/.cargo/registry/src/github.com-1ecc6299db9ec823/glam-0.11.3/src/f32/vec4_mask.rs:23:64
     |
  23 | #[derive(Clone, Copy, Default, PartialEq, Eq, Ord, PartialOrd, Hash)]
     |                                                                ^^^^ conflicting implementation for `f32::vec4_mask::Vec4Mask`
  ...
  65 | impl hash::Hash for Vec4Mask {
     | ---------------------------- first implementation here
     |
     = note: this error originates in a derive macro (in Nightly builds, run with -Z macro-backtrace for more info)

I've noticed glam 0.11.3 has a build.rs file that I thought might mess with the target directory in a hardcoded fashion, but it looks very benign.

Ok! I'm now getting the same result as you. It works with wasm-pack directly, but not with web-bundler :(
Interestingly, it also works for me if I set CARGO_TARGET_DIR and run wasm-pack directly.
I think the pieces of the puzzle are:

that build script, specifically the part where it sets vec4_sse2
The implementation of Vec4Mask

Specifically, it looks like these two conditions are both true, but only one should be allowed to be true at a time:
#[cfg(any(not(target_feature = "sse2"), feature = "scalar-math"))]
#[derive(Clone, Copy, Default, PartialEq, Eq, Ord, PartialOrd, Hash)]

#[cfg(vec4_sse2)]
impl hash::Hash for Vec4Mask {

I've found that this seems to work when you build in release mode!
wasm-pack also fails in debug mode, but unlike web-bundler its default is release.

Actually, nevermind that last point. It works in web-bundler if you happened to run it in wasm-pack with that configuration first :facepalm: Similarly, it failed in debug mode with wasm-pack for me because I'd previously run it in debug mode with web-bundler.
I think it's probably something to do with it running that build script with a different target in mind and then caching the result inappropriately.

@edmellum would you mind checking out the bevy-test branch and see if it works for you?
I found that some of the environment vars that Cargo sets for our backend build.rs script are leaking into the wasm build.rs scripts like Glam's. Specifically CARGO_CFG_TARGET_FEATURE is leaking through, giving Glam a very strange view on if SSE2 is actually available or not.
My proof of concept is pretty rough. I just unset a few vars before calling wasm-pack. It works for me, but I'd like to confirm it works for you too before cleaning it up to merge into the main branch.

Awesome work! 😃 My app compiles with the bevy-test app! It sounds like nested build.rs files makes for some interesting issues and your branch sets the direction for dealing with it in a great way while solving this specific issue. 👏

Thanks @edmellum. I've generalized the fix and cleaned it up a bit, and merged it into the main branch. I'll be making a 0.1.4 release to crates.io soon with the fix.


Support for Rx PL commands [enhancement]

I have X10 RF device talk to PL device
Status message looks like below
02/13 23:54:28 Rx PL HouseUnit: A1
02/13 23:54:28 Rx PL House: A Func: On
Is it possible to support this?

I manage to enhance this, please see below changes
import pickle
...
    elif line[15:20] == 'Rx PL':
        # decode PL message. format is:
        #   02/13 23:54:28 Rx PL HouseUnit: A1
        #   02/13 23:54:28 Rx PL House: A Func: On
        line_list = line.split(' ')
        if line[21:27] == 'HouseU':
            house_code = line_list[5]
            with open ('/root/.house_code', 'wb') as f:
                pickle.dump(house_code, f)
        else:
            house_func = line_list[7]
            with open ('/root/.house_code', 'rb') as f:
                house_code = pickle.load(f)
        return house_code, {'func': house_func}, 'powerline'

@dony71
Thanks for posting this - I didn't see a git repository with your modified code - have you considered coding this as a fork?
I made the modifications described, but I still am not seeing any posting in my X10 broker. I tested by posting from mosquitto and a different computer, but unfortunately I don't have any X10 RF devices to test whether the main code is working, so I am not sure whether I am having issues in the main code or my modifications. (Also there are no errors logged in the mochad_dispatch logfile)
Any suggestions on how you got it working?

here we go https://github.com/dony71/mochad_dispatch
sorry, took a while for me for having time to do this


WIP: linger

TBA

This works flawlessly until after the user launches a prelaunched instance. Basically, the problem is that only instances that were NOT originally started with prelaunch are able to prelaunch another at app startup.
Ex: User opens the app for the first time, closes it, and reopens the app. The copy prelaunched by the first app instance launches very quickly like we want. During this copy's activation redirection, it goes through the OnLaunched method in App.cs again--where it invokes the FullTrust component to initiate another prelaunch. Unfortunantely, the app never is launched in the background and closing it leaves the user with no prelaunched app instance to redirect to (causing the slower startup)

This could be because there still might be an instance with a Key == "PrelaunchedInstance" that wasn't unregistered properly and our multi-instancing code [as a result] wouldn't try to prelaunch another copy.

I'm honestly stumped for now.
Any ideas from org members are welcome. Feel free to reach out through the necessary internal channel if needed.

/azp run

Pushed some changes I have yet to test: idea is to use CoreWindow_Activated to launch a new Prelaunch instance when the old one has been opened.

/azp run

It looks like "continue where you left off" is broken.

I think continue where you left off shows "old" open tabs (tabs that were open when the prelaunch instance was set up). We might need to delay loading tabs until instance is actually open?

I think continue where you left off shows "old" open tabs (tabs that were open when the prelaunch instance was set up). We might need to delay loading tabs until instance is actually opened?

Agreed 👍

Uops sorry for the force-push, I forgot this is not one of my branches 😅.
In any case latest commit removes the calls to "TerminateUwp" as @duke7553 did in the beginning as they appear to cause issues with prelaunch in Release mode.
Unfortunately this brings back an old issue were multiple suspended instances remain in Task Manager if you open Files from the taskbar or command line..


Converting live streams to VOD when an event ends

Have you read the FAQ and checked for duplicate issues: Yes
What version of Shaka Player are you using: 2.2.2
Can you reproduce the issue with our latest release version: Yes
Can you reproduce the issue with the latest code from master: yes
Are you using the demo app or your own custom app: Demo app
What browser and OS are you using: ANy (example, Chrome - Ubuntu)
What did you do?
Load a event dash playlist, see the current time and endtime before end and until the end of the event.
What did you expect to happen?
Before end:

duration: 87127900.361602
currentime:<PHONE_NUMBER>

End of event:

duration: 100000 (100 seconds)
currentime: 100000 (100 seconds)

What actually happened?
Before end:

duration: 87127900.361602
currentime: 87127900.361602

Sample:
Before to event end:
<?xml version="1.0" encoding="utf-8"?>

<MPD
  xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
  xmlns="urn:mpeg:dash:schema:mpd:2011"
  xsi:schemaLocation="urn:mpeg:dash:schema:mpd:2011 http://standards.iso.org/ittf/PubliclyAvailableStandards/MPEG-DASH_schema_files/DASH-MPD.xsd"
  type="dynamic"
  availabilityStartTime="2015-01-01T00:00:00Z"
  publishTime="2017-10-05T10:14:23.867179Z"
  minimumUpdatePeriod="PT2S"
  timeShiftBufferDepth="PT3M20S"
  maxSegmentDuration="PT3S"
  minBufferTime="PT0S"
  profiles="urn:mpeg:dash:profile:isoff-live:2011,urn:com:dashif:dash264">
  <Period
    id="1"
    start="PT0S">

Just to event end:
<?xml version="1.0" encoding="utf-8"?>

<MPD
  xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
  xmlns="urn:mpeg:dash:schema:mpd:2011"
  xsi:schemaLocation="urn:mpeg:dash:schema:mpd:2011 http://standards.iso.org/ittf/PubliclyAvailableStandards/MPEG-DASH_schema_files/DASH-MPD.xsd"
  type="dynamic"
  availabilityStartTime="2015-01-01T00:00:00Z"
  publishTime="2017-10-05T10:14:23.867179Z"
  minimumUpdatePeriod="PT2S"
  timeShiftBufferDepth="PT3M20S"
  maxSegmentDuration="PT3S"
  minBufferTime="PT0S"
  profiles="urn:mpeg:dash:profile:isoff-live:2011,urn:com:dashif:dash264">
  <Period
    id="1"
    start="PT0S">

I can't spot the difference between the two xml snippets in your description of the problem.  Are they identical?  Can you help us understand what we're supposed to see from those?
Also, it would be really helpful if you could provide a way for us to reproduce your issue.  A manifest URI is generally needed to reproduce issues that depends on a specific piece of content or type of content.

Sorry, I copy the mpd wrong.
The case it's the same as the EVENT playlist in HLS. It's used for sport events or live events (news, music, ...).

So it seems that the issue is in how we handle the conversion from dynamic, live streams to static, VOD streams.  We will look into it, but a way to reproduce this would be very helpful.

@avelad Could you send us the content you are using via<EMAIL_ADDRESS>so that we can reproduce this issue? Without it we won't be able to effectively look into this.

I'll try to get a sharable url, but i need some days.

@avelad Thanks. Once you get us content that we can use, we will take a look into this.

Hi @vaage , the stream to test is:
https://cdn.demo.anevia.com/nPVR/eds/StarsTV/miradash/StarsTV.mpd?begin=1508156633&end=1508156700
You need change the begin and end parameters by the correct unix time (max 10 minutes between begin and end around the current hour)

First your content has a lot of gaps in it (missing segments), which isn't a problem, but a bad user experience.  Second, your manifests include segments that aren't inside the availability window.  This means the first segment in the list is before timeShiftBufferDepth in the past.  Currently we will don't support this, but I will fix that.
The problem when ending is that the times for live segments aren't the same as for VOD segments.  When it is a live stream, the segment times are based on availabilityStartTime, which makes the segment times large (e.g. 88278328).  Once it becomes VOD, you use presentationTimeOffset to adjust the segment times to start at 0.  This changes the segment times, which would require us to seek and rebuffer.
Do you know the duration of the live stream ahead of time?  Will the whole live stream be playable once it becomes VOD, or just part of it?  We support something called in-progress recordings.  These act like live streams while they are being recorded, but become VOD at the end.  To do this, set the mediaPresentationDuration at the beginning and have the availabilityStartTime be the start of the stream so the segment times start at 0 (which you should be doing anyway).  Then once the recording ends, you can just drop off the live attributes and it will become VOD.
If you don't know the duration ahead of time, it may still be possible.  If you start the availabilityStartTime when the stream starts so the segment times start at 0, then once it ends the segment times don't change.  But this only really works if the whole live stream will be available once it becomes VOD.  Trying to only use the last few minutes would require much more work on our part.

Could you clarify which do you mean by knowing the duration of the live stream?
We cannot change availabilityStartTime to 0 because it's impact on CDN hints. The same segment are used on live and for this feature.

What I mean is the segment times should start at 0 and availabilityStartTime should be when the live streams starts.
For example, let's say you start streaming at 8:00.  The first media segment should have a time of 0 and the availabilityStartTime should be 8:00.  You then have a normal live stream for 2 hours; after that, you stop the stream.  You now have a VOD clip that is 2 hours long and starts at 0.  This is how in-progress recording work.  This should work even if you don't know that you'll be streaming for 2 hours.
However, this case won't work for something like a TV channel which runs for days and then you only want to keep the last hour of the stream.

After check our specs, we have the last case "this case won't work for something like a TV channel which runs for days and then you only want to keep the last hour of the stream." We have a buffer of 8 hours, but the events duration is less than 8 hours.

The availability window change has been cherry-picked to v2.2.4.

@joeyparrish , I lost the track of this issue, but i see that has been deprioritized to backlog, why?
Note: I see the same behaviour on HLS with EVENT playlist.


Show current subscription and command sample to change default subscription if command fail with error no permission or resource not exist

Is your feature request related to a problem? Please describe.

Describe the solution you'd like

https://dev.azure.com/azuretracking/Azure tracking/_workitems/edit/1313
Show current subscription and command sample to change default subscription should be implemented as a common function for the errors like no permission or resource not exist.
Describe alternatives you've considered

Additional context

add to S172


Unable to communicate with the OpenAI server - due to certificate verification error [SSL: CERTIFICATE_VERIFY_FAILED] certificate verify failed: self-signed certificate in certificate chain (_ssl.c:1006)

Describe the bug
Error: Cannot process your request due to Exception: OpenAI API request failed to connect: Connection error.
Traceback (most recent call last):
File "/root/miniconda3/envs/taskweaver/lib/python3.11/site-packages/httpcore/_exceptions.py", line 10, in map_exceptions
yield
File "/root/miniconda3/envs/taskweaver/lib/python3.11/site-packages/httpcore/_backends/sync.py", line 168, in start_tls
raise exc
File "/root/miniconda3/envs/taskweaver/lib/python3.11/site-packages/httpcore/_backends/sync.py", line 163, in start_tls
sock = ssl_context.wrap_socket(
^^^^^^^^^^^^^^^^^^^^^^^^
File "/root/miniconda3/envs/taskweaver/lib/python3.11/ssl.py", line 517, in wrap_socket
return self.sslsocket_class._create(
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/root/miniconda3/envs/taskweaver/lib/python3.11/ssl.py", line 1108, in _create
self.do_handshake()
File "/root/miniconda3/envs/taskweaver/lib/python3.11/ssl.py", line 1379, in do_handshake
self._sslobj.do_handshake()
ssl.SSLCertVerificationError: [SSL: CERTIFICATE_VERIFY_FAILED] certificate verify failed: self-signed certificate in certificate chain (_ssl.c:1006)
The above exception was the direct cause of the following exception:
Traceback (most recent call last):
File "/root/miniconda3/envs/taskweaver/lib/python3.11/site-packages/httpx/_transports/default.py", line 66, in map_httpcore_exceptions
yield
File "/root/miniconda3/envs/taskweaver/lib/python3.11/site-packages/httpx/_transports/default.py", line 228, in handle_request
resp = self._pool.handle_request(req)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/root/miniconda3/envs/taskweaver/lib/python3.11/site-packages/httpcore/_sync/connection_pool.py", line 268, in handle_request
raise exc
File "/root/miniconda3/envs/taskweaver/lib/python3.11/site-packages/httpcore/_sync/connection_pool.py", line 251, in handle_request
response = connection.handle_request(request)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/root/miniconda3/envs/taskweaver/lib/python3.11/site-packages/httpcore/_sync/connection.py", line 99, in handle_request
raise exc
File "/root/miniconda3/envs/taskweaver/lib/python3.11/site-packages/httpcore/_sync/connection.py", line 76, in handle_request
stream = self._connect(request)
^^^^^^^^^^^^^^^^^^^^^^
File "/root/miniconda3/envs/taskweaver/lib/python3.11/site-packages/httpcore/_sync/connection.py", line 156, in _connect
stream = stream.start_tls(**kwargs)
^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/root/miniconda3/envs/taskweaver/lib/python3.11/site-packages/httpcore/_backends/sync.py", line 152, in start_tls
with map_exceptions(exc_map):
File "/root/miniconda3/envs/taskweaver/lib/python3.11/contextlib.py", line 155, in exit
self.gen.throw(typ, value, traceback)
File "/root/miniconda3/envs/taskweaver/lib/python3.11/site-packages/httpcore/_exceptions.py", line 14, in map_exceptions
raise to_exc(exc) from exc
httpcore.ConnectError: [SSL: CERTIFICATE_VERIFY_FAILED] certificate verify failed: self-signed certificate in certificate chain (_ssl.c:1006)
To Reproduce
Steps to reproduce the behavior:

Start taskweaver as per the instructions on the Github repo
Type the user query "Anything"
See error

Expected behavior
See Taskweaver iterate through the iterations to fulfill the request in the user prompt.
Environment Information (please complete the following information):

OS: WSL (W11)
Python Version 3.11
LLM that you're using: [e.g., GPT-4]

Hi, we never encountered this error before, could you provide more context? e.g., which LLMs are you using? are you using tools like ollama or litellm?

close as no more activity


add Denver Recycling drop off sites to a map (home page probably)

This is relatively simple to do through the places api.  We can create a second set of markers on the home page map that bring up recycling centers based on a text search.  What information would we want to provide and what should the second set of markers look like?

I added some preliminary example code to the recyclingDropoff branch

Here's a list of recycling centers to add to this map.


Fix build by removing deprecated default configuration

The artifact name problem was my fault—when I ported from Build.scala to build.sbt I forgot to remove the deprecated Defaults.defaultSettings. This meant that if moduleName was set before baseSettings, it got ignored. Removing the old-style default configuration fixes the build (artifact names include the prefix) and is more idiomatic than changing the project identifiers.

The build failures (403s for a Cobertura DTD while running coveralls) look unrelated to this change, but it's weird that they don't happen for Oracle's JDK 7. May be worth waiting an hour or two to see if they clear up.

Cool! I restarted the Ci build.

Coverage remained the same when pulling e9f91655fde751d0fee11f9d5c60dd6ab9616f4e on travisbrown:fix-build into e600385dad403e7e5c688271f7f061c0ec13ba67 on finagle:master.

Well that's a little better. Just restarted again.

Thanks! Merging this.


Move selected ... to end

What I did:

Some upper and lower case corrections on the tooltips.
Rearranged the buttons order in "Firewall: Settings: Normalization"
Correction for the "move to end" function for "Firewall: Rules: xxx"

Thanks for this, merged! ❤


run hooks outside of a transaction

This is required to get vacuum working in post- hooks. Pre/Post hooks can now be:

a string
a json string containing a "sql" string key and a "transaction" key

All of the following are valid:
{{ config(
    'post-hook': [
        'select 1 -- inside transaction',
        {"sql": "select 2 -- inside transaction", "transaction": true},
        {"sql": "vacuum {{ this }}", "transaction": false},
        '{{ after_commit("vacuum " ~ adapter.quote_schema_and_table(this.schema, this.name)) }}',
        '{{ vacuum(this) }} -- this is a macro which expands to a post-transaction json string'
    ]
) }}

neat, i hadn't realized we were actually working actively on this.
is it possible to do this?
post-hook:
  - {sql: "grant select on {{ this }} to db_reader", transaction: true}
  - "vacuum {{ this.schema }}.{{ this.name }}"

essentially, the first argument is always the sql and an optional second argument specifies the transaction status. most times it would be nice to just declare the sql syntax and not think about transactions at all, and i'm also nervous about adding additional configuration parameters given that we have a bit of a configuration spaghetti bowl at the moment.

yeah, i'm with you @jthandy -- doesn't really make sense to add another config arg for this. I like that idea!

I like the idea of defaulting to transaction = true. One recommendation: name this thing after_commit, it's more clear. Like:
post-hook:

"grant select on {{ this }} to db_reader"
{ after_commit: true, sql: "vacuum {{ this.schema }}.{{ this.name }}" }

@cmcarthur that makes sense, but we need this to work for pre-hooks too ;)

before_commit?

@cmcarthur @jthandy just pushed some more code... all of these are valid ways to define pre- or post-hooks:
    'post-hook': [
        'select 1 -- inside transaction',
        {"sql": "select 2 -- inside transaction", "transaction": true},
        {"sql": "vacuum \"dbt_dbanin\".\"dbt_users\"", "transaction": false},
        '{{ after_commit("vacuum " ~ adapter.quote_schema_and_table(this.schema, this.name)) }}',
        '{{ vacuum(this) }}'
    ]

Some of these macros don't belong here, but I'm using it as a proof-of-concept: https://github.com/fishtown-analytics/dbt/blob/0e6044508def2e9901a1d964861c0b678be28617/dbt/include/global_project/macros/materializations/helpers.sql

Summary, because this branch kind of morphed from its initial purpose:
This branch formalizes how hooks should work. Now, a hook is either:

a sql string
a dict in the format {"sql": sql_string, "transaction": True/False}

If a sql string is provided, the hook will run inside of the model transaction. If a dict is provided, and transaction is False, then the hook will either run before the begin or after the commit for the model transaction, depending on if the hook is a pre-hook or post-hook.
This means that commands like analyze and vacuum can now be run in post-hooks.
The dictionary syntax is a little unwieldy. Three new macros, before_begin, in_transaction, and after_commit have been added to make adding hooks easier.
With this syntax, you can define a hook that looks like:

{{ config({
    "post-hook": after_transaction('vacuum ` ~ adapter.quote_schema_and_table(this.schema, this.name))
  })
}}

Finally, `on-run-start` and `on-run-end` hooks have been refactored to permit the same hook definition provided above. This means that you can define hook macros and use them either in run hooks or model hooks. Note that, for now, all `on-run-*` run outside of a transaction.

Fixes https://github.com/fishtown-analytics/dbt/issues/486

I think the code block above should read (as of v0.10.1):
{{ config({
    "post-hook": after_commit('vacuum ' ~ adapter.quote_schema_and_table(this.schema, this.name))
  })
}}

Thanks @ryantuck - I think you're right :)


QuickCheck driver always runs the same test

I think there is a bug with Kudzu's QuickCheck driver.  Under certain conditions, it seems to only test for a single test case even when configured to run for more than one.
See the following example:
import Kudzu

main :: IO ()
main  =  do
  print =<< testUntilSameQC 6 (\x -> x == (0::Int))

The property is obviously incorrect and states that every integer is a zero!
When running the above program, this is what I get:
+++ OK, passed 1 test.
+++ OK, passed 1 test.
+++ OK, passed 1 test.
+++ OK, passed 1 test.
+++ OK, passed 1 test.
+++ OK, passed 1 test.
+++ OK, passed 1 test.
(6,Just 0)

Meaning the tests have passed?
Investigating further with traceShow, we can see the reason.  The only test argument across all runs is 0:
import Kudzu
import Debug.Trace

prop_zero :: Int -> Bool
prop_zero x | trace ("x = " ++ show x ++ "\n") False  =  undefined
prop_zero x  =  x == 0

main :: IO ()
main  =  do
  print =<< testUntilSameQC 6 prop_zero

x = 0sts)

+++ OK, passed 1 test.
x = 0sts)

+++ OK, passed 1 test.
x = 0sts)

+++ OK, passed 1 test.
x = 0sts)

+++ OK, passed 1 test.
x = 0sts)

+++ OK, passed 1 test.
x = 0sts)

+++ OK, passed 1 test.
x = 0sts)

+++ OK, passed 1 test.
(6,Just 0)

Testing with "pure" QuickCheck hints at the underlying reason:
import Test.QuickCheck

main :: IO ()
main  =  do
  quickCheck (withMaxSuccess 1 (\x -> (x::Int) == 0))
  quickCheck (withMaxSuccess 1 (\x -> (x::Int) == 0))
  quickCheck (withMaxSuccess 1 (\x -> (x::Int) == 0))
  quickCheck (withMaxSuccess 1 (\x -> (x::Int) == 0))
  quickCheck (withMaxSuccess 1 (\x -> (x::Int) == 0))
  quickCheck (withMaxSuccess 1 (\x -> (x::Int) == 0))

+++ OK, passed 1 test.
+++ OK, passed 1 test.
+++ OK, passed 1 test.
+++ OK, passed 1 test.
+++ OK, passed 1 test.
+++ OK, passed 1 test.

For a property with an Int argument.  When run for just a single test, QuickCheck always tests with the argument "0".  This may be due to QuickCheck trying random small test cases first then progressively bigger cases.  With 1 case, at least for Int arguments, there seems to be no randomness.
Maybe Kudzu ought to call QuickCheck in chunks of a dozen or so maxSuccesses or use a more low-level internal interface to QuickCheck.  :thinking: :thought_balloon:
System information
Here are the versions used in reproducing the bug:

GHC 9.0.2
Kudzu's git main head: 0869ea1967062d64ce1a962401aa604e59b917ee
QuickCheck 2.14.3

The same behaviour seems to happen for lists, see:
import Kudzu
import Debug.Trace

main :: IO ()
main  =  do
  print =<< testUntilSameQC 360 (\xs -> xs == ([] :: [Int]))

+++ OK, passed 1 test.
+++ OK, passed 1 test.
... (357 lines omitted) ...
+++ OK, passed 1 test.
+++ OK, passed 1 test.
(360,Just 0)

Oh dear, I'm glad you found this.

Hi! I am a PhD. student and I work with Koen & John, and have recently done some work together with Nick (QC maintainer) on parallelizing QC, so I am knee-deep in the code right now. I can shed some light on this.
This is due to how QC generates test data! QC has a size parameter that tries to help you generate small terms first, and then larger ones. Initially, the size is always zero. This size increases as you pass more tests (and after you've discarded a magic number of 10 tests). Eventually it wraps around, etc.
Some generators, e.g the one for lists, starts by generating the length of the list. When the size is zero there can only ever be an empty list generated. Since this size parameter is reset every time you invoke QC, Kudzu will always use the same size (zero). Similarly for Ints, the generator for integers will generate numbers within a range, and when the size is zero the range is (-0, 0), so it can only ever generate a zero! That is why your first property holds, because the generated int is always zero in this case. If you had chosen any number /= 0, the property would always be falsified instead. Please note that in these cases it does not matter which random seed you use!
The thing here is that QC is not really meant to be rerun like this to get fine-grained stats of how it performs. It is meant to run a bunch of tests at once. You could get around this is a couple of ways.

If you could run more tests before querying the coverage, the size would vary and eventually falsify your first property.
If QC would let you specify the initial size, you could have rerun it with incrementing sizes and observe the expected behavior. The difficulty with this, currently, is that the seed is not a single counter that is manipulated. It is computed from the number of tests passed so far, and the number of tests that have been discarded since the last non-discarded test. It would take some more engineering work to the code base to actually get this working (meaning, a quick hack is not enough).

This size computation strategy is a thorn in my side, and I hope that a master student will want to do a thesis where they evaluate different strategies for this!

This is fixed by #12


Migrate completely to MeshOps V2 from MeshOps V1

Current Behavior

Currently Lifecycle page in Meshery UI invokes operations which use a stricter older method of deployment with less flexibility.
Desired Behavior

Use MeshOps V2, for all Meshery related operations, for each of Meshery's components(adapters).
Implementation

Acceptance Tests

Mockups

Contributor Guides and Handbook

🛠 Meshery Build & Release Strategy
📚 Instructions for contributing to documentation

Meshery documentation site and source

🎨 Wireframes and designs for Meshery UI in Figma
🙋🏾🙋🏼 Questions: Discussion Forum and Community Slack

Hey, @Revolyssup I would like to work on this, can you please
elaborate?


NotificationCategory.Alarm does not work on iOS

Tried NotificationCategory.Alarm, on android it repeats the sound until you click on the notification, but not on iOS, the sound is played only once.
NotificationContent(
      id: Random().nextInt(2147483647),
      channelKey: content['channelKey'],
      title: content['title'],
      body: content['body'],
      notificationLayout: NotificationLayout.BigText,
      category: NotificationCategory.Alarm,
    )

Flutter Version : 3.3.0
Awesome Notification Version : 0.7.0-beta.6+1

Got the same issue with iPhone 13 (iOS 15.5). It seems like what affected this is an app's notification setting called "Banner Style", which is set to "Temporary" by default. After manually switching it to "Persistent", this would behave as expected.
Is there any way to set the "Banner Style" to "Persistent" on runtime when the category is set to NotificationCategory.Alarm?

@WillowWisp when you manually switching it to "Persistent", the sound is played many times? I have only once, unlike android, the sound is looped there.

On iOS calls are not handle by notifications, instead they use CallKit.
Also, on iOS there is not locked / persistent notifications. According our heuristics, Awesome tries to use the maximum resources as possible to create the notifications, but if the resource does not exists, it will be ignored. And there is so differences between Android distributions as between Android and iOS, this is the best approach in most cases.


[client]: enable momentum scrolling

Client lacks momentum scrolling on markdown pages.

Solved with https://github.com/sinnerschrader/patternplate-client/releases/tag/v1.0.3


Broke a test

retest this please

retest this please

retest this please

I'm assuming we don't need this anymore; reopen it if you still need it, @ibrechin!


Properly clean up after Azure integration test

What does this PR do?
SSIA
Additional Notes

Review checklist
Please check relevant items below:

[ ] This PR includes all newly recorded cassettes for any modified tests.

[ ] This PR does not rely on API client schema changes.

[ ] The CI should be fully passing.

[ ] Or, this PR relies on API schema changes and this is a Draft PR to include tests for that new functionality.

Note: CI shouldn't be run on this Draft PR, as its expected to fail without the corresponding schema changes.

/azp run


Refresh button

Feature Request
Sometimes we can get really delayed by connection issues or twitch itself being buggy. A refresh button would be nice, I suggest leaving it near the sleep timer button.

Closed due to new Scope of the project


Can't find any releases

Hello,
Are the pre-compiled releases for this available? I can't find them on the releases tab.
Thank you

This project has minimal code for the smoothing features of niimath. I suggest using niimath.


Fix overlapping navigation buttons in docs

Fix issue with navigation buttons overlapping the body text making it hard to select the text.
This has to be in v0 as it's a docs fix and we need to publish the doc CSS from v0.
The fix was to make sure the nav buttons had a limited width smaller than the padding of the main body text.
After:

Fixes https://github.com/Microsoft/pxt/issues/3104

Awesome!  That was quick!  Thanks Sam :-)


[Question] How to refer to standard ConfigMap or Secrets resources?

Hello,
Could you please suggest a way on how to use configmap or secret values to configure jaeger-operator storage backend? Did I get it right, that per Fine-Grained Configuration both of these are not supported yet? Here is sample deployment, I would like to not expose password value here.
apiVersion: jaegertracing.io/v1
kind: Jaeger
metadata:
  name: simple-prod
spec:
  strategy: production
  storage:
    type: elasticsearch
    options:
      es:
        server-urls: http://elasticsearch:9200
        index-prefix: 'jaeger-op-'
        username: 'admin'
        password: 'sensitive'

@avoidik, I think it's the same case of #1238. I'm closing this as duplicate, but let me know if you think it's something else.


⚠ Burdi - Selfservice has degraded performance

In b4efd9d, Burdi - Selfservice (https://manage.burdi.com.au) experienced degraded performance:

HTTP code: 200
Response time: 12354 ms

Resolved: Burdi - Selfservice performance has improved in ae0fc7a.


TODO/FIXME Count 5

[ ] TODO: this call will currently send JSON/JSON-LD if it is preferred
Commit: (2c49197) Add default error handler for requested JSON/JSON-LD.
File:  lib/express.js:245
Dave Longley commented 5 years ago

[ ] TODO: rate limit
Commit: (39dba70) Update error logging.
File:  lib/index.js:214
David I. Lehn commented 7 months ago

[ ] TODO: check for 'critical' in exception chain and use that?
Commit: (39dba70) Update error logging.
File:  lib/index.js:213
David I. Lehn commented 7 months ago

[ ] TODO: document why this is only set on a GET vs. other methods
Commit: (2c49197) Add default error handler for requested JSON/JSON-LD.
File:  lib/express.js:196
Dave Longley commented 5 years ago

[ ] TODO: add mode to only log important server cause of exceptions
Commit: (39dba70) Update error logging.
File:  lib/config.js:52
David I. Lehn commented 7 months ago

Closing, opened individual issues of the items.


unzip.Extract() close event is not called

request(`https://bungie.net${manifest.mobileWorldContentPaths.en}`)
      .pipe(unzip.Extract({ path: `./manifests` }).on('close', () => {
        return fileName;
      }));

Expected result: The close event is emitted and fileName is returned.
Reality: No event is called. I've tried close, end, finish, and start and no event is ever emitted from Extract. I've tried putting it on the pipe and on Extract itself with the same result.

Not sure what was happening. Tried the same code I had and now the events are called.
All is well, thanks.


Add basic microcosm-http implementation

This commit adds an example and basic implementation of the microcosm-http library.
It leans on axios, which unfortunately uses Promises (I'd like to avoid requiring a polyfil we don't technically need). Still, axios is rock solid and works server/client side.
I've also added an onNext callback to Action, ActionButton, and ActionForm. This makes it easier to listen to a variety of action statuses, as demonstrated in the example.
There's a couple of fun things already:
Upload progress

Upload failure

Codecov Report

Merging #413 into microcosm-http will decrease coverage by 1.75%.
The diff coverage is 8.33%.

@@                Coverage Diff                 @@
##           microcosm-http     #413      +/-   ##
==================================================
- Coverage           84.88%   83.13%   -1.76%
==================================================
  Files                  45       46       +1
  Lines                1297     1322      +25
  Branches              241      246       +5
==================================================
- Hits                 1101     1099       -2
- Misses                163      187      +24
- Partials               33       36       +3

Impacted Files
Coverage Δ

packages/microcosm/src/emitter.js
100% <ø> (ø)
:arrow_up:

packages/microcosm-http/src/http.js
0% <0%> (ø)

packages/microcosm/src/addons/action-form.js
0% <0%> (-100%)
:arrow_down:

packages/microcosm/src/addons/action-button.js
100% <100%> (+100%)
:arrow_up:

packages/microcosm/src/action.js
90.9% <9.09%> (-9.1%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 40a4670...4ed079d. Read the comment docs.


MQTT Cover: Fixed status reporting for range with non-zero base

Description:
fixed issue with tilt range potentially being non-zero based
Pull request in home-assistant.github.io with documentation (if applicable): home-assistant/home-assistant.github.io#2548
Checklist:
If user exposed functionality or configuration variables are added/changed:

[x] Documentation added/updated in home-assistant.github.io

If the code communicates with devices, web services, or third-party tools:

[x] Local tests with tox run successfully. Your PR cannot be merged unless tests pass
[ ] New dependencies have been added to the REQUIREMENTS variable (example).
[ ] New dependencies are only imported inside functions that use them (example).
[ ] New dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
[ ] New files were added to .coveragerc.

If the code does not interact with devices:

[ ] Local tests with tox run successfully. Your PR cannot be merged unless tests pass
[ ] Tests have been added to verify that the new code works.

nits have been picked

Aww yissss
On May 4, 2017 9:32 PM, "Robbie Trencheny"<EMAIL_ADDRESS>wrote:
Merged #7393 https://github.com/home-assistant/home-assistant/pull/7393.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/home-assistant/home-assistant/pull/7393#event-1069918369,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABjyffSwOdbHLze6XKjOrJAzeAV7mDO5ks5r2nwwgaJpZM4NNPKc
.

Cherry-picked for 0.44.1


RFC: Temporal Filter

Preview: https://github.com/risingwavelabs/rfcs/blob/eric/0018-temporal-filter/rfcs/0018-temporal-filter.md
Migrated from https://singularity-data.quip.com/a6XXAQVa6b0N/RFC-Temporal-Filter

Seems that we will add a new field time_now in our barrier.
Do we want to collect one result per barrier, or collect multiple results per barrier?

If we collect one result per barrier, we must ensure that the time_now is greater than watermark, or the result will be meaningless.
If we collect multiple results per barrier, should we produce 2N results per barrier (given that N is num of different value in time column recently) or produce M results per barrier (given that M is num of barriers recently)?

Since we are doing a range delete for TemporalFilter, we should definitely use the delete range   interface (https://github.com/risingwavelabs/risingwave/issues/5978) for better performance.

@soundOfDestiny , am I wrong, or is time_now equivalent to the watermark? It seems we should issue time_now from meta, and ensure that all of the barriers of same epoch have the same time_now?

@soundOfDestiny , am I wrong, or is time_now equivalent to the watermark? It seems we should issue time_now from meta, and ensure that all of the barriers of same epoch have the same time_now?

yes, I think that we should issue time_now from meta, and ensure that this time_now is greater than any watermark in source.

@soundOfDestiny , am I wrong, or is time_now equivalent to the watermark? It seems we should issue time_now from meta, and ensure that all of the barriers of same epoch have the same time_now?

yes, I think that we should issue time_now from meta, and ensure that this time_now is less than latest watermark in each shard of source.

Will we also include an operator insertion_time(t) where t is table name?
So, for instance,
CREATE MATERIALIZED VIEW v AS SELECT * FROM t1 NATURAL JOIN t2 WHERE insertion_time(t1) > now() - '1h' AND insertion_time(t2) > now() - '15m'

time_now is less than latest watermark in each shard of source.

By watermark, you are referring to compaction watermark? Or watermark used in watermark filter?

time_now is less than latest watermark in each shard of source.

By watermark, you are referring to compaction watermark? Or watermark used in watermark filter?

watermark used in watermark filter

Seems that we will add a new field time_now in our barrier.

It's Optional. The epoch (int64) is designed to carry physical time with higher bits in it.

Do we want to collect one result per barrier, or collect multiple results per barrier?

Do you mean when to emit results? In my mind, if an event arrives and satisfies the time condition, it will be passed to downstream immediately. But the shifting of time is driven by barrier, so when the barriers some, some DELETE events may be emitted to delete the events that not satisfied the temporal filter condition any more.

Note that in this schemem, state cleaning and emitting delete events are independent. State cleanning is driven by Watermark message, that is, the events below the watermark will be removed from state. Emitting delete (or insert) events is driven by Barrier message, because the epoch in barriers will advance the current time (now()) and then trigger new delete or insert events to downsteam.

Seems that we will add a new field time_now in our barrier.

It's Optional. The epoch (int64) is designed to carry physical time with higher bits in it.

Do we want to collect one result per barrier, or collect multiple results per barrier?

Do you mean when to emit results? In my mind, if an event arrives and satisfies the time condition, it will be passed to downstream immediately. But the shifting of time is driven by barrier, so when the barriers some, some DELETE events may be emitted to delete the events that not satisfied the temporal filter condition any more.

I'm not sure the result at the barrier point it meaningful because it does not contain all data before time_now.

Either introducing a new TemporalFilter operator or reusing DynamicFilter looks good to me. Let's leave the choice to the implementer.

I think regardless, I'd prefer the use of now() emitting watermark, as that means that something downstream of the Dynamic/TemporalFilter can also clean its state based on the filter's timestamp field.

Either introducing a new TemporalFilter operator or reusing DynamicFilter looks good to me. Let's leave the choice to the implementer.

I think regardless, I'd prefer the use of now() emitting watermark, as that means that something downstream of the Dynamic/TemporalFilter can also clean its state based on the filter's timestamp field.

yes, it will.

Datatype of now() in batch and in streaming are now both implemented as Timestamptz.
now() in streaming will return time of the barrier epoch.
now() in batch will return time of the latest epoch that the binder saw.


index type and partial index

added support for partial indexes via WHERE keyword, postgresql, Sqlserver and sqlite
added support for index type (btree, hash, gin,..) via USING keyword, postgresql, mysql feature

Added docs and partial's support for all DBs that support them

What's missing to get this merged?

Principle looks good. It would be nice to have some tests.
Escaping/guarding of invalid values may be a good idea.

Having tests would be nice!

Written my own migration library in this time migratum
moving to golang

Somebody else should take over. Or this should be closed.

Closing until this can come up again in a future version


ios simulator doesn't print when starting observatory on port 8181

@chinmaygarde @tvolkert @johnmccutchan
When starting the ios simulator w/ a debugging port of 8181 (flutter run --debug-port=8181), we don't get a

Observatory listening on http://<IP_ADDRESS>:xxx

message. We do when we pass any other port number, or when we don't pass any port number. This asymmetry makes it harder to use a specific port (8181) for debugging, esp. as we now rely on scrapping stdout to ensure that the observatory is up and running.
I think we should change it to always print the marker text (Observatory listening on...) when a --observatory-port=xxx flag is passed.

I dont see any guards around 8181 specifically. Is this still an issue? I am not too familiar with this unfortunately.

I moved to using port 8100 to work around this. I think the guard is in the VM somewhere.

We can close this -


cargo update hangs in cargo::core::resolver::activate_deps_loop

I hit this while running "cargo update" on the master branch of https://github.com/paritytech/parity .
Trace: cargo-update.txt
Produced with RUST_LOG=cargo::core::resolver=trace cargo generate-lockfile
Cargo.lock.txt
Cargo.toml.txt

Affects both cargo 1.18 and cargo nightly 0.20.0-nightly (9fcdbb44f 2017-05-22)

Looks like the problem is that multihash depends on ring ~0.7.1 which has been yanked --> the solver never finds a solution for ring and backtracks through the entire search space.

The activation/backtracking chain seems to go something like this:
... -> isatty -> bitflags -> rpassword -> semver -> pretty_assertions -> difference -> matches -> quine-mc_cluskey -> miow -> multihash -> ring (fail)

and for each of the packages in the chain, cargo tries a few possibilities (and the chain is probably longer)

Thanks for the investigation @bennofs! In that case I'm going to close this in favor of https://github.com/rust-lang/cargo/issues/4066 as I think it's a dupe of that issue.


LoadCommands are overwritten if there is not enough space.

If there is not enough space between the start of the de-cached file and the first section_64, the load commands will be overwritten. usually, this is not an issue but for Springboard which has 200ish dylib commands, there is not enough space for extra load commands, which ObjCConvertor depends on.
From what I can tell there are primarily two ways to deal with this, somehow shift the sections or delete load commands
While I would prefer to shift the data, this would require adjusting all the code to data references, which then either require LC_SPLIT_SEGMENT_INFO (removed from DYLD) or brute force change all the ADRP instructions, likely generating some bad code.
 If the de-cached files are only used for dis-assembly, we can probably delete the dylib_commands to make room. But I really don't want to do this as it would completely destroy the pipe dream of making the files executable.

fixed by removing LC_UUID and LC_CODE_SIGNATURE, and if necessary, LC_LOAD_DYLIB. #42b5cf6


Select/Deselect all labels keyboard shortcut - text classification (feature request)

Use case: Say I want to label a text with only one label but I'm being shown all possible labels (say 10), so instead of closing one by one by hand until I have the one I want, I think it would be great to close them all in one keystroke and chose the one I need.
Do you think it could be useful?

Please raise a new issue if you want this feature. I can't figure out the useful situation for most of doccano user.


poly1305/asm/poly1305-armv4.pl: avoid conditional branch to PLT in THUMB-2

When compiling for THUMB-2, the conditional branch to PLT results in a
R_ARM_THM_JUMP19 relocation. Some linkers don't support this relocation
in THUMB-2 (ld.gold), while others can end up truncating the relocation
to fit (ld.bfd).
Adding an "it eq" before the branch converts it into an unconditional
branch, which uses R_ARM_THM_JUMP24 relocation that has a range of 16MB.
See https://github.com/android-ndk/ndk/issues/337 for background.
The current workaround is to disable poly1305 optimization assembly,
which is not optimal and can be reverted after this patch:
https://github.com/freedesktop/gstreamer-cerbero/commit/beab607d2b1ff23c41b7e01aa9c64be5e247d1e6
CLA: trivial

Editorial note. I'd say that "remove unintentional relocation" would be more appropriate subject. Because modification doesn't affect Thumb-2 exclusively and original subject is too "tech". I mean not everybody keeps those abbreviations  in "Level 1 cache" of their brains. I would also modify description as "conditional branch to global symbol results in reference to PLT and a R_ARM_THM_JUMP19 relocation". You don't have to do anything, I can do it upon commit to repo.

Thanks

Ping for 2nd review.

Merged. Thanks!


Merge branch 'branch-24.02' into main

Merge branch 'branch-24.02' into main
Change version to 24.02.0
Note: merge this PR with "create a merge commit"
Signed-off-by: Tim Liu<EMAIL_ADDRESS>

This PR is not the final merge to main change.
Draft the PR for in-advance review purpose
We'll up merge the cuDF commits after rapidsai get the v24.02.00 tagged/released.

build


feat: implement tiered smt

closes #36

We have a couple of open questions such as:

should storages always take self as immutable?
I think it should because in-memory storages should be treated as exception as we will have more robust solutions in production that will be either async or mutex/lock based

should we use as interface the serializable trait from winter-utils?
it seems to me we should introduce a new Hashable trait that will require deterministic serialization to bytes, and the ability to use the type as input for a given hasher (i.e. Rpo256)

Closed in favor of https://github.com/0xPolygonMiden/crypto/pull/45


DBZ-6659 properly declaring junit 5 dependency

Related main PR https://github.com/debezium/debezium/pull/4671

@Naros  seems I can't request a review here. Please have a look


SVG to PNG not render images in Safari browser

Hi, i have a problem with downloading svg as png in Safari. In Chrome works fine but in Safari sometimes (not every time) images in svg not rendering in final png.
https://jsfiddle.net/fvkjyLw4/
correct png (Chrome)

wrong png (Safari)

I am also able to reproduce this issue, both in my own codebase and the example from @saulacher above.
Safari: 12.1.1 (146<IP_ADDRESS>.1)
macOS: 10.14.5 (18F132)
It almost always happens on the first download. Successive downloads often yield the full svg as expected, but not always.

I experience the same problem but with tspan in text

Looking into this more, I see that Safari makes a new request for all linked assets. Here's a screenshot of the example shared by @saulacher (with the downloaded result showing in the upper right corner).
Before clicking the "Save" button, I cleared all network requests from the log. As you can see, the 3 jpgs are requested again. My sense is that these resources are not yet downloaded when the png is created and therefore, do not show in the result.
But when I click the "Save" button a second time, the 3 jpgs are not requested again and the png shows as expected.
This aligns with my own case. The parts that don't show initially are <text> elements that use webfonts. The webfonts are requested on the first click of "Save", but don't show. It takes another click to download the png in order to get the <text> elements to show in the png.
When I switch out the webfonts for a system font (Helvetica), the <text> elements show on the first png download.
Not yet sure what the solution is, but wanted to post my progress in the hopes it helps move this closer to a solution.

Update: Looks like Chrome also makes requests, but some are pulled from cache. Still confused...

I've narrowed it down to this line. From what I can find elsewhere, Safari has issues rendering linked assets when the canvas element is first drawn.
In the source, just after the line I linked to, if you run document.body.appendChild() on both canvas and src (which is an image with the svg dataURI as its src), you'll find that in Safari 12, the src image renders the fonts, but the canvas doesn't. Running saveSvgAsPng a second time shows the fonts/images rending correctly.
While it's not ideal, I've found a workaround. To force the PNG to be generated twice, but dowloaded only once, I first running svgAsPngUri and saveSvgAsPng in the returned promise's .then(). I've forked the example @saulacher posted as an example: https://jsfiddle.net/2hpok9uj/. This works in Safari. But as I said, it's not ideal.

It looks like it might be a bug in WebKit. You can file an issue here.


Polygon styling props ignored for Google Maps on iOS

Is this a bug report?
Yes
Have you read the Installation Instructions?
Yes
Environment
react-native: >= 0.51.0
react: >= 16.0.0
react-native-maps: 0.24.0
Steps to Reproduce

Download repository
Launch example project for iOS
Switch "Use GoolgeMaps?" to on
Go to "Update native props"

Expected Behavior
The shapes would respect the props (fillColor, strokeWidth, strokeColor etc.) of polygons, circles etc.
Actual Behavior
The circle has a black stroke and no fill and the polygon has a blue fill and no stroke.
Reproducible Demo
The example project in the repository can be used.

Note that using setNatvieProps on a timeout on mount eg. setTimeout(() => ref.setNativeProps(this.props), 1000) will result in the correct behaviour.

Not sure but this might be an outdated example?
I'm doing this and it works fine:
<Polygon
                style={styles.polygon}
                coordinates={this.props.coordinates}
                holes={this.props.holes}
                strokeColor={strokeColor}
                fillColor={fillColor}
/>

Maybe I don't get the issue?

@rborn strange... Would it be possible for you to check the example project and get that working? I have the exact same issue in my project as I've shown above. Works fine for everything except GoogleMaps on iOS.

@benjamin-halter I created a brand new project and all seems to work fine which makes me thing is an issue with the examples or maybe your settings?
https://github.com/rborn/rn_maps_polygons_test

@rborn thanks for that example! I can confirm this works - I noticed that you used pods to install, I however followed the manual instructions - I will try install with pods and report back the results

I can confirm that installing using CocoaPods removes the issue - may be worth updating documentation/looking into this further.
Thanks!

@benjamin-halter the docs already say how to use pods, but maybe if you feel is not explained enough you can always come with a PR to improve that and I'll happily merge it 🤗

@rborn more than happy with how the docs explain how to use pods, was more referring to highlighting the slight differences as a result of manually installing vs using pods

Just run into this, glad to know that manual installation is the cause.
The project was created with react-native init and react-native-maps was added with react-native link. The Polygon styling props are lost when enable Google Maps with manual installation process described here.
Maybe for now we should add a few lines in documentation to let people know about this issue with current manual installation process.

Is the only way to use Cocoapods? I'm facing an issue when installing with Cocoapods, where I get errors like <React/UIView+React.h> cannot be found. Manual installation works, but I encounter the above issue.

@benjamin-halter Can you please reopen this? It's still an issue for people who want manual installation.

Reopening as requested by @EskelCz. I would recommend following the Cocoapods route if applicable but agree this is an issue for those that require manual installation.

Ok I have figured out the workaround, the ref was supposed to be on the overlay shape, not the map. :) and the correct props set to it.

I am using RN 0.60 so only pods install is available.
I still don't see my styles.
I find the pods install instructions a bit unclear. My podfile is here https://github.com/fo-am/iCrapAppPro/blob/master/ios/Podfile I have attempted to merge in the maps things, tho there are differences between the podfile distributed with react native and the one in the installation instructions.
Have I missed a crucial step?

for anyone else who may be experiencing this problem and not able to resolve it: downgrading to v0.24.2 worked for us (on RN 0.60.3). We upgraded to react-native-maps 0.25.0 while upgrading to RN 0.60.3, and started having this issue. After much struggling with the problem, we just reverted react-native-maps back to v0.24.2 and everything is back to normal and working with RN 0.60.3

@JayHuang that's strange, because I'm seeing the issue on version 0.24.0, react-native 0.59.3

Same issue here.
Using RN 0.60 so only pods install is available.

I am also facing this but not always . Some times the styles are being applied correctly . I can not find any pattern or scenario to reproduce.
Using RN:0.60.3 and react-native-maps:0.25

This is what worked for me.
constructor(props) {
  super(props);
  this.circle = React.createRef();
}

<Circle
  ref={this.circle}
/>

<MapView
  onMapReady={() => this.circle.current.setNativeProps({ fillColor: "rgba(r,g,b,a)" })}
/>

I'd recommend using the onMapReady event over setTimeout in componentDidMount. Still not ideal though...

I'm also facing this issue.
Using cocoapods, RN 0.60.3 and<EMAIL_ADDRESS>I have the issue on a Polygon, even if the fillColor is set to green, from time to time it shows purple.

this still remains an issue

I have the same issue when using Circle component after upgrade react-native-maps to 0.25
I downgrade react-native-maps version to 0.24.2 and it works fine.

Suddenly, this issue happened to me.
I am aware of this issue while I upgrade from Expo SDK v33 to v35, where react-native-maps version changes from 0.24.2 to 0.25.0, and react-native version stays at 0.59.
This didn't happen when my app was Expo v33 for months, but this happens when I tried to upgrade from v33 to v35 yesterday. Strangely, this issue remains although I downgrade to Expo SDK v33.
Anyway, I was able to solve this issue by using setNativeProps, recommended by @kpl39. Thanks.
constructor(super) {
  this.circle = null;
}

onMapReady = () => {
  this.circle && this.circle.setNativeProps({
    fillColor: 'rgba(0,0,0,0.12)',
    strokeColor: 'rgba(0,0,0,0.3)',
  })
}

render() {
  return (
    <MapView
      ...
     onMapReady={this.onMapReady}
    />
      <MapView.Circle
        center={region}
        radius={distance}
        fillColor={fillColor}
        strokeWidth={0.5}
        strokeColor={strokeColor}
        ref={ref => this.circle = ref}
      />
    </MapView>
  )
}

I have the issue on a Polygon, even if the fillColor is set to green, from time to time it shows purple (the default color).

Same here, but it seems to take correct color once i navigate back to the screen. Not sure how to fix it. Any idea?

I had the same issue with Geojson component which uses Polygon as a child component. The styling props wasn't applied for IOS. I also tried given solutions but had a lot of issues with setting the ref and native props onMapReady call.
I solved my issue by having colors in the initial state as null and setting them later in the componentDidMount.  You can see the example below.
import {Geojson} from "react-native-maps";

...

constructor(props) {
  super(props);

  this.state = {
    fillColor: null,
    strokeColor: null,
  };
}

_setColors() {
  this.setState({
    fillColor: 'rgba(60, 165, 255, 0.2)',
    strokeColor: 'rgba(60, 165, 255, 1)'
  })
}

componentDidMount() {
  setTimeout(() => this._setColors(), 10)
}

render() {
  const {geojson} = this.props;
  const {strokeColor, fillColor} = this.state;

  return <Geojson
    geojson={geojson}
    strokeColor={strokeColor}
    strokeWidth={3}
    fillColor={fillColor} />
}

I'm experiencing the related problem with fillColor, strokeColor and strokeWidth on the project I'm working on with react-native-maps version 0.26.1 , as a temporal fix I applied this solution: https://github.com/react-native-community/react-native-maps/issues/3025#issuecomment-522968087
Although, on the project, we have one specific case where it's not working 100% perfect (sometimes it shows the correct styles, sometimes it doesn't), but as temporal fix, we can cope with it...
Does anybody know if this bug related with Google Maps is already being addressed and an official solution will arrive soon? If I'm not mistaken, this is happening since July 2019 (v0.25.0) :confused:

@kerembalcan I tried your solution. But i have to setTimeout for 1 second to make it work.

I opened a #3658 to correct the issue in GeoJson specifically where the stroke color, stroke width, fill color, and marker color properties were not getting preserved. Alternatively, here's a patch for 0.27.1

This issue still exists on the master branch? I am experiencing it on iOS.

Adding weight to the fact that this issue is still present on iOS with version 0.28.0 (at least for me!)


Removed isVisible prop from ValidateCodeForm

Details

Fixed Issues

$ https://github.com/Expensify/App/issues/19787
PROPOSAL: https://github.com/Expensify/App/issues/19787#issuecomment-1567986239
Tests

Logout
Enter your email and continue
Verify the magic code input is focused
Type some random digits (less than 6), go back and again click continue
Verify that magic code input is focused again and that it is empty (does not have the random numbers you entered earlier)

[ ] Verify that no errors appear in the JS console

Offline tests

Same as 'Tests' section above
QA Steps

Same as 'Tests' section above

[ ] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android / native
[x] Android / Chrome
[x] iOS / native
[x] iOS / Safari
[x] MacOS / Chrome / Safari
[x] MacOS / Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[x] I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web
Chrome
https://github.com/Expensify/App/assets/68777211/2223cd92-27ea-4174-9026-bade49096f52
Safari
https://github.com/Expensify/App/assets/68777211/cc7f3cca-f29c-40ab-80b6-8e801f55f098

Mobile Web - Chrome
https://github.com/Expensify/App/assets/68777211/aca87310-816e-470f-b6b9-667e4951da83

Mobile Web - Safari
https://github.com/Expensify/App/assets/68777211/ad9571ab-0d8f-40c1-bf9f-2138780d1719

Desktop
https://github.com/Expensify/App/assets/68777211/8663bb7c-de1b-45fa-8c9e-c8c7871614e9

iOS
https://github.com/Expensify/App/assets/68777211/3fb8887b-27b6-417d-8801-e19c8e67cc6d

Android
https://github.com/Expensify/App/assets/68777211/8dc4fe31-fd49-4105-87e9-62d284ed8f6c

@huzaifa-99 thank you for the quick PR 👍 I put a hold on the PR as we're on merge freeze right now until Wednesday.
I'll review this PR soon though

merge freeze is over. removing HOLD

@huzaifa-99 thank you for the detailed explanation. Could you kindly tell me why the autoFocus prop is not working?

@rushatgabhane can you check the message @huzaifa-99 sent above? 🙇

@huzaifa-99 i agree! Let's add a comment on why we're doing it also

@huzaifa-99 but why is this issue not happening on main?

@rushatgabhane

Question: do we still add shouldFocusDelay in the magic code and 2fa code screens

no

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

🚀 Deployed to staging by https://github.com/hayata-suenaga in version: 1.3.42-20 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to production by https://github.com/jasperhuangg in version: 1.3.42-26 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to staging by https://github.com/hayata-suenaga in version: 1.3.44-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


Tutorial Map Completion

Description
Task: Tutorial Map Completion
Feature: Tutorial Map Completion
Complete the Tutorial map by adding triggers, NPCs, and dialogue completion to ensure a seamless gameplay progression and an engaging tutorial experience.
Dependencies
NA
Milestones
List of steps that need to be completed for this task.

[x] Addition of triggers and events in the Tutorial map (Oct. 19)
[x] Making special title and dialogue boxes for the Tutorial Game Area. (Oct 18)

Completion Deadline: Oct 19
Documentation
TBD
Member

Yash Mittal (@YashMitttal} (s4823869)
Rachit Chaurasia (@rachitchaurasia) (s4823870)
Dev Gupta (@DRG31) (xdrgx)

created


Pipeline error in RTSP stream example

I'm trying to stream from an RTSP camera source with the following command:
$ gst-launch-1.0 rtspsrc location=rtsp://YourCameraRtspUrl short-header=TRUE ! rtph264depay ! video/x-h264, format=avc,alignment=au ! kvssink stream-name=YourStreamName storage-size=512
after, obviously, changing my stream name and RTSP URL and exporting the access credentials.
But this is the error I'm getting:
Setting pipeline to PAUSED ... log4cplus:ERROR could not open file ./kvs_log_configuration INFO - Initializing curl. 2018-12-14 11:45:20 [139747905300224] INFO -  createKinesisVideoClient(): Creating Kinesis Video Client 2018-12-14 11:45:20 [139747905300224] INFO -  heapInitialize(): Initializing native heap with limit size 536870912, spill ratio 0% and flags 0x00000001 2018-12-14 11:45:20 [139747905300224] INFO -  heapInitialize(): Creating AIV heap. 2018-12-14 11:45:20 [139747905300224] INFO -  heapInitialize(): Heap is initialized OK 2018-12-14 11:45:20 [139747905300224] INFO - Refreshing credentials. Force refreshing: 0 Now time is:<PHONE_NUMBER>896627750 Expiration: 0 2018-12-14 11:45:20 [139747905300224] INFO - New credentials expiration is<PHONE_NUMBER> 2018-12-14 11:45:20 [139747905300224] DEBUG - createDeviceHandler invoked 2018-12-14 11:45:20 [139747905300224] INFO -  createDeviceResultEvent(): Create device result event. 2018-12-14 11:45:20 [139747905300224] DEBUG - clientReadyHandler invoked 2018-12-14 11:45:20 [139747905300224] DEBUG - Awaiting for the producer to become ready... 2018-12-14 11:45:20 [139747905300224] DEBUG - Kinesis Video producer is Ready. 2018-12-14 11:45:20 [139747905300224] INFO - try creating stream 2018-12-14 11:45:20 [139747905300224] INFO - Creating Kinesis Video Stream vnex 2018-12-14 11:45:20 [139747905300224] INFO -  createKinesisVideoStream(): Creating Kinesis Video Stream. 2018-12-14 11:45:20 [139747905300224] DEBUG - describeStreamHandler invoked 2018-12-14 11:45:20 [139747905300224] DEBUG - Awaiting for the stream to become ready... 2018-12-14 11:45:20 [139747905300224] INFO - Refreshing credentials. Force refreshing: 0 Now time is:<PHONE_NUMBER>896828871 Expiration: 0 2018-12-14 11:45:20 [139747251971840] DEBUG - describeStream response: {"StreamInfo":{"CreationTime":1.544765892261E9,"DataRetentionInHours":24,"DeviceName":null,"KmsKeyId":"arn:aws:kms:us-west-2:354387791117:alias/aws/kinesisvideo","MediaType":"video/h264","Status":"ACTIVE","StreamARN":"arn:aws:kinesisvideo:us-west-2:354387791117:stream/vnex/1544765892261","StreamName":"vnex","Version":"aXjbGB5w0xnX4BRghlGW"}} 2018-12-14 11:45:22 [139747251971840] INFO - Discovered existing Kinesis Video stream: arn:aws:kinesisvideo:us-west-2:354387791117:stream/vnex/1544765892261 2018-12-14 11:45:22 [139747251971840] INFO - stream arn in stream_info struct: arn:aws:kinesisvideo:us-west-2:354387791117:stream/vnex/1544765892261 2018-12-14 11:45:22 [139747251971840] INFO -  describeStreamResultEvent(): Describe stream result event. 2018-12-14 11:45:22 [139747251971840] DEBUG - streamingEndpointHandler invoked 2018-12-14 11:45:22 [139747251971840] INFO - Refreshing credentials. Force refreshing: 0 Now time is:<PHONE_NUMBER>242899328 Expiration: 0 2018-12-14 11:45:22 [139747243579136] DEBUG - getStreamingEndpoint response: {"DataEndpoint":"https://s-4010bf70.kinesisvideo.us-west-2.amazonaws.com"} 2018-12-14 11:45:23 [139747243579136] INFO - streaming to endpoint: https://s-4010bf70.kinesisvideo.us-west-2.amazonaws.com 2018-12-14 11:45:23 [139747243579136] INFO -  getStreamingEndpointResultEvent(): Get streaming endpoint result event. 2018-12-14 11:45:23 [139747243579136] DEBUG - streamingTokenHandler invoked 2018-12-14 11:45:23 [139747243579136] INFO - Refreshing credentials. Force refreshing: 1 Now time is:<PHONE_NUMBER>532750987 Expiration:<PHONE_NUMBER> 2018-12-14 11:45:23 [139747243579136] INFO - New credentials expiration is<PHONE_NUMBER> 2018-12-14 11:45:23 [139747243579136] INFO -  getStreamingTokenResultEvent(): Get streaming token result event. 2018-12-14 11:45:23 [139747243579136] DEBUG - streamReadyHandler invoked 2018-12-14 11:45:23 [139747243579136] DEBUG - Kinesis Video stream vnex is Ready. 2018-12-14 11:45:23 [139747905300224] Stream is ready Pipeline is live and does not need PREROLL ... Progress: (open) Opening Stream Progress: (connect) Connecting to rtsp://admin:admin@123@<IP_ADDRESS>:554/LiveMedia/ch1/Media1 ERROR: from element /GstPipeline:pipeline0/GstRTSPSrc:rtspsrc0: Could not open resource for reading and writing. Additional debug info: gstrtspsrc.c(6775): gst_rtspsrc_retrieve_sdp (): /GstPipeline:pipeline0/GstRTSPSrc:rtspsrc0: Failed to connect. (Generic error) ERROR: pipeline doesn't want to preroll. Setting pipeline to PAUSED ... Setting pipeline to READY ... Setting pipeline to NULL ... Freeing pipeline ...
Any help/advice would be appreciated. :)

your rtsp url looks weird. Can you double check it's playable on some other players like VLC?

Yeah I checked. It's playable on vlc.

Okay so I just tried it with a sample rtsp stream from https://stackoverflow.com/questions/35067817/sample-rtsp-url-for-video-streaming and it works.
I guess it's a problem with my rtsp url then. But it works in vlc. Any ideas why this is happening?

can you try remove the @ from your password?

Closing the issue for now as the issue has been answered.


AQCU-1159: Updates to ensure that all ts attribute rows show even when no data is present

Coverage increased (+0.004%) to 98.65% when pulling bd83c2bc6510ff3e09cd72b23e41da0dbfc456d4 on zmoore-usgs:bug/show-all-details into 9253bc75eb7fae04955d10b280fbda5b529e3128 on USGS-R:master.

Coverage increased (+0.004%) to 98.65% when pulling 396cc1b24137cc0c58090f0b109f3c2d09dfad24 on zmoore-usgs:bug/show-all-details into 9253bc75eb7fae04955d10b280fbda5b529e3128 on USGS-R:master.


Add Huobi support

Hope to support the Huobi exchange in the near future. This should be easy: update ExchangeSharp. Add the Huobi request API code to the market summary (they are different).

This is in but it is very, very slow. Not even sure if it's worth the effort to be honest. OKEX has a similar issue going on as well.


python3Packages.llfuse: 1.3.6 -> 1.3.8-2020-12-04

Newer versions of pytest break llfuse.
This was fixed upstream in https://github.com/allure-framework/allure-python/issues/381
but is not released yet.
Update llfuse to upstream rather than downgrading pytest dependency.
Signed-off-by: Sirio Balmelli<EMAIL_ADDRESS>
Motivation for this change
I utilize downstream packages that depend on llfuse.
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[x] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[x] Determined the impact on package closure size (by running nix path-info -S before and after)
[] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

@siriobalmelli Thanks, but there is already a PR addressing the same issue: https://github.com/NixOS/nixpkgs/pull/106279

@bachp sorry, I missed that one while I was working on this one.
#106279 seems cleaner: instead of building from source it's patching only the test issue. Closing this.


why updating style onRest doesn't work?

DEMO on Codepen
Expect: click the cube and it goes to right 300px and then down 300px
Actual: the cube only goes right 300px
I updated the style in function onRest and it successfully sets the style, however Motion doesn't work.

BTW, what is the standard way to implement a sequence of tween using react-motion? Something like GSAP TimelineLite

hi there?

hey @lzl124631x I find that React Motion is best suited for animations that react to state changes. ie. smoothly showing or hinding a sidebar navigation, tranisitioning between views when the URL changes and similar things that are tied specifically to the state/props within a given component, where you always have the values avilable that you want to animate between.
Complex sequential stuff, where you have full control over how each animation within the sequence, is something I always rely on GSAP for. IMO it has far a superior API for that kind of stuff (Like the TimelineLite class you mention). GSAP and React Motion are two very different approaches to solving animation. I would say they are almost polar opposites. I love both of them, so this isn't trying to talk down React Motion at all, but in this particular case it seems like GSAP might be the better fit and leave you with simpler, cleaner code.

@Ahrengot Thanks for your comments.
In the first few days with React Motion, it's cool enough to help me achieve some one-step animation during state changes. However, as the project goes on, it's inevitable that I need to make some fancier sequence of animation. I think other devs might stumble into the same situation.
Is it possible to give React Motion the ability to animate a sequence of tween? For example, make the <Motion>'s style attribute accept an array of sub-styles, and React Motion just animate to the first sub-style, and then the 2nd and then ... and the last. In this way a sequence of tween is achieved. What do you think?

BTW, I'm copying the iOS App Clear in the purpose of learning React. In the video, swipe-to-right-to-mark-item-as-completed requires a sequence of tween.

Back to my original question, I think it's a bug of React Motion. Made another try. It still doesn't work demo on codepen

@lzl124631x you need to delay updating state with setTimeout/requestAnimationFrame.
See https://github.com/nkbt/react-motion-loop/blob/master/src/Component.js#L21-L23

@nkbt Wow! Thanks! It works as long as I wrap requestAnimationFrame around updating state.
Demo on CodePen

@nkbt Can you kindly tell me why delaying updating state with setTimeout/requestAnimationFrame do the trick?

Not really, maybe something to do with batch updates optimisations, but I
don't know for sure
On Thu., 10 Nov. 2016 at 12:52, 7z7<EMAIL_ADDRESS>wrote:

@nkbt https://github.com/nkbt Can you kindly tell me why delaying
updating state with setTimeout/requestAnimationFrame do the trick?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/chenglou/react-motion/issues/390#issuecomment-259580118,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAKsoA0Q5MDkoqnlS2kOcY689h6QANIBks5q8ne6gaJpZM4KqOdn
.


initialize attribute value to null

@yukinying @adon-at-work please review!
use case - https://github.com/yahoo/html-purify/pull/11#discussion-diff-34043770R98

gd. leaving this for @yukinying to merge.


Draining Mode

I hava a two nodes livekit cluster, I want these two nodes to take turns entering draining mode to achieve hot updates.
LiveKit Docs
Home -> Self Hosting -> Distributed Setup -> Downscaling-and-draining
Please tell me how to put a node into draining mode?
I have checked the relevant documentation and did not find the relevant API.

it's automatic. SIGTERM would start draining them


Fixing issue #686

Fixing issue #686

@peter279k done!

@peter279k could you please approve? Its missing 2 points to win the swag

Hi @reisraff, I've approved this, but it seems that test/unit/MailHelperTest.php` class has the conflict.
Can you fix that?

@peter279k done!

Hello @reisraff,Thanks again for the PR! It's HACKTOBERFEST! We want to show our appreciation by sending                                              you some special Hacktoberfest swag. If you have not already, could you please fill out                                              this form so we can send it to you? Thanks!                                             Team SendGrid DX

Hello @reisraff,Thanks again for the PR! We appreciate your contribution and look forward to                                              continued collaboration. Thanks!                                             Team SendGrid DX

Could you please issue a release with this fix? It has been half a year and this patch, as far as I understand, is blocking normal usage of Personalization objects.
See also https://github.com/sendgrid/sendgrid-php/issues/882 and https://github.com/sendgrid/sendgrid-php/issues/849.
Practically right now we have to construct and end custom json blobs to the API instead of actually using the library if we want to send multiple personalization objects in a proper way. Without it, sending wrong emails or an email with multiple people in the To-header is a little too easy.