Relationship fixes regarding naming conventions and displaying relationship data

The issue i am having has to do with setting up the relationships on BREAD according to the documentation here https://the-control-group.github.io/voyager/docs/v0.10/#core-concepts-bread-relationships .
According to this logic, if a have a User, and this user belongs to a Team model (whilst having a team_id in the user table) i would need to create a teamId() relationship.
And that does not sound quite right. I would also add that it's a bit counterintuitive as far as doing things the Laravel-way goes.
If i want to get the user's team, the relationship should be team() and not teamId().
After all i am getting back a Team instance from the relationship and not the id of that instance, which i can access with user->team->id().
So far basically i have the following implemented :
Override method name as @marktopper suggested
{
    "relationship": {
        "method": "team"
    }
}

Applying relationship data, options and labels correctly on Browse, Read, Create, Edit
Solve field name collision on ManyToMany Relationships by setting the options the following way
{
    "relationship": {
        "key": "sports.id",
        "label": "name",
        "method": "sports"
    }
}

I don't know how this worked before but it never worked for me correctly as the 'id' field was not unique

@marktopper Voilà
I see here the styleCI has failed and Travis is still building but perhaps if the idea is to your liking we can look at them together.

You can ignore StyleCI. That is automatically fixed on merge.
I will look into TravisCI.

As far as Style goes i made the file PSR2 compliant. Not is just complaining about white lines.
Fixed on another commit the Travis problem.
Ran test locally. They are all green.

I'm away from the computer for the moment so it'll take me a bit to clean this up but basicallt
@elseif($row->type == 'select_dropdown' && property_exists($options, 'options'))
                                            <?php echo $options->options->{$data->{$row->field}};?>

Handles the case where the input is a dropdown but with static options.
It was not being handled in the view and getting bounced to the final @else thus just showing an integer as opposed to getting that index from the options.
I did not use
{{  $options->options->{$data->{$row->field}} }}

as the blade compiler kept erroring out. Can you confirm on your end?
Anyhow, i'll add the linking and cleanup the comments (which i thought i already did but apparently i missed some) and then commit again.
Thank you for your feedback

No hurry, I am also busy for the next few hours.
Will test it out the rendering issue once I'm back along with other tests.

Managed to do it away from my laptop.
For the php echo business, i found a reference that would allow curly brackets inside blade if prefixed with @ but although i haven't tested it i think results are not what we want.
The tests do pass but may be a false positive.
If this is a blade limitation i don't know how to get around it.
Perhaps at the beginning of the file, once the json is parsed i could turn it into a collection and
access it as an array underneath to get around this.
Anyhow we'll see.
Speak soon
/best

All tested and works good.
However there seems to have been added some conflicts.
I can look into it if you do not have time for it.
NOTE TO SELF: This should be documented.

@marktopper Ah that's great.
Well later i got to freshen up the browse.blade.php as discussed with @Frondor and move the $dataTypeContent to $data have a quick look at that curly braces inside curly braces business that is nagging at me :D
That way i can fix the conflicts and push again.
Sometime in the next few hours.

Cool, ping me when ready ;)

@marktopper Turns out i got to go away for work for a couple of days and won't be able to look at the conflict before i come back.
Is there a change you could look into it? If not i'll be happy to do it when i come back.
Whatever is good for you.
Best
sid

I will look into it, enjoy your days off.

Hi.. I have tested the id to name in a fresh laravel 5.3 installation and voyager 0.10.15 but seems still not work.  the id still show id not name or description at browse section.

It works, do php artisan cache:clear | php artisan view:clear | php artisan route:clear | php artisan config:clear

Hi guys. Great that this is fixed. I'm a bit new to Voyager and don't find any documentation on how to use this? I really would like to show a label over an id in the browse view of my system.

@bjornfant, this PR was merged in 7 months ago.  If you have questions or issues, please make your own issue or ask on our Slack group

@bjornfant I'm looking for the same solution. I looked through the commits and merge requests and cannot find anything. Documentation seems lacking if this was fixed.

@chadpriddle, please don't make me repeat myself.....


How to get Arrow Schema for PostgreSQL column of hstore(map) and geometry types in JdbcToArrowUtils.jdbcToArrowSchema ?

I want to convert into Apache Arrow IPC data format in Java existing data from PostgreSQL database.
JdbcToArrowUtils.jdbcToArrowSchema allows do it for scalar types and arrays.
org.postgresql.jdbc.PgResultSetMetaData instance from PostgreSQL jdbc driver provide all required info related to column types pgResultSetMetaData.getColumnTypeName().
But looks like current implementation support only ArrowType.List  with no support of Map type mapping in code
How to get Apache Arrow schema and transform data into Arrow for hstore(map) and geometry database column types?

I don't think it's possible; while you can override the conversion from JDBC type to Arrow type, the supported Arrow types are hardcoded: https://github.com/apache/arrow/blob/50a7d15dfb4cbc4dd449ff2bb3ba2b1cde62a3ab/java/adapter/jdbc/src/main/java/org/apache/arrow/adapter/jdbc/JdbcToArrowUtils.java#L414
For Map: it'd be reasonable to add support directory
For geometry type: the question would be, what type do you expect this to be mapped to? And would it be useful to extend the JDBC adapter with full control over the Arrow type support, so that you can add custom types at runtime?

Hello @lidavidm
Thank you for your time and knowledge sharing!

For Map: it'd be reasonable to add support directory

Sounds perfect! Something similar with following snippet for schema:
 if(arrowType.getTypeID() == ArrowType.ArrowTypeID.Map) {                     FieldType mapType = new FieldType(false, ArrowType.Struct.INSTANCE, null, null);                     FieldType keyType1 = new FieldType(false, new ArrowType.Utf8(), null, null);                     children = new ArrayList<>();                     children.add(new Field("child", mapType,                             Arrays.asList(new Field(MapVector.KEY_NAME, keyType1, null),                                     new Field(MapVector.VALUE_NAME, keyType1, null))));                 }

For geometry type: the question would be, what type do you expect this to be mapped to?

binary representation is OK for me for current task

And would it be useful to extend the JDBC adapter with full control over the Arrow type support, so that you can add custom types at runtime?

It could be good solution for custom type mapping in complex cases.
First step is add column index in
final ArrowType arrowType = config.getJdbcToArrowTypeConverter().apply(columnIndex, columnFieldInfo);
It is allow write custom type mapping by end users (Leveraging jdbc driver specific features and types. The same story with arrays elements types - much more easy to get element type by column index then iterate all columns to collect data for jdbcToArrowConfig.setArraySubTypeByColumnIndexMap()
I also have proposal for column/schema level metadata - propagate "comment" for table/columns here by using java.sql.DatabaseMetaData#getColumns / java.sql.DatabaseMetaData#getTables from connection.getMetaData() or just allow user to provide it from custom comment handler in JdbcToArrowConfig . It will be very useful metadata in real life (medium to large scale project) for documentation and maintenance topics. Apache Spark code use "comment" key for such metadata, so this  looks like reasonable default name for metadata in Arrow schema too

Hello @lidavidm Thank you for your time and knowledge sharing!

For Map: it'd be reasonable to add support directory

Sounds perfect! Something similar with following snippet for schema:  if(arrowType.getTypeID() == ArrowType.ArrowTypeID.Map) { FieldType mapType = new FieldType(false, ArrowType.Struct.INSTANCE, null, null); FieldType keyType1 = new FieldType(false, new ArrowType.Utf8(), null, null); children = new ArrayList<>(); children.add(new Field("child", mapType, Arrays.asList(new Field(MapVector.KEY_NAME, keyType1, null), new Field(MapVector.VALUE_NAME, keyType1, null)))); }

Yes - if you want to file a Jira and/or PR they would be much appreciated. (For anything here, I'm generally supportive, but I don't have too much time right now to do more than review code.)

For geometry type: the question would be, what type do you expect this to be mapped to?

binary representation is OK for me for current task

That sounds good to me. If there's more capabilities required, you may want to follow the discussion about "canonical extension types": https://lists.apache.org/thread/qxc1g7h9ow79qt6r7sqtgbj8mdbdgnhb
This would let us define a new "type" for Postgres-style geometry data which is just metadata over an existing type (such as binary).

And would it be useful to extend the JDBC adapter with full control over the Arrow type support, so that you can add custom types at runtime?

It could be good solution for custom type mapping in complex cases. First step is add column index in final ArrowType arrowType = config.getJdbcToArrowTypeConverter().apply(columnIndex, columnFieldInfo);  It is allow write custom type mapping by end users (Leveraging jdbc driver specific features and types. The same story with arrays elements types - much more easy to get element type by column index then iterate all columns to collect data for jdbcToArrowConfig.setArraySubTypeByColumnIndexMap()

Ok, cool. If you have an API proposal, feel free to file a Jira and/or PR - I think it makes sense to allow more flexibility here, given that we allow it in the 'opposite direction' anyways.

I also have proposal for column/schema level metadata - propagate "comment" for table/columns here by using java.sql.DatabaseMetaData#getColumns / java.sql.DatabaseMetaData#getTables from connection.getMetaData() or just allow user to provide it from custom comment handler in JdbcToArrowConfig . It will be very useful metadata in real life (medium to large scale project) for documentation and maintenance topics. Apache Spark code use "comment" key for such metadata, so this looks like reasonable default name for metadata in Arrow schema too

Interesting. A contribution would be welcome here as well - I think it makes sense to propagate the JDBC metadata into the Arrow metadata if it's useful for applications.

Ok, let's do all things step by step:
https://issues.apache.org/jira/browse/ARROW-17629
https://issues.apache.org/jira/browse/ARROW-17630
https://issues.apache.org/jira/browse/ARROW-17631

Thank you!

Issue resolved by pull request 14134, 14081:
https://github.com/apache/arrow/pull/14134
https://github.com/apache/arrow/pull/14081


Exception uncaught in LocalAdmissionController destructor

Found in daily regression with chaos.
[BaseDaemon.cpp:361] ["(from thread 1) Terminate called after throwing an instance of pingcap::Exception
Code: 2, e.displayText() = Exception: resource manager grpc call failed: AcquireTokenBuckets. write failed: failed to connect to all addresses, e.what() = Exception
Stack trace:
0x7798c4d\tterminate_handler() [tiflash+125406285]
\tlibs/libdaemon/src/BaseDaemon.cpp:628
0x7ff025889a13\tstd::__terminate(void (*)()) [libc++abi.so.1+236051]
0x7ff0258899b8\tstd::terminate() [libc++abi.so.1+235960]
0x1ec9dfb\t__clang_call_terminate [tiflash+32284155]
0x1fbc961\tDB::LocalAdmissionController::~LocalAdmissionController() [tiflash+33278305]
\tdbms/src/Flash/ResourceControl/LocalAdmissionController.h:445
0x1fa226c\tDB::Server::main(std::__1::vector<std::__1::basic_string<char, std::__1::char_traits, std::__1::allocator >, std::__1::allocator<std::__1::basic_string<char, std::__1::char_traits, std::__1::allocator > > > const&) [tiflash+33170028]"]

Labeled p2 and minor since it happened when server is about to shut down.

This problem can be caused by two reasons:

PD is down when tiflash try to send last LAC report to cleanup something in PD.
tiflash got SIGTERM then grpc doesn't immediately, this canbe tricky. Because LAC have to send last rpc to do cleanup, but grpc cannot work at that time.

We need to make sure if this crash is caused by reason-1 or reason-2. If it's reason-1, we can just catch the exception. Otherwise we need to figure out others ways to send the last grpc to PD.

We can make sure this is caused by PD shutting down, so close


the addin is stuck stuck on screen checking authentication

What debugging steps can I do to find the problem. Can you reproduce this error?

No, I do not reproduce it. I would double-check all of the details on your app registration. From your screen shot, it doesn't appear that you're using this sample, or you're using an older version of it?
For debugging, you can load the add-in in the web version of Excel and use the developer tools to debug the JavaScript code.

Yes that was the newest version and I tried the updated version with the updated packages too. Why do you say it from the screenshot it does not appear to be the plugin?
Here is the code of authenticating... https://github.com/microsoftgraph/msgraph-sample-office-addin/blob/4658f0259656f68fd959ffa8df3685f96ad1c62c/graph-tutorial/src/addin/taskpane.html#L13

Just to be sure i am not uploading the plugin manifest because there isnt such an option anymore I am just starting the server with yarn start

Yes that was the newest version and I tried the updated version with the updated packages too. Why do you say it from the screenshot it does not appear to be the plugin?

That's not the UI in the add-in. You have to upload the manifest to get this to work. The option has moved, I've updated the README.

Thank you it works now. It wasnt clear to me that the outlook plugin is for excel from the get go. I was thinking it was for outlook (now I see it in the manifest, but before it slipped my eye apparently). Do you know of any sample or other outlook plugin that use the graph api? if yes please link them here.
What would need to be made to transform the code to be working in outlook except for changing the code in the manifest and workbook specific implementation? For example would the consent.js need to be changed in any way?

No I'm not aware of any sample like that. You might take a look in https://github.com/officedev to see what types of samples they have from the Office side.


use correct lerna workspace setup

lerna bootstrap is to be deprecated. The yarn workspace should be used instead: https://lerna.js.org/docs/getting-started#package-dependency-management
"@k8slens/semver": "./packages/semver" syntax is not universally supported. (In fact, it's not supported by flatpak_node_generator that I use to publish this application to flathub.org. Of course, it would be more standard-compliant to use workspace: when you upgrade to yarn 2.

Note: Although I updated the yarn.lock in this PR, I would prefer the repo owner to update it instead, for security concerns.

Closing for being solved in #7113 and  #7115


assets:precompile runs before breakfast:assets:compile

When I began to deploy to Heroku I found that my breakfast assets were always being update one push behind.   I did a little digging in the logs and noticed the asset:precompile was being executed before the breakfast:assets and the new version was not being served.
I was able to find the asset:precompile enhancement in breakfast.rake.  I was able to instead prepend the tasks breakfast:yarn:install and breakfast:assets:compile by passing them as an array of strings.
if Rake::Task.task_defined?("assets:precompile")
  Rake::Task["assets:precompile"].enhance ["breakfast:yarn:install", "breakfast:assets:compile"]
end

I also noticed I was having a duplicate yarn install, but I do not know that it was being initiated though breakfast.
Rails 5.1.4

Fixed with 0.6.3


[netcdf-c] Add usage

Add usage to netcdf-c, related issue https://github.com/microsoft/vcpkg/issues/8391

Also note that the usage is probably wrong because of where the config files are getting put.

Thanks @PhoebeHui!


update info texts on welcome and about page

These are some minor changes:

updating the infos within the about text (added a paragraph about the jodas)

put collaborators in a different order (make the more productive ones more visible)

Please feel free to update more. Who else is an active collaborator and who isn't anymore and can therefore be moved to the "Thanks to..." list? (Or should we create two lists? One with active collaborators and and one with the former?) And some people have last names and some don't, maybe we can make them more similar?

Lol thanks I guess we should use last names for everyone. I'll try to dig these up.

Collection of last names:
Nynne Just-Christofferson, Carsten Zimmermann, Brigitte Markmann, Franzi Wittleder,

add link to RGSoC

Its Nynne Just Christoffersen without the '-' thanks!


Support skip_values in ColumnValueDecoderImpl

Is your feature request related to a problem or challenge? Please describe what you are trying to do.
related https://github.com/apache/arrow-rs/issues/1792
Add func at
https://github.com/apache/arrow-rs/blob/e59b023480437f67e84ba2f827b58f78fd44c3a1/parquet/src/column/reader/decoder.rs#L253-L255
Describe the solution you'd like
A clear and concise description of what you want to happen.
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
Additional context
Add any other context or screenshots about the feature request here.

I can work on this one

@thinkharderdev  thanks man! 👍


clif build fails due to error in LLI building on Fedora 33 with GCC10

When I got to ./install_clif, I got the following error:
pykaldi/tools/clif_backend/llvm/include/llvm/ExecutionEngine/Orc/OrcRemoteTargetClient.h:722:26: error: could not convert ‘((llvm::orc::remote::OrcRemoteTargetClient<ChannelT>*)this)->callB<llvm::orc::remote::OrcRemoteTargetRPCAPI::ReadMem>(Src, Size)’ from ‘Expected<vector<unsigned char,allocator<unsigned char>>>’ to ‘Expected<vector<char,allocator<char>>>’
722 |     return callB<ReadMem>(Src, Size);

Applying the patch suggested here fixed it.

Thanks for the feedback and trying out the red had patch! Seems to solve compilation in Gcc9 as well: https://github.com/pykaldi/pykaldi/pull/226
We'll probably include the fix into install_clif.sh, so that the files gets patched automatically.


changed 'New Boarding' to 'Draft Boarding'

the issue addressed: #353

Hello @ seemagawaradi - thanks for this PR! Our team will review this pull request within three business days. While you are waiting, you can work on another issue if you'd like.
We really appreciate the effort - thanks!

 Review PRs

Right! I'm sorry, I'm kind of new to this. Thanks for your input. I will definitely look into it and change it.

Hi @seemagawaradi ! When you have a moment, can you please comment on issue #353? We cannot assign it to you until you have commented on it so other people may think it's available to work on.
Also our guidelines state that if an issue isn't commented on in three days (72 hours) it will be considered abandoned. It doesn't have to be fixed, just let us know you're still working on it.
Thanks!

(The guidelines weren't up when you started with on it,  so we wanted to give you a heads up. The guidelines in full are at: https://wildaid.github.io/contribute/ )


pythonPackages.sabyenc: init at 2.3.3

Motivation for this change
sabnzbd has started complaining about missing sabyenc module (which apparently offers better performance), so package it and add to sabnzbd dependencies.
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[x] Fits CONTRIBUTING.md.

@GrahamcOfBorg build python2.pkgs.sabyenc python3.pkgs.sabyenc sabnzbd

Success on aarch64-linux (full log)
Attempted: python2.pkgs.sabyenc, python3.pkgs.sabyenc
The following builds were skipped because they don't evaluate on aarch64-linux: sabnzbd
Partial log (click to expand)
/build/sabyenc-3.3.5
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/j2zx8b96i17nx3rshshnb8rc3vdyic1q-python3.6-sabyenc-3.3.5
shrinking /nix/store/j2zx8b96i17nx3rshshnb8rc3vdyic1q-python3.6-sabyenc-3.3.5/lib/python3.6/site-packages/sabyenc.cpython-36m-aarch64-linux-gnu.so
strip is /nix/store/a245zacjzf3qw0davhvlfarihcy2yyrc-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/j2zx8b96i17nx3rshshnb8rc3vdyic1q-python3.6-sabyenc-3.3.5/lib
patching script interpreter paths in /nix/store/j2zx8b96i17nx3rshshnb8rc3vdyic1q-python3.6-sabyenc-3.3.5
checking for references to /build in /nix/store/j2zx8b96i17nx3rshshnb8rc3vdyic1q-python3.6-sabyenc-3.3.5...
/nix/store/pbdz2ns50ayai7jl82l4v7ljz9ml2c63-python2.7-sabyenc-3.3.5
/nix/store/j2zx8b96i17nx3rshshnb8rc3vdyic1q-python3.6-sabyenc-3.3.5

Success on x86_64-darwin (full log)
Attempted: python2.pkgs.sabyenc, python3.pkgs.sabyenc
The following builds were skipped because they don't evaluate on x86_64-darwin: sabnzbd
Partial log (click to expand)
Processing ./sabyenc-3.3.5-cp36-cp36m-macosx_10_6_x86_64.whl
Installing collected packages: sabyenc
Successfully installed sabyenc-3.3.5
/private/tmp/nix-build-python3.6-sabyenc-3.3.5.drv-0/sabyenc-3.3.5
post-installation fixup
strip is /nix/store/sixx1lfy97125f6hxymbwn64cb8z62p3-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/ac5w1h7fp43hzr29xqj9w12vrh7h29w5-python3.6-sabyenc-3.3.5/lib
patching script interpreter paths in /nix/store/ac5w1h7fp43hzr29xqj9w12vrh7h29w5-python3.6-sabyenc-3.3.5
/nix/store/3m3ix24g7yl294zw1xxla49fa9zjichc-python2.7-sabyenc-3.3.5
/nix/store/ac5w1h7fp43hzr29xqj9w12vrh7h29w5-python3.6-sabyenc-3.3.5

Success on x86_64-linux (full log)
Attempted: python2.pkgs.sabyenc, python3.pkgs.sabyenc
The following builds were skipped because they don't evaluate on x86_64-linux: sabnzbd
Partial log (click to expand)
/build/sabyenc-3.3.5
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/jxxrl37acz0b802gqsfhv2z78gal55ba-python3.6-sabyenc-3.3.5
shrinking /nix/store/jxxrl37acz0b802gqsfhv2z78gal55ba-python3.6-sabyenc-3.3.5/lib/python3.6/site-packages/sabyenc.cpython-36m-x86_64-linux-gnu.so
strip is /nix/store/a3nk8z2i7m7wa3jdckgv710n7j3yx4b5-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/jxxrl37acz0b802gqsfhv2z78gal55ba-python3.6-sabyenc-3.3.5/lib
patching script interpreter paths in /nix/store/jxxrl37acz0b802gqsfhv2z78gal55ba-python3.6-sabyenc-3.3.5
checking for references to /build in /nix/store/jxxrl37acz0b802gqsfhv2z78gal55ba-python3.6-sabyenc-3.3.5...
/nix/store/9177wilyw583pg9hg4zkp1nw1qh7k8mx-python2.7-sabyenc-3.3.5
/nix/store/jxxrl37acz0b802gqsfhv2z78gal55ba-python3.6-sabyenc-3.3.5


Rich error model

Hi, thanks for the project!!
Is there are possible to use rich error model?
https://www.grpc.io/docs/guides/error/
https://cloud.google.com/apis/design/errors#error_model

Yes, take a look at these exceptions: https://github.com/spiral/php-grpc/tree/master/src/Exception

Ammm, if i clealy understand its a basic grpc error model, which can produce only code and error message. In rich error model you can pass in status additionals errors details, for example stack trace or validation errors in special details field.
package google.rpc;

message Status {
  // A simple error code that can be easily handled by the client. The
  // actual error code is defined by `google.rpc.Code`.
  int32 code = 1;

  // A developer-facing human-readable error message in English. It should
  // both explain the error and offer an actionable resolution to it.
  string message = 2;

  // Additional error information that the client code can use to handle
  // the error, such as retry delay or a help link.
  repeated google.protobuf.Any details = 3;
}

Hmm, I see. Custom codes and messages are already being passed, we have to add support for details only.


Save VMI UUID under map for future use on cleanup stage

What this PR does / why we need it:
On the cleanup stage, VMI already does not have UUID, that prevented to remove socket file under /var/run/kubevirt/sockets
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #1448
Special notes for your reviewer:
Release note:

NONE

@davidvossel Looks like when object deletionTimestamp != nil k8s also set UUID of the object to an empty string, at least I can see this behavior.


added string interpolation step

I have added a step to show case simple interpolation with string and integer variables

Thanks for the PR!

GitHub Selfies


fish-shell: function name is broken for local files (./script.py)

When Using argcomplete under Fish-Shell, the generated Code contains the literal Path to the Script as part of a function-name:
~/C/makefile-style-python register-python-argcomplete --shell fish ./foo/bar/baz

function __fish_./foo/bar/baz_complete
    set -x _ARGCOMPLETE 1
    set -x _ARGCOMPLETE_DFS \t
    set -x _ARGCOMPLETE_IFS \n
    set -x _ARGCOMPLETE_SUPPRESS_SPACE 1
    set -x _ARGCOMPLETE_SHELL fish
    set -x COMP_LINE (commandline -p)
    set -x COMP_POINT (string length (commandline -cp))
    set -x COMP_TYPE
    if set -q _ARC_DEBUG
        ./foo/bar/baz 8>&1 9>&2 1>/dev/null 2>&1
    else
        ./foo/bar/baz 8>&1 9>&2 1>&9 2>&1
    end
end
complete -c ./foo/bar/baz -f -a '(__fish_./foo/bar/baz_complete)'

__fish_./foo/bar/baz_complete is not a valid function name in Fish and thus | sourceing the generated Snippet results in an Error:
~/C/makefile-style-python register-python-argcomplete --shell fish ./foo/bar/baz | source
- (line 2): function: Illegal function name '__fish_./foo/bar/baz_complete'
function __fish_./foo/bar/baz_complete
^
from sourcing file -

Removing the offending Characters only leaving [a-zA-Z0-9] or a similar restrictive character-set would result in a workable Fish script.

Does completion works after function name fix?
For me (fish 3.1.2) it doesn't.
After changing complete -c ./foo/bar/baz -f -a '(__fish_foo_bar_baz_complete)' to complete -c baz -f -a '(__fish_foo_bar_baz_complete)' completion starts working as expected.

After changing complete -c ./foo/bar/baz -f -a '(__fish_foo_bar_baz_complete)' to complete -c baz -f -a '(__fish_foo_bar_baz_complete)' completion starts working as expected.

https://github.com/fish-shell/fish-shell/issues/6001, fixed in fish 3.3.0.

fixed in fish 3.3.0.
Nice!

Relative paths should be also supported in generated script body - running completion from different directory would fail now.
Probably it's better to use single completion function for fish, like for bash. Disabling completions descriptions should be also changed with this approach because it's done by modifying script.

After fish-shell/fish-shell#6001 completion registered via complete -p /home/auser/myscript ... work for /home/user/myscript and ./myscript but not for ~/myscript.
@faho is this expected or it should be reported?
There is workaround: if I register command via complete -c myscript ... all three cases works, but also completion is invoked for any other script with same name.


About maskgitvq.jsonl

Hi, what is maskgitvq.jsonl? It is needed in PretoeknizedDataSetJSONL(dataset_config.pretokenization).

Hi,
Please see https://github.com/bytedance/1d-tokenizer/blob/main/README_RAR.md#training-preparation

Thanks, that's great.


Improve fatal error page

Is your feature request related to a problem? Please describe.

we show a default fatal error page that was previously from nuxt shell/layouts/error.vue
we could make this respect light / dark mode and improve how it looks. possibly inline with our non-fatal error page?

not sure we can show the header bar with burger menu and user avatar though

Additional context

@richard-cox Is this relevant - "fatal errors" are swallowed in production build

Ah yes, this was pre-discovery. Closing, error page is only seen when running in dev


linux-64 package contains a spurious (and almost empty) sysroot

(E.g.) https://anaconda.org/conda-forge/qt/5.12.9/download/linux-64/qt-5.12.9-hda022c4_4.tar.bz2 has a spurious sysroot folder, with only a single file:
x86_64-conda-linux-gnu/sysroot/usr/include/linux/input.h.bak

This file is created by the code here:
https://github.com/conda-forge/qt-feedstock/blob/636c8b55355fbb908d5c6c67e909e289bcdf39bc/recipe/build.sh#L147-L153
For this reason, after installing qt other packages sometimes fail to compile:
$ conda create -n test
[...]
$ conda activate test
$ conda install qt
[...]
$ pip cache purge
$ pip install mpi4py
[...]
checking for MPI compile and link ...
/usr/bin/mpicc -pthread -B /home/mdiener/emirge/miniforge3/envs/ceesd/compiler_compat -Wno-unused-result -Wsign-compare -DNDEBUG -fwrapv -O2 -Wall -fPIC -O2 -isystem /home/mdiener/emirge/miniforge3/envs/ceesd/include -fPIC -O2 -isystem /home/mdiener/emirge/miniforge3/envs/ceesd/include -fPIC -I/home/mdiener/emirge/miniforge3/envs/ceesd/include/python3.9 -c _configtest.c -o _configtest.o
success!
removing: _configtest.c _configtest.o
/usr/bin/mpicc -pthread -B /home/mdiener/emirge/miniforge3/envs/ceesd/compiler_compat -Wno-unused-result -Wsign-compare -DNDEBUG -fwrapv -O2 -Wall -fPIC -O2 -isystem /home/mdiener/emirge/miniforge3/envs/ceesd/include -fPIC -O2 -isystem /home/mdiener/emirge/miniforge3/envs/ceesd/include -fPIC -I/home/mdiener/emirge/miniforge3/envs/ceesd/include/python3.9 -c _configtest.c -o _configtest.o
/usr/bin/mpicc -pthread -B /home/mdiener/emirge/miniforge3/envs/ceesd/compiler_compat _configtest.o -Lbuild/temp.linux-x86_64-3.9 -o _configtest
/home/mdiener/emirge/miniforge3/envs/ceesd/compiler_compat/ld: warning: libopen-rte.so.40, needed by /usr/lib/x86_64-linux-gnu/openmpi/lib/libmpi.so, not found (try using -rpath or -rpath-link)
/home/mdiener/emirge/miniforge3/envs/ceesd/compiler_compat/ld: warning: libopen-pal.so.40, needed by /usr/lib/x86_64-linux-gnu/openmpi/lib/libmpi.so, not found (try using -rpath or -rpath-link) /home/mdiener/emirge/miniforge3/envs/ceesd/compiler_compat/ld: warning: libm.so.6, needed by /usr/lib/x86_64-linux-gnu/openmpi/lib/libmpi.so, not found (try using -rpath or -rpath-link)
/home/mdiener/emirge/miniforge3/envs/ceesd/compiler_compat/ld: warning: libhwloc.so.15, needed by /usr/lib/x86_64-linux-gnu/openmpi/lib/libmpi.so, not found (try using -rpath or -rpath-link)
/home/mdiener/emirge/miniforge3/envs/ceesd/compiler_compat/ld: /usr/lib/x86_64-linux-gnu/openmpi/lib/libmpi.so: undefined reference to `mca_base_framework_components_close'
[...]

The workaround I found is to remove the sysroot directory after installing qt:
$ rm -rf miniforge3/envs/test/x86_64-conda-linux-gnu/sysroot/
$ pip install mpi4py  # works fine now

[x] I read the conda-forge documentation and could not find the solution for my problem there.

Issue:

Environment (conda list):

$ conda list

Details about  conda and system ( conda info ):

$ conda info

Probably just need to remove that file in the recipe build script. It’s getting packaged because it wasn’t cleaned up

#206 looks like it will fix this issue

@isuruf @jakirkham : Since #206 went into a new package instead, could we simply modify the tar.bz2 file for this package as outlined above and re-upload to anaconda?

@isuruf @jakirkham : Since #206 went into a new package instead, could we simply modify the tar.bz2 file for this package as outlined above and re-upload to anaconda?

Would it be possible to bump the build number for that package with the needed change?

Would it be possible to bump the build number for that package with the needed change?

I'm not sure, but I think this might be possible.


Prototype Pollution vulnerability affecting @chasemoskal/snapstate, version 0.0.9

Overview
Affected versions of this package are vulnerable to Prototype Pollution. An attacker can manipulate the prototype of an object, potentially leading to the alteration of behavior of all objects inheriting from the affected prototype by passing specially crafted input to this function.
Location:
@chasemoskal/snapstate/x/tools/attempt-nested-property.js:14

PoC:
(async () => {
  const lib = await import('@chasemoskal/snapstate');

var BAD_JSON = JSON.parse('{"__proto__":{"polluted":true}}');
var victim = {}
console.log("Before Attack: ", JSON.stringify(victim.__proto__));
try {
  lib.attemptNestedProperty ({},[["__proto__"], "polluted"], true)
} catch (e) { }
console.log("After Attack: ", JSON.stringify(victim.__proto__));
delete Object.prototype.polluted;
})();

Output:
Before Attack:  {}

After Attack:  {"polluted":true}
How to prevent:

Freeze the root prototype using Object.freeze
Require schema validation of JSON input.
Avoid using unsafe recursive merge functions.
Consider using objects without prototypes (for example, Object.create(null)), breaking the prototype chain and preventing pollution.
As a best practice use Map instead of Object

Is there any updates on this?

Is there any updates on this?


 It aids in advanced mathematical computations for students, researchers, and professionals.
Under which category you wish to place it -

[ ] Computer Science
[x] Mathematics
[ ] Physics
[ ] Chemistry
[ ] Biology
[ ] Art
[ ] Finance
[ ] Scientific
[ ] Health
[ ] Sports
[x] Let project owner decide
[ ] Suggest a new category - (Answer here)

@SarthakKeshari  please assign me this issue

Hey @chinmayr633,
Assigned.
You may contribute your code under the folder path -
calc_for_everything\calculators\src\computer_science\computerAlgebraSystemCASCalc
Issue completion deadline - 22nd Oct 11:00:00 am IST
NOTE - In case the issue completion deadline is not met, the issue will be assigned to a new participant

@chinmayr633,
Since the issue completion deadline is crossed,
Issue has been unassigned.
Kindly do not create a PR for the issue now.

@SarthakKeshari kindly assign me this issue.

Hey @nipun221,
Assigned.
You may contribute your code under the folder path -
calc_for_everything\calculators\src\computer_science\computerAlgebraSystemCASCalc
Issue completion deadline - 31st Oct 8:00:00 am IST
NOTE - In case the issue completion deadline is not met, the issue will be assigned to a new participant

@SarthakKeshari kindly increase the deadline as i am working on it.

As on 31st Oct, we are concluding Hacktoberfest. So, deadline can be updated max. to 31st Oct 11:00:00 pm IST

@nipun221,
Deadline updated - 31st 11:00:00 pm IST

@nipun221,
Since the issue completion deadline is crossed,
Issue has been unassigned.
Kindly do not create a PR for the issue now.


added 4 agile questions to agile-quiz.ts

Summary of changes

Added 4 agile questions in relation to burndown/burnup charts and non-functional requirements
Issue #103

Checklist

[x] I have read and followed the contribution guidelines.
[x] I have read through the Code of Conduct and agree to abide by the rules.
[x] This PR is for one of the available issues and is not a PR for an issue already assigned to someone else.
[x] My PR title has a short descriptive name so the maintainers can get an idea of what the PR is about.
[x] I have provided a summary of my changes.

closes #XXXXX

Thank you for your contribution!
Please review the requested changes. Once those changes have been implemented, then we can merge your PR into main. 👍

Thanks for reviewing and have updated the PR accordingly!


tweak the formatting and line wrapping of the first run messaging

When you first the dart tool, we print an analytics disclaimer:
The Dart CLI developer tool uses Google Analytics to report usage and diagnostic data
along with package dependencies, and crash reporting to send basic crash reports.
This data is used to help improve the Dart platform, Flutter framework, and related tools.

Telemetry is not sent on the very first run.
To disable reporting of telemetry, run this terminal command:

dart --disable-analytics.
If you opt out of telemetry, an opt-out event will be sent,
and then no further information will be sent.
This data is collected in accordance with the
Google Privacy Policy (https://policies.google.com/privacy).

The line length, wrapping, and spacing isn't consistent in that message. I suggest we update it to something like the below:
The Dart CLI developer tool uses Google Analytics to report usage and diagnostic
data along with package dependencies, and crash reporting to send basic crash
reports. This data is used to help improve the Dart platform, Flutter framework,
and related tools.

Telemetry is not sent on the very first run. To disable reporting of telemetry,
run this terminal command:

    dart --disable-analytics

If you opt out of telemetry, an opt-out event will be sent, and then no further
information will be sent. This data is collected in accordance with the Google
Privacy Policy (https://policies.google.com/privacy).

This was completed:

#215


status and release-status to release_status

Ref https://github.com/KSP-CKAN/CKAN-meta/pull/1175

LGTM, merging


Handle owning multiple teams

At https://gratipay.com/new:

The 1 weekly payments totalling $0.10 that previously were directed to your [] user account will be redirected to your new Team, pending approval of your application.

I assume if someone applies for a second team, they will not have any tips to migrate.

---
Want to back this issue? **[Post a bounty on it!](https://www.bountysource.com/issues/26035661-handle-owning-multiple-teams?utm_campaign=plugin&utm_content=tracker%2F85909&utm_medium=issues&utm_source=github)** We accept bounties via [Bountysource](https://www.bountysource.com/?utm_campaign=plugin&utm_content=tracker%2F85909&utm_medium=issues&utm_source=github).

Correct. All tips are migrated to the first new Team a ~user opens. It didn't seem possible to do something more fine-grained than that:

Since giving to Participants has been ambiguous in regard to products or services delivered, migrating giving to a single-purpose Team will be a judgement call for our users. If I have 100 supporters, and 60 would say they were giving to me because of one product or service I provide, and 30 because of another, and 10 just because they love me, then how should I migrate? I don't even know who my supporters are, so it's not like I can manually review and make assignments ("Oh, this person is a Fizzbuzz user, that's probably why they've been supporting me. Let's move their payment to the new Fizzbuzz Team"). No: I have to guess at the 60-supporter product/service, and migrate all of my giving to a new Team dedicated to that. Then I can make a second Team for the 30-supporter product/service.

Beyond that, we do handle multiple teams per owner in the simple sense. @book runs three, e.g.:
https://gratipay.com/cpan-book/
https://gratipay.com/act/
https://gratipay.com/cpan-io/
:-)

Unfortunately, I created the cpan-io team first, but I think most of my tippers did it because of my CPAN contributions, which is covered by the cpan-book team that was created later.

Okay, I think I will close this for now and we can reopen as needed.


Different camera rotation between code and 3D view

Checklist:

[x] I cleared the cache of my browser
[x] I updated to the latest version available

Release with the issue: 1.1.5
Last working release (if known): New user today
Browser and Operating System: Firefox 95.0.1, Linux Mint 20.2 64Bit
Description of problem:
After getting the camera position and rotation from the 3D view by double clicking into white space, I got the coordinates like explained within the documentation.
The current selected view is one room of my flat in top-down perspective.
camera_position: { x:<PHONE_NUMBER>3706742, y:<PHONE_NUMBER>2685895, z: -511.3383214420605 }
camera_rotate: { x: -1.5472489731553267, y: 0.4442461998816112, z: 1.5160512996981885 }
After adding the coordinates into the card config and saving it, the camera doesn't look in the previous perspective anymore.
The camera is nearly rotated 90° up and 90° to the left.
If I get the new position now, the following coordinates are shown:
camera_position: { x:<PHONE_NUMBER>3706753, y:<PHONE_NUMBER>2685895, z: -511.33832144206036 }
camera_rotate: { x: -2.511429565824015, y: 0.22129923242939392, z: 2.9828461394081165 }
If I set this new rotation, the view stays the same now.
The whole map has 0,0 coordinate to the top left as mentioned in the docs.

Hello I'm going to verify if I can reproduce and fix

I can reproduce the problem but it I'm unable to fix. It has been introduced since the implementation of a few card size and position adjustments.

Thank you for investigating.
Is there a possible workaround?

Thank you for investigating.
Is there a possible workaround?

Have you tried to double click on an empty space when you have the model in the editor ? I have also some trouble but I have very slight differences between the captured position/rotation and the one that is displayed; also when doing the operation in with the Editor open the result is even more accurate

Have you tried to double click on an empty space when you have the model in the editor ? I have also some trouble but I have very slight differences between the captured position/rotation and the one that is displayed; also when doing the operation in with the Editor open the result is even more accurate

If ti still does not work, please send me your model sh3d and/or obj

If ti still does not work, please send me your model sh3d and/or obj

Yes, I used the empty space for the camera position within the editor.
Doesn't seem to help though. I still got the described rotation.
I have to note, that my previous information was for a room in the right bottom corner zoomed in.
As I figured out now, the camera always points in direction of the center of the model after leaving the editor.
This is true for all four edges.
If I use the top down from the middle of the model, the camera behaves normal.

@Floyer007, please have a look to the last version 1.1.13. I think that I have improved the management of position and rotation save. Nevertheless there are still some remaining issues. Related to the card position.

I close for lack of feedback, if the problem persist, please repost it

Yes, still persists within v1.1.13.
Will recheck it with another floorplan within the next weeks and will provide feedback if needed.


A file was included in /_layouts/default.html

Describe the bug
Website fails to serve from GitHub pages. I get this error instead
Your site is having problems building: A file was included in /_layouts/default.html that is a symlink or does not exist in your _includes directory. For more information, see https://help.github.com/en/articles/page-build-failed-file-is-a-symlink.
Expected behavior
Website serves correctly save as Jekyll serve on GitHub.

Can not reproduce this. Are you still experiencing this?


Added missing check to avoid a NRE

The PdbMethod may not be set at all, while ConfuserEx is instructed to rename the pdb. This did lead to a NRE.
fixes #182

:white_check_mark: Build ConfuserEx 400 completed (commit https://github.com/mkaring/ConfuserEx/commit/29a6ba4537 by @mkaring)


Added release notes for 2.11.1

Description
Release notes for 2.11.1
Check List

[x] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

UTs fixed as part of https://github.com/opensearch-project/security-analytics-dashboards-plugin/pull/783


Setting type of variadic parameter doesn't take

When a variadic parameter has a type of its elements being set, Phan doesn't remember them.
<?php

/** @param array $args */
function f(...$args) {
    print_r($args);
}
f(42, 'string');
f([42], ['string']);

class C {
    /** @param array $args */
    function f(...$args) {}
}
(new C)->f(42, 'string');
(new C)->f([42], ['string']);

The phpdoc standard seems to be @param array ...$args for a variadic array of arrays, not array $args - see the test in https://github.com/phpDocumentor/phpDocumentor2/commit/14510b1833ed3ca3467169e8e9f5f6924342a977

Thats the intention (for $args to be an array of arrays) and is what we're testing for.
In the tests, we're making sure that
/** @param array $args */
function f(...$args) {}
f(42, 'string');
f([42], ['string']);

emits issues for the first call, but not the second
+%s:%d PhanTypeMismatchArgument Argument 1 (args) is int but \f() takes array defined at %s:%d
 +%s:%d PhanTypeMismatchArgument Argument 2 (args) is string but \f461() takes array defined at %s:%d

Thats the expected behavior, right? Or am I misunderstanding stuff.

If $args was an array of integers, I would expect
/** @param int ...$args */
// Or
/** @param int[] $args */

When reading it, instead of int $args (should be obvious from looking only at the doc comment, but I need to look in both places to know if it is an array of ints)
I.e. the test should instead test
/** @param array ...$args */
(Same comment for an array of arrays.)

Agree with including the ellipsis – if you can write a function param in raw PHP as int ...$args then you should be able to use exactly the same syntax in the docblock.
I'm not sure, though, that int[] $args should be supported as a direct equivalent (because actually calling that function with an array will result in an error).

phpStorm is compatible with @param string[] $words when the code is function name(string ...$words), and becaie I'm using that IDE I am following that style, and honestly that make sense IMO, because inside the function body the variable $words will be an array of strings, just like string[] $wordssuggests.
However, I got PhanTypeMismatchDeclaredParam for such code.
Would be very nice if Phan could support that style, considering that it seems quite reasonable and a popular IDE uses it.

phpStorm is compatible with @param string[] $words when the code is function name(string ...$words), and becaie I'm using that IDE I am following that style, and honestly that make sense IMO, because inside the function body the variable $words will be an array of strings, just like string[] $wordssuggests.

PHPStorm also supports @param string ...$words. You can use @phan-param string ...$words (I think) if you have a need to type @param string[] $words for other tools to work properly. (As of january 2018)
https://youtrack.jetbrains.com/issue/WI-29429#comment=27-2680697


JpaEventStoreAutoConfiguration doesn't load

If we have an EventBus in the Spring context, there will be no EventStorageEngine configured:
https://github.com/AxonFramework/AxonFramework/blob/719dddb4738c51a8802f74dc6270bf3bb2b7d69e/spring-boot-autoconfigure/src/main/java/org/axonframework/springboot/autoconfig/JpaEventStoreAutoConfiguration.java#L38
I think it should only check for the storage engine presence.
my issue

Hi Sam,
this is intended behavior. If you specify an EventBus, then Axon shouldn't autoconfigure another one for you, either as an Event Bus or an Event Store. Therefore, it won't need to configure an EventStorageEngine either.
The problem is that otherwise Axon will define a JPA based EventStorageEngine and require the entities to be registered too. If you then don't use them, you are forced to maintain unused tables in a database. We want to avoid that.
Closing this issue as "works as intended", but feel free to comment.

Hi, thanks for the response.
How would you recommend to register a MessageDispatchInterceptor<EventMessage<?>>?
I'm trying to do it via overriding this @Bean in org.axonframework.springboot.autoconfig.AxonAutoConfiguration#eventStore. The method is exactly the same but also passes the interceptor to the builder. But now JpaEventStoreAutoConfiguration won't start.

By default I see conditions @AutoConfigureAfter that basically happens in this order:

JpaEventStoreAutoConfiguration creates storage engine.
AxonAutoConfiguration creates event bus.

Now if I wish to create my own bus, there would be no engine.

Also, just noticed you said this:

If you specify an EventBus, then Axon shouldn't autoconfigure another one for you, either as an Event Bus or an Event Store.

That is actually not what happens here. If I define EventBus, I will not get EventStorageEngine which is a totally different thing.

If you want to register a dispatch interceptor, you would do:
public void configure(EventBus eventBus) {
    eventBus.registerDispatchInterceptor(....)
}```


fix(eslint-plugin-qwik): handle linting tuple types properly for valid-lexical-scope rule

What is it?

[ ] Feature / enhancement
[x] Bug
[ ] Docs / tests

Description
TupleType does not have a symbol property which caused the line: const symbolName = type.symbol.name; to throw an error.
When a tuple type is used, eslint-qwik-plugin would error out with:
TypeError: Cannot read properties of undefined (reading 'name')
Occurred while linting [REDACTED].tsx:1
Rule: "qwik/valid-lexical-scope"
    at r3 ([REDACTED]/node_modules/eslint-plugin-qwik/index.js:424:69352)
    at wdr ([REDACTED]/node_modules/eslint-plugin-qwik/index.js:424:70273)
    at r3 ([REDACTED]/node_modules/eslint-plugin-qwik/index.js:424:70109)
    at Pdr ([REDACTED]/node_modules/eslint-plugin-qwik/index.js:424:68153)
    at Adr ([REDACTED]/node_modules/eslint-plugin-qwik/index.js:424:68005)
    at [REDACTED]/node_modules/eslint-plugin-qwik/index.js:424:67003
    at Array.forEach (<anonymous>)
    at p ([REDACTED]/node_modules/eslint-plugin-qwik/index.js:424:66124)
    at Array.forEach (<anonymous>)
    at p ([REDACTED]/node_modules/eslint-plugin-qwik/index.js:424:67171)

I have updated the code to check if it's a tuple type and check the inner types (retrieved using checker.getTypeArguments(...)). I found this out just by brute-force grepping of the Typescript codebase and have no idea if this is the right way to do it but it works! 😅
With this change, I see these eslint errors now:
export type Props = {
  foobar: [string, number, Function],
};

  32:18  error  Identifier ("props") can not be captured inside the scope (useWatch$) because "props.foobar" is an instance of the "Function" class, which is not serializable. Check out https://qwik.builder.io/docs/advanced/optimizer for more details

Use cases and why

n/a
Checklist:

[x] My code follows the developer guidelines of this project
[x] I have performed a self-review of my own code
[ ] I have made corresponding changes to the documentation
[ ] Added new tests to cover the fix / functionality

Yup will do! Somehow I completely missed that there were tests!


URL Array Issue

Be sure to search for your issue before opening a new one.
Current Behavior

I am using react-player 2.3.1
I am passing an array to the 'url' parameter. One is a *.mp4 file (local file) and another is a *.m3u8 file from AWS.
The *.mp4 file is played, however the next video is not called.
Expected Behavior

The *.mp4 file is played, the next video in the array should play.
What am i missing?
Steps to Reproduce

Pass a local *.mp4 file in the url array along with a remote accessible AWS link to *.m3u8 file
Play react-player

Environment

URL attempting to play:
Browser: Chrome (86.0.4240.198)
Operating system: Windows 10
jsFiddle example: https://jsfiddle.net/sv5x3ug1

Other Information

url -> is from AWS.
The Intro is played, Intro3D and url from AWS is not played

@ravola possible reason that I can determine from the given information is that it can be due to cors policy of s3 bucket or resource that you are using for video serving.
It would be helpful if you can share the links here, specifically aws link of a video. Otherwise, check your console for cors error, if any.

@afzaalahmad the AWS S3 cors policy is setup and it plays from S3 when i pass the url without an array.
url={url} --> url = AWS S3 link which works.

When i pass an array
var video = "../../video.mp4" -->video.mp4
<ReactPlayer url={[video, url]} playing="true" />
The video.mp4 plays and url (AWS m3u8) will not start.

Duplicate of #1053

@cookpete do you plan to support a playlist for this scenario? I can see it works for youtube as a playlist. Why not for this scenario?
Trying to understand why it wouldn't work?

It works for youtube because the youtube player supports passing in a list of video IDs to generate a playlist. ReactPlayer just acts as a proxy to that functionality.
Playlist supports comes up a lot and is simply beyond the scope of this component. There is nothing stopping anyone creating ReactPlaylist or something that uses ReactPlayer to play a list of URLs in sequence and provide methods for going back and forth.

Understood! @cookpete


I added manually those files as per docs, but, it showing 'No such module' while trying to import

I added manually those files as per docs, but, it showing 'No such module' while trying to import, Can you suggest, how to fix this issue?

I fixed this myself.


Intermittent log outs on desktop Chrome + Safari

✅ Prerequisites

[X] Did you perform a cursory search of open issues? Is this bug already reported elsewhere?
[X] Are you running the latest SDK version?
[X] Are you reporting to the correct repository (magic-sdk)?

🐛 Description
Our users are experiencing intermittent logouts on desktop Chrome + Safari even after the fix for issue https://github.com/magiclabs/magic-js/issues/279. We believe there is still a session persistence issue on desktop browsers.
🧩 Steps to Reproduce

Login using Magic
Wait a random amount of time (usually a couple days)
User is brought to logged out page even though they didn't explicitly log out

🤔 Expected behavior
User is logged in for the duration of the session. We currently have sessions set to 90 days and to auto-refresh using the Magic dashboard.
😮 Actual behavior
User is only logged in for a couple days before being logged out.
💻 Code Sample
🌎 Environment

Software
Version(s)

magic-sdk
10.0.0

Browser
Google Chrome 107.0.5304.110 and Safari 15.4

yarn

Operating System
MacOS 12.3

cc @mikeavvad who was also facing this issue

@pkayfire The steps to reproduce require some time to test this. Please allow for a few days for me to reproduce and update.

@ayv8er  @Ethella I have quite a similar issue, let me describe it.
So for me Chrome is ok (at least for 2-days short session), but in Safari and Brave Magic drops the session after a couple of refreshes (less than 1 minute).
Is it a separate bug and I should create another issue?

Hi everyone, I am trying to reproduce this myself because no one has been able to provide steps that result in reproducing this.
@pkayfire, I have been monitoring sessions on both Chrome and Safari on your app for 9 days now. I will continue for as long as possible. If you have any additional information you can provide, I'd highly appreciate it.

@stepheljobs The issue with Brave is that the app will not detect session in Brave when shields are enabled. Please disable shields, it will solve the issue.
If you require shields to be enabled, please try going to brave://settings/cookies, scroll down and under Sites that can always use cookies, try adding:

[*.]magic.link (check including third-party cookies on this site)

Scroll way down to the bottom, make sure that neither magic.link or csb.app is included under:

sites that clear cookies when you close them
sites that can never use cookies

Thank you @ayv8er !

@ayv8er thanks for your answer regarding Brave! But what about Safari? Seems like it acts just like Brave for me.

Closing for now as Magic team were unable to reproduce and we haven't had any users reporting the issue recently.


Error: when I send request to the server I got an error:

The ip and mac address is correct.
Exception happened during processing of request from ('<IP_ADDRESS>', 63908)
Traceback (most recent call last):
File "/usr/lib/python2.7/SocketServer.py", line 290, in _handle_request_noblock
self.process_request(request, client_address)
File "/usr/lib/python2.7/SocketServer.py", line 318, in process_request
self.finish_request(request, client_address)
File "/usr/lib/python2.7/SocketServer.py", line 331, in finish_request
self.RequestHandlerClass(request, client_address, self)
File "/usr/lib/python2.7/SocketServer.py", line 652, in init
self.handle()
File "/usr/lib/python2.7/BaseHTTPServer.py", line 340, in handle
self.handle_one_request()
File "/usr/lib/python2.7/BaseHTTPServer.py", line 328, in handle_one_request
method()
File "server.py", line 56, in do_GET
result = getTempRM()
File "server.py", line 177, in getTempRM
device = broadlink.rm((RMIPAddress, RMPort), RMMACAddress)
TypeError: init() takes exactly 4 arguments (3 given)

You need to add a type. For RM Pro use
device = broadlink.rm((RMIPAddress, RMPort), RMMACAddress,10141)
at the first line of the sendCommand method.
However, this only solves the "learning" part. The sending part has a whole bunch of issues. It seems that the broadlink lib was updated and we need to make a few changes to support it.

I think I have a solution.  I'm still doing more testing, but expect a PR very soon

@eyalellenbogen What were the other issues with sending?  Once the device is initialized with the proper device type, the rest should work fine.  I'm just wondering what issue you had so I can test.

@uudruid74 a lot has happened since and I kind of forgot :). But, if you try sending data you'll probably stumble on the same issues. Unless you're having no problems... in that case it's probably something I did wrong.

Resolved by #13


Unable to customise title and description (Facebook)

Hi,
I'm unable to customise a dynamic title for Facebook. Or even just a static title.
shareData: function () {
    return {
      title: function() {
        if (this.data())
          return "Hello | " + this.data().title;
      },
      image: "/images/testing.png",
      thumbnail: "/images/testing.png",
      description: "Testing description."

My meta data are fine. But when I installed this packaged, my og tags are not configuring well.

Hello!
Field title cannot be a function, see this.

Thanks. I get it.


Make it clear context can be extended

Signed-off-by: Doug Davis<EMAIL_ADDRESS>

LGTM

LGTM

another round of L G T Ms needed

LGTM

LGTM

LGTM

LGTM


Handle starting token in the 'list-objects' query

Coverage decreased (-0.003%) to 93.553% when pulling 14dec68f151bfaebd1d0eaf6189698c2da0512a8 on julienduchesne:handle-starting-token into 02482f89d26c839b32100968e4f56896df41792f on spulec:master.

Coverage decreased (-0.003%) to 93.553% when pulling 14dec68f151bfaebd1d0eaf6189698c2da0512a8 on julienduchesne:handle-starting-token into 02482f89d26c839b32100968e4f56896df41792f on spulec:master.

Coverage decreased (-0.003%) to 93.553% when pulling 14dec68f151bfaebd1d0eaf6189698c2da0512a8 on julienduchesne:handle-starting-token into 02482f89d26c839b32100968e4f56896df41792f on spulec:master.

@julienduchesne Thank you so much for this! You've just improved this library for many thousands of users. Welcome to Moto!

Thanks!

This is now available in Moto version 1.1.4


[SUPPORT] hoodie commit time format change

Describe the problem you faced
We are trying to migrate hudi table from 0.8 to 0.12 and noticed that _hoodie_commit_time format has changed to include milliseconds.
Below is example of sample data in different version:
hudi 0.8:<PHONE_NUMBER>4733
hudi 0.12:<PHONE_NUMBER>1615400
Is there a property to configure timestamp format? We need this to ensure backward compatibility and also reduce changes to data while migrating
To Reproduce
Steps to reproduce the behavior:

Create a hudi table with version 0.8
Write data
Upgrade table to 0.12
Write data

Expected behavior
A clear and concise description of what you expected to happen.
Environment Description

Hudi version : 0.12

Spark version : 3.1

EMR version : EMR 6.3

Storage (HDFS/S3/GCS..) : S3

Running on Docker? (yes/no) : no

use hudi-cli or in 0.12, you can use spark procedure to upgrade table.
use hudi-cli:

use spark-sql:
call upgrade_table(table => 'xxx', to_version => 'FIVE');

@KnightChess My issue is not with table upgrade but timestamp format. Is there a property to configure _hoodie_commit_type timestamp format?

https://github.com/apache/hudi/pull/4024
look like none, https://hudi.apache.org/releases/release-0.10.0/#writer-side-improvements

@sknukala as @KnightChess mentioned you don't have to worry about the timestamp format as the new millisecond instant time is designed to be backward compatible.  You don’t have to do any special handling.
Do you have any specific reason for enforcing timestamp format?

@yihua A lot of downstreams use this column to incrementally pull data and change in format impacts all of them. If the format can be controlled, it will be easy.
Also, as we upgraded table, old data is in legacy format while new loads have ms leading to inconsistency.

@sknukala if you are using Hudi incremental query, the instant timestamp format (second vs millisecond granularity) should not matter, because internally Hudi treats the instant time as a String and uses the predicate based on the instant time with String comparison for filtering records, so millisecond-level instant time is still backward compatible with second-level instant time.  Could you clarify how the incremental pull is impacted?

@sknukala : let us know if you see any inconsistencies. and may be provide a reproducible script if feasible.

@yihua @nsivabalan : As you pointed, hudi is handling changes as it uses string comparison. However, this change is affecting places where _hudi_commit_column is casted to timestamp format. Ex: scripts loading incremental data to database using _hoodie_commit_time

hmmm, I see. sorry, I can't think of easier route here.
We can add a config to use older format if need be. But if a table already has a mix of both, not sure if we can do anything about it rather than fixing on the consumer end.
Also, we usually don't have any backporting fixes. i.e. even if we solve the issue, we can't port it back to 0.10.1 and other versions > 0.10.1.
sorry about that.
@xushiyan @yihua : can you folks think of any other approach here.

@nsivabalan : Adding a config to current hudi version 0.12 and future versions would help. Please let me know

@sknukala : is it not possible to fix the consumers to detech whether its sec or ms granularity before casting. bcoz, then you can never upgrade hudi to ms granularity and are essentially stuck.

@nsivabalan : the granularity of seconds just works fine for us. Having a config can help users control the timestamp format or if need be to adapt ms, we can plan this activity.
Currently, having a default to ms is blocking migration to hudi 12(as we need to update all consumers) and we are loosing all performance improvements implemented in recent hudi versions. with the config, upgrade would be seamless.

I discussed w/ few other hudi experts. We feel this has to be addressed at app layer where commit times are casted to timestamp. we don't have plans to support sec level granularity. sorry about that.
let us know if we can help in any other way.

If I disable the metadata to be written with each record that is processed, does it optimize the pipeline?


feat: implement table range checksums for reth db checksum

close https://github.com/paradigmxyz/reth/issues/7561
Check whether it is in the right direction.
cargo run --bin reth db checksum HashedAccounts --datadir ~/.local/share/reth/holesky  --start 0x005e54f1867fd030f90673b8b625ac8f0656e44a88cfc0b3af3e3f3c3d486960 --end 0x03089e01be9eb2af5ff5fa1c5983c6c6fb78dd734658d1f8f11d4f8d27a23fd5

And here is the result:
2024-04-13T17:16:42.693809Z  WARN This command should be run without the node running!
2024-04-13T17:16:42.695030Z  INFO <range>:: 0x005e54f1867fd030f90673b8b625ac8f0656e44a88cfc0b3af3e3f3c3d486960..=0x03089e01be9eb2af5ff5fa1c5983c6c6fb78dd734658d1f8f11d4f8d27a23fd5
2024-04-13T17:16:42.695765Z  INFO Hashed 0 entries.
2024-04-13T17:16:42.695850Z  INFO Hashed 4 entries.
2024-04-13T17:16:42.695895Z  INFO Checksum for table `HashedAccounts`: 0xf0b3ac90be2afa66 (elapsed: 301.167µs)

hey @AbnerZheng did my comment make sense / are you stuck on anything?

It makes sense.  But I am not familiar with these table, trying to sync a node on my server so that I could inspect these tables.

hey @AbnerZheng did my comment make sense / are you stuck on anything?

It makes sense. But I am not familiar with these table, trying to sync a node on my server so that I could inspect these tables.

btw it should be possible to test this with a testnet node, for example holesky, which is much smaller! lmk if you're still blocked or don't understand something - the table definitions are here
https://github.com/paradigmxyz/reth/blob/12873d515a9cea30d553fe938dc42a12c072562b/crates/storage/db/src/tables/mod.rs#L246-L380

@Rjected I have add another argument limit, and print the start-key and  end-key when running checksum.
So I can imagine the usage of this tool would like:

Get table name from running reth db stats if don't know name exactly.
Run checksum with limit being specified, but without setting start-key or end-key.  For example:

reth db checksum AccountsHistory --datadir ~/.local/share/reth/holesky --limit 100

The result would be like:
2024-04-30T15:27:36.360619Z  WARN This command should be run without the node running!
2024-04-30T15:27:36.360754Z  INFO Hashed 0 entries.
2024-04-30T15:27:36.360870Z  INFO Hashed 100 entries.
2024-04-30T15:27:36.360908Z  INFO start-key: {"key":"0x0000000000000000000000000000000000000000","highest_block_number":30161}
2024-04-30T15:27:36.360919Z  INFO end-key: {"key":"0x000000000000000000000000000000000000005e","highest_block_number":18446744073709551615}
2024-04-30T15:27:36.360934Z  INFO Checksum for table `AccountsHistory`: 0x98f8199844a34072 (elapsed: 178.629µs)

Compare the start-key, end-key, checksum with other. If they are the same, continue running the command with the end-key we got before as the new start-key, for example:

reth db checksum AccountsHistory --datadir ~/.local/share/reth/holesky --limit 100 --start-key '{"key":"0x000000000000000000000000000000000000005e","highest_block_number":18446744073709551615}'

We can get:
2024-04-30T15:32:01.614445Z  WARN This command should be run without the node running!
2024-04-30T15:32:01.614565Z  INFO start={"key":"0x000000000000000000000000000000000000005e","highest_block_number":18446744073709551615}
 end=
2024-04-30T15:32:01.614625Z  INFO Hashed 0 entries.
2024-04-30T15:32:01.614779Z  INFO Hashed 100 entries.
2024-04-30T15:32:01.614813Z  INFO start-key: {"key":"0x000000000000000000000000000000000000005e","highest_block_number":18446744073709551615}
2024-04-30T15:32:01.614820Z  INFO end-key: {"key":"0x00000000000000000000000000000000000000c1","highest_block_number":18446744073709551615}
2024-04-30T15:32:01.614833Z  INFO Checksum for table `AccountsHistory`: 0xadb85f752caba2fe (elapsed: 207.885µs)

repeat step 2 and 3 and to find the corrupt range. Or we can use binary search strategy if you like.

@Rjected bump

@Rjected I have add another argument limit, and print the start-key and end-key when running checksum.
I can imagine the usage of this tool would like:
1. Get the table name by running `reth db stats` if don't know the name exactly.

2. Run checksum with the argument `limit` being specified, but without setting `start-key` or `end-key`.  For example:

reth db checksum AccountsHistory --datadir ~/.local/share/reth/holesky --limit 100

The result would be like:
2024-04-30T15:27:36.360619Z  WARN This command should be run without the node running!
2024-04-30T15:27:36.360754Z  INFO Hashed 0 entries.
2024-04-30T15:27:36.360870Z  INFO Hashed 100 entries.
2024-04-30T15:27:36.360908Z  INFO start-key: {"key":"0x0000000000000000000000000000000000000000","highest_block_number":30161}
2024-04-30T15:27:36.360919Z  INFO end-key: {"key":"0x000000000000000000000000000000000000005e","highest_block_number":18446744073709551615}
2024-04-30T15:27:36.360934Z  INFO Checksum for table `AccountsHistory`: 0x98f8199844a34072 (elapsed: 178.629µs)

3. Compare the `start-key`, `end-key`, `checksum` with other. If they are the same, continue running the command with the `end-key` we got before as the new `start-key`, for example:

reth db checksum AccountsHistory --datadir ~/.local/share/reth/holesky --limit 100 --start-key '{"key":"0x000000000000000000000000000000000000005e","highest_block_number":18446744073709551615}'

We can get:
2024-04-30T15:32:01.614445Z  WARN This command should be run without the node running!
2024-04-30T15:32:01.614565Z  INFO start={"key":"0x000000000000000000000000000000000000005e","highest_block_number":18446744073709551615}
 end=
2024-04-30T15:32:01.614625Z  INFO Hashed 0 entries.
2024-04-30T15:32:01.614779Z  INFO Hashed 100 entries.
2024-04-30T15:32:01.614813Z  INFO start-key: {"key":"0x000000000000000000000000000000000000005e","highest_block_number":18446744073709551615}
2024-04-30T15:32:01.614820Z  INFO end-key: {"key":"0x00000000000000000000000000000000000000c1","highest_block_number":18446744073709551615}
2024-04-30T15:32:01.614833Z  INFO Checksum for table `AccountsHistory`: 0xadb85f752caba2fe (elapsed: 207.885µs)

4. repeat step 2 and 3 and to find the corrupt range. Or we can use binary search strategy if you like.

So instead of documenting the unit, user can know how key would look like by running directly with limit setted and without setting start-key and end-key.

this sounds great! taking a look at the changes

bump @Rjected


Is this framework applicable on node-regression tasks for graphs?

It can't support node regression task. You can see the paper for details.


Comparison with Llama3

I see you compared your version with other models, but what about the version from which you derived it?
Thanks

In the weblinx paper, we have found that non-finetuned models are not as good as finetuned models, so it is unlikely that Llama-3-8b-Instruct surpasses Llama-3-8B-Web. However, if you think it's worth adding the results, it should be fairly straightforward to run the eval script with minor changes to the config: https://github.com/McGill-NLP/webllama/tree/main/modeling#run-llama-on-evaluation-splits


Ubuntu 16.04 + cupy

Hi all. Been banging my head agaisnt the wall trying to sort this out.
I am trying to install Chainer/cupy with CUDA support. As far as I see my CUDA environment is set up correctly. nvidia-smi shows the correct output (ie. picking up the video card).
My PATH is set up as well:
/usr/src/miriad/linux64/bin:/usr/local/cuda/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/usr/games:/usr/local/games
and can pick up nvcc by invocation on the command line.
Installing Chainer through pip install --user -vvvv --no-cache-dir chainer doesn't appear to show any problems. The beginning of the pip output below:
Running setup.py (path:/tmp/pip-build-68qLGz/chainer/setup.py) egg_info for package chainer
Running command python setup.py egg_info
running egg_info
creating pip-egg-info/chainer.egg-info
writing requirements to pip-egg-info/chainer.egg-info/requires.txt
writing pip-egg-info/chainer.egg-info/PKG-INFO
writing top-level names to pip-egg-info/chainer.egg-info/top_level.txt
writing dependency_links to pip-egg-info/chainer.egg-info/dependency_links.txt
writing manifest file 'pip-egg-info/chainer.egg-info/SOURCES.txt'
Executing cythonize
Options: {'profile': False, 'annotate': False, 'linetrace': False, 'no_cuda': False}
Include directories: ['/usr/local/cuda/include']
Library directories: ['/usr/local/cuda/lib64']
creating /tmp/tmpR22XRu/tmp
creating /tmp/tmpR22XRu/tmp/tmpR22XRu
x86_64-linux-gnu-gcc -pthread -DNDEBUG -g -fwrapv -O2 -Wall -Wstrict-prototypes -fno-strict-aliasing -Wdate-time -D_FORTIFY_SOURCE=2 -g -fstack-protector-strong -Wformat -Werror=format-security -fPIC -I/usr/local/cuda/include -c /tmp/tmpR22XRu/a.cpp -o /tmp/tmpR22XRu/tmp/tmpR22XRu/a.o
cc1plus: warning: command line option ‘-Wstrict-prototypes’ is valid for C/ObjC but not for C++
c++ -pthread -shared -Wl,-O1 -Wl,-Bsymbolic-functions -Wl,-Bsymbolic-functions -Wl,-z,relro -fno-strict-aliasing -DNDEBUG -g -fwrapv -O2 -Wall -Wstrict-prototypes -Wdate-time -D_FORTIFY_SOURCE=2 -g -fstack-protector-strong -Wformat -Werror=format-security -Wl,-Bsymbolic-functions -Wl,-z,relro -Wdate-time -D_FORTIFY_SOURCE=2 -g -fstack-protector-strong -Wformat -Werror=format-security /tmp/tmpR22XRu/tmp/tmpR22XRu/a.o -o /tmp/tmpR22XRu/liba.so
creating /tmp/tmp0wp0Kb/tmp
creating /tmp/tmp0wp0Kb/tmp/tmp0wp0Kb
x86_64-linux-gnu-gcc -pthread -DNDEBUG -g -fwrapv -O2 -Wall -Wstrict-prototypes -fno-strict-aliasing -Wdate-time -D_FORTIFY_SOURCE=2 -g -fstack-protector-strong -Wformat -Werror=format-security -fPIC -c /tmp/tmp0wp0Kb/a.cpp -o /tmp/tmp0wp0Kb/tmp/tmp0wp0Kb/a.o
cc1plus: warning: command line option ‘-Wstrict-prototypes’ is valid for C/ObjC but not for C++
c++ -pthread -shared -Wl,-O1 -Wl,-Bsymbolic-functions -Wl,-Bsymbolic-functions -Wl,-z,relro -fno-strict-aliasing -DNDEBUG -g -fwrapv -O2 -Wall -Wstrict-prototypes -Wdate-time -D_FORTIFY_SOURCE=2 -g -fstack-protector-strong -Wformat -Werror=format-security -Wl,-Bsymbolic-functions -Wl,-z,relro -Wdate-time -D_FORTIFY_SOURCE=2 -g -fstack-protector-strong -Wformat -Werror=format-security /tmp/tmp0wp0Kb/tmp/tmp0wp0Kb/a.o -L/usr/local/cuda/lib64 -lcublas -lcuda -lcudart -lcurand -lnvToolsExt -o /tmp/tmp0wp0Kb/liba.so
creating /tmp/tmpCV_ZU2/tmp
creating /tmp/tmpCV_ZU2/tmp/tmpCV_ZU2
x86_64-linux-gnu-gcc -pthread -DNDEBUG -g -fwrapv -O2 -Wall -Wstrict-prototypes -fno-strict-aliasing -Wdate-time -D_FORTIFY_SOURCE=2 -g -fstack-protector-strong -Wformat -Werror=format-security -fPIC -I/usr/local/cuda/include -c /tmp/tmpCV_ZU2/a.cpp -o /tmp/tmpCV_ZU2/tmp/tmpCV_ZU2/a.o
cc1plus: warning: command line option ‘-Wstrict-prototypes’ is valid for C/ObjC but not for C++
c++ -pthread /tmp/tmpCV_ZU2/tmp/tmpCV_ZU2/a.o -o /tmp/tmpCV_ZU2/a
Include directories: ['/usr/local/cuda/include']
Library directories: ['/usr/local/cuda/lib64']
creating /tmp/tmptdiHao/tmp
creating /tmp/tmptdiHao/tmp/tmptdiHao
x86_64-linux-gnu-gcc -pthread -DNDEBUG -g -fwrapv -O2 -Wall -Wstrict-prototypes -fno-strict-aliasing -Wdate-time -D_FORTIFY_SOURCE=2 -g -fstack-protector-strong -Wformat -Werror=format-security -fPIC -I/usr/local/cuda/include -c /tmp/tmptdiHao/a.cpp -o /tmp/tmptdiHao/tmp/tmptdiHao/a.o
cc1plus: warning: command line option ‘-Wstrict-prototypes’ is valid for C/ObjC but not for C++
c++ -pthread -shared -Wl,-O1 -Wl,-Bsymbolic-functions -Wl,-Bsymbolic-functions -Wl,-z,relro -fno-strict-aliasing -DNDEBUG -g -fwrapv -O2 -Wall -Wstrict-prototypes -Wdate-time -D_FORTIFY_SOURCE=2 -g -fstack-protector-strong -Wformat -Werror=format-security -Wl,-Bsymbolic-functions -Wl,-z,relro -Wdate-time -D_FORTIFY_SOURCE=2 -g -fstack-protector-strong -Wformat -Werror=format-security /tmp/tmptdiHao/tmp/tmptdiHao/a.o -o /tmp/tmptdiHao/liba.so
creating /tmp/tmpw2rG0J/tmp
creating /tmp/tmpw2rG0J/tmp/tmpw2rG0J
x86_64-linux-gnu-gcc -pthread -DNDEBUG -g -fwrapv -O2 -Wall -Wstrict-prototypes -fno-strict-aliasing -Wdate-time -D_FORTIFY_SOURCE=2 -g -fstack-protector-strong -Wformat -Werror=format-security -fPIC -c /tmp/tmpw2rG0J/a.cpp -o /tmp/tmpw2rG0J/tmp/tmpw2rG0J/a.o
cc1plus: warning: command line option ‘-Wstrict-prototypes’ is valid for C/ObjC but not for C++
c++ -pthread -shared -Wl,-O1 -Wl,-Bsymbolic-functions -Wl,-Bsymbolic-functions -Wl,-z,relro -fno-strict-aliasing -DNDEBUG -g -fwrapv -O2 -Wall -Wstrict-prototypes -Wdate-time -D_FORTIFY_SOURCE=2 -g -fstack-protector-strong -Wformat -Werror=format-security -Wl,-Bsymbolic-functions -Wl,-z,relro -Wdate-time -D_FORTIFY_SOURCE=2 -g -fstack-protector-strong -Wformat -Werror=format-security /tmp/tmpw2rG0J/tmp/tmpw2rG0J/a.o -L/usr/local/cuda/lib64 -lcudnn -o /tmp/tmpw2rG0J/liba.so

Looking in the lib/python2.7/site-packages/cupy/core directory I see that core.so,flags.so and internal.so have been compiled.
Yet, when I try to import cupy, I get the following error:
RuntimeError: CuPy is not correctly installed. Please check your environment, uninstall Chainer and reinstall it with pip install chainer --no-cache-dir -vvvv.
Any thoughts or suggestions on how to proceed would be very much appreciated. I don't understand what is wrong with my environment. I have managed to compile OpenCV with the cuda bindings without issue very recently.

For reference to all, I think I have fixed it. I am still not sure what exactly I did that fixed it. I simply removed nvidia/cuda completely and reinstalled. I also reinstalled g++. Upon reinstalling CUDA I asked it to installed the package driver. A simply pip install --no-cache-dir --user chainer worked.

On my environment, I can use Cupy (Ubuntu 16.04, AWS p2.xlarge).
I've installed Chainer with sudo pip install chainer.
% lsb_release -a
No LSB modules are available.
Distributor ID:	Ubuntu
Description:	Ubuntu 16.04.1 LTS
Release:	16.04
Codename:	xenial

% echo $PATH
/home/wkentaro/.local/bin:/usr/local/bin:/usr/local/sbin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/usr/games:/usr/local/games

% echo $LD_LIBRARY_PATH
/usr/local/cuda/lib64:

% python -c 'import cupy; print cupy'
<module 'cupy' from '/usr/local/lib/python2.7/dist-packages/cupy/__init__.pyc'>

Sorry for late reply. It looks you successfully compiled the library. I can find no error.
Maybe it is a problem of your running environment. Can you check LD_LIBRARY_PATH?

@ unnonouno - no problem. I ended up completely removing CUDA, and reinstalling with the .run file. Everything else was exactly the same, and cupy compiled correctly and is importable from python. Was at a loss because I don't think I edited by bash rc scripts (ie. the PATH and LD_LIBRARY_PATH were unchanged). I am not questioning it though as it works now!

Oh, great! Is it Ok to close this issue?

Yes - no objections here. Big thanks for the package.


Add unique cell identifiers

Context
See Cell Census unique cell identifiers.

Design
From @pablo-gar :
Per triage:
Use case to fulfill
Census cell can be mapped to a cell in its source h5ad.
Requirements

A row identifier is included in the dataset schema. Best encoding candidate, an integer ranging from 1 to number of cells in dataset under adata.obs["source_cell_row"]
The row identifier is included in the Census schema by drawing from the source h5ads.

Allows

Mapping a cell from the Census to the source h5ad.
Having a unique cell id by concatenating dataset_id, dataset_version_id and source_cell_row.

"source_cell_row" is a suggestion, better names may exist @BAevermann @jahilton @bkmartinjr

The Requirements did not originate from the triage call.
I suggest we use the index as the row identifiers rather than add a new field.

I believe @bkmartinjr had some hesitations with using the index, as in currently it is too flexible to encode anything (e.g. int, float, strings) this can be problematic for the census since we cannot have multi-type columns.
We could enforce data-type consistency of the anndata index or replace it with a new index, in the first scenario that means there may be some extra load on the curators to make sure it passes the validation.

AnnData historically requires a string index, which would bloat the Census memory use, etc. In addition, AnnData is reportedly moving away from string-only, which would be very hard for us to encode (as Pablo mentions).  So ideally we would have something more compact and supporting polymorphic index keys.
There is one possibility -- we could simply use a well defined hash of the index value (whatever that value is in the source H5AD), and store the hash digest as an int64 source_data_key.  Assuming we pick a well-defined hash function and converstion method from "index_value" to hash, then:
Pro:

very easy to encode, with good space characteristics
very fast to encode from any value (need to establish the method, but likely something as simple as  hash(str(index_value))
fast lookup in both SOMA and AnnData (i.e., you can use it as an obs index if you want to do so)
can be created dynamically/on-demand if we don't want to store it inside the H5AD

Con:

not an array offset value - slightly more overhead to than an iloc-style offset.  Mostly affects use cases doing bulk operations.
not reversible - you can't reverse the hash to get the index key.  Not sure if this is a problem in reality.

If you do want to explore this further, I have thoughts on possible hashes and implementation.

If you do want to explore this further, I have thoughts on possible hashes and implementation.

Please tell us more.

bloat the Census memory use
AnnData is reportedly moving away from string-only, which would be very hard for us to encode

Thank you. Both are reasonable justification for not using the existing index (which would have provided likely, but not guaranteed, consistency across versions)
For naming the field, I would suggest including census in the name to avoid confusion for a user looking at the downloaded file without the context of the Census.
I have a slight preference for obs/observation over cell.
census_observation_id?

Having the word census in there will then be confusing for census users. A few other suggestions:

h5ad_observation_row
h5ad_observation_id
source_observation_row
source_observation_id
census_h5ad_join_id

I like 5

Please tell us more.

OTOMH:

Pick a fast non-cryptographic hash with availability in Python & R packages.  xxhash would be a good choice (very fast, available in Python and R packages).  There are others (slower, but somewhat more commonly available).
Store the hash as either an int64 digest (best) or a string digest (less best, but OK)
Well-defined conversion of AnnData obs.index values to hash input.  This is easy - just need to write it down.  (e.g., for strings, take the UTF-8 raw bytes and hash it;  for ints, hash the raw little-endian bytes;  etc)

From June 27 call with @jahilton, @bkmartinjr, @pablo-gar, @brianraymor

observation_joinid proposed as the name in obs.
@bkmartinjr to prototype hash.
@pablo-gar to draft schema proposal. This field is calculated/added by the portal during ingestion and should NOT be presented in Explorer.

Proto which adds observation_joinid to an H5AD and writes out a new H5AD containing the modification.
import os.path
import sys

import anndata
import numpy as np
import xxhash

"""
Annotate an H5AD with `observation_joinid`

Uses xxhash (https://xxhash.com/), via https://pypi.python.org/pypi/xxhash/.

NOTE: xxhash is licensed BSD-2
"""

def main():
    h5ad_filename = sys.argv[1]
    ad = anndata.read_h5ad(h5ad_filename)

    ad.obs["observation_joinid"] = (
        ad.obs.index.to_series()
        .map(lambda idx: xxhash.xxh3_64_intdigest(idx, seed=0))
        .astype(np.uint64)
    )

    fpath, fext = os.path.splitext(h5ad_filename)
    save_to_filename = f"{fpath}_with_joinid.h5ad"
    ad.write(save_to_filename)

if __name__ == "__main__":
    sys.exit(main())

observation_joinid

Key
observation_joinid

Annotator
Data Portal

Value
int64.This `MUST` be the int64-encoded output of the {HASH FUNCTION} applied to the index of var. It represents a unique observation identifier for the given versioned dataset.

@pablo-gar - two questions to help refine this:

any issues using a 64-bit int for the R user base?
any reason to prefer int64 vs. uint64?   We can cast to either, as it doesn't change the number of bits in the hash.  I did the proto above using uint, but it is easily fixed.

@pablo-gar - I'm confused by these references.

Draft schema addition for var and raw.var
... applied to the index of var

@pablo-gar - I'm confused by https://github.com/chanzuckerberg/single-cell-curation/issues/522#issuecomment-1610356230.

Draft schema addition for var and raw.var
... applied to the index of var

Mistake, it must be obs

@pablo-gar - two questions to help refine this:

any issues using a 64-bit int for the R user base?

AFAIK R doesn't have issue with 64-bit encoded values (R tiledbsoma uses them all the time). The issue comes when allocating vectors (lists) with number of elements greater than the max 32-bit number

any reason to prefer int64 vs. uint64? We can cast to either, as it doesn't change the number of bits in the hash. I did the proto above using uint, but it is easily fixed.

No strong preference and I was not thinking about them, uint64 seems cleaner to me I'd say keep it that way.

@pablo-gar @jahilton - I don't see a rationale for exposing this field in the Seurat encoding. (And if we did, it would be a numeric?)

I don't see a rationale for exposing this field in the Seurat encoding

Isn't the rationale the same for including it in the AnnData objects?
I'm a ~python~ R user of the Census and want to link my selected observations to the observations in CELLxGENE Datasets that have more metadata.

We need to make compatibility with R  a requirement. tiledbsoma which is required by Census has a dependency on bi64.
I see two options:

We encode this as a unit32 OR
We ensure bi64 is used during the Seurat conversion.

We encode this as a unit32 OR

R does not support unsigned 32 bit integers?

We ensure bit64 is used during the Seurat conversion.

I do not believe that bit64 supports unsigned 64 bit integers per:

Package 'bit64' provides serializable S3 atomic 64bit (signed) integers

Reading Arrow R Package:

Some of these differences are purely cosmetic: integers in R are in fact 32 bit signed integers, so the underlying data types in Arrow and R are direct analogs of one another. In other cases the differences are purely about the implementation: Arrow and R have different ways to store a vector of strings, but at a high level of abstraction the R character type and the Arrow string type can be viewed as direct analogs. In some cases, however, there are no clear analogs: while Arrow has an analog of POSIXct (the timestamp type) it does not have an analog of POSIX; conversely, while R can represent 32 bit signed integers, it does not have an equivalent of a 64 bit unsigned integer.

final suggested "Description"

A short string which uniquely identifies the observation within the dataset.

Wouldn't this just be replacing uint64 with str in the value row?
Perhaps I don't understand the significance of a short string.

We could say "string" rather than "short string". I'm not sure "short' adds any real value (even though I think the word originated with me!)


Context set in beforeEach is not available in tests

Test file:
import test from 'ava';

test.beforeEach(t => {
  t.context = 'unicorn';
  t.end();
});

test(t => {
  t.is(t.context, 'unicorn');
  t.end();
});

Result:
 ✔ [anonymous]
  ✖ [anonymous] undefined === 'unicorn'

Copy-pasted your code and ran with ava#master:

Are you using master branch or installing via npm?

npm

There were some changes in the way we set context after the release (I think), so as I see, this issue is resolved in master.

Ok, thanks for the update!

https://github.com/sindresorhus/ava/releases/tag/v0.4.0


Incorrect value into mlflow_http_client

In the __init__ for ModelExporter, the package uses the MLFLOW_TRACKING_URI to create the HTTP_CLIENT, even though the URI is not correct (should use the value from the MLFLOW_CLIENT tracking_uri).
This causes errors if the env var MLFLOW_TRACKING_URI is not set, and is a risk if it is not overridden later.
https://github.com/mlflow/mlflow-export-import/blame/master/mlflow_export_import/model/export_model.py#L89

MLFLOW_TRACKING_URI  has to be set. The tool does not handle file-based store where not MLFLOW_TRACKING_URI  is needed. Not sure what the issue is.


chore: initializing dev 1.4.0

Issue #, if available:
Description of changes:
initializing dev 1.4.0
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

AWS CodeBuild CI Report

CodeBuild project: IDFModuleTestsInfrastructur-59JoFoVH64CI
Commit ID: c50dba6d62c2fa71ac847798d4de993c96d67ac2
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository


Bugfix/product image loader

Short description and why it's useful
I extract to the new component images loading strategy implemented in Product Gallery Carousel and use it on Producta Gellery Carousel and Product Gallery Zoom Carousel components.
Which environment this relates to
Check your case. In case of any doubts please read about Release Cycle

[x] Test version (https://test.storefrontcloud.io) - this is a new feature or improvement for Vue Storefront. I've created branch from develop branch and want to merge it back to develop
[ ] RC version (https://next.storefrontcloud.io) - this is a stabilisation fix for Release Candidate of Vue Storefront. I've created branch from release branch and want to merge it back to release
[ ] Stable version (https://demo.storefrontcloud.io) - this is an important fix for current stable version. I've created branch from hotfix or master branch and want to merge it back to hotfix

Upgrade Notes and Changelog

[x] No upgrade steps required (100% backward compatibility and no breaking changes)
[ ] I've updated the Upgrade notes and Changelog on how to port existing VS sites with this new feature

IMPORTANT NOTICE - Remember to update CHANGELOG.md with description of your change
Contribution and currently important rules acceptance

[x] I read and followed contribution rules
[x] I read the TypeScript Action Plan and adjusted my PR according to it
[x] I read about Vue Storefront Modules and I am aware that every new feature should be a module

@patzick

I removed hidden props from component and use v-show on parent component
Used $listeners to stop using '.native' event
I set default for all props and removed required
Cheged object name to 'image'

I used https://css-tricks.com/aspect-ratio-boxes/ to maintaining image size. I used  to this mathematic  formula {height% / ( width / 100 )}

Merged and ready for tests

@przspa You forgot about pictures in checkout :)

Related to #2863 - @przspa please take a look :)

@przspa You forgot about pictures in checkout :)
 #3013 fixed my mistake


chore(bump-e-common): Updated expensify-common ref hash

@AndrewGable Can you review this PR?
Details

Merges hyperlink changes from expensify-common to the App

Fixed Issues

$ Fixes App/4229
Tests

QA Steps

Type [Yo (click here to see a cool cat)](https://c8.alamy.com/compes/ha11pc/cookie-cat-con-sombrero-de-cowboy-y-sun-glass-ha11pc.jpg) (without `)
Verify it hyperlinks correctly

Tested On

[x] Web
[x] Mobile Web
[x] Desktop
[x] iOS
[x] Android

Screenshots

Web
https://user-images.githubusercontent.com/3069065/127357607-b09cc0f1-6e6c-4b0d-9d1a-6e53df0e3eec.mp4
Mobile Web
https://user-images.githubusercontent.com/3069065/127372250-daec48b7-855b-4965-b11b-7cffddc227cf.mp4
Desktop
https://user-images.githubusercontent.com/3069065/127357442-98d02450-cdf1-45d1-8cea-0bf6f136d99b.mp4
iOS
https://user-images.githubusercontent.com/3069065/127385748-6e297267-fa5c-47e2-8851-5b0fa654c545.mp4
Android
https://user-images.githubusercontent.com/3069065/127372048-5dbce2a9-172b-4252-98d2-6f0945f65ffe.mp4

@AndrewGable  Can you review this PR. Hopefully, this should pass all the checks.

So unfortunately I am seeing a weird bug on this PR now, it's only running one check from my end. Not the tests & lint 😞

Ohh just saw the count! Something wrong at my end?

Github actions not working. Closing this PR.

Received a notification from GitHub for this. Temp error from github.


[Community] PremAI Tool Calling Functionality

This PR is under WIP and adds the following functionalities:

[X] Supports tool calling across the langchain ecosystem. (However streaming is not supported)
[X] Update documentation

Hi, I am seeing one check is failing, but is unrelated with the changes I am done here.
tests/unit_tests/document_loaders/parsers/test_pdf_parsers.py::test_pdfminer_parser FAILED [ 36%]

Let me know if we can merge this or anything that I need to do from my side. Thanks
cc: @baskaryan

This is fixed, after pulling the latets changes from master. Thanks :)

Hi can some one please review this PR, since it has been a while. Thanks a ton :)
cc: @baskaryan @startime-h

Hi can some one please review this PR, since it has been a while. Thanks a ton :)
cc: @baskaryan @startime-h

Hi, it has been quite some days, it would be great if some one could review the PR. Thanks

Hi can some one please review this PR. Thanks Sorry I need to tag so much, however let me know if it can be merged.
cc: @eyurtsev, @baskaryan

Hi @Anindyadeep,
Do you want to add tests for the code changes here?
Langchain has a suite of standard tests for chat models in the standard-tests library, which is already a test dependency of langchain-community. It includes tests for tool calling. What do you think about adding these for PremAI?
Here is an example implementation for integration tests: https://github.com/langchain-ai/langchain/blob/master/libs/partners/fireworks/tests/integration_tests/test_standard.py
And unit tests: https://github.com/langchain-ai/langchain/blob/master/libs/partners/fireworks/tests/unit_tests/test_standard.py
We can add xfails (as in the example) if needed where tests are failing. But this will at least illuminate the failures and provide tests for the functionality implemented here.


Pass references to avoid clones

This was to also remove clones on the stacks-signer side.
Most of the functions off of "process_inbound_messages" do not need to own the data passed to them

Codecov Report

Merging #30 (46dd407) into main (e87f997) will decrease coverage by 0.48%.
Report is 2 commits behind head on main.
The diff coverage is 72.11%.

:exclamation: Current head 46dd407 differs from pull request most recent head d0b4217. Consider uploading reports for the commit d0b4217 to get more accurate results

@@            Coverage Diff             @@
##             main      #30      +/-   ##
==========================================
- Coverage   78.75%   78.27%   -0.48%
==========================================
  Files          12       14       +2
  Lines        1365     1372       +7
==========================================
- Hits         1075     1074       -1
- Misses        290      298       +8

Files
Coverage Δ

src/taproot.rs
91.83% <ø> (ø)

src/v1.rs
86.52% <ø> (ø)

src/v2.rs
90.00% <ø> (ø)

src/state_machine/coordinator/mod.rs
0.00% <0.00%> (ø)

src/state_machine/signer/mod.rs
75.51% <75.51%> (ø)

src/state_machine/coordinator/frost.rs
69.79% <69.79%> (ø)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Self-tuning database

Is self-tuning feature possible in Cayley like in [Concourse][1], removing the need for database configurations?
[1]: https://github.com/cinchapi/concourse

Not sure what that means - you will need to at least configure the backend.
Closing for now. Feel free to reopen if you have some specific features in mind.


[BUG] The resource 'projects/debian-cloud/global/images/family/debian-10' was not found

Current Behavior
Installing the GCP Connector can't be finished due to the debian-10 not being found anymore, GCP has updated the Debian family to v11 or v12.
Expected Behavior
It should automatically select the Image from GCP so the same error should not raise any more when there is an updated version.
Steps to Reproduce

Create a GCP Connector as usual.
Click Connector and click the 3 dots then click Install
Step 1/8 would raise ERROR.

Failure Logs
Error
The resource 'projects/debian-cloud/global/images/family/debian-10' was not found

Scrapoxy Version
4.11.1
Custom Version

[X] No
[ ] Yes

Deployment

[ ] Docker
[ ] Docker Compose
[ ] Kubernetes
[X] NPM
[ ] Other (Specify in Additional Information)

Operating System

[X] Linux
[X] Windows
[ ] macOS
[ ] Other (Specify in Additional Information)

Storage

[ ] File (default)
[ ] MongoDB & RabbitMQ
[ ] Other (Specify in Additional Information)

Additional Information
No response

Hello,
Thanks for reporting the issue.
I've changed to debian-12.
Release 4.11.2 solved it.
Fabien


Updates to Rake tasks

Use pry in console task for nicer formatting and debugging tools
Move man page generation to man rake task
Reorganize test tasks

Move rspec and minitest tasks under the test namespace
Create separate coverage task for generating coverage reports from tests

Don't know enough about Ruby testing to have an opinion either way, but LGTM.
Why is the seed needed?

Why is the seed needed?

There's some temporal dependency in our integration tests that requires certain tests be run before others, and it's been there for a long time (#5037, #5064, #5613, #6611, #8871). Nobody has put in the time to root it out yet.


worksheet url

when we grab worksheet url from Publish to the Web popup, there's only list and cells url. please mention in README.md that we need to change /list/ (or /cells/) into /worksheets/.

I need more information about this issue.  Is the "Publish to the Web" popup on Google Docs when you are publishing the spreadsheet?   Can you be more specific?  Thanks!

If more information is added to the issue I will work on this.

Pop up on File > Publish to the Web. Grabbing the atom URL, you get either
https://spreadsheets.google.com/feeds/list/ID/od6/public/basic?hl=en_US or
https://spreadsheets.google.com/feeds/cells/ID/od6/public/basic?hl=en_US.
i got syncservice working by manually editing either one of those into https://spreadsheets.google.com/feeds/worksheet/ID/public/basic (turn "list" into "worksheet" and remove "od6".


Hide div based on specific screen size

Is there a way to hide an element if it hits a certain screen size?  For example something like medium-0 which would actually hide a div?
The problem I have is right now my sticky nav works great on large screens.  The nav sits at the left of the screen.  But on smaller screens, I'm not able to get that sticky to float at the top instead.  I can it it to fill a space at the top but it doesn't stick there, it's still overrunning the content.  So I figure if the screen is that small, I'll just hide the nav.
WeDoTDD.com

duh nevermind found it.  hide-medium, etc.


All logs are ending up in start_log.txt

They should go to their respective logging files after hyperion startup

Should have been fixed in and/or #911 #1186