E2E prototype for Azure Storage Block blob service.

There are some todo's to be resolved, especially a memory management issue for request with a request body.

It allows a customer to roll over a key while the service is running.

Jeffrey Richter (watch Architecting Distributed Cloud Appshttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fazure.microsoft.com%2Ftraining%2Fdistributed-cloud-apps%2F&data=02|01|jeffreyr%40microsoft.com|82df4ff9e5ae46a5095908d7345e957b|72f988bf86f141af91ab2d7cd011db47|1|0|637035453166233741&sdata=4GnkpFUKxlZXGXFr6oQo5GB%2FFNIbDXIZDXUij0q4AEE%3D&reserved=0)

From: JinmingHu<EMAIL_ADDRESS>Sent: Sunday, May 10, 2020 9:18 AM
To: Azure/azure-sdk-for-cpp
Cc: Jeffrey Richter; Review requested
Subject: Re: [Azure/azure-sdk-for-cpp] E2E prototype for Azure Storage Block blob service. (#95)
@JinmingHu-MSFT commented on this pull request.

In sdk/storage/inc/common/unused/StorageSharedKeyCredential.hhttps://github.com/Azure/azure-sdk-for-cpp/pull/95#discussion_r422666262:

+#pragma once
+
+#include
+#include
+
+namespace Azure { namespace Storage {
+
+class StorageSharedKeyCredential
+{
+public:

StorageSharedKeyCredential(std::string accountName, std::string accountKey);

const std::string& GetAccountName() const;
const std::string& GetAccountKey() const;
void SetAccountKey(std::string accountKey);

When will this function be used?
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHubhttps://github.com/Azure/azure-sdk-for-cpp/pull/95#pullrequestreview-408759648, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AARLJPYKHN7ASANZBJDVJU3RQ3HULANCNFSM4M4TLKZQ.

You want the methods the base class in addition to the derived classes. The base class allows the customer to create a client without knowing what kind of blob it is. But this still should support snapshots and version.
In c#, the base method can return the base type and the derived typed can return their own types. I'm not sure if c++can do it; we'd have to experiment and see what's possible.

Jeffrey Richter (watch Architecting Distributed Cloud Appshttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fazure.microsoft.com%2Ftraining%2Fdistributed-cloud-apps%2F&data=02|01|jeffreyr%40microsoft.com|82df4ff9e5ae46a5095908d7345e957b|72f988bf86f141af91ab2d7cd011db47|1|0|637035453166233741&sdata=4GnkpFUKxlZXGXFr6oQo5GB%2FFNIbDXIZDXUij0q4AEE%3D&reserved=0)

From: JinmingHu<EMAIL_ADDRESS>Sent: Sunday, May 10, 2020 9:14 AM
To: Azure/azure-sdk-for-cpp
Cc: Jeffrey Richter; Review requested
Subject: Re: [Azure/azure-sdk-for-cpp] E2E prototype for Azure Storage Block blob service. (#95)
@JinmingHu-MSFT commented on this pull request.

In sdk/storage/inc/blobs/unused/blob_client.hhttps://github.com/Azure/azure-sdk-for-cpp/pull/95#discussion_r422665834:

+class BlobClient
+{
+public:

// connection string
BlobClient(const std::string& connectionString, std::string containerName, std::string blobName, BlobClientOptions options = BlobClientOptions());

// shared key auth
BlobClient(Azure::Core::Http::Uri uri, Azure::Storage::Common::StorageSharedKeyCredential credential, BlobClientOptions options = BlobClientOptions());

// token auth
BlobClient(Azure::Core::Http::Uri uri, Azure::Core::TokenCredential credential, BlobClientOptions options = BlobClientOptions());

// anonymous/SAS/customized pipeline auth
BlobClient(Azure::Core::Http::Uri uri, BlobClientOptions options = BlobClientOptions());

void SetSnapshotTime(const std::string& snapshot);

This makes the client no thread-safe. See the Go pattern way for doing this. Changing a snapshot (or version) returns a NEW client with the new URL. The only client remains so other threads using it are not affected.
In that case, we have to move these snapshot function and versionId function to derived class like BlockBlobClient, AppendBlobClient. Because in C++, we cannot override function only by return type.
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHubhttps://github.com/Azure/azure-sdk-for-cpp/pull/95#discussion_r422665834, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AARLJP4JITW6VIBBXEEDCALRQ3HF7ANCNFSM4M4TLKZQ.

This PR is not valid anymore, maybe we should close it? @katmsft

Closed this PR as it is no longer valid.


pull request for e2e test at 12/09/2016 00:56:03

:white_check_mark: Validation status: passed
For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Add pedsim_sensors/point_cloud.cpp: (pointcloud with occlusion)

Hi,
Since the original pedsim_sensors doesn't consider occlusion, I add a point_cloud.cpp, which publishes occluded people and obstacles pointcloud.
Try it by
roslaunch pedsim_sensors  pedsim_sensor.launch

Thanks for this. Other than the two comments above, it looks nice. Also do you have a viz of of the PCD with occlusion you can attach here? You can use srl_tracking_rviz_plugin options for showing bounding boxes, then add the standard rviz point cloud visualization

Thank you for the review.
Here is the visualization of the occluded PCD. You can see there is occlusion due to a square obstacle.

Also, I use complex since it is easier to deal with vector-like calculation such as addition and angle calculation, but it is ambiguous as you said.
I modify the code and create new pull request based on your advice.


Base manager can now be used for clean_duplicate_history

Description
clean_duplicate_history uses objects as manager. This has now been changed to _default_manager and an option added to use _base_mananger.
Related Issue
none
Motivation and Context
We use a manager to filter records by default, however we want to remove all records from duplicates.
How Has This Been Tested?
The command was first run without parameters and then with the new --base-manager parameter.
Screenshots (if appropriate):
none
Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[ ] I have run the make format command to format my code
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[ ] I have read the CONTRIBUTING document.
[x] I have added tests to cover my changes.
[ ] I have added my name and/or github handle to AUTHORS.rst
[ ] I have added my change to CHANGES.rst
[x] All new and existing tests passed.

Would you mind adding tests in simple_history/tests/tests/test_commands.py to make sure both code branches have coverage?

@nick-traeger This is looking like a nice contribution for folks who use custom managers to filter their models' queries.
Would you go through the checklist (from your initial comment) and make sure you've completed the necessary items? Most are already complete or very minor updates. I checked off a couple for you that are clearly already done.
Also, would you mind adding a short note about usage of the new option in the Utils docs page?

Needs to be rebased.


Update Puppeteer.md

Summary
The instructions on this page didn't worked for me and seemed somewhat outdated.
After digging a bit I found that the right "project" (for recent Jest + Puppeteer) is actually jest-environment-puppeteer.
Test plan
No tests needed for documentation changes

Hmm, that package comes from the same monorepo as the preset. If the preset is broken, shouldn't we just report it there? I don't think this change is the correct one (although I've never used it, so I'm just going off of a cursory look in that repo)

Yeah this change is not relevant, if something is broken we have to fix it on our side.

Perfect, thanks!


[as2_gazebo_assets] Gazebo INDI controller plugin

Basic Info

Info
Please fill out this column

Issue(s) this addresses

ROS2 version tested on
Humble

Aerial platform tested on
Gazebo

Description of contribution in a few bullet points

Description of documentation updates required from your changes

Future work that may be required in bullet points

Plugin not building in Gz Fortress, changing to draft


need  libAlexaCommsLib.so file compatible for 64bit

IMPORTANT: Before you create an issue, please take a look at our Issue Reporting Guide.
Briefly summarize your issue:

I have NXP iMX8MMini-EVK evaluation board. It is a 64bit processor.
I am porting avs-device-sdk from 32 to 64 bit.
I have 32 bit compatible libAlexaCommsLib.so file. when i try to compile it on 64 bit machine i am getting error saying : "file in wrong format". (for obvious reason).
this is why i need  libAlexaCommsLib.so file compatible for 64bit.
What is the expected behavior?

when I include the 64bit so file, my application should compile successfully
What behavior are you observing?

As I a compiling the code which includes a 32 bit so file, I am getting an error saying "file in the wrong format."
Provide the steps to reproduce the issue, if applicable:

I run the sh file which internally invokes a cmake file. and eventually using a 'libAlexaCommsLib.so'
Tell us about your environment:

What version of the AVS Device SDK are you using?
  <x.y.z>

Tell us what hardware you're using:

[ ] Desktop / Laptop
[ ] Raspberry Pi
[.] Other - tell us more:
using NXP iMX8MMini-EVK evaluation board
Which has Yocto in it

Tell us about your OS (Type & version):

[ ] Linux
[ ] MacOS
[ ] Raspbian Stretch
[ ] Raspbian Jessy
[.] Other - tell us more:
-using NXP iMX8MMini-EVK evaluation board
Which has Yocto in it

Hi @prachipsutane for this Comms related question could you please fcontact your Amazon Solutions Architect. Since this library is not open source we do not provide support for it on github. Thanks!


Unclear demotion behavior

Initial idea to introduce gto demote $MODEL $VERSION $ENV was based on the assumption that user may want to undo the action of promotion. E.g. if he mistakenly promoted a experimental version to production.
One corner case I found out for this demote cmd is this.

Let's suppose that you have a rf with v1 and v2. Then you promote to production v2, then v1, then again v2.
Now you demote what's in production right now. As a result, v1 now in production.
Now you demote again. As a result, v2 now in production. But you already tried to undo promotion of v2 to production, so it's confusing.

I see two options here:

Keep things as they are ^. Maybe there are some user scenarios in which this makes sense.
Make another assumption. If you demote v2 from production, that means that it shouldn't appear there until you promote it again. Then the example above will end up without any version of rf promoted to production.
Disallow demote instruction and require to promote things instead.
Use option 3 + still allow to have demote shortcut cmd which will actually execute promote $PREV_VERSION_IN_THAT_ENV, but that doesn't look very intuitive in complex scenarios also.

I'm leaning towards option 3 right now because it's simpler. Later we can introduce demote command as in option 1 or 2, however we decide.
WDYT?
CC @dmpetrov @mike0sv @dberenbaum @omesser @shcheklein

Considering current implementations with labels in #219, I'm going to use the 5th approach above.
If you deregister a version, all labels of that version are also considered inactive.


Elixir has autocompletion for imports for a while now

Yes - I haven't looked at the README for a while. Thanks for taking a look.
I meant something different by that FAQ entry. Here's what I'd like to do:
iex> ls "/usr/b<tab>

then that would turn into:
iex> ls "/usr/bin

I'm not sure if this is even possible. It seems like it would require some smarts about the types of arguments that I'm not sure is even accessible in the tab completion handler.
If you're curious about why this is desirable, Nerves doesn't have an easily accessible bash prompt so we do quite a bit of filesystem navigation at the iex prompt.

I've added to my todo list to take a pass at the README.md. There's probably more text that could be improved.

Ohhhhhh, i thought the autocompletion was about the commands themselves (which didn't work for a while). :D So please ignore this!


"No suggestions" persists while typing if the completion helper is set to return an empty list for empty content.

Does this issue occur when all extensions are disabled?: Yes

VS Code Version:
OS Version:

Steps to Reproduce:
Background: We use Monaco to build our own editor, with our own language server underlying.

Set the completionProvider to return no suggestions when the content is empty.
In an empty editor, hit Ctrl+Space to trigger Monaco suggestions - there should be "No suggestions"

Begin typing. It won't trigger the completionProvider until you hit a trigger character.

It only happens after you hit Ctrl+Space in an empty editor.
Normally it works like this:

We believe the issue is in this line: https://github.com/microsoft/vscode/blob/main/src/vs/editor/contrib/suggest/browser/suggestModel.ts#L672
It checks if the user has started typing new character by comparing the end of last word with a start of new word. It does that comparison by checking if end is less than the start of the new word. This gets tricky when you type the "i" and the previous value was an empty string. This prevents it from triggering it.

What are the reproduction steps to get this behavior in VS Code?

We are using Monaco to build our own editor so technically we didn't reproduce it in VS Code. We found this issue in https://github.com/microsoft/vscode/blob/main/src/vs/editor/contrib/suggest/browser/suggestModel.ts#L672, which is under vscode repo so I think I should file it here.

technically we didn't reproduce it in VS Code

Closing as it does not to surface in VS Code.


Need for a commit?

Do I need to explicitly call commit on an aggregate?
As shown here:
https://github.com/exponentially/extreme_system/blob/master/lib/system/gen_aggregate.ex#L47
I'm currently using with_new_aggregate and with_aggregate. I'm guessing maybe they take care of that?

Correct, they care about that for you


Surface temperature doesn't change as quickly as Greenhouse Gas 'haze' does

Test device
Macbook air m1 chip
Operating System
13.1
Browser
safari 16.2
Problem description
For https://github.com/phetsims/qa/issues/903, with Show Surface Temperature enabled, if I increase the level of greenhouse gases to max, let the temperature stabilize, then quickly decrease it to the minimum value, the 'haze' goes away immediately. The coloring of the surface doesn't change as quickly, leading to the surface looking redder before the fade begins to happen.
Visuals
https://user-images.githubusercontent.com/87318828/219801016-6da3dfcd-9095-42d8-92a9-80e4b005b299.mp4

Troubleshooting information:
!!!!! DO NOT EDIT !!!!!
Name: Greenhouse Effect
URL: https://phet-dev.colorado.edu/html/greenhouse-effect/1.1.2-rc.2/phet/greenhouse-effect_all_phet.html
Version: 1.1.2-rc.2 2023-02-17 17:51:12 UTC
Features missing: applicationcache, applicationcache, touch
Flags: pixelRatioScaling
User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/605.1.15 (KHTML, like Gecko) Version/16.2 Safari/605.1.15
Language: en-US
Window: 1440x654
Pixel Ratio: 2/1
WebGL: WebGL 1.0
GLSL: WebGL GLSL ES 1.0 (1.0)
Vendor: WebKit (WebKit WebGL)
Vertex: attribs: 16 varying: 30 uniform: 1024
Texture: size: 16384 imageUnits: 16 (vertex: 16, combined: 32)
Max viewport: 16384x16384
OES_texture_float: true
Dependencies JSON: {}

The haze changes instantly because it represents the concentration of greenhouse gasses in the atmosphere.  The surface temperature lags behind because it takes a while for the surface to cool off.  The redder look is a result of the visual interaction between the two effects.  So, I would say that the code is behaving as designed, and the question is whether this is potentially confusing enough that we should change anything about it.  My vote would be no, but I'll pass it on to @arouinfar to get her input.


#73 add apache rat plugin

Signed-off-by: Bogdan Sava<EMAIL_ADDRESS>

Also there fixes for 2 files without license, detected by rat

I have excluded .json from rat check because of this file:
open-metadata-implementation/governance-servers/admin-services/admin-services-configuration.postman_collection.json
This file has no license, and I'm not sure if should I add it or not.
Any suggestions?


JWT not active

Hi! Sometimes I receive a "JWT not active" error. What does it mean? Clearly the token expiration time is not, because it always happens randomly.
Do you have any idea?
Best regards.

I am also running into this


Fix race condition in test-utils CloseableCursor implementation

Fixes #181

Thanks! Looks like a clear improvement to me 👍


add a few tests for the modified files check

This partitions a few more things in the hasModifiedFiles check logic to add some tests for them. There are other elements that need refactoring to be able to accurately test.
One notable change is the logic that drops the first layer if it's empty - this logic used to accept a []v1.Layer interface from the go-containerregistry library. The problem with this is that it's not possible to pass in a slice of a concrete type that implements the interface because the compiler does not assert those two be the same (e.g. the implementation does not implement the interface). See the example below[1]. Kind of a unique behavior to go. Either way, we only needed that information for logging, so I moved the logging outside of the function and instead just report if we've shifted. I've added tests for this as well.
Signed-off-by: Jose R. Gonzalez<EMAIL_ADDRESS>[1] https://go.dev/play/p/Tl6RVyz6uhq

Coverage increased (+0.5%) to 78.637% when pulling 11fbd8b9b4a824ecd32295386b7cccb065f5bd1e on komish:tests-has-mod-files into 5a93a15aba8980fcf6184bb3134de4b6f0ca4b13 on redhat-openshift-ecosystem:main.

coverage: 78.107% (-0.04%) from 78.149%
when pulling 11fbd8b9b4a824ecd32295386b7cccb065f5bd1e on komish:tests-has-mod-files
into 5a93a15aba8980fcf6184bb3134de4b6f0ca4b13 on redhat-openshift-ecosystem:main.


[hotfix][runtime] Remove unused IOManager parameter while constructing BufferStorage

What is the purpose of the change
After removing the code path of noncredit-based flow control, the IOManager parameter would never be used for constructing the BufferStorage, so we can remove it along with the related code path.
Brief change log

Remove IOManager parameter from related methods in InputProcessorUtil
Remove IOException throwable from related methods

Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): (yes / no)
The public API, i.e., is any changed class annotated with @Public(Evolving): (yes / no)
The serializers: (yes / no / don't know)
The runtime per-record code paths (performance sensitive): (yes / no / don't know)
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (yes / no / don't know)
The S3 file system connector: (yes / no / don't know)

Documentation

Does this pull request introduce a new feature? (yes / no)
If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

LGTM


[SPARK-45358][SQL][HIVE] Remove shim classes for Hive prior 2.0.0

What changes were proposed in this pull request?

This PR aims to clean up unused Hive shim classes for Hive prior 2.0.0, it's pure refactor, kind of something like git squash
Why are the changes needed?

SPARK-45328 removed Hive support prior to 2.0.0, this PR is the next step of the code clean up, see https://github.com/apache/spark/pull/43116#discussion_r1336612849
Does this PR introduce any user-facing change?

No.
How was this patch tested?

Pass GA
Was this patch authored or co-authored using generative AI tooling?

No.

cc @HyukjinKwon @LuciferYang

https://github.com/apache/spark/blob/2cc1ee4d3a05a641d7a245f015ef824d8f7bae8b/sql/hive/src/main/scala/org/apache/spark/sql/hive/client/HiveShim.scala#L264-L269
Can getMSCMethod use findMethod() now?

Can getMSCMethod use findMethod() now?

I think no, findMethod only works for public method.
  protected def findMethod(klass: Class[_], name: String, args: Class[_]*): Method = {
    klass.getMethod(name, args: _*)
  }

BTW, to make the change clear, the change in this PR is conservative, in the next step, we can replace some method reflection with direct API call.

Next, we might consider using MethodHandle or VarHandle instead of reflection, they should be the more recommended way to use in Java 17+.

The code changes are fine to me, hoping to get more reviews from others.

cc @dongjoon-hyun

Merged to master.


OCPP201 Websocket control

PR enables external control over the websocket connection of OCPP201

Should be merged with : https://github.com/EVerest/libocpp/pull/139


Add tracing to language server

Copied from https://github.com/Azure/typespec-azure-pr/issues/636
We currently only log some low volume things to output window from language server. It would be good to use the tracing feature of LSP to log much more when it's on.
Examples:

Every file read, whether it was a cache hit or miss, etc.
Every probe for package.json
Diagnostics in unopen documents.

released PR: https://github.com/microsoft/typespec/pull/3533


Calico eBPF fails to init on Talos Linux

I'm provisioning a cluster using the Talos Linux + Kube distro and am finding that the calico-node mount-ebpffs container fails to mount the cgroup2 file system as called from calico/node/pkg/nodeinit/calico-init_linux.go.
W0731 07:12:21.604403       1 feature_gate.go:241] Setting GA feature gate ServiceInternalTrafficPolicy=true. It will be removed in a future release.
2023-07-31 07:12:21.607 [INFO][1] init/startup.go 432: Early log level set to info
2023-07-31 07:12:21.607 [INFO][1] init/calico-init_linux.go 57: Checking if BPF filesystem is mounted.
2023-07-31 07:12:21.607 [INFO][1] init/calico-init_linux.go 69: BPF filesystem is mounted.
2023-07-31 07:12:21.607 [INFO][1] init/calico-init_linux.go 92: Checking if cgroup2 filesystem is mounted.
2023-07-31 07:12:21.609 [INFO][1] init/calico-init_linux.go 120: Cgroup2 filesystem is not mounted. Trying to mount it...
2023-07-31 07:12:21.609 [INFO][1] init/calico-init_linux.go 126: Mount point /run/calico/cgroup is ready for mounting root cgroup2 fs.
2023-07-31 07:12:21.613 [ERROR][1] init/calico-init_linux.go 48: Failed to mount cgroup2 filesystem. error=failed to mount cgroup2 filesystem: exit status 1

Expected Behavior
Calico with eBPF dataplane works on Talos
Current Behavior
Calico with eBPF dataplane does not work on Talos due to an FS mount failure in the eBPF mount init container
Possible Solution
I am currently under the impression this is because bpfdefs.CgroupV2Path is /run/calico/cgroup which seems to be a non-writable directory under Talos (the vast majority of rootfs is readonly with the exception of specific files and the entirety of /var), but mounting an emptyDir at that location in both the init and the main pod does not provide any improvement.
I am unable to change the bpfdefs const and rebuild calico entirely due to environmental constraints (no Docker installs as required by the makefiles) but if needed I can go through the processes to get a environments set up in my work gcloud tenancy and build it that way. I am also happy to run any dev builds produced by the calico team.
Steps to Reproduce (for bugs)
Install a Talos cluster
Install Calico with the operator and this Installation CR
 apiVersion: operator.tigera.io/v1
kind: Installation
metadata:
    name: default
spec:
    calicoNetwork:
        bgp: Enabled
        linuxDataplane: BPF
        ipPools:
        -   blockSize: 26
            cidr: <IP_ADDRESS>/16
            disableBGPExport: false
            encapsulation: None
            natOutgoing: Enabled

Context
We need to use the eBPF dataplane for some shenanigans that doesn't work with the iptables one (mostly Source IP related), so can't just use the non-eBPF mode. Calico is the only competent CNI with BGP + eBPF support that meets our needs.
Cilium, while not helpful to us due to BGP issues, is supported on Talos and their eBPF dataplane works when installed with the following Talos guide, something in there might be helpful in working this out. https://www.talos.dev/v1.4/kubernetes-guides/network/deploying-cilium/#without-kube-proxy
Your Environment
Calico:
quay.io/tigera/operator:v1.30.4
docker.io/calico/node:v3.26.1
Other:
Talos (v1.4.6) kernel 6.1.35-talos
Containerd 1.6.21
Kubelet v1.27.3

Talos already mounts cgroupv2 and bpffs filesystems, it seems the calico check failed to detect that and trying to mount again:
Checking if cgroup2 filesystem is mounted.

Check if calico supports skipping those checks, in case of cilium there's options in the helm chart to skip those two checks, also less init containers

I'm running into the same issue, has any progress been made?

It first tries to find in /nodeproc/1/mountinfo whether the fs is already mounted. So it does not seem like it is mounted yet. Interestingly, it manages to create /run/calico/cgroup. Mabe os.MkdirAll does not fail if the dir already exists. We could make the location configurable instead of hardwired 🤦

Are there any suggested workarounds for this little issue?

We would also like a solution for this.

Any updates on the issue? We would like to switch to eBPF but this is currently a blocker

I have merged the PR that allows you to set cgroup path for calico node. Atm if you are using operator, you would need to annotate calico-node ds so that operator does not change it. We will try to figure out acceptable operator configuration asap.

#8055 managed to get into 3.27.1


Too many idle connections and too little active connections in high traffic

Bug description
Hello,
I'm using Google Cloud Run to connect to Cloud SQL Postgres instance with Prisma through Auth Proxy.
Using connection_limit=2 since serverless.
Still too many connections are created and are in the idle state.
Even when 10 cloud run instances are active and 8 are idle, GCP Cloud SQL shows only 2 connections as active and 21 connections as idle.
Tested with 100 concurrent connections to the cloud run endpoint for 60 seconds.
Is using external connection pooling the only solution here?
PS: This is a NestJS app and the Prisma Client is used as a NestJS service.
Cloud SQL connections chart

Cloud Run instances chart

a376-0722663cbdc1">
How to reproduce
Using a serverless service like Cloud Run and Cloud SQL with Prisma
Expected behavior
Prisma should't be creating 20 idle connections for 2 active connections
Prisma information

// Add your schema.prisma

@Injectable()
export class PrismaService implements OnModuleDestroy, OnModuleInit {

  constructor(private config: ConfigService) {
    logger.debug("Initializing Prisma on startup")
  }

  db : PrismaClient = new PrismaClient({
    datasources: {
      db: {
        url: this.config.get('DATABASE_URL'),
      },
    }
  })

  async onModuleInit() {
    this.initializeDb()
  }

  async initializeDb(){
    try {
      logger.debug("initializing prisma db")
      this.db.$connect().catch(async (e) => {
        logger.debug(`Error while connecting to db: ${process.env.DATABASE_URL}`)
        logger.debug("Trying again")
        await new Promise((resolve) => setTimeout(resolve, 10000));
        this.initializeDb()
      })
    } catch (error) {
      logger.error(`Error while connecting to db: ${process.env.DATABASE_URL}`)
      logger.error("Trying again")
      await new Promise((resolve) => setTimeout(resolve, 10000));
      this.initializeDb()
    }
  }

  async onModuleDestroy() {
    await this.db.$disconnect();
  }

  async enableShutdownHooks(app: INestApplication) {
    //@ts-ignore
    this.db.$on("beforeExit", async () => {
      await app.close();
    });
  }

}

Environment & setup

OS: Debian
Database: PostgreSQL
Node.js version: 20

Prisma Version
5.4.0

The connections come down after traffic subsides but still 10 idle connections for 2 active connections.

Seems like the event "beforeExit" got removed from Prisma.

Still the same behaviour is seen.
Is this normal?

@cryptrr What do you mean by "out of total 13000 requests, 400 fails."? What error do you get?

@cryptrr I think it would be interesting if you could use the metrics preview feature and log the metrics before shutdown for example.
const metrics = await prisma.$metrics.json()
console.log(metrics)

See https://www.prisma.io/docs/concepts/components/prisma-client/metrics for how to use it.

Even when 10 cloud run instances are active and 8 are idle,

What do you mean here?
Do you have 10 instances total? Or 18 total?
What does "are idle" mean? Did they not handle any traffic at all?

GCP Cloud SQL shows only 2 connections as active and 21 connections as idle.

So there are a total of 23 connections open, and 2 are active and 21 are shown as idle, correct?

Generally, when a Prisma Client instance handles at least 1 query it will open one connection.
If it has to handle multiple queries at the same time, it will open as many connections as needed until the connection limit is hit.
It will then keep those connections open (and not just close them again).
When the instance does not run any queries, all of these connections will be idle and waiting.
When there are queries, it will use these existing connections.
So if you have 18 "servers" with a Prisma Client instance each, it would be normal for at least 18 connections to be open, or even 36 when those instances all handled traffic that made it necessary to open connections up to your connection limit.

The problem here is that even at the peak 10 cloud run max instances that I set, the active connections from prisma does not go higher than 2.
This might be probably causing the socket errors when under load.
Note that the 8 idle cloud run instances are some kind of GCP internal to keep containers warm. I set the max instances to 10.

@Jolg42 The errors are mostly timeouts and rest are connection refusal errors.
Running 1m test
  2 threads and 80 connections
  Thread Stats   Avg      Stdev     Max   +/- Stdev
    Latency   949.04ms  547.67ms   2.00s    56.74%
    Req/Sec    36.29     18.81   100.00     69.53%
  4112 requests in 1.00m, 59.24MB read
  Socket errors: connect 18, read 0, write 0, timeout 446
Requests/sec:     68.45
Transfer/sec:      0.99MB

The issue was with cloud run scaling. Closing now.

Hello @cryptrr
I have the same issue with the same stack (Cloud Run + Cloud SQL + Prisma).
I'm searching a solution aroung prisma pool_size and I see your posts.
Could you share you cloud run scaling solution ?

Hi @cryptrr
I am experiencing the same issue in the same environment.
Can you share how you adjusted the scaling or if you solved the problem?
Thanks

@cryptrr Please share your solution

@cryptrr I have the same problem, could you share the solution?

I'm also interested. @cryptrr what actually was the problem with "cloud run scaling"?

This is in fact a problem with SQL itself with serverless. Connections are gonna add up unnecessarily. Completely preventing it is kinda impossible if not using pooler like pgbouncer or prisma's own hosted connection pooling service.

Hello guys, I was facing this problem in my RDS Postgre and couldn't find a solution from prisma itself. So, I run that script programmatically:
WITH inactive_connections AS (
    SELECT
        pid,
        rank() over (partition by client_addr order by backend_start ASC) as rank
    FROM
        pg_stat_activity
    WHERE
        -- Exclude the thread owned connection (ie no auto-kill)
        pid <> pg_backend_pid( )
    AND
        -- Exclude known applications connections
        application_name !~ '(?:psql)|(?:pgAdmin.+)'
    AND
        -- Include connections to the same database the thread is connected to
        datname = current_database()
    AND
        -- Include connections using the same thread username connection
        usename = current_user
    AND
        -- Include inactive connections only
        state in ('idle', 'idle in transaction', 'idle in transaction (aborted)', 'disabled')
    AND
        -- Include old connections (found with the state_change field)
        current_timestamp - state_change > interval '5 minutes'
)
SELECT
    pg_terminate_backend(pid)
FROM
    inactive_connections
WHERE
    rank > 1

What does the script do ?

What does the script do ?

Close the idles connections


Make SendGrid permissions management easy

Create a class for managing permission scopes that has the following features:

Allow you to add create, delete, read, update permissions for each of the groups defined here  -- these can be hard coded in
Allow for creating an array of all the scopes possible, as a "create admin permissions" method
Allow for "read only" which pulls only read permissions
Create a method for each of the example groups here, which provide the appropriate permissions. Note: Some of these are redundant with the previous requests on this issue.

Is this issue taken? If not, can I take this?

Since there has been no activity on this issue since March 1, 2020, we are closing this issue. Please feel free to reopen or create a new issue if you still require assistance. Thank you!


--include flag with regex

# example
$ cmd --include=Filter*,Map
# match
# - Filter
# - FilterByUserID
# - Map

# ----
# Default
# -> match all pattern or skip if no flag.

To rename only to include because exclude exists.


MAGIC WP4 Stratosphere-troposphere coupling

Namelist to identify surface patterns that are the most connected with stratospheric variability: the spatial patterns and indices of the NAM.
Latest version for ESMValTool v2:

namelist v2 working and uploaded to github repository, branch REFACTORING_zmnam
https://github.com/ESMValGroup/ESMValTool/tree/REFACTORING_zmnam

Current status: alpha version of namelist v2 working locally and to be refined.

Now that the REFACTORING_zmnam_v2 branch has been merged in https://github.com/ESMValGroup/ESMValTool/pull/742 we can close this issue.


Handling rate-limiting via status code 429

Continuing from https://github.com/secynic/ipwhois/pull/143, when RIPE rate-limits, it returns a generic html page and status code 429, rather then the expected JSON.
Therefore on request failure the status code should be checked for as well.
Regarding your previous question about the point at which they start rate-limiting, I think it's around ~3500 requests. I'm not sure for how long the block persists.

Oh wow. At least it isn't bad like Lacnic's 10 requests per minute. I'm going to write some tests for this and the other RIRs as well, but they won't be included in Travis builds, as I don't want to spam the RIRs on every commit.

Sounds good. Thanks for answering this so quick - appreciate it.

Merged in #145. Leaving this open pending new offline rate limit tests.

Hey @secynic thanks for fixing the RIPE rate-limiting issue. It's been working pretty great.
I've started noticing something else recently.
When querying LACNIC via the legacy WHOIS, when you get rate-limited the client will just hang there. Is there a way to make it fail with a RateLimitError by tweaking some of the method params?

Good to hear the fix is working.
Is the legacy issue all RIRs or just RIPE again?

Hey @secynic, as far as I could tell, LACNIC is the only RIR where I encounter this behavior. That said, they are also the only ones that will limit you after 10 requests.

I think they must have changed the Whois response.
Legacy whois (Net.get_whois()) does check for rate limit:
https://github.com/secynic/ipwhois/blob/master/ipwhois/net.py#L572
Let me run some tests.

Hmm think I found it, looks like another bug (infinite recursive loop - or until rate-limit ban is lifted).
I have retry_count checks in exception handling, but not prior to the first recursive get_whois call. Should be an easy fix.

Please test the dev branch, it should be fixed.

Hey @secynic, left you a comment on https://github.com/secynic/ipwhois/commit/9d97f65d16535b9d7160f9313950214b7ee9aa57#commitcomment-19740116

Thanks, fixed

Have you had a chance to test this? If all is good on your end, I will merge.

@secynic Yep, works great. Thanks for the fix.
Only tested with LACNIC, though. Haven't gotten rate-limited by the others so far.

Thanks for testing. Merged in 343f944ba174c9be57caa534b4fbf72e4fa57882
Still leaving open for previous mentioned offline tests. I also lost 100% coverage on this merge, need to add a test for WhoisRateLimitError.

I just wanted to provide an update given the amount of time that has passed. I have been busier than usual with work/life/holidays, and plan to get 0.15.0 pushed to PyPi soon.
The only items pending are these offline tests and #149.
Sorry for the delay!

Understood, thank you for the update!


Long line names overlap with "Back" button

I'll take a stab at it.

Draft 1: pushing the header to the right of the "back" button; let the rest of the text cut

Draft 2: Truncate the string if it's getting too long

Thanks @Shanfan ! merging


QUESTION: Automated signup process for Lasair?

Would we like users to be able to sign-up for a Lasair (web) account automatically or are there reasons to keep this a manual process (email to ask for an account)? I remember a manual process was required as a separate account/setup was needed for Jupyter Hub, but this functionality is now delegated to co-lab.
I can add the 'forgot password' functionality too if we want to switch to automatic login.
Any thoughts?

This functionality is already in Lasair4! Closing.


Feature Request: Open PR from Octo

Open PR from Octo
Type: feature request
Describe what happened (or what feature you want)
Would be nice to be able to directly open a PR from Octo, be able to set the title, description, assign labels, projects, milestones, assignees, and reviewers.

@hahuang65 I have a basic implementation where the user needs to specify the target repo and base and head branches. That requires that the user has already pushed his branch to the target repo or fork.
Does that work for you? The reason Im asking is that gh allows to create a new fork, push the branch there and then create the PR. I think that is a little too much for octo.nvim, but can try to implement if that's what people expects

I'm actually not sure what the general use-case should be, or if there even is one.
When I use gh, I usually just do gh pr create --web --fill and it just creates a PR against the repo I'm in, with the defaults for branches as the current branch I'm on, into the trunk branch master or main or whatever is designated.
So for me personally, the use-case would be to use the current repo, with the current branch, targeting a PR into the designated mainline branch.

Implemented in #178
@hahuang65 can you test it please?

Thanks for the diligence, will test and write comments in the PR.

I found this feature while exploring. This should be added to the README !!!

Thanks for the heads up, just added it


Upgrade to Ubuntu 22.04

This pull request upgrades to Ubuntu 22.04

Ruby version installed with Ubuntu 22.04

$ ruby -v
ruby 3.0.2p107 (2021-07-07 revision 0db68f0233) [x86_64-linux-gnu]

Thanks @yahonda!


fix: set electron-builder version to 22.11.7

This PR...
attempts to fix pipeline errors

what features/fixes are we "loosing" with this downgrade?

electron-builder documentation does not provide a really good sight but It looks like they do all releases together - such as electron-[builder|updater|publisher...]
These are all the things I can find, It didn't look me like it may break things, so I want to try - If fails we can revert it back;
https://github.com/electron-userland/electron-builder/releases/tag/v22.11.11
https://github.com/electron-userland/electron-builder/releases/tag/22.11.10
https://github.com/electron-userland/electron-builder/releases/tag/v22.11.9
https://github.com/electron-userland/electron-builder/releases/tag/v22.11.8


DOC : added default value of absolute_sigma to False in scipy.optimize.curve_fit docs

Reference issue

Closes #11944
What does this implement/fix?

added default value of absolute_sigma to False in scipy.optimize.curve_fit docs
Additional information

thanks, merged


setState should support callbacks, same as the typical react setState

Currently, reflux setState does not support a callback. I believe expected functionality here would be that it worked like or better than the typical React setState.
Suggestion:
Set expected completions based on number of subscribed components.
While looping setState for all subscribed components, fire off a callback on that component's setState indicating it is complete.
When all completions are reached, fire the callback for the reflux store's setState.
I believe this could also be wrapped as a promise instead of a callback. Honestly, I'm not sure why the normal React setState is a callback and not a promise.

Reflux's this.setState does not have a callback because it changes its store state immediately. React only has callbacks as a workaround for the fact that it doesn't. It would be very awkward (and even confusing) to implement a workaround that "works around" a problem that doesn't actually exist in Reflux.
As for your suggestion that it instead call back when all subscribing components have updated their state: that is a major violation of the single most fundamental principle of flux itself (one-way data flow).
If your store logic depends upon knowing the state of subscribed components then you're not actually doing flux. Reflux is a flux library.


Is this project dead?

...no updates for months...

...no updates for months...

Doesn't mean dead :-)
Most libraries nowadays rely on the PSR-7 standard, so there is no interest/traction in adding features to this API. zend-diactoros is our own PSR-7 implementation.

I consider a project with unanswered pull requests and issues a dead project...

@mlocati be my guest in answering issues and pull request from 4 years ago on many of my (personal stuff, not just zf) actively maintained projects :-)

That means that you don't have time to give feedback to requests to zend-http?

Yes, and I generally answer things as they come up in my inbox.
If I skip something, it's just because I wasn't working on it at that time,
and then it gets archived when I clean up my inbox.
Also, most contributors only work on this when they have free time, at the
end of the day or before going to work.
Marco Pivetta
http://twitter.com/Ocramius
http://ocramius.github.com/
On Thu, Jan 12, 2017 at 6:12 PM, Michele Locati<EMAIL_ADDRESS>wrote:

That means that you don't have time to give feedback to requests to
zend-http?
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
https://github.com/zendframework/zend-http/issues/104#issuecomment-272223151,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAJakCexKRKMZbljj8ZE8aBUutfoqzU8ks5rRl8ZgaJpZM4Lh-Vo
.


[ScaleManager] TypeError: this.removeFullscreenTarget is not a function

Version

Phaser Version: 3.18.1

Operating system: Microsoft Windows [Version 10.0.18362.175]

Browser: Google Chrome 75.0.3770.100 (Official Build) (64-bit)
Browser: Firefox 67.0.4 (64-bit)

Description

I have tried implementing the fullscreen functionality in my game using this.scale.toggleFullscreen(), and hoped that it will scale my game properly, but instead i got an error in the console TypeError: this.removeFullscreenTarget is not a function.
I have tried the Fullscreen Demo from examples, and the scaling is done properly (but the error is still triggered, perhaps from this.scale.stopFullscreen(); ), so it's safe to assume that my code is wrong, but the removeFullscreenTarget error slipped into 3.18.1 from 3.18.0-beta1.
( I was using this previously because 3.17 was failing on Internet Explorer 11 )
See the error in the image attached.

Example Test Code

let item = this.add
            .image(0, 0, 'background_default')
            .setOrigin(0.12, 0);

item.setInteractive();
item.on('pointerdown', ()=>{
    if(!this.scale.isFullscreen) {
        this.scale.toggleFullscreen(); // will trigger the error
        // this.scale.startFullscreen(); // this works ok
     }
}, this);

Thank you for submitting this issue. We have fixed this and the fix has been pushed to the master branch. It will be part of the next release. If you get time to build and test it for yourself we would appreciate that.


Feature/es streaming index

Added

Streaming Index (subscribe document change events from Kafka, and PySpark read it as a stream then, update to the Elasticsearch)

https://github.com/dpkp/kafka-python/issues/2412


Generating a PDF/PNG version of the R-Ladies map based on current stats

Hi @gdequeiroz
Thanks for the great package! I was trying to insert a map into my RMarkdown file using meetupr. I ended up using a screenshot. I was hoping to highlight my chapter amidst all other pins. I did this by hovering over the chapter so that the name lights up and then took a screenshot. However, the screenshot generated an artificial blue box (near the selected name) to mark the selection. I could not avoid this. Please see the screenshot below.
E.g.

Is there a cleaner/more reliable way to generate this screenshot programmatically using the meetupr package? Could this be done highlighting a selected chapter too, say East Lansing? That would be very helpful! Thanks again!

However, the screenshot generated an artificial blue box (near the selected name) to mark the selection. I could not avoid this. Please see the screenshot below.

I personally don't know how to solve that. :/ Maybe you can investigate? (I'm going to open an issue on that)

Is there a cleaner/more reliable way to generate this screenshot programmatically using the meetupr package?

The map is generated using leaflet and using the meetupr to get the data. I think there is an option of downloading a map if we modify the code in the app. I will take a look at that.


Add 1-moment microphysics to prognostic EDMF

This PR adds 1-moment microphysics scheme to prognostic EDMF.
Precipitation (rain and snow) is only computed as a grid mean quantity (i.e. we don't have updraft and environment precipitation variables). The sources to precipitation are computed as a sum of contributions from updrafts and the environment. The precipitation sinks (evaporation, melting, deposition/sublimation) are only computed on the grid mean.
My main priority was to only have one definition of compute_precipitation_sources! and compute_precipitation_sinks!. This is where I loop over all microphysics processes and I don't want to have multiple versions of it. That function returns 4 outputs (source terms to total water, rain, snow and energy) and I didn't know how to write it outside of a colidx loop.
Things I don't like about the code right now:

the additional colidx loop
all the additional variables I'm adding to the cache
compute_precipitation_sinks! and compute_precipitation_sources! behave differently. The sources one zeroes out the cached S before adding to it. The sinks does not. This is because when used without EDMF, the sinks are done after the sources and add to the same cached values. This is clunky, but I didn't have a better idea and I did not want to add another 4 variables to the cache

Also, can I re-use my tmp scalar between different updraft j-s and the environment?
    tmp1 = p.scratch.ᶜtemp_scalar
    n = number of updrafts

    do colidx
        # Sources from the updrafts
        for j in 1:n
            foo!(
                tmp1[colidx],
               all_the_sgs_j_variables_and_dollars[colidx]
            )
        end

Just a thought. Looking at the code, another way to calculate sources for one moment microphysics is to dispatch on compute_precipitation_sources! by the sgs model, rather than saving the precipitation sources in edmf precomputed quantities. We can keep this for now and see what would be better as we add more options.

Sounds good. I agree, there should be a more elegant way to switch between 0M/1M w/wo EDMF(diagnostic and prognostic).  And also w/wo quadratures in the future. I think with the promised advent of fusion I could write the whole 1-moment microphysics as a point-wise function that returns a tuple of numbers. Instead of having to use it inside colidx call.
But it is easier for me to write a better solution once we have something working.

I'll also add some flame graph job for the 1M


Add "Picture in Picture" button under YouTube video

I was waiting for an answer to my question, but it took too long.
So I wrote my own code to solve this problem. You can embed it in your project.
https://github.com/SuperZombi/Picture-in-Picture-for-Youtube

@beaufortfrancois can this be merged?


Update browser tab title to reflect location in app

At the least, section e.g. "Micronutrient Action Policy Support: Quick MAPS".
Could also reflect current data/selection

Some suggestions for titles, descriptions and keywords for pages. Feel free to edit and expand the list.

Page
Title
Description
Keywords

Home
Micronutrient Action Policy Support (MAPS): Homepage
MAPS is a web-hosted tool, communicating estimates of dietary micronutrient (MN) supplies and deficiency risks at national and sub-national scales in Africa. The tool draws on MN biomarker survey data where these are available, and dietary MN supply estimates derived from nationa-scale (Food Balance Sheets) or sub-national (House-hold Consumption and Expenditure Survey) data, presenting the user with multiple perspectives on MN deficiency risks and highlighting where there ar emajro data gaps.
Micronutrients; maps; policy

Maps Tool Interface
Micronutrient Action Policy Support: Tools
Various tools to explore micronutrient deficiencies in your geography of interest and possible interventions to mitigate the micro-nutrient deficiencies.
Micronutrients; maps; tools; interventions

Quick maps: Baseline
Micronutrient Action Policy Support: Quick Maps - Baseline
Baseline estimates of dietary MN supplies and deficiency risks in the selected country or region.
Maps; micronutrients; national; sub-national; Africa; dietary; deficiency

Quick maps: Projections
Micronutrient Action Policy Support: Quick Maps - Projections to 2050
Projections of food system changes under various scenarios.
projections; scenarios; micronutrients; food systems;

Some suggestions for titles, descriptions and keywords for pages. Feel free to edit and expand the list.

Page
Title
Description
Keywords

Home
Micronutrient Action Policy Support (MAPS): Homepage
MAPS is a web-hosted tool, communicating estimates of dietary micronutrient (MN) supplies and deficiency risks at national and sub-national scales in Africa. The tool draws on MN biomarker survey data where these are available, and dietary MN supply estimates derived from nationa-scale (Food Balance Sheets) or sub-national (House-hold Consumption and Expenditure Survey) data, presenting the user with multiple perspectives on MN deficiency risks and highlighting where there ar emajro data gaps.
Micronutrients; maps; policy

Maps Tool Interface
Micronutrient Action Policy Support: Tools
Various tools to explore micronutrient deficiencies in your geography of interest and possible interventions to mitigate the micro-nutrient deficiencies.
Micronutrients; maps; tools; interventions

Quick maps: Baseline
Micronutrient Action Policy Support: Quick Maps - Baseline
Baseline estimates of dietary MN supplies and deficiency risks in the selected country or region.
Maps; micronutrients; national; sub-national; Africa; dietary; deficiency

Quick maps: Projections
Micronutrient Action Policy Support: Quick Maps - Projections to 2050
Projections of food system changes under various scenarios.
projections; scenarios; micronutrients; food systems;


Dart command tool should include Windows targeting manifest

Per this doc:
https://docs.microsoft.com/en-us/windows/win32/sysinfo/targeting-your-application-at-windows-8-1
Windows apps that support Windows 8.1 or above should include an application manifest to indicate their support. Individual apps cannot presently demonstrate this support from Dart, as far as I can tell, since the Dart linker doesn't provide a way for applications to include assembly manifest resources.
As a result, Windows API calls will result in legacy behavior where there is a difference between Windows 7 or Windows 10. This also makes it hard for apps to consume newer APIs in certain places (for example, the modern MessageBox equivalent TaskDialog is not accessible without an assembly manifest.
We should link a manifest into dart.exe and the executables dart2native produces.

6cec462d24ad9ef817f666a4f3e9b5bc3bdba8ad


Fix: Use fsGroupChangePolicy to prevent recursive perm changes

See https://kubernetes.io/docs/tasks/configure-pod-container/security-context/#configure-volume-permission-and-ownership-change-policy-for-pods for more information
Refs: https://github.com/rstudio/package-manager/issues/14547

@jforest What do I need to do to get the linter to pass here?


iPad: Type of roads cannot be edited

I tried changing the type of road today on an iPad.
(Location: https://www.openstreetmap.org/way/773761965)
I was able to select the raod:

But I could not change the type. Once I clicked on "Zufahrtsweg", the searchform searched for a location:

I did not test this on the preview / 2-x-preview, yet.

Looks like the underlying issue here is that the feature isn't actually selected when first tapped, it's just in the hover state. So the inspector can't be interacted with. This is still a bug that needs fixing.


Joseph259

Not sure if this is a permanent solution but I just use a shallow copy (save on temp variable) and set the state as so.
Let me know what you think

@DevelopmentByDavid Updated!


fix(n-tree): 解决issue #5217中所提的-Tree组件数据渲染错误问题 (#5217)

close #5217

Codecov Report
All modified lines are covered by tests :white_check_mark:

Comparison is base (79cdba5) 62.36% compared to head (1965415) 62.37%.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5296   +/-   ##
=======================================
  Coverage   62.36%   62.37%
=======================================
  Files        1074     1074
  Lines       22592    22597    +5
  Branches     5931     5932    +1
=======================================
+ Hits        14090    14094    +4
- Misses       6959     6960    +1
  Partials     1543     1543

Files
Coverage Δ

src/tree/src/Tree.tsx
35.48% <100.00%> (+0.38%)
:arrow_up:

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

可能忽悠一些边界问题，我感觉，不过大面上应该是对的

感谢

我整理了一下 77d679d

我整理了一下 77d679d

索嘎，学习了学习了😄


Provide Putty instructions for SSH

The instructions here do not work for Putty.  This is the most common SSH tool that runs on Windows desktop.
Basically, you need to run PuttyGen and either generate a fresh keypair, or click Load and get the properly formatted public key.  Annoyingly, this is not what Putty stores on the .pub file :(

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 69db0238-ad2d-43b9-52db-2f2fad0ea380
Version Independent ID: 6f355823-2d16-5085-0fbc-294d20597223
Content: Detailed steps to create an SSH key pair - Azure Linux Virtual Machines
Content Source: articles/virtual-machines/linux/create-ssh-keys-detailed.md
Service: virtual-machines-linux
GitHub Login: @cynthn
Microsoft Alias: cynthn

@DavidLangworthy Thanks for the feedback! Did you know SSH now works from PowerShell in Windows 10? There is also a separate article for using SSH from Windows: https://docs.microsoft.com/en-us/azure/virtual-machines/linux/ssh-from-windows.

Thanks.  Could you cross link these?  The portal page I landed on pointed me at the linux one.

@DavidLangworthy Yes! And I will try and see if the folks who work on the portal can link to both the Windows and Linux specific topics :)

#please-close


avr-sim: init at 2.8

Description of changes
New Package: Gerd's AVR Simulator
Website: http://www.avr-asm-tutorial.net/avr_sim/index_en.html
AVR assembler simulator for the stepwise execution of assembler source code.
Some Features:

Simulates AVR 8-bit microcontrollers of any type (ATtiny, ATmega, etc).
Assembles the source code with the built-in assembler gavrasm.
Allows control over registers, flags, memories, ports, timer/counters, AD converter, etc.

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Sorry if my questions is stupid, but what should I do in this case? Should I host a copy of the source code?

Sorry if my questions is stupid, but what should I do in this case? Should I host a copy of the source code?

You don't have to do anything, I was just making a comment/observation.
But if you want to create a mirror for avr-sim, for long-lasting reproducibility, just do it and change
fetchurl { url = "https://UPSTREAM/filename"; sha256 = ...; }
to
fetchurl { urls = [ "https://UPSTREAM/filename" "https://YOUR_MIRROR/filename" ]; sha256 = ...; }
The first URL will be tried first, and if it fails, fetchurl continues to the next URL(s) in the list.

Thanks for the tip. I do want to host a mirror, but I don't have a personal server (yet). Is it a good idea to use IPFS on my personal machine? Since IPFS is content-addressed, it won't be tied to my particular machine.

Is it a good idea to use IPFS on my personal machine? Since IPFS is content-addressed, it won't be tied to my particular machine.

Sounds good in theory, but (1) although I see a fetchipfs function in nixpkgs, it isn't used by any packages(?) and (2) I don't know how to make e.g. fetchipfs a fallback for fetchurl. (But that doesn't mean it's impossible.)

@emilytrau thanks for the suggestion. Now it will fallback to an archive.org snapshot.
I believe this is ready to be merged right now.

Thank you @bjornfor! You really helped me a lot with this PR, and I certainly learned a lot.


Make 'rest' import in Node specialized

Makes it more obvious what it is used for.
It should probably be removed in the future.

🇬🇷


set_agent_executor overwrites custom callbacks in agent.py

        """set agent executor is set."""
        if hasattr(self.llm, "model_name"):
            self.llm.callbacks = [
                TokenCalcHandler(self.llm.model_name, self._token_process)
            ]
        if not self.agent_executor:
            if not self.cache_handler:
                self.cache_handler = CacheHandler()
            self.set_cache_handler(self.cache_handler)
        return self

line 152 -> if hasatter(self.llm, "model_name"):
line 153 -> self.llm.callbacks = [...] (this overwrites all other call-backs that have been added when initialising instead of just appending the call-backs. This needs to update. not overwrite.

Nice, good  catch will fix it now :)

Fixed, new minor version is out 0.27.1 :) might take a few mionutes to propagate

Legend. And what a quick response.

This is imo still the case:
    litellm.callbacks = callbacks

    def call(self, messages: List[Dict[str, str]], callbacks: List[Any] = []) -> str:
        with suppress_warnings():
            if callbacks and len(callbacks) > 0:
                litellm.callbacks = callbacks

see
Any callbacks passed to a LLM like so
llm = LLM(model="gpt-4o", temperature=0.4, callbacks=["langsmith"])

will be overwritten by the TokenCalcHandler callback

Even when hardcoding it to "langsmith" I cannot get litellm to log my requests, other than the one using native Langchain tools. The completion calls are nowhere visible. Visible in Langtrace, but I prefer Langsmith A LOT over Langtrace. Bummer.


Added metrics for LRU data cache

Fixes #679
Description
This PR adds additional metrics around LRU data cache such as size, capacity, evictions and cache miss in order to have a same set of metrics collection across the board.
Changelog

Add metrics for LRU data cache

@AshishNaware Could you please squash the three commits and force push? That's a practice in the Tetragon project, to keep clean git history on the main branch. Currently one of the CI jobs is failing because one of the commit messages is too long.

@lambdanis @mtardy - I have squashed the commits and rebased the branch. This PR has now passed all the checks.


New package: MatLang v0.1.0

Registering package: MatLang
Repository: https://github.com/juliamatlab/MatLang
Created by: @aminya
Version: v0.1.0
Commit: cfa170e7bf299c600f664165505b9c0b012b9cb3
Reviewed by: @aminya
Reference: https://github.com/juliamatlab/MatLang/commit/cfa170e7bf299c600f664165505b9c0b012b9cb3#commitcomment-35500523

I want all of this to be under version 0.1. It is not a mistake or something. I just wanted to make my first release of the package better. Thanks!


More detailed documentation

I found lack of documented features in Hive.
I think that existed docs must be more detailed.
Needed additional information:

TypeAdapters
differences between Hive/HiveFlutter
possible frequent errors
details about newest stable version of library
detailed tutorials with example projects

+1
Yes, I agree, I am struggling with Generics right now, since the Hive Code Generator doesn't support Generics for now, so I'm kind of stuck on how to write my own.


Add stale and suspense

After this addition we should be able to upgrade straight up to 1.9.x
For later @urql/core versions we still need:

https://github.com/FormidableLabs/urql/blob/master/packages/core/CHANGELOG.md#190
https://github.com/FormidableLabs/urql/blob/master/packages/core/CHANGELOG.md#1100

Closing in favor of #184.


Ephemeral RefCap shouldn't be an assignable refcap type

This allows modification of val and sending of mutable data to actors.
Example:
use "debug"
use "files"
use "collections"

actor Main
  var env: Env

  new create(env': Env) =>
    env = env'

    let map: Map[String, Array[String]] trn^ = recover trn Map[String, Array[String]] end
    map.insert("start", ["A" ; "b"])
    map.insert("A", ["end"])

    let romap: Map[String, Array[String]] val = map
    let foo: Foo = Foo(env, map)
    foo.test()

//    map.insert("X", ["c"; "b"; "end"; "start"])

actor Foo
  let env: Env
  let map: Map[String, Array[String]] val
  new create(env': Env, map': Map[String, Array[String]] val) =>
    env = env'
    map = map'

  be test() =>
    env.out.print("Size of map in actor: " + map.size().string())

A few extra cases for the fix:

Unions: (Example iso^ | None)

Intersections: A ref & A val already has a more aggressive check, but there could be other cases.
(Side note: If this check is implemented, there's an argument that we should technically only enforce the ref & val check for variable bindings (as both A trn^ or A iso^ are already subtypes of A val & A ref by definition))

Tuples `(A iso^, B ref)

In other words, the test for capabilities has to be deep, not just checking a nominal cap
Some day also generics, but that has its own issue
https://github.com/ponylang/ponyc/issues/1931

I reopened this because the PR that closed it needs to be reverted for now.


feat: local non-module scripts in index.html

If a <script> points to a local file (eg: /a/b.js) and is not a module type, it should be treated like a static asset.
I'm working on a plugin that expects this behavior.

Closed in favor of #1648

Closed in favor of #1648


fix: [BUG] yarn 2 pnp issues #1312

fix #1312

Triggered CI - I'll take your word for it that this fixes the issue.
Expected to be included 5.0.0

Thanks @kewde !


Add exceptional slugs for search

Add the Horizon 2020 business support page and the Civil Service Apprenticeship Schemes campaign to search, as these content types are excluded by default.

:+1:


Add identifier options to trusted dealer demo

Identifiers can only be the default for trusted dealer demo at the moment. With the new changes, allow trusted dealer to accept custom identifiers

this is done already


refactor: cleaned up bot listeners

Split up bot listeners into separate cogs.
#34

Sorry about the - uh - massive git differences. Maybe there's some way of detecting actual line additions vs just moving lines over to another file :man_shrugging: ?
I recommend you test it by running a few commands though considering that's pretty much what changed :+1:


Update security-auditlogquery.md

Instructions: Add any supporting information, such as a description of the PR changes, here.

[!NOTE]
The following guidance is for Microsoft employees only. Community contributors can ignore this message; our content team will manage the status.

After you've created your PR, expand this section for tips and additional instructions.

do not merge is the default PR status and is automatically added to all open PRs that don't have the ready to merge label.
Add the ready for content review label to start a review. Your PR won't be reviewed until you add this label.
If your content reviewer requests changes, review the feedback and address accordingly as soon as possible to keep your pull request moving forward. After you address the feedback, remove the changes requested label, add the review feedback addressed label, and select the Re-request review icon next to the content reviewer's alias. If you can't add labels, add a comment with #feedback-addressed to the pull request.
After the content review is complete, your reviewer will add the content review complete label. When the updates in this PR are ready for external customers to use, replace the do not merge label with ready to merge and the PR will be merged within 24 working hours.
Pull requests that are inactive for more than 6 weeks will be automatically closed. Before that, you receive reminders at 2 weeks, 4 weeks, and 6 weeks. If you still need the PR, you can reopen or recreate the request.

For more information, see the Content review process summary.

@arishojaswi Hi, I don't have permissions to merge to this repo. However, my colleague @lauragra can merge this for you. Thanks, Linda

@arishojaswi , this is your fork of the public Microsoft Graph docs repo. Do you want to submit this change to update the live/public docs?

Yes. Submitted the change. @Lauragra


Add Fuzzy and Regex Lookup to lookup cmdlet.

Decided against Specific looks from the Get-KeePassEntry function.
It will only support getting a subset of entries based on group.
All other filtering will be done on the pipeline.
Filtering on the pipe line fits the most common powershell standard.


kernel: remove 4.7

Fixes #19822
Motivation for this change
Linux kernel 4.7 has been EOL'd.
Since we always keep the set of upstream maintained kernels, this one needs to go.
Note that grsecurity still pulls 4.7.10 because those folks have yet to release a 4.8.x patch.
Since we generally keep grsecurity up-to-date, it will eventually switch to 4.8 I presume.
Still pinging @joachifm to make him aware.

Needs cleanup? or has cleanup?
:+1:

In a way both :) But you are right, I meant to do has: clean-up

I'm wondering if we should be leaving an EOL'd kernel in 16.09. I don't want to drop it, but I doubt we're going to maintain it.

I've long thought we should just stick to LTS and latest stable, on master and the release branches. It seems to be begging for trouble to have known unsupported kernels in our stable branch. @domenkozar ?

I think we should cherry-pick this to 16.09, unless there's some specific reason for another way.

When people explicitly override kernel branch, IMHO they should count on it disappearing when EOLd. (Upstream clearly announces minimal support time for each branch.)

I'll cherry-pick, I agree.

27b37f1b9532170a043468d38eaf4bf1dbf97e09


[Fix](count on index) fix count on index opt when count project expr

Proposed changes
This PR addresses an issue where counting on an index with a projected expression was suboptimal.

run buildall

run buildall

run buildall


Fix for correct work with $resource.query

I think, it is just a bug.

Hi Alex,
when you apply the interceptor we want the whole processed response and not just the _embeddedItems because if you have other properties inside the response they will be lost. So this is not a bug and it is the needed behavior. You also see that one test is failing which exactly tests this.
Why do you think this is a bug?
Thanks and regards,
Guy

I have a simple application with Spring Boot + Spring Data JPA in backend with the following frontnend:
// app
var app = angular.module('homeis', [
'ngResource',
...
'spring-data-rest''ui.bootstrap'
])
.config(function(..., SpringDataRestInterceptorProvider){
SpringDataRestInterceptorProvider.apply();
// a lot of other code
})
// resource definition
app.factory('Taxonomy', function($resource){
return $resource('/taxonomies/:id');
});
// controller
app.controller('TaxonomyIndexController', function($scope, Taxonomy){
$scope.taxonomies = Taxonomy.query();
// other code
});
Wihtout _embeddedItems there is an error: Error: [$resource:badcfg] Error in resource configuration for action query. Expected response to contain an array but got an object (Request: GET /taxonomies)
And it is right, array with items is in _embeddedItems property of preprocessResponse.
Server response is:
{
"_links" : {
"self" : {
"href" : "http://localhost:8080/taxonomies{?page,size,sort}",
"templated" : true
}
},
"_embedded" : {
"taxonomies" : [ {
"title" : "654",
"alias" : "654",
"_links" : {
"self" : {
"href" : "http://localhost:8080/taxonomies/1"
}
}
} ]
},
"page" : {
"size" : 20,
"totalElements" : 1,
"totalPages" : 1,
"number" : 0
}
}
May be something wrong with configuration, can you explain it to me?

Hi Alex,
so it looks like it worked now?
Thanks and regards,
Guy

Yes it is!
Thanks!


fix: text pushes UI due to padding

Removing the padding, as IIRC we have added it only due to overflowing cursive-like glyphs in Bangers, which we did not ship in the end.
Might re-introduce a smarter version once we have italics, i.e. based on actual width - advance width. Once there, we shall also investigate, how to keep the padding-like buffer, as we need to keep the width as advance width due to wrapping.
We could probably also just remove the padding once the text starts to overflow. However, the whole behavior of overflowing WYSIWYG is not ideal.
Fixes #8743

👍


how to pass params while using actions.pop() in version RNRF-3.41.0??

Version
Tell us which versions you are using:

react-native-router-flux v3.41.0 (v3 is not supported)
react-native v0.47.2

Expected behavior
I'm sorry to change this issue for v3, because I'm half way away from completion of my project turning back again is so hard.
I'm trying to pass params while returning back from one scene to other, which cannot be done with
Actions.pop(refresh:{params:"jb"})
and tried to log in componentWillReceiveProps and other places too
Actual behavior
But I cannot receive any props anywhere in the component
Can someone help me fix this issue

did you just try passing them Actions.pop({foo: 'bar'})

I tried but no luck on RN 0.48 and react-native-router-flux v4beta21 on Android 7.0.
It does run componentwillreciveprops function but it doesnt add that values to components maybe i should use something like super(props) in componentwillreciveprops ?

Sorry, it is not related to RNRF. Check RN docs

You can send a function from the first scene to the second scene, so it can be executed before popping.
// First scene
Actions.push("secondScene", {
beforeBack: () => { this.loadData() }
})
// Second scene
this.props.beforeBack ? this.props.beforeBack() : null;
Actions.pop()


puts must append newline

int puts ( const char * str );
Write string to stdout
Writes the C string pointed by str to the standard output (stdout) and appends a newline character ('\n').
The function begins copying from the address specified (str) until it reaches the terminating null character ('\0'). This terminating null-character is not copied to the stream.
Notice that puts not only differs from fputs in that it uses stdout as destination, but it also appends a newline character at the end automatically (which fputs does not).

https://www.cplusplus.com/reference/cstdio/puts/

I wasn't able to find the puts function in this repository, can you clarify your issue a bit better?

Sorry It was in a fork

Sorry It was in a fork


Cleanup azure-client-sdk-parent Configuration

This PR centralized and de-duplicates configurations defined in azure-client-sdk-parent.

/azp run java - aggregate-reports

/azp run java - aggregate-reports

/azp run java - aggregate-reports

/azp run java - aggregate-reports


[WEB-2139] demo top nav

Fixed demo top nav to look like the Figma: https://www.figma.com/design/qBLLLwbJYGeZoca4m3lQD4/Onboarding-|-Q2-2024-|-HM?node-id=599-11503&m=dev
As the screen gets smaller, I progressively remove certain links. Dark mode does not change the background or text color (this is the pattern we are following for our marketing site).

Updated!
https://github.com/stytchauth/stytch-nextjs-integration/assets/167138465/43c68392-fb28-4f52-8f75-4176130db04b


Fix sidekiq strict args in asset manager rake tasks

Symbols were being passed in the rake task, causing it to error with ArgumentError: Job arguments to AssetManagerUpdateWhitehallAssetWorker must be native JSON types.
Fixed by passing strings down to the worker, which works fine as the AssetUpdater expect stringified keys.
Co-authored-by: Neamah al Selwi<EMAIL_ADDRESS>⚠ This repo is Continuously Deployed: make sure you follow the guidance ⚠
Follow these steps if you are doing a Rails upgrade.

@davidgisbey Hey David, I see you were the last one to touch this area. We changed the worker as it was using the AssetUpdater we had business with. Tests were fine - passing hash with symbols, expecting hash with symbols - but the rake task broke when manually testing (see the ArgumentError in commit message).
Thought it would be good to have you look at the changes. You may also have some insight into wether we need to maintain these rake tasks since it seems they haven't been run in some time (they would have errored the same prior to our changes).  We are moving towards using non-legacy endpoints for whitehall as well, it seems all the auth_bypass_ids values are being set just fine in asset-manager. Perhaps there is not a business need here anymore?
The strict args are set in the Sidekiq initializer. I am also wondering if there is anything we can do to make it break the tests so this situation doesn't happen again.

Great catch. Code looks good to me. I suspect these can probably be removed i think they were used once to populate the auth_bypass_id when it was added. Might be worth double checking with a member of the Experience team though

Great catch. Code looks good to me. I suspect these can probably be removed i think they were used once to populate the auth_bypass_id when it was initially added. Might be worth double checking with a member of the Experience team though

@ollietreend Dragging you in to have a look at these rake tasks, whether we need them.
The worker itself (which is so beautifully reusable) is something I'd keep around and maybe use it further down the line if we bring both File and Image Attachments flows to some level of consistency.

Hi @lauraghiorghisor-tw
Both AssetManagerUpdateWhitehallAssetWorker and the asset_manager:* Rake tasks were implemented in #6570 to support the introduction of auth_bypass_ids on assets. This was required as part of an "epic" to introduce the "shareable previews" feature to Whitehall.
As I think you & David have already concluded, these Rake tasks would have been used for a one-off migration when the "shareable previews" feature was initially launched. I don't believe it's been used (or needed) since then, so we probably should have cleared it up at the time.
They would have been run over a year ago now, long before "strict args" were required in the app. So as you've already said, the error you're seeing would not have happened at the time.

If these Rake tasks are useful to you: you'll need to adapt them to use strict args (as you've already done in this PR) 😄
If you don't need them: please do feel free to delete them rather than fix them 🗑

Either way you'll be improving the codebase! ✨🧹
As for the tests not picking up on the Sidekiq strict args requirement, that does seem a bit annoying. Have you tried adding Sidekiq.strict_args! to the test/support/sidekiq_test_helpers.rb file? It looks like that is included in both the MiniTest and Cucumber test suites, and hopefully will configure Sidekiq so it behaves the same as in the 'real world'.

Thanks for confirming we can get rid of them @ollietreend 🙏🏻
Will have a play around with the strict_args 🛝


Implement all I2C traits for &RefCell

This allows an I2C bus to safely be shared between device drivers. Note that it does not allow the bus to be shared between threads/interrupts because RefCell is not Sync and therefore &RefCell is not Send.
Alternatives
Third party crate
This could be implemented in a third party crate via a wrapper type, but I don't want to maintain an entire crate that is almost entirely boilerplate.
Use RefCell::try_borrow_mut
This could also be implemented using RefCell::try_borrow_mut, but that would require a new error enum:
pub enum I2cRefCellError<E> {
	I2c(E),
	RefCell(core::cell::BorrowMutError)
}

The RefCell borrow will only fail if the user has manually borrowed from it (an obvious bug that should be caught immediately during development), so I don't think that it is worth the extra complexity to avoid a panic in that case.

r? @therealprof
(rust-highfive has picked a reviewer for you, use r? to override)

See https://github.com/rust-embedded/embedded-hal/blob/master/embedded-hal-bus/src/i2c/refcell.rs

yes. I propose closing this, now that we have embedded-hal-bus, unless somebody has an objection.

I think that this direct impl on '&RefCell' is slightly more convenient than the wrapper type in embedded-hal-bus, but I don't have strong feelings either way

On second thought, it makes more sense for the refcell impl to stay next to the mutex and critical-section impls in embedded-hal-bus


release/2.0.0

Changes

Added support for Typescript
Refactored validation functions
Refactored and removed unused code, improving the features that we currently have
Added support for data-placeholders so the user can define different values for each field
Restructured the error/success message templates to replace VGS one

@paulocesarpcfj it's important to add an description to PR.

@paulocesarpcfj it's important to add a description to PR.

Nice call out. Done!


Open GL issue

When I try to open a game called YOMI Hustle It says my video card dose not support any of the
supported OpenGL Versions
Configuration
ARM 64 (aarch 64)
Memory 4gb
4 cores
QUEM 7.2 ARM virtual machine

UTM Version: 4.1.6
macOS Version: Ventura
Mac Chip M1

OH and btw it feels a little jittery or laggy

like the whole windows software

DIfferent game

There is a known issue where macOS OpenGL only goes to 2.X. Is your rendering backend set to ANGLE (Metal)

Windows don't have gpu

anyone know how to fix it?

There is a known issue where macOS OpenGL only goes to 2.X. Is your rendering backend set to ANGLE (Metal)?

where do I do that

Now its showing me this

It can't be fixed...
the comment above is in Linux environment

You can try software(Mesa3D for windows, google it) tho, but i'll be very slow.


[T4A3][F11-B2]ChiangWengKiat

Created parent class contact and removed common methods in child classes

Ready for review

@wengkiat Some comments added. Please close the PR after reading comments. I believe you may have missed out the classes Email and Address.

Noted, thanks for the feedback!


python311Packages.repoze-{lru,sphinx-autointerface,who}: rename from repoze_{lru,sphinx_autointerface,who}

Description of changes
part of https://github.com/NixOS/nixpkgs/issues/245383

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 266822 at b832f0a3 run on x86_64-linux 1

8 packages failed to build:

python310Packages.opensfm
python311Packages.opensfm
qemu_full
qemu_full.debug
qemu_full.ga
samba4Full
samba4Full.dev
samba4Full.man

48 packages built successfully:

buildbot
buildbot-full
buildbot-ui
ceph
ceph-client
ceph-csi
ceph.dev
ceph.doc
libceph (ceph.lib ,libceph.dev ,libceph.doc ,libceph.lib ,libceph.man)
ceph.man
devpi-client
devpi-server
python310Packages.aiohttp-apispec
python310Packages.cornice
python310Packages.cypherpunkpay
python310Packages.deform
python310Packages.pypugjs
python310Packages.pyramid
python310Packages.pyramid-chameleon
python310Packages.pyramid-exclog
python310Packages.pyramid-jinja2
python310Packages.pyramid-mako
python310Packages.pyramid-multiauth
python310Packages.repoze-lru
python310Packages.repoze-sphinx-autointerface
python310Packages.repoze-who
python310Packages.routes
python310Packages.slack-bolt
python310Packages.webargs
python310Packages.webhelpers
python311Packages.aiohttp-apispec
python311Packages.cornice
python311Packages.cypherpunkpay
python311Packages.deform
python311Packages.pypugjs
python311Packages.pyramid
python311Packages.pyramid-chameleon
python311Packages.pyramid-exclog
python311Packages.pyramid-jinja2
python311Packages.pyramid-mako
python311Packages.pyramid-multiauth
python311Packages.repoze-lru
python311Packages.repoze-sphinx-autointerface
python311Packages.repoze-who
python311Packages.routes
python311Packages.slack-bolt
python311Packages.webargs
python311Packages.webhelpers

Result of nixpkgs-review pr 266822 at dd12b6e7 run on x86_64-linux 1

2 packages failed to build:

python310Packages.opensfm
python311Packages.opensfm

54 packages built successfully:

buildbot
buildbot-full
buildbot-ui
ceph
ceph-client
ceph-csi
ceph.dev
ceph.doc
libceph (ceph.lib ,libceph.dev ,libceph.doc ,libceph.lib ,libceph.man)
ceph.man
devpi-client
devpi-server
python310Packages.aiohttp-apispec
python310Packages.cornice
python310Packages.cypherpunkpay
python310Packages.deform
python310Packages.pypugjs
python310Packages.pyramid
python310Packages.pyramid-chameleon
python310Packages.pyramid-exclog
python310Packages.pyramid-jinja2
python310Packages.pyramid-mako
python310Packages.pyramid-multiauth
python310Packages.repoze-lru
python310Packages.repoze-sphinx-autointerface
python310Packages.repoze-who
python310Packages.routes
python310Packages.slack-bolt
python310Packages.webargs
python310Packages.webhelpers
python311Packages.aiohttp-apispec
python311Packages.cornice
python311Packages.cypherpunkpay
python311Packages.deform
python311Packages.pypugjs
python311Packages.pyramid
python311Packages.pyramid-chameleon
python311Packages.pyramid-exclog
python311Packages.pyramid-jinja2
python311Packages.pyramid-mako
python311Packages.pyramid-multiauth
python311Packages.repoze-lru
python311Packages.repoze-sphinx-autointerface
python311Packages.repoze-who
python311Packages.routes
python311Packages.slack-bolt
python311Packages.webargs
python311Packages.webhelpers
qemu_full
qemu_full.debug
qemu_full.ga
samba4Full
samba4Full.dev
samba4Full.man

I fixed the commit messages.
pytho3Packages -> python3Packages

@ofborg eval


Issues installing tab on arm64. Failed to select version for zeroize = "^0.9.3"

rustup stable-aarch64-unknown-linux-gnu unchanged - rustc 1.51.0 (2fd73fabe 2021-03-23)
cargo cargo 1.51.0 (43b129a20 2021-03-16)
OS Linux homebase 5.11.16-gentoo-x86_64 #1 SMP Wed Apr 21 20:13:15 EDT 2021 aarch64 GNU/Linux
 (chroot) homebase ~ # cargo install -j24 tab
    Updating crates.io index
  Installing tab v0.5.7
error: failed to compile `tab v0.5.7`, intermediate artifacts can be found at `/tmp/cargo-installc5woYg`

Caused by:
  failed to select a version for the requirement `zeroize = "^0.9.3"`
  candidate versions found which didn't match: 1.3.0, 1.2.0, 1.1.1, ...
  location searched: crates.io index
  required by package `dialoguer v0.7.0`
      ... which is depended on by `tab v0.5.7`

I checked out the 0.5.7 tagged commit e167812a60bbbf01cc3cb9f10700a34d5dc16565  and the latest in main then manually updated tab/Cargo.toml dialoguer to 0.8.0 and both build successfully. It pulled in zeroize v1.3.0
playing around with it, it seems to be working, though some of the tests failed. [retask, keyboard_latency, reconnect, service::client::client_session_tests::tx_terminated, service::client::tests::terminate_escape] the rest passed.

I experienced this problem on my x86_64 Linux system as well, haven't tried the fix yet.

I know this is an old thread, but just wanting to give an update for anyone else who comes across this issue. The current main branch now has an updated version of dialoguer, so you can build and install tab by just running:
cargo install --path tab

That said, as of writing, the current released version (v0.5.7), and therefor the version available via crates.io, does not include this update. So running:
brew install austinjones/taps/tab

or:
cargo install tab

appears to still be broken. If possibly, it would be great if we could get a new minor version released so that the instructions on the README page work for new users.


Binaries and Intermediate folder should not be included

Hey, this is more as a feedback rather than an issue.
Binaries and Intermediate folder should not be included when you upload a tag with a ZIP of the plugin's files.
Those folders are generated by the compilation and IDE during development, and will be regenerated in other devs computers.

Agreed. We're currently working on automating our release process and will clean this up. Thanks for the feedback.


Sticky footer

Request sticky footer
I try to set footer at bottom of page but my-auto on footer doesn’t work

my-auto is for vertical margin not for positioning. You can add class fixed-bottom to make element sticky at the bottom of the page.

Fixed bottom doesn’t work, footer stay over post content on small windows size.
Margin top auto (mt-auto) on flex item is correct on bootstrap html classic theme.
sorry for my-auto (mobile phone auto correct)

Can you please share a link to your site and explain again exactly what you want to do? I must understand it on example.

Ok it’s resolved
I just add a filter on language attribute and some classes.
I send patch this afternoon (can’t write code on mobile phone)

/* Add your styles here */ html {     height: 100vh; } html.admin-bar {     height: calc( 100vh - 32px ); } @media (max-width: 767px) {     html.admin-bar {         height: calc( 100vh - 46px );     } } body {     height: 100%; } #page {     display: flex;     flex-direction: column;     flex-grow: 1;     height: 100%; } #content {     min-height: auto; } footer {     margin-top: auto !important; }

`
// admin-bar Flex Adjust
add_filter('language_attributes', 'bootscore_5_footer_adjust');
function bootscore_5_footer_adjust($lang) :string{
if( is_user_logged_in() )
$lang = $lang . 'class="admin-bar"';
return $lang;
}
`

Do you have a live preview?

I just created the plugin to push the footer in the footer.
You are free to test it.
https://github.com/norico/BtScore-Footer-Adjust

Why you deleted the link to your plugin? I would reopen this issue and transfer it to parent-theme's issues. So users can load it if they want to use a sticky footer. I like your plugin.


Projects created by vue3  + ts + vue-router cannot run

Version
4.5.4
Reproduction link
https://github.com/hello-hyh/vue-cli-issue
Environment info
  System:
    OS: Windows 10 10.0.18363
    CPU: (12) x64 Intel(R) Core(TM) i7-8850H CPU @ 2.60GHz
  Binaries:
    Node: 12.16.1 - C:\Program Files\nodejs\node.EXE
    Yarn: 1.22.4 - ~\AppData\Roaming\npm\yarn.CMD
    npm: 6.14.5 - C:\Program Files\nodejs\npm.CMD
  Browsers:
    Chrome: 85.0.4183.83
    Edge: Spartan (44.18362.449.0)
  npmPackages:
    @ant-design-vue/babel-helper-vue-transform-on:  1.0.1
    @vue/babel-helper-vue-jsx-merge-props:  1.0.0
    @vue/babel-plugin-transform-vue-jsx:  1.1.2
    @vue/babel-preset-app:  4.5.4
    @vue/babel-preset-jsx:  1.1.2
    @vue/babel-sugar-functional-vue:  1.1.2
    @vue/babel-sugar-inject-h:  1.1.2
    @vue/babel-sugar-v-model:  1.1.2
    @vue/babel-sugar-v-on:  1.1.2
    @vue/cli-overlay:  4.5.4
    @vue/cli-plugin-babel: ~4.5.0 => 4.5.4
    @vue/cli-plugin-eslint: ~4.5.0 => 4.5.4
    @vue/cli-plugin-router: ~4.5.0 => 4.5.4
    @vue/cli-plugin-typescript: ~4.5.0 => 4.5.4
    @vue/cli-plugin-vuex: ~4.5.0 => 4.5.4
    @vue/cli-service: ~4.5.0 => 4.5.4
    @vue/cli-shared-utils:  4.5.4
    @vue/compiler-core:  3.0.0-rc.10
    @vue/compiler-dom:  3.0.0-rc.10
    @vue/compiler-sfc: ^3.0.0-0 => 3.0.0-rc.10
    @vue/compiler-ssr:  3.0.0-rc.10
    @vue/component-compiler-utils:  3.2.0
    @vue/eslint-config-standard: ^5.1.2 => 5.1.2
    @vue/eslint-config-typescript: ^5.0.2 => 5.1.0
    @vue/preload-webpack-plugin:  1.1.2
    @vue/reactivity:  3.0.0-rc.10
    @vue/runtime-core:  3.0.0-rc.10
    @vue/runtime-dom:  3.0.0-rc.10
    @vue/shared:  3.0.0-rc.10
    @vue/web-component-wrapper:  1.2.0
    eslint-plugin-vue: ^7.0.0-0 => 7.0.0-beta.3
    typescript: ~3.9.3 => 3.9.7
    vue: ^3.0.0-0 => 3.0.0-rc.10
    vue-eslint-parser:  7.1.0
    vue-hot-reload-api:  2.3.4
    vue-loader:  15.9.3 (16.0.0-beta.6)
    vue-router: ^4.0.0-0 => 4.0.0-beta.9
    vue-style-loader:  4.1.2
    vue-template-es2015-compiler:  1.9.1
    vuex: ^4.0.0-0 => 4.0.0-beta.4
  npmGlobalPackages:
    @vue/cli: Not Found

Steps to reproduce
vue create vue-next-v3
following is  console output
Vue CLI v4.5.4
Please pick a preset: Manually select features
Check the features needed for your project: Choose Vue version, Babel, TS, Router, Vuex, CSS Pre-processors, Linter
Choose a version of Vue.js that you want to start the project with 3.x (Preview)
Use class-style component syntax? No
Use Babel alongside TypeScript (required for modern mode, auto-detected polyfills, transpiling JSX)? Yes
Use history mode for router? (Requires proper server setup for index fallback in production) Yes ? Pick a CSS pre-processor (PostCSS, Autoprefixer and CSS Modules are supported by default): Sass/SCSS (with dart-sass)
Pick a linter / formatter config: Standard
Pick additional lint features: Lint on save
Where do you prefer placing config for Babel, ESLint, etc.? In dedicated config files
Save this as a preset for future projects? No
What is expected?
use npm run serve command to success run app
What is actually happening?
$ npm run serve
 ERROR  Failed to compile with 2 errors                                                                                15:35:31
 error  in ./src/App.vue?vue&type=template&id=7ba5bd90

Syntax Error: SyntaxError: Unexpected token u in JSON at position 0
    at JSON.parse (<anonymous>)

 @ ./src/App.vue?vue&type=template&id=7ba5bd90 1:0-319 1:0-319
 @ ./src/App.vue
 @ ./src/main.ts
 @ multi (webpack)-dev-server/client?http://****:8080&sockPath=/sockjs-node (webpack)/hot/dev-server.js ./src/main.ts

 error  in ./src/views/About.vue?vue&type=template&id=039c5b43

Syntax Error: SyntaxError: Unexpected token u in JSON at position 0
    at JSON.parse (<anonymous>)

 @ ./src/views/About.vue?vue&type=template&id=039c5b43 1:0-336 1:0-336
 @ ./src/views/About.vue
 @ ./src/router/index.ts
 @ ./src/main.ts
 @ multi (webpack)-dev-server/client?http://******:8080&sockPath=/sockjs-node (webpack)/hot/dev-server.js ./src/main.ts

It seems to be lost  script tag and script content in App.vue and About.vue
I think may be cli-plugin-typescript package line 3 lead too this problem, or cli-plugin-router template has conflicts with cli-plugin-typescript template

Just published vue-loader 16.0.0-beta.7. That should have fixed this bug.


[Feature Request] Respect Entity Permissions

Very cool module. The only issue I'm running into is that the right-click context menu on entity links is available for all players, and players can activate any of the context menu options regardless of their permissions regarding that entity.
 The player can bypass their lack of permissions by right-clicking the link and selecting View Scene and Show Players (Text)/Show Players (Image).

Thanks for your feedback! All scenes options should be restricted to GM only, I'll look into this issue.

I did a test on my side and I can not reproduce this bug: contextmenu don't show up when user is a standard user.
Did you changed your players permissions in your campaign ? What role did you assign to your players ?

Thanks for taking a look at this so quickly!
My players all have standard player user roles. I have changed the permissions somewhat, though. The current settings are:

Setting
Player Permission

Configure Token Settings
Disabled

Create Journal Entries
Disabled

Create Map Notes
Disabled

Create Measured Template
Enabled

Create New Actors
Disabled

Create New Items
Disabled

Create New Tokens
Disabled

Display Mouse Cursor
Enabled

Display Ruler Measurement
Enabled

Modify Configuration Settings
Disabled

Open and Close Doors
Disabled

Upload New Files
Disabled

Use Drawing Tools
Enabled

Use File Browser
Disabled

Use Script Macros
Enabled

Whisper Private Messages
Enabled

I'm using Forge to host my game. I don't know if it's pertinent to the issue at hand, but I don't use Forge's automatic user management.

Okay, I find a bug related to action display conditions. I'm investigating this.

I released a new version (v1.0.1). Please update and try again. This version should solve your issue, but even if it do not, this is a mandatory update to dig deeper into you issue.

Scene links look to be fixed! Journal entry links with None permissions are still showing options for players to show text/images, though.

I released a new version (v1.0.2) which includes new controls around permission on all entities.

Works perfectly! Thanks!


Lost pages

When you deploy again in heroku, all the created pages are removed.

As long as you use the same remote git settings, your content will be fetched back. You just have to wait for the content to be re-synced, which can take a few seconds. Reload the site after a minute to see your content.


issue with intent schema, fairly new at this

First, everything has been working swimmingly through the initial node setup and the readiness for the outside world (ddns).  I'm at the Alexa Skill creation part, and this is where I'm hanging up.
I've created the custom slots and copied in the appropriate info from the files.  I've copy/pasted the intent schema and the utterances.  However, when I go to save it, I get this error:
Error: There was a problem with your request: Error in sample on line 21 - 'MusicIntent play {coldplay|name} in the {Room}'. The given intent doesn't declare the slot 'name'.
Not really sure how to address this, and didn't (couldn't) find anything in searches related to this, so any guidance is super appreciated.
Thanks!

I believe 'Name' should be capitalized.

Thank you; in the intent file --
{
"intent": "MusicIntent",
"slots": [
{
"name": "Name",
"type": "AMAZON.LITERAL"
or in the utterance file?
MusicIntent play {coldplay|name} in the {Room}

They must match. If it's capitalized in one, then it should be capitalized in the other.
The error on the other hand seems to contradict Amazon documentation: https://developer.amazon.com/public/solutions/alexa/alexa-skills-kit/docs/alexa-skills-kit-interaction-model-reference#literal-slot-type-reference
It says there that examples must be given for slots of type AMAZON.LITERAL. However, your error seems in conflict with that requirement.
Could you try changing AMAZON.LITERAL to just LITERAL? The documentation says that AMAZON.LITERAL is no longer supported at the end of the month. I know folks in UK and Germany had issues with AMAZON.LITERAL not working.

After making that change to the five or so instances in the intent schema (and leaving AMAZON.NUMBER alone), it Successfully updated the interaction model.
THANK YOU!

I am getting an error " Error: There was a problem with your request: Invalid intent name 'null'.
", what can be the problem?

If anyone else has this issue, I found that the beta Interaction model isn't the most obvious thing in the world. You not only have to 'save' it, but also 'build' it too. Once you build it, you can then enable testing.