[SVCS-552] Remove unneeded API calls in folder_file_ops

Added construct_path and construct_empty_path to base-
provider for individual providers to make paths for folder-file-ops
without needing to make API calls

Ticket
https://openscience.atlassian.net/browse/SVCS-552

Purpose
the Baseprovider class folder_file_op function was making calls to get metadata, and then making the same calls again when calling revalidate path. It is possible to create paths from this metadata and forgo making more API calls.

Changes
Added 2 new functions to the Baseprovider. construct_path and construct_empty_path.
Construct_path takes the parent path and metadata. Each provider then has its own implementation on how to get a path from this. Some will simply use it as a proxy to revalidate_path since their revalidate_path does not make API calls. If an individual providers revalidate_path does make api calls, it will instead call path_from_metadata or something similar.
construct_empty_path returns a math from metadata where the identifier is none( ie it doesnt actually exit at that location).
Added tests to test these new functions. construct_empty_path is tested in core/test_provider since almost all providers use the base definition.
construct_path is tested individually in providers and is ALWAYS tested against the output of revalidate_path because that is what it is replacing.
Dataverse is the only provider that could still makes API calls here, however I am fairly certain that dataverse cannot perform folder_file_ops so it should never call those functions.

Side effects
There could be some timing issues, however this seems unlikely

QA Notes
To test, move or copy a folder containing at least one file across 2 providers.
ie move folder1 from OSFstorage to GoogleDrive. It should work and make less API calls
Figshare may not work quite correctly. It is very hard to test with the many bugs figshare has.

Deployment Notes

Coverage increased (+0.04%) to 89.057% when pulling 918743f2cc14646f157fc93ed8ca54f074214124 on AddisonSchiller:feature/folder-file-ops-revamp into 3d9ac2f7dad5a02d0ef0baf7b78dee1ff0672996 on CenterForOpenScience:develop.

Coverage increased (+0.04%) to 89.244% when pulling f1e59f8dc5fdb6a9d721bbcd8d89b2ef56b03376 on AddisonSchiller:feature/folder-file-ops-revamp into cc68aca3fd9dc281aa0d1037ddad95d8eb75a174 on CenterForOpenScience:develop.

Coverage increased (+0.04%) to 89.244% when pulling 1188a93271d6a9731145987243da057a64f2b61d on AddisonSchiller:feature/folder-file-ops-revamp into cc68aca3fd9dc281aa0d1037ddad95d8eb75a174 on CenterForOpenScience:develop.


Create pull_request_template.md

Create Pull_request Template
Fixes  #1

@Abhishek-kumar09  I have done the changes tell me if something more you want me to add or change


Make more areas

As the project starts to get bigger, let's export what we can in areas.

Good job, Issue Resolved


Lidar Data Format and Foggification Parameters for VLP32 Lidar

Hello,
I download some HDL64 and VLP32 Lidar data from the DENSE datasets. Each data file consists of 5 columns where the first 3 columns are x/y/z coordinates and the 4th column is intensity. What is the meaning of the 5th column?
I have a VLP32 Lidar and would like to apply fortification to its data frames. Have you measured the parameters g and n for VLP32 Lidar? If not, is it possible to derive them from the matching data frames of HDL64 and VLP32 Lidar and the known parameters of the HDL64 Lidar?
Thank you and looking forward to your reply.

Hi @qiank10, the fifth colum contains the laser power level. Velodyne sensors are able to adaptively set the laser power level dependent on the target to prevent saturation of the detector for high reflective targets and to increase laser power for low reflective targets.
In terms of Foggification. We did not measure the parameters for the VLP32, but there is a follow up paper “CNN-based Lidar Point Cloud De-Noising in Adverse Weather” written by Heizler et. al. using our algorithm for the VLP32 and the same parameters n/g as for the HDL64S3D.

Thank you for the answers. I'll try the parameters n/g for the HDL64S3D.

Hi @qiank10, the fifth colum contains the laser power level. Velodyne sensors are able to adaptively set the laser power level dependent on the target to prevent saturation of the detector for high reflective targets and to increase laser power for low reflective targets.

@MarioBijelic Follow-up question to your answer: The fifth column ranges from 0-63 for the HDL64 S3 and 0-31 for the VLP32, however the manual of the HDL64 states that in automatic power mode the returned power-level is a 3-bit information, which therefore ranges only from 0-7. Based on the value ranges I assumed this column describes the vertical index of the emitting laser, or am I confusing something here?

Hi @qiank10, the fifth colum contains the laser power level. Velodyne sensors are able to adaptively set the laser power level dependent on the target to prevent saturation of the detector for high reflective targets and to increase laser power for low reflective targets.

@MarioBijelic Follow-up question to your answer: The fifth column ranges from 0-63 for the HDL64 S3 and 0-31 for the VLP32, however the manual of the HDL64 states that in automatic power mode the returned power-level is a 3-bit information, which therefore ranges only from 0-7. Based on the value ranges I assumed this column describes the vertical index of the emitting laser, or am I confusing something here?

@ptoews You are right, the 5th feature is the LiDAR channel and not the laser power level.

@ptoews You are right, the 5th feature is the LiDAR channel and not the laser power level.

Hey @MartinHahner, thanks for your answer. Can you elaborate what you mean by lidar channel? By vertical index I mean the association to one of the 32 or 64 vertically mounted lasers, I think you are referring to the same? And may I ask how you found this out or possibly have a source for that? That would help me so that I can rely on that in my thesis. Thanks!

Hey @MartinHahner, thanks for your answer. Can you elaborate what you mean by lidar channel? By vertical index I mean the association to one of the 32 or 64 vertically mounted lasers, I think you are referring to the same? And may I ask how you found this out or possibly have a source for that? That would help me so that I can rely on that in my thesis. Thanks!

@ptoews Yes, I mean the same as you. It already becomes obvious when you look at the value range as you pointed out.
But I also extended their dataset viewer in such a way that I can color-code the points based on the 5th feature. So I am absolutely certain that this is the LiDAR channel and not the laser power level.
When you visualize the data with their dataset viewer, you can add a few lines of code within update_lidar3d to mask out points based on the 5th column, to verify it for yourself if you like.
https://github.com/princeton-computational-imaging/SeeingThroughFog/blob/fae362911d03f01e6bc672b532b90d486df8d166/tools/DatasetViewer/DataViewer_V2.py#L386-L438

@ptoews Yes, I mean the same as you. It already becomes obvious when you look at the value range as you pointed out.
But I also extended their dataset viewer in such a way that I can color-code the points based on the 5th feature. So I am absolutely certain that this is the LiDAR channel and not the laser power level.
When you visualize the data with their dataset viewer, you can add a few lines of code within update_lidar3d to mask out points based on the 5th column, to verify it for yourself if you like.
https://github.com/princeton-computational-imaging/SeeingThroughFog/blob/fae362911d03f01e6bc672b532b90d486df8d166/tools/DatasetViewer/DataViewer_V2.py#L386-L438

Thanks for the tip, will definitely do that!

Thanks for the tip, will definitely do that!


Generic audio bindings support

For Android support, we need a new binding to the audio subsystem of LabSound.
We already had a binding for Magic Leap in LabSound. However, as we add more and more platforms, it makes sense to have a generic binding system that is plugged at final link time.
This is an implementation of that idea, which exposes a callback function setter that can be used to interface to the underlying audio subsystem for the platform.
It is the intent to move out the magic leap audio binding to the consumer, and implement Android similiarly, both outside of the LabSound library, while using this function pointer interface.

I have been thinking that this sort of mechanism is somehow necessary as well. Originally, LabSound had platforms hard-structured into the code; a mac implementation, a windows implementation, and so on. Little by little it became obvious that sometimes I wanted to use RtAudio on windows, and sometimes native facilities, so I split the implementations up into the backends directory, which has worked out pretty well so far. I like the idea of taking it even further to allow external back end implementations.


state transfer sub command does not clean up the resources it creates

In order to clean up manually before running use the following command:
$ oc --context=destination-ctx -n pvc-transfer-source delete pod,cm,secret,svc,route -l app=crane2 && oc --context=destination-ctx -n pvc-transfer-source delete pvc foo && oc --context=source-ctx -n pvc-transfer-source delete pod,cm,secret,svc,route -l app=crane2

follow up from #19

/kind bug
/priority critical


Recreate entities  from JDA in Jorg with only the needed data

JorgUser

[x] userId
[x] username
[x] discriminator
[x] avatarUrl
[ ] isBot

JorgGuild:

[x] guildId
[x] guildName
[x] guildIconUrl

JorgMember

[x] JorgUser object
[ ] Roles array

JorgRole

[ ] roleName
[ ] JorgPerms

JorgPerms

[ ] list of perms that is available ala hasXPerm, hasYPerm, further research required

There are a LOT of permissions and they can all apply to person, voice, or text.
https://ci.dv8tion.net/job/JDA/javadoc/net/dv8tion/jda/api/Permission.html#ALL_CHANNEL_PERMISSIONS

Should JorgMember's Roles array be an array or list of JorgRole's?


exporter/stats/prometheus: enforce singleton on one exporter per process

The docs at https://prometheus.io/docs/instrumenting/writing_exporters/#deployment recommend that exactly ONE exporter per instance so this is sort of similar to #264 but here for prometheus instead of by ProjectID, it is per instance.

Fixed by #268


Update ldr_amd64.s resolver to use OriginalBase

Hello
Thank you for your awesome work.
I used it on internal testing with one of my tool and noticed i had to change the value of the Dll address against a security product to use the one in OriginalBase (see https://www.vergiliusproject.com/kernels/x64/Windows 10 | 2016/2110 21H2 (November 2021 Update)/_LDR_DATA_TABLE_ENTRY).
If you think it should be merge, it would be interesting to change the comment too ^^

Thanks for the contribution!
Out of curiosity, have you also tried to retrieve the address in DllBase with equivalent assembly instructions?
If the detection is due to the original instructions that match a specific pattern of opcodes the security solution classifies as dangerous, maybe we can still retrieve the address from DllBase using alternative instructions very easily.


Testing improvements.

Tests now take ~2m40 on my laptop.  With -Dcheck.size=100 -Dcheck.count=1, they take about ~1m20.  A huge part of the test time was (re)creating the SparkContext.
I disabled testVSMGenIsLinearSpaceInSizeParameter.  It doesn't quite make sense to me to be spending half our test time budget verifying ... that our tests aren't taking too long.  Happy to discuss it on Monday.
Following Jackie's original code, the duplicated logic and defaults for check settings in Prop and gradle are needed to include the check settings (in particular, the seed) in the gradle output when you're not using --info or similar.  I couldn't figure out another way to do it.
Changes:
Set seed with -Dcheck.seed=seed, random with -Dcheck.seed=random.
Added SparkManager to store sc and sqlContext.
Reuse sc between tests.
Added -Dcheck.size=size and -Dcheck.count=count.
Removed Prop.check with count, size options.
Disabled testVSMGenIsLinearSpaceInSizeParameter.

Awesome.  I want this, so I'm merging it in.  Hope that's okay...

Re: testVSMGenIsLinearSpaceInSizeParameter I agree and I also feel that it's a bit flaky.


remove dead code from dbscan code

Did you read the Contributor Guide?

Yes, I have read the Contributor Rules and Contributor Development Guide

Is this PR related to a JIRA ticket?

No

What changes were proposed in this PR?
removing dead code in the DBSCAN implementation
How was this patch tested?
ran stats unit tests
Did this PR include necessary documentation updates?

No, this PR does not affect any public API so no need to change the documentation.

@james-willis JIRA ticket for this. Please.


Abhay/wasserstien distance metric

Description

Additional context and related issues

Release notes
( ) This is not user-visible or docs only and no release notes are required.
( ) Release notes are required, please propose a release note for me.
( ) Release notes are required, with the following suggested text:
# Section
* Fix some things. ({issue}`issuenumber`)

Moved to the correct repo: https://github.com/truera/truera-trino/pull/4


Error while running sample code for IOS - Error - Framework not found

When I tried to run the code for IOS simulator, I received below error.
MTOUCH : warning MT1302: Could not extract the native framework 'TOCropViewController.framework' from '/Users/admin/Desktop/Xam.Plugins.ImageCropper-master/Sample/iOS/obj/iPhoneSimulator/Debug/mtouch-cache/TOCropViewController.framework.zip'. Please ensure the native framework was properly embedded in the managed assembly (if the assembly was built using a binding project, the native framework must be included in the project, and its Build Action must be 'ObjcBindingNativeFramework').
clang : error : linker command failed with exit code 1 (use -v to see invocation)
error MT5209 : Native linking error : framework not found TOCropViewController
MTOUCH : error MT5202: Native linking failed. Please review the build log.
1 Warning(s)
3 Error(s)

Why did you close this? I have this as an issue, did you get it working? if so please share how you fixed it.

There is one make file available. when run it on your mac, it would download actual native project and create a framework file required.
I expect a framework file instead of make file as solution.
Let me open this issue as per request.

Right ok, I didn't quite realise that. I opened up the folder with the make file, entered "make" into my terminal, everything installed and now iOS will build & run. Thanks!


Get Started with SAP S/4HANA Cloud SDK for JavaScript

Tutorial URL: https://developers.sap.com/tutorials/s4sdkjs-getting-started.html
Step 4: Use the SDK in existing project (optional)
`austinkloske@penguin:~/git/cloud-s4-sdk-examples$ npm run start:local

<EMAIL_ADDRESS>start:local /home/austinkloske/git/cloud-s4-sdk-examples
npx ts-node src/

Express server listening on port 8080
^C
austinkloske@penguin:~/git/cloud-s4-sdk-examples$ sudo npm install @sap/s4sdk-core
npm ERR! code E404
npm ERR! 404 Not Found: @sap/s4sdk-core@latest
npm ERR! A complete log of this run can be found in:
npm ERR!     /root/.npm/_logs/2019-04-17T22_13_47_721Z-debug.log`

Thanks for reporting this issue. Unfortunately, the tutorial references an obsolete name, this should be @sap/cloud-sdk-core. We will adapt the tutorial.
Please try with sudo npm install @sap/cloud-sdk-core.

This has been fixed in the tutorial and can be closed.


Automatically update resources with all Gatherling tournaments.

I cleaned up resources in 83b4926 and I think that'll do.


gmtstrainplot python verion error

Describe the bug
Bug at program gmtstrainplot.sh
The bug is caused when bash calls python to compute/print computation results. Some of the calls
cause errors in Python3.x  (e.g sclat=$(echo print ${south} + ${tmp_scrate} | python)). These lines
are ok for previous versions of Python.
To Reproduce
Steps to reproduce the behavior:

run command './gmtstrainplot.sh -jpg -vhor station_info.dat -psta -l -o output_vel'
using Python 3.6
check for errors

"<stdin>", line 1
print 34 + 0.4

or
File "<stdin>", line 1, in <module>
TypeError: unsupported operand type(s) for -: 'builtin_function_or_method' and 'float'

Expected behavior
All of the lines just compute a bash variable (to be used later on)
Screenshots
Desktop (please complete the following information):

OS: [Windows]
Python: [3.6]
GMT: [e.g. 5.2.1] -- irrelevant
StrainTool: [v1.0-rc2.0]

Additional context
Bug reported by Varvara

Tried to fix this via computing all quantities with bc, but that is probably not an option. Python does complicated manipulations (like print(round(${T},-1)+10)); this is not possible with bc (at least not in less than a few lines).

Trying a new approach:

add a function in the script, to resolve system's python version (resolve_py_version())
make a function alias to python; this is called pythonc. If the system Python version is 3.x.x, then
this function just collapses to alias pythonc="python -c". Else, if the version is 2.x.x, then the alias is
python -c "from __future__ import print_function;.

Hence, now

When calling Python's print in the script, always use Python 3.x.x syntax
Instead of writing

python -c "print int((${south} + ${north})/2)"

we write
pythonc "print int((${south} + ${north})/2)"

Also, never use the piped version, aka echo print ${south} + ${tmp_scrate} | python


[BUG]

Information

Apktool Version (apktool -version) - Answer: 2.10.0
Operating System (Mac, Linux, Windows) - Answer: Linux localhost 4.19.136-perf+ #1 SMP PREEMPT Sat Sep 28 15:44:54 CST 2024 aarch64 Android
APK From? (Playstore, ROM, Other) - Answer: Chrome
Java Version (java --version) - Answer: openjdk version "21.0.5" 2024-10-15

Stacktrace/Logcat
❯ apktool b Data/ --output out.apk
I: Using Apktool 2.10.0 with 6 thread(s).
I: Checking whether sources has changed...
I: Smaling smali folder into classes.dex...
I: Checking whether sources has changed...
I: Checking whether sources has changed...
I: Smaling smali_classes2 folder into classes2.dex...
I: Smaling smali_assets folder into assets.dex...
I: Checking whether resources has changed...
I: Building resources...
W: /data/data/com.termux/files/usr/tmp/brut_util_Jar_179186574957728854387583908200169979170.tmp[1]: ELF: inaccessible or not found
W: /data/data/com.termux/files/usr/tmp/brut_util_Jar_179186574957728854387583908200169979170.tmp[2]: syntax error: unexpected '('
brut.androlib.exceptions.AndrolibException: brut.common.BrutException: could not exec (exit code = 1): [/data/data/com.termux/files/usr/tmp/brut_util_Jar_179186574957728854387583908200169979170.tmp, compile, --dir, /data/data/com.termux/files/home/downloads/Data/res, --legacy, -o, /data/data/com.termux/files/home/downloads/Data/build/resources.zip]

Steps to Reproduce

apktool

Frameworks
If this APK is from an OEM ROM (Samsung, HTC, LG). Please attach framework files
(.apks that live in /system/framework or /system/priv-app)
APK
If this APK can be freely shared, please upload/attach a link to it.
Real.Boxing.ver.2.11.0.build.300162_r.zip
Questions to ask before submission

Have you tried apktool d, apktool b without changing anything?  Answer: Yes
If you are trying to install a modified apk, did you resign it? Answer: No
Are you using the latest apktool version? Answer: Yes

Sadly running on Android is not supported.


MEGA is shown as Google drive in Cloud Drives

Description
MEGA is shown as Google drive in Cloud Drives

Steps To Reproduce
Simply start Files with an attached MEGA cloud share
Requirements
Please fix the name
Files Version
<IP_ADDRESS>
Windows Version
10.0.22631.3447
Log File
debug.log

Thanks for the report, have you previously had Google Drive installed?

Yes, I had Google drive installed previously.

This is probably from an issue with Google Drive not uninstalling property. Can you try opening the registry path HKEY_CURRENT_USER\Software\Google and see if Drive or DriveFS is shown, If so you can Right click > Delete on those folders only and restart Files from the system tray.

I did and it did not solve the problem.

I removed the folder C:\Users\JAOtt\AppData\Local\Google\DriveFS.
After that the MEGA entry completely disappeared.

The path is for the registry not normal file explorer.

I don't understand wath you say.

Type Registry in Windows start menu search bar > Open it > Enter the path from my first comment into the box that says computer follow the restart of the instructions.

I'm a little confused
I removed the registry entry for Google drive as you mentioned before. It dit not change everything.
After that I removed the folder C:\Users\JAOtt\AppData\Local\Google\DriveFS. The result was that the MEGA disappeared from Cloud Drives
How do I get MEGA visible in Cloud Drives?

Did you fully close and reopen Files after?

Yes I did. To be sure I restarted Windows.

Thanks for the information. Mega should show without Google drive but I guess there's an issue with detection.

@HanOtten it seems that one of the registry keys isn't configured properly, I can't say for sure, but there is a good chance reinstalling Mega will fix this issue.
Can you also confirm if Mega is displayed in File Explorer?

I reinstalled MEGA, but it is still not shown in cloud drives.
MEGA is shown in the Windows explorer.
Please, can you tell me wich registry key should be available for detecting MEGA?

@Josh65-2201 do you know?

Have you fully restarted Files by quitting from the system tray?

That was the trick, after enebling MEGA file explorer integration it works.
Thanks for your help.

Great to know


Strings

Even though strings are only used for meta-programming, the misalignment is unpleasant since e.g. every auto_param prints as an enormous term of unreadable string.str applications. There are four issues here:

fin vs Fin (def vs structure)
unsigned vs UInt32 (def vs structure)
is_valid_char vs isValidChar (Nat.le issue as in https://github.com/dselsam/mathport/issues/15)
bits vs ofNat (number mismatch as in https://github.com/dselsam/mathport/issues/17)

The last two issues need to be solved independently. The first two seem to only be required for aligning strings.
Note: lean3 used to make fin a structure but changed it to a def so that the subtype API could be used: https://github.com/leanprover-community/lean/issues/359
I see a few options:

don't align strings
backport Fin
backport a fin4 that is only used for characters, and align this
try to auto-port char -> Char anyway and discard whatever downstream declarations fail
forward-port Fin as def

I suggest backporting fin4 (just for char) as a default, assuming Leo wants to keep Fin a structure.

What about erasing auto_param? That is, the porting tools rewrites auto_param a t ==> a.

I agree that would be better than not aligning and keeping the unreadable junk. I think the auto-param is useful information though, and figured mathlib might reimplement it and want the old annotations. We could also only auto-port the string literals used in auto-param and discard whatever breaks because of that change, which is probably nothing besides the auto_param equations themselves.

I added special support for replacing auto_param calls with autoParam calls inside mathport. I think every auto_param in mathlib uses obviously, and so for now I just hard-coded syntax for Mathlib.obviously in the new autoParam terms rather than parse the names.

There are more than just obviously.  Good catch, thanks. I guess I will parse the names during mathport.

Now we decode the concrete strings from auto_param arguments: https://github.com/dselsam/mathport/blob/master/MathPort/Translate.lean#L63


StoryBook Testing

Why
This test ensures that storybook components are working well and nothing is broken.
What
Review existing Story book test review and fix any configuration and deployment issues.
How
Execution

On workflow file changed
On frontend files changed
Deployment: https://storybook.govtool.cardanoapi.io

This ready to be closed now @spannercode ?

The https://storybook.govtool.cardanoapi.io/ link does not work

@Ryun1 as soon as the base repository for the storybook is decided, we can complete this. The link will be live again after the deployment.

PR for updated storybook tests.

PR for update workflow

Storybook is deployed to link
https://storybook-govtool.cardanoapi.io/

The related PRs are merged and the deployment complete with a publicly accessible URL (in previous comment by Sudip) so closing this ticket as completed.
CC: @Ryun1


Update readme to mention pip install git+

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Will CAT work under Mojave or not?

It would be great if the documentation for this project got updated for Mojave.  I have a Mac that should be able to run Mojave and have no idea if I should attempt to update without knowing if CAT is going to work.
Mac Pro (2012), model 5,1
I've submitted a pull request to the documentation regarding Sierra, but it's been sitting for nearly a year without being merged.  Is this project dead?

I have a 2009 Mac Pro updated to 5.1 firmware with a compatible 4.0 LTE Bluetooth and Wifi card. Was fine until Mojave. I have chatted with the Mac devs and they claim nothing has changed that would prevent this hack from working (assuming they aren't lying). Hardware list hasn't changed for sure. Anyway to either edit and use this tool as is or get a fix?

I have chatted with the Mac devs and they claim nothing has changed that would prevent this hack from working

What Mac developers?  Apple?  Apple actually talked to you about a Mac that was hacked?

Verifying Wi-Fi hardware... NOT OK. No compatible Broadcom AirPort card is active

I've seen this once or twice with mine under Sierra.  It was temporary and cleared up after rebooting.  Probably a coincidence since I also have VPN software that kills the Wifi interface if the VPN is dropped.
While I appreciate your response to my question, it's still unanswered.  I have a stock machine that does not need any hacks to run Mojave.  I wish the developer(s) of CAT would respond to some of these more recent threads.

Hi please can you tell me if your tool will work with Mojave OS.
Also is this project still being manned by anyone?

For me the tool works with 10.14.1 on a MBP 6,2 (2010, 15“) with BT 4.0 dongle:
https://github.com/dokterdok/Continuity-Activation-Tool/issues/438#issuecomment-436787007

10.14.1 ?
BETA?

10.14.1 Final Release

I've tried running the fix on Mojave, it does not work and stops the OS from booting up.
I had to put the machine in to recover mode, and had to reinstall Mojave, 10.14.1 before being able to get access to the drive again.
Please update software so it can be used on Mojave.


Add tooling to check for HTTPS versions of cask URLs

I saw some cask updates losing their https links and I though we could add a tool to migrate all those casks that have an HTTPS version of the download link (and maybe homepage too) available but are not currently using it.

Closing for lack of implementation. This is can be revisited later.


Refactor command line arguments parsing with a dedicated CommandParser

Continuation of #26213.
Thank you a lot to @lupoDharkael for the initial work! I updated the code to the latest master and heavily redone the previous implementation. What I added:

Usage generation (can be disabled).
Support for positional arguments (it's better to support it instead of manually checking for scene / script).
Multiply arguments support.
Support for default values.
Support for required arguments (checked automatically after calling notify())
Support for compound arguments (-abc), sticky arguments (-dvalue), adjacent arguments (-d=value) (all this things can be disabled).
The ability to specify allowed values lists (syntactic sugar for checkers).
Support for any number of flags in a single command.
Support for use with different prefixes (e.g. /command, +command, -command, etc, this can be useful for chat commands parsing, for example).
Custom actions on parsing via parsed signal.
Support for arguments that can be specified multiply times.
The ability to configure help message padding / size.
Tests.
General API improvements.

Simple demo project: TestParser.zip
Current API looks similar to Qt (API) and Boost.program_options (features).
But I haven't made any changes to main.cpp. I think it will be better to agree on API first and merge it as a class for GDScript because it can be used as is. Then, I will send a separate PR with changes to main.cpp and then another PR with the ability to disable engine arguments to override with custom one. I think that this approach will simplify review process.

After adding tests from me, test_main.cpp got too big and can't compile on Windows without /bigobj. Could anyone help me with this? I am not familiar with SCons.

After adding tests from me, test_main.cpp got too big and can't compile on Windows without /bigobj. Could anyone help me with this? I am not familiar with SCons.

Perhaps somehow related to template fixture usage which may blow it up? I haven't done this to be honest...
Possibly /bigobj could be added specifically for tests env in SCons to resolve this.

Possibly /bigobj could be added specifically for tests env in SCons to resolve this (in https://github.com/godotengine/godot/blob/master/tests/SCsub).

Thanks, it worked :)

@akien-mga, I noticed that you changed the description. But in this PR there is not a refactoring of the current editor CLI.
I thought to provide a test-covered class that can be used in GDScript with this PR, and then reuse it to refactor the engine CLI in another PR to simplify review process and avoid merge conflicts. What do you think about it?
Also this PR is ready for review, just waiting for your feedback :)

This PR is not a refactoring of the current editor CLI. I thought to provide a test-covered class that can be used in GDScript with this PR, and then use it to refactor the engine command line arguments parsing in another PR.

I have a feeling this PR is not going to get looked at by the devs if it doesn't make an attempt to refactor the Godot CLI. Right now, this PR has no use case other than exposure in the API, something only a few people have shown a little interest for. Refactoring main.cpp is (in my understanding) a more important goal. The initial proposal (godotengine/godot-proposals#137) follows this line of thinking as well.
As it stands, this PR does not implement that proposal, and as no real need for an exposed command parser has been explicitely requested. That leads me to believe the devs will ignore your work, which is a shame because it looks promising. If you haven't already, take a look at Godot's best practices for contributing.

Refactoring main.cpp is (in my understanding) a more important goal.

While it's an important goal, adding a general-purpose command-line parser is a crucial step to achieve it, even if we don't end up exposing it as public API.

As it stands, this PR does not implement that proposal, and as no real need for an exposed command parser has been explicitely requested.

I'd definitely find the parser useful for a lot of things. Plugins like GUT would no longer need to implement their own command-line parsers. Game-specific options could also be implemented more easily: godotengine/godot-proposals#2726.
Even Python has argparse module, and GDScript is known to be similar to Python. The fact that Godot can execute scripts with --script parameter only supports the idea that we do have use cases that could be solved with this.

While it's an important goal, adding a general-purpose command-line parser is a crucial step to achieve it, even if we don't end up exposing it as public API.

I don't disagree, in fact I believe this is what I said as well. All I am saying is that I think this PR should define a command line parser and refactor main.cpp to use it. Optionally it could be exposed to the api already, but that can also happen in another PR.

@akien-mga, I noticed that you changed the description. But this PR is not a refactoring of the current editor CLI.

I have renamed the PR's title to reflect changes in this PR. Yeah this doesn't refactor the main.cpp argument parsing in the engine, and that could be made in the successive PRs.

While it's an important goal, adding a general-purpose command-line parser is a crucial step to achieve it, even if we don't end up exposing it as public API.

I don't disagree, in fact I believe this is what I said as well. All I am saying is that I think this PR should define a command line parser and refactor main.cpp to use it. Optionally it could be exposed to the api already, but that can also happen in another PR.

I don't disagree either, but exposed or not, the work done on refactoring main.cpp could be in vain if we end up not agreeing with the public API for the parser.

Exposed or not, the work done on refactoring main.cpp could be in vain if we end up not agreeing with the public (or rather internal, depending on what you treat as internal) API for the parser (and this is prominent by above reviews of mine), especially when this has a chance to be exposed to scripting.

Comes back to the point of what you prioritise: engine or api. I am fine either way, whichever is preferred by the maintainers. I just think if you develop the parser first for the engine, you have a clear use case where you can judge the implementation. That can then help with designing the public API.

I just think if you develop the parser first for the engine, you have a clear use case where you can judge the implementation. That can then help with designing the public API.

The previous PR #26213 did refactoring but ended up not reviewed either. Since this PR is based on #26213, I'd assume that it is already somewhat battle-tested against use cases in Godot (which are not that advanced, to be honest), and the implementation in this PR is by far more flexible than Godot really needs.
Unfortunately, this may be a problem to adoption, because as I said, Godot's development is extremely pragmatic and this PR may also end up in Limbo, just because it solves more problems than Godot currently has, which is pity to be honest...

Indeed, as @Xrayez mentions, there is not a proper proposal opened following proper procedure that can justify in real-world usage scenario integrating this kind of functionality. As such this PR will most likely end up in limbo. I suggest re-starting the process from scratch, opening a proper proposal and seeing if there is any interest.

I opened a counter-proposal about this:
https://github.com/godotengine/godot-proposals/issues/2797

@Xrayez, thank you a lot, will push discussed changes in a few days. I'm going to move this PR to Goost, if the developers don't change their minds. Have this class as a plugin sounds good to me too.

@Shatur have you considered refactoring help-related properties into a separate class yet? I think it would be fine to add a class for this which could be passed to get_help_text() method.
I'm thinking that CommandLineInterface could be a good name for this. The help text is an actual interface user see while interacting. If not, could be named as CommandLineHelpFormat.
Again, my main rationale about this is that there are like 60% of properties which are related to help text generation, and 40% of properties:

I think it's important to make the parser API easy to navigate and find properties which are going to be used in 90% of the cases compared to formatting properties.
The alternative, as I said previously, is to use a plain Dictionary for formatting stuff. Of course, we'll lack autocompletion but I don't think it's really that important to have public API for.

@Xrayez, yes, still thinking about it... I probably like the approach with CommandLineHelpFormat more as with Physics2DShapeQueryParameters.
Going to rebase to the latest master to fix CI, add the class and apply your other suggestions.

@Xrayez, pushed the changes. I keep changes in separate commits to simplify review. Will squash it once you are done :)

@Xrayez, thanks, yes, I pretty sure that the documentation should be improved.

@Shatur I've started working on porting this PR to Goost in Godot 3.x as we've discussed at Godot contributors chat, see goostengine/goost#123.
I'm writing test cases in GDScript and noticed that the following test case:
func test_parse():
    var args = ["--input path"]

    var input = CommandLineOption.new()
    input.names = ["input", "i"]

    parser.add_option(input)
    var err = parser.parse(args)
    if err:
        print(parser.get_error_text())
    assert_eq(err, OK)

    var i = parser.find_option("input")
    assert_eq(input, i)

    assert_eq(parser.get_value(i), "path")

fails and prints:
res://goost/core/test_command_line_parser.gd
* test_parse
'--input path' is not a valid option.
Maybe you wanted to use: '--input'.
    [Failed]:  [30] expected to equal [0]:
      at line -1
    [Failed]:  [""] expected to equal ["path"]:
      at line -1
* test_builtin_options

According to documentation, both = and   (space) are supported. Is it a bug or am I missing something?

I wonder what could be done to avoid this mistake

I have no idea :) In theory we could have two methods, one for a single string, second for a list of strings.

I have no idea :) In theory we could have two methods, one for a single string, second for a list of strings.

I think parse method could take Variant over PackedStringArray, and cast variant to either String or PackedStringArray, depending on Variant.get_type().

I think parse method could take Variant over PackedStringArray

I think it can confuse users a little :)

Note: looks like prefix precedence in long_prefixes/short_prefixes matters:
func test_get_prefix_precedence():
    var debug = CommandLineOption.new()
    debug.arg_count = 0
    parser.add_option(debug)

    parser.long_prefixes = ["--no-", "--"]

    assert_eq(parser.parse_args(["--debug"]), OK)
    assert_true(parser.is_set(debug))
    assert_eq(parser.get_prefix(debug), "--")

    assert_eq(parser.parse_args(["--no-debug"]), OK)
    assert_true(parser.is_set(debug))
    assert_eq(parser.get_prefix(debug), "--no-")

    parser.long_prefixes = ["--", "--no-"] # Swap precedence.

    assert_eq(parser.parse_args(["--debug"]), OK)
    assert_true(parser.is_set(debug))
    assert_eq(parser.get_prefix(debug), "--")

    assert_eq(parser.parse_args(["--no-debug"]), ERR_PARSE_ERROR,
            "Precedence of `--` prefix is higher than `--no-`, should fail.")
    assert_false(parser.is_set(debug))

The above test case works, but I wonder if that's expected. Should this rely on precedence of prefixes?

The above test case works, but I wonder if that's expected. Should this rely on precedence of prefixes?

No, I think it can be fixed. We should check for each prefix before return the error.

I think parsing should fail immediately if default argument is not allowed according to allowed_args.

Agree, we should have a check for it.

I think parsing should fail immediately if default argument is not allowed according to allowed_args.

Agree, we should have a check for it.

Fixed in 2eeadba (#123).

The above test case works, but I wonder if that's expected. Should this rely on precedence of prefixes?

No, I think it can be fixed. We should check for each prefix before return the error.

Fixed in 9340536 (#123).

Found a test case which crashes the engine, see goostengine/goost#125 for reproduction and solution.

Found a test case which crashes the engine, see goostengine/goost#125 for reproduction and solution.

Nice catch!


Fix i18n lookup for unauthorized message

Fixes #415 without relying on specific i18n version.
Inspired by https://github.com/plataformatec/simple_form/blob/master/lib/simple_form/inputs/base.rb#L173-L189.

Thank you @clemens, I think we need a test here to proove that the issue is really solved, so a test that would actually fail without your changes and passes with them. Thanks for your contribution! Really appreciated.

What do you have in mind for that test? A mock that expects a call with a certain key? Otherwise we'd have to test against a specific version of i18n – which seems questionable.


Format JSON errors from fftokens

Parse a JSON error of the form:
  {"error": "Bad Request", "message": "Field 'x' is required"}
into a message of the form:
  "Bad Request: Field 'x' is required"

Codecov Report

Merging #748 (8d47766) into main (41a5a15) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##              main      #748   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files          323       323
  Lines        20084     20095   +11
=========================================
+ Hits         20084     20095   +11

Impacted Files
Coverage Δ

internal/tokens/fftokens/fftokens.go
100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 41a5a15...8d47766. Read the comment docs.

Seems like maybe the ethconnect and fabconnect plugins should get similar treatment in order to parse the expected error formats from there as well.

Added formatting for ethconnect and fabconnect errors. Tested via unit test and manual test on a real stack to ensure that errors which match the expected formatting and errors which don't match it will both show up in a suitable manner.


Added Donate in Pages and code complete donate page as per the projec…

Added Donate in Pages and code complete donate page as per the project folder structure.
Added separate CSS and TSX files.

Can you add the hacktoberfest tag to the issue? I can not see this in my profile.


TOS Typo

Corporate TOS issue: “If you're posting anything you or your Users did not create yourselves and on your behalf, you agrees that…” Fix typo.

Yikes! Thanks, @MarcM001. We'll take a look!

@MarcM001 Thanks for your contribution! That typo has been fixed in the draft update.

On Fri, Jul 28, 2017 at 02:01:41PM -0700, Joe Mazzella wrote:

That typo has been fixed in the draft update.

Cross-linking #2, which is the PR for that
github-corporate-tos-update-july-2017 branch.


Change the method to load "socket_io_js"

Change the method to load "socket_io_js" from static NSString to
Loading resource js file

Can I know a little more about the thinking behind this? :)


BackHandler working only in remote debugging mode?

When I enable debug mode. it is ok, but I disabled debug mode. it is not working
how to use it.
many thanks

hi there, it's hard to say what's going on without a repro. There are differences in the runtime between a phone and remote debugger though.

Closing as there is no repro.


Intellisense inserts useless import on globals

Does this issue occur when all extensions are disabled?: Yes

VS Code Version: 1.59
OS Version: Windows 10 21H1

Steps to Reproduce:

Open any typescript or javascript project.
Install globalthis into it.
Type in an object (or also a type, in typescript) that is available globally, like Array, DocumentFragment, window, Math, etc. Literally any global will do, but I'll use just one as an example hereafter.
Observe intellisense helping you complete DocumentFrag into DocumentFragment:

(on a sidenote: why two?)
Select that one in intellisense and hit enter to confirm.

Expected:
DocumentFragment is inserted into the document and that's it.
Actual:
DocumentFragment is inserted into the document and this is inserted at the top:
import { DocumentFragment } from "globalthis/implementation";

This is a useless and incorrect import. Globalthis doesn't work like that, and the package contains no instruction for VScode to do this, as far as I can tell. It is meant purely as a polyfill/shim, which shouldn't affect development in any way.

(Experimental duplicate detection)
Thanks for submitting this issue. Please also check if it is already covered by an existing one, like:
* [typescript intellisense import is not supported in <script lang="ts"> block (#126770)](https://www.github.com/microsoft/vscode/issues/126770)

Bad bot. That's totally different.

Does this reproduce in the latest VS Code insiders build with all extensions disabled?
/needsMoreInfo

@mjbvz

Does this reproduce in the latest VS Code insiders build with all extensions disabled?

It doesn't appear to happen on Insiders with extensions disabled. I even took the effort to copy all my settings over.
Does this indicate the problem has been fixed? If so there should be at least a pre-existing issue for it, which I couldn't find. Perhaps under a different kind of title...

Closing as likely fixed by the new TS version in insiders based on the feedback


Implements AWS SigV4 for the HTTP output plugin.

Which issue(s) this PR fixes:
Fixes #4444
What this PR does / why we need it:
This PR adds a new authentication method to the HTTP output plugin for AWS sigV4. We need it so that customers can use Fluentd to send data to Amazon OpenSearch Ingestion which supports the Fluentd output plugin, but requires SigV4 authentication.
Docs Changes:

aws_sigv4 - When this option is specified, Fluentd will sign requests using AWS Signature Version 4.

aws_service - The AWS service to authenticate against

aws_region - The AWS region to use when authenticating

aws_role_arn - The AWS role ARN to assume when authenticating

You can optionally specify an aws_role_arn. If you provide it, Fluentd will assume that AWS role and send requests signing from that role. Otherwise, Fluentd will use the credentials found by the credential provider chain as defined in the AWS documentation.
Release Note:
The http output plugin supports AWS Signature Version 4 authentication.

@dlvenable Thanks so much for this enhancement!
I am very happy that adding AWS SigV4 authentication will allow Fluentd to work with AWS services such as Prepper!

Thank you all for the useful feedback. I've pushed changes to address these comments.

@daipom , @cosmo0920 , I see that some tests are failing, but they don't appear to be related to http. Are these possibly flaky tests?
I'm very interested in getting this PR in to allow us to move forward. Thank you.

@daipom , @cosmo0920 , I see that some tests are failing, but they don't appear to be related to http. Are these possibly flaky tests?
I'm very interested in getting this PR in to allow us to move forward. Thank you.

These failed tests are flaky tests on macOS and Windows. They should be able to ignored for now.
@daipom @ashie Any ETA for getting merged this PR? In Fluent Bit side, SigV4 signature is set up in the almost HTTP related plugins. So, I wanted to equip the similar functionality as a parity for Fluent Bit.
And this PR should be prioritized to process.

@daipom @ashie Any ETA for getting merged this PR?

It's almost ready for merge.
We'll merge soon when we get @dlvenable's response about https://github.com/fluent/fluentd/pull/4459#discussion_r1552620586

Yes. I think we can merge this soon, at least once the concerns pointed out by @ashie are resolved.

Thanks for your contribution!

@dlvenable Thanks for your contribution!


Details page function migrate

Details

Fixed Issues

$ https://github.com/Expensify/App/issues/16230
PROPOSAL: https://github.com/Expensify/App/issues/16230#issuecomment-1582300963
Tests

Go to a report (Chat)
mention any user
click on the highlighted mention
Verify that the Details Screen appears to the right and all options are normal

[x] Verify that no errors appear in the JS console

Offline tests

QA Steps

Go to a report (Chat)
mention any user
click on the highlighted mention
Verify that the Details Screen appears to the right and all options are normal

[x] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android / native
[x] Android / Chrome
[x] iOS / native
[x] iOS / Safari
[x] MacOS / Chrome / Safari
[x] MacOS / Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[x] I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

https://github.com/Expensify/App/assets/77237602/0bee2313-2930-4856-82d2-663680e2053e

Mobile Web - Chrome

https://github.com/Expensify/App/assets/77237602/a89bef0d-cf63-41e3-b3de-f8d93a1a186c

Mobile Web - Safari

https://github.com/Expensify/App/assets/77237602/c444cb2c-18a8-4fae-84f8-880938af5327

Desktop

https://github.com/Expensify/App/assets/77237602/6d74b239-211c-4459-8d45-01ab32ad2e01

iOS

https://github.com/Expensify/App/assets/77237602/da41d87a-1681-4ae3-8d5e-8797c9c75f84

Android

https://github.com/Expensify/App/assets/77237602/5648deb3-7516-469b-a87d-d16124d147b1

Gentle Bump @0xmiroslav on review...

@0xmiroslav bump on review.. Had to fix another merge conflict.. Hope we can merge this before another one arises! 😅

@0xmiroslav I understand your concern but this is a very simple migration with no callback methods, useEffects or refs. I just had to remove the render method mainly. I think if we merge this even before the TODO is complete, there won't be a big difference in the code for another. But we can hold if you wish

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

🚀 Deployed to staging by https://github.com/grgia in version: 1.3.29-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to production by https://github.com/luacmartins in version: 1.3.29-11 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


Cannot set FPS for stylized video

I edit the config/prompts/prompt_travel.json file fps value (in the last section, 6th last line).
But when I run
animatediff stylize create-config movie.mp4
the stats show fps: 8 always.
17:03:35 INFO     org_movie=WindowsPath('D:/F13 eyeball 1080p.mp4')                                                                                stylize.py:164
         INFO     config_org=WindowsPath('config/prompts/prompt_travel.json')                                                                                stylize.py:165
         INFO     ignore_list=WindowsPath('config/prompts/ignore_tokens.txt')                                                                                stylize.py:166
         INFO     out_dir=WindowsPath('stylize')                                                                                stylize.py:167
         INFO     fps=8

How do I set another fps value for stylize?
The hint text says
Changing the 'fps' at this timing is not recommended as it will change the playback speed.                                                                                stylize.py:317
                  If you want to change the fps, specify it with the create-config option

Where do I change the "create-config option"?
If I feed in a 25 fps movie for styling I want a 25 fps stylized movie to be output with all the movie frames included.
Thanks for any tips.

animatediff stylize create-config -h

Thanks for the quick reply.  Passing --fps to animatediff stylize create-config did the trick.


1.18

Any plans for 1.18?

There are, I'm working on upgrading the api to make it better first though.

That took longer than expected but it should be done now! There was some merging conflicts (i forgot to merge before updating ;/) so if you find a bug feel free to open another issue.

Thanks!

...

...

... ?

...

... ?

i think they're referencing the fact that you've only updated the mod on curseforge. it would be nice to see an updated version on github and modrinth

Modrinth gets updates before curseforge and github is too much hassle to post versions on


Support keyring for passwords.

There is a great password keyring interface that supports Linux, OS X, and Windows password vaults.
https://pypi.python.org/pypi/keyring
Please consider adding keyring for getting passwords securely.

This one I don't "get" just yet - something more than along these lines which you can already do:
nr = numerous.Numerous(apiKey=keyring.get_password(blah))

?

Nope, i just didn't see that tree in the forest.
I saw all of the other password entry options and didn't think about apiKey=keyring.get_password(blah)
I would suggest that the docs promote keyring as an option.

FYI reworked https://github.com/outofmbufs/Nappy/wiki/APIKey-Management accordingly.

That's great!

On Oct 23, 2015, at 6:19 AM, Neil Webber<EMAIL_ADDRESS>wrote:
FYI reworked https://github.com/outofmbufs/Nappy/wiki/APIKey-Management accordingly.
—
Reply to this email directly or view it on GitHub.


All crop pages on staging are giving 500 errors.

Fixed! This had to do with that data loss bonsai reported I think. We had to run guide.reindex in the console.


Bad Graphics

Mushrooms make everything brighter and brighter until everything is black and white, and peyote doesn't do anything.
Running on OS X Yosemite with the latest version of Java as of September 9 2015. I'll post a screenshot of my About This Mac page.

Hey,
you're doing two things here - firstly, you're taking too many drugs, to a point of overdosing, and secondly you aren't realizing drug effects are randomized. Try again and your results will differ.
~Ivorius

Am 09.09.2015 um 21:32 schrieb FireHunterX<EMAIL_ADDRESS>Mushrooms make everything brighter and brighter until everything is black and white, and peyote doesn't do anything.
Running on OS X Yosemite with the latest version of Java as of September 9 2015. I'll post a screenshot of my About This Mac page.
https://cloud.githubusercontent.com/assets/14205258/9772028/c75a23e8-5707-11e5-9240-c3cb005c1592.png
https://cloud.githubusercontent.com/assets/14205258/9772031/c7633280-5707-11e5-9bb3-ce58361ad87c.png
https://cloud.githubusercontent.com/assets/14205258/9772029/c7622156-5707-11e5-86ce-49a7b71b5607.png
https://cloud.githubusercontent.com/assets/14205258/9772030/c7627f3e-5707-11e5-8f48-8b661b0dc2cc.png
https://cloud.githubusercontent.com/assets/14205258/9772032/c7648cb6-5707-11e5-828c-3c58bed06e67.png
https://cloud.githubusercontent.com/assets/14205258/9772061/f054762c-5707-11e5-8da0-81342983c3f3.png
https://cloud.githubusercontent.com/assets/14205258/9772066/fa66b60c-5707-11e5-8d61-6457f92fc290.png
—
Reply to this email directly or view it on GitHub https://github.com/Ivorforce/Psychedelicraft/issues/17.

Oh, so it's intended to do that? Even with 1? I just figured it was the graphics card not being supported.

It's intended to do something - as I said, ranomized. The fact that it was so strong was probably because you took two drugs right after another, thinking one was ineffective.

Am 09.09.2015 um 21:42 schrieb FireHunterX<EMAIL_ADDRESS>Oh, so it's intended to do that? Even with 1? I just figured it was the graphics card not being supported.
—
Reply to this email directly or view it on GitHub https://github.com/Ivorforce/Psychedelicraft/issues/17#issuecomment-139025008.

I made that mistake before XD

There is also an interaction issue with the Inventory Tweaks thing that automatically refills your hot bar with the same item (I think), but it makes it so that if you try to eat just one, it will eat two.
Example: If you are being really careful and hold down right mouse just long enough to hear the "chomp chomp chomp" sound of eating just once, and the number just goes down by one, but then a few seconds later the number will drop down one more, as it has somehow eaten two.
I kinda think it would be good if the intensity of the drugs (especially mushrooms) was reduced by half or more.  I interpret the closed eye visuals (I assume that's what you were going for, where everything is washed out solid colors) are sortof a punishment for taking too much (because you are blind and your screen is just white with nothing cool to look at).  But they always take over after eating just two of something.  It would be nice if it took like 10 to get to that point.  And people had to work harder to dry more drugs to get the effects that a single one gives you.  Because the melty-drifty effects of a single one are awesome.

10 is far too much - I intended one item of mushrooms to be equal to one 'normal' dose.
I think currently you arrive at 1 if you eat about 3 of them, which I think makes sense for most cases.


don't fire type checks on blockly theme changes

fixes https://github.com/microsoft/pxt-minecraft/issues/2557
minecraft is our only editor that actually customizes the blockly theme. setting the theme was causing blockly to fire an event which in turn triggered a type check on the home screen. that type check fails because there is no project open when you're on the home screen

Thanks!


Add birdnetR

Insert URLs to the project here: https://github.com/birdnet-team/birdnetR

[x] The projects is active, documented, open source licensed, shows usage from external parties and is directly targeting environmental sustainability. Find more details in the Contribution Guide.

All issues labeled as Good First Issue of the project listed on OpenSustain.tech will be visible on ClimateTriage.com. This is a great way to welcome new community members to your project.
All new projects listed will be posted on our Mastodon channel.

@fegue @SunnyTseng @kahst

@Ly0n Thanks for including birdnetR 😀
I didn't know about this repository, very cool!!


Validation message doesn't show after update angular from 6 to 9

Hi, I have an application in wich I implemented a few custom fields, that extends from FieldType. I have custom validators too. I was using angular 6 and ngx-formly 4.8.3. All was working fine. After upgrade to angular 9 and ngx-formly 5.10.6, the validation message dissapears, the controls are invalid but the message doesn't appear.
I have validationMessges defined in the module
FormlyModule.forRoot({       validationMessages: mensajesValidaciones, .... export const mensajesValidaciones = [   { name: 'required', message: requiredMessage },   { name: 'min', message: minMessage },   { name: 'max', message: maxMessage },   { name: 'minLength', message: minLengthMessage },   { name: 'maxLength', message: maxLengthMessage } ];
I don't know if there are some lib, that have conflict with the new version of ngx-formly. my package.json is:
"dependencies": {     "@angular/animations": "^9.1.12",     "@angular/cdk": "^9.2.4",     "@angular/common": "^9.1.12",     "@angular/compiler": "^9.1.12",     "@angular/core": "^9.1.12",     "@angular/forms": "^9.1.12",     "@angular/localize": "^9.1.12",     "@angular/material": "^9.2.4",     "@angular/platform-browser": "^9.1.12",     "@angular/platform-browser-dynamic": "^9.1.12",     "@angular/router": "^9.1.12",     "@auth0/angular-jwt": "^2.1.0",     "@babel/polyfill": "^7.8.7",     "@fortawesome/angular-fontawesome": "^0.6.1",     "@fortawesome/fontawesome-free": "^5.15.1",     "@fortawesome/fontawesome-svg-core": "^1.2.28",     "@ng-select/ng-select": "^4.0.0",     "@ngx-formly/bootstrap": "^5.10.6",     "@ngx-formly/core": "^5.10.6",     "@swimlane/ngx-datatable": "^15.0.0",     "@types/go": "^1.6.20",     "@usig-gcba/autocompleter": "^2.0.6",     "angular2-text-mask": "^9.0.0",     "bootstrap": "^4.3.1",     "core-js": "^3.1.3",     "file-saver": "^1.3.8",     "flatpickr": "^4.6.2",     "font-awesome": "^4.7.0",     "gojs": "^2.1.30",     "jquery": "^3.3.1",     "lodash": "^4.17.20",     "moment": "^2.24.0",     "ngx-bootstrap": "^5.6.1",     "ngx-captcha": "^8.0.1",     "ngx-chips": "^2.2.2",     "ngx-clipboard": "^12.3.0",     "ngx-editor-vs": "^4.1.1",     "primeng": "^5.2.0-rc.2",     "rxjs": "~6.6.3",     "rxjs-compat": "^6.2.1",     "tslib": "^1.10.0",     "zone.js": "~0.10.2"   },   "devDependencies": {     "@angular-devkit/build-angular": "~0.901.12",     "@angular/cli": "~9.1.12",     "@angular/compiler-cli": "^9.1.12",     "@angular/language-service": "^9.1.12",     "@types/jasmine": "^2.8.16",     "@types/jasminewd2": "^2.0.6",     "@types/lodash": "^4.14.165",     "@types/node": "^12.11.1",     "codelyzer": "^5.1.2",     "jasmine-core": "~2.99.1",     "jasmine-spec-reporter": "~4.2.1",     "karma": "~1.7.1",     "karma-chrome-launcher": "~2.2.0",     "karma-coverage-istanbul-reporter": "^2.0.5",     "karma-jasmine": "~1.1.1",     "karma-jasmine-html-reporter": "^0.2.2",         "protractor": "~5.3.0",     "ts-node": "~5.0.1",     "tslint": "~5.9.1",     "typescript": "3.8.3"   }
Any ideas?

Hi, can you provide a reproduction example https://stackblitz.com/edit/ngx-formly-ui-bootstrap
Thanks!


Falsk url redirect with Masking

Is there a way to redirect url in flask app and mask the url?
@app.route("/test")
def handle_ext_url():
    url = "https://www.google.com"
    return redirect(url)

I just want my addressbar to show localhost:8080/test but the page should show google.com.

I think you want to embed google.com into your iframe.
The above code just redirect the browser to google.com, not embed it.

I think you want to embed google.com into your iframe.
The above code just redirect the browser to google.com, not embed it.

awful idea, don't do that. nobody likes frames nowadays.
also completely out of the scope of this issue tracker or flask in general.

awful idea, don't do that. nobody likes frames nowadays.
also completely out of the scope of this issue tracker or flask in general.

@nhdinh @ThiefMaster
I do not want to use iframe, I just want to mask my address bar to my flask app host port and show web content of redirected url.
Similar to what we do in the masked domain forward.

@nhdinh @ThiefMaster
I do not want to use iframe, I just want to mask my address bar to my flask app host port and show web content of redirected url.
Similar to what we do in the masked domain forward.

@nhdinh @ThiefMaster
I do not want to use iframe, I just want to mask my address bar to my flask app host port and show web content of redirected url.
Similar to what we do in the masked domain forward.

Got it. I think this issue is out of Flask scope.

@nhdinh @ThiefMaster
I do not want to use iframe, I just want to mask my address bar to my flask app host port and show web content of redirected url.
Similar to what we do in the masked domain forward.

Got it. I think this issue is out of Flask scope.

"I just want to compromise browser security by hiding one site behind another URL." Stop trying to make what sounds like an email scam. Focus on more important and legitimate things, like the functionality of your site.

"I just want to compromise browser security by hiding one site behind another URL." Stop trying to make what sounds like an email scam. Focus on more important and legitimate things, like the functionality of your site.


Release notes diff from last minor version

Hello,
I just read your last release note for 4.11.0. I was wondering why do you list the full changelog since 4.10.0 (I guess) and not from 4.10.14.
You probably do this because there wil be more 4.10.x minor versions.
Could you highlight the changes from the last minor version at this date ? It's easier to follow ;-)

@joeyparrish can you review it? Please!

I just read your last release note for 4.11.0. I was wondering why do you list the full changelog since 4.10.0 (I guess) and not from 4.10.14.

It is because the changelog is entirely automated, and based on the branch history.  .0 releases are all released from main, and therefore the release tooling sees all the changes between 4.11.0 and 4.10.0 as being "in" this release.

Could you highlight the changes from the last minor version at this date ? It's easier to follow ;-)

We used to maintain the changelog by hand, and when we did it that way, we would only include changes unique to that feature release.  However, it was just too much work, and we frequently made mistakes.  We omitted things that mattered, we added things accidentally that were reverted, etc.
For us to show only non-cherry-picked changes in the feature release, we would need that functionality in the release tools, which are here:

https://github.com/shaka-project/shaka-player/blob/6716ff00c411df5b284d0b705c0d7cd6ef2ec76e/.github/workflows/release-please.yaml#L18-L27
https://github.com/google-github-actions/release-please-action
https://github.com/googleapis/release-please

I've contributed changes to these tools before, so I know they are maintained and that the maintainers are reasonable.  This sounds like it could be a large change, though, so it might be necessary to form a rough plan and get the agreement of the maintainers before spending too much effort on a PR.
If you would like to lead that process, please link to a release-please discussion here so that others can pitch in and follow along.
Does this answer your question?

Thanks for the detailed answer !
It's not something critical, it's more like a comfort thing. I didn't knew it was automated.
I was taking Google's Media3 repository as an example, but they fill it manually, you can see for each version release the previous version it references: https://github.com/androidx/media/blob/release/RELEASENOTES.md
1.4.1 -> 1.4.0
1.4.0 -> 1.3.1 (last 1.3.x version known to this release date)
(potential 1.3.2 could logically reference 1.3.1)


Cannot find mavericks-compose artifact

The documentation states the following:
"To use Mavericks with Jetpack Compose, add the com.airbnb.android:mavericks-compose artifact (TBD on versioning)."
Yet I cannot find the corresponding artifact on MavenCentral. Any idea why? I searched the following: https://mvnrepository.com/artifact/com.airbnb.android

It will be released today :)


Request from GO regarding has_participant

@ukemi said:

This morning while working on the cell wall metabolism areas of GO I noticed that we have two has participant relations. One, 'has participant', is the one we have traditionally used and the other, has_participant, directly refers to a BFO term and comes in via the PO import. Of course I used the non-traditional one at first for all my edits and the obo file looked weird.
Is this problematic and should we somehow filter the one used in PO?

@balhoff replied:

My guess is that this is an accident of history in PO, and we could probably get them to replace the IRI with the RO one. They both have the same numeric ID.

https://github.com/geneontology/go-ontology/issues/16602

PO PR: #688


'Single quotes' are being encoded in URL

Expected Behavior
As per https://datatracker.ietf.org/doc/html/rfc3986#section-2.2, single quotes are delimiter characters so they should not be encoded. This is even hinted at in the comment here: https://github.com/Kong/insomnia/blob/develop/packages/insomnia-url/src/querystring.ts#L11. I wonder what the cause for excluding this character was.
Actual Behavior
Single quotes encoded to %27
Reproduction Steps
No response
Is there an existing issue for this?

[X] I have searched the issue tracker for this problem.

Additional Information
No response
Insomnia Version
2022.2.1
What operating system are you using?
Ubuntu
Operating System Version
Ubuntu 21.10
Installation method
AppImage
Last Known Working Insomnia version
No response

Hi @dimitropoulos, thanks for looking into the issue. That sounds like a reasonable way to keep everyone happy, although I personally do not believe there to be many APIs that would be designed with non-standards compliant behaviour in mind. The suggested fix to allow it to be configurable is nevertheless absolutely welcome - with the "correct" behaviour set as default perhaps?


Crash in modifySubscription function

Multiple Crash occurrences in: **NativePusher.swift** file
Any improvements you suggest: Guard the scenario when clientID is nil by guard let or if let. Also, guard let or if let if the URL is valid URL instead of forcefully unwrapping
CC @pusher/mobile

This line is generating multiple crashes. Is it because the clientID is forcefully unwrapped?

I feel like it must be some concurrency thing that hasn't been considered because this line: https://github.com/pusher/pusher-websocket-swift/blob/master/Source/NativePusher.swift#L199 suggests that there is already a nil check for the clientId

which concurrency thing, can you please elaborate?

Also it could be the line
URLRequest(url: URL(string: url)!)
A valid Url might not be getting generated


Support unix sockets

Hello,
Mint natively supports making requests on unix sockets by setting the address to {:local, "/path/to/socket.sock"} and the port number to 0, for example:
{:ok, conn} = Mint.HTTP.connect(:http, {:local, "/var/run/docker.sock"}, 0, hostname: "localhost")

For more context, tests for this functionality in Mint can be found here.
However, to my knowledge Finch does not currently allow this.
In case this feature may be desirable, a possible approach could be to do as Hackney does, ie. supporting url schemas in the form of eg. "http+unix".

Hi and thanks for the issue! I agree that Finch should support this. I have not looked in to this very much yet, but rather than using a scheme like http+unix, I think we should use the {:local, socket_path} tuple that Mint uses, which is the type from inet https://erlang.org/doc/man/inet.html#type-local_address.

Hi @sneako , thanks for your quick reply!
Personally I don't have a strong opinion about which approach to use, but I'm afraid that using the local_address() type from inet would not fit well with the current API exposed by Finch, which (if I understand correctly) currently expects a URI or a string that can be parsed to a URI.
Anyway, once the preferred approach is defined I would be happy to implement it and send a PR, if that's OK for you :)

Hi @dallagi, sorry for the delay in getting back to you. I have been thinking about this a bit in the meantime, and have come to the conclusion that my initial proposal of using the local_address type would probably not be sufficient. I have not personally used TLS over a unix socket, however based on my limited research it does seem to be entirely possible. There is no way to specify that you would like to use TLS in the local_address tuple that I had proposed, therefore your proposal of http+unix or https+unix does seem like it could be the best way forward.

Hi @sneako,
No worries at all for the delay, I appreciate the effort you’re putting in maintaining finch :)
Thanks for the heads up about the potential issues!
I agree that having to url encode the path of the socket is not very convenient.
However, personally I can’t think of a better alternative.
Passing a custom tuple (similarly as the PR you linked) would work, but I’m afraid it would also feel a little out of place in finch, since until now the URI was always passed as a String or `URI.

out of curiosity, what would be an actual example call to Finch.build/4 that you propose? Please use as real values as possible and if we need to URI encode things, please do that as well. I think showing concrete examples will help move the discussion forward.

Hi @wojtekmach you are absolutely right, I’ll try to come up with some practical examples.
Let’s say we want to hit the _ping api exposed by a local docker daemon listening on /var/run/docker.sock.
Using an approach similar to hackney’s it would look like this:
Finch.build(:get, "http+unix://%2Fvar%2Frun%2Fdocker.sock/v1.41/_ping")

Otherwise, another option could be to go with a tuple, which for example could look like this:
Finch.build(:get, {"http", "/var/run/docker.sock", "/v1.41/_ping"})

Headers and body would keep working same way as now.
To be clear I don't have a strong preference, as IMHO none of them is inherently better than the other, and of course there may also be some better option I didn't consider.

I thinked a bit more about this.
If I had to pick one to these two approaches myself I’d probably go with the former, ie. hackney’s approach.
This would allow Finch to keep the API of build/4 consistent (as the url would keep being either a URI or a URI-like String) at the cost of a little more complexity for users due to urlencoding, which IMHO could be an acceptable compromise given that unix sockets are supposedly a rather niche use case.
However, the simplest approach may actually be to skip the build/4 step altogether (for now at least), and let users who want to run request on a unix socket build the Request directly.
This may look something like this:
%Finch.Request{scheme: :"http+unix", host: "/var/run/docker.sock", port: 0, method: "GET", path: "/v1.41/_ping", headers: [], body: nil, query: nil}

Overall, in my opinion this last approach could be a good way to start, as it would allow Finch to add support for unix sockets without changing its user-facing API, while still keeping the possibility to update the build/4 function at a later time if necessary.

In curl, setting the unix socket is just another option instead of messing with the url:
$ curl --unix-socket /var/run/docker.sock http://localhost/v1.41/_ping
OK

(setting the url to http:///v1.41/_ping or even just http://v1.41/_ping also works, more on this below.)
I think this is relevant here. Here's an idea how we could support this in Finch:
{:ok, _} =
  Finch.start_link(
    name: MyFinch,
    pools: %{
      {:local, "/var/run/docker.sock"} => [size: 10]
    }
  )

Finch.build(:get, "http://localhost/v1.41/_ping", unix_socket: "/var/run/docker.sock")
|> Finch.request()

Note, in our pool map we use the path to the socket, not the host. I believe the host is mostly or totally irrelevant. For example, It is ignored by the docker server:
$ curl --unix-socket /var/run/docker.sock http://bad.host/v1.41/_ping
OK

Btw, given at least for Docker, the host is irrelevant, we can also use empty host like this:
iex> URI.parse("http:///v1.41/_ping") |> Map.take([:host, :path, :scheme])
%{host: "", path: "/v1.41/_ping", scheme: "http"}

iex> :uri_string.parse("http:///v1.41/_ping")
%{host: "", path: "/v1.41/_ping", scheme: "http"}

WDYT?

I like @wojtekmach's proposal of using a new :unix_socket option rather than some kind of hybrid scheme. We could add a :unix_socket field to the Request struct and from there it should be quite straightforward.

I have a similar use case that requires communicating with a UNIX socket.
I would like to do a PR to add support to this, is @wojtekmach's solution the chosen approach?


Nami fails to transfer native tokens between accounts: BabbageOutputTooSmallUtxo

I have a Nami wallet with several accounts holding tokens in the testnet. At least since Monday, there have been issues when trying to transfer native tokens (tAda works without issues) to other accounts in my same wallet. When submitting, Nami receives a 400 error from Blockfrost with the following response:
{"error":"Bad Request","message":"\"transaction submit error ShelleyTxValidationError ShelleyBasedEraBabbage (ApplyTxError [UtxowFailure (UtxoFailure (BabbageOutputTooSmallUTxO [((Addr Testnet (KeyHashObj (KeyHash \\\"615e88e55cc1a7be9aa69264476fb83c27a38fe78f56f98aa1cdb4d4\\\")) (StakeRefBase (KeyHashObj (KeyHash \\\"c2f2a14030c9b90cc292022b1a85cfe53fabb3b3f54f4a0d2cba76d2\\\"))),Value 189640 (fromList [(PolicyID {policyID = ScriptHash \\\"6f1a1f0c7ccf632cc9ff4b79687ed13ffe5b624cce288b364ebdce50\\\"},fromList [(41474958,799999992713)]),(PolicyID {policyID = ScriptHash \\\"b5094f93ff9fcba9e8b257197d589cbcde3d92a108804e3a378bd2ce\\\"},fromList [(4e5458,1000000000000)])]),NoDatum,SNothing),Coin 1361960)]))])\"","status_code":400}

Increasing the amount of tAda to transfer does not fix the problem.
This (fixed) issue might be related: https://github.com/input-output-hk/cardano-node/issues/3913

@rmgaray Talk to Cardano Support on the Live support page so that your issue can be looked into.

@rmgaray Talk to Cardano Support on the Live support page so that your issue can be looked into.

This is a phishing link, please ignore

I am facing the same issue. This was working fine last week.
Unexpected error in listAsset. [Message: "transaction submit error ShelleyTxValidationError ShelleyBasedEraBabbage (ApplyTxError [UtxowFailure (UtxoFailure (BabbageOutputTooSmallUTxO [((Addr Testnet (KeyHashObj (KeyHash \"8508f4bc3dbf739b7f93411050128c5b830955575193e4b6076f83dc\")) (StakeRefBase (KeyHashObj (KeyHash \"0c46bbdab11b31a7426411db71c483420d1264dbedce4d455b5b55bb\"))),Value 4195879 (fromList [(PolicyID {policyID = ScriptHash \"1dd52e9d4238e1c6b7a1fe72cedf50ee12701749065cb58d6d8cbc04\"},fromList [(426974654d61726b45766964656e6365323435393232,1),(426c6f6f6453706c61747465723433313835,1),(426c6f6f6453706c61747465723435353136,1),(4368616c6b4f75746c696e653930353932,1),(4368616c6b4f75746c696e653934313638,1),(4372696d65546170653334,1),(4372696d655461706535323334,1),(43726f77626172313936393133,1),(45766964656e6365426f617264323238383030,1),(45766964656e6365426f617264323439353839,1),(46696e6765725072696e74313236323534,1),(466c6173686c69676874313739313634,1),(466f6f745072696e74313430323530,1),(476c617373657326506c616964536f636b73323337353030,1),(48616e646375666673313934353739,1),(48616e6463756666733835313932,1),(48616e6463756666733837393035,1),(486561727365313736323838,1),(4963655069636b323130373936,1),(4963655069636b323131313930,1),(4a75727953756d6d6f6e733733353532,1),(506f6c6963654261646765313334313637,1),(506f6c6963654861743330373939,1),(506f6c6963654861743331353636,1),(506f6c6963654861743331383435,1),(506f6c6963655363616e6e65723231383936,1),(526f7065313033303539,1),(526f7065313037333238,1),(5365616c656445766964656e63654261673131313031,1),(5365616c656445766964656e6365426167313235323839,1),(53706163654e6565646c65323735383539,1),(54697265547261636b73313533353037,1),(54697265547261636b73313533363435,1),(56696e746167654d6167617a696e65323236393535,1),(56696e746167654d6167617a696e65323438313230,1),(57656c636f6d65546f466c6f72696461323534363332,1),(57656c636f6d65746f55544148323231363831,1),(57656c636f6d65746f55544148323232313337,1),(57656c636f6d65746f55544148323233373838,1)]),(PolicyID {policyID = ScriptHash \"ca622f7887d7bf8af94c00fbdc83641511d0b6c1b61e8811cdbce003\"},fromList [(4d6f6e64617954657374,850)])]),NoDatum,SNothing),Coin 4443610)]))])"]

nami is a single address wallet, if u scroll through the issues everyone been posting, it has been facing troubles to recognize assets and reimporting, im unfortunately one of them, my advice get used to eternl wallet or yoroi. The moment u reimport nami wallet u will be in deep trouble


Add missing @using BlazorWorker.Core to example .razor view

Knitpicking but was obviously missing :)

Thanks


Revert "Merge pull request #15646 from tienifr/fix/15438-maintain-whi…

…te-space-in-display-name"
This reverts commit 5a0c876fabbccf8279eb5483c92997f565633267, reversing changes made to 80ad4132102d03798abc4ac1c0d08696a507db36.
Details
Reverts https://github.com/Expensify/App/pull/15646 to solve deploy blockers
Fixed Issues
$ https://github.com/Expensify/App/issues/16376
$ https://github.com/Expensify/App/issues/16371
PROPOSAL: N/a
Tests

Create a new group chat with 8 users
Verify the names in the header do not overflow

[ ] Verify that no errors appear in the JS console

Offline tests
Same as tests
QA Steps

Create a new group chat with 8 users
Verify the names in the header do not overflow

[ ] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android / native
[x] Android / Chrome
[x] iOS / native
[x] iOS / Safari
[x] MacOS / Chrome / Safari
[x] MacOS / Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is correct English and approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)

[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[x] I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Mobile Web - Chrome

Mobile Web - Safari

Desktop

iOS

Android

@marcaaron @parasharrajat One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

Threw a hold since @tienifr put up a PR that might fix the regression rather than reverting https://github.com/Expensify/App/pull/16397

https://github.com/Expensify/App/pull/16397 does indeed solve the issue, closing this out


RA reports syntax error on if inside let

fn main() {
    const A: bool = true;

    let b: i32 = {
        if A {
            4
        } else {
            10
        }
    };

    println!("{}", b);
}

this is valid rust code but rust analyzer reported several syntax errors

rust-analyzer f5a4a4b

The language server state got out of sync with the editor state. You can see this by the fact that semantic highlighting is highlighting parts of identifiers differently.

@matthiaskrgr have you seen this lately?

If it's a synchronization issue, this is pretty much untestable (and unactionable) without a LSP trace taken from the beginning.


Change time code param value limit

The docs mention 32 as time code limit, but according to my tests, the API throws ArgumentException for any value above 15 (which also matches the logic mentioned at http://www.4front-tech.com/pguide/midi/midi9.html. It seems then, that the documentation should be changed to limit this parameter to 15.

@MartinZikmund : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@MartinZikmund : Thanks for your contribution! The author(s) have been notified to review your proposed change.


fix: have requestedassignment respect rack

Proposed fix for #190 .
The change works by, in the case where all brokers are all assigned a rack, it orders the brokers used by the requestedassignment function in what KIP-36 calls a rack alternated broker list.. This list is used by the existing algorithm to create the partition assignments.  If not all brokers have rack information, there's no change to existing behaviour.
This will be applied to both initial assignment and any subsequent reassignment.  If broker pods move between racks for any reason, then the existing partitions will be subject to re-assignment by the existing alterAssignments mechanism

The PR currently has contains a unit test which I believe demonstrates the issue.  I have an idea for a code change that should resolve the issue whilst keeping compatibility for clusters are not AZ based deployments.

In particular for example what the limitations are => does it handle only the initial creation? Or also any later updates when the racks change int he broker?

In particular for example what the limitations are => does it handle only the initial creation? Or also any later updates when the racks change int he broker?

I updated the PR's description.  I hope that answers your questions.

Thanks for the PR.


Support for adding photos.

The adapter should always be last according to the Faraday docs.

Any chance you can add tests for this?  If not I will try to get to it at some point this week, but don't want to merge anything in without having some tests on it.

foursquare2 doesn't have tests for any POST action from what I can see. I'm afraid I have to work on something else now.