Feature/mizuki refactoring consensus

What is this pull request?
A little fix & pass
Why do you implement it? Why do we need this pull request?
To pass CI
How to use the features provided in the pull request?
Do you provide tests, or use case examples?
Describe how to use features in your pull request.
Details/Features
List of features / major commits

Remove set_test
using Transaction = protocol::Transaction

Closing this PR, since code in feature/consensus was replaced by force push


Make tuple annotation more specific

This PR makes the syntax for creating tuples more specific, where before it was ambiguous is some cases. There are now 4 concrete scenarios:
For example, this Sway code passes:
script;

use std::assert::assert;

struct S {
    t: (u64,)
}

fn main() -> u64 {
    let a = S {
        t: (2,)
    };
    let b = match a {
        S { t } => t,
    };
    assert(b.0 == 2);

    1
}

And this Sway code passes:
script;

use std::assert::assert;

struct S {
    t: (u64)
}

fn main() -> u64 {
    let a = S {
        t: (2)
    };
    let b = match a {
        S { t } => t,
    };
    assert(b == 2);

    1
}

But this Sway code fails:
script;

use std::assert::assert;

struct S {
    t: (u64,)
}

fn main() -> u64 {
    let a = S {
        t: (2)
    };
    let b = match a {
        S { t } => t,
    };
    assert(b == 2);

    1
}

  --> tuple_single_element/src/main.sw:11:13
   |
 9 |
10 |     let a = S {
11 |         t: (2)
   |             ^ Mismatched types.
expected: (u64)
found:    numeric.
help: Struct field's type must match up with the type specified in its declaration.
12 |     };
13 |     let b = match a {
   |
____

error
  --> tuple_single_element/src/main.sw:16:14
   |
14 |
15 |     };
16 |     assert(b == 2);
   |              ^^ No method named "eq" found for type "(u64)".
17 |
18 |     1
   |

And this Sway code fails:
script;

use std::assert::assert;

struct S {
    t: (u64)
}

fn main() -> u64 {
    let a = S {
        t: (2,)
    };
    let b = match a {
        S { t } => t,
    };
    assert(b == 2);

    1
}

  --> tuple_single_element/src/main.sw:11:12
   |
 9 |
10 |     let a = S {
11 |         t: (2,)
   |            ^^^^ Mismatched types.
expected: u64
found:    (u64).
help: Struct field's type must match up with the type specified in its declaration.
12 |     };
13 |     let b = match a {
   |

Closes #906

If I understand this correctly, this PR is a bug fix which makes the type (T) get parsed as T in parenthesis, rather than as the 1-element tuple (T,). Is that right? If so then :+1:


Net

https://github.com/desktop/desktop/actions/runs/6696629608/job/18194749390

Thank you for opening this issue, we will look into it.


colorMask - incorrect positioning

Generated div visually appears at the top of page, not under input — jsfiddle (see telephone field)
Also, generated div class is needed for further customization.

any update on it

I have the same problem with this otherwise excellent plugin. I suspect it has something to do with HTML order, unfortunately, I cannot seem to find the HTML in the DOM tree of my inspector to find out what is going on :-).

@satodavan , @madhurjya , @xavez ,
In the 4.x branch the colorMask is updated.  The positioning is more customizable through css and prototype fn.  See readme and have a try

@satodavan , @madhurjya , @xavez ,
Have a look at the updated jsfiddle using the 4.x branch..  You just need to add the padding in the css to make it 100%
https://jsfiddle.net/x82sjn49/34/
The colormask changes will be merged into 3.x branch also


CLB: project options disappeared from the menu

2023-03-17: there is no project options in my menu. I cannot access Assembly tools and others.
Frontend version: fb5152b March 17, 2023 8:04 AMBackend version: 53da770 March 15, 2023 12:00 AM

please just search for the project and follow the link to the project

See https://github.com/CatalogueOfLife/checklistbank/issues/1161

Do you mean "search dataset"?
I do not see an option "search for the project"

Give it a try for some time. We all find this way more convenient as it was with redundant and hidden menu items.

I agree interface menu was redundant.
Simple improvement should solve the current problem (not intuitive mix of datasets & projects under "Search datasets" item): menu should have two items: "Search projects" (incl. drop down a list of available projects in CLB) and "Search datasets".
"Dataset" and "Project" are two different entities.  CoL-draft as  a Project has many tools which are absent in the menu for "Dataset". As soon as CoL released as a fixed dataset, it moves to the category "Dataset".

There are actually 3 entities called dataset origins: external, project and release datasets.
You can filter them in the search as you need.

Yes, 3 entities.
Could you pls give me a screenshot, showing where I can choose between project, external & release?

And this is what the collapsed release list looks like:

Thanks!
Such an unobvious implementation...


Elm: pygments highlights variable name including number in elm code incorrectly.

(Original issue 1400 created by nobkz on 2017-12-08T16:24:48.558875+00:00)
Variable names should be colored in one color, but variable names including number is colored in two color.  The number (0-9) in variable name is different color from alphabet [a-z].

(Original comment by nobkz on 2017-12-08T16:27:04.051720+00:00)
I think that Elm lexer in pygments is wrong. so now I try to research source code.

(Original comment by nobkz on 2017-12-08T16:40:50.012802+00:00)
I found and modified about Elm lexer code.
https://bitbucket.org/birkenfeld/pygments-main/pull-requests/744/fixed-elm-lexer-about-variable-name/diff


INT B-20496 Safety Move Authentication Error Message

Agility ticket
Summary
This branch updates the error message that displays when an office user attempts to access a safety move when they do not have the adequate permissions to view safety moves.
The new page specifies that the page is not accessible, instead of the generic "Oops!" message that pops up for all other page errors.
How to test

Create an admin user at adminlocal:3000
Access DBeaver or psql, find your admin user in the admin_users table, and check the super column, this gives the user the ability to grant safety move permissions to office users.
In the admin dashboard, click "Office Users" and create a new user with your desired roles, be sure to include "Service Counselor".
After creating, find the user in the "Office Users" list and click "edit", you should now see a "Safety Move" checkbox, check it and save the changes.
Login to officelocal as the SC user, click the "Customer Search" tab, search for any string, then click the "Add Customer" button that pops up.

Create the customer, ensuring that the "Is this a safety move?" checkbox at the very top is checked.
Create the orders as needed, then you should be directed to the move details page for your new customer/move. Copy the URL.
Login as another user without safety move privileges and navigate to the URL, you should now see the updated error screen
For Prime, you'll need to complete the usual steps in order to make the move available to prime first, then make two prime users, one with and one without safety move privileges, since the Prime Sim doesn't use the same URL that you copied above, and you can't access any move there until it's available to Prime.

Screenshots

Warnings

:warning:

New files have been created under one of the legacy directories
(src/shared or src/scenes). Please relocate them according to the file structure described here.
View the frontend file org ADR for more information

  Generated by :no_entry_sign: dangerJS against 473135ec906b899a202cb343154f4a8cc40eeb50

I have a question for testing as Prime. I made a new prime user from the app - which shouldn't have the safety move privileges - but I can see and access the safety move from Prime simulator. Is this normal?

I have a question for testing as Prime. I made a new prime user from the app - which shouldn't have the safety move privileges - but I can see and access the safety move from Prime simulator. Is this normal? Maybe it doesn't matter for prime sim?

Doesn't look like there's anything for prime so I'm gonna go with

accidentally closed...


The same api token works on postman but  doesn't work on axios

if you face this problem.. it is because the authorization header only expects a capital latter Authorization but axios always sends a small latter one.. this will be fixed in the next version


Updated the test case for DDC6558 after review comments

@jeroenvrooij DDC6558Employee is not mapped, leading JoinedSubclassPersister to not find the phoneNumber property. Adding it there makes your test to pass.
@Ocramius I'd close this one as invalid...

@lcobucci what do you mean with 'is not mapped'? I added the '@entity' annotation. In the original PR I also added the inheritance annotations to the Employee, but that lead to other issues and @Ocramius noted that that was an invalid mapping. See https://github.com/doctrine/doctrine2/issues/6558 for some background info and a link to the other PR.
If you think multilevel inheritance is working properly can you please show me a brief example? We'd love to work with it, but we cannot find any docs or anybody to tell us how to do it. The implementations we tried for ourselves all had their flaws (hence the created issue ;))

@jeroenvrooij it's not mapped as a discriminator. I've made your tests pass by adding it there.

@lcobucci adding a discriminator on Employee is not valid. To quote @Ocramius:

Only one discriminator column is allowed at top level - this usage is invalid and should probably be reported by the schema validation

Check: https://github.com/doctrine/doctrine2/pull/6559

@jeroenvrooij that's not what I meant, that specific class is not listed in your discriminator map (at the root class).
All classes of the inheritance tree should be there, even if they're abstract.
I'm replying from my mobile so it's quite difficult to send you snippets, however if you just add that class to your map the test will pass.

I'm now on my laptop... this makes your tests to pass:

/**
 * @Entity
 * @InheritanceType("JOINED")
 * @DiscriminatorColumn(name="discr", type="string")
 * @DiscriminatorMap({"manager" = "DDC6558Manager", "staff" = "DDC6558Staff", "developer" = "DDC6558Developer", "employee" = "DDC6558Employee"})
 */
abstract class DDC6558Person
{
    /** @Id @Column(type="integer") @GeneratedValue */
    public $id;
}

Note that I've added "employee" = "DDC6558Employee" to your discriminator map.

@lcobucci Thanks for the explanation, I now get what you mean :). And indeed: if I add the employee in the discriminator map of the root class then the test passes. At the moment I cannot quickly test it in our application because we already re-structured the design (we could not wait any longer). But I think that all scenarios (persisting, fetching, etc) will now work, awesome!
(You could even add "foo" = "DDC6558Employee" to the mapping, the key doesn't seem to matter. I suppose that is due to the fact that the Employee is abstract and will never be instantiated.)
We really struggled to get this set up, mainly because it is not in the Doctrine docs and we couldn't find any conclusive info on the web. I cannot imagine that we are the only ones facing this, so would this be something that should be added to the docs? If so, I would love to help making that happen :).

@jeroenvrooij rather than documentation, this should be part of the schema validation tools.
The validator should have a piece of logic dedicated to detecting problems in the DiscriminatorMap


Add expected-lite

Martin Moene offers most c++17/20 vocabulary types (optional, variant, span, expected, etc) as single header libraries compatible with c++11 or even c++98.
This is expected https://github.com/martinmoene/expected-lite
I'm willing to add the others

Martin thinks it's best not to advertise trunk for now

I've been working on updating expected-lite to(wards) p0323r5, and now r6, but have been sidetracked to gsl-lite, span-lite and status_value the last two months.

The expected further changes make me somewhat reluctant to (also) advertise trunk. On the other hand, I try to keep trunk working and for the time being compatible with what was and gsl-lite is on CE as trunk.

So I've modified both PR to install the 0.0.1 tag instead


fix(ClientRequest): support throwing custom errors in request listener

@kettanaito

I throw a simple object with code property. Do we have a more solid Error object for tests?
I mainly used trial and error to determine that this.afterConnectionPhase = true belongs there. Please confirm if this is correct.

closes #452

@kettanaito Fixed. PTAL

Okay, I've pushed some refactoring to the error suppression logic so it behaves as we expect and account for the support of throwing network connection errors from the request listener. Explaining the changes below...

I suspect that the failing CI has to do with the network on GitHub Actions:
 FAIL  modules/http/compliance/http-errors.test.ts > forwards ENETUNREACH error for a bypassed request
AssertionError: expected 'ENETUNREACH' to be 'EHOSTUNREACH' // Object.is equality
 ❯ modules/http/compliance/http-errors.test.ts:131:29
    129|   const requestError = await errorPromise
    130|
    131|   expect(requestError.code).toBe('EHOSTUNREACH')
       |                             ^
    132|   expect(requestError.syscall).toBe('connect')
    133|   expect(requestError.address).toBe('2607:f0d0:1002:51::4')

  - Expected   "EHOSTUNREACH"
  + Received   "ENETUNREACH"

This same test produces the correct error locally. Will look into it...

As long as the state doesn't become too complicated, I think it's a great solution!
Thanks!! LGTM

As long as the state doesn't become too complicated, I think it's a great solution!

I will keep an eye on this part of the code to make sure it doesn't grow out of hand. I think we should be covered now.

I'm working with WSL, and I get these errors:

@mikicho, which version of Node.js is that? Also, I think the second error is related to the OS you're using.

Perhaps we should attempt to replicate this behavior using a more dependable error code? (e.g. ECONREFUSED)

Perhaps we should attempt to replicate this behavior using a more dependable error code? (e.g. ECONREFUSED)

Not sure what you mean here. Can you give an example of how we can achieve this substitute?
I'm not proficient with network error codes but they seem to stand for quite different things. ECONREFUSED means the connection was OK DNS-wise but was refused by the server. It appears to be a different error than EHOSTUNREACH, where the requested host is outside of the current network (but the host itself and the network are OK).

I've just ran the test on Node.js v20.6.1 and saw that it groups ECONNREFUSED into an AggregateError that doesn't have the syscall or address properties. I've adjusted those assertions accordingly. All tests are passing locally on that version of Node.
@mikicho, I'd still highly recommend nvm and use v18.14.x because we don't officially support Node.js v20 in Interceptor just yet.

This is with 18.14.2. The OS acts differently (I have WSL Debian)

Not sure what you mean here. Can you give an example of how we can achieve this substitute?

I mean, we want to make sure we can throw suppressed errors from the request handler, and capture them before the request is sent. maybe we can use a more reliable error, which acts the same across OS

@mikicho, I fixed that assertion to pass on Ubuntu. Also, looks like your branch has to be pulled to resolve the second failing assertion. Let me know how it goes!

Released: v0.25.7 🎉
This has been released in v0.25.7!

📄 Release notes
📦 npm package

Make sure to always update to the latest version (npm i @mswjs/interceptors@latest) to get the newest features and bug fixes.

Predictable release automation by @ossjs/release.


ERROR: Can not execute setup.py since setuptools is not available in the build environment.

Which python version should we use?
╰$ pip install pythontextnow
Collecting pythontextnow
  Using cached pythontextnow-1.0.1.tar.gz (18 kB)
  Preparing metadata (setup.py) ... error
  error: subprocess-exited-with-error

  × python setup.py egg_info did not run successfully.
  │ exit code: 1
  ╰─> [1 lines of output]
      ERROR: Can not execute `setup.py` since setuptools is not available in the build environment.
      [end of output]

  note: This error originates from a subprocess, and is likely not a problem with pip.
error: metadata-generation-failed

× Encountered error while generating package metadata.
╰─> See above for output.

note: This is an issue with the package mentioned above, not pip.
hint: See above for details.

Fixed after upgrade setuptools and wheel
pip install --upgrade setuptools wheel


Enable SdlCheck and fix warning for use of uninitialized pointer value

As part of generating an official build, one warning was issued for not using SdlCheck (see https://learn.microsoft.com/en-us/cpp/build/reference/sdl-enable-additional-security-checks?view=msvc-170 .)  Enabling this has the effect of enabling use of uninitialized pointer local variables, and most of this change revolves around that.  The general pattern seems to be Winfile using two locals, one which is initialized if a second is set, then later consumed if the second is set.  The compiler is not smart enough to understand that whenever it is used, the local will be initialized.  The changes here have the effect of suppressing the compiler warning, although any use of the local where it hasn't been initialized with the correct value will still be incorrect.  About the best thing these changes do is force a deterministic failure rather than consume uninitialized stack and fail in random ways.
This also splits the XP build definition from the regular one, since it seems to have enough XP-specific switches now that doing so is cleaner.  SdlCheck is only enabled for the 2022 compiler, so it's not present in the XP build.

It is about initialization and not about catching exception. This is the most weird argument I have ever heard.
As so many times I agree to disagree with your programming style from the 80s and your attitude of handling changes and running this repo.
This repo has detoriated into @malxau private environment.


Search: allow to match on entire word in combination with regex option

Currently we do not seem to respect the "match entire word" option when enabling regex search. The editor find widget does respect it.

Seems to work for me. But it will be imperfect because "entire word" is sort of a hack. And behavior differences in some cases could come from https://github.com/microsoft/vscode/issues/27280

And this kind of thing https://github.com/microsoft/vscode/issues/66411


enhance: [2.5] Cherry-pick proto change from master

Previous proto changes:
pr: #359 #369

/lgtm


Northumberland PP - Users wanted to know if there were any charges for credit or debit card charges before they selected this option.

Duplicate of #231


Consider merging with lspower and maintaining a single code base

Hi @ebkalderon, I wanted to start a discussion about merging some of the changes I made when lspower was forked and then deprecating that project so we can maintain a single code base. (I think you pinged me about this but I don't see where now so I'll just create this new issue).
I think the only significant changes since you've been updating tower-lsp again are:

The use of async-codec-lite in order to facilitate warm targets re: https://github.com/ebkalderon/tower-lsp/issues/187
The use of httparse and twoway instead of nom. This is more efficient and reduces the number of dependencies.

A lot of the rest of the changes are either bug fixes or updates you've already made or stylistic changes which aren't important.
I could work on PRs for the above two and, deprecate lspower, and then help to maintain tower-lsp going forward if that is something that interests you.

Hello again, @silvanshade! It's great to hear from you again. Thanks so much for maintaining lspower in my absence and submitting excellent improvements to the codebase all the while.
Sure, I would be happy to merge in those two changes into tower-lsp and resume the project in a more full capacity, if you're okay with that! Although small note: the twoway crate is technically considered deprecated today and advises users to go for memchr instead. This should still be fewer dependencies than relying on nom, though, either way. I'd also be happy to grant you some rights to the repository, if you're interested, considering your excellent contributions so far.
I'm looking forward to rolling out the custom client-to-server request approach described in https://github.com/ebkalderon/tower-lsp/issues/256#issuecomment-860024369, as well as addressing #284 long-term (I think I may have a vague idea of how to proceed and will update the issue shortly), and in light of this, I think it would be wonderful if the two codebases were consolidated together.
Feel free to get started on those PRs and we can review them together! And please freely ping me if you have further questions or suggestions as well. :heart:

Just merged in the changes, @silvanshade! What would you say to receiving collaborator access to this repo, adding you as an author to the Cargo.toml, and possibly adopting the lspower name unilaterally to try to unify the user bases of both crates?

@ebkalderon thanks for the follow up! That all sounds good to me. I'm not entirely sure if it would be better to use lspower or just keep the name tower-lsp. I don't really have a strong opinion about it either way so I guess it's up to you but it's fine with me if you think that would be best.

So one minor point in favor of keeping the tower-lsp name is that I already created a cancellation token API for lspower but it's not as nice as the one you described recently. So moving to that would be a breaking change I guess. I kind of doubt anyone is actually using it but still.

That's certainly a fair point. I wouldn't want to cause confusion for existing lspower and tower-lsp users. I guess we could shift focus towards #207 and choose a new name instead, once the API is finally stabilized.

Now that version 0.16.0 is up on crates.io, this task is effectively complete. :tada: I've personally added you, @silvanshade, as a co-author of the tower-lsp crate in the Cargo.toml. If you would like collaborator access to the repository going forward, please feel free to reach out to me personally. Thanks again for your great co-maintainership and contributions so far!


Port all this to C++ and do bindings to Python,Java ...

Is your feature request related to a problem? Please describe.
This project could reach a broader audience
Describe the solution you'd like
Port all this to C++ and to "lightweight" bindings
Describe alternatives you've considered
Port all this to Rust and do lightweight bindings

@0lru Thank you for having a positive impression for Harvester. To make my understanding clearer, let me make sure about some points. (1) Do you mean you want to suggest me to open up some other language versions of Harvester? I mean, now Harvester is a Python library but you say there should be Harvester C++ or Harvester Java as well? (2) Could you tell me your priority of the languages? As far as I read above, C++ comes first and then Rust follows. (3) Could you tell me your background a bit more? I'm a contributor to the official GenICam committee who regularly attends every face-to-face meeting called International Vision Standards Meeting, IVSM in short. I am responsible for developing and maintaining the GenICam Python binding that Harvester consumes. /Kazunari

Harvesters consist of more than 2500 LOC. From my experience, if you write your own thing based on the Genicam-API, as an example in Java or C++, you'll end up with even more LOC.
C++ seems the be one of the most portable languages at our time. You can now run in the browser and embed it in other environments through pybind11, JNI or whatsoever. Rust is comparable.
In consequence, I wondered if it's possible to create something more generic. Why shouldn't it be possible to harvest in any other language without too much code duplication?

@0lru Hi. Thank you for your valuable suggestion. The positive news that I have now is the official GenICam committee has already decided to develop such a C++ library that would be ported to other languages. The decision was made in late 2019 so it would take time more or less but it's promising because one of the committee member companies has the first prototype to be reviewed in the near future. I hope you keep an eye on the progress; it should come up in the GenICam GitHub repository. /Kazunari

Hi @kazunarikudo! do you know what the status is of the genicam committee cpp library that you are referring to?

@Bart-van-Ingen Hi, I could recall someone was throwing a hint at the time but I do not know if the guy still working for the company. At least I do not believe that was just a hint that never worked. /Kazunari.

@Bart-van-Ingen I am sorry but I do not think so as of 2021.

The header file downloaded by genicam and the interface in the manual are even different. I have no way to abstract the SDKs of multiple camera vendors based on genicam's interface.


Fix RubyGems printing packaging messages during the specs

Closes #4755.
My bad!

@homu r+

:pushpin: Commit 1745ecc has been approved by segiddins

:hourglass: Testing commit 1745ecc with merge 196594b...

:sunny: Test successful - status


trace 看板展示异常

Search before asking

[X] I had searched in the issues and found no similar feature requirement.

DeepFlow Component
Grafana Dashbaord
What you expected to happen
看这是解析 json 失败

这个 app: xxx 是我们的 pod 标签，用来标记应用名，但是根据 trace detail 数据来看，label是个字符串：

难道是将 string 当成 json 解析导致的问题么？grafana 也没有异常日志。。暂时没有排查思路
How to reproduce
No response
DeepFlow version
v6.5.4
DeepFlow agent list
No response
Kubernetes CNI
macvlan
Operation-System/Kernel version
Operating System: Ubuntu 22.04.2 LTS
Kernel: Linux 5.15.0-60-generic
Anything else
No response
Are you willing to submit a PR?

[X] Yes I am willing to submit a PR!

Code of Conduct

[X] I agree to follow this project's Code of Conduct

正在尝试复现, 并尽快修复此问题.
We're working to reproduce the bug and fix it as quickly as possible.

This is a bug that has been fixed in version v6.5.5


Kernel Compile error: memcpy pointer mismatch for actual parameter

this is what i get when I try to compile the driver:
https://i.imgur.com/Woyp8aT.png

try to set warning level 0

Can you fix some offset? i make some problem ,can you help me ?


Possibility to implement: Base "length" slider for Mountain Chains

Feature requests should adhere to the following guidlines:

be concise & describe in high-level terms (ie "please add a sand dunes biome, here's a picture")
technical proposals or system overhauls should be demonstrated in a working fork/pull-request
please do not solicit with the promise of donations and such

Please describe the feature you'd like to see:
Implementaion of some form of slider for: Base "length" slider for Mountain Chains, Allowing for single mountain chains or longer, or some Bias method
What considerations for gameplay/performance/user-experience should be made:
Possibly allow for players to increase chance of single "mountain" or much longer (tiers) for their world.
What alternatives or examples have you considered:
No obvious alternatives but examples could include:
HOME TOWN MOUNTAIN & TIERS

Thank you for the amazing mod <3 -

Both chains and individual mountains occur in the generator as-is.
There's not really a single parameter that can control it. A lot of it is down to the way different worldgen components interact together - when you start restricting those to get more repeatable/predictable results elsewhere you take a lot of variation out of the generator as whole

Ah yes thank you , for clearing it up 😍


Adding npm authenticate task, npm-common, and refactoring npm task

@t-jakurl,
Thanks for your contribution as a Microsoft full-time employee or intern. You do not need to sign a CLA.
Thanks,
Microsoft Pull Request Bot

@t-jakurl,
Thanks for your contribution as a Microsoft full-time employee or intern. You do not need to sign a CLA.
Thanks,
Microsoft Pull Request Bot


Release 0.30.4

Coverage decreased (-0.01%) to 27.722% when pulling 9bdc53868390ed3aa93cf5f2ea394dceea1b9d56 on release-0.30.4 into a323a164ae88598fa2be8605e8f902b2467f14a2 on master.


fs_open:Adjust the definition of the open path

Summary
Reference https://man7.org/linux/man-pages/man2/open.2.html
EISDIR pathname refers to a directory and the access requested
involved writing (that is, O_WRONLY or O_RDWR is set).
Impact
Testing

dup with https://github.com/apache/nuttx/pull/13907


Don't require to have a home/index.md for multilingual sites

I'm building a Spanish-language site that will have only some of it's posts in English. I'm following the Academic documentation for multilingual (created content/en and content/es) support and I came up into errors if I didn't create a home/index.md file inside my content/en folder.

Building sites … ERROR 2020/04/16 14:16:04 Homepage not found or duplicate homepages detected for a localization! Add the home/ folder (especially /home/index.md) to each language's content folder. For example, your site should have a content/home/ folder containing index.md and your homepage sections, or for multi-language sites, content/en/home/ and content/zh/home/ etc. Refer to the 'Build Your Homepage' and 'Language' documentation at https://sourcethemes.com/academic/docs/ and the example homepage at https://github.com/gcushen/hugo-academic/tree/master/exampleSite/content/home/index.md .

I don't want to have an English homepage so copying the content/es/home to content/en/home solves the issue. However, the side effect is that now Hugo detects that the index is translated and shows the language picker in my homepage.
Would it be possible to enable multilingual support for some pages without having to also translate the homepage? (I apologise if I'm doing something wrong and this is already possible)

Each Academic site you create requires a homepage.
Perhaps you might wish to try Hugo's approach to just translating pages - refer to Hugo docs and Hugo Forums.


[liblzma] Many linker warnings about missing PDB

Describe the bug
Linking LibLZMA causes many linker warnings for all dependent targets. This also affects ports that rely on LibLZMA indirectly, such as TIFF. The linker warning is LNK4099 - missing PDB (liblzma.pdb)
Environment

OS: Windows 11
Compiler: Visual Studio 2022
Triplet: x64-windows-static
Debug build configuration

To Reproduce
Minimal CMake project that uses vcpkg in manifest mode:
CMakeLists.txt

cmake_minimum_required(VERSION 3.16)

# Make sure vcpkg toolchain file is used
if(NOT DEFINED CMAKE_TOOLCHAIN_FILE)
    if(DEFINED ENV{VCPKG_ROOT})
        set(CMAKE_TOOLCHAIN_FILE "$ENV{VCPKG_ROOT}/scripts/buildsystems/vcpkg.cmake")
    else()
        message(FATAL_ERROR "You have to pass pass -DCMAKE_TOOLCHAIN_FILE=VCPKG_ROOT/scripts/buildsystems/vcpkg.cmake to cmake")
    endif()
endif()

# Make sure that static triplet is selected
if(WIN32 AND CMAKE_GENERATOR_PLATFORM MATCHES "64$" AND NOT CMAKE_GENERATOR_PLATFORM STREQUAL "ARM64")
    set(VCPKG_TARGET_TRIPLET "x64-windows-static")
elseif(WIN32 AND CMAKE_GENERATOR_PLATFORM MATCHES "32$" OR CMAKE_GENERATOR_PLATFORM STREQUAL "x86")
    set(VCPKG_TARGET_TRIPLET "x86-windows-static")
else()
    message(WARNING "You need to select a static VCPKG_TARGET_TRIPLET to reproduce this")
endif()

project(min-vcpkg-liblzma-test)
find_package(liblzma REQUIRED)
add_executable(min-vcpkg-liblzma-test ${CMAKE_CURRENT_SOURCE_DIR}/main.cpp)
set_property(TARGET min-vcpkg-liblzma-test PROPERTY MSVC_RUNTIME_LIBRARY "MultiThreaded$<$<CONFIG:Debug>:Debug>")
target_link_libraries(min-vcpkg-liblzma-test PRIVATE LibLZMA::LibLZMA)

vcpkg.json
{
    "name": "min-vcpkg-liblzma-test",
    "version": "1.0.0",
    "builtin-baseline": "809266d51a238e504acc134e5878c7860d5c179c",
    "dependencies": [ "liblzma" ]
}

main.cpp

#include <lzma.h>

int main() {
    lzma_stream strm = LZMA_STREAM_INIT;
    lzma_easy_encoder(&strm, 0, LZMA_CHECK_CRC64);
	return 0;
}

Download link: min-liblzma-test.zip
Expected behavior
No warnings.
Failure logs
Build started...
1>------ Build started: Project: ZERO_CHECK, Configuration: Debug x64 ------
1>Checking Build System
2>------ Build started: Project: min-vcpkg-liblzma-test, Configuration: Debug x64 ------
2>Building Custom Rule C:/Temp/min-liblzma-test/CMakeLists.txt
2>main.cpp
2>lzma.lib(easy_encoder.c.obj) : warning LNK4099: PDB 'liblzma.pdb' was not found with 'lzma.lib(easy_encoder.c.obj)' or at 'C:\Temp\min-liblzma-test\build\win64\Debug\liblzma.pdb'; linking object as if no debug info
2>lzma.lib(stream_encoder.c.obj) : warning LNK4099: PDB 'liblzma.pdb' was not found with 'lzma.lib(stream_encoder.c.obj)' or at 'C:\Temp\min-liblzma-test\build\win64\Debug\liblzma.pdb'; linking object as if no debug info
2>lzma.lib(easy_preset.c.obj) : warning LNK4099: PDB 'liblzma.pdb' was not found with 'lzma.lib(easy_preset.c.obj)' or at 'C:\Temp\min-liblzma-test\build\win64\Debug\liblzma.pdb'; linking object as if no debug info
2>lzma.lib(common.c.obj) : warning LNK4099: PDB 'liblzma.pdb' was not found with 'lzma.lib(common.c.obj)' or at 'C:\Temp\min-liblzma-test\build\win64\Debug\liblzma.pdb'; linking object as if no debug info
2>lzma.lib(filter_common.c.obj) : warning LNK4099: PDB 'liblzma.pdb' was not found with 'lzma.lib(filter_common.c.obj)' or at 'C:\Temp\min-liblzma-test\build\win64\Debug\liblzma.pdb'; linking object as if no debug info
2>lzma.lib(stream_flags_encoder.c.obj) : warning LNK4099: PDB 'liblzma.pdb' was not found with 'lzma.lib(stream_flags_encoder.c.obj)' or at 'C:\Temp\min-liblzma-test\build\win64\Debug\liblzma.pdb'; linking object as if no debug info
2>lzma.lib(block_header_encoder.c.obj) : warning LNK4099: PDB 'liblzma.pdb' was not found with 'lzma.lib(block_header_encoder.c.obj)' or at 'C:\Temp\min-liblzma-test\build\win64\Debug\liblzma.pdb'; linking object as if no debug info
2>lzma.lib(block_util.c.obj) : warning LNK4099: PDB 'liblzma.pdb' was not found with 'lzma.lib(block_util.c.obj)' or at 'C:\Temp\min-liblzma-test\build\win64\Debug\liblzma.pdb'; linking object as if no debug info
2>lzma.lib(index.c.obj) : warning LNK4099: PDB 'liblzma.pdb' was not found with 'lzma.lib(index.c.obj)' or at 'C:\Temp\min-liblzma-test\build\win64\Debug\liblzma.pdb'; linking object as if no debug info
2>lzma.lib(block_encoder.c.obj) : warning LNK4099: PDB 'liblzma.pdb' was not found with 'lzma.lib(block_encoder.c.obj)' or at 'C:\Temp\min-liblzma-test\build\win64\Debug\liblzma.pdb'; linking object as if no debug info
2>lzma.lib(index_encoder.c.obj) : warning LNK4099: PDB 'liblzma.pdb' was not found with 'lzma.lib(index_encoder.c.obj)' or at 'C:\Temp\min-liblzma-test\build\win64\Debug\liblzma.pdb'; linking object as if no debug info
2>lzma.lib(lzma_encoder_presets.c.obj) : warning LNK4099: PDB 'liblzma.pdb' was not found with 'lzma.lib(lzma_encoder_presets.c.obj)' or at 'C:\Temp\min-liblzma-test\build\win64\Debug\liblzma.pdb'; linking object as if no debug info
2>lzma.lib(crc32_fast.c.obj) : warning LNK4099: PDB 'liblzma.pdb' was not found with 'lzma.lib(crc32_fast.c.obj)' or at 'C:\Temp\min-liblzma-test\build\win64\Debug\liblzma.pdb'; linking object as if no debug info
2>lzma.lib(stream_flags_common.c.obj) : warning LNK4099: PDB 'liblzma.pdb' was not found with 'lzma.lib(stream_flags_common.c.obj)' or at 'C:\Temp\min-liblzma-test\build\win64\Debug\liblzma.pdb'; linking object as if no debug info
2>lzma.lib(vli_encoder.c.obj) : warning LNK4099: PDB 'liblzma.pdb' was not found with 'lzma.lib(vli_encoder.c.obj)' or at 'C:\Temp\min-liblzma-test\build\win64\Debug\liblzma.pdb'; linking object as if no debug info
2>lzma.lib(vli_size.c.obj) : warning LNK4099: PDB 'liblzma.pdb' was not found with 'lzma.lib(vli_size.c.obj)' or at 'C:\Temp\min-liblzma-test\build\win64\Debug\liblzma.pdb'; linking object as if no debug info
2>lzma.lib(filter_flags_encoder.c.obj) : warning LNK4099: PDB 'liblzma.pdb' was not found with 'lzma.lib(filter_flags_encoder.c.obj)' or at 'C:\Temp\min-liblzma-test\build\win64\Debug\liblzma.pdb'; linking object as if no debug info
2>lzma.lib(check.c.obj) : warning LNK4099: PDB 'liblzma.pdb' was not found with 'lzma.lib(check.c.obj)' or at 'C:\Temp\min-liblzma-test\build\win64\Debug\liblzma.pdb'; linking object as if no debug info
2>lzma.lib(filter_encoder.c.obj) : warning LNK4099: PDB 'liblzma.pdb' was not found with 'lzma.lib(filter_encoder.c.obj)' or at 'C:\Temp\min-liblzma-test\build\win64\Debug\liblzma.pdb'; linking object as if no debug info
2>lzma.lib(crc32_table.c.obj) : warning LNK4099: PDB 'liblzma.pdb' was not found with 'lzma.lib(crc32_table.c.obj)' or at 'C:\Temp\min-liblzma-test\build\win64\Debug\liblzma.pdb'; linking object as if no debug info
2>lzma.lib(crc64_fast.c.obj) : warning LNK4099: PDB 'liblzma.pdb' was not found with 'lzma.lib(crc64_fast.c.obj)' or at 'C:\Temp\min-liblzma-test\build\win64\Debug\liblzma.pdb'; linking object as if no debug info
2>lzma.lib(sha256.c.obj) : warning LNK4099: PDB 'liblzma.pdb' was not found with 'lzma.lib(sha256.c.obj)' or at 'C:\Temp\min-liblzma-test\build\win64\Debug\liblzma.pdb'; linking object as if no debug info
2>lzma.lib(lzma_encoder.c.obj) : warning LNK4099: PDB 'liblzma.pdb' was not found with 'lzma.lib(lzma_encoder.c.obj)' or at 'C:\Temp\min-liblzma-test\build\win64\Debug\liblzma.pdb'; linking object as if no debug info
2>lzma.lib(lzma2_encoder.c.obj) : warning LNK4099: PDB 'liblzma.pdb' was not found with 'lzma.lib(lzma2_encoder.c.obj)' or at 'C:\Temp\min-liblzma-test\build\win64\Debug\liblzma.pdb'; linking object as if no debug info
2>lzma.lib(x86.c.obj) : warning LNK4099: PDB 'liblzma.pdb' was not found with 'lzma.lib(x86.c.obj)' or at 'C:\Temp\min-liblzma-test\build\win64\Debug\liblzma.pdb'; linking object as if no debug info
2>lzma.lib(powerpc.c.obj) : warning LNK4099: PDB 'liblzma.pdb' was not found with 'lzma.lib(powerpc.c.obj)' or at 'C:\Temp\min-liblzma-test\build\win64\Debug\liblzma.pdb'; linking object as if no debug info
2>lzma.lib(ia64.c.obj) : warning LNK4099: PDB 'liblzma.pdb' was not found with 'lzma.lib(ia64.c.obj)' or at 'C:\Temp\min-liblzma-test\build\win64\Debug\liblzma.pdb'; linking object as if no debug info
2>lzma.lib(arm.c.obj) : warning LNK4099: PDB 'liblzma.pdb' was not found with 'lzma.lib(arm.c.obj)' or at 'C:\Temp\min-liblzma-test\build\win64\Debug\liblzma.pdb'; linking object as if no debug info
2>lzma.lib(armthumb.c.obj) : warning LNK4099: PDB 'liblzma.pdb' was not found with 'lzma.lib(armthumb.c.obj)' or at 'C:\Temp\min-liblzma-test\build\win64\Debug\liblzma.pdb'; linking object as if no debug info
2>lzma.lib(arm64.c.obj) : warning LNK4099: PDB 'liblzma.pdb' was not found with 'lzma.lib(arm64.c.obj)' or at 'C:\Temp\min-liblzma-test\build\win64\Debug\liblzma.pdb'; linking object as if no debug info
2>lzma.lib(sparc.c.obj) : warning LNK4099: PDB 'liblzma.pdb' was not found with 'lzma.lib(sparc.c.obj)' or at 'C:\Temp\min-liblzma-test\build\win64\Debug\liblzma.pdb'; linking object as if no debug info
2>lzma.lib(simple_encoder.c.obj) : warning LNK4099: PDB 'liblzma.pdb' was not found with 'lzma.lib(simple_encoder.c.obj)' or at 'C:\Temp\min-liblzma-test\build\win64\Debug\liblzma.pdb'; linking object as if no debug info
2>lzma.lib(delta_common.c.obj) : warning LNK4099: PDB 'liblzma.pdb' was not found with 'lzma.lib(delta_common.c.obj)' or at 'C:\Temp\min-liblzma-test\build\win64\Debug\liblzma.pdb'; linking object as if no debug info
2>lzma.lib(delta_encoder.c.obj) : warning LNK4099: PDB 'liblzma.pdb' was not found with 'lzma.lib(delta_encoder.c.obj)' or at 'C:\Temp\min-liblzma-test\build\win64\Debug\liblzma.pdb'; linking object as if no debug info
2>lzma.lib(crc64_table.c.obj) : warning LNK4099: PDB 'liblzma.pdb' was not found with 'lzma.lib(crc64_table.c.obj)' or at 'C:\Temp\min-liblzma-test\build\win64\Debug\liblzma.pdb'; linking object as if no debug info
2>lzma.lib(lz_encoder.c.obj) : warning LNK4099: PDB 'liblzma.pdb' was not found with 'lzma.lib(lz_encoder.c.obj)' or at 'C:\Temp\min-liblzma-test\build\win64\Debug\liblzma.pdb'; linking object as if no debug info
2>lzma.lib(lzma_encoder_optimum_fast.c.obj) : warning LNK4099: PDB 'liblzma.pdb' was not found with 'lzma.lib(lzma_encoder_optimum_fast.c.obj)' or at 'C:\Temp\min-liblzma-test\build\win64\Debug\liblzma.pdb'; linking object as if no debug info
2>lzma.lib(lzma_encoder_optimum_normal.c.obj) : warning LNK4099: PDB 'liblzma.pdb' was not found with 'lzma.lib(lzma_encoder_optimum_normal.c.obj)' or at 'C:\Temp\min-liblzma-test\build\win64\Debug\liblzma.pdb'; linking object as if no debug info
2>lzma.lib(price_table.c.obj) : warning LNK4099: PDB 'liblzma.pdb' was not found with 'lzma.lib(price_table.c.obj)' or at 'C:\Temp\min-liblzma-test\build\win64\Debug\liblzma.pdb'; linking object as if no debug info
2>lzma.lib(fastpos_table.c.obj) : warning LNK4099: PDB 'liblzma.pdb' was not found with 'lzma.lib(fastpos_table.c.obj)' or at 'C:\Temp\min-liblzma-test\build\win64\Debug\liblzma.pdb'; linking object as if no debug info
2>lzma.lib(simple_coder.c.obj) : warning LNK4099: PDB 'liblzma.pdb' was not found with 'lzma.lib(simple_coder.c.obj)' or at 'C:\Temp\min-liblzma-test\build\win64\Debug\liblzma.pdb'; linking object as if no debug info
2>lzma.lib(lz_encoder_mf.c.obj) : warning LNK4099: PDB 'liblzma.pdb' was not found with 'lzma.lib(lz_encoder_mf.c.obj)' or at 'C:\Temp\min-liblzma-test\build\win64\Debug\liblzma.pdb'; linking object as if no debug info
2>min-vcpkg-liblzma-test.vcxproj -> C:\Temp\min-liblzma-test\build\win64\Debug\min-vcpkg-liblzma-test.exe
2>Done building project "min-vcpkg-liblzma-test.vcxproj".
3>------ Skipped Build: Project: ALL_BUILD, Configuration: Debug x64 ------
3>Project not selected to build for this solution configuration
========== Build: 2 succeeded, 0 failed, 0 up-to-date, 1 skipped ==========

This seems to be caused by commit 371892cc20c3b81e5f609e898ab78875fc4d3d72 (#29561) because the issue is not present if I use the previous commit, e752415c5fdabba5a3f79279c22e2cb5ffd78a44 as builtin-baseline in vcpkg.json. However, I don't see anything in it that could cause this...

Do you have the pdb file locally? I installed the x86-windows triplet.
\vcpkg\packages\liblzma_x86-windows\bin

I installed the x86-windows triplet.

It was properly reported for a static triplet, and it can be found also in the error logs of https://dev.azure.com/vcpkg/public/_build/results?buildId=88488&view=results (but it is not an error).

This seems to be caused by commit 371892c (#29561) because the issue is not present if I use the previous commit, e752415 as builtin-baseline in vcpkg.json. However, I don't see anything in it that could cause this...

Don't change the baseline ... it will also change the version of script ports. liblzma depends on vcpkg-cmake.

There isn't any PDB file in vcpkg_installed and there still isn't one even when switching baseline to the one that doesn't emit the warning.


Search updates

This makes a few more updates to the sphinx search. Notably it adds a new API method to check if the API can use the extended search query build or the standard.  The way it was, the standard would always run and then be ignored by the sphinx API.  This addresses that and simply streamlines the path.  I think there is work to do in the highlighter function but that is for another time.
Next it removes the small and medium custom search index options leaving only the "large".  The others were really only a full  option for MySQL anyway and the usefulness of those is not even debatable, they are atrocious.
Next up It changes the way the custom database index is created.  The original way was using crypt(word), then using the first 2,4 or 5 "alpha/numeric usable" characters of that 32? character result.  Then multiplying that it by a power of the i'th chr() of the search (i'th being 2,4,5) word, I :poop: you not, that is about what it did.  The idea here is to avoid word collisions in the index but its painfully slow and has a poor distribution.
I changed crypt to a FNV1A32 hash (8 hex result) which is really designed for a db index, fast, very good distribution and uniqueness.   There was a article on running this against s 220K dictionary and 90000 number list and having 4 "collisions" where two non = words hashed out the same a.k.a NBD.  I rather doubt the old method was ever benchmarked for this, but crypt is a security algo not a speed/distribution/etc. algo.  Of course  FNV1A32 was likely not available when that was installed.  This will require a rebuild of any custom search index but its worth it.  To note this algo should be available since 5.7, but if we have a problem its an easy function add if needed.
Lastly it makes some changes so searching for 5.7 is possible without finding 57 as well, its a better overall tradeoff

Codecov Report

Merging #3459 (ca89e0c) into development (946699e) will decrease coverage by 7.43%.
The diff coverage is 21.21%.

@@                Coverage Diff                @@
##             development    #3459      +/-   ##
=================================================
- Coverage          30.22%   22.78%   -7.44%
+ Complexity         15976    15763     -213
=================================================
  Files                417      394      -23
  Lines              74414    69495    -4919
=================================================
- Hits               22489    15835    -6654
- Misses             51925    53660    +1735

Impacted Files
Coverage Δ
Complexity Δ

sources/ElkArte/AdminController/ManageSearch.php
4.41% <0.00%> (+0.12%)
83.00 <0.00> (-7.00)
:arrow_up:

sources/ElkArte/Controller/Search.php
0.00% <ø> (ø)
98.00 <0.00> (ø)

sources/ElkArte/Database/AbstractSearch.php
55.00% <0.00%> (-1.53%)
7.00 <1.00> (ø)

sources/ElkArte/Database/Mysqli/Search.php
6.25% <ø> (-5.66%)
9.00 <0.00> (-3.00)

sources/ElkArte/Database/Postgresql/Search.php
10.20% <ø> (-1.57%)
11.00 <0.00> (-1.00)

sources/ElkArte/MessagesDelete.php
4.33% <0.00%> (+0.01%)
144.00 <0.00> (ø)

sources/ElkArte/Search/API/Custom.php
0.00% <0.00%> (ø)
37.00 <0.00> (ø)

sources/ElkArte/Search/API/Fulltext.php
0.00% <0.00%> (ø)
31.00 <0.00> (ø)

sources/ElkArte/Search/API/Sphinx.php
0.00% <0.00%> (ø)
33.00 <1.00> (+1.00)

sources/ElkArte/Search/API/Sphinxql.php
0.00% <0.00%> (ø)
40.00 <1.00> (+1.00)

... and 159 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 946699e...ca89e0c. Read the comment docs.

When you are ready merge it! :P

I think I'm done with it again ... you know until next time.  On a positive note it builds the custom index much faster, still slow as heck, but faster.  Also fixed an old error that left the index a bit bigger than it could be


support pulling from ghcr.io

it would be great to have an oci_pull target in the WORKSPACE which we fetch as part of CI as a smoke test.  https://github.com/bazel-contrib/rules_oci/blob/eae8d198ab8f95797402f0692094d43a2a62f35f/oci/tests/BUILD.bazel#L42-L48
https://github.com/bazel-contrib/rules_oci/blob/eae8d198ab8f95797402f0692094d43a2a62f35f/WORKSPACE#L117-L134


Download and install latest Elasticsearch DPK

Configure an option to download and install the latest Elasticsearch DPK from MOS.

The latest Elasticsearch DPK (03) release has a non-Puppet install method that would work better with vagabond. The Puppet method replaces all the PeopleSoft Image Puppet code with the Elasticsearch code, so they don't play well together. The trickiest part will be managing the JAVA_HOME environment variables. PeopleTools 8.55 will crash if it uses Java 8 - which is required for Elasticsearch.


Fixed the newest same type release algorithm

Current dependencies on/for this PR:

main

PR #359   👈

This comment was auto-generated by Graphite.


DateTimeAdapter drops microseconds

DateTimeAdapter uses millisecondsSinceEpoch instead of microsecondsSinceEpoch. So if you try to save to hive e.g. 2021-01-08 15:43:46.900361, it actually saves 2021-01-08 15:43:46.900. One problem this is causing is that you cannot use DateTime.isAtSameMomentAs to compare a date saved to hive to the original date (it could be e.g. File.lastModified).
Version

Hive version: 1.4.4+1

Maybe you can forget this, see https://github.com/dart-lang/sdk/issues/44717

Maybe you can forget this, see https://github.com/dart-lang/sdk/issues/44717


include utility because using std::move

Should #include <utility> (because of std::move) to be self-contained.

@josephwb ... sorry for not replying before ...  If you are ok with that I will add
#include <utility>

And close this pull request?

nothing_but<T> moved to is own repo .


SimpleDisposable ?

I am getting an error that SimpleDisposable cannot be constructed because it does NOT have an initializer. Is it meant to be used outside of Bond itself?
Kind regards,
Sergey

Thanks for reporting this, We'll make it public.

Thanks a lot!
There is a small question I have: I am trying to write a function which would return an EventProducer for a network operation (to retrieve a certain kind of value). However, there seems to be no built-in way to have such operation to fire (i.e. to trigger it). I was looking at an example of NSNotificationCenter+Bond, but there the firing of a notification is done by NSNotificationCenter itself.

@serieuxchat I think what you are talking about is futures and promises. I think those were featured in the first alpha of v4 but removed later.
Have a look at BrightFutures. You can subscribe to the result of a Future and manipulate your Observables imperatively from there (using someObservable.next(value))


Feat: liquid staking module sketch #LSC-267

a quick note (just thought about it) — what if we receive a big ass voucher that will mess up our distribution? we might want to consider redelegating or something.

what's up with the idea to get the redeemed amount inside the reply handler?

what's up with the idea to get the redeemed amount inside the reply handler?

I suggest to stick with the current version for now. When we will be able to test the contracts on more realistic infrastructure (our integration-test framework), we'll compare these two versions (current and with the 'reply'-handler) and choose a more accurate one (or with less gas consumption).


Does Electron App Reloads, When There Is A Change In main.dev.js For Dev Env?

May be we can use https://github.com/Quramy/electron-connect to do it?

There is an ongoing experiment for this

@amilajack, can you share the experiment branch if present, I would also help in contributing?

https://github.com/chentsulin/electron-react-boilerplate/tree/hot-reload-main-process

hello, what's the progress?


Allow disabling of auto closing triple quotes

I would appreciate more fine control over what is auto closed. My issue is that the auto closing on triple quotes is making me press backspace 6 times per commented out code, and I've tried living with it in the hopes I'll get used to it, but it's still quite annoying.
This is what I end up with each time I try and comment something out:
''''''
# code I want to comment out
''''''

A solution recommended here was to disable auto closing on all quotes in all languages, which I've done for the time being, but it's not really a good solution.

As a more advanced solution, you could potentially check the line above. If the indent of that line is n (perhaps like a sphinx variable docstring) or n-1 (normal docstring), then auto close, but for anything else then don't.

Moving this issue to discussion as an enhancement request for comments and upvotes.


Should we move away from UNSAFE_componentWillReceiveProps

I want to address some adjustment improvement to remove the need for use UNSAFE_componentWillReceiveProps as it throws an error with react 17 and use shouldComponentUpdate method instance
and here my suggestion, it ok?
  shouldComponentUpdate (nextProps, nextState) {
    if (this.state.connected) {
      // Subscribe to new topics
      difference(nextProps.topics, this.props.topics).forEach((newTopic) => {
        this._log('Subscribing to topic: ' + newTopic)
        this._subscribe(newTopic)
      })

      // Unsubscribe from old topics
      difference(this.props.topics, nextProps.topics).forEach((oldTopic) => {
        this._log('Unsubscribing from topic: ' + oldTopic)
        this._unsubscribe(oldTopic)
      })
    }
    return false
  }

Also seeing the same warning in browser console, would really like to see an update like this pulled in. An otherwise awesome tool here.

Have been away from this project for a while, will take a look into this sometime next week.

@lahsivjar Do you think this could be resolved if a pull request was made with the proposed changes?


sched Never Exec

var sched = {
	schedules: [
		{m: [10, 20, 30, 40, 50, 0]}  //6 times per hour / every 10 minutes
	]
};
later.setInterval(function () {
	//code
}, sched);

is there any thing wrong whit my sched?

  This is probably what is causing the problem.
var sched = {
    schedules: [
        {m: [0, 10, 20, 30, 40, 50]}  //6 times per hour / every 10 minutes
    ]
};
later.setInterval(function () {
    //code
}, sched);


Asynchronous cannot obtain return value

let script_with_params = "(async () => {12})()";
    // execute_script_static
    let result = runtime.execute_script_static("<user-script>", &script_with_params)?;
    // run_event_loop
    runtime.run_event_loop(PollEventLoopOptions::default()).await?;

    let scope = &mut runtime.handle_scope();
    let local = v8::Local::new(scope, result);
    // Deserialize a `v8` object into a Rust type using `serde_v8`,
    // in this case deserialize to a JSON `Value`.
    let deserialized_value =
        serde_v8::from_v8::<serde_json::Value>(scope, local);
    Ok(deserialized_value.unwrap().to_string())

result:    {}

Excuse me, how should I write it to correctly obtain the return value within asynchrony？

(async () => {return 12})()

Hello,
Thank you for your prompt response. I tried your suggestion by modifying the JavaScript function to (async () => {return 12})(). However, I'm still encountering issues in retrieving the expected result in Rust. The returned value I'm getting is still {}.
Here's the modified JavaScript snippet I used:
deno_core::extension!(ext, ops = [op_query_database]);
let mut runtime = JsRuntime::new(RuntimeOptions {
    module_loader: Some(Rc::new(deno_core::FsModuleLoader)),
    extensions: vec![ext::init_ops()],
    ..Default::default()
});

> let script_with_params = "(async () => {return 12})()";

// execute_script_static
let result = runtime.execute_script_static("<user-script>", &script_with_params)?;
// run_event_loop
runtime.run_event_loop(PollEventLoopOptions::default()).await?;

let scope = &mut runtime.handle_scope();
let local = v8::Local::new(scope, result);
// Deserialize a `v8` object into a Rust type using `serde_v8`
let deserialized_value = serde_v8::from_v8::<serde_json::Value>(scope, local);
Ok(deserialized_value.unwrap().to_string())

Could you please provide further guidance on what might be going wrong or suggest any additional modifications I should make to correctly obtain the return value of the asynchronous function?
In addition to my previous message, I also attempted another approach in Rust, but I'm still not able to retrieve the expected result. Here's the relevant portion of the code I used:
deno_core::extension!(ext, ops = [op_query_database]);
let mut runtime = JsRuntime::new(RuntimeOptions {
    module_loader: Some(Rc::new(deno_core::FsModuleLoader)),
    extensions: vec![ext::init_ops()],
    ..Default::default()
});

let script_with_params = "(async () => {return 12})()";
// execute user script
let result = runtime.execute_script_static("<user-script>", &script_with_params)?;
// run event loop, wait for async operations to complete
runtime.run_event_loop(PollEventLoopOptions::default()).await?;
// create HandleScope
let scope = &mut runtime.handle_scope();
// use scope to get string
let rust_string = result.open(scope).to_rust_string_lossy(scope);
println!("rust_string:{:#?}", rust_string);
Ok(rust_string)

When I run this, the output doesn't reflect the expected result of 12, but rather I still receive an empty or incorrect result. I'm not sure if there's a problem with how I'm using deno_core or if there's a mistake in how I'm handling the async function in JavaScript.
Could you provide any insights or suggestions on what might be going wrong with this approach as well?
Thank you for your patience and help.

Ah right, you have an async function - which means the return value is a Promise. You can use JsRuntime::resolve() function to wait for this promise to complete and then proceed to deserialize it:
deno_core::extension!(ext, ops = [op_query_database]);
let mut runtime = JsRuntime::new(RuntimeOptions {
    module_loader: Some(Rc::new(deno_core::FsModuleLoader)),
    extensions: vec![ext::init_ops()],
    ..Default::default()
});

> let script_with_params = "(async () => {return 12})()";

// execute_script_static
let result = runtime.execute_script_static("<user-script>", &script_with_params)?;
runtime.resolve(result).await?;

let scope = &mut runtime.handle_scope();
let local = v8::Local::new(scope, result);
// Deserialize a `v8` object into a Rust type using `serde_v8`
let deserialized_value = serde_v8::from_v8::<serde_json::Value>(scope, local);
Ok(deserialized_value.unwrap().to_string())

Hello again,
Thank you for your continued assistance. I have followed your suggestion to use JsRuntime::resolve(), but I'm encountering an issue where the script execution seems to hang indefinitely. Here's the relevant code snippet:
deno_core::extension!(ext, ops = [op_query_database]);
let mut runtime = JsRuntime::new(RuntimeOptions {
   extensions: vec![ext::init_ops()],
   ..Default::default()
});

let script_with_params = "(async () =>  12)();";
// 执行用户脚本
let result = runtime.execute_script_static("<user-script>", &script_with_params)?;
let res=runtime.resolve(result).await?;
let scope = &mut runtime.handle_scope();
let local = v8::Local::new(scope, result);
// Deserialize a `v8` object into a Rust type using `serde_v8`
let deserialized_value = serde_v8::from_v8::<serde_json::Value>(scope, local);
Ok(deserialized_value.unwrap().to_string())

When I use runtime.resolve(result).await?;, the execution doesn't seem to complete, leading to an infinite hang. This is different from my earlier approach where I used runtime.run_event_loop(). With run_event_loop(), the script executes, but I face difficulties in retrieving the result.
Could you please help me understand why runtime.resolve() is causing an indefinite hang in this case? Also, is there a difference in how runtime.run_event_loop() and runtime.resolve() handle script execution that might affect retrieving the result?
Any further insights or suggestions you could provide would be greatly appreciated.
Thank you.

@mmastrac could. you take a look here? I'm confused as well, I thought that JsRuntime::resolve was meant to do exactly that - do we need to run JsRuntime::run_event_loop() concurrently to have it work correctly?

@bartlomieju @huiali  Correct, you need to run JsRuntime::run_event_loop concurrently or it won't resolve. I recommend using https://docs.rs/deno_core/latest/deno_core/struct.JsRuntime.html#method.with_event_loop_promise.

That's fine, but then I think docstring on JsRuntime::resolve should hint that the event loop needs to be polled, from what it reads right now:
/// Waits for the given value to resolve while polling the event loop.
  ///
  /// This future resolves when either the value is resolved or the event loop runs to
  /// completion.

it hints that it automatically runs the event loop.

Looks like I need to fix that comment, it's definitely wrong

Looks like I need to fix that comment, it's definitely wrong

Thanks!

@mmastrac @bartlomieju
Thank you for your response and the suggestion to use JsRuntime::with_event_loop_promise. I understand the need to run JsRuntime::run_event_loop concurrently for the script to resolve properly. However, I'm not entirely clear on how to implement this in my current setup.
Could you kindly provide a bit more guidance or a simple example on how to use JsRuntime::with_event_loop_promise in conjunction with JsRuntime::run_event_loop? An illustrative snippet showing the correct way to set this up would be immensely helpful.
Thank you once again for your patience and assistance.

deno_core::extension!(ext, ops = [op_query_database]);
let mut runtime = JsRuntime::new(RuntimeOptions {
extensions: vec![ext::init_ops()],
..Default::default()
});
let script_with_params = "(async () => { return 12 })()";
let result = runtime.execute_script_static("<user-script>", script_with_params);
let value = runtime.with_event_loop_promise(Box::pin(async move{ result }), PollEventLoopOptions::default()).await?;
let scope = &mut runtime.handle_scope();
let rust_string = value.open(scope).to_rust_string_lossy(scope);
Ok(rust_string)

return  [object Promise]

Hello again,
I appreciate your guidance on using JsRuntime::with_event_loop_promise. I attempted to implement it based on your suggestion, but I'm still facing challenges in retrieving the return value from the executed script. Here is the code snippet I used:
#[op2(async)]
#[smi]
pub async fn op_async_add_smi(#[smi] x: u32, #[smi] y: u32) -> u32 {
    tokio::time::sleep(Duration::from_millis(10)).await;
    x + y
}

deno_core::extension!(ext, ops = [op_async_add_smi]);
let mut runtime = JsRuntime::new(RuntimeOptions {
    extensions: vec![ext::init_ops_and_esm()],
    ..Default::default()
});

let script_with_params = "const op_async_add_smi = Deno.core.ensureFastOps();(async () =>  await op_async_add_smi(1,2) )()";
let result = runtime.execute_script_static("<user-script>", script_with_params);
let value = runtime.with_event_loop_promise(Box::pin(async move { result }), PollEventLoopOptions::default()).await?;
let scope = &mut runtime.handle_scope();
let rust_string = value.open(scope).to_rust_string_lossy(scope);
println!("rust_string:{:#?}", rust_string);

However, I am still not able to obtain the return value from the script. The script execution does not seem to yield the expected result, and I'm not sure what I might be missing or doing incorrectly.
Could you please help me understand what might be going wrong with this implementation? Any further insights or specific examples would be highly beneficial.
Thank you once again for your assistance.

I believe this is wrong:

let script_with_params = "const op_async_add_smi = Deno.core.ensureFastOps();(async () =>  await op_async_add_smi(1,2) )()";

It should be:

let script_with_params = "const { op_async_add_smi } = Deno.core.ensureFastOps();(async () =>  await op_async_add_smi(1,2) )()";

Hello,
Thank you for your prompt response and the correction regarding the script. I made the suggested change:
let script_with_params = "const { op_async_add_smi } = Deno.core.ensureFastOps();(async () =>  await op_async_add_smi(1,2) )()";

However, I'm still encountering the same issue. The script execution continues to return "[object Promise]". This leads me to believe that the issue might be related to how the Promise's resolved value is being retrieved, rather than the script itself.
Here's the relevant part of my Rust code:
//... [Previous setup code]
let result = runtime.execute_script_static("<user-script>", script_with_params);
let value = runtime.with_event_loop_promise(Box::pin(async move { result }), PollEventLoopOptions::default()).await?;
let scope = &mut runtime.handle_scope();
let rust_string = value.open(scope).to_rust_string_lossy(scope);
println!("rust_string:{:#?}", rust_string);

从您的描述中看来，尽管您按照作者的建议进行了修改，但是您的脚本仍然返回 “[object Promise]”，这表明您获取的是一个未解析的 Promise 对象，而不是该 Promise 解析后的值。这确实表明问题可能出在如何正确处理这个 Promise 上，以获取其最终的返回值。以下是您可以用来回复作者的内容：
Hello,
Thank you for your prompt response and the correction regarding the script. I made the suggested change:
rust
Copy code
let script_with_params = "const { op_async_add_smi } = Deno.core.ensureFastOps();(async () =>  await op_async_add_smi(1,2) )()";
However, I'm still encountering the same issue. The script execution continues to return "[object Promise]". This leads me to believe that the issue might be related to how the Promise's resolved value is being retrieved, rather than the script itself.
Here's the relevant part of my Rust code:
rust
Copy code
//... [Previous setup code]
let value = runtime.with_event_loop_promise(Box::pin(async move { result }), PollEventLoopOptions::default()).await?;
let scope = &mut runtime.handle_scope();
let rust_string = value.open(scope).to_rust_string_lossy(scope);
println!("rust_string:{:#?}", rust_string);
It appears that I'm not capturing the resolved value of the Promise correctly. Could you please provide some guidance on how to properly extract the final value from the Promise returned by the executed script? Any further insights or examples would be greatly appreciated.
Thank you once again for your help.

Hello,
Thank you for your prompt response and the correction regarding the script. I made the suggested change:
let script_with_params = "const { op_async_add_smi } = Deno.core.ensureFastOps();(async () =>  await op_async_add_smi(1,2) )()";

However, I'm still encountering the same issue. The script execution continues to return "[object Promise]". This leads me to believe that the issue might be related to how the Promise's resolved value is being retrieved, rather than the script itself.
Here's the relevant part of my Rust code:
//... [Previous setup code]
let result = runtime.execute_script_static("<user-script>", script_with_params);
let value = runtime.with_event_loop_promise(Box::pin(async move { result }), PollEventLoopOptions::default()).await?;
let scope = &mut runtime.handle_scope();
let rust_string = value.open(scope).to_rust_string_lossy(scope);
println!("rust_string:{:#?}", rust_string);

// rust_string:"[object Promise]"

It appears that I'm not capturing the resolved value of the Promise correctly. Could you please provide some guidance on how to properly extract the final value from the Promise returned by the executed script? Any further insights or examples would be greatly appreciated.
Thank you once again for your help.

I believe the issue lies in the way I'm handling the promise resolution in Rust. I'm looking for a way to correctly retrieve the final resolved value of the asynchronous operation executed in the script. Are there any examples in the source code, perhaps unit tests, that demonstrate how to properly handle and retrieve the result of an asynchronous operation in this context?

Hello,
I wanted to update you on my progress. I have managed to successfully retrieve the return value from the asynchronous operation using a different approach in Rust. Here's the snippet of the solution I used:
// Creating a persistent handle_scope reference
let mut handle_scope = runtime1.handle_scope();
// Creating a HandleScope
let scope = &mut v8::HandleScope::new(&mut handle_scope);
// Creating a context
let context = v8::Context::new(scope);
let scope = &mut v8::ContextScope::new(scope, context);
let code = r#"
    (async() => await 2)();
"#;
let script = v8::String::new(scope, code).unwrap();
let script = v8::Script::compile(scope, script, None).unwrap();
let result = script.run(scope).unwrap();
let promise = v8::Local::<v8::Promise>::try_from(result)
    .expect("Expected a Promise");
assert!(promise.state() == v8::PromiseState::Fulfilled);
let result = promise.result(scope);
let result_string = result.to_string(scope).unwrap().to_rust_string_lossy(scope);
println!("Result: {}", result_string);

This approach involves creating a HandleScope and a context, then compiling and running the script within this context. The result is then obtained from the Promise. This method effectively addresses the issue I was encountering with the asynchronous operation return values.
Thank you once again for all your assistance.

let script_with_params = "const { op_async_add_smi } = Deno.core.ensureFastOps();(async () =>  await op_async_add_smi(1,2) )()";

I think this is not correct - this script has now two elements, none of them is returned from the evaluation. If you want to return the resulting promise of op_async_add_smi I would do something like this:
let script_with_params = "(async () => { const { op_async_add_smi } = Deno.core.ensureFastOps(); return await op_async_add_smi(1,2); )()";

Hello,
Thank you for your continued support. I wanted to update you on my progress and also seek your opinion on an approach I've tried.
I managed to execute the script and retrieve the value using the following method:
let promise_global = runtime.execute_script("<user-script>", FastString::Owned(Box::from(script_with_params)))?;
runtime.run_event_loop(PollEventLoopOptions::default()).await?;
let scope = &mut runtime.handle_scope();
let result_global = v8::Local::new(scope, promise_global);
let promise = unsafe { v8::Local::<v8::Promise>::cast(result_global) }; // use unsafe
let result = promise.result(scope).to_rust_string_lossy(scope);

This method seems to work for executing the script and retrieving the value. However, I am wondering if there is an even better or more efficient way to achieve this. Particularly, I'm interested in understanding if there's a way to optimize the handling of promises and the extraction of their results.
Any further insights or suggestions you could provide would be greatly appreciated.
Thank you once again for your assistance.

Particularly, I'm interested in understanding if there's a way to optimize the handling of promises and the extraction of their results.

There's not much that can be done here - you pretty much used the canonical way that V8 exposes. Instead of using cast that requires unsafe you can use try_from instead.

Thanks!


chore: release helm-cosmo 0.12.3 🚀

:robot: I have created a release beep boop
0.12.3 (2024-11-22)
Bug Fixes

delete org and user workflows (#1326) (484898d)

This PR was generated with Release Please. See documentation.

:robot: Created releases:

<EMAIL_ADDRESS>:sunflower:


Fix error on LINEAR interpolations

I've got a model with mixed cubic and linear interpolations that couldn't export, simplifying the loop by putting the list lookup in the conditions fixed it.
Hope this PR is good for you, thanks for the work on GLTF.

Thank you very much, that you investigated this. Can you provide me the file, that I can investigate, why this happens?

Okay, now I got my mistake, but I will fix it differently.


UTM MacOS under App Store can run on Mac mini i5 but not Mbp 2019 i9

Describe the issue
I use the Debian (both minimum and the xfce).
I run the usually apt-get update/upgrade first.  The i9 default cannot run UTM (as it has 8 cores.  I adjust it to 1/2/4.  1 is very slow and 2 is acceptable and 4 is ok.  But none of i9 can run upgrade, it just hang there.  My i9 has 32GB memory.
May I stress that macmini i5 is ok.  I can even do build-essentials and compile c/c++/asm etc. under i5, which has 64 GB memory.
Configuration

UTM Version: 2.0.22(22)
OS Version: macOS Big Sur 11.2.2
Intel or Apple Silicon? Intel

Crash log
There is no crash; the system just hang
Debug log
done see attached
Upload VM
done see attached but need to add a file extension .txt
For the actual terminal command it is here:
apt-get update ok
[sudo] password for debian:
Sorry, try again.
[sudo] password for debian:
Sorry, try again.
[sudo] password for debian:
Hit:1 http://security.debian.org/debian-security buster/updates InRelease
Hit:2 http://deb.debian.org/debian buster InRelease
Hit:3 http://deb.debian.org/debian buster-updates InRelease
Reading package lists... Done

but I can't show the log of the "sudo apt-get upgrade" but it works for awhile until it can't
see screen dump when it freeze:

debug.log
config.plist.txt

One thing you can try is to select a CPU in the System settings (advanced). Choose something older like Haswell. That way both your machines will be emulating the same CPU.


The link to the TrueType spec points to the OpenType spec instead.

https://docs.microsoft.com/en-us/typography/truetype/hinting-tutorial/#a-note-about-hinting-tools has the text:

Tools used to produce professional fonts are not necessarily commercially available. Software and font companies have developed specific software for their development needs. In this document the syntax used for all TrueType instructions should be considered specific to this document and / or a specific TrueType development tool. For a full explanation of TrueType instructions and their syntax see the Microsoft TrueType spec Version 1.66 (or later) or the manual of a specific TrueType editor. In addition to proprietary tools the known TrueType editors are currently: RoyalT from Apple Computer and TypeSolution's TypeMan and StingRay.

But the "Microsoft TrueType spec Version 1.66" text links to https://docs.microsoft.com/en-us/typography/opentype/spec/ rather than the actual original TrueType 1.66 specification.  It would be super useful if this could be made to link to the (surprisingly hard to find!) official TrueType documentation.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: f1b2057a-c251-e692-7341-120d4a1bbd97
Version Independent ID: a5a56e09-d9b5-e66d-0e3e-14810ebc943d
Content: TrueType hinting tutorial - Intro - Typography
Content Source: typographydocs/truetype/hinting-tutorial/index.md
Product: typography
GitHub Login: @alib-ms
Microsoft Alias: alib

I suggest the link should be to Instructing TrueType Glyphs. This information was previously in a downloadable Word document, and I suspect all links to it were replaced by a generic link to the spec home page.

Ah yes, I forgot it used to be a .doc file... might be worth doing a find-all in the last commit that still used .doc links and see which additional pages may need their links updated.


test: add ability to test locally

Add the same script than in travis, but in the makefile to be able to test it locally quickly.

You are 100% right (I miss to work with you), it was changed.

you still planning on coming to the meetup tonight?

Yep, Hope to see you.


feat: importTypesPath for gql-tag-operations-preset

🚨 IMPORTANT: Please do not create a Pull Request without creating an issue first.
Any change needs to be discussed before proceeding. Failure to do so may result in the rejection of the pull request.
Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
This adds support for specifying an import typesPath for the gql-tag-operations-preset, just like import-types.
Related #8379
Type of change
Please delete options that are not relevant.

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[x] This change requires a documentation update

Screenshots/Sandbox (if appropriate/relevant):
Adding links to sandbox or providing screenshots can help us understand more about this PR and take action on it as appropriate
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

[ ] Test A
[ ] Test B

Test Environment:

OS:
@graphql-codegen/...:
NodeJS:

Checklist:

[ ] I have followed the CONTRIBUTING doc and the style guidelines of this project
[ ] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes
[ ] Any dependent changes have been merged and published in downstream modules

Further comments
If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

I marked this as "needing documentation update" because it adds options. I added jsdoc annotations but I'm not sure if that's all that's required.


Update for Qiskit 1.0

Updates the code for compatibility with Qiskit 1.0.
I relied only on the tests as I can't test this out in Jupyter due to https://github.com/kdk/qiskit-timeline-debugger/issues/4.

I was testing out your changes locally and I have mentioned some dependency changes.
Moreover, the graphviz library needs to be installed in the system for displaying the coupling map of the circuit.


Document an easier way to cherry-pick PRs

What this PR does / why we need it:
Applying PRs via patch-diff.githubusercontent.com  is what prow does with the cherrypick plugin too and it is
much easier and less error prone.
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #
Special notes for your reviewer:
Release note:
NONE

/cc @fabiand

it is much easier and less error prone.

any more info about how this is less error prone?

any more info about how this is less error prone?

Easier to verify that the PR is the right one and the cherry-pick, like in the case of prow, just creates one commit, makes from my experience resolving merge conflicts much easier.

If others find the documented way better, that works for me too.

Easier to verify that the PR is the right one and the cherry-pick, like in the case of prow, just creates one commit, makes from my experience resolving merge conflicts much easier.

I get it now. yes, by referencing the PR number, there' sless room for error.

/hold
The good thing about git cherry-pick -x is that it makes it obvious it's a cherry-pick, and gives you the hash of the cherry-picked commit.
I'm not necessarily opposed to that, just wanted to point it out and make sure everybody's ok with it.
Feel free to cancel the hold if nobody objects!

/close


Cannot recieve push notifications

I cannot recieve push notifications even though app is running background

@nagasaikrishna To receive push notifications (at least non-silence notifications) you don't need any plugin. In case of iOS10 I am going to fix it now as it stopped working.


Adding Cloud_Interface project

Checking in the initial Cloud Interface project towards JIRA 1949.

Closing the pull request as the content needs to be refactored.


Update the branch policies for the repository

After reviewing the branch policies for the repository, it seems that the main and release branches can benefit with more strict push and PR review policies. I would like to propose updating those as follows:

Follow naming convention release/<release-number> for release branches. Example release/rc.1
Use the following rules for main and release/* branches:

Require PR before merging

Require 3 approvals
Dismiss stale PR approvals when new commits are pushed
Require review from Code Owners

Require status checks to pass before merging
Require conversation resolution before merging
Require signed commits
Do not allow bypass the above settings

Please add your comments and proposals for additional changes to this issue.

LGTM but IANAM

LGTM but IANAM

LGTM but IANAM

LGTM but IANAM

LGTM but IANAM

Closed as all policies were enforced


Does not work on Flutter Web

Hello,
I found your package after looking for a solution to using hero animation in page view. This seemed to work perfectly, but when I tried it on my web application, there was no animation displaying. For privacy reasons, I cannot provide screenshots of the problem but I can share my code. Here is the code:
**Home page/Holder page:**

final _coastController = CoastController();

Coast(
        controller: _coastController,
        scrollDirection: Axis.vertical,
        dragStartBehavior: DragStartBehavior.down,
        beaches: [
          Beach(builder: (context) => IntroPage(size: size)),
          Beach(builder: (context) => BiWeeklyReadingsPage(size: size)),
          Beach(builder: (context) => UpcomingEventsPage(size: size)),
          Beach(builder: (context) => ContactUsPage(size: size)),
        ],
        observers: [
          CrabController(),
        ],
      ),

**Inro Page**
return Container(
      height: size.height - size.height * 0.08,
      width: size.width,
      child: Center(
        child: Column(
          mainAxisAlignment: MainAxisAlignment.center,
          crossAxisAlignment: CrossAxisAlignment.center,
          children: [
            Crab(
              tag: "text",
              child: Container(
                child: RichText(
                  text: TextSpan(
                      style: TextStyle(
                          fontSize: size.height * 0.075,
                          color: mainColor),
                      children: [
                      ...

**The rest of the pages have about the same code, using the SAME tag.**

I hope you can fix this issue/let me know why the error is occurring.
Keep up the great work.
Thanks,
Rhino

Never mind a full restart solved the problem jumped the gun on this one. Sorry about that. Great package keep up the great work!


doc: the link of document is broken

Describe the bug

All the link of the documents are cannot be accessed. For example: https://burn.dev
To Reproduce

Expected behavior

Screenshots

Desktop (please complete the following information):

OS: [e.g. iOS]
Browser [e.g. chrome, safari]
Version [e.g. 22]

Smartphone (please complete the following information):

Device: [e.g. iPhone6]
OS: [e.g. iOS8.1]
Browser [e.g. stock browser, safari]
Version [e.g. 22]

Additional context

@Aisuko I can't reproduce the problem, to me it looks fine. Can you give more details?

@Aisuko Is this resolved? I don't have any problems accessing the website from my end.

Hi @nathanielsimard I think it is because the reason below:
I'm trying to execute curl burn.dev

Thanks, I'll close the issue since it seems to be related only to your university policy.


WIP: verifier: Use the VirTEE CA Chain

This introduces changes into the code to utilize the cert chain provided by the VirTEE sev crate, pushing resposibility for upkeep and maintainership back to the library itself. This also reduces duplication of code and expands functionality for future changes.

/cc @fitzthum @DGonzalezVillal

Waiting on https://github.com/virtee/sev/pull/206

@larrydewey maybe the compiler/cargo errors you are seeing are due to some specifics in your local build environment? (e.g. cargo, rust toolchain, etc.) In this case you can maybe take a look at
https://github.com/confidential-containers/trustee/blob/81f904f0f5ec10db471922d86f03d90fa8e6385e/.github/workflows/kbs-rust.yml#L33-L38
to find a working configuration. The CI should define the canonical build configuration that we want to support.

This is my default configuration, so I don't believe it is my workflow or configuration.


Tab won't close after entering exit in Ubuntu-18.04, Linux and CMD.

 When I enter an invalid command and afterward entering exit the result is that the tab is still open and just showing  [process exited with code 127] without actually closing the tab if it is Linux or Ubuntu and [process exited with code 9009] if it is CMD. The tab is not usable, but just showing the message mentioned above. It happens only after I enter an invalid command. Photos attached below.
Environment
Windows build number: 1909
Windows Terminal version (if applicable): 0.10.761.0
Any other software?
No
Steps to reproduce
Need to check the way that the command exit works in the specific cases that mentioned and fix it so it'll work like in the PowerShell terminal (I tried the same there but didn't face an issue).
Expected behavior
The tab to be closed, just like after entering a valid command.
Actual behavior
The tab remains open and unavailable to use, just showing the message [process exited with code 127].

Thanks for the report! This one is by design, pursuant to https://github.com/microsoft/terminal/issues/4223#issuecomment-574834181. /dup #4223


feat: dataspace protocol transfer-process-dispatcher|spi

What this PR changes/adds
Implements transfer-process spi and dispatcher following :dsp:dsp-catalog.
:data-protocols:dsp:dsp-transfer-process:dsp-transfer-process-dispatcher
:data-protocols:dsp:dsp-transfer-process:dsp-transfer-process-spi
Why it does that
Support the dataspace protocol specification.
Further notes
Waits for PR #2759 to be merged
Linked Issue(s)
Relates #2474
Checklist

[x] added appropriate tests?
[x] performed checkstyle check locally?
[x] added/updated copyright headers?
[ ] documented public classes/methods?
[ ] added/updated relevant documentation?
[x] assigned appropriate label? (exclude from changelog with label no-changelog)
[x] formatted title correctly? (take a look at the CONTRIBUTING and Etiquette for pull requests for details)

Codecov Report
Patch coverage has no change and project coverage change: -52.62 :warning:

Comparison is base (108d686) 64.83% compared to head (6f9a327) 12.21%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #2760       +/-   ##
===========================================
- Coverage   64.83%   12.21%   -52.62%
===========================================
  Files         953      959        +6
  Lines       19551    19638       +87
  Branches     1167     1172        +5
===========================================
- Hits        12675     2399    -10276
- Misses       6421    17142    +10721
+ Partials      455       97      -358

Impacted Files
Coverage Δ

...l/dsp/transferprocess/dispatcher/DelegateUtil.java
0.00% <0.00%> (ø)

...patcher/DspTransferProcessDispatcherExtension.java
0.00% <0.00%> (ø)

...ispatcher/delegate/TransferCompletionDelegate.java
0.00% <0.00%> (ø)

...s/dispatcher/delegate/TransferRequestDelegate.java
0.00% <0.00%> (ø)

...ess/dispatcher/delegate/TransferStartDelegate.java
0.00% <0.00%> (ø)

...spatcher/delegate/TransferTerminationDelegate.java
0.00% <0.00%> (ø)

... and 587 files with indirect coverage changes
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


possible future change to how cresting is coded.

The codebook entry for cresting highlights some possible room for misinterpretation. In the atypical exemplar example, the Wilkins and Chazan paragraph on blade core preparation suggests that even if there are only a couple crested blades, you count cresting as present.
This is a bit of an edge case. By coding cresting as present, we are going a bit against the grain of author interpretations. However, if these are exhausted blade cores, and if cores were initiated through cresting, then the codebook entry would be correct. Keep this way for now.

No, its a bit silly. If there are crested blades involved, there should be a description that they served that purpose, like other kinds of debitage, lateral trimming/distal trimming/debord.  Change ambiguous wording of the atypical examplars so that it is appropriate for coding in assemblage wide contexts if there are only a few, but not if we are coding a particular chains that are well worked out, and wher they argue crested pieces are in the assemblage, but not applied in the chain of interest.