PHOENIX-5435 - Annotate HBase WALs with Phoenix Metadata

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
6m 59s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s
The patch appears to include 2 new or modified test files.

_ 4.x Compile Tests _

+0 :ok:
mvndep
0m 43s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
9m 16s
4.x passed

+1 :green_heart:
compile
1m 53s
4.x passed

+1 :green_heart:
checkstyle
3m 23s
4.x passed

+1 :green_heart:
javadoc
3m  7s
4.x passed

+0 :ok:
spotbugs
0m 35s
phoenix-hbase-compat-1.5.0 in 4.x has 3 extant spotbugs warnings.

+0 :ok:
spotbugs
0m 30s
phoenix-hbase-compat-1.4.0 in 4.x has 3 extant spotbugs warnings.

+0 :ok:
spotbugs
0m 28s
phoenix-hbase-compat-1.3.0 in 4.x has 3 extant spotbugs warnings.

+0 :ok:
spotbugs
5m 46s
root in 4.x has 1011 extant spotbugs warnings.

+0 :ok:
spotbugs
3m 29s
phoenix-core in 4.x has 957 extant spotbugs warnings.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 28s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
5m 56s
the patch passed

+1 :green_heart:
compile
1m 48s
the patch passed

+1 :green_heart:
cc
1m 48s
the patch passed

+1 :green_heart:
javac
1m 48s
the patch passed

-1 :x:
checkstyle
3m 35s
root: The patch generated 272 new + 6145 unchanged - 41 fixed = 6417 total (was 6186)

+1 :green_heart:
prototool
0m  2s
There were no new prototool issues.

-1 :x:
whitespace
0m  0s
The patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply

+1 :green_heart:
xml
0m  2s
The patch has no ill-formed XML file.

+1 :green_heart:
javadoc
3m  5s
the patch passed

-1 :x:
spotbugs
4m  0s
phoenix-core generated 4 new + 956 unchanged - 1 fixed = 960 total (was 957)

-1 :x:
spotbugs
5m 29s
root generated 4 new + 1010 unchanged - 1 fixed = 1014 total (was 1011)

_ Other Tests _

-1 :x:
unit
143m 30s
root in the patch failed.

+1 :green_heart:
asflicense
2m 56s
The patch does not generate ASF License warnings.

214m 11s

Reason
Tests

FindBugs
module:phoenix-core

org.apache.phoenix.hbase.index.IndexRegionObserver.DEFAULT_PHOENIX_APPEND_METADATA_TO_WAL isn't final but should be  At IndexRegionObserver.java:be  At IndexRegionObserver.java:[line 125]

org.apache.phoenix.hbase.index.IndexRegionObserver.PHOENIX_APPEND_METADATA_TO_WAL isn't final but should be  At IndexRegionObserver.java:be  At IndexRegionObserver.java:[line 124]

Load of known null value in org.apache.phoenix.hbase.index.IndexRegionObserver.prepareIndexMutations(IndexRegionObserver$BatchMutateContext, List, long)  At IndexRegionObserver.java:in org.apache.phoenix.hbase.index.IndexRegionObserver.prepareIndexMutations(IndexRegionObserver$BatchMutateContext, List, long)  At IndexRegionObserver.java:[line 719]

Switch statement found in org.apache.phoenix.hbase.index.scanner.FilteredKeyValueScanner.seekToNextUnfilteredKeyValue() where default case is missing  At FilteredKeyValueScanner.java:where default case is missing  At FilteredKeyValueScanner.java:[lines 84-101]

FindBugs
module:root

org.apache.phoenix.hbase.index.IndexRegionObserver.DEFAULT_PHOENIX_APPEND_METADATA_TO_WAL isn't final but should be  At IndexRegionObserver.java:be  At IndexRegionObserver.java:[line 125]

org.apache.phoenix.hbase.index.IndexRegionObserver.PHOENIX_APPEND_METADATA_TO_WAL isn't final but should be  At IndexRegionObserver.java:be  At IndexRegionObserver.java:[line 124]

Load of known null value in org.apache.phoenix.hbase.index.IndexRegionObserver.prepareIndexMutations(IndexRegionObserver$BatchMutateContext, List, long)  At IndexRegionObserver.java:in org.apache.phoenix.hbase.index.IndexRegionObserver.prepareIndexMutations(IndexRegionObserver$BatchMutateContext, List, long)  At IndexRegionObserver.java:[line 719]

Switch statement found in org.apache.phoenix.hbase.index.scanner.FilteredKeyValueScanner.seekToNextUnfilteredKeyValue() where default case is missing  At FilteredKeyValueScanner.java:where default case is missing  At FilteredKeyValueScanner.java:[lines 84-101]

Failed junit tests
phoenix.end2end.ViewMetadataIT

Subsystem
Report/Notes

Docker
ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-913/1/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/phoenix/pull/913

Optional Tests
dupname asflicense javac javadoc unit spotbugs hbaseanti checkstyle compile cc prototool xml

uname
Linux 989c2b3fb99f 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev/phoenix-personality.sh

git revision
4.x / 3008ca9

Default Java
Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08

checkstyle
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-913/1/artifact/yetus-general-check/output/diff-checkstyle-root.txt

whitespace
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-913/1/artifact/yetus-general-check/output/whitespace-eol.txt

spotbugs
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-913/1/artifact/yetus-general-check/output/new-spotbugs-phoenix-core.html

spotbugs
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-913/1/artifact/yetus-general-check/output/new-spotbugs-root.html

unit
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-913/1/artifact/yetus-general-check/output/patch-unit-root.txt

Test Results
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-913/1/testReport/

Max. process+thread count
5708 (vs. ulimit of 30000)

modules
C: phoenix-hbase-compat-1.5.0 phoenix-hbase-compat-1.4.0 phoenix-hbase-compat-1.3.0 phoenix-core . U: .

Console output
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-913/1/console

versions
git=2.7.4 maven=3.3.9 spotbugs=4.1.3 prototool=1.10.0-dev

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m  0s
Docker mode activated.

-1 :x:
docker
2m 30s
Docker failed to build yetus/phoenix:955047a0b.

Subsystem
Report/Notes

GITHUB PR
https://github.com/apache/phoenix/pull/913

Console output
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-913/2/console

versions
git=2.17.1

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
4m 18s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  1s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s
The patch appears to include 2 new or modified test files.

_ 4.x Compile Tests _

+0 :ok:
mvndep
0m 31s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
26m  3s
4.x passed

+1 :green_heart:
compile
1m 22s
4.x passed

+1 :green_heart:
checkstyle
4m  2s
4.x passed

+1 :green_heart:
javadoc
2m 22s
4.x passed

+0 :ok:
spotbugs
0m 26s
phoenix-hbase-compat-1.5.0 in 4.x has 3 extant spotbugs warnings.

+0 :ok:
spotbugs
0m 23s
phoenix-hbase-compat-1.4.0 in 4.x has 3 extant spotbugs warnings.

+0 :ok:
spotbugs
0m 21s
phoenix-hbase-compat-1.3.0 in 4.x has 3 extant spotbugs warnings.

+0 :ok:
spotbugs
3m 54s
root in 4.x has 1011 extant spotbugs warnings.

+0 :ok:
spotbugs
2m 40s
phoenix-core in 4.x has 957 extant spotbugs warnings.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 23s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
23m 43s
the patch passed

+1 :green_heart:
compile
1m 27s
the patch passed

+1 :green_heart:
cc
1m 27s
the patch passed

+1 :green_heart:
javac
1m 27s
the patch passed

-1 :x:
checkstyle
4m 14s
root: The patch generated 308 new + 8142 unchanged - 61 fixed = 8450 total (was 8203)

+1 :green_heart:
prototool
0m  2s
There were no new prototool issues.

-1 :x:
whitespace
0m  0s
The patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply

+1 :green_heart:
xml
0m  2s
The patch has no ill-formed XML file.

+1 :green_heart:
javadoc
2m 23s
the patch passed

-1 :x:
spotbugs
3m  8s
phoenix-core generated 4 new + 956 unchanged - 1 fixed = 960 total (was 957)

-1 :x:
spotbugs
4m 10s
root generated 4 new + 1010 unchanged - 1 fixed = 1014 total (was 1011)

_ Other Tests _

-1 :x:
unit
114m 35s
root in the patch failed.

+1 :green_heart:
asflicense
2m 51s
The patch does not generate ASF License warnings.

209m 17s

Reason
Tests

FindBugs
module:phoenix-core

org.apache.phoenix.hbase.index.IndexRegionObserver.DEFAULT_PHOENIX_APPEND_METADATA_TO_WAL isn't final but should be  At IndexRegionObserver.java:be  At IndexRegionObserver.java:[line 125]

org.apache.phoenix.hbase.index.IndexRegionObserver.PHOENIX_APPEND_METADATA_TO_WAL isn't final but should be  At IndexRegionObserver.java:be  At IndexRegionObserver.java:[line 124]

Load of known null value in org.apache.phoenix.hbase.index.IndexRegionObserver.prepareIndexMutations(IndexRegionObserver$BatchMutateContext, List, long)  At IndexRegionObserver.java:in org.apache.phoenix.hbase.index.IndexRegionObserver.prepareIndexMutations(IndexRegionObserver$BatchMutateContext, List, long)  At IndexRegionObserver.java:[line 719]

Switch statement found in org.apache.phoenix.hbase.index.scanner.FilteredKeyValueScanner.seekToNextUnfilteredKeyValue() where default case is missing  At FilteredKeyValueScanner.java:where default case is missing  At FilteredKeyValueScanner.java:[lines 84-101]

FindBugs
module:root

org.apache.phoenix.hbase.index.IndexRegionObserver.DEFAULT_PHOENIX_APPEND_METADATA_TO_WAL isn't final but should be  At IndexRegionObserver.java:be  At IndexRegionObserver.java:[line 125]

org.apache.phoenix.hbase.index.IndexRegionObserver.PHOENIX_APPEND_METADATA_TO_WAL isn't final but should be  At IndexRegionObserver.java:be  At IndexRegionObserver.java:[line 124]

Load of known null value in org.apache.phoenix.hbase.index.IndexRegionObserver.prepareIndexMutations(IndexRegionObserver$BatchMutateContext, List, long)  At IndexRegionObserver.java:in org.apache.phoenix.hbase.index.IndexRegionObserver.prepareIndexMutations(IndexRegionObserver$BatchMutateContext, List, long)  At IndexRegionObserver.java:[line 719]

Switch statement found in org.apache.phoenix.hbase.index.scanner.FilteredKeyValueScanner.seekToNextUnfilteredKeyValue() where default case is missing  At FilteredKeyValueScanner.java:where default case is missing  At FilteredKeyValueScanner.java:[lines 84-101]

Failed junit tests
phoenix.end2end.UpgradeIT

phoenix.end2end.OrphanViewToolIT

Subsystem
Report/Notes

Docker
ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-913/3/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/phoenix/pull/913

Optional Tests
dupname asflicense javac javadoc unit spotbugs hbaseanti checkstyle compile cc prototool xml

uname
Linux 2fb3ebe1bc30 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev/phoenix-personality.sh

git revision
4.x / acb2123

Default Java
Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08

checkstyle
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-913/3/artifact/yetus-general-check/output/diff-checkstyle-root.txt

whitespace
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-913/3/artifact/yetus-general-check/output/whitespace-eol.txt

spotbugs
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-913/3/artifact/yetus-general-check/output/new-spotbugs-phoenix-core.html

spotbugs
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-913/3/artifact/yetus-general-check/output/new-spotbugs-root.html

unit
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-913/3/artifact/yetus-general-check/output/patch-unit-root.txt

Test Results
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-913/3/testReport/

Max. process+thread count
5826 (vs. ulimit of 30000)

modules
C: phoenix-hbase-compat-1.5.0 phoenix-hbase-compat-1.4.0 phoenix-hbase-compat-1.3.0 phoenix-core . U: .

Console output
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-913/3/console

versions
git=2.7.4 maven=3.3.9 spotbugs=4.1.3 prototool=1.10.0-dev

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@gjacoby126 Some high-level questions:

For interactions with old clients, do we still get these WAL annotations (for ex: 4.16 server + 4.14 client) or do we only get this after clients are upgraded?

Is it worth-while to maintain a whitelist for tables/views/indices where we may not want to enable this?

This feature requires a 4.16 client and a 4.16 server. The server code is intended to gracefully no-op and not annotate if the client hasn't provided anything.
The question would be how to store the list of tables to annotate, since so much of the logic is client-side where we don't have the server-side hbase-site.xml. It could be Yet Another PTable Attribute, but I'm unsure if it's worth the complexity -- wdyt? The conceptually cleanest way would be to annotate replicated tables and not annotate unreplicated ones, but replication scope is on the TableDescriptor, which we don't usually have access to client-side.

A critique I received offline to this PR from @priyankporwal suggested that annotating indexes might not be worth the storage cost, so we could also consider exempting indexes in the next draft (which is waiting on PHOENIX-6186 to populate the DDL timestamps)

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
3m 27s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  1s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s
The patch appears to include 3 new or modified test files.

_ 4.x Compile Tests _

+0 :ok:
mvndep
0m 42s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
12m 54s
4.x passed

+1 :green_heart:
compile
1m 32s
4.x passed

+1 :green_heart:
checkstyle
2m 53s
4.x passed

+1 :green_heart:
javadoc
2m 23s
4.x passed

+0 :ok:
spotbugs
0m 26s
phoenix-hbase-compat-1.5.0 in 4.x has 3 extant spotbugs warnings.

+0 :ok:
spotbugs
0m 23s
phoenix-hbase-compat-1.4.0 in 4.x has 3 extant spotbugs warnings.

+0 :ok:
spotbugs
0m 23s
phoenix-hbase-compat-1.3.0 in 4.x has 3 extant spotbugs warnings.

+0 :ok:
spotbugs
4m 25s
root in 4.x has 1004 extant spotbugs warnings.

+0 :ok:
spotbugs
2m 57s
phoenix-core in 4.x has 950 extant spotbugs warnings.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 27s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
6m 57s
the patch passed

+1 :green_heart:
compile
1m 36s
the patch passed

+1 :green_heart:
cc
1m 36s
the patch passed

+1 :green_heart:
javac
1m 36s
the patch passed

-1 :x:
checkstyle
3m  0s
root: The patch generated 330 new + 8319 unchanged - 76 fixed = 8649 total (was 8395)

+1 :green_heart:
prototool
0m  2s
There were no new prototool issues.

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
xml
0m  1s
The patch has no ill-formed XML file.

+1 :green_heart:
javadoc
2m 28s
the patch passed

-1 :x:
spotbugs
3m 29s
phoenix-core generated 4 new + 950 unchanged - 0 fixed = 954 total (was 950)

-1 :x:
spotbugs
4m 36s
root generated 4 new + 1004 unchanged - 0 fixed = 1008 total (was 1004)

_ Other Tests _

-1 :x:
unit
195m 56s
root in the patch failed.

+1 :green_heart:
asflicense
2m 22s
The patch does not generate ASF License warnings.

259m 36s

Reason
Tests

FindBugs
module:phoenix-core

org.apache.phoenix.hbase.index.IndexRegionObserver.DEFAULT_PHOENIX_APPEND_METADATA_TO_WAL isn't final but should be  At IndexRegionObserver.java:be  At IndexRegionObserver.java:[line 126]

org.apache.phoenix.hbase.index.IndexRegionObserver.PHOENIX_APPEND_METADATA_TO_WAL isn't final but should be  At IndexRegionObserver.java:be  At IndexRegionObserver.java:[line 125]

Load of known null value in org.apache.phoenix.hbase.index.IndexRegionObserver.prepareIndexMutations(IndexRegionObserver$BatchMutateContext, List, long)  At IndexRegionObserver.java:in org.apache.phoenix.hbase.index.IndexRegionObserver.prepareIndexMutations(IndexRegionObserver$BatchMutateContext, List, long)  At IndexRegionObserver.java:[line 800]

Switch statement found in org.apache.phoenix.hbase.index.scanner.FilteredKeyValueScanner.seekToNextUnfilteredKeyValue() where default case is missing  At FilteredKeyValueScanner.java:where default case is missing  At FilteredKeyValueScanner.java:[lines 84-101]

FindBugs
module:root

org.apache.phoenix.hbase.index.IndexRegionObserver.DEFAULT_PHOENIX_APPEND_METADATA_TO_WAL isn't final but should be  At IndexRegionObserver.java:be  At IndexRegionObserver.java:[line 126]

org.apache.phoenix.hbase.index.IndexRegionObserver.PHOENIX_APPEND_METADATA_TO_WAL isn't final but should be  At IndexRegionObserver.java:be  At IndexRegionObserver.java:[line 125]

Load of known null value in org.apache.phoenix.hbase.index.IndexRegionObserver.prepareIndexMutations(IndexRegionObserver$BatchMutateContext, List, long)  At IndexRegionObserver.java:in org.apache.phoenix.hbase.index.IndexRegionObserver.prepareIndexMutations(IndexRegionObserver$BatchMutateContext, List, long)  At IndexRegionObserver.java:[line 800]

Switch statement found in org.apache.phoenix.hbase.index.scanner.FilteredKeyValueScanner.seekToNextUnfilteredKeyValue() where default case is missing  At FilteredKeyValueScanner.java:where default case is missing  At FilteredKeyValueScanner.java:[lines 84-101]

Failed junit tests
phoenix.end2end.index.ViewIndexIT

Subsystem
Report/Notes

Docker
ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-913/4/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/phoenix/pull/913

Optional Tests
dupname asflicense javac javadoc unit spotbugs hbaseanti checkstyle compile cc prototool xml

uname
Linux 88e7da627350 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev/phoenix-personality.sh

git revision
4.x / e57fcc8

Default Java
Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08

checkstyle
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-913/4/artifact/yetus-general-check/output/diff-checkstyle-root.txt

spotbugs
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-913/4/artifact/yetus-general-check/output/new-spotbugs-phoenix-core.html

spotbugs
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-913/4/artifact/yetus-general-check/output/new-spotbugs-root.html

unit
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-913/4/artifact/yetus-general-check/output/patch-unit-root.txt

Test Results
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-913/4/testReport/

Max. process+thread count
6080 (vs. ulimit of 30000)

modules
C: phoenix-hbase-compat-1.5.0 phoenix-hbase-compat-1.4.0 phoenix-hbase-compat-1.3.0 phoenix-core . U: .

Console output
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-913/4/console

versions
git=2.7.4 maven=3.3.9 spotbugs=4.1.4 prototool=1.10.0-dev

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
4m 11s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  1s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s
The patch appears to include 3 new or modified test files.

_ 4.x Compile Tests _

+0 :ok:
mvndep
0m 32s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
10m 44s
4.x passed

+1 :green_heart:
compile
1m 25s
4.x passed

+1 :green_heart:
checkstyle
10m 32s
4.x passed

+1 :green_heart:
javadoc
2m 22s
4.x passed

+0 :ok:
spotbugs
0m 27s
phoenix-hbase-compat-1.5.0 in 4.x has 3 extant spotbugs warnings.

+0 :ok:
spotbugs
0m 22s
phoenix-hbase-compat-1.4.0 in 4.x has 3 extant spotbugs warnings.

+0 :ok:
spotbugs
0m 24s
phoenix-hbase-compat-1.3.0 in 4.x has 3 extant spotbugs warnings.

+0 :ok:
spotbugs
3m 59s
root in 4.x has 1004 extant spotbugs warnings.

+0 :ok:
spotbugs
2m 38s
phoenix-core in 4.x has 950 extant spotbugs warnings.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 24s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
5m 59s
the patch passed

+1 :green_heart:
compile
1m 28s
the patch passed

+1 :green_heart:
cc
1m 28s
the patch passed

+1 :green_heart:
javac
1m 28s
the patch passed

-1 :x:
checkstyle
10m 46s
root: The patch generated 541 new + 23086 unchanged - 193 fixed = 23627 total (was 23279)

+1 :green_heart:
prototool
0m  1s
There were no new prototool issues.

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
xml
0m  2s
The patch has no ill-formed XML file.

+1 :green_heart:
javadoc
2m 26s
the patch passed

-1 :x:
spotbugs
3m 11s
phoenix-core generated 5 new + 950 unchanged - 0 fixed = 955 total (was 950)

-1 :x:
spotbugs
4m 12s
root generated 5 new + 1004 unchanged - 0 fixed = 1009 total (was 1004)

_ Other Tests _

-1 :x:
unit
143m 37s
root in the patch failed.

+1 :green_heart:
asflicense
0m 45s
The patch does not generate ASF License warnings.

214m 46s

Reason
Tests

FindBugs
module:phoenix-core

org.apache.phoenix.hbase.index.IndexRegionObserver.DEFAULT_PHOENIX_APPEND_METADATA_TO_WAL isn't final but should be  At IndexRegionObserver.java:be  At IndexRegionObserver.java:[line 126]

org.apache.phoenix.hbase.index.IndexRegionObserver.PHOENIX_APPEND_METADATA_TO_WAL isn't final but should be  At IndexRegionObserver.java:be  At IndexRegionObserver.java:[line 125]

Load of known null value in org.apache.phoenix.hbase.index.IndexRegionObserver.prepareIndexMutations(IndexRegionObserver$BatchMutateContext, List, long)  At IndexRegionObserver.java:in org.apache.phoenix.hbase.index.IndexRegionObserver.prepareIndexMutations(IndexRegionObserver$BatchMutateContext, List, long)  At IndexRegionObserver.java:[line 800]

Switch statement found in org.apache.phoenix.hbase.index.scanner.FilteredKeyValueScanner.seekToNextUnfilteredKeyValue() where default case is missing  At FilteredKeyValueScanner.java:where default case is missing  At FilteredKeyValueScanner.java:[lines 84-101]

org.apache.phoenix.jdbc.PhoenixDatabaseMetaData.CHANGE_DETECTION_ENABLED_BYTES is a mutable array  At MetaDataEndpointImpl.java: At MetaDataEndpointImpl.java:[line 336]

FindBugs
module:root

org.apache.phoenix.hbase.index.IndexRegionObserver.DEFAULT_PHOENIX_APPEND_METADATA_TO_WAL isn't final but should be  At IndexRegionObserver.java:be  At IndexRegionObserver.java:[line 126]

org.apache.phoenix.hbase.index.IndexRegionObserver.PHOENIX_APPEND_METADATA_TO_WAL isn't final but should be  At IndexRegionObserver.java:be  At IndexRegionObserver.java:[line 125]

Load of known null value in org.apache.phoenix.hbase.index.IndexRegionObserver.prepareIndexMutations(IndexRegionObserver$BatchMutateContext, List, long)  At IndexRegionObserver.java:in org.apache.phoenix.hbase.index.IndexRegionObserver.prepareIndexMutations(IndexRegionObserver$BatchMutateContext, List, long)  At IndexRegionObserver.java:[line 800]

Switch statement found in org.apache.phoenix.hbase.index.scanner.FilteredKeyValueScanner.seekToNextUnfilteredKeyValue() where default case is missing  At FilteredKeyValueScanner.java:where default case is missing  At FilteredKeyValueScanner.java:[lines 84-101]

org.apache.phoenix.jdbc.PhoenixDatabaseMetaData.CHANGE_DETECTION_ENABLED_BYTES is a mutable array  At MetaDataEndpointImpl.java: At MetaDataEndpointImpl.java:[line 336]

Subsystem
Report/Notes

Docker
ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-913/5/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/phoenix/pull/913

Optional Tests
dupname asflicense javac javadoc unit spotbugs hbaseanti checkstyle compile cc prototool xml

uname
Linux c23295b9be68 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev/phoenix-personality.sh

git revision
4.x / 7ac4dff

Default Java
Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08

checkstyle
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-913/5/artifact/yetus-general-check/output/diff-checkstyle-root.txt

spotbugs
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-913/5/artifact/yetus-general-check/output/new-spotbugs-phoenix-core.html

spotbugs
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-913/5/artifact/yetus-general-check/output/new-spotbugs-root.html

unit
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-913/5/artifact/yetus-general-check/output/patch-unit-root.txt

Test Results
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-913/5/testReport/

Max. process+thread count
5945 (vs. ulimit of 30000)

modules
C: phoenix-hbase-compat-1.5.0 phoenix-hbase-compat-1.4.0 phoenix-hbase-compat-1.3.0 phoenix-core . U: .

Console output
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-913/5/console

versions
git=2.7.4 maven=3.3.9 spotbugs=4.1.4 prototool=1.10.0-dev

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 33s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  1s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s
The patch appears to include 3 new or modified test files.

_ 4.x Compile Tests _

+0 :ok:
mvndep
0m 32s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
10m 53s
4.x passed

+1 :green_heart:
compile
1m 23s
4.x passed

+1 :green_heart:
checkstyle
9m 38s
4.x passed

+1 :green_heart:
javadoc
2m 26s
4.x passed

+0 :ok:
spotbugs
0m 27s
phoenix-hbase-compat-1.5.0 in 4.x has 3 extant spotbugs warnings.

+0 :ok:
spotbugs
0m 23s
phoenix-hbase-compat-1.4.0 in 4.x has 3 extant spotbugs warnings.

+0 :ok:
spotbugs
0m 22s
phoenix-hbase-compat-1.3.0 in 4.x has 3 extant spotbugs warnings.

+0 :ok:
spotbugs
4m  9s
root in 4.x has 1004 extant spotbugs warnings.

+0 :ok:
spotbugs
2m 59s
phoenix-core in 4.x has 950 extant spotbugs warnings.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 25s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
5m 59s
the patch passed

+1 :green_heart:
compile
1m 26s
the patch passed

+1 :green_heart:
cc
1m 26s
the patch passed

+1 :green_heart:
javac
1m 26s
the patch passed

-1 :x:
checkstyle
9m  5s
root: The patch generated 496 new + 23127 unchanged - 152 fixed = 23623 total (was 23279)

+1 :green_heart:
prototool
0m  2s
There were no new prototool issues.

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
xml
0m  2s
The patch has no ill-formed XML file.

+1 :green_heart:
javadoc
2m 27s
the patch passed

-1 :x:
spotbugs
3m 44s
phoenix-core generated 3 new + 950 unchanged - 0 fixed = 953 total (was 950)

-1 :x:
spotbugs
5m 25s
root generated 3 new + 1004 unchanged - 0 fixed = 1007 total (was 1004)

_ Other Tests _

-1 :x:
unit
132m 36s
root in the patch failed.

+1 :green_heart:
asflicense
2m 37s
The patch does not generate ASF License warnings.

204m 21s

Reason
Tests

FindBugs
module:phoenix-core

Load of known null value in org.apache.phoenix.hbase.index.IndexRegionObserver.prepareIndexMutations(IndexRegionObserver$BatchMutateContext, List, long)  At IndexRegionObserver.java:in org.apache.phoenix.hbase.index.IndexRegionObserver.prepareIndexMutations(IndexRegionObserver$BatchMutateContext, List, long)  At IndexRegionObserver.java:[line 800]

Switch statement found in org.apache.phoenix.hbase.index.scanner.FilteredKeyValueScanner.seekToNextUnfilteredKeyValue() where default case is missing  At FilteredKeyValueScanner.java:where default case is missing  At FilteredKeyValueScanner.java:[lines 84-101]

org.apache.phoenix.jdbc.PhoenixDatabaseMetaData.CHANGE_DETECTION_ENABLED_BYTES is a mutable array  At MetaDataEndpointImpl.java: At MetaDataEndpointImpl.java:[line 336]

FindBugs
module:root

Load of known null value in org.apache.phoenix.hbase.index.IndexRegionObserver.prepareIndexMutations(IndexRegionObserver$BatchMutateContext, List, long)  At IndexRegionObserver.java:in org.apache.phoenix.hbase.index.IndexRegionObserver.prepareIndexMutations(IndexRegionObserver$BatchMutateContext, List, long)  At IndexRegionObserver.java:[line 800]

Switch statement found in org.apache.phoenix.hbase.index.scanner.FilteredKeyValueScanner.seekToNextUnfilteredKeyValue() where default case is missing  At FilteredKeyValueScanner.java:where default case is missing  At FilteredKeyValueScanner.java:[lines 84-101]

org.apache.phoenix.jdbc.PhoenixDatabaseMetaData.CHANGE_DETECTION_ENABLED_BYTES is a mutable array  At MetaDataEndpointImpl.java: At MetaDataEndpointImpl.java:[line 336]

Failed junit tests
phoenix.end2end.ViewTTLIT

Subsystem
Report/Notes

Docker
ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-913/6/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/phoenix/pull/913

Optional Tests
dupname asflicense javac javadoc unit spotbugs hbaseanti checkstyle compile cc prototool xml

uname
Linux febe6ca7d32a 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev/phoenix-personality.sh

git revision
4.x / 6195621

Default Java
Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08

checkstyle
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-913/6/artifact/yetus-general-check/output/diff-checkstyle-root.txt

spotbugs
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-913/6/artifact/yetus-general-check/output/new-spotbugs-phoenix-core.html

spotbugs
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-913/6/artifact/yetus-general-check/output/new-spotbugs-root.html

unit
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-913/6/artifact/yetus-general-check/output/patch-unit-root.txt

Test Results
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-913/6/testReport/

Max. process+thread count
6043 (vs. ulimit of 30000)

modules
C: phoenix-hbase-compat-1.5.0 phoenix-hbase-compat-1.4.0 phoenix-hbase-compat-1.3.0 phoenix-core . U: .

Console output
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-913/6/console

versions
git=2.7.4 maven=3.3.9 spotbugs=4.1.4 prototool=1.10.0-dev

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

In this latest revision:

I added a new boolean flag, CHANGE_DETECTION_ENABLED to System.Catalog which is configured via property on table or view creation. It can be changed via ALTER. Adding it to an index will fail. Only tables and views with this flag set to true (it defaults false) will have their changes annotated into the WAL. Future JIRAs (such as PHOENIX-6227, and the main CDC code which will go in phoenix-connectors) will also use this flag.
Indexes are no longer annotated.
Shifted WALAnnotationIT to use the SchemaBuilder API introduced with Phoenix TTL

I believe the one remaining request left to do is @kadirozde 's suggestion to do a perf test. I will do this over the next couple of days.
@ChinmaySKulkarni , @kadirozde , fyi.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 31s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  1s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s
The patch appears to include 4 new or modified test files.

_ 4.x Compile Tests _

+0 :ok:
mvndep
0m 32s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
10m 57s
4.x passed

+1 :green_heart:
compile
1m 27s
4.x passed

+1 :green_heart:
checkstyle
10m 21s
4.x passed

+1 :green_heart:
javadoc
2m 23s
4.x passed

+0 :ok:
spotbugs
0m 27s
phoenix-hbase-compat-1.5.0 in 4.x has 3 extant spotbugs warnings.

+0 :ok:
spotbugs
0m 24s
phoenix-hbase-compat-1.4.0 in 4.x has 3 extant spotbugs warnings.

+0 :ok:
spotbugs
0m 21s
phoenix-hbase-compat-1.3.0 in 4.x has 3 extant spotbugs warnings.

+0 :ok:
spotbugs
3m 58s
root in 4.x has 1004 extant spotbugs warnings.

+0 :ok:
spotbugs
2m 42s
phoenix-core in 4.x has 950 extant spotbugs warnings.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 24s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
6m 17s
the patch passed

+1 :green_heart:
compile
1m 34s
the patch passed

+1 :green_heart:
cc
1m 34s
the patch passed

+1 :green_heart:
javac
1m 34s
the patch passed

-1 :x:
checkstyle
10m 40s
root: The patch generated 537 new + 23086 unchanged - 193 fixed = 23623 total (was 23279)

+1 :green_heart:
prototool
0m  2s
There were no new prototool issues.

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
xml
0m  1s
The patch has no ill-formed XML file.

+1 :green_heart:
javadoc
2m 21s
the patch passed

-1 :x:
spotbugs
3m 13s
phoenix-core generated 3 new + 950 unchanged - 0 fixed = 953 total (was 950)

-1 :x:
spotbugs
4m 14s
root generated 3 new + 1004 unchanged - 0 fixed = 1007 total (was 1004)

_ Other Tests _

-1 :x:
unit
140m 47s
root in the patch failed.

+1 :green_heart:
asflicense
0m 43s
The patch does not generate ASF License warnings.

208m 41s

Reason
Tests

FindBugs
module:phoenix-core

Load of known null value in org.apache.phoenix.hbase.index.IndexRegionObserver.prepareIndexMutations(IndexRegionObserver$BatchMutateContext, List, long)  At IndexRegionObserver.java:in org.apache.phoenix.hbase.index.IndexRegionObserver.prepareIndexMutations(IndexRegionObserver$BatchMutateContext, List, long)  At IndexRegionObserver.java:[line 800]

Switch statement found in org.apache.phoenix.hbase.index.scanner.FilteredKeyValueScanner.seekToNextUnfilteredKeyValue() where default case is missing  At FilteredKeyValueScanner.java:where default case is missing  At FilteredKeyValueScanner.java:[lines 84-101]

org.apache.phoenix.jdbc.PhoenixDatabaseMetaData.CHANGE_DETECTION_ENABLED_BYTES is a mutable array  At MetaDataEndpointImpl.java: At MetaDataEndpointImpl.java:[line 336]

FindBugs
module:root

Load of known null value in org.apache.phoenix.hbase.index.IndexRegionObserver.prepareIndexMutations(IndexRegionObserver$BatchMutateContext, List, long)  At IndexRegionObserver.java:in org.apache.phoenix.hbase.index.IndexRegionObserver.prepareIndexMutations(IndexRegionObserver$BatchMutateContext, List, long)  At IndexRegionObserver.java:[line 800]

Switch statement found in org.apache.phoenix.hbase.index.scanner.FilteredKeyValueScanner.seekToNextUnfilteredKeyValue() where default case is missing  At FilteredKeyValueScanner.java:where default case is missing  At FilteredKeyValueScanner.java:[lines 84-101]

org.apache.phoenix.jdbc.PhoenixDatabaseMetaData.CHANGE_DETECTION_ENABLED_BYTES is a mutable array  At MetaDataEndpointImpl.java: At MetaDataEndpointImpl.java:[line 336]

Subsystem
Report/Notes

Docker
ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-913/7/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/phoenix/pull/913

Optional Tests
dupname asflicense javac javadoc unit spotbugs hbaseanti checkstyle compile cc prototool xml

uname
Linux de63ff85ea36 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev/phoenix-personality.sh

git revision
4.x / 18b9f76

Default Java
Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08

checkstyle
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-913/7/artifact/yetus-general-check/output/diff-checkstyle-root.txt

spotbugs
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-913/7/artifact/yetus-general-check/output/new-spotbugs-phoenix-core.html

spotbugs
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-913/7/artifact/yetus-general-check/output/new-spotbugs-root.html

unit
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-913/7/artifact/yetus-general-check/output/patch-unit-root.txt

Test Results
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-913/7/testReport/

Max. process+thread count
6126 (vs. ulimit of 30000)

modules
C: phoenix-hbase-compat-1.5.0 phoenix-hbase-compat-1.4.0 phoenix-hbase-compat-1.3.0 phoenix-core . U: .

Console output
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-913/7/console

versions
git=2.7.4 maven=3.3.9 spotbugs=4.1.4 prototool=1.10.0-dev

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

The test run is odd -- looks like phoenix-core passed but then there was an error in building or shading phoenix-client? I can't reproduce locally -- mvn clean install -DskipTests passes for me.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 30s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  1s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s
The patch appears to include 4 new or modified test files.

_ 4.x Compile Tests _

+0 :ok:
mvndep
0m 32s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
10m 40s
4.x passed

+1 :green_heart:
compile
1m 22s
4.x passed

+1 :green_heart:
checkstyle
10m 33s
4.x passed

+1 :green_heart:
javadoc
2m 24s
4.x passed

+0 :ok:
spotbugs
0m 26s
phoenix-hbase-compat-1.5.0 in 4.x has 3 extant spotbugs warnings.

+0 :ok:
spotbugs
0m 24s
phoenix-hbase-compat-1.4.0 in 4.x has 3 extant spotbugs warnings.

+0 :ok:
spotbugs
0m 21s
phoenix-hbase-compat-1.3.0 in 4.x has 3 extant spotbugs warnings.

+0 :ok:
spotbugs
3m 59s
root in 4.x has 1004 extant spotbugs warnings.

+0 :ok:
spotbugs
2m 39s
phoenix-core in 4.x has 950 extant spotbugs warnings.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 24s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
6m  4s
the patch passed

+1 :green_heart:
compile
1m 28s
the patch passed

+1 :green_heart:
cc
1m 28s
the patch passed

+1 :green_heart:
javac
1m 28s
the patch passed

-1 :x:
checkstyle
10m 51s
root: The patch generated 496 new + 23126 unchanged - 152 fixed = 23622 total (was 23278)

+1 :green_heart:
prototool
0m  1s
There were no new prototool issues.

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
xml
0m  1s
The patch has no ill-formed XML file.

+1 :green_heart:
javadoc
2m 23s
the patch passed

-1 :x:
spotbugs
3m 11s
phoenix-core generated 3 new + 950 unchanged - 0 fixed = 953 total (was 950)

-1 :x:
spotbugs
4m 13s
root generated 3 new + 1004 unchanged - 0 fixed = 1007 total (was 1004)

_ Other Tests _

-1 :x:
unit
294m 10s
root in the patch failed.

+1 :green_heart:
asflicense
2m 31s
The patch does not generate ASF License warnings.

365m 36s

Reason
Tests

FindBugs
module:phoenix-core

Load of known null value in org.apache.phoenix.hbase.index.IndexRegionObserver.prepareIndexMutations(IndexRegionObserver$BatchMutateContext, List, long)  At IndexRegionObserver.java:in org.apache.phoenix.hbase.index.IndexRegionObserver.prepareIndexMutations(IndexRegionObserver$BatchMutateContext, List, long)  At IndexRegionObserver.java:[line 800]

Switch statement found in org.apache.phoenix.hbase.index.scanner.FilteredKeyValueScanner.seekToNextUnfilteredKeyValue() where default case is missing  At FilteredKeyValueScanner.java:where default case is missing  At FilteredKeyValueScanner.java:[lines 84-101]

org.apache.phoenix.jdbc.PhoenixDatabaseMetaData.CHANGE_DETECTION_ENABLED_BYTES is a mutable array  At MetaDataEndpointImpl.java: At MetaDataEndpointImpl.java:[line 336]

FindBugs
module:root

Load of known null value in org.apache.phoenix.hbase.index.IndexRegionObserver.prepareIndexMutations(IndexRegionObserver$BatchMutateContext, List, long)  At IndexRegionObserver.java:in org.apache.phoenix.hbase.index.IndexRegionObserver.prepareIndexMutations(IndexRegionObserver$BatchMutateContext, List, long)  At IndexRegionObserver.java:[line 800]

Switch statement found in org.apache.phoenix.hbase.index.scanner.FilteredKeyValueScanner.seekToNextUnfilteredKeyValue() where default case is missing  At FilteredKeyValueScanner.java:where default case is missing  At FilteredKeyValueScanner.java:[lines 84-101]

org.apache.phoenix.jdbc.PhoenixDatabaseMetaData.CHANGE_DETECTION_ENABLED_BYTES is a mutable array  At MetaDataEndpointImpl.java: At MetaDataEndpointImpl.java:[line 336]

Failed junit tests
phoenix.end2end.PermissionNSEnabledWithCustomAccessControllerIT

phoenix.end2end.ViewMetadataIT

phoenix.end2end.join.SubqueryIT

Subsystem
Report/Notes

Docker
ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-913/8/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/phoenix/pull/913

Optional Tests
dupname asflicense javac javadoc unit spotbugs hbaseanti checkstyle compile cc prototool xml

uname
Linux 505cd6e9f51a 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev/phoenix-personality.sh

git revision
4.x / 5e70f76

Default Java
Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08

checkstyle
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-913/8/artifact/yetus-general-check/output/diff-checkstyle-root.txt

spotbugs
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-913/8/artifact/yetus-general-check/output/new-spotbugs-phoenix-core.html

spotbugs
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-913/8/artifact/yetus-general-check/output/new-spotbugs-root.html

unit
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-913/8/artifact/yetus-general-check/output/patch-unit-root.txt

Test Results
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-913/8/testReport/

Max. process+thread count
6034 (vs. ulimit of 30000)

modules
C: phoenix-hbase-compat-1.5.0 phoenix-hbase-compat-1.4.0 phoenix-hbase-compat-1.3.0 phoenix-core . U: .

Console output
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-913/8/console

versions
git=2.7.4 maven=3.3.9 spotbugs=4.1.4 prototool=1.10.0-dev

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 30s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s
The patch appears to include 4 new or modified test files.

_ 4.x Compile Tests _

+0 :ok:
mvndep
0m 33s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
11m 14s
4.x passed

+1 :green_heart:
compile
1m 22s
4.x passed

+1 :green_heart:
checkstyle
8m 47s
4.x passed

+1 :green_heart:
javadoc
2m 20s
4.x passed

+0 :ok:
spotbugs
0m 29s
phoenix-hbase-compat-1.5.0 in 4.x has 3 extant spotbugs warnings.

+0 :ok:
spotbugs
0m 24s
phoenix-hbase-compat-1.4.0 in 4.x has 3 extant spotbugs warnings.

+0 :ok:
spotbugs
0m 21s
phoenix-hbase-compat-1.3.0 in 4.x has 3 extant spotbugs warnings.

+0 :ok:
spotbugs
4m  4s
root in 4.x has 1004 extant spotbugs warnings.

+0 :ok:
spotbugs
2m 43s
phoenix-core in 4.x has 950 extant spotbugs warnings.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 27s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
5m 59s
the patch passed

+1 :green_heart:
compile
1m 28s
the patch passed

+1 :green_heart:
cc
1m 28s
the patch passed

+1 :green_heart:
javac
1m 28s
the patch passed

-1 :x:
checkstyle
9m  1s
root: The patch generated 536 new + 23080 unchanged - 192 fixed = 23616 total (was 23272)

+1 :green_heart:
prototool
0m  2s
There were no new prototool issues.

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
xml
0m  1s
The patch has no ill-formed XML file.

+1 :green_heart:
javadoc
2m 24s
the patch passed

-1 :x:
spotbugs
3m 14s
phoenix-core generated 3 new + 950 unchanged - 0 fixed = 953 total (was 950)

-1 :x:
spotbugs
4m 17s
root generated 3 new + 1004 unchanged - 0 fixed = 1007 total (was 1004)

_ Other Tests _

-1 :x:
unit
148m 12s
root in the patch failed.

+1 :green_heart:
asflicense
0m 47s
The patch does not generate ASF License warnings.

212m 54s

Reason
Tests

FindBugs
module:phoenix-core

Load of known null value in org.apache.phoenix.hbase.index.IndexRegionObserver.prepareIndexMutations(IndexRegionObserver$BatchMutateContext, List, long)  At IndexRegionObserver.java:in org.apache.phoenix.hbase.index.IndexRegionObserver.prepareIndexMutations(IndexRegionObserver$BatchMutateContext, List, long)  At IndexRegionObserver.java:[line 800]

Switch statement found in org.apache.phoenix.hbase.index.scanner.FilteredKeyValueScanner.seekToNextUnfilteredKeyValue() where default case is missing  At FilteredKeyValueScanner.java:where default case is missing  At FilteredKeyValueScanner.java:[lines 84-101]

org.apache.phoenix.jdbc.PhoenixDatabaseMetaData.CHANGE_DETECTION_ENABLED_BYTES is a mutable array  At MetaDataEndpointImpl.java: At MetaDataEndpointImpl.java:[line 336]

FindBugs
module:root

Load of known null value in org.apache.phoenix.hbase.index.IndexRegionObserver.prepareIndexMutations(IndexRegionObserver$BatchMutateContext, List, long)  At IndexRegionObserver.java:in org.apache.phoenix.hbase.index.IndexRegionObserver.prepareIndexMutations(IndexRegionObserver$BatchMutateContext, List, long)  At IndexRegionObserver.java:[line 800]

Switch statement found in org.apache.phoenix.hbase.index.scanner.FilteredKeyValueScanner.seekToNextUnfilteredKeyValue() where default case is missing  At FilteredKeyValueScanner.java:where default case is missing  At FilteredKeyValueScanner.java:[lines 84-101]

org.apache.phoenix.jdbc.PhoenixDatabaseMetaData.CHANGE_DETECTION_ENABLED_BYTES is a mutable array  At MetaDataEndpointImpl.java: At MetaDataEndpointImpl.java:[line 336]

Subsystem
Report/Notes

Docker
ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-913/9/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/phoenix/pull/913

Optional Tests
dupname asflicense javac javadoc unit spotbugs hbaseanti checkstyle compile cc prototool xml

uname
Linux f4f92db0025f 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev/phoenix-personality.sh

git revision
4.x / 1261c3f

Default Java
Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08

checkstyle
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-913/9/artifact/yetus-general-check/output/diff-checkstyle-root.txt

spotbugs
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-913/9/artifact/yetus-general-check/output/new-spotbugs-phoenix-core.html

spotbugs
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-913/9/artifact/yetus-general-check/output/new-spotbugs-root.html

unit
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-913/9/artifact/yetus-general-check/output/patch-unit-root.txt

Test Results
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-913/9/testReport/

Max. process+thread count
5776 (vs. ulimit of 30000)

modules
C: phoenix-hbase-compat-1.5.0 phoenix-hbase-compat-1.4.0 phoenix-hbase-compat-1.3.0 phoenix-core . U: .

Console output
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-913/9/console

versions
git=2.7.4 maven=3.3.9 spotbugs=4.1.4 prototool=1.10.0-dev

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m 10s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  1s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s
The patch appears to include 4 new or modified test files.

_ 4.x Compile Tests _

+0 :ok:
mvndep
0m 31s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
12m  3s
4.x passed

+1 :green_heart:
compile
1m 36s
4.x passed

+1 :green_heart:
checkstyle
6m 24s
4.x passed

+1 :green_heart:
javadoc
2m 47s
4.x passed

+0 :ok:
spotbugs
0m 29s
phoenix-hbase-compat-1.5.0 in 4.x has 3 extant spotbugs warnings.

+0 :ok:
spotbugs
0m 25s
phoenix-hbase-compat-1.4.0 in 4.x has 3 extant spotbugs warnings.

+0 :ok:
spotbugs
0m 23s
phoenix-hbase-compat-1.3.0 in 4.x has 3 extant spotbugs warnings.

+0 :ok:
spotbugs
4m 43s
root in 4.x has 1005 extant spotbugs warnings.

+0 :ok:
spotbugs
3m 11s
phoenix-core in 4.x has 951 extant spotbugs warnings.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 25s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
7m 22s
the patch passed

+1 :green_heart:
compile
2m  4s
the patch passed

+1 :green_heart:
cc
2m  4s
the patch passed

+1 :green_heart:
javac
2m  4s
the patch passed

-1 :x:
checkstyle
8m 10s
root: The patch generated 506 new + 23134 unchanged - 191 fixed = 23640 total (was 23325)

+1 :green_heart:
prototool
0m  2s
There were no new prototool issues.

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
xml
0m  2s
The patch has no ill-formed XML file.

+1 :green_heart:
javadoc
3m  5s
the patch passed

-1 :x:
spotbugs
3m 59s
phoenix-core generated 2 new + 951 unchanged - 0 fixed = 953 total (was 951)

-1 :x:
spotbugs
5m 32s
root generated 2 new + 1005 unchanged - 0 fixed = 1007 total (was 1005)

_ Other Tests _

-1 :x:
unit
198m 10s
root in the patch failed.

+1 :green_heart:
asflicense
2m  8s
The patch does not generate ASF License warnings.

271m 24s

Reason
Tests

FindBugs
module:phoenix-core

Switch statement found in org.apache.phoenix.hbase.index.scanner.FilteredKeyValueScanner.seekToNextUnfilteredKeyValue() where default case is missing  At FilteredKeyValueScanner.java:where default case is missing  At FilteredKeyValueScanner.java:[lines 84-101]

org.apache.phoenix.jdbc.PhoenixDatabaseMetaData.CHANGE_DETECTION_ENABLED_BYTES is a mutable array  At MetaDataEndpointImpl.java: At MetaDataEndpointImpl.java:[line 336]

FindBugs
module:root

Switch statement found in org.apache.phoenix.hbase.index.scanner.FilteredKeyValueScanner.seekToNextUnfilteredKeyValue() where default case is missing  At FilteredKeyValueScanner.java:where default case is missing  At FilteredKeyValueScanner.java:[lines 84-101]

org.apache.phoenix.jdbc.PhoenixDatabaseMetaData.CHANGE_DETECTION_ENABLED_BYTES is a mutable array  At MetaDataEndpointImpl.java: At MetaDataEndpointImpl.java:[line 336]

Failed junit tests
phoenix.end2end.IndexExtendedIT

phoenix.util.IndexScrutinyIT

phoenix.end2end.IndexScrutinyToolIT

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-913/11/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/phoenix/pull/913

Optional Tests
dupname asflicense javac javadoc unit spotbugs hbaseanti checkstyle compile cc prototool xml

uname
Linux b75c8bf09267 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev/phoenix-personality.sh

git revision
4.x / 432474e

Default Java
Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08

checkstyle
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-913/11/artifact/yetus-general-check/output/diff-checkstyle-root.txt

spotbugs
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-913/11/artifact/yetus-general-check/output/new-spotbugs-phoenix-core.html

spotbugs
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-913/11/artifact/yetus-general-check/output/new-spotbugs-root.html

unit
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-913/11/artifact/yetus-general-check/output/patch-unit-root.txt

Test Results
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-913/11/testReport/

Max. process+thread count
5876 (vs. ulimit of 30000)

modules
C: phoenix-hbase-compat-1.5.0 phoenix-hbase-compat-1.4.0 phoenix-hbase-compat-1.3.0 phoenix-core . U: .

Console output
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-913/11/console

versions
git=2.7.4 maven=3.3.9 spotbugs=4.1.4 prototool=1.10.0-dev

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 30s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  1s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s
The patch appears to include 4 new or modified test files.

_ 4.x Compile Tests _

+0 :ok:
mvndep
0m 31s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
10m 58s
4.x passed

+1 :green_heart:
compile
1m 21s
4.x passed

+1 :green_heart:
checkstyle
9m 47s
4.x passed

+1 :green_heart:
javadoc
2m 24s
4.x passed

+0 :ok:
spotbugs
0m 27s
phoenix-hbase-compat-1.5.0 in 4.x has 3 extant spotbugs warnings.

+0 :ok:
spotbugs
0m 24s
phoenix-hbase-compat-1.4.0 in 4.x has 3 extant spotbugs warnings.

+0 :ok:
spotbugs
0m 23s
phoenix-hbase-compat-1.3.0 in 4.x has 3 extant spotbugs warnings.

+0 :ok:
spotbugs
4m  9s
root in 4.x has 1005 extant spotbugs warnings.

+0 :ok:
spotbugs
2m 44s
phoenix-core in 4.x has 951 extant spotbugs warnings.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 25s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
6m 13s
the patch passed

+1 :green_heart:
compile
1m 30s
the patch passed

+1 :green_heart:
cc
1m 30s
the patch passed

+1 :green_heart:
javac
1m 30s
the patch passed

-1 :x:
checkstyle
9m 15s
root: The patch generated 474 new + 23163 unchanged - 157 fixed = 23637 total (was 23320)

+1 :green_heart:
prototool
0m  1s
There were no new prototool issues.

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
xml
0m  1s
The patch has no ill-formed XML file.

+1 :green_heart:
javadoc
2m 35s
the patch passed

-1 :x:
spotbugs
3m 19s
phoenix-core generated 2 new + 951 unchanged - 0 fixed = 953 total (was 951)

-1 :x:
spotbugs
4m 30s
root generated 2 new + 1005 unchanged - 0 fixed = 1007 total (was 1005)

_ Other Tests _

-1 :x:
unit
128m 30s
root in the patch failed.

+1 :green_heart:
asflicense
2m 30s
The patch does not generate ASF License warnings.

198m 43s

Reason
Tests

FindBugs
module:phoenix-core

Switch statement found in org.apache.phoenix.hbase.index.scanner.FilteredKeyValueScanner.seekToNextUnfilteredKeyValue() where default case is missing  At FilteredKeyValueScanner.java:where default case is missing  At FilteredKeyValueScanner.java:[lines 84-101]

org.apache.phoenix.jdbc.PhoenixDatabaseMetaData.CHANGE_DETECTION_ENABLED_BYTES is a mutable array  At MetaDataEndpointImpl.java: At MetaDataEndpointImpl.java:[line 336]

FindBugs
module:root

Switch statement found in org.apache.phoenix.hbase.index.scanner.FilteredKeyValueScanner.seekToNextUnfilteredKeyValue() where default case is missing  At FilteredKeyValueScanner.java:where default case is missing  At FilteredKeyValueScanner.java:[lines 84-101]

org.apache.phoenix.jdbc.PhoenixDatabaseMetaData.CHANGE_DETECTION_ENABLED_BYTES is a mutable array  At MetaDataEndpointImpl.java: At MetaDataEndpointImpl.java:[line 336]

Failed junit tests
phoenix.end2end.index.ViewIndexIT

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-913/12/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/phoenix/pull/913

Optional Tests
dupname asflicense javac javadoc unit spotbugs hbaseanti checkstyle compile cc prototool xml

uname
Linux fbce87f802cf 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev/phoenix-personality.sh

git revision
4.x / d43c362

Default Java
Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08

checkstyle
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-913/12/artifact/yetus-general-check/output/diff-checkstyle-root.txt

spotbugs
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-913/12/artifact/yetus-general-check/output/new-spotbugs-phoenix-core.html

spotbugs
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-913/12/artifact/yetus-general-check/output/new-spotbugs-root.html

unit
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-913/12/artifact/yetus-general-check/output/patch-unit-root.txt

Test Results
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-913/12/testReport/

Max. process+thread count
6087 (vs. ulimit of 30000)

modules
C: phoenix-hbase-compat-1.5.0 phoenix-hbase-compat-1.4.0 phoenix-hbase-compat-1.3.0 phoenix-core . U: .

Console output
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-913/12/console

versions
git=2.7.4 maven=3.3.9 spotbugs=4.1.4 prototool=1.10.0-dev

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@gokceni , @ChinmaySKulkarni , @virajjasani , I believe I have addressed all outstanding comments (and also pushed up a fix for an NPE in ViewIndexIT the last test run found.) Could you please give it another look? Thanks!

@gjacoby126 btw for the past couple of days, all precommit PR builds (that I came across) are timing out and precommit Jira builds for 4.x patch are passing by ~1/4 probability (that I am aware of) so you might also want to upload 4.x patch to Jira to trigger 4.x precommit Jira build.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 41s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  1s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s
The patch appears to include 3 new or modified test files.

_ 4.x Compile Tests _

+0 :ok:
mvndep
0m 38s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
11m  7s
4.x passed

+1 :green_heart:
compile
1m 28s
4.x passed

+1 :green_heart:
checkstyle
7m 31s
4.x passed

+1 :green_heart:
javadoc
2m 25s
4.x passed

+0 :ok:
spotbugs
0m 28s
phoenix-hbase-compat-1.5.0 in 4.x has 3 extant spotbugs warnings.

+0 :ok:
spotbugs
0m 23s
phoenix-hbase-compat-1.4.0 in 4.x has 3 extant spotbugs warnings.

+0 :ok:
spotbugs
0m 24s
phoenix-hbase-compat-1.3.0 in 4.x has 3 extant spotbugs warnings.

+0 :ok:
spotbugs
4m 18s
root in 4.x has 1005 extant spotbugs warnings.

+0 :ok:
spotbugs
2m 55s
phoenix-core in 4.x has 951 extant spotbugs warnings.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 25s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
6m 35s
the patch passed

+1 :green_heart:
compile
1m 37s
the patch passed

+1 :green_heart:
cc
1m 37s
the patch passed

+1 :green_heart:
javac
1m 37s
the patch passed

-1 :x:
checkstyle
7m 36s
root: The patch generated 459 new + 23220 unchanged - 157 fixed = 23679 total (was 23377)

+1 :green_heart:
prototool
0m  2s
There were no new prototool issues.

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
xml
0m  2s
The patch has no ill-formed XML file.

+1 :green_heart:
javadoc
2m 31s
the patch passed

-1 :x:
spotbugs
3m 29s
phoenix-core generated 2 new + 951 unchanged - 0 fixed = 953 total (was 951)

-1 :x:
spotbugs
4m 36s
root generated 2 new + 1005 unchanged - 0 fixed = 1007 total (was 1005)

_ Other Tests _

-1 :x:
unit
127m 59s
root in the patch failed.

+1 :green_heart:
asflicense
2m 33s
The patch does not generate ASF License warnings.

195m 44s

Reason
Tests

FindBugs
module:phoenix-core

Switch statement found in org.apache.phoenix.hbase.index.scanner.FilteredKeyValueScanner.seekToNextUnfilteredKeyValue() where default case is missing  At FilteredKeyValueScanner.java:where default case is missing  At FilteredKeyValueScanner.java:[lines 84-101]

org.apache.phoenix.jdbc.PhoenixDatabaseMetaData.CHANGE_DETECTION_ENABLED_BYTES is a mutable array  At MetaDataEndpointImpl.java: At MetaDataEndpointImpl.java:[line 336]

FindBugs
module:root

Switch statement found in org.apache.phoenix.hbase.index.scanner.FilteredKeyValueScanner.seekToNextUnfilteredKeyValue() where default case is missing  At FilteredKeyValueScanner.java:where default case is missing  At FilteredKeyValueScanner.java:[lines 84-101]

org.apache.phoenix.jdbc.PhoenixDatabaseMetaData.CHANGE_DETECTION_ENABLED_BYTES is a mutable array  At MetaDataEndpointImpl.java: At MetaDataEndpointImpl.java:[line 336]

Failed junit tests
phoenix.end2end.ViewMetadataIT

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-913/13/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/phoenix/pull/913

Optional Tests
dupname asflicense javac javadoc unit spotbugs hbaseanti checkstyle compile cc prototool xml

uname
Linux ea827aee166e 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev/phoenix-personality.sh

git revision
4.x / 4b272b1

Default Java
Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08

checkstyle
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-913/13/artifact/yetus-general-check/output/diff-checkstyle-root.txt

spotbugs
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-913/13/artifact/yetus-general-check/output/new-spotbugs-phoenix-core.html

spotbugs
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-913/13/artifact/yetus-general-check/output/new-spotbugs-root.html

unit
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-913/13/artifact/yetus-general-check/output/patch-unit-root.txt

Test Results
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-913/13/testReport/

Max. process+thread count
6255 (vs. ulimit of 30000)

modules
C: phoenix-hbase-compat-1.5.0 phoenix-hbase-compat-1.4.0 phoenix-hbase-compat-1.3.0 phoenix-core . U: .

Console output
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-913/13/console

versions
git=2.7.4 maven=3.3.9 spotbugs=4.1.4 prototool=1.10.0-dev

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Thanks for the reviews, @ChinmaySKulkarni @gokceni and @virajjasani !


Koodikatselmointi

(In English, because the documentation was in English)
Downloaded 2022-05-03 19:00
General points

You've separated minor things into modules nicely (messages, colors, styles, fonts etc.), this helps keep everything consistent and helps maintenance
Generally good separation of UI, Logic and Data storage
Both the auto-formatter and Pylint have suggestions in places, you should consider implementing these
The code is very clean and readable, good work!

Specifics
UI - General
UI code with TKinter can get very messy, but you've done an excellent job of keeping things organized and clear with functions!
AccountView
Calculation of net worth seems to take place in the UI code. I see why you did it this way, but consider putting it somewhere else.
TransactionService
_convert_to_int() could be fine, if the data was know to be in the correct format (as is the case in format_amount()). Right now the user can input anything and the function will blindly try to convert it to an int, which can raise exceptions. A simple regex match at the start of the function and handling that situation appropriately OR having a separate validation function that the UI can call would solve this.
Unrelated to code (ie. usability)
The ability to delete accounts and transactions would be great.

Kiitos hyvästä palautteesta! Thank you for the feedback.


Uncaught Error: ENOENT: no such file or directory, lstat '~/AppData\Local\atom\app-1.45.0\ ajax'

[Enter steps to reproduce:]

...
...

Atom: 1.45.0 x64
Electron: 4.2.7
OS: Unknown Windows version
Thrown From: Atom Core
Stack Trace
Uncaught Error: ENOENT: no such file or directory, lstat 'C:\Users\abgka\AppData\Local\atom\app-1.45.0\ ajax'
At fs.js:115

Error: ENOENT: no such file or directory, lstat 'C:\Users\abgka\AppData\Local\atom\app-1.45.0\ ajax'
    at Proxy.realpathSync (fs.js:1435:7)
    at Proxy.fs.realpathSync (ELECTRON_ASAR.js:306:40)
    at TreeView.moveEntry (~/AppData/Local/atom/app-1.45.0/resources/app/static/<embedded>:14:1005297)
    at TreeView.onDrop (~/AppData/Local/atom/app-1.45.0/resources/app/static/<embedded>:14:1012226)
    at HTMLDivElement.<anonymous> (~/AppData/Local/atom/app-1.45.0/resources/app/static/<embedded>:14:985857)

Commands
     -3:04.7.0 autocomplete-plus:confirm (input.hidden-input)
     -2:59.6.0 core:backspace (input.hidden-input)
     -2:57 editor:newline (input.hidden-input)
     -2:44.4.0 autocomplete-plus:confirm (input.hidden-input)
  6x -2:42.6.0 core:move-left (input.hidden-input)
     -2:40.6.0 core:backspace (input.hidden-input)
     -2:24.9.0 editor:newline (input.hidden-input)
     -2:24.7.0 core:move-up (input.hidden-input)
     -2:19.4.0 autocomplete-plus:confirm (input.hidden-input)
     -2:18 editor:newline (input.hidden-input)
     -1:32.2.0 core:cut (input.hidden-input)
     -1:29.9.0 editor:newline (input.hidden-input)
     -1:29 core:paste (input.hidden-input)
  4x -1:17.3.0 core:undo (input.hidden-input)
     -0:36.1.0 tree-view:add-folder (span.name.icon.icon-file-directory)
     -0:29.4.0 core:confirm (input.hidden-input)

Non-Core Packages

Thanks for reaching out!
We require the template to be filled out on all new issues and pull requests. We do this so that we can be certain we have all the information we need to address your submission efficiently. This allows the maintainers to spend more time fixing bugs, implementing enhancements, and reviewing and merging pull requests.
Thanks for understanding and meeting us half way :grinning:


Move PathResolver elsewhere

This is generally useful code that should go elsewhere

Closing this since it was removed.


Longer response time in sending 1 million records using express.js

Hi there,
I have developed an application that rely heavily on database on following environment-
node v10.15.3
postgresql v10.5
200 concurrent applications access API to execute read all records from database. In response, 1 million record is returned by the database to node server and node server returns the same packet to client application. The response time is 6407.9 msec which is very high.
200 concurrent API call is made every second.
I also used compression module, but it did not help much.
Can anyone please let me know how to speed up the response time?

@sachinavinaw I would like to point out something, that response is not getting delayed by the express it's waiting for your DB to complete the query and return the response. So the actual problem is with the query itself.
Several solutions:
Adding pagination would be a quick and efficient one.
Other then this, you can try using streams for PostgreSQL
for implementing streams in pg, take reference from the link below
https://www.npmjs.com/package/pg-query-stream

I agree, sending one million of anything in a single request is something to avoid.  Pagination is the best approach IMO.  Either way this is not an express issue, if you would like more support with how to design your application I would post on Stack Overflow or the express gitter


Scripting - update and delete existing custom action

Hi Daniel,
This PR is for #429 in order to avoid manually editing the JSON file.
Alberto

Great stuff, thanks a lot for this contribution! Will review and merge later today.


Number of subintervals

Hi  all,
For using Sympson's and Trapezoidal method we have to define the number of subinterval. For this we define the function as "def simpson(f, a, b, n)" , what is the value of n (number of subintervals ) to be used to calculate and plot the integration here?

I am not going to do this part, but I guess, that is the number, if I remember correctly, in the class professor put 1000 right?. I hope you figured it out. If not, you can reopen the issue.


Add the ability to suppress CLT version check

I am using Sierra with Command Line Tools 7.3. I cannot upgrade CLT to newer version because even the latest NVIDIA CUDA compiler does not support 8.0+ and I am not able to build GPGPU code (like this: src-d/kmcuda). There is an option to disable XCode version check on Travis but there is no such option for CLT. I am not a dedicated Mac programmer and I don't want to install the full XCode monster. Effectively, I am unable to use Homebrew and have to short circuit check_clt_minimum_version in extend/os/mac/diagnostic.rb.
Please add some magic environment variable, e.g. TRAVIS to disable CLT version check.

Sorry, the 7.3 CLT has known, unresolvable issues with Sierra so we won't do this.

All right. It works perfectly fine for bottles though. For those like me, these are the instructions how to disable the 8.0 check:

export HOMEBREW_NO_AUTO_UPDATE=1
Edit /usr/local/Homebrew/Library/Homebrew/extend/os/mac/diagnostic.rb, insert return in the beginning of check_clt_minimum_version


Botgarden pottag KS changes

@kevin-kariuki - please review these minor changes and merge into your own branch. Thanks!

@kevin-kariuki - UGH, the way Github is diffing that is awful.
I just moved the pottag test up above the taxon test (keeping record type tests in alphabetical order in the file) and renamed the variables in the pottag test so they didn't include "taxon" in the variable name.

Noted.


Updated the Habitat 2.0 citation

Motivation and Context
The recently released Habitat 2.0 paper needs to be in the references and citations list.
How Has This Been Tested

Visually inspected rendered README.
Types of changes

Docs change / refactoring / dependency upgrade

Checklist

[ ] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[x] I have read the CONTRIBUTING document.
[x] I have completed my CLA (see CONTRIBUTING)
[ ] I have added tests to cover my changes.
[x] All new and existing tests passed.

@ASzot -- same comment. Please also add bibtex to the "Citing Habitat" section.

Now added.


More warnings

I think more warning would be useful for new users.
My list for what should be a warning but isnt so far:

warning for invalid animation name
warning for invalid animation properties (negative or 0 for numbers)
warning for too many/few values in a bezier curve
warning for invalid keyboard varient
warning for invalid keyboard layout
warning for invalid keyboard options
the current warning for booleans (yes/no) options does not list the avilable options

I will comment on here as I find more things that need warning

invalid animation name/properties is an error?

most cases in which a warning is not reported arise because at the time of parsing the said keyword they cannot be checked for correctness.
Example:
bind=mod,key,focusmonitor,IAMABADPERSON

The config parser doesn't know whether the monitor won't exist in the future.
some I can hack around some warnings though, fair.

You could also add runtime warnings instead of just in the config manager I believe this is already done in the log files but I think it should be more clearly visible for warnings

some done in 3a8dcf284aa3953585e3f700afa1095903c3a65f

the current warning for booleans (yes/no) options does not list the avilable options

booleans are not a separate data type. It's literally an int. I made them called "bool" in the wiki to avoid confusion and people setting bools to stuff like 31

How does that stop you from listing available values in the error message

hyprland internally doesn't know which value is a bool. Either I can suggest both int and bool values, which could be confusing, or I can suggest none.

ok

all done.


[Feature] - BindingAction.append operator

Sometimes with bindable properties that are arrays, its useful to append a value rather than just set it. To that end, this PR adds an .append operator.
Example:
.binding(.append(\.$identifiers, id))

You can definitely do this, but a thing we want to try to do is prevent business logic from "escaping" the reducer. As soon as a view has unfettered write access to a piece of state, you run the risk of introducing business logic that cannot be tested.

I think I failed to clarify, I'm only using .binding inside my reducers, I'm not even using viewStore.binding(_:). I use .binding inside my reducers to just set simple Bool or String properties so I can avoid having the boilerplate actions like setUserName or setIsAuthorized and so on. From the perspective of the view layer I agree, it should only be mutated either by dispatching actions or setting up bindings via the ViewStore.

As an alternative, what do you think of defining an "appended" key path on array?
extension Array {
  var append: Element? {
    get { self.last }
    set {
      if let newValue = newValue {
        self.append(newValue)
      } else if !self.isEmpty {
        self.removeLast()
      }
    }
  }
}

And then use it:
.binding(\.$identifiers.append, id))

This could be defined in your own application or even a library.

That's really interesting, I like that approach. I'll probably end up closing this PR in favor of that extension considering its lightly and non-intrusive.
Quick clarification question:

You can definitely do this, but a thing we want to try to do is prevent business logic from "escaping" the reducer. As soon as a view has unfettered write access to a piece of state, you run the risk of introducing business logic that cannot be tested.

When you say "escaping", do you mean using .binding(.set(\.$property, newValue)) outside of a reducer?

Hey @thebarndog, cool idea.  Do you have a short example of what the reducer would look like? Is there a benefit to using .binding(.set(\.$isAuthorized, false)) over state.isAuthorized = false?

Another idea for an extension @stephencelis, reducing boilerplate from
case let .logIn(provider):
    return .authenicate(provider: provider)
        .flatMap { user in
            return Publishers.Merge(
                Just(AppAction.binding(.set(\.$currentUser, user)),
                Just(AppAction.binding(.set(\.$connectedAccounts.append, provider))
            )
        }

case let .logIn(provider):
    return .authenicate(provider: provider)
        .on(success:
            .merge(
                .init(value: .binding(.set(\.$currentUser, user)),
                .init(value: .binding(.set(\.$connectedAccounts.append, provider))
             ),
              failure: .none
         )

where .on(success:failure:) is an extension on Effect that looks like func on(success: Effect, failure: Effect). Also useful would be Effect.if(_:then:) for Effects that produce Bools

I'm going to go ahead and close this since there are some better ways to accomplish the same thing


pull tle's from celetrak instead of satnogs

Satnogs is missing certain satellites. Celestrak has a more complete and up-to-date database.

I forgot I had never merged to main, so I've done that now. Make a new PR pointing to main instead, sorry.
Also, a few changes:

pls lint
let's keep both sources, make a function argument with default value "celestrack" or something like that
use requests properly; use params={"CATNR":self.id} instead of hacking it in there
typing-wise, you should store the result of the response as a Response object in a var resp and then put the lines into a differently named array. Otherwise the tle_txt variable will be both a str and a List[str] depending on where in the function you are which is bad practice. I think mypy will catch this but not sure.


MAC OS x el capitan vscode upgrade to 0.10.5 cannot be used

MAC OS x el capitan vscode upgrade to 0.10.5 cannot be used

you can start up code  with a English-US keyboard layout.

closing as duplicate of #1463

@Onlytanya  oh ! thank

sorry, for the hassle. we hope to get an update out soon


Create jimmy

The life story. Of Gerald James Anthony Terrance. Caufield. Born in 1955. Flint Hill Dipton Went to Dipton Saint Patrick's School. Run by Catholic nuns. Watch the church burned down in Dipton Saint Patrick's when I was very young boy. Leave school at 14. I started work on Richard White. Farm. I loved it. That's where I got the Bug for the Tools. I used to fetch a Turkey home for Christmas. My mom and dad. Used to sell it I once fetched a full leg of pork home. Looking forward to Sundays dinner? And ended up with mincemeat. I asked where  pork.Had gone. We're smoking it. bought myself a little scooter? To go to work and back. Come home. Mom sold it.  for £15 . Every penny I made was took off me. I once had a Savings under me carpet in the bedroom. My little sister. Tidying my room. Found it. Give it to mom. Never saw it again.  Chapter 2. I got married. To get out of the house. Started work as a butcher. Come home one day. Found out she. Was messing about. This really hurt me. I went down the wrong road for a while.  Bought A Vespa scooter. And I went to Scotland. For two years break. The best time of my life. So far. Come home. Nothing had changed. Apart from Grandma Lawlor Dying. . Which brought my heart. Moved out again. Start work. at Bob Huten Open cast coal sites. I was driving. Heavy machinery. Then I started fixing heavy machinery. I loved it. All over the country. Scotland, Wales, everywhere. Most of the time was spent in a place called Tau Law. We had five core sites. Unfortunately. Bob Huten. Died. I find somewhere else to work. So I went to Komatsu. Repair in heavy machinery.  track was everything. I got badly hurt. Went to.Langley Park Moving to my sisters. Met a lovely lady called Gillian. Now the best part of my life. gillian Had a son,  called  Michael. And he give us.. four grandchildren for me. Jake. jodi emmie. And Thomas. My beautiful little girl. Got married? I had one child. Call Alissa. I love all my grandchildren. I would die for any one of them.

The life story. Of Gerald James Anthony Terrance. Caufield. Born in 1955. Flint Hill Dipton Went to Dipton Saint Patrick's School. Run by Catholic nuns. Watch the church burned down in Dipton Saint Patrick's when I was very young boy. Leave school at 14. I started work on Richard White. Farm. I loved it. That's where I got the Bug for the Tools. I used to fetch a Turkey home for Christmas. My mom and dad. Used to sell it I once fetched a full leg of pork home. Looking forward to Sundays dinner? And ended up with mincemeat. I asked where  pork.Had gone. We're smoking it. bought myself a little scooter? To go to work and back. Come home. Mom sold it.  for £15 . Every penny I made was took off me. I once had a Savings under me carpet in the bedroom. My little sister. Tidying my room. Found it. Give it to mom. Never saw it again.  Chapter 2. I got married. To get out of the house. Started work as a butcher. Come home one day. Found out she. Was messing about. This really hurt me. I went down the wrong road for a while.  Bought A Vespa scooter. And I went to Scotland. For two years break. The best time of my life. So far. Come home. Nothing had changed. Apart from Grandma Lawlor Dying. . Which brought my heart. Moved out again. Start work. at Bob Huten Open cast coal sites. I was driving. Heavy machinery. Then I started fixing heavy machinery. I loved it. All over the country. Scotland, Wales, everywhere. Most of the time was spent in a place called Tau Law. We had five core sites. Unfortunately. Bob Huten. Died. I find somewhere else to work. So I went to Komatsu. Repair in heavy machinery.  track was everything. I got badly hurt. Went to.Langley Park Moving to my sisters. Met a lovely lady called Gillian. Now the best part of my life. gillian Had a son,  called  Michael. And he give us.. four grandchildren for me. Jake. jodi emmie. And Thomas. My beautiful little girl. Got married? I had one child. Call Alissa. I love all my grandchildren. I would die for any one of them.

The life story. Of Gerald James Anthony Terrance. Caufield. Born in 1955. Flint Hill Dipton Went to Dipton Saint Patrick's School. Run by Catholic nuns. Watch the church burned down in Dipton Saint Patrick's when I was very young boy. Leave school at 14. I started work on Richard White. Farm. I loved it. That's where I got the Bug for the Tools. I used to fetch a Turkey home for Christmas. My mom and dad. Used to sell it I once fetched a full leg of pork home. Looking forward to Sundays dinner? And ended up with mincemeat. I asked where  pork.Had gone. We're smoking it. bought myself a little scooter? To go to work and back. Come home. Mom sold it.  for £15 . Every penny I made was took off me. I once had a Savings under me carpet in the bedroom. My little sister. Tidying my room. Found it. Give it to mom. Never saw it again.  Chapter 2. I got married. To get out of the house. Started work as a butcher. Come home one day. Found out she. Was messing about. This really hurt me. I went down the wrong road for a while.  Bought A Vespa scooter. And I went to Scotland. For two years break. The best time of my life. So far. Come home. Nothing had changed. Apart from Grandma Lawlor Dying. . Which brought my heart. Moved out again. Start work. at Bob Huten Open cast coal sites. I was driving. Heavy machinery. Then I started fixing heavy machinery. I loved it. All over the country. Scotland, Wales, everywhere. Most of the time was spent in a place called Tau Law. We had five core sites. Unfortunately. Bob Huten. Died. I find somewhere else to work. So I went to Komatsu. Repair in heavy machinery.  track was everything. I got badly hurt. Went to.Langley Park Moving to my sisters. Met a lovely lady called Gillian. Now the best part of my life. gillian Had a son,  called  Michael. And he give us.. four grandchildren for me. Jake. jodi emmie. And Thomas. My beautiful little girl. Got married? I had one child. Call Alissa. I love all my grandchildren. I would die for any one of them.


Custom script name

Would it be possible to configure the script name? For instance compile-assets.sh instead of buildpack-run.sh, which doesn't mean anything to me.
Not exactly sure how to configure this though: env variable?

The issue has been addressed. Now you can set the filename with heroku config:set BUILDPACK_RUN=my_file.sh. It's also possible to specify multiple files to source by separating them with colons.

Perfect! Did you implement that right away when I suggested it? I'm impressed! I think the issue can be closed.

I implemented it the next day, yes ;) I hope that the buildpack is helpful to you.

Yes it is! I have a React-Rails stack, I use it to compile my webpack project before providing it to rails assets.

That's great! Feel free to recommend the buildpack to anybody if it was useful to you :)


GFM task lists are not pretty

GFM task lists are hard to read and hard to improve even if you're willing to add styling.
Sample md:
  - [ ] todo
  - [x] done

generates:

<input disabled="" type="checkbox"/>to do

<input disabled="\" type="checkbox" checked=""/>done

which renders as:

Issues

List marker characters are visible (the "discs" in front of the list item)
The checkmark in the checkbox is hard to see against the background of the (disabled) checkbox and the contrast between the unchecked and checked checkbox is not great either.  (see below).

It's possible to suppress the list marker characters with CSS styling (e.g list-style-type: none;), but that requires user to do the styling external to pulldown-cmark.
The (lack of) contrast is a CSS problem not limited to pulldown-cmark generation.  Github itself produces:

(dark theme)
Note the check mark in the checked item is barely visible and the contrast between checked and unchecked is not outstanding.
It's not possible to improve the contrast of a disabled checkmark input with CSS styling (both checked or unchecked).  You can change the (foreground) color of a list marker with accent-color, but that doesn't apply when checkbox is disabled, and there's no CSS attribute for the marker background color in any case.
I found various stunts attempting to improve the rendering, but they all involve a lot of CSS which has to be provided externally.
Github generated HTML (which ought to be a reference implementation) involves suppressing the list markers, then rendering the checkbox for a task item as a hanging indent on the text of the list item.
I've got some code that takes a different approach which I'll be submitting, but I wanted to get a clear statement of the  problem out there first.

This is closed as #806 has been added to the external rendering crate meta-issuel