Permissions in C:\Windows\system32\inetsrv\config

Required Information
Question, Bug, or Feature?
Type: Question
Enter Task Name: IIS Web Application Deployment
https://github.com/microsoft/azure-pipelines-tasks/tree/master/Tasks/IISWebAppDeploymentOnMachineGroupV0
Issue Description
Getting the bellow error when running this task using a non administrative account.
My question is regarding giving read access to the C:\Windows\system32\inetsrv\config folder for the local users group would be considered insecure for a production environment.
Error logs
"C:\Program Files\IIS\Microsoft Web Deploy V3\msdeploy.exe" -verb:sync -source:package='D:\Agents\azagent\A1_work\r1\a\temp_web_package_29244155173395825.zip' -dest:contentPath='Sitename' -enableRule:AppOffline
Error: An error occurred when reading the IIS Configuration File 'MACHINE/REDIRECTION'. The identity performing the operation was 'User'.
Error: Filename: \?\C:\Windows\system32\inetsrv\config\redirection.config
Error: Cannot read configuration file due to insufficient permissions
Error count: 1.

@pontuskindh for machine group based tasks we recommend running the agent as NT AUTHORITY\LOCAL SYSTEM.


Multiple annotations not working as expected

Hi, I am doing some inference on large arrays. I have some workers for GPU tasks and others for the generic ones, mainly reshaping and I/O. I notice some GPU-related code is executed on workers without the GPU, resulting in an exception.

import dask
import dask.array as da
import numpy as np
from dask.distributed import Client, LocalCluster

def test_gpu(array):
    print("test_gpu")
    return array

def main():
    cluster = LocalCluster(
        resources={"CPU": 1},
    )
    client = Client(cluster)

    zeros = da.zeros(10)
    with dask.annotate(resources={"GPU": 1}):
        res = zeros.map_blocks(test_gpu, meta=np.array(()))
    with dask.annotate(resources={"CPU": 1}):
        zarr_array = da.to_zarr(
            res,
            "/tmp/test.zarr",
            overwrite=True,
            return_stored=True,
        )
    zarr_array.compute(optimize_graph=False)

if __name__ == "__main__":
    main()

This is just an example that shows the issue. In this case I expect the job to be hunging, waiting for a GPU worker. Anyway the job is completed and the print appears on the screen.
If I change the second dask.annotate to GPU, the job waits forever.
Did I misunderstand how annotations work or is it bug?
Environment:

Dask version: 2022.9.1
Python version: 3.8.13
Operating System: Ubuntu 20.0.4
Install method (conda, pip, source):  conda

Thanks for the report and the nice example @mdrio (and sorry for the slow response). I see you're using optimize_graph=False, so it seems like you have likely already run into https://github.com/dask/dask/issues/7036 .
Unfortunately, it looks to me like you've come across another place where we can inadvertently optimize out task annotations! In dask.array.store there is a manual optimization step which is not able to be turned off:
https://github.com/dask/dask/blob/05e2db30395a812b3ab58a1a5a55099be10d772c/dask/array/core.py#L1168-L1172
The best fix for this (short of fixing #7036) is probably to complete https://github.com/dask/dask/issues/9381, which would allow blockwise annotations to be properly transmitted, and would generally use less custom logic in store.
In the meantime, you may be able to work around this behavior by deliberately introducing a persist() between store and your GPU operations:
zeros = da.zeros(10)
with dask.annotate(resources={"GPU": 1}):
    res = zeros.map_blocks(test_gpu, meta=np.array(()))
res = res.persist(optimize_graph=False)

with dask.annotate(resources={"CPU": 1}):
    zarr_array = da.to_zarr(
        res,
        "/tmp/test.zarr",
        overwrite=True,
        return_stored=True,
    )
zarr_array.compute(optimize_graph=False)

(though I should note that the above is pretty hacky)

Hi, I'll try the workaround ASAP, thanks!


Problem with automatically fetching

Hi Guy,
first of all I want to thank You for Your great work. I'm trying to use the fetch feature of the module and it didn't work for me at all. The resolvedResponse is always the same as before. I'm using v0.3.1
Than I tried the https://github.com/guylabs/angular-spring-data-rest-sample. The sample about automatic link fetching delivered a lot of 404s in the chromes console.
I have created a fork for the example with working parent structure and a pull request in the angular-spring-data-rest-sample repository so You can verify my problem.
I have also looked at the js-code and I'm almost sure that the problem is in the fetch function and the usage of the $http without resolving the promise.
Hope this can help You.
BR,
Shari

Hi Shari,
thanks for the pull request and for reporting the issue. I'll have a look at the beginning of next week as I now do not have the time for that. I hope this is ok for you.
I'll come back to you as soon as I have found the issue.
Thanks and regards,
Guy

Hi Shari,
well the problem about the 404's is that the categories doesn't have any parent, so the link to the parent returns a 404 and that is as Spring Data REST defines it.
I also checked out your branch and ran it, but there I don't see any issue in the sample project. Can you please elaborate more on this? And what do you mean that the "resolvedResponse" is always the same? Which response do you mean? The one from the fetch function or the one from the main request?
And about the statement that the promise isn't resolved: do you mean the success function is not called properly or is not good?
Regards,
Guy

Hi Guy,
the problem with the example is, that it doesn't prove that the automatic link fetching is working, because the parents are not being found (404s) and therefor the $scope.categories can not be extended with the parent data.
resolvedResponse is the returned data in file automatic-link-fetching.html, line 27-28. So I would say the response of the main request ( SpringDataRestAdapter.processWithPromise )
"Not resolved promise" was maybe not the right expression :) What I mean is that:
processDataWithPromise is being resolved without waiting/resolving the result of the $http promise called in the fetch function. Let me try to write down the call stack:

processWithPromise
processData
fetchFunktion
$http makes the get
fetchFunktion returns
processData returns data (the $http.get is not ready yet!)
processWithPromise resolves the data returned from the processData (without the information that should be fetched)
$http.get is ready, but too late because the processWithPromise has already returned/resolved the data to the caller

You can easily prove that by setting breakpoints in lines:
93  "data[key] = recursive ? processData(responseData, ..."
and 303 "deferred.resolve(processedData);"
of the angular-spring-data-rest-provider.js
Regards,
Shari

Hi Shari,
ok now I see your problem. Ok I'll need to rewrite some things such that the caller gets the proper resolved response. Thanks for catching this issue! I'll work on it as soon as possible and provide a new release which fixes this issue.
Thanks and regards,
Guy

Hi Shari,
I just committed the changes needed to the master branch. The sample now works with your pull request. You just need to exchange the processWithPromise function with the process function as now the SpringDataRestAdapter has just the process method which is able to handle promises and returns promises.
Can you please verify the functionality? I still need to add some more tests and update the documentation, but when everything is working as you need it, I will release a new version of it.
Thanks a lot and regards,
Guy

Nice work. I can confirm that the fork is working with this version. I can check tomorrow on a bigger project if everything is OK.
Thanks again for the quick fixing :+1:
As I can see, that caused a bigger refactoring :)

Thanks and I'm glad I could help. Now the whole promises are much more cleaner and it's done the right way ;). Ok just come back here when you tested it and then I can do a new release.
And yes that was a bigger refactoring ;)

I changed some more things again including the tests and some other things. It should still work as expected. But can you test it once again if you don't mind?

sure. No problem. But tomorrow. I'm done for today :)

My tests went fine.
Thanx again!

Hi Shari,
I just released 0.4.0 with the changes you tested. I hope now everything runs as expected.
Thanks again for finding the issue.
Regards,
Guy


[$500]  Chat – Message draft created Offline disappears while go back Online and refresh page

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number: 1.4.26-1
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:
Action Performed:

Go to https://staging.new.expensify.com/
Log in
Go Offline
Open any chat and draft a message in it
Go back Online (not focus on the chat) refresh the page

Expected Result:
The conversation is still displayed to the top of LHN (maintaining the same drafted status)
The drafted message is still displayed in the compose box
Actual Result:
The conversation is not displayed to the top of LHN (not maintaining the same drafted status)
The drafted message is not displayed in the compose box
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android: Native
[ ] Android: mWeb Chrome
[ ] iOS: Native
[ ] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[ ] MacOS: Desktop

Screenshots/Videos
Add any screenshot/video evidence

https://github.com/Expensify/App/assets/78819774/f2f08838-812b-429d-b102-153c9d5976d4
View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01169b0346fc6a15b0
Upwork Job ID:<PHONE_NUMBER>283096576
Last Price Increase: 2024-01-24
Automatic offers:

situchan | Contributor | 28129739

@alitoshmatov - can you review and comment on the proposal above?

Not sure what I am doing wrong, but still not reproducible on me
https://github.com/Expensify/App/assets/59907218/c652f4a9-4ebe-4396-b0b3-57ecb20558f6

I reproduced it on desktop application but, I don't think refreshing is expected behavior on desktop
https://github.com/Expensify/App/assets/59907218/34feff59-4647-485d-b62f-2f8f97575cd8

Yes I was able to reproduce it on staging, still curious why it wasn't reproducible on local testing. Let me do some research on this issue then.

@ZhenjaHorbach just to be 100% sure can you retest this issue on the latest main. If you manage to reproduce it. I will ask for other c+ help and reassign if they can also reproduce

I reproduced with very simple step: (need to refresh quickly)

Open any chat and draft message
Quickly refresh app

https://github.com/Expensify/App/assets/108292595/735bc174-f849-4feb-87e1-065894fb4c1c

And another step: (no need quick action to refresh)

Open any chat and draft message
Open Settings page
Refresh

https://github.com/Expensify/App/assets/108292595/59c7c614-347b-48da-8e26-6bb3ac59f769
(both steps don't require offline/online switch)

@situchan Will you be able to take it over?

@situchan Will you be able to take it over?

sure if you want to

That would be great.
@anmurali can you reassign this issue to @situchan

Issue not reproducible during KI retests. (First week)

@ZhenjaHorbach thanks for the proposal.

The main problem with this issue is that when we reload the page in this state by default we have reportID === 0
As a result, we can't get any text value for Composer

Can you please share permalink which explains your RCA?
Also, please confirm that there's no side effect from your solution.

@ZhenjaHorbach thanks. The root cause is correct.
So the solution is to call updateComment when reportID becomes valid.
Isn't it better to render SilentCommentUpdater conditionally like this?
            isValidReportID && <SilentCommentUpdater
                reportID={reportID}
                report={report}
                value={value}
                updateComment={updateComment}
                commentRef={commentRef}
            />

This will trigger updateComment automatically on mount of this component

ok if you think it's better, please update proposal accordingly

@ZhenjaHorbach's proposal looks good to me. Both solutions are fine but I prefer alternative one.
🎀 👀 🎀 C+ reviewed

Payment not due for another 4 days but I will be OOO so I have reassigned for payment

Sounds good! @situchan please complete the checklist so we can prep to issue payment next week.

Not able to find exact offending PR as Report screen was refactored several times (mainly for performance improvement).
I think this bug existed for a while.
We can skip regression test as caught by QA team, assuming this case already exists in TestRail.

BZ checklist is all set. All set to issue payment tomorrow.

@ZhenjaHorbach $500 sent and contract ended!

@situchan $500 sent and contract ended!

All set. Thanks everyone!


.gitmodules: update submodules

This PR updates the submodule URLs and syncs the Nerpa project with those submodules' most recent commits. The goal is to fix current issues in the installation process. It also includes changes in the installation script and p4info2ddlog dependency.

I will merge this


[SnapshotHelper.swift] Simulator name contains "Clone X of " in screenshots

New Issue Checklist

[x] Updated fastlane to the latest version
[x] I read the Contribution Guidelines
[x] I read docs.fastlane.tools
[x] I searched for existing GitHub issues

Issue Description

When running parallelized UI Tests on concurrent devices, the simulator name contains "Clone X of " inside the screenshot files. This messes up with the ordering of the screenshots.
Command executed

fastlane snapshot
Complete output when running fastlane, including the stack trace and command used

[14:13:52]: Copying '/Users/vagrant/git/fastlane/screenshots/de-DE/Clone 1 of iPad Pro (12.9-inch) (3rd generation)-Authentication - Login Password.png'...
[14:13:52]: Copying '/Users/vagrant/git/fastlane/screenshots/de-DE/Clone 2 of iPad Pro (12.9-inch) (3rd generation)-TaskChain - Creation Empty.png'...
[14:13:52]: Copying '/Users/vagrant/git/fastlane/screenshots/de-DE/Clone 1 of iPad Pro (12.9-inch) (3rd generation)-1. GymFeed - Tasks.png'...
[14:13:52]: Copying '/Users/vagrant/git/fastlane/screenshots/de-DE/Clone 1 of iPad Pro (12.9-inch) (3rd generation)-Member - Dashboard GDPR.png'...
[14:13:52]: Copying '/Users/vagrant/git/fastlane/screenshots/de-DE/Clone 2 of iPad Pro (12.9-inch) (3rd generation)-7. TaskChain - Creation Trigger.png'...
[14:13:52]: Copying '/Users/vagrant/git/fastlane/screenshots/de-DE/Clone 2 of iPad Pro (12.9-inch) (3rd generation)-6. TaskChain - Creation Filled.png'...
[14:13:52]: Copying '/Users/vagrant/git/fastlane/screenshots/de-DE/Clone 2 of iPad Pro (12.9-inch) (3rd generation)-TaskChain - Offline.png'...
[14:13:52]: Copying '/Users/vagrant/git/fastlane/screenshots/de-DE/Clone 1 of iPad Pro (12.9-inch) (3rd generation)-Authentication - Login.png'...
[14:13:52]: Copying '/Users/vagrant/git/fastlane/screenshots/de-DE/Clone 2 of iPad Pro (12.9-inch) (3rd generation)-3. TaskChain - Templates.png'...
[14:13:52]: Copying '/Users/vagrant/git/fastlane/screenshots/de-DE/Clone 1 of iPad Pro (12.9-inch) (3rd generation)-GymFeed - Empty.png'...
[14:13:52]: Copying '/Users/vagrant/git/fastlane/screenshots/de-DE/Clone 1 of iPad Pro (12.9-inch) (3rd generation)-Authentication - Wrong Password.png'...
[14:13:52]: Copying '/Users/vagrant/git/fastlane/screenshots/de-DE/Clone 2 of iPad Pro (12.9-inch) (3rd generation)-TaskChain - Empty Templates.png'...
[14:13:52]: Copying '/Users/vagrant/git/fastlane/screenshots/de-DE/Clone 2 of iPad Pro (12.9-inch) (3rd generation)-5. TaskChain - Assign Members.png'...
[14:13:52]: Copying '/Users/vagrant/git/fastlane/screenshots/de-DE/Clone 1 of iPad Pro (12.9-inch) (3rd generation)-Authentication - Login Email.png'...
[14:13:52]: Copying '/Users/vagrant/git/fastlane/screenshots/de-DE/Clone 1 of iPad Pro (12.9-inch) (3rd generation)-9. Member - Dashboard.png'...
[14:13:53]: Copying '/Users/vagrant/git/fastlane/screenshots/de-DE/Clone 1 of iPad Pro (12.9-inch) (3rd generation)-GymFeed - Offline.png'...
[14:13:53]: Copying '/Users/vagrant/git/fastlane/screenshots/de-DE/Clone 1 of iPad Pro (12.9-inch) (3rd generation)-8. Member - Search Members.png'...
[14:13:53]: Copying '/Users/vagrant/git/fastlane/screenshots/de-DE/Clone 2 of iPad Pro (12.9-inch) (3rd generation)-4. TaskChain - Overview.png'...
[14:13:53]: Copying '/Users/vagrant/git/fastlane/screenshots/de-DE/Clone 1 of iPad Pro (12.9-inch) (3rd generation)-0. Authentication - Stay Logged In.png'...
[14:13:53]: Copying '/Users/vagrant/git/fastlane/screenshots/de-DE/Clone 1 of iPad Pro (12.9-inch) (3rd generation)-2. GymFeed - Snooze Task.png'...
[14:13:53]: Copying '/Users/vagrant/git/fastlane/screenshots/de-DE/Clone 1 of iPad Pro (12.9-inch) (3rd generation)-Member - Search Empty.png'...

Oh wow.
Does Xcode/whatever is running these tests add Clone X of  automatically as soon as it detects the same device being run multiple times?

Yes, only when enabling parallelization.

BTW, I wouldn't say that's a feature but a bug, right? 🤔

🤷♀ (It took it as supporting a new thing with parallel execution, but you are probably right)

I already made a PR (https://github.com/fastlane/fastlane/pull/14895) 👍
If you got the time that'd be awesome to have it reviewed/merged 💪
(we would like to use parallelization internally in my company to make screenshot automation even faster!)

PR https://github.com/fastlane/fastlane/pull/14895 got merged, and it was already part of release fastlane 2.126.0 - so this should now be fixed!


Delete files on explorer with press key Delete

VSCode Version: 1.36.0
OS Version: Deepin 15.9.3

Steps to Reproduce:

Select any file at explorer and press delete key, for delete file or files
Result: vscode start a find folders and files with delete match.

Does this issue occur when all extensions are disabled?: Yes

/duplicate of #76514 and fixed in the upcoming recovery release.


Error from configparser when setting up new computer

Running ofxclient for the first time, setting up accounts. Computer is Windows 10 with 64-bit Python 3.7.6 installed via miniconda, and ofxclient 2.0.3 installed via pip.
After entering user/password for a bank, I got the following traceback:
password>
Traceback (most recent call last):
  File "c:\programdata\miniconda2\envs\py3\lib\runpy.py", line 193, in _run_module_as_main
    "__main__", mod_spec)
  File "c:\programdata\miniconda2\envs\py3\lib\runpy.py", line 85, in _run_code
    exec(code, run_globals)
  File "C:\ProgramData\Miniconda2\envs\py3\Scripts\ofxclient.exe\__main__.py", line 7, in <module>
  File "c:\programdata\miniconda2\envs\py3\lib\site-packages\ofxclient\cli.py", line 63, in run
    main_menu(args)
  File "c:\programdata\miniconda2\envs\py3\lib\site-packages\ofxclient\cli.py", line 83, in main_menu
    add_account_menu(args)
  File "c:\programdata\miniconda2\envs\py3\lib\site-packages\ofxclient\cli.py", line 130, in add_account_menu
    if login_check_menu(bank, args):
  File "c:\programdata\miniconda2\envs\py3\lib\site-packages\ofxclient\cli.py", line 219, in login_check_menu
    GlobalConfig.add_account(a)
  File "c:\programdata\miniconda2\envs\py3\lib\site-packages\ofxclient\config.py", line 244, in add_account
    self.parser.set(section_id, key, section_items[str(key)])   # JCG
  File "c:\programdata\miniconda2\envs\py3\lib\site-packages\ofxclient\config.py", line 122, in set
    ConfigParser.set(self, section, option, value)
  File "c:\programdata\miniconda2\envs\py3\lib\configparser.py", line 1197, in set
    self._validate_value_types(option=option, value=value)
  File "c:\programdata\miniconda2\envs\py3\lib\configparser.py", line 1182, in _validate_value_types
    raise TypeError("option values must be strings")
TypeError: option values must be strings

I don't really understand this bug, but found a brute-force fix, by changing line 244 in config.py:
was:
self.parser.set(section_id, key, section_items[key])
is:
self.parser.set(section_id, key, str(section_items[key]))
Everything seems to work OK now.

Oops, I see that this issue has been discussed and resolved in the unreleased version 2.04. I had not found this before posting. Please feel free to delete this issue.


When making a custom block I found a BUG!

When making a mod and activated on it..then... the type of bug is piston and I haven't do something wrong and... please help me

Also when you change the shape of a custom block it will invisble and if placed it will crash!

@zhouwei Check it.

@zhouwei This already now sorry.


Store pluvial and fluvial protection information in PlayerRound table

The housegroup table contains information that is continuously updated (and overwritten) during a round. Therefore, information about the specifics of the house protection and community protection of an individual player is not available per round. Therefore, this information has to be stored in the playerround table:

pluvial_base_protection to indicate the pluvial base community protection of the player's house without news effects
fluvial_base_protection to indicate the fluvial base community protection of the player's house without news effects
pluvial_house_delta to indicate the extra pluvial house protection of the player's house based on measures
fluvial_house_delta to indicate the extra fluvial house protection of the player's house based on measures
pluvial_community_delta to indicate the change in community protection for the player's house based on news effects
fluvial_community_delta to indicate the change in community protection for the player's house based on news effects

From these 6 values, four totals can be calculated:

pluvial_community_protection = pluvial_base_protection + pluvial_community_delta
fluvial_community_protection = fluvial_base_protection + fluvial_community_delta
pluvial_house_protection = pluvial_base_protection + pluvial_community_delta + pluvial_house_delta
fluvial_house_protection = fluvial_base_protection + fluvial_community_delta + fluvial_house_delta

Combined with the groupround.pluvial_flood_intensity and groupround.fluvial_flood_intensity, the community damage and house damage can be calculated as the difference of the intensity and the protection levels.

Also delete the following fields:

pluvial_damage
fluvial_damage
since the damage has to be calculated for community and house separately, based on the above calculations. Since these calculations can be easily repeated, the result does not have to be stored in the database.

Fields have been added to the database.


[Feature Request]: add one checkbox in options for "show hidden folders"

The tool is already awesome, but I lack a very small feature that I hope is easy to add: the "show hidden folders" checkbox that is available next to the "hide known extensions"  in the standard options in explorer;
I am more a Linux guy and not able to to the coding myself for Windows, so sorry I can't contribute the patch as I would otherwise try to.

It's a relatively easy addition, but I've been trying to avoid duplicating too much of what's already built in as a single click. The first two options in the WinSetView Options menu, "Show file extensions" and "Enable compact view in Windows 11", are arguably unnecessary because they fall into that category, but I feel strongly that file extensions should never being hidden in Windows and the default non-compact view in Windows 11 on non-tablet devices seemed silly.
Personally, I like to keep the hidden folders hidden (except AppData) as I rarely need to access them and, instead, I have a right-click item that will let me enable/disable the display of both hidden and system items very quickly.
I'll consider this request for a future update, but I have to clarify if you only need to see hidden items or also see system items (protected operating system files):

Also note that if you only need AppData unhidden, there's already a checkbox for that:

In the meantime, extract the attached reg file to WinSetView's AppData subfolder. Uncomment the last line if you also want to see items that have the System attribute set.
WinSetViewCustom.zip

Hi,
Thanks for your answer.
I manage the hosting service for our company, a software editor, and I like to have all our servers configured the same way. I also like when I connect to a customer's server to quickly configure it with all my usual tools and confs. My goal is to use the script version of you tool to enforce common settings to all servers and users, including file type associations, and/or to deploy my conf on any account I am given on a machine. I fully understand your concern about not duplicating existing controls, but my goal is to automatize as much as I can the enforcement of common settings. I would only use the GUI version once, and then apply the result everywhere.
Our app hides folders from users..... but maintenance agents need to access them, hence the need to show hidden folders but not system files.

Sounds good. The attached reg file in my previous reply should do the trick.

Thanks, I'll test it tomorrow at work.

Hi,
It works fine, so now I can use your tool and the additional reg conjointly to reach my goal
Thanks

Great! I'm not sure I was clear, but if you put the reg file in WinSetView's AppData subfolder, it will be applied automatically.

This option is now in the Options menu in version 2.97.


Bitbucket Server: system admin cannot unfurl if not a project admin

It seems a global admin was not capable of unfurling a link to a repository created by another user.
Actions:

Verify the behavior
If permission related, ask BbS team if any additional permission verification is necessary

The issue isn't reproducible with recent version of the plugin - 4.0.2. It must have been fixed in some intermediate release.


Action Menu

Would be nice if we can implement a basic interaction with Action Menu. It may be filling a form and then requesting a credential. Or any other idea that show some interactions.

We will address DIDComm UI changes in roots-react-native


Add missing details on SFTP regional service availability

Add missing details on SFTP regional service availability

@mabesignal : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@mabesignal : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@normesta, if you approve this change, the "en-us" should be removed from the new URL before the PR is merged. Thanks.

@mabesignal : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@normesta, if you approve this change, the "en-us" should be removed from the new URL before the PR is merged. Thanks.

Good catch thanks! just fixed that

As this appears to be a statement of official support, I'd ask @yashluna to review the proposed update. Yes, ultimately, we would want to remove "en-us" from all links. @mabesignal - if you've already been working with our product team on this change, then thank you for the update. Going forward, since you are internal, pls use the "azure-docs-pr" repo instead of the "azure-docs" repo. "azure-docs" repo is for customers and contributors external to Microsoft. Thx! I'll defer to @yashluna on the proposed change.

Do we add explicit callouts for all Blob Storage features that are available globally? If not, is there a reason we would make the exception for SFTP?

Come to think of it no we do not. Global availability is implied unless otherwise stated in a note. @mabesignal sorry - I didn't look carefully enough at this PR. As consistency guideline, we only call out availability in cases where the availability is not global. Then, we would add something like "Is available only in blah blah and blah regions". Also, as an aside (Blob Storage with a hierarchical namespace is the same as Azure Data Lake Storage Gen2. This note somehow implies that they are separate services.  For those reasons, we'll close this PR. Thank you for your contribution though.
#please-close

Come to think of it no we do not. Global availability is implied unless otherwise stated in a note. @mabesignal sorry - I didn't look carefully enough at this PR. As consistency guideline, we only call out availability in cases where the availability is not global. Then, we would add something like "Is available only in blah blah and blah regions". Also, as an aside (Blob Storage with a hierarchical namespace is the same as Azure Data Lake Storage Gen2. This note somehow implies that they are separate services. For those reasons, we'll close this PR. Thank you for your contribution though.
#please-close

No worries #normesta -- If this isn't suited to be called out in our documentation, is there a process to add SFTP regional availability onto https://azure.microsoft.com/global-infrastructure/services/?products=storage so it is clear to our customers?

Come to think of it no we do not. Global availability is implied unless otherwise stated in a note. @mabesignal sorry - I didn't look carefully enough at this PR. As consistency guideline, we only call out availability in cases where the availability is not global. Then, we would add something like "Is available only in blah blah and blah regions". Also, as an aside (Blob Storage with a hierarchical namespace is the same as Azure Data Lake Storage Gen2. This note somehow implies that they are separate services. For those reasons, we'll close this PR. Thank you for your contribution though.
#please-close

No worries @normesta -- If this isn't suited to be called out in our documentation, is there a process to add SFTP to our Products available by region https://azure.microsoft.com/global-infrastructure/services/?products=storage so it is clear to our customers?

I wish there was. There is no "Features available by region" equivalent to that page. I'd love to see one though. Our team isn't empowered to create such a page and I'm not totally sure who to ping in order to make that suggestion. Our current pattern in docs pages (such as the SFTP docs pages) is to assume availability and include that information only in cases where there is limited availability. Regional information typically appears only in content that supports a preview feature. By GA, most features are available globally.


pass_thru option

I want caddy to run a command for updating an html file every time I access that page. My current Caddyfile looks like this::
example.com {
  root * /var/www/{host}
  route /stats {
    exec command-to-update-html-file-at /var/www/example.com/stats/index.html
  }
  file_server
}

When I access example.com/stats the command is executed but caddy responds with {"status":"success"}. Only accessing example.com/stats/index.html directly shows the generated html.
Is there (or can you add) an option to not respond directly but continue to the file_server directive?

@abiosoft I don't know why GH didn't auto-close this issue, when you merged #19 , but I believe that you can close this as complete :+1:


[WIP]:  Add web ui for addax

Contact Details（联系人）
<EMAIL_ADDRESS>What happened?
should I add a web ui for addax ?
should contains below feature:
api for submit job and query status by http rest api
web-ui to management jobs
Version
4.0.6 (Default)
OS Type
No response
Java JDK Version
Oracle JDK 1.8.0
Relevant log output
No response

The project addax-admin  is addax-base web ui mangement, it is still in development.
Of course, there are many excellent datax-based web management tools in the community, and it is also suitable for addax

Great I will check it

That's a good idea , May be you can develop it base on datax-web?


UTC timestamps for myo data?

Hi,
Are the timestamps for the data UTC?
If not, is there a way I could get UTC timestamps?

Hi,
There is timestamp that you can convert in "datetime" format with pandas.to_datetime(timestamp). You could easily then get the UTC time from this "datetime" value.


Optimizer: Replace the MandatoryCombine pass with a Simplification pass, which is implemented in Swift

The Swift Simplification pass can do more than the old MandatoryCombine pass: simplification of more instruction types and dead code elimination.
The result is a better -Onone performance while still keeping debug info consistent.
Currently following code patterns are simplified:

struct -> struct_extract
enum -> unchecked_enum_data
partial_apply -> apply
br to a 1:1 related block
cond_br with a constant condition
isConcrete and is_same_metadata builtins

More simplifications can be added in the future.
For details see the commit messages.
rdar://96708429
rdar://104562580

@swift-ci test

@swift-ci benchmark

@swift-ci test

@swift-ci benchmark

The strategy sounds great, as long as we can easily tell apart

Yes, we can add as many different simplification passes as we like.

canonicalization required for diagnostics

not done yet in this PR

canonicalization that preserves debug info, but not required for diagnostics

the onone-simplification and late-onone-simplification passes

simplifications that we want to happen at a few places in the -O pipeline

the simplification pass

@swift-ci test

@swift-ci test

@swift-ci test

@swift-ci smoke test


Add getGroupByFunction method to schema and view

This would return a Function similar to:
element -> element.getProperty("property1");

this could then be used in a groupingBy collector, e.g:
Collectors.groupingBy(groupByFunction);

where the function groups by all properties that are in the groupBy array in the schema or view.
All groupBy property values would need to be classes that have an implementation of hashCode and equals.

Merged into develop.


ENH: Add method to import selected files into DICOM browser

In some cases, it is necessary to load individual files and not an entire folder into the DICOM database.

:pray:


build failure: build/release/src/build.c: In function 'fixup_length_block'

Ok, another issue. :)
--- snip ---
build/release/src/build.c: In function 'fixup_length_block':
build/release/src/build.c:50:24: error: implicit declaration of function '__bswap16'; did you mean '__bswap_16'? [-Werror=implicit-function-declaration]
                 word = __bswap16(word) + size;
                        ^~~~~~~~~
                        __bswap_16
build/release/src/build.c:64:25: error: implicit declaration of function '__bswap32'; did you mean '__bswap_32'? [-Werror=implicit-function-declaration]
                 dword = __bswap32(dword) + size;
                         ^~~~~~~~~
                         __bswap_32
build/release/src/build.c:77:25: error: implicit declaration of function '__bswap64'; did you mean '__bswap_64'? [-Werror=implicit-function-declaration]
                 qword = __bswap64(qword) + size;
                         ^~~~~~~~~
                         __bswap_64
cc1: all warnings being treated as errors
scons: *** [build/release/src/build.o] Error 1
scons: building terminated because of errors.
--- snip ---

Try to pull on master and build again. I added #include <endian.h> to build.c in hopes that it addresses your issue. __bswap* functions are also supposed to be gcc builtins. Depending on your version of gcc, that may not be the case. It builds for me on Debian 9 and on Windows under Cygwin. Also, it builds under docker with the dockerfile included in the repository. Let me know if you're still having issues. I may need to change them to __builtin_bswap*

@zznop yes, sorry. due to time pressure here i forgot to add few more details like os, gcc ver, etc.: so've i used:

archlinux (kernel 4.18.16)
gcc: 8.2.1
glibc: 2.28
scons: 3.0.1
I've managed to add a temporary/dirty fix: https://github.com/BlackArch/blackarch/blob/feadc0bdd58f330c29d3d67c2e15158ef8c4e0f5/packages/flyr/PKGBUILD#L27 so i guess for newer versions you will need '_bswap*'. in the meanwhile i will use '#include <endian.h>'  in build.c and see if it solved that issue.

I’ll build a BlackArch Linux VM this week sometime and look into a fix that keeps support for Debian/Ubuntu. This project is under rapid development so I’d hate for you to have to go through the trouble for each release. I can probably check if __bswap_* functions are defined and then typedef the __bswap* functions (if including endian.h doesn’t do the trick on Arch). I’m excited to be apart of your distro!

I’ll build a BlackArch Linux VM this week sometime and look into a fix that keeps support for Debian/Ubuntu. This project is under rapid development so I’d hate for you to have to go through the trouble for each release. I can probably check if __bswap_* functions are defined and then typedef the __bswap* functions (if including endian.h doesn’t do the trick on Arch). I’m excited to be apart of your distro!

Sounds good and thanks a lot! Unfortunately, #include <endian.h did not help, jfyi. Yes, typedef should help us. :)

same issue here, but changing __bswap* to __bswap_* immediately fixes the build issues.

ubuntu 18.04 (kernel 4.15.0-36)
gcc: 7.3.0
glibc: 2.27
scons: 3.0.1

was about to make a pull request but I saw it may just be an OS specific issue

I added some simple define lines in conversion.h where byteswap.h is included to handle this issue
//added fix to handle different OS byteswap defines
#ifndef __bswap16
#define __bswap16 __bswap_16
#endif
#ifndef __bswap32
#define __bswap32 __bswap_32
#endif
#ifndef __bswap64
#define __bswap64 __bswap_64
#endif

I believe this was resolved by #22. Please re-open it @noptrix if you have any issues on BlackArch.


Visual regression testing

As the components should be pure to comply with z-kit we can simply test visual regressions and browser support.
We can automate these tests with some tools.

Couldn't find tools that work nicely with the project so far. For now we are going with an nightmarejs approach, opening the demo and checking for the rendered elements.


New rule: warm when app cache is used in insecure sites

Firefox is deprecating it:
https://www.fxsitecompat.com/en-CA/docs/2018/support-for-application-cache-on-insecure-sites-has-been-deprecated/

This can probably be done as part of #30.

Closing in favor of https://github.com/webhintio/rfcs/issues/11


STORM-433: Give users visibility to the depth of queues at each bolt

This pull request adds a column to the executors table on the components page showing the average length of the tuple queue when the executor consumes a chunk.

@nathanmarz, @revans2, @d2r
Do we still want this? If so I'll upmerge and fix all the problems:

easy, I'll take care of this.
I can also monitor the batch-transfer-queue.
This one's trickier. It depends on what you mean by "thread-safe." They are certainly thread-safe in the sense that nothing will get corrupted. I've read the disruptor code for 2.10.1, and only reads are ever done by the additional code. They may be off by an amount if a write is done during, but it won't corrupt any values.

Do we still want this?
Yes, I think this would be a tremendous help to users while debugging "slowness" issues.

This is ready for another look.

Hi @knusbaum, it has been a while, and it looks like this needs an up-merge again.  It might also be good to remove changes from the Thrift-generated code that result in only time stamp changes.

@knusbaum : I see you closed this.  Are you planning to open a new PR for publishing these stats?  It would be a big help to us, we often wonder at various behaviors we witness from our users' topologies, and the only mechanism we have right now for getting visibility into the queue depths seems to be getting every topology owner to use a custom metrics consumer to publish the metrics which we would then need to provide fancy aggregation on top of.  Having it in the Storm UI and also in the API stats would be very very helpful.

I am preparing a patch for publishing in-backlog (receive-queue) and out-backlog (send-queue). I can see the average value of these metrics on UI over each time window period but only in executors section.  (No aggregation over component level etc) Also users may be interested in instant value of these metrics and I don't know how will I fit that into UI. any suggestions are welcome.

@abhishekagarwal87 : awesome news!
Any way you can post a screenshot of the UI you are currently proposing?  At least please do so with the PR when you send it.  That could help others to brainstorm how to put such values into the UI.  Maybe you're instead asking for suggestions on how to handle obtaining the instantaneous values?

I will do that Eric. I am using https://github.com/apache/storm/blob/master/storm-core/src/jvm/org/apache/storm/metric/internal/LatencyStatAndMetric.java to store the windowed values. It is easy to add the instantaneous values in the result map so that is not a problem. I will put a screenshot and the PR soon. May be that will clear the confusion.

@abhishekagarwal87 I am excited to see your screenshot as well. Also, I am curious as why you chose to use https://github.com/apache/storm/blob/master/storm-core/src/jvm/org/apache/storm/metric/internal/LatencyStatAndMetric.java over https://github.com/apache/storm/blob/master/storm-core/src/jvm/org/apache/storm/metric/internal/CountStatAndMetric.java?

Because we need average length of queue average over each time window. If you look at the LatencyStatAndMetric, it does exactly that. I record the queue lengths in each operation and return the average values with executor heartbeat.

Guys, follow up discussion is happening on #1406. Can you let me know your feedback there?


[9.x] Add 'hex' validation rule

This is a proposal of a single new hex validation rule that checks whether a string has all characters in range of a-f, A-F, 0-9. Second optional parameter is a prefix to add a simple way of handling html colours or literal hex values.
It's an implementation of the proposal https://github.com/laravel/framework/issues/9988 and also solution to a real problem i've had while working on a project.
Examples:
// Simple value
Validator::validate([
  'value' => 'abcdef123456'
], [
  'value' => 'hex'
]);

// Optional param - literal hex value
Validator::validate([
  'value' => '0x123'
], [
  'value' => 'hex:0x'
]);

// Optional param - HTML colour
Validator::validate([
  'value' => '#FFFFFF'
], [
  'value' => 'hex:#'
]);

This PR is also a followup to my previous https://github.com/laravel/framework/pull/41807. I agree that particular string helper might not have been the most frequently used method but a simple validation rule surely will be quite handy.

Not really sure it's a common need, since it's just a simple regexp validation rule, but at least some tests are needed.

Thanks for your pull request to Laravel!
Unfortunately, I'm going to delay merging this code for now. To preserve our ability to adequately maintain the framework, we need to be very careful regarding the amount of code we include.
If possible, please consider releasing your code as a package so that the community can still take advantage of your contributions!
If you feel absolutely certain that this code corrects a bug in the framework, please "@" mention me in a follow-up comment with further explanation so that GitHub will send me a notification of your response.


Fix demos deployment

Looks like some recent dependent package updates broke demos which in turns breaks the proper deployment of the docs.

I think the problem is the newest demo.
In particular the usage of fd2html_v in the render_table hfun seems to cause problems with the global and local variables. After that function is called all global variables from config.md and all local variables are cleared.


libvlc demo segfaults

First, than yous for the tutorials and the rust crate.
I am quite happy to see how well FLTK works with Rust in general. I thought that FLTK was dead after the Foundry ported Nuke to Qt. I haven't used it since the early 2000s...
I was particularly excited to take a look at combining Fltk and Vlc. Unfortuantely, I have run into some trouble. (not sure how this is working for anyone)
Running this on pop os 20.10 (basically latest version of ubuntu) I get the following error after pushing play:
 Compiling vlc-fltk v0.1.0 (/home/jgerber/src/3ps/fltk/demos/fltk-rs-demos/libvlc)
    Finished dev [unoptimized + debuginfo] target(s) in 0.70s
     Running `/home/jgerber/src/3ps/fltk/demos/fltk-rs-demos/target/debug/vlc-fltk`
../include/vlc_xlib.h:46:vlc_xlib_init: Xlib not initialized for threads.
This process is probably using LibVLC incorrectly.
Pass "--no-xlib" to libvlc_new() to fix this.
[00007f447c004740] egl_x11 gl error: Xlib not initialized for threads
../include/vlc_xlib.h:46:vlc_xlib_init: Xlib not initialized for threads.
This process is probably using LibVLC incorrectly.
Pass "--no-xlib" to libvlc_new() to fix this.
[00007f447c004740] glx gl error: Xlib not initialized for threads
../include/vlc_xlib.h:46:vlc_xlib_init: Xlib not initialized for threads.
This process is probably using LibVLC incorrectly.
Pass "--no-xlib" to libvlc_new() to fix this.
[00007f447c004740] egl_x11 gl error: Xlib not initialized for threads
[00007f447c011700] main filter error: Failed to create video converter
../include/vlc_xlib.h:46:vlc_xlib_init: Xlib not initialized for threads.
This process is probably using LibVLC incorrectly.
Pass "--no-xlib" to libvlc_new() to fix this.
[00007f447c004740] glx gl error: Xlib not initialized for threads
../include/vlc_xlib.h:46:vlc_xlib_init: Xlib not initialized for threads.
This process is probably using LibVLC incorrectly.
Pass "--no-xlib" to libvlc_new() to fix this.
[00007f447c004740] egl_x11 gl error: Xlib not initialized for threads
../include/vlc_xlib.h:46:vlc_xlib_init: Xlib not initialized for threads.
This process is probably using LibVLC incorrectly.
Pass "--no-xlib" to libvlc_new() to fix this.
[00007f448c079c90] vdpau_avcodec generic error: Xlib not initialized for threads
[00007f448c079c90] vdpau_avcodec generic error: Xlib is required for VDPAU
../include/vlc_xlib.h:46:vlc_xlib_init: Xlib not initialized for threads.
This process is probably using LibVLC incorrectly.
Pass "--no-xlib" to libvlc_new() to fix this.
[00007f447c004740] egl_x11 gl error: Xlib not initialized for threads
../include/vlc_xlib.h:46:vlc_xlib_init: Xlib not initialized for threads.
This process is probably using LibVLC incorrectly.
Pass "--no-xlib" to libvlc_new() to fix this.
[00007f447c004740] glx gl error: Xlib not initialized for threads
../include/vlc_xlib.h:46:vlc_xlib_init: Xlib not initialized for threads.
This process is probably using LibVLC incorrectly.
Pass "--no-xlib" to libvlc_new() to fix this.
[00007f447c004740] egl_x11 gl error: Xlib not initialized for threads
Segmentation fault (core dumped)
``

when i build the app, here is what is getting linked against:

linux-vdso.so.1 (0x00007ffdae4dc000)
libvlc.so.5 => /lib/x86_64-linux-gnu/libvlc.so.5 (0x00007f8433b92000)
libstdc++.so.6 => /lib/x86_64-linux-gnu/libstdc++.so.6 (0x00007f84339b1000)
libpthread.so.0 => /lib/x86_64-linux-gnu/libpthread.so.0 (0x00007f843398f000)
libX11.so.6 => /lib/x86_64-linux-gnu/libX11.so.6 (0x00007f8433851000)
libXext.so.6 => /lib/x86_64-linux-gnu/libXext.so.6 (0x00007f843383c000)
libXinerama.so.1 => /lib/x86_64-linux-gnu/libXinerama.so.1 (0x00007f8433837000)
libXcursor.so.1 => /lib/x86_64-linux-gnu/libXcursor.so.1 (0x00007f8433828000)
libXrender.so.1 => /lib/x86_64-linux-gnu/libXrender.so.1 (0x00007f843361e000)
libXfixes.so.3 => /lib/x86_64-linux-gnu/libXfixes.so.3 (0x00007f8433616000)
libXft.so.2 => /lib/x86_64-linux-gnu/libXft.so.2 (0x00007f84335fd000)
libfontconfig.so.1 => /lib/x86_64-linux-gnu/libfontconfig.so.1 (0x00007f84335b6000)
libGL.so.1 => /lib/x86_64-linux-gnu/libGL.so.1 (0x00007f843352e000)
libGLU.so.1 => /lib/x86_64-linux-gnu/libGLU.so.1 (0x00007f84334ba000)
libdl.so.2 => /lib/x86_64-linux-gnu/libdl.so.2 (0x00007f84334b4000)
libgcc_s.so.1 => /lib/x86_64-linux-gnu/libgcc_s.so.1 (0x00007f8433499000)
libc.so.6 => /lib/x86_64-linux-gnu/libc.so.6 (0x00007f84332af000)
/lib64/ld-linux-x86-64.so.2 (0x00007f8433d34000)
libm.so.6 => /lib/x86_64-linux-gnu/libm.so.6 (0x00007f8433160000)
libvlccore.so.9 => /lib/x86_64-linux-gnu/libvlccore.so.9 (0x00007f8433050000)
libxcb.so.1 => /lib/x86_64-linux-gnu/libxcb.so.1 (0x00007f8433024000)
libfreetype.so.6 => /lib/x86_64-linux-gnu/libfreetype.so.6 (0x00007f8432f61000)
libexpat.so.1 => /lib/x86_64-linux-gnu/libexpat.so.1 (0x00007f8432f33000)
libuuid.so.1 => /lib/x86_64-linux-gnu/libuuid.so.1 (0x00007f8432f2a000)
libGLdispatch.so.0 => /lib/x86_64-linux-gnu/libGLdispatch.so.0 (0x00007f8432e72000)
libGLX.so.0 => /lib/x86_64-linux-gnu/libGLX.so.0 (0x00007f8432e3c000)
libidn.so.11 => /lib/x86_64-linux-gnu/libidn.so.11 (0x00007f8432e07000)
libdbus-1.so.3 => /lib/x86_64-linux-gnu/libdbus-1.so.3 (0x00007f8432db5000)
libXau.so.6 => /lib/x86_64-linux-gnu/libXau.so.6 (0x00007f8432daf000)
libXdmcp.so.6 => /lib/x86_64-linux-gnu/libXdmcp.so.6 (0x00007f8432da7000)
libpng16.so.16 => /lib/x86_64-linux-gnu/libpng16.so.16 (0x00007f8432d6c000)
libz.so.1 => /lib/x86_64-linux-gnu/libz.so.1 (0x00007f8432d4f000)
libbrotlidec.so.1 => /lib/x86_64-linux-gnu/libbrotlidec.so.1 (0x00007f8432d41000)
libsystemd.so.0 => /lib/x86_64-linux-gnu/libsystemd.so.0 (0x00007f8432c8d000)
libbsd.so.0 => /lib/x86_64-linux-gnu/libbsd.so.0 (0x00007f8432c73000)
libbrotlicommon.so.1 => /lib/x86_64-linux-gnu/libbrotlicommon.so.1 (0x00007f8432c4e000)
librt.so.1 => /lib/x86_64-linux-gnu/librt.so.1 (0x00007f8432c43000)
liblzma.so.5 => /lib/x86_64-linux-gnu/liblzma.so.5 (0x00007f8432c1a000)
libzstd.so.1 => /lib/x86_64-linux-gnu/libzstd.so.1 (0x00007f8432b4a000)
liblz4.so.1 => /lib/x86_64-linux-gnu/liblz4.so.1 (0x00007f8432b29000)
libgcrypt.so.20 => /lib/x86_64-linux-gnu/libgcrypt.so.20 (0x00007f8432a0b000)
libgpg-error.so.0 => /lib/x86_64-linux-gnu/libgpg-error.so.0 (0x00007f84329e2000)
Any ideas?

Fixed it by adding x11 dependency and calling
use x11::xlib;
...
fn main() {
unsafe { xlib::XinitThreads();};
let app = ...
}

Hi
Thank you for your nice words.
I'm glad it's fixed. Could it be the version of libvlc-dev?

I had this same issue, but I added args.push("--no-xlib".to_string()); in my code.
here is my cargo:
fltk = "1.1.2"
vlc-rs = { git = "https://github.com/garkimasera/vlc-rs.git" }

I get whatever version git pulls in, which should be the same as you (last update was 2 years ago)


missing requirement.txt

Hello,
I think it would be great to add a docker or a list of package on which the code works.

+1


Remove logger config #238

Coverage decreased (-1.35%) when pulling c2fe66b5dbbddab5c1cf47be4f58ca9f93ba43c2 on akkie:logger into ee80b8178beae12dc844a7678edcf97cdc737cc4 on mohiva:master.

Coverage decreased (-1.35%) when pulling 42c5e4939c2dd381b099a3e5555773c79846ba5c on akkie:logger into ee80b8178beae12dc844a7678edcf97cdc737cc4 on mohiva:master.

Coverage remained the same when pulling 13f95dc1c15d439df61705ce097adcda00da4e5b on akkie:logger into ee80b8178beae12dc844a7678edcf97cdc737cc4 on mohiva:master.

Coverage remained the same when pulling 13a0b72fffee9af354a501a60041eaebcfb39373 on akkie:logger into ee80b8178beae12dc844a7678edcf97cdc737cc4 on mohiva:master.


Open multiple files from fuzzy finder

Hi guys,
from another IDE I am using I like the feature to have multiple files opened at one time. This works by pressing Shift and Arrow up/down to mark them and then simply Enter to open. A new tab for each file will then be opened.
Regards Benedikt

See https://github.com/atom/fuzzy-finder/issues/70

Thanks @samrayner! Closing this out in favor of https://github.com/atom/fuzzy-finder/issues/70.


Would it make sense to default :retry_log_level to :warning?

I'm aware https://github.com/wojtekmach/req/issues/357, but while that's in the process of consideration, would it make sense to default :retry_log_level to :warning?
In my view, transient networking issues are expected, and with the default retry behaviour recoverable. What should be an error is if the retries eventually failing, not each individual retry step.

Good call, a PR would be appreciated.


Issue with BrowserAnimationsModule

Hi all,
This error is coming up on compilation after importing BrowserAnimationsModule, compilation is failing due to this.
ERROR in node_modules/@angular/platform-browser/animations/src/module.d.ts(4,1): error TS1128: Declaration or statement expected.

I am using
Angular CLI: 1.5.0
Node: 9.0.0
OS: linux x64
Angular: 5.0.1
Please light some ideas into this.
Thanks,
Uttahb

A typescript error message.. What version of typescript are you using? Try to upgrate to a version greater than 2.4.2 if you're using a previous version.

Hi julianobrasil,
Thanks for the reply. I tried updating ts to version 2.5.3
now its showing a warning too
<EMAIL_ADDRESS>requires<EMAIL_ADDRESS><2.5.0' but 2.5.3 was found instead.
also the issue with browserAnimationModule is still there. Can you specify which version of typescript
solves the issue
thanks,
uttahb

The warning is not a problem. It generally works with it (I saw it over here in my projects too). Could you post your complete package.json?

thanks again for quick reply.
this is my package.json
{
"name": "myproject",
"version": "0.0.0",
"license": "MIT",
"scripts": {
"ng": "ng",
"start": "ng serve",
"build": "ng build",
"test": "ng test",
"lint": "ng lint",
"e2e": "ng e2e"
},
"private": true,
"dependencies": {
"@angular/animations": "^5.0.1",
"@angular/cdk": "^5.0.0-rc0",
"@angular/common": "^5.0.0",
"@angular/compiler": "^5.0.0",
"@angular/core": "^5.0.0",
"@angular/flex-layout": "^2.0.0-beta.10-4905443",
"@angular/forms": "^5.0.0",
"@angular/http": "^5.0.0",
"@angular/material": "^5.0.0-rc0",
"@angular/platform-browser": "^5.0.0",
"@angular/platform-browser-dynamic": "^5.0.0",
"@angular/router": "^5.0.0",
"angular2-swiper": "^0.8.1",
"core-js": "^2.4.1",
"hammerjs": "^2.0.8",
"rxjs": "^5.5.2",
"zone.js": "^0.8.14"
},
"devDependencies": {
"@angular/cli": "1.5.0",
"@angular/compiler-cli": "^5.0.0",
"@angular/language-service": "^5.0.0",
"@types/jasmine": "~2.5.53",
"@types/jasminewd2": "~2.0.2",
"@types/node": "~6.0.60",
"codelyzer": "~3.2.0",
"jasmine-core": "~2.6.2",
"jasmine-spec-reporter": "~4.1.0",
"karma": "~1.7.0",
"karma-chrome-launcher": "~2.1.1",
"karma-cli": "~1.0.1",
"karma-coverage-istanbul-reporter": "^1.2.1",
"karma-jasmine": "~1.1.0",
"karma-jasmine-html-reporter": "^0.2.2",
"protractor": "~5.1.2",
"ts-node": "~3.3.0",
"tslint": "~5.7.0",
"typescript": "~2.5.0"
}
}

Have you removed node_modules and dist directories? If you haven't, do it and npm install after that.

Please keep GitHub issues for bug reports / feature requests. Better avenues for troubleshooting / questions are stack overflow, gitter, mailing list, etc.

Thanks, that was the problem, sorry for the delay in response.
Thank you very much, but would you please explain me why a plain npm install could not serve the correct version?

@uttahb, I'm not sure. I don't kown bom internas.  It can be a bunch of things, like:

npm algorithms get confused and think some parts don't need to be replaced while they should be
npn doesn't have enough permissions to do that
a bug in the version you're using

@julianobrasil Thanks a lot for replying again. That's a good pointer for the future. Thanks a lot


A command option to export books in PDF files.

I use Bookstack to document all my procedures, but how to get that documentation when the system is down?
I would like to request a way to export books in PDF thru command line in order to export them automatically (cron or scripted basis) to a desired folder for offline emergency access.
Of course, it will be useful for many other situations.
Thank you for the wonderful work so far.

Thanks for the request @edersong, but I wouldn't really look to increase the scope of this CLI to support export tasks too.
This is something that can be achieved via the REST API if desired, and I have an example script for that here.


it is possible to submit an empty feedback form

Acceptance criteria

it's not possible to send  empty feedback form
Should the button be disabled until you fill in the form?

http://recordit.co/NWz4uRPcQe

Fixed this morning via https://github.com/kiwicom/smart-faq/pull/378

Although button criteria is not met :smile:

can we close this then?

cc @jaroslav-kubicek

closing since now we have design for that in a new issue, see https://github.com/kiwicom/smart-faq/issues/411


Can't export sam onnx model without "orig_im_size" input

Hi mingj2021,
I had a problem when using the export_sam_model function in demo.py script:
If the "orig_im_size" input in dummy_inputs is commented (as default), I cannot export the onnx model.
Got the following error:
TypeError: forward() missing 1 required positional argument: 'orig_im_size'
If I add the "orig_im_size" input, export can be success but cannot further transfer to .engine model.
Any hints to solve this issue?
I had tried both sam_vit_b_01ec64.pth and sam_vit_l_0b3195.pth
With TensorRT-<IP_ADDRESS>

change "forward" function in the file which is "segment_anything/utils/onnx.py" ， comment the params "orig_im_size"

Thanks, the export to onnx without 'orig_im_size' works.
But still got the following complain when transferring to .engine:

[06/08/2023-10:31:47] [TRT] [E] [graphShapeAnalyzer.cpp::analyzeShapes::1300] Error Code 4: Miscellaneous (IShuffleLayer /Reshape_9: reshape changes volume. Reshaping [4] to [1].)
[06/08/2023-10:31:47] [TRT] [E] ModelImporter.cpp:748: While parsing node number 1237 [Reshape -> "/Reshape_9_output_0"]:
[06/08/2023-10:31:47] [TRT] [E] ModelImporter.cpp:749: --- Begin node ---
[06/08/2023-10:31:47] [TRT] [E] ModelImporter.cpp:750: input: "/Reshape_8_output_0"
input: "/Concat_13_output_0"
output: "/Reshape_9_output_0"
name: "/Reshape_9"
op_type: "Reshape"
[06/08/2023-10:31:47] [TRT] [E] ModelImporter.cpp:751: --- End node ---
[06/08/2023-10:31:47] [TRT] [E] ModelImporter.cpp:754: ERROR: ModelImporter.cpp:179 In function parseGraph:
[6] Invalid Node - /Reshape_9
[graphShapeAnalyzer.cpp::analyzeShapes::1300] Error Code 4: Miscellaneous (IShuffleLayer /Reshape_9: reshape changes volume. Reshaping [4] to [1].)

https://github.com/mingj2021/segment-anything-tensorrt/issues/7#issue-1747148108
transfer sam_vit_l_0b3195.pth to .engine model


added .sass file support

I added .sass (cleaner indent-sytax) file support using node-sass's indentedSyntax option

Could you add a test?

ok working on the test :)

implemented the test but it failes when running after the scss tests.. If i comment out the scss test it works just fine. Maybe you can help out :)

@iMoritz commented on 28 mrt. 2015 19:41 CET:

implemented the test but it failes when running after the scss tests.. If i comment out the scss test it works just fine. Maybe you can help out :)

Does the test still fail when you include some css into the test file? I remember a situation that node-sass-middleware failed when the files didn't had any content.

@jerone. This is exactly what I thought when looking at the test code. :)

Please upgrade package.json with node-sass v2.1.1 which is released today. Everything is exactly same as v2.0.1, except for an installation fix.

@jerone yeah .. was just a commit bug .. is fixed now
@am11 updated package.json to node-sass 2.1.1

@iMoritz, thanks! :)
In package.json, can you please upgrade the packages:

connect: ^3.3.4 to ^3.3.5
mocha: ^2.1.0 to ^2.2.1
should: ^5.0.0 to ^5.2.0

(taken from https://david-dm.org/sass/node-sass-middleware#info=devDependencies&view=table)

Also, you can change "mkdirp": "0.5.x", to "mkdirp": "^0.5.0",

After some investigation I found out that node-sass cannot find the included file so this is the first problem.
Next I found out that the index.css file doesn't get recompiled even if turn on the force option in the middleware

After some investigation I found out that node-sass cannot find the included file so this is the first problem I fixed.
Next I found out that the index.css file only gets a recompile if force is turned on in the middleware

no idea why it failes on node v0.10.38 maybe someone could help out

will continue on this after the node-sass v3 update


Wrong metadata format

According to http://universaldependencies.org/format.html metadata needs to be separate between a = between key and value.
We need to:

support the new and old formats
write only the new

This way we can easily convert existing CONLL-U files.

In http://universaldependencies.org/format.html the documentation about the metadata and comments:

Lines starting with the # character and preceding a sentence are considered as carrying metadata relevant to the following sentence. These lines are an integral part of the format as they give the ability to embed metadata together with the sentences. Consequently, any tools compatible with the CoNLL-U format should carry these lines over into their output (unless specifically designed to process them in some way). The contents of the comments and metadata is basically unrestricted and will vary depending on the application, but from v2 every sentence must have a unique sentence id, formatted as in the examples below. In sentence ids, the slash character (“/”) is reserved for specialized downstream use and should be avoided in UD treebanks. Comments used to specify the unannotated sentence as a single string should also be formatted as below. Comment and metadata lines inside sentences (i.e., between the token lines) are disallowed.

We have two possibilities:

we will consider that ALL comment lines preceding a sentence carrying metadata in the format KEY = VALUE, or
we will have both cases of comment lines with and without meta

Suggestions?

close via b99d8c460b9e780cff363d31742513d82a4f4d53

See also 8bc0476, improved validation , all sentence MUST have the text and sent_id metadata.


Incompatibility with other plugins like Strange New Worlds

Currently, in reading view we have to go a little bit dirty due to the Dataview compatibility issue mentioned in #37. I mean, we have to hide the .original-internal-link and append .mathLink-internal-link.
This approach causes incompatibility with some other link-related plugins like Strange New Worlds (btw it's awesome!).
For example, in live preview everything is fine:

but in reading view, the hidden .original-internal-link is decorated by Strange New Worlds (look at the "3" in front of the link).

So it will be great if we can find a workaround...

Anyway, I'll take a look at what's happening in the Dataview thing before long.


[CS2113-T13-1]-Lucria-B-RecurringTasks

Completed RecurringTasks.
Added the ability to create RecurringTasks using the command format below.
recurring Do Tutorial /at 19/09/2019 1500
Controller will check with the current date and determine if the stored Date in the RecurringTask has passed everytime a command is input into ArchDuke. Should the date passed the current date, controller will delete the old RecurringTask and add a new RecurringTask that's a certain number of weeks ahead of the old date. The number of weeks added to the old date will increase until the new date is ahead of the current date.
Should the stored date be equal to the current date, the old RecurringTask will also be deleted and a new RecurringTask will be created with the deadline a week ahead.

Good job.


change title on README

I´ve left reviews and line comments, created a file and made a commit, opened a pull request

No description provided.


[TickTick] ...

Extension – TickTick
Author: @viduycheung

Description

Steps To Reproduce

install ticktick
into the tick, display：application not found

The current behavior
The expected behavior
Raycast version
Version: 1.39.1

You need install TickTick macOS version first.


Shift-right-clicking to change city production can disable animations going forward (until shift re-pressed)

Pretty much what the title says.  I changed my city production via shift+right-click, and then animations were disabled until I tapped the shift key again.
This is kind of a feature since it allows a convenient way to disable animations, but is also a bug.

hmm, doesn't caps lock disable animations in civ?


AOI analysis with dissolved parameter does not work

STR

Add Create areas of influence analysis to a layer.
Set BOUNDARIES as Dissolved.
The analysis does not work. An error appears in the UI saying "The map cannot be rendered" and when opening the console, in the Network tab the error points to that there is not cartodb_id (see screenshot below).

cc @tbirdman86 @CartoDB/support

I have no idea what's happening with this analysis, could you give us some light here @rochoa?

The error just says that cartodb_id is not defined, but it is there, I don't know :(.

It's buggy, the analysis with that option is not returning the cartodb_id for each row. Probably, it was working before because the interactivity was not used by default.
Reference: https://github.com/CartoDB/camshaft/issues/212.

Hey guys, it is related with camshaft, let me close this one, it is already opened there.


Multiple items breakpoints?

Is it posible to set up breakpoints? like:
responsive: [     {       breakpoint: 1024,       settings: {         slidesToShow: 3,         slidesToScroll: 3,         infinite: true,         dots: true       }     },     {       breakpoint: 600,       settings: {         slidesToShow: 2,         slidesToScroll: 2       }     },     {       breakpoint: 480,       settings: {         slidesToShow: 1,         slidesToScroll: 1       }     }

This issue is solved... ✅

This issue is solved... ✅


Improving Code-Style of Android App

One have to improve the style and format of code written for Android-App

Done

Done


Sns notifications

Only one lambda function can listen for s3 event. If someone wants to trigger two or more lambdas on the same s3 event it would be impossible.
One of the solutions is to use SNS topics as trigger events. SNS events have a slightly different structure.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Thanks!


New metric: Adjusted mutual info score

What does this PR do?
Fixes part of #2003

Before submitting

[x] Was this discussed/agreed via a Github issue? (no need for typos and docs improvements)
[x] Did you read the contributor guideline, Pull Request section?
[x] Did you make sure to update the docs?
[x] Did you write any new necessary tests?

PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?
Make sure you had fun coding 🙃

:books: Documentation preview :books:: https://torchmetrics--2058.org.readthedocs.build/en/2058/

I have yet to implement expected_mutual_info_score as it is quite involved.

@SkafteNicki @Borda CI is failing at "Install Sudo in container". Any idea what this is about?

@SkafteNicki @Borda CI is failing at "Install Sudo in container". Any idea what this is about?

There is likely Microsoft outage, pls be patient and let's try it later again...


EQ3 colors even when all gains are set to 0.

Describe the bug
EQ3 takes away mid frequencies even with 0 gain on all channels.
To Reproduce
I run the following chain: Tone.Player( with my mp3) -> Tone.EQ3 -> output.
If I just put Tone.Player( with my mp3) -> output, it sounds different, even though the EQ3 is set to 0 gain on all channels.
const eq = new Tone.EQ3({
  high: 0,
  mid: 0,
  low: 0,
  lowFrequency: 300,
  highFrequency: 600,
});
eq.toDestination();
const player = new Tone.Player(audioFile).connect(eq);

Expected behavior
A description of what you expected to happen.
What I've tried
I'll probably try and write a parametric eq.
Additional context
I wanted to create a parametric eq by serially chaining EQ3-s.

EQ high/mid/low values are all in Decibels, so 0 would mean no change. -Infinity should silence all of those bins.

Well, that is why it was a bug on Nov 26, 2023, @tambien , because I observerd change. But I ended up taking the AI suggestion and built the plugin by probably chaining filters or so.


create application form

create an applicaiton form in accordance to the design issued on the slack channel

@mulfranck @Ngumbutlar can you check this form on mobile, the navigation is quite unresponisve

Okay on that, I will create an issue and check if anyone will do it.


[Refactor] Move v2/Components > /Components & Collect2 > Collect

Blocker: https://github.com/artsy/reaction/pull/3296
Been meaning to flatten the v2 folder for a while and rename Collect2 to Collect.

Warnings

:warning:
The staging version of Metaphysics has breaking changes, this might not affect your build, but could mean your queries don't work the way you expect. See below for breaking changes:

:warning: Type 'ConsignmentSubmissionEdge' was removed
:warning: Type 'SubmissionCategoryAggregation' was removed
:warning: Type 'SubmissionDimensionAggregation' was removed
:warning: Type 'SubmissionStateAggregation' was removed
:warning: Field 'consignmentSubmissionsConnection' was removed from object type 'Me'

  Generated by :no_entry_sign: dangerJS against 2fe393086348a632d75e24894a6575ead23503ac


launch a firework explosion at [x,y] without any trace?

Issue
Would it be possible to make just an explosion at certain coordinates without the firework trace?
Example: make an immediate explosion anywhere the user clicks

This could maybe be achieved by initiating own Explosion?
But this object is not exported from the fireworks-js package, therefore I wasn't able to import it.

The reason I wasn't able to partly achieve the custom explosion coordinates: #102

@sentisso Hi!
No, but it is possible to implement
fireworks.launch(count)
// or
fireworks.launch({ count, x, y, withTrace })


Static pages output to public

Fix mistake in output of static pages. Need to overwrite the pages in
/public.

Code LGTM :+1:  You are go for merge :checkered_flag:


Fixing tests, added gitattributes

Fixing Travis Tests,
added Gitattributes to not export all config files and tests

As already mention in the issue #3 the unit tests were not executed.
This pull requests fixes the unit tests and I also added a git attributes file so "unimportant" configs like travis won't be exported.

Added a fix for the badges in the readme file, they were redirecting only to the badge-images.
now they redirect to the project

Can one of you guys please review and tell me if that's ok? @visto9259  @matwright
Test aren't working atm and I have many things to commit after that ;-)
Thanks  ;)


Allow custom shell scripts to be defined by derivative images and have Canasta run them at both compile time and runtime

This is already possible for runtime, no? Just add them to the maintenance-scripts/ directory?

Well, yes, except I think today you closed the PR without merging it that would've actually fixed this issue. Right now, the scripts are being called manually.
Also, there needs to be a way to run the runtime scripts on startup only, not over and over again on a cron like maintenance-scripts does.

Ooh - what was the PR? I didn't think there was anything useful among the stuff I closed.

#269

Oh, okay. But please check the relevant code in run-apache.sh (a script that will hopefully be renamed soon, but that's another story) - I think you may have the wrong impression about what it currently does:
https://github.com/CanastaWiki/Canasta/blob/master/_sources/scripts/run-apache.sh#L103

I still think my comment is relevant. What if a derivative image needed to add their own maintenance script? They should be able to do so, and they should be able to control the order in which the scripts run.

Well, we can talk about setting the order - but what does that have to do with this issue? It doesn't say anything about order of operation.

I think it's an implied nonnegotiable prerequisite that the scripts should be run in a well-ordered manner. We don't want nondeterministic script runs!

Well, they're run in alphabetical order, so it's not nondeterministic... is that good enough? I hope so, because that's how things are done right now. :)

They are? But I thought the PR to do that was closed without being merged, much to my dismay :(

Okay - run-all.sh (until recently known as run-apache.sh) uses the "find" command to traverse through all the sripts in maintenance-scripts/ - I thought that "find" always returned files in alphabetical order, but as I just found out, apparently it only usually does that - there's no guarantee of the order unless you then run "sort" or something. Anyway, if you think the current approach to sorting should change, you should either create a different issue for it, or rename this issue - it's very confusing to have a discussion here about functionality that's not discussed in either the issue title or description.

Closing this -

Compile-time scripts can be run by the derivative image themselves at any time with the RUN command.
Runtime scripts can be added to maintenance-scripts/ to run.

I should add that we still need to alphabetize the order in which the maintenance-scripts/ files are run.


SQLSelect regression with subqueries

Module version(s) affected
5
Description
Regression within the SQLSelect class causes sub queries to be duplicated. This can be very easily reproduced in a blank silverstripe project.
How to reproduce
The regression itself:
Creating the select statement
$sql = SQLSelect::create('*', '( SELECT DISTINCT "SiteTree"."ClassName" FROM "SiteTree" ) as FINAL');

Output
SELECT *
 FROM ( SELECT DISTINCT "SiteTree"."ClassName" FROM "SiteTree" ) as FINAL AS "( SELECT DISTINCT
SiteTree.ClassName FROM SiteTree ) as FINAL"

Note that the subquery is being duplicated.
Possible Solution
no response
Additional Context
I noticed that the issue cannot be reproduced when double quotations (") are left out of the query. Following the same reproduction steps WITHOUT the double quotations results in the correct output:
$sql = SQLSelect::create('*', '( SELECT DISTINCT SiteTree.ClassName FROM SiteTree ) as FINAL');

Output
SELECT *
 FROM ( SELECT DISTINCT SiteTree.ClassName FROM SiteTree ) as FINAL

The reproduction code is an MVP, our actual use case is a little bit more complex with additional where statements, and froms.  This worked just fine in silverstripe v4. A closer reproduction would be something like
$siteTree = SiteTree::get();
$query = $siteTree->dataQuery()->sql();
$finalQuery = SQLSelect::create('*', '(' . $query . ') as FINAL');
Debug::dump($finalQuery->sql());

Output (Note the duplication after the aliasing "AS FINAL AS "...."):

Validations

[X] Check that there isn't already an issue that reports the same bug
[X] Double check that your reproduction steps work in a fresh installation of silverstripe/installer (with any code examples you've provided)

You say this is a regression - what is the latest version you saw this working in?

You say this is a regression - what is the latest version you saw this working in?

We're on version 4.13.42 of the framework I believe. Upgrading straight to 5.2

@marwan38 the example SQL ($sql = SQLSelect::create('*', '( SELECT DISTINCT "SiteTree"."ClassName" FROM "SiteTree" ) as FINAL');) is the same in both how to reproduce and possible solution. Perhaps should be different?

@michalkleiner
It's mentioned just above the example,.. my mistake I've updated it. As mentioned right below that it's not exactly a "possible solution" but rather something I discovered which may help debug the issue.

I'm going to move that into the "additional context" section then - since that's what you're saying it is.

I've been asked to look into fixing this at my new job. So I'll have glance to see how difficult - or not difficult it is.

I'm making a start on this.
First, I just replicated the behaviour. Adding this unit test to vendor/silverstripe/framework/tests/php/ORM/SQLSelectTest.php replicates the issue.
public function testSubqueries()
{
    $query = new SQLSelect('*', '( SELECT DISTINCT "SQLSelectTest_DO"."ClassName" FROM "SQLSelectTest_DO" ) as FINAL');

   $this->assertSQLEquals(
       'SELECT * FROM ( SELECT DISTINCT "SQLSelectTest_DO"."ClassName" FROM "SQLSelectTest_DO" ) as FINAL',
       $query->sql()
   );

}

The test passes on 4.13.x-dev. On 5.2.x-dev the test fails with:
1) SilverStripe\ORM\Tests\SQLSelectTest::testSubqueries
Failed asserting that two strings are equal.
--- Expected
+++ Actual
@@ @@
-'SELECT * FROM ( SELECT DISTINCT "SQLSelectTest_DO"."ClassName" FROM "SQLSelectTest_DO" ) as FINAL'
+'SELECT * FROM ( SELECT DISTINCT "SQLSelectTest_DO"."ClassName" FROM "SQLSelectTest_DO" ) as FINAL AS "( SELECT DISTINCT SQLSelectTest_DO.ClassName FROM SQLSelectTest_DO ) as FINAL"'

/var/www/html/vendor/silverstripe/framework/src/Dev/SapphireTest.php:808
/var/www/html/vendor/silverstripe/framework/tests/php/ORM/SQLSelectTest.php:1335
/var/www/html/vendor/bin/phpunit:122

Here's what I found so far.
When did the issue get introduced
This behaviour was introduced by this PR: #10462
From the unit test that got added, it looks like we were trying to resolved an issue where someone would define an alias in the subquery's SQL and in the array key. Doesn't look like this was meant to affect the scenario where a SQLSelect is created with a from provided as string.
Why this is happening
Let's say you instanciate an SQLSelect this way: new SQLSelect('*', '( SELECT DISTINCT "SQLSelectTest_DO"."ClassName" FROM "SQLSelectTest_DO" ) as FINAL');,
The $from parameter can be provided as a string or an array. If you provide an associative array, the keys will be considered as the alias.
The problem is that if you provide a string, the key is assumed to be equal to the string. Presumably, this behaviour is there so that "MyTableName" is automatically aliased to itself. For our example, our $from parameter gets converted to:
[
    "'( SELECT DISTINCT \"SQLSelectTest_DO\".\"ClassName\" FROM \"SQLSelectTest_DO\" ) as FINAL')" =>
         "'( SELECT DISTINCT \"SQLSelectTest_DO\".\"ClassName\" FROM \"SQLSelectTest_DO\" ) as FINAL')"
]

That wasn't a problem in CMS 4 because the key was ignored if the subquery already contained an AS statement.
Bypassing the problem
If you wrap the sub query string in an array, it's happy because SQLSelect doesn't try to generate a matching key.
In the example below, all the scenarios except no-alias-string pass.
    public function subqueryProvider()
    {
        return [
            'no-alias-string' => ['( SELECT DISTINCT "SQLSelectTest_DO"."ClassName" FROM "SQLSelectTest_DO") AS "FINAL"'],
            'no-alias-array' => [['( SELECT DISTINCT "SQLSelectTest_DO"."ClassName" FROM "SQLSelectTest_DO") AS "FINAL"']],
            'no-alias-array-numeric-key' => [[0 => '( SELECT DISTINCT "SQLSelectTest_DO"."ClassName" FROM "SQLSelectTest_DO") AS "FINAL"']],
            'explicit-alias-string' => [['FINAL' => '( SELECT DISTINCT "SQLSelectTest_DO"."ClassName" FROM "SQLSelectTest_DO")']],
        ];
    }

    /**
     * @dataProvider subqueryProvider
     */
    public function testSubqueries($subquery)
    {
        // var_dump($subquery);
        $query = new SQLSelect('*', $subquery);

        $actualSQL = $query->sql();

        $this->assertSQLEquals(
            'SELECT * FROM ( SELECT DISTINCT "SQLSelectTest_DO"."ClassName" FROM "SQLSelectTest_DO") AS "FINAL"',
            $actualSQL
        );
    }

Questions or Possible solution

Do we think the current behaviour is actually the correct one?

I don't think so. Seems really weird to implicitly assume aliases in this scenario

Assuming we agree that this is behaviour is a bug, then the next step would be to decide how to fix it:

We could revert #10462.
We update SQLSelect (and other related SQLExpression) to not implicitly add alias when the $from parameter is provided as a string.

I'm leaning towards option 2, but that may have a lot of other implications, which I'm not aware of.

Yup sounds like a bug to me. IMO reverting isn't really viable, so some variation of option 2 sounds good. Haven't fully wrapped my head around it so I'm not sure if there are edge cases where that'll cause a new problem, but it still sounds like the better way forward even with that possibility.

I'm pretty sure it's coming from this line:
https://github.com/silverstripe/silverstripe-framework/blob/8a576f91be3af375a1c067b2d25141224fe0d66d/src/ORM/Queries/SQLConditionalExpression.php#L81
I'll try hacking the line and I'll throw the kitchen sink at it. We'll see what breaks.

Here's my initial results. Just documenting here so I remember where I got up to.
Try number 1
First I tried doing this change to SQLConditionExpression:
-            $this->from[str_replace(['"','`'], '', $from)] = $from;
+            $this->from[] = $from;

My assumption was that the alias wouldn't matter because it would be equal to the table name anyway.
However, Versioned didn't like that. Versioned is apparently very concerned about those table aliases.
This is the specific Versioned bit that appear to trip up my test, but there's other places in Versioned that do stuff to the table aliases.
Not obviously clear to me why Versioned works this way.
Try number two
For try number 2, decided to retain the current logic for $from that looked like plain table names.
Other $from are pushed on top of the array without an alias. That seem like a fair choice since those table aliases will be non-sense anyway.
            $from = trim($from);
            if (preg_match('/^"?([a-zA-Z0-9_]+)"?$/', $from)) {
                $this->from[str_replace(['"','`'], '', $from)] = $from;
            } else {
                $this->from[] = $from;
            }

I ran builds on those changes:

framework build was happy ... failed because of some other linting problem.
kitchen-sink build is ongoing at time of writing.

Could the second approach open up some SQL injection vectors if we use it as it is?

@michalkleiner I don't think so ... or more accurately, it's not introducing any SQL Injection vector that wouldn't be there already.
SQLConditionalExpression::addFrom() is a low level API. Very few developers will be interacting with this method directly.
setFrom and addFrom make no effort to validate their inputs. If you're interacting with SQLConditionalExpression or its descendants, you are more or less writing raw SQL. I think it's fair to put it back on the developer to sanitised their inputs in this case.

My kitchen-sink build mostly passes.
The PHP 8.3 fails because I had to lock to PHP 8.1, so that's expected.
There's a few Behat failures, but those are on the regular 5.2 kitchen-sink as well ... apparently some people aren't keeping up on top of their build dashboard since their boss quit on them 😜.

Pull request ready for review: https://github.com/silverstripe/silverstripe-framework/pull/11312

PR merged. Will be automatically tagged by GitHub Actions.


do simple literal prefix scanning in regex!

Hi,
I saw the news of that regex got refactored and optimized and decided to check my old benchmark. I was very surprised it now runs twice as long!
How to reproduce (using multirust for versions as older regex doesn't compile with newer nightly Rust):
git clone https://github.com/mkpankov/parse-rust.git
cd parse-rust
multirust override nightly-2015-06-24
git checkout 4076c404caf1560a466e9f0799817035089fe841
cargo build --release
time zcat mp3-logs-with-fake-ips.log.gz | ./target/release/parse-rust
// outputs around 4s on my machine
multirust override nightly-2015-05-25
git checkout e33d410291fa7f134eef628b5591d605cd68b218
cargo clean
cargo build --release
time zcat mp3-logs-with-fake-ips.log.gz | ./target/release/parse-rust
// outputs around 2s on my machine

I'm sorry I can't pinpoint it more accurately (maybe it's Rust changes, not regex), but recent major changes of regex might be it.  This kind of degradation puts it back behind C++ :disappointed:

Okay, seems the real problem is in regex! and regex_macros. Switching to regex::Regex::new instead gives me ~1s time, which is about twice as good as the best of regex! ones.
If that means there's nothing to fix in this crate - feel free to close this, I'll refile the issue where appropriate.

One of the major optimizations for dynamic regexes is in how it handles literal prefixes. Unfortunately, the added complexity of that makes it a little tricky to get it into the regex! macro, so it's no longer doing literal prefix matching. There's probably something simple we can do to at least recover the loss without encoding a full DFA (which is #26).

@mkpankov Thank you for noticing this and reporting it!

BTW, regarding the literal prefix matching, are you using tricks like https://github.com/shepmaster/jetscii to make them even faster?

jetscii must run on stable Rust, so no. (@shepmaster knows of my interest though!) I am using memchr though, which only works in the single-byte-prefix case. I suppose jetscii is a candidate for use in regex! though.

That might shift the performance scales in favour of regex! once again.  = )

FYI jetscii is limited to ascii at the moment but it could just as well be implemented to look for any byte values.

Perhaps of interest, jetscii 0.3.0 introduces support for finding substrings:

Method
Speed

str.find(Substring::new("xyzzy"))
5017 MB/s

str.find("xyzzy"
3837 MB/s

Out of curiosity, what is the status of this year-and-a-half old bug?

@JoeyAcc I have zero plans to work on the regex! macro in the foreseeable future. I'd personally rather see it removed until there's a plausible way to make it work on stable Rust.

Closing in favor of #26.


getExportedDeclarations() throws exception if file is empty

Version: 14.2.1
Error is:
.../node_modules/ts-simple-ast/dist/errors/BaseError.js:7

var _this = _super.call(this, message) || this;
                           ^
Error: Could not find the node's symbol.

To Reproduce
just call typingsFile.getExportedDeclarations() on empty file
Expected behavior
return empty array

Thanks for reporting this @ihorskyi! This is now fixed and available in 14.4.1.
By the way, that .getExportedDeclarations() is one of my favourite methods. Let me know if you run into any more problems with it.


biot5x/examples/finetunning_biot5x_blurb.ipynb has a problem as to typing_extensions.

After compliting the gsutil step and then during executing the biot5x/src/finetune_biot5x.py, I encountered the following error:
~/.local/lib/python3.8/site-packages/tensorflow/python/types/trace.py in <module>
     29 from typing import Any, List, Optional, Sequence
     30
---> 31 from typing_extensions import Protocol
     32 from typing_extensions import runtime_checkable
     33

ModuleNotFoundError: No module named 'typing_extensions'

I confirmed that pip install typing_extensions has been done successfully.

Ubuntu 20.04.6 LTS (Focal Fossa)
<IP_ADDRESS>-microsoft-standard-WSL2
Python 3.11.5

Did you try to run the biot5x/src/finetune_biot5x.py script in an environment? If not, you should try to create your own one and then install all the required packages including pip install typing-extensions.

Thanks. When trying the script at my PC, the following error occurred.
I have already installed the jax module by pip install jax .
2023-12-15 16:51:48.224877: W tensorflow/compiler/tf2tensorrt/utils/py_utils.cc:38] TF-TRT Warning: Could not find TensorRT
Traceback (most recent call last):
  File "biot5x/src/finetune_biot5x.py", line 38, in <module>
    from jax.experimental.global_device_array import GlobalDeviceArray
ModuleNotFoundError: No module named 'jax.experimental.global_device_array'


Explain numeric type of hash() output

Would it be possible to add some detail to the hash() utility function to describe exactly which numeric type should be used to store it.  It says "integer" in the description but shows a value which would be a UBIGINT.

Thanks, fixes!


neba-144 MVC: Enable view resolution to Sling Scripting

#144

Added script view resolution leveraging sling resource types
Enabled WebApplicationContext support and thereby spring form taglib support in the process
Enable ServletContextAware and ServletConfigAware in the process, thus improving compliance to standard WebApplicationContext setups

Coverage increased (+0.5%) to 91.701% when pulling 355fc6d9383f602522bbc14c7a93a1f6c9f6fccd on neba-144 into<PHONE_NUMBER>2f8f493ad331f4d1795dca46cfa00c on develop.


mgmt: mcumgr: add support for indications/notifications

Is your feature request related to a problem? Please describe.
The current implementation of the SMP only allows for handling requests coming from a client. The server side may want to inform the client about a time critical issue but would have to wait until a client poll for that specific request.
A device using the SMP server may go to error state and would therefore like to inform the client, by sending either a notification or indication, that it is in error state.
Describe the solution you'd like
Open up for an api a user can use to send notifications/indication through the SMP server.

Asynchronous responses are not supported and will not be supported due to issues noticed when testing it before whereby flash is stalled during a flash erase/program for an extended period of time and commands sent during that time (i.e. over UART) are corrupted.

Though as an alternative system, there is now MCUmgr client support in-tree with implementations for os_mgmt and img_mgmt so you could use that in an application, it can act as a server and respond to incoming queries and act as a client to asynchronously send commands to the other device (which would be in server mode)

What about in a synchronous way where the SMP server will handle each (request/response, indication, notification) in a blocking way?

There would be nothing to do as that is already supported, MCUmgr client writes to characteristic with data, MCUmgr server processes command, then writes response back to client via characteristic write. Indication/notification isn't going to improve anything

Okay, can the client and server co-exist?

Yes

Cool, I will try to work out a solution using the smp client also, thank you :)


No executable npm found, No executable node found

Mac OS X Sierra
IntelliJ IDEA 2016.3
NodeJS 7.7.3 installed in usr\local\bin
на windows все ок.
где подкрутить на MAC?

is /usr/local/bin in the PATH on Mac?  do you run gradle from command line or from IDEA? I remember there was some difference between UI apps and command-line

Got the same thing when running from inside IDEA on Ubuntu 16.04.2.
Seems to run fine on the command line though.

Same problem here. It works in command line but not in IDEA.

So, Homebrew on OS X installs node into /usr/local/bin, but, the default PATH for UI applications not launched from the Terminal is /usr/bin:/bin:/usr/sbin:/sbin. Thus, IntelliJ probably won't find anything installed via Homebrew or Terminal.
I've found that running the launchctl config user path command works well, e.g., sudo launchctl config user path $PATH sets the user path for UI applications just like what I have in the Terminal at the moment. You just have to run it and reboot.

Now I see it is a known issue. This should be fixed in IDEA 2017.2 and Gradle 3.5


Desktop Optimise on Consumer App for existing screens

Put className="desktop-container" on each outer div for each component
Set desktop-container to margin-right: 220px
Set header to margin-right: 220px
Need to sort out button


Add Tutorials/Docs for DQN

There are various different types of DQNs
Add tutorials, documentation on how one can for e.g. use Categorical Value Functions instead of the usual.
@sampreet-arthi Can you add more details?

We can add this to #196?

Yeah, sounds good


Cmdct 3282 - update to generic error alert

Description
Design wanted the generic/global error alert message to be a bit more useful for the user. The agreed upon change was to tell the user to refresh and if the problem persists, to email the help desk.

If anyone has suggestions to change link={"link"}, let me know. Karla and I did that to avoid changing the type. Also, the styling can probably be cleaned up as well, but I was having a hard time with it.
Related ticket(s)

CMDCT-3282

How to test
Login as a state user, if you don't see the error banner when you first enter the workplan page, create a new workplan, enter it, turn your wifi off, and then leave the form. See that the error alert matches the spec. You can also enter the SAR page before having an approved work plan to see the placement of both the SAR error and generic global error.
Specifics to note:
alert should not have a "close" button per CMS Design System
alert should contain a clickable link to email<EMAIL_ADDRESS>(this will not work in dev local)
alert should be same width as page content column
this alert should come above (to the top of) the alert that appears if a user does not have an approved Work Plan available for use in SAR
Important updates

Author checklist

[ ] I have performed a self-review of my code
[ ] I have added thorough tests, if necessary
[ ] I have updated relevant documentation, if necessary

convert to a different template: test → val | val → prod

Blocker: From the figma mockup it seems like alert should be same width as page content column.
Here's some additional styling based on the mockup as well.
ErrorAlert.tsx
const sx = {   root: {     background:'palette.error_lightest',     borderLeft: "palette.error",     minHeight: 0,     marginY: "1rem",     maxWidth: "55.25rem",     margin: "auto",     borderInlineStartWidth: "0.5rem",     borderInlineStartColor: 'palette.error',     boxShadow: "0px 4px 3px rgba(0, 0, 0, 0.2)",     "&.toast": {       position: "absolute",       right: 0,       width: "90%",       maxWidth: "500px",       margin: "1rem",       boxShadow: "0px 3px 9px rgba(0, 0, 0, 0.2)",     },   }, };


feat: add Portuguese translation

Thank you for your contribution!

@ViPeR5000 could you please rebase? I had to fix the ci pipeline.
git add remote upstream https://github.com/eifinger/hass-foldingathomecontrol
git fetch --all
git rebase upstream/main
git push --force

This PR is stale for 2 weeks and running it through deepl showed me that a lot of information would be lost by this translation.
I encourage you to open it again with a proper translation. Thank you!


Prevent network plugin from showing "NaNkB/s"

Add a safeguard to not show NaN to the end user

Thanks for your contribution!


Error when saving: Invalid Request SHA

Please let me know what to do with this error:

Also, @ project team, please unblock my other account @fulldecent

@willmedtrainingsolutionscom Can you provide some more details on what's happening per the contribution guidelines ?
Does this happen if you log out of Prose, then log back in?
Phillip.

Logging and and then in fixed the problem. Sorry, I should have tried this first! I do also realize that some of the meta data was missing the first time this was submitted, but not sure if that is related to the error. Closing now.

:+1:


remove dropdown and redirect after click - Create selection

the dropdown is now redundant. You can get to the mass mint by clicking in the selection. Could we please remove it and redirect the user after only clicking the "create"
thanks

the dropdown is now redundant. You can get to the mass mint by clicking in the selection. Could we please remove it and redirect the user after only clicking the "create"
thanks

How about this case?  waifu mint on ahk

shoot, let me think @Jarsen136

@Jarsen136 got it sir, for every campaign, we will have additional card in the selection

I have created svg for the current waifu minter.
there is also added sentence in the nft card - "Create awesome NFTs from your art and add them to your existing collection" the rest stays the same.
SVG is ready for download in the figma - if you need png, let me now and I will export it

thanks!

👋


[WIP] Integrations Test and changing run end to end

https://github.com/neuralaudio/hear-eval-kit/pull/200


Fix Collection return type in Query class template

Fixes https://github.com/propelorm/Propel2/issues/1975

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (8d22484) 89.28% compared to head (4ffc406) 67.44%.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@              Coverage Diff              @@
##             master    #1989       +/-   ##
=============================================
- Coverage     89.28%   67.44%   -21.84%
  Complexity     8058     8058
=============================================
  Files           232      232
  Lines         24534    24534
=============================================
- Hits          21905    16548     -5357
- Misses         2629     7986     +5357

Flag
Coverage Δ

5-max
67.44% <ø> (-21.84%)
:arrow_down:

7.4
67.44% <ø> (-21.84%)
:arrow_down:

agnostic
67.44% <ø> (ø)

mysql
?

pgsql
?

sqlite
?

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Thanks @tsybenko for the PR!
Unfortunately the issue is not in the FQCN, the a wrong recognition of psalm class intersection (&), which triggers Phpstorm to recognise Collection as a magic function name 🙈
With FQCN, IDEs don't recognize this row complete, so we can use that to temporary fix it for psalm notation without losing information.