Thanks and suggestions on flexmark

Hi @vsch
I have just launched a site, https://gitq.com, which can help to build the communities for open source projects. The markdown part I'm using is flexmark, it's awesome! And I just want to say thank you so much!
I also notice that we have too many questions here in the issues (even this post), I think it would be better to ask questions in some other places if possible and if it does be an issue, then we can file it here later. That is the reason I built GitQ. So I'm inviting you to join GitQ to discuss flexmark there. I hope this will not bother you too much.
Again, thank you so much.

@steveluo, thank you. It is a great idea. I have found GitHub issues to be no well suited for discussions.
I created the group for flexmark-java and a few of my other open source projects. I will move question issues to the discussion group.
Is there a discussion group for gitq suggestions?

@vsch you are so cool 👍  and thank you for using GitQ 😄
What do you mean a discussion group?

Wrong terminology. I meant a gitq project under GitQ where suggestions or questions regarding GitQ could be discussed.
I think GitQ is a great addition to GitHub that should be a standard GitHub project feature.
One thing I encountered immediately because I imported all project labels. I deleted all labels not relevant to topics and found that selecting several labels to be deleted in one operation would be more comfortable. Currently you can only delete one at a time and there is a confirmation dialog popping up for each one.
What configuration option are you using for flexmark-java on GitQ or is it standard CommonMark?
The reason I ask is that I use my JetBrains Markdown Navigator plugin for creating most posts and copy/paste the markdown (or HTML) into comments on GitHub or other sites. In order to have "identical" preview in the plugin I would add GitQ specific parser options. Then what I see in my plugin preview would accurately reflect what I will get on GitQ.

Yes, we have the community for GitQ itself:
https://gitq.com/GitQLab/gitq.com

One thing I encountered immediately because I imported all project labels. I deleted all labels not

Thanks, I'll add a delete all button soon.

What configuration option are you using for flexmark-java on GitQ or is it standard CommonMark?

The extension I used:
    private static final List<Extension> DEFAULT_EXTENSIONS = ImmutableList.<Extension>builder()
            .add(AbbreviationExtension.create())
            .add(AutolinkExtension.create())
            .add(AutoLinkRendererExtension.create())
            .add(EscapedCharacterExtension.create())
            .add(TaskListExtension.create())
            .add(StrikethroughExtension.create())
            .add(TablesExtension.create())
            .add(TaskListRendererExtension.create())
            .add(InsExtension.create())
            .add(SuperscriptExtension.create())
            .add(TocExtension.create())
            .add(JekyllFrontMatterExtension.create())
            .build();

and the options I used:
        options.set(HtmlRenderer.ESCAPE_INLINE_HTML, false);
        options.set(HtmlRenderer.SOFT_BREAK, "
");

@steveluo, thanks.
BTW, since you are including Non-GitHub styling extensions (Ins, Superscript), you should probably replace the StrikethroughExtension with StrikethroughSubscriptExtension to have ~subscript~ rendered as subscript in addition to the GitHub ~~strikethrough~~ rendering.

@vsch thanks for mention this. Is there any default options I can use to be fully compatible with GitHub markdown?

@steveluo, GitHub is now CommonMark with addition of strikethrough, table, emoji, task lists.
You should probably add:

EmojiExtension, the EmojiExtension.ROOT_IMAGE_PATH should be set to the URL of the base directory where emoji images are located on your site. This extension converts https://github.com/arvida/emoji-cheat-sheet.com of the form :smile: to :smile:, etc.

You probably do not need:

EscapedCharacterExtension because it only affects the AST not the rendered HTML, unless you need the AST.

The following extension that you are using add extra markdown elements to GitHub implementation. It will not affect GitHub comments copied to GitQ, other than processing extra markup. However, the reverse copy will result in some markdown elements parsed as text:

AbbreviationExtension

InsExtension

SuperscriptExtension

TocExtension

TablesExtension allows more flexible tables than GitHubs. To limit it to the same parsing as GitHub tables add the following to your options:
.set(TablesExtension.COLUMN_SPANS, false)
.set(TablesExtension.MIN_HEADER_ROWS, 1)
.set(TablesExtension.MAX_HEADER_ROWS, 1)
.set(TablesExtension.APPEND_MISSING_COLUMNS, true)
.set(TablesExtension.DISCARD_EXTRA_COLUMNS, true)
.set(TablesExtension.HEADER_SEPARATOR_COLUMN_MATCH, true);

@steveluo, I added two new extensions GfmIssuesExtension and GfmUsersExtension that will parse and render #124 and @user-name text to GitHub issue and GitHub user links.
The issues require that GfmIssuesExtension.GIT_HUB_ISSUES_URL_ROOT be set to the http://github.com/user/project/issues where http://github.com/user/project is the associated GitHub project URL with /issues suffix added. The extension will append the / and issue number from the parsed text.
The users extension will create GitHub user links, without needing to modify the defaults, of the form https://githum.com/user where user is the user name from the parsed text.
If you add support for these two extensions on GitQ then comments will be able to refer to GitHub users and issues for the associated project the same way as it is done on GitHub.

@vsch Thanks for the details. I removed EscapedCharacterExtension.
I don't use the official EmojiExtension, GfmIssueExtension as I have already implemented them by using a pipeline something like https://github.com/jch/html-pipeline
Now, you can paste an issue link in GitQ in a separate line and it will show the preview, see below test which I paste the link of this issue (and some other links):
https://gitq.com/GitQLab/sandbox/topics/2/showing-github-issue-with-a-link

@steveluo, excellent choice. It makes GitHub compatibility not an issue.

@steveluo, I don't know if you are still interested in GitQ but just in case you are I have a few ideas stemming from my need to have a discussion forum for my projects to generate user feedback for future product evolution.
I think the need for hosted forums with good GitHub/GitLab integration is real and having one which provides hosted Discourse forums with your added GitHub integration features would be a good choice for many smaller projects and companies, especially as a less expensive alternative to discourse.org.
I also think you need to adapt a tiny free and monthly $5/mo. upgrade tiers for additional features/traffic.
$5/mo is not much which a lot of people can afford. Yet I am spending over $100/mo on services that started out free or at $5-10/mo. It adds up quite fast, especially if you have a good idea which I think GitQ is but it needs to have your integration ideas added to Discourse features.
Let me know if you have moved on to other projects/ideas or if you are still interested in GitQ forums and possibly cutting development costs by moving GitQ implementation to Discourse with your GitHub/GitLab/BitBucket integrations as discourse plugins.

Hi @vsch, thank you very much for sharing your thoughts and ideas to me. It sounds to be very attractive. So far, GitQ haven't taken too much of my efforts. I'm still a bit concern to the real requirements for building a forum/discussion service for open source projects as it seems that people are more likely to share ideas, ask questions directly in GitHub and it's more natural to users.
Actually, to open source projects, I just want to build a free forum service and hope it can be an alternative to stackoverflow.
I'm thinking to add some new features to GitQ, such as documentation service, and I also want to add some features to help open source developers to build their business on their projects. I hope at that time people can like GitQ 😄 .

@steveluo, glad to hear you still have not given up and are still interested because I think it is a great idea but will need some effort to take it from a great idea to a great implementation.
First there is a bug in the current implementation of GitQ probably due to GitHub changing something in their API. The # no longer shows issues and no longer renders as a link to an issue on a project.
That out of the way I would like to discuss how GitQ could be made more attractive.
Let's address your desires:

I'm thinking to add some new features to GitQ, such as documentation service, and I also want to add some features to help open source developers to build their business on their projects. I hope at that time people can like GitQ :smile: .

The best way to help others build a business on their projects is to become a good example of what and how to do it.
No project can succeed without financial support. Either by the founders contributing their time free, by dedicated sponsors or self funding through revenue generating products/services. I am too old for the first and too experienced to hope for the second. That is why I suggested some form of low cost paid service options.
If you are interested I can help you with GitQ project. I have a vested interest in good to great discussion software for technical projects with excellent GitHub/GitLab integration. I will refer to this software as GitQ in our discussion.
Now to the bits and bytes we both love. Primary requirement for success of any project is FOCUS. We all have limited time available for any project. It is crucial to focus on the primary goals and leave the rest for later.

[ ] We need to "ride on the coat tails" of giants that came before us which means use successful projects to help make GitQ known and popular:

[ ] Plugins for developer IDEs to allow interaction with GitHub/GitLab/GitQ without leaving their IDE. I am not interested in a mobile app or turning the forums into a social site. Nothing that will dilute or detract from its value as a technical source.

[ ] JetBrains IntelliJ and other IDEs - I would be interested in having GitHub issues and GitQ forums for my projects available directly in intellij-community so I can read and respond from the IDE.
Right now I copy/paste comments and replies between IntelliJ and GitHub. I would write a plugin to integrate GitHub/GitQ in JetBrains IDEs.

[ ] Eclipse plugin - I am not a user or proficient in Eclipse but think the IDE is popular enough to warrant a plugin for GitQ/GitHub/GitLab

[ ] Others can come later.

[ ] Offer an API for integration with other applications/services but will most likely need to implement popular integrations ourselves since no one will do it until after GitQ is a success.

[ ] GitHub/GitLab integration

[x] Allow creating a forum from GitHub repositories

[x] Allow creating a GitHub issue from a comment or comments in the forum discussion.

[ ] Allow taking an issue from GitHub and migrating it or parts of it to GitQ.

[ ] Absolutely need Discourse forum capabilities because you cannot offer much less than what is already popular. Since discourse is open source it makes no sense to build something from scratch instead of following the spirit of OSS and making additions to the project. I would prefer to create plugins for Discourse for the extra functionality.

[ ] Allow questionnaires/surveys in the discussions to get user feedback on alternative technical issues.

[ ] Documentation service if you mean have functionality to facilitate creation and maintenance of documentation then I think it is a great future direction and I would be very interested in developing the idea further but not right now. Focus.

[ ] Source of answers to technical questions can be discussed. I would love to have an alternative to Stack Overflow which IMHO became a groupie paradise. I stopped participating there. The obsession with rising in ratings goes to people's heads especially software geeks who find a niche where they can be king.

[ ] Project Site hosting can come later if at all. GitHub has GitHub pages and unless we can do a better job and be able to afford it I don't see the point. Focus on primary features of being an amazing technical discussion forum.

Let me know what you think and if you are interested in collaborating on GitQ to advance its potential.
I would suggest creating a forum on GitQ for GitQ discussion so we can start dog-fooding our own ideas.

Hi @vsch
Thank you so much for so long post and so many suggestions. I think it is not a proper place here to discuss this topic, so I will write to you directly, is it ok? And actually the GitQ forum on GitQ is already there:
https://gitq.com/GitQLab/gitq.com

Hi @steveluo, please do write directly to me at the e-mail address in my GitHub profile. I will wait for your e-mail so we can continue the discussion.


feat: scaffold a synthetics node project

part of #470

npx @elastic/synthetics init <project-dir> - You would get everything set up from running tests locally to pushing monitors to the Kibana Monitor management.
- npm run test  - Runs the synthetics tests locally
- npm run push - Pushes the local journeys with configured monitor values to the uptime monitor management UI.

Needs rebasing once #482 is merged. For now you can look at https://github.com/vigneshshanmugam/synthetics/commit/9f00ac004b8a0502321ec3c18aae55a703517dd8

:broken_heart: Build Failed

the below badges are clickable and redirect to their specific view in the CI or DOCS

Expand to view the summary

Build stats

Start Time: 2022-05-12T06:03:02.357+0000

Duration: 5 min 21 sec

Steps errors
Expand to view the steps failures

Checks linting

Took 0 min 3 sec . View more details here
Description: npm run-script lint

:robot: GitHub comments
To re-run your PR in the CI, just comment with:

/test : Re-trigger the build.


Disable schedule

Disabling sync not working when previously was enabled (interval > 0). When sync interval is disabled, then previously scheduled service intent are starting.
Previously scheduled intents schould be removed when interval is <= 0.
public void schedule(Intent intent, long interval) {
        if (isScheduled(intent)) {
            unschedule(intent);
        }

        if (interval < 1) {
            logger.error("Tried to schedule an interval less than 1");
            return;
        }

        PendingIntent pendingIntent = pendingIntentFactory.getPendingIntent(intent);

        setRepeating(interval, pendingIntent, intent);

        logger.info("Scheduled {}", intent.getComponent().toShortString());
    }

This issue has been fixed in https://github.com/optimizely/android-sdk/pull/397


Right click pop-up menu is not coming properly

Hi ,
I have enabled the right click on node. But, the pop up menu appears on the start of the node always. However, I want the pop up menu to appear from the place where I have right clicked. How can I achieve this ?

https://www.jstree.com/api/#/?q=contextmenu&f=$.jstree.defaults.contextmenu.show_at_node


BaseProvider can be replaced by Provider

Current Behavior
The wrapped provider is typed as an extension of the BaseProvider. However BaseProvider is an extension of Provider. In my understanding, there are no properties used by the wrapper that are defined in BaseProvider and not in Provider.
And because a lot of providers are not typed as extending BaseProvider (for example, signer.provider is typed as Provider) so we have to force the type (operation that can be destructive if the Wrapper is using BaseProvider specific fields).

Expected Behavior
The wrapper must be able to wrap all provider extending Provider.

BaseProvider implements the Provider interface and exposes network field and perform function, which the MulticallProvider overwrites. It is the most efficient way to build such a provider. What's the usecase you have where you need to type it Provider instead of BaseProvider?

My point is, when we are using signer.provider, we have a Provider (and not a BaseProvider, see code here)
IMO we can have a Provider to wrap and find a way to build a BaseProvider from a Provider.
In fact, the provider is a JsonRpcProvider which is implementing BaseProvider, but typed as Provider..
See here what we are doing as workaround.
this is a good refactor to improve the multicall adoption since usage is going to be generalized to Provider interface

Unfortunately, there's no workaround other than a complete rewrite of the package, because the network field is used for efficient purposes and the perform function is overwritten to be able to batch RPC calls natively...

Mmh and having a MulticallWrapper.fromProvider(provider: Provider) that is creating a BaseProvider from a Provider, is it possible or is Provider interface too low level? (haven't checked the code in depth)

The Provider interface is indeed actually too low-level: it misses the definition of the network field and the perform function.


Use Iceberg generic record to replace Avro IndexedRecord and add a translation to/from data type in Flink

Current implementation uses Avro as the intermediate fomat, as:
Input as Java Map, serialized to Avro IndexRecord (as the intermediate format), then call Parquet.write(Iceberg API) to write into Parquet file.

We need to remove that dependency and use Iceberg generic record/built-in types (maps with non-string keys, decimals, date/time types...) as the input

Remove AvroSerializer and its implementations
Remove AvroUtils
Remove the setting on serializer in IcebergSinkAppender

Add the translation to/from Flink native formats (like we did for InternalRow for Spark)

FileWriter#write() could accept convention type in addition to Iceberg generic record. See this comment.

I 100% agree that we need to support Iceberg GenericRecord or Flink native formats. We probably need some generic serializer interface. We use Avro quite extensively in the streaming pipeline. It would be nice if we can avoid the format conversion and write Avro directly.

@stevenzwu Thanks for the comments and sorry for my late response~~
Regarding:

We probably need some generic serializer interface.

Yes, I rename "AvroSerializer" into "RecordSerializer" as the generic serializer interface to transform from any input format to Iceberg Record
Regarding:

We use Avro quite extensively in the streaming pipeline. It would be nice if we can avoid the format conversion and write Avro directly

Got your idea. Opened a new issue as https://github.com/apache/incubator-iceberg/issues/943

Ready to close this issue as Avro and IndexedRecord are removed, by the folllowing commits:

https://github.com/apache/incubator-iceberg/pull/856/commits/7ed7583fca49252abdcd587716fc6e3de5c55423
https://github.com/apache/incubator-iceberg/pull/856/commits/01f66bac827407f5fbcc6ef1d8f37b042dc9de8a


computedStyle doesn't work

Hey guys, the computed styles access seems doesn't work

In the console there is only a hash like that { position: 'static' }
Can we make it working?
--
Cheers

Does zombie compute stylesheets?

last time i checked, it didn't


less renaming

not sure why core_platform was written that way

I'm not sure either, but the fix is certainly welcome. Thanks!

It's most likely to avoid confusion with the stdlib platform. Maybe at a certain point both were used in the module.


doc: rm getRows side-effect

Hi, thanks for node-google-spreadsheet
i guess this is a mistake, getRows shouldnt create a new row

thanks!


Changing auth custom email message doesn't cause update

Describe the bug
If I change the custom message used for email verification, Amplify doesn't detect a change and thus doesn't update the auth lambda.
To Reproduce

Change the EMAILMESSAGE element of categories.function.____CustomMessage in the team-provider-info.json file.
Do amplify status (or amplify push)

You will see there is no change. Doing an amplify publish also doesn't result in it being updated (presumably since this is all in the Lambda, and the Lambda has not been updated).
Expected behavior
I would expect amplify status/amplify push to show a change/make the appropriate updates.

Environment
npx: installed 1 in 0.777s

  System:
    OS: macOS 10.15.2
    CPU: (16) x64 Intel(R) Core(TM) i9-9980HK CPU @ 2.40GHz
    Memory: 1.76 GB / 32.00 GB
    Shell: 5.7.1 - /bin/zsh
  Binaries:
    Node: 12.4.0 - /usr/local/bin/node
    npm: 6.13.1 - /usr/local/bin/npm
  Browsers:
    Brave Browser: <IP_ADDRESS>
    Chrome: 79.0.3945.88
    Firefox: 68.0.2
    Safari: 13.0.4
  npmPackages:
    @quasar/app: ^1.0.0 => 1.4.3
    @quasar/extras: ^1.0.0 => 1.3.3
    @vue/eslint-config-prettier: ^4.0.0 => 4.0.1
    aws-amplify: ^2.2.1 => 2.2.1
    aws-amplify-vue: ^1.1.1 => 1.1.1
    axios: ^0.18.1 => 0.18.1
    babel-eslint: ^10.0.1 => 10.0.3
    eslint: ^5.10.0 => 5.16.0
    eslint-loader: ^2.1.1 => 2.2.1
    eslint-plugin-vue: ^5.0.0 => 5.2.3
    leaflet: ^1.6.0 => 1.6.0
    quasar: ^1.0.0 => 1.5.11
  npmGlobalPackages:
    @aws-amplify/cli: 4.11.0
    @quasar/cli: 1.0.5
    claudia: 5.9.1
    npm: 6.13.1
    ts-jest: 24.1.0
    ts-node: 8.4.1
    tslint: 5.20.0
    typescript: 3.6.4

Additional context
If I'm missing something, or there is something else I should be doing, or a different way I should be editing that custom message, let me know.,

@chris Were you able to get past this issue using the amplify update auth flow? If not, we have the amplify push --force command now in v 4.16.0 implementing the functionality  mentioned above.

If you're still stuck please comment on this issue.


Plug-n-play deploy a kubernetes pod usage metering

Preflight Checklist

[X] I have searched the issue tracker for an issue that matches the one I want to file, without success.

Problem Description
I have a cluster and i want to know how much resources a namespace uses via metering the pods in it
Proposed Solution
There is a demo already for it in examples but it is not prod ready, it is a common use-case that can be useful for many users of openmeter
Alternatives Considered
No response
Additional Information
No response

Hi @yairyairyair, we've just shipped this feature: https://openmeter.io/docs/ingestion/kubernetes


Optional checks for multi-line docstring summary style.

Hello,
PEP 257 allows multi-line docstring summaries to start on the first or second line, as it is outlined in #44. I prefer one over the other and was looking for a way to perform consistency checks on my projects. Thus, I have added two optional error codes (D212, D213), which you might like to incorporate.
As those are more restrictive than PEP 257, both error codes should naturally be selected explicitly (and typically mutual exclusive) by the following. Otherwise, they are ignored.
pydocstyle --add-select=D212,D213 file_to_check.py

I have tried to touch as little as possible when implementing them. Please review if this is too cumbersome, or interferes with pydocstyle in a way I have not noticed.
Kind regards,
Tobias

Thanks for submitting this! The concept is good, and I'll try to review the code as soon as I can.

Fwiw, it was on my todo list; my main project wants to stablise our docstrings according to your D212 rule ;-)  So I am thrilled to see this patch.
When you get a chance, please squash your two commits into a single commit.  Thanks.
Just as an aside, I believe D213 equals H404.  https://github.com/openstack-dev/hacking/blob/master/hacking/checks/docstrings.py#L77

@javydb
You are right, I've added additional checks, but they quickly grow tedious. Another
abstraction layer like @check_for(Content), to test only literals between docstring opening and closing, would come in handy to reduce redundancy.
Another enhancement for the test framework, which came to my mind, was to test against virtual files, whose content is generated dynamically at run time from definitions in test cases.
H404 seems to be equal to D212; I have somewhat harmonized this PR with their code, since I am reinventing the wheel already.
Kind regards,
Tobias

Another abstraction layer like @check_for(Content),
to test only literals between docstring opening and closing,
would come in handy to reduce redundancy.

That would be very nice.  It would be a separate changeset.

Make sure to also add your change to the changelog.

I have adapted the PR to your requested changes. With the integration as a regular definition test, I had to remove the Unicode related test cases, since they are invalid in the current PyPy3 (v2.4.0). Those may be added to #178 if so desired.
Also, the expect decorator gets confused by required arguments. Please review the change at a_following_valid_function for any side effects.

@toroettg Merged! Thank you so much for your time and effort, and sorry for taking so long to merge this.


Update deps for 2021(mostly)

Motivation for changes:
Update deps for 2021, starting with latest guessit without breaking the tests..
Detailed changes:
Update guessit
Direct

guessit

Indirect

pytz
python-dateutils
(and more)

Log and/or tests output (preferably both):
Need help with test output.. Too long to paste.. Probably a log level error..

TO-DO:

[ ] Deal with depecation
[x] Deal with test errors
[ ] Actual pasting of test output

Any help is appreciated!!

Found why more tests were failing.. The transition to 3.3...So I just upgraded to 3.2 guessit..

Looks good. Not sure if there is a bug in new guessit, or maybe something just changed that doesn't play nice with how we expect things to work. Can be sorted out later though.
Is the one per line comments in requirements.txt just a result of new pip-compile version? If so, let's update the pip-tools requirement in dev-requirements.txt so that the next person running it doesn't end up switching it back to the single line format.

Yeah,I was running the latest version.. while we are at it let's update black as well

Thanks!


.github/script/STEP

          .github/script/STEP

Originally posted by @Jean-sys77 in https://github.com/Exp-Communicate-Using-Markdown-Cohort-1/series-communicate-using-markdown-Jean-sys77/pull/7#pullrequestreview-1799721021

      .github/script/STEP

  .github/script/STEP

.github/script/STEP


Version 0.4.0 can't do df.read(mikeio1d.res1d.QueryDataReach("Discharge", 'tunnel_name'))

I have a res1d file which contains the results from a simulation in Mike+. I imported that file with
df = mikeio1d.Res1D("model_m1d - Result Files/modelBaseDefault_Network_HD.res1d")
One of the reaches in the model is a tunnel which I earlier opened with
discharge = df.read(mikeio1d.res1d.QueryDataReach("Discharge", 'Fictious outlet Valldalen-Basin'))
But I get an error:
NoDataForQuery: Invalid query Discharge:Fictious outlet Valldalen-Basin
It works properly in mikeio1d version 0.3.0, but not in 0.4.0. Is it a bug?

Thank you for the answer! That was very helpful. Is this syntax documented anywhere?

How would I do if I wanted the discharge from several reaches into one dataframe? Earlier, I would then write res.read([mikeio1d.res1d.QueryDataReach("Discharge", a) for a in tunnels])
since the discharge is the same in all chainages of every reach, it was unimportant to specify chainage. Is there a way I can just get the start or end chainage without knowing it? Or to get a list of the first chainages of every reach in a list?

Thanks for the tips. I used option 2, with the add() and read() methods. My tunnels list looks like this:
tunnels = ['Fictious outlet Valldalen-Basin', 'Inntaksluke-Risbu', 'Fictious outlet Vasstøl', 'Vasstøl-Øyna']
I manually copied the names from the output of res.reaches.keys(). Here, the list was short enough that I could just translate the names to "snake_case" and skip the for-loop, but this would get clumsy if the list was very long. So yes, your suggested syntax would be welcome in the future.
For me it is not so intuitive to use node or reach names as attributes (is that the correct term?), and I can imagine some problems in translating from one to the other, i.e. a list of strings to a list of attributes, if that is even possible. For me it would be more practical to be able to write res.result_network.reaches['Fictious outlet Valldalen-Basin'].Discharge.result_quantities[0].read(). Is there a reason why I can't do that instead of your suggestion for v.0.5.0?


Invalid inputs given to generate an instance of 'FabricEthNetworkGroupPolicyListAllOf'

When trying to perform a get_fabric_eth_network_group_policy_list call with the latest Intersight 1.0.11-8814 version, I am getting the following error message:
Error: Invalid inputs given to generate an instance of 'FabricEthNetworkGroupPolicyListAllOf'. The input data was invalid for the allOf schema 'FabricEthNetworkGroupPolicyListAllOf' in the composed schema 'FabricEthNetworkGroupPolicyList'. Error=Invalid inputs given to generate an instance of 'FabricEthNetworkGroupPolicyAllOf'. The input data was invalid for the allOf schema 'FabricEthNetworkGroupPolicyAllOf' in the composed schema 'FabricEthNetworkGroupPolicy'. Error=Invalid inputs given to generate an instance of 'MoBaseComplexType'. The input data was invalid for the allOf schema 'MoBaseComplexType' in the composed schema 'FabricVlanSettings'. Error=unsupported operand type(s) for +: 'int' and 'str'
This was working fine with previous versions of the SDK.

This issue is actually caused by a bug in a dependency, python-dateutil, which was fixed in version 2.8.2:
https://github.com/dateutil/dateutil/releases/tag/2.8.2


Add other standard maps to edit new empty buffer

Startify already supports i and <insert> to open and edit new buffer.
It would be nice to also support I, a, A, o, O.

Unfortunately, that's very subjective. :-)
In my experience, having many default mappings is a bad thing (even more so when having multiple mappings for one thing), because then someone else will create another issue that the new defaults interfere with his mappings etc.
Long story short: autocmd User Startified nmap <buffer> I i etc.
Thanks anyway!


Remove call to wrap in deepContains

Test Polymer.dom with native shadowroot (chrome only)
Fixes #3273

@sorvell PTAL

LGTM


Watching file changed inside a docker container

Hi, I've set up a simple docker container for my theme development. Unfortunately theme watch wouldn't pick up file changes made from host machine. Is there any way to resolve this?

Sorry you will have to give me a whole bunch more information. Why did you setup a container for development. What is the setup? Do you have your files in the container and running themekit from host? If you are running themekit from the container how are you installing themekit in your container?

Any update?

Hi, sorry about late reply. I've lost my Dockerfile but it was quite simple. It was like
FROM ubuntu:latest

# aptget update, essential packages
# install node npm
# install linux version of themekit

And I've created docker-compose that builds this dockerfile and shares volume # volume share . /home. And I've ran the docker image by giving a interactive mode flag  docker run -it themekit bash
To be honest, I've tried out this setup as an experiment.

I haven't written in Go before but I've noticed it's using 'fsnotify' for watching file system change. I found this issue https://github.com/fsnotify/fsnotify/issues/152 but I guess that's not very helpful =(..  I wonder how Nodemon can achieve file watch across NFS using --legacy flag

That is a good find. I am going to close this since it seems like there is a limitation of the file watcher and really there is no reason to be doing theme development in a container. Your theme is deployed on shopify and you don't need any other services like databases/memstores.

agreed =)..

We are new to themekit, but use containers for most things. Here it would be useful, since we can use the container to encapsulate the themekit, and allow devs to work with the themes without knowing how to install/manage themekit.  (which does sound a bit silly, since they need to learn liquid anyways, but its one less thing to think about)
In legacy mode, nodemon uses polling to detect file changes.  This is also useful in some cases where there are a large number of files to watch.
I don't have much experience with golang, but this might serve as a useful reference: https://github.com/fsnotify/fsnotify/issues/9

@krumware I am still working a better installer for windows, would that alleviate this issue?
Supporting a polling fallback just for container development adds significant complexity to themekit and supports a very small amount of user base.

I think that it would. Even a powershell script or using a package manager like Chocolatey would help.
I also agree that those using this method (while becoming more common) is still too small of a user group, and likely will be alleviated by enhancement to Docker on Windows in (hopefully) short time.

Well, I think it would still be useful to support file change events inside containers because in larger scale shopify theme development, it would be nicer to encapsulate your development environment inside containers  (e.g. it enables developers to work in consistent environment for package management systems like NPM).

@JasonShin If you are still interested in getting themekit to work in a Docker environment, I am in the process of moving the file watching over to a polling process to ensure that it works more uniformly on any operating system. You can give this a try by using v1.0.0-pre in your docker container. This can be done by installing themekit and then running theme update --version=v1.0.0-pre. I am not sure what is the best way to install themekit in a container because the install script requires python and curl (curl -s https://raw.githubusercontent.com/Shopify/themekit/master/scripts/install | sudo python)


Weights upcasted to float32 at load time

When loading Gemma model(s) the weights are upcasted towards float32 representation increasing the memory requirements by twice and slowing down computations

Fixed in a different way, anyway it's in https://github.com/huggingface/optimum-tpu/pull/21.


Community connector page creation: make the neseted options a separate question

Nested options in some of the questions, such as age groups, gender groups, ethnoracial groups, gender groups, etc. are not accessible for different ATs. We had Tab navigation and screen reader navigation issues with these nested options. All users including magnifier users and Dragon users were not sure if they are required to pick these nested options or not. It would be more accessible to remove these nested options and ask them as a separate question.
We take a similar approach when we ask "Can you connect to people with disabilities, Deaf persons, and/or their supporters? (required)" If they select "People who experience disabilities" we show a subsequent question " Please select people with disabilities that you can connect to (required)" instead of nesting it inside the first question.

Individual - community connector:
https://www.figma.com/file/AXufBnFAVHvGdsxnQMVhNF/The-Accessibility-Exchange-Wireframes?node-id=2613%3A68551
Community organization - rep org:
https://www.figma.com/file/AXufBnFAVHvGdsxnQMVhNF/The-Accessibility-Exchange-Wireframes?node-id=2560%3A65260
Community org - support org:
https://www.figma.com/file/AXufBnFAVHvGdsxnQMVhNF/The-Accessibility-Exchange-Wireframes?node-id=2602%3A68633
Community org - civil society:
https://www.figma.com/file/AXufBnFAVHvGdsxnQMVhNF/The-Accessibility-Exchange-Wireframes?node-id=2567%3A65306

See also: https://github.com/accessibility-exchange/platform/pull/1288#issuecomment-1310796711


Complete Instruction

Hello,
it's the first time trying this out and I'm completly new to Visual Studios and dont get it.
Is there anywhere a step by step guide i can follow?
I'm trying to get it done since 4 hours now. :(
I always get the error "The ddocument's format is eiter unsupported or the document contains binary characters, opening wit a diferent application".
Thanks in advance!

Thank you so much ;)


Add 'copyFormatting' global setting

Summary of the Pull Request
Implements copyFormatting as a global setting. When enabled, formatting such as font and foreground/background colors are copied to the clipboard on all copy operations.
Also updates the schema and docs.
References
#5212 - Spec for Formatted Copying
#4191 - Setting to enable/disable formatted copy
#5263 - PR prematurely merged without approval of #5212
This feature will also have an impact on these yet-to-be-implemented features:

#5262 - copyFormatting Keybinding Arg for Copy
#1553 - Pointer Bindings

PR Checklist

[X] Closes #4191

Detailed Description of the Pull Request
We already check if the hstring passed into the clipboard is empty before setting it. So the majority of the changes are actually just adding the global setting in.
Validation Steps Performed

copyFormatting
Mouse Copy
Keyboard Copy

not set (false)
✔
✔

true
✔
✔

false
✔
✔

Additional Comments
Question: Should this actually close #4191?
Yes: the sentiment behind this issue was to disable/enable formatted copy
No: the proposal was to copy specific formats
For now, I've assumed yes, but still wanted to point it out

Well, don't wanna complain and all, but technically this only closes #2690, not #4191 (actually the former happens to be already closed, because you apparently decided to not implement it back then).
This also looks like the implementation of option 1b from the spec at #5212, and what i was really into was the option 2b - it is what was originally requested (to split html from rtf) and is flexible so you can e.g. create separate commands for plain copy and html copy, which is common in other terminals, and is what some guy proposed in the original issue. I don't know your plans about that though, just throwing my opinion.

To be fair, this is called out in the discussion section.

Question: Should this actually close #4191?
Yes: the sentiment behind this issue was to disable/enable formatted copy
No: the proposal was to copy specific formats
For now, I've assumed yes, but still wanted to point it out

Well, don't wanna complain and all, but technically this only closes #2690, not #4191 (actually the former happens to be already closed, because you apparently decided to not implement it back then).
This also looks like the implementation of option 1b from the spec at #5212, and what i was really into was the option 2b - it is what was originally requested (to split html from rtf) and is flexible so you can e.g. create separate commands for plain copy and html copy, which is common in other terminals, and is what some guy proposed in the original issue. I don't know your plans about that though, just throwing my opinion.

Yeah. The spec now says that #4191 will be implemented later. So you're right. Updating the PR header now

@msftbot merge this in 1 minute


Tickets are linked by there is no hyperlink in the app sections to redirect from 1 ticket to another

Sorry to hear you're having an issue. Linkets is built on the Zendesk search API and tickets API. Sometimes linked tickets don't display immediately because the tickets haven't been re-indexed yet within Zendesk's search infrastructure. If you wait a minute and refresh, are the linked tickets displayed?

The ticket was submitted some time ago - months if I recall correctly.  You
pushed an update and the issue resolved after that time.
From what I could tell based on the timestamp of the last update, when this
occurred, the extension hadn't been updated for several months and simply
broke.  We have again been identifying Linkets as an appropriate solution
for our clients.
T.J. BUMGARDNER
CEO
Need to chat?  Click here https://calendly.com/zenbros to schedule a
meeting
On Sun, Feb 21, 2021 at 8:31 PM Alex Glover<EMAIL_ADDRESS>wrote:

Sorry to hear you're having an issue. Linkets is built on the Zendesk
search API and tickets API. Sometimes linked tickets don't display
immediately because the tickets haven't been re-indexed yet within
Zendesk's search infrastructure. If you wait a minute and refresh, are the
linked tickets displayed?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/alexdglover/linkets/issues/15#issuecomment-782996479,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AMQDDUVKNZLU3KDWUNKFVQTTAG6XRANCNFSM4WNKNZVA
.


KYLIN-4106 fix Illegal partition for SelfDefineSortableKey

do % opration before abs ，more detail：https://issues.apache.org/jira/browse/KYLIN-4106
Signed-off-by: langdamao<EMAIL_ADDRESS>

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@1d56aee). Click here to learn what that means.
The diff coverage is 100%.

@@            Coverage Diff            @@
##             master     #777   +/-   ##
=========================================
  Coverage          ?   25.75%
  Complexity        ?     6045
=========================================
  Files             ?     1393
  Lines             ?    82980
  Branches          ?    11605
=========================================
  Hits              ?    21371
  Misses            ?    59553
  Partials          ?     2056

Impacted Files
Coverage Δ
Complexity Δ

...ne/mr/steps/FactDistinctColumnsReducerMapping.java
81.81% <100%> (ø)
17 <0> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1d56aee...6dac479. Read the comment docs.


Add Specific WebSocket errors

Purpose

Add Specific WebSocket errors

Approach

Identify the potential errors thrown in java in WebSocket and return appropriate Ballerina errors.

Samples

N/A

Remarks

N/A

Check List

[ ] Read the Contributing Guide
[ ] Required Balo version update
[ ] Updated Change Log
[ ] Checked Tooling Support (#)
[ ] Added necessary tests

[ ] Unit Tests
[ ] Spec Conformance Tests
[x] Integration Tests
[ ] Ballerina By Example Tests

[ ] Increased Test Coverage
[ ] Added necessary documentation

[ ] API documentation
[ ] Module documentation in Module.md files
[ ] Ballerina By Examples

Codecov Report

Merging #19119 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #19119   +/-   ##
=======================================
  Coverage    15.8%    15.8%
=======================================
  Files          47       47
  Lines        1259     1259
  Branches      196      196
=======================================
  Hits          199      199
  Misses       1047     1047
  Partials       13       13

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 99bb98b...761ffea. Read the comment docs.


Update backup-azure-arm-vms-prepare.md

typo in a link - "netwrok" vs "network"

Hi @nromyn, I'm your friendly neighborhood Azure Pull Request Bot (You can call me AZPRBOT). Thanks for your contribution!

This seems like a small (but important) contribution, so no contribution license agreement is required at this point. Real humans will now evaluate your PR.

TTYL, AZPRBOT;

@nromyn : Thanks for your contribution to the Azure documentation! The author, @markgalioto, has been notified to review your proposed change.

@nromyn : Thank you for catching that mistake. Having the link go to the correct heading is a much better experience!
#sign-off, This fix is correct and is ready to be merged.


Update Layout.js

What kind of change does this PR introduce?

Does this PR introduce a breaking change?

What needs to be documented once your changes are merged?

👷 Deploy Preview for prankurverma processing.
🔨 Explore the source changes: 967782d942a0843744235a85687e5c4ce98dcf82
🔍 Inspect the deploy log: https://app.netlify.com/sites/prankurverma/deploys/6171ac72adac45000747e853


WORKING DOCkER FILE for Mac M1

Hi, I was searching for a one working docker file that would enable running cellpose GUI. I tried installing it first on my M1 MacBook but had no luck ( qt libraries issues). Then I switched to Docker as in theory one well-set file should be helpful for everyone, but I cant find any which is working. Can anyone from the community have a working Dockerfile to share?

closing due to inactivity


Support for new API

Some sort of basic task list:

[ ] Support for new API in an extra module
[ ] Make sure the time is synced (NTP). We need this for timers/alarms to work properly.

Will there be near-future update to the new Alexa api that supports timers etc?

Also if there is any help needed, I would be more than happy to help

Not in the near future unfortunately. We have a lot of refactoring to do, before we can do such big changes. The current primary goal is to get #30 merged. That requires testing and code review. I believe we are close on that one, if Mason won't have further issues.

Would the api update require massive overhaul on components currently being worked on?
If I were to start updating to the api and somehow succeed, would it be possible to add it as a new branch?

Okay, here's the thing. The whole API / processing / platform notifying code is kind of intertwined / it's not clear to me what goes after what and when and how we can separate it right now (the specific code changes).
What we will definitely do is to separate the AVS stuff into a module like alexapi.somethingLikeServices.avs. We need this, there is no doubt there.
The (shortest) path to new API I had in mind:

help #30 get merged - testing & CR, I believe we're almost there, but if you help with it, we can finally get it out of our hair
I'll do #21, which will affect every single python file and I'll need CR and testing in case I accidentally break something; this should be pretty quick, but I need someone to review my changes - this is what takes the most time as people don't have much time to do that
in #23 we'll split the code for current API so it's gonna be more clear what the module should look like
anyone can go crazy and implement the new API

Basically, the path could be shorter, but there's the thing that right now, you don't know how the main code is gonna interface with the service module, therefore we need to do 3 and 2 is gonna help us set up better pylint tests and is gonna make 3 easier as well as general development. I've been postponing it for a while and I think it's time I finally do it.
Also, there's no guarantee that the new API mechanisms can be the same as with the old one. We have to find out.
So if you want to help out, I (and anyone else) would greatly appreciate it. If you'd help according to the scenario above, that would be the best. Then you could work on the new API in a special module and we'd have no merge conflicts and issues while other people are working on other stuff.

So just to keep track, @davidmroth is doing some serious work on this at https://github.com/davidmroth/AlexaPi/tree/avs_v2
We'd have to do some things first to get that merged (#21, #23, change it to use #68), but it looks very promising. We might have version 2.0 sooner than we thought :-)

Thanks @renekliment! Not event close to being ready. My plan is to squash the current branch once I have a stable API. Then I was thinking I would back port some of the awesome things you guys are doing. If all goes well, I wanted to see if you'd be interested in merging this into a AVSv2 branch or something.

Yeah, it needs some work, but you're not fooling around!
If we have #23 and #68 and you then rebase your branch on top of that, using those interfaces, I'd be glad to merge that into an official avs2 branch, maybe even throw it into master as a preview (not on by default). I haven't looked at #23 yet at all, but I hope we can have these services like AVS modular so we can support both API versions, hell, maybe even other services if available, so people can just chose in their config.

@davidmroth  how far have you gotten on the v2 branch?

There seems to be a library for the new API - https://github.com/nicholas-gh/python-alexa-client as pointed by @illperipherals
@davidmroth You might be interested in this.

@nicholas-gh You might be interested in our project. If not, sorry for the spam.

There is so many different python implementations of alexa, all with different features and parts working.
Is there some documentation on what we're working towards in terms of code structure/modularity, threading and generic playback/device/voice service interfaces?

I don't think so. It's just a case of who has time and an itch to scratch :)
I'm not actively working on my now - I have "real" echo devices. They have some benefits (mics, spotify), but also some downsides (no local scripting ability.)

Another link for the record: https://github.com/nicholasjconn/python-alexa-voice-service
@davidmroth You might wanna check it out.

Is this likely to happen soon? I mean this is great project cos its headless but it was reporting things dont work like timers due to API version but that was 2+ years ago. If I could code it, I would!!!

Any development on this recently?


Add option to animate the 2D view by iterating over slices in a certain dimension/axis

I have added this feature which you can test or check out in the updated README.md.
I tried to keep the implementation as similar to the 3D one as to avoid unnecessary complexity, but unfortunately either I'm doing something wrong when converting TXYC images to CTXY, or 2D screenshots don't play well with microfilm or something else completely which makes the output animation's colors incorrect. I tried to troubleshoot this issue as much as I could, but the only solution I found was to instead use Pillow to avoid having to mess with image dimension ordering. The weirdest part to me is that these issues don't happen when using the whole window screenshots (so without the canvas_only option)
The output of both implementations can be compared by toggling the "use Pillow to generate gif" bool.
To reproduce my label color issues with microfilm, you can use these files from Rosenhain, S., Magnuska, Z., Yamoah, G. et al. A preclinical micro-computed tomography database including 3D whole body organ segmentations.:
Labels-M20_0.25h.nii.gz
Scan-M20_0.25h_0000.nii.gz
To import them into napari you can either use the napari-medical-image-formats plugin or export their data in a script using a library like nibabel and then import it to napari.
Here's an example of a scan with colored labels animated with microfilm:

And here is the same animation with Pillow:

The first one took ~20 secs and the second one ~5, both use the same 50 slices.
It seems that the outputs are very similar when not considering my color issues with microfilm, and Pillow also seems to be faster, so maybe we could completely replace one with the other in both functions? I also understand if you don't want to fix something that isn't broken and just keep your plugin with its current functionality. I can keep this fork for anyone else who might stumble upon it and find it useful.

Ok, the first two changes have been added, the readme images/gifs should work when merged! :))

Hi @haesleinhuepf and @PereGinebra. The reason for the blinking is that by default microfilm uses a min-max intensity scaling. If you use only the canvas, this min-max changes across frames while with the viewer you have both black and white elements in the picture that keep that range fix. You can fix this here: https://github.com/haesleinhuepf/napari-animated-gif-io/blob/66bc20ef63672fe2b52429f335730be18a7feb7a/src/napari_animated_gif_io/_function.py#L137
by using the rescale_type argument:
microanim = Microanim(data=swapped, cmaps=['pure_red', 'pure_green', 'pure_blue'], fig_scaling=10, rescale_type='dtype')
'dtype' means you use the whole range available to the type of the image.
Regarding the speed issue I don't think that this can be fixed. microfilm was really made to handle complex cases with multi-channel images, scalebars etc. Here it's only used to save a series of standard RGB images, and for this I guess generic solutions like Pillow will always be faster.

And you might also want to have a look at the napari-animation plugin. It allows you to create the same kind of gifs if you just use two key-frames, but then also allows for more complex animations (and video formats).

Oh thanks, I remember checking it out when I was looking for a plugin for this, but for some reason thought it was also just meant for more complex 3D animations. I guess I should have tried it out before trying to reinvent the wheel.
Is there a way to set the frame-rate of the animations that I'm missing? It would be useful as so to slow-down animations for easier comparison between scans!


enabling docs build

after adding gulp-typedoc we can now build docs

Great! Thanks for the PR! I'll test it and merge.

I merged it, is it OK?

@c-ice you don't have write permissions to this repository, I merged it a while ago. It looks good to me, thanks for the change! :-)


Update to stable Vite plugin

Remix has finally released stable Vite support: https://github.com/remix-run/remix/blob/main/CHANGELOG.md#v270

@mcansh documentation still refers to "unstable vite plugin", I believe that is no longer correct?..

@mcansh documentation still refers to "unstable vite plugin", I believe that is no longer correct?..

you're correct, i missed one usage of unstable 😅, thanks for the heads up


Switch to wildcard lists wherever possible

Switch lists after implementing https://github.com/dnswarden/blocklist-staging/issues/17 , when #17 is implemented back-end servers  doesn't require any kind of manual intervention when the new lists are added or replaced or removed.

completed in https://github.com/dnswarden/blocklist-staging/pull/28


TanStack Query plugin

Description
Hey guys! I saw that the tanstack query generation is coming soon which is awesome. We are planning to migrate our project to use openapi-ts with tanstack-query. In order to avoid double work in our side when should we expect this feature to be shipped? Cheers!

Hey @sahinkutlu, would generating queryOptions() objects be enough to start?

@mrlubos is there any WIP on this? overall I'm having a good time using fetch API with tanstack query but there are some pain points that.. I'm sure you're aware of given that this is on the roadmap :slightly_smiling_face:

Yep, I did have a look at it, might prioritise it actually.

Hi @mrlubos! Yes generated query options would very nice 👍 When do you think it will be released?
Cheers!

can't wait too. good work guys

It would be nice to have. I'm thinking about writing my generator, but if it's implemented in your library it would be just awesome!

@mkeyy0 soon https://github.com/hey-api/openapi-ts/blob/main/packages/openapi-ts/test/snapshots/test/generated/v3_hey-api_client-fetch_plugin_tanstack-react-query/tanstack-query.gen.ts.snap

Very exciting. RQ support gonna sky rocket this package!

Looking forward to this.

I hope that other framework versions of TanStack, like Vue, will also be supported.

@Jannchie most definitely 🙏

Looking forward to use this in combination with vue. Is there an ETA?

@brmdbr Hopefully within 2 weeks, but if you want to test drive it earlier, send me a message on Discord/email/Twitter/LinkedIn and I can walk you through it (in exchange for some feedback 😈)

@Jannchie @brmdbr can you get in touch with me to test the Vue plugin?

Support for React, Solid, Svelte, and Vue done, currently undergoing testing. If anyone wants to try it out early, add this to your configuration file
for React
plugins: ['@tanstack/react-query']

for Solid
plugins: ['@tanstack/solid-query']

for Svelte
plugins: ['@tanstack/svelte-query']

for Vue
plugins: ['@tanstack/vue-query']

and feel free to open a new issue if you run into any problems! I don't really expect the APIs to change, but it has not been thoroughly tested (except for React), so you never know!

@mrlubos It would be nice if we could override some of the tanstack query options. I prefer to set some options manually, such as enabled and staleTime, and this would allow for those manual changes. I haven't looked into the query key part of it too much, so not sure if that would work with the typing, but having the ability to add additional keys would be appreciated.
Here is my idea on how to do this with adding the tanstackQueryOptions as a parameter.
export const serverGetOptions = (
  options: Options<ServerGetData>,
  tanstackQueryOptions?: Omit<UndefinedInitialDataOptions<any, Error, any, any[]>, "queryFn">,
) => {
  return queryOptions({
    ...tanstackQueryOptions,
    queryFn: async ({ queryKey }) => {
      const { data } = await serverGet({
        ...options,
        ...queryKey[0].params,
        throwOnError: true,
      });
      return data;
    },
    queryKey: [
      {
        params: createQueryKeyParams(options),
        scope: "serverGet",
      },
      ...(tanstackQueryOptions ? tanstackQueryOptions.queryKey : []),
    ],
  });
};

@RobertOstermann that's fair, I will need to improve types to unlock this feature. In the meantime, you can simply spread the response from this function onto useQuery() and add your options there.
useQuery({
})

@RobertOstermann that's fair, I will need to improve types to unlock this feature. In the meantime, you can simply spread the response from this function onto useQuery() and add your options there.
useQuery({
  ... serverGetOptions(),
  enabled: false,
})

I was able to do that for most of the options, but struggled to get it working with queryKey, might just be user error though.

@RobertOstermann what kind of query key are you passing? I would expect TypeScript to complain if it doesn't match the expected shape. That might need to be improved, why are you needing to pass your own query key?

I was trying to pass in a number. Tried adding it as a new element at the end of the query key array, but no luck. I prefer to pass in my own query key so I can easily invalidate several queries, all which share that same query key, when a mutation is complete. I think it not matching the expected shape was the issue.
Also, thanks for all your hard work on this! Super useful.
useQuery({
  ... serverGetOptions(),
  queryKey: [...serverGetOptions().queryKey, idNumber],
  enabled: false,
})

@RobertOstermann we should talk about that use case, perhaps separately. Query key design is important. I've also heard from others they need URL base as part of it so they can target by the client which made the request.

When using bundle: true, the code doesn't seem to generate correctly. Maybe it's related to #939 ?

Thank you for this nice work. Can you confirm that services: { asClass: true, } will not work with the plugin (yet)?

@holtgrewe The question is what do you imagine/understand by that? The plugin is a separate output so the way you generate services does not have an impact on it

Is it known that using client: 'fetch' makes the plugins be ignored?

@mrlubos the result appears to be incompatible as it does not generate the ClassNameService. prefix to the calls. But never mind, I adjusted away from services: { asClass: true }.

@holtgrewe Ah got you. That should be fixed, thanks for pointing it out
@SimenB yes, there are no plans to support the old clients at this time

Aight 👍

@RobertOstermann / @mrlubos could you share some information about how key invalidation in mutations are to be used with the standard / builtin and custom overrides? This would be very useful for newbies to TanStack Query like me.
Thanks!

Hey all, added a quick page on this plugin to docs + StackBlitz example to signal this is ready to be used and welcoming feedback! https://heyapi.vercel.app/openapi-ts/tanstack-query.html

Related https://github.com/hey-api/openapi-ts/issues/980

queryKey / mutationKey logic is not make sense to me at all, I think should allow user to define it instead of auto autogenerate it

@himself65 can you explain why? I do agree that eventually we could provide API hooks to customise the output further, but want to hear your take on why the current logic doesn't make sense

for example, there are apis:

GET /keys
GET /keys/{id}
PUT /keys/{id}

queryKey for /keys and keys/{id} should be () => ['keys'] and id => ['keys', id']

@mrlubos As mentioned before, I'm using the Vue3 flavor of TanStack query. I'm writing my own composeables to isolate the queries outside of components and make them reuseable. I now need my composeables to be reactive, in other words pass Ref<T> or ComputedRef<T> into the arguments. The following code complies with the type requirements of the generated code.
export const useMyRecordListQuery = (categoryUuid: MaybeRefOrGetter<string | undefined>) => {
    return useInfiniteQuery({
        ...myApiMyRecordListInfiniteOptions({
            path: { category: toValue(categoryUuid)! },
        },
        enabled: !!toValue(categoryUuid),
        getNextPageParam: (lastPage) => lastPage.next,
    }
}

There is particular support for MaybeRefOrGetter built into TanStack query and I guess this needs to be implemented into the @tanstack/vue-query plugin as well.
https://github.com/TanStack/query/blob/804357b9352d3fc39855ead9b60a39028ba6e3a3/packages/vue-query/src/useQuery.ts#L20-L52
What do you think?

@holtgrewe I think that's fair, we can improve types for queries to use the TanStack types just like mutations do

All, v0.53.0 will contain a fix for https://github.com/hey-api/openapi-ts/issues/987

I see @rkorzhoff. Mind opening an issue please?

Sure!

@mrlubos https://github.com/hey-api/openapi-ts/issues/1030

for example, there are apis:
* GET /keys

* GET /keys/{id}

* PUT /keys/{id}

queryKey for /keys and keys/{id} should be () => ['keys'] and id => ['keys', id']

Rather, by default, the plugin should follow the recommendations made by TkDodo on his blog. This allows the invalidation of many queries at once:

queryClient.invalidateQueries({ queryKey: ['todos'] }) would invalidate anything related to todos;
queryClient.invalidateQueries({ queryKey: ['todos', 'list'] }) would invalidate all todos list pages;
queryClient.invalidateQueries({ queryKey: ['todos', 'detail', id] }) would invalidate a single todo specified by id.

I agree, I would expect a query with a url {baseUrl}/keys/{id}?filters='all' to have the resulting query key: queryKey: ['keys', id, { filters: 'all' }].
Also, making the queryFn depend on the queryKey makes it difficult to use a custom query key instead of the query key defined by the options. Is there a reason the queryFn doesn't recreate the query key instead of having it passed in? I think generating the query function as follows would allow for custom query keys.
export const serverGetKeysOptions = (options: Options<ServerGetKeysData>) => {
  return queryOptions({
    // queryFn: async ({ queryKey ) => {
    queryFn: async () => {
      const { data } = await serverGetKeys({
        ...options,
        ...serverGetKeysQueryKey(options)[0],
        throwOnError: true,
      });
      return data;
    },
    queryKey: serverGetKeysQueryKey(options),
  });
};

Hi, I also tested the generated results and found another pain point  due to  current  queryKey design.
I think it's common to find that clients and servers are using different baseUrls for the sample resources for performance and security, since the queryKey is hardly depend on baseUrl, it makes us hard to prefetch queries for server-side rendering.
Also, the hey-api/client-fetch client construct a Request object internally which will throw an error if the custom fetch function expect urls without hostname. i.e new Request('/') is valid in Chrome but not in firefox or node.
This can be workaround by using a fake baseUrl and replace it via custom fetch function but very awkward.
i would appreciate it if this can be taken into consideration.
Thanks for maintaining this great project.  It's been extremely helpful for us.

@yue4u do you have a solution in mind for each of the 2 mentioned issues?

@yue4u do you have a solution in mind for each of the 2 mentioned issues?

Thanks for your quick reply!

For query key design

Like other comments I think following TanStack Query' recommendations is a good practice and queryFn should not depend on the queryKey. Or just make this queryKey option more customizable to let users decide themselves.

For Request object,

IMO it would be more helpful to avoid instancing Request objects and use the same interface as global fetch (string|URL, RequestInfo) but this either needs an API change or create a new option?

Like other comments I think following TanStack Query' recommendations is a good practice and queryFn should not depend on the queryKey. Or just make the queryKey option more customizable to let users decide themselves.

@mrlubos Any update on if this is in the works?

Awesome work @mrlubos 👍
My question is about the use of React Suspense. At the moment, react-query has an explicit hook useSuspenseQuery to make use of React Suspense and doesn't allow for setting it as option since v5:

In React Query v5, the suspense option is no longer a boolean flag on the query hooks. Instead, you should use the dedicated hooks for suspense, such as useSuspenseQuery, which automatically handles suspense mode for you.

And all generated code seems to use the base useQuery, so I was wondering if there is something I could configure to change this behavior, or if this falls in a Feature Request?
Thank you, loonatic


refactor: remove rustpython

What type of enhancement is this?
Tech debt reduction
What does the enhancement do?
Remove rustpython which seems not very useful in our usecase(due to not having access to python eco system), also this will reduce our binary size
Implementation challenges
None

We can just remove it from default features. There are more tests related:

dashboard: remove script module from OSS distribution @ZonaHex
docker image: remove python from base image @zyy17


Migrating docs to wiki and revising license

Coverage remained the same at 81.455% when pulling f470bdd2f1b5fe7a417f15fca1bf6dbb6c4c2be9 on refresh-readme into 2e2c546a1163d90ddebff0ccb6c59f9061d556a8 on develop.


Responsive Accordion Tabs: TypeError: Right-hand side of 'instanceof' is not an object

I'm using Foundation 6.4.2-rc2 in combination with npm<EMAIL_ADDRESS>(including source maps) and JointsWP 5. I get the following error when trying to use the Responsive Accordion Tabs component:
TypeError: Right-hand side of 'instanceof' is not an object     at e.value (foundation.responsiveAccordionTabs.js:304)     at e.value (foundation.responsiveAccordionTabs.js:239)     at e.value (foundation.responsiveAccordionTabs.js:200)     at e.t (foundation.core.js:553)     at new e (foundation.responsiveAccordionTabs.js:175)     at HTMLUListElement.<anonymous> (foundation.core.js:356)     at Function.each (jquery.js?ver=1.12.4:2)     at a.fn.init.each (jquery.js?ver=1.12.4:2)     at String.<anonymous> (foundation.core.js:338)     at Function.each (jquery.js?ver=1.12.4:2)     at Object.reflow (foundation.core.js:330)     at a.fn.init.t.fn.foundation (foundation.core.js:385)     at init-foundation.js:1
The code I've used can be found here: Pastebin. I'm using Accordion as the base for this component. The accordion works only on small when using: data-responsive-accordion-tabs="accordion medium-tabs large-tabs".
The component works on small AND medium when using data-responsive-accordion-tabs="accordion medium-accordion large-tabs" instead, so it seems the plugin fails when converting the accordion to tabs. This code is working inside the codepen examples found here when filing an issue, so I'm not sure why it's not working on my site.

I'm still having this issue with 6.4.3 and<EMAIL_ADDRESS>It would be great if anyone could give me a helping hand.

I have the same issue. Did you manage to fix it @arjendejong12?

I've replaced babel with webpack and pointed it to use the .js files in the /js/ folder, which fixed this issue for me.

@arjendejong12 could you possibly explain how you replaced babel with webpack in a way a noob like me could understand. I'm fairy new to web dev, so while I know how to write SASS/CSS, HTML, PHP and basic JS/jQuery, I've never used tools like babel and webpack. And honestly, I have to use CodeKit to compile my SASS as I kept getting errors trying to setup my environment manually per Foundation's instructions.
I too use JointsWP and are getting the same errors you were when trying to use the responsive accordion tabs.
Any help would be greatly appreciated.

This was solved in the JointsWP repo. You have to load the responsive accordion tabs after the other JS files.
https://github.com/JeremyEnglert/JointsWP/issues/273


Pastanaga Editor: Video upload does not show up on view

Go to https://plone-react.kitconcept.io/front-page
Login
Edit front page and add new video tile
-> video shows up properly
Hit save button
-> video does not show up (see screenshot)

Fixed in #204


prog: collect parents during arg traversal

It was a performance/code optimization that was originally done in https://github.com/google/syzkaller/pull/4380, but was later dropped because of the suspicions that it affected the overall fuzzing performance. Now that the big PR is merged, we can consider this change separately.

This change spares the need to construct a parents map for len[A, T] and conditional fields calculations.

27 runs (each 20hrs long) of the mainline revision vs 27 runs of this PR:

Property
mainline

impl
Δ

buffer too small
3.0

3.0
+0.0% p=0.26

candidates
0.0

0.0

corpus
18434

18387
-0.3% p=0.44

coverage
124825

125737
+0.7% p=0.27

crash types
8.0

8.0
+0.0% p=0.49

crashes
52.0

49.0
-5.8% p=0.43

exec candidate
32.0

32.0
+0.0%

exec collide
2782789

2849921
+2.4% p=0.01

exec fuzz
354183

429095
+21.2% p=0.00

exec gen
4214

4984
+18.3% p=0.00

exec hints
5771752

5960266
+3.3% p=0.11

exec minimize
2936472

2747241
-6.4% p=0.22

exec seeds
10514

10580
+0.6% p=0.64

exec smash
1067538

1078517
+1.0% p=0.54

exec total
13466299

13659620
+1.4% p=0.26

exec triage
499458

457228
-8.5% p=0.10

executor restarts
959

960
+0.1% p=0.52

filtered coverage
0.0

0.0

fuzzing
561011

561082
+0.0% p=0.73

max signal
306499

309295
+0.9% p=0.38

new inputs
67336

61701
-8.4% p=0.03

rotated inputs
38323

32472
-15.3% p=0.03

signal
200242

200818
+0.3% p=0.38

suppressed
0.0

0.0

uptime
64584

64559
-0.0% p=0.01

vm restarts
185

183
-1.1% p=0.54

Among all mainline runs, there have been found 42 different bugs. Among all runs of this PR, only 32.

After I rebased it on top of the mainline (that had a number of prog/ fixes), the fuzzing performance hit is gone. 12 20h runs per each syzkaller branch:

Property
mainline
Δ
impl
Δ

buffer too small
10.5

6.0
-42.9% p=0.16

candidates
0.0

0.0

corpus
14256

14155
-0.7% p=0.48

coverage
125832

126236
+0.3% p=0.51

crash types
7.5

10.0
+33.3% p=0.14

crashes
63.0

59.5
-5.6% p=0.85

exec candidate
32.0

32.0
+0.0%

exec collide
1161518

1167328
+0.5% p=0.98

exec fuzz
481122

465400
-3.3% p=0.74

exec gen
25654

24652
-3.9% p=0.79

exec hints
5349046

5561698
+4.0% p=0.18

exec minimize
2020474

1980280
-2.0% p=0.35

exec seeds
11820

11870
+0.4% p=0.98

exec smash
1173171

1179026
+0.5% p=0.98

exec total
10674775

10924054
+2.3% p=0.13

exec triage
515156

511694
-0.7% p=0.38

executor restarts
16896

17342
+2.6% p=0.02

filtered coverage
0.0

0.0

fuzzing
517725

517488
-0.0% p=0.51

max signal
315522

316504
+0.3% p=0.89

new inputs
55546

55814
+0.5% p=0.65

rotated inputs
34454

34750
+0.9% p=0.74

signal
171910

172680
+0.4% p=0.55

suppressed
0.0

0.0

uptime
59647

59632
-0.0% p=0.45

vm restarts
180

178
-0.8% p=0.52

@dvyukov  I think we can merge it now.


Using a const value as an index in an assignment flags modification

const { foo } = formValueObject;

let bar;
let bar[foo ?? 999] = 42;

eslint(no-const-assign): Unexpected re-assignment of const variable foo
let bar = [];
bar[parseInt("42", 10)] = 99;

eslint(no-global-assign): Read-only global 'parseInt' should not be modified.

Thank you.


docs(blog): initial post skeleton

CC @ssd71 you can write blog post in medium/dev.to or create it directly on the graphback website (or both if needed)

Closing until we are ready to work on this again.


[question] How to use HMR for typescript

For hot module replacement(reload) in asp.net core, we face some difficulties, in which typescript files do not reload on the change save process. while it is working with angular which seems to be owing to the following code snippet in their boot-client.ts
if (module['hot']) {
    module['hot'].accept();
    module['hot'].dispose(() => {
        // Before restarting the app, we create a new root element and dispose the old one
        const oldRootElem = document.querySelector('app');
        const newRootElem = document.createElement('app');
        oldRootElem.parentNode.insertBefore(newRootElem, oldRootElem);
        modulePromise.then(appModule => appModule.destroy());
    });
} else {
    enableProdMode();
}

I was wondering whether there is any solution to enable such capability for Aurelia projects or not?

This package provides the module.hot.accept functionality. It is experimental though, so it might not work in some cases. You'd have to provide a full repo to reproduce, although unfortunately right now our resources are limited and we are focusing on SSR and other important features more than on HMR.

@niieani ,
I have @shahabganji  `s problem too, The main problem comes from where we need HMR for .ts files in Aurelia like Angular.
When you use the default standard aurelia-asp.net Core template via latest dotnet new --install "Microsoft.AspNetCore.SpaTemplates::*" and dotnet new aurelia
commands you can see HMR works very well with HTML,CSS,SCSS (if you add the loader) without refreshing browser but for .ts files does not
so I want to know for this problem means HMR for .ts with Aurelia-webpack-plugin is there any solution or not ? We did not have this problem in Angular`s template (dotnet new angular), I checked the angular template in that templates and found above codes as main different for .ts HMR. (module['hot'].accept(); ... )
now the main question is , Does Aurelia-Webpack-Plugin (as HMR feature or anything else) work with .ts files without refreshing browser or not ? (we dont like to use browserSync for auto refreshing browsers !!!)

Yes, it works with TypeScript the same way as it does with JavaScript. The skeleton-navigation-webpack-typescript has an example included.

@niieani ,
Nop, I checked the example you said, I did not see HMR, when I changed any .ts files, the browser refreshed !!! but in angular examples HMR works with .ts files without refreshing browsers.
The main problem is browser refreshing for .ts files as I said above I can using browsersync for "Microsoft.AspNetCore.SpaTemplates::*" for refreshing after .ts files changes but I dont. (of course I think there is a bug !)
Can you update or test the SpaTemplates for this purpose specially because the sample uses pure wepack not easy-webpack or ... ? I think this is the same project as SpaTemplates.

The main point is that when the HMR module understands about the changes in .ts files, it refreshes the whole page and browser which leads to losing the state of the application that is not suitable.
The module.hot.accept functionality is not what I accept from Aurelia to support or not, instead I expect there'll be some replacement for it in order for us to be able to use HMR with ASP.NET MVC Core projects, just like angular that provides such functionality.
As @HamedFathi  said, both spa templates provided by Steve Sanderson in dotnet new and @EisenbergEffect are the same, and surprisingly while they understand the change of .ts files but they don't replace the new module with the old one, while they do for other files, .html, .css, .scss, and etc for instance.
I would be grateful if you could come up with any suggestion or alternative to the problem.
Had we any hint of how to implement such functionality, we could also assist providing such capability for the framework.

@HamedFathi did you run with the HMR enabled? See: https://github.com/aurelia/skeleton-navigation/tree/master/skeleton-typescript-webpack#running-with-hot-module-reload

@niieani ,
yes, I did, see these pictures
for changing TypeScript

for changing Html

If I changed .ts file then changed .html file both changes perform successfully but for .ts files need refreshing the browser

OK, so that looks like a bug in this module (HMR support in general). It's not related to TypeScript support though, I'm pretty sure you could reproduce the same problem in the JavaScript skeleton. I could be wrong though.

@EisenbergEffect , @niieani
OK, What is the next step ?!

@HamedFathi Currently SSR is a higher priority for the team than HMR.
HMR is nice-to-have, but very hard to do right and bug-free. As you can read from the issues in this repository, I believe we need to make some changes to how Aurelia works for HMR to work reliably.
I'm sorry, but I don't think this is going to be completely fixed until Aurelia 2.0, unless somebody has time (or money) to contribute to the issue of HMR specifically.


Update _index.html to include latest details and links for KubeCon

Updated the _index.html file content/de/_index.html to include the
latest links for the Cloud Native Computing Foundation’s flagship conference.
KubeCon + CloudNativeCon
KubeCon Europe on May 16-20, 2022
KubeCon North America on October 24-28, 2022

/lgtm


implementation Graph-node on Cronos failed

Do you want to request a feature or report a bug?
This is bug.
What is the current behavior?
Current Command:
graph-node --postgres-url postgresql://postgres:aaa@localhost:5432/graphnodedb --ethereum-rpc mainnet:https://evm-cronos.crypto.org --ipfs <IP_ADDRESS>:5001 --http-port 80

If the current behavior is a bug, please provide the steps to reproduce and if possible a minimal demo of the problem.
When I run cronos local node, graph-node sync blocks at first, but after a few hour, it fails with rpc error.
What is the expected behavior?
It must be run without error.

Assuming this is a duplicate of #3086, closing. Re-open if it's a different issue.


Update README

move the CLI part to an independent README.
Add description for manifest migrate and diff command

I think it may be better to leave this as is, since it's intended as a walkthrough rather than a reference. Let's discuss on Monday.

I think it may be better to leave this as is, since it's intended as a walkthrough rather than a reference. Let's discuss on Monday.

Ok that makes sense, so where is the reference supposed to be sitting at, istio.io? I think we can at least add the remaining commands part to the quick tour if not creating a new independent section. Sure, let's discuss on Monday.

@richardwxn: PR needs rebase.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@richardwxn the reference should be here:
https://preliminary.istio.io/docs/reference/commands/istioctl/
sync with @adammil2000 as I think he is working in this area.
Cheers
-steve

talked offline with @ostromart, instead of creating an independent reference in the README, I made a change to the PR to only add missing commands for the quick tour part.


Fix endpoint placeholder & security overflow

Fixes #910
Fixes firezone/product#450

Pull Request Test Coverage Report for Build eb98409f7dc294bb7034096a521d547ff7d69bf5-PR-916

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.1%) to 67.395%

Totals

Change from base Build 6c2703869ea19f5f623c8b98dbf41f0bbab1d058:
-0.1%

Covered Lines:
1048

Relevant Lines:
1555

💛  - Coveralls


CODE QUESTION #24

CODE QUESTIONS # 24 is broken. I entered it exactly how the directions say but it says it's wrong. I'm using Google Chrome browser from my desktop it is the updated version.  Here is my work
<link href="https://fonts.googleapis.com/css?family=Lobster" rel="stylesheet" type="text/css">

CatPhotoApp

Kitty ipsum dolor sit amet, shed everywhere shed everywhere stretching attack your ankles chase the red dot, hairball run catnip eat the grass sniff.

Purr jump eat the grass rip the couch scratched sunbathe, shed everywhere rip the couch sleep in the sink fluffy fur catnip scratched.

@robo21 Thank you for reporting this issue. Please use the issue template when creating an issue. I'm assuming you're on challenge "Size Your Images". If so, your code is incorrect.

Create a class called smaller-image and use it to resize the image so that it's only 100 pixels wide.

This is a standard message notifying you that this issue seems to be a request for help. Instead of asking for help here, please click the "help" button on the challenge on freeCodeCamp, which will take you to the help chatroom for that specific challenge. You can also view our full list of official chatrooms.
If you think I'm wrong in closing this issue, please reopen it and add further clarification. Thank you, and happy coding!


Add meaningful benchmarks

This PR adds meaningful benchmarks.
The benchmarks were refactored and a few were added to examine imcache performance. New README section was created to reflect benchmarks results.

Codecov Report

Merging #30 (122c584) into master (f3fd1a6) will not change coverage.
The diff coverage is n/a.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
@@           Coverage Diff           @@
##           master      #30   +/-   ##
=======================================
  Coverage   94.94%   94.94%
=======================================
  Files           9        9
  Lines         514      514
=======================================
  Hits          488      488
  Misses         22       22
  Partials        4        4

Impacted Files
Coverage Δ

hasher.go
100.00% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


Support for Python3

The script is currently not running on Python 3.
The line in question is a call to .iteritems(). This could be replaced with .items() making it work on both Python-2 and 3. The performance difference can be ignored in my opinion because the data-structure is sufficiently small. And having it work on Python-3 is overall beneficial.
I could add a PR for this. Let me know if you'd be interested.

Makes sense. 👍

How strongly do you feel about continuing Python-2 support? I see that there's a dependency on six which introduces indirections which could be removed by dropping support of Python-2.
Additionally, it would open up the doors of some very useful data-structures and syntax like type-hinting and data-classes.
Making this work on both Python-2 and -3 is feasible, but it's a bit of a drag. If you depend on it, I don't mind keeping it Python-2 compatible. But I would especially like to add type-hinting because it gives so much nicer editor support.

I still have a few systems on python 2, so don't want to remove compatibility with 2.... yet.

Ok. No worries.
Once the packaging is done, you can also use python3 on systems which use python-2 by default. Do these systems have python-2 only? Or is that just the default Python interpreter? I can understand if you have some imposed limitations. But if not, using Python-3 with a "virtual environment" on such a system might be an acceptable solution to you too?
Don't get me wrong, I don't want to tell you how to do things. And because I don't know your level of experience with Python, I just want to make sure that there's not a viable solution that could be beneficial for you as well.
In our team, we had systems limited to Python-2 for ages as well (RedHat systems). But they also had Python-3 packages available. So all that was necessary to "moderninse" our code-base was to install the Python-3 package. It can live side-by-side with Python-2 without any issues.
Then to run Python-3 applications all that's necessary is to run python3 -m venv /path/to/new-env. This creates a new "virtual environment" at the given location, and that can be used to run Python 3 applications without polluting the operating-system. All dependencies and third-party- libraries will be installed into that environment. So even uninstalling becomes as easy as nuking /path/to/new-venv.
Again, I can't stress enough that I am not adamantly hung up on Python-3. I just want to make sure that we're not sticking with Python-2 for no reason :wink:


Use Next layout for account page

Description
We would like to use the Next layout for the account page. There will be some testing and possible refactor work involved.

check also the getCustomer API call, and try not to make it everytime we land in the account page (check cache)


Theme.textTheme.button.color is ignored by RaisedButton & FlatButton

Problem:
RaisedButton and FlatButton ignore the color attribute provided by the textTheme.button.color attribute in ThemeData.
Edit: removed noise.

Any updates on this? Feels weird I can't change the text color of buttons

Same here.. Please upvote the first comment

import 'package:flutter/material.dart';

const _kPrimaryColor = Color(0xFF6D9AEC);
const _kAccentColor = Color(0xFF8FECFF);

class Themes {
  static ThemeData get light => ThemeData(
        primaryColor: _kPrimaryColor,
        accentColor: _kAccentColor,
        buttonTheme: ButtonThemeData(
          shape: RoundedRectangleBorder(
            borderRadius: BorderRadius.circular(12),
          ),
          padding: EdgeInsets.all(16),
          buttonColor: _kAccentColor,
          textTheme: ButtonTextTheme.normal,
        ),
        textTheme: TextTheme(
          display1: TextStyle(
            fontFamily: "Bahnschrift",
            color: _kPrimaryColor,
            fontSize: 14,
            fontWeight: FontWeight.w600,
          ),
          button: TextStyle(
            fontFamily: "Bahnschrift",
            color: Colors.white,
            fontSize: 16,
            fontWeight: FontWeight.w400,
          ),
        ),
      );
}

```dart
        FlatButton(
          color: Theme.of(context).primaryColor,
          onPressed: () => null,
          child: Text("Phone"),
        ),
        FlatButton(
          color: Theme.of(context).accentColor,
          onPressed: () => null,
          child: Text("Email"),
        ),

No matter what you do, the color of the button text is not themeable.

I ended up creating my own button widget based on a container which I then could style however I want:
Container(
          width: width,
          height: height,
          decoration: BoxDecoration(boxShadow: [
            BoxShadow(
              color: vButtonShadow,
              offset: Offset(-5, 5),
              blurRadius: 10,
            ),
          ]),
          child: Material(
            borderRadius: BorderRadius.circular(3),
            color: vButtonColor,
            child: InkWell(
                onTap: onPressed,
                child: Center(
                  child: Text(
                      'Lorem Ipsum',
                      style: TextStyle(color: vButtonTextColor, fontWeight: FontWeight.w600),
                      ),
                )),
          ),
        )

The colors are consts I defined in another file.

That should be a rather trivial to change in the Framework... is a pull request desired?

I have tried to change colour of DateTimePicker

        Theme(
            data: Theme.of(context).copyWith(
              primaryColor: Colors.orange,
              accentColor: Colors.green,
              buttonTheme: ButtonThemeData(textTheme: ButtonTextTheme.normal)

            ),
            child: Builder(builder: (context) {
            return Button(onTap:(){
//                  displaying picker from here
              });
            }))

I have tried everything with button theme
 buttonTheme: ButtonThemeData(textTheme: ButtonTextTheme.primary)
 buttonTheme: ButtonThemeData(textTheme: ButtonTextTheme.accent)
 buttonTheme: ButtonThemeData(textTheme: ButtonTextTheme.normal)
and many other things i have tried at in theme, but end results are not worked for me the button's text color stays same
Here is the screenshot

Guys any update on this? It's the second project I bump into this issue already. I have ended up building my own components instead of using the built in buttons

I have tried to change colour of DateTimePicker

        Theme(
            data: Theme.of(context).copyWith(
              primaryColor: Colors.orange,
              accentColor: Colors.green,
              buttonTheme: ButtonThemeData(textTheme: ButtonTextTheme.normal)

            ),
            child: Builder(builder: (context) {
            return Button(onTap:(){
//                  displaying picker from here
              });
            }))

I have tried everything with button theme
 buttonTheme: ButtonThemeData(textTheme: ButtonTextTheme.primary)
 buttonTheme: ButtonThemeData(textTheme: ButtonTextTheme.accent)
 buttonTheme: ButtonThemeData(textTheme: ButtonTextTheme.normal)
and many other things i have tried at in theme, but end results are not worked for me the button's text color stays same
Here is the screenshot

I am exactly facing the same problem as mentioned. Please look on this issue asap if possible that would be very helpful.

If Flutter team is too busy to fix broken theme stuff, can they point us in the right direction for what blockers can be addressed?

The docs of ButtonTextTheme states:
enum ButtonTextTheme {
  /// Button text is black or white depending on [ThemeData.brightness].
  normal,

  /// Button text is [ThemeData.accentColor].
  accent,

  /// Button text is based on [ThemeData.primaryColor].
  primary,
}

For normal as well as accentColor, the description is in fact working.
For primary. i have observed the text color to actually be dependent on primarySwatch rather than just primaryColor (resulting in either black or white, according to the programmatically determined brightness of your swatches' colors).
So if you want to colorize your button, you will have to pick the corresponding accentColor and set ButtonTextTheme.accent accordingly. Maybe the "TextTheme..." properties are now legacy ways to achieve the theming which have been preserved for compatibility reasons..?

I have tried to change colour of DateTimePicker

        Theme(
            data: Theme.of(context).copyWith(
              primaryColor: Colors.orange,
              accentColor: Colors.green,
              buttonTheme: ButtonThemeData(textTheme: ButtonTextTheme.normal)

            ),
            child: Builder(builder: (context) {
            return Button(onTap:(){
//                  displaying picker from here
              });
            }))

I have tried everything with button theme
 buttonTheme: ButtonThemeData(textTheme: ButtonTextTheme.primary)
 buttonTheme: ButtonThemeData(textTheme: ButtonTextTheme.accent)
 buttonTheme: ButtonThemeData(textTheme: ButtonTextTheme.normal)
and many other things i have tried at in theme, but end results are not worked for me the button's text color stays same
Here is the screenshot

I also have the same problem. Does someone knows any update or way to solve this problem?

Maybe a bit late... but you can use this:
ThemeData(
primaryTextTheme: Typography(platform: TargetPlatform.iOS).white,
textTheme: Typography(platform: TargetPlatform.iOS).white,
)
https://icetutor.com/question/how-to-change-the-entire-themes-text-color-in-flutter

Hello everyone, I have had this issue and it was very fustrating to solve, but I think I found some kind of work around.
It seems that the only way to apply color to the text of FlatButtons using a Theme is by using a ColorScheme like this:
ThemeData yourTheme= ThemeData(

    // Your themes
    // . . . maybe you could be setting the textTheme
    // . . . or the primary & secondary colors
    // . . . even set your color scheme
    ////////////////

    buttonTheme: ButtonThemeData(
      colorScheme: ColorScheme( // You need to set up a color scheme for your
        buttomTheme (even if you already did on your ThemeData)
        background: background, // NOT USED
        brightness: Brightness.light, // I have tried dark & light and it seems like this workaround only works on ligh
        error: errorColor, // NOT USED
        onBackground: Colors.black87, // NOT USED
        onError: Colors.white, // NOT USED
        onSurface: Colors.black87, // NOT USED
        onSecondary: Colors.black87, // NOT USED
        onPrimary: Colors.black, // NOT USED
        primary: secondary700, // IMPORTANT LINES: This sets the text color for FlatButtons
        primaryVariant: secondary700,
        secondary: Colors.black, // IMPORTANT LINES: This sets the text color for RaisedButtons
        secondaryVariant: Colors.black,
        surface: Colors.white, // NOT USED
      ),
      buttonColor: secondaryMain,  // IMPORTANT LINES: This sets the fill color of your raised buttons
      disabledColor: disabledColor,
      textTheme: ButtonTextTheme.accent, // IMPORTANT LINES: Makes everything happen
    );
  );

For some other reason this does not apply to DatePickers, so the workaround for those is to do the same, like this:
DateTime selectedDate = await showDatePicker(
                  context: context,
                  initialDate: DateTime.now(),
                  firstDate: DateTime.now().subtract(Duration(hours: 24)),
                  lastDate: DateTime(2030),
                  builder: (context, child) => Theme(
                    data: ThemeData(
                      colorScheme: ColorScheme(
                        background: background,
                        brightness: Brightness.light,
                        error: errorColor,
                        onBackground: Colors.black87,
                        onError: Colors.white,
                        onSurface: Colors.black87,
                        onSecondary: Colors.black87,
                        onPrimary: Colors.black,
                        primary: secondary700, //  FLAT BUTTON COLOR
                        primaryVariant: secondary700,
                        secondary: Colors.black,
                        secondaryVariant: Colors.black,
                        surface: Colors.white,
                      ),
                      primaryColor: secondaryMain, //  HEADER COLOR
                      accentColor: secondaryMain, // DATE COLOR
                      buttonTheme: ButtonThemeData(
                        textTheme: ButtonTextTheme.accent,
                      ),
                    ),
                    child: child,
                  ),
                );

Hope it works for you too ;)
Let me know if it did! :P

FWIW, I just copied the code for the time picker and modified it by explicitly setting the colors of the flat buttons, it took around 5 minutes, so that might be the quickest solution.

Currently, for showDatePicker, I prefer to use primarySwatch to set the buttons' color. This is a relatively simple way that I have found without much more modification.

Hello everyone, I have had this issue and it was very fustrating to solve, but I think I found some kind of work around.
It seems that the only way to apply color to the text of FlatButtons using a Theme is by using a ColorScheme like this:
ThemeData yourTheme= ThemeData(

    // Your themes
    // . . . maybe you could be setting the textTheme
    // . . . or the primary & secondary colors
    // . . . even set your color scheme
    ////////////////

    buttonTheme: ButtonThemeData(
      colorScheme: ColorScheme( // You need to set up a color scheme for your
        buttomTheme (even if you already did on your ThemeData)
        background: background, // NOT USED
        brightness: Brightness.light, // I have tried dark & light and it seems like this workaround only works on ligh
        error: errorColor, // NOT USED
        onBackground: Colors.black87, // NOT USED
        onError: Colors.white, // NOT USED
        onSurface: Colors.black87, // NOT USED
        onSecondary: Colors.black87, // NOT USED
        onPrimary: Colors.black, // NOT USED
        primary: secondary700, // IMPORTANT LINES: This sets the text color for FlatButtons
        primaryVariant: secondary700,
        secondary: Colors.black, // IMPORTANT LINES: This sets the text color for RaisedButtons
        secondaryVariant: Colors.black,
        surface: Colors.white, // NOT USED
      ),
      buttonColor: secondaryMain,  // IMPORTANT LINES: This sets the fill color of your raised buttons
      disabledColor: disabledColor,
      textTheme: ButtonTextTheme.accent, // IMPORTANT LINES: Makes everything happen
    );
  );

For some other reason this does not apply to DatePickers, so the workaround for those is to do the same, like this:
DateTime selectedDate = await showDatePicker(
                  context: context,
                  initialDate: DateTime.now(),
                  firstDate: DateTime.now().subtract(Duration(hours: 24)),
                  lastDate: DateTime(2030),
                  builder: (context, child) => Theme(
                    data: ThemeData(
                      colorScheme: ColorScheme(
                        background: background,
                        brightness: Brightness.light,
                        error: errorColor,
                        onBackground: Colors.black87,
                        onError: Colors.white,
                        onSurface: Colors.black87,
                        onSecondary: Colors.black87,
                        onPrimary: Colors.black,
                        primary: secondary700, //  FLAT BUTTON COLOR
                        primaryVariant: secondary700,
                        secondary: Colors.black,
                        secondaryVariant: Colors.black,
                        surface: Colors.white,
                      ),
                      primaryColor: secondaryMain, //  HEADER COLOR
                      accentColor: secondaryMain, // DATE COLOR
                      buttonTheme: ButtonThemeData(
                        textTheme: ButtonTextTheme.accent,
                      ),
                    ),
                    child: child,
                  ),
                );

Hope it works for you too ;)
Let me know if it did! :P

This Did it...... thanks

@modulovalue, @jaumard @YAPPDEF @lukepighetti @kolaente @Lootwig @vware @ch-muhammad-adil @fgatti675 @DineshTamang @migalv @ykaito21 @padmanabanSampath  There's a rather wide-reaching proposal to remedy the problems that have come up in this issue. Please take a look at https://github.com/flutter/flutter/issues/54776. We'd appreciate your feedback.

@HansMuller Thank you.
For those stumbling across this issue, please check out #54776 where a concrete solution is being proposed.