802.1X WPA2 Enterprise incorrectly uses PEAP instead of EAP even when no password is specified (IDFGH-12403)

Answers checklist.

[X] I have read the documentation ESP-IDF Programming Guide and the issue is not addressed there.
[X] I have updated my IDF branch (master or release) to the latest version and checked that the issue is present there.
[X] I have searched the issue tracker for a similar issue and not found a similar issue.

General issue report
I am attempting to connect to WPA2 Enterprise wifi which requires EAP-TLS. I call the ESP's enterprise wifi API similarly to the example/wifi-enterprise code when configured for EAP-TLS (i.e. not PEAP or TTLS). Yet, the Enterprise AP reports that the ESP is proposing PEAP, which it doesn't support and the authentication is rejected.
I'm using ESP-IDF 5.1 (as I'm also using ESP-ADF v2.6 and that's the latest supported ESP-IDF version)
My code:
	// reset
	esp_wifi_disconnect(); // wifi_connectAsStation loop start reset
	esp_wifi_stop(); // wifi_connectAsStation loop start reset

	// clear any previous client cert config
	esp_eap_client_clear_certificate_and_key();
	esp_wifi_sta_enterprise_disable(); // EAP

	// client and CA certs - length is strlen(cert) NOT INCLUDING any terminating NUL
	const unsigned char *client_cert = _wifi_clientCert.cert;
	int client_cert_len = _wifi_clientCert.cert_len;

	const unsigned char *private_key = _wifi_clientCert.pkey;
	int private_key_len = _wifi_clientCert.pkey_len;

	const unsigned char *private_key_password = _wifi_clientCert.pass;
	int private_key_passwd_len = _wifi_clientCert.pass_len;

	const unsigned char *ca_cert = _wifi_clientCert.cacert;
	int ca_cert_len = _wifi_clientCert.ca_len;

	// clear any previous EAP identity
	esp_eap_client_clear_identity();

	// set new EAP identity, certs
	esp_err_t id_err = esp_eap_client_set_identity((unsigned char const*)identity, strlen(identity)); // PEAP-TTLS? the ESP-IDF Wifi enterprise example uses this for EAP-TLS also
	esp_err_t ca_err = esp_eap_client_set_ca_cert(ca_cert, ca_cert_len);
	esp_err_t cert_err = esp_eap_client_set_certificate_and_key(client_cert, client_cert_len, private_key, private_key_len, private_key_password, private_key_passwd_len);
	esp_err_t en_err = esp_wifi_sta_enterprise_enable(); // EAP

	ESP_ERROR_CHECK(esp_wifi_set_mode(WIFI_MODE_STA) );

	// need to dynamically copy in SSID/Password here (i.e. strcpy, not just set pointer to SSID string)
	wifi_config_t wifi_config = {
		.sta = {
			.ssid = "MYSSID",
			.password = "",
			.threshold.authmode = WIFI_AUTH_OPEN,
			.pmf_cfg = {
				.capable = true,
				.required = false
			},
		},
	};

	ESP_ERROR_CHECK(esp_wifi_set_config(WIFI_IF_STA, &wifi_config) );

	// try connect
	wifi_newState(WIFI_ConnectAccessPointWaitForConnected, __LINE__);

	// - ESP_OK: succeed
	// - ESP_ERR_WIFI_NOT_INIT: WiFi is not initialized by esp_wifi_init
	// - ESP_ERR_INVALID_ARG: invalid argument
	// - ESP_ERR_NO_MEM: out of memory
	// - ESP_ERR_WIFI_CONN: WiFi internal error, station or soft-AP control block wrong
	// - ESP_FAIL: other WiFi internal errors

	esp_err_t startResult = esp_wifi_start();
	esp_err_t connectResult = esp_wifi_connect();

	// startResult is returning ESP_OK

	esp_err_t err = esp_netif_get_ip_info(_wifi_stateVars.wifista_esp_netif, &ipInfo);     // return <IP_ADDRESS>

	// At this point we wait for WIFI_EVENT events, and within <200ms we receive WIFI_EVENT_STA_DISCONNECTED with reason = WIFI_REASON_802_1X_AUTH_FAILED

For comparison, the example/wifi-enterprise code uses esp_wifi_set_config() before the enterprise API, but otherwise the same calls:
    // from example/wifi-enterprise
    ESP_ERROR_CHECK(esp_wifi_set_mode(WIFI_MODE_STA) );
    ESP_ERROR_CHECK(esp_wifi_set_config(WIFI_IF_STA, &wifi_config) );
    ESP_ERROR_CHECK(esp_eap_client_set_identity((uint8_t *)EXAMPLE_EAP_ID, strlen(EXAMPLE_EAP_ID)) );
    ESP_ERROR_CHECK(esp_eap_client_set_ca_cert(ca_pem_start, ca_pem_bytes) );
    ESP_ERROR_CHECK(esp_eap_client_set_certificate_and_key(client_crt_start, client_crt_bytes,
                                      client_key_start, client_key_bytes, NULL, 0) );
    ESP_ERROR_CHECK(esp_wifi_sta_enterprise_enable());
    ESP_ERROR_CHECK(esp_wifi_start());

The Cisco enterprise AP event logs (where XXXXXX correctly displays my EAP identity)
Event: 5400 Authentication failed
Failure Reason: 12851 Received unexpected EAP NAK message. Client rejected the conversation
Resolution: Verify that the client's supplicant does not have any known compatibility issues and that it is properly configured.
Root cause: ISE expects for regular conversation continuation but client sent outer EAP method NAK message. It means that client rejected conversation for some reason that is unknown to ISE. Known issue: CSSC <IP_ADDRESS> sends outer EAP method NAK during EAP-FAST/EAP-GTC conversation to reject the conversation according to user's input.
Username: XXXXXX

And finally quote from my network engineer with logs from their Cisco Enterprise AP:
[1:49 pm] Joseph
	11001	Received RADIUS Access-Request
	11017	RADIUS created a new session
	15049	Evaluating Policy Group
	15008	Evaluating Service Selection Policy
	15048	Queried PIP - DEVICE.Wired Dot1x
	15048	Queried PIP - Radius.User-Name
	15048	Queried PIP - Normalised Radius.RadiusFlowType
	15048	Queried PIP - Cisco.cisco-av-pair
	15048	Queried PIP - Radius.Called-Station-ID
	15048	Queried PIP - DEVICE.Location
	11507	Extracted EAP-Response/Identity
	12500	Prepared EAP-Request proposing EAP-TLS with challenge
	12625	Valid EAP-Key-Name attribute received
	11006	Returned RADIUS Access-Challenge
	11001	Received RADIUS Access-Request
	11018	RADIUS is re-using an existing session
	12301	Extracted EAP-Response/NAK requesting to use PEAP instead (*****)
	12300	Prepared EAP-Request proposing PEAP with challenge
	12625	Valid EAP-Key-Name attribute received
	11006	Returned RADIUS Access-Challenge
	11001	Received RADIUS Access-Request
	11018	RADIUS is re-using an existing session
	12851	Received unexpected EAP NAK message. Client rejected the conversation
	11504	Prepared EAP-Failure
	11003	Returned RADIUS Access-Reject

[1:50 pm] Joseph
I can see your device is proposing PEAP on  line12301 (*****)
[1:50 pm] Joseph
That means it is doing username and password

I've enabled further WPA supplicant logging, and it appears my cert is encrypted using an algorithm/digest that is not supported by mbedtls. Thus, possibly the ESP-IDF is failling to use a client cert so it reverts to PEAP (where I believe it is optional) even if a username/password isn't configured.
Method esp_eap_client_set_certificate_and_key() returns no error - it only fails to decrypt the password during the connection attempt in the background and seems to only print an error if "Print debug messages from WPA Supplicant" is turned on in idf.py menuconfig

Hi @tpbedford-oomdata, is it possible to share more details about the cert encryption? yes, wpa_supplicant logs are disabled by default.

@kapilkedawat The encryption used for the private key was des-ede3-cbc which I can see is not compiled in (MBEDTLS_DES_C is not defined by default). Once I decrypted the cert it worked OK, so I'll recrypt it with a supported algorithm for my case.
So ultimately I suppose esp_eap_client_set_certificate_and_key() should not return ESP_OK when given an unsupported cert. My cert was encrypted with des-ede3-cbc which was not supported, but this method accepted my cert. Only after esp_wifi_connect() was called, that somewhere in the background this decryption failed, and there was no error message to indicate why. The WIFI_EVENT_STA_DISCONNECTED event gave reason as WIFI_REASON_802_1X_AUTH_FAILED which doesn't tell the user anything useful.

@kapilkedawat  Further, the esp_eap_client_set_certificate_and_key() method appears to require len+1 to work. I'm reading my cert file from FAT filesystem and gave the actual length of the file. Only once I added an additional NUL and used len+1 did it succeed.
e.g.
FILE* f = fopen("mycert.pem"); // is 3048 bytes
size_t cert_len = fread(cert_buf, ..., f); // len = 3048

esp_eap_client_set_certificate_and_key(cert_buf, cert_len, pkey_buf, pkey_len, NULL, 0); // FAILS if cert_len=3048

cert_buf[cert_len] = 0; // add NUL
esp_eap_client_set_certificate_and_key(cert_buf, cert_len+1, pkey_buf, pkey_len+1, NULL, 0); // succeeds passing 3049 instead

Hi @tpbedford-oomdata,
Yes esp_eap_client_set_certificate_and_key() API needs zero terminated strings. Please see https://docs.espressif.com/projects/esp-idf/en/stable/esp32/api-reference/network/esp_wifi.html?highlight=esp_eap_client_set_certificate_and_key#_CPPv438esp_eap_client_set_certificate_and_keyPKhiPKhiPKhi .
The API returns ESP_OK because we do not attempt to parse the certificates until initiating the EAP connection. Performing this operation before establishing the connection would cause unnecessary overhead.

The API returns ESP_OK because we do not attempt to parse the certificates until initiating the EAP connection. Performing this operation before establishing the connection would cause unnecessary overhead.

Noted ("The client_cert, private_key, and private_key_password should be zero-terminated.") but,
a) it's not clear from the doc that len argument must be strlen(cert)+1 and not strlen(cert)
b) why require len as an argument at all if the cert strings are null-terminated?
I personally think the overhead of parsing the cert when calling esp_eap_client_set_certificate_and_key() would be OK: it's an infrequent operation, done once when initialising wifi, which takes several seconds to connect anyway, and otherwise there is no indication to the caller why the wifi connection attempt failed. The WIFI_EVENT event doesn't carry enough information to know if it's a bad cert, bad password, bad key, unsupported encryption algo, etc.

The API returns ESP_OK because we do not attempt to parse the certificates until initiating the EAP connection. Performing this operation before establishing the connection would cause unnecessary overhead.

Noted ("The client_cert, private_key, and private_key_password should be zero-terminated.") but, a) it's not clear from the doc that len argument must be strlen(cert)+1 and not strlen(cert) b) why require len as an argument at all if the cert strings are null-terminated?

len is required since there may be chain of certs.

I personally think the overhead of parsing the cert when calling esp_eap_client_set_certificate_and_key() would be OK: it's an infrequent operation, done once when initialising wifi, which takes several seconds to connect anyway, and otherwise there is no indication to the caller why the wifi connection attempt failed. The WIFI_EVENT event doesn't carry enough information to know if it's a bad cert, bad password, bad key, unsupported encryption algo, etc.

thanks for your input, we will take it into consideration.

Thanks for reporting, we will close this issue. Feel free to reopen if have more updates.
Thanks for using our Espressif product!


Webapi waittimes view

@kbharathala this "works" but still needs some reworking. Not sure how to handle getting wait times when the user isn't logged in, so it just defaults to whatever polling booth has an id of 1 unless the HTTP GET to /lookup/<phone> goes through. That's probably not ideal behavior.

Okay, we'll figure something else out after.


[Feature Request] Ensure primary shard recency in case of new node join in batch allocation

Is your feature request related to a problem? Please describe
Currently while allocating Unassigned shards, we clear cache for nodes where active primary shards reside in case new nodes are added to ensure we don't cancel recovery for excessively stale shards. And refetch the data from those nodes, to ensure recency.
Describe the solution you'd like
As we introduce, batch allocation of shard we need to improve on this flow where we only remove the cache for a particular shard from the node and while fetching we don't need to fetch the data for whole node, but just for particular shards of the node. And fill the cache with that data to avoid a lot of fetching.
Related component
Cluster Manager
Describe alternatives you've considered
No response
Additional context
No response

[Triage - attendees 1 2 3 4 5 6]
@shiv0408 Thanks for filing, we'd welcome a pull request to improve this experience.


zoom value

Is there zoom value configuration or zoom in/out functionality? Is it possible that Javascript changes the zoom of webcam? Thanks.

Not that I know of.  Try using a different aspect ratio.  Some cameras prefer 16:9 or 4:3 and have trouble cropping to fit into the other one.


How to get "current solar energy" value

Hi Niels!
Thank you for creating and maintaining this library. I used it for some weeks now to collect the data of my SE7K to an influx DB. Which was very easy thanks to your documentation.
What I try to figure out for some time now is how to get the "current solar power" value from the inverter. See value "A" in the following screenshot from the SolarEdge app.

The value "power" in the following script output shows 259W which matches "B" in the screenshot. This is "I_AC_Power" register 40083. I searched the registers in the SolarEdige register documentation but found no other one that could contain "A".
Value "C" I can get from the meter. Value "D" probably from the battery. Did not yet investigate that. With B, C and D I could calculate A, but is this really the way?
Inverter(localhost:1502, connectionType.TCP: timeout=1, retries=3, unit=0x1):

Registers:
        Manufacturer: SolarEdge
        Model: SE7K-RWS48BEB4
        Type: Three Phase Inverter
        Version: 0004.0013.0040
        Serial: nnnnnnnnnn
        Status: Producing
        Temperature: 37.24°C
        Current: 2.63A
        Phase 1 Current: 0.85A
        Phase 2 Current: 0.89A
        Phase 3 Current: 0.88A
        Phase 1 voltage: 409.30V
        Phase 2 voltage: 409.50V
        Phase 3 voltage: 407.80V
        Phase 1-N voltage: 235.90V
        Phase 2-N voltage: 237.20V
        Phase 3-N voltage: 235.10V
        Frequency: 49.99Hz
        Power: 259.00W
        Power (Apparent): 621.50VA
        Power (Reactive): -565.00VAr
        Power Factor: 41.56%
        Total Energy: 454451Wh
        DC Current: 0.32A
        DC Voltage: 815.20V
        DC Power: 262.94W
Batteries found:
        Model: BYD Premium LVS 8.0
        SOE: 11.0
Meters found:
        Model: SE-MTR-3Y-400V-A
        Export Energy Active: 267017Wh
        Import Energy Active: 147045Wh

Note: Screenshot and script output were take at the same time (as fast as I could press the keys on my phone and on my keyboard).
Best wishes
Stefan

In my experience the Power value you have showing 259.00W is the actual AC output of the inverter, and is therefore the "current solar energy" in most normal setups.
The presence of a battery may be complicating matters, however. While the SolarEdge app is not real time, and a poor indicator of actual current production, the values B + D = A in this case. If your battery is connected via DC to your inverter the power used to charge the battery will not be exported to the grid or used as self consumption. The inverter will therefore only report the AC power it actually outputs. In this case you will need to do some addition and subtraction.
See this previous question for a similar situation.

Thank you for pointing to the other question. The participants there made similar or the same experiences as I did. And yes my DC battery is directly connected to the SE7K.
When the sun in shining the SE7K routes energy to the inverter and to the battery or grid. But only the energy going to the inverter is shown in I_AC_Power. When its dark the SE7K routes energy from the battery to the inverter. This is then also shown in I_AC_Power.
Therefore the "production" value in the SolarEgde app is reduced by the amount of energy routed to the battery but increased by the amount taken from the battery. Of course this is not documented anywhere - or at least I did not found it.
Conclusion: I have to do the math myself.

i dont think B is from inverter. its the house load and u can read it from meter only. A from inverter is "power".

@frezeen Thanks for your feedback.
The way B is calculated depends on the setup. In my case I have an SE7K with a DC battery directly connected to the inverter.
In this setup B can come from three sources:

solar power
battery power
grid (meter power)

As the solar power and the battery power is always routed through the inverter "Power" is already the sum of both. In cases both power sources do not provide enough energy for the house there is also import from the grid. Then I have to add "Power" + "Meter Power" to get B.
In situations where we have enough power to export energy to the grid, we have to subtract "Meter Power" from "Power" to get B.
I have implemented this in a Modbus project https://github.com/stscde/modbus-esp8266-solaredge/blob/master/src/ModbusSolarEdge.cpp I am currently working on.
B is there calculated with the following method. From my comparisons in the last 7 days it gives the same values as the SolarEdge app. Therefore I am quite confident it is ok.
/**
 * Calculate power used by house (B)
 * @param i_ac_power_norm Inverter output normalized in W
 * @param m1_m_ac_power Power going through the meter in W
 */
int calculate_house_usage(int16_t i_ac_power_norm, int16_t m1_m_ac_power) {
    // NOTE: if we import power from the grid the meter value is negative

    // when exporting: remove the exported power from the inverters output to get the house usage
    // when importing: we have to add the imported power to the inverters output
    return i_ac_power_norm + (m1_m_ac_power * -1);
}

But like I said before. In other setups a different calculation may be required.
Best wishes
Stefan

Can you temporarily turn off or disconnect the battery to simplify the diagnosis and understanding? I dont have a battery, and Power setting will always match A in your diagram.

@dmaunder Thanks for your input.
When turning off the battery the system works like yours. Inverter output always matches A.
In case battery is turned on I use the following code from my project linked above to calculate the sun power. I'm using this for some month now and it works as expected.
/**
 * Calculate available sun power
 * @param i_ac_power_norm Inverter output normalized in W
 * @param b1_b_instantaneous_power Power from the battery in W
 */
int ModbusSolarEdge::calculate_sun_power(int16_t i_ac_power_norm, float b1_b_instantaneous_power) {
    // if we have no inverter output sun is not shining bright enough
    if (i_ac_power_norm <= 0) {
        return 0;
    }

    // NOTE: when the battery is loading "b1_b_instantaneous_power" is positive when unloading it is negative
    // NOTE 2: "i_ac_power_morm" contains the power used by the house + the power send to the grid but NOT the power sent to the battery BUT the power coming from the battery when unloading

    // when exporting: as the inverter output "i_ac_power_morm" already contains the power send to the grid we do not have to deal with it here
    // when importing: import from battery has to be removed from inverter output "i_ac_power_morm" as we want to have the sun power not the battery power
    i_ac_power_norm += b1_b_instantaneous_power;

    // import from battery may result in values lower 0 because of conversion losses DC > AC
    return i_ac_power_norm > 0 ? i_ac_power_norm : 0;
}

Best wishes
Stefan


GoogleCloudEnterpriseSearchRetriever fails to where location is "us"

System Info
'OS_NAME': 'DEBIAN_10'
Langchain version :  '0.0.288'
python :  3.10
Who can help?
No response
Information

[ ] The official example notebooks/scripts
[X] My own modified scripts

Related Components

[ ] LLMs/Chat Models
[ ] Embedding Models
[ ] Prompts / Prompt Templates / Prompt Selectors
[ ] Output Parsers
[ ] Document Loaders
[X] Vector Stores / Retrievers
[ ] Memory
[ ] Agents / Agent Executors
[ ] Tools / Toolkits
[ ] Chains
[ ] Callbacks/Tracing
[ ] Async

Reproduction
This issue only occurs when region != "global". The retriever works well when region is set to "global"
Steps to reproduce :

Create a Enterprise search App with region = 'us'

Import langchain version 0.0.288

import langchain
from langchain.retrievers import GoogleCloudEnterpriseSearchRetriever

PROJECT_ID = "<PROJECT_ID>"  # Set to your Project ID
SEARCH_ENGINE_ID = "<SEARCH_ENGINE_ID>"#"# Set to your data store ID

retriever = GoogleCloudEnterpriseSearchRetriever(
    project_id=PROJECT_ID,
    search_engine_id=SEARCH_ENGINE_ID,
    max_documents=3 ,
    location_id = "us"
)

retriever.get_relevant_documents("What is capital of India?")

Code errors out with below

---------------------------------------------------------------------------
_InactiveRpcError                         Traceback (most recent call last)
File /opt/conda/envs/python310/lib/python3.10/site-packages/google/api_core/grpc_helpers.py:72, in _wrap_unary_errors.<locals>.error_remapped_callable(*args, **kwargs)
     71 try:
---> 72     return callable_(*args, **kwargs)
     73 except grpc.RpcError as exc:

File /opt/conda/envs/python310/lib/python3.10/site-packages/grpc/_channel.py:1161, in _UnaryUnaryMultiCallable.__call__(self, request, timeout, metadata, credentials, wait_for_ready, compression)
   1155 (
   1156     state,
   1157     call,
   1158 ) = self._blocking(
   1159     request, timeout, metadata, credentials, wait_for_ready, compression
   1160 )
-> 1161 return _end_unary_response_blocking(state, call, False, None)

File /opt/conda/envs/python310/lib/python3.10/site-packages/grpc/_channel.py:1004, in _end_unary_response_blocking(state, call, with_call, deadline)
   1003 else:
-> 1004     raise _InactiveRpcError(state)

_InactiveRpcError: <_InactiveRpcError of RPC that terminated with:
	status = StatusCode.NOT_FOUND
	details = "DataStore projects/PROJECT_ID/locations/us/collections/default_collection/dataStores/SEARCH_ENGINE_ID not found."
	debug_error_string = "UNKNOWN:Error received from peer ipv4:<IP_ADDRESS>:443 {created_time:"2023-09-14T12:55:00.327037809+00:00", grpc_status:5, grpc_message:"DataStore projects/PROJECT_ID/locations/us/collections/default_collection/dataStores/SEARCH_ENGINE_ID not found."}"
>

The above exception was the direct cause of the following exception:

NotFound                                  Traceback (most recent call last)
Cell In[365], line 1
----> 1 retriever.get_relevant_documents("What is capital of India?")

File ~/.local/lib/python3.10/site-packages/langchain/schema/retriever.py:208, in BaseRetriever.get_relevant_documents(self, query, callbacks, tags, metadata, **kwargs)
    206 except Exception as e:
    207     run_manager.on_retriever_error(e)
--> 208     raise e
    209 else:
    210     run_manager.on_retriever_end(
    211         result,
    212         **kwargs,
    213     )

File ~/.local/lib/python3.10/site-packages/langchain/schema/retriever.py:201, in BaseRetriever.get_relevant_documents(self, query, callbacks, tags, metadata, **kwargs)
    199 _kwargs = kwargs if self._expects_other_args else {}
    200 if self._new_arg_supported:
--> 201     result = self._get_relevant_documents(
    202         query, run_manager=run_manager, **_kwargs
    203     )
    204 else:
    205     result = self._get_relevant_documents(query, **_kwargs)

File ~/.local/lib/python3.10/site-packages/langchain/retrievers/google_cloud_enterprise_search.py:254, in GoogleCloudEnterpriseSearchRetriever._get_relevant_documents(self, query, run_manager)
    251 search_request = self._create_search_request(query)
    253 try:
--> 254     response = self._client.search(search_request)
    255 except InvalidArgument as e:
    256     raise type(e)(
    257         e.message + " This might be due to engine_data_type not set correctly."
    258     )

File /opt/conda/envs/python310/lib/python3.10/site-packages/google/cloud/discoveryengine_v1beta/services/search_service/client.py:577, in SearchServiceClient.search(self, request, retry, timeout, metadata)
    570 metadata = tuple(metadata) + (
    571     gapic_v1.routing_header.to_grpc_metadata(
    572         (("serving_config", request.serving_config),)
    573     ),
    574 )
    576 # Send the request.
--> 577 response = rpc(
    578     request,
    579     retry=retry,
    580     timeout=timeout,
    581     metadata=metadata,
    582 )
    584 # This method is paged; wrap the response in a pager, which provides
    585 # an `__iter__` convenience method.
    586 response = pagers.SearchPager(
    587     method=rpc,
    588     request=request,
    589     response=response,
    590     metadata=metadata,
    591 )

File /opt/conda/envs/python310/lib/python3.10/site-packages/google/api_core/gapic_v1/method.py:113, in _GapicCallable.__call__(self, timeout, retry, *args, **kwargs)
    110     metadata.extend(self._metadata)
    111     kwargs["metadata"] = metadata
--> 113 return wrapped_func(*args, **kwargs)

File /opt/conda/envs/python310/lib/python3.10/site-packages/google/api_core/grpc_helpers.py:74, in _wrap_unary_errors.<locals>.error_remapped_callable(*args, **kwargs)
     72     return callable_(*args, **kwargs)
     73 except grpc.RpcError as exc:
---> 74     raise exceptions.from_grpc_error(exc) from exc

NotFound: 404 DataStore projects/PROJECT_ID/locations/us/collections/default_collection/dataStores/SEARCH_ENGINE_ID not found.

Expected behavior
Code should return three relevant documents from Enterprise Search

This was fixed in #10513 v0.0.310
Update to that version or greater and specify the location parameter.
Regional Data Stores require the endpoint to be set manually, which was not implemented in earlier versions of the retriever.

Thanks @holtskinner . I confirm that this works in higher versions.


chat does not fully/correctly scroll down

The chat does not fully/correctly scroll down. There might be some problem with how the $watch interacts with the state-updates.

seems like duplicate of #1053


HHH-10661 - Reduce code duplication in serialize method of StatefulPersistenceContext

https://hibernate.atlassian.net/browse/HHH-10661
Supersedes https://github.com/hibernate/hibernate-orm/pull/2357

I will apply this, nice cleanup thanks


Can not get autocomplete for page object method

What are you trying to achieve?
I'm trying to get autocomplete on codeceptjs. I define a method that has a name like "inputXYZ" in a page object "page1" then I add "page1" into inject(). So I expect I can get the method "inputXYZ" autocomplete when I call "page1"
Details

CodeceptJS version: 2.6.2
NodeJS Version: v10.16.0
Operating System: Windows 10
playwright

@ledaivuong  Hi! Did you try generating the type definitions in the steps.d.ts file with npx codeceptjs def . command? Worked for me :)


Release API endpoints

Adds the following endpoints:

GET /repos/:user/:repo/releases: List a repository's releases
GET /repos/:user/:repo/releases/:id: Get a release
POST /repos/:user/:repo/releases: Create a new release
PATCH /repos/:user/:repo/releases/:id: Edit a release
DELETE /repos/:user/:repo/releases/:id: Delete a release

See also https://github.com/go-gitea/go-sdk/pull/31, #330

https://developer.github.com/v3/repos/releases/

@bkcsoft Updated to include changes to https://github.com/go-gitea/go-sdk/pull/31

@bkcsoft Updated to include changes to https://github.com/go-gitea/go-sdk/pull/31

LGTM

LGTM

LGTM

LGTM


Download with Progress throws exception

Moved from https://github.com/robinrodricks/FluentFTP.GnuTLS/issues/131
FTP Server OS: Unix
FTP Server Type: Pure-FTPd
Client Computer OS: Windows
FluentFTP Version: https://github.com/robinrodricks/FluentFTP/commit/fb2ee75f08929685bf5cfd9447d5343c3ffc7fc6 (master)
Framework: .NET  8
With the following code an exception is thrown. It is not thrown with progress disabled.
var downloadProgress = new Progress<FtpProgress>(p =>
{
    var progress = (int)p.Progress;
    if (progress % 10 == 0)
    {
        _logger.LogInformation(
            "Progress: {Progress:F1}% ETA: {Eta}",
            p.Progress,
            p.ETA);
    }
});

var client = new AsyncFtpClient(host, username, password);
client.Config.CustomStream = typeof(GnuTlsStream);
await client.AutoConnect(cancellationToken).ConfigureAwait(false);
var downloadStatus = await client.DownloadFile(
        fileDestinationPath,
        normalizedFilePath,
        verifyOptions: FtpVerify.OnlyChecksum | FtpVerify.Retry | FtpVerify.Delete,
        progress: downloadProgress,
        token: cancellationToken)
    .ConfigureAwait(false);

Logs :
FluentFTP.Exceptions.FtpException: Error while downloading the file from the server. See InnerException for more info.
 ---> System.ArgumentException: GnuTlsInternalStream.Read: maxCount must be greater than zero
   at FluentFTP.GnuTLS.GnuTlsInternalStream.Read(Byte[] buffer, Int32 offset, Int32 maxCount)
   at System.IO.Stream.<>c.<BeginReadInternal>b__38_0(Object <p0>)
   at System.Threading.Tasks.Task`1.InnerInvoke()
   at System.Threading.ExecutionContext.RunFromThreadPoolDispatchLoop(Thread threadPoolThread, ExecutionContext executionContext, ContextCallback callback, Object state)
--- End of stack trace from previous location ---
   at System.Threading.ExecutionContext.RunFromThreadPoolDispatchLoop(Thread threadPoolThread, ExecutionContext executionContext, ContextCallback callback, Object state)
   at System.Threading.Tasks.Task.ExecuteWithThreadLocal(Task& currentTaskSlot, Thread threadPoolThread)
--- End of stack trace from previous location ---
   at FluentFTP.FtpSocketStream.ReadAsync(Byte[] buffer, Int32 offset, Int32 count, CancellationToken token)
   at FluentFTP.FtpDataStream.ReadAsync(Byte[] buffer, Int32 offset, Int32 count, CancellationToken token)
   at FluentFTP.AsyncFtpClient.DownloadFileInternalAsync(String localPath, String remotePath, Stream outStream, Int64 restartPosition, IProgress`1 progress, CancellationToken token, FtpProgress metaProgress, Int64 knownFileSize, Boolean isAppend, Int64 stopPosition)
   --- End of inner exception stack trace ---
   at FluentFTP.AsyncFtpClient.DownloadFileInternalAsync(String localPath, String remotePath, Stream outStream, Int64 restartPosition, IProgress`1 progress, CancellationToken token, FtpProgress metaProgress, Int64 knownFileSize, Boolean isAppend, Int64 stopPosition)
   at FluentFTP.AsyncFtpClient.DownloadFileToFileAsync(String localPath, String remotePath, FtpLocalExists existsMode, FtpVerify verifyOptions, IProgress`1 progress, CancellationToken token, FtpProgress metaProgress)
   at FluentFTP.AsyncFtpClient.DownloadFile(String localPath, String remotePath, FtpLocalExists existsMode, FtpVerify verifyOptions, IProgress`1 progress, CancellationToken token)

Thanks for opening this here. What exactly is the code base you are using, as the current master has tried to address this topic?
Also I would appreciate the complete log. If you read the other issues, you will notice that the connect FEAT command response and other things that precede the actual download play an important role in how the problem develops.

Code base: Current master, sorry I used ambiguous terms.
Thanks for the log, I will study them...
First glance tells me it is still related to the progress problems I linked you to - I will need some time to check this, please stand by.

I linked the commit that I used to make sure I had the latest one: https://github.com/robinrodricks/FluentFTP/commit/fb2ee75f08929685bf5cfd9447d5343c3ffc7fc6

This was automatically closed by GitHub because of the wording I used in the commit text... so I reopened.
Please test with the newest master - this should now be ok.

I can confirm that I am no longer getting this exception with e84c034d27bf43091a999fc70a4b6786f5ba9b16 applied

Great! Thanks for your efforts.


Fix container with same name start

The current command docker ps with filter by name might return multiple
containers. See docs:

The name filter matches on all or part of a container’s name
https://docs.docker.com/engine/reference/commandline/ps/#name

The proposed method uses container inspect with a fallback to ignore
the return code 1 and formats to only return the Id

Hey,
thank you for your contribution. It looks reasonable then to use inspect with formatting. I test it as soon as possible. 👍

Sorry for the long delay. I did some local tests and as stated above, it's more reliable to use docker container inspect instead of docker ps -qaf name="".
Looks good to me. I merge it. 👍


TypeError: Context processor UnfoldAdminLoader didn't return a dictionary.

What version of Unfold are you using?
0.40.0
What version of Django are you using?
5.0.4
What browser are you using?
Arc browser, latest one 1.63.1
Did you checked changelog/commit history, if the bug is not already fixed?
Yes
Did you searched other issues, if the bug is not already fixed?
Yes
Did you checked documentation?
Yes
Are you able to replicate the bug in the demo site?
No
Describe your issue
I was using django unfold reading the unfold documentation. I needed to migrate the models and I am using custom user models as below:

from django.db import models
from django.contrib.auth.models import (
    AbstractUser,
    BaseUserManager,
    PermissionsMixin,
)
from rest_framework_simplejwt.tokens import RefreshToken

from beatsbazaar import boto3

class CustomUserManager(BaseUserManager):
    def create_user(self, email, password=None, **extra_fields):
        if not email:
            raise ValueError("The Email field must be set")
        email = self.normalize_email(email)
        user = self.model(email=email, username=email, **extra_fields)
        if password:
            user.set_password(password)
        user.save()
        return user

    def create_superuser(self, email, password=None, **extra_fields):
        extra_fields.setdefault("is_staff", True)
        extra_fields.setdefault("is_superuser", True)

        if extra_fields.get("is_staff") is not True:
            raise ValueError("Superuser must have is_staff=True")

        if extra_fields.get("is_superuser") is not True:
            raise ValueError("Superuser must have is_superuser=True")

        return self.create_user(email, password, **extra_fields)

class User(AbstractUser, PermissionsMixin):
    email = models.EmailField(max_length=100, unique=True)
    password = models.CharField(max_length=100, blank=True, null=True)
    name = models.CharField(max_length=100, blank=True, null=True)
    picture = models.CharField(max_length=300, blank=True, null=True)
    date_joined = models.DateTimeField(auto_now_add=True)
    is_active = models.BooleanField(default=True)
    is_superuser = models.BooleanField(default=False)
    is_staff = models.BooleanField(default=False)

    objects = CustomUserManager()

    def to_json(self):
        return {
            "id": self.pk,
            "username": self.username,
            "name": self.name,
            "picture": boto3.get_presigned_url(self.picture),
        }

    @property
    def get_followers(self):
        return FollowUser.objects.filter(followed_to=self)

    @property
    def get_followings(self):
        return FollowUser.objects.filter(followed_by=self)

    USERNAME_FIELD = "email"
    REQUIRED_FIELDS = []

    def get_token(self):
        refresh = RefreshToken.for_user(self)
        return {"refresh": str(refresh), "access": str(refresh.access_token)}

    def __str__(self):
        return self.email

I did register it in admin.py file as
from django.contrib import admin

# Register your models here.

from django.contrib.auth.admin import UserAdmin as DjangoUserAdmin
from unfold.admin import ModelAdmin
from .forms import UserCreateForm, UserEditForm
from .models import User
from beatsbazaar.sites import new_admin_site

@admin.register(User)
class CustomUserAdmin(DjangoUserAdmin):
    add_form = UserCreateForm
    form = UserEditForm
    model = User
    list_display = ["email", "name", "is_active", "is_staff", "is_superuser"]
    fieldsets = (
        (None, {"fields": ("email", "password")}),
        ("Personal info", {"fields": ("name", "picture")}),
    )

@admin.register(User, site=new_admin_site)
class UnfoldCustomUserAdmin(ModelAdmin):
    pass

Here is the error I got

Please note that, I am using channels with asgi.py and my codebase uses sync_to_async and other channel methods/features extensively.
Looking forward for a positive feedback. Thanks

"Context processor UnfoldaAdminLoader didn't return a dictionary".
UnfoldAdminLoader is template  loader belonging into loaders sections in TEMPLATES, not context_processors.


Refs #32338 -- Rendered Radio and Checkbox in  tags

Refs ticket 32338

Wow! Great to see this happen. I’ll try to review this over the weekend.

buildbot, test on selenium.

@smithdc1 Can you take a look at Thibaud's comments?


Code samples for MSAL net Client assertions are incorrect and outdated

Both exp and nbf should be numbers in the token, not strings.
manually creates RSACryptoServiceProvider which is superseded by certificate.GetRSAPrivateKey();

I'll try to submit a PR for this, if I manage to checkout this massive repository (Even Codespaces doesn't checkout the code correctly).

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: fc3f2cc1-73e4-8d32-bd46-30a84e28f710
Version Independent ID: 4ccd0fa0-91de-4c53-6a63-3175a433a0df
Content: Client assertions (MSAL.NET) - Microsoft identity platform
Content Source: articles/active-directory/develop/msal-net-client-assertions.md
Service: active-directory
Sub-service: develop
GitHub Login: @jmprieur
Microsoft Alias: jmprieur

@svrooij
Thanks for your feedback! I've assigned this issue to the author who will investigate and update as appropriate.

@JamesTran-MSFT I already created a PR #86636 with a fix, there is the same author tagged. If that PR is accepted this issues is auto closed.


go mod tidy

/retest

/retest

I saw this in the most recent test failure:
E0818 23:57:23.219244       1 logr.go:265]  "msg"="Failed to get API Group-Resources" "error"="Get \"https://<IP_ADDRESS>:443/api?timeout=32s\": dial tcp <IP_ADDRESS>:443: i/o timeout"
E0818 23:57:23.219285       1 logr.go:265] setup "msg"="starting manager" "error"="Get \"https://<IP_ADDRESS>:443/api?timeout=32s\": dial tcp <IP_ADDRESS>:443: i/o timeout"

In KCC we observed something similar when the test pod didn't have enough memory and it was OOMing (and presumably killing kube-apiserver).  We eventually noticed an OOM event on one of the pods there, but I haven't seen any direct evidence in the logs here ... yet.  But we just doubled the memory and (anecdotally) the tests did become much more consistent.

@justinsb thanks for sharing the observation! @sdowell it looks like something we can do to reduce test flakiness.

@justinsb Thank you so much for sharing the observation! In your case was it an issue of the available memory on the node or with the pod resource requests/limits?

/retest

/lgtm

/retest

/retest


Mac m1, not able to compile

Current Behavior
Java spring project: fat file, but missing compatible architecture (have (i386,x86_64,unknown), need (arm64e))
Expected Behavior
Project should compile
Suggested Fix
No idea
tesseract -v
No response
Operating System
macOS 12 Monterey
Other Operating System
No response
uname -a
No response
Compiler
No response
CPU
silicon m1
Virtualization / Containers
No response
Other Information
No response

This is not a proper issue report. This is a C++ project, not Java.
This project compiles without problem on Apple M1 see https://github.com/tesseract-ocr/tesseract/issues/3286

This is not a proper issue report. This is a C++ project, not Java. This project compiles without problem on Apple M1 see #3286

Where should I report this issue?


Does SRS support push HEVC/H.265 over WebRTC(whip) using OBS ?

Describe the bug
Does SRS support push HEVC/H.265 over WebRTC using OBS ? I don't know whether SRS or OBS does not support push HEVC/H.265 over WebRTC ?
Version
SRS 6.0.155

I think it's a bug, HEVC/H.264 over WebRTC is supported by SRS, but when it is the WHIP publish, the code will force RTC downgrade to H.264 during SDP negotiation.
https://github.com/ossrs/srs/blob/741613426251c9988304aa79b255bc3d8511d7a2/trunk/src/app/srs_app_rtc_conn.cpp#L2754-L2757
There's a recent related issue #4259 , which is publish by GB28181 with HEVC, but play offer said SRS only support H.264.
Maybe adjust the SDP negotiation can fix this issue, I'll try later.

I think it's a bug, HEVC/H.264 over WebRTC is supported by SRS, but when it is the WHIP publish, the code will force RTC downgrade to H.264 during SDP negotiation.
https://github.com/ossrs/srs/blob/741613426251c9988304aa79b255bc3d8511d7a2/trunk/src/app/srs_app_rtc_conn.cpp#L2754-L2757
There's a recent related issue #4259 , which is publish by GB28181 with HEVC, but play offer said SRS only support H.264. Maybe adjust the SDP negotiation can fix this issue, I'll try later.

I made a mistake, I didn't add codec=hevc in the whip url parameters. After I did this, It worked

oh, I just knows that.
repeat the solution: use the whip url with codec: http://localhost:1985/rtc/v1/whip/?app=live&stream=livestream&codec=hevc

oh, I just knows that. repeat the solution: use the whip url with codec: http://localhost:1985/rtc/v1/whip/?app=live&stream=livestream&codec=hevc

push stream was successful, but it still cannot be played normally in Chrome, even though I have turned on hardware-accelerated video decode flag. can you try it?

I I found a way to play the hevc stream over WebRTC in chrome. Add two param to start chrome "--enable-features=WebRtcAllowH265Receive --force-fieldtrials=WebRTC-Video-H26xPacketBuffer/Enabled".


A11y_Azure Tools Storage Explorer_Manage Access Policies_Manage Access Policies_HeadingAndLabels:Access Policies looks like a heading but it is not defined using any heading level

Check out Accessibility Insights! - Identify accessibility bugs before check-in and make bug fixing faster and easier.
GitHub Tags:
#A11yMAS; #A11yTCS; #Win11; #DesktopApp; #A11ySev3; #BM_Azure Tools Storage Explorer_May2022; #Azure Tools Storage Explorer; #WCAG2.4.6; #Headings and Labels; #FTP;
Environment Details:
Application: Microsoft Azure Storage Explore
version: 1.24.0
OS Details
Microsoft Windows 11 Enterprise
version 21H2 OS Build 22000.613
Repro Steps:

Launch Storage Explorer
Navigate to "Open Connect dialog" pane and Sign in to Azure.
Go to "Manage Accounts" pane and Select the subscriptions you will use. Once selected, click on "Open Explorer" button.
Navigate to "Blob Containers" of the selected subscription, right click and Select "Create Blob Container" and hit enter.
Right Click on newly created blob container and select "Manage Access Policies" and hit enter.
Verify that the text "Access Policies" is MAS Compliant.

Actual results:
"Access Policies" text present in "Manage Access Policies" window looks like heading, but it is not defined in any heading level.
Expected results:
"Access Policies" text should be defined using H1 level heading.
User Impact:
Users might get confused if "Access Policies" text is not defined using any heading level.
Attachments:

Hi @ManishaC1
Please verify that this bug is fixed using the Storage Explorer build at: https://storageexplorerpublish.blob.core.windows.net/privatebuilds/20220624.3-accessibility-testing/StorageExplorer-ia32.exe

Issue is resolved in the provided environment(ver 1.25.0). Hence closing the bug.


Workaround git log --since missing commits

Git's walking mechanism stops as soon as it sees a commit which is older than the date specified by --since.
This is problematic in LLVM's commit history in August 2022, because there is a commit in the middle of it with a CommitDate in 2021.
Work around this by considering a large number of commits and taking the oldest one matching the target date. I'll do the August pack build and confirm that everything is OK before merging this.
Fix #89.
Signed-off-by: Peter Waller<EMAIL_ADDRESS>

I've shipped the 202208 pack using this, now requesting review but also happy to merge it as-is.


Incorrect dependency version installed when specifying a git commit.

Issue description
When I try to install a specific git commit of a repository, pipenv ignores the commit hash and installs the head.
Expected result
I expect to see the specified commit hash replicated in Pipfile.lock and the specified commit of the package installed in the virtual environment.
Actual result
The Pipfile.lock contains "ref": null in the package entry and the head of the package repository is installed in the virtual environment.
Steps to replicate
mkdir test
cd test
pipenv install git+https://github.com/myhdl/myhdl.git@ae25af4d593d20a26c85fbb17c0cd98a026e8595

Inspect the myhdl entry in Pipfile.lock. On my system the ref is set to null.
To confirm, perform an additional check:
pipenv shell
pip freeze

Which confirms that the installed myhdl is the head.
My debugging efforts
Release 2023.7.23 works as expected.
Releases 2023.8.19 and 2023.8.20 fail with an error.
Subsequent releases look to complete successfully but install the wrong version and set null in the lock file.
The problematic code looks to be on lines 115 to 118 of pipenv/pipenv/utils/locking.py

See same issue (ref is null using git source w/commit hash) on MacOS w/python 3.11

I tried reproducing  this without luck on Windows and ubuntu without luck, here is the output from Windows:
matte@LAPTOP-N5VSGIBD MINGW64 ~/Projects/pipenv-triage/issue-5973
$ pipenv install git+https://github.com/myhdl/myhdl.git@ae25af4d593d20a26c85fbb17c0cd98a026e8595
Creating a virtualenv for this project...
Pipfile: C:\Users\matte\Projects\pipenv-triage\issue-5973\Pipfile
Using default python from C:\Users\matte\AppData\Local\Programs\Python\Python311
\python.exe (3.11.2) to create virtualenv...
[ ===] Creating virtual environment...created virtual environment CPython3.11.2.
final.0-64 in 4083ms
  creator CPython3Windows(dest=C:\c\users\matte\.virtualenvs\issue-5973-2dbfxMHD
, clear=False, no_vcs_ignore=False, global=False)
  seeder FromAppData(download=False, pip=bundle, setuptools=bundle, wheel=bundle, via=copy, app_data_dir=C:\Users\matte\AppData\Local\pypa\virtualenv)
    added seed packages: pip==23.2.1, setuptools==68.2.2, wheel==0.41.2
  activators BashActivator,BatchActivator,FishActivator,NushellActivator,PowerShellActivator,PythonActivator

Successfully created virtual environment!
Virtualenv location: C:\c\Users\matte\.virtualenvs\issue-5973-2dbfxMHD
Creating a Pipfile for this project...
Installing
git+https://github.com/myhdl/myhdl.git@ae25af4d593d20a26c85fbb17c0cd98a026e8595
...
Resolving
git+https://github.com/myhdl/myhdl.git@ae25af4d593d20a26c85fbb17c0cd98a026e8595
...

Installation Succeeded
Pipfile.lock not found, creating...
Locking [packages] dependencies...
Building requirements...
Resolving dependencies...

INFO:pip.subprocessor:Running command git rev-parse -q --verify 'sha^ae25af4d593d20a26c85fbb17c0cd98a026e8595'
INFO:pip.subprocessor:Running command git fetch -q https://github.com/myhdl/myhdl.git ae25af4d593d20a26c85fbb17c0cd98a026e8595
INFO:pip.subprocessor:Running command git checkout -q ae25af4d593d20a26c85fbb17c0cd98a026e8595
Locking [dev-packages] dependencies...
Updated Pipfile.lock (15e8a5eda9949e87102c00fa1884a3c3f27288c8934043801db642adb16969ca)!
Installing dependencies from Pipfile.lock (6969ca)...
To activate this project's virtualenv, run pipenv shell.
Alternatively, run a command inside the virtualenv with pipenv run.

matte@LAPTOP-N5VSGIBD MINGW64 ~/Projects/pipenv-triage/issue-5973
$ cat Pipfile
[[source]]
url = "https://pypi.org/simple"
verify_ssl = true
name = "pypi"

[packages]
myhdl = {ref = "ae25af4d593d20a26c85fbb17c0cd98a026e8595", git = "git+https://github.com/myhdl/myhdl.git"}

[dev-packages]

[requires]
python_version = "3.9"

matte@LAPTOP-N5VSGIBD MINGW64 ~/Projects/pipenv-triage/issue-5973
$ cat Pipfile.lock
{
    "_meta": {
        "hash": {
            "sha256": "15e8a5eda9949e87102c00fa1884a3c3f27288c8934043801db642adb16969ca"
        },
        "pipfile-spec": 6,
        "requires": {
            "python_version": "3.9"
        },
        "sources": [
            {
                "name": "pypi",
                "url": "https://pypi.org/simple",
                "verify_ssl": true
            }
        ]
    },
    "default": {
        "myhdl": {
            "git": "git+https://github.com/myhdl/myhdl.git",
            "ref": "ae25af4d593d20a26c85fbb17c0cd98a026e8595"
        }
    },
    "develop": {}
}

Also just verified this example worked on mac os using latest pipenv -- I am at a loss as to what you are saying.

Could this caused by different python versions?
Diff between your Pipfile and mine:
12c12
< python_version = "3.10"
---
> python_version = "3.9"

Diff between your Pipfile.lock and mine:
4c4
<             "sha256": "e967d6ee54dd082c5c5035ebd37e2a7f61e5d627203f1775300d3181df5a91a2"
---
>             "sha256": "15e8a5eda9949e87102c00fa1884a3c3f27288c8934043801db642adb16969ca"
8c8
<             "python_version": "3.10"
---
>             "python_version": "3.9"
21c21
<             "ref": null
---
>             "ref": "ae25af4d593d20a26c85fbb17c0cd98a026e8595"

The windows test was actually using:

Using default python from C:\Users\matte\AppData\Local\Programs\Python\Python311
Not sure why it had 3.9 in Pipfile (possibly separate issue)

I used a variety of pythons across the three OS tests I ran and could not reproduce it.   Doesn't mean its not an issue for you, but I am not sure yet what could be causing it.

It is likely worth re-labelling this as a regression (in addition to a legitimate bug), unless it is unable to be reproduced.

I can replicate this issue on Pipenv 2023.12.1

@ohshazbot could you check if you experience it on this branch:  https://github.com/pypa/pipenv/pull/6276

Thank you so much for this analysis @ohshazbot -- it is exactly as you describe and the cause of why I opened https://github.com/pypa/pipenv/issues/6266
Your findings will help me narrow this regression down further in the future.


Add v2 API to FileParsers

This applies the same ideas used for the SMILES and SMARTS parsers
Fixes #7074

@bp-kelley did you intended to approve this?


fix(tagging): Support paste with tagging enabled and tagging-label="false"

Fixes #1668

Looks like a perfect PR, thanks! :smile:


fix: mount host filesystem as bind rslave mount

Changes
Fixes https://github.com/open-telemetry/opentelemetry-demo/issues/1722
See https://github.com/docker/compose/issues/12139 (since Docker compose v2.29.6)
Merge Requirements
For new features contributions, please make sure you have completed the following
essential items:

[ ] CHANGELOG.md updated to document new feature additions
* [ ] Appropriate documentation updates in the docs
* [ ] Appropriate Helm chart updates in the helm-charts

Maintainers will not merge until the above have been completed. If you're unsure
which docs need to be changed ping the
@open-telemetry/demo-approvers.

Tested on a Linux environment, @open-telemetry/demo-approvers It would be very appreciated if someone else could test these changes on their end too. Thanks!

@rogercoll I'll merge this one, and we can investigate further if any windows user starts to get any errors.


Testing/Helping

Hi there, I've just purchased an Inky phat for my rpi0 and I'm trying to get your repo to work. I wanted to reach out to you and see how this project is coming along and if there's anything I can do to test/help out?
I've got the yellow version of the Inky phat. So far, I've added this repo as a dependency to a basic Nerves sandbox and I'm able to interact with with it over ssh in an iex session.
I ran the few commands I saw in the "Examples" comment under Inky.ex and all went well until I ran Inky.show(state).
iex(20)> Inky.show(state) "send_command/2" "spi_write/3 binary" ** (MatchError) no match of right hand side value: {:error, :timeout}     (inky_zero_nerves) lib/inky/inky.ex:279: Inky.spi_write/3     (inky_zero_nerves) lib/inky/inky.ex:85: Inky.setup/2     (inky_zero_nerves) lib/inky/inky.ex:135: Inky.update/3
I haven't got time right now to dig in further and see if I can get this to work, but I would like to spend some time playing with it over the holidays. I figured it'd be good to drop you a line and say hi before I got to tinkering with it.
Anyhow, I'll see what I can do on my own over the next few days and check back later with a progress report. Until then, thanks for the work you've done here!

Hello again, I ended up forking this repo and pushing a few commits that allowed me to update the screen using Inky.show(state) after setting the state with Inky.setup(nil, :phat). I also started working on an umbrella app that uses my fork as a target dep alongside Mogrify with the goal of displaying an image. I've still got a long way to go there, but I wanted to let you know I've made a little progress. Here's the fork:
https://github.com/jasonmj/inky_zero_nerves


No translation for ballot paper

use OpenSlides with English menus
create an election
create the ballot paper

result: the ballot paper is in German

The language of the texts in the generated PDFs seems to be set from the browser language only. I have the same issue if I try to print ballot papers in German. You should consider adding a language setting somewhere.

Right, currently (in OpenSlides 2.0) the language of generated pdfs is based on the browser language. It's independent from the client side language chooser which impacts on html templates only. We have the same issue for all config fields: the are generated and translated from server side. And the server detected the browser language not any client-side language choice.
Our plan is for future versions to bring all translations to client-side (also pdf which should generated from JavaScript by jsPDF, see #1640). Additional we have to save the language choice in cookie that OpenSlides can remember the choice after reload.

Our plan is for future versions to bring all translations to client-side (also pdf which should generated from JavaScript by jsPDF, see #1640).

Bug #1640 is now closed but the bug is still in OS 2.1dev

Retested with current master, where we use always client side pdf creation: Election ballot pdf is now in the requested language. So fixed for me.

Confirmed fixed.


put to_xml and from_xml on the OME class

modification for you to consider...  this puts most of the main functionality in the OME class namespace:
from ome_types import OME

ome = OME.from_xml('path/to/ome.xml')
xml = ome.to_xml()
some_dict = ome.to_dic()

Oh, I guess this got auto-closed when I merged the PR or deleted its branch after? Sorry. Anyway, I'm actually against this change. I think the model class API should stick to representing the model itself, not XML parsing/generation or anything else. I've used (and written!) APIs that add I/O to model classes, and it always just gets messy.

I agree with you for pretty much all of the model, and I wouldn't want this pattern to proliferate to the inner nodes...  the OME class just seems a little special and has the potential to be the one main export from this library.  Not gonna die on that hill though... but i do think that if we don't do this we should start cleaning up the organization of the main library exports.

The simplest and probably most common use case is parsing XML into an OME object and trawling through the fields for whatever the user needs, i.e. read-only. For this, the user actually only needs to import from_xml, not even OME. I 100% agree we should clean up the exports and module organization!

Sorry I should clarify a little better: If the goal is to simplify the requirements for the user, I was pointing out that the most common use case already has a very simple interface: the from_xml function. More complex use cases would require importing a few more pieces, and that's fine.


Refine module/app build process

See discussion here: https://github.com/ScottLogic/d3fc-showcase/pull/537#discussion_r49850253

Using Browserify might also simplify things - we don't currently get much benefit (in terms of bundle size) in using rollup, and the tools around Browserify are more mature. I made a start here https://github.com/tlsim/d3fc-showcase/commits/browserify

Using Browserify might also simplify things - we don't currently get much benefit (in terms of bundle size) in using rollup, and the tools around Browserify are more mature. I made a start here https://github.com/tlsim/d3fc-showcase/commits/browserify

Sounds good :)
Another option: use rollup for our code (to allow us to use ES6 modules) and concat/uglifiy to generate a single file with all of our dependencies. In my mind it's fairly simple and should be easy to maintain.
No strong feelings at the moment though - too many options!

The linked comment is no longer relevant due to seedrandom integration for the app only (and not the consumed module).


Camera freeze after using a while

Steps to Reproduce
If I rotate the phone or tap on the camera len for a while, the preview will be freeze. If I restart the app, it works. I think the camera can't adapt new exposure or focus frequently.
Expected results
The preview doesn't drop or auto restart new when there is a problem.
About your device

Brand
Model
OS

Apple
iPhone 7
14.2

@dim-apparence this is an issue for our iOS master

Hello @vimaxwell I'm currently working on the video support for iOS. Seems to be fixed in this future branch (in progress, very instable for now).

the bug still exists. but the frequency is smaller


"Invalid attribute value type" exception with Boolean property

When applying DynamoDBProperty to a Boolean, PutItemAsync throws ValidationException "Invalid attribute value type"
Changing the type to Integer resolves the issue.

@SailAwayWine can you please provide code of your entity that leads to this error? I can't reproduce the issue on my side. The only scenario I can think of that can lead to this issue is mapping primary key that has type Number in DDB to bool property in C#.

Yes.  Looks like using a BOOL as the Hash Key for a Global Secondary Index is not supported by DynamoDB, which is what I was trying to do.  Sorry for the false bug.


Updated core-components.md

Added the URL to find the Tenant ID through the Azure Portal.
As lot of people just put there email id rather than Tenant ID. Have a lot issue posted on the same in community.

Docs Build status updates of commit a255555:
:warning: Validation status: warnings

File
Status
Preview URL
Details

power-platform/guidance/coe/setup-core-components.md
:warning:Warning

Details

power-platform/guidance/coe/setup-core-components.md

Line 76, Column 42: [Warning: file-not-found - See documentation] Invalid file link: 'azure/active-directory/fundamentals/active-directory-how-to-find-tenant'.
Line 325, Column 42: [Warning: file-not-found - See documentation] Invalid file link: 'azure/active-directory/fundamentals/active-directory-how-to-find-tenant'.

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Docs Build status updates of commit 89c9417:
:warning: Validation status: warnings

File
Status
Preview URL
Details

power-platform/guidance/coe/setup-core-components.md
:warning:Warning

Details

power-platform/guidance/coe/setup-core-components.md

Line 76, Column 42: [Warning: file-not-found - See documentation] Invalid file link: '../../fundamentals/active-directory-how-to-find-tenant'.
Line 325, Column 42: [Warning: file-not-found - See documentation] Invalid file link: '../../fundamentals/active-directory-how-to-find-tenant'.

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Docs Build status updates of commit 8912261:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

power-platform/guidance/coe/setup-core-components.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Docs Build status updates of commit 34f6081:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

power-platform/guidance/coe/setup-core-components.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Docs Build status updates of commit f2ae1be:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

power-platform/guidance/coe/setup-core-components.md
:white_check_mark:Succeeded

power-platform/power-fx/reference/function-patch.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Docs Build status updates of commit ccfb9b7:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

power-platform/guidance/coe/setup-core-components.md
:white_check_mark:Succeeded

power-platform/power-fx/reference/function-patch.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Would like them to have a separate pull request.. As the other one was a typo fix for Power Fx doc.

Learn Build status updates of commit 0afd7f5:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

power-platform/guidance/coe/setup-core-components.md
:white_check_mark:Succeeded

power-platform/power-fx/reference/function-patch.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the learn.microsoft.com contributor guidesPost your question in the Learn support channel

Learn Build status updates of commit 37fdb10:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

power-platform/guidance/coe/setup.md
:white_check_mark:Succeeded

power-platform/guidance/coe/setup-core-components.md
:white_check_mark:Succeeded

power-platform/power-fx/reference/function-patch.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the learn.microsoft.com contributor guidesPost your question in the Learn support channel

Learn Build status updates of commit 71c727a:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

power-platform/guidance/coe/setup.md
:white_check_mark:Succeeded

power-platform/guidance/coe/setup-core-components.md
:white_check_mark:Succeeded

power-platform/power-fx/reference/function-patch.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the learn.microsoft.com contributor guidesPost your question in the Learn support channel

Learn Build status updates of commit a3e30d1:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

power-platform/guidance/coe/setup-core-components.md
:white_check_mark:Succeeded

power-platform/power-fx/reference/function-patch.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the learn.microsoft.com contributor guidesPost your question in the Learn support channel

I made the changes regarding the CoE kit docs in our local branch for the November release, and these will go live next week when we push those changes.

Ohh, that's wonderful. Let's close this pull request then and look forward for those changes in live doc.


How to get constant from SnapKit

Tell me please, how to get constant positionX for testButton (as it is done in frames) after set constraints to testButton.
self.testButton.snp.makeConstraints { (make) -> Void in       make.centerX.equalTo(self.carListView)       make.width.equalTo(200)       make.height.equalTo(20)       make.top.equalTo(self.carListArray.last!.snp.bottom).offset(14)   }

You can't
You need to wait when viewLays out correctly and then get the value of centerX using frame like this:
let centerX= self.testButton.frame.center.x

You can't
You need to wait when viewLays out correctly and then get the value of centerX using frame like this:
let centerX= self.testButton.frame.center.x

so how to make sure that the view finished layouts?

You can't

You need to wait when viewLays out correctly and then get the value of centerX using frame like this:

let centerX= self.testButton.frame.center.x

so how to make sure that the view finished layouts?

In your viewController you can do it in viewDidLayoutSubviews or in view in layoutSubviews


Wrong anchors for non-latin symbols in wiki pages

Gogs version (or commit ref): <IP_ADDRESS>9
Git version: 2.6.6
Operating system: Ubuntu 16.04 + Docker 1.12.3 + Alpine Linux 3.3 (inside container)
Database (use [x]):

[x] PostgreSQL
[ ] MySQL
[ ] SQLite

Can you reproduce the bug at https://try.gogs.io:

[x] Yes (https://try.gogs.io/tetafro/test/wiki/Home)
[ ] No
[ ] Not relevant

Log gist: -

Description
Wrong anchors for non-latin symbols in wiki pages: when head (starts with # symbols) contain non-latin symbols, like cyrillic for example, anchor link for this head will not contain any of these symbols.

This should be fixed by https://github.com/gogits/gogs/pull/3981.


Add syntax to clean tasks working directories to YAML file

First version, users provide a small script to clean directory after processing. Possibly use AiiDA's cleanworkdir functionality instead (be careful with provenance).

Or just specified data nodes


Issue when compiling

This happens if I try to recompile while having the GUI already trying to compile

source_prepared.txt
By the way, I'm porting this over Rust, I'll make it a PR once it's done :)

try it again it fixed by me close eveything of it

in your source_prepared file, the error is caused because this bit was generated 3 times, I didn't look too far into the code yet, I might do that later, but this is the issue (I am pretty sure), and it's caused by the generator.

Hey! I am really sorry for my recent absence. I will look forward to fix the issues in the following week.

For anyone still wondering, there has to be a space character between listener.join() and with

Edit that line and you should be ok

source_prepared.txt By the way, I'm porting this over Rust, I'll make it a PR once it's done :)

So I had looked at this and I sent my reply saying it duplicated. Which was the case. How exactly did you run PySilon.bat, what did you put into the gui as arguments and did you have any errors while compiling, apart from that one? Also, which python version are you on and what OS are you using?

For anyone still wondering, there has to be a space character between listener.join() and with

Edit that line and you should be ok

sadly not because it's repeating :c

source_prepared.txt By the way, I'm porting this over Rust, I'll make it a PR once it's done :)

So I had looked at this and I sent my reply saying it duplicated. Which was the case. How exactly did you run PySilon.bat, what did you put into the gui as arguments and did you have any errors while compiling, apart from that one? Also, which python version are you on and what OS are you using?

https://github.com/mategol/PySilon-malware/assets/50798713/47036f4e-3532-4544-97d8-05d9e1d5b7a0
Here's a sample of how I made it happen, I didn't have other errors apart from the script not compiling, I'm using Python 3.11.3 and I'm using Windows 10.

I think I get it, build source maybe takes a bit to load so if you click it multiple times it will build it but with some parts being built multiple times which gives you that error. Idk why it grayed the compile button out a second time but this could be the issue, I'll try to recreate it later. :)

WE FIGURED IT OUT FINALLY.. anyways it will be in the next update and also I can send you the new builder.py which should fix the issue (it just had some problems with the uhh when uhh and then euhh either way it works) and you can just replace it and try to build and compile again, if you face any other issues, uhhh, just write another comment.
Here is the new script, just copy and paste everything into your old builder.py :+1:

Dude I was the one that figured it out lmfao, did you get drunk again

MAN I SAID WE

teamwork

Nahhh 🗿

Dude I was the one that figured it out lmfao, did you get drunk again
Hey, hey. I was the drunk one

oh yeah, fixed and will be in the next update :)


feat(local development): add vscode:clean script

This PR adds a new script to the root package.json called vscode:clean which resets lib/vscode.
Changes

add script to ./ci/dev/clean-vscode.sh
add script vscode:clean to package.json at root

Screenshots

Checklist

[x] tested locally
[ ] added new dependencies
[ ] updated the docs
[ ] added a test

Fixes N/A (no accompanying issue)

🔥 this is going to be really helpful.

@jsjoeio make sure to squash that second commit into the first!
Highly recommend using git commit --fixup to make it clear that's the intent.

@jsjoeio make sure to squash that second commit into the first!
Highly recommend using git commit --fixup to make it clear that's the intent.

😮 Thanks for the tip! I haven't used that before. I'll make those changes before I merge.


Add a JavaScript linter config for Hound with ES6 syntax enabled

We decided to default to ES6 for our last project and the upcoming ones.
This PR enables ES6 syntax linting for Hound.

:ship:


implement target speed detection

We have the ability to capture USB packets for analysis at High-Speed or Full-Speed, but we require the user to specify the speed when initiating capture. We want the speed to be detected automatically and to allow capture to be launched with speed unspecified.

The analyzer gateware has moved to the Cynthion repository; this issue is now tracked at https://github.com/greatscottgadgets/cynthion/issues/53.


remove flaky overlord test

If a task is manually inserted in the task storage and the task storage sync runs immediately then there won't be any waiting task. This was cause of failure for the build - https://travis-ci.org/druid-io/druid/jobs/70762283

close/reopen to rebuild

@himanshug @pjain1 instead of removing the test, can we add a fake lock to test the task is making it into the waiting queue?

@xvrl @pjain1 is working on another PR to improve that. we did this one to prevent any spurious failure as that assert condition was non-deterministic.


Double-check node handling of inline inputs

I really want to believe the node implementation doesn't match what the spec implies on handling of inline datums in inputs where you'd have to duplicate inline datums inside the witness set.
See add_reference_input and input_required_wits

Somebody mentioned to me that if they spend an inline datum and yet specify the datum of the input in their own transaction, they get a NonOutputSupplimentaryDatums error. I haven't verified this myself though


Added support for the 'layout' attribute

I've added support for the 'layout' attribute that allows the user to specify image layout format such as rgba8 using a non-standard [layout(rgba8)] attribute, as we discussed yesterday.
This functionality is only enabled when XSC_ENABLE_LANGUAGE_EXT is enabled through CMake AND when the necessary extension is enabled through input options/CLI/GUI.
I've added the -E<TYPE> CLI option which works similar to -W<TYPE>, and allows specific (or all) extensions to be enabled. Since I know you are working on an extension of your own I assume this is preferred than having separate options for each extension.
The core additions are:

ImageLayoutFormat enumeration containing all image layout formats and a mapping to GLSL keywords. This is available even when extensions are disabled, since it is part of standard GLSL, and you might want to use this functionality for the input-option based solution to the image layout format problem (as discussed yesterday).
New layout attribute and a mapping of its identifiers to ImageLayoutFormat in HLSLAnalyzer. Resulting image layout is stored on relevant BufferTypeDenoters.
Change to GLSLGenerator::WriteBufferDeclTexture so that image layout stored on BufferTypeDenoter is used if available. If one is not available or extension is disabled the system will try to deduce one automatically from base buffer type (similar how it worked so far). Finally if format cannot be deduced the buffer will be marked as writeonly, since formats are only needed for reads.

I'll probably do a secondary PR in which I track which buffers are actually being written to. In that case we can always avoid writing out the layout format, and since most RW buffers are only used for writes, this should allow the user to avoid attributes in majority of situations.

Added another commit in order to avoid writing image layout format qualifiers if images aren't used for any reads (i.e. what I wrote in the last paragraph above).

I just looked at it for a moment, but it looks good so far.
The idea of using -E<TYPE> for language extensions is great 👍 ,
but I think I should then change the -E ENTRY command to -e ENTRY, let's see.
Also making the enum ImageLayoutFormat always available is sensible.

Ah indeed, I missed the fact that "-E" was already in use, something should get renamed.

Yes, but I appreciate the -E command for the extensions support.

Thought you might find it useful :)
I amended the last commit, it was incorrectly applying writeonly to non RW buffers.

I renamed your -E language extension command to -X for eXtension.
I also made the extensions member and its enum in ShaderInput always enabled, but it is ignored if XSC_ENABLE_LANGUAGE_EXT is not defined.
In this way, the client programmer doesn't need to define XSC_ENABLE_LANGUAGE_EXT for it's own projects (only to bulid the compiler).
In the XscDebugger the respective PropertyGrid entry is then disbaled, but visible so that you always see what is build into the ccompiler and what is not.


Rounded top corners for bar chart

Feature Proposal
I saw a lot of questions in stack overflow about rounded top corners, I want to request to make it a feature instead of different approaches from different people which gets outdated once your repo post a new update.
Feature Use Case
A rounded top corners for bar chart
Possible Implementation
const options = {
     roundedCorner: 1
}

This is already implemented for v3:
https://www.chartjs.org/docs/master/charts/bar#borderradius
https://www.chartjs.org/samples/master/charts/bar/border-radius.html

This is great. Thanks @kurkle! 💯


Jest: TypeError: Cannot read property 'Constants' of undefined

Getting this vague error running a Jest test (not even including anything react-native)
TypeError: Cannot read property 'Constants' of undefined

      at Object.<anonymous> (node_modules/react-native/Libraries/Components/DrawerAndroid/DrawerLayoutAndroid.android.js:25:47)
      at Object.get DrawerLayoutAndroid [as DrawerLayoutAndroid] (node_modules/react-native/Libraries/react-native/react-native-implementation.js:25:34)
      at Object.<anonymous> (node_modules/react-native-drawer-layout-polyfill/dist/index.android.js:1:229)
      at Object.<anonymous> (node_modules/react-navigation/src/views/Drawer/DrawerView.js:5:38)

Current Behavior
It generates this error. Not even testing anything specifically react-native or react-navigation.
Expected Behavior
Not this.
Your Environment

software
version

react-navigation
1.0.0-beta.21

react-native
0.49.5

node
08.5

npm or yarn
yarn

Not even testing anything specifically react-native or react-navigation.

So what are you using Jest for? 🤔
Anyway it looks like it's related to react-native-drawer-layout-polyfill, and that he released a new 2.0.0 version less than 20 days ago.
Maybe updating it will fix it? We'll need to do a PR for that.

I'm also running into this error, and updating to 2.0.0 for react-native-drawer-layout-polyfill doesn't seem to help.

A clue: this only occurs for me when jest.haste.defaultPlatform is set to android

I think this can be closed here. I can reproduce this without react-navigation from a cleanly created react-native app by setting the defaultPlatform to android. I'm going to file a bug report in react-native proper.
cc @kelset

Thanks for reporting @peterlandry


Must have a Storyboard object reference before this trigger action can execute in TimePicker

My XAML code
<mah:TimePicker Grid.Row="2" Grid.Column="0"  Margin="0,0,0,10" >
</mah:TimePicker>
Getting following error in TimePicker.
Error detail :
System.Windows.Markup.XamlParseException
HResult=0x80131501
Message=Provide value on 'System.Windows.Markup.StaticResourceHolder' threw an exception.
Inner Exception 1:
InvalidOperationException: Must have a Storyboard object reference before this trigger action can execute.
Visual Studio 2017 Enterprise /VS 2019 community
Net 4.6.

Hi @shahshyam
Please fill in the entire issue template and provide a sample App. I cannot reproduce your issue with the latest version of MahApps.
Happy coding
Tim

@shahshyam Which version of MahApps are you using?

Sorry for delay response. I am using latest version of Mahapp. My project structure is It is vsto addins which load sidebar . The sidebar was WinForms user control and its load WPF usercontrol on it. WPF user control is using MahAppControl called TimePicker.

@shahshyam So you have the WPF inside a WinForms control? Can you check if you add all necessary resources at your WPF control? Or is there also a App.xaml?

yes, I have wpf control in side WinForms control and there is not any App.xml and other control is working as expected like tabcontrol , calendarpicker etc

@shahshyam Ok, thx for the clarification.

I have the same problem. I´m using the latest version too and in my case the WPF is not inside WinForms control.
In my case  it works on a UserControl but not in MainWindow.

I have the same problem and it also doesn't work in a UserControl.

Is there a work around for this issue while this remains open?

Hi @derekdd23
I still cannot reproduce this issue. May it be possible to provide a not working sample App?
To answer your question: at least you can grab the original Style and replace DynamicResource with StaticResource in the ControlTemplate.Triggers:
See: https://github.com/MahApps/MahApps.Metro/pull/4075/commits/d6c712f9b182590ffede91911788b659141db363
Happy coding
Tim

Hi,
I have reproduced the error.
I think it is related to how the application starts.
I use DI and the application starts like this (more or less):
    public static class Program
    {
        [STAThread]
        static void Main(string[] args)
        {
            var app = new App();

            var mainWindow = new MainWindow();

            app.InitializeComponent();

            app.Run(mainWindow);
        }
    }

I am attaching a compressed file with the project that reproduces this problem when the application starts.
WpfMahAppDatePickerError.zip
Thanks!!

@pacoweb It works now with the latest changes.

Thanks!
When is the nuget package update scheduled?

@pacoweb v2.4.5 is out now

Thank you!
Great job!


Update specs2-core, specs2-scalacheck to 4.12.10

Updates

org.specs2:specs2-core
org.specs2:specs2-scalacheck

from 4.12.0 to 4.12.10.
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "org.specs2" } ]

labels: test-library-update, semver-patch

Superseded by #178.


Fib corrections. Additional example added.

[x] I have read freeCodeCamp's contribution guidelines.
[x] My pull request has a descriptive title (not a vague title like Update index.md)
[x] My pull request targets the master branch of freeCodeCamp.
[x] None of my changes are plagiarized from another source without proper attribution.
[x] My article does not contain shortened URLs or affiliate links.

@MFry You can not add image files to the directory.  You will need to link from another source containing the images you want to link in the article.  Please remove these added files from your PR and link to external images.
Thank you.

@RandellDawson that seems like an oversight, especially for mathematical symbols.
I would think it would be useful to have all of the common ones added to a shared folder for reference. Makes the math based text much more approachable.


refactored get_s3_client into a function in a aws_s3_utils.py file

Description
refactored get_s3_client into a function to reduce the bulk of cript.API and make it easier to navigate and handle
Changes

removed some bulk from the cript.API class
wrote docstrings for get_s3_client
tested the code and it is working fine
formatted the whole thing with black
changed log to have file be capitalized for better UI

Known Issues
Notes
Checklist

[ ] My name is on the list of contributors (CONTRIBUTORS.md) in the pull request source branch.
[ ] I have updated the documentation to reflect my changes.

@InnocentBug tried to format with trunk using WSL and it kept not working and not sure what to do to fix it, can you please update the PR when you get a chance?


Add card edit menu

I can't make the menu on the top of map @davidmjiang to help. Thanks

I spent a few hours looking at this tonight. At first I thought it was just a matter of adding a higher z-index to the popout so that it showed above the map, but that wasn't doing anything. Then I realized it's the overflow-x: hidden that is causing anything beyond the left column to not show up. Then I learned that you can't have overflow in one direction be visible and overflow in another direction be hidden/scroll, which is what we would want (if there were a lot of cards such that they take up more vertical space than the map, we want a vertical scrollbar, not to just show them all).  I'll need to do some more research on this, but here's an article that could helps explain what I found: https://css-tricks.com/popping-hidden-overflow/


Refactor handleRefreshAccount, handleLoginUrl, handleRedirectUrl, handleRefreshUrl

@vgrichina Please let me know if you have any comments for these changes. If not I will resolve conflicts and it will be ready to merge. It affects many files and functionalities so soon there will be another conflict.
After the merge, I will be able to make changes for #349, because it affects this PR.

@marcinbodnar sorry this got off my radar. Looks good overall, but please rebase as there are conflicting changes.

@vgrichina conflicts resolved

@marcinbodnar looks good, but I need to make sure login / transaction signing works, so might beed some time to test and then merge


How to export bones of a dicom set (for example in .obj) in AMI.js?

Description
I want to load some DICOM files and export the bones of that files or at least the volume. I already load the DICOM files and get the quadview and the volume Rendering, but I want to export the bones of that files.
When I export to .obj I get the box which is the content of the volume but I want to export the content inside.
Steps to Reproduce

Load DICOM data

I Load the volume using vrHelper = new AMI.VolumeRenderingHelper(stack);

I export it using OBJExporter and passing the scene which contains the volume, i also tried to pass the mesh (  let exporter = new THREE.OBJExporter(); let obj = exporter.parse(mesh);)

Expected Results
What I would really like is to export the bones and then slice it get only a part of that, for example get only the clavicle.
I would like to export this:

Actual Results
But I am only be able to export an empty box
This is the mesh that I am exporting which has 12 faces and 8 vertices and it has geometry: BoxGeometry, I Know that this is wrong but I don´t Know how to get the real mesh

I tried to create a labelmap using threshold and get only bones and then create a mesh from that labelmap but I wasn't able to do that.
Thank you very much.
Browsers Affected

[X] All
[ ] Chrome
[ ] Firefox
[ ] Edge
[ ] Safari 9
[ ] Safari 8
[ ] IE 11

Versions

AMI: v.0.32.0
THREEJS: v.1.0.7

My understanding is that one can use the threejs obj exporter SO github
to export the Mesh
On Wed, Aug 28, 2019 at 10:56 AM cpanap00<EMAIL_ADDRESS>wrote:

Description
I want to load some DICOM files and export the bones of that files or at
least the volume. I already load the DICOM files and get the quadview and
the volume Rendering, but I want to export the bones of that files.
When I export to .obj I get the box which is the content of the volume but
I want to export the content inside.
Steps to Reproduce Expected Results
What I would really like is to export the bones and then slice it get only
a part of that, for example get only the clavicle.
I would like to export this:
[image: image]
https://user-images.githubusercontent.com/17741571/63840565-93d9cf00-c981-11e9-98d7-cac6efb42a70.png
Actual Results
But I am only be able to export an empty box
This is the mesh that I am exporting which has 12 faces and 8 vertices and
it has geometry: BoxGeometry, I Know that this is wrong but I don´t Know
how to get the real mesh
[image: image]
https://user-images.githubusercontent.com/17741571/63841009-4c077780-c982-11e9-8f37-cd662894c4b0.png
I tried to create a labelmap using threshold and get only bones and then
create a mesh from that labelmap but I wasn't able to do that.
Thank you very much.
Browsers Affected

All
Chrome
Firefox
Edge
Safari 9
Safari 8
IE 11

Versions

AMI: v.0.32.0
THREEJS: v.1.0.7

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/FNNDSC/ami/issues/391?email_source=notifications&email_token=AET34F6J22NEYP7DZMEWDGDQGY4UXA5CNFSM4IQ7ZKKKYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4HH3QWXQ,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AET34FZJPL4QEC5WZAYEJGTQGY4UXANCNFSM4IQ7ZKKA
.

Hi, you can not export anything from the volume rendering itself: first you must generate a 3d model from the voxels values, using marching cubes for instance, then export it to the format of your choice!

My understanding is that one can use the threejs obj exporter SO github to export the Mesh
…
On Wed, Aug 28, 2019 at 10:56 AM cpanap00 @.***> wrote: Description I want to load some DICOM files and export the bones of that files or at least the volume. I already load the DICOM files and get the quadview and the volume Rendering, but I want to export the bones of that files. When I export to .obj I get the box which is the content of the volume but I want to export the content inside. Steps to Reproduce Expected Results What I would really like is to export the bones and then slice it get only a part of that, for example get only the clavicle. I would like to export this: [image: image] https://user-images.githubusercontent.com/17741571/63840565-93d9cf00-c981-11e9-98d7-cac6efb42a70.png Actual Results But I am only be able to export an empty box This is the mesh that I am exporting which has 12 faces and 8 vertices and it has geometry: BoxGeometry, I Know that this is wrong but I don´t Know how to get the real mesh [image: image] https://user-images.githubusercontent.com/17741571/63841009-4c077780-c982-11e9-8f37-cd662894c4b0.png I tried to create a labelmap using threshold and get only bones and then create a mesh from that labelmap but I wasn't able to do that. Thank you very much. Browsers Affected - All - Chrome - Firefox - Edge - Safari 9 - Safari 8 - IE 11 Versions - AMI: v.0.32.0 - THREEJS: v.1.0.7 — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#391?email_source=notifications&email_token=AET34F6J22NEYP7DZMEWDGDQGY4UXA5CNFSM4IQ7ZKKKYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4HH3QWXQ>, or mute the thread https://github.com/notifications/unsubscribe-auth/AET34FZJPL4QEC5WZAYEJGTQGY4UXANCNFSM4IQ7ZKKA .

Thank you but I already use OBJExporter and It works fine, That's why I get the box my problem is that I need to generate a 3D model to export it.

Thank you but I already use OBJExporter and It works fine, That's why I get the box my problem is that I need to generate a 3D model to export it.

See comments above above marching cubes :)

Hi, you can not export anything from the volume rendering itself: first you must generate a 3d model from the voxels values, using marching cubes for instance, then export it to the format of your choice!

Thank You NicolasRannou, that's what I thought, I had already search about marching cubes and perhaps I need to do it in Back-End such as C++ or python because I didn´t find anything using javascript. Do I need to do a labelmap using threshold in order to export only the bones or It won't be necessary?
Thank You again.

So yes you can write your own JS implementation (probably using web-workers somehow for performance) or do it in the back end (which may be faster anyway).
In theory, all you need is the DICOM data. From there you can just iterate through the voxels and for each of them, depending on its intensity decide whether it should be part of the mesh or not!

So yes you can write your own JS implementation (probably using web-workers somehow for performance) or do it in the back end (which may be faster anyway).
In theory, all you need is the DICOM data. From there you can just iterate through the voxels and for each of them, depending on its intensity decide whether it should be part of the mesh or not!

Okay, Thank You very much.

I'm sorry to bother you again but I'm not able to get the mesh. I think the problem is from the data I use to get the mesh.
I use the rawData from the stack and this is what it should looks like:

However when I use marching cubes algorithm this is what I get:

The form is very similar but It is not perfect. I'm using this https://github.com/kig/gl-volume3d-demo for the marching cubes algorithm and I'm passing the dimensions too which are x:512 y:512 and z:61 in this case:

This is how I export to TXT the data:

My question is: What am I doing wrong?


log test info without useless stack trace [POL-155]

cleans up test logging.
before:

after:

@zarsky-broad what is the problem you are trying to solve here? Can you also link a ticket that explains the problem?
When I've been running the integration tests, I do see the console.info statements.

yup, sorry @cahrens, you beat me to it

yup, sorry @cahrens, you beat me to it

Nice! I had accepted the extra cruft as "just the way things are", but it's definitely much cleaner with this.

Change or remove logPageConsoleMessages?

I left the stack trace on that one, since it's called mid-run it might have useful stack trace.


403: Forbidden - CSRF Verification failed

Bug description
Using Kali Linux:
After successfully installing defectDojo's latest version and running it using docker-compose, I am unable to import scan result. Each upload attempt results in a 403 Forbidden page. The weird thing is that I was able to import scan results on last Thursday, using the same version. Any help?
Steps to reproduce
Steps to reproduce the behavior:

Go to 'Products'
Create a Product
Go to 'Findings' tab and select 'Import Scan Results'
Try importing any sort of scan - I am using Burp Scan
Click on Import and see this:

Expected behavior
I should be able to successfully upload my xml Burp Scan file
Deployment method (select with an X)

[ ] Kubernetes
[x] Docker
[ ] setup.bash / legacy-setup.bash

Environment information

Operating System: Kali 2020.3

Network Logs

CSRF Middleware Token

I've checked and tried all google solutions, nothing works - any ideas?

May sound stupid, but did you try to logout and login again? clear cookies/cache/etc?

May sound stupid, but did you try to logout and login again? clear cookies/cache/etc?

Yep, I've tried everything really, did not work

Have no idea, must be something local stripping the CSRF header, or some corruption of the settings.py file where CSRF exemptions are configured.

I've seen this with SSO when SSO bypasses dojo's login method. I want to add a fix to the middleware, but it can be a hard issue to reproduce. Planning to add a middleware check that will reset CSRF in the future.

I was able to reconstruct this issue. It is caused if you have cookies set from a UI session. You can find the details about the background described here - basically if it sees a login cookie, it now runs the full CSRF checks and you need to set the CSRF header and a correct referrer.
In previous versions, this was not the case - there it only verified API tokens for the API.

It was a different thing than the OP mentioned, but was definitely reconstructable enough. I would get those CSRF errors only when the script first logged in via UI. I can imagine that you are sending different headers than the script, which might bypass this.

I know of one other spot where this occurs. When getting an SSO token
without first going to Dojo, CSRF will not be set properly. We could catch
all CSRF issues by reissuing in the middleware, when appropriate.
Greg Anderson
DefectDojo Project Leader
@.***
On Thu, Apr 22, 2021 at 4:00 PM James Cullum (Pseudonym) <
@.***> wrote:

It was a different thing than the OP mentioned, but was definitely
reconstructable enough. I would get those CSRF errors only when the script
first logged in via UI. I can imagine that you are sending different
headers than the script, which might bypass this.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/DefectDojo/django-DefectDojo/issues/2760#issuecomment-825182033,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABEFRQF6OGXG4QL2UKTQ6HDTKCE6NANCNFSM4PVNN5QQ
.

Trying to upload MobSF scan results using json file.
Getting 403 Forbidden - CSRF verification failed. Request aborted.
Why? What to do now

I would recommend turning on debug to gain additional information about the error.

The issue is still persistant, API calls are failing due to CSRF token requirment


Upgrade kafka and other libs

This PR does the following.

Upgrades kafka version from 2.8.0 to 3.5.0 which removes commons lang3 dependency. Had to add the dependency manually
Add apache commons dependency
Upgrade opensearch version and testContainer versions

@Claudenw @reta thanks for the review. Updated PR.


Resolving object relations on an implicit conversion might be too aggressive

Make explicit run()s be the default API.

Cooool!!


Studio Tests For Autocomplete

Closes #74

lgtm :+1:
the test thing is bordering on too clever with the naming conventions, but I like its simplicity for now


Improve autocomplete result matching

Expected Behavior
Autocomplete should only show items that match terms, and weight them according to best match.
Actual Behavior
Currently the autocomplete suggestions are a bit hit and miss.

Duplicate of #22

Yeah, kind of. The fix for 22 wasn’t enough, as it turns out.