Building a bot

Hello zacmos,
Thank you for sharing this comprehensive library.
Please pardon my ignorance but how would you recommend building a bot for replying/acting everytime that someone @'s its name?
There exists the streaming API but how would one use this reacting to being called instead of pooling twitter every few seconds.
Perhaps possible to provide a sample example? Many thanks!!

Hi!
Thanks for reaching out. For the future, our community forums are likely a better place to get support for things like this. There is also a great community slack channel(external to Twitter) that I've used to run ideas by other bot makers the in the past.
To create a rule, you could use the filtered stream that looks for @mentions and replies with a Tweet using the manage Tweets endpoint. You could also use recent search in a similar way too.
I have a few examples of bots I've built in Python. I'm a Python developer, but our team is hoping to expand our tutorials to other languages:

Creating a Twitter bot
Kickstart your Twitter bot with our Glitch example written in Python
Devs in the Details: How to Create a Twitter Bot

Also, I like bot wiki for bot examples and other resources. I hope this helps!

Thanks Jessica but unfortunately those resources are too generic.
I'm really looking for a sample in Java language for this usage.
Why not opening on this repository the forum option?
The other forum is large but only has some 50 questions related to java and mostly unanswered.

Thanks for your feedback. I'd like to make a Java example in the future. I've worked with a bot maker in the past built this template, which could be combined with this SDK for this use.
Feel free to open up a post on the send me a DM if you don't hear anything. I'll also pass on your suggestions for support in the future.


v4: Update to GCC 14 in GCC executors

This updates the v4 gcc executor to GCC 14.

Your development orb(s) have been published. It will expire in 30 days.
You can preview what this will look like on the CircleCI Orb Registry at the following link(s):
https://circleci.com/developer/orbs/orb/geos-esm/circleci-tools?version=dev:feeb2628d801148c72aa11b5f38480442f557d12
https://circleci.com/developer/orbs/orb/geos-esm/circleci-tools?version=dev:alpha

Your development orb(s) have been published. It will expire in 30 days.
You can preview what this will look like on the CircleCI Orb Registry at the following link(s):
https://circleci.com/developer/orbs/orb/geos-esm/circleci-tools?version=dev:feeb2628d801148c72aa11b5f38480442f557d12
https://circleci.com/developer/orbs/orb/geos-esm/circleci-tools?version=dev:alpha

Your orb has been published to the CircleCI Orb Registry.
You can view your published orb on the CircleCI Orb Registry at the following link:
https://circleci.com/developer/orbs/orb/geos-esm/circleci-tools?version=4.2.0


Write tests for utils

Feature request
Feature description
The files under the utils directory are completely untested (though some are tested indirectly through usage in plugins). We should write tests for each file in the utils directory, testing each method/constant that is exported, similar to how we have tests for each plugin file.
How the feature is useful
Ensures we don't accidentally break the functionality of a util when shipping a change to the library.

Hi. I no longer work at DigitalOcean.
Also, what you're reporting seems in no way related to this issue. Please open a new issue in GitHub when reporting something unrelated to existing issues.

Yes thank you, I'm sorry for bothering you


issues with controlled TextInput with text replacement, "." shortcut on iOS

React Native version: 0.61.4
Steps To Reproduce

Create a TextInput component:

        <TextInput
          onChangeText={setValue}
          value={value}
        />

In iOS settings > general > keyboard make sure that "." Shortcut is on.
make sure "Check Spelling" is on.
make sure at least one thing is available in "Text Replacement" (omw should be there by default)
within the text input you created type some misspelled text.
press space twice after your text
type the text replacement shortcut

Describe what you expected to happen:

Miss-spelled text should have a red underline
there should be a period when space is pressed twice
text replacement shortcut should be replaced with its matching text.

The above will not be true when using value on a TextInput. If you remove the value prop and have the component uncontrolled the above all works as expected. Also, if the component is made multiline the above all work as expected, even in the controlled case.
Snack, code example, screenshot, or link to a repository:
https://snack.expo.io/H18J_rWlI

I am running into the same issue. it works when the shortcut is a-z like if you make a text replacement "smh" -> "shake my head" it works but if it is any special character such as a text replacement "@@" -><EMAIL_ADDRESS>it does not work UNLESS you enable multiline

this issue has not been fixed, not sure how to get it more attention

+1

I see I'am not the only one with the @@ shortcut for my email. Setting the multiline option solved the issue but introduce a new one for me: If I hit the return key (which in my case is returnKeyType="next") it add a new \n to my input value. So it's not really solved.

does this issue need a needs triage label? /cc @cpojer

I am also running into the same issue.
"react": "16.9.0",
"react-native": "0.61.3",

The same with me, any update on this?
"react": "16.11.0",
"react-native": "0.62.2",

Same problem here - exact same versions as @sonnd08
"react": "16.11.0",
"react-native": "0.62.2",

Related to #22078 and possibly #29572. I found that my fix for #29572 works around this issue, but it's not great and doesn't work for everyone.

Any news?

This is one of the telltale signs someone has built their app in React Native, that keyboard shortcuts don't work.
Any update?

ANy update ?

Hey, I'm looking at it and I think I found a possible solution: Here is where I posted everything: https://github.com/facebook/react-native/issues/37437

I'm still getting this issue on "react-native": "0.70.8". Text replacement on iOS doesn't work unless multiline is enabled on the textfield

still an issue "react-native": "0.71.3"

I'm looking at it again, My Mac broke and took a while to fix it

PR created: https://github.com/facebook/react-native/pull/39385

Likely fixed in new arch with https://github.com/facebook/react-native/pull/46970 (thanks @gedu for linking me to this!)

@NickGerleman I tried applying your patch to an Expo v52 (React Native 0.76.0) project using New Arch. Unfortunately it doesn't seem to resolve this issue and the workaround I referenced earlier no longer works in 0.76.0 and New Arch.
Perhaps I did something wrong, but I'm fairly certain the patch is applying and it doesn't seem to change the behavior.
@cortinico would you please reopen this issue?

Here is a reproducer with the patch applied: https://github.com/mhoran/new-arch-autocorrect-repro. I also opened a pick request (https://github.com/reactwg/react-native-releases/issues/595) though it's a bit moot since the bug does not seem to be fixed.

This should be fixed in main by https://github.com/facebook/react-native/pull/47269 and I've filed a pick request for 0.76. For those who want to test sooner, you can apply the patches to 0.76.0 via patch-package as shown in the reproducer.


Update Auth ApiTests for Xcode 9

The tests crash at start up accessing the UI from a background thread

@paulb777  I was unable to reproduce it running Auth_Tests_iOS unit tests on iPhone 7 Plus (11.0) simulator. Which configuration did you use?

Working on it.


Added support for the language field

This is used for example by the easytags plugin for vim

Fixed in #17


[BUG] rancher2_cluster_role_template_binding resources won't get deleted on Terraform apply

Rancher Server Setup

Rancher version: v2.7.8
Installation option (Docker install/Helm Chart): Docker installation

Information about the Cluster

Kubernetes version: v1.26.10+rke2r1
Cluster Type (Local/Downstream): downstream custom cluster
4 on-premises worker nodes
3 etcd/controlplane EC2 nodes on AWS (Amazon Linux 2)
The cluster was created using the rancher2_cluster_v2 resource on Terraform, like this:

resource "rancher2_cluster_v2" "buildfarm" {
  name               = local.buildfarm_cluster_name
  kubernetes_version = "v1.26.10+rke2r1"
  rke_config {
    etcd {
      snapshot_schedule_cron = "0 1 * * *"
      snapshot_retention     = 10
      s3_config {
        bucket                = "<REDACTED>"
        endpoint              = "<REDACTED>"
        folder                = "ApplicationData/rancher/${local.buildfarm_cluster_name}/snapshots"
        cloud_credential_name = rancher2_cloud_credential.svc_devopstoolsdev_s3_fullreadwrite.id
        region                = "ca-central-1"
      }
    }
  }
}

The roles were created like this:
resource "rancher2_cluster_role_template_binding" "buildfarm_owners" {
  count            = length(local.buildfarm_cluster_owners)
  name             = "binding-${local.buildfarm_cluster_owners[count.index]}"
  cluster_id       = rancher2_cluster_v2.buildfarm.cluster_v1_id
  role_template_id = "cluster-owner"
  user_id          = local.buildfarm_cluster_owners[count.index]
}

User Information

What is the role of the user logged in? Cluster Owner

Provider Information

What is the version of the Rancher v2 Terraform Provider in use? v3.2.0
What is the version of Terraform in use? Terraform Enterprise, workspace configured with Terraform v1.5.7

Describe the bug
Terraform can't destroy the mentioned resource. I get the following error:
Error: [ERROR] waiting for cluster role template binding (c-m-mm685n9f:binding-u-ywwuxgdfgf) to be removed: timeout while waiting for state to become 'removed' (last state: 'active', timeout: 10m0s)
To Reproduce
Comment out the rancher2_cluster_role_template_binding and try to do a terraform apply
Actual Result
The apply errors out as mentioned above.
Expected Result
To be able to successfully delete them through Terraform.
Screenshots

Additional context

We recreated this bug by creating a new template binding using a user_id containing invalid characters.   This I'd consider to be a fault due to lack of proper validation.  Terraform Apply failed though still added the bad resource.
Query to confirm the offending resource:
kubectl get clusterroletemplatebindings.management.cattle.io -n <clusterid> <name>
Resource deletion hangs:
kubectl delete clusterroletemplatebindings.management.cattle.io -n <clusterid> <name>
Final resolution to delete the offending resource turned out to be removing the finalizers:
kubectl edit clusterroletemplatebindings.management.cattle.io -n <clusterid> <name>
replace finalizers list with the following:
finalizers: []

Interesting... I don't understand how I could've used user_id with invalid chars.
This is my cluster_owners variable, under the local block:
cluster_owners = [
    "u-kqapq4gres",
    "u-4darj5vaup",
    "u-ywwuxgdfgf",
    "u-kvpsnu7cya",
    "u-zpi42xj73n"
  ]

They're basically rancher user IDs that I copied directly from the UI, under the Users & Authentication tab. And I can see those users by their names under Cluster Configuration > Member Roles, which leads me to think that the IDs are indeed valid.

Hey @voliveira-tmx - I took a look at this and wasn't able to reproduce the issue without significant tampering (adding my own custom finalizer). I suspect that there is a finalizer on these CRTBs which is preventing them from being deleted. We use these for a variety of reasons (such as making sure that the external/downstream objects are removed before removing the local object).
Unfortunately, it will be difficult for us to work on a fix (or give advice on a workaround) without a better idea of which finalizer is on the object, and why it isn't being removed. Can you pick one of the objects that is failing to delete and gather the finalizers and any related log statements?
To get the finalizers for the object, run the following command in the cluster that rancher is installed on to get the CRTB:
kubectl get ClusterRoleTemplateBinding binding-u-ywwuxgdfgf -n c-m-mm685n9f -o yaml

If this output contains too much information and you just want to get the finalizers, you can use the following command to just get the finalizers:
kubectl get ClusterRoleTemplateBinding binding-u-ywwuxgdfgf -n c-m-mm685n9f -o jsonpath="{.metadata.finalizers}

I'd also like to ask for log entries related to this CRTB. You should be able to filter for those by grepping for the c-m-mm685n9f/binding-u-ywwuxgdfgf string, like below:
cat logs.txt | grep 'binding-u-ywwuxgdfgf'

Please make sure to review the output before posting here - keep in mind that this issue is public.
In the meantime, I would recommend making sure that the cluster that these CRTBs are giving access to shows "connected" on the UI and can reach your Rancher install.


Log stderr stdout when container exit code != 0

Closing because this PR is not enough to solve the issue.
Moving the discussion here: https://github.com/filecoin-project/bacalhau/issues/485


Roll engine 180a497ee558..13c879a8ed18 (6 commits)

https://github.com/flutter/engine/compare/180a497ee558...13c879a8ed18
git log 180a497ee558..13c879a8ed18 --first-parent --oneline
2020-05-04<EMAIL_ADDRESS>Roll src/third_party/skia 4dab280c2835..8a2f29eae7a5 (10 commits) (flutter/engine#18127)
2020-05-04<EMAIL_ADDRESS>Roll src/third_party/skia cdf23dd9f1b5..4dab280c2835 (4 commits) (flutter/engine#18123)
2020-05-04<EMAIL_ADDRESS>Roll src/third_party/dart e2c223de2e2a..e7bebea059ff (11 commits) (flutter/engine#18122)
2020-05-04<EMAIL_ADDRESS>[web] Remove left/top/transform reset since all code paths now set ltwh (flutter/engine#17867)
2020-05-04<EMAIL_ADDRESS>Roll src/third_party/dart 3a7633a191ca..e2c223de2e2a (1 commits) (flutter/engine#18121)
2020-05-04<EMAIL_ADDRESS>Roll src/third_party/skia 57f289d7423c..cdf23dd9f1b5 (6 commits) (flutter/engine#18120)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC<EMAIL_ADDRESS>on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Commit queue failed; closing this roll.


What happens if path doesn't exist? Does exist?

Nothing in docs or API doc says what happens in the cases where path does/doesn't exist.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 6e72a34c-083c-9b7c-2ece-13c6cc0aa42f
Version Independent ID: 18bfe5df-0e39-9c91-332d-4e28ab46e82c
Content: Download a blob with .NET - Azure Storage
Content Source: articles/storage/blobs/storage-blob-download.md
Service: storage
Sub-service: blobs
GitHub Login: @normesta
Microsoft Alias: normesta

@brandonh-msft
Thanks for your feedback! I've assigned this issue to the author who will investigate and update as appropriate.

#reassign:pauljewellmsft

Thanks for bringing this issue to our attention! I've updated the doc to provide some more context around downloading to a file path. Changes should go live later today.
#please-close


Ensure rolling raises for incorrect inputs

Close #490

Removed the test_rolling_raises cases w/ axis keyword arg as pandas is raising, let me know if we still want to keep those for now though!

FutureWarning: The 'axis' keyword in DataFrame.rolling is deprecated and will be removed in a future version. Call the method without the axis keyword instead.

thx


new user considering porting from CppAD

Hi,
I currently use CppAD and was considering porting my codebase to use your library. I make use of gradient, jacobian, and hessian computations in cppad. The optimisation framework I'm using also makes use of the sparsity pattern that CppAD can compute for both jacobian and hessian matrices. Is there anything that I'm currently using from CppAD as per the above that's not currently provided in your library before I begin the porting work?  Thanks

Hi, while you should find that Adept is much faster than CppAD for the pure AD, it is missing some of the functionality you require. Firstly it only does first-order differentiation, so can't compute the Hessian of arbitrary functions, although as explained in section 4.1 of the documentation (https://www.met.reading.ac.uk/clouds/adept/adept_documentation.pdf), if your cost function is quadratic then you can compute a good approximation to the Hessian from the Jacobian, which Adept can calculate. Secondly there is no sparse array functionality, nor a way for Adept to report the sparsity pattern for Jacobian matrices.


Distinguish between user and group when listing identities

/v2-beta/identities returns various information and it would helpful to be able to distinguish between users and groups. Some additional field that can have value user or group would probably be enough.
The alternative is to just search for *_user, which is a little hacky.
    {
        "id": "1i!github_user:6208550",
        "type": "identity",
        "links": {
            "self": "…/v2-beta/identities/1i!github_user:6208550"
        },
        "actions": { },
        "baseType": "identity",
        "all": null,
        "externalId": "6208550",
        "externalIdType": "github_user",
        "login": "joshwget",
        "name": "Josh Curl",
        "profilePicture": "https://avatars3.githubusercontent.com/u/6208550?v=3",
        "profileUrl": "https://github.com/joshwget",
        "projectId": null,
        "role": null
    },
    {
        "id": "1i!github_team:1580870",
        "type": "identity",
        "links": {
            "self": "…/v2-beta/identities/1i!github_team:1580870"
        },
        "actions": { },
        "baseType": "identity",
        "all": null,
        "externalId": "1580870",
        "externalIdType": "github_team",
        "login": "sherdock",
        "name": "Sherdock",
        "profilePicture": "https://avatars0.githubusercontent.com/u/9343010?v=3",
        "profileUrl": "https://github.com/orgs/rancher/teams/sherdock",
        "projectId": null,
        "role": null
    },
    {
        "id": "1i!rancher_id:1a1",
        "type": "identity",
        "links": {
            "self": "…/v2-beta/identities/1i!rancher_id:1a1"
        },
        "actions": { },
        "baseType": "identity",
        "all": null,
        "externalId": "1a1",
        "externalIdType": "rancher_id",
        "login": null,
        "name": "Josh Curl",
        "profilePicture": null,
        "profileUrl": null,
        "projectId": null,
        "role": null
    },
    {
        "id": "1i!github_org:9343010",
        "type": "identity",
        "links": {
            "self": "…/v2-beta/identities/1i!github_org:9343010"
        },
        "actions": { },
        "baseType": "identity",
        "all": null,
        "externalId": "9343010",
        "externalIdType": "github_org",
        "login": "rancher",
        "name": "Rancher",
        "profilePicture": "https://avatars0.githubusercontent.com/u/9343010?v=3",
        "profileUrl": "https://github.com/rancher",
        "projectId": null,
        "role": null
    },
]

The field externalIdType does differentiate between the user and group, but since a field with only values user or group is needed, I'll add a new field to the Identity class in cattle. Should I call it identityType?
@vincent99 @prachidamle @cjellick

Each returned identity should have two additional fields.
me - Identity is associated with the current access key / private key
user - Identity is a user type and not non-user type (group, team, etc...)

@mrajashree maybe we should be able to take care of this issue while you are working in the same area for above fix:
https://github.com/rancher/rancher/issues/8754

Let's limit the scope for now to just implementing me and user.

available to test on master

Tested with latest build from master:
When accessing http://:8080/v2-beta/identities , "user": true is set for the user entries.
For github auth enabled setup , following 2 entries have "user": true set:
"externalIdType": "github_user”,
"externalIdType": “rancher_id
For openLdap auth enabled setup , following  2 entries have "user": true set:
"externalIdType": “openldap_user”,
"externalIdType": “rancher_id
For local auth enabled setup,1 entry has  "user": true set:
"externalIdType": "rancher_id”,

For SAML auth provider(Tested with PingFederator) , 2 entries have "user": true set:
"externalIdType": “shibboleth_user”,
"externalIdType": “rancher_id"


Migrate Travis to Github Actions: Simulator based CI

ASF Infra has advised Travis will be deprecated and removed by Dec '22 end. This PR migrates our PR CI from Travis to Github Actions.
All workflow/jobs run on default spec:
2-core CPU (x86_64)
7 GB of RAM
14 GB of SSD space
https://docs.github.com/en/actions/using-github-hosted-runners/about-github-hosted-runners#supported-runners-and-hardware-resources

Referencing https://github.com/apache/cloudstack/pull/6896 but this is to try a different Github Actions approach

Appears I’m getting close, now to figure out the best way to pass the data, fix Marvin tests dependency issues.

Request for review - @DaanHoogland @shwstppr @nvazquez @weizhouapache @harikrishna-patnala  @davidjumani
Finally it seems to be working for following:

On commit push on PR cancels old jobs
RAT checks
UI Build (currently failing the unit test, which I confirmed is not related to this PR but happening on main)
Simulator CI runs alright (most are passing now, those failing need to be investigated - either issue in the test or ACS code, or something in Github actions env)
TBD: Unlike Travis, Github actions job timeout is 6hrs; should we keep these many jobs or have fewer?

// kicking pkging only as there are changes in ui/package.json; otherwise all changes in .github for CI purpose
@blueorangutan package

@rohityadavcloud a Jenkins job has been kicked to build packages. It will be bundled with  KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

UI build: :heavy_check_mark:
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/6956 (QA-JID-13)

Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 4824

@blueorangutan ui
All tests passing except the one with (intermittent) failure

@rohityadavcloud a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@blueorangutan package

@rohityadavcloud a Jenkins job has been kicked to build packages. It will be bundled with  KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 4835

@rohityadavcloud I restarted the failing job several times, but it seems to be consistent in failing. It is the tagging tests that fail.

@DaanHoogland see my comment above :)

@rohityadavcloud that sounds good, do your tests use multiple cores by default? the gh runners have only 2 but still :D Feel free to ping me here or on asf slack if you are stuck with the implementation details!

Thanks all - any thoughts on consolidating the component tests together (as Github Actions timeout is 6hrs, compared to an hour for Travis). What we can do is to have 5-6 runners per PR (than 20+) with pipelining and passing artifacts b/w jobs:
Check type of changes, do we need to build UI or java code -> Do mvn -Dnoredist -Dsimulator build with unit tests -> if it passes -> run smoketests (2-4 runners) and integration tests (2-4 runners)

I don´t like the idea of consolidating if that lengthens the duration of the total run of checks. Our feedback loop will be effectively a day when we exceed 5 hours. Even with 2 hours some of us will only return the next day. Let's run more in parallel rather than less. especially if we separate the build part out.

Logged optimisations/suggests at https://github.com/apache/cloudstack/issues/7010


SpherePointer.IsNearObject returns incorrect value

SpherePointer.IsNearGrabbable will return true if it is near ANY collidable, but it should only return true if it is near something that is grabbable (has NearInteractionGrabbable component on it).
And instead of doing an extra sphere cast we should just take advantage of focus system and just check if the sphere pointer is focusing anything

This bug was filed a while back I think in response to some code review. At the time this was brought up, but the author actually fixed it in the same review and so this bug immediately went stale.
https://github.com/microsoft/MixedRealityToolkit-Unity/blob/mrtk_development/Assets/MixedRealityToolkit.SDK/Features/UX/Scripts/Cursors/FingerCursor.cs#L199
The original bug references this section, which used to do a sphere raycast (instead of just an interactiongrabbable search)
tl;dr this was fixed in the same PR that this issue was filed against so it's not relevant anymore

suggestion for fix: create a 'grabbable layer mask' similar to what the poke pointer does with poke layer masks, and in SpherePointer.IsNearObject, query using the grab layer mask filter.
Addison had previously created this solution, but then I reverted it to reduce risk from his change, because the layer mask was unrelated to his PR. We should bring that change back in.

Marking urgency soon since it blocked several people who were using sr meshes in MRTK.

fixed.


The caches are not all cleaned when deleting the local repository

The following new test inside SingleModuleNativeIT test fails:
    @Test
    void buildDeleteRepoAndRebuild() throws IOException, InterruptedException {
        final Path localMavenRepo = parameters.mavenRepoLocal();
        TestUtils.deleteDir(localMavenRepo);

        final TestClientOutput o1 = new TestClientOutput();
        client.execute(o1, "clean", "install", "-e", "-B").assertSuccess();

        TestUtils.deleteDir(localMavenRepo);

        final TestClientOutput o2 = new TestClientOutput();
        client.execute(o2, "clean", "install", "-e", "-B").assertSuccess();
    }

Sounds like a duplicate of https://github.com/mvndaemon/mvnd/issues/26 - let's close that one.

Sounds like a duplicate of https://github.com/mvndaemon/mvnd/issues/26 - let's close that one.

The commit https://github.com/mvndaemon/mvnd/commit/67d5b4b9c95e1f56d1287a2efccd33c67b091bdb might be a problem on OSX, as the WatchService on OSX uses polling, so file changes won't be detected if the repo is deleted and the launch started just after (the default polling interval is 10s on OSX).
However, even after fixing the problem, when the compilation failure happens, the repo has not been fully re-populated.  This means the resolution of artefacts is cached somehow.

The commit https://github.com/mvndaemon/mvnd/commit/67d5b4b9c95e1f56d1287a2efccd33c67b091bdb might be a problem on OSX, as the WatchService on OSX uses polling, so file changes won't be detected if the repo is deleted and the launch started just after (the default polling interval is 10s on OSX).
However, even after fixing the problem, when the compilation failure happens, the repo has not been fully re-populated.  This means the resolution of artefacts is cached somehow.

It seems the problem is the ProjectArtifactsCache default implementation.

It seems the problem is the ProjectArtifactsCache default implementation.


Feat/introduce toml usage

Proposed Changes
After checking the build setup I identified some differences in versions of used dependencies.
Example:
File, Module, Plugin
build.gradle (maestro-android) -> "com.google.protobuf" version "0.8.18"
build.gradle (maestro-client) -> "com.google.protobuf" version "0.9.1"

To fix this issue I want to introduce version catalog (libs.versions.toml) so every dependencies + version is in one place. It is now easier to update & maintain all deps used in this repository.
Testing
Tested it by running ./gradlew test , installDist, using cli & maestro studio locally.
Issues Fixed
see above

TOML usage is a neat and welcome change! However, can we stick with Java 8 (or at least address it in a different PR)?

Java 11 branch in fork created. update-java-11-agp-7.4.1 depends on toml change so waiting until this is merged.

Thanks @nilsjr ! Everything works 👍


Is it necessary to use linux system to do the installation

Software and Hardware Versions
macOS 10.15.7
Docker version 19.03.12
Problem description
I follow the steps according to README.md and faced with the folllowing error.
(base) cai@caideMacBook-Pro ~ % pip install git+git://github.com/cap-ntu/ML-Model-CI.git@master
WARNING: The directory '/Users/cai/Library/Caches/pip' or its parent directory is not owned or is not writable by the current user. The cache has been disabled. Check the permissions and owner of that directory. If executing pip with sudo, you may want sudo's -H flag.
Collecting git+git://github.com/cap-ntu/ML-Model-CI.git@master
  Cloning git://github.com/cap-ntu/ML-Model-CI.git (to revision master) to /private/var/folders/sm/fw6rnkrj471728596tyrh9jr0000gn/T/pip-req-build-s1uzb4r4
  Running command git clone -q git://github.com/cap-ntu/ML-Model-CI.git /private/var/folders/sm/fw6rnkrj471728596tyrh9jr0000gn/T/pip-req-build-s1uzb4r4
    ERROR: Command errored out with exit status 1:
     command: /Users/cai/opt/miniconda3/bin/python -c 'import sys, setuptools, tokenize; sys.argv[0] = '"'"'/private/var/folders/sm/fw6rnkrj471728596tyrh9jr0000gn/T/pip-req-build-s1uzb4r4/setup.py'"'"'; __file__='"'"'/private/var/folders/sm/fw6rnkrj471728596tyrh9jr0000gn/T/pip-req-build-s1uzb4r4/setup.py'"'"';f=getattr(tokenize, '"'"'open'"'"', open)(__file__);code=f.read().replace('"'"'\r\n'"'"', '"'"'\n'"'"');f.close();exec(compile(code, __file__, '"'"'exec'"'"'))' egg_info --egg-base /private/var/folders/sm/fw6rnkrj471728596tyrh9jr0000gn/T/pip-req-build-s1uzb4r4/pip-egg-info
         cwd: /private/var/folders/sm/fw6rnkrj471728596tyrh9jr0000gn/T/pip-req-build-s1uzb4r4/
    Complete output (13 lines):
    Traceback (most recent call last):
      File "<string>", line 1, in <module>
      File "/private/var/folders/sm/fw6rnkrj471728596tyrh9jr0000gn/T/pip-req-build-s1uzb4r4/setup.py", line 51, in <module>
        stdout = subprocess.check_output(check_ubuntu_version_args, universal_newlines=True, shell=False)
      File "/Users/cai/opt/miniconda3/lib/python3.7/subprocess.py", line 411, in check_output
        **kwargs).stdout
      File "/Users/cai/opt/miniconda3/lib/python3.7/subprocess.py", line 488, in run
        with Popen(*popenargs, **kwargs) as process:
      File "/Users/cai/opt/miniconda3/lib/python3.7/subprocess.py", line 800, in __init__
        restore_signals, start_new_session)
      File "/Users/cai/opt/miniconda3/lib/python3.7/subprocess.py", line 1551, in _execute_child
        raise child_exception_type(errno_num, err_msg, err_filename)

    FileNotFoundError: [Errno 2] No such file or directory: '/usr/bin/lsb_release': '/usr/bin/lsb_release'
    ----------------------------------------

ERROR: Command errored out with exit status 1: python setup.py egg_info Check the logs for full command output.

I've found on the website that lsb_release is specific to linux system like ubuntu. So I just want to confirm that it is necessary to install docker on a linux operating system machine to build the developing environment as well as the running environment.
Steps to Reproduce the Problem
As above.
Expected Behavior
Other Information

Yes, this way development is more convenient and efficient
It is recommended to use dual systems（mac/ubuntu18.04）
I first used the Ubuntu system on the virtual machine, but there was no real driver and graphics card. Finally, I installed a dual system to solve the problem.

It is been fully tested on Ubuntu, but for mac it supposed to be ok. The error you meet is because there is no TensorRT version for mac.
You are recommended to go through CONTRIBUTING.md to install the dev environment. There is some unexpected error when installing with pip. A PR is welcome if you can fix the pip install error.


WrapperClass.java

Please provide a description.

Please provide a valid description of your generated pull request and put your code in the appropriate folder.

Please resolve the conflict @LaibaMemon


Explain how to publish a new finder

This commit explains the steps needed to publish a new finder.
Trello: https://trello.com/c/X0I3cfJS/335-write-documentation-about-how-to-create-a-finder

I've changed the documentation, moved the information about Whitehall into https://github.com/alphagov/whitehall/pull/2865
I will squash the commits when everyone's happy with the changes.

I added a couple more more inline comments but looks good to me.
I was thinking it would also be helpful to link to @tijmenb's new schema docs for finders: https://alphagov.github.io/govuk-developers/content-schemas/finder/

Those schema docs are very prototype, not ready for prod yet. Hopefully we can get something permanent in December.

@MatMoore & @tijmenb I've addressed your comments, and I've rebased the branch.
Thank you


Transfers hanging at 99% completion

Storage Explorer Version: 1.11.2
Build Number: 20191217.4
Platform/OS: Win10
Architecture: x64
Regression From: Only started experiencing this recently
Bug Description
Transfers are hanging at 99% completion
Steps to Reproduce
Initiate a large transfer in ASE by copy/paste within ASE.  More below on what "large" is.
Expected Experience
Transfer operation in ASE completes when underlying data is transferred.
Actual Experience
Over the last ~1 week (approximately aligned to the most recent ASE update), every "large" (more below re: "large") blob<-->blob transfer I initiate (all within-region, all in SCUS) has hung permanently at 99% completion, though examination of the data shows that the transfer is actual 100% complete.
The "Cancel" button is non-responsive in this state.  This is particularly problematic because the transfer appears to have actually completed, so if the "Cancel" button were responsive, I could allow subsequent queued
This has happened consistently on two different machines, both Win10, one a VM in SCUS, the other a local machine.  Smaller transfers are succeeding on both machines.
If I had to say what "large" and "small" are, I would put the line at around 1000 blobs and around 100GB (so "large" but not "massive"), but it's difficult to test this rigorously.
I don't have data to conclude that this is specific to blob <--> blob transfers, I just haven't done, for example, local <--> blob transfer at this scale recently.
Screenshot:

Additional Context
AzCopy command (retrieved by clicking "Copy AzCopy Command to Clipboard"), without credentials:
./azcopy.exe copy "https://something.blob.core.windows.net/something/something/?sv=something" "https://something.blob.core.windows.net/something/?se=something" --overwrite=prompt --recursive --s2s-preserve-access-tier=false;

We have seen people reporting AzCopy "hangs" at the end of the transfer. We will communicate this issue to the AzCopy team. According to #2029, customers found that increasing the network bandwidth may be able to work around this issue.

Also could you please send us an AzCopy log for the hanging transfer?

@agentmorris I can help to investigate this issue from the AzCopy side if you could kindly provide the log file.
To confirm, were you doing block blob -> block blob copies?

Log file sent by email.  Yes, this was a block<->block copy.

I am seeing this problem also.

Thanks @agentmorris! We'll study the logs and try to figure out the root cause.
@Plasma could you please send me the logs as well? My email can be viewed from my profile. Thanks!

@agentmorris  I'm continuing the investigation started by @zezha-msft.  There's some information which would be very useful, but is only in the plan files, not the log files.  By default plan files are saved in the ".plans" subdirectory under where the logs are.  Could you please take a look, and see if you have files under there that contain the same GUID as the job id (log file name) that you sent to Ze?  if you do, could you zip them all up (there may be 19 or 20 or so of them) and email them to me?  Basically they will contain the same info as the logs... but in a machine readable form and with one extra flag that is important to this bug but not reflected in the logs.
My email address is in my profile.
Thanks heaps, since the plan files may make all the difference to diagnosing this issue.
@Plasma Not sure if you've already sent logs to Ze, but could you also please send me plan files if possible, and include logs too if you have haven't already sent them to Ze.

@JohnRusk Sure, where are the logs located? I can't find them anywhere nor via any of the app menus. Cheers.

@Plasma, the location for the log files are at C:\Users\<your_username>\.azcopy. Each log file is named by its AzCopy job ID.

Thanks - it didn't happen today, so I will wait until it happens again. I note my problem was a bit different, it just never started (was stuck at the phase where its just trying to figure out how many files it needs to copy).

Oh, yes, that is different.  I wonder if the AzCopy engine couldn't reach the source account for some reason.

Closing due to lack of response. Please open a new issue if you are still having problems.

Apologies for delayed response.  We have not observed this issue since upgrading to 1.12.0, and have done maybe 5-10 large transfers since then.  That doesn't make it 100% guaranteed that the issue was resolved, since it wasn't 100% deterministic, but I'm... 97% sure the issue has been resolved.


Fix access of 'required' key for TypedDictField in GenerateJsonSchema

Fixes https://github.com/pydantic/pydantic/issues/6192

Left a small suggestion. other than that LGTM 👍
Thanks!


Restarting yabai crashes WindowServer (only when an external monitor is attached)

Reliably reproduced when an external monitor was attached.
My external monitor is Acer VG270K (3840 x 2160).
I'm running Catalina 10.15.4 on a MacBook Pro (16-inch, 2019).
Could not reproduce when the external monitor was not attached.
yabai version:
➜  ~ brew info yabai
koekeishiya/formulae/yabai: stable 3.2.1, HEAD
A tiling window manager for macOS based on binary space partitioning.
https://github.com/koekeishiya/yabai
/usr/local/Cellar/yabai/HEAD-ba36ce6 (10 files, 628.3KB) *
  Built from source on 2020-08-17 at 18:27:22

Here is one of the crash reports:
Process:               WindowServer [223]
Path:                  /System/Library/PrivateFrameworks/SkyLight.framework/Versions/A/Resources/WindowServer
Identifier:            WindowServer
Version:               600.00 (450.9)
Code Type:             X86-64 (Native)
Parent Process:        launchd [1]
Responsible:           WindowServer [223]
User ID:               88

Date/Time:             2020-08-17 18:34:45.281 -0700
OS Version:            Mac OS X 10.15.4 (19E287)
Report Version:        12
Bridge OS Version:     4.4 (17P4281)
Anonymous UUID:        BA221A88-AC6B-445F-B92F-FA2CD8F8205D

Time Awake Since Boot: 110 seconds

System Integrity Protection: disabled

Crashed Thread:        0  Dispatch queue: com.apple.main-thread

Exception Type:        EXC_BAD_ACCESS (SIGSEGV)
Exception Codes:       KERN_INVALID_ADDRESS at 0x0000000000000010
Exception Note:        EXC_CORPSE_NOTIFY

Termination Signal:    Segmentation fault: 11
Termination Reason:    Namespace SIGNAL, Code 0xb
Terminating Process:   exc handler [223]

VM Regions Near 0x10:
-->
    __TEXT<PHONE_NUMBER>891000-0000000107893000 [    8K] r-x/r-x SM=COW  /System/Library/PrivateFrameworks/SkyLight.framework/Versions/A/Resources/WindowServer

Application Specific Information:
StartTime:2020-08-17 18:33:14
GPU:IG&AMD
MetalDevice for accelerator(0x3217): 0x7fab754225b8 (MTLDevice: 0x107b94000)
MetalDevice for accelerator(0x4927): 0x7fab76f33ca8 (MTLDevice: 0x107bad000)
IOService:/AppleACPIPlatformExpert/PCI0@0/AppleACPIPCI/PEG0@1/IOPP/EGP0@0/IOPP/EGP1@0/IOPP/GFX0@0/AMDRadeonX6000_AmdRadeonControllerNavi14/ATY,Boa@1
IOService:/AppleACPIPlatformExpert/PCI0@0/AppleACPIPCI/PEG0@1/IOPP/EGP0@0/IOPP/EGP1@0/IOPP/GFX0@0/AMDRadeonX6000_AmdRadeonControllerNavi14/ATY,Boa@0

Thread 0 Crashed:: Dispatch queue: com.apple.main-thread
0   com.apple.SkyLight            	0x00007fff6107cc19 __fadeFinished_block_invoke + 20
1   com.apple.SkyLight            	0x00007fff6107c29f fadeFinished + 133
2   com.apple.SkyLight            	0x00007fff61083131 CGXSetWindowListAlpha + 58
3   com.apple.SkyLight            	0x00007fff6121e8e0 _XSetWindowListAlpha + 169
4   com.apple.SkyLight            	0x00007fff6107669c invocation function for block in connectionHandler(unsigned int, mach_msg_header_t*, void*) + 346
5   com.apple.SkyLight            	0x00007fff61076514 invocation function for block in connectionHandler(unsigned int, mach_msg_header_t*, void*) + 65
6   com.apple.SkyLight            	0x00007fff611afd53 CGXHandleMessage + 139
7   com.apple.SkyLight            	0x00007fff610743b1 connectionHandler(unsigned int, mach_msg_header_t*, void*) + 216
8   com.apple.SkyLight            	0x00007fff611f7d47 post_port_data + 255
9   com.apple.SkyLight            	0x00007fff611f79af CGXRunOneServicesPass + 1706
10  com.apple.SkyLight            	0x00007fff611f83b9 server_loop + 91
11  com.apple.SkyLight            	0x00007fff611f8357 SLXServer + 1461
12  WindowServer                  	0x000000010789232e 0x107891000 + 4910
13  libdyld.dylib                 	0x00007fff6bdbbcc9 start + 1

Have you seen #277?  I'm also on a 2019 16" MBP with a 4k external monitor and don't have any issues restarted Yabai.  I did it three times this morning even as part of modifying my config.

This is what I have in my .yabairc for #277:
yabai -m config window_opacity               on
yabai -m config active_window_opacity        1.0
yabai -m config normal_window_opacity        0.95
yabai -m config window_opacity_duration      0.0   # https://github.com/koekeishiya/yabai/issues/277#issuecomment-552944282

I'll try to turn off window_opacity altogether.

Huh.  Well, I have a transparency setting on normal windows, too.  With the same 0 delay opacity duration.  Mine is largely just default, but my yabairc is here: https://github.com/Liquidmantis/dotfiles/blob/master/yabai/yabairc

Confirmed. If I commented out this block of config:
# yabai -m config window_opacity               on
# yabai -m config active_window_opacity        1.0
# yabai -m config normal_window_opacity        0.95
# yabai -m config window_opacity_duration      0.0   # https://github.com/koekeishiya/yabai/issues/277#issuecomment-552944282

I could restart yabai (with external monitor attached) all I want without crashing. Setting window_opacity_duration to 0.0 is not enough in my case.

Due to changes made for #585 on master, the window_opacity_duration must be set to 0.0 before the command that enables window_opacity. I have made a change to master that makes it so that this value will always be 0.0 for Catalina, and cannot be changed by the user (because Apple is not going to fix their bug anyway..).


BLoC folder icon

Description
Added BLoC folder icon.
Closes #2585.
Closes #1461.
Contribution Guidelines

[x] By creating this pull request, I acknowledge that I have read the Contribution Guidelines for this project.
[x] I have read the Code Of Conduct and promise to abide by these rules

@PKief sorry for mentioning, but can I get some feedback or can I get this merged?

@PKief sorry for mentioning, but can I get some feedback or can I get this merged?

The motive of this folder icon is a little different to all of the other folder icons of this extension. It has too many colors and this black border, which is not looking good and not consistent to the other folder icons.
Please take a look at the contribution guidelines to get more information on how to design good folder icons.

@PKief done, I believe that now the motive fits better with the other folder icons.


Tidy misc rounds

Closes #89

[x] Remove preceding c_ from 252 (but issues with starting with number so prepend with misc_)
[x] Typo in 2 doz distances
~Move number of doz to end, start with distance?~ - not implemented as current phrasing matches common parlance better.

@TomHall2020 back after 5 weeks or so away.
Looking to get this up on PyPI asap.
Feel free to look over this, all fairly minor final cleanup before release.


I can't run the example/example.py after install habitat-sim and habit-lab

🐛 Bug
Steps to Reproduce
Steps to reproduce the behavior:

cd habit-lab
python example/example.py
I can't run the example.py, tail of the info in terminal:

I0708 18:43:48.215437  4814 Sensor.cpp:69] Deconstructing Sensor
I0708 18:43:48.215448  4814 Sensor.cpp:69] Deconstructing Sensor
I0708 18:43:48.216286  4814 Renderer.cpp:71] Deconstructing Renderer
I0708 18:43:48.216351  4814 WindowlessContext.h:17] Deconstructing WindowlessContext
Traceback (most recent call last):
  File "examples/example.py", line 30, in <module>
    example()
  File "examples/example.py", line 19, in example
    observations = env.reset()  # noqa: F841
  File "/home/jiayunjie/robot_sim/habitat-lab/habitat/core/env.py", line 220, in reset
    self.reconfigure(self._config)
  File "/home/jiayunjie/robot_sim/habitat-lab/habitat/core/env.py", line 303, in reconfigure
    self._sim.reconfigure(self._config.SIMULATOR)
  File "/home/jiayunjie/robot_sim/habitat-lab/habitat/tasks/rearrange/rearrange_sim.py", line 263, in reconfigure
    self._add_objs(ep_info)
  File "/home/jiayunjie/robot_sim/habitat-lab/habitat/tasks/rearrange/rearrange_sim.py", line 389, in _add_objs
    auto_sleep=self.habitat_config.get("AUTO_SLEEP", True),
  File "/home/jiayunjie/robot_sim/habitat-lab/habitat/tasks/rearrange/obj_loaders.py", line 88, in load_articulated_objs
    ao.transformation = T
AttributeError: 'NoneType' object has no attribute 'transformation'
I0708 18:43:51.005597  4814 Simulator.cpp:54] Deconstructing Simulator

I dont know the reason about that, please tell me how to solve it.

Closing in favor or #676

Closing in favor of #676
Can you please tell me how to solve it? #676 is also proposed by me, it is remain a problem, thanks!


AbstractDifferentiation stable docs 404

https://juliadiff.org/AbstractDifferentiation.jl/stable
Gives a 404 error

That's expected. Stable docs are only built when a new release is tagged, and there hasn't been a new release since the doc website was added. This will be fixed automatically once the next release is made (but this might take a few days since it will be a breaking release and we might want to include more breaking changes).


killed

why i am getting killed as output?

We need more debug.

i meet this error also.

@LianlianMao can you give us more information? The file you tried to analyze, steps to replicate, your hardware, ...
It might be a problem with too much RAM usage.

1.Here is some information about hardware:
(1)CPU:2.7GHz Intel,2 cpu, 8 cores per cpu, 2 threads per core.
(2)Memory:128G total, 120G used.
2.I am trying to analysis 2000 apk file. Because i am not sure all of these files are apk, i use this function 'androconf.is_android(filename)' to judge whether the file is apk before analysis it. Then I use the function 'misc.AnalyzeAPK(filename,session=None)' to start analysis apk. However, the process collapsed when finish the 141st apk.
Thanks!

do you process the apks in multiple threads? Do you have a backtrace?
have you montiored the RAM usage while analysing?
Can you look into the syslog if the OOM killer is active?

No, I only care my analysis result but ignore the RAM usage.


Inconsistent readRawBody behavior in some nitro presets

Environment
nitropack: 2.1.1
node: 18.12.1
deno: 1.30.2
Reproduction
https://github.com/Twitch0125/nitro-inconsistent
(stackblitz works for node-server and cloudflare workers https://stackblitz.com/edit/nitro-inconsistent?file=readme.md)

pnpm install
pnpm run:node-server or pnpm run:deno or pnpm run:cloudflare

Describe the bug
It seems that some of the utils behave differently if they're in different environments. I'm not sure if this is actually an issue in Nitro, Unenv, or H3. Creating it for Nitro because it has the most stars so this might be seen by more people here.
When I try to get the raw body with getRawBody I'm seeing different return values if its running in Deno or Cloudflare Worker presets.
Given a handler that looks like this
export default eventHandler(async (event) => {
  const body = await readRawBody(event);
  return { body, type: typeof body };
});

I can send it this json payload
{ "test": "testing json" }

and I'll get 3 different responses
node:
{"body":"{\"test\":\"testing json\"}","type":"string"}

deno:
{"body":"blob:null/a9f116d7-5f24-4f78-a50f-aa6432394633","type":"string"}

cloudflare:
{"body":{"type":"Buffer","data":[123,34,116,101,115,116,34,58,34,116,101,115,116,105,110,103,32,106,115,111,110,34,125]},"type":"object"}

Additional context
Looking into the code a bit, it looks like readRawBody() is checking a event.node.req.body property and then returns whatever that is. I'd guess the issue is in whatever codebase is setting that body property.
Logs
No response

Could you confirm with latest version of Nitro @Twitch0125 ? 🙏

Could you confirm with latest version of Nitro @Twitch0125 ? 🙏
Updated to nitro 2.3.1 and I am still seeing this issue. The reproduction repo  and stackblitz link were also updated

Seem related directly to h3: unjs/h3#363

https://github.com/unjs/h3/issues/363 will support Buffer for readBody but it might be safer option to choose.
The core of different types backs to the fact that raw input of providers is different (even for node for direct calls vs user fetch). While we might support to Buffer normalization more it adds more overhead.

@pi0 Any ETA on this getting merged?

This should be fixed via https://github.com/unjs/h3/pull/366 and https://github.com/unjs/h3/commit/19d133d6a33ffb742713f4d83f00f555aeb83224
Please upgrade lockfile and ping me to reopen if either readBody or readRawBody (with second param encoding set to false) are not returning a Buffer type.
Thanks for reporting the issue ❤


New Crowdin updates

:tada: This PR is included in version 0.52.0 :tada:
The release is available on:

v0.52.0
GitHub release

Your semantic-release bot :package::rocket:


Not working for PowerShell

I can get snippets to work as expected for a plain text file. But when I try the same thing with a PowerShell language snippet, I get all of the prompts but nothing gets written to the powershell.json file. I have other snippets in the file so I know it works. No errors and no results.  Running VS Code 1.10.2

Think I found the problem. The default PowerShell.json file includes a large block comment explaining how to use it. Manually entering snippets still works. But when your extension is running I think it is failing with an unsurfaced error. I removed the block comment and now the extension works as expected.

It is fixed in version 0.0.4


Remove remote working as an option

Trello card URL:
https://trello.com/c/4owuXmAO/762-update-working-pattern-options-so-there-is-more-flexibility-around-types-of-role-reflecting-the-needs-of-jobseekers-schools
Changes in this PR:
Remove remote working as an option. The guidance includes it as a footnote, but suggests that it's uncommon. We think that including it would be misleading without further explanation.

 Update 'working pattern' options so there is more flexibility around types of role reflecting the needs of jobseekers/schools


Setup New Relic and Observability

Overview
In order to keep an eye on the performance of our app we want the New Relic Ruby Gem installed.
Action Items

Get setup with a Code for Boston New Relic account (contact @mzagaja).
Get a New Relic API Key
Add the New Relic gem to the backend.

Added the gem a little while ago
dcdb6cb83a9dbddf1c09dd346d73e9fef25b93b0


[BUG] quotePlugin doesn't handle multi-line quotes correctly

[x] I have searched for similar issues in both open and closed tickets and cannot find a duplicate.
[x] I have read the documentation and cannot find an answer.

Describe the bug
A blockquote can appear as a multi-line quote in rich text mode, but rendering it using a markdown renderer puts everything on a single line.
To Reproduce
With the quotePlugin enabled, either:

In rich text mode:

Create a quote
Use shift+enter to insert additional lines

In source mode:

Write a quote in the format:> line one
> line two

The quotes will appear on multiple lines in rich text mode - however, if the value is rendered in a markdown render, they will appear on a single line.
Expected behavior
I would expect quotes created in the manner described above to appear on a single line, as they would when rendering markdown.
Screenshots
Rich text mode:

Source mode:

Rendering using markedjs:

Desktop (please complete the following information):

OS:  Windows
Browser: Chrome

This seems to be a difference in the markdown engines. There are several discussions in the internet discussing this. For the record, Github renders the quotes with a multiple line:

line one
line two


⚠ Bofrost.de has degraded performance

In c642934, Bofrost.de (https://www.bofrost.de) experienced degraded performance:

HTTP code: 200
Response time: 1817 ms

Resolved: Bofrost.de performance has improved in 63eaa10 after 11 minutes.


[stable/grafana] Support ingress.extraPaths for grafana

What this PR does / why we need it:
Adding ingress.extraPaths configuration to allow users to prepend additional paths to every host. This is required when working with aws-alb-ingress-controller and configuring ssl redirection (see https://kubernetes-sigs.github.io/aws-alb-ingress-controller/guide/tasks/ssl_redirect/).
Special notes for your reviewer:
Inspired on this PR (which was not closed yet): https://github.com/helm/charts/pull/15080
Checklist

[x] DCO signed
[x] Chart Version bumped
[x] Variables are documented in the README.md
[x] Title of the PR starts with chart name (e.g. [stable/chart])

/assign @rtluckie

/ok-to-test
/lgtm


Theming Documentation

Adds theming example. I've added a few form inputs (TextInput, SelectInputNative, OptionTileGroup) but there themability is being addressed in a separate pull request
https://user-images.githubusercontent.com/1447339/154564771-b4cf31ec-2605-460d-98f7-871b9ab4d2cc.mov
What type of change is this?
Please delete options that are not relevant.

[x] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[x] Updating documentation.
[ ] Updating deployment/build pipeline.
[ ] Updating Project Dependencies
[ ] Improving or adding to Test Coverage

Completeness Checklist

[ ] TESTS: My changes maintain the baseline required test coverage, as specified by code climate analysis.
[ ] DOCS: All new component work is covered in that component's Overview docs.
[ ] DOCS: All new component work is covered in a component Playground.
[ ] DOCS: All new visual changes or options are covered under relevant components' VisualTests.
[ ] My code has no linting or typescript compile warnings.
[ ] My work is tied to a Github issue and satisfies the acceptance criteria (if applicable) of the corresponding issue.

Quality Checklist:

[ ] My code follows the style guidelines of this project
[ ] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes

UI Checklist

[ ] I have conducted visual UAT on my changes/features.
[ ] My solution works well on desktop, tablet, and mobile browsers.

 Pagination -- add border-radius and childGap to page number buttons


Component: Button

reference: https://flowbite.com/docs/components/buttons/

👍🏻Done:

Button component
Props - color, gradient, size, pill, outline, shadow
Prefix/Suffix slots and default slot
Docs with everything that implemented
✊🏻To-Do:
? social/payment buttons(do i really need to do them. they can be already implemented with slots)
icon buttons
loading buttons
disabled state
some tests

@zoltanszogyenyi
added button group and almost all button variants from flowbite original docs. The only variants I skipped - payment and social buttons. I think we can merge it


Nessus: merge importers

Is your feature request related to a problem? Please describe
There are two Nessus importers: nessus and nessus was. Both are using almost the same parsing methods so there is redundancy which is harder to maintain.
Describe the solution you'd like
Merge two them
Describe alternatives you've considered
I don't know about the alternative.
Additional context
https://github.com/DefectDojo/django-DefectDojo/pull/5471#issuecomment-977904248

@kiblik our current parser model support having one parser that manage both. I think this could be done. I can take a look.


[Enhancement]: adding back ground color  and font color

Do you want to have the enhancement of existing game ? 😀 Describe yourself..
Game enhancement by adding color to make appearance of site better.
Describe the solution you'd like
Solution steps ->I would like to work on this issue by adding background color and text color.
Select program in which you are contributing
GSSoC23
Code of Conduct

[X] I follow CONTRIBUTING GUIDELINE of this project.

I've noticed an opportunity to enhance the project's aesthetics by adding background and font colors. Mind if I contribute these changes?

Please assign this issue to me. I want to contribute in this project

I am interested in making the website a little more attractive and responsive.
Requesting to assign me this issue to me

Please assign this issue to me for the GSSOC24. I would like to make the UI of this website more interesting and creative.

please assign me this issue

Hello there!
I'm excited about the opportunity to enhance the game by adding background color and font color (#2). Improving the appearance of the site can greatly enhance the overall user experience and make the game more visually appealing.
I'd love to take on this task and work on implementing the solution steps by adding background color and text color. This involves carefully selecting color schemes that complement each other and align with the game's theme, ensuring a cohesive and visually pleasing design.
Looking forward to diving into this enhancement and contributing to the game's aesthetic appeal!
Best regards,
Nidha Ahmed Mohammad

I can solve this issue , please assign this this to me

I am experienced in web development, having designed various websites and contributed to college club websites. I can help solve issues by adding background and font colors effectively. Please assign me this issue.

Hi, I am a beginner in web development and I am eager to learn new things and implement them for which I find open very useful
I would like work on this and explore much more possibilities and creativity
Solution ->
I want to enhance the dashboard by adding solid back ground colors if possible gradient back ground color and
add hover features to input fields, create card for instructions making it more appealing and also a lot more changes to make it look user friendly and intuitive
assign this task to me I would like to contribute under GSSoC'2024
I promise to follow the Code of Conduct

Please assign me

Please assign this project.

Hey, I think the aesthetics of the game can be improved more to increase user experience so I request you to assign me as to showcase my my experience.

Hey, I would like to work on the same. Can you please assign this to me.

@Muskansahuincredible @nidhaahmed @20ankur07 @mdramijzamadar @Paavni-Goyal @mdramijzamadar @BhargavTammana Please raise any other issue, i'll assign you
If you have any doubt you can directly send message on our discord (https://discord.gg/rZb46cCMmK), we have created seprate chennals for all projects...
Thank you :)

please assign me this issue


Seeting the JVM arguments

Hello team,
I have deployed an application using liberty build pack and now after deploying I have to set JVM arguments custom properties for that application , how can I set the custom properties for the application built on libert build
Note:  tried to set the evn variables but application is not working as expected.

setting a JVM argument can be done by using the cf set-env APPNAME ENV_VARIABLE OPTION
in your case you want somethng like:
cf set-env myapp JVM_ARGS '-Xdump:heap+java+snap:events=systhrow,filter=java/lang/OutOfMemoryError'
just replace the argument for one you want to use.
IBM provides documentation for configuring the JRE here:
https://console.ng.bluemix.net/docs/runtimes/liberty/customizingJRE.html

Hello Joseph,
Thank you I am able to load the application as expected.
Regards,
Praveen.S
On Tue, Sep 27, 2016 at 10:04 PM, Joseph Marrero<EMAIL_ADDRESS>wrote:

setting a JVM argument can be done by using the cf set-env APPNAME
ENV_VARIABLE OPTION
in your case you want somethng like:
cf set-env myapp JVM_ARGS '-Xdump:heap+java+snap:events=
systhrow,filter=java/lang/OutOfMemoryError'
just replace the argument for one you want to use.
IBM provides documentation for configuring the JRE here:
https://console.ng.bluemix.net/docs/runtimes/liberty/customizingJRE.html
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/cloudfoundry/ibm-websphere-liberty-buildpack/issues/312#issuecomment-250052601,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AUFuub_q3ARa5BbjMYm5ZXW5qoDzuNPPks5qucsmgaJpZM4KG31c
.

--
Thanks & Regards,
Praveen Kumar S
+91<PHONE_NUMBER>

Hello Joseph,
I am sometime encountering the issues while loading the directories and sub
directories after setting the JVM args,
I am able to see the logs some times and sometimes not.
On Wed, Sep 28, 2016 at 10:04 AM, Praveen sadineni<EMAIL_ADDRESS>wrote:

Hello Joseph,
Thank you I am able to load the application as expected.
Regards,
Praveen.S
On Tue, Sep 27, 2016 at 10:04 PM, Joseph Marrero<EMAIL_ADDRESS>
wrote:

setting a JVM argument can be done by using the cf set-env APPNAME
ENV_VARIABLE OPTION
in your case you want somethng like:
cf set-env myapp JVM_ARGS '-Xdump:heap+java+snap:events=
systhrow,filter=java/lang/OutOfMemoryError'
just replace the argument for one you want to use.
IBM provides documentation for configuring the JRE here:
https://console.ng.bluemix.net/docs/runtimes/liberty/customizingJRE.html
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/cloudfoundry/ibm-websphere-liberty-buildpack/issues/312#issuecomment-250052601,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AUFuub_q3ARa5BbjMYm5ZXW5qoDzuNPPks5qucsmgaJpZM4KG31c
.

--
Thanks & Regards,
Praveen Kumar S
+91<PHONE_NUMBER> <%2B91%209611411664>

--
Thanks & Regards,
Praveen Kumar S
+91<PHONE_NUMBER>

Cleared the cache also and tried
On Wed, Sep 28, 2016 at 10:43 AM, Praveen sadineni<EMAIL_ADDRESS>wrote:

Hello Joseph,
I am sometime encountering the issues while loading the directories and
sub directories after setting the JVM args,
I am able to see the logs some times and sometimes not.
On Wed, Sep 28, 2016 at 10:04 AM, Praveen sadineni<EMAIL_ADDRESS>wrote:

Hello Joseph,
Thank you I am able to load the application as expected.
Regards,
Praveen.S
On Tue, Sep 27, 2016 at 10:04 PM, Joseph Marrero <
<EMAIL_ADDRESS>wrote:

setting a JVM argument can be done by using the cf set-env APPNAME
ENV_VARIABLE OPTION
in your case you want somethng like:
cf set-env myapp JVM_ARGS '-Xdump:heap+java+snap:events=
systhrow,filter=java/lang/OutOfMemoryError'
just replace the argument for one you want to use.
IBM provides documentation for configuring the JRE here:
https://console.ng.bluemix.net/docs/runtimes/liberty/customizingJRE.html
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/cloudfoundry/ibm-websphere-liberty-buildpack/issues/312#issuecomment-250052601,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AUFuub_q3ARa5BbjMYm5ZXW5qoDzuNPPks5qucsmgaJpZM4KG31c
.

--
Thanks & Regards,
Praveen Kumar S
+91<PHONE_NUMBER> <%2B91%209611411664>

--
Thanks & Regards,
Praveen Kumar S
+91<PHONE_NUMBER> <%2B91%209611411664>

--
Thanks & Regards,
Praveen Kumar S
+91<PHONE_NUMBER>

I am happy that you can now load the application as expected. Closing as JVM_ARGS can be set correctly and it was just a matter of configuration. If you have issues getting the logs please post a detailed explanation including what you are seeing in the log. But since reading the logs is not related to setting the JVM_ARGS i am closing this issue.


Enabling document set feature from template causes bugs

Hi,
I have managed to enable the docset feature from the provisioning template, however, if you enable such feature either from the xml template or the pnp-powershell, it causes the bugs described on this other github issue
It seems that the only way to do this is using the GUI. Any help ? thanks

Looks like in case of enabling this feature either from pnp-powershell, csom or provisioning template, you first need to allow site custom scripts first. Here is a workaround.


Multiple Checkbox in Dialog

I have multiple checkbox in Dialog what I want is i want to make check boxes check one at a time means user can check one checkbox out of multiple checkbox at a time. How can I do this ?

Do you mean radiobutton funtionality? Why not go with that?
Otherwise try to make Validation Rule, or just check how many are checked each time one of them is checked (TS)


Text formatting and misalignment in group / users screen

In the group / users screen the text that says the admin's name is smaller and the admin text is misaligned and also smaller.

You said the admin text is misaligned,
What does it look like in the iOS view?
For now I fixed the size of the font for the Admin's user name, and centered the admin tag. However, I think the admin tag should be directly under the userName. See the second attached image to see what I mean.
If you pick one I will merge it from the hotfixes branch.

Hi @kykrueger
I think the second one is better but the "Admin name" text should be moved up and there should be more space between the name and the "Admin" text. If this is difficult, then the first one is fine - it would be even better if the admin text was moved down a little - so it looked like it was sitting on the same line as the name text. Otherwise it could just be set to the same size as that text.
This isn't a critical issue so just do what's easiest.

The layout has been updated in the latest hotfix. There was no pull request made, but the changes have been merged and pushed. I am closing this issue.


V-Sync disables when window not visible, causing GPU to go to 100% [Metal]

Bug Description
Observed on macOS 12.2, with M1-Pro GPU
When the render window is not visible (ie hidden behind another OS window, offscreen or minimised) the frame-rate goes up dramatically until the gpu is at 100% capacity. Upon revealing the window, the frame-rate and GPU utilisation go back to the normal V-Sync frame-rate.
To Reproduce

Launch any example on macOS with Metal Renderer (I tested it with 01-cubes)
Completely Hide or minimize the window (if the window can be seen through a transparent window, its considered visible)
GPU Utilisation should go up to 100% until the window is visible again

GPU at around 25 % and at 100% when render window is behind IDE window

Additional context
Using a simple timer I tracked down what causes this unexpected refresh rate, though I'm not familiar enough with Metal to understand exactly what exactly is wrong.
https://github.com/bkaradzic/bgfx/blob/3d4bd88c0635b614b453aac1003cc56a11d1ccf0/src/renderer_mtl.mm#L3377
m_metalLayer.nextDrawable blocks the render thread to wait for V-Sync synchronisation. (approximately 8ms for 120Hz refresh rate in my case)
However when the window is not visible, this function does not block anymore, causing the render loop to go as fast as possible.
m_metalLayer.nextDrawable is called by SwapChainMtl::currentDrawableTexture() in the following call hierarchy:

I thought of implementing a short sleep timer to avoid the render thread exceeding my monitors max frame rate, but then again I'm not sure how to access the max frame rate value in a cross platform way...
Any help is much appreciated, thanks !

I have checked this on an intel macbook and cannot reproduce it.
Does nextDrawable returns nil when the window is not visible?
on iOS and tvOS you shouldn't use GPU when app is in the background. (https://developer.apple.com/documentation/metal/preparing_your_metal_app_to_run_in_the_background?language=objc)
I guess on macOS it would make sense to stop rendering in the background too.

(void)windowDidChangeOcclusionState:(NSNotification *)notification;
https://stackoverflow.com/questions/24086398/viewwillappear-or-viewdidappear-on-nswindowcontroller
I have tested it with minimize and hiding behind another window and it worked well.

It could be added here:  https://github.com/bkaradzic/bgfx/blob/3d4bd88c0635b614b453aac1003cc56a11d1ccf0/examples/common/entry/entry_osx.mm#L832
And pass it to s_ctx and somehow disable rendering and slow down the update loop.

And pass it to s_ctx and somehow disable rendering and slow down the update loop.

Update loop is in that file, here: https://github.com/bkaradzic/bgfx/blob/3d4bd88c0635b614b453aac1003cc56a11d1ccf0/examples/common/entry/entry_osx.mm#L525-L535
But be careful for case when multiple windows are present, and one is occluded, which other is not... Logic should be: if all windows are occluded slow down update loop.

It seems to be a macOS bug on newer versions, which causes nextDrawable not blocking when the window is occluded. Might be related to this https://github.com/gfx-rs/wgpu/issues/1783.


QR Code Model 1 not supported

First of all, thank you for providing such a nice library.
This QR code is not recognized, but I don't know what the problem is.
The smartphone app recognized it, so I don't think the QR code is broken.

I do believe that this symbol is in fact invalid. It is correctly detected but could not be decoded due to a checksum error. I checked the sample grid if there was an issue there but the grid placement is perfectly fine. I also tried to decode this image with a couple different online scanners and all agree that there is no valid qrcode to be found.
Which "smartphone app" were you using and what was the content of the detected qrcode?

The app I was using was "QRQR"
And the string read is "766400488514071012112935"
I have attached the app URL below.
https://www.denso-wave.com/en/system/qr/product/reader.html

Thanks for the information.  According to the ISO specification, "Model 1 of QR Code, as defined in AIM ITS 97-001, is the form of the symbology originally used for a number of early or closed systems applications but is not recommended for use in new or open systems applications [...]". Model 1 codes are simply not implemented. If you need support for those and have some money to throw at the problem, please get in touch with me via zxingcpp (at) gmail.com.

thank you for your reply.
I'm sorry if my understanding is wrong.
I believe that the difference between Model 1 and Model 2 of QR codes is the presence or absence of alignment patterns.
However, this library may be able to read her QR code without alignment pattern.
I don't know what the difference is.
I hope you'll tell me.
I have pasted the QR code read by "zxing" below.

That is not entirely correct. Model 1 has no alignment patterns in any of the available sizes (or versions in QR speak). Model 2 Version 1 has no alignment patterns but higher versions have them. The most relevant difference is (quote) "symbol character placement follows different rules", i.e. the way the black/white squares are to be interpreted is different.

thank you! I understood it well.
Model 1 and version 1 of model 2 are confusing.
Is there a way to tell them apart visually?
I did a quick search, but couldn't find any information on how to differentiate or how to decode Model 1...

Is there a way to tell them apart visually?

If you have a Version 1 symbol (21 modules wide and high) then you are out of luck. For all symbols with higher Version numbers the Model 2 symbols have alignment patterns, Model 1 don't.
Your original sample is 29 modules wide, i.e. Version 3 and has no alignment patterns, therefore Model 1.
For information on how to decode them, you'd need the specification document.

なるほど、それは難しいですね。 。 。
私のアプリはモデル 1 QR コードを読み取る必要があるため、この問題に対処する必要があります。
そこで、ご連絡させていただきたいと思います。

I see, that's difficult.
My app needs to recognize model 1 QR code and I have to solve this problem.
So I would like to contact you.

Dear axel
Thanks for contacting.
Yes, I am very interested in contributing my work.
That'd be my honor.
Best,

差出人: axxel @.>
送信日時: 2023年10月17日 16:30
宛先: zxing-cpp/zxing-cpp @.>
CC: Nakatsubo Seiji @.>; Author @.>
件名: [EXTERNAL] Re: [zxing-cpp/zxing-cpp] QR Code Model 1 not supported (Issue #614)
I noticed that you published an implementation to support Model1 herehttps://github.com/sayzzy-nt/zxing-cpp/commit/724a8e6c28d1d1b8e412ebef3b440005cf1efa76. That is nice. Would you be interested in preparing a PR and contributing your work here?
—
Reply to this email directly, view it on GitHubhttps://github.com/zxing-cpp/zxing-cpp/issues/614#issuecomment-1765829351, or unsubscribehttps://github.com/notifications/unsubscribe-auth/BAPZYOQGRGJXHAZZHCPAS5TX7YX3BAVCNFSM6AAAAAA4QEKVX6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTONRVHAZDSMZVGE.
You are receiving this because you authored the thread.Message ID: @.***>

Yes, I am very interested in contributing my work.

That is very good to hear. I'll wait for your pull request then before looking closely at your changes and will provide feedback if I see something questionable.


maestral-gui: 1.4.6 -> 1.4.8

Motivation for this change
Upstream update, including update for dependency desktop-notifier.
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[x] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
21.11 Release Notes (or backporting 21.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 135258 at 5315bb16 run on aarch64-linux 1

5 packages built successfully:

maestral (python39Packages.maestral)
maestral-gui
python38Packages.desktop-notifier
python38Packages.maestral
python39Packages.desktop-notifier

1 suggestion:

warning: python-include-tests
Consider adding a checkPhase for tests, or if not feasible, pythonImportsCheck.
Near pkgs/development/python-modules/maestral/default.nix:51:0:
   |
51 |     description = "Open-source Dropbox client for macOS and Linux";
   | ^

warning: python-include-tests
Consider adding a checkPhase for tests, or if not feasible, pythonImportsCheck.

Can you add this?

Done, I think.

This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
Result of nixpkgs-review pr 135258 run on x86_64-linux 1

5 packages built:

maestral (python39Packages.maestral)
maestral-gui
python38Packages.desktop-notifier
python38Packages.maestral
python39Packages.desktop-notifier


fixed up component example

request() takes the URL as first parameter, followed by options object.

@stopfstedt Thanks!


test: ReceiptProviderIdExt

Adds tests for the ReceiptProviderIdExt and solves #10341.

Please use special keywords for automatically closing the issue when referencing it https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword


Class to represent molecular hamiltonians

What should we add?
There should be a class to represent the molecular hamiltonian

It should be a subclass of the proposed PolynomialTensor #665. It should store the one- and two-body tensors. There should be functionality to convert between chemist and physicist indexing conventions, as well as converting to FermionicOp.
There's no need to wait for #665 since it can be made a subclass after the fact.

How do I represent the constant h_0 using ElectronicEnergy?


feat: add keyboard shortcuts for Editor actions

This PR closes #314
Adds Action to show CodeGPT Actions popup with keyboard shortcut:

All Actions are assigned an alpha-numeric letter for seamless keyboard controls.
I didn't really know how to define the best default shortcut, so I sticked with the  CTRL+SHIFT+ALT combo plus "M" (maybe "M" for "Menu"?), that doesn't seem to be used by anything too important:

thank you very much for your hard work


Be more lenient before deciding a peer is excessively throttling requests

PR Description
Previously a single request which didn't progress the chain by at least 50 blocks caused us to mark a peer as temporarily unsuitable as a sync target.  This could give false alarms during periods where a lot of validators were offline and leaving many sequential empty slots.  On Medalla this resulted in regularly restarting sync from the finalised slot and then abandoning the peer when we reached the gap in the chain.
Note, the test for detecting throttling has been disabled and will need to be updated to assert that disabling only happens after multiple responses.
Documentation

[x] I thought about documentation and added the documentation label to this PR if updates are required.

Updated tests here: https://github.com/ajsutton/teku/pull/3


Update manifest and other formatting for CD3 Automation Toolkit

Add here your WMS ID 11407
General requirements

Information in the workshop is adequate and updated
Code is correct and working
Links are correct
Make sure you enter the help email link in your manifest.json
Please make sure WMS URLs are updated as needed after your PR is approved

Checklist - Refer to the QA document for the complete list
Please confirm that the following is completed before submitting your PR

[ ] All filenames are lower case (including folders, images, files, etc.)
[ ] Filenames are descriptive
[ ] Your workshop folder structure should be similar to the one used in the sample workshop (https://github.com/oracle-livelabs/common/tree/main/sample-livelabs-templates/sample-workshop)
[ ] Are you using multiple versions (desktop/, sandbox/, tenancy/)? Make sure that each of them contains a manifest.json and an index.html
[ ] Image references in markdown contain an alternate text

@dipeshrath Please remove the jekyll-gh-pages.yml in .github/workflow from the commit

Removed as requested.


fix(TCOMP-236): fix input component archetype

Please check if the PR fulfills these requirements

[x] The commit message follows Talend standard
[x] Tests for the changes have been added (for bug fixes / features)

What is the current behavior? (You can also link to an open issue here)
input-components-archetype is not correct
What is the new behavior?
archetype was cleaned up and fixed
Does this PR introduce a breaking change?

[ ] Yes
[x] No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...
Other information:
https://jira.talendforge.org/browse/TCOMP-236
It's better to check generated project rather that this PR:
https://github.com/Talend/components/compare/work/TCOMP-236_input_archetype_example?expand=1
or in branch
https://github.com/Talend/components/tree/work/TCOMP-236_input_archetype_example/components/components-table
If you want try to build archetype do following:
mvn clean install (on components\examples\components-api-archetypes\input-component-archetypeinput-component)
than use following command to generate project:
mvn org.apache.maven.plugins:maven-archetype-plugin:2.4:generate -DarchetypeGroupId=org.talend.components -DarchetypeArtifactId=input-component-archetypes -DarchetypeVersion=0.18.0-SNAPSHOT

Pull request test result: failure :x:

Pull request test result: failure :x:

Build failed not because of my changes

Pull request test result: success :star:

Pull request test result: failure :x:

Pull request test result: failure :x:

Pull request test result: failure :x:

Pull request test result: failure :x:

Pull request test result: success :star:


HaploidWalker and GetHaplotypes

HaploidWalker abstract walker for tools reading haploid files
GetHaplotypes tool for converting diploid calls to haploids with different models
Tests for most of the code

Coverage increased (+18.7%) to 81.597% when pulling 92fa326d349f0b4c14d7f2eb68a2782c4f5ee739 on dgs_haplotype_walker into dd563584e0b4e110d556a5b633a001b7b77d3d55 on master.

Coverage increased (+18.7%) to 81.633% when pulling 801e6a5c77606e2c9653bc3e8bdbb130f10c801b on dgs_haplotype_walker into dd563584e0b4e110d556a5b633a001b7b77d3d55 on master.

Coverage increased (+19.1%) to 82.034% when pulling 7c14f305b757090b878ff6a4afbf23a6b4c22617 on dgs_haplotype_walker into dd563584e0b4e110d556a5b633a001b7b77d3d55 on master.

Coverage increased (+19.1%) to 82.034% when pulling c7d7d2e347ac0feeb5d3fdf859deb0a070d2b89a on dgs_haplotype_walker into dd563584e0b4e110d556a5b633a001b7b77d3d55 on master.

Coverage increased (+19.1%) to 82.034% when pulling cd8046d5f3146d27b321a088931015f81e55f91c on dgs_haplotype_walker into dd563584e0b4e110d556a5b633a001b7b77d3d55 on master.


Bug 2094405: missing env resource from disks list

📝 Description
when adding a resource from the environment tab when VM is running the resource is not shown on the disks list
🎥 Demo
before:

after:

Signed-off-by: Aviv Turgeman<EMAIL_ADDRESS>

/lgtm


use valid ESM imports/exports

Reviewer:
Asana:
Description
Steps to test

Current dependencies on/for this PR:

main

PR #187   👈

This comment was auto-generated by Graphite.


create-react-app Update Steps

The course was published using create-react-app 1.
Create-react-app 3 involves the following breaking changes that aren't yet reflected in the course:
NOTE: Checked boxes below signify patched, but need to be published and uploaded.

[ ] create-react-app 3 only generates one webpack.config. It uses env vars for settings. Need to update videos to reflect
[x] In "Testing" module, in Demo: Unit Testing, install the react-test-renderer version that matches your React version. Check package.json to see the version of React you're using. For example, if you're running React 16.8.0, then npm install<EMAIL_ADDRESS>[ ] Eliminate the separate /utils file that we create in M9-10 (testing) since it ultimately isn't used and can't be published that way because /utils doesn't get published.
[ ] In the "Publishing" module, in Demo: Production Component Library Build, make the following tweaks to the babel config:

[ ] This is patched at 2:22, but need to record this audio: "Note that I'm referencing the babel preset under the babel namespace. We're telling babel to transpile our modules to commonJS format, which is a common standard for npm packages. And we're tweaking the configuration of react-app.    We're setting the absolute runtime to false on the react-app preset. Otherwise the react-app preset will try to reference the babel runtime locally. We're setting helpers to false too. You can set helpers to true to potentially reduce your bundle sizes, but you need to add @babel/runtime as a dependency of your component library if you do so."
[ ] Babel 7 moved their packages under the @babel namespace. So, check your package.json for the version of @babel/core installed by create-react-app, and install the corresponding versions of @babel/preset-env and @babel/cli. For example, if @babel/core 7.1.0 is installed, then run this: npm i<EMAIL_ADDRESS><EMAIL_ADDRESS>[ ] Reference @babel/env (instead of babel-env)
[ ] Update final exercise files to reflect being generated from cra 3

In summary, do this:
  "babel": {
    "presets": [
      [
        "@babel/preset-env",
        {
          "modules": "commonjs"
        }
      ],
      [
        "react-app",
        {
          "helpers": false,
          "absoluteRuntime": false
        }
      ]
    ]
  },

Hi Cory, thanks so much for this course, it's been quite helpful to me. to follow up on this, setting "modules":"false" is all it's needed to produce the es6 module build?

Thanks! Yes, I believe that's correct. You can also check out nwb as an example of an ES module build config.

Thanks.. A LOT!. Cory that issue  was me crazy.  For now, everything Good


Discussion: Changes to allow interoperability with other scrapers/decrease network traffic

Hey,
These are more involved additions: definitely let me know if you have questions, concerns, or suggestions for a better way to approach this. The default behaviour if the user does not specify any of the new flags should be identical to the old behavior of the program.
These additions are intended to allow get_cover_art to interoperate with other scrapers and use local copies of art when they exist: a lot of setups keep each album in a separate directory, with a "cover.jpg" file in that directory. This branch adds flags that will use that art (embedding it into the media files) if it exists. The user can select whether to use that art if it exists and only do a network lookup if necessary, or to prefer the network lookup and only fall back to the local files if the network is unsuccessful.
The popular Kodi mediaplayer has a number of scrapers that could interact with these additions, for example.
The README.md diff should have detailed info on how this behaves, but I've essentially added the following options:
--use-folder-art : before, after, or none (default none). If it's none, local files are ignored (current behavior). If it's before, then local files are prefered to avoid network traffic. If it's after, local files are used only as fallbacks.
--folder-art-name : A list of one or more filenames to look at locally. Defaults to "cover.jpg _albumcover.jpg folder.jpg", which are 3 filenames used by pretty common scrapers (note that even though there is a default value here, these files are still ignored unless the user specified --use-folder-art of before or after).
There is also a third option, --output-filename, that allows get_cover_art to output cover image files using a particular name. The default is "{artist} - {album}.jpg", which is backward compatible with the old naming scheme. But if a user wants to generate a different name patter (for compatibility with other scraping systems they're using), they can do that here.

I'm testing this branch now, but some of my test cases no longer work.  Examples:

running this from the interpreter or another script, rather than main:

python3 -c "from get_cover_art import CoverFinder; CoverFinder({'force': True}).scan_folder('../mp3test/test')"

python3 -c "from get_cover_art import CoverFinder; CoverFinder({'force': True}).scan_file('../mp3test/test/test1.mp3')"

Both cases fails with 'NoneType' object has no attribute 'format'

running with --test to download but not embed, and then running with --no_download to only embed already-downloaded artwork:

    python3 -m get_cover_art --path=../mp3test/test --verbose --force --test
    python3 -m get_cover_art --path=../mp3test/test --verbose --force --no_download

The first command succeeds, but the second one fails with local variable 'local_art' referenced before assignment
I had some local path in my example, but it can be any local path to audio files.

 I believe both of these should be fixed by the latest commit.

Thanks, your changes fixed the 'local_art' referenced before assignment error, but I'm still getting the 'NoneType' object has no attribute 'format' error when importing the script in Python.   See -c commands from my last comment, or you could also reproduce as follows:
from get_cover_art import CoverFinder
finder = CoverFinder({'force': True})
finder.scan_folder('../mp3test/test')"
finder.scan_file('../mp3test/test/test1.mp3')"

(you'll need to change the paths to point to your own audio files, but you get the idea)

Oh, I see what you're saying. Yes, I needed to fall back to the DEFAULT value in the CoverHandler init function.
That should be fixed in the current HEAD.

--output-filename is renamed to --art-filename in the latest commit, 98256be116162ae847ea992ad3d7fcd5643c5c77

Now that the tests are passing, I'm trying to understand all your changes (I probably should've read closer before).  At first I thought --folder-art-name meant a folder name, not a filename.  I don't want to ask for more parameter renames without understanding this better:
Art Folder options:
inline = use same folder as audio file
dest = artwork folder override (ignored if --inline)
Art File options:
folder-art-name = what filename to look for (within Art Folder)
art-filename = what filename to save as (within Art Folder)
Behavior:
Here's where I'm really confused:
--use-folder-art=none: "local files are ignored (current behavior)"

but that's not current behavior.  In my readme: "Step 2 is skipped if it had already downloaded (or attempted to download) the image file".  Does that not work for you?  Is there a bug?  --use-folder-art : none should be equivalent to --force

--use-folder-art=before: "then local files are prefered to avoid network traffic"

this should already be the default behavior (unless there's a bug)

--use-folder-art=after: "local files are used only as fallbacks"

this seems like the only new behavior

Am I understanding this correctly?

The subtlety that makes these options useful is that the folder-art-name is
the name(s) of pre-existing art (possibly from some other system, like a
Kodi or VLC scraper), which can be different from the art-filename (which
is the name of the art files downloaded and “owned” by get_cover_art).
Obviously the current naming isn't intuitive.  Perhaps rename:
--folder-art-name  to --existing-art-name or --external-art-name
--use-folder-art to --use-existing-art or --use-external-art
Think of "folder-art-name" as "the files owned/downloaded by any other
scrapers I use" and "art-filename" as "the files owned/downloaded by
get_cover_art.py".  You're 100% correct that if you decide to specify
"--inline --art-filename cover.jpg" then all of a sudden the two systems’
files are being kept in the same place, and the behavior is very close to
what's already been specified.
But the normal use-case I envision is that they'd be different: for
instance, a Kodi scraper just drops a single cover.jpg into each directory.
But the get_cover_art user wants to use the {album} - {artist} naming in
the --dest directory for the get_cover_art downloads, because it's less
cluttered and more robust if some directories have files from multiple
albums. Or maybe the other scraper gets angry if you overwrite its files.

By default, the local cover.jpg will be ignored (this is the same as
current behavior). An existing Artist - Album.jpg in the --dest directory
will still be used.
Specifying "--use-folder-art before" will always insert a pre-existing
cover.jpg if it's found, rather than hitting the network. If you do
download a file, though, it will be stored as Artist - Album.jpg in the
--dest directory. This lets you avoid network traffic as much as possible
if another system's already downloaded covers, but it's potentially less
flexible if you don't strictly use one folder per album.
Specifying "--use-folder-art after" will only use the existing
cover.jpg if the network lookup fails. You're only relying on the other
system as a safety net if get_cover_art can't find a cover.

Whatever get_cover_art downloads will not step on the files downloaded by
the other scraper, and vice-versa (so long as the art-filename and the
folder-art-name are different): the external scraper's downloads will be
embedded in your music files, but otherwise the two systems leave each
other alone.
On Tue, Apr 20, 2021 at 7:32 PM Rego Sen @.***> wrote:

Now that the tests are passing, I'm trying to understand all your changes
(I probably should've read closer before). At first I thought
--folder-art-name meant a folder name, not a filename. I don't want to
ask for more parameter renames without understanding this better:
Art Folder options:
inline = use same folder as audio file
dest = artwork folder override (ignored if --inline)
Art File options:
folder-art-name = what filename to look for (within Art Folder)
art-filename = what filename to save as (within Art Folder)
Behavior:
Here's where I'm really confused:
--use-folder-art=none: "local files are ignored (current behavior)"

but that's not current behavior. In my readme: "Step 2 is skipped if
it had already downloaded (or attempted to download) the image file". Does
that not work for you? Is there a bug? --use-folder-art : none should
be equivalent to --force

--use-folder-art=before: "then local files are prefered to avoid network
traffic"

this should already be the default behavior (unless there's a bug)

--use-folder-art=after: "local files are used only as fallbacks"

this seems like the only new behavior

Am I understanding this correctly?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/regosen/get_cover_art/pull/7#issuecomment-823666453,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ACXVD6BAQ3USVEATOCGA4WLTJYFKPANCNFSM43E4VHFA
.

Ok, I see what you mean.  Then I would recommend the following to make usage more clear to users:

rename dest -> art-dest
rename inline -> art-dest-inline
rename art-filename -> art-dest-filename
rename use-folder-art -> external-art-mode
rename folder-art-name -> external-art-filename

And ideally group them as follows (don't worry about this part if it's too much trouble- I can made the changes myself after merging):
python -m get_cover_art [--path=<path_to_audio_file_or_folder>] [--options]

  --path PATH           audio file, or folder of audio files (recursive)

  --art-dest ART_DEST   set artwork destination folder
  --art-dest-inline     set artwork destination folder to same folders as audio files
  --art-dest-filename ART_DEST_FILENAME
                        set artwork destination filename format. Accepts {artist},
                        {album}, and {title}. Default '{artist} - {album}.jpg'

  --external-art-mode {before,after,none}
                        Use image from local folder; "before" prevents
                        downloads, "after" uses as a fallback.  Default is none.
  --external-art-filename EXTERNAL_ART_FILENAME [EXTERNAL_ART_FILENAME ...]
                        Filename(s) of folder art to use. Accepts {artist},
                        {album}, and {title} for replacement: e.g. cover.jpg
                        or {album}-{artist}.jpg

  --test, --no_embed    scan and download only, don't embed artwork
  --no_download         embed only previously-downloaded artwork
  --force               overwrite existing artwork
  --verbose             print verbose logging
  --throttle            wait X seconds between downloads

  --skip_artists SKIP_ARTISTS
                        file containing artists to skip
  --skip_albums SKIP_ALBUMS
                        file containing albums to skip
  --skip_artwork SKIP_ARTWORK
                        file containing destination art files to skip

Okay, I've made those changes in the most recent head, and re-ordered everything to match your suggestions.
I left in the old --inline and --dest arguments as aliases for the new options, to maintain backward compatibility (the primary names are now --art-dest-inline and --art-dest as requested, but --inline and --dest work as aliases in case any users have scripts out there using the existing option names).
This is just in the parser.add_argument options in main.py, so if you think that's not necessary you can pull the old aliases out easily: just eliminate the --dest and --inline arguments on lines 12 and 18 of main.py.

Good call on the aliases, this looks great!  Merging now


Modified README to include detailed information from the spec + fixed typos

First, there is important information in the Spec around providing unique src attributes for each player on the page. I think this information should be put front and center on in the README as well. Also, I noticed a typo in the seeked event handler docs.

Thanks @sparrowj !!!!!


Add support for snake case key in raw message struct

Hi @pranav12verma, thank you for the PR.
I want to keep these types consistent with Go's standard library types, such as sql.NullString. As you can see, they don't have any struct tags, so I don't want to add tags either. For this reason, I'm going to close this PR.
If you need these specific tags, you can use your own fork.
Again, thanks for your contribution.


How to close dialog on click outside the image

I'm using PhotoView inside a full screen dialog like this
<RelativeLayout
    xmlns:android="http://schemas.android.com/apk/res/android"
    android:layout_width="match_parent"
    android:layout_height="match_parent">

    <com.github.chrisbanes.photoview.PhotoView
        android:id="@+id/photo_view"
        android:layout_width="match_parent"
        android:layout_height="match_parent"/>
</RelativeLayout>

The PhotoView width and height are set to match_parent and hence cover the entire screen.
If image proportions differ from the screen ones then image is scaled to fit in the center and there will be some unused space in the view.
When user clicks on the view, is it possible to detect if the click was done outside the actual image to close the dialog?

have a look at setOnOutsidePhotoTapListener method


add on redis key prefix when retrieving current

current is just the revision id without the prefix so the example doesn't work.

Good catch!