ParquetDataset has an invalid parameter validate_schema

Description
Parquet files are unable to be read and loaded into the proper ParquetDataset object when used with make_batch_reader. This is due to a deprecated parameter validate_schema=False that was removed in v15.0.0 version of pyarrow.
Actual behavior
/opt/omniai/work/instance1/jupyter/projects/luke/luke-env/lib/python3.9/site-packages/keras/src/backend.py:452: UserWarning: `tf.keras.backend.set_learning_phase` is deprecated and will be removed after 2020-10-11. To update it, simply pass a True/False value to the `training` argument of the `__call__` method of your layer or model.
  warnings.warn(
2024-01-26 19:39:09,352 [INFO] /opt/omniai/work/instance1/jupyter/projects/luke/docs/examples/data/parquet
INFO:luke_logger:/opt/omniai/work/instance1/jupyter/projects/luke/docs/examples/data/parquet
2024-01-26 19:39:09,352 [INFO] Mode: val
INFO:luke_logger:Mode: val
2024-01-26 19:39:09,352 [INFO] Reading from: /opt/omniai/work/instance1/jupyter/projects/luke/docs/examples/data/parquet
INFO:luke_logger:Reading from: /opt/omniai/work/instance1/jupyter/projects/luke/docs/examples/data/parquet
2024-01-26 19:39:09,352 [INFO] num_epochs is: None
INFO:luke_logger:num_epochs is: None
2024-01-26 19:39:09,352 [INFO] Reader pool type: thread
INFO:luke_logger:Reader pool type: thread
2024-01-26 19:39:09,353 [INFO] file:///opt/omniai/work/instance1/jupyter/projects/luke/docs/examples/data/parquet
INFO:luke_logger:file:///opt/omniai/work/instance1/jupyter/projects/luke/docs/examples/data/parquet
/opt/omniai/work/instance1/jupyter/projects/luke/luke-env/lib/python3.9/site-packages/petastorm/fs_utils.py:88: FutureWarning: pyarrow.localfs is deprecated as of 2.0.0, please use pyarrow.fs.LocalFileSystem instead.
  self._filesystem = pyarrow.localfs
KILL ALL!
Traceback (most recent call last):
  File "/usr/local/lib/python3.9/runpy.py", line 197, in _run_module_as_main
    return _run_code(code, main_globals, None,
  File "/usr/local/lib/python3.9/runpy.py", line 87, in _run_code
    exec(code, run_globals)
  File "/opt/omniai/work/instance1/jupyter/projects/luke/luke/train/run.py", line 315, in <module>
    main(obj={})
  File "/opt/omniai/work/instance1/jupyter/projects/luke/luke-env/lib/python3.9/site-packages/click/core.py", line 1157, in __call__
    return self.main(*args, **kwargs)

  File "/opt/omniai/work/instance1/jupyter/projects/luke/luke-env/lib/python3.9/site-packages/click/core.py", line 1078, in main
    rv = self.invoke(ctx)
  File "/opt/omniai/work/instance1/jupyter/projects/luke/luke-env/lib/python3.9/site-packages/click/core.py", line 1688, in invoke
    return _process_result(sub_ctx.command.invoke(sub_ctx))
  File "/opt/omniai/work/instance1/jupyter/projects/luke/luke-env/lib/python3.9/site-packages/click/core.py", line 1434, in invoke
    return ctx.invoke(self.callback, **ctx.params)
  File "/opt/omniai/work/instance1/jupyter/projects/luke/luke-env/lib/python3.9/site-packages/click/core.py", line 783, in invoke
    return __callback(*args, **kwargs)
  File "/opt/omniai/work/instance1/jupyter/projects/luke/luke-env/lib/python3.9/site-packages/click/decorators.py", line 33, in new_func
    return f(get_current_context(), *args, **kwargs)
  File "/opt/omniai/work/instance1/jupyter/projects/luke/luke/train/run.py", line 169, in from_config
    run_steps(ctx)
  File "/opt/omniai/work/instance1/jupyter/projects/luke/luke/train/run.py", line 298, in run_steps
    luke_run.run_steps()
  File "/opt/omniai/work/instance1/jupyter/projects/luke/luke/train/runner_class_tf.py", line 69, in run_steps
    result = step.execute(self.global_config, self.model)
  File "/opt/omniai/work/instance1/jupyter/projects/luke/luke/train/steps_tf/train_evaluate_step.py", line 137, in execute
    evaluator_results = model.train_and_evaluate(
  File "/opt/omniai/work/instance1/jupyter/projects/luke/luke/model_defs/models_tf/base_keras_model.py", line 221, in train_and_evaluate
    history = self.fit(
  File "/opt/omniai/work/instance1/jupyter/projects/luke/luke/model_defs/models_tf/base_model.py", line 168, in fit
    return self.training_fn(
  File "/opt/omniai/work/instance1/jupyter/projects/luke/luke/model_defs/models_tf/base_keras_model.py", line 122, in training_fn
    validation_data = validation_data()
  File "/opt/omniai/work/instance1/jupyter/projects/luke/luke/data/base_reader.py", line 116, in val_input_fn
    dataset = dataset_fn(
  File "/opt/omniai/work/instance1/jupyter/projects/luke/luke/data/base_reader.py", line 280, in get_petastorm_dataset
    reader = self.get_reader(  # pylint: disable=E1123
  File "/opt/omniai/work/instance1/jupyter/projects/luke/luke/data/local_reader.py", line 33, in get_reader
    return make_batch_reader(
  File "/opt/omniai/work/instance1/jupyter/projects/luke/luke-env/lib/python3.9/site-packages/petastorm/reader.py", line 298, in make_batch_reader
    dataset_metadata.get_schema_from_dataset_url(dataset_url_or_urls, hdfs_driver=hdfs_driver,
  File "/opt/omniai/work/instance1/jupyter/projects/luke/luke-env/lib/python3.9/site-packages/petastorm/etl/dataset_metadata.py", line 402, in get_schema_from_dataset_url
    dataset = pq.ParquetDataset(path_or_paths, filesystem=fs, validate_schema=False, metadata_nthreads=10)
TypeError: __init__() got an unexpected keyword argument 'validate_schema'

Expected behavior
The dataset is loaded properly into the ParquetDataset object so that it can be consumed downstream.

It seems that the validate_schema argument has been removed with the update of pyarrow.
I resolved this issue using petastorm=0.12.1,  pyarrow=10.0.1
Using Reader and make_reader in the petastorm, data is loaded successfully.
However, deprecated warning is being displayed due to the previous version, and It's not pretty.
I hope someone shares a fancy solution using the latest version.
here is my work
fs = s3fs.S3FileSystem(key="ACCESS_KEY", secret="SECRET_KEY", endpoint_url="ENDPOINT")
reader = make_reader(dataset_url="s3a://YOUR/DATA/PATH", filesystem=fs) as reader

or

reader = Reader(dataset_path = "s3a://YOUR/DATA/PATH")

https://github.com/uber/petastorm/issues/758#issuecomment-1785925528


Add 'listApiDeclarations' function.

@mohsen1 Can you please review?
If general idea is ok, I will work on tests and docs.

Are you trying to guess it or is it always accurate? This can make the API simpler and I like it. My only concern is, if it's working for all 1.2 specs

@mohsen1 I used swagger-js converter as reference and also tested it on 300+ 1.2 specs.
I didn't tested it on 1.1 or 1.0 but according to swagger-js it should be only one special rule for 1.0.

Works for me then

@mohsen1 I made all required changes, can you take a look?

LGTM!

This is big change, so I think it need NPM release.
It's new API function, so it should be 1.1.0.
I don't have keys for NPM so it should you.
P.S. If you want you can setup this: https://docs.travis-ci.com/user/deployment/npm/


chore: redo typo PR by leopardracer

Thanks leopardracer for https://github.com/AztecProtocol/aztec-packages/pull/10443. Our policy is to redo typo changes to dissuade metric farming. This is an automated script.

Docs Preview
Hey there! 👋 You can check your preview at https://67524bd8d58c3c73b648cf0e--aztec-docs-dev.netlify.app


Update sbt-ghpages to 0.8.0

About this PR
📦 Updates com.typesafe.sbt:sbt-ghpages from 0.6.3 to 0.8.0
Usage
✅ Please merge!
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

⚙ Adjust future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "com.typesafe.sbt", artifactId = "sbt-ghpages" } ]

Or, add this to slow down future updates of this dependency:
dependencyOverrides = [{
  pullRequests = { frequency = "30 days" },
  dependency = { groupId = "com.typesafe.sbt", artifactId = "sbt-ghpages" }
}]

labels: sbt-plugin-update, early-semver-major, semver-spec-minor, artifact-migrations, commit-count:1

Updated manually


Assignment line not translated well when using double quotes

This v1 line
Clipboard := "Powershell -command ""Get-CimInstance -ClassName win32_operatingsystem | Select-Object CSName, LastBootUpTime | FT -Autosize"""
is translated to v2 line
A_Clipboard := "Powershell -command ""Get-CimInstance -ClassName win32_operatingsystem | Select-Object CSName, LastBootUpTime | FT -Autosize"""
Must be using escaped quote otherwise it gives an autohotkey error
A_Clipboard := "Powershell -command "Get-CimInstance -ClassName win32_operatingsystem | Select-Object CSName, LastBootUpTime | FT -Autosize""

working on this here

So currently,
I have this regex with matches only strings in an assignment
and this code which doesn't fully work
      else if RegexMatch(Line, "i)^([\s]*[a-z_][a-z_0-9]*[\s]*:=\s*)(.*)", &Equation) ; Line is a variable assignment, check for ""
      { ; Replace "" with `", see #111
         Line := Equation[1]
         pos := RegExMatch(Equation[2], "`"((?:`"`")?(?:[^`"]*(?:`"`")?[^`"]*?)*?(?:`"`")?)`"", &match) ; https://regex101.com/r/RMoJ06/2
         if pos != 0
            Line .= "`"" RegExReplace(match[1], "`"`"", "```"") "`""
      }

So it still doesn't add in variables or other strings if multiple


Implementing go-rtmfp in monibuca

Hi I was wondering if you could also create this plugin for monibuca: https://github.com/optman/go-rtmfp
Right now I have a project which is using rtmfp and I don't like the architecture of MonaServer and the code is really not easy to understand. I need that rtmfp protol to upgrade from MonaServer into something more powerful and fast such as monibuca.
Let me know
thanx

Besides flash, is there any client that can use rtmfp?

Besides flash, is there any client that can use rtmfp?

Yes you can use librtmfp with C++ and golang and any other languages like Java and Python.

Yes you can use librtmfp with C++ and golang and any other languages like Java and Python.

let me see. only first link is real rtmfp client. As Web Apps can't use UDP protocol,only Desktop Apps can play rtmfp streams. Can you tell me more about your project？

let me see. only first link is real rtmfp client. As Web Apps can't use UDP protocol,only Desktop Apps can play rtmfp streams. Can you tell me more about your project？

Well it is a bitcoin kind of platform built around the p2p capabilities of RTMFP. The core application is an application runtime container which loads all kind of subapplication in the main host dynamically. The core application has zero source code... the application load submodule.appunit and place everything the UI modularly and you can switch from one subapp to another by just switching the current perspective. You can also load backend code modularly without breaking the main application. You can load/unload each subapp and update it just the part which is update will be unloaded from the UI and then reloaded. Same applies for the backend code.
There are many submodules like Youtube, Vimeo, Tesseract, LawDictionnaries, VideoConference, etc...
But as I said all modules are in the blockchain and validated and loaded securely.

Well it is a bitcoin kind of platform built around the p2p capabilities of RTMFP. The core application is an application runtime container which loads all kind of subapplication in the main host dynamically. The core application has zero source code... the application load submodule.appunit and place everything the UI modularly and you can switch from one subapp to another by just switching the current perspective. You can also load backend code modularly without breaking the main application. You can load/unload each subapp and update it just the part which is update will be unloaded from the UI and then reloaded. Same applies for the backend code.
There are many submodules like Youtube, Vimeo, Tesseract, LawDictionnaries, VideoConference, etc...
But as I said all modules are in the blockchain and validated and loaded securely.

Sounds very powerful and interesting.  Is the whole system developed with go? Isn't rtmfp used to transmit video?

Sounds very powerful and interesting.  Is the whole system developed with go? Isn't rtmfp used to transmit video?

No the whole system is developed with Adobe AIR and C++ Native Extensions.

No the whole system is developed with Adobe AIR and C++ Native Extensions.

s very powerful and interesting. Is the whole system developed with go? Isn't rtmfp used to transmit video?

No the whole system is developed with Adobe AIR and C++ Native Extensions. What I am planning to do is to export the rtmfp part of monibuca as a C++ headers and *.obj files and then use this inside of a Native C++ extension which will be hooked to the Flash VM by Adobe AIR and I can call all the initialisation code from AS3 directly into C++.
Well RTMFP is more than Video we can send audio,data,video but what is amazing is that Adobe AIR has builtin SDK to create p2p collaborative apps and do video conferences between the peers in the network with NetGroups.

s very powerful and interesting. Is the whole system developed with go? Isn't rtmfp used to transmit video?

No the whole system is developed with Adobe AIR and C++ Native Extensions. What I am planning to do is to export the rtmfp part of monibuca as a C++ headers and *.obj files and then use this inside of a Native C++ extension which will be hooked to the Flash VM by Adobe AIR and I can call all the initialisation code from AS3 directly into C++.
Well RTMFP is more than Video we can send audio,data,video but what is amazing is that Adobe AIR has builtin SDK to create p2p collaborative apps and do video conferences between the peers in the network with NetGroups.

It seems that RTMFP could land on an open source Java library : pedroSG94/rtmp-rtsp-stream-client-java#223
There is also a commercial alternative but I won't pay for something which is now open to everybody : http://www.smaxe.com/product.jsf?id=juv-rtmfp-client

It seems that RTMFP could land on an open source Java library : pedroSG94/rtmp-rtsp-stream-client-java#223
There is also a commercial alternative but I won't pay for something which is now open to everybody : http://www.smaxe.com/product.jsf?id=juv-rtmfp-client

The truth is it is impossible to kill Flash and yes AIR is an .exe running natively on Windows, Mac, Android, iOS, etc...
Flash is getting metamorphosed into those solutions:
https://github.com/ruffle-rs/ruffle
https://medium.com/leaningtech/running-flash-in-webassembly-using-cheerpx-an-update-d500b6fbc44e
https://github.com/open-flash/avmore

The truth is it is impossible to kill Flash and yes AIR is an .exe running natively on Windows, Mac, Android, iOS, etc...
Flash is getting metamorphosed into those solutions:
https://github.com/ruffle-rs/ruffle
https://medium.com/leaningtech/running-flash-in-webassembly-using-cheerpx-an-update-d500b6fbc44e
https://github.com/open-flash/avmore

Thank you for sharing so much good information. go-rtmfp or xserver can run dependently without Monibuca. What's the need to put them together？

Thank you for sharing so much good information. go-rtmfp or xserver can run dependently without Monibuca. What's the need to put them together？

I would love to see rtmfp inside of monibuca because the source code is so clear and clean that I would also like to learn at the same time. Also since there's rtmp support having the rtmfp would make this project more complete in features. I am really curious how you will architect the code and make it fit inside of your code. Actually the code is already there but adapting it is what interests me the most.

I would love to see rtmfp inside of monibuca because the source code is so clear and clean that I would also like to learn at the same time. Also since there's rtmp support having the rtmfp would make this project more complete in features. I am really curious how you will architect the code and make it fit inside of your code. Actually the code is already there but adapting it is what interests me the most.

RTMFP protocol is different from other protocols since it just helps clients  transmit audio and video between them. Monibuca is a SFU（Selective Forwarding Unit） mode server so plugins just put the audio and video data into buffers. What can I do if I get a rtmfp connection?

RTMFP protocol is different from other protocols since it just helps clients  transmit audio and video between them. Monibuca is a SFU（Selective Forwarding Unit） mode server so plugins just put the audio and video data into buffers. What can I do if I get a rtmfp connection?

You can add p2p functions out of the box. There's an API which allows you to build powerful p2p server less applications + on top of rtmfp there's an integrated API to create your own protocol very easily.

You can add p2p functions out of the box. There's an API which allows you to build powerful p2p server less applications + on top of rtmfp there's an integrated API to create your own protocol very easily.

All the routing is Integrated you don't need to worry about it. You just need to listen to network events and react to them.

All the routing is Integrated you don't need to worry about it. You just need to listen to network events and react to them.

Look at all the Video Links I sent concerning RTMFP you will see the power.

Look at all the Video Links I sent concerning RTMFP you will see the power.

You can create Private NetGroups protected with passwords. There's so many features.

You can create Private NetGroups protected with passwords. There's so many features.

So many features can be implemented by standard alone server. What's the difference between putting it together with Monibuca?

So many features can be implemented by standard alone server. What's the difference between putting it together with Monibuca?

Actually all the things described previously are handled all by the protocol you can just use those features to extend monibuca so that it can be accessed by the client app to create real-time applications or game servers.

Actually all the things described previously are handled all by the protocol you can just use those features to extend monibuca so that it can be accessed by the client app to create real-time applications or game servers.

You're talking about the next stage of Monibuca. This is a bright future. However, every project needs some growth opportunities. In this way, there will be a series of clear requirements and financial support~

You're talking about the next stage of Monibuca. This is a bright future. However, every project needs some growth opportunities. In this way, there will be a series of clear requirements and financial support~


quickstack: init at unstable-2021-01-26

Description of changes
Draft, since I'm not sure I'll be using this enough to be able to maintain it, in hopes that anyone else who wants it can start from here and not from scratch.
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
22.11 Release Notes (or backporting 22.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

@lheckemann why is this closed? I'd address the review if needed

I don't intend to maintain it. If you'd like to, you're welcome to take it and submit a new PR with yourself as the maintainer :)


Help to install dcn

Hi,
Thanks for your clarifications earlier on the code. I am now trying to use the deformable convolution kernels with the VoxelNet version. But am having issues in installing it and importing it further. I installed it by:
cd CenterPoint/det3d/ops/dcn
python setup.py bdist_wheel
pip install dist/*.whl
It says its installing, but when trying to import e.g. from det3d.ops.dcn import DeformConv, ModulatedDeformConvPack, it fails with following error:
ImportError: cannot import name 'deform_conv_cuda'
I am not sure what I am missing here. Could you please share the setup steps for this?
Thanks !!
Anuj

Can you try
python setup.py build_ext --inplace
I haven't tried your way yet.

Wow, amazing, that works. Thank you very much for the quick response !! :+1:
I will close this issue in a while once everything is good :grinning:
Thanks again !!

close for now due to inactivity

yeah, you need to change the batch_size if using 2 GPU. I suggest you just compare with our 0.1 voxel size model (additionally with flipping). This model is faster, consumes less memory, and only marginally lower (64.9 vs. 65.5) than 0075_dcn

https://github.com/tianweiy/CenterPoint/blob/890e538afc95ee741f4c29b4c30b37251027e31c/configs/nusc/voxelnet/nusc_centerpoint_voxelnet_01voxel.py#L165
For 0.1 voxel size model, you can double this batch size and it should fit in a V100. For 0.075, you can use as large a batch size as it can fit into your gpu.

Can you try
python setup.py build_ext --inplace
I haven't tried your way yet.

Hi,
I met the same ImportError for 'cannot import name 'deform_conv_cuda''. However, I tried to follow the provided method to solve the problem. After running 'python setup.py build_ext --inplace', it returns the 'error: command 'x86_64-linux-gnu-gcc' failed with exit status 1'.  Do you have any ideas for what causing this error?
Thanks!

@ZhangYu1ing  is the problem solved?

@ZhangYu1ing is the problem solved?

Yes, I noticed that my torch version is 1.7.1, which could not be used to define AT_CHECK. After replacing all the AT_CHECK to TORCH_CHECK in both deform_conv_cuda.cpp and deform_pool_cuda.cpp files, then the setup.py could successfully build and create the deform_conv_cuda.cpython-37m-x86_64-linux-gnu.so file. Finally, the ImportError for 'cannot import name 'deform_conv_cuda'' does not exist anymore~

sounds good. I just finished ICCV submission and I am now working on a refactoring of the codebase. Hopefully, I can make the codebase easier to tune and tweak in one to two weeks.

Awesome! We are looking forward to the update~

running build_ext
building 'deform_conv_cuda' extension
Emitting ninja build file /home/leus/autoware/detection_3D/CenterPoint/det3d/ops/dcn/build/temp.linux-x86_64-3.8/build.ninja...
Compiling objects...
Allowing ninja to set a default number of workers... (overridable by setting the environment variable MAX_JOBS=N)
[1/1] c++ -MMD -MF /home/leus/autoware/detection_3D/CenterPoint/det3d/ops/dcn/build/temp.linux-x86_64-3.8/src/deform_conv_cuda.o.d -pthread -B /home/leus/.pyenv/versions/anaconda3-5.1.0/envs/py38/compiler_compat -Wl,--sysroot=/ -Wsign-compare -DNDEBUG -g -fwrapv -O3 -Wall -Wstrict-prototypes -fPIC -DWITH_CUDA -I/home/leus/.pyenv/versions/anaconda3-5.1.0/envs/py38/lib/python3.8/site-packages/torch/include -I/home/leus/.pyenv/versions/anaconda3-5.1.0/envs/py38/lib/python3.8/site-packages/torch/include/torch/csrc/api/include -I/home/leus/.pyenv/versions/anaconda3-5.1.0/envs/py38/lib/python3.8/site-packages/torch/include/TH -I/home/leus/.pyenv/versions/anaconda3-5.1.0/envs/py38/lib/python3.8/site-packages/torch/include/THC -I/usr/local/cuda-10.2/include -I/home/leus/.pyenv/versions/anaconda3-5.1.0/envs/py38/include/python3.8 -c -c /home/leus/autoware/detection_3D/CenterPoint/det3d/ops/dcn/src/deform_conv_cuda.cpp -o /home/leus/autoware/detection_3D/CenterPoint/det3d/ops/dcn/build/temp.linux-x86_64-3.8/src/deform_conv_cuda.o -DTORCH_API_INCLUDE_EXTENSION_H '-DPYBIND11_COMPILER_TYPE="_gcc"' '-DPYBIND11_STDLIB="_libstdcpp"' '-DPYBIND11_BUILD_ABI="_cxxabi1011"' -DTORCH_EXTENSION_NAME=deform_conv_cuda -D_GLIBCXX_USE_CXX11_ABI=0 -std=c++14
FAILED: /home/leus/autoware/detection_3D/CenterPoint/det3d/ops/dcn/build/temp.linux-x86_64-3.8/src/deform_conv_cuda.o
c++ -MMD -MF /home/leus/autoware/detection_3D/CenterPoint/det3d/ops/dcn/build/temp.linux-x86_64-3.8/src/deform_conv_cuda.o.d -pthread -B /home/leus/.pyenv/versions/anaconda3-5.1.0/envs/py38/compiler_compat -Wl,--sysroot=/ -Wsign-compare -DNDEBUG -g -fwrapv -O3 -Wall -Wstrict-prototypes -fPIC -DWITH_CUDA -I/home/leus/.pyenv/versions/anaconda3-5.1.0/envs/py38/lib/python3.8/site-packages/torch/include -I/home/leus/.pyenv/versions/anaconda3-5.1.0/envs/py38/lib/python3.8/site-packages/torch/include/torch/csrc/api/include -I/home/leus/.pyenv/versions/anaconda3-5.1.0/envs/py38/lib/python3.8/site-packages/torch/include/TH -I/home/leus/.pyenv/versions/anaconda3-5.1.0/envs/py38/lib/python3.8/site-packages/torch/include/THC -I/usr/local/cuda-10.2/include -I/home/leus/.pyenv/versions/anaconda3-5.1.0/envs/py38/include/python3.8 -c -c /home/leus/autoware/detection_3D/CenterPoint/det3d/ops/dcn/src/deform_conv_cuda.cpp -o /home/leus/autoware/detection_3D/CenterPoint/det3d/ops/dcn/build/temp.linux-x86_64-3.8/src/deform_conv_cuda.o -DTORCH_API_INCLUDE_EXTENSION_H '-DPYBIND11_COMPILER_TYPE="_gcc"' '-DPYBIND11_STDLIB="_libstdcpp"' '-DPYBIND11_BUILD_ABI="_cxxabi1011"' -DTORCH_EXTENSION_NAME=deform_conv_cuda -D_GLIBCXX_USE_CXX11_ABI=0 -std=c++14
cc1plus: warning: command line option ‘-Wstrict-prototypes’ is valid for C/ObjC but not for C++
In file included from /home/leus/.pyenv/versions/anaconda3-5.1.0/envs/py38/lib/python3.8/site-packages/torch/include/ATen/Parallel.h:149:0,
                 from /home/leus/.pyenv/versions/anaconda3-5.1.0/envs/py38/lib/python3.8/site-packages/torch/include/torch/csrc/api/include/torch/utils.h:3,
                 from /home/leus/.pyenv/versions/anaconda3-5.1.0/envs/py38/lib/python3.8/site-packages/torch/include/torch/csrc/api/include/torch/nn/cloneable.h:5,
                 from /home/leus/.pyenv/versions/anaconda3-5.1.0/envs/py38/lib/python3.8/site-packages/torch/include/torch/csrc/api/include/torch/nn.h:3,
                 from /home/leus/.pyenv/versions/anaconda3-5.1.0/envs/py38/lib/python3.8/site-packages/torch/include/torch/csrc/api/include/torch/all.h:12,
                 from /home/leus/.pyenv/versions/anaconda3-5.1.0/envs/py38/lib/python3.8/site-packages/torch/include/torch/extension.h:4,
                 from /home/leus/autoware/detection_3D/CenterPoint/det3d/ops/dcn/src/deform_conv_cuda.cpp:4:
/home/leus/.pyenv/versions/anaconda3-5.1.0/envs/py38/lib/python3.8/site-packages/torch/include/ATen/ParallelOpenMP.h:84:0: warning: ignoring #pragma omp parallel [-Wunknown-pragmas]
 #pragma omp parallel for if ((end - begin) >= grain_size)

/home/leus/autoware/detection_3D/CenterPoint/det3d/ops/dcn/src/deform_conv_cuda.cpp: In function ‘void shape_check(at::Tensor, at::Tensor, at::Tensor*, at::Tensor, int, int, int, int, int, int, int, int, int, int)’:
/home/leus/autoware/detection_3D/CenterPoint/det3d/ops/dcn/src/deform_conv_cuda.cpp:66:3: error: ‘AT_CHECK’ was not declared in this scope
   AT_CHECK(weight.ndimension() == 4,
   ^~~~~~~~
/home/leus/autoware/detection_3D/CenterPoint/det3d/ops/dcn/src/deform_conv_cuda.cpp:66:3: note: suggested alternative: ‘DCHECK’
   AT_CHECK(weight.ndimension() == 4,
   ^~~~~~~~
   DCHECK
/home/leus/autoware/detection_3D/CenterPoint/det3d/ops/dcn/src/deform_conv_cuda.cpp: In function ‘int deform_conv_forward_cuda(at::Tensor, at::Tensor, at::Tensor, at::Tensor, at::Tensor, at::Tensor, int, int, int, int, int, int, int, int, int, int, int)’:
/home/leus/autoware/detection_3D/CenterPoint/det3d/ops/dcn/src/deform_conv_cuda.cpp:194:3: error: ‘AT_CHECK’ was not declared in this scope
   AT_CHECK((offset.size(0) == batchSize), "invalid batch size of offset");
   ^~~~~~~~
/home/leus/autoware/detection_3D/CenterPoint/det3d/ops/dcn/src/deform_conv_cuda.cpp:194:3: note: suggested alternative: ‘DCHECK’
   AT_CHECK((offset.size(0) == batchSize), "invalid batch size of offset");
   ^~~~~~~~
   DCHECK
/home/leus/autoware/detection_3D/CenterPoint/det3d/ops/dcn/src/deform_conv_cuda.cpp: In function ‘int deform_conv_backward_input_cuda(at::Tensor, at::Tensor, at::Tensor, at::Tensor, at::Tensor, at::Tensor, at::Tensor, int, int, int, int, int, int, int, int, int, int, int)’:
/home/leus/autoware/detection_3D/CenterPoint/det3d/ops/dcn/src/deform_conv_cuda.cpp:301:3: error: ‘AT_CHECK’ was not declared in this scope
   AT_CHECK((offset.size(0) == batchSize), 3, "invalid batch size of offset");
   ^~~~~~~~
/home/leus/autoware/detection_3D/CenterPoint/det3d/ops/dcn/src/deform_conv_cuda.cpp:301:3: note: suggested alternative: ‘DCHECK’
   AT_CHECK((offset.size(0) == batchSize), 3, "invalid batch size of offset");
   ^~~~~~~~
   DCHECK
/home/leus/autoware/detection_3D/CenterPoint/det3d/ops/dcn/src/deform_conv_cuda.cpp: In function ‘int deform_conv_backward_parameters_cuda(at::Tensor, at::Tensor, at::Tensor, at::Tensor, at::Tensor, at::Tensor, int, int, int, int, int, int, int, int, int, int, float, int)’:
/home/leus/autoware/detection_3D/CenterPoint/det3d/ops/dcn/src/deform_conv_cuda.cpp:417:3: error: ‘AT_CHECK’ was not declared in this scope
   AT_CHECK((offset.size(0) == batchSize), "invalid batch size of offset");
   ^~~~~~~~
/home/leus/autoware/detection_3D/CenterPoint/det3d/ops/dcn/src/deform_conv_cuda.cpp:417:3: note: suggested alternative: ‘DCHECK’
   AT_CHECK((offset.size(0) == batchSize), "invalid batch size of offset");
   ^~~~~~~~
   DCHECK
/home/leus/autoware/detection_3D/CenterPoint/det3d/ops/dcn/src/deform_conv_cuda.cpp: In function ‘void modulated_deform_conv_cuda_forward(at::Tensor, at::Tensor, at::Tensor, at::Tensor, at::Tensor, at::Tensor, at::Tensor, at::Tensor, int, int, int, int, int, int, int, int, int, int, bool)’:
/home/leus/autoware/detection_3D/CenterPoint/det3d/ops/dcn/src/deform_conv_cuda.cpp:497:3: error: ‘AT_CHECK’ was not declared in this scope
   AT_CHECK(input.is_contiguous(), "input tensor has to be contiguous");
   ^~~~~~~~
/home/leus/autoware/detection_3D/CenterPoint/det3d/ops/dcn/src/deform_conv_cuda.cpp:497:3: note: suggested alternative: ‘DCHECK’
   AT_CHECK(input.is_contiguous(), "input tensor has to be contiguous");
   ^~~~~~~~
   DCHECK
/home/leus/autoware/detection_3D/CenterPoint/det3d/ops/dcn/src/deform_conv_cuda.cpp: In function ‘void modulated_deform_conv_cuda_backward(at::Tensor, at::Tensor, at::Tensor, at::Tensor, at::Tensor, at::Tensor, at::Tensor, at::Tensor, at::Tensor, at::Tensor, at::Tensor, at::Tensor, at::Tensor, int, int, int, int, int, int, int, int, int, int, bool)’:
/home/leus/autoware/detection_3D/CenterPoint/det3d/ops/dcn/src/deform_conv_cuda.cpp:579:3: error: ‘AT_CHECK’ was not declared in this scope
   AT_CHECK(input.is_contiguous(), "input tensor has to be contiguous");
   ^~~~~~~~
/home/leus/autoware/detection_3D/CenterPoint/det3d/ops/dcn/src/deform_conv_cuda.cpp:579:3: note: suggested alternative: ‘DCHECK’
   AT_CHECK(input.is_contiguous(), "input tensor has to be contiguous");
   ^~~~~~~~
   DCHECK
ninja: build stopped: subcommand failed.
Traceback (most recent call last):
  File "/home/leus/.pyenv/versions/anaconda3-5.1.0/envs/py38/lib/python3.8/site-packages/torch/utils/cpp_extension.py", line 1533, in _run_ninja_build
    subprocess.run(
  File "/home/leus/.pyenv/versions/anaconda3-5.1.0/envs/py38/lib/python3.8/subprocess.py", line 516, in run
    raise CalledProcessError(retcode, process.args,
subprocess.CalledProcessError: Command '['ninja', '-v']' returned non-zero exit status 1.

The above exception was the direct cause of the following exception:

Traceback (most recent call last):
  File "setup.py", line 4, in <module>
    setup(
  File "/home/leus/.pyenv/versions/anaconda3-5.1.0/envs/py38/lib/python3.8/site-packages/setuptools/__init__.py", line 153, in setup
    return distutils.core.setup(**attrs)
  File "/home/leus/.pyenv/versions/anaconda3-5.1.0/envs/py38/lib/python3.8/distutils/core.py", line 148, in setup
    dist.run_commands()
  File "/home/leus/.pyenv/versions/anaconda3-5.1.0/envs/py38/lib/python3.8/distutils/dist.py", line 966, in run_commands
    self.run_command(cmd)
  File "/home/leus/.pyenv/versions/anaconda3-5.1.0/envs/py38/lib/python3.8/distutils/dist.py", line 985, in run_command
    cmd_obj.run()
  File "/home/leus/.pyenv/versions/anaconda3-5.1.0/envs/py38/lib/python3.8/site-packages/setuptools/command/build_ext.py", line 79, in run
    _build_ext.run(self)
  File "/home/leus/.pyenv/versions/anaconda3-5.1.0/envs/py38/lib/python3.8/site-packages/Cython/Distutils/old_build_ext.py", line 186, in run
    _build_ext.build_ext.run(self)
  File "/home/leus/.pyenv/versions/anaconda3-5.1.0/envs/py38/lib/python3.8/distutils/command/build_ext.py", line 340, in run
    self.build_extensions()
  File "/home/leus/.pyenv/versions/anaconda3-5.1.0/envs/py38/lib/python3.8/site-packages/torch/utils/cpp_extension.py", line 670, in build_extensions
    build_ext.build_extensions(self)
  File "/home/leus/.pyenv/versions/anaconda3-5.1.0/envs/py38/lib/python3.8/site-packages/Cython/Distutils/old_build_ext.py", line 195, in build_extensions
    _build_ext.build_ext.build_extensions(self)
  File "/home/leus/.pyenv/versions/anaconda3-5.1.0/envs/py38/lib/python3.8/distutils/command/build_ext.py", line 449, in build_extensions
    self._build_extensions_serial()
  File "/home/leus/.pyenv/versions/anaconda3-5.1.0/envs/py38/lib/python3.8/distutils/command/build_ext.py", line 474, in _build_extensions_serial
    self.build_extension(ext)
  File "/home/leus/.pyenv/versions/anaconda3-5.1.0/envs/py38/lib/python3.8/site-packages/setuptools/command/build_ext.py", line 196, in build_extension
    _build_ext.build_extension(self, ext)
  File "/home/leus/.pyenv/versions/anaconda3-5.1.0/envs/py38/lib/python3.8/distutils/command/build_ext.py", line 528, in build_extension
    objects = self.compiler.compile(sources,
  File "/home/leus/.pyenv/versions/anaconda3-5.1.0/envs/py38/lib/python3.8/site-packages/torch/utils/cpp_extension.py", line 491, in unix_wrap_ninja_compile
    _write_ninja_file_and_compile_objects(
  File "/home/leus/.pyenv/versions/anaconda3-5.1.0/envs/py38/lib/python3.8/site-packages/torch/utils/cpp_extension.py", line 1250, in _write_ninja_file_and_compile_objects
    _run_ninja_build(
  File "/home/leus/.pyenv/versions/anaconda3-5.1.0/envs/py38/lib/python3.8/site-packages/torch/utils/cpp_extension.py", line 1555, in _run_ninja_build
    raise RuntimeError(message) from e
RuntimeError: Error compiling objects for extension

hi, I got this error when I run bash ./setup.sh
can anyone help?

running build_ext
building 'deform_conv_cuda' extension
Emitting ninja build file /home/leus/autoware/detection_3D/CenterPoint/det3d/ops/dcn/build/temp.linux-x86_64-3.8/build.ninja...
Compiling objects...
Allowing ninja to set a default number of workers... (overridable by setting the environment variable MAX_JOBS=N)
[1/1] c++ -MMD -MF /home/leus/autoware/detection_3D/CenterPoint/det3d/ops/dcn/build/temp.linux-x86_64-3.8/src/deform_conv_cuda.o.d -pthread -B /home/leus/.pyenv/versions/anaconda3-5.1.0/envs/py38/compiler_compat -Wl,--sysroot=/ -Wsign-compare -DNDEBUG -g -fwrapv -O3 -Wall -Wstrict-prototypes -fPIC -DWITH_CUDA -I/home/leus/.pyenv/versions/anaconda3-5.1.0/envs/py38/lib/python3.8/site-packages/torch/include -I/home/leus/.pyenv/versions/anaconda3-5.1.0/envs/py38/lib/python3.8/site-packages/torch/include/torch/csrc/api/include -I/home/leus/.pyenv/versions/anaconda3-5.1.0/envs/py38/lib/python3.8/site-packages/torch/include/TH -I/home/leus/.pyenv/versions/anaconda3-5.1.0/envs/py38/lib/python3.8/site-packages/torch/include/THC -I/usr/local/cuda-10.2/include -I/home/leus/.pyenv/versions/anaconda3-5.1.0/envs/py38/include/python3.8 -c -c /home/leus/autoware/detection_3D/CenterPoint/det3d/ops/dcn/src/deform_conv_cuda.cpp -o /home/leus/autoware/detection_3D/CenterPoint/det3d/ops/dcn/build/temp.linux-x86_64-3.8/src/deform_conv_cuda.o -DTORCH_API_INCLUDE_EXTENSION_H '-DPYBIND11_COMPILER_TYPE="_gcc"' '-DPYBIND11_STDLIB="_libstdcpp"' '-DPYBIND11_BUILD_ABI="_cxxabi1011"' -DTORCH_EXTENSION_NAME=deform_conv_cuda -D_GLIBCXX_USE_CXX11_ABI=0 -std=c++14
FAILED: /home/leus/autoware/detection_3D/CenterPoint/det3d/ops/dcn/build/temp.linux-x86_64-3.8/src/deform_conv_cuda.o
c++ -MMD -MF /home/leus/autoware/detection_3D/CenterPoint/det3d/ops/dcn/build/temp.linux-x86_64-3.8/src/deform_conv_cuda.o.d -pthread -B /home/leus/.pyenv/versions/anaconda3-5.1.0/envs/py38/compiler_compat -Wl,--sysroot=/ -Wsign-compare -DNDEBUG -g -fwrapv -O3 -Wall -Wstrict-prototypes -fPIC -DWITH_CUDA -I/home/leus/.pyenv/versions/anaconda3-5.1.0/envs/py38/lib/python3.8/site-packages/torch/include -I/home/leus/.pyenv/versions/anaconda3-5.1.0/envs/py38/lib/python3.8/site-packages/torch/include/torch/csrc/api/include -I/home/leus/.pyenv/versions/anaconda3-5.1.0/envs/py38/lib/python3.8/site-packages/torch/include/TH -I/home/leus/.pyenv/versions/anaconda3-5.1.0/envs/py38/lib/python3.8/site-packages/torch/include/THC -I/usr/local/cuda-10.2/include -I/home/leus/.pyenv/versions/anaconda3-5.1.0/envs/py38/include/python3.8 -c -c /home/leus/autoware/detection_3D/CenterPoint/det3d/ops/dcn/src/deform_conv_cuda.cpp -o /home/leus/autoware/detection_3D/CenterPoint/det3d/ops/dcn/build/temp.linux-x86_64-3.8/src/deform_conv_cuda.o -DTORCH_API_INCLUDE_EXTENSION_H '-DPYBIND11_COMPILER_TYPE="_gcc"' '-DPYBIND11_STDLIB="_libstdcpp"' '-DPYBIND11_BUILD_ABI="_cxxabi1011"' -DTORCH_EXTENSION_NAME=deform_conv_cuda -D_GLIBCXX_USE_CXX11_ABI=0 -std=c++14
cc1plus: warning: command line option ‘-Wstrict-prototypes’ is valid for C/ObjC but not for C++
In file included from /home/leus/.pyenv/versions/anaconda3-5.1.0/envs/py38/lib/python3.8/site-packages/torch/include/ATen/Parallel.h:149:0,
                 from /home/leus/.pyenv/versions/anaconda3-5.1.0/envs/py38/lib/python3.8/site-packages/torch/include/torch/csrc/api/include/torch/utils.h:3,
                 from /home/leus/.pyenv/versions/anaconda3-5.1.0/envs/py38/lib/python3.8/site-packages/torch/include/torch/csrc/api/include/torch/nn/cloneable.h:5,
                 from /home/leus/.pyenv/versions/anaconda3-5.1.0/envs/py38/lib/python3.8/site-packages/torch/include/torch/csrc/api/include/torch/nn.h:3,
                 from /home/leus/.pyenv/versions/anaconda3-5.1.0/envs/py38/lib/python3.8/site-packages/torch/include/torch/csrc/api/include/torch/all.h:12,
                 from /home/leus/.pyenv/versions/anaconda3-5.1.0/envs/py38/lib/python3.8/site-packages/torch/include/torch/extension.h:4,
                 from /home/leus/autoware/detection_3D/CenterPoint/det3d/ops/dcn/src/deform_conv_cuda.cpp:4:
/home/leus/.pyenv/versions/anaconda3-5.1.0/envs/py38/lib/python3.8/site-packages/torch/include/ATen/ParallelOpenMP.h:84:0: warning: ignoring #pragma omp parallel [-Wunknown-pragmas]
 #pragma omp parallel for if ((end - begin) >= grain_size)

/home/leus/autoware/detection_3D/CenterPoint/det3d/ops/dcn/src/deform_conv_cuda.cpp: In function ‘void shape_check(at::Tensor, at::Tensor, at::Tensor*, at::Tensor, int, int, int, int, int, int, int, int, int, int)’:
/home/leus/autoware/detection_3D/CenterPoint/det3d/ops/dcn/src/deform_conv_cuda.cpp:66:3: error: ‘AT_CHECK’ was not declared in this scope
   AT_CHECK(weight.ndimension() == 4,
   ^~~~~~~~
/home/leus/autoware/detection_3D/CenterPoint/det3d/ops/dcn/src/deform_conv_cuda.cpp:66:3: note: suggested alternative: ‘DCHECK’
   AT_CHECK(weight.ndimension() == 4,
   ^~~~~~~~
   DCHECK
/home/leus/autoware/detection_3D/CenterPoint/det3d/ops/dcn/src/deform_conv_cuda.cpp: In function ‘int deform_conv_forward_cuda(at::Tensor, at::Tensor, at::Tensor, at::Tensor, at::Tensor, at::Tensor, int, int, int, int, int, int, int, int, int, int, int)’:
/home/leus/autoware/detection_3D/CenterPoint/det3d/ops/dcn/src/deform_conv_cuda.cpp:194:3: error: ‘AT_CHECK’ was not declared in this scope
   AT_CHECK((offset.size(0) == batchSize), "invalid batch size of offset");
   ^~~~~~~~
/home/leus/autoware/detection_3D/CenterPoint/det3d/ops/dcn/src/deform_conv_cuda.cpp:194:3: note: suggested alternative: ‘DCHECK’
   AT_CHECK((offset.size(0) == batchSize), "invalid batch size of offset");
   ^~~~~~~~
   DCHECK
/home/leus/autoware/detection_3D/CenterPoint/det3d/ops/dcn/src/deform_conv_cuda.cpp: In function ‘int deform_conv_backward_input_cuda(at::Tensor, at::Tensor, at::Tensor, at::Tensor, at::Tensor, at::Tensor, at::Tensor, int, int, int, int, int, int, int, int, int, int, int)’:
/home/leus/autoware/detection_3D/CenterPoint/det3d/ops/dcn/src/deform_conv_cuda.cpp:301:3: error: ‘AT_CHECK’ was not declared in this scope
   AT_CHECK((offset.size(0) == batchSize), 3, "invalid batch size of offset");
   ^~~~~~~~
/home/leus/autoware/detection_3D/CenterPoint/det3d/ops/dcn/src/deform_conv_cuda.cpp:301:3: note: suggested alternative: ‘DCHECK’
   AT_CHECK((offset.size(0) == batchSize), 3, "invalid batch size of offset");
   ^~~~~~~~
   DCHECK
/home/leus/autoware/detection_3D/CenterPoint/det3d/ops/dcn/src/deform_conv_cuda.cpp: In function ‘int deform_conv_backward_parameters_cuda(at::Tensor, at::Tensor, at::Tensor, at::Tensor, at::Tensor, at::Tensor, int, int, int, int, int, int, int, int, int, int, float, int)’:
/home/leus/autoware/detection_3D/CenterPoint/det3d/ops/dcn/src/deform_conv_cuda.cpp:417:3: error: ‘AT_CHECK’ was not declared in this scope
   AT_CHECK((offset.size(0) == batchSize), "invalid batch size of offset");
   ^~~~~~~~
/home/leus/autoware/detection_3D/CenterPoint/det3d/ops/dcn/src/deform_conv_cuda.cpp:417:3: note: suggested alternative: ‘DCHECK’
   AT_CHECK((offset.size(0) == batchSize), "invalid batch size of offset");
   ^~~~~~~~
   DCHECK
/home/leus/autoware/detection_3D/CenterPoint/det3d/ops/dcn/src/deform_conv_cuda.cpp: In function ‘void modulated_deform_conv_cuda_forward(at::Tensor, at::Tensor, at::Tensor, at::Tensor, at::Tensor, at::Tensor, at::Tensor, at::Tensor, int, int, int, int, int, int, int, int, int, int, bool)’:
/home/leus/autoware/detection_3D/CenterPoint/det3d/ops/dcn/src/deform_conv_cuda.cpp:497:3: error: ‘AT_CHECK’ was not declared in this scope
   AT_CHECK(input.is_contiguous(), "input tensor has to be contiguous");
   ^~~~~~~~
/home/leus/autoware/detection_3D/CenterPoint/det3d/ops/dcn/src/deform_conv_cuda.cpp:497:3: note: suggested alternative: ‘DCHECK’
   AT_CHECK(input.is_contiguous(), "input tensor has to be contiguous");
   ^~~~~~~~
   DCHECK
/home/leus/autoware/detection_3D/CenterPoint/det3d/ops/dcn/src/deform_conv_cuda.cpp: In function ‘void modulated_deform_conv_cuda_backward(at::Tensor, at::Tensor, at::Tensor, at::Tensor, at::Tensor, at::Tensor, at::Tensor, at::Tensor, at::Tensor, at::Tensor, at::Tensor, at::Tensor, at::Tensor, int, int, int, int, int, int, int, int, int, int, bool)’:
/home/leus/autoware/detection_3D/CenterPoint/det3d/ops/dcn/src/deform_conv_cuda.cpp:579:3: error: ‘AT_CHECK’ was not declared in this scope
   AT_CHECK(input.is_contiguous(), "input tensor has to be contiguous");
   ^~~~~~~~
/home/leus/autoware/detection_3D/CenterPoint/det3d/ops/dcn/src/deform_conv_cuda.cpp:579:3: note: suggested alternative: ‘DCHECK’
   AT_CHECK(input.is_contiguous(), "input tensor has to be contiguous");
   ^~~~~~~~
   DCHECK
ninja: build stopped: subcommand failed.
Traceback (most recent call last):
  File "/home/leus/.pyenv/versions/anaconda3-5.1.0/envs/py38/lib/python3.8/site-packages/torch/utils/cpp_extension.py", line 1533, in _run_ninja_build
    subprocess.run(
  File "/home/leus/.pyenv/versions/anaconda3-5.1.0/envs/py38/lib/python3.8/subprocess.py", line 516, in run
    raise CalledProcessError(retcode, process.args,
subprocess.CalledProcessError: Command '['ninja', '-v']' returned non-zero exit status 1.

The above exception was the direct cause of the following exception:

Traceback (most recent call last):
  File "setup.py", line 4, in <module>
    setup(
  File "/home/leus/.pyenv/versions/anaconda3-5.1.0/envs/py38/lib/python3.8/site-packages/setuptools/__init__.py", line 153, in setup
    return distutils.core.setup(**attrs)
  File "/home/leus/.pyenv/versions/anaconda3-5.1.0/envs/py38/lib/python3.8/distutils/core.py", line 148, in setup
    dist.run_commands()
  File "/home/leus/.pyenv/versions/anaconda3-5.1.0/envs/py38/lib/python3.8/distutils/dist.py", line 966, in run_commands
    self.run_command(cmd)
  File "/home/leus/.pyenv/versions/anaconda3-5.1.0/envs/py38/lib/python3.8/distutils/dist.py", line 985, in run_command
    cmd_obj.run()
  File "/home/leus/.pyenv/versions/anaconda3-5.1.0/envs/py38/lib/python3.8/site-packages/setuptools/command/build_ext.py", line 79, in run
    _build_ext.run(self)
  File "/home/leus/.pyenv/versions/anaconda3-5.1.0/envs/py38/lib/python3.8/site-packages/Cython/Distutils/old_build_ext.py", line 186, in run
    _build_ext.build_ext.run(self)
  File "/home/leus/.pyenv/versions/anaconda3-5.1.0/envs/py38/lib/python3.8/distutils/command/build_ext.py", line 340, in run
    self.build_extensions()
  File "/home/leus/.pyenv/versions/anaconda3-5.1.0/envs/py38/lib/python3.8/site-packages/torch/utils/cpp_extension.py", line 670, in build_extensions
    build_ext.build_extensions(self)
  File "/home/leus/.pyenv/versions/anaconda3-5.1.0/envs/py38/lib/python3.8/site-packages/Cython/Distutils/old_build_ext.py", line 195, in build_extensions
    _build_ext.build_ext.build_extensions(self)
  File "/home/leus/.pyenv/versions/anaconda3-5.1.0/envs/py38/lib/python3.8/distutils/command/build_ext.py", line 449, in build_extensions
    self._build_extensions_serial()
  File "/home/leus/.pyenv/versions/anaconda3-5.1.0/envs/py38/lib/python3.8/distutils/command/build_ext.py", line 474, in _build_extensions_serial
    self.build_extension(ext)
  File "/home/leus/.pyenv/versions/anaconda3-5.1.0/envs/py38/lib/python3.8/site-packages/setuptools/command/build_ext.py", line 196, in build_extension
    _build_ext.build_extension(self, ext)
  File "/home/leus/.pyenv/versions/anaconda3-5.1.0/envs/py38/lib/python3.8/distutils/command/build_ext.py", line 528, in build_extension
    objects = self.compiler.compile(sources,
  File "/home/leus/.pyenv/versions/anaconda3-5.1.0/envs/py38/lib/python3.8/site-packages/torch/utils/cpp_extension.py", line 491, in unix_wrap_ninja_compile
    _write_ninja_file_and_compile_objects(
  File "/home/leus/.pyenv/versions/anaconda3-5.1.0/envs/py38/lib/python3.8/site-packages/torch/utils/cpp_extension.py", line 1250, in _write_ninja_file_and_compile_objects
    _run_ninja_build(
  File "/home/leus/.pyenv/versions/anaconda3-5.1.0/envs/py38/lib/python3.8/site-packages/torch/utils/cpp_extension.py", line 1555, in _run_ninja_build
    raise RuntimeError(message) from e
RuntimeError: Error compiling objects for extension

hi, I got this error when I run bash ./setup.sh
can anyone help?

maybe you have the latest version of torch. Please try to replace all the "AT_CHECK" to "TORCH _CHECK " in both deform_conv_cuda.cpp and deform_pool_cuda.cpp files

@ZhangYu1ing Thanks for your replying!! also I need to replace TORCH_ERROR to TORCH_WARN and fix it!!


Solved exceeded the number of permissible registered listeners

I was able to reproduce the issue with Samsung Galaxy A51 (Android 11) with forced to use 2G network only in our project. We use getCells() from various threads with 1s refresh rate and it seems that it has problem to unregister listener properly in some cases. When I added that line, then app continue and problem does not occur anymore for now. But I am not 100% sure if it is correct solution.

Hi @xcadrik, can you please provide more information how you reproduce that crash on your side? An code example where you call NetMonster Core with threading would be helpful.
I managed to get Samsung A40 with Android 11 but can't reproduce it even when I call getCells() every 500 ms.

Hi,
You can look at this code, it is open source, but switch netmonster-core to your master branch:
https://github.com/rtr-nettest/open-rmbt-android/tree/feature/all_cell_info_dialog
I think you just need to allow permissions and turn on location, manually restrict network to use only 2G, basically app crashes after few seconds when it is restricted to use 2G networks on exceeded number of listeners.
If not, then maybe when you go to settings and turn on expert mode -> go back to home screen-> tap on the frequency/signal -> dialog should appear with cells details could help.
Thank you for any advice.
Bc. Michal Cádrik
Softvérové oddelenie
http://www.martes-specure.com/
MARTES, s.r.o.
Dlhá 88, 010 09
Žilina, Slovakia
IČO  31625410, OROS Žilina, vl.č. 2518/L
T:  tel:+421415628931 +421 41 562 89 39
M:  tel:+421948875933 +421 948 033 555
@.> @.
http://www.martes-specure.com/ www.martes-specure.com
From: Michal Mroček @.>
Sent: Monday, August 2, 2021 21:36
To: mroczis/netmonster-core @.>
Cc: Michal Cádrik @.>; Mention @.>
Subject: Re: [mroczis/netmonster-core] Solved exceeded the number of permissible registered listeners (#23)
Hi @xcadrik https://github.com/xcadrik , can you please provide more information how you reproduce that crash on your side? An code example where you call NetMonster Core with threading would be helpful.
I managed to get Samsung A40 with Android 11 but can't reproduce it even when I call getCells() every 500 ms.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub https://github.com/mroczis/netmonster-core/pull/23#issuecomment-891280200 , or unsubscribe https://github.com/notifications/unsubscribe-auth/AII2LMN3LFODAXKPYQRFSBDT23XQJANCNFSM5BD6E3KQ .
Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675  or Android https://play.google.com/store/apps/details?id=com.github.android&utm_campaign=notification-email .

Hey, thanks for the sample. As far as I can see you are querying the lib from multiple places and threads. Especially getCells() is invoked at the nearly same time (a few ms diff) from different threads (saveCellInfo, updateInfo). But the main issue is how you use getNetworkType() which is invoked every 100 ms. This eventually floods internal queue of the lib and getCells() response time will be 3 000 ms+ instead of usual 300 ms (on that Samsung A40).
The only proper way how to fix it is to synchronise access from all threads to that critical section where it eventually crashes. It works but processing time increases. And in a few seconds response time is around 6 000 ms.
I'll keep looking for solutions but some code optimisation from your side would be also good!

Thank you a lot!
Yes, I was looking at that problem of accessing it at multiple places. I plan to do some optimization, but I had no time/not planned yet – (more critical stuff in other project), but sure I will take a look as soon as I can.
BTW it is a good library. I wanted to achieve something similar by myself, but I have no access to so many devices (a lot of differences in api implementation/behavior for different models) and I have no such networking knowledge (I do not understand to all those numbers we can get from cell info)
Big thank you for that.
Bc. Michal Cádrik
Softvérové oddelenie
http://www.martes-specure.com/
MARTES, s.r.o.
Dlhá 88, 010 09
Žilina, Slovakia
IČO  31625410, OROS Žilina, vl.č. 2518/L
T:  tel:+421415628931 +421 41 562 89 39
M:  tel:+421948875933 +421 948 033 555
@.> @.
http://www.martes-specure.com/ www.martes-specure.com
From: Michal Mroček @.>
Sent: Tuesday, August 3, 2021 09:47
To: mroczis/netmonster-core @.>
Cc: Michal Cádrik @.>; Mention @.>
Subject: Re: [mroczis/netmonster-core] Solved exceeded the number of permissible registered listeners (#23)
Hey, thanks for the sample. As far as I can see you are querying the lib from multiple places and threads. Especially getCells() is invoked at the nearly same time (a few ms diff) from different threads (saveCellInfo, updateInfo). But the main issue is how you use getNetworkType() which is invoked every 100 ms. This eventually floods internal queue of the lib and getCells() response time will be 3 000 ms+ instead of usual 300 ms (on that Samsung A40).
The only proper way how to fix it is to synchronise access from all threads to that critical section where it eventually crashes. It works but processing time increases. And in a few seconds response time is around 6 000 ms.
I'll keep looking for solutions but some code optimisation from your side would be also good!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub https://github.com/mroczis/netmonster-core/pull/23#issuecomment-891618184 , or unsubscribe https://github.com/notifications/unsubscribe-auth/AII2LMN4HEIZNLUHFKECRQTT26NIVANCNFSM5BD6E3KQ .
Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675  or Android https://play.google.com/store/apps/details?id=com.github.android&utm_campaign=notification-email .

Should be fixed by caching (2ed098a6); tested on your app and avg. response time on Samsung A40 was ~300ms whilst on 2G/EDGE, tested for 10 minutes. Your app seemed to work a bit better  👍.

Sorry for the late reply my accounts have been hacked,I went on github to
see if I could get help,I don't no shit about computers
On Wed, Jul 28, 2021, 5:17 AM xcadrik @.***> wrote:

I was able to reproduce the issue with Samsung Galaxy A51 (Android 11)
with forced to use 2G network only in our project. We use getCells() from
various threads with 1s refresh rate and it seems that it has problem to
unregister listener properly in some cases. When I added that line, then
app continue and problem does not occur anymore for now. But I am not 100%
sure if it is correct solution.
You can view, comment on, or merge this pull request online at:
https://github.com/mroczis/netmonster-core/pull/23
Commit Summary

Solved problem with too many listeners (occurred when forced to use
2G network on samsung device)

File Changes

M
library/src/main/java/cz/mroczis/netmonster/core/feature/config/TelephonyManagerListeners.kt
https://github.com/mroczis/netmonster-core/pull/23/files#diff-d4d7538bc4940beb84b7c563480c6dacb4d3e2e0b450f401a2d6545b4b3df3ac
(1)

Patch Links:

https://github.com/mroczis/netmonster-core/pull/23.patch
https://github.com/mroczis/netmonster-core/pull/23.diff

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/mroczis/netmonster-core/pull/23, or unsubscribe
https://github.com/notifications/unsubscribe-auth/AO4FLWXZTIKJKGEFHDD2CSDTZ7DLZANCNFSM5BD6E3KQ
.


C#: error unpacking empty controllers list in UHPPOTE

...
public class Tests {
   ...
    static Controller[] controllers = {
    };
...

GODEBUG=cgocheck=2  && export DYLD_LIBRARY_PATH=../../lib/tests && mono ./tests.exe structs
  *** ERROR: 惠is not a valid device address:port
make: *** [debug] Error 255

Length of controllers list is hard-coded to 2 in bindings/csharp/uhppoted.cs:
       ...
        udevices devices = new udevices();
        devices.N = 2;
        devices.devices = p;
       ...

Fixed, closing


Improve development environment

The current implementation relies on an active shopify store so that the api requests can work. We should you create tests that mock the api endpoints so the project can be developed in its encapsulation.

Hi, I'm using GoCart.js for the first time I need some help on how to install it in my shopify theme. I'm stuck in step 5.

Please create a new issue describing what issues you have so we can help you :)


From stb to image crate: some doubts

I'm trying to replace the stb crate with the same hdr functionality in image, I have some doubts about it:

Do we really need to use the crate half to halve the space used by the hdr image? That by itself makes sense, if only float16 were actually supported by today's hardware. Apart from the ARM architecture the situation is gray: half float
The image used for hdr I've never seen in the game. Once I'm done implementing everything how do I verify that it's ok?

from my (unreliable) memory:
the reason float 16 is needed is for gpu hardware support of hdr textures. I don't think 32 bit is widely supported by gpus. I came across this error at one point and the wgpu team told me in the matrix chat that I should switch to 16 bit

on this page you can see that texture filtering isn't supported on 32bit
https://webgl2fundamentals.org/webgl/lessons/webgl-data-textures.html

found it lol

You can verify that the hdr environment maps are working well with the environment map gltf file. I made a branch that you can use to verify it: hdr_env_test_scene In particular, the metallic balls on the top row should look like this:

Nice! Thank you!

I should have made it, here's my screenshot:

this screenshot is with the image crate? looks good to me! feel free to PR

It is! I do a couple of checks and then open a PR.
Take note there is a "flaw", which I don't think is possible to fix (it was also in the original code). An hdr image (with the native values already processed) has only 3 useful color channels, while in our code we must necessarily use 4 color channels because of the wgpu::TextureFormat::Rgba16Float format (there is no Rgb16Float one).
So between RAM and sending data to the GPU we use a quarter more data than necessary. All in all it is a minor thing, but to be taken into account in case we find an alternative solution.

nice! that's awesome. will be great to get rid of the dependency and have more of the codebase in rust instead of c :).

we use a quarter more data than necessary

I wonder if texture compression would help mitigate the fact that one channel is being ignored


Will multithreading be implemented?

Will you be implementing multithreading in triton, or will you be left with Python flaws?

I don't understand the question. Triton is already multi-threaded by nature. Both explicitly across program instances, and implicitly within instance across data blocks.

triton can use more than one of the available kernels or not?

I don't understand what you mean. Triton can use more than one host threads if you bind different python threads to different CUDA streams. Triton kernels are launched in parallel with different values of program_id, which amounts to multi-threading. Within kernels and for any given SMs, programs are single threaded by design, as the compiler automatically parallelize the code to map it onto different CUDA threads. Programmers who want to control CUDA threads directly should use CUDA.

How do you manage flows during a data race?
https://en.wikipedia.org/wiki/Race_condition

You can have a look at https://github.com/openai/triton/blob/master/python/triton/ops/matmul.py#L70-L81 for an example of how race conditions are handled may be handled when different program instances have to concurrently accumulate the result of many partial reductions.


raft - questions regard to membership change

Hi etcd team,
I was reading the raft code regards to dynamic membership change and I have a question about it. I have limited familiarity with the raft code so first I want to verify if my understanding about current membership implementation is correct:

Only one node reconfiguration at a time and one node change per reconfiguration. This guarantees two consecutive configurations has at least one node overlap in quorums.
Raft proposes the reconfiguration as "normal" command and adopts the new configuration only after it's committed in old quorum.

This implies that the membership is something in "state" because raft only uses it after it's committed, however, raft uses log history for leader election and I wonder if it's possible that current "applied membership" and the latest membership in log differs more than one node? If so, is this safe?
One example:
Let's say there're 3 consecutive reconfigurations:
S1: [A, B, C]
S2: [A, B, C, D]
S3: [A, B, C, D, E]

And this is current log state:
A(Term: 1): S1, S2, S3 [S1]
B(Term: 1): S1, S2, S3 [S3]
C(Term: 1): S1, S2, S3 [S3]
D(Term: 1): S1, S2, S3 [S3]
E(Term: 1): S1, S2, S3 [S3]

Configuration S3 is committed because it has been persisted on the quorum of S2, besides that, it has been persisted by all nodes in S3 as well. However, S3 is not applied to A yet, S2 is not applied to A as well(this is possible that A received entry S2 and S3 but has not received the commit message yet)so A thinks it's still belong to S1.
Now let's say B is partitioned from rest of the cluster and C, D, E form a new quorum in next term and C is the leader:
A(Term: 1): S1, S2, S3 [S1]
B(Term: 1): S1, S2, S3 [S3]
C(Term: 2): S1, S2, S3 [S3] L
D(Term: 2): S1, S2, S3 [S3]
E(Term: 2): S1, S2, S3 [S3]

Then A starts a leader election and it got the vote from B because A has a sufficient log history(it has S3 in log). So A thinks it's the leader of term2.
A(Term: 2): S1, S2, S3 [S1] L
B(Term: 2): S1, S2, S3 [S3]
C(Term: 2): S1, S2, S3 [S3] L
D(Term: 2): S1, S2, S3 [S3]
E(Term: 2): S1, S2, S3 [S3]

I was wondering can this happen? Thanks in advance!

however, raft uses log history for leader election and I wonder if it's possible that current "applied membership" and the latest membership in log differs more than one node? If so, is this safe?

This should not be possible.

Then A starts a leader election and it got the vote from B because A has a sufficient log history(it has S3 in log). So A thinks it's the leader of term2.

Before A starts the election, it MUST apply all pending configuration entries.

please check the doc here: https://github.com/coreos/etcd/blob/master/raft/node.go#L130-L135


dh-make-golang doesn't append -dev to end of library package names

The go packaging team naming conventions here state that:

We use the -dev suffix to keep the namespace clean for shipping shared libraries in the future, which would then be shipped as golang-github-stapelberg-godebiancontrol

However, when I run the command
dh-make-golang make -type "library" -git_revision v2.2.2 github.com/pion/webrtc
I get the output
golang-github-pion-webrtc
golang-github-pion-webrtc_2.2.2.orig.tar.xz
itp-golang-github-pion-webrtc.txt
I would have expected instead the package name to be golang-github-pion-webrtc-dev. Is this incorrect?

Whoops, just saw that the binary package name is indeed Package: golang-github-pion-webrtc-dev in debian/control


I cloned the current repo and I cannot build the example app.

Describe the bug
Example app will not build.  I'm using Android Studio Dolphin 2021.3.1 Patch 1. (built on Sep 30, 2022).  I'm running on macOS 12.6.1 on Apple Silicon. I cloned the repo, and opened the project found in path drift/examples/app and tried to build and run.  I get:
Running "flutter pub get" in app...
The current Dart SDK version is 2.16.2.

Because go_router >=0.2.0 <4.0.0 depends on flutter_web_plugins from sdk which depends on js 0.6.3, go_router >=0.2.0 <4.0.0 requires js 0.6.3.
And because sqlite3 >=1.6.0 <1.7.1 depends on js ^0.6.4 and sqlite3 >=1.7.1 requires SDK version >=2.17.0 <3.0.0, go_router >=0.2.0 <4.0.0 is incompatible with sqlite3 >=1.6.0.
So, because app depends on both go_router ^3.0.6 and sqlite3 ^1.7.0, version solving failed.
pub get failed (1; So, because app depends on both go_router ^3.0.6 and sqlite3 ^1.7.0, version solving failed.)

Any help would be appreciated.  Thanks.

The current Dart SDK version is 2.16.2.

The problem is very likely that you have an outdated Flutter version. For me, the latest state on develop builds just fine with Flutter 3.3.7.


Include ABAP Projects from dotabap.org in the artifacts

Hi @IObert,
thank you for this initiative. It would be great if the list powering https://dotabap.org/ that is maintained in the dotabap-list project can be included in the artifacts. The list is provided as a JSON format and can be accessed at: https://raw.githubusercontent.com/dotabap/dotabap-list/main/list.json.
Hope that someone has the time to contribute this. I can just provide the idea in the moment.
CU
Gregor

and https://list.dotabap.org/list.json and more information via https://generated.dotabap.org/generated.json
but I'm not sure what information is needed? something like the traffic stats is not public accessible

As far as I see, the list of repos must be added to analyzer/src/providers/gh-repo.ts#L7

ahh, okay, it looks at stars and forks

We could create a new "ABAP type" as well but then I'd make sense to have some DL count or so.
But I think it's, for now, enough to add them to the list of GitHub repos.
I can take this item :)

Done, all items of that list should be added automatically in the next run (on Sept 1st)


Fix Rubocop on CI

Somehow the linter has begun failing after we upgraded bundler.
https://ci.integration.publishing.service.gov.uk/job/finder-frontend/job/deployed-to-production/420/console

:shipit: Hopefully this will fix the content schema downstream builds!

I think this might have been because we bumped rubocop version https://github.com/alphagov/govuk-lint/pull/66


default max_document_size is inconsistent between documentation and default.ini

Documentation for the max_document_size setting claims it is 4 GB: http://docs.couchdb.org/en/2.0.0/config/couchdb.html#couchdb/max_document_size
But in practice it is 64 MB: https://github.com/apache/couchdb/blob/2f539e003c88b8c76c42a39e6c53b9e61bc783f8/rel/overlay/etc/default.ini#L11
Which one is correct?
Your Environment

Version used: 2.0.0
Operating System and version (desktop or mobile): CentOS 7 64-bit

I don't think the documentation is trying to show what the default value is, in the inset; it's just trying to show how you'd change the value in your own local.ini file. For instance, scrolling up it shows a sample setting for the util_driver_dir directory that is clearly not the default value.
64MB is the correct default value.


Got "Application Error" after trying to accept the invitation

Hello,
I just discovered Staticman and I have a problem with it. I have added "staticmanapp" as a contributor to my github repo but can't manage to accept the invite. In fact, I'm getting an "Application Error" visiting the URL https://api.staticman.net/v2/connect/Skyost/repo :

Just seen this : #243.


Faulty validation in multistep forms

Reproduction
https://formkit.link/f79dbfa81d9b8b92ff946c3945092b31
Describe the bug
Fields, even if they have no validation, are incorrectly displayed as invalid if you press the Submit button in a multistep form and other fields with unfulfilled validation exist.
If you click on the ‘Next’ button in a step, the validation works correctly. In this example, the fields Name and Email are displayed as invalid in the ‘Personal Info’ step. If you now go to the last page and press ‘Submit’, in addition to the fields correctly marked as invalid, the Phone field is also marked as invalid (but without a note).
Expected behaviour:

Current behaviour:

Environment
• OS: Windows
• Browser: Chrome
• Version: 130.0.6723.70 (Offizieller Build) (64-Bit)

This is s styling issue with the theme I believe, specifically this tailwind selector:
.group[data-invalid] .group-data-\[invalid\]\:ring-red-500

@andrew-boyd I think we just need to name that outer group perhaps?

I believe that the issue I posted last week is related: HERE

I believe that the issue I posted last week is related: HERE

Looks like the same error. Didn't see it when searching for ‘multistep’ (I still only see it when searching for ‘multi-step’, although other issues with ‘multi-step’ in the name are displayed when searching for ‘multistep’).

Following up on this issue again.
Does anyone know of a workaround that I would be able to employ while this bug is being looked at? It is causing significant confusion for the customers on our website currently. I am also hesitant to mess with the auto-generated formkit.theme.ts file as I do not want to ruin any of the existing styling while looking for a workaround.


Fix documentation on how to use librato sink

This PR updates the documentation on how to use the Librato sink.

This change is

I signed it!

@k8s-bot ok to test

👍 thanks for doing this @dieterdemeyer lgtm

Not really sure why this PR is failing since it's just documentation...
Is there an underlying problem here ?

looks like an infrastructure flake.
@k8s-bot test this

The problem is with CLA. @dieterdemeyer did you sign it?

Yes, I already signed it.

/retest

@k8s-bot /retest


Bug: Date of weight previously removed weight value remains after edit command.

After performing weight 2 w/ to remove the latest weight from the second client in the list, the date of the recorded weight still remains in the graph. Not sure if this is a bug, otherwise would it be good to specify that this behaviour is correct in the UG?

I think it's considered an enhancement, so we can include this behaviour in the UG.
Maybe it could be phrased as a benefit for the user; so that they can quickly tell that a weight has been removed.


Main Readme + Fix %s on uint64 printing weird

"

i would just mention that the CLI only supports holesky
and technically only preprod, which doesnt have public addresses
idk how to word that


local server

hi, please tell me, we have an application with 40 thousand clients, we need the ability to run a local server on them and generate a certificate in order to connect using a web application with a phone and send data to it. Is this possible with this package?

Let's Encrypt (https://letsencrypt.org) is a public service that generates SSL certificates for public reachable domains (real domains). For each domain, it will need to point to an IP that reaches your "local" server. I don't know if this is what you want.


Storybook no longer working on Windows

To reproduce:
cd react
npm i
npm run start

This works for some people some of the time, no idea what's going on with it.

Seems to be fine now.


Maintenance?

I like the API of SDS but I see no (development) activity in this repository. Is it still maintained?
The sds source in the redis seems to be newer?

The project is abandoned. I see that most of the closed PRs were closed by the authors themselves because the project is abandoned. And I see 600 forks. Maybe there is a new leader among them?

This is a shame. I really like this library. I am thinking about forking it and review/merging the pull requests.
I should probably also search the redis source for fixes for sds.
I have also some interesting functions that could be useful, especially json encoding/decoding and urldecoding/encoding.
Or someone knows a maintained fork?
Or someone interested in working with me on that?


chore(graphql-transformer-migrator): warn users about stripping out the comments in schema migration

Description of changes

warns users about removing graphql comment when using migrator tool

Checklist

[x] PR description included
[x] yarn test passes
[ ] Tests are changed or added
[ ] Relevant documentation is changed or added (and PR referenced)
[ ] New AWS SDK calls or CloudFormation actions have been added to relevant test and service IAM policies

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@lazpavel I've updated the base branch to target master. Can you please rebase.


Closes https://github.com/IBM/carbon-components-react/issues/2230
When the Icon component is being used without the description property the default is being assigned to description. The default value at the moment is  Provide a description that will be used as the title. This default description generates an invalid (from an a11y perspective) aria-label attribute value in the HTML, which can cause confusion to the end user. This leads to a false negative in DAP (no reported violation).
Changelog
Removed
Removed the following property from the Icon component.
descripton: Provide a description that will be used as the title
Please dont hesitate to raise questions! Peace out!

@asudoh @emyarod thanks for merging this and taking the time to review it!


sync: refactor sync_device into non-blocking connects

This deprecates sync_tcp_connect(), replacing it with sync_server_setup_tcp() intended to be called just once to establish the host+port of the server to maintain a connection with.
Now sync_update() transparently maintains that connection to the best of its ability, iterating across the addrinfo/hostentry results of the host resolution done once up front and stored in the device.
The host+port resolution code is mostly unchanged, just decomposed to store its iterative state in sync_device instead of local variables.
A few state variables have been added for tracking if the sync_device is setup->connecting->connected->ready:
The setup state indicates that sync_server_setup_tcp() has been called successfully with the resolved address info stores @ sync_device.server
connecting->connected->ready just track the progression of the connection until established including the greeting etc.  At which point, sync_update() will start succceeding.
At any point, if d->sock becomes INVALID_SOCKET, it implicitly clears all of connecting->connected->ready for the cycle to repeat itself.
Whenever a new connect is initiated, it's performed on the next address in the address info.  This may not be ideal, it might make more sense to flag the one we've been connected to as the one to always use.  But it's mostly harmless.
With this commit, sync_update() should never block the main loop of the demo.
It would be nice to make sync_update()'s return value describe the connecting vs. connected state for the demo to show status overlays or what not.  For now errors are all just -1, they could be -errno for more context.

This is a first stab at addressing https://github.com/rocket/rocket/issues/97
I only did a quick linux build and test using the included example demo.  That seemed to at least work, including reconnecting gracefully when I restarted RocketEditor.
I have not yet even compile tested WIN32, and have zero knowledge or ability to test the AMITCP or GEKKO variants seemingly supported by the code.
Just wanted to get this up ASAP and see how any relevant parties feel about the trajectory here, and if any of this is utterly unsupported by AMITCP/GEKKO to the extent that we can't possibly do it.
One thing I'd like to note is; if this were how librocket already worked, my schismtracker changes @ https://github.com/schismtracker/schismtracker/pull/353 would already automagically handle RocketEditor disconnects w/reconnecting and only fail @ startup if the --rocket host:port couldn't be resolved, which is a UX that makes sense, without any effort.  I definitely can't have the schism UI hanging while stuck in name resolution+(re)connect delays @ sync_update(), and no, threading insanity is not happening to try work around that.
@kusma WDYT?

Thanks for the review.
It took me a little while to get back to this, but I'd like to report that in the mean time my musician tested these changes in Windows proper via my hacked Rocket-integrated SchismTracker and our demo project, it all seemed to work fine for him.  So it at least seems the non-blocking connect implementation here works properly in native Windows and I already verified Linux.
Now we just have to get the API settled, and handle the limited blocking connect platforms gracefully.

Closing in favor of #107 since that seems like a far better and more generalized way to facilitate such use cases.

Closing in favor of https://github.com/rocket/rocket/pull/107 since that seems like a far better and more generalized way to facilitate such use cases.