Add option to use a specific range of IPs

This is a necessary use case for customers that bring their own IPs, or Packet global anycast IPs.

We’ve been using kube-vip in the latest integrations (anthos in this case), metallb is not used at all.
We don’t have an annotation that the CCM can recognize to associate addresses to label in this way, that I know of.
The CCM will provision an extra IP if needed, but there is no way to request that the created IP be tagged with a tag or request an IP from reservations with a given tag.  I think a CCM recognized annotation that sets up this tag dependent behavior would allow us to ensure that multiple services claim the same address without knowing the address in advance (which is what spec.loadBalancerIP allows for today).

We may actually be part of the way there. The following is paraphrased from the README, in both the kube-vip and metallb sections.
For each service of type=LoadBalancer currently in the cluster or added:

if an Elastic IP address reservation with the appropriate tags exists, and the Service already has that IP address affiliated with it, it is ready; ignore
if an Elastic IP address reservation with the appropriate tags exists, and the Service does not have that IP affiliated with it, add it to the service spec (if configured for metallb, also ensure it is in the pools of the metallb ConfigMap with auto-assign: false)
if an Elastic IP address reservation with the appropriate tags does not exist, create it and add it to the services spec (if configured for metallb, also ensure is in the pools of the metallb ConfigMap with auto-assign: false)

The question is, are those tags usable as is? Or do we need something else?

Thanks for pointing this out, @deitch. This comment will include a little thinking-out-loud as I go through the README.

When starting the CCM, set the env var METAL_EIP_TAG=<tag>, where  is whatever tag you set on the EIP

This tag becomes a CCM-scoped filter, I think we would benefit from an application-scoped setting, specified within each service (as an annotation or label).
Let's say METAL_EIP_TAG was set. If two Service/LoadBalancer resources were created with the same tag annotation, and we need a new /32 Elastic IP reservation to fulfill the LoadBalancer request, I would imagine the CCM would request a new reservation, tagging that reservation with both the METAL_EIP_TAG and the tag identified in the annotation.  The second LoadBalancer resource would, barring race conditions, find that same address.
If we have an existing reservation that matches both tags, but is larger than /32, we would need a way to assign the same /32 from that reservation to both services.  Perhaps the application-scoped tag on the reservation looks like: {single-ccm-annotation-tag}:{/32 IP}
Perhaps we already have this?
https://github.com/equinix/cloud-provider-equinix-metal#elastic-ip-configuration

usage="cloud-provider-equinix-metal-auto" Is this the default METAL_EIP_TAG?
service="<service-hash>" This seems close to the tag filter idea
cluster=<clusterID> This seems related to https://github.com/equinix/cloud-provider-equinix-metal/issues/154

The suggestion I am mulling around is whether we should introduce a tag such as:

annotation="keyword{",/32 IP" pulled from the reservation if the reservation is larger than /32}"

Multiple of these could be added to an existing reservation or added to a new reservation that uses the annotation.
kind: Service
metadata:
  annotations:
    metal.equinix.com/ip-reservation-tag-annotation: keyword
    metal.equinix.com/ip-reservation-cidr: 28
spec:
  type: LoadBalancer

If the CIDR is specified, we would create an IP reservation request of that size.  If not specified, we would find any reservation with the keyword in the annotation tag, or create a /32 with that annotation tag.

To draw a /32 from an existing reservation,
kind: Service
metadata:
  annotations:
    metal.equinix.com/ip-reservation-id: {uuid}
    metal.equinix.com/ip-reservation-cidr: 28 # optional, used for creates
spec:
  type: LoadBalancer

or
kind: Service
metadata:
  annotations:
    metal.equinix.com/ip-reservation-tag: {keyword}
    metal.equinix.com/ip-reservation-cidr: 28 # optional, used for creates
spec:
  type: LoadBalancer

My suggestions may not behave well in race conditions where two services are created at once with the same tags. I imagine multiple requests would be distributed to different CCM pods and requested at once.

These suggestions also may not fit the alternate engines, metallb and kube-vip which may offer duplicating or conflicting options.

We have an existing prefix metal.equinix.com/src-. Anywhere I said metal.equinix.com/ip- above, pretend I said metal.equinix.com/src-.

METAL_EIP_TAG

This is from the control plane load balancing. This doesn't control for Service type=LoadBalancer
You raise a good point. While it does have solid tag logic, it doesn't provide a way for use to tell it what tags to use. You could replicate the logic, but that is messy. It is consistent, but internal.
The hashing really is also to avoid names that might not be accepted on tags, but primarily to avoid leakage. It isn't the business of the EM API or its backend database to know what the names of services are inside clusters. We had some customer who needed that extra privacy guarantee, and there was no reason why not.

think we would benefit from an application-scoped setting, specified within each service (as an annotation or label)

I can get behind that. So when you create a Service, your annotations can determine the CCM behaviour:

get an arbitrary EIP for me (current behaviour)
use a reserved one
take a reserved one from a pool

Did I miss any? We would need to know what to do if the EIP already is in use. Do we allow reuse? Or call it an error?
I like where this is going.

We would need to know what to do if the EIP already is in use.

If the EIP is used by the requesting cluster - this is fine?

your annotations can determine the CCM behaviour ... did I miss any?

https://github.com/equinix/terraform-metal-anthos-on-baremetal/issues/51 would like the CCM to offer private addresses. Private address provisioning works in the same way on the EM API, perhaps we just need another annotation to toggle private addresses (and we can use existing private IPs and pools just as we would public pools).

We may be blocked by the Equinix Metal API here. IP Reservations tags can not be changed.

Noting that tags can be changed now. It would still be helpful to have a way (that is well documented alongside the bring your own IP pattern) to accomplish the following:

I have a /24 reservation, use it for the /32 needed for the service
I have a special use-case that will require several IPs, find the reservation matching the given tag criteria and if it does not exist create it with the given size. Use this for the /32 needed for the service.

When the parent block reservation has no available /32s, an error saying as much would be surfaced.

/reopen

/remove-lifecycle rotten

/triage accepted


Unable to resolve module #ansi-styles

Hi everyone! 👋
I came across the next issue while using the library
The error
When I installed chalk and implemented it I got the next error
[Error: undefined Unable to resolve module #ansi-styles from /Users/Github/porcuSafe/node_modules/chalk/source/index.js: #ansi-styles could not be found within the project or in these directories:
  node_modules
> 1 | import ansiStyles from '#ansi-styles';

How I implemented the library
import chalk from 'chalk'
const originalLog = console.log;

console.log = function(...args) {
    // Check if the first argument looks like a tag
    if (typeof args[0] === 'string' && args[0].startsWith('[') && args[0].endsWith(']')) {
        let tag = args.shift(); // Remove the tag from the arguments array

        // Style the tag with Chalk
        const styledTag = chalk.cyan(tag);

        // Combine styled tag and original message
        args.unshift(styledTag);
    }

    originalLog.apply(console, args);
};

The technologies used in my project

react-native v0.73.2
expo v50
react v18.2.0
typescript 5.0.4

The Fix
So I used patch-package to patch<EMAIL_ADDRESS>for the project I'm working on.
Here is the diff that solved my problem:
diff --git a/node_modules/chalk/source/index.js b/node_modules/chalk/source/index.js
index 8bc993d..284bca5 100644
--- a/node_modules/chalk/source/index.js
+++ b/node_modules/chalk/source/index.js
@@ -1,5 +1,5 @@
-import ansiStyles from '#ansi-styles';
-import supportsColor from '#supports-color';
+import ansiStyles from './vendor/ansi-styles/index.js';
+import supportsColor from './vendor/supports-color/browser.js';
 import { // eslint-disable-line import/order
 	stringReplaceAll,
 	stringEncaseCRLFWithFirstIndex,

This is a problem with the bundler used by React Native, not this package. It needs to support the imports field in package.json.

Another solution is to downgrade chalk to something like 4.1.2. Unfortunately large frameworks like React Native can't instantly migrate to make use of new features like ESM.


Lint/UnneededDisable Exclude is ignored.

The Lint/UnneededDisable does not honor the excludes
Expected behavior
I would expect that if I explicitly exclude a file or set of files from the this cop then that cop will not trigger an error.
Actual behavior
Cop triggers an error on explicitly excluded files.
Steps to reproduce the problem
Create a file with an unnecessarily disabled rule:
# Disable style cop to enable metadata DSL to line up for readability
# rubocop:disable Style/SingleSpaceBeforeFirstArg
#
foo       'qux'
bar       'quux'
baz       'garply'

Exclude the file in your configuration:
Lint/UnneededDisable:
  Exclude:
    - '**/metadata.rb'

Output from a run:
bundle exec rubocop -c /tmp/github/exclude.yml -D /tmp/github/metadata.rb
Inspecting 1 file
W

Offenses:

/tmp/github/metadata.rb:2:1: W: Lint/UnneededDisable: Unnecessary disabling of Style/SingleSpaceBeforeFirstArg (did you mean Style/SpaceBeforeFirstArg?).
# rubocop:disable Style/SingleSpaceBeforeFirstArg
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

1 file inspected, 1 offense detected

Note that if the rule is globally disabled, it will not execute the cop.  So, it seems to just not be honoring the excludes.
RuboCop version
bundle exec rubocop -V
0.39.0 (using Parser <IP_ADDRESS>, running on ruby 2.1.6 x86_64-linux)

That's a bug. I'll fix it.


Warn if remembering a worker without using rememberWorker

// Before
val worker = remember { SomeWorker() }

// After
val worker = rememberWorker { SomeWorker() }

Also offer to automatically migrate the method call.

PSI fun again wohoo

should be fairly easy to detect


The context property TransmitWorkID is not documented

The tremendously useful context property TransmitWorkID is not documented. It is just mentioned as existing in https://docs.microsoft.com/en-us/dotnet/api/bts.transmitworkid?view=bts-dotnet. It should be described along with the other context properties at https://docs.microsoft.com/en-us/biztalk/core/how-to-use-message-context-properties

PR #452 has been created to fix this.


Node type ImageFlip+ and MaskFlip+ not found in the given example graph InstantID_multi_id.json

Hi, when I load the InstantID_multi_id.json, I get the error
When loading the graph, the following node types were not found: ImageFlip+ MaskFlip+...
May I know what's going on and what installation did I miss? I can load and execute the InstantID_posed.json without any problem. Thanks!

Install this solve my problem https://github.com/cubiq/ComfyUI_essentials


pick #6672 and #6736

What have you changed?
Pick #6672 and #6736.
What is the type of the changes?

Bugfix

How is the PR tested?

Integration test

Does this PR affect documentation (docs) or should it be mentioned in the release notes?
Yes.
Does this PR affect tidb-ansible?
No.
Refer to a related PR or issue link (optional)
#6672.

/run-all-tests


train the STD Model on my own dataset

Congradulations for accepted work
Is this git complete? I would like to train your suggested  Spatial-Transform-Decoupling  model on my own dataset. However, I did not find any code related to your suggested  Spatial-Transform-Decoupling  model. Could you provide a more detailed user guide？ Thanks a lot

Our core code: bbox_heads, cfgs.
Indeed, Installation in README only tell readers how to use rotated_faster_rcnn+r50 in MMRotate. Further, you can use our rotated_faster_rcnn+vit_small+std like:
CUDA_VISIBLE_DEVICES=0,1,2,3,4,5,6,7 ./tools/dist_train.sh ./configs/rotated_imted/rotated_imted_faster_rcnn_vit_small_1x_dota_le90_8h_stdc_xyawh321v.py 8
CUDA_VISIBLE_DEVICES=0,1,2,3,4,5,6,7 ./tools/dist_test.sh ./configs/rotated_imted/rotated_imted_faster_rcnn_vit_small_1x_dota_le90_8h_stdc_xyawh321v.py ./work_dirs/rotated_imted_faster_rcnn_vit_small_1x_dota_le90_8h_stdc_xyawh321v/epoch_12.pth 8 --format-only --eval-options submission_dir="./work_dirs/Task1_rotated_imted_faster_rcnn_vit_small_1x_dota_le90_8h_stdc_xyawh321v_epoch_12/"
python "../DOTA_devkit/dota_evaluation_task1.py" --mergedir "./work_dirs/Task1_rotated_imted_faster_rcnn_vit_small_1x_dota_le90_8h_stdc_xyawh321v_epoch_12/" --imagesetdir "./data/DOTA/val/" --use_07_metric True

对已接受工作的祝贺 这个 git 完成吗？我想在我自己的数据集上训练您建议的空间变换解耦模型。但是，我没有找到与您建议的空间变换解耦模型相关的任何代码。您能提供更详细的用户指南吗？ 非常感谢

同学 你好！！请问你在自己的数据集上运行成功了吗？


Query: Sum should return zero for empty collections regardless of the type

This is to match the behavior of LINQ to Objects and expectation expressed here:
https://entityframework.codeplex.com/workitem/2449
http://data.uservoice.com/forums/72025/suggestions/2410716
http://stackoverflow.com/questions/3274196

@maumar - Is this something we already did or tracking somewhere else?

somewhat related to https://github.com/aspnet/EntityFramework/issues/6061

Verified this is already working.

Scratch that, I see that we don't return 0 for nullable types.


Sample guest data and remove duplicate type key in json

Fixed #120
Fixed #63

can ignore codecov


Segmentation Fault

Hi,
We have been using sqlite3 module successfully for quite some time in an embedded application. Recent updates to the app make more heavily use of the database and the node VM now gets a segmentation fault.
The error happens sporadically and sometimes even when the app is not writing to the database and just idling.
Any help would be appreciated.
Node: 6.10.3
Npm: 3.10.10
Architecture: armv7l
OS: GNU/Linux
Program terminated with signal SIGSEGV, Segmentation fault.
#0  sqlite3_db_mutex (db=0x0) at Release/obj/gen/sqlite-autoconf-3150000/sqlite3.c:138532
warning: Source file is more recent than executable.
138532	}
[Current thread is 1 (LWP 25481)]
(gdb) list
138527	    (void)SQLITE_MISUSE_BKPT;
138528	    return 0;
138529	  }
138530	#endif
138531	  return db->mutex;
138532	}
138533
138534	/*
138535	** Free up as much memory as we can from the given database
138536	** connection.
(gdb) bt
#0  sqlite3_db_mutex (db=0x0) at Release/obj/gen/sqlite-autoconf-3150000/sqlite3.c:138532
#1  0xb481a668 in node_sqlite3::Statement::Work_Prepare (req=) at ../src/statement.cc:128
#2  0x00866d44 in ?? ()
Backtrace stopped: previous frame identical to this frame (corrupt stack?)
Regards
Mark

Some more info from gdb ...
Program terminated with signal SIGSEGV, Segmentation fault.
#0  sqlite3_db_mutex (db=0x0) at Release/obj/gen/sqlite-autoconf-3150000/sqlite3.c:138532
warning: Source file is more recent than executable.
138532	}
[Current thread is 1 (LWP 25481)]
(gdb) list
138527	    (void)SQLITE_MISUSE_BKPT;
138528	    return 0;
138529	  }
138530	#endif
138531	  return db->mutex;
138532	}
138533
138534	/*
138535	** Free up as much memory as we can from the given database
138536	** connection.
(gdb) bt
#0  sqlite3_db_mutex (db=0x0) at Release/obj/gen/sqlite-autoconf-3150000/sqlite3.c:138532
#1  0xb481a668 in node_sqlite3::Statement::Work_Prepare (req=) at ../src/statement.cc:128
#2  0x00866d44 in ?? ()
Backtrace stopped: previous frame identical to this frame (corrupt stack?)
(gdb) p db
$1 = (sqlite3 *) 0x0
(gdb) info threads
Id   Target Id         Frame

1    LWP 25481         sqlite3_db_mutex (db=0x0) at Release/obj/gen/sqlite-autoconf-3150000/sqlite3.c:138532
2    LWP 25482         0xb6b6a8d0 in pthread_cond_wait () from /lib/libpthread.so.0
3    LWP 25358         0xb6b6cd58 in ?? () from /lib/libpthread.so.0
4    LWP 25359         0xb6b6cd58 in ?? () from /lib/libpthread.so.0
5    LWP 25360         0xb6b6cd58 in ?? () from /lib/libpthread.so.0
6    LWP 25361         0xb6b6cd58 in ?? () from /lib/libpthread.so.0
7    LWP 25362         0xb6b6cd58 in ?? () from /lib/libpthread.so.0
8    LWP 25483         0xb6b6a8cc in pthread_cond_wait () from /lib/libpthread.so.0
9    LWP 25484         0xb6b6a8cc in pthread_cond_wait () from /lib/libpthread.so.0
10   LWP 25356         0x004e8094 in v8::internal::IC::IC(v8::internal::IC::FrameDepth, v8::internal::Isolate*, v8::internal::FeedbackNexus*) ()
(gdb)

What node-sqlite3 version are you running/experiencing this crash with? If you are running v4.0.2 can you check if downgrading to 4.0.0 fixes the sporadic crash? Asking since 4.0.1 upgraded the internal sqlite library version to 3.24.0: https://github.com/mapbox/node-sqlite3/blob/master/CHANGELOG.md#401

I may just attempt to edit the makefile to build with SQLITE_ENABLE_API_ARMOR defined. Offending code snippet below.
/*
** Return the mutex associated with a database connection.
*/
SQLITE_API sqlite3_mutex *sqlite3_db_mutex(sqlite3 *db){
#ifdef SQLITE_ENABLE_API_ARMOR
if( !sqlite3SafetyCheckOk(db) ){
(void)SQLITE_MISUSE_BKPT;
return 0;
}
#endif
return db->mutex;
}

I got this error today:
PID 64555 received SIGSEGV for address: 0x18
/home/mohamed/Development/project/node_modules/segfault-handler/build/Release/segfault-handler.node(+0x2e45)[0x7f3e3d149e45]
/lib64/libpthread.so.0(+0x14a90)[0x7f3e3a3e3a90]
/home/mohamed/Development/project/node_modules/sqlite3/lib/binding/napi-v3-linux-x64/node_sqlite3.node(sqlite3_db_mutex+0x0)[0x7f3e343b9730]
/home/mohamed/Development/project/node_modules/sqlite3/lib/binding/napi-v3-linux-x64/node_sqlite3.node(_ZN12node_sqlite39Statement12Work_PrepareEP10napi_env__Pv+0x23)[0x7f3e34393bd3]
/lib64/libnode.so.72(+0xdd9bd4)[0x7f3e3b1cabd4]
/lib64/libpthread.so.0(+0x9432)[0x7f3e3a3d8432]
/lib64/libc.so.6(clone+0x43)[0x7f3e3a306913]
Segmentation fault (core dumped)

The DB was closed before an insert finished, hence the crash. An error message would be nice.


PHOENIX-6557 Fix code problems flagged by SpotBugs as High priority

A lot of this patch is setting the character sets, and boxing/unboxing optimizations, but there are a handful of actual bug fixes hidden in there.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
6m 34s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  1s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

-1 :x:
test4tests
0m  0s
The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ master Compile Tests _

+0 :ok:
mvndep
4m 57s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
19m 31s
master passed

+0
hbaserecompile
32m 25s
HBase recompiled.

+1 :green_heart:
compile
1m 46s
master passed

+1 :green_heart:
checkstyle
3m 59s
master passed

+1 :green_heart:
javadoc
2m  5s
master passed

+0 :ok:
spotbugs
5m  0s
root in master has 1031 extant spotbugs warnings.

+0 :ok:
spotbugs
3m 24s
phoenix-core in master has 972 extant spotbugs warnings.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 15s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
18m  9s
the patch passed

+0
hbaserecompile
26m 43s
HBase recompiled.

+1 :green_heart:
compile
1m 59s
the patch passed

+1 :green_heart:
javac
1m 59s
the patch passed

-1 :x:
checkstyle
3m 56s
root: The patch generated 372 new + 9895 unchanged - 369 fixed = 10267 total (was 10264)

-1 :x:
whitespace
0m  0s
The patch has 2 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply

-1 :x:
whitespace
0m  0s
The patch 1 line(s) with tabs.

+1 :green_heart:
xml
0m  3s
The patch has no ill-formed XML file.

+1 :green_heart:
javadoc
2m 10s
the patch passed

+1 :green_heart:
spotbugs
3m 23s
phoenix-core generated 0 new + 704 unchanged - 268 fixed = 704 total (was 972)

+1 :green_heart:
spotbugs
5m 12s
root generated 0 new + 757 unchanged - 274 fixed = 757 total (was 1031)

_ Other Tests _

-1 :x:
unit
2m  6s
root in the patch failed.

-1 :x:
asflicense
0m 37s
The patch generated 613 ASF License warnings.

103m 52s

Reason
Tests

Failed junit tests
phoenix.mapreduce.FormatToBytesWritableMapperTest

phoenix.mapreduce.util.ColumnInfoToStringEncoderDecoderTest

phoenix.util.ColumnInfoTest

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1319/1/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/phoenix/pull/1319

Optional Tests
dupname asflicense javac javadoc unit spotbugs hbaserebuild hbaseanti checkstyle compile xml

uname
Linux 7f3d6fdb319a 4.15.0-153-generic #160-Ubuntu SMP Thu Jul 29 06:54:29 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev/phoenix-personality.sh

git revision
master / c1ffb0b

Default Java
Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08

checkstyle
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1319/1/artifact/yetus-general-check/output/diff-checkstyle-root.txt

whitespace
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1319/1/artifact/yetus-general-check/output/whitespace-eol.txt

whitespace
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1319/1/artifact/yetus-general-check/output/whitespace-tabs.txt

unit
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1319/1/artifact/yetus-general-check/output/patch-unit-root.txt

Test Results
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1319/1/testReport/

asflicense
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1319/1/artifact/yetus-general-check/output/patch-asflicense-problems.txt

Max. process+thread count
495 (vs. ulimit of 30000)

modules
C: phoenix-core . U: .

Console output
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1319/1/console

versions
git=2.7.4 maven=3.3.9 spotbugs=4.1.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m  7s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  1s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

-1 :x:
test4tests
0m  0s
The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ master Compile Tests _

+0 :ok:
mvndep
5m 15s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
19m 45s
master passed

+0
hbaserecompile
31m 57s
HBase recompiled.

+1 :green_heart:
compile
1m 47s
master passed

+1 :green_heart:
checkstyle
3m 56s
master passed

+1 :green_heart:
javadoc
2m 12s
master passed

+0 :ok:
spotbugs
4m 59s
root in master has 1031 extant spotbugs warnings.

+0 :ok:
spotbugs
3m 22s
phoenix-core in master has 972 extant spotbugs warnings.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 16s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
16m 53s
the patch passed

+0
hbaserecompile
23m 58s
HBase recompiled.

+1 :green_heart:
compile
1m 49s
the patch passed

+1 :green_heart:
javac
1m 49s
the patch passed

-1 :x:
checkstyle
4m  1s
root: The patch generated 372 new + 9895 unchanged - 369 fixed = 10267 total (was 10264)

-1 :x:
whitespace
0m  0s
The patch has 2 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply

-1 :x:
whitespace
0m  1s
The patch 1 line(s) with tabs.

+1 :green_heart:
xml
0m  3s
The patch has no ill-formed XML file.

+1 :green_heart:
javadoc
2m  5s
the patch passed

+1 :green_heart:
spotbugs
3m 19s
phoenix-core generated 0 new + 704 unchanged - 268 fixed = 704 total (was 972)

+1 :green_heart:
spotbugs
4m 59s
root generated 0 new + 757 unchanged - 274 fixed = 757 total (was 1031)

_ Other Tests _

-1 :x:
unit
2m  3s
root in the patch failed.

-1 :x:
asflicense
0m 36s
The patch generated 613 ASF License warnings.

94m 44s

Reason
Tests

Failed junit tests
phoenix.mapreduce.FormatToBytesWritableMapperTest

phoenix.mapreduce.util.ColumnInfoToStringEncoderDecoderTest

phoenix.util.ColumnInfoTest

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1319/2/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/phoenix/pull/1319

Optional Tests
dupname asflicense javac javadoc unit spotbugs hbaserebuild hbaseanti checkstyle compile xml

uname
Linux 741eb6fee043 4.15.0-153-generic #160-Ubuntu SMP Thu Jul 29 06:54:29 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev/phoenix-personality.sh

git revision
master / c1ffb0b

Default Java
Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08

checkstyle
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1319/2/artifact/yetus-general-check/output/diff-checkstyle-root.txt

whitespace
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1319/2/artifact/yetus-general-check/output/whitespace-eol.txt

whitespace
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1319/2/artifact/yetus-general-check/output/whitespace-tabs.txt

unit
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1319/2/artifact/yetus-general-check/output/patch-unit-root.txt

Test Results
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1319/2/testReport/

asflicense
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1319/2/artifact/yetus-general-check/output/patch-asflicense-problems.txt

Max. process+thread count
493 (vs. ulimit of 30000)

modules
C: phoenix-core . U: .

Console output
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1319/2/console

versions
git=2.7.4 maven=3.3.9 spotbugs=4.1.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m  4s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  1s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

-1 :x:
test4tests
0m  0s
The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ master Compile Tests _

+0 :ok:
mvndep
5m  3s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
19m 35s
master passed

+0
hbaserecompile
31m 37s
HBase recompiled.

+1 :green_heart:
compile
1m 49s
master passed

+1 :green_heart:
checkstyle
4m  1s
master passed

+1 :green_heart:
javadoc
2m  7s
master passed

+0 :ok:
spotbugs
4m 56s
root in master has 1031 extant spotbugs warnings.

+0 :ok:
spotbugs
3m 18s
phoenix-core in master has 972 extant spotbugs warnings.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 15s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
16m 59s
the patch passed

+0
hbaserecompile
24m  4s
HBase recompiled.

+1 :green_heart:
compile
1m 47s
the patch passed

+1 :green_heart:
javac
1m 47s
the patch passed

-1 :x:
checkstyle
4m  3s
root: The patch generated 370 new + 9895 unchanged - 369 fixed = 10265 total (was 10264)

-1 :x:
whitespace
0m  0s
The patch 1 line(s) with tabs.

+1 :green_heart:
xml
0m  2s
The patch has no ill-formed XML file.

+1 :green_heart:
javadoc
2m  7s
the patch passed

+1 :green_heart:
spotbugs
3m 21s
phoenix-core generated 0 new + 704 unchanged - 268 fixed = 704 total (was 972)

+1 :green_heart:
spotbugs
5m  0s
root generated 0 new + 757 unchanged - 274 fixed = 757 total (was 1031)

_ Other Tests _

-1 :x:
unit
118m  1s
root in the patch failed.

-1 :x:
asflicense
1m 30s
The patch generated 613 ASF License warnings.

212m 38s

Reason
Tests

Failed junit tests
phoenix.end2end.index.MutableIndexFailureIT

phoenix.end2end.CSVCommonsLoaderIT

phoenix.end2end.VariableLengthPKIT

phoenix.end2end.CsvBulkLoadToolIT

phoenix.end2end.ArithmeticQueryIT

phoenix.end2end.index.MutableIndexFailureWithNamespaceIT

phoenix.end2end.index.IndexMetadataIT

phoenix.end2end.TenantSpecificTablesDDLIT

phoenix.end2end.OrphanViewToolIT

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1319/3/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/phoenix/pull/1319

Optional Tests
dupname asflicense javac javadoc unit spotbugs hbaserebuild hbaseanti checkstyle compile xml

uname
Linux ad7e8bd10000 4.15.0-153-generic #160-Ubuntu SMP Thu Jul 29 06:54:29 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev/phoenix-personality.sh

git revision
master / c1ffb0b

Default Java
Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08

checkstyle
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1319/3/artifact/yetus-general-check/output/diff-checkstyle-root.txt

whitespace
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1319/3/artifact/yetus-general-check/output/whitespace-tabs.txt

unit
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1319/3/artifact/yetus-general-check/output/patch-unit-root.txt

Test Results
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1319/3/testReport/

asflicense
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1319/3/artifact/yetus-general-check/output/patch-asflicense-problems.txt

Max. process+thread count
8314 (vs. ulimit of 30000)

modules
C: phoenix-core . U: .

Console output
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1319/3/console

versions
git=2.7.4 maven=3.3.9 spotbugs=4.1.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
5m 28s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  2s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

-1 :x:
test4tests
0m  0s
The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ master Compile Tests _

+0 :ok:
mvndep
5m 18s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
16m 27s
master passed

+0
hbaserecompile
28m  2s
HBase recompiled.

+1 :green_heart:
compile
1m 39s
master passed

+1 :green_heart:
checkstyle
5m 27s
master passed

+1 :green_heart:
javadoc
2m  5s
master passed

+0 :ok:
spotbugs
4m 35s
root in master has 1031 extant spotbugs warnings.

+0 :ok:
spotbugs
3m  2s
phoenix-core in master has 972 extant spotbugs warnings.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 16s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
13m 41s
the patch passed

+0
hbaserecompile
20m 18s
HBase recompiled.

+1 :green_heart:
compile
1m 39s
the patch passed

+1 :green_heart:
javac
1m 39s
the patch passed

-1 :x:
checkstyle
5m 31s
root: The patch generated 369 new + 9898 unchanged - 369 fixed = 10267 total (was 10267)

-1 :x:
whitespace
0m  0s
The patch 1 line(s) with tabs.

+1 :green_heart:
xml
0m  3s
The patch has no ill-formed XML file.

+1 :green_heart:
javadoc
2m  3s
the patch passed

+1 :green_heart:
spotbugs
3m  3s
phoenix-core generated 0 new + 704 unchanged - 268 fixed = 704 total (was 972)

+1 :green_heart:
spotbugs
4m 32s
root generated 0 new + 757 unchanged - 274 fixed = 757 total (was 1031)

_ Other Tests _

-1 :x:
unit
114m 27s
root in the patch failed.

-1 :x:
asflicense
1m 50s
The patch generated 613 ASF License warnings.

207m 52s

Reason
Tests

Failed junit tests
phoenix.end2end.index.IndexMetadataIT

phoenix.end2end.index.MutableIndexFailureWithNamespaceIT

phoenix.end2end.CsvBulkLoadToolIT

phoenix.end2end.index.MutableIndexFailureIT

phoenix.end2end.TenantSpecificTablesDDLIT

phoenix.end2end.VariableLengthPKIT

phoenix.end2end.CSVCommonsLoaderIT

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1319/4/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/phoenix/pull/1319

Optional Tests
dupname asflicense javac javadoc unit spotbugs hbaserebuild hbaseanti checkstyle compile xml

uname
Linux bc0706fd6feb 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev/phoenix-personality.sh

git revision
master / c1ffb0b

Default Java
Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08

checkstyle
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1319/4/artifact/yetus-general-check/output/diff-checkstyle-root.txt

whitespace
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1319/4/artifact/yetus-general-check/output/whitespace-tabs.txt

unit
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1319/4/artifact/yetus-general-check/output/patch-unit-root.txt

Test Results
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1319/4/testReport/

asflicense
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1319/4/artifact/yetus-general-check/output/patch-asflicense-problems.txt

Max. process+thread count
14780 (vs. ulimit of 30000)

modules
C: phoenix-core . U: .

Console output
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1319/4/console

versions
git=2.7.4 maven=3.3.9 spotbugs=4.1.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 28s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  1s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

-1 :x:
test4tests
0m  0s
The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ master Compile Tests _

+0 :ok:
mvndep
5m  5s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
16m 36s
master passed

+0
hbaserecompile
28m  5s
HBase recompiled.

+1 :green_heart:
compile
1m 41s
master passed

+1 :green_heart:
checkstyle
5m 29s
master passed

+1 :green_heart:
javadoc
2m  6s
master passed

+0 :ok:
spotbugs
4m 33s
root in master has 1031 extant spotbugs warnings.

+0 :ok:
spotbugs
3m  3s
phoenix-core in master has 972 extant spotbugs warnings.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 16s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
13m 37s
the patch passed

+0
hbaserecompile
20m 34s
HBase recompiled.

+1 :green_heart:
compile
1m 40s
the patch passed

+1 :green_heart:
javac
1m 40s
the patch passed

-1 :x:
checkstyle
5m 31s
root: The patch generated 357 new + 9902 unchanged - 365 fixed = 10259 total (was 10267)

-1 :x:
whitespace
0m  0s
The patch 1 line(s) with tabs.

+1 :green_heart:
xml
0m  3s
The patch has no ill-formed XML file.

+1 :green_heart:
javadoc
2m  3s
the patch passed

+1 :green_heart:
spotbugs
3m  4s
phoenix-core generated 0 new + 718 unchanged - 254 fixed = 718 total (was 972)

+1 :green_heart:
spotbugs
4m 30s
root generated 0 new + 771 unchanged - 260 fixed = 771 total (was 1031)

_ Other Tests _

-1 :x:
unit
115m 25s
root in the patch failed.

-1 :x:
asflicense
1m 53s
The patch generated 613 ASF License warnings.

204m 25s

Reason
Tests

Failed junit tests
phoenix.end2end.PermissionNSEnabledWithCustomAccessControllerIT

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1319/5/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/phoenix/pull/1319

Optional Tests
dupname asflicense javac javadoc unit spotbugs hbaserebuild hbaseanti checkstyle compile xml

uname
Linux e6080b08842c 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev/phoenix-personality.sh

git revision
master / c1ffb0b

Default Java
Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08

checkstyle
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1319/5/artifact/yetus-general-check/output/diff-checkstyle-root.txt

whitespace
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1319/5/artifact/yetus-general-check/output/whitespace-tabs.txt

unit
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1319/5/artifact/yetus-general-check/output/patch-unit-root.txt

Test Results
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1319/5/testReport/

asflicense
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1319/5/artifact/yetus-general-check/output/patch-asflicense-problems.txt

Max. process+thread count
13890 (vs. ulimit of 30000)

modules
C: phoenix-core . U: .

Console output
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1319/5/console

versions
git=2.7.4 maven=3.3.9 spotbugs=4.1.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Thanks for the review @richardantal .
I have cleaned up what you suggested, and hopefully answered your question.


Directory Mode Error Reporting

From the day the domain blablanet.es is register and HUB install nothing is change
$a->config['system']['directory_mode']  = DIRECTORY_MODE_SECONDARY;
But in last Git Pull is reporter is acting us DIRECTORY_MODE_NORMAL
How is that Possible? The only Possible is $a->config['system']['directory_mode']  = DIRECTORY_MODE_SECONDARY; is not working properly and that directive no works

That is ridiculous  http://hubchart.hubzilla.it/hub.jsp?hubFqdn=blablanet.co.il also report directory mode Main Directory and is in .htconfig.php setup from first day us cache directory aslso now few month there and with only 2 users @redmatrix really you can't say now is a problem of a Individual Hub really something here is not clear

You may have it set to secondary in the config file - but this is over-written by what is in the database. You may have "accidentally" set this manually with
util/config system directory_mode 1
and this over-rides your config file. It should be set to 2 for a secondary server.
In any event your site is reporting to the outside world that it is DIRECTORY_MODE_PRIMARY and there is only one primary directory allowed per realm. So if we encounter a site with that setting in the RED_GLOBAL realm (other than zothub.com) we ignore it completely and change it to something safe.

Test Directory Mode in 2 domains one .es have a lot configs but co.il have only few addons activate from first day nothing do there
blablanet.es# util/config system directory_mode
config[system][directory_mode] = 2
blablanet.co.il# util/config system directory_mode
config[system][directory_mode] = 2
Both show UP us secondary Server can you tell me please where I need to look ?
Mysql say:  system	directory_server	https://zothub.com

Here is what your site reports.
https://blablanet.es/siteinfo.json

Ok @redmatrix I agree there say Directory Mode Primary now look https://hubzilla.site/siteinfo.json
SAY directory_mode":"DIRECTORY_MODE_PRIMARY",
https://hubzilla.zottel.net/siteinfo.json
SAY directory_mode":"DIRECTORY_MODE_PRIMARY",
https://hub.pixelbits.de/siteinfo.json
SAY directory_mode":"DIRECTORY_MODE_PRIMARY",
https://my.federated.social/siteinfo.json
SAY NOTHING BUT IS IN THE LIST Page not found.
https://hubzilla.nl/siteinfo.json
SAY directory_mode":"DIRECTORY_MODE_PRIMARY",
@redmatrix really I am missing something ? All say DIRECTORY MODE PRIMARY like me but I am sure I have setup secondary  I am sure util/config system directory_mode return 2
Can we consider all that one BUG

#fixed

Ok Thanks test and working I imagine that solve the seam issue before Christmas I make the Pull request #282 for include again blablanet.es
Request ~281 can be close nothing to do here  . I imagine we can close this issue if not one have something more to say?


esp32: Port the bootloader patch

Summary
currently esp32 protected mode requires a patched bootloader. it's a bit cumbersome to build the bootloader for that purpose.
this commit attempts to remove the need of the patched bootloader by applying the changes by ourselves using esp hal.
Impact
Testing
esp32-devkitc:knsh (with https://github.com/apache/nuttx/pull/13309)

This patch wouldn't work by itself, right? I meant: it would not remove the need of the IDF bootloader, right?
I'm not against getting rid of the IDF/legacy bootloader (in fact, I support that), but I thing the changes necessary to run the knsh with simpleboot must be in this same PR.

This patch wouldn't work by itself, right? I meant: it would not remove the need of the IDF bootloader, right?
I'm not against getting rid of the IDF/legacy bootloader (in fact, I support that), but I thing the changes necessary to run the knsh with simpleboot must be in this same PR.

why?
this patch is to make it work with unpatched bootlooder. it works as far as i tested.
it isn't about simpleboot.

This patch wouldn't work by itself, right? I meant: it would not remove the need of the IDF bootloader, right?
I'm not against getting rid of the IDF/legacy bootloader (in fact, I support that), but I thing the changes necessary to run the knsh with simpleboot must be in this same PR.

why?
this patch is to make it work with unpatched bootlooder. it works as far as i tested.
it isn't about simpleboot.

Hi @yamt ,
This commit does not remove the need for the "patched" bootloader (a.k.a IDF bootloader). See: the legacy bootloader (IDF bootloader) is selected by CONFIG_ESP32_APP_FORMAT_LEGACY, which is selected by default if CONFIG_BUILD_PROTECTED is enabled (the case for esp32-devkitc:knsh).
Also, as I commented in https://github.com/apache/nuttx/issues/13308#issuecomment-2339015822, the HW testing of  the knsh is failing (device panics). I tried applying this patch and the result is the same.
I support/encourage getting rid of the CONFIG_ESP32_APP_FORMAT_LEGACY and use the simpleboot for CONFIG_BUILD_PROTECTED, but this requires reworking the associated linker scripts and testing. This commit does not do that by itself.

This patch wouldn't work by itself, right? I meant: it would not remove the need of the IDF bootloader, right?
I'm not against getting rid of the IDF/legacy bootloader (in fact, I support that), but I thing the changes necessary to run the knsh with simpleboot must be in this same PR.

why?
this patch is to make it work with unpatched bootlooder. it works as far as i tested.
it isn't about simpleboot.

Hi @yamt ,
This commit does not remove the need for the "patched" bootloader (a.k.a IDF bootloader). See: the legacy bootloader (IDF bootloader) is selected by CONFIG_ESP32_APP_FORMAT_LEGACY, which is selected by default if CONFIG_BUILD_PROTECTED is enabled (the case for esp32-devkitc:knsh).
Also, as I commented in #13308 (comment), the HW testing of the knsh is failing (device panics). I tried applying this patch and the result is the same.
I support/encourage getting rid of the CONFIG_ESP32_APP_FORMAT_LEGACY and use the simpleboot for CONFIG_BUILD_PROTECTED, but this requires reworking the associated linker scripts and testing. This commit does not do that by itself.

i don't understand why you insist to associate this PR to simpleboot.
this PR is NOT about simpleboot.
without this PR, we need a patched version of esp-idf bootloader.
with this PR, we can use the plain esp-idf bootloader.
although i'm not sure what exactly you mean by "the HW testing", i tested this on a real board.

This patch wouldn't work by itself, right? I meant: it would not remove the need of the IDF bootloader, right?
I'm not against getting rid of the IDF/legacy bootloader (in fact, I support that), but I thing the changes necessary to run the knsh with simpleboot must be in this same PR.

why?
this patch is to make it work with unpatched bootlooder. it works as far as i tested.
it isn't about simpleboot.

Hi @yamt ,
This commit does not remove the need for the "patched" bootloader (a.k.a IDF bootloader). See: the legacy bootloader (IDF bootloader) is selected by CONFIG_ESP32_APP_FORMAT_LEGACY, which is selected by default if CONFIG_BUILD_PROTECTED is enabled (the case for esp32-devkitc:knsh).
Also, as I commented in #13308 (comment), the HW testing of the knsh is failing (device panics). I tried applying this patch and the result is the same.
I support/encourage getting rid of the CONFIG_ESP32_APP_FORMAT_LEGACY and use the simpleboot for CONFIG_BUILD_PROTECTED, but this requires reworking the associated linker scripts and testing. This commit does not do that by itself.

i don't understand why you insist to associate this PR to simpleboot. this PR is NOT about simpleboot.
without this PR, we need a patched version of esp-idf bootloader. with this PR, we can use the plain esp-idf bootloader.
although i'm not sure what exactly you mean by "the HW testing", i tested this on a real board.

Right, we are probably doing the tests differently: I was unable to build the bootloader and make it work with this patch, please describe how you did it using it. What do you mean by  we can use the plain esp-idf bootloader.?

i built the bootloader (and partition table) in esp-idf directly. (it was a bit ago and i don't remember the exact build proceduce.)
because i haven't built the bootloader using nuttx's "make bootloader", the bootloader i'm using does not have this patch. https://github.com/apache/nuttx/blob/master/arch/xtensa/src/esp32/bootloader/0001-esp32-Connect-Xtensa-Instruction-RAM1-to-Cache.patch
i used "make flash ESPTOOL_BINDIR=./esp/bin ESPTOOL_PORT=/dev/tty.SLAB_USBtoUART" to build and flash nuttx, whele ./esp/bin contains the bootloader and partition table mentioned above.

Thanks for reporting! It's important to make this patch to work within NuttX too. Officially, make bootloader is required to build the legacy bootloader and, by doing that, it would apply the patch you mentioned in the 2nd argument.
After some debugging, I figured out that this PR is able to make it work with some modifications in Bootloader.mk and in the defconfig. I also suggest some minor fixes too. Can you please apply the following patch:

i understand the Bootloader.mk change.
but is the defconfig change related to this PR?

Thanks for reporting! It's important to make this patch to work within NuttX too. Officially, make bootloader is required to build the legacy bootloader and, by doing that, it would apply the patch you mentioned in the 2nd argument.
After some debugging, I figured out that this PR is able to make it work with some modifications in Bootloader.mk and in the defconfig. I also suggest some minor fixes too. Can you please apply the following patch:

i understand the Bootloader.mk change. but is the defconfig change related to this PR?

i applied the bootloader.mk patch.
i guess the defconfig one warrants another PR.


fix: Host Player Ready Race Condition

readyConnection needs to be completed before sending ReadyMessage.
In master we have this in ClientScene.Ready
conn.Send(new ReadyMessage());
ready = true;
readyConnection = conn;
readyConnection.isReady = true;

This is fine for remote clients because by the time the server round-trips the lines after the Send have executed, however for Host client, the Send goes straight through to ClientScene.InternalAddPlayer and fails for a null readyConnection.
To reproduce the fault in master:
Create an empty scene with an empty game object with a custom Network Manager with the code below and the HUD and Telepathy, and assign any appropriate prefab to the playerPrefab field and uncheck Auto Create Player, and play as Host:
public class NetManager : NetworkManager
{
    public override void OnServerReady(NetworkConnection conn)
    {
        base.OnServerReady(conn);
        base.OnServerAddPlayer(conn);
    }
}

You'll get the following warning in the console, and the player won't be spawned:
No ready connection found for setting player controller during InternalAddPlayer
UnityEngine.Debug:LogWarning(Object)
Mirror.ClientScene:InternalAddPlayer(NetworkIdentity) (at Assets/Mirror/Runtime/ClientScene.cs:87)
Mirror.NetworkServer:AddPlayerForConnection(NetworkConnection, GameObject) (at Assets/Mirror/Runtime/NetworkServer.cs:832)
Mirror.NetworkManager:OnServerAddPlayer(NetworkConnection) (at Assets/Mirror/Runtime/NetworkManager.cs:1302)
ReadyTest.NetManager:OnServerReady(NetworkConnection) (at Assets/ReadyTest/NetManager.cs:17)
Mirror.NetworkManager:OnServerReadyMessageInternal(NetworkConnection, ReadyMessage) (at Assets/Mirror/Runtime/NetworkManager.cs:1120)
Mirror.<>c__DisplayClass7_0`1:<MessageHandler>b__0(NetworkMessage) (at Assets/Mirror/Runtime/MessagePacker.cs:164)
Mirror.NetworkConnection:InvokeHandler(Int32, NetworkReader, Int32) (at Assets/Mirror/Runtime/NetworkConnection.cs:308)
Mirror.NetworkConnection:TransportReceive(ArraySegment`1, Int32) (at Assets/Mirror/Runtime/NetworkConnection.cs:361)
Mirror.ULocalConnectionToServer:Send(ArraySegment`1, Int32) (at Assets/Mirror/Runtime/LocalConnections.cs:69)
Mirror.NetworkConnection:Send(ReadyMessage, Int32) (at Assets/Mirror/Runtime/NetworkConnection.cs:219)
Mirror.ClientScene:Ready(NetworkConnection) (at Assets/Mirror/Runtime/ClientScene.cs:185)
Mirror.NetworkManager:OnClientConnect(NetworkConnection) (at Assets/Mirror/Runtime/NetworkManager.cs:1381)
Mirror.NetworkManager:OnClientAuthenticated(NetworkConnection) (at Assets/Mirror/Runtime/NetworkManager.cs:1200)
Mirror.NetworkManager:OnClientConnectInternal(NetworkConnection, ConnectMessage) (at Assets/Mirror/Runtime/NetworkManager.cs:1183)
Mirror.<>c__DisplayClass7_0`1:<MessageHandler>b__0(NetworkMessage) (at Assets/Mirror/Runtime/MessagePacker.cs:164)
Mirror.NetworkConnection:InvokeHandler(Int32, NetworkReader, Int32) (at Assets/Mirror/Runtime/NetworkConnection.cs:308)
Mirror.NetworkConnection:TransportReceive(ArraySegment`1, Int32) (at Assets/Mirror/Runtime/NetworkConnection.cs:361)
Mirror.ULocalConnectionToServer:Update() (at Assets/Mirror/Runtime/LocalConnections.cs:81)
Mirror.NetworkClient:Update() (at Assets/Mirror/Runtime/NetworkClient.cs:279)
Mirror.NetworkManager:LateUpdate() (at Assets/Mirror/Runtime/NetworkManager.cs:271)

nice fix @MrGadget1024


Add chinese local adapter

For the issue https://github.com/alpheios-project/components/issues/843

added AlpheiosChineseLocAdapter
added local ChineseSource for retrieving data from json
register it to ClientAdapters
added unit tests

Should be merged with
https://github.com/alpheios-project/data-models/pull/88

I'm really sorry for multiple comments. GitHub was having issues and I was trying to hit refresh as they advised on their error page 🙂. Now all of this is a result of that. Looks like there is no way to remove them 🙁. This is embarrassing.

I think, as I resolve all review's comments - I will merge it to master!

Pull Request Test Coverage Report for Build 252

188 of 209 (89.95%)  changed or added relevant lines in 4 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.5%) to 85.957%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

src/adapters/chineseloc/adapter.js
54
55
98.18%

src/adapters/tufts/adapter.js
1
2
50.0%

src/client-adapters.js
0
6
0.0%

src/adapters/chineseloc/chinese-source/chinese-source.js
133
146
91.1%

Totals

Change from base Build 245:
-0.5%

Covered Lines:
2763

Relevant Lines:
3078

💛  - Coveralls


Allow Geometry Columns and Differing SRID

Can you please make sure all tests are passing?
Also, can you turn GEOGRAPHY and GEOMETRY into const values (perhaps on the blueprint?) To avoid the possibility or spelling errors.

Not sure why the tests are failing – will investigate.
Not quite sure what you mean by turning the GEOMETRY and GEOGRAPHY in to constants. Could you give me an example or point me in the right direction?
Thanks
Steve
From: Peter Haza<EMAIL_ADDRESS>Sent: 14 January 2016 14:09
To: phaza/laravel-postgis
Cc: Steve Goddard
Subject: Re: [laravel-postgis] Allow Geometry Columns and Differing SRID (#34)
Can you please make sure all tests are passing?
Also, can you turn GEOGRAPHY and GEOMETRY into const values (perhaps on the blueprint?) To avoid the possibility or spelling errors.
—
Reply to this email directly or view it on GitHubhttps://github.com/phaza/laravel-postgis/pull/34#issuecomment-171653284.

Ok - got the tests all passing fine locally. They are failing on github with an error that appears to be with the Bosnadev package:
1) ConnectionFactoryBaseTest::testMakeCallsCreateConnection
Declaration of Bosnadev\Database\Connectors\ConnectionFactory::createConnection() should be compatible with Illuminate\Database\Connectors\ConnectionFactory::createConnection($driver, $connection, $database, $prefix = '', array $config = Array)

Any ideas??
I've done some more reading on constants. It seems a lot of complexity when a in_array check (which is what currently happens) might be quicker and simpler? But maybe I'm overcomplicating things?

Will cancel this and try again with a version 2 branch.


set_charging_amps failing from evcc with tesla template with commandProxy

Starting testing https://github.com/evcc-io/evcc/pull/14616 with the docker image provided by evcc maintainer (https://hub.docker.com/layers/evcc/evcc/tesla/images/sha256-7e6d75f3a55a8c02076bf0745dbfd0f698f434258cdc4c59ee6ce38a5ea0fb32?context=explore):
Command set_charging_amps is not coming through:
2024/06/30 12:54:53 ERRO The command was canceled. command=set_charging_amps err="charing Amps missing in body"
As I understand it @wimaha, this seem to be an issue of this proxy as evcc is just sending the same requests but to your proxy instead of evcc one, right ?

What is the body in the logs? It should be printed in the line with received command.

Ok, here is the trace log from evcc:
[tesla ] TRACE 2024/06/30 15:00:32 POST http://192.168.X.Y:8080/api/1/vehicles/YYYYYYYY/command/set_charging_amps
[tesla ] TRACE 2024/06/30 15:00:32 {"charging_amps": 1}
--
{"response":{"result":true,"reason":"The command was successfully received and will be processed shortly.","vin":"YYYYYY","command":"set_charging_amps"}}
[lp-1  ] ERROR 2024/06/30 15:00:32 max charge current 1A: 201 Created

From what I understand, the body is thus in JSON: {"charging_amps": 1}, which by the way is consistent with the docs https://developer.tesla.com/docs/fleet-api#set_charging_amps.

So I think the issue is that your code is expecting a string and not directly an for charging_amps !
In other words, it works when sending {"charging_amps": "1"}  but fails with {"charging_amps": 1} .

In the docs is stated "charging_amps": "integer"
So I think expecting a string is correct, because integer is here integrated in a string.
Anyway I will make an update so that integer are also accepted.

Seems cleaner anyway to sent a « pure » int instead of wrapping it up inside a string.

Fixed with 1.0.4 🙂

Nice! I can confirm that the set_charging_amp command from EVCC is now properly executed!


PyroFishing still has a bug that disables fisherman job.

*Detailed description of the issue:
If I fishing on a server with PyroFishing, Jobs Reborn's fisherman level still doesn't go up and income won't be paid.
and Jobs <IP_ADDRESS> update note says "Fix for PyroFishing compatibility breaking regular fishing".
below, my jobs version info in server.
------------------------------------------------
Jobs: <IP_ADDRESS> SqLite-> <IP_ADDRESS>
CMILib: <IP_ADDRESS> -> <IP_ADDRESS>
Server: 2218 1.20.6-R0.1-SNAPSHOT
Economy: CMIEconomy Vault: 1.7.3-CMI
------------------------------------------------

ERROR (DELETE IF YOU HAVE NO ERROR):
<-- Try to use pastebin.com server if you have long error. -->
####################
## PASTE ERROR HERE ##
####################

CONFIG SECTION (DELETE IF NOT RELEVANT):
#####################################
## PASTE RELEVANT CONFIG SECTION HERE ##
#####################################

Jobs version: <IP_ADDRESS>
Server Type (Spigot/Paper/etc): Purpur(forked of Paper)
Server Version (using /ver): 1.20.6-2218-ec1b4fa (MC: 1.20.6)
Relevant plugins (Delete if this isn't needed): PyroFishingPro

Sorry, I didn't know that I have to custom settings.

Okay, this seems to work for me with .1 of jobs
  # Catching CUSTOM fish of the PyroFishingPro plugin
  PyroFishingPro:
    CustomTier:
      income: 5.0
      points: 5.0
      experience: 7.0
    Bronze:
      income: 5.0
      points: 5.0
      experience: 7.0
    Gold:
      income: 5.0
      points: 5.0
      experience: 7.0
    Silver:
      income: 5.0
      points: 5.0
      experience: 7.0
    Diamond:
      income: 5.0
      points: 5.0
      experience: 7.0
    Platinum:
      income: 5.0
      points: 5.0
      experience: 7.0
    Mythical:
      income: 5.0
      points: 5.0
      experience: 7.0


Add integration test for Bijectors

We should perform similar tests in https://github.com/EnzymeAD/Enzyme.jl/pull/2037 for Mooncake.
@mhauru, can you copy the tests over?

Thanks Markus -- extra integration tests are always welcome!

On this -- if you find failing tests, please don't worry about fixing them. We can just find a good way to mark them as failing, and open an issue which says "fix failing Bijectors.jl integration tests"


Support downloading FileAttachment annotations with the keyboard

While reviewing PR #16898 it occurred to me that it's currently impossible to trigger downloading of FileAttachment annotations using the keyboard.
Hence this patch adds Ctrl + Enter as the keyboard shortcut to download those, thus supplementing the existing double-clicking when using a mouse.

/botio test


Add modules to concepts.md

Adding a figure can also be helpful although modules are not that abstract.
Signed-off-by: GuessWhoSamFoo<EMAIL_ADDRESS>

Pull Request Test Coverage Report for Build 1052

0 of 0   changed or added relevant lines in 0 files are covered.
92 unchanged lines in 2 files lost coverage.
Overall coverage increased (+0.6%) to 71.731%

Files with Coverage Reduction
New Missed Lines
%

pkg/cluster/apply.go
33
43.61%

pkg/cluster/merger.go
59
45.37%

Totals

Change from base Build 1040:
0.6%

Covered Lines:
10708

Relevant Lines:
14928

💛  - Coveralls


Inconsistent/missing output with iPython

I'm having some trouble with output objects being overwritten in iPython Beaker notebooks. For example the following code snippet will only show the second figure and delete the first one after briefly showing it:
figure(), plot( linspace( 0, -1)), title( 'Figure 1')
figure(), plot( linspace( 0,  1)), title( 'Figure 2')
This could also be seen as a feature, meaning that I can create dynamically updating plots, but when opening a new figure I would have expected the old plot to persist and not get replaced.
Along the same lines, and more worryingly, the following code produces a different output every time it is run. It sometimes shows one player, sometimes two, but never three or all four, with the first ones being overwritten in the output:
from IPython.display import display, Audio
print "sound 1", display( Audio( data=sin( 100*linspace( 0, 2*pi, 8000)), rate=8000))
print "sound 2", display( Audio( data=sin( 200*linspace( 0, 2*pi, 8000)), rate=8000))
print "sound 3", display( Audio( data=sin( 300*linspace( 0, 2*pi, 8000)), rate=8000))
print "sound 4", display( Audio( data=sin( 400*linspace( 0, 2*pi, 8000)), rate=8000))
If I add a 1 second pause between these calls then only the last audio player is shown. If I remove the print statements all four are shown. So there seems to be a timing threshold after which previous output objects are replaced.
Just as before, being able to replace outputs can be a desirable trait, but I would have preferred to have control on which outputs are expendable and which should persist.
This is all on a Mac running the latest release version (and also the prerelease).

Thanks for the detailed report Paris, much appreciated.
We'll get right on this.

OK, looks like this has already been fixed.  I get this reliably from master: https://pub.beakernotebook.com/#/publications/5602f1b7-21e1-43e6-ab6c-19b8b72019a9?fullscreen=true
and i can confirm that with 1.3.4 I see the same bug that you do.
1.4 will be released at the end of the month, or you can get a prerelease:
http://beakernotebook.com/downloads

The problem seems to persist in 1.4 as well (albeit in a different form).
For example it the following code I get an audio player and a figure (ignore the error in the audio player, it's because I don't give it any data):
from IPython.display import display, Audio

display( Audio( [1], rate=8000))
subplot( 1, 2, 1), plot( [0,1])

#display( Audio( [1], rate=8000))
#subplot( 1, 2, 2), plot( [0,1])

Case 1: As it, it will present an audio player and a plot.
Case 2: If I add a  time.sleep(.5) between the audio player and the plot lines, only the plot appears. The expected behavior would be to show both.
Case 3: If I uncomment the last two lines, neither of the requested audio players appear (regardless of the existence of a sleep statement or not). The expected behavior would be to see two audio players and two plots.
In the latter cases, the audio players are momentarily visible, but they get overwritten by the plots when they are drawn.

Thanks for your persistence reporting bugs :)  I'll look at this soon.

just got this on master.  the slider flashed & was replaced by the graph.

Hello, @psmaragdis . Please, try to run you tests on this dist

I can't seem to get the web browser to connect to this binary. Any idea why?
I exported as a Mac Application, but when launch it and go to <IP_ADDRESS>:8801/beaker/ there's nothing to load (unlike other beaker binaries which present me with the initial page)

@psmaragdis, you have to perform next steps to launch the application:

open xcarchive in Finder
right click -> choose Show Package Contents
go to Products -> Applications
dbl click on Beaker application - it should present page in browser

It looks like this build is missing the jre files in the resources (hence not launching).

Have you opened http://<IP_ADDRESS>:8801/beaker/#/control in browser after steps above?

Looks like it was a problem with that one machine I was running it on. It launches, but it still doesn't behave predictably. The example with the four sound players at the start of the thread is fine, but if do:
figure(), plot( linspace( 0, -1)), title( 'Figure 1')
figure(), plot( linspace( 0, 1)), title( 'Figure 2')

I only get the second figure to show but not the first. If I do:
from IPython.display import display, Audio
figure(), plot( linspace( 0, -1)), title( 'Figure 1')
print "sound 1", display( Audio( data=sin( 100*linspace( 0, 2*pi, 8000)), rate=8000))
figure(), plot( linspace( 0, 1)), title( 'Figure 2')
print "sound 2", display( Audio( data=sin( 200*linspace( 0, 2*pi, 8000)), rate=8000))

I sometimes get both figures, most of the time I get the second figure only, but I never get the sound players (the briefly show up and then the output is cleared for the second figure).
If I add time.sleep(1) between all the lines I get the first sound player to show up, then it gets erased and the second sound player renders, then the second player gets erased, and then I get both figures.

Just to verify, this is not resolved, right?

it is no longer relevant due to http://us3.campaign-archive1.com/?u=d05838b85c905bc618b25e5a9&id=bf9c4bb414&e=49f86b7c29


BUG Allowed: min 1 max 3 step 1

Hi,
when try to start a program on my HWPD 69AMBC/1-S (washing machine) an error occured:
Allowed: min 1 max 3 step 1
when integration set the defaults params values:
/config/custom_components/hon/device.py::start_command()
...
self.update_command(command, self.attributes["parameters"])
...

The fix is to use a min value instead trow the error here:
/config/custom_components/hon/parameter.py::106
...
raise ValueError(f"Allowed: min {self._min} max {self._max} step {self._step}")
...
to
...
self._value = self._min
...

just to understand, how do you start the program ? because normally they all have default values that match with what is expected

I checked and I cannot do the modification because  this piece of code is used in a lot of context (like setting the temperature).
I've added one log to understand the value passed.
How do you start the program ?

I'm having the same issue with my HD 496AMBCB/1-80 washer dryer (otherwise working well).
I've set up a button to perform the action as such:
show_name: true
show_icon: true
type: button
tap_action:
  action: perform-action
  perform_action: hon.start_program
  data:
    program: low_dry
  target:
    device_id: <my_device_id>
icon: mdi:tumble-dryer
layout_options:
  grid_columns: 1
  grid_rows: 2
name: Low heat dry
show_state: true

I am guessing that this should be using the default values:
delayTime: [0 - 1410] - Default: 0 - Step: 30
dryLevel: [1, 3, 4] - Default: 4
dryTime: [1 - 4] - Default: 1 - Step: 1
lang: [0 - 25] - Default: 1 - Step: 1
However, even if I specify the parameters such as:
 data:
    program: low_dry
    parameters: >-
      {'delayTime':0,'dryLevel':4,'dryTime':1,'lang':1}

I still get the following error:
Failed to perform the action hon/start_program. Value [0] - Allowed: min 1 max 4 step 1

Any idea what might cause this? Let me know if you need more info @gvigroux


Web UI don't lunch

Hello @madchicken I did clean install of Your plugin - version 2.1, I cleared the accessories cache. The Web UI don't work on any port. I restart the raspberry and Homebridge few times - but it didn't help, also I don't see any error in logs.
[3/1/2021, 9:53:02 PM] [ZigBee] Successfully started ZigBee service
[3/1/2021, 9:53:02 PM] [ZigBee] ZigBee platform initialized @ 0x00124b0014da2968

@piokacz Can you try v2.1.2? I added some log to debug this issue

Hello @madchicken , many thanks that your plugin works via homebridge interface - now I can install it without the need to buid it from the source.
My version of plugin:
homebridge-zigbee-nt v2.1.2
my logs after homebridge restart:
[3/3/2021, 10:23:04 PM] [ZigBee] Successfully started ZigBee service
[3/3/2021, 10:23:04 PM] [ZigBee] ZigBee platform initialized @ 0x00124b0014da2968
[3/3/2021, 10:23:04 PM] [ZigBee] Reuse accessory from cache with uuid 6895c160-ba25-497f-b805-38071c751c56 and name zigbee:permit-join
[3/3/2021, 10:23:04 PM] [ZigBee] Zigbee: disabling joining new devices.
[3/3/2021, 10:23:04 PM] [ZigBee] PermitJoin accessory successfully registered
[3/3/2021, 10:23:04 PM] [ZigBee] Reuse accessory from cache with uuid 4994893c-ea77-4292-a4ad-09e1f36f7099 and name zigbee:touchlink
[3/3/2021, 10:23:04 PM] [ZigBee] TouchLink accessory successfully registered
[3/3/2021, 10:23:04 PM] [ZigBee] Initializing ZigBee device: 0x086bd7fffec995f1 - RH3040 - TUYATEC-e4wp7oyu
[3/3/2021, 10:23:04 PM] [ZigBee] Reuse accessory from cache with uuid 4d997f57-ab72-4b46-bab6-f4b58d1df573 and name 0x086bd7fffec995f1
[3/3/2021, 10:23:04 PM] [ZigBee] Successfully auto discovered device: 0x086bd7fffec995f1, PIR sensor
[3/3/2021, 10:23:04 PM] [ZigBee] Registered device: 0x086bd7fffec995f1 TUYATEC-e4wp7oyu RH3040
[3/3/2021, 10:23:04 PM] [ZigBee] Mounting device 0x086bd7fffec995f1...
[3/3/2021, 10:23:04 PM] [ZigBee] Initializing ZigBee device: 0xbc33acfffed7e1b2 - TRADFRI motion sensor - IKEA of Sweden
[3/3/2021, 10:23:04 PM] [ZigBee] Reuse accessory from cache with uuid c2745d52-7755-417b-afe7-8f89cd8f8fb7 and name 0xbc33acfffed7e1b2
[3/3/2021, 10:23:04 PM] [ZigBee] Found class for device with key IKEA of Sweden:TRADFRI motion sensor
[3/3/2021, 10:23:04 PM] [ZigBee] Registered device: 0xbc33acfffed7e1b2 IKEA of Sweden TRADFRI motion sensor
[3/3/2021, 10:23:04 PM] [ZigBee] Mounting device 0xbc33acfffed7e1b2...
[3/3/2021, 10:23:04 PM] [ZigBee] Initializing ZigBee device: 0x60a423fffe029b7b - RH3052 - TUYATEC-yg5dcbfu
[3/3/2021, 10:23:04 PM] [ZigBee] Reuse accessory from cache with uuid 848737fa-56a0-41bd-bc63-b2bec685cd05 and name 0x60a423fffe029b7b
[3/3/2021, 10:23:04 PM] [ZigBee] Successfully auto discovered device: 0x60a423fffe029b7b, Temperature & humidity sensor
[3/3/2021, 10:23:04 PM] [ZigBee] Registered device: 0x60a423fffe029b7b TUYATEC-yg5dcbfu RH3052
[3/3/2021, 10:23:04 PM] [ZigBee] Mounting device 0x60a423fffe029b7b...
[3/3/2021, 10:23:04 PM] [ZigBee] Initializing ZigBee device: 0x60a423fffe2cd0e5 - RH3052 - TUYATEC-yg5dcbfu
[3/3/2021, 10:23:04 PM] [ZigBee] Reuse accessory from cache with uuid 982243fc-936f-4965-b6c8-df3228a98a37 and name 0x60a423fffe2cd0e5
[3/3/2021, 10:23:04 PM] [ZigBee] Successfully auto discovered device: 0x60a423fffe2cd0e5, Temperature & humidity sensor
[3/3/2021, 10:23:04 PM] [ZigBee] Registered device: 0x60a423fffe2cd0e5 TUYATEC-yg5dcbfu RH3052
[3/3/2021, 10:23:04 PM] [ZigBee] Mounting device 0x60a423fffe2cd0e5...
[3/3/2021, 10:23:04 PM] [ZigBee] Initializing ZigBee device: 0xbc33acfffe3313b6 - TS0041 - _TZ3400_keyjqthh
[3/3/2021, 10:23:04 PM] [ZigBee] Reuse accessory from cache with uuid 09ac29ce-8b1d-4375-8e76-3feaaacfbb88 and name 0xbc33acfffe3313b6
[3/3/2021, 10:23:04 PM] [ZigBee] Successfully auto discovered device: 0xbc33acfffe3313b6, Wireless switch with 1 button
[3/3/2021, 10:23:04 PM] [ZigBee] Registered device: 0xbc33acfffe3313b6 _TZ3400_keyjqthh TS0041
[3/3/2021, 10:23:04 PM] [ZigBee] Mounting device 0xbc33acfffe3313b6...
[3/3/2021, 10:23:04 PM] [ZigBee] Initializing ZigBee device: 0x5c0272fffedb0f19 - TS0601 - _TZE200_2dpplnsn
[3/3/2021, 10:23:04 PM] [ZigBee] Reuse accessory from cache with uuid 3030368a-f9a0-4511-ac6d-d8250e763e8c and name 0x5c0272fffedb0f19
[3/3/2021, 10:23:04 PM] [ZigBee] Found class for device with key _TZE200_2dpplnsn:TS0601
[3/3/2021, 10:23:04 PM] [ZigBee] Entity '[object Object]' is unknown
[3/3/2021, 10:23:04 PM] [ZigBee] Initializing ZigBee device: 0x847127fffe93fcfe - TS0601 - _TZE200_ckud7u2l
[3/3/2021, 10:23:04 PM] [ZigBee] Reuse accessory from cache with uuid eb7068c3-a24a-41a7-b800-32a2e1c8fb04 and name 0x847127fffe93fcfe
[3/3/2021, 10:23:04 PM] [ZigBee] Found class for device with key _TZE200_ckud7u2l:TS0601
[3/3/2021, 10:23:04 PM] [ZigBee] Registered device: 0x847127fffe93fcfe _TZE200_ckud7u2l TS0601
[3/3/2021, 10:23:04 PM] [ZigBee] Mounting device 0x847127fffe93fcfe...
(node:3565) UnhandledPromiseRejectionWarning: AssertionError [ERR_ASSERTION]: ZigBee Entity resolution failed
    at new ZigBeeAccessory (/usr/lib/node_modules/homebridge-zigbee-nt/src/accessories/zig-bee-accessory.ts:70:11)
    at new TuyaThermostatControl (/usr/lib/node_modules/homebridge-zigbee-nt/src/accessories/tuya/tuya-thermostat-control.ts:6:1)
    at Object.createAccessoryInstance (/usr/lib/node_modules/homebridge-zigbee-nt/src/registry.ts:87:14)
    at ZigbeeNTHomebridgePlatform.<anonymous> (/usr/lib/node_modules/homebridge-zigbee-nt/src/platform.ts:286:32)
    at Generator.next (<anonymous>)
    at /usr/lib/node_modules/homebridge-zigbee-nt/dist/platform.js:27:71
    at new Promise (<anonymous>)
    at __awaiter (/usr/lib/node_modules/homebridge-zigbee-nt/dist/platform.js:23:12)
    at ZigbeeNTHomebridgePlatform.initDevice (/usr/lib/node_modules/homebridge-zigbee-nt/dist/platform.js:218:16)
    at /usr/lib/node_modules/homebridge-zigbee-nt/src/platform.ts:224:68
(node:3565) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). To terminate the node process on unhandled promise rejection, use the CLI flag `--unhandled-rejections=strict` (see https://nodejs.org/api/cli.html#cli_unhandled_rejections_mode). (rejection id: 3)
(node:3565) [DEP0018] DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js process with a non-zero exit code.

Ok, we need to remove your thermostat from supported devices, since is not recognised by the herdsman lib, as you can see from the two lines of logs:
[ZigBee] Found class for device with key _TZE200_2dpplnsn:TS0601
[ZigBee] Entity '[object Object]' is unknown

To support it, we need to wait that it is added to supported devices in zigbee-herdsman-converters project.
I'll push a new version without the thermostat support so you can start the plugin

Hello @madchicken, this thermostat is paired with the dongle, but it's not present in the network - I just borrowed it for a while. Without the Web UI i cannot unpair the device - maybe this is the problem?

Yes, it is the problem. Stay tuned, I'll push a new version soon, so you can use again the WEB UI

Oh wait! They just added it https://github.com/Koenkk/zigbee2mqtt/issues/6088
Let me see if we can support it

Hi, I saw You [Fix] Dismiss support for _TZE200_ckud7u2l TS0601 thermostat (#133), but my thermostat _TZE200_ckud7u2l TS0601 works fine and the other one _TZE200_2dpplnsn', ['TS0601'] is not present in my network write now

Thanks for pointing that our, sorry for the confusion, I fixed the PR

Hi @madchicken , in wersion 2.1.3 it's working:
[3/4/2021, 4:15:56 PM] [ZigBee] Starting WEB UI on port 9000, host is set to <IP_ADDRESS>
[3/4/2021, 4:15:56 PM] [ZigBee] WebSocket server started @ null
[3/4/2021, 4:15:56 PM] [ZigBee] WEB UI Listening on port 9000


Minor edits for grammar

Details of the Pull Request
For grammar and style.

Also, thanks for keeping Roy's work around!


xgboost4j-spark inconsistency in maxBin/maxBins param name

Should the param name here really be maxBins?
https://github.com/dmlc/xgboost/blob/b53a5a262c74987d85c54fd3d41bc6d28e5e1d60/jvm-packages/xgboost4j-spark/src/main/scala/ml/dmlc/xgboost4j/scala/spark/params/BoosterParams.scala#L158-L159

no, we need to respect xgboost native layer (https://xgboost.readthedocs.io/en/latest/parameter.html) to make a correct conversion between underscore-style and camel case


port to ng12 with new gongc

Problem while trying to compile the imported gong library

Error: projects/gong/src/lib/gong.module.ts:129:11 - error NG1010: Value at position 23 in the NgModule.imports of GongModule is not a reference
  Value could not be determined statically.

129  imports: [
              ~
130     FormsModule,
    ~~~~~~~~~~~~~~
...
160     AngularSplitModule,
    ~~~~~~~~~~~~~~~~~~~~~
161  ],

datatimepicker not installed


For better typescript definitions, addCustomSetters() method might be the problem?

I was playing around with the types, and I found that if I set the custom setters in the constructor instead of the method, then the typing utilities worked perfectly!
Here's an example of the issue I was facing. Take this code and put it into a typescript
import Spiccato from '../src/index'

type Track = {
  id: number
  position: number[]
  name: string
}

type Store = {
  trackKeys: Set<number>
  tracksById: Record<string, Track>
}

const store: Store = {
  trackKeys: new Set([]),
  tracksById: {}
}

export const trackManager = new Spiccato(store, {
  id: 'tracks',
  enableWriteProtection: false
})

trackManager.init()
trackManager.addCustomSetters({
  setTrack(track: Track) {
    this.setState((prevState: Store) => {
      prevState.trackKeys.add(track.id)
      prevState.tracksById[track.id] = track

      return prevState
    })
  }
})

// HERE! Typescript throws an error, saying that `Property 'setTrack' does not exist on type {}`
trackManager.setters.setTrack({
  id: 1,
  position: [0, 0],
  name: 'Track 1'
})

This got me thinking, if Redux can do it so can Spiccato. And it should be able to infer all types from all methods defined in the custom setters!
I put together a simpler set of class code, as a test to see if I can get the typescript bindings to work. I found that if I have them set from the constructor directly, then typescript can infer those types.
type GetterMethod = (...args: any[]) => any;

class Testy<CustomGetters extends Record<string, GetterMethod> = {}> {
  public getters: CustomGetters;

  constructor(getters: CustomGetters) {
    this.getters = getters;
  }
}

const testy = new Testy({
  addCount: (addFirst: number, addSecond: number) => {
    return addFirst + addSecond;
  },
  subtractCount: (subFirst: number, subSecond: number) => {
    return subFirst - subSecond;
  }
});

// Now TypeScript knows the available methods on getters
testy.getters.addCount(1, 2); // This works
testy.getters.subtractCount(5, 3); // This works

This is making me conclude that Typescript cannot add more types after the class has already been defined?
I think the core issue here is that more types are being added after the class has been created, and typescript will only show types that exist upon creation.
Now on the other hand, we could also have a type for all CustomGetters as I believe you've already done, however that's a lot of custom type defintions that could be inferred automatically upon creation.
**My recommendation: **
Remove the "addCustomSetters" method and "addCustomGetters" methods.
Shouldn't all custom setters and getters be defined when the Spiccato manager is defined? I'm struggling to think of a scenario where Spiccato custom setters would be set after init().
I also think that all dynamically generated setters/getters could also be generated in the constructor, which would then also enable all of those typescript types to be automatically generated too.
As a bonus of removing these, it would remove the possibility of calling these methods before "init"

Yes, I think the ideal solution would be to have TS infer the types of all these. This was something I tried to get going in several different ways, but I always came back to one issue. This only works if you supply the getters/setters/methods in the constructor as you've said. But specifically, it will only work if you apply those within the same scope as the initialize call on the spiccato instance.
Take this as an example - imagine a slightly different class definition whey you supply your getters/setters/methods as arguments:
manager = new Spiccato({
    customGetter(){
        this.methods.someCustomMethod() // 'this' can be inferred in this context
    }.
   // other setters and methods here
})

That all works. But one of the fundamental ideas that I had when designing this (and one of the ways I use this on a daily basis) is to be able to use the file use the file system to help logically separate getter, setter, and method functionality. The funcionality I display in the docs is very simple, but in practice, these custom functions can be very complex, and run for dozens to hundreds of lines. If you have to define them all in the same file, that becomes unmanageable at scale.
So imagine you have some custom function you define in another file. If you try to access the this keyword in that function, you would have to explicitly define what this refers to get type safety.  So you need a type that defines the signature of this. And if you have that, then you technically need to have types for State, Getters, Setters, Methods, and NamepsacedMethods in that context so you could access this.setters, for example.
This organization pattern is covered in the 1.0.2-beta branch. Use the CLI to generate the file structure for the state resource, and you'll see the whole scope of that pattern. It is more verbose, but does get the functionality to work in a way that allows for defining these things in an organized way between several files.
your comment aboutinitializing with custom setters/getters before init is right on. There is a reason that it's done this way right now (if you add them before init, it will not allow you to override dynamic setters/getters with custom functionality). But I think you're right. That should be changed to allow for init to be called after.

the issues with calling init() after addCustomGetters and addCustomSetters has been resolved in the release-1.0.4-beta branch. Will close this issue with a PR when we merge the beta line of branches into main.


Fix settings

@geoperez I have not tested (I could do it on monday), after reading code, some remarks :

i think RecaptchaPrivateKey should be move to Recaptcha node below SiteKey and renamed PrivateKey, why do you have added [JsonIgnore] ?
line 67 of Startup.cs it should be "if DEBUG" and not "if !DEBUG"
perhaps the properties "LdapHostnames", "LdapPort", "LdapUsername", "LdapPassword" and "DefaultDomain" should be moved below the properties for the two providers. I think it will be more clear and the comment for UseAutomaticContext will be correct (it says that the credentials are below but for the moment they are above).

Thanks for the work !
It's not related to issue 221 but when I have done my testing, i noted a small issue : after changing with success a password, there id two confirmation dialog : the first is empty with juste the Ok button and the second with the right title and body. I don't know anything to angular so I can't help you but if you could take a look...
Regards

@ben-ty I applied your suggestions. Let me know if it's working for you.

Status?

Hi @geoperez , i have done some adjustments (file attached) :

Remove unused HelpTitle property and re add ChangePasswordTitle (used in change-password.html),
Incorrect log output : log.AddConsole and log.AddDebug are already called by WebHost.CreateDefaultBuilder and it result in duplicate or mangled logs

My tests are ok :)
Archive.zip

I just applied your suggestions.


ATV-37 | Fetch Documents for authenticated users

Description :sparkles:

Allow for authenticated users to fetch their own documents

The filter for allowed Docuemnts is done on the get_queryset level, so when the list method is called, it only allows for the specific subset of Documents plus the login_required

Add small tweaks to Django Admin to make it easier which user is associated to a lease

Issues :bug:
Closes :no_good_woman:
ATV-37: As an authenticated user I want to filter and sort my diploma copy requests to find a specific request easily
Related :handshake:

https://helsinkisolutionoffice.atlassian.net/browse/ATV-36
#15
#20

Codecov Report

Merging #24 (7daf348) into main (9811024) will decrease coverage by 1.10%.
The diff coverage is 80.00%.

@@            Coverage Diff             @@
##             main      #24      +/-   ##
==========================================
- Coverage   82.12%   81.01%   -1.11%
==========================================
  Files          45       45
  Lines         962      964       +2
  Branches       88       88
==========================================
- Hits          790      781       -9
- Misses        141      155      +14
+ Partials       31       28       -3

Impacted Files
Coverage Δ

users/models.py
80.00% <50.00%> (-20.00%)
:arrow_down:

documents/admin.py
81.25% <100.00%> (ø)

documents/api/viewsets.py
82.35% <100.00%> (ø)

atv/decorators.py
73.77% <0.00%> (-16.40%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9811024...7daf348. Read the comment docs.


Added optional choice for hdfs clients

Description
Added optional choice for hdfs clients. Previously only InsecureClient was supported. This PR adds KerberosClient and TokenClient.
Motivation and Context
Some hdfs work with kerberos authentication. Mine does... This adds support for those clusters.
This fixes #2481.
Have you tested this? If so, how?
I have tested the KerberosClient in practice and it works! (Thousand times faster than hadoopcli :) )
Not tested the TokenClient though, because I do not have access to a Hadoop cluster with token authentication.

Only adding KerberosClient now.
And I've added some really basic test. Don't know what your standards are, so if you have any specific test in mind let me know.
Also changed Parameter to ChoiceParameter. This removed the need for the ValueError is the else clause, so now I made InsecureClient the default in the else clause.
In the next couple of days I will test this code in a couple of projects.

(Y)(Y)

👍 👍

Thanks for reporting back @pietermarsman ! Glad to hear things functioning as expected


shims: correct __swift_mode_t for android-aarch64

android on AArch64 will alias mode_t to __kernel_mode_t which is aliased to
unsigned int rather than unsigned short like it is on the other targets.
Update the condition to reflect that.

Replace this paragraph with a description of your changes and rationale. Provide links to external references/discussions if appropriate.

Resolves SR-NNNN.

@swift-ci please test and merge


Add ServiceScope to ProcessEnvironment

so build services can start using it.

It would be great to use ProcessEnvironment in the PID instrumentation build service here: https://github.com/gradle/gradle-profiler/pull/238

Let's not do this. As Sterling said, we should be careful what services to expose to build services.


Two hashtags

Hi, is there any option to get latest images at the same time from two different hasthags ? Example we have #hashtag1 and #hashtag2 and need to add latest images from this two hashtags. How can i do that?  :)

+1 would be a nice feature if it already doesn't exist.

It's not super convenient, but you can create multiple feeds on the same page, see #12.
Hope that helps!


this is my 2nd pr

Don't Edit Someone else file. We won't Accept this type of Pull Request.
And Also You have modified index.html. That is totally wrong.
So As a Gesture of Spam I would be closing this Pull Request.


Add notebook here in repo also

You can directly commit notebooks here using colab

Yes but we don't want to "commit" notebooks so that the repo remains as light as possible

Please close the issue if resolved :)

You can close this issue yourself!


Panel-performance: Icons of applications launchers take too long

When I have several programs open, the application launcher icons take some time to appear. This can get really annoying, because then all the open programs shown in the panel are moved to make space for the icons. Thus, several times every day, I click on another open program in the panel only to have it shifted and another program is brought to the front.
Maybe the problem is caused by the same thing that causes my File Manager to be so slow.
I will keep watching what is going on with Lumina - and be happy to compile and test new versions. But for day-to-day use, this DE is unfortunately not yet ready. At least not on my T530. I will have to look for something else.
This is really sad, but it confirms what I and many others who commented on PC-BSD/TrueOS/Lumina in various threads on the German bsdforen.de have experienced: This OS and its components never seem to become really stable. Whenever something is 90% done, it seems the project jumps on yet another new idea (be it SysAdm, Wayland integration or whatever). Contrary to what has been a PC-BSD goal for a long time, this OS and its components should not be recommended to beginners. Too much of it seems to be in Beta-state and constantly changing.
Sorry for this rant. But it is the 3rd time I thoroghly tried PC-BSD (twice) and Lumina (since spring of 2016). I give up. Again.

Where exactly is the slowdown?
A) Launching an app to when the app window appears
B) App window appearance to when the task manager button for that window shows up.
Additionally, which task manager plugin are you using (grouped/ungrouped), and approximately how many windows do you have open before this starts to happen? The output of "top" might be helpful in this situation too -  simply to see if your system is just running out of available resources.
I use TrueOS/Lumina on my Lenovo T420 here and cannot reproduce the slowness issues you have mentioned here or on the other file manager ticket - so any information you can provide will be very useful. My gut feeling though is that it is something specific to either your hardware or your system settings which is creating the bottleneck.

Thanks for the reply. I just sent you a short video (ca. 20 seconds) which shows the delay in the panel.

This appears to have been resolved with icon caching improvements and other Lumina fixes in the versions released after this ticket was created. Please reopen or create a new issue if this problem occurs again.


Suggested Improvements to Release Template

When this issue is created in the target repos, it would be helpful to have some more detail, especially if it is for a new repo. Setting up codecov, dependabot, actions, backporting needed handholding from the release team that may not have been necessary if there was a link to another checklist for new repos. Also, the first step in post release may be clarified with an example. For example: "Prepare for an eventual security fix development iteration by incrementing the version on the release branch to the next eventual patch version."  could be changed to " Prepare for an eventual security fix development iteration by incrementing the version on the release branch to the next eventual patch version. (e.g. after release of 2.4, the 2.4 (release) branch should build 2.4.1, the 2.x branch should build 2.5.0")
https://github.com/opensearch-project/opensearch-build/blob/main/meta/templates/releases/release_template.md

Hi, @macohen, since the time this issue got opened, the release template has been improved a few rounds, and also got moved to here https://github.com/opensearch-project/opensearch-build/blob/main/.github/ISSUE_TEMPLATE/release_template.md , also, the team adds a Wiki page to describe the process and explain the flow ,, I am so sorry that we replied just now, would you mind have a look and let us know if the current design works ok?  thanks!!

Thanks! I totally didn't remember opening this issue, but we've come along way. The detail is much improved. I'll close!


Uid can't be more than 255 (uid="0255")

Hi,
I have 302 test cases running using NBi and I used uid attribute for each test case in order to have a specific id for, in future, introduce this id in a database and analyze the results of tests.
However, when I add the uid attribute for test case number 256 it is returned the following error.
At line 15303: The 'uid' attribute is invalid - The value '0256' is invalid according to its datatype 'http://www.w3.org/2001/XMLSchema:unsignedByte' - The string '0256' is not a valid Byte value.
The syntax used was:

Can you help me solving this problem? Am I using in a wrong way this attribute?
Thank you in advance,

You're using it correctly, it's a bug.
Most (all?) of us use the name as the identifier of the test. It's technically possible to have two tests with the same name but it's not recommended.

Set max value for this attribute to<PHONE_NUMBER>

Preview available at https://ci.appveyor.com/project/CdricLCharlier/nbi/build/1.14.0-ci.48 (Tab artefacts)

Thanks a lot for correct this issue.
I'm using xml results to insert information in database and I want to use uid to have a unique identifier of tests for make more easy the location and possible correction of those tests in nbits file.
Thanks again.

Included in release v1.14


Prevent switching to newly added windows

Resolves #159
The only change is preventing AddWindow to switching to the window:
https://github.com/workspacer/workspacer/blob/7f2dc71474037667c986b1b1df7d3c5e70eb80d7/src/workspacer/Workspace/WorkspaceManager.cs#L347-L352
All the other changes seem to be due to a mismatch between line endings (sorry).

This PR seems to co flare two things (Win11-fix and real bug fix) but otherwise looks ok to me.


How to perform multi-image inference

Hi,
I want to change the inference.py to test multi-images
But I don't want to transform the input to batch
Because the current output mask will be the next input(I changed the framework to video object segmentation task and added additional input mask which from previous frame's output)
I first simply changed the original code with for-loop it will get error in this line
net = DeepLabResNetModel({'data': tf.expand_dims(img, dim=0)}, is_training=False)
Then I tried to create the network only at first iteration and add this line
net.layers['data'] = tf.expand_dims(img, dim=0)
But it didn't change the data layer's content
The output masks all the same with the first iteration
How to modify the inference.py to iterativelly change the data layer?
Thanks!

BTW
I have a question that why the test image size not resizing and feed to the network it can work?(in inference.py)
I trained with image size 321x321 and tested with 854x480
It confused me

If I understood you correctly, the error that you are receiving is due to the variables created for the second time inside the loop. To solve it, you would need to reuse the created variables after the first iteration. For example, take a look at these lines from the multi-scale evaluation script:
    with tf.variable_scope('', reuse=False):
        net = DeepLabResNetModel({'data': image_batch}, is_training=False)
    with tf.variable_scope('', reuse=True):
        net075 = DeepLabResNetModel({'data': image_batch075}, is_training=False)
    with tf.variable_scope('', reuse=True):
        net05 = DeepLabResNetModel({'data': image_batch05}, is_training=False)

Regarding the second question: (in general), that is the beauty of fully convolutional networks!
(Here), when you evaluate your trained model, each image is fed separately into the network (not in batches as during the training phase), so all the images preserve their original size, be it 321x321 or 854x480, or something else, and output masks of the corresponding sizes.

It works.
And I got the point how the network works.
Very thank you for the help and answering!


Question: How can I assign testID for items?

I want to assign the testID label for e2e testing purpose to items. I see this interface in @types/react-native-material-dropdown:
`

export interface DropDownData {
/** Value of item /
value: string;
/* Label to be shown /
label?: string;
/* Props for this item */
props?: Partial;
}`

And I've try to do something like this with the hope of assign the testID to items when they show but had no luck.
data={[      { value:  'John',        props: {                      testID: 'JohnItem',                    },       },      { value:  'David',        props: {                      testID: 'DavidItem',                    },       } ]}
Am I wrong about the purpose of the DropDownData.props or using it the wrong way? Is there any other way to apply testID to items?

A guy on my team has had difficulty with this, too. We are using Detox for our end-to-end testing, but have not found a workaround for this component yet.

@duenguyen2103 - it's not a full solution but what I found is that if you scroll to the position you want and do something like handle a tap() event, the tests pass. I don't know what your specific use-case is but I'm assuming it's similar to mine. Unfortunately, only what is visible inside of the dropdown can be tap()'d so this solution isn't the best :/

I added testID in my fork. Maybe it help somebody


Update ingress apiVersion

Hello!
Thanks for great documents!
Update ingress apiVersion on https://kubernetes.io/ja/docs/concepts/services-networking/ingress/
It's looks like networking.k8s.io/v1beta1 is already deprecated on v1.19.
Error:
Warning: networking.k8s.io/v1beta1 Ingress is deprecated in v1.19+, unavailable in v1.22+; use networking.k8s.io/v1 Ingress

Thanks!

Sorry. This is incorrect PR.
moved #26459


Stryker should not do a dry-run when there are no files

Repro steps:

Create a new directory
Call npm init and skip through it
Install mocha: npm i -D mocha
Call stryker init and choose mocha - mocha
Run stryker

Current behavior:

Expected behavior:
No crash. Just a message that no files have been found.

I'll take this one

Awesome! If you need any help, feel free to let us know :)

Thanks for fixing this @legopiraat!


Is it posible to automatically resolve modules from aliased directory?

Suppose I have module alias in package.json:
"_moduleAliases": {
    "@modules": "modules"
  }

why should I have not only alias for modules directory in this plugin's settings, but for each of its children modules (js files)?
"settings": {
    "import/resolver": {
      "alias": {
        "map": [
          ["modules", "./modules"],
          // aliases, I wish to get rid of
          ["@modules/balance-manager", "./modules/balance-manager"],
          ["@modules/coin-finances", "./modules/coin-finances"],
          ["@modules/config", "./modules/config"],
          ["@modules/rub-finances", "./modules/rub-finances"]
        ],
        "extensions": [".ts", ".js", ".jsx", ".json"]
      }
    }
  }

@khataev sorry for the late reply. I think your configuration can be simplified as follows.
"settings": {
    "import/resolver": {
      "alias": {
        "map": [
          ["@modules", "./modules"]
        ],
        "extensions": [".ts", ".js", ".jsx", ".json"]
      }
    }
  }


Update the background color of uneditable parts

Make the background color of uneditable parts of elements in content items more distinct from the editable parts because previously, it was almost an invisible difference. Now the BG are diagonal stripes of light colors that are unobtrusive but distinctively different from the rest of the UI. Tested using the Stylish extension.

After discussion, I'm closing this without merging because the change isn't following Kontent.ai's design language.