Refactor DialogStateManager and DialogManager into Adaptive

move all DM, PathREsolvers, MemoryScope classes into Adaptive assembly
replace DC.State => extension method DC.GetState()
Change DC to use ObjectPath.SetPathValue() for 3 properties it manages
update everyone to use .GetState()
Fix some misc bugs which surfaced because of subtle interactions.

Pull Request Test Coverage Report for Build 86020

0 of 0   changed or added relevant lines in 0 files are covered.
84 unchanged lines in 2 files lost coverage.
Overall coverage increased (+0.1%) to 76.484%

Files with Coverage Reduction
New Missed Lines
%

/libraries/Microsoft.Bot.Builder.Dialogs/ObjectPath.cs
33
77.8%

/libraries/Microsoft.Bot.Builder.Dialogs/DialogContext.cs
51
69.83%

Totals

Change from base Build 85982:
0.1%

Covered Lines:
8066

Relevant Lines:
10546

💛  - Coveralls

:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Builder.dll compared against version 4.5.3
:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Builder.AI.Luis.dll compared against version 4.5.3
:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Builder.AI.QnA.dll compared against version 4.5.3
:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Builder.ApplicationInsights.dll compared against version 4.5.3
:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Builder.Azure.dll compared against version 4.5.3
:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Builder.Dialogs.dll compared against version 4.5.3
:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Builder.TemplateManager.dll compared against version 4.5.3
:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Configuration.dll compared against version 4.5.3
:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Connector.dll compared against version 4.5.3
:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Schema.dll compared against version 4.5.3


adjust tests to reflect final uri's

also adjusted the corrected ipmi capabilities command

code changes looks good.


Publish all nodes of a given OPC UA Server

Is it possible to publish all available nodes of a OPC UA Server?
Right now I add every nodeID to the pblishednodes.json document.
[
  {
    "EndpointUrl": "opc.tcp://blueface:48010",
    "UseSecurity": false,
    "OpcNodes": [
      {
        "Id": "ns=6;s=AirConditionerXml.Humidity",
        "OpcSamplingInterval": 2000,
        "OpcPublishingInterval": 5000
      },
      {
        "Id": "ns=6;s=AirConditionerXml.Temperature",
        "OpcSamplingInterval": 2000,
        "OpcPublishingInterval": 5000
      }
    ]
  }
]

I tried "Id": "ns=6;s=AirConditionerXml but this doesn't seem to work.
The thing is, I want the OPC publisher to publish newly added objects without the need to edit publishednodes.json and restart the server.
A workaround could be to update the published nodes while the publisher is running. That way I could use another tool to automatically update the node list. Is this possible somehow?
Thanks in advance
Daniel

The nodeconfiguration tool works just fine. Thank you very much.
But I'm still curious if it's possible to publish all properties and components below a node.
For example there is a node "Fluid temperature" (ns=2;s=11000.Density) which has several properties and components like identification and unit. (...Density.Identification and .Unit). If I want to publish them, I need to add every single nodeID. Right now, I don't know if there is a way to publish a node with every subordinate node, short of programming a new tool which uses the nodeconfiguration tool.

Problem is solved. Here's what we did: When building an OPC UA server we also build a publishednodes.json. After connection to the publisher machine was established through simple tcp connectivity, the publisher machine downloads publishednodes.json from the OPC UA server machine and runs https://github.com/Azure-Samples/iot-edge-opc-publisher-nodeconfiguration. Not exactly what we were planning to do but in the end all we needed. Thanks again.


Make gg work with multithreading/parallelism

@tinou98 has started work on this already. PR -> #26

#26 is merged. There are still some changes pending. @tinou98 Once you are done create another PR and link it to this issue.

@tinou98 is anything pending on this ?

I've finished implementing everything I was thinking of. If there are others stuff to implement, maybe we can create others issues, and close this one ?

Cool. Closing this then


raiseNotification func clean code

#14
raiseNotification func clean code
TODO

[x] clean code (delete else)
[x] Built successfully
[x] Ran gofmt successfully

I find the existing code more readable. I don't see why the cleanup is needed.
One suggestion: While doing OSS dev, get your issues triaged and accepted before raising PRs.
Nevertheless, thank you for taking your time and opting to contributing on this project.


Upload only the XCframework product without excess directories

Goal
Pretty much does as described, copies the XCframework products up to the top level once built and zips them there, rather than the whole directory structure.
@kstenerud I'd appreciate you checking the zip file on the build step, just to make sure everything is there.

Hi Josh, the build script already produces BugsnagPerformance.xcframework.zip and friends, which is what gets uploaded to the github release page already. So you should just be able to upload that zipfile directly.

Ok, all done


[chore] upgrade to vite-plugin-svelte 1.1.0 and enable prebundleSvelteLibraries

We'll turn prebundleSvelteLibraries on by default in vite-plugin-svelte 2.0 when Vite 4 comes out. For now we turn it on here. The feedback thus far has been good
Ref https://github.com/sveltejs/kit/issues/2612

Enabling prebundleSvelteLibraries is causing the below error building my application with vite. I flipped it to false to confirm that specifically caused the error, but I'm unsure how to resolve it. Are there vite/svelte/etc config changes necessary to accommodate this change? Thanks for your help, happy to provide more information if needed.
vite v3.1.4 building SSR bundle for development...
✘ [ERROR] No loader is configured for ".svelte" files<EMAIL_ADDRESS>
[vite-plugin-svelte-kit] Build failed with 1 error:
error: No loader is configured for ".svelte" files<EMAIL_ADDRESS>error during build:
Error: Build failed with 1 error:
error: No loader is configured for ".svelte" files<EMAIL_ADDRESS>    at failureErrorWithLog (../../node_modules/esbuild/lib/main.js:1566:15)
    at ../../node_modules/esbuild/lib/main.js:1024:28
    at runOnEndCallbacks (../../node_modules/esbuild/lib/main.js:1438:61)
    at buildResponseToResult (../../node_modules/esbuild/lib/main.js:1022:7)
    at ../../node_modules/esbuild/lib/main.js:1134:14
    at responseCallbacks.<computed> (../../node_modules/esbuild/lib/main.js:671:9)
    at handleIncomingPacket (../../node_modules/esbuild/lib/main.js:726:9)
    at Socket.readFromStdout (../../node_modules/esbuild/lib/main.js:647:7)
    at Socket.emit (node:events:513:28)
    at addChunk (node:internal/streams/readable:315:12)

@schmidtk can you file an issue with a way to reproduce this? I haven't see this error before and am unsure what to advise without some way to be able to reproduce and debug it

@benmccann No problem, I was hoping it would ring a bell. 😄 I'll see if I can reproduce with a simple example, because I'm currently working in a reasonably large monorepo.

@benmccann Ok narrowed it down further. The error is a combination of enabling legacy.buildSsrCjsExternalHeuristics in our vite config, and not having an error route in the app. When that flag is enabled and Sveltekit uses its default error page, we see the error I posted above.
I'll check with my team on why we're using that flag and see if we can stop doing that, but adding our own +error.svelte will prevent the build error as a workaround. FYI in case buildSsrCjsExternalHeuristics and prebundleSvelteLibraries should be working together.

Enabling prebundleSvelteLibraries causes an error in my application which imports a Svelte component from a dependency that tries to use import { PUBLIC_FIREBASE_CONFIG } from '$env/static/public';. This worked fine in 1.0.0-next.525 but not in 1.0.0-next.526. I'll try to add a minimal repro later.

@jacob-8 One workaround we discussed is to set $env/static/public to optimizeDeps.exclude. This could be the default in the future, but on the other hand Svelte packages should try to avoid SvelteKit features unless necessary. In this case, the package could have a function that receives a parameter for PUBLIC_FIREBASE_CONFIG

@jacob-8 One workaround we discussed is to set $env/static/public to optimizeDeps.exclude.

Perfect! I'll try that.

on the other hand Svelte packages should try to avoid SvelteKit features unless necessary.

Yeah, I used to pass in a config to the library and would like to return to doing this but with all the changes affecting initialization of a library on both client and server side it was just to painful to make one single solution work across all my projects without awaiting parent in each load. I'm waiting until the dust settles a bit more.

In our app we use byteMD, and it stopped working with 526, but only in dev mode (npm run preview is fine).
The error message in console is like SyntaxError: The requested module '/node_modules/word-count/index.js?v=4f0918c6' does not provide an export named 'default.
As this message hints to vite dev mode module loading, and this PR was linked from 526 changelog, I post here.
Will try some circumvention, but it's pretty annoying for us.

I hadn't much luck fiddling with config files, so I setup a blank sveltekit project to reproduce:
TLDR; I reproduce the problem (reminder: dev mode only) with:

sveltekit >v225
export const ssr = false; in master (topmost) +layout.server.ts (our app is a SPA)

If I downgrade SK version to v225 or lower, it works again.

@benmccann reproductible repository here: https://github.com/0gust1/sveltekit-bug-repro-526
Should I open an issue ?


Update database.json

Added:

AAC at2 (chunked), at15 (spliced main encrypted), at16 (spliced ad encrypted)
AC4 at1-4
EAC3 at1-4

It's ok but moving the CEAC block at a different location means the diff is not useful for this section.

Thanks Romain. What would you like me to do? Cancel this PR and resubmit with diff in existing place?

Any works. If you push a second commit I can git-"squash" (ie merge all the commits of the PR into one).

Superseeded by #52 and #54. Closing.


IDs are tokenized during search gives strange results (bad tokenizing on colons)

This is the trackable issue for:
http://jira.geneontology.org/browse/GO-624
The current statement of the issue is:

on http://amigo.geneontology.org/amigo/gene_product/FB:FBgn0000535
in free-text, enter GO:0007072
no results are filtered

This is considered an issue because it seems unlikely this gene would have the seen associations with GO:0007072.
Possibilities to consider are something wrong with the search such the the "go" bits in the synonyms are matching (although why so few then) or there is a hiccup in the ontology and these really are in the closure.

Also from http://jira.geneontology.org/browse/GO-1428
Seems odd that this search returns no result:
http://amigo.geneontology.org/amigo/medial_search?q=S000000031
would have expected it to return this entry:
http://amigo.geneontology.org/amigo/gene_product/SGD:S000000031

This is the expected behavior given the tokenizing issue. Now that the work has been done for the new tokenizing with GOlr in the monarch stack, we just need to port it over to AmiGO by updating bbop-manager-golr.

We're running into this again, see https://github.com/geneontology/helpdesk/issues/99
This is really key, people really expect to be able to search with the non-prefixed part of the ID. Do we still need to change bbop-manager-golr? Isn't this just a matter of adding the unprefixed form as something solr searches on?

hi, any news on this? we really would like to do some analysis for a paper that we would like to submit ASAP @ValWood

@Antonialock This isn't our primary issue. this is a side issue.


pytispark breaks

Seems that previous 1.0 version pytispark didn't pushed to pyti.org as expected.

Done.


Project refactoring

There a few things in the project that I believe are worth changing, namely:

Don't use batch/cmd files, migrate to npm scripts or gulp (if lengthier or complicated scripts are required) instead
Use local packages instead of installing global packages using npx (Installed with node.js by default)
Use a CDN for Libraries such as p5.js
Rename classes/ to model/ (files such as util should not be classes and instead use functions)

A few suggestions as well:

Migrate to yarn, a package manager with more features (and looks nicer too!)
Since this is an open source project, use a linter (I would suggest standard.js)
Add GitHub Issue/PR templates

I would be happy to start a PR to implement any/all of these changes.

PR Created at #13


RequireJS compatibility

This fixes a bug that comes up when requiring Iced CoffeeScript using RequireJS.

This change seems good to me; we should also create a pull request at https://github.com/jashkenas/coffeescript
Actually it looks like https://github.com/jashkenas/coffeescript/blob/master/Cakefile might already be AMD aware.  Would it work to take the code from there and see if it fixes your issue?
(....But I think it should be more carefully structured so that if window.CoffeeScript is already defined, then browser.coffee (which loads and executes script type=text/coffeescript) should not be executed a second time.)

I tried using the code from coffeescript's Cakefile but then realized that it doesn't work because Iced needs an external dependency, iced-runtime, to be bundled in with it. I guess that's why Iced uses browserify. I opened maxtaco/coffee-script#155 to see if maxtaco or someone can help.
As for preventing browser.coffee from executing more than once, that's probably a good thing to do. I don't think the entire module should be skipped, maybe browser.coffee itself should handle it? Maybe like by marking the


OSSL_STORE: Add reference docs for the built-in Windows store implementation

Fixes openssl/project#422

Looks good - what it needs is to mention that it doesn't currently enforce any additional constraints configured in the Windows certificate store that aren't part of the certificate itself.
The background here is you can do various kinds of special constraints on a root certificate like name constraints etc., but by adding registry entries rather than modifying the registry itself. People might be expecting us to enforce those, but we don't. So we should mention that.
Reposting here:

Our new Winstore provider, which allows trusted root certificates to be loaded from the Win32 system store, doesn't honour some features of CryptoAPI.
CryptoAPI has the ability to associate additional constraining properties with a certificate in the store. This includes both documented and undocumented capabilities:
The documented capability to override EKU
The undocumented capability to add name constraints
The undocumented capability to override the certificate expiry date
Both documented and undocumented capabilities are in use in the wild. Chromium is apparently checking for the undocumented attributes under the assumption people are using them.
While an X.509 name constraint embedded in a certificate's DER will obviously be honoured by us, an X.509 name constraint added as a property in the system store will not be, as we don't check for any of this.

I've added a section to describe those features

@nhorman please reconfirm

Approval reconfirmed

24 hours has passed since 'approval: done' was set, but as this PR has been updated in that time the label 'approval: ready to merge' is not being automatically set.  Please review the updates and set the label manually.

Merged to the master, 3.3 and 3.2 branches. Thank you.


"client_id" is missing when using a custom OAuth config for LinkedIn

I'm not sure if this is properly for this repo or oauth2_client, but please let me know if that's the case.
I created an app in the LinkedIn developer portal, used the ID/secret locally and was able to go through the auth flow on LI (which leads me to believe the client id is set correctly on my end), but when handling the access token response I get the error in the title (and at the end of this issue).
LinkedIn's OAuth docs say to include the client ID and secret again in the call to get the access token – I'm not sure if that's non-standard?
Here is my client config:
export const linkedInOAuth2Client: OAuth2ClientConfig = {
  authorizationEndpointUri: "https://www.linkedin.com/oauth/v2/authorization",
  clientId: getRequiredEnv("LINKED_IN_CLIENT_ID"),
  clientSecret: getRequiredEnv("LINKED_IN_CLIENT_SECRET"),
  redirectUri: `${SITE_BASE_URL}/linkedInCallback`,
  tokenUri: "https://www.linkedin.com/oauth/v2/accessToken",
  defaults: {
    scope: [
      "email",
      "openid",
      "profile",
    ],
  },
};

Relevant part of the stack trace:
Error: A required parameter "client_id" is missing
    at AuthorizationCodeGrant.getTokenResponseError (https://deno.land/x/oauth2_client@v1.0.2/src/grant_base.ts:156:14)
    at eventLoopTick (ext:core/01_core.js:181:11)
    at async AuthorizationCodeGrant.parseTokenResponse (https://deno.land/x/oauth2_client@v1.0.2/src/grant_base.ts:72:13)
    at async handleCallback (https://deno.land/x/deno_kv_oauth@v0.10.0/lib/handle_callback.ts:69:18)

Hi Kevin, you're configuration looks correct. I believe that this is a non-standard requirement. I've drafted a quick fix. Please let me know if it works.

Import using https://raw.githubusercontent.com/denoland/deno_kv_oauth/handle-callback-request-options/mod.ts
Add a 3rd argument to handleCallback() with the following structure:{
  requestOptions: {
    urlParams: {
      client_id: getRequiredEnv("LINKED_IN_CLIENT_ID"),
      client_secret: getRequiredEnv("LINKED_IN_CLIENT_SECRET"),
      redirect_uri: `${SITE_BASE_URL}/linkedInCallback`,
    },
  },
}

Thanks for the quick response!
I tried it with both requestOptions: { urlParams: { ... } } and with requestOptions: { body: { ... } } as the third param to handleCallback and I get the same error message with the updated path for handleCallback:
Error: A required parameter "client_id" is missing
    at AuthorizationCodeGrant.getTokenResponseError (https://deno.land/x/oauth2_client@v1.0.2/src/grant_base.ts:156:14)
    at eventLoopTick (ext:core/01_core.js:181:11)
    at async AuthorizationCodeGrant.parseTokenResponse (https://deno.land/x/oauth2_client@v1.0.2/src/grant_base.ts:72:13)
    at async handleCallback (https://raw.githubusercontent.com/denoland/deno_kv_oauth/handle-callback-request-options/lib/handle_callback.ts:71:18)

If it helps, here's the code I'm working with.

Good thinking trying requestOptions: { body: { ... } }. But I thought that would've worked. The best course of action is to add a pre-built OAuth config for LinkedIn as part of this library (we'd need it sooner or later anyway). Then, troubleshooting can be boiled down to only a few moving parts. I'm happy to do this if no one grabs it up.

As I noted in the related PR, I'm able to set up the custom config so I no longer run into the "client_id is missing" error even without the handleCallback change, (now I've got a different and opaque error from LinkedIn that I can't yet troubleshoot) so feel free to close this whenever.

I'll close this issue for now but will still pursue #287, as it'll hopefully prevent issues relating to LinkedIn from popping up in the future. Thank you, Kevin!


Is there any date/time variable in the chat to place them in order?

If you want to sort the messages you can sort them by seq field which is a number.
If you want to sort the chats:
topicSubs.updated
/// Or
topic.updated

There is also created, touched and deleted as DateTime


Cant use a text editing controller?

Just testing the package out and it seems like I cant use a text editing controller?
class _MyHomePageState extends State<MyHomePage> {
TextEditingController _controller;

 @override
  void initState() {
    _controller = TextEditingController(text: 'test');
    super.initState();
  }
 @override
  Widget build(BuildContext context) {
return Scaffold(
      appBar: AppBar(
        title: Text(widget.title),
      ),
      body: Column(
        children: [
          Container(
            child: FormBuilderTextField(
              controller: _controller,
              attribute: "Name",
              decoration: InputDecoration(labelText: "Name"),
            ),
          ),
        ],
      )
   }
}

Nothing crazy here but when I run it I get "NoSuchMethodError: invalid member on null: 'initialValue'".
Not sure if I'm doing anything wrong. It does work when I use it in initialValue (initialValue:_controller.text). What am I missing here?

Hi @sjeanph,
Which version are you on?

this newest one, 3.12.0

I'm unable to reproduce. Could you kindly share the full stack-trace?

I've seen the problem. For now, kindly wrap your form fields inside a FormBuilder. That should do the trick.

that did it thanks :)


Documentation is hard on the eyes

Describe the bug
The Avalonia documentation has really bad contrast for monospaced text in Brave browser. It's very hard to read.
 Let me try some other browsers.

@Xerxes004, Shouldn't this be an issue for the Brave browser then? I'm not sure it's worth the time for Avalonia to try to support every non-mainstream browser.

@robloo does Avalonia not control the style for this documentation? I also just checked and Chrome has the same issue (Brave is based on Chromium).


[New game]: Fill in four

🎮 Game Request
Player are given four colors. Their job is to fill every square in the canvas with no neighbouring part have a same color.
Point down the features
Game points will be awarded as per level cleared
Select program in which you are contributing
GSSoC23
Code of Conduct

[X] I follow CONTRIBUTING GUIDELINE of this project.

Hey @S-ishita !
Thank you for raising an issue 💗
You can self assign the issue by commenting /assign in comment 😀
Make sure you follow CODE OF CONDUCT and CONTRIBUTING GUIDELINES 🚀
Don’t Forget to ⭐ our GameZone🎮
Make sure you join our Discord🕹

Hey @S-ishita ! Thank you so much for your raising the issue💗
It’s all yours, you can come anytime again and make some contributions! 🚀
Alone, we can do little, but together we can do so much! 😇


occ installation do not support password beginning with "-"

When a password starts with a "-" the occ command sees it as an option call, not as a string
Throws the error:
`The "--admin-pass" option requires a value.

must find a way to escape password.
' .... ' not working


Updated CONTRIBUTING.md with correct test command

What does this PR do
Checklist:

[X] I have read CONTRIBUTING.md
[ ] I have written necessary tests and rustdoc comments (no applicable)
[ ] A change log has been added if this PR modifies nix's API (no applicable)

Thanks for doing this!


Fix race where processModelUpdate can be called after close()

Fixes processModelUpdate vs close() race
close() can be called and processModelUpdate() can be invoked after the check for CLOSED
This fix waits for idle, then closes the store, lowering the change of an incoming onMessage() happening while the scheduler moves the state to CLOSED and nulls out the model.
10k/10k passed multiple times.

/gcbrun


sgx: send nil TopologyInfo

/dev/sgx_* cannot be mapped to any topology. SGX itself is topology
aware but we cannot control it with TopologyInfo.
Currently, pkg/topology returns empty TopologyInfo{Nodes:[]NUMANode{}}
for /dev/sgx_ but kubelet TopologyManager (when enabled and with the
policy other than 'none') interpretes that as "Hint Provider has no
possible NUMA affinities for resource" and rejects the SGX resources.
What we want is "Hint Provider has no preference for NUMA affinity with
resource". This is communicated using nil TopologyInfo.
See: https://github.com/kubernetes/kubernetes/issues/112234
Signed-off-by: Mikko Ylinen<EMAIL_ADDRESS>

Codecov Report

Merging #1141 (8ac321f) into main (d07c35f) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #1141   +/-   ##
=======================================
  Coverage   52.96%   52.96%
=======================================
  Files          40       40
  Lines        4358     4358
=======================================
  Hits         2308     2308
  Misses       1923     1923
  Partials      127      127

Impacted Files
Coverage Δ

cmd/sgx_plugin/sgx_plugin.go
76.47% <100.00%> (ø)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Allow queuing custom responses from function call

During a function call, sometimes it's desirable to let the user know that this is going to take awhile. While it is possible to prompt the LLM to return a text response while this is happening, it would offer more control to be able to do agent.say("....").
Currently when that is done, the speech gets queued after the LLM's response. We'd want the ability to inject a response as the immediate thing that's communicated.

It would be huge if we could even pre-buffer the audio for this message...  Thanks guys!

It would be huge if we could even pre-buffer the audio for this message...  Thanks guys!

Hey, what do you mean by pre-buffer, do you want to synthesize the agent speech ahead of time?

@theomonnom hi Theo, yes exactly. Then we could get to very nice and low latencies with an initial prebuffered message, as we are streaming the full answer.
Hume for example is also offering this feature.

@davidzhao Where do you think the "quick response" before the function call done should come from:
prompt the LLM to say something after function_calls_collected or allow the function to early return a customized text before it done?

some folks are already prompting LLM to return the right text. I think others are choosing to use agent.say to queue up a custom placeholder response.
currently when trying the latter path, the speech doesn't get enqueued right away

some folks are already prompting LLM to return the right text. I think others are choosing to use agent.say to queue up a custom placeholder response.
currently when trying the latter path, the speech doesn't get enqueued right away

I see. I can take a look if it's an issue of agent.say doesn't work as expected.

The current function call logic is like the following pseudo-code
fncs = speech_handle.synthesis_handle.play().join()
chat_ctx = speech_handle.source.chat_ctx
nest = 0
while fncs and nest < max_nested:
  tools_messages = [fnc.exectue() for fnc in fncs]

  answer_llm_stream = llm.chat(chat_ctx.copy() + tools_messages)
  speech_handle.synthesis_handle = _synthesize_agent_speech(answer_llm_stream)

  fncs = speech_handle.synthesis_handle.play().join()
  nest += 1

So that the function call will block all later speech (also the one from say), and all the function calls share the same base chat_ctx from the speech_handle.source. Not sure if it's intended, the nested function call cannot be interrupted as the interrupted = answer_synthesis.interrupted is not used, though this might rarely happen https://github.com/livekit/agents/blob/main/livekit-agents/livekit/agents/pipeline/pipeline_agent.py#L820
I have a proposal that we send the function calls in a fnc_queue and execute them in separate task. It records the nest index and the base chat_ctx for each function call task so it should have the same behavior like the current version. And any user interruption will cancel all the queued function calls.
@theomonnom what do you think, is there any potential risk for implementing like that?


Consider supporting https://www.convex.dev/

Describe the feature you'd like to request
SQL is cool, but it would be nice to see a template with convex.dev, possibly the easiest way for building application I've ever seen (especially the ones that requires reactive features)
Describe the solution you'd like to see
use convex.dev
Additional information
No response

Example usage?


feat(backend): add support for empty string annotations

🚨 Proposed changes
Thanks for the work you spend on this plugin.
When hosting a catalog entity in a GitLab instance (hosting the catalog-info.yaml there) the backend automatically applies the gitlab.com/instance and gitlab.com/project-slug annotation.
Currently, there is no way to opt out of that for an individual entity, whether the source code is hosted elsewhere or for entities without source code, and which issues are tracked elsewhere (for example, in Jira).
Without this change, the processor already respects custom annotations.
With this change, the processor also ignores entities that set an empty string for these annotations.
apiVersion: backstage.io/v1alpha1
kind: Component
metadata:
  # ...
  annotations:
    gitlab.com/instance: ""
    gitlab.com/project-slug: ""
spec:
  # ...

This is something between a feature and a bugfix. (A breaking change only if someone used an empty string before.)
⚙ Types of changes
What types of changes does your code introduce? Put an x in the boxes that apply

[x] New feature (non-breaking change which adds functionality)
[x] Bugfix (non-breaking change which fixes an issue)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[x] Documentation Update (if none of the other choices apply)
[ ] Refactor

Hi @jerolimov, great feature! Thank you!

Thanks @antoniomuso for merging this so fast. Is it possible to get a release with this? :hugs:


For max_pool_with_argmax op, GPU kernel keeps consistent with the behavior of CPU

Fix #22025
Respect with  tf.nn.max_pool_with_argmax: API , now GPU implementation returns flattened index ((b * height + y) * width + x) * channels + c.

@poxvoculi  @rmlarsen Hi, could you take a look or reassign? Thanks.

I checked those failed checks. Seems unrelated?

@yifeif Hi, yifei. Could you take a look? Thank you :-)

Thanks @facaiy!  @rmlarsen would you be the right person to review changes to maxpooling_op?

Nagging Reviewer @rmlarsen: You have been added as a reviewer to this pull request. Please add your review or reassign. It has been 44 days with no activity and the awaiting review label has been applied.

Nagging Reviewer @rmlarsen: You have been added as a reviewer to this pull request. Please add your review or reassign. It has been 59 days with no activity and the awaiting review label has been applied.

Close it since #26562 is created to fix the issue.


[httpbp]base64 encoding decoding edgecontext

Description
Since our current edgecontext header transfer is using base64encoded so we need to keep it consistent to attach to the header with base64 format
👓 @pacejackson @fishy

change notes:

renaming
explicit the error and and return trust edge context false when error happens
use w http.ResponseWriter as argument instead of http.header for SetEdgeContextHeader


Add notes and nullifiers to genesis.toml

We have the need to be able to pass a configuration file on node initialisation to pre-populate the DB ( store ) of the node with:

Notes
Nullifiers

This would be helpful for testing, but also potentially in production with nodes that would want to init from a certain state.
Depends on: #138
Linked to: #127

Closing this as I don't think we need to implement this functionality any more.


Warn istio users not to upgrade more than one minor version at a time

We will do this in the istio app-readme, since no custom chart logic exists in the UI.
https://github.com/rancher/rancher/issues/33843#issuecomment-890173681
Thread on doing this in chart vs dashboard: https://github.com/rancher/dashboard/issues/3627

Available to test in rancher-istio chart version 100.1.0+up1.11.4

On rancher v2.6.3-rc4
Deployed a 1CP, 1 ETCD, and 2 Worker nodes.
Warning is visible while installing and upgrading Istio chart.


Add Postgres to Codespaces

Trello card
Trello-4572
Context
Since we added a Postgres database to the application the Codespaces have been failing to boot. We need to make a Postgres instance available inside the Docker container for the app to connect to.
Changes proposed in this pull request

Add Postgres to Codespaces

Guidance to review
Go to the repository home page and select this branch from the drop down, then start a new Codespace from the branch. Check you can load the website.

Looks good to me


Fix flaky TestReload

Signed-off-by: albertteoh<EMAIL_ADDRESS>
Which problem is this PR solving?

Fixes #2644 .

Short description of the changes

The logs from #2644 indicate a race condition where the cert.crt file was loaded before the key.crt file, which was not observed in local testing in #2624. That is "Loaded modified certificate" was logged for certFile.Name() before keyFile.Name().
This fixes this race condition by being more explicit on the wait condition to include the keyFile.Name() in the log entry.

Testing
The following test run passes locally:
go test -test.count=5000 -test.run=TestReload$ ./pkg/config/tlscfg/

We could merge this if the branch build is successful: https://travis-ci.org/github/albertteoh/jaeger/builds/745572554 (since our main build is out of credits)

We could merge this if the branch build is successful: https://travis-ci.org/github/albertteoh/jaeger/builds/745572554 (since our main build is out of credits)

Thanks @yurishkuro . It looks like the build has just passed.


Gpu scheduling

Work in progress.  I'm posting it in this form just for communication purposes.


3.5.7 No more result from API when workflows.argoproj.io/phase=Running

Pre-requisites

[X] I have double-checked my configuration
[X] I have tested with the :latest image tag (i.e. quay.io/argoproj/workflow-controller:latest) and can confirm the issue still exists on :latest. If not, I have explained why, in detail, in my description below.
[X] I have searched existing issues and could not find a match for this bug
[ ] I'd like to contribute the fix myself (see contributing guide)

What happened/what you expected to happen?
Hello,
We have likely identified a regression in version 3.5.7. This is unexpected, as there are no related issues or changes noted in the changelog. The Argo Workflows API does not return any results when queried with workflows.argoproj.io/phase=Running, workflows.argoproj.io/phase=Pending. Failed, Succeeded, Error are OK.
GET https://[URL]/api/v1/workflows/[NAMESPACE]?listOptions.labelSelector=workflows.argoproj.io/phase=Running&listOptions.limit=10

Version 3.5.7:

Version 3.5.6:

Thank you for your help on that issue
Hugo
Version
3.5.7
Paste a small workflow that reproduces the issue. We must be able to run the workflow; don't enter a workflows that uses private images.
GET https://[URL]/api/v1/workflows/[NAMESPACE]?listOptions.labelSelector=workflows.argoproj.io/phase=Running&listOptions.limit=10

Logs from the workflow controller
kubectl logs -n argo deploy/workflow-controller | grep ${workflow}

Logs from in your workflow's wait container
kubectl logs -n argo -c wait -l workflows.argoproj.io/workflow=${workflow},workflow.argoproj.io/phase!=Succeeded

I imagine this is due to #13021, I can't see another likely source of the problem.

Yes it would be from there, cc @jiachengxu. That would suggest the archived merging logic has a bug in it -- archived workflows will never be in Pending state so it should only retrieve the live ones in this case 🤔

I tried to reproduce the issue locally with v3.5.7, but I couldn't reproduce the issue, the followings are screenshots from my test, and both UI and postman returned the running workflows.

@Joibel IIRC, you are also running v3.5.7 in some of your environments, have you seen this issue before?

Probably important information, we are using persistance with PostgreSQL database. The behaviour could be different on that case?

Probably important information, we are using persistance with PostgreSQL database. The behaviour could be different on that case?

@hmoulart Thanks for providing the info, during my test, I was also using the postgres database for archiving workflows

Thanks for trying to repro Alan and Jiacheng!
@hmoulart I imagine there must be some other confounding variable here, perhaps in your Argo configuration, if it hasn't been easily reproduced

@hmoulart have u tried v3.5.8?

@tooptoop4 I'm going to try tomorrow :) Thanks

Hello,
I upgraded to version 3.5.8, and I’m pleased to report that the bug has been resolved!
Thank you to suggest me this upgrade.
Hugo

For reference, that means this was resolved by #13166


Add generic typed setTag/withTag

Reduces the need to call Tags.SOMETAG.getKey() and adds type safety for setTag if done from the span.
Fixes #271

Coverage decreased (-0.9%) to 73.183% when pulling aa1eb08b1853faa48837d0e81c6152e4c9f03ce6 on tylerbenson:tyler/withtag into d6c6509d5524f99039e34cbf121df79c46a25147 on opentracing:v0.32.0.

+1

Nice one.
Why is this considered a breaking change?

+1

One thing to note, I didn't follow @cwe1ss's suggestion to split the method declaration out by type. I don't have anything against that.  If y'all prefer the non-generic option I can do that instead.  Thoughts?

LGTM

@yurishkuro Approved - is it ok if I go ahead and merge?


feat: ✨ update uw image

📝 Changed routes:

/

(view full size)

Commit def6705a911055f4cba7e065d13e961f61a62aff (https://aireadi-hpeb3czpr-fairdataihub.vercel.app).


Chap 2: Can't sign CSR (Minikube, Docker driver, Arm M1)

In Chapter 2, following the instructions for Creating a Subject (pp. 15-16). Step 4 ("Sign the CSR...") fails as below:
openssl x509 -req -in johndoe.csr -CA /.minikube/ca.crt -CAkey /.minikube/ca.key -CAcreateserial -out johndoe.crt -days 364
Can't open /.minikube/ca.crt for reading, No such file or directory

I have confirmed that on my local machine, ~/.minikube contains ca.key and ca.crt:
user@LOCAL .minikube % ls
addons			certs			machines
ca.crt			config			profiles
ca.key			files			proxy-client-ca.crt
ca.pem			key.pem			proxy-client-ca.key
cache			logs
cert.pem		machine_client.lock

(and both files have content, i.e. certificate and key). Running:

Minikube v.1.32.2
Docker Engine 24.0.6
Apple M1/ARM.

Thanks!

Based on the error message you provided, it seems like you are missing the ~ character for the path to refer to .minikube in the user home directory.

Thanks, @bmuschko -- so that's a typo in the book, then, which I can log in the errata. But more importantly, if I put the ~ back in, then it at least finds the signature, but Docker still fails:
docker@minikube:~/cert$ openssl x509 -req -in johndoe.csr -CA ~/.minikube/ca.crt -CAkey ~/.minikube/ca.key -CAcreateserial -out johndoe.crt -days 364
Signature ok
subject=CN = johndoe, O = cka-study-guide
Can't open /home/docker/.minikube/ca.crt for reading, No such file or directory
281473422404064:error:02001002:system library:fopen:No such file or directory:../crypto/bio/bss_file.c:69:fopen('/home/docker/.minikube/ca.crt','r')
281473422404064:error:2006D080:BIO routines:BIO_new_file:no such file:../crypto/bio/bss_file.c:76:
unable to load certificate

Ugh, you are right. There's an issue with the formatting of that command in the book. In the text above the command, you can see another incorrect formatting <code>.... Would you mind sending that to the errata?
In regard to the commands, check this script I use during my live training: https://github.com/bmuschko/cka-crash-course/blob/master/exercises/01-rbac/create-user-context.sh

I added the this issue to the errata: https://app.oreilly.com/cs/portal/edit/errata/200061


Availability of SAP Discovery Center mission?

Sorry for all the new issues :-).
The README mentions that this project should be available in the SAP Discovery Center soon. I've tried different searches in the Mission Catalog:

multitenant
Sustainable
saas

but wasn't able to find it. Is the publication still planned?

Hi @gregorwolf,
Thanks for reaching out.
We need to align on this internally.
Not if that is the first priority, given the current workload.
I will align with my colleagues and come here again to update this issue.

I completely agree with Alper's comment, and I wanted to add a quick note. We are currently assessing the possibility of merging the Cloud Foundry repository with our Kyma repository. This consolidation would greatly streamline the maintenance of the corresponding Discovery Center mission and GitHub repository. However, please understand that our backlog is currently quite full, and we are prioritizing the most urgent updates first, as Alper mentioned. We appreciate your patience and understanding as we work through these tasks.

To set priorities right I would value additions and improvements to the sample itself more than adding it to the Discovery Center. The benefit of the Discovery Center is just the additional visibility.


Add automated tests for this repo

I recently went to do some work on this repo and found 2 unrelated issues that needed to be debugged and solved first.  We should set up an automated test to run at least weekly to catch these issues as they occur for easier debugging, and also as part of good development practice.
As a first pass, I'd propose just deploying the Vagrant vms which are in the tests folder successfully as the test.  We'll likely need to use CIrun in order to have a machine large enough to deploy the vms (requires 16 gb of ram just for vm's, though we could likely lower that a bit)

I'm working on this in the spawnviewer branch.  I'm getting the following currently.  I added libvirt, kvm, and qemu to the nix-shell file.  Not sure what's going wrong.
Bringing machine 'hpc01-test' up with 'libvirt' provider...
Bringing machine 'hpc02-test' up with 'libvirt' provider...
Bringing machine 'hpc03-test' up with 'libvirt' provider...
==> hpc03-test: An error occurred. The error will be shown after all tasks complete.
==> hpc01-test: An error occurred. The error will be shown after all tasks complete.
==> hpc02-test: An error occurred. The error will be shown after all tasks complete.
An error occurred while executing multiple actions in parallel.
Any errors that occurred are shown below.

An error occurred while executing the action on the 'hpc01-test'
machine. Please handle this error then try again:

Error while connecting to libvirt: Error making a connection to libvirt URI qemu:///system?no_verify=1&keyfile=/home/runnerx/.ssh/id_rsa:
Call to virConnectOpen failed: Failed to connect socket to '/var/run/libvirt/libvirt-sock': No such file or directory

An error occurred while executing the action on the 'hpc02-test'
machine. Please handle this error then try again:

Error while connecting to libvirt: Error making a connection to libvirt URI qemu:///system?no_verify=1&keyfile=/home/runnerx/.ssh/id_rsa:
Call to virConnectOpen failed: Failed to connect socket to '/var/run/libvirt/libvirt-sock': No such file or directory

An error occurred while executing the action on the 'hpc03-test'
machine. Please handle this error then try again:

Error while connecting to libvirt: Error making a connection to libvirt URI qemu:///system?no_verify=1&keyfile=/home/runnerx/.ssh/id_rsa:
Call to virConnectOpen failed: Failed to connect socket to '/var/run/libvirt/libvirt-sock': No such file or directory
Error: Process completed with exit code 1.

Or possibly try a metal machine if nested virtualization is not supported on non-metal aws ec2 instances.


BUG: become member should inside button

Is there an existing issue for this?

[X] I have searched the existing issues

What went down?

Record

[X] I agree to follow this project's Code of Conduct
[X] I'm a GSSOC'24 contributor
[X] I want to work on this issue

Hello @SUGAM-ARORA please assign this issue to me under gssoc 24


.env in /docker for workflow repos

docker-compose will throw an error without an .env file in /docker directory. Be sure to include/create them even if it's completely blank. This applies to all workflow repos.

Thanks @JaerongA!  I will close this issue since we are now migrating to Dev Containers for our example workflows, which should not have this requirement.  Please reopen if I missed anything.


Provide better instructions on how to get git credentials for Azure API management service using REST api

The API Management Service REST calls are not intuitive on how to generate the git credentials to clone the repo from my API service and push my policies.
I can check to see if the service has REST API management enabled using a http GET call. It returns a response body of
{
    "id": "git",
    "primaryKey": "key1",
    "secondaryKey": "key2",
    "enabled": true
}

Unsure how to attain the git secret for the apim user to clone my repo. The secret can only be generated through the portal?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 7d0120b7-a5fe-fead-e88b-cf1bab80ba73
Version Independent ID: 7371e474-727d-5bd1-600d-a502e9b17581
Content: Configure your API Management service using Git - Azure
Content Source: articles/api-management/api-management-configuration-repository-git.md
Service: api-management
GitHub Login: @vladvino
Microsoft Alias: apimpm

@NathanielRose You can get it from portal as well as from REST api call.
POST https://management.azure.com/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.ApiManagement/service/{serviceName}/users/{userId}/token?api-version=2018-06-01-preview
In this value of {userId} will be git.It is documented under User - Get Shared Access Token.
https://docs.microsoft.com/en-us/rest/api/apimanagement/user/getsharedaccesstoken
I have tried and it worked for me.
ex. https://management.azure.com/subscriptions/{mysubscriptionId}/resourceGroups/DixitRG/providers/Microsoft.ApiManagement/service/Dixitcxp/users/git/token?api-version=2018-06-01-preview

Hi @DixitArora-MSFT
I am looking to automate this process through terraform and the API Management Service does not have this in the terraform provider which requires us to use the REST API.
I am able to generate a token from a REST POST: https://management.azure.com/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.ApiManagement/service/{serviceName}/users/{userId}/token?api-version=2018-06-01-preview
However the value provided is still not able to clone the repo from apim. Is it possible to do the steps in this doc through the REST API?
https://docs.microsoft.com/en-us/azure/api-management/api-management-configuration-repository-git

@NathanielRose Almost every portal operation can be done through REST API.  This reference provides a guide for working with API Management REST API. Do let me know if there is any operation for which REST API is not exposed.

@DixitArora-MSFT The reference that you provided and the documentation for the API Management git configuration does not provide details on how to obtain the git secret. The git tenant is what I assumed to use which gives the tenant access response.
{
    "id": "git",
    "primaryKey": "key1",
    "secondaryKey": "key2",
    "enabled": true
}

From here it is very unclear what to do next. Your comment above explains that a user should use the users method to generate a token which is presumed that we should treat the apim git user as an API Management user.
In addition to this, the value response that is passed is url encoded and requires decoding to clone. All of this is not in the documentations and API Management is not offered through the CLI for an alternative to using the REST API.

@NathanielRose  If I understand your use case you are trying to generate the git credentials to clone the repo from API service and push policies. As you are trying to automate this through terraform which require you to use the REST API.
I agree with you that documentation is not intuitive with REST API calls for obtaining git credentials .
Regarding your query the value provided is still not able to clone the repo from apim. I am able to clone this with the value that is generated.
For generating the token we need to use below REST API call with value of {userId} equal to git.
(https://management.azure.com/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.ApiManagement/service/{serviceName}/users/{userId}/token?api-version=2018-06-01-preview)
Also if your ultimate goal is to push policies. You can also consider link for pushing the policies if this suits your requirement.
To see all the endpoints exposed for any resource, visit resource explorer and navigate to that specific resource.

@NathanielRose  Since we have not heard back from you we will now proceed to close this thread. If there are further questions regarding this matter, please tag me in your reply. We will gladly continue the discussion and we will reopen the issue.

Hello @DixitArora-MSFT ,
Excuse the delay due to travels.
We have provided a script that better explains how to generate Git credential for APIM scm repo here.
Can this be included in the docs for others to follow ho to obtain credentials?
Thanks!

@DixitArora-MSFT  The links for below are now dead. Do you have updated references?

Also if your ultimate goal is to push policies. You can also consider link for pushing the policies if this suits your requirement.

In this value of {userId} will be git. It is documented under User - Get Shared Access Token.
https://docs.microsoft.com/en-us/rest/api/apimanagement/user/getsharedaccesstoken


Developer should be able to push YAML into a Github Repo

Please describe the feature that you want to propose
Desired feature:
Should be able to link an integration to a GitHub repo. Thereafter there should be a button on the code preview screen that pushes changes to GitHub for change control reasons:

The "Sync your code" button (green check mark) should be renamed to "Build". Clicking it should enable the "GitHub" button if Kaoto detects that there has been a code change.
Justification:
Promotes good change control practices that align with the version control policies the customer likely already has in place. This feature is also a differentiator for Kaoto against other low-code platforms where change control is embedded into the platform.

For information, on the first iteration, the management of the Source Control system will be delegated to VS Code extensions. (so yes, it will be available only in VS Code).
For later iterations, it is planned to have ways to have Source Control system. The most probable will be that it will be delegated to an OpenShift service registry so that it can be integrated with several OpenShift services.
That said, it will be interesting to have a button too for standalone versions or in a simpler Kubernetes/OpenShift context.

Consider focusing on GitHub integrations so that Development Teams can use their existing CD practises/policies vis-a-vis source control and change management. #535 also has some relevance here where you'll want version-control WIP.


disable dynamic control

Hello ,
Please i am working with dynamic forms.
I just need to disable a TdDynamicInputComponent regarding a boolean.
How can i achieve that ?
THANKS.

We have an open issue for this. Since we cant do it atm.

Would that be #490?

closing since we will follow the thread in https://github.com/Teradata/covalent/issues/490


facing an error in line 144 read_post function

Hi. thank you for sharing your code. I'm trying to run BDANN_twitter.py but it faces an error line 144, in read_post
texts = open(pre_path + 'train_posts.txt', 'r').readlines()
return codecs.charmap_decode(input,self.errors,decoding_table)[0]
UnicodeDecodeError: 'charmap' codec can't decode byte 0x9d in position 6314: character maps to . could you tell me what changes is needed to get rid of this error?

Hi, thanks for your interest. I guess you can change code texts = open(pre_path + 'train_posts.txt', 'r').readlines() to texts = open(pre_path + 'train_posts.txt', 'r', encoding="utf8").readlines()
Hope this helps you.


Issue Memory leak

Dear Sirs,
I think that I found a RAM leak using QuestaSim on Windows.
In my simulation, I'm using the AXI VVC and I'm performing some AXI read every 46 us.
From the attachments, you can see two memory profiling reports, the first one is at 40 ms while the second is at 40.1 ms.
As you can see some code entries are consuming 10 MB of RAM every 100 us.
axi_channel_handler_pkg.vhd:561
generic_queue_pkg.vhd:988
generic_queue_pkg.vhd:786
axi_read_data_queue_pkg.vhd:122
generic_queue_pkg.vhd:443
memory_40000_us.txt
memory_40100_us.txt
I was not able to find the exact lines of code that produced the leak.
Best regards
Emanuele

Dear Sirs,
I tested this issue on a different platform:  Questasim 2023 on a Linux PC. The memory leak seems to be present in this case too.
Best regards
Emanuele


Add "space boundary guide" to discourage placing spaces far to edge

The editor could (by default) have a region boxed off that suggests where spaces should go. SuperZambezi improvised something like this on his stream.

I'd probably just make it a dotted line around the area. I'd make a setting to disable it.

That's good to know. ^^

Closing this, as the new Telescope feature includes the space boundary and helps diagnose when spaces are too close to the edge.


Multi period streams with SegmentTemplate not working anymore.

Test stream: GPAC "live profile with five periods" or any streams with multi period and SegmentTemplate.
It was this change that break it.
Compare buffering goals to the difference between next segment's start
Change-Id: Ie9fac1b427b631ac467656c15fd8608e12c07efc
commit 0df1ab0e8bc2a4a02935dbf0f1bbd05513b60333
The reason is the new way to calculate bufferAhead in shaka.media.StreamingEngine.prototype.update_ function.
It using getSegmentReferenceNeeded_  method and calculate bufferedAhead
bufferedAhead = needPeriod.startTime + reference.startTime - playheadTime;
This will be next period's start time plus start time of the segment reference from the current period after period end (this segment should not exist).
This will make bufferAhead to big which cause that we fall out of the function that should make the period switch.
It's easy to reproduce and track, play GPAC "live profile with five periods" and it will stop playback before period switch (after 2 min),
if you look at the v2 log for bufferAhead  you will see it's to big.

@PatrikCarlander
Thanks for such a detailed repro, we'll look into it.

I'm starting to think this might be a problem with this particular test stream that surfaced after the buffering goal calculation change.
@PatrikCarlander, did you encounter the issue through the "live profile with five periods" stream or do you have a custom stream that behaves the same way? Do you know of any other affected stream (demo or custom)?

We have this problem with our regular multi period segmented templated streams. It's not many sample stream of this kind online. I just remove this in Ericsson fork of shaka player. But it would be better if we fix this here. Problem is as a said it get a segment reference after period ended. So if we have 2 min period bufferAhead will be 120 sec and that make us jump out the function.

@PatrikCarlander our multi-period live manifests use segment template and work with the latest Shaka.
What we have seen is that if the period start time is not precise enough (rounding issues), you can run into problems like the one you describe.
I think (@ismena correct me if I'm wrong) reference should always be in needPeriod, but this might not hold if your period start times do not match your period durations as calculated by Shaka. As a side note, I think there might be a missing assertion here.
Can you see from the logs whether reference.endTime + period.startTime > nextPeriod.startTime?

I can add that I have also had rounding issues with our hls2dash [1] and had to be very careful not to lose any digits when calculating both start times and durations.
[1] https://github.com/Eyevinn/hls-to-dash

What is wrong with reference stream GPAC "live profile with five periods"? It worked before this commit.

Sorry about that, I misunderstood -- we use SegmentTemplate + SegmentTimeline with period start times. This manifest uses SegmentTemplates with period durations, and looks like a different issue. Sorry for the confusion!

@PatrikCarlander would you be able to provide a manifest for one of your custom streams that are also affected?

The  GPAC "live profile with five periods" should not be any problem to test with.
I can send you a privet stream if you send me an mail to<EMAIL_ADDRESS>(it's always sensitive to share broadcasters content).

Sounds good. I will reach out to you by email if we need a stream example.

I see the same issue with stream
http://lbd.kaltura.com:8001/mapped/playlist-saas.php/disc/1/type/vod/manifest.mpd
from bug #537
We get a bufferedAhead of 90 sec after period switch, which cause that we fall out of the function.

Found it!
The problem wasn't in the new buffering logic, but in the way we were getting a segment reference to calculate it.
(That's why I originally blamed the stream itself thinking it had a 'ghost' segment).
Thanks @PatrikCarlander, having a second example helped.
Let me know if the fix resolves the problem with your custom stream.

Thanks. This fix resolve the problem.


Allow a uuid passed to project name to retrieve the project

Description of change
Sometime users are unsure of whether they need to pass a project ID or a project name.
This has been exacerbated by docs and our UI design. But nonetheless, the confusion
can arise. A reasonable approach might be to be permissive. For example if they happen
to pass the ID to --project-name, just let them have it anyway. This approach requires
a bit on consideration. But as it  is such a small change I simply created this PR, to consider.
Guide to reproduce test results
Try running
resim project get --name <a valid project uuid>
And verify that it works.
Checklist

[x] I have self-reviewed this change.
[x] I have tested this change.
[ ] This change is covered by tests that are already landed, or in this PR.

@iainjwhiteside - slightly in two minds about whether this is a good change or not. But throwing it out there for consideration.

@iainjwhiteside - I know you stamped this already But i made quite a few additional changes, including rebasing on your tests PR and modifying/extending tests.
The major logical change was checking for tests that are named with a UUID that happens to be an ID of another test. Seems like the kind of thing that could happen as a copy-paste error, so wanted to cover it.


Opposing end of half-shutdown socketpair incorrectly indicates EOF

Build Number: Microsoft Windows [Version 10.0.17134.376]
What you're doing and what's happening:

Call socketpair(AF_UNIX, ..)
Set both sides O_NONBLOCK
Call shutdown(a, SHUT_WR)
Call read(b, .., 1)

read() fails with EAGAIN, as if the socket hasn't been partially shut down. Linux/OS X  both calls succeed and indicate 0 bytes read, which is commonly interpreted to indicate disconnection.
As shown in the script below, WSL is generating conflicting indicators: the socket is marked as readable by select(), but on attempting to read it, EAGAIN is generated.
Strace:
socketpair(AF_UNIX, SOCK_STREAM, 0, [3, 4]) = 0
fcntl(3, F_GETFL)                       = 0x2 (flags O_RDWR)
fcntl(3, F_SETFL, O_RDWR|O_NONBLOCK)    = 0
fcntl(4, F_GETFL)                       = 0x2 (flags O_RDWR)
fcntl(4, F_SETFL, O_RDWR|O_NONBLOCK)    = 0
sendto(3, "x", 1, 0, NULL, 0)           = 1
select(5, [4], [], [], {tv_sec=0, tv_usec=0}) = 1 (in [4], left {tv_sec=0, tv_usec=0})
read(4, "x", 1)                         = 1
shutdown(3, SHUT_WR)                    = 0
select(5, [4], [], [], {tv_sec=0, tv_usec=0}) = 1 (in [4], left {tv_sec=0, tv_usec=0})
read(4, 0x7fe8bb36dc0c, 1)              = -1 EAGAIN (Resource temporarily unavailable)

Reproduction script (run with CWD = Git checkout of https://github.com/dw/mitogen/ or just replace the set_nonblock call):
import socket
import os
import select

import mitogen.core

s1,s2 = socket.socketpair()
mitogen.core.set_nonblock(s1.fileno())
mitogen.core.set_nonblock(s2.fileno())

def is_ready(f):
    r,_,_ = select.select([f], [], [], 0)
    return len(r) > 0

s1.send('x')
assert is_ready(s2)
assert 'x' == os.read(s2.fileno(), 1)

s1.shutdown(socket.SHUT_WR)
assert is_ready(s2)
assert '' == os.read(s2.fileno(), 1)

Bugs:

https://github.com/dw/mitogen/issues/323
https://github.com/dw/mitogen/issues/333

Haven't done a side-by-side, but this sure smells like #3100. You are on 17134 and it wasn't fixed until 17666. Give RS5 aka 1809 aka 17763 a try and see if that helps.

Looks very similar! Is there a way to get RS5 without enabling insider on my main laptop?

1809 is the "October 2018 Update". You shouldn't need to be on Insiders. I don't really follow the status of the update rollout (and I don't work at MSFT) but you should get it automatically, eventually, if you haven't already.

@therealkenc The rollout of 1809 is currently halted are the file deletion bugs and other critical issues I think.


ENH: interpolate: handle length-1 grid axes in RegularGridInterpolator

Reference issue

closes gh-5890, closes gh-7560, closes gh-9524
What does this implement/fix?

Make regular grid interpolator handle length-one dimensions with method='linear'.  So follow https://github.com/scipy/scipy/issues/5890#issuecomment-189882317 and make it extrapolate along this axis.
If one of the grid axes has length-1, then
(i) Interpolation should work along the axis (linear, nearest), and
(ii) In the orthogonal direction, it's extrapolation. Thus,  fill_value = None should extrapolate, otherwise the result  simply equals  fill_value.
Additional information

This has been requested at least three times from 2016, cf linked issues. So ISTM the functionality is wanted by users, is not unreasonable, and is not hard to implement.

This implements the linked suggestion accurately. (In stats, I've seen a lot of _lazywhere instead of where, but with np.errstate works, too.)
I want to check a few things when I'm at a computer, but this looks 👍.

I've forgotten that _lazywhere is now in _lib, so not stat-only anymore. On a side note, I used to be rather strongly against np.errstate in the library code, not so much anymore apparently :-).
Do you want me to change it to _lazywhere here?

Do you want me to change it to _lazywhere here?

Not necessarily. Up to you. I don't think it matters much here.

OK, let me know when you're happy with this. I had also suggested adding the example from gh-7560 and adapting the property-based test to test interpn, too, but that's all make-better. I'll squash-merge (if that's OK?) when you're ready?

Fine by me!


07/09/2018 19:03 : Create Pull Request for branch master -> prTesting1_2018070919

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

split/updateTestRef1.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


create responsive containers

Motivation
Currently with .container and .container-fluid we have an all or nothing approach to either a full width or fixed width layout.  I would like to make these containers responsive to give the end user full control over when the switch to a fixed width layout occurs.
It was brought up in PR #24903 , and discussed on the Slack channel. The use case I am addressing in this PR is actually the opposite of what's being asked in the other one, because I see this as the more 99% use case.
Example
The most common use case I see is the user who wants their extra small and small devices to maintain a fluid layout since real estate is at a premium, and only switch to a fixed layout on medium devices and larger where you have much more width.
Approach
If you dig into the source on containers you realize that on extra small devices, .container and .container-fluid are the same. It's not until you hit the larger sizes that max-widths start getting applied.  The approach I use is similar to all the other responsive classes where styling is applied to the breakpoint and up.  This PR introduces 4 new classes which can be used in place of existing container classes.

.container-sm
.container-md
.container-lg
.container-xl

As an example,

would mean the container stays fluid until you hit the medium breakpoint, and from there on up it would be fixed width.  This table gives you a full breakdown.

XS Screen
SM Screen
MD Screen
LG Screen
XL Screen

.container
fixed *
fixed
fixed
fixed
fixed

.container-sm
fluid
fixed
fixed
fixed
fixed

.container-md
fluid
fluid
fixed
fixed
fixed

.container-lg
fluid
fluid
fluid
fixed
fixed

.container-xl
fluid
fluid
fluid
fluid
fixed

.container-fluid
fluid
fluid
fluid
fluid
fluid

As you can see, the .container and .container-fluid maintain the same functionality so backwards compatibility is maintained.
Next Steps
I imagine this PR will require a decent amount of discussion. One point to address is if it is worth it to be able to go the other direction as well, and switch from a fixed layout to a fluid layout after a certain breakpoint.
Also, I'm sure I could also use some help on optimizing the SCSS.

It might be easier to comprehend if you can see the (desired) compiled code, so here is the CSS:
.container,
.container-fluid,
.container-sm,
.container-md,
.container-lg,
.container-xl {
  width: 100%;
  padding-right: ($grid-gutter-width / 2);
  padding-left: ($grid-gutter-width / 2);
  margin-right: auto;
  margin-left: auto;
}

@media (min-width: 576px) {
  .container,
  .container-sm {
    max-width: 540px;
  }
}

@media (min-width: 768px) {
  .container,
  .container-sm,
  .container-md {
    max-width: 720px;
  }
}

@media (min-width: 992px) {
  .container,
  .container-sm,
  .container-md,
  .container-lg {
    max-width: 960px;
  }
}

@media (min-width: 1200px) {
  .container,
  .container-sm,
  .container-md,
  .container-lg,
  .container-xl {
    max-width: 1140px;
  }
}

ping @chasepalmer

Hi @browner12 Thanks a lot for your contribution, the idea is clear and intresting, and I see how this can be useful.
I got your branch and test it out and it works as it should.
I don't know if the naming container-* represent what it does, but naming is really hard and I can't come up with a better option at the moment.
I'll be up to @mdo to decide on this one 😄

This is something I always meant to look into myself since I needed it for a project, but worked around it locally and forgot about it :)
I'd like to see this merged too, so 👍 from me.

Why not use the same approach here as is already being done with rows/columns:
.container,
.container-fluid {
  width: 100%;
  padding-right: ($grid-gutter-width / 2);
  padding-left: ($grid-gutter-width / 2);
  margin-right: auto;
  margin-left: auto;
}

@media (min-width: 576px) {
  .container,
  .container-sm {
    max-width: 540px;
  }
  .container-sm-fluid {
    width: 100%;
    padding-right: ($grid-gutter-width / 2);
    padding-left: ($grid-gutter-width / 2);
    margin-right: auto;
    margin-left: auto;
  }
}

@media (min-width: 768px) {
  .container,
  .container-sm,
  .container-md {
    max-width: 720px;
  }
  .container-sm-fluid,
  .container-md-fluid {
    width: 100%;
    padding-right: ($grid-gutter-width / 2);
    padding-left: ($grid-gutter-width / 2);
    margin-right: auto;
    margin-left: auto;
  }
}

@media (min-width: 992px) {
  .container,
  .container-sm,
  .container-md,
  .container-lg {
    max-width: 960px;
  }
  .container-sm-fluid,
  .container-md-fluid,
  .container-lg-fluid {
    width: 100%;
    padding-right: ($grid-gutter-width / 2);
    padding-left: ($grid-gutter-width / 2);
    margin-right: auto;
    margin-left: auto;
  }
}

@media (min-width: 1200px) {
  .container,
  .container-sm,
  .container-md,
  .container-lg,
  .container-xl {
    max-width: 1140px;
  }
  .container-sm-fluid,
  .container-md-fluid,
  .container-lg-fluid,
  .container-xl-fluid {
    width: 100%;
    padding-right: ($grid-gutter-width / 2);
    padding-left: ($grid-gutter-width / 2);
    margin-right: auto;
    margin-left: auto;
  }
}

If we can give the user this full control for whether their breakpoint is fluid or fixed, I'm all for that.  Even though I feel like switching from a fixed container on a smallish device to a fluid container on a largish device will be a very uncommon use case.
My one concern with your code is we will need to reset the max-width property for all higher breakpoints, since our media queries to do have an upper bound, but simply a min-width.
For example:

The relevant media queries would be:
@media (min-width: 576px) {
  .container,
  .container-sm {
    max-width: 540px;
  }
  .container-sm-fluid {
    width: 100%;
    padding-right: ($grid-gutter-width / 2);
    padding-left: ($grid-gutter-width / 2);
    margin-right: auto;
    margin-left: auto;
  }
}

@media (min-width: 768px) {
  .container,
  .container-sm,
  .container-md {
    max-width: 720px;
  }
  .container-sm-fluid,
  .container-md-fluid {
    width: 100%;
    padding-right: ($grid-gutter-width / 2);
    padding-left: ($grid-gutter-width / 2);
    margin-right: auto;
    margin-left: auto;
  }
}

This would mean on a device >768px even though it has a width: 100% from the container-md-fluid, it still has the max-width:540px from the .container-sm.  Therefore it would still (I believe) behave as a fixed width container at this point.   It may be as simple as resetting it with max-width:none for those responsive fluid classes.

any movement on this? I'm not sure what the turnaround time is like on new features in this repo.

I'm not sure what the turnaround time is like on new features in this repo

"hey, i know you're all volunteers, doing this for free in your spare time to give away for free...but any idea when you'll have this done or what?"

sorry @patrickhlauke, the way you read it is not at all the way I meant it.
just legitimately curious if we like to take the new features a little slower to flesh them out more. For the projects I contribute to, I have a better understanding of the pacing of things, and was just trying to get a feel for BS.
I absolutely share your sentiment on people feeling entitled to OSS, and thanks for all you do in this project.

yeah sorry, flew off the handle there...hence deleted the comment. missed the context that this was a PR as well.

@browner12 Sorry for the delay! I'm going to pull this down and write some docs for it.

Checking it out locally, the code doesn't generate what you've put into your desired output comment.

yah, i think i need some help with the Sass.
i'll give it a shot this week

Yeah, I'll see about trying to take another look, too :). These layers of loops, maps, and what not always trip me up.

@mdo I was able to clean up the top part with an @extend directive.
I'm running into an issue in the media queries where @extend returns the error

you may not extend an outer selector from within media

which I feel shouldn't apply because I'm trying to extend a selector from within the media query.
Any thoughts on that part?

bump

could we put this on either the 4.2 or 4.3 project board?

@browner12 Haven't forgotten about this. v4.2 is up after v4.1.2, so stay tuned!

thanks @mdo ! 4.1 and 4.2 are looking great!

Checked this out locally—.container- specific changes look good. However, I realized that this may require additional changes for the navbar. There are .navbar .container and .navbar .container-fluid selectors in there. Not sure the best way forward on that just yet...

hey @mdo. made the necessary change to make the containers work in the navbars. would love a second set of eyes on it.
I don't love how I had to add the global scoped variable to the top of _navbar.scss. Was wondering if it would be good to move this into _variables.scss since I'm now using it in more than one file.

Thanks @browner12! Looking at the diff, we've lost .container-fluid outright now.
Also, curious if we can get away from some of the complexity with .navbar [class^="container-"] { ... } instead of listing all the responsive container classes out again?

what do you mean by, "lost .container-fluid outright now"?
for listing them all out again, are you talking about this part:
$combined-container-max-widths: map-merge(
  (
    xs: 0,
    fluid: 9999px,
  ),
  $container-max-widths
) !default;

I was actually going to ask about this, because as I was writing it, it was feeling a little messy.  Since we use this same code on both _grid.scss and _navbar.scss, would it be appropriate to extract it to _variables.scss?

Quick look at current diff shows .container-fluid class is gone from the sass code, that may be what @mdo meant by "lost .container-fluid outright now".

correct, we remove .container-fluid and add it the the map that we loop over.
could we extract the map-merge to _variables.scss?

I'm not sass pro, but if your change means that class="container-fluid" is gone, then this is breaking change that can't be merged to 4.2

it doesn't remove it from the compiled code, it's just doesn't explicitly declare it separately in the SASS anymore.

What is the purpose of this PR?
Afaik container class already scales for different viewports perfectly. Can OP olaborate why to add additional class for each viewport?

Just to give a real use case of this PR, I am developing a responsive form and it's currently broken-ish between 768px and 991px (sm).
The base layout (sm+) uses two columns (8/4) on a container. I don't want to switch to our mobile layout for sm resolutions, There is just enough width to display both columns pretty well up to 780px, but the container's width is fixed to 720px on sm. I get that we need to support 768px anyway, so might as well apply media queries all the way up to 991px, but I'd rather sacrifice consistency over a good UX for most of sm resolutions.
In this case, I would use container-fluid up to sm and then switch to container for md+. In the past, I have implemented this behavior using container-fluid all the way and applying offsets on md+, but the downside is that the content keeps resizing.

@MartijnCuppens anything I can do to help get this in 4.2? really don't want to wait until 4.3 for this.

@browner12,
I understand, but we've decided to postpone all new features to v4.3. There are a lot of features I personally would love to have in v4.2, but we're at a point we can no longer postpone the release of v4.3 anymore.

gotcha, thanks for the response.

With your first commit, is there a benefit to removing the map-merge? My one concern here is we're now duplicating the @extends %containers; code, which could lead to divergence if people don't realize they're doing the same thing.
It looks like your second commit is the same thing, but for the _navbar.scss.
This is why I asked/suggested we move the map merge to _variables.scss. Then we could refactor that duplication to just one spot, and then still keep my original loops here.
Thoughts?
It looks like what you have here will still compile the same, BTW.

The values of the map weren't used, didn't make sense to merge maps here. The generated code should indeed be the same.
We 'll need some docs for this. I guess a separate examples page will be most interesting to demonstrate this?

Sorry, I don't follow that. What do you mean "the values weren't used"?  Are you referring to the '0' and '9999px' values? because the keys were definitely being used in the loop.

Yup, was talking about the 0 and 9999px

I guess I preferred the original code, because it avoided the duplication, but it's not a hill I'm going to die on.
They both seem to generate the same output, so I'm okay with it.
I think the documentation could go on this page: https://getbootstrap.com/docs/4.1/layout/overview/#containers

@browner12 how to make resp. containers in v4.2 release?

it was not merged in yet, so you'll have to wait until 4.3

I might be overthinking this after coming back to the PR a few times over the last several months, but this feels a little off still. The latest changes from @MartijnCuppens output multiple container classes per media query when I think we'd want a single container per breakpoint.
For example, here's what @browner12's earliest comment shows for compiled CSS, and this is matched by @MartijnCuppens's latest changes.
.container,
.container-fluid,
.container-sm,
.container-md,
.container-lg,
.container-xl {
  width: 100%;
  padding-right: ($grid-gutter-width / 2);
  padding-left: ($grid-gutter-width / 2);
  margin-right: auto;
  margin-left: auto;
}

@media (min-width: 576px) {
  .container,
  .container-sm {
    max-width: 540px;
  }
}

@media (min-width: 768px) {
  .container,
  .container-sm,
  .container-md {
    max-width: 720px;
  }
}

@media (min-width: 992px) {
  .container,
  .container-sm,
  .container-md,
  .container-lg {
    max-width: 960px;
  }
}

@media (min-width: 1200px) {
  .container,
  .container-sm,
  .container-md,
  .container-lg,
  .container-xl {
    max-width: 1140px;
  }
}

But wouldn't we want this instead? See the CodePen demo. (Forgive the shorthand attribute selector, and note .container-fluid is absent as it's covered by that selector.)
[class^="container"] {
  padding-right: 1.5rem;
  padding-left: 1.5rem;
  margin-right: auto;
  margin-left: auto;
}

.container {
  max-width: 980px;
}

@media (min-width: 576px) {
  .container-sm {
    max-width: 540px;
  }
}

@media (min-width: 768px) {
  .container-md {
    max-width: 720px;
  }
}

@media (min-width: 992px) {
  .container-lg {
    max-width: 960px;
  }
}

@media (min-width: 1200px) {
  .container-xl {
    max-width: 1140px;
  }
}

I don't think that behaves the same.
For example, let's assume

and a viewport width of 800px.
With my original code the
 would fall under the following media query
@media (min-width: 768px) {
  .container,
  .container-sm,
  .container-md {
    max-width: 720px;
  }
}

and have a width of 720px.
With your new code, it would fall under the following media query
@media (min-width: 576px) {
  .container-sm {
    max-width: 540px;
  }
}

and have a width of 540px.
With that new code the container doesn't grow as the screen size grows.

It all depends on what we want. The behaviour of this PR and the codepen of @mdo is indeed different.
As a comparison, this is the behaviour of the current implementation: https://codepen.io/MartijnCuppens/pen/pqaGzd?editors=1100
I personally think case of @mdo would be used more. @andresgalante, what do you think?

I strongly disagree.
Let's take a more extreme example. Let's again assume HTML of

but this time a screen size of 2000px. With the new code we would still have a container width of 540px, meaning it's taking up approximately 1/4 of the screen width. Even if we continue growing the screen size, 2100px, 2200px, the container is still stuck at 540px.
With this new code, you are changing the fundamental purpose behind containers. Previously we essentially had 2 states, a .container-fluid state (1) where the element was always 100% of its parent, and a .container state (2) where the element was approximately between 70-95% of its parent. This was good because it allowed us to effectively use our screen width.
Now we've got 5 distinct states:

.container-sm 540px
.container-md 720px
.container-lg 960px
.container 980px <-- where did this one come from?
.container-xl 1140px

and a very inefficient use of our screen width.
My original PR maintains those 2 original states, but gives us the ability to decide at which breakpoint we want to switch from state 1 to state 2.
You've also broken all of the backwards compatibility. A .container is now stuck permanently at 980px rather than adapting to the screen width.

Your codepen is not accurate.  Try this one instead:
https://codepen.io/anon/pen/YdawZJ?editors=1100

.container-xx that never gets wider than specified for it seems more usable (speaking from experience). I am catching myself plenty of times when I want to limit width of some content (eg. message). @mdo proposition appears more clean than what I am currently doing (.container .row .col-md-8).

Really looking forward to this being baked in! It’s something I use on every website I make.

Please merge this

My use case for wanting .container-*-fluid is to only turn on fluidity below a certain breakpoint.
I have a layout that uses non-fluid containers at desktop sizes so the site, and most importantly, it's header/navbar, lines up with the rest of the page.
However, once you get to tablet and mobile sizes, I want that header/navbar to become fluid, so that the brand/logo sits as far left as possible and the nav menu sits as far right as possible.
I've solved this using my own custom class and media query
  .container-md-fluid {
    @include media-breakpoint-down(md) {
      max-width: 100%;
    }
  }

@Soviut if I'm understanding you correctly, that's exactly what my PR solves.  You would use container-lg and all screen sizes MD and down would be fluid, while LG and up would be fixed.

@browner12 yeah, I was just reinforcing that use case since there were some proposals that seemed like the opposite (fluid on larger screens).
My only issue is the name; I feel like the container-*-fluid is more in keeping with the convention set by other breakpoint classes. eg: d-lg-flex, col-md-6, text-sm-right, etc.

Can someone who likes the alternate behavior please explain to me your reasoning and a possible use case? I am honestly struggling to see the benefit of that approach. Why would people want Bootstrap predefined max-widths when they could just add their own specific ones as needed?

Back in my original comment, I laid out a (IMO) very plausible use case, and one that I've run into many times

The most common use case I see is the user who wants their extra small and small devices to maintain a fluid layout since real estate is at a premium, and only switch to a fixed layout on medium devices and larger where you have much more width.

The purpose of the .container, as it currently stands is to be responsive and adapt to the growing screen width to use as much real estate as possible. We are trying to add to this ability to effectively use screen width by giving the user the ability to choose where the container switches from fluid to fixed.
The alternate behavior takes the responsive aspect of the .container away. I think it will also add to the confusion, because .container will behave differently than all of the others. With this approach, I can also see in the future people saying "Well, I want the
 to be a .container-sm on small and medium devices, but I want it to be a .container-lg on large and extra large devices." and then we're basically back to where we started.

I found myself on the same boat once and my solution matched the one from @mdo.
In my experience, when you build a mobile-first website, you want your layout to take the full width of the mobile device, usually up to a small laptop.
Extrapolating to bootstrap named breakpoints, you want your layout to grow in width up to the xl breakpoint.
With @mdo approach, you would set the .container-xl class in your container and it would do the job seamlessly, starting fluid and constraining on the xl breakpoint. Similarly, if you wanted your layout to grow up to the md breakpoint, you would set your container class to .container-md and you are done. On the other hand, with your approach, the container grows fluid to the desired breakpoint, and then it adapts the behaviour of the default .container class, increasing in width at each grid breakpoint. For me, this feels wrong and not the natural way to do, but hey, again, I'm talking based on my own experiences and of course, I might be wrong.

Can someone who likes the alternate behavior please explain to me your reasoning and a possible use case? I am honestly struggling to see the benefit of that approach. Why would people want Bootstrap predefined max-widths when they could just add their own specific ones as needed?

Back in my original comment, I laid out a (IMO) very plausible use case, and one that I've run into many times

The most common use case I see is the user who wants their extra small and small devices to maintain a fluid layout since real estate is at a premium, and only switch to a fixed layout on medium devices and larger where you have much more width.

The purpose of the .container, as it currently stands is to be responsive and adapt to the growing screen width to use as much real estate as possible. We are trying to add to this ability to effectively use screen width by giving the user the ability to choose where the container switches from fluid to fixed.
The alternate behavior takes the responsive aspect of the .container away. I think it will also add to the confusion, because .container will behave differently than all of the others. With this approach, I can also see in the future people saying "Well, I want the
 to be a .container-sm on small and medium devices, but I want it to be a .container-lg on large and extra large devices." and then we're basically back to where we started.

I found myself on the same boat once and my solution matched the one from @mdo.
In my experience, when you build a mobile-first website, you want your layout to take the full width of the mobile device, usually up to a small laptop.
Extrapolating to bootstrap named breakpoints, you want your layout to grow in width up to the xl breakpoint.
With @mdo approach, you would set the .container-xl class in your container and it would do the job seamlessly, starting fluid and constraining on the xl breakpoint. Similarly, if you wanted your layout to grow up to the md breakpoint, you would set your container class to .container-md and you are done. On the other hand, with your approach, the container grows fluid to the desired breakpoint, and then it adapts the behaviour of the default .container class, increasing in width at each grid breakpoint. For me, this feels wrong and not the natural way to do, but hey, again, I'm talking based on my own experiences and of course, I might be wrong.

@Tylerian so if I'm understanding you correctly, you would want .container.md to be fluid up til the MD breakpoint, and then stick at a defined width for all wider sizes?  That would mean on a 2000px wide screen, the container would be 720px wide.
IMO, this looks silly, and is not a common use case.  As I stated before, this takes away the responsiveness of the container, and people should write their own code for this.
Do you have a live example where you've used it this way?  It might be helpful for me to see.

If you liked the original functionality of this PR, please voice your concern on the new one. It has been merged, and completely changes how this feature will work.
https://github.com/twbs/bootstrap/pull/29095

hallelujah, thanks guys!

Just for clarification. This will go into 4.4 as described by @browner12 in the initial post?

@jandante: Yes, you can view the ship list here: https://github.com/twbs/bootstrap/issues/29096
The v4.4.0 project board can be found here: https://github.com/twbs/bootstrap/projects/18


added notifications for kong provider

What type of PR is this?

/kind feature
What this PR does / why we need it:
This PR adds notifications for conversion of Kong provider
Which issue(s) this PR fixes:

This pull request addresses part of the issue described in #131
Does this PR introduce a user-facing change?:

Added notifications for Kong

/cc @mlavacca @LiorLieberman

Work on gateway merging, plugin feature parser and successful conversions is pending due to some clarifications required

Thanks for this PR, @Devaansh-Kumar!
My general feedback is that we definitely need tests for this PR. You could improve the already existing tests we have in the Kong provider by adding checks on the notifications created. WDYT?

Yes I suppose we can add a NotificationAggregator field to the testCases struct and check if it is properly filled or not. Is this what you meant?

Thanks, @Devaansh-Kumar!
/approve
/lgtm


Uncaught TypeError: Cannot read property 'isComment' of undefined

Using the editor:move-line-up command while editing a markdown document caused the line highlighted to disappear and the following error to be thrown.
TypeError: Cannot read property 'isComment' of undefined
    at TokenizedBuffer.module.exports.TokenizedBuffer.isFoldableCodeAtRow (/usr/share/atom/resources/app.asar/src/tokenized-buffer.js:429:71)
    at TokenizedBuffer.module.exports.TokenizedBuffer.isFoldableAtRow (/usr/share/atom/resources/app.asar/src/tokenized-buffer.js:424:19)
    at TokenizedBuffer.module.exports.TokenizedBuffer.updateFoldableStatus (/usr/share/atom/resources/app.asar/src/tokenized-buffer.js:412:25)
    at TokenizedBuffer.module.exports.TokenizedBuffer.handleBufferChange (/usr/share/atom/resources/app.asar/src/tokenized-buffer.js:377:20)
    at /usr/share/atom/resources/app.asar/src/tokenized-buffer.js:62:24
    at Emitter.module.exports.Emitter.emit (/usr/share/atom/resources/app.asar/node_modules/event-kit/lib/emitter.js:82:11)
    at TextBuffer.module.exports.TextBuffer.applyChange (/usr/share/atom/resources/app.asar/node_modules/text-buffer/lib/text-buffer.js:624:20)
    at TextBuffer.module.exports.TextBuffer.revertToCheckpoint (/usr/share/atom/resources/app.asar/node_modules/text-buffer/lib/text-buffer.js:789:16)
    at TextBuffer.module.exports.TextBuffer.transact (/usr/share/atom/resources/app.asar/node_modules/text-buffer/lib/text-buffer.js:753:14)
    at TextEditor.module.exports.TextEditor.transact (/usr/share/atom/resources/app.asar/src/text-editor.js:1136:26)

Thanks for the report, @mrkwse -- this looks like a duplicate of https://github.com/atom/atom/issues/5905 (see https://github.com/atom/atom/issues/5905#issuecomment-104222091).
Can you add a comment to that issue and provide a bit more information -- which version of Atom you're running, which OS, and which packages you have installed (apm list).


sublime text3  do not support universal ctags

when i make .tag by universal ctags, sublime text 3 do not go to define by the .ctags!!!

Same issue here :(

Same issue here :(

Fixed by 0.5.1


Fix(frontend):  fix Navigation component z-index for small devices

This PR fixes #618
Changes the frontend/src/Navigation.tsx component's z-index.
This was needed because the content that should be below the header was flowing over it in small screens. See below:

Hi @tenokami . Hope you're well. I understand you might be busy. I was just wondering when can i expect this PR to get merged? Appreciate your time and efforts. 🙂

@Bitnagar, @dartpain Will review and merge it as soon as he can. Thank you for your patience


chore: copy redhat overlays from redhat-v1.2.2

/cc @lance, did this following the methodology you shared.

Seems like lance beat me to it. Closing.


Document and test ale_python_vulture_options

The Vulture linter already supports ale_python_vulture_options, but it is not documented or tested.  Since Vulture only supports configuration via options, it is an important use case.  Add docs and test.
Cheers,
Kevin

Apparently the build failed on Travis for --neovim-only.  However, I don't see any failure messages in the output and the build passed on my repo before submission.  Can the failure be ignored (or the build restarted)?

It just fails randomly some times. Cheers! :beers:

No worries.  Good to know.  Thanks again @w0rp!  :beers:


Collapsible pushing item out of screen

I am having the current issue:
https://stackoverflow.com/questions/53435735/how-to-display-elements-after-a-collapsible-within-the-screen
Figured I would post it here just in case you have some alternate solution.
Seems similar to #5 except that I'm not sure how setting a height would help me, specially since the height of the two <TouchableOpacity>s changes depending on what their contents are.
The idea is to have both <TouchableOpacity>s within the screen and have the component in the Collapsible resize accordingly given that it returns a <FlatList>.
Any pointers would be of great help. Thank you.

Do you have a visual of this? Or can you recreate this in http://snack.expo.io/?

Sorry I took all day. Here is a demonstration:
https://snack.expo.io/@yokhen/collapsible-flatlist-brainwreck

Kk I looked at the snack, this issue is a duplicate of #86


How to host only the book directory

Hi, this is clearly a problem with my knowledge but how does one actually make GH pages host only the book directory? It would be good to have that in the docs.

What I did was to publish the main branch (this operation creates a new branch for GitHub Pages which contains only the book directory), once the pipeline/action has finished the deployment, I changed the GitHub page source branch for the new one 'gh-pages'.
Now, everytime I make a commit on 'main'; it will automatically update the 'gh-pages' branch with the most recent book directory content and since it is the source branch for GitHub pages, it will create a new pipeline/action to deploy the book content because GitHub has detected a change in the 'gh-pages' branch.
Let me know if that helped you @un10able

Sorry for not seeing this issue.
md-book outputs a directory book
Then in the CI flow with GH Actions
https://github.com/MichaelCurrin/mdbook-quickstart/blob/main/.github/workflows/main.yml
...the contents of book are committed on the gh-pages directory at the root by this setup. No action needed. https://github.com/MichaelCurrin/mdbook-quickstart/tree/gh-pages


Add url option for what clib

I am running into an issue where I have prebuild building a linux version. Which then when I try to install in https://github.com/mhart/alpine-node
Prebuild pulls the linux build thinking it is acceptable however alpine uses musl libc not gnu libc
http://www.musl-libc.org/faq.html
So the binary is incompatible. I am wondering if there is anyway to add a URL option that would also include the libc version so that I could set travis to build for both options and tag them separately.
Thanks!

we don't have that as an option yet but can easily add it. what do the other contributors think?

Thanks. It looks like ldd could be used on linux to figure out what version of libc is available. Anything I can do to help let me know.

we don't have that as an option yet but can easily add it. what do the other contributors think?

+1
@juliangruber We had a similar problem with leveldown-hyper and alpine at NowSecure

@ralphtheninja can you take this one?

@juliangruber Sorry that I haven't responded until now. Been busy with irl :/ I'll try looking in to it this week.

@ralphtheninja I would be happy to take a crack at this if your busy. I am just wondering what you all think the best solution is. Given

This should only be an issue on Linux and BSD (only two OS I know of that Node supports might have different libc)
There is a default assumed libc for both
Node doesn't have the libc type in "process"
There does not seem to be a good terminal command I can find to say "what libc is this" (ldd appears to vary a lot even when it is normal glibc

I was thinking the best bet might just to be look for a LIBC env variable and if it is set make the upload/download URL allow that variable so the default template could become
{name}-v{version}-node-v{abi}-{platform}{libc}-{arch}.tar.gz
which makes it a nonbreaking change for the normal urls. I would then just issue a PR for the node alpine container to have ENV LIBC=musl This way I can do a separate CI prebuild in the alpine container and I would simply end up with two linux tars one the normal format and one with -linuxmusl-
Let me know if this sounds like a good solution

@corbinu Just hack something up and make a PR and then we can discuss and tweak it :)

Sorry for being late to the party, I missed this issue completely. Could this be ported to prebuild-install? This would make me things easier on NodeOS. Also, to check for the system default libc, I'm doing readlink /lib/ld-linux.so.2 | grep musl, this way I can be able to know if system libc is musl-based or not, for glibc it would be gnu instead.


Adding the Graph Visualization page to the Athens Guide.

Added graph visualization page.

@joelhans I don't think I'm getting github emails so just saw this, I submitted another PR and am closing this.