Bug: correctly formatting on <Leader>p, incorrectly formatting on save

Do you want to request a feature or report a bug?
Bug
What is the current/expected behavior?
current behavior: respecting let g:prettier#config#semi = 'false' on <Leader>p, but not on file save
expected behavior: same behavior on <Leader> p and file save
What version of vim-prettier are you using - (output of :PrettierVersion) ?
1.0.0-alpha
What version of prettier are you using - (output of :PrettierCliVersion) ?
1.16.4^@
What is your prettier executable path - (output of :PrettierCliPath) ?
../client/node_modules/.bin/prettier
Did this work in previous versions of vim-prettier and/or prettier ?
Not sure

Hi @n-xlkt ,
Thanks for reporting this issue, just to make sure i understood.

When using <Leader> p you get the formatting as you expected
When saving a file the auto formatting is not matching the one from <Leader> p ?

Can you provide a minimal sample code for me to reproduce and look into it ?
thanks a lot!

For sure! Hope this clarifies.
original sample:
import React, { Component, Fragment } from "react"
import { Row, Col } from 'react-bootstrap'
import { Link } from 'react-router-dom'

const overdueReview = {
  color: '#F15B4E'
}

using <Leader> p:
import React, { Component, Fragment } from 'react'
import { Row, Col } from 'react-bootstrap'
import { Link } from 'react-router-dom'

const overdueReview = {
  color: '#F15B4E'
}

using :w:
import React, { Component, Fragment } from "react";
import { Row, Col } from "react-bootstrap";
import { Link } from "react-router-dom";

const overdueReview = {
  color: "#F15B4E"
};

here's pertinent samples from my dots:
" ale linting events
let b:ale_fixers = ['prettier']
let g:ale_fix_on_save = 1
let g:ale_sign_error = '❌'
let g:ale_sign_warning = '⚠'

" prettier
let g:prettier#config#print_width = 100
let g:prettier#config#semi = 'false'
let g:prettier#config#trailing_comma = 'none'
let g:prettier#config#single_quote = 'true'```


Cannot follow getting started guide 'Creating a new role'

Issue Type

Bug report

Molecule and Ansible details
$ ansible --version && molecule --version
ansible [core 2.15.0]
  config file = /etc/ansible/ansible.cfg
  configured module search path = ['/Users/jgeerling/.ansible/plugins/modules', '/usr/share/ansible/plugins/modules']
  ansible python module location = /Users/jgeerling/Library/Python/3.9/lib/python/site-packages/ansible
  ansible collection location = /Users/jgeerling/.ansible/collections:/usr/share/ansible/collections
  executable location = /Users/jgeerling/Library/Python/3.9/bin/ansible
  python version = 3.9.6 (default, Mar 10 2023, 20:16:38) [Clang 14.0.3 (clang-14<IP_ADDRESS>.1)] (/Library/Developer/CommandLineTools/usr/bin/python3)
  jinja version = 3.1.2
  libyaml = True
molecule 5.0.1 using python 3.9
    ansible:2.15.0
    azure:23.4.1 from molecule_plugins
    containers:23.4.1 from molecule_plugins requiring collections: ansible.posix>=1.3.0 community.docker>=1.9.1 containers.podman>=1.8.1
    delegated:5.0.1 from molecule
    docker:23.4.1 from molecule_plugins requiring collections: community.docker>=3.0.2 ansible.posix>=1.4.0
    ec2:23.4.1 from molecule_plugins
    gce:23.4.1 from molecule_plugins requiring collections: google.cloud>=1.0.2 community.crypto>=1.8.0
    podman:23.4.1 from molecule_plugins requiring collections: containers.podman>=1.7.0 ansible.posix>=1.3.0
    vagrant:23.4.1 from molecule_plugins

Molecule installation method (one of):

pip

Ansible installation method (one of):

pip

Detail any linters or test runners used: N/A
Desired Behavior
If I run molecule init role acme.my_new_role --driver-name docker (as specified in the getting started guide), I should have a new role named my_new_role in the current directory, and no errors should display in the command output.
Actual Behaviour
After installing a fresh instance of Ansible + Molecule, and running the above command, I get:
$ molecule init role acme.my_new_role --driver-name docker
INFO     Initializing new role my_new_role...
Using /etc/ansible/ansible.cfg as config file
- Role my_new_role was created successfully
<IP_ADDRESS> | UNREACHABLE!: Data could not be sent to remote host "<IP_ADDRESS>". Make sure this host can be reached over ssh: ssh: connect to host <IP_ADDRESS> port 22: Connection refused
WARNING  Retrying execution failure 4 of: ansible localhost -o -m lineinfile -a path=my_new_role/meta/main.yml line="  namespace: acme" insertafter="  author: your name"
Traceback (most recent call last):
  File "/Users/jgeerling/Library/Python/3.9/bin/molecule", line 8, in <module>
    sys.exit(main())
  File "/Users/jgeerling/Library/Python/3.9/lib/python/site-packages/click/core.py", line 1130, in __call__
    return self.main(*args, **kwargs)
  File "/Users/jgeerling/Library/Python/3.9/lib/python/site-packages/click/core.py", line 1055, in main
    rv = self.invoke(ctx)
  File "/Users/jgeerling/Library/Python/3.9/lib/python/site-packages/click/core.py", line 1657, in invoke
    return _process_result(sub_ctx.command.invoke(sub_ctx))
  File "/Users/jgeerling/Library/Python/3.9/lib/python/site-packages/click/core.py", line 1657, in invoke
    return _process_result(sub_ctx.command.invoke(sub_ctx))
  File "/Users/jgeerling/Library/Python/3.9/lib/python/site-packages/click/core.py", line 1404, in invoke
    return ctx.invoke(self.callback, **ctx.params)
  File "/Users/jgeerling/Library/Python/3.9/lib/python/site-packages/click/core.py", line 760, in invoke
    return __callback(*args, **kwargs)
  File "/Users/jgeerling/Library/Python/3.9/lib/python/site-packages/click/decorators.py", line 26, in new_func
    return f(get_current_context(), *args, **kwargs)
  File "/Users/jgeerling/Library/Python/3.9/lib/python/site-packages/molecule/command/init/role.py", line 174, in role
    r.execute()
  File "/Users/jgeerling/Library/Python/3.9/lib/python/site-packages/molecule/command/init/role.py", line 102, in execute
    util.run_command(cmd, check=True)
  File "/Users/jgeerling/Library/Python/3.9/lib/python/site-packages/molecule/util.py", line 156, in run_command
    raise CalledProcessError(
subprocess.CalledProcessError: Command '['ansible', 'localhost', '-o', '-m', 'lineinfile', '-a', 'path=my_new_role/meta/main.yml line="  namespace: acme" insertafter="  author: your name"']' returned non-zero exit status 4.

I'm on a Mac running macOS Ventura 13.4 with Docker Desktop 4.17.0.
Possibly related: #3678

@geerlingguy
I cannot reproduce the issue on my MacOS.
I guess it may be because the Using /etc/ansible/ansible.cfg as config file.
Can you try to temporarily rename/remove the /etc/ansible/ansible.cfg and try again?


Feature request: Replace share links with links to fxtwitter

For Discord users, fxtwitter is a replacement for regular twitter link embeds. You can actually see the feature in action here.. It shows more info, allows for more pics to be embedded, and allows for videos to be embedded as well. Having a toggle to replace twitter.com links with fxtwitter.com using the share > "copy link to tweet" function would be an amazing addition.

Sorry, too niche for this extension, this would be better implemented in a dedicated extension


Update the Action name

Docs Build status updates of commit 89121db:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

msteams-platform/concepts/task-modules/task-modules-bots.md
:bulb:Suggestion

Details

msteams-platform/concepts/task-modules/task-modules-bots.md

Line 26: [Suggestion] Illegal link: below in the discussion on task/submit -- missing bookmark. The file concepts/task-modules/task-modules-bots.md doesn't contain a bookmark named the-flexibility-of-task-submit.
Line 50: [Suggestion] Illegal link: below -- missing bookmark. The file concepts/task-modules/task-modules-bots.md doesn't contain a bookmark named payload-of-task-fetch-and-task-submit-messages.

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

Docs Build status updates of commit b5539c0:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

msteams-platform/concepts/task-modules/task-modules-bots.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Deprecation FileStreamer-like object

Hi,
I would like stream attachments through grape. By reading the doc, I can do this :
class AttachmentStream
  attr_reader :response
  def initialize(response)
    @response = response
  end

  def each
    yield response.read_body
  end
end

source =<EMAIL_ADDRESS>Net::HTTP.start(source.host, source.port, use_ssl: true) do |http|
  req = Net::HTTP::Get.new source
   http.request(req) do |res|
     stream AttachmentStream.new(res)
   end
end

Unfortunately, there is a warning that says :
'[DEPRECATION] Argument as FileStreamer-like object is deprecated. Use path to file instead.'

Is is still relevant ?
Thanks

Are you reading 1.4.0 docs? https://github.com/ruby-grape/grape/pull/1520 has not been released yet.

I was reading on master branch, sorry :(


9289 formalize reflexive

Note that there is a change in here to ParserAllActivityModifier.java. This is a small, pretty insignificant change I made when review a recent change by Levi. I forgot to push this to master , and thus it is included here.


配置文件里域名的解析问题

你正在使用哪个版本的 V2Ray？
V2Ray 5.1.0
你的使用场景是什么？
WebSocket + TLS + CDN(CF)
你看到的异常现象是什么？
配置文件中的节点地址为域名时，域名解析直接走系统的DNS，而不经过配置文件中的dns配置。
比当我自选CDN-IP时，有如下两种方法：

在vmess的outbound中直接指定自选的ip地址，在wsSettings中添加Host header：握手失败。
在dns中添加hosts记录，vmess的outbound使用域名：解析到的域名不是dns hosts中配置的ip。

你期待看到的正常表现是怎样的？
当配置文件中的address是域名时应走dns配置解析，而不是系统的dns。
注：目前的解决方法是在路由器里定义dns解析，或者改系统的hosts文件，感觉太麻烦了。
请附上你的配置

服务端配置：
{
  "inbounds": [{
    "port": *,
    "listen": "*",
    "protocol": "vmess",
    "settings": {
      "clients":[
              {
                      "id": "*",
                      "alterId": *
              }
      ]
    },
    "streamSettings": {
            "network": "ws",
            "wsSettings": {
                    "path": "/*"
            }
    }

  }],
  "outbounds": [{
    "protocol": "freedom",
    "settings": {}
  }]

}

客户端配置：
{
  "dns": {
	"hosts":{
		"my.domain.name": "*"
	}
  },
  "inbounds": [
    {
      "port": *,
      "listen": "*",
      "protocol": "socks",
      "settings": {
        "auth": "noauth",
        "udp": true
      }
    }
  ],
  "outbounds": [
    {
      "protocol": "vmess",
      "settings": {
        "vnext": [
          {
            "address": "selected_ip",
            "port": 0*
            "users": [
              {
                "id": "*",
                "alterId": *
              }
            ]
          }
        ]
      },
      "streamSettings": {
        "network": "ws",
        "security": "tls",
        "wsSettings": {
		  "headers": {
			"Host": "my.domain.name"
		  },
          "path": "/*"
        }
      }
    }
  ]
}

请附上出错时软件输出的错误日志

服务器端错误日志：
// 在这里附上服务器端日志
无日志

客户端错误日志：
// 在这里附上客户端日志
无日志

请附上访问日志

// 在这里附上服务器端日志
无日志

其它相关的配置文件（如 Nginx）和相关日志
如果 V2Ray 无法启动，请附上 --test 命令的输出
如果 V2Ray 服务运行异常，请附上 journal 日志

Why change address to an IP does not work in your case
You forget to set streamSettings.tlsSettings.serverName to your domain name. This field is required so the TLS client hello initiated by V2Ray contains an SNI , or you will get error code: 1003 from cloudflare. (Because they do not allow direct IP access without an SNI.)
So a correct streamSettings configuration with custom IP looks like this
      "streamSettings": {
        "network": "ws",
        "security": "tls",
        "tlsSettings": {
          "serverName": "example.com"
        },
        "wsSettings": {
          "path": "/",
          "headers": {
            "Host": "example.com"
          }
        }
      }

How to make dns.hosts works for outbound address.
You can route all DNS queries to V2Ray, there are many ways to do that.
Method 1
Create a DNS inbound and configure your operating system to forward all DNS query to that inbound.
example:

config.json:

{
  "dns": {
    "tag": "builtin_dns",
    "hosts": {
      "example.com": "<IP_ADDRESS>"
    },
    "servers": [
      "<IP_ADDRESS>"
    ]
  },
  "inbounds": [
    {
      "tag": "socks_in",
      "listen": "<IP_ADDRESS>",
      "port": 1080,
      "protocol": "socks",
      "settings": {
        "udp": true
      },
      "sniffing": {
        "enabled": true,
        "destOverride": [
          "http",
          "tls"
        ]
      }
    },
    {
      "tag": "dns_in",
      "protocol": "dokodemo-door",
      "listen": "<IP_ADDRESS>",
      "port": 53,
      "settings": {
        "address": "<IP_ADDRESS>",
        "port": 53,
        "network": "udp"
      }
    }
  ],
  "outbounds": [
    {
      "tag": "proxy",
      "protocol": "vmess",
      "settings": {
        "vnext": [
          {
            "address": "example.com",
            "port": 443,
            "users": [
              {
                "alterId": 0,
                "id": "11111111-1111-1111-1111-111111111111"
              }
            ]
          }
        ]
      },
      "streamSettings": {
        "network": "ws",
        "security": "tls",
        "tlsSettings": {
          "serverName": "example.com"
        },
        "wsSettings": {
          "path": "/",
          "headers": {
            "Host": "example.com"
          }
        }
      }
    },
    {
      "tag": "dns",
      "protocol": "dns",
      "proxySettings": {
        "tag": "proxy"
      }
    }
  ],
  "routing": {
    "rules": [
      {
        "outboundTag": "proxy",
        "inboundTag": [
          "socks_in",
          "builtin_dns"
        ],
        "type": "field"
      },
      {
        "outboundTag": "dns",
        "inboundTag": [
          "dns"
        ],
        "type": "field"
      }
    ]
  }
}

Then change default DNS resolver of your operating system.
Linux:

/etc/resolv.conf:

nameserver <IP_ADDRESS>

Windows:
see this article
Method 2
Use transparent proxy.
 This compromises your privacy.
Add a client routing rule side that allow direct connection to domestic website. If you connect to them using your proxy server, they can and probably log IP of proxy server and submit this data to the firewall.
Add a server routing rule side that blocks connection to domestic website for the same reason above.
Add a client routing rule the allow direct connection to private IPs and domains, or something cloud probably break.
Add a server routing rule side that blocks connection private IPs and domains to reduce attack surface of your server.
Try transparent proxy, which cloud prevent direct connection to internet without proxy, prevent DNS leakage, and easier to share connection with other devices that does not run V2Ray. (This requires Linux)
Read documentations articles on https://guide.v2fly.org, they may be helpful to you.


feat(GroupTheory/Perm): composition of permutations is 1 iff they are inverses

Thanks! Please fix names (see suggestions above), wait for the CI, then merge.
bors d+

bors r+


Decide the entry eliminator of list at its initialization.

Done at https://github.com/l-smash/l-smash/commit/4b46719bfb7ef7bfad4f3b2ffd2cef8ae6e1128a .


[ BDH-69 ] feat: Add userOp unmarshaler for Solver communication, address previous PR feedback

fix: ProcessingStatus type restoration
fix: Address previous PR feedback
feat: Add userOp custom unmarshalling

@EliasiOfir, I addressed your feedback here. I am merging it now because I need the changes for the Solver communication, but feel free to comment.


#44 Namespace duplication when using file scoped namespaces

fix issue: https://github.com/pautx24/VsNamespaceFixer/issues/44

Hi! First of all: thanks a lot for the effort!! <3
I just tested it and it went not quite well: is still duplicating the namespace, leaving the scoped one as it is.
To reproduce it, just added a new class in the root of resources/Console.Test with scoped namespace. Altered the namespace to be wrong, and then try to "adjust it". It adds a namespace with the {} leaving the old scoped namespace as it was.
Can you review it, please?
Cheers!


Fixes #5162: Copy obeys user's lang over URL

What's this PR do?
Addresses inconsistent behavior where a logged-in user's profile language could override the language indicated by the URL prefix.
Where should the reviewer start?
This is just a config update to the dosomething_global feature, specifically for the language detection settings (admin/config/regional/language/configure).
How should this be manually tested?

Log in.
Load a campaign in multiple languages, each in its own tab.
You should see the appropriate language for all copy (given that the translation exists).
Change your user's preferred language.
Reload the various campaign tabs.
You should still see the appropriate language in each tab, based on the language indicated by the URL.

Any background context you want to provide?
N/A
What are the relevant tickets?
#5162
Screenshots (if appropriate)
N/A
Questions:

Does the knowledge base need an update? No

:+1:


Adding https://testexecution.blob.core.windows.net/testplatformdeploy…

…ment/3571446/TestPlatform.Deployment.zip in DTA make.json

Hi @RanjanarMS, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!

It looks like you're a Microsoft contributor (Ranjana Rathinam). If you're full-time, we DON'T require a Contribution License Agreement. If you are a vendor, please DO sign the electronic Contribution License Agreement. It will take 2 minutes and there's no faxing! https://cla.microsoft.com.

TTYL, MSBOT;


Upgraded to 1.12.4 and now the pod restarts

I upped the logging to INFO and it looks like it restarts during a federation loop
2020-04-28 12:33:26,445 - synapse.http.federation.matrix_federation_agent - 242 - INFO - federation_transaction_transmission_loop-531 - Connecting to skalarprodukt.de:8448
2020-04-28 12:33:26,447 - synapse.http.federation.matrix_federation_agent - 242 - INFO - federation_transaction_transmission_loop-697 - Connecting to matrix.allmende.io:443
2020-04-28 12:33:26,449 - synapse.http.federation.matrix_federation_agent - 242 - INFO - federation_transaction_transmission_loop-1011 - Connecting to chat.phuks.co:8448
2020-04-28 12:33:26,455 - synapse.http.federation.matrix_federation_agent - 242 - INFO - federation_transaction_transmission_loop-504 - Connecting to 10friends.info:8448
2020-04-28 12:33:26,457 - synapse.http.federation.matrix_federation_agent - 242 - INFO - federation_transaction_transmission_loop-572 - Connecting to tozein.com:8448
2020-04-28 12:33:26,459 - synapse.http.federation.matrix_federation_agent - 242 - INFO - federation_transaction_transmission_loop-501 - Connecting to synapse.asra.gr:443
2020-04-28 12:33:26,464 - synapse.http.federation.matrix_federation_agent - 242 - INFO - federation_transaction_transmission_loop-901 - Connecting to matrix.oldrevelminds.com:8448
2020-04-28 12:33:26,467 - synapse.http.federation.matrix_federation_agent - 242 - INFO - federation_transaction_transmission_loop-664 - Connecting to chat.138.io:8448
2020-04-28 12:33:26,469 - synapse.http.federation.matrix_federation_agent - 242 - INFO - federation_transaction_transmission_loop-297 - Connecting to matrix.rptc.bid:8448
2020-04-28 12:33:26,471 - synapse.http.federation.matrix_federation_agent - 242 - INFO - federation_transaction_transmission_loop-412 - Connecting to matrix.decent.fund:8448
2020-04-28 12:33:26,473 - synapse.http.federation.matrix_federation_agent - 242 - INFO - federation_transaction_transmission_loop-995 - Connecting to matrix.p6ril.fr:8448
2020-04-28 12:33:26,476 - synapse.http.federation.matrix_federation_agent - 242 - INFO - federation_transaction_transmission_loop-852 - Connecting to rduce.org:8448
2020-04-28 12:33:26,478 - synapse.http.federation.matrix_federation_agent - 242 - INFO - federation_transaction_transmission_loop-354 - Connecting to matrix.grin.hu:8448
2020-04-28 12:33:26,481 - synapse.http.federation.matrix_federation_agent - 242 - INFO - federation_transaction_transmission_loop-382 - Connecting to matrix.trustserv.de:8448
2020-04-28 12:33:26,491 - synapse.http.federation.matrix_federation_agent - 242 - INFO - federation_transaction_transmission_loop-253 - Connecting to jhammons.io:8449
2020-04-28 12:33:26,494 - synapse.http.federation.matrix_federation_agent - 242 - INFO - federation_transaction_transmission_loop-806 - Connecting to hackerfraternity.org:8448
2020-04-28 12:33:26,496 - synapse.http.federation.matrix_federation_agent - 242 - INFO - federation_transaction_transmission_loop-370 - Connecting to chat.eritonito.com:8448
2020-04-28 12:33:26,498 - synapse.http.federation.matrix_federation_agent - 242 - INFO - federation_transaction_transmission_loop-731 - Connecting to matrix.antonionapolitano.eu:8448
2020-04-28 12:33:26,505 - synapse.http.federation.matrix_federation_agent - 242 - INFO - federation_transaction_transmission_loop-373 - Connecting to tenpthree.net:8448
2020-04-28 12:33:26,508 - synapse.http.federation.matrix_federation_agent - 242 - INFO - federation_transaction_transmission_loop-983 - Connecting to matrix.1312.media:8448
2020-04-28 12:33:26,510 - synapse.http.federation.matrix_federation_agent - 242 - INFO - federation_transaction_transmission_loop-900 - Connecting to backstop.modular.im:443
2020-04-28 12:33:26,512 - synapse.http.federation.matrix_federation_agent - 242 - INFO - federation_transaction_transmission_loop-792 - Connecting to matrix.ffslfl.net:443
2020-04-28 12:33:26,518 - synapse.http.federation.matrix_federation_agent - 242 - INFO - federation_transaction_transmission_loop-535 - Connecting to nets.sh:8448
2020-04-28 12:33:26,520 - synapse.http.federation.matrix_federation_agent - 242 - INFO - federation_transaction_transmission_loop-317 - Connecting to heavner.dev:8448
2020-04-28 12:33:26,522 - synapse.http.federation.matrix_federation_agent - 242 - INFO - federation_transaction_transmission_loop-368 - Connecting to resplendent.company:8448
2020-04-28 12:33:26,524 - synapse.http.federation.matrix_federation_agent - 242 - INFO - federation_transaction_transmission_loop-518 - Connecting to matrix.jon02.ch:8448
2020-04-28 12:33:26,525 - twisted - 192 - INFO -  - Main loop terminated.

Anyone else had problems with 1.12.4 before I look into it further and submit an upstream issue?

Another loop's log
2020-04-28 12:45:10,451 - synapse.http.federation.matrix_federation_agent - 242 - INFO - federation_transaction_transmission_loop-478 - Connecting to chat.python.nz:8448
2020-04-28 12:45:10,457 - synapse.http.federation.matrix_federation_agent - 242 - INFO - federation_transaction_transmission_loop-895 - Connecting to matrix.familie-vogdt.de:443
2020-04-28 12:45:10,459 - synapse.http.federation.matrix_federation_agent - 242 - INFO - federation_transaction_transmission_loop-893 - Connecting to rrra.bid:8448
2020-04-28 12:45:10,460 - synapse.http.federation.matrix_federation_agent - 242 - INFO - federation_transaction_transmission_loop-761 - Connecting to matrix.nilux.be:8448
2020-04-28 12:45:10,492 - synapse.http.matrixfederationclient - 434 - INFO - federation_transaction_transmission_loop-568 - Failed to send request: <Message id=11566 rCode=2 maxSize=0 flags=answer,recDes,recAv queries=[Query(b'_matrix._tcp.synapse.pantarhei.duckdns.org', 33, 1)]>
2020-04-28 12:45:10,493 - synapse.http.matrixfederationclient - 491 - WARNING - federation_transaction_transmission_loop-568 - {PUT-O-545} [synapse.pantarhei.duckdns.org] Request failed: PUT matrix://synapse.pantarhei.duckdns.org/_matrix/federation/v1/send/1588077218366: DNSServerError(<Message id=11566 rCode=2 maxSize=0 flags=answer,recDes,recAv queries=[Query(b'_matrix._tcp.synapse.pantarhei.duckdns.org', 33, 1)]>)
2020-04-28 12:45:10,495 - synapse.http.matrixfederationclient - 434 - INFO - federation_transaction_transmission_loop-479 - Failed to send request: <Message id=39429 rCode=2 maxSize=0 flags=answer,recDes,recAv queries=[Query(b'_matrix._tcp.matrix.catila.duckdns.org', 33, 1)]>
2020-04-28 12:45:10,510 - synapse.http.matrixfederationclient - 491 - WARNING - federation_transaction_transmission_loop-479 - {PUT-O-490} [matrix.catila.duckdns.org] Request failed: PUT matrix://matrix.catila.duckdns.org/_matrix/federation/v1/send/1588077218311: DNSServerError(<Message id=39429 rCode=2 maxSize=0 flags=answer,recDes,recAv queries=[Query(b'_matrix._tcp.matrix.catila.duckdns.org', 33, 1)]>)
2020-04-28 12:45:10,510 - twisted - 192 - INFO -  - Main loop terminated.

Humph doesnt look like an issue with that version, rolled back to a previous version

Hmm, not sure what's going on but it's probably not the federation spam. That happens whenever you're in a server with users from a homeserver that no longer exists (someone shut down their homeserver without leaving all public rooms first).
Can you kubectl describe the pod and see why it's restarting? Did the process crash or did the health check fail?

Does look like the liveness probe failed!
 Let's try this:

kubectl edit the deployment and remove the liveness/readiness probes for a moment
kubectl port-forward matrix-synapse-blahblahblah 8008
Try to manually hit localhost:8008 and localhost:8008/_matrix/static/

If you can hit the endpoints manually, leave the probes disabled and see if you can use the homeserver as normal. We can keep looking into why the probes are failing but that should give you a temporary fix.
If you can't reach the endpoints or the homeserver still doesn't work with the probes disabled, then we can take a closer look at your logs and see if it's an issue with the chart or with Synapse.
Thanks!

thanks @dacruz21 ! I need to up the docker image again so I'll just comment it out in the deployment file for now (still using my edited fork at the moment)

So currently I can hit it. Will report back behaviours from tomorrow !

So it seems the container hasnt restarted itself, and I seem to be able to chat to people fine for a long period of time....

Hey @danjenkins, I've bumped the default timeout for the Synapse health probes. Can you update to 2.1.0 and let me know if you're still getting this issue? Feel free to raise/lower them further in synapse.probes, 5 seconds is probably more generous than you want to be, but if you're on some old hardware, then maybe it's not generous enough :)

@dacruz21 Circling back on the timeout issue, 5 seconds seems to not be generous enough. It's much better but I am averaging 5 restarts in 24 hours due to healthcheck failure.


Incremental model logic fails when initial loaded table is empty

Is this a new bug in dbt-core?

[X] I believe this is a new bug in dbt-core
[X] I have searched the existing issues, and I could not find an existing issue for this bug

Current Behavior
Currently, the is_incremental() macro checks different conditions in a model before activating the where clause to increment the load.
There is a case where, for any given reason (the source table was empty for example), the first build of a model results in an empty table.
The macro will check correctly all the conditions :
1- The model must already exist in the database
2- The destination table already exists in the database
3- The full-refresh flag is not passed
4- The running model is configured with materialized='incremental'
and activate the where clause :
where event_time >= (select max(event_time) from {{ this }})
Unfortunatly, the where clause will not work because the returned max(event_time) will be null, consequence of the destination table in the database being empty. This causes the incremental model to be blocked by the empty table, and never incerement the table, even when the data becomes available in the source ref.
Expected Behavior
The is_inremental() macro should include an additional condition :
5- The destination table is not empty
This should correct the faulty behaviour in the where clause introduced by the empty destination table in the database.
Whenever the data becomes available (after a fix for example) the model will build correctly.
Steps To Reproduce
1- Create an incremental model
2- Make sure the first run results in an empty table in the destination
3- Fix the model and make the data available again
4- Run the incremental model
Relevant log output
No response
Environment
- OS:
- Python:
- dbt:

Which database adapter are you using with dbt?
snowflake
Additional Context
No response

If you expect this use case of an empty initial table, can't you do a:
where event_time >= (select coalesce(max(event_time),'1900-01-01') from {{ this }})

This was not an expected case on our side. We had to spend time to find out that the root cause was an empty table.
We tought something didn't work as expected with the incremental config, as in our pipeline, nothing showed that the table was empty.
The solution you proposed is exactly what we implemented to fix it.
I imagine this could happen to others. Maybe it is worth being known as a use case for incremental models.
I guess it is not exactly a bug. More like an unexpected behavior if you are not warned.
It could easily be taken care of by adding this check in the is_inremental() macro:
5- The destination table is not empty
It should act as a fix and also a highlight of this possible case.

Thanks for these insight @b-per and @BenameurZyad. I'm going to re-categorize this a feature request for further consideration:

add a check in the is_incremental() macro for an empty table.

Thanks a bunch. You guys are awsome.

In the meantime, I opened this issue to improve our documentation:

https://github.com/dbt-labs/docs.getdbt.com/issues/5321

@BenameurZyad I've updated the documentation within https://github.com/dbt-labs/docs.getdbt.com/pull/5326 so that it includes an example that will work when the incremental table is empty.
I'm going to close this issue in favor of that update to the documentation. If we get additional feedback that this is not sufficient, we can consider re-opening this.


feat: add endpoint to fetch blinded blocks

Motivation

https://github.com/ethereum/beacon-APIs/pull/241

Description
Adds endpoint to fetch blinded blocks, see getBlindedBlock
Closes https://github.com/ChainSafe/lodestar/issues/5699

:tada: This PR is included in v1.20.0 :tada:


1.17 ?

hey, haema 1.17 is pretty stable. so why not updating this one too ? :)

If i just wanted to update it would already be updated, but im adding a lot more stands and im doing that in my spare time, however, we are close to release of the 2.0 update for 1.17

If i just wanted to update it would already be updated, but im adding a lot more stands and im doing that in my spare time, however, we are close to release of the 2.0 update for 1.17

Les GOOO


Allow users to update environment variables value and scope

Describe the bug
At the moment with Lagoon, you can create new environment variables. You however can't update the value or scope (e.g. global or runtime) of the environment variable in the future. If you have the ability to create, surely this would mean you can update as well.
The impact of this bug is that you are forced to:

delete the current environment variable
create a new environment variable with the same name but with the new value/scope

This however is 2 GraphQL API requests, when 1 would be safer (no messing up the name), atomic (no chance of a build with no environment variable), easier for everyone (1 API request) and less confusing.
This also will mean that customers with heavy use (read - automated) of environment variables will end up hitting the API a lot more than necessary, which could impact scaling in the future.
Expected behaviour
If you have the ability to create environment variables, you should also be able to update them. At least the value of the variable and and scope of the variable should be updateable.
Impacted customers
At least 2 large customers in APJ are impacted by this.

Permissable scope changes would be build>runtime>global etc - but project>environment not possible


xfce: update to version 4.16

Motivation for this change
Update Xfce components to the latest version (4.16).
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 114567 at 0eb3a2e2 run on aarch64-linux 1

4 packages marked as broken and skipped:

xfce.xfce4-embed-plugin
xfce.xfce4-hardware-monitor-plugin
xfce.xfce4_embed_plugin
xfce.xfce4_hardware_monitor_plugin

4 packages failed to build:

lightdm_gtk_greeter
xfce.xfce4-datetime-plugin (xfce.xfce4_datetime_plugin)
xfce.xfce4-dockbarx-plugin (xfce.xfce4_dockbarx_plugin)
xmonad_log_applet_xfce

54 packages built:

pragha
xfce.exo
xfce.garcon
xfce.gigolo
xfce.libxfce4ui (xfce.libxfce4ui_gtk3)
xfce.libxfce4util
xfce.mousepad
xfce.orage
xfce.parole
xfce.ristretto
xfce.terminal (xfce.xfce4-terminal ,xfce.xfce4terminal)
xfce.thunar (xfce.thunar-bare ,xfce.thunar-build ,xfce.thunarx-2-dev)
xfce.thunar-archive-plugin
xfce.thunar-dropbox-plugin
xfce.thunar-volman (xfce.thunar_volman)
xfce.tumbler
xfce.xfburn
xfce.xfce4-appfinder (xfce.xfce4_appfinder)
xfce.xfce4-battery-plugin (xfce.xfce4_battery_plugin)
xfce.xfce4-clipman-plugin (xfce.xfce4_clipman_plugin)
xfce.xfce4-cpufreq-plugin (xfce.xfce4_cpufreq_plugin)
xfce.xfce4-cpugraph-plugin (xfce.xfce4_cpugraph_plugin)
xfce.xfce4-dev-tools (xfce.xfce4_dev_tools)
xfce.xfce4-dict
xfce.xfce4-eyes-plugin (xfce.xfce4_eyes_plugin)
xfce.xfce4-fsguard-plugin (xfce.xfce4_fsguard_plugin)
xfce.xfce4-genmon-plugin (xfce.xfce4_genmon_plugin)
xfce.xfce4-i3-workspaces-plugin
xfce.xfce4-mailwatch-plugin (xfce.xfce4_mailwatch_plugin)
xfce.xfce4-mpc-plugin (xfce.xfce4_mpc_plugin)
xfce.xfce4-namebar-plugin (xfce.xfce4_namebar_plugin)
xfce.xfce4-netload-plugin (xfce.xfce4_netload_plugin)
xfce.xfce4-notes-plugin (xfce.xfce4_notes_plugin)
xfce.xfce4notifyd (xfce.xfce4-notifyd)
xfce.xfce4panel (xfce.xfce4-panel ,xfce.xfce4panel_gtk3)
xfce.xfce4-power-manager (xfce.xfce4_power_manager ,xfce.xfce4_power_manager_gtk3)
xfce.xfce4-pulseaudio-plugin (xfce.xfce4_pulseaudio_plugin)
xfce.xfce4-screenshooter
xfce.xfce4-sensors-plugin (xfce.xfce4_sensors_plugin)
xfce.xfce4session (xfce.xfce4-session)
xfce.xfce4settings (xfce.xfce4-settings)
xfce.xfce4-systemload-plugin (xfce.xfce4_systemload_plugin)
xfce.xfce4taskmanager (xfce.xfce4-taskmanager)
xfce.xfce4-timer-plugin (xfce.xfce4_timer_plugin)
xfce.xfce4-verve-plugin (xfce.xfce4_verve_plugin)
xfce.xfce4volumed_pulse (xfce.xfce4-volumed-pulse)
xfce.xfce4-weather-plugin (xfce.xfce4_weather_plugin)
xfce.xfce4-whiskermenu-plugin (xfce.xfce4_whiskermenu_plugin)
xfce.xfce4-windowck-plugin (xfce.xfce4_windowck_plugin)
xfce.xfce4-xkb-plugin (xfce.xfce4_xkb_plugin)
xfce.xfconf
xfce.xfdashboard
xfce.xfdesktop
xfce.xfwm4

13 suggestions:

warning: maintainers-missing
Package does not have a maintainer. Consider adding yourself?
Near pkgs/desktops/xfce/panel-plugins/xfce4-cpugraph-plugin/default.nix:59:5:
   |
59 |     maintainers = [ ];
   |     ^

warning: maintainers-missing
Package does not have a maintainer. Consider adding yourself?
Near pkgs/desktops/xfce/panel-plugins/xfce4-mailwatch-plugin/default.nix:41:5:
   |
41 |     maintainers = [ ];
   |     ^

warning: maintainers-missing
Package does not have a maintainer. Consider adding yourself?
Near pkgs/desktops/xfce/panel-plugins/xfce4-notes-plugin/default.nix:45:5:
   |
45 |     maintainers = [ ];
   |     ^

warning: missing-patch-comment
Please add a comment on the line above, explaining the purpose of this patch.
Near pkgs/desktops/xfce/applications/xfce4-dict/default.nix:10:15:
   |
10 |   patches = [ ./configure-gio.patch ];
   |               ^

warning: missing-patch-comment
Please add a comment on the line above, explaining the purpose of this patch.
Near pkgs/desktops/xfce/core/thunar/default.nix:48:5:
   |
48 |     ./thunarx_plugins_directory.patch
   |     ^

warning: missing-patch-comment
Please add a comment on the line above, explaining the purpose of this patch.
Near pkgs/desktops/xfce/core/xfce4-panel/default.nix:45:15:
   |
45 |   patches = [ ./xfce4-panel-datadir.patch ];
   |               ^

warning: unclear-gpl
gpl2 is a deprecated license, check if project uses gpl2Plus or gpl2Only and change meta.license accordingly.
Near pkgs/desktops/xfce/panel-plugins/xfce4-mailwatch-plugin/default.nix:39:5:
   |
39 |     license = licenses.gpl2;
   |     ^

warning: unclear-gpl
gpl2 is a deprecated license, check if project uses gpl2Plus or gpl2Only and change meta.license accordingly.
Near pkgs/desktops/xfce/panel-plugins/xfce4-sensors-plugin/default.nix:50:5:
   |
50 |     license = licenses.gpl2;
   |     ^

warning: unused-argument
Unused argument: automakeAddFlags.
Near pkgs/desktops/xfce/applications/ristretto/default.nix:1:21:
  |
1 | { mkXfceDerivation, automakeAddFlags, gtk3, glib, libexif
  |                     ^

warning: unused-argument
Unused argument: automakeAddFlags.
Near pkgs/desktops/xfce/core/xfce4-settings/default.nix:1:21:
  |
1 | { mkXfceDerivation, automakeAddFlags, exo, garcon, gtk3, glib
  |                     ^

warning: unused-argument
Unused argument: lib.
Near pkgs/desktops/xfce/applications/xfce4-taskmanager/default.nix:1:3:
  |
1 | { lib, mkXfceDerivation, exo, gtk3, libwnck3, libXmu }:
  |   ^

warning: unused-argument
Unused argument: libjpeg.
Near pkgs/desktops/xfce/core/tumbler/default.nix:8:3:
  |
8 | , libjpeg
  |   ^

warning: unused-argument
Unused argument: xorg.
Near pkgs/desktops/xfce/core/xfce4-session/default.nix:1:99:
  |
1 | { mkXfceDerivation, polkit, exo, libxfce4util, libxfce4ui, xfconf, iceauth, gtk3, glib, libwnck3, xorg, xfce4-session }:
  |                                                                                ^

This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.
Result of nixpkgs-review pr 114567 run on x86_64-linux 1

5 packages marked as broken and skipped:

xfce.xfce4-embed-plugin
xfce.xfce4-hardware-monitor-plugin
xfce.xfce4-vala-panel-appmenu-plugin
xfce.xfce4_embed_plugin
xfce.xfce4_hardware_monitor_plugin

1 package failed to build and are new build failure:

xmonad_log_applet_xfce: plain log  |  pretty log

57 packages built:

lightdm_gtk_greeter
pragha
xfce.exo
xfce.garcon
xfce.gigolo
xfce.libxfce4ui (xfce.libxfce4ui_gtk3)
xfce.libxfce4util
xfce.mousepad
xfce.orage
xfce.parole
xfce.ristretto
xfce.terminal (xfce.xfce4-terminal ,xfce.xfce4terminal)
xfce.thunar (xfce.thunar-bare ,xfce.thunar-build ,xfce.thunarx-2-dev)
xfce.thunar-archive-plugin
xfce.thunar-dropbox-plugin
xfce.thunar-volman (xfce.thunar_volman)
xfce.tumbler
xfce.xfburn
xfce.xfce4-appfinder (xfce.xfce4_appfinder)
xfce.xfce4-battery-plugin (xfce.xfce4_battery_plugin)
xfce.xfce4-clipman-plugin (xfce.xfce4_clipman_plugin)
xfce.xfce4-cpufreq-plugin (xfce.xfce4_cpufreq_plugin)
xfce.xfce4-cpugraph-plugin (xfce.xfce4_cpugraph_plugin)
xfce.xfce4-datetime-plugin (xfce.xfce4_datetime_plugin)
xfce.xfce4-dev-tools (xfce.xfce4_dev_tools)
xfce.xfce4-dict
xfce.xfce4-dockbarx-plugin (xfce.xfce4_dockbarx_plugin)
xfce.xfce4-eyes-plugin (xfce.xfce4_eyes_plugin)
xfce.xfce4-fsguard-plugin (xfce.xfce4_fsguard_plugin)
xfce.xfce4-genmon-plugin (xfce.xfce4_genmon_plugin)
xfce.xfce4-i3-workspaces-plugin
xfce.xfce4-mailwatch-plugin (xfce.xfce4_mailwatch_plugin)
xfce.xfce4-mpc-plugin (xfce.xfce4_mpc_plugin)
xfce.xfce4-namebar-plugin (xfce.xfce4_namebar_plugin)
xfce.xfce4-netload-plugin (xfce.xfce4_netload_plugin)
xfce.xfce4-notes-plugin (xfce.xfce4_notes_plugin)
xfce.xfce4notifyd (xfce.xfce4-notifyd)
xfce.xfce4panel (xfce.xfce4-panel ,xfce.xfce4panel_gtk3)
xfce.xfce4-power-manager (xfce.xfce4_power_manager ,xfce.xfce4_power_manager_gtk3)
xfce.xfce4-pulseaudio-plugin (xfce.xfce4_pulseaudio_plugin)
xfce.xfce4-screenshooter
xfce.xfce4-sensors-plugin (xfce.xfce4_sensors_plugin)
xfce.xfce4session (xfce.xfce4-session)
xfce.xfce4settings (xfce.xfce4-settings)
xfce.xfce4-systemload-plugin (xfce.xfce4_systemload_plugin)
xfce.xfce4taskmanager (xfce.xfce4-taskmanager)
xfce.xfce4-timer-plugin (xfce.xfce4_timer_plugin)
xfce.xfce4-verve-plugin (xfce.xfce4_verve_plugin)
xfce.xfce4volumed_pulse (xfce.xfce4-volumed-pulse)
xfce.xfce4-weather-plugin (xfce.xfce4_weather_plugin)
xfce.xfce4-whiskermenu-plugin (xfce.xfce4_whiskermenu_plugin)
xfce.xfce4-windowck-plugin (xfce.xfce4_windowck_plugin)
xfce.xfce4-xkb-plugin (xfce.xfce4_xkb_plugin)
xfce.xfconf
xfce.xfdashboard
xfce.xfdesktop
xfce.xfwm4

The following issues got detected with the above build packages.
Please fix at least the ones listed with your changed packages:

lightdm_gtk_greeter:

warning: unclear-gpl
gpl3 is a deprecated license, check if project uses gpl3Plus or gpl3Only and change meta.license accordingly.
Near pkgs/applications/display-managers/lightdm/gtk-greeter.nix:76:5:
   |
76 |     license = licenses.gpl3;
   |     ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/unclear-gpl.md
warning: maintainers-missing
Package does not have a maintainer. Consider adding yourself?
Near pkgs/applications/display-managers/lightdm/gtk-greeter.nix:77:5:
   |
77 |     maintainers = with maintainers; [ ];
   |     ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/maintainers-missing.md

xfce.exo:

warning: unclear-gpl
gpl2 is a deprecated license, check if project uses gpl2Plus or gpl2Only and change meta.license accordingly.
Near lib/attrsets.nix:362:7:
    |
362 |       value = f name (catAttrs name sets);
    |       ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/unclear-gpl.md
warning: maintainers-missing
Package does not have a maintainer. Consider adding yourself?
Near lib/attrsets.nix:362:7:
    |
362 |       value = f name (catAttrs name sets);
    |       ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/maintainers-missing.md

xfce.garcon:

warning: unclear-gpl
gpl2 is a deprecated license, check if project uses gpl2Plus or gpl2Only and change meta.license accordingly.
Near lib/attrsets.nix:362:7:
    |
362 |       value = f name (catAttrs name sets);
    |       ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/unclear-gpl.md
warning: maintainers-missing
Package does not have a maintainer. Consider adding yourself?
Near lib/attrsets.nix:362:7:
    |
362 |       value = f name (catAttrs name sets);
    |       ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/maintainers-missing.md

xfce.gigolo:

warning: unclear-gpl
gpl2 is a deprecated license, check if project uses gpl2Plus or gpl2Only and change meta.license accordingly.
Near lib/attrsets.nix:362:7:
    |
362 |       value = f name (catAttrs name sets);
    |       ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/unclear-gpl.md
warning: maintainers-missing
Package does not have a maintainer. Consider adding yourself?
Near lib/attrsets.nix:362:7:
    |
362 |       value = f name (catAttrs name sets);
    |       ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/maintainers-missing.md

xfce.libxfce4ui:

warning: maintainers-missing
Package does not have a maintainer. Consider adding yourself?
Near lib/attrsets.nix:362:7:
    |
362 |       value = f name (catAttrs name sets);
    |       ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/maintainers-missing.md

xfce.libxfce4util:

warning: maintainers-missing
Package does not have a maintainer. Consider adding yourself?
Near lib/attrsets.nix:362:7:
    |
362 |       value = f name (catAttrs name sets);
    |       ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/maintainers-missing.md

xfce.mousepad:

warning: unclear-gpl
gpl2 is a deprecated license, check if project uses gpl2Plus or gpl2Only and change meta.license accordingly.
Near lib/attrsets.nix:362:7:
    |
362 |       value = f name (catAttrs name sets);
    |       ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/unclear-gpl.md
warning: maintainers-missing
Package does not have a maintainer. Consider adding yourself?
Near lib/attrsets.nix:362:7:
    |
362 |       value = f name (catAttrs name sets);
    |       ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/maintainers-missing.md

xfce.orage:

warning: maintainers-missing
Package does not have a maintainer. Consider adding yourself?
Near pkgs/desktops/xfce/applications/orage/default.nix:47:3:
   |
47 |   meta = with lib; {
   |   ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/maintainers-missing.md

xfce.parole:

warning: unclear-gpl
gpl2 is a deprecated license, check if project uses gpl2Plus or gpl2Only and change meta.license accordingly.
Near lib/attrsets.nix:362:7:
    |
362 |       value = f name (catAttrs name sets);
    |       ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/unclear-gpl.md
warning: maintainers-missing
Package does not have a maintainer. Consider adding yourself?
Near lib/attrsets.nix:362:7:
    |
362 |       value = f name (catAttrs name sets);
    |       ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/maintainers-missing.md

xfce.ristretto:

warning: unclear-gpl
gpl2 is a deprecated license, check if project uses gpl2Plus or gpl2Only and change meta.license accordingly.
Near lib/attrsets.nix:362:7:
    |
362 |       value = f name (catAttrs name sets);
    |       ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/unclear-gpl.md
warning: maintainers-missing
Package does not have a maintainer. Consider adding yourself?
Near lib/attrsets.nix:362:7:
    |
362 |       value = f name (catAttrs name sets);
    |       ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/maintainers-missing.md
warning: unused-argument
Unused argument: automakeAddFlags.
Near pkgs/desktops/xfce/applications/ristretto/default.nix:1:21:
  |
1 | { mkXfceDerivation, automakeAddFlags, gtk3, glib, libexif
  |                     ^

xfce.terminal:

warning: unclear-gpl
gpl2 is a deprecated license, check if project uses gpl2Plus or gpl2Only and change meta.license accordingly.
Near lib/attrsets.nix:362:7:
    |
362 |       value = f name (catAttrs name sets);
    |       ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/unclear-gpl.md
warning: maintainers-missing
Package does not have a maintainer. Consider adding yourself?
Near lib/attrsets.nix:362:7:
    |
362 |       value = f name (catAttrs name sets);
    |       ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/maintainers-missing.md

xfce.thunar-archive-plugin:

warning: unclear-gpl
gpl2 is a deprecated license, check if project uses gpl2Plus or gpl2Only and change meta.license accordingly.
Near lib/attrsets.nix:362:7:
    |
362 |       value = f name (catAttrs name sets);
    |       ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/unclear-gpl.md
warning: maintainers-missing
Package does not have a maintainer. Consider adding yourself?
Near lib/attrsets.nix:362:7:
    |
362 |       value = f name (catAttrs name sets);
    |       ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/maintainers-missing.md

xfce.thunar-dropbox-plugin:

warning: unclear-gpl
gpl3 is a deprecated license, check if project uses gpl3Plus or gpl3Only and change meta.license accordingly.
Near pkgs/desktops/xfce/thunar-plugins/dropbox/default.nix:42:5:
   |
42 |     license = licenses.gpl3;
   |     ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/unclear-gpl.md
warning: maintainers-missing
Package does not have a maintainer. Consider adding yourself?
Near pkgs/desktops/xfce/thunar-plugins/dropbox/default.nix:39:3:
   |
39 |   meta = with lib; {
   |   ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/maintainers-missing.md

xfce.thunar:

warning: unclear-gpl
gpl2 is a deprecated license, check if project uses gpl2Plus or gpl2Only and change meta.license accordingly.
Near lib/attrsets.nix:362:7:
    |
362 |       value = f name (catAttrs name sets);
    |       ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/unclear-gpl.md
warning: maintainers-missing
Package does not have a maintainer. Consider adding yourself?
Near lib/attrsets.nix:362:7:
    |
362 |       value = f name (catAttrs name sets);
    |       ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/maintainers-missing.md
warning: missing-patch-comment
Please add a comment on the line above, explaining the purpose of this patch.
Near pkgs/desktops/xfce/core/thunar/default.nix:48:5:
   |
48 |     ./thunarx_plugins_directory.patch
   |     ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/missing-patch-comment.md

xfce.thunar-volman:

warning: unclear-gpl
gpl2 is a deprecated license, check if project uses gpl2Plus or gpl2Only and change meta.license accordingly.
Near lib/attrsets.nix:362:7:
    |
362 |       value = f name (catAttrs name sets);
    |       ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/unclear-gpl.md
warning: maintainers-missing
Package does not have a maintainer. Consider adding yourself?
Near lib/attrsets.nix:362:7:
    |
362 |       value = f name (catAttrs name sets);
    |       ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/maintainers-missing.md

xfce.tumbler:

warning: unclear-gpl
gpl2 is a deprecated license, check if project uses gpl2Plus or gpl2Only and change meta.license accordingly.
Near lib/attrsets.nix:362:7:
    |
362 |       value = f name (catAttrs name sets);
    |       ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/unclear-gpl.md
warning: maintainers-missing
Package does not have a maintainer. Consider adding yourself?
Near lib/attrsets.nix:362:7:
    |
362 |       value = f name (catAttrs name sets);
    |       ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/maintainers-missing.md
warning: unused-argument
Unused argument: libjpeg.
Near pkgs/desktops/xfce/core/tumbler/default.nix:8:3:
  |
8 | , libjpeg
  |   ^

xfce.xfburn:

warning: unclear-gpl
gpl2 is a deprecated license, check if project uses gpl2Plus or gpl2Only and change meta.license accordingly.
Near pkgs/desktops/xfce/mkXfceDerivation.nix:51:7:
   |
51 |       license = licenses.gpl2; # some libraries are under LGPLv2+
   |       ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/unclear-gpl.md
warning: maintainers-missing
Package does not have a maintainer. Consider adding yourself?
Near lib/attrsets.nix:362:7:
    |
362 |       value = f name (catAttrs name sets);
    |       ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/maintainers-missing.md

xfce.xfce4-appfinder:

warning: unclear-gpl
gpl2 is a deprecated license, check if project uses gpl2Plus or gpl2Only and change meta.license accordingly.
Near lib/attrsets.nix:362:7:
    |
362 |       value = f name (catAttrs name sets);
    |       ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/unclear-gpl.md
warning: maintainers-missing
Package does not have a maintainer. Consider adding yourself?
Near lib/attrsets.nix:362:7:
    |
362 |       value = f name (catAttrs name sets);
    |       ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/maintainers-missing.md

xfce.xfce4-battery-plugin:

warning: attribute-typo
A likely typo in rev-prefix argument was found, did you mean prefix?
Near lib/attrsets.nix:362:7:
    |
362 |       value = f name (catAttrs name sets);
    |       ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/attribute-typo.md
warning: unclear-gpl
gpl2 is a deprecated license, check if project uses gpl2Plus or gpl2Only and change meta.license accordingly.
Near lib/attrsets.nix:362:7:
    |
362 |       value = f name (catAttrs name sets);
    |       ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/unclear-gpl.md
warning: maintainers-missing
Package does not have a maintainer. Consider adding yourself?
Near lib/attrsets.nix:362:7:
    |
362 |       value = f name (catAttrs name sets);
    |       ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/maintainers-missing.md

xfce.xfce4-clipman-plugin:

warning: unclear-gpl
gpl2 is a deprecated license, check if project uses gpl2Plus or gpl2Only and change meta.license accordingly.
Near lib/attrsets.nix:362:7:
    |
362 |       value = f name (catAttrs name sets);
    |       ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/unclear-gpl.md
warning: maintainers-missing
Package does not have a maintainer. Consider adding yourself?
Near lib/attrsets.nix:362:7:
    |
362 |       value = f name (catAttrs name sets);
    |       ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/maintainers-missing.md

xfce.xfce4-cpufreq-plugin:

warning: unclear-gpl
gpl2 is a deprecated license, check if project uses gpl2Plus or gpl2Only and change meta.license accordingly.
Near lib/attrsets.nix:362:7:
    |
362 |       value = f name (catAttrs name sets);
    |       ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/unclear-gpl.md
warning: maintainers-missing
Package does not have a maintainer. Consider adding yourself?
Near lib/attrsets.nix:362:7:
    |
362 |       value = f name (catAttrs name sets);
    |       ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/maintainers-missing.md

xfce.xfce4-cpugraph-plugin:

warning: maintainers-missing
Package does not have a maintainer. Consider adding yourself?
Near pkgs/desktops/xfce/panel-plugins/xfce4-cpugraph-plugin/default.nix:59:5:
   |
59 |     maintainers = [ ];
   |     ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/maintainers-missing.md

xfce.xfce4-datetime-plugin:

warning: attribute-typo
A likely typo in rev-prefix argument was found, did you mean prefix?
Near lib/attrsets.nix:362:7:
    |
362 |       value = f name (catAttrs name sets);
    |       ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/attribute-typo.md
warning: unclear-gpl
gpl2 is a deprecated license, check if project uses gpl2Plus or gpl2Only and change meta.license accordingly.
Near lib/attrsets.nix:362:7:
    |
362 |       value = f name (catAttrs name sets);
    |       ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/unclear-gpl.md

xfce.xfce4-dev-tools:

warning: unclear-gpl
gpl2 is a deprecated license, check if project uses gpl2Plus or gpl2Only and change meta.license accordingly.
Near lib/attrsets.nix:362:7:
    |
362 |       value = f name (catAttrs name sets);
    |       ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/unclear-gpl.md
warning: maintainers-missing
Package does not have a maintainer. Consider adding yourself?
Near lib/attrsets.nix:362:7:
    |
362 |       value = f name (catAttrs name sets);
    |       ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/maintainers-missing.md

xfce.xfce4-dict:

warning: unclear-gpl
gpl2 is a deprecated license, check if project uses gpl2Plus or gpl2Only and change meta.license accordingly.
Near lib/attrsets.nix:362:7:
    |
362 |       value = f name (catAttrs name sets);
    |       ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/unclear-gpl.md
warning: maintainers-missing
Package does not have a maintainer. Consider adding yourself?
Near lib/attrsets.nix:362:7:
    |
362 |       value = f name (catAttrs name sets);
    |       ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/maintainers-missing.md
warning: missing-patch-comment
Please add a comment on the line above, explaining the purpose of this patch.
Near pkgs/desktops/xfce/applications/xfce4-dict/default.nix:10:15:
   |
10 |   patches = [ ./configure-gio.patch ];
   |               ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/missing-patch-comment.md

xfce.xfce4-eyes-plugin:

warning: maintainers-missing
Package does not have a maintainer. Consider adding yourself?
Near pkgs/desktops/xfce/panel-plugins/xfce4-eyes-plugin/default.nix:49:5:
   |
49 |     maintainers = [ ];
   |     ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/maintainers-missing.md

xfce.xfce4-fsguard-plugin:

warning: maintainers-missing
Package does not have a maintainer. Consider adding yourself?
Near pkgs/desktops/xfce/panel-plugins/xfce4-fsguard-plugin/default.nix:49:5:
   |
49 |     maintainers = [ ];
   |     ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/maintainers-missing.md

xfce.xfce4-genmon-plugin:

warning: maintainers-missing
Package does not have a maintainer. Consider adding yourself?
Near pkgs/desktops/xfce/panel-plugins/xfce4-genmon-plugin/default.nix:47:5:
   |
47 |     maintainers = [ ];
   |     ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/maintainers-missing.md

xfce.xfce4-mailwatch-plugin:

warning: unclear-gpl
gpl2 is a deprecated license, check if project uses gpl2Plus or gpl2Only and change meta.license accordingly.
Near pkgs/desktops/xfce/panel-plugins/xfce4-mailwatch-plugin/default.nix:39:5:
   |
39 |     license = licenses.gpl2;
   |     ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/unclear-gpl.md
warning: maintainers-missing
Package does not have a maintainer. Consider adding yourself?
Near pkgs/desktops/xfce/panel-plugins/xfce4-mailwatch-plugin/default.nix:41:5:
   |
41 |     maintainers = [ ];
   |     ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/maintainers-missing.md

xfce.xfce4-mpc-plugin:

warning: maintainers-missing
Package does not have a maintainer. Consider adding yourself?
Near pkgs/desktops/xfce/panel-plugins/xfce4-mpc-plugin/default.nix:41:5:
   |
41 |     maintainers = [ ];
   |     ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/maintainers-missing.md

xfce.xfce4-namebar-plugin:

Please consider this feature to be alpha.
A substituteInPlace with an unmatched pattern got detected:
substituteStream(): WARNING: pattern 'var dirs = Environment.get_system_data_dirs()' doesn't match anything in file 'src/preferences.vala'

Please check the offending substituteInPlace for typos or changes in source.
warning: stale-substitute
Stale substituteInPlace detected.
substituteStream(): WARNING: pattern 'var dirs = Environment.get_system_data_dirs()' doesn't match anything in file 'src/preferences.vala'
See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/stale-substitute.md

xfce.xfce4-netload-plugin:

warning: attribute-typo
A likely typo in rev-prefix argument was found, did you mean prefix?
Near lib/attrsets.nix:362:7:
    |
362 |       value = f name (catAttrs name sets);
    |       ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/attribute-typo.md
warning: unclear-gpl
gpl2 is a deprecated license, check if project uses gpl2Plus or gpl2Only and change meta.license accordingly.
Near lib/attrsets.nix:362:7:
    |
362 |       value = f name (catAttrs name sets);
    |       ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/unclear-gpl.md
warning: maintainers-missing
Package does not have a maintainer. Consider adding yourself?
Near lib/attrsets.nix:362:7:
    |
362 |       value = f name (catAttrs name sets);
    |       ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/maintainers-missing.md

xfce.xfce4-notes-plugin:

warning: maintainers-missing
Package does not have a maintainer. Consider adding yourself?
Near pkgs/desktops/xfce/panel-plugins/xfce4-notes-plugin/default.nix:45:5:
   |
45 |     maintainers = [ ];
   |     ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/maintainers-missing.md

xfce.xfce4notifyd:

warning: unclear-gpl
gpl2 is a deprecated license, check if project uses gpl2Plus or gpl2Only and change meta.license accordingly.
Near lib/attrsets.nix:362:7:
    |
362 |       value = f name (catAttrs name sets);
    |       ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/unclear-gpl.md
warning: maintainers-missing
Package does not have a maintainer. Consider adding yourself?
Near lib/attrsets.nix:362:7:
    |
362 |       value = f name (catAttrs name sets);
    |       ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/maintainers-missing.md

xfce.xfce4panel:

Please consider this feature to be alpha.
A substituteInPlace with an unmatched pattern got detected:
substituteStream(): WARNING: pattern 'gettext' doesn't match anything in file './libxfce4panel/abicheck.sh'
substituteStream(): WARNING: pattern 'gettext' doesn't match anything in file './autogen.sh'

Please check the offending substituteInPlace for typos or changes in source.
warning: unclear-gpl
gpl2 is a deprecated license, check if project uses gpl2Plus or gpl2Only and change meta.license accordingly.
Near lib/attrsets.nix:362:7:
    |
362 |       value = f name (catAttrs name sets);
    |       ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/unclear-gpl.md
warning: maintainers-missing
Package does not have a maintainer. Consider adding yourself?
Near lib/attrsets.nix:362:7:
    |
362 |       value = f name (catAttrs name sets);
    |       ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/maintainers-missing.md
warning: missing-patch-comment
Please add a comment on the line above, explaining the purpose of this patch.
Near pkgs/desktops/xfce/core/xfce4-panel/default.nix:45:15:
   |
45 |   patches = [ ./xfce4-panel-datadir.patch ];
   |               ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/missing-patch-comment.md
warning: stale-substitute
Stale substituteInPlace detected.
substituteStream(): WARNING: pattern 'gettext' doesn't match anything in file './libxfce4panel/abicheck.sh'
See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/stale-substitute.md
warning: stale-substitute
Stale substituteInPlace detected.
substituteStream(): WARNING: pattern 'gettext' doesn't match anything in file './autogen.sh'
See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/stale-substitute.md

xfce.xfce4-power-manager:

warning: unclear-gpl
gpl2 is a deprecated license, check if project uses gpl2Plus or gpl2Only and change meta.license accordingly.
Near lib/attrsets.nix:362:7:
    |
362 |       value = f name (catAttrs name sets);
    |       ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/unclear-gpl.md
warning: maintainers-missing
Package does not have a maintainer. Consider adding yourself?
Near lib/attrsets.nix:362:7:
    |
362 |       value = f name (catAttrs name sets);
    |       ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/maintainers-missing.md

xfce.xfce4-pulseaudio-plugin:

warning: unclear-gpl
gpl2 is a deprecated license, check if project uses gpl2Plus or gpl2Only and change meta.license accordingly.
Near lib/attrsets.nix:362:7:
    |
362 |       value = f name (catAttrs name sets);
    |       ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/unclear-gpl.md
warning: maintainers-missing
Package does not have a maintainer. Consider adding yourself?
Near lib/attrsets.nix:362:7:
    |
362 |       value = f name (catAttrs name sets);
    |       ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/maintainers-missing.md

xfce.xfce4-screenshooter:

warning: unclear-gpl
gpl2 is a deprecated license, check if project uses gpl2Plus or gpl2Only and change meta.license accordingly.
Near lib/attrsets.nix:362:7:
    |
362 |       value = f name (catAttrs name sets);
    |       ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/unclear-gpl.md
warning: maintainers-missing
Package does not have a maintainer. Consider adding yourself?
Near lib/attrsets.nix:362:7:
    |
362 |       value = f name (catAttrs name sets);
    |       ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/maintainers-missing.md

xfce.xfce4-sensors-plugin:

warning: unclear-gpl
gpl2 is a deprecated license, check if project uses gpl2Plus or gpl2Only and change meta.license accordingly.
Near pkgs/desktops/xfce/panel-plugins/xfce4-sensors-plugin/default.nix:50:5:
   |
50 |     license = licenses.gpl2;
   |     ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/unclear-gpl.md

xfce.xfce4session:

warning: unclear-gpl
gpl2 is a deprecated license, check if project uses gpl2Plus or gpl2Only and change meta.license accordingly.
Near lib/attrsets.nix:362:7:
    |
362 |       value = f name (catAttrs name sets);
    |       ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/unclear-gpl.md
warning: maintainers-missing
Package does not have a maintainer. Consider adding yourself?
Near lib/attrsets.nix:362:7:
    |
362 |       value = f name (catAttrs name sets);
    |       ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/maintainers-missing.md
warning: unused-argument
Unused argument: xorg.
Near pkgs/desktops/xfce/core/xfce4-session/default.nix:1:99:
  |
1 | { mkXfceDerivation, polkit, exo, libxfce4util, libxfce4ui, xfconf, iceauth, gtk3, glib, libwnck3, xorg, xfce4-session }:
  |                                                                                ^

xfce.xfce4settings:

Please consider this feature to be alpha.

Near lib/attrsets.nix:362:7:
    |
362 |       value = f name (catAttrs name sets);
    |       ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/unclear-gpl.md
warning: maintainers-missing
Package does not have a maintainer. Consider adding yourself?
Near lib/attrsets.nix:362:7:
    |
362 |       value = f name (catAttrs name sets);
    |       ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/maintainers-missing.md
warning: unused-argument
Unused argument: automakeAddFlags.
 Consider adding yourself?
Near pkgs/desktops/xfce/panel-plugins/xfce4-systemload-plugin/default.nix:47:5:
   |
47 |     maintainers = [ ];
   |     ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/maintainers-missing.md

xfce.xfce4taskmanager:

warning: unclear-gpl
gpl2 is a deprecated license, check if project uses gpl2Plus or gpl2Only and change meta.license accordingly.
Near lib/attrsets.nix:362:7:
    |
362 |       value = f name (catAttrs name sets);
    |       ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/unclear-gpl.md
warning: maintainers-missing
Package does not have a maintainer. Consider adding yourself?
Near lib/attrsets.nix:362:7:
    |
362 |       value = f name (catAttrs name sets);
    |       ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/maintainers-missing.md
warning: unused-argument
Unused argument: lib.
Near pkgs/desktops/xfce/applications/xfce4-taskmanager/default.nix:1:3:
  |
1 | { lib, mkXfceDerivation, exo, gtk3, libwnck3, libXmu }:
  |   ^

xfce.xfce4-timer-plugin:

warning: unclear-gpl
gpl2 is a deprecated license, check if project uses gpl2Plus or gpl2Only and change meta.license accordingly.
Near pkgs/desktops/xfce/panel-plugins/xfce4-timer-plugin/default.nix:41:5:
   |
41 |     license = licenses.gpl2;
   |     ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/unclear-gpl.md
warning: maintainers-missing
Package does not have a maintainer. Consider adding yourself?
Near pkgs/desktops/xfce/panel-plugins/xfce4-timer-plugin/default.nix:42:5:
   |
42 |     maintainers = [ ];
   |     ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/maintainers-missing.md

xfce.xfce4-verve-plugin:

warning: attribute-typo
A likely typo in rev-prefix argument was found, did you mean prefix?
Near lib/attrsets.nix:362:7:
    |
362 |       value = f name (catAttrs name sets);
    |       ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/attribute-typo.md
warning: unclear-gpl
gpl2 is a deprecated license, check if project uses gpl2Plus or gpl2Only and change meta.license accordingly.
Near lib/attrsets.nix:362:7:
    |
362 |       value = f name (catAttrs name sets);
    |       ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/unclear-gpl.md
warning: maintainers-missing
Package does not have a maintainer. Consider adding yourself?
Near lib/attrsets.nix:362:7:
    |
362 |       value = f name (catAttrs name sets);
    |       ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/maintainers-missing.md
warning: unused-argument
Unused argument: xfconf.
Near pkgs/desktops/xfce/panel-plugins/xfce4-verve-plugin/default.nix:8:3:
  |
8 | , xfconf
  |   ^

xfce.xfce4-whiskermenu-plugin:

warning: attribute-typo
A likely typo in rev-prefix argument was found, did you mean prefix?
Near lib/attrsets.nix:362:7:
    |
362 |       value = f name (catAttrs name sets);
    |       ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/attribute-typo.md
warning: unclear-gpl
gpl2 is a deprecated license, check if project uses gpl2Plus or gpl2Only and change meta.license accordingly.
Near lib/attrsets.nix:362:7:
    |
362 |       value = f name (catAttrs name sets);
    |       ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/unclear-gpl.md
warning: unnecessary-parallel-building
Meson, CMake and qmake already set enableParallelBuilding = true by default so it is not necessary.
Near lib/attrsets.nix:362:7:
    |
362 |       value = f name (catAttrs name sets);
    |       ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/unnecessary-parallel-building.md
warning: maintainers-missing
Package does not have a maintainer. Consider adding yourself?
Near lib/attrsets.nix:362:7:
    |
362 |       value = f name (catAttrs name sets);
    |       ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/maintainers-missing.md

xfce.xfce4-xkb-plugin:

warning: attribute-typo
A likely typo in rev-prefix argument was found, did you mean prefix?
Near lib/attrsets.nix:362:7:
    |
362 |       value = f name (catAttrs name sets);
    |       ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/attribute-typo.md
warning: unclear-gpl
gpl2 is a deprecated license, check if project uses gpl2Plus or gpl2Only and change meta.license accordingly.
Near lib/attrsets.nix:362:7:
    |
362 |       value = f name (catAttrs name sets);
    |       ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/unclear-gpl.md
warning: maintainers-missing
Package does not have a maintainer. Consider adding yourself?
Near lib/attrsets.nix:362:7:
    |
362 |       value = f name (catAttrs name sets);
    |       ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/maintainers-missing.md

xfce.xfconf:

warning: unclear-gpl
gpl2 is a deprecated license, check if project uses gpl2Plus or gpl2Only and change meta.license accordingly.
Near lib/attrsets.nix:362:7:
    |
362 |       value = f name (catAttrs name sets);
    |       ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/unclear-gpl.md
warning: maintainers-missing
Package does not have a maintainer. Consider adding yourself?
Near lib/attrsets.nix:362:7:
    |
362 |       value = f name (catAttrs name sets);
    |       ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/maintainers-missing.md

xfce.xfdashboard:

warning: attribute-typo
A likely typo in rev-prefix argument was found, did you mean prefix?
Near lib/attrsets.nix:362:7:
    |
362 |       value = f name (catAttrs name sets);
    |       ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/attribute-typo.md
warning: unclear-gpl
gpl2 is a deprecated license, check if project uses gpl2Plus or gpl2Only and change meta.license accordingly.
Near lib/attrsets.nix:362:7:
    |
362 |       value = f name (catAttrs name sets);
    |       ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/unclear-gpl.md
warning: maintainers-missing
Package does not have a maintainer. Consider adding yourself?
Near lib/attrsets.nix:362:7:
    |
362 |       value = f name (catAttrs name sets);
    |       ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/maintainers-missing.md

xfce.xfdesktop:

warning: unclear-gpl
gpl2 is a deprecated license, check if project uses gpl2Plus or gpl2Only and change meta.license accordingly.
Near lib/attrsets.nix:362:7:
    |
362 |       value = f name (catAttrs name sets);
    |       ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/unclear-gpl.md
warning: maintainers-missing
Package does not have a maintainer. Consider adding yourself?
Near lib/attrsets.nix:362:7:
    |
362 |       value = f name (catAttrs name sets);
    |       ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/maintainers-missing.md

xfce.xfwm4:

warning: unclear-gpl
gpl2 is a deprecated license, check if project uses gpl2Plus or gpl2Only and change meta.license accordingly.
Near lib/attrsets.nix:362:7:
    |
362 |       value = f name (catAttrs name sets);
    |       ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/unclear-gpl.md
warning: maintainers-missing
Package does not have a maintainer. Consider adding yourself?
Near lib/attrsets.nix:362:7:
    |
362 |       value = f name (catAttrs name sets);
    |       ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/maintainers-missing.md

xmonad_log_applet_xfce:

warning: missing-patch-comment
Please add a comment on the line above, explaining the purpose of this patch.
Near pkgs/applications/window-managers/xmonad/log-applet/default.nix:32:15:
   |
32 |   patches = [ ./fix-paths.patch ];
   |               ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/missing-patch-comment.md

I wish we had xfce4-mixer back.

Result of nixpkgs-review pr 114567 run on x86_64-linux 1

5 packages marked as broken and skipped:

xfce.xfce4-embed-plugin
xfce.xfce4-hardware-monitor-plugin
xfce.xfce4-vala-panel-appmenu-plugin
xfce.xfce4_embed_plugin
xfce.xfce4_hardware_monitor_plugin

1 package failed to build:

xmonad_log_applet_xfce

57 packages built:

lightdm_gtk_greeter
pragha
xfce.exo
xfce.garcon
xfce.gigolo
xfce.libxfce4ui (xfce.libxfce4ui_gtk3)
xfce.libxfce4util
xfce.mousepad
xfce.orage
xfce.parole
xfce.ristretto
xfce.terminal (xfce.xfce4-terminal ,xfce.xfce4terminal)
xfce.thunar (xfce.thunar-bare ,xfce.thunar-build ,xfce.thunarx-2-dev)
xfce.thunar-archive-plugin
xfce.thunar-dropbox-plugin
xfce.thunar-volman (xfce.thunar_volman)
xfce.tumbler
xfce.xfburn
xfce.xfce4-appfinder (xfce.xfce4_appfinder)
xfce.xfce4-battery-plugin (xfce.xfce4_battery_plugin)
xfce.xfce4-clipman-plugin (xfce.xfce4_clipman_plugin)
xfce.xfce4-cpufreq-plugin (xfce.xfce4_cpufreq_plugin)
xfce.xfce4-cpugraph-plugin (xfce.xfce4_cpugraph_plugin)
xfce.xfce4-datetime-plugin (xfce.xfce4_datetime_plugin)
xfce.xfce4-dev-tools (xfce.xfce4_dev_tools)
xfce.xfce4-dict
xfce.xfce4-dockbarx-plugin (xfce.xfce4_dockbarx_plugin)
xfce.xfce4-eyes-plugin (xfce.xfce4_eyes_plugin)
xfce.xfce4-fsguard-plugin (xfce.xfce4_fsguard_plugin)
xfce.xfce4-genmon-plugin (xfce.xfce4_genmon_plugin)
xfce.xfce4-i3-workspaces-plugin
xfce.xfce4-mailwatch-plugin (xfce.xfce4_mailwatch_plugin)
xfce.xfce4-mpc-plugin (xfce.xfce4_mpc_plugin)
xfce.xfce4-namebar-plugin (xfce.xfce4_namebar_plugin)
xfce.xfce4-netload-plugin (xfce.xfce4_netload_plugin)
xfce.xfce4-notes-plugin (xfce.xfce4_notes_plugin)
xfce.xfce4notifyd (xfce.xfce4-notifyd)
xfce.xfce4panel (xfce.xfce4-panel ,xfce.xfce4panel_gtk3)
xfce.xfce4-power-manager (xfce.xfce4_power_manager ,xfce.xfce4_power_manager_gtk3)
xfce.xfce4-pulseaudio-plugin (xfce.xfce4_pulseaudio_plugin)
xfce.xfce4-screenshooter
xfce.xfce4-sensors-plugin (xfce.xfce4_sensors_plugin)
xfce.xfce4session (xfce.xfce4-session)
xfce.xfce4settings (xfce.xfce4-settings)
xfce.xfce4-systemload-plugin (xfce.xfce4_systemload_plugin)
xfce.xfce4taskmanager (xfce.xfce4-taskmanager)
xfce.xfce4-timer-plugin (xfce.xfce4_timer_plugin)
xfce.xfce4-verve-plugin (xfce.xfce4_verve_plugin)
xfce.xfce4volumed_pulse (xfce.xfce4-volumed-pulse)
xfce.xfce4-weather-plugin (xfce.xfce4_weather_plugin)
xfce.xfce4-whiskermenu-plugin (xfce.xfce4_whiskermenu_plugin)
xfce.xfce4-windowck-plugin (xfce.xfce4_windowck_plugin)
xfce.xfce4-xkb-plugin (xfce.xfce4_xkb_plugin)
xfce.xfconf
xfce.xfdashboard
xfce.xfdesktop
xfce.xfwm4

mousepad is not working for me:
$ result/bin/mousepad

(process:25308): GLib-GIO-CRITICAL **: 13:48:25.458: g_settings_schema_list_keys: assertion 'schema != NULL' failed

(process:25308): GLib-GIO-CRITICAL **: 13:48:25.458: g_settings_schema_list_children: assertion 'schema != NULL' failed
Segmentation fault (core dumped)

mousepad is not working for me:
$ result/bin/mousepad

(process:25308): GLib-GIO-CRITICAL **: 13:48:25.458: g_settings_schema_list_keys: assertion 'schema != NULL' failed

(process:25308): GLib-GIO-CRITICAL **: 13:48:25.458: g_settings_schema_list_children: assertion 'schema != NULL' failed
Segmentation fault (core dumped)

The segmentation fault was due to not finding the mousepad gsettings schemas.
I have found a fix for it: we have to allow checking parent sources when looking up schema when calling the function g_settings_schema_source_lookup.

I have found a fix for it: we have to allow checking parent sources when looking up the mousepad schema when the function g_settings_schema_source_lookup is called.

Reported upstream.

This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.
Result of nixpkgs-review pr 114567 run on x86_64-linux 1

4 packages marked as broken and skipped:

xfce.xfce4-embed-plugin
xfce.xfce4-hardware-monitor-plugin
xfce.xfce4_embed_plugin
xfce.xfce4_hardware_monitor_plugin

1 package failed to build and are new build failure:

xmonad_log_applet_xfce: log was empty

57 packages built:

lightdm_gtk_greeter
pragha
xfce.exo
xfce.garcon
xfce.gigolo
xfce.libxfce4ui (xfce.libxfce4ui_gtk3)
xfce.libxfce4util
xfce.mousepad
xfce.orage
xfce.parole
xfce.ristretto
xfce.terminal (xfce.xfce4-terminal ,xfce.xfce4terminal)
xfce.thunar (xfce.thunar-bare ,xfce.thunar-build ,xfce.thunarx-2-dev)
xfce.thunar-archive-plugin
xfce.thunar-dropbox-plugin
xfce.thunar-volman (xfce.thunar_volman)
xfce.tumbler
xfce.xfburn
xfce.xfce4-appfinder (xfce.xfce4_appfinder)
xfce.xfce4-battery-plugin (xfce.xfce4_battery_plugin)
xfce.xfce4-clipman-plugin (xfce.xfce4_clipman_plugin)
xfce.xfce4-cpufreq-plugin (xfce.xfce4_cpufreq_plugin)
xfce.xfce4-cpugraph-plugin (xfce.xfce4_cpugraph_plugin)
xfce.xfce4-datetime-plugin (xfce.xfce4_datetime_plugin)
xfce.xfce4-dev-tools (xfce.xfce4_dev_tools)
xfce.xfce4-dict
xfce.xfce4-dockbarx-plugin (xfce.xfce4_dockbarx_plugin)
xfce.xfce4-eyes-plugin (xfce.xfce4_eyes_plugin)
xfce.xfce4-fsguard-plugin (xfce.xfce4_fsguard_plugin)
xfce.xfce4-genmon-plugin (xfce.xfce4_genmon_plugin)
xfce.xfce4-i3-workspaces-plugin
xfce.xfce4-mailwatch-plugin (xfce.xfce4_mailwatch_plugin)
xfce.xfce4-mpc-plugin (xfce.xfce4_mpc_plugin)
xfce.xfce4-namebar-plugin (xfce.xfce4_namebar_plugin)
xfce.xfce4-netload-plugin (xfce.xfce4_netload_plugin)
xfce.xfce4-notes-plugin (xfce.xfce4_notes_plugin)
xfce.xfce4notifyd (xfce.xfce4-notifyd)
xfce.xfce4panel (xfce.xfce4-panel ,xfce.xfce4panel_gtk3)
xfce.xfce4-power-manager (xfce.xfce4_power_manager ,xfce.xfce4_power_manager_gtk3)
xfce.xfce4-pulseaudio-plugin (xfce.xfce4_pulseaudio_plugin)
xfce.xfce4-screenshooter
xfce.xfce4-sensors-plugin (xfce.xfce4_sensors_plugin)
xfce.xfce4session (xfce.xfce4-session)
xfce.xfce4settings (xfce.xfce4-settings)
xfce.xfce4-systemload-plugin (xfce.xfce4_systemload_plugin)
xfce.xfce4taskmanager (xfce.xfce4-taskmanager)
xfce.xfce4-timer-plugin (xfce.xfce4_timer_plugin)
xfce.xfce4-verve-plugin (xfce.xfce4_verve_plugin)
xfce.xfce4volumed_pulse (xfce.xfce4-volumed-pulse)
xfce.xfce4-weather-plugin (xfce.xfce4_weather_plugin)
xfce.xfce4-whiskermenu-plugin (xfce.xfce4_whiskermenu_plugin)
xfce.xfce4-windowck-plugin (xfce.xfce4_windowck_plugin)
xfce.xfce4-xkb-plugin (xfce.xfce4_xkb_plugin)
xfce.xfconf
xfce.xfdashboard
xfce.xfdesktop
xfce.xfwm4

The following issues got detected with the above build packages.
Please fix at least the ones listed with your changed packages:

lightdm_gtk_greeter:

An unsuitable usage of meta.homepage got detected.
Please replace it with the actual URL to not accidentially break things when the homepage gets updated.
warning: maintainers-missing
Package does not have a maintainer. Consider adding yourself?
Near pkgs/applications/display-managers/lightdm/gtk-greeter.nix:77:5:
   |
77 |     maintainers = with maintainers; [ ];
   |     ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/maintainers-missing.md

  terminal/Makefile.am:91: error: MAINTAINER_MODE does not appear in AM_CONDITIONAL
  terminal/Makefile.am: installing './depcomp'
  /nix/store/68b3r289fa48pnjy70qbbdywckjnigc1-automake-1.16.3/share/automake-1.16/am/depend2.am: error: am__fastdepCC does not appear in AM_CONDITIONAL
  /nix/store/68b3r289fa48pnjy70qbbdywckjnigc1-automake-1.16.3/share/automake-1.16/am/depend2.am:   The usual way to define 'am__fastdepCC' is to add 'AC_PROG_CC'
  /nix/store/68b3r289fa48pnjy70qbbdywckjnigc1-automake-1.16.3/share/automake-1.16/am/depend2.am:   to 'configure.ac' and run 'aclocal' and 'autoconf' again
  /nix/store/68b3r289fa48pnjy70qbbdywckjnigc1-automake-1.16.3/share/automake-1.16/am/depend2.am: error: AMDEP does not appear in AM_CONDITIONAL
  /nix/store/68b3r289fa48pnjy70qbbdywckjnigc1-automake-1.16.3/share/automake-1.16/am/depend2.am:   The usual way to define 'AMDEP' is to add one of the compiler tests
  /nix/store/68b3r289fa48pnjy70qbbdywckjnigc1-automake-1.16.3/share/automake-1.16/am/depend2.am:     AC_PROG_CC, AC_PROG_CXX, AC_PROG_OBJC, AC_PROG_OBJCXX,
  /nix/store/68b3r289fa48pnjy70qbbdywckjnigc1-automake-1.16.3/share/automake-1.16/am/depend2.am:     AM_PROG_AS, AM_PROG_GCJ, AM_PROG_UPC
  /nix/store/68b3r289fa48pnjy70qbbdywckjnigc1-automake-1.16.3/share/automake-1.16/am/depend2.am:   to 'configure.ac' and run 'aclocal' and 'autoconf' again

builder for '/nix/store/wgk6y160fwz6p10kbrd84bg059ymaa22-xfce4-terminal-0.8.10.drv' failed with exit code 1; last 10 log lines:
  terminal/Makefile.am:91: error: MAINTAINER_MODE does not appear in AM_CONDITIONAL
  terminal/Makefile.am: installing './depcomp'
  /nix/store/68b3r289fa48pnjy70qbbdywckjnigc1-automake-1.16.3/share/automake-1.16/am/depend2.am: error: am__fastdepCC does not appear in AM_CONDITIONAL
  /nix/store/68b3r289fa48pnjy70qbbdywckjnigc1-automake-1.16.3/share/automake-1.16/am/depend2.am:   The usual way to define 'am__fastdepCC' is to add 'AC_PROG_CC'
  /nix/store/68b3r289fa48pnjy70qbbdywckjnigc1-automake-1.16.3/share/automake-1.16/am/depend2.am:   to 'configure.ac' and run 'aclocal' and 'autoconf' again
  /nix/store/68b3r289fa48pnjy70qbbdywckjnigc1-automake-1.16.3/share/automake-1.16/am/depend2.am: error: AMDEP does not appear in AM_CONDITIONAL
  /nix/store/68b3r289fa48pnjy70qbbdywckjnigc1-automake-1.16.3/share/automake-1.16/am/depend2.am:   The usual way to define 'AMDEP' is to add one of the compiler tests
  /nix/store/68b3r289fa48pnjy70qbbdywckjnigc1-automake-1.16.3/share/automake-1.16/am/depend2.am:     AC_PROG_CC, AC_PROG_CXX, AC_PROG_OBJC, AC_PROG_OBJCXX,
  /nix/store/68b3r289fa48pnjy70qbbdywckjnigc1-automake-1.16.3/share/automake-1.16/am/depend2.am:     AM_PROG_AS, AM_PROG_GCJ, AM_PROG_UPC
  /nix/store/68b3r289fa48pnjy70qbbdywckjnigc1-automake-1.16.3/share/automake-1.16/am/depend2.am:   to 'configure.ac' and run 'aclocal' and 'autoconf' again

@jonringer Could you give more details on this failure? xfce4-terminal builds without problems for me. It also succeeds according to https://github.com/NixOS/nixpkgs/pull/114567#issuecomment-791574205 and https://github.com/NixOS/nixpkgs/pull/114567#issuecomment-787097416.

builder for '/nix/store/2rjsw7dlq6s0f1zf89zn37rj9g3sbf1z-xmonad-log-applet-xfce4-unstable-2017-09-15.drv' failed with exit code 1; last 10 log lines:
  configure: error: Package requirements (libxfce4panel-1.0 >= 4.6.0) were not met:

  No package 'libxfce4panel-1.0' found

  Consider adjusting the PKG_CONFIG_PATH environment variable if you
  installed software in a non-standard prefix.

  Alternatively, you may set the environment variables LIBPANEL_CFLAGS
  and LIBPANEL_LIBS to avoid the need to call pkg-config.
  See the pkg-config man page for more details.

xmonad-log-applet-xfce4 seems to be unmaintained. The last commit in https://github.com/kalj/xmonad-log-applet was on Sep 15, 2017.
It is not compatible with the new xfce4-panel version.
It was being packaged only by Fedora and Funtoo besides nixpkgs, according to repology. And Fedora is just removing it from their repository. Probably we also have no viable alternative other than removing it from nixpkgs.

I have been using this on my system for some days now, and it seems stable.
If nobody has any more suggestions, I would like to merge this.

This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.
Result of nixpkgs-review pr 114567 run on x86_64-linux 1

5 packages marked as broken and skipped:

xfce.xfce4-embed-plugin
xfce.xfce4-hardware-monitor-plugin
xfce.xfce4_embed_plugin
xfce.xfce4_hardware_monitor_plugin
xmonad_log_applet_xfce

57 packages built:

lightdm_gtk_greeter
pragha
xfce.exo
xfce.garcon
xfce.gigolo
xfce.libxfce4ui (xfce.libxfce4ui_gtk3)
xfce.libxfce4util
xfce.mousepad
xfce.orage
xfce.parole
xfce.ristretto
xfce.terminal (xfce.xfce4-terminal ,xfce.xfce4terminal)
xfce.thunar (xfce.thunar-bare ,xfce.thunar-build ,xfce.thunarx-2-dev)
xfce.thunar-archive-plugin
xfce.thunar-dropbox-plugin
xfce.thunar-volman (xfce.thunar_volman)
xfce.tumbler
xfce.xfburn
xfce.xfce4-appfinder (xfce.xfce4_appfinder)
xfce.xfce4-battery-plugin (xfce.xfce4_battery_plugin)
xfce.xfce4-clipman-plugin (xfce.xfce4_clipman_plugin)
xfce.xfce4-cpufreq-plugin (xfce.xfce4_cpufreq_plugin)
xfce.xfce4-cpugraph-plugin (xfce.xfce4_cpugraph_plugin)
xfce.xfce4-datetime-plugin (xfce.xfce4_datetime_plugin)
xfce.xfce4-dev-tools (xfce.xfce4_dev_tools)
xfce.xfce4-dict
xfce.xfce4-dockbarx-plugin (xfce.xfce4_dockbarx_plugin)
xfce.xfce4-eyes-plugin (xfce.xfce4_eyes_plugin)
xfce.xfce4-fsguard-plugin (xfce.xfce4_fsguard_plugin)
xfce.xfce4-genmon-plugin (xfce.xfce4_genmon_plugin)
xfce.xfce4-i3-workspaces-plugin
xfce.xfce4-mailwatch-plugin (xfce.xfce4_mailwatch_plugin)
xfce.xfce4-mpc-plugin (xfce.xfce4_mpc_plugin)
xfce.xfce4-namebar-plugin (xfce.xfce4_namebar_plugin)
xfce.xfce4-netload-plugin (xfce.xfce4_netload_plugin)
xfce.xfce4-notes-plugin (xfce.xfce4_notes_plugin)
xfce.xfce4notifyd (xfce.xfce4-notifyd)
xfce.xfce4panel (xfce.xfce4-panel ,xfce.xfce4panel_gtk3)
xfce.xfce4-power-manager (xfce.xfce4_power_manager ,xfce.xfce4_power_manager_gtk3)
xfce.xfce4-pulseaudio-plugin (xfce.xfce4_pulseaudio_plugin)
xfce.xfce4-screenshooter
xfce.xfce4-sensors-plugin (xfce.xfce4_sensors_plugin)
xfce.xfce4session (xfce.xfce4-session)
xfce.xfce4settings (xfce.xfce4-settings)
xfce.xfce4-systemload-plugin (xfce.xfce4_systemload_plugin)
xfce.xfce4taskmanager (xfce.xfce4-taskmanager)
xfce.xfce4-timer-plugin (xfce.xfce4_timer_plugin)
xfce.xfce4-verve-plugin (xfce.xfce4_verve_plugin)
xfce.xfce4volumed_pulse (xfce.xfce4-volumed-pulse)
xfce.xfce4-weather-plugin (xfce.xfce4_weather_plugin)
xfce.xfce4-whiskermenu-plugin (xfce.xfce4_whiskermenu_plugin)
xfce.xfce4-windowck-plugin (xfce.xfce4_windowck_plugin)
xfce.xfce4-xkb-plugin (xfce.xfce4_xkb_plugin)
xfce.xfconf
xfce.xfdashboard
xfce.xfdesktop
xfce.xfwm4

The following issues got detected with the above build packages.
Please fix at least the ones listed with your changed packages:

lightdm_gtk_greeter:

An unsuitable usage of meta.homepage got detected.
Please replace it with the actual URL to not accidentially break things when the homepage gets updated.


[Question] How to setup 2 leak sensors?

Could you please advise how to configure 2 leak sensors, so they would be recognized as 2 different entities in HA?
Currently, both of them are reported to a single entity in HA (I can tell this by imitating a leak, and a single entry in HA will reflect state of both)

Unless there in two different zones, the SIA protocol does not distinguish between them.

Could you please help to understand how to 'create' zones? )

I'm not sure, I don't use them.


Remove the need for SplFileObject flags

Since the beginning the League\Csv\Reader class has been relying on the SplFileObject flags for controlling which CSV line are returned or not. The problem is that some differences appear when

using different PHP version (including HHVM);
using SplTempFileObject(used in with Reader::createFromString)  vs SplFileObject (use with other named constructors).

We need a independent yet normalized way to loop through the CSV. So that the following will work out of the box without the need of SplFileObject flags.
foreach ($csv as $row) {
   //do something meaningfull with the $row array
}

The last row shouldn't contains null or false

@nyamsprod any idea how to achieve this? I'm facing the same problem in one of my project

The bug that needed this rewrite has been fixed in the master. The feature is no longer necessary


Add 25 texts total

25 seems like a solid number for a milestone -- not too big, not too small. Texts should be from various genres and styles so that Ambuda can be a general-purpose resource for teachers.
Also, add parse data for at least 80% of these texts.

Closing in favor of a more tactical milestone.


gpl: fix inclusion of test only when tests enabled

The addition of the test in gpl caused builds to build when ENABLE_TEST=OFF this corrects this behavior.
@maliberty it might be nice to add a test to the Jenkinsfile to check this behavior. It doesn't actually have to build openroad, just run cmake, since the failure is in the cmake configuration. https://github.com/siliconcompiler/siliconcompiler/actions/runs/7508809382/job/20444951866

@vvbandeira or @maliberty any update on this?

@gadfort
I will follow-up on the CI test on a separated PR.


New components for amount-currency and date-time

Build failed @johnnysolsson

npm install -D jest-cli solves the issue

@simonmika Pushed new checkbox component. Also, smoothly now builds successfully. Please review.


Explore uncertanties

The Uncertainties package is a python project that allows for fairly seamless handling of quantities along with their uncertainties. It would be fun to try running it through this cost calculator.

This worked basically out of the box. I added an example to the v2 demo notebook in #1.


Add provision for pd.Index in default_json_write by returning list

Coverage increased (+0.008%) to 90.479% when pulling 294ec6d62e053ff144aea4c50a67f68a4378ed8f on dev into 8920a05fee1af0b53f03513b2b3a2e8980294d1c on master.


Support for Docker deployment via Packer

The packer/build.sh script currently defaults to building an AMI for EC2 deployment.
Docker deployment via docker.json requires a seperate shell script, or modifications to the existing script, to build correctly. If deployed to a docker container, Grafana dashboard currently reports N/A metrics. Additional work required to ensure the connector operates correctly.

Have tried a build from Packer to Docker and run into the following so far:

Supervisor needs to be kicked into gear when a new image is first started
service supervisor start

InfluxDB is having some issues which appear very similar to:
https://github.com/influxdb/influxdb/issues/1164

Influx is listening on port 8090, but other ports aren't showing up in netstat.


[SPARK-43484][BUILD][SS] Kafka/Kinesis Assembly should not package hadoop-client-runtime

What changes were proposed in this pull request?

Change hadoop-client-runtime's scope to provided in kafka/kinesis assembly modules.
Why are the changes needed?

hadoop-client-runtime is already included in Spark binary tgz, we should not package it again into the optional assembly jar.
This issue exists since SPARK-33212.
Does this PR introduce any user-facing change?

No.
How was this patch tested?

Manual review.

cc @srowen @sunchao

There are other unexpected jars that were wrongly included in the assembly jar, would like to address them in separate PRs, since they were caused by different tickets, but I'm fine to fix all issues in one PR if the reviewers prefer.

Merged to master, thanks!


"Cannot read property 'getRouteAtDepth' of undefined" when loading react in the browser

Hi,
I realised that this problem happens when the react library is loaded on the browser via an script tag. Because, when I load it on my main.js using
var React = require('react');

it works fine.

:+1:

sorry, you're saying that the global build doesn't work?