Acrolinx quality improvements: bitsadmin-peers-and-list.md

Learn Build status updates of commit 4c6f10c:
:warning: Validation status: warnings

File
Status
Preview URL
Details

WindowsServerDocs/administration/windows-commands/bitsadmin-peers-and-list.md
:warning:Warning

Details

WindowsServerDocs/administration/windows-commands/bitsadmin-peers-and-list.md

Line 1, Column 1: [Warning: ms-date-missing - See documentation] Missing required attribute: 'ms.date'. A freshness date is required for this content set. Add a date in format MM/DD/YYYY.
Line 1, Column 1: [Warning: ms-topic-missing - See documentation] Missing required attribute: 'ms.topic'. Add a valid value to indicate the article type.
Line 1, Column 1: [Warning: author-missing - See documentation] Missing required attribute: 'author'. Add the current author's GitHub ID.
Line 1, Column 1: [Warning: title-missing - See documentation] Missing required attribute: 'title'. Add a title string to show in search engine results.
Line 1, Column 1: [Warning: ms-author-missing - See documentation] Missing required attribute: 'ms.author'. Add the current author's Microsoft alias.
Line 9, Column 1: [Warning: h1-not-first - See documentation] Markdown content is not allowed before H1 'bitsadmin peers and list'.
Line 1, Column 1: [Suggestion: description-missing - See documentation] Missing required attribute: 'description'.

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Learn Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching the learn.microsoft.com contributor guidesPost your question in the Learn support channel


MethodHandle.invoke and MethodHandle.invokeExact are only supported starting with Android O (--min-api 26)

Hello basically i am using log4j library and this support minSdk 26 and currently i am using minSdk 21 but the problem is i cannot upgrade minSdk version to 26 .
So is there any way to compatible midSdk 21 to 26 .. Any help would be appreciated

@nameisjayant,
Although version 2.x has a baseline of Java 8, most of our users nowadays runs Java 11 or Java 17. That is why we must (at least partially) support JPMS.
We introduced the MethodHandle#invokeExact call in ServiceLoaderUtil for this exact reason, starting from version 2.18.0. I don't see a way to remove it.
As a workaround, you can use version 2.17.2.


Warnings

Note to look more closely into the unit test warnings
../../../../mambaforge-pypy3/envs/multidms-dev/lib/python3.12/site-packages/dateutil/tz/tz.py:37
  /home/jared/mambaforge-pypy3/envs/multidms-dev/lib/python3.12/site-packages/dateutil/tz/tz.py:37: DeprecationWarning: datetime.datetime.utcfromtimestamp() is deprecated and scheduled for removal in a future version. Use timezone-aware objects to represent datetimes in UTC: datetime.datetime.fromtimestamp(timestamp, datetime.UTC).
    EPOCH = datetime.datetime.utcfromtimestamp(0)

../../../../mambaforge-pypy3/envs/multidms-dev/lib/python3.12/multiprocessing/popen_fork.py:66: 15 warnings
multidms/data.py: 15 warnings
tests/test_data.py: 210 warnings
  /home/jared/mambaforge-pypy3/envs/multidms-dev/lib/python3.12/multiprocessing/popen_fork.py:66: DeprecationWarning: This process (pid=99501) is multi-threaded, use of fork() may lead to deadlocks in the child.
    self.pid = os.fork()

tests/test_data.py::test_ModelCollection_charts
  /home/jared/MatsenGroup/Projects/multidms/multidms/multidms/model_collection.py:679: FutureWarning: A value is trying to be set on a copy of a DataFrame or Series through chained assignment using an inplace method.
  The behavior will change in pandas 3.0. This inplace method will never work because the intermediate object on which we are setting values always behaves as a copy.

  For example, when doing 'df[col].method(value, inplace=True)', try using 'df.method({col: value}, inplace=True)' or df[col] = df[col].method(value) instead, to perform the operation inplace on the original object.

    muts_df_tall.condition.replace(

tests/test_data.py::test_ModelCollection_charts
  /home/jared/MatsenGroup/Projects/multidms/multidms/multidms/model_collection.py:877: DeprecationWarning: DataFrameGroupBy.apply operated on the grouping columns. This behavior is deprecated, and in a future version of pandas the grouping columns will be excluded from the operation. Either pass `include_groups=False` to exclude the groupings or explicitly select the grouping columns after groupby to silence this warning.
    .apply(sparsity)

-- Docs: https://docs.pytest.org/en/stable/how-to/capture-warnings.html

I don't think the fork warnings have to do with multidms.fit_models since we use the "spawn" context. Rather, it may be the case that pandarallel is messing things up since it explicitly sets the context to be "fork". However, I'm not sure I understand how pandarallel forked processes use jax at all. Maybe it's just because jax is loaded in the forked processes?
One thing you could look at is replacing pandarallel with swifter.

Closing as the last outstanding problem with "deadlock" warning has been individually documented in #147


Is Banshee 3D based on bsf?

Yes.
Please post any further questions on discourse or discord. Github is reserved for bugs and feature requests ONLY.


Feat/table types

Change description
Change the "columns "part of TabelEvidence to return types for the columns. This functionality is there to support the Platform to style the column outputs (e.g., rounding numbers)
Example:
'columns': [
  {'value': 'false_positive_rate', 'type': 'number'},
   {'value': 'true_positive_rate', 'type': 'number'},
   {'value': 'threshold', 'type': 'number'}
]

@IanAtCredo @aproxacs Is this pull request still meaningful?

@fabrizio-credo Yes, please merge this. Now Backend converts this for old Lens versions, but it will be deprecated by the end of this year.
Note : please change str to string


Bluetooth: Support setting long periodic advertising data

If the data is longer than what can fit in one fragment, the data is sent to the controller in multiple operations.

Updated the PR to use ad_stream created in https://github.com/zephyrproject-rtos/zephyr/pull/41537


[FEATURE] Upgrade llama-cpp-python to latest version

The version of llama-cpp-python this project uses is quite old. Therefore I get a lot of errors regarding versions of GGML models. It also doesn't support GGUF models.
I would suggest to up the version of llama-cpp-python to the latest one.
GGUF models are the future anyway it would seem.
Perhaps we could work on something that allows chosing ?

Thanks for remaindering.👍

This project actually depends on llamacpp-python. Seems their most recent version doesn't support gguf. I will see whether they can have an update.


Fix images not shown in screenshots (DEV)

Some images in ImageViews don't show up in our screenshot tests.
We could fix this by replacing these ImageViews with AppCompatImageViews.
However, there could be other issues as well, so I decided against this solution and instead now launch the fragments in our screenshot tests in an AppCompatActivity.
The issue described was related to not using AppCompatActivity, because we used FragmentScenario which uses the non-AppCompatActivity called EmptyFragmentActivity. Unfortunately, its not possible to use custom Activities with FragmentScenario => https://issuetracker.google.com/issues/121347222
That's why we now use ActivityScenario and provide our own Empty AppCompatActivity.
Now all images show up.
TODO before merging

[ ] Revert https://github.com/corona-warn-app/cwa-app-android/pull/3318/commits/789d4dcd64e53da7742cd44f73adf6caf1a92420 (Run firebase_screenshots in CI pipeline)

@LukasLechnerDev Please run the firebase_screenshots job in CI to make sure these changes did not break anything?

@mtwalli Screenshots are now here: https://126387-268027139-gh.circle-artifacts.com/0/zips/CWA-Android-Screenshots-789d4dcd64e53da7742cd44f73adf6caf1a92420.zip. Images are now all visible as far as I can tell, but the weird "grey pressed state" issue is still there.

@mtwalli Screenshots are now here: https://126387-268027139-gh.circle-artifacts.com/0/zips/CWA-Android-Screenshots-789d4dcd64e53da7742cd44f73adf6caf1a92420.zip. Images are now all visible as far as I can tell, but the weird "grey pressed state" issue is still there.

Thanks!, Did you figure out why the pressed state are appearing in screens ?

@mtwalli Screenshots are now here: https://126387-268027139-gh.circle-artifacts.com/0/zips/CWA-Android-Screenshots-789d4dcd64e53da7742cd44f73adf6caf1a92420.zip. Images are now all visible as far as I can tell, but the weird "grey pressed state" issue is still there.

Thanks!, Did you figure out why the pressed state are appearing in screens ?

No, unfortunately not. It doesn't happen locally on my devices, so its very hard to fix for me. I guess a potential solution would be to tweak the device on which the screenshots are taken in the CI pipeline (maybe try other Android Versions or a different device altogether, etc. )


Remove exporting remote skill link

The remote skill is a preview feature and not enabled on PROD. Remove the link from public folder.
The instruction page itself is not deleted since we may pick it up later when the feature is published.

#sign-off

@ovishesh: I'm sorry - only the author of this article, @, can sign off on your changes. But we do have an exception process - if you are on the Microsoft content or product team for this product area, you can ask the PR review team to review and merge it by sending mail to the techdocprs alias.

#sign-off

@eric-urban: I'm sorry - only the author of this article, @, can sign off on your changes. But we do have an exception process - if you are on the Microsoft content or product team for this product area, you can ask the PR review team to review and merge it by sending mail to the techdocprs alias.

@nitinme Could you review? An 'orphaned' article contradicts internal quality standards. Thanks.

@Emma-ms or @eric-urban This kind of change is best made in the private repository. We'll close this PR. Would you create a new PR in the private repo? Thanks very much.

Hi @ktoliver, Do we still require new PR in Private Repo to resolve this? I think @eric-urban has resolved this in the link below:
Thanks
https://github.com/MicrosoftDocs/azure-docs-pr/commit/444438d03d08f8391a5050e0d573f855fa0b7a83#diff-54b62b8e97713ca4d67c85e7acaf2bcd672162ed6bf16525e410125b1802f9db

Hi @ktoliver, Do we still require new PR in Private Repo to resolve this? I think @eric-urban has resolved this in the link below:
Thanks
MicrosoftDocs/azure-docs-pr@444438d#diff-54b62b8e97713ca4d67c85e7acaf2bcd672162ed6bf16525e410125b1802f9db

@aazeez442 No, thanks; everything looks in order. Thanks!


Index 0 is out of bounds

Traceback (most recent call last):
File "/usr/local/bin/stegpy", line 8, in
sys.exit(main())
File "/usr/local/lib/python3.8/dist-packages/stegpy/steg.py", line 52, in main
host.read_message(password)
File "/usr/local/lib/python3.8/dist-packages/stegpy/lsb.py", line 45, in read_message
msg = decode_message(self.data)
File "/usr/local/lib/python3.8/dist-packages/stegpy/lsb.py", line 167, in decode_message
bits = 2 ** ((host_data[0] & 48) >> 4) # bits = 2 ^ (5th and 6th bits)
IndexError: index 0 is out of bounds for axis 0 with size 0

I haven't looked at this program in a long time. Can you give provide the host file you tried to use or some context like how often this problem happens?


Add new study - using Trial Registry - search registry independent

When adding a new study by using the trial registry you have to choose the registry first and to enter the exact ID. Would it be possible to have a registry independent search of ID or title (through study characteristics like in MDR)?

@sergiocontrino We dont have an API for this in the current BE. In all the mdr related APIs we have to send both Study id and registry id

thank you @Swarnalathaa , moving to other milestone


Test with multiple database backends

Discovered a backend specific issue for postgresql(#21) and added a new github action to run tests with postgresql. Would be a good idea to run it with other backends as well.

closing from #30


Split out our directory structure vs. Forge

After discussion with leadership, we have elected to split out the directory structure of Sponge to remain compatible (mostly) with 3rd party platforms (namely Forge). Current running idea is to do as follows:

../mods -> ../plugins
Split where plugin configs and Sponge configs are stored
Remove the alternate plugins directory configuration property. The only reason this was useful was SpongeForge co-mingling plugins and mods. In the high unlikelihood that an implementation is made that the root platform also has plugins, we can circle back at that point.
Remove specifying where the config directory for plugins are located. Per the same reason as the prior bullet.
Add ../plugin-configs
Add ../sponge. This will become where Sponge's internal files will mostly reside (except for things specific to worlds)

Add ../sponge/config
Add ../sponge/libraries

I'm curious as to what this change means for what was previously called "hybrid" Sponge plugins. e.g. they contained both mods and plugins , usually in the form of mixins.

I'm curious as to what this change means for what was previously called "hybrid" Sponge plugins. e.g. they contained both mods and plugins , usually in the form of mixins.

Honestly it would be best to deploy that in our plugins directory. Mixins are now read from plugin jars in the plugins directory in 1.16.5+


Typhoeus fails to make SSL connection on host where curl success

Hello, we I am with the html-proof project. Sending an issue upstream where our customer cannot connect to an SSL host. They are running on an old Travis host and that same host can make the same connection using curl.
Full issue report is at https://github.com/gjtorikian/html-proofer/issues/376
Please advise what information we can get you to be helpful.
Ping @ilg-ul

You probably need to install a libcurl with openssl compiled in

Hi, I'm getting the exact same issue on my end.
@andrewfader I tried installing libcurl with openssl on my Mac using homebrew but still having the same issue. Are you using Mac OS?

should typheous and command-line curl both be using the same libcurl? i.e. if curl succeeds OK, can libcurl be the problem? This does seem to be happening to me for any ssl site.
I've also tried changing to libcurl4-openssl, again to no avail.

I'm debugging this for the html-proofer project in a local travis test environment. I'm now running:

request = Typhoeus::Request.new(
  ARGV[1],
  method: :get,
  headers: { Accept: "text/html" }
)

request.run

puts request.response.code

Using that against https://talk.jekyllrb.com results in a code 0.
Initially the OS had libcurl4-gnutls-dev installed, which I swapped to libcurl4-openssl-dev to no avail. Still investigating.

Sorry, ignore that, my code was bad (should be ARGV[0], I'm an idiot). I'm getting a 200 with that now. Heading back up the stack...

AHA. Got it.
My change to libcurl4-openssl-dev is what did it.
It seems that running the code above with libcurl4-gnutls-dev installed (the default on this travis environment) results in many code 0 responses. Changing to libcurl4-openssl-dev fixes it.
Why that should be inside typhoeus, I'm not sure, but it's definitely openssl vs gnutls at work here.

Thank you for identifying the root cause. Sorry, I don't know much about Typhoeus, could you please help interpret this information as to how a user of html-proofer can get make their Travis scripts Just Work?

@fulldecent I did a writeup on the htmlproofer wiki at https://github.com/gjtorikian/html-proofer/wiki/Using-HTMLProofer-From-Ruby-and-Travis - the important bit is telling travis to use openssl instead of gnutls:
addons:
  apt:
    packages:
    - libcurl4-openssl-dev

I suspect this should be changed into an issue highlighting the fact that typhoeus has problems with gnutls.

@Floppy Thanks for helping with that. For html-proofer's perspective, we are fully happy with this solution/workaround and it is resolved.

Also experiencing this on Mac OS 10.13.4, Net::HTTP and curl work fine but Typhoeus keeps returning could not load PEM client certificate, OpenSSL error error:0200103F:system library:fopen:File name too long when passing the following options:
          sslkey: key,
          sslcert: certificate,
          ssl_verifyhost: 0,
          ssl_verifypeer: false
}```

thanks, the same issue, always got an esponse_code=0return_code=ssl_cacert_badfile ,after reinstall libcurl4-openssl-dev, the issue solved, so happy


Starting pool fails ( on BTC )

Hi,
I'm building the miningcore for Bitcoin, but everytime i start the pool, i get this error.
I've seen others getting the same issue ( on bitcoin cash ) but i tried those options without any result.
I've tried 3 differtent bitcoin node versions en still no change.
Created wallets on the usual way, deleted them on using other nodes and recreate them.
Anyway, this is the error:
[2022-01-30 11:57:15.2688] [E] [bitcoin1] System.FormatException: Invalid base58 data
at NBitcoin.DataEncoders.Base58Encoder.DecodeData(String encoded)
at NBitcoin.DataEncoders.Base58CheckEncoder.DecodeData(String encoded)
at Miningcore.Blockchain.Bitcoin.BitcoinUtils.AddressToDestination(String address, Network expectedNetwork) in /home/sven/pools/miningcore/src/Miningcore/Blockchain/Bitcoin/BitcoinUtils.cs:line 20
at Miningcore.Blockchain.Bitcoin.BitcoinJobManagerBase1.AddressToDestination(String address, Nullable1 addressType) in /home/sven/pools/miningcore/src/Miningcore/Blockchain/Bitcoin/BitcoinJobManagerBase.cs:line 527
at Miningcore.Blockchain.Bitcoin.BitcoinJobManagerBase`1.PostStartInitAsync(CancellationToken ct) in /home/sven/pools/miningcore/src/Miningcore/Blockchain/Bitcoin/BitcoinJobManagerBase.cs:line 481
Anyone that could help me out?
Thanks.

You need to use a bitcoin legacy address as pool address. Legacy addresses start with 1

Hi,
Thanks for your fast reply.
That part is solved now, now i got my last issue i gues:
[2022-01-30 18:12:42.9831] [I] [Bitcoin1] Stratum ports <IP_ADDRESS>:3052 online
[2022-01-30 18:12:43.1976] [E] [Bitcoin1] System.TypeInitializationException: The type initializer for 'ZeroMQ.lib.zmq' threw an exception.
---> System.DllNotFoundException: Unable to load shared library 'libzmq' or one of its dependencies. In order to help diagnose loading problems, consider setting the LD_DEBUG environment variable: liblibzmq: cannot open shared object file: No such file or directory
at ZeroMQ.lib.zmq.version(Int32& major, Int32& minor, Int32& patch)
at ZeroMQ.lib.zmq..cctor()
--- End of inner exception stack trace ---
at ZeroMQ.lib.zmq.ctx_new()
at ZeroMQ.ZContext..ctor()
at ZeroMQ.ZContext.get_Current()
at Miningcore.Rpc.RpcClient.<>c__DisplayClass16_1.b__2() in /home/sven/pools/miningcore/src/Miningcore/Rpc/RpcClient.cs:line 345 System.TypeInitializationException: The type initializer for 'ZeroMQ.lib.zmq' threw an exception.
---> System.DllNotFoundException: Unable to load shared library 'libzmq' or one of its dependencies. In order to help diagnose loading problems, consider setting the LD_DEBUG environment variable: liblibzmq: cannot open shared object file: No such file or directory
at ZeroMQ.lib.zmq.version(Int32& major, Int32& minor, Int32& patch)
at ZeroMQ.lib.zmq..cctor()
--- End of inner exception stack trace ---
at ZeroMQ.lib.zmq.ctx_new()
at ZeroMQ.ZContext..ctor()
at ZeroMQ.ZContext.get_Current()
at Miningcore.Rpc.RpcClient.<>c__DisplayClass16_1.b__2() in /home/sven/pools/miningcore/src/Miningcore/Rpc/RpcClient.cs:line 345    at ZeroMQ.lib.zmq.ctx_new()
at ZeroMQ.ZContext..ctor()
at ZeroMQ.ZContext.get_Current()
at Miningcore.Rpc.RpcClient.<>c__DisplayClass16_1.b__2() in /home/sven/pools/miningcore/src/Miningcore/Rpc/RpcClient.cs:line 345
Any idea?
Van: Oliver @.>
Verzonden: zondag 30 januari 2022 13:53
Aan: @.>
CC: @.>; @.>
Onderwerp: Re: [oliverw/miningcore] Starting pool fails ( on BTC ) (Issue #1144)
You need to use a bitcoin legacy address as pool address. Legacy addresses start with 1
—
Reply to this email directly, view it on GitHubhttps://github.com/oliverw/miningcore/issues/1144#issuecomment-1025137164, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ABONXW53YPQ3FODTSNEFUQTUYUYDJANCNFSM5NEFENGA.
Triage notifications on the go with GitHub Mobile for iOShttps://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Androidhttps://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
You are receiving this because you authored the thread.Message ID: @.***>

I found the fix ( for linux/ubuntu )
fix this with compiling and install zeromq lib:
wget https://github.com/zeromq/libzmq/archive/v4.2.3.tar.gz
tar zxvf v4.2.3.tar.gz
cd libzmq-4.2.3/
./autogen.sh
./configure --prefix=/usr
make
make install
check:
$ ls /usr/lib/libzmq.*
/usr/lib/libzmq.a /usr/lib/libzmq.so /usr/lib/libzmq.so.5.1.3
/usr/lib/libzmq.la /usr/lib/libzmq.so.5
or the fastest way is download from repository:
apt-get install libzmq3-dev


Change video quality support

Is it possible to extend VideoPlayerController so I can change the video quality of hls streams. Hls.js supports changing the video quality but I can't figure out how to call the Hls.js api.

it is not possible to do this in this plugin , because i can only use methods that are supported in the official video_player plugin.

it is not possible to do this in this plugin , because i can only use methods that are supported in the official video_player plugin.
if they add support for changing video quality in video_player , i will add support for that in this plugin.

Is there any workaround so I can change the quality. Is there any package or plugin that enables this feature?

there is better_player but it only supports android and ios.


Should AeCairoContext provide a single source setter method that double-dispatchs on Color and AeCairoSurface?

In cairo, the "source" can be a color, a gradient or a surface. The C API and our bindings are:
void	cairo_set_source () -> #source:
void	cairo_set_source_rgb () -> #sourceColorR:g:b:
void	cairo_set_source_rgba () -> #sourceColorR:g:b:a:
void	cairo_set_source_surface () -> #sourceSurface:x:y:

The first function receives a AeCairoPattern, an instance of this hierarchy:

in the other hand, the cairo_set_source_rgb, cairo_set_source_rgba and cairo_set_source_surface are only shortcuts that internally create a pattern but avoid creation of the patterns explicitly on lib users.
In our bindings, I added this method to simplify setting as source an instance of Color:
AeCairoContext>>
sourceColor: aColor

	aColor isTranslucent
		ifTrue: [
			self
				sourceColorR: aColor red
				g: aColor green
				b: aColor blue
				a: aColor alpha ]
		ifFalse: [
			self
				sourceColorR: aColor red
				g: aColor green
				b: aColor blue ]

My point: When writing examples and tests, several times I had the intuition to type aCairoContext source: Color black instead of aCairoContext sourceColor: Color black.
We could provide something like:
AeCairoContext>>
source: anObject
	anObject aeSetAsSourceIn: self

and then:
AeCairoSurface>>
aeSetAsSourceIn: aCairoContext
	aCairoContext sourceSurface: self x: 0 y: 0

and convert AeCairoContext>>sourceColor: into Color>>aeSetAsSourceIn:.
Not sure if I like it, anyway.
👉 Please share your opinions 👈

This would include as well renaming current AeCairoContext>>source: as sourcePattern:, and add AeCairoPattern>>asSetAsSourceIn: that sets it when using the generic source:.


set Pod restartPolicy to Never when injecting sidecar container

On further reflection, this isn't the right direction.  We should instead add support in the injector for single-container style applications because that is the only configuration that actually gives us the semantics we need on Kubernetes as it is today (and in the foreseeable future since the sidecar container KEP is stalled and doesn't do everything we need).


Provided a better message when encountering invalid clusterId

This PR addresses issue https://github.com/nats-io/java-nats-streaming/issues/70

We appreciate the contribution and time you've spent here, but feel it's better to address this through documentation.  See:  https://github.com/nats-io/java-nats-streaming/issues/70


Including a sub crate in cargo package doesn't seem to be possible?

STR:

git clone https://github.com/eqrion/cbindgen && cd cbindgen && git checkout v0.16.0
cargo package (succeeds)
Add to the Cargo.toml file something like include = ["tests/rust/expand_dep"] (or any other test sub-crate). I expected something like that to fix https://github.com/eqrion/cbindgen/issues/637.
cargo package

Expected:

Crates get packaged?

Actual:
error: couldn't read src/lib.rs: No such file or directory (os error 2)
error: aborting due to previous error
error: could not compile `cbindgen`

Hmm, ok, so include = [] is not doing what I expected, which is fine, but is there a way to include a subcrate? Doing it explicitly doesn't seem to help. I guess for now I can avoid packaging those tests but...

Cargo intentionally does not allow a single .crate file to include multiple packages (see #6917 and #8597).  In general, the .crate file should not be expected to be able to run all tests.  Although it works in many cases, there are various edge cases that do not work.  If you want a fully testable snapshot of a release, I would suggest packaging it separately (for example, using GitHub Releases).

I see, thanks. That's a kind of unfortunate limitation, as it'd be nice if cargo package did "the right thing" off-hand.
I guess for now skipping those tests is fine. If somebody cares, making a separate source release is probably also an option.
I'll close this since this seems basically a dupe of https://github.com/rust-lang/cargo/issues/8597. Thanks for the references!


Gem Value

Formula for Gem value is being figured incorrectly, resulting in gem values being wrong.
Formula is (C^2 + 4 x C) x V
Currently the program is running it as (C^2 + 4) x C x V.

OK, I realize its been a long, long time, but I finally remembered to fix this. Please take a look.


Allow string values for script- and style-src policies

Summary
Ensure that the script- and style-src found on the policyObj are indeed arrays before applying Array.prototype.concat.
This is necessary because "'self'".concat("'sha256-xx'") evaluates to 'self''sha256-xx', which is an invalid policy. The same bug does not appear when using an array, because buildPolicy joins each item in the array with a space between, while it leaves strings intact.
Requirements (place an x in each [ ])

[x] I've read and understood the Contributing Guidelines and have done my best effort to follow them.
[x] I've read and agree to the Code of Conduct.
[x] I've written tests to cover the new code and functionality included in this PR.
[x] I've read, agree to, and signed the Contributor License Agreement (CLA).

I was unable to sign the CLA using the link provided, it just showed a blank page for me.

Codecov Report

Merging #9 into master will not change coverage.
The diff coverage is 100%.

@@          Coverage Diff          @@
##           master     #9   +/-   ##
=====================================
  Coverage     100%   100%
=====================================
  Files           2      2
  Lines         110    117    +7
  Branches        5      5
=====================================
+ Hits          110    117    +7

Impacted Files
Coverage Δ

spec/plugin.spec.js
100% <100%> (ø)
:arrow_up:

plugin.js
100% <100%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2605f00...3c29bf7. Read the comment docs.

Hi @wanecek, thanks for the contribution(s)! I'm just checking about the contributor guidelines and will get back to you as soon as I get an answer :)

@wanecek the contributor guidelines are up!  Thanks againf or your patience!

@AnujRNair No worries at all :) I signed the CLA :+1:

Hi @wanecek! I'm just confirming with the team that everything has been setup correctly - again, apologies for the delay! This first PR will always be the longest one, but others after this should be reviewed pretty quickly :)

That's perfect, thank you @AnujRNair! Don't worry about it, take your time :) I just wanted to make sure that the PR wasn't forgotten :)

@wanecek would you mind signing the license agreement one more time? I think I misconfigured it before
Thanks!

Sure! Done!


Add background for quickstarts in dark mode

Description
These were looking a little rough in dark-mode (see before / after screenshots in the pull request). This isn't a perfect solution, but I think it looks much better than before.
Screenshot(s)
BEFORE

AFTER

*

While adding pure white can cause some visual strain on dark mode because of the high contrast, I think we can leave it as it is for now given the low traffic.
That said, I'm reviewing our overall visual treatment for Dark mode and I'm working on documenting a set of improvements for Q4. No action on that for now though.

@legnaleama Thanks!  this improvement actually make the overall exp. a little better, so I'm going to merge this in, but I'm looking forward to whatever you come up with.


add cluster name to email subject

prepend cluster name to alert email subject

Coverage increased (+11.6%) to 76.478% when pulling 45d6f9fbaed763e322e6e1e98be62311a0348eaa on dixu/email-subject into 19f68a0756d97026be3eeca73d9bae402f8370bd on master.


Debugging into Python code?

Hello Daniel,
there is one single reason which lets me stick currently on RF Language Server: with this, it is possible to set a breakpoint in the Python code behind keywords and to halt the execution also there. With Robot Code, I am not able to do that.
Are there any plans to support this?

Hello Simon,
Of course, it is also possible to debug into the Python code. However, it is disabled by default.
Search for the setting robotcode.debug.attachPython, with this setting you can enable it for the workspace.
It also works via the Launch Configurations:
        {
            "name": "RobotCode: Default",
            "type": "robotcode",
            "request": "launch",
            "purpose": "default",
            "presentation": {
                "hidden": true
            },
            "attachPython": true,
            "pythonConfiguration": "RobotCode: Python"
        },
        {
            "name": "RobotCode: Python",
            "type": "python",
            "request": "attach",
            "presentation": {
                "hidden": true
            },
            "justMyCode": false
        }

The the purpose of the first configuration is default and there is a setting attachPython, the second configuration is the pythonConfiguration that is used. Here you can also disable justMyCode for the python config to also be able to debug python code that is not in your workspace i.e. the RobotFramework library.

See also https://github.com/d-biehl/robotcode/issues/113


refactor: init @rehearsal/diagnostic package

Created a package @rehearsal/diagnostic with base configs.
 Could you please add inline comments before Class/Function declaration explaining functionality?

I will add all comments in the final PR, because expect some changes in the functions / classes list


The CPU data did not show

Description

I‘m listening to a spring boot project. Many requests are not shown. And the CPU data did not show, but other data can be displayed
Environment

Pinpoint version:
OS, WAS, affected library, etc:
Additional details (e.g. how your collector/web is set up):
ubuntu14.04
tomcat 8.0.32
collector, web 1.6.0-RC2
agent 1.6.0
jdk java-8-openjdk

Additional Info

web photo
bug

I think cpu collection for open jdk is not working right now.
Could you try setting profiler.jvm.vendor.name=Oracle in pinpoint.config and see if it works?

@Xylus
Thank you very much, With your help I solve my problem

@TimeStarRipple Thanks for testing this out - will fix in #2332


Performance problems

Hi,
thanks for your article. Automated Feature Engineering is very promising.
I am running the Loan Repayment script right now to compare it with my own engineered features.
I am very curious about the results.
What is the recommended horse power to compute the result on one day (like mentioned in the article)?
Elapsed: 18:50:30 | Remaining: 22358:53:57 | Progress:   0%|          | Calculated: 3/3563 chunks
The ft.py uses one job by default. Any other value but 1 crashes the script.
I am using a r4.2xlarge aws ec2 instance. But with one job it cannot utilize more than one core.
Nevertheless even with all eight cores, it would still take weeks.
Can you recommend some specs to speed this up?
Best regards

With the Featuretools on Dask notebook implementation, it took about 3 hours to generate the feature matrix using a MacBook laptop with 16 GB of RAM. I'd recommend taking the Dask route instead of doing the entire computation at once.
The Dask implementation should run within a few hours on a personal laptop. It's a great example of the benefits of parallel computation!


RL Chain with VowpalWabbit

Description: This PR adds a new chain rl_chain.PickBest for learned prompt variable injection, detailed description and usage can be found in the example notebook added. It essentially adds a VowpalWabbit layer before the llm call in order to learn or personalize prompt variable selections.

Most of the code is to make the API simple and provide lots of defaults and data wrangling that is needed to use Vowpal Wabbit, so that the user of the chain doesn't have to worry about it.

Dependencies: vowpal-wabbit-next,

sentence-transformers (already a dep)
numpy (already a dep)

tagging @ataymano who contributed to this chain
Tag maintainer: @baskaryan
Twitter handle: @olgavrou

Added example notebook and unit tests

this is super cool @olgavrou! i think it probably makes more sense for this to live in langchain_experimental (libs/experimental/langchain_experimental) package than langchain package. we're trying to put all new more end-to-end chains in langchain_experimental and keeping only the basic, building-block chains in langchain. the difference in user experience should be small. if that sounds good to you im happy to make the move!

Thanks @baskaryan that sounds good
I can also see that the 3.11 extended test fails due to a torchvision dependency installation. I’m unsure why this is happening, do you have any ideas maybe?

Thanks @baskaryan that sounds good
I can also see that the 3.11 extended test fails due to a torchvision dependency installation. I’m unsure why this is happening, do you have any ideas maybe?

I believe there are some known issues with poetry and torchvision https://github.com/python-poetry/poetry/issues/6409. if we don't want to let this block things we can move the unit tests to integration tests for now?

Thanks @baskaryan that sounds good
I can also see that the 3.11 extended test fails due to a torchvision dependency installation. I’m unsure why this is happening, do you have any ideas maybe?

I believe there are some known issues with poetry and torchvision python-poetry/poetry#6409. if we don't want to let this block things we can move the unit tests to integration tests for now?

Sure, I can make both changes: moving into experimental and moving unit to integration tests

Sure, I can make both changes: moving into experimental and moving unit to integration tests

ok @baskaryan moved things into langchain_experimental, leaving the tests as unit_tests seems to work fine now.
Two things:

Unrelated, there were some unit tests failing in experimental, looked unrelated to my changes, added a workaround, let me know if you think it is ok
I also left the notebook in the original location, let me know if there is a different location for it that would make more sense for the docs, like under use cases maybe

@baskaryan :)

apologies for the delay, merged into master in #11462! thank you @olgavrou and @ataymano!!


Replace warn(..) with warning(..)

As per subject.
For #32.
Seems to work in Python 2.

@kobbled: I forgot you already had 320f8c3 lined up for this.
Let me know if you'd want me to close this one and merge 320f8c3 instead.

No, that is fine, you can continue merging b9e53b7 into master. Thanks though.


How to apply custom entity to current selection only?

I'm using a sample code found here to implement a custom entity for links.
What is the current behavior?
Select a portion of text, and create a link. Then keep typing after the link is created, and the editor will mark all characters you type in as a part of the link.
What is the expected behavior?
The link should be created for the current selection only. When you type more characters after creating a link, they should be plain text, not a link.

@ming-soon it seems like you're wanting an IMMUTABLE entity. Take a look at: https://draftjs.org/docs/advanced-topics-entities.html#mutability

@richardson-trevor Thanks.


:gift_heart: Run Go tests for each module

Changes

:gift_heart: Run Go tests for each module

/kind enhancement
Fixes #

Looks like this helps:

https://github.com/knative/client/pull/1953/checks?check_run_id=29579171848
https://github.com/knative/client/actions/runs/10672089158/job/29579078173?pr=1953#step:7:49

/cc @dsimansk


Able to set progress bar index to a custom value.

It would be useful to be able to dynamically update the progress bar value to any index - one usecase is tracking a download.

[Current coverage][cc-pull] is 97.44%

Merging [#1][cc-pull] into [master][cc-base-branch] will decrease coverage by 0.79%

2 files (not in diff) in Sources were modified. more
File ...urces/Progress.swift was modified. more

@@           master         #1   diff @@
========================================
  Files           3          3
  Lines         113        117     +4
  Methods         0          0
  Branches        0          0
========================================
+ Hits          111        114     +3
- Misses          2          3     +1
  Partials        0          0

Powered by Codecov. Last updated by [e926656...e7d1772][cc-compare]
[cc-base-branch]: https://codecov.io/gh/jkandzi/Progress.swift/branch/master?src=pr
[cc-compare]: https://codecov.io/gh/jkandzi/Progress.swift/compare/e926656a61050e8a1b60aeb21521993fd1432ece...e7d1772a5c29806e3da6095782e19ca48b848044
[cc-pull]: https://codecov.io/gh/jkandzi/Progress.swift/pull/1?src=pr


wrap functions with multiple arguments

julia> A = rand(iterdates())
TimeDag.Rand{Float64}(MersenneTwister(0x8cd2a3d85b05db9753173f0c2181b447))

julia> B = 2*A
TimeDag.SimpleBinary{*, Float64, TimeDag.UnionAlignment}()

julia> D = wrap((a, b, c) -> a+b-c)(A, B, A)
ERROR: MethodError: no method matching apply(::var"#111#112", ::TimeDag.Node{Float64}, ::TimeDag.Node{Float64}, ::TimeDag.Node{Float64})
Closest candidates are:
  apply(::Function, ::TimeDag.Node, ::TimeDag.Node; kwargs...) at /Users/mzgubic/JuliaEnvs/TimeDagForecasters/dev/TimeDag/src/ops/core.jl:55
  apply(::Function, ::TimeDag.Node, ::Any; kwargs...) at /Users/mzgubic/JuliaEnvs/TimeDagForecasters/dev/TimeDag/src/ops/core.jl:58
  apply(::Function, ::Any, ::TimeDag.Node; kwargs...) at /Users/mzgubic/JuliaEnvs/TimeDagForecasters/dev/TimeDag/src/ops/core.jl:59
  ...
Stacktrace:
 [1] (::TimeDag.Wrapped{var"#111#112"()})(::TimeDag.Node{Float64}, ::Vararg{TimeDag.Node{Float64}, N} where N; kwargs::Base.Iterators.Pairs{Union{}, Union{}, Tuple{}, NamedTuple{(), Tuple{}}})
   @ TimeDag ~/JuliaEnvs/TimeDagForecasters/dev/TimeDag/src/ops/core.jl:80
 [2] (::TimeDag.Wrapped{var"#111#112"()})(::TimeDag.Node{Float64}, ::Vararg{TimeDag.Node{Float64}, N} where N)
   @ TimeDag ~/JuliaEnvs/TimeDagForecasters/dev/TimeDag/src/ops/core.jl:80
 [3] top-level scope
   @ REPL[125]:1

Are there any inherent limitations why we cant do this? It's possible to work around it by building a tuple of arguments and then splat the tuple, but that seems awful 😁
julia> T = wrap((a, b) -> (a, b))(A, B)
TimeDag.SimpleBinary{var"#113#114"(), Tuple{Float64, Float64}, TimeDag.UnionAlignment}()

julia> T2 = wrap((t, b) -> (t..., b))(T, A)
TimeDag.SimpleBinary{var"#115#116"(), Tuple{Float64, Float64, Float64}, TimeDag.UnionAlignment}()

julia> evaluate(wrap(t->t[1] + t[2] - t[3])(T2), DateTime(2021, 1, 1), DateTime(2021, 1, 10))
Block{Float64}(9 knots)
|                time |    value |
|            DateTime |  Float64 |
|---------------------|----------|
| 2021-01-01T00:00:00 |  1.25666 |
| 2021-01-02T00:00:00 |  1.64837 |
| 2021-01-03T00:00:00 | 0.742571 |
| 2021-01-04T00:00:00 | 0.716422 |
| 2021-01-05T00:00:00 | 0.566468 |
| 2021-01-06T00:00:00 | 0.347844 |
| 2021-01-07T00:00:00 |  1.56021 |
| 2021-01-08T00:00:00 |  1.74319 |
| 2021-01-09T00:00:00 |  0.59063 |

I suppose we would need to interpret the Left alignment as Leftmost alignment? I can't see any other issues - though I haven't looked very deeply.

Yep, we definitely want to support nary arguments!
The primary issue is that alignment over more than two nodes currently isn't implemented — will be easy to do this once that is done :)

I think this should be closed by #19, but feel free to re-open if you run into any other problems!
julia> x = rand(iterdates())
TimeDag.Rand{Float64}(MersenneTwister(0x6af540c0b17368c5d697e7081577efda))

julia> y = 2 * x
TimeDag.SimpleBinary{*, Float64, TimeDag.UnionAlignment}()

julia> z = wrap((a, b, c) -> a + b - c)(x, y, x)
TimeDag.SimpleNary{var"#5#6"(), 3, Float64, TimeDag.UnionAlignment}()

julia> evaluate(z, DateTime(2021), DateTime(2021, 1, 3))
Block{Float64}(2 knots)
|                time |   value |
|            DateTime | Float64 |
|---------------------|---------|
| 2021-01-01T00:00:00 | 1.89078 |
| 2021-01-02T00:00:00 | 1.92375 |


Jetson-inference on Jetson Orin NX

Hello,
in the readme file it is stated that the repo can be used on an AGX Orin.
What about Orin NX? Is it supported at the moment? If not, is there a plan to do it in a near future?
Thanks!

@AleBasso80 I haven't actually ran it on an Orin NX, but yes it should work fine.  If you run into any issues please let me know.

@dusty-nv many thanks, I'll try as soon as I get one.
I keep you informed.
Cheers


standalone version of CLEARSWI

Dear Korbinian,
Would it be useful for users to have a versioned standalone version of CLEARSWI as well like you did with ROMEO?
Cheers
Steffen

Hi Steffen,
I'm not sure about the benefit, as I received the feedback that it works nicely in julia. However I plan to build a standalone version anyway to use it within SEPIA.
But since you ask, I guess it would be useful for users ;)

Finally, there is a standalone version of CLEARSWI:
https://github.com/korbinian90/CompileMRI.jl/releases

Hi Korbinian,
I'm finding a bug in the linux version/matlab for SWI....according to me, it calls cmd_mag but doesn't define it...i tried adding
cmd_mag = [ ' -m' mag_fn] but that changes the error from...no cmd_mag to not a string or vector (from memory...so not an exact bug report....). Am getting pretty seriously into unwrapping lately, so this is a very timely and very useful thing for me. I really like ROMEO....although am struggling to remove the pre-scaling....we are doing asynchronous time series...phase contrast...so we want to turn almost ALL of the presets off and just get very vanilla unwrapping...no shifting up and down, no prescaling, no post-scaling...that all SIGNAL for us....

oh, am running entirely from matlab 2020 on Ubuntu 16

Hi @drswgw
Did the error occur in running the $ clearswi ... or $ romeo ... cmd program?
I don't use the matlab version myself and I might have changed something in the compiled version without adjusting the matlab caller. I will check
For ROMEO, you can turn off the scaling of the input with --no-rescale (expects data in radians). By default it shouldn't perform more than unwrapping (adding/subtracting 2π from voxels).
If you need more customization then available or have special questions, please ask. I think the best place would then be here: https://github.com/korbinian90/ROMEO/issues

Hi @drswgw
Thanks for reporting that bug! I think I fixed it, please test the new version v3.3.1:
https://github.com/korbinian90/CompileMRI.jl/releases

Hi Corbinian,
Not sure if this will show up on your end as an image? anyway, tried the new version....
matlab line 65 error in clear SWI
COMMAND must be a string scalar or character vector
the call to cmd_mag is probably fixed, but there is some other call? that is in the wrong format for matlab?
it's further downstream now...who knows, maybe it's on my end with the inputs? I don't think so, because ROMEO works OK...
Maybe it would help to know what I am doing....vanilla unwrapping, don't care about SWI, just want to pirate the Laplacian unwrapping. Our signal is all in the phase domain, the magnitude images are dead to us.

Hi @drswgw ,
That is a weird problem. I used the matlab array concatenation syntax to join strings like [str1 str2]. On your machine that seems to have created an array of strings instead of concatenating them. I replaced these parts of code with strjoin({str1, str2}) instead, maybe that helps. (v3.3.2 https://github.com/korbinian90/CompileMRI.jl/releases)
From writing this reply, I have a second guess what might go wrong. Matlab has this new string type with double quotes "real_string", which seems to be very incompatible with the old type with single quotes 'char_array'. Maybe you used double quotes somewhere? I think this script works only with the single quote char arrays like 'tanh'

For the second part, if you only need the laplacian unwrapping, you could try the julia version. It should be fairly simple:

Install julia and add to PATH (https://julialang.org/downloads/platform/#linux_and_freebsd)
Install Packages: run in the julia REPL: julia> import Pkg; Pkg.add("FFTW"); Pkg.add("MriResearchTools")
Run a julia script in bash with $ julia unwrapping_script.jl

Example contents of unwrapping_script.jl
using MriResearchTools, FFTW

phasefile = "path-to-phase/phase.nii"
phase = readphase(phasefile; rescale=false) # rescale=true, if phase values should be scaled to a 2pi range
unwrapped = laplacianunwrap(phase)

savenii(unwrapped, "path-to-output/unwrapped.nii"; header=header(phase))

(or type these commands in the interactive julia REPL environment)

Hi Korbinian,
Julia should be fine. Will give that a whirl.  Here is the previous errror in more detail. If you can define what the 'COMMAND' string should look like? Seems like it is just a matlab type error (the new versions of matlab have more/confusing types....not a huge fan of some of the changes....in general Matlab struggles to be...consistent). Basically passing a string seems like the hold up.

Hi Korbinian,
OK, this looks like the 'fix'.
The strjoin of all the subitems doesn't work....vsn 3.3.2, BUT...this looks like it does work...so just roll the code back a bit to 3.3.1...and add the strjoin LAST to strjoin the WHOLE string array right before passing it as the argument. i.e. your concatenate is working fine, but is generating a string array (probably becuase of the "SNR" or whatever other matlabness is going on).

SUCCESS....forgetabout previous comment.....MY BAD using "SNR", "laplacian" etc.
['a' 'b'] = 'ab' but ["a" "b"] doesn't work at all. So version 3.2.1, no further mods WORKS....version 3.2.2 probably doesn't work

.

oops 3.3.1 = GOOD
3.3.2 = BAD

I like your post from before, that seems to be a good solution!
Then, the input can be char_arrays or strings, (hopefully) without weird errors.
Wenn putting char_arrays and strings into an array, everything gets promoted to string. Then there is no type mismatch, when joining.
(now you don't need it anymore, but theres a new v3.3.3 coming up, which allows strings and char_arrays)

the standalone version of clearswi is now inlcuded in Neurodesk :)

Hi Korbinian,
OK CLEARSWI is working, using MRItools 3.3.1 and being careful to use single quotes 'a' not "a". ClearSWI turns out to be no good for my application: asynchronous phase based encoding of motions/velocities etc. Currently SWI doesn't output the unwrapped phase data, just a magntidue image and the MIP, which for me the MIP is giving a different number of slices than the input data and the magnitude output just isn't my cup of tea. Some of the input slices come in blank, so that may be why the MIP is missing some slices, but it messes up the masking etc. to change the number of slices.
So on to Julia to try and implement the Laplacian unwrapping.This is my version of Julia already installed, thought I would upgrade to version 1.7.2 to match the current version of the manual from Julia. Which version of Julia does ROMEO and clearSWI use?

Hi Korbinian,
OK, baby steps. Julia up and running, the import for "MriResearchTools" and "FFTW" went swimmingly. What about masking? Probably need to set a mask....

https://user-images.githubusercontent.com/62578943/156423563-61b5c879-b5ea-48bd-8de0-4256dcd33c46.mov

that may be a bit annoying to run all the time, let me know and I can replace it with a still image....still, a picture is worth a thousand words...so a movie must be worth a million


[ENHANCEMENT] Add Finding Violates SLA filtering to Report Builder

This merge request introduces a new feature to the Report Builder.
It enables users to filter findings based on their SLA violation status.
The main use case is to generate reports covering only SLA breaches.

Test results
Use cases tested manually:

no value chosen: displays all findings
"Any" chosen: displays all findings and the field is reset
"False" and "True": display only a proper subset of findings

Documentation
Update not needed for this minor improvement.

@tomaszn Though you failed the Dryrun Security "Sensitive Files Check", your changes are small enough that they won't impact the work we're doing concurrently.


add ability to easily debug ts files

Need to debug ts files as is, without uglifying/minifying/etc

Gues, could someone merge it?

Hi @ast-pmykhailov. Would you please make a reprodution first when debugging ts files is not working? Normally jiti does not uglify or minify and preserves lines as well in error stacks.

@pi0 , the problem is not in uglify/minify of ts modules, but source maps for files are not available

It is intentional. Jiti does not generate source maps but preserves line mapping for correct stack trace.
Would you please fork this repo to reproduce when mapping is not working for debugging: https://stackblitz.com/edit/node-tj6xqn?terminal=start

@pi0
we have .ts file we want to debug

On the first run, right after the build of jiti, it debugs as .js

On the second run, it works with .ts
But with this fix it works correct even for the first run right after the build

any updates @pi0 ? sorry for ping you, but it's really uncomfortable during debug(

Hi, @acibilous Sorry for checking on this late. I see what you mean now. Added a few changes since it can be also useful for ESM files, option is now called JITI_SOURCE_MAPS.


HTML conversion of manual

Best idea yet is from Ben:  use pdf2htmlEx to convert our manual to HTML.
https://github.com/coolwanglu/pdf2htmlEX
Allen suggests these are good for search:  Python documentation or Rust documentation for the way that it provides search.
https://docs.python.org/3/
And this one has optimistic search results (no return) as you type:
http://doc.rust-lang.org/std/

done - all docs are now in bookdown  and can be generated in both pdf and html.


Use the right version of bicep using oras in workflow

Description
This is to use bicep binary from ghcr because https://get.radapp.dev/tools/bicep-extensibility is not used anymore.
Type of change

This pull request fixes a bug in Radius and has an approved issue (issue link required).
This pull request adds or changes features of Radius and has an approved issue (issue link required).
This pull request is a minor refactor, code cleanup, test improvement, or other maintenance task and doesn't change the functionality of Radius (issue link optional).

Fixes: #issue_number

awesome find. thanks :)


Memory leaks in floating-point compression code

Original issue: https://charm.cs.illinois.edu/redmine/issues/271

[src/arch/util/compress.c:218]: (error) Memory leak: baseData
[src/arch/util/compress.c:274]: (error) Memory leak: baseData
[src/arch/util/compress.c:499]: (error) Memory leak: baseData

The leaks all result from the case where bData is NULL on input, and so memory is allocated, but the returned pointer never escapes the individual function.

Original author: Yanhua Sun
Original date: 2013-08-26 19:41:34

Phil,
I checked and noticed when bData is NULL, that function should not be called at all.  How did you detect the memory leak?

Original author: Yanhua Sun
Original date: 2013-08-26 21:56:31

added assert(bData != NULL)  to avoid the memory leak. Checked in

Original date: 2013-08-28 18:54:47

Fixed in commit:774d2cd18d416bd1f8d4b5849330bfe00c03559f


Update Intl

The intl package now has 1.0.0 release candidates. If I use npm install intl it installs the release candidate. Something changed so that if you have a 1.0.0 release candidate things break. Should likely update sometime in the near future.

Will take a look on that.

Updated! :+1:

Now we are integrated with David to keep track of our dependencies state.


[BUG] configure dialog doesn't open for D&D 5e

Describe the bug
I am running the most updated version of foundry and the Dungeons and Dragons 5e system. When I try to update token mold's token configure options, the dialog doesn't pop up. This is the error from the console:
foundry.js:753  TypeError: An error occurred while rendering TokenMoldForm 41. Cannot convert undefined or null to object
at Function.keys ()
at get _actorAttributes [as _actorAttributes] (token-mold.js:1324:32)
at TokenMoldForm.getData (token-mold.js:1081:33)
at TokenMoldForm._render (foundry.js:5812:29)
at TokenMoldForm._render (foundry.js:6532:17)
at TokenMoldForm.render (foundry.js:5769:10)
at HTMLAnchorElement. (token-mold.js:268:19)
To Reproduce
Steps to reproduce the behavior:

Create a world with the D&D 5e system
go to actors tab
open development console
click on the settings icon for token mold

See error (only on console, nothing happens in UX at all)

Expected behavior
The dialog with the token configuration settings should pop up and let me update the settings
Module incompatibilities
I have no other modules active (and have not turned any on since I created a new world to test this)
Desktop (please complete the following information):

OS: My laptop is running windows 11, the VM running foundry is on Ubuntu
Browser: Edge
FVTT Version:  11 build 3.15
System version: 3.0.1
Module version: 2.20.3

I have created a PR for this fix after playing around in the js console for a bit to get the dialog to open:
https://github.com/Moerill/token-mold/pull/198

This is impacting me. I see there is an open PR. I use Forge...so getting the module updated in my game is more complex (I do not know how). Requesting that the change #198 be validated and a patch version created. The code change looks good to me, signed off. I cannot integrate or trigger any GitHub actions for this repo.

I was looking at the console for the error and added the fixes that @Joe-Engineer approved of 15 hours ago and still wasn't able to get the settings screen to pop up, i decided to comment out lines 1317 - 1344 and I did manage to get the settings menu to open, not the most elegant fix but hey, no null pointer exceptions if theres nothing to call on the null pointer exception LOL

I'm having the same issue.
From the console:
foundry.js:753 TypeError: An error occurred while rendering TokenMoldForm 216. Cannot convert undefined or null to object     at Function.keys (<anonymous>)     at get _actorAttributes [as _actorAttributes] (token-mold.js:1324:32)     at TokenMoldForm.getData (token-mold.js:1081:33)     at TokenMoldForm.renderPatch (application-render.js:28:29)     at 🎁call_wrapper [as call_wrapper] (libWrapper-wrapper.js:591:14)     at 🎁Application.prototype._render#0 (libWrapper-wrapper.js:189:20)     at TokenMoldForm._render (foundry.js:6532:17)     at 🎁call_wrapped [as call_wrapped] (libWrapper-wrapper.js:507:22)     at 🎁FormApplication.prototype._render#remote-highlight-ui (hooks.js:31:14)     at 🎁call_wrapper [as call_wrapper] (libWrapper-wrapper.js:616:16)     at 🎁FormApplication.prototype._render#0 (libWrapper-wrapper.js:189:20)     at TokenMoldForm.render (foundry.js:5769:10)     at HTMLAnchorElement.<anonymous> (token-mold.js:268:19)
Token mold 2.20.3
Foundry V11 Build 325

I have the same error. The HP dice and unnamed token works when I drag tokens onto the map, but I can't open the settings.
Foudnry Version 11 Build 315
Dungeons 6 Dragons 5E 3.0.4
Token Mold 2.20.3
From the console:

undry.js:753 TypeError: An error occurred while rendering TokenMoldForm 95. Cannot convert undefined or null to object
[Detected 1 package: token-mold]
at Function.keys ()
at get _actorAttributes [as _actorAttributes] (token-mold.js:1324:32)
at TokenMoldForm.getData (token-mold.js:1081:33)
at TokenMoldForm._render (foundry.js:5812:29)
at TokenMoldForm._render (foundry.js:6532:17)
at TokenMoldForm.render (foundry.js:5769:10)
at HTMLAnchorElement. (token-mold.js:268:19)
onError @ foundry.js:753
🎁call_wrapped @ libWrapper-wrapper.js:507
🎁Hooks.onError#lib-wrapper @ listeners.js:138
🎁Hooks.onError#0 @ libWrapper-wrapper.js:187
(anonymous) @ foundry.js:5771
Promise.catch (async)
render @ foundry.js:5769
(anonymous) @ token-mold.js:268

I've published an unofficial fork that should fix the issue, please test the version that matches your Foundry install.
Foundry v11:  https://raw.githubusercontent.com/BeardedGnome/token-mold/v2.21.0/module.json
Foundry v12:  https://raw.githubusercontent.com/BeardedGnome/token-mold/v2.22.1/module.json

Latest release for Foundry v12 is listed in issue:
https://github.com/Moerill/token-mold/issues/204


Cannot compile tests on macos

The tests in libvsync depend on several Linux specific features, making them non-portable. I believe that is unnecessary, since the library itself should work on other POSIX systems (and most of it should also work on non-POSIX systems).
The issues I’ve found are:

dependency on sys/sysinfo.h
use of non-standard sched_setaffinity
use of non-standard  getrandom
inttypes.h (although here I am unsure about the reason)

If we could get rid of these dependencies, the test cases would be more portable and run on other POSIX systems like macOS.

I have removed the dependency on sys/sysinfo.h and the call to sched_setaffinity and then only these tests to fail to compile:
The following tests FAILED:
         13 - core-vatomic8_write (Not Run)
        176 - test_ut_bitmap (Not Run)
        193 - bounded_mpmc_check_full (Not Run)
        197 - ut_test_simple (Not Run)
        288 - test_case_8_listset_fine (Not Run)
        308 - test_test_case_popped_once_stack_xbo_backoff (Not Run)
        310 - cnd_test1 (Not Run)
        311 - cnd_test2 (Not Run)
        312 - mutex_musl (Not Run)
        313 - mutex_slim (Not Run)
        314 - mutex_tristate (Not Run)
        315 - once (Not Run)

I'll investigate that in more detail the reason for each of them, but the last 6 must be failing because of futex interface.

Ok, I got all tests to compile and run. We just need  4 minor changes. I'll create a MR for it soon.


Enlarge exemption limit

This (tiny) PR increases the transition constraint exemption limit in AirContext by one.
I believe that in some cases, the current limit may be a problem (for instance a trace where the 2^k rows are necessary, which then needs to be extended to the next power of two 2^{k+1}). In such cases, the current limit won't be sufficient, because the last evaluation frame to be checked on the proving side will overlap between the actual trace and the dummy values.

(Clippy failing is not due to the changes induced by this PR, but I can make it go green here if needed)

Thank you! Looks good to me. I'll fix the clippy issue in a separate commit.


GetDepositHistoryAsync Mapping Issue

Cannot map enum value. EnumType: FTX.Net.Enums.DepositStatus, Value: complete, Known values: confirmed, unconfirmed, cancelled, completed. If you think complete should added please open an issue on the Github repo.
This was marked fixed on Feb 24th, but even that had the status as complete not completed.   the Withdrawal one is mapped correctly.

You're right, seems like it wasn't fixed correctly. Should be good now


Move items in Database Navigator up and down

I have read #833 and https://dbeaver.jkiss.org/forum/viewtopic.php?f=2&t=1912
How do I re-order the connections in a folder in Database Navigator?

There is no way to reorder connections (they are always in alphanumeric order).
But there was a bug - DBeaver didn't sort connections on new connection create.
Fixed.


Skill-roll Dice UI: Quick buttons to switch which characteristic is used?

[v1.3] Enhancement (:
There are quite a few instances where a character would want to use a different base stat to roll a skill and, uhhmm, not all players are good with working out dice pools on-the-fly, never mind modifying existing ones. ;)
What would be fantastic is if the Dice UI that appeared by clicking the "Roll" column dice symbols included a row of Characteristic buttons along the top (above the pool perhaps?) that had the default statistic pre-selected but allowed clicking to switch up the stat that's used?
Something abbreviated like... [BR] [AG] [INT] [CUN] [WP] [PR] ...perhaps?
Thanks.

Players need to know how to construct dice pools, doesn't matter if they are not good at working them out on the fly.
Not sure this one is possible with the current way the dice dialog is created, and to update it to allow this could cause more problems.  I'll leave this issue here as a reminder to investigate.

Players need to know how to construct dice pools, doesn't matter if they are not good at working them out on the fly.
Not sure this one is possible with the current way the dice dialog is created, and to update it to allow this could cause more problems.  I'll leave this issue here as a reminder to investigate.

Fair comment, though mine was perhaps a touch more of a snipe at my current players than anything. ;)
The request was more on the basis that there are various talents and such that regularly switch up the stat a character can use to make a roll (such as Guaridan's Soresu Technique allowing Intellect instead of Brawn for Lightsaber checks - or Consular's Willpower instead of Brawn) and it's not at all unusual to ask a player to roll off a skill against another stat than the default.
As the primary way to roll abilities is a simple click on the Roll column of the character sheet, I was definitely hoping that it was an easy step to choose a different stat, even if it was pre-dialog? :>
Fully understand that it's not as straight-forward as it seems, though, so I'm happy that you're keeping it for future investigation. Hopefully, something can be worked out!
(and thanks for the quick response!)

Fair comment, though mine was perhaps a touch more of a snipe at my current players than anything. ;)
The request was more on the basis that there are various talents and such that regularly switch up the stat a character can use to make a roll (such as Guaridan's Soresu Technique allowing Intellect instead of Brawn for Lightsaber checks - or Consular's Willpower instead of Brawn) and it's not at all unusual to ask a player to roll off a skill against another stat than the default.
As the primary way to roll abilities is a simple click on the Roll column of the character sheet, I was definitely hoping that it was an easy step to choose a different stat, even if it was pre-dialog? :>
Fully understand that it's not as straight-forward as it seems, though, so I'm happy that you're keeping it for future investigation. Hopefully, something can be worked out!
(and thanks for the quick response!)

You can always right click the skill and hit "change characteristic".  Especially if it's a case where a character will always use a different stat than normal.

You can always right click the skill and hit "change characteristic".  Especially if it's a case where a character will always use a different stat than normal.

Woah... I didn't even know that was a thiiiing! (and I've right-clicked most things!)
That's awesome! :D

Woah... I didn't even know that was a thiiiing! (and I've right-clicked most things!)
That's awesome! :D

I can add, I also spent inordinate amount of time now knowing about this feature. Right-click in general is not the most intuitive UX nowadays.
How about making the stat link into a dropdown? e.g. Astrigation (Int ▼)

The ask was for the ability to change the characteristics in the die roller dialog NOT change the right-click.  I don't want to change the right click abilities, as there are more than just an option to change the characteristic in there.
Context menus have always been a way to hide additional functionality without compromising the UI, they may not be intuitive but they have their place.

This is not going to be changed.


Call super from set_user_language

This allows reusing the existing implementation in Solidus's controller_helpers/common, which is in some ways better than the implementation here.
This also removes the prepend_before_action, since it is already added as a before_action in Solidus itself.

@tvdeyen what's your concern with Solidus < 1.3?

@kennyadsl it breaks for Soliuds < 1.3 because it does not have set_user_language defined.

it looks like it does, maybe it's loaded in a different way?

Got it, in 1.2 those methods were inside the include block and this commit fixed the issue. Thinking on a way to support it...

I don’t think it’s worth to support Solidus < 1.3. It will reach end of life soon and for users of old versions of Solidus there are still older version of this gem.

Closed by  #2626 :tada: :tada: :tada: :tada: :tada:


Dependency updates (test, pedantic and analyzer)

Not much in this PR really, I was just annoyed at being stuck at analyzer 2.3.0 because glados depended on it.

And not to mention the old version of test

Also note that this breaks compatibility with Flutter <2.9.0

Sorry for the late response, I was a bit busy with studying and now Christmas preparations.
The package is published as 1.1.2. Again, thank you very much for contributing!


Upgrade JS dependencies

Fix a bunch of depedencies pointed out by dependabot

@dcermak can this one be merged ?


Simply doesn't work in VS Code 1.5.3

hello, please try update to latest vs code things should be ok there.

I am now on version 1.6.0 and is still doesn't work.
Is there any additional configuration I need to make this work?
Does the file I am working in need to be a particular extension (I am working with react .jsx files)?

hello,
yes currently this extention works on html and php files only, I will try add the support for jsx tonight or this weekend if i can.

Thanks a lot! this is pretty nice of you. While you are at it, could you also add support for .js files as well?
Sometimes you need to generate html elements from your .js files.
Again, thank you very much, I really appreciate it!

Hey @abusaidm
I looked into it.
Adding these lines to package.json should do the trick.
{
  "language": "javascript",
  "path": "./snippets/snippets.json"
},
{
  "language": "javascriptreact",
  "path": "./snippets/snippets.json"
}

Thanks @faabiopontes I forgot to come back and add the js and react ones like @djihbril asked.
all added and published in version 0.0.18
Thanks for your help.
If you find any other issue please let me know and will do my best to resolve it

Thanks guys. Works like a charm.
👍 👍 for the prompt responses!


cip: Conviction Voting Template

cip: <to be assigned>
title: Conviction Voting Template
author: Joel Thorstensson (@oed)
discussions-to: <URL of the Github issue for this CIP (if this is a PR)>
status: Idea
category: Standards
type: RFC
created: 2021-02-28

This is still a work in progress. Will add more context to these schemas!

Simple Summary
This CIP describes a template that can be used to create off-chain conviction voting dapps.
Abstract

Abstract goes here.
Motivation

Fix me :)
Specification
Definition content
Deployment: Deploy your own.
{
  "name": "Conviction Voting Dapp",
  "description": "Voting data for my dapp",
  "schema": "<convictions-schema-docid>",
  "config": {
    "context": "<caip19-asset-id>"
  }
}

Proposal Schema
Deployment: <proposal-schema-docid>
{
  "$schema": "http://json-schema.org/draft-07/schema#",
  "type": "object",
  "title": "Convictions",
  "properties": {
    "context": {
      "type": "string"
    },
    "title": {
      "type": "string"
    },
    "currency": {
      "type": "string"
    },
    "amount": {
      "type": "number"
    },
    "beneficiary": {
      "type": "string"
    },
    "description": {
      "type": "string"
    },
    "url": {
      "type": "string"
    }
  },
  "additionalProperties": false,
  "required": [
    "context",
    "title",
    "currency",
    "amount",
    "beneficiary",
    "url"
  ]
}

Convictions Schema
Deployment: <convictions-schema-docid>
{
  "$schema": "http://json-schema.org/draft-07/schema#",
  "type": "object",
  "title": "Convictions",
  "properties": {
    "context": {
      "type": "string"
    },
    "supply": {
      "type": "number"
    },
    "proposals": {
      "type": "array",
      "items": {
        "$ref": "#/definitions/proposals"
      }
    },
    "convictions": {
      "type": "array",
      "items": {
        "$ref": "#/definitions/convictions"
      }
    }
  },
  "additionalProperties": false,
  "required": [
    "context",
    "proposals",
    "convictions"
  ],
  "definitions": {
    "proposals": {
      "type": "string",
      "$id": "ceramic://doc",
      "$ceramicSchema": "<proposal-schema-docid>",
      "maxLength": 150
    },
    "convictions": {
      "type": "object",
      "properties": {
        "proposal": {
          "type": "string",
          "$id": "ceramic://doc",
          "$ceramicSchema": "<proposal-schema-docid>",
          "maxLength": 150
        },
        "allocation": {
          "type": "number"
        }
      },
      "required": [
        "proposal",
        "allocation"
      ]
    }
  }
}

Conviction State Schema
Deployment: <convictions-state-schema-docid>
{
  "$schema": "http://json-schema.org/draft-07/schema#",
  "type": "object",
  "title": "ConvictionState",
  "properties": {
    "context": {
      "type": "string"
    },
    "blockHeight": {
      "type": "number"
    },
    "supply": {
      "type": "number"
    },
    "participants": {
      "type": "array",
      "items": {
        "$ref": "#/definitions/participants"
      }
    },
    "proposals": {
      "type": "array",
      "items": {
        "$ref": "#/definitions/proposals"
      }
    }
  },
  "additionalProperties": false,
  "required": [
    "context",
    "supply",
    "participants",
    "proposals"
  ],
  "definitions": {
    "participants": {
      "type": "object",
      "properties": {
        "account": {
          "type": "string"
        },
        "balance": {
          "type": "number"
        },
        "convictions": {
          "type": "string",
          "$id": "ceramic://doc",
          "$ceramicSchema": "<convictions-schema-docid>",
          "maxLength": 150
        }
      },
      "required": [
        "account",
        "balance",
        "convictions"
      ]
    },
    "proposals": {
      "type": "object",
      "properties": {
        "proposal": {
          "type": "string",
          "$id": "ceramic://doc",
          "$ceramicSchema": "<proposal-schema-docid>",
          "maxLength": 150
        },
        "totalConviction": {
          "type": "number"
        },
        "triggered": {
          "type": "boolean"
        }
      },
      "required": [
        "proposal",
        "totalConviction",
        "triggered"
      ]
    }
  }
}

Rationale

Fix me :)
Backwards Compatibility
N/A
Implementation

Fix me :)
Security Considerations

Security considerations go here.
Copyright
Copyright and related rights waived via CC0.

Check out the thoughts here, and in the other issues... lots of good debates around UX
https://github.com/1Hive/conviction-voting-app/issues/52

Awesome that you are pushing the UX work needed to make CV usable @GriffGreen 🙌
This CIP is mostly aimed at creating a solid data data layer for CV. If we manage to do this there could potentially be multiple different frontends that display the CV data in different ways based on preference / usability considerations.

@oed what do you think about adding a blockNumber or blockHeight parameter to the root of the state document? I think it'd be a great way to make all the data in state completely verifiable, since one could then verify all the other data at the prescribed block height.
"blockHeight": {
  "type": "number"
}

@topocount Yeah, that's a good addition. You could a rough idea of when the snapshot was made from the subsequent anchor commit, but it wouldn't be precise. Updating the first post!

@oed what do you think about adding a blockNumber or blockHeight parameter to the root of the state document? I think it'd be a great way to make all the data in state completely verifiable, since one could then verify all the other data at the prescribed block height.
"blockHeight": {
  "type": "number"
}

@oed Could this cause any issues like we've been seeing with the blockNumber in anchor commits, where it could diverge from the on-chain state if there's a block reorg?

@stbrody no this is more about when the conviction computation service sampled the data from the blockchain. Which is mostly independent from anchor commits.

Currently there is a beneficiary and amount which indicates there is a transfer function call to a contract from the Oracle.
Why not use an array of actions for all the contract methods to be triggered if the proposal succeeds?
actions: [{
    contract: "contract-address",
    method: "mint",
    args: ["to-address", "amount"]
}, {
    contract: "another-address",
    method: "transfer",
    args: ["to-address", "amount"]
}]


Need to catch up docs for functions/sink/source in Admin CLI

Describe the bug
Some of the subcommands of functions/sink/source are not documented in Pulsar admin CLI, such as sink/source status. We need update the doc to catch up the work.

@murong00 thanks for submitting this issue.  This is something that needs work.  Are you going to add the needed documentation?


Docstrings for client update

Add docstrings for the updated python client.
Review, please.

Codecov Report

:exclamation: No coverage uploaded for pull request base (sc1467-1@49c7556).

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 49c7556...161efc6. Read the comment docs.

@chekunkov I've updated the changes, if you have some time - could you take a another quick look on it if there're any major issues with the docstrings? It's much more Sphinx/RST compatible now, but I'm afraid it will require some additional time to polish it and fix minor formatting issues (in a separate PR).

@vshlapakov feel free to merge, we will improve the docs later as a part of RTD ticket


function signature mismatch - ubuntu - html5 export

Godot version:
3.2.4 rc3
https://downloads.tuxfamily.org/godotengine/3.2.4/rc3/
OS/device including version:

Issue description:
HTML5 export does not work. Browser shows:
alert and function signature mismatch error message
f12:
exception thrown: RuntimeError: function signature mismatch,RuntimeError: function signature mismatch
at godot_js_main(int, char**) (:wasm-function[11275]:0x21c48e)
at main (:wasm-function[23592]:0x589d14)
at Module._main (http://localhost:8060/tmp_js_export.js:9:329687)
at Object.callMain (http://localhost:8060/tmp_js_export.js:9:334793)
at http://localhost:8060/tmp_js_export.js:402:26
at new Promise ()
at http://localhost:8060/tmp_js_export.js:397:12
EngineConfig.onPrintError @ tmp_js_export.js:215
tmp_js_export.html:212 function signature mismatch
displayFailureNotice @ tmp_js_export.html:212
Steps to reproduce:
Export any project, add html5 export, select quick run. (firefox, brave browsers replicate the issue.)
Export was fine with 3.2.4 rc2
Minimal reproduction project:
html5.zip

Duplicate of https://github.com/godotengine/godot/issues/46352.


PerfKitExplorer Dashboard for every benchmark

The benchmarker can output the final results in "Text", "Json", etc.  One output it can do is to Google BigQuery.  This allows for big data mining.
To make this dashboarding on BQ easier we released a tool called PerfKitExplorer.
The work for this issue is to create a PerfKitExplorer dashboard for every benchmark.
Side note -  the explorer is extensible so we could just as easily export to MySQL and create a MySQL widget for the Explorer to analyze results.  We just have not done that work yet.

Widget extensibility isn't so much a "feature" right now as a "plan".  The next release (v23) in addition to a significant overhaul of the sidebar UX, will better factor the code to support different types of widgets.  If I we wanted a "quick and dirty" solution, it would be to add the REST URL to the widget/data config.
Realistically, we're looking at having support (and tutorials/documentation) for custom widgets in the Q2/Q3 timeframe.

I've retargeted this to v0.19.0 since the corresponding pull request #332 is still open and no longer targeting the current milestone. If it's ready now, let me know and we can see if we can still get it in v0.18.0.

@yuyantingzero  Release v0.19.0 is starting - should this get pushed further back, or will it be ready?

I will push it further back. Actually, this will be checked into PerfKitExplorer as discussed offline.

This was moved to PerfKitExplorer.


Ignore lateinitialize for owner field in group resource

Description of your changes
This PR ignores late-initialize for owner field in group resource to avoid
I have:

[x] Read and followed Crossplane's contribution process.
[x] Run make reviewable to ensure this PR is ready for review.
[ ] ~Added backport release-x.y labels to auto-backport this PR if necessary.~

How has this code been tested

/test-examples="examples/groups/v1beta1/group.yaml"

/test-examples="examples/groups/v1beta2/group.yaml"


Minecarts are invisible or incomplete (incomplete train)

Info
Please provide the following information:
Train_Carts: v1.17.1-v1 (build: 941)
BKCommonLib: v1.17.1-v3 (build: 1117)
Server: 3242-Spigot-6c1c1b2-d3cc412 (MC: 1.17.1)

Bug
Minecarts are invisible or incomplete (incomplete train)
Description
I have a problem with the Minecarts, I have made public transport on the server using the TrainCarts plugin, I have of course set that Minecarts are chunkloaders, it happens to me quite often that the train, I mean the whole train set, that the train is not visible, is invisible, I know by sound effects that when the train stops ringing. I also observe that some trains are sometimes half as long when they are not exactly invisible ... I tried to update Spigot to the latest build using buildtools, I also have the TrainCarts plugin for the current version, as well as the BKCommonLib plugin, could anyone help me please?
Expected behaviour
So that the train sets are visible and not incomplete
Actual behaviour
The trainsets are invisible or incomplete
Steps to reproduce
I don't know, I need help...
Additional Information
No additional information...

Its quite possible this commit https://github.com/bergerhealer/BKCommonLib/commit/c742f3ea90d96f27feac8ff17fee10ce7931b6b6 already fixed this issue, can you check if you still have this problem on dev? I would expect errors in the server log about addEntity failing.
https://ci.mg-dev.eu/job/BKCommonLib/1124/

Okay, now I will try update it to the DEV version and I'll see if the problem is solved, or I'll provide the log...

Great, everything works as it should, thank you! :-)


Allow to specify bucket override

Allow user to specify bucket option, which will override a default one, specified in the config.
  has_attached_file :dl_photo,
    bucket: 'validations',
    path: '/dl/:spree_user_id.:extension',

addresses https://github.com/alextsui05/paperclip-backblaze/issues/5

@andrewshatnyy Thanks for the PR. I'll merge this by the end of today.

Thanks, man.


Using cssnext inside browsers

Hi! First of all, thanks for all the job here :)
I'm trying to run postcss inside the browser to make some kind of Codepen for CSS. After bundling with Webpack, postcss and some plugins are working as expected. However, when including postcss-cssnext it crashes. After some debugging, I've found that the reason is the require statements in https://github.com/MoOx/postcss-cssnext/blob/master/src/features.js
These are "dynamic" requires inside functions. I understand the reasoning behind it for Node environments but, when trying to bundle this library with Webpack, these dependencies are not found (they are not bundled). On top of that, this file mixes ES Modules (import/export) with CommonJS (require/module), which I believe is not a very good practice. I've tried hoisting these dependencies manually and everything works correctly again.
Do you think we can modify this file or provide an alternative solution for browsers? Or perhaps, do you know any option in Webpack to force bundling these dynamic dependencies? I've been checking but couldn't find anything.
Apart from this, there's a warning that might be related to browserslist:  ./node_modules/browserslist/index.js 781:20-33 Critical dependency: the request of a dependency is an expression. Any idea?
Thanks!

Not sure what to say here as we don't have any problem on running cssnext in a browser. See http://cssnext.io/playground/.

@MoOx I've been checking this again and I'm getting more and more confused :sweat:
Importing cssnext from a cloned repo works fine, but the one I install with npm crashes: TypeError: __webpack_require__(...) is not a function     at Object.fontFamilySystemUi (features.js?4c1b:96)
If I replace node_modules/postcss-cssnext/node_modules with the cloned repo's node_modules it works again (the first one is flattened by npm).
At this point, I don't know if it's a problem in the node_modules structure or a misconfiguration in Webpack (the one I have is quite generic, though). However, making the change I mentioned in the first post fixes everything. If you want to make this change 74a37a2a921ce19cb1496f3738c6d272e6a25589 (passes all tests and the website and playground work well), I can make a PR. Otherwise, feel free to close this issue :+1:

the idea of using require is to lazy load in memory all plugin, which especially make sense if not user (per config or browserlist). So I am not a fan of making this change. I am sure you probably have a config issue. Especially when I see __webpack_require__(...) is not a function. You should maybe check the loader user for cssnext code (src or lib?) and the webpack version used.

I'm using Webpack 3.x. Looks like the problem is the combination of ESM and CJS. postcss-font-family-system-ui uses export default for module environments, so the require('postcss-font-family-system-ui') in postcss-cssnext gets { default: function() {...} } instead of the actual function (at least in my webpack environment).
For the record, this is the minimum fix that I've come up with:
// webpack.config.js

...
resolve: {
  alias: {
    'postcss-font-family-system-ui$': './pffsu-monkeypatch.js'
  }
}

// pffsu-monkeypatch.js

module.exports = require('postcss-font-family-system-ui/src/main.js').default;

@MoOx  Thanks for your time!

Alternatively, you might be interested by https://github.com/59naga/babel-plugin-add-module-exports
Not sure why we don't have this issue in our repo for the website

I built a stupid monkey patch to get this working with browserify: here's postcss-font-family-system-ui as a CommonJS module: https://github.com/RyanZim/postcss-font-family-system-ui-commonjs
Used by my WIP repl for postcss: https://github.com/RyanZim/postcss-repl

@MoOx No idea, perhaps babel-node has something to do. I've already checked that plugin today but unfortunately it doesn't work with babel-preset-env.

@RyanZim I'm glad I'm not the only one struggling with this :sweat_smile:
I wish I found that earlier but now my simple monkeypatch works well in Webpack. It simply redirects to the default property of the imported object.


Protein Family sorter is not loading any families

I created a genome group, clicked on it when deploying the PFS

This is what returned

I created a group with the same two genomes and it worked for me!

Cleared cache and it worked


[FR]: Support timeout option

What is the current behavior?
Currently there is no timeout attribute on this rule. Internally, we have some references to rules_nodejs jest_test we wrote that supports passing the timeout attribute to the rule https://bazel.build/reference/be/common-definitions#test.timeout. This is particularly useful for longer running targets until we migrate them to be smaller. Having this would ease our migration path
Describe the feature
Given a jest_test rule, take an attribute called timeout that passes along the values described here https://bazel.build/reference/be/common-definitions#test.timeout
Fund our work

[ ] Sponsor our open source work by donating a feature bounty

okay I pushed another commit to that branch, it's only reproducible with snapshots enabled.


[DRAFT/Dashboard] Improvements in SMP-spec.io/dashboard

Description
This Draft PR tracks the progress towards moving to smp-dashboard profile.
This PR fixes #
Notes for Reviewers
Signed commits

[x] Yes, I signed my commits.

@asubedy a conflict here..

Uh-oh, merge conflict.

@Abhishek-kumar09 use a combination of blonde and saffron to indicate active vs non-active, if you would.
Please drop the margin between the two buttons and the bottom border radius. Disallow the two buttons from row-wrapping (keep them on the same row).
These buttons are functioning as a tabbed menu. Even though they are not technically that, let's style them as so given that they are functioning as so.


Change the region name for Pakistan

Currently, it shows Pakistan's flag along with the name "South Asia U.S. Dollar".
I believe a better way to show it would be to show Pakistan's flag along with name "Pakistan - U.S. Dollar".
Thanks.

Pakistan is one of the regions that is used for South Asia by Steam. Same deal with CIS countries.


[Proposal] Allow Gate to explicitly deny/allow abilities to guests

Currently, the Gate immediately denies abilities if there is no authenticated user.  There are likely many instances where this is a good default, but there are likely a great number of scenarios where developers would like the option to handle guests.
Yes, it is more than likely possible to write a custom Gate and include this logic, but I feel like it is at least worth discussing to see if this functionality should be included by default in Laravel.

You can pass anything into forUser method.

@rkgrep but the subsequent allows(...) call would still try to resolve  the user.
i'm sure there are ways this can be achieved via hacking.  the spirit of the proposal was to make this a default functionality.

allows uses internal resolver, which is overwritten with forUser call.
app(Gate::class)->define('something', function ($user) {
    if ($user == 'guest') do_something();
});
app(Gate::class)->forUser('guest')->allows('something');

As for me - it is quite handy to use class hinting in policies and closures. With your proposal it will be impossible as anything could be passed as user variable.
While implicitly calling forUser allows to prevent unexpected variables passed.

I agree with @jwalton512, I personally find it somewhat cumbersome that the documentation mentions that I can use the Gate facade to have my policy applied, but in reality if there is no logged-in user then my policy will be skipped completely. The workaround I have is to just call the policy directly:
$user = Auth::user()
if (!policy($myClassInstance)->show($user, $myClassInstance)){
    abort(403);
}

We're open to PRs, but don't process proposal issues.

@GrahamCampbell, happy to write a PR, but what is the point if it's not something @taylorotwell would be interested in having in the framework.
In fact, @taylorotwell mentioned in a recent Laravel podcast episode that he felt like it wasted the dev's time to create a PR when it wasn't going to be accepted.

Feel free to discuss on slack. That's where proposals can be discussed first. ;)

@jwalton512 Did you follow  up you suggestion? Any news?

@JamesGuthrie How thats a workaround. For guest users it raise an exception:
Type error: Argument 1 passed to App\Policies\FooPolicy::show() must be an instance of App\Models\User, null given

Did anyone ever discuss this? The Slack archives don't go very far.
I'm be willing to contribute a PR on it. I was thinking something paralleling Validator::extendImplicit where there's a special function (Gate::defineImplicit?)  for defining abilities that still run when the user resolves to falsy. That way the behavior for normal rule definitions remains intact.
Feel free to get at me on the Larachat under the same username.

@tdhsmith  Currently I use the following for checking Guest permissions in actions:
  public function certify($ability, $arguments = [])
  {
    if (auth()->user()) {
      return $this->authorize($ability, $arguments);
    }
    $result = Gate::forUser(new User)->allows($ability, $arguments);

    return $result ? $this->allow() : $this->deny();

  }

Yes, but I think that's better contained within the ability's definition. Plus, calling forUser un-constrains the kinds of $user arguments the callback gets. It would be safer (in a code maintenance/readability sense) to only change the behavior of the user resolver when the ability says it's ok.
Also FYI, you can use $this->authorizeForUser($user, $ability, $arguments) instead of Gate::forUser($user)->allows($ability, $arguments) if you want your calls to look similar / both be sourced from AuthorizesRequests.

@tdhsmith, yes, it can be conciser.
  /**
   * Authorizes a given action for a guest.
   * @param       $ability
   * @param array $arguments
   * @return \Illuminate\Auth\Access\Response|void
   */
  public function certify($ability, $arguments = [])
  {
    if (auth()->user()) {
      return $this->authorize($ability, $arguments);
    }

    return $this->authorizeForUser(new User, $ability, $arguments);
  }

Use the NullObject pattern and set a Guest extends User from the Authenticate middleware if the user is not authenticated:
# Http/Middleware/Authenticate
protected function authenticate(array $guards)
{
    if (empty($guards)) {
        return $this->auth->authenticate();
    }

    foreach ($guards as $guard) {
        if ($this->auth->guard($guard)->check()) {
            return $this->auth->shouldUse($guard);
        }
    }

    $this->auth->setUser(new Guest());
}

In your Roles you can then check $user instanceof Guest

A simpler way:
Put this somewhere, perhaps in AuthServiceProvider boot()
if(!Auth::check()) {
    $userClass = config('auth.providers.users.model');
    Auth::setUser(new $userClass());
}

Then in your policy check for guest by doing:
if (is_null($user->getKey())) {
    // guest
}

Implemented here https://github.com/laravel/framework/pull/16239 :+1:

@mmghv thanks, just to let you know in my particular case I require the policy method to still be called when it's a guest.

@malhal That's what the PR allows you to do, You add the ability name in the allowGuest attribute in the policy and it will be called for guests.

@mmghv ah sorry I misread it, all good then!

Who wants this PR to be merged please review and approve or give a thumb-up on the PR because there's a possibility that Taylor may reject it, Thanks :)


Memory Leak Event Emitters: when using evaluate

Hi Nightmare Team
I know there has been an issue submitted 3 weeks ago:
https://github.com/atom/electron/issues/3244
However, I want to contribute to this issue that nightmare's evaluate function could be the potential source of this problem..

Test

// with evaluate -> Memory Leak after the 10nth loop
function *start() {
var nightmare = new Nightmare({ show: true });
for (var i = 0; i < links.length; i++) {
var title = yield nightmare.goto(links[i]).evaluate(_extractTitle);
console.log(links[i], title);
}
yield nightmare.end();
}

Test

// no evaluate -> everything runs fine!
function *start() {
var nightmare = new Nightmare({ show: true });
for (var i = 0; i < links.length; i++) {
var title = yield nightmare.goto(links[i]);
console.log(links[i], title);
}
yield nightmare.end();
}
Node version: 4.2.2
Nightmare version: 2.14.7
I hope I could contribute to this issue to help you to fix it more faster.
Screenshot of the full code and output included!
Question: Do you guys work on this issue already?
Cheers
R.

This is a nightmare issue, please file it on the appropriate repo


Added a list of common pitfalls that for new developers

In my experience, there are several common assumptions make about the Vulkan
API that aren't true. This is a short list of them, explaining how and why
one might reach that conclusion and why it isn't true or is unhelpful.

@charles-lunarg I think this all looks good to me, but want someone else at an IHV to review this as well

@sfricke-samsung After all the comments are addressed, should the commits be squashed down into 1, to better manage git history?

@charles-lunarg yes, but I know GitHub has a "Squash and Merge" option so happy to do that myself (I was planning to squash it regardless unless there was a reason to conserve the commit). You are more then welcome to squash yourself too

Ah I will leave it to you. No reason to manually do the work when a tools that does it automatically exists.

I have re-written large sections of this article to better address the mentioned issues. Hopefully it better explains the intended point.

@charles-lunarg I really like the rewrite and I think it looks good. Will wait on @Tobski 👍 and then let's get this merged in!


Checking for TypeConverter's should use TypeDescriptor.GetConverter

As per https://github.com/dotnet/runtime/issues/29823, it is no longer reliable to directly check for TypeConverterAttribute as some types are now handled intrinsically within TypeConverter.
The following code needs to utilize TypeDescriptor.GetConverter instead:
https://github.com/PowerShell/PowerShell/blob/65a3e467cc95059d16f58174335e6dd3a58c459b/src/System.Management.Automation/engine/LanguagePrimitives.cs#L1490-L1499
Related issues: #9815

@SeeminglyScience Thanks for great investigations! Do you ready to pull PR?
I found TypeConverterAttribute still in some places.

Do you ready to pull PR?

Nah you can mark this one up for grabs I think.  It should be a simple change but it will need some tests that I don't have the bandwidth for atm.

It should be a simple change

It can be not trivial. The TypeConverterAttribute  is used in PSMemberViewTypes.
@SteveL-MSFT It seems it is critical for 7.0.

@iSazonov we'd need to test to be sure, but from the referenced .NET Core issue it seems .NET Core team are saying that we should not need to be checking directly for TypeConverterAttribute, and that the TypeDescriptor.GetConverter method(s) will check that as well as the various other methods of registering type converters.

TypeConverterAttribute is not deprecated and we should keep current code. Also the attribute can be used in any custom code.

Now fix works. Will pull tomorrow with a test.

@iSazonov given the changes that .NET made in .NET 5, has this been fixed in 7.1? If so, can you please close it as fixed?

@joeyaiello .Net team changed the implementation some times for last 1-2 years because they want to reduce cross assembly dependencies. I think we need re-check that all converters we want to have work in current version (I think they is near RC and .Net 5 has stable package design).

@iSazonov , this seems to have been fixed by https://github.com/PowerShell/PowerShell/pull/12580?

.NET team recommended the method provided on TypeDescriptor for finding type converters... it doesn't look like that PR makes use of that?

I guess .Net now stable in the area - our tests from #12580 works. But they (.Net team) do not still close/fix all related issues so it is not clear can we benefit more from .Net and improve PowerShell engine itself.
Since our tests are passed we could close the bug labeled issue as fixed and continue monitor silently.

@iSazonov Can we close this issue?

We need recheck. I did not monitor latest changes in .Net.