Enable passthrough of DeepLC options in fasta2speclib

To enable DeepLC calibration and other DeepLC options in fasta2speclib, the fasta2speclib config (from json file) should be passed to the ms2pip.retention_time module:
Replace this line:
https://github.com/compomics/ms2pip_c/blob/2e0c2af34d9d81317a5313b837d9d4111a96981f/fasta2speclib/fasta2speclib.py#L342
With
        rt_predictor = RetentionTime(config=params)

This makes it possible to add a deeplc entry to the fasta2speclib config file:
{
    ...
    "elude_model_file":null,
    "rt_predictions_file":null,
    "add_retention_time":true,
    "deeplc": {
        "calibration_file": "/path/to/deeplc/peptide/file.csv"
    }
}

Other options under “deeplc" could be any option from the DeepLC API.

Was already fixed in #135.


Is it okay to use a backup email address to use for succession?

I've been trying to get my account up and running successfully but I don't know how to get past name not resolved. How do I get past it.

Why:
Closes [issue link]

What's being changed:

Check off the following:

[ ] I have reviewed my changes in staging (look for the deploy-to-heroku link in your pull request, then click View deployment).
[ ] For content changes, I have completed the self-review checklist.

Writer impact (This section is for GitHub staff members only):

[ ] This pull request impacts the contribution experience

[ ] I have added the 'writer impact' label
[ ] I have added a description and/or a video demo of the changes below (e.g. a "before and after video")

Thank you for your pull request. We are unable to accept your change at this time


Private expression-bodied read-only properties should be ignored

Hi,
I'm currently encountering an issue with a generated OpenAPI schema that seems to be related on how properties are filtered by the SystemTextJsonReflectionService implementations.
public class TestClass
{
    private string Prop1 { get; set; }

    private string Prop2 { get; } = "Hello";

    private string Prop3 => "Hello";
}

Both Prop2 and Prop3 are not filtered because they don't have a setter.


CU-86azyk87x - Add field 'shipstation_store_id' to Spree::Store model…

…, add data migration to pre-populate it with correct values.. use these values instead of 'Spree::Store#id' in shipment serializers

Task linked: CU-86azyk87x Add field 'shipstation_store_id' to Spree::Store model, add data migration to pre-populate it with correct values.. use these values instead of 'Spree::Store#id' in shipment serializers


Add Linter rules

Like my other projects, I want to add Linter rules. That helps for having consistency in the code and avoid bad practices.
For an example of rules, see https://github.com/renaudjenny/SwiftClockUI/blob/master/Sources/.swiftlint.yml

fixed with e01f19b


In some cases resizing class is not removed from GridItem element after onResizeStop event

Describe the bug
In some cases resizing class is not removed from GridItem element after onResizeStop event
Your Example Website or App
https://react-grid-layout.github.io/react-grid-layout/examples/1-basic.html
Steps to Reproduce the Bug or Issue

Go to https://react-grid-layout.github.io/react-grid-layout/examples/1-basic.html
Start resize some grid item and than return it to initial state
See in devtools resizing class is not removed after resize stop event

Expected behavior
resizing class is removed after resize stop event
react-grid-layout library version
1.3.4
Operating System Version
Windows
Browser
Chrome
Additional context
No response
Screenshots or Videos

https://user-images.githubusercontent.com/18212010/164425918-74580d0e-514e-447d-b9cc-1aa8c4b5e53d.mp4

It's 2 years too late but I managed to find a workaround.
Create a state that will manage which item is being resized. It can be a local or a global state depending on your use case.
Create 2 function like so:
  const startResize = useCallback(layout, oldItem, newItem) => { // You can also use oldItem
    setIsResizingItem(newItem);
    // or setIsResizing(newItem.i);
  }, []);

  const stopResize = useCallback(() => {
    setIsResizingItem(null);
  }, []);

Then, put them in your ReactGridLayout component
onResizeStart={startResize}
onResizeStop={stopResize}

On your items, consume the aforementioned state to check if the current item is resizing:
const isResizing = useMemo(
  () => equals(id, isResizingItem.i),
  [isResizingItem, id]
);

Finally, sanitize the className provided by React Grid Layout:
const sanitizedReactGridLayoutClassName = useMemo(
  () => (isResizing ? className : className?.replace(' resizing ', '')),
  [className, isResizing]
);


Scheduler for Awake

Description of the new feature / enhancement
Keep awake during time interval
It would be nice to have a feature where i can leave the awake functionality ON during working hours and ignore the settings during non-working hours. Schedule the awake window.
Scenario when this would be used?
It would be nice to have a feature where i can leave the awake functionality ON during working hours and ignore the settings during non-working hours. Schedule the awake window.
Supporting information
No response

/dup #27790


How to set vertical div for each section

Hi
I've config, and that's ok. But I have some proble. I want set  vertical align center for each section
I've attach file, so you can see, more blank on bottom page, so if I can set vertical, it's very wonderful

tks

This is not an issue that relates to Scrollify. You should post your question on stackoverflow.com.


Translate docs/alerts/_index.md into Korean

What type of PR is this?
/kind content
/kind translation
Any specific area of the project related to this PR?
/area documentation
What this PR does / why we need it:
Translate Translate docs/alerts into Korean
Which issue(s) this PR fixes:
Fixes #https://github.com/falcosecurity/falco-website/issues/805#issue-1573521157
Special notes for your reviewer:
@vjjmiras

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: Virusuki
Once this PR has been reviewed and has the lgtm label, please assign vjjmiras for approval by writing /assign @vjjmiras in a comment. For more information see the Kubernetes Code Review Process.
The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

content/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Thanks for your pull request. Before we can look at it, you'll need to add a 'DCO signoff' to your commits.
:memo: Please follow instructions in the contributing guide to update your commits with the DCO
Full details of the Developer Certificate of Origin can be found at developercertificate.org.
The list of commits missing DCO signoff:

12a29c8 Translate docs/alerts/_index.md into Korean

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Thanks for your pull request. Before we can look at it, you'll need to add a 'DCO signoff' to your commits.
:memo: Please follow instructions in the contributing guide to update your commits with the DCO
Full details of the Developer Certificate of Origin can be found at developercertificate.org.
The list of commits missing DCO signoff:

12a29c8 Translate docs/alerts/_index.md into Korean

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Thanks for your pull request. Before we can look at it, you'll need to add a 'DCO signoff' to your commits.
:memo: Please follow instructions in the contributing guide to update your commits with the DCO
Full details of the Developer Certificate of Origin can be found at developercertificate.org.
The list of commits missing DCO signoff:

12a29c8 Translate docs/alerts/_index.md into Korean

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Thanks for your pull request. Before we can look at it, you'll need to add a 'DCO signoff' to your commits.
:memo: Please follow instructions in the contributing guide to update your commits with the DCO
Full details of the Developer Certificate of Origin can be found at developercertificate.org.
The list of commits missing DCO signoff:

12a29c8 Translate docs/alerts/_index.md into Korean

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Thanks for your pull request. Before we can look at it, you'll need to add a 'DCO signoff' to your commits.
:memo: Please follow instructions in the contributing guide to update your commits with the DCO
Full details of the Developer Certificate of Origin can be found at developercertificate.org.
The list of commits missing DCO signoff:

12a29c8 Translate docs/alerts/_index.md into Korean

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Thanks for your pull request. Before we can look at it, you'll need to add a 'DCO signoff' to your commits.
:memo: Please follow instructions in the contributing guide to update your commits with the DCO
Full details of the Developer Certificate of Origin can be found at developercertificate.org.
The list of commits missing DCO signoff:

12a29c8 Translate docs/alerts/_index.md into Korean

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: Virusuki
Once this PR has been reviewed and has the lgtm label, please ask for approval from vjjmiras by writing /assign @vjjmiras in a comment. For more information see the Kubernetes Code Review Process.
The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

content/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Thank you @Virusuki, it's a great contribution!
/LGTM

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: Virusuki, vjjmiras
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

content/OWNERS [vjjmiras]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

LGTM label has been added.  Git tree hash: 7fc0efee8985dffd78cdc834403853315def54d3

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: Virusuki, vjjmiras
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

content/OWNERS [vjjmiras]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


Reading 8 Ists & Coils and writing multiple register bug fix

I found some bugs in the library. You reading Ists and Coils for 8 registers, the 8th register will always be 0. Also, when we write multiple holding registers, the last value will be lost.
I have fix the bug in my local copy. I want to submit the bug but I do not know how.

you can fork the repo, commit your changes and pull request. or you can attach your update here, i'll try to make pull request to make this library better

I am also seeing this same issue - every 8th coil is not working.
Umarsaid, is there any way at all for you to post or forward me the updated library you mention that you fixed?  My programming skills are still improving and I'm having trouble reading through the library to identify where the issue is.  Thank you very much in advance for your help!!!!

Please would you change these lines 329 and 380 in modbus.cpp
from
	while (numregs--) {         i = (totregs - numregs) / 8;
to
	while (numregs) {         i = (totregs - numregs) / 8;         numregs--;
by my findings only this decrement order need to be changed.

Thank you!!!!  I will try this as soon as I can, hopefully later today.  I’ve spent hours trying to study the library but it is clearly above my skill.  This will help me tremendously!
I’ll email back as soon as I confirm this is OK.  Thank you very much for your help!
Best regards,
-Richard White
From: petersoltys<EMAIL_ADDRESS>Sent: Thursday, February 14, 2019 9:47 PM
To: andresarmento/modbus-arduino<EMAIL_ADDRESS>Cc: WHITE, RICHARD D. [AG/2563]<EMAIL_ADDRESS>Comment<EMAIL_ADDRESS>Subject: Re: [andresarmento/modbus-arduino] Reading 8 Ists & Coils and writing multiple register bug fix (#35)
Please would you change these lines 329 and 380 in modbus.cpphttps://github.com/andresarmento/modbus-arduino/blob/master/libraries/Modbus/Modbus.cpp
from
while (numregs--) { i = (totregs - numregs) / 8;
to
while (numregs) { i = (totregs - numregs) / 8; numregs--;
by my findings only this decrement order need to be changed.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHubhttps://github.com/andresarmento/modbus-arduino/issues/35#issuecomment-463940551, or mute the threadhttps://github.com/notifications/unsubscribe-auth/Ak6L_aYurmh2M668cxabL_tGN284DIVaks5vNmXvgaJpZM4Siuvn.
This system contains confidential and copyrighted information.  Access to the system is limited to users only and only for approved business purposes.
Anyone obtaining access to and using this system acknowledges that all information on this system including but not limited to electronic mail, word processing, directories and files, constitutes private property belonging to the Company.
Anyone using of viewing this system is further advised that the use of this system may be recorded and the information contained herein may be monitored, retrieved and reviewed if, in the Company’s sole discretion there is a business reason to do so.
If improper activity or use is suspected, all available information may be used by the Company for possible disciplinary action, prosecution, civil claim or any remedy or lawful purpose.

Peter - THANK YOU - I tried this and it looks like it works!  I am very grateful for your help.  This is definitely something very important to my projects.   I really appreciate this!

Thank you Peter !!
I met the same issue with the writeMultipleCoils function.
I did the same change at line 499 with numoutputs and it works now.
while (numoutputs) { i = (totoutputs - numoutputs) / 8; numoutputs--;

Thank you Peter !!
I met the same issue with the writeMultipleCoils function.
I did the same change at line 499 with numoutputs and it works now.
while (numoutputs) { i = (totoutputs - numoutputs) / 8; numoutputs--;

Thank you, you are the best

Please would you change these lines 329 and 380 in modbus.cpp
from
	while (numregs--) { i = (totregs - numregs) / 8;
to
	while (numregs) { i = (totregs - numregs) / 8; numregs--;
by my findings only this decrement order need to be changed.

Thank you, you are the best


chore: reduce one Option match for elements in object pool

Signed-off-by: Andy Lok<EMAIL_ADDRESS>

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

45 of 46 (97.83%)  changed or added relevant lines in 5 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.08%) to 83.216%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

minitrace/src/util/object_pool.rs
11
12
91.67%

Totals

Change from base Build<PHONE_NUMBER>:
0.08%

Covered Lines:
1661

Relevant Lines:
1996

💛  - Coveralls


undefined method `[]' for nil:NilClass

Hi,
We're experiencing a Warden compatibility issue upgrading a Grape app from 0.11.0 to 0.13.0.
When we attempt to access a URL which requires authentication we get this trace:
NoMethodError: undefined method `[]' for nil:NilClass
        /Users/matt/.rbenv/versions/2.2.2/lib/ruby/gems/2.2.0/gems/rack-mount-0.8.3/lib/rack/mount/route_set.rb:154:in `block in call'
        /Users/matt/.rbenv/versions/2.2.2/lib/ruby/gems/2.2.0/gems/rack-mount-0.8.3/lib/rack/mount/code_generation.rb:96:in `block in recognize'
        /Users/matt/.rbenv/versions/2.2.2/lib/ruby/gems/2.2.0/gems/rack-mount-0.8.3/lib/rack/mount/code_generation.rb:75:in `optimized_each'
        /Users/matt/.rbenv/versions/2.2.2/lib/ruby/gems/2.2.0/gems/rack-mount-0.8.3/lib/rack/mount/code_generation.rb:95:in `recognize'
        /Users/matt/.rbenv/versions/2.2.2/lib/ruby/gems/2.2.0/gems/rack-mount-0.8.3/lib/rack/mount/route_set.rb:141:in `call'
        /Users/matt/.rbenv/versions/2.2.2/lib/ruby/gems/2.2.0/gems/grape-0.13.0/lib/grape/api.rb:114:in `call'
        /Users/matt/.rbenv/versions/2.2.2/lib/ruby/gems/2.2.0/gems/grape-0.13.0/lib/grape/api.rb:44:in `call!'
        /Users/matt/.rbenv/versions/2.2.2/lib/ruby/gems/2.2.0/gems/grape-0.13.0/lib/grape/api.rb:39:in `call'
        /Users/matt/.rbenv/versions/2.2.2/lib/ruby/gems/2.2.0/gems/rack-1.6.4/lib/rack/urlmap.rb:66:in `block in call'
        /Users/matt/.rbenv/versions/2.2.2/lib/ruby/gems/2.2.0/gems/rack-1.6.4/lib/rack/urlmap.rb:50:in `each'
        /Users/matt/.rbenv/versions/2.2.2/lib/ruby/gems/2.2.0/gems/rack-1.6.4/lib/rack/urlmap.rb:50:in `call'
        /Users/matt/.rbenv/versions/2.2.2/lib/ruby/gems/2.2.0/gems/activerecord-4.2.3/lib/active_record/connection_adapters/abstract/connection_pool.rb:653:in `call'
        /Users/matt/.rbenv/versions/2.2.2/lib/ruby/gems/2.2.0/gems/honeybadger-2.1.1/lib/honeybadger/rack/metrics_reporter.rb:17:in `call'
        /Users/matt/.rbenv/versions/2.2.2/lib/ruby/gems/2.2.0/gems/honeybadger-2.1.1/lib/honeybadger/rack/error_notifier.rb:33:in `block in call'
        /Users/matt/.rbenv/versions/2.2.2/lib/ruby/gems/2.2.0/gems/honeybadger-2.1.1/lib/honeybadger/config.rb:190:in `with_request'
        /Users/matt/.rbenv/versions/2.2.2/lib/ruby/gems/2.2.0/gems/honeybadger-2.1.1/lib/honeybadger/rack/error_notifier.rb:30:in `call'
        /Users/matt/.rbenv/versions/2.2.2/lib/ruby/gems/2.2.0/gems/rack-ssl-enforcer-0.2.9/lib/rack/ssl-enforcer.rb:57:in `call'
        /Users/matt/.rbenv/versions/2.2.2/lib/ruby/gems/2.2.0/gems/rack-1.6.4/lib/rack/tempfile_reaper.rb:15:in `call'
        /Users/matt/.rbenv/versions/2.2.2/lib/ruby/gems/2.2.0/gems/rack-1.6.4/lib/rack/lint.rb:49:in `_call'
        /Users/matt/.rbenv/versions/2.2.2/lib/ruby/gems/2.2.0/gems/rack-1.6.4/lib/rack/lint.rb:37:in `call'
        /Users/matt/.rbenv/versions/2.2.2/lib/ruby/gems/2.2.0/gems/rack-1.6.4/lib/rack/showexceptions.rb:24:in `call'
        /Users/matt/.rbenv/versions/2.2.2/lib/ruby/gems/2.2.0/gems/rack-1.6.4/lib/rack/commonlogger.rb:33:in `call'
        /Users/matt/.rbenv/versions/2.2.2/lib/ruby/gems/2.2.0/gems/sinatra-1.4.6/lib/sinatra/base.rb:218:in `call'
        /Users/matt/.rbenv/versions/2.2.2/lib/ruby/gems/2.2.0/gems/rack-1.6.4/lib/rack/chunked.rb:54:in `call'
        /Users/matt/.rbenv/versions/2.2.2/lib/ruby/gems/2.2.0/gems/rack-1.6.4/lib/rack/content_length.rb:15:in `call'
        /Users/matt/.rbenv/versions/2.2.2/lib/ruby/gems/2.2.0/gems/thin-1.6.3/lib/thin/connection.rb:86:in `block in pre_process'
        /Users/matt/.rbenv/versions/2.2.2/lib/ruby/gems/2.2.0/gems/thin-1.6.3/lib/thin/connection.rb:84:in `catch'
        /Users/matt/.rbenv/versions/2.2.2/lib/ruby/gems/2.2.0/gems/thin-1.6.3/lib/thin/connection.rb:84:in `pre_process'
        /Users/matt/.rbenv/versions/2.2.2/lib/ruby/gems/2.2.0/gems/thin-1.6.3/lib/thin/connection.rb:53:in `process'
        /Users/matt/.rbenv/versions/2.2.2/lib/ruby/gems/2.2.0/gems/thin-1.6.3/lib/thin/connection.rb:39:in `receive_data'
        /Users/matt/.rbenv/versions/2.2.2/lib/ruby/gems/2.2.0/gems/eventmachine-1.0.7/lib/eventmachine.rb:187:in `run_machine'
        /Users/matt/.rbenv/versions/2.2.2/lib/ruby/gems/2.2.0/gems/eventmachine-1.0.7/lib/eventmachine.rb:187:in `run'
        /Users/matt/.rbenv/versions/2.2.2/lib/ruby/gems/2.2.0/gems/thin-1.6.3/lib/thin/backends/base.rb:73:in `start'
        /Users/matt/.rbenv/versions/2.2.2/lib/ruby/gems/2.2.0/gems/thin-1.6.3/lib/thin/server.rb:162:in `start'
        /Users/matt/.rbenv/versions/2.2.2/lib/ruby/gems/2.2.0/gems/rack-1.6.4/lib/rack/handler/thin.rb:19:in `run'
        /Users/matt/.rbenv/versions/2.2.2/lib/ruby/gems/2.2.0/gems/rack-1.6.4/lib/rack/server.rb:286:in `start'
        /Users/matt/.rbenv/versions/2.2.2/lib/ruby/gems/2.2.0/gems/rack-1.6.4/lib/rack/server.rb:147:in `start'
        /Users/matt/.rbenv/versions/2.2.2/lib/ruby/gems/2.2.0/gems/rack-1.6.4/bin/rackup:4:in `<top (required)>'
        /Users/matt/.rbenv/versions/2.2.2/bin/rackup:23:in `load'
        /Users/matt/.rbenv/versions/2.2.2/bin/rackup:23:in `<main>'

After realising that the issue went away with authentication disabled, we did some debugging from within Warden which lead us to this code: https://github.com/hassox/warden/blob/74162f2bf896b377472b6621ed1f6b40046525f4/lib/warden/manager.rb#L27-L50
We found that with 0.11.0, running this code:
env['warden'] = Proxy.new(env, self)
@app.call(env)

at a breakpoint placed after line 30 of the above snippet, that a rack response body was returned:
=> [200,
 {"Content-Type"=>"application/json", "Content-Length"=>"14"},
 #<Rack::BodyProxy:0x007fd5fd1cf388
  @block=
   #<Proc:0x007fd5fd1cf2e8@/Users/matt/.rbenv/versions/2.2.2/lib/ruby/gems/2.2.0/gems/activerecord-4.2.3/lib/active_record/connection_adapters/abstract/connection_pool.rb:654>,
  @body=
   #<Rack::BodyProxy:0x007fd5fd1cf5e0
    @block=#<Proc:0x007fd5fd1cf518@/Users/matt/.rbenv/versions/2.2.2/lib/ruby/gems/2.2.0/gems/rack-1.6.4/lib/rack/response.rb:82>,
    @body=
     #<Rack::Response:0x007fd5fd1cf9c8
      @block=nil,
      @body=["{\"hello\":\"hi\"}"],
      @chunked=false,
      @header={"Content-Type"=>"application/json", "Content-Length"=>"14"},
      @length=14,
      @status=200,
      @writer=#<Proc:0x007fd5fd1cf798@/Users/matt/.rbenv/versions/2.2.2/lib/ruby/gems/2.2.0/gems/rack-1.6.4/lib/rack/response.rb:30 (lambda)>>,
    @closed=false>,
  @closed=false>]

After escaping from this breakpoint, the request completes successfully.
Whereas with 0.13.0, we got the following return value:
=> #<Rack::Response:0x007fa522ba30a0
 @block=nil,
 @body=["{\"hello\":\"hi\"}"],
 @chunked=false,
 @header={"Content-Type"=>"application/json", "Content-Length"=>"14"},
 @length=14,
 @status=200,
 @writer=#<Proc:0x007fa522ba2f38@/Users/matt/.rbenv/versions/2.2.2/lib/ruby/gems/2.2.0/gems/rack-1.6.4/lib/rack/response.rb:30 (lambda)>>

and on continuation, we get the trace above.
It'd be great if you could explain whether or not this is intended behaviour, and if it is, what an appropriate workaround might be from our side.
Thanks in advance for your help (and thanks for Grape too! :smiley:).

This is because Grape no longer returns an array of status code, headers and bodies, but a Rack::Response. Check the top of https://github.com/ruby-grape/grape/blob/master/UPGRADING.md, there's quite a bit of detail.
It looks like something is trying to access the response with response[1] (probably trying to get the headers), whereas the response is an object. There's definitely a workaround where you can just call to_a in a middleware but it's possible that the calling code should change - it would be much faster than having to convert these things into an array.
I'll close this, but if you can't figure out how to fix it put up a project with a repro and I'll help you out.

is there any link to issue in grape?

is there any link to issue in grape?

Not sure what you're asking for? This page is an issue in Grape that turns out to be an issue in Rack :)


simplify the way how to define logger

Currently, we need the following code to get a instance of logger:
private val logger = KotlinLogging.logger {}
the code itself is very simple, but the problem is, we have to put this line in every class which use log, and for a large project, there could be many many classes.
So I suggest we can add a new extension property, which can get the logger instance for us, and we can use this property in every classes without calling the logger initialization code.
I made a PR #78 for this, please take a look

I have a couple of concerns regarding the suggestion:

The biggest one is that add a property on all classes clutter your env (ie: it will suggest it for autocompletion in any case you included the library). I really don't like that.
probably it is better not to have synchrinze block at all (but create duplicated instances).
I don't think it will work on the file level - only inside classes?

The first one is my main concern preventing me from merging such a PR.

The biggest one is that add a property on all classes clutter your env (ie: it will suggest it for autocompletion in any case you included the library). I really don't like that for libraries, in your applicative code, it is more acceptable.

no, it will not be added to all classes.
it's an extension property, it will be available only if you import it, like import mu.log,
without this explicit import statement, this property will not be added to class.

probably it is better not to have synchronized block at all (but create duplicated instances).

OK
I think I can remove synchronized block

I don't think it will work on the file level - only inside classes?

You are right, an extension property only works for classes,
I will do more research, to see if there is anything we can do for the file level case

Regarding the import, I know it will not added to all classes unless you import. The issue is the IDE will suggest to add it and import on almost any auto-completion (because it's a public extension to all instances)

I decided not to merge such a PR at the moment. Thanks anyway!


Add status changed by user info to context

This is required to track who cancelled/paused/resumed any execution.
"context" : { "user" : "stanley", "pack" : "examples", "workflow_execution" : "61a0887aac2049b57fed57de", "paused_by" : "stanley", "resumed_by" : "stanley" }

A really helpful addition 👍
We'll need a small Changelog record for this anyway and I'm sure someone else will request unit tests as well. So adding those would be nice.

Addressed @armab


Error - Unexpected token ,,  || Error Unexpected Identifier

Finds an error after a comma, but there is nothing there.  Deleting the comma leads to an error on all but the first character of the next word.
Same with Unexpected Identifier, it's like the Linter is seeing a character which isn't actually there then throwing an error

@fergusmeiklejohn what linter are you using here?

🤷♂ We'll re-open if there's news.


could not find driver after execute composer

Hi all, I have installed phpbrew in my elementary os, but I got problem when execute composer update for my symfony app
i got this issue :
[Doctrine\DBAL\Exception\DriverException]
An exception occured in driver: could not find driver
[Doctrine\DBAL\Driver\PDOException]
could not find driver
I tried to reinstalling phpbrew phpvers +default +pdo
but it's doesn't work
I'm using php-5.4.35
Thank you.
Kahfi

you shiuld at least use +pdo +mysql

or go with +dbs if you intend to use different db drivers for multiple projects.

oh i see,
thanks it's worked
thanks all for your help.


Discussion of a few modifications

Hello,
I'm hoping to use this ticket as a platform to discuss a couple of things I have been thinking contributing with. One I have already started work on as it affects my workflow. There are also a feature request, I wanted to know if can be done.
Using default clients for variables/stacktrace
I find that the dap-setup-ui and dap-takedown-ui are perfect for customizing layouts for personal preferences. Though using the clients kakoune already provides might be best for the default behavior: toolsclient and docsclient. Kakoune and most plugins that require output use these. For example:

grep/find
documentation
linters
kak-gbdp

In my case I wrote a script that builds a sort of IDE, based on this: https://github.com/mawww/kakoune/wiki/IDE. So I have my environment setup and the three clients are always used. I have already created a local branch which:

has a boolean option that the user can set to determine if they want to use the two provided commands (false by default)
uses docsclient and toolsclient for both vars/stacktrace
for now I simply commented out takedown-ui in the general.rs (but will handle it better)

Stacktrace syntax and opening files
I think I will take the time for syntax highlighting, and the kakoune-find plugin can be used as a reference for opening the files in the jumpclient
Don't show "+" arrow on empty arrays
This is minor, if I can tackle it I will. You can see in it in the screenshot for my pull request for variable syntax hl. While testing I thought something was broken, but it was due to me clicking on the array(0) variables.
Feature request
Is it possible to toggle breakpoints after the debugging session has started?
Please let me know your thoughts. They are minor things, and I can definitely contribute on the first three -- definitely going to wrap up the first one soon and can provide a pull request. Just wanted to know your thoughts.

Hello again! I'm just going to address your points one by one.
Using default clients for variables/stacktrace - Don't submit a pull request for this. This can be handled without any changes to kak-dap. The dap-setup-ui, dap-takedown-ui, and dap-run-terminal commands are designed to be overridden for this very reason. For your use case, try putting the following commands (warning: untested) into your kakrc:
# This just sets the stacktrace and variables clients to the docs and "tools clients, respectively.
define-command -override dap-setup-ui %{
    set global stacktraceclient docsclient
    set global variablesclient toolsclient
}
# This does absolutely nothing. We want to keep the clients open for later use by other plugins.
define-command -override dap-takedown-ui %{}

More information about modifying kak-dap's layout can be found here: https://codeberg.org/jdugan6240/kak-dap/wiki/Customizing-debugger-UI.
Stacktrace syntax and opening files - If you want to submit a pull request implementing this, absolutely - go for it. That sounds legit awesome.
Don't show "+" arrow on empty arrays - I don't think this is possible, to be completely honest, and here's why.
Every variable object returned by the debug adapter has a variables_reference parameter. If this is zero, then the variable isn't expandable. If it is greater than zero, then it is expandable. This value is used by child variables to indicate which variable is its parent. This is unfortunately the only way kak-dap can know to place the + sign next to a given variable. Look through lines 104-134 of variables.rs if you want a better grasp of the overall logic.
Long story short, if the adapter is returning a variables_reference value that isn't zero for a variable that can't be expanded, that seems to be a bug with the adapter - the variables_reference value is our only clue for if a variable is expandable.
Feature request - It is indeed possible to implement this, but it is difficult due to how the DAP is designed.
Basically, when sending breakpoints to a debug adapter, you can't just set or remove a single breakpoint - you have to update all the breakpoints in any given file in a single message. This means that, whenever a breakpoint is set or removed at runtime, we would need to remember what breakpoints are associated with that file, and set or remove the breakpoint in that group of breakpoints, then send those breakpoints to the adapter all at once. It's frankly extremely over-engineered, but it's what we've got to work with.
In short, it's very possible to do this, but it's far from trivial, and the "you can't set breakpoints at runtime" restriction was just me kicking the can further down the road. I do plan to tackle this at some point, though.

@jdugan6240,
Thanks for taking your time to read my long message, hah. All sounds good. I might take a look at the breakpoint issue now that you have explained it, just out of curiosity to see if I can help out.
Regarding the default client -- I fully understand how it's currently setup, and have read the docs. I realize now that what I describe in my approach is not best. I am not suggesting to change the feature, just the default behavior.
I highly recommend DAP should use the docsclient, and toolsclients by default. This is pretty standard, I mention in the original post just a few examples of this being the case.
That being said, what I propose is changing the dap-setup-ui and dap-takedown-ui to use default clients -- and allow users to customize if they want to use custom clients -- not the other way around. Currently one has to write custom code if they want to use the default clients, which is odd to be honest. Think about it, if you use the linter, find, and grep -- and each opens their own custom client, that would be quite frustrating.
The point here is to use default clients, as many other features/plugins do -- and allow a user to customize if they want something non-standard. I hope this makes sense, don't think I am suggesting anything but following the default approach to using the tools/docs clients where possible.

I hear you regarding the default clients. I'm by no means married to the idea of custom clients for kak-dap. I personally don't use toolsclient and docsclient myself too much, and I also didn't believe docsclient in particular fit what we're trying to do here.
My main issue with this is that we shouldn't assume these clients exist if we do change to using docsclient and toolsclient (another question - which would be which?). We don't want to create a dependency on running one of the aforementioned tools to create these clients beforehand, so we may need to create them ourselves. For dap-setup-ui, if they do exist, we wouldn't want to recreate them, whereas if they don't, we would need to create them. For takedown-ui, do we want to delete these clients or leave them up?
There's also the issue of the tools you mentioned defaulting to the same client if there's only one (which I imagine is how many people use Kakoune). This would make the jumpclient and the toolsclient or docsclient the same client, which would cause issues when we need to update both in different ways.
Overall, although I get you wanting to have it work that way for your use case, making it the default raises a bunch of questions that are neatly sidestepped by using custom clients, and if the user wants to use docsclient snd toolsclient, doing so is trivial.
Not trying to be combative, by the way - just trying to explain why things are the way they are. I'm certainly open to changing this behavior - I just don't see a good reason to right now.

Hey, sorry for the very late response
What other commands/plugins do is if the clients don't exist they open on the same client. I'm guessing a use case like working on pure console, a server with limited capabilities. Opening new clients might be an issue, as to not create dependencies, or assumptions on environment.
Regarding the jump and tools client having to update both in different ways, to be honest I am unsure of the underlying behavior. But may be able to look into it to see if it's an issue... time permitting.
My use case is defined by the default behavior of Kakoune, so I don't think this would just apply to me and how I use the editor. It comes with three clients, and various tools/plugins use them. I use docs for vars, tools for stack -- basically I chose docs as I find variables to be reference to the code... but to be honest, it's just making use of what is already there and not needing to create new ones.
I have absolutely no issue using the exiting commands, but I do feel it's a little backwards to have to modify the default behavior to go along with the default clients that exist, but this is your call really :)

OK, I'm starting to understand where you're coming from, I think. Being consistent with the way other plugins work does have a certain appeal. That said, kak-dap isn't the only plugin that uses custom clients like this (kaktree being a notable example of a plugin that does this), and there is another issue, I think, with using the "default" clients:

My use case is defined by the default behavior of Kakoune, so I don't think this would just apply to me and how I use the editor. It comes with three clients, and various tools/plugins use them.

This seems to be a conflict of anecdotes - you heavily use docsclient and toolsclient, whereas I don't use them often at all (and when I do, they're the same as the main client). You don't believe you're alone, and I don't believe I'm alone. These anecdotes seem to me to cancel out, therefore.
The reason I believe the way I do about this issue is, I don't consider what you describe to be the default behavior. Kakoune does not come with three clients (the IDE script is a third party contribution to the wiki, and must be inserted into your config), and as you say, the plugins that ship with Kakoune default to using the same client when docsclient and toolsclient aren't defined (which they aren't, by default).
The big reason using a single client is problematic here is due to how the buffers are updated. kak-dap uses kak -p invocations to send commands to the correct client, which means the order in which the buffers are updated is at the mercy of the process scheduler and the behavior of Kakoune's command socket. This creates inherent unpredictability, which is avoided with multiple clients. If at all possible, we need to avoid using the same client by default, to avoid an inferior experience for users.
IMO, we simply can't make any assumptions about what environment the user is running, and whether docsclient and toolsclient actually exist. We had to default to something, and this custom clients approach seemed to be the best way to ensure basic functionality for those who just install the plugin without changing their kakrc.
Please know that I am not trying to be combative or dismissive of your suggestions - they are well appreciated and I am frankly flattered that someone found my silly experiment worth using. I simply believe that using docsclient and toolsclient by default, like other plugins do, opens a can of worms that I'd rather not open by default. The default works to varying degrees for every scenario other than a dumb terminal, and changing the default behavior is a trivial task if necessary.

If you don't mind, let's get off this tangent and start discussing some of your other suggestions. I had been thinking for a while of doing a thorough rewrite of the Rust side of kak-dap, now that I have a better understanding of how Rust works and how to architect a Rust application. This would be a great opportunity to implement setting breakpoints during debugging (I have a pretty good idea of how to approach this). There's also a memory leak regarding variables, which your comment about expanding empty arrays actually reminded me of, that I could fix as well.
This would obviously take some time, as I don't have a ton of free time. This wouldn't touch the kakscript too much, though, which would leave you free to implement the stacktrace stuff if you wish.
I would also like to direct you to pesticide, which is another DAP client designed to work with Kakoune that is in early alpha. It has a different approach to things, using a separate terminal window as the debugger window, which eliminates the clients issues we've been discussing. Some inspiration could potentially be taken from there (I'm definitely going to be borrowing ideas from the code).

Hey, sorry... I've been swamped.
Yeah, also tagbar adds a different window. I think it makes sense for these use cases. Let's just leave it at that and I'll use the recommended approach, not a big deal.
That being said I regularly use the plugin, and works well. Settings breakpoints while debugging would be great! I'm in the same boat, and my contribution here was more out of need to make reading variables/interaction a little easier. So I hope to contribute the stacktrace stuff later.
Interesting, will have to check pesticide out.
Thank again for your work!

Sorry to revive this really old discussion, but I thought you'd want to know that work on this plugin has moved to Sourcehut: https://git.sr.ht/~jdugan6240/kak-dap.
I am in the middle of a complete rewrite of kak-dap in Python, with a better knowledge of how the plugin should work, and am addressing some of the issues you brought up here. For example:

Your point about some variables being marked as expandable when they shouldn't have been. Yeah, this ended up being a kak-dap bug. Basically, the "icon" was blank as it should be for any non-expandable variables at first, but if anything expandable showed up after that, the icon would never again update to blank for any future non-expandable variables.
Your point about the client usage. Again, the option to manually determine what clients to use will still exist, but the plugin will, out of the box, attempt to determine which windowing environment you're using and set up a layout accordingly.

This rewrite also comes with changes to how you'll configure kak-dap. Basically, the .kak-dap.json file has been completely reworked, now being YAML instead of JSON, and debug adapters are defined in a new adapters.yaml file in the kak-dap directory. The reason for this is I hope to eventually support having the plugin install debug adapters for you with a dap-install command, which should ease getting started with it (and YAML is much nicer as a config language than JSON).
If you want to check it out, check out the big-rewritening branch on the Sourcehut repo. It's just about functional at this point, but is lacking some features and the documentation is basically nonexistent. If you wanted to contribute, questions can be directed to the following mailing list: https://lists.sr.ht/~jdugan6240/kak-plugins-discuss.


[Release Radar Request] Neo4j-Migrations v2

Open Source Project name
neo4j-migrations
What is your project?
Neo4j-Migrations is a database refactoring tool for Neo4j. It takes care of managing Cypher scripts by checksumming them and applying them in a controlled fashion, including pre-conditions and repeatable migrations. In addition it contains a set of predefined refactoring such as renaming a set of labels or types and changing relationships.
It comes as a standalone API, as CLI and as a plugin for major Java frameworks such as Spring Boot or Quarkus. The CLI does not need to have JVM installed, it is build with GraalVM and available as native executable for various operation systems and architectures:

Here's the main author of the project giving a presentation of the project at Neo4j's Nodes2022 conference: https://www.youtube.com/watch?v=5-j0xiVAeoM
Version
2.0
Date
2022-12-05
Description of breaking changes
The 2.0 release is now build on Java 17. Previous baseline was Java 8, but Java 8's time is coming to an end, at least in non-commercial settings.
This allows us to support Spring Boot 3 (released in November 2022, also on Java 17) and make use of the latest Java-Driver for Neo4j which also requires Java 17.
Apart from that, the GraalVM, an Oracle Labs project we are using to produce native binaries, stopped supporting Java 8 a while back and we have been stuck on an old version ever since.
In addition, our code base got smaller because we don't do multi-release jars anymore and we can of course benefit from all the new features since Java 8, such as text blocks, records, switch statements and the like.
GitHub Repo
https://github.com/michael-simons/neo4j-migrations
Website
https://neo4j.com/labs/neo4j-migrations/2.0/introduction/
Link to changelog
https://github.com/michael-simons/neo4j-migrations/releases/tag/2.0.0
Social media
https://twitter.com/rotnroll666/status/1599775753360396288
Anything else to add?
The project uses rather strict semantic versioning. On the one hand, we try to not break our users ever without a proper warning and on the other hand, try to support as many Neo4j major versions as possible without our users ever noticing that we adapt behind the scenes.

Big release :muscle:

Congrats on being featured in the Dec/Jan Festive Release Radar 🥳

Read the blog here
Check out our GitHub Tweet

:clap:

Wow. Thank you. 🙇♂


Explicitly specify DTO field names during serialization

Specified the serialized names of DTO classes.
Before I could do that I had to create a separate model for the LocationMessage https://github.com/ably/ably-asset-tracking-android/pull/398/commits/1d7a43820171292971b7006d4c83d25f79a34629 because previously we used the GeoJsonMessage which is also exposed in our public API. Thus I wasn't able to use the Gson library annotations with GeoJsonMessage to not expose that dependency in our API.
Then I've moved some mappers to a more appropriate location https://github.com/ably/ably-asset-tracking-android/pull/398/commits/eb21bb0c114bed3311c650b5ba30e54c509530e9 (and fixed tests https://github.com/ably/ably-asset-tracking-android/pull/398/commits/eae265aada2aa73bf73c514b8ea798a8783067c3).
In the end I finally annotated the DTO classes with explicit field names https://github.com/ably/ably-asset-tracking-android/pull/398/commits/8c63e89ab26b689bece95cd764c7b13427814d83.

I've prepared an issue for running integration tests with minifyEnabled true https://github.com/ably/ably-asset-tracking-android/issues/400


[Docs] Fix warnings and suggestions from vale

Description

Fix all warnings and suggestion from vale that were not visible until an error was introduced

@stichbury - returning to your comment on why certain things were not raised on Vale in the last PRs. I just quickly checked, and there are two relevant factors:

Previously, e.g. was considered an error, but e.g was not -> I've made it stricter in this PR now
It seems like vale as a pre-commit hook will always return "passed" as long as there is no new error introduced (3 different levels: error, warning, suggestion).

This means that over time, vale probably raised a couple of suggestions and warnings, but they were never shown to us unless we simultaneously introduced a vale error. To find all of the warnings/suggestions, I intentionally added an error (adding e.g. this in any of the docs) and then ran the linter. Only then were all of the warnings/suggestions visible. I've fixed them all in this PR now, but it's essential to be aware of that limitation.
@stichbury - I couldn't find a quick way of configuring that warnings/suggestions are also errors for us. Do you have an idea? Otherwise, it's good to be aware of the restriction above 🔝  It might be worth considering switching to github actions for vale. It seems like there is a configuration option fail_on_error  that might does that, but one would have to test it out, because I am not sure if it behaves similarly to the pre-commit hook. So I'll leave that for someone to test out next sprint 👍
Screenshot
Notice

[x] I acknowledge and agree that by checking this box and clicking "Submit Pull Request":

I submit this contribution under the Apache 2.0 license and represent that I am entitled to do so on behalf of myself, my employer, or relevant third parties, as applicable.
I certify that (a) this contribution is my original creation and / or (b) to the extent it is not my original creation, I am authorized to submit this contribution on behalf of the original creator(s) or their licensees.
I certify that the use of this contribution as authorized by the Apache 2.0 license does not violate the intellectual property rights of anyone else.
I have not referenced individuals, products or companies in any commits, directly or indirectly.
I have not added data or restricted code in any commits, directly or indirectly.

Aha! That makes sense, thanks for working out what was happening and resolving those issues.

I couldn't find a quick way of configuring that warnings/suggestions are also errors for us. Do you have an idea?

We could just make the level setting of the Vale styles that are important into errors rather than warnings/suggestions? It's not non-trivial but it's relatively easy to do for the main culprits that we occur regularly such as spelling, capitalisation and abbreviation.
Of course, by doing that, it then means that all reports have to be fixed even where they are valid cases (this may mean simply switching vale on and off with comments around the section in question).
Having a way to see all suggestions clearly at all times, and then decide whether to act on them is the ideal. I'll discuss with @antonymilne in the next sprint as we have a ticket to look at this. For now though, you've cleared up what was there, and that's awesome. Thank you 🙏


Suggest noFallthroughCasesInSwitch TypeScript option

See #6906.

This makes sense to me 👍
What needs to happen for this? Happy to help with a PR.

Ooo thanks for reminding us. This was already done 😄
https://github.com/facebook/create-react-app/blob/fa648daca1dedd97aec4fa3bae8752c4dcf37e6f/packages/react-scripts/scripts/utils/verifyTypeScriptSetup.js#L117
Will be in 4.0


Correction for raw affiliation Western University Western University

Correction needed for raw affiliation Western University Western University
raw_affiliation_name: Western University Western University
new_rors: 02grkyz14
previous_rors: 05cgtjz78
works_examples: W4360593204;W4388727027;W4385885009;W4386928715;W4385553950
contact: 560ba5d7da9211374d2b697ab2ed5aba:afa3f54e23c3b476 @ uwo.ca

This issue was accepted and ingested by the OpenAlex team on 2024-12-19. The new affiliations should be visible within the next 7 days.


[fix] fix migration action and procedure name

Purpose
Change the action and procedure name of migration
Tests

API and Format

Documentation

+1


Self-Contained App Crashes When Using ApplicationDataContainer

Discussed in https://github.com/microsoft/WindowsAppSDK/discussions/2618

Originally posted by anlocnghg June 13, 2022
My app previously used 'framework-dependent' deployment (it installed in an user local app folder and could be distributed via Microsoft Store). However, due to our organization's requirements that only xCopy deployment is allowed, meaning self-contained app. I followed the instruction (Link), everything initially was okay. Only until I started using the ApplicationDataContainer, for example:
private void myButton_Click(object sender, RoutedEventArgs e)
{
    myButton.Content = "Button Clicked";

    // App crashes
    var localSettingContainer = Windows.Storage.ApplicationData.Current.LocalSettings;
}

I know that since the xCopy deployment (self-contained app), there is no user local storage folder for the installed app. I would like to ask what is the best way to walkaround this issue to be able to reuse to ApplicationDataContainer, or any other app settings container API?
Thank you very much!
Below is steps to reproduce the crash:

Create a new WinUI3 app
Make this app self-contained by editing the project file following this link.
Created a variable referencing to Windows.Storage.ApplicationData.Current.LocalSettings in a Button Clicked handler, for example:
var localSettingContainer = Windows.Storage.ApplicationData.Current.LocalSettings;
Run and the app crashes when the button clicked

The ApplicationData type needs package identity to know where to store the data. xcopy-deployed apps don't have identity by default.  I'm not finding an easy way to construct an ApplicationDataContainer on its own outside of ApplicationData but we'll ask around.
Good feature request, though - "where should I store my data for apps that aren't strictly speaking installed?"  I'd suggest something under %localappdata%\temp by default, and we could use cues from the app itself (like the identity in a side-by-side manifest) to put something under %localappdata%\$(publisher)\$(appname) ...

I'm not finding a ~easy~ way to construct an ApplicationDataContainer on its own outside of ApplicationData

You can strike 'easy'. ApplicationData requires package identity as the data store is created when the package is registered. If you're not packaged then no package registration thus no ApplicationData data store thus ApplicationData[Manager] APIs won't work.

Windows.Storage.ApplicationData.Current requires the process have package identity AND cannot be in an AppContainer.
Windows.Storage.ApplicationDataManager.CreateForPackageFamilyName(pkgfamilyname) does the equivalent if you have package identity and run as MediumIL (or higher).
If you lack package identity the long-standing guidance is to use %LOCALAPPDATA%\publisher\product\... for per-user data

The data location moral equivalents for packaged vs unpackaged apps

ApplicationData
Unpackaged

LocalCacheFolder
%LOCALAPPDATA%<publisher><product>`

LocalFolder
%LOCALAPPDATA%<publisher><product>`

TemporaryFolder
%LOCALAPPDATA%\Temp

LocalSettings
HKCU\SOFTWARE\<publisher>\<product>

See Microsoft.Storage.ApplicationData #2639


ARROW-14424: [Packaging][Python] Disable windows wheel testing for python 3.6

Benchmark runs are scheduled for baseline = 3347be7cba0782ff469042eea9bc3c81ea4178be and contender = bbb3106274b0dfd10b8f28ea5ffeabe072845411. bbb3106274b0dfd10b8f28ea5ffeabe072845411 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished :arrow_down:0.0% :arrow_up:0.0%] ec2-t3-xlarge-us-east-2
[Scheduled] ursa-i9-9960x
[Scheduled] ursa-thinkcentre-m75q
Supported benchmarks:
ursa-i9-9960x: langs = Python, R, JavaScript
ursa-thinkcentre-m75q: langs = C++, Java
ec2-t3-xlarge-us-east-2: cloud = True


sumatrapdf: Link fix

Use download links from official website @ https://www.sumatrapdfreader.org/download-free-pdf-viewer

/verify


MBR - missing link for reference

"Why it’s sda and hda ? refer here for more." - does not point to any valid reference. Add a refer link or remove this line instead.

[x] I have read freeCodeCamp's contribution guidelines.
[x] My pull request has a descriptive title (not a vague title like Update index.md)
[x] My pull request targets the master branch of freeCodeCamp.
[x] None of my changes are plagiarized from another source without proper attribution.
[x] My article does not contain shortened URLs or affiliate links.

If your pull request closes a GitHub issue, replace the XXXXX below with the issue number.
Closes #XXXXX

Thanks for contributing to the freeCodeCamp repository. Congratulations on your first PR! 🎊
Look forward to more contributions from you! ✈


Add a wrap widget

Add a wrap widget

[x] Finish the document
[x] Add optional directions

At present, horizontal direction can be used. My English is not good enough, so I need you to help me think about the document part.

This is a great widget. :+1:
I hope I find the time tomorrow evening to take a closer look at it and to add the missing documentation.

Alright, I've now updated the documentation of the code. :slightly_smiling_face:

Cool, I will implement optional directions next.

Currently supports optional direction, but alignment is not implemented, this part I don't have strong demand, therefore no strong desire to impl it.
Because a lot of changes, the document also needs to be updated.
I haven't implemented alignment yet, but I'll do it in the future if I have time.Of course, it would be nice to see if anyone is interested in making it happen ahead of me.I need you to help me mark this part in the document , to mark that this part has not been implemented yet. Thank you very much.

OK, this is actually done, even the align has been implemented.

Awesome work! :slightly_smiling_face:
Could you update the example so, that it is able to show all different kinds of directions and alignments? This would present the possibilities of your widget better.
Is there a reason of why you are using two different structs for the direction instead of one enum?

I’ve updated the example, why do I use different structs instead of enumerations because it’s better in performance? This is one of the reasons, mainly to correspond to iced’s row and column.

why do I use different structs instead of enumerations because it’s better in performance? This is one of the reasons, mainly to correspond to iced’s row and column.

I was just curious. I didn't know there was such a big difference in performance.
Alright! Thank you very much for such a nice widget. :+1:


Various fixes including

configure openshift-gitops with admin permissions
add readme to default templates
create default templates even if HostedCluster CR is not found
enable UI by default

lgtm, just need to rewrite the test according to changes


[4.0.beta17] Advanced Import 'use external' paths are not updated on filesystem changes

Godot version
4.0.beta17.mono.official
System information
Windows 10
Issue description
When the advanced import dialog is used to link external materials (possibly other resource types aswell) and a part of the hierarchy that's contained in the link path changes in the filesystem, the paths become invalid (they are not auto-adjusted by the editor)
Steps to reproduce
Open the attached project and rename the 'SubFolder' to something else.
Notice the console error indicating the now invalid external-res paths for the imported asset
Minimal reproduction project
ImportLinkLostMRP.zip

This is a core issue


build errors for arm

if i build using separate cpu architecture i got this error for arm:
java.io.FileNotFoundException: ..\react-native-webrtc\android\build\intermediates\bundles\release\jni\lib\armeabi-v7a\libjingle_peerconnection_so.so (The system cannot find the path specified)
is arm not supported? -EDIT- even building for single cpu architecture it still errors
i also have found that the demo uses RN 0.29 and in build.gradle
it uses com.android.tools.build:gradle:1.3.1 while mine is 2.1.0 not that i know if this matters.
-EDIT- setting it back to 1.3.1 compiles on a newly tested project but my old one requires 2.1.0 because of one signal
im also using RN 0.39 and v0.54.6 for webrtc

apparently it conflicts with the one signal package. version 2.1.0 or 1.3.1 is fine regardless
the fix is this in /build.gradle
android {
    ...
    defaultConfig {
        ...
        multiDexEnabled true
    }
}

thanks for sharing!


arm64

Hello, first I want to say thankyou for an awesome project and all the work reverse engineering the closed source binary drivers! Simply amazing. I have more of a question/request then issue. Any chance you could add a release with an arm64 download? I'm pretty much all aarch64 these days, I do have it compiling at this momemt but I'm positive issues will arise during compile. Combine that with how long it takes on slower machines it would be super great. again thank you for the awesome work you guys did!

It is a very idea maybe at same time update it with latest GCC ARM from https://github.com/xpack-dev-tools/riscv-none-elf-gcc-xpack/releases/tag/v13.2.0-2
As anyway this fork is just original version with a very small patch to support WCH CH56x Interrupt


label

why you define your label in the loss function to be :
` def sync_loss(self,out_v,out_a,criterion):
    batch_size  = out_a.size()[0]
    time_size   = out_a.size()[2]

    label       = torch.arange(time_size).cuda()

    nloss = 0
    prec1 = 0

`
should the label  be 0 or 1 depended on the data is synchronized or not ?

The label should be the matching frame, i.e. along the diagonal. See https://ieeexplore.ieee.org/document/9067055


Add nested type support: struct/resource methods

Methods of nested struct or resource is for query script. Standalone call is unuseful because it will not chang Blockchain's state, should not generate go methods code for them.

No that is incorrect, they can change Blockchain state, and they can get Blockchain state.
There is a contract with a struct
pub contract Example {
  priv let name: String

  pub struct ExampleStruct {
    pub fun getName(): String {
      return Example.name // return blockchain state 🤯
    }

    pub fun setName(_ n: String) {
      Example.name = n // change blockchain state 🤯
    }
  }

  init() {
    self.name = ""
  }
}

But how do we position the instance of struct/resource? We can only construct the type and invoke function...


Weather-forecaster

issue #259
This project gives the weather forecast of the city entered by the user.

@Jayshah6699 sir please review this


Switch to dtolnay actions, bump versions

Closes #9

I don't have privileges on this repo, so I can't merge it. Do you mind merging it @bjoernQ?


Add kubebox version 0.6.0

Add kubebox from https://github.com/astefanutti/kubebox

You could add shortcuts property as it will be opened in new separate window when executed from start menu.


Can you disable associations on update?

I'm having all sorts of trouble with validation failures when trying to update a model with associations. For example I might load a Person and a person can have a type of Job (butcher, baker, etc). I can load the person and populate their job. But when I come to update the person, sometimes the validator chokes on job and the stack trace is insufficient to find out exactly what's going wrong. What I think is happening is Waterline looks at the whole association object and tries to validate it, rather than just just looking at the foreign key.
So is there a way to just update the properties of that primary person object and ignore the actual association object(s)?
Thanks in advance.

See also https://github.com/balderdashy/waterline/issues/964#issuecomment-95626676.

Guys, can you check @devinivy's answer in https://github.com/balderdashy/waterline/issues/964#issuecomment-95626676:

The way nested updates works is as such,

When an id is specified on a nested record passed to Collection#update, update those nested records.
Remove all associations with the parent record, either by removing associations from a junction table (m:n) or by setting child record foreign keys to null (1:n).
For those nested records passed to Collection#update without specified without ids, create them.
Gather ids from all nested records, now created or updated, and associate those records with the parent record.

Step two is failing for you.  In your case, since nested updates reset associations entirely, doing updates like this is generally bound to orphan post records, which isn't allowed by your model.  If your records aren't allowed to be orphaned, it might be better to update those child records directly, so that their foreign keys are explicitly switched.  I hope it's clear: doing a nested update like this will leave you with exactly one post associated with your user.

I think that explains what's going on.
In #975 there is an ongoing discussion on what can be done to fix this. Please continue the discussion there. If you feel the issues are different please reopen this! Thanks.


MJ lessons learned

I started the blog with collecting and organising the lessons learned from the planning HackMD and the group meet notes, Zulip etc.

Awesome. I will work on this tomorrow.

Nice! Let me know then. I think at least a short zoom would be good like it
was today 😊
On Thu 3. Nov 2022 at 17.31, Radovan Bast @.***> wrote:

Awesome. I will work on this tomorrow.
—
Reply to this email directly, view it on GitHub
https://github.com/coderefinery/coderefinery.org/pull/711#issuecomment-1302288008,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AJQY66X7CWXEWW7NVHY6M5TWGPLDHANCNFSM6AAAAAAROUSZMQ
.
You are receiving this because you were assigned.Message ID:
@.***>

And "tomorrow" became later. Let's work on it together. I will coordinate via chat.

We are now working on it in a collaborative document and will post changes than to this PR.

Updated draft is here: https://hackmd.io/K0qOP97ATO2ZqR6TcwHa0A

Later I will move it back to this PR but leaving it on hackmd for easier edits for a bit.

Matias, do you have a suggestion for a tweet text?

Oh sorry I forgot this. Do you still need one?

I forgot as well. I now checked and it looks like we did not tweet about it. So this is still relevant and not too late.


Auto destroy LB on terraform destroy

Hey folks, this build-up on the good work of @phaer in previous commits.
It was achieved with a simple null resource that triggers on the change of the token, and my testing indicated that it's also necessary to delete the network.
The end result is that it works well and the destroy is smooth. Even in the case of an eventual error, it will continue, if the LB was not there for instance, or the hcloud command was not installed.

This trick also doesn't work if the current hcloud context is incorrect. The best thing to do would be to delete the traefik service in the kube-system namespace and let the ccm to delete the real load-balancer.

Thanks, folks, will definitely test with kubectl -n kube-system delete svc traefik, my fear is that the CCM would take a long time to abide, but maybe not.

It has a finalizer, it should be synchronous

Did some changes folks, it works in deleting Traefik in a deterministic fashion. But the networks it's something else, they get deleted 5 minutes later, so either they do this because it's a fresh cluster, or it's just the IP routing table that takes time to refresh and clear.

Tried deleting the ccm with kubectl delete -f https://github.com/hetznercloud/hcloud-cloud-controller-manager/releases/latest/download/ccm-networks.yaml, but changed nothing. Am out of options, for now, it the network is slow to delete, folks will understand that they need to delete it manually.
I propose we merge, what do you think?

Ah, turns out if we let the cluster "settle" for at least 10 minutes, and then delete, the network goes away without resistance! 🥳 Otherwise, in testing scenarios, quickly create and delete,  it takes under 5 minutes to go, in which case, the tester can use his hcloud command rightfully, to speed things up a tiny bit 😂

That should be good enough folks, merging.


Fix/vault calls add srt token

For some reason, quite a few changes from previous PRs were missing. Here is an additional PR.

Changed merged via another PR


Add name parameter to 'update_user' method

This was done to enable editing admin user name as per this ticket:
https://trello.com/c/j1jx6KkX/154-allow-super-admin-edit-admin-roles

Great. Please can you add a note in the CHANGELOG.md file to show people importing the new version what code changes they might need to make.

And the test for this method probably also needs updating to check that it does the right thing with the new parameter.

Ahh, fair do @TheDoubleK. I did that now :). It's the first time I've introduced a breaking change 😳


[exthost] [error] TypeError [ERR_INVALID_ARG_TYPE]: The "path" argument must be of type string. Received type undefined

Issue Type: Bug
Hello,
Most of my extensions doesn't work any more. I always have the same error in the Extension Host logs : [exthost] [error] TypeError [ERR_INVALID_ARG_TYPE]: The "path" argument must be of type string. Received type undefined
[2020-07-17 09:04:03.877] [exthost] [info] ExtensionService#_doActivateExtension ms-vscode.powershell {"startup":false,"extensionId":{"value":"ms-vscode.powershell","_lower":"ms-vscode.powershell"},"activationEvent":"onLanguage:powershell"}
[2020-07-17 09:04:03.877] [exthost] [info] ExtensionService#loadCommonJSModule file:///c:/Users/adm-a.billon/.vscode/extensions/ms-vscode.powershell-2020.6.0/out/src/main
[2020-07-17 09:04:03.879] [exthost] [error] Activating extension ms-vscode.powershell failed due to an error:
[2020-07-17 09:04:03.879] [exthost] [error] TypeError [ERR_INVALID_ARG_TYPE]: The "path" argument must be of type string. Received type undefined
	at validateString (internal/validators.js:112:11)
	at Object.join (path.js:375:7)
	at Function.Module._nodeModulePaths (internal/modules/cjs/loader.js:590:37)
	at Module.load (internal/modules/cjs/loader.js:777:23)
	at Module._load (internal/modules/cjs/loader.js:693:12)
	at Module._load (electron/js2c/asar.js:717:26)
	at Function.Module._load (electron/js2c/asar.js:717:26)
	at Function.t._load (c:\Program Files\Microsoft VS Code\resources\app\out\vs\workbench\services\extensions\node\extensionHostProcess.js:974:348)
	at Function.i._load (c:\Program Files\Microsoft VS Code\resources\app\out\vs\workbench\services\extensions\node\extensionHostProcess.js:943:839)
	at Function.n._load (c:\Program Files\Microsoft VS Code\resources\app\out\vs\workbench\services\extensions\node\extensionHostProcess.js:940:198)
	at Module.require (internal/modules/cjs/loader.js:820:19)
	at require (internal/modules/cjs/helpers.js:68:18)
	at Function.s [as __$__nodeRequire] (c:\Program Files\Microsoft VS Code\resources\app\out\vs\loader.js:33:205)
	at h._loadCommonJSModule (c:\Program Files\Microsoft VS Code\resources\app\out\vs\workbench\services\extensions\node\extensionHostProcess.js:945:34)
	at h._doActivateExtension (c:\Program Files\Microsoft VS Code\resources\app\out\vs\workbench\services\extensions\node\extensionHostProcess.js:835:599)
	at h._activateExtension (c:\Program Files\Microsoft VS Code\resources\app\out\vs\workbench\services\extensions\node\extensionHostProcess.js:834:692)
	at Object.actualActivateExtension (c:\Program Files\Microsoft VS Code\resources\app\out\vs\workbench\services\extensions\node\extensionHostProcess.js:832:453)
	at h._activateExtension (c:\Program Files\Microsoft VS Code\resources\app\out\vs\workbench\services\extensions\node\extensionHostProcess.js:601:405)
	at c:\Program Files\Microsoft VS Code\resources\app\out\vs\workbench\services\extensions\node\extensionHostProcess.js:601:83
	at Array.map (<anonymous>)
	at h._activateExtensions (c:\Program Files\Microsoft VS Code\resources\app\out\vs\workbench\services\extensions\node\extensionHostProcess.js:601:71)
	at c:\Program Files\Microsoft VS Code\resources\app\out\vs\workbench\services\extensions\node\extensionHostProcess.js:601:176
	at processTicksAndRejections (internal/process/task_queues.js:85:5)

VS Code version: Code 1.47.2 (17299e413d5590b14ab0340ea477cdd86ff13daf, 2020-07-15T18:22:06.216Z)
OS version: Windows_NT x64 10.0.17134

System Info

Item
Value

CPUs
Intel(R) Core(TM) i5-8250U CPU @ 1.60GHz (8 x 1800)

GPU Status
2d_canvas: enabledflash_3d: enabledflash_stage3d: enabledflash_stage3d_baseline: enabledgpu_compositing: enabledmultiple_raster_threads: enabled_onoop_rasterization: disabled_offprotected_video_decode: enabledrasterization: enabledskia_renderer: disabled_off_okvideo_decode: enabledviz_display_compositor: enabled_onviz_hit_test_surface_layer: disabled_off_okwebgl: enabledwebgl2: enabled

Load (avg)
undefined

Memory (System)
15.85GB (9.93GB free)

Process Argv

Screen Reader
no

VM
0%

Extensions (13)

Extension
Author (truncated)
Version

vscode-base64
ada
0.1.0

overtype
ada
0.2.0

vscode-edifact
DAX
0.6.0

xml
Dot
2.5.0

gitlens
eam
10.2.2

reg
ion
1.0.1

rainbow-csv
mec
1.7.0

csharp
ms-
1.22.1

powershell
ms-
2020.6.0

vscode-hexdump
sle
1.7.2

poor-mans-t-sql-formatter-vscode
Tao
1.6.10

vscode-icons
vsc
10.2.0

vsc-jsonsnippets
wmo
0.7.0

I was running VSCode with different user that opened the Windows session.
I opened a session on my station launched VScode with this user and it resolved my issue.

Can you explain what you mean by running vscode with a different user than the one that opened the session? Looking for clues to https://github.com/microsoft/vscode/issues/102642

My OS is Windows 10. I log on with a domain user "a.billon".
When I run VSCode, I run it with a different user (adm-a.billon) and with elevated elevated privileges as I need different rights to connect to shares or SQL servers.
Hope this helps.

I think we made some progress on https://github.com/microsoft/vscode/issues/102642, if that's the same issue you were having, and a fix should be coming down the line in case you hit it again.


Customer Loyalty Program

Added a field 'points' to each product in the default.yml file.
Each product has been assigned 1 point for now (we could later on assign points in proportion to the product price).
The bonus point is being displayed in the product's modal, user's basket, order summary, and when a user tracks the order. The bonus points corresponding to each order item and the whole order are being stored but the total bonus points for the user are not being stored yet (I'll be working on it next).

Hope you find this useful. :)
Order Track Result

Product Modal

Order Summary

User Basket

I'm not sure a dedicated column is really needed, we could just calculate the bonus points like so many loyalty programs on the fly based on the price. Like 1$ = 1 Point. Then I also think it doesn't need to display the points everywhere. Maybe only on the product details popup? The basket screen should show the total you'd gain on chekout and the order summary PDF exactly like you did shows the earned points and maybe also the new total of the user (once you save the points in DB). I think we should do a separate table for them which is not exposed via API.

I think we should also add an explanation to what these bonus points are and what they are good for.
Currently as a user who hasn't read the issue this would be totally unclear.
I'd remove the bonus points from the product detail page, i think they are especially confusing there. Loyalty Points should bind the user to the shop for a second or third purchase not increase the chance of the initial purchase.
To the User Basket and the Order Page i think we should add an extra paragraph, something like this:
Bonus points earned: 3
Bonus Points can be used to get special discounts on your next order. When you have some you can choose to use them by ...

@J12934 @bkimminich I've implemented a few changes as per your suggestions. Here are the updated screenshots:

I'm working on adding it to the user and further we can discuss about how to redeem the bonus points. :)

That looks nice! Maybe we could just rephrase the text into something slightly more cheesy and promises-made-not-kept style?

Collect Juicy Points now! You will be able to redeem them for amazing bonuses in the future!

@bkimminich I've updated the message :)

I think the bonus points should be displayed less prominently in the final invoice.

Hi @J12934 Thanks for your help! I'll make the changes and push a commit soon.


Wrong version tag

I guess you made a mistake, take a look at https://packagist.org/packages/tzk/taiga-laravel as you can see there is no version 1.0.0, I guess you should make new tag 1.2.0 so its clear for everyone.
Also delete current 1.0.0 tag since composer treats it as 1.0.
Thanks

Yes indeed I made a mistake on the tag name. I've just renamed it to v1.1.0.


Allow using PHP 8.0 with Jikan

To be able to develop and test PHP 8.0 it needs to be allowed in the composer.json first

@irfan-dahir would you have some time to check this change out. It's not that big and allows me to check if more changes are needed for PHP 8.

Thanks for the PR, @rjd22 🙌


YETUS-748. docker socket group needs handling in dind mode

(!) A patch to the testing environment has been detected.
Re-executing against the patched versions to perform further tests.
The console is at https://builds.apache.org/job/yetus-github-multibranch/job/PR-37/1/console in case of problems.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
7
Precommit patch detected.

_ Prechecks _

0
hadolint
0
hadolint was not available.

+1
@author
0
The patch does not contain any @author tags.

-0
test4tests
0
The patch doesn't appear to include any new or modified tests.  Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ master Compile Tests _

0
mvndep
8
Maven dependency ordering for branch

-1
mvninstall
66
root in master failed.

+1
javadoc
10
master passed

_ Patch Compile Tests _

0
mvndep
5
Maven dependency ordering for patch

+1
mvninstall
10
the patch passed

-1
shellcheck
2
The patch generated 1 new + 3 unchanged - 0 fixed = 4 total (was 3)

+1
shelldocs
1
There were no new shelldocs issues.

+1
whitespace
0
The patch has no whitespace issues.

+1
javadoc
9
the patch passed

_ Other Tests _

+1
unit
5
precommit in the patch passed.

+1
unit
3
asf-site-src in the patch passed.

+1
asflicense
9
The patch does not generate ASF License warnings.

156

Subsystem
Report/Notes

GITHUB PR
https://github.com/apache/yetus/pull/37

Optional Tests
dupname  asflicense  shellcheck  shelldocs  javac  javadoc  unit  hadolint

uname
Linux pietas.apache.org 4.4.0-137-generic #163~14.04.1-Ubuntu SMP Mon Sep 24 17:14:57 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
/home/jenkins/jenkins-slave/workspace/yetus-github-multibranch_PR-37/out/precommit/personality/provided.sh

git revision
master / 3a14572

maven
version: Apache Maven 3.2.1 (ea8b2b07643dbb1b84b6d16e1f08391b666bc1e9; 2014-02-14T17:37:52+00:00)

Default Java
1.8.0_191

mvninstall
https://builds.apache.org/job/yetus-github-multibranch/job/PR-37/1/artifact/out/branch-mvninstall-root.txt

shellcheck
v0.3.3 (This is an old version that has serious bugs. Consider upgrading.)

shellcheck
https://builds.apache.org/job/yetus-github-multibranch/job/PR-37/1/artifact/out/diff-patch-shellcheck.txt

Test Results
https://builds.apache.org/job/yetus-github-multibranch/job/PR-37/1/testReport/

modules
C: precommit asf-site-src U: .

Console output
https://builds.apache.org/job/yetus-github-multibranch/job/PR-37/1/console

Powered by
Apache Yetus 0.9.0-SNAPSHOT http://yetus.apache.org

This message was automatically generated.

(!) A patch to the testing environment has been detected.
Re-executing against the patched versions to perform further tests.
The console is at https://builds.apache.org/job/yetus-github-multibranch/job/PR-37/2/console in case of problems.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
17
Docker mode activated.

_ Prechecks _

+1
@author
0
The patch does not contain any @author tags.

-0
test4tests
0
The patch doesn't appear to include any new or modified tests.  Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ master Compile Tests _

0
mvndep
10
Maven dependency ordering for branch

+1
mvninstall
74
master passed

+1
javadoc
17
master passed

_ Patch Compile Tests _

0
mvndep
5
Maven dependency ordering for patch

+1
mvninstall
17
the patch passed

+1
hadolint
2
There were no new hadolint issues.

-1
shellcheck
2
The patch generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)

+1
shelldocs
2
There were no new shelldocs issues.

+1
whitespace
0
The patch has no whitespace issues.

+1
javadoc
15
the patch passed

_ Other Tests _

+1
unit
7
precommit in the patch passed.

+1
unit
6
asf-site-src in the patch passed.

+1
asflicense
15
The patch does not generate ASF License warnings.

215

Subsystem
Report/Notes

Docker
Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/yetus-github-multibranch/job/PR-37/2/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/yetus/pull/37

Optional Tests
dupname  asflicense  shellcheck  shelldocs  javac  javadoc  unit  hadolint

uname
Linux 5157d95c9fb4 4.4.0-137-generic #163~14.04.1-Ubuntu SMP Mon Sep 24 17:14:57 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
precommit/src/main/shell/personality/yetus.sh

git revision
master / 3a14572

maven
version: Apache Maven 3.3.9

Default Java
1.8.0_191

shellcheck
v0.4.6

shellcheck
https://builds.apache.org/job/yetus-github-multibranch/job/PR-37/2/artifact/out/diff-patch-shellcheck.txt

Test Results
https://builds.apache.org/job/yetus-github-multibranch/job/PR-37/2/testReport/

Max. process+thread count
89 (vs. ulimit of 2000)

modules
C: precommit asf-site-src U: .

Console output
https://builds.apache.org/job/yetus-github-multibranch/job/PR-37/2/console

Powered by
Apache Yetus 0.9.0-SNAPSHOT http://yetus.apache.org

This message was automatically generated.

(!) A patch to the testing environment has been detected.
Re-executing against the patched versions to perform further tests.
The console is at https://builds.apache.org/job/yetus-github-multibranch/job/PR-37/3/console in case of problems.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
16
Docker mode activated.

_ Prechecks _

+1
@author
0
The patch does not contain any @author tags.

-0
test4tests
0
The patch doesn't appear to include any new or modified tests.  Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ master Compile Tests _

0
mvndep
11
Maven dependency ordering for branch

+1
mvninstall
72
master passed

+1
javadoc
16
master passed

_ Patch Compile Tests _

0
mvndep
5
Maven dependency ordering for patch

+1
mvninstall
17
the patch passed

+1
hadolint
1
There were no new hadolint issues.

+1
shellcheck
2
There were no new shellcheck issues.

+1
shelldocs
2
There were no new shelldocs issues.

+1
whitespace
0
The patch has no whitespace issues.

+1
javadoc
15
the patch passed

_ Other Tests _

+1
unit
7
precommit in the patch passed.

+1
unit
6
asf-site-src in the patch passed.

+1
asflicense
15
The patch does not generate ASF License warnings.

209

Subsystem
Report/Notes

Docker
Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/yetus-github-multibranch/job/PR-37/3/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/yetus/pull/37

Optional Tests
dupname  asflicense  shellcheck  shelldocs  javac  javadoc  unit  hadolint

uname
Linux 46d1101c3fd3 4.4.0-137-generic #163~14.04.1-Ubuntu SMP Mon Sep 24 17:14:57 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
precommit/src/main/shell/personality/yetus.sh

git revision
master / 3a14572

maven
version: Apache Maven 3.3.9

Default Java
1.8.0_191

shellcheck
v0.4.6

Test Results
https://builds.apache.org/job/yetus-github-multibranch/job/PR-37/3/testReport/

Max. process+thread count
90 (vs. ulimit of 2000)

modules
C: precommit asf-site-src U: .

Console output
https://builds.apache.org/job/yetus-github-multibranch/job/PR-37/3/console

Powered by
Apache Yetus 0.9.0-SNAPSHOT http://yetus.apache.org

This message was automatically generated.

(!) A patch to the testing environment has been detected.
Re-executing against the patched versions to perform further tests.
The console is at https://builds.apache.org/job/yetus-github-multibranch/job/PR-37/4/console in case of problems.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
17
Docker mode activated.

_ Prechecks _

+1
@author
0
The patch does not contain any @author tags.

-0
test4tests
0
The patch doesn't appear to include any new or modified tests.  Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ master Compile Tests _

0
mvndep
11
Maven dependency ordering for branch

+1
mvninstall
72
master passed

+1
javadoc
16
master passed

_ Patch Compile Tests _

0
mvndep
5
Maven dependency ordering for patch

+1
mvninstall
17
the patch passed

+1
hadolint
1
There were no new hadolint issues.

+1
shellcheck
2
There were no new shellcheck issues.

+1
shelldocs
2
There were no new shelldocs issues.

+1
whitespace
0
The patch has no whitespace issues.

+1
javadoc
15
the patch passed

_ Other Tests _

+1
unit
7
precommit in the patch passed.

+1
unit
7
asf-site-src in the patch passed.

+1
asflicense
14
The patch does not generate ASF License warnings.

209

Subsystem
Report/Notes

Docker
Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/yetus-github-multibranch/job/PR-37/4/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/yetus/pull/37

Optional Tests
dupname  asflicense  shellcheck  shelldocs  javac  javadoc  unit  hadolint

uname
Linux cb3d4c71e1a7 4.4.0-137-generic #163~14.04.1-Ubuntu SMP Mon Sep 24 17:14:57 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
precommit/src/main/shell/personality/yetus.sh

git revision
master / 3a14572

maven
version: Apache Maven 3.3.9

Default Java
1.8.0_191

shellcheck
v0.4.6

Test Results
https://builds.apache.org/job/yetus-github-multibranch/job/PR-37/4/testReport/

Max. process+thread count
90 (vs. ulimit of 2000)

modules
C: precommit asf-site-src U: .

Console output
https://builds.apache.org/job/yetus-github-multibranch/job/PR-37/4/console

Powered by
Apache Yetus 0.9.0-SNAPSHOT http://yetus.apache.org

This message was automatically generated.

(!) A patch to the testing environment has been detected.
Re-executing against the patched versions to perform further tests.
The console is at https://builds.apache.org/job/yetus-github-multibranch/job/PR-37/5/console in case of problems.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
18
Docker mode activated.

_ Prechecks _

+1
@author
0
The patch does not contain any @author tags.

-0
test4tests
0
The patch doesn't appear to include any new or modified tests.  Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ master Compile Tests _

0
mvndep
10
Maven dependency ordering for branch

+1
mvninstall
73
master passed

+1
javadoc
16
master passed

_ Patch Compile Tests _

0
mvndep
5
Maven dependency ordering for patch

+1
mvninstall
17
the patch passed

+1
hadolint
1
There were no new hadolint issues.

+1
shellcheck
2
There were no new shellcheck issues.

+1
shelldocs
2
There were no new shelldocs issues.

+1
whitespace
0
The patch has no whitespace issues.

+1
javadoc
16
the patch passed

_ Other Tests _

+1
unit
7
precommit in the patch passed.

+1
unit
7
asf-site-src in the patch passed.

+1
asflicense
14
The patch does not generate ASF License warnings.

212

Subsystem
Report/Notes

Docker
Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/yetus-github-multibranch/job/PR-37/5/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/yetus/pull/37

Optional Tests
dupname  asflicense  shellcheck  shelldocs  javac  javadoc  unit  hadolint

uname
Linux fc3adda969aa 4.4.0-137-generic #163~14.04.1-Ubuntu SMP Mon Sep 24 17:14:57 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
precommit/src/main/shell/personality/yetus.sh

git revision
master / 3a14572

maven
version: Apache Maven 3.3.9

Default Java
1.8.0_191

shellcheck
v0.4.6

Test Results
https://builds.apache.org/job/yetus-github-multibranch/job/PR-37/5/testReport/

Max. process+thread count
90 (vs. ulimit of 2000)

modules
C: precommit asf-site-src U: .

Console output
https://builds.apache.org/job/yetus-github-multibranch/job/PR-37/5/console

Powered by
Apache Yetus 0.9.0-SNAPSHOT http://yetus.apache.org

This message was automatically generated.


Cleanup build-logic

Some changes addressed from #1780.

Replace with with using
https://docs.gradle.org/current/javadoc/org/gradle/api/artifacts/DependencySubstitutions.Substitution.html#with-org.gradle.api.artifacts.component.ComponentSelector-
Use HTTPS links
Optimize imports
Remove deprecated forUseAtConfigurationTime call https://docs.gradle.org/current/userguide/upgrading_version_7.html#for_use_at_configuration_time_deprecation

Merged, thanks!


No Transactions

Completed Umbrel node setup (pi+SSD) - fully synced 2 days ago.
Installed sparrow wallet (windows), imported wallet into sparrow (coldcard air gapped).
Connected to private electrum server using the URL provided in Umbrel Dashboard.
Generated new address and sent BTC from exchange to my address.
Initially I could see this transaction in the wallet (status unconfirmed).
after hitting refresh wallet - It cant see any transactions in my wallet.
Same thing when connecting with Public Server (bitaroo).
Tor Browser installed.
Freaking out a little.
Any advice is greatly appreciated.
sparrow.txt
Log attached

Do you have the txid? If so, what was the fee rate?
Something that may have happened with the recent sudden rise in fees is that the exchange didn't pay enough fees and the mempool transaction was excluded from the default 300Mb pool. This doesn't mean the transaction is lost (other nodes will have higher defaults) but it might mean that your Umbrel or the Bitaroo server doesn't have it anymore. This is unlikely but possible. The current purge rate is 8.5 sats/vB.
I'd try a few other public servers - connect to them, and refresh the wallet. If you saw it in Sparrow previously, it was on the Bitcoin network, so it exists.

Hi - thanks for the reply. I don't have the txid (i did when I could see the transaction in the wallet).
I just searched Bitcoin Explorer using my address and have found the unconfirmed transaction.
Fee rate showing as 21.13 sat/vb
I used economy fee option at withdrawal from exchange. Rookie error?
Trying connections to other public servers - Is it generally a long wait for Finding transactions? - seems very slow.

Ok great, your funds are in the mempool. Unfortunately, that transaction is going to take awhile to clear - hashrate has dropped significantly recently due to events in China and blocks are coming in more slowly which is pushing up the fees. One thing you can do is CPFP your stuck transaction. But it will likely clear if you are prepared to wait.

Thanks for your help ... good news is the transaction is now showing again (unconfirmed).


[Chromatic] Scroll is not shown in snapshots

Although the scroll is in the test, it is not in the Chromatic snapshots:
Textarea test:

Snapshot:

This is happening in the tests of Date Input, Resultset Table, Select, Table, Text Input and Textarea.
Also scroll arrows are not shown in responsive Tabs:

Research if there is a way to have the scroll in the snapshot.
Some helpful information can be found here: https://www.chromatic.com/docs/faq.

The problem with the scroll arrows not showing in Tabs was related to this issue: #1681.
However, the problem with the rest of the components is still occuring.


overwrite certs_secret if it already exists

The script in run.erb will not update the certs_secret if it already exists.
We use the --dry-run feature of kubectl to generate a json and apply it afterwards, which will work for create and update scenario.
BTW: maybe it would be a good idea to also activate errexit (set -e) and/or similar options.

Looks good to me, thanks! I've just hooked our CI to have full tests on each PR, do you mind rebasing?

done


SAK-42177 Implementation of standardized banners in Rubrics, BasicLTI, and Chat

https://jira.sakaiproject.org/browse/SAK-42177
Replaced various banners in rubrics, basicLTI, and chat with new banners created for SWITCH in SAK-41866. Also removed some unnecessary inline styles attached to the banners.

@kjw47, there are conflicts.
You'll need to update your master and then rebase your branch for this PR because changes have happened in master for BasicLTI recently. Let me or @ern know if you have any questions.

Thanks, @kjw47! As soon as Travis finishes building, I'll merge it in.


Print the stack trace when the helper fails a test

Currently when a test is failed by the helper, the test doesn't print enough information to identify the correct line in the failed test. Since we were already using pkg/errors, which provides very nice stack trace functionality, I updated the test helper to take full advantage of it.
Here's an example test that will fail:
func TestStuff(t *testing.T) {
	h := test.NewHelper(t)
	defer h.Cleanup()

	h.Must(errors.New("derp"))
}

Here's the current output. Note that the file and line number of the failure is in the test helper, not the test itself.
$ go test -run TestStuff
--- FAIL: TestStuff (0.00s)
	test.go:62: derp
FAIL
exit status 1
FAIL	github.com/golang/dep	0.068s

Below is the new output. Note that you can now see where the test failed:
$ go test -run TestStuff
--- FAIL: TestStuff (0.00s)
	test.go:64: derp
		github.com/golang/dep.TestStuff
			/Users/caro8994/src/github.com/golang/dep/txn_writer_test.go:21
		testing.tRunner
			/usr/local/Cellar/go/1.8/libexec/src/testing/testing.go:657
		runtime.goexit
			/usr/local/Cellar/go/1.8/libexec/src/runtime/asm_amd64.s:2197
FAIL
exit status 1
FAIL	github.com/golang/dep	0.072s

There are other things that we can do to improve the output of the tests but this is a quick win that we can build on top of without changing existing tests.

lgtm

This is a great addition, for all the reasons @carolynvs gave. Thanks!


add RNCookieManagerIOS.h and RNCookieManagerIOS.m to your ios project

Bug
Error "add RNCookieManagerIOS.h and RNCookieManagerIOS.m to your ios project"

Environment info
react-native-community/cookies version: 2.0.3
React native info output:
System:
    OS: macOS 10.15.3
    CPU: (8) x64 Intel(R) Core(TM) i7-4770HQ CPU @ 2.20GHz
    Memory: 700.00 MB / 16.00 GB
    Shell: 3.2.57 - /bin/bash
  Binaries:
    Node: 10.15.0 - ~/.nvm/versions/node/v10.15.0/bin/node
    Yarn: 1.22.0 - /usr/local/bin/yarn
    npm: 6.4.1 - ~/.nvm/versions/node/v10.15.0/bin/npm
    Watchman: 4.9.0 - /usr/local/bin/watchman
  SDKs:
    iOS SDK:
      Platforms: iOS 13.2, DriverKit 19.0, macOS 10.15, tvOS 13.2, watchOS 6.1
    Android SDK:
      API Levels: 21, 22, 23, 24, 25, 26, 27, 28, 29
      Build Tools: 25.0.0, 27.0.3, 28.0.1, 28.0.3, 29.0.0, 29.0.3
      System Images: android-19 | Google APIs Intel x86 Atom, android-25 | Google APIs Intel x86 Atom, android-25 | Google Play Intel x86 Atom, android-26 | Google Play Intel x86 Atom, android-27 | Google APIs Intel x86 Atom, android-27 | Google Play Intel x86 Atom
      Android NDK: 17.2.4988734
  IDEs:
    Android Studio: 3.5 AI-191.8<IP_ADDRESS>10548
    Xcode: 11.3.1/11C504 - /usr/bin/xcodebuild
  npmPackages:
    react: 16.9.0 => 16.9.0
    react-native: 0.61.5 => 0.61.5

Library version: 2.0.3
react-native config already contains this package:
    "@react-native-community/cookies": {
      "root": "/Users/jay.shah/Documents/mypartner/node_modules/@react-native-community/cookies",
      "name": "@react-native-community/cookies",
      "platforms": {
        "ios": {
          "sourceDir": "/Users/jay.shah/Documents/mypartner/node_modules/@react-native-community/cookies/ios",
          "folder": "/Users/jay.shah/Documents/mypartner/node_modules/@react-native-community/cookies",
          "pbxprojPath"<EMAIL_ADDRESS>          "podfile": null,
          "podspecPath"<EMAIL_ADDRESS>          "projectPath"<EMAIL_ADDRESS>          "projectName": "RNCookieManagerIOS.xcodeproj",
          "libraryFolder": "Libraries",
          "sharedLibraries": [],
          "plist": [],
          "scriptPhases": []
        },
        "android": {
          "sourceDir": "/Users/jay.shah/Documents/mypartner/node_modules/@react-native-community/cookies/android",
          "folder": "/Users/jay.shah/Documents/mypartner/node_modules/@react-native-community/cookies",
          "packageImportPath": "import com.reactnativecommunity.cookies.CookieManagerPackage;",
          "packageInstance": "new CookieManagerPackage()"
        }
      },
      "assets": [],
      "hooks": {},
      "params": []
    },

Steps To Reproduce

npm install --save @react-native-community/cookies
pod install
run app from Xcode

Describe what you expected to happen:

ios build to work but breaks with "add RNCookieManagerIOS.h and RNCookieManagerIOS.m to your ios project"

Library only works if I add pod 'react-native-cookies', :path => '../node_modules/react-native-cookies/ios' in Podfile

Only works when I add
pod 'react-native-cookies', :path => '../node_modules/@react-native-community/cookies/ios'

to my Podfile.
Ideally library should work without adding the above line right?

Hmm @jayshah123 it possible might be due to the podspec being in the iOS/ folder and at the root. Could you try that locally and possible send a PR for that?

will check this

I am getting the same error when running jest. I also added the 'react-native-cookies' line mentioned above to Podfile (and ran pod install), but that made no difference.

Fixed with https://github.com/react-native-community/cookies/pull/40

I still have this issue in jest, @nareshbhatia any luck resolving this?

@remy90, sorry I am not on that project any more and can't remember if we had solved the issue.

Hi @remy90
I just solved this issue configuring jest with a setupFile.
Inside the setupFile you should create a mock for this library:
jest.mock('@react-native-community/cookies', () => ({
  CookieManager: jest.fn(),
}));

Thanks for the help @luisaverza! I had to do it slightly differently just given some of the changes to the library...
jest.mock("@react-native-cookies/cookies", () => ({
  clearAll: jest.fn(),
}));

just incase anyone else stumbles across this thread.

I solved this issue by doing following:
(Delete installed app)

Clean XCode Project
Build XCode Project

This worked for me in a jestSetup file:
jest.mock('@react-native-community/cookies', () => ({
  CookieManager: jest.fn(),
}));

I'm getting this - not with jest just normal trying to run the RN app.
with adding
pod 'react-native-cookies', :path => '../node_modules/@react-native-community/cookies/ios'
I now get:
[!] No podspec found for react-native-cookies in ../node_modules/@react-native-community/cookies/ios