User Defined Types - properties list order

Is your feature request related to a problem? Please describe.
Currently properties defined in user defined types when listed via intellisense are listed in alphabetical order. It would be better when listed to be sorted first on the order they are defined in the type. Usually when we define our types we put the most important and mandatory properties first. That makes easier for end users to consume the template.

Do we know the default behavior for other languages like typescript and go? We want users of different languages to have a consistent experience across languages.

I am not familiar with typescript or go but if I compare it to PowerShell when you type cmdlet there you get the parameters in the order you have defined them in your cmdlet. We can also take Bicep as example as well. When you start to type the properties of a resource they are not in alphabetical order. For example:

The first two are the required one. The order also matches how they are ordered in the official docs.

Required properties are floated up above optional properties, but the sort is otherwise alphabetical:

As far as I can tell, the alphabetical sort is consistent with how TypeScript and C# completions are sorted.

This also applies to bicepparam and param autocomplete for the required-properties there as well.
main. Bicep
param DeploymentHub DeploymentHubType

type DeploymentHubType = {
  @description('The object to define the Hub Deployment')
  prefix: string
  orgName: string
  appName: string
}

produces

so do we make this behavior the same like for Azure resources in bicep or do we follow logic of other languages? I prefer the Azure logic as first it makes more sense and second than we do not have different behavior (inconsistency) when you use Azure resources and types in parameters files.

Also it is hard to get upvote on many of the types thing as it is preview that you have to enable and not many people using Bicep are familiar with these new concepts.

so do we make this behavior the same like for Azure resources in bicep or do we follow logic of other languages?

I think Bicep, TypeScript, and C# are already in alignment here: the order is required properties (alphabetically sorted) followed by optional properties (alphabetically sorted).
The one deviation from this pattern I was able to find in Bicep is that the order of top-level resource properties is hard-coded and non-alphabetical.

ok, than at least mandatory ones should be first.

Could you share a scenario in which the mandatory properties are not already showing up first? My attempts to repro all seem to exhibit the desired ordering (required properties (alphabetically sorted) followed by optional properties (alphabetically sorted)).

Apologies. Yes this is the current behavior. Got distracted by the initial request those to be in the order defined that forgot to check if indeed the mandatory are the first ones.

Sounds like we can close this one. Let me know if I am misreading.


platformio.ini: use common for most settings

This way it's much easier to see what changes between the three
environments, instead of comparing magic numbers wondering if they
change you can just glance at it and see the things that are different.

Hmm, nice.


Can we get thumbnails(from bookmarks) using controller's isReady property?

without controller.isReady thumbnail view gives an error null check used on null value
however with isReady thumbnail view just shows blank tab

Could you give me more info about your error? Actual error, stacktrace, flutter doctor, and so on.

• Upstream repository https://github.com/flutter/flutter.git
• Framework revision 78666c8dc5 (6 weeks ago), 2023-12-19 16:14:14 -0800
• Engine revision 3f3e560236
• Dart version 3.2.3
• DevTools version 2.28.4
• If those were intentional, you can disregard the above warnings; however it is recommended to use "git"
directly to perform update checks and upgrades.
[✓] Android toolchain - develop for Android devices (Android SDK version 32.1.0-rc1)
• Android SDK at /Users/zhanerke/Library/Android/sdk
• Platform android-33, build-tools 32.1.0-rc1
• Java binary at: /Applications/Android Studio.app/Contents/jre/Contents/Home/bin/java
• Java version OpenJDK Runtime Environment (build 11.0.11+0-b60-7772763)
• All Android licenses accepted.
[✓] Xcode - develop for iOS and macOS (Xcode 15.0)
• Xcode at /Applications/Xcode.app/Contents/Developer
• Build 15A240d
• CocoaPods version 1.14.2
[✓] Chrome - develop for the web
• Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome
[✓] Android Studio (version 2021.1)
• Android Studio at /Applications/Android Studio.app/Contents
• Flutter plugin can be installed from:
🔨 https://plugins.jetbrains.com/plugin/9212-flutter
• Dart plugin can be installed from:
🔨 https://plugins.jetbrains.com/plugin/6351-dart
• Java version OpenJDK Runtime Environment (build 11.0.11+0-b60-7772763)
[✓] VS Code (version 1.85.0)
• VS Code at /Applications/Visual Studio Code.app/Contents
• Flutter extension can be installed from:
🔨 https://marketplace.visualstudio.com/items?itemName=Dart-Code.flutter

Could you please enable "All Exceptions" and check what code causes the actual issue.

Oh, the following code change may fix the issue:
child: controller?.isReady != true || controller?.documentRef == null
  ? null
  : PdfDocumentViewBuilder(

Wow, so the fix above leads to the problem shown in the title. OK. I understood...

0.4.30 (557456a) is released. And it contains fix for the example.
The most important part of the example change is that it uses a new ValueNotifier and ThumbnailsView is updated by ValueListenableBuilder:
https://github.com/espresso3389/pdfrx/blob/557456a8fe33253e3c06c74330aac4fe28767ca0/example/lib/main.dart#L34

0.4.30 (557456a) is released. And it contains fix for the example.
The most important part of the example change is that it uses a new ValueNotifier and ThumbnailsView is updated by ValueListenableBuilder:
https://github.com/espresso3389/pdfrx/blob/557456a8fe33253e3c06c74330aac4fe28767ca0/example/lib/main.dart#L34

Should I use also onViewerReady, because I couldn't get PDF Page views in thumbnails tab

Oh, I didn't introduce onViewerReady on the issue. Yes, please use onViewerReady for your purpose.

I need to resolve issue with Cmake, onViewerReady is in 32's version:(

No error, however thumbnails are not shown:(((
I have added onViewerReady
I forked repo and added 3.18.1 to build.gradle

Do you run the example code? Or any other code?

Your screenshot does not seem to the example code (because outline/search tabs are missing).
If so, you should show me your code. I don't know anything about your code.

I want to get only thumbnails

So please show your codes. Do you wrap your ThumbnailView with ValueListenableBuilder correctly?
https://github.com/espresso3389/pdfrx/blob/52de2dae0e16bac8666b8ac979510ea21f6b4b2e/example/lib/main.dart#L125-L129

Mmm, the example code is not correct :(

0.4.37 contains the following "example" fixes:

humbnails_view.dart
main.dart
https://github.com/espresso3389/pdfrx/blob/755e65ff3c19d776619f73060dca6728d60d7fb5/example/lib/main.dart#L127-L134

There are two important points on the previous example's problem (and why it works)

Drawer ensures that ThumbnailsView is generated later than PdfViewer's document load
Example Bug (but example code itself is not affected by the bug): ThumbnailsView is a child of ValueListenableBuilder and it is generated regardless of ValueListenableBuilder's state change

We should move it to ValueListenableBuilder's builder

So the causes your problem is that you've removed drawer code.
And If ThumbnailView is directly placed without drawer, it should be moved to ValueListenableBuilder's builder because child does not affected by ValueListenableBuilder state updates.

`Row(
children: [
AnimatedSize(
duration: const Duration(milliseconds: 300),
child: ValueListenableBuilder(
valueListenable: showLeftPane,
builder: (context, showLeftPane, child) => SizedBox(
width: showLeftPane ? 300 : 0,
child: child!,
),
child: Padding(
padding: const EdgeInsets.fromLTRB(1, 0, 4, 0),
child: DefaultTabController(
length: 1,
child: Column(
children: [
const TabBar(tabs: [
Tab(text: 'Thumbnails'),
]),
Expanded(
child: TabBarView(
children: [
ValueListenableBuilder(
valueListenable: documentRef,
builder: (context, documentRef, child) =>
ThumbnailsView(
documentRef: documentRef,
controller: pdfController,
),
),
],
),
),
],
),
),
),
),
),
Expanded(child:
Stack(children: [
PdfViewer.file(
_path,
        controller: pdfController,

        passwordProvider: () => passwordDialog(context, themeData),
        params: PdfViewerParams(
          pageAnchor: PdfPageAnchor.all,
          backgroundColor: themeData.primaryColor,
          errorBannerBuilder:
              (context, error, stackTrace, documentRef) => Center(
            child: Text(
              error.toString(),
            ),
          ),
          onDocumentChanged: (document) async {
            if (document == null) {
              documentRef.value = null;
            }
          },
          onViewerReady: (document, controller) async {
            documentRef.value = controller.documentRef;
          },
          viewerOverlayBuilder: (context, size) => [
            PdfViewerScrollThumb(
              controller: pdfController,
              orientation: ScrollbarOrientation.right,
              thumbSize: const Size(40, 25),
              thumbBuilder:
                  (context, thumbSize, pageNumber, controller) =>
                      Container(
                color: Colors.black,
                child: Center(
                  child: Text(
                    pageNumber.toString(),
                    style: const TextStyle(color: Colors.white),
                  ),
                ),
              ),
            ),
          ],
        ),
      ),

])
)
],
)`

My code like your example code, except this
DefaultTabController(                         length: 1,                         child: Column(                           children: [                             const TabBar(tabs: [                               Tab(text: 'Thumbnails'),                             ]),                             Expanded(                               child: TabBarView(                                 children: [                                   ValueListenableBuilder(                                     valueListenable: documentRef,                                     builder: (context, documentRef, child) =>                                         ThumbnailsView(                                       documentRef: documentRef,                                       controller: pdfController,                                     ),                                   ),                                 ],                               ),                             ),                           ],                         ),                       ),

Thumbnail code is like an example code.
Below the main code.
Row(
          children: [
                AnimatedSize(
                  duration: const Duration(milliseconds: 300),
                  child: ValueListenableBuilder(
                    valueListenable: showLeftPane,
                    builder: (context, showLeftPane, child) => SizedBox(
                      width: showLeftPane ? 300 : 0,
                      child: child!,
                    ),
                    child: Padding(
                      padding: const EdgeInsets.fromLTRB(1, 0, 4, 0),
                      child: Expanded(
                        child:  ValueListenableBuilder(
                          valueListenable: documentRef,
                          builder: (context, documentRef, child) =>
                              ThumbnailsView(
                                documentRef: documentRef,
                                controller: pdfController,
                              ),
                        ),
                      )
                    ),
                  ),
                ),
                Expanded(child: pdfViewer())
              ],
            )

Now with your updated code, it gives esrror:
 PdfException: FPDFBitmap_CreateEx(0, 0) failed.
E/flutter (30356): #0      PdfPagePdfium.render.<anonymous closure>.<anonymous closure>.<anonymous closure> (package:pdfrx/src/pdfium/pdfrx_pdfium.dart:551:21)
E/flutter (30356): #1      _ComputeParams.execute (package:pdfrx/src/pdfium/worker.dart:55:43)
E/flutter (30356): #2      BackgroundWorker._workerEntry.<anonymous closure> (package:pdfrx/src/pdfium/worker.dart:28:17)
E/flutter (30356): #3      _RootZone.runUnaryGuarded (dart:async/zone.dart:1594:10)
E/flutter (30356): #4      _BufferingStreamSubscription._sendData (dart:async/stream_impl.dart:339:11)
E/flutter (30356): #5      _BufferingStreamSubscription._add (dart:async/stream_impl.dart:271:7)
E/flutter (30356): #6      _SyncStreamControllerDispatch._sendData (dart:async/stream_controller.dart:784:19)
E/flutter (30356): #7      _StreamController._add (dart:async/stream_controller.dart:658:7)
E/flutter (30356): #8      _StreamController.add (dart:async/stream_controller.dart:606:5)
E/flutter (30356): #9      _RawReceivePort._handleMessage (dart:isolate-patch/isolate_patch.dart:184:12)

The reason of PdfException: FPDFBitmap_CreateEx(0, 0) failed is that your builder always emit child! even if the leftPage size is 0.

What I mean is;
builder: (context, showLeftPane, child) => SizedBox(
  width: showLeftPane ? 300 : 0,
  child: showLeftPane ? child! : null,
),

Oh, it works now

thank you!)


Add ability to show/hide NPCs nameplates

Visible NPC HP Bar: http://forum.sa-mp.com/showthread.php?t=632664
Code: https://raw.githubusercontent.com/AbyssMorgan/SA-MP/master/include/SAM/vnpc.inc
Related functions: https://github.com/kurta999/YSF/blob/b27a575300f101cdacb9326582348c90d92eb0ef/src/natives/players.cpp#L696-L740

Pls don't let this go down the path of CNPC.
Find out if this won't cause any drama first.

This is not like CNPC. This solution affects only for specific players, not on server playerd

These is interesting...i dont like memory hacking but then again raknet structure on server side didnt change for a long time and memory address is exported in a variable...
Anyway these woul require us to hook onto raknet and in perspective it could mean per player NPC's streaming...


Missing Attributes

Good Morning.
I have this setup and working for a few of the easier items (i can turn the car on, check the status of the Windows, Alarm etc), however none of the additional attributes seem to show up. For example I cannot see any of the following:
Distance to Service
No errors that i can see in the log?  Even the "Show all data Sensor" has no attributes?

Can you please provide more details such as what car you have, version of HA.  Can you also enable data debug in the config options and also turn on debug for this integration in configuration.yaml and provide me the output.

Hmm, it looks like they should be there and it is creating all the sensors as it should.  I can see that you have 2 cars on your account.  Do either of them show the attributes?  This integration should work with having multiple cars on an account but wonder of that is where the issue may be.  Can you show me some screenshots for the following:

The integration config device screen for both your cars (obfuscate the reg) as below:

The attributes screen for the all info sensor (for both)(obfuscate anything sensitive).

I have blanked a lot out as it is not my data but show me as much as you can.  Need to see if this is some sort of mixup between your 2 cars.
As a note (but might be worth trying) - see issue #66 .  There is an updated version in the dev branch that if you know how to clone and use in HA might be worth testing.  There are a number of changes in this and I am waiting to get some testing on non PHEV vehicles before releasing.  It also has better debugging that may help find the issue.  No problem if you can't, we should be able to work out the problem in this version with a bit of trial and error.

Firstly thanks for all the responses so far! Appreciate the great support!
OK so a few things
1: I only actually have 1 car. The other car is an old car that we no longer own. I have just logged into the Landrover InControl website and deleted that old car.  I have deleted the integration, rebooted, and re-installed the integration.  Still same issue (but now the old car is gone!).
2: Screen shot 1

3: Screen shot 2 (missing the attributes!)

Not entirely sure how I clone and use the beta version I am afraid.

Ah - light bulb moment.
Sorry I have not done much on this integration for some time until recently and looks like the current released version is an old one (2.1.3) that does not work with HA after 2021.12 (ish) when they changed the name of the attributes.  I will release a new version shortly as a beta version (this will be the one in the dev branch).  It might have some errors but think it works ok (as I said was looking for a non PHEV to do final testing with).  I will let you know when done and then you will need to enable show beta versions on the integration in HACS - weirdly from the redownload option as below.  It will be 2.2.0beta.

OK just released.  If this has errors, v2.1.4 is also a beta release that i know a number of people have been using ok.  You can try that version too.

2.2.0 has indeed fixed the issue!
Thank you.

Great,  Can you let me know how you get on and add any issues to #66.  If it seems all ok, I will release this as an official version at the weekend.
Thanks and glad we got it sorted.


Multiply Two Numbers

This pull request do not contains files in specific folders. Please fix it and reopen


Add option for generation of pywal colors with wallpaper change

Is your feature request related to a problem? Please describe.
I am still using pywal over matugen for theme generation of a few programs, and I find it useful to automate wal when changing wallpapers from the hyprpanel settings.
Describe the solution you'd like
A simple option to enable wal theme generation.
Describe alternatives you've considered
Not supporting pywal
Additional context
This is something I find useful, maybe others will want it too :-)

Hey there :wave: . Is this a feature request?

The PR is ready to go, subject to your review, but I just used the feature request template to keep it organized.

On second thought, may still want to add pywal to the optional dependency list in the readme.

Awesome, I'll take a look at this during the weekend :heart:

Wonderful! Thanks for the contribution :heart:!


fix: Better product_query_page (Search)

What
We had some reports about search on Slack which are fixed here:

The template cards had no padding (I unified the padding across the cards now)
When you were scrolling to far into the templates the empty list card appeard

And I further fixed:

You landed on a blank screen if refreshing while scrolling down
To many rebuilds while scrolling, we don't need to rebuild on every scroll (?), but only when the scroll to top button appears or dissapears

Screen recording

Click me
https://user-images.githubusercontent.com/39344769/193820025-4f9acb65-7cab-49aa-b66a-f49e2e559055.mp4

Design
I'm honestly really open about the design,

maybe just 3 animated cards are enouph
the single (not animated) template card could be confusing
maybe just a loading indicator
maybe a text "Loading more products..."

Open for suggestions

I just spend some time trying to find a better way how to build the overscroll widgets by trying to create a own Scroll behaviour by extending MaterialScrollBehavior with a buildOverscrollIndicator which seemed promising.
But this sadly turned out to not really work as we can't check in there if the overscroll is on top or on the bottom. Just the general scroll direction of the ListView. If I have some time I'll check again if there is anything else I can finde, but untill then I applied your suggestions 👍🏼

Codecov Report

Merging #3093 (ad18e9f) into develop (b8e1f82) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           develop   #3093      +/-   ##
==========================================
- Coverage     6.47%   6.46%   -0.01%
==========================================
  Files          246     246
  Lines        12185   12199      +14
==========================================
  Hits           789     789
- Misses       11396   11410      +14

Impacted Files
Coverage Δ

...cards/product_cards/smooth_product_card_found.dart
0.00% <0.00%> (ø)

...ds/product_cards/smooth_product_card_template.dart
2.70% <ø> (ø)

...mooth_app/lib/data_models/product_query_model.dart
3.22% <0.00%> (ø)

...mooth_app/lib/pages/personalized_ranking_page.dart
0.00% <0.00%> (ø)

...pp/lib/pages/product/common/product_list_page.dart
0.00% <0.00%> (ø)

...p/lib/pages/product/common/product_query_page.dart
0.43% <0.00%> (-0.03%)
:arrow_down:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


What's the easiest/cleanest way to work with class names?

From reading the docs, it seems like Glamor prefers not using class names, and instead pushes people to use <div css={ ... } or <div ...css({ ... }). As far I can you can get a class name by forcing the resulting object .toString(), but that leaves me doing things like:
let classes = `${className || ''} ${STYLES.separator}`
if (bottomMargin) classes += ` ${STYLES.bottomMargin}`
if (topMargin) classes += ` ${STYLES.topMargin}`

Previously with CSS Modules I was using the classnames package, but I think even to make that work I'd still need to do some ugly manual toString-ing, like:
const classes = classnames(className, `${STYLES.separator}`,
  [`${STYLES.bottomMargin}`]: bottomMargin,
  [`${STYLES.topMargin}`]: topMargin,
})

Am I missing something? Is there any nicer way? It would make using Glamor awesome if so.

As a side thought about interoperability...
The focus on the more "magic" syntaxes (eg. the data-object-spreading approach or the custom-react-prop approach) seems unfortunate to me since standardizing around class name strings or inline style objects seems like the way to guarantee interoperability with the greater ecosystem of React (or non-React) components, since they are never going to assume a Glamor dependency (nor would you want them to).
I saw that css={ ... } to className="..." conversion was added in https://github.com/threepointone/glamor/issues/95 but even that feels like too much magic in my opinion, since no one is going to know that from just looking at it.
Totally possible that I could be missing something that the current approach offers, if so would love to learn it!

Is this what you're looking for? (using computed property keys)
const rule1 = css({
  boxSizing: 'border-box',
  borderWidth: 0,
  borderStyle: 'solid',
  margin: 0,
  padding: 0,
  font: 'inherit',
  textTransform: 'inherit',
  textDecoration: 'none'
});

const classes = classNames({
  [rule1]: true,
  [css({fontSize: 50,marginRight: 5})]: true
});

console.log('classes', classes);
// css-lbcvys css-11iolps

Hey @ChristopherBiscardi thanks for the example. That is essentially what I'd like to be possible, yup! Unfortunately, as far as I can tell, because of the way that Glamor defaults to returning an object that can be spread across a low-level JSX node, such as...
{
  'data-css-1l8ukt1': ''
}

...that example you provided actually doesn't work. Instead you'd end up with:
console.log('classes', classes)
// ""

And to fix it you would have manually force the returned object to a string, like...
const classes = classNames({
  [`${rule1}`]: true,
  [`${css({fontSize: 50,marginRight: 5})}`]: true
});

console.log('classes', classes);
// css-lbcvys css-11iolps

...which I think is super unfortunate, purely because the "default" case is optimized for a non-standard way of creating/sharing/defining styles.
If Glamor were to return class name strings by default, you could do simple things like:
const classes = classNames({
  rule1,
  css({fontSize: 50,marginRight: 5}),
  props.isBold && css({ fontWeight: 'bold' }),
});

that example you provided actually doesn't work

That's strange since I copied it out of a working codepen. Can you provide more details as to why it isn't working for you?

Ah yup, you're right, sorry, with [computed]: true it works because it coerces them. What I tested that didn't work was the nicer, terser version:
const glamor = require('glamor')
const classnames = require('classnames')

const styles = {
  button: glamor.css({
    background: 'gray'
  }),

  active: glamor.css({
    background: 'red'
  }),
}

const isActive = true

const classes = classnames(
  styles.button,
  isActive && styles.active
)

console.log('classes', classes)
// ""

Perhaps to be more clear, toString is defined on styles returned from css(), which the object initializer spec says toString is called on if a computed property key is an object. Thus it's like calling css({}).toString()), which yields the css classname.
styles.button in your example will be an object and is not a computed property so it doesn't get toStringd. The approach you're taking looks a lot like the aphrodite glamor package. Maybe you want that?

Thanks! Yeah I understand about .toString() needing to be called—although I didn't realize that it was implicitly called on computed properties, although that makes sense.
What I'm talking about at a deeper level is arguing that from a architecture/design point of view, Glamor should put a stronger emphasis on class names (and/or potentially style dictionaries, although they are slightly harder to work with and will probably be less performant) because they are the portability "standard" of styling components. Right now there are a few different places that you end up having to be aware of the not-quite-classname-like behavior of Glamor when working with other libraries:

When using something like classnames.
When passing styles into a third-party component you have to be sure to stringify first.
I'm sure there are more...

Which is the cause of not dealing in a common primitive.
Or put more directly:

What are the benefits from the current data-* design choice? And are they significant enough that they are worth extra code and mental overhead for common use cases for users, in addition to extra bloat in the generated output to account for both data-* and class names, since class names are always required when crossing library boundaries? I'm my opinion they aren't, but I might not have the full picture.

I'm especially interested in arguing for this because I think Glamor seems like it has a lot of potential in terms of its simplicity, and with the css`...` syntax coming up.

Like you mentioned, I could use the Aphrodite-mimicking export from Glamor, but I'd personally argue for all of the X-like exports to be removed because they only serve to clutter the core library and make it feel more like a random experimental project without direction. I wouldn't want to depend on them heavily.

First, the original question -
let classes = `${className || ''} ${STYLES.separator}`
if (bottomMargin) classes += ` ${STYLES.bottomMargin}`
if (topMargin) classes += ` ${STYLES.topMargin}`

would be simpler as
let classes = css(
  rule,
  STYLES.separator,
  bottomMargin && STYLES.bottomMargin,
  topMargin && STYLES.topMargin
)

assuming all of these are glamor rules, of course.
on a broader note, I don't actually agree that classnames should be what the community standardizes.  The idea of having a rule as an opaque object is fairly core to the idea, letting me do stuff like WeakMap caches, composition, etc. the classnames issue can be fixed by aliasing it with a version of the function which recognizes glamor rules (and the computed keys syntax works well in a pinch).
Personally, I don't really feel the pain of non-readable classnames anymore. Unlike regular css (and I feel this is key to the issue), it's trivial to know where the definition of a rule happened by just looking at its 'callsite'. I do plan on making a debug helper to read current values from rules (I currently use cssFor(), but would prefer an object to inspect instead)

I was trying to use class-names to combine styles from a public class-based style-override API (parents may not want to use glamor) and ran into this.
For that case, one option is to just avoid the problem -- instead of combining classNames, use the spread syntax for your glamor styles, and classNames for the parent overrides.
const myStyles = css({ color: 'red' });

const MyComponent = ({ className }) =>

...
;

There may be specificity gotchas with this approach since class and attribute selectors have equal precedence, but it's working for us so far.

nothing actionable here, closing, feel free to reopen if there's more to discuss.


Update browserlist

We may want to just keep this ticket open so we remember to come back to this every so often.
Run npx browserslist@latest --update-db and commit any changes to the package-lock.json file.

I just ran this but it didn't really change anything in terms of targets.  I'm going to close this because we're likely to not need to adjust it until we move into Nuxt3 which will have a lot fresher stuff.


how to remove a record ?

seems there is not a method to remove a record ..

It's in the documentation.
Person.find({ surname: "Doe" }).remove(function (err) {
    // Does gone..
});

thanks ,Ieemm !!


Failed to check FreeRDP file descriptor

freerdp version:
This is FreeRDP version 2.3.2 (2.3.2)
Ubuntun18.0.4
when I run this command:
xfreerdp /d:AD-OCLOUD /u:administrator /p:Admin@123 /v:<IP_ADDRESS> /app:"c:\windows\system32\mspaint.exe"  &
for the first time, it is successful to open the mspaint.exe, but for the second time, it fails, the output is:
ocloud@ocloud-KVM:~$ [22:07:42:980] [93118:93119] [INFO][com.freerdp.core] - freerdp_connect:freerdp_set_last_error_ex resetting error state
[22:07:42:980] [93118:93119] [INFO][com.freerdp.client.common.cmdline] - loading channelEx rdpdr
[22:07:42:980] [93118:93119] [INFO][com.freerdp.client.common.cmdline] - loading channelEx rdpsnd
[22:07:42:980] [93118:93119] [INFO][com.freerdp.client.common.cmdline] - loading channelEx cliprdr
[22:07:42:980] [93118:93119] [INFO][com.freerdp.client.common.cmdline] - loading channelEx rail
[22:07:43:334] [93118:93119] [INFO][com.freerdp.primitives] - primitives autodetect, using optimized
[22:07:43:338] [93118:93119] [INFO][com.freerdp.core] - freerdp_tcp_is_hostname_resolvable:freerdp_set_last_error_ex resetting error state
[22:07:43:338] [93118:93119] [INFO][com.freerdp.core] - freerdp_tcp_connect:freerdp_set_last_error_ex resetting error state
[22:07:43:361] [93118:93119] [WARN][com.freerdp.crypto] - Certificate verification failure 'unable to get local issuer certificate (20)' at stack position 0
[22:07:43:361] [93118:93119] [WARN][com.freerdp.crypto] - CN = WIN-LA60UQ5C6VC.ad.ocloud.com
[22:07:44:171] [93118:93119] [INFO][com.freerdp.gdi] - Local framebuffer format  PIXEL_FORMAT_BGRX32
[22:07:44:171] [93118:93119] [INFO][com.freerdp.gdi] - Remote framebuffer format PIXEL_FORMAT_RGB16
[22:07:44:177] [93118:93119] [INFO][com.winpr.clipboard] - initialized POSIX local file subsystem
[22:07:44:180] [93118:93119] [INFO][com.freerdp.channels.rdpsnd.client] - [static] Loaded fake backend for rdpsnd
[22:07:44:181] [93118:93119] [WARN][com.freerdp.client.x11] - xf_Pointer: Invalid appWindow
[22:07:44:222] [93118:93119] [WARN][com.freerdp.client.x11] - xf_Pointer: Invalid appWindow
[22:07:44:222] [93118:93119] [WARN][com.freerdp.client.x11] - xf_Pointer: Invalid appWindow
[22:07:44:236] [93118:93119] [WARN][com.freerdp.client.x11] - xf_Pointer: Invalid appWindow
[22:07:44:237] [93118:93119] [WARN][com.freerdp.client.x11] - xf_Pointer: Invalid appWindow
[22:07:45:285] [93118:93119] [WARN][com.freerdp.client.x11] - xf_Pointer: Invalid appWindow
[22:07:45:306] [93118:93119] [WARN][com.freerdp.client.x11] - xf_Pointer: Invalid appWindow
[22:07:45:341] [93118:93119] [WARN][com.freerdp.client.x11] - xf_Pointer: Invalid appWindow
[22:07:45:345] [93118:93119] [WARN][com.freerdp.client.x11] - xf_Pointer: Invalid appWindow
[22:07:45:360] [93118:93119] [WARN][com.freerdp.client.x11] - xf_Pointer: Invalid appWindow
[22:07:45:371] [93118:93119] [WARN][com.freerdp.client.x11] - xf_Pointer: Invalid appWindow
[22:07:45:407] [93118:93119] [WARN][com.freerdp.client.x11] - xf_Pointer: Invalid appWindow
[22:07:45:635] [93096:93097] [INFO][com.freerdp.core] - ERRINFO_DISCONNECTED_BY_OTHER_CONNECTION (0x00000005):Another user connected to the server, forcing the disconnection of the current connection.
[22:07:45:635] [93096:93097] [ERROR][com.freerdp.core] - rdp_set_error_info:freerdp_set_last_error_ex ERRINFO_DISCONNECTED_BY_OTHER_CONNECTION [0x00010005]
[22:07:45:721] [93096:93097] [WARN][com.freerdp.client.x11] - xf_Pointer: Invalid appWindow
[22:07:45:874] [93118:93119] [INFO][com.freerdp.core] - rdp_set_error_info:freerdp_set_last_error_ex resetting error state
[22:07:45:002] [93118:93119] [WARN][com.freerdp.client.x11] - xf_Pointer: Invalid appWindow
[22:07:46:264] [93118:93119] [WARN][com.freerdp.client.x11] - xf_Pointer: Invalid appWindow
[22:07:46:305] [93118:93119] [WARN][com.freerdp.client.x11] - xf_Pointer: Invalid appWindow
[22:07:46:311] [93118:93119] [WARN][com.freerdp.client.x11] - xf_lock_x11_:	[1] recursive lock from xf_UpdateWindowArea
[22:07:46:394] [93118:93119] [WARN][com.freerdp.client.x11] - xf_lock_x11_:	[1] recursive lock from xf_UpdateWindowArea
[22:07:46:946] [93118:93119] [WARN][com.freerdp.client.x11] - xf_lock_x11_:	[1] recursive lock from xf_UpdateWindowArea
[22:07:46:954] [93118:93119] [WARN][com.freerdp.client.x11] - xf_lock_x11_:	[1] recursive lock from xf_UpdateWindowArea
[22:07:46:971] [93118:93119] [WARN][com.freerdp.client.x11] - xf_lock_x11_:	[1] recursive lock from xf_UpdateWindowArea
[22:07:46:987] [93118:93140] [ERROR][com.freerdp.channels.rail.client] - Unknown RAIL PDU order reveived.
[22:07:46:987] [93118:93140] [ERROR][com.freerdp.channels.rail.client] - rail_order_recv failed with error 13!
[22:07:46:987] [93118:93119] [ERROR][com.freerdp.core] - rail_virtual_channel_client_thread reported an error. Error was 13
[22:07:46:987] [93118:93119] [ERROR][com.freerdp.core] - checkChannelErrorEvent() failed - 0
[22:07:46:987] [93118:93119] [INFO][com.freerdp.client.common] - Network disconnect!
[22:07:46:987] [93118:93119] [ERROR][com.freerdp.client.x11] - Failed to check FreeRDP file descriptor

well, ERRINFO_DISCONNECTED_BY_OTHER_CONNECTION is quite clear, is it not?

Let me make it clear，
1 first,  run the command, mspaint opened, then  I close  the mspaint windows;
2 after a while, I want to open mspaint again, but fails.
it seems  the rdp connection is not closed at first time, but  how?  I can just close the mspaint window.
How to close the connection?

@ligangcc that is a server setting, in RAILS mode the RDP connection stays open until the server closes it (or freerdp is manually closed)
There is no (reliable) way to detect when RAILS should close the client (there are many windows always open, like the keyboard language switch, some tray icons, ...)
FreeRDP always creates a new connection and does not reuse existing instances, so what you see is that the server kept the last session open and you can not connect because of that. Either close the client manually or adjust the connection close timeout on the server


Hotfix: Corrected typo in logdie call

Coverage remained the same at 100.0% when pulling e207aa1814e6e15bd5d009702410a75d3abec682 on hotfix/correct_typo_in_logdie into 8f6e708229c14a248d530f3480b6fae77989c4ed on master.

Approve

Coverage remained the same at 100.0% when pulling ee7e26d873c0ded0ff6b62d416bc0a21647463dd on hotfix/correct_typo_in_logdie into 8f6e708229c14a248d530f3480b6fae77989c4ed on master.

Approved


V0.4 siqi Ready for merge

Coverage increased (+1.3%) to 80.096% when pulling e0d15446ba2ececf61cfa0d2e5a57081d0f7373c on V0.4-siqi into b4cce69854ef830406716a00e107e2e5cf432de0 on master.

Coverage increased (+1.3%) to 80.096% when pulling b0dd57a7ad59a5d60508e20cf9dbf03d6fb9874a on V0.4-siqi into b4cce69854ef830406716a00e107e2e5cf432de0 on master.

Coverage increased (+1.3%) to 80.096% when pulling 1180e3582ac5392cd5b16bdb909e517c7cd6f4b7 on V0.4-siqi into b4cce69854ef830406716a00e107e2e5cf432de0 on master.

Coverage increased (+1.3%) to 80.096% when pulling a3ed29cec4794580578b663a4a46c78c49f3928c on V0.4-siqi into b4cce69854ef830406716a00e107e2e5cf432de0 on master.


check spelling

check spelling

Thanks. I will apply some changes but not all. Javadoc is indeed the tool to generate documentation. But it's common to refer to all docs as Javadocs too. In fact, Google renders many results for this term (including for other open-source projects).

Cherry picked changes. The dockbook was left as-is since we are moving to asciidoctor anyway.


deps: update diagram-js to 7.4.0

adjust to changes in implicit root ID

Looks good now! I added some tests to have the implicit root cases covered.


s3_endpoint documentation and example for #78

Please see #92 for PR.

Q
A

Bug fix?
no

New feature?
no

API breaks?
no

Deprecations?
no

Related tickets
Additional documentation for #78 (213e9a8) and banzaicloud/banzai-charts#528

License
Apache 2.0

What's in this PR?
I added additional documentation for the s3_endpoint variable and will be submitting another PR to the banzaicloud/banzai-charts.
Why?
I want to use Wasabi instead of Amazon, and noticed the feature existed but appeared undocumented.

 Deleting in favor of #93

Please forgive the crazy back-n-forth.


Create speculative APIs for each components

What
Design a public API for each of our components as a base for discussion with the community and other teams. This includes:

methods
events
new options (including callbacks)

Why
This should facilitate and speed up discussions around what's useful to services.
Who needs to work on this
Developers
Who needs to review this
Developers
Done when
We've gone through our components and designed a public API for each of them as a base for discussion:

[ ] Accordion
[ ] Button
[ ] Character Count
[ ] Checkboxes
[ ] Error summary
[ ] Exit This Page
[ ] Header
[ ] Notification Banner
[ ] Radios
[ ] Skip Link
[ ] Tabs

We've set up a Padlet board to discuss with our community which features each component could offer.


Introduce Pull Request Reviewers

Introduces a generated set of code owners to ensure a good contribution experience.
For more details/timelines (internal): go/codeowners

@lyoung-confluent Does it has to go in -post branches. These are released branches and we generally don't make changes unless it's an exceptional case.

This will be effective when we branch out next.


Web workers to avoid browser freezing with large network

Hi,
I am having browser freezing issues when loading large networks (about 200 nodes and 500 edges), when physics is on.
I am adding nodes and edges to VisJs Datasets progressively, but I think the delay happens when turning the physics on and off to scatter the nodes.
I think web workers would be beneficial to speed up the calculations. Do you have any plans of adding them?
Alternatively, is there any workarounds I can try, like a different physics engine or some offline node positioning  algorithms that you recommend?
Thanks,
Christian

Hi @chriscarex,
unfortunately everything is sync and changing it would be a huge endeavor and also a massive breaking change for a lot of people. This has to be well though and someone has to invest a lot of time into this as everything just assumes that as soon as a function executes, everything is done, just shoving it to a web worker would break a lot of code.
I would really like to see this happen though.

My page also freeze when adding nodes to the network progressively. Any recommendations?


Transition from Travis CI to GitHub Actions

As previously mentioned we should transition from Travis CI to GitHub actions.
Hopefully this works well. 🤞

I just noticed that two builds were triggered instead of only one, I am going to fix this.

I just noticed that two builds were triggered instead of only one, I am going to fix this.

Should be good to go now.

Should be good to go now.


Django Form Admin and Taggit Through Model

Hi,
I am using Taggit library. I need to use some additional fields like featured_tag and hence I created a through model. Now, I need to modify Django Admin for the same. So, on front end, I have used VueJs to create assign which tag is featured, but, how we would handle in BackEnd form while saving. As I understand, we need to call save_m2m() function, but how we will pass these addtional attributes. Any thoughts ?

Dupe of #706


Problems when installing cudamat on windows

Hi,
I have issues when installing cudamat on windows. I am using windows 10 64 bits, with python 2.7.12 (Anaconda 4.2). This issue is kind of similar to #69 but I get different errors.
First of all, I installed CUDA and have a functional nvcc command. I have tried to install cudamat wither by pip or directly running setup.py and both failed with the same kind of errors.
First, as it is suggested on https://wiki.python.org/moin/WindowsCompilers that one should use the same C++ compiler version as the python version, as I am using python 2.7 I try to install with visual C++ 9. This gives the following error:
Microsoft (R) C/C++ Optimizing Compiler Version 15.00.30729.01 for x64
Copyright (C) Microsoft Corporation.  All rights reserved.

tmpxft_00001e0c_00000000-1.cpp
nvcc warning : The 'compute_20', 'sm_20', and 'sm_21' architectures are deprecated, and may be removed in a future release (Use -Wno-deprecated-gpu-targets to suppress warning).
nvcc fatal   : Host compiler targets unsupported OS.
error: command 'C:\\Program Files\\NVIDIA GPU Computing Toolkit\\CUDA\\v8.0\\bin\\nvcc.exe' failed with exit status 1

Then, I read here http://docs.nvidia.com/cuda/cuda-installation-guide-microsoft-windows/index.html#axzz4T75SPmzM that actually only C++ 11 onwards is supported. Therefore I tried with C++ 14 and then I get a different error:
nvcc warning : The 'compute_20', 'sm_20', and 'sm_21' architectures are deprecated, and may be removed in a future release (Use -Wno-deprecated-gpu-targets to suppress warning).
cudamat.obj
cudamat_kernels.obj
LINK : fatal error LNK1181: cannot open input file 'ID=2.obj'
error: command 'C:\Program Files\NVIDIA GPU Computing Toolkit\CUDA\v8.0\bin\nvcc.exe' failed with exit status 2
Is there anything that can be done? or it is just simply not going to work and I have to migrate to python 3.5? (but then I would get the problems as #69 I guess).
Has anybody been able to correctly install cudamat on windows?
thanks!

I just tried the solution on #57 (compiling manually). Compiling works well. when I try to import cudamat however, I get the following which I dont understand because libcudamat.dll is present in the cudamat directory. Any idea?
I just found that I am actually working on python 3.5 ! (I activated a virtual env from somebody else and I did nto know it was using 3.5 ver.)

import cudamat
Traceback (most recent call last):
File "", line 1, in
File "C:\Users\Otto\Downloads\cudamat-master\cudamat\cudamat.py", line 19, in
cudamat = load_library('libcudamat')
File "C:\Users\Otto\Downloads\cudamat-master\cudamat\cudamat.py", line 17, in load_library
basename + ext))
File "C:\Program Files\Anaconda2\envs\phy\lib\ctypes_init.py", line 425, in LoadLibrary
return self.dlltype(name)
File "C:\Program Files\Anaconda2\envs\phy\lib\ctypes_init.py", line 347, in init
self._handle = _dlopen(self._name, mode)
OSError: [WinError 126] No se puede encontrar el módulo especificado

OK sorry, it was just a silly path problem. Now I can import correctly. I will try to test to see if it is really working.

Tests run OK. It means that the manual compiling solved the problem.
For the records, I am using python 3.5 on windows 10 64 bit.
After installing CUDA, I installed C++ 2015 from here:
http://landinghub.visualstudio.com/visual-cpp-build-tools
after that, I used one of the prompts on C:\Program Files (x86)\Microsoft Visual C++ Build Tools, I think it was either the Visual C++ 2015 x86 x64 Cross Build Tools Command Prompt, or native 64 or MSBuild, dont remember anymore.
After that, I compiled manually as indicated on #57, created a cudamat folder on site packages and moved the necessary elements there. This seems to do the trick.

Just for the record, can you also try compiling with #79? A simple pip install http://github.com/f0k/cudamat/archive/simplify-compile.zip would do (with --user and/or --upgrade --no-deps --force-reinstall as needed). Thank you!

the building and installation seems to work. However, importing cudamat does not work, it seems that it fails to load the shared libraries

import cudamat
Traceback (most recent call last):
File "", line 1, in
File "C:\Program Files\Anaconda2\envs\phy\lib\site-packages\cudamat_init_.py", line 1, in
from .cudamat import *
File "C:\Program Files\Anaconda2\envs\phy\lib\site-packages\cudamat\cudamat.py", line 15, in
cudamat = load_library('libcudamat')
File "C:\Program Files\Anaconda2\envs\phy\lib\site-packages\cudamat\cudamat.py", line 13, in load_library
basename + sysconfig.get_config_var('SO')))
File "C:\Program Files\Anaconda2\envs\phy\lib\ctypes_init.py", line 425, in LoadLibrary
return self.dlltype(name)
File "C:\Program Files\Anaconda2\envs\phy\lib\ctypes_init.py", line 347, in init
self._handle = _dlopen(self._name, mode)
OSError: [WinError 126] No se puede encontrar el módulo especificado

Thank you for testing. Can you edit your C:\Program Files\Anaconda2\envs\phy\lib\site-packages\cudamat\cudamat.py, so load_library becomes:
def load_library(basename):
    here = os.path.dirname(__file__) or os.path.curdir
    fn = os.path.join(here, basename + sysconfig.get_config_var('SO'))
    print(fn)
    print(os.path.listdir(here))
    return ct.cdll.LoadLibrary(fn)

Try importing the library again. It should now give us some hints what's going wrong.

Hmm, today I cannot reproduce the problem, cudamat is installing fine. I also re-installed and seems OK.

back from Xmas vacation, I reinstalled Anaconda, and then reinstalled cudamat with pip as you suggested. It imports fine, and tests run OK. So I guess it is confirmed that it is working as expected!

AttributeError                            Traceback (most recent call last)
 in ()
----> 1 import cudamat
C:\Users\Carlos\Anaconda3\lib\site-packages\cudamat_init_.py in ()
----> 1 from .cudamat import *
2 from . import learn
C:\Users\Carlos\Anaconda3\lib\site-packages\cudamat\cudamat.py in ()
15     return ct.cdll.LoadLibrary(fn)
16
---> 17 _cudamat = load_library('libcudamat')
18
19 _cudamat.get_last_cuda_error.restype = ct.c_char_p
C:\Users\Carlos\Anaconda3\lib\site-packages\cudamat\cudamat.py in load_library(basename)
12     fn = os.path.join(here, basename + sysconfig.get_config_var('SO'))
13     print(fn)
---> 14     print(os.path.listdir(here))
15     return ct.cdll.LoadLibrary(fn)
16
AttributeError: module 'ntpath' has no attribute 'listdir'

>      12     fn = os.path.join(here, basename + sysconfig.get_config_var('SO'))
>      13     print(fn)
> ---> 14     print(os.path.listdir(here))
>      15     return ct.cdll.LoadLibrary(fn)

It should be os.listdir. But anyway, this is not part of the cudamat code, I guess you added this yourself?
Ah, I see, you corrected it afterwards and posted the output.

C:\Users\Carlos\Anaconda3\lib\site-packages\cudamat\libcudamat.pyd
['cudamat.cu', 'cudamat.py', 'cudamat_kernels.cu', 'learn.cu', 'learn.py', 'learn_kernels.cu', 'libcudalearn.cp36-win_amd64.exp', 'libcudalearn.cp36-win_amd64.lib', 'libcudalearn.cp36-win_amd64.pyd', 'libcudamat.cp36-win_amd64.exp', 'libcudamat.cp36-win_amd64.lib', 'libcudamat.cp36-win_amd64.pyd', 'rnd_multipliers_32bit.txt', '__init__.py', '__pycache__']

So it tries to load libcudamat.pyd because sysconfig.get_config_var('SO') is set to .pyd. During compilation, though, sysconfig.get_config_var('SO') seems to have been set to .cp36-win_amd64.pyd. It seems you installed cudamat with a different Python interpreter than you used afterwards. You can try copying the files and rename them accordingly, but chances are that the two interpreters are not compatible. Try to figure out which interpreter you used for compiling and which one you used for importing cudamat. At the very least, they should produce the same output for import sysconfig; print sysconfig.get_config_var('SO').


RPP Updates

CentOS 7 Build

@LakshmiKumar23 need this to be merged for the CI to pass - https://github.com/ROCmSoftwarePlatform/rocJenkins/pull/445

@kiritigowda Trying to build a centos docker to test this. Using (this docker)[https://github.com/GPUOpen-ProfessionalCompute-Libraries/MIVisionX/blob/master/docker/centos7/level-4.dockerfile]. Unable to build
 You could try using --skip-broken to work around the problem
Error: Package: hsakmt-roct-devel-202204<IP_ADDRESS>200-65.el7.x86_64 (ROCm)
           Requires: libdrm-amdgpu
 You could try running: rpm -Va --nofiles --nodigest
The command '/usr/bin/scl enable devtoolset-7 echo -e "[ROCm]\nname=ROCm\nbaseurl=https://repo.radeon.com/rocm/yum/rpm\nenabled=1\ngpgcheck=1\ngpgkey=https://repo.radeon.com/rocm/rocm.gpg.key" >         /etc/yum.repos.d/rocm.repo && yum -y install --nogpgcheck rocm-dev' returned a non-zero code: 1

@LakshmiKumar23 use this docker - compute-artifactory.amd.com:5000/rocm-plus-docker/compute-rocm-rel-5.2:52-centos-7.7-stg1 and follow the setup instructions

@LakshmiKumar23 use this docker - compute-artifactory.amd.com:5000/rocm-plus-docker/compute-rocm-rel-5.2:52-centos-7.7-stg1 and follow the setup instructions

@kiritigowda Followed the steps on this docker. Issue with clang
cmake -DBACKEND=HIP ../
-- The CXX compiler identification is unknown
CMake Error at CMakeLists.txt:27 (project):
  The CMAKE_CXX_COMPILER:

    clang++

  is not a full path and was not found in the PATH.

  Tell CMake where to find the compiler by setting either the environment
  variable "CXX" or the CMake cache entry CMAKE_CXX_COMPILER to the full path
  to the compiler, or to the compiler name if it is in the PATH.

-- Configuring incomplete, errors occurred!
See also "/var/tmp/boost_1_72_0/rpp/build/CMakeFiles/CMakeOutput.log".
See also "/var/tmp/boost_1_72_0/rpp/build/CMakeFiles/CMakeError.log".

@LakshmiKumar23 use this docker - compute-artifactory.amd.com:5000/rocm-plus-docker/compute-rocm-rel-5.2:52-centos-7.7-stg1 and follow the setup instructions

@kiritigowda Followed the steps on this docker. Issue with clang
cmake -DBACKEND=HIP ../
-- The CXX compiler identification is unknown
CMake Error at CMakeLists.txt:27 (project):
  The CMAKE_CXX_COMPILER:

    clang++

  is not a full path and was not found in the PATH.

  Tell CMake where to find the compiler by setting either the environment
  variable "CXX" or the CMake cache entry CMAKE_CXX_COMPILER to the full path
  to the compiler, or to the compiler name if it is in the PATH.

-- Configuring incomplete, errors occurred!
See also "/var/tmp/boost_1_72_0/rpp/build/CMakeFiles/CMakeOutput.log".
See also "/var/tmp/boost_1_72_0/rpp/build/CMakeFiles/CMakeError.log".

@LakshmiKumar23 -- Need to setup clang
sudo yum update
sudo yum install git cmake3
yum install llvm-toolset-7-clang llvm-toolset-7-clang-analyzer llvm-toolset-7-clang-tools-extra
scl enable llvm-toolset-7 bash

@LakshmiKumar23 use this docker - compute-artifactory.amd.com:5000/rocm-plus-docker/compute-rocm-rel-5.2:52-centos-7.7-stg1 and follow the setup instructions

@kiritigowda Followed the steps on this docker. Issue with clang
cmake -DBACKEND=HIP ../
-- The CXX compiler identification is unknown
CMake Error at CMakeLists.txt:27 (project):
  The CMAKE_CXX_COMPILER:

    clang++

  is not a full path and was not found in the PATH.

  Tell CMake where to find the compiler by setting either the environment
  variable "CXX" or the CMake cache entry CMAKE_CXX_COMPILER to the full path
  to the compiler, or to the compiler name if it is in the PATH.

-- Configuring incomplete, errors occurred!
See also "/var/tmp/boost_1_72_0/rpp/build/CMakeFiles/CMakeOutput.log".
See also "/var/tmp/boost_1_72_0/rpp/build/CMakeFiles/CMakeError.log".

@LakshmiKumar23 -- Need to setup clang
sudo yum update
sudo yum install git cmake3
yum install llvm-toolset-7-clang llvm-toolset-7-clang-analyzer llvm-toolset-7-clang-tools-extra
scl enable llvm-toolset-7 bash

@kiritigowda  Yes, I ran all the steps in the instructions

scl enable llvm-toolset-7 bash

@kiritigowda Retried the build. It works. Must have missed a step last time. Can be merged


[🐛 BUG]: Environment variables in services are lowecased

No duplicates 🥲.

[X] I have searched for a similar issue in our bug tracker and didn't find any solutions.

What happened?
This sample config
version: '2.7'

service:
  test:
    command: php test.php
    env:
      XDEBUG_MODE: off

test.php file contents:L
<?php

var_export(getenv());

rr serve will output environment variables in php process. You'll see xdebug_mode instead of XDEBUG_MODE.
Version (rr --version)
2.10.6
Relevant log output
No response

fixed by: https://github.com/roadrunner-server/service/commit/b41e9e59e6b9b46d9a112b1941ca5e4ee6b4ecd7


DEC-1009: Metadata ordering bug

Why: When viewing an item in beehive, the order of the metadata does not reflect the order specified in the collection configuration
How: Added a configuration store and changed all pages that render items to load this store and use it to order the metadata

👍

👍


Add keep-alive timeout (#464)

This includes the libuv timer stuff in #1056 plus the keep-alive code.
There's a ~5% perf hit. I'm trying to improve that.
#464
cc @halter73 @mikeharder @davidfowl @Tratcher

Thanks @halter73 for the suggestion about counting seconds between ticks instead of querying time. That fixed the perf regression :+1:

⌚

@halter73 Using TestServer and I'm tentatively addressing your concern about long standing tests in the last commit (d09230e).

Travis test failure on OS X (https://travis-ci.org/aspnet/KestrelHttpServer/jobs/157181697) is not related to this change since it's showing up in other branches (https://travis-ci.org/aspnet/KestrelHttpServer/jobs/157157166, https://travis-ci.org/aspnet/KestrelHttpServer/jobs/155406648 - in the latter it was the other test in the class that failed).
Still waiting for a 🚢  or more feedback.
⌚

:shipit:


Standardize tune description format

We should have a common format for describing tunes (series of beeps) across the different implementations in this repository. Extensive searching was done, a simple widespread standard was not found.
Following is proposed:

Simple text file
Each line represents a beep or a pause

Column one is a positive integer number of milliseconds
Column two is a positive integer frequency in Hz, or 0 which represents silence
Columns are separated by a space

Line ending is unix format (\n, but \r\n should not cause an error when reading file)
File extension is .tune
Consider adding a silence at the end so that looped playback sounds good :-)

Example for mary_had_a_little_lamb.tune:
400 2673
400 2349
400 2093
400 2349
400 2673
400 2673
790 2673
400 2349
400 2349
790 2349
400 2673
400 3136
790 3136
400 2673
400 2349
400 2093
400 2349
400 2673
400 2673
400 2673
400 2673
400 2349
400 2349
400 2673
400 2349
790 2093
400 0

Work plan:

[x] Convert existing tunes into this format, save to tunes/ folder
[ ] Update each implementation to accept a .tune file on the command line / stdin or however else

[x] Using _mm_stream_si128
[ ] Using counter and threads
[x] In Javascript

[x] Update run instructions so users know to supply the song file

Related: #1

@fulldecent, what was wrong with the human-readable ".song" format described in #1 & #24?

@rocketinventor Nothing is wrong with those ideas. For the "standardized" format, the simplest one is preferred.
Going forward I think we will also have a few parsers to bring, say, morse code or midi into this format.

@fulldecent It would probably be a good idea to have start, stop, and end of line symbols. While these are not 100% necessary, they would still be useful to improve the resiliency of the parser against poorly formed files, and code. In addition, start and end tokens would allow for arbitrary text to be added before, and after the actual song data.
Making 0 0 or 000 0 the official end token would be trivial to implement (in the example it is 400 0) and does not violate any of the current (proposed) specs.

Right now the 400 0 is just a pause so that the tune can be repeated with the correct pause between plays.

Oh. That should probably be mentioned in the specs, then.

@fulldecent Please update the proposal message to indicate that the JS port has been updated to use this new spec.

@rocketinventor Thank you, one check for the good guys

Just added this documentation to the tunes/ folder and added two sample tunes.
87dbedb9bf0f4c79389300d6a664c7e94d50b30e
797e8ec77397d52b261d205755da6e3f8ca40b65

Tune format now working for c implementation with 0090934aa5c36717b4f5b08d1f2e6e03af4b88ec

It should be noted that this format is distinct from GRUB_INIT_TUNE.

This is equivalent to the GRUB_INIT_TUNE when using a TEMPO of 60,000 (bpm)

make one for rickrolling people


Add 2.5K support and address issue #36

https://github.com/TomW1605/EDAutopilot/commit/2a350c852adb9793f0c3b445011e58a2bf924f63 is more workaround than actual fix, but it does seem to resolve the issue, I more-or-less successfully completed a hands-off 52 jump trip with this in place and the only issue I noted was a handful of times we just never found the navball and the ship just kept pitching up forever.  The autopilot never crashed, at least, which I think is an improvement.
Lots of other ways this could be handled, but this seemed to be the smallest potential impact and probably works fine if the future holds some changes in the "can't find the ball" logic.

sorry i somehow completely missed this. unfortunately i have changed the code base so much that i can't easily merge it. i need get it committed then i can try and merge it. would it be possible for you to make a PR with just the resolution changes?

Sure, I've separated the 2.5K support into #3 and the other bit, if still relevant later, I can rebase and resubmit separately.


Can the application support beacon simulators?

The app / library will work with every advertising frame, as long as the advertised data matches the beacon specification.
You can see / adjust the performed checks in the meetsSpecification method (e.g. in IBeaconAdvertisingPacket).
I'd say it depends on the beacon simulator application if they manage to advertise valid iBeacon or  Eddistone frames. A good application to inspect advertising data is nRF Connect.


AWS Lambda with Python 3.12 not supported

How do you use Sentry?
Sentry Saas (sentry.io)
Version
AWS Lambda Version 101
Steps to Reproduce
The latest Sentry AWS Lambda layer (101) does not support Python 3.12 which was released Dec 2023.
Supported versions section
While viewing a lambda function in the AWS Console

Select the "Code" tab
View the "Layers" section at the bottom
Verify that the "SentryPythonServerlessSDK" layer is at version 101 which is the latest version at time of writing.
Note that the layer compatible runtime does not list python 3.12

Expected Result
The documentation and the layer's compatible runtimes should list python 3.12 as a supported version.
Actual Result
The latest version of python supported is 3.11
AWS Console

Doc

Thanks @tinycogio. We don't have a timeline for this yet -- we'll keep this issue open to track progress on this.

Has there been any progress on this issue? We recently set up this integration and one of the key workloads that we want to monitor is on Python 3.12, but we didn't realise that this version was unsupported until after setting things up.

@amrishparmar No progress yet – we are busy with other projects at the moment. We are happy to accept and review community PRs if anyone would like to contribute.


get the list of all function calls that leads to the current function from the stack

get the list of all function calls before the current function from the stack.
Thereby making it more easier to understand the workflow of tinygrad, both for beginners and even for the contributors.
This function is now added in at file location tinygrad/tinygrad/get_function_stack.py
If this location seems to be worrisome, please specify the file location which is most suitable.

Not better. This is generic Python stuff that probably doesn't even belong in tinygrad


[SED] Fix Commissioning with Long Idle time

Commissioning fails with long Sleep period because device goes into Idle mode prior to completing the commissioning.
Fix that by always enabling Active mode at the start of the commissioning process and always disabling it at the end. Without any condition whatsoever.

Just a note: This doesn't quite implement what I think it was aiming to implement.  The goal was "stay in active mode while we are commissioning".  What actually got implemented is "stay in active mode until commissioning completes or commissioning window closes, whichever happens first".  But that second thing can still be while we are in the middle of commissioning.


Move GDPT

Implements #158

Nice! I just had a quick look and it seems like this already makes use of the pre-computed schur decomposition? This would be very nice.

Yes, it's already using precomputed Schur vectors. Can I merge it?

Sure, go ahead.

Do we generally make sure we fall back to brandts when to SLEPSc is installed, whenever .compute_schur is called? This would be important.

That behavior is implemented within msmtools.


MUI Select components unexpectedly growing modal

Affected Components: SQFormDropdown, SQFormMultiselect, Maybe SQForm(Async)Autocomplete
The MUI Select components seems to be expanding with the options selected thus growing the flex item and the entire flex-box. I'm seeing this in multiple places on some applications and obviously within storybook. Hopefully we can force it to not grow at all and stick to the width it starts at.
Loom: https://www.loom.com/share/6cb8d8ffba3546c4b74a1afac1e0a04c

The reason why the MultiSelect grows and the TextField doesn't is because, when options are added, the text you're seeing is rendered inside a div, whereas the text in the TextField is in an actual text input which has that inherent text-overflow-without-expanding behavior. The parent Dialog container isn't set to width: 100%, so the MultiSelect div will grow until the Dialog hits its max-width limit.
The only options I see with how it's currently set up are to either set an explicit width on the MultiSelect so it can't grow/shrink when changed, or set the Dialog to be full width.

I don't necessarily have an opinion but something definitely needs to be done about it. It's breaking modals left and right from what I can see.

So I've been looking at this for a bit. It does seem like the best way to handle this is that the consumer should define a max width for the component. However, if a component is smaller because it's on a smaller screen it'll still expand but only to max width.
I really don't think there's anyway reason the component should be changing size. But MUI's select examples are doing similar things as the issues mentioned here.

Is there a particular reason why we allow it to shrink to fit the content? As opposed to setting it to be full width then letting the consumer specify a max width?

It is fullWidth, we pass fullWidth={true} to the select component.

It is fullWidth, we pass fullWidth={true} to the select component.

Sorry, I meant the Dialog component

Well what's crazy is that we can set the maxWidth with the maxWidth prop on a dialog but that's completely ignored. It'll still expand to the moon and back. Regardless, the select components expand in and outside of a dialog. So making a change on the SQFormDialog wouldn't fix any issues on SQForm or the stepper.

@20BBrown14
This is an issue with the Multiselect component that we need to address. Living inside a Dialog certainly makes this a more glaring issue but the issue is within the CSS of the Multiselect.
MUI provides the recipe to achieve what we want which is the text-overflow behavior we see with our Text Input.
Here's the source code example. They specify a minWidth and a maxWidth and I think the values they used seem pretty reasonable.
https://material-ui.com/components/selects/#MultipleSelect.js

Looking over the code for our MuiSelect component I would've expected us to use
<FormControl className={classes.formControl}>
Can you attempt to add FormControl and see if any regressions occur?

Using a min/max width still allows for the select div to grow if the starting width is lower than the max. That's a weird UX thing my opinion.
Using formcontrol like they've done is basically the same as just setting a min/max width. It also puts the label in the dropdown as a placeholder then moves it up when it's focused. You can see that behavior on MUI's select docs (linked above). So I'm not sure we want that.
Aside from that using formcontrol breaks our "theme" as you can see below, the form control expands over the other components. So if we wanted to use formcontrol we'd need to update all of our components to use.

Using a min/max width still allows for the select div to grow if the starting width is lower than the max. That's a weird UX thing my opinion.
Using formcontrol like they've done is basically the same as just setting a min/max width. It also puts the label in the dropdown as a placeholder then moves it up when it's focused. You can see that behavior on MUI's select docs (linked above). So I'm not sure we want that.
Aside from that using formcontrol breaks our "theme" as you can see below, the form control expands over the other components. So if we wanted to use formcontrol we'd need to update all of our components to use.

FWIW the FormControl just needs width: 100%; to fix that. I think the overflow is caused by FormControl having display: inline-flex; by default, which I think means its width is based on its content rather than the available space, or something like that. And the label animation thing can be disabled with shrink={true} on InputLabel

FWIW the FormControl just needs width: 100%; to fix that.

Sorry, maybe I'm not understanding. That addition on top of, or solely, still allows the select to grow to the maxWidth which is less than the starting width. it does fix the overlapping form elements, though. Is that what you were referring to when you said "that"?

FWIW the FormControl just needs width: 100%; to fix that.

Sorry, maybe I'm not understanding. That addition on top of, or solely, still allows the select to grow to the maxWidth which is less than the starting width. it does fix the overlapping form elements, though. Is that what you were referring to when you said "that"?

Yeah, the overlapping part


Allow the DynamoDB table root names to be overridden

Also added short versions to the other options. Tested against a local dynamodb instance using the infx in service-routing-dev branch.

LGTM


Increasing the number of worker threads/core to be used

Hi,
Currently run of Tagger on my 24 core CPU uses 8-12 core instead of the full 24.
gensim gives an option of utilizing the full cores of CPU.
Is there an option possible for tagger as well? This would really speed it up.

Hi,
Actually in my experience, using a single thread was always faster than using multi-threading. The reason for this is that the tagger is not batched, I guess.

@kewlcoder  : As tensorflow/theano computes everything on the symbolic graph, each time the graph is fed with data, the calculation has been done on gpu/cpu. For smaller batch, transferring time of data to gpu/cpu bus bottleneck the overall computation time. So if you have smaller batch single thread will be best. Even sometimes codes run faster on CPU than a titan X gpu for this reason.

Yes for me the tagger was faster on CPU than on GPU (I had K40 at the time). The tagger could definitely be batched, but I did not do it as the datasets were small enough and training can already be done in a few hours.


[tests-only] Retry listing roles if the response body is invalid

Description
While listing the user roles via settings API, sometimes the response body is incomplete causing the json decoder to throw an error. This PR has implemented retrying for certain numbers if the response body is not valid json.
Related Issue

Fixes https://github.com/owncloud/ocis/issues/6524

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] Technical debt
[x] Tests only (no source changes)

Checklist:

[ ] Code changes
[ ] Unit tests added
[ ] Acceptance tests added
[ ] Documentation ticket raised:

CI is failing with https://drone.owncloud.com/owncloud/ocis/28993/27/8
 Scenario Outline: search files by stop words when clean_stop_words is disabled                                                         # /drone/src/tests/acceptance/features/apiSearch/contentSearch.feature:68
 Examples:
      | dav-path-version |
      | old              |
        Failed step: And the search result of user "Alice" should contain only these files:
        The number of elements in the response doesn't matches with expected number of elements
        Failed asserting that 0 matches expected 1.


[T2A2][T07-A1]Low Zheng Heng Henry

Add generic type specification in getLinesInFile()
Add generic type specification in splitByWhitespace()

Ready for review

@e0003801

i would encourage you to be more critical when you try to improve the code quality.
in general, pay more attention to coding standards violation.
some useful ones include checking how conditional statements are written, naming conventions etc.,
this PR is quite minimal in that sense


Support multiple formats and crs

@tomkralidis That's basically my first ever github pull request. I only worked with gitlab or gitea until now. Please take a look if I missed anything.
Overview

adds support for comma separated formats ('Format1,Format2,Format3')
adds support for comma separated spatial reference systems ('crs1,crs2,crs3')

Related Issue / Discussion
#617
Additional Information

multiple formats and crs can be strings containing just the required data or containing multiple values, comma separated
multiple values will be mapped to multiple elements in the CSW response

Contributions and Licensing
(as per https://github.com/geopython/pycsw/blob/master/CONTRIBUTING.rst#contributions-and-licensing)

[x] I'd like to contribute this feature to pycsw. I confirm that my contributions to pycsw will be compatible with the pycsw license guidelines at the time of contribution.
[ ] I have already previously agreed to the pycsw Contributions and Licensing Guidelines

@tomkralidis I'm sorry, there was a stupid bug I pushed in the first commit. Checks have been passed fine now.

Thanks @Rastopapola , some comments:

we'll need docs added to the new behaviour of the pycsw:Format and pycsw:CRS fields in https://docs.pycsw.org/en/latest/administration.html#existing-repository-requirements
the PR supports the "existing database" workflow.  I think we also need to support ingest.  This means demonstrating that pycsw can ingest a sample Dublin Core document with multiple fields, store it into the core model, and finally be able to output accordingly
it would be valuable to have the tests updated based on 2.

the PR supports the "existing database" workflow. I think we also need to support ingest. This means demonstrating that pycsw can ingest a sample Dublin Core document with multiple fields, store it into the core model, and finally be able to output accordingly

Yes, I see. I will take care of this tomorrow.

News on this PR can be found here


Allow unsetting shortcut_context.

shortcut_context is not set by default, and I do not see any reason it should not be unsettable.
Fixes #57188

Thanks!


upgrade to guava 17.0

This is a blocker for us to upgrade: https://issues.apache.org/jira/browse/HADOOP-10101
Until this is addressed we can't use Guava 15+. When the patch finally makes it in (targeted for 3.0), we will likely want to use the latest Guava (currently at 18).
An issue will be how we support hadoop 2.x and 3.0 - we'll need a conditional guava dependency.
In the meantime, we may as well continue our use of guava 14.0-rc1.  The reason for originally specifying 17.0 is because that is now the dependency of GeoServer version 2.5.3 and above. Prior to 2.5.3, GeoServer depends on guava 11.0.1 which is incompatible with GeoWave.  We are now excluding guava from our GeoServer library, which means that guava 17.0 will be the only one on this webapps classpath, which is the right thing for us within GeoServer 2.5.3 and above.  However, anyone interested in using GeoServer 2.5.2 and below will have to come up with some interesting way of bundling guava (it may just be as simple as removing the guava exclusion so that we bundle GeoWave with guava 14.0-rc1, but the GeoServer webapp will have both guava 11.0.1 and 14.0-rc1 on the classpath so its basically introducing a classloader race condition).
Bottom-line, lets upgrade guava with hadoop 3.0, and we will not support GeoServer version 2.5.2 or below without someone workaround guava versioning.


Sign rendering code seems to have an inverted condition

Hi,
I was briefly looking into why trouble fails to render the correctly configured sign icons and instead uses the first letter of the severity instead.
It occured to me that this condition is wrong
https://github.com/folke/trouble.nvim/blob/91cab162e69ee46296c264438e27b61051b8c880/lua/trouble/format.lua#L66
since the else branch uses vim.fn.sign_getdefined() which does exist in nvim 0.10. Indeed flipping the condition makes trouble render the icon instead of the letter just fine.
However I'm not sure there's no more correct way to do version checks since that first branch is probably supposed to be used for all older versions instead of all versions not being 0.10 and I'm not sure how those nvim feature flags work.

https://github.com/folke/trouble.nvim/issues/449

It seems rather odd to declare a non-deprecated API, literally everyone uses, obsolete and break existing configs for no apparent reason. gitsigns, lualine, trouble v2 and other plugins work just fine with sign_define, only trouble v3 looks rather dated now.
With your pointer and the help of https://neovim.io/doc/user/diagnostic.html#diagnostic-signs I managed to adjust the config to support old and new style but since I couldn't find any tutorials or example configs using the "recommded" API, I think it will take a while until the world catches up...

Allright, I'll see if I can just also use the old values if needed.

I think I fixed it

Doesn't look like it, with the latest main and after backing out the new configuration:

Can you check again?

Looking good now. 👍🏻


chore: Fixed typo

Fixed typo.

Please see https://github.com/microsoft/vscode/wiki/How-to-Contribute#spell-check-errors

@gjsjohnmurray Hello, John. Nice to meet you.
I've read the document that you've provided and verified that this change is safe.
No need to worry. Contribution is a gift, not a chore.
I've spent some part of my short life to make VSCode a better product.
You're free to throw my gift into trash and continue using VSCode without my fix if that brings you joy.


404 on fuchsia cipd package

Fuchsia engine v2 build fails the fuchsia precache build with a 404 on a cipd package:
https://ci.chromium.org/p/flutter/builders/try/Linux fuchsia_precache/54749?

The relevant fuchsia build is https://ci.chromium.org/p/flutter/builders/prod/Linux linux_fuchsia/3

Seems like the cipd package was not uploaded or it was not tagged correctly.
flutter/fuchsia - git_revision:905222c11f06d613f4a2dd5b9567fe4bc3882861

\cc @zanderso

This requires moving this logic:
https://cs.opensource.google/flutter/recipes/+/main:recipes/engine/engine.py;l=1129
To:
https://cs.opensource.google/flutter/engine/+/master:tools/fuchsia/build_fuchsia_artifacts.py?q=tools%2Ffuchsia%2Fbuild_fuchsia_artifacts.py&ss=flutter
And add support for the following magic parameters:

REVISION
CHROOT_TPM_DIR

Part 1: adding support for the magic variables have landed here: https://flutter-review.googlesource.com/c/recipes/+/51042


try once more to fix flakey tests

closes #790 (hopefully)

the flakiness seems to be due to the timeout being hit before one full pass through the loop happens. with this change, there will always be at least one pass.


Ignore Multiple Folders? [Bug]

I can't seem to find a way to ignore either multiple folders or files. There was nothing in the readme to reference so I'm trying here.

There isn't really a way to do this right now. I would consider this a feature request since this behavior wasn't intended.


aperture can act as a transducer

I suppose that sometime in the future, almost every list functions will be able to act like transducers. This is one step in that direction.

Cool!

Thank you, @gonzaloruizdevilla.

:clap:


NO-ISSUE: Synchronize From Upstream Repositories

The downstream repository has been updated through the following upstream commit:

Date
Commit
Author
Message

2024-09-10 17:41:06
operator-framework/operator-controller@d09f325
Tayler Geiger
Add provided ServiceAccount documentation to drafts (#1232)

upstream commit list

The vendor/ directory has been updated and the following commits were carried:

Date
Commit
Author
Message

2024-08-30 00:02:12
openshift/operator-framework-operator-controller@de07dac
dtfranz
UPSTREAM: : Add OpenShift specific files

2024-08-30 00:02:12
openshift/operator-framework-operator-controller@1ea0bd3
Alexander Greene
UPSTREAM: : Drop commitchecker

2024-08-30 00:02:13
openshift/operator-framework-operator-controller@b707d7c
AOS Automation Release Team
UPSTREAM: : Updating ose-olm-operator-controller-container image to be consistent with ART Reconciling with https://github.com/openshift/ocp-build-data/tree/4022cd290f00a44d667dda03f2d78d84a488c7ed/images/ose-olm-operator-controller.yml

2024-08-30 00:02:13
openshift/operator-framework-operator-controller@1b659a8
Mikalai Radchuk
UPSTREAM: : update owners

2024-08-30 00:02:14
openshift/operator-framework-operator-controller@3d5a478
Brett Tofel
UPSTREAM: : Add pointer to tooling README

2024-08-30 00:02:14
openshift/operator-framework-operator-controller@868725a
Mikalai Radchuk
UPSTREAM: : Disable Validating Admission Policy APIs downstream

2024-08-30 00:02:14
openshift/operator-framework-operator-controller@37f3bfb
AOS Automation Release Team
UPSTREAM: : Updating ose-olm-operator-controller-container image to be consistent with ART for 4.16 Reconciling with https://github.com/openshift/ocp-build-data/tree/6250d54c4686a708ca5985afb73080e8ca9a1f7f/images/ose-olm-operator-controller.yml

2024-08-30 00:02:15
openshift/operator-framework-operator-controller@0f1acae
Mikalai Radchuk
UPSTREAM: : Enable Validating Admission Policy APIs downstream

2024-08-30 00:02:15
openshift/operator-framework-operator-controller@23e9ae2
Ilias Rinis
UPSTREAM: : manifests: set required-scc for openshift workloads

2024-08-30 00:02:16
openshift/operator-framework-operator-controller@40e7e0b
AOS Automation Release Team
UPSTREAM: : Updating ose-olm-operator-controller-container image to be consistent with ART for 4.17 Reconciling with https://github.com/openshift/ocp-build-data/tree/4c1326094222f9209876f06833179a1b9178faf7/images/ose-olm-operator-controller.yml

2024-08-30 00:02:16
openshift/operator-framework-operator-controller@1ba4dc4
everettraven
UPSTREAM: : add everettraven to approvers+reviewers

2024-08-30 00:02:17
openshift/operator-framework-operator-controller@0033ca7
everettraven
UPSTREAM: : add openshift kustomize overlay

This pull request is expected to merge without any human intervention. If tests are failing here, changes must land upstream to fix any issues so that future downstreaming efforts succeed.
/cc @openshift/openshift-team-operator-runtime
/cc @openshift/openshift-team-operator-ecosystem

/label tide/merge-method-merge

https://github.com/openshift/operator-framework-operator-controller/pull/135#issuecomment-2343792186
I didn't find any refs to these groups in openshift/release... not sure where they are coming from...

I didn't find any refs to these groups in openshift/release... not sure where they are coming from...

They are coming from the bumper itself.

/override ci/prow/openshift-e2e-aws-techpreview

/approved
/override ci/prow/openshift-e2e-aws-techpreview

/approve

/cc @openshift/openshift-team-operator-framework

https://github.com/openshift/operator-framework-tooling/pull/50 to fix https://github.com/openshift/operator-framework-operator-controller/pull/135#issuecomment-2343792186

/retitle OPRUN-3510: Synchronize From Upstream Repositories

/jira refresh


updating installation instructions and adding subsections

I updated the installation instructions in the README and under For Users section added several subsections for Arch Linux, Other Distros and Install using Cargo and also added your package to the aur and now it can be easily installed with this command:
paru -S tplay-git

Also you can view the package here.
Also one more suggestion, my bad, I forgot to put it in the issues but also write a workflow file this will allow you for automated testing for an example on how to write it. you can take a look at my project's workflow located here.

Thanks for doing this!
Currently, this won't work out of the box, as you noticed in #4 , due to #3 .

:: Calculating conflicts...
:: Calculating inner conflicts...
Repo (8) yt-dlp-2023.03.04-1  onetbb-2021.8.0-2  cblas-3.11.0-2
opencv-4.7.0-7  mujs-1.3.3-1  rubberband-3.2.1-1  uchardet-0.0.8-1
mpv-1:0.35.1-4
Aur (1) tplay-git-0.3.1.r104.7636250-1
As you can see, it uses mpv 0.35, which is incompatible with the libmpv-rs crate used in the dependencies.
Unfortunately, the current solution described in #3 is a workaround based on a temporary crate.
I don't think it's possible to select a crate depending on the external dependency (mpv).
It should be solvable with feature flags/build scripts, I'll create a branch to check this out

let's hold off this pull request until the crate can reliably be installed and run (with working audio). Removing the external dependency to mpv would be nice


Create Profile - 2nd page

When I run the build for http://webreflections.azurewebsites.net/create
The Set up runs but I cannot advance to the 2nd page.  Hitting next does nothing.
Any ideas?

Same for me.  Running Windows 10, Visual Studio 2015, and have a Logitech HD Pro C920 webcam.

Anyone?

Any solution yet?

Updating the NPM version on the server did the trick.

Thank you soooo much


CI Fixes

ci: bump

:tada: This PR is included in version 1.0.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Fix dynamic plugin test for OCP 4.15

What type of PR is this?

Uncomment only one  /kind line, and delete the rest.
For example, > /kind bug would simply become: /kind bug

/kind bug
/kind cleanup
/kind failing-test
/kind enhancement
/kind documentation
/kind code-refactoring

What does this PR do / why we need it:
Have you updated the necessary documentation?

[ ] Documentation update is required by this PR.
[ ] Documentation has been updated.

Which issue(s) this PR fixes:
Fixes #?
Test acceptance criteria:

[ ] Unit Test
[ ] E2E Test

How to test changes / Special notes to the reviewer:

/test all

/retest

/lgtm
/approve

/cherry-pick v1.10

Ignore this comment. I am trying out cherry-pick bot.
/cherry-pick v1.10


[Friend V2] Friend uses NFC for pairing ($500)

Is your feature request related to a problem? Please describe.
I want to be able to pair my Friend by using NFC instead of bluetooth discovery.
Describe the solution you'd like

A characteristic that sets the NFC value to the device id.
An update to the connection page to connect by using NFC instead of scanning for devices.

Connection, reconnection logic should remain the same, but the devices list should simply include the id of the device you NFC to.

I want to take this task, need a little more information, do I also need to add NFC connection functionality to the Friend Firmware or just on Flutter App.
Thanks!

Is there a particular NFC antenna we should use?

Not working on this but iOS does not support NFC (OOB) pairing last I saw

Submitted initial PR #610
We can make iOS and Android pairing work using App Links which will pickup on the URL link and pull into app and start pairing, otherwise you end up on website with a lost and found style message and setup instructions. This is how most airtags etc work in the easy way.

We are missing antennas on devices so this is also something that needs to be resolved, but will not need code/pin/overlay change for that.

NFC feature (firmware) completed. https://github.com/BasedHardware/omi/pull/610.
App side will be developed later.


cross origin font requests failing

Fonts are unable to load from the cdn referenced in the dist fabric.css - https://appsforoffice.microsoft.com/fabric/fonts/
CSS3117: @font-face failed cross-origin request. Resource access is restricted.
File: SegoeUI-Regular.eot

I think this is the same issue as #73

Thanks for letting us know. We are working on it.

@pascalberger are you still seeing issues?  I've tried a couple of times on different environments and fonts seem to be downloading fine.  Wondering if when you tried some configs were still propagating. Please let us know if things are working for you.

@LezaMax  this is working now. Thanks!

Icons are now generally shown, but there are quite a lot missing. I've opened #79 for this


support obfs4 transport

This pull request wraps TOR's obfs4 plugin as a transport layer for gost. Gost could benefit from this feature since it makes the proxy more resistant to third parties' interference and active probing.
Configuration is through the query string with keys including cert, iat-mode, and state-dir (optional, default is current dir). When the server runs at the first time, cert is generated automatically and iat-mode is set to 0 if not specified otherwise. Then the client just need to copy and paste the URL from server's stdout.
To reset the server's profile (so that it can have a new packet length distribution), remove files starting with obfs in the state-dir.

I am currently refactoring the code (see the branch refactor), the structure has changed greatly compared to the previous.
I will merge this feature after the refactoring is done. Thanks a lot.


[5.0] Sema: Request the layout for generic parameters if there is a body

Cherry-picked: "Merge pull request #14411 from
aschwaighofer/sema_require_layout_generic_params"
Generic parameters can become sources of metadata types and
conformances. To access them the layout needs to be available to IRGen.
rdar://37086144
SR-6879

@swift-ci Please smoke test and merge

The linux failure also occurs in the vanilla swift-5.0-branch:
Foundation/Data.swift:998:15: error: type 'Data' does not conform to protocol 'Collection'
public struct Data : ReferenceConvertible, Equatable, Hashable, RandomAccessCollection, MutableCollection, RangeReplaceableCollection {
              ^
Foundation/Data.swift:1008:22: note: possibly intended match 'Data.Indices' (aka 'Range<Int>') does not conform to 'Collection'
    public typealias Indices = Range<Int>

For example, here:
https://ci.swift.org/view/swift-5.0-branch/job/oss-swift-5.0-incremental-RA-linux-ubuntu-16_04/140/console


Remove instance local buffer

It doesn't seem needed to have instance local-side effects
especially around a shared buffer (having it exists makes
thread-safety and/or thread-safe clients that much harder to
achieve).

Looks good, thanks for the fix!

I'll wait to tag this and upload it to pypi for a couple days so we can get your other change in as well (no hurry!).


Refresh abicheck

Updates reference tags for both zlib and zlib-ng.
Also:

fix missing --zlib-compat option
don't assume configure is a sh script
fix funky CHOST problem described at https://github.com/zlib-ng/zlib-ng/issues/1219; this deserves careful review.

Note that zlib changed the signatures of two functions (cf. discussion in https://github.com/zlib-ng/zlib-ng/issues/1217 )
so this does not quite pass yet.
Best reviewed as individual commits.

Closing in favor of individual pull requests for each fix.


Resolve issue with navbar elements wrapping

Consider having the nav expanded on load, and then hook into the scroll event that fires on desktop to collapse the nav.


map editor

Pull Request Test Coverage Report for Build<PHONE_NUMBER>1
Details

517 of 982 (52.65%)  changed or added relevant lines in 20 files are covered.
1 unchanged line in 1 file lost coverage.
Overall coverage decreased (-10.5%) to 67.779%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

internal/editor/infrastructure/storages/memstorage.go
19
20
95.0%

internal/server/application/handlers/get_handlers/user.go
0
1
0.0%

cmd/server/main.go
0
2
0.0%

internal/server/application/handlers/ws_handlers/player.go
1
3
33.33%

cmd/editor/main.go
0
3
0.0%

internal/server/domain/game/data/food.go
16
19
84.21%

internal/server/domain/ws/data.go
4
7
57.14%

internal/server/application/server.go
14
18
77.78%

internal/server/domain/game/data/game.go
10
20
50.0%

internal/server/domain/game/routines/handler.go
48
63
76.19%

Files with Coverage Reduction
New Missed Lines
%

cmd/server/main.go
1
0.0%

Totals

Change from base Build<PHONE_NUMBER>1:
-10.5%

Covered Lines:
1584

Relevant Lines:
2337

💛  - Coveralls


Update troubleshoot-managed-grafana.md

The naming limitation is outdated, listing 30 characters while Azure lists 23 characters as the maximum, and indeed this is what the limit is when validating.

Learn Build status updates of commit 0107966:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

articles/managed-grafana/troubleshoot-managed-grafana.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the learn.microsoft.com contributor guidesPost your question in the Learn support channel

@maud-lv,
Can you review the proposed changes?
IMPORTANT: When the changes are ready for publication, add a #sign-off comment to signal that the PR is ready for the review team to merge.
#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

#sign-off


Not seeing errors

Applies To

[X] Notebooks (.ipynb files)
[ ] Interactive Window and/or Cell Scripts (.py files with #%% markers)

What happened?
After updating my VS Insiders version I am no longer seeing notebook error tracebacks. I've disabled all extensions besides Jupyter and Python. I just see a circled X with no output.
Screenshot:

VS Code Version
Version: 1.75.0-insider (Universal) Commit: 9ccc2b3b30c122afe45bc6722bef0e3901fb2806
Jupyter Extension Version
v2023.1.2000202160
Jupyter logs
No text in output panel.
Coding Language and Runtime Version
Python v3.9.6
Language Extension Version (if applicable)
Python v2023.1.10181031
Anaconda Version (if applicable)
No response
Running Jupyter locally or remotely?
Occurs when running either local or remote

looks like the Jupyter extension error renderer is no longer showing anything, you can click the "change presentation" button to switch over to vscode's built-in error renderer

@rebornix - Did you already complete the work to merge the error renderers? Is it expected that Jupyter's is still in that list?

I can reproduce the error but not @amunger's suggested fix:
https://user-images.githubusercontent.com/2721423/213877921-f93bdc8a-d1a0-4898-ad85-685d36c15e69.mov

@thomasaarholt - you have both a regular output and an error output below it. The </> in your capture corresponds to the error output - try clicking that one to select the alternative error renderer.

The alternative, non-default renderer (application/vnd.code.notebook.error) seems to work. Also I want to note that the button clicking placement for the </> symbol seems to be off in my IDE (it is very hard to click on)


document 404 response

Closes #103, #102
PR Includes 404 responses for the retrieve, update, and delete endpoints.
Context
I started working on this thinking that crudrouter manually documented the 200 and 422 response, but I've come to suspect that this is built-into FastAPI - is that right?
Passing responses to fastapi.routing.add_api_route seems to satisfy the wip test I created. I also tested with
Left to do
Before finalizing, I was hoping to run the test suite here @awtkns - I had some trouble setting up some of the test requirements locally 👏   And please let me know if you have any suggestions for improvement.
And if you have any ideas about where to include tests, that would be great! So far I just put a wip test in test_openapi_schema.py which seemed fitting.

Awesome thanks so much for this! I am also tempted to include schemathesis in the test suite to validate the correctness of the generated OpenApi spec.

Hi there :)

I am also tempted to include schemathesis in the test suite to validate the correctness of the generated OpenApi spec.

Awesome! Let me know if you'll need any adjustments on the Schemathesis side for your use case :)

I think this is done btw @awtkns 🙂 Let me know if you want any other changes implemented 👍

Thanks for this @sondrelg 🎉
Changes will be released to version 0.8.3 on merge.

@awtkns I looked at this a little more, and I think my implementation here might be a little bit off. If you're planning to implement schemathesis I'm sure you'll spot it, but leaving this here in case it's helpful.
Looking through these docs, it looks like this is the way to specify responses:
class NotFoundModel(BaseModel):
    detail: str

@router.get('/{item_id}/', status_code=200, response_model=Model, responses={'404': {'model': NotFoundModel}})
async def retrieve(item_id: int) -> Model:
    try:
        return await Model.objects.get(id=item_id)
    except NoMatch:
        raise HTTPException(status_code=404, detail="Item not found")

tl;dr: I think this PR fixed one schemathesis issue: the missing response code, but doesn't fully resolve it, since the model isn't correctly specified.

Not sure how helpful this is, since it's not 1:1 with the crudrouter implementation, but here's a full example of most of the crudrouter endpoints, using ormar, after adjusting them so they pass schemathesis tests:
import logging
from typing import Optional

from asyncpg import UniqueViolationError, CharacterNotInRepertoireError
from fastapi import APIRouter, HTTPException
from ormar import NoMatch
from pydantic import BaseModel

from payments.models import Author

logger = logging.getLogger(__name__)

author_router = APIRouter(prefix='/authors')

class HTTPExceptionMessage(BaseModel):
    detail: str

responses = {
    'not_found': {'404': {'model': HTTPExceptionMessage}},
    'validation_error': {'422': {'model': HTTPExceptionMessage}}
}

@author_router.get('/', status_code=200, response_model=list[Author])
async def get(skip: Optional[int] = 0, limit: Optional[int] = None) -> list[Author]:
    qs = Author.objects.filter()
    if skip:
        qs.offset(skip)
    if limit:
        qs.limit(limit)
    return await qs.all()

AuthorCreateModel = Author.get_pydantic(exclude={'id', 'books'})

@author_router.post('/', status_code=201, response_model=Author, responses=responses['validation_error'])
async def create(author: AuthorCreateModel) -> Author:
    try:
        return await Author.objects.create(**author.dict())
    except UniqueViolationError:
        raise HTTPException(422, detail="Name is taken")
    except CharacterNotInRepertoireError:
        raise HTTPException(422, detail="Invalid encoding")

@author_router.get('/{item_id}/', status_code=200, response_model=Author, responses=responses["not_found"])
async def retrieve(item_id: int) -> Author:
    try:
        return await Author.objects.get(id=item_id)
    except NoMatch:
        raise HTTPException(status_code=404, detail="Item not found")

AuthorUpdateModel = Author.get_pydantic(exclude={'id', 'books'})

@author_router.put('/{item_id}/', status_code=200, response_model=Author, responses=responses['not_found'])
async def update(item_id: int, updated_author: AuthorUpdateModel) -> Author:
    try:
        author = await Author.objects.get(id=item_id)
    except NoMatch:
        raise HTTPException(status_code=404, detail="Item not found")

    await author.update(**updated_author.dict(exclude_unset=True))
    return author

@author_router.delete('/{item_id}/', status_code=204, responses=responses['not_found'])
async def route(item_id: int) -> None:
    try:
        author = await Author.objects.get(id=item_id)
        await author.delete()
    except NoMatch:
        raise HTTPException(status_code=404, detail="Item not found")

Thanks again for the detailed write up @sondrelg! I've created an issue to track this in #105.
Have you written any additional code to setup Schemathesis for testing against the file above? Or are you just doing it from the cli?

Just from the CLI for now 👍


Indent problem with multiple @include

From demo shown, it appears multiple mixins used via @include are not keeping indentation or spacing.
"csscomb.formatOnSave": true,
	"csscomb.preset": {
		"remove-empty-rulesets": false,
		"always-semicolon": true,
		"color-case": "upper",
		"block-indent": "\t",
		"color-shorthand": false,
		"element-case": "lower",
		"leading-zero": true,
		"quotes": "single",
		"sort-order": [
			["$import", "$variable", "$extend", "$include"],
			["..."],
			["$include mq"]
		],
		"sort-order-fallback": "abc",
		"space-before-colon": "",
		"space-after-colon": " ",
		"space-before-combinator": " ",
		"space-after-combinator": " ",
		"space-between-declarations": "\n",
		"space-before-opening-brace": " ",
		"space-after-opening-brace": "\n",
		"space-after-selector-delimiter": "\n",
		"space-before-selector-delimiter": "",
		"space-before-closing-brace": "\n",
		"strip-spaces": true,
		"unitless-zero": true
	},

I figured it out. Apparently the file had CRLF set instead of LF line endings.