Resource requirement tweaks

Solves #106 .
When testing out oncoanalyser against some more difficult samples I ran into quite some erratic behaviour of stages running out of memory.
In general this was caused by the java process allocating 95% of available memory, followed by the java process invoking an external (usually R) script. This would cause the container to go over the memory limits set in the base.config, and the container would be killed by the supervisor (in my case k8s).
Even without an external application (outside of java) being invoked this can happen. The Xmx parameter only sets the size of the heap. The GC operates outside of this. So if the heap fills up, the GC kicks in, filling up the remaining memory, and causing the whole container to go OOM.
Also, some stages, like purple and sage are set to a resource class that is too low for the amount of work they need to do, especially for more difficult samples.
Therefore we don't set the size of the heap higher than 75% of the container memory limits when running hmftools (see pipeline5, second is heap memory and third arg is total memory). After changing this the stability of the pipeline greatly improved. I went from sage+purple pretty much always going OOM to the pipeline completing successfully even for difficult samples.
I also bumped the process requirements for purple, sage, and orange. This brings it more in line with the resource requirements set in pipeline5. These extra resources are necessary to finish more difficult samples in a reasonable of time and without going OOM.

I've made the modifier controlling the proportion of JVM maximum heap space allocated from total available memory configurable for users with defaults defined at the module level.
For processes where large amounts of memory is required I've increased the default proportion from the suggested 75%. Similarly for processes with low amounts of memory allocated, the default has also been increased since the modifier doesn't scale well at the low-end imo.
I'd rather not sacrifice usable memory to optimise where not strictly needed - please let me know if these defaults are a problem with your set up and we can adjust as necessary.
I'll run some tests to ensure these changes to indeed work, let's discuss any points you'd like review in the meantime!

Looks great, I think it's a good solution to make this setting configurable.


issue with nearest_neighbor_tanimoto.py

I received the error:   from sklearn.utils.fixes import sparse_lsqr
ImportError: cannot import name 'sparse_lsqr' from 'sklearn.utils.fixes' while using  nearest_neighbor_tanimoto.py
Please can it be resolved?
Thanks

Hi @matany58,
I'm sorry for not seeing your issue before! Are you still having this error? My best guess is that it might be an sklearn version issue. What versions of Python and sklearn are you using?
Thanks,
Kyle


serve updates

server hardening middleware
traces
metadata- traceid, date, version
gh login
playwright tests
dashboards

req count
dns query count

Added to README


Expire 0.6.x deprecations

Hi @AVHopp, @Scienfitz, we can merge this PR in right before the next release.

Hi @Scienfitz @AVHopp: I've now rebased onto the latest main branch + changed the target branch to release/0.9.0. If you could briefly double-check and accept, I can proceed to merge


HashedValue -> CertificateHashedValue

Motivation
Discussed in eng meeting to rename this to something less generic
Proposal
Rename it
Test Plan
CI

#1964  👈
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @andresilva91 and the rest of your teammates on  Graphite


[WIP] ZXW Diagram implementation

Implement ZXWDiagram.
Moving functions under zx_diagram.jl to utils.jl for reusing them for ZXWDiagram.

Thank you for the pull request; it looks great overall. I have a few minor suggestions. It seems that you have extended the SpiderType and used it in the ZXWDiagram. This extension also makes the original ZXDiagram capable of handling ZXW, resulting in no difference between the new ZXWDiagram. I suggest defining a new spider type for ZXWDiagram only to avoid affecting the previous data structures and algorithms.

Thank you for the pull request; it looks great overall. I have a few minor suggestions. It seems that you have extended the SpiderType and used it in the ZXWDiagram. This extension also makes the original ZXDiagram capable of handling ZXW, resulting in no difference between the new ZXWDiagram. I suggest defining a new spider type for ZXWDiagram only to avoid affecting the previous data structures and algorithms.

This makes much more sense. I will change it accordingly. Thank you!

The latest commits on ADT of Parameters used to represent parameters for spider didn't pass the CI because YaoHIR and CompilerPluginTools are restricting Expronicon to be 0.6.0. I have already made a PR in YaoHIR to partially solve the problem. I am temporarily removing CompilerPluginTools from Project.toml since Roger said he wants to rewrite CompilerPluginTools instead of fixing it.

Hello, @ChenZhao44  I have finished correcting for ZXWDiagram, and Parameter and copied from your branch the implementation of converting a ZXWDiagram to eincode and then to Matrix. I am waiting for @Roger-luo 's comment on my edits on CompilerPluginTools. For the sake of passing CI, I have removed all tests related to CompilerPluginTools.


QIR generator code clean up

Is your feature request related to a problem? Please describe.
There's some ugly code in there...
Describe the solution you'd like
Some specific items:

[obsolete/solved differently] Create a RuntimeFunctionBuilder that generates calls to runtime functions, including all prep code.
[x] Track known information about values, such as lengths of array literals, and use it to simplify code.
[x] In particular, simplify for loop condition evaluation when the loop direction is known.
[x] Avoid materializing tuple literals that are immediately deconstructed, such as let (a, b) = (1, 2);.
[obsolete/will be solved differently] Avoid generating callable values for partial applications that are only used locally.

Describe alternatives you've considered
N/A
Additional context
N/A

@alan-geller I believe the subsequent work I did largely took care of those.
As for the partial applications, as part of implementing support for lambda expressions in Q#, I would like to just move the responsibility to properly lift lambdas and partial applications into a separate compiler pass, and remove the partial application handling from the QIR emission entirely. I'll hence go ahead and close this isse.


Support for controllers

Since by default the Meta Quest 3 ship with and support primarily controllers (with hand tracking as a "do you want to enable it" kind of thing), I think we should support controllers for every interactions.

Nevermind duplicate of https://github.com/Volumetrics-io/MR.js/issues/71


feat: Allow installing plugins

not sure about the whole thing.
also I merged #266 because I can't wait

Is there a plugin on Thunderstore yet to test this against? ^^

Is there a plugin on Thunderstore yet to test this against? ^^

kyurid

As @ASpoonPlaysGames said here, a warning whenever a plugin is installed would be nice.
So like when you install a mod with plugin, it should show some pop-up requiring install confirmation (next to limiting plugin install to dev mode for now)
Thing is, I have no idea how to go Vue/TS -> Rust -> Vue/TS -> Rust without getting super ugly, so not sure if I can help you on that part :/
(Still haven't gotten around to testing btw, sorry about that).

this will be the first and last time I work on the frontend

added a warning to the installing process with an option to cancel the install

so now

the warning popups don't overlay but I did remove the 5 second wait since I have no idea how to implement properly.
the disabled/enabled text in DevView updates correctly now

for the plugins not showing up as installed. I am not sure what would be the best way but I have some ideas.

install a dummy mod in mods with data about plugins that came with it
add a file to plugins folder to keep track of plugins's origin

CI failure on Windows is likely unrelated to this PR and cause by Rust toolchain update, see also #280

I fixed CI issue on main now btw, so just update with main to get it resolved ^^

lol when I tried to fix the merge conflicts it didn't find any.

now the folder is using the thunderstore mod string.
also the early folder creation was an accident and it is now fixed.

I am not including the version because I would be easier when updating the plugin
Also plugins shouldn't be silently not installing

I am not including the version because I think it would be easier when updating the plugin

Eh not really. You technically still have to delete the old mod plugin folder cause the author could've changed the binary name and so simply overriding it might not be enough.
And at that point, whether you delete cat_or_not-kyurid or cat_or_not-kyurid-* doesn't matter much anymore ^^

Also plugins shouldn't be silently not installing

Agreed yet that's what it does rn :P

Eh not really. You technically still have to delete the old mod plugin folder cause the author could've changed the binary name and so simply overriding it might not be enough.
And at that point, whether you delete cat_or_not-kyurid or cat_or_not-kyurid-* doesn't matter much anymore ^^

it does. I would to iterate over the whole plugins folder and parse each folder vs just going straight to a folder.
since you want versions to be included so much, I will another iter chain.

Agreed yet that's what it does rn :P

// warn user
if !plugins.is_empty() {
    // check here instead if we can install plugins so people don't get broken mods without plugins
    if !can_install_plugins {
        Err(ThermiteError::MiscError(
            "plugin installing is disabled; this mod contains a plugin; plugins can be enabled in the dev menu".to_string(),
        ))?
    }
// snip //

if there is a plugin in the plugins folder and plugin installing is disabled then it will propagate this MiscError to the user since this error is getting caught
also there is no mod w/ plugin on thunderstore to test that :P

In the meantime, don't forget to update after #295 got merged ^^

Looks like something broke when merging recent main ._.

should be fixed now

more conflicts >:(
and also it would quite not pog if this doesn't get merged before soon:tm: plugins v3 pr

more conflicts >:(

Had quite some code refactoring going on the last week or so but should be better now ^^
Just resolve merge conflicts and we can do another round of review

I don't want to deal with this anymore


[1378] Improve user profile reservation tables [master]

Resolves #1378 on master

re-add datatables to user profiles
remove datatables gem and replace with vendor assets
implement default sorting for different categories
make general improvements to controller / partial

I think this was reviewed in #1407 but I would appreciate a second review now that we've set it up for master.

This looks good to me!

Great, merging!


Version of secret not required

On this page, it states that

Versions are currently required. When rotating secrets, you will need to update the version in your application configuration.

From my testing, this seems to not be the case anymore.
By simply not specifying the version id in the SecretUri it fetches the latest version
Should this be updated?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 7feaa3d0-7233-a3cb-cb9b-a9a55b1f0d7a
Version Independent ID: f41f9d51-52f8-1f45-1043-1344a3b74458
Content: Use Key Vault references - Azure App Service
Content Source: articles/app-service/app-service-key-vault-references.md
Service: app-service
GitHub Login: @mattchenderson
Microsoft Alias: mahender

@jeppe742 Thanks for the feedback! We are currently investigating and will update you shortly.

No, the note still holds. The behavior is undefined without a version, and there are some rough edge cases that can come up. We are working on full versionless support, but until then we are keeping the note.
#please-close


mini.pairs: python f-strings

Contributing guidelines

[X] I have read CONTRIBUTING.md
[X] I have read CODE_OF_CONDUCT.md
[X] I have updated 'mini.nvim' to latest version

Module(s)
mini.pairs
Description
Support auto pairs for quotes ("'", '"') when typing python f-strings.
Neovim version
0.10.1
Steps to reproduce

nvim -nu minimal.lua
Edit python file
Type the following characters: print(f'

Expected behavior
The quote is autopaired after the f-string.
Actual behavior
No auto-pairing is done.

In 'mini.pairs' the neighborhood pattern is responsible to decide when inserted character expands into full pair. By default, ' has it such that single ' is inserted after any English letter (to be usable inside plain English text) and \. This part won't change.
The most straightforward approach to solve this issue is to update neighborhood pattern for ' only in Python files. For that, create an 'after/ftplugin/python.lua' file inside your config directory and put there these lines:
if MiniPairs ~= nil then
  MiniPairs.map_buf(0, 'i', "'", { action = 'closeopen', pair = "''", neigh_pattern = '[^\\].' })
end

This will create only a buffer-local mapping which will insert single ' only after \. The downside is that it will insert double '' after any letter also.
Closing as not planned.

Thank you for the quick response. I'm assuming I'm able to alter the regex to ignore solely f?

For anyone looking, the above solution didn't work or wasn't satisfactory, so I added the following luasnip to my python files:
    s('f', fmt('print(f{}{}{})', { c(1, { t("'"), t('"') }), i(2), rep(1) })),


Draw all nodes in the tree using gl.TRIANGLES instead of gl.LINES?

I read through this article and thought that this might be a useful option to add in. A few reasons that stick out:

Users may want to increase the overall line thickness for the tree (not just for colored nodes)

This could be particularly important for people with vision impairments

Users may want to be able to "zoom in" on parts of the tree and see the lines / points increase in size. Lines / points aren't impacted by zooming (as far as I can tell), so zooming in can be a bit confusing.

Although I could also see "lines look the same at any zoom level" as being an upside to the current way of doing things...

Plain lines can apparently be inconsistently rendered across different browsers (I don't think this has been a problem, but as more people start using Empress it could be)
This looks closer to what other tree visualizers, e.g. iTOL / ggtree, do by default (so it makes Empress look less different; I guess this could be an upside or a downside depending on how you look at it)

In terms of the code, I think this'd just involve treating each line analogously to how "thick lines" are currently treated. I'm not sure if this will be a performance problem, but if so we could probably make this a configurable option.
I set up a quick and dirty prototype in this branch, where all nodes are treated as thick lines and all points are drawn as squares using two triangles -- it doesn't look that bad, although nodes overlapping is a problem since the line width used here is 5:

The line thickness would need to be adjusted based on the dimensions of the tree (...so, the same problem as #276). On the other side of things, using too small of a thickness results in an invisible-looking tree when the user is zoomed out:

... although using a default color of black, rather than gray, helps a bit:

Anyway, not a big deal -- but something that we may want to consider.

This is an interesting idea, I like it in general so as long as performance isn't impacted for large trees.

This would be nice to have as a parameter users can toggle.
For large trees, this can become a bit expensive. However, as tree get larger, making all lines thicker greatly increases the amount of branch overlap. Even in the moving pictures tree, you can begin to see a fair amount of overlap. For tress > 100,000 nodes, I think we risk the tree looking like a single blob. I choose to only thicken colored branch because it them easier to see for large trees.


Implement PsBasic.Default

Implement PsBasic.Default. This class is a Pass that maintains a collection of login/password pairs and checks a login attempt for correctness.
Fixes #349

@davvd Please find a reveiwer.

@suseika Thanks for your pull request, let me find someone who can review it

@ggajos review this one, please

@Suseika few comments

@ggajos Fixed

@rultor merge please

@rultor merge please

@ggajos Thanks for your request. @yegor256 Please confirm this.

@Suseika I don't like this design. Class User belongs only to PsBasic, but you made it public in the package. Why would anyone else need it? Besides, I would NOT use such a class, but instead find a way to manage these login/passwords inside PsBasic.Default. how about this:
new PsBasic.Default(
  "yegor password urn:test:123",
  "peter super%20secret%20password urn:foo:peter"
)

We don't need to have full identities here, with properties. It's a simple class for basic needs. If someone needs something bigger, he will implement it from scratch

@yegor256 But that wouldn't be a proper object-oriented solution. Why would we hold multiple data items in a single string when we are writing in an object oriented language? That's similar to byte-hacking when integer constants are used instead of enums, and instead of deriving one enum instance from another we'd do some obscure bitwise operations, you know what I mean. If we pack everything in a string, we will need additional logic to validate that string, i.e. that it consists of 3 pieces. On the other hand, User class makes it explicit what you have to provide to create a PsBasic.Default instance. Even with your example you demonstrated that there is an issue with spaces (or whatever character is chosen as a separator).
If we don't need full Identities with properties, how about changing User constructor parameters to User(String login, String password, String urn) with the third parameter being a String instead of Identity?

Class User belongs only to PsBasic, but you made it public in the package. Why would anyone else need it?

To construct instances of PsBasic.Default. I explained above why I think that working with objects is better than working with strings.
I think that your solution would create much more problems than it would solve. So I'll ask before beginning rewriting the class: are you sure you want me to reimplement PsBasic.Default to have Strings instead of Users in its constructor?

@Suseika you're right about OOP approach, but at the same time wrong. Here is why. This User class is not a class really, but just a holder of data. A bag where we carry some other objects. Right? And this is what objects should NOT be used for. This class has no behavior. It just holds three strings. That's totally against OOP.
On the other hand, the text-based approach I suggested is purely data-focused and compact.
If you want to be truly object oriented, this is how your design should look:
new PsBasic.Default(
  new Users(
    new Users.Entry(
      "jeffrey", new User("super secret", new Identity.Simple("..."))
    ).
    new Users.Entry(
      "peter", new User("my password", new Identity.Simple("..."))
    )
  )
)

Then, here is how User should look:
interface User {
  Opt<Identity> authenticate(String password);
}

This is true OOP, but it's so verbose... That's why I suggested strings.

@yegor256 I reimplemented it how you suggested, please take a look.

@Suseika we should not use any dependencies in this project, in compile scope

@yegor256 Done, see the new commit.

@Suseika looks good, but test design is wrong, see my comment. Also, try more complex input data. For example, try password "hey \u20ac"

@yegor256 "hey \u20ac" is not a valid Java string. If you mean password "hey \u0020ac", then PsBasic.Defaultconstructor will fail, because we decided to choose space as a delimiter, and that string is just "hey  ac" string with two spaces instead of one, so it will fail if it is used in"username hey \u0020ac urn:foo:user"`. If you insist on the text-based approach, do you have any suggestions on how to treat spaces in passwords?

Also, try more complex input data.

I made passwords a bit more varying (used punctuation and other languages), is that enough?
Please see the new commit.

@Suseika what if the user wants to use a password with a space inside?

@yegor256 I know, that is exactly my concern. You suggested the text format "username password urn" with spaces as separators, but it clearly is not appropriate for the task. And any character could potentially be used in a password, so that would always be a problem whatever we choose as a separator character. But you don't like the OO approach because it is either too verbose or objects turn out to be data bags. So how do you want me to implement passing users into PsBasic.Default constructor?

@yegor256 I personally would go with the "objects as data bags" approach I was trying to use earlier because it clearly represents what is expected as input to PsBasic.Default and doesn't suffer from the separator character problem. I understand why you don't like it, but it is the best alternative I can come up with.

@Suseika we just have to URL-encode each of three parts and that's it.

@yegor256 I implemented what you suggested. Please see the commits.

@Suseika looks perfect now, one small comment above

@yegor256 Sorry, I simply overlooked this. Of course it has to be private. By the way, shouldn't qulice disallow public static fields? Or are there instances when those can be tolerable? Can I suggest it as a feature to qulice repo?
Fixed, please see above commit.

@Suseika I think it will be too harsh for qulice :)

@rultor try to merge

@rultor try to merge

@yegor256 OK, I'll try to merge now. You can check the progress of the merge here

@rultor try to merge

@yegor256 Done! FYI, the full log is here (took me 9min)

@ypshenychka please, let us know what do you think about this ticket, according to our QA rules

@rultor please deploy

@rultor please deploy

@davvd OK, I'll try to deploy now. You can check the progress here

@rultor please deploy

@davvd Done! FYI, the full log is here (took me 9min)

@ggajos
According to our QA Rules:

The code reviewer found at least three problems in the code.
Comments were mostly about design problems, not cosmetic issues.

Issues found are moslty cosmetic. Try to find at least three major problems while future reviews.
Please confirm that everything is clear and you have no questions regarding this approach.

@ypshenychka I will, thanks.

@ggajos Thank you!

@davvd Quality is acceptable.

@davvd Quality is acceptable.

@ypshenychka thank you, let's try to make it "good" next time

@ggajos I added 10 mins to @ypshenychka (for QA review) in transaction 62124492. Thanks for your contribution, 18 mins was added to your account, payment ID is AP-7N617714DT396041L, 175 hours and 5 mins spent total. review comments (c=3) added as a bonus. +18 to your rating, your total score is +588


Add missing reference symbol to a function parameter.

This is quite a trivial change =)
Could you explain please, what is the status of C++11 features in this project? Are they allowed or not?
If the latter, what do you think about using some of C++11\14\17 features?

This change is

Thanks, change looks fine.
Regarding C++11, I don't see a need to modify the code of such basic library to make use of these new features as they have not been part of the initial design of the library. Requiring C++11 may be problematic for some projects still. It would be easier to discuss about it if you were to make a more specific case of which features you would like to use for the gflags library implementation and why these are needed? Note that in your own project you can of course use C++11.

My English isn't so good actually, so I tried to write a code instead =)
Here - 79832156, is my attempt to simplify some things and even increase code performance.
Of course, this is not a candidate for a merge, but only a demo.
My point is that C++1x features allow to write more clean and effective code.
Last changes to interface of the std::string class allows to avoid making copies, for example.
It seems, that ReparseCommandLineNonHelpFlags function can be reworked without string duplication.
With move semantic we can hold a class objects in containers, instead of pointers.
And range-based-for looks pretty =)
It is obvious, that such wide used library as gflags cannot change compiler requirements at one moment, but I hope that it can be possible in future.
Even the Chromium project now allows many things from C++11 standart and library, which is great, IMHO.


Hook up file upload button on dashboard

implemented withi https://github.com/NickSavage/Zettelgarden/commit/4af18ef829bb4ed4d45a6b8c98f73de2557a8b74


update the deprecated aws-iam-role argument

│ Warning: Argument is deprecated
│
│   with module.altinitycloud_connect_aws.aws_iam_role.this,
│   on .terraform/modules/altinitycloud_connect_aws/iam.tf line 1, in resource "aws_iam_role" "this":
│    1: resource "aws_iam_role" "this" {
│
│ Use the aws_iam_role_policy resource instead. If Terraform should exclusively manage all inline policy associations (the current behavior of this argument), use the aws_iam_role_policies_exclusive resource as well.
│
│ (and one more similar warning elsewhere)

more deprecated arguments:
            3s 832ms                    [bash] ╷
            3s 832ms                    [bash] │ Warning: Argument is deprecated
            3s 832ms                    [bash] │
            3s 832ms                    [bash] │   with module.altinitycloud_connect_aws.aws_iam_role.this,
            3s 832ms                    [bash] │   on .terraform/modules/altinitycloud_connect_aws/iam.tf line 46, in resource "aws_iam_role" "this":
            3s 832ms                    [bash] │   46:   managed_policy_arns = [
            3s 832ms                    [bash] │   47:     "arn:${data.aws_partition.current.partition}:iam::aws:policy/IAMFullAccess",
            3s 832ms                    [bash] │   48:     "arn:${data.aws_partition.current.partition}:iam::aws:policy/AmazonEC2FullAccess",
            3s 832ms                    [bash] │   49:     "arn:${data.aws_partition.current.partition}:iam::aws:policy/AmazonVPCFullAccess",
            3s 832ms                    [bash] │   50:     "arn:${data.aws_partition.current.partition}:iam::aws:policy/AmazonS3FullAccess",
            3s 832ms                    [bash] │   51:     "arn:${data.aws_partition.current.partition}:iam::aws:policy/AmazonRoute53FullAccess",
            3s 832ms                    [bash] │   52:     "arn:${data.aws_partition.current.partition}:iam::aws:policy/AWSLambda_FullAccess",
            3s 832ms                    [bash] │   53:     # for aws ssm start-session
            3s 832ms                    [bash] │   54:     "arn:${data.aws_partition.current.partition}:iam::aws:policy/AmazonSSMManagedInstanceCore",
            3s 832ms                    [bash] │   55:   ]
            3s 832ms                    [bash] │
            3s 832ms                    [bash] │ The managed_policy_arns argument is deprecated. Use the aws_iam_role_policy_attachments_exclusive resource instead.
            3s 832ms                    [bash] ╵


Cannot reproduce the training curves of LLaMA3-simpo-v2

I tried to reproduce the simpo-v2's results on llama-3, but find the training curve is quite different from your released version. I am using 8x A6000 GPUs.
Here is the training config:
# Model arguments
model_name_or_path: meta-llama/Meta-Llama-3-8B-Instruct
torch_dtype: null
attn_implementation: flash_attention_2

# Data training arguments
dataset_mixer:
  princeton-nlp/llama3-ultrafeedback-armorm: 1.0
dataset_splits:
- train
- test
preprocessing_num_workers: 12

# SimPOTrainer arguments
bf16: true
beta: 10
gamma_beta_ratio: 0.3
do_eval: true
evaluation_strategy: steps
eval_steps: 400
gradient_accumulation_steps: 8
gradient_checkpointing: true
gradient_checkpointing_kwargs:
  use_reentrant: False
hub_model_id: simpo-exps
learning_rate: 1.0e-6
log_level: info
logging_steps: 1
lr_scheduler_type: cosine
max_length: 2048
max_prompt_length: 1800
num_train_epochs: 1
optim: adamw_torch
output_dir: outputs/llama-3-8b-instruct-simpo-v2
run_name: llama-3-8b-instruct-simpo-v2
per_device_train_batch_size: 2
per_device_eval_batch_size: 4
push_to_hub: false
save_strategy: "steps"
save_steps: 1000000
report_to:
- wandb
save_total_limit: 20
seed: 42
warmup_ratio: 0.1

Here is the my training curve

And your released training curve

I am wondering how to fix this issue.

It turns out to be the problem of wandb x axis. I need to change it to global steps instead of logging steps in the simpo released wandb curve.

Then the loss curve is reasonable, looks like this:

I also tried using llamafactory instead of the simpo offical codes for the training, it turns out I can get similar training curves for full training. But when changing to lora using llamafactory, with the exact same hyper parameters as full training, the loss curve looks weird. Probably because of lora and full fine-tuning of SimPO/DPO need different hyper parameters. For example, lora might require a higher learning rate.
My curves:
https://wandb.ai/dongfu/huggingface/reports/Reproduction-of-SimPO-V2-of-LLaMA-3-8B-Instruct--Vmlldzo4OTU5Mjk3


Crashing when dot autocompleting

I am using ST 3 on Windows 10.
I have opened a rather large Node project.
When I open a js file and start typing a variable followed by a dot the following error appears.

+1
Sometimes I have this situation (small project, one js file)

+1
and when stop typing few minutes then resume to typing.  will block sublime 3~5 seconds.

On linux too. ST3 with a single js file.

+1
On Ubuntu 14.04 using ST3.

+1
On Ubuntu 14.04 using ST3.

Maybe cut out the +1 spam an provide an easy way to reproduce this instead?

I'll install it again and try to find a repro.


Added info to Node NotReady troubleshooting

Fixes Issue #1391
Description
Added some error messages and advice related to Node NotReady troubleshooting.
Does this change impact docs?

[X] Yes, PR includes docs updates
[ ] Yes, issue opened: #
[ ] No

LGTM!


First look at possible refactor for 3.0.0

This is my first pass on a refactor for 3.0.0 release. It includes all of the functions that I think are necessary for running any one of the three current bots, and also includes two new helper functions, build_bot() and run_until_dead(), both of which drastically cut down on the boilerplate required to build something new.
All feedback is welcome.

One additional change: tests. Perhaps the tests that were written around Config would be suited for use here?

I just wanted to reiterate, this is a really good step in the right direction. Great work!


Dart <-> Rust automated interface generation

This guy made a very very very good Dart<->Flutter FFI automation/generation, but the project is Sponsorware:
https://github.com/thlorenz/rid-examples
I just wanted to make it more visible to more people can sponsor it and thus make it open source.
Thank you and sorry if not the right place

Thank you!
And no worries, Actually me and @thlorenz will be guests on Podcast soon, and we will talk about both projects and how we could improve them!
So be tuned!

@shekohex Which podcast? Sounds interesting

https://podcasts.google.com/feed/aHR0cHM6Ly9mZWVkcy5yZWRjaXJjbGUuY29tLzFlNzE3Y2E4LTk0ZDQtNGEzOS04MDdlLWExNDg4ODRhOTc4Ng/episode/YzJhNWQxMDMtYTY4Ny00Y2E0LWFlMDctYzRjMzI4NzEyNTk1?sa=X&ved=0CAUQkfYCahcKEwjoi5q-9MvzAhUAAAAAHQAAAAAQLA
https://podcasts.google.com/feed/aHR0cHM6Ly9mZWVkcy5yZWRjaXJjbGUuY29tLzFlNzE3Y2E4LTk0ZDQtNGEzOS04MDdlLWExNDg4ODRhOTc4Ng/episode/MDBlNjYzZjYtNWZlMC00NjA1LWExYWItYmMxZTBhMzliMjI1?sa=X&ved=0CAUQkfYCahcKEwjoi5q-9MvzAhUAAAAAHQAAAAAQLA
https://podcasts.google.com/feed/aHR0cHM6Ly9mZWVkcy5yZWRjaXJjbGUuY29tLzFlNzE3Y2E4LTk0ZDQtNGEzOS04MDdlLWExNDg4ODRhOTc4Ng/episode/Y2U5Nzg0MTktNTc2Ny00OTZkLWJlNjgtODFiNmU3MGQ4NjA2?sa=X&ved=0CAUQkfYCahcKEwjoi5q-9MvzAhUAAAAAHQAAAAAQLA


Command-line should have a 't' command for bidirectional transfer

't' should act like 'w', but print out the received bytes.
Suggested in this thread:
http://gameduino2.proboards.com/thread/852/spidriver-running-gameduino3?page=1&scrollTo=2221

Any progress on this?

Is that why I cant seem to get anything out of the Atmel M90E26?  You have to write 8 bits, and it immediately returns 16 bits.  Except I see nothing.
This is from the manual.

On the spidriver, I see the clock being interrupted, between flipping between write and read.

This diagram looks half-duplex, so the right sequence should be:
spicl <device> s w 0x40 r 2 u

It operates like it's half-duplex, but the manual says full-duplex.
The SCK doesn't look the same as the diagram, don't know if that's relevant.

This looks fine - the gaps on SCK are just the inter-byte pauses.

Hmm, one idea... datasheet does say that it expects a '1' bit before the 7-bit register address. So changing 0x49 there to 0xc9 might work?

Good call. That wasn't quite it, but I got it working.  I discovered I have a different chip variation to the manual.  Thanks.

I have same issue - I need to receive same time I'm transmitting (full duplex).


add story location

take location, send location and take location as points, poly and multi problem

solved: 9292681c5f41f5837ac4f998ec55a7f0f5fda502


Pokeyjo patch 1

for lab

Thank you for your submission! We require that all contributors sign our Contributor License Agreement ("CLA") before we can accept the contribution. Read and sign the agreement
Learn more about why HashiCorp requires a CLA and what the CLA includes

0 out of 2 committers have signed the CLA.

[ ] Joseph Brown
[ ] pokeyjo

Joseph Brown seems not to be a GitHub user.
You need a GitHub account to be able to sign the CLA. If you already have a GitHub account, please add the email address used for this commit to your account.
Have you signed the CLA already but the status is still pending? Recheck it.


Write a "Life of a refactoring" guide

Build an animation in a main.m fashion.
Create functions for common patterns.
Turn functions into plans/performers.

Goal is to communicate value of the runtime in simple computer science terms.

This is captured in our examples in the catalog.


Support custom webpack watch options/polling

Describe the feature
Support configurable watch options, which would be passed in places like here: https://github.com/callstack/repack/blob/main/packages/repack/src/server/compilerWorker.ts#L10
Motivation
We use Bazel for our monorepo setup, which utilizes symlinks heavily. Webpack file watching does not respond to file changes through symlinks, so we need to use polling for HMR to work correctly. Right now we are patching the package, like so:
-compiler.watch({}, error => {
+compiler.watch({ poll: 500 }, error => {

Would be great if this was supported natively.
Related Issues

Have you tried passing watchOptions to Webpack config? https://webpack.js.org/configuration/watch/#watchoptions


'Unsupported operator', reason: 'Multi-level object equality link queries are not supported.'

Realm 2.0.3
I am doing a query like (Person is a RLMObject class, redThread is a RLMObject instance):
[Person objectsWhere:"ANY clothes.buttons.thread == %@", redThread];

Sometimes (!?) it blows up with:
2016-11-01 14:16:52.610 CRM-CT-Pro[88780:1625835] *** Terminating app due to uncaught exception 'Unsupported operator', reason: 'Multi-level object equality link queries are not supported.'
Here's the stacktrace i could get:
	1   libobjc.A.dylib                     0x00000001082f121e objc_exception_throw + 48
	2   Realm                               0x0000000106e63f09 _ZL15RLMPreconditionbP8NSStringS0_z + 320
	3   Realm                               0x0000000106eac95e _ZN12_GLOBAL__N_112QueryBuilder14add_constraintINS_15ColumnReferenceEU8__strongP11objc_objectEEv15RLMPropertyType23NSPredicateOperatorTypemT_T0_ + 410
	4   Realm                               0x0000000106e6792e _ZN12_GLOBAL__N_112QueryBuilder22apply_value_expressionEP15RLMObjectSchemaP8NSStringP11objc_objectP21NSComparisonPredicate + 2646
	5   Realm                               0x0000000106e64c40 _ZN12_GLOBAL__N_112QueryBuilder15apply_predicateEP11NSPredicateP15RLMObjectSchema + 2782
	6   Realm                               0x0000000106e64857 _ZN12_GLOBAL__N_112QueryBuilder15apply_predicateEP11NSPredicateP15RLMObjectSchema + 1781
	7   Realm                               0x0000000106e63fd2 _Z19RLMPredicateToQueryP11NSPredicateP15RLMObjectSchemaP9RLMSchemaRN5realm5GroupE + 154
	8   Realm                               0x0000000106e5b56d RLMGetObjects + 221
	9   Realm                               0x0000000106e51669 +[RLMObject objectsWithPredicate:] + 101

Is this legal? Why is it only sometimes working? If it's illegal what are my options?
I did not observe this in 2.0.2. Theorizing a regression or updated policy.

I don't have much time to look into this now, but I think your query can be expressed in other ways that may work:
[Person objectsWhere:"clothes.buttons.thread == %@", redThread];

or
[Person objectsWhere:"SUBQUERY(clothes, $garment, ANY $garment.buttons.thread == %@).@count > 0", redThread];

or
[Person objectsWhere:"SUBQUERY(clothes, $garment, $garment.buttons.thread == %@).@count > 0", redThread];

Although I'm very surprised you're saying your query used to work on 2.0.2 but not on 2.0.3.
Does it consistently fail with that exception, or only occasionally?

I think we don't allow for multi-level object equality link queries that compare against null. It's not immediately obvious to me if this is simply an oversight, or if we're missing support from the query engine. I suspect it's the former.

It's the latter. It's not 100% clear what semantics we want for a comparison against null when one of the intermediate links is itself null.


(PDB-1192) add metrics and logs support

This adds two fields, logs and metrics, to the reports response to contain
logs and metrics passed from Puppet in the terminus. This is part of the ongoing
work to retire consoleDB.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://jenkins.puppetlabs.com/job/platform_puppetdb_intn-sys_pr/740/

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://jenkins.puppetlabs.com/job/platform_puppetdb_intn-sys_pr/741/

Looks like legit acceptance and unit test failures here

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://jenkins.puppetlabs.com/job/platform_puppetdb_intn-sys_pr/742/

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://jenkins.puppetlabs.com/job/platform_puppetdb_intn-sys_pr/743/

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://jenkins.puppetlabs.com/job/platform_puppetdb_intn-sys_pr/744/

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://jenkins.puppetlabs.com/job/platform_puppetdb_intn-sys_pr/747/

@senior passing now

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://jenkins.puppetlabs.com/job/platform_puppetdb_intn-sys_pr/752/

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://jenkins.puppetlabs.com/job/platform_puppetdb_intn-sys_pr/753/

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://jenkins.puppetlabs.com/job/platform_puppetdb_intn-sys_pr/755/

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://jenkins.puppetlabs.com/job/platform_puppetdb_intn-sys_pr/756/

@AJ I think I've addressed all your comments

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://jenkins.puppetlabs.com/job/platform_puppetdb_intn-sys_pr/768/

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://jenkins.puppetlabs.com/job/platform_puppetdb_intn-sys_pr/769/

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://jenkins.puppetlabs.com/job/platform_puppetdb_intn-sys_pr/770/

@pljenkinsro

@pljenkinsro retest this please

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://jenkins.puppetlabs.com/job/platform_puppetdb_intn-sys_pr/773/

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://jenkins.puppetlabs.com/job/platform_puppetdb_intn-sys_pr/786/

@pljenkinsro retest this please

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://jenkins.puppetlabs.com/job/platform_puppetdb_intn-sys_pr/787/

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://jenkins.puppetlabs.com/job/platform_puppetdb_intn-sys_pr/792/

@pljenkinsro retest this please

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://jenkins.puppetlabs.com/job/platform_puppetdb_intn-sys_pr/794/

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://jenkins.puppetlabs.com/job/platform_puppetdb_intn-sys_pr/802/

@kbarber @senior addressed your comments aside from the one to ken above

@pljenkinsro retest this please

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://jenkins.puppetlabs.com/job/platform_puppetdb_intn-sys_pr/803/

@wkalt some niggles, nothing breaking. Looks good.

@kbarber thanks for the comments, just dealt with them

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://jenkins.puppetlabs.com/job/platform_puppetdb_intn-sys_pr/810/

@pljenkinsro retest this please

@kbarber fixed

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://jenkins.puppetlabs.com/job/platform_puppetdb_intn-sys_pr/812/

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://jenkins.puppetlabs.com/job/platform_puppetdb_intn-sys_pr/813/


issue in inference

python infer.py anchor-based --ckpt-path ../models/custom/checkpoint/custom.yml.0.pt
--source ../custom_data/videos/EE-bNr36nyA.mp4 --save-path ./output.mp4
Loading DSNet model ...
Traceback (most recent call last):
File "infer.py", line 66, in
main()
File "infer.py", line 18, in main
model.load_state_dict(state_dict)
File "/home/mossad/aeye/DSNet/venv/lib/python3.7/site-packages/torch/nn/modules/module.py", line 1407, in load_state_dict
self.class.name, "\n\t".join(error_msgs)))
RuntimeError: Error(s) in loading state_dict for DSNet:
Unexpected key(s) in state_dict: "fc_ctr.weight", "fc_ctr.bias".

sorry , my bad , i trained model using anchor-free option and tried to infer with option anchor-based


Unify framed transports with Transport

This crate has some redundancy in order to provide a good abstraction (such as implementing AsyncRead for Fuse). However this does make for a nice api (e.g. FramedWrite cant be a Stream).
I propose transport as a solution to this. Most of the adapters would be inside one struct which would enable us to reuse methods and trait implementations (like Sink and Stream).
You could then make a framed stream with Transport::framed(io, codec) or Transport::framed_write(io, encoder)
The branch is here:
https://github.com/matthunz/futures-codec/tree/transports
You guys have an opinion on this?
@najamelan @cbs228 @Nemo157

Is your new composite type Sink or Stream? It appears that one can only access the underlying streams by reference. While I can see how this approach will streamline things, I am concerned that this will limit the opportunities for:

Compositing Framed with generics that take Sink/Stream; or
Using Framed with futures which consume their Sink/Stream by move.

The latter is a bit rarer these days, thankfully. Many futures take streams by &mut refs. But SinkExt::fanout() will consume a Sink, as does SinkExt::left_sink().
I am actually not sure what the primary use-case is for split I/O types: i.e., types which are AsyncWrite but not AsyncRead, or vice-versa. I've seen tokio calls for splitting a socket into read and write halves, but I'm not sure how people use that. The only use-case I can think of immediately might be a Cursor to a &'static [u8]. If one can make such a thing, it would be rightfully be AsyncRead only.

Oh well I haven't implemented Sink or Stream yet, just have those placeholders to demonstrate.
I definitely agree with you about streams being accessed by reference. I'm hoping to add the methods we have now, just generically in the Transport struct, so we can re use code. Basically the end goal is you should be able to use the library the same, getting an owned stream if needed.
First though the problem I'm still trying to figure out is whether exposing Framed as a type alias of Transport is weird to work with.

Sounds good; I'm glad there will be an option for an owned stream. I look forward to seeing this when it gets closer to finished.
I generally aim to have a small API surface, which exposes as few types as possible to the user. Were you planning on exposing both Transport and various Framed aliases?

I think I don't understand all of the implications of this, but if it makes the impl cleaner and it does not remove functionality, then it should be good!
For solving the issues with being able to move out the stream and sink, it would be good to provide a split method I think. There's still many combinators that take by value, like most methods on futures::StreamExt.


[Assets Availability on Release Tag] Please make downloadable asset for aws-iam-authenticator_TAG_linux_arm64

Hi Team,
Please make downloadable asset for aws-iam-authenticator_TAG_linux_arm64. I am looking for Tag: 0.5.27
In case it won't be possible, please suggest how to obtain specific binaries?
It seems like the set of release assets changed after https://github.com/kubernetes-sigs/aws-iam-authenticator/releases/tag/v0.5.21 (only .zip and .tar.gz are made available)
Thank you

The artefacts für 0.6.20 are also missing.

+1 on this. Broke our EKS deployment docker files as the compiled binaries are missing from latest .5 and .6 releases.

Looks like the GitHub Action failed to publish the artifacts for some reason:
      • release created/updated
           url=https://github.com/kubernetes-sigs/aws-iam-authenticator/releases/tag/v0.6.20
           published=false

https://github.com/kubernetes-sigs/aws-iam-authenticator/actions/runs/8853579891/job/24314748037

In case it takes a while to fix this, can someone document the steps to build from source in the README.

In case it takes a while to fix this, can someone document the steps to build from source in the README.

It looks like we can run the make instruction build-all-bins to build from source:
make build-all-bins

https://github.com/kubernetes-sigs/aws-iam-authenticator/blob/master/Makefile#L90


buildsystem: relax requirement on cmake version

Commit 73cc5089 (Using target_compile_features to specify C++ 11
standard) bumped the required cmake version, from 3.0 to 3.8, so
as to get the definition of target_compile_features().
However, target_compile_features() was introduced in cmake-3.1:
https://cmake.org/cmake/help/v3.1/command/target_compile_features.html
And using cmake-3.1 is indeed sufficient to properly build.
As such, relax the minimum required version down to cmake-3.1,
so we can build on oldish, entreprise-grade distributions that
only have cmake-3.1 (or at least, don't have up to cmake-3.8).
Reported-by: Thomas Petazzoni<EMAIL_ADDRESS>Signed-off-by: "Yann E. MORIN"<EMAIL_ADDRESS>

Coverage remained the same at 100.0% when pulling e8b6b7adc138a66f8d47396a2e707366d3771028 on yann-morin-1998:yem/cmake-version into c682b9879b349a0411633845dfd66a5d8af00f83 on nlohmann:develop.

Thanks for the PR! I’ll check it soon.

Thanks!

Sorry to be late, but I think this PR will actually break things for old CMake-versions. Indeed target_compile_features() has been added to CMake 3.1. However, the requested features by this library (cxx_std_11) have only been added in CMake 3.8.  See the changelog of cmake 3.8
One possible solution before 3.8 to solve a dependency to C++11 with target_compile_features was requesting a feature which implied C++11-support for compiler such as cxx_range_for.

@pboettch Thanks for reporting!

@pboettch Indeed, cxx_std_11 was added only with 3.8.0. I only
checked for the addition of target_compile_features(). My bad, sorry.
However, I've actually been able to build with just cmake-3.1.

GCC from version 5 on enables C++11 by default, however, cmake should moan about the unknown feature.

Error on my side: even gcc 5.4 does build c++11 by default.

I just tried on a Ubuntu 14.04 platform which uses cmake 3.5.1 the following:
add_executable(t t.cpp)
target_compile_features(t PRIVATE cxx_std_11)

And I got
CMake Error at CMakeLists.txt:4 (target_compile_features):
  target_compile_features specified unknown feature "cxx_std_11" for target
  "t".

@pboettch Arg.. I had a more recent version of cmake lying around, that was
taking precedence. I just retried, and indeed cmake-3.1 errors out too.
Shall I send a revert, or will you do?
(lesson learnt: next time, do not append to PATH, but prefix to it...)

@yann-morin-1998 If you change it to target_compile_features( ... cxx_range_for) in the CMakeLists.txt of this library, does it it work for you?

@pboettch So, replacing cxx_std_11 with cxx_range_for does work with cmake-3.1, yes.

Maybe some versions before GCC 4.8. IOW versions of compilers which had partial support of some C++11 features. Normally you should already not support these compilers.
AFAIK, CMake cxx_range_for pulls in C++11 support on GCC, Clang and VS.

@nlohmann @pboettch Here's what it got me:
[  2%] Building CXX object test/CMakeFiles/catch_main.dir/src/unit.cpp.o
cd /home/ymorin/tmp/json/json/build-me/test && /usr/bin/c++    -I/home/ymorin/tmp/json/json/test/thirdparty/catch    -std=gnu++11 -o CMakeFiles/catch_main.dir/src/unit.cpp.o -c /home/ymorin/tmp/json/json/test/src/unit.cpp

So it is using the gnu++11 suport.

That's CMake's default for GCC when C++11 is required.


Login Error

Some times when I try to sign in, it gives me a Login Error! I managed to bypass it once, but it's not letting me in anymore.

Can confirm I am also having this issue periodically, seemingly at random. Restarting the client once or twice seems to fix it temporarily.


frontend: bump typescript-eslint dep. versions

Bump @typescript-eslint/eslint-plugin and @typescript-eslint/parser to latest version 7.17.0.
side note: we still can't update eslint > ^8 because of these two deps. because they depend on ^8.57.0.

waiting for typescript-eslint/eslint-plugin and typescript-eslint/parser to support eslint 9


No return from offline on iOS

We're building a mobile app using manifoldJS. On iOS, when we lose the network (e.g. airplane mode), and then re-connect, the app never returns from the offline status page.
Just to give you a bit more context, we're using these plugins:
cordova-plugin-crosswalk-webview 1.5.0 "Crosswalk WebView Engine"
cordova-plugin-device 1.1.0 "Device"
cordova-plugin-hostedwebapp 0.2.1 "HostedWebApp"
cordova-plugin-network-information 1.1.0 "Network Information"
cordova-plugin-splashscreen 3.0.0 "Splashscreen"
cordova-plugin-statusbar 2.1.0 "StatusBar"
cordova-plugin-whitelist 1.0.0 "Whitelist"
phonegap-plugin-push 1.4.4 "PushPlugin"
We have our own offline page. We're testing this on 2 separate iphones, an iphone 4 and 6, and see the same issue on both.
iOS version is latest: 9.2.1
The offline mode works fine on android.
Any ideas?

Wonder if it's related to this:
https://github.com/manifoldjs/ManifoldCordova/issues/25

Sorry to bump this, I was just wondering if anyone else has seen this - it seems pretty bad, since it renders the whole offline stuff as unusable.
I'll try removing cordova and re-building the app, see if that makes a difference.

Hi Matt,  I'm looking at this now, sorry for the delay, we've been focused on 0.5 upcoming.  So you are saying that the "online" event code doesn't seem to be working?  it accurately goes offline, but never comes online.

Hi Matt,
I just tried a few apps in the iOS store that I know are using Manifoldjs and they all came right back online, are you seeing any errors in the console when you go back online?

That's weird. I'll try to generate a vanilla app and see if I can recreate.
I'll post an update t-row, cheers for taking a look!
On Tue, 16 Feb 2016 22:23 Jeff Burtoft<EMAIL_ADDRESS>wrote:

Hi Matt,
I just tried a few apps in the iOS store that I know are using Manifoldjs
and they all came right back online, are you seeing any errors in the
console when you go back online?
—
Reply to this email directly or view it on GitHub
https://github.com/manifoldjs/ManifoldCordova/issues/59#issuecomment-184899466
.

Hi,
So I finally got round to testing this.
I'm testing on a real iphone 4, which has wifi connection, but no data network (there is no sim card in the phone).
I've just generated a new manifoldjs app with this command:
manifoldjs http://www.bbc.co.uk -d bbcapp -p ios
The app generates fine. I build and launch on the device, and then disconnect from the usb cable. Here's what I observe:
When I load the app, and then go aeroplane mode, nothing happens until I click a link on the page, at which point I get the offline page (by design?)
When I have the offline screen displayed, and then turn aeroplane mode off, I never return back to the app - I remain stuck in the offline page. The ony way back  is for me to force-quite the app and launch it again.
Here's some output from xcode which may or may not be of use :)
When I first go into aeroplane mode:
2016-02-22 09:20:46.747 WwwBbcCoUk[236:8539] Invalid callback id received by sendPluginResult
While in aeroplane mode, I try to click a link:
2016-02-22 09:21:08.159 WwwBbcCoUk[236:8539] Resetting plugins due to page load.
2016-02-22 09:21:08.161 WwwBbcCoUk[236:8539] Received a navigation start notification.
2016-02-22 09:21:08.192 WwwBbcCoUk[236:8539] Failed to load webpage with error: The Internet connection appears to be offline.
2016-02-22 09:21:08.197 WwwBbcCoUk[236:8539] Received a navigation failure notification. error: Error Domain=NSURLErrorDomain Code=-1009 "The Internet connection appears to be offline." UserInfo={NSErrorFailingURLStringKey=http://www.bbc.co.uk/news, NSErrorFailingURLKey=http://www.bbc.co.uk/news, NSLocalizedDescription=The Internet connection appears to be offline., NSUnderlyingError=0x15e2f8b0 {Error Domain=kCFErrorDomainCFNetwork Code=-1009 "The Internet connection appears to be offline." UserInfo={_kCFStreamErrorCodeKey=8, NSErrorFailingURLStringKey=http://www.bbc.co.uk/news, NSErrorFailingURLKey=http://www.bbc.co.uk/news, NSLocalizedDescription=The Internet connection appears to be offline., _kCFStreamErrorDomainKey=12}}}

And again, when I turn OFF aeroplane mode:
2016-02-22 09:23:06.817 WwwBbcCoUk[236:8539] Invalid callback id received by sendPluginResult
Finally, here's the version of the plugins I'm using:
Matts-MacBook-Pro:cordova:% cordova plugin list
cordova-plugin-hostedwebapp 0.2.1 "HostedWebApp"
cordova-plugin-network-information 1.2.0 "Network Information"
cordova-plugin-whitelist 1.0.0 "Whitelist"

Any ideas?

Can anyone else confirm these steps produce the same issues as me on a different iphone device?

Hi Matt, I only have a simulator at this time.  @DaveVoyles can you do a base app and test this for Matt.  The offline page is suppose to go on by itself when network is lost, so I think there must be something up with network-information
@mattwoberts I'll try this with the new version tonight on simulator and see if I get the same issue.

Hi @boyofgreen. I just tried that app I generated above on the simulator (iphone 6), and it works perfectly. Trying to find another device to test it on...

bump Anyone else seeing this?

More updates re: this. I've upgraded everything, so I'm on manifoldjs 0.5.0, but the issue remains.
Created a new app as before using this new manifoldjs. Works perfectly on the simulator, but on 3 different test devices, it doesn't work. I tried debugging the app, didn't get too far since i don't know 'owt about objective c, but all I can see is that this isn't being hit:
// Handles notifications from the network-information plugin and shows the offline page whenever
// network connectivity is lost. It restores the original view once the network is up again.
- (void)updateConnectivityStatus:(NSNotification*)notification
{

.. when you're on a real device, although it does get hit when you test on the sim.
:(

I'm going to work round this by disabling the offline support and instead using the notifications from cordova network-information - the javascript notification hooks provided by that plugin are working fine for me, but no events are firing for the offline support added to this plugin.
However, I'm confused why no-one else is reporting to see this issue.. @boyofgreen did you manage to test this on a real device?
Matt

I have not yet.  This is an interesting one. Clearly there is a bug, but we should also just give you the ability to disable to offline page as a manifest value.

Did you have to add anything to your info.plist iOS file to get this to run?
If I wrap my own site (DaveVoyles.com) then try to run it through my iphone 6 with xCode, it throws an error about "App Transport Security policy requires the use of a secure connection". Thought this SO post would have helped, but no dice.

So with the latest version of iOS, it is https only by default, but you can go into your plist (I don't remember the value, but I remember it being evident) and allow for http.  if you can't find it, I'll crack open an app I did it for and see what it was

I haven't edited this for my app, my site is https

Got it working. I just plugged the phone in and out a bunch and it suddenly removed that error. shrug.
Steps taken:

Created a new ManifoldApp from the ManifoldJS generator page
Open project in xCode & Changed info.plist to allow for Arbitrary loads, to load my default page
Manifold app loads www.DaveVoyles.com
When I turn on airplane mode the page hides and the text "It looks like you are offline. Please reconnect to use this application" appears.

Cheers. Yeah that's the expected behaviour. Does it come back when you turn aeroplane off?
So the only difference is that you edited your plist, which shouldn't be an issue for me since I'm HTTPS.

and he probably has a SIM card in his phone, maybe that is the difference?

No, it does not come back when I turn airplane mode off and reconnect to the internet.
Yes, I have a SIM in this phone as well.

Thanks Dave.  Something must have changed under us.  There are a number of iOS issues raised on the tracker .  We need to make sure we have it implemented correctly, then raise an issue if need be.

looks like the issue would be here:
https://github.com/manifoldjs/ManifoldCordova/blob/a31b045317d0b63974141b7c9d21434343135dd5/src/ios/CDVHostedWebApp.m#L346

Hi. I'm testing on both a phone with and without a sim card - same issue on
both.
That code you highlight never gets hit for me on iOS when I go
offline/online.. Weird eh.
On Wed, 2 Mar 2016 16:38 Jeff Burtoft<EMAIL_ADDRESS>wrote:

looks like the issue would be here:
https://github.com/manifoldjs/ManifoldCordova/blob/a31b045317d0b63974141b7c9d21434343135dd5/src/ios/CDVHostedWebApp.m#L346
—
Reply to this email directly or view it on GitHub
https://github.com/manifoldjs/ManifoldCordova/issues/59#issuecomment-191318130
.

yea, I saw something about the event name changing, maybe we are listening to an old even name

If I knew anything at all about obj-c I'd take a closer look :) might have a nosey anyway

I'm in the same boat -- I don't know any obj-c.
I agree, looks like it's in the exact spot you mentioned above, but you said it's never hitting that breakpoint, right?

As you've already noted, it works in the simulator and I'm afraid I don't have a device right now to test this, but if you place a breakpoint in the following line of the Plugins/CDVReachability.m file, does it get hit when the network status changes?
https://github.com/apache/cordova-plugin-network-information/blob/master/src/ios/CDVReachability.m#L103

@mattwoberts would you be able to try that?  My guess is that it will run once, but not when it goes back online.

Yes, it's on my to-do list tonight - I'll get back to you in a couple of hours!

@boyofgreen @f2bo Hi - just tested, and a breakpoint on that line is never being hit for me - the javascript offline / offline code is firing for me, but never that breakpoint, not even first load.

Hi @mattwoberts.
Interesting. I mentioned placing the breakpoint in the line that actually posts the notification, but just to be sure, can you make sure that the CDVReachabilityCallback method doesn't get called at all? There's some validation code in that method that might cause it to skip the line with the breakpoint.
There's another breakpoint that you can set that might help to understand what is going on. Can you put a breakpoint in the sendPluginResult method?
https://github.com/apache/cordova-plugin-network-information/blob/3968f2069dfc858244640215046b09649d8b2eb4/src/ios/CDVConnection.m#L41
Assuming it gets hit, make a note of the call stack leading up to that breakpoint both when transitioning from online to offline and offline to online. (The call stack for all threads can be examined in the Debug navigator pane on the left side of Xcode).
Also, I'm intrigued by the fact that you say that the javascript offline / online code is working despite the fact that the notification on the native side never gets fired. Since I can't reproduce the problem in the simulator, I'm trying to understand the code path that needs to execute for that to happen. Presumably, you are hooking the online / offline events with code similar to the following, correct?
    document.addEventListener('deviceready',  function () {
        document.addEventListener("offline", function () {
            console.log('Device is OFFLINE...');
        }, false);
        document.addEventListener("online", function () {
            console.log('Device is ONLINE...');
        }, false);
    }, false);

Hi @f2bo
Right - here's my responses. I'm testing on an iphone 4 this time - it's the one that doesn't have a SIM card in it.
CDVReachabilityCallback - that method you asked me to breakpoint is not being hit at all. Ever. Just to be certain I wasn't doing something silly, I tested on a the simulator, and the breakpoints WERE hit without issue.
sendPluginResult:
Going from online to offline:

Going from offline back to online:

Regarding the javascript API - yes absolutely, this is how I'm working around it for now. I listen to the events like this:
        document.addEventListener("offline", offline, false);         document.addEventListener("online", online, false);
And those functions fire perfectly, every time!

Thanks @mattwoberts ,   @f2bo and I will be together for the next few weeks and will have some real devices to test with, so we'll figure this out.

Hi. Just wondered if there was any update / progress on this. I've managed to work around it on my app, so it's not a major issue for me, but I'd ideally prefer to use this...

Hi Matt, we had to move it out of the 0.3 release (i know it's still tagged) since we didn't want to hold up the other changes with it.  We have a 0.4 starting in two weeks, and we'll address it in that release, one way or another.
Sorry about the delay, but we haven't forgotten about you!

Hi @mattwoberts,
Sorry it took so long to get back to you but we are currently working on the next release and have started looking at this issue again.
I can't tell whether I've been able to reproduce the same symptoms that you report. In my tests, the application does detect changes in network connectivity correctly on a device (iPhone 6s - iOS 9.3) when the application is in the foreground. However, I did find a problem when the changes happen while the application is in the background. I've pushed a potential fix to the ios-offline-fix branch. It would be very helpful if you can test it and let us know if you notice any improvement.
The only changed file is src/ios/CDVHostedWebApp.m, so it's probably easiest to test by replacing that file in a copy of your project.
Otherwise, you can replace the plugin with the one in the ios-offline-fix branch of this repo. For example:
cordova plugin rm cordova-plugin-hostedwebapp
cordova plugin add https://github.com/manifoldjs/ManifoldCordova.git#ios-offline-fix

👍
Excellent work - just got round to testing it, and it worked perfectly for me, on all real devices I could find hanging around.
Cheers - what release do you think this will be in?

we are targeting 0.6 for the end of the month, it will be in that one.


CI: migrate remaining misc. bash script tests to run as part of Ginkgo framework

Move tests/00-no-newlines-in-log-call.sh to contrib/scripts/no-newlines-in-log-call.sh and have it run during the precheck Makefile target (formerly known as precheck-gofmt).
Migrate tests/00-check-examples.sh to run during Ginkgo tests, which validates all policy examples in certain directories under examples.

Signed-off by: Ian Vernon<EMAIL_ADDRESS>Fixes: #2535

test-me-please

test-me-please

test-me-please

test-me-please


The input value type 'SupplyInput' is not present when resolving type 'VariantInput' , The input value type 'MachineInput' is not present when resolving type 'VariantInput'

Before opening, please confirm:

[X] I have installed the latest version of the Amplify CLI (see above), and confirmed that the issue still persists.
[X] I have searched for duplicate or closed issues.
[X] I have read the guide for submitting bug reports.
[X] I have done my best to include a minimal, self-contained set of instructions for consistently reproducing the issue.
[X] I have removed any sensitive information from my code snippets and submission.

How did you install the Amplify CLI?
npm
If applicable, what version of Node.js are you using?
16.14.0
Amplify CLI Version
8.2.0
What operating system are you using?
Windows
Did you make any manual changes to the cloud resources managed by Amplify? Please describe the changes made.
No manual changes made
Amplify Categories
Not applicable
Amplify Commands
push
Describe the bug
The input value type 'SupplyInput' is not present when resolving type 'VariantInput' [@683:1]. The input value type 'MachineInput' is not present when resolving type 'VariantInput' [@683:1]
Expected behavior
'SupplyInput' and 'VariantInput' are both defined and should be pushed accordingly.
 To configure PRODUCTION-READY authorization rules, review: https://docs.am
plify.aws/cli/graphql/authorization-rules

⚠  WARNING: Amplify CLI will change the default identity claim from 'username' to use 'sub::username'. To continue using only usernames, set 'identityClaim: "username"' on your 'owner' rules on you
r schema. The default will be officially switched with v9.0.0. To read more: https://docs.amplify.aws/cli/migration/identity-claim-changes/
/ Fetching updates to backend environment: dev from the cloud.✅ GraphQL schema compiled successfully.

Edit your schema at E:\web.js.py.more\tr-crm\amplify\backend\api\trcrm\schema.graphql or place .graphql files in a directory at E:\web.js.py.more\tr-crm\amplify\backend\api\trcrm\schema
✔ Successfully pulled backend environment dev from the cloud.
\ Building resource api/trcrm
⚠  WARNING: your GraphQL API currently allows public create, read, update, and delete access to all models via an API Key. To configure PRODUCTION-READY authorization rules, review: https://docs.am
plify.aws/cli/graphql/authorization-rules

⚠  WARNING: Amplify CLI will change the default identity claim from 'username' to use 'sub::username'. To continue using only usernames, set 'identityClaim: "username"' on your 'owner' rules on you
r schema. The default will be officially switched with v9.0.0. To read more: https://docs.amplify.aws/cli/migration/identity-claim-changes/
| Building resource api/trcrm✅ GraphQL schema compiled successfully.

Edit your schema at E:\web.js.py.more\tr-crm\amplify\backend\api\trcrm\schema.graphql or place .graphql files in a directory at E:\web.js.py.more\tr-crm\amplify\backend\api\trcrm\schema

    Current Environment: dev

┌──────────┬───────────────┬───────────┬───────────────────┐
│ Category │ Resource name │ Operation │ Provider plugin   │
├──────────┼───────────────┼───────────┼───────────────────┤
│ Api      │ trcrm         │ Update    │ awscloudformation │
├──────────┼───────────────┼───────────┼───────────────────┤
│ Auth     │ trcrmc892667c │ No Change │ awscloudformation │
├──────────┼───────────────┼───────────┼───────────────────┤
│ Storage  │ ProductImages │ No Change │ awscloudformation │
├──────────┼───────────────┼───────────┼───────────────────┤
│ Function │ postProduct   │ No Change │ awscloudformation │
├──────────┼───────────────┼───────────┼───────────────────┤
│ Function │ deleteProduct │ No Change │ awscloudformation │
└──────────┴───────────────┴───────────┴───────────────────┘
? Are you sure you want to continue? Yes

⚠  WARNING: your GraphQL API currently allows public create, read, update, and delete access to all models via an API Key. To configure PRODUCTION-READY authorization rules, review: https://docs.am
plify.aws/cli/graphql/authorization-rules

⚠  WARNING: Amplify CLI will change the default identity claim from 'username' to use 'sub::username'. To continue using only usernames, set 'identityClaim: "username"' on your 'owner' rules on you
r schema. The default will be officially switched with v9.0.0. To read more: https://docs.amplify.aws/cli/migration/identity-claim-changes/
✅ GraphQL schema compiled successfully.

Edit your schema at E:\web.js.py.more\tr-crm\amplify\backend\api\trcrm\schema.graphql or place .graphql files in a directory at E:\web.js.py.more\tr-crm\amplify\backend\api\trcrm\schema
\ Building resource api/trcrm
⚠  WARNING: your GraphQL API currently allows public create, read, update, and delete access to all models via an API Key. To configure PRODUCTION-READY authorization rules, review: https://docs.am
plify.aws/cli/graphql/authorization-rules

⚠  WARNING: Amplify CLI will change the default identity claim from 'username' to use 'sub::username'. To continue using only usernames, set 'identityClaim: "username"' on your 'owner' rules on you
r schema. The default will be officially switched with v9.0.0. To read more: https://docs.amplify.aws/cli/migration/identity-claim-changes/
| Building resource api/trcrm✅ GraphQL schema compiled successfully.

Edit your schema at E:\web.js.py.more\tr-crm\amplify\backend\api\trcrm\schema.graphql or place .graphql files in a directory at E:\web.js.py.more\tr-crm\amplify\backend\api\trcrm\schema
? Do you want to update code for your updated GraphQL API Yes
? Do you want to generate GraphQL statements (queries, mutations and subscription) based on your schema types?
This will overwrite your current graphql queries, mutations and subscriptions Yes
/ Updating resources in the cloud. This may take a few minutes...

UPDATE_IN_PROGRESS amplify-trcrm-dev-212645 AWS::CloudFormation::Stack Sat May 14 2022 16:07:29 GMT-0500 (Central Daylight Time) User Initiated
UPDATE_IN_PROGRESS functiondeleteProduct    AWS::CloudFormation::Stack Sat May 14 2022 16:07:33 GMT-0500 (Central Daylight Time)
UPDATE_IN_PROGRESS authtrcrmc892667c        AWS::CloudFormation::Stack Sat May 14 2022 16:07:33 GMT-0500 (Central Daylight Time)
UPDATE_IN_PROGRESS storageProductImages     AWS::CloudFormation::Stack Sat May 14 2022 16:07:33 GMT-0500 (Central Daylight Time)
UPDATE_IN_PROGRESS functionpostProduct      AWS::CloudFormation::Stack Sat May 14 2022 16:07:33 GMT-0500 (Central Daylight Time)
UPDATE_COMPLETE    functiondeleteProduct    AWS::CloudFormation::Stack Sat May 14 2022 16:07:33 GMT-0500 (Central Daylight Time)
UPDATE_COMPLETE    authtrcrmc892667c        AWS::CloudFormation::Stack Sat May 14 2022 16:07:33 GMT-0500 (Central Daylight Time)
UPDATE_COMPLETE    storageProductImages     AWS::CloudFormation::Stack Sat May 14 2022 16:07:33 GMT-0500 (Central Daylight Time)
UPDATE_COMPLETE    functionpostProduct      AWS::CloudFormation::Stack Sat May 14 2022 16:07:33 GMT-0500 (Central Daylight Time)
| Updating resources in the cloud. This may take a few minutes...

UPDATE_IN_PROGRESS apitrcrm AWS::CloudFormation::Stack Sat May 14 2022 16:07:35 GMT-0500 (Central Daylight Time)
| Updating resources in the cloud. This may take a few minutes...

UPDATE_IN_PROGRESS amplify-trcrm-dev-212645-apitrcrm-1ASUOTZ9A2WS8 AWS::CloudFormation::Stack Sat May 14 2022 16:07:35 GMT-0500 (Central Daylight Time) User Initiated
\ Updating resources in the cloud. This may take a few minutes...

UPDATE_IN_PROGRESS GraphQLAPIDefaultApiKey215A6DD7     AWS::AppSync::ApiKey        Sat May 14 2022 16:07:40 GMT-0500 (Central Daylight Time)
UPDATE_IN_PROGRESS GraphQLAPITransformerSchema3CB2AE18 AWS::AppSync::GraphQLSchema Sat May 14 2022 16:07:41 GMT-0500 (Central Daylight Time)
| Updating resources in the cloud. This may take a few minutes...

UPDATE_COMPLETE GraphQLAPIDefaultApiKey215A6DD7 AWS::AppSync::ApiKey Sat May 14 2022 16:07:42 GMT-0500 (Central Daylight Time)
\ Updating resources in the cloud. This may take a few minutes...

UPDATE_IN_PROGRESS UpdateRolesWithIDPFunction AWS::Lambda::Function Sat May 14 2022 16:07:53 GMT-0500 (Central Daylight Time)
| Updating resources in the cloud. This may take a few minutes...

UPDATE_COMPLETE UpdateRolesWithIDPFunction AWS::Lambda::Function Sat May 14 2022 16:08:36 GMT-0500 (Central Daylight Time)
| Updating resources in the cloud. This may take a few minutes...

UPDATE_FAILED GraphQLAPITransformerSchema3CB2AE18 AWS::AppSync::GraphQLSchema Sat May 14 2022 16:08:45 GMT-0500 (Central Daylight Time) Schema Creation Status is FAILED with details:
Found 2 problem(s) with the schema: The input value type 'SupplyInput' is not present when resolving type 'VariantInput' [@683:1]. The input value type 'MachineInput' is not present when resolving type 'VariantInput' [@683:1].
/ Updating resources in the cloud. This may take a few minutes...

UPDATE_ROLLBACK_IN_PROGRESS amplify-trcrm-dev-212645-apitrcrm-1ASUOTZ9A2WS8 AWS::CloudFormation::Stack Sat May 14 2022 16:08:46 GMT-0500 (Central Daylight Time) The following resource(s) failed to update: [GraphQLAPITransformerSchema3CB2AE18].
\ Updating resources in the cloud. This may take a few minutes...

UPDATE_FAILED               apitrcrm                 AWS::CloudFormation::Stack Sat May 14 2022 16:08:53 GMT-0500 (Central Daylight Time) Embedded stack arn:aws:cloudformation:us-east-2:957708162239:stack/amplify-trcrm-dev-212645-apitrcrm-1ASUOTZ9A2WS8/742a1960-ba0d-11ec-97f5-0a941f9fb33a was not successfully updated. Currently in UPDATE_ROLLBACK_IN_PROGRESS with
reason: The following resource(s) failed to update: [GraphQLAPITransformerSchema3CB2AE18].
UPDATE_ROLLBACK_IN_PROGRESS amplify-trcrm-dev-212645 AWS::CloudFormation::Stack Sat May 14 2022 16:08:53 GMT-0500 (Central Daylight Time) The following resource(s) failed to update: [apitrcrm].

\ Updating resources in the cloud. This may take a few minutes...

UPDATE_IN_PROGRESS functiondeleteProduct AWS::CloudFormation::Stack Sat May 14 2022 16:09:10 GMT-0500 (Central Daylight Time)
UPDATE_IN_PROGRESS functionpostProduct   AWS::CloudFormation::Stack Sat May 14 2022 16:09:10 GMT-0500 (Central Daylight Time)
UPDATE_IN_PROGRESS authtrcrmc892667c     AWS::CloudFormation::Stack Sat May 14 2022 16:09:10 GMT-0500 (Central Daylight Time)
UPDATE_IN_PROGRESS storageProductImages  AWS::CloudFormation::Stack Sat May 14 2022 16:09:10 GMT-0500 (Central Daylight Time)
UPDATE_COMPLETE    functionpostProduct   AWS::CloudFormation::Stack Sat May 14 2022 16:09:10 GMT-0500 (Central Daylight Time)
UPDATE_COMPLETE    functiondeleteProduct AWS::CloudFormation::Stack Sat May 14 2022 16:09:10 GMT-0500 (Central Daylight Time)
UPDATE_COMPLETE    authtrcrmc892667c     AWS::CloudFormation::Stack Sat May 14 2022 16:09:10 GMT-0500 (Central Daylight Time)
UPDATE_COMPLETE    storageProductImages  AWS::CloudFormation::Stack Sat May 14 2022 16:09:10 GMT-0500 (Central Daylight Time)
/ Updating resources in the cloud. This may take a few minutes...

UPDATE_IN_PROGRESS apitrcrm                   AWS::CloudFormation::Stack Sat May 14 2022 16:09:11 GMT-0500 (Central Daylight Time)
UPDATE_IN_PROGRESS UpdateRolesWithIDPFunction AWS::Lambda::Function      Sat May 14 2022 16:09:11 GMT-0500 (Central Daylight Time)
| Updating resources in the cloud. This may take a few minutes...

UPDATE_IN_PROGRESS GraphQLAPIDefaultApiKey215A6DD7     AWS::AppSync::ApiKey        Sat May 14 2022 16:09:15 GMT-0500 (Central Daylight Time)
UPDATE_IN_PROGRESS GraphQLAPITransformerSchema3CB2AE18 AWS::AppSync::GraphQLSchema Sat May 14 2022 16:09:15 GMT-0500 (Central Daylight Time)
- Updating resources in the cloud. This may take a few minutes...

UPDATE_COMPLETE GraphQLAPIDefaultApiKey215A6DD7 AWS::AppSync::ApiKey Sat May 14 2022 16:09:16 GMT-0500 (Central Daylight Time)
- Updating resources in the cloud. This may take a few minutes...

UPDATE_COMPLETE UpdateRolesWithIDPFunction AWS::Lambda::Function Sat May 14 2022 16:09:46 GMT-0500 (Central Daylight Time)
\ Updating resources in the cloud. This may take a few minutes...

UPDATE_COMPLETE                              GraphQLAPITransformerSchema3CB2AE18             AWS::AppSync::GraphQLSchema Sat May 14 2022 16:10:18 GMT-0500 (Central Daylight Time)
UPDATE_ROLLBACK_COMPLETE_CLEANUP_IN_PROGRESS amplify-trcrm-dev-212645-apitrcrm-1ASUOTZ9A2WS8 AWS::CloudFormation::Stack  Sat May 14 2022 16:10:20 GMT-0500 (Central Daylight Time)
/ Updating resources in the cloud. This may take a few minutes...

UPDATE_COMPLETE                              apitrcrm                 AWS::CloudFormation::Stack Sat May 14 2022 16:10:28 GMT-0500 (Central Daylight Time)
UPDATE_ROLLBACK_COMPLETE_CLEANUP_IN_PROGRESS amplify-trcrm-dev-212645 AWS::CloudFormation::Stack Sat May 14 2022 16:10:28 GMT-0500 (Central Daylight Time)
UPDATE_COMPLETE                              storageProductImages     AWS::CloudFormation::Stack Sat May 14 2022 16:10:29 GMT-0500 (Central Daylight Time)
UPDATE_COMPLETE                              functionpostProduct      AWS::CloudFormation::Stack Sat May 14 2022 16:10:29 GMT-0500 (Central Daylight Time)
UPDATE_COMPLETE                              functiondeleteProduct    AWS::CloudFormation::Stack Sat May 14 2022 16:10:29 GMT-0500 (Central Daylight Time)
\ Updating resources in the cloud. This may take a few minutes...

UPDATE_COMPLETE apitrcrm AWS::CloudFormation::Stack Sat May 14 2022 16:10:40 GMT-0500 (Central Daylight Time)
| Updating resources in the cloud. This may take a few minutes...

UPDATE_COMPLETE          authtrcrmc892667c        AWS::CloudFormation::Stack Sat May 14 2022 16:10:40 GMT-0500 (Central Daylight Time)
UPDATE_ROLLBACK_COMPLETE amplify-trcrm-dev-212645 AWS::CloudFormation::Stack Sat May 14 2022 16:10:41 GMT-0500 (Central Daylight Time)
| Updating resources in the cloud. This may take a few minutes...

Following resources failed

Resource Name: gg64scu6svdaxgv34zvlfad7meGraphQLSchema (AWS::AppSync::GraphQLSchema)
Event Type: update
Reason: Schema Creation Status is FAILED with details: Found 2 problem(s) with the schema:
The input value type 'SupplyInput' is not present when resolving type 'VariantInput' [@683:1].
The input value type 'MachineInput' is not present when resolving type 'VariantInput' [@683:1].
URL: https://console.aws.amazon.com/cloudformation/home?region=us-east-2#/stacks/arn%3Aaws%3Acloudformation%3Aus-east-2%3A957708162239%3Astack%2Famplify-trcrm-dev-212645-apitrcrm-1ASUOTZ9A2WS8%2F742a1960-ba0d-11ec-97f5-0a941f9fb33a/events

✖ An error occurred when pushing the resources to the cloud
🛑 An error occurred during the push operation: /
Resource is not in the state stackUpdateComplete
⚠ Review the Amplify CLI troubleshooting guide for potential next steps: https://docs.amplify.aws/cli/project/troubleshooting/

Additional information
No response

@ykethan I have changed the schema accordingly
`# This "input" configures a global authorization rule to enable public access to
all models in this schema.  PostedSupplierStatus
@function(name: "postSupplier-${env}")
postConfig(input: ConfigInput!): PostedConfigStatus
@function(name: "postConfig-${env}")
postProduct(input: PostProductInput!): PostedProductStatus
@function(name: "postProduct-${env}")
postSupply(input: SupplyInput!): PostedSupplyStatus
@function(name: "postSupply-${env}")
postMachine(input: MachineInput!): PostedMachineStatus
@function(name: "postMachine-${env}")
postVariant(input: VariantInput!): PostedVariantStatus
@function(name: "postVariant-${env}")
}
`
but am getting this error now
`ollowing resources failed
Resource Name: 6z3ztxrcc5ezlohs7tzlmsdaneGraphQLSchema (AWS::AppSync::GraphQLSchema)
Event Type: create
Reason: Schema Creation Status is FAILED with details: Internal Failure while saving the schema.
✖ An error occurred when pushing the resources to the cloud
🛑 An error occurred during the push operation: /
Resource is not in the state stackUpdateComplete
`

Hey @othewebdev, I recently noticed this error as well and filed a separate issue for this: https://github.com/aws-amplify/amplify-category-api/issues/458. The error seems to be cause by passing type block on to input attribute (example: suppliers: [Supplier]). Could you please create the model types and relationships according to https://docs.amplify.aws/cli/graphql/data-modeling/#setup-relationships-between-models

closing the issue due to inactivity. Please feel free in reaching out to us again.


Licensing

First of all, thank you for providing this library!
Is the project licensed under the MIT license as the the package.json says?

glad you like it.
MIT License properly assigned  a974f10


feat: Adding Sphinx documentation for python

Adding sphinx documentation for python
Adding initial index.html page for the docs

Notes:

create the branch gh-pages and setup it to build from gh-pages /root at 'pages' settings before merging
probably we need to change the 'contents: read' to 'contents: write' so the bot can build and push it

Content Notes:

For callout_server.rst we had to generate it manually due to a Type problem for Sphinx, it was not recognizing the '|' operator:
None | HeadersResponse | ImmediateResponse:

to generate it auto for this file maybe it is needed to change to the old format but I don't think it would be ideal to change the code just to fit the docs, let me know which path you wanna go for
I generated a branch that builds it and so you can check the content here for a preview:
https://pweiber.github.io/service-extensions-samples/

Content Notes:

For callout_server.rst we had to generate it manually due to a Type problem for Sphinx, it was not recognizing the '|' operator:
None | HeadersResponse | ImmediateResponse:

to generate it auto for this file maybe it is needed to change to the old format but I don't think it would be ideal to change the code just to fit the docs, let me know which path you wanna go for
I generated a branch that builds it and so you can check the content here for a preview: https://pweiber.github.io/service-extensions-samples/

I believe you should be able to use the Union type to get around that, I.e. Union[None | HeadersResponse | ImmediateResponse]

@pweiber let me know if I should create the gh-pages branch.


Korean letter is not printing in pdf

html input is Welcome To PDF 유니코드에  . generated output in pdf is Welcome To PDF ìoe ë‹ˆì½”ë“oeì—

how to add specific embeded fonds dejavu serif and NanumGothic to pdf ,when we are generating PDF from HTML ?


Fix /absolute.png not working on /path

If the component is used on https://example.com/path with a source of /images/awesome.jpg the asset will try to load from https://example.com/path/images/awesome.jpg.

Thanks, Abraham! Your contributions are very welcome 👍


Unexpected compile time errors for language/operator/number_operator tests

There are compile time errors for these new tests for ddc in strong and weak mode:
operator/number_operator_typing_test
operator/number_operator_context_test

The test failures were approved on Add test for new numeric operator typing rules.
@lrhn are these expected failures? It looks like these tests are new, so is this a new feature that is not supported yet? Is there a tracking bug for that work that I can link to for these failures?
Failure logs:
https://dart-ci.appspot.com/log/ddc-nnbd-linux-release-chrome/dartdevk-strong-linux-release-chrome/3979/language/operator/number_operator_typing_test
https://dart-ci.appspot.com/log/ddc-nnbd-linux-release-chrome/dartdevk-strong-linux-release-chrome/3979/language/operator/number_operator_context_test

The CFE issue implementing the new rules is #42577

As Johnni says, these are tests for new behavior, and they are expected to fail until that behavior is implemented.

Perfect, thanks!


[Bug]: component is not renederd

What happened?
A rendering bug happened!
please look at the white X in the circle

do you need the json file?
Unsupported features

[X] My animation doesn't use unsupported features

What Compottie version do you experience the bug on?
2.0.0-beta02
What platforms are you seeing the problem on?
Android
Does Compottie log anythyng to the stdout / your logger set with Compottie.logger?
No

do you need the json file?

Yes. I can't say anything here without the animation file

Closing this one. Please reopen if there would be updates or you will be able to share the animation file


Frame displayed incorrectly after clear command

After running the 'clear' command in a WSL session (Extraterm 0.42.1, using extraterm-commands-0.42.1), issuing an commands that generate single lines of stdout such as 'ls' or 'date' creates a frame but with no content.
Clicking the button to move the output to a separate tab shows that the command executed successfully (output shows correctly in new tab).
Issuing 'date' a second time does show the correct frame and output but it's a bit of an annoyance.

Which version of Windows are you using? (I think the command winver in Powershell can quickly show you. The 1809 or 1803 etc version number is the interesting one) Also can you provide a screenshot?

I am running Windows 10 Pro version 1803 (OS Build 17134.706).
I've also attached 2 screenshots. One showing the issue and one showing what should be displayed.


Get Tetris working

We have all the pieces in place now, we should be able to get Tetris working. Figure out what is
going wrong in the code and get Basic Tetris working!

Closed by 933b0b9e4908ad8755b1507784b262095c9eee7d


README Example using angular ui router part

Hello I found that this part in my app doesn't work in all cases :
.state('admin', {
        url: '/admin',
        abstract: true,
        template: '<ui-view/>',
        resolve: {
          auth: function($auth) {
            return $auth.validateUser();
          }
        }
      })

This would not work unless you do it like this (or something similar) :
.state('admin', {
        url: '/admin',
        abstract: true,
        template: '<ui-view/>',
        resolve: {
          auth: function($auth) {
            if($auth.validateUser().$$state.status == 2) {
             return {}
            }
           return $auth.validateUser();
          }
        }
      })

And this shows only when the user is not authorized. When user is authorized then it doesn't matter which of these above state definitions you use, it will work in both cases.
Is there a better way to do this? I've tried with .then.catch but it doesn't work for both cases when user is logged/not logged

If anyone is having similar issues this worked for me :
resolve: {
                currentUser:  function($auth) {
                  var user = $auth.validateUser().then(function(resp) {
                    return resp;
                  },
                  function(resp) {
                    return {};
                  })
                  .catch(function(resp) {
                    return {};
                  });

                  return user;
                }
              }


doc/asm: get_tls not defined in go_asm.h

What version of Go are you using (go version)?

$ go version
go version go1.12.7 darwin/amd64

Does this issue reproduce with the latest release?
Yes
What operating system and processor architecture are you using (go env)?
go env Output
$ go env
GOARCH="amd64"
GOBIN=""
GOCACHE="/Users/purewhite/Library/Caches/go-build"
GOEXE=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="darwin"
GOOS="darwin"
GOPATH="/Users/purewhite/go"
GOPROXY=""
GORACE=""
GOROOT="/usr/local/Cellar/go/1.12.7/libexec"
GOTMPDIR=""
GOTOOLDIR="/usr/local/Cellar/go/1.12.7/libexec/pkg/tool/darwin_amd64"
GCCGO="gccgo"
CC="clang"
CXX="clang++"
CGO_ENABLED="1"
GOMOD=""
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -fno-caret-diagnostics -Qunused-arguments -fmessage-length=0 -fdebug-prefix-map=/var/folders/gr/t7x82cps0w563940rhk76_400000gn/T/go-build992278676=/tmp/go-build -gno-record-gcc-switches -fno-common"

What did you do?
I'm studying go asm, and want to write a demo to get the *g.
According to the doc, I should be able to get *g using code like this:
#include "textflag.h"
#include "go_asm.h"

TEXT ·getg(SB),NOSPLIT,$0-8
    get_tls(CX)
    MOVQ    g(CX), AX
    MOVQ    AX, ret+0(FP)
    RET

What did you expect to see?
Successfully get current g's address.
What did you see instead?
$ go build .
# local/study/getg
./getg.s:5: unrecognized instruction "get_tls"
./getg.s:6: expected pseudo-register; found CX
./getg.s:7: expected pseudo-register; found AX
asm: assembly of ./getg.s failed

It seems to me that macro moved to a runtime header file go_tls.h. You might have to do #include "../../src/runtime/go_tls.h".
But I will defer to some experts to confirm if my diagnosis is correct @ianlancetaylor @randall77

It seems to me that macro moved to a runtime header file go_tls.h. You might have to do #include "../../src/runtime/go_tls.h".
But I will defer to some experts to confirm if my diagnosis is correct @ianlancetaylor @randall77

Hi, thanks for your reply.
After doing this, this program can be compiled, but if I want to get the m of g according to the doc, the problem still exists.
Code like this:
#include "textflag.h"
#include "go_asm.h"
#include "../../src/runtime/go_tls.h"

TEXT ·getm(SB),NOSPLIT,$0-8
    get_tls(CX)
    MOVQ    g(CX), AX
    MOVL	g_m(AX), BX
    MOVQ    BX, ret+0(FP)
    RET

outputs:
$ go build .
# local/study/getm
./getm.s:8: expected pseudo-register; found AX
asm: assembly of ./getm.s failed

Only the runtime package's go_asm.h defines the offsets of the runtime data structures, like g_m. When you run go build in local/study/getg, go_asm.h will contain the offsets of the local/study/getg package, not the runtime package.

The asm documentation should be clarified to explain that this code only works within the runtime package itself.
We do not want to support this outside of the runtime package.

Hi, I've submitted a pr #33069 , please take a look.
Thanks!

@ianlancetaylor Hi, I think this is a fix for the doc, and should be released asap. Therefore,  maybe the milestone should be go1.13 instead?
Just an inquiry.

The milestone doesn't mean that it has to wait for 1.14.  It only means that it should be resolved before 1.14 comes out.  I'm fine with getting a fix into 1.13, but I would like @robpike to take a look at the CL (if he hasn't already).


add result on countable and connected implies strongly connected

The same result is true with Smaller than the continuum instead of Countable.
Trying to find any relationship with T300, but I guess that is no relationship between Strongly connected and Completely regular.

Yeah I see the flavor with T300 but nothing obvious appears to me either.
I improved the theorem to use "smaller than continuum"


Fixed a bug that command can not be acquired when there are multiple semicolons

@see: http://kito0039.hatenablog.com/entry/2018/05/09/002547

I merged this PR and fixed this package myself.
I really appreciate the idea and PR !!

merged thanks.


android lock screen/notification ignores capabilities

Describe the Bug
Not sure if this is intended or not, but it is counterintuitive.
If I specify notificationCapabilities and compactCapabilities that do not include SkipToNext or SkipToPrevious, I would not expect the buttons for those functionalities to appear on the notification controls for android. I do not want to enable those controls, but it seems there is no option except to have those buttons appear, and simply not function if I don't provide those capabilities. Additionally, I am providing RemoteJumpForward and RemoteJumpBackward, and the controls for that do not show up on the android notification.
Steps To Reproduce
Instantiate track player like in the docs, and provide the following capabilities. The notification controls show the skip to previous track button regardless, and show the skip to next track as long as you're not on the last track in the list of tracks. The "jump" controls are not shown.
I think the notification should check capabilities for displaying these, rather than doing it solely based on the length of tracks and current track index.
Code To Reproduce
const AUDIO_CAPABILITIES = [
  Capability.Play,
  Capability.Pause,
  Capability.JumpForward,
  Capability.JumpBackward,
  Capability.SeekTo,
];

...

        await TrackPlayer.updateOptions({
          android: {
            appKilledPlaybackBehavior:
              AppKilledPlaybackBehavior.ContinuePlayback,
          },
          capabilities: AUDIO_CAPABILITIES,
          notificationCapabilities: AUDIO_CAPABILITIES,
          compactCapabilities: AUDIO_CAPABILITIES,
        });

        await TrackPlayer.add(tracks);

Replicable on Example App?
Can you replicate this bug in the React Native Track Player Example App?
Environment Info:
Paste the results of npx react-native info
System:
    OS: macOS 12.2.1
    CPU: (10) x64 Apple M1 Pro
    Memory: 31.07 MB / 16.00 GB
    Shell: 5.8 - /bin/zsh
  Binaries:
    Node: 14.18.3 - ~/.nvm/versions/node/v14.18.3/bin/node
    Yarn: 1.22.18 - ~/.nvm/versions/node/v14.15.5/bin/yarn
    npm: 6.14.15 - ~/.nvm/versions/node/v14.18.3/bin/npm
    Watchman: 2<IP_ADDRESS> - /opt/homebrew/bin/watchman
  Managers:
    CocoaPods: 1.11.3 - /usr/local/bin/pod
  SDKs:
    iOS SDK:
      Platforms: DriverKit 21.4, iOS 15.5, macOS 12.3, tvOS 15.4, watchOS 8.5
    Android SDK:
      API Levels: 30, 31, 32, 33
      Build Tools: 30.0.2, 30.0.3, 31.0.0, 32.0.0, 32.1.0
      System Images: android-30 | ARM 64 v8a, android-30 | Intel x86 Atom_64, android-30 | Google APIs ARM 64 v8a, android-30 | Google APIs Intel x86 Atom, android-30 | Google APIs Intel x86 Atom_64, android-30 | Google Play ARM 64 v8a, android-31 | ARM 64 v8a, android-31 | Google APIs ARM 64 v8a, android-31 | Google Play ARM 64 v8a, android-32 | Google APIs ARM 64 v8a, android-32 | Google Play ARM 64 v8a, android-33 | Google APIs ARM 64 v8a, android-Tiramisu | Google APIs ARM 64 v8a, android-Tiramisu | Google Play ARM 64 v8a
      Android NDK: Not Found
  IDEs:
    Android Studio: 2021.1 AI-211.7628.21.2111.8309675
    Xcode: 13.4.1/13F100 - /usr/bin/xcodebuild
  Languages:
    Java: <IP_ADDRESS> - /usr/bin/javac
  npmPackages:
    @react-native-community/cli: Not Found
    react: 18.0.0 => 18.0.0
    react-native: 0.69.5 => 0.69.5
    react-native-macos: Not Found
  npmGlobalPackages:
    *react-native*: Not Found
sa

Paste the exact react-native-track-player version you are using
3.2.0
Real device? Or simulator? real android device - pixel 4 on api 33
What OS are you running? android 13 / api 33
How I can Help
What can you do to help resolve this?
Have you investigated the underlying JS or Swift/Android code causing this bug?
Can you create a Pull Request with a fix?

Please read this issue
https://github.com/doublesymmetry/react-native-track-player/issues/1702#issuecomment-1240483764

Thanks @jspizziri ! I did try looking for related issues before opening this one but clearly missed that one 🤦

@jspizziri Can we re-open this.
I'm seeing this same issue on the example app in this repo, making only these changes necessary to repro:
diff --git a/example/src/services/SetupService.ts b/example/src/services/SetupService.ts
index ef02e38..774b9b3 100644
--- a/example/src/services/SetupService.ts
+++ b/example/src/services/SetupService.ts
@@ -21,14 +21,15 @@ export const SetupService = async (): Promise<boolean> => {
       capabilities: [
         Capability.Play,
         Capability.Pause,
-        Capability.SkipToNext,
-        Capability.SkipToPrevious,
+        Capability.JumpForward,
+        Capability.JumpBackward,
         Capability.SeekTo,
       ],
       compactCapabilities: [
         Capability.Play,
         Capability.Pause,
-        Capability.SkipToNext,
+        Capability.JumpForward,
+        Capability.JumpBackward,
       ],
       progressUpdateEventInterval: 2,
     });

It should show the rewind icon and forward icon with these changes, instead of the skip track backward/forward icons, right?

@sam1463
Did you solve the problem?
I have the same problem.

@sam1463 Did you solve the problem? I have the same problem.

@jspizziri can you re-open this issue? It's still occurring on the current version of the library (3.2.0) and is easily reproducible in the example app.

Seems like this is still an issue on the example project.

So it looks like the cause is a behavior change in Android 13: https://developer.android.com/about/versions/13/behavior-changes-13#playback-controls

I fixed this for the most part in the KotlinAudio library through https://github.com/doublesymmetry/KotlinAudio/pull/64

I'm also seeing Capability.SeekTo not being respected on lockscreens on Android 11 and 12. Could this be related or is there another potential issue?

As you can see the progress bar is blank and I can't scroll through it, even though I have the seekTo capability active. Does this belong here or should I create a new issue? This was on a Samsung device, if that is any help.

Tried 4.0-rc1 and seekto, jumpforward and jumpbackward seem to work, but I'm not seeing RemotePlay and RemotePause events come in. I verified it on the example app as well.

Tried 4.0-rc1 and seekto, jumpforward and jumpbackward seem to work, but I'm not seeing RemotePlay and RemotePause events come in. I verified it on the example app as well.

This is unrelated to this particular issue. Please use discord to ask questions and create distinct issues for new issues.

Considering this fixed.