[OAuth2] Incompatibility with access_token responses without "expire_in"

Title: oauth2 filter is incompatible with authorization servers that omit expire_in on access_token responses
Description:
When configuring the oauth2 HTTP filter against an RFC 6749-compliant OAuth 2.0 authorization server, the auth flow fails if the access_token response does not contain an expire_in field.
Repro steps:
Setup Envoy oauth2 HTTP filter against an RFC 6749-compliant authorization server that does not return the expire_in field on the access_token response, such as GitHub.
Admin and Stats Output: Not relevant
Config:
http_filters:
- name: envoy.filters.http.oauth2
  typed_config:
    "@type": type.googleapis.com/envoy.extensions.filters.http.oauth2.v3alpha.OAuth2
    config:
      token_endpoint:
        cluster: github-oauth
        uri: https://github.com/login/oauth/access_token
        timeout: 3s
      authorization_endpoint: https://github.com/login/oauth/authorize
      redirect_uri: "https://example.org/callback"
...

Logs:
Starting with the response headers of the access_token request as sent by the Envoy OAuth 2.0 client implementation.
Relevant log line: No access token or expiration after asyncGetAccessToken
[2020-12-30 13:54:59.295][138392][debug][http] [source/common/http/async_client_impl.cc:99] async http request response headers (end_stream=false):                                                                 ':status', '200'
'date', 'Wed, 30 Dec 2020 12:54:59 GMT'                                                                                'content-type', 'application/json; charset=utf-8'
'transfer-encoding', 'chunked'
'server', 'GitHub.com'
'status', '200 OK'
'vary', 'X-PJAX,Accept-Encoding, Accept, X-Requested-With,Accept-Encoding'
'etag', '<redacted>'
'cache-control', 'max-age=0, private, must-revalidate'
'strict-transport-security', 'max-age=31536000; includeSubdomains; preload'
'x-frame-options', 'deny'
'x-content-type-options', 'nosniff'
'x-xss-protection', '1; mode=block'
'referrer-policy', 'origin-when-cross-origin, strict-origin-when-cross-origin'
'expect-ct', 'max-age=2592000, report-uri="https://api.github.com/_private/browser/errors"'
'content-security-policy', 'default-src 'none'; base-uri 'self'; block-all-mixed-content; connect-src 'self' uploads.github.com www.githubstatus.com collector.githubapp.com api.github.com github-cloud.s3.amazonaw
s.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com cdn.optimizely.com logx.optimize
ly.com/v1/events wss://alive.github.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com; frame-ancestors 'none'; frame-src render.githubusercontent.com; img-src 'self' data: githu
b.githubassets.com identicons.github.com collector.githubapp.com github-cloud.s3.amazonaws.com *.githubusercontent.com; manifest-src 'self'; media-src 'none'; script-src github.githubassets.com; style-src 'unsafe
-inline' github.githubassets.com; worker-src github.com/socket-worker-5029ae85.js gist.github.com/socket-worker-5029ae85.js'
'x-github-request-id', 'BC8C:90EB:916225:CC179B:5FEC78A3'
'x-envoy-upstream-service-time', '134'

[2020-12-30 13:54:59.295][138392][trace][http] [source/common/http/async_client_impl.cc:116] async http request response data (length=236 end_stream=false)
...
[2020-12-30 13:54:59.298][138392][debug][upstream] [source/extensions/filters/http/oauth2/oauth_client.cc:92] No access token or expiration after asyncGetAccessToken
[2020-12-30 13:54:59.298][138392][debug][http] [source/common/http/filter_manager.cc:827] [C1][S16538478899231496212] Sending local reply with details

Call Stack: Not relevant
Additional information
RFC 6749 Section 5.1 states:

expires_in
RECOMMENDED.  The lifetime in seconds of the access token.  For
example, the value "3600" denotes that the access token will
expire in one hour from the time the response was generated.
If omitted, the authorization server SHOULD provide the
expiration time via other means or document the default value.

In short, authorization server implementations do not have to provide the expires_in parameter in their access_token request response.
For example, GitHub does not set this parameter: (https://docs.github.com/en/free-pro-team@latest/developers/apps/authorizing-oauth-apps)
{
  "access_token":"e72e16c7e42f292c6912e7710c838347ae178b4a",
  "scope":"repo,gist",
  "token_type":"bearer"
}

The Envoy OAuth 2.0 client implementation interprets this field as mandatory though. It rejects any responses without the expired_in parameter
https://github.com/envoyproxy/envoy/blob/7e3b483bbb004bf2b8234e3ec2be6ceef254a2f9/source/extensions/filters/http/oauth2/oauth_client.cc#L91-L95
Proposed Fix
#14625
The Envoy oauth2 filter token config should have a field default_expires_in or similar, that when specified, allows responses without the expires_in field to pass. In the absence of the expires_in field, it should use that default value from the config file as the token expiration parameter.

Until then, here's an ugly patch for testing / demonstration. This patch just ignores the expired_in parameter entirely and hardcodes it to 3600.
With this patch and #14538, the oauth2 token works with the GitHub OAuth App feature.
diff --git a/source/extensions/filters/http/oauth2/oauth_client.cc b/source/extensions/filters/http/oauth2/oauth_client.cc
index 170d4a9a2..16f807c14 100644
--- a/source/extensions/filters/http/oauth2/oauth_client.cc
+++ b/source/extensions/filters/http/oauth2/oauth_client.cc
@@ -88,14 +88,14 @@ void OAuth2ClientImpl::onSuccess(const Http::AsyncClient::Request&,

   // TODO(snowp): Should this be a pgv validation instead? A more readable log
   // message might be good enough reason to do this manually?
-  if (!response.has_access_token() || !response.has_expires_in()) {
-    ENVOY_LOG(debug, "No access token or expiration after asyncGetAccessToken");
+  if (!response.has_access_token()) {
+    ENVOY_LOG(debug, "No access token after asyncGetAccessToken");
     parent_->sendUnauthorizedResponse();
     return;
   }

   const std::string access_token{PROTOBUF_GET_WRAPPED_REQUIRED(response, access_token)};
-  const std::chrono::seconds expires_in{PROTOBUF_GET_WRAPPED_REQUIRED(response, expires_in)};
+  const std::chrono::seconds expires_in{3600};
   parent_->onGetAccessTokenSuccess(access_token, expires_in);
 }

Filter:
name: envoy.filters.http.oauth2
typed_config:
  "@type": type.googleapis.com/envoy.extensions.filters.http.oauth2.v3alpha.OAuth2
  config:
    token_endpoint:
      cluster: github-oauth
      uri: https://github.com/login/oauth/access_token
      timeout: 3s
    authorization_endpoint: https://github.com/login/oauth/authorize
    redirect_uri: "<URL_TO_SELF>/callback"
    redirect_path_matcher:
      path:
        exact: /callback
    signout_path:
      path:
        exact: /signout
    credentials:
      client_id: <YOUR_GITHUB_CLIENT_ID>
      token_secret:
        name: github-oauth-client-secret
      hmac_secret:
        name: github-oauth-hmac

Cluster:
name: github-oauth
connect_timeout: 5s
type: LOGICAL_DNS
lb_policy: ROUND_ROBIN
load_assignment:
  cluster_name: github-oauth
  endpoints:
  - lb_endpoints:
    - endpoint:
        address:
          socket_address:
            address: github.com
            port_value: 443
transport_socket:
  name: tls
  typed_config:
    "@type": type.googleapis.com/envoy.extensions.transport_sockets.tls.v3.UpstreamTlsContext
    sni: github.com

cc: @williamsfu99

cc: @williamsfu99

I'll have a go at fixing this today if you don't mind.

I'll have a go at fixing this today if you don't mind.

@terorie
Thanks so much for raising this issue and providing so much detail! I don't mind - let me know if you need me to review or to submit a PR - I have time today.

@terorie
Thanks so much for raising this issue and providing so much detail! I don't mind - let me know if you need me to review or to submit a PR - I have time today.

@williamsfu99 Thanks for your quick response and helping me with this. I would appreciate a look at #14625. I'm very new to Envoy, so if the code isn't any good, feel free to submit your own PR. In the meantime, I'm going to add tests later today.

@williamsfu99 Thanks for your quick response and helping me with this. I would appreciate a look at #14625. I'm very new to Envoy, so if the code isn't any good, feel free to submit your own PR. In the meantime, I'm going to add tests later today.

Please remove the stale label. Envoy is still incompatible with GitHub's OAuth 2.0 provider.

Sorry to barge in, but is there a workaround or my best option are to compile envoy with hardcodesexpired_in?

It seems this is still an issue when attempting to authenticate against Github.
2022-07-04T10:02:21.394561Z	debug	envoy http	async http request response headers (end_stream=false):
':status', '200'
'server', 'GitHub.com'
<snip>
2022-07-04T10:02:21.394691Z	debug	envoy upstream	No access token or expiration after asyncGetAccessToken
2022-07-04T10:02:21.394777Z	debug	envoy http	[C727][S1785646932291492729] encoding headers via codec (end_stream=false):
':status', '401'
<snip>

Frustrating issue that wasn't too clear until I found this thread: it's very hard to find results for debugging GIthub's own products!

@orHayoun @DiamondJoseph I am working on fixing #14625 today.


Newly created account should need approval before user can log in

My actions before raising this issue

[x] Read/searched the docs
[x] Searched past issues

Currently when new user creates account, it immediately can log in and see project, tasks, etc. It is absolutely no go! This configuration makes CVAT impossible to be used on publicly accessible server.
Expected Behaviour

New user shouldn't be possible to login until account is approved by administrator or superuser.
Current Behaviour
New user creates account and logs in and see all project internal. Any malicious user could register!

Possible Solution

Provide account approval flow.
Steps to Reproduce (for bugs)

Create account over Create account link from login page and then login to see project, tasks, etc.
Context

n/a
Your Environment

Git hash commit (git log -1): 226c2f2
Docker version docker version (e.g. Docker 17.0.05): 20.10.2
Are you using Docker Swarm or Kubernetes? n/a
Operating System and version (e.g. Linux, Windows, MacOS): n/a
Code example or link to GitHub repo or gist to reproduce problem: n/a
Other diagnostic information / logs: n/a

Next steps
n/a

Duplicate of #1030, as a workaround please use the parameter 'reduce_task_visibility' (now is on line 437) in base.py as Andrey suggested.

Duplicate of #1030, as a workaround please use the parameter 'reduce_task_visibility' (now is on line 437) in base.py as Andrey suggested.

@bsekachev @valeriyvan I did this process but i does not work. I didnt understand why? After ı changed reduce_task_visibility as True, ı rebuilded cvat using docker-compose up -d. However no change. I mean that ı can not build changing of reduce_task_visibility. I think there is something ı dont know.

@omersefaztrk Answered you in the other issue, docker-compose up -d doesn't build images, you should use  --build flag :docker-compose -f docker-compose.yml -f docker-compose.dev.yml up -d --build. Please read the docker-compose documentation or our installation guide.

Thanks. It works


Ignore non basic auth secret annotations

Previously if a secret was annotated, kpack would assume it was a basic auth secret even if it was a dockerconfig secret which would prevent it from being used in a build.
Found by @jamespollard8

Codecov Report

Merging #422 into master will increase coverage by 0.24%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #422      +/-   ##
==========================================
+ Coverage   67.08%   67.33%   +0.24%
==========================================
  Files          85       85
  Lines        3625     3612      -13
==========================================
  Hits         2432     2432
+ Misses        907      894      -13
  Partials      286      286

Impacted Files
Coverage Δ

pkg/git/fetch.go
60.41% <ø> (ø)

pkg/git/git_keychain.go
80.32% <ø> (ø)

pkg/git/k8s_git_keychain.go
89.47% <ø> (ø)

pkg/git/remote_git_resolver.go
95.34% <ø> (ø)

pkg/apis/build/v1alpha1/build_pod.go
97.84% <100.00%> (+0.27%)
:arrow_up:

pkg/apis/build/v1alpha1/source_resolver.go
0.00% <0.00%> (-6.07%)
:arrow_down:

...erimental/v1alpha1/custom_cluster_builder_types.go
0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 520fadc...8afc449. Read the comment docs.


Pagination + Search

Is it possible for dashboard using pagination + search? so admin can easily search vpn configuration.
Because for now, to load 500+ users configuration, it takes around 8-10s.. After scrolling, it will glitch and takes another 5s or more...
Thank you!

i will add a table view (issue #27) after SSO implementation.
Hopefully this weekend

i will add a table view (issue #27) after SSO implementation.
Hopefully this weekend

Thank you! Take your time @vx3r ! Keep safe, stay healthy!

please reopen if needed


HTML5 required validity does not work with OSelect component with a placeholder

Overview of the problem
Oruga version: [0.7.0]
Vuejs version: [3.3.13]
OS/Browser: Firefox 125.0.3 on macOS
Description
When using an OSelect component with a placeholder, the component shows as "valid" when no option has been chosen.
Steps to reproduce
const value = ref(null);
const mySelectRef = ref(null);

<OSelect ref="mySelectRef" v-model="value" placeholder="Select me!">
  <option value="pickme">Pick me</option>
</OSelect>

Expected behavior
mysSelectRef.checkHtml5Validity() === false
Actual behavior
mysSelectRef.checkHtml5Validity() === true
Additional details
Upon inspecting things further the "value" of the select element is the placeholder text "Select me!" instead of being blank. This is due to the option having the :value="null" thus no value attribute is actually set on the option so the browser falls back to the inner text of the option.
This also occurs in the current 0.8.9 and also occurs in Google Chrome. Thus it is not isolated to a specific oruga version nor browser.
Possible solutions

use empty string "" as the not-selected value.  This will fix the issue in part as the browser will correctly understand the chosen value. But it messes with the modelValue if the user really wants null to be unselected.
customize checkHtml5Validity() for this component handle this situation explicitly.

I wouldn't just customize checkHtml5Validity; we'd also want the underlying <select> to register as an invalid element on the browser's side of things so it blocks form submission. As far as I'm aware, the empty-string-valued option and setCustomValidity are the only viable options there. and the latter has its own issues; for instance, it requires the caller to select a validation error message, which may not match the browser's default.

I don't know of a good quick fix for this yet. If anyone has an idea, I would be glad to hear it!

I'd say the most semantically valid option would be to require the model value of <OSelect> to be a non-nullable string. It would then be the user's responsibility to define a bijective mapping between the string values and the actual domain values from which they want to select. This would be a breaking change, though; I'm sure the use of a null model value (and even the use of objects as the model value!) happens in the wild even though it deviates from the DOM standard (which specifies that <select>/<option> values are strings).
We might be able to add some mapping code such that modelValue is transformed from null to an empty string when interacting with the DOM, but we'd still have to determine how to react when firing update:modelValue events. It would likely be unintuitive for users if passing :modelValue = "null" selects the placeholder, but selecting the placeholder from the user interface emits "" as the model value. Most of the solutions I can think of to that issue are either unreliable or clunky. For instance, if we try to detect that the parent component has ever passed a null modelValue, that doesn't help detect cases where the modelValue is expected to be nullable but started out non-null. If we require an additional prop to signal nullability, we basically might as well just have the parent component handle the logic to map empty strings to/from null.

@blm768 I have made a suggestion to solve the placeholder problem. Please take a look and let me know what you think.

I wasn't previously aware of the options prop; that does help somewhat to solve the issues with using non-string option values. There may be more iteration we'll need on that to settle on the optimal design, though. I wonder if the best direction would actually be to have a low-level selection component that takes <option> values as slots and only supports strings for its modelValue and then have a higher-level wrapper around it with an options prop and the ability to take arbitrary model values.

So unless someone has a really better implementation idea for now, I think I will merge #964 as is into the next release. We can try it out and tweak it as needed.


Adding support for gossip as an alternative to lookupd

@stephensearles thanks for pushing this forward, I have a few comments I'll put inline

Having dug in a little more now I see there are quite a few changes to RegistrationDB in this PR.  I'll admit that its API might benefit from improvement but I can't help but feel like some of this is busy work.
I guess, more generally, why don't we outline and discuss the changes you're proposing to RegistrationDB and settle on things that make sense and are necessary (for whatever reason) for these gossip changes.
Perhaps we can defer some of the naming/cleanup changes to a follow-up PR.

Yeah, I think part of the problem was that I misunderstood the design of RegistrationDB while I did most of that work. I do think it could stand some improvement, but I agree that it may work better in a separate PR.

gotta re-add the serf dependency to Godeps

this diff fixed things up for me (serf must have added AdvertisePort at some point):
diff --git a/Godeps b/Godeps
index 36f5b21..43ed0a5 100644
--- a/Godeps
+++ b/Godeps
@@ -6,3 +6,4 @@ github.com/bitly/go-simplejson          fc395a5db941cf38922b1ccbc083640cd76fe4bc
 github.com/bmizerany/perks/quantile     6cb9d9d729303ee2628580d9aec5db968da3a607
 github.com/mreiferson/go-options        2cf7eb1fdd83e2bb3375fef6fdadb04c3ad564da
 github.com/mreiferson/go-snappystream   307a466b220aaf34bcee2d19c605ed9e96b4bcdb # v0.2.0
+github.com/hashicorp/serf               5e0771b8d61bee28986087a246f7611d6bd4a87a # v0.6.3
diff --git a/nsqd/gossip.go b/nsqd/gossip.go
index 0c26c74..df6ca46 100644
--- a/nsqd/gossip.go
+++ b/nsqd/gossip.go
@@ -82,8 +82,8 @@ func initSerf(opts *nsqdOptions,
        serfConfig.Tags["h"] = hostname
        serfConfig.Tags["v"] = util.BINARY_VERSION
        serfConfig.NodeName = net.JoinHostPort(opts.BroadcastAddress, strconv.Itoa(tcpAddr.Port))
-
        serfConfig.MemberlistConfig.AdvertiseAddr = broadcastAddr.String()
+       serfConfig.MemberlistConfig.AdvertisePort = gossipAddr.Port
        serfConfig.MemberlistConfig.BindAddr = gossipAddr.IP.String()
        serfConfig.MemberlistConfig.BindPort = gossipAddr.Port
        serfConfig.MemberlistConfig.GossipInterval = 100 * time.Millisecond

OK, so after pulling down these changes and testing locally, I can apply the following diff and the tests pass (the diff is really just removing all the networking related changes, leaving only the improvements to the test related to convergence).
This is inline with what I expected - I feel like the hostnames on your local machine aren't resolving correctly and I'm not convinced this implies that the implementation needs to change.  Also, the code reads correct to me with this diff applied (as we briefly discussed in #nsq).
In a production deployment these knobs would all be configurable, so I don't think we're limiting things in any way.
diff --git a/nsqd/gossip.go b/nsqd/gossip.go
index 09df7c7..4e374ce 100644
--- a/nsqd/gossip.go
+++ b/nsqd/gossip.go
@@ -3,7 +3,6 @@ package nsqd
 import (
        "bytes"
        "encoding/json"
-       "fmt"
        "net"
        "os"
        "strconv"
@@ -62,18 +61,17 @@ func memberToProducer(member serf.Member) *registrationdb.Producer {

 func initSerf(opts *nsqdOptions,
        serfEventChan chan serf.Event,
-       tcpAddr *net.TCPAddr, httpAddr *net.TCPAddr, httpsAddr *net.TCPAddr, broadcastAddr *net.TCPAddr) (*serf.Serf, error) {
-       hostname, err := os.Hostname()
-       if err != nil {
-               return nil, err
-       }
+       tcpAddr *net.TCPAddr,
+       httpAddr *net.TCPAddr,
+       httpsAddr *net.TCPAddr,
+       broadcastAddr *net.TCPAddr) (*serf.Serf, error) {

-       gossipHost, gossipPortStr, err := net.SplitHostPort(opts.GossipAddress)
+       hostname, err := os.Hostname()
        if err != nil {
                return nil, err
        }

-       gossipPort, err := strconv.Atoi(gossipPortStr)
+       gossipAddr, err := net.ResolveTCPAddr("tcp", opts.GossipAddress)
        if err != nil {
                return nil, err
        }
@@ -90,15 +88,10 @@ func initSerf(opts *nsqdOptions,
        serfConfig.Tags["h"] = hostname
        serfConfig.Tags["v"] = util.BINARY_VERSION
        serfConfig.NodeName = net.JoinHostPort(opts.BroadcastAddress, strconv.Itoa(tcpAddr.Port))
-
-       broadcastAddr.Port = gossipPort
-       opts.Logger.Output(0, fmt.Sprintf("serf: advertising: %s", broadcastAddr))
-       opts.Logger.Output(0, fmt.Sprintf("serf: binding: %s:%d", gossipHost, gossipPort))
-
        serfConfig.MemberlistConfig.AdvertiseAddr = broadcastAddr.IP.String()
-       serfConfig.MemberlistConfig.AdvertisePort = gossipPort
-       serfConfig.MemberlistConfig.BindAddr = gossipHost
-       serfConfig.MemberlistConfig.BindPort = gossipPort
+       serfConfig.MemberlistConfig.AdvertisePort = gossipAddr.Port
+       serfConfig.MemberlistConfig.BindAddr = gossipAddr.IP.String()
+       serfConfig.MemberlistConfig.BindPort = gossipAddr.Port
        serfConfig.MemberlistConfig.GossipInterval = 100 * time.Millisecond
        serfConfig.MemberlistConfig.GossipNodes = 5
        serfConfig.MemberlistConfig.LogOutput = logWriter{opts.Logger, []byte("memberlist:")}
diff --git a/nsqd/gossip_test.go b/nsqd/gossip_test.go
index 8b23139..b504ae4 100644
--- a/nsqd/gossip_test.go
+++ b/nsqd/gossip_test.go
@@ -33,9 +33,8 @@ func TestGossip(t *testing.T) {
                opts.ID = int64(i)
                opts.Logger = newTestLogger(t)
                opts.GossipAddress = addr.String()
-               opts.BroadcastAddress = addr.IP.String()
                if seedNode != nil {
-                       opts.SeedNodeAddresses = []string{seedNode.broadcastAddr.String()}
+                       opts.SeedNodeAddresses = []string{seedNode.opts.GossipAddress}
                }
                tcpAddr, _, nsqd := mustStartNSQD(opts)
                defer nsqd.Exit()

re: your question about how this PR should handle nsqlookupd...
As implemented nsqlookupd is still fully supported.  I don't see any reason to change that. It means that nsqd can still register like it always has with an existing nsqlookupd cluster and opens up the door to a variety of operational choices teams can make on how to transition.
A future release can add deprecation warnings, etc. before finally removing it when we're happy & ready.


In documentation all overloads should be on one page

We should try using https://github.com/microsoft/rushstack/blob/6d52e3a640e323435e85b47b72ac785f1ef25cdc/libraries/api-extractor-model/src/items/ApiItem.ts#L193 and put all overloads on a single API reference page.
cc @Lightning00Blade

Closed via https://github.com/puppeteer/puppeteer/pull/12679


Use CURLWrapper module and more options for time zone service.

Two more options for IP time zone detection services.

Now the plugin also supports querying time zone from ipwho.is and ipapi.co, in addition to ip-api.com. Users that have trouble with their time zone being misidentified can try their luck with an alternative service.
HTTP and HTTPS handling is now done with Aroma's CURLWrapper module, replacing the improvised HTTP-only handler from before. This ends up reducing the binary size.

Looks good to me! Thank you, as always, for your amazing work!


Suggestion to add a PreserveReferencesHandling.Auto

So far I've always avoided using PreserveReferencesHandling due to how verbose the json becomes with adding a $id property to all json objects when I might only use the feature once or twice in all of the json. Instead I'd prefer it if Json.NET would only output the $id property on json objects that actually use the feature. This could be specified with a PreserveReferencesHandling.Auto value similar to TypeNameHandling.Auto.
From my understanding, the only barrier to implementing this is that the object graph would need a first pass to identify objects that would use the feature as JsonWriter is a forward only writer. Would this ever be considered if the overall performance is not affected, perhaps by storing the results of the first pass into a struct object tree and then serializing that object tree on the second pass?

What you can do is load JSON into a JToken after serialization and remove all the $ids that don't have a $ref pointing to them. I gave the scriptcs team code that does this a couple of years ago.

Thanks for the idea.


Counter16 benchmarks added with Cocotb Testbenches

Motivate of the pull request

[ ] To address an existing issue. If so, please provide a link to the issue:
[ ] Breaking new feature. If so, please describe details in the description part.

Describe the technical details
What is currently done? (Provide issue link if applicable)

What does this pull request change?

Which part of the code base require a change

[ ] RTL
[ ] Gate-level netlists
[ ] Design Verification
[ ] Physical Design
[ ] Timing characterization
[ ] Documentation
[ ] Regression tests
[ ] Continous Integration (CI) scripts

Impact of the pull request

[ ] Require a change on Quality of Results (QoR)
[ ] Break back-compatibility. If so, please list who may be influenced.

@anaszameer-rs Remember to update the rtl_list.yaml at https://github.com/tangxifan/micro_benchmark/blob/main/simple_registers/rtl_list.yaml


feat: add core service support

Adding support for Windows Core Service and Linux Core Service... Big CI/CD changes overall

Thanks again @RobPasMue for your responsiveness on this mater.


[Playground] GetMetadata() endpoint

Add new endpoint to the Playground runners which returns metadata. Returned metadata includes:

Type of Beam SDK (Java, Go, Python, Scio)
Version of Beam SDK
Commit from which the runner was built
Timestamp of the commit

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

[ ] Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
[ ] Update CHANGES.md with noteworthy changes.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)

See CI.md for more information about GitHub Actions CI.

LGTM

R: @damondouglas
The only failing check is due to snippet renaming, it is addressed in

https://github.com/apache/beam/pull/25033

Not merging it here to simplify separate PRs and reduce conflicts.


try considering supporting macOS?

mac brew install  util-linux：findmnt not found

dupe of #59, please see linked comment
https://github.com/binpash/try/issues/59#issuecomment-1606070746


Add Color position in Y [COLY] axis

Font Project introducing the axis
Bitcount (still a private project)
Short description of what the axis does
The position of the background color moves up and down. Negative values go down and positive values go up in the Y dimension.
Image
Pending
Why is the axis needed
Please provide an expected case of use from the user’s point of view, reasoning on why or how the users might use or would benefit from the axis.
Axis metadata fields
# Color position in Y, based on a still private project
tag: "COLY"
display_name: "Color position in Y"
min_value: -100
default_value: 0
max_value: 100
precision: 0
fallback {
  name: "Default"
  value: 0
}
fallback_only: false
description:
  "The position of the background color moves up and down."

Color position in Y

Should "position" be capitalized?
e.g. Color Position in Y

# YLY1 based on a still private project
tag: "YLY1"
display_name: "Y position Layer 1"
min_value: -100
default_value: 0
max_value: 100
precision: 0
fallback {
  name: "Default"
  value: 0
}
fallback_only: false
description:
  "The position of the layer moves left and right. "
  " Negative values to the left and positive values to the right, "
  " in the Y dimension."

An additional Axis YLY2 should be registered for the second layer, so its axis metadata fields would be
# YLY2 based on a still private project
tag: "YLY2"
display_name: "Y position Layer 2"
min_value: -100
default_value: 0
max_value: 100
precision: 0
fallback {
  name: "Default"
  value: 0
}
fallback_only: false
description:
  "The position of the layer moves left and right. Negative values"
  " to the left and positive values to the right, in the Y dimension."
  " This Layer is closer to the user than Layer 1."

This is agreed with me, @chrissimpkins and @evanwadams :)

In relation to the comment made in "LYSZ", should this axis better be Vertical Position Paint 1 tag YPN1

Last axis definitions revised
YPN1
# YPN1 based on a still private project
tag: "YPN1"
display_name: "Vertical Position Paint 1"
min_value: -100
default_value: 0
max_value: 100
precision: 0
fallback {
  name: "Default"
  value: 0
}
fallback_only: false
description:
  "The position of the paint moves up and down. Negative values"
  " move down and positive values up. Paint 1 is behind Paint 2."

YPN2
# YPN2 based on a still private project
tag: "YPN2"
display_name: "Vertical Position Paint 2"
min_value: -100
default_value: 0
max_value: 100
precision: 0
fallback {
  name: "Default"
  value: 0
}
fallback_only: false
description:
  "The position of the paint moves up and down. Negative values"
  " move down and positive values up.

I updated the prev comment to tweak the wording :) Ship it!

I'll create the PRs, but the font needs to be ready to move forward with the axes regs ;-)


Edit add recommendation form

add recommendation Thymeleaf template form needs to get the user id as a hidden field when the button is pressed. Do that.

Getting the user to the recommendation was done through a controller method.


DROPPED_RTPSPARTICIPANT error while building modules. How to FastRTPS_1.4.0.patch ?

Hi Apollo platform developers,
I wanted to know how to apply the patch "FastRTPS_1.4.0.patch", I couldn't find any documentation on how to do that. I am working inside the docker and encountering the following errors. I think applying the patch will solve the issue.
shifa@in_dev_docker:/apollo$ bazel build //modules/routing:all
INFO: Reading 'startup' options from /apollo/tools/bazel.rc: --batch_cpu_scheduling --host_jvm_args=-XX:-UseParallelGC
INFO: (04-10 14:22:20.458) Found 6 targets...
ERROR: (04-10 14:22:31.558) /apollo/cyber/service_discovery/BUILD:5:1: C++ compilation of rule '//cyber/service_discovery:topology_manager' failed (Exit 1).
cyber/service_discovery/topology_manager.cc: In member function 'bool apollo::cyber::service_discovery::TopologyManager::Convert(const PartInfo&, apollo::cyber::proto::ChangeMsg*)':
cyber/service_discovery/topology_manager.cc:152:10: error: 'DROPPED_RTPSPARTICIPANT' is not a member of 'eprosima::fastrtps::rtps::DISCOVERY_STATUS'
case eprosima::fastrtps::rtps::DISCOVERY_STATUS::DROPPED_RTPSPARTICIPANT:
^
INFO: (04-10 14:22:31.604) Elapsed time: 12.172s, Critical Path: 5.79s
Might be a silly question. Can someone please help me ?

Hi, maybe you can follow @Eclipsehelio 's answer in this issue: https://github.com/ApolloAuto/apollo/issues/7240

Hi @gruminions,
I tried doing what @Eclipsehelio suggested, but I am encountering another error now and still facing the same error building in some other modules.
shifa@in_dev_docker:/apollo$ bazel build //modules/guardian:all
INFO: Reading 'startup' options from /apollo/tools/bazel.rc: --batch_cpu_scheduling --host_jvm_args=-XX:-UseParallelGC
INFO: (04-11 17:33:54.404) Found 2 targets...
ERROR: (04-11 17:33:54.572) /apollo/cyber/BUILD:67:1: Linking of rule '//cyber:cyber_core' failed (Exit 1).
/usr/bin/ld: //usr/local/lib/libglog.a(libglog_la-logging.o): relocation R_X86_64_32 against `.rodata' can not be used when making a shared object; recompile with -fPIC
//usr/local/lib/libglog.a: error adding symbols: Bad value
collect2: error: ld returned 1 exit status
INFO: (04-11 17:33:54.606) Elapsed time: 0.642s, Critical Path: 0.04s
shifa@in_dev_docker:/apollo$ bazel build //modules/data:all
INFO: Reading 'startup' options from /apollo/tools/bazel.rc: --batch_cpu_scheduling --host_jvm_args=-XX:-UseParallelGC
INFO: (04-11 16:42:33.229) Found 6 targets...
ERROR: (04-11 16:42:38.559) /apollo/cyber/service_discovery/BUILD:5:1: C++ compilation of rule '//cyber/service_discovery:topology_manager' failed (Exit 1).
cyber/service_discovery/topology_manager.cc: In member function 'bool apollo::cyber::service_discovery::TopologyManager::Convert(const PartInfo&, apollo::cyber::proto::ChangeMsg*)':
cyber/service_discovery/topology_manager.cc:152:10: error: 'DROPPED_RTPSPARTICIPANT' is not a member of 'eprosima::fastrtps::rtps::DISCOVERY_STATUS'
case eprosima::fastrtps::rtps::DISCOVERY_STATUS::DROPPED_RTPSPARTICIPANT:
^
INFO: (04-11 16:42:38.612) Elapsed time: 6.070s, Critical Path: 4.60s
Anyone has any idea of what should be done ?
Thanks.

@shifakhan4892 were you able to build Apollo normally? Is it only this patch that is causing a build failure?

Closed due to inactivity. If the problem persists, pls feel free to reopen it or create a new one and refer to it.


fix(build): fix rnx-build-apple not being resolved

Description
Fix rnx-build-apple not being resolved correctly in pnpm setups
Test plan
n/a

This looks reasonable, though should the /bin/bash actually be /bin/sh, or are the scripts written specifically for bash shells?

We're using some convenience features that only exist in /bin/bash (and compatible shells).


Breaking change for object

Hi,
I didn't have time to check yet, but we had a user of our library ZfrShopify having a breaking change in last version of Guzzle-Services (downgrading to 1.1.0 fixed the issue).
We have a descriptor that looks like this:
        'GetMetafields' => [
            'httpMethod'       => 'GET',
            'uri'              => 'admin/metafields.json',
            'parameters'       => [
                'metafield' => [
                    'description' => 'Filter metafields by resource type and ID (accepts sub-fields "owner_id" and "owner_resource")',
                    'location'    => 'query',
                    'type'        => 'object',
                    'required'    => false
                ],
            ]
        ]

We called it this way:
$shopifyClient->getMetafields([
  'metafield' => [
    'owner_id' => 123,
    'owner_resource' => 'product'
  ]
]);

This used to properly serializes those parameters as ?metafield[owner_id]=123&metafield[owner_resource]=product
In the last version, it apparently does not work and serialize it as ?metafield=123&metafield=product, so it's a rather big breaking change.
We'll try to have a look but if you already know the reason, it would be nice to revert!

Did you get anywhere with debugging this?

Hi Graham ! That’s a long time ago, I do not really remember. I unfortunately stopped backend development a few years ago.

Ok, I'm going to close this out. :)


Upgrade vcluster to latest version

Context
Upgrade vcluster to the latest available version.
By the time of this issue got created, we're at 0.5.0-beta.0, according to defaults. Also k3s is outdated.
Make sure that Renovate is able to keep the versions up-to-date.
Alternatives
n/a

Fixed by #27 #28 #29 #30 #31


refactor(scripts): use project image asset in list script

Current dependencies on/for this PR:

main

PR #120

PR #121   👈

This stack of pull requests is managed by Graphite.


fix: encount for the new sveltekit vite config placement

The newest SvelteKit has 'vite' placed on a higher level, not within the 'kit' configuration. This PR fixes that, while allowing for older configurations to keep working as well.
https://kit.svelte.dev/docs/configuration

My bad, had my vite config wrong for months now I see.


Unreachable branch in gridPathCells is actually reachable

In gridPathCells, I was able to hit the following branch:
if (currentError) {  // LCOV_EXCL_BR_LINE
    // Expected to be unreachable since cells between `start` and `end`
    // should have valid local IJK coordinates.
    return currentError;  // LCOV_EXCL_LINE
}

By using start = 820807fffffffff and end = 8208e7fffffffff.
Can reproduce with the following patch:
diff --git a/src/apps/testapps/testGridPathCells.c b/src/apps/testapps/testGridPathCells.c
index b5c47321..1b5548f1 100644
--- a/src/apps/testapps/testGridPathCells.c
+++ b/src/apps/testapps/testGridPathCells.c
@@ -39,4 +39,13 @@ SUITE(gridPathCells) {
         t_assert(lineError == E_FAILED,
                  "Line not computable across multiple icosa faces");
     }
+    TEST(gridPathCells_pentagon) {
+        H3Index start = 0x820807fffffffff;
+        H3Index end = 0x8208e7fffffffff;
+
+        H3Index path[3];
+        H3Error lineError = H3_EXPORT(gridPathCells)(start, end, &path);
+        t_assert(lineError == E_FAILED,
+                 "...");
+    }
 }
diff --git a/src/h3lib/lib/localij.c b/src/h3lib/lib/localij.c
index 8b073026..27210721 100644
--- a/src/h3lib/lib/localij.c
+++ b/src/h3lib/lib/localij.c
@@ -713,6 +713,7 @@ H3Error H3_EXPORT(gridPathCells)(H3Index start, H3Index end, H3Index *out) {
         cubeToIjk(&currentIjk);
         H3Error currentError = localIjkToCell(start, &currentIjk, &out[n]);
         if (currentError) {  // LCOV_EXCL_BR_LINE
+            assert(false);
             // Expected to be unreachable since cells between `start` and `end`
             // should have valid local IJK coordinates.
             return currentError;  // LCOV_EXCL_LINE

Running make test-fast will trip the assert.
(I guess it could be a good idea to use assert for unreachable path, at least in debug, to make sure they actually are unreachable)

Thanks for pointing this out. We should remove the exclusion and instead cover those lines.
I'd like to adopt some more ideas from the SQLite testing methodology which includes adding assertions for all defensive code blocks so we can be alerted if testing or fuzzers reach them.


Announcement: Happy Hacktoberfest 2022!

Add Your Favorite Board Game
If you're looking to contribute for Hacktoberfest and would love an "easy win", but don't want to make it to a superfluous repository, then please consider this one and contribute by adding a favorite board game to this list. There's no need to create an issue, just make sure it's not already in the list.
What Is This?
This is an awesome list which lets people show their love for, and recommend, board games. I have some CI tooling set up to 1- check for linting issues and 2- create preview builds so we can view opened PRs with vercel (this is all automatic, you don't need to set anything up).
Common Issues
Image size and improperly formatted tables are the most common culprits. Please follow the contributing and formatting guides, linked to below; they're quick reads and the formatting guide includes an example. If there's an issue with your PR at first, don't worry! I'll help as best as I can and often make code suggestions during a review. If you have questions, ask below in this issue thread of your PR.
How Do I Contribute?
Please read the contributing guide, it's a quick read, and follow the formatting guide, again it's short and includes examples.
If you're concerned about contributions counting towards hacktoberfest, not to worry! I'll mark any accepted PR with the appropriate label and the repo here is marked already.
Please tag your PRs with this issue # if you're contributing during October for Hacktoberfest. I'll close this issue after the end of October. For now, happy contributing!

I want to work on this. Please assign me this.

You are welcome to contribute to this communal list, as this issue describes. It is not an issue to be assigned, but an invitation to contribute.

Thank you to all who participated!
We've added 12 games and had 9 new contributors. For those accepted PRs yours should have been marked with the https://github.com/edm00se/awesome-board-games/labels/hacktoberfest-accepted label to give you credit in the hacktoberfest tracker.


Different color for buffers that are open in windows that are not currently focused?

I would like to use a different color for buffers that are in another window and are not given the current focus, is there a way to do that? And if there isn't could there be? :)

@kdheepak I have a similar request: is possible to have different highlights for select, current, active, inactive, modified buffers?


Update AnacronFiles & LinuxCronTabs and add LinuxScheduleFiles

Include files inside the directories of cron.* Also /var/spool/cron contains further directories.
LinuxScheduleFiles combines all three scheduling artificats into one.

Have removed returned_types =)


Training with direct byte buffer samples

Attempting to add ability to use native byte buffers for training as copying large arrays causes JVM to stall.
My familiarity with JNI is low. Would appreciate assistance.
It looks like the tests are running but they never finish running into this non-stop error message:
Cover must have at least one input file
Cover must have at least one input file
Cover must have at least one input file
Cover must have at least one input file
Cover must have at least one input file
Cover must have at least one input file

@nishemon It looks like you added dict support. Could you take a look, please?

Hi, I am traveling the next two weeks. I will take a look around Christmas. Sorry for the delays

Codecov Report

Merging #50 into master will increase coverage by 1.79%.
The diff coverage is 89.28%.

@@             Coverage Diff              @@
##             master      #50      +/-   ##
============================================
+ Coverage     51.33%   53.13%   +1.79%
- Complexity       86       92       +6
============================================
  Files             8        9       +1
  Lines           563      591      +28
  Branches         96       97       +1
============================================
+ Hits            289      314      +25
- Misses          199      201       +2
- Partials         75       76       +1

@luben Thanks for the ack. I have managed to get the dictionary training with direct byte buffers. It still uses an int array for the sample sizes; I couldn't figure out how to do a size_t array from Java.


Add support for OAuth2 and Send on Behalf of functionality

implements #56
Now passing through the oauth2_token and sobo_email parameters to pydocusign.
This change requires the work from https://github.com/novafloss/pydocusign/issues/76

Thanks for this PR @kbussell
Can you rebase it please ? python 3 support was added.

So sorry it took so long to get to this

@kbussell no problem, I have time :)

@kbussell there is just a flake8 error

Replaced by #69


Refs #22983 -- Added tests for squashing migrations with functions from migration files.

Noticed while checking ticket-28628.
See ebb13bbd884d8c3053d1d342ef0423240feb05e6.

Thanks both for checking :+1:

Are we thinking of switching the migration import pattern in the future?

I don't think it's necessary, see Ad's analysis with my comments (I'm somewhere in the middle :smile:  ).


Introduced the concept of combinedBalance holding the balance of all accounts

I will close this PR for now. Maybe I will come back to this topic in the future.


DO NOT MERGE Testing image update for #15326

Testing image update for #15326

test-me-please

test-race-runtime

test-race-upstream-k8s

test-race-runtime

test-race-runtime

test-race-runtime

test-race-runtime

test-me-please

Runtime race build failed on #14676 https://jenkins.cilium.io/job/Cilium-PR-Runtime-4.9-Race-Detection/20/
Not re-triggering since the correct image was used in the job (question is whether we need it at all, see https://github.com/cilium/cilium/pull/15326#discussion_r593215095)


Add new text entries for 'ru' locale

Add new text entries for 'ru' locale

Why was this closed? @pp2amd6

Open new PR with 'yarn format'


Making an atom without an initial value should return possibly undefined

Closes #116

Looks good. I am going to party now. I will try to merge it tomorrow or after tomorrow.

Can I just fix pnpm test or CI?

Oh, I didn't notice those errors :upside_down_face: You can go ahead and fix them

Never mind, they were fairly straightforward fixes :sweat_smile:


The confidence of bbox deformable detr predicts is very slow

Prerequisite

[X] I have searched the existing and past issues but cannot get the expected help.
[X] I have read the FAQ documentation but cannot get the expected help.
[X] The bug has not been fixed in the latest version.

💬 Describe the reimplementation questions
Deformable detr predicts num_queries bbox with confidence and corrdinates, however, the max score of boxes is always very slow, often below 0.4. How can I increase the score of bboxes?
Environment
。
Expected results
No response
Additional information
No response

Did you use the pre-trained model provided in mmdetection?

Because the detector uses Focal loss, it is common that the scores of boxes are low.


Fix grpc data read thread block with finished instruction_id in _GrpcDataChannel

Input data for completed instructions (especially, failed instruction) can cause the thread of _GrpcDataChannel._read_inputs() and another thread of _GrpcDataChannel.input_elemnts() to be stuck.
The current implementation makes this issue in the following scenario.

Thread A is for gRPC data channel. It reads data elements and puts to queues in _GrpcDataChannel._read_inputs().
Thread B is a work thread for an instruction "process_bundle-10". A work thread runs user code and pulls data elements from the queue for the instruction in _GrpcDataChannel.input_elements() from BundleProcessor.process_bundle().
Thread C is another work thread for an instruction "process_bundle-12".

(Thread A) Read the first chunk of data elements for an instruction "process_bundle-10". This adds a new queue to _received in _receiving_queue() from _read_inputs() and put elements to the queue.
(Thread B) Pull the first element from the queue for "process_bundle-10" in input_elements() and throw an exception during processing the element. This remove the queue with _clean_receiving_queue in input_elements()'s finally clause.
(Thread A) Read remaining chunks of elements for "process_bundle-10". It will add new queue for "process_bundle-10" to _received again!  But, be blocked as queue full (maxsize = 5) indefinitely as there is no work thread pulling data elements  of "process_bundle-10".
(Thread C) Wait on data for another instruction "process_bundle-12" but be blocked at input_elements() because Thread A has no progress for "process_bundle-12" data.

As a solution, I suggest managing completed instructions in _GrpcDataChannel to avoid data elements queue to be restored so that gRPC data channel thread and work threads will have no blocking issue.

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

[ ] Choose reviewer(s) and mention them in a comment (R: @username).
[ ] Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
[ ] Update CHANGES.md with noteworthy changes.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

GitHub Actions Tests Status (on master branch)

See CI.md for more information about GitHub Actions CI.

@robertwb I created a PR for easy review. I added a comment. Please let me know if single commit is preferred. I'll squash the commits into one.

For the lint/formatter, you can run yapf -irp sdks/python/apache_beam/runners/worker/data_plane.py

Accidentally closed and reopen PR.

I fixed Python lint test failure but precheck still fails at Python PreCommit. I guess this failure is due to BEAM-12699, not by my change.
@robertwb  Could you let me know what I should do to merge this change? thanks!

Run Python PreCommit

All looks good now. Thanks for your contribution!


add ignoring WebStorm project folder

Duplicate of https://github.com/vuejs/vue/pull/4383

as @petervmeijgaard said. See #4383 for the explanation


Adding Signal subgraph

Reference Issues/PRs
Fixes #120
What does this implement/fix? Explain your changes.
This adds signal subgraph estimation functionality to the graspy package. Estimation of the signal subgraph of a graph will be achievable through iterative and non-iterative screening measures described in the following paper.
Any other comments?

For the proof notebook, does that need to be in the graspy files or could I just upload it to github and send you guys the link?

NOTE: Proof notebook for PR here

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@4eb5794). Click here to learn what that means.
The diff coverage is 91.33%.

@@            Coverage Diff            @@
##             master     #297   +/-   ##
=========================================
  Coverage          ?   88.16%
=========================================
  Files             ?       38
  Lines             ?     2349
  Branches          ?        0
=========================================
  Hits              ?     2071
  Misses            ?      278
  Partials          ?        0

Impacted Files
Coverage Δ

graspy/__init__.py
100% <100%> (ø)

graspy/subgraph/__init__.py
100% <100%> (ø)

graspy/subgraph/base.py
85.71% <85.71%> (ø)

graspy/subgraph/itscreen.py
92.3% <92.3%> (ø)

graspy/subgraph/nonitscreen.py
96.55% <96.55%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4eb5794...bc0b7c8. Read the comment docs.

I edited the dependencies and now it just depends on mgc since Sambit added the mgc function to the mgc  package.
I tried having scipy 1.4.0 as the dependency for mgc  but I am pretty sure that I cannot have scipy calculate just the test statistic: it always calculates the test statistic and the p-value, per the docs
This makes the computation time much longer. My bad if I am mistaken about this @sampan501
@bdpedigo @j1c
Also it is now giving me an error in Travis when I just have mgc as a dependency for some reason:
"ImportError: cannot import name 'MGC'"

That is likely because I haven't added the version with MGC on PyPi (still testing it)
As for the calculating just the statistic, you can just set reps = 1 and to prevent the warning from showing up use something like in https://stackoverflow.com/questions/14463277/how-to-disable-python-warnings

Now has scipy and mgc
@bdpedigo @j1c

In your tutorial notebooks,

clear all outputs. part of the point of these is for netlify to build them to see if they work properly.
there is a line where you just print S_hat and something else. Not really that useful.
explain the experiment. the conditions, what you are proposing and and why. It can even be simpler in the sense that you can do 2 population instead of 4 for sake of clarity.

@j1c
So forego doing demonstration with three classes and instead just do the demonstration with two classes, but explain in more detail what I am doing?

Yes. The demo notebook should be straight forward for a layman to read so simpler experiment is better

@j1c @bdpedigo I edited the notebooks and cleared all the outputs. When I re-uploaded them, the tests failed due to a Timeout Error. I then commented out part of the code that I thought was causing the Timeout error, and when I did,  the results seen now popped up: it passed the tests but Travis has never stopped running.
Why am I getting a Tiimeout error for my tutorial notebooks?
It said "TimeoutError in tutorials/subgraph/ItScreen.ipynb: 7:53:25 PM: Cell execution timed out"

@bdpedigo @j1c I changed the test statistic in the tutorial notebooks to dcorr instead of mgc and now all the tests pass but Travis never finishes

So apparently Travis can’t build when you have merge conflicts. Fix them and Travis should build

@j1c Im not sure what the error is. I looked at the resolve conflicts and I'm not sure what it is asking. All the versions of softwares required are the same.

Conflicts occur when you and someone else modified the same file(s). pull master to latest commit and merge master into your branch

So I incorporated all of the changes made to graspy and made my code work in Gun's subgraph directory tree. I made a new PR here @j1c @bdpedigo


DEP: change default of atol in scipy.sparse.linalg.*

https://github.com/scipy/scipy/pull/8400 promised to change the default of atol in scipy.sparse.linalg.gcrotmk and has been raising a DeprecationWarning for 4 years. Let's do what needs to be changed to get rid of the warning.
CC @pv

Actually, this applies to many more functions in scipy.sparse.linalg.

I'd like to give this a go as my first contribution to open source.
I'm currently compiling my scipydev environment on macOS

I'd like to give this a go as my first contribution to open source.

Go for it! 🥳
Please take note that there are several separate python files in https://github.com/scipy/scipy/tree/v1.8.0/scipy/sparse/linalg/_isolve where this needs to be adapted; not just in the implementation, but also in the docstrings.

Sure. I have reproduced the DeprecationWarning.
I see there is already a method called _get_atol() in iterative.py, which also contains a very similar deprecation warning that can be triggered by other functions. The objective would be to get rid of all of these, from what I read.
Here is a first draft of a quick fix to remove the deprecation warning from this first function call.
Please do let me know if you think a similar approach would be good for the other affected methods:
_get_atol()
gmres()
lgmres()

I kindly appreciate any feedback you may have.

Please do let me know if you think a similar approach would be good for the other affected methods:
_get_atol()
gmres()
lgmres()

Yes! :)
Everywhere in sparse/linalg/_isolve where you find atol as deprecated.

@pv
You added the following warning to the docstrings of atol (in #8400):
        .. warning::
           The default value for `atol` will be changed in a future release.
           For future compatibility, specify `atol` explicitly.

Since we're trying to execute this deprecation (including the change in default value), could you share what you had in mind as the new default? IMO the only reasonable things would be atol=0 (as any fixed scale might not be adapted to the scale of the problem at hand), but maybe I'm missing something?

Ping @pv, if you could let us know about what the default for atol was intended to be...

@h-vetinari see https://github.com/scipy/scipy/pull/8400#issue-296133417

In the future, we may want to change the default behavior to atol=0.

Yeah, I had seen that, but thought that getting confirmation would be easier. 😅
But fair enough, should be good to proceed with atol=0.

1.10 was released, resetting the milestone to 1.11

To all involved, see the PR above for addressing this for (only) iterative solvers for now. There are probably details that I am missing hence please help me identify the issues a bit better in case I misunderstood.
Currently, we have the following situation;
We have a tol and a strange looking atol keywords. What internally happens is that all the inputs are now passed to a helper function called get_atol
https://github.com/scipy/scipy/blob/maintenance/1.10.x/scipy/sparse/linalg/_isolve/iterative.py#L78-L116

User didn't provide atol then it first maps to None and that causes a warning and internally atol becomes legacy. This means:
a. tol value is checked against the residual norm Ax - b. Note that matvec operation is costly. If the residual norm is already less than tol we exit.
b. Then b norm is checked against 0. Since tol*norm(b) won't do any good we return tol
c. And the typical case is to return tol*norm(b).
User passed legacy all the same as above except the warning.
If atol is actually set to something, then we return max(atol, tol*norm(b)). Why max is used I don't understand.

Typically, atol, rtol pair is used as tol = atol + rtol*<some metric>. This is more or less what everybody expects from this pair and their naming is chosen to reflect this. But I'm a bit lost in all the issues I could read.
What I propose is the following,

Make default atol=0.
If atol is set to string, fire a warning saying this is going away in version 1.13 (hence make the current deprecation on a definite schedule). These are the users probably wanted to keep old behavior. Document how it can be done to match old behavior via atol, rtol.
Introduce a new keyword rtol and map current tol to rtol. Set tol=None as the default to weed out the ones who actually set tol value and fire deprecation warnings for them to use rtol.
Use the formula tol = atol + rtol*norm(b)

@rc : Ping for the memory lane
@jvsqzj for syncing this behavior with gcrotmk, and lgmres

I see some detailed discussion, but I also have limited bandwidth as the release manager so I'm going to bump the milestone to accommodate the imminent branching on May 29th. If you have some fix ready before then, feel free to merge/adjust back.

This will happen in the context of https://github.com/scipy/scipy/pull/18488, which already targets 1.12 👍

@ilayn @h-vetinari can this be closed?

IMO would be OK to close, but I leave the final decision to @ilayn

Sorry forgot to read this. Thanks all.

context for the reopening: https://github.com/scipy/scipy/pull/16050#issuecomment-1839610984

Copying that context here:

https://github.com/scipy/scipy/pull/18488 did not touch gcrotmk and lmgres [...]

So those are still outstanding here. It's a pity we missed this, would have been good to do this in the same cycle. Perhaps if we're fast, a PR could still be backported before GA...

Perhaps if we're fast, a PR could still be backported before GA...

How is gh-16050 looking? want to trigger CI?

How is gh-16050 looking? want to trigger CI?

I merged main there, but I don't think anymore that it's the right approach. It directly switches to errors if atol is not a float, whereas for the other functions we've introduced extensive warnings around that (see _get_atol).

Opened a PR to clean things up, hopefully still for 1.12: #19702. Note that minres / tfqmr had also not been fixed yet (handled in that PR), and that lsmr and lsqr need deeper changes: #19704.


Profile photos in Team page shrinks on mobile devices

The profile images of team members with long name or designations seems to shrink on mobile devices/smaller screens. This might be due to flex box, I think it can be solved by giving the image fixed height and width.

@coderhawk999 @hm-bilal Would you guys like to check up on this? This is still unresolved.
/remind me to update the status of this issue on 20th December

Cool :+1: get @hm-bilal too with you so he can understand the codebase better.


[WIP] Implementation of Kafka Sink for event forwarding.

Ref: #2
This is implemented with the Shopify/sarama library. It is implemented with the AsyncProducer or SyncProducer as a configuration choice.
The integration tests are manual and require docker and docker-compose. They can be found in the tests directory.
Signed-off-by: Chris Dornsife<EMAIL_ADDRESS>

@cdornsife if would help a lot if you could smash to 2 commits 1 - changes , 2 - vendor'd code.

Working through cleaning up my "signed-off-by" disaster I created.

This is working great for us - thank you!

Hey, I'm curious what the status of this PR is. Is there anything what needs to be done / where I can help? I'd like to use this, but I'd prefer a release over a self baked binary based on this PR :)

This project doesn't have an existing example for how to test with attached resources. I created a docker-compose test that doesn't require having eventrouter or kubernetes running in order to test with a real kafka server instead of using the sarama mocks.  It appears that @rsanders is using the code and it works, so now someone can convert the tests to use unit tests with sarama mocks. That would probably be the least invasive route. Or, the maintainer of this repo can specify how they want it. The code works, it's the tests that aren't polished.

I'll enqueue some cycles to get this in, I also need todo a refresh on the deps.


Quick calculator fixes

Closes https://github.com/quantified-uncertainty/squiggle/issues/2516 and https://github.com/quantified-uncertainty/squiggle/issues/2503
I'm not very sure about the useMemo, it kind of seems ugly, would be curious for a second take.

This also solves the case of functions not updating when the Squiggle code updates, but only if the calculator function returns the function directly, and not a dict with the function.


Fix typo in comment of initializer template

Thanks @obfuscoder. I'll look into it.

Wanna pull this PR anytime soon? It's just a typo fix.


Number of workers and Error: Redis connection to <IP_ADDRESS>:6379 failed - read ECONNRESET

Thanks for Kue, it's pretty remarkable.
I'm having a problem with it and I was wondering if Kue has a limit on the number of workers?
In my app I've tried to fork 12 workers using the cluster module.  When I run this it very quickly aborts with the error:
Error: Redis connection to <IP_ADDRESS>:6379 failed - read ECONNRESET
If hard-code the number of workers to just 1 it seems to work ok.

I've got a work around for this problem. It's related to having too many workers and using node-redis.
I've switched over to ioredis and it works well for me now.
This is the code:
var Redis = require('ioredis');

const queue = kue.createQueue({
    prefix: id,
    redis: {
        createClientFactory: function(){
            return new Redis();
        }
    },
});


tqdm (a Python Package) Not Working Correctly in WSL

tqdm is a popular progress bar package in Python, but in my WSL, it behaves incorrectly as the following picture:

The length of the whole frame grows and results in mis-alignment.
Expected behavior is like this:

The length of the frame has a fixed length; only the progress bar grows visually.
Code to reproduce the results:
pip install tqdm
python

from time import sleep
from tqdm import tqdm

for _ in tqdm(range(10000)):
    sleep(0.1)

Environment

OS: Microsoft Windows [Version 10.0.17134.345]
WSL:

$ lsb_release -a
No LSB modules are available.
Distributor ID: Ubuntu
Description:    Ubuntu 18.04.1 LTS
Release:        18.04
Codename:       bionic

Python 3.7.1

Tracking internally as MSFT:19724399

Looks like it's working fine to me:

Can you test on RS5 / October 2018 / Windows 1809 Release / version 17763 and see if it works on that build?
If it doesn't, then I'm assuming that it was fixed sometime after RS5 was snapped. I could try and bisect and find when it was actually fixed, but that'd take away from time I could be using to fix other bugs :P

Hi, thanks for your reply. However, I updated my Surface Pro 4 to Build 1809, and the problem was still there. I noticed that you ran your code via cmd whereas I ran it under Windows Subsystem Linux (installed from Microsoft Store, according to this guide). Do you have any other suggestions?

cmd and wsl both run attached to conhost.exe, which is actually responsible for acting as the terminal application. conhost handles output the same, regardless of how it was launched.
Presumably I fixed it sometime after we stopped committing fixes to RS5 (roughly August) and yesterday. I'd check an Insider's build in a few weeks and see if it still repros on that.


Need to allow dynamic cors whitelisting

We need to allow dynamic cors whitelisting.
https://github.com/ainblockchain/ain-blockchain/blob/master/client/middleware.js#L40
Related issues:

https://github.com/ainblockchain/ain-blockchain/issues/1272

cc: @jiyoung-an

Some sample curl command lines for debugging / testing:
curl http://localhost:8081/json-rpc -X POST -H "Origin: http://aina.ainetwork.ai" --verbose -H "Content-Type: application/json" -d '{
  "jsonrpc": "2.0",
  "id": 1,
  "method": "ain_getAddress",
  "params": {
    "protoVer": "1.1.3"
  }
}'

curl http://localhost:8081/json-rpc -X POST -H "Origin: http://other.example.com" --verbose -H "Content-Type: application/json" -d '{
  "jsonrpc": "2.0",
  "id": 1,
  "method": "ain_getAddress",
  "params": {
    "protoVer": "1.1.3"
  }
}'

curl http://localhost:8081/json-rpc \
  -H "Origin: http://aina.ainetwork.ai" \
  -H "Access-Control-Request-Method: POST" \
  -H "Access-Control-Request-Headers: X-Requested-With" \
  -X OPTIONS --verbose

curl http://localhost:8081/json-rpc \
  -H "Origin: http://other.example.com" \
  -H "Access-Control-Request-Method: POST" \
  -H "Access-Control-Request-Headers: X-Requested-With" \
  -X OPTIONS --verbose

dynamic origin: https://www.npmjs.com/package/cors#configuring-cors-w-dynamic-origin

After some considerations, just decided not to use dynamic origin of cors package for performance reasons.

For performance reasons, just decided not to support it for now.


Don't parse emoticons as commands

Two lines, I have dishonored my family.

Why these two characters, specifically?

For example: !-! or !~! exist

!_!

Don't be silly Rhythms, !_! is already included as an exception.
Perhaps the best thing to do is allow any symbol character that isn't a letter (and maybe numbers if we ever decide to support that, !3! isn't that important)

https://github.com/Zarel/Pokemon-Showdown/commit/bed5a46ff37023e1ba52fe5db7165629e3dd7575


Fix auto-version in nightly builds

https://github.com/KittyCAD/modeling-app/actions/runs/6779833902/job/18436503429#step:4:12
This fails silently, and then goes on to prevent app builds.

Today's nightly worked! https://github.com/KittyCAD/modeling-app/actions/runs/6807244505/job/18510396396


Problem with colour of signs

Description
Hey,
When updating to the latest version of the plugin I see rendering issues with the colours of the signs in the gutter.
I've located this commit as the culprit. Checking out the commit before resolves the issue
Neovim version
0.9.5
Operating system and version
macOS Ventura
Expected behavior
It should look like this:

Actual behavior
It renders like this:

Minimal config
require('gitsigns').setup({
  signs = {
    add          = { text = '█' },
    change       = { text = '█' },
    delete       = { text = '█' },
    topdelete    = { text = '█' },
    changedelete = { text = '█' },
    untracked    = { text = '┆' },
  },
  on_attach = function(bufnr)
    local gs = package.loaded.gitsigns

    local function map(mode, l, r, opts)
      opts = opts or {}
      opts.buffer = bufnr
      vim.keymap.set(mode, l, r, opts)
    end

    -- Navigation
    map('n', ']c', function()
      if vim.wo.diff then return ']c' end
      vim.schedule(function() gs.next_hunk() end)
      return '<Ignore>'
    end, {expr=true})

    map('n', '[c', function()
      if vim.wo.diff then return '[c' end
      vim.schedule(function() gs.prev_hunk() end)
      return '<Ignore>'
    end, {expr=true})
  end
})

Steps to reproduce
Make a change to any version controlled file
Gitsigns debug messages
No response

This change is due to changes in Nvim v0.10. I'll add a guard for the old behaviour.

Thanks for the quick fix!


route: Use prefix_rewrite_ directly

Signed-off-by: Tianyu Xia<EMAIL_ADDRESS>
Commit Message:
Additional Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]

/assign @silverstar194

No issues with this. LGTM

/assign @envoyproxy/envoy-maintainers


Fix kdump test for Mariner

Update correct config file when crash dump needs to be stored in ephemeral disk
Add more nr_cpus when the test machine has more than 56 cores (more than on xeon socket)
Add an option not to kill a process when it timeouts
Add a provision to print additional information before hitting panic

@LiliDeng LGTM, @0xba1a please fix check errors.

@LiliDeng LGTM, @0xba1a please fix check errors.

Fixed the errors. Can you please check now?


question: simple MIDI beeping

Hello,
first of all I'd like to thank you for this nice module. It's great to see it's not a dead project.
I have a problem/question. Let's say I want to create a simple application which writes MIDI beeps on output, Morse code for example. How can I do that? In all examples there is some trigger, like MIDI input, but I want my application to send those signals whenever it wants. Can I do it without callbacks?
I tried this, but it does not work:
import jack

client = jack.Client("MYMIDI")
outport = client.midi_outports.register("output")

@client.set_process_callback
def process(frames):
    outport.clear_buffer()
    i = client.frame_time
    outport.write_midi_event(i, (144, 36, 64))
    i += 1000
    outport.write_midi_event(i, (128, 36, 64))

with client:
    input()

Thanks very much,
Petr

I think i figured it out. This is ugly, but it's working. Huray
import jack

client = jack.Client('WRITEDRUMS')
outport = client.midi_outports.register('output')

c = 0

@client.set_process_callback
def process(frames):
    global c
    outport.clear_buffer()
    if c == 0:
        outport.write_midi_event(0, (144, 36, 64))
        c += frames
    elif c > 100000:
        outport.write_midi_event(0, (128, 36, 64))
        c = -100000
    else:
        c += frames

with client:
    input()

Thanks, I'm glad you find my little JACK module useful.

Can I do it without callbacks?

No, the JACK MIDI functions are only supposed to be used from within the process callback.
Some of the other Python-JACK wrappers might hide the process callback from the user and provide functions to "immediately" send MIDI events, but here you don't have that.
The first argument to write_midi_event() specifies the time in samples starting with 0 at the beginning of the current block.
If you want to create a sequence of events with given time delays (in samples), you'll have to keep a counter similar to what you did in your second example.
If the next event in the sequence falls within the current block, you can use write_midi_event() with the remaining time (in samples since the beginning of the current block).
If the next event in the sequence falls beyond the current block, you have to somehow keep track of it and just wait for the next call of the callback and handle it there.
I'm sorry if this doesn't make sense ... if you still have troubles, feel free to describe a bit more concretely what sequence of events you would like to send, then I can probably give some less confusing advice ...
BTW, frame_time should only be used outside of the process callback, last_frame_time should be used within the process callback.


Add list of volunteers under README.md#Volunteers

There are 7 confirmed external volunteers.
Profile
Name:
Position/Company: (optional!)
LinkedIn/Profile: (optional!)
About Me: (What is your educational background? What do you do? What are you interested in? What do you want the students to know about you?)
Ask Me About: (What are you excited to help with/be asked about?!)
Also make sure volunteers have CWLs: https://activate.id.ubc.ca/iamweb/

@all-contributors please add @alisonmyers for doc, ideas, eventOrganizing, review

@all-contributors please add @alisonmyers  for doc, ideas, eventOrganizing, review

@all-contributors please add @craigdsthompson for doc, ideas, code, eventOrganizing, review

@all-contributors please add @stoosepp for ideas, eventOrganizing

@all-contributors please add @willengle for ideas, eventOrganizing

@all-contributors please add @sanamsh for ideas, eventOrganizing

@all-contributors please add @qhuo for code

@all-contributors please add @vDeoo for code

@all-contributors please add @vDeo for code

@all-contributors please add @jsondoo for code

@all-contributors please add @Crymzix for code

@all-contributors please add @jordancoblin for code

@all-contributors please add @AkimaLunar for code

@all-contributors please add @syin for code

@all-contributors please add @jordancoblin for code

@all-contributors please add @jordancoblin for code

All volunteers have been added now.

@all-contributors please add @qhou for code

@all-contributors please add @jordancoblin for documentation

@all-contributors please add @caropinzonsilva for code


Request service via GET

Will it be possible to call my function via GET? Some apps, like podcasts agregators and rss readers, can only make get requests.

You can --- query parameters map to params.vflags 1:1.
Note that by default, it's an array with items separated by spaces (as passed in). This can be overcome using quotation marks.
i.e.
https://f.stdlib.com/me/ns/f?name=Hello%20World

Maps to
params.vflags.name; // -> ['Hello', 'World'];

And
https://f.stdlib.com/me/ns/f?name="Hello%20World"

Maps to
params.vflags.name; // -> ['Hello World'];


DocsArchive-<IP_ADDRESS>Auto archive content

Please don't merge this PR until target archive repo PR https://github.com/OPS-E2E-PPE/docs-archive-test-target-new/pull/1 is merged into live branch.
Auto archive content to https://github.com/OPS-E2E-PPE/docs-archive-test-target-new.git

Docs Build status updates of commit d2712ca:
:x: Validation status: errors
Please follow instructions here which may help to resolve issue.

File
Status
Preview URL
Details

:x:Error

Details

[Error]

Cannot sync git repo to specified commit because branch Archive_master_2019-09-20-11-20-40 has been deleted or has been force pushed: fatal: Couldn't find remote ref Archive_master_2019-09-20-11-20-40

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


fix: create a modular structure and outsourcing environment variables

:tada: This PR is included in version 1.0.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Add Navtrail with dropdown

This adds a dropdown menu and a user avatar
Not logged

Logged in

big oof 😛

@w3cj this error
Error:   10:23  error  Parse errors in imported module './NavTrail.svelte': '>' expected. (1:8)
import/no-named-as-default

is related to #37 issue

I think you will need to merge with main for the CI checks to pass.

I just have to do another commit for it to recheck it

Your branch is 3 commits behind main, maybe rebase or merge main into your branch.

Regarding the $app multiple import error, I think the fix in the tsconfig.json might have been wrong. Can you try removing the $app aliases in there and add<EMAIL_ADDRESS>to the includes array? I'm not near a PC to try right now.

removing the tsconfig fix results in import/no-unresolved

Please merge / rebase with master. I updated the eslint config to handle multiple $app imports.

Still, we get import/no-named-as-default-member

Looks like the rule import/no-named-as-default-member is the issue instead of import/import/no-named-as-default??

Not sure if it's both or just one of them.

Let's disable these rules for .svelte files specifically. Do you mind opening another PR?
This section in the eslint config can be updated and we can remove 'import/no-named-as-default': 0, in the general rules:
	overrides: [
		{
			files: ['**/*.svelte'],
			parser: 'svelte-eslint-parser',
			parserOptions: {
				parser: '@typescript-eslint/parser',
			},
			rules: {
				'import/no-named-as-default': 0,
				'import/no-named-as-default-member': 0,
			},
		},
	],

btw, I keep getting this warning
`parseForESLint` from parser `@typescript-eslint/parser` is invalid and will just be ignored


Include STL libraries

Recently if I am not including some STL libraries like <limit> and <algorithm>, I couldn't compile the code. Shall we include those libraries in the code?

Thanks! These are necessary additions needed to run on some platforms but I didn't add them in. Thanks for including these lines.


imagemagick-ffmpeg: Update to version 7.1.1-8

Updated checkver and autoupdate to align with the manifests in the main bucket
Also added arm64 architecture

[x] I have read the Contributing Guide.

/verify


NullPointerException: HttpClientPool in org.apache.cxf.Bus using VertxHttpClientHTTPConduitFactory

I tried the now default VertxHttpClientHTTPConduitFactory (using URLConnectionHTTPConduitFactory currently) and my tests are failing with:
[...]
Caused by: java.lang.NullPointerException: HttpClientPool in org.apache.cxf.Bus
	at java.base/java.util.Objects.requireNonNull(Objects.java:259)
	at io.quarkiverse.cxf.HTTPConduitImpl$3.createConduit(HTTPConduitImpl.java:55)
	at io.quarkiverse.cxf.QuarkusHTTPConduitFactory.configure(QuarkusHTTPConduitFactory.java:74)
	at io.quarkiverse.cxf.QuarkusHTTPConduitFactory.createConduit(QuarkusHTTPConduitFactory.java:68)
	at org.apache.cxf.transport.http.HTTPTransportFactory.getConduit(HTTPTransportFactory.java:237)
	at org.apache.cxf.binding.soap.SoapTransportFactory.getConduit(SoapTransportFactory.java:226)
	at org.apache.cxf.binding.soap.SoapTransportFactory.getConduit(SoapTransportFactory.java:233)
	at org.apache.cxf.endpoint.AbstractConduitSelector.createConduit(AbstractConduitSelector.java:144)
	at org.apache.cxf.endpoint.AbstractConduitSelector.getSelectedConduit(AbstractConduitSelector.java:108)
	at org.apache.cxf.endpoint.UpfrontConduitSelector.selectConduit(UpfrontConduitSelector.java:77)
	at org.apache.cxf.endpoint.ClientImpl.getConduit(ClientImpl.java:973)
	at de.someproject.SoapApiClientSupport.getConduit(TspSoapApiClientSupport.java:36)
	[...]

The conduit lookup looks like this:
import org.apache.cxf.frontend.ClientProxy;
import org.apache.cxf.transport.http.HTTPConduit;

    @CXFClient
    private final MyPortType myPortType;

    public HTTPConduit getConduit() {
        return (HTTPConduit) ClientProxy.getClient(myPortType).getConduit();
    }

Any ideas?

Hint: Debugger nevers stops in VertxWebClientRecorder so it's not called apparently.

Turns out that it must have something to do with the test (dependency?) setup for those two affected maven modules because when those modules end up in my bigger Quarkus app (that is then operated as a container), the issue does not occur!

Couldn't it be an initialization order problem? From where is the client called in the failing test? Is it early at application starup by any chance?
Another option could be that you have two Bus instances in your test for some reason? What kind of test is it?

Anyway, registering the HttpClientPool instance on the Bus was motivated by my intention to eventually donate the VertxHttpClientConduit stuff to CXF - so I wanted to keep it independent of Quarkus as far as possible. I gave up on that in 3.16 and therefore we could actually get rid of VertxWebClientRecorder and rather rely on Arc.container().instance(HttpClientPool.class) in io.quarkiverse.cxf.HTTPConduitImpl$3.createConduit(HTTPConduitImpl.java:55)

@famod would you like to test this fix? https://github.com/quarkiverse/quarkus-cxf/pull/1598


Policyfile: Cannot install cookbooks using lock.json from Artifactory source

Description
When installing cookbooks from a lock file, the http client object (required for Artifactory integration) does not get built.
This is unique to artifact resolution from lock.json vs. the policyfile compiler.
It only reproduces when there is no local cache available for the remote cookbook from Artifactory (policy lock was generated on separate machine for exmaple).
ChefDK Version
ChefDK 3.6.57
Platform Version
Windows 10
Replication Case
Setup a policyfile that resolves artifacts from Artifactory.
Ensure valid API key is set in chef config file.
Generate lock.json, pulling cookbooks down from Artifactory (should work):
chef install .\policy.rb
Ensure downloaded cookbooks are removed from the local cache:
rm -Recurse C:\Users\example\AppData\Local\chefdk\
Install cookbooks from the lockfile, pulling from Artifactory:
chef install .\policy.lock.json
Output:
Installing cookbooks from lock
Installing chef_handler            3.0.3
Error: Failed to install cookbooks from lockfile
Reason: (NoMethodError) undefined method `streaming_request' for nil:NilClass

Stacktrace
--> #0  CookbookOmnifetch::ArtifactoryLocation.install at C:/opscode/chefdk/embedded/lib/ruby/gems/2.5.0/gems/cookbook-omnifetch-0.8.0/lib/cookbook-omnifetch/artifactory.rb:43
    #1  ChefDK::Policyfile::CookbookLocationSpecification.ensure_cached at C:/opscode/chefdk/embedded/lib/ruby/gems/2.5.0/gems/chef-dk-3.6.57/lib/chef-dk/policyfile/cookbook_location_specification.rb:81
    #2  ChefDK::Policyfile::CookbookLock.install_locked at C:/opscode/chefdk/embedded/lib/ruby/gems/2.5.0/gems/chef-dk-3.6.57/lib/chef-dk/policyfile/cookbook_locks.rb:79
    #3  block in ChefDK::PolicyfileLock.block in install_cookbooks at C:/opscode/chefdk/embedded/lib/ruby/gems/2.5.0/gems/chef-dk-3.6.57/lib/chef-dk/policyfile_lock.rb:297
    ͱ-- #4  Hash.each at C:/opscode/chefdk/embedded/lib/ruby/gems/2.5.0/gems/chef-dk-3.6.57/lib/chef-dk/policyfile_lock.rb:295
    #5  ChefDK::PolicyfileLock.install_cookbooks at C:/opscode/chefdk/embedded/lib/ruby/gems/2.5.0/gems/chef-dk-3.6.57/lib/chef-dk/policyfile_lock.rb:295
    #6  ChefDK::PolicyfileServices::Install.install_from_lock at C:/opscode/chefdk/embedded/lib/ruby/gems/2.5.0/gems/chef-dk-3.6.57/lib/chef-dk/policyfile_services/install.rb:156
    #7  ChefDK::PolicyfileServices::Install.run(cookbooks_to_update#Array, exclude_deps#FalseClass) at C:/opscode/chefdk/embedded/lib/ruby/gems/2.5.0/gems/chef-dk-3.6.57/lib/chef-dk/policyfile_services/install.rb:61
    #8  ChefDK::Command::Install.run(params#Array) at C:/opscode/chefdk/embedded/lib/ruby/gems/2.5.0/gems/chef-dk-3.6.57/lib/chef-dk/command/install.rb:78
    #9  ChefDK::Command::Base.run_with_default_options(params#Array) at C:/opscode/chefdk/embedded/lib/ruby/gems/2.5.0/gems/chef-dk-3.6.57/lib/chef-dk/command/base.rb:58```

Happening exactly the same here. Any idea about how to solve or workaround this? Thank you very much!

Got some good feedback from @danielsdeleo on the community slack related to where this could be getting called in the code:

If you want to start digging, lib/chef-dk/policyfile/cookbook_location_specification.rb:99 is the only place we call CookbookOmnifetch.init... you could try printf-debugging the args passed in, and use p caller to print the call stack at that point
you would be looking for a case where the source_options has artifactory: "SOME_URL" but http_client: is not set or is nil


Name of file folder in navigation input field

is not deleted when author creates a new page or folder, so the same name appears in the input field again next time.

published with version 1.3.5


Error occurred when executing TripoRefineModel:  Failed to generate mesh: refine for v2.0 is not supported

Error occurred when executing TripoRefineModel:
Failed to generate mesh: refine for v2.0 is not supported
File "C:\Users\user\Documents\GitHub\ComfyUI\ComfyUI\execution.py", line 323, in execute
output_data, output_ui, has_subgraph = get_output_data(obj, input_data_all, execution_block_cb=execution_block_cb, pre_execute_cb=pre_execute_cb)
File "C:\Users\user\Documents\GitHub\ComfyUI\ComfyUI\execution.py", line 198, in get_output_data
return_values = _map_node_over_list(obj, input_data_all, obj.FUNCTION, allow_interrupt=True, execution_block_cb=execution_block_cb, pre_execute_cb=pre_execute_cb)
File "C:\Users\user\Documents\GitHub\ComfyUI\ComfyUI\execution.py", line 169, in map_node_over_list
process_inputs(input_dict, i)
File "C:\Users\user\Documents\GitHub\ComfyUI\ComfyUI\execution.py", line 158, in process_inputs
results.append(getattr(obj, func)(**inputs))
File "C:\Users\user\Documents\GitHub\ComfyUI\ComfyUI\custom_nodes\ComfyUI-Tripo_init.py", line 182, in generate_mesh
raise RuntimeError(f"Failed to generate mesh: refine for v2.0 is not supported")
anyone has a solution?

Refine is only for v1.4 and v1.3, not for v2.0.


Conflict with Turn Marker in V9

Observed on Version 9 - Build 238
[Detected 2 packages: turnmarker, drag-ruler]
    at modules/turnmarker/scripts/turnmarker.js:96
    at Function._call (foundry.js:294)
    at Function.callAll (foundry.js:253)
    at ClientDatabaseBackend.callback (foundry.js:10216)
    at foundry.js:10186
    at Array.map (<anonymous>)
    at ClientDatabaseBackend._handleUpdateEmbeddedDocuments (foundry.js:10186)
    at ClientDatabaseBackend._updateEmbeddedDocuments (foundry.js:10068)
    at async Function.updateDocuments (common/abstract/document.mjs:373)
    at async DragRulerRuler.animateEntities (modules/drag-ruler/src/foundry_imports.js:89)
    at async DragRulerRuler.moveEntities (modules/drag-ruler/src/foundry_imports.js:40)

I created a ticket with them too: https://github.com/kckaiwei/TurnMarker-alt/issues/86

This is no conflict, but rather a symptom of turn marker not being ported to v9 yet (note that this issue still occurs with Drag Ruler disabled).


[SPARK-11393][SQL] CoGroupedIterator should respect the fact that GroupedIterator.hasNext is not idempotent

When we cogroup 2 GroupedIterators in CoGroupedIterator, if the right side is smaller, we will consume right data and keep the left data unchanged. Then we call hasNext which will call left.hasNext. This will make GroupedIterator generate an extra group as the previous one has not been comsumed yet.

Merged build triggered.

Merged build started.

cc @marmbrus

Test build #44559 has started for PR 9346 at commit 9be67c8.

Test build #44559 has finished for PR 9346 at commit 9be67c8.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44559/
Test PASSed.

I'm a little confused.  If GroupedIterator.hasNext isn't idempotent then we should fix that instead of working around it.  However, as of master I wasn't able to reproduce a problem with it (but maybe my test case is insufficient?
    val schema = new StructType().add("i", IntegerType).add("s", StringType)
    val encoder = RowEncoder(schema)
    val input = Seq(Row(1, "a"), Row(1, "b"), Row(2, "c"))
    val grouped = GroupedIterator(input.iterator.map(encoder.toRow),
      Seq('i.int.at(0)), schema.toAttributes)

    val result = grouped.map {
      case (key, data) =>
        assert(key.numFields == 1)
        key.getInt(0) -> data.map(encoder.fromRow).toSeq
    }

    assert(result.hasNext)
    assert(result.hasNext)
    assert(result.hasNext)

    assert(result.next === 1 -> Seq(input(0), input(1)))

    assert(result.hasNext)
    assert(result.hasNext)
    assert(result.hasNext)

    assert(result.next === 2 -> Seq(input(2)))

    assert(!result.hasNext)
    assert(!result.hasNext)

Maybe "not idempotent" is not a proper word to describe this problem, GroupedIterator has a special constraint which is diffrent from normal iterator, and CoGroupedIterator breaks this constraint at the condition described in PR description.

btw as https://github.com/apache/spark/pull/9330 has been merge, the problem is not generating an extra empty group but making the last group empty.

If we use grouped directly and call hasNext right after we call next, the issue will be exposed.

Okay, thanks.  Merging to master.


NTR: positive regulation of ferroptosis

Please provide as much information as you can:

Suggested term label:

positive regulation of ferroptosis

Definition (free text)

Any process that activates or increases the frequency, rate or extent of ferroptosis

Reference, in format PMID:#######

PMID: 32015325

Gene product name and ID to be annotated to this term

I'm not a biologist (so no expert!) but the attached review does reference more gene products associated with the mechanism (currently there are just 2 gene products associated for negative regulation), erastin (small molecule) is known the induce ferroptosis and is likely to be interacting with one or more voltage dependent ion channels (VDAC(s)) so could possibly be VDAC1/VDAC2/VDAC3

Parent term(s)

GO:0110075

Children terms (if applicable) Should any existing terms that should be moved underneath this new proposed term?

N/A

Synonyms (please specify, EXACT, BROAD, NARROW or RELATED)

Cross-references

For enzymes, please provide RHEA and/or EC numbers.

Can also provide MetaCyc, KEGG, Wikipedia, and other links.

https://en.wikipedia.org/wiki/Ferroptosis

Any other information

I'm asking for the term as if you have negative regulation of a process then surely there must be +ve regulation as well.
Note: have emailed HUGO to ask if AIFM2 will be re-named FSP1 as the nature article suggests

@pgaudet Should we add this term when there is no immediate use case of annotation?

Looking at the paper @ceararea mentioned I thought the voltage dependent ion channels could be annotated, or is this too indirect?


Implement RemoveRow method

Row removal functinoality is present in stargate but not exposed in the client library.

Implemented as DeleteCellsAsync.


De-singletonize the store

Create the store once in the main index.js and then inject it where
needed.  This accomplishes three main goals:

Gets rid of a singleton
Makes our code look more like the official Redux examples
Supports server-side rendering should any project based on the
boilerplate need that.  With server rendering, you create a new store
on the server for every request, so you need to be able to inject that
into the component tree.  A singleton just wouldn’t cut it there.

LGTM


Pandoc command not found

I get the error that the pandoc command is not found even though I set /opt/homebrew/bin/pandoc as the path in the settings.

This is strange. Please run /opt/homebrew/bin/pandoc -v, and show me the output.
https://github.com/mokeyish/obsidian-enhancing-export/blob/39bf85c2ad3df36c2b37fd87e53f48333c38ca3f/src/exporto0o.ts#L148-L153

@mokeyish /opt/homebrew/bin/pandoc -v ouputs the following:
pandoc 2.19.2
Compiled with pandoc-types <IP_ADDRESS>, texmath <IP_ADDRESS>, skylighting 0.13,
citeproc <IP_ADDRESS>, ipynb 0.2, hslua 2.2.1
Scripting engine: Lua 5.4
User data directory: /Users/tim/.pandoc
Copyright (C) 2006-2022 John MacFarlane. Web:  https://pandoc.org
This is free software; see the source for copying conditions. There is no
warranty, not even for merchantability or fitness for a particular purpose.

Running just pandoc -v has the same result btw

@tim-hilde Please try ln -s /opt/homebrew/bin/pandoc /usr/local/bin

The latest version already supports to detect the pandoc version.


Add Some Sound Effects

We need some punches and Level up sounds and hurt sounds!

Sounding good via commit d3fd00515e0db494a061d10df6e8fd3431564b67


Follow button is disabled on profile pages

Phanpy dev

Visit any profile page of user that you are not following

Follow button will be in disabled state

<button type="button" data-swap-state="" disabled="">Follow</button>

Can’t replicate this on my own install, using latest commit.

@Fastidious
Attaching video
https://github.com/cheeaun/phanpy/assets/1143226/58fac5eb-196e-49bd-b387-d75b4ec8fd62

What OS/browser are you using? I can't repro on macOS' Safari either.

@Fastidious you are attaching screenshot of user's card, not his profile page

@Fastidious you are attaching screenshot of user's card, not his profile page

Aha! I stand corrected, indeed. I can replicate now.

Thanks for fix!


Consider to use only Message instead of TransportMessage and ClusterMessage

Current solution
I have changed API for cluster at https://github.com/servicefabric/servicefabric/pull/37 to make it work with members and as a result was introduced ClusterMessage class to return from listen method which have message and member fields instead of message and endpoint fields on TransportMessage. Also added API to resolve member by ID.
Problems

We introduced many message classes Message, TransportMessage, ClusterMessage which is kind of confusing.
Membership information disseminate over the cluster in eventually consistent way so it may lead to errors when not possible to transform TransportMessage to ClusterMessage since member not available yet on this node.
Creating of ClusterMessage and TransportMessage objects on each message will produce more garbage pressure since even so this classes are small the messages are often.

Proposed solution
We need to know for incoming messages from where it was sent in order to do some specific on sender logic or reply. This is the reason why we have this other messages since this information is not available on Message class.
So I was thinking it can be done in a different way. For example, when we are sending message to each message add additional system header with key “origin” and value which corresponds to endpoint/member ID. Also alternatively it can be not a header, but just additional field since any message have someone who sends it (?).
So in such case we can use everywhere Message class. For convenience on Message class we can provide some additional methods like origin() or something like this.
@myroslavlisniak @artem-v @ronenhamias WDYT?

Solved at PR: https://github.com/servicefabric/servicefabric/pull/43


Invariant Violation: requireNativeComponent: "NSTStreetView" was not found in the UIManager.

"react": "16.13.1",
"react-native": "0.63.4",
"react-native-streetview": "~0.2.1"
emulator: Android Studio
I try to use the react-native-street view component in an android emulator and I get the following error, anyone who knows any solution for this error?

after installing react-native-streetview :

npx react-native link react-native-streetview
cd ios
pod install
run

"react": "16.13.1", "react-native": "0.63.4", "react-native-streetview": "~0.2.1" emulator: Android Studio
I try to use the react-native-street view component in an android emulator and I get the following error, anyone who knows any solution for this error?

Hi did you get anything?

v0.2.4 is now released. please remove current version and install with:
yarn install<EMAIL_ADDRESS>cd ios
pod install
cd ..
npx react-native run-ios