Add support for Xiaomi Mi light intensity sensor (lumi.sen_ill.mgl01)

Just adding a case with the model name. Works largely like the combined motion + light sensors, except that there is no motion reported.

Let me know if more than this is needed for adding support.


Optimize tiled feature layer

Notably relevent for large polygon geometries, e.g. countries, if a polygon matches a lot of visible tiles when navigating it will be duplicated for each tile leading to a larger transfered data volume than required and a performance bottleneck.
Possible solutions:

send IDs of alreay loaded features to avoid duplicating
debounce requests to only send it when move stops

Using PMTiles to render such features could solve the issue


PyPI package update

The current version of PySd package in the PyPI repo is 0.10.0 we will need to update the package there to make it easier for users to install PySD.
I am also working in a repo with dependencies on PySD, for which I will need a new version of PySD on PyPI (I'm working on a new pull request with some new features) in order to be able to make the CI work.

Hi @JamesPHoughton, could you update the PySD version on PyPI?
We can also add a badget to the README generated with badge.fury.io

oooh, I like that badge... =) Do please add it to the readme.
I've just sent you an email about setting up an action to update PyPI when we create a new release, and made API tokens that should give you access to do it. That way I won't be the bottleneck on that side!

While you're at it, let's also remove the landscape.io badge. Do you think it would be worth adding a different code-quality checking service, or any other commit-time checks?

Right now I don't know which more badges could be interesting to add. I will add also a budget for docs:

sure, that sounds like a good idea.

I already created release 1.2.0 and the package was successfully uploaded to PyPI


tesla_powerwall not defined?

I get errors when udiTeslaPW2 starting (it never connects). Looks like an error in TeslaInfoV2.py @ line 13:
from tesla_powerwall import GridStatus, OperationMode, MeterType
I don't see tesla_powerwall defined anywhere
Ref:
https://github.com/Panda88CO/udi-TeslaPW2/blob/5a2b426c4eb0d285b874b18c0f75efe90c84a3cb/TeslaInfoV2.py#L13
Log:
2024-12-30 13:35:32.060 MainThread udi_interface      ERROR    udi_interface:write: Traceback (most recent call last):
2024-12-30 13:35:32.060 MainThread udi_interface      ERROR    udi_interface:write: File "/var/polyglot/pg3/ns/0021b9026ce5_16/TeslaPW2main.py", line 6, in
2024-12-30 13:35:32.060 MainThread udi_interface      ERROR    udi_interface:write: from TeslaInfoV2 import tesla_info
2024-12-30 13:35:32.060 MainThread udi_interface      ERROR    udi_interface:write: File "/var/polyglot/pg3/ns/0021b9026ce5_16/TeslaInfoV2.py", line 13, in
2024-12-30 13:35:32.060 MainThread udi_interface      ERROR    udi_interface:write: from tesla_powerwall import GridStatus, OperationMode, MeterType
2024-12-30 13:35:32.061 MainThread udi_interface      ERROR    udi_interface:write: ModuleNotFoundError
2024-12-30 13:35:32.061 MainThread udi_interface      ERROR    udi_interface:write: :
2024-12-30 13:35:32.061 MainThread udi_interface      ERROR    udi_interface:write: No module named 'tesla_powerwall'

Looks like the library is requirements are notimportedChristian OlgaardSent and "auto corrected" by my iPhoneOn Dec 30, 2024, at 20:41, danman222 @.***> wrote:
I get errors when udiTeslaPW2 starting (it never connects). Looks like an error in TeslaInfoV2.py @ line 13:
from tesla_powerwall import GridStatus, OperationMode, MeterType
I don't see tesla_powerwall defined anywhere
Ref:
https://github.com/Panda88CO/udi-TeslaPW2/blob/5a2b426c4eb0d285b874b18c0f75efe90c84a3cb/TeslaInfoV2.py#L13
Log:
2024-12-30 13:35:32.060 MainThread udi_interface      ERROR    udi_interface:write: Traceback (most recent call last):
2024-12-30 13:35:32.060 MainThread udi_interface      ERROR    udi_interface:write: File "/var/polyglot/pg3/ns/0021b9026ce5_16/TeslaPW2main.py", line 6, in
2024-12-30 13:35:32.060 MainThread udi_interface      ERROR    udi_interface:write: from TeslaInfoV2 import tesla_info
2024-12-30 13:35:32.060 MainThread udi_interface      ERROR    udi_interface:write: File "/var/polyglot/pg3/ns/0021b9026ce5_16/TeslaInfoV2.py", line 13, in
2024-12-30 13:35:32.060 MainThread udi_interface      ERROR    udi_interface:write: from tesla_powerwall import GridStatus, OperationMode, MeterType
2024-12-30 13:35:32.061 MainThread udi_interface      ERROR    udi_interface:write: ModuleNotFoundError
2024-12-30 13:35:32.061 MainThread udi_interface      ERROR    udi_interface:write: :
2024-12-30 13:35:32.061 MainThread udi_interface      ERROR    udi_interface:write: No module named 'tesla_powerwall'
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you are subscribed to this thread.Message ID: @.***>

Can you send log all log fileChristian OlgaardSent and "auto corrected" by my iPhoneOn Dec 30, 2024, at 20:41, danman222 @.***> wrote:
I get errors when udiTeslaPW2 starting (it never connects). Looks like an error in TeslaInfoV2.py @ line 13:
from tesla_powerwall import GridStatus, OperationMode, MeterType
I don't see tesla_powerwall defined anywhere
Ref:
https://github.com/Panda88CO/udi-TeslaPW2/blob/5a2b426c4eb0d285b874b18c0f75efe90c84a3cb/TeslaInfoV2.py#L13
Log:
2024-12-30 13:35:32.060 MainThread udi_interface      ERROR    udi_interface:write: Traceback (most recent call last):
2024-12-30 13:35:32.060 MainThread udi_interface      ERROR    udi_interface:write: File "/var/polyglot/pg3/ns/0021b9026ce5_16/TeslaPW2main.py", line 6, in
2024-12-30 13:35:32.060 MainThread udi_interface      ERROR    udi_interface:write: from TeslaInfoV2 import tesla_info
2024-12-30 13:35:32.060 MainThread udi_interface      ERROR    udi_interface:write: File "/var/polyglot/pg3/ns/0021b9026ce5_16/TeslaInfoV2.py", line 13, in
2024-12-30 13:35:32.060 MainThread udi_interface      ERROR    udi_interface:write: from tesla_powerwall import GridStatus, OperationMode, MeterType
2024-12-30 13:35:32.061 MainThread udi_interface      ERROR    udi_interface:write: ModuleNotFoundError
2024-12-30 13:35:32.061 MainThread udi_interface      ERROR    udi_interface:write: :
2024-12-30 13:35:32.061 MainThread udi_interface      ERROR    udi_interface:write: No module named 'tesla_powerwall'
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you are subscribed to this thread.Message ID: @.***>

CorrectThe library seems not  to have been installed.  Look in requirements.txt.  You need to pip install thoseChristian OlgaardSent and "auto corrected" by my iPhoneOn Dec 30, 2024, at 20:41, danman222 @.***> wrote:
I get errors when udiTeslaPW2 starting (it never connects). Looks like an error in TeslaInfoV2.py @ line 13:
from tesla_powerwall import GridStatus, OperationMode, MeterType
I don't see tesla_powerwall defined anywhere
Ref:
https://github.com/Panda88CO/udi-TeslaPW2/blob/5a2b426c4eb0d285b874b18c0f75efe90c84a3cb/TeslaInfoV2.py#L13
Log:
2024-12-30 13:35:32.060 MainThread udi_interface      ERROR    udi_interface:write: Traceback (most recent call last):
2024-12-30 13:35:32.060 MainThread udi_interface      ERROR    udi_interface:write: File "/var/polyglot/pg3/ns/0021b9026ce5_16/TeslaPW2main.py", line 6, in
2024-12-30 13:35:32.060 MainThread udi_interface      ERROR    udi_interface:write: from TeslaInfoV2 import tesla_info
2024-12-30 13:35:32.060 MainThread udi_interface      ERROR    udi_interface:write: File "/var/polyglot/pg3/ns/0021b9026ce5_16/TeslaInfoV2.py", line 13, in
2024-12-30 13:35:32.060 MainThread udi_interface      ERROR    udi_interface:write: from tesla_powerwall import GridStatus, OperationMode, MeterType
2024-12-30 13:35:32.061 MainThread udi_interface      ERROR    udi_interface:write: ModuleNotFoundError
2024-12-30 13:35:32.061 MainThread udi_interface      ERROR    udi_interface:write: :
2024-12-30 13:35:32.061 MainThread udi_interface      ERROR    udi_interface:write: No module named 'tesla_powerwall'
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you are subscribed to this thread.Message ID: @.***>

Log file attached. Do I need to install something else?
udiTeslaPW2_12-30-2024_31526_PM.zip

I  need the full log - it includes the install log where i may be able to see why the local library was not installed

From: danman222 @.>
Sent: Monday, December 30, 2024 9:39 PM
To: Panda88CO/udi-TeslaPW2 @.>
Cc: Panda88CO @.>; Comment @.>
Subject: Re: [Panda88CO/udi-TeslaPW2] tesla_powerwall not defined? (Issue #11)
Log file attached. Do I need to install something else?
udiTeslaPW2_12-30-2024_31526_PM.ziphttps://github.com/user-attachments/files/18277620/udiTeslaPW2_12-30-2024_31526_PM.zip
—
Reply to this email directly, view it on GitHubhttps://github.com/Panda88CO/udi-TeslaPW2/issues/11#issuecomment-2565896169, or unsubscribehttps://github.com/notifications/unsubscribe-auth/APQ7ECQLHAQO67Y2FADBH2L2IGVO7AVCNFSM6AAAAABUMPUXR2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKNRVHA4TMMJWHE.
You are receiving this because you commented.Message ID: @.***>

Attached
pg3_12-30-2024_35228_PM.zip
system_12-30-2024_35250_PM.zip

I am not a python coder but I notice this from requirements.txt:
tesla-powerwall==0.3.19
Should that be tesla_powerwall==0.3.19  ??? (underscore vs. dash)
Also, current version of tesla_powerwall appears to be 0.5.2. Newer versions not tested?
Thanks,
Dan

Newer versions moved to async library and it will take a lot of effort to change all codeYou can see what happens if you download the full log and in the zip there is an install.logIt has been working for a while so i doubt there is a typoChristian OlgaardSent and "auto corrected" by my iPhoneOn Dec 31, 2024, at 02:35, danman222 @.***> wrote:
I am not a python coder but I notice this from requirements.txt:
tesla-powerwall==0.3.19
Should that be tesla_powerwall==0.3.19  ??? (underscore vs. dash)
Also, current version of tesla_powerwall appears to be 0.5.2. Newer versions not tested?
Thanks,
Dan
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you commented.Message ID: @.***>

Btw i am travelling so i have no access to my setupChristian OlgaardSent and "auto corrected" by my iPhoneOn Dec 31, 2024, at 02:35, danman222 @.***> wrote:
I am not a python coder but I notice this from requirements.txt:
tesla-powerwall==0.3.19
Should that be tesla_powerwall==0.3.19  ??? (underscore vs. dash)
Also, current version of tesla_powerwall appears to be 0.5.2. Newer versions not tested?
Thanks,
Dan
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you commented.Message ID: @.***>

I need you to go to log and Download Log Package
Sorry for not being clear

From: danman222 @.>
Sent: Monday, December 30, 2024 10:00 PM
To: Panda88CO/udi-TeslaPW2 @.>
Cc: Panda88CO @.>; Comment @.>
Subject: Re: [Panda88CO/udi-TeslaPW2] tesla_powerwall not defined? (Issue #11)
Attached
pg3_12-30-2024_35228_PM.ziphttps://github.com/user-attachments/files/18277717/pg3_12-30-2024_35228_PM.zip
system_12-30-2024_35250_PM.ziphttps://github.com/user-attachments/files/18277718/system_12-30-2024_35250_PM.zip
—
Reply to this email directly, view it on GitHubhttps://github.com/Panda88CO/udi-TeslaPW2/issues/11#issuecomment-2565910132, or unsubscribehttps://github.com/notifications/unsubscribe-auth/APQ7ECSLZBMWNB3XKETZMET2IGX5LAVCNFSM6AAAAABUMPUXR2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKNRVHEYTAMJTGI.
You are receiving this because you commented.Message ID: @.***>

I found it. Problem is this:
ERROR: No matching distribution found for udi_interface>=3.3.15
udiTeslaPW2_12-31-2024_101428_AM.zip

Looks like it stopped installing everything after that in "requirements.txt"

It.should be released.  I think you need to open ticket at udi for this one
On Tue, Dec 31, 2024 at 16:17 danman222 @.***> wrote:

I found it. Problem is this:
ERROR: No matching distribution found for udi_interface>=3.3.15
udiTeslaPW2_12-31-2024_101428_AM.zip
https://github.com/user-attachments/files/18282335/udiTeslaPW2_12-31-2024_101428_AM.zip
—
Reply to this email directly, view it on GitHub
https://github.com/Panda88CO/udi-TeslaPW2/issues/11#issuecomment-2566527897,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/APQ7ECT6ERMNVA262FQYRDD2IKYPFAVCNFSM6AAAAABUMPUXR2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKNRWGUZDOOBZG4
.
You are receiving this because you commented.Message ID:
@.***>

You need to find it under log
On Tue, Dec 31, 2024 at 16:13 danman222 @.***> wrote:

This isn't an urgent issue - so happy new year, enjoy your holiday and
safe travels.
I'm new to this Polyglot V3 interface so I'm learning the UI. I am
attaching an image of the log options available. I don't see a "Download
Log Package" option. There is no install.log file in any of zip files
created using the 2 options I see.
Log.Options.-.Polyglot.V3.jpg (view on web)
https://github.com/user-attachments/assets/1f78fdeb-8399-4ccf-a2c8-7981f46d4461
—
Reply to this email directly, view it on GitHub
https://github.com/Panda88CO/udi-TeslaPW2/issues/11#issuecomment-2566525871,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/APQ7ECQ7PL2N6CQLD2JZ7732IKYDJAVCNFSM6AAAAABUMPUXR2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKNRWGUZDKOBXGE
.
You are receiving this because you commented.Message ID:
@.***>

I didn't see anywhere in the PG3 UI to submit a support ticket but I submitted one from the UDI web

Quick response from UDI:
Benoit Mercier wrote:
Hi Daniel,
There is no udi_interface 3.3.15. The last release is 3.3.14.
I told Christian he should update the plugin accordingly.

That is the way to do itChristian OlgaardSent and "auto corrected" by my iPhoneOn Dec 31, 2024, at 18:22, danman222 @.***> wrote:
I didn't see anywhere in the PG3 UI to submit a support ticket but I submitted one from the UDI web
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you commented.Message ID: @.***>

Ok. I'll try to fix itChristian OlgaardSent and "auto corrected" by my iPhoneOn Dec 31, 2024, at 18:41, danman222 @.***> wrote:
Quick response from UDI:
Benoit Mercier wrote:
Hi Daniel,
There is no udi_interface 3.3.15. The last release is 3.3.14.
I told Christian he should update the plugin accordingly.
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you commented.Message ID: @.***>

After the holiday. Happy New Year!

Did it already but it will take some time to depoly - you can also edit the requirement.txt to 3.3.14 and try to run install.sh

From: danman222 @.>
Sent: Tuesday, December 31, 2024 6:48 PM
To: Panda88CO/udi-TeslaPW2 @.>
Cc: Panda88CO @.>; Comment @.>
Subject: Re: [Panda88CO/udi-TeslaPW2] tesla_powerwall not defined? (Issue #11)
After the holiday. Happy New Year!
—
Reply to this email directly, view it on GitHubhttps://github.com/Panda88CO/udi-TeslaPW2/issues/11#issuecomment-2566623274, or unsubscribehttps://github.com/notifications/unsubscribe-auth/APQ7ECRCEY6N27LS2DZOOU32ILKGDAVCNFSM6AAAAABUMPUXR2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKNRWGYZDGMRXGQ.
You are receiving this because you commented.Message ID: @.***>

I would but I'm a noob with all of this. I don't no how to console into the eisy.

Ok - then delete and reinstall in the new slot - there are still some issues with upgrades in the node store - I assume you never to got it working
Happy New Year
Christian

From: danman222 @.>
Sent: Tuesday, December 31, 2024 6:56 PM
To: Panda88CO/udi-TeslaPW2 @.>
Cc: Panda88CO @.>; Comment @.>
Subject: Re: [Panda88CO/udi-TeslaPW2] tesla_powerwall not defined? (Issue #11)
I would but I'm a noob with all of this. I don't no how to console into the eisy.
—
Reply to this email directly, view it on GitHubhttps://github.com/Panda88CO/udi-TeslaPW2/issues/11#issuecomment-2566627289, or unsubscribehttps://github.com/notifications/unsubscribe-auth/APQ7ECRBKUBO3JGP5LVVN2T2ILLDVAVCNFSM6AAAAABUMPUXR2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKNRWGYZDOMRYHE.
You are receiving this because you commented.Message ID: @.***>

I just did a re-install in the same slot and ... looks like it's working now!
thanks,
Dan

😁Christian OlgaardSent and "auto corrected" by my iPhoneOn Dec 31, 2024, at 19:09, danman222 @.***> wrote:
I just did a re-install in the same slot and ... looks like it's working now!
thanks,
Dan
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you commented.Message ID: @.***>


Netflix clone

We are only looking at solving the issues listed out. We do not need templates at the moment. And that was about 37 file changes. Try solving an issue and I would accept your PR immediately. thank you.


Termius-beta: init at 9.9.0

Package Information

Package name: Termius-beta
Latest released version: 9.9.0
Current version on the unstable channel: none
Current version on the stable/release channel: none

Notification for Termius Maintainer:
@Br1ght0ne @th0rgal
Hi, I have utilized code from Termius and modified it for Termius-beta to work, and as far as testing goes Termius-beta works completely fine.
Since the code is very similar, i have kept both of you as Maintainers for Termius-beta as well.
If you don't want to be maintainer for this code, its completely fine just do notify me 🤗

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[x] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Sorry about the error,
Probably due to me not adding myself to Maintainer list,
Which i did just now! 🫠

Hi @drupol, I am sorry to ask of you this but i just closed this PR and created a new one:
https://github.com/NixOS/nixpkgs/pull/368256
Although did follow your tips tho..


Implementing Semantic Segmentation Head?

Firstly, thanks for the implementation of the MobileNetV3!
Do you have an interest in implementing the semantic segmentation head described in section 6.4? I am currently planning to implement that, so if you have an interest, we can work together to do it!

Hello @fzyzcjy!
Thank you for your interest in our implementation. Currently, we are not planning to implement segmentation head.
Cheers,
Martin

OK fine!


[Feature Requests] New Expand and Transform commands

Hi @timhor! Thanks so much for creating this plugin, I find myself using it all the time!
Wondering if you would be open to adding a few commands to complement the existing set:

Add a new "Expand selection to..." command that expands the selection to any markdown symbols so it could be using to quickly select the text between bold, italics, strikethrough, etc..
Building off a 1, it would be great if this could be enhanced to also select the markup symbols if you hit the command again. This way you could quickly replace or delete any marked up text by hitting at most two hotkeys.
A final suggestion, similar to your "Transform selection..." commands, would be to add commands for Transform the selection/word to styled text without even having to select it first e.g. bold, italic, strikethrough, highlight, etc.

Ideally, executing the command again toggles the styling e.g. toggles bold.

Thanks again for sharing this plugin!

Glad you like the plugin! I'll keep these in mind, but it may take some time before I can get around to working on them.

On point 3, @chrisgrieser has just released Smarter Markdown Hotkeys which allows you to toggle formatting without needing to select an entire word.

That’s awesome, thx for sharing!


Games made with LWJGL3: Performance tanks when being recorded

Version
3.2.1
Platform
Windows x64
JDK
Zulu OpenJDK 17.0.4
Module
LWJGL core, GLFW, OpenAL, OpenGL, STB, JOML
Bug description
When recording footage of our games at resolutions higher than 1080p, performance drops dramatically. For example, our primary project, Robot Farm, goes from 230 FPS to 120 FPS on a basic scene where there's not much going on. In scenes where it would normally be 100 FPS, it can dip to 60 FPS or lower. It appears to only happen on performance intensive software that use OpenGL extensively.
This has also been tested on our older games; We Shall Wake from 2015 on LWJGL2 dropped dramatically when being recorded. As well as "Battledroid" by Puppygames, dipping far below its target of 60 FPS when being recorded at resolutions higher than 1080p. I'm not quite certain this is an LWJGL bug or something else, since as far as I know, LWJGL2 does not share any code with LWJGL3.
Regardless, I felt that it would be appropriate to report, since this could limit the visibility of games made with LWJGL in the future due to the fact that the primary way games are shared/spread in this time are via YouTube/Twitch streaming. If this issue extends past LWJGL into something else, preventative measures could be potentially taken to remedy this.
Builds of all of our games can be supplied for testing. Our build of We Shall Wake running on LWJGL2 can be found publicly here:
https://www.nokoriware.com/weshallwake
Recording programs tested:

Fraps
Bandicam

Stacktrace or crash log output
No response

Hey @SkyAphid,
This is completely normal. There's nothing wrong with LWJGL or the recording software. Even if you ignore the bandwidth required and the encoding/storage overhead, reading back the framebuffer is a major synchronization point and will always affect rendering performance. Btw, I wouldn't say the FPS drops you're seeing are "dramatic", they're about 4-6ms per frame, in line with what I would expect when rendering at 1440p or 4K.
There have been many attempts to mitigate the impact (buffering, asynchronous readbacks, etc.) but there's no good software solution to this problem. I guess the best you could do with software is something like Nvidia ShadowPlay, which encodes the framebuffer on the GPU and reduces the amount of data that needs to be read back. Maybe one could even implement a similar solution using Vulkan's H.264/H.265 encoding extensions. However, there's some performance hit even with ShadowPlay.
Fortunately there's an easy (but costly, depending on the output quality/fps required) solution that makes this problem go away and every competitive streamer uses it: a second PC with an HDMI capture card. The GPU of the primary/rendering machine is connected to the capture card via HDMI and the OS is configured to mirror whatever is displayed on the primary monitor. Then the second machine takes care of encoding & streaming. It is the only zero-overhead solution.

Drops dramatically more than what would normally be expected? What are the frame times you see before & during capturing, and have you done any profiling?

@Spasi
Fair enough, I'll keep this in mind and give Shadowplay a try. My worry was primarily that it seems to hit games made with Java the hardest, since I'm also getting major stuttering as well. This doesn't seem to occur with games made the "traditional way," but if there's nothing that can be done, I'll do my best to mitigate it.
Regardless, I wanted to report it in case this was something that needed to be diagnosed. My apologies for taking up your time.
Thanks for the quick response fellas!

No one (should) ever use software-only solutions like Fraps or Bandicam anymore when recording their gameplay footage... I made all my videos with OBS (with NVENC) and later switched to GeForce Experience to record all my videos at frametimes of less than a millisecond (> 1000 FPS) on 1440p. The overhead of NVENC-based solutions like GeForce Experience (previously ShadowPlay) or the encoder in OBS is so absolutely minuscule.
But, like @Spasi said, if you want to have zero overhead, you need a separate PC with a capture card.
So, if you have an Nvidia card with a hardware video encoder engine, then by all means, use that with either OBS or GeForce Experience.
Also: If you choose OBS make sure to start it as the PC's Administrator account, as Windows 10+ display driver scheduler will then give it way more GPU compute time when it needs it, as otherwise (when run under a non-privileged Windows user) you can still get hitches in the encoded video (but not in the live gameplay) that you will then see in the recorded video later.


OlDisplayMode Enum formatting

This content is not formatted correctly.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 43d441be-e7f7-d213-a396-6ae5c281e406
Version Independent ID: c9046e3e-1f64-01e0-1fdc-ac96e14c9493
Content: OlDisplayMode Enumeration (Outlook)
Content Source: api/Outlook.oldisplaymode.md
Product: outlook
GitHub Login: @o365devx
Microsoft Alias: o365devx

@jozefizso Thanks for catching this! I fixed it, and changes will go live later today.


fix typo in documentation

Thanks!

Btw do you know codespell?
Doing just pip install codespell and then codespell without configuration
finds a number of typos in any sizeable project, usually with not too many false positives.


Azure - Wix Connection

Hi! Thank you in advance for your valuable help. I'm receiving the following error after doing all the steps to connect Wix to Azure. o anyone understand what would be happening or how to fix it?
Thank you

Hi @nvmundial in you're mysql instance, connection security, try to mark disable in SSL enforcment

Thank you so much! It worked yesterday. However now I'm having a new, different error.

Can you send here the app logs?

Thank you so so much!! Please let me know if you need something else.

Not sure if the "Extracting" log is normal. But it appears a lot.
Thank you for your help, you are my hero.

Please try to redeploy with this docker image name :
veloex/velo-external-db:latest

I am having the same issue (cannot be mapped to a host ID). How was this resolved?

Hi! I redeployed with veloex/velo-external-db:mysql and worked. Let me know
if it works for you.
On Thu, Feb 16, 2023 at 8:22 AM jndjndjnd @.***> wrote:

I am having the same issue (cannot be mapped to a host ID). How was this
resolved?
—
Reply to this email directly, view it on GitHub
https://github.com/wix/velo-external-db/issues/412#issuecomment-1433081243,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/A5XRCNE73QP4FRXHOY7VFUDWXYSYBANCNFSM6AAAAAAUUKQX4E
.
You are receiving this because you were mentioned.Message ID:
@.***>

Thank you! I got the Wix page, but Authorization Config Status is yellow, and Connection Status is red.

About the yellow authorization it's fine, it means it just using the default.
About the connection status is red-check that the host name in the environment variable is correct.

The host name in the secret is correct, but I still get the same error.

Check if it's a MySQL server.
On Thu, Feb 16, 2023 at 1:32 PM jndjndjnd @.***> wrote:

The host name in the secret is correct, but I still get the same error.
—
Reply to this email directly, view it on GitHub
https://github.com/wix/velo-external-db/issues/412#issuecomment-1433534814,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/A5XRCNBFJQRCFAO67G5NJB3WXZXFPANCNFSM6AAAAAAUUKQX4E
.
You are receiving this because you were mentioned.Message ID:
@.***>

So I figured out why the deployment error, though haven't gotten a response from wix yet.
Because the most recent ("latest") update on docker was 21 days ago, and essentially broke things if following stricly from the tutorial listed here:
https://support.wix.com/en/article/velo-integrate-your-azure-database-with-your-wix-site
The package has a unique ID called a UID. The part that it's not liking is that linux can only read UIDs so high by default, and the most recent update is above linux's maximum allowed.
Someone on wix's end needs to change the package with UID 718322462 (mine shows the same error when on "latest") to one that Linux will support. Fixing this in the update will fix the bug (though github's seems to be the old one).
Until then, anyone affected can use the veloex/velo-external-db:mysql one instead, but in my case as well, this seems to not work with the permissions JSON (I have modified many different ways, it really doesn't seem to like any iteration)
My hope is that someone will see this, take the few minutes to tweak the UID and go back to the latest build. In the wait, would be nice if anyone had any ideas on how to fix the permissions component on the mysql deployment

So I figured out why the deployment error, though haven't gotten a response from wix yet. Because the most recent ("latest") update on docker was 21 days ago, and essentially broke things if following stricly from the tutorial listed here:
https://support.wix.com/en/article/velo-integrate-your-azure-database-with-your-wix-site
The package has a unique ID called a UID. The part that it's not liking is that linux can only read UIDs so high by default, and the most recent update is above linux's maximum allowed.
Someone on wix's end needs to change the package with UID 718322462 (mine shows the same error when on "latest") to one that Linux will support. Fixing this in the update will fix the bug (though github's seems to be the old one).
Until then, anyone affected can use the veloex/velo-external-db:mysql one instead, but in my case as well, this seems to not work with the permissions JSON (I have modified many different ways, it really doesn't seem to like any iteration)
My hope is that someone will see this, take the few minutes to tweak the UID and go back to the latest build. In the wait, would be nice if anyone had any ideas on how to fix the permissions component on the mysql deployment

Hi, about this, you're right, we fixed it, and you can now use the latest tag again.

So I figured out why the deployment error, though haven't gotten a response from wix yet. Because the most recent ("latest") update on docker was 21 days ago, and essentially broke things if following stricly from the tutorial listed here:
https://support.wix.com/en/article/velo-integrate-your-azure-database-with-your-wix-site
The package has a unique ID called a UID. The part that it's not liking is that linux can only read UIDs so high by default, and the most recent update is above linux's maximum allowed.
Someone on wix's end needs to change the package with UID 718322462 (mine shows the same error when on "latest") to one that Linux will support. Fixing this in the update will fix the bug (though github's seems to be the old one).

Hi, about this, you're right, we fixed it, and you can now use the latest tag again.

Until then, anyone affected can use the veloex/velo-external-db:mysql one instead, but in my case as well, this seems to not work with the permissions JSON (I have modified many different ways, it really doesn't seem to like any iteration)
My hope is that someone will see this, take the few minutes to tweak the UID and go back to the latest build. In the wait, would be nice if anyone had any ideas on how to fix the permissions component on the mysql deployment

About the permissions, can you elaborate?

So I think I just discovered something in the mysql distro that doesn't behave like the full latest. See attached, nothing I did would yield any other message than the one shown. As soon as I switched to the fixed latest, everything automagically worked again with the same settings. It does seem like something with the mysql distro handles this differently and won't register any permissions entered.
The fix resolved my issue and permissions now works fine on the latest build, but wouldn't hurt to have the other if there ever was a reason to downgrade again.

Hi, the current mysql image is deprecated, stick to the latest meanwhile.

It's great that it looks like it works now. But it really worries me that they took 3 weeks to fix it. If something like that happens again my business is over. Idokah, Can we have a working backup somehow?

Yeah, kinda echoing what nvmundial said. This came up while pitching the purchase of a wix website. It was really a nail-biter moment. It was nice to have the mysql backup to keep working and show a previews, but not a great assurance in my data not being visible to site visitors.
It was very helpful to have anything proven functional with my site to rely on, that perhaps it might be wise to have the last functional release available when pushing to a new one. It would have solved the issue many days earlier, and many might not be as sleuth at digging through the logs as I was. Switching to an old release is such an easy fix in pinch moments (could also be added as an easy addition in the guide, as it's own main go to when trying to fix issues)

I pushed to the tag :mysql the same image for backup.
Sorry for the late fix.

But :mysql don't support Permissions, correct? Can we have 2?
On Sun, Mar 5, 2023 at 4:33 AM Ido Kahlon @.***> wrote:

I pushed to the tag :mysql the same image for backup.
Sorry for the late fix.
—
Reply to this email directly, view it on GitHub
https://github.com/wix/velo-external-db/issues/412#issuecomment-1455037922,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/A5XRCNBGDD5N4FZFQ36FO23W2RMVPANCNFSM6AAAAAAUUKQX4E
.
You are receiving this because you were mentioned.Message ID:
@.***>

Good to know! Thank you.
On Thu, Mar 9, 2023 at 11:30 AM Ido Kahlon @.***> wrote:

:mysql supports anything :latest support because they're the same now.
—
Reply to this email directly, view it on GitHub
https://github.com/wix/velo-external-db/issues/412#issuecomment-1462366258,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/A5XRCNHWTT3CJJY4AH3OGBTW3IAQRANCNFSM6AAAAAAUUKQX4E
.
You are receiving this because you were mentioned.Message ID:
@.***>


hongbo/efficient array append

follow up of #1279 and #1237
cc @suiyunonghen

Pull Request Test Coverage Report for Build 4040
Details

1 of 1 (100.0%)  changed or added relevant line in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 80.43%

Totals

Change from base Build 4039:
0.0%

Covered Lines:
4377

Relevant Lines:
5442

💛  - Coveralls


[CSDiagnostics] Diagnose ambiguous empty closures

Allow SpecifyClosureReturnType to be diagnosed in ambiguous context
Add a tailoed diagnostic for when it's impossible to infer a type of
an empty closure

Resolves: rdar://88256059

@swift-ci please smoke test


Using --test together with automatically generated tests fails

I was testing an interesting plugin for Robot Framework called https://github.com/Snooz82/robotframework-datadriver which can generate tests automatically using different input files. This works great, but if you want to involve pabot (using --testlevelsplit) there is a problem which I want to describe here.
I try starting the test both, as described in robotframework-datadriver as a library which activates a listener and I also tried modifying robotframework-datadriver to use the --prerunmodifier, to get the test generation run "earlier" in the process.
But both these tests fail because pabot starts the robot instances with the --test "Test Name" parameter and robot framework cannot find the automatically generated tests at this "early stage".
Would it be possible to get the --test parameter to filter the tests to run, after the prerunmodifier has finished? I assume the library listener is far to late in the process though...

I don't remember was there some reason why we decided to do filtering based on --test/--suite/--include/--exclude first and only then run pre-run modifiers. Now that I think about it, running modifiers first and allowing using standard options to filter possibly added tests afterwards makes more sense. Changing the order is obviously trivial and updating tests and docs shouldn't be too much work either. The change would be backwards incompatible, but doing it in a major release ought to be fine.
Have you @JockeJarre tested does changing the order actually fix the issue? If it does, would be you be interested in creating a PR?

The problem comes up when using pabot together with the datadriver plugin. I am discussing with mkorpela (pabot) and René (datadriver) on slack and we (actually they) try to solve it between these two components and call robot differently. It would mean we would not have to change anything in robot.
Anyway good to hear your thought on maybe changing it here.
Depending on how far we come with the ideas from above I would try to make a PR.

Yeah, I saw that discussion as well. The problem is that data-driver is a listener (i.e. used at execution time) and --test and others need to be used before execution starts. If it could be changed to pre-run modifier then this change ought to help.

The issue is now fully solved between Pabot and datadriver https://github.com/mkorpela/pabot/issues/187 so this issue can be closed!
So with datadriver we can dynamically create variations of tests from a datafile and pabot is able to start them all in parallel.
Thanks for your support

It's great that the original issue is resolved. I still think running modifiers before filtering based on cli options should be considered. I'll reopen this issue to use it as a reminder.

shall we change the title then to reflect more what is meant?

@pekkaklarck I am using prerunmodifier and facing this issue - dynamically generated tests does not gets included/excluded or failed test rerun gets those tests.
Is this issue being planned to be fixed soon or suggestion to workaround it?

Added this to RF 3.2 scope.

The change was as trivial as I expected. I was a bit surprised that we actually had tests for running modifiers after other config, but because there was no reasoning why that decision was done initially I simply updated those tests. All other tests passed with these changes. I'll still take a look should the User Guide be updated, but otherwise this is about to be ready.


Typo "Typescript"→"TypeScript"

https://docs.microsoft.com/en-us/javascript/api/overview/azure/service-bus-readme?view=azure-node-latest
related: "https://github.com/MicrosoftDocs/azure-docs-sdk-node/pull/1287#pullrequestreview-768207375"
@danieljurek  - Thank you for your suggestion.

@hyoshioka0128 Thank you for the PR! 🎉


CDK Drag-Drop - Object Configuration on attributes

Feature Description
Implementing the possibility of elements with only one attribute and one object passing all the options, is more organized and easier to deploy.
Example:
<div [DragDropList]="{
listID: 'idlist1',
listConnectedTo: ['list2', 'list3', 'list4', 'list5'],
listData: list1,
listOrientation: 'horizontal',
listDropped: dropListDropped($event)
}" > ... </div>

<!-- OR --->

<div [DragDropList]="DragDropListConfigObj"> ... </div>

<!-- OR --->

<div [DragDropList]="{ listID: 'idlist1', ...DragDropListConfigObj }"> ... </div>

And another for the list elements:
<div [DragDropItem]="{
itemData: item,
itemDisabled: false,
itemMoved: dragMoved($event),
cdkDragReleased: dragReleased()
}" *ngFor="let item of list1; let item = i"> item </div>

<!-- OR --->

<div [DragDropItem]="DragDropListConfigObj" *ngFor="let item of list1; let item = i"> item </div>

Use Case
Facilitates the library learning curve and also enables easier and more organized changes. could be applicable on any Angular-Drag-Drop. I don't think it's hard to do, but if you want you wouldn't need to make a bigger effort to start a deployment method since the library already provides one.

The problem with doing this is that changes inside the object won't be picked up by change detection, unless the entire object is swapped out. Furthermore, it introduces a second way of doing the same things as before which can make the API confusing. We currently have the CDK_DRAG_CONFIG injection token that'll allow you to customize most of the options either for the entire app, or a subset of it.

Do you have any usage example please? I didn't find any

I'm sorry, my previous comment was wrong. It looks like we never got around to expanding the CDK_DRAG_CONFIG to support more options. I'll open a PR so that most of the input defaults can be changed through there.

Will this be like an object that I change the settings to use globally or in a specific dragdrop list without having to set the attributes in html !?

The object would allow you to set the default values for all the lists inside a module or a component. E.g. here's how you would make all lists default to being horizontal:
import {NgModule} from '@angular/core';
import {DragDropModule, CDK_DRAG_CONFIG} from '@angular/cdk/drag-drop';

@NgModule({
  imports: [DragDropModule],
  providers: [{
    provide: CDK_DRAG_CONFIG
    useValue: {
      orientation: 'horizontal'
    }
  }]
})

Wow, this will make html much cleaner, especially when you have multiple lists with similar settings, let me know when you release this update please! It will be very good!
To overwrite I would just put the differences in the attributes right?

Correct, this object will only configure the defaults, but then you can use the inputs to change it on each instance. I can't guarantee when it'll be released, but you can keep an eye on the PR. https://github.com/angular/components/pull/17970


fix for redirect to same state

I have 3 roles:
anonymous, member, admin
I have 3 states:
.state("login", {
    data: {
        permissions: {
            only: ['anonymous'],
            redirectTo: 'home'
        }
    },
    url: "/login",
    controller: 'loginCtrl'
})
.state("home", {
    data: {
        permissions: {
            except: ['anonymous'],
            redirectTo: 'login'
        }
    },
    controller: 'dashboardCtrl'
})
.state('list', {
    data: {
        permissions: {
            only: ['admin'],
            redirectTo: 'login'
        }
    }
})

If I'm currently in the role of "member" and in state "home" and try to navifate to "list"
Then I get redirected to "login" and then automatically redirected back to "home"
I also have a pageloader directive that displays a "loader". This pageloader keeps loading, because $stateChangeSuccess or $stateChangeError are never triggered.
If I add the "reload: true" then $stateChangeSuccess is triggered.
    .directive('pageLoader', [
        '$timeout',
        function ($timeout) {
            return {
                restrict: 'AE',
                template: '

',
                link: function (scope, el, attrs) {
                    el.addClass('pageLoader hide');
                    scope.$on('$stateChangeStart', function (event, toState, toParams, fromState, fromParams) {
                        el.removeClass('hide');
                        el.addClass('animate');
                    });
                    scope.$on('$stateChangeSuccess', function (event, toState, toParams, fromState) {
                        event.targetScope.$watch('$viewContentLoaded', function () {
                            el.addClass('hide');
                            el.removeClass('animate');
                        })
                    });
                    scope.$on('$stateChangeError', function (event, toState, toParams, fromState) {
                        console.log('$stateChangeError: ' + toState)
                    });
                }
            };
        }
    ])

I think this should be an option, it is not necessary for everyone. I believe we have a problem achieving this as of right now because of this:
https://github.com/angular-ui/ui-router/issues/1620#issuecomment-104610338

I don't see a need for having a reload hardcoded either. The good news though, they accepting PRs for having options added to the stateChangeStartevent and even added that to the 0.2.16 milestone of ui-router. See https://github.com/angular-ui/ui-router/issues/1620#issuecomment-114477207


Request IIW Credential

Also include the link to the IIW logo

Mediator no longer handle issue-credential protocol. Issuer functionality is moved to it's own repo(s)


Additional testing guidance

Hi guys!
I have a hard time figuring out the best approach to unit test our modules(actions, stores & getters).
I have seen the issue #128 and docs about testing that are pretty simple and straight forward in that example and mocked data is reasonable.
My stores have collections and data that are related to each other and sometimes I need to combine that resources to get wanted data for containers/components. Getters fetch that data exposed from multiple stores and depend on it.Problem occurs when I'm to test such getter/action. I need to mock a bunch of data and repeat that for every similar test.
What is your approach to testing such getters and populating data stores before asserting correct return values from getters?
Because in your test example you noted "...we did not stub or mock any part of the NuclearJS system". As I understand, you are thinking about methods like reactor.evaluate or reactor.dispatch etc. For setting up state we are left with reactor.loadState and created actions.
What do you use to populate multiple stores for just one action or getter test?
Calling multiple actions to prepare terrain before testing another action doesn't seem like a solution.
I also have actions that evaluate state before dispatching. Is that an anti-pattern?
Maybe I need a completely different approach, but it's all a bit vague for me at the moment. Any recommendations, guidelines or suggestions would be welcome and helpful.
Thank you

It's perfectly reasonable to have actions evaluate reactor state before dispatching.  A good way to think about NuclearJS is a large map of state that you can read and write to anytime (just writes have to go through dispatch).
We usually invoke whatever setup actions need to happen in tests if we are testing some action performing the proper state change, it's not ideal but sometimes this complexity is necessary.  Another way to simply testing is to make the store handler or getter a pure function that can be tested in isolation, which is much easier to test all use cases.  And then have a single test that ensures that the proper state of several actions takes place.
Hope this helps!

@jordangarcia just to make sure I understand. For example if the action we are testing depends on state set up by some other actions. We can call those actions to prepare the state and then call the targeted action and check for proper state change?
I have module that handles form editing and it consists among other things of few actions, and some depend on the other ones.
I.e. there are actions for registering form fields to store(init values), updating specific form fields and reseting all of them to init values.
If I'm to test reset action I would first need to register form, update some fields and in the end try to reset it to initial values. So, in this scenario you would just go ahead and call the required actions inside test case?
Thanks a bunch for your response I appreciate it

Yeah I tend to be okay with calling actions in tests to setup the proper state, as this is actually the use case you'd more likely encounter in production.
There is a misconception that unit testing is inherently better, but I am very uncomfortable with having to mock all dependencies in a language without interfaces (javascript).  In a statically typed language like java you can implement mocks that conform to the same interface and know that you mocks are realistic in javascript mocking isn't so clean and can lead to tests passing when the actual code doesn't even do what you think it does.

Thank you very much @jordangarcia!
As you've answered and clarified the questions I'll close the issue.


ARMv7/armhf version missing

Hi, I see that there is a standard ARMv7 install, but the :armv7 tag fails to pull anything through. Is this just a hangover from the mono to dot net switch?

Hi, we're not doing it as a tag anymore, it's a separate docker container:
https://hub.docker.com/u/emby/
Thanks.

Thanks Luke. I tried searching and went through the docs, but didn't spot this.


adds files genererated by npm run plugin.spine.full.dist

This PR Fixes a bug
Describe the changes below:
Adds the output from npm run plugin.spine.full.dist
Ref this issue: https://github.com/photonstorm/phaser/issues/5118
(files were edited and included in Phaser 3.23 but spine plugin was not built to dist)
companion PR updates phaser examples:
https://github.com/photonstorm/phaser3-examples/pull/311

Thanks for this PR, but closing it off as I've done loads of work on Spine for 3.5


Fix random failures in config package tests

What does this PR do?
Fix flakiness where config sync tests would fail if automated fuzzing generated a proxy field that was the empty string. Since empty strings in a config are handled specially (taken to mean "unset the field" even if a default is detected), this would cause tests to fail randomly.
What issues does this PR fix or reference?
N/A
Is it tested? How?
N/A
PR Checklist

[ ] E2E tests pass (when PR is ready, comment /test v8-devworkspace-operator-e2e, v8-che-happy-path to trigger)

[ ] v8-devworkspace-operator-e2e: DevWorkspace e2e test
[ ] v8-che-happy-path: Happy path for verification integration with Che

/retest

/test v8-images


Add Laravel sets to "find rule" page

Looks good :clap:

When one of the Laravel rule clicked, it seems back to /find-rule instead of detail page, step to reproduce:

Open https://getrector.com/find-rule?activeRectorSetGroup=laravel
Click one of the rule listed.
It should go to detail rule, it currently back to /find-rule


Remove unused argument in _get_data_files_patterns

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.


Wayland support

Both bevy and winit support wayland surfaces natively, but bevy_egui opts out of the necessary feature flags.
In testing, it looks like just enabling them works fine. I don't know how to test if it makes a difference on wasm, though. Consider enabling wayland for bevy and winit, or at least supporting this through a feature flag?

I believe that just enabling wayland feature for bevy in the project that depends on both bevy and bevy_egui will do it. Cargo features are supposed to be additive, so even though bevy_egui just specifies the minimal feature set it needs, your final binary will have Bevy compiled with a union of features specified in your Cargo.toml and bevy_egui's one.
Unless bevy_egui itself needs any API that is exposed by wayland feature, there shouldn't be a need for enabling it.
Let me know if that helps.

I'll close the issue as I believe there isn't anything incompatible with Wayland in bevy_egui. If the problem still persists and you can confirm that it's indeed a problem on bevy_egui's side, please let me know or feel free to open a new issue.


PR #111: Replace phpMyAdmin documentation with Adminer.

You're just knocking these things out... thanks!

 Thanks for merging. :)


mud-input-control too much top margin

Bug type
Component
Component name
MudCheckBox
What happened?
From 6.0.10 to 6.0.11 my layout is changed over many pages.
There is a extra top margin which in my opinion should not be there.
In my layouts there is everywhere a top-margin of 6px.

Expected behavior
I think here should not be a margin-top set.
Reproduction link
https://try.mudblazor.com/snippet/wkGGkLuqgdBxUoxA
Reproduction steps

see picture

Relevant log output
No response
Version (bug)
6.0.11
Version (working)
6.0.10
What browsers are you seeing the problem on?
Firefox, Chrome, Microsoft Edge
On what operating system are you experiencing the issue?
Windows
Pull Request

[ ] I would like to do a Pull Request

Code of Conduct

[X] I agree to follow this project's Code of Conduct

I only use checkboxes. But radiobuttons could have the same problem. I did not check.
I guess it is linked to https://github.com/MudBlazor/MudBlazor/pull/4084


feat: Reorder collection datasets (#6483)

Reason for Change

#6483

Changes

Added reorder dataset functionality as per mocks.
TODO. Draft PR only.

Testing steps

Curator may only reorder datasets while collection is private collection, or private revision collection.
Curator may only reorder datasets with the feature flag reorder=true.
Curator may only reorder datasets when all datasets are loaded and valid.

Checklist 🛎

[ ] Add product, design, and eng as reviewers for rdev review
[ ] For UI changes, add screenshots/videos, so the reviewers know what you expect them to see
[ ] For UI changes, add e2e tests to prevent regressions

Notes for Reviewer

Superseded by https://github.com/chanzuckerberg/single-cell-data-portal/pull/6665 (as per Slack).


separate update and reply and a stub for acquiring and releasing lock

@cjellick -- checked for idempotency - works well.
fixes https://github.com/rancherio/rancher/issues/1196

Notes about the race condition bug so that we dont forget it this so that we dont forget it:
Steps to reproduce the "extractedConfig not found" error:

Turn idempotency checks on int cattle
Put a breakpoint at JooqObjectManager line 121 in cattle
create a machine
When you hit the breakpoint and value has "Saving Machine Config" or the extractedConfig field, orchestrate the threads such that the "Saving Machine Config" goes first and the extractedConfig field thread goes second.

The root cause is that cleanupResources is not working properly because machine.Name is empty. This can be fixed by creating a new string variable for the machine name.

We also contend that this is a bug in cattle that occurs because of a dirty write. It should not be as easy as it is to get this race condition and the dirty write.
We think the fix could/should be to:

Aqcuire a readWrite lock.
Reread the resource
Write the updates.

hey guys, any idea when this going to be incorporated into rancher?

@akurkin it got superseded by some other work, but we should be circling back to it soon. Out of curiosity: are you looking for something in particular out of this PR? It is basically a backend refactoring effort with very little user-facing impact.

@cjellick sure, I can explain. Maybe I misunderstood something and this PR won't resolve the issue :smile:
Couple times happened to me that machine created using digital ocean provider via Rancher UI (or API) ended up in a state 'error' with some error message in Docker Machine, similar to "exceeded number of retries (60)" or something like that. So I thought that with this PR it'll help Rancher to recover from this state, since VM was created just fine, only thing that it took a bit longer. It would help if Rancher could detect it and re-connect to that VM.


Show average SST for entire NMS on "Key climate & ocean drivers" windows

Currently, modal windows such as the one below, show SST for the polygon centroid.

SST should be  calculated as the average across the sanctuary.

The commit just pushed above is a first pass at the core of the problem - generating an average SST for a slice in time for the entire sanctuary.
Here is an example of what it produces, which gives the average SST for the entire channels islands NMS for May 2020:
> mean_SST("cinms", "2020", "05")
[1] 15.72583

At first glance, this seems to be working properly. For example, you can see here that the SST raster and the Sanctuary polygons line up properly.

But a little more digging is required to ensure that the right raster cells are being extracted to calculate the average.

Great job Jai! Let's iterate updates in the following ways:

Migrate get_nms_ply() to work generically in utility.R from rocky.R (so no weird Ben file dependencies). Or better yet, migrate to dedicated R 📦.
Use st_bbox(nms_ply) to get bounding box of any study area, eg sanctuary.
Use rerddap package to extract the gridded data given bounding box  a la intro to rerddap vignetterequire("rerddap")
sstInfo <- info('jplMURSST41')
# get latest daily sst
murSST <- griddap(sstInfo, latitude = c(22., 51.), longitude = c(-140., -105), time = c('last','last'), fields =
'analysed_sst')

I updated Ben's code to fix several bugs in the calculation of SST - the function rerrddap in the spatial.r file. The code now runs and I produced a csv (avg-sst_cinms.csv) that contains a history of mean and standard deviation of SST, using the function generate_all_SST.R (also in spatial.R). To do:

The modal windows that contain the SST figure need to be modified to point to this csv.
The SST figure needs to be modified to include both mean and sd in the plot.
In the code there were two things that came up - they might be an issue or not. First, line 78 is as follows:

  r <- raster(nc$summary$filename)

This line produces the error:
Error in as.Date(time, origin = startDate) : object 'startDate' not found

However, the line still runs - weird.
4. The second issue is with line 54, which is:
  sanctuary_ply <-   as_Spatial(st_union(get_nms_polygons(sanctuary_code)))

That produces the warning:
Warning message:
In sp::proj4string(obj) : CRS object has comment, which is lost in output

Having read into it, I don't think that this particular issue (which has to do with projections) really matters in our case, but I thought I would bring it up.
5. As a last thing, you will note that line 54 is a rewrite of your code Ben (changing from tidyverse form to the more old-fashioned form of writing R). I did this, because your version (which is still in the code, but commented out) produced some errors, but inconsistently so. The error is:
Error in UseMethod("st_geometry") : no applicable method for 'st_geometry' applied to an object of class "c('SpatialPolygonsDataFrame', 'SpatialPolygons', 'Spatial', 'SpatialVector')"

Output to https://github.com/marinebon/cinms/blob/master/data/oceano/avg-sst_cinms.csv

Next step in Viz:

OLD: red area plot of temp
NEW: red line of mean with ribbon +/- standard deviation
OUTSIDE Ben's laptop, in Github Actions, etc

The new time series figure plots both the average as well as the standard deviation of temperature. I couldn't figure out the functions in oceano.R that were used to generate the previous version of the figure  (plot_timeseries and generate_timeseries), so I just wrote a simple new function to create the new figure, which is here in oceano.R
And here is the function itself:
plot_SST_timeseries <- function(csv){
  # The purpose of this function is to generate the figure showing the sea surface temperature time series
  # for a Sanctuary (displaying both avg and standard deviation of temp). The function has one parameter
  # (csv) which is the path name for the csv data file to be plotted

  # Read in the csv file
  SST_history <- read.csv(csv, header = TRUE)

  # create a data frame which lines up the data in the way that dygraph needs it
  SST_history <- data.frame(date = as.Date(SST_history$date, "%Y-%m-%d"), SST = SST_history$average_SST, lower = SST_history$average_SST-SST_history$standard_deviation_SST, upper = SST_history$average_SST+SST_history$standard_deviation_SST)
  SST_history <- xts(x = SST_history[,-1], order.by = SST_history$date)

  # create the figure
  dygraph(SST_history, main = "Sea Surface Temperature", xlab = "Date", ylab = "Temperature (°C)")%>%
    dySeries(c("lower", "SST", "upper"), label = "Temperature (°C)", color = "Red")%>%
    dyRangeSelector()
}


Avoid latest setuptools for rl

Motivation

To fix CI
Description of the changes

Avoid latest setuptools for rl

@toshihikoyanase Could you review this PR?

How about adding a TODO comment or an issue to remove this constraint in the future?

Thanks! In my poor understanding, we cannot expect gym to resolve the issue because it is in a sort of maintenance mode and suggests being replaced by a successor library, Gymnasium as announced at gym. Thus https://github.com/DLR-RM/stable-baselines3/pull/780 is a directly related issue to resolve the issue.


add tolerance to grid charging check to allow for floating point issues

A floating point error (~1e-15) was causing a stack overflow in the powerflow code. Add a tolerance to fix the issue.

Alternative fix would be to set gen to zero if it's smaller than some tolerance. I think "tolerance" in the powerflow code is too high for this approach, I'd want 1e-7 or smaller for this approach.
Test with
Test_Case.zip

Still failing for case 3 of attached file, hangs at 66.6%

Case 3 of attached file - grid target 0 and time series critical load hangs as above image with these changes...
Test_Case.zip


Wiimote: No devices found

Hey, thanks for making this nice lib! I have been playing with the Wiimote script, trying to get my EV3 to run. However, it seems like the Devices class needs an update.
I have my motors in Output A and D, so I've updated my script. However, no matter how I plug it, I get this:
Traceback (most recent call last):
  File "./wii-drive.py", line 36, in <module>
    left_motor = pyev3.Motor(pyev3.OUTPUT_D)
  File "/home/robot/WII/pyev3.py", line 102, in __init__
    LEGO_PORT_NAME=port or '*' #,
  File "/home/robot/WII/pyev3.py", line 21, in __init__
    raise IndexError('No devices found')

The 'devices' variable seems empty no matter what I do, so I guess the problem lies in whatever magic the pyudev line does.
Any help would be greatly appreciated by myself and my son. Thanks again!

I am new to Github, so I don't know if I can go off topic, but what version of RCX are you using and have you gotten the basic functionality to work without the wiiremote?


Using with Angular 6

Installed the plugin and built it. No issues. But when i use it, it says
\node_modules\a                                                      ngular2-notification-bar\index.ts is missing from the TypeScript compilation. Pl                                                      ease make sure it is in your tsconfig via the 'files' or 'include' property. The missing file seems to be part of a third party library. TS files in publishe                                                      d libraries are often a sign of a badly packaged library. Please open an issue i                                                      n the library repository to alert its author and ask them to package the library                                                       using the Angular Package Format (https://goo.gl/jB3GVv).
any idea?

try this please
https://github.com/wnabil/ngx-notification-bar


BC V.22 container with AAD authentication

I am trying to setup an Azure Test VM using AAD and a v.22 container.
But the container keps going into an unhealthy state. The setup/scripts worked fine with our old version 14 containers.
The event log of the container is full with "System.InvalidOperationException: AadApplicationId cannot be null or empty" errors.
Checking the https://learn.microsoft.com/en-us/dynamics365/business-central/dev-itpro/administration/authenticating-users-with-azure-ad-openid-connect?tabs=multitenant%2Cadmintool page, it says that in v22 we must use "ADOpenIdMetadataLocation" instead of "ClientServicesFederationMetadataLocation" that had to be used in version older then v22.
I have checked nav-docker and it seems that ADOpenIdMetadataLocation is set, but shouldn't it also set ValidAudiences?

My script for testing containers with AAD auth can be found as a response here:
https://github.com/microsoft/navcontainerhelper/issues/2990

Thanks, does this script have a guide how to run it?

You need to replace my secrets with yours - there are 4 of those
$containerName = "bcserver"
$licenseFile = $LicenseFileUrlSecret.SecretValue | Get-PlainText
$credential = New-Object pscredential -ArgumentList 'admin', $PasswordSecret.SecretValue
$artifactUrl = Get-BCArtifactUrl -country us -type OnPrem
$aadCredential = New-Object pscredential -ArgumentList ($AadUserNameSecret.SecretValue | Get-PlainText), $AadPasswordSecret.SecretValue

Thanks. That part I did (eventually) figure out.
But how do I specify which Azure Subscription / Resource Group to use?
As a user-admin in our organization I need to specify the subscription where I'm allowed to do stuff like this. :)
Right now it's trying to do it somewhere where I cannot do stuff.

Sorry, but as stated, that script is just my test script, and I provided that as such (not as a command or like).
You can also use https://aka.ms/getbc to get an Azure VM with AAD setup - I am doing some fixes to this (currently in https://aka.ms/getbc2), but if you want to extract the code and use it yourself - it is probably easier to look at and understand my test script.
You don't have to create the AAD apps in code - you can also create them manually - it was more for stating that using these parameters, New-BcContainer will create a container with 22, running AAD authentication that works.
The script does a lot more than that as well.

https://aka.ms/getbc is now updated with all - and works with AAD and 22.
If your office account requires multi-factor authentication, the log (http://hostnameofvm/Status.aspx) of the VM will display a device code with which you need to login to your AAD account of your BC tenant in which the AAD Apps will be created.

Hi Freddy,
I hi-jacked one of our admins, and were able to run the script. It did fail on one of the later tasks, but it allowed me to log in.
Now I just need to figure out how to apply this to our VM image bake and build processes.

You can easily reuse the same AAD Apps for all your VMs - you just need to have all Reply-To addresses inserted there (I think)
Then you don't need to create any AAD Apps - but just setup BC to use the existing ones and have all the clientIDs and secrets in a keyvault.


Stackable not working for <Card.Group>

Steps to Reproduce
<Card.Group stackable={true}> //stuff </Card.Group>
Expected
Stacked when resize
Result
Reduces to 3 per row and no further
Any ideas how to make it work? :)

Could you complete all the required fields in the issue template, please? We also need to know which version and have a codepen to investigate.
However, I almost sure that you haven't define a viewport.


Some responses missing the "problems" array

DocumentResponse , ProductResponse does not have the new problems array in 3.4

TODO Josef: pull request


Error when generating the code if the jdl file has an entity with no fields

Error when generating the code if the jdl file has an entity with no fields.
I wanted to have an entity that groups 3 other entities, so it has only relations and no simple fields.
entity Calendar {
}
jhipster-ionic
INFO! No custom sharedOptions found within blueprint: generator-jhipster-ionic at /home/lucian/.nvm/versions/node/v16.17.0/lib/node_modules/generator-jhipster-ionic
Welcome to JHipster v7.8.1
 info Using blueprint generator-jhipster-ionic for project-name subgenerator

ERROR! baseName is required
Error: baseName is required
at default.get sharedData [as sharedData] (/home/lucian/.nvm/versions/node/v16.17.0/lib/node_modules/generator-jhipster-ionic/node_modules/generator-jhipster/generators/generator-base.js:211:15)
at default.loadUser (file:///home/lucian/.nvm/versions/node/v16.17.0/lib/node_modules/generator-jhipster-ionic/node_modules/generator-jhipster/generators/bootstrap-application/generator.mjs:86:18)
at Object. (/home/lucian/.nvm/versions/node/v16.17.0/lib/node_modules/generator-jhipster-ionic/node_modules/yeoman-generator/lib/index.js:1097:23)
at /home/lucian/.nvm/versions/node/v16.17.0/lib/node_modules/generator-jhipster-ionic/node_modules/run-async/index.js:49:25
at new Promise ()
at /home/lucian/.nvm/versions/node/v16.17.0/lib/node_modules/generator-jhipster-ionic/node_modules/run-async/index.js:26:19
at /home/lucian/.nvm/versions/node/v16.17.0/lib/node_modules/generator-jhipster-ionic/node_modules/yeoman-generator/lib/index.js:1098:9
at new Promise ()
at default.executeTask (/home/lucian/.nvm/versions/node/v16.17.0/lib/node_modules/generator-jhipster-ionic/node_modules/yeoman-generator/lib/index.js:1069:12)
at runLoop.add.once (/home/lucian/.nvm/versions/node/v16.17.0/lib/node_modules/generator-jhipster-ionic/node_modules/yeoman-generator/lib/index.js:1049:14)

@Luca1234 Does this error happen with the main jhipster generator as well?

The main generator seems to be working well.
Now the error with jhipster-ionic seems to be different:
`Error running generator app: TypeError: /home/lucian/Documents/jhipster/test-error/ionic/node_modules/generator-jhipster-ionic/generators/ionic/templates/src/app/pages/entities/_entity.model.ts.ejs:19
17|  limitations under the License.
18| -%>

19| <%_
20| const variables = {};
21| const defaultVariablesValues = {};
22| let tsKeyType;

Cannot read properties of undefined (reading 'type')
TypeError: /home/lucian/Documents/jhipster/test-error/ionic/node_modules/generator-jhipster-ionic/generators/ionic/templates/src/app/pages/entities/_entity.model.ts.ejs:19
17|  limitations under the License.
18| -%>

19| <%_
20| const variables = {};
21| const defaultVariablesValues = {};
22| let tsKeyType;

Cannot read properties of undefined (reading 'type')
at default.eval ("/home/lucian/Documents/jhipster/test-error/ionic/node_modules/generator-jhipster-ionic/generators/ionic/templates/src/app/pages/entities/_entity.model.ts.ejs":16:16)
at _entity.model.ts (/home/lucian/.nvm/versions/node/v16.17.0/lib/node_modules/generator-jhipster-ionic/node_modules/ejs/lib/ejs.js:692:17)
at /home/lucian/.nvm/versions/node/v16.17.0/lib/node_modules/generator-jhipster-ionic/node_modules/ejs/lib/ejs.js:258:40
at new Promise ()
at tryHandleCache (/home/lucian/.nvm/versions/node/v16.17.0/lib/node_modules/generator-jhipster-ionic/node_modules/ejs/lib/ejs.js:256:14)
at Object.exports.renderFile (/home/lucian/.nvm/versions/node/v16.17.0/lib/node_modules/generator-jhipster-ionic/node_modules/ejs/lib/ejs.js:489:10)
at EditionInterface.processFile (/home/lucian/.nvm/versions/node/v16.17.0/lib/node_modules/generator-jhipster-ionic/node_modules/mem-fs-editor/lib/actions/copy-tpl-async.js:22:20)
at EditionInterface.applyProcessingFileFunc (/home/lucian/.nvm/versions/node/v16.17.0/lib/node_modules/generator-jhipster-ionic/node_modules/mem-fs-editor/lib/actions/copy-async.js:14:52)
at EditionInterface.exports._copySingleAsync (/home/lucian/.nvm/versions/node/v16.17.0/lib/node_modules/generator-jhipster-ionic/node_modules/mem-fs-editor/lib/actions/copy-async.js:94:50)
at EditionInterface.exports.copyAsync (/home/lucian/.nvm/versions/node/v16.17.0/lib/node_modules/generator-jhipster-ionic/node_modules/mem-fs-editor/lib/actions/copy-async.js:50:17) {
path: '/home/lucian/Documents/jhipster/test-error/ionic/node_modules/generator-jhipster-ionic/generators/ionic/templates/src/app/pages/entities/_entity.model.ts.ejs'
}
`
This is the sample model I used for test:
`application {
config {
baseName test
packageName com.test
applicationType monolith
    buildTool maven
    authenticationType jwt

    databaseType sql
    devDatabaseType mysql
    prodDatabaseType mysql
    cacheProvider ehcache

    clientFramework angular
}
entities *
service * with serviceClass
filter *
dto * with mapstruct
paginate * with infinite-scroll

}
entity Parent {
}
entity Child1 {
name String
}
relationship OneToMany {
Parent{child} to Child1{parent}
}`

Thanks for providing the steps to reproduce. I'll try to look at this in the next few days.

@Luca1234 I was able to reproduce the issue and attempted to fix it with optional chaining in https://github.com/jhipster/generator-jhipster-ionic/pull/802. This fixes the generation process, but fails when running prettier:
Error: Error parsing file ../ionic4j/cypress/e2e/entities/parent/parent.cy.ts: SyntaxError: Identifier expected. (79:42)
  77 |         cy.authenticatedRequest({
  78 |           method: 'DELETE',
> 79 |           url: `${parentApiUrl}/${parent.}`,
     |                                          ^
  80 |         }).then(() => {
  81 |           parent = undefined;
  82 |         });

I also tried your JDL with regular JHipster, and it does generate but does not compile:
[INFO] Error: src/main/webapp/app/entities/parent/update/parent-form.service.ts:46:7 - error TS2322: Type '{}' is not assignable to type 'IParent | NewParent'.
[INFO]
[INFO] 46       return {};
[INFO]          ~~~~~~~~~~


Implement sort-merge join

Which issue does this PR close?

Closes #141.
Rationale for this change

related to #1599
What changes are included in this PR?

Are there any user-facing changes?

I hope to find time to review this more carefully tomorrow

cc @Dandandan  and @tustvold

I plan to review this PR first thing tomorrow morning US eastern time (~ 6AM or so)

I've just finished my first pass of review, and the overall structure looks great to me. Nice work @richox!
I plan to re-review the polling logic carefully tomorrow morning.

Cc @Dandandan you might be interested in this as well.

I agree -- thank you so much @richox 👍


403 on https://fcm.googleapis.com/wp/

Please confirm the following:

[x] I have read the README entirely
[x] I have verified in the issues that my problem hasn't already been resolved

Setup

Please provide the following details, the more info you can provide the
better.

Operating System: Linux
PHP Version: 7.1
web-push-php Version: <1.0.0>

Please check that you have installed and enabled these PHP extensions :

[x] gmp
[x] mbstring
[x] curl
[x] openssl

Please select any browsers that you are experiencing problems with:

[x] Chrome
[x] Firefox
[x] Firefox for Mobile
[ ] Opera for Android
[ ] Samsung Internet Browser
[ ] Other

Please specify the versions (i.e. Chrome Beta, Firefox Beta etc).

Chrome (last version) on Desktop, Chrome (last version) on Mobile
Problem
Sending a push notification from php I got
Array
(
    [success] =>
    [endpoint] => GuzzleHttp\Psr7\Uri Object
        (
            [scheme:GuzzleHttp\Psr7\Uri:private] => https
            [userInfo:GuzzleHttp\Psr7\Uri:private] =>
            [host:GuzzleHttp\Psr7\Uri:private] => fcm.googleapis.com
            [port:GuzzleHttp\Psr7\Uri:private] =>
            [path:GuzzleHttp\Psr7\Uri:private] => /wp/[...]:[...]
            [query:GuzzleHttp\Psr7\Uri:private] =>
            [fragment:GuzzleHttp\Psr7\Uri:private] =>
        )

    [message] => Client error: `POST https://fcm.googleapis.com/wp/[...]:[...]` resulted in a `403 Forbidden` response:

<!DOCTYPE html>
<html lang=en>
  <meta charset=utf-8>
  <meta name=viewport content="initial-scale=1, minimum-scale=1,  (truncated...)

    [statusCode] => 403
    [reasonPhrase] => Forbidden
    [expired] =>
    [content] => GuzzleHttp\Psr7\Stream Object
        (
            [stream:GuzzleHttp\Psr7\Stream:private] => Resource id #11

Features Used

[x] VAPID Support
[ ] GCM API Key
[x] Sending with Payload

Example / Reproduce Case

Please provide a code sample that reproduces the issue. If there is a
repository that reproduces the issue please put the link here.

Similar to this, but implemented in CodeIgniter
https://github.com/Minishlink/web-push-php-example/blob/master/src/send_push_notification.php
Other

Please put any remaining notes here.

In my send_push_notification I have
$auth = array(
    'VAPID' => array(
         'subject' => 'https://www.mywebsite.com/',
         'publicKey' => $this->app->get_config_option('vapid')['public_key'],
         'privateKey' => $this->app->get_config_option('vapid')['private_key'],
     ),
);

I've tried on Firefox and I can't subscribe to push notifications, on debug console I have
Impossible to subscribe to push notifications DOMException: "Invalid raw ECDSA P-256 public key."
I've tried with 2 different generated keys.

Sorry, now it works. Some fields in database were too short.
Thank you anyway. Great lib!


Create on_create callbacks on Scenario Selector

Issue
Add a callback on Scenario Selector called 'on_create' that will be called after the creation of the scenario.
This will allow the user to populate the scenario and manage it.

or we could select it on creation => on_change would be enough ...
But I suppose you want to differentiate between creation and selection ...

Right now, the workaround is on_change. This is what I have used. A user told me the same yesterday but this makes it really hard.  on_change will not work (or hardly work) on many use cases.


unsync on segment or part removal

This came up after testing by Kenneth.
This PR makes the rundown go unsynced if the currently playing segment or part is removed

I've had a chat with Julian & Tom, merging in this :)


Feature requests to improve DX of this tool

Hey there,
I started playing around with this tool in the last time. I actually like the idea behind it, but there are some things I'd like to improve (please note that I'm opening an issue first to discuss, if @teozkr is fine with it, I'll open PRs for my requests)

[ ] copy manual-repo.nix into the directory during sbtix-gen-all2. I think its unnecessary to force users to copy the file from a cloned repo, this is definetely a step that can be automated
[ ] option to generate a default.nix with a sbtix.buildSbtProgram expression. This would make it easier to bootstrap/prototype applications in Scala as no extra packaging steps are needed and this sort of approach doesn't need much tweaking
[ ] copy/refresh all expressions in this repository. When driving such an approach sbtix itself ensures that everything is up-to-date. Right now it's up to the developer as he'd need to update the rev and sha256 in the fetchFromGitHub expression needed to download the internal SBTix API.

Thanks in advance :-)

Hey, and thanks for the feedback. :D Splitting my reply into sections, since this ended up getting a bit long-winded.

Regarding manual-repo.nix, I agree that we're in a pretty crappy situation at the moment. :/
Your solution seems like a decent quick fix to the immediate problem, but sadly manual-repo.nix is something that needs to be maintained manually at the moment, depending on your SBT version. Eventually the goal is to get rid of manual-repo.nix completely, but sadly I have no idea at the moment about where to hook into SBT to get that information.
As a workaround, I'm curious about whether it would be enough to add the corresponding version of org.scala-sbt % compiler-interface to the classpath genNix considers. It feels pretty hacky to hard-code in an extra dependency, but it would probably be worth it if it killed manual-repo.nix.

I absolutely agree about generating a default.nix, as long as that doesn't overwrite existing files unless the user opts into that. It would also be nice to have a way to choose between buildSbtProgram and buildSbtLibrary.

I'm not sure about whether you mean updating the versions in this repository, or changing the template to a moving target that automatically updates.
If it's the former, that's mostly because there hasn't been a proper release yet, and I know myself well enough to know that it'd get outdated immediately if I had to update it manually after every new commit. You could probably make Travis update that automatically, but the value of that seems limited, since after a proper alpha it should just point towards that instead.
If it's the latter, I'm definitely against it since I like the JVM community's overall insistence on version pinning. If you come back half a year later then your build shouldn't stop working just because Sbtix has been to a newer version of SBT, or because an option was renamed or whatever.

Overall, very good points to raise even if I don't always agree with your solutions. I'd gladly accept a PR solving 1 or 2. 3 would probably be fixed best by doing an alpha release soon and updating the README (and templates) after that. Probably after these and possibly #24 are fixed.
That said, I'm going on vacation tomorrow. I'm bringing my laptop, but probably won't have too much time to work on this for about a week.

thanks for your answer!

Your solution seems like a decent quick fix to the immediate problem, but sadly manual-repo.nix is something that needs to be maintained manually at the moment, depending on your SBT version.

I know. A first idea was to add some sort of CLI option to copy the manual-repo.nix, however you're right this needs a better solutionin the long term.

I absolutely agree about generating a default.nix, as long as that doesn't overwrite existing files unless the user opts into that. It would also be nice to have a way to choose between buildSbtProgram and buildSbtLibrary.

Yes, I'm 100% on your side. Will provide a PR in the next time for that :-)

I'm not sure about whether you mean updating the versions in this repository, or changing the template to a moving target that automatically updates.

Right now a default.nix looks like this:
let
    sbtixDir = fetchFromGitHub {
        owner = "teozkr";
        repo = "Sbtix";
        rev = "5277d96745afcc04a0873102f4a5f80cfc68fa23";
        sha256 = "17h2ijb50q76al72hpggv35bbqiayyzvybmfwyx1cr5xzlpvzcqh";
    };
    sbtix = pkgs.callPackage "${sbtixDir}/sbtix.nix" {};
in ...

This is what I'd like to get rid of. Other tools (see node2nix copy such files (node-env.nix in the case of node2nix) directly into the project directory rather than forcing people to download it.

This is what I'd like to get rid of. Other tools (see node2nix copy such files (node-env.nix in the case of node2nix) directly into the project directory rather than forcing people to download it.

Fair enough. I used to do it that way, but I didn't like that there wasn't a clear separation between project files and Sbtix boilerplate, as well as that it wasn't obvious where to upgrade it from or what the current version was.
On the other hand, it would make sense to go back to that approach but have sbtix-gen (and co.) copy it automatically, since sbtix-gen and sbtix.nix are currently supposed to be from the same release anyway.

I used to do it that way, but I didn't like that there wasn't a clear separation between project files and Sbtix boilerplate

understandable. However I think that most users would like to have one command to bootstrap an environment to build their Scala Code using Nix and this is IMHO avoidable extra-work (furthermore we would have to update the fetchFromGitHub expression in our default.nix template if we implement my second suggestion).
AFAIK node2nix made this optional (but true by default). Would this be a suitable alternative?

At the moment my preferred solution would be to just make sbtix-gen copy it, but add a header to the generated file that mentions what version it was copied from.

can be closed as all tasks are finished :-)


Support for Ansible Galaxy

There's a REST API available at.

Example user call
Example role call

Hi, @espadrine!
For example, I have some ansible role at https://github.com/ansible-roles/ansible-role-sublimetext3_packagecontrol and published at Galaxy https://galaxy.ansible.com/list#/roles/3078
So, 3078 is the role ID that used in API calls.
I think there will be cool if next badges for ansible will be available at shields.io:

Badge Name
API Call URL
Keys used to generate result
Result / Badge Value example

Role name
https://galaxy.ansible.com/api/v1/roles/3078/
summary_fields->owner->username + '.' + name
igor_mukhin.sublimetext3_packagecontrol

Minimum ansible version
https://galaxy.ansible.com/api/v1/roles/3078/
min_ansible_version
1.4

Versions count
https://galaxy.ansible.com/api/v1/roles/3078/versions/
count
3

Latest version
https://galaxy.ansible.com/api/v1/roles/3078/versions/
first(results)->name
v0.2.0

To generate all this badges we need get only role ID from user. Or even just role's galaxy URL and then automatically extract ID from hash.

Thanks a lot for this information! That is tremendously helpful.
I notice that they send a cookie (Set-Cookie: sessionid=oxd81rvw70noo42xqwg594t6ngc8ncsq; expires=Mon, 25-May-2015 19:16:28 GMT; httponly; Max-Age=1209600; Path=/), that is a bit odd. Otherwise, it all seems straightforward.

@espadrine Don't think that cookies matter something.
You can just get information and not care about cookies.
Try wget -qO - https://galaxy.ansible.com/api/v1/roles/3078/versions/.

@espadrine Hi. How can I help you to force some progress on this?

I tried making the first one, with this kind of style:
I am unsure of whether that suits the notion of "role" that users are familiar with, or how easy it is to figure out where to find the role id.

Oh, cool :)
Role Id assigned to role once it added to galaxy.
For example this is list of my roles: https://galaxy.ansible.com/list#/users/9737

@igormukhingmailcom does getting the information like this still work? I can't find IDs on my roles.

Ansible galaxy 2 uses "name based" urls now, but old urls should be
redirected.
On Friday, 19 February 2016, Scott Miller<EMAIL_ADDRESS>wrote:

@igormukhingmailcom https://github.com/igormukhingmailcom does getting
the information like this still work? I can't find IDs on my roles.
—
Reply to this email directly or view it on GitHub
https://github.com/badges/shields/issues/286#issuecomment-186050323.

Sounds like we probably need a PR to fix this functionality then

@smiller171 here's a one-liner for finding your role's ID once it's on Galaxy:
$ ansible-galaxy info YourUser.RoleName | grep -E 'id: [0-9]' | awk {'print $2'}

This works on Ansible <IP_ADDRESS> but I recon it's working on older versions, too.

@igormukhingmailcom how did you get the 3078 id for your role?

Since this issue comes up at the top of the result list when searching for how to get a badge that shows the latest version of a collection on Ansible Galaxy, I'll post our solution for that.
Ansible Galaxy returns the latest version of a collection using an HTTP GET on
https://galaxy.ansible.com/api/v2/collections/{NS}/{COLL}/ as follows:
{
    . . .
    "latest_version": {
        "version": "1.0.0-dev1",
    }
}

That allows using the dynamic badge creation feature of shields.io, e.g. in Markdown syntax:
![Version on Galaxy](https://img.shields.io/badge/dynamic/json?style=flat&label=galaxy&prefix=v&url=https://galaxy.ansible.com/api/v2/collections/ibm/ibm_zos_core/&query=latest_version.version)

Resulting in this badge:

Thanks for sharing @andy-maier! Given the above, it seems like we should be able to add a native version badge if you or anyone else would be interested in submitting a PR

For anyone who finds this search, you can use the API to query for a role directly. E.g.
https://galaxy.ansible.com/api/v1/roles/?search=myrole
And once you get the role ID, you can use this to get the downloads count:
https://img.shields.io/badge/dynamic/json?color=blueviolet&label=Galaxy Downloads&query=%24.download_count&url=https%3A%2F%2Fgalaxy.ansible.com%2Fapi%2Fv1%2Froles%2FROLEID%2F%3Fformat%3Djson


Background or overlay issue

how to fix that the background dissolve was fine in version 0.6.0 but the background is like this in higher versions?
https://github.com/emilkowalski/vaul/assets/77485398/fc2bb2a0-dcdd-4aa5-990b-f4a815aaddd6
also why there is orange border?

Can you provide a demo with reproduction? The orange border is there, because Radix changes focus to the drawer, you can disable it with css.


Featured links automatically showing description

What
Add meta descriptions automatically below hub links in the accordion. (See attached design).
Why
To give me context on the hub content, and allow for short links.

https://trello.com/c/rBSB0bIQ/281-automatically-add-the-hub-page-metadescription-below-hub-links-in-the-accordion

@andysellick updated


LicenseFinder cannot determine the license of some npm packages

I tried running LicenseFinder on a large npm project and noticed that it could not determine the license of some npm packages (21 of 384). This surprised me because all 21 packages name a license (like MIT or Apache-2.0 for example) in their package.json file.
I tried reading through the source code to better understand how LicenseFinder determines the license of an npm package. Is it correct that LicenseFinder looks for a LICENSE file inside the package? I checked the 21 packages an none included a LICENSE file (although some included a LICENSE.md file). One of these packages is vue-template-compiler for example.
If that is the case, I would suggest falling back to the license field inside the package.json if no LICENSE file could be found.

I guess I was wrong, hls.js contains both a LICENSE file and a license field in its package.json, but LicenseFinder cannot determine its license (should be Apache 2.0).

Well, this is strange: I created a new npm project and installed all dependencies for which LicenseFinder could not determine the license in the previous project. In this new project LicenseFinder could determine all those licenses.

I debugged a bit into it: Turns out
npm list --json --long

does not reliably include license fields in its output. In my bigger project it included the license field only for the root package but not for any of the dependencies. This then caused spec_licenses to be empty.
https://github.com/pivotal/LicenseFinder/blob/ced7de9f22a627cb7bd2f11f18e41ffb914ec0b0/lib/license_finder/packages/npm_package.rb#L67-L78
I think a more reliable approach would be to take the license information from the package.json file of the actual package. Here is something I quickly hacked together (first time writing ruby code):
def initialize(npm_json)
  install_path = npm_json['path']
  p install_path
  package_path = install_path.nil? ? nil : File.join(install_path, "package.json")
  package_json = !package_path.nil? && File.file?(package_path) ? JSON.parse(File.read(package_path), max_nesting: false) : npm_json
  spec_licenses = Package.license_names_from_standard_spec(package_json)
  p spec_licenses
  @json = npm_json
  @identifier = Identifier.from_hash(npm_json)
  @dependencies = deps_from_json
<EMAIL_ADDRESS>        @identifier.version,
        description: npm_json['description'],
        homepage: npm_json['homepage'],
        spec_licenses: spec_licenses,
        install_path: install_path,
        children: @dependencies.map(&:name))
end

Hi @WIStudent - FWIW, license_finder does check for licenses in the package.json (via npm list) before checking for license files.
In the first instance, were the packages reported, but licenses not found?  I noticed NPM v7 doesn't list packages beyond immediate dependencies by default.  I opened an issue about it a while back. https://github.com/pivotal/LicenseFinder/issues/834
Is it possible this change in behaviour in NPM explains what you're seeing?

@timani I switched a lot between npm versions, so I am not sure anymore which one I used in the tests above. But I just noticed that the output of npm list --json --long depends on the current npm version, the npm version that was used to install the project, and whether the -a option was included.
Install with v6.14.13 / run with v6.14.13 / no -a option

Transitive dependencies are included, packages inside the json file have the "license" field
license_finder reports 25 of 2264 with unknown licenses

Install with v6.14.13 / run with  v7.18.1 / no -a option

No transitive dependencies are included, "license" field only exist for root package
license_finder reports 1 of 132 with unknown licenses

Install with v6.14.13 / run with  v7.18.1 / with -a option

Transitive dependencies are included, "license" field only exist for root package
license_finder reports 11 of 2459 with unknown licenses

Install with v7.18.1 / run with v6.14.13 / no -a option

Transitive dependencies are included, packages inside the json file have the "license" field
license_finder reports 16 of 740 with unknown licenses

Install with v7.18.1 / run with  v7.18.1 / no -a option

No transitive dependencies are included, "license" field only exist for root package
license_finder reports 11 of 132 with unknown licenses

Install with v7.18.1 / run with  v7.18.1 / with -a option

Transitive dependencies are included, "license" field only exist for root package
license_finder reports 146 of 2236 with unknown licenses

Sadly I don't know how I got my original 21 of 384 unknown licenses.
By the way, you can pass the -a flag to npm list using license_finders --npm-options flag
license_finder report --format=html --save=license-report.html --npm-options="\-a"

Are there actually over 2000 unique packages?  I'd be interested in getting a (sanitized) copy of your package.json to have a play too.

@timhaines I cannot share the package.json unfortunately, it's a work related project that's not open source. Basicly it's an android/iOS app using capacitor + vue and aws-amplify for backend communication. The dev dependencies mostly consist of testing (jest and cypress), linting (eslint), packaging (webpack, babel, typescript) and some dependencies for own build/deploy scripts.
I checked the package-lock.json. According to the docs, when using npm7 the packages field should contain every unique package. It contains 1377 prod and 2788 dev packages. The package.json contains 54 dependencies and 77 devDependencies (although I just noticed that 3 dependencies should actually be devDependencies).
A while ago I created a simple vue3 project  using the vue-cli to checkout some new vue3 features. Although this project only has a total of 15 dependencies in its package.json, according to Github's dependency graph it's dependency tree contains 1018 dependencies.
Because everything gets bundled by webpack, almost nothing of the dependency tree lands in the final output. This just gave me the idea to further research if there are any webpack plugins that can list the licenses of any package that gets bundled into the final output. I stumbled across LicenseFinder because we are using Gitlab at work and Gitlab seems to use it as a base for their own integrated license scanning.

I don't see where the code is looking into a LICENSE file. As @timhaines pointed out, it is getting it from the package json itself. @WIStudent did your hack solution actually get you better output? If it did we can look at getting a PR through but I think there may be NPM version issues that could be affecting this

@xtreme-shane-lattanzio I think there are multiple issues with npm7:

As already mentioned in https://github.com/pivotal/LicenseFinder/issues/834, npm list --json --long no longer returns transitive dependencies
At least in my case the output of npm list --json --long also did not include the license field in any of the dependencies.

The second point is the reason why I initially thought LicenseFinder would only search for LICENSE files. Because the output of npm list does not include any licenses, the spec_licenses passed to the constructor of the superclass is always an empty array. And because install_path is set to the directory of the package, LicenseFinder will then search this directory for licenses. At least that's the behavior that is documented in the superclass.
https://github.com/pivotal/LicenseFinder/blob/8d221073b508ecbbb727648b0c682a29b60c37b3/lib/license_finder/package.rb#L8-L20
My hacky sollution fixed my issue that the license was undefined for some of the found dependencies (but not the issue, that not all dependencies were found). It did by taking the install_path directory that was taken from the npm list output, looking for the package.json file inside that directory and reading the license information from that package.json file.
Npm itself admits that the output of npm list is not the best and warns that there will probably be significant changes with npm8.
Starting with npm7, the package-lock.json  contains every package inside the dependency tree in a flat array. The usage of npm7 can be detected by "lockfileVersion": 2. I think instead of relying on npm list it would be much simpler to take the paths to every installed package from the package-lock.json, follow these paths to each package.json, read the license information from the package.json file and additionally pass the path to install_path, so that LicenseFinder can also search for license files (or whatever it does when both spec_licenses and install_path are present).

I think you have a good handle on this and I am not sure when we can prioritize this so please feel free to make a PR if you want to get this in!

Hi, any updates regarding this? There is already npm v9 and now we get empty licences list.

@Mistic92 I stopped using LicenseFinder and am now using webpack/rollup plugins instead to determine the packages that get bundled into the final output and their licenses.

@WIStudent but webpack/rollup is only for single language and if we don't use this packers it won't work. Looks like Pivotal is not investing a lot of time on this tool anymore.

@Mistic92 There is another issue https://github.com/pivotal/LicenseFinder/issues/916 that asks for support for npm 7 and newer, but there doen't seem to be any progress either. I guess most people that need license detection in npm dependencies moved to other solutions like I did with webpack/rollup plugins for example.


#![allow(non_snake_case, non_camel_case_types)]

nooooooooooooooooooooooooooooo :sob:

Complain to the OpenType spec editor, not me. :-)

You can put it on individual structs and stuff so you don't have to enable it globally.