Make registration checker plugin automatically derive target directory

Only relevant when registration checker is used outside of ash sbt plugin, which is highly unlikely... let's consider this issue a deep backlog.

Closing to clean up GH issues, will re-open if really needed one day


Update UG

Codecov Report

Merging #198 (2146569) into master (183cf0b) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master     #198   +/-   ##
=========================================
  Coverage     54.96%   54.96%
  Complexity      699      699
=========================================
  Files           143      143
  Lines          3022     3022
  Branches        393      393
=========================================
  Hits           1661     1661
  Misses         1170     1170
  Partials        191      191

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ea0442a...2146569. Read the comment docs.


fix(getClippingRect): fix incorrect clipping rect calculation with fixed ancestors

Fixes https://github.com/floating-ui/floating-ui/issues/2288
@leandro-fenoglio-ca @sallerli1 @jcfranco  can you test this change on the scenario(s) that have been failing for you to see if they are fixed?

@atomiks Nested floating-ui elements are no longer hidden, but positioning is still off.

@jcfranco can you post a sandbox with that structure shown?

Sure thing. Here is the original use case reported to us: https://codepen.io/cont-kolomeets/pen/yLERQPx?editors=1000

Gotcha. I'll work on creating an isolated repro case.

Fixes #2288
@leandro-fenoglio-ca @sallerli1 @jcfranco can you test this change on the scenario(s) that have been failing for you to see if they are fixed?

@atomiks , thank you very much for the support. I tested your solution here and it solved the problem that was happening.
One question, after reviewing and approving this solution, will it be applied to popperjs as well?

No problem

One question, after reviewing and approving this solution, will it be applied to popperjs as well?

If you want to contribute it sure :) I'm only working on Floating UI, but Popper can receive fixes from external contributions.

@atomiks  I built and tested in our codes, the issue is fixed, thanks a lot for your support!

I'm going to merge this since it fixes the linked issue's problem, but if you find time to make a minimal repro @jcfranco feel free to open a new issue


Extract region from Kendrick plot

Enable region of interest drawing in Kendrick plot to filter feature lists

included in #1885


[Quarm] When in 3rd person and feared, camera detaches

When feared camera stays at fear location and character can be seen running off (not sure if camera reattaches after fear, died when this happened)

This has been fixed for a few commits


feat: compare models

Need to finish some refactoring in Rust before starting this part (OpenAI provider same as LlamaCpp)


Feat/marxan 1469 hash and sign export files

This PR adds logic for verifying and integrity checking import files signature and manifest files
Feature relevant tickets

check signed hash of zip file contents users try to import
hash and sign exported data in downloadable zip artifacts
configure signing secret for integrity checks of exported data (via env var+config)

@tiagojsag could I ask you to please have a look at the way I handled the new RSA key secret in the Terraform part of things?


fix styled-components in package.json

styled-components is move to @types/styled-components.
See below:

https://github.com/styled-components/styled-components/issues/2099

styled-components is move to @types/styled-components.
See below:

styled-components/styled-components#2099

thanks bro <3


Fix Issue and Add Scroll View

Changes:

For Issue: https://github.com/Wootric/WootricSDK-Android/issues/50

Using Fragment (FragmentManager, FragmentActivity & DialogFragment) from Support Library v4.
Trello: https://trello.com/c/y6MsJeXx/2755-use-fragement-from-support-library-dialogfragment-fragmentmanager

For Issue: https://github.com/Wootric/WootricSDK-Android/issues/49

Add TAG SURVEY_DIALOG_TAG to Fragment Transaction somewhat https://github.com/Wootric/WootricSDK-Android/blob/master/androidsdk/src/main/java/com/wootric/androidsdk/SurveyManager.java#L187
Trello: https://trello.com/c/fplSIQQ7/1112-add-tag-to-fragment-transaction

Fix Survey view getting hidden from bottom if Survey question get's long by adding Scroll View

Please refer to changes of https://github.com/Wootric/WootricSDK-Android/compare/aa-fix-issue-and-scroll-view?expand=1#diff-31822127d59d919a5fbe722716e1493f
The issue was not only with German Translation, it's more because if lengthy NPS question is found.
Trello: https://trello.com/c/FPX4S5Zd/2780-android-buttons-and-feedback-field-hidden-when-language-is-long-ie-german-translation

Testing:

Go to https://github.com/Wootric/WootricSDK-Android/blob/master/app/src/main/java/com/wootric/androidsdk_demo/MainActivity.java and update your credential or refer to http://docs.wootric.com/android/#installing-android-sdk to setup your app for testing purpose and start a survey.
For seeing Scroll View update surve language to German like wootric.setLanguageCode("DE"); as it converts to have long NPS question. Or, you can update NPS question by setting up Product Name like  wootric.setProductName("this is very very longgggg product name that I am using for testing the view of message bar of our product in android so let's have fun");

Images of Scroll View showing Fix:

For German Language:
On Start:

On Scroll:

For Long Product Name:
On Start:

On Scroll:

Note: I also have updated build version 27.0.3 along with min SDK version 16 and target SDK version 26

@diegoserranoa thank you so much for your explanation and review.
Thanks for letting me know about such BG issue and suggestion. I finally was able to replicate it with API level 16 and screen size 720x1280 and is now fixed (Image below):

Also, updated PR with changes required to show versioning and deployment.


IBM cloud object storage support

I added support for IBM COS, which is essentially a wrapper around AWS S3 (IBM COS APIs seem to be compatible, up to the point that the aws python cli can be used against an IBM COS instance).
This is going to be the case until there is a functional go sdk for IBM COS (it is still a work in progress).
I tested the following:

Uploading files to buckets in a COS instance.
Adding multiple buckets.
Migrating between buckets.

Thank you all for this awesome project.

Thanks @acorbellini for your contribution!  Can you please resolve merge conflict?

Sure, sorry about that, I was working on a older version of the branch and didn't notice.

Did you start this PR on the master branch?  I see that you have a commit like this "Merge branch 'development' into ibm-cos-support".  If you start on development branch and do a rebase, I assume you won't have a commit that says "Merge branch 'development' ...".  If so, can you please create a branch on development instead?  Thanks.

@sfzeng Please take a look.

Hi, acorbellini, could you please add the apache license declare to cosmover.go and ibmcos.go, and replace the package name ibmCosMover with ibmcosmover?

Added the licence info as requested.
Sorry about the messy changes. I made the PR and went on vacations. Hope now I have a more clean branch to push.

Looks good to me now.  @sfzeng Please see if your comments are addressed.  Thanks.


Group Drawer doesn't work

Hi, I'm using Hyprland and I wanted to make something similar to the example here but it doesn't work, I mean, the icons are there but they are always there, they don't hide, this is my config
//FOR POWER GROUP
    "custom/arch": {
        "format": "󰣇",
        "tooltip": false,
        "on-click": "wofi",
        "on-click-right": "wlogout --protocol layer-shell"
    },
    "custom/quit": {
        "format": "󰍃",
        "tooltip": false,
        "on-click": "hyprctl dispatch exit"
    },
    "custom/lock": {
        "format": "󰌾",
        "tooltip": false,
        "on-click": "gtklock"
    },
    "custom/reboot": {
        "format": "󰜉",
        "tooltip": false,
        "on-click": "(sleep 10 && reboot) & (notify-send --urgency=critical --expire-time=20000 --wait 'System Reboot' 'The system will reboot in 10 seconds, click to cancel' && killall sleep)",
        "on-click-right": "reboot"
    },
    "custom/shutdown": {
        "format": "󰐥",
        "tooltip": false,
        "on-click": "(sleep 10 && shutdown now) & (notify-send --urgency=critical --expire-time=20000 --wait 'System Shutdown' 'The system will shutdown in 10 seconds, click to cancel' && killall sleep)",
        "on-click-right": "shutdown now"
    },
    "custom/sleep": {
        "format": "󰒲",
        "tooltip": false,
        "on-click": "systemctl suspend"
    },
    //GROUP CONFIGURATIONS
    "group/audio": {
        "orientation": "inherit",
        "modules": [
            "pulseaudio",
            "pulseaudio#microphone"
        ]
    },
    "group/system": {
        "orientation": "inherit",
        "modules": [
            "tray",
            "temperature",
            "network",
            "bluetooth"
        ]
    },
    "group/power": {
        "orientation": "inherit",
        "drawer": {
            "transition-duration": 500,
            "transition-left-to-right": true
        },
        "modules": [
            "custom/arch",
            "custom/quit",
            "custom/lock",
            "custom/sleep",
            "custom/reboot",
            "custom/shutdown"
        ]
    }

Am I doing something wrong?

Never mind , I was using the package waybar-hyprland which is out of date, my bad


vgbh translate upgrade

For an explanation of how to fill out the fields, please see the relevant section
in PULL_REQUESTS.md
Commit Message:
Additional Description:
Risk Level:
Testing:
Docs Changes: https://github.com/cloudnativeto/envoy/blob/zh/docs/root/intro/arch_overview/http/upgrades.rst
Release Notes:
[Optional Runtime guard:]
[Optional Fixes #Issue] #89
[Optional Deprecated:]

/LGTM

@helight 我提交的review comment已经确认修改。你再看看哈

这个为什么关闭了呢？


Enhancement:

Could you make it so you can type the phrase for drunk notes / hivemind in capital letters? My i key doesn't work and I can only put it in capital letters (exept if I use caps lock wich doesn't work in friday night funkin for some strange reason) .
You could also make caps lock work.

Caps lock is weird with haxe
but yea sure I'll do the capital thing tho


isNull missing from json schema

the json schema is missing isNull property

Hello @gionn,
It is correct isNull is not part of the json schema.
The isNull deprecated and is replaced by notExists, exists (when you want to check if the path is actual available) or isNullOrEmpty, isNotNullOrEmpty (when you want to check if the value of a path is null or empty.
As some time (probably in version 0.5.0) the isNull and isEmpty will be removed.
Greetings,
@quintush

Thanks for clarifying, I've raised a PR to clearly state that in the docs I check everytime I am writing unit tests :D


[SPARK-7576] [MLLIB] Add spark.ml user guide doc/example for ElementwiseProduct

Merged build triggered.

Merged build started.

Test build #33744 has started for   PR 6501 at commit f7be7ad.

Test build #33744 has finished for   PR 6501 at commit f7be7ad.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Other than those minor items, looks good---thanks!

Merged build triggered.

Merged build started.

Test build #33791 has started for   PR 6501 at commit 4ad93d5.

Test build #33791 has finished for   PR 6501 at commit 4ad93d5.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

LGTM, I'll merge with master and branch-1.4  Thanks!


issue: login page in dark mode

Description
The image in the login page doesnot fit well for the dark mode.
Screenshots

Additional information
I would like to work on this issue.

@itsmeAnubhab Closing this issue as the UI is already updated.


No documentation

There is virtually no documentation on how to install and use this project. Please provide us with the necessary info to install and use this project. And preferably an install release so that we can use existing tools to istall this project. And maybe a brief intro into the various core hotcakes only code.

You'll find documentation and installation packages on the official project website.
https://hotcakes.org

More specifically, please reference the installation documentation here:
https://hotcakescommerce.zendesk.com/hc/en-us/articles/115002941503-Installing-Hotcakes-Commerce


Updating all the tests cases

Updating all the test cases to improve code coverage.

this closes #71
@lewismc

Coverage increased (+1.6%) to 92.672% when pulling abf90279ff30866f49cb041efc67ee38da4e2555 on Omkar20895:master into 2730fdbbc01c382595671e602efb218d8ab38ba7 on lewismc:master.

Most of the test coverage is reduced because of the recent addition of 'if and else' statements in the code that need not be tested. Coverage looks good to me.
@lewismc


[Fix #10633] Fix infinite autocorrection loop in Style/AccessorGrouping when combining multiple of the same accessor

Previously when the same accessor was listed more than once, the autocorrection would continually add it to the grouped accessor. This fixes it to ensure that the accessor will only show up once.
Fixes #10633.

Before submitting the PR make sure the following are checked:

[x] The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
[x] Wrote good commit messages.
[x] Commit message starts with [Fix #issue-number] (if the related issue exists).
[x] Feature branch is up-to-date with master (if not - rebase it).
[x] Squashed related commits together.
[x] Added tests.
[x] Ran bundle exec rake default. It executes all tests and runs RuboCop on its own code.
[x] Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.

Nice 👍


Update tests runs

I guess we should tests against php 7.2 or something
7.0 and 5.6 are EOL ;)

But those are the ones that run on the updater server ;) Ubuntu 16.02 or?

Nope 7.2 is run on updates.nextcloud.com

Okay 👍


[Website] Fix link colour contrast

There are some issues with the contrast of links when viewing docs in dark mode. These issues are fixed by this PR.
it addresses #3928 and is a continuation of #3705.

I still found one occurrence of a blue link:
https://ff4ba5b7.cloudflare-docs-7ou.pages.dev/ruleset-engine/rules-language/functions/#function-uuidv4

Can you check, please?

Sure! These were the only ones I found last week.


[FEATURE] Operator: Basic Metrics enabled

Enable basic metrics for the operator:

controller: workqueue, tenant operation (optional detailed) metrics
subscription: http handler metrics

Note: For the controller, detailed tenant operation metrics are disabled
by default and can be enabled by setting the environment variable:
DETAILED_OPERATION_METRICS to true.
Documentation will be published under:
https://sap.github.io/cap-operator/docs/usage/metrics/

Can be tested using:
ghcr.io/pavan-sap/cap-operator/controller:0.11.0
&
ghcr.io/pavan-sap/cap-operator/server:0.11.0
The metrics server for both is running under port 9090 (and /metrics path by default)

[like]  Nayak, Pavan reacted to your message:

From: skrishnan-sap @.>
Sent: Tuesday, November 12, 2024 1:26:51 PM
To: SAP/cap-operator @.>
Cc: Nayak, Pavan @.>; Author @.>
Subject: Re: [SAP/cap-operator] [FEATURE] Operator: Basic Metrics enabled (PR #152)
@skrishnan-sap commented on this pull request.

In website/content/en/docs/usage/metrics.mdhttps://github.com/SAP/cap-operator/pull/152#discussion_r1838099278:

@@ -0,0 +1,62 @@
+---
+title: "Metrics"

Can we change this to "Operator Metrics" to be clear (as this is clubbed under "Usage" where application related processes are documented)?
—
Reply to this email directly, view it on GitHubhttps://github.com/SAP/cap-operator/pull/152#pullrequestreview-2429593310, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AF67EY2CR5HATODJGBZELBD2AH6ZXAVCNFSM6AAAAABRG2HPSWVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDIMRZGU4TGMZRGA.
You are receiving this because you authored the thread.Message ID: @.***>


Audio playback

Implement audio in the library with an example.

While it compiles and works correctly on linux and alsa, on windows I'm getting the compilation error:
In file included from ..\fenstim\src\fenster\fenster_audio.h:22,
                 from ...\nimcache\audio_r\@m..@ssrc@sfenstim_audio.nim.c:9:
...\include\mmsystem.h:28:11: error: unknown type name 'UINT'
   28 |   typedef UINT MMVERSION;
      |           ^~~~
...\include\mmsystem.h:29:11: error: unknown type name 'UINT'
   29 |   typedef UINT MMRESULT;
      |           ^~~~
...\include\mmsystem.h:35:11: error: unknown type name 'UINT'
   35 |   typedef UINT *LPUINT;
      |           ^~~~
compilation terminated due to -fmax-errors=3.


registerPage: No converter for component of type "function ConnectFunction(props) {...

Bug Report
Prerequisites

[x] Can you reproduce the problem in a MWE?
[x] Are you running the latest version?
[x] Did you perform a search in the issues?

Environment Details and Version
Piral 0.8.0
Description
calling registerPage with a component returned by react-redux's connect() method, I'm getting an exception:
No converter for component of type "function ConnectFunction(props) {...
Steps to Reproduce

create a component using connect() of the react-redux package.
Pass that component to app.registerPage()
Notice it throwing an error.

Expected behavior
I expect this to work with react-redux components.
Actual behavior
An exception is thrown
Possible Origin
At this point, you are trying to use component.type:
https://github.com/smapiot/piral/blob/57dd5aff0ba728c60757a37f9072952d04795fb2/src/packages/piral-core/src/utils/components.ts#L16
But component.type is not a string, but instead is a function for this connected component.

I'm confused. Every React component (I'm aware of) must be a function (either a class component or a FC).
Can you show the MWE? I tried, e.g., a class component and everything works without a flaw.
Just to be clear - if your code ends up in this part, you'd put in an object (as in typeof foo === 'object'). Glancing over react-redux I've also not seen an object returned, just (wrapped) functions. Maybe I'm missing something though.

Here you go: https://github.com/SantoJambit/piral-mwe

I've taken a deeper look and I think the issue comes with React.memo. I've updated the MWE to use React.memo instead of react-redux to reproduce the issue.

Other react higher order components return objects as well: React.lazy, react.forwardRef.
The common part seems to be that an attribute $$typeof is present, with a value of Symbol(react.memo), Symbol(react.forward_ref), etc. respectively

I see, thanks for figuring out a way to reproduce this. I think we can deal with the $$typeof special prop for the moment.
According to the type definitions we have:
    interface ExoticComponent<P = {}> {
        /**
         * **NOTE**: Exotic components are not callable.
         */
        (props: P): (ReactElement|null);
        readonly $$typeof: symbol;
    }

So looking if $$typeof is there and a symbol could be sufficient.
Hotfix with 0.8.1 incoming later today / tomorrow morning.
Thanks for the report! : beers:

Landed in develop.


Update README.md

I added designers documentation Google docs here because that is where we have the names of people that worked on tasks

Cool


Gitter room

Hi, what do you think about Gitter room for bridge.net?

Sure, https://gitter.im/bridgedotnet
We'll monitor and see how it goes. No guarantee we'll always be there, or answer questions, but we'll give it a try.

@geoffreymcgill thanks, but you did not create a room

Fixed.

👍


Typechecking error when using typeclasses

Théophile Wallez reported the following program that does not typecheck:
assume val test_typeclass: Type -> Type

assume new type test_type (t:Type0) (tc:test_typeclass t)

assume val test_pred: #t:Type0 -> #tc:test_typeclass t -> test_type t tc -> bool

val test:
  #t:Type0 -> #tc:test_typeclass t -> #a:Type0 ->
  ps_b:(xa:a -> test_type t tc) -> Lemma (forall (xaa:a). test_pred (ps_b xaa))

At some point we get a constraint ?u xaa = ?v, where ?v has the tcresolve tactic associated with it (using meta) ... then we create a new uvar ?w : a -> test_typeclass t, and solve ?u and ?v in terms of ?w, however since there is no tcresolve tactic associated with it, ?w remains unresolved


Add theme Arberia for Hugo

Add theme Arberia for Hugo
Demo site: https://arberiatheme.netlify.app/
Github Repo: https://github.com/antedoro/arberia

Thanks for adding Arberia theme.
As per this, your theme seems to be released under the GPLv2 license. Whereas the LICENSE file indicates it as MIT.

@hugo-sid Sorry for the mistake.
I have updated the README.
I hope now it's all ok.

Thanks for adding Arberia theme.
As per this, your theme seems to be released under the GPLv2 license. Whereas the contents of LICENSE file seem to be as that of MIT.

Sorry for the mistake.
I have updated the README.
I hope now it's all ok.

No worries. Thanks for adding Arberia theme.


transform deepforest prediction into labelimg format

https://github.com/tzutalin/labelImg

https://github.com/ai-in-actiune/tree-counting-and-classification-in-images/pull/38


Add files via upload

Among us game by Anvay
Your checklist for this pull request
Author name
Author:

About your game
What is your game about?

How do you play your game?

Code
Check off the items that are true.

[ ] The game was made using the Sprig editor.
[ ] The game is placed in the in the /games directory.
[ ] The code is significantly different from all other games in the Sprig gallery (except for games labeled "demo").
[ ] The game runs without errors.
[ ] The name of the file/game contains only alphanumeric characters, -s, or _s.
[ ] The game name is not the same as the others from gallery

Image (If an image is used)

[ ] The image is in the /games/img directory.
[ ] The name of the image matches the name of your file.

Thanks for your PR!

I'm so sorry if you see this I accidently clicked and did not add the information


Command "setYaw" does not change movement direction

Using the absolute movement command "setYaw" changes the view orientation of the player but not his actual body orientation. Sending the "move 1" command afterwards (discrete or continuous) makes the player move into the yaw direction that was present previous to "setYaw".
In the discrete scenario the player moves sideways/backwards and in the continuous case the player changes back to the original yaw orientation.

The absolute movement commands don't currently play well with the continuous movement commands, which take control over the yaw/pitch and don't relinquish it easily... this is certainly something that should be improved.
In the discrete case, the setYaw command doesn't make a whole lot of sense unless it is restricted to multiples of 90 degrees, since discrete motion assumes a 4-connected grid and only allows the player to move one square at a time. There is a discrete turn command which can be used instead, which turns the agent by +/- 90 degrees.


[Stop] creating animated stop throws percent.match is not a function

I am not sure if Animating the Stop element is even possible. Is there some other way to achieve this.
let AnimatedLinearGradient = Animated.createAnimatedComponent(LinearGradient)
let AnimatedStop = Animated.createAnimatedComponent(Stop)
let AnimatedSvg = Animated.createAnimatedComponent(Svg)
let svg = (
    <AnimatedSvg height={400} width={350}>
    <Defs>
      <AnimatedLinearGradient id="grad" x1="0" y1="50" x2="100" y2="50">
          <Stop offset="0%" stopColor="#888" stopOpacity="1" />
          <AnimatedStop offset={driveAnimationValues_x1} stopColor="#888" stopOpacity="0.1" />
          <Stop offset="100%" stopColor="#888" stopOpacity="1" />
      </AnimatedLinearGradient>
    </Defs>

      <Rect x="10" y="20" rx="16" ry="16" width="96" height="32" fill="url(#grad)"/>
      <Rect x="116" y="20" rx="16" ry="16" width="96" height="32" fill="#888" />
      <Rect x="222" y="20" rx="16" ry="16" width="96" height="32" fill="#888" />

      <Rect x="10" y="62" rx="16" ry="16" width="96" height="32" fill="#888" />
      <Rect x="116" y="62" rx="16" ry="16" width="202" height="32" fill="#888" />

      <Rect x="10" y="104" rx="16" ry="16" width="192" height="32" fill="#888" />

      <Rect x="10" y="146" rx="16" ry="16" width="96" height="32" fill="#888" />
      <Rect x="116" y="146" rx="16" ry="16" width="96" height="32" fill="#888" />
      <Rect x="222" y="146" rx="16" ry="16" width="96" height="32" fill="#888" />

      <Rect x="10" y="188" rx="16" ry="16" width="96" height="32" fill="#888" />
      <Rect x="116" y="188" rx="16" ry="16" width="202" height="32" fill="#888" />

      <Rect x="10" y="230" rx="16" ry="16" width="310" height="32" fill="#888" />
    </AnimatedSvg>
);

TypeError: TypeError: TypeError: percent.match is not a function

This error is located at:
    in LinearGradient (at createAnimatedComponent.js:153)
    in AnimatedComponent (at Walkthrough.js:447)
    in RNSVGDefs (at Defs.js:8)
    in Defs (at Walkthrough.js:446)
    in RNSVGGroup (at G.js:23)
    in G (at Svg.js:128)
    in RNSVGSvgView (at Svg.js:108)
    in Svg (at createAnimatedComponent.js:153)
    in AnimatedComponent (at Walkthrough.js:445)
    in RCTView (at View.js:43)
    in RCTView (at View.js:43)
    in RCTScrollView (at ScrollView.js:1070)
    in ScrollView (at Walkthrough.js:483)
    in RCTView (at View.js:43)
    in RCTView (at View.js:43)
    in Walkthrough (created by Connect(Walkthrough))
    in Connect(Walkthrough) (at SceneView.js:9)
    in SceneView (at StackViewLayout.js:488)
    in RCTView (at View.js:43)
    in AnimatedComponent (at StackViewCard.js:12)
    in Card (at createPointerEventsContainer.js:28)
    in Container (at StackViewLayout.js:526)
    in RCTView (at View.js:43)
    in RCTView (at View.js:43)
    in StackViewLayout (at withOrientation.js:30)
    in withOrientation (at StackView.js:59)
    in RCTView (at View.js:43)
    in Transitioner (at StackView.js:21)
    in StackView (at createNavigator.js:57)
    in Navigator (at createKeyboardAwareNavigator.js:11)
    in KeyboardAwareNavigator (at createNavigationContainer.js:383)
    in NavigationContainer (at App.js:139)
    in PersistGate (at App.js:138)
    in Provider (at App.js:137)
    in App (at renderApplication.js:32)
    in RCTView (at View.js:43)
    in RCTView (at View.js:43)
    in AppContainer (at renderApplication.js:31)

This error is located at:
    in NavigationContainer (at App.js:139)
    in PersistGate (at App.js:138)
    in Provider (at App.js:137)
    in App (at renderApplication.js:32)
    in RCTView (at View.js:43)
    in RCTView (at View.js:43)
    in AppContainer (at renderApplication.js:31)
TypeError: TypeError: percent.match is not a function

This error is located at:
    in LinearGradient (at createAnimatedComponent.js:153)
    in AnimatedComponent (at Walkthrough.js:447)
    in RNSVGDefs (at Defs.js:8)
    in Defs (at Walkthrough.js:446)
    in RNSVGGroup (at G.js:23)
    in G (at Svg.js:128)
    in RNSVGSvgView (at Svg.js:108)
    in Svg (at createAnimatedComponent.js:153)
    in AnimatedComponent (at Walkthrough.js:445)
    in RCTView (at View.js:43)
    in RCTView (at View.js:43)
    in RCTScrollView (at ScrollView.js:1070)
    in ScrollView (at Walkthrough.js:483)
    in RCTView (at View.js:43)
    in RCTView (at View.js:43)
    in Walkthrough (created by Connect(Walkthrough))
    in Connect(Walkthrough) (at SceneView.js:9)
    in SceneView (at StackViewLayout.js:488)
    in RCTView (at View.js:43)
    in AnimatedComponent (at StackViewCard.js:12)
    in Card (at createPointerEventsContainer.js:28)
    in Container (at StackViewLayout.js:526)
    in RCTView (at View.js:43)
    in RCTView (at View.js:43)
    in StackViewLayout (at withOrientation.js:30)
    in withOrientation (at StackView.js:59)
    in RCTView (at View.js:43)
    in Transitioner (at StackView.js:21)
    in StackView (at createNavigator.js:57)
    in Navigator (at createKeyboardAwareNavigator.js:11)
    in KeyboardAwareNavigator (at createNavigationContainer.js:383)
    in NavigationContainer (at App.js:139)
    in PersistGate (at App.js:138)
    in Provider (at App.js:137)
    in App (at renderApplication.js:32)
    in RCTView (at View.js:43)
    in RCTView (at View.js:43)
    in AppContainer (at renderApplication.js:31)
    at percentToFloat (blob:http://localhost:8081/f5d64044-7756-4abd-8531-c5ccaf9d319a:142607:27)
    at blob:http://localhost:8081/f5d64044-7756-4abd-8531-c5ccaf9d319a:142629:16
    at forEachSingleChild (blob:http://localhost:8081/f5d64044-7756-4abd-8531-c5ccaf9d319a:5055:14)
    at traverseAllChildrenImpl (blob:http://localhost:8081/f5d64044-7756-4abd-8531-c5ccaf9d319a:4989:11)
    at traverseAllChildrenImpl (blob:http://localhost:8081/f5d64044-7756-4abd-8531-c5ccaf9d319a:5002:29)
    at traverseAllChildren (blob:http://localhost:8081/f5d64044-7756-4abd-8531-c5ccaf9d319a:5041:16)
    at Object.forEachChildren [as forEach] (blob:http://localhost:8081/f5d64044-7756-4abd-8531-c5ccaf9d319a:5064:9)
    at _default (blob:http://localhost:8081/f5d64044-7756-4abd-8531-c5ccaf9d319a:142624:21)
    at _class.render (blob:http://localhost:8081/f5d64044-7756-4abd-8531-c5ccaf9d319a:142541:41)
    at _class.proxiedMethod (blob:http://localhost:8081/f5d64044-7756-4abd-8531-c5ccaf9d319a:11274:32)

@msand this does not work anymore.


Please support microsoft service fabric on linux and maybe windows too

Service fabric supports running on Linux, it can run docker containers, it has a service discovery service named the naming service much like consul and it can even run docker compose files and it even has it's own DNS service that can facilitate service discovery based on the state in the naming service. Please add this is a supported backend, it would be amazing.
https://docs.microsoft.com/en-us/azure/service-fabric/service-fabric-docker-compose
https://docs.microsoft.com/en-us/azure/service-fabric/service-fabric-dnsservice
https://docs.microsoft.com/en-us/azure/service-fabric/service-fabric-connect-and-communicate-with-services

Here is a windows nanoserver-insider docker image for rabbit if that helps getting it supported on windows at all.
rabbitmq-nanoserver-insider.zip

The RabbitMQ team now maintains the plugin @ https://github.com/rabbitmq/rabbitmq-autocluster -- Mind closing this out and opening your feature request there?  Thanks!

Thanks I created an issue there


Improve diagnostics for incomplete manifests

You can pass a Matcher to MatchError (instead of just a string)
Le lun. 3 sept. 2018 à 14:23, Glyn Normington<EMAIL_ADDRESS>a
écrit :

@glyn commented on this pull request.
In pkg/core/manifest_test.go
https://github.com/projectriff/riff/pull/725#discussion_r214673111:

@@ -75,7 +75,7 @@ var _ = Describe("Manifest", func() {

  	It("should return a suitable error", func() {
  		Expect(err).To(HaveOccurred())

		Expect(err.Error()).To(HavePrefix("Manifest is incomplete:"))

		Expect(err.Error()).To(HavePrefix("Manifest is incomplete: istio array missing: "))

MatchError() requires a complete match and won't pass when just a prefix
matches.
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
https://github.com/projectriff/riff/pull/725#discussion_r214673111, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AATIljegdTcQpQ_6l2Z07yF_KOK1-51Xks5uXR8mgaJpZM4WXXte
.

Merged as 9893df87


crash in iOS cocos2dx

in iOS.
crash in follow lines.
auto target = (uint8_t*)GLExt::glMapBuffer(GL_ARRAY_BUFFER, GL_WRITE_ONLY);

compile failed in this line.
g_glUnmapBuffer = ::glUnmapBuffer;

I'm sorry for this bug.
I think that this bug is caused when I fixed other bugs.
I fix it at this week end.

in windows, It's running well.

I fixed and checked it on iOS and Mac.
https://github.com/effekseer/EffekseerForCocos2d-x

I have not checked a performance yet in this version. I will try it

I checked a performance. I think that it is no problem

I tested it. It 's no problems.
Thank you.
I closed this issue.


MixinExtras annotations not being remapped on NeoForge

I hope I'm at the right place here.
I'm using MixinExtras on a common/fabric/forge/neoforge project with yarn mappings and mixins in common.
As I understand, refmaps are now gone from NeoForge, so the mixin annotations are remapped directly instead.
This works without issue for standard annotations like @Inject, but fails for MixinExtras annotations.
For example, in
@ModifyExpressionValue(method = "postHit", at = @At(value = "CONSTANT", args = "intValue=2"))
the "postHit" will be left as-is, instead of being remapped to "hurtEnemy(Lnet/minecraft/world/item/ItemStack;Lnet/minecraft/world/entity/LivingEntity;Lnet/minecraft/world/entity/LivingEntity;)Z".
So far I've found two possible workarounds:

duplicate the offending mixin and manually change the annotations
switch the whole project over to mojmaps

This is a known issue with Tiny Remapper's mixin extension that will also need to be addressed upstream if Fabric ever wants to disable the mixin AP by default.

Yes, we'll have to downstream some TR and Loom 1.5 changes but the upstream work for it is done.

Whoo, it's fixed! :tada:
Already compiling and working, thank you!


Allow attachments in transactions

Allowing attachments in transactions is very useful to avoid having split transactions where you adquired multiple items (eg: groceries).
In my experience it's easy to link a transaction to an individual item (when you buy one thing), but when you go grocery shopping you do one payment but buy multiple things. I don't want to split that payment into the individual items because most times I don't need to split that into several categories but I still do want to capture the prices for history purposes (and, maybe in the far future, OCR search?).
Even for single items you could store the receipt in case you need it in the future for warranty purposes, though in that case maybe a link to external storage is more useful.

Just adding some sub-issues.

[ ] Design local file structure for attached files
[ ] Data model and migrations to support file attachments to transactions
[ ] Support attachments in tRPC procedures
[ ] Attachment preview
[ ] Attachment CRUD UI

Local file structure for attached files
We'll have one "data" folder, inside, we'll put:

db.sqlite
attachments folder

[transactionId] folders to indicate which transaction the files are associated to. Inside, we'll have all attachments for that transactions in a flat structure.

userSettings.json will need to change structure from
{
  "dbPath": "[...]/finlight.sqlite"
}

to something like
{
  "dataPath": "[...]/finlight"
}

We could have 2 settings, one for the attachments' location and another for the db location, but I think it's nicer and simpler to keep them together.
This is a config backwards incompatible change. There's no user base to maintain, so I'm just going to break compatibility. However, in order to be nicer about this going forward, even if just for my sake, I will make it easier by:
{
  "version": "1.0",
  "settings": {
    "dataPath": "[...]/finlight"
  }
}

Alternatives considered
We though of using SQLite Blobs for files, which would work quite nicely. However, there's a few issues:

Cloud storage services like Google Drive don't support syncing updates only, the entire database needs to be synced every time it changes. Even if we keep blobs in a separate SQLite, we'd have to re-sync all attachments every time.
It's a bit slower than raw file access.

attachments folder

[transactionId] folders to indicate which transaction the files are associated to. Inside, we'll have all attachments for that transactions in a flat structure.

Better having all attachments in the same folder than distributing them in year/month subfolders? What happens if a transaction has more than one attachment?

I wanted to keep the structure as simple as possible.

What happens if a transaction has more than one attachment?

All attachments for a given transaction will live in the same folder. There can't be 2 attachments in the same transactions with the same filename. This is enforced as well by a unique constraint at the db level: https://github.com/dsaltares/finlight-electron/pull/16/files#diff-84ed7d3e4d9d5c9c18074f0fac0eca077009db08c000992e1028c1ab6c6910eeR22.


Update to discord intents

https://discordpy.readthedocs.io/en/latest/intents.html#privileged-intents

wanna assign me to this @schana


Bad image

Please fix Test/Apple Golden 1/56_100.jpg

Hi,
Thank you for spotting this.
I have fixed the problem now.
I have extracted again the frames from that movie ... so all images with Apple Golden 1 have been replaced.
regards,
Mihai


Template Provisioning Error - MSoft 365 learning pathways

Describe the issue
Emailed that provisioning had failed. Site is accessible.
3de769bd-5732-48c6-bbe0-5fb15be71844

Hi,
Thanks for using the Look Book site. This seems to be a random hiccup on the SharePoint side which would imply that the template should work properly if you try it one more time. Seems that the provisioning did succeed partially. Can you test this one more time and, in case of any failure, share the updated Correlation ID (by creating a new issue) for us to double-check the flow. Thanks.


README: typo fix

@Mikaela Added your request to the PR.

This PR should be submit to Homebrew.  See CONTRIBUTING.md for more details on where PR should send to?

@xu-cheng This typo was already corrected in homebrew/Homebrew.

If that's the case, it will be merged into Linuxbrew within a week.


Password field within HTTP runner not set as secret

https://github.com/StackStorm/st2/blob/543edb7777093c85179e5dddd08671c31e788560/contrib/runners/http_runner/http_runner/runner.yaml#L24-L26
Password field within HTTP runner not set as secret field leaving password recorded in plain text.

Thanks for reporting this, will open a fix.

Resolved by #4245.
Thanks again for reporting this.


test(typings): simplify .d.ts file testing

Closes #178

:tada: This PR is included in version 2.3.1 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


STYLE: Remove 9 no-op dynamic_casts (casting T* to T*)

Removed nine "no-op" dynamic_casts that just cast pointers to their own
compile-time type.
Note: in those cases where auto was used to declare a variable
initialized by such a no-op dynamic_cast, this commit replaced
auto by the explicitly specified declaration type.

Follow-up to pull request #2360 (which specifically did Modules/Core).


feat(TFD-1513): Add Normalize component

What is the current behavior? (You can also link to an open issue here)
Normalize component doesn't exist.
What is the new behavior?
Normalize component is added to TCOMP.
Please check if the PR fulfills these requirements

[x] The commit message follows Talend standard
[x] Tests for the changes have been added (for bug fixes / features)
[ ] Docs have been added / updated (for bug fixes / features) ?
[ ] The code coverage on new code >75%
[x] The new code does not introduce new technical issues (sonar / eslint)

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build / CI related changes
[ ] Other... Please describe:

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information:

Pull request test result: success :star:

Pull request test result: failure :x:

Pull request test result: success :star:

Pull request test result: success :star:

Pull request test result: success :star:

Pull request test result: success :star:

Pull request test result: success :star:

Pull request test result: failure :x:

Pull request test result: failure :x:

Pull request test result: failure :x:

Pull request test result: failure :x:

Pull request test result: failure :x:

Pull request test result: failure :x:

Pull request test result: failure :x:

Pull request test result: success :star:

Pull request test result: failure :x:

Pull request test result: success :star:

Pull request test result: success :star:

Pull request test result: success :star:

Pull request test result: success :star:

Pull request test result: success :star:

Pull request test result: success :star:

Pull request test result: success :star:

Pull request test result: success :star:

What is the status of this PR ?
there is no label to say if it is being reviewed, or if it can be merged or reword is required.

This PR is currently in test by our QA.
As soon as we have their approval, this is going to be merged.

Pull request test result: success :star:

Pull request test result: success :star:

Pull request test result: failure :x:

Pull request test result: failure :x:

Pull request test result: success :star:


Issue#594 Add tutorial to Chat Activity

@llaske I had to close my last PR #626 on the issue #594 due to some problem . I have done the changes you asked for in this new PR. Please review and suggest changes if required

@Hemansh31 your branch is not updated.This PR also contains commit of another PR.

@sarthak-g could you tell me how to update the branch for both my PRs?

Here's a visualisation of this pull request commit a1c9fff relative to the dev branch;

You will see your branch diverged from dev a few days ago.
At the moment, it is easy to rebase;
git checkout dev
git pull
git checkout chat_Tutorial
git rebase dev
git push

For me using your branch the result looks like;
$ git rebase dev
First, rewinding head to replay your work on top of it...
Applying: Issue#594 Adding tutorial to Chat Activity
Applying: This is my submission of the ChessBoard Task for GSoC 2020. Also, Issue#592
Applying: Issue#594 Commit with changes requested upon review

However, if you've never done rebase or merge conflict resolution before, I suggest taking a backup of your repository first.  If the dev branch moves in a way that conflicts with what you are doing, you'd be forced into managing the conflict in your repository.  This is not enjoyable the first time. :grinning:
For further information, look for documentation in GitHub on keeping a branch up to date or rebasing.  Don't be distracted by discussions about rebasing when merging a pull-request.  Similar sounding concept, but different.

@quozl  I am getting that my branch is already up to date

@quozl What I understand is that I need to keep my branches updated with the remote dev branch and each issue can be commited in a new branch such that each branch has commits regarding that issue only? Is this what we want?

@Hemansh31 Yes we have to do the same. For these PRs you can remove the latest commit by git reset or you can create new PR from a different branch...

Thanks for asking.

@quozl I am getting that my branch is already up to date

This may happen if your origin remote is your own fork on GitHub.  You may benefit from adding the llaske/sugarizer repository as a remote and pull from it instead.

@quozl What I understand is that I need to keep my branches updated with the remote dev branch and each issue can be commited in a new branch such that each branch has commits regarding that issue only? Is this what we want?

It helps.  Yours is an adequate explanation, but is also a simplification.
We have some maintainers as reviewers who find it more effective to solve any problem you've left them rather than demand you do it.  This saves on another communication round-trip.  It depends on the reviewer's time and the urgency of the work being done.
Our Guide for Reviewers allows for "not waste the time of the contributor, by doing anything trivial that otherwise the contributor might have to do.".  As a contributor you should also think like a reviewer, so that what you give them is as close as possible to what they want.


chore: create required database models

Description

Created User, Message, Investor Models
Created Project, Sme, Connection, Investment Models
Added some methods for user authentication to User Model
Optimized the base route unit test
Wrote unit tests for the database models
Added some rules to eslintrc.js configuration

Delivers #5
How Has This Been Tested?

In your terminal, run git clone https://github.com/BuildForSDG/SmeVest-Backend.git
Run cd SmeVest-Backend
Run git fetch origin ch-create-models
Run git checkout origin/ch-create-models
Run yarn install
create a .env file in the root directory then add details as seen in .env-example file
Run yarn run start:dev to start the development server, you should get a response of "Database connection successful" on your terminal
Run yarn run test to run unit tests

Screenshots (if applicable, else remove this line / section)
None
Checklist:

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have added necessary inline code documentation
[x] I have added tests that prove my fix is effective and that this feature works
[x] New and existing unit tests pass locally with my changes

Nice work our TTL


Patch 2

Someone was using this library as an example and was brutally confused because all the nested and hidden logic. Didn't realize it wasnt a clone. Can close the PR because I won't.

what do you mean using as an example, who was doing it?


Idea: Create unity starter repo (template)

What if anyone could just start a new repository from some template, and it would already include a full pipeline. we could use firebase to deploy a webgl build as a CD example.
Let me know what everyone thinks; please add as many ideas as you might have.

Closing this because I think with the new documentation it's just a matter of copying the advanced workflow from this repo.


Expose create/delete cloudhook

Description:
Allow other components to check if a user is logged in to the cloud and to create/delete cloudwebhooks.
Checklist:

[x] The code change is tested and works locally.
[x] Local tests pass with tox. Your PR cannot be merged unless tests pass
[x] There is no commented out code in this PR.

If the code does not interact with devices:

[x] Tests have been added to verify that the new code works.

Rolled back a few changes, cleaned it up, added some more tests.


K8SSAND-995 Mgmt api heap

What this PR does:

Make the management API heap size configurable via a field in the K8ssandraCluster.
Add error handling for cases where StorageConfig or CassandraConfig are not defined in a DatacenterConfig. (These conditions previously caused a runtime panic).
Add unit tests for all of the above.
Add new test function to get a minimal Cassandra DatacenterConfig.

Which issue(s) this PR fixes:
Fixes #212.
Checklist

[ ] Changes manually tested
[x] Automated Tests added/updated
[x] Documentation added/updated
[x] CHANGELOG.md updated (not required for documentation PRs)
[x] CLA Signed:  DataStax CLA

Changes made:

Use resource.Quantity for management API heap size.
Add MgmtAPIHeap to CassandraClusterTemplate.
Removed a comment John objects to.

Will not fix:

Changes to config variable naming.
Moving MgmtAPIHeap from CassandraDatacenterTemplate to a lower level.


set up fire pipeline for animation

Some feedback for the pipeline as it currently exists. I know this is a work in progress, so my focus here are items to address to have the pipeline run smoothly and set it up for animation.

[x] add a .placeholder file in 1_fetch/in/ so the file structure exists to run the pipeline
[x] in _targets.R add a comment that provides the source of the F2F data
[x] move fire perimeter processing steps to your 2_process. If the pipeline gets more complicated, I would consider splitting your fetch, process and viz targets to have their own targets scripts as well.

To set this up for animation, I'd like you to rework your 2_process and 3_visualize steps so that they use branching. The goal is to structure the pipeline so that if creates individual frames that reflect each step in the animation. What you have done already creates frames like this, so the change needed is to leverage branching so each frame is tracked within the pipeline instead of using a for loop within your iterate_map_years function.
An example pipeline that does that can be seen here https://github.com/USGS-VIZLAB/lake-temp-timeseries/blob/77d06c4e2f21b36b7e8619c84108f0a842d03e30/_targets.R#L50-L59
In that target, I am calling the plot_lake_temp function that prints a single map frame for a given date. I provided pattern = map(temp_daily, date_df) which is telling it to run this function for each row of date_df (which contains the date for each frame) and each data frame in temp_daily (which contains processed data shown on the map for each day).
For your chart and map, I would expect this to be something like pattern = map(years) where years is a list of the years of interest for the animation. This can then be used as an input to your function, like build_map(year), and will return a single year that will plug in nicely to the function you already wrote that filters fire_pts by year. The first step will be to set up the 2_process steps to use branching. Let's touch base after you have done that.
Steps:

[x] address minor comments above
[x] Create a new target years that is a list of all the years of interest
[x] Rework 2_process chart_data target to use branching, where pattern = map(years) to apply across each year
[x] Rework 2_process map_data target to use branching, where pattern = map(years) to apply across each year
[ ] Submit PR with new processing steps, don't worry about 3_visualize not working at this time. Provide information in the PR that details the changes you made, and which targets should be run to review the changes. Assign Cee as reviewer

Nice job. Next, we want to use dynamic branching to create the frames of your gif and animate with magick. I really like what you did with gganimate for the chart animation, and the interpolation is definitely the best part of that package, but I think it may be a challenge to get your two components to align using 2 different animation mechanisms. To keep things simpler animation-wise, let's use the frame + magick approach for both the chart and the map.
The next steps will be to adapt your targets in 3_visualize to use dynamic branching. Rework what you have so that for both the chart and map uses your Years target as the branching pattern to create the frames for individual years. Since we want the chart and map to be in the same gif, you should also add an additional target that takes the chart and map frames and composes them into a single visual and saves as a png.
There is an example here that does that using cowplot and grid: https://github.com/USGS-VIZLAB/flow-tiles/blob/5dcff2964061e0c014e237ecba8b7ef06be2b751/src/plot_cartogram.R#L137-L254 This example combines the national tile and the tile map to a single canvas, and adds the USGS logo, a title, some text, etc. When I do this I find it easier to add all the text in this final stage, because then I have more control on the positioning and sizing without having to go back and edit the chart elements themselves. There is a major efficiency benefit to keep the map and chart targets separate from this composition step because data-intensive maps can take a while to generate with ggplot. This way you can refine the final appearance without redoing those targets.
Send me the PR when you've got the pipeline set up to

[ ] use branching to create frames and
[ ] the targets export pngs for each frame.


Add data attributes to attachment links using JS

What

Sets the GA4 data attributes for attachment links via JavaScript, instead of setting them directly on the attachment links' HTML.
Why

Initially we were going to set our GA4 data attributes directly on each attachment links' HTML - as shown in https://github.com/alphagov/whitehall/pull/7481. However, as the HTML lives in whitehall, deploying the new HTML to our servers requires us to republish 45k+ documents which takes a bit of time.
This could become an issue if we constantly need to make changes to the data attributes, as we'd need to republish 45k documents every time. It also feels a bit like technical debt to implement something that would require 45k republishes to update.
Therefore, in whitehall we are going to set an attribute called data-ga4-attachment-links on the HTML of each attachment link once. Then, we can add the actual data attributes using JS by grabbing every instance of data-ga4-attachment-link. This will stop us having to republish 45k+ documents if the GA4 attributes ever need changing/updating. With this technique, we will only need to do the 45k+ republish once, just to add the tag data-ga4-attachment-link on everything.
I put the function call in init-ga4.js as it needs to run before the ga4-link-tracker module runs, otherwise the module wouldn't get initialised on the HTML if data-module='ga4-link-tracker' was added to each link after the tracker was initialised.
Testing
The JS tests should demonstrate that it works, however if you want to see it for yourself:

Run static locally with a local version of govuk_publishing_components
Run government-frontend, pointing to your local static
Go to init-ga4.js in govuk_publishing_components and on line 15 change the CSS selector we're using from [data-ga4-attachment-link] to section.attachment.embedded.
If you go to http://<IP_ADDRESS>:3090/government/publications/equality-act-guidance you will see that every attachment link has the GA4 link attributes - this is because they are section elements with the classes attachment embedded, so our GA4 code has added the attributes to every element matching section.attachment.embedded. Of course in our real solution we are going to be adding a GA4 specific selector [data-ga4-attachment-link] to the links we need via whitehall.

Visual Changes
None.
Before
After

Thanks @JamesCGDS - I've made the requested changes.


Added an option to disable validation in sample server.

This still defaults to true if unspecified, but provides an option to
use PositiveValidator for scenarios where we want to skip validation.

#135  👈
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @mhrheaume and the rest of your teammates on  Graphite

Merge activity

Nov 6, 7:58 PM EST: A user merged this pull request with Graphite.


[Bug] Cant store relationship (select 1-n) in 5.0.2 free version

Bug report
What I did
Add "select" field to create and update operation()
What I expected to happen
I can save the data
What happened
I cant save the data
What I've already tried to fix it
Testing all addField([ // settings])
Is it a bug in the latest version of Backpack?
yes 5.0.2
Backpack, Laravel, PHP, DB version
PHP VERSION:
PHP 8.1.2 (cli) (built: Jan 26 2022 16:40:42) (NTS)
Copyright (c) The PHP Group
Zend Engine v4.1.2, Copyright (c) Zend Technologies
LARAVEL VERSION:
v9.0.1@afeb58d019b203ecb1a1c4063a66a029ea6bea63
BACKPACK VERSION:
5.0.2@a118a414770e6719732c7629f939d4f9337f5433
Soooo,
My relationship in Rescuer Model:
return $this->hasOne(RescuerType::class, 'id', 'rescuer_type_id');
(Worked in laravel only)
Settings to the field:
$this->crud->addField([
            'label' => 'Typ',
            'type' => 'select',
            'name' => 'rescuer_type_id',
            'entity' => 'rescuerType'
        ]);

What i got i try to save a new or an updated rescuer:
Call to undefined method App\Models\Rescuer::rescuer_type_id()
So, i ment out, that he try to use the "name" as the relation-ship function in Rescuer.
But the docs says:
[  // Select
   'label'     => "Category",
   'type'      => 'select',
   'name'      => 'category_id', // the db column for the foreign key

   // optional
   // 'entity' should point to the method that defines the relationship in your Model
   // defining entity will make Backpack guess 'model' and 'attribute'
   'entity'    => 'category',

   // optional - manually specify the related model and attribute
   'model'     => "App\Models\Category", // related model
   'attribute' => 'name', // foreign key attribute that is shown to user

   // optional - force the related options to be a custom query, instead of all();
   'options'   => (function ($query) {
        return $query->orderBy('name', 'ASC')->where('depth', 1)->get();
    }), //  you can use this to filter the results show in the select
]

So, name should be the foreignkey. And entoty should be the relation-ship model.
if i just use this settings:
$this->crud->addField([
            'label' => 'Typ',
            'type' => 'select',
            'name' => 'rescuerType',
        ]);

(Caus u think well, than i just use the relationship function.) i got:
array_key_exists(): Argument #2 ($array) must be of type array, string given
File: vendor/backpack/crud/src/app/Library/CrudPanel/Traits/FakeFields.php:59
In Backpack version 4.1 i works well.. anybody got an idea?
Edit: I forgot, the form works well. i got an selection-box with the correct relation-ship values from the RescuerType table. Only on store the data, i got the error

Hello @busaku
I don't think this is making sense to me. The relation you show is hasOne (1-1) and like the field says, it should be used in a BelongsTo (1-n).
So if you have rescuer_type_id in your Rescuer model, you sould be using:
public function rescuerType() {
    return $this->belongsTo(RescuerType::class, 'rescuer_type_id');
}

Let me know if that relation was the problem.
Pedro

Hey @pxpm
so.. it works. but now it doesnt make sense to me :D
but thank you ;)
paD


Moved applyProps/applyDefaultProps to prototype under each class instead

Description:
This PR moves applyProps and applyDefaultProps to each specific class. Why I've done this is because I would easily inject to make custom setValue. I've also replace the broken eventHandlers features (https://github.com/inlet/react-pixi/issues/185).
I've also updated all tests but I haven't run it on a actual project to see if it works...
I've added DisplayObject.getReactEventHandlers() and DisplayObject.setReactEventHandlers(['click']). This can be used for optimization to only include the events you use. So it doesn't need to iterate over unused events.

This is a big one, we've to test it thoroughly before merging it

Fixed all conflicts and fixed all requested changes.
It would be good if someone could review this.

Hi @EloB I'll review this PR somewhere next week, busy on another project atm.
Thanks for the collab!

Hi @EloB,
This PR (along with the issue) is open for while now, and in all honestly I've been thinking about it and I'd like to keep the logic as it is. Somehow it doesn't feel right to add the applyProps on each class/component and to monkey patch PIXI.
If you'd like to set custom PIXI values you can always use the imperative way (by using ref) and assign the values.
Anyway, I really appreciate all the effort. Thanks! 🙏

I don’t agree with you. So making a plug-in to pixi is just a monkey patching? When you make plugins to pixi this is the way todo it.

Making a plug-in that mutates the lib itself (for instance by changing PIXI’s DisplayObject.prototype) feels not right, that’s what I meant by monkey-patching.
What was the reason again why you want to override the setValue?
If we could create a more uniform way of enabling this behavior along with the events I’m all ears.

Have you seen a plugin that haven’t mutated the library? Have you looked at official plugins how they are built?

The setValue thing is used for animation react-spring to set values for color/tint things.

Have you seen a plugin that haven’t mutated the library?

Maybe, but that doesn't mean it's elegant. I rather keep ReactPixi pure and compositing around PIXI instead of changing it.

Have you looked at official plugins how they are built?

I don't see ReactPixi as a plugin, but more as a React interface for PIXI. Although this difference might be arguable.

The setValue thing is used for animation react-spring to set values for color/tint things so it support “native” springs.

I see, but wouldn't it be better to have a wrapper that handles that? The tint option in PIXI always requires a number (not an Array). I would love to find a way to make this possible without mutating PIXI. The ReactPixi's setValue belongs to the internal behaviour of this lib and should not be exposed as the logic might change in the future.
Anyhow, I really do appreciate all the help!
I'm super busy at the moment, but if you're interested I'd love to collab on this together and see if we can make some kind of util out of it that support this, rough idea:
import { animated, useSpring } from 'react-spring';
import { utils, Sprite } from '@inlet/react-pixi';

const AnimationSprite = utils.native(Sprite);

const MyComponent = ({ tint }) => (
  <AnimatedSprite texture={Texture.WHITE} tint={tint} />
);

@inlet I put down a lot of hours into this feature and it was put to hold then I updated all review requests and then it was declined. I only have 7 days left at my client where I need this thing. I would not have time to update this. I'm sorry :(

@EloB I’m sorry to hear that, I wish I had more time to review this PR sooner. I feel somehow bad about this as you put time and effort into this.
Again sorry! And I really appreciate all the great work you’ve done!

Hi @EloB,
Just to give you a heads up, I've been working on the react-spring implementation and it works like a charm now 🙌
I reckon something with animating tint values, this is also working, here's a demo:
https://codepen.io/inlet/pen/jOrpLOR
Thanks!


ANC Photo activity should be optional [1h]

Issue
The photo activity should be optional in all ANC encounters
Task

remove required validation on photo activity

@adamhstewart
Photo activity was optional from the beginning. Where did you see it as required?

@anvmn Rechecked - it is indeed optional .


Character Sheet Talents Populating Incorrectly

I'm having an issue with my talents page populating incorrectly after I close and reopen my character sheet. The talents on the left is what it should be, but if I close my sheet and reopen it, I get the talent list on the right. Some of it is correct, but it's duplicating some and replacing others.

I have turned off all modules and the problem still occurred. Ticking and unticking a talent in the talent tree fixes the list. Otherwise reloading foundry fixes the list.

Don't have a fix yet, but this merge seems to be causing this
https://github.com/StarWarsFoundryVTT/StarWarsFFG/blob/0a1522ad6453c75733ded2c7e73d5975de5e47cc/modules/actors/actor-sheet-ffg.js#L1369
Removing this line fixes the symptom, but also deactivates the talent information updates. Need to investigate further to propose a fix.


Allow any BLEADDR-esses

Answers checklist.

[X] I have read the documentation ESP-AT Programming Guide and the issue is not addressed there.
[X] I have used the latest released firmware or have updated my ESP-AT branch (master or release) to the latest version and checked that the issue is present there.
[X] I have searched the issue tracker for a similar issue and not found a similar issue.

General issue report
Setting this address is ineffective, it still advertises using the original (AT+BLEADDR?) address.
AT+RST
OK
ready

 AT+GMR  // first to debug
    AT version:<IP_ADDRESS>(4c6eb5e - ESP32 - May 20 2022 03:11:58)
    SDK version:qa-test-v4.3.3-20220423
    compile time(5641e0a):May 20 2022 11:12:05
    Bin version:2.4.0(WROOM-32)
    OK

AT+BLEINIT=2
    OK

AT+BLEADDR=1,"d9:2c:b0:e1:26:19"
    OK

AT+BLEADDR?
    +BLEADDR:"3c:e9:0e:86:8e:xx"    // ineffective??
    OK

AT+BLEADVSTART
    OK

Still advertises with original address (3c:e9:0e:86:8e)
even when I try to set example from user manual
AT+BLEADDR=1,"f8:7f:24:87:1c:7b"
Also there shouldn't be MSB bit restriction, only full 0, 255 restriction.

@Luxin812 PTAL

@mrx23dot Maybe you can try to set the <own_addr_type> parameter of AT+BLEADVPARAM command to 1, you can refer to the following example:

The address queried by the AT+BLEADDR command in ESP32 AT is always the <BLE_public_addr> address, you can check the [AT+BLEADDR command introduction](https://docs.espressif.com/projects/esp

-at/en/latest/esp32/AT_Command_Set/BLE_AT_Commands.html#id1)

If the two parameters "1,"12:34:45:78:66:88"" are not used, they can be omitted directly, as long as the <own_addr_type> parameter in the AT+BLEADVPARAM command and the <addr_type> in the AT+BLEADDR command are guaranteed The parameters are the same.
I use the above sample test here, it works normally, is your mobile phone location turned on? If it is convenient, can you take a screenshot to see the nrf screen of your mobile phone and provide your mobile phone model?


Slider changes direction on RotoContentChenge trigger

Hello,
I've resumed my little project width your rotoslider, but now i've found a error that I've never seen before.
When I trigger the rotocontentchage the vertical slider, becomes horizontal.
An example can be seen here:
http://jsfiddle.net/eLj3a/1/
just click on the first line and the slider just reorients himself.
Am I doing something wrong?

 Sorry for that.
That way I was initialising another roto slider width the default settings...
Thanks


Deprecate WithTermination in favor of clearer WithEdgeTermination and WithCustomEdgeTermination

Resolves #86
We'll probably want to add a WithAgentTermination as well, but that
will be a little more involved, and may fit into the built-in connection
forwarding better.

Current dependencies on/for this PR:

main

PR #88   👈

This comment was auto-generated by Graphite.

cc @russorat and/or @inconshreveable for API opinions

don't love it. why not WithTLSTermination(... TLSTerminationOption) changing to take two functional options:

one that disables it (because it's on by default) (e.g. WithTLSTerminationDisabled)
a second that let's the caller specify a cert/key to ship to use for termination (WithTLSTermationCertKeyPair)

@inconshreveable I'm not sure I see the benefit of having another layer of functional option wrapping over letting those options simply being top-level TLS options.
also:

one that disables it (because it's on by default) (e.g. WithTLSTerminationDisabled)

No it's not - by default we pass the TLS handshake down to the agent.
There are three termination scenarios for TLS endpoints:

No termination - agent receives the TLS stream from the client verbatim. Either the agent or backed has to terminate it. (the default)
Edge termination with user-provided certificates. This is the only one we advertised support for.
Edge termination with ngrok-provided certificates. This one was possible "by accident" if the user passes empty slices to the existing WithTermination function.

Indeed, the ngrok agent's default is not what I expected. even so, it feels like we're configuring a single behavior and these are configuration knobs you can twiddle within that larger behavior. projecting out a fuller api to explain why it should be constructed like this, i'd propose this is a reasonable future state which supports the proposed design:
WithTLSTermination(
  WithTLSTerminationEnabled(true|false),
  // we could support this in the library
  WithTLSTerminationAt(Edge|Agent),
  // eventually if we wanted this kind of configurability, these three below could be collapsed to `WithTLSConfig(*tls.Config)`
  WithTLSTerminationCertKeyPair(cert, key []byte),
  WithTLSTerminationMinimumVersion(int),
  WithTLSTerminationCipherSuites(...CipherSuite),
)

thoughts?

@inconshreveable Going through my backlog, realized I forgot this was in flight.
Updated to be more in-line with your proposed interface.


Add support for certbot 2.x

See https://github.com/certbot/certbot/wiki/Certbot-v2.x-Plugin-Compatibility

For anyone landing here when trying to use certbot-s3front and facing the following error (as reported on #55): unrecognized arguments: --certbot-s3front:auth-s3-bucket, here is one way work around it waiting this issue to be closed:
> virtualenv venv
> source venv/bin/activate
> pip install certbot===1.32.0
> pip install acme===1.32.0
> pip install certbot-s3front

# then as mentioned on the README.md
>  AWS_ACCESS_KEY_ID="REPLACE_WITH_YOUR_KEY" \
AWS_SECRET_ACCESS_KEY="REPLACE_WITH_YOUR_SECRET" \
certbot --agree-tos -a certbot-s3front:auth \
--certbot-s3front:auth-s3-bucket REPLACE_WITH_YOUR_BUCKET_NAME \
[ --certbot-s3front:auth-s3-region your-bucket-region-name ] #(the default is us-east-1, unless you want to set it to something else, you can delete this line) \
[ --certbot-s3front:auth-s3-directory your-bucket-directory ] # (default is "") \
-i certbot-s3front:installer \
--certbot-s3front:installer-cf-distribution-id REPLACE_WITH_YOUR_CF_DISTRIBUTION_ID \
-d REPLACE_WITH_YOUR_DOMAIN


K8S Operator yaml file broken! - jaegertracing_v1_jaeger_crd

this link on this page return 404.
please change it to this link: https://raw.githubusercontent.com/jaegertracing/jaeger-operator/master/deploy/crds/jaegertracing.io_jaegers_crd.yaml

Thanks for reporting this issue - I am going to move it to the doc repo.


Ability to disable intermediate file generation

The changes are implemented in commit a6f4cb8. A workspace setting was included to disable code generation. Use "vua.generation.disable"


Improve support for full history servers

Summary
Recent issues related to the size and maintenance of sqlite databases (#5102 and #5095) highlight infrastructure challenges for users that operate full history servers.
Solution
This issue does not propose a solution, but is meant as a spot for ongoing discussion of requirements and corresponding solutions, continuing the conversation that had started in #5102.

Some pain points off the top of my head:

SQLite databases growing to several TiB in size (especially transactions.db)
NuDB files are already growing beyond 16 TiB (makes it hard to use on most file systems)
Hard to bootstrap a new full history server in a trustless way (beyond "here, just take this database and use it - if you're worried just run https://xrpl.org/docs/references/http-websocket-apis/admin-api-methods/logging-and-data-management-methods/ledger_cleaner for a few weeks/months or so becauser --import does no validation"), no public full history dumps are available, not even ones for certain ledger ranges
Impossible(?) to have instances only responsible for certain ledger ranges (e.g. run a server that only serves data for ledgers 32.570-10.000.000 and later merge results if a query comes in) to be able to distribute load - "full history" always means "full history on a single machine" not "full history available within a cluster of machines"
Node database has to be local, very fast for random reads and can't be shared between instances afaik
The only actually useful database backend for node.db is NuDB (https://github.com/cppalliance/NuDB) - written a few years ago and with no real command line tools, other clients in various languages to access data, any community around it to speak of and 1 single commit fixing some includes in the past 3 years. When I asked about some corner case almost a decade ago, there was not much help from the author (https://github.com/cppalliance/NuDB/issues/46).

I'm not sure if it is usable for full history servers, I ran into issues with it years ago, switched to NuDB and never looked back tbh.
In general it would help somewhat, if it were indeed a viable option, yes.

Since it is (too) easy to criticize, here are some potential solutions for the points I brought up:

Split transaction.db and ledger.db files by ledger height (e.g. every million or 10 million ledgers?) into their own file. SQLite can handle really big database files, but this current state seems like it is getting into edge-case territory already.
node.db files similarly should be split by ledger height (this is what shards did). There will be some duplication of rarely changing inner and leaf nodes across these files, but that's a rather trivial overhead imho.
Shards were also designed partially to solve this issue. I'm not 100% sure if they ended up being created deterministically, but I know that they at least can be created that way. This would enable stable P2P distribution (e.g. BitTorrent, IPFS) and out-of-band verification of such database files (technically a ledger hash from a trusted source is enough to verify the full contents of a shard cryptographically).
This one seems more difficult, but maybe with standalone mode this might already be possible? I didn't look too much into horizontal scaling of rippled clusters (probably connected through some middleware that does the actual request parsing and routing, like for xrplcluster). Might be more of a documentation and middleware issue and a case of "well, you just need to do it this way".
I would maaaaybe propose an option of querying a (local) caching server for K/V pairs such as memcached, before actually hitting any database because it might be easier to share something readonly/read-through between several running instances that way. I/O wise however a lot of operations just seem to require huge amounts and I'm not sure if even a local network (even a virtual one in the case of several instances running on the same machine) would help in that regard. Full history servers especially more likely get requests for stuff that is no longer in the "hot zone" so to speak. Another option might be to try out a fully networked K/V store for node data. Then again: Is network I/O really fast enough if disk I/O already struggles? OTOH databases are generally filled with magic pixie dust, might at least be worth a try to store transactions, ledgers, wallet/config and nodes in Postgres and run some benchmarks.
Similar to above, no idea if RocksDB is even as performant as this very bare-bones implementation of an algorithm, but at least there's a bit of an ecosystem around it. OTOH it would likely make it much harder to deterministically create ledger dump files to be distributed.

Coming in cold after a few years away from rippled development ..

#5066 has some discussions on the challenges in supporting shards. Referencing here as we consider any additional strategies.
I do recall the concerns on deterministic shards and agree that should be achievable and important to enable out-of-band verification and benefit from those other distribution methods.
I also understood that clio was in part meant to solve the storage/sharding challenges that FH servers face, in addition to better performance for reporting use cases.  It also appears to have mixed adoption there. Due to the cold start challenge of getting data. Due to the need of operating additional data backends? Understanding those challenges/gaps would be helpful too.

I still see History Sharding from this link. Is it the same thing removed in https://github.com/XRPLF/rippled/pull/5066 🤔 ?
Clio 's full history node uses less than 7TB data storage and maintains more off-chain indexes. But FH Clio needs another full history rippled and months of time to setup 🥲 .

I still see History Sharding from this link. Is it the same thing removed in #5066 🤔 ?

Yes. It wasn't working very well and added fair amount of complexity, so we decided to remove it.


Can we start tour with new set of steps and is there a possiblity of it getting conflicted with previous steps

this.$tours['myTour'].steps = initialSteps;
but later i would like to change the steps, then will the following work?
this.$tours['myTour'].steps = newSteps;
Help needed

Solved this by having steps as computed property


Trying to run on EC2 instance.

Hi, we are trying to run HarmBench on EC2 instance, and we are having issues in setting up slurm, can you share your slurm.conf file and some insights on how we could setup slurm.

Hi @ArmaanSeth , you can run a job using the .py on a local mode instead of slurm. What's your current cmd?

I am working on ubuntu and am trying to run for llama2-7b, can you tell me the gpu requirements to run the benchmarks. So I can use that as an reference.

Hi @ArmaanSeth , we have an example GCG notebook so that you can quickly test GCG on your side.
For the method, what objective are you trying to solve in choosing the method?

I am trying to run all the 3 steps, I have got the slurm working but each sbatch job is loading the llama model in memory resulting in CUDA out of memory error.

Hi @ArmaanSeth,
Our hyperparameters were set using 80GB A100 GPUs, so GPUs with less memory may require increased parallelism to load models. In configs/model_configs/models.yaml, you can set the number of GPUs required to load each model. The models are partitioned across GPUs using device_map='auto' in the load_model_and_tokenizer function.


Revamp Chatbot Prototype

Description
Revamps the NIBE prototype to use latest Langchain. Also separates responsibilities:

asf_hp_installer_chatbot: experimentation of data heavy pipelines, with associated utils
rag: all things end-to-end RAG Langchain related, this includes document processing pipelines
api: uses Langserve, a FastAPI wrapper. This enables more ways to interact with the chains throughout dev, test, and prod.

Note: WhatsApp interface hasn't been implemented, and this PR will be updated to reflect these changes. The aim of this PR is to first revamp the prototype to use the latest Langchain LCEL framework.
Addresses #6 , branch is 2_revamp
Instructions for Reviewer
Contact me for Langfuse integration details (env vars needed in your .env file)

Checkout branch 2_revamp
Run make pip-install if you already have the project conda environment setup
Test the integration test script that mimics the prototype test script:

python rag/tests/test_retrieval.py

To test the API:

Have poetry installed, feel free to ask me how best to do this
conda deactivate, then cd api
poetry env use 3.10, then poetry install
langchain app serve --app app.server:app
Navigate to <IP_ADDRESS>:8000
Test out the /invoke endpoint by replacing the string in the JSON request "input": "string", with a query.

Please pay special attention to and other notes

Setting up, feel free to ask me questions
I'm still rethinking/ implementing the WhatsApp interface and the messaging system, will be best to not serialise the files but to log conversations to a message queuing system i.e. Redis. Then periodically send incremental batches to an S3 parquet file.

Checklist:

[x] I have refactored my code out from notebooks/ N/A
[x] I have checked the code runs
[x] I have tested the code
[x] I have run pre-commit and addressed any issues not automatically fixed
[x] I have merged any new changes from dev
[x] I have documented the code

[x] Major functions have docstrings
[x] Appropriate information has been added to READMEs

[x] I have explained this PR above
[x] I have requested a code review

Other additional features to review:

[x] Add CLI for running ingestion and reindexing of docs into vector database
[ ] Add CLI command for saving vector database snapshots to local and desired S3 path
[ ] Add CLI command for recreating an index from snapshot saved locally or in S3 path

Review instructions, after make install or make pip-install, test out CLI commands with chatbot --help, there are descriptions for other commands available.

Description
Revamps the NIBE prototype to use latest Langchain. Also separates responsibilities:

asf_hp_installer_chatbot: experimentation of data heavy pipelines, with associated utils
rag: all things end-to-end RAG Langchain related, this includes document processing pipelines
api: uses Langserve, a FastAPI wrapper. This enables more ways to interact with the chains throughout dev, test, and prod.

Note: WhatsApp interface hasn't been implemented, and this PR will be updated to reflect these changes. The aim of this PR is to first revamp the prototype to use the latest Langchain LCEL framework.
Addresses #6 , branch is 2_revamp
Instructions for Reviewer
Contact me for Langfuse integration details (env vars needed in your .env file)

Checkout branch 2_revamp
Run make pip-install if you already have the project conda environment setup
Test the integration test script that mimics the prototype test script:

python rag/tests/test_retrieval.py

To test the API:

Have poetry installed, feel free to ask me how best to do this
conda deactivate, then cd api
poetry env use 3.10, then poetry install
langchain app serve --app app.server:app
Navigate to <IP_ADDRESS>:8000
Test out the /invoke endpoint by replacing the string in the JSON request "input": "string", with a query.

Please pay special attention to and other notes

Setting up, feel free to ask me questions
I'm still rethinking/ implementing the WhatsApp interface and the messaging system, will be best to not serialise the files but to log conversations to a message queuing system i.e. Redis. Then periodically send incremental batches to an S3 parquet file.

Checklist:

[x]  I have refactored my code out from notebooks/ N/A

[x]  I have checked the code runs

[x]  I have tested the code

[x]  I have run pre-commit and addressed any issues not automatically fixed

[x]  I have merged any new changes from dev

[x]  I have documented the code

[x]  Major functions have docstrings
[x]  Appropriate information has been added to READMEs

[x]  I have explained this PR above

[x]  I have requested a code review

Other additional features to review:

[x]  Add CLI for running ingestion and reindexing of docs into vector database
[ ]  Add CLI command for saving vector database snapshots to local and desired S3 path
[ ]  Add CLI command for recreating an index from snapshot saved locally or in S3 path

Review instructions, after make install or make pip-install, test out CLI commands with chatbot --help, there are descriptions for other commands available.

Hi Solomon!
Thanks for the really comprehensive work, I am loving the configurability of the chatbot and think this enables us to have a lot of flexibility in terms of what we are able to do. The change to FastAPI from Flask makes sense especially when it comes to asynchronous nature/potential of chatbots and also love the FastAPI documentation that comes with it.
I was able to eventually get both the test script up and running and then also run the API with a local Qdrant vector database, so that's good. Ran into a couple of bugs which I've commented on and we've discussed (there have been quite a few changes since this PR was put out so that's unsurprising). It would be great to know what the steps are to deploy the chatbot on the EC2 instance, this is potentially we can discuss at some point in the coming weeks. I think it might be useful @Jack-Vines  to review the API part of this PR as myself and @crispy-wonton do not have much experience with these packages or how they set up.
As a more general comment, I think we are missing some documentation at the top of each file, i.e. a clear message which is readable for those who either have no or some experience with either web applications or RAG pipelines and I think potentially some visual representations would really help us understand the functionality of the different files and the architecture overall. I am happy to help out with this!
I think as a whole, we also need documentation on how to set everything up from poetry, to LangFuse and of course with regards to running an EC2 instance! It doesn't seem trivial, at least to a beginner like myself, so I think this would be super helpful.
Thanks again for the stellar work!


[1.11.x] Bump KIE 7.59.0.Final

Many thanks for submitting your Pull Request :heart:!
Please make sure that your PR meets the following requirements:

[ ] You have read the contributors guide
[ ] Your code is properly formatted according to this configuration
[ ] Pull Request title is properly formatted: KOGITO-XYZ Subject
[ ] Pull Request title contains the target branch if not targeting main: [0.9.x] KOGITO-XYZ Subject
[ ] Pull Request contains link to the JIRA issue
[ ] Pull Request contains link to any dependent or related Pull Request
[ ] Pull Request contains description of the issue
[ ] Pull Request does not include fixes for issues other than the main ticket

How to retest this PR or trigger a specific build:

Run all builds
Please add comment: Jenkins retest this

Run (or rerun) specific test(s)
Please add comment: Jenkins (re)run [runtimes|optaplanner|apps|examples] tests

Quarkus LTS checks
Please add comment: Jenkins run LTS

Run (or rerun) LTS specific test(s)
Please add comment: Jenkins (re)run [runtimes|optaplanner|apps|examples] LTS

Native checks
Please add comment: Jenkins run native

Run (or rerun) native specific test(s)
Please add comment: Jenkins (re)run [runtimes|optaplanner|apps|examples] native

Full Kogito testing (with cloud images and operator BDD testing)
Please add comment: Jenkins run BDD
This check should be used only if a big change is done as it takes time to run, need resources and one full BDD tests check can be done at a time ...

The (build) Runtimes check has failed. Please check the logs.

class org.drools.core.common.DefaultFactHandle cannot be cast to class org.drools.core.kogito.factory.KogitoInternalFactHandle

@mariofusco @lucamolteni some recent change?

The (build) Examples check has failed. Please check the logs.

The (build) Apps check has failed. Please check the logs.

Kogito was implicitly rely on a bug now solved in Drools. This fix also requires a small change in Kogito codebase.
Replaced by https://github.com/kiegroup/kogito-runtimes/pull/1570


feat(alert-dialog): change position to bottom

New position for the alert-dialog. For mobile users, it's better to dislpay alerts at the bottom of the navigator, so the thumb can easily press the desired button for the action. At the moment, the alert dialog renders a centered dialog, instead of at the bottom.
Preview of the change

@byeze I believe https://ui.shadcn.com/docs/components/drawer#examples already achieves this functionality by rendering either a Drawer component or a Dialog component based on the viewport width.


refactors unit tests

Description
refactors the functional and unit tests
Types of changes
fixes #133
Checklist:

[x] My code follows the code style of this project.
[x] All new and existing tests passed.

@wmhilton what do you think about this?

yayyyy @wmhilton we have a green build (https://node-coverage-server.herokuapp.com/coverage/github.com/local-npm/local-npm) I added a shutdown function so that we are not only looking for a siginit to be sent to the process. This was causing issues with travis, when travis got a siginit it just failed the build. IMO it seemed pretty hacky anyway.

going to merge and keep moving forward with the refactor 🎉


Some symbols packages aren't making it to Nuget

Getting this from Nuget on publishing:

The symbol package JsonPath.Net 0.1.1 failed validation because of the following reason(s):

The uploaded symbols package contains pdb(s) for a corresponding dll(s) not found in the nuget package.

Your symbol package was not published on NuGet Gallery and is not available for consumption.
You can reupload your symbol package once you've fixed the issue with it.

Doesn't occur with all packages.  For example, the schema package seems to be fine.

Looks like everything is set up now. (#45 resolved this)


Use Hatch environments

The requirement files remain (for now) because the CI pipeline is still configured to use them. Migrating the CI pipeline is the next step.

Codecov Report

Merging #573 (2bdcd95) into main (9d754ca) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #573   +/-   ##
=======================================
  Coverage   97.50%   97.50%
=======================================
  Files           6        6
  Lines         400      400
  Branches       80       80
=======================================
  Hits          390      390
  Misses          8        8
  Partials        2        2


Add helper for checking string being extension ID

Add a small helper for checking whether a string is (purely based on its
format) an extension ID.
The plan is to use this helper in follow-ups in order to distinguish
between extension IDs and generic web origins. Specifically, we're
adding the support of receiving smart card commands from web pages,
which means we'll store two kinds of permissions granted by the user:
ones based on Extension IDs and ones based on web origins; when loading
these persisted permissions, we'll need to determine the kind of every
stored item.
This is a preparatory commit for the effort tracked by #377: supporting
PC/SC requests from web pages.

Thanks!


postgresqlPackages.periods: 1.1 -> 1.2

Motivation for this change
https://github.com/xocolatl/periods/commits
periods 1.2 is required to pg_upgrade from PostgreSQL 12 to 13. periods must be upgraded in each database before pg_upgrade can succeed (otherwise you see this error - ref https://github.com/xocolatl/periods/commit/58e30e5b25d337c0fe4bf8eec193f989c3e42852)
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

I tested an upgrade of periods from 1.1 to 1.2 in PostgreSQL 12 and I tested that PostgreSQL 13 can load periods 1.2.

Result of nixpkgs-review pr 101878 1

1 package built:

postgresqlPackages.periods (postgresql11Packages.periods)

Result of nixpkgs-review pr 101878 1

1 package built:

postgresqlPackages.periods (postgresql11Packages.periods)


Cannot compare commits between releases

I'm the maintainer of the littlefs-fuse in nixpkgs and I don't like to update packages without a changelog, unless I can compare the commit history between releases.
Littlefs-fuse doesn't do either. People really do read look at those things and you don't have them then they come up with their own ungenerous conclusions.

Hmm, is the problem the git subtree merge --squash? You can see the squashed commit history in the commit message, albeit in short form: https://github.com/littlefs-project/littlefs-fuse/commit/985bca0
littlefs-fuse is really just a small wrapper over littlefs, so in a sense the changeset really is just "bumped littlefs dependency".
I can add a link from littlefs-fuse's release notes to littlefs's release notes though, that seems like a good idea.

I've added a link/note to the release notes:
https://github.com/littlefs-project/littlefs-fuse/releases/tag/v2.7.9


Transform Error when function have types (typescript code)

Describe the bug
Transform Error when function have types

Expected behavior
It should have no error
Version
The version of @swc/core: 1.1.20

Can you share your swcrc file?

Closing as automatic typescript detection is implemented.


Finer grained configuration to make index smaller & faster for large sites: by linkTitle, by title, by Headings Level 1 only, and etc.

For large dictionary-like websites, containing terms with definitions, it makes sense to search by main term only and avoid search by sub-headings and content.
For example, searching by linkTitle only, completely avoiding all other parts of an article, will make the search index very small. Could be "expanded" to title, description, Heading Level 1, 2, etc.
Applicable for professional dictionary-like websites and large websites in general.

searching by linkTitle only, completely avoiding all other parts of an article

TBD, but I don't have a proposal yet. Please describe your implementation below if you have any. Since the title is required and this request seems unusual, it will greatly impact the UI, PRs are also welcome.

Could be "expanded" to title, description, Heading Level 1, 2, etc.

Headings and description (summary) make sense.
Btw, if your site is large, it's always recommended to use an online search serviceto save bandwidth, and improve the user experience, the client search need to download the large index.json from your server and index it locally, it really take time and bandwidth, especially to a large site.

Thanks; yes, I plan to integrate with Algolia, didn't have enough time yet... if JS search can index only main title (and ignore subtitles, text) it can make index size at least 10x smaller I hope.
But with Algolia it could be 1000x more powerful: stop-words, synonyms, word stemming, fuzzy search, auto error correction, and etc.; I did it a while ago (not very good UI, but index was Ok) but now I plan to find a way to integrate with hugomods/search.

The linkTitle request will not be approved at this time.
For the other requests, please check the release notes of v0.17.0 and the docs.
If this index is still large, it might be time to move to an online service. The client-side JS implementation is not designed for large websites with millions of content.

Thanks for v0.17.0 with new features; index_heading filter is really great to have even for 100-page sites with a unified page structure; this use case is not specific to large sites.
JS is better than Algolia if we need to index only page titles.


Assert::nullOrStringNotEmpty() with string|null will always evaluate to true

Hello,
public function foo(?string $bar)
{
    Assert::nullOrStringNotEmpty($bar);
}

The above example leads to the following error:
Call to static method Webmozart\Assert\Mixin::nullOrStringNotEmpty() with string|null will always evaluate to true.
The problem is, that it's totally possible for $bar to be an empty string.
Unfortunately I can't provide a playground example, because Webmozart\Assert can't be used there.

I can confirm this with these dependencies:
phpstan/phpstan                             0.12.92            PHPStan - PHP Static Analysis Tooln
phpstan/phpstan-webmozart-assert            0.12.15            PHPStan webmozart/assert extension
webmozart/assert                            1.10.0             Assertions to validate method input/output with nice error messages.

Should be fixed in PHPStan core. Once this is fixed, this starts working automatically as well: https://phpstan.org/r/f23ca7f4-0c82-487a-8858-384e8abad8cd

@herndlm @ondrejmirtes Thank you for fixing this issue! 🙂


Is there a way for an extension to detect DarkMode theme for Visual Studio 2022? We have implemented ToolTips for our extension and we can't find a way to style the ToolTips according to the VS display theme.

Thank you! I'll try these options out


check out pre-py310 examples, make sure the instructions for running them work

Pete said he was getting ModuleNotFoundError, no module named example_utils, and that he had to mess with the logging initialization code before it would run.

I suspect he was running the code as a script python example.py as opposed to a module, which the docs spell out python -m example. This is easy to miss.


Admin

I am sorry about this huge code review. I fixed a lot of merge conflicts and added some tests for parts of the website.

LGTM, thanks