Failed to auto connect to the wallet

Project Name
thirdweb_connect_error
Description
This project is a minimal reproduction of a problem experienced when the provider tries to connect.
https://github.com/CWhits/thirdweb_connect_error
Reproducing the error
Follow these steps to reproduce the error:

Clone the project: git clone https://github.com/CWhits/thirdweb_connect_error
Navigate into the project directory: cd thirdweb_connect_error
Install the dependencies: npm install
Start the project: npm run dev
Make sure no other Chrome window is open.
Open a new Chrome window and navigate to localhost:3000
Connect the wallet and log into MetaMask.
Quit Chrome completely from the system menu.
Launch Chrome again and navigate to localhost:3000
If the button is showing the loading indicator, refresh/reload the page.

At this point, you should see the error.
Error Details
Unhandled Runtime Error
Error: Failed to auto connect to the wallet.
Call Stack
MetaMaskWallet._connect2
<EMAIL_ADDRESS>(141:0)
async eval
<EMAIL_ADDRESS>(538:0)
Environment
Provide any relevant details about the environment where the problem occurs, like:

OS: 13.3.1 (a) (22E772610a)
Node.js version: v18.15.0
npm version: 9.6.3
Chrome version: Version 113.0.5672.92 (Official Build) (x86_64)
MetaMask version: 10.29.0

@CWhits
This is expected - when you close the browser - MetaMask is locked and requires password to unlock, a locked MetaMask can not be auto-connected

Good, but it should not crash the app.

@CWhits It doesn't crash the app - it is just logging out an error

It is crashing in mine.

@CWhits If it is crashing, you can let me what stops working?

Hi @MananTank, were you able to run the sample project that I attached? You should be  experiencing the error being logged in the console, the error overlay and/or the small error window on the bottom left. Have you seen it happen on your side?

The error overlay can be ignored - it's only shown in dev and does not break the app.
To avoid this, we have stopped throwing the error in https://github.com/thirdweb-dev/js/commit/a5e509438dad551f757db55e8300f79bcf523952 and just logging it out instead.

@MananTank the Wallet now stays in a loading state. Update the project to the latest Thirdweb version and perform the same steps as before. You will see it happen. After refreshing then it logs the "Failed to auto connect to the wallet" error.

@CWhits "Failed to auto connect" error log is expected if wallet can not be auto connected. For example if Metamask is locked - wallet will not be auto connected. This does not break the app - user just needs to connect the app again manually

@MananTank the example I included allows you to replicate the issue with the wallet. I don’t think that the Wallet button displaying a loading state helps with the user experience. If you follow the original 10 steps to reproduce you will easily encounter the issue.

That is how the wallet looks after quitting Chrome and coming back again to the app.
The steps to reproduce are exactly the same.

@CWhits So It's stuck on loading state?

@MananTank Here is exactly what I am experiencing. This video was recorded using the latest versions
"@thirdweb-dev/react": "^3.13.0",
"@thirdweb-dev/sdk": "^3.10.20",
https://github.com/thirdweb-dev/js/assets/99901039/ef80c39b-19e6-4ccb-b6bd-e0d1adb2ad94

@CWhits Thanks for this, Can you check if any Network requests are being blocked in Network panel?

@MananTank narrowing down I can see that the issue can arise from the Local Storage. When the button remains in a spinning state the TW/coordinatorStorage/lastConnectedWallet object is {"walletId":"metamask","connectParams":{}}. In this case  if (!walletObj) {...} in line 308 of thirdweb-wallet-provider.tsx will think that you have a valid object and the code will continue until it gets stuck in the try that starts in line 358. Certainly the setConnectionStatus("connecting"); will be triggered but it seems that the code will be stuck in await wallet.autoConnect(walletInfo.connectParams); As I can see you add and remove the TW/coordinatorStorage/lastConnectedWallet when connecting and disconnecting but that key pair could persist when quitting the browser thus the next time the user opens the browser, that key pair could be available and wallet.autoConnect might not return. Hope it helps.

Maybe checking that the lastConnectedWallet exist in Local Storage and then checking if some specific parameter exist as well after checking walletObj and set the setConnectionStatus("disconnected"); if the object or parameter is empty. Not the best thing but maybe can patch this thing for the moment.

I'm facing this issue in mine. What to do, please suggest?

@rashi293 Looks like the error in your case is thrown - Can you update to latest version so that the error is not thrown and just logged

Hello @MananTank any update on this issue?

@CWhits Can you update to latest version of thirdweb packages and check if the issue still persists?

Hey @CWhits
I've added autoconnect timeout in the latest nightly version. So that ConnectWallet button does not remain stuck indefinitely
The default is 15 seconds. If you want to configure the timeout - You can set time in milliseconds in autoConnectTimeout prop in <ThirdwebProvider />
Please use below version to test this:
<EMAIL_ADDRESS><EMAIL_ADDRESS>
Let me know if this fixes the autoconnect stuck on loading state for you

How

exactly to resolve this?

Anyone still facing the issue ?, Any solution ?


Cleanup/1886 cleanup global space in prim tests, replace pull_msg with expect_throw_msg

Summary
This PR advances #1886 with the following:

cleaned up /prim tests files of global using statements
remove the unnecesarry pull_msg functions in the gp_* tests. They can be replaced with EXPECT_THROW_MSG.
puts functions with non-unique names file f, fun, f1 in namespaces (The namespace names are based on the file name)
removed global variables like const char* function_ = "function"; from the global namespace of tests
moved util functions like correct_type_vector in the utils header file
added missing header guards to test utility files (ode mock observers and hmm test utilities)

No release notes as this is part of an ongoing project that is being done over multiple PRs. Will put release notes in the final one.
Tests
/
Side Effects
/
Checklist

[x] Math issue #1886

[x] Copyright holder: Rok Češnovar, Univ. of Ljubljana
The copyright holder is typically you or your assignee, such as a university or company. By submitting this pull request, the copyright holder is agreeing to the license the submitted work under the following licenses:
- Code: BSD 3-clause (https://opensource.org/licenses/BSD-3-Clause)
- Documentation: CC-BY 4.0 (https://creativecommons.org/licenses/by/4.0/)

[x] the basic tests are passing

unit tests pass (to run, use: ./runTests.py test/unit)
header checks pass, (make test-headers)
dependencies checks pass, (make test-math-dependencies)
docs build, (make doxygen)
code passes the built in C++ standards checks (make cpplint)

[x] the code is written in idiomatic C++ and changes are documented in the doxygen

[x] the new changes are tested

Thanks. Done.


Extract message crate

Problem
solana_program::message needs to be pulled out
Summary of Changes

Move to its own crate and re-export with deprecation
Move AddressLookupTableAccount to this crate
Move CompiledInstruction to this crate
Copy ALL_IDS from the sysvar module to avoid a dependency. This code is deprecated anyway so the stuff we are copying should not change.
Inline the NONCED_TX_MARKER_IX_INDEX from solana_nonce to avoid a dependency
Make serde and bincode optional in this crate
Remove thiserror from the new crate
Add doc_auto_cfg

This uses the solana-system-interface crate so that needs to be published before this can be merged (update: solana-system-interface has been published)

Sorry, can you rebase once more to pick up https://github.com/anza-xyz/agave/pull/3774 ?

Need to figure out some doctest dependency issues

Need to figure out some doctest dependency issues

There's another issue with the cargo build-sbf tests -- since they're using a local solana-program without patching the deps for solana-system-interface, the build pulls in two versions of solana-pubkey / solana-instruction / solana-decode-error. I can push up a fix for this if you like

Oh yes please, maybe that's it

I think we're looking good! Tagged @febo for an approval since I can't merge it :upside_down_face:

Looks like there's a missing dependency on wasm-bindgen. But even after fixing that, there's multiply defined symbols for the system instructions between solana-system-interface and sdk/program/src/system_instruction.rs -- we'll need to remove those first and change solana-program to re-export all of those.

Looks like there's a missing dependency on wasm-bindgen. But even after fixing that, there's multiply defined symbols for the system instructions between solana-system-interface and sdk/program/src/system_instruction.rs -- we'll need to remove those first and change solana-program to re-export all of those.

Would you like me do have a look at it?

Would you like me do have a look at it?

Yes please that'd be great, whenever you have a moment


Add support in L1 kernel handle interrupts posted from the IOMMU

The current TDX architecture supports posted interrupts (from Host VMM and IOMMU devices) for TDX L1 VMM (VTL2). For passthrough devices owned by L2 guest (VTL0), Hyper-V does not use posted interrupts. Each HW interrupt from L2 owned device results in a TDEXIT to Hyper-V today. This comes with considerable performance cost.
The L1 kernel uses a single interrupt vector to handle the interrupts of passthrough L2 devices [1]. The L1 kernel relays the interrupt to the L2 guest using a bitfield in which each bit represents an L2 interrupt vector.
To mitigate the described performance cost, the IOMMU can deliver interrupts directly to the L1 kernel using posted-interrupts. Under this scheme, a CPU interrupt vector needs to be assigned to each of the interrupts delived to the L1 kernel.
As stated in [1], the synic is not modeled in Linux as an irq chip or irq domain, and the demultiplexed logical interrupts are not Linux IRQs. This
also implies that interrupt handles cannot be installed using request_irq().
Since each of the posted interrupts needs its own CPU vector, reserved a set of vectors that can be assigned dynamically to L2 guests upon request.*
openvmm userspace can request the assignment using an ioctl
[1]. https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/virt/hyperv/vmbus.rst?h=v6.12#n168
*A more elegant, albeit time-consuming solution would be to implement the synic as an irq_chip or irq_domain leverage the Linux IRQ infrastructure.

@ricardon is this issue still open?

Yes @cperezvargas we are still working on it. Currently it is in a proof-of-concept state and is not ready to be merged.


Fix animated WebP incorrect render when canvasWidth larger than iter …

New Pull Request Checklist

[x] I have read and understood the CONTRIBUTING guide
[x] I have read the Documentation
[x] I have searched for a similar pull request in the project and found none
[x] I have updated this branch with the latest master to avoid conflicts (via merge from master or rebase)
[ ] I have added the required tests to prove the fix/feature I am adding
[ ] I have updated the documentation (if necesarry)
[ ] I have run the tests and they pass
[ ] I have run the lint and it passes (pod lib lint)

This merge request fixes / reffers to the following issues: ...
Pull Request Description
When use #1438 in our app, we found image is rendered incorrect because first frame's size is not always equal to canvas size.
I just port the logic in libwebp.
@lianchengjiang also help check this.

I run the test in local, test04CachedImageExistsForURL: is failed, but seems this fail should not caused by my change.

Any update on this?

This is nearly the same fix logic for canvas size issue and disposal method support as #1952
For disposal method support, we should create an CGContext before the iteration start. And then clear the canvas before the frame end if disposal_background.
You implementation use UIGraphicsBeginImageContextWithOptions and UIRectFill this is UIKit specify, we should use CGBitmapContextCreate and CGContextClearRect for better performance and macOS support.
Additionaly, there are two more issue in Animated WebP decoding, including duration per frame and Animated WebP loop count. You can check #1951 for more details.

I have merged #1952 , let's close this one and see how it goes.


About page with some errors

The Instagram redirection doesn't work. If you click it nothing happens. It's the same for the YouTube redirection.

The YouTube link works perfectly fine for me.
It seems like the library I use does not work as expected, so I replaced it with own code, please try again (I uploaded new apk file).

Doesn't work yet. Same behavior as earlier

For me both now work...
You could download THIS APP and write the following:

If you then click on the blue "Launch" button it should open my insta page (in the app, if you have it installed).
Does it do that?

Nevermind it works. It looks like I didn't download the most current version ^^

Does the YouTube link work as well?

No

Does at least the website open or does nothing happen?

Nothing happens

I programmed a workaround because the library methods do not really seem to work.

Published in Version 1.2.5


FkRegex removes trailing slash from URL

Removing trailing slashes in FkRegex is IMHO a bad idea.

It's magic besides the regex
You can't have trailing slashes in your URL, even if you want. Ea.: as identifier for index (/) because /path/resources is the same like /path/resources/
There is no reason to support such a feature. If you want to support optional trailing slashes, just add \/?$ to your regex.
It's undocumented

@paulodamaso/z please, pay attention to this issue

@mreiche/z this project will fix the problem faster if you donate a few dollars to it; just click here and pay via Stripe, it's very fast, convenient and appreciated; thanks a lot!

@mreiche Please help me understand what happened in this issue: you did it before the pull request before the issue were open?

Where do you need help? The PR in reference to the issue should describe
everything.
Paulo Lobo<EMAIL_ADDRESS>schrieb am Do., 4. Juli 2019, 20:11:

@mreiche https://github.com/mreiche Please help me understand what
happened in this issue: you did it before the pull request before the issue
were open?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/yegor256/takes/issues/990?email_source=notifications&email_token=AAELYJI4SKCXAYC4JVRCOZLP5Y4LTA5CNFSM4H5CRVE2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODZH56RA#issuecomment-508550980,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAELYJKJJTMSZ3AFAOTUNGTP5Y4LTANCNFSM4H5CRVEQ
.

@0crat in

@0crat in (here)

@paulodamaso Job #990 is now in scope, role is DEV

@0crat in (here)

@paulodamaso Thanks for your contribution, @mreiche/z! If you would be a member of the project, you would now earn +15 reputation points, as explained in §29. You can join and apply to it, see §2.

@0crat assign @mreiche

@0crat assign @mreiche  (here)

@paulodamaso The job #990 assigned to @mreiche/z, here is why; the budget is 30 minutes, see §4; please, read §8 and §9; if the task is not clear, read this and this; @mreiche/z is not a member of this project yet, but they can request to join, as §1 explains; there will be no monetary reward for this job

It is strongly discouraged to assign jobs to their creators, see §19: -15 point(s) just awarded to @paulodamaso/z

Manual assignment of issues is discouraged, see §19: -5 point(s) just awarded to @paulodamaso/z

Job #990 is not in the agenda of @mreiche/z, can't inspect

@sereshqua/z please review this job completed by @mreiche/z, as in §30; the job will be fully closed and all payments will be made when the quality review is completed

The job #990 is now out of scope

@mreiche please make sure you start the messages with the name of the user there are addressed to, see

@0crat quality acceptable

Quality review completed: +4 point(s) just awarded to @sereshqua/z

Order was finished, quality is "acceptable": +30 point(s) just awarded to @mreiche/z


Housekeeping

Minor updates to dependencies, and readme file fixes.
Motivation and Context
I have another 4 commits ready to open a PR on, but I wanted to push these separately as there seems to be some debate (in the Slack) about how to use RE2.
Also, the Mongo updates fixes the error/warning about missing native BSON drivers that I was seeing when running the tests.
How Has This Been Tested?
I ran the scripts test.
Checklist:

[ ?] My code follows the code style of this project. I'm not sure what the code style is, at least it seems to be inconsistent. But @silentrob mentioned on Slack that he is OK with ES6 so I've used that.
[x ] I have updated the documentation accordingly. Just the link in readme.md
[ x] All new and existing tests passed. Only the script tests.

Thanks for the PR!


load_dataset('docred') results in a NonMatchingChecksumError

Describe the bug
I get consistent NonMatchingChecksumError: Checksums didn't match for dataset source files errors when trying to execute datasets.load_dataset('docred').
Steps to reproduce the bug
It is quasi only this code:
import datasets
data = datasets.load_dataset('docred')

Expected results
The DocRED dataset should be loaded without any problems.
Actual results
NonMatchingChecksumError                  Traceback (most recent call last)
<ipython-input-4-b1b83f25a16c> in <module>
----> 1 d = datasets.load_dataset('docred')

~/anaconda3/lib/python3.8/site-packages/datasets/load.py in load_dataset(path, name, data_dir, data_files, split, cache_dir, features, download_config, download_mode, ignore_verifications, keep_in_memory, save_infos, script_version, use_auth_token, task, streaming, **config_kwargs)
    845
    846     # Download and prepare data
--> 847     builder_instance.download_and_prepare(
    848         download_config=download_config,
    849         download_mode=download_mode,

~/anaconda3/lib/python3.8/site-packages/datasets/builder.py in download_and_prepare(self, download_config, download_mode, ignore_verifications, try_from_hf_gcs, dl_manager, base_path, use_auth_token, **download_and_prepare_kwargs)
    613                             logger.warning("HF google storage unreachable. Downloading and preparing it from source")
    614                     if not downloaded_from_gcs:
--> 615                         self._download_and_prepare(
    616                             dl_manager=dl_manager, verify_infos=verify_infos, **download_and_prepare_kwargs
    617                         )

~/anaconda3/lib/python3.8/site-packages/datasets/builder.py in _download_and_prepare(self, dl_manager, verify_infos, **prepare_split_kwargs)
    673         # Checksums verification
    674         if verify_infos:
--> 675             verify_checksums(
    676                 self.info.download_checksums, dl_manager.get_recorded_sizes_checksums(), "dataset source files"
    677             )

~/anaconda3/lib/python3.8/site-packages/datasets/utils/info_utils.py in verify_checksums(expected_checksums, recorded_checksums, verification_name)
     38     if len(bad_urls) > 0:
     39         error_msg = "Checksums didn't match" + for_verification_name + ":\n"
---> 40         raise NonMatchingChecksumError(error_msg + str(bad_urls))
     41     logger.info("All the checksums matched successfully" + for_verification_name)
     42

NonMatchingChecksumError: Checksums didn't match for dataset source files:
['https://drive.google.com/uc?export=download&id=1fDmfUUo5G7gfaoqWWvK81u08m71TK2g7']

Environment info

datasets version: 1.11.0
Platform: Linux-5.11.0-7633-generic-x86_64-with-glibc2.10
Python version: 3.8.5
PyArrow version: 5.0.0

This error also happened on my Windows-partition, after freshly installing python 3.9 and datasets.
Remarks

I have already called rm -rf /home/<user>/.cache/huggingface, i.e., I have tried clearing the cache.
The problem does not exist for other datasets, i.e., it seems to be DocRED-specific.

Hi @tmpr, thanks for reporting.
Two weeks ago (23th Aug), the host of the source docred dataset updated one of the files (dev.json): you can see it here.
Therefore, the checksum needs to be updated.
Normally, in the meantime, you could avoid the error by passing ignore_verifications=True to load_dataset. However, as the old link points to a non-existing file, the link must be updated too.
I'm all fixing this.


mocap_nokov: 0.0.1-2 in 'noetic/distribution.yaml'

Increasing version of package(s) in repository moveit to 0.0.1-2:
upstream repository: https://github.com/NOKOV-MOCAP/mocap_nokov.git
release repository: https://github.com/NOKOV-MOCAP/mocap_nokov_release.git
rosdistro version: 0.0.1-1
old version: 0.0.1-1
new version: 0.0.1-2

This doesn't seem like this was done with the bloom command.  That means that, in all likelihood, this is not going to work.  Can you redo this pull request, using bloom?

This doesn't seem like this was done with the bloom command. That means that, in all likelihood, this is not going to work. Can you redo this pull request, using bloom?

The release repo says the release was done using bloom, but probably the automatic PR couldn't be opened. https://github.com/NOKOV-MOCAP/mocap_nokov_release#mocap_nokov-noetic---001-2

It seems like something went wrong with the release. I'll close this for now.


buffer_scale = 1 appears to still be downsampling

I can visibly see the effect of lowering buffer_scale to something like .1 but even when I set it to 1 you can still clearly see aliasing as a result of downsampling.
Comparing the older boilerplate webvr-polyfill.js and the current webvr-polyfill.js shows different behavior. The older boilerplate code does not exhibit this issue. However, I'd prefer to not use this older version for other reasons.
Does this sound like a possible bug? If not, any clues on how to avoid downsampling would be appreciated.
Thanks,
Dustin

Can you provide an example of this?

Here is a example that uses a 2048x2048 video file as a texture - https://www.panomoments.com/m/2048 - The buffer_scale is currently set to 1 and it's using the latest polyfill.
Let me know if you're not able to reproduce. I am using a Galaxy S7 Edge.
Thanks,
Dustin

It looks like I'm unable to replicate using my Microsoft Surface Pro 2 (in forced VR mode).

@borismus were you able to replicate? I may swap over to the older polyfill sometime today or this weekend, but want to make sure you're able to see the issue before doing so.

FYI, I reverted back to the old polyfill so that above example will no longer have the issue. I will try to setup another demo page where it can be replicated later today.

Hmm, there's something odd going on. I tried to put together a simple version to share, but I am unable to replicate. I'll try to dig around a little, but is it possible that some CSS is causing strange interactions?

Everything is possible, but if you can't repro I'm going to close the issue.


Associate resource name completion candidates w/ the corresponding kind as completion category

All completion candidates for resource names, e.g. for kele-get, should be associated w/ the resource kind as completion category. Completion categories act as the basis for, for example, Embark actions.
For the most part, this would be a generalization of the existing logic for categorizing namespace candidates as kele-namespace (7517f0afebb42731e0592c58ea6a343481d5f817).

It is not feasible to dynamically generate the category based on resource name, e.g. (intern (format "kele-resource-%s" kind)); embark-keymap-alist et al assume specific matches.
Rather, I think we can change tack slightly here to have all resource names be categorized as simply kele-resource by default. This would allow us to attach generic keymaps, annotations, etc. Then, for resource kinds w/ specific "needs" (e.g. a num-active annotation for pods), we can attach the specific category to them on a case-by-case basis, e.g. kele-pods.

Deprioritizing Embark integrations in favor of fleshing out Transient-based usage first. Transient is in core Emacs while Embark is not, which means that improvements we make to Transient usage will have broader reach and appeal.


Blocklist feature

Please make sure these boxes are checked, before submitting a new PR.

[x] You ran rustfmt on the code base before submitting (on latest nightly with rustfmt support)
[x] You reference which issue is being closed in the PR text (if applicable)

Issues
#143
Breaking Changes
None.
Other Changes

Components can block a certain IpAddr and SystemPath by triggering BlockIp and BlockSystem on NetworkStatusPort (There are corresponding events for unblocking: UnblockIp and UnblockSystem)
A blocklist is added to the NetworkThread
New variant of  ConnectionState called Blocked that allows the NetworkDispatcher to keep track of which connections are blocked.

Components that requires the NetworkStatusPort can block an IpAddr or SystemPath by triggering BlockIp and BlockSystem on it. Blocking/unblocking an IpAddr will also block/unblock all SystemPath with that same ip address.
The network thread keeps track of all blocked ip addresses and sockets. Upon blocking, it will drop all channels to that ip or socket and notify the network dispatcher. The network dispatcher will update the connection state to ConnectionState::Blocked. If a message is tried to be sent on a connection that is blocked, the message will be dropped by the network dispatcher. Furthermore, the network dispatcher will trigger an indication to the NetworkStatusPort to confirm each block and unblock using BlockedIp, BlockedSystem, UnblockedIp and UnblockedSystem.
Status

[x] Blocklist implementation
[x] Tests of blocking and unblocking
[ ] Tutorial

Do you mind delaying the merge of this until next week once #145 should be merged and already including code for reading the blocklist from config as well?

I don't mind, I will add that :)

Actually, you know what. I think you can just as well merge it once all tests pass.
Looking over it in more detail, it's anyway just a sub-part of the full feature set we discussed for #143 so we can just as well add the config stuff in the next PR.

The failing items will go away if you rebase on master @haraldng . I already fixed them (well, the nightly one at least^^).


Update "Merge Insert" docs

I was scrolling through the docs and noticed what I'm fairly certain is a bug or typo in some of the example code.
e.g.:
import lance

# Change the ages of both Alice and Bob
new_table = pa.Table.from_pylist([{"name": "Alice", "age": 30},
                                  {"name": "Bob", "age": 20}])
dataset = lance.dataset("./alice_and_bob.lance")
# This will use `name` as the key for matching rows.  Merge insert
# uses a JOIN internally and so you typically want this column to
# be a unique key or id of some kind.
dataset.merge_insert("name") \
       .when_matched_update_all() \
       .execute()

new_table never actually gets used. I'm not sure what the intended code here is.

I think it's meant to be passed into .execute().


Fix plot issue

Fix a plot issue when max_steps is larger than 1000.
Not a bug but make the plot function more robust.

Thank you


Add arm support

This PR adds basic linux/arm64 support via docker's new buildx. For now, we're adding linux/amd64 and linux/arm64 only but it is fairly trivial to add more platforms.
This does change the development experience: Since docker-compose can't natively build an multi-arch image, we are moving that phase into the make build command. In order to spin up a local dev environment, you now need to run make build before running make up. Unfortunately I'm not aware of a better way to solve this.
Closes #133

Thanks for your quick review! I've responded/addressed all of your comments, PTAL. @Grokzen

When are we expecting this to be merged?

When are we expecting this to be merged?

Unclear! I'll have time to do another design revision today/tomorrow. We'll see after that.

@JanBerktold Thanks for the quick reply,
I am using a manually created container image for now. I'd be watching this thread, I hope you get some time for it.
Have a nice day.

@isaadabbasi This PR needs more work before i am passing it through the gates into the master branch

Hello @Grokzen! Just to get back into this, would you be fine with updating the Travis CI workflow so the published builds support linux/arm64 using docker buildx?

Hey @Grokzen is currently being actively developed?

@ac27182 No not currently


TravisCI Build fails while waiting for an input to surge.sh

I'm submitting a

[x] CI enhancement

Current behavior
Travis CI builds fail after 10mins as Surge expects an email input which it doesn't get.
Steps to reproduce
Create any Pull Request (or a new commit in any of the existing Pull Requests)
Useful link:
https://surge.sh/help/integrating-with-travis-ci

@live-wire Can you please look into this issue? I won't get time until next week to look into this?

Yeah I'm on it 🍺
I'll reach out to you If i have doubts.

Sounds good. Thanks a lot for taking lead on this.

@live-wire Please feel free to close the issue if this is completed.

This was resolved as part of #58


Elapsed time doesn't reset each run

The current behavior is that the elapsed time field doesn't reset each time that you convert a project.  The elapsed time field should reset every time the Go button is pressed.

It also doesn't handle operations taking longer than a day (maybe I'm the only one that had a conversion take that long :p?). That is, it won't show the days component of the timespan, only hours, mins, seconds.


Compiling with -install_path and -rpath flags containing @ macros fails

H/t to @vinistock for finding this issue.
The below is mostly copied from #88; the issue is essentially that we're parsing -install_path @executable_path/... and similar flags as param files, incorrectly.

That snippet was added to support parameter files.
The macOS cc wrapper script inspects the full command line in order to remap libraries that are being linked against to their fully resolved paths, taking into account the rpaths added to the binary. I don't have first-hand experience with this but this is allegedly because of some oddness having to do with runpaths added to binaries (this has some context; I think it's that the paths are relative to the build dir and not the workspace that's causing the issue but I have no idea what's introducing the -Wl,-rpaths in the first place).
Anyways, for that reason we need to actually read what's in the parameter file. The PR in this repo you linked to was essentially copied from upstream (this commit); in general the logic in the macOS wrapper mostly comes from upstream.
The issue here, of course, is that the @ in -install_name @execution_path/... does not signify a parameter file!
What's peculiar to me is that upstream Bazel seems to fail on this in the exact same way (here's a minimal test case). Perhaps it's simply not common for users to want to generate dylibs with install_paths from Bazel and it hasn't come up? Not sure.

Extending the logic in the macOS wrapper to skip processing args starting with @ (like @execution_path/..., @executable_path/..., @load_path/.., @rpath/..., etc.) when the preceeding arg is -install_name or -rpath is the obvious fix, I think.
I have a few concerns though:

is this genuinely an error with the default Bazel toolchain?

edit: it appears so: bazelbuild/bazel#13044

are -install_name and -rpath the only args that accept @ macro form args? might be worth checking the clang arg parsing source to be sure

edit: it's probably better to just check that the file exists instead of maintaining a list. FWIW clang and the linker don't seem to actually even have a list of @ macros that are acceptable; passing in @some_random_thing will compile successfully. grepping through dyld source and peering through the dyld man pages does indicate that it's really just @rpath, @executable_path, and @loader_path though. (@execution_path seems to be just a typo that a few people independently made over the years)

what kind of path remapping should we be doing for -install_name and -rpath?

I think the answer is "none" for -install_name but what about -rpath? Don't we have the same issues as with -Wl,-rpath? -rpath certainly does seem to just expand out into -rpath to the linker, experimentally. Are we just banking on users always using the not-macOS-specific -Wl form?

edit: going to add -rpath @loader_path/... to $RPATHS too; this misses -Xlinker -rpath -Xlinker @loader_path/... but I think that's okay for now.

why does the logic in the wrapper only check for @loader_path?

edit: not really sure but assuming this is the path of the directory the dylib being loaded was found at at link time it makes sense that this doesn't match up with the runtime search path, for Bazel. if you don't think about it too hard.

For your reference, the flag is added by Ruby's configure script. As instructed by the README, running autogen.sh creates the configure script, which in turn adds the install_name flag.
Although the configure script itself doesn't exist in the repository (since it's autogenerated), we can see the relevant lines in configure.ac. Here is where it sets the install_name and a few lines above is where the base path is set.
Sorbet's custom build does the same process, integrating it with Bazel. Here is where configure is invoked and install_name is set and the build fails immediately after when compiling (because cc_wrapper will try to read the path).
In respect to your concerns, I'll need to do more research to be of more help. But I can confirm that changing the cc_wrapper to not do any special processing of arguments beginning with @ makes the build succeed. For example, swapping the loop that parses arguments for this does the trick
for i in "$@"; do
    parse_option "$i"
done

In respect to your concerns, I'll need to do more research to be of more help.

Whoops my bad, I wasn't expecting you to try to find the answers to those questions; just thinking out loud.

Sorbet's custom build does the same process, integrating it with Bazel. Here is where configure is invoked and install_name is set and the build fails immediately after when compiling (because cc_wrapper will try to read the path).

Got it, thanks.

Note I believe this case should be fixed once https://github.com/bazelbuild/bazel/pull/13148 lands

Note I believe this case should be fixed once bazelbuild/bazel#13148 lands

Thank you. And thanks for bumping that PR/writing bazelbuild/bazel#14650.

I think the referenced bazel fixes are in bazel 6.0.0 but I'm still seeing failures when using @rrbutani's test case from the gist.
Tried on 6.0.0 and 7.0.0-pre.20221212.2.
Any idea what's needed?

This may be resolved now with the new wrapper scripts. Can someone please try it and close this issue?

Closing now, but can reopen if someone says something.

Please reopen. Just tried 1.2.0, still having this issue with -install_name @rpath/libomp.dylib


Update beaker-electron to 1.7.1-0-g6dac09a

After making all changes to the cask:

[x] brew cask audit --download {{cask_file}} is error-free.
[x] brew cask style --fix {{cask_file}} left no offenses.
[x] The commit message includes the cask’s name and version.

Thank you for the contribution. It was merged directly as b1a3f0f593dd6e7c14bd85598e99bc4cacdd2a45. Your contribution is still credited to you.


Console command for interacting with Chromium OS clipboard

Right now, if you are using the regular Secure Shell and enter-chroot, croutonurlhandler doesn't work. Also, there is no way to synchronize the Chrome OS clipboard with the clipboard inside the chroot, for use with vim or emacs clipboard integration. Can these features be implemented, or do they rely too heavily on X?

See #2113 for the first item.  I'm not sure what you want for the second item, since vim/emacs without X11 have their own internal buffers that aren't synchronized via any standard.

Thanks for the quick response. I guess I meant getting xclip or some equivalent to work in the console, and it would be easy to have that command talk to whatever other programs.

Ohhh, that makes sense.  Basically, we need to add xclip-like -i and -o parameters to croutonclip.

Yeah, that work even without X, from enter-chroot in secure shell.
xclip actually works if I do xiwi uxterm.
On Sun, Oct 11, 2015, 02:22 David Schneider<EMAIL_ADDRESS>wrote:

Reopened #2169 https://github.com/dnschneid/crouton/issues/2169.
—
Reply to this email directly or view it on GitHub
https://github.com/dnschneid/crouton/issues/2169#event-432288818.

I hacked up something in go to do what I needed (of course it requires the crouton chrome extension installed), but since it doesn't have a dedicated server process it has a high latency (depends on the extension reconnecting to the server).
I could refactor slightly to have a long running server to which I communicate with using named pipes, but I presume croutonclip is already doing something like this?
In case its useful to others, here is what I came up with so far:
https://gist.github.com/acornejo/763f8540dd01090955f3ddcbfee55d42

I've since put it in a proper repo and updated it to use a long running process to avoid any lag, works well enough for me, perhaps its useful to others:
https://github.com/acornejo/croshclip

Is this also addressed by https://github.com/zwhitchcox/crouton-clipboard? I think this should be closed.

Examine the FAQ for "Secure Shell".  It has a link to a utility program called "osc52" which copies from stdin to the system clipboard, up to 100K chars.

As a filter to vim, to copy a whole file to system clipboard:

$ vim somefile
gg
!G osc52.sh
*

Copy a few words, lines or whole file direct from command line:

$ echo foo bar | osc52.sh
*
$ cat | osc52,sh
There was a young person from Ride
Who had a most practical side
^D
*
$ cat somefile | osc52.sh

How do we use croutonclip?

Or, more specifically, if we have croutonclip installed inside enter-chroot, how do we get Vim/NeoVim to actually yank to the Chrome OS clipboard?

Hmmm, I'm getting somewhere. If I let it run for a while, it says
❯ croutonclip
Timeout waiting for extension to connect.
Cannot open /sys/class/tty/tty0/active: No such file or directory

I gave up on all that, and use Secure Shell - logging into
"username@localhost" - together with the osc52.sh utility that comes with
Secure Shell, in order to copy text to the system clipboard.
On Fri, Oct 13, 2017 at 1:04 AM, Joe Pea<EMAIL_ADDRESS>wrote:

Hmmm, I'm getting somewhere. If I let it run for a while, it says
❯ croutonclip
Timeout waiting for extension to connect.
Cannot open /sys/class/tty/tty0/active: No such file or directory
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/dnschneid/crouton/issues/2169#issuecomment-336351269,
or mute the thread
https://github.com/notifications/unsubscribe-auth/Acvoi2fOjON-IwFVkMuGNUgseU82kWYJks5sru9fgaJpZM4GLAgq
.

Ah, cool, got croshclip working (needed Crouton Chrome plugin). I'm still not sure how croutonclip works though, but croshclip meets the need!


api: mode sense add control page support

Signed-off-by: Xiubo Li<EMAIL_ADDRESS>

Has be updated, please review.

Hey, was just asking for a one or two line description. Thanks for being so thorough.


Add Python location to ‘az —version’

Example:
$ az --version
azure-cli (2.0.3+dev)

acr (2.0.1+dev)
acs (2.0.3+dev)
appservice (0.1.3+dev)
batch (2.0.1+dev)
cloud (2.0.1+dev)
component (2.0.1+dev)
configure (2.0.3+dev)
container (0.1.3+dev)
core (2.0.3+dev)
dla (0.0.2+dev)
dls (0.0.2+dev)
documentdb (0.1.3+dev)
feedback (2.0.1+dev)
find (0.0.2+dev)
iot (0.1.3+dev)
keyvault (2.0.1+dev)
lab (0.0.2+dev)
monitor (0.0.2+dev)
network (2.0.3+dev)
nspkg (2.0.0+dev)
profile (2.0.3+dev)
redis (0.2.0+dev)
resource (2.0.3+dev)
role (2.0.2+dev)
sql (2.0.1+dev)
storage (2.0.3+dev)
taskhelp (0.1.1b4+dev)
testsdk (0.1.0+dev)
utility-automation (0.1.1)
vm (2.0.3+dev)

Python (Darwin) 3.5.1 (v3.5.1:37a07cee5969, Dec  5 2015, 21:12:44)
[GCC 4.2.1 (Apple Inc. build 5666) (dot 3)]

Python location /Users/debekoe/Repos/derekbekoe-azure-cli/env/bin/python

Codecov Report

Merging #2986 into master will decrease coverage by <.01%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##           master    #2986      +/-   ##
==========================================
- Coverage    63.4%   63.39%   -0.01%
==========================================
  Files         466      466
  Lines       26593    26596       +3
  Branches     4083     4083
==========================================
  Hits        16861    16861
+ Misses       8655     8618      -37
- Partials     1077     1117      +40

Impacted Files
Coverage Δ

src/azure-cli-core/azure/cli/core/util.py
67.42% <0%> (-1.57%)
:arrow_down:

...-testsdk/azure/cli/testsdk/recording_processors.py
53.33% <0%> (ø)
:arrow_up:

...-cli-role/azure/cli/command_modules/role/custom.py
33.1% <0%> (ø)
:arrow_up:

...e-cli-acs/azure/cli/command_modules/acs/_params.py
68.51% <0%> (ø)
:arrow_up:

...twork/azure/cli/command_modules/network/_format.py
43.37% <0%> (ø)
:arrow_up:

...ure-cli-vm/azure/cli/command_modules/vm/_params.py
96.19% <0%> (ø)
:arrow_up:

...li-role/azure/cli/command_modules/role/commands.py
86.66% <0%> (ø)
:arrow_up:

...i-redis/azure/cli/command_modules/redis/_params.py
77.77% <0%> (ø)
:arrow_up:

...twork/azure/cli/command_modules/network/_params.py
93.11% <0%> (ø)
:arrow_up:

...e-cli-acr/azure/cli/command_modules/acr/_format.py
38.88% <0%> (ø)
:arrow_up:

... and 14 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a655d59...e740d7e. Read the comment docs.


Feature request: Add members to group flow

Is your feature request related to a problem?
Support adding members to a group
Describe the solution to the problem
No response
Describe the uses cases for the feature
No response
Additional details
No response

Adding members and publishing welcomes is complete, with the exception of the "group sync" flow which is ticketed separately


[CS] Restructure the code

As the application grows bigger, the application is becoming messier.
I feel managing the code is going slightly out of hand.
So. restructuring the application is needed.
Current thinking is using some kind of MVP pattern.

add util header to accommodate simple function, generate...
edje controls user interaction (simple interaction is handled here as well).
view creates view with registering callbacks(reside in presenter)
presenter delegates a logic to view/edje and data
data manipulates data.

The patch would just restructure the code so it will take less than a day.

:octocat: cibot: Thank you for posting issue #577. The person in charge will reply soon.

[ ] Change name to tell view object from data object in appdata_s
[ ] Change router to main
[ ] ...
[ ] Change others to main


Option to disable E1029 using a regex pattern on the variable name

cfn-lint version: 0.26.0
This is another take on the https://github.com/aws-cloudformation/cfn-python-lint/issues/740. I am using cfn-lint in combination with Serverless Framework and the VSCode plugin to validate the CloudFormation template "chunks" that are referenced in the resource section within the serverless.yml (spec: https://serverless.com/framework/docs/providers/aws/guide/serverless.yml/)
serverless.yml (not validated by cfn-lint, provided for reference)
service: my-service
provider:
  name: aws
[... other stuff ..]

# importing raw CloudFormation files here
resources:
  - Description: My Example Service Stack
  # roles
  - ${file(./cfn-resources/resource1.yml)}
  - ${file(./cfn-resources/resource2.yml)}

.cfnlintrc
templates:
- cfn-resources/*.yml

resource1.yml
Conditions:
  PrimaryRegion: !Equals ['${self:provider.region}', 'us-east-1']

[some resources]

Serverless framework will pre-process the yml file and replace the ${..} sequence with actual string values before generating the actual CloudFormation template to be sent to AWS. Unfortunately they chose a syntax that conflicts with something CloudFormation uses as well.
With the above config, cfn-lint generates this error:
E1029: Found an embedded parameter outside of an "Fn::Sub" at Conditions/PrimaryRegion/Fn::Equals/0
I can get around this error by putting a !Sub in front of it (which is useless, it will upload an unnecessary !Sub 'us-east-1' to AWS). But then I get this:
E1019: Parameter self:provider.region for Fn::Sub not found at Conditions/PrimaryRegion/Fn::Equals/0/Fn::Sub
So I have to disable both rules, or disable E1019 and stick a !Sub in front of everything that has a serverless-specific variable.
It would be great to have a way to be able to configure both rules in such a way that they treat the whole ${variable}  block as a literal by if variable matches a regex pattern. Ideally through .cfnlintrc so it applies to all the files...
NOTE: I am aware that this is not an issue with cfn-python-lint, but I don't see how it could be solved by the VSCode plugin (it basically reports what it gets from cfn-lint) or the Serverless team (they're stuck with the syntax due to backwards compatibility, it's been discussed before, in the context of having the problem in the opposite direction by serverless treating ${AWS::Region} as its own variable and trying to replace it, see https://github.com/serverless/serverless/pull/3694)

I think this could be done easily.  Configuring this rule seems to be never ending so making it a little more dynamic seems like a reasonable approach to me.

@kddejong assuming you're hinting at a pull request: I haven't written any python yet, but if you thinking it's easy I can give it a shot when I have time.
For confirmation, I would assume the change involves something like:

choose a way to configure the offending rule (E1019), for example:

configure_rules:
  E1019:
    resource_excludes_custom_filter: [some regex]
    condition_excludes_custom_filter: [other regex]

use self.config to read the rule settings in match_values function around here and decide whether to skip the rule checks in a similar way as already done with the hard-coded resource_excludes and condition_excludes
also add a self.config_definition in the same class, in a similar way to this one
update docs, mentioning the settings in https://github.com/aws-cloudformation/cfn-python-lint#configure-rules
write a couple of tests

If I missed something, let me know.

@coyoteecd I don't mind trying to tackle this too.  It looks like you are heading in the right direction.  Let me know what works best for you.

After a bit of thought, I realized that the initial config proposal is not what I need; the reason is the resource/condition excludes are meant to apply specifically to the Resource/NotResource/Condition subsections, while in my case I have "variables" that must be ignored in other places too, e.g. name of a resource.
So I settled for fixing E1029 to have a generic custom exclude regex:
configure_rules:
  E1029:
    custom_excludes: [some regex]

The regex matches against the complete variable name, i.e. ${self:provider.stage}, so an example regex would be:
configure_rules:
  E1029:
    custom_excludes: ^\${self.+}$

The above ignores any variable that starts with "self" anywhere in the .yml file.

I installed 0.28.1 and it works as intended, we can close this.


Support for workload identity federation

We run on GCP and have several other parties that do not run on GCP and need to interact with our GCP infrastructure. We tend to use the Workload Identity Federation feature of GCP (see https://cloud.google.com/iam/docs/using-workload-identity-federation) to allow them access based on their AWS, Azure, or OIDC credentials. We love that feature as it removes the need to manage secrets.
However, it seems this identity federation is supported by most google client libraries, but not the dotnet one. Is it just a matter of me being unable to find this in the documentation? Otherwise, please consider this a feature request to add support for federated credentials.
See https://github.com/googleapis/google-auth-library-nodejs#workload-identity-federation for how Identity Federation is supported by the nodejs GCP clients. They use the new gcloud iam workload-identity-pools create-cred-config cli tool to create a json that can be used in the GOOGLE_APPLICATION_CREDENTIALS  environment variable to have the client libraries automatically use identity federation. Perhaps this can be an inspiration on how to offer this in the dotnet eco system.

I'm transferring this issue to google-api-dotnet-client as that's where the auth library lives. I'll then assign it to Amanda, who knows this area better than I do.


Egde option

add grafical interface of the edge option of the radar plot methods.

I am working on this one now. I just need a file to test and then I'll create a PR for inspection.

Will you take a look at PR#154?
I didn't add the code to the plot_grid. I think it should work the same, though. Correct?

yes, it could work just the same in plot_grid, this is however not much of a problem in the grid as it don't have the closing of azimuth problem.
I actually don't fully understand what it is the underling pyart error that create that problem, but if edge=False solves the problem, I'm fine with it.

I believe it has to do with the interpolation that pyart performs to extract the edge from the gate center information. If there is wonky data then the interpolation gets a weird value. Is this correct @jjhelmus ?

for reference the original source of this issue: https://groups.google.com/forum/?utm_medium=email&utm_source=footer#!msg/artview-users/7gSpxa6_POM/MkRQGPwaBAAJ

I believe it has to do with the interpolation that pyart performs to extract the edge from the gate center information. If there is wonky data then the interpolation gets a weird value.

The range, azimuth and elevation data stored in Py-ART's Radar class refers to the center of the range bin. If this is always set correctly is another question but typically even if the gates locations are specified differently it makes little perceivable difference.  Therefore for each gate we need to calculate the locations of the "edges" of  quadrilateral which will be have a center at the gate location.
For the range dimension this is relatively straight forward. For gates not at the endpoints, the edge is halfway between the gates. At the ends we extrapolate by adding or adding or subtracting half the distance from the previous/next gate.
The azimuth/elevation dimension are a bit more difficult, as we need to take into account the possible periodic nature of the dimension and some physical limitation (elevation should be between 0 and 180 degrees) but the idea is similar, find the mid-point between rays and extrapolate at the edges.  This work good if the sampling of the azimuth or elevation is fairly uniform but if you have a big break or a wonky ray it can mess things up.  I'm guessing that is what is going in the linked example.

Thanks for the explanation @jjhelmus.

Issue closed in PR #154


Add subnormal values handling for fp8e5m2 to bf16 conversion

This basically follows the cuda without native FP solution, but avoids multiplications (the exact same solution seems tricky to achieve with LLVM btw as it grandmotherly replaces fp constants). A bit crude and doesn't benefit from packing much, but works. Spending some memory for the substitution table seemed better than a more complex logic.

Yep, we do. I left the skip condition for those and will push those patches separately.


[DNM/WIP]: New yosys master+wip with some fixes

This builds up on https://github.com/SymbiFlow/symbiflow-arch-defs/pull/1577. It updates the conda yosys package that should have the share directory location fixed.

Superseded #1577


Update LD_LIBRARY_PATH to ensure access to GDAL in rasterframes notebook

Signed-off-by: Tom Schroeder<EMAIL_ADDRESS>

closes #193


[RSDK-8195]   Set supports_pcd to true in RealSense

RSDK-8195
Forgot to change properties after adding new pcd method
Tested with robot usage of RealSense as a dependency for the join-point-clouds module to verify that we can invoke get_properties properly and that pcd support is now true

@bhaney since Rand is OOO

There is a config parameter in the realsense module called "enable_point_clouds" which would toggle on or off the enablePointClouds  bool. You should go through the code and remove the config parameter, as well as the enablePointClouds bool
struct RealSenseProperties also has enablePointClouds bool as a field.
And please continue adding me to PRs for the intel realsense, even when Rand is around

Got it. I removed enable_point_clouds in config validation and traces of enablePointClouds from the hpp and cpp files

There is a config parameter in the realsense module called "enable_point_clouds" which would toggle on or off the enablePointClouds  bool. You should go through the code and remove the config parameter, as well as the enablePointClouds bool
struct RealSenseProperties also has enablePointClouds bool as a field.
And please continue adding me to PRs for the intel realsense, even when Rand is around

Got it. I removed enable_point_clouds in config validation and traces of enablePointClouds from the hpp and cpp files

Justy FYI - removing configuration attributes of a model is a breaking change.
I do not think we're at enough use of this mode to warrant a migration, but for something like webcam or transform camera I would have insisted we investigate usage and run a migration script to remove the attribute.
But for here - please update the attribute in the readme if it exists.

There is a config parameter in the realsense module called "enable_point_clouds" which would toggle on or off the enablePointClouds  bool. You should go through the code and remove the config parameter, as well as the enablePointClouds bool
struct RealSenseProperties also has enablePointClouds bool as a field.
And please continue adding me to PRs for the intel realsense, even when Rand is around

Got it. I removed enable_point_clouds in config validation and traces of enablePointClouds from the hpp and cpp files

Justy FYI - removing configuration attributes of a model is a breaking change.
I do not think we're at enough use of this mode to warrant a migration, but for something like webcam or transform camera I would have insisted we investigate usage and run a migration script to remove the attribute.
But for here - please update the attribute in the readme if it exists.

I don't think this attribute is documented

There is a config parameter in the realsense module called "enable_point_clouds" which would toggle on or off the enablePointClouds  bool. You should go through the code and remove the config parameter, as well as the enablePointClouds bool
struct RealSenseProperties also has enablePointClouds bool as a field.
And please continue adding me to PRs for the intel realsense, even when Rand is around

Got it. I removed enable_point_clouds in config validation and traces of enablePointClouds from the hpp and cpp files

Justy FYI - removing configuration attributes of a model is a breaking change.
I do not think we're at enough use of this mode to warrant a migration, but for something like webcam or transform camera I would have insisted we investigate usage and run a migration script to remove the attribute.
But for here - please update the attribute in the readme if it exists.

I don't think this attribute is documented in the readme or in docs

perfect


Shipping might be done with only Amiga.cfg, not minimig.cfg?

I have several friends who destroyed their own personal startup config by copying over the AmigaVision minimig.cfg over their own.
Many Amiga users have personal configs, using their own old hdf images from back in the day. It is disruptive to have an AmigaVision install just wipe such a config completely by overwriting minimig.cfg.
Since the isolation between AmigaVision configs and personal configs works pretty well already, it might be good to not ship AmigaVision with a "minimig.cfg". It already comes with Amiga.cfg and the corresponding Amiga.mgl, which might be enough? Amiga.cfg could even be renamed AmigaVision.cfg and then AmigaVision could live happily besides personal configurations.
I am just writing down my thoughts for suggestions, please feel free to ignore.

So, first off: this has been the case with every MegaAGS release from the start; if you blindly copy over the files if you have a custom setup, you would always kill your setup.
That, of course, doesn’t mean you are wrong — we debated this a bit back and forth, and erred on the side of supporting people that didn’t read the docs, just copied over everything and launched Minimig.
Now that we have the new MGL setup, I agree that we should probably not touch Minimig at all, and just ship everything inside the Amiga.mgl setup.
We are going to issue a quick follow-up “patch” release for the 2023.04.05 release (as we always end up doing since there’s always a couple of issues discovered on release), and we will stop shipping anything related to the Minimig config at all from then on.
I personally am pretty strongly against shipping an entry called AmigaVision.mgl, though — we are trying to appeal to the people that “just want to try Amiga games”, and it’s nice to have a clean, understandable name without involving the branding of our project in that list. (I will update the docs to point out the possibility of duplicate entries if you use names.txt, though :)


add sample data service queries doc

The sample data queries doc[1] is missing in EI. Some of the contents here are applicable to EI 7.1 as well. Therefore, it is necessary to create a new page.
[1] https://docs.wso2.com/display/EI660/Sample+Queries+

Fixed by https://github.com/wso2/docs-ei/pull/2315


Uploaded Icon of Link not shown if used in system group

Hi everyone,
I have just started exploring Fenrus and already like this tool.
I created a system group containing some links and uploaded my own icons (PNG) using the browse button. The icons do not load if it is a system group - see screenshot. If I add the same link/icon to a group (not system) then it works and the icons are shown.

Is this a bug or am I missing something?

fixed in 0.4.1


[BUG]  Error Pops Up When Sydney Makes A Response InternalError": "Unhandled Exception

Checks

☑ I confirm that I have searched existing issues and couldn't find a similar bug.
☑ I have read the documentation carefully and it couldn't resolved my problem.

Describe the bug
Responses does work very fine with no issues however an error pops up every response sydney make. "InternalError": "Unhandled Exception
https://github.com/juzeon/SydneyQt/assets/150899804/9beeeff8-42e7-4309-bb2e-562d55dab8e2
Desktop (please complete the following information):

OS and Version: [Windows 11]
SydneyQt Version: [v2.3.1]

Seems like a bug on bing's side. Does this occur in v2.3.0?

yes it happened on the previous version too.

Seems like a bug on bing's side. Does this occur in v2.3.0?

Same happened in v2.3.1, I thought it is in the app or Hardware Issue

Same thing happens with the web api when no search is false. And with that it just closes out the connection after returning the error, no response is given. At least that's the case for the openai styled endpoint.

@juzeon  Figured it out. It is the deuct3 option that is causing the error to occur. Idk what that option does though. Removing it causes everything to work fine.

@jschmudd Thanks dude.


Problem cyrillic (russian) font

The device displays Russian letters incorrectly, regardless of the sending method.

Unfortunately, there is no full support for the Russian language. But you can always create your own font and I will gladly add it to the project.
Now Cyrillic is used only for days of the week in (aa) clock mode https://github.com/widapro/wledPixel/blob/main/src/main.cpp#L963-L964

"ПН" - Понедельник

There is a font https://github.com/pilnikov/MAX7219-Clock/blob/master/Fonts.h

Can you add the font from the link above?

Happy New Year!
I've compiled the bin with the fonts file from Jager-f and I can't show the special characters like: á, é, í, etc., it shows others Ä, Â, A+...
In spanish these charaters are essential for displaying messages.
What am I doing wrong?
Thank you


Improve handling of NUL file on Windows

NUL file is now stat-able. The special handling of /dev/null is removed since this system file is supported by the OS and can be treated like any other file.

StatStream is kind of an odd pattern (or I'm just not used to seeing it in C#) but it's private so I guess it's fine.

With a public API I would have been more careful (I hope) and probably opted for something like
bool TryStatStream(Stream stream, [NotNullWhen(true)] out stat_result? res) but with local functions the habit is to write as few lines of code as possible 😃


support for opentsdb 2.3

updated opentsdb to version 2.3
removed hardcoded hbase version in wget
fixed docker build by using gnuplot from community repo

Thanks for this PR; sorry it took so long to get it merged, I'm trying to clean up some of the things I've left languishing, like this docker container.


fix typo in new-mail

new_command => new_mail_command

Good spot!
The source of the mistake is actually in the code repo, so I've updated that too.
https://github.com/neomutt/neomutt/blob/f22450bc82a67f121b0432811ecbf66989244eae/docs/manual.xml.head#L15846
Thanks!


Restart when we don`t have connection to internet

When we don`t have connection to internet, then we have error:
Running a Speed Test...
[2023-05-31 11:12:13.422] [error] Trying to get interface information on non-initialized socket.
[2023-05-31 11:12:18.435] [error] Configuration - Couldn't resolve host name (HostNotFoundException)
[2023-05-31 11:12:18.435] [error] Configuration - Cannot retrieve configuration document (0)
[2023-05-31 11:12:18.435] [error] ConfigurationError - Could not retrieve or read configuration (Configuration)
[2023-05-31 11:12:18.436] [error] ConfigurationError - Could not retrieve or read configuration (Configuration)
{"type":"log","timestamp":"2023-05-31T11:12:18Z","message":"Configuration - Could not retrieve or read configuration (ConfigurationError)","level":"error"}
./speedtest.sh: 22: arithmetic expression: expecting primary: "  / 125000 "

and container is down and nothing in graphana...
Please add "restart always" to you docker-compose file for this container to restart and test again when the internet came back :)

Good catch, thx


[bug] I copied your splashscreen example code, but can't colse splashscreen window

Describe the bug
I copied your splashscreen example code, but can't colse splashscreen window. And new window show 'no response'.
I only changed url to '/xx/splashscreen.html'.
How to solve it?
Reproduction
No response
Expected behavior
No response
Platform and versions
window 10
rust v1.57
tauri v1.0.0

Stack trace
No response
Additional context
No response

Can you share your project? I can't help you without more information, you probably missed something. There's also a guide in the docs.

I think the rust is too old. Please update.

I think the rust is too old. Please update.

I had updated rust version to 1.61. Still not working.

Can you share your project? I can't help you without more information, you probably missed something. There's also a guide in the docs.

Hey, my code is here.

@Virgil-N Your close_splashscreen function was sync, the example shows you that it needs to be asnyc.
-> change the function signature to async fn close_splashscreen(window: tauri::Window) {}

@Virgil-N Your close_splashscreen function was sync, the example shows you that it needs to be asnyc. -> change the function signature to async fn close_splashscreen(window: tauri::Window) {}

Problem solved. Thanks!

Hello, my english is not good.
windows 10
tauri and rust both latest.

tauri dev is ok.
splashscreen show -> close when domcontentloaded -> main show.

but after build, splashscreen show forever, and no main window.

Hello, my english is not good.
windows 10
tauri and rust both latest.

tauri dev is ok.
splashscreen show -> close when domcontentloaded -> main show.

but after build, splashscreen show forever, and no main window.

Sorry, code work fine. because i didn't write Waiting for rust in my code. sorry again.


Rebuilding sqlite3 failed.

Hi
I'm using atom-shell 0.21.2 and i'm trying to rebuild sqlite3 for my app but with no success.
i tried all three ways in here, but none of them works.
$ export ATOM_NODE_VERSION=0.21.0
$ apm install .

so output is:

gyp info it worked if it ends with ok
gyp info using<EMAIL_ADDRESS>gyp info using<EMAIL_ADDRESS>| linux | x64
gyp http GET https://atom.io/download/atom-shell/v0.21.0/node-v0.21.0.tar.gz
gyp http 200 https://atom.io/download/atom-shell/v0.21.0/node-v0.21.0.tar.gz
gyp http GET https://atom.io/download/atom-shell/v0.21.0/SHASUMS256.txt
gyp WARN install got an error, rolling back install
gyp ERR! install error
gyp ERR! stack Error: getaddrinfo ENOTFOUND
gyp ERR! stack     at errnoException (dns.js:37:11)
gyp ERR! stack     at Object.onanswer [as oncomplete] (dns.js:124:16)
gyp ERR!   System Linux 3.14.27-desktop-1.mga4
node-pre-gyp ERR! command "node" "/home/mehdi/temp/test/atom-shell-v0.21.2-linux-x64/resources/app/node_modules/sqlite3/node_modules/.bin/node-pre-gyp" "install" "--fallback-to-build"
node-pre-gyp ERR! cwd /home/mehdi/temp/test/atom-shell-v0.21.2-linux-x64/resources/app/node_modules/sqlite3
node-pre-gyp ERR! node -v v0.11.14
node-pre-gyp ERR! node-pre-gyp -v v0.6.2
node-pre-gyp ERR! not ok
Unsupported target version: 0.21.0
npm ERR! Linux 3.14.27-desktop-1.mga4
npm ERR! argv "/usr/local/bin/node" "/usr/local/bin/npm" "install" "sqlite3"
npm ERR! node v0.11.14
npm ERR! npm  v2.0.0
npm ERR! code ELIFECYCLE
npm ERR<EMAIL_ADDRESS>install: node-pre-gyp install --fallback-to-build
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>install script.
npm ERR! This is most likely a problem with the sqlite3 package,
npm ERR! not with npm itself.
npm ERR! Tell the author that this fails on your system:
npm ERR!     node-pre-gyp install --fallback-to-build
npm ERR! You can get their info via:
npm ERR!     npm owner ls sqlite3
npm ERR! There is likely additional logging output above.

I also tried to change target into 0.21.2 but results was the same.
I guess i'm lost in atom-shell version vs atom-node version vs installed node version!
here is some info:
$ apm -v
apm  0.141.0
npm  2.5.1
node 0.10.35
python 2.7.6
git <IP_ADDRESS>

$ node -v
v0.11.14

$ node-gyp -v
v1.0.2

And finally i tried to run my app to see sqlite related error:

A JavaScript error occured in the browser process
Uncaught Exception:
Error: Cannot find module '/home/mehdi/temp/test/atom-shell-v0.21.2-linux-x64/resources/app/node_modules/sqlite3/lib/binding/node-v41-linux-x64/node_sqlite3.node'
at Function.Module._resolveFilename (module.js:351:15)
at Function.Module._load (module.js:293:25)
at Module.require (module.js:380:17)
at require (module.js:399:17)
at Object. (/home/mehdi/temp/test/atom-shell-v0.21.2-linux-x64/resources/app/node_modules/sqlite3/lib/sqlite3.js:4:15)
at Module._compile (module.js:475:26)
at Object.Module._extensions..js (module.js:493:10)
at Module.load (module.js:370:32)
at Function.Module._load (module.js:325:12)
at Module.require (module.js:380:17)

node_modules/sqlite3/lib/binding/node-v41-linux-x64/node_sqlite3.node ?!!
So please tell what to do?

This process.versions in sample app:

From your first result:
gyp ERR! stack Error: getaddrinfo ENOTFOUND

It was apparently networking problem.
From your third result:
node-pre-gyp install --fallback-to-build
node-pre-gyp ERR! install error
node-pre-gyp ERR! stack Error: Unsupported target version: 0.21.0

Somehow it switched to use node-pre-gyp instead of node-gyp, which doesn't support atom-shell yet.
I suggest reporting this to node-sqlite3 since people there may have better knowledge of this. I'm closing this since it is not a problem of atom-shell.

Could you tell me about versions at least? i mean --target or npm_config_target should be what for atom-shell 0.21.2 ?
Have you notice the screenshot of 0.21.2? isn't version of modules and node weird?
This is the 0.19.0 shot:

Atom-Shell >= 0.12 uses io.js instead of node, so the versions are ok.
sqlite3 uses node-pre-gyp to build, so currently no atom-shell support.
You can build sqlite3 for atom-shell <=0.20.x with https://github.com/bwin/aspm.

For anyone having same issue: http://verysimple.com/2015/05/30/using-node_sqlite3-with-electron/

Thanks, @olimsaidov. Those linked steps worked for me, pasting here for posterity.
cd node_modules/sqlite3
npm run prepublish
node-gyp configure --module_name=node_sqlite3 --module_path=../lib/binding/node-v43-darwin-x64
node-gyp rebuild --target=0.27.1 --arch=x64 --target_platform=darwin --dist-url=https://atom.io/download/atom-shell --module_name=node_sqlite3 --module_path=../lib/binding/node-v43-darwin-x64

Modify for your version of electron and node. I tested with 0.29.1 and v44.

@milesoldenburg where to see the v44? thanks

@fritx It depends on the version you of electron and node you are running. So in my case I just swapped 0.27.1 in the snippet with 0.29.1 and v43 with v44.

ok thanks i will try it @milesoldenburg and also snippet from @olimsaidov

unfortunately i'm on Windows, any guys know how to deal with it? :cry:

For people building sqlite3 for v0.31.0, checkout https://github.com/mapbox/node-sqlite3/issues/498.

@zcbenz thanks finally it worked.. I used the fork:
"dependencies": {
  "sqlite3": "git://github.com/kkoopa/node-sqlite3.git#nan2",
}


[SPARK-31106][SQL] Support is_json function

What changes were proposed in this pull request?
In this PR, I am proposing a JSON function is_json.
This function will check whether a given string is valid JSON string or not. It it is valid it will return true, if it is invalid it will return false. In case of NULL input NULL will be returned.
scala> sql("select is_json('{[]}')").show
+-------------+
|is_json({[]})|
+-------------+
|        false|
+-------------+

scala> sql("select is_json('[1, 2, 3]')").show
+------------------+
|is_json([1, 2, 3])|
+------------------+
|              true|
+------------------+

scala> sql("select is_json(null)").show
+-----------------------------+
|is_json(CAST(NULL AS STRING))|
+-----------------------------+
|                         null|
+-----------------------------+

Why are the changes needed?
This is one the most basic and required functions when we are dealing with JSON data.
Say, user is reading a table then he can segregate the table into rows with valid JSON and rows with invalid JSON. Now user only needs to process on the rows containing valid/invalid JSON.
This function is supported by some popular databases as well. Some of them are :

MySQL
SQL Server
IBM Db2
Sqlite
MariaDB
Amazon Redshift

Does this PR introduce any user-facing change?
Yes, Now users can use is_json() function to verify whether the given JSON string is valid or not.

How was this patch tested?
UT added.

@HyukjinKwon @maropu @dongjoon-hyun @MaxGekk
Kindly review this PR.

Can one of the admins verify this patch?

Can one of the admins verify this patch?

@iRakson, how many functions do you target to add? I would like to avoid adding a bunch of functions just for the sake of matching.

@iRakson, how many functions do you target to add? I would like to avoid adding a bunch of functions just for the sake of matching.

This function and two aggregate functions, if you are ok with these.

json_array_agg and json_object_agg -> These functions can be very useful with Group By queries.

Can you clarify the usage and benefit? in particular, considering we can easily work around via from/to_json

Can you clarify the usage and benefit? in particular, considering we can easily work around via from/to_json

Although these aggregate functions can be a little faster than working around with to_json, I agree implementing them might not worth it. So I will not implement them. Thank you.

is_json will perform better than from_json though, as it is only reading the tokens and nothing else.

Is is_json last one you want to add for now?

Is is_json last one you want to add for now?

Yes.
If we can improve performance significantly using the aggregates then may be those aggregate functions be added.
I already updated the liras for those methods. You can mark them resolved.

ok to test

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/25723/
Test PASSed.

Test build #121032 has started for PR 28167 at commit d427915.

Test build #121042 has started for PR 28167 at commit 6f7d569.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/25733/
Test PASSed.

Test build #121032 has finished for PR 28167 at commit d427915.

This patch passes all tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
case class IsJson(child: Expression) extends UnaryExpression with CodegenFallback

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/121032/
Test PASSed.

Test build #121042 has finished for PR 28167 at commit 6f7d569.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/121042/
Test PASSed.

@iRakson   Could you provide the links?

MySQL
SQL Server
IBM Db2
Sqlite
MariaDB
Amazon Redshift

@iRakson Could you provide the links?

MySQL
SQL Server
IBM Db2
Sqlite
MariaDB
Amazon Redshift

MySQL
SQL Server
IBM Db2
Sqlite
MariaDB
Amazon Redshift
Names may differ across DBMSs.

Names may differ across DBMSs.

How did you decide the is_json name? It seems the name is different from the others in the systems above.

Names may differ across DBMSs.

How did you decide the is_json name? It seems the name is different from the others in the systems above.

Actually ISJSON seemed more intuitive to me. And in order to follow other JSON function names get_json_object, from_json , i chose is_json.
But looking at the other DBMSs function names we can name it valid_json.
WDYT?

I don't have strong preference though, valid_json looks better to me.

Test build #121075 has started for PR 28167 at commit c06abe0.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/25766/
Test PASSed.

Test build #121075 has finished for PR 28167 at commit c06abe0.

This patch passes all tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
case class ValidJson(child: Expression) extends UnaryExpression with CodegenFallback

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/121075/
Test PASSed.

Hi, @iRakson . Please update the PR description with the following information which were requested by @gatorsmile .

https://github.com/apache/spark/pull/28167#issuecomment-611879823

Hi, @iRakson . Please update the PR description with the following information which were requested by @gatorsmile .

#28167 (comment)

Updated.

is_json -> valid_json in the PR description.

is_json -> valid_json in the PR description.

Updated.

Retest this please.

Test build #121288 has started for PR 28167 at commit c06abe0.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/25973/
Test PASSed.

I saw the discussion on the naming in the above comments. The naming is always difficult.
The current one looks like too-Apache-Spark-specific.

VALID_JSON: This PR.
JSON_VALID: MySQL, MariaDB, Sqlite
ISJSON: SQL Server
IS JSON predicate: Oracle, IBM Db2
is_valid_json: Amazon Redshift

@maropu and @gatorsmile . Although VALID_JSON have a correct meaning, shall we avoid adding a new dialect in the SQL world by our hands?

Test build #121288 has finished for PR 28167 at commit c06abe0.

This patch passes all tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
case class ValidJson(child: Expression) extends UnaryExpression with CodegenFallback

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/121288/
Test PASSed.

Yea, thanks for your suggestion, @dongjoon-hyun. Since all the existing names are totally different,
I suggested the clear meaning one. Actually, I'm still not sure we need this function because we already the workaround for this purpose as @HyukjinKwon suggested above.

FYI, IBM Db2 for I is neither DB2 for LUW nor DB2 for zOS. DB2 for I is not widely used. Please get rid of "IBM Db2: IS JSON"

@iRakson @maropu @dongjoon-hyun @HyukjinKwon @MaxGekk I checked the above reference links. They are very helpful. There are many different JSON-related functions? Could we first stop merging new functions first?
Let us do more investigation, discuss which APIs we need to add and why they are needed?

@iRakson @maropu @dongjoon-hyun @HyukjinKwon @MaxGekk I checked the above reference links. They are very helpful. There are many different JSON-related functions? Could we first stop merging new functions first?
Let us do more investigation, discuss which APIs we need to add and why they are needed?

Yeah, I think this is much better approach.

I am good to stop it for now, yes. I have the same concern (https://github.com/apache/spark/pull/28167#issuecomment-611470102).

Thanks, @maropu , @gatorsmile , @iRakson , @HyukjinKwon . +1 for more invesigations on JSON effort.

Since 3.0, we are able to inject functions. Maybe we can create a separate sub-project or third-party project to maintain dialect functions from other platforms instead of adding them directly to Spark. For example, I recently created https://github.com/yaooqinn/spark-func-extras to achieve such a goal(Maybe we can move this project to a proper place to maintain). Functions in this project can overwrite spark builtin ones to keep the meaning of the platforms where they come from if conflicts occur. Also, some function candidates may eventually go into the spark’s master branch if they turn out that they are quite useful and do not conflict.
cc @cloud-fan @maropu, @gatorsmile,  @HyukjinKwon, @dongjoon-hyun, thanks.


Added new theme for (Un)colored : Black-Room Theme

Hello,
I'm really interested in your project so I've tried to create a new theme : the Black-Room Theme.
In the future I'll try to add ChartJs support and pdf export but I have to understand all the code before that.
Thank you for your work !
PS: It's my first time using github so I don't really know if it'll work :)

Hi @Skyeun, thanks a lot for your interest !
Right now and for the past 3-4 months, I'm busy on the next major version, and I really don't think I will release another version before that :(
I was busy extracting (Un)colored core functionnalities and making it a dedicated library (in TypeScript & JavaScript, for Node.js & the browser). It's done, and right now I'm creating a more professional interface (which is dark) under Angular 5. If you wanna help with funtionnalities, keep this framework in mind ;)
Sorry, I can't merge your request for those reasons :( Can you make me a screenshot though so I can see your work ? :)

Hello,
I added the preview image for Black-room theme :)
I'll like a lot to help you with these functionalities but before that, I have to learn Angular and TypeScript :)
I think it's a great idea to create a dedicated library and I'll pay a close attention to your project ;)

@Skyeun I've seen your screenshot the day you posted it (I had no time to answer, and then I forgot, sorry 😟 ), it's really cool 👍 , for the info : the dark theme/mode for version 1.0 is pretty near from that 😉
@almir-campos When version 1.0 development started, I included User Interface (UI) themes management, and pretty quick, big questions kicked in :

How far will theme customization go ? Just colors ? Full CSS ?
Will this affect User eXperience (UX) ?
Is this time consuming to implement, to extend, to maintain ?
Is that coherent with the new professional turn of the software ?

I thought a lot about this, made research, tests, and have answered thoses questions :

I tested colors only and full CSS customization, and both can go pretty far (and wrong) with how the software can look, and degrade its "marketing" image, make it less serious, less professional.
So this leads us to : yes, this will affect UX, and I want to have full control of that.
It's a bit time consuming to implement, but it's not that big of a deal.
No it's not. Professional softwares want to have full control of what users perceive, how, and how fast.

So no, UI themes creation and management will not be a thing for those reasons, but don't worry, a very nice dark theme is already implemented for version 1.0 😉

This is great!


Show more stats

It would be nice to extend the dashboard with a bunch of other stats, such as:

number of unique songs
total minutes played per day / week / month / year
favorite artists / tracks
cycles (when a track was listened to the last time), maybe by drawing a line or arc from the previous day to the current day

I guess the Spotify "Year in Music" does a similar thing, but it would be cool to have it anyway here too :)

Yes! I would love that :) If we could fetch favorite artist's images that would put some color in the dashboard as well. I wonder if there is a Spotify API we can use for that.

There is one but it requires a token. Not sure if there are some public endpoints though.


[keepercore] Aggregation: Allow for

Why
There are scenarios where the aggregation grouping key has to be derived from more than one variable.
Example:
aggregate(cloud.name as cloud, account.name as account, region.name as region, instance_type as type, quota_type : sum(reservations) as reserved_instances_total) (merge_with_ancestors="cloud,account,region"): is("instance_type") and reservations >= 0

The account.name is not necessarily unique. Ideally we could express something like:
aggregate("{account.name} ({account.id})" as account, r

What
tbd
AC
tbd


Test issue1

Waterline version:
Node version:
NPM version:
Operating system:

Comment issue 2

Comment issue 1


Auto release of CausalPy 0.2.3 to PyPI failed

See here https://github.com/pymc-labs/CausalPy/actions/runs/8569317167
Tagging @anevolbap, @juanitorduz, @jpreszler as I won't be able to get to this until next week 😭

Not this weekend 🙈😞. I'll try early next week (never release or deploy on Fridays 😅)

Based on a quick look, I think changing the download-artifact@v3 to V4 in the release yaml may fix things. The artifact is being uploaded with V4 and based on https:// github.com/actions/download-artifact there are breaking changes and mixing the two is problematic.

Based on a quick look, I think changing the download-artifact@v3 to V4 in the release yaml may fix things. The artifact is being uploaded with V4 and based on https:// github.com/actions/download-artifact there are breaking changes and mixing the two is problematic.

Agreed. The version mismatch arises from issue #310. It could be reverted, or we could simply update the version of download-artifact to V4. I can do either of the two.

Agreed. The version mismatch arises from issue #310. It could be reverted, or we could simply update the version of download-artifact to V4. I can do either of the two.

Happy for you to take this on. It's outside my area of expertise.

@drbenvincent, there is an open PR (#316) that reverts the problematic changes and hopefully fixes the auto-release issues.

@drbenvincent, there is an open PR (#316) that reverts the problematic changes and hopefully fixes the auto-release issues.

Great stuff. Thanks for the speedy response. In theory, if I merge this and manually trigger the release workflow, that should maybe upload 0.2.3 to pypi without having to do another version bump?

Hmmm, re-ran the GitHub action, but that failed again

The step Build source distribution seems to still be using the older versions (e.g. chechout@v4 instead of v3), like it is cached. Is it possible to run it from scratch?

I manually uploaded 0.2.3 to pypi. So the current version is now available to pip install :)


Rustic redesign

@zachlatta This is still in progress. Would love to get your input on the design so far!

@zachlatta what do you think?

I think it's super cool, but going to stick with the current design for the archived site. Here's a screenshot of the beaut Max made in this PR for posterity:

Haha! Did your scheme work?

Yes! I'll update the README
--
Zach Latta
https://zachlatta.com http://zachlatta.com
@zachlatta https://twitter.com/zachlatta / fb
https://www.facebook.com/crynix / github https://github.com/zachlatta
On Thu, Mar 18, 2021 at 11:22 AM Ishan Goel @.***>
wrote:

Haha! Did your scheme work?
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
https://github.com/zachlatta/ponzies/pull/1#issuecomment-802016053, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AAHSH6FW6K7UXZYSMN4QYOLTEILDHANCNFSM4BWLR7RQ
.


Add a failing test for sort-prop-types

E.g, we are using this pattern on the Material-UI repository.

In your example, the propTypes aren't referenced anywhere in the function.

We do not follow variables references, so with this pattern the propTypes order is not checked.

We do not follow variables references

@yannickcr Will this be fixed in the future? Or should we just not use this pattern.

In your example, the propTypes aren't referenced anywhere in the function. Is that reflective of your actual code?

@ljharb This is the actual code. I have removed the reference. I wanted to be consistent with the other tests.

Will this be fixed in the future? Or should we just not use this pattern?

We only have access to the AST and it is tricky to follow variables references, so it is not planned to support them. But you can still open an issue for it, if there is enough demand for this feature we could try to see if it is feasible.
If you want to be able to use the prop-types related rules (like prop-types or sort-prop-types) you should avoid this pattern for now, sorry :|

I agree, it's not straightfoward.
Still, we have access to the scope. I think that it can be done in simples cases like this one.
E.g. This is how I'm doing it with babel: https://github.com/oliviertassinari/babel-plugin-transform-react-remove-prop-types/blob/master/src/index.js#L75.
Sure, I'm gonna open an issue. Thanks.


Add custom place to Nearby

Sometimes I hear about an interesting non-famous place on the local news.

But still, I would like to have a way to remember it in the future.
Nearby seems like a good place to put such information. I should be able to long-press anywhere on the map and add the new point's label.
There are many ways to implement backend storage:

Locally in the app's database. Easy, but points get lost at each reinstall
On the SD card on the phone. A bit awkward and lost when people change phones.
As a list in a sub-page of the user. In such case we should be clear that these points are publicly visible and linked to the user.
As a global list shared by all users of the app. Same warning as above.

In any case, loading should happen in parallel with Wikidata SPARQL loading, and points should start showing up as soon as the first points start arriving.
Low priority.

I am working

@Anil-Praharaj21 can you share your approach here? :) @nicolas-raoul suggested 4 ways to implement the feature and it would be great if we could first reach a consensus on which method we should go with.

I am thinking to save it in the database or we can go for Bookmarked it


avm and setting implicit keyvault secrets for connection strings #611

In azd, we allow the user to pass a keyvault reference when creating a cosmos database. If they do provide one, then we set a keyvault secret that contains the connection string.
That way the user doesn't have to do that in their own bicep.
It's not necessary, but certainly makes for a seamless experience for users, so they don't have to think about doing so on their own.
You can see that in action here: https://github.com/Azure/azure-dev/blob/main/templates/common/infra/bicep/core/database/cosmos/cosmos-account.bicep#L34
It would be nice if avm did the same.

@jongio, this issue was transferred to the BRM repo, as it relates to a feature request to a module. Please note that the avm/res/document-db/database-account module is yet to be migrated from CARML. Since no module owner has volunteered to take care of this one yet, please expect delays in both the migration and the addition of the requested feature.

@jongio, this issue was transferred to the BRM repo, as it relates to a feature request to a module. Please note that the avm/res/document-db/database-account module is yet to be migrated from CARML. Since no module owner has volunteered to take care of this one yet, please expect delays in both the migration and the addition of the requested feature.

Plese note, a draft PR popped up in the meantime: https://github.com/Azure/bicep-registry-modules/pull/667

I'm picking up this issue as the module was already migrated and owner assigned

I'm picking up this issue as the module was already migrated and owner assigned

Thanks, ping if you have any questions

@bryansan-msft - Do you have an ETA on this one?

@jongio There is a pull request already open that include this one #1407. It should be this week hopefully tomorrow


Support for JavaScript BigInt in BigNumber Constructor

Currently, the constructor of the BigNumber library is complaining when using the native JavaScript BigInt type in TypeScript. When trying to create a BigNumber instance using a BigInt value (e.g., new BigNumber(100n)), it throws an error or does not behave as expected.
Expected Behavior
I would expect that the constructor of BigNumber should accept JavaScript's native BigInt type and initialize a BigNumber instance accordingly. For example:
const bigNumber = new BigNumber(100n);

Actual Behavior
Passing a BigInt to the constructor currently results in an error or is not handled appropriately. It seems that the library does not recognize BigInt as a valid input type.
Rationale
JavaScript introduced the BigInt type in ES2020 to handle arbitrarily large integers, which aligns well with the goals of the BigNumber.js library. Allowing the BigNumber constructor to accept BigInt would simplify the interaction between native JavaScript types and the BigNumber library, making it easier for developers to work with large numbers.
Currently, developers need to manually convert BigInt to string (or other types) before passing them to BigNumber, which feels unnecessary and counterintuitive, given the overlapping functionality between BigInt and BigNumber.
For example, instead of doing:
const bigNumber = new BigNumber(100n.toString());

It should be possible to do:
const bigNumber = new BigNumber(100n);

Proposal
Update the constructor of BigNumber to accept the BigInt type and convert it internally to the appropriate format for BigNumber. This change would improve usability and modernize the library to align with newer JavaScript features.
Additional Information
JavaScript BigInt documentation: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/BigInt
Let me know if this feature could be considered or if there's a workaround for this in the current version. Thank you!

What version are you using, or perhaps you are using TypeScript, because passing a BigInt to the constructor works for me?

This is most likely a TS issue yes.
I think the best solution would be to update the types since JS is known for casting variable types in weird ways. It should be ensured that BigInts are treated properly

I have just merged and pushed a previous pull request that added support for BigInt to the types. I will publish later this week after deciding whether to accept another PR that adds a toBigInt method.

Looks like you merged and then reverted the toBigInt PR? I don't see that in the history though...
Is there still a chance that feature makes it in?

Looks like you merged the PR.
Could you publish this version to npm? Would love to install it asap 😄

I've published a forked version of it with the correct type.
I think you'd want to use bigint and not the constructor of the type (BigInt)
I published a version with this fix since I needed this asap and was getting tired of always converting BigInts to string 😂

@Moicky
Okay, thanks for letting me know that I had merged another crappy PR.


Wallet provider

This is also "bigger than it looks" since we are just injecting the wallet provider into eth service rather than having it inside.


Example project code fails to run with Jest 28

Hello,
I'm trying to upgrade to jest 28 but I can't make it work.
I've created a new blank project with minimum libraries but the test fails in the "chalk" library, maybe it needs update? Or why is it even trying to use import inside a function, it just doesn't make sense.
This is the full error log:
C:\Users\juraj\git\addons\_bugzilla\mockzilla>npx jest
 FAIL  ./some.test.ts
  ● Test suite failed to run

    Jest encountered an unexpected token

    Jest failed to parse a file. This happens e.g. when your code or its dependencies use non-standard JavaScript syntax, or when Jest is not configured to support such syntax.

    Out of the box Jest supports Babel, which will be used to transform your files into valid JS based on your Babel configuration.

    By default "node_modules" folder is ignored by transformers.

    Here's what you can do:
     • If you are trying to use ECMAScript Modules, see https://jestjs.io/docs/ecmascript-modules for how to enable it.
     • If you are trying to use TypeScript, see https://jestjs.io/docs/getting-started#using-typescript
     • To have some of your "node_modules" files transformed, you can specify a custom "transformIgnorePatterns" in your config.
     • If you need a custom transformation specify a "transform" option in your config.
     • If you simply want to mock your non-JS modules (e.g. binary assets) you can stub them out with the "moduleNameMapper" config option.

    You'll find more details and examples of these config options in the docs:
    https://jestjs.io/docs/configuration
    For information about custom transformations, see:
    https://jestjs.io/docs/code-transformation

    Details:

    C:\Users\juraj\git\addons\_bugzilla\mockzilla\node_modules\chalk\source\index.js:1
    ({"Object.<anonymous>":function(module,exports,require,__dirname,__filename,jest){import ansiStyles from '#ansi-styles';
                                                                                ^^^^^^

    SyntaxError: Cannot use import statement outside a module

      at Runtime.createScriptFromCode (node_modules/jest-runtime/build/index.js:1796:14)
      at Object.<anonymous> (node_modules/mockzilla/dist/node.js:7:33)

Test Suites: 1 failed, 1 total
Tests:       0 total
Snapshots:   0 total
Time:        0.403 s
Ran all test suites.

The minimal example project:
mockzilla.zip
Thank you!

Or maybe the Chalk needs downgrade, as I'm looking at their npm page:

IMPORTANT: Chalk 5 is ESM. If you want to use Chalk with TypeScript or a build tool, you will probably want to use Chalk 4 for now. Read more.