Framework stuck at broker reconciling state

We had several occasions where the mesos slave with running broker got restarted, the framework tries to reconcile the broker task, then the framework got restarted while the broker state is "reconciling" (saved in zk), after that the framework will be stuck due to the reconciling broker state which wasn't reconciling at all. It will not start any brokers even though the broker is no longer running, the only way I found to fix this is to manually go into zk /kafka-mesos node and delete all the "task" broker attributes that contains "reconciling" state from the brokers json.
The code causing this problem:
https://github.com/mesos/kafka/blob/master/src/scala/main/ly/stealth/mesos/kafka/scheduler/mesos/TaskReconciler.scala#L124
Maybe it should resume the reconciliation or remove the check all together, rather than do nothing if the state is reconciling.

Is it actually stuck?  The default reconciliation timeout is pretty high, 30 minutes I think.  Can you attach broker logs from before/after the framework restart?

All the brokers are no longer running, but the framework zk state remembered a broker in reconciling state, so when the framework restart it won't start any broker again as long as a single broker state is stuck in reconciling, and it is no longer recoverable because of the above mentioned line. (if any broker state is in reconciling the framework won't schedule any future reconciliation, and since the broker is no longer running the reconciling state is stuck there forever)

@steveniemitz Any thought? You can easily recreate the problem by having a framework with 1 running broker, stop the framework first, then kill the broker, manually change the broker state from running to reconciling in zookeeper /kafka-mesos, start the framework and it will be stuck.
I would suggest removing the if part and always do startImpl() in https://github.com/mesos/kafka/blob/master/src/scala/main/ly/stealth/mesos/kafka/scheduler/mesos/TaskReconciler.scala#L124
not sure if there's any side-effect though.

It's very likely to happen when there is a rolling restart of the mesos slaves, say you have 2 slaves: slave01 and slave02, broker is running on slave01 and framework running on slave02.

slave01 got restarted (broker killed and lost)
framework start reconciling with broker
while it is still reconciling, slave02 got restarted
framework start after slave02 got back, but stuck forever due to the reconciling state.

Here is an example state from /api/broker/list
{
  "brokers": [
    {
      "id": "21",
      "active": true,
      "cpus": 1,
      "mem": 3072,
      "heap": 2048,
      "syslog": false,
      "constraints": "hostname=like:.*slave01.*",
      "options": "",
      "log4jOptions": "",
      "jvmOptions": "",
      "stickiness": {
        "period": "864000s",
        "hostname": "slave01.mycluster.com"
      },
      "failover": {
        "delay": "60s",
        "maxDelay": "10m",
        "failures": 0
      },
      "task": {
        "id": "kafka-21-27ae8058-b0b8-48a3-9d94-eac6e30db749",
        "slaveId": "400ac0f4-9bf6-435c-a227-51a9b559e22d-S3",
        "executorId": "kafka-21-a35bc7ce-8bf2-4016-9f43-6f41aad154d9",
        "hostname": "slave01.mycluster.com",
        "endpoint": "slave01.mycluster.com:10023",
        "attributes": {},
        "state": "reconciling"
      },
      "metrics": {
        "timestamp": 0
      },
      "needsRestart": false
    }
  ]
}

Stopping the broker does not work (/api/broker/stop), since it only changes the active field from true to false, the task section will stick around, and when I start the broker it won't do anything.
The only relevant log I got after framework restart is
2017-06-15 15:16:14,871 WARN           TaskReconciler] Reconcile already in progress, skipping.

The log before the framework restart won't matter, as long as you time it to kill the framework when a broker is reconciling (for any reason), then when you start the framework again it will stuck.
We are using mesos 0.28.2, from my understanding reconciliation is framework driven, so as long as the framework skip it in the startup if block, then the reconciliation can never complete.


How correct set vmagent_scrape_config ?

Hello! Thanks for roles vm
I try install vmagent by ansible and get error
Inventory
all:
  children:
    vm-single:
      hosts:
        "victoriametrics":
          ansible_host: "xxxx"
  vars:
    ansible_user:  ubuntu
    ansible_ssh_private_key_file: ~/.ssh/id_rsa
    vmagent_scrape_config:
      node:
      - targets:
        - localhost:9100
    prometheus_components: [ "prometheus", "node_exporter" ]
.....

Playbook
---
- hosts: vm-single
  collections:
    - victoriametrics.cluster
  become: true
  roles:
    - role: cloudalchemy.node_exporter
    - role: victoriametrics.cluster.vmagent

ansible error
TASK [victoriametrics.cluster.vmagent : Ensure vic-vmagent service started] ************************************************************************************************************
Monday 11 April 2022  18:36:37 +0600 (0:00:01.264)       0:00:59.164 **********
fatal: [victoriametrics]: FAILED! => changed=false
  msg: |-
    Unable to start service vic-vmagent: Job for vic-vmagent.service failed because the control process exited with error code.
    See "systemctl status vic-vmagent.service" and "journalctl -xe" for details.

systemctl status vic-vmagent
● vic-vmagent.service - Description=VictoriaMetrics vmagent service
     Loaded: loaded (/etc/systemd/system/vic-vmagent.service; enabled; vendor preset: enabled)
     Active: failed (Result: exit-code) since Mon 2022-04-11 12:36:39 UTC; 1min 0s ago
    Process: 1677 ExecStart=/usr/local/bin/vmagent-prod --remoteWrite.url=http://localhost:8428/api/v1/write --promscrape.config=/opt/vic-vmagent/config.yml --remoteWrite.tmpDataPath=>
   Main PID: 1677 (code=exited, status=255/EXCEPTION)

Apr 11 12:36:39 victoriametrics systemd[1]: vic-vmagent.service: Scheduled restart job, restart counter is at 5.
Apr 11 12:36:39 victoriametrics systemd[1]: Stopped Description=VictoriaMetrics vmagent service.
Apr 11 12:36:39 victoriametrics systemd[1]: vic-vmagent.service: Start request repeated too quickly.
Apr 11 12:36:39 victoriametrics systemd[1]: vic-vmagent.service: Failed with result 'exit-code'.
Apr 11 12:36:39 victoriametrics systemd[1]: Failed to start Description=VictoriaMetrics vmagent service.
Apr 11 12:36:39 victoriametrics systemd[1]: vic-vmagent.service: Start request repeated too quickly.
Apr 11 12:36:39 victoriametrics systemd[1]: vic-vmagent.service: Failed with result 'exit-code'.
Apr 11 12:36:39 victoriametrics systemd[1]: Failed to start Description=VictoriaMetrics vmagent service.

cat /opt/vic-vmagent/config.yml
#Ansible managed

node:
-   targets:
    - localhost:9100
```

Please, take a look at prometheus documentation for scrape_config - https://prometheus.io/docs/prometheus/latest/configuration/configuration/#scrape_config
VMagent uses same format for config as described here - https://docs.victoriametrics.com/vmagent.html#how-to-collect-metrics-in-prometheus-format
Default value for this variable is:
vmagent_scrape_config:
  scrape_configs:
    - job_name: localhost
      static_configs:
        - targets: []
#          - "<IP_ADDRESS>:9100"

Where you will need to add your jobs and respective targets to scrape_configs section.

Thanks!


Fix Bird output for gateway metrics

Description
Bird is adding headers to the output of any of its commands. This cause problem while parsing the metrics via show protocol all. The first protocol was not parsed correctly, so it was ignored.
BIRD 2.0.10 ready.
Name       Proto      Table      State  Since         Info
Issue link
Checklist

Purpose

[x] Bug fix
[ ] New functionality
[ ] Documentation
[ ] Refactoring
[ ] CI

Test

[x] Unit test
[ ] E2E Test
[ ] Tested manually

Introduce a breaking change

[ ] Yes (description required)
[x] No

Looks okay.


[4.0] Fix Quaternions init from vector

We already get these inits from the imported (C) struct definition, so having them in the overlay extension merely results in a false ambiguity.
rdar://problem/33758735 Cannot call simd_quatf(vector: ...) in Swift 4
[for swift-4.0-branch]
Explanation: Remove unnecessary inits that cause ambiguity.
Scope: Local to the simd overlay
Radar: 33758735
Risk: Very Low.

@swift-ci Please test


Run chromeless script only in aws and periodically

Hi,
I'm a newbie and sorry for my english.
Thanks a lot for this work, i succeeded to run chromeless script locally and remotely from my pc to aws lambda but i would try to run a chromeless script directly in aws, not remotely from my computer or from another website. i would like call this function (with cloudwatch?) periodically. is it possible?
I don't understand all and how it works! Perhaps it's similar to #307 issue.
thanks for your replies

@steftroubadour I succeeded to do it.
And as a contribution to the community, I created a skeleton project for calling chromeless from AWS Lambda, from which anyone can start: Calling chromeless from AWS Lambda function

thanks a lot @eitansela , it works like a charm!
Now, It only remains for me to understand all! :)


iterating over tf.Tensor is not allowed

Please make sure that this is a bug. As per our
GitHub Policy,
we only address code/doc bugs, performance issues, feature requests and
build/installation issues on GitHub. tag:bug_template
System information

Have I written custom code (as opposed to using a stock example script provided in TensorFlow): Yes
OS Platform and Distribution (e.g., Linux Ubuntu 16.04):
Mobile device (e.g. iPhone 8, Pixel 2, Samsung Galaxy) if the issue happens on mobile device:
TensorFlow installed from (source or binary):
TensorFlow version (use command below): 2.3
Python version:3.8
Bazel version (if compiling from source):
GCC/Compiler version (if compiling from source):
CUDA/cuDNN version:
GPU model and memory:

You can collect some of this information using our environment capture
script
You can also obtain the TensorFlow version with:

TF 1.0: python -c "import tensorflow as tf; print(tf.GIT_VERSION, tf.VERSION)"
TF 2.0: python -c "import tensorflow as tf; print(tf.version.GIT_VERSION, tf.version.VERSION)"

Describe the current behavior
I have a dictionary that I build by accessing only the channel dimensions of an output layer of a convolutional neural network (it has a shape (100,24,24,6) )
Therefore keys of this dictionary are tuples of tensor shape (6, ) . I want to map these keys to the input of the next layer using the tf.map_fn(). However, i am incapable of doing it because the keys of my dictionary are of type tensor and i cannot iterate over them .
Looking for some help. Thank you.
Describe the expected behavior
Contributing

Do you want to contribute a PR? (yes/no):
Briefly describe your candidate solution(if contributing):

Standalone code to reproduce the issue
Provide a reproducible test case that is the bare minimum necessary to generate
the problem. If possible, please share a link to Colab/Jupyter/any notebook.
Other info / logs Include any logs or source code that would be helpful to
diagnose the problem. If including tracebacks, please include the full
traceback. Large logs and files should be attached.

Hi @saylideshmukh ! Could you please provide a standalone code to reproduce this issue?

Hi @saylideshmukh ! Is this issue #53910 is duplicate to this feature request?

Yes

Hi @mohantym I realized that I can try to access the tf.Tensor objects by delaying my python function i.e. delaying the execution of the do_mapping function. Any idea regarding this?

@saylideshmukh ! Could you provide the gist of solution you are working on and close the duplicate feature request #53910 ?

Hello @mohantym I have a built a custom layer and trained it by just passing the outputs of the previous layer to the custom layer and then recording these output values so that i can observe them . i use a dictionary for observing. I observed that most of the values in the channel dimension of output values are similar. So in my custom layer build i encode a dictionary (vmap)that have these enumerated similar values . Now i want to freeze all the previous layers to the custom layer and retrain my model by passing my encoded dictionary values (vmap) to the inputs of the preceding layer of the custom layer. For this purpose i need to map my enumerated values using tf.map_fn to the input channel dimension of the preceeding layer. The problem i am having is while trying to iterate over the keys of the dictionary(vmap), which are tuple of 6 tf.Tensor objects. I want to access this tf.Tensor objects of the key tuple.
I have tried the eager execution and decorating my mapping function with tf.decorator so that i can iterate over these tf.Tensor objects . But the error i get is :TypeError: You are attempting to use Python control flow in a layer that was not declared to be dynamic. Pass dynamic=True to the class constructor.
Encountered error:
"""
iterating over tf.Tensor is not allowed in Graph execution. Use Eager execution or decorate this function with @tf.function.
Here is the gist of the custom layer Class :
class valuemaplayer(keras.layers.Layer):
def init(self,data_format = None,**kwargs):
super(valuemaplayer,self).init(**kwargs)
self._vmap = {}
self._data = []
self._compression = True
self.data_format = conv_utils.normalize_data_format(data_format)
def build(self, input_shape):
        pass

def enable_compression(self):
    value = list(self.get_values())
    vmap = self._vmap
    cnt = 0

    for v0 in value:
        for v1 in v0:
            for v2 in v1:
                for v3 in v2:
                    v = tuple(v3)
                    if v not in vmap:
                        vmap[v]=cnt
                        cnt+=1
    self._compression = True

@tf.function
def do_mapping(self,pixel):
    if self._compression :       #can i make this python free if cond?
        pixel = tuple(pixel)
    # to do convert pixel(of channel axis) from tensor to a tuple

    for en in range(len(pixel.shape)) :   #can i make this in tf.range of tf.while_loop cond?
        enumerated_value=self._vmap.get(pixel)
    return enumerated_value

@tf.function
def call(self, inputs, training=True):#use eager execution or decorate with @tf.function
    if self._compression:
            # input_shape = inputs.get_shape()
            # input_channel = self._get_input_channel(input_shape)
            # channel_axis = self._get_channel_axis()
        inputs = tuple(inputs[-1,-1,-1,:])

        # TODO check if channel axis gets mapped by tf.map_fn
        #resize inputs to 2 axis, 1 for each pixel and other channel , work on each pixel
        changed_inputs = tf.map_fn(self.do_mapping(pixel=self._vmap.keys()), elems=inputs,fn_output_signature=tf.TensorSpec)
    return changed_inputs
    # # else compression is disabled
    # # in case we're training, we do not want to observe values
    if not training:
        self._data.append(inputs)
    return inputs

    # get values of the output of value map layer
def get_values(self):
    for d in self._data:
        try:
            d = d.numpy()
        except AttributeError:
            continue
    yield d


[dsx] metadata - renamed BCC to BCH (DO NOT MERGE YET)

@timmolter am waiting for the exchange to update one of the API endpoints (https://dsx.uk/mapi/info) that has the old names it it still


Typescript syntax highlighting failing

VSCode Version: 1.7.2
OS Version: OSX El Capitan 10.11.5

Steps to Reproduce:
Not sure as of yet.
When turning on typescript.tsserver.trace to true I get the following error:
[Trace - 11:46:51 AM] Response received: quickinfo (27). Request took 4 ms. Success: false . Message: Error processing request. Project '/Users/amamut/Projects/gambit/tsconfig.json' does not contain document '/users/amamut/projects/gambit/typings/globals/angular/index.d.ts'
I can say right now that the file in question definitely exists in '/Users/amamut/Projects/gambit/typings/globals/angular/index.d.ts'. Notice how in the message the directory is lowercased. I am not sure if that is what is causing the issue but after updating to 1.7.2 my highlighting broke. I will continue to debug and see if I can find more information. I was just hoping someone ran into this problem and was able to remedy.
My tsconfig's include property:
"include": [     "src/**/*.ts",     "typings/**/*.d.ts"   ]
Thanks!

Closing because it looks like it came back on its own without changing anything.


Migrate to new s3 URL method

Path based access has been deprecated and now returns a redirect error to bucketname.s3.amazonaws.com
as explained in this post:
https://aws.amazon.com/blogs/aws/amazon-s3-path-deprecation-plan-the-rest-of-the-story/
This makes cloudformation to fail as it refers to the now redirected s3
bucket path, and raises the message:
S3 error: The bucket you are attempting to access must be addressed using the specified endpoint. Please send all future requests to this endpoint. For more information check http://docs.aws.amazon.com/AmazonS3/la
There is no strong documentation about what are the updates in China and
Gov regions, consider it follows the same logic.

Codecov Report

Merging #1873 into v0.16.x will decrease coverage by 0.00%.
The diff coverage is 0.00%.

@@             Coverage Diff             @@
##           v0.16.x    #1873      +/-   ##
===========================================
- Coverage    24.41%   24.40%   -0.01%
===========================================
  Files           98       98
  Lines         5116     5117       +1
===========================================
  Hits          1249     1249
- Misses        3727     3728       +1
  Partials       140      140

Impacted Files
Coverage Δ

pkg/api/assets.go
0.00% <0.00%> (ø)

pkg/api/region.go
0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f2781f8...f553e94. Read the comment docs.

/assign @dominicgunn

@tjamet could you please also patch 0.15.x and 0.14.x?

@Fsero yes sure, did this first one for the approach to focus discussion and planned to do so when convergence on the solution

Thanks for doing this @tjamet! The approach here seems good.
/lgtm

Thanks for doing this @tjamet! The approach here seems good.
/lgtm


Sample code that runs perfectly in JS API 4.17 does not work as expected in JS API 4.18

Hello everyone,
One of our customers is using JS API 4.18 in Angular environment.
He claims that running the code in: https://developers.arcgis.com/javascript/latest/sample-code/sandbox/index.html?sample=styling-icon-fonts
works fine in native JS but in Angular the objects are not displayed immediately. They are displayed only after performing Zoom operation (zoom in, zoom out).
In order to reproduce it, you can create an Angular project, copying the HTML code from the sample and see the issue.
They also claim that in JS API 4.17, it worked fine. Only 4.18 has this issue.
The question is why doesn't it work the same as in 4.17? i.e. Display the graphics immediately after adding them to the map, without the need in zoom operation.
Thanks,
Miri

Hi @MiriEshel, thanks for reporting. This is a known issue that we hope to address at 4.19 (April).

I ran into the same thing and had put this together to demonstrate if it helps:  https://codepen.io/jwerts28/pen/JjbRVVw

Thanks for letting us know @jwerts.

Hi, I'm running into the same problem :/

If removing and then adding featurelayer it does not redraw until zoom.

(if I do a timeout on first layer add I can see the layer.. something like this:
    void this.view.when().then(() => {
      setTimeout(() => {
        void this.view.goTo(this.realTimeLayer().graphics).then(() => {
       // do stuff...
        });
      }, 400);
    });

however after first draw if I try to click on something that I have drawn, it vanishes :/
( i have some code that changes color on a point marker, after vanishing the first time it appears, and everything works fine.)
April is pretty far away, is there someone that has a workaround for this until then?

Thanks for the additional info @Cyberdada. We are actively looking into this.

@MiriEshel @Cyberdada we believe we fixed this bug. Can you retest using npm install @arcgis/core@next?

@andygup Now I get this error :
[esri.assets] The API assets location needs to be set using config.assetsPath.
:/
(assets have been configured in angular.json as described in documentation, this error did not come up in 4.18 )
This is the relevant part of the log:
Logger.js:5 [esri.assets] The API assets location needs to be set using config.assetsPath. More information: https://arcg.is/1OzLe50
_consoleWriter @ Logger.js:5
_log @ Logger.js:5
errorOnce @ Logger.js:5
a @ assets.js:5
get thumbnailUrl @ basemapDefinitions.js:5
u @ read.js:5
read @ JSONSupport.js:5
read @ Basemap.js:5
c @ JSONSupport.js:5
fromJSON @ JSONSupport.js:5
fromId @ Basemap.js:5
f @ basemapUtils.js:5
castBasemap @ Map.js:5
_cast @ Properties.js:5
set @ Properties.js:5
set @ subclass.js:5
t @ set.js:5
t @ set.js:5
set @ Accessor.js:5
postscript @ Accessor.js:5
p @ subclass.js:5
push../src/app/plugins/map/esri/services/esri-map-initialize.service.ts.EsriMapInitializeService.factory @ esri-map-initialize.service.ts:48

It works :) I got a bit confused at first because a got an error about the assetsPath, that I did not get earlier, but then I checked out the documentation and added the assetsPath setting, now all is working great :)

Closing as fixed at 4.19.

Hi @dougkpowers yes it's confirmed fixed. Do you have a codepen or github repo that reproduces the issue?


Add ability to send monitoring data to VictoriaMetrics

Gatling supports sending monitoring data to InfluxDB. It would be great adding the ability to send monitoring data to VictoriaMetrics, since it usually requires lower compute resources (RAM, CPU, disk space, disk IO) compared to InfluxDB - see these benchmarks and these case studies for details. VictoriaMetrics supports data ingestion via multiple popular protocols:

Influx line protocol
Graphite plaintext protocol
OpenTSDB protocol
Prometheus text exposition protocol
CSV
JSON
See these docs for details.

It would be great if gatling could send monitoring data to VictoriaMetrics via one of these protocols. The ingested data then can be queried via Prometheus-compatible query language - MetricsQL. VictoriaMetrics supports Prometheus querying API (see these docs) and Graphite querying API (see these docs).

We already support Graphite plaintext protocol.
Any additional metrics and reporting features fall into the scope of our Enterprise version.


chore: release v0.0.1

🤖 New release

robot-hat-rs: 0.0.1

Changelog

0.0.1 - 2023-11-17
Other

update Cargo.toml
delete old action file, bcz not working
Update rust.yml
Create rust.yml
update ci.yml
Update ci.yml
update docs
Create ci.yml
update docs
impl pin abstraction for robot-hat pins
add initial ultrasonic impl
create cargo lib
Update README.md
Create LICENSE-APACHE
Create LICENSE-MIT
Initial commit

This PR was generated with release-plz.

Generate again with up-to-date commits, deleting this


feat: modeled payments

Adds:

Generic Validator class that tests lambdas against data and tracks the results in a ValidationResult
A PaymentMessage class that models input on /api/v1/payment and allows syntactic validation
A PaymentService that does all the work instead of doing it all in the controller

Removes:

ENV keys for now in favor of static keys (because the current solution handles secrets. that's not needed - better not handled in server-side programs)
GET /api/v1/payment because that doesn't do anything
All logic from the controllers... better to use services that have logic (and will need async) than trying to solve that in an express controller straight.

ACK clean af


Append Push Url to create clean urls for multifaceted searches/filters

Question
So I have a multi-faceted checkbox filter and I have successfully managed to get this all working and filtering correctly.
the last piece of the puzzle I am however, stuck on. That is pushing/appending the url to reflect the options checked. Everything I try it seems to just replace the url and not append the query-string with the option checked.
So some examples are:
I have a Geographic Location that contains multiple checkboxes and when checked these would like so in the URL (in the address bar). ?location=europe+worldwide+asia
The above would filter out Europe and Worldwide and Asia
I have a Process and Operation that contains multiple checkboxes and when checked these would like so in the URL (in the address bar). location=europe+worldwide+asia&process=anerobic-digestion+centrifuges
The above would filter out Anerobic Digestion and Centrifuges in  Europe and Worldwide and Asia
There are a few more categories and filters but the above should give a good example/gist of the issue.
It would also be nice to include the entry type and limit too, but not essential.
The problem is I cannot seem to get the s-push-url correct to just either append the query-string if it already has options or write it new if not. So for example, if you already have a location selected.as europe. When you check Worldwide I want the url to change from website.com/products/?location=europe to website.com/products/?location=europe+worldwide
If you did not have any locations select them I would need the url to add the ?location= part.
The same would apply for any other query-strings and append or create them.
I have tried numerous approaches, but cannot crack it. Here are some I have tried.
s-push-url="{{ '?' ~ {location: locationQueryString ~ '+' ~ entry.slug} }}"
s-push-url="{{ craft.app.request.queryParam('location') ? '+' ~ entry.slug : craft.app.request.absoluteUrl ~ '?location=' ~ entry.slug }}"
 s-push-url="{{ craft.app.request.queryString ? '&' : '?location=' }}{{ locationQueryString|length ? '+' ~ entry.slug : entry.slug }}"

However, each time it just change the full Url to last selected option as an example.
If I entered website.com/products/?location=europe into my browser and then checked the worldwide, it would change/push the url to website.com/products/?location=worldwide but I want it to be website.com/products/?location=europe+worldwide
Whilst I appreciate I can set the s-push-url="true" I would like some cleaner/friendly urls.
Any ideas Ben? Or any easy way to achieve this or get clean urls from s-push-url="true" instead?

You should probably be using the sprig.pushUrl(url) function to achieve this:
{% set params = {
    location: location,
} %}
{% do sprig.pushUrl('?' ~ params|urlencode) %}

See this video in which I explain this approach:
https://putyourlightson.com/sprig/videos#7.-pushing-url-updates

Thanks for this Ben.  Brilliant. I did re-watch the video on CraftQuest and it made sense.
I have managed to resolve this now.
Thanks again. Sprig is awesome and you are amazing.


Create ultrasound.js extension

Adds grouping and allows load from urls

Not much use for this extension when the same can be accomplished with the upcoming Sound+ extension. There’s also not many blocks for messing with audio…

How does this compare to https://github.com/TurboWarp/extensions/pull/672?

How does this compare to #672?

Outdated comment, I meant Audio Engine from lily

How does this compare to #672?

Outdated comment, I meant Audio Engine from lily

Yeah I have 2 sound extensions, don't get em mixed up lol


Investigating the implementation of HL7

💬 Questions and Help
We need to understand how to implement HL7 standard in our APIs.

[ ] HL7 v2 (messages)
[ ] HL7 v3 CDA (XML) Releases: R1, R2
[ ] HL7 v4 FHIR (JSON + REST) Releases: R1, R2, R3 & R4

@bazuzu666 let's write down the motivations. It have to be clear for newcomers why we need to support these standards.

HL7 = Health Level 7 (seven because it corresponds to level 7 of ISO-OSI model)
It is the international standard for clinical data interchange, created to move information about patient data and to standardise the interoperation between various hospital wards and systems.
HL7 versions

v1 was only used for a proof of concept implementation and served to define the content and structure of the standard.

v2 messages are encoded and composed by segments, segments are composed by fields. Each field starts with a pipe symbol and it has a fixed position but some may be optional and some may repeat. Each field has a data type and if it is empty, the pipe maintains its position.
Examples of segments below:

MSH (Message Header)
EVN (Event Description)
PID (Patient Identification)
PV1 (Patient Visit Information)
AL1 (Patient Allergy Information)

v3 messages are encoded in XML composed by a Header, containing information about the document itself and providing info on authentication, patient and so on, and by a Body, which contains the clinical report and can be either an unstructured blob or a structured markup. The body is composed by section elements each containing narrative blocks (human readable, the content to be rendered) and any number of CDA entries (structured computer-processable components)
Es:

<ClinicalDocument>
  ... CDA Header ...
  <structuredBody>

      <text>...</text>
      <observation>...</observation>
      <substanceAdministration>
        <supply>...</supply>
      </substanceAdministration>
      <observation>
        <externalObservation>...
        </externalObservation>
      </observation>

...

  </structuredBody>
</ClinicalDocument>

v4 is the newest standard called FHIR (Fast Health Interoperability Resources) and it adheres to RESTful design principles. It supports both XML and JSON. FHIR has many components of CDA, but they are separated into smaller more manageable pieces. When reading data, the biggest difference from CDA is that FHIR provides atomic data access, meaning that instead of needing to transmit and parse huge files, you can use FHIR and make a specific request of a single observation and get that only.

They decided to have v3 non-compatible with v2, so it means that existing 2 interfaces will not be able to communicate with newer v3. Compatibility between v3 & v4 is under investigation. I think they created a new digital divide where apps that need to speak v4 will also need v2 & v3 interfaces to communicate. Moreover each of the three versions comes with multiple revisions.

v1-3
Great place for fastify endpoints in #154 .

See hl7-db for an expressjs example without massaging the data into a different schema.
See transform-pouch for mutating/massaging the database data.
See pouch-box psp crypto-pouch TweetNACL for possible cryptography options

v4
We will get for free in CouchDB but all other message endpoints must adapt incoming messages to our final specification.

Can we set an ETA for a POC of this integration? We need to expose a specific fastify-plugin.

Hi All,
I work in the Healthcare Interoperability/Integration space and have experience with HL7 v2, CDAs, and FHIR. I'm not super familiar with the tech stack in HospitalRun but I would love to learn more.
What are the motivations for implementing HL7 standards? Are there any workflows/integrations you are hoping to support? Integrating Healthcare Enterprises (IHE) describes a number of profiles  below which might be helpful to give some context to the integration. https://wiki.ihe.net/index.php/Profiles
I think picking one of these profiles that you think would be useful and then implementing one of the actors would help to limit the scope and add valuable context for the implementation.
I'd be really interested to dig in. Let me know if you want to discuss this further.

Hi Jeremy! Thanks for reaching us. We are going to implement HL7 for sure, starting from FHIR. We already have some internal discussion about this since day one. I would really appreciate if you want to join us. We use our slack as primary communication channel. May I invite you to join it?

I can also help with this. We have implemented both HL7 v2 as well as FHIR integrations at BetterPT.


Formly Reset the Errors on Focus Out for Prime Input Mask

Formly Reset the Errors on Focus Out for Prime Input Mask
https://stackblitz.com/edit/angular-ljcdzn-3r3fwu?file=src%2Fapp%2Fapp.component.ts,src%2Fapp%2Finput-mask.component.ts,src%2Fapp%2Fapp.component.html
By default, I have set the invalid error to true on model changes to the inputMask field and input field. When we enter the value and focus out, the error bound to the inputMask is vanishing, whereas for the input field, it is retaining the error .

@aitboudad  can you help on above issue .

The issue is not from Formly side, Prime Input Mask clear the existing validation when unmask is passed


Please invite me to the GitHub Community Organization

Name
Noval Ramdhani
Discord Username (if applicable)
No response
Additional Context
Web programming enthusiast.

Welcome to ChryzHub @novalramdhani .🥳🎉
We are happy to have you onboard🤗


White, dark tiles craftable

About the PR
White and dark tiles can now be crafted via the crafting menu in-game.
Added white and dark tile recipes in Resources/Prototypes/Recipes/Crafting/Graphs/tiles.yml
Uncommented white and dark tile recipes in Resources/Prototypes/Recipes/Crafting/tiles.yml and changed the description
Changelog

Added dark and white tile recipes out of 1 steel tile in the crafting menu.

:cl: ninruB
good lord I think I made several mistakes while submitting the PR and making the changes themselves.

I am feeling incredibly anxious and I am still uncertain about the ID's in Resources/Prototypes/Recipes/Crafting/Graphs/tiles.yml
material: FloorTileItemSteel in both the dark and white tile recipes and if it all works properly or not.

Would it not be better to have those tiles crafted the same way steel tiles are, rather than this extra step?

Would it not be better to have those tiles crafted the same way steel tiles are, rather than this extra step?

I originally thought that it'd be better to make it like you said, but then I thought that it'd be much more versatile if you could say, pry some tiles off the floor and craft them into dark ones instead of making them via steel.
I also considered to make recipes for them both via steel and steel tiles, but I thought that'd clog up the tile tab with too much duplicate recipes.

failing linter, also changelog is formatted backwards, otherwise lgtm

Supposedly fixed the 2 linter isues that occured

Yeah, I'm giving up on the idea of using steel tiles since I can't find the god forsaken ID.
I'm just going to use steel for the recipe and close this PR since if it gets merged there will be about 10 extra commits that aren't necesarry.


Applied feedback from Lesson One.

Added more explanation of for loops.
Added more explanation about variables.
Added some further-reading-style exercises.

A good example to add at the bottom is a for loop with an if statement, might be worth adding?

I like it.

Done, with another mind-bendy thingy.

Yes.


Code flow analysis isn't smart enough

typescript version: Version 1.9.0-dev.20160424
first looks like a bug:
if (options.leftJoin)
    Object.keys(options.leftJoin).forEach(key => {
        qb.leftJoin(options.leftJoin[key], key);
    });

Gives TS2531: Object is possibly 'null' or 'undefined'., however error is not expected because of the if (options.leftJoin) check above.

second:
connect(options?: ConnectionOptions) {
    if (!options)
        options = {} as ConnectionOptions;

    console.log(options.url);
}

Gives same TS2531: Object is possibly 'null' or 'undefined'.. Looks like expected behaviour because of original type of the options object. Solution is to define variable with a new type and without undefined. Maybe there is a smarter way to do it?

I did a quick test with alm. Looks good to me:
type ConnectionOptions = {url:string}
function connect(options?: ConnectionOptions) {
    if (!options)
        options = {} as ConnectionOptions;

    console.log(options.url);
}

Proof

I'm also experiencing the same error as the second example using ||:
export function patch<R>(path: string, options?: HTTPOptions): Promise<HTTPResponse<R>> {
    options = options || {};
    options.method = 'PATCH'; // error options can be null or undefined

    let req = new HttpRequest<R>(path, options);
    return req.request();
}

In addition, the options is HTTPOptions | undefined when I inspect it. Though it is giving me the error that it can be null or undefined. Slight incorrect since it cannot be null.

@pleerock Regarding the first issue, control flow analysis doesn't consider a type guard to hold across a callback (because the callback could happen at any time, including outside the guarded block). This is different and more conservative from what we've previously done, and we're certainly open to feedback about whether it is too conservative. Meanwhile, you probably want to capture the guarded variable in a local and then reference that in the callback:
if (options.leftJoin) {
    const leftJoin = options.leftJoin;
    Object.keys(leftJoin).forEach(key => {
        qb.leftJoin(leftJoin[key], key);
    });
    ...
}

Regarding your second example, I can't tell how ConnectionOptions is defined and in particular whether it is a union type that includes null and undefined. However, assuming ConnectionOptions is just a plain object type, your example compiles with no error as expected. Looks like that is what @basarat is seeing too.
@tinganho Your example compiles fine for me (but I suspect you have an older nightly build).

@basarat are you on the typescript version as me? Because it looks weird that I get this error and you are not. I used same code as you and I get an error. Proof:

@ahejlsberg thank you, got the problem of the first issue. For the second issue I have same code as basarat which does not compile

@pleerock I can also compile @basarat 's example correctly.
$ tsc -v
Version 1.9.0-dev.20160424

tinganho at Tiens-MacBook-Pro in ~/Development/Mount on master [!?]
$ cat test.ts
type ConnectionOptions = {url: string}
function connect(options?: ConnectionOptions) {
    if (!options) {
        options = {} as ConnectionOptions;
    }

    console.log(options.url);
}
tinganho at Tiens-MacBook-Pro in ~/Development/Mount on master [!?]
$ tsc test.ts

The strange thing is that it doesn't work on my IDE VSCode Insider:

I have defined in my workspace settings:
{
	"typescript.tsdk": "/usr/local/lib/node_modules/typescript/lib",
}

It appears the current typescript@next (1.9.0-dev.20160424) still doesn't contain the control flow type analysis logic (there's no getFlowTypeAtReference function in the tsc.js file). Don't know why, something must have gone awry on the nightly build server.
@mhegazy Mohamed, any ideas?

@tinganho You need to specify --strictNullChecks on the command-line to repro @pleerock's issue.

Yes got it now.

Looks like we have not published a nightly since 4/12. the script is publishing without updating. looking into it.

are you on the same typescript version as me

@pleerock I am actually on nTypeScript https://github.com/TypeStrong/ntypescript which is just a build of TypeScript/master with some automation I did before official typescript@next but continue to use because I like to experiment with non public / non supported / cutting edge APIs :rose:

We've identified and fixed the issue with the nightly build server. Tonight's build should be good and will contain the control flow type analysis logic.

confirming that it works with the last build

@pleerock thanks for the confirmation.

@ahejlsberg @yuit This doesn't work in nightly TypeScript - is it a related issue or should I file as a new bug?
let maybeNumber: number | undefined;
(function () {
	maybeNumber = 1;
})();
if (maybeNumber) {
	maybeNumber++; // -> says that type of `maybeNumber` is always `nothing`, not even `number | undefined` anymore
}

@RReverser this is not covered in OP. control flow analysis is localized, and does not track side effects from other functions. feel free to file a new issue though.

@mhegazy Well, I don't expect it to be smart enough to refine maybeNumber to number, but I also don't see why compiler might assume that maybeNumber becomes nothing after such call - preserving number | undefined seems more reasonable to me.

Filed at https://github.com/Microsoft/TypeScript/issues/8381.

the issue is it does not know about the side effects. you would want it to catch something like:
let maybeNumber: number | undefined;
if (maybeNumber) {
    maybeNumber++; // there is no way the control flow would reach here.
}

@mhegazy Hmm, can't it assume that declared variable type was preserved on unknown side effects?

the declared variable type is always there. but then control flow "narrows" it down. so:
let maybeNumber: number | undefined;

maybeNumber // it is undefined here, though it is defined as a number | undefined, there are no initialization to a non-undefined value.

maybeNumber  = 1;  // it is number definitely

maybeNumber  ++; // allowed, as it is definitely a number

if (maybeNumber === undefined) {
    maybeNumber  // here it is nothing, i.e. there is no way for the control flow to reach here, as it was a number, and number does not include undefined.
}

@mhegazy Yeah, I understand why in:
let maybeNumber: number | undefined;
if (maybeNumber) {
    maybeNumber++; // there is no way the control flow would reach here.
}

it fails - it's obvious that control flow won't reach here because maybeNumber is undefined at that point.
However, I would expect compiler to assume number | undefined in my initial example (this actually "broke" my working code) - if it's unsure about side effects, then treat variable type after the call as per its initial declared type and not keep the type as it was before the call.

yup, i think we are saying the same thing. and that is what #8381 is tracking.

@mhegazy Cool, thanks. Just wanted to be sure we're on the same page / I'm not getting anything wrong.

Hi, I hit this error too. I understand the reasoning behind not carrying the reduced type over closures but non the less it looks very counter intuitive.
My case is with returning a closure, which should be safe.
function getLengthLambda(x: any[]|null) {
    if (!x) {
        return () => 0;
    }

    return () => x.length + 1; // <--- error TS2531: Object is possibly 'null'
}

getLengthLambda([]);

I have just encountered the problem with _.isEmpty:
    if (_.isEmpty(childrenDescription)) {
        return null;
    }

    return childrenDescription.map( // Here I get TS2531: Object is possibly 'null' or 'undefined`, which is wrong
        (childDescription, index) => createChild(childDescription, index)
    );

@108adams It's just a problem of poor definition, not of TypeScript itself.
For example, if I define helper like
declare function isEmpty(x: any): x is null | undefined;

it can already catch these cases and control flow will know that anything after the check is at least non-null.


Update SystemVM scripts from python2 to python3

Description

Considering that Python 2.7 will not be maintained in 2020 (will be retired on 1st January 2020) next VR template should have Python3 installed to support python3 scripts; additionally, VR's Python2 codebase should be migrated to Python3.

This PR covers partially issue #3195.

Types of changes

[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] New feature (non-breaking change which adds functionality)
[ ] Bug fix (non-breaking change which fixes an issue)
[x] Enhancement (improves an existing feature and functionality)
[ ] Cleanup (Code refactoring and cleanup, that may add test cases)

some pylint errors in travis job 1, mostly requiring extra blank lines at places @GabrielBrascher .

@GabrielBrascher can you give an indication on this. as we are out of time for python2 now?
how much more work needed and should it be reviewed yet!

@DaanHoogland it still needs some work and testing, therefore, we can wait a bit for reviewing it.
I will be testing it tomorrow to re-assess the state; the plan is to address the pending points until the end of the week.

this should be coordinated with #3797

@GabrielBrascher any update for us, you still working on this? Thanks.

Sorry for the late reply, @rhtyd. I just fixed conflicts and ported to the current master.
I am now performing tests and if all goes right I shall have this PR ready for review soon.

UPDATE: After updating the code I was able to build the System VM template and test it (on KVM).
Environment: KVM
Network type: Advanced with security groups
Test - Deploy VMs and assert that User VM gets IPv6 address correctly:

Deploy VM on a network (let's call this network of python3) with no VR
VR is deployed, health check scripts are all good
User VM is deployed on the Python3 network
SSH on IPv6 address works

Based on the test result, this PR I am moving it from "Draft" to "ready for review". With that said, I encourage reviewers to check the code and test SystemVMs with the Python3 changes ;-)
Note: there are still pending tests such as VR for Basic networks, Advanced networks without SG, VPCs, etc. Additionally, I have not tested this template on SSVM or CPVM.

Travis is failing due to pycodestyle failures: https://travis-ci.org/github/apache/cloudstack/jobs/715011759
I will address these "checkstyle" issues soon and update the PR.

Pycodestyle has passed after last commit. Jenkins and Travisa are looking good.
This one is ready for review/tests.

Current Travis Pylint errors are related to the fact of Pylint evaluating a, supposedly, Python2 code.
pylint  --disable=R,C,W configure.py
No config file found, using default configuration
************* Module configure
E: 24, 0: No name 'request' in module 'urllib' (no-name-in-module)
E: 24, 0: Unable to import 'urllib.request' (import-error)
E: 25, 0: No name 'parse' in module 'urllib' (no-name-in-module)
E: 25, 0: Unable to import 'urllib.parse' (import-error)
E: 26, 0: No name 'error' in module 'urllib' (no-name-in-module)
E: 26, 0: Unable to import 'urllib.error' (import-error)
E: 81,23: Undefined variable 'urllib' (undefined-variable)
E: 82,26: Undefined variable 'urllib' (undefined-variable)
E: 84,27: Undefined variable 'urlopen' (undefined-variable)

-------------------------------------------------------------------
Your code has been rated at 9.39/10 (previous run: 10.00/10, -0.61)

If Travis had pylint3, then it would be evaluating a Python3 code. I get the following result on pylint3
pylint3  --disable=R,C,W configure.py
No config file found, using default configuration

-------------------------------------------------------------------
Your code has been rated at 10.00/10 (previous run: 9.39/10, +0.61)

:arrow_down: The same applies for the errors raised by Travis regarding passwd_server_ip.py:
pylint  --disable=R,C,W passwd_server_ip.py
No config file found, using default configuration
************* Module passwd_server_ip
E: 34, 0: No name 'parse' in module 'urllib' (no-name-in-module)
E: 34, 0: Unable to import 'urllib.parse' (import-error)
E: 36, 0: Unable to import 'http.server' (import-error)
E: 37, 0: Unable to import 'socketserver' (import-error)

-------------------------------------------------------------------
Your code has been rated at 8.60/10 (previous run: 10.00/10, -1.40)

vs pylint3
pylint3  --disable=R,C,W passwd_server_ip.py
No config file found, using default configuration

-------------------------------------------------------------------
Your code has been rated at 10.00/10 (previous run: 8.60/10, +1.40)

@blueorangutan package

@GabrielBrascher a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

Packaging result: ✔centos7 ✔debian. JID-1715

@GabrielBrascher can you hacve a look at the conflict?

@DaanHoogland updated this PR fixing the conflict with master.

@blueorangutan package

@GabrielBrascher a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

Packaging result: ✔centos7 ✔centos8 ✔debian. JID-2082

@blueorangutan test

@DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

@GabrielBrascher I see pylint errors again in travis job 1, can you have a look?

@GabrielBrascher @wido @rhtyd @weizhouapache @PaulAngus python3 work in general has been neglected for a while. Are we still going to push it for 4.15?
@blueorangutan package

@DaanHoogland I have been able to run some tests on the Advanced network with security groups, and a few tests on the basic network. But it still lacking some tests on advanced networks with VPC, etc.
With that said, I think that we will need a couple more months and also more review/test.

Packaging result: ✔centos7 ✖centos8 ✔debian. JID-2222

@GabrielBrascher that would mean moving to the next milestone!

@DaanHoogland correct! I migrated it to 4.16 so we don't wait longer to release 4.15.

@blueorangutan package

@GabrielBrascher a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

Packaging result: ✔centos7 ✔centos8 ✔debian. JID-2673

@GabrielBrascher can we close this?


Feature Request: Toggle Python Interactive Prompts in Code Blocks

Description
The Python documentation features a helpful UI element that allows users to show or hide the interactive Python prompts (>>>) within code blocks. This feature is beneficial for readers who wish to copy and paste code samples without manually removing the prompts. I propose adding similar functionality to  enhance the user experience for technical documentation, particularly for Python projects.
Proposed Functionality

Add a toggle switch/button in the UI to show/hide interactive Python prompts.
The feature could utilize custom CSS classes and JavaScript to selectively hide elements marked as prompts.
Provide a global setting in mkdocs.yml for the site or a per-page option to enable this feature for specific code blocks or for all code blocks.

Use Cases

Readers can easily copy code samples without the Python shell prompts, streamlining the experience of using code examples from the documentation.
Improves the readability of code blocks by allowing users to focus on the code itself, free from REPL-specific syntax.
Enhances the functionality, aligning it with features provided by official Python documentation and other technical documentation tools.

Additional Context
This feature is demonstrated in the Python official documentation. Here is an example where the feature is utilized:
Decimal — Decimal fixed point and floating-point arithmetic
Thank you for considering this feature request. I believe it would be a valuable addition

Hello, thanks for the feature request :)
We have this CSS example in the docs: https://mkdocstrings.github.io/recipes/#prevent-selection-of-prompts-and-output-in-python-code-blocks, to prevent selection of prompts in pycon code blocks.
But the Copy button will still copy the prompts I think. So we might want to provide something involved indeed.

oh would I have to copy and paste the css in an mkdocs extra css file and then it works?

Yep, exactly :slightly_smiling_face:

got it!
we can't put it in the package anyway and then turn it on or off via mkdocs config?

Generally speaking, it's good if we can avoid adding tons of options. For now I'll hold on it, especially since it's just one line of CSS to copy-paste to a file, and one line in mkdocs.yml to add it to the site. Also, the issue of the "Copy" button still copying the prompts is not resolved.
I'll think about how to add a Toggle button like in the Python docs, because actually hiding the prompts also makes it work for the copy button :slightly_smiling_face:


fine tune next/previous navigation for first/last index in accessible view

          > @rperez030 thanks for testing. isn't the fact that it tells you the length sufficient given you know it's reached the end (if index = length) or beginning (if index = 1)?

Wrapping around doesn't sound ideal to me either. Let's see there are 3 elements, and I'm focus on 2 of 3. If I press the next command, the widget gets refocused, and it announces focused 3 of 3. Good until here. If I press the next command again, the widget gets refocused, but since there is no real change, position information is not reannounced. In other words, If I'm not sure the current element is the last one, pressing the next command will not help me. I would need to go backwards to get confirmation on what's going on.
One way of resolving this would be repeating the position information when I press any of the commands, even if there is no change.
Another possibility would be to prevent the widget from refocusing when I am in the first / last element, and I try to move beyond that element. In that way pressing the next command will not produce any feedback if I am in the last one, and the previous will not produce any feedback if I am in the first one.
Does it make sense? In any case, this would be a refinement, not something that would prevent someone from using the feature.
Originally posted by @rperez030 in https://github.com/microsoft/vscode/issues/189090#issuecomment-1654614578

          > @rperez030 thanks for testing. isn't the fact that it tells you the length sufficient given you know it's reached the end (if index = length) or beginning (if index = 1)?

Wrapping around doesn't sound ideal to me either. Let's see there are 3 elements, and I'm focus on 2 of 3. If I press the next command, the widget gets refocused, and it announces focused 3 of 3. Good until here. If I press the next command again, the widget gets refocused, but since there is no real change, position information is not reannounced. In other words, If I'm not sure the current element is the last one, pressing the next command will not help me. I would need to go backwards to get confirmation on what's going on.
One way of resolving this would be repeating the position information when I press any of the commands, even if there is no change.
Another possibility would be to prevent the widget from refocusing when I am in the first / last element, and I try to move beyond that element. In that way pressing the next command will not produce any feedback if I am in the last one, and the previous will not produce any feedback if I am in the first one.
Does it make sense? In any case, this would be a refinement, not something that would prevent someone from using the feature.
Originally posted by @rperez030 in #189090 (comment)

Something else to consider when fine tuning the responses. Right now, position information is announced using an alert in macOS, and a status message in Windows. This is a situation where it makes sense to use an alert in all platforms so that screen readers prioritize this over other events. For example, right now JAWS is announcing position information after reannouncing the widget.

Huh, @rperez030 I'm using alert for all platforms here
https://github.com/microsoft/vscode/pull/189090/files#diff-4efbc8603e9ad007329781c173d2c4ea5e830b895d0796780a8c8bf9a28ffc5eR266-R268
which appears to be platform agnostic
https://github.com/microsoft/vscode/blob/41c7fc34e084dad4087760597516ffbeaba0b155/src/vs/base/browser/ui/aria/aria.ts#L47-L61
I think it might just be a JAWS issue - does this repro when using NVDA?

It doesn't, but NVDA handles aria-live differently. You may be right dough. I'll debug NVDA on Monday and we'll know for sure which event it is seeing. JAWS may be simply prioritizing the focus event.
On Jul 28, 2023, at 12:03 PM, Megan Rogge @.***> wrote:

Huh, @rperez030https://github.com/rperez030 I'm using alert for all platforms here
https://github.com/microsoft/vscode/pull/189090/files#diff-4efbc8603e9ad007329781c173d2c4ea5e830b895d0796780a8c8bf9a28ffc5eR266-R268
which appears to be platform agnostic
https://github.com/microsoft/vscode/blob/41c7fc34e084dad4087760597516ffbeaba0b155/src/vs/base/browser/ui/aria/aria.ts#L47-L61
I think it might just be a JAWS issue - does this repro when using NVDA?
—
Reply to this email directly, view it on GitHubhttps://github.com/microsoft/vscode/issues/189105#issuecomment-1655938821 or unsubscribehttps://github.com/notifications/unsubscribe-auth/AJH5KGTPQFZXWXAFAIR5UMTXSPPELBFKMF2HI4TJMJ2XIZLTS2BKK5TBNR2WLJDUOJ2WLJDOMFWWLO3UNBZGKYLEL5YGC4TUNFRWS4DBNZ2F6YLDORUXM2LUPGBKK5TBNR2WLJDUOJ2WLJDOMFWWLLTXMF2GG2C7MFRXI2LWNF2HTAVFOZQWY5LFUVUXG43VMWSG4YLNMWVXI2DSMVQWIX3UPFYGLAVFOZQWY5LFVEZDKNRRGI4TSOJTURXGC3LFVFUGC427NRQWEZLMQKSXMYLMOVS2SMZRGY4DCMZTGY2KI3TBNVS2S2DBONPWYYLCMVWIFJLWMFWHKZNJGMZDSMRSGU4DONFENZQW2ZNJNBQXGX3MMFRGK3FMON2WE2TFMN2F65DZOBS2YSLTON2WKQ3PNVWWK3TUUZ2G64DJMNZZLAVEOR4XAZNKOJSXA33TNF2G64TZUV3GC3DVMWUDIMJYHAYTSMBQQKSHI6LQMWSWS43TOVS2K5TBNR2WLKRRHAZDKMZSGA2TAOECUR2HS4DFUVWGCYTFNSSXMYLMOVS2SMRVGYYTEOJZHEZYFJDUPFYGLJLMMFRGK3FFOZQWY5LFVEZTCNRYGEZTGNRUQKSHI6LQMWSWYYLCMVWKK5TBNR2WLKJTGI4TEMRVHA3TJJ3UOJUWOZ3FOKTGG4TFMF2GK.
You are receiving this email because you were mentioned.
Triage notifications on the go with GitHub Mobile for iOShttps://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Androidhttps://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

Friendly ping! Looks like this issue requires some further steps to be verified. Please provide us with the steps necessary to verify this issue.

To verify, focus an accessible view that has several elements to navigate (like chat responses). Continue to press next even though you're on the last element. Verify that it repeats the index to you.

This bug has been fixed in the latest release of VS Code Insiders!
@meganrogge, you can help us out by commenting /verified if things are now working as expected.
If things still don't seem right, please ensure you're on version e7756c8870ee1df7360e6624e220534174039b02 of Insiders (today's or later - you can use Help: About in the command palette to check), and leave a comment letting us know what isn't working as expected.
Happy Coding!

Focus an accessible view for which there are several elements (like chat responses or notifications). Verify that if you are on the first or last element, pressing next or previous does not result in repeated alerts. it should not notify the screen reader user as nothing has changed.

Note to verifier there's an issue to disable these actions when they cannot be taken, which is the better fix.

Verified. With NVDA, if I press enter on the Next button while on the last chat response, the focus goes back to the response text instead of staying on the button, though that might be by design.


Problem with larger Strings mbedtls_aes_crypt_cbc concurency on ISR/Timer  (IDFGH-9423)

Answers checklist.

[X] I have read the documentation ESP-IDF Programming Guide and the issue is not addressed there.
[X] I have updated my IDF branch (master or release) to the latest version and checked that the issue is present there.
[X] I have searched the issue tracker for a similar issue and not found a similar issue.

IDF version.
4.4.4
Operating System used.
Windows
How did you build your project?
Command line with idf.py
If you are using Windows, please specify command line type.
CMD
Development Kit.
esp32 wrover psiram
Power Supply used.
External 5V
What is the expected behavior?
mbedtls aes_crypt_cbc very large strings are breaking ISR concurrent calls.
Core  1 register dump:
PC      : 0x40093534  PS      : 0x00060633  A0      : 0x80098031  A1      : 0x3ffbfbb0
0x40093534: memcpy at /builds/idf/crosstool-NG/.build/HOST-x86_64-w64-mingw32/xtensa-esp32-elf/src/newlib/newlib/libc/machine/xtensa/memcpy.S:275
A2      : 0x00000000  A3      : 0x749f128c  A4      : 0xf0599579  A5      : 0x00000000
A6      : 0x00e04cc0  A7      : 0xe04cc000  A8      : 0xe04cc000  A9      : 0x3ffbfb10
A10     : 0x0000000a  A11     : 0x00000001  A12     : 0x00000000  A13     : 0x00001000
A14     : 0x3ffbfb03  A15     : 0x00000001  SAR     : 0x00000008  EXCCAUSE: 0x0000001d
EXCVADDR: 0x00000000  LBEG    : 0x4009352d  LEND    : 0x4009354f  LCOUNT  : 0x0f059956
0x4009352d: memcpy at /builds/idf/crosstool-NG/.build/HOST-x86_64-w64-mingw32/xtensa-esp32-elf/src/newlib/newlib/libc/machine/xtensa/memcpy.S:272
0x4009354f: memcpy at /builds/idf/crosstool-NG/.build/HOST-x86_64-w64-mingw32/xtensa-esp32-elf/src/newlib/newlib/libc/machine/xtensa/memcpy.S:290
Backtrace: 0x40093531:0x3ffbfbb0 0x4009802e:0x3ffbfbc0 0x40098b5a:0x3ffbfbe0 0x400842e6:0x3ffbfc10 0x400843e5:0x3ffbfc40 0x401507a5:0x3ffbfc60 0x4015084c:0x3ffbfc80 0x400d97c9:0x3ffbfcb0 0x40084091:0x3ffbfcd0 0x4000bfed:0x3ffee5f0 0x4009b6e9:0x3ffee600 0x40178a16:0x3ffee620 0x40178b3d:0x3ffee640 0x400dd0b4:0x3ffee680 0x400ebb0c:0x3fff7970
0x40093531: memcpy at /builds/idf/crosstool-NG/.build/HOST-x86_64-w64-mingw32/xtensa-esp32-elf/src/newlib/newlib/libc/machine/xtensa/memcpy.S:274
0x4009802e: prvCopyDataFromQueue at D:/Dropbox/esp-idf/components/freertos/queue.c:2326
0x40098b5a: xQueueReceiveFromISR at D:/Dropbox/esp-idf/components/freertos/queue.c:1968
0x400842e6: lock_acquire_generic at D:/Dropbox/esp-idf/components/newlib/locks.c:142
0x400843e5: _lock_acquire at D:/Dropbox/esp-idf/components/newlib/locks.c:163
0x401507a5: adc1_rtc_mode_acquire at D:/Dropbox/esp-idf/components/driver/adc_common.c:406
0x4015084c: adc1_get_raw at D:/Dropbox/esp-idf/components/driver/adc_common.c:431
(inlined by) adc1_get_raw at D:/Dropbox/esp-idf/components/driver/adc_common.c:427
0x400d97c9: periodic_timer_adc_callback at D:/Dropbox/esp-idf/Dev/PRODUCAO/main/user_main.c:2180
(inlined by) periodic_timer_adc_callback at D:/Dropbox/esp-idf/Dev/PRODUCAO/main/user_main.c:2170
0x40084091: _xt_lowint1 at D:/Dropbox/esp-idf/components/freertos/port/xtensa/xtensa_vectors.S:1114
0x4009b6e9: vPortClearInterruptMaskFromISR at D:/Dropbox/esp-idf/components/freertos/port/xtensa/include/freertos/portmacro.h:571
(inlined by) vPortExitCritical at D:/Dropbox/esp-idf/components/freertos/port/xtensa/port.c:332
0x40178a16: esp_aes_release_hardware at D:/Dropbox/esp-idf/components/mbedtls/port/aes/block/esp_aes.c:68
0x40178b3d: esp_aes_crypt_cbc at D:/Dropbox/esp-idf/components/mbedtls/port/aes/block/esp_aes.c:259
TOTAL SIZE TO BE ENCRYPTED STRLEN from a STRING [37475]
invove from: mbedtls_aes_crypt_cbc
What is the actual behavior?
execute everything right, not crash because the system is on load, even on interruption ISR running, so, the AES should be slowed and others functions keeped.
with smallers strings it is working perfect.
Steps to reproduce.
4 interruptions running.
ADC reading while timer interrupt
gpio interrupt on every 8000us
Debug Logs.
no logs.

More Information.
The problems is on the routing of MBED with all others functions runnign together.

Hi @filzek Can you please provide a small sample code that may help in reproducing the issue?
Thanks,
Aditya

run adc on timer handle reading by 100 times on each of 6 adc channel. every 1/32 sec, to timer will be dispatch 32 times per second. read 100 times each of 6 channels.
in another task also run udp multicast sender and receive.
in another task gpio interrupt handle.
in a http task try to encrypt a psiram object of 1mb of pure text.
crash happen.
we tried everything to solve but was unable.
it giver

Hi @filzek Can you please provide a small test code.
I am unable to reproduce this at my end.
The issue you see looks like that it is only reproducible under certain conditions.
If you could provide some small test build then it would definitely speed up the process of providing a fix.
Thanks,
Aditya

Hi @filzek I am unable to reproduce the issue at my end.
Please provide a small test code if possible.
I will close down the issue. Feel free to re-open the issue if the problem is not solved at your end.
Thanks,
Aditya


There is sound notifications during downloading

When file is in process of downloading there is a sound for every batch of data
I/flutter ( 1201): Download task (c49d7308-7b8f-4654-8281-d55bcc74cbe8) is in status (DownloadTaskStatus(2)) and process (56)
W/Notification( 1201): Use of stream types is deprecated for operations other than volume control
W/Notification( 1201): See the documentation of setSound() for what to use instead with android.media.AudioAttributes to qualify your playback use case

I use
Flutter (Channel dev, v0.5.7, on Mac OS X 10.12.6 16G29, locale en-NL)
Android toolchain - develop for Android devices (Android SDK 27.0.3)
And I run your package on Android devices only - emulator Nexus 5 and my mobile Samsung Galaxy S7.

The problem comes from setting the priority of Notification from Android O. I haven't ever tested on that OS version, but it should be fixed by adding a line of code. I have just published a new version to fix it. Let me know if it works

yep. It is fixed. I've checked only on devices that I mentioned above.


Updates to the FakeDir.create_file and FakeDir.create_folder methods

When you add an element to a FakeDir with one of these methods, nothing is returned.  So if you want to work with the object you just created, its kind of silly:
import seedir as sd
r = sd.randomdir()
r.create_file('new_file.txt') # None is returned
f = r['new_file.txt'] # you have to enter the name again; this gets worse for nested paths

It would be nicer if these methods simply returned the created object:
import seedir as sd
r = sd.randomdir()
f = r.create_file('new_file.txt')

Another point is that these methods currently allow you to create multiple files or folders using a list/collection (as shown here), but the docstrings don't reflect that (they imply that only a string can be passed in order to create one item).
But I guess the return request will have to be rectified with the potential for more than one item being created.  Presumably if you create one folder, you want that item to be directly returned (and not that item within a list or something).  Whereas if you create multiple items at once, you would either need to return a collection of references (or nothing at all).  One approach might be to add separate create_files and create_folders (note the plural) which manage creation of multiple items?

Added in 205f278.  Rather than adding new methods (with confusingly similar names), I just stayed with the original methods.  If only one folder/file is created, that object is directly returned.  If more are created, a list of objects is returned.


Article and spreadsheet naming number differs

The CA-Persona-Internals is CA100 on the docs page but CA200 on the spreadsheet. I know these are examples but it might confuse people.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: a7fac997-1920-f24e-767a-13755b794f85
Version Independent ID: a7fac997-1920-f24e-767a-13755b794f85
Content: Conditional Access framework and policies - Azure Architecture Center
Content Source: docs/guide/security/conditional-access-framework.md
Service: architecture-center
Sub-service: azure-guide
GitHub Login: @clajes
Microsoft Alias: clajes

@dogborne Thanks for the feedback. We are investigating the issue and will update you shortly.

thanks for the comment, I fully agree and will update and do a PR

It appears this was addressed. Please reopen with additional details if still experiencing issues.


No intellisense, code lens or completion when script in sub folder

It seems I get completion if a script (*.fsx) file is in the same folder as a *.fsproj project but none if it is in a sub folder. For example in the following solution I have to identical script files PowerPeriod.fsx and NodatTime.fsx but I only get intellisense in the latter.

Neither script file is added to the project. For the PowerPeriod.fsx the Language service logs report Cached Typecheck result not yet available
  [09:08:27 DEBUG] REQ (689) -> {unusedDeclarations}, File ="~\src\ValueAdd\scripts\PowerPeriod.fsx" Data={"FileName":"d:\\Appdev\\ValueAdd\\src\\ValueAdd\\scripts\\PowerPeriod.fsx"}
  [09:08:27 DEBUG] REQ (690) -> {simplifiedNames}, File = "~\src\ValueAdd\scripts\PowerPeriod.fsx" Data={"FileName":"d:\\Appdev\\ValueAdd\\src\\ValueAdd\\scripts\\PowerPeriod.fsx"}
 [09:08:27 DEBUG] RES (687) <- {tooltip} in 15 ms: Kind={"info"} Data="Cached typecheck results not yet available"
 [09:08:27 DEBUG] RES (690) <- {simplifiedNames} in 12 ms: Kind={"info"} Data="Cached typecheck results not yet available"
 [09:08:27 DEBUG] RES (688) <- {unusedOpens} in 13 ms: Kind={"info"} Data="Cached typecheck results not yet available"
 [09:08:27 DEBUG] RES (689) <- {unusedDeclarations} in 13 ms: Kind={"info"} Data="Cached typecheck results not yet available"
 [09:08:28 DEBUG] REQ (691) -> {declarations}, File = "~\src\ValueAdd\scripts\PowerPeriod.fsx" Data={"FileName":"d:\\Appdev\\ValueAdd\\src\\ValueAdd\\scripts\\PowerPeriod.fsx","Lines":["#I \"C:/Users/C24701/.nuget/packages\"\r","#r \"Newtonsoft.Json/lib/net45/Newtonsoft.Json.dll\"\r","#r \"nodatime/2.2.2/lib/net45/NodaTime.dll\"\r","#load \"../Prelude.fs\"\r","\r","open System\r","open System.Globalization\r","open NodaTime\r","open NodaTime.TimeZones\r","\r","let tz =BclDateTimeZone.FromTimeZoneInfo(TimeZoneInfo.Local)\r","tz.\r",""],"Version":60}
 [09:08:28 DEBUG] RES (691) <- {declarations} in 6 ms: Kind={"declarations"} Data=[{"Declaration"{"UniqueName":"PowerPeriod_1_of_1","Name":"PowerPeriod","Glyph":"Module","GlyphChar":"N","IsTop evel":true,"Range":{"StartColumn":1,"StartLine":1,"EndColumn":1,"EndLine":13},"BodyRange":{"StartColumn":1,"StartLine":1,"EndColumn":62,"EndLine":11},"File":"d:\\Appdev\\ValueAdd\\src\\ValueAdd\\scripts\\PowerPeriod.fsx","EnclosingEntity":"M","IsAbstract":false},"Nested":[{"UniqueName":"PowerPeriod_1_of_1","Name":"tz","Glyph":"Field","GlyphChar":"F","IsTopLevel":false,"Range":{"StartColumn":5,"StartLine":11,"EndColumn":62,"EndLine":11},"BodyRange":{"StartColumn":5,"StartLine":11,"EndColumn":62,"EndLine":11},"File":"d:\\Appdev\\ValueAdd\\src\\ValueAdd\\scripts\\PowerPeriod.fsx","EnclosingEntity":"M","IsAbstract":false}]}]
 [09:08:28 DEBUG] REQ (692) -> {signatureData}, File = "~\src\ValueAdd\scripts\PowerPeriod.fsx" Data={"FileName":"d:\\Appdev\\ValueAdd\\src\\ValueAdd\\scripts\\PowerPeriod.fsx","Line":11,"Column":5,"Filter":""}
  [09:08:28 DEBUG] RES (692) <- {signatureData} in 7 ms: Kind={"info"} Data="Cached typecheck results not yet available"

Apologies if this is a known issue but I had a quick look and could find anything.
I can share the project via e-mail if it helps.
Version
VS Code: 1.18.0
Ionide FSharp: 3.12.2

Hmm... I can't reproduce, can you try the latest update? Maybe we've accidentally fixed that.

Closing this issue as it appears that using Postman with the Interceptor turned on prevented the communication between ionide and fsautocomplete.

If it is any additional help, this is the server side error that is captured.
[I] 2017-11-17T14:28:06.3495356Z: listener started in 24.000 ms with binding <IP_ADDRESS>:8746 [Suave.Tcp.tcpIpServer] Unhandled error - Index was outside the bounds of the array.
at <StartupCode$FsAutoComplete-Core>.$Commands.getLine@348.Invoke(Int32 i)
 at FsAutoComplete.UnopenedNamespacesResolver.ParsedInput.adjustInsertionPoint(FSharpFunc`2 getLineStr, InsertContext ctx)
  at FsAutoComplete.UnopenedNamespacesResolver.ParsedInput.tryFindNearestPointToInsertOpenDeclaration(Int32 currentLine, ParsedInput ast, String[] entity, OpenStatementInsertionPoint insertionPoint, FSharpFunc`2 getLine)
   at <StartupCode$FsAutoComplete-Core>.$Commands.clo@100-19.Invoke(ParsedInput ast)
   at <StartupCode$FsAutoComplete-Core>.$Commands.clo@98-17.Invoke(String n)
   at <StartupCode$FsAutoComplete-Core>.$Commands.Completion@344-1.Invoke(FSharpOption`1 _arg13)
   at Microsoft.FSharp.Control.AsyncBuilderImpl.args@835-1.Invoke(a a) Unhandled Exception: System.IndexOutOfRangeException: Index was outside the bounds of the array.
    at <StartupCode$FsAutoComplete-Core>.$Commands.getLine@348.Invoke(Int32 i)
    at FsAutoComplete.UnopenedNamespacesResolver.ParsedInput.adjustInsertionPoint(FSharpFunc`2 getLineStr, InsertContext ctx)
    at FsAutoComplete.UnopenedNamespacesResolver.ParsedInput.tryFindNearestPointToInsertOpenDeclaration(Int32 currentLine, ParsedInput ast, String[] entity, OpenStatementInsertionPoint insertionPoint, FSharpFunc`2 getLine)
   at <StartupCode$FsAutoComplete-Core>.$Commands.clo@100-19.Invoke(ParsedInput ast)
   at <StartupCode$FsAutoComplete-Core>.$Commands.clo@98-17.Invoke(String n)
   at <StartupCode$FsAutoComplete-Core>.$Commands.clo@112-21.Invoke(FSharpDeclarationListItem _arg3)
    at Microsoft.FSharp.Control.AsyncBuilderImpl.callA@851.Invoke(AsyncParams`1 args)
 --- End of stack trace from previous location where exception was thrown ---
    at Microsoft.FSharp.Control.CancellationTokenOps.Start@1268-1.Invoke(ExceptionDispatchInfo edi)
    at <StartupCode$FSharp-Core>.$Control.loop@430-54(Trampoline this, FSharpFunc`2 action)
    at Microsoft.FSharp.Control.Trampoline.ExecuteAction(FSharpFunc`2 firstAction)
    at <StartupCode$FSharp-Core>.$Control.-ctor@516-1.Invoke(Object state)
    at System.Threading.ExecutionContext.RunInternal(ExecutionContext executionContext, ContextCallback callback, Object state, Boolean preserveSyncCtx)
    at System.Threading.ExecutionContext.Run(ExecutionContext executionContext, ContextCallback callback, Object state, Boolean preserveSyncCtx)
    at System.Threading.QueueUserWorkItemCallback.System.Threading.IThreadPoolWorkItem.ExecuteWorkItem()
    at System.Threading.ThreadPoolWorkQueue.Dispatch()

same problem.
Not sure to how reproduce иut at me it turned out as follows:

Create two files: Main.fsx, Other.fsx (blank)
Main.fsx code:

#load "./Other.fsx"

open System

After some actions with intellisense it dropped.
Output "F# Language Service"
[17:44:30 ERROR] RES (352) <- {parse} ERROR in 1014 ms: {stack: Error: connect ECONNREFUSED <IP_ADDRESS>:8616
	at Object.exports._errnoException (util.js:1050:11)
	at exports._exceptionWithHostPort (util.js:1073:20)
	at TCPConnectWrap.afterConnect [as oncomplete] (net.js:1097:14), message: connect ECONNREFUSED <IP_ADDRESS>:8616, code: ECONNREFUSED, errno: ECONNREFUSED, syscall: connect, address: <IP_ADDRESS>, port: 8616, config: [object Object], request: [object Object], response: undefined} Data=undefined

@colinbull, great, that's helpful, indeed

@psmolkin, make sure you don’t have any proxies like Postman Interceptor or fiddler running or restrict the ports they are listening on as I have found this can cause a very similar error to the one you are seeing.

@colinbull , can you try 3.12.5?

Cool, will try on Monday. Thanks.

@colinbull, Not promising anything, can't reproduce so just trying to randomly add try...withs ;-)

@Krzysztof-Cieslak fixed for me, thanks

Sounds related to this issue https://github.com/ionide/ionide-vscode-fsharp/issues/570
I just tested the it with 3.12.5. Unfortunatly the issue still exists.

Ok, this seems to have fixed the immediate issue, but I can confirm that indeed #570 still exists and I can break the intellense and code lens if you use anything in the #load directive other than the a single file name.
For example
 #load @"D:\Appdev\foo\bar\FileSystem.fs" //breaks
 #load @"D:/Appdev/foo/bar/FileSystem.fs" //breaks
 #load "./FileSystem.fs" //breaks
 #load "FileSystem.fs" //Works fine as long as the script is at the same level

I think I'll close this issue and keep an eye on #570 as @2moveit points out it seems to be the same issue.


Namespace 'firebase' has no exported member 'Promise'

Version info
Angular:
4.2.4
Firebase:
4.5.0
AngularFire:
4.0.0-rc0
Other (e.g. Ionic/Cordova, Node, browser, operating system):
Node v6.11.3, Windows 7 x64
How to reproduce these conditions
import { Component } from '@angular/core';
import { AngularFireDatabase, FirebaseListObservable } from 'angularfire2/database';

interface MovieQuote {
  movie: string;
  quote: string;
  $key?: string;
}

@Component({
  selector: 'app-root',
  templateUrl: './app.component.html',
  styleUrls: ['./app.component.css']
})
export class AppComponent {
  formMovieQuote: MovieQuote = {
    'movie': '',
    'quote': ''
  };

  movieQuotesStream: FirebaseListObservable<MovieQuote[]>;

  constructor(db: AngularFireDatabase) {
    this.movieQuotesStream = db.list('/quotes');
  }

  onSubmit() {
    this.formMovieQuote = {
      'movie': '',
      'quote': ''
    };
  }
}

@yazan-alomari Update to the 5.0 branch to fix this error. This also upgrades you to the new database API. The migration is easy and the guide is here. However, if you need to stay on the old version use the angularfire2/database-deprecated module.

Still getting the "no exported member 'Promise'" error.

@EstiShay What version of Firebase, Angular, and AngularFire are you on?

angularfire: 5.0.0-rc.0-next
firebase: 4.2.0-4.5.0
angular: 4.2.4
We're still getting it. Tried to roll back to pre-Firebase 4.5.0 and use AngularFire 4.0.0-rc.0. This way we get a screen full of Promise errors. When we update to 5.0, we still get one Promise error.

Is there a documentation for updating the previous code in accordance with AngularFire 5.0?
I have tried the changes mentioned here.Still I'm unable to resolve the issue.

@davideast I think you should be waited for a little before closing the ticket!
Why I have to do full refactor for just a little modification?

This is fixed in master
https://github.com/angular/angularfire2/commit/96b3c208064b1019399e892e58ee480b4264eeb9#diff-bdb6b409af08da485e2b960e4d9f75eaL16

Hi,
i have the same problem here, and i don't want to make changes on my code, because in this case i should make a lot of changes
how can i downgrade firebase and angularfire to resolve this issue ?

Hi,
I had a look at the commit that @Maistho mentions above. But when I look at that file in my local node_modules, the changes are not there. So, I checked the version of angularfire2 in my local node_modules: it's 5.0.0-rc.0-next.
In my project, my package.json specifies "angularfire2": "^5.0.0-rc.3"
When I run yarn add angularfire2 5.0.0-rc3 I get error Couldn't find package "5.0.0-rc.3" on the "npm" registry.
When I delete node_modules and run npm install I can see "version": "5.0.0-rc.3" in my local node_modules. And I don't get the firebase has no exported member 'Promise error.
I'm not sure why there is a difference, but I hope this helps
Charlie

@CharlesSuttie
yarn add angularfire2 5.0.0-rc3 should be yarn add<EMAIL_ADDRESS>instead.
If you have rc.0-next you will get the error. rc.2 and above should be fine.

when update
the version of angularfire2 in my local node_modules: it's 5.0.0-rc.0-next.
then getting this error :

node_modules/angularfire2/database/index"' has no exported member 'FirebaseListObservable'

I don't want to upgrade to v5. How does one stay on 4.0.0-rc.0 (or 1,2)? Is there an actual working v4 anymore?

I don't want to upgrade to v5. How does one stay on 4.0.0-rc.0 (or 1,2)? Is there an actual working v4
anymore?

im having the same problem...

Same problem.."angularfire2": "^5.0.0-rc.3" and "firebase": "^4.6.0"...that's using npm install firebase@latest so don't know how you're getting firebase V5.
Error is:
Namespace 'firebase' has no exported member 'Promise'.

I'm having the same problem.
angular: 4.1.3
angularfire2: 5.0.0-rc.3
firebase: 4.6.0
Node: v6.10.0
npm: 4.2.0
OS: macOS Sierra
Xcode: Xcode 9.0.1 Build version 9A1004

Found some answers...Firebase doesn't have a promise any more...it is just a generic promise so change firebase.promise to Promise.
Also Angularfire2 doesn't have a submit on the object any more...read the conversions from 4 to 5...you have to do some mapping to get it to behave in a similar fashion.... beware breaking updates!!!

I rolled back to<EMAIL_ADDRESS>and worked just fine. @davideast  the "angularfire2/database-deprecated" didn't work out for me I don't know if there's a specific version that has that module integrated.

@tinomen any solution?

@mubasshir
"angularfire2": "^5.0.0-rc.3",
 "firebase": "4.4.0",

Should work

Yeah, rollback from  V5 if you don't want the breaking changes or look at the blogs from Jorg at  javebratt.com to work out how to use the new features...he's been updating his blogs to cover V5

@mubasshir I downgraded and it is working fine.
"angularfire2": "4.0.0-rc.0",
"firebase": "^3.6.6",
I'm too close to completion that I don't want to spend anytime upgrading to v5. Unfortunately, it is generally allowed to introduce breaking changes in rc versions but it's too bad there wasn't much explanation until folks started logging issues. It's the unfortunate side of open source when a major version has this experience then abandoned.

@tinomen, you can upgrade to V5 and keep the old API. Just switch your database imports to angularfire2/database-deprecated.

but it's too bad there wasn't much explanation until folks started logging issues

I'm sorry that you felt frustration and a bit of surprise with the new version. I tried hard to solicit feedback and create awareness of the upcoming changes. There was a long detailed proposal to the breaking changes that was created three weeks before the 5.0 release. We created a migration guide upon releasing the new version. I want to avoid these frustrating experiences in the future. What else could we do to make this process easier?

I get this error but its coming from node_module.
my package.json says       "angularfire2": "^5.0.0-rc.3",
i did npm update/install and deleted node_modules folder and re-installed..but i keep getting this file with Promise in it.
/node_modules/angularfire2/firebase.app.module.d.ts (12,28): Namespace 'firebase' has no exported member 'Promise'.
angularfire2/database-deprecated  does not help me. any idea?

I've got "angularfire2": "^5.0.0-rc.3" too, and can't get the right declaration for delete, so...
I'm just manually editing firebase.app.module.d.ts and manually changing:
delete: () => firebase.Promise;
to
delete: () => Promise;
Terrible, but I'm doing this just to get back to work until this issue is resolved.

@davideast I was speaking of the v4 changes. I got the error when npm installed rc.1. 4-rc0 with firebase 3.6.6 doesn't throw the error and I can just move on with dev. When my POC is done I'll evaluate an upgrade to v5

@NimaiMalle  - I know it's less than ideal, but this is an instance where learning to use some of the great GNU tools like find, sed, and grep in a terminal can make your life a little easier. https://unix.stackexchange.com/questions/112023/how-can-i-replace-a-string-in-a-files

@NimaiMalle changing from firebase.Promise to Promise is not an issue, actually, I like this, it does not make sense to have many types of the same Promise object! it is confusing also is making unnecessary wrapping and more code just to switch from Promise to firebase.Promise and the way back, this was a headache, it is indeed a good change, especially they were the same and there was nothing special about firebase.Promise anyway.
@tnesbit450 it is not only a "string" to replace! it is a class need to be imported as well! it is not that easy as what you are thinking, it is simply a refactor that you need to do.

Having "angularfire2": "^5.0.0-rc.3" in my package.json seemed to make yarn install 5.0.0-rc.0-next.
But after checking  npm semver calculator, I found that changing the entry in package.json to "angularfire2": "5.0.0-rc.3" (i.e without the carat) causes yarn to install 5.0.0-rc.3 instead of 5.0.0-rc.0-next. This fixed the problem for me.

@almothafar - yeah, Always easier said ham done of course. But, files are nothing but strings. With the exception of binaries, it’s pretty straight forward. And even that can be accounted for. It doesn’t hurt to give it a shot. One simple command in the CLI. And if you can’t make it work, you just roll back the changes in one more simple line of text in a CLI.

What I'm seeing is: Namespace 'firebase' has no exported member 'firestore' in the following .d.ts files:
node_modules/angularfire2/firebase.app.module.d.ts
node_modules/angularfire2/firestore/collection/changes.d.ts
node_modules/angularfire2/firestore/firestore.d.ts
node_modules/angularfire2/firestore/interfaces.d.ts
node_modules/angularfire2/firestore/observable/fromRef.d.ts
I'm on "angularfire2": "^5.0.0-rc.3".

Is there a documentation for v5? Old namespace don't work anymore.

@davideast I was speaking of the v4 changes. I got the error when npm installed rc.1. 4-rc0 with firebase 3.6.6 doesn't throw the error and I can just move on with dev. When my POC is done I'll evaluate an upgrade to v5

I have to do rollback to
"angularfire2": "4.0.0-rc.0",
"firebase": "^3.6.6",

and works for me
here, the steps to migrate to V5.
StepsToupdateV5


Avoid duplicating apex NS records

Normal behaviour will show apex NS and performing a zone reset will lead to new NS records to be created, both unexpected behaviour and actually unnecessary in the zone definition.
Going further and resetting multiple times the zone will lead to those NS records to be duplicated over and over.
Steps to replicate the issue:

Create an account with Digital Oceans as DNS provider
Reset the zone via panel
Cross-check between panel and DO Console

Result can be simply monitored through DO Console by searching in page for value ns1.digitalocean.com, which should have multiple entries after multiple resets.

Thanks for the PR. Merged in 👍


Updates (drop support for PHP < 7.2, allow PHP 8.0)

PHP 8.0 will work after https://github.com/schmittjoh/JMSSerializerBundle/pull/819

FYI @ahilles107

Thank you for your work @mhujer !


Benchmarks: Hero Healing Per Minute

On the Benchmarks tab, there's a column for "Hero Healing per Minute". For most heroes, this value is at zero. However, even though the value is zero, it places the player at a percentile.
It's possible I just don't understand what the percentile means here, but it really doesn't make sense to me; if I did zero healing, that means I would be in the 0th percentile, right? Or is it the other way around, N percent of people playing this hero did no healing?
Either way I think the UI could use a little explanation or tweaking. Would it make sense to remove the data from matches where the hero did no healing and display these columns differently? So you're only being compared to matches where some healing was done by that hero.

I think the standard definition of percentile is the percent of observations that fall at or below the indicated value.  0 is a valid value, so I don't think we should omit it.
If a percentile is given for a 0 value, that's the percent of observations that was 0.  I think the tooltip indicates "equal or less than"

Yep you're right. It feels a bit strange to be given a green "all is good" for a stat that you did nothing on, but I suppose that means you're playing the hero as intended, so in fact things are all good.


feat(Order/Max): basic IsMin / IsBot lemmas

I couldn't find anything similar to these, but there's a possibility they might already be in Mathlib somewhere.

Thanks! Delegating to @YaelDillies
bors d=@YaelDillies

maintainer merge

bors merge
Silly me


For Code Reviewer

Project Link
Team members: 3
Glenda Diaz assign to Team member #1 tasks
Belay Birhanu assign to Team member #2 tasks
Birhanu Gudisa assign to Team member #3 tasks

Hi Team,
Your project is complete!  There is nothing else to say other than... it's time to merge it :shipit:
Congratulations! 🎉
Highlights 💯

Descriptive info ✔
Tasks distributed equally ✔

Optional suggestions
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.

As described in the Code reviews limits policy  you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.


"scroll-to-top"-button missing - probably feature request

Details

Project URL: http://docs.readthedocs.io/en/latest/theme.html

Expected Result
wanted to find a a "scroll-to-top"-button when checking this URL on my phone. Couldn't find it...

@kassbohm hi, thanks for your report.
Could you give more details? Where you would add it to not interfere with the rest of the design for example? A simple a link is enough?
Probably a better place for this issue is https://github.com/rtfd/sphinx_rtd_theme
Would you like to make a Pull Request?

Hi thanks for replying.
sorry, actually I wanted to add this to  https://github.com/rtfd/sphinx_rtd_theme ... should we close this here and I ask at https://github.com/rtfd/sphinx_rtd_theme instead?

Sure. When you create the issue in the other repository please, paste the link here so they are connected. Thanks!

https://github.com/rtfd/sphinx_rtd_theme/issues/424

@humitos
added two pics about what I mean https://github.com/rtfd/sphinx_rtd_theme/issues/424
any other questions?

Thanks!


C++ ONLY !?

Is it possible to build C++ only lib using CMake under Windows ?
Failed to find any such instructions in the docs!

I have tried the same and could not find a CMake target for libtink.so. As far as I understand the CMake support is still in development and is good enough to develop tink, but not for building the final product.
What's more, tink uses absl, meaning using CMake alone could be tricky as a package-manager-like functionality is needed to install absl (or other deps) and build the tink itself. CMake does not do that by itself.
I might be wrong though.

CMake in combination with CPack adn CTest can do everything. It is super frustrating how many C++ projects still rely on self-baked build systems :( last one I adopted was botan, same issue :( CMake was only ment for developers :(
Thanks for the update!


Build Loading Spinner

I could use help building a loading spinner to run while waiting on graphql calls to load. For example, the Gardens component runs a graphql query when initialized, but there is no spinner or anything to show that you're waiting.

@capndave I would like to work on it as part of hacktoberfest challenge. Please assign it to me

@sameer-j how is this going?

Sorry for the delay, I could start it only today after taking out time from my work. I will actively work on this now.
I need some help. I followed the steps to setup the environment in my local. I m not able to get past the login though. Is there any test account with which I can login? Tried Signup but its giving error "Error decoding signature"


[1.12.2] Killer_Joe "kills" Server. (Block Entity being ticked).

Issue Description:
Server shuts down, after entering the AoE of a Killer_Joe, doesn't matter if aktiv or not.
What happens:
Server shuts down and will crash everytime, until i use "/setblock" to switch the Killer_Joe with any other Block.
What you expected to happen:
I can walk in the Area of Effect from the Killer_Joe. If it's aktiv, i would recive Damage, if it's offline, i can just walk / build or collect there.
Steps to reproduce:

Build a Killer_Joe, give him any Sword (tried with 3 different Swords)
Let it work once (even without any Monster, just Nutrient and a Weapon).
Server crashes.

Affected Versions (Do not use "latest"):

EnderIO: 1.12.2 - 5.0.20
EnderCore: 1.12.2 - 0.5.18
Minecraft: 1.12.2
Forge: 1.12.2 - <IP_ADDRESS>54

Your most recent log file where the issue was present:
Crash-Reports sorted by Sword-Type.

DIamond-Sword (Vanilla / latest)
https://pastebin.com/Kxstu5Di
Emeradic-Sword (Actually Additions)
https://pastebin.com/WZCcPVxr
Unbreakable Paper-Sword (Tinkers Construct / oldest)
https://pastebin.com/A6eyMuiw

If you need more Information, pls tell me and i'll bring them as fast as i can.
Thanks for your Time and your great Work!

ftbutilities/ftblib is crashing here. Open a ticket there and link this one in.

thanks for the Info, I've just now seen, that they updated their Mods 3 Hours ago. Will try the new Versions tomorrow, and if it doesn't work, i'll do as you suggested.

Sorry for my late answer, got a suprise visit from a friend and didn't find time to test it.
With the following Versions it now works fine.
EnderIO: 1.12.2 - 5.0.21
EnderCore: 1.12.2 - 0.5.18
Minecraft: 1.12.2
Forge: 1.12.2 - <IP_ADDRESS>66
FTBLib: <IP_ADDRESS>
FTB Utilities: <IP_ADDRESS>
Thanks again and i guess that means case closed.


Updated Prometheus to scrape more MCM metrics

What this PR does / why we need it:
The following is the list of new metrics that Prometheus scrape's from MCM

mcm_machine_controller_frozen
mcm_machine_items_total
mcm_machineset_items_total
mcm_machine_set_failed_machines
mcm_machinedeployment_items_total
mcm_machine_deployment_failed_machines
mcm_cloud_api_requests_total
mcm_cloud_api_requests_failed_total
mcm_scrape_failure_total

Which issue(s) this PR fixes:
Partially https://github.com/gardener/machine-controller-manager/issues/211
Special notes for your reviewer:
I can see that a couple of MCM metrics are already scraped by the Prometheus. So I have tried to add a few more. This is my first time trying to work with metrics, so please double check that I am doing the right thing.
Kindly take a look at the metrics currently MCM exposes here - https://github.com/gardener/machine-controller-manager/blob/master/pkg/metrics/metrics.go.
Release note:

MCM metrics are exposed to the Prometheus

I shall be creating a subsequent PR to display these metrics onto the dashboard.

Hi @wyb1 ,
Right now I think they do return blank values. If that's the case, i should perhaps avoid metrics that return blank values for now. And probably integrate them later once i have a new MCM release with corrected values for those?

And also is this an issue only for alerting and not for Prometheus scraping? If that's the case, I can update MCM (with a new release) to return 0 before I integrate this into alerting?

@prashanth26 Prometheus won't have an issue scraping the metrics, but it can cause problems with alerting or if you create dashboards (either the query will break or the dashboard will have "gaps" in the data). In general Prometheus best practice is to avoid missing metrics whenever possible. See this blog post.

@wyb1 Think you are right. But for now they want to have the ability to query for the whitelisted metrics. As Prashanth has already announced to provide a subsequent PR with a dashboard, then there will be indeed a need to integrate these metrics to have proper dashboards and alerts :) Thank you.

Okay, then we can merge and once any dashboards/alerts are based on these metrics they should no longer be "missing".

@wyb1 Thanks for your feedback. I shall make the suggested changes by you at the MCM before integrating the dashboard/alerting. In the meanwhile these currently exposed metrics should help us with watching the cloud provider failures/rate-limits sort of issues, which is the reason for me in creating this PR.


Receive Chain Swap: claim fails if the user RBF-ed the BTC tx

In the following scenario:

SDK creates a Receive Chain Swap (receive-payment --method bitcoin --payer-amount-sat 50000)
user sends the correct amount to the BTC swap address
user RBFs that tx to bump the fee
the BTC tx gets confirmed
SDK fails to claim

"Failed to handle Chain Swap ... update: Could not verify user lockup transaction: Transaction was not found in script history"

The reason is that we are looking for the initial tx ID in the swap script history, instead of the new (RBF) tx ID:
https://github.com/breez/breez-sdk-liquid/blob/1389d49f03aaba73e079c4957ce97fae505ea086/lib/core/src/chain_swap.rs#L1180-L1183
We store the initial tx ID as user_lockup_tx_id as soon as we see it in the mempool, but we don't update it in case it's RBF-ed.
One solution is to update it in our DB on RBF.
Another idea is to skip checking the tx ID here and instead get the 1st tx in the swap script history, since the 1st tx is by definition the lockup tx.

We should take the first transaction. If there are more transactions they will be refunded.


Disable nvim-hlslens like side marks

Neovim version (nvim -v | head -n1)

Operating system/version

How to reproduce the issue
Some time ago in the preview window appears side marks like in nvim-hlslens plugin. Like [35/54] and so on. How to turn them off? I didn't find a configuration option, and they are distracting for me.
Expected behavior

Actual behavior

Make sense. I will add the option later.


List of keyboard shortcuts?

What are they? And, thank you from the depths of my heart and soul for this.

I need to actually add the keyboard controls somewhere, sorry for that.  Here is what they are in the meantime:
SPACE - next preset with transition
H - next preset without transition
DELETE - last preset
A - random mashup

@jberg I'm trying to use these hotkeys in Webamp but they don't work? Do I need to enable hotkeys or do something in __butterchurnOptions ?
This is how I initialize Webamp
      this.webamp = new Webamp({
        initialTracks: this.tracks,
        initialSkin: this.initialSkin,
        availableSkins: this.skins,
        // filePickers: [dropboxFilePicker],
        enableHotkeys: true,
        __butterchurnOptions: {
          importButterchurn: () => import('butterchurn'),
          getPresets: () => {
            const presets = butterchurnPresets.getPresets();
            return Object.keys(presets).map((name) => ({
              name,
              butterchurnPresetObject: presets[name],
            }));
          },
          butterchurnOpen: true,
        },
        __initialWindowLayout: initialWindowLayout,
      });

thanks!

Hi @vesper8 ,
Are you making sure to click on the butterchurn window to ensure it has focus before trying keyboard shortcuts?  If you are, then there might be some issue with focus handling in webamp itself since it is handling the focus/keyboard controls.  You shouldn't need to pass anything special into the constructor for it to work.

hrm.. actually it seems to be working now.. maybe i just didn't notice the subtle change between presets when i tried it before.. thanks for the reply!

awesome! glad you got it working


a few camanjs filters, effects rewitten in pure golang

a few camanjs filters, effects rewitten in pure golang. Any problems, please let me know soon
Thank you!
NOTE: all code for examples below is placed in caman/example directory.
original image

Sepia effect

Colorize

Curves

Channels

@anthonynsimon could you please spend a minute to review my request ?


Renaming repo causes internal server error

I initially turned ShareLaTeX CI compilation on for my repo, called nerc-internship. After deciding to rename it to nerc-internship-presentation, any attempts to link this new repo up with ShareLaTeX CI causes internal server errors.
My renamed repo: https://github.com/drewsberry/nerc-internship-presentation
When I try to "Turn On" ShareLaTeX CI:

This still hasn't been fixed.