Android: NoOpKernel was registered to support Op 'TensorflowArray' DynamicRNN

I'm trying to load a graph I trained in python, which includes only using dynamicRNN, and the most basic RNN cell.
When I try execute the graph on the Android, I get the following error message:
Invalid argument: No OpKernel was registered to support Op 'TensorArray' with these attrs
     [[Node: c96ce52cccd5408aad2fb356a8246023/RNN/TensorArray_1 = TensorArray[clear_after_read=true, dtype=DT_FLOAT, dynamic_size=false, tensor_array_name="c96ce52cccd5408aad2fb356a8246023/RNN/dynamic_rnn/input"](c96ce52cccd5408aad2fb356a8246023/RNN/unpack)]]

Environment info
Operating System:
Ubuntu x64 14.04
Android 6.0
Installed version of CUDA and cuDNN:
(please attach the output of ls -l /path/to/cuda/lib/libcud*):
If installed from binary pip package, provide:

Which pip package you installed.
The output from python -c "import tensorflow; print(tensorflow.__version__)".

If installed from source, provide

The commit hash (git rev-parse HEAD)
tag v0.9.0
The output of bazel version
0.3.0

Steps to reproduce

Create RNN model in python
Compile it with tensorflow_android_lib targeting armv7
Try run the model on android

What have you tried?

Logs or other output that would be helpful
(If logs are large, please upload as attachment).

It seems it that the RNN ops are default not included in the android_extended_ops_group under /tensorflow/cc/kernel/BUILD.
a hack is adding the operations manually but the more correct way seems to use selective_registration.
https://github.com/tensorflow/tensorflow/blob/master/tensorflow/core/framework/selective_registration.h
Is there an easy way to determine the names of all the ops I would need, perhaps writing a grep on parsing a txt version of the saved graph?

And on the same note, is there an example of how to use selective_registration, in particular how to differentiate between SHOULD_REGISTER_OP_KERNEL SHOULD_REGISTER_OP and SHOULD_REGISTER_OP_GRADIENT

So long as the op builds and runs correctly, it's fine to add it to the default ops file group (we've just been adding them on an as-needed basis now that we have a way to manage binary size).
You don't need to use selective registration yourself unless you are prioritizing binary-size -- it will cut the final .so size essentially in half to result in < 1mb compressed for a typical graph.
@cwhipkey do you know if there is a public example of this yet?

Okay, but it would be nice to be able to do selective registration eventually, so I can get the minimal size for my own graph right.
I tried to do it on my own, and replaced the android_cc_library, to depend on android_all_ops instead. Like this:
cc_library(
    name = "android_tensorflow_kernels",
    srcs = select({
        "//tensorflow:android": [
            "//tensorflow/core/kernels:android_all_ops",
        ],
        "//conditions:default": [],
    }),
    copts = tf_copts(),
    tags = [
        "manual",
        "notap",
    ],
    visibility = ["//visibility:public"],
    deps = [
        "//tensorflow/core:android_tensorflow_lib_lite",
        "//tensorflow/core:protos_cc",
        "//third_party/eigen3",
    ],
    alwayslink = 1,
)

But then I got the following error during compilation:
external/eigen_archive/eigen-eigen-d02e6a705c30/unsupported/Eigen/CXX11/../../../Eigen/src/Core/util/StaticAssert.h:32:40: error: static assertion failed: THIS_TYPE_IS_NOT_SUPPORTED
     #define EIGEN_STATIC_ASSERT(X,MSG) static_assert(X,#MSG);
                                        ^
external/eigen_archive/eigen-eigen-d02e6a705c30/unsupported/Eigen/CXX11/../../../Eigen/src/Core/SpecialFunctions.h:976:9: note: in expansion of macro 'EIGEN_STATIC_ASSERT'
         EIGEN_STATIC_ASSERT((internal::is_same<Scalar, Scalar>::value == false),

This is my main build file:
cc_binary(
    name = "myapp",
    srcs = [
        "main.cc",
        "ops_to_register.h"
    ],
    copts = [
        "-fno-exceptions",
        "-DEIGEN_AVOID_STL_ARRAY",
        "-DSELECTIVE_REGISTRATION",
        "-mfpu=neon", # This one for ARM only
        "-std=c++11",
        "-DMIN_LOG_LEVEL=0",
        "-DTF_LEAN_BINARY",
        "-O2",
        "-fPIE",
    ],
    linkopts = [
        "-landroid",
        "-llog",
        "-lm",
        "-z defs",
        "-s",
        "-Wl,--icf=all",  # Identical Code Folding
        "-Wl,--exclude-libs,ALL",  # Exclude syms in all libs from auto export
        "-pie",
    ],
    deps = [
        "@org_tensorflow//tensorflow/core:android_tensorflow_lib",
    ],
)

Any ideas as to why it might be failing to compile with EIGEN?

In my case op 'Div' is already included in tensorflow/contrib/makefiletf_op_files.txt but I getting error https://github.com/tensorflow/tensorflow/issues/3549. I think it is probably depending on context.

Adding links to #3543 and #3546 in case they all have a related root cause.

Regarding the question: "@cwhipkey do you know if there is a public example of this yet?", no there is no public example yet of creating a selective-registration header.

Re: @lingz :  I was able to compile with selective registration, but it didn't help reduce the file size for me.  Instead, I ended up using the makefile from tensorflow/contrib/makefile, removing all the unused ops classes from tf_op_files.txt.
For what it's worth, this is what I had in my ops_to_register.h:
const bool kRequiresSymbolicGradients = false;
const char* kNecessaryOpKernelClasses =
    ",Add,"
    ",Const,"
    ...
    ",Softmax,";

constexpr bool ShouldRegisterOp(const char* name) {
    return strcmp(name,"Add") ? true :
        strcmp(name,"Const") ? true :
        ...
        strcmp(name,"Softmax") ? true :
        false;
}

The SHOULD_REGISTER_OP macro from tensorflow/core/framework/selective_registration.h calls ShouldRegisterOp, which returns true if the op should be registered.
The SHOULD_REGISTER_OP_KERNEL macro does a string search in kNecessaryOpKernelClasses

For why the header didn't make the size smaller, I think there are a few
possibilities to check:

selective registration can only make code deleted if the expressions can
be evaluated as constexprs.  Using const char* instead of const char[] on
the definition of kNecessaryOpKernelClasses may be enough to prevent this.
But even with that,  I would have expected some drop by the const bool
kRequiresSymbolicGradients = false;  line.  Was it no change at all in
size, or a small change?

doublecheck that SELECTIVE_REGISTRATION macro is defined for calls to
compile the ops and kernels.

what compiler are you using?  Maybe compiler differences could explain
it as well.

--
Here's an example ops_to_register.h that gets generated by the tool that
will be opensourced soon:
#ifndef OPS_TO_REGISTER
#define OPS_TO_REGISTER
constexpr inline bool ShouldRegisterOp(const char op[]) {
return false
|| (strcmp(op, "AvgPool") == 0)
|| (strcmp(op, "BiasAdd") == 0)
|| (strcmp(op, "Concat") == 0)
|| (strcmp(op, "Const") == 0)
|| (strcmp(op, "Conv2D") == 0)
|| (strcmp(op, "Identity") == 0)
|| (strcmp(op, "LRN") == 0)
|| (strcmp(op, "MatMul") == 0)
|| (strcmp(op, "MaxPool") == 0)
|| (strcmp(op, "NoOp") == 0)
|| (strcmp(op, "Placeholder") == 0)
|| (strcmp(op, "Relu") == 0)
|| (strcmp(op, "Reshape") == 0)
|| (strcmp(op, "Softmax") == 0)
|| (strcmp(op, "_Recv") == 0)
|| (strcmp(op, "_Send") == 0)
;
}
const char kNecessaryOpKernelClasses[] = ","
"AvgPoolingOp<CPUDevice, float>,"
"BiasOp<CPUDevice, float>,"
"ConcatOp<CPUDevice, float>,"
"ConstantOp,"
"Conv2DOp<CPUDevice, float>,"
"IdentityOp,"
"LRNOp<CPUDevice, float>,"
"MatMulOp<CPUDevice, float, false >,"
"MaxPoolingOp<CPUDevice, float>,"
"NoOp,"
"PlaceholderOp,"
"ReluOp<CPUDevice, float>,"
"ReshapeOp,"
"SoftmaxOp<CPUDevice, float>,"
"RecvOp,"
"SendOp,"
;
const bool kRequiresSymbolicGradients = false;
#endif
On Thu, Sep 29, 2016 at 11:39 AM, Sam<EMAIL_ADDRESS>wrote:

Re: @lingz https://github.com/lingz : I was able to compile with
selective registration, but it didn't help reduce the file size for me.
Instead, I ended up using the makefile from tensorflow/contrib/makefile,
removing all the unused ops classes from tf_op_files.txt.
https://github.com/tensorflow/tensorflow/blob/f71cc62282bf2e066f9ebd08cf3f605fc98c6e41/tensorflow/contrib/makefile/tf_op_files.txt
For what it's worth, this is what I had in my ops_to_register.h:
const bool kRequiresSymbolicGradients = false;const char* kNecessaryOpKernelClasses =
",Add,"
",Const,"
...
",Softmax,";
constexpr bool ShouldRegisterOp(const char* name) {
return strcmp(name,"Add") ? true :
strcmp(name,"Const") ? true :
...
strcmp(name,"Softmax") ? true :
false;
}
The SHOULD_REGISTER_OP macro from tensorflow/core/framework/
selective_registration.h
https://github.com/tensorflow/tensorflow/blob/f71cc62282bf2e066f9ebd08cf3f605fc98c6e41/tensorflow/core/framework/selective_registration.h
calls ShouldRegisterOp, which returns true if the op should be registered.
The SHOULD_REGISTER_OP_KERNEL macro does a string search in
kNecessaryOpKernelClasses
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/tensorflow/tensorflow/issues/3549#issuecomment-250553879,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AQw4wQ7SVEzQUTsU3512180ZgGITJBZTks5qvAXugaJpZM4JXOz-
.

The tool for generating ops_to_register.h that @cwhipkey mentioned is now commited: https://github.com/tensorflow/tensorflow/blob/master/tensorflow/python/tools/print_selective_registration_header.py

hi @andrewharp
I tried to use print_selective_registration_header.py to write ops to ops_to_register.h. I follow instructions and run:
bazel build tensorflow/python/tools:print_selective_registration_header && bazel-bin/tensorflow/python/tools/print_selective_registration_header --graphs=path/to/graph.pb > ops_to_register.h
Then
bazel build -c opt --copt="-DSELECTIVE_REGISTRATION" \
    --copt="-DSUPPORT_SELECTIVE_REGISTRATION" \
    //tensorflow/contrib/android:libtensorflow_inference.so \
    --host_crosstool_top=@bazel_tools//tools/cpp:toolchain \
    --crosstool_top=//external:android/crosstool --cpu=armeabi-v7a

Everything went well, so I use the libtensorflow_inference.so in my Android project. Still when I run the model resnet_101_coco from the model zoo, I get the error:
 java.lang.IllegalArgumentException: No OpKernel was registered to support Op 'Round' with these attrs.  Registered devices: [CPU], Registered kernels:  <no registered kernels>
How to overcome this? Thanks.

@bobeo: What does your ops_to_register.h look like?

hi @andrewharp
I attached the ops_to_register.h. I can see it has 'Round" ops ( || isequal(op, "Round") ) . The final libtensorflow_inference.so is 4MB.
The model I use is faster_rcnn_resnet101_coco from
http://download.tensorflow.org/models/object_detection/faster_rcnn_resnet101_coco_11_06_2017.tar.gz
Thanks.
ops_to_register.h.zip

@andrewharp any luck with this?

There are at least couple reasons this could happen:

the kernel for round isn't being compiled on android.  you could add a compilation error in tensorflow/core/kernels/cwise_op_round.cc and then run the android build again, to see if it actually compiles that file.

the kernel is being compiled, but for some reason the ops_to_register.h is causing it to not use the Round op.  ops_to_register.h works by comparing the string name of the class to the string in the ops_to_register.h.  It's possible the compiler for the device is using a different name than the compiler for the host (used to make ops_to_register.h).  It can be tricky to get the names out of the device compilation -- one way could be to change the cwise_op_round.cc kernel file and

Add:
#define CLAZ_NAME(x) #x
static_assert(false, CLAZ_NAME(UnaryOp));
then build and look for the class name printed by the assertion failure.

thanks @bobeo ,
I did this process with a few pb graphs including the ones from the example app
and in in time I'm the print_selective_registration_header process i see that the ops_to_register.h file is updated according to the graph but the resulting libtensorflow_inference.so is always in the same size.
i tried all the bazel clean / bazel dump options that i have found, but nothing helped
so it is either a bazel caching issue. or that the build from ops_to_register.h does not work properly.

OK,
just realized that i had 2 ops_to_register.h files ...
on in the /core/framework folder
and one in the project root folder where i ran the print_selective_registration_header build
i think that this is worth clearing in the print_selective_registration_header.h comments...

@eli99999 any luck? Can you try this model?
I'm trying all over again, if success I will let you know. Cheers!

@cwhipkey @andrewharp hi guys, do you know if I should compile libtensorflow_inference.so with GPU enabled? Or it doesnt make any difference? Currently I compiled it without GPU because else I got this error
When I run it an Android, it takes like 1 minute to process each frame. Is that normal?


feat: add transparent balance front page to extension

Closes #674.

Changed

Move extension settings button to the left

Added

Add transparent balance front page to extension
Add ability to disable RadioGroup

This won't go in now that the extension requirements have changed.


Fix typos in telemetry

astsyAsyncMeasurement->atsAsyncMeasurement
startMeasuremeant->startMeasurement

Codecov Report

Merging #5531 (5f37c36) into dev (4ed1f69) will not change coverage.
The diff coverage is 100.00%.

Flag
Coverage Δ

*Carryforward flag

msal-angular
96.50% <ø> (ø)

Carriedforward from 4ed1f69

msal-common
85.22% <100.00%> (ø)

Carriedforward from 4ed1f69

msal-core
82.84% <ø> (ø)

Carriedforward from 4ed1f69

msal-node
83.37% <ø> (ø)

msal-node-extensions
76.03% <ø> (ø)

Carriedforward from 4ed1f69

msal-react
94.68% <ø> (ø)

Carriedforward from 4ed1f69

node-token-validation
88.88% <ø> (ø)

Carriedforward from 4ed1f69

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files
Coverage Δ

...mon/src/telemetry/performance/PerformanceClient.ts
93.96% <100.00%> (ø)

...src/telemetry/performance/StubPerformanceClient.ts
100.00% <100.00%> (ø)


Update context docs to include info on merging

add doc about evaluation context merging (global, client) now that's in the spec.

There's a brief section here I think covers this. If it's not enough, we can add something more substantial.


Remove dispatchFromArray

Closes #1245.

You need to rebase this :)

@jbrooksuk
done.

Thank you.


Wait till images are loaded before running 'onEnd' ?

I noticed that the onEnd parameter fires after the dom is finished, but the images are still loading.

Hey @rolandschuetz , any chance you got an example working? I've been trying for a while to get smoothstate injecting the content only after the images got loaded but without luck so far.
For example, this test in the render of the onEnd:
    console.log('All images have loaded.');
}, function(loaded, count, success) {
   console.log(loaded + ' of ' + count + ' images has ' + (success ? 'loaded' : 'failed to load') +  '.');
});```
loops twice the first console.log and doesn't fire the second one.

Sorry, I have no experience with that plugin

@AllanD have you been able to work this out? Is there any information you could share with @kevinchevallier?


[Helps 184] Add Search Aptitude Service

Added Search Aptitude with a few unit test for the search interface.
Note: On the SearchResult type there is still some research to be done to make sure we are constraining the key types to string.
Please let me know if you have any questions

Bumped LDK Contract Version please let me know if I missed it anywhere else


OCPBUGS-45309: disable pod security admission by default in 4.18

Disables PSa in 4.18 as outlined in https://issues.redhat.com/browse/OCPBUGS-45309

/lgtm

/jira refresh

/jira refresh


wrong listen regex?

I just want to force listen to only a socket file and this regex [1] only detects the listen command in case it has a space at the beginning in the config file.
[1] https://github.com/samuelkadolph/unicorn-rails/blob/master/lib/unicorn_rails.rb#L27
Always starting unicorn listening in port 3000 and the socket file.
Is this something made on purpose?

+1 here. Why is that? It was driving me nuts. @samuelkadolph would you be open to a PR to fix that?

Ah, I wasn't paying attention and missed #20

Fixed by #20


Adding JQuery to the View Editor config

We want to add JQuery to the View Editor configuration so that other webhosted tools can integrate with View Editor better (in this case the JIRA issue collector macro has a dependency on JQuery and we want users to be able to submit a JIRA ticket without leaving View Editor through this macro). Can this be in the default configuration?

Jquery is already pulled into ve, closing this in favor of a customization issue instead, but will need to assess more first since a jira issue collector may require allowing custom js in customization


Add build machine supporting GTK3 to run the complete JMC test set

In order to have the complete test suite for the Mission Control Project being run, I need a build Linux x64 build machine that supports GTK3 using Xvfb

@reinhapa Do you know which specific packages are needed for this? We already put xvfb on the machines by default and the jmc-build jobs look to all be running on build-scaleway-x64-ubuntu-16-04-2 which has quite a few of the GTK3 packages installed:
jenkins@build-scaleway-ubuntu1604-x64-2:~$ dpkg -l | grep -i gtk
ii  gir1.2-gtk-2.0                        2.24.30-1ubuntu<IP_ADDRESS>                 amd64        GTK+ graphical user interface library -- gir bindings
ii  gir1.2-gtk-3.0:amd64                  3.18.9-1ubuntu3.3                        amd64        GTK+ graphical user interface library -- gir bindings
ii  libgtk-3-0:amd64                      3.18.9-1ubuntu3.3                        amd64        GTK+ graphical user interface library
ii  libgtk-3-bin                          3.18.9-1ubuntu3.3                        amd64        programs for the GTK+ graphical user interface library
ii  libgtk-3-common                       3.18.9-1ubuntu3.3                        all          common files for the GTK+ graphical user interface library
ii  libgtk-3-dev:amd64                    3.18.9-1ubuntu3.3                        amd64        development files for the GTK+ library
ii  libgtk2.0-0:amd64                     2.24.30-1ubuntu<IP_ADDRESS>                 amd64        GTK+ graphical user interface library
ii  libgtk2.0-bin                         2.24.30-1ubuntu<IP_ADDRESS>                 amd64        programs for the GTK+ graphical user interface library
ii  libgtk2.0-common                      2.24.30-1ubuntu<IP_ADDRESS>                 all          common files for the GTK+ graphical user interface library
ii  libgtk2.0-dev                         2.24.30-1ubuntu<IP_ADDRESS>                 amd64        development files for the GTK+ library
jenkins@build-scaleway-ubuntu1604-x64-2:~$

Is this adequate for this requirement?

@sxa555 I could run a test build enabling those tests again...

@reinhapa Any luck?

oic, at the moment it is configured for build-scaleway-x64-ubuntu-16-04-2 will switch over to build-scaleway-x64-ubuntu-16-04-2 and give it a try...

@sxa555 I enabled the UI tests now ignoring any failures for further analysis. I guess that @thegreystone may has an idea, what the problem is...

@reinhapa Any updates on this one? Do you believe there is a follow-on infrastructure issue with the setup or are the issues you're hitting potentially down to "real" code problems? Need to know if I can close this or if i have to move it to the April milestone now.

@sxa555 I did not get the cause of the failing tests as they seem to pass locally. As this issue is not that problematic at the moment, I got no problem to move this issue to the April now..

@reinhapa Is this still causing a problem?

@sxa the job is no longer built on Jenkins instead using github actions now...


Errors trying to export glTF using THREE.GLTFExporter

I'm trying to export a glTF scene from ngl. I tried simply adding GLTFExporter to the three import list in viewer.ts, and tried a few other ways as well, but I can't get it to build with GLTFExporter.
I know GLTFExporter has some typescript problems, but I've managed to import it and use it in a simple test typescript project like this:
// just for GLTFExporter
import * as THREE from 'three'
(<any>window).THREE = THREE; // need to make this global
import 'three/examples/js/exporters/GLTFExporter';

and then to use it:
	let exporter = new THREE.GLTFExporter()
	exporter.parse(scene, (gltf) => {console.log("Parsed scene!"); }, {});

which works in the test project but not in ngl. In ngl if I add the above code to viewer.ts, I get this error when building:
(!) Missing exports
https://github.com/rollup/rollup/wiki/Troubleshooting#name-is-not-exported-by-module
build\js\src\viewer\viewer.js
GLTFExporter is not exported by node_modules\three\build\three.module.js

(which is true; it just adds it to THREE), and at runtime in the browser console:
Uncaught ReferenceError: THREE is not defined
    at GLTFExporter.js:54
    at window.console (ngl.dev.js:4)
    at ngl.dev.js:5

Note that THREE is only defined in viewer.ts by my code above. I'm not sure what the above error means.

Just for posterity, I got this working by calling ngl as a lib, and with many thanks to https://stackoverflow.com/questions/52375863/how-to-import-three-js-gltfexporter-in-typescript.


Wrong string in string replacement

There is a bit of code to prevent the bot from mentioning itself when sending replies, however in one case this results in the bot replacing the self mention with the word "replace" instead of an empty string.
Simple fix. On line 47, 'replace' should be replaced with ''
https://github.com/cnsumner/huldra/blob/00a0c46f72c4a4eaee79c6666df7da95c8607b65/lib/huldra.dart#L45-L48

Taking this myself since I have nothing better to do.


Correctly position "Latest" block on service priority org pages

On service priority organisations the "Latest" block appeared in the wrong place.

Use correct featured links wrapper class – .featured-services-and-guidance wrapper was renamed in fd7476e

https://trello.com/c/QbRztL2M/16-align-latest-news-panel-on-organisation-homepages-small
Before

After

:+1:


Add support for building LFS or SPIFFS images?

It would be useful, I think, if we could pick at least in-tree lua_modules directly into a LFS image as part of the firmware bundle.  This would lower the friction of jettisoning some "somewhat hairy" C modules in favor of Lua+C hybrids as I've been trying to drive us to (e.g. https://github.com/nodemcu/nodemcu-firmware/pull/2819 and now https://github.com/nodemcu/nodemcu-firmware/issues/3126).
However, I understand if there's hesitation to do LFS builds because people might want to add their own modules, and that opens "now I need to let people upload files" which is always a little hair-raising on the web.  So...
Maybe instead of LFS, landing selected lua_modules in SPIFFS would still be useful.  They could still be require-d as is, at the cost of increased memory consumption, and given @TerryE's proposal in https://github.com/nodemcu/nodemcu-firmware/issues/2917, having Lua files in SPIFFS would eventually let us tell people how to compile their LFS images on-module.

I doubt I fully understand the issue as LFS has been supported for a long time thanks to @HHHartmann : https://github.com/marcelstoer/docker-nodemcu-build#create-an-lfs-image-for-esp8266

Argh, I was apparently not completely awake when I filed this one.  I meant for this to be about the web builder. -_-

The correct list would be https://github.com/marcelstoer/nodemcu-custom-build/issues (open-source backend of the cloud builder).


AdvancedDataGridDemo for newer Avalonia versions

I am creating a new avalonia  app  with:
dotnet new avalonia.mvvm
and then I am trying to make changes to the template to add the Advanced DataGrid changes, but it does not work. when I execute
dotnet run
nothing happens, I didn't receive even errors...
I think it can be because of breaking changes in styles (https://github.com/AvaloniaUI/Avalonia/wiki/Breaking-Changes#default-theme-was-renamed-to-simple) where says "StyleInclude with old relative path won't work anymore."

What can I do to this work with new Avalonia version?
I'm using Avalonia 0.10.18, will this work with the Avalonia vNext (version 11)?

No, unfortunately the older avalonia versions won't work with the newest. I plan to update Avalonia versions for my projects soon.
To use the newest Simple style you should add the following XAML to your App.axaml file:
<Application.Styles>
    <SimpleTheme Mode="Light"/>
</Application.Styles>


checkpoints.restore_checkpoint` should raise an error for explicit paths that don't exist

Discussed in https://github.com/google/flax/discussions/1612

Originally posted by PgLoLo October  9, 2021
From documentation of flax.training.checkpoints.restore_checkpoint:

Returns:
Restored target updated from checkpoint file, or if no step specified and
no checkpoint files present, returns the passed-in target unchanged.
If a file path is specified and is not found, the passed-in target will be
returned. This is to match the behavior of the case where a directory path
is specified but the directory has not yet been created.

Why silently hiding the checkpoint absence (which is a great potential for a bug: by path misspecification, step misspecification, etc.) is a good idea? Makes no sense to me, is there any logic behind this decision?

I think it makes sense to return an additional value indicating whether the restoration actually took place. Silent failures are the scariest.


No network hashrate  ETC parity 2.4.6 MiningCore 4.7

Description
MiningCore can't load network hashrate with ETC chain
Steps to Reproduce
Every time i'm starting  MC app with ethereum-classic config
I try with monero and it's works.
Expected behavior
I would have network hashrate on api reccord.
Actual behavior
I have 0 Hs on network hashrate data all time
Reproduces how often
100 %
Version
MC : 4.7
Parity : 2.4.6
Additional Information
Linux system ubuntu 16.04
mining core is very nice, Thanks for that !

It already was
https://github.com/coinfoundry/miningcore/issues/360

after reading #360 issue and then #386  i c'ant realy solve my problem or i probably miss something.
you said
#1 :  ' Difficulty / block time '  you mean i have to calculate it in my web ui ?
#2 : ' use 1.95 parity version '  it's a bit old for now , dont you think ?
Does 'Geth' node work with mining core ?

#1 Hasrat network calculate yourself
Example:
https://github.com/sammy007/open-ethereum-pool/blob/master/www/app/controllers/application.js#L37
#2 Yes parity use the latest version

it really doesnt work natively on API   ? i have to do it myself ? Is it working with a full node Geth ?

Yes, for ethereum, the network speed is not displayed, for other varieties of coins it is displayed. Get is not supported.

ok thank you Konstantin35 for your answer.  I'll stay with Sammy for this timet,  dagger coin works fine.
I'm working on a web gui for mining core, i'll keep it for other coin.


add encoding support to file in/out node

[ ] Bugfix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)

Proposed changes

Current File in/out node can not specify encoding of files as discussed here (https://github.com/node-red/node-red/pull/2051).
This PR add support for selecting input/output encoding for file in/out node.
Checklist

[x] I have read the contribution guidelines
[x] For non-bugfix PRs, I have discussed this change on the mailing list/slack team.
[x] I have run grunt to verify the unit tests pass
[x] I have added suitable unit tests to cover the new/changed functionality

Coverage increased (+0.02%) to 76.461% when pulling f6be192a88e16d495518496eeb04fde62e2cfed1 on node-red-hitachi:file-node-encoding into fec52a81511abcb9c510400fa1324de1491f2c6d on node-red:dev.

Excuse me. There was a missing entry in message catalogue.  Fix committed.


Allow verbose output in Hubble Nebula - string indices must be integers, not str

Issuing,
salt '*' nebula.queries day verbose=True
results in,
    Passed invalid arguments to nebula.queries: string indices must be integers, not str

        Run the set of queries represented by ``query_group`` from the
        configuration in the file query_file

        query_group
            Group of queries to run

        query_file
            salt:// file which will be parsed for osquery queries

        verbose
            Defaults to False. If set to True, more information (such as the query
            which was run) will be included in the result.

        CLI Examples:

        .. code_block:: bash

            salt '*' nebula.queries day
            salt '*' nebula.queries hour verbose=True
            salt '*' nebula.queries hour pillar_key=sec_osqueries

This does not happen if I issue the command without verbose=True.

I left a comment on your PR asking for more output. I just want to make sure we fix this correctly.

I am not sure why this is still open.


⚠ Bofrost.lu has degraded performance

In 257c17e, Bofrost.lu (https://www.bofrost.lu) experienced degraded performance:

HTTP code: 200
Response time: 2061 ms

Resolved: Bofrost.lu performance has improved in 8647cd2.


【New Feature Support】Add Support the Observability Feature to Expose  external storage service status and Hard disk throughput or Other indicators

Output of lsblk:
# paste output here

Output of blkid:
# paste output here

Output of kubectl version:
# paste output here

Output of kubectl get lsn -o yaml:
# paste output here

Cloud Provider/Platform (AKS, GKE, Minikube etc.):
# paste output here

Observability function support is scheduled to be supported in September or October .


Update json.hpp to v3.9.1

Fixes #833
Integrate the latest Released version of json.hpp from https://github.com/nlohmann/json/releases/tag/v3.9.1
Presently following the existing process, i.e. drop-in a copy of it.
We may later on consider mapping it as submodule under third_party. But not in this PR.
cc: @SahilAshar

spellcheck / build (pull_request) Failing after 6s — build

Oh, please................... total waste. Ignore this spell checker.

Ok, I'll explicitly turn off the spell checker for now for json.hpp file. Should fix the CI loop and won't resurface again.

Appears like the new version adds new subtype, and gcc is being strict now about that /home/runner/work/cpp_client_telemetry/cpp_client_telemetry/lib/api/LogConfiguration.cpp:80:24: error: enumeration value ‘binary’ not handled in switch [-Werror=switch]
Will need a fix for Linux.

Converting it to draft, as it appears like there's more than one spot that needs an adjustment to make it work with the new library on Linux and Mac (Windows is already good).

Please ignore the timeout of C/C++ CI on Windows (vs2017) / Build (pull_request) In progress — This check has started..., appears like there is some transient issue with GitHub actions.


WIP: test GatewayHTTPS

related: #5415

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: sebastienvas
Assign the PR to them by writing /assign @sebastienvas in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

tests/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@cmluciano: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
fdc5ec644e8e6fea607074396d6ca9b5200c74a2
link
/test istio-unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

This most likely will fail and I think the problem might be that I need to pass the same certs in the request that we mount here

@cmluciano: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
fdc5ec644e8e6fea607074396d6ca9b5200c74a2
link
/test istio-unit-tests

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
fdc5ec644e8e6fea607074396d6ca9b5200c74a2
link
/test istio-pilot-e2e-envoyv2-v1alpha3

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@cmluciano: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
fdc5ec644e8e6fea607074396d6ca9b5200c74a2
link
/test istio-unit-tests

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
fdc5ec644e8e6fea607074396d6ca9b5200c74a2
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/istio-pilot-e2e.sh
fdc5ec644e8e6fea607074396d6ca9b5200c74a2
link
/test istio-pilot-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@cmluciano: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
fdc5ec644e8e6fea607074396d6ca9b5200c74a2
link
/test istio-unit-tests

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
fdc5ec644e8e6fea607074396d6ca9b5200c74a2
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/istio-pilot-e2e.sh
fdc5ec644e8e6fea607074396d6ca9b5200c74a2
link
/test istio-pilot-e2e

prow/e2e-bookInfoTests-v1alpha3.sh
fdc5ec644e8e6fea607074396d6ca9b5200c74a2
link
/test e2e-bookInfo-envoyv2-v1alpha3

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

cc @vadimeisenbergibm

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: costinm
Assign the PR to them by writing /assign @costinm in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

pilot/OWNERS
tests/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

rebased on Vadim's PR.

@cmluciano: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e.sh
fdc5ec644e8e6fea607074396d6ca9b5200c74a2
link
/test istio-pilot-e2e

prow/e2e-bookInfoTests-v1alpha3.sh
fdc5ec644e8e6fea607074396d6ca9b5200c74a2
link
/test e2e-bookInfo-envoyv2-v1alpha3

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
a72a015f0cf99515c50b79f01e55112d20dac7f5
link
/test istio-pilot-e2e-envoyv2-v1alpha3

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@cmluciano: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-bookInfoTests-v1alpha3.sh
fdc5ec644e8e6fea607074396d6ca9b5200c74a2
link
/test e2e-bookInfo-envoyv2-v1alpha3

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
a72a015f0cf99515c50b79f01e55112d20dac7f5
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/istio-pilot-e2e.sh
a72a015f0cf99515c50b79f01e55112d20dac7f5
link
/test istio-pilot-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@cmluciano: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
a72a015f0cf99515c50b79f01e55112d20dac7f5
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/istio-pilot-e2e.sh
a72a015f0cf99515c50b79f01e55112d20dac7f5
link
/test istio-pilot-e2e

prow/e2e-bookInfoTests-v1alpha3.sh
a72a015f0cf99515c50b79f01e55112d20dac7f5
link
/test e2e-bookInfo-envoyv2-v1alpha3

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@cmluciano: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
a72a015f0cf99515c50b79f01e55112d20dac7f5
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/istio-pilot-e2e.sh
a72a015f0cf99515c50b79f01e55112d20dac7f5
link
/test istio-pilot-e2e

prow/e2e-bookInfoTests-v1alpha3.sh
a72a015f0cf99515c50b79f01e55112d20dac7f5
link
/test e2e-bookInfo-envoyv2-v1alpha3

prow/istio-unit-tests.sh
bacc20feeb03299f38776e6f31446b0b070c0623
link
/test istio-unit-tests

prow/istio-presubmit.sh
bacc20feeb03299f38776e6f31446b0b070c0623
link
/test istio-presubmit

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: sebastienvas
Assign the PR to them by writing /assign @sebastienvas in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

tests/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@cmluciano: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e.sh
a72a015f0cf99515c50b79f01e55112d20dac7f5
link
/test istio-pilot-e2e

prow/e2e-bookInfoTests-v1alpha3.sh
a72a015f0cf99515c50b79f01e55112d20dac7f5
link
/test e2e-bookInfo-envoyv2-v1alpha3

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
6cd125609252acab13733dd9070f8317ded1ff49
link
/test istio-pilot-e2e-envoyv2-v1alpha3

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@cmluciano: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-bookInfoTests-v1alpha3.sh
a72a015f0cf99515c50b79f01e55112d20dac7f5
link
/test e2e-bookInfo-envoyv2-v1alpha3

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
6cd125609252acab13733dd9070f8317ded1ff49
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/istio-pilot-e2e.sh
6cd125609252acab13733dd9070f8317ded1ff49
link
/test istio-pilot-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@cmluciano: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
6cd125609252acab13733dd9070f8317ded1ff49
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/istio-pilot-e2e.sh
6cd125609252acab13733dd9070f8317ded1ff49
link
/test istio-pilot-e2e

prow/e2e-bookInfoTests-v1alpha3.sh
6cd125609252acab13733dd9070f8317ded1ff49
link
/test e2e-bookInfo-envoyv2-v1alpha3

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: cmluciano
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: sebastienvas
Assign the PR to them by writing /assign @sebastienvas in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

tests/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

We are close to finalizing 0.8.0. If this PR needed for 0.8.0, please merge ASAP. Otherwise, please merge to master if it is needed for 1.0.0, or close it.

This should go into 0.8 once we fix the current bugs with HTTPs gateways, but it is not release-blocking

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: cmluciano
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: costinm
Assign the PR to them by writing /assign @costinm in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

pilot/OWNERS
tests/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: cmluciano
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: linsun
Assign the PR to them by writing /assign @linsun in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@cmluciano: PR needs rebase.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@cmluciano: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
3e2fdfed205934b2f042aa84a48edf90b5d38ecd
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/istio-presubmit.sh
befdbb728878e43b382481bbc39f2ed6eb1f6a67
link
/test istio-presubmit

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@cmluciano: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
3e2fdfed205934b2f042aa84a48edf90b5d38ecd
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/istio-presubmit.sh
befdbb728878e43b382481bbc39f2ed6eb1f6a67
link
/test istio-presubmit

prow/istio-unit-tests.sh
befdbb728878e43b382481bbc39f2ed6eb1f6a67
link
/test istio-unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@cmluciano: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
3e2fdfed205934b2f042aa84a48edf90b5d38ecd
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/istio-presubmit.sh
befdbb728878e43b382481bbc39f2ed6eb1f6a67
link
/test istio-presubmit

prow/istio-unit-tests.sh
64ce7c2284beb506808aec03522122b2df410fca
link
/test istio-unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@cmluciano: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
3e2fdfed205934b2f042aa84a48edf90b5d38ecd
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/istio-unit-tests.sh
64ce7c2284beb506808aec03522122b2df410fca
link
/test istio-unit-tests

prow/istio-presubmit.sh
64ce7c2284beb506808aec03522122b2df410fca
link
/test istio-presubmit

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: cmluciano
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: costinm
Assign the PR to them by writing /assign @costinm in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

pilot/OWNERS
tests/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@cmluciano: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
3e2fdfed205934b2f042aa84a48edf90b5d38ecd
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/istio-presubmit.sh
64ce7c2284beb506808aec03522122b2df410fca
link
/test istio-presubmit

prow/istio-unit-tests.sh
01f32bc27304a3e0690649a511b62f92b8781f23
link
/test istio-unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@cmluciano: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
3e2fdfed205934b2f042aa84a48edf90b5d38ecd
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/istio-presubmit.sh
64ce7c2284beb506808aec03522122b2df410fca
link
/test istio-presubmit

prow/istio-unit-tests.sh
923a6d5481df461bc5ee1f883ace0f2965e01cec
link
/test istio-unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@cmluciano: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
5845ab17faa238b9eee36fd53be180818c19c734
link
/test istio-pilot-e2e-envoyv2-v1alpha3

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@cmluciano: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
5845ab17faa238b9eee36fd53be180818c19c734
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/istio-pilot-e2e.sh
5845ab17faa238b9eee36fd53be180818c19c734
link
/test istio-pilot-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@cmluciano: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
5845ab17faa238b9eee36fd53be180818c19c734
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/istio-pilot-e2e.sh
5845ab17faa238b9eee36fd53be180818c19c734
link
/test istio-pilot-e2e

prow/e2e-simpleTests.sh
5845ab17faa238b9eee36fd53be180818c19c734
link
/test e2e-simple

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@cmluciano: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
5845ab17faa238b9eee36fd53be180818c19c734
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/istio-pilot-e2e.sh
5845ab17faa238b9eee36fd53be180818c19c734
link
/test istio-pilot-e2e

prow/e2e-simpleTests.sh
5845ab17faa238b9eee36fd53be180818c19c734
link
/test e2e-simple

prow/e2e-bookInfoTests.sh
5845ab17faa238b9eee36fd53be180818c19c734
link
/test e2e-bookInfo

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: cmluciano
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: sebastienvas
Assign the PR to them by writing /assign @sebastienvas in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

tests/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@cmluciano: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e.sh
5845ab17faa238b9eee36fd53be180818c19c734
link
/test istio-pilot-e2e

prow/e2e-bookInfoTests.sh
5845ab17faa238b9eee36fd53be180818c19c734
link
/test e2e-bookInfo

prow/e2e-bookInfoTests-v1alpha3.sh
d8b9bb14b8d50a06976ede0e6122773f021dd121
link
/test e2e-bookInfo-envoyv2-v1alpha3

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
d8b9bb14b8d50a06976ede0e6122773f021dd121
link
/test istio-pilot-e2e-envoyv2-v1alpha3

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@cmluciano: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-bookInfoTests-v1alpha3.sh
d8b9bb14b8d50a06976ede0e6122773f021dd121
link
/test e2e-bookInfo-envoyv2-v1alpha3

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
d8b9bb14b8d50a06976ede0e6122773f021dd121
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/istio-pilot-e2e.sh
d8b9bb14b8d50a06976ede0e6122773f021dd121
link
/test istio-pilot-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.


Eboled node and python samples don't call refresh()

The setcursor() calls in these examples should also be updated with the values from the C++ example which displays nicely now.

Done.


blank info.yaml

please fill in the info.yaml so we can make a great datasheet. Example: https://github.com/mattvenn/tinytapeout_m_segments/blob/main/info.yaml

Thanks! I have filled info.yaml. Let me know if something needs to be changed - I will be happy to do that.
Direct link: https://github.com/krasin/wokwi-guess-my-number/blob/main/info.yaml


[Cocoapods] min_ios_version_supported -> min_supported_versions

Summary:
One of the most common diffs we have in React Native macOS is simply extending the platforms key Inside every pod spec to include macOS. React Native tvOS does the same to add tvOS. In the future, React Native may support visionOS, at which point we do the same thing again. Let's define a min_supported_versions hash that can be overridden at one place that is extensible to more platforms, instead of just specifying min_ios_version_supported.
Note: In doing this change, I have set it that React-Hermes.podspec doesn't build for macOS anymore. I think this is safe, since anyone using Hermes on macOS was probably using React Native macOS where we already have a diff to add macOS back?
Changelog:
[IOS] [CHANGED] - Add min_supported_versions helper to cocoa pods scripts
Test Plan:
CI should pass.

@Saadnajmi could you please rebase on the latest main, as there were unrelated CircleCI failures recently.

@Saadnajmi could you please rebase on the latest main, as there were unrelated CircleCI failures recently.

Uuuh, I seem to have messed up the branch a bit with the rebate, I'll fix shortly

@Saadnajmi there are some Ruby Test failures. Reproducible locally with
cd packages/react-native/scripts
sh run_ruby_tests.sh

Could you please fix them?

@dmytrorykun looks like we're good now!

I don't think it can find the min_supported_versions
What should I do more fetch the value from cocoapods helper?

@bingDBdu Without knowing much of your setup, I see you're using cocoapods 1.15.0, which I think is actually not compatible with React Native at the moment


update window functions doc

Adds more detail about window frames.
Adds information about the strict window frame check: https://github.com/apache/druid/pull/15746
This PR has:

[x ] been self-reviewed.

[ ] using the concurrency checklist (Remove this item if the PR doesn't have any relation to concurrency.)

[ ] added documentation for new or modified features or behaviors.
[ ] a release note entry in the PR description.
[ ] added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links.
[ ] added or updated version, license, or notice information in licenses.yaml
[ ] added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
[ ] added unit tests or modified existing tests to cover new code paths, ensuring the threshold for code coverage is met.
[ ] added integration tests.
[ ] been tested in a test Druid cluster.

Apart from adding a line about the empty OVER() rest LGTM !


ADDON-34275: Implemented table component with actions

JIRA Ticket: https://jira.splunk.com/browse/ADDON-34275
Implemented table component using Splunk-UI with the following functionality:

Quick actions (disable/edit/clone)
Expandable rows feature
Showing the total number of elements in the table
Sorting functionality

NOTE:
Implemented the table component using the static data only
No action will be performed on click on disable/edit/clone button

:tada: This PR is included in version 5.0.0-develop.1 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:

:tada: This PR is included in version 5.0.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Collate Expression broken in 3.0.0

Hi there,
Thanks for the great update to 3.0.0!
I'm running in an issue however in my project; SQL-Statments with collate expressions now aren't parsed correctly any more in .moor files.
Simple Repro:
CREATE TABLE FROMMOOR (
  "textColumn" text
);

repro:
    select * from FROMMOOR
    order by textColumn collate nocase;

Behavior on moor_generator 2.4.0:
[INFO] Generating build script...
[INFO] Generating build script completed, took 352ms

[INFO] Initializing inputs
[INFO] Reading cached asset graph...
[INFO] Reading cached asset graph completed, took 68ms

[INFO] Checking for updates since last build...
[INFO] Checking for updates since last build completed, took 759ms

[WARNING] moor_generator|lib/src/analyzer/moor/moor_ffi_extension.dart was not found in the asset graph, incremental builds will not work.

[WARNING] Invalidating asset graph due to build script update!
[INFO] Cleaning up outputs from previous builds....
[INFO] Cleaning up outputs from previous builds. completed, took 6ms

[INFO] Generating build script...
[INFO] Generating build script completed, took 66ms

[INFO] Creating build script snapshot......
[INFO] Creating build script snapshot... completed, took 11.4s

[INFO] Initializing inputs
[INFO] Building new asset graph...
[INFO] Building new asset graph completed, took 623ms

[INFO] Checking for unexpected pre-existing outputs....
[INFO] Checking for unexpected pre-existing outputs. completed, took 1ms

[INFO] Running build...
[INFO] 1.0s elapsed, 1/5 actions completed.
[INFO] 3.9s elapsed, 1/5 actions completed.
[INFO] 5.0s elapsed, 1/5 actions completed.
[INFO] 8.5s elapsed, 1/5 actions completed.
[INFO] Running build completed, took 8.8s

[INFO] Caching finalized dependency graph...
[INFO] Caching finalized dependency graph completed, took 40ms

Behavior on moor_generator 3.0.0:
[INFO] Generating build script...
[INFO] Generating build script completed, took 353ms

[INFO] Initializing inputs
[INFO] Reading cached asset graph...
[INFO] Reading cached asset graph completed, took 70ms

[INFO] Checking for updates since last build...
[INFO] Checking for updates since last build completed, took 770ms

[WARNING] Invalidating asset graph due to build script update!
[INFO] Cleaning up outputs from previous builds....
[INFO] Cleaning up outputs from previous builds. completed, took 5ms

[INFO] Generating build script...
[INFO] Generating build script completed, took 60ms

[INFO] Creating build script snapshot......
[INFO] Creating build script snapshot... completed, took 11.4s

[INFO] Initializing inputs
[INFO] Building new asset graph...
[INFO] Building new asset graph completed, took 639ms

[INFO] Checking for unexpected pre-existing outputs....
[INFO] Checking for unexpected pre-existing outputs. completed, took 1ms

[INFO] Running build...
[INFO] 1.1s elapsed, 2/5 actions completed.
[INFO] 3.9s elapsed, 2/5 actions completed.
[INFO] 4.9s elapsed, 2/5 actions completed.
[INFO] 8.3s elapsed, 2/5 actions completed.
[WARNING] moor_generator:moor_generator on lib/from_moor.dart:
There were some errors while running moor_generator on package:moor_isolates_close/from_moor.dart:
[WARNING] moor_generator:moor_generator on lib/from_moor.dart:
Error while trying to parse repro: Bad state: Unary operator TokenType.collate not recognized by types2.
[INFO] Caching finalized dependency graph completed, took 29ms

[INFO] Succeeded after 8.7s with 4 outputs (11 actions)

P.S.:
Since 3.0.0, semicolons are required to end statements in .moor files. Before, they were optional. You might want to include this in the Changelog to make it easier to migrate.

Thanks for the report. As a workaround for now, you can enable the legacy_type_inference build option.

Fixed in sqlparser: 0.8.1. Running flutter packages upgrade should fix this.


Deploying nextjs app with pnpm causes Webapp warmup timeout

Description
I have a Github Actions workflow that has been successfully deploying my nextjs app using npm to Azure Static Webapps for a few weeks. I migrated to pnpm for improved dependency management- it was a few lines of code to change. This builds fine locally, but on Github, the build consistently fails with this message:
Finished Upload. Polling on deployment.
Status: InProgress. Time: 0.0557385(s)
....
Status: InProgress. Time:<PHONE_NUMBER>(s)
Status: Failed. Time:<PHONE_NUMBER>(s)
Deployment Failed :(
Deployment Failure Reason: Web app warm up timed out. Please try again later.

Note: typically before this change this check would take about 20 seconds before I get a valid response from the app and the build completes.
To Reproduce
Here are the key files involved (I can't link directly to source, private repo).
# pr.yml
name: Build and deploy (PR)

on:
  pull_request:
    types: [opened, synchronize, reopened]
    branches:
      - main
  workflow_dispatch:

jobs:
  exec:
    uses: ./.github/workflows/build-and-deploy.yml
    secrets: inherit
    with:
      preview: true

# build-and-deploy.yml
name: Build and deploy
...
jobs:
  build_and_deploy:
    name: Build and Deploy
    runs-on: ubuntu-latest
    ...
    steps:
      ...
      - name: Use pnpm ${{ env.PNPM_VERSION }}
        uses: pnpm/action-setup@v3
        with:
          version: ${{ env.PNPM_VERSION }}
      - name: Use Node.js ${{ env.NODE_VERSION }}
        uses: actions/setup-node@v4
        with:
          node-version: ${{ env.NODE_VERSION }}
      - name: Install
        run: |
          # force a development install, to make sure dev dependencies are installed
          # they get filtered out by the standalone build for next
          NODE_ENV=development pnpm install

      - name: Build
        run: pnpm run build

      - name: Test
        run: pnpm run test

      - name: Deploy
        id: deploy
        if: ${{ !env.ACT || env.DEPLOY == 'true' }}
        uses: Azure/static-web-apps-deploy@v1
        with:
          azure_static_web_apps_api_token: ${{ secrets.AZURE_STATIC_WEB_APPS_API_TOKEN }}
          repo_token: ${{ secrets.GITHUB_TOKEN }} # Used for Github integrations (i.e. PR comments)
          action: "upload"
          skip_app_build: true
          skip_api_build: true
          app_location: ${{ env.APP_LOCATION }}
        env:
          skip_deploy_on_missing_secrets: true

Expected behavior
Deployment would succeed and I would be able to access the static web app at the preview URL provided by the build.
Screenshots
n/a
Device info (if applicable):
n/a
Additional context
Not sure what else would help, let me know!

This was a problem for me to, it was based on node_modules not being in the right place or symlinked.
For me it was important to to the following in the .npmrc
shared-workspace-lockfile=false
node-linker=hoisted

which means NO SYMLINKS, but also keep a full node_modules in each project in the shared workspace. If I hoisted the modules to the shared workspace then it would fail with that exact error.
However beware, using this configuration you might run into this problem: https://github.com/pnpm/pnpm/issues/6584

Same issue here

Yeah @petero-dk , this resolved the issue for me too. Thanks so much!


Excuse me, why does the SSA module use multi-head attention and the CFA module does  use single-head attention?

Hi, the use of single-head attention in CFA is to reduce computational cost, since we found that there's no major difference compared with multi-head attention. The underlying reason may due to the channel-wise characteristic. Hope this helps.


What happened to grid-styled?

I just joined a project that is using grid-styled currently.  I was trying to find documentation for it, and https://github.com/jxnblk/grid-styled redirects here.
Is this a rebranding?  Seems there is a totally different npm package for this grid system, as well.  You may want to add something to the documentation that explains what's going on.  Cheers!

I've added a note to the readme, for docs for the previous version, you can view the readme at the previous version https://github.com/rebassjs/grid/tree/v5.0.2


Move CI to GitHub Actions

Travis CI rather abruptly ended its generous open source build plans, and Drupal VM has been without any active CI for almost a month now.
I should rectify that, by moving the existing CI workflows over to GitHub Actions.
I'll maybe also take this opportunity to clean things up a bit and maybe switch to Molecule, if that's an easy transition. If it turns out to be too complicated, I'll drop that and just do a straight migration.

Looks like it might not be so bad moving everything to GH Actions and Molecule at the same time. I might have to do a little extra work getting some of the extra testing steps incorporated, but this is going to make complexity go way down.

Needing to fix some issues in Drush role, Ansible for Kubernetes, and Drupal role to get further on this :P
"It'll be quick," I said to myself earlier today... Here I am 6 hours later.

Drat, now I'm running into the issue from my MySQL role:
TASK [geerlingguy.mysql : Ensure MySQL is started and enabled on boot.] ********
fatal: [instance]: FAILED! => {"changed": false, "msg": "Unable to start service mysql: Job for mariadb.service failed because a timeout was exceeded.\nSee \"systemctl status mariadb.service\" and \"journalctl -xe\" for details.\n"}

Fixed by disabling AppArmor on debian builds: https://github.com/geerlingguy/ansible-role-mysql/issues/422

Follow-up issue: https://github.com/geerlingguy/drupal-vm/issues/2114


Set UID/GID for docker-compose

Summary
Solves issue "Wrong permissions with docker-compose". When installing locally under Linux with
docker-compose up -d --build normally the mount targets for some volumes are not defined: They are created under root
ownership. Files inside these volumes are created with ownership of the UID/GID that the daemons inside the corresponding
container run under. Some as "root", others as 999:0. The patch enforces a certain UID/GID that should be configured in .env
and set to the user's UID/GID. This way daemons run with proper IDs and create files belonging to the user. The directories
need to be created before the first docker-compose build, this advice has been noted in docker-compose.md .
Change Type
Please delete any irrelevant options.

[ x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update
[ x] Documentation update

Testing

git clone repository
edit .env and set proper UID/GID
create the directories mkdir meili_data images .env.production .env.development data-node
docker-compose up -d --build
docker-compose down
docker-compose up -d --build

If step 6 finishes without an error related to permission/ownership of the file meili_data/data.ms/auth/data.mdb,
all works well.
Test Configuration:
Tested under Ubuntu 22.04, docker.io 20.10.25-0ubuntu1~22.04.1
Checklist

[x] My code adheres to this project's style guidelines
[x] I have performed a self-review of my own code
[ ] I have commented in any complex areas of my code
[x] I have made pertinent documentation changes
[x] My changes do not introduce new warnings
[ ] I have written tests demonstrating that my changes are effective or that my feature works
[ ] Local unit tests pass with my changes
[ ] Any changes dependent on mine have been merged and published in downstream modules.

There's a merge conflict with the change of the doc file to docker_compose_install.
Sorry I probably could've avoided this by merging this one first @efocht


The action requested requires authorization

Despite using correct URL and credentials (username + password), the connection to IPCam fails:
Error: Failed to initialize the device: Error: 400 Bad Request - The action requested requires authorization and the sender is not authorized
    at services.device.getDeviceInformation ([...]/node_modules/node-onvif/lib/modules/device.js:453:12)
    at promise.then.catch ([...]/node_modules/node-onvif/lib/modules/service-device.js:853:4)
    at process._tickCallback (internal/process/next_tick.js:68:7)

My mistake, I used wrong credentials without noticing it.

I set the credentials correctly, but get the same error.


Add Travis CI and coverage buttons

Changed README.md

Looks good (for other stuff we should be testing and have at least two other people approving)


Type mismatch with interaction  DragBox condition

In OL 6.6.1 I have a new type error for this case:
import condition from "ol/events/condition";
import OlDragBox from "ol/src/interaction/DragBox";

const exampleDragBox = new OlDragBox({ condition: condition.platformModifierKeyOnly });

(TypeScript gives me one of its famous massive errors, so here's the gist)
"Type '(mapBrowserEvent: MapBrowserEvent<any>) => boolean' is not assignable to type 'Condition'

Did the interface change or is this perhaps revealing a typing error?
As always, thank you.

I'm unable to reproduce this. See https://codesandbox.io/s/eloquent-mountain-mipdd?file=/src/index.ts. The one thing I notice in your code is that you are mixing imports from ol and ol/src.

Thanks for the codesandbox. Didn't realise it was that easy to get OpenLayers + TS working in a sandbox . I'll do my own reproductions next time.
You're right. Removing src fixed it. Need to get vscode to import properly.


[RFC] Layer-shell: Add a request for modifiers.

Add a new request to the zwlr_layer_surface_v1 interface for requesting
to get keybord modifiers. This enables applications like the status bar
to get the current layout and present it.
Signed-off-by: Harish Krupo<EMAIL_ADDRESS>

I am currently working on a module for waybar (PR) to show the current keyboard layout. Each time the user switches the layout using the shortcut set in xkb_options (eg. xkb_options win_space_toggle), the layout switches and the modifier event is sent to the currently focused application. Due to this the bar doesn't get the event and is unable to update the layout.
To remedy this, I have added a new request in the layer_surface interface which adds the client into the notifier list and sends the modifier change information to the client.
This is my first time contributing to wlroots. This patch is a quick hack to get it working. Kindly review the patch and suggest changes. If this is not the way to go then please suggest what else can be done to receive the layout change information.

I don't think this is in scope for layer-shell. Maybe for another protocol?
Please make a PR/open an issue in the wlr-protocols repo first so we can discuss.

There are a few problems here:

Code style is wrong all over the place
Changes to protocols should first be discussed in wlr-protocols
I don't want to add this to layer-shell

I don't think this is in scope for layer-shell. Maybe for another protocol?
Please make a PR/open an issue in the wlr-protocols repo first so we can discuss.

Sure, will do so.

There are a few problems here:

Code style is wrong all over the place

Yes, this is just for comments. I will fix them :)

Changes to protocols should first be discussed in wlr-protocols

Okay, will do so.

I don't want to add this to layer-shell

Closing because this definitely shouldn't go in layer-shell.


Add Option to Not Prompt for Authentication on Startup

Is your feature request related to a problem? Please describe.

I don't want to sign in to my GitHub account, but every time I open VSCode with this plugin installed I'm prompted by this notification to sign in. There doesn't appear to be any way to say "Don't remind me again"
Describe the solution you'd like
Some way to say that I don't want to be prompted to sign in with my github account every time I open VSCode.

This would be helpful because this extension installed in the Flatpak never remembers logging in anyway, so it's necessary to dismiss the login notification every time I run VS Code.


failed calling webhook

I create a K8s cluster on my vmware with the follow config:
kubernetes 1.13.1 istio 1.1.5 etcd 3.3.0
master <IP_ADDRESS> kube-apiserver control-manager ，scheduler，etcd01
node1 <IP_ADDRESS> kubelet ,flannel,etcd02,kube-proxy
node2 <IP_ADDRESS> kubelet ,flannel,etcd03,kube-proxy
and today I use the istio-demo.yaml to install the istio 1.1.5, I have set up the k8s plugins as it saying , but the automatic sidecar injection failed .And then when I want to install the bookinf-gateway, the error happen:
https://istio.cn/uploads/default/original/1X/75b74d6314a5b4387cfb96c3281d8479ce6972b3.png
I desire to get some help from you, please!

Sounds like Galley may not be running? Can you get the output of kubectl get pods -n istio-system and the logs for the galley pod

@LeoLee98 Were you able to solve this issue?


Use existing login

I am looking to automate, a bit, but not the ARI Automation way. Not through runbooks.
I work for a CSP, and I would like to pull tenant IDs from the partner center and run this against each customer tenant without having to get a new login prompt for each. Is that possible without a managed identity and application id?

I believe it is indeed. But you would have to edit the main script to instead of authenticate, just change the tenant id...
It would require some customizations


enhancement: Make it more clear what column is the arrow positioned in, when it's visible in TableCell

https://discord.com/channels/1015005816094478347/1015005816648118347/1227004845626494998

Closed in https://github.com/marc2332/freya/commit/f289d7fd10ccf8500f2dda225244137374310a72


Text bug and highlight in the visual mode only on java

There is no issue in python but not for java I don't know why.

close to zero info in this bug report. search existing issues, visual mode has some known quirks.

Same happening to me.


default value initialization to avoid redundant variable assignment

Sub-Tasks

[x] Modify wavefield.cc to initialize the wavefield parameter with default values and update them only when a user passes a value for it in the SDF file.
[x] Modify all world sdf files in order only to have PMS model wave parameters, namely -- direction, steepness, gain, and period(will do it after the first review)

Summary
The modification avoids repeated initialization of some wavefield variables, which always have the same value across all world files. Therefore now, the publisher allows the user to indicate solely the variable they wish to modify, leaving the remaining variables to be managed automatically.
Test it
To test this, one can use the sydney_regatta.sdf. The world file currently only publishes direction, steepness, gain, and period.

For now, please review this using the testing instructions above to make sure the sydney_regatta.sdf is working properly.

@tejalbarnwal This seems to be working fine for syndey_regatta.sdf

@tejalbarnwal This seems to be working fine for syndey_regatta.sdf

great, I will go ahead and push the updated world files

update: I have updated all the world files

@tejalbarnwal Is this PR also intended to address issue #684 (which we discussed in our meeting but I only just wrote up today)? If so, we should wait to merge it until we figure out what the new parameters should be. Otherwise we can merge this now and create a new PR for #684. What would you prefer?

@tejalbarnwal Is this PR also intended to address issue #684 (which we discussed in our meeting but I only just wrote up today)? If so, we should wait to merge it until we figure out what the new parameters should be. Otherwise, we can merge this now and create a new PR for #684. What would you prefer?

We could merge this and create a new PR to address #684; this way, we could have a clean commit log for the repo. I was also thinking if I should squash all the commits made to this branch to just one commit?

@tejalbarnwal Ok, in that case I'll make a new PR soon with the new wavefield values. Could you review it today?
I don't usually squash commits but I don't think it's a problem if you prefer that.

@tejalbarnwal Ok, in that case I'll make a new PR soon with the new wavefield values. Could you review it today?
I don't usually squash commits but I don't think it's a problem if you prefer that.
Edit: Also, since this is approved and we aren't modifying it further and we're wrapping up for the release today, it would help if you could merge it soon. Thanks!

Yes, I will test out the parameters specified wave model envelope in #684. I will let you know in a few minutes if any warnings or error is raised on my system
Oh, I wasn't aware that I could merge it. I am used to reviewers merging it in other repos. I will merge it now.

@tejalbarnwal Thanks and no problem. We let the creator of the PR perform the merge (if you have the permissions, which you do).
You are welcome to play around with the wave parameters, but I will also soon have a PR for you to review with specific values for the various practice worlds.

@tejalbarnwal Thanks and no problem. We let the creator of the PR perform the merge (if you have the permissions, which you do).
You are welcome to play around with the wave parameters, but I will also soon have a PR for you to review with specific values for the various practice worlds.

yup, I will review it!


Add a support listeners with union type of event + Allow pass one listener to muiltiple event class names in ListenerCollection::add()

Q
A

Is bugfix?
✔

New feature?
✔

Breaks BC?
❌

Fixed issues
#62

👍


Faraday 2.0

Hello guys, big thanks for your hard work here!
Do you have any plans to release support for Faraday 2?
Best!

@maszuDEV yes its on the backlog. I'll post the upgrade link here for reference incase anyone wants to create a PR. https://github.com/lostisland/faraday/blob/main/UPGRADING.md

https://github.com/decision-labs/fcm/pull/101


Specified shape incompatible with data.

I keep getting this error when trying to predict
"Error: Specified shape incompatible with data."
I guess my question is how do I know the specified shape ? And where do i find it ?

Can someone please help ?


I'm getting 'undefined'

I have a electron app where I'm trying to check if a connection is availible. I've done it like in your readme but the console logs always undefined.
I have also tried your is-reachable with the google example, but same result.

Are you sure you check the correct parameter in the callback? The first is most likely the error (which will be undefined).

yep, I'm sure.
Here is my code:
isReachable('google.com:80', (err, reachable) => {
    console.log(reachable);
});

or
isOnline(function(err, online) {
    console.log(online);
});

And what does err return?
From the docs

Same as above except the callback doesn't have an error parameter.

Not sure if err is undefined or the first param actually is the result.

I've also tried the following while connected / disconnected:
isOnline(function(online) {
    console.log(online);
});

Both results were false

BTW. I'm including it via import isOnline from 'is-online'; and compile it then with babel.
But that should be not the reason for this issue. I hope.
All the other ES6 stuff works well.

Neither is-online nor is-reachable are capable of returning undefined to the callback. Try this in the REPL (the null true are the callback args in this case):
$ node
> require('is-reachable')('sindresorhus.com', console.log)
undefined
> null true

@silverwind
GET file://google.com/favicon.ico?1457219323579 net::ERR_FILE_NOT_FOUND
maybe it's because of electron ?

You're getting the browser API: https://github.com/sindresorhus/is-reachable/blob/master/browser.js
As to why, I'm not sure, I thought electron scripts should get the node version?

Hey I ran into the same issue. It may be because there is no main property set in the package.json. Also if you're using browserify or webpack they will fallback to browser instead. Great little lib though. 😃

It may be because there is no main property set in the package.json.

Proof? Electron handles no "main" just fine, which is optional btw.

@sindresorhus I experienced a similar issue and at the time was investigating that avenue. It was a maybe rather than a definite.
The actual issue is that the documentation is wrong on the signature of the function.
The first item is the online status and not an error. Thats why they're getting undefined.
isOnline((online) => {
$scope.isOnline = online;
});
should work as expected.

I'd say the documentation is right. Both is-online and is-reachable have:

Browser API
Same as above except the callback doesn't have an error parameter.

The issue here is still, that electron should never get browser.js in first place. Maybe someone affected can test if adding main resolves this.

in fact electron runs two processes

main process (node server)
renderer (chromium browser / client)

so (it is how it should be) if you run it from the renderer it's the browser api.


xdg-desktop-portal: 1.8.0 -> 1.8.1

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://github.com/flatpak/xdg-desktop-portal/releases.
meta.description for xdg-desktop-portal is: "Desktop integration portals for sandboxed apps"
meta.homepage for xdg-desktop-portal is: ""
meta.changelog for xdg-desktop-portal is: ""
Updates performed

Version update

To inspect upstream changes

Release on GitHub

Compare changes on GitHub

Impact

Checks done (click to expand)

built on NixOS

Warning: a test defined in passthru.tests did not pass

0 of 0 passed binary check by having a zero exit code.

0 of 0 passed binary check by having the new version present in output.

found 1.8.1 with grep in /nix/store/hbjfx76djplwf0pgx0wnzsjkgavc47c5-xdg-desktop-portal-1.8.1

directory tree listing: https://gist.github.com/a678e2fba703005114068f19d7fdb3ba

du listing: https://gist.github.com/b1d176d1399cdc9c1b0050b6a5be9087

Rebuild report (if merged into master) (click to expand)

6 total rebuild path(s)

2 package rebuild(s)

2 x86_64-linux rebuild(s)
2 i686-linux rebuild(s)
0 x86_64-darwin rebuild(s)
2 aarch64-linux rebuild(s)

First fifty rebuilds by attrpath
xdg-desktop-portal
xdg-desktop-portal-gtk

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/hbjfx76djplwf0pgx0wnzsjkgavc47c5-xdg-desktop-portal-1.8.1 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A xdg-desktop-portal https://github.com/r-ryantm/nixpkgs/archive/33bd0c92b0f8b1090aa055e1cea759eb7053004e.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/hbjfx76djplwf0pgx0wnzsjkgavc47c5-xdg-desktop-portal-1.8.1
ls -la /nix/store/hbjfx76djplwf0pgx0wnzsjkgavc47c5-xdg-desktop-portal-1.8.1/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

2 packages built:

xdg-desktop-portal
xdg-desktop-portal-gtk

Maintainer pings
cc @jtojnar for testing.

Result of nixpkgs-review pr 113632 at 33bd0c92 run on aarch64-linux 1

2 packages built:

xdg-desktop-portal
xdg-desktop-portal-gtk

1 suggestion:

warning: unclear-gpl
lgpl21 is a deprecated license, check if project uses lgpl21Plus or lgpl21Only and change meta.license accordingly.
Near pkgs/development/libraries/xdg-desktop-portal/default.nix:81:5:
   |
81 |     license = licenses.lgpl21;
   |     ^

Remove fontconfig dependency.

Not @r-ryantm , but fixed.

Tests were already broken so SNAFU.


charmxi: Update list of builtin types

Remove unnecessary size_t and bool (revert from #2775)
Add some rarer multi-word types

Fixes #3065

I assume passing size_t and bool to entry methods would still work after the revert?

I assume passing size_t and bool to entry methods would still work after the revert?

Yes. For example, tests/charm++/zerocopy/zc_post_modify_size/zc_post_modify_size.ci includes entry void recv_zerocopy(nocopypost int buffer[size], size_t size, bool isBcast);.
There is no benefit to including them in BuiltinTypes. I searched through the charmxi source and couldn't find any special behavior that such a designation would give. My guess is that it is only necessary for types like unsigned int that have a space in the middle.


Supporting bundle/resource entry metadata

Resource filter interface to support bundle/resource entry metadata.
Updated CLI / maven / ant to handle the new metadata fields in bundle
and resource entry.

Coverage decreased (-1.8%) to 49.13% when pulling 1160d7b881eea2dd01d75fdad90d1459e022bf25 on yumaoka:rfe-106-metadata into<PHONE_NUMBER>85c34952446539ddd33656b44b58dc on IBM-Cloud:master.

Coverage decreased (-1.8%) to 49.13% when pulling 1160d7b881eea2dd01d75fdad90d1459e022bf25 on yumaoka:rfe-106-metadata into<PHONE_NUMBER>85c34952446539ddd33656b44b58dc on IBM-Cloud:master.


Can I get a spatial mesh map by streaming ?

We can see camera live video by streaming by SDK initial option, but can we get spatial mesh map by streaming ?
How can I make it real?
I want to use ZED mini on drone , and watch spatial mesh map sent by flying drone in real time.

Use the Spatial mapping sample and change the input to :
init_parameters.input.setFromStream(ip,port);

Okay.
So,how should I change the code and where to chang?
I'm pasting the "Spatial Mapping code" below.
if (sscanf(arg.c_str(),"%u.%u.%u.%u:%d", &a, &b, &c, &d,&port) == 5) {
// Stream input mode - IP + port
string ip_adress = to_string(a)+"."+to_string(b)+"."+to_string(c)+"."+to_string(d);
param.input.setFromStream(sl::String(ip_adress.c_str()),port);
cout<<"[Sample] Using Stream input, IP : "<<ip_adress<<", port : "<<port<<endl;
}
else  if (sscanf(arg.c_str(),"%u.%u.%u.%u", &a, &b, &c, &d) == 4) {
// Stream input mode - IP only
param.input.setFromStream(sl::String(argv[1]));
cout<<"[Sample] Using Stream input, IP : "<<argv[1]<<endl;
}

Okay.
So,how should I change the code and where to chang?
I'm pasting the "Spatial Mapping code" below.

if (sscanf(arg.c_str(),"%u.%u.%u.%u:%d", &a, &b, &c, &d,&port) == 5) {
// Stream input mode - IP + port
string ip_adress = to_string(a)+"."+to_string(b)+"."+to_string(c)+"."+to_string(d);
param.input.setFromStream(sl::String(ip_adress.c_str()),port);
cout<<"[Sample] Using Stream input, IP : "<<ip_adress<<", port : "<<port<<endl;
}
else if (sscanf(arg.c_str(),"%u.%u.%u.%u", &a, &b, &c, &d) == 4) {
// Stream input mode - IP only
param.input.setFromStream(sl::String(argv[1]));
cout<<"[Sample] Using Stream input, IP : "<<argv[1]<<endl;
}

Since we already provide the way to use streaming input in the spatial mapping sample, you don't have to change anything. Just launch this way :
$ ./ZED_Spatial_Mapping :port
For example,
$ ./ZED_Spatial_Mapping <IP_ADDRESS>:30000

I see!
Thank you so much.
$ ./ZED_Spatial_Mapping <IP_ADDRESS>:30000
Above comand should be at Receiver side?
How about Sender side?

Receiver :
$ ./ZED_Spatial_Mapping <IP_ADDRESS>:30000
Sender  (no need to specify IP)
$ ./ZED_Streaming_Sender

I see.
So at the Receiver side, which should I tipe "$ ./ZED_Spatial_Mapping 192.168....(port)" in the directory,
\spatial mapping\cpp\build
or
\camera streaming\receiver\cpp\build ???

My receiver side is visual studio 2019, how can I represent the comand code ,$ ./ZED_Spatial_Mapping <IP_ADDRESS>:30000?

$ is just to indicate that it must run in a terminal...
On windows, the syntax will be more (in a terminal ) :
ZED_Spatial_Mapping.exe <IP_ADDRESS>:30000

I understand it now.
Thanks a lot!


Create view to get dealer list

Task 1/4 to create the proxy services for the Cloud functions.
Create the get_dealerships view to get the list of dealers.

So it seems one step of the instructions wanted to use the web action URL instead of the API to get all the dealers...
The link includes my email in it, so I'd rather not. (It'd also require an extra step to authenticate when there's a perfectly good API setup for it already.)

BUG: Actually Calling the API in view
https://github.com/dreammelter/agfzb-CloudAppDevelopment_Capstone/blob/55aed49aaed61f7a99621402581a92df4e9a56b3/server/djangoapp/restapis.py#L36-L61
For whatever reason, Django throws a KeyError when I try to access the Dealer info from the list of Dealership JSON objects received. (After calling the API method in the view)
https://github.com/dreammelter/agfzb-CloudAppDevelopment_Capstone/blob/55aed49aaed61f7a99621402581a92df4e9a56b3/server/djangoapp/views.py#L100-L113
Which, I see we are receiving....

I can print each dealer (instead of creating new CarDealer) and the whole dictionary is returned, as expected.

I tried recreating something similar outside the project and it works as expected:
#test ways to unpack dictionaries stored in lists...

# our dictionary list:
# this is essentially what our "dealers" list looks like.
d_list = [
    {'a':1,'b':"two",'c': False},
    {'a':"one", 'b':True, 'c':3},
    {'a':True,'b':2, 'c':"three"}
]

# this is what our plain CarModel class looks like
class Model:
    def __init__(self, a, b ,c) -> None:
        self.a = a
        self.b = b
        self.c = c

    def __str__(self) -> str:
        return self.a

d_list.items() # Error: this is a list object

for d in d_list:
    d.items()

for d in d_list:
    for k, v in d.items():
        # here making some sort of factory/higher order func would be useful...
        # or use a constructor method, yeah
        dict(k=v) # this ends up making a bunch of little dictionaries that all have a key of 'k'

o_list = []

for d in d_list:
    # d is accessing the individual dict entry, right?
    new_obj = Model(a=d['a'], b=d['b'], c=d['c'])
    o_list.append(new_obj)

# that works as expected...
# o_list is now a collection of objects.
# objs, whose properties we can access with a .
o_list[0].a
o_list[2].b
o_list[1].c

# this creates a (dict length ** 2) number of objects... so 9 in our case.
# however this was one solution that Django accepted at one point
# except I can't seem to replicate it now since I didn't keep the code.
x_list = []
for d in d_list:
    for i in d:
        new_obj = Model(a=d['a'], b=d['b'], c=d['c'])
        x_list.append(new_obj)

Not sure what's going on here... (wrong type? Data suddenly disappears?)
This practically crashes the whole front page.

test_access = dealers[0]['address'] works as expected. 🙃

Since Django worked fine with a second for-loop being used to access each key in the dict, used a while loop to short circuit it before making a new obj per key.
I could also be wrong about my assumption that each dealer obj is in fact a dictionary, but IDK... it was half working and the mockup also worked.
https://github.com/dreammelter/agfzb-CloudAppDevelopment_Capstone/blob/ccfe9cc6325a0a820c04ee8842aca07b44e3345a/server/djangoapp/restapis.py#L55-L64

Still need a separate "get dealers by state" method (and thus a new API link.)


Chrome-Pinterest-Extension

Here I intend to create a Pinterest extension in Chrome browser using html, css and javascript.
It helps us collect, organize, save and revisit our inspiring ideas whenever we wish to.
Please assign me this issue, I'm a GSSoc22 participant.

/assign

We are not accepting new projects as of now. Keep an eye on the announcement channel on discord of this repo for further instructions.


Training not converging with default settings

Hi,
we're from the University of Wuerzburg and tried to replicate your project for German report data.
For now, we simply tried to get your code to run and train on MIMIC with the default settings provided as well as the settings provided in your paper. Of course, we made sure to have the same package versions as in the project.
However, we quickly get NaN loss after some iterations. So first, we tried to create a subsample of the dataset. For a very small dataset (~300 images), the training does converge. However, even for 1000 images the loss does not get smaller. We also tried several different learning rates and hyperparameters, but nothing helped so far.
I was hoping that you might be familiar with our problems and give us advice here.
Thanks in advance!

Hi AmarHek,
Did you solve this issue? I'm trying to run the code and having the same trouble.
Thanks.

Hi felipezeiser!
we actually did solve it, it was a huge mistake on our side!
Our Github Repo was set to use LFS and we had the reports inside the repo, which lead to the contents simply being links to github LFS.
When we actually trained on the proper reports, we had no problems running the code.
Maybe you have a similar issue on your end, fingers crossed!
Kind regards
Amar

Thank you very much for the quick response.
Unfortunately it is not the same problem as we all have cases on a secondary HD in the cluster. And apparently the reports are being sent correctly to TextEncoder.
If it doesn't bother me to ask a few more questions, how much did you use a batch size? Did you evaluate other parameters besides the default ones?


Introduce a rake test:asan task for convenient running of Address Sanitiser

Sample output:

P.S.
The detected error is in the last part of the conditional statement here:
https://github.com/discourse/mini_racer/blob/f407f68b534c16193222e9365841ac22bcc2ba4b/ext/mini_racer_extension/mini_racer_extension.cc#L1214-L1216
I am not too sure what's the idea here, so I chose not to change it.

I am more than happy to try this out!


Update list of systemlibs and add script to verify

I noticed that in addition to com_github_googleapis_googleapis being missing as a system lib (see #42361) the new typing_extensions_archive wasn't added to the list of valid options.
This simply removes the com_github_googleapis_googleapis, the alternative is to readd it as the new name com_google_googleapis and readd (and potentially update) the system build file but I can't verify this. Maybe  @perfinion may?
It also adds typing_extensions_archive as a valid option.
I also made a script which points out those issues. I'd like to have that added to CI as this acts like a basic sanity check. Could anyone from the TF team guide me on how to do that?

I like this, thank you.

@mihaimaruseac Could you tell me where I could add this so it is run by the CI scripts for PRs?

@mihaimaruseac Could you tell me where I could add this so it is run by the CI scripts for PRs?

I talked with mihai at yesterday's SIG-Build meeting, we're not really sure about where yet. Lets get this merged first then maybe we can do a github action, the complicated part is most of their kokoro alerting is internal to google so there isnt a way to notify you and I. initially i'll try running a cronjob on my build machine until we figure out alerting

Sorry, came to review GitHub stuff only now. We could try Github Actions at one point in the future, besides what perfinion@ said.

I used GHA in the past and it is generally very easy to use. I could add one to run this to this PR or a follow up. It should be pretty trivial (checkout, setup python, run script) but needs maybe some bikeshedding about names and probably someone need to enable GHA for this repo. Also it will only run AFTER it is merged, so testing is a bit nasty. I could test it in my fork and link that in the PR though
IMO running linters and such things like this are perfect for GHA as they are fast and easy to set up. Also that takes off pressure from the other tests

Let's rebase this on master again, that should fix sanity build

Rebased

I'm not sure if im mis-reading the patches after the rebase or not?
it looks like "typing_extensions_archive" is removed from syslibs_configure.bzl?
That got added in commit b7871f8a232536fcb6e388bb05a9fd7171ff3a96 so should stay in the valid list

Good catch, thanks! Corrected and rebased to current master