undefined local variable or method `tagged_logger' during perform_enqueued_jobs

What Ruby, Rails and RSpec versions are you using?
Ruby version: 3.0.3p157 (2021-11-24 revision 3fb7d2cadc) [x86_64-darwin21]
Rails version: 7.0.0
RSpec 3.10

rspec-core 3.10.1
rspec-expectations 3.10.1
rspec-mocks 3.10.2
rspec-rails 5.0.2
rspec-support 3.10.3

Observed behaviour
Inside an rspec support module, my app is calling perform_enqueued_jobs. The spec in question that is using this support module is expecting this call to raise an exception.
When I attempt to run this spec, the following is raised:
got #<NameError: undefined local variable or method `tagged_logger'

When I debug into perform_enqueued_jobs, I am taken into _assert_nothing_raised_or_warn inside activesupport-7.0.0/lib/active_support/testing/assertions.rb, When debugging the block below, it shows e as having the expected exception.
        rescue Minitest::UnexpectedError => e
          if tagged_logger && tagged_logger.warn?
            warning = <<~MSG
              #{self.class} - #{name}: #{e.error.class} raised.
              If you expected this exception, use `assert_raises` as near to the code that raises as possible.
              Other block based assertions (e.g. `#{assertion}`) can be used, as long as `assert_raises` is inside their block.
            MSG
            tagged_logger.warn warning
          end

          raise
        end

Debugging further reveals that the if tagged_logger check above is causing the undefined error.
I reported this on Rails forum here and a member of the core team suggested the following:
"This seems to be a bug in RSpec that doesn’t implement the tagged_logger. Please report the issue in the RSpec issue tracker."
Expected behaviour
The spec should finish and allow to raise_error to check for the expected exception. This spec is working as expected in Rails 6.

Thanks for reporting.
tagger_logger seems to have been introduced in this commit. Wondering if we should work this around by setting it to nil in our adapters code, or this should be fixed in Rails. Wondering where this tagged_logger is defined/initialized in Rails code for testing.
Would you like to dig deeper in this, @jkwuc89 ?

I'll take a deeper dive into this and report what I find.

It feels like they are checking for a tagged logger by assuming it exists, they could easily fix this by checking its defined

Inside the Rails PR that added the block I included in the description above, one finds this comment which suggests checking if tagged_logger is defined. 🤔
https://github.com/rails/rails/pull/42459#discussion_r771836505

I think rspec-rails should be responsible for making sure the features of ActiveSupport::TestCase it uses works with RSpec, nor Rails that should check if its own API is existent.

Thanks for the hints @rafaelfranca, @ghiculescu.
@jkwuc89 Does it fix the issue if you add the following to rspec-rails' lib/rspec/rails/example/rails_example_group.rb?
        extend ActiveSupport::Concern
+       include ActiveSupport::Testing::TaggedLogging
        include RSpec::Rails::SetupAndTeardownAdapter

Here is a quick monkey patch using @pirj suggested solution
# spec/rspec_helper.rb

require 'rspec/rails/version'

if Gem::Version.create(RSpec::Rails::Version::STRING) < Gem::Version.create("5.1.0")
  RSpec::Rails::RailsExampleGroup.module_eval do
    include ActiveSupport::Testing::TaggedLogging
  end
end

Adding the following to spec/rails_helper.rb inside my Rails project allows tagged_logger to get defined which fixes the original undefined error in the description above.
if Rails::VERSION::MAJOR >= 7
  include ActiveSupport::Testing::TaggedLogging
end

Unfortunately, it causes another issue when I run the spec in question. When _assert_nothing_raised_or_warn is called inside activesupport-7.0.0/lib/active_support/testing/assertions.rb as part of handling an exception during perform_enqueued_jobs, it causes the spec to fail with the following because _assert_nothing_raised_or_warn uses name inside its definition.
expected Workflow::SellerAuthorization::MissingSellerAuthorizationError, got #<RSpec::Core::ExampleGroup::WrongScopeError: `name` is not available from within an example (e.g. an...ore`, `let`, etc). It is only available on an example group (e.g. a `describe` or `context` block).> with backtrace:
  # ./spec/support/events/async_event_processor.rb:6:in `publish_event_inline'
  # ./spec/models/workflow/seller_authorization_spec.rb:668:in `block (3 levels) in <top (required)>'
  # ./spec/models/workflow/seller_authorization_spec.rb:699:in `block (6 levels) in <top (required)>'
  # ./spec/models/workflow/seller_authorization_spec.rb:699:in `block (5 levels) in <top (required)>'
  # ./spec/spec_helper.rb:20:in `block (2 levels) in <top (required)>'

I'm using the following crappy patch, as including the module into RSpec::Rails::RailsExampleGroup did not do anything.
Also defined a dummy name method (sigh), to resolve the subsequent issue that @jkwuc89 raises just above (which this also runs into)
if Rails::VERSION::MAJOR >= 7
  require 'rspec/rails/version'

  RSpec::Core::ExampleGroup.module_eval do
    include ActiveSupport::Testing::TaggedLogging

    def name
      'foobar'
    end
  end
end

PRs would be accepted to solve this, RailsExampleGroup should conditionally (as in, if on Rails 7) include this module, and ideally we'd want a snippet testing it.

This was fixed in 6.0.0 and further improved in 6.0.1

Please provide a reproduction snippet.

I am getting this error in 6.0.1 with this test:
it "test description" do
  expect {
    perform_enqueued_jobs do
      # test an email sending method here
    end
  }.to change { ActionMailer::Base.deliveries.size }.by(2)
end

I also see the same error with 6.0.1, my code looks similar
      specify do
        expect { perform_enqueued_jobs { dispatch } }
          .to not_change(ActionMailer::Base.deliveries, :size)
          .and not_raise_error

Ruby 3.2.1, rails 7.0.4

Does the monkey patch mentioned above fix it for you @riffraff @joemsak ?
It would be very helpful if you could provide a runnable snippet to reproduce the issue. doc, examples.
Just for the reference, related PRs: #2587, #2625.

@pirj I just saw this error in 6.0.1, and the monkey patch above https://github.com/rspec/rspec-rails/issues/2545#issuecomment-1029539971 can fix the issue.
However, I find I missed type: :job in my spec. If I add it, everything works fine. I think it's because the error is raised by RSpec::Core::ExampleGroup if I don't add type: :job, so the monkey patch works. When running a spec with type: :job, RSpec::Rails::RailsExampleGroup is included, so the fix works. Does it make sense?

If it’s not a Rails example group (no ‘type:’ set), why it is expected to include the code introduced in #2587 ?
I would refrain from including this to non-Rails example groups.
Am I missing something?

Still see this issue and https://github.com/rspec/rspec-rails/issues/2545#issuecomment-1029539971 helps resolve it but would like to understand why https://github.com/rspec/rspec-rails/pull/2587 doesn't fix things?

I'm running this code:

describe "#request_token" do
it "returns a successful response" do
post :request_token, params: { username<EMAIL_ADDRESS>password: '21dxM{XkwHwM6=$' }
expect(response).to have_http_status(:success)
end
end

and am getting this error:
=> There was an error building fixtures
=> #<ArgumentError: wrong number of arguments (given 0, expected 1+)>

/.rbenv/versions/3.2.2/lib/ruby/gems/3.2.0/bundler/gems/fixture_builder-7a042cc63699/lib/fixture_builder/namer.rb:16:in name' /.rbenv/versions/3.2.2/lib/ruby/gems/3.2.0/bundler/gems/fixture_builder-7a042cc63699/lib/fixture_builder/delegations.rb:16:in name'
/.rbenv/versions/3.2.2/lib/ruby/gems/3.2.0/gems/activesupport-<IP_ADDRESS>/lib/active_support/testing/assertions.rb:254:in rescue in _assert_nothing_raised_or_warn' /.rbenv/versions/3.2.2/lib/ruby/gems/3.2.0/gems/activesupport-<IP_ADDRESS>/lib/active_support/testing/assertions.rb:249:in _assert_nothing_raised_or_warn'

I got past the first "tagged logger" error by adding include ActiveSupport::Testing::TaggedLogging, however I'm seeing this afterward and haven't seen anything addressing it. Adding def name did not work for me.

I'm running this code:

describe "#request_token" do
it "returns a successful response" do
post :request_token, params: { username: 'XXX', password: 'XXX' }
expect(response).to have_http_status(:success)
end
end

and am getting this error:

=> There was an error building fixtures
=> #<ArgumentError: wrong number of arguments (given 0, expected 1+)>

/.rbenv/versions/3.2.2/lib/ruby/gems/3.2.0/bundler/gems/fixture_builder-7a042cc63699/lib/fixture_builder/namer.rb:16:in name' /.rbenv/versions/3.2.2/lib/ruby/gems/3.2.0/bundler/gems/fixture_builder-7a042cc63699/lib/fixture_builder/delegations.rb:16:in name'
/.rbenv/versions/3.2.2/lib/ruby/gems/3.2.0/gems/activesupport-<IP_ADDRESS>/lib/active_support/testing/assertions.rb:254:in rescue in _assert_nothing_raised_or_warn' /.rbenv/versions/3.2.2/lib/ruby/gems/3.2.0/gems/activesupport-<IP_ADDRESS>/lib/active_support/testing/assertions.rb:249:in _assert_nothing_raised_or_warn'

I got past the first "tagged logger" error by adding include ActiveSupport::Testing::TaggedLogging, however I'm seeing this afterward and haven't seen anything addressing it. Adding def name did not work for me.

I'm still seeing this issue with Ruby (3.3.5), Rails (7.1.4), rspec (3.13.0), rspec-rails (7.0.1). To me it's pointing here:
NameError:
       undefined local variable or method `tagged_logger' for an instance of FactoryBot::SyntaxRunner

But don't think is has to do with FactoryBot, it's seems is just because I have my perform_enqueued_jobs in a factory.
Any news on this cc @jkwuc89 @pirj @JonRowe

@sebaherrera07 Can you please:

open a new issue
link to this one
provide a backtrace
provide a repro example


Please add LinkedIn Support

Checklist

[x] I'm reporting a new site support request

[x] I've verified that I'm running youtube-dl version 2021.12.17

[x] I've checked that all provided URLs are alive and playable in a browser

[x] I've checked that none of provided URLs violate any copyrights

[x] I've searched the bugtracker for similar site support requests including closed ones

https://www.linkedin.com/learning/python-essential-training-14898805/challenge-handling-arguments?autoplay=true&resume=false

Description
I want to download LinkedIn Video Courses, But It Gives me This error:
>> youtube-dl 'https://www.linkedin.com/learning/python-essential-training-14898805/challenge-handling-arguments?autoplay=true&resume=false' --verbose
[debug] System config: []
[debug] User config: ['--buffer-size', '16384', '--external-downloader', 'aria2c', '--external-downloader-args', '--continue=true --file-allocation=prealloc --max-concurrent-downloads=24 --max-connection-per-server=16 --split=24 --min-split-size=1M', '--continue', '-f', 'bestvideo+bestaudio', '--merge-output-format', 'mkv', '--embed-subs', '--fixup', 'detect_or_warn', '--download-archive', 'C:\\Users\\nom4d\\AppData\\Roaming\\youtube-dl\\arch.txt', '--output', 'G:\\yt-dlp\\%(playlist)s\\%(playlist_index)s - %(title)s.%(ext)s', '--ignore-errors', '--no-overwrites', '--youtube-skip-dash-manifest']
[debug] Custom config: []
[debug] Command-line args: ['https://www.linkedin.com/learning/python-essential-training-14898805/challenge-handling-arguments?autoplay=true&resume=false', '--verbose']
[debug] Encodings: locale cp1252, fs utf-8, out utf-8, pref cp1252
[debug] youtube-dl version 2021.12.17
[debug] Python version 3.11.1 (CPython) - Windows-10-10.0.22621-SP0
[debug] exe versions: ffmpeg N-55702-g920046a, ffprobe N-55702-g920046a, phantomjs 2.1.1
[debug] Proxy map: {}
ERROR: An extractor error has occurred. (caused by KeyError('JSESSIONID')); please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; see  https://yt-dl.org/update  on how to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.
Traceback (most recent call last):
  File "C:\Program Files\Python311\Lib\site-packages\youtube_dl\extractor\common.py", line 534, in extract
    ie_result = self._real_extract(url)
                ^^^^^^^^^^^^^^^^^^^^^^^
  File "C:\Program Files\Python311\Lib\site-packages\youtube_dl\extractor\linkedin.py", line 95, in _real_extract
    video_data = self._call_api(
                 ^^^^^^^^^^^^^^^
  File "C:\Program Files\Python311\Lib\site-packages\youtube_dl\extractor\linkedin.py", line 36, in _call_api
    'Csrf-Token': self._get_cookies(api_url)['JSESSIONID'].value,
                  ~~~~~~~~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^
KeyError: 'JSESSIONID'
Traceback (most recent call last):
  File "C:\Program Files\Python311\Lib\site-packages\youtube_dl\extractor\common.py", line 534, in extract
    ie_result = self._real_extract(url)
                ^^^^^^^^^^^^^^^^^^^^^^^
  File "C:\Program Files\Python311\Lib\site-packages\youtube_dl\extractor\linkedin.py", line 95, in _real_extract
    video_data = self._call_api(
                 ^^^^^^^^^^^^^^^
  File "C:\Program Files\Python311\Lib\site-packages\youtube_dl\extractor\linkedin.py", line 36, in _call_api
    'Csrf-Token': self._get_cookies(api_url)['JSESSIONID'].value,
                  ~~~~~~~~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^
KeyError: 'JSESSIONID'

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "C:\Program Files\Python311\Lib\site-packages\youtube_dl\YoutubeDL.py", line 815, in wrapper
    return func(self, *args, **kwargs)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "C:\Program Files\Python311\Lib\site-packages\youtube_dl\YoutubeDL.py", line 836, in __extract_info
    ie_result = ie.extract(url)
                ^^^^^^^^^^^^^^^
  File "C:\Program Files\Python311\Lib\site-packages\youtube_dl\extractor\common.py", line 547, in extract
    raise ExtractorError('An extractor error has occurred.', cause=e)
youtube_dl.utils.ExtractorError: An extractor error has occurred. (caused by KeyError('JSESSIONID')); please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; see  https://yt-dl.org/update  on how to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.

Using the --verbose flag shows that LinkedIn is supported:
...
[linkedin:learning] challenge-handling-arguments: Downloading webpage
ERROR: No video formats found; please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; see  https://yt-dl.org/update  on how to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.
...

Use --cookies ... with the site cookies from a logged-in browser session that can access the page content (otherwise the site shows "Unlock the full course today"), as described in the Manual.
The LinkedIn extractor ought to detect and report the not-logged-in status, as the yt-dlp LinkedIn extractor does.


Fix component label on resources

What happened?
Description
The component label should actually reflect each individual component, currently from what I can see it's either not set or if it's set it uses generic name otel-collector which is not helping to differentiate the pods based on their function.
$ kubectl get po -l app=splunk-otel-collector
NAME                                                              READY   STATUS    RESTARTS   AGE
splunk-otel-collector-agent-76blz                           1/1     Running   0          10m
splunk-otel-collector-agent-8hlx7                           1/1     Running   0          17m
splunk-otel-collector-agent-dzwjc                           1/1     Running   0          11m
splunk-otel-collector-agent-l92n2                           1/1     Running   0          12m
splunk-otel-collector-agent-p4zbp                           1/1     Running   0          14m
splunk-otel-collector-agent-xrqpb                           1/1     Running   0          17m
splunk-otel-collector-gateway-79f4b69897-4rtdg              1/1     Running   0          9d
splunk-otel-collector-gateway-79f4b69897-62s2b              1/1     Running   0          10d
splunk-otel-collector-gateway-79f4b69897-p2kwr              1/1     Running   0          10d
splunk-otel-collector-k8s-cluster-receiver-86b996bfb9467w   1/1     Running   0          9d

 kubectl  get po -l component=otel-collector
NAME                                                   READY   STATUS    RESTARTS   AGE
splunk-otel-collector-gateway-79f4b69897-4rtdg   1/1     Running   0          9d
splunk-otel-collector-gateway-79f4b69897-62s2b   1/1     Running   0          10d
splunk-otel-collector-gateway-79f4b69897-p2kwr   1/1     Running   0          10d

Steps to Reproduce
Expected Result
Actual Result
Chart version
0.71.0
Environment information
Environment
Cloud: (e.g., "EKS", "AKS", "GKE")
k8s version: (e.g., 1.21.0)
OS: (e.g., "Ubuntu 20.04")
Chart configuration
No response
Log output
No response
Additional context
No response

This looks like a duplicate of https://github.com/signalfx/splunk-otel-collector-chart/issues/749.


Lots of time-outs

Describe the bug
Debug log shows time-outs of most of the connections, for example:

CONNECT connectivitycheck.gstatic.com:443 HTTP/1.1
Host: connectivitycheck.gstatic.com:443
Proxy-Connection: Keep-Alive
User-Agent: Dalvik/2.1.0 (Linux; U; Android 10; CPH1931 Build/QKQ1.200209.002)
DEBU[2024-07-31T13:15:08+03:00] [DNS] resolved dns for connectivitycheck.gstatic.com: <IP_ADDRESS>
DEBU[2024-07-31T13:15:08+03:00] [PROXY] Start HTTPS
DEBU[2024-07-31T13:15:08+03:00] [HTTPS] New connection to the server connectivitycheck.gstatic.com <IP_ADDRESS>:49372
DEBU[2024-07-31T13:15:08+03:00] [HTTPS] Sent 200 Connection Estabalished to <IP_ADDRESS>:39264
DEBU[2024-07-31T13:15:08+03:00] [HTTPS] Client sent hello 517bytes
DEBU[2024-07-31T13:15:08+03:00] [HTTPS] Writing chunked client hello to connectivitycheck.gstatic.com
DEBU[2024-07-31T13:15:10+03:00] [HTTPS] Error reading from <IP_ADDRESS>:39264 timed out
DEBU[2024-07-31T13:15:10+03:00] [HTTPS] Closing client Connection.. <IP_ADDRESS>:39264
DEBU[2024-07-31T13:15:10+03:00] [HTTPS] Error reading from <IP_ADDRESS>:443 timed out
DEBU[2024-07-31T13:15:10+03:00] [HTTPS] Closing server Connection.. connectivitycheck.gstatic.com <IP_ADDRESS>:49372

Possibly related to #26?
The proxy also does not seem to affect YouTube throttling.
Expected behavior
Little to no timeouts
Actual behavior
Many timeouts
How To Reproduce?

Start SpoofDPI with parameters -addr <IP_ADDRESS> -port 8082 -debug (not sure how relevant are these)
Connect from Android phone
Wait for the logs

Client information
OS: Server: aarch64 GNU/Linux 6.1.31-1+
Client: Android 10
Version: spoog-dpi v0.0.0(dev) (sic!)
Additional context

the logs saying lots of timed out are an expected behavior. the https request may have contained keep-alive header so the connection will be timed out after the period of time that's given as the command line argument. (default to 2000ms).
I'm going to take a look what's wrong with youtube thing soon.

For youtube you might want to give https://github.com/hufrea/byedpi/ a go.
SpoofDPI worked great for me until just about a few days ago, but then my ISP learned to reassemble Client Hello, and now only more complex byedpi's desync/fake methods work.

@MahouShoujoMivutilde Thanks! I personnaly wanna implement the feature that can send fake client hello packet too, but because of the lack of knowledge in Golang and Network, I've been still figuring out how to do it.

@xvzc, is this issue still relevant? Or it can be closed?


Docker-in-Docker Feature "Failed to parse manifest" Error

The docker-in-docker:2 feature is failing to load, preventing my devcontainer from building
I think this is to do with the manifest URL requiring authorization (the URL from the logs below: https://ghcr.io/v2/devcontainers/features/docker-in-docker/manifests/2), as if I visit that URL, I get a HTTP 401
Versions: Dev Containers 0.275.1 in VS Code 1.75.1 (441438abd1ac652551dbe4d408dfcec8a499b8bf).
Relevant part of trace log:
[2023-03-01T06:36:27.388Z] --- Processing User Features ----
[2023-03-01T06:36:27.388Z] configPath: /workspaces/repo/.devcontainer/devcontainer.json
[2023-03-01T06:36:27.389Z] * Processing feature: ghcr.io/devcontainers/features/docker-in-docker:2
[2023-03-01T06:36:27.389Z] > input: ghcr.io/devcontainers/features/docker-in-docker:2
[2023-03-01T06:36:27.389Z] >
[2023-03-01T06:36:27.389Z] > resource: ghcr.io/devcontainers/features/docker-in-docker
[2023-03-01T06:36:27.389Z] > id: docker-in-docker
[2023-03-01T06:36:27.389Z] > version: 2
[2023-03-01T06:36:27.389Z] > owner: devcontainers
[2023-03-01T06:36:27.389Z] > namespace: devcontainers/features
[2023-03-01T06:36:27.389Z] > registry: ghcr.io
[2023-03-01T06:36:27.389Z] > path: devcontainers/features/docker-in-docker
[2023-03-01T06:36:27.389Z] manifest url: https://ghcr.io/v2/devcontainers/features/docker-in-docker/manifests/2
[2023-03-01T06:36:32.419Z] Failed to parse manifest:
[2023-03-01T06:36:32.419Z] (!) WARNING: Falling back to deprecated GitHub Release syntax. See https://github.com/devcontainers/spec/blob/main/proposals/devcontainer-features.md#referencing-a-feature for updated specification.
[2023-03-01T06:36:32.419Z] Github feature.
[2023-03-01T06:36:32.420Z] Could not resolve Feature 'ghcr.io/devcontainers/features/docker-in-docker:2'.  Ensure the Feature is published and accessible from your current environment.
[2023-03-01T06:36:32.424Z] Error: Failed to process feature ghcr.io/devcontainers/features/docker-in-docker:2
[2023-03-01T06:36:32.424Z]     at Cne (/root/.vscode-remote-containers/dist/dev-containers-cli-0.275.1/dist/spec-node/devContainersSpecCLI.js:1827:3109)
[2023-03-01T06:36:32.425Z]     at processTicksAndRejections (node:internal/process/task_queues:96:5)
[2023-03-01T06:36:32.426Z]     at async nm (/root/.vscode-remote-containers/dist/dev-containers-cli-0.275.1/dist/spec-node/devContainersSpecCLI.js:1827:2243)
[2023-03-01T06:36:32.426Z]     at async Uf (/root/.vscode-remote-containers/dist/dev-containers-cli-0.275.1/dist/spec-node/devContainersSpecCLI.js:1829:1773)
[2023-03-01T06:36:32.427Z]     at async pie (/root/.vscode-remote-containers/dist/dev-containers-cli-0.275.1/dist/spec-node/devContainersSpecCLI.js:1915:2568)
[2023-03-01T06:36:32.428Z]     at async vF (/root/.vscode-remote-containers/dist/dev-containers-cli-0.275.1/dist/spec-node/devContainersSpecCLI.js:1915:1972)
[2023-03-01T06:36:32.428Z]     at async P7 (/root/.vscode-remote-containers/dist/dev-containers-cli-0.275.1/dist/spec-node/devContainersSpecCLI.js:1915:901)
[2023-03-01T06:36:32.429Z]     at async Fie (/root/.vscode-remote-containers/dist/dev-containers-cli-0.275.1/dist/spec-node/devContainersSpecCLI.js:1921:2093)
[2023-03-01T06:36:32.429Z]     at async Vf (/root/.vscode-remote-containers/dist/dev-containers-cli-0.275.1/dist/spec-node/devContainersSpecCLI.js:1921:3241)
[2023-03-01T06:36:32.430Z]     at async eoe (/root/.vscode-remote-containers/dist/dev-containers-cli-0.275.1/dist/spec-node/devContainersSpecCLI.js:2045:17324)

This turned out to be a connectivity issue with Docker. Restarting Docker and then reopening and rebuilding the devcontainer has fixed the issue. This happened after adding --net=host and removing it.


Bypass M1 Mac crash until a proper integration can be introduced

Code from Intrueder to bypass the crash that is happening for M1 Macs

Support of M1 processors has been added in v2.2.0 (CUESDK v3.0.447)


Added right crowfoot notation '--{' to parser, incl test

For relationships, the parser understands "left crowfoot" notation (}--), but not right crowfoot (--{).
This pull request fixes this, including a test fixture for this case.
Note: --{ is, strictly speaking, not documented on plantuml.com, but if you
check this example (in the editable example on https://plantuml.com), you'll see that it works with the desired result:
class Dwelling {
}

class Window
class Door

Window }-- Dwelling: Composition
Dwelling --{ Door: Composition

Done, @Enteee

@Chris927 when do you need this bugfix as 0.0.13?

@Chris927 when do you need this bugfix as 0.0.13?

@Enteee No rush for me, am happy to wait until 0.0.13 is available. Thanks!

Ok. I don't have much lined up for 0.0.13. So I'll probably just give it a go and release this on ts own right now.


split-paired-reads.py breaks

Turns out split-paired-reads.py breaks when stuff is in the trailing section of the fastQ header.. This is a fastQ file that breaks it. It's an output fastQ from Heng Li's bfc error correction tool: https://github.com/lh3/bfc
Here is an example:
@SRR797058.11HWI-ST600:227:C0WR4ACXX:7:1101:20488:1997/1        ec:Z:0_0:1_0_1:0_0
aTCCACCTTCTGGTCACCTAGGAGCTTTCCAACATCAGCAGTGACCTGGTCAGCCTGCTCTGTGAATGAATCTGTCATCTTAACAACCACGCTGGCACTGG
+
&+????????????????????????????????????????????????????????????????????????????????????????+????????++

Fails silently - outputs an empty set of read files..
split-paired-reads.py corr.fq -->   corr.fq.1 and  corr.fq.2 are empty.

Hi Matt, what version of khmer are you using? A release or 'master'?

(I ask because we fixed just such a bug in #759.)

I installed using pip install khmer on a ec2 instance that is no longer running. pip search khmer indicates v1.3 so I'm gonna go with that.  It's def. those trailing characters that breaks things, as running awk '{print $1}' corr.fq > fixed.corr.fq then split-paired.reads.py works fine.

On Tue, Mar 17, 2015 at 03:36:09AM -0700, Matt MacManes wrote:

I installed using pip install khmer on a ec2 instance that is no longer running. pip search khmer indicates v1.3 so I'm gonna go with that.  It's def. those trailing characters that breaks things, as running awk '{print $1}' corr.fq > fixed.corr.fq then split-paired.reads.py works fine.

OK. This should be fixed in the next release; I'd like to test against
master to be sure, thought, so if you could send me (privately is fine)
the top of a file that triggers the problem, I'll run it. thanks!

On current master parsing fails with an error message:

split-paired-reads.py somefile.fastq
...
Unrecognized format for read pair information: SRR797058.11HWI-ST600:227:C0WR4ACXX:7:1101:20488:1997/1        ec:Z:0_0:1_0_1:0_0
Exiting.

It does create empty result files.

I guess an error message is better than nothing, but better yet would be to ignore the training info in the fastq header.

I'll look into this and try to fix the parser.

Fixed by #954


2018 approved absence not deducted from allowance

I was testing some stuff out and I came across this possible bug.
As the test user, I requested 1 day in 2018 which was approved.  However, this does not come off the Allowance for the year as shown in the below screenshot.

Hi @AsimPervez93
The calendr's statistics section always shows the current year.
Although it needs to be more flexible.

@vpp Ah I see, so come 2018, it would take it off the allowance correctly?

yes, but I am going to merge in "carry over" feature, that would allow employees to carry over lefteovers to next year.

Would it be possible to make the carry over feature optional?
I know most companies in my country do not allow employees to carry over leftovers to next year.

@AsimPervez93 in that case you just set the cary over value to be 0

@vpp Yeah that would work.  As long as the feature wouldn't mean that any leftover days would be automatically carried over.  This would be a good feature, just not very useful in my country.  Thanks for clarifying.

The carry over would be very useful in my company. Thanks!


lov.okfn.org is defunct

Doing ontospy utils -d offers to scan from http://lov.okfn.org but that site is down (not sure if temporarily or permanently).
Maybe that site moved - it seems to be what is now offered at https://lov.linkeddata.es - and indeed changing code to use https://lov.linkeddata.es/dataset/lov/api/v2/vocabulary/list as baseuri works.
I recommend to list the normalized URI in the UI - i.s. add trailing /.
While at it, I recommend to switch the alternative http://prefix.cc/popular/ to use secure https protocol - both the listing in UI and actual baseuri.

I intend on carrying this patch for the Debian packaging on Ontospy: https://salsa.debian.org/debian/ontospy/-/blob/debian/master/debian/patches/1001_URIs.patch

Many thanks for this! Added to https://github.com/lambdamusic/Ontospy/releases/tag/2.0.0-alpha


Cory videos not playing in Safari

Again, just recording this for the record.  I know you are aware of this issue and working on it.
but the Cory videos are not playing in Safari.
Thanks!!

The Cory videos don't play in Google Chrome either, FYI.  Thanks very much.

Fixed


feat: Saves objects states in Objects Manager to keep them between rooms

Fixes https://github.com/godot-escoria/escoria-issues/issues/193
Unblocks https://github.com/godot-escoria/escoria-demo-game/pull/532

How are we going to merge this? If we put it into develop before we merge the "instant transition" PR, it's going to cause merge conflicts, especially given how very much different the object and room managers have become.
How do we want to handle this?

Sorry, didn't read your comment, @BHSDuncan. Maybe you could incorporate this change in your branch then? It isn't quite big.

@BHSDuncan Agree with @dploeger . I'm fine if you cherry-pick this commit into #515 and we close this one.

Status: waiting for #515 to be merged. Will have to be rebased after that.

To test:

checkout branch "room6" from @balloonpopper
rebase this branch on origin/develop
If you want to see the issue, test (apply scenario below)
apply this PR onto the resulting branch
run

Scenario:

Access room06 -> notice that right door is closed
exit room06 to room05
Get back to room06
-> if PR not applied, notice that right door is now open
-> else, notice that right door is still closed

The state was preserved in my testing - the door stays "closed" with the fix applied.
Other issues were found in the transition between these rooms (as dicsussed in the channel) but they seem unrelated to this PR.

The state was preserved in my testing - the door stays "closed" with the fix applied. Other issues were found in the transition between these rooms (as dicsussed in the channel) but they seem unrelated to this PR.

Can you also maybe check if it's preserved across saving and loading? It should be based on what I see, but best to test. :)

Can you also maybe check if it's preserved across saving and loading? It should be based on what I see, but best to test. :)

I was asked to hold off on save testing while @StraToN does some more work on the save system.


Fix 32-bit syscalls on OSX

32-bit OS X doesn't use the "class" notion so doesn't require the offset.  Also now that it looks like restructuring is done, I'm probably going to start looking into ARM if you don't have any concerns.
Thanks!

Are you sure the syscall interface is even being used on OS X? Everything still works if I remove arch/ and src/syscall.c.

0ef217726e5a7026dab59ddcea9f5d1221c9c8aa (which no longer has OS X syscall handling) still works if you rm -rf arch/ src/syscall.c. I think OS X isn't giving us precedence.

Odd, and you're right - probably something in system dylib - I'll play with it some more.


Fail to provision

BUG REPORT

local hardware
ubuntu 18.x
ansible 2.5.2
kubespray 07cc9819

running vagrant up or later vagrant provision
bkaplan@speedy:~/si/kubespray$ vagrant provision
==> k8s-01: Running provisioner: shell...
    k8s-01: Running: inline script
==> k8s-02: Running provisioner: shell...
    k8s-02: Running: inline script
==> k8s-03: Running provisioner: shell...
    k8s-03: Running: inline script
==> k8s-03: Running provisioner: ansible...
Vagrant has automatically selected the compatibility mode '2.0'
according to the Ansible version installed (2.5.2).

Alternatively, the compatibility mode can be specified in your Vagrantfile:
https://www.vagrantup.com/docs/provisioning/ansible_common.html#compatibility_mode

==> k8s-03: Vagrant has detected a host range pattern in the `groups` option.
==> k8s-03: Vagrant doesn't fully check the validity of these parameters!
==> k8s-03:
==> k8s-03: Please check https://docs.ansible.com/ansible/intro_inventory.html#hosts-and-groups
==> k8s-03: for more information.
    k8s-03: Running ansible-playbook...
ERROR! no action detected in task. This often indicates a misspelled module name, or incorrect module path.

The error appears to have been in '/home/bkaplan/si/kubespray/roles/vault/handlers/main.yml': line 44, column 3, but may
be elsewhere in the file depending on the exact syntax problem.

The offending line appears to be:

- name: unseal vault
  ^ here

Ansible failed to complete successfully. Any error output should be
visible above. Please fix these errors and try again.

Got the same issue on latest commit 32f312f4a6f68f34fdf746d79fbdfe55f497335a

Duplicate of #2764


Error establishing source (relational) connection!

Mysql example
db.url=jdbc:mysql://<IP_ADDRESS>:3306/clean_data
db.login=root
db.password=pass
db.driver=mysql-connector-java-5.1.18-bin.jar
#db.driver=lib/mysql-connector-java-5.1.28.jar
#db.driver=com.mysql.jdbc.Driver
I'm getting this in my status.log file;
Error establishing source (relational) connection! Please check your connection settings.
Please is something wrong with my connection settings above. Also, what is the correct input to db.driver.
Thanks.

Hi, the correct input to db.driver for mysql is
db.driver=com.mysql.jdbc.Driver

Thanks for your reply.
My connection settings now look like this:
db.url=jdbc:mysql://localhost:3306/clean_data
db.login=root
db.password=passwd
db.driver=com.mysql.jdbc.Driver
I've corrected that but still I'm getting this in my status.log file;
Error establishing source (relational) connection! Please check your connection settings.
The database exist and I can query it but I wonder why connection cannot be established.

Hey,
I am facing the exact same issue. Was there a solution in the meanwhile?
My r2rml.properties is:
db.url=jdbc:mysql://localhost:3306/sakila
db.login=root
db.password=123456
db.driver=com.mysql.jdbc.Driver
I can establish a connection via MySQL Workbench with the abovementioned login credentials and I can query the sakila database (e.g. table "actor"). However, I still get the error: "2019-03-25 13:16:52,567 ERROR [Database] Error establishing source (relational) connection! Please check your connection settings."
I am using a Win10 x86 device with mysql community version 5.5.
Thanks!

So I solved the issue, but it requires changes to the source code in order to run with MySQL version > 5.5.
I did the following:

I installed the latest version of MySQL (8.0)
I changed the maven dependencies of "mysql-connector-java" to "8.0.15".
The latest driver is: "com.mysql.cj.jdbc.Driver", I changed that in the properties file

Lastly, I am not sure whether that is just specific to my MySQL instance, however, I had to change the strings that is used to establish the MySQL server connection to:
connection = DriverManager.getConnection(url + user + password + conf);
	String user = "?user=root";
	String password = "&password=1234";
	String url = "jdbc:mysql://localhost/sakila";
	String conf = "&useUnicode=true&useJDBCCompliantTimezoneShift=true&useLegacyDatetimeCode=false&serverTimezone=UTC";

The java exception I got from above, was just because the sakila DB, which is used as MySQL example DB which is created by default on install, does not look as it is modelled in the R2RML mapping file. So by adjusting the example mapping to the actual example data, it works just fine.
Regards,
Constantin

Hi,
Happy to hear this works now.
Thanks for posting your solution here. This is likely to be helpful to other Mysql users as well.
Best,
Nikos


update java version detector and maven rigging to support java 9

This PR tried to fixed two issues:

Java 9 version string in format of '9.0.1' instead of '1.9.0', so original java version detector will return wrong major version number, which is '0'

maven rigging template will generate maven:3-jdk-9 and openjdk:9-jre-alpine for Java 9

maven:3-jdk-9 has an SSL issue: https://github.com/docker-library/openjdk/issues/145
openjdk:9-jre-alpine is not a valid base image (no tag existed for 9-jre-alpine)
Solution is to replace two images as maven:3-jdk-{{version}}-slim and openjdk:{{version}}-jre-slim
Generated Dockerfile are tested again java 7,8,9
The Dockerfile will not work properly for java 6, as maven:3-jdk-6 does not exist.

Codecov Report

Merging #16 into master will decrease coverage by 0.1%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##           master      #16      +/-   ##
==========================================
- Coverage   56.86%   56.75%   -0.11%
==========================================
  Files          39       39
  Lines        1034     1036       +2
==========================================
  Hits          588      588
- Misses        446      448       +2

Impacted Files
Coverage Δ

derrick/detectors/image/java.py
37.93% <0%> (-2.81%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2cbc973...c5c806e. Read the comment docs.


Could you please upload the extracted clip image embeddings of precomputed proposals to google drive?

Dear author,
Could you please upload the extracted clip image embeddings of precomputed proposals to google drive?
Or somewhere can be downloaded via terminal?
As I am out of China mainland, it seems I can not download from Baidu cloud.
Also, I have meet the box identity error... So I can not generate these embeddings by myself...
https://github.com/dyabel/detpro/issues/8#issuecomment-1101276373
I would appreciate it very much if you can upload to google drive or somewhere can be downloaded via terminal!

Same question, can the author put the embeddings somewhere that can be downloaded via terminal?

same here


Consider making all initializable contracts expose some sort of view function that returns if the contract is initialized or not

V3 Initializers
Module Implementators TLDR
Initializable modules should:

Inherit InitializableMixin (see below)
Override the internal function _isInitialized()
Implement an external/public view called isModuleNameInitialized() that returns a bool
Implement an external/public called initializeModuleName(...)

i.e.
contract SampleModule is InitializebleMixin {
    ...

    function initializeSampleModule(address param1, address param2, uint param3) external onlyIfNotInitialized {
        // Will reverti if called after initialization
        // ...

        // Set initialized
        _someStorage().initialized = true;
    }

    function isSampleModuleInitialized() external returns(bool) {
        return _isInitialized();
    }

    function _isInitialized() internal override returns(bool) {
        return(_someStorage().initialized);
    }

    ...

    function someFuntion() external onlyIfInitialized {
        // will revert unless the module was initialized
    }
    ...

}

InitializableMixin
InitializebleMixin adds two modifiers (onlyIfInitilized and onlyIfNotInitilized) and requires the implementation of the virtual function (_isInitialized())
//SPDX-License-Identifier: MIT
pragma solidity ^0.8.0;

import "../errors/InitError.sol";

abstract contract InitializableMixin {
    modifier onlyIfInitialized() {
        if (!_isInitialized()) {
            revert InitError.NotInitialized();
        }

        _;
    }

    modifier onlyIfNotInitilized() {
        if (_isInitialized()) {
            revert InitError.AlreadyInitialized();
        }

        _;
    }

    function _isInitialized() internal virtual view returns(bool);
}

Tooling
Deployer
The tooling will check if a module inherits the InitializableMixin. If a module inherits the mixin it should:

Check if there's an external function named isModuleNameInitialized() that returns a bool
Check if there's an external function named initializeModuleName() (with or without parameters)

CLI
The CLI will raise a warning when trying to interact with a initializeble module that wasn't initialized.

reference: https://hackmd.io/@wDuYijTaRY6GbPExcc1gWw/BJVITg52K


[plugins.json] Add cocoapods-pl

Please add the following entry to the plugins.json file:
{
  "gem": "cocoapods-pl",
  "name": "CocoaPods Pl",
  "author": "pangzhanli",
  "url": "https://github.com/pangzhanli/cocoapods-pl",
  "description": "A longer description of cocoapods-pl."
}

error

error


Ensure CombinedChannelDuplexHandler can not be shared.

Motivation:
CombinedChannelDuplexHandler must not be shared as it contains state.
Modifications:
Enforce that it is not shared.
Result:
Fixes [#6333]

Cherry-picked into 4.1 (78586a9) and 4.0 (0a7cce243cc21e92e76df4cdf6d18c9e9206a0f6)


Multi-GPU Support for MSD trials

Is your feature request related to a problem? Please describe.
Yes, one of my colleagues experienced a bottleneck due to the current single-GPU implementation of ipie using SHCI trials. We're interested in exploring multi-GPU solutions. also, @linusjoonho had mentioned potential updates related to this feature in the past. It would be great if the developers could share any updates on this matter.
Describe the solution you'd like
A basic version of multi-GPU support would be sufficient for our needs.
Thank you!

There is no GPU support for MSD trials? How is this being run?

Also, what do you mean by multi-gpu support? Do you want to distribute the integrals among multiple gpus? Just run on multiple gpus (this should be supported for single determinant AFQMC through mpirun -np number_of_gpus). Something else?
To enable GPU support for MSD trials one would need to rewrite https://github.com/JoonhoLee-Group/ipie/blob/develop/ipie/estimators/kernels/cpu/wicks.py as an equivalent gpu/wicks.py and rewrite the kernels using cuda (via numba). It's also not clear to me that the other non-kernel routines would necessarily work out of the box on GPUs (anything with wicks in the name). An alternative could be to ignore the kernels and use GPUs just for the dense linear algebra part with host-device transfers for the (cpu) kernels but I would worry that would lead to poor performance.

Hi Fionn! This is Yifei here. Thanks for the prompt reply. I guess Hung thought that there is an internal MSD code with multi-GPU support because the memory could be a bottleneck in that case. So I guess he is asking about both the MSD as well as multi-GPU support. And you've answered both of them. Indeed I find the wicks part hard to GPU-ize. I guess it's a case-by-case thing depending on the problem size, in some cases the buildcont12 is more time-consuming and in others the wicks takes more time.
For SD case, I feel memory can hardly be a problem so multi-GPU might not be necessary unless we tackle systems with nelectrons>100. Though I'd be interested to know whether "mpirun -np number_of_gpus" implements multi-GPU by just chunking the Hamiltonian and distributing the calculation to different devices. Appreciate your time.

Hi Yifei, for SD we do support multi-GPU with chunking Hamiltonian.

The SD gpu code should work for both a chunked Hamiltonian (integrals are distributed among gpus on a node (say 8 or 16 gpus), and non-chunked (each gpu gets a copy of the integrals). The latter case will perform better but will be a bit more memory constrained.  I think the general advice would be to use as many walkers per GPU as you can get away with, certain intermediate tensors grow with the number of walkers so there is a limit naturally. But say you wanted to use 800 walkers and had 8 gpus you could set num_walkers = 100 and run like mpirun -np 8 python -u bin/ipie --gpu input.json (or similarly if using a more pythonic script).
We briefly investigated implementing a gpu variant of wicks a long time ago and at the time it wasn't 100% clear how much one would gain given the complications of porting the kernels. Not to say it's not worth doing but it can be tricky to get the best performance (it's why there are various variants of implementations in the SD case too)

Overall, we try to optimize the code performance for multiple GPU with multiple dets. We are on the way to do this. Thank you for the comment. We will get back to you once we have more progress. @hungpham2017 @linusjoonho @fdmalone  maybe for now, we may close this issue.

I would also appreciate support for MSD using multi-gpu multi node architectures.
Any ideas on a timeline for this?
Thanks team.
cc @davidev886


Sensitivity labels logic app error

Description
The sensitivity labels logic app fails at the "Get label from the SharePoint list" step. All steps previous to the failing step are running correctly and populating with sensitivity labels.
When this step runs it continually gets an error with a status code of 404 and message of "Resource not found". I have checked at the list is available on the site.
There is no option to update the step in the process either.
Steps to reproduce

Run job - either daily schedule, or manual

Expected results
Sensitivity labels populate list
Actual Results
Job always fails. Checking back, it appears this has never run correctly. Sensitivity labels have been in place for several weeks now.
Solution component
Logic Apps
Operating system (environment)
Windows
Additional Info
All other components of the logic app work well with no issues.

@eoinmack are you able to share any screenshots of the Logic App where it fails please? Thanks


Update puppeteer container with new packages

Look at the approach in https://github.com/green-coding-berlin/example-applications/compare/main...container-slim

Please also fix the documentation bugs in the Readme regarding docker compose run

I changed the references in the documentation. No need for you to do that from your side

I tried downloading the containers with the testing tag from Docker Hub: docker pull greencoding/puppeteer-chrome:testing.
The containers arrive fine and size is reduced as expected. However they cannot start:
docker run --rm -it greencoding/puppeteer-chrome:testing
gives me:
Docker build: cannot mount volume over existing file ...
The problem is: Since you built the containers with the docker compose file and not with just the docker build client it somehow expects or has saved the bind mount information.
Since the container should be redistributable and people might not have the directory structure of your development machine this makes the container very limited in where it can be run.
The solution is to remove the build information from the compose.yml file and instruct the user to build via the docker build CLI command.
Please re-upload the containers again to Docker Hub as testing containers with the new way of building them. I will test again then.
Learning for us: Containers on Docker Hub should never have bind mounts! Neither through the docker build nor the compose.yml file.
I left the compose.yml file nevertheless in the folder as it is very nice for starting and testing the containers.

@ArneTR
I updated the readme on how to run the images when they are built locally, and updated the Dockerfile to include the COPY of the test script as opposed to using a volume mount in the docker compose file.
Images built including these Dockerfiles have been pushed to docker hub under the testing tag, please try pulling and running them.


Automatic generation of docker/docker reference docs from YAML

Problem description
Need a way to generate docs on the fly from a YAML file. The first target is docker/docker. This issue will track that work.
cc/ @johndmulhausen @dmp42

I should be able to get this up and running within a week.
Plan is to re-use some of the logic found in the docker/docker manpage generation and add the logic found in k8s for the YAML file generation.

@mstanleyjones @FrenchBen just going through issues, and wondering if this happened and whether we can close this?

No, we are still working out kinks with @tiborvass .

Closing. Great job everyone! The new refdocs are awesome.


Migrate from react UNSAFE_componentWillReceiveProps to getDerivedStateFromProps

Describe the issue
We current use in the Graph component the react lifecycle method componentWillReiceveProps.  This method has been deprecated in favor of getDerivedStateFromProps(props, state).
Expected
Refactor UNSAFE_componentWillReceiveProps into getDerivedStateFromProps.
Environment:
All.
Additional context
Consider that no fundamental changes should be made in the current implementation of UNSAFE_componentWillReceiveProps, we only want to migrate the react bits in order to keep the library compliant with the newest versions of react.

can i work on this? if you don't mind

Hey @chisom5 sure, you're the first claiming it, I'll assign it to you :slightly_smiling_face:

Hi @chisom5 please check the Contributions section of the README of the project, cheers!

got that thanks

can I take it? it's really simple... it already took too much time of this issue

I have already made the changes i am making a PR  i guess you can review it @danielcaldas

Passing the ownership of the issue to @gopherine since you stepped up with the PR already :slightly_smiling_face:

This issue is still ongoing, it happens that the migration is not that trivial due to the flow of execution change of getDerivedStateFromProps which gets executed at every render...
From react docs:

Note that this method is fired on every render, regardless of the cause. This is in contrast to UNSAFE_componentWillReceiveProps, which only fires when the parent causes a re-render and not as a result of a local setState.


[Feature] DO NOT Store ALL Plugins while Install

Description of the new feature / enhancement
During install, let user choose plugins which they need and only store them on disk.
Or let plugins be downloaded like browser extension.
Scenario when this would be used?
Decrease the storage used. Now it is more than 500MB after releasing the installer package.
Supporting information
This is what installer of powertoys be like in 2019:

And this is what installer of powertoys be like now:

What a joke. It is a good thing that PT has an increasing number of useful plugins with the time flowing.
But not every plugin is used. For example, I only need PT.Run and Fancy.Zone.
Is it necessary to increase the storage used each time a new plugin is merged? The user's hard disk is not infinite.

/dup #3170


Goal: organize backlog by 12/12

Over the last week, with the help of @jimjag, we have managed to reduce the total backlog by 25% and reorganized many more.
I want this completed by weeks end.
Strategy: Run through the outstanding issues (currently 68) migrated from sourceforge, and organize.
Close the issue if one of the following conditions apply:
I added a label  for those without permissions to close open issues, please give the reason for closing from the list below in a comment and add the label can close, then a team member can follow up.

works in BeanShell 3.0, resolved
cannot reproduce
not enough information given
duplicate of another existing issue
stale, not an issue in 2022

If an issue is deemed necessary for further consideration, please elaborate in comment and add your findings. To help us categorize the issues better one or more of the following labels may apply.

GUI pertains to swing or awt from the gui application or applets
documentation pertains to wrong or missing documentation
parsing problem with grammar, there are parser errors
patch provides a change to the BeanShell source code
feature due to a java feature not implemented yet, or feature request
out of scope v3 not considered for next release like strict java support

Finally please add the label checked to indicate that the issue has been reviewed, comments added, labels applied, and it can be filtered off the list of outstanding issues. Which if empty means our goal is done!
Thank you in advance for your assistance.

Admittedly, a slightly more restricted list of outstanding issues also excluding all patches, documentation, GUI, and out of scope for v3.0 issues, is all finished and done, one day before the deadline. [chuffed]
Who said it cannot be done?
Of the original list of 68 issues only 19 remain.

Only 10 more to go...

All issues have been processed round 1, thank you for all the assist.
Next we'll have to do bug triage and see what we've got.
Closed: list is complete

Congraulations, well done.  Sorry that I could not have been of more assistance on this


SRA Identity & Auth: [M1] Identity Changes

Relevant issue(s):
Parent ticket: https://github.com/awslabs/aws-sdk-swift/issues/1119
Grandparent ticket: https://github.com/awslabs/aws-sdk-swift/issues/1095
Pre-existing ticket (used in Q4 planning): https://github.com/awslabs/aws-sdk-swift/issues/700
Summary
Milestone 1 of SRA Identity & Auth Project
* Add new interfaces / structs
    * Identity protocol
    * IdentityResolver protocol
* Refactor Credentials, CredentialsProviding, and related classes to work with new interfaces
* Move files to fit SRA module structure

aws-sdk-swift PR: https://github.com/awslabs/aws-sdk-swift/pull/1150
smithy-swift PR: https://github.com/smithy-lang/smithy-swift/pull/594


Slack notifyer

A new notify component for slack (slack.com).  A simple component that posts a slack message to the specified channel using the slacker python module.

+1

Cheers @stephenway

I know you don't really need my help, but it looks good to me. :+1:

Alright, I'll merge the pull request now as it's a pretty small component and there are no core changes it's pretty low risk.  @balloob if you notice anything in the code review just let me know and I'll issue another pull.

This is the documentation for this notifier.

Plz any way to expand component a bit more? Is it possible to set Sender name via API? (override default "bot"). And possibly icon. I have other services integrated to Slack via webhooks, so there I'm able to configure names and icons directly in slack...


helm stable/redis does not work with istio sidecar

Here's the yaml i generated from helm install stable/redis.
# Source: redis/templates/redis-master-svc.yaml
apiVersion: v1
kind: Service
metadata:
  name: rune-redis-master
  labels:
    app: redis
    chart: redis-3.2.0
    release: "rune-redis"
    heritage: "Tiller"
  annotations:
spec:
  type: ClusterIP
  ports:
  - name: redis
    port: 6379
    targetPort: redis
  selector:
    app: redis
    release: "rune-redis"
    role: master
---
# Source: redis/templates/redis-slave-svc.yaml
apiVersion: v1
kind: Service
metadata:
  name: rune-redis-slave
  labels:
    app: redis
    chart: redis-3.2.0
    release: "rune-redis"
    heritage: "Tiller"
  annotations:
spec:
  type: ClusterIP
  ports:
  - name: redis
    port: 6379
    targetPort: redis
  selector:
    app: redis
    release: "rune-redis"
    role: slave
---
# Source: redis/templates/redis-slave-deployment.yaml
apiVersion: extensions/v1beta1
kind: Deployment
metadata:
  name: rune-redis-slave
  labels:
    app: redis
    chart: redis-3.2.0
    release: "rune-redis"
    heritage: "Tiller"
spec:
  replicas: 3
  template:
    metadata:
      labels:
        release: "rune-redis"
        role: slave
        app: redis
      annotations:
        sidecar.istio.io/inject: "false"

    spec:
      securityContext:
        fsGroup: 1001
        runAsUser: 1001
      containers:
      - name: rune-redis
        image: docker.io/bitnami/redis:4.0.9
        imagePullPolicy: "Always"
        env:
        - name: REDIS_REPLICATION_MODE
          value: slave
        - name: REDIS_MASTER_HOST
          value: rune-redis-master
        - name: REDIS_PORT
          value: "6379"
        - name: REDIS_MASTER_PORT_NUMBER
          value: "6379"
        - name: ALLOW_EMPTY_PASSWORD
          value: "yes"
        - name: REDIS_DISABLE_COMMANDS
          value:
        ports:
        - name: redis
          containerPort: 6379
        livenessProbe:
          initialDelaySeconds: 30
          periodSeconds: 10
          timeoutSeconds: 5
          successThreshold: 1
          failureThreshold: 5
          exec:
            command:
            - redis-cli
            - ping
        readinessProbe:
          initialDelaySeconds: 5
          periodSeconds: 10
          timeoutSeconds: 1
          successThreshold: 1
          failureThreshold: 5
          exec:
            command:
            - redis-cli
            - ping
        resources:
          null
---
# Source: redis/templates/redis-master-statefulset.yaml
apiVersion: apps/v1beta2
kind: StatefulSet
metadata:
  name: rune-redis-master
  labels:
    app: redis
    chart: redis-3.2.0
    release: "rune-redis"
    heritage: "Tiller"
spec:
  selector:
    matchLabels:
      release: "rune-redis"
      role: master
      app: redis
  serviceName: "redis-master"
  template:
    metadata:
      labels:
        release: "rune-redis"
        role: master
        app: redis
      annotations:
        sidecar.istio.io/inject: "false"

    spec:
      securityContext:
        fsGroup: 1001
        runAsUser: 1001
      containers:
      - name: rune-redis
        image: "docker.io/bitnami/redis:4.0.9"
        imagePullPolicy: "Always"
        env:
        - name: REDIS_REPLICATION_MODE
          value: master
        - name: ALLOW_EMPTY_PASSWORD
          value: "yes"
        - name: REDIS_PORT
          value: "6379"
        - name: REDIS_DISABLE_COMMANDS
          value:
        ports:
        - name: redis
          containerPort: 6379
        livenessProbe:
          initialDelaySeconds: 30
          periodSeconds: 10
          timeoutSeconds: 5
          successThreshold: 1
          failureThreshold: 5
          exec:
            command:
            - redis-cli
            - ping
        readinessProbe:
          initialDelaySeconds: 5
          periodSeconds: 10
          timeoutSeconds: 1
          successThreshold: 1
          failureThreshold: 5
          exec:
            command:
            - redis-cli
            - ping
        resources:
          null

        volumeMounts:
        - name: redis-data
          mountPath: /bitnami/redis/data
          subPath:
  volumeClaimTemplates:
    - metadata:
        name: redis-data
        labels:
          app: "redis"
          chart: redis-3.2.0
          component: "master"
          release: "rune-redis"
          heritage: "Tiller"
      spec:
        accessModes:
          - "ReadWriteOnce"
        resources:
          requests:
            storage: "8Gi"

Most of it is pretty irrelevant but what you'd expect to be there is there:

The pods do not have the istio sidecar on them.
The service ports are named:

  ports:
  - name: redis
    port: 6379
    targetPort: redis

Istio version: 7.0.1
I thought this was fixed in 5.0.0?
Istio auto-injector version: 7.0.1

Some more info:
kubectl run --namespace default redis-client --rm --tty -i --image docker.io/bitnami/redis:4.0.9 -- bash

I have no name!@redis-client-9f45fc688-dxs5c:/$ redis-cli -h rune-redis-master
Could not connect to Redis at rune-redis-master:6379: Connection refused

It doesn't matter if I don't name the service's port or if it's named redis.
However, there is an older version of this chart on the cluster and it does work from a sidecarred service. How can I find out what the difference is to istio, exactly?

Whoops, meant to put this in istio/issues

I have the same issue. Did you find a solution? I think istio sidecars don't fit k8s statefulsets.

They do though.
It really looked like Istio wasn't able to handle the "redis" protocol traffic. I had it working for a while before I started running into this issue; make sure the port is named "redis".
I ditched istio whenever i couldn't figure it out, unfortunately.

@proddam did you managed to run helm/stable redis chart on istio cluster?

I'm having the same issue.

I think the issue might be that StatefulSets usually have 2 services mapped to the same pod, which Istio does not support. (Or did not support at the time). Did an update fix this or anything?

If the issue that you see is istio sidecar not starting then check istio sidecar logs and look for envoy missing listener for inbound application port. If that's the case than creating a dummy service for your redis pods will help to get it working.
See https://github.com/istio/istio/blob/master/pilot/cmd/pilot-agent/status/ready/probe.go#L41-L65 and https://github.com/spotahome/redis-operator/issues/93#issuecomment-423026080.

Commenting out securityContext from deployment.yaml works for me.
=====
spec:
securityContext:
runAsUser: 1001
fsGroup: 1001

@iroller I'm getting the message you mentioned (envoy missing listener for inbound application port) but I do have a service. The only thing of note here is that the container port and the service are both UDP... is it required to have a TCP-based port on the service?

@jaygorrell you probably have rfs-app-redis service for sentinel, right? Try creating rfr-...-redis service for redis pods. I provided an example below.
apiVersion: v1
kind: Service
metadata:
  name: rfr-app-redis-dummy
spec:
  ports:
    - name: redis-dummy
      port: 16379
      protocol: TCP
      targetPort: 6379
  selector:
    app: redis-failover
    component: redis
    creator: redisfailover
    redisfailover: search-redis

The solution provided by @amyroh works for us! Just need to set master.securityContext.enabled=false when deploying redis.

I ran into a similar issue, where my redis pod would CrashLoop after enabling the istio sidecar proxy. The root cause was actually in the Istio InitContainer, which needed to be run as root. Setting the following in the redis helm chart fixed it for me:
master:
  securityContext:
    runAsUser: 0

Confirming what previously has been mentioned: this not a sidecar/traffic management issue. The problem is that the securityContext.runAsUser = 1001 directive is on a Pod level hence affecting all containers in the Pod including istio-init. istio-init has to be run as root in order to configure iptables.
Commenting out runAsUser field (or moving it to the container level) resolves the issue and Redis Cluster works fine with sidecars enabled. Replicas are able to establish connections to master just fine and I'm able to execute commands via redis-cli on both master and replicas.
I suspect many charts may not work because of similar issue, one thing we could do is explicitly adding securityContext.runAsUser = 0 to the istio-init container (by default, with an option to disable that via a Helm option) so that this setting takes precedence over the pod-level one. istio-init currently requires running as root anyways.

@philrud that's totally right, we should disable runAsUser if want to inject istio's sidecars.
I am curious, do you use mTLS? Have you got a chance to run redis with mTLS? Thanks

@XBeg9 yes, I was running that setup with mTLS=on

@philrud namespace-policy or global one?

@philrud is this fixed now?

yes, the fix will go live with 1.1.3, closing


How to create the certs?

Self Signed certs or general SSL certs seems to be not working. It would be helpful if there is any literature pointed out on how to get the ES256 signed certs and what is needed to get them.

@mauricefisher64 - Any help here please? Not able to find any documentation or steps to get the certificates.

Adding an example of an openssl command in README.md that shows how to generate a self-signed certificate that works with c2patool would be great.
In addition, getting more information than CoseInvalidCert when passing invalid certs to c2patool would also be helpful: I see that c2pa-rs logs precise information about what went wrong, it would be great to be able to access that information in c2patool with a flag.
I haven't been able to generate a key that passes c2pa-rs checks following the "Signing manifests" guide currently published on your website, which might need updating?
Thanks in advance,

Older versions of this repo's README.md feature a code snippet for that specific purpose:
openssl req -new -newkey rsa:4096
   -sigopt rsa_padding_mode:pss \
   -days 180 \
   -extensions v3_ca \
   -addext "keyUsage = digitalSignature" \
   -addext "extendedKeyUsage = emailProtection" \
   -nodes -x509 -keyout private.key -out certs.pem -sha256

Which works.
My understanding is that this was removed to clarify that c2patool comes with a built-in cert / key for testing purposes.
I think this would still be great to have for reference. If not here, maybe on the "Signing Manifests" page of opensource.contentauthenticity.org.

PS: The v3_ca extension is sometimes not available out-of-the-box on Mac OS, but specific instructions could be given for that case.

I've tried with both self-signed certified certificates (created with the command above ☝ ) and also with the certificates signed by root CA, but always getting the following error when using RSA key and "alg": "PS512":
[2023-10-16T09:32:11Z ERROR c2pa::store] Signature that was just generated does not validate: CoseInvalidCert
Error: embedding manifest

Caused by:
    COSE error parsing certificate

Any thoughts?
CC: @mauricefisher64

Ok, I've dug into the code and it seems that the C2PA SDK internationally forbids the self-signed certificates:
https://github.com/contentauth/c2pa-rs/blob/d9b077c8790e172d5bc9f23dc17f13df343160f1/sdk/src/cose_validator.rs#L350
I wonder, does it mean that the C2PA Spec does not allow the self-signed certificates? Or the spec does not forbid it, but the SDK does not allow it because it does not make sense in practice?

According to the C2PA spec, Self-Signed certs or SSL certs are not supported.


Tutorial - Angular 1 - Step 3 shows no parties

On my local machine it runs ok, but http://socially-step03.meteor.com/ shows no parties...
Developertools in Chrome show the parties are in the partiesList, but somehow angular is not aware of that.

I think the deployed version is not updated yet, will try top update it tomorrow

On my local machine with 1.3.1. it's ok!

@gjr-qm , 1.3.1 fixes that, just deployed the latest version of step 3 to http://socially-step03.meteor.com.
Thanks!


Tags only generated for .php files

First off thanks for this. It's removed my only gripe about ST2.
I've been working on Drupal (which is written in PHP) and couldn't figure out why the tags weren't getting generated correctly. Eventually I came across a blog post (http://openflows.com/blog/mvc/2009/01/27/using-exuberant-ctags-drupal) that gave me the clue. By default ctags only reads .php files but Drupal uses several custom extensions. By editing CTags.sublime-settings and changing the ctags_command command to include the --langmap option:
    "ctags_command"   :  "/opt/local/bin/ctags -R --langmap=php:.engine.inc.module.theme.php --php-kinds=cdfi",

I was able to get it working. If there's a better way to provide this option I'd love to know what it is. In either case it seems like it'd be a nice thing to document.

I probably should have made it clear for anyone else that stumbles across this issue that the /opt/local/bin/ prefix is related to issue #14.


translations should not be null validation error

I recently added
#[Assert\EnableAutoMapping]

to a class that implements TranslatableInterface, but now when I try to validate an entity, I get
object(App\Entity\Project).translations:
   This value should not be null. (code ad32d13f-c3d4-423b-909a-857b961eb720)

I can't find where translations is being set to NotNull, though I suspect it's in Defaults.
bin/console debug:valid App\Entity\Project
|translations          | Symfony\Component\Validator\Constraints\NotNull            | Default, Project | [                                                                               |
|                       |                                                            |                  |   "message" => "This value should not be null.",                                |
|                       |                                                            |                  |   "payload" => null                                                             |
|                       |                                                            |                  | ]
I think null is valid, and I can't figure out how to unset this, or even how to set it to an acceptable default (an empty collection?)

The same thing is happening with currentLocale, even though that's not persisted.

I think I'm going down the wrong path here, so I'm closing this.


Feature request: Read GITHUB_REPO and GITHUB_USER from .git/config

Is it OK to assume that this can be inferred from the [origin] entry in .git/config?

Yes, this is definitely feasible if a user is within a git repository. One would need to scan upwards for a git repo and then parse the git config format. PRs welcome if you like :).

Alternatively git config or an API version of it can help detect and parse a config file for a Git repository.

would be awesome.
👍

Hello, before noticing this issue, I hacked together #49 which I think addresses the request from this issue as well. Comments and critiques welcome.


Brightway 25

Hello, is this available for Brightway 2? That is what I thought until I tried to install and:
Collecting brightway25 (from polyviz)
Downloading brightway25-1.0.6.tar.gz (12.0 MB)

You are right. I just removed brightway25 from the requirements. So now it will install without assuming a specific brightway version.


Fix Test Suite 'TRAVIS' Dependency

This should fix the problem when running the test suite locally.

I confirm that now it works, thanks.
Is there a reason why the execution flag for test_suite.py has been removed?
Just for note, the compilation of the test suite resources is now much more verbose:
stefi@libeccio:~/develop/webots/tests$ python test_suite.py
make: Entering directory '/home/stefi/develop/webots/tests'
make[1]: Entering directory '/home/stefi/develop/webots/tests/api'
make[1]: Entering directory '/home/stefi/develop/webots/tests/protos'
make[1]: Entering directory '/home/stefi/develop/webots/tests/parser'
make[1]: Entering directory '/home/stefi/develop/webots/tests/rendering'
make[1]: Entering directory '/home/stefi/develop/webots/tests/physics'
make[2]: Entering directory '/home/stefi/develop/webots/tests/api/controllers'
make[2]: Entering directory '/home/stefi/develop/webots/tests/api/plugins/physics'
make[2]: Entering directory '/home/stefi/develop/webots/tests/rendering/controllers'
make[2]: Entering directory '/home/stefi/develop/webots/tests/physics/controllers'
make[2]: Entering directory '/home/stefi/develop/webots/tests/protos/controllers'
make[2]: Entering directory '/home/stefi/develop/webots/tests/parser/controllers'
make[2]: Entering directory '/home/stefi/develop/webots/tests/api/plugins/remote_controls'
make[2]: Entering directory '/home/stefi/develop/webots/tests/api/plugins/robot_windows'
# make release robot_window
# make release copy_args_in_custom_data
# make release hidden_parameter_single
...

Is there a reason why the execution flag for test_suite.py has been removed?

No, I did noticed that sometimes when editing a file in Github the flag is removed, this is probably what happened, I will re-add it in this PR.

Just for note, the compilation of the test suite resources is now much more verbose:

That's normal, now we are passing the path to make, because before the test suite was not working if launched from outside the 'webots/tests' folder. But I have an idea to improve the compilation outputs, let me try.

:+1:

:eyes:


Adding Jenkinsfiles

Description:
Added Jenkinsfiles for both the Master and Build Agents (Nodes). I also updated the links to the Jenkins repo and repo key to reflect the use of LTS.
These templates use stack-create-complete and stack-delete-complete instead of sleep.

Note: still showing file-conflicts. Also, you may get blocked by commit 3a1614d60f61acb86eba12cc312dd9b5e82231de (it's not signed)

It appears the conflicts were caused by the merge from Jason's old PR...I updated my files to reflect and they should be good to go.


darwin: remove unused os-specific stuff

Motivation for this change
This is all stuff that isn't being used and it relies on some "impure" Mac OS X locations to work correctly.
Things done

[ ] Tested using sandboxing
(nix.useSandbox on NixOS,
or option build-use-sandbox in nix.conf
on non-NixOS)
Built on platform(s)

[ ] NixOS
[ ] OS X
[ ] Linux

[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[x] Fits CONTRIBUTING.md.

Nevermind, "install_name_tool" is actually being used.


ci: migrate deprecated grammar

Ref: https://github.blog/changelog/2020-10-01-github-actions-deprecating-set-env-and-add-path-commands/.

https://github.com/nodejs/node-gyp/pull/2261 attempted to do the same (I've just realised it seems to have changed a bit from when I first looked at it but originally it was similar to this one).

#2261 attempted to do the same (I've just realised it seems to have changed a bit from when I first looked at it but originally it was similar to this one).

@richardlau I believe I find the right method through  https://github.com/VXAPPS/modern.cpp.core/blob/a2fa3eafe3cc044738ce3d65fd5299b15bd81f61/.github/workflows/integrate.yml#L153.
Github CI documentation is no helpful at all for windows :(


S3 related configuration

Can someone provide me with service, executor, and s3uploder configs, so I could see S3logs of my tasks in UI?
Thanks in advance

Is there any way I can get help here?
We have discovered that executor creates new uploader:
INFO  [2018-03-23 09:23:29,715] [main] c.h.s.s3uploader.SingularityS3UploaderDriver 8765 - Created new uploader SingularityS3Uploader [uploadMetadata=S3UploadMetadata [directory=/var/mesos/slaves/4b0e9fed-0308-42ba-b856-d53e81fdb92e-S13/frameworks/Singularity/executors/tao5/runs/2acdee44-b2bc-4b85-8565-addb8ac48795/boban-test-32-1521797006456-1-db05-DEFAULT, fileGlob=service.log*.[gb]z*, s3Bucket=singularity, s3KeyFormat=boban-test/%Y/%m/boban-test-32-1521797006456-1-db05-DEFAULT_%index-%s%fileext, finished=false, onFinishGlob=Optional.absent(), pid=Optional.absent(), s3AccessKey=Optional.absent(), s3SecretKey=Optional.absent(), finishedAfterMillisWithoutNewFile=Optional.absent(), s3StorageClass=Optional.of(STANDARD_IA), applyStorageClassIfOverBytes=Optional.of(75000), uploadImmediately=Optional.of(false)], metadataPath=/var/log/singularity/s3/metadata/boban-test-32-1521797006456-1-db05-DEFAULT-file1.s3.json]

Since executor compress service.log and saves it to SANDBOX/log folder, uploader can't find it. I tried adding :
s3UploaderAdditionalFiles:
   - directory: logs

to /etc/singularity.executor.yaml, /etc/singularity.executor.cleanup.yaml, /etc/singularity.s3base.yaml  but nothing has changed.

Did you read through the release notes for 0.14 already? There is a section on configuration updates specifically related to s3 uploader configs https://github.com/HubSpot/Singularity/releases/tag/Singularity-0.14.0

I did it many times, tried everything. No success.

I'll edit the release notes later to make it more clear. In the notes it states that that config you posted gets removed from executor, but needs to be added to singularity service yaml. From the current release notes.
# in SingularityService yaml configuration
s3:
  s3Bucket: my-logs-bucket
  s3KeyFormat: "%requestId/%Y/%m/%taskId_%index-%s-%filename"
  s3StorageClass: "STANDARD_IA"
  applyS3StorageClassAfterBytes: 75000
  s3UploaderAdditionalFiles:
   - filename: access.log
     # The default directory in the executor was set to 'logs', now it must be manually specified
     # If not specified, the directory to search for log files will be the task app directory in the sandbox
     directory: logs

I've updated the release notes to make this more obvious. All you should need is something like:
s3UploaderAdditionalFiles:
  - filename: service.log
    directory: logs

in the service yaml config

That's good, now it works fine! Thanks for this.
Is there something I should do in order for UI to show uploaded log files to s3? If I remember correctly, UI was doing that some time before.

That part should have remained similar. If you had a custom s3KeyFormat in your old executor config, you'll want to move that to SingularityService as well, since it uses that to search for logs in s3

s3KeyFormat had and has default value now. It's interesting that I don't see logs that have been just updated.

How can I debug it?

Missing S3 logs from UI is related to #1640. So it is fixed #1762


get currentMediaItemIndex while using concatenatingMediaSource2

I want to add multiple videos to the player and then play it , and show one timeline to show the total duration for this earlier we had
setShowMultiWindowTimeBar
however it has been deprecated, so we switched to the new ConcatenatingMediaSource2 ,
we also want to access the currentMediaItemIndex however when we check the mediaItemCount its just one, which is the expected out put in normal situations.
how can we access  currentMediaItemIndex of each mediaitem that is added while using ConcatenatingMediaSource2
also according to this
can't add/remove media sources once the source is created.
so what is the alternative approach since we assume the setShowMultiWindowTimeBar will not be available soon

ConcatenatingMediaSource2 does merge together mulitple media items to a a single media item.  There is no way to seek to a certain media item within the ConcatenatingMediaItem2.
You can seek to a position in the ConcatenatingMediaSource2 with seekTo(positionMs). The timeline gives you an API to get the positions of the periods in the window and calculate the positions to be used with seekTo:
    Timeline currentTimeline = player.getCurrentTimeline();
    Timeline.Window window = new Timeline.Window();
    Timeline.Period period = new Timeline.Period();
    int firstPeriodIndex = currentTimeline.getWindow(0, window).firstPeriodIndex;
    int lastPeriodIndex = window.lastPeriodIndex;
    long startPositionMs = 0;
    for (int i = firstPeriodIndex; i <= lastPeriodIndex; i++) {
        startPositionMs += currentTimeline.getPeriod(i, period).getDurationMs();
    }


Merge pull request #1 from apache/master

9.5 update
What changes were proposed in this pull request?
(Please fill in changes proposed in this fix)
How was this patch tested?
(Please explain how this patch was tested. E.g. unit tests, integration tests, manual tests)
(If this patch involves UI changes, please attach a screenshot; otherwise, remove this)
Please review http://spark.apache.org/contributing.html before opening a pull request.

Can one of the admins verify this patch?

Looks mistakenly open. Could you close this please? @sphinx-jiang


Add LoadingBar component

Changes

Add progressive LoadingBar component
Add util to generate unique ids

Closes #75.

Not sure why that one test is failing — all tests pass locally.


Blacklisted entries takes too long to be resolved on Firefox

Blacklisted entries takes too long to be resolved on Firefox causing many pages to take more than 60 seconds to load.
For instance, if I try open an web page that on its <head> contains a JavaScript that loads a resource from a blacklisted domain, the page won't load until the name resolution for that resource is over. For some reason, perhaps because dnscrypt-proxy returns REFUSED instead NXDOMAIN for the blacklisted domains, Firefox wait some timeout until cancel the request.
If I try to access the blacklisted domain directly, I noticed the same issue on Firefox and also on GNOME Web Browser (epiphany), but on epiphany I couldn't reproduce the same issue when the blacklisted domain is an external resource of a page such as a JavaScript file.
I'm using dnscrypt-proxy 2.0.19.

I haven't been able to reproduce this using Firefox (assuming that you don't have anything else such as dnsmasq in front of dnscrypt-proxy).
But you can set refused_code_in_responses = false to return a successful but false response instead of REFUSED.

No, I don't have dnsmasq in front of dnscrypt-proxy.
Unfortunately the version I'm using (2.0.19, from Debian buster/testing) do not have the option refused_code_in_responses.

Oh, man. I had this on my resolv.conf:
options edns0 single-request-reopen

By removing this line it seems working fine now! Found it on https://github.com/jedisct1/dnscrypt-proxy/wiki/Installation-linux. What it really does? Is it important?

options edns0 alone is probably fine.
single-request-reopen changes the way queries for both IPv4 and IPv6 are handled, but it's not necessary at all, and is apparently a bad idea. I've removed it from the Wiki page.
Thanks!

awesome jedisct! thank you!


Example zoo for AI Platform

Example zoo for AI Platform:  samples runnable on AI Platform, automatically and minimally modified from existing samples.  The only changes made to the source examples are:

packaged as a python package called trainer with __init__.py, setup.py, submit.sh, config.yaml, README.md added.

optionally a utility file tfgfile_wrapper.py added to handle the situation when the source examples write to local disk instead of cloud storage.

Normally smaller PRs are easy to review, I see a lot of things happening 33 files :)

@gogasca Agreed!  Sorry it turned out this way.  I was going to merge the imported examples before adding tests in a separate PR.


Rebrand to Strawberry some repo pieces.

Codecov Report

Merging #243 (4f24d35) into master (14aee7d) will decrease coverage by 0.02%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #243      +/-   ##
==========================================
- Coverage   66.19%   66.16%   -0.03%
==========================================
  Files         352      351       -1
  Lines       28699    28694       -5
==========================================
- Hits        18996    18986      -10
- Misses       8231     8235       +4
- Partials     1472     1473       +1

Impacted Files
Coverage Δ

src/lazy/init.go
68.05% <0.00%> (-5.56%)
:arrow_down:

src/cache/filecache/filecache.go
76.97% <0.00%> (-2.16%)
:arrow_down:

src/hugofs/fileinfo.go
72.17% <0.00%> (-0.87%)
:arrow_down:

src/modules/collect.go
59.59% <0.00%> (-0.34%)
:arrow_down:

src/commands/check.go

src/resources/transform.go
72.95% <0.00%> (+1.63%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 14aee7d...4f24d35. Read the comment docs.

Codecov Report

Merging #243 (4f24d35) into master (14aee7d) will decrease coverage by 0.02%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #243      +/-   ##
==========================================
- Coverage   66.19%   66.16%   -0.03%
==========================================
  Files         352      351       -1
  Lines       28699    28694       -5
==========================================
- Hits        18996    18986      -10
- Misses       8231     8235       +4
- Partials     1472     1473       +1

Impacted Files
Coverage Δ

src/lazy/init.go
68.05% <0.00%> (-5.56%)
:arrow_down:

src/cache/filecache/filecache.go
76.97% <0.00%> (-2.16%)
:arrow_down:

src/hugofs/fileinfo.go
72.17% <0.00%> (-0.87%)
:arrow_down:

src/modules/collect.go
59.59% <0.00%> (-0.34%)
:arrow_down:

src/commands/check.go

src/resources/transform.go
72.95% <0.00%> (+1.63%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 14aee7d...4f24d35. Read the comment docs.


fix(es/minifiier): Add one more DCE pass

Description:
Related issue (if exists):

Closing as this is not useful for minifier


Nexpose Scans

Is there a way to import nexpose without knowing how to use google go?

Replied to your other thread in the main repository.


[posix] add posix system minimal init

This PR solves #6344.
This PR adds a method otSysInitMinimal for initialization when dry-run option is passed. When doing dry-run, many components are not necessary to initialize. This also avoids dry-run action (like print radio version) from being broken by failure in initialization of other unrelated components.

As discussed, we will keep it as it is and add backbone parameters when starting the daemon.


A Skyblock Suggestion.

https://www.spigotmc.org/resources/a-skyblock.1220/
Could the Variables for this be added. like island level?
Or will i have to move to uSkyblock..i would reeeeeally like to not have too do that. thanks

Or will i have to move to uSkyblock

No I'll add support for it when I have time.

awesome. :+1:


Support illumos target

Related to https://github.com/taiki-e/setup-cross-toolchain-action/issues/2
Thanks @taiki-e.

Published in 1.23.0.


Kbd-index-extension

This PR adds a minimal form of lazy indexing to allow for empty dimensions.

Looks good to me! Could you also add an eager version for Tensor and SwizzleArray? I think the specialization is something like Base.getindex(tns::Tensor, idxs::Vararg{<:Union{Colon, Nothing}}) = compute(lazy(tns)[idxs...])

What's the intended behavior for eager? It seems like the :/nothing construct is primarily meant for expressing lazy computation.

I think it would just eagerly insert a length-1 dimension? I was asking mostly because all of the constructs usually have an eager counterpart. Though no worries if you'd rather not add it here, we can skip it for now and add it later.


No directions and ETA

We noticed this from our users that share screenshots with us that sometimes they have a gray bar at the top where instructions should be and blank white space where ETA should be
we're using the 0.6.1 version of this package. We weren't able to reproduce this unfortunately. Maybe this happens when navigations completes?
we couldn't get any more info from our users

@jokerttu can you please take a look?

yes all default
<NavigationView
  mapViewCallbacks={mapViewCallbacks}
  onMapViewControllerCreated={setMapViewController}
  onNavigationViewControllerCreated={setNavigationViewController}
/>


Add Support For Linking @bpmn-io/form-js When Linking Dependencies

Works on my machine.
Related to https://github.com/bpmn-io/build-on-demand/issues/14.

I am testing this right now with https://github.com/camunda/camunda-modeler/actions/runs/892480848
The code looks good.

LGTM


Accepting completions emits YCM error

This error started appearing with increasing frequency over the last couple of weeks. I'm on nvim and this is my current init.vim.
MacOS version: 10.12.6
Neovim version: 0.3.8
Every time I accept a suggested completion, I get this error, which appears to come from somewhere in YCM:
Error detected while processing function <SNR>97_on_complete_done[7]..<SNR>97_substitute_suffix:
line    1:
E715: Dictionary required

Here's my tabnine config:
{
  "version": "1.0.10",
  "hide_promotional_message": false,
  "beta_enabled": "No",
  "ignore_all_lsp": true,
  "creation_time": "2019-08-21T16:59:39.965011Z",
  "semantic_status": {
    "python": "Enabled",
    "javascript": "Enabled",
    "unknown": "Enabled"
  },
  "disable_auto_update": false,
  "user_understands_that_enabling_tabnine_cloud_sends_code_to_tabnine_servers": false,
  "hosted_deep_completions_enabled": "Disabled",
  "tabnine_cloud_host": null,
  "tabnine_cloud_port": null,
  "cloud_whitelist": [],
  "api_key": null,
  "api_key_service_level": null,
  "api_base_url": null,
  "local_enabled": "Unset",
  "disable_local_when_using_battery": false,
  "hide_deep_information_message": false,
  "enable_power_saving_mode": false,
  "rate_limit_interval_seconds": null,
  "rate_limit_amount": null
}

Thanks for the great product! I'm new to issue boards so let me know what more information I can provide.

This was an issue born from a conflict between TabNine and the deoplete source for TabNine.


Add a paradigm to capture attention shift

Cognitive atlas uses
Inter-modal selective attention task
In general, should we try to more align paradigms with Cognitive Atlas

We are no longer encoding Paradigm.  Instead we have expanded the annotation capabilities of HED to capture task information. Attention is explicitly captures in the Task-property/Attentional-strategy. The shift can be captured using the Attribute/Relational/Connective-relation/From-to

We are no longer encoding Paradigm.  Instead we have expanded the annotation capabilities of HED to capture task information. Attention is explicitly captures in the Task-property/Attentional-strategy. The shift can be captured using the Attribute/Relational/Connective-relation/From-to


How about the TypeConverter support List,Set

The some like List<T> does't Support, but I think that It should support List<String> which only the type T is String.
That is your recommendation:
List<T>, Map<T>, etc. Best way to fix this is to create a separate table relationship
But the String does't need to build a Table...

If you use a List as TypeConverter that converts it to a string, that would suffice. Not something that's supported.


deploy/operator.yaml references outdated image

Hello! Came across your operator today and was very excited. It's super useful to me right now for repeatedly testing an internal endpoint. However, I quickly ran into an issue that was quite puzzling - I looked at the code for the ApacheBench CRD and it clearly listed all the different ab arguments including timelimit. However, setting timeLimit on the spec did nothing. Looking at git blame on the file, it looks like the initial version of the file only supported the basic arguments. I suspect you uploaded the image that is on quai.io before adding the other types. I tried updating the container to :latest and got the same results.
@jmckind Any chance you could publish a new image and update the deploy script? Thanks in advance!

Hey @mihasya, thanks for trying out the operator! I am glad that you have found it useful. I will take a look and get that sorted out.

Hey @mihasya, thanks for trying out the operator! I am glad that you have found it useful. I will take a look and get that sorted out.

Oh man so glad you got back to me! 😅 I thought it'd be quick to rebuild the image and upload it to our own repo, but it looks like this was built using an older version of the operator-sdk, which I know nothing about, so I got bogged down trying to figure out what version I needed to install. I don't have any hands on experience with the operator stuff, so I had to table that for now due to time constraints. Really hope you can republish an image, this is eminently useful and such a clever application of Kube jobs, CRDs and namespaces!

Oh man so glad you got back to me! 😅 I thought it'd be quick to rebuild the image and upload it to our own repo, but it looks like this was built using an older version of the operator-sdk, which I know nothing about, so I got bogged down trying to figure out what version I needed to install. I don't have any hands on experience with the operator stuff, so I had to table that for now due to time constraints. Really hope you can republish an image, this is eminently useful and such a clever application of Kube jobs, CRDs and namespaces!

Hi @mihasya. I rebuilt the operator and pushed a new latest tag today. Sorry for the delay but I had to go back to the older operator-sdk version like you mentioned. I am starting to test the issue you described now but wanted to give you a heads up that the new image is available.
If that still does not work for you, I am also working on updating the SDK dependency to the latest version but it takes a project migration to get to the new project layout, etc. That will take me a bit, but once I get it there I will resume finishing out the remaining work to get everything working like I envisioned, mostly around making the output from the job easier to consume.
Looking forward to any feedback that you have using it in "the real world". :)

One more thing, I have not updated the tag referenced in the operator.yaml just yet, so you will need to manually change the tag to latest on you side.

Thanks so much for releasing the new image! I tested it right away, and unfortunately ran into an issue. The new version correctly picks up the timeLimit arg, however there seems to be a bug with the new version of the operator where the job pods fail with a bash syntax error.
If you're short on time, perhaps you could let me know the version of the operator SDK that works and I can take a stab at patching it.
Output from describe pod/....:
Working with old version (note the missing -t):
    Command:
      ab
      -n
      5000000
      <snip>.us-west-2.elb.amazonaws.com/<snip>

Not working with new version:
    Command:
      bash
      -c
      'ab
      -n
      5000000
      -t
      15
      <snip>.us-west-2.elb.amazonaws.com/<snip>
      '

Logs of failing pod:
$ kubectl logs <snip> -n benchmark
-n: -c: line 0: unexpected EOF while looking for matching `''
-n: -c: line 1: syntax error: unexpected end of file

Yaml I'm sending in:
apiVersion: httpd.apache.org/v1alpha1
kind: ApacheBench
metadata:
  name: <snip>
spec:
  requests: 5000000
  timeLimit: 15
  url: <snip>

I am sorry, I had something that I was working on in my current branch and that caused the issue that you saw. I thought I had removed all of that but the alternate command for the job that you saw got through. I re-pushed the image, can I ask you to try one more time?
Full disclosure, it has just been me working on and using this, so I got a little sloppy with my process. Going forward, now that I am not the only one affected when I break stuff, I will make sure to do proper PRs, etc. for changes.

Also, yes I would love help if you are interested. The operator uses the old pre 1.0 version of operator-sdk, so I have been using version v0.19.4 to build it until I can migrate the project. I will also document the basic steps for developing on the operator to make it easier. Thank you again for your interest in this project!

I am up and running! Using latest - jobs work, and timeLimit is now recognized. Thanks so much for fixing this up! We've got a couple of load tests planned, so this is most excellent timing.
Looking forward to the dev docs.


fix: the input format

AIxplain Comment
File: src/google_gemini.py

Clearer explanation of unified diff

   --- a/src/google_gemini.py
 +++ b/src/google_gemini.py
@@ -41,7 +41,7 @@

{ai_input}
-
+This is the content of the file, followed by the changes based on unified diff:
 These are the changes, based on unified diff:

{changes}
   - The explanation of `unified diff` can be more clear by adding "This is the content of the file, followed by the changes based on unified diff:" before the diff itself.


Create Java-16/OpenJFX16 compatible release including the module-info

There was the nice PR #50 provided by @aashideacon proposing a JavaFX/OpenJFX16 related build. Hence FXFileChooser version 0.0.12 should target for JavaFX16.

Closed with 0b335be243d143c9b7de9cf7dce51cb1a9b746a6.


Added support Docker for easy way to use

Hi f3l1x,
you can try use dag with Docker and dummy data.
Only use this command docker run -p 5555:80 -d jakubenglicky/ninjify-dag:latest, visit http://localhost:5555/api/ and that's all.
Before merge this PR, my docker image change to an official ninjify organization.
It's possible for you?

Hi @jakubenglicky. Thank you very much for Docker stuff here.
I was thinking, what is the purpose of this PR, I mean dag is pretty simple and you can run it with PHP development server. Or am I missing sth?

You're right.


Fix for #31 support deserialization of IEnumerable with Add methods.

Motivation:
The current version of the library serialized any class that supports IEnumerable BUT expected it to be ICollection at deserialization. So, the classes that satisfy C# collection initialization pattern (IEnumerable + Add method) aren't properly deserialized.
Unfortunately, the existence of the ICollection interface is checked at the very last moment, in GenericReader.Read*Enumerable method. So, it is practically impossible to introduce a new object type for its own way to deserialize. I've also tried to replace ICollection with IEnumerable with implementing Add extension method to avoid massive code replication, but it works 2x slower for the ICollections.
So, the final implementation is:

There is a method Add for IEnumerable implemented via extension

At every switch branch for each object type in the collection a new branch for IEnumerable is added, in case the class does not implement the collection.

It added quite a few lines of code (~600 new lines of code) to GenericReader, but I see no option to avoid it without refactoring the whole approach that forces to replicate the code now.
The implementation for ICollection works as fast as before (as nothing changed in this branch of execution)
Implementation of IEnumerable + Add method call works ~8x slower than pure ICollection. There are options for how to optimize that further, however, the current implementations seem to be MVP for me and I would rather play first with code emitting which will help to avoid even more massive code replication.
Changes:
In the main library:

A new small class IEnumerableExtension that provides Add method for IEnumerable

Changes in GenericReader, methods ReadHEnumerable and ReadTypedEnumerable to add IEnumerable option at every switch branch where ICollection is used

In tests

A test collection class is added
Three tests (int, string, and object) are added to ListSerializationTest

p.s. "remove local development infrastructure files" commit removes files I have added to debug solution. Unfortunately, debugging via unit tests is almost not possible, as thousands of exceptions for the test case generator class prevent the successful start of the unit tests under the debugger (another point to think of, by the way). So, I've added a simple console application locally to debug, test performance, and other needs. This commit removes simply this test application from the project.

This looks good performance wise but can be improved a bit more - I've added comments inline.
Oh also can you squash the commits?

Ok, seems like I couldn't squash commits for the existing pull request, let's try creating another one. :-(