It would be great if point lights could have a radius

This would improve the realism of specular reflections where a light is relatively large compared to the distance of it from a surface. At the moment it is treated as infinitely small (that would be the definition of a "point" then) and so the reflections will look like small dots at close distances.

Have been thinking about how to do this off-and-on and wondering about the following:

Reflect the view ray off the surface normal to get a (normalised) reflection direction
Calculate closest point on this ray to the position of the light: dot product of fragment-to-light vector and reflection direction, multiplied by reflection direction, plus fragment position
Offset light along vector towards closest point by a maximum of the light radius
Attenuate light by some amount based on offset (not sure what the calculation for this should be)

This ought to give more believable specular reflections while not being too complicated to calculate.

A second possibility is just offsetting the light by its radius towards the fragment. Might be worth trying this first to see what that looks like…

A second possibility is just offsetting the light by its radius towards the fragment. Might be worth trying this first to see what that looks like…

OK, yeah, tried that. It doesn't work.

The winning solution was the second comment above: offsetting the point towards the reflection ray by up to radius. I am not attenuating the light at all, however, as I realised this doesn't make any sense. It would affect all light falling on objects from point lights and mess up the diffuse calculations as well. At the moment this means that reflections of ball lights off of shiny surfaces are a little crisp – I can revisit perhaps in the future.


ERROR: This playlist is private, use --username or --netrc to access it.

There's no way in the source code nor on the wiki site I could find a work around for this, I'll fix this by making the playlist unlisted, but I'd still like an explanation on how I fix this.

From what I speculate, the MusicBot itself needs to change configuration in order to hook or link YouTube accounts to the bot.

We don't support private playlists as we don't pass account information to youtube-dl.


Table Structure Not Correct

Issue in help/using/reference/ids-in-aam.md
Looks like the top table structure was corrupted on one of the recent updates

Thanks for reporting this, David! We're investigating and we'll update it.
Vlad Falon
Technical Writer, Audience Manager

The table should be displayed correctly now.
Thanks again for contributing, David!
Vlad


Add user guide "how to whitelist your token"

Are we missing a user guide "how to whitelist your token"? If yes, could you add it please.

https://guide.ref.finance/products/exchange/deposit
You can see it here.

邮件已经收到，我会尽快查看的～


Suggestion

This is awesome! It would be great if you added optional text on top of the foreground: "Text" or something, which could be colored independently, much like you do for foreground/background. I would like to be able to test text colors against background colors.
Thank you for such a great tool!

Thanks for the id idea! I agree that would be useful and while I would like to make some color picking tools which made that easier, I think setting text has quite a few variables and would probably warrant a dedicated mode. I'll consider this for the future, but with the current focus of this tool I don't think this will be implemented.
Also check it out, the site has been completely rewritten from scratch and now has HWB color modes.


Add media query extensions for the aspect ratio utility

Slightly puzzled as https://github.com/tachyons-css/tachyons-utilities isn't up to date with what's in this repo. Have the versions fallen out of whack?

@callum the versions of all modules have never been perfectly in sync. This patch is incomplete but added something similar to the upcoming 4.6.0.


Unknown props text throws warning

bundle.js:3453 Warning: Unknown props `text`, `options` on <div> tag. Remove these props from the element.

I wonder if these properties are even needed? It appears that the code is filtering the list of properties passed in to the editor, and copying some of those properties (like onChange, onFocus, etc.) to the div element being rendered by the component. However, some of these properties like 'options' and 'text' are not recognized by React, and in fact the React console warning claims that these are in fact a no-op. Yet the editor appears to work fine, so I suspect adding 'options' and 'text' to the blacklist would silence this warning without breaking anything.

+1

It appears that there's an open PR (BY @jossmac) that fixes this issue in just the way I described.

@wangzuo please see #34


The first line of code blocks is indented slightly, and should not be.

With the extension enabled, default settings:

With the extension disabled:

The first line of the code block seems to be indented by about 0.5em, for some reason. Successive lines are not indented.
This is the post used as an example of the bug.

How did I not get notified of this issue?? No email, no notification, no nothing :/
Thanks for reporting! I've fixed the issue and updated my Chrome extension -- it takes 1-2 days to get it reviewed by Google, so until then :)
The problem was that code blocks share a CSS class with inline codes, so the padding rule for inline codes was also being applied to code blocks, hence the first line having a slight indent. Why only the first line? Because code blocks are inline elements (i.e. display: inline;), so only the first line was affected.

Update is live on Chrome store :D


Work in the same environment with container

As a Contributor, I would like to work in the same environment as other collaborators.

Container: Kubernete, Docker...

Do elaborate @christianrd how would you achieve this?


Setting Modal = true in BrowserOptions does not work

Version: 13.5.1

Target:  windows

If you set BrowserWindowOptions.Modal = true when creating a new BrowserWindow, the created window will not be a modal window even after setting the parent.
Consider this code:
var parent = Electron.WindowManager.BrowserWindows.First(); // assume a main window exists and this returns it
var child = await Electron.WindowManager.CreateWindowAsync(
            new BrowserWindowOptions
            {
                Show = false,
                Modal = true
            });
child.SetParentWindow(parent);

child.OnReadyToShow += () =>
{
    child.Show();
}

child.OnShow += async () =>
{
    var isModal = await child.IsModalAsync();
}

The observed behavior of the child window is that it is NOT a modal window, and you can still interact with the main window (parent). The value of isModal in the OnShow handler is false, too.
I haven't investigated this, but it's possible that for modal windows to work the parent must be set inside the BrowserWindowOptions: https://www.electronjs.org/docs/latest/api/browser-window/#modal-windows

Update: I tested some changes locally and can confirm that setting a parent in the BrowserWindowOptions fixes the issue. Would you like me to make a PR with my test changes?

Interesting... id be interested to see if the javascript version of the add parent works or not.  If it does work, sounds like a bug in the implementation of that function.

Well if thats the case then this is less a bug and more of a documentation issue.  You might add to the readme.
I think more and more we need a howto or faq or something about some of these common issues.

@danatcofo unfortunately it's not just a documentation issue. To create a modal window, ElectronNET needs to add the Parent property to BrowserWindowOptions. It's currently impossible to create a modal window in C#.

Hi @MutatedGamer
We are facing the same issue. We would like to try out the fix you have made locally. Is it possible for you to share the updated code for us to try out? If sharing the code is not possible by any chance please let us know the list of changes to try out the fix.
Also, please let us know if there is any plan to release the fix anytime soon

@MonishaMaryA I'll submit a pull request this weekend with the changes I made to get it working

@MutatedGamer
Thanks for the update. Let us know once you submit a pull request. Do you have any idea on when the pull request will be merged and released?

@MonishaMaryA I created PR https://github.com/ElectronNET/Electron.NET/pull/673
I cannot speak for when it would likely get merged or released. I've been working off a local build of the library that I push to a local filesystem nuget feed.

Sure @MutatedGamer
Thank you so much for updating the fix and sharing the PR. We will also try to build locally and work.

@robertmuehsig , @GregorBiswanger
Could you please let us know when the pull request #673 will be merged and released?

Hi @GregorBiswanger ,
In the latest release 23.6.1, this fix is not reflected. Could you please check on this issue again?

Hi @GregorBiswanger and @FlorianRappl
I see that the PR 673 was merged to master branch which is now stale. We need this to be fixed as soon as possible. Could you please let us know if there is any possibility for fixing this and release  the update any time sooner


Support for VK_EXT_pipeline_creation_cache_control

This extension is particularly useful for asynchronous pipeline compilation systems and will improve the experience for emulator users like Cemu and Citra. It can also reduce draw time hitching in applications by making vkCreateGraphicsPipeline calls predictable. Most desktop drivers support it nowadays so it would be nice to see it implemented in MoltenVK as well.

I also would like to see this extension.  For us it would be a huge memory savings.  At a high level, here is how we use the VkPipelineCache when that extension is not supported:

Each rendering thread gets its own VkPipelineCache
At startup, we load a main VkPipelineCache from disk, then we do vkMergePipelineCaches to merge any cached shaders to the individual thread caches
When needing a new PSO, we create it on the individual thread caches, this is so that there is not lock contention and multiple threads can create PSOs at the sam etime
When we exit the game, we merge the individual per-thread caches back to the VkPipelineCache and then write that to disk

The problem is step 2 creates enormous copies in memory in copies of the MVKShaderLibrary that holds the std::string with the shader.
What we do when VK_EXT_pipeline_creation_cache_control is supported saves this memory in the following way:

At startup we load the VkPipelineCache from disk
When we need to compile a shader, we first call vkCreateGraphicsPipelines with the flag VK_PIPELINE_CREATE_FAIL_ON_PIPELINE_COMPILE_REQUIRED_BIT_EXT
If it fails, then and only then we create the pipeline on the per-thread cache
When it’s time to write the VkPipelineCache to disk on exit, we merge the per-thread caches

Since  VK_PIPELINE_CREATE_FAIL_ON_PIPELINE_COMPILE_REQUIRED_BIT_EXT should be lock free (and also quick) this allows us to avoid duplicating the cache to all of the per-thread caches whilst still having lock free behavior.

VK_EXT_pipeline_creation_cache_control is fairly easy and straightforward to implement, and we'll proceed to do so.
However, due to the current nature of Metal's pipeline serialization mechanism, it's not clear to what extent there will be large wins with regard to skipping compilations, until Metal makes certain improvements that we have suggested to them.

MoltenVK's current pipeline caching serializes pipeline MSL source code out to the cache, which saves the SPIRV-Cross to MSL conversion on recovery. This is one reason why MoltenVK retains the MSL source code internally after a MTLLibrary has been created. So the initial implementation of VK_EXT_pipeline_creation_cache_control will still trigger both shader and pipeline compilations.

The next MoltenVK caching improvement will be to use Metal's binary archives to serialize actual Metal pipelines. Doing so will save Metal pipeline compilation when pulled from the pipeline cache. However, to do so, Metal requires that we have the vertex and fragment shader functions from MTLLibraries, in order to look up the pipeline in the binary archive. The problem with this is that Metal provides no mechanism to serialize the MTLLibrary itself into binary form (this is something we've requested), which means we will still need to retain the MSL source code, serialize it into the cache, and compile the MTLLibaries in order to use them to look up a Metal pipeline in the binary archive.

Regarding the MSL source code memory issues, there are a couple of things we can do to improve this.

One is to compress the MSL text when we retain it, which should reduce the memory hit substantially.
I've anecdotally noticed that applications sometimes submit the same SPIR-V code to multiple VKShaderModules, resulting in the same MSL code, and compilation into multiple identical MTLLibraries. To reduce this redundancy, we can create an internal cache that will help eliminate this duplicate MSL source code and MTLLibraries.

I propose we approach this in the following steps:

Introduce MSL compression and internal caching to alleviate the immediate MSL source code memory pressure.

Implement VK_EXT_pipeline_creation_cache_control, with the understanding that, for now, it will kick back VK_PIPELINE_CREATE_FAIL_ON_PIPELINE_COMPILE_REQUIRED_BIT_EXT every time a pipeline is pulled from cache.

Use Metal binary archives to remove the requirement to perform a pipeline compile when pulling pipelines from the cache (shader compiles will still be required as explained above).

Migrate to allowing the SPRIV to MSL conversion to be independent of the pipeline structure (VA's and VB's), so that a SPIRV code will convert to the same MSL, regardless of the pipeline it will be compiled into. This will result in fewer distinct MSL and MTLLibraries.

If and when Metal supports serializing compiled MTLLibraries, introduce this to eliminate the shader compiles as a pipeline is pulled out of the pipeline cache.

@danginsburg

If it fails, then and only then we create the pipeline on the per-thread cache

If multiple threads try to retrieve the same pipeline, fail, and then create them in their own thread-cache, will each thread end up with copies of essentially the same pipeline? I guess there is no feedback into the global pipeline cache until the merge at the end?
I'm wondering if MoltenVK could internally feed this back to the global pipeline cache? I'm thinking the global cache could mark the failure, and then once a thread compiled the same pipeline, it could feed it back to the global cache, so a subsequent request from a different thread would recover it, rather than compile it again.
Or is it generally the case that only one thread will be interested in any particular pipeline?

@danginsburg
One more question. I guess without the extension, all of the pipeline caches are internally synchronized, but with VK_EXT_pipeline_creation_cache_control, you'd set all pipeline caches (including the global one) to be externally synchronized with VK_PIPELINE_CACHE_CREATE_EXTERNALLY_SYNCHRONIZED_BIT_EXT? Or would you leave the global pipeline cache internally synchronized?

Overall plan sounds good.  A few pieces of feedback:

However, due to the current nature of Metal's pipeline serialization mechanism, it's not clear to what extent there will be large wins with regard to skipping compilations

Yeah, I'm not expecting wins in terms of skipping compiles, I'm just looking for the big memory savings by not having to duplicate caches across threads.

I've anecdotally noticed that applications sometimes submit the same SPIR-V code to multiple VKShaderModules, resulting in the same MSL code, and compilation into multiple identical MTLLibraries. To reduce this redundancy, we can create an internal cache that will help eliminate this duplicate MSL source code and MTLLibraries.

For what it's worth, we already de-duplicate VkShaderModules for this reason as a memory optimization (it helped memory consumption on several real Vulkan drivers, including mobile).  From my experience, other Vulkan drivers. do not do this de-duplication.  I don't think it's necessary for MoltenVK to do it either, although I'm not against it as long as it doesn't add much overhead.

Introduce MSL compression and internal caching to alleviate the immediate MSL source code memory pressure.

That sounds reasonable, but if it was going to add significantly to PSO creation time I'm not sure I'm in favor of it.  Performance is probably more important than memory here.  The compression would need to be fast (i.e. < 0.1ms), or at least there would need to be an option to disable it.

If multiple threads try to retrieve the same pipeline, fail, and then create them in their own thread-cache, will each thread end up with copies of essentially the same pipeline? I guess there is no feedback into the global pipeline cache until the merge at the end?

We actually avoid this situation - if two threads encounter the same PSO, only one thread compiles it and the other one waits.  The merge at the end is what gets the individually thread compiled PSOs back into the main archive that gets serialized to disk.

I'm wondering if MoltenVK could internally feed this back to the global pipeline cache? I'm thinking the global cache could mark the failure, and then once a thread compiled the same pipeline, it could feed it back to the global cache (at this point, it would be a pointer copy, so fast even with locking), so a subsequent request from a different thread would recover it, rather than compile it again.

This is the app's job in my opinion.  I wouldn't add this complexity to MoltenVK.

One more question. I guess without the extension, all of the pipeline caches are internally synchronized, but with VK_EXT_pipeline_creation_cache_control, you'd set all pipeline caches (including the global one) to be externally synchronized with VK_PIPELINE_CACHE_CREATE_EXTERNALLY_SYNCHRONIZED_BIT_EXT? Or would you leave the global pipeline cache internally synchronized?

Actually, at the moment they are all still internally synchronized.  I should probably add VK_PIPELINE_CACHE_CREATE_EXTERNALLY_SYNCHRONIZED_BIT_EXT to the individual thread caches so the VK_PIPELINE_CREATE_FAIL_ON_PIPELINE_COMPILE_REQUIRED_BIT_EXT doesn't lock, although in practive I've seen this be so fast on drivers it didn't show up much.  I will be keeping the global cache internally synchronized for sure.

@danginsburg Thanks for all the feedback. Very helpful. And should simplify things somewhat.

Closing based on feedback on PR.


Where to generate the GISAID identifer

we could potentially catch this in fixed_data on upload

We won't. GISAID identifiers will be moved out of the biosample model (which was inappropriate in the first place, as its a sequence not sample ID). Published artifacts now belong in a PAG which can be tagged with accessions like this.


remove run_error from tracking code

This branch removes the run_error field from dbt's tracking code.
It uses the new 2-0-0 version of the run_model schema.
Closes #805

@drewbanin i nixed result as well. can you take a look?

test:
select event_id, run_error from fishtown_snowplow.run_model
where invocation_id in ('5eb37985-587c-4004-9137-a33cbc7ff061', 'bd6142dd-5fac-4c8f-ba55-45140e166011')
limit 10;

returns:
event_id                             | run_error
-------------------------------------+----------------------------------------------------------------------------------------------------------
1cae9a84-181d-4d1c-8e5d-7d24672cbce7 | Database Error in model moby_dick_base (models/moby_dick_base.sql)
                                     :   000904 (42000): 923491e6-b118-44c5-9ab7-7f230349f3cf: SQL compilation error: error line 5 at position 2
                                     :   invalid identifier 'ANOTHER_FIELD_THAT_DOES_NOT_EXIST'
                                     :   compiled SQL at target/run/talk/moby_dick_base.sql
9e906ecb-1daf-45d0-ba3d-8e92347dc50e |

the first event is on development, second is on this branch. the invocations both have null results


Repeating data read

  @SqlQuery
    List<T> getReadyEntries(@Bind("now") Date now,
                            @Bind("max") int max,
                            // This is somewhat a hack, should really be a @Bind parameter but we also use it
                            // for StringTemplate to modify the query based whether value is null or not.
                            @Nullable @Define("owner") String owner,
                            @Define("tableName") final String tableName);

I found there are multiple thread run getReadyEntries at the same time in the code. Will different thread repeated data right?

Please use the mailing list for questions

Please use the mailing list for questions

<EMAIL_ADDRESS>you mean this one?


Fix collision issues in box.py

The box.py script does not handle collision properly.

Expected Behavior
The box remains completely inside the white square even during collisions
Actual Behavior
The box overshoots the white square

Yo can I ?

One issue at a time

can i get assigned please

Sure thing all the best :)

hey can i get assigned to this?

can i get assigned please

@tejas-techstack are you still working on this?

he removed his assignment, can i get it now?

can i be assigned this issue?

Can I be assigned?

Assign me to this please

Go ahead @LalithaTanmayee

I'm having dinner, sorry
pls assign to the next person

so can i get assigned to this?

hi
can i get assigned to this
i even have the code ready

@LalithaTanmayee can you show me some progress by 10:15?
or I'll be forced to assign someone else

can i get this?

hey can i get assigned to this?

go ahead @aniruddhajoshi100

Could you please assign this to me?

Can I be assigned this?

can i get assigned if this is still open?


Compilation error for Curl backend on Scala Native

I'm getting this error when I add this dependency to the project
"com.softwaremill.sttp.client3" % "core_native0.4_3" % "3.8.15":
[error] /usr/bin/ld: cannot find -lcurl: No such file or directory
[error] clang: error: linker command failed with exit code 1 (use -v to see invocation)
[error] Failed to link

"curl --version" returns:
curl 7.81.0 (x86_64-pc-linux-gnu) libcurl/7.81.0 OpenSSL/3.0.2 zlib/1.2.11 brotli/1.0.9 zstd/1.4.8 libidn2/2.3.2 libpsl/0.21.0 (+libidn2/2.3.2) libssh/0.9.6/openssl/zlib nghttp2/1.43.0 librtmp/2.3 OpenLDAP/2.5.14

Turned out I need to install libcurl, not just curl :)


error text viewing blocks with theoneprobe

When I look at Ex Nihilo Adscensio blocks using theoneprobe (worn as a bauble), I see an error message as an extra (Error: exnihiloadscensio:topprovider). Screenshot:

This applies to at least the sieve, as shown, and the stone barrel. Relevant versions include:
Minecraft 1.10.2
Forge <IP_ADDRESS>4
Ex Nihilo Adscensio 0.1.17
theoneprobe 1.4.4
Baubles 1.3.9

Already reported in #111. Awaiting fix on TOP for me to fix.

Thanks, sorry for the dup. I did look through the open issues, but didn't trigger that an issue with console spam (that I wasn't seeing) would be related.


Enhance security:

OCSP-Stapling enabled by default
Client re-negotiation disabled by default
Any response headers can be configured. Suggestion for better security: set the system-property "athenz.response_headers_json" to something like this:
{ "Expect-CT": "max-age=31536000, report-uri="http://........"", "Strict-Transport-Security": "max-age=31536000", "X-Content-Type-Options": "nosniff", "Referrer-Policy": "strict-origin-when-cross-origin", "Cache-Control": "must-revalidate,no-cache,no-store" }

Signed-off-by: Gilad Ben-Dor<EMAIL_ADDRESS>

Merge hell. Closing pull-request.
Resurrected as https://github.com/AthenZ/athenz/pull/1353


tesseract not able to detect handwritten text even after improving image quality

Hi,
I'm trying to extract the handwritten data from image but even after improving the image quality tesseract is not able to detect handwritten text . can you please suggest me the steps to detect handwritten from given image.
Reference link -
https://github.com/tesseract-ocr/tesseract/wiki/ImproveQuality#rescaling
Image link
https://drive.google.com/open?id=1wv0JvuedQl99fYLNn8BMUId74PtLt_Ej
Regards
Rahul

Please respect guidelines for posting issue.


[ERROR]: Business Area's not completed-present for E2E - Order to Cash

Contact Details
<EMAIL_ADDRESS>Describe the error you see in the documentation, or the correction you suggest
There are 3 business area's (and subsequent business proces, patterns) that are not present/completed and or vice versa
65.10.0xx.x00 - Manage store operations (Guidance hub NO - BPC YES)
65.x0.0xx.x00 - Manage pricing and contracts (Guidance hub YES, BPC NO)
65.x0.0xx.x00 - Trade across companies (Guidance hub YES, BPC NO)
65.x0.0xx.x00 - Process customer rebates (Guidance hub YES, BPC NO)
Link to the article where the error is
https://learn.microsoft.com/en-us/dynamics365/guidance/business-processes/order-to-cash-overview https://github.com/microsoft/dynamics365patternspractices/blob/main/templates/business-processes/Business Process Catalog October 2023.xlsx
Code of Conduct

[X] I agree to follow this project's Code of Conduct

Changes to the articles have been submitted and will be published in the next round of publishing. The articles will now reflect the updates that are in the catalog. Thanks for submitting your feedback.

thank you! your feedback is appreciated


using navigatefallback causes Uncaught SyntaxError: Unexpected token <

I used navigateFallback : 'index.html' since I'm working with a SPA using react-router with browser history. However, when i did , it seems its effecting the facebook login button which causes errors. IF i remove navigate fallback option, the facebook login works fine. How do i blacklist the fallback so the facebook login works fine.

There is no blacklist for navigateFallback. What you can do instead is whitelist patterns of URLs that you do want matched, using navigateFallbackWhitelist.
The exact configuration you'd want really depends on your web app's URLs, but in general, try to use a RegExp that matches the minimal set of possible routes.


Set kube-score version tag

Description
This PR sets the kube-score image tag in the GitHub Actions to v1.11.0 to avoid unexpected checks to happen due to major changes to kube-score.

/merge


Fix typo in make publish target

OK, works on my machine. Will merge as soon as the PR build finishes successfully.


encoding issue in bdr:W22704_3352 ?

there seems to be an encoding issue in http://purl.bdrc.io/resource/W22704_3352.ttl :
"dbu ma'i skor/ (tsa锛�ngi)"@bo-x-ewts

same in http://library.bdrc.io/show/bdr:W22704_3292:

the encoding problem is in the original data


Closes #14234 and updates text

Carry of #14234
Fixing excessive notes in text

Signed-off-by: Mary Anthony<EMAIL_ADDRESS>

Just some nits, LGTM otherwise, thanks Mary!

I wonder if we can modify the its contents are replaced by the contents of - some users have taken this to mean that the container image will be modified, when in actual fact, the bind-mounted directory hides the image directory - and when the user docker commits the container, that image will not contain the bind-mounted files, but rather the underlying original files.

@thaJeztah for the merge.  Author LGTM

LGTM, thanks @moxiegirl (and thanks, Sven; good point)


Playbook partnership mano 20221129

some recent changes

I rebased your branch since there were only really 3 commits that needed to be there, make sure you rebase against main before starting new work


Run all services in parallel

Refactor pillar to be able to start all services in parallel inside device-steps

If I correctly understood the comment https://github.com/lf-edge/eve/pull/2839#issuecomment-1266149108, we should firstly try to refactor existence logic to be able to start services at some place in device-steps (after upgrade converter) and split device-steps later onto onboot and service part.
Inside this PR I put required changes. Probably we can split the last commit (about Fix flags parsing in go routines) into separate PR.

We can do this but to be safe we should add WaitForOnboarded() to the top of Run in agents which are currently started after client has run.

Well, seems it works, and handle certificate generation order as well (as we start client after all certs generated), thank you!


Improve method names

This PR introduces two method name changes in ReflectiveBuilder class.

@armiol, PTAL.


Add methods to API docs and use typehints

Currently the API docs are missing a bunch of xpublish.Rest methods, so this fills them out. It also switches to using type hints directly in the docs rather than requiring them to be specified in the docstrings.
Closes #160 #161
I'm headed out on vacation, so feel free to edit or merge away, otherwise if there aren't any complaints I'll land it when I get back.

Hi @thisch, thanks for the feedback and suggestions on how to better get autodoc-typehints and napoleon to play together. I haven't gotten much time to work on Xpublish for the last few weeks due to fighting various fires, but I'll make an issue to work on cleaning up the docstrings.


Bitbucket server badges for build

:clipboard: Description

:link: Data

:microphone: Motivation

Can you fill out the issue template with a bit more info on this suggestion. An issue like this would be a good example of the details we are looking for: https://github.com/badges/shields/issues/7919

I'm going to close given the lack of info in the OP and subsequent absence of follow up.
Additionally, it's unclear to me what this would have even been referring to. As far as I know, Bitbucket Pipelines remains a cloud-only service, so were we talking about.. Bamboo?
Furthermore, given Atlassian's prior announcements about decommissioning large swaths of their server products (including Bitbucket and Bamboo), I don't think it would be practical for us to try to add support for server-only badges, even if they are still selling DC licenses.


typo : "empthy" -> "empty" in 09-bootstrapping-kubernetes-workers

Just a fix for a simple typo.

sorry - duplicate of https://github.com/kelseyhightower/kubernetes-the-hard-way/pull/484


maximum_claim_blocks does not apply to spent claim blocks

I set maximum_claim_blocks to 50,000 but it only appears to apply to unused claim blocks, which makes the value relatively irrelevant as you could have 30,000 spent claim blocks and 50,000 unused for a total of 80,000, despite the limit

It was intended to only apply to unspent claim blocks (i.e. a max for that balance); I'll mark this as a feature request for a setting to specify the "maximum total claim blocks" or such.


Compatibility Issue: FaceAiSharp DetectFaces Method Fails with ImageSharp 3.1.1 Due to Missing ImageInfoExtensions

Compatibility Issue with ImageSharp 3.1.1: Missing 'ImageInfoExtensions'
Description
When the FaceAiSharp library is used alongside the latest version of ImageSharp (3.1.1), the DetectFaces method throws a runtime exception, indicating a compatibility issue. This problem does not occur with the older version of ImageSharp (2.1.5), suggesting that changes in ImageSharp's library, specifically the removal or modification of ImageInfoExtensions, might be the cause.
Environment

.NET Runtime: .NET 6
FaceAiSharp Version: Latest
ImageSharp Version: 3.1.1
Operating System: Windows 11

Exception Details
Could not load type 'SixLabors.ImageSharp.ImageInfoExtensions' from assembly 'SixLabors.ImageSharp, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=d998eea7b14cab13'.
Steps to Reproduce

Ensure the .NET 6 environment is set up with the latest versions of FaceAiSharp and ImageSharp (3.1.1).
Run the following code, replacing file paths with valid image paths on your system:

var selfiePath = @"<ReplaceWithValidPath>\Selfie.jpg";
var groupPhotoPath = @"<ReplaceWithValidPath>\GroupPhoto.jpg";

// Load images from file paths
using var selfieStream = File.OpenRead(selfiePath);
var selfie = Image.Load<Rgb24>(selfieStream);

using var groupPhotoStream = File.OpenRead(groupPhotoPath);
var groupPhoto = Image.Load<Rgb24>(groupPhotoStream);

var detector = FaceAiSharpBundleFactory.CreateFaceDetectorWithLandmarks();
var recognizer = FaceAiSharpBundleFactory.CreateFaceEmbeddingsGenerator();

var selfieFaces = detector.DetectFaces(selfie);
if (!selfieFaces.Any())
{
    Console.WriteLine("No faces detected in the selfie.");
    return;
}

Expected Behavior
The DetectFaces method should successfully identify faces within the provided images without triggering any exceptions.
Actual Behavior
An exception is thrown by the method, pointing to the inability to load the type ImageInfoExtensions, which suggests that this class has either been removed or relocated in the latest ImageSharp version.
Possible Solution
A review of the changes made between ImageSharp versions 2.1.5 and 3.1.1 could clarify whether ImageInfoExtensions has been deprecated or replaced. Adapting FaceAiSharp to align with these updates could potentially resolve the issue.

Fixed by #28

An updated version is now available on NuGet: https://www.nuget.org/packages/FaceAiSharp/0.5.23


Add a NOR trait to encode that word clearing is supported

This is to encode MCU flashes that have ECC, where it is common that only a complete clear of the word is allowed. This is a more restrictive version of MultiwriteNorFlash as it cannot encode flashes with ECC support.
Example use-case of this trait: https://github.com/tweedegolf/sequential-storage/pull/63

While obvious to add the trait like this, I'm not sure this is the best way to do it...
In Sequential-Storage I'd like to be able to switch behaviour depending on whether a true multiwrite can be done, or only a clear to 0. I'm not sure on how to do this.
However, say we change the MultiWriteNorFlash trait to have an associated const bool that declares the ability, then we could make a meaningful selection so it can use the pessimistic algo for clear-only.
But I'm still not sure that's the best API


Adding latest images

Closes #2242

https://www.howtogeek.com/devops/understanding-dockers-latest-tag/
I don’t think we should do this PR. Sounds like latest is a bit confusing and I’m not sure I like the idea of overwriting a docker image on every push.


Uncapitalize names on the About page

Description
On the about page (https://www.girldevelopit.com/about), the names of our staff and board are in ALL CAPS. This makes them hard to read (weird kerning) and hard to copy-paste into emails.
Ask
Switch to title case for the names
To Do

[ ] Create a h3.nocaps style
[ ] Apply to board names
[ ] Celebrate!

sorry, just forgot to mention this issue in my recent pull request.


unsoundness from use-conflicts

Currently the system is slightly unsound bc we may overestimate the number of places an invention is useful (since we dont capture conflicts) which will boost our best_invention_so_far which will cause us to overprune.
2 solutions: either rapidly detect a conflict or potential conflict and dont adjust the bound based on this invention; or rapidly calculate an exact conflict-aware cost.
Also note that we dont even complete inventions too often so its not too bad if thats slow and we do a more conflict-aware thing for it.

Currently we print [cost mismatch] at the start of the invention when this happens

This is important to do soon

Since this can only cause an over-estimate, map the rewrite_with_invention over the donelist_buf after filtering in order to get true costs, then re-filter based on these true costs, etc. I think youll want finisheditems to really carry around a true cost btw tho its fine if this isnt pushed at buf-push time but instead at final-push time.
And btw it'd be nice to have a flag that lets you do it at buf-push time too for debugging purposes since itd let you catch all cost-mismatches

solved in #101


Solves cancelling previous jobs #102

Description
Closes #102

Used Github Action's Cancel run workflow<EMAIL_ADDRESS>
Affected Dependencies
List any dependencies that are required for this change.
How has this been tested?

On pushing 2 commits to the repository
Action 1 will start to build. Action 2 starts after a few seconds. On running the cancel workflow, Action 1 will get canceled.
Typically, any previous workflows will be canceled on a new push to the repository

Checklist

[x] I have followed the Contribution Guidelines and Code of Conduct
[x] I have commented my code following the OpenMined Styleguide
[x] I have labeled this PR with the relevant Type labels
[x] My changes are covered by tests
@gmuraru

Could you push again here to see if it is canceled? https://github.com/OpenMined/SyMPC/actions

Could you push again here to see if it is canceled? https://github.com/OpenMined/SyMPC/actions

Just pushed one

Hmm -- it might be that we need this merged (in the main branch) and then we could create two PRs. I will try that after the tests pass and then I will try to create one dummy PR and push 2 times. If it does not work I will revert the changes.

Hmm -- it might be that we need this merged (in the main branch) and then we could create two PRs. I will try that after the tests pass and then I will try to create one dummy PR and push 2 times. If it does not work I will revert the changes.

Yes, sure. Let's see if it works. A screenshot of the actions on my repository:


Auto-Increment field

It would be nice supporting the sequence transparently by defining a property as AUTOINCREMENT, like with RDBMS.
Example:
ALTER PROPERTY User.id AUTOINCREMENT 1

In this case a new sequence User.id is created. Every time a new document/vertex/edge is created, the value of id will be sequence.next().

Is sequence.next() thread safe?

Yes.

+1 for AUTOINCREMENT or DEFAULT sequence().next()

Hi all
This is already supported in v 2.2, the syntax is as follows:
CREATE SEQUENCE seq type ordered;

CREATE CLASS Foo;
CREATE PROPERTY Foo.id INTEGER;
ALTER PROPERTY Foo.id default "sequence('seq').next()"

Thanks
Luigi


Remve attribute ogit:_tags from ogit:optional-attributes

What
Remove ogit:_tags described in optional attributes Variable.ttl
https://github.com/arago/OGIT/blob/4553c328c1df08f980486101a21b01f39ca2fe35/NTO/Automation/entities/Variable.ttl#L25-L27
Why

We don't need to describe fields such as ogit:_tags or ogit:_content explicitly.
It confuses some hiro-graph client libraries

The optional attribute 'ogit:_tags' was added to defines tags for each variable. So information such which variable belongs to which namespace can be gathered.
for ex. 'allowedTypes'  has tag 'Auth'  then it will be mostly used in Auth namespace.
So what kind of problems it is creating that it needs to be removed?

@KaushikGondaliya
You don't need to to add this attribute to use it. Same with ogit:_content or ogit:_id
We have a client library that shows this as an invalid scheme. Anyway, I think we could add a fallback for such case, but I thought it was added by mistake and created an issue.


Does Swipe support commenting?

How do you add a comment to a Swipe file?
JSON does not have capability of commenting. It might be easier to understand hard-coded values of positions or animations with some comments.
There are two approaches to add a comment to JSON data:

Use a JSON extension like JSON5 or CSON for commenting in a JSON-like format.
Add a comment as a JSON element with a key named, for example, "comment", "//" or "#".

I think the former looks better if a Swipe document is written with a text editor. The latter with an authoring tool.

Closing this issue. Swipe Engine does not support JSON5 nor CSON. Comments can be added with keys that do not conflict with those used by Swipe specification.


Change Management Document - near term implementation plan

Describe the Issue
Describe our Change Management procedure with an initial diagram and high level document
Additional Context
This is an initial step focusing on the near-term and we will add iterations to this document with time.
Description: Change management is about the implementation of processes and procedures that help not only manage platform changes but also communicate these planned events, while ensuring that any modifications are well understood, tested, planned for and documented_
Change Management diagram - business requirements:
Need to create a diagram documenting change management for the AWS landing zone. A change defines an event when the state of an existing service changes, either by introducing a new version of the existing service (i.e. upgrade), or a brand new service/feature (a new release) or decommissioning an existing service. The diagram should document the process the team follows if they need to make any change to the production environment for the Cloud landing zone.
Audience: The diagram is intended to be shared with our clients that using the AWS landing zone currently, who want to know how our team is managing changes in the landing zone production environment.
Process Scope: The change management flow in the diagram should reflect what improvements to the current change management process  we can introduce "tomorrow" without developing any additional code (ie. near-term).  The change management should only focus on the "landing zone"-level change,  client application changes are out of scope.
Additional requirements from Olena
The diagram/process should include the steps for 1) intiating a change i.e. a Change Request in a written form including the steps to implement and test the change as well as a rollback plan, 2) getting approval for the change i.e. from the Public Cloud PO, 3) scheduling the change for implementation in a non-prod environment i.e. create a ticket in ZenHub, 4) implementing the change in the non-prod environment i.e. create a PR and assign for review 5) approve the change for implementation in the the non-prod environment, 6) review the change to confirm there is no negative impact and 7) repeat the steps 3-6 for production environment. The process should also address what safety controls are in place to ensure only approved and reviewed changes are applied to prod i.e. a papertrail of the PO sign off and the approval for the PR before it is merged into the main branch. I would also like to see confirmation that all changes in prod are applied "as a code" i.e. no human can log in and click the buttons and there are safety controls that prevent humans from making unauthorized changes to the prod environment.
Acceptance Criteria

[ ] High level description (List format) (maximum 1 page)

Updated the business requirements (below Description) for this upcoming ticket, per our meeting with Olena today

Please include the information about the controls that the team has in place to ensure all changes are tested and reviewed/approved before applied in production.

Review of second draft of change management document with PO and post-review comments being incorporated.
Discussions from the Platform Admin perspective are forthcoming on this process and a larger team discussion has been scheduled for this draft.  A review with Olena will be scheduled when completed (targeted to Monday).  Thereafter as per PO discussions the following will occur:

Refinement of change management process as per the discussion with Olena and team comments
Second Change Management process test run (separate ticket)
CM post-Change process review for learnings/latest updates (ticket as above)
Results discussion and CM final draft process approval by Director for publication (ticket as above)
Process moved to visualization/publication stage (separate ticket - to coordinate with web design/publication group and publish diagram with Accessibility in mind)

Final draft was reviewed with Warren for the dev perspective.   Will review with Private Cloud for thoughts and a standards perspective with that team just before going to the visual process creation with the web design team

Private Cloud review of Change Management draft process took place and meeting discussion held.  It's ready for the visual flow creation.  Sending this finalized version to web design to kick-off that process.  Closing


Unsupported Site - Please add

Please follow the guide below

You will be asked some questions and requested to provide some information, please read them carefully and answer honestly
Put an x into all the boxes [ ] relevant to your issue (like this: [x])
Use the Preview tab to see what your issue will actually look like

Make sure you are using the latest version: run youtube-dl --version and ensure your version is 2018.05.18. If it's not, read this FAQ entry and update. Issues with outdated version will be rejected.

[x] I've verified and I assure that I'm running youtube-dl 2018.05.18

Before submitting an issue make sure you have:

[x] At least skimmed through the README, most notably the FAQ and BUGS sections
[x] Searched the bugtracker for similar issues including closed ones
[x] Checked that provided video/audio/playlist URLs (if any) are alive and playable in a browser

What is the purpose of your issue?

[ ] Bug report (encountered problems with youtube-dl)
[x] Site support request (request for adding support for a new site)
[ ] Feature request (request for a new functionality)
[ ] Question
[ ] Other

If the purpose of this issue is a site support request please provide all kinds of example URLs support for which should be included (replace following example URLs by yours):

Single video: https://www.bhg.com.au/koala-hospital?category=TV
Single video: https://www.bhg.com.au/magnolia-manor?category=TV

Note that youtube-dl does not support sites dedicated to copyright infringement. In order for site support request to be accepted all provided example URLs should not violate any copyrights.

Description of your issue, suggested solution and other information
Please add support for https://www.bhg.com.au/ site.  Thank you

Please help
I thought I had posted 2 links to the videos I can’t download. Here is one
https://www.bhg.com.au/koala-hospital?category=TV
Can you please have a look & advise what more info is needed. Thx

Sorry not noticing them.


24h format

Could you add support for a 24h time format? Thx!

The time format is determined by Nickel.
If you are running firmware 4.34.20097 or later, you can go to Settings > Date and time > Use 24-hour format

Great, found it. Thanks! :)

You're welcome.


cmd/dep: clarify ensure help text

A very tiny (but important) update to the help text: ensure no longer modifies the manifest file.

It may only modify the manifest when -update is specified.
https://github.com/golang/dep/blob/d89cec4d74469d69863a455c80c2e909c467bf34/cmd/dep/ensure.go#L164
Though to be honest I'm not quite sure if that will ever result in the contents of manifest being altered (other than reformatting)?

I was under the impression that the tooling treats the manifest as read-only, TOML formatting fixes notwithstanding.

So I was the villian who changed this in https://github.com/golang/dep/pull/235#pullrequestreview-21438086.  But I'm not sure anymore why I left this in:
https://github.com/golang/dep/blob/master/cmd/dep/ensure.go#L163
if !cmd.update {
		manifest = p.Manifest
}

It does result in minor tweaks to the manifest, such as in TestIntegration/status/case1, rewriting the following:
[[dependencies]]
  name = "github.com/sdboyer/deptest"
  version = "^0.8.0"

to this
[[dependencies]]
  name = "github.com/sdboyer/deptest"
  version = ">=0.8.0, <1.0.0"

I think those lines are a bug from my PR, and should be removed.

What a pickle this is.

Gosh, I apologize for all the confusion I've caused! 😞 I've spent more time today that I am willing to admit trying to remember when (if ever) dep should modify the manifest file now that it's a user managed file...
I'm pretty sure that I've left things in a bad spot and will clean up my mess once I understand the desired behavior.

@carolynvs oh no, it's no big deal - this should be an easy fix. Yes, @peterbourgon's right - the only command that can ever fully write out the manifest is dep init. The new spec in #277 contemplates a dep ensure -add that could append to the manifest - but never fully write it back out. -update is only about changing what's in the lock.

I just opened #454 to fix this goof on my part, and then realized maybe wasn't not a goof? I was just preserving the existing behavior, which isn't the same in the new command spec.
I can't remove modifying the manifest during ensure as long as we still support dep ensure<EMAIL_ADDRESS>dep ensure github.com/pkg/foo:git.internal.com/alt/foo, and dep ensure -override<EMAIL_ADDRESS>Let me know if I should close #454 or just updated it to make it clear that it's part of #277.

@carolynvs hm, yeah, on further thought, i realize, yes - these really are two separate changes. We'd conflated a bunch of things together with respect to the move to TOML, but really, the issue is that we didn't lay out appropriate follow-up issues after the merge.
Moving away from re-writing out the manifest is separate from moving to TOML from JSON. And, until we implement the changes to create a new dep ensure in #277...well, it might be better to NOT make this change, as it would make the current-implemented approach to dep ensure make less sense.
So, I guess we put this on hold, and try to get to a new version of dep ensure ASAP.

Incorporated by #480


Simplex Domain

Simplex Domain
Tests
Init

@ndem0 From my side the PR can be merged. @benv123 Did an amazing job in implementing sampling on arbitrary dimensions Simplex. We have both sampling on the interior and on the boundary.


Test reporter hangs on async tests

When I use the mocha test reporter to run a test like the following
main = run [mochaReporter] do
    describe "do something" do
        it "successfully does something" do
            liftEff $ log "hello"
            res <- later' 100 $ return "Alligator"
            liftEff $ log "good bye"
            return unit

, the test page just hangs showing passes: 0 failures: 0 duration: 0s. If I comment out the line containing later', everything works and the test success is shown. In either case the second log message is shown in the console.
(I apologise if this is expected behaviour / a user error. I'm new to purescript and js programming in general.)

Thanks for reporting! I'll look into this as soon as possible. :)

OK, I know what's the issue here and it's my original implementation of reporters in purescript-spec that's way to naive. Working on it now. :)

any news on this?   i may have time to contribute code to this, and changes will improve if you can fill us in on what you already know.  thanks!  (-:

Oh, sorry for dropping the ball on this one. Have been short on time lately, but I got somewhere with this on the async-reporter branch: https://github.com/owickstrom/purescript-spec/tree/async-reporter
It does not compile but I think it's nearly there. The idea is to change from having a fully collected test result tree which the reporters can use, to let reporters await tests themselves.
-- Previously:
type Reporter e = Array Group -> Eff e Unit
-- Now:
type Reporter e = Array (Group (Aff e Unit)) -> Aff e Unit

This way the mocha reporter can call the underlying it, describe etc synchronously and run the done callback asynchronously.
If you have the time to look at this and perhaps finish the stuff that I started that would be very helpful! :) I'd love to get some more people involved in this project.

ok, thanks!  i should be able to work with that.  now it's my turn to drop the ball.  but i'll try not to!  give me a week or two-  (-:

No problem at all, I guess it's you folks that need this the most right now, and I'm just utterly grateful for all the help I can get. :+1:


Enable CodeFolding Tests

Make sure to run the internal integration tests. Currently integration test runs are disabled on PRs so you wont see if these fail or not

This was what I was going to ask. Other than locally how do I kick them off?

Converting to draft until I can run the integration tests in CI, just to make sure this doesn't get checked in without the right validation

This was what I was going to ask. Other than locally how do I kick them off?

You can queue up a build for this branch on the Razor Integration Tests pipeline. It should then auto-show in the checks dialog here in GitHub I believe.

This was what I was going to ask. Other than locally how do I kick them off?

You can queue up a build for this branch on the Razor Integration Tests pipeline. It should then auto-show in the checks dialog here in GitHub I believe.

Looks like this only pulls branches from this repo, so I'll have to remake the PR

https://devdiv.visualstudio.com/DevDiv/_build/results?buildId=6454812&view=results

Pipeline is running at https://devdiv.visualstudio.com/DevDiv/_build/results?buildId=6489509&view=results

Looks like the tests are failing but I love that we're working on it.

  Is there a better way we can know that folding ranges were computed? Could we rely on telemetry somehow?

Interestingly I just ran the test, and it failed, but visually I could see in VS that the folding ranges were there, so timing makes sense.
Did these tests used to use `WaitForOutliningAsync'? Seems like that is the more standard process in integration tests, to just wait for things to be as we expect, and let the cancellation token take care of failures

Just checked, and adding in a call to WaitForOutliningAsync, before calling GetOutlineRegionsAsync, makes all of the tests pass on my machine.
I think it could even go further potentially, and have a method that waits for X outlining regions to be present, and then returns them.

WaitForOutliningAsync

The test basically waits for the correct number and expected outlining to be available. Adding a call to WaitForOutlineRegionsAsync should help with stability though.

The test basically waits

Looks like MaxTries is 1 at the moment, so thats not a lot of waiting 😛

The test basically waits

Looks like MaxTries is 1 at the moment, so thats not a lot of waiting 😛

I rewrote history and it now has 10 whole retries!!!


Installation and Setup on MACOS M1 Arm fails

Hi,
I downloaded the model and followed your instructions.
I get the following error
7b-v0.1
PORT=8080
MODEL_PATH=models--xingyaoww--CodeActAgent-Mistral-7b-v0.1
MODEL_DIR=.
CUDA_VISIBLE_DEVICES=
docker: Error response from daemon: unknown or invalid runtime name: nvidia.
See 'docker run --help'.
I figured out that MacOS is not supported by Nvidia Toolkit.
Any solution for that specific problem?
Thanks a lot

I have Docker Desktop installed on my Mac. What am I missing here?

vllm is not supported by mac.

So OS has to be Linux right?
Thank you

So OS has to be Linux right? Thank you

linux with Nvidia card and CUDA is better

Appreciate your fast reply. Last question do you run the demo on aws ec2? Can you let me know the configuration so I can deloy it? Thank you

Appreciate your fast reply. Last question do you run the demo on aws ec2? Can you let me know the configuration so I can deloy it? Thank you

Have a try with aws g5.2xlarge

you can also try to run the model with llama.cpp with openai Api support in macos

I need it local on MacOS but seems very heavy for that. Do you know a way to do so without breaking the limits? What would you suggest? Very painful and expensive going through AWS [g5.2xlarge] to test the capabilities and replicate the results. Would be great to discuss options

I need it local on MacOS but seems very heavy for that. Do you know a way to do so without breaking the limits? What would you suggest? Very painful and expensive going through AWS [g5.2xlarge] to test the capabilities and replicate the results. Would be great to discuss options

you can try llama.cpp python binding with openai API support. it’s not difficult.
I’ll try to submit PR for macos later.

You are a great help man. Developer power.
If you can drop a MacOS documentation as I and a lot of people are not familiar with it that would be awesome. I can give you instant feedback on that today. Would love to test it out and loop back

Also do you know a way to deploy it but not run out of cash as fast as aws g5.2xlarge ? Can I use something else?
So what exactly do I have to modify in Codeact scripts and bash commands to use llama cpp python?
https://github.com/abetlen/llama-cpp-python
Thanks a lot

I need it local on MacOS but seems very heavy for that. Do you know a way to do so without breaking the limits? What would you suggest? Very painful and expensive going through AWS [g5.2xlarge] to test the capabilities and replicate the results. Would be great to discuss options

you can try llama.cpp python binding with openai API support. it’s not difficult.
I’ll try to submit PR for macos later.

Can you provide the documentation for MacOS today? That would be awesome
The idea seems to be very effective. You guys did a great job

Also do you know a way to deploy it but not run out of cash as fast as aws g5.2xlarge ? Can I use something else?
So what exactly do I have to modify in Codeact scripts and bash commands to use llama cpp python?
https://github.com/abetlen/llama-cpp-python
Thanks a lot

install llama.cpp
prepare gguf format with llama.cpp:  check this link
start web server with the gguf model: check this link
any other steps.

Will try right now and let you know if it works
Thank you

I tried it but it is too complex for me. I need a step by step, command by command instructions. Would be great to get some help from you here. I think most of the people will never be able to do this on their own. Lets share it so the community can faster test and try it. Thanks a lot for your help

Are you able to give a step by step or even a short screen recording and paste it into the readme github?

Are you able to give a step by step or even a short screen recording and paste it into the readme github?

I will try to add gguf model and scripts later.

I have issues installing the nvidia cuda part. Can you tell what exactly you need to set up on linux to get it running?

I have issues installing the nvidia cuda part. Can you tell what exactly you need to set up on linux to get it running?

show more details about issues

The issue is that cuda and nvidia toolkit is not preinstalled on the ec2 instance. It is very painful to install them manually.
What is the easiest way to get the model running? On which cloud or instance with which specific configuration. It would be very helpful to get a documentation about that otherwise not a lot of people can reproduce results or optimize or contribute to the project.
Appreciate your help.

If you can leave a nice reproducible documentation step by step where folks can go through that way you will receive a lot of feedback for the model and the work.
Did you try the deployment over hugging face? Would that be an easy alternative?

Hey @faddy19, thanks for your interest in our work! Sorry for the late reply; for some reason, I did not receive email notification for this issue.
The goal of using vLLM is to serve an OpenAI compatible API on your localhost -- If that's not feasible on MacOS, you can consider using ollama that recently has support regarding local hosting (check this). This will allow you to run the model directly on your Mac without relying on AWS EC2 instance.
If you still want to get EC2 working, you can refer to this guide to install nvidia driver & cuda, and then this guide to install nvidia-docker to be able to run vLLM in docker.
Once you setup the vLLM, you can proceed with the rest of the README that using Docker.

That's great. I will try a local one today and provide feedback. This is very helpful. Thanks

Hi @sweetcard, thanks for suggesting using llama.cpp.
Hi @faddy19 , I got llama.cpp working on my MacOS laptop (M2 Max) and wrote instructions here. We actually don't need ollama since llama.cpp can already serve models into OpenAI-compatible APIs.
Please let me know if it resolves your issue!

Close due to inactivity - feel free to re-open if issue arise!


better Chinese zh_cn.json

Uploading zh_cn.json…

Hello!
It seems you were trying to upload a translation file, but the link does not go anywhere. Can you try uploading it again?


Creating Anagram Search

Adding Anagram Search

@Ratna04priya did u send a pull request for ur new algorithm?

@Ratna04priya did u send a pull request for ur new algorithm?

yes!


Function: Update an existing Agent pool

We need a  function to update an existing Agent pool.
docs: https://docs.microsoft.com/en-us/rest/api/azure/devops/distributedtask/pools/update?view=azure-devops-rest-7.1

Closed until needed.


Simplify builtin fill/splat dispatches.

Thanks! Now that these are reworked and simplified I'll probably end up combining them in a future PR.


MissingContentLength error

I can successfully connect to my local minio instance (and for example use the S3 list objects node).
When using the S3 put object node, I am getting MissingContentLength: You must provide the Content-Length HTTP header. error.
I did some troubleshooting and this seems to be related: https://github.com/airblade/right_aws/commit/e6cf18db65a4921615c88cdf52a14dafe94139d8
Does this require an update of the package or is there another workaround suggested?
On a side note (likely unrelated):
In client-s3-node field S3 endpoint is Red, indicating an error, although the value looks fine to me (and actually works, see list objects above):
https://mesh:9000

Hi @aperiodicchain, thanks for this issue. I will investigate about the MissingContentLength error and see what's causing it and where it is coming from. When it comes to the endpoint, the issue is that the address of the endpoint is checked in the client-s3-node with regex which actually checks for a domain, so it's looking for a proper domain, and you pass just a mesh string. I will take a look at that as well and see how to modify the regex and wether it is a good idea to do that or not.

Hi @aperiodicchain, can you please if possible provide a bit more information on how to reproduce this error, so far I wasn't able to reproduce it and I just was able to find out that when you try to upload object which is empty or has 0 length that is when this error occurs, but I wasn't able to replicate that either.

Hi @rristov60, sure please find my flow as json:
Hope this helps
debug_s3.zip

Side note: @rristov60 If you need Minio instance for testing & dev I recommend using Stackhero - fast to setup and tear down when you don't need it.

I have the same issue. I use Spaces from DigitalOcean which works fine with my other nodejs app.
I want to create a file with the content "Hello World". I put "Hello World" in body and get this Error Message: "MissingContentLength: UnknownError"
Where can I set the content length ?
Regards
Holger

https://github.com/minio/minio/issues/4152


Add a frame view

A frame view is a view that is capable of wrapping another object in some kind of border.
It is thematically described.  That is, its content is defined by a set of grouped constants in the theme store (a grouping of key/value pairs that describe what the content of the view should be).


Make tutorial_example_trainer build on Windows with Bazel

With these changes, we are able to build the C++ example trainer by
bazel build --host_cpu=x64_windows_msvc --cpu=x64_windows_msvc -c opt tensorflow/cc:tutorials_example_trainer
with Bazel from HEAD on Windows.
I modified the BUILD files carefully, hopefully it won't break TF build on other platform.
@mrry @damienmg @dslomov

Can one of the admins verify this patch?

Thanks for sending this in, Yun!

@tensorflow-jenkins test this please.

 Looks like there are many failures, I'll look into it.

Can we test it again?

@tensorflow-jenkins test this please.

@mrry could you take another look?

@mrry Just pushed, please review again. :)

@tensorflow-jenkins test this please.

From the error message in Linux GPU, looks like we should also pull depthwise_conv_grad_op out of deps, but  depthwise_conv_grad_op needs depthwise_conv_op.h. What should we do?

Or maybe they are in the deps for a reason? See these two commits b51ef0cd06e1bfb529b272e55010790ff3ead31f, 99e298a84775fcfe91ce0e2d40566d4bd00f53f9

I'm not sure what the proper solution would be for them. Assigning to @jmchen-g, since he wrote those ops originally.

Which deps are not clear here? If you mean why it is in the deps of nn, Depthwise is one of the convs that we need to support in TF and is commonly used to reduce the computing needs for a model.

OK, I see. Sounds like depthwise_conv_ops is supposed to be in deps of nn. I've deleted my last commit. Please test again?

@mrry Are you OK with keeping depthwise_conv_ops in deps of nn? If so, I think this PR is ready to merge.

@meteorcloudy Yes, that's fine. I suspect our existing build rules are not as clean as they could be for this op, but that shouldn't derail what you're trying to do :).
I'll go ahead and merge now.

Nice, thanks! \o/

This change is causing problems in testing now with BUILD rules. Apparently select() and glob() don't play nicely with each other.

@rohan100jain Can you show me the error message? I wonder why it's not causing problem before.. Users are beginning to try Windows build with Bazel now, reverting this will completely break them.

Even after fixing the bug at  https://github.com/tensorflow/tensorflow/pull/4796/files#diff-15609f78c0cd35bfdc31f9d8bd9b1e91R984
there are failures like:
https://ci.tensorflow.org/job/tensorflow-cl-sanity/14995/console
I tried various combinations of glob() and select() and none seem to work.

Just want to follow up on this. I managed to build label_image example using the same procedure. Have to fix a bug at https://github.com/bssrdf/tensorflow/commit/58f93bd1d5cf47e7cffa63b59569233e5d2faa34#diff-f6254560279f78a9d74e66dfd2d85977 for it to build on win. But it failed to run due to some file path issue
$ bazel-bin/tensorflow/examples/label_image/label_image
E C:\tools\msys64\var\tmp\Bazel\s5nfxnhX\execroot\tensorflow\tensorflow\examples\label_image\main.cc:279] Not found: Failed to load compute graph at 'tensorflow/examples/label_image/data/tensorflow_inception_graph.pb'
although the file tensorflow_inception_graph.pb is present in that directory.

@rohan100jain Hmm.. This is weird.
Here's what I tested:
I reset my branch to c20da148738df38c589fefc6287b64194b0ddbee, which is just before reverting this change.
And I ran bazel build --nobuild tensorflow/... on Mac, Linux and Windows. It all passed.
For glob() and select(), as long as you don't use select as arguments of glob, they will work just fine. So I'm not sure why it's failing like that on ci.
Can you give me some instructions to reproduce this error?

@rohan100jain OK, I know what's wrong. After reviewed the internal change, It looks like a bad merge. The internal change is not the same as this PR. I will send a PR again.

I believe there is nothing wrong with this PR, but I am not sure how to get it back. Another PR or revert the revert commit? @mrry

I think the best way forward is another PR. Should be quick to review if it's the same as the last one :).

OK, PR sent. https://github.com/tensorflow/tensorflow/pull/5009


nextTick

I believe that an installation should also run process.nextTick calls if possible to simulate correct timer flow.
Currently, lolex ignores process.nextTick calls which go out of order when testing Node calls :)
Fixing would look like:

detect if nextTick is present.
If it is, override it like setTimeout
Whenever timers are run - always before the next timer - call the nextTick callbacks in order registered.

Submitting a PR for this

Closed by #120.
P.S. You might want to check out this


Using mock to run wechaty will install puppeteer as default

Related log as follows, I think it should not install puppeteer when we use mock to start.
➜  wechaty-getting-started git:(master) ✗ WECHATY_PUPPET=mock npm start

><EMAIL_ADDRESS>start /Users/jiaruili/git/wechaty-getting-started
> node examples/starter-bot.js

10:28:42 INFO Wechaty <mock> start() v0.22.4 is starting...
10:28:42 INFO PuppetManager install(mock@latest) please wait ...
npm:
><EMAIL_ADDRESS>install /Users/jiaruili/git/wechaty-getting-started/node_modules/wechaty/node_modules/puppeteer
> node install.js

You should use WECHATY_PUPPET=wechaty-puppet-mock instead of WECHATY_PUPPET=mock because it's outdated.


minor fixes

removes MEISE from index on tool page
fixes a typo

Merged, thanks!
(PS: Don't be scared to explicitly request a review from some people for PRs. :)


Icons get stretched on multiline notifications

For multiline notifications the icon scales for each line, getting absurdly big with 3+ lines.

i believe that is due to https://github.com/ItsEthra/egui-notify/pull/5, i have a fork which makes this a bit better if you wanna try it

It'll try to fix it in the next couple of days

Should be fixed with https://github.com/ItsEthra/egui-notify/commit/4d02802ea44b305da47626af6aa39ec5491ed769


Update to Micronaut 4.0.0

Update Groovy version
Set source level to 17
Allow API changes
Fix Github actions to Java 17

Can you use master as the branch for this PR?. master already points to 4.0.x

Do I need to do anything to get this on master?  It was merged to 2.0.0 🤔


[adMob] Add a variety of ads

Please add display of Google ads such as:
Interstitial
Rewarded interstitial
Rewarded
Native advanced
App open
Delphi only supports Banners

Please visit the Playground for an implementation of Interstitial. More coming later.. maybe :-)

Thanks

When Rewarded ad added?
Why https://github.com/DelphiWorlds/Playground/tree/main/Demos/Advertising removed?

RewardedAd is in there. The demo was renamed to: https://github.com/DelphiWorlds/Playground/tree/main/Demos/AdMob


malformed for lw

I'm just learning mips, but I'm pretty sure this code should be correct.
.data
	ans: .word	42

.text
main:
	lw 	$a0, ans
	li 	$v0, 1
	syscall

    li      $a0, 0
    li      $v0, 10
    syscall

Instead I get:
lw $a0, ans`:6 malformed for `lw` on

(platform is windows with python 3.7 x86_64)

Hi! Thanks for giving my project a try, its still in progress so thank you for your patience with it 😅.
I've only permitted the non psuedo form of load word which would be lw $a0, 0($t0) where $t0 for example could hold an address. So quick fix would be to expand lw 	$a0, ans to:
la    $t0, ans
lw    $a0, 0($t0)

No need to read further if a solution is all you needed, but my thoughts on why this is is below:
So this still needs working out but psuedo instructions are not real in that they never make it to a mips cpu, they are expanded by the assembler to actual instructions. It was my thinking that I wanted to create something that only understood pure mips and that psuedo instructions would be some additional layer of preprocessing to be added later.
That being said there are a few that I added since it it really annoying to not have an easy way of loading addresses for an example. Still it felt strange to overload lw. Plus there may be a limitation in how I've implemented things but I would have to investigate.


MySQLTime should provide a more concise description

When converted to String via .description, MySQLTime gets the default description generated via Mirror, which looks like this: MySQL.MySQLTime(year: 2018, month: 11, day: 26, hour: 4, minute: 19, second: 24, microsecond: 955255). This is considerably more verbose than it really needs to be under most circumstances and makes the values provided in e.g. a DatabaseLog more difficult to work with visually. Since MySQLTime is internal to the mysql module, consumers of the driver can't add their own CustomStringConvertible or CustomDebugStringConvertible conformances to the type. MySQLTime should either provide description and/or debugDescription as e.g. return (try? Date.convertFromMySQLTime(self)).description ?? "<error>" or be marked public so apps can provide their own conformances or other mechanisms.

@0xTim LMK what you think of the fix in #222. It's a pseudo RFC 3339 format that doesn't require converting to/from Swift.Date.


No value formatter found for attribute Spine.Attribute on save()

Hello, I have a Resource class containing optional Strings, Dates, LinkedResourceCollection and other Resources.
When I am trying to save an object of this class, I am creating the object using values only for the subject attribute.
Some of the log messages are:
Debug    - Serializing attribute Spine.Attribute as 'subject'
Warning  - No value formatter found for attribute Spine.Attribute.
Info     - Saving resource resource(nil, nil) using URL: /resource
The thing is that the resource class seams to be ok, due to the fact that the fetching works perfect.
As a result the server does not receive any parameters.
(I made the POST using the PostMan and the JSON which the debugger returned me and the POST made successfully. So there must be something with the save function)

I have created a value formatter for the string attribute and the warning has been disappeared.


Hardcoded igv database

We have the igv database hardcoded in the code as a json. I wonder how often it changes and if this should be dynamic and fetch it from somewhere?
Or if we should leave like it is.
PUBLIC_GENOMES_FILE = 'public_genomes.json'

public_genomes.json was taken form the public URL https://s3.amazonaws.com/igv.org.genomes/genomes.json, as indicated at the end of this documentation page.
I am not sure if it changes often, but I thought that it was not meant to be loaded each time a new notebook starts.
Ideally it would be better to have a cached version in the package, and check for new versions once in a while, e.g. if instantiating an unknown genome.

public_genomes.json was taken form the public URL https://s3.amazonaws.com/igv.org.genomes/genomes.json, as indicated at the end of this documentation page.
I am not sure if it changes often, but I thought that it was not meant to be loaded each time a new notebook starts.
Ideally it would be better to have a cached version in the package, and check for new versions once in a while, e.g. if instantiating an unknown genome.

Yeah! Seems like a good idea.
Thanks for the input @harrouet. I'm mainly creating these issues as a form to keep track on things I'm thinking.
I'm giving a review in ipyigv.

Yeah! Seems like a good idea.
Thanks for the input @harrouet. I'm mainly creating these issues as a form to keep track on things I'm thinking.
I'm giving a review in ipyigv.

Sure, feel free to reach out in case of question!

Sure, feel free to reach out in case of question!

Thanks :)

Thanks :)


fix(remix-dev/vite): fix websocket double handleUpgrade error with custom vite hmr server config

Closes: https://github.com/remix-run/remix/issues/7953
In https://github.com/remix-run/remix/issues/7953#issuecomment-1821212710, @Mordred found that this is a general issue when using custom vite server config.
For the use case of child compiler, I think remix doesn't have to delegate user's vite config and also disabling server.hmr entirely seems appropriate.
Testing Strategy
I modified integration/vite-css-dev-express-test.ts to use this server.hmr.server config.
Also, I created a reproduction with the same patch to verify the fix in https://github.com/hi-ogawa/remix-repro-7953 (or https://stackblitz.com/edit/hi-ogawa-remix-repro-7953-mum9cp?file=server.mjs)
Note that this custom server setup is useful for https server as well. You can see this use case here https://github.com/hi-ogawa/test-remix-vite-express-https/pull/1.

@hi-ogawa using hmr: false is definitely something we want to do but this PR seems also concerned with createViteServer API. So I made a separate PR with just the hmr: false changes #8108 since I want to consider how we handle server configuration and HTTPS interop separately.

@pcattori Thanks for taking a look! The blocker for users was child compiler initialized with a  following type of vite config, so as long as it's gone, this issue https://github.com/remix-run/remix/issues/7953 should be resolved by your PR.
server: {
  hmr: {
    server: ...(user custom server)
  },
  middlewareMode: false,
}


MH-13681 Automatic publication of streaming URLs

First version without the implementation of the LiveScheduleService

@lwillmann I've restarted the buildbot build.  If you notice things failing like this again ping me or Lars and we can restart the build.

Thank you @gregorydlogan I will do so

When publishing events with streaming (e.g., HLS), the raw streaming URLs should be added to  existing publication-elements.

The live scheduler automatically publishes at the beginning of an event and the streaming URLs are added to the "engage-live"-channel

For VOD streaming, an option of the "publish-engage" operation should be added to generate streaming links under the "engage-player"-channel

Withdrawing published events already remove the publication-channels "engage-live" and "engage-play.

Hi Greg,
thanks for the review.
I hope my last commit has resolved all requested changes. Normally the publication of Streaming-URLs is switched off by not having a configuration at all.

Hi @rute-santos ,
thanks for your advice. I hope the method no behaves correctly.
Kind regards,
Ludwig

Since the Opencast 8 feature freeze is fast approaching, @rute-santos, do you mind reviewing and merging this once it is okay?


Ionic 5 - async in ion-content

I'm using a simple http get request in a service in an Ionic 5 application that returns an Observable. When I use that Observable with an async pipe inside ion-content in a template the ChangeDetection is not working on the data update of the Observable:
<ion-content>
  <div *ngIf="data$ | async as data>
    {{data.text}}
  </div>
</ion-content>

If I use the async pipe outside ion-content
  <div *ngIf="data$ | async as data>
    {{data.text}}
  </div>
  <ion-content>
  </ion-content>

the ChangeDetection works fine.
Is there anything (configuration?) I am missing?

Have you tried to manually force change detection as a workaround ? ChangeDetectorRef.detectChanges() using RxJs, your code should look something like this.service.MyAwesomeRequest().pipe(res => { this.changeDetectorRef.detectChanges(); return res;});

Thanks for the issue. Can you provide a repo with the code required to reproduce this issue?


add 'dom' domain

Sorry, my English is not good
problem
'dom' does not exist
solution
Addition of 'dom'
result
Corresponds to 'dom'

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Closing as invalid - "dom" is not currently a valid IANA gTLD and if and when it is added, the library will be updated.


Get Google Analytics working

Get a test/dev account for google analytics

[] login to google analytics
[] review the code for SPA
[] write a new components that listens to the route and reports to analytics
[] confirm the data in analytics truly reflects the navigation


[BUG] - InFutureExceedsClockSkew - I am not sure this is a bug, just not a FR

External
SPO for rabbitholepools.io [RABIT]
Summary
Following system reboot, relay node starts, syncs but immediately drops all outgoing connections and gets dropped by all incoming peers (no txn flow), with error in log file as follows:
{“at”:“2020-11-27T01:23:55.33Z”,“env”:“1.21.1:9577e”,“ns”:[“cardano.node.ChainDB”],“data”:{“kind”:“TraceAddBlockEvent.IgnoreInvalidBlock”,“block”:{“hash”:“5956c15”,“kind”:“Point”,“slot”:14873950},“reason”:“InFutureExceedsClockSkew (RealPoint (SlotNo 14873950) 5956c15ab55ef0f89d6d43d4e6e03a328ee158f28168471f15320dcceb6ae5c0)”},“app”:,“msg”:"",“pid”:“696”,“loc”:null,“host”:“ip-172-3”,“sev”:“Info”,“thread”:“39”}
More log info attached as separate file.
Steps to reproduce
Steps to reproduce the behavior:

Have cardano-node run as systemd service with unit as specified in attached file
Reboot system

Expected behavior
With the attached systemd unit, I have never experienced any issues starting/stopping/restarting the cardano-node. This applied to system-wide reboots also. Until Wednesday, Nov 25 2020, which is when this issue first presented (I have been using systemd for months, including testnet). I would have expected a system-wide reboot to be followed in quick succession by a start of cardano-node (within 45 seconds of rebooting). This always worked. The other day it didn't with error as above (and attached in logs).
At first glance I thought this was a time sync issue. So I discovered this:

the issue went away with a reset of the whole db (but replicated at the next reboot);
the issue did not seem to occur if the server was shut down and restarted (instead of reboot).

I decided to attempt to install chrony, and this, surprisingly solved the problem. I have attempted to replicate the issue and have not managed. Since then I have also successfully updated to 1.23.0 without a hitch.
IOHK_request_20201127.txt
reboot_fail_cardano_InFuture.txt
systemd_service.txt
System info (please complete the following information):

OS: Ubuntu
20.04
1.21.1

Screenshots and attachments
Please see attached systemd unit and log file snippet. Please let me know if you require more information.
Additional context
I have already posted this issue on the forum:  https://forum.cardano.org/t/system-time-sync-issue-causing-relay-wreck/42607
I have also opened a ticket with IOHK on Zendesk (106428 -attached).
Thank you for your time and patience.
All the best,
Adrem

The error you see is there to protect you from dishonest nodes setting their clock ahead so that they're in a future slot, which increases their chances of winning slot battles or just to make you adopt their chain, as it can be longer.
We do allow for some clock skew (a few seconds) as in practice not all nodes will have perfectly synchronised clocks. However, when we receive a block created in a slot that is unreasonably far in the future, we treat it as invalid (InFutureExceedsClockSkew).
It is very likely that this happened not because some dishonest node served you a block created in a future slot, but because your clock was running behind. This meant that blocks created by honest nodes were incorrectly considered as invalid.

I decided to attempt to install chrony, and this, surprisingly solved the problem.

With the explanation above, maybe you'll find this less surprising? :slightly_smiling_face:

the issue went away with a reset of the whole db (but replicated at the next reboot);
Note that in such cases, deleting the volatile folder will very likely be enough, and won't require you to sync the whole chain again, just a few thousand blocks.

We expect people to keep their clocks in sync. Most OSes or distros enable NTP or another daemon by default anyway. If we can't rely on this, how else could we detect the attack described above? We would have to incorporate some kind of NTP functionality ourselves. FYI, Ouroboros Chronos should take care of this too. So this is not a bug.

@mrBliss,
thank you for taking the time to clarify this issue with me. Really appreciate it!
I have taken the liberty to link this closed issue on the forum, where it appears as a solution. I hope it's OK.
All the best,
A


But Shapeshift is not working inside the bitcoin.com wallet!!!
PLEASE FIX OR REMOVE THIS SHITTY SERVICE FROM THE APP AND CONNECT COINEX.COM INSTEAD

The ShapeShift option in the Bitcoin.com wallet, should be a direct link to their website.
Due to the KYC laws ShapeShift now has to abide by, you cannot complete a swap from within the wallet anymore.
We released a statement about this here: https://news.bitcoin.com/bitcoin-com-wallet-will-no-longer-feature-the-shapeshift-service/
If this option is not linking you to the ShapeShift website, it sounds like you may have an old version of the wallet, please update to v5.2.0
If you require further assistance, please email our wallet support team:
<EMAIL_ADDRESS>


ps-autoenv and pipenv blocking

PS> Import-Module ps-autoenv
PS> echo "echo 'whoa'" > project/.autoenv
PS> cd project
whoa
the above commands are working well;
the following commands didn't work well.
PS> Import-Module ps-autoenv
PS> echo "pipenv shell" > project/.autoenv
PS> cd project
it's blocking.

ps-autoenv does, intentionally, block whilst waiting for the given command(s) to finish; I never really expected anyone to run anything interactive.
Not really sure how to handle pipenv shell off the top of my head... perhaps you could just use the virtualenv 'activate' script?
# .autoenv
pipenv --venv | Join-Path -ChildPath 'scripts/activate.ps1' | iex

#.autoenv.leave
deactivate

Does that help at all? Feel free to reopen if it doesn't or if you have any follow up questions.


AttentionWrapper incompatible with RNN

System information

OS Platform and Distribution: linux
TensorFlow version: pypi tf-nightly 2.2.0.dev20200212
TensorFlow-Addons version: pypi tfa-nightly 0.9.0.dev20200214
Python version: 3.7.5

Describe the bug
I would like to use an attention-wrapped lstm cell with tf.keras.layers.RNN, but I receive an error message related to the state type. The AttentionWrapperState initial state gets internally converted to a tuple, causing a type error.
Code to reproduce the issue
import tensorflow as tf
import tensorflow_addons as tfa

cell = tf.keras.layers.LSTMCell(8)

mechanism = tfa.seq2seq.LuongAttention(
    units=8,
    memory=tf.ones((2, 4, 8)))

cell = tfa.seq2seq.AttentionWrapper(
    cell=cell,
    attention_mechanism=mechanism)

layer = tf.keras.layers.RNN(cell)

initial_state = cell.get_initial_state(batch_size=2, dtype=tf.float32)

output = layer(
    inputs=tf.ones((2, 4, 8)),
    initial_state=initial_state,
)

Other info / logs
  File "/home/john_tukey/miniconda3/envs/tfn/lib/python3.7/site-packages/tensorflow_core/python/keras/engine/base_layer.py", line 864, in __call__
    outputs = self.call(cast_inputs, *args, **kwargs)
  File "/home/john_tukey/miniconda3/envs/tfn/lib/python3.7/site-packages/tensorflow_core/python/keras/layers/recurrent.py", line 793, in call
    zero_output_for_mask=self.zero_output_for_mask)
  File "/home/john_tukey/miniconda3/envs/tfn/lib/python3.7/site-packages/tensorflow_core/python/keras/backend.py", line 4092, in rnn
    input_time_zero, tuple(initial_states) + tuple(constants))
  File "/home/john_tukey/miniconda3/envs/tfn/lib/python3.7/site-packages/tensorflow_core/python/keras/layers/recurrent.py", line 778, in step
    output, new_states = cell_call_fn(inputs, states, **kwargs)
  File "/home/john_tukey/miniconda3/envs/tfn/lib/python3.7/site-packages/tensorflow_core/python/keras/engine/base_layer.py", line 864, in __call__
    outputs = self.call(cast_inputs, *args, **kwargs)
  File "/home/john_tukey/miniconda3/envs/tfn/lib/python3.7/site-packages/tensorflow_addons/seq2seq/attention_wrapper.py", line 2038, in call
    "Received type %s instead." % type(state)
TypeError: Expected state to be instance of AttentionWrapperState. Received type <class 'tuple'> instead.

This kind of construct used to work in TensorFlow 1.

Hey, I think that I've fixed it by packing the state back into an AttentionWrapperState before the type check. To keep the change minimal, I deliberately avoided making any changes to RNN that calls a _standardize_args method in first place. Any thoughts, should this be submitted upstream ?
https://github.com/georgesterpu/addons/commit/2f5863abc0aff96df99223964c828a8bb13515ec

Any thoughts, should this be submitted upstream ?

The best practice is to avoid implicit casts. It would be better to explicitly extend the list of allowed inputs and maintain them appropriately. Effectively the same thing but without surprises.

@failure-to-thrive
Sorry for not fully understanding your message, is it correct to infer that you recommend something like: AttentionWrapperState(cell_state=state[0], attention=state[1], ...) ?
I had a quick look at the documentation of collections.namedtuple, and it omits this aspect.
It says: To convert a dictionary to a named tuple, use the ** operator (as described in Unpacking Argument Lists):. Can we make an analogy and use the * operator for list to namedtuple conversions ? Since the AttentionWrapperState object x is converted to a list inside keras.layers.recurrent._stardardize_args as list(x), would the * operator preserve the argument order throughout packing and unpacking ? The example in Unpacking Argument Lists instructs: If they are not available separately, write the function call with the * operator to unpack the arguments out of a list or tuple; range(*args).
I can see instead that flake8 mentions a codestyle issue: E722 do not use bare 'except'. Also, namedtuple has a method _makefor creating new instances, is this recommended over namedtuple(iterable) ?

I posted a reply earlier, but soon realised that I misunderstood your advice.
What would you recommend in this specific case ?

Now it is mostly a documentation job. You've already done the rest. But the code owner knows best.

Maybe we could always call AttentionWrapperState(*state) and update the documentation to say something like:

state: A tuple or list that can be packed as an AttentionWrapperState instance

What do you think?

Personally I did not investigate the logic behind state flattening inside RNN, but if you are okay with this solution, I can go ahead and submit a PR with your amendments.

Maybe @qlzh727 has an additional suggestion as he worked as this Keras code.

Thanks for reporting the issue, the issue is caused by force converting the initial_state tuple into list during input process. The reason behind that is keras need to have all the input tensors in its first argument for the call (). Under the hood, we flat all the inputs, inital_state into list, and then get them back in call() body.
For now, you just need the default initial state (zeros), then you can skip the line for get_initial_state(). RNN layer will call cell.get_initial_state() if the initial state is not provide. In the case u need to provide a non-default initial state, then lets update the AttentionWrapperState to accept list as inputs during construction.
In the meantime, let me check the keras code and see if we can walk around the issue for having all the tensor inputs in the first arg. This assumption might not be needed anymore after recent rework.

@qlzh727 thanks for looking into this.
Although I don't need a non-default case, unfortunately the call to RNN with initial_state=None still returns the same error.

@qlzh727 thanks for looking into this.
Although I don't need a non-default initial state, unfortunately the call to RNN with initial_state=None still returns the same error.

Indeed, it seems that there are more assumptions in the keras backend RNN code that it will convert the state into tuples and pass it to the cell.call(). Changing that might require a lot of work, and could potentially break others. Let me see if we can reconstruct the AttentionWrapperState with the value from tuple.