Incorrect indentation and missing newline for multiline docstring

Discovered in my project: https://github.com/laggykiller/apngasm-python/tree/stubgen-fix
To build and reproduce
git clone --recursive https://github.com/laggykiller/apngasm-python.git
cd apngasm-python
git checkout stubgen-fix
python -m build .

https://github.com/laggykiller/apngasm-python/blob/stubgen-fix/src/apngasm_python.cpp#L253
        .def("add_frame", nb::overload_cast<const apngasm::APNGFrame &>(&apngasm::APNGAsm::addFrame),
        "frame"_a,
        R"pbdoc(
        Adds an APNGFrame object to the frame vector.

        :param frame: The APNGFrame object to be added
        :type frame: apngasm_python._apngasm_python.APNGFrame

        :return: The new number of frames/the number of this frame on the frame vector.
        :rtype: int
        )pbdoc")

The generated pyi
    def add_frame(self, frame: _apngasm_python.APNGFrame) -> int:
        """
                Adds an APNGFrame object to the frame vector.
        :param frame: The APNGFrame object to be added
        :type frame: apngasm_python._apngasm_python.APNGFrame
        :return: The new number of frames/the number of this frame on the frame vector.
        :rtype: int
        """
        ...

The expected correct pyi generated should contain
    def add_frame(self, frame: _apngasm_python.APNGFrame) -> int:
        """
        Adds an APNGFrame object to the frame vector.

        :param frame: The APNGFrame object to be added
        :type frame: apngasm_python._apngasm_python.APNGFrame

        :return: The new number of frames/the number of this frame on the frame vector.
        :rtype: int
        """
        ...

Note that help() shows correct docstring
from apngasm_python import _apngasm_python
help(_apngasm_python)

...
     |  add_frame(...)
     |      add_frame(self, frame: apngasm_python._apngasm_python.APNGFrame) -> int
     |
     |      Adds an APNGFrame object to the frame vector.
     |
     |      :param frame: The APNGFrame object to be added
     |      :type frame: apngasm_python._apngasm_python.APNGFrame
     |
     |      :return: The new number of frames/the number of this frame on the frame vector.
     |      :rtype: int
...

Should be fixed with the changes. It seems that the generated pyi is now error free for your module.

Version 0.1.3 is released. Please give me a feedback if everything runs.

Thank you for your hardwork. Can confirm the problem is fixed!


Update disponsable domain list

Update ths list according to gist.github.com/michenriksen/8710649#.
QQ.com is a domain owned by the Tencent, so it was removed.
Also, some domains were added from sites like temp-mail.org or mohmail.com#.

thx


integ-tests: reduce number of EIPs required by tests

As long as the compute nodes are in a private subnet with NAT and the master subnet has auto-assign public ip set to true then we can set use_public_ips to false. The master still gets a public ip from the subnet setting (auto-assign public ip) while the compute nodes only need a private IPs.
This reduces the number of Elastic IPs required to run integration tests.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Codecov Report

Merging #1683 into develop will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop    #1683   +/-   ##
========================================
  Coverage    52.61%   52.61%
========================================
  Files           24       24
  Lines         3959     3959
========================================
  Hits          2083     2083
  Misses        1876     1876

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 481f404...70cef70. Read the comment docs.


Update travis scripts for bumping and publish

This project uses semver, please check the scope of this pr:

[ ] #none# - documentation fixes and/or test additions
[X] #patch# - backwards-compatible bug fix
[ ] #minor# - adding functionality in a backwards-compatible manner
[ ] #major# - incompatible API change

CHANGELOG

Updated the travis scripts used for bumping and publishing

Changes Unknown when pulling 33c6cd040fa9c0c832fcf76fa145ace43892f21d on juwara0:updateTravis into ** on ciena-blueplanet:master**.


Introduce invcircuit and dagcircuit functions

Introduce the dagcircuit function, which does the following:
gates = [("Rx", 1, (θ = π/4,)),
         ("Ry", 2, (θ = π/4,))]

dagcircuit(gates)

returns the gate list:
 ("Ry", 2, (θ = 0.7853981633974483, dag = true))
 ("Rx", 1, (θ = 0.7853981633974483, dag = true))

i.e. it reverses the gate list ordering and adds the dag = true keyword argument. Then, the gate function can be generalized to recognize the dag flag, and perform the conjugate transpose of the gate when the ITensor is made.
Similarly, an invcircuit function could be defined which instead adds the flag inv = true, which could work for nonunitary gates.

The dag part has been done, I'm closing this for now and re-open in the future if we actually need the inv


Allow setting expires headers, use browser caching and improve gtmetrics results

I have a GatsbyJS site that I tested with Azure Static Web Apps.
I've tested both versions with GTMetrics.
On the left is the version using Azure Static Web Apps and on right my old version (running on Apache). Currently, the code on both sites is identical.

The biggest downsides are:

browser caching
expires headers
cookie-free domains

my current webserver is running on Apache and I'm using gatsby-plugin-htaccess to generate .htaccess files.
what alternatives I should use for Azure Static Web Apps? If there are any available there should be mentioned in the docs.
I've noticed that the version on Azure Static Web App is 114KB bigger. Any ideas why?

We are working on adding custom headers, you can see that in this issue: https://github.com/Azure/static-web-apps/issues/2
As for the increased size that does seem strange, could this be related to the type of compression? We dont have brotli support right now.

@miwebst that might be brotli.
My current website is returning x-content-encoding-over-network: br but Azure Static Web Apps is returning x-content-encoding-over-network: gzip
When can we expect brotli? Is there an issue for that?
Looking forward to those customer headers :) they will address first two of my list, but what about cookie-free domains? Ideally, site hosted on Azure Static Web Apps should be all green on gtmetrics or at least better than standard Apache shared host.

Hi Misiu,
To answer your questions:

Brotli support is on our roadmap, I dont have an ETA for you but hopefully this will be out soon :)
Cookie-free domains: unless you are using auth static web apps should be cookie free today, let me know if that is not the case
Custom headers: we have a preliminary option for this here: https://docs.microsoft.com/en-us/azure/static-web-apps/routes#default-headers - please let us know if you have feedback!

Note on custom headers: right now they are part of the routes.json file, we will most likely move to a general config file later on

@miwebst thanks for the update.
I'll check cookie-free domains and custom headers right away.
Can I contact you directly? I can send links to both sites hosted in Azure Static Web Apps and on a classic host. They are 1:1 and I use them to compare performance using GTMetrics and other tools.

@miwebst in my Gatsby project I'm using gatsby-plugin-htaccess.
It builds quite complex .htaccess file, this is part of it, that is responsible for cache-control:
# ----------------------------------------------------------------------
# | Expires headers                                                    |
# ----------------------------------------------------------------------

# This matches the settings described at:
# https://www.gatsbyjs.org/docs/caching/

<IfModule mod_headers.c>
    <FilesMatch "\.(html|json)$">
        Header set Cache-Control "public, max-age=0, must-revalidate"
    </FilesMatch>
    <FilesMatch "\.(js|css)$">
        Header set Cache-Control "public, max-age=31536000, immutable"
    </FilesMatch>
    <Files sw.js>
        Header set Cache-Control "public, max-age=0, must-revalidate"
    </Files>
</IfModule>

How can I recreate the same functionality with Azure Static Web Apps routes.json? (specify header per file type)

On the right is the same website running on old Apache hosting, on right the website running on Azure Static Web Apps

As you can see in the above picture Expires headers are the main reason for such a low score.

I see, for now we just added default headers that apply to all static content served. In the future we are planning to add this functionality so you can specify particular headers based on the route.

@miwebst I hope it is a near future :)

@miwebst any updates?
Is there a roadmap available for static web apps or a user-voice portal?

There is currently not a public road map and these Github pages have been serving a little as a user-voice portal. There is also an official Azure App Service user voice page that you can create items on.
As for this specific issue, we need to change how our configuration file is designed to enable a more streamlined experience when editing the headers for a particular path. We are working on this but I dont have any updates right now.

Any new Updates on it? We need the same tools for an experies header

@miwebst any updates? This is one of two issues that is holding me back from using Azure Static Web Apps 😐

So for transparency, we are working on revamping our config file experience to be more flexible. This work is nearly done and once we finish the documentation it will be live :) I expect this will finish by the end of the month.
What is the other issue holding you back?

@miwebst thank you for reply :)
Really looking forward to this. If the format will be flexible I'm sure that soon a plugin for Gatsby will be created that will allow generating such files (similar to htaccess generator that already exists)
The second issue is with password protect, many users (including me) need a way to password protect entire website. I've already created an issue for that: https://github.com/Azure/static-web-apps/issues/94

@mkarmark Do you know if the new config file can handle this? (different headers based on file extension)

@miwebst any updates on this issue?

@miwebst any updates on this issue?

@anthonychu The new config file does not currently support different headers based on file extensions though that is something we can work on supporting if there is a demand for it.

@anthonychu The new config file does not currently support different headers based on file extensions though that is something we can work on supporting if there is a demand for it.

@Misiu  Sorry for the delay on this. We just launched the new config file. It has some breaking changes from routes.json but does have support for applying different headers based on different file types! https://docs.microsoft.com/en-us/azure/static-web-apps/configuration

@miwebst thank you for the update! I'll definitely take a look and give this a try.

fixed by new config, @Misiu please reopen if you're still seeing the original issue.


D435 "Import Error: DLL load failed: The Specified module could not be found"

Before opening a new issue, we wanted to provide you with some useful suggestions (Click "Preview" above for a better view):

Consider checking out SDK examples.
Have you looked in our documentations?
Is you question a frequently asked one?
Try searching our GitHub Issues (open and closed) for a similar issue.

All users are welcomed to report bugs, ask questions, suggest or request enhancements and generally feel free to open new issue, even if they haven't followed any of the suggestions above :)

Required Info

Camera Model
D435

Firmware Version
<IP_ADDRESS>

Operating System & Version
Win 10

Platform
PC

SDK Version
2.0

Language
python

Segment
{Robot/Smartphone/VR/AR/others }

Issue Description
Hello all! I am trying to set up some code for my D435 Intel Realsense Camera, and have already installed the SDK as well as the GitHub librealsense folder. I have set the appropriate environmental variables (I believe), and after dragging the realsense dll file and the pyealsense2.pyd files into my project folder, as well as copying them into Python folder and setting the appropriate path variables, I am now met with the issue of "Import Error: DLL load failed: The Specified module could not be found". Any help would be greatly appreciated, thanks!

[Realsense Customer Engineering Team Comment]
Hi @jasonjsong,
did you use the prebuild library from the Realsense SDK, rather than build it from source ?
if that is the case,
(1)Note that these binaries are built with Python 2.7, and cannot be import using Python 3)
(2) please check if either Miscrosoft Visual c++ 2015 Redistributable (X64) or Microsoft Visual c++2017 is installed on your PC, if no, please install either one
best
wwppyy

I have still the same problems (https://github.com/IntelRealSense/librealsense/issues/1877 - unfortunately all hints doesn't work for me. Miscrosoft Visual c++ 2015 Redistributable (X64) is installed.)
You say, the binaries cannot import using Python 3 - @dorodnic said:

Hi @LeMajors
Can you try the files installed with Intel.RealSense.SDK.exe? Under C:\Program Files\Intel RealSense SDK 2.0\bin we provide x86 and x64 versions for both python 2.7 and 3.6.

At .../Intel RealSense SDK 2.0/bin/ I can find only /x64 and /x86 folders - I assume these are for python 2.7 and do not work for 3.6?
So there is no workaround and we have to build the library form source?

[Realsense Customer Engineering Team Comment]
Hi @LeMajors,
at https://github.com/IntelRealSense/librealsense/tree/development/wrappers/python
the latest windows installation session  mentioned
"Windows users can install the RealSense SDK 2.0 from the release tab to get pre-compiled binaries of the wrapper, for both x86 and x64 architectures. (Note that these binaries are built with Python 2.7, and cannot be import using Python 3)"
by the way, on your setup, even with the VC++ redistributable (X64) is installed, using Python 2.7 still not able to import the pre-compiled library?
or you have to use python 3 for some reason?
if that the case, please see if there still  issues when build the library from source
best

The D435 is part of a robot project that already has many thousands of lines of code. So I will not go back to 2.7.
As noob in terms of cmake I need some additional help.
What are the settings for cmake-gui (win10, 64Bit)?

Where is the source code: "C:/.../RealSense D435/librealsense-2.12.0/src" doesn't work. What's the correct path?
Where to build the binaries: I guess, it's up to me?
Where and how can I select the option "BUILD_PYTHON_BINDINGS"?

Kind regards, Marcus

[Realsense Customer Engineering Team Comment]
Hi @LeMajors
please find below for my inline comment
What are the settings for cmake-gui (win10, 64Bit)?

Where is the source code: "C:/.../RealSense D435/librealsense-2.12.0/src" doesn't work. What's the correct path?
[ww]
once you launch the cmake -gui
you should set the where the source code to C:/.../RealSense D435/librealsense-2.12.0/  (go one upper layer)

Where to build the binaries: I guess, it's up to me?
yes, it is up to you,
ex :C:/.../RealSense D435/librealsense-2.12.0/build/, the CMAKE will create the folder for you if not exist

Where and how can I select the option "BUILD_PYTHON_BINDINGS"?
once you set the directory right, the CMAKE will pop up the options list
then you need to check the BUILD_PYTHON_BINDINGS option

once checked, press configure button
and ensure the PYTHON EXCUTABLE is set to Python 3
ex :C:/Users/wangwill/AppData/Local/Programs/Python/Python36/python.exe
press generate button to generate the solution once completed you can press open project to launch the solution then build the library or sample code
under the build/release or build/debug folder, you should able to find realsense.dll and pyrealsense2.cp36-win_amd64.pyd which you need
you can copy both under C:\xxx\librealsensexxx\wrappers\python\examples\ and run the sample code to see if it work ex. python-tutorial-1-depth.py

Hi @RealSense-Customer-Engineering
thanks for your detailed informations.
Yes it's Win10, 64Bit, Intel Celeron CPU N3450.
When I set the two paths, there is no popup. Now I can just Add an Cache Entry (Name, Type, Value, Description) and Configure:

I tried all 3 choices "Visual Studio 15 2017", "Visual Studio 15 2017 Win64" , "Visual Studio 15 2017 ARM". All with this result:
Error in configuration process, project files may be invalid
The CMakeOutput.log says: "The system is: Windows - 10.0.17134 - AMD64" - but that's definitely not the case!?
What's wrong here?
Regards, Marcus

Hi @RealSense-Customer-Engineering
Yes, the files and folders are existing.
I also copied the folder to c:/ to shorten the path. To be sure I gave "everybody" full access to all files and folders. But It's the same result.

[Realsense Customer Engineering Team Comment]
Hi @LeMajors
please refer to below link for the Windows librealsense installation guide which has pictures which is easier to follow
https://github.com/IntelRealSense/librealsense/blob/development/doc/installation_windows.md

Ok, I came a little further...
After not seeing any options as in the screenshot, I reinstalled CMake.
Also I checked the properties of "CMakeLists.txt" - Windows said, it may be blocked because it comes from a different computer... I switched to "allow".
I guess, this was the main problem. Now he finds CMakeLists.txt because of this Error:
Generator
Visual Studio 15 2017 Win64 could not find any instance of Visual Studio.
So I reinstalled, but with no success. What I have installed is "Microsoft Visual C++ 2017 Redistributable (x64) - 14.14.26429".
Do I have to install something different?

[Realsense Customer Engineering Team Comment]
Hi @LeMajors
it looks something wrong about your VC installation
please find below link which has similar issue as you
https://github.com/Valloric/YouCompleteMe/issues/2945
The VC folder should be there. Are you sure you selected Desktop development with C++ in the Workloadstab during installation of Visual Studio 2017? Run again the vs_Community.exe installer, click Continue, wait for the products screen to appear, click on Modify under Visual Studio Community 2017, and check if Desktop development with C++ is selected under Windows. If not, select it then click on the Modify button to install it. Once it's done, leave the installer and run again the install.py script.

and do you mean i need to install vs2015 or vs 2013?

No, it should work fine with VS 2017.

weikent commented on Mar 12
It worked. Thank you for your help.
It is my fault, I don't select Desktop development with C++

@RealSense-Customer-Engineering - Thank you for the help and your patience!
To summarize the problems:

I had to allow access to the file "CMakeLists.txt" because it came from another computer.
The "Visual Studio Community 2017" has to be installed. (I assumed that the installation would range from "Microsoft Visual C ++ 2017 Redistributable (x64) - 14.14.26429").

So for me everything is fine now. If it's also working for @jasonjsong  we can now close this issue.

Working for me as well now!
My primary issue was installing Visual Studio Community 2017, thanks for all the help everyone!


Incoming Call Alert and Screenshot Capturing & Sharing

Dear Team
We are building a Video Calling Application for mobile app in React-Native and Web App in Angular 8. Everything is working fine, now we have a new requirement from our client.

If Web App is initiating a call towards mobile app, how can I alert the mobile app user for an Incoming Call like other Calling Apps like WhatsApp or Skype.
I want to capture the screenshot from mobile app and send it to Web App. How we can do this?

Any suggestions for this would be really helpful! Looking forward to your hear from you.
Thanks
Harikrishnan

I think u can build your own signal service on both native & web client. If you just have simple scenario such as chat, send picture in chat, you can try agora.io RTM services.

@Matrixbirds Can agoro.io RTM send messages while app is closed? I am using socket.io and it doesn't work when app is closed.

@AGC786 RTM can not send messages while the app is closed. you can use FCM.


variables and tables comparison broken for ApplicationService

the comparison of the variables and tables in the ApplicationService in the equality operator is broken when the length of the lists change:
https://github.com/f5devcentral/f5-cccl/blob/master/f5_cccl/resource/ltm/app_service.py#L62
        if not all(v in self._data['variables']
                   for v in other.data['variables']):

This comparison will fail when the other list is shorter than the self list.
This breaks the for example update using the k8s-bigipcontroller see https://github.com/F5Networks/k8s-bigip-ctlr/issues/1038

simple fix is to compare the length of the lists for equality first


New version: SteamTables v1.2.1

Registering package: SteamTables
Repository: https://github.com/braamvandyk/SteamTables.jl
Created by: @braamvandyk
Version: v1.2.1
Commit: 58bb8adeaf1bc7e35fd1b4e6ef88f8d2c129a536
Reviewed by: @braamvandyk
Reference: https://github.com/braamvandyk/SteamTables.jl/issues/10

@braamvandyk ^


"Unable to make progress running work" using 7.5-rc-3

I get an error similar to https://github.com/gradle/gradle/issues/20254 with 7.5-rc-3. To reproduce:
git clone https://github.com/apollographql/apollo-kotlin
cd apollo-kotlin
# checkout branch add-benchmark
git checkout 3f07a68671b6c8dc6784af744ef917a4edbb2bfd
./gradlew -p tests build

The build reaches 97% and then fails with:
Unable to make progress running work. The following items are queued for execution but none of them can be started:
  - Queued nodes for :
      - work action resolve metadata-service.json (project :multi-module-root) (state=SHOULD_RUN, dependencies=NOT_COMPLETE, group=finalizer in task group 0, successors=[:multi-module-root:generateServiceApolloSources])
      - :multi-module-child:generateServiceApolloSources (state=SHOULD_RUN, dependencies=NOT_COMPLETE, group=org.gradle.execution.plan.CompositeNodeGroup@39bfc497, successors=[:multi-module-child:checkApolloVersi
[...]

This started with 7.5-rc-1. 7.4.2 seems unaffected

This should be fixed now, via https://github.com/gradle/gradle/pull/21163


SPIKE: Find link sharing pattern for Airtable

Describe the issue
Airtable seems to allow a 1-time sharing of links to people.
Which Sprint Goal is this issue related to?

Note: 'Milestone' is a ZenHub term that we use synonymously with 'Sprint'.

The 'Milestone' description (created in ZenHub) should clearly list Sprint Goals. This section should indicate which 'goal' this issue is related to.
Additional context
Add any other context, attachments or screenshots
Definition of done

Investigate if a solution exists
Share with team

Not relevant anymore


Add more courses for Nepali Language

What does this PR do?
Add more Courses for Nepali Language
For resources
Description
Added more Courses for Nepali Language
Why is this valuable (or not)?
Added more Courses for Nepali Language
How do we know it's really free?
Its freely available on Youtube
For book lists, is it a book? For course lists, is it a course? etc.
It is a course
Checklist:

[* ] Read our contributing guidelines.
[ *] Search for duplicates.
[ *] Include author(s) and platform where appropriate.
[ *] Put lists in alphabetical order, correct spacing.
[ *] Add needed indications (PDF, access notes, under construction).
[ *] Used an informative name for this pull request.

Follow-up

Check the status of GitHub Actions and resolve any reported warnings!

For youtube, we prefer "playlist" links and the name of the producer/creator. docs/CONTRIBUTING.md#platforms-and-access-notes
NO SHORTENED LINKS!

For youtube, we prefer "playlist" links and the name of the producer/creator. docs/CONTRIBUTING.md#platforms-and-access-notes NO SHORTENED LINKS!

The Videos included are more than a hour long and are in Nepali Language.


CHAOS-4246 Update iam integration doc

Update IAM integration doc

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step behind the Harness VPN and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app. Current Draft URL is: https://65d863d75405aec73261e000--harness-developer.netlify.app


[type] Ignore attr defined

This was a 3.6 specific mypy complaint

We bypassed zuul to save time on this as we knew it was correct and wanted to avoid the rebase.


setCursor doesn't work well with inputStyle: "contenteditable",

Hi,
When I try to do editor.setCursor({line: 0, ch: 2}) with inputStyle: "contenteditable", setting, the cursor doesn't change this position but this work fine with inputStyle: "editor",.
I'm looking to make a fix/pr, if you have advice about fixing this issue, please feel free to comment.
Example with demo/abc.html :
<!doctype html>

<title>CodeMirror: Any Word Completion Demo</title>
<meta charset="utf-8"/>
<link rel=stylesheet href="../doc/docs.css">

<link rel="stylesheet" href="../lib/codemirror.css">
<link rel="stylesheet" href="../addon/hint/show-hint.css">

CodeMirror

Home

Manual

Code

Any Word Completion

Native Spellchecker Demo

<form><textarea id="code" name="code">
Native abc tesst
</textarea></form>

(External linked issue : https://github.com/Ionaru/easy-markdown-editor/issues/160 & https://github.com/zestedesavoir/zds-site/issues/5652)

Works for me in Chrome and Firefox (but since the code you show doesn't call setCursor, I can't be sure that I'm doing the same things that you're doing).

Works for me in Chrome and Firefox (but since the code you show doesn't call setCursor, I can't be sure that I'm doing the same things that you're doing).

In your webconsole, when you try .setCursor, the cursor will don't move

Native Spellchecker Demo

Codemirror uses Codemirror.inputStyle: `contenteditable` with spellcheck: true.

<form><textarea id="code" name="code">
Native abc tesst
</textarea></form>
<form><textarea id="code2" name="code2">
No abc, textareaInput
</textarea></form>

editor.setSelection({line:0, ch:2}, {line:0, ch:5}) doesn't work :

editor2.setSelection({line:0, ch:2}, {line:0, ch:5}) works :

Looking for the bug
In dom.js, I add log and trace in range function because it calls the native/browser function to selection the text, I got (line 40):
if (document.createRange) range = function(node, start, end, endNode) {
  console.log("RANGE:")
  console.log(node, start, end, endNode)
  console.trace()
  let r = document.createRange()
  r.setEnd(endNode || node, end)
  r.setStart(node, start)
  return r
}

Output for: editor.setSelection(...)

If my editor (CM) does not have the focus, editor.setSelection will work if I use editor.focus() after.

I try to set the focus out with code: document.getElementsByTagName('A')[0].focus() and use editor.setSelection after, this will don't work.
Output for 2. focus out before setSelection()

If my editor (CM) does not have the focus, editor.setSelection will work if I use editor.focus() after.

editor.setSelection({line:0, ch:2}, {line:0, ch:5})
Output RANGE: "Native" 5 6 undefined

console.trace (click to open)
range @ codemirror.js:90
measureCharInner @ codemirror.js:2493
measureCharPrepared @ codemirror.js:2423
get @ codemirror.js:2654
cursorCoords @ codemirror.js:2666
scrollPosIntoView @ codemirror.js:3436
endOperation_finish @ codemirror.js:3891
endOperations @ codemirror.js:3810
(anonymous) @ codemirror.js:3793
finishOperation @ codemirror.js:2053
endOperation @ codemirror.js:3790
(anonymous) @ codemirror.js:3946
(anonymous) @ codemirror.js:9707
(anonymous) @ VM1819:1

editor.setSelection({line:0, ch:2}, {line:0, ch:5})
Output RANGE: "Native" 2 5 "Native"

console.trace (click to open)
range @ codemirror.js:90
ContentEditableInput.showPrimarySelection @ codemirror.js:8858
ContentEditableInput.showSelection @ codemirror.js:8818
ContentEditableInput.focus @ codemirror.js:8909
focus @ codemirror.js:8210
(anonymous) @ VM1826:1

Looking how .focus() work
https://github.com/codemirror/CodeMirror/blob/28568ba037146b2d13857849650db94b8ec09385/src/input/ContentEditableInput.js#L196-L202
When I comment if (!this.selectionInEditor()), focus will refresh selection each time and getSelection on 1. or 2. will work if I do .focus() after.
Now, I think I know why editor2.getSelection work and not editor.getSelection, it seem showSelection is never called with editor.getSelection.
Looking in the refresh/render function after a change
Ok...
This is the render loop:
https://github.com/codemirror/CodeMirror/blob/28568ba037146b2d13857849650db94b8ec09385/src/display/operations.js#L56-L68
showSelection (I mean cm.display.input.showSelection to his closest friends) is called in endOperation_W2 if op.selectionChanged is true.
https://github.com/codemirror/CodeMirror/blob/28568ba037146b2d13857849650db94b8ec09385/src/display/operations.js#L119-L120
In endOperation_R2 function :
https://github.com/codemirror/CodeMirror/blob/28568ba037146b2d13857849650db94b8ec09385/src/display/operations.js#L104-L105
op.selectionChanged is defined in startOperation:
https://github.com/codemirror/CodeMirror/blob/28568ba037146b2d13857849650db94b8ec09385/src/display/operations.js#L23-L42
Next step
I have to understand why startOperation is not called or why startOperation is called with selectionChanged is false.
Hack for my code (temporary solution)
Now I understand their is a hack (temporary solution) for my code:
editor.setSelection({line:0, ch:2}, {line:0, ch:5})
editor.display.input.showSelection(editor.display.input.prepareSelection(), true)

Not usefull
3rd looking
I saw on my last looking that selectionChanged is not true, I will looking why looking the tree of setCursor and setSelection
Looking of setSelection declaration
https://github.com/codemirror/CodeMirror/blob/28568ba037146b2d13857849650db94b8ec09385/src/model/Doc.js#L119-L124
Looking where setSimpleSelection is set...
https://github.com/codemirror/CodeMirror/blob/28568ba037146b2d13857849650db94b8ec09385/src/model/Doc.js#L20
setSimpleSelection is set in "./selection_updates.js".
https://github.com/codemirror/CodeMirror/blob/28568ba037146b2d13857849650db94b8ec09385/src/model/selection_updates.js#L95-L99
selectionChanged is always true after setSelection, checked with : console.log(doc.cm ? doc.cm.curOp.selectionChanged : 'nop')

I have to understand why startOperation is not called or why startOperation is called with selectionChanged is false.

Ok... I did a mistake, I forget to watch the value of selectionChanged (I thought I did it).
showSelection doesn't work when takeFocus is false. 😕
editor.setSelection({line:0, ch:2}, {line:0, ch:5}) works fine if I replace takeFocus by true.
Caused by: https://github.com/codemirror/CodeMirror/commit/b9e0c4cd0bab86a440cb10e3505bd6691bb0f001  linked to #3979 in #9 (https://github.com/notepadqq/CodeMirror/pull/9/commits/b9e0c4cd0bab86a440cb10e3505bd6691bb0f001)

The condition op.focus == activeElt() seems that it will be always false because op.focus is boolean and activeElt() returns an HTMLElement.
HTMLElement == true
false
HTMLElement == false
false
document.body == true
false
document.body == false
false

activeElt() always return an HTMLElement.
https://github.com/codemirror/CodeMirror/blob/28568ba037146b2d13857849650db94b8ec09385/src/util/dom.js#L67-L80
I think this code is not necessary, because it is already tested in L110 in showSelection:
https://github.com/codemirror/CodeMirror/blob/28568ba037146b2d13857849650db94b8ec09385/src/input/ContentEditableInput.js#L108-L112

Ah, right, the issue only occurs when the editor has focus within the window, but the window doesn't itself have focus.
I looked at your patch but I think there's a much less invasive way to fix this. See attached patch. Does that work for you?

My change is invasive but needed and it doesn't make depreciation and don't not changz the behavior.
I need to test but in first looking (i just reviewed not test), that doesn't sound perfect with no-focus. Without calling showPrimarySelection the selection will be not processing because the selection can appear without focus.

I'd prefer that you actually test. It can be painful to give up one's patch, but I really much prefer the low-impact version of the fix.

I try with:

abc.html (click to open)
<!doctype html>

<title>CodeMirror: Native Spellchecker Demo</title>
<meta charset="utf-8"/>
<link rel=stylesheet href="../doc/docs.css">

<link rel="stylesheet" href="../lib/codemirror.css">
<link rel="stylesheet" href="../addon/hint/show-hint.css">

CodeMirror

Home

Manual

Code

Native Spellchecker Demo

Native Spellchecker Demo

This editor uses Codemirror.inputStyle: 'contenteditable' and spellcheck: true.

<form><textarea id="code" name="code">
Native abc tesst with contenteditableInput editor
</textarea></form>

Default Editor Mode

The native spellchecker (of the browser) does not run with Codemirror.inputStyle: 'textarea' (default value).

<form><textarea id="code2" name="code2">
No spellchecker in a textareaInput editor
</textarea></form>

Like I say, in contenteditableInput the selection appear only when the textarea have focus but in textareaInput the selection always appear (with or without focus). I think you would the same behavior depending of the Style.

(I got a bug, editor2.focus() seem to not work, I mean I can't write directly)

Like I say, in contenteditableInput the selection appear only when the textarea have focus

That's just how the native selection works, so it is kind of implied in the decision to use the native selection.

Can you publish your change on npm ?

CodeMirror uses a monthly release cycle. There'll be a new release around the 20th of the month.

You don't use tag to publish beta ? https://medium.com/@kevinkreuzer/publishing-a-beta-or-alpha-version-to-npm-46035b630dd7
I got an error with yarn install when I did : "codemirror": "file:../codemirror/" in my dependency of my code :/

@marijnh I tried your code on master of Easymde: My change works fine, your change seem to doesn't work, I let you try:

zds.html (click to open)
<!DOCTYPE html>

  <meta charset="UTF-8">
  <meta name="viewport" content="width=device-width, initial-scale=1.0">
  <meta http-equiv="X-UA-Compatible" content="ie=edge">
  <title>Example / Preview</title>
  <link rel="stylesheet" href="../dist/easymde.min.css">

  <textarea id="myText"></textarea>

My change (PR #6168) :

Your commit/master branch :
I add a color change, to show you that it is been the last version of codemirror in git (not the old one).

On my PR, i did 4 commits :

Each commit is one step, you can try each commit step by step.

f0eccc8e3e24e5220d5f26b4d6fca12fa1bbb903 don't change the behavior for user, I explained why, here. It is only code review to delete unused code.
c8f0a0e4a79dae7d5b81e0e3a3c410f0c122fdf4 Demo page for documentation if people want to try (I can remove this commit if you want).
8c07543296063051d9c48c0d8e1968af1ea0a5b4 My fix.
a2a32984771c232773159a6dca8ba92e58f00972 A new setting (I can remove this commit if you want).

(If my change need to be enabled with option tell me I will make this changes).

It is only code review to delete unused code.

That isn't actually unused code. The focus field in an operation will hold false or a DOM node.
Your fix seems to unconditionally mess with the DOM selection, which is not a good idea (when the user doesn't have the editor focused, but for some reason its content is changed, that'll disrupt the selection).
So, again, I don't want to merge these changes.
Running just CodeMirror, without any external code, I can really verify that the problem is gone with my patch. If can set up a demo without your codebase that still shows the problem, let me know, but for now I'm closing this.

But in textareaInput this work fine...

Running just CodeMirror, without any external code, I can really verify that the problem is gone with my patch. If can set up a demo without your codebase that still shows the problem, let me know, but for now I'm closing this.

Please, I didn't finish yet, can you reopen ? I can prove without easymde (I wanted to save some time with remaking an an existing script). I will don't speak again of easymde, here.
Why I'm sure ?

The behavior of contenteditableInput and textareaInput is different ;
I take time to read your code, watch how it work ;
The selection is not processed when we have no focus in contenteditableInput.

My example with only codemirror:
var editor = CodeMirror.fromTextArea(document.getElementById('code'), {
  inputStyle: 'contenteditable',
  spellcheck: true
})

document.getElementById('icanproveit').addEventListener('click', function () {
  const cm = editor;
  const startPoint = cm.getCursor('start');
  const endPoint = cm.getCursor('end');
  cm.replaceSelection('**' + cm.getSelection() + '**');
  startPoint.ch += 2;
  endPoint.ch += 2;
  cm.setSelection(startPoint, endPoint)
  cm.focus();
})

My full page to test:

zds.html (click to open)
<!doctype html>

<title>CodeMirror: Native Spellchecker Demo</title>
<meta charset="utf-8"/>
<link rel=stylesheet href="../doc/docs.css">

<link rel="stylesheet" href="../lib/codemirror.css">
<link rel="stylesheet" href="../addon/hint/show-hint.css">

CodeMirror

Home

Manual

Code

Native Spellchecker Demo

Native Spellchecker Demo

This editor uses Codemirror.inputStyle: 'contenteditable' and spellcheck: true.

<input type="button" id="icanproveit" value="ok" />
<form><textarea id="code" name="code">
Native abc tesst with contenteditableInput editor
</textarea></form>

Default Editor Mode

The native spellchecker (of the browser) does not run with Codemirror.inputStyle: 'textarea' (default value).

<input type="button" id="icanproveit2" value="ok" />
<form><textarea id="code2" name="code2">
No spellchecker in a textareaInput editor
</textarea></form>

Result:

I see—that's a different issue from the one before, though. Attached patch seems to help with that.

This work fine thanks you!


Column names remains static

Once table is created, drop and create is not updating column names with new copy book details.
Details:
when creating a new table and does a describe on it.. its showing the table layout of the previous table.. set cobol.hive.mapping, this is also showing old layout(created using previous cobol copy book).
when creating external table A that points to copybook A, that works fine. But when creating another external table B pointing to another copybook B in a different location, the original table A structure has been replace with table B. Now Table A and B is having the same structure.

Code has been updated. Try new jar.

Hi Ram,
Where can i get the jar which is updated with this issue.
Regards,
Sandeep


Cross-platform win32-input-mode usage

Description of the new feature/enhancement
By creating this issue, I would like to start a public discussion about what could be changed in the current design of the win32-input-mode protocol before it becomes widespread and cross-platform.
The Considerations section states:
https://github.com/microsoft/terminal/blob/612b00cd445470fa85d2f71dc94930f03ebe4823/doc/specs/%234999 - Improved keyboard handling in Conpty.md?plain=1#L60-L62
At the same time, the section Future Considerations allows cross-platform use:
https://github.com/microsoft/terminal/blob/612b00cd445470fa85d2f71dc94930f03ebe4823/doc/specs/%234999 - Improved keyboard handling in Conpty.md?plain=1#L411-L416
Improvements
List of possible improvements, issues and use cases not covered by this keyboard protocol:

No way to restore the normal mode of the terminal when the connection is lost or the application crashes.
https://github.com/microsoft/terminal/issues/8343#issuecomment-1586225095

Support win32-input-mode request acknowledgment with the current state of keyboard modifiers.

Req: ^[[?9001h
Ack: ^[[0;0;0;0;CtrlState;0_

Support for LeftShift and RightShift modifiers along with Shift.

Support for Unicode codepoint decimal value (for BaseCharacter) instead of UnicodeChar (Uc), which currently represents one UTF-16 code unit (wchar_t).
^[[Vk;Sc;Uc;Kd;Cs;Rc_ => ^[[Vk;Sc;BaseCharacter;Kd;Cs;Rc_

Support for passing/receiving an entire grapheme cluster as one keyboard event in order to get it by a single ReadKey call, e.g. getting an accented letter á represented as a sequence of codepoints. (GC = BaseCharacter + Codepoint1 + Cp2 + … + CpN).
#2853
https://github.com/microsoft/terminal/issues/8343#issuecomment-1586225095
https://github.com/microsoft/terminal/issues/8343#issuecomment-1586288563
Possible solution:

Add continuing codepoints as optional arguments to the event sequence:
^[[Vk;Sc;BaseCharacter;Kd;Cs;Rc [ ; Codepoint1 ; Cp2 ; … ; CpN ] _

Sending clipboard data without additional generation of keystroke sequence, since this data must already be enclosed (mandatory bracketed paste mode).

Example
When the user presses in the console

...
Press Key1
Release Key1
Press á
Release á
Press 🏴☠
Release 🏴☠
Press Ctrl
Press Key2
Release Key2
Release Ctrl
...
Paste from clipboard by mouse right click
...
Press F5
Release F5
...

Note: 🏴☠ = U+1F3F4 Black Flag + U+200D ZWJ + U+2620 Skull and Crossbones + U+FE0F VS16
The input stream would look like the following:
...
^[[x;x;x;pressed;0;1_
^[[x;x;x;released;0;1_
^[[x;x;65;pressed;0;1;769_
^[[x;x;65;released;0;1;769_
^[[x;x;127988;pressed;0;1;8205;9760;65039_
^[[x;x;127988;released;0;1;8205;9760;65039_
^[[17;29;0;1;8;1_
^[[x;x;x;pressed;8;1_
^[[x;x;x;released;8;1_
^[[17;29;0;0;0;1_
...
^[[200~ clipboard_utf-8_raw_data ^[[201~
...
^[[116;114;0;1;0;1_
^[[116;114;0;0;0;1_
...

No way to restore the normal mode of the terminal when the connection is lost or the application crashes.

This is a general problem that can apply to a lot of terminal states. Some of them you could potentially recover from by blindly typing reset in a WSL shell, or echoing an appropriate escape sequence, but that's not a realistic solution for most users. We need something like a Reset Terminal action that'll allow the user to easily recover from any messed up state - not just this one particular keyboard protocol.
This is a fairly common feature in terminal emulators, and I could have sworn we already had an issue for it, but I can't find it now. It's possible it was just something that was discussed in an unrelated issue, but we definitely should open an issue for it if there isn't one.

No way to get an entire grapheme cluster via single read key call, i.e. get accented a-letter á that represented as a codepoint sequence.

But the win32-input-mode is a direct representation of the key events we receive. If there was keyboard that allowed you to enter grapheme clusters, that would have to be in the form of multiple key events, and this is something that applications would already be expected to handle. Same goes for any characters outside the BMP for that matter - they're going to appear as two separate key events to represent the surrogate pair. We can't report a UTF-8 representation for combined events that we haven't received yet.

I believe that it is necessary to avoid unreasonable fragmentation of the grapheme cluster for the following reason.
The application must be able to compose codepoints into clusters. At the same time, it should mark how the cluster was composed. In the general case, it makes sense to distinguish a grapheme cluster assembled with several keystrokes from a grapheme cluster generated with one keystroke, since when deleting it with Backspace, in the first case, the codepoints will have to be deleted one-by-one, in the second, the whole cluster at a time. By using the Del key in both cases, we can delete the entire cluster.
For example, a user can compose a cluster by typing codepoint by codepoint using Alt+Num, and in the process correct errors using Backspace. Also, the user can use IME with one keystroke to get a complex cluster, and delete it with Backspace also in one keystroke.

In a scenario where the terminal does not support win32-input-mode, the application falls into an undefined state. It has received the cluster and is waiting for the win32-input sequence. Oops.
It turns out that it is possible to transfer a complete cluster as one event only by adding optional continuing codepoints as additional arguments to the event sequence.
^[[Vk;Sc;BaseCharacter;Kd;Cs;Rc [ ; Codepoint1 ; Cp2 ; … ; CpN ] _

Closing this issue in favor of kvm-input-mode protocol (backward compatible with win32-input-mode).

For example, a user can compose a cluster by typing codepoint by codepoint using Alt+Num, and in the process correct errors using Backspace. Also, the user can use IME with one keystroke to get a complex cluster, and delete it with Backspace also in one keystroke.

Assuming this was possible, what happens when your editor saves these two different clusters to disk and later reloads them? Now there's no way to distinguish between the two, and a backspace would work in exactly the same way for both of them. To a user, the backspace behavior would just seem random.
I really cannot imagine an editor going to all that effort, when it's just going to cause confusion. If anything, it might make sense to backspace over the entire cluster with one keystroke in all cases, regardless of how the cluster was entered. That at least would be consistent.

It would be important for me here to clarify that we are talking only about the current open cluster in which code points are currently being added.

Then I don't understand why you'd need to tell the difference between a cluster entered as a single keystroke and one entered with multiple keystrokes. If the keyboard protocol splits a cluster into multiple keystrokes, the final keystroke would assumedly close the cluster, so it's still going to immediately become atomic isn't it?

The last entered cluster must be kept open, since it is not known whether an additional joiner will arrive or not, for example, with a skin tone modifier.

User can manually construct a grapheme cluster of any length they want by stringing together multiple zero-width joiners.

We seem to be going in circles here. I refer you back to my comment here: https://github.com/microsoft/terminal/issues/8343#issuecomment-1588876569
I understand what you're suggesting - I just don't think it's a very good idea. That's just my opinion.

it might make sense to backspace over the entire cluster with one keystroke in all cases, regardless of how the cluster was entered.

For example GitHub web interface allows you to ZWJ+codepoint-by-ZWJ+codepoint backspace a complex cluster. Try to backspace the following cluster 🏴☠. I am using FF as my desktop browser. It may behave differently in other browsers. Windows Notepad and Notepad++ allows you to backspace codepoint-by-codepoint.

 This does not apply to rare emoji. It seems to me when using a Devanagari-like writing system with complex clusters in each syllable, this is critical.

This seems like something I'd want to configure in my editor though. Sometimes I might prefer backspacing over individual parts of a cluster, and sometimes I might prefer deleting the entire thing with a single backspace. That should be my choice to make, so I know it's going to work exactly the way I expect. I definitely wouldn't want the behavior randomly changing depending on which IME I happened to use, and then potentially changing again when I reload the content from disk.

I agree that disputes about what atomic or piecewise grapheme clusters should be is a matter of settings. But that's not the point.
I am based on the assumption that a certain operating system can output an entire cluster at a single keystroke, and I consider it fundamentally wrong to split it into a sequence of distinct keypresses and releases, as required by the current win32-input-mode implementation.

I consider it fundamentally wrong to split it into a sequence of distinct keypresses and releases

I sympathise with that viewpoint, but from my understanding of your proposed protocol, you're just creating more work for app devs. They already have to accept a cluster split into distinct keypresses, but now they also have to check for additional parameters at the end of the sequence that might be continuing codepoints. So unless there is some value to them in distinguishing between the two, it's just bunch of extra work for nothing.
Also, if an app has already been designed to work with win32-input-mode, they're not going to be expecting those continuing codepoints, so they'd lose half of the cluster. That is not what I would consider backwards compatible. So if you want to extend the protocol like this, I'd encourage you to use a different mode number.
The additional viewport and mouse stuff is an even bigger issue, but I don't want to get into a discussion about protocol design. As long as it's a separate mode that an application has specifically requested, you can do whatever you want.

Also, if an app has already been designed to work with win32-input-mode, they're not going to be expecting those continuing codepoints

I adapt the protocol model in case of undefined behavior of existing win32-input-mode-aware applications.

It also seems to me that using the win32-input-mode protocol, it is quite difficult to determine two simultaneously pressed buttons if at least one of them generates a complex cluster. What should the incoming stream look like for á + 🏴☠? Eight (powered by surrogate pairs?), six or two keys pressed and released?

What about auto-repeat keys? It also seems to be difficult to distinguish an auto-generated key event between the original press and release.

The additional viewport and mouse stuff is an even bigger issue, but I don't want to get into a discussion about protocol design.

To be honest, this is strange to me. A couple of remarks on this subject, if you will, without continuing the discussion.
I haven't seen a command shell whose prompt didn't get corrupted when the terminal window is resized. The secret is that after resizing, the shell loses all coordinate reference points: cursor coordinates, sizes of scrollable fields, etc. And the solution is almost on the table. First: The shell does not get the size of the window synchronously. Second The shell does not receive information about what else has changed after the resize.
Let's send the window size to the application synchronously and what we see:
Note: The Calc app is a standalone external TUI app that just receives window size synchronously instead of SIGWINCH.
https://github.com/microsoft/terminal/assets/11535558/c56c6565-7c85-4d79-9d43-6161fba9bebe
Let's update the coordinate reference points for the application after window resize and what we see:
Note: cmd.exe as a standalone TUI application, and they don't loose their prompt after terminal window resize!
https://github.com/microsoft/terminal/assets/11535558/909598a6-9f5d-4139-9063-4965203abf1c


PR : Accessibility - custom improvement - allow badge text color customisation

Fixes #22062 - as proposed, allow badge text color customisation for accessibility purpose

This looks conceptually good to me. @mdo ?

okay with @mdo waiting for the PR https://github.com/twbs/bootstrap/pull/22551 I will close this one


Remove duplicated package.json

https://github.com/maplibre/maplibre-gl-native/blob/main/package.json
https://github.com/maplibre/maplibre-gl-native/blob/main/platform/ios/package.json
These are almost the same and should be deduplicated. Need to check if the second one is still being used.

The js scripts we have are mainly for pulling in render tests and shaders from maplibre-gl-native. It's mainly the package.json in the root along with the files in /scripts that are in use. Many of the files in /scripts needs to be updated from es5 to typescript so they can be run with ts-node - they are not working currently because they require() a lot of packages that are only built as es modules, so they need import/export syntax instead.

I think the iOS one is just an outdated version of the other one.


Use identity with the restrictive instantation to detect nongenric instances and disable variance probing on nongeneric instances

Previously @ahejlsberg had mentioned disabling variance probing for generic mapped types - that's not good enough. In the examples given by, eg varianceProblingAndZeroOrderIndexSignatureRelationsAlign (which come from user code - see #29817), the mapped types are within something else which we're still doing variance calculations for. The real "heuristic" as it were, is simply that if we know we're not relating generic types, then we should compare structurally rather than with variances (since we know the structural comparison will yield the correct result and likely be more permissive than any pessimistic higher order relationship may have been). Since we can't directly check if a type still contains generics or not, I proxy the check by seeing if the restrictive instantiation of the type and the type itself are identical. If they are, then either A. we're looking at a restrictive instantiation of a type, or B. we're looking at a type which is unaffected by instantiation of all generics in it (so contains no generics). Skipping generic variances for restrictive instantiations seems fine, since the goal with those is to measure without constraints anyway. If that was for some reason undesirable, a different unique instantiation could be used in the same vein as the restrictive instantiation.

cc @ahejlsberg this was the PR for the thing I was just talking to you about.
@typescript-bot test this & @typescript-bot run dt

@typescript-bot test this & @typescript-bot run dt

Note from DT: In its current state, this should fix the failure in @types/jasmine. (That's where the test case nongenericPartialInstantiationsRelatedInBothDirections.ts comes from.)

@typescript-bot test this & @typescript-bot run dt

@typescript-bot test this

This undoes the pair of RWC errors introduced by the merge of #29817, so the RWC diff looks pretty good to me.

This undoes the pair of RWC errors introduced by the merge of #29817, so the RWC diff looks pretty good to me.

I looked at the DT diff. Most of the ember errors are gone, so I guess that the ones remaining have strictFunctionTypes: true. Jasmine is also fixed. However, the process ran out of memory before finishing, so I'm not sure it finished yargs successfully.
Worse, mithril overflows the stack now. You should probably take a look.

@typescript-bot test this & @typescript-bot run dt

Remaining DT changes just look to be some minor changes in ember that @sandersn already has a PR up on DT to fix, so this looks good now ❤

After some soul searching on how to best fix the depth crash found via specced, i swapped from using the restrictive instantiation to the permissive instantiation as an identity target - both map all type parameters, but since permissive maps type parameters into wildcard, repeated instantiations don't chain (and the wildcard type often bails out of identity checking way faster than a type parameter when it doesn't match as an added bonus).

@typescript-bot test this & @typescript-bot run dt

The DT run is all clean except for the remaining ember failures, which I have a fix for, and another project URL change, which I just updated.

Is the project url failure just only reporting one failure at a time or something?

@weswigham That is unlikely because dtslint issues the error, and it's being run in parallel by dtslint-runner.
It's much more likely that of the 5200+ npm packages that DT tracks, one or two per day change their urls.

Update from #30133: Reverting the invariance of conditional types shows that this PR still fixes errors in

jasmine (which is a test case of this PR)
ember and ember__object

I'm not sure of the exact cause of ember's problem, but it's still going through their UnwrapComputedPropertyGetters conditional type.
However, spected, mithril and yargs no longer error on master, so this PR doesn't need to address those errors.

@typescript-bot run dt


Initial standalone components and new feature-flag Root Page

This PR has changed to include the following:

Adds a shared-standalone-component-lib directory that is meant to mirror the shared directory.
Renames feature/feature-flags to feature/feature-flags-legacy.
Adds back feature-flags dir, now as the new feature flag feature dir
Adds a component playground app with references to the standalone library so elements can be quickly imported into there and developed / demo'd in isolation.
Adds a new Common Root Page presentational layout component.
Adds a new Feature Flag Root Page instance of that Common Root Page.
Points the feature-flags nav link to this component, which does lazy-loading with loadComponent rather than loadChildren.

This also contains draft code for Common Section Card List, Common Section Card List, and some demo Section Card usage in the Feature Flag Root Page to demonstrate the way this will work. I've left it in for the next person to pick up and complete.

@VivekFitkariwala please see updated code, that mat-dialog example wasn't the best example, I've done a common-section-card instead which is much more straightforward I think

ok I made some changes based on our conversations, and have gotten it working correctly I think for styles-scoping and material element imports.
@zackcl @ppratikcr7 please take a fresh look. I plan on providing some documentation in here, but otherwise I'm not planning other changes, I think it's ready to go.
Note that all old feature flag files and old feature flag named exports were named _LEGACY so that we can avoid confusion with old stuff and don't run into naming conflicts, until we know those pieces are not worth keeping around and can be safely deleted. The src/app/core/feature-flag directory was simply duplicated at this point; we can reuse these files and scrape out the outdated stuff, but that's enough changes for one PR, that can come later.

@danoswaltCL I have a small comment, rest looks good. I just need a working example of one component that can be seen properly in component playground to confirm that playground works good,  but yeah its not required for pending approval of this PR. I can still approve this PR.

@danoswaltCL I have a small comment, rest looks good. I just need a working example of one component that can be seen properly in component playground to confirm that playground works good, but yeah its not required for pending approval of this PR. I can still approve this PR.

Yup, let me fire this back up today, I have an idea to make this clearer.

converted to draft to save as a sketch, will open new PR with just the changes needed for the root page + root page header

I don't think there's anything to use from here anymore, closing


⚠ Bofrost.ch has degraded performance

In 59dba07, Bofrost.ch (https://www.bofrost.ch) experienced degraded performance:

HTTP code: 200
Response time: 2024 ms

Resolved: Bofrost.ch performance has improved in 1e994a2 after 8 minutes.


Add a convenience method that runs both RB and XEB

gpylint run with pyle configuration found following docstring issues.
I think it is worthwhile to fix them so we have a complete info from pydoc or if this gets rendered in web docs, WDYT?
************* File cirq-core/cirq/experiments/two_qubit_xeb.py
cirq-core/cirq/experiments/two_qubit_xeb.py:1:0: missing-module-docstring
cirq-core/cirq/experiments/two_qubit_xeb.py:71:0: g-doc-return-or-yield
cirq-core/cirq/experiments/two_qubit_xeb.py:99:0: g-doc-return-or-yield
cirq-core/cirq/experiments/two_qubit_xeb.py:149:0: g-short-docstring-punctuation
cirq-core/cirq/experiments/two_qubit_xeb.py:149:0: g-doc-return-or-yield
cirq-core/cirq/experiments/two_qubit_xeb.py:242:0: g-doc-return-or-yield
cirq-core/cirq/experiments/two_qubit_xeb.py:271:0: g-doc-args
cirq-core/cirq/experiments/two_qubit_xeb.py:272:0: g-doc-return-or-yield

@pavoljuhas I completed the missing docstrings with the help of an LLM :D. ptal

@pavoljuhas I completed the missing docstrings with the help of an LLM :D. ptal

Looks good!  :-o
There is one last thing about changing the default value of the random_state argument to None, otherwise LGTM.


Allow #if in function builders.

Dropping the IfConfigDecl is not a great implementation, but it'll work well enough to unblock this code while we work to allow multi-statement bodies in general.
rdar://50710698

@swift-ci Please test.


What to be aware of when disabling cleanupOutdatedCaches?

I've seen @userquin and the docs say to be careful when setting cleanupOutdatedCaches to false. Why? What should we be aware of?

Background: we ran into an issue somewhat like #177 causing blank screens and we found that keeping the old files on the server was the only way to fix it. This is very awkwardly accomplished by keeping the assets in a separate GitHub repository. Now we've ran into a size limit so we've had to start deleting the oldest of those assets and we're concerned that infrequent users will run into this issue again (we do a lot of deploys). So, I'm glad we don't need to do this if we set cleanupOutdatedCaches to false instead.

@adam-lynch

using cleanupOutdatedCaches has the problem of a hard refresh on client side, we're using stale while revalidate strategy (html pages on cache with old assets versions, missing from server), so if there is a new version app will stop working (404; deploy a new app version will remove old assets from server) https://developer.chrome.com/docs/workbox/modules/workbox-precaching/#clean-up-old-precaches
if you don't use cleanupOutdatedCaches, you will end  up with storage quota problems, it will depend on app size

Thanks @userquin. From that link:

This obsolete data shouldn't interfere with normal operations, but it does contribute towards your overall storage quota usage, and it can be friendlier to your users to explicitly delete it. You can do this by adding cleanupOutdatedCaches() to your service worker, or setting cleanupOutdatedCaches: true if you're using one of Workbox's build tools to generate your service worker.

What happens when the limit is reached? I would've assumed that the oldest files will be evicted from cache to make space, but I'm not sure now.

@adam-lynch in theory, workbox-build will try to update changed assets, if the quota is reached, browser can remove assets without any logic, so beware assuming what resources/assets will be evicted.
https://developer.chrome.com/docs/workbox/understanding-storage-quota/
https://love2dev.com/blog/what-is-the-service-worker-cache-storage-limit/

on quota error the sw will no install/activate the new sw and so your new app version (or maybe unpredictable behavior, it will depend on user agent and/or OS): you should also deal with it, maybe adding error callback and showing a message/toast as suggested in preview comment (first link).
https://web.dev/storage-for-the-web/#how-much

Thanks for this, v helpful. I assume I'll need to switch to injectManifest to add an expiration plugin / custom expiration logic.

maybe adding error callback and showing a message/toast as suggested in preview comment (first link).

I don't understand, which article you're referring to?

upps sorry, it was here https://web.dev/i18n/en/storage-for-the-web/#over-quota

check this: https://github.com/vitest-dev/vitest/blob/main/docs/vite.config.ts#L86
Beware with opaque responses (CORS)

It looks like immutable may have fixed my issue so I don't need to do this.
I did yet another review of our headers and found:

index.html and sw.js were being cached. I updated those to no-cache. I don't think this caused any real issue 🤔
WASM files had an incorrect Content-Type. I don't think this had any real effect.
I changed /assets/**'s Cache-Control header from public, max-age=31536000 to public, max-age=31536000, immutable.

Now, I can't make the issue happen no matter what I try.
Maybe it could still happen in some browsers (e.g. iOS Safari wouldn't surprise me), so to be safe if our React app doesn't mount, I delete the entire cache in cache storage that the service worker, unregister all service workers, and reloads. (The code for this is just in a <script>...</script> in the index.html)
Also, I'm not going to remove the old assets (before this point in time) for a while because when users requested them, they were not immutable (even though if they are now).

Beware with opaque responses (CORS)

I reviewed our cache storage and it looks fine, thanks.

@adam-lynch I'm adding a new entry in deploy  section https://github.com/vite-pwa/docs/pull/19

@adam-lynch can this be closed?

yeah


tekton-ci: unlink quay-push-konflux-ci secret

After b1ce8f527d607725f3a9ae062873166354567bcf, the tekton-ci namespace contains two dockercfg secrets for quay.io authentication (both linked to the appstudio-pipeline SA). One of them has permissions for the redhat-appstudio org, the other one for the konflux-ci org. But since both of them contain auth for "quay.io", when the secrets get merged to produce the final auth file, only one of them wins. Given that our CI has lost permissions for pushing to the redhat-appstudio org, it seems that konflux-ci wins.

Failing CI example: https://github.com/redhat-appstudio/build-service/pull/251/checks?check_run_id=22424496254


add support for tsv files to datatables viewer

closes: https://github.com/antleaf/nims-mdr-development/issues/320

@Steven-Eardley had to loosen up the TSV detection.  Should still be pretty minimal false positive chance, but is much more likely to identify a file as tab delineated now.


Check the nccl version compatibility

The nccl.h now is picked up from the repo even when the system has a NCCL library installed. The version is dynamically checked at runtime.

Thanks for doing this. I'm assuming you've tested on my GCP machine to ensure it gets the correct header?

Yes I did.


Not compatiable with jQuery handler function

Documentation Is:

[ ] Missing
[ ] Needed
[ ] Confusing
[x ] Not Sure?

Please Explain in Detail...
Howdy! I think NoSleep.js doesn't work with with a jQuery click event when a handler reference is used rather than an anonymous function (I hope I got those terms right :-P ).
E.g.
Doesn't work (NoSleep.enable() is in the start_ex_wizard function)
$('#start-link').click(start_ex_wizard);
Does work
$('#start-link').click(function(){
NoSleep.enable(); // Prevent device from sleeping
start_ex_wizard();
});
Your Proposal for Changes
I thought you might like to add a note to the readme.md so others are aware. Alternatively I could document it on StackOverflow.

Not sure if it is related, but I am trying to use it with AngularJS and I cannot make it work. I added it in an ng-click controller function and as soon as noSleep.enable() is called, the CPU goes up to 170%. The angular event handler also uses jquery that's why I thought it might be a similar case.

Not sure if it is related, but it does not work with Vue3.2. There is a notification about noscipt, "We're sorry but nosleepauto doesn't work properly without JavaScript enabled. Please enable it to continue". But I'm sure that the page runs with JavaScript enabled. So I'm confused by this notification. Maybe it is caused by event handler or Dom handler failure.


Anchor.fm / estilogospel

What article on docs.github.com is affected?

What part(s) of the article would you like to see updated?

Additional information

ไม่มีอะไรให้ดุ


Added support for event_return for master-side returns

The event_return function makes multiple calls to returners() by individual events that can be logged. Since grains['master'] won't be defined, the system assumes the local hostname will identify the master. This allows the use of the returner in environments where the minions can't talk to the Splunk HEC, or where opening such access is undesirable.

Oops... Initial pull request wasn't the latest version of my code. I've corrected this.

It looks like you have some tabs in your code which are messing with indentation. Could you replace them with spaces, please?

Thanks for the feedback, @basepi. Tabs have been removed, and I also cleaned up the commit history.


CFFL

CFFL

Linter check found the following problems:
The following problems have been found:
ERROR: /tmp/abs_50yzcltoz7/clone/recipe/meta.yaml:20: missing_wheel: For pypi packages, wheel should be present in the host section
ERROR: /tmp/abs_50yzcltoz7/clone/recipe/meta.yaml:27: missing_pip_check: For pypi packages, pip check should be present in the test commands
ERROR: /tmp/abs_50yzcltoz7/clone/recipe/meta.yaml:30: invalid_url: https://www.dashdaq.io/ : HTTPSConnectionPool(host='www.dashdaq.io', port=443): Max retries exceeded with url: / (Caused by NewConnectionError('<urllib3.connection.HTTPSConnection object at 0xffffa47d67d0>: Failed to establish a new connection: [Errno -2] Name or service not known'))
INFO: /tmp/abs_50yzcltoz7/clone/recipe/meta.yaml:35: invalid_url: https://dash.plot.ly/dash-daq : URL domain redirect dash.plot.ly ->  dash.plotly.com
WARNING: /tmp/abs_50yzcltoz7/clone/recipe/meta.yaml:36: missing_description: The recipe is missing a description
Errors were found

Linter check found the following problems:
The following problems have been found:
ERROR: /tmp/abs_05lts6a4j9/clone/recipe/meta.yaml:20: missing_wheel: For pypi packages, wheel should be present in the host section
ERROR: /tmp/abs_05lts6a4j9/clone/recipe/meta.yaml:27: missing_pip_check: For pypi packages, pip check should be present in the test commands
ERROR: /tmp/abs_05lts6a4j9/clone/recipe/meta.yaml:30: invalid_url: https://www.dashdaq.io/ : HTTPSConnectionPool(host='www.dashdaq.io', port=443): Max retries exceeded with url: / (Caused by NewConnectionError('<urllib3.connection.HTTPSConnection object at 0xffff74782620>: Failed to establish a new connection: [Errno -2] Name or service not known'))
INFO: /tmp/abs_05lts6a4j9/clone/recipe/meta.yaml:35: invalid_url: https://dash.plot.ly/dash-daq : URL domain redirect dash.plot.ly ->  dash.plotly.com
WARNING: /tmp/abs_05lts6a4j9/clone/recipe/meta.yaml:36: missing_description: The recipe is missing a description
Errors were found


Typo in label of GO:0102842 and GO:0102859

Hi,
The labels of
GO:0102842
1-18:1-2-16:2-monogalactosyldiacylglycerol desaturase activity (Sn2-16:3 forming
and GO:0102859
1-18:1-2-18:2-phosphatidylcholine desaturase activity (sn2-18:3 forming
are missing the closing brackets.
Also, the capitalization of Sn2 is not consistent across GO (Sn2 and sn2), should it be fixed to SN2 (https://en.wikipedia.org/wiki/SN2_reaction)?
GO:0102842                1-18:1-2-16:2-monogalactosyldiacylglycerol desaturase activity (Sn2-16:3 forming
GO:0102844                1-18:2-2-16:1-monogalactosyldiacylglycerol desaturase activity (Sn2-16:2 forming)
GO:0102843                1-18:2-2-16:0-monogalactosyldiacylglycerol desaturase activity (Sn2-16:1 forming)
GO:0102859                1-18:1-2-18:2-phosphatidylcholine desaturase activity (sn2-18:3 forming
GO:0102862                1-18:2-2-18:2-sn-glycerol-3-phosphocholine desaturase activity (sn2-18:3 forming)
GO:0102861                1-18:2-2-18:1-phosphatidylcholine desaturase activity (sn2-18:2 forming)
Thanks!

@ukemi thanks!


UI appearance of every calculator, solved #369

Fixes Issue🛠

Closes #369
Description👨💻
Updated as per the requirement of admin

Type of change📄

[] Bug fix (non-breaking change which fixes an issue)
[X] New feature (non-breaking change which adds functionality)

How this has been tested✅

Checklist✅

[X] My code follows the style guidelines of this project
[X] I have performed a self-review of my own code
[X] I have commented my code, particularly in hard-to-understand areas
[X] I have added demonstration in the form of GIF/video file
[X] I am an Open Source Contributor

Screenshots/GIF📷

Hey @Rakesh9100 , as per your demand, i have made changes and resolved the UI based issues, now it looks fine.
Hope this sounds good ?

Scroll to Top button is hidden being overlapped. Pls do fix.
And also do some change in source code GitHub logo with some animations and hover effect to it!! @Shantanu-Meta

Yah, I have fixed that, Now check it once.

Contributors page is showing errors with overflowing, pls do fix @Shantanu-Meta

Done @Rakesh9100

Hey @Rakesh9100 , can u check it ?

Nice work, Appreciated!! ✨
Merged, Congrats on getting your PR merged to this repo under JWOC 🎉🎉 @Shantanu-Meta

Nice work, Appreciated!! ✨
Merged, Congrats on getting your PR merged to this repo under JWOC 🎉🎉 @Shantanu-Meta


Polars: nit error messages

Closes #1699
Closes #1655

#1824  👈
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @Shoeboxam and the rest of your teammates on  Graphite

I don't know of other reasons that would cause deserialization problems, but I also don't know what I don't know. I guess the binary itself could be malformed.
Broader changes to error.rs would facilitate this, I think the error enum could be updated and shared messages could be consolidated there.


Passing data from controller to view.

In short I'm trying to make inline editable datatable and I'm trying to pass array to view with editable columns.
Code snippet of problem
In my controller
$editable_cols = [
            'Id' => false,
            'Name' => true,
            'Email' => true,
            'Created at' => false,
            'Updated at' => false];

return $dataTable->render('datatables.dt_eloquent', compact($editable_cols));

And the result in my view is: "Undefined variable: editable_cols"
What is the proper way to pass that array to my view?
Also If anyone knows better way to do inline editable table - please share.

Instead of using compact do
$editable_cols = [
            'Id' => false,
            'Name' => true,
            'Email' => true,
            'Created at' => false,
            'Updated at' => false];

return $dataTable->render('datatables.dt_eloquent', ['editable_cols=>$editable_cols]);

It works, thanks!


Bio Weekly - Add Figure for Weekly HealthPartners Clinical Collections by Clinic Location

Add a new figure for the weekly number of clinical collections at HealthPartners by clinic location.
Title this new figure: Figure 11.1 Weekly Clinical Biospecimen Collections at HealthPartners by Clinic Location
Requestor(s): Michelle
Table or Figure title: Figure 11.1 Weekly Clinical Biospecimen Collections at HealthPartners by Clinic Location
Variables needed (include variable name and Concept ID):

RcrtES_Site_v1r0 (214456996)

BioSpm_Setting_v1r0 (650516960)

BioClin_SiteBlLocation_v1r0 (185243482) OR 7.  Use the blood location ID or the urine location ID to get the location; it can be assumed that they are the same if both are present. If one is not populated, the other can be used.)

BioRec_CollectFinal_v1r0 (410912345)

Specify numerator and denominator by variable name where applicable:

Denominator = All finalized clinical collections at HFH - RcrtES_Site_v1r0 (214456996) = 0; BioSpm_Setting_v1r0 (650516960) = 1; BioRec_CollectFinal_v1r0 (410912345) = 1

Numerator = HP clinic locations (BioClin_SiteBlLocation_v1r0 (185243482) OR 7. BioClin_SiteUrLocatBL_v1r0 (452847912))
HP Clinic Locations:
NSC = 1
Elk River = 2
Chanhassen = 3

Notes: N/A
Approved by:

@HopkinsDC
To clarify, for the HP locations would it be:
d_173836415_d_266600170_d_185243482=1 OR d_173836415_d_266600170_d_452847912=1  means NSC
d_173836415_d_266600170_d_185243482=2 OR d_173836415_d_266600170_d_452847912=2  means Elk River
d_173836415_d_266600170_d_185243482=3 OR d_173836415_d_266600170_d_452847912=3  means Chanhassen?

@HopkinsDC To clarify, for the HP locations would it be: d_173836415_d_266600170_d_185243482=1 OR d_173836415_d_266600170_d_452847912=1 means NSC d_173836415_d_266600170_d_185243482=2 OR d_173836415_d_266600170_d_452847912=2 means Elk River d_173836415_d_266600170_d_185243482=3 OR d_173836415_d_266600170_d_452847912=3 means Chanhassen?

Yes, that's correct.

Update successfully implemented in 12/18 weekly biospecimen metrics report.

@KELSEYDOWLING7 My apologies! I mistook this issue for the update made to Figure 11 (Weekly Biospecimen Collections
at HealthPartners). This is a separate, new figure and it's not in the 12/18 report yet because I think we were waiting on prod data to populate.

@HopkinsDC  That's ok! We do have a few data points for it now

@KELSEYDOWLING7 It's good to see HP's clinical collections are showing properly. Just a couple of additional edits:

Can you adjust the x-axis to start on 11/20/23?
Assuming the y-axis scale will auto-adjust as the weekly collections increase, can you adjust it to be a whole-number scale (no "#.5" half counts)?

@HopkinsDC Sure thing

@KELSEYDOWLING7 Thank you!

Update successfully implemented in 12/26 weekly biospecimen metrics report.


use applications from specified rounds to build source dataset

Create a script that does the following:

fetch applications.json from the Indexer (example) for a given set of rounds identified by round IDs (list can be hardcoded in the script)
remove all applications with status other than APPROVED
generate an array of project documents according to the format reported below under "indexed document format"
writes the array to disk as JSON

Extend search.py and data.py to account for additional fields
Adjust the Dockerfile to invoke said script instead of wget

Indexed document format
- project id (as shown in top level of `applications.json`, not in the `project` object)
- project name
- project description
- banner img cid, if present
- logo img cid, if present
- website url
- round id
- application id
- total received in usd (using the `amountUSD` field)
- vote count (using the `votes`)

Example from an applications.json file:
[
    {
        "id": "0",
        "projectId": "0x1b014acdbd404fda33ec62e3c82d8575f5eef50a3d6e92ac770eb8f1a6264c9c",
        "roundId": "0x1488817b0137CA16F35D72A5F2A7c095c1Ec9166",
        "status": "APPROVED",
        "amountUSD": 0.01594488,
        "votes": 1,
        "uniqueContributors": 1,
        "metadata": {
            "signature": "0x922e37eef844905edce66cf1f5de91a9aa2d299df0691841c744b9e17a9f6caa3c3937df7fdc1818ecca5bfa60acde763d8ff83d9895194f13f908baf99839c31b",
            "application": {
                "round": "0x1488817b0137ca16f35d72a5f2a7c095c1ec9166",
                "recipient": "0x37e5e6eb36467F98392ebBb35F110FbB8238e6D3",
                "project": {
                    "lastUpdated": 0,
                    "createdAt":<PHONE_NUMBER>000,
                    "id": "10:0x8e1bD5Da87C14dd8e08F7ecc2aBf9D1d558ea174:0",
                    "title": "production test project (for approval)",
                    "description": "test description",
                    "website": "https://gitcoin.co/",
                    "metaPtr": {
                        "protocol": "1",
                        "pointer": "bafkreifvxz5ebytdxbifumtruclwdck2bcgamedyn6nze44l2amqe5wmiy"
                    },
                    "userGithub": "michellema1208",
                    "projectGithub": "gitcoinco",
                    "projectTwitter": "musingsbymima",
                    "credentials": {
                        "twitter": {
                            "@context": [
                                "https://www.w3.org/2018/credentials/v1"
                            ],
                            "type": [
                                "VerifiableCredential"
                            ],
                            "credentialSubject": {
                                "id": "did:pkh:eip155:1:0x37e5e6eb36467F98392ebBb35F110FbB8238e6D3",
                                "@context": [
                                    {
                                        "hash": "https://schema.org/Text",
                                        "provider": "https://schema.org/Text"
                                    }
                                ],
                                "provider": "ClearTextTwitter#musingsbymima",
                                "hash": "v0.0.0:ZGSTCMn5QKa3BDAa2/asBecP8iiIRx/WtXVvbBRXPqI="
                            },
                            "issuer": "did:key:z6MkghvGHLobLEdj1bgRLhS4LPGJAvbMA1tn2zcRyqmYU5LC",
                            "issuanceDate": "2023-09-14T20:48:26.874Z",
                            "proof": {
                                "type": "Ed25519Signature2018",
                                "proofPurpose": "assertionMethod",
                                "verificationMethod": "did:key:z6MkghvGHLobLEdj1bgRLhS4LPGJAvbMA1tn2zcRyqmYU5LC#z6MkghvGHLobLEdj1bgRLhS4LPGJAvbMA1tn2zcRyqmYU5LC",
                                "created": "2023-09-14T20:48:26.874Z",
                                "jws": "eyJhbGciOiJFZERTQSIsImNyaXQiOlsiYjY0Il0sImI2NCI6ZmFsc2V9..kjB5C6fC4xmj2rgB4t4TtrEdlHEsJeUz-oxPqXtsvx_iXtQsB0xHHDPg3FuMoWIgj0PX2WC5PGK3eukjJ7nBAA"
                            },
                            "expirationDate": "2023-12-13T20:48:26.874Z"
                        },
                        "github": {
                            "@context": [
                                "https://www.w3.org/2018/credentials/v1"
                            ],
                            "type": [
                                "VerifiableCredential"
                            ],
                            "credentialSubject": {
                                "id": "did:pkh:eip155:1:0x37e5e6eb36467F98392ebBb35F110FbB8238e6D3",
                                "hash": "v0.0.0:n/Db39IbeksKyw8Hx1L/KDqtlPTFlLV+IyslsQrcfGA=",
                                "provider": "ClearTextGithubOrg#gitcoinco#26017180",
                                "@context": [
                                    {
                                        "hash": "https://schema.org/Text",
                                        "provider": "https://schema.org/Text"
                                    }
                                ]
                            },
                            "issuer": "did:key:z6MkghvGHLobLEdj1bgRLhS4LPGJAvbMA1tn2zcRyqmYU5LC",
                            "issuanceDate": "2023-09-14T20:48:38.393Z",
                            "proof": {
                                "type": "Ed25519Signature2018",
                                "proofPurpose": "assertionMethod",
                                "verificationMethod": "did:key:z6MkghvGHLobLEdj1bgRLhS4LPGJAvbMA1tn2zcRyqmYU5LC#z6MkghvGHLobLEdj1bgRLhS4LPGJAvbMA1tn2zcRyqmYU5LC",
                                "created": "2023-09-14T20:48:38.393Z",
                                "jws": "eyJhbGciOiJFZERTQSIsImNyaXQiOlsiYjY0Il0sImI2NCI6ZmFsc2V9..7Bc04h1Muxz_L7tFE9ulB8fx58FnV1ShT09HVZqdXDHsL71WpRcxIK7QO-UPRvsBEYmI69lXFRzrjZjJYzOdBw"
                            },
                            "expirationDate": "2023-12-13T20:48:38.393Z"
                        }
                    }
                },
                "answers": []
            }
        },
...
]

It may be necessary to correlate applications.json with other data files to also pull in data such as round name.


Parser does not like identifiers that looks like exponents

This is bad:
define constant e1 = 3.14
ParseError (at line 1 col 16).
define constant e1 = 3.14
                ^^

In PR #429


APK Link broken

Since about 2 days, https://piebridge.me/br/latest.apk no longer works but leads to a 404:
Location: https://jianyu.io/br/latest.apk [following]
Location: https://d.jianyu.io/br/br-v<IP_ADDRESS>.play.apk [following]
Remote file does not exist -- broken link!!!

Could that please be fixed? Just make it br-v<IP_ADDRESS>.play.apk :wink:

Sorry, forget to deploy to firebase.
Please use this link instead: https://d.jianyu.io/br/latest.apk
jianyu.io -> firebase hosting
d.jianyu.io -> actual download link, on vps
piebridge.me and v*.piebridge.me is deprecated.

Still cannot fixed..
cannot deploy to firebase hosting..
and, https://d.jianyu.io/br/latest.apk won't be a 302, will just download.

It's slow, but seems to work. Just let me know when I shall use a different link. Until then I'd say "works for me". Thanks!

Cannot make jianyu.io / piebridge.me work.
So, please note, https://jianyu.io/br/latest.apk won't be a 302, it will just response as 200.
which means, you should send if-match with etag, last-modified.


Lua 5.4 support

Can you add lua-5.4 support?
Fedora has a patch for it: https://src.fedoraproject.org/rpms/lua-posix/blob/master/f/lua-posix-helpers-5.4.patch

Thanks for the hints @opoplawski, although I solved the require issue differently, and also changed the way bitwise operations are implemented so that this release works correctly for luarocks users too.
Resolved with https://github.com/luaposix/luaposix/releases/tag/v35.0

Thanks, looks good.


2 jenkinsci repositories on Docker Hub with different tags

When I was searching for Jenkins 2.8 Docker image, I came across the following repos:

https://hub.docker.com/r/library/jenkins/tags/
https://hub.docker.com/r/jenkinsci/jenkins/tags/

Not sure if they are both owned by jenkinsci, former only has 1.x release, while the latter has mostly 2.x releases. Would be nice to consolidate into one and/or keep the tags consistent across both. :smiley:

It is described in https://hub.docker.com/r/library/jenkins

This is a fully functional Jenkins server, based on the Long Term Support release http://jenkins.io/.
For weekly releases check out jenkinsci/jenkins

I missed that. Thanks @carlossg


Cats in 2.8 way slower than in 2.79

Ryzen 3600
32gb ram
5700 amd gpu
SSD
Clicking on apply rest pose takes up to 5 minutes compared to seconds on 2.79, same with merging all meshes.

This is very likely an issue with Blender, not with Cats. Test if the same issue still occurs in Blender 2.90


Support for encrypting numbers

Hey folks,
I recently started using this for a hobby project and noticed that it is possible to encrypt Strings only.
Error: encryption enabled for field amount of unsupported type Float: only String fields can be encrypted.

Is there some inherent plugin/cryptography limitation to encrypting numbers, or was this just never a priority to implement?
If someone could give me a couple of hints around this I'd love to take a stab at implementing support for it.

There is no technical limitation AFAIK, AES-GCM-256 would work fine on the IEEE-754 float64 data format used by JavaScript to store numbers (I did this a while back for another project, source), with proper padding.
The main challenge in implementing this (and/or other data types) is how to define the data format that is being encrypted: how to go from a JavaScript variable to an array of bytes to encrypt, and on decryption how to go back from the decrypted array of bytes back into a JavaScript data type.
For SQL-based schemas, I suppose we could use the schema metadata to know what kind of processing to do, but I'm not sure how that would translate in MongoDB / NoSQL schemas.


Is there a way to use MathBox.js from file:// ?

I noticed the first part on your documents is something like:
document.getElementById('info').innerHTML = "Sorry. This example does not work when accessed using file://. Please use an http:// host and try again.";

And well, I tested and it doesn't work in with file:// and I would like to know if there's a workaround for this. Because I will try to implement MathBox with org-mode on emacs, and for the best use, you always open your files with file:// because since it's only an HTML file, maybe with some javascript and css, you don't need a server. Anyway, I'll appreciate your input. =)

+1 this would be great, especially for use within a WebView. Also @unconed are you still actively working on this? Or is this intended to be superseded by MathBox2?


fix: AU-1836: translate "previous" to finnish and swedisn on form

AU-1836

What was done

fixed missing previous translation from a couple of forms

How to install

Make sure your instance is up and running on correct branch.

git checkout feature/AU-1836-translation
make fresh

Run make drush-cr

How to test

[ ] Go to this form
[ ] navigate to page four. See that the "previous" button is translated
[ ] switch to swedish, see that it works there too
[ ] Go to this form
[ ] navigate to page four. See that the "previous" button is translated
[ ] switch to swedish, see that it works there too
[ ] Check that code follows our standards

Designers review

[ ] This PR does not need designers review
[ ] This PR has been visually reviewed by a designer (Name of the designer)

Other PRs

Link to other PR

Kumpainenkin lomake tarvii vielä enkunkieliset käännökset

Jes. Sen siitä saa, että kääntää asioita pois englannista. Nyt pitäisi toimia oikein


Pass RouteSettings into all callers of showGeneralDialog. fixes #31261

Description
Right now there is no way to customize the RouteSettings when using the showDialog functions. I can't think of a good reason to omit this, since it's pretty useful for e.g. analytics to track page names.
Related Issues

#31261

Tests
I added the following tests:

added test for showDialog to demonstrate how it is passed to the NavigatorObserver

Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

[x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
[x] I signed the [CLA].
[x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
[x] I updated/added relevant documentation (doc comments with ///).
[x] All existing and new tests are passing.
[x] The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
[x] I am willing to follow-up on review comments in a timely manner.

Breaking Change
Does your PR require Flutter developers to manually update their apps to accommodate your change?

[x] No, this is not a breaking change.

I just attempted to do this myself and fix the merge conflicts, but I don't have write permission to your branch. If you like, I can just push this from one of my branches and close this PR.

@darrenaustin sorry, didn't check guthub notifications, and missed your message.. thanks, feel free to close this PR in favor of your own 👍

@hpoul thanks again for your contribution. Sorry we didn't get this in from your branch.  Closing as #51525 recreates this with some updates.


error: ‘ADCGScalar’ is not a member of ‘ct::core’

Hi,
I'm having trouble compiling my own example of the LQR Control like the example "LQR Control of a Damped Oscillator". I'm compiling my code using
catkin build -DCMAKE_BUILD_TYPE=Release -DBUILD_EXAMPLES=true
The error I get is
In function ‘int main(int, char**)’:
/usr0/home/rshu/ct_ws/src/ct_ballbot/src/InvertedPendulumLQRExample.cpp:24:3: error: ‘ADCGScalar’ is not a member of ‘ct::core’
   ct::core::ADCGScalar g(9.81);
   ^
/usr0/home/rshu/ct_ws/src/ct_ballbot/src/InvertedPendulumLQRExample.cpp:25:3: error: ‘ADCGScalar’ is not a member of ‘ct::core’
   ct::core::ADCGScalar L(1.0);

below is a snippet of the code where I'm trying to define SCALAR type make my system aut-differentiable
ct::core::ADCGScalar g(9.81);
ct::core::ADCGScalar L(1.0);
std::shared_ptr<InvertedPendulum> invertedPendulum(new InvertedPendulum(g, L));

The weird thing is that the LQR Control of a Damped Oscillator compiles fine. I able to run
rosrun ct_optcon ex_LQR with no issues.
I used the scripts install_deps.sh and install_cppadcg.sh to install the dependencies.
System:

Ubuntu 16.04 + ROS Kinetic
Compiler: GCC
CT Version 3.0.2

Any advice would be really appreciate it thank you!

Hi @rshum19 , thanks for reporting!
Can you quickly verify that the ct_core unit tests pass on your system, e.g. try to run
$ catkin build ct_core -DBUILD_TESTS=true -DCMAKE_BUILD_TYPE=Release
afterwards you should be able to run the code-gen unit tests. rosrun ct_core CodegenTests
Also, please let me know if you are on branch v3.0.2 or if you are on tag 3.0.2 (they are slightly different as of now).
Please let me know what your findings are!

Having the same issue and a similar system configuration. Error message ‘ADCGScalar’ is not a member of ‘ct::core’ while trying to compile the example in a separated catkin package. All unit tests are passed on git branch v3.0.2:
[----------] Global test environment tear-down
[==========] 13 tests from 6 test suites ran. (18745 ms total)
[  PASSED  ] 13 tests.

Also did some experiment to manually turn on CPPAD and CPPADCG flag in CMakeLists. ‘ADCGScalar’ issue goes away but complains  note:   no known conversion for argument 1 from ‘const CppAD::cg::CG<double>’ to ‘double’.

Dear @tsaoyu
Thanks for reporting. In order to clarify the issue, I wrote a quick test package, which is public and can be found here. It contains a slightly modified version of the LQR example code.
This package compiles fine on my machine using
catkin build test_package.
Can you verify if this test package works or fails on your machine

Dear @markusgft
Thank you for your prompt response. Similar to @tsaoyu I can also report that all the units test passed on the git branch v3.0.2
[----------] Global test environment tear-down
[==========] 13 tests from 6 test cases ran. (21862 ms total)
[  PASSED  ] 13 tests.

With the test_package I have not issues compiling. However, when I run the example
rosrun test_package testLqr

I get the following output
A:
    0     1
-2500  -100

B:
0
1

Q:
1 0
0 1

R:
1

terminate called after throwing an instance of 'std::runtime_error'
  what():  solveSchurDirect() in CARE can only be used if the lapack library is installed on your system.
Aborted (core dumped)

It seems that the issue with   ct::core::ADCGScalar is not a problem with the test package. However I don't know why I get the issue with the lapack library since it is installed in my sytem
rshu@gs16678:~/ct_ws$ dpkg -l liblapack-dev
Desired=Unknown/Install/Remove/Purge/Hold
| Status=Not/Inst/Conf-files/Unpacked/halF-conf/Half-inst/trig-aWait/Trig-pend
|/ Err?=(none)/Reinst-required (Status,Err: uppercase=bad)
||/ Name                   Version          Architecture     Description
+++-======================-================-================-==================================================
ii  liblapack-dev          3.6.0-2ubuntu2   amd64            Library of linear algebra routines 3 - static vers

Are there any additional steps besides sudo apt-get install liblapack-dev or compile flags required?
Thank you!

Okay .. this is getting more interesting by the minute. It might be that the find-script needs some more tweaks and tricks.
Can you confirm that lapack is not found during building? When you build with catkin build -- verbose, you should see some output like this when it builds ct_optcon

What is your output for lapack?
Now, back to answer the original problem ... what was the difference in your cmakelist.txt, that made it not find the AD-Scalar type? Did you find that out?

Answering the original question the difference in CMakeList.txt file was a mistake in   target_link_libraries, I was linking against ct_rbd
Original
add_executable( InvertedPendulumLQR src/InvertedPendulumLQR.cpp)
target_link_libraries(InvertedPendulumLQR  ct_rbd)

Solved
add_executable( InvertedPendulumLQR src/InvertedPendulumLQR.cpp)
target_link_libraries(InvertedPendulumLQR  ${catkin_LIBRARIES})

Back to the lapack issue it does show that lapack was found

My test result on test_package also shows lapack was missing on my system. Rebuild ct_optcon after catkin clean is successful with IPOPT support.
-- A library with BLAS API found.
-- Found LAPACK library
-- No ENV variable for blasfeo found.
-- No ENV variable for HPIPM found.
-- Found IPOPT - building with IPOPT support
-- Found Doxygen: /usr/bin/doxygen (found version "1.8.13") found components:  doxygen

So, @tsaoyu it is working for you, including lapack support?
And @rshum19 it is not working for you? Did you attempt a catkin clean?

@markusgft Still the same issue while trying to run the test package.
terminate called after throwing an instance of 'std::runtime_error'
  what():  solveSchurDirect() in CARE can only be used if the lapack library is installed on your system.
Aborted (core dumped)

The thing is also strange that the example ex_Nlp_2D (require the IPOPT) runs well.

@markusgft
I tried  catkin clean but the error in the test package still persist. However, I tried running the LQR example in ct_optcon and that had no issues
rosrun ct_optcon ex_LQR

Maybe there is something missing in the CMakeList.txt of the test_package?

The most likely cause for the ssue is that for some reason, the CT_USE_LAPACK compile flag gets not exported properly in your cases (on my system, it does -- which is strange). I will figure a proper fix as soon as my time allows.
In the meantime, can you simply try adding the compile definition manually to your package, e.g. something along the lines of add_definition(CT_USE_LAPACK)

@markusgft  add compile flag add_definitions(-DCT_USE_LAPACK) solve the issue.
But the other packages discovery is still an issue. For example, the CPPAD flag seems broken that everytime when I call ct::core::internal::TraitSelector<SCALAR>::Trait::cos() the error
error: ‘TraitSelector’ is not a member of ‘ct::core::internal’

Dear @tsaoyu @rshum19
I finally understood the issue. The problem is that
target_link_libraries( ... ${catkin_LIBRARIES})
does not perform a proper import of the compile flags of the catkin targets. In order to properly import the compile definitions, you are explicitly required to link against ct_optcon ...
target_link_libraries( ... ${catkin_LIBRARIES} ct_optcon)
..should solve the first problem.
The problem with the trait definition is, that the TraitSelector does not live in the internal namespace. The correct expression is ct::core::tpl::TraitSelector<SCALAR>::Trait::cos().
I believe that you used that namespace because of an error in the documentation. I will fix that as soon as possible and push a new version of the docu!

Dear @markusgft
Linking  against ct_optcon does solve the issue for the test_package. The interesting thing is that on my own package linking only to ${catkin_LIBRARIES} is sufficient. Nonetheless, I think you have helped me with my issues. I appreciate your prompt response and help!

Thank you for the help @markusgft! Now I am able to template my own model using traits.