TestTCPClient.test_spoof_address and TestTCPClient.test_spoof_address errors found while tox testing

I tested with tox on my machine running Ubuntu 16.04 having both python 3.5 and 3.6 and got two commands failed errors TestTCPClient.test_spoof_address and TestTCPClient.test_spoof_address.
Steps to reproduce the problem:
I am using Ubuntu 16.04. I had both py35 and py36 installed.

I clone the repo: git clone https://github.com/mitmproxy/mitmproxy
cd mitmproxy
Run the dev.sh from terminal
sudo ./dev.sh
. venv/bin/activate
tox (Also tried tox -e py35/6)

Expected behavior:
py35: commands succeeded
py36: commands succeeded
Error found:
=================================== FAILURES ===================================
___________________________ TestProxyServer.test_err ___________________________
self = <test.mitmproxy.test_proxy.TestProxyServer object at 0x7fb3be65bac8>

    @skip_windows
    def test_err(self):
        # binding to <IP_ADDRESS>:1 works without special permissions on Windows
        conf = ProxyConfig(options.Options(listen_port=1))
        with pytest.raises(Exception, match="Error starting proxy server"):
>           ProxyServer(conf)

E           Failed: DID NOT RAISE <class 'Exception'> matching 'Error starting proxy server'
test/mitmproxy/test_proxy.py:65: Failed
_______________________ TestTCPClient.test_spoof_address _______________________
self = <test.mitmproxy.net.test_tcp.TestTCPClient object at 0x7fb3bd7cfba8>

    def test_spoof_address(self):
        c = tcp.TCPClient(("<IP_ADDRESS>", self.port), spoof_source_address=("<IP_ADDRESS>", 0))
        with pytest.raises(exceptions.TcpException, match="Failed to spoof"):
>           c.connect()

E           Failed: DID NOT RAISE <class 'mitmproxy.exceptions.TcpException'> matching 'Failed to spoof'
test/mitmproxy/net/test_tcp.py:628: Failed
============== 2 failed, 1328 passed, 1 skipped in 90.52 seconds ===============
ERROR: InvocationError: '/home/bksahu/Documents/Github/mitmproxy/.tox/py35/bin/pytest --timeout 60 --cov-report= --cov=mitmproxy --cov=pathod --full-cov=mitmproxy/ --full-cov=pathod/'

Any other comments? What have you tried so far?
Tried tox -e py35/6 and got the same error for both. I looked up the documentation of both mitmproxy and tox but I couldn't find anything relevant.

System information
Mitmproxy: 3.0.0dev1082 (ddb8f43)
Python:    3.5.2
OpenSSL:   OpenSSL 1.1.0g  2 Nov 2017
Platform:  Linux-4.10.0-28-generic-x86_64-with-Ubuntu-16.04-xenial

Thanks for the report. Can you run mitmproxy on a privileged port without any further measures on your system? In other words, does mitmproxy -p 80 spawn a fully functioning mitmproxy instance?
The tests we're looking at should fail because regular users shouldn't have sufficient permissions.

Thanks for your comment. I got this on mitmproxy -p 80.
Error starting proxy server: OSError(98, 'Address already in use')
So the errors I reported are bugs or they are supposed to work that way ?

Well you need to check with a free port - you seem to have something running on port 80 already. what about mitmproxy -p 85 for example? Are you running this as root?

Yes that mitmproxy -p 85 works fine. Yes I am running this as root.

Ok, so the culprit is that you are running this as root, that makes binding
to privileged ports succeed (which would normally fail). Similar to
skip_windows, we probably need a "skip_root" decorator to skip those tests
when running as root.
 :-)
On Sat, 30 Dec 2017, 10:44 Batakrishna Sahu<EMAIL_ADDRESS>wrote:

Yes that mitmproxy -p 85 works fine. Yes I am running this as root.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/mitmproxy/mitmproxy/issues/2730#issuecomment-354536883,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AA-NPr1q7er57Gz-aoRxQd3UuTeJNIacks5tFgXmgaJpZM4ROXlA
.

I tried tox -e py35 testing with out root and I got this
Traceback (most recent call last):
  File "/home/batakrishna/Documents/Github/mitmproxy/venv/lib/python3.5/site-packages/py/_error.py", line 66, in checked_call
    return func(*args, **kwargs)
PermissionError: [Errno 13] Permission denied: '/home/batakrishna/Documents/Github/mitmproxy/.tox/py35/.tox-config1'

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/home/batakrishna/Documents/Github/mitmproxy/venv/bin/tox", line 11, in <module>
    sys.exit(cmdline())
  File "/home/batakrishna/Documents/Github/mitmproxy/venv/lib/python3.5/site-packages/tox/session.py", line 40, in main
    retcode = Session(config).runcommand()
  File "/home/batakrishna/Documents/Github/mitmproxy/venv/lib/python3.5/site-packages/tox/session.py", line 392, in runcommand
    return self.subcommand_test()
  File "/home/batakrishna/Documents/Github/mitmproxy/venv/lib/python3.5/site-packages/tox/session.py", line 565, in subcommand_test
    self.finishvenv(venv)
  File "/home/batakrishna/Documents/Github/mitmproxy/venv/lib/python3.5/site-packages/tox/session.py", line 482, in finishvenv
    venv.finish()
  File "/home/batakrishna/Documents/Github/mitmproxy/venv/lib/python3.5/site-packages/tox/venv.py", line 214, in finish
    self._getliveconfig().writeconfig(self.path_config)
  File "/home/batakrishna/Documents/Github/mitmproxy/venv/lib/python3.5/site-packages/tox/venv.py", line 32, in writeconfig
    path.write("\n".join(lines))
  File "/home/batakrishna/Documents/Github/mitmproxy/venv/lib/python3.5/site-packages/py/_path/local.py", line 501, in write
    f = self.open(mode)
  File "/home/batakrishna/Documents/Github/mitmproxy/venv/lib/python3.5/site-packages/py/_path/local.py", line 361, in open
    return py.error.checked_call(open, self.strpath, mode)
  File "/home/batakrishna/Documents/Github/mitmproxy/venv/lib/python3.5/site-packages/py/_error.py", line 86, in checked_call
    raise cls("%s%r" % (func.__name__, args))
py.error.EACCES: [Permission denied]: open('/home/batakrishna/Documents/Github/mitmproxy/.tox/py35/.tox-config1', 'w')


Set environtment var for app_dev.php

E.g.:
### ~/.homestead/Homestead.yml
 variables:
      - key: SYMFONY_DEV
      value: 1

I don't agree. Homestead is not the "default for standard", and if you're using env vars, there's a lot of chance that you would use SYMFONY_DEBUG=0|1 and SYMFONY_ENV=prod|dev , but it's up to the dev to choose between different env vars.
Plus, with env vars, technically you would not need app_dev anymore because everything can be handled with these env vars.

I agree with @Pierstoval , but anyway, is there somewhere a good example in Symfony docs about how to use a Symfony app during the development along with Docker or other virtualization tools? Because by default, I can't get access to theapp_dev.php inside Docker container without any changes. It'd be nice to have a good example how to handle it at least in docs if any exists.

@bocharsky-bw The problem with this "Symfony + Docker" thing is that a Symfony docker stack would need at least 2 containers : php-fpm + nginx, and there's some dichotomy between devs about "apache or nginx", but also "one or multiple containers", "do we need mysql or mariadb", etc.
I don't think that the @Symfony team is ready to set up a "standard recommendation for Docker" or any other virtualization tool (like homestead with vagrant or just a simple virtualbox container).
This is stuff that also has to be maintained, and as everything grows up very fast in our world, the core team would have to discuss about these things very deeply before making any changes in the Standard Edition to adapt to every environment, including virtualization or container-based stacks.
That's why I'm 👎 for this change : the Standard Edition is "not ready yet" for these advanced stacks. Even if lots of devs are using them.

For information, we maintain a basic Docker setup for API Platform (it works for any Symfony project): https://github.com/api-platform/api-platform

As Symfony 4 & Flex are coming, I think we can close this: new development practices will help in maintaining a custom development environment or deployment process.


Whin receive message problem

I have issue that I can receive messages only when I sent messages from web.whatsapp.com. When I'm traying to send message from whasapp android app it doesn't work. I checked it on 2 different phone numbers and 2 different  smartphones - android 12 and updated whatsapp to newest one.
Whin send and confirm work without problem.

Thanks for using whin!.
I guess you're talking about sending a whatsapp to your node-red env, from within the whatsapp android app.
To be all honest, we did not test that particular scenario cause we, the maintainers, are using iphones.
I will try to get an Android phone and test if we can reproduce your problem... will get back with my comments shortly.

I really like Your project! Yes, I'm traying to send command from phone and node red is listening to whatsapp. Node red version 10.2.1.

Simple flow - 1 and 2 are 2 different phones numbers.

I did the testing with a borrowed android phone (xiaomi Redmi); added it to whin requesting a new token; adjusted the node-red nodes with its new configuration, and everything worked just fine.
I am affraid there must be something wrong on your end.

I really like Your project! Yes, I'm traying to send command from phone and node red is listening to whatsapp. Node red version 10.2.1.  Simple flow - 1 and 2 are 2 different phones numbers.

weird config, but nevertheless it should work. Just make sure node 1 and 2 on your picture have the right config (it must be different on each).
These 2 nodes are listeners: this means that whatever you send to whin (using any whatsapp client) from number used on config 1, should pop on node 1. Same exact thing on from phone on config 2.
Each number will have a different token, and are listening a different (encrypted) queue for reception.

Problem solved - I had beta version of Whatsapp. I removed it and changed on standard. Now is everything works! Thanks!

Problem solved - I had beta version of Whatsapp. I removed it and changed on standard. Now is everything works! Thanks!

Great!.
Running the beta version of whatsapp shoudn't be a problem neither, but anyway...
I guess you're using the node-red add-on for home assistant (node-red latest version is 2.X.X, not 10.X.X We will be glad to know of use-cases when using whin on HA (it would be an inspiration for our youtube channel with samples and use-cases). Please share your ideas with the community, as we are not HA users :)


Remove unused DepthCalculation enum

Objective
Remove unused enum DepthCalculation and its usages. This was used to compute visible entities in the old renderer, but is now unused.
Solution
sed 's/DepthCalculation//g'

Changelog
Changed
Removed bevy_render::camera::DepthCalculation.
Migration Guide
Remove references to bevy_render::camera::DepthCalculation, such as use bevy_render::camera::DepthCalculation. Remove depth_calculation fields from Projections.

bors r+


Bug: ui5 service not loaded correctly with version 0.0.3

This is in my wdio.conf.js file. I am using wdi5 version 0.0.3.
exports.config = {
    // ...
    services: ['ui5'],
    // ...
}

On startup wdio throws an error  because it cannot identify wdio-ui5-service as the service behind the keyword ui5.
 ERROR @wdio/utils:initialiseServices: Error: Couldn't find plugin "ui5" service, neither as wdio scoped package "@wdio/ui5-service" nor as community package "wdio-ui5-service". Please make sure you have it installed!

I think this is related to some internal refactoring for version 0.0.3 that removed the launcher. According to the documentation (https://webdriver.io/docs/customservices.html), this might still be necessary?!
It works, when I directly include the service class (like you do it in the tests):
const ui5Service = require('wdio-ui5-service/src/index')

exports.config = {
    // ...
    services: [
        [ui5Service]
    ],
    // ...
}

confirmed, our bad.
fix on the way 🤭


Util.tree ?element function example inconsistent with its signature in the documentation (?)

Hello Anton,
I have just been reading about the parser documentation and it appears to me that the application of the element function is inconsistent with its signature,
So,
?element:(name -> (name * string) list -> 'a list -> 'a)
is a function of three arguments producing 'a
but it is used as,
~element:(fun (name, _) children -> Element (name, children))
which appears to be a function of only two arguments, the tupple (name, _) and children,
See here for the original piece of documentation,
kind regards,
Ondrej
val tree :
?text:(string list -> 'a) ->
?element:(name -> (name * string) list -> 'a list -> 'a) ->
?comment:(string -> 'a) ->
?pi:(string -> string -> 'a) ->
?xml:(xml_declaration -> 'a) ->
?doctype:(doctype -> 'a) ->
([< signal ], sync) stream -> 'a option
This function's type signature may look intimidating, but it is actually easy to use. It is best introduced by example:
type my_dom = Text of string | Element of name * my_dom list
"HTML5 is easy to parse".
|> string
|> parse_html
|> signals
|> tree
~text:(fun ss -> Text (String.concat "" ss))
~element:(fun (name, _) children -> Element (name, children))

This was actually fixed in #50, and is now
https://github.com/aantron/markup.ml/blob/e1aed3c90cb564c261d4fe4bc272f918f9113039/src/markup.mli#L554-L561
The issue is that Markup.ml's doc generation script is currently broken, and as I haven't gotten around to fixing it, I haven't been able to post accurate docs lately (almost all the docs are still accurate, though). I opened #62 to remind myself to get on it! I'm closing this issue in the meantime.

Ok, tx Anton! 😃


Alignment parameter is not passed to __wbindgen_free in js bindings.

https://github.com/rustwasm/wasm-bindgen/blob/f117406532fb2fd813d998e2ea98ad56e4a2ae4c/crates/cli-support/src/js/binding.rs#L1059
I suppose it should pass in 4 by default.
Built with: --target wasm32-unknown-unknown -Z build -std=std,panic_abort
Generated binding with --web

Indeed, it was missed in #3463.


Remove "OSBv2 is now available at v2.opensourcebrain.org" from the top of the homepage

Not really necessary...

Changed in #17


We need more infrastructure for testing macs

The current quantity of macs at c7 is not enough to run all the mac tests we want to run.

https://www.macstadium.com/pricing was considered as an option.

We now have a lot of macs at macstadium, closing issue.


Line editor is no longer accessible on a tablet since the introduction of arrow labels

CMD+Enter and/or CMD+Dblclick does not invoke the line editor on a tablet or mobile (with and without external keyboard). As of now the line editor is simply not accessible for tablet users on Arrows.
@ad1992, as a quick temporary fix, could we add the line editor command to the context menu?

:)
I am so stupid...
Also in the mean time I got the line editor to work with CMD+enter


How to use batch processing

Great tool
May I ask how to use the newly added batch processing function? I couldn't find any relevant instructions. Can you provide an answer? Thank you

Does this help? https://github.com/hkchengrex/MMAudio/blob/main/docs/EVAL.md


#fixes issue #950 improved_search_button_and_removed_unnecessary_logo

Now it's better than before :
https://github.com/user-attachments/assets/447bbe7c-8b87-4e8d-a6b1-967e6278a634
Kindly merge it.

@shreya0154 Your pull request has been successfully merged! Don't stop here—continue contributing by addressing more issues and aiming to become a top contributor. You can also contribute in my another Repository BuddyTrail which is also under Hacktoberfest
Great contribution to HACKTOBERFEST'24! 🎉


Fix for dynamic primaryKey result, fixes #157

Fix for this issue: https://github.com/overlookmotel/sequelize-hierarchy/issues/157

Coverage increased (+0.06%) to 91.223% when pulling ec2c5e02b95197033838a683f4d8f85f230b3d45 on lukichev:master into 1cd9b690805fee41da619c4e710b5f423bec78d2 on overlookmotel:master.

@overlookmotel, hey, any updates on this one?

Have uuid`s in some tables as primary id. Need this too.

This should be fixed in v2.0.3, just released. Please can you check and let me know if it's working?


(node/comcam-archiver.tu.lsst.org) rm dead el7 network config

It is probably fine to leave the host on dhcp with no configuration.  NM enables dhcp on all interfaces when there is no configuration.  This host is only an NFS server and doesn't need to communicate with dds anymore.


[discussion] Simplify article: How to validate email with regex

Related to the discussion on #5305 @pkulikov @weshaggard @dasMulli @BillWagner @mairaw @rpetrusha

Hello! I wanted to just run the idea of deleting this article by you all. As we can see from the many issues opened on it, a lot of people want to have the regex tweaked to fit their specific needs.
Reading through quite a few articles on this subject, it seems that the general consensus is to not use regex to validate every email type, but instead to just use a simple structural validator (contains @ and .) and to use a verification email to truly validate the email.
Options

Delete the article
Simplify the article
??

References
Problems related to matching

https://codereview.stackexchange.com/questions/77072/regex-to-match-email-address
https://softwareengineering.stackexchange.com/questions/78353/how-far-should-one-take-e-mail-address-validation/78363#78363
https://www.regular-expressions.info/email.html

Thoughts on why you shouldn't

https://davidcel.is/posts/stop-validating-email-addresses-with-regex/
https://hackernoon.com/the-100-correct-way-to-validate-email-addresses-7c4818f24643

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 202e3f9f-a12a-53de-9069-fd469e3dbebc
Version Independent ID: fd3699bb-4881-b6b4-1275-43eed3d5f626
Content: How to: Verify that Strings Are in Valid Email Format
Content Source: docs/standard/base-types/how-to-verify-that-strings-are-in-valid-email-format.md
Service: dotnet
GitHub Login: @rpetrusha
Microsoft Alias: ronpet

I'd agree with deleting it. The question is where to redirect traffic.
@scottaddie Is there an article that already exists on the ASP.NET site that talks about creating accounts and validating the destination email addresses?

@BillWagner The closest thing we have to that is https://docs.microsoft.com/aspnet/core/security/authentication/accconfirm.

The basic regex actually does conform to an RFC. It's unfortunately the case, though, that when I wrote it, I neglected to document which RFC, and I've long ago forgotten.
My feeling is that we should keep the regex, but note its limitations -- that it doesn't validate every email address (and that a regex to validate all possible email addresses doesn't exist), and provide a few examples from customer requests for fixes to illustrate email addresses that won't validate.

I believe the previous discussion was more leaning towards finding a better example / use case for regex based validation. But so far, I don't think anyone has found a good one so far 😅.

I feel like (based on the feedback and the searches coming in to the page) people  are visiting the page because they want to validate an email and want a solution. Therefor, they don't read the page really and probably just skim straight down to the code.
Comparing it to the other example regex pages, none of them have any negative votes. This is the only one. And based on the feedback, it's because the email validation doesn't fit their need. It's not the "perfect" email validation they require. It can never be perfect.
Perhaps a first step would be to simplify the article and regex, note that it's not perfect and they must customize it to their needs, point to some other articles about regex email checking, and circle back on this in 3-4 months after we see if this change is effective?
If it's not, then we can look at deleting it?

The more we simplify the article and the regex, the less perfect it becomes. The only major simplification that I can think of is to remove support for punycode,, and I'm not really sure that it helps all that much, since the punycode portion of the validation is handled in a separate method.
I think that negative votes is likely to be the nature of the beast here. All of the how to regexes are intended to provide a solution; none are intended as tutorials. The basic problem is that the other regexes match an easily identifiable pattern, but this one can't and doesn't. Despite that, the topic still has a large number of page views and a relatively high CSAT.
Noting that the regex is not perfect is good, and that a regex cannot successfully validate all email addresses (or actually, if one could, it would be nearly incomprehensible and unmaintainable). Noting that it can be customized further, or welcoming contributors who want to customize it, is also good. But I'd tone the customization text down a bit, since customizing this regex is non-trivial, and we can't really expect that someone wants to customize their regex.

There some interesting things to consider as well:

The top keyword searches for the topics listed as related articles have nothing to do with how to validate email so I don't think they're fair comparisons.
SkyRay shows 100% CSAT for this topic for the past month. How far are we looking back to consider deleting this one?
If you look for C# valid email for example, this topic is the only article from docs that shows up on the first couple of pages

What if we just tweaked the title a bit to not indicate that our solution is complete?

I don't think we came to a consensus on this. I'm going to close it for now and if something happens (such as a lot of issues being created) I'll reopen this.

https://github.com/ea234/FkEMailValidator

No RegEx
The Fasted (see TestClass)
In German ... use Google-Translate

... the fastest (Sorry for the mistake. Maybe I should use Google-Translate too)

Reopening this since we were discussing this again before the holidays.

I think before the holiday's we left this at:

Simplify the regex, so that it's easier to read and parse.
Indicate that a regex for email is highly complicated and may never cover every possibility.
For security purposes and further validation, send a test email to the email address.

I totally agree.  There's an easier way.

@Peled-Zohar Thanks. I think that using the MailAddress class is a great idea of an alternative. I think a simple regex and then a wrapper around this class would simplify this article and make it easy to understand and use.

@Thraka  Since the MailAddress constructor validates the format for you, there really is no need for a regular expression at all - unless you have a performance-sensitive use case where a simple regex can save you from a lot of exception catching.

The article is about how to use RegEx to validate an email. So it's either delete it or simplify it. 😄 However, RegEx email validation is something commonly searched for. So someone may find it useful. I think pointing out (1) simpler things to do, such as MailAddress and (2) having a simple regex, would improve the value of the article.

MailAddress is not a good alternative, @Thraka; see #6620. Is this guidance still accurate, @davidsh?

Hi @rpetrusha !! 😄 The wrapper code for using MailAddress (to handle the exception and return true/false) could implement that logic to search for a space character.

@rpetrusha Thanks, I wasn't aware of that issue. still, I think it might be a better alternative than using a long, cumbersome, unreadable and unmaintainable regular expression, especially combined with @Thraka's idea of adding the logic to handle the space char.


Add definitions to "my_immutable_string.cpp"

Need to define the declared stuff in the header file "my_immutable_string.h".

These definitions will be their alpha versions so to speak, I will add specific issues for specific functions later


PyCharm 2022.1.2 intelligence not work

Description
cannot import module correcty even if I placed .pyd files in site-packages

I tried python3.9(recompiled with RENDERDOC_PYTHON_PREFIX64 ) and 3.6, the results are the same
python_stubs has been deleted and the intelligence not work

Steps to reproduce

Environment

RenderDoc version: 1.21 (github)
Operating System: Win11 Pro
Graphics API: DX12
Python: 3.6 or 3.9
PyCharm: 2022.1.2

I can't feasibly help to debug problems in third party programs like pycharm. This is known to work so it's not a bug, I can't help with misconfigurations apart from to suggest checking again with the documentation that explains how to set it up and double check to make sure you have followed all of the steps to ensure the python module is available and can be loaded together with the main DLL.


[doc] Add description of common switches

https://github.com/openthread/openthread/issues/4038

Should we add a column for cmake switches? It's currently in Additional information but I think it should be equivalent to Makefile switches.
Thoughts? @piotrkoziar @ludu

Should we add a column for cmake switches? It's currently in Additional information but I think it should be equivalent to Makefile switches.
Thoughts? @piotrkoziar @Ludu

@simonlingoogle To be honest, I have initially done as you described. I moved to "Additional information" because some switches do not have CMake switch equivalent.

Should we add a column for cmake switches? It's currently in Additional information but I think it should be equivalent to Makefile switches.
Thoughts? @piotrkoziar @Ludu

@simonlingoogle To be honest, I have initially done as you described. I moved to "Additional information" because some switches do not have CMake switch equivalent.

Then, we can know which switches are not supported by cmake and add them later. Isn't it a benefit?

Is it possible to do something to avoid the horizontal scroll for the table?

Is it possible to do something to avoid the horizontal scroll for the table?

@edmont I will try to do so. There is the comment above with suggestions how to accomplish that, I will start with that.
Sorry for not updating this PR for quite a long time, I think I will push some changes soon.

Is it possible to do something to avoid the horizontal scroll for the table?

Yes, I suggested some changes that should fix that in https://github.com/openthread/openthread/pull/5484#discussion_r497963256

Sorry for not updating this PR for quite a long time, I think I will push some changes soon.

@piotrkoziar , any plans to move this PR forward?

Sorry for not updating this PR for quite a long time, I think I will push some changes soon.

@piotrkoziar , any plans to move this PR forward?

Doing it right now. Sorry for the delay.

@Vyrastas I applied most of your suggestions - the table looks better now, there is no need for horizontal scrolling.

@Vyrastas @simonlingoogle thank you for the reviews! I am marking the draft as ready.

Everything LGTM


Interactive Window can't connect to the conda environment after the latest update

Environment data

VS Code version: 1.71.0
Jupyter Extension version (available under the Extensions sidebar): v2022.8.1002431955
Pylance Extension version (available under the Extensions sidebar): v2022.8.50
Windows  version: 10 21H2 19044.1889
Python and/or Anaconda version: 3.10.5 , 1.8.0
Type of virtual environment used (N/A | venv | virtualenv | conda | ...): Conda
Jupyter server running: Local

Expected behaviour
I expected to connect successfully to the environment and run codes.
Actual behaviour
After the new update, I can't use Interactive Window in VSCode. It stuck on connecting to the environment:

Steps to reproduce:
[NOTE: Self-contained, minimal reproducing code samples are extremely helpful and will expedite addressing your issue]

XXX

Logs

Output for Jupyter in the Output panel (View→Output, change the drop-down the upper-right of the Output panel to Jupyter)

XXX

I figured out that the problem is with my conda environment since I can run codes on another conda env. Does the Interactive Window depend on a special Python package?

Thanks for filing this issue, to better assist you with this issue, could you upload the output from the Jupyter output panel (you can get there using Jupyter: Show Output)

Sure, Here is what you asked for:
Visual Studio Code (1.71.0, undefined, desktop)
Jupyter Extension Version: 2022.8.1002431955.
Python Extension Version: 2022.14.0.
Workspace folder e:\AUT\Thesis
info 11:54:39.684: ZMQ install verified.
User belongs to experiment group 'jupyterTestcf'
User belongs to experiment group 'jupyterEnhancedDataViewer'
info 11:54:40.208: LSP Notebooks experiment is enabled
info 11:54:40.256: Loading webview. View is notset
info 11:54:40.257: Loading web view...
info 11:54:40.415: Webview panel created.
info 11:54:40.579: Experiment status for python is {"enabled":true,"optInto":[],"optOutFrom":[]}
info 11:54:42.647: Web view react rendered
info 11:54:45.341: Process Execution: > ~\Anaconda3\envs\z\python.exe -m pip list
> ~\Anaconda3\envs\z\python.exe -m pip list
info 11:55:11.580: Process Execution: > ~\Anaconda3\envs\Python3.10\python.exe -m pip list
> ~\Anaconda3\envs\Python3.10\python.exe -m pip list
info 11:55:26.391: Starting interactive window for resource 'e:\AUT\Thesis\MyWork\Thesis-LSTM.py'
info 11:55:26.671: Preferred Remote kernel for Interactive-1.interactive is undefined
info 11:55:26.974: Starting Jupyter Session id = 'startUsingPythonInterpreter:.jvsc74a57bd08325e60079e6fd335b0cd0610c0c15467c64caa13249a797ad422b2dc5770ad8.c:\Users\Shayan\Anaconda3\envs\Python3.10\python.exe.c:\Users\Shayan\Anaconda3\envs\Python3.10\python.exe.-m#ipykernel_launcher' (Python Path: c:\Users\Shayan\Anaconda3\envs\Python3.10, EnvType: Conda, EnvName: 'Python3.10', Version: 3.10.5) for 'Interactive-1.interactive' (disableUI=false)
info 11:55:26.977: Creating raw notebook for resource 'e:\AUT\Thesis\MyWork\Thesis-LSTM.py'
info 11:55:26.977: Computing working directory for resource 'e:\AUT\Thesis\MyWork\Thesis-LSTM.py'
info 11:55:26.987: Starting raw kernel 'Python3.10 (Python 3.10.5)' for interpreter c:\Users\Shayan\Anaconda3\envs\Python3.10\python.exe
info 11:55:27.8: Process Execution: > ~\Anaconda3\envs\Python3.10\python.exe -c "import ipykernel; print(ipykernel.__version__); print("5dc3a68c-e34e-4080-9c3e-2a532b2ccb4d"); print(ipykernel.__file__)"
> ~\Anaconda3\envs\Python3.10\python.exe -c "import ipykernel; print(ipykernel.__version__); print("5dc3a68c-e34e-4080-9c3e-2a532b2ccb4d"); print(ipykernel.__file__)"
info 11:55:27.65: Kernel launching with ports 9000,9001,9002,9003,9004. Start port is 9000
info 11:55:27.194: Process Execution: > ~\Anaconda3\envs\Python3.10\python.exe ~\.vscode\extensions\ms-toolsai.jupyter-2022.8.1002431955\pythonFiles\vscode_datascience_helpers\kernel_interrupt_daemon.py --ppid 10832
> ~\Anaconda3\envs\Python3.10\python.exe ~\.vscode\extensions\ms-toolsai.jupyter-2022.8.1002431955\pythonFiles\vscode_datascience_helpers\kernel_interrupt_daemon.py --ppid 10832
info 11:55:27.194: Process Execution: cwd: ~\.vscode\extensions\ms-toolsai.jupyter-2022.8.1002431955\pythonFiles\vscode_datascience_helpers
cwd: ~\.vscode\extensions\ms-toolsai.jupyter-2022.8.1002431955\pythonFiles\vscode_datascience_helpers
warn 11:55:27.641: 10832

info 11:55:27.648: Process Execution: > ~\Anaconda3\envs\Python3.10\python.exe -m ipykernel_launcher --ip=<IP_ADDRESS> --stdin=9003 --control=9001 --hb=9000 --Session.signature_scheme="hmac-sha256" --Session.key=b"77fc4450-2a81-4219-a01e-6d03411f78a8" --shell=9002 --transport="tcp" --iopub=9004 --f=c:\Users\Shayan\AppData\Roaming\jupyter\runtime\kernel-v2-10832datfJuPQ6UB7.json
> ~\Anaconda3\envs\Python3.10\python.exe -m ipykernel_launcher --ip=<IP_ADDRESS> --stdin=9003 --control=9001 --hb=9000 --Session.signature_scheme="hmac-sha256" --Session.key=b"77fc4450-2a81-4219-a01e-6d03411f78a8" --shell=9002 --transport="tcp" --iopub=9004 --f=c:\Users\Shayan\AppData\Roaming\jupyter\runtime\kernel-v2-10832datfJuPQ6UB7.json
info 11:55:27.648: Process Execution: cwd: e:\AUT\Thesis\MyWork
cwd: e:\AUT\Thesis\MyWork
info 11:55:28.596: ipykernel version 6.14.0 for c:\Users\Shayan\Anaconda3\envs\Python3.10\python.exe
info 11:55:28.597: ipykernel location ~\Anaconda3\envs\Python3.10\lib\site-packages\ipykernel\__init__.py for c:\Users\Shayan\Anaconda3\envs\Python3.10\python.exe
warn 11:55:31.899: StdErr from Kernel Process c:\Users\Shayan\Anaconda3\envs\Python3.10\lib\site-packages\traitlets\traitlets.py:2392: FutureWarning: Supporting extra quotes around strings is deprecated in traitlets 5.0. You can use 'hmac-sha256' instead of '"hmac-sha256"' if you require traitlets >=5.
  warn(

warn 11:55:31.899: StdErr from Kernel Process c:\Users\Shayan\Anaconda3\envs\Python3.10\lib\site-packages\traitlets\traitlets.py:2346: FutureWarning: Supporting extra quotes around Bytes is deprecated in traitlets 5.0. Use '77fc4450-2a81-4219-a01e-6d03411f78a8' instead of 'b"77fc4450-2a81-4219-a01e-6d03411f78a8"'.
  warn(

info 11:55:32.82: Kernel Output: NOTE: When using the `ipython kernel` entry point, Ctrl-C will not work.

To exit, you will have to explicitly quit this process, by either sending
"quit" from a client, or using Ctrl-\ in UNIX-like environments.

To read more about this, see https://github.com/ipython/ipython/issues/2049

To connect another client to this kernel, use:
    --existing c:\Users\Shayan\AppData\Roaming\jupyter\runtime\kernel-v2-10832datfJuPQ6UB7.json

warn 11:55:35.207: Didn't get response for requestKernelInfo after 3010ms.
info 11:55:35.209: Started kernel Python3.10 (Python 3.10.5)., (Raw session started and connected)
info 11:55:35.210: Finished connecting cea6c34d-ff13-4c8d-a28e-94e258021c3c
info 11:55:35.214: UpdateWorkingDirectoryAndPath in Kernel
info 11:55:35.219: Executing silently Code (unknown) = import types as _VSCODE_types\nimport os\nimport hashlib as _VSCODE_hashlib\nfrom IPython import get_ip

Thanks for filing this issue, to better assist you with this issue, could you upload the output from the Jupyter output panel (you can get there using Jupyter: Show Output)

Sure, Here is what you asked for:
Visual Studio Code (1.71.0, undefined, desktop)
Jupyter Extension Version: 2022.8.1002431955.
Python Extension Version: 2022.14.0.
Workspace folder e:\AUT\Thesis
info 11:54:39.684: ZMQ install verified.
User belongs to experiment group 'jupyterTestcf'
User belongs to experiment group 'jupyterEnhancedDataViewer'
info 11:54:40.208: LSP Notebooks experiment is enabled
info 11:54:40.256: Loading webview. View is notset
info 11:54:40.257: Loading web view...
info 11:54:40.415: Webview panel created.
info 11:54:40.579: Experiment status for python is {"enabled":true,"optInto":[],"optOutFrom":[]}
info 11:54:42.647: Web view react rendered
info 11:54:45.341: Process Execution: > ~\Anaconda3\envs\z\python.exe -m pip list
> ~\Anaconda3\envs\z\python.exe -m pip list
info 11:55:11.580: Process Execution: > ~\Anaconda3\envs\Python3.10\python.exe -m pip list
> ~\Anaconda3\envs\Python3.10\python.exe -m pip list
info 11:55:26.391: Starting interactive window for resource 'e:\AUT\Thesis\MyWork\Thesis-LSTM.py'
info 11:55:26.671: Preferred Remote kernel for Interactive-1.interactive is undefined
info 11:55:26.974: Starting Jupyter Session id = 'startUsingPythonInterpreter:.jvsc74a57bd08325e60079e6fd335b0cd0610c0c15467c64caa13249a797ad422b2dc5770ad8.c:\Users\Shayan\Anaconda3\envs\Python3.10\python.exe.c:\Users\Shayan\Anaconda3\envs\Python3.10\python.exe.-m#ipykernel_launcher' (Python Path: c:\Users\Shayan\Anaconda3\envs\Python3.10, EnvType: Conda, EnvName: 'Python3.10', Version: 3.10.5) for 'Interactive-1.interactive' (disableUI=false)
info 11:55:26.977: Creating raw notebook for resource 'e:\AUT\Thesis\MyWork\Thesis-LSTM.py'
info 11:55:26.977: Computing working directory for resource 'e:\AUT\Thesis\MyWork\Thesis-LSTM.py'
info 11:55:26.987: Starting raw kernel 'Python3.10 (Python 3.10.5)' for interpreter c:\Users\Shayan\Anaconda3\envs\Python3.10\python.exe
info 11:55:27.8: Process Execution: > ~\Anaconda3\envs\Python3.10\python.exe -c "import ipykernel; print(ipykernel.__version__); print("5dc3a68c-e34e-4080-9c3e-2a532b2ccb4d"); print(ipykernel.__file__)"
> ~\Anaconda3\envs\Python3.10\python.exe -c "import ipykernel; print(ipykernel.__version__); print("5dc3a68c-e34e-4080-9c3e-2a532b2ccb4d"); print(ipykernel.__file__)"
info 11:55:27.65: Kernel launching with ports 9000,9001,9002,9003,9004. Start port is 9000
info 11:55:27.194: Process Execution: > ~\Anaconda3\envs\Python3.10\python.exe ~\.vscode\extensions\ms-toolsai.jupyter-2022.8.1002431955\pythonFiles\vscode_datascience_helpers\kernel_interrupt_daemon.py --ppid 10832
> ~\Anaconda3\envs\Python3.10\python.exe ~\.vscode\extensions\ms-toolsai.jupyter-2022.8.1002431955\pythonFiles\vscode_datascience_helpers\kernel_interrupt_daemon.py --ppid 10832
info 11:55:27.194: Process Execution: cwd: ~\.vscode\extensions\ms-toolsai.jupyter-2022.8.1002431955\pythonFiles\vscode_datascience_helpers
cwd: ~\.vscode\extensions\ms-toolsai.jupyter-2022.8.1002431955\pythonFiles\vscode_datascience_helpers
warn 11:55:27.641: 10832

info 11:55:27.648: Process Execution: > ~\Anaconda3\envs\Python3.10\python.exe -m ipykernel_launcher --ip=<IP_ADDRESS> --stdin=9003 --control=9001 --hb=9000 --Session.signature_scheme="hmac-sha256" --Session.key=b"77fc4450-2a81-4219-a01e-6d03411f78a8" --shell=9002 --transport="tcp" --iopub=9004 --f=c:\Users\Shayan\AppData\Roaming\jupyter\runtime\kernel-v2-10832datfJuPQ6UB7.json
> ~\Anaconda3\envs\Python3.10\python.exe -m ipykernel_launcher --ip=<IP_ADDRESS> --stdin=9003 --control=9001 --hb=9000 --Session.signature_scheme="hmac-sha256" --Session.key=b"77fc4450-2a81-4219-a01e-6d03411f78a8" --shell=9002 --transport="tcp" --iopub=9004 --f=c:\Users\Shayan\AppData\Roaming\jupyter\runtime\kernel-v2-10832datfJuPQ6UB7.json
info 11:55:27.648: Process Execution: cwd: e:\AUT\Thesis\MyWork
cwd: e:\AUT\Thesis\MyWork
info 11:55:28.596: ipykernel version 6.14.0 for c:\Users\Shayan\Anaconda3\envs\Python3.10\python.exe
info 11:55:28.597: ipykernel location ~\Anaconda3\envs\Python3.10\lib\site-packages\ipykernel\__init__.py for c:\Users\Shayan\Anaconda3\envs\Python3.10\python.exe
warn 11:55:31.899: StdErr from Kernel Process c:\Users\Shayan\Anaconda3\envs\Python3.10\lib\site-packages\traitlets\traitlets.py:2392: FutureWarning: Supporting extra quotes around strings is deprecated in traitlets 5.0. You can use 'hmac-sha256' instead of '"hmac-sha256"' if you require traitlets >=5.
  warn(

warn 11:55:31.899: StdErr from Kernel Process c:\Users\Shayan\Anaconda3\envs\Python3.10\lib\site-packages\traitlets\traitlets.py:2346: FutureWarning: Supporting extra quotes around Bytes is deprecated in traitlets 5.0. Use '77fc4450-2a81-4219-a01e-6d03411f78a8' instead of 'b"77fc4450-2a81-4219-a01e-6d03411f78a8"'.
  warn(

info 11:55:32.82: Kernel Output: NOTE: When using the `ipython kernel` entry point, Ctrl-C will not work.

To exit, you will have to explicitly quit this process, by either sending
"quit" from a client, or using Ctrl-\ in UNIX-like environments.

To read more about this, see https://github.com/ipython/ipython/issues/2049

To connect another client to this kernel, use:
    --existing c:\Users\Shayan\AppData\Roaming\jupyter\runtime\kernel-v2-10832datfJuPQ6UB7.json

warn 11:55:35.207: Didn't get response for requestKernelInfo after 3010ms.
info 11:55:35.209: Started kernel Python3.10 (Python 3.10.5)., (Raw session started and connected)
info 11:55:35.210: Finished connecting cea6c34d-ff13-4c8d-a28e-94e258021c3c
info 11:55:35.214: UpdateWorkingDirectoryAndPath in Kernel
info 11:55:35.219: Executing silently Code (unknown) = import types as _VSCODE_types\nimport os\nimport hashlib as _VSCODE_hashlib\nfrom IPython import get_ip

@shayandavoodii = Does that same conda environment work when you try to use it for a notebook (command jupyter: create notebook)? The only package I know of that we need is IPykernel which should get installed when it is first launched, so you could try re-installing that package if it doesn't work in a notebook either.

great to hear, thanks for the update!


Nextflow docker permission issues

From the README:
One currently unresolved issue: If you upload a file while the application is deployed through Docker, and then later attempt to upload a file while the application is deployed locally, the application will likely run into permission issues related to the nf-ncov-voc cache. You can fix this by removing all cache files in the nf-ncov-voc/ directory:
$ rm -r results work .nextflow .nextflow.log* capsule  framework  plugins  secrets  tmp
You may have to use sudo.

@anwarMZ found this:
Running Nextflow using a Docker-in-Docker approach can indeed lead to permission issues, especially with files and directories that are shared between the host and the containers. Let's address this issue specifically for a Docker-in-Docker setup:
Docker-in-Docker Volume Mounting: Ensure that the .nextflow directory is properly mounted into the outer Docker container. You might need to add a volume mount for this directory.
Permissions in Docker: The user inside the Docker container might not have the same UID as your host user, leading to permission issues.
Workaround using NXF_HOME: Set the NXF_HOME environment variable to a directory that is definitely writable within the Docker container.
Here are some steps to try:
Modify your Docker run command to include a volume mount for the Nextflow home directory:
docker run -v /path/on/host/.nextflow:/root/.nextflow ...
Inside your Docker container, set the NXF_HOME environment variable to a known writable location:
export NXF_HOME=/tmp/nextflow
mkdir -p $NXF_HOME
chmod 777 $NXF_HOME
If you're using a Docker Compose file, you can add these environment variables and volumes there:
version: '3'
services:
nextflow:
image: your-nextflow-image
environment:
- NXF_HOME=/tmp/nextflow
volumes:
- /path/on/host/.nextflow:/tmp/nextflow
If you're running Nextflow from within a script inside the Docker container, you can set the NXF_HOME at the beginning of the script:
#!/bin/bash
export NXF_HOME=/tmp/nextflow
mkdir -p $NXF_HOME
chmod 777 $NXF_HOME
nextflow run ...
Ensure that the user running Nextflow inside the Docker container has write permissions to the directory specified by NXF_HOME.
After making these changes, try running your Nextflow pipeline again.
If you're still encountering issues, please provide:
Your Docker run command or Docker Compose file
The Dockerfile you're using for your Nextflow image
The exact error message you're seeing
The output of ls -la $NXF_HOME from inside the Docker container
This additional information will help us further diagnose and resolve the permission issue in your Docker-in-Docker setup.


Embedded structs

Hi,
I would like to handle this use case :
type BaseItem struct {
	ID int `json:"id"`

	lossless.JSON `json:"-"`
}

type NamedItem struct {
	BaseItem
	Name string `json:"name"`
}

func (t NamedItem) MarshalJSON() ([]byte, error) {
	return t.JSON.MarshalJSON(t)
}

func (t *NamedItem) UnmarshalJSON(data []byte) error {
	return t.JSON.UnmarshalJSON(t, data)
}

const data = `
{
	"id": 1,
	"name": "foobar",
	"extra": "data"
}`

func main() {

	var item NamedItem
	if err := json.Unmarshal([]byte(data), &item); err != nil {
		panic(err)
	}
	str, err := json.MarshalIndent(item, "  ", "  ")
	if err != nil {
		panic(err)
	}
	fmt.Println(string(str))
}

The actual result is :
{
    "BaseItem": {
      "id": 0
    },
    "extra": "data",
    "id": 1,
    "name": "foobar"
  }

Is there a way to better handle embedded structs ?

Unfortunately no, that's not handled by the library.
I don't use this library anymore and am not actively maintaining it, so I probably won't fix this.  If you're interested and want to tackle it yourself, I will gladly take a patch for it.

I'm not exactly sure how it would be done, but it would involve checking for the Anonymous flag on the reflected StructField in json-lossless's syncFromStruct though: https://golang.org/pkg/reflect/#StructField


Part of CC-1391: Figure out why CI tests end early for Kotlin (SQLite)

Need to log out why SDK failed to download the tester artifact.

@andy1li are you able to reliably trigger this error? I thought that exceptions from async functions are automatically bubbled up anyway 🤔

@rohitpaulk TBH, I'm not sure. That's why I'm trying to log it out, in order to be sure.
The fact that the CI just silently stopped is beyond me right now.

Cool. Would recommend trying to replicate this - you can create a test repo and have that build a branch of course-sdk. Would be faster than waiting for PR reviews etc.

Probably not in the right direction.


[Feature Request]  Add the ability to filter the display of recipes according to the actor's abilities not just permissions

I would need he ability to filter the display of recipes according to the actor's abilities not just permissions, is it possible to add in the recipe configuration a piece of code exactly equal to the "anyOf" feature of the components to prepare a macro with a boolean return value to decide who can or cannot view the recipe ?
An example some recipes only make sense for mages , so I would like to be able to enter a code to check if the actor class is "mage".
return actor.class.name === "Mage"

A feature the same as "anyOf" on components would be perfect.

Have to think about it. This feature shares a common space with the existing required field.
So your request is actually make a) allow anyOf on required fields. b) useable and available also filters by required input.

... not enough extend anyOf add actor variable to the macro

uh oh doesnt work that simple as anyOf can also be ingredient and now it might be an actor source so i would also need to consume this when the ingredient is consumed so this would actually allow to create ingredients that can consume actor resources. that will not be possible as macro as is -> 2 paths another anyOf especially for requirements or go down the rabbit hole and build what is needed to make anyOf also consume actor things... e.g. xp... yeah you see need to think about it :-)


CUDA version is out of date

Version 1.5.2 of ML.NET requires CUDA 10.1 with cuDNN 7.6.5 for that version in order to work now.
This page is also out of date: https://github.com/dotnet/machinelearning/blob/master/docs/api-reference/tensorflow-usage.md

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 0495cff9-97a6-68ba-504c-ec7fcbc69a9c
Version Independent ID: 0c7c0298-37e3-f945-fee5-fc6ccd7a362d
Content: How to install GPU support in Model Builder - ML.NET
Content Source: docs/machine-learning/how-to-guides/install-gpu-model-builder.md
Product: dotnet-ml
GitHub Login: @luisquintanilla
Microsoft Alias: luquinta

Hi @frogcrush
Thanks for raising this issue. Does working with the older versions of these libraries throw an error or just warnings?

Hi @frogcrush
Thanks for raising this issue. Does working with the older versions of these libraries throw an error or just warnings?

It throws errors and won't work with the older versions.

It throws errors and won't work with the older versions.

Thanks for that clarification.

Thanks for that clarification.

Stale issue fixed by #23718 & dotnet/machinelearning#5594
Thanks @frogcrush


Use r21.05 version of Triton backend API

To increase compatibility of DALI Triton backend we build against the oldest working Triton backend API

CI MESSAGE: [3139167]: BUILD FAILED


Company Facet selector not working

I select all companies, and then want to deselect MarkLogic & MarkLogic Corp to see who is external. After select all, deselect MarkLogic, it changes to "Select None" and "MarkLogic" so it ONLY has MarkLogic selected.

I deployed an improvement for this issue, but it's not a complete fix. The use case you described now works. However, these steps will give you a counter-intuitive result:

Select All on the company facet
deselect MarkLogic (and related entries)
click Select All again

This will ensure that all values showing in the facet are selected (for company, they would be anyway, since the MarkLogic values disappear; each person has only one company). Values that were not showing (because they weren't values that appeared in the last search) will not be included in the next search. The solution is to Select None, which clears the Company facet and gets back the full list.

thanks for the workaround!


[WIP] Quotes

Hi @sofiafaro! I've been going through the Joy docs and I thought that one of the next things Mirth should have is the ability to talk about quoted programs.
So far, I have been able to extend the lexer and elaborator to support quoted types. I chose the syntax [ a b -- c d ] to match the value level quotes from Joy, which allowed me to delegate most of the work to the lexer/elaborator for morphism types.
I think the next step would be to support quotes at the value level, which would involve, at least

Extending the value-level elaborator. I think quotes should be treated kind of like string and int literals at elab-arrow-step!, but I'm not sure how to get my hands on the type of the quoted program to elab-stack-push! it.

Generating code for quotes. I think this one might be a matter of generating the contents of the quote as a function, then pushing a function pointer onto the stack. I'm not sure if C's lack of first-class functions might bite us here, though.

Finally, we'd need something like the i combinator. I believe its type would be *a [ *a -- *b] -- *b, and the implementation would take the function pointer from (2) and call it.

Thanks for your time reading this! It's okay if this doesn't match what you have in mind for Mirth.

Thanks for your comments! I rewrote history a bit so things look cleaner.
I now understand why this isn't the best fit for higher-order words, but I'm glad to hear it might still be useful.

The TQuote case isn't necessary (unless there's something I'm missing!), this is what TMorphism is for.

You're completely right. I think my original reasoning was that a higher order word would need to be able to tell the difference between a series of words and a quoted series of words, but that was based on a misunderstanding of the elaborator.

Need to disambiguate between tensor types and morphism types when elaborating [...] at the type level.

Done! It was really easy thanks to sig-has-dashes? :)

Need to make sure we don't allow an LPAREN matched to an RBRACKET nor an LBRACKET matched to an RPAREN in the lexer.

Whoops. It's fixed now :)


Graphical Glitch on Windows 10

[X] I am on the latest Hyper.app version
[X] I have searched the issues of this repo and believe that this is not a duplicate

Windows 10 1809 build: 17763.678:
Hyper 3.0.2 (Stable):
Gist:
N/A (CMD+ALT+I on macOS, CTRL+SHIFT+I elsewhere):
The issue is reproducible in vanilla Hyper.app:

Issue

Random graphical glitches that usually happen when resizing the window, or when maximizing window. Some text persists (only graphically) in random locations, when clicked with the left-mouse button, the glitch disappears.
The glitch also appears when using nano on a remote server. The bottom controls of nano persist (only graphically) even after exiting nano.
Not sure if the same behavior can be observed on Linux or MacOS. I haven't tested it on either.
Glitch

After Clicking on the glitch

Happens to me aswell.
Also I've randomly experienced glitch where sometimes last one/two lines of output cannot be seen until I resize window or type in another command or press ^C

These are the same as issues #3791 and #3792

@deuks Yup, seems so.

I am having the same issue. I would be curious to know if anyone isn't having this issue, to see if we can compare configs to see what the issue might be.

closing as duplicate


[Key Vault Admin] Recordings

This PR should pass. This is needed for:

[Key Vault Admin] Tests #11010
[Key Vault Admin] Pre-release work #10799

@iscai-msft @christothes thank you!


Aweful Keybinding

I want to write a text in chat and the "Overlay" say no, you bind the key so you cant write a big L as example.
Please mak the bindings only work when i hover over an item.
sry for my bad English

I try but "alt gr" doesnt work.


[Validate] minCount does not work for 1

Good Day,
I was using the minCount validation to validate a multiple select field. initially I just wanted to make sure that the field was not empty, so I tried to use the empty but that did not work .Then I tried the minCount[1] and it did not validate. Finally I changed the 1 to 2 and it worked but it is checking for 2 elements.
I am trying to use JSFiddle to post some sample code but I am not getting it to display the multi select dropdown.
EDIT: Updated the JSFiddle:
has minCount set to 1: http://jsfiddle.net/rduvhn8u/79/
has minCount set to 2: http://jsfiddle.net/rduvhn8u/78/

Fixed in next

I've added examples for each validation type to docs.
http://semantic-ui.com/behaviors/form.html#rule-examples

Thanks so much! Great examples!


143 unrelevant devices get deleted by cb delete entity

Since the IoTAgent API does not provide filter functionality, I implement this in the IoTAgentClient of FiLiP. In this way the function get_device_list( ) can now return the devices filtered by entity_id.

@djs0109 I made some minor modifications and added some more tests. Please double-check if everything works as expected.

LGTM

@djs0109 thank you very much!


Posix demo use heap_3 in cmake

Description

Use heap_3.c in Posix_GCC demo cmakefile to align with makefile.

Test Steps

Before this PR. There will be malloc failed.

Checklist:

[x] I have tested my changes. No regression in existing tests.

Related Issue

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@chinglee-iot @aggarg The changes looks good to me. However, having a quick look at the posix example, it seems like we are maintaining support for CMake and Make based build system. Please note that CMake has generator for Unix Makefile. If the CMakeLists.txt is in parity with features of Makefile then we can drop support for Makefile and CMake generator to generate the Makefile to continue supporting Make based build. Any thoughts on this?

You are right @urutva - we just need to update some GH actions to use cmake and not make.


Error: Wrong item profit in cost overview

u using tsm or auctionator?

I used TSM and modified to use dbrecent

I see a similar number after switching to Auctionator and reloaded.

The last time I check was one week ago and it was displaying correctly.

have you recently been on the tournament realm?

Yes. Didn't thought of that as the potential reason. Any way I can fix this?

Found the answer in discord (thanks to Sky#0833):
use /tsm debug clearitemdb to clear cache.

you found somethink like that for Auctinator? Have same problem with it, was on tourament realm

Was Auctionator/TSM bug


Do not propagate default tvm url config

relates to https://github.com/adobe/aio-lib-web/pull/149 and https://github.com/adobe/aio-lib-core-tvm/pull/66/files
replaces https://github.com/adobe/aio-cli-plugin-app/pull/389/files
Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):
Types of changes

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[x] I have signed the Adobe Open Source CLA.
[x] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[x] I have read the CONTRIBUTING document.
[x] I have added tests to cover my changes.
[x] All new and existing tests passed.

Resolved comment
Test AIO_CLI_ENV=stage DEBUG=@adobe/aio-lib-core-tvm* with link chain:
aio => this pr => https://github.com/adobe/aio-lib-web/pull/149 => https://github.com/adobe/aio-lib-core-tvm/pull/66
Will deploy against stage s3


Replace Evns.Elide and Aborts.Elide with dependant types

See #231

I've played with the change locally and inference seems great now! I think we can consider this a fix for https://github.com/getkyo/kyo/issues/215 as well. With this new approach, an explicit Nothing type parameter produces an Envs[Nothing], which I'd say is a reasonable behavior. Previously, Elide was completely removing Envs from the pending set.
@johnhungerford was the removal of layers intended?

@fwbrasil I removed layers for Aborts and Envs because I'm not sure how to implement it properly. Since the output type of Envs[A].run will depend on the type of effect you're running it on, it's not quite right to say the layer "removes Envs[A]". Given that Layer is up in the air as an approach (at this point I think we should get rid of it), I didn't spend time on it.

@johnhungerford sounds good. I can follow up with a PR to remove layers for now.

Perhaps it's still possible to support Layers via a more generalized Memoization effect. I will need to think if there are any limitations to generalized effect memoizations.


Custom engine with sequenced acquisitions

Hi all,
We are finally diving into sub-classing the acquisition engine and the new approaches for on-the-fly and file saving. I think with all of these tools (again, thank you so much for your work), we should be able to meet on our needs.
I had a question about callbacks and saving images when doing a sequence acquisition. I see in the current acquisition code (here) that all of the images are collected from the sequence before they are returned.
We run some fairly intensive acquisitions where we need to stream the data to disk because we cannot hold all of the sequence in RAM. Any suggestions on how to handle this in our own acquisition engine?
In our current code, we:

Setup hardware sequenced acquisition with camera as master
Create Zarr store with optimized chunk size
Start sequenced acquisition through the core
pop "N" images (set by Zarr chunk size) out of the circular buffer
Stop pulling images from the buffer and write to the Zarr store
Repeat 4 & 5 until no more images remain in buffer

Looking at this really helpful post, I see that we can connect to frameReady, but it wasn't clear to me about how to do that for a sequenced acquisition.
Thanks!

Hey Doug, great question.  I can imagine a few possible solutions to this, and you can guide me to what seems like it would work best for you.

the code you linked could very easily be improved by changing the signature of exec_event to return an Iterable[PImagePayload] rather than a sequence, that way it could yield frames as they're popped off the buffer.  That is how it should have been implemented to begin with and will be an easy improvement.
the chunk of code that does the popping could be extracted into a new method that you could more easily override in a subclass if you wanted to fully customize the popping/yielding of frames
as for "Stop pulling images from the buffer and write to the Zarr store", you may want to simply circumvent using frameReady altogether for your needs (this remains to be seen).  There's technically nothing stopping you from doing the writing to zarr in your acquisition engine directly, but if possible, i would encourage you to try to resist that for now, since going through the frameReady emission on the runner will allow you to use more of the built-in-functionality.  (let's continue discussing that bit)

i would also encourage you to have a look at the Zarr PR https://github.com/pymmcore-plus/pymmcore-plus/pull/263 ... it's not far from merging, and you could perhaps use that instead of implementing your own zarr logic.  I believe it should be flexible enough, but have a look at the __init__ and see if you'd need more things exposed.  The way that would be used is something like this:
writer = OMEZarrWriter("file.zarr", ...)
with mda_listeners_connected(writer):
     core.mda.run(sequence)

but again, for your needs, it's definitely possible that something in there is simply not performant enough, in which case we should see whether it can be fixed.
those are some thoughts... let's keep discussing

the code you linked could very easily be improved by changing the signature of exec_event to return an Iterable[PImagePayload] rather than a sequence, that way it could yield frames as they're popped off the buffer.  That is how it should have been implemented to begin with and will be an easy improvement.

Sounds good!

the chunk of code that does the popping could be extracted into a new method that you could more easily override in a subclass if you wanted to fully customize the popping/yielding of frames.

I don't know if this is necessary, as the logic that is there pretty much matches ours. Plus, we need to sub-class the exec_event anyways for our use because we are using our own NI-DAQ class that mmcore doesn't handle.

as for "Stop pulling images from the buffer and write to the Zarr store", you may want to simply circumvent using frameReady altogether for your needs (this remains to be seen).  There's technically nothing stopping you from doing the writing to zarr in your acquisition engine directly, but if possible, i would encourage you to try to resist that for now, since going through the frameReady emission on the runner will allow you to use more of the built-in-functionality.  (let's continue discussing that bit)

I'm 100% on board with using the built-in functionality. I want us to do this "right" the first time so we can give it as an example to others both within and outside my group.

i would also encourage you to have a look at the Zarr PR #263 ... it's not far from merging, and you could perhaps use that instead of implementing your own zarr logic. I believe it should be flexible enough, but have a look at the __init__ and see if you'd need more things exposed. The way that would be used is something like this:

I definitely think we should re-use your zarr code. We will look into the __init__ and see if we need anything else exposed.

We also need to do on-the-fly processing of the data to deskew/rotate the images from our OPM. Even "snaps" for the OPM microscope setup require sequenced acquisitions because we are always using the DAQ to blank the laser(s) and apply a voltage to the galvo driver.
In addition to the saving pattern above, for display we need something like:
img_processor = DeskewOpm(acq_settings)
with mda_listeners_connected(img_processor):
     core.mda.run(sequence)

Ideally, the img_processor needs to know the number of channels being acquired ahead of time (driven by changes the user makes to the GUI) and then yield one layer per channel of the processed data back to Napari. In this case, it will be on-the-fly deskewed data using a Numba-accelerated function. We already do this our fully custom GUI and it works fine.
Beyond that, we are still figuring out how to make the above process loop until the user hits "stop". I don't have a lot of experience with signals, etc... so I'm not super helpful to group that way. In our current code, we check if the user has clicked the stop button or changed the acquisition settings every time the code yields a deskewed image for display. If no changes, the same sequenced acquisition is run again. If there are setup changes, the sequencing is setup again before running. If stopped, the sequence stops.
That does mean the GUI doesn't respond to the stop button until data is yielded for our current strategy.
Which one do think makes sense to tackle first? We have a draft of the custom engine, maybe we should test that a bit more and share with you?

ok @dpshepherd, frameReady should now be immediately emitted with #290.  will cut a new release soon.  will comment on the processing in a moment

regarding on-the-fly processing, or indeed any sort of serial processing before display or saving, this is something that I've intentionally left out of pymmcore-plus for the moment, knowing it would be an important topic.  You can currently do this sort of thing yourself by chaining together or subclassing processors (and the pattern I'll show in a moment will probably continue to work indefinitely), but I also hope to provide a nicer interface eventually.  Here's the deal:

currently, every "handler" you provide to mda_listeners_connected will be passed arguments to their event handlers that are unaffected by other handlers.  There is an intermediate ThreadRelay object that looks something like this:
graph LR;
    core.mda.events -->|frameReady| ThreadRelay;
    ThreadRelay --> Handler1;
    ThreadRelay --> Handler...;
    ThreadRelay --> HandlerN;

at the moment, napari-micromanager itself doesn't use this pattern, but i intend to use that in napari-micromanager.  The idea being that the image data is dumped to the ThreadRelay and control returns immediately to acquisition, so that any sort of processing/saving (that doesn't need to modify the next image acquisition event) is handled asynchronously and doesn't slow down the imaging.
This means that if you wanted one of your handlers (whether it be a display or saving handler) to process data first, you currently could subclass like this:
class SavingHandler:
    def frameReady(self, frame):
        print("Saving frame")

class ProcessingMixin:
    def frameReady(self, frame):
        # as shown, this mixin can only be used with a
        # super class that has a frameReady method
        print("processing frame")
        super().frameReady(frame)

class MyProcessor(ProcessingMixin, SavingHandler):
    ...

img_processor = MyProcessor()
with mda_listeners_connected(img_processor):
     core.mda.run(sequence)

To be clear, I don't think that's a pattern that everyone should have to do forever... but it's one way that this could work until we have a more formal framework for chaining together processors (with the possibility to fork the chain after a processor into, say, display, and saving handlers).  That said, it's a low level construct that should allow you to do pretty much anything you want.

Ideally, the img_processor needs to know the number of channels being acquired ahead of time (driven by changes the user makes to the GUI) and then yield one layer per channel of the processed data back to Napari.

the way that the handler pattern works is that any methods on your handler that have names that match the events emitted by mda.events will be connected.  So, to get information about the number of channels (or anything about the currently executing sequence), you can add a sequenceStarted method to your handler.  Note also that the second argument to frameReady is an instance of MDAEvent... and if you used useq.MDASequence to generate your list of events, then the event.sequence  attribute will point to the parent sequence that created it.  You can see an example of us using that in the OMEZarrWriter here.  Here's a quick example of both of those patterns
class MyProcessor:
    # grab info about the full experiment at the beginning
    def sequenceStarted(sequence: MDASequence, metadata: dict):
        self.n_channels = len(s.channels)

    def frameReady(self, frame, event):
        # if not using the sequenceStarted method
        if event.sequence:
            # grab info from event.sequence
            self.n_channels = len(event.sequence.channels)

about to take off on a flight... so will address remaining questions soon

hey @dpshepherd, just checking in.  How are things going?   Anything waiting on my feedback or action at this point?


"import os" and dependency specification - Error with Pod Initialization

Is this a BUG REPORT or FEATURE REQUEST?:
BUG REPORT
What happened:
I have python code with
<<<
import os
def getfolder(event, context):
os.listdir('...')
...

During function deployment, I specify depency as "os" in requirements file.  The pod initialization fails with error/crashloop.
If I do not specify dependency file, the POD gets created successfully and function may be executed successfully.
kubeless function deploy getfolder --runtime python2.7 --from-file getfolder.py --handler getfolder.getfolder --dependencies=getfolder.txt
cat getfolder.txt
os
kubectl get pods
NAME                         READY   STATUS                  RESTARTS   AGE
getfolder-76bf7f6849-lq2d7   0/1     Init:CrashLoopBackOff   2          48s
kubectl logs getfolder-76bf7f6849-lq2d7
Error from server (BadRequest): container "getfolder" in pod "getfolder-76bf7f6849-lq2d7" is waiting to start: PodInitializing
I believe this behavior is specific to "os" import, while other dependency specifications worked.  I suspect, "os" is imported by default internally as the pod logs shows some evidence in certain scenarios.
What you expected to happen:
POD to be running and function in ready state
How to reproduce it (as minimally and precisely as possible):
A Python code with "import os" and dependency specification during function deployment
Anything else we need to know?:
Environment:

Kubernetes version (use kubectl version): v1.16.15
Kubeless version (use kubeless version):  v1.0.7-dirty
Cloud provider or physical cluster: physical cluster

Indeed, os is not a pip dependency, you don't need to add it since it's already available. You can deploy your function as kubeless function deploy getfolder --runtime python2.7 --from-file getfolder.py --handler getfolder.getfolder.
Closing this, let me know if you still find issues.


Is the latest version aar not uploaded to Maven warehouse

Report

[ ] I have searched existing issues and this is not a duplicate

Issues and Steps to Reproduce
https://mvnrepository.com/artifact/com.facebook.yoga/yoga?repo=jcenter
jcenter the latest version is 1.16.0
Expected Behavior
Describe what you expected would happen.
Actual Behavior
Describe what actually happened.
Link to Code
If you have some code that maintainers can clone/test for themselves, bugs can be resolved much faster. Please paste a link here.
When applicable, use this fiddle to post a web repro.

Please see https://mvnrepository.com/artifact/com.facebook.yoga.android/yoga-layout/1.19.0 for the latest published version. A newer version should be published soon as well.


Integrate llvm-project and bump dependencies.

LLVM_COMMIT="0aee67ad4e6e750351ecf608d7d056fc49cb9348" MHLO_COMMIT="53d10d99c36549f0a41d131829df91352d938d60" TF_COMMIT="49ffedb82a7e6597b5e5dae9ec6f948fab858842"

Did you forget to push your mhlo branch to the fork?

Did you forget to push your mhlo branch to the fork?

Done. iree-org/iree-mhlo-fork/tree/patch_iree_mhlo_fork_bump_20230316


Put the .NET connector into the new template

@irinel-dan, when you'd be able to provide your review on this PR? Thanks


Interface Dupe Bug

Issue description:
Items can be duped at will, and non-stackable items can be forced to stack
What happens:
Changing the item filter in the interface causes and existing items inside of that same type, to be converted into the "new" filtered item.
What you expected to happen:
No dupe.
Steps to reproduce:
This youtube video shows the exact steps.
https://www.youtube.com/watch?v=g6wlwpAQHvA
For anyone who can't watch, basically you put a stack of anything inside the storage system, then open the interface and add an item to the filter list, then add 1 of that item to the Interface's inventory (top bar). The Interface will move this item to the bottom bar (because of the filter setting). Without removing the item from the bottom bar, change the filtered item to the item you wish to dupe. The system will convert the bottom bar item into a stack the new duped item, removing the original stack of items you put in the system at first. So you can convert a stack of cobble into a stack of anything at will, as long as you have 1 of that item to start with.
Version (make sure you are on the latest version before reporting):
1.2.25 (This is the latest version for 1.10.2. It also the default version used in FTB Beyond)

Minecraft: 1.10.2 (FTB Beyond)
Forge: <IP_ADDRESS>1
Refined Storage: 1.2.25

Does this issue occur on a server? [yes/no]
Yes (tested it on my own server after watching the video)
If a (crash)log is relevant for this issue, link it here:
[pastebin/gist/etc link here]

Duplicate of:

#1206
#892

Fixed for 1.11. Will come to 1.10.2 soon as well.

Has this been pushed to 1.10.2 yet?

1.10 is unsupported.

Then you shouldn't have stated that it was fixed in the 1.2.26 changelog.

It was fixed when I tested it.

Okay thank you for your quick response, we'll continue to investigate the problem on our end. Although, it may be worth keeping in mind that the mod is not fixed for 1.10.2.


.helm\plugins\helm-gcs\scripts\pull.sh: %1 is not a valid Win32 application.

Hitting the following while adding repo:
helm repo add oceana-gcp gs://my-team-helm-repo --debug
Error: Looks like "gs://my-team-helm-repo" is not a valid chart repository or cannot be reached:
fork/exec C:\Users\me\.helm\plugins\helm-gcs\scripts\pull.sh: %1 is not a valid Win32 application.

$ ~/.helm/plugins/helm-gcs/bin/helm-gcs.exe version
version: 0.2.0
commit: 12854b9ec61b242dba21786181b9af5a4e7692c6
date: 2018-05-31T11:11:26Z

helm version
Client: &version.Version{SemVer:"v2.11.0", GitCommit:"2e55dbe1fdb5fdb96b75ff144a339489417b146b", GitTreeState:"clean"}
Server: &version.Version{SemVer:"v2.11.0", GitCommit:"2e55dbe1fdb5fdb96b75ff144a339489417b146b", GitTreeState:"clean"}

I've tried using helm-gcs.exe directly and here's the output
init is successful:
$ cd ~/.helm/plugins/helm-gcs/bin
$ ./helm-gcs.exe init gs://helmbucket/charts --debug --service-account="C:/service-account.json"
time="2018-10-16T15:44:56+01:00" level=debug msg="create a repository with index file at gs://helmbucket/charts/index.yaml"
time="2018-10-16T15:44:58+01:00" level=debug msg="push index file"

pull fails:
$ ./helm-gcs.exe pull gs://helmbucket/charts --debug --service-account="C:/service-account.json"
Error: storage: object doesn't exist
Usage:
  helm-gcs pull gs://bucket/path [flags]

Flags:
  -h, --help   help for pull

Global Flags:
      --debug                    activate debug
      --service-account string   service account to use for GCS

storage: object doesn't exist

I'm using GitBASH 2.16.1.windows.4 on Windows 10.
I've tried using both service account json and gcloud auth application-default login

Hi @dkirrane
Sorry for the inconvenience, I'll look at it as soon as possible

Did you get any time to look at this?
I'll try Linux version now to see if I can workaround it for now

Sorry for the delay, I'm very busy and completely forgot.
There may be a problem with the shell scripts on Windows, I need to investigate further.
In the meantime, you can use helm-gcs.exe but your pull command is incorrect, it should be:
./helm-gcs.exe pull gs://helmbucket/charts/<your-chart-0.1.0.tgz> --debug --service-account="C:/service-account.json" > your-chart-0.1.0.tgz
I know this command is not very convenient, I'm working on that.

Any updates on this?
When you have alot of charts then the workaround becomes a little ..cumbersome ;)

I have the same issue. It kinda sucks that the plugin doesn't work on windows at all

@Dyhr : I just ended up installing it in WSL 🤷♂

@Klaboe, thanks


Modify the wording when a new Ledger Live update is available

📝 Description
_The orange banner used to inform Ledger Live users about a new available version does not clearly indicate that Ledger Live will get re-opened automatically. If a user quickly relaunches the app before the update is done, it will fail.
Current behavior

The new wording suggested with this PR is : “New update available, it will install and relaunch Ledger Live automatically when you close the app”
❓ Context

JIRA or GitHub link: LIVE-8997

✅ Checklist
Pull Requests must pass the CI and be code reviewed. Set as Draft if the PR is not ready.

[ ] npx changeset was attached.
[ ] Covered by automatic tests.
[ ] Impact of the changes:

...

🧐 Checklist for the PR Reviewers

[ ] The code aligns with the requirements described in the linked JIRA or GitHub issue.
[ ] The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
[ ] There are no undocumented trade-offs, technical debt, or maintainability issues.
[ ] The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
[ ] Any new dependencies have been justified and documented.
[ ] Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

/generate-screenshots


Make git-xl installable with pip

I threw this together so I could use it locally but realized others might find it useful as well, so here you go. This makes git-xl installable with pip, and usable on macOS and linux without the need for pyinstaller.
With this change, you can do:
pip install git+https://github.com/xlwings/git-xl

to install this package directly from git into Python's packages, and then:
python -m gitxl install

to install it (or run any of the other CLI commands).

Thanks! I like the idea, but the tests are currently failing: https://github.com/xlwings/git-xl/actions/runs/3409486259/jobs/5671317549
Also, I'd probably go ahead and use the more future proof way of building packages based on pyproject.toml instead of setup.py.

Also, this can be turned into a proper cli command (xltrail instead of python -m gitxl) and the version string shouldn't be hardcoded, but will be replaced by the CI pipeline...
I can look into these things, but just don't have a lot of time right now.

Hey,
I have added support for cli commands and installation with pipx in my fork (https://github.com/watercrossing/git-xl).
This makes installation even easier:
pipx install git+https://github.com/watercrossing/git-xl.git (later this would be just pipx install git-xl to install from pypi,
and then git-xl install.
Perhaps @MilesCranmer can merge my commit into their repo to add it to this PR?

Hey @watercrossing,
Feel free to create a new PR with your + my commits (if desired)! I unfortunately don't have time to clean up this one, and ended up switching to an alternate solution anyways.
Cheers,
Miles

I unfortunately don't have time to clean up this one, and ended up switching to an alternate solution anyways.

@MilesCranmer Might I ask what this alternate solution was? I'm trying to find a good way to version control excel files on a Mac.


Create Mk

Why:
Closes:

What's being changed (if available, include any code snippets, screenshots, or gifs):

Check off the following:

[x] I have reviewed my changes in staging, available via the View deployment link in this PR's timeline (this link will be available after opening the PR).

For content changes, you will also see an automatically generated comment with links directly to pages you've modified. The comment won't appear if your PR only edits files in the data directory.

[x] For content changes, I have completed the self-review checklist.

I don't no what hapinneng ito this
On Thu, 2 May 2024, 22:02 github-actions[bot], @.***>
wrote:

Closed #32772 https://github.com/github/docs/pull/32772.
—
Reply to this email directly, view it on GitHub
https://github.com/github/docs/pull/32772#event-12683727325, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/A6N6QFR5GIH2ES6F23ABS7LZAJBNZAVCNFSM6AAAAABHDGOMDWVHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJSGY4DGNZSG4ZTENI
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>


Fix a sub-Blueprints deps bug.

This change fixes a bug where directories that could contain a Blueprints file
but currently do not were not being added as a dependency.  This meant that if
a Blueprints file were added to that directory it would not automatically get
picked up by the build.

LGTM


2.24 Android Screenshots show removed renewal text

Where to find the issue

https://www.coronawarn.app/assets/screenshots/2-24/en/android/TestCertificateDetailsFragment__2.png
https://www.coronawarn.app/assets/screenshots/2-24/de/android/TestCertificateDetailsFragment__2.png
https://www.coronawarn.app/assets/screenshots/2-24/en/android/RecoveryCertificateDetailsFragment_recovered_2.png
https://www.coronawarn.app/assets/screenshots/2-24/de/android/RecoveryCertificateDetailsFragment_recovered_2.png

Describe the issue
The text "Please make sure to get a new digital certificate in time" (EN) or "Bitte bemühen Sie sich rechtzeitig darum, einen neuen digitalen Nachweis ausstellen zu lassen." (DE) has been removed in CWA 2.24 however there are screenshots published for the 2.24 release which still show this text.

See PR https://github.com/corona-warn-app/cwa-app-android/pull/5282 and issue https://github.com/corona-warn-app/cwa-documentation/issues/899

Suggested change
Replace the screenshots with correct ones taken from CWA 2.24 Android.

@MikeMcC399 thanks for opening this issue. With the abovementioned PR, this has been fixed.


ENH: Add CLI entry point test

Add CLI entry point test.

It is unclear to me the proper way to test this.
Have looked in other nipreps repositories and found different ways to test main:
nondefaced-detector: https://github.com/nipreps/nondefaced-detector/blob/abf20d244de51a9a73933cbf3cf64fad163f6fa0/nondefaced_detector/cli/tests/main_test.py#L10C25-L11C50
sdcflows: https://github.com/nipreps/sdcflows/blob/357ef3e683f05a1722c113b1dc94ceed2ed02a53/sdcflows/cli/tests/test_find_estimators.py#L144
Do we need to add an argv=None to main ? e.g.
https://github.com/nipreps/sdcflows/blob/357ef3e683f05a1722c113b1dc94ceed2ed02a53/sdcflows/cli/main.py#L26
https://github.com/nipreps/migas-server/blob/24536bbd46423a94d3dae29702d32af4435f3ed7/migas/server/cli.py#L30
https://github.com/nipreps/nibabies/blob/7b1e91d5d84094129caa29e16803f842605eaa23/nibabies/cli/mcribs.py#L24
Comments are welcome.

It is unclear to me the proper way to test this.
Have looked in other nipreps repositories and found different ways to test main: nondefaced-detector: https://github.com/nipreps/nondefaced-detector/blob/abf20d244de51a9a73933cbf3cf64fad163f6fa0/nondefaced_detector/cli/tests/main_test.py#L10C25-L11C50 sdcflows: https://github.com/nipreps/sdcflows/blob/357ef3e683f05a1722c113b1dc94ceed2ed02a53/sdcflows/cli/tests/test_find_estimators.py#L144
Do we need to add an argv=None to main ? e.g. https://github.com/nipreps/sdcflows/blob/357ef3e683f05a1722c113b1dc94ceed2ed02a53/sdcflows/cli/main.py#L26 https://github.com/nipreps/migas-server/blob/24536bbd46423a94d3dae29702d32af4435f3ed7/migas/server/cli.py#L30 https://github.com/nipreps/nibabies/blob/7b1e91d5d84094129caa29e16803f842605eaa23/nibabies/cli/mcribs.py#L24
Comments are welcome.

Using argv=None when passing it to the main function seems like the best choice to me. @effigies  @oesteban , do either of you have strong opinions on this?

Sorry to ping you again his morning @effigies @oesteban.

@effigies Maybe you have more insight into https://github.com/nipreps/eddymotion/pull/184#issuecomment-2080813005. Suggestions are welcome. Thanks.

@effigies, can you have a look if you meet some bandwidth?

Sure, had a look and just went ahead and patched. I think the main(argv=None) pattern is simple enough. I moved the monkeypatching just to set the command to eddymotion for realism (otherwise checking output would show usage: pytest [-h] ...).
Ran into an empty array error here:
src/eddymotion/cli/run.py:47: in main
    _ = estimator.estimate(
src/eddymotion/estimator.py:170: in estimate
    fixed, moving = _prepare_registration_data(
src/eddymotion/estimator.py:336: in _prepare_registration_data
    _to_nifti(dwframe, affine, moving)
src/eddymotion/estimator.py:243: in _to_nifti
    data = _advanced_clip(data)
src/eddymotion/estimator.py:223: in _advanced_clip
    a_min = np.percentile(denoised[denoised > 0] if nonnegative else denoised, p_min)

Simple fix to change that to >=0, which matches the variable.


Additional css not included on login page

Version information

Laravel: v5.7.9
Voyager: v1.1.7

Description

The additional css files are not included on the login page, while they are included on (most?) other pages. This shows that the additional css file setting in itself is working, but it can't be used to alter the style of the login page.

Yes that is correct. The login page is a stand-alone view and doesn't use the main layout that the rest of Voyager uses. The explanation for that is simple, it's a completely different layout.
Having said that, you can just override that one view file (same as any other page, which our docs cover) and edit it as needed.  I'd prefer not to add additional_css to that view due to the high likelihood of conflict between styles for that page and styles for everything else.


completed reserve chron sort

There is one issue that I'm stuck with -- it's the clearing of the input box after I add the task.  I used $setPristine, but it doesn't seem to reset the input box (even those the state is set to pristine).

@dkannenberg Let's chat aboutyour issue tomorrow (Monday).

Fixed up that code from last night to get it to work.  Thanks for walking it through with me.


Runtime error: Unexpected value '[object Object]' imported by the module 'AppModule'. Please add a @NgModule annotation.

I am using angular-cli. I am using this generator and I am very happy with it except that I have a runtime error when I build my app using --prod. I have set all the "dependencies" for @angular/... to "4.1.3" in my app's package.json. I have set all the "devDependencies" for @angular/... to "4.1.3" in my library's package.json and "peerDependencies" for @angular/core to "4.1.3" in src/package.json. But it does not solve the problem. Can anyone offer any help? Thanks.
{Edit} I am using the instructions in the "Consuming your library during development" section to npm link because we do not yet have our own package repo. Could this be the problem?

For anyone who might also encounter this problem...
"NgModule from one node_modules does not equal NgModule from another node_modules even if they're the same version"
... and there is the problem.
To solve this...
you need to have a central location for all your app and lib dependencies, for example, a global npm cache.
For each shared dependency, go into the global cache's node_modules/[dependency] folder, node_modules/@angular/core for example, and create an npm link by executing sudo npm link.
Then delete the @angular folder that exists in all of your app and lib node_modules folders and from the node_modules folders execute sudo npm link [dependency], so sudo npm link @angular/core for example, for each dependency.
Rebuild your libs, then rebuild your apps.

thanks for the solution. I hope we'll get a easier way to solve that soon !

Thank you for reporting.
See #113 for a solution. Closing this issue but feel free to re-open if needed 👍


2_2_floorplan_io failed with error "Number of pins 2114 exceeds max possible 2084"

Describe the bug
I've tried to run a design with very dense IO pins, and 2_2_floorplan_io failed with error "Number of pins 2114 exceeds max possible 2084".
First, when I set the DIE_AREA to0 0 51 51, it runs OK with gui_final below.

Then, I try to constrait the IO pins to a smaller interval, leaving the DIE_AREA unchanged. It runs OK too. You can see below there's some free space at the boundaries.

In this case, it should be OK if I just set DIE_AREA smaller. So I run again with DIE_AREA set to 0 0 50 50. It fails at the 2_2_floorplan_io stage with error "Number of pins 2114 exceeds max possible 2084".

I don't understand. If I can constraint pins into a apparently smaller interval and it runs OK, why I get limited when I set DIE_AREA just 1um smaller?
Expected Behavior
I expect when I set DIE_AREA a little smaller, it should still runs OK, instead of limiting.
Maybe the pin number limitation should be much loose? Or there is some way for me to change the limitaion?
Environment
caitianhao@c111:/OpenROAD-flow-scripts/tools/OpenROAD$ ./etc/Env.sh
tee: build/openroad-env.log: Permission denied
Unknown git commit, this is not a git repository.

Please make sure that you have the latest code changes and add the commit
hash in the description.

kernel: Linux 5.4.0-146-generic
os: Ubuntu 20.04.5 LTS (Focal Fossa)
cmake version 3.24.2
CMake Warning at CMakeLists.txt:96 (message):
  OpenROAD git describe failed, using sha1 instead

CMake Error: Could not open file for write in copy operation /OpenROAD-flow-scripts/tools/OpenROAD/include/ord/Version.hh.tmp
CMake Error: : System Error: Inappropriate ioctl for device
CMake Error at CMakeLists.txt:133 (configure_file):
  configure_file Problem configuring file

-- The CXX compiler identification is GNU 9.4.0
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Check for working CXX compiler: /usr/bin/c++ - skipped
-- Detecting CXX compile features
-- Detecting CXX compile features - done
-- OpenROAD version: HEAD-HASH-NOTFOUND
-- System name: Linux
-- Compiler: GNU 9.4.0
-- Build type: RELEASE
-- Install prefix: /usr/local
-- C++ Standard: 17
-- C++ Standard Required: ON
-- C++ Extensions: OFF
-- Found GTest: /usr/lib/x86_64-linux-gnu/libgtest.a
-- The C compiler identification is GNU 9.4.0
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Check for working C compiler: /usr/bin/cc - skipped
-- Detecting C compile features
-- Detecting C compile features - done
-- Performing Test C_COMPILER_SUPPORTS__-Wall
-- Performing Test C_COMPILER_SUPPORTS__-Wall - Success
-- Performing Test CXX_COMPILER_SUPPORTS__-Wall
-- Performing Test CXX_COMPILER_SUPPORTS__-Wall - Success
-- Performing Test C_COMPILER_SUPPORTS__-Wno-array-bounds
-- Performing Test C_COMPILER_SUPPORTS__-Wno-array-bounds - Success
-- Performing Test CXX_COMPILER_SUPPORTS__-Wno-array-bounds
-- Performing Test CXX_COMPILER_SUPPORTS__-Wno-array-bounds - Success
-- Performing Test C_COMPILER_SUPPORTS__-Wno-nonnull
-- Performing Test C_COMPILER_SUPPORTS__-Wno-nonnull - Success
-- Performing Test CXX_COMPILER_SUPPORTS__-Wno-nonnull
-- Performing Test CXX_COMPILER_SUPPORTS__-Wno-nonnull - Success
-- Performing Test C_COMPILER_SUPPORTS__-Wno-maybe-uninitialized
-- Performing Test C_COMPILER_SUPPORTS__-Wno-maybe-uninitialized - Success
-- Performing Test CXX_COMPILER_SUPPORTS__-Wno-maybe-uninitialized
-- Performing Test CXX_COMPILER_SUPPORTS__-Wno-maybe-uninitialized - Success
-- Performing Test C_COMPILER_SUPPORTS__-Wno-format-overflow
-- Performing Test C_COMPILER_SUPPORTS__-Wno-format-overflow - Success
-- Performing Test CXX_COMPILER_SUPPORTS__-Wno-format-overflow
-- Performing Test CXX_COMPILER_SUPPORTS__-Wno-format-overflow - Success
-- Performing Test C_COMPILER_SUPPORTS__-Wno-unused-variable
-- Performing Test C_COMPILER_SUPPORTS__-Wno-unused-variable - Success
-- Performing Test CXX_COMPILER_SUPPORTS__-Wno-unused-variable
-- Performing Test CXX_COMPILER_SUPPORTS__-Wno-unused-variable - Success
-- Performing Test C_COMPILER_SUPPORTS__-Wno-unused-function
-- Performing Test C_COMPILER_SUPPORTS__-Wno-unused-function - Success
-- Performing Test CXX_COMPILER_SUPPORTS__-Wno-unused-function
-- Performing Test CXX_COMPILER_SUPPORTS__-Wno-unused-function - Success
-- Performing Test C_COMPILER_SUPPORTS__-Wno-write-strings
-- Performing Test C_COMPILER_SUPPORTS__-Wno-write-strings - Success
-- Performing Test CXX_COMPILER_SUPPORTS__-Wno-write-strings
-- Performing Test CXX_COMPILER_SUPPORTS__-Wno-write-strings - Success
-- Performing Test C_COMPILER_SUPPORTS__-Wno-sign-compare
-- Performing Test C_COMPILER_SUPPORTS__-Wno-sign-compare - Success
-- Performing Test CXX_COMPILER_SUPPORTS__-Wno-sign-compare
-- Performing Test CXX_COMPILER_SUPPORTS__-Wno-sign-compare - Success
-- Performing Test C_COMPILER_SUPPORTS__-Wno-deprecated
-- Performing Test C_COMPILER_SUPPORTS__-Wno-deprecated - Success
-- Performing Test CXX_COMPILER_SUPPORTS__-Wno-deprecated
-- Performing Test CXX_COMPILER_SUPPORTS__-Wno-deprecated - Success
-- Performing Test C_COMPILER_SUPPORTS__-Wno-c++11-narrowing
-- Performing Test C_COMPILER_SUPPORTS__-Wno-c++11-narrowing - Failed
-- Performing Test CXX_COMPILER_SUPPORTS__-Wno-c++11-narrowing
-- Performing Test CXX_COMPILER_SUPPORTS__-Wno-c++11-narrowing - Failed
-- Performing Test C_COMPILER_SUPPORTS__-Wno-register
-- Performing Test C_COMPILER_SUPPORTS__-Wno-register - Failed
-- Performing Test CXX_COMPILER_SUPPORTS__-Wno-register
-- Performing Test CXX_COMPILER_SUPPORTS__-Wno-register - Success
-- Performing Test C_COMPILER_SUPPORTS__-Wno-format
-- Performing Test C_COMPILER_SUPPORTS__-Wno-format - Success
-- Performing Test CXX_COMPILER_SUPPORTS__-Wno-format
-- Performing Test CXX_COMPILER_SUPPORTS__-Wno-format - Success
-- Performing Test C_COMPILER_SUPPORTS_CMake Error: Could not open file for write in copy operation /OpenROAD-flow-scripts/tools/OpenROAD/src/sta/include/sta/StaConfig.hh.tmp
CMake Error: : System Error: Inappropriate ioctl for device
CMake Error at src/sta/CMakeLists.txt:465 (configure_file):
  configure_file Problem configuring file

_-Wno-reserved-user-defined-literal
-- Performing Test C_COMPILER_SUPPORTS__-Wno-reserved-user-defined-literal - Failed
-- Performing Test CXX_COMPILER_SUPPORTS__-Wno-reserved-user-defined-literal
-- Performing Test CXX_COMPILER_SUPPORTS__-Wno-reserved-user-defined-literal - Failed
-- Performing Test C_COMPILER_SUPPORTS__-fpermissive
-- Performing Test C_COMPILER_SUPPORTS__-fpermissive - Failed
-- Performing Test CXX_COMPILER_SUPPORTS__-fpermissive
-- Performing Test CXX_COMPILER_SUPPORTS__-fpermissive - Success
-- Performing Test C_COMPILER_SUPPORTS__-x
-- Performing Test C_COMPILER_SUPPORTS__-x - Failed
-- Performing Test CXX_COMPILER_SUPPORTS__-x
-- Performing Test CXX_COMPILER_SUPPORTS__-x - Failed
-- Performing Test C_COMPILER_SUPPORTS__c++
-- Performing Test C_COMPILER_SUPPORTS__c++ - Failed
-- Performing Test CXX_COMPILER_SUPPORTS__c++
-- Performing Test CXX_COMPILER_SUPPORTS__c++ - Failed
-- Performing Test C_COMPILER_SUPPORTS__-Wno-unused-but-set-variable
-- Performing Test C_COMPILER_SUPPORTS__-Wno-unused-but-set-variable - Success
-- Performing Test CXX_COMPILER_SUPPORTS__-Wno-unused-but-set-variable
-- Performing Test CXX_COMPILER_SUPPORTS__-Wno-unused-but-set-variable - Success
-- TCL library: /usr/lib/x86_64-linux-gnu/libtcl.so
-- TCL header: /usr/include/tcl/tcl.h
-- TCL readline library: /usr/lib/x86_64-linux-gnu/libtclreadline.so
-- TCL readline header: /usr/include/x86_64-linux-gnu
-- Found SWIG: /usr/bin/swig (found suitable version "4.1.0", minimum required is "3.0")
-- Using SWIG >= 4.1.0 -flatstaticmethod flag for python
-- Found Boost: /usr/local/lib/cmake/Boost-1.80.0/BoostConfig.cmake (found version "1.80.0")
-- boost: 1.80.0
-- Found Python3: /usr/include/python3.8 (found version "3.8.10") found components: Development Development.Module Development.Embed
-- Found ZLIB: /usr/lib/x86_64-linux-gnu/libz.so (found version "1.2.11")
-- Found Threads: TRUE
-- spdlog: 1.8.1
-- Found BISON: /usr/bin/bison (found version "3.5.1")
-- Could NOT find Doxygen (missing: DOXYGEN_EXECUTABLE)
-- STA version: 2.4.0
-- STA git sha:
-- System name: Linux
-- Compiler: GNU 9.4.0
-- Build type: RELEASE
-- Build CXX_FLAGS: -O3 -DNDEBUG
-- Install prefix: /usr/local
-- Found FLEX: /usr/bin/flex (found version "2.6.4")
-- TCL library: /usr/lib/x86_64-linux-gnu/libtcl.so
-- TCL header: /usr/include/tcl/tcl.h
-- Check if compiler accepts -pthread
-- Check if compiler accepts -pthread - yes
-- SSTA: 0
-- STA executable: /OpenROAD-flow-scripts/tools/OpenROAD/src/sta/app/sta
-- GPU is not enabled
-- Found re2: /opt/or-tools/lib/cmake/re2/re2Config.cmake (found version "9.0.0")
-- Found Clp: /opt/or-tools/lib/cmake/Clp/ClpConfig.cmake (found version "1.17.7")
-- Found Cbc: /opt/or-tools/lib/cmake/Cbc/CbcConfig.cmake (found version "2.10.7")
-- Found Eigen3: /usr/local/share/eigen3/cmake/Eigen3Config.cmake (found version "3.4.0")
-- Found SCIP: /opt/or-tools/lib/cmake/scip/scip-config.cmake (found version "8.0.1")
-- GUI is enabled
-- Found Boost: /usr/local/lib/cmake/Boost-1.80.0/BoostConfig.cmake (found version "1.80.0") found components: serialization
-- Found OpenMP_CXX: -fopenmp (found version "4.5")
-- Found OpenMP: TRUE (found version "4.5")
-- Could NOT find VTune (missing: VTune_LIBRARIES VTune_INCLUDE_DIRS)
-- Found Boost: /usr/local/lib/cmake/Boost-1.80.0/BoostConfig.cmake (found suitable version "1.80.0", minimum required is "1.78")
-- Found Boost: /usr/local/lib/cmake/Boost-1.80.0/BoostConfig.cmake (found version "1.80.0") found components: serialization system thread
-- TCL readline enabled
-- Tcl Extended disabled
-- Python3 enabled
-- Configuring incomplete, errors occurred!

To Reproduce
https://drive.google.com/file/d/1b1ZJ-tue9nnEg246WAT4PlvKqhZVN7-z/view?usp=sharing
Relevant log output
No response
Screenshots
No response
Additional Context
No response

@DrSpace Could you try the branch from this PR: https://github.com/The-OpenROAD-Project/OpenROAD/pull/3156?
With the configuration you're using in this design, the number of pins is greater than the number of available positions to place the pins. However, your script manually places pins in pre-determined positions, using multiple layers for vertical and horizontal directions. The previous check wasn't accounting for the pre-placed pins.
But notice that you may have trouble if you don't use the pre-placed pins. You can increase the number of available positions by defining multiple layers for horizontal and vertical pins (in the place_pins command, options -hor_layers and -ver_layers), or reducing the min distance between the pins with the option -min_distance.
More details about these options are described here: https://github.com/The-OpenROAD-Project/OpenROAD/tree/master/src/ppl#place-all-pins

It seem that the ORFS use an older version of OpenRoad, Would it be better to update the submodule of ORFS?


Generator helloworld works

#4

Welcome to Codecov :tada:
Once merged to your default branch, Codecov will compare your coverage reports and display the results in this comment.
Thanks for integrating Codecov - We've got you covered :open_umbrella: