[CT-1669] [Bug] type_timestamp() returns incorrect value for Postgres and Snowflake

Is this a new bug in dbt-core?

[X] I believe this is a new bug in dbt-core
[X] I have searched the existing issues, and I could not find an existing issue for this bug

Current Behavior

Create a column in Postgres or Snowflake with type type_timestamp(),

select
    cast(date_col as {{ type_timestamp() }}) as date_timestamp,
...

This renders to
cast(date_col as TIMESTAMP) as date_timestamp,

Then during testing, retrieve column types from

{%- set columns_in_relation = adapter.get_columns_in_relation(model) -%}

However,
{% for column in columns_in_relation %}
   {{ log((column.dtype | upper), info=True) }}
{% endfor %}

for this column returns:
TIMESTAMP WITHOUT TIME ZONE

This makes testing data types using the built in types impossible.
For context, in dbt-expectations, we've had to override type_timestamp() for that reason and would like to deprecate that in favor of the dbt-core implementation.
Expected Behavior
type_timestamp() should return the native data type, e.g. TIMESTAMP WITHOUT TIME ZONE
In dbt-expectations, we use this right now:
{# timestamp  -------------------------------------------------     #}
{%- macro type_timestamp() -%}
  {{ return(adapter.dispatch('type_timestamp', 'dbt_expectations')()) }}
{%- endmacro -%}

{% macro default__type_timestamp() -%}
    timestamp
{%- endmacro %}

{% macro snowflake__type_timestamp() -%}
    timestamp_ntz
{%- endmacro %}

{% macro postgres__type_timestamp() -%}
    timestamp without time zone
{%- endmacro %}

Steps To Reproduce
See steps above. Tested on Postgres, BigQuery and Snowflake.
Relevant log output
No response
Environment
- OS: MacOS 13
- Python: 3.9.9
- dbt: 1.3.1

Which database adapter are you using with dbt?
postgres, snowflake, bigquery
Additional Context
No response

I realize the above matches the docs, however I'm not sure why the described behavior is useful or desired.

@clausherther Thanks for reaching out about this!
To make sure I'm following with you, does the following capture the difference between what you're actually seeing versus your expectations?

Adapter
Macro
Actual
Expected

postgres
type_timestamp()
TIMESTAMP
timestamp without time zone

snowflake
type_timestamp()
TIMESTAMP
timestamp_ntz

bigquery
type_timestamp()
TIMESTAMP
timestamp

Assuming so, here's some more info:
Migration of cross-database type_* macros from dbt-utils to dbt-core
I think that the last implementation of type_timestamp() in dbt_utils actually aligned with your expectations. It looks nearly identical to what you have in dbt-expectations here.
We tried to do some consolidation of data type logic in this PR (by taking advantage of api.Column.translate_type), and it changed the literal strings being rendered in some cases:

https://github.com/dbt-labs/dbt-core/pull/5428

Here's a chain of references explaining why type_timestamp() consistently yields TIMESTAMP for all the adapters you mentioned:

core/dbt/include/global_project/macros/utils/data_types.sql#L16-L24
core/dbt/adapters/base/column.py#L23-L25
core/dbt/adapters/base/column.py#L9-L16
plugins/postgres/dbt/adapters/postgres/relation.py#L26
https://github.com/dbt-labs/dbt-redshift/blob/4890c0f9bb4305dac1d686aca2f43cffc2f89cce/dbt/adapters/redshift/relation.py#L17
https://github.com/dbt-labs/dbt-snowflake/blob/e18c501175c84d5b08d66244533e636a5a04dba1/dbt/adapters/snowflake/column.py#L8
https://github.com/dbt-labs/dbt-bigquery/blob/a19f8e1a8ffa5edf1ca1a9255641c68ea2c10f95/dbt/adapters/bigquery/column.py#L12-L20

Next steps
I'm actually a bit surprised we haven't heard problems about this! I wonder if it's because TIMESTAMP somehow still ended up with the same final data types in each database?
We've got a few options:

Do nothing and accept things as-is
Change the implementation of type_timestamp() via an update to TYPE_LABELS
Change the implementation of type_timestamp() directly by moving away from api.Column.translate_type
Something else not listed above.

I don't know what the consequences would be if we update the TYPE_LABELS in the relevant databases -- it might break something. Moving away from api.Column.translate_type for type_timestamp() might be fully backwards compatible :shrug: ?
As next steps, we should try out each of the options above to determine the consequences of each.
Heads-up: we all be out of the office until Jan 3rd, so my responses will be delayed until after that.

@dbeatty10 thanks for the detailed reply! Let's chat more after the New Year.
I think the reason you probably haven't heard much about this is that when you use type_timestamp() to cast a column, TIMESTAMP works just fine across those databases and results in the correct type being created. You only run into issues if you compare what type_timestamp returns and what the db stores as the more explicit version of that. I think the most common way people that today is by using the dbt-expectations tests and in dbt-expectations we override that type_timestamp macro today so we might have been hiding that issue ;)

@clausherther I gave this some more thought, and I think we should implement Option 2 listed above:

Change the implementation of type_timestamp() via an update to TYPE_LABELS

Let me know what you think!
Pros

It would align with the data types returned by the information_schema.columns view (or equivalent for the data platform)
type_timestamp() could be used for other purposes, potentially the column data type within model contracts
It would restore the original literal string values returned bytype_timestamp() that existed in dbt-utils previously (e.g., TIMESTAMP_NTZ instead of TIMESTAMP for Snowflake, etc)
It would relieve the burden on dbt-expectations to override the type_timestamp macro here
Will align with the comments here
If we knew then what we know now, we probably would have added/updatedTYPE_LABELS in these PRs:

https://github.com/dbt-labs/dbt-core/pull/5428
https://github.com/dbt-labs/dbt-bigquery/pull/214
https://github.com/dbt-labs/dbt-redshift/pull/130
https://github.com/dbt-labs/dbt-snowflake/pull/183
https://github.com/dbt-labs/dbt-spark/pull/380

Cons

If anyone has been relying on the literal string value of type_timestamp() macro to always be TIMESTAMP, then it will be a breaking change for them.

But this would be an odd thing to do -- I'd expect most/all people to want to use it in the manner you described instead.

Implementation hints
The proposed implementation would involve coordinated PRs in 5 different repos: dbt-core, dbt-bigquery, dbt-redshift, dbt-snowflake, and dbt-spark.
I were to implement this, here's how I might go about it:

Copy TYPE_LABELS from here into:

PostgresColumn
RedshiftColumn
SnowflakeColumn
SparkColumn.

Update the 2nd part of "TIMESTAMP": "TIMESTAMP" within each adapter to be the desired data type. e.g., something like:

PostgresColumn - "TIMESTAMP": "TIMESTAMP WITHOUT TIME ZONE"
RedshiftColumn - "TIMESTAMP": "TIMESTAMP"
SnowflakeColumn - "TIMESTAMP": "TIMESTAMP_NTZ"
SparkColumn - "TIMESTAMP": "TIMESTAMP"

Include functional tests to establish the expected behavior going forward

See the schema test from here and here for inspiration

dbt-bigquery is already has TIMESTAMP here, so I don't think its TYPE_LABELS needs any changes. But any new functional test should be added within that adapter too in order to verify!


row id generator spin cause heartbeat timeout

Describe the bug
A clear and concise description of what the bug is.
When running ci-1cn-1fe with datagen, when sequence id reaches its upper bound, the row id generator will spin, and heartbeat timeouts when spinning.
create materialized source s1 (v1 int, v2 float) with (
  connector = 'datagen',
  fields.v1.min = '1',
  fields.v1.max = '100000',
  fields.v2.min = '1',
  fields.v2.max = '100000',
  datagen.rows.per.second='400000',
  datagen.split.num = '12') row format json;
CREATE_SOURCE

2022-08-12T07:50:05.966115Z  WARN risingwave_source::row_id: Sequence for row-id reached upper bound, spin loop.
2022-08-12T07:50:05.968500Z  WARN risingwave_source::row_id: Sequence for row-id reached upper bound, spin loop.
2022-08-12T07:50:05.970643Z  WARN risingwave_source::row_id: Sequence for row-id reached upper bound, spin loop.
2022-08-12T07:50:05.972776Z  WARN risingwave_source::row_id: Sequence for row-id reached upper bound, spin loop.
2022-08-12T07:50:14.911147Z  WARN risingwave_rpc_client::meta_client: Failed to send_heartbeat: timeout deadline has elapsed
2022-08-12T07:50:21.962466Z  WARN risingwave_rpc_client::meta_client: Failed to send_heartbeat: timeout deadline has elapsed
2022-08-12T07:50:23.893243Z  WARN risingwave_source::row_id: Sequence for row-id reached upper bound, spin loop.
2022-08-12T07:50:24.084308Z  WARN risingwave_source::row_id: Sequence for row-id reached upper bound, spin loop.
2022-08-12T07:50:24.086435Z  WARN risingwave_source::row_id: Sequence for row-id reached upper bound, spin loop.
2022-08-12T07:50:24.088554Z  WARN risingwave_source::row_id: Sequence for row-id reached upper bound, spin loop.
2022-08-12T07:50:24.090666Z  WARN risingwave_source::row_id: Sequence for row-id reached upper bound, spin loop.
2022-08-12T07:50:24.092801Z  WARN risingwave_source::row_id: Sequence for row-id reached upper bound, spin loop.
2022-08-12T07:50:24.094924Z  WARN risingwave_source::row_id: Sequence for row-id reached upper bound, spin loop.
2022-08-12T07:50:24.096023Z  WARN risingwave_source::row_id: Sequence for row-id reached upper bound, spin loop.
2022-08-12T07:50:23.906150Z  WARN risingwave_source::row_id: Sequence for row-id reached upper bound, spin loop.
2022-08-12T07:50:24.153228Z  WARN risingwave_source::row_id: Sequence for row-id reached upper bound, spin loop.
2022-08-12T07:50:24.156129Z  WARN risingwave_source::row_id: Sequence for row-id reached upper bound, spin loop.
2022-08-12T07:50:24.158205Z  WARN risingwave_source::row_id: Sequence for row-id reached upper bound, spin loop.
2022-08-12T07:50:24.160285Z  WARN risingwave_source::row_id: Sequence for row-id reached upper bound, spin loop.
2022-08-12T07:50:24.162356Z  WARN risingwave_source::row_id: Sequence for row-id reached upper bound, spin loop.
2022-08-12T07:50:24.164422Z  WARN risingwave_source::row_id: Sequence for row-id reached upper bound, spin loop.
2022-08-12T07:50:24.166490Z  WARN risingwave_source::row_id: Sequence for row-id reached upper bound, spin loop.
2022-08-12T07:50:24.566411Z  WARN risingwave_source::row_id: Sequence for row-id reached upper bound, spin loop.
2022-08-12T07:50:24.568322Z  WARN risingwave_source::row_id: Sequence for row-id reached upper bound, spin loop.
2022-08-12T07:50:24.570883Z  WARN risingwave_source::row_id: Sequence for row-id reached upper bound, spin loop.
2022-08-12T07:50:24.571997Z  WARN risingwave_source::row_id: Sequence for row-id reached upper bound, spin loop.
2022-08-12T07:50:24.573100Z  WARN risingwave_source::row_id: Sequence for row-id reached upper bound, spin loop.
2022-08-12T07:50:24.575243Z  WARN risingwave_source::row_id: Sequence for row-id reached upper bound, spin loop.
2022-08-12T07:50:24.578157Z  WARN risingwave_source::row_id: Sequence for row-id reached upper bound, spin loop.
2022-08-12T07:50:24.580043Z  WARN risingwave_source::row_id: Sequence for row-id reached upper bound, spin loop.
2022-08-12T07:50:24.594805Z  WARN risingwave_source::row_id: Sequence for row-id reached upper bound, spin loop.
2022-08-12T07:50:24.596010Z  WARN risingwave_source::row_id: Sequence for row-id reached upper bound, spin loop.
2022-08-12T07:50:24.598104Z  WARN risingwave_source::row_id: Sequence for row-id reached upper bound, spin loop.
2022-08-12T07:50:24.600206Z  WARN risingwave_source::row_id: Sequence for row-id reached upper bound, spin loop.
2022-08-12T07:50:24.602329Z  WARN risingwave_source::row_id: Sequence for row-id reached upper bound, spin loop.
2022-08-12T07:50:24.604465Z  WARN risingwave_source::row_id: Sequence for row-id reached upper bound, spin loop.
2022-08-12T07:50:24.606596Z  WARN risingwave_source::row_id: Sequence for row-id reached upper bound, spin loop.
2022-08-12T07:50:34.658987Z  WARN risingwave_source::row_id: Sequence for row-id reached upper bound, spin loop.
2022-08-12T07:50:34.662169Z  WARN risingwave_source::row_id: Sequence for row-id reached upper bound, spin loop.
2022-08-12T07:50:34.664301Z  WARN risingwave_source::row_id: Sequence for row-id reached upper bound, spin loop.
2022-08-12T07:50:34.666410Z  WARN risingwave_source::row_id: Sequence for row-id reached upper bound, spin loop.
2022-08-12T07:50:34.668509Z  WARN risingwave_source::row_id: Sequence for row-id reached upper bound, spin loop.
2022-08-12T07:50:34.670609Z  WARN risingwave_source::row_id: Sequence for row-id reached upper bound, spin loop.
2022-08-12T07:50:34.672704Z  WARN risingwave_source::row_id: Sequence for row-id reached upper bound, spin loop.
2022-08-12T07:50:34.674803Z  WARN risingwave_source::row_id: Sequence for row-id reached upper bound, spin loop.
2022-08-12T07:50:42.913260Z  WARN risingwave_rpc_client::meta_client: Failed to send_heartbeat: timeout deadline has elapsed
2022-08-12T07:50:47.871312Z  WARN risingwave_source::row_id: Sequence for row-id reached upper bound, spin loop.
2022-08-12T07:50:47.873534Z  WARN risingwave_source::row_id: Sequence for row-id reached upper bound, spin loop.
2022-08-12T07:50:47.875658Z  WARN risingwave_source::row_id: Sequence for row-id reached upper bound, spin loop.
2022-08-12T07:50:47.877771Z  WARN risingwave_source::row_id: Sequence for row-id reached upper bound, spin loop.
2022-08-12T07:50:47.879914Z  WARN risingwave_source::row_id: Sequence for row-id reached upper bound, spin loop.
2022-08-12T07:50:47.881101Z  WARN risingwave_source::row_id: Sequence for row-id reached upper bound, spin loop.
2022-08-12T07:50:47.883619Z  WARN risingwave_source::row_id: Sequence for row-id reached upper bound, spin loop.

To Reproduce
Steps to reproduce the behavior.
Run ci-1cn-1fe with datagen for about 10m.
Expected behavior
A clear and concise description of what you expected to happen.
Heartbeat should not fail.
Additional context
Add any other context about the problem here.

Not sure if they are related yet, need more investigation.

I always saw this line flooding the log file in the recent benches I did.


⚠ Turnos 24x7 has degraded performance

In 5b4afb6, Turnos 24x7 (https://reservas-dev.alternativasinteligentes.com/) experienced degraded performance:

HTTP code: 200
Response time: 931 ms

Resolved: Turnos 24x7 performance has improved in 4585930.


Use ButtonView also on iOS

Enable the button View logic also for iOS to apply own styles and different texts.

would be nice to get this fixed and merged in


Add Dolby's Info

Adds the following events or companies:

Checklist

[X] I have updated the event or company counts
[] I have put the most recent relevant date in the "Last Update" column
[] I have linked to the article about the change, not the company's website

Hey for some reason your PR is removing a company? Could you try rebasing?


Cinder implementation

Hi folks,
thank you for the fast response to my last requests. However, I have a few more things I would like to add to your async OpenStack client.

Seems that Accept and Content Type headers are missing in the client. (see https://github.com/DreamLab/AsyncOpenStackClient/commit/34f648dbcc131756ce3d2c53ed5bdd5d589d21fc)

In case you are interested to support also the volumes API of Cinder, please have a look at https://github.com/DreamLab/AsyncOpenStackClient/commit/ac62956b8610d734c4e8de1eb529655429c2f74c.

I would really appreciate if you consider to merge this request as well.
Thanks and best regards,
Manuel

We're good to go then

It has been released under 0.7.0 tag


Add support for inlineStyles in options argument

This is a combination of the features in #12, #15 and #24 rolled into one diff. Based on the work of @adamtal3 in #24.

Nice combo! 😸

Looks great! This is much more customizable than my suggestion which makes it much better :smile:
What about https://github.com/sstur/draft-js-import-element/pull/13 ? Do you wish to implement something similar for the html import?
Thanks for your effort!

Thanks to @coopy for the testing he did in #15. I took an almost identical approach here.

@adamtal3: I do have a plan for https://github.com/sstur/draft-js-import-element/pull/13. I'll continue this conversation over there. Thanks!


Is it possible to get data from a time period ?

@patrickelectric you can look at _data/locations -- it's available in .yml formaat.

Thanks!


router instance

how is it possible to create router using Router.create to pass around to components? I am trying to pass router to my custom network layer to redirect to login when server authentication failed.

See: https://github.com/rackt/react-router/issues/1720 - there's nothing specific to the Relay integration about getting a router instance.


spotUser action not work

I tried to use this api: https://hyperliquid.gitbook.io/hyperliquid-docs/for-developers/api/exchange-endpoint#transfer-from-spot-account-to-perp-account-and-vice-versa
My request payload: {"action":{"type":"spotUser","classTransfer":{"usdc":1100000,"toPerp":true}},"nonce":1733910442843,"signature":{"r":"0xddef40cbaac1c2fa452afa28854e7a1eec2da7bf0e8aa04254ec8b863f5965fc","s":"0x13d147f843fddf3f2e8361ed8f1767631e86e25a0e274f1afd75ca12698e4031","v":27}}
I got a respone of error 422: Failed to deserialize the JSON body into the target type

This is a repo for the python sdk, not the API in general. If you have a question about the API I recommend you join the discord and ask in api-traders. That endpoint no longer exists and has been replaced by usdClassTransfer. I'll update the docs


InfluxDB 2 is not supported

Hi,
this plugin is not compatible to InfluxDB 2 due to the old influx client that is being used. Is it planned to upgrade this to support v2 of Influx?

Hi!
No, I'm not planning this right now. My Raspbian has still InfluxDB v1.6. Also, I can see that my other Ubuntus and Debian have v1.6.


Picking Tinkerbell action image URI from bundle

Description of changes:
The patches for eliminating local registry in Tinkerbell stack merged. Hence reading tink-worker action image URIs from bundle release.
Testing:
eksctl-anywhere generate clusterconfig
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

/hold
Holding for 🐞bash to get over.

/unhold


support ubuntu12+14

to fix #55
What this PR did:

mkfs.ext4 -O ^has_journal,^metadata_csum for ubuntu12, 14
restore initctl for ubuntu12, 14
setup ttyS0 for ubuntu12, 14
control packages by release version

Tested On:

[x] ubuntu 12.04
[x] ubuntu 14.04
[x] ubuntu 16.04
[x] ubuntu 18.04

Testcase:
$ cat Dockerfile
FROM ubuntu:12.04

# apt sources
RUN sed -i 's/archive/old-releases/g' /etc/apt/sources.list

$ docker run --rm -it -v /var/run/docker.sock:/var/run/docker.sock --privileged -v $(pwd):/d2vm -w /d2vm ssst0n3/d2vm:v0.2.2-dev build -f Dockerfile . -v

$ cp disk0.qcow2 vm.qcow2
$ qemu-system-x86_64 -hda vm.qcow2 --enable-kvm -nographic
...
Ubuntu 12.04.5 LTS localhost.localdomain ttyS0

localhost login:

@Adphi  review please?

I'm not sure what to make of this pull request.
As stated in the issue (#55 ):

we won't be making any changes to the project to support this use case

We don't want to maintain distribution releases that are no longer maintained upstream.
This will only create an increasing burden on project maintenance.
The maintenance required to keep the project up to date with the supported distribution versions is more than sufficient.
Can you explain the reasons for adding support for such unmaintained distribution versions ?

Hello @ssst0n3,
Thanks for you pull request !
I'm sorry, but I'm not sure what to make about it.
As stated in the issue (#55):

we won't be making any changes to the project to support this use case

We don't want to maintain distribution versions that are no longer maintained upstream.
This will only create an increasing burden on project maintenance.
The maintenance required to keep the project up to date with the supported distribution versions is more than sufficient.
Can you explain the reasons for adding support for such unmaintained distribution versions ?

@Adphi
I use the unmaintained distribution versions to build the env of history container vulnerabilities.
FYI: https://github.com/ssst0n3/docker_archive

I'm ok to add non official support for it, as long as you maintain it.
We need to add some tests for this.
But they will be optional because it should not be a show stopper in case of breaking change.
I'll try to find some time in the following weeks to review the pull request.


How to access currency

Hi, I am British and therefore use the £ symbol on my US keyboard often.
I can't seem to find it. I expected it to be under L or P but it isn't there.
I have had a look at your code and can see there is a currency section but I don't know how to access it. I am not very savvy with code.
Any help would be appreciated!

Hi Mattieu,
Thank you for your reply.
Would it be possible to include it in the All character set? It is a little
inconvenient to need to change the character set to be able to write the
GBP symbol. I notice that the EUR symbol is included in the All set, as is
the USD.
On Fri, 21 Jul 2023 at 17:52, Matthieu Pierre @.***>
wrote:

if you select only the Currency character set, you will find it under P,
but if you select All, it is missing
—
Reply to this email directly, view it on GitHub
https://github.com/damienleroy/PowerAccent/issues/104#issuecomment-1645794124,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/A5JV5BIKMZRUAJK3LUJNSLDXRKQVDANCNFSM6AAAAAAT6BCQXM
.
You are receiving this because you authored the thread.Message ID:
@.***>


AmbiguousMatchException fix

This exception is fired when ValueSerializerFactory is registered for some (not direct) descendant of ICollection.
Take a look at this line - it can't decide which Add to use.
Stumbled when tried to serialize Json.Net's JArray (don't ask why ¯\(ツ)/¯ ) which is derived from JCollection which is derived from ICollection and others.
Fix is to place specific ValueSerializerFactory at begining in the Options prop. I think this proofs my assumptions.

It looks good for me.


Typo correction in docs/features.rst

Looks like there was a typo in the features.rst file as RTD currently uses Elasticsearch rather than Solr

Thanks!

Pleasure is all mine ;-) @ericholscher


Helpers for Ownable contract

Function to easily transfer ownership of an Ownable contract to a specific address.
If the current owner is already a desired address it will not execute a call to the contract.
Depends on: https://github.com/keep-network/hardhat-helpers/pull/3

Parachuting out of nowhere with questions!

Why is the dist/ dir included in this repo? Would it make sense to use something like tsdx and have dist created as part of the build / publish?
It feels like you're writing TS that can be auto-generated with something like typechain, which we use elsewhere... what's the rationale for declaring your own Ownable class?

1. Why is the `dist/` dir included in this repo? Would it make sense to use something like `tsdx` and have `dist` created as part of the build / publish?

Thanks for pointing that to me! Obviously, we don't need to push the dist directory (this was probably something that I brought from developing GH actions, where dist dir had to be pushed). It was enough to define prepare script that will be invoked on yarn install in the package using this plugin (see: https://github.com/keep-network/hardhat-helpers/pull/3).

2. It feels like you're writing TS that can be auto-generated with something like `typechain`, which we use elsewhere... what's the rationale for declaring your own `Ownable` class?

The Ownable class is a helper that implements a specific logic that we need for deployments scripts. It's not directly calling the contracts. Also for calls to the contract, we use functions exposed by hardhat-deploy plugin.


Building script

The building scripts provided by Google/Chromium is a mess and so Ungoogled-Chromium is inheriting the problem.
A simple Makefile can solve any task, but due to some point I don't get, the wheel is getting always reinvented.  Why that? Unneccessary in my view.
I was trying to compile for Void-Linux but no success. Maybe some did so and can post the solution.
The building instructions are missing some points so far:

"flags.gn contains only a subset of what is needed to run the build.", ok, but please explain all flags and dependencies so anybody can put in the needed flags.
How not to compile to a specific platform (e.g. Debian Linux) but to the platform on which the build is compiled? Maybe this point is explained within the previous one (flags).

Regards

A tiny change of the source invokes a complete recompilation.

Please, could you elaborate more on this?
Changing some bits in already unpacked source makes ninja to recompile only the changed files.
If you meant the rebuilding process with each new version, ccache helps here more-or-less.
It was earlier possible to use jumbo to speed up the compilation, but unfortunately, Google removed it some versions ago.

please explain all flags and dependencies so anybody can put in the needed flags.

Ungoogled project has nothing to do with those, they are as they are defined in Chromium. Chromium documentation suggests a way to list them all: gn args out/Release --list. They are rather good documented there. Quick googling is also helpful with this page. It is for Mac, but most of the flags are also applicable everywhere else.

How not to compile to a specific platform (e.g. Debian Linux) but to the platform on which the build is compiled?

Could you please elaborate on what you are trying to achieve, what have you attempted and how/if was it unsuccessful?

This is an old issue, that didn't show much activity recently — closing.
If you have any more information to add, feel free to do so.


Plugins won't load [Delete please]

Plugins not loading with beta build #265 on Unturned <IP_ADDRESS>
Edit: Should say commands won't load, plugins show as loaded in the console, but typing help or trying to use any commands from the plugins yields no results.

No errors, says the plugins are loaded but when i try to use a command from the plugin it says failed to find command.


Build Error

In master brach:

duplicated Import item "System.Text.Json" in Heron.csproj cause reference problem
dependencies like "Microsoft.Extenstions.*" not include in references, need to run command Update-Package -reinstall in NuGet Console

I've updated the Nuget packages on the master branch.  Hopefully commit f310953 fixes the issue.


Add our deploy examples upstream to Devfile registry (2.2.0 schema)

/kind feature

Which functionality do you think we should add?
As a user, I want to have my deploy devfiles maintained by the devfile registry for examples such as node.js, dotnet, java, etc.
Why is this needed?

[ ] It should have our odo deploy examples pushed upstream to the Devfile registry

Thís is going to be addressed in https://github.com/devfile/api/issues/757


missing upernet_van.py

Huge thanks for sharing your work, this is great! Just a quick question, there is a reference to upernet_van.py as shown below but I am unfortunately unable to find it. Would you be so kind to share it as well? Thanks!
https://github.com/Visual-Attention-Network/VAN-Segmentation/blob/0ece089912fe40d25ac17c7c6c892bb35da92728/configs/upernet/VAN/upernet_van_large_512x512_160k_ade20k.py#L2

Sorry!
We update the path in configs.


Document how to set up coveralls reporting

Our dev guide can explain how to set up coveralls

If no one is working on this, I can start working on this soon! :)


Remove sentinel enum values from StableHLO and MHLO

Many MHLO enums were created by reproducing HLO enums, and in that process we inherited enum values like TRANSPOSE_INVALID, COMPARISON_TYPE_NOTYPE, etc whose only purpose is to serve as sentinel values in the HLO protobuf schema where it's not possible to specify that it's mandatory to provide a value for the attribute.
In MHLO (and in StableHLO), these enum values aren't super useful because MLIR attributes can be optional. Let's audit all enum values in MHLO and StableHLO, identify all sentinel values and remove them. #534 and #583 are two particular instances of this ticket that were opened earlier for two individual sentinels which we found confusing while speccing StableHLO.

I'm on board with this. I don't love the usage of DefaultValuedOptionalAttr as a whole, and this sounds like it will reduce the usage. It complicates transformations (StableHLO <--> MHLO, StableHLO <--> VHLO) since it has the extra step of checking if the optional attribute exists, or if the optional attribute is the default value and needs to be removed / skipped during transformation. Would prefer attributes to be default valued, or optional.


Chapter 12 final pass

This final pass does a lot of small wording changes, and moves around a bunch of go-furthers so they are 1:1 with sections. It also:

Adds a go-further on refresh rates
Merges two go-furthers on allocating event loops to cores
Adds a section, "Committing display lists", to split the mega-section into two

I think once this PR is merged, we should do a PR to release the chapter (this just requires toggling a bit in config.json) and then we're set to publish on Monday!

Quick question that I just had: what if a page sets a setTimeout for a long time, then navigates to another page? We don't handle this correctly, right? Should we add a footnote or something? Is there an easy fix?

Quick question that I just had: what if a page sets a setTimeout for a long time, then navigates to another page? We don't handle this correctly, right? Should we add a footnote or something? Is there an easy fix?

Good point. Navigation to a new page should clear the task queue. That seems easy enough to just fix?

Ok, let's merge this first, then do that in another PR.

Oh, wait, no, that isn't quite enough, because setting a setTimeout doesn't yet add anything to the task queue. There's a subordinate thread, which perhaps we could track and kill, but it's not an easy fix.

Oh, wait, no, that isn't quite enough, because setting a setTimeout doesn't yet add anything to the task queue. There's a subordinate thread, which perhaps we could track in the JSContext and kill, but it's not an easy fix.

Oh. I guess to fix we'd need to save off the URL of the setTimeout and compare when the timer expires. Not too hard?

What if the user follows a link from a page to itself? The most correct token to check is the JSContext itself. Actually ...
I just checked and maybe this doesn't happen! The setTimeout call creates a task, but that task calls dispatch_settimeout on the old JSContext, not the new one. That's good, but the old JSContext still holds a reference to tab and in principle could mess with the new page. (Security issue!!!) I think it might be enough to clear self.js.tab when we navigate, but ugh!

What if the user follows a link from a page to itself? The most correct token to check is the JSContext itself. Actually ...
I just checked and maybe this doesn't happen! The setTimeout call creates a task, but that task calls dispatch_settimeout on the old JSContext, not the new one. That's good, but the old JSContext still holds a reference to tab and in principle could mess with the new page. (Security issue!!!) I think it might be enough to clear self.js.tab when we navigate, but ugh!

Might be good enough to just note this in a foot note then as one example of the limitations of a toy browser, and that it's not a feasible of our browser to handle every single corner case exactly correctly, just as we don't fix all the memory leaks. But since we noted it, the reader gets a sense of the endless corner cases to make it perfect and secure. I mentioned this in another footnote regarding scrolling as well...

Ok, split the GIL go-further, now to add the setTimeout one.

Added a footnote for the setTimeout bug. The nice thing about adding a footnote is that we don't need to decide on the "best" fix if we just gesture in the direction of multiple 😆


Add devenv configuration

Install Python and Hatch and activate the Hatch virtualenv upon entering the devenv shell.
The activated Hatch environment is 'local' if a symlink to autonity.py is found, 'default' otherwise.
The 'local' environment loads autonity.py from ./autonity.py, while the 'default' environment installs it from PyPI.

Nice!


[core-util] - Add function to convert environment variable to boolean

I could have sworn we had similar logic to what .NET is doing somewhere... but I can't find it. I like the idea of having it in a common place, ideally of the shape
isEnvBooleanTrue(environmentVariableName: string): boolean

Originally posted by @xirzec in https://github.com/Azure/azure-sdk-for-js/pull/20776#r826403204

Label prediction was below confidence level 0.6 for Model:ServiceLabels: 'Azure.Core:0.311302,Azure.Identity:0.26307535,Cosmos:0.09530021'


fix: update openrpc to 3.1.2

:tada: This PR is included in version 1.4.1 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Remove auto-creation of pots when a new pool is created

Currently, in pool incentives, we automatically create pots for some standard lock durations every time a pool is created.  This is not necessary, as users can make pots themselves using a CreatePot message.  Automatically creating pots will lead to unnecessary state bloat.  We should probably remove this, but it's not urgent.
Source:  https://github.com/osmosis-labs/osmosis/pull/105#discussion_r618806693

I think we should actually keep auto-making a pot for > 1ms (ref #171 )

State bloat concern no longer applicable after Eugen's work on #386 was done


Enable Translation of Greek Language

Description
Please enable the translation of gitea to the Greek language.

I've added it as a language :)
Please post your username on crowdin so I can make you an editor of the language (able to approve translations).

Thank you,
my username is the same as github, infl00p

You should have proofreader status.


Use expectations

How about using assert instead of this:
https://github.com/FriendsOfApi/boilerplate/blob/master/src/Api/Tweet.php#L56
Not sure if it's any better or not, would make sense to do some research. The SPL InvalidArgumentException is kind of redundant from this point of view.

👍  to use https://github.com/webmozart/assert

I like that package, but I wonder if we need it in this boilerplate. By assert I meant the language construct in PHP. For some is empty checks it should be more than enough IMO, more importantly, KISS.

Sure.

Just came across this:

Assertions should not be used for normal runtime operations like input parameter checks. As a rule of thumb your code should always be able to work correctly if assertion checking is not activated.

Maybe it's not really a good idea after all

With scalar type hints there is no much assertions to do, right?

With scalar type hints there is no much assertions to do, right?

Well, only the empty checks. Honestly I wonder why it's not recommended to use the above, but it's okay to use ifs.

Well, only the empty checks. Honestly I wonder why it's not recommended to use the above, but it's okay to use ifs.


Replace Deprecated ListView with FlatList in SignlePickerMaterialDialog.js

After ListView has got deprecated in the new release of ReactNative, the Material Dialog in my Project was no longer working, so I updated it to FlatList instead and kept the appearance and UI as is.
Signed-off-by: Ashraf Ghanem<EMAIL_ADDRESS>

Thanks for the PR! This was done in #48


Instance / sample weights with boosted regression tree

Hello,
Does the boosted regression tree implementation (objective='reg:linear') in xgboost support sample weights ? I've browsed through the code and tried some experiments, but it does not seem to be the case.
Please advise.
Thanks,
-firdaus

Yes, checkout for example https://github.com/dmlc/xgboost/blob/master/demo/kaggle-higgs/higgs-numpy.py#L28

Thanks for the quick response. Starting with this example earlier, I replaced objective = 'binary:logitraw' with objective='reg:linear'.
For this objective function, the results with and without weights seem to be the same.
Any ideas why that might be?
Thanks.

Could simply because the weight do not contributed to the regression loss as much. The weight contributes to the loss function in all cases

Ah - you're right. I had to scale up the weights to see a difference. Thanks !


Cursive font in documentation is very difficult to read

The cursive font in the code blocks of the documentation make the examples very difficult to read, as there is a mix of more traditional monospaced, and the cursive font. A standard monospaced font for all of the code would be much more legible, especially for those with dyslexia and other reading troubles.

Just tried a different computer, and it wasn't cursive, but still not a regular monospaced font. The cursive might be some additional font installed, but still, the "Operator Mono" font seems to be causing issues. It should just be monospace

Script italics in Operator Mono are a feature, not a bug.
https://www.typography.com/blog/introducing-operator
Legibility is in large part a matter of taste. While the point about dyslexia is well-taken, a more varied typeface can dramatically improve code legibility for the colorblind. I myself am neither dyslexic nor colorblind, but switched to Dank Mono (which has similar script italics to Operator) in my editor a while ago and would have a hard time working without script italics now.


What about Power Pages and the Azure Active Directory B2C Identity Provider?

It seems like it is not possible to actually use the newly created custom domain in the Azure Active Directory B2C identity provider in Power Pages. When trying to add my custom domain in the authorithy field I get the following error message:
"The authority URL is incorrect for B2C sign in and sign out policy"
Seems like it will only accept URLs containing b2clogin.com...?

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 9c4a65cd-dae6-898a-514b-5bb9238f58a3
Version Independent ID: 9c2f7824-efed-7108-7c1e-eb2b57f3c0d6
Content: Enable Azure AD B2C custom domains - Azure AD B2C
Content Source: articles/active-directory-b2c/custom-domain.md
Service: active-directory
Sub-service: b2c
GitHub Login: @kengaderdus
Microsoft Alias: kengaderdus

@olasandness
Thanks for your feedback! We will investigate and update as appropriate.

Hi @olasandness
It is correct that Azure Active Directory B2C only accepts URLs containing b2clogin.com for sign-in and sign-out policies. However, you can still use your custom domain by creating a CNAME record that points to your B2C tenant domain name (something like yourtenant.b2clogin.com).
Here are the steps to follow:

In your DNS provider, create a CNAME record that points to your B2C tenant domain name. For example, if your B2C tenant domain name is contoso.b2clogin.com, create a CNAME record that points to contoso.b2clogin.com.

In your Power Pages application, use your custom domain name in the URL, but replace the domain name with your B2C tenant domain name. For example, if your custom domain name is login.contoso.com, replace it with contoso.b2clogin.com.

This way, your users will see your custom domain name in the URL, but the sign-in and sign-out policies will still use the B2C tenant domain name.
I hope this helps! Let me know if you have any further questions.

@olasandness
We are going to close this thread as resolved but if there are any further questions regarding the documentation, please tag me in your reply and we will be happy to continue the conversation

@olasandness @ManoharLakkoju-MSFT
Just to share my experience. I just went through the same situation and was able to get it to work somehow, feels a bit hacky though.
These were the steps:

On the Power Page Set Up -> Identity Providers -> Configured ADB2C with the default b2clogin.com endpoint
Went to Power Pages management -> Site Settings -> Confirmed the B2C details were there and updated the values to my B2C custom domain.

After all this if you go the Identity providers section again it shows an error that some settings are missing for Azure AD B2C, but if you ignore that error and test the app the Azure B2C button for Sign In should show up and redirect the user to the B2C custom domain.
It's just weird that Power Pages validates "The authority URL is incorrect for B2C sign in and sign out policy" when using ADB2C tenants with custom domains is common.


Consider Scaphold instead of Firebase

Because GraphQL. But wait for Relay 2 (https://github.com/facebook/relay/issues/1369)
Of course, we want declarative and type-safe data.
https://scaphold.io

How about apollo-client?


sync VSO - GitHub

sync VSO - GitHub.
npm package version 0.5.6

Hi @ignatvilesov, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!

It looks like you're a Microsoft contributor (Vilesov Ignat (Akvelon)). If you're full-time, we DON'T require a Contribution License Agreement. If you are a vendor, please DO sign the electronic Contribution License Agreement. It will take 2 minutes and there's no faxing! https://cla.microsoft.com.

TTYL, MSBOT;


Provider produced inconsistent result when using "placement"

Description
When applying changes to juju_application.ceph_mon for a Ceph deployment using Terraform, the provider "provider["registry.terraform.io/juju/juju"]" produced an unexpected new value in the .placement attribute. Specifically, it was cty.StringVal("1,0,2"), but after the apply, it changed to cty.StringVal("0"):
╷
│ Error: Provider produced inconsistent result after apply
│
│ When applying changes to juju_application.ceph_mon, provider "provider[\"registry.terraform.io/juju/juju\"]" produced an
│ unexpected new value: .placement: was cty.StringVal("1,0,2"), but now cty.StringVal("0").
│
│ This is a bug in the provider, which should be reported in the provider's own issue tracker.
╵

The particular use case here is deploying ceph on virsh VMs managed through MAAS and juju. First, MAAS is configured manually in the VM host, then a MAAS cloud is configured in juju using a virsh VM as the controller. Afterwards, terraform is used to:

link the VM host to MAAS so that VMs can be composed through MAAS.
compose VMs in MAAS to use as ceph OSDs and Monitors (assuming each VM runs an OSD and a Monitor).
create a model in juju for the ceph deployment and add the VMs to such model.
deploy ceph charms and integrate as appropriate.

This problem occurs in step 4, when coordinating the deployment of ceph-mon units on the same machines as ceph-osd units. the pattern is:
resource "juju_machine" "ceph_osd" {
  // ... (omitted for brevity)
  count = local.num_osds
}
resource "juju_application" "ceph_osd" {
  // ... (omitted for brevity)
  units = local.num_osds
}
resource "juju_application" "ceph_mon" {
  // ... (omitted for brevity)
  placement = join(",", [ for i in range(local.num_osds) : juju_machine.ceph_osd[i].machine_id ])
}

Urgency
Casually reporting
Terraform Juju Provider version
0.10.0
Terraform version
v1.6.6
Terraform Configuration(s)
terraform {
  required_providers {
    maas = {
      source = "registry.terraform.io/maas/maas"
      version = "~>1.0"
    }
    juju = {
      version = "~> 0.10.0"
      source  = "registry.terraform.io/juju/juju"
    }
  }
}

variable "maas_endpoint" { type = string }
variable "maas_api_key" { type = string }
variable "maas_kvm_host" { type = string }
variable "juju_maas_cloud_name" { type = string }

provider "maas" {
  api_version = "2.0"
  api_key = var.maas_api_key
  api_url = var.maas_endpoint
}
provider "juju" {}

locals {
    num_osds = 3
    ceph_osd_tag = "osd"
}

resource "maas_vm_host_machine" "ceph_osd" {
  count = local.num_osds
  hostname = "ceph-osd${count.index}"
  vm_host = var.maas_kvm_host
  cores = 2
  memory = 2048
  storage_disks {
    size_gigabytes = 15
  }
  storage_disks {
    size_gigabytes = 15
  }
}

resource "maas_tag" "osd" {
  name = local.ceph_osd_tag
  machines = maas_vm_host_machine.ceph_osd[*].id
}

resource "juju_model" "ceph" {
  name = "ceph"
  cloud {
    name   = var.juju_maas_cloud_name
  }
  config = {
    logging-config              = "<root>=INFO"
    development                 = false
    no-proxy                    = "<IP_ADDRESS>,localhost,::1"
    update-status-hook-interval = "5m"
  }
}

resource "juju_machine" "ceph_osd" {
  count       = local.num_osds
  model       = juju_model.ceph.name
  base        =<EMAIL_ADDRESS>  name        = "ceph-osd${count.index}"
  constraints = "tags=${maas_tag.osd.name}"
}

resource "juju_application" "ceph_osd" {
  name = "ceph-osd"
  model = juju_model.ceph.name
  charm {
    name     = "ceph-osd"
    channel  = "quincy/stable"
  }
  config = {
    osd-devices = "/dev/vdb"
  }
  units = local.num_osds
  placement = join(",",juju_machine.ceph_osd[*].machine_id)
}
resource "juju_application" "ceph_mon" {
  name = "ceph-mon"
  model = juju_model.ceph.name
  charm {
    name     = "ceph-mon"
    channel  = "quincy/stable"
  }
  units = local.num_osds
  placement = join(",",juju_machine.ceph_osd[*].machine_id)
}
resource "juju_integration" "ceph" {
  model = juju_model.ceph.name
  application {
    name     = juju_application.ceph_osd.name
    endpoint = "mon"
  }
  application {
    name     = juju_application.ceph_mon.name
    endpoint = "osd"
  }
}

Reproduce / Test

Install and config libvirt. Then, create a virsh network for the VMs.cat <<EOF > maas-net.xml
<network>
 <name>maas-ceph</name>
 <forward mode='nat'>
   <nat>
     <port start='1024' end='65535'/>
   </nat>
 </forward>
 <dns enable="no" />
 <bridge name='virbr1' stp='off' delay='0'/>
 <domain name='testnet'/>
 <ip address='<IP_ADDRESS>' netmask='<IP_ADDRESS>'>
 </ip>
</network>
EOF
virsh net-define maas-net.xml
virsh net-start maas-ceph

Install and manually configure MAAS on the VM host.
Setup a KVM host and create a VM to serve as the juju controller (don't deploy).
Configure a MAAS cloud in Juju using the Virsh VM as the controller.
(optional) Lock the juju controller in MAAS.
Run terraform: terraform init && terraform apply

Debug/Panic Output
maas_vm_host_machine.ceph_osd[1]: Creating...
maas_vm_host_machine.ceph_osd[2]: Creating...
maas_vm_host_machine.ceph_osd[0]: Creating...
juju_model.ceph: Creating...
juju_model.ceph: Creation complete after 0s [id=2af167dd-374f-45f6-88e4-9f051a0725d9]
maas_vm_host_machine.ceph_osd[1]: Still creating... [10s elapsed]
maas_vm_host_machine.ceph_osd[2]: Still creating... [10s elapsed]
maas_vm_host_machine.ceph_osd[0]: Still creating... [10s elapsed]
maas_vm_host_machine.ceph_osd[2]: Still creating... [20s elapsed]
maas_vm_host_machine.ceph_osd[1]: Still creating... [20s elapsed]
maas_vm_host_machine.ceph_osd[0]: Still creating... [20s elapsed]
maas_vm_host_machine.ceph_osd[0]: Still creating... [30s elapsed]
maas_vm_host_machine.ceph_osd[2]: Still creating... [30s elapsed]
maas_vm_host_machine.ceph_osd[1]: Still creating... [30s elapsed]
maas_vm_host_machine.ceph_osd[2]: Still creating... [40s elapsed]
maas_vm_host_machine.ceph_osd[0]: Still creating... [40s elapsed]
maas_vm_host_machine.ceph_osd[1]: Still creating... [40s elapsed]
maas_vm_host_machine.ceph_osd[2]: Still creating... [50s elapsed]
maas_vm_host_machine.ceph_osd[1]: Still creating... [50s elapsed]
maas_vm_host_machine.ceph_osd[0]: Still creating... [50s elapsed]
maas_vm_host_machine.ceph_osd[0]: Still creating... [1m0s elapsed]
maas_vm_host_machine.ceph_osd[2]: Still creating... [1m0s elapsed]
maas_vm_host_machine.ceph_osd[1]: Still creating... [1m0s elapsed]
maas_vm_host_machine.ceph_osd[1]: Still creating... [1m10s elapsed]
maas_vm_host_machine.ceph_osd[2]: Still creating... [1m10s elapsed]
maas_vm_host_machine.ceph_osd[0]: Still creating... [1m10s elapsed]
maas_vm_host_machine.ceph_osd[0]: Still creating... [1m20s elapsed]
maas_vm_host_machine.ceph_osd[1]: Still creating... [1m20s elapsed]
maas_vm_host_machine.ceph_osd[2]: Still creating... [1m20s elapsed]
maas_vm_host_machine.ceph_osd[1]: Still creating... [1m30s elapsed]
maas_vm_host_machine.ceph_osd[2]: Still creating... [1m30s elapsed]
maas_vm_host_machine.ceph_osd[0]: Still creating... [1m30s elapsed]
maas_vm_host_machine.ceph_osd[0]: Still creating... [1m40s elapsed]
maas_vm_host_machine.ceph_osd[1]: Still creating... [1m40s elapsed]
maas_vm_host_machine.ceph_osd[2]: Still creating... [1m40s elapsed]
maas_vm_host_machine.ceph_osd[2]: Still creating... [1m50s elapsed]
maas_vm_host_machine.ceph_osd[1]: Still creating... [1m50s elapsed]
maas_vm_host_machine.ceph_osd[0]: Still creating... [1m50s elapsed]
maas_vm_host_machine.ceph_osd[0]: Creation complete after 1m57s [id=c3dp8r]
maas_vm_host_machine.ceph_osd[2]: Creation complete after 1m59s [id=gf6ypf]
maas_vm_host_machine.ceph_osd[1]: Still creating... [2m0s elapsed]
maas_vm_host_machine.ceph_osd[1]: Creation complete after 2m5s [id=tmwf63]
maas_tag.osd: Creating...
maas_tag.osd: Creation complete after 1s [id=osd]
juju_machine.ceph_osd[0]: Creating...
juju_machine.ceph_osd[1]: Creating...
juju_machine.ceph_osd[2]: Creating...
juju_machine.ceph_osd[1]: Creation complete after 0s [id=ceph:0:ceph-osd1]
juju_machine.ceph_osd[2]: Creation complete after 0s [id=ceph:1:ceph-osd2]
juju_machine.ceph_osd[0]: Creation complete after 0s [id=ceph:2:ceph-osd0]
juju_application.ceph_osd: Creating...
juju_application.ceph_mon: Creating...
╷
│ Error: Provider produced inconsistent result after apply
│
│ When applying changes to juju_application.ceph_mon, provider "provider[\"registry.terraform.io/juju/juju\"]" produced an
│ unexpected new value: .placement: was cty.StringVal("2,0,1"), but now cty.StringVal("0").
│
│ This is a bug in the provider, which should be reported in the provider's own issue tracker.
╵
╷
│ Error: Provider produced inconsistent result after apply
│
│ When applying changes to juju_application.ceph_osd, provider "provider[\"registry.terraform.io/juju/juju\"]" produced an
│ unexpected new value: .placement: was cty.StringVal("2,0,1"), but now cty.StringVal("").
│
│ This is a bug in the provider, which should be reported in the provider's own issue tracker.

Notes & References
The OSDs and Monitors are depoyed successfully, but the integration is skipped due to errors reported by the juju_application resource. The output of juju switch ceph && juju status is as follows:
Model  Controller          Cloud/Region        Version  SLA          Timestamp
ceph   maas_cloud-default  maas_cloud/default  3.1.7    unsupported  13:21:58-05:00

App       Version  Status   Scale  Charm     Channel        Rev  Exposed  Message
ceph-mon  17.2.6   blocked      3  ceph-mon  quincy/stable  195  no       Missing relation: OSD
ceph-osd  17.2.6   blocked      3  ceph-osd  quincy/stable  576  no       Missing relation: monitor

Unit         Workload  Agent  Machine  Public address  Ports  Message
ceph-mon/0*  blocked   idle   0        <IP_ADDRESS>           Missing relation: OSD
ceph-mon/1   blocked   idle   1        <IP_ADDRESS>           Missing relation: OSD
ceph-mon/2   blocked   idle   2        <IP_ADDRESS>           Missing relation: OSD
ceph-osd/0*  blocked   idle   0        <IP_ADDRESS>           Missing relation: monitor
ceph-osd/1   blocked   idle   1        <IP_ADDRESS>           Missing relation: monitor
ceph-osd/2   blocked   idle   2        <IP_ADDRESS>           Missing relation: monitor

Machine  State    Address       Inst id    Base          AZ       Message
0        started  <IP_ADDRESS>  ceph-osd0<EMAIL_ADDRESS>default  Deployed
1        started  <IP_ADDRESS>  ceph-osd1<EMAIL_ADDRESS>default  Deployed
2        started  <IP_ADDRESS>  ceph-osd2<EMAIL_ADDRESS>default  Deployed

@tllano11 Thanks for opening this, could you please reduce the plan into something smaller and easy to reproduce to make things go faster, thanks!

Thanks for the quick reply @cderici . I just updated the terraform plan in the bug description and included some debug output as well. I tried to reduce the plan as much as I could. Let me know if there is anything else you need me add or modify.

This issue does not appear to be a duplicate of #182. In this case, there are 3 placement values, but only 1 value is put back in after deploy.

I also noticed that sometimes no value is put back at all. In the Debug/Panic Output section of the issue description, the last error shows this.

Adding to this, also getting this error.
Terraform - https://github.com/canonical/kafka-bundle/tree/main/terraform/dev
Command that deploys it - https://github.com/canonical/kafka-bundle/blob/38ab7c3d5df4465c3c4ff4b71994ab709aa11962/tests/integration/terraform/test_terraform.py#L30-L64
Failing messages - https://pastebin.com/1kUgVSv8

I can reproduce that same issue without using "placement", e.g.:
resource "juju_application" "opensearch" {
    name = "opensearch"
    model = var.model_name
    charm {
        name = "opensearch"
        channel = var.opensearch_channel
        base = var.opensearch_base
    }

    constraints = join(" ", [
      for k,v in {
          "instance-type" = var.opensearch_constraints.instance_type
          "root-disk" = var.opensearch_constraints.root-disk
          "spaces" = var.opensearch_constraints.spaces
      } : "${k}=${v}"
    ])

    units = var.opensearch_count
}

An update has been added to 0.11.0 for placements. All machines should be written when deploying. There is still a problem with order to fix. I have some work in progress here.

Unfortunately this issue persists in version 0.13.0
juju_application.test: Creating...
╷
│ Error: Provider produced inconsistent result after apply
│
│ When applying changes to juju_application.test, provider "provider[\"registry.terraform.io/juju/juju\"]" produced an unexpected new value: .placement: was cty.StringVal("1,2"), but now
│ cty.StringVal("1").
│
│ This is a bug in the provider, which should be reported in the provider's own issue tracker.
╵


Add onLoad method to SvgUri

Summary
PR based on #1449, but without LocalSvg changes.

@laffed this PR has been included in https://github.com/react-native-svg/react-native-svg/releases/tag/v12.4.3. What are the compat issues that were introduced in 13.x?


Check for previous/existing GitHub issues/module proposals

[X] I have checked for previous/existing GitHub issues/module proposals.

Check this module doesn't already exist in the module indexes

[X] I have checked for that this module doesn't already exist in the module indexes; or I'm proposing the module to be migrated from CARML/TFVM.

Bicep or Terraform?
Terraform
Module Classification?
Pattern Module
Module Name
avm-ptn-dev-center-dev-box
Module Details
Terraform module equivalent of bicep for dev box
Do you want to be the owner of this module?
Yes
Module Owner's GitHub Username (handle)
mjslegg
(Optional) Secondary Module Owner's GitHub Username (handle)
dan-dimitrov

@mjslegg ,
Thanks for requesting/proposing to be an AVM module owner!
We just want to confirm you agree to the below pages that define what module ownership means:
Team Definitions & RACI
Shared Specification (Bicep & Terraform)
Module Support
Any questions or clarifications needed, let us know!
If you agree, please just reply to this issue with the exact sentence below (as this helps with our automation 👍):
"I CONFIRM I WISH TO OWN THIS AVM MODULE AND UNDERSTAND THE REQUIREMENTS AND DEFINITION OF A MODULE OWNER"
Thanks,
The AVM Core Team

Related issue (module proposal for the Bicep version of the same module): https://github.com/Azure/Azure-Verified-Modules/issues/703

I CONFIRM I WISH TO OWN THIS AVM MODULE AND UNDERSTAND THE REQUIREMENTS AND DEFINITION OF A MODULE OWNER

Hi @mjslegg are you MSFT FTE?

@mjslegg
Since there is no response from your side, i will place request to 'looking for owners' until we find owner.

Hi @prjelesi . I'd like to accept ownership of this module. :-)

HI @autocloudarc
Thanks for requesting/proposing to be an AVM module owner!
We just want to confirm you agree to the below pages that define what module ownership means:

Team Definitions & RACI
Shared Specification (Bicep & Terraform)
Module Support

Any questions or clarifications needed, let us know!
If you agree, please just reply to this issue with the exact sentence below (as this helps with our automation 👍):
"I CONFIRM I WISH TO OWN THIS AVM MODULE AND UNDERSTAND THE REQUIREMENTS AND DEFINITION OF A MODULE OWNER"
Thanks,
The AVM Core Team
#RR

I CONFIRM I WISH TO OWN THIS AVM MODULE AND UNDERSTAND THE REQUIREMENTS AND DEFINITION OF A MODULE OWNER


Getting an error while passing a single rbridge_id value as input

Getting an error while passing a single rbridge_id value as input. rbridge_id type is array and legnth of the array is 1.  I am not getting any error while running the same action with single element in Web UI.
st2 run network_essentials.modify_arp_nd_aging_ve mgmt_ip=<IP_ADDRESS> arp_aging_type=arp_aging vlan_id=10 rbridge_id=52
ERROR: 400 Client Error: Bad Request
MESSAGE: 52 is not of type 'array', 'null' for url: http://<IP_ADDRESS>:9101/v1/executions

I am noting that @poorani612 also mentioned that this behavior is new to 2.1 - this worked in 2.0.1. I'm looking over the st2client code today to see if I can identify what changed

@poorani612 The parsing of these parameters occurs in https://github.com/StackStorm/st2/commits/master/st2client/st2client/commands/action.py and this file hasn't been changed since before the 2.0.1 release
Have you been able to confirm that this worked in a previous release?

Everyone upgraded to 2.1 and not able to verify in 2.0 :-(

@poorani612 no problem - based on my findings I'm guessing this has always existed. Regardless, thanks for the find, and watch #3159 for the fix


Redesign implementation

Lots of changes, here are a few of them:

If no incident history is provided, let the user know and provide them a link directly to the status page of the service
Update the design for the toolbar
Redesign incident history timeline
Adds a "mini timeline" to each service tile
Allows users to provide a logo for a service. If none is provided, we display the service name
When adding a new service, users can just from 4 pre-configured services. We auto-fill the form when one of those is chosen.
Removes "configure" page. All service settings now editable on a tile by tile basis via an "edit" button.
Enables searching of tiles via search input in toolbar

Brought to you by

Huge shoutout to @devfreddy for paving the way for so much of the work that was done in this PR. Would not have gotten too far without his help. You can see some of his work in the commits below, but what you can't see is how often he dropped what he was doing to help me figure out how to remove x roadblock from my path. Thank you, @devfreddy.
Kudos to @ericSpence, the original author, for coming up with such an awesome idea for a NR app and for creating it during a super hectic week of coding. Obviously, we couldn't have applied this redesign if the app didn't exist in the first place.

Related:
For more details on the visual changes, check out #23

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.0 out of 2 committers have signed the CLA.:x: danielgolden:x: devfreddyYou have signed the CLA already but the status is still pending? Let us recheck it.


Thoughts on adding email?

A way to sync email locally and search it nicely would be nice, since there are many things you get emails for that would be hard to get notifications for otherwise, purchases for instance.
In general I feel it would be really easy to hack stuff together if you have a nice API to work with your emails

Do have a wrapper around parsing an IMAP dump in my modules; related issue about troubleshooting in case you run into similar issues.


[BugFix] change default sink_dop to make it version compatible

What type of PR is this：

[x] BugFix
[ ] Feature
[ ] Enhancement
[ ] Refactor
[ ] UT
[ ] Doc
[ ] Tool

Which issues of this PR fixes ：

Fixes #
Problem Summary(Required) ：

Default sink_dop is not compatible with previous version, and failed the DCHECK(desired_tablet_sink_dop > 0).
Checklist:

[ ] I have added test cases for my bug fix or my new feature
[ ] I have added user document for my new feature or new function

run starrocks_admit_test

@Mergifyio rebase

run starrocks_admit_test

starrocks_be_unittest succeeded.


error in helpers.bash: line 87: `bash-it': not a valid identifier

Hi, I am using manjaro cinnamon. I reinstalled system today. Then, I find this xsession error.
my_home_directory/.bash_it/lib/helpers.bash: line 87: `bash-it': not a valid identifier
Thanks

Can you check whether this also happens with the latest version of Bash-it? Line 87 in this file is the end of the function: https://github.com/Bash-it/bash-it/blob/master/lib%2Fhelpers.bash#L87

@nwinkler I reinstalled bash_it and download the newest helpers.bash manually, but I still have the problem. Here is my bashrc.
 1 PATH=$PATH:/home/my_user_name/anaconda/bin:/home/guanghua/texlive/2015/bin/x86_64-linux:/bin:/sbin:/usr/bin:/usr/sbin   2 if [ -f /usr/bin/screenfetch ]; then screenfetch ; fi   3    4    5    6 # Path to the bash it configuration   7 export BASH_IT="/home/guanghua/.bash_it"   8    9 # Lock and Load a custom theme file  10 # location /.bash_it/themes/  11 export BASH_IT_THEME='bobby'  12   13 # Your place for hosting Git repos. I use this for private repos.  14 export<EMAIL_ADDRESS>15   16 # Don't check mail when opening terminal.  17 unset MAILCHECK  18   19 # Change this to your console based IRC client of choice.  20 export IRC_CLIENT='irssi'  21   22 # Set this to the command you use for todo.txt-cli  23 export TODO="t"  24   25 # Set this to false to turn off version control status checking within the prompt for all themes  26 export SCM_CHECK=true  27   28 # Set vcprompt executable path for scm advance info in prompt (demula theme)  29 # https://github.com/xvzf/vcprompt  30 #export VCPROMPT_EXECUTABLE=~/.vcprompt/bin/vcprompt  31   32 # Load Bash It  33 source $BASH_IT/bash_it.sh

I use LightDM as my display manager.

I can confirm this on latest bash-it

Antergos
LightDM

.xsession-errors error:
line 90: `bash-it' : not a valid identifier

Weird - what could cause this? Is it because that function does not start with function? Line 90 is the end of the function, the closing curly brace.

Could it be because of the dash in the name? POSIX seems to only allow underscores: http://pubs.opengroup.org/onlinepubs/9699919799/basedefs/V1_chap03.html#tag_03_235

Just confirmed it. It's the dashes in the identifiers. I renamed every
functions with dashes in their names in helpers.bash, and then the error
moved on to search.bash: line 48: '_bash-it-search': not a valid identifier
On Wed, Nov 2, 2016, 14:06 Nils Winkler<EMAIL_ADDRESS>wrote:

Weird - what could cause this? Is it because that function does not start
with function? Line 90 is the end of the function, the closing curly
brace.

Could it be because of the dash in the name? POSIX seems to only
allow underscores:
http://pubs.opengroup.org/onlinepubs/9699919799/basedefs/V1_chap03.html#tag_03_235

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/Bash-it/bash-it/issues/672#issuecomment-257797483,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AHrX46vH5jv50AIVivVuKdGJZZYc8c_zks5q6ESFgaJpZM4HhX4K
.

--
Munif Tanjim

Just confirmed it. It's the dashes in the identifiers. I renamed every
functions with dashes in their names in helpers.bash , and then the error
moved on to search.bash: line 48: '_bash-it-search': not a valid identifier

So why are these distros running in POSIX mode? Some further reading here: http://unix.stackexchange.com/questions/258785/force-posix-mode
Are you sure that they are actually running Bash, and not sh or dash or something like that?

Cause of the Error
So, here's the note from Bash - ArchWiki:

Note: In Arch /bin/sh (which used to be the Bourne shell executable) is symlinked to /bin/bash. If Bash is invoked with the name sh, it tries to mimic the startup behavior of historical versions of sh, including POSIX compability.

And the default LightDM Xsession script (generally located in /etc/lightdm/Xsession) uses the interpreter:
#!/bin/sh

Because of the behaviour of /bin/sh in Arch Linux (and its derivatives), the previously mentioned error occurs.
Fix
Edit the /etc/lightdm/Xsession interpreter line to:
#!/bin/bash

( @nwinkler I think we can close this issue and maybe add a troubleshooting guide in the Wiki. )

Awesome, thanks for finding this!
Do you have write permission for the Wiki?

I can edit the wiki from the web interface.

Awesome - you want to take a stab at adding what you posted above?

Did that already.

Great - closing this now.

I just had to make sure i execute the script using bash and not sh, i.e.
bash ~/.bash_it/install.sh


Use os.path.splitext() in render_template()

When running this function on Python 3.8, I ran into an error of .suffix not being an available method of str. Changing to use this function should fix that error.

How about switching to pathlib completely?


Game area

Preparation

[X] I read the Troubleshooting Guide
[X] My question isn't answered in any other issues (even the closed ones)

Your question
Is this an issue in Game area mode or because of something else?

the app was working fine in the last week but it stopped working from 2 days.
i have reset the phone settings and it worked fine yesterday and today it is not working so i reset the phone settings again and it started working.
can i get help please?
video
https://streamable.com/x12xs6

Since it only happens sometimes I'm guessing battery optimization is at fault.
Also report this as a bug please.


When delegate handler throws an exception, service returns 404 (not found)

Expected
When a delegate handler throws an exception I would expect the service to return 500 (internal server error)
Actual
When a delegate handler throws an exception the service returns 404 (not found)
Steps to Reproduce the Problem
Create a delegate handler (inherit from DelegatingHandler) and configure it in startup/config
Get the handler to throw and exception
Postman to the endpoint that contains the handler and 404 is returned
Possible fix
Add the following code to the ErrorsToHttpStatusCodeMapper:
if (errors.Any(e => e.Code == OcelotErrorCode.UnableToCompleteRequestError))
{
        return 500;
}

Other
I am not sure if the current behavior is for a reason so will not do anything until I hear this is not a daft thing to change!
Specifications

Version: 5.5.7
Platform: Windows 10
Subsystem: Visual Studio 2017 C# Core 2.0

@Dilsy99 yep I pretty much agree with this. I don't think there is any reason for this other than I haven't accounted for delegating handlers throwing exceptions since I did the error mapper stuff. I did the error mapping stuff maybe a year and a half ago and delegating handlers are 6 months old so probably my bad :(
I guess this should really be configurable because some places might want to return a 404 instead of 500 to discourage hackers because they think that a 500 means vulnerable to buffer overflow etc. I personally don't see a problem returning a 500 in .net but maybe I'm naive :( However for now happy for you to make this map to a 500 if you want to submit a PR!? :)

@TomPallister Many thanks for the response
I did think about configuration and how that would work in practice but it rather overwhelmed my Friday afternoon brain!
I have made the change and the only byproduct that I have noticed (because the test failed :-)) is that the ssl certificate configuration error now returns 500 rather than 404 (which makes sense as the handler is throwing the error).
Are you OK that this breaks existing functionality that  people "may" rely on?
public void should_not_dangerous_accept_any_server_certificate_validator()

@TomPallister  Excellent. Many thanks

@Dilsy99 released in version 6.0.0


feat: partial metadata projection

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

[x] Make sure to open an issue as a bug/issue before writing your code!  That way we can discuss the change, evaluate designs, and agree on the general idea
[x] Ensure the tests and linter pass
[x] Code coverage does not decrease (if any source code was changed)
[x] Appropriate docs were updated (if necessary)

This PR updates the documentation to specify how to get a partial metadata projection via the table.get() method, and clarified the difference between this method and table.getMetadata() in terms of being selective about metadata retrieved. A system test for this usage of table.get() has been added, as well as an expansion of the table.getMetadata() system test to help illustrate the differences between these two methods. This PR reflects an update to the BigQuery API across all languages, not a GH issue for this repo.

Checking the implementation guide, I think a good idea to test the different between getting a basic view vs full view is to check for the lastModifiedTime and/or numBytes, as in the basic view, those attributes are not computed by the backend.
https://github.com/googleapis/google-cloud-go/pull/6186/files#diff-62ca20d473019007434974e167cb4ad4be57a9f5b8b4ba834dfcf7abe3ee4f76

I'm already checking against numBytes in the new system test so I can add lastModifiedTime as well.


chore: import repository https://github.com/testingcicdorg/jx3-python-app4.git

this commit will trigger a pipeline to generate the CI/CD configuration which will create a second commit on this Pull Request before it auto merges

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To complete the pull request process, please assign
You can assign the PR to them by writing /assign  in a comment when ready.
The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


Multiple vector types in admin (polygon, line, points) in 1 map

Hi -
Thanks for the awesome code. Can you show how you get multiple different GEOS geometry fields into 1 admin map (polygon, line, points)?
This example only brings in the Point:
import floppyforms as forms
class GeoForm(forms.Form):
point = forms.gis.PointField()
I would like points, lines and polygons like the top of your map below the GeoDjango widgets title.
Cheers

There are a couple of widgets for geo data: http://django-floppyforms.readthedocs.io/en/latest/geodjango.html
If I remember correctly the MultiPolygonField will do the trick.


Action Window during plot phase

Hi there!
Don't know if it's the good place to post, here are some problems I encountered when playing on throneteki:

Maester Lomys: The game offers you to discard a card each time you win a challenge as defender, not only during intrigue challenge.

Action windows: As a NW player, I miss action windows during plot / draw phase, particularly with a Old Forest Hunter. When I use Counting Coppers, it draw 5 cards, so it's not easy to say " I would like to discard during plot phase", because some cards were drawn during draw phase.

Another action window I have a problem with ( but which is probably reported by some other players): when a player passes during challenge action, and his opponent makes an action, if this second player clicks on "Done", the first one doesn't have the possibility to make another action. It's a problem when you have several strength boosts for example. If I win a challenge, I won't play a strength boost and pass, but if my opponent boosts one of his characters, I would like to be able to do the same after him.
Thanks !

Maester Lomys fix: #529
I sympathize with your need for extra action windows, especially because the specific situation you describe is not solvable manually, your opponent would have to trust you to not discard cards drawn in the draw phase. Still, it would introduce a lot of clicking for players that are not playing the Old Forest Hunter. We'll see what cryogen says.

Old forest hunter is implemented now, closing this unless any more cards require this super niche action window


fix scrollbarSize and add karma test for firefox

fix scrollbarSize when recalc is falsy and size undefined and add karma testing for firefox add travis support

Hi there, thanks for the the PR. There is a bit of a concern here as this conflicts with what was done in: https://github.com/react-bootstrap/dom-helpers/pull/21

I thought I had taken it into this commit, but now I think I  understood it the opposite way, so the goal was to cache the size if it was 0, but why the test size !== undefined ? It means that with the let size it will be undefined. So i'm going to remove the test size === 0.

hmm yeah, it really should be any falsey value that isn't 0 so (!size && size !== 0) || recalc

I agree, done !

Thanks!

Could you push an update to npm so I can fix the firefox errors in react-overlays ?


[refactor] add "@Suppress("UnstableApiUsage")" for ignore @Incubatig warnings

it's just a friendly warning, that you are using the Incubating class. Let's look into the definition:
"Indicates that a feature is incubating. This means that the feature is currently a work-in-progress and may change at any time."
So don't worry, use it, and eventually update it in the future. Probably, it will be marked as stable in some future Android Studio and plugin versions.

I removed this warning by @Suppress("UnstableApiUsage")

Yeap, I agree with you!
BTW, Thanks and congrats for your first PR in ComposeNews 💪😍
I hope to see more PR from you in the future! ☺


Duplicate test harness using axum router

Status: trying to get a matching test harness router implemented in axum. This has been a good exercise because there are a lot of sharp edges.
Biggest issue right now is that it seems that any handler which involves a JsFuture (kv::get for instance) doesn't appear to be sync / send as needed.
I know we may not continue using miniflare, but I hope that breaking out the individual test handlers will make converting to wasm bindgen test easier.

I know we may not continue using miniflare, but I hope that breaking out the individual test handlers will make converting to wasm bindgen test easier.

@kflansburg My point was to understand your position, not to limit you in any way.
Feel free to push forward the best way you can.
Because, there are many things that could be tested using wasm-bindgen-test and for some reason even the existing wasm-bindgen-tests apparently were deprecated.
There are currently only 6 of them, 4 running, 2 broken.
My objective is to run wasm-bindgen-test-runner over miniflare - workerd.
I already started on the wasm-bindgen-test-runner, it seems I'll have to start by writing some tests.

Ok, I think this is in pretty good shape. Going to take a docs pass in the morning to explain the utilities for making things Send, but overall I think this turned out pretty well.

@kflansburg can you please explain how the send macro is sound?
JsValue types are !Send for good reason afaict. While workers (and wasm in general) is not multithreaded out of the box today, it very well may be in the future.
Let's assume the wasm memory is shared via SharedArrayBuffer - i.e. the Rust side will be genuinely multithreaded, and so something like axum will be able to call its handlers across threads.
Unless I am misunderstanding something, JsValues will still not be thread-safe (e.g. you can't have an instance of a JS class like DurableObject shared between threads, the JS runtime does not allow this and pointers in Rust to these JsValues require maintaining that invariant, I think..)

@kflansburg fair enough! For anyone else who stumbles in this, explanation of why Cloudflare intends to keep Workers always single-threaded: https://developers.cloudflare.com/workers/reference/security-model/#step-1-disallow-timers-and-multi-threading

@kflansburg why did you remove pub use crate::schedule::*; in worker/src/lib.rs? After upgrading to v0.0.22 the following no longer works in my scheduled workers:
use worker::{ScheduleContext, ScheduledEvent};

@kflansburg why did you remove pub use crate::schedule::*; in worker/src/lib.rs? After upgrading to v0.0.22 the following no longer works in my scheduled workers:
use worker::{ScheduleContext, ScheduledEvent};

And if it's accident shouldn't there be any tests in the build pipeline to reveal these types of problems? :)

This was a typo and is fixed here. https://github.com/cloudflare/workers-rs/pull/501


[Documentation Update]: Readme.md file

Is there an existing issue for this?

[X] I have searched the existing issues

Issue Description
I feel like Readme.md file doesn't seems attractive and is a bit boring as it contains text only.
Suggested Change
We can use links, animations, emojis etc to enhance it
Urgency
High
Record

[X] I agree to follow this project's Code of Conduct
[X] I'm a GSSOC WOB24 contributor
[X] I want to work on this issue
[X] I'm willing to provide further clarification or assistance if needed.

go ahead and make an pr referencing this issue

go ahead and make an pr referencing this issue

Hi @Harish-2003, can you add the GSSoC-ext label too.. I talked to Kalyani Uppuluri- leaderboard manager of GSSoC, he said that it's issue from your side, that's why it's not getting counted towrds leaderboard

Oh ok actually I am on my phone I will do that by night

Oh ok actually I am on my phone I will do that by night

Sure


"Manifest file has corrupted" when I tried to install from edge / chrome store

Hello, I hope you doing well.
When I tried to install this wonderful plugin from the edge / chrome addon store on edge latest version, it keep says
"Manifest file from this addon has corrupted and can't be installed in this browser"
How could I solve this problem? Thank you, have a good day

I'm unable to replicate this (tried installing in Edge from Chrome Web Store and Edge Add-ons on both Mac and Windows) and I can't find any reference to the error message anywhere else, so I'm afraid there's not much I can do.

I was used Ramdisk with Browser temp, and it was the problem.
Ramdisk program had some kind of overflow today and ouccured the glitches.
the problem is now solved, and thanks for the reply. have a nice day


fix: support colon in unquoted strings

Fix originally implemented by @freylax in #27 so credits should go that user.
However, since the author hasn't replied I thought I'd open a new PR for this so we can merge it.
Also fixes the tests in main.

@lunjon, thank you very much! :)


WIP: Permission request handler

Before submitting, please confirm you've

[x] read and understood our Contributing Guidelines
[x] completed Mattermost Contributor Agreement
[x] executed npm run lint:js for proper code formatting

Please provide the following information:
Summary
Use session.setPermissionRequestHandler() to confirm permissions when they're requested.
Results of the dialog are saved to AppData\Roaming\Mattermost\permissions.json.
This implementation is naive. The dialog pause the application until selecting a choice.
Issue link
https://mattermost.atlassian.net/browse/PLT-7458
Test Cases

Receive any messages in a channel.
A dialog should appear to confirm Allow/Deny/Skip the 'notifications' permission.
A desktop notification should appear after clicking 'Allow'.

Additional Notes
https://circleci.com/gh/yuya-oc/desktop/411#artifacts

Thanks @yuya-oc!
I can ask one of our designers to help with a design mock up for it.

Questions:

What options do we have for the popup? E.g. we could have

popup in the middle
popup in top left corner similar to browsers
popup, perhaps similar to desktop notifications in the bottom right corner
a bar at the top similar to the "blue bar" message sometimes displayed in Mattermost

2) The dialog pause the application until selecting a choice. Are there any improvements we can do?
3) Are there any other instances where this dialog would be needed (video calls?)

Options

popup in the middle
popup in top left corner similar to browsers
Possible. But need to create a dialog with BrowserWindow instead of dialog.
popup, perhaps similar to desktop notifications in the bottom right corner
Currently impossible. We can't choose allow/deny in desktop notifications without native modules.
a bar at the top similar to the "blue bar" message sometimes displayed in Mattermost
Possible. But a little complex internal flow would be needed.

Improvement for The dialog pause the application until selecting a choice
The application stops because dialog uses synchronous flow. So we can improve that by using asynchronous flow. But it would be a little complex than synchronous one.

Permissions:
Sure. There are ‘media’(WebRTC), ‘geolocation’, ‘notifications’, ‘midiSysex’, ‘pointerLock’, ‘fullscreen’, ‘openExternal’.
https://electron.atom.io/docs/api/session/#sessetpermissionrequesthandlerhandler

Hey @yuya-oc, sorry for the delay on this.
Sent you a note on pre-release and added notes on this Google presentation: https://docs.google.com/presentation/d/1uyIQxcscGzKcXPHUMMb3Rg7Loxld1ztmOE7t4d0z_nA/edit#slide=id.g28d3453657_0_16
I think we're close after a minor change to the dialog design and positioning.
Regarding 2), not sure how much work this would be? Thinking of a use case where the user receives the dialog while the app is minimized, without realizing it until much later. It could be a bad user experience if they didn't receive any notifications during this time period.

1 - I'm still evaluating the options. Will get back to you
2 - @yuya-oc How much work would it be to switch this to asynchronous flow?
3 - :+1:
For the dialog, are we able to get close to the Chrome "request permission" dialog?

This would mean

title: {app or site URL} wants to:
text: Show notifications // Use your camera and microphone
icon: Bell for notifications / video camera for video calls (I can provide these as we use similar icons elsewhere in Mattermost)
buttons: Allow / Block

2 - I need to consider the case where many requests are coming. At least a day would be needed.
Dialog: It would be more complex flow because it's combination of main and renderer process though, possibe by using Popover of react-bootstrap. https://react-bootstrap.github.io/components.html#popovers

@yuya-oc How much more complex would it be?
The reason why having a "nicer" dialog would be good is that the majority of users will see this dialog (given most have desktop notifications enabled). So it's worth spending some the time to improve them. However, if it's a lot of work we can consider keeping the original design and just changing the texts.
The other dialogs we're adding (navigating to external pages, uncaught exception errors) are more rare and only a few people will ever see them.

I feel it's difficult to describe enough in sentences... It's surely complex because two asynchronous things work together, so I need to manage the state in each processes. But the flow is almost similar in both cases.
However, I need to implement the dialog itself in addition to logical flow.

Of course I agree to create nicer dialog.

This is a prototype for the dialog. Icons are chosen from Bootstrap glyphicons for now. https://getbootstrap.com/docs/3.3/components/#glyphicons

Implemented the dialog with asynchronous flow. https://circleci.com/gh/yuya-oc/desktop/471#artifacts

This looks great to me.
Just two minor questions/notes:

I think the text isn't quite centered with the icon. If we're not limited by Electron, maybe move it by 1px up? No worries if not possible.

I didn't grab a screenshot, but when you click "Allow" or "Block" there's a 1-2 second lag when the action is accepted. Not sure if we can reduce that time?

It looks difficult for me. Possibly we can move it by 1px with hardcoding though, we also need to consider about other icons.

I noticed that point. I think it's related to React's state management though, I could not find the actual problem.

Sounds good
Okay, let's merge and see how it feels. We'll have a month to try improve it if needed.

Rebased to solve conflicts. #600 is still working fine.


doc: adding release notes in documentation

Implementing release note in documentation, using https://github.com/ansys/pyansys-geometry/pull/1138.

You might want to redirect the old CHANGELOG.md file as well. Or at least delete it

I agree, I will modify it!


Feature #360/Add word aligner

Describe what your pull request addresses

[ ]

Test Instructions

[ ]

LGTM


R example for xgb.train throws warning

When running the R example from xgb.train in the current master branch, I get the following warning:
[<time>] WARNING: amalgamation/../src/learner.cc:576:
Parameters: { "verbose" } might not be used.

  This may not be accurate due to some parameters are only used in language bindings but
  passed down to XGBoost core.  Or some parameters are not used but slip through this
  verification. Please open an issue if you find above cases.

Code as given in the example:
data(agaricus.train, package='xgboost')
data(agaricus.test, package='xgboost')

dtrain <- with(agaricus.train, xgb.DMatrix(data, label = label))
dtest <- with(agaricus.test, xgb.DMatrix(data, label = label))
watchlist <- list(train = dtrain, eval = dtest)

## A simple xgb.train example:
param <- list(max_depth = 2, eta = 1, verbose = 0, nthread = 2,
              objective = "binary:logistic", eval_metric = "auc")
bst <- xgb.train(param, dtrain, nrounds = 2, watchlist)

Let me take a look.  Thanks for opening the issue.

I need to deprecate the verbose parameter in the next release and unify it with the verbosity that's used by other bindings.

Same warning I am getting in Python also. I tried some methods but none of them work. Please resolve this issue

Fixed by https://github.com/dmlc/xgboost/pull/9942 .


Bitbucket support

Any plans to enable support on bitbucket?

Thanks for your feedback.
I'm closing this in favor of #92, where we can keep track of all alternative services.
Best,
Stephan


Ensure any calls to DDS require authentication

In order that all necessary communication between services is secure we should ensure the .../goobipdf endpoint should require (and be provided with) authentication.

closing, as this is being migrated to SNS


414 Argument struct for lucetc::Compiler::new()

Approach for  #414
First time working in this code base and not a huge amount of rust experience so comments much appreciated!
This is an approach that attempts to make construction simpler without changing the signature for Compiler::new.  CompilerBuilder could easily be something more like CompilerOptions that gets passed in as an argument to either a new Compiler method or Compiler::new if that is really the desire.
There are many more places using Compiler::new that I can update once I get some agreement on approach.  Also can add some testing.  Just throwing something out there fore feedback first.

Do you mean that there is more you'd like to do here? If you are satisfied, I think this is already a great step in the right direction.

I just meant the last commit I just added where I clean up uses of Compiler::new in the tests, mostly in lucetc/test/wasm.rs.  With that, I think this is complete.  Really appreciate the guidance on this @katie-martin-fastly!


Stats on OP child function calls

Collect stats on OPs host side functions calls.
@cglagovich generated such stats for set runtime arg here :https://docs.google.com/spreadsheets/d/10cRIyALulNFO6_K9mYg9R-JrB7wPQfRMy2x8GDChIYU/edit#gid=0
Add a column to op report for each of these functions set run time args, enqueue program, enqueue read, and enqueue write by default.
If multiple instances of the function exist, sum their duration.
Add this to op report as it allows for better conditional analysis if needed.
Adding new child functions should be as easy as adding the function name to a list in post proc scripts.

@davorchap and @cglagovich this feature is in.  There child functions calls which will be included in ops report by default. Additionally, using the --child-functions cli option in tracy.py you can ask for more child functions to be added to the report.
e.g. python -m tracy -v -p -r --child-functions CoreRangeSet -m pytest {test} will include the total duration spent on CoreRangeSet during each op.
Sample BERT run ( last columns show child functions duration sum)
ops_perf_results_2024_05_27_14_38_52.csv


[Contribution Process Bug]: job Queue error message keep repeating the initial error

Describe the issue
Job Queue error message keep repeating the initial error
Whenever job queue fails it always shows the first error message
Expected behavior
show latest error message
Steps to reproduce
Hi everyone,
I recently found an issue about Job Queue error message. It can't log the real error message which caused wrong direction of error check.
For example, I create a Job Queue Entry to run this CU that must return error.
Suppose every error messages are different as I log the current datetime.
However, no matter how many times running this JQ Entry, it will only repeat the Error Message of initial run.
Only after I cleared the "Error Message Register Id", then I can log a new Error Message.
Is there any setup I miss to cause this?
Thanks to Leo chu for the content

Additional context
No response

Thanks for reporting! We've got a fix coming 😊
As this issue isn't related to the System Application / Business Foundation, it shouldn't have been logged here. I'm hence closing this issue. But a fix will be shipped soon.


Support Application default credentials

For the GCP library it looks like https://prefecthq.github.io/prefect-gcp/credentials/#prefect_gcp.credentials.GcpCredentials we always need to have the credential file. However when running on Google Services you can normally used an attached   Application Default Credential and don't have to pass the credential along which is the recommended way for this in production.  My reading of the docs indicate it only supports the https://googleapis.dev/python/google-auth/1.15.0/user-guide.html#service-account-private-key-files method currently.
It should be easy to support via the SDK.  We normally do it via https://googleapis.dev/python/google-auth/1.15.0/user-guide.html#application-default-credentials.
import google.auth

credentials, project = google.auth.default()

vs
from google.oauth2 import service_account

credentials = service_account.Credentials.from_service_account_file(
    '/path/to/key.json')

scoped_credentials = credentials.with_scopes(
    ['https://www.googleapis.com/auth/cloud-platform'])

Prefect 1.x supported ADC as well (https://github.com/PrefectHQ/prefect/blob/1.x/src/prefect/agent/vertex/agent.py#L73)

We should support this per https://github.com/PrefectHQ/prefect-gcp/blob/main/prefect_gcp/credentials.py#L184 — perhaps we can just clarify the documentation by explicitly mentioning ADC? The blurb with "from the env" and the gcloud command is not particularly clear.

Thanks @madkinsz, the code support looks good. I think the Docs should point to this page about authentication, and then make it clear that it will attempt to use ADC if no credential is provided.


⚠ Bofrost.be has degraded performance

In ea4d3c8, Bofrost.be (https://www.bofrost.be) experienced degraded performance:

HTTP code: 200
Response time: 1827 ms

Resolved: Bofrost.be performance has improved in 1ed1d47.


I am interested in continuing this project

Tks your code can running in production environment;
I just interesting in continuing this project.
But I am a new gopher. How to connect you?
PS: I change your project code structure like mysql_exporter.

my email address is linked to my profile, so you can get in contact through this way for example.
I think it is necessary to refactor the code and give it a cleaner structure.
Recently @coder-hugo  has also shown interest in continuing this project. But the pull requests are still open and I'd recommend that you both get in touch...

I have made a pr #23.

Hi @stefanmonkey, @ofesseler, @coder-hugo,
What is the status here? I would like to use this exporter, and I can contribute fixing issues, making code reviews, and refactoring too.


Docker run and detach

Hi,
I am trying to docker.run an image in detached mode. In docker command I am using:
docker run --detach=true  --name api -t registry:5000/api:latest

I can then see in "STATUS" column (docker ps -a on the host) that the container is Up and running.
Trying to do the same thing with the API
docker.run("registry:5000/api:latest",null , null,
    {
        detach: true,
        name: "api"
    },
    function (err, data, container) {
            console.log("callback!")
    }
);

When I check with docker ps -a the container is up and running but It never goes in the callback even though detach = true.
I tried to add the option Tty: false to the list of options above
It goes in the callback but the status of the container is "Exited (0) 4 seconds ago "
Any idea to keep my container up and running in detach mode with the API ?
Thanks

Check the examples, like: https://github.com/apocas/dockerode/blob/master/examples/exec_running_container.js

How can we return the Container ID if the whole code in the above example was part of a function and that function is called to Spin up a container?
If not the Container Id, Then at least some status code would do.
Please help.


odo dev: Add support for non-exec commands part of a composite run or debug command

User Story

As an odo user
Now that I am able to run commands that are composite (thanks to #5054)
I want to be able to include non-exec commands(apply command) as part of my composite run or debug command
So that I can perform additional operations, like applying other component definitions (e.g., for building and pushing images, creating other Kubernetes resources, ...)

Acceptance Criteria

[ ] odo dev should run all the commands part of the composite run command
[ ] odo dev --debug should run all the commands part of the composite debug command

Example
schemaVersion: 2.2.0
metadata:
  name: nodejs
variables:
  CONTAINER_IMAGE: quay.io/unknown-account/myimage

components:
  - container:
      endpoints:
        - name: http-3000
          targetPort: 3000
      image: registry.access.redhat.com/ubi8/nodejs-14:latest
    name: runtime

  - name: image-build-component
    image:
      imageName: "{{CONTAINER_IMAGE}}"
      dockerfile:
        uri: ./Dockerfile

  - name: my-k8s-resource
    kubernetes:
      # Resource potentially referencing the 'CONTAINER_IMAGE' variable.
      # Might be inlined as well.
      uri: 'k8s/my-resource.yaml'

commands:
  - id: build-image
    apply:
      component: image-build-component

  - id: create-k8s-resource
    apply:
      component: my-k8s-resource

  - id: install
    exec:
      commandLine: npm install
      component: runtime
      workingDir: /projects

  - id: start
    exec:
      workingDir: /projects
      commandLine: npm start
      component: runtime

  - id: run
    composite:
      commands:
        - build-image
        - create-k8s-resource
        - install
        - start
      group:
        isDefault: true
        kind: run

Links

Related Epic (mandatory):
Blocked by: https://github.com/redhat-developer/odo/issues/5054

/kind user-story

@feloy I'm wondering if we'll need to add additional watchers for the resources deployed using the apply command here.