sc-10107 Make quick copy-text button for common name and ID

Scope of changes
sc-10107 Make quick copy-text button for common name and ID
Type of change

[ ] bug fix
[x] new feature
[ ] documentation
[ ] other (describe)

Acceptance criteria
https://app.shortcut.com/rotational/story/10107/make-quick-copy-text-button-for-common-name-and-id

Author checklist

[x] I have manually tested the change and/or added automation in the form of unit tests or integration tests
[ ]  I have updated the dependencies list
[ ]  I have recompiled and included new protocol buffers to reflect changes I made
[ ]  I have added new test fixtures as needed to support added tests
[x]   Check this box if a reviewer can merge this pull request after approval (leave it unchecked if you want to do it yourself)
[x]  I have moved the associated Shortcut story to "Ready for Review"

Reviewer(s) checklist

[ ] Any new user-facing content that has been added for this PR has been QA'ed to ensure correct grammar, spelling, and understandability.

Codecov Report
Base: 44.10% // Head: 44.12% // Increases project coverage by +0.02% :tada:

Coverage data is based on head (ee44772) compared to base (0cebf93).
Patch coverage: 73.33% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #841      +/-   ##
==========================================
+ Coverage   44.10%   44.12%   +0.02%
==========================================
  Files         617      618       +1
  Lines       23035    23047      +12
  Branches     1405     1406       +1
==========================================
+ Hits        10159    10170      +11
- Misses      11551    11552       +1
  Partials     1325     1325

Flag
Coverage Δ

unittests
44.12% <73.33%> (+0.02%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

...pp/details/BasicDetails/components/TrisaDetails.js
100.00% <ø> (ø)

web/gds-admin-ui/src/utils/index.js
46.09% <66.66%> (ø)

web/gds-admin-ui/src/components/Copy.js
75.00% <75.00%> (ø)

...com/trisacrypto/directory/pkg/gds/certman/certs.go
55.46% <0.00%> (+0.31%)
:arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Petsc was printing lots of errors.  This makes it a bit more quiet.  Also, a possible indexing error is fixed if no leftmost eigenvectors are asked for.

/style


JSON decode error

error happended on pi4 supervising honeywell:
Traceback (most recent call last):
File "supervise.py", line 204, in
main(tstat_type)
File "supervise.py", line 128, in main
zone.set_cool_setpoint(zone.get_schedule_cool_sp())
File "/home/pi/github/ThermostatSupervisor/honeywell.py", line 409, in set_cool_setpoint
'SystemSwitch': self.system_switch_position[self.COOL_MODE],
File "/home/pi/.local/lib/python3.7/site-packages/pyhtcc/pyhtcc.py", line 135, in submit_control_changes
return self.pyhtcc.submit_raw_control_changes(self.device_id, data)
File "/home/pi/.local/lib/python3.7/site-packages/pyhtcc/pyhtcc.py", line 423, in submit_raw_control_changes
json_data = result.json()
File "/usr/lib/python3/dist-packages/requests/models.py", line 897, in json
return complexjson.loads(self.text, **kwargs)
File "/usr/lib/python3/dist-packages/simplejson/init.py", line 518, in loads
return _default_decoder.decode(s)
File "/usr/lib/python3/dist-packages/simplejson/decoder.py", line 370, in decode
obj, end = self.raw_decode(s)
File "/usr/lib/python3/dist-packages/simplejson/decoder.py", line 400, in raw_decode
return self.scan_once(s, idx=_w(s, idx).end())
simplejson.errors.JSONDecodeError: Expecting value: line 1 column 1 (char 0)

another occurrence:
2021-07-19 18:53:40: (session:1, poll:1) COOL MODE [cool deviation] act temp=72.0°F, act humidity=51.0% RH, set point=72, override=66 (temporary)
[log_msg]: message text=Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: base64
Subject: honeywell cool deviation alert on zone 0
From<EMAIL_ADDRESS>To<EMAIL_ADDRESS>MjAyMS0wNy0xOSAxODo1Mzo0MDogKHNlc3Npb246MSwgcG9sbDoxKSBDT09MIE1PREUgW2Nvb2wg
ZGV2aWF0aW9uXSBhY3QgdGVtcD03Mi4wwrBGLCBhY3QgaHVtaWRpdHk9NTEuMCUgUkgsIHNldCBw
b2ludD03Miwgb3ZlcnJpZGU9NjYgKHRlbXBvcmFyeSkKCmVtYWlsIHNlbnQgZnJvbSBtb2R1bGUg
Jzxtb2R1bGUgJ2VtYWlsX25vdGlmaWNhdGlvbicgZnJvbSAnL2hvbWUvcGkvZ2l0aHViL1RoZXJt
b3N0YXRTdXBlcnZpc29yL2VtYWlsX25vdGlmaWNhdGlvbi5weSc+JyBydW5uaW5nIG9uIHJhc3Bi
ZXJyeXBpICgxMjcuMC4xLjEp
[log_msg]: smtp connection successful
[log_msg]: email account authorization for account<EMAIL_ADDRESS>successful
[log_msg]: mail send was successful
[log_msg]: Email sent!
*** honeywell cool deviation detected on zone 0, reverting thermostat to cool schedule ***
Traceback (most recent call last):
File "supervise.py", line 206, in
main(tstat_type, zone_input)
File "supervise.py", line 129, in main
zone.set_cool_setpoint(zone.get_schedule_cool_sp())
File "/home/pi/github/ThermostatSupervisor/honeywell.py", line 436, in set_cool_setpoint
'SystemSwitch': self.system_switch_position[self.COOL_MODE],
File "/home/pi/.local/lib/python3.7/site-packages/pyhtcc/pyhtcc.py", line 135, in submit_control_changes
return self.pyhtcc.submit_raw_control_changes(self.device_id, data)
File "/home/pi/.local/lib/python3.7/site-packages/pyhtcc/pyhtcc.py", line 423, in submit_raw_control_changes
json_data = result.json()
File "/usr/lib/python3/dist-packages/requests/models.py", line 897, in json
return complexjson.loads(self.text, **kwargs)
File "/usr/lib/python3/dist-packages/simplejson/init.py", line 518, in loads
return _default_decoder.decode(s)
File "/usr/lib/python3/dist-packages/simplejson/decoder.py", line 370, in decode
obj, end = self.raw_decode(s)
File "/usr/lib/python3/dist-packages/simplejson/decoder.py", line 400, in raw_decode
return self.scan_once(s, idx=_w(s, idx).end())
simplejson.errors.JSONDecodeError: Expecting value: line 1 column 1 (char 0)

root cause was hang between thermostat and TCC site, re-registered thermostat wifi and then app unlocked and error went away.

another error occurred on 8/21/21 after 21 sessions, here's the failing output:
2021-08-21 12:02:01: (session:11, poll:45) COOL MODE [following schedule] act temp=72.0°F, act humidity=58.0% RH, set point=72, override=72
[log_msg]: Traceback (most recent call last):
File "/home/pi/github/ThermostatSupervisor/honeywell.py", line 502, in refresh_zone_info
all_zones_info = self.pyhtcc.get_zones_info()
File "/home/pi/github/ThermostatSupervisor/honeywell.py", line 168, in get_zones_info
data = result.json()
File "/usr/lib/python3/dist-packages/requests/models.py", line 897, in json
return complexjson.loads(self.text, **kwargs)
File "/usr/lib/python3/dist-packages/simplejson/init.py", line 518, in loads
return _default_decoder.decode(s)
File "/usr/lib/python3/dist-packages/simplejson/decoder.py", line 370, in decode
obj, end = self.raw_decode(s)
File "/usr/lib/python3/dist-packages/simplejson/decoder.py", line 400, in raw_decode
return self.scan_once(s, idx=_w(s, idx).end())
simplejson.errors.JSONDecodeError: Expecting value: line 1 column 1 (char 0)
[log_msg]: exception during refresh_zone_info, on trial 1 of 3, probably a connection issue, waiting 30 seconds and then retrying...
[log_msg]: Traceback (most recent call last):
File "/home/pi/github/ThermostatSupervisor/honeywell.py", line 502, in refresh_zone_info
all_zones_info = self.pyhtcc.get_zones_info()
File "/home/pi/github/ThermostatSupervisor/honeywell.py", line 168, in get_zones_info
data = result.json()
File "/usr/lib/python3/dist-packages/requests/models.py", line 897, in json
return complexjson.loads(self.text, **kwargs)
File "/usr/lib/python3/dist-packages/simplejson/init.py", line 518, in loads
return _default_decoder.decode(s)
File "/usr/lib/python3/dist-packages/simplejson/decoder.py", line 370, in decode
obj, end = self.raw_decode(s)
File "/usr/lib/python3/dist-packages/simplejson/decoder.py", line 400, in raw_decode
return self.scan_once(s, idx=_w(s, idx).end())
simplejson.errors.JSONDecodeError: Expecting value: line 1 column 1 (char 0)
[log_msg]: exception during refresh_zone_info, on trial 2 of 3, probably a connection issue, waiting 30 seconds and then retrying...
[log_msg]: message text=Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Subject: intermittent JSON decode error during refresh zone
From<EMAIL_ADDRESS>To<EMAIL_ADDRESS>refresh_zone_info: trial 3 of 3
email sent from module '<module 'email_notification' from '/home/pi/github/ThermostatSupervisor/email_notification.py'>' running on raspberrypi (<IP_ADDRESS>)
[log_msg]: smtp connection successful
[log_msg]: email account authorization for account<EMAIL_ADDRESS>successful
[log_msg]: mail send was successful
[log_msg]: Email sent!
Traceback (most recent call last):
File "supervise.py", line 214, in
main(tstat_type, zone_input)
File "supervise.py", line 144, in main
zone.refresh_zone_info()
File "/home/pi/github/ThermostatSupervisor/honeywell.py", line 540, in refresh_zone_info
raise pyhtcc.ZoneNotFoundError(f"Missing device: {self.device_id}")
pyhtcc.pyhtcc.ZoneNotFoundError: Missing device: 1457408

this is a duplicate of #93, closing this issue.


Update to the latest version of gonum's API

Hasn't been testing correctly because TCopy and other APIs were dropped. Now corrected and currently passes all tests on my machine.

This request will be left open for 3 days for any comments. If there are no objections then it will be merged on the 16th of September.


Reduce singleton

Summary
Builds on #3159.
Reduces the usage of the j$ singleton and removes properties that are not used/not supported (CallTracker, SpyStrategy, isSpy, createSpyObject).  It's not technically breaking, since they don't seem to have been documented, but I might want to be cautious.

Test plan
All existing tests should pass.

This is great. It's ironic how we took a single file build of Jasmine, pretty-printed it and now we are turning it back into a set of modules.


About datasets

Hi, thank you for open sourcing D2Net, and I have to say that it is indeed very good work!!! I have a few doubts about the split of datasets.
In the paper," We split the training dataset into three folds with 190 sequences as training data and 95 sequences as validation data, then conduct the experiments in three-fold cross-validation manner."
But in the Code, there are  "Testing data". I don't understand where the test data comes from.
In preprocess.py, there are MICCAI_BraTS2018_TrainingData_gz、MICCAI_BraTS2018_ValidationData_gz and MICCAI_BraTS2018_TestingData_gz. How is this divided?
And in split.py, You did a triple cross validation.
I don't quite understand how validation data and testing data are divided. It is so strange.
Looking forward to your reply. Thank you.

Sorry for late reply.
The training dataset, validation dataset and testing dataset in preprocess.py are official dataset splits of BraTS. We only use the training dataset as our dataset and manually split it into training set and validation set (for 3 runs towards 3 cross-validation), since the official validation dataset and testing dataset does not release segmentation labels.


Spat data sending should be supported

Is your feature request related to a problem? Please describe.
Spat data sending is not supported.
目前未支持信号机数据下发。
Describe the solution you'd like
Dandelion should support Spat data sending interface. Refer to chapter 5.3.17 of specification for interface between Cooperative Intelligent Transportation System RSU and central subsystem for interface details
应支持信号机数据下发接口，接口详情参考《合作式智能运输系统-RSU与中心子系统间接口规范》第5.3.17章节。
Describe alternatives you've considered

Additional context
None.

#107


Implement GC9A01 driver

Implement GC9A01 driver for lvgl

Looks good to me, thank you!

GC9A01_HOR_RES

Cleaned up GC9A01_HOR_RES and GC9A01_VER_RES

Could you add default values to the top of the source file, like was done for the ST7565 driver?

Could you add default values to the top of the source file, like was done for the ST7565 driver?

Please take a look

Any more updates needed to this pull request?

Sorry for the late replay. It seems good and I merged it.
Thank you for the contribution.


fix: check for file name length

Fixes #4190
Enforcing file name length which is upto 255 chars. Throws an error if file name length exceeds 255 chars.
Added tests.

@sipsma Can you please have a look when you get some time?


tcmur_cmdproc_thread: Command 0xa3 not supported

Linux initiators will send service action 0x0c (MI_REPORT_SUPPORTED_OPERATION_CODES) to detect if INQUIRY, WRITE_SAME, and WRITE_SAME_16 commands are supported. Since tcmu-runner doesn't currently handle this service code, it results in a warning in the tcmu-runner log.

@dillaman
We will add this support if you are not dealing with this.
Thanks,

@lxbsz Go ahead, I am not working on it -- it was just something I noticed and figured it should be cleaned up to prevent false warnings in the logs.


How to disable sound?

Sorry if this is written somewhere else, but I have a problem where a certain program stops sound recording if I RDP into it with sound enabled (even Windows RDP does that). There's a console audio option in the help (-o) but not in the man page, so I searched the web and found no way to be certain sound is disabled in my rdp session.
Can anyone help a brother out?

@jackmcmorrow This is an issue tracker, not a support forum. Please use the mailing list or IRC for that.


Fix helpdm couldn't DM the user (#1640)

I hope that fixes #1640.

This PR is in high priority since this feature is getting used relatively often, as far as I can see.
@FaresAhmedb remember to lint before you push by running poetry run task lint.

@Xithrius Sure I will do in the future commits. Thanks for the heads up!

When committing from a suggestion, please change the message to have a relevant description besides "Updating ".
Context: b9456b4047b658b868c5ea5a965c0610ce7d9736

@Xithrius Sorry for the mistake. Can I use --amend?

In already public commits, that isn't a good idea. I'll squash merge this PR so there's only one commit in the end.
Thank you for this contribution!


Fix a performance regression in subqueries with implicit fills

During the compilation refactor, it was intended to retrieve the
information from the query into a new data format that would then be
used to build the query. The problem is that the actual execution is
still done on the AST so the implicit change of fill(null) to
fill(none) (which is done to prevent the outer query from churning
through and ignoring a bunch of null points) was never done.
Fixes #9271.

This does, in fact, not fix the issue it says it will fix. I think I've figured out the actual issue so I'll update this when I'm done with the fix.


UI and website copy for translation

While we are preparing for the UI and website copy for translation, we noticed that there are a few items missing or need updates in the ui/en.yaml. It seems like all the changes in this commit are not there.
Filter by keyword
We will need to add 'Filter by keyword'.
Page names:
In the 'briefPageDescriptions' section of ui/en.yaml, we will need to remove the word 'Archive'.
Community page:
We won't have 'Core Libraries' and 'Community Libraries' in the community page, we will just call it 'Libraries'.
Accessibility setting:
We understand that we might not implement 'Reduced Motion' in this round, but we'd like to add it in the UI list and have it translated since we'd like to include it for future implementation.
Please let us know how you'd like to proceed. I can open a PR if it's easier. Thanks!
@stalgiag @outofambit; cc @limzykenneth @davepagurek

Thanks for flagging!
I won't be able to get to this today so if this is a prerequisite for your work feel free to open a PR (and even merge directly once tests pass). Your team probably has the best sense of the needed UI text. Otherwise, I can add these key-value pairs at the beginning of next week.

Resolved with PR #129


Unable to select existing App Service Plan when create function

Is this by design?   Once, selecting Dynamic, there is no option to select existing App Service plan (if many).

I'd say the service plan becomes mostly irrelevant in dynamic. In practice, what name does it end up using for the plan? Does it reuse the same one for multiple funcs in same region?

It ends up reusing one in the same region.  I agree that same or different app service plan is likely irrelevant.
One thing we have to be smart about whether to reuse or create a new one (given below restriction).

Five maximum containers (site) per service plan.
Five service plans per subscription.

This 5 plans / 5 containers limit seems a bit random to me. I'd rather say 1 plan / 25 containers. Doesn't take anything away, but removes confusion.

By design


Changing it so that markGpuOnly will disabler samplers

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Remove use of secondary action link component

Using the GOV.UK Design System spacing override classes we can add spacing around a link without need for a custom component or even a div.
When adding spacing override classes to inline elements such as anchors, we do need to also add the govuk-!-display-inline-block override.

Are we getting rid of related custom CSS as we remove components, or are we going to clean that up later? In application.scss we still have a .question + .secondary-action-link class...

Are we getting rid of related custom CSS as we remove components, or are we going to clean that up later? In application.scss we still have a .question + .secondary-action-link class...

We can definitely get rid of that! 🔥 Nice spot


please release with 1.6.5 version of solana

so it could be could to keep this create up to pace with solana sdk

Addressed by #210.


Remove "column_keys" from output

I've successfully used the plugin to fetch data and write it to a json file (despite knowing nothing about ruby) but I'm at a loss as to how to parse the headers out of the json so I can consume it with jekyll.
The json I'm getting looks like this
[{"column_keys":["title","gallery","event","ministry","published","date_added","ministry_name","ten_minutes","id"],"attrs":{"title":"Family Revival","gallery":[{"id":"attcNc5ihYUtR3QdD","url":"https://dl.airtable.com/BarsFKuSvKRea5cOgHs5_IMG_3174.jpg","filename":"IMG_3174.jpg","size":2042172,"type":"image/jpeg","thumbnails":{"small":{"url":"https://dl.airtable.com/nsv6C5TACt49UdktTNEg_small_IMG_3174.jpg","width":48,"height":36},"large":{"url":"https://dl.airtable.com/JNh8Z65SIaQb6V2Fgc4d_large_IMG_3174.jpg","width":512,"height":512}}}

And on and on and on (it's a very long file.)
The json I'm used to getting (from the node client) looks like this:
[{"title":"Family Revival","gallery":[{"id":"attcNc5ihYUtR3QdD","url":"https://dl.airtable.com/BarsFKuSvKRea5cOgHs5_IMG_3174.jpg","filename":"IMG_3174.jpg",

And my ruby script looks like this:
require 'json'
require 'airtable'
require 'active_support/all'

# Pass in api key to client
@client = Airtable::Client.new("key...")
# Pass in the app key and table name
@table = @client.table("app...", "Photos")
@records = @table.records(:sort => ["date_added", :desc], :limit => 50)

File.open("_data/photos.json", "w") do |f|
<EMAIL_ADDRESS>end

Obviously I need to do something to the ruby script to strip that initial json, but what?

Figured it out.  Here is the code in case you run into the same problem:

require 'json'
require 'airtable'
require 'active_support/all'

# Pass in api key to client
@client = Airtable::Client.new("key....")
# Pass in the app key and table name
@table = @client.table("app...", "Photos")
@records = @table.records(:sort => ["date_added", :desc], :limit => 50)

File.open("_data/photos.json", "w") do |f|
    data = @records.map { |record| record.attributes }
    f.write(data.to_json)
end


Map - refine 'landing behaviour' of shared/public analyses

For April 2024 if possible.
Was just on a call with our tick data provider friends and they love the detailed analysis platform as researchers but would like it much simplified for their users who are general public, hospital and vet doctors and potentially policy makers.
Shared and/or public analyses are part of the answer to this.
If we can pre-configure views to show certain things, these can be linked from their website.
At the moment we have the following issues with imported analyses:

left panel is open on marker configuration (unwanted)
floating plot is not in the "hide controls" state we left it in
floating plot is not in the position it was left in
floating plot size is not what it was left in
(legend position(s) also not preserved, but perhaps less of a problem)
if the floating plot has a "proportion" y-axis and the floater's controls are hidden, there is no information to tell the user what that proportion is (the label is just "proportion")

Previous thoughts on much of this here: https://github.com/VEuPathDB/web-monorepo/issues/444
This might be better as a parent ticket for smaller, well-defined tasks.

Related to #275

This is now mostly done in #275.
Need to think more about the floater, hidden controls, resizing etc before closing this completely I think, but great start.

Moved remaining issues to b69 nice to have - and will require discussion first


Inconsistent Threshold of RigidBody2D Collision Responses

Godot version
3.3.2.stable.official
System information
Windows 10, GLES3
Issue description
A RigidBody2D (Character mode) will get stuck between two StaticBody2D objects because the overlap distance is inconsistent depending on the speed at which the rigid body hit the static body.
Here is the setup (example project attached):

Here is a diagram of the problematic corner:

When the blue rigid body hits the green static body with any sufficient velocity (whether gravity is on or off), it will always settle at 0.3 overlap on the y axis. But if the blue hits at a low velocity, it settles at lower values (like 0.08).
The issue is that while the rigid body is not moving at all (and no gravity or downward forces exist) it will still stay at 0.3 overlap with the green, but cannot go deeper than 0.2 for example in the x axis to overlap the red.
This results in the case where the overlap rectangle between blue and red is taller than it is wide, which generates a horizontal contact normal (which makes sense) but means that the rigid body cannot move over the seam even though everything is snapped to pixels/grid.
In other words, the overlap displacement threshold (at which two overlapping bodies are considered just touching and not overlapping) should be the same at rest regardless of how fast the collision was.
Also, is there an easy way to modify this value of 0.3 max overlap? Tried with the custom solver bias of the CollisionShape2D but it had no effect.
Thank you a lot for reading my issue!
Steps to reproduce

Open the attached project and start the only scene
Wait for the blue RigidBody2D to fall (using gravity, or disable gravity and press down arrow)
Wait for the blue to hit the green StaticBody2D, you should see that the y label offset shows 0.30000
Now press the right arrow (or left) and the blue will be stopped by the red static body and the x offset will be less than 0.3

Minimal reproduction project
Collision2DTest.zip

And I forgot to mention that the continuous mode (discrete, ray, shape) does not affect the behavior I'm describing, neither does switching from Character mode to Rigid body mode.

I haven't investigated your specific case yet, but could you try to set this parameter in the physics server in order to reduce the allowed penetration?
You can put this script on any node in the tree, just called once in _ready (it affects all rigid bodies).
var space = get_world_2d().space
Physics2DServer.space_set_param(space, Physics2DServer.SPACE_PARAM_BODY_MAX_ALLOWED_PENETRATION, 0.0)

In this example, it will be set to 0 but you can set any other value.

Thank you for your quick reply.
After some testing, here is how I can summarize what I found:

there is a critical velocity below which the seam will be able to stop the rigid body. The less the SPACE_PARAM_BODY_MAX_ALLOWED_PENETRATION (MAP) is, the less that critical velocity will be.
If you set the MAP to zero, if there is gravity (or any downward force), then the critical velocity will still be higher than zero (albeit small, like 0.1 tiles per second).
Otherwise if there are no downward forces and MAP is zero, then this critical velocity drops to almost zero (floating point errors).

I assume that the first and second cases are an issue because the seam shouldn't stop the rigid body even when it is pushed down (zero damping, zero friction). I'm not sure if this is an inherent limitation with the collision response algorithm or something can be done to account for corners/seams and slow moving objects.
But overall, setting the max overlap to zero does effectively help by making the seam only affect much slower moving objects. But, it creates another issue; very noticeable jitter at rest if you set a high gravity scale for example. Basically, every half a second, the y offset jumps to 0.1 or so, and goes back to zero. (And again, continuous collision modes have no effect on this jitter.)

Thanks for the tests and detailed explanation!
After testing, I can confirm there's a bug here which is similar to #47148. There should be a better mechanism to prevent collision with edges between objects.
I'm closing this issue as duplicate of #47148, but this repro case will be useful to help solving the issue so I've added a note there about your findings.

After spending the whole day reading the code, I figured something out, so trying to share what I found if it helps someone.
In the file godot-3.3.2-stable\servers\physics_2d\collision_solver_2d_sat.cpp
    (...)
    _FORCE_INLINE_ void generate_contacts() {

	// nothing to do, don't generate
	if (best_axis == Vector2(0.0, 0.0))
		return;

	// ---- START OF CHANGE ----
	real_t max_penetration = 0.3;
	if (best_depth <= max_penetration)
		return;
        // ---- END OF CHANGE ----

    (...)

This solves the issue (assuming you also set Physics2DServer.SPACE_PARAM_BODY_MAX_ALLOWED_PENETRATION to the same value). Sorry I couldn't find how to access the body/area from the shape to retrieve the value of the space using Physics2DServer space_get_param... Maybe someone who spent more time with the code could save me the hassle of figuring that out :D
Also, there is something I should correct about what I said earlier: the jittering issue seems to be completely unrelated, it happens even if the max_penetration is not zero. It too will happen at a certain point if the force pushing an object against another is sufficiently high. So basically, gravity scale set to 10 will jitter even with 0.3 max_penetration. And the jittering doesn't happen every frame, more like every half a second, so it must be some cached value (object set to never sleep); I played with the max_separation but it didn't help.
Anyway, thanks again!


Syncing handshake RPC data in chunks; Mod Options improvements

Not thoroughly tested, but looks alright. I'll update the workshop item during some workday to test the waters, and if there will be some breaking changes, I'll do the rollback.

I'm going to hold sanctioning this until Monday morning in case issues come up.
Thanks again for looking into this! ❤

vmf-2023-07-03.zip


PowerShell sessions in Pipeline have a limited scope. Please explain this and be explicit

I have been stumpped by a problem regarding the lifetime of a PowerShell session duing the pipeline. Nowhere in the documentation does it say tasks should be defined in the same Job that dependencies are imported into. For PowerShell, the user should be made aware not to create different stages expecting that to work on the same PowerShell session; this simply does not work and this is not documented. For a fuller description of this issue, please refer to this:
https://developercommunity.visualstudio.com/content/problem/1142539/azure-pipeline-powershell.html
Please can you document this for the PowerShell task, you can even use my faulty pipeline definition as an example.

Document details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 7458d5b2-1bb7-7d87-7ce6-2b0c430b0155
Version Independent ID: edf5bbd3-a3f0-5426-e985-31290f8afd05
Content: YAML schema - Azure Pipelines
Content Source: docs/pipelines/yaml-schema.md
Product: devops
Technology: devops-cicd
GitHub Login: @steved0x
Microsoft Alias: sdanie

@plastikfan Sorry that you ran into trouble with this - I have added an update the the PowerShell task article as well as the related section in the YAML schema document.

Hi @steved0x, thanks for doing this. I found the update with the extra note in the PowerShell(pwsh) task, but I can't see what has been updated in YAML schema document. Please can you link and specify the actual paragragh with the new information, thanks.

Actually, don't you think that PowerShell modules warrant full documentation, rather than a little note somehere, that is not that visbible? There is no documentation on PowerShell modules on Azure. I find this very strange. PowerShell modules pose a whole set of issues that PowerShell scripting do not so I think this should be fully addressed.


TypeError: meshio does not support VTK type 6.

Hi,
I tried saving my mesh after extruding. Now I get the above error and could not find anything about it.
cloud = pv.PolyData(indexing3D)

meshvol = cloud.delaunay_2d(alpha=2.)
meshvol2 = meshvol.extrude([0, 0, 1.5], inplace=False, progress_bar=False)

pv.save_meshio("SCC_140_extruded.obj", meshvol2)

This is the "meshvol" object:
<bound method PolyData.is_all_triangles of PolyData (0x7f1b28ee5440)
N Cells:	394483
N Points:	198131
X Bounds:	1.990e+02, 7.720e+02
Y Bounds:	2.390e+02, 8.160e+02
Z Bounds:	1.000e+00, 1.000e+00
N Arrays:	0
and the "meshvol2" object (extruded):
<bound method PolyData.is_all_triangles of PolyData (0x7f1b28fe9ad0)
N Cells:	790753
N Points:	396262
X Bounds:	1.990e+02, 7.720e+02
Y Bounds:	2.390e+02, 8.160e+02
Z Bounds:	1.000e+00, 2.500e+00
N Arrays:	0
Thank you!
Max

This issue seems to be accidentally created here. PolyData and cloud.delaunay_2d is nothing that meshio has any part in. Hard to tell, because the MWE is incomplete. Closing.
Feel free to reopen with a complete copy-and-pastable MWE if you feel this is a meshio issue after all.


Confused by "inbox server settings are valid" message

Checklist

[X] I have used the search function to see if someone else has already submitted the same feature request.
[X] I will describe the problem with as much detail as possible.
[X] This issue only contains a request for one single feature, not multiple (related) features.

App version
6.714
Problem you are trying to solve
Now that I didn't do any code contributions for K-9 for quite a while, I just switched from an old debug version to the official beta version on Google Play. So far, the new account setup looks quite nice. I'm sure it will help many new users. However, I noticed a few problems that I will be creating issues now.
When creating a new account, after typing the IMAP server details and pressing "ok", I got to a screen with the full-screen message "inbox server settings are valid". This message disappeared after a few seconds. However, it was displayed long enough that it confused me quite a bit. I expected a "next" button or something similar. I ended up clicking the screen randomly (the icon, the location where I would expect a "next" button, etc). While this confusion didn't last long (screen gets redirected soon, at least if you don't end up pressing the back button), I think this short confusion is not a nice first impression to the app for new users.
Suggested solution
Keep showing the progress indicator below the "inbox server settings are valid" message. This indicates that the app is still doing something (eg redirecting to the next settings page) and that I don't need to click anything to continue.
Screenshots / Drawings / Technical details
No response

In a design meeting we've decided to continue showing the progress indicator along with the success message. That will hopefully make it clear that no user input is expected on this transient screen.
We'll also experiment with reducing the timeouts so the screen isn't displayed for too long, but also not so short that it appears like a flash.


Can NOT save a 'case' if NOT press the '+' button

You see...

 Wait and see.

😜

已更新到v1.2.4： 更正在没有选定用例的时候保存用例,提示保存为新用例。
https://github.com/bowenliang123/SailfishRequester/commit/964109cbea6faecbbcc23ef99934a529d3271a15
多谢xx提意见~

jjboom


Cookie Consent doesn't work on mobile browser

Hello!
I've install the plugin in my web and works very well in IE and in Chrome, but when I tried it in my smart phone, it didn't work in the samsung usual navigator.
My phone is a samsung galaxy

Duplicate of #62


Optimize: UI

In optimizing the UI, we meticulously refine the user experience to enhance efficiency, accessibility, and aesthetic appeal. Through iterative design processes and user feedback analysis, we identify pain points and streamline interactions, ensuring seamless navigation and clarity in functionality. We prioritize intuitive layouts, employing minimalist aesthetics and consistent visual cues to guide users effectively. Performance optimization is integral, ensuring swift response times and smooth transitions across various devices and screen sizes. Accessibility features are integrated to accommodate diverse user needs, promoting inclusivity. By harmonizing functionality with elegance, we deliver a UI that not only meets but exceeds user expectations, fostering engagement and satisfaction.

Why not InkFree

Why not InkFree

We refrain from utilizing Inkfree font primarily due to its readability and versatility limitations. While Inkfree font may offer a unique handwritten aesthetic, its irregular strokes and lack of uniformity can impede readability, especially in longer texts or smaller font sizes. Additionally, the distinctive style may not align with the formal or professional tone required for certain documents or contexts. Furthermore, Inkfree font may encounter compatibility issues across various platforms and devices, limiting its practicality for widespread use. In essence, while Inkfree font may have niche applications for artistic or decorative purposes, its drawbacks in readability, versatility, and compatibility outweigh its aesthetic appeal for our intended communication needs.
Powered by ChatGPT.


Add GraphStore

Just an initial API to start the discussion if that is the expected API

Checked with @logan-markewich. This looks good. Thank you!

bump @yisding are we following with this?


use unittest.mock instead of mock

Could you please consider to use unittest.mock instead of mock as a fallback?
https://trello.com/c/S6eADbii/64-remove-python-mock
https://fedoraproject.org/wiki/Changes/DeprecatePythonMock

I don't see a problem in doing so.  Not sure when I'll have time to make a PR and test.

In https://build.opensuse.org/package/show/devel:languages:python/python-vncdotool
you see that
https://build.opensuse.org/package/view_file/devel:languages:python/python-vncdotool/python-vncdotool-no-mock.patch
is enough down to at least python 3.6.
By the way, we have also
https://build.opensuse.org/package/view_file/devel:languages:python/python-vncdotool/remove-nose.patch
to remove usage of unmaintained nose. I would do a PR, however I am not sure about the infractructure files and CI, unfortunately.

The reference to the external mock has been replaced by unittest.mock with 029948a, which should be included with the next releasee.

Thanks!


Error in Windows 10

I try to install in Windows using luarocks and I recieve the following error:
C:\Windows\system32>luarocks install ltui
Installing https://luarocks.org/ltui-1.5-1.src.rock

mingw32-gcc -O2 -c -o src/core/lcurses/lcurses.o -IC:/tools/lua/include src/core/lcurses/lcurses.c
src/core/lcurses/lcurses.c:86:10: fatal error: curses.h: No such file or directory
 #include <curses.h>
          ^~~~~~~~~~
compilation terminated.

Error: Build error: Failed compiling object src/core/lcurses/lcurses.o

I built lua in Windows with the following steps

You can clone ltui source code and run xmake to build it.


[$500] Sign In - Open in app pop-up not displayed when user successfully Signed In on public room

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number: 1.4.34-1
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause-Internal Team
Slack conversation:
Action Performed:
Precondition: user should be signed out

Open public room deeplink https://staging.new.expensify.com/r/5408450846930023
Click in Sign In button
Sign In with valid email

Expected Result:
Pop-up "Open in app" should be displayed
Actual Result:
"Open in app" pop-up not displayed
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android: Native
[ ] Android: mWeb Chrome
[ ] iOS: Native
[ ] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[ ] MacOS: Desktop

Screenshots/Videos
https://github.com/Expensify/App/assets/115492554/e46f7224-660b-4adb-9bab-b15947ca4e0e

View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01b45ef5fa722b5aec
Upwork Job ID:<PHONE_NUMBER>122564608
Last Price Increase: 2024-02-02
Automatic offers:

Ollyws | Reviewer | 28144604
dukenv0307 | Contributor | 28144605

Issue OwnerCurrent Issue Owner: @dukenv0307

We think that this bug might be related to #vip-vsb

Yeah, that's a fair point. It's unclear what that relates to unless you're familiar with the app! @izarutskaya can we make sure to keep an eye on making the action steps accessible for everyone to understand? I think what you're referring to here is the desktop app?
@shahinyan11 if you install our macOS desktop app, when you open a URL on Web, there's usually a centered modal asking if you want to open the (desktop) app instead.

You can download the macOS desktop app from this page: https://new.expensify.com/settings/about/app-download-links

Thanks for the review @Ollyws, I agree with the solution. Assigning @dukenv0307 🚀

Nice! Confirming the payment summary as follows:

@dukenv0307 $500 for the fix - paid!
@Ollyws $500 for the C+ review - you need to accept the offer.

Perfect, settled up. Closing!


Why KeepAlive is default in launchd in osx?

http://apple.stackexchange.com/questions/159532/how-do-i-associate-a-launchd-2-plist-with-its-domain-and-service-targets
Apple suggest avoiding KeepAlive and RunAtLoad because the intention is to avoid ever launching a process without a guarantee of work to be done. Both keys remain and are required for many tasks.

Upstart in linux do the same thing too.
I think it should look like apache2 in ubuntu,the service do not care about keepalive default.
Ps: I can not find any document of this behavior.Is this behavior same across all platform?

Most service managers try to keep a service alive to some degree by restarting it if it fails. This is normal behavior and to be consistent, this is on by default.


Create CodeSandbox examples

React-router is one of the most used dependencies on CodeSandbox. This week I also saw that the sandbox by @pshrmn (https://codesandbox.io/s/vVoQVk78) passed the 1000 forks.
I started to think about this and I think it would be beneficial for react-router to have sandboxes of the official examples and link them in the documentation. This would allow everyone to play with the given examples and use one of the examples as a way to give an easy reproduction if they find an issue. It would also help users that search for react-router examples on CodeSandbox, because the examples cover a lot of use cases and questions.
I'd love to open a PR for this, but I first wanted to know your thoughts. I can make the sandboxes automatically stay in sync with the examples on the website and on GitHub. This means that if you change the file in Git it will be automatically reflected in CodeSandbox.
I'm curious what you think, I can open a PR if you're interested 😄 .

Is the syncing something we need to manage, or would you do so on your end? If it's all on you, I have no problem doing nothing! 😄

The syncing will work the same like we do with Redux. So this means that the source of truth is in the git repository. For every request to the sandbox we check if the commit sha has changed, and sync if it has.
I'll open a PR today! 😄

Closing in favor of keeping the discussion in #5586


Fix/error messages ts issue

This PR updated the examples for ErrorMessage to adress issue #352.

Adds TS and JS codeExamples and Code for both multi and single error.

Thanks @pmaier983 👍


implement patricia merkle trees

docs (maybe addtitonal research is needed):

https://github.com/ethereum/wiki/wiki/Patricia-Tree
https://ethereum.stackexchange.com/questions/6415/eli5-how-does-a-merkle-patricia-trie-tree-work
https://blog.ethereum.org/2015/11/15/merkling-in-ethereum/

task:

implementations should be abstract and independent of any data
place in aeutil

api (must include, can include more):

root hash
lookup with proof
verify proof
get empty
delete entry
get entry
insert entry

@meivantodorov @HristianHristov this is stuck for 11 days now, can we PR and merge?

@thepiwo this is still work in progress, and it is not stuck. When it is ready, there will be PR.

when do you think it will be ready, as #341 is depended on this and there have not been any commits in 11 days.

The work was focused on improving this library. I hope that after 2 days there will be PR.


[Help Needed] Unable to Run Game

Hi, I'm making a game and I'm unable to run it, I get this error:

What do I do?

Hi Asher, this is a duplicate of https://github.com/chrismaltby/gb-studio/issues/6 so I'm going to close this one, if you don't mind zipping up a small example project where there is happening and attaching to that issue I can look into it.

Here:
Roboventure.zip

I'm on a MacBook.

Hi Asher,
The problem was your L1.png which was 256px by 257px (1px taller than is
currently allowed), I cropped your image and the game runs now.
Attached a fixed version of the project.
I definitely need to improve the error message here so that it's clear
what's happening but if you stick to sizes with multiples of 8 you should
be fine!
https://github.com/chrismaltby/gb-studio/issues/51 is the issue I've set
for handling this.
Looks great by the way!
Thanks,
Chris
[image: Screen Shot 2019-04-25 at 2.05.07 PM.png]
On Thu, Apr 25, 2019 at 1:02 PM Asher Gomez<EMAIL_ADDRESS>wrote:

Here:
Roboventure.zip
https://github.com/chrismaltby/gb-studio/files/3116757/Roboventure.zip
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
https://github.com/chrismaltby/gb-studio/issues/57#issuecomment-486643494,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AD77W2W2AECZ2H73SBJY77LPSGMVFANCNFSM4HII7H3A
.

Hi Asher,
The problem was your L1.png which was 256px by 257px (1px taller than is currently allowed), I cropped your image and the game runs now.
Attached a fixed version of the project.
I definitely need to improve the error message here so that it's clear what's happening but if you stick to sizes with multiples of 8 you should be fine! #51 is the issue I've set for handling this.
Looks great by the way!
Roboventure_fixed.zip

Thanks!


Category-Filter: after selection of first filter remaining categories are not suggested

What happened?
When a category filter is set, the autosuggestion does not show the remaining categories. For getting the remaining categories displayed, the user needs to click out of the filter and select the filter again.
Excpected Behavior
After selecting a category-filter the remaining categories are suggested
Vendor and Product are suggested.

Vendor with filter criteria is selected. Product is no longer suggested.

After clicking out of the filter and clicking in Product is suggested again.

What type of frontend frameware are you seeing the problem on?
Angular
Which version of iX do you use?
v2.0.0
Code to produce this issue.
/* Taken from the IX-Docu: https://ix.siemens.io/docs/controls/category-filter */

import { Component } from '@angular/core';

@Component({
  selector: 'app-example',
  template: `
    <ix-category-filter
      placeholder="Filter by"
      [repeatCategories]="repeatCategories"
      [categories]="categories"
      [filterState]="filterState"
    ></ix-category-filter>
  `,
})
export default class CategoryFilter {
  repeatCategories = false;
  filterState = {
    tokens: ['Custom filter text'],
    categories: [
      {
        id: 'ID_1',
        value: 'IBM',
        operator: 'Not equal',
      },
    ],
  };
  categories = {
    ID_1: {
      label: 'Vendor',
      options: ['Apple', 'MS', 'Siemens'],
    },
    ID_2: {
      label: 'Product',
      options: ['iPhone X', 'Windows', 'APS'],
    },
  };
}

Internal ref [IX-868]


Everything breaks without semicolons

Should semicolons be optional? I'm not sure, but if not, it needs to be more clear that EVERY COMMAND MUST BE ENDED BY A SEMICOLON.

I don't mind semicolons being required, personally. I don't think it really matters too much, to be honest. :P

oppppppppppppppppptional pls

I think I can basically change
CommandSeparator -> ";"

to
CommandSeparator -> ";" | "\n"

and that should make them optional?

Should do :package:

does now

Depending on how the grammar is written, it feels like that might just throw a bunch of commandseperators everywhere there is a new line, which probably works but feels like the tokens might get a bit ugly. (I can't think of a better way to do it though :P)

@liam4 should this issue be closed?

This hasn't been fixed yet :/ I tried that change a while ago but it didn't fix it. I'll look into it more soon :P


Remove legacy SearchIndexer classes

Description
This PR removes the code related to legacy SearchIndexer.cs

Removed SearchIndexer.cs
Removed TypedSearchIndexer Feature Flag
Changed the static method call GetSearchValueTypeForSearchParamType from class SearchIndexer.cs to TypedElementSearchIndexer.cs
Removed all the Converters inside Features/Search/Converters folder, except the ones that are inside NodeConverters folders
Removed Unit Tests from SearchIndexer and Converters

Related issues
Addresses issue #1738 .
Testing
I ran all the Tests and checked that the ones that are failing are due to Culture differences (e.g. expecting '.' instead of ','). E2E tests are also failing.
FHIR Team Checklist

[ ] Update the title of the PR to be succinct and less than 50 characters
[ ] Add a milestone to the PR for the sprint that it is merged (i.e. add S47)
[ ] Tag the PR with the type of update: Bug, Dependencies, Enhancement, or New-Feature
[ ] Tag the PR with Azure API for FHIR if this will release to the managed service
Review squash-merge requirements

Semver Change (docs)
Patch|Skip|Feature|Breaking (reason)

/azp run

/azp run

LGTM, I wouldn't mind more refactoring in term of names, like IFhirNodeToSearchValueTypeConverter to just ITypedElementToSearchValueConverter and moving content of NodeConverterTests from Shared.Core.UnitTests to upper Converter folder (no need to separate them anymore), but that can be done in separate PR.

LGTM, I wouldn't mind more refactoring in term of names, like IFhirNodeToSearchValueTypeConverter to just ITypedElementToSearchValueConverter and moving content of NodeConverterTests from Shared.Core.UnitTests to upper Converter folder (no need to separate them anymore), but that can be done in separate PR.

I updated the PR with your suggestions

Thank you for doing this!
Depends on how much time you want to spend on this, I wouldn't mind a bit more of refactoring.
But first a bit of history.
We had two different things doing same work. First we had SearchIndexer and IFhirElementToSearchValueTypeConverter and converters which look like: CodeableConceptToTokenSearchValueTypeConverter
At some point we wanted to switch to different approach, but to keep old code present, so we can flip value in config and make sure both approaches are working.
That's how we get to IFhirNodeToSearchValueTypeConverter and CodeableConceptNodeToTokenSearchValueTypeConverter
One is Element and another is Node, one is SomethingToSearchValueTypeConverter, and another is SomethingNodeToSearchValueTypeConverter.
Since we removing old part of code, I don't think there is huge need to have SomethingNode because word Node was used mostly to differentiate between two types, but since first type is removed, it doesn't serve any purpose.
So it would be nice to take all current non-abstract converters and remove word Node from them, since it doesn't serve much purpose.
Tests can be renamed as well.
FhirNodeToSearchValueTypeConverter and FhirNodeToSearchValueTypeConverterManager file can be renamed to FhirTypeElementTo.... (to get rid of that Node notion)
It's not necessery, and up to your desire to mess with a code :)

In reply to: 814469138 [](ancestors = 814469138)


[EFR32] Window Covering app modified to compile on boards without LCD.

Problem
The Window Covering app is not compiling for BRD4166a.
Change overview
Guards added to remove the LCD-dependent code from the app.
Testing
Tested on BRD4164a (WSTK) and BRD4166a (TBS2).

master 1.0 approval reason: fixes compilation of existing example.


Add command line option '--foreground #rrggbb'

I manage about 20 systems and am able to open a terminal to any one of them over ssh.  I have a different font colour which helps me recognise what system I'm on.  Can a new command line option be added  '--foreground #rrggbb' so that I can use only the one default config yml file?  I'm already very impressed by alacritty and would like to see it become even more useful.  Many regards.

I don't think making this a dedicated command line flag makes much sense for most users, however the proposal has come up before to allow overriding any configuration file setting from the command line.
Please see https://github.com/jwilm/alacritty/issues/1258 for more info. That should resolve this issue too, so closing this as a duplicate.

Thanks Chris.  I'll keep an eye on what happens in the other thread.  Looks like https://crates.io/crates/config can may be quite useful.  Keep up the good work.


"Quick Open..." dialog on Linux doesn't always put the focus into the text field

Godot version
4.1.1, 4.2
System information
Linux, PopOS!
Issue description
When using the "Quick Open..." dialog it will sometimes appear and the focus is NOT in the text field and there's no way to get the focus in there without mouse clicking on it. This is frustrating and slows the developer down by having to reach for the mouse.
Steps to reproduce
Unfortunately, it's fairly random and I don't know what causes it.  It feels like it does this maybe 20% of the time I open that dialog, but it's hard to say.  It feels like a timing issue of some kind but that's just a wild guess.
Minimal reproduction project

I can 100% reproduce this on v4.3.dev6.official [64520fe67].
Open the script editor as a dockable window and use the Quick Open shortcut.
The window will open up and the search will be focused but not the window itself!
I remember also randomly when the script editor was docked, sometimes there was a chance that it could also have the same issue, which might actually be the main issue here.

Cant reproduce it in 4.3.rc1 and 4.3.stable so this might have been fixed by: https://github.com/godotengine/godot/pull/93682


Finish stretchy character support and add bbox support

This PR finishes the stretchy character support (by adding the multi-character support).  It also adds a font data object and uses that to hold the information about delimiters, character bounding boxes, and TeX font parameters for the font, so the TeX font parameters have been moved from where they were.
This also implements bbox computations for TextNodes and mo nodes (which should make the bonding boxes correct for mrow as well, but mfrac still needs work).
This PR is targeted to the stretchy-chars branch, so the you don't see all those original files as well.  If you want, I can merge this into stretchy-chars and you can review them as a whole (but I was trying to do incremental updates to keep the reviews small).  Since this does make changes to stretchy-chars, it might be easier not to have to look at the originals but only final versions at this point.  Let me know how you want to handle it.

Just realized I forgot to tslint and add some of the jsdoc comments, so hold off on this until I do that.  Sorry!

OK, I've linted and added the missing jsdoc comments.  So this should be ready to review.

I found some documentation on my proposed changes:
https://www.typescriptlang.org/docs/handbook/release-notes/typescript-2-1.html
under "spread and rest", as well as here:
https://github.com/tc39/proposal-object-rest-spread/blob/master/Spread.md

I have addressed all the issues either by making the change, or explaining the reason for the original code (except for one typo that I couldn't find).  Can you take another look?

I approve. But somehow my approve button is gone.

It's probably the merge conflict. Anyway, some of your comments to my review should probably be kept for posterity. They are very good!

I've added the comments that you asked for into FontData.js.  Let me know if you want any of the others as well.
I've fixed the merge conflict, but I don't see an approval button anymore either, so I'm just going to merge it.


Silent Authentication of Existing Authenticated User On Specific Page

I don't have an issue, this is a question (not sure how to set it to a question).
I have a web app with SSO authentication. Within the app, there is a page that accesses a separate API. The page in itself is a separate react project (technically an SPA in itself) injected into the main web app. The user is already logged in and is required to be in order to access this specific page.
The page is using oidc-client-ts to authenticate the existing user.
It does pick up the main web app cookie and authenticates the user to access the API (a separate token is required to access endpoints). The API is a separate project as well, but uses the same identity provider as the main web app.
What we are trying to do is avoid the 3 redirects as it authenticates the existing user to access the API. We have tried a multitude of different theories, including a hidden custom iframe that would do the authentication and handle the redirects, then write the token to storage, but the entire page is still redirecting.
We are using ASP.NET to serve the main web app, and the API is also an ASP.NET backend. We are using React on the frontend.
Can anyone suggest anything that may result in zero page redirects while silently authenticating the existing user (we do not need to redirect to a login page, since that was already done to sign into the main web app).
Thank you in advance :)

This issue (question) staled, closing it for now.


Use get_last_sys_error() instead of get_last_rtl_error()

get_last_sys_error() already exists, so there's no need for yet
another macro that fulfills the same purpose.
Fixes #4120

Note: has been confirmed to work right by #4120 author

My question is why was it called get_last_rtl_error to start with? Who has it? Basically what I'm saying is that it would be more appropriate to replace get_last_rtl_error with something we already have to such circumstances than to accommodate it.

Like what, get_last_socket_error?  But get_last_rtl_error is used with fcntl, which isn't purely a socket function, and we cannot count on get_last_socket_error to provide the corresponding error (it's possible that Window just happens to use the same underlying function, but I do not trust Microsoft to be consistent)

I do not trust Microsoft to be consistent

But why do you trust somebody on Internet who suggest to add get_last_rtl_error? Was it actually more consistent solution? I actually can't see that it is. Anyway, if we are talking about Microsoft, MSVCRT has no fcntl. And if there was, it would be part of "POSIX [band-]aid" thing, which would use errno, as the rest of "POSIX [band-]aid".

Like what, get_last_socket_error?

No, rather get_last_sys_error.

Ah, now that makes sense.  I hadn't noticed get_last_sys_error(), thanks for pointing it out.  Commit changed accordingly, along with this PR's title and description.

On related note this actually calls for following question. It's obviously a code path that is not exercised by absolute majority. How do we know it's even right for that unknown system that suffers from this problem? I mean now it compiles there, but is code path in question right in its entirety? Maybe the problem is triggered by malformed or non-standard headers, in which case it would be appropriate to have user solve that problem? As opposite to creating formally incorrect impression "if-it-compiles-then-it-has-to-be-right"... Questions are rhetorical, just think about these, all the time...

Well, it comes back to "how do we trust code thrown at us for systems we have no access to?"

Approval noted, will merge.

Merged.
master / 1.1.1:
b4c35656441929ce6f6be112648d637cba51dc91 Use  get_last_sys_error() instead of get_last_rtl_error()
1.1.0:
e00fa4ee53e05fac63b5a25f8e9ea71a1ec59c33 Use  get_last_sys_error() instead of get_last_rtl_error()


Issues with training : Dataloader not iterable

I am training the model using the following command

python tools/train_net.py --dataset coco2017 --cfg configs/baselines/e2e_mask_rcnn_R-50-C4_1x.yaml  --bs 8 --nw 4

The dataset is getting loaded properly but I am getting an error in line 327 on train_net.py
for args.step, input_data in zip(range(args.start_iter, iters_per_epoch), dataloader):
The error says :  The argument#2 of zip must be iterable.
Please help. Thanks

train_net.py is deprecated. Use 'train_net_step.py` instead.


TagBot trigger issue

This issue is used to trigger TagBot; feel free to unsubscribe.
If you haven't already, you should update your TagBot.yml to include issue comment triggers.
Please see this post on Discourse for instructions and more details.
If you'd like for me to do this for you, comment TagBot fix on this issue.
I'll open a PR within a few hours, please be patient!

Triggering TagBot for merged registry pull request: https://github.com/JuliaRegistries/General/pull/83312

Triggering TagBot for merged registry pull request: https://github.com/JuliaRegistries/General/pull/86343

Triggering TagBot for merged registry pull request: https://github.com/JuliaRegistries/General/pull/90557

Triggering TagBot for merged registry pull request: https://github.com/JuliaRegistries/General/pull/92124

Triggering TagBot for merged registry pull request: https://github.com/JuliaRegistries/General/pull/93830

Triggering TagBot for merged registry pull request: https://github.com/JuliaRegistries/General/pull/99311

Triggering TagBot for merged registry pull request: https://github.com/JuliaRegistries/General/pull/115286

Triggering TagBot for merged registry pull request: https://github.com/JuliaRegistries/General/pull/119857


create logic for loading a camel catalog for a specific version

requires the model classes #8

I think that we can start with a single version of Camel as a first step.

work started on https://github.com/apupier/camel-language-server/tree/9-ProvidePossibilitiesToUseDifferentCatalogVersion with a nice test which is showing that it is currently not working


BUG: 1.9.1 pypi package seems to be compiling extensions with the --inplace distutils option on

Describe your issue.
When installing scipy using pip, all shared objects are dumped in site-packages instead of their respective folders
Reproducing Code Example
Run in a fresh docker python:3.10.7-alpine3.16
$ pip install scipy==1.9.1
$ python
>>> import scipy
...
 from . import _ccallback_c
 ImportError: cannot import name _ccallback_c

$ find / -name _ccallback_c.cpython-310-x86_64-linux-gnu.so
/usr/local/lib/python3.10/site-packages/_ccallback_c.cpython-310-x86_64-linux-gnu.so

this one should be in /usr/local/lib/python3.10/site-packages/scipy/_lib/

Error message
ImportError: cannot import name _ccallback_c

SciPy/NumPy/Python version information
1.9.1 / 1.23.3 / 3.10.7

Hi @sieira, thank you for reporting.  Otherwise disregard the following. Was the output of pip install concluent? It should have tried to compile SciPy as we do t provide wheels for musl yet. I would be inclined to close this as we already have a musl issue.

The distribution packages are not suitable in my case, however, it actually seems to be an issue of the python docker image that is not setting an adequate PYTHONPATH. So, I'm closing this...


Incorrect implementation of euclidean distance in facenet.py

https://github.com/davidsandberg/facenet/blob/master/src/facenet.py#L412
Euclidean distance is the square root of the differences of the squares of the vectors. Should be
diff = np.subtract(embeddings1, embeddings2)
dist = np.sqrt(np.sum(np.square(diff), 1))

Correct me if I'm missing something obvious.

I think it is not that important to do the sqrt. Only if you keep it consistent, it is just fine.


Project missing the license file

Individual files have the Apache 2.0 license, but the repo is missing a license file. Please add a license file.
This one is from the librealsense repo: https://github.com/IntelRealSense/librealsense/blob/master/LICENSE

Thank you for adding the license file.


Idva6 790 email producer

Short description outlining key changes/additions
An email service that can be used to send one of six email types.
JIRA Ticket Number
IDVA6-790
Type of change

[ ] Bug fix
[x] New feature
[ ] Breaking change
[x] Infrastructure change

Pull request checklist

[x] I have added unit tests for new code that I have added
[x] I have added/updated functional tests where appropriate
[x] The code follows our coding standards

An exhaustive list of peer review checks can be read here

CI: Security warnings found!

CI: Security warnings found!

CI: Security warnings found!


chore: release main

:robot: I have created a release beep boop
@opentelemetry/auto-instrumentations-node: 0.27.4
Dependencies

The following workspace dependencies were updated

dependencies

@opentelemetry/instrumentation-aws-sdk bumped from ^0.5.0 to ^0.5.1
@opentelemetry/instrumentation-fastify bumped from ^0.25.0 to ^0.26.0
@opentelemetry/instrumentation-graphql bumped from ^0.27.3 to ^0.27.4
@opentelemetry/instrumentation-ioredis bumped from ^0.27.1 to ^0.28.0
@opentelemetry/instrumentation-mongodb bumped from ^0.28.0 to ^0.29.0
@opentelemetry/instrumentation-mysql bumped from ^0.27.1 to ^0.28.0
@opentelemetry/instrumentation-mysql2 bumped from ^0.28.0 to ^0.29.0
@opentelemetry/instrumentation-redis bumped from ^0.28.0 to ^0.29.0
@opentelemetry/instrumentation-winston bumped from ^0.27.0 to ^0.27.2

browser-extension-autoinjection: 0.27.4
0.27.4 (2022-02-28)
Bug Fixes

browser-extension-autoinjection: update eslint-plugin-json5 version to 0.1.4 (#896) (e47fcaa)

instrumentation-aws-sdk: 0.5.1
0.5.1 (2022-02-28)
Bug Fixes

opentelemetry-instrumentation-aws-sdk: error when ReturnConsumedCapacity is set to None (#899) (e7ab4d0)

Dependencies

The following workspace dependencies were updated

dependencies

@opentelemetry/propagation-utils bumped from ^0.26.0 to ^0.27.0

instrumentation-fastify: 0.26.0
0.26.0 (2022-02-28)
Features

new fastify instrumentation (#611) (77c215b)
upstream mocha instrumentation testing plugin from ext-js #621 (#669) (a5170c4)
use latest instrumentation base (#769) (7aff23e)

Bug Fixes

fastify and browser autoinjection failed to compile (#793) (c08efa8)
typo in fastify description (#891) (adbd6dc)
update some dev-deps in fastify instrumentation (a20f77b)
use localhost for services in CI (#816) (f497313)

instrumentation-graphql: 0.27.4
0.27.4 (2022-02-28)
Bug Fixes

graphql: fix graphql.operation.name field (#903) (5529261)

instrumentation-ioredis: 0.28.0
0.28.0 (2022-02-28)
⚠ BREAKING CHANGES

ioredis: net.peer.ip -> db.connection_string

Bug Fixes

ioredis: net.peer.ip -> db.connection_string (986c349)

instrumentation-long-task: 0.28.0
0.28.0 (2022-02-28)
Features

Long Tasks instrumentation (#757) (56d332e)
longtasks: allow callback to add span attributes on collection (#863) (1f68004)
upstream mocha instrumentation testing plugin from ext-js #621 (#669) (a5170c4)

Bug Fixes

rename lerna's --include-filtered-dependencies option (#817) (cf268e7)

instrumentation-mongodb: 0.29.0
0.29.0 (2022-02-28)
Features

mongodb4: added mongodb4 instrumentation (#869) (47700e1)

instrumentation-mysql: 0.28.0
0.28.0 (2022-02-28)
⚠ BREAKING CHANGES

mysql,redis:* net.peer.ip -> db.connection_string

Bug Fixes

mysql,redis:* net.peer.ip -> db.connection_string (bf39b90)

instrumentation-mysql2: 0.29.0
0.29.0 (2022-02-28)
⚠ BREAKING CHANGES

mysql,redis:* net.peer.ip -> db.connection_string

Features

add mysql2 responsehook (#915) (f436601)
support mysql2 v1 (#908) (d3883d3)

Bug Fixes

mysql,redis:* net.peer.ip -> db.connection_string (bf39b90)

instrumentation-redis: 0.29.0
0.29.0 (2022-02-28)
⚠ BREAKING CHANGES

mysql,redis:* net.peer.ip -> db.connection_string

Bug Fixes

mysql,redis:* net.peer.ip -> db.connection_string (bf39b90)
opentelemetry-instrumentation-redis: add condition before error print (#897) (f1d2fd0)

instrumentation-winston: 0.27.2
0.27.2 (2022-02-28)
Bug Fixes

documentation: mixed up winston readme for hook (#910) (0a557e8)

propagation-utils: 0.27.0
0.27.0 (2022-02-28)
Features

instrumentation-aws-sdk: upstream aws-sdk instrumentation from ext-js (#678) (f5851e7)
upstream mocha instrumentation testing plugin from ext-js #621 (#669) (a5170c4)

Bug Fixes

rename lerna's --include-filtered-dependencies option (#817) (cf268e7)

This PR was generated with Release Please. See documentation.

This was a test to see if the release-please fix works.


Delete redundant call to open logout modal

Resolves AB#711 - probably

I can't see how this fixes the linked issue; its more likely that force logout isn't reset properly? This will remove the logout modal but the user is still erroneously logged out?

I can't see how this fixes the linked issue; its more likely that force logout isn't reset properly? This will remove the logout modal but the user is still erroneously logged out?

Yeah actually it probably doesn't, but this makes the forced logout follow the same steps as a regular logout, the modal is called to open inside vcSession_Logout

After testing, it seems to work as expected either way so I imagine this was fixed and just not closed


shift-tab causes app to exit

termbox shows this as a sequence that includes key=Z - \x1b[Z

FWIW, this doesn't happen with tcell #232

Fixed in #232


Expose branch_name_prefix in common\lib\dependabot\pull_request_creator.rb

I would like to expose branch_name_prefix so it can be configurable.
The reasoning is that I am running dependabot against an Azure DevOps repository. I run dependabot multiple times against this repostory using separate directories as filters. I would like for each directory potentially create independent PR's even for the same dependencies. The easiest way I see to accomplish this is to set the branch_name_prefix independently for each directory.

I'm using dependabot-core directly and I am able to create dependency updates for the same dependency in different directories because branch name actually includes the directory dependency is located in. https://github.com/dependabot/dependabot-core/blob/main/common/lib/dependabot/pull_request_creator/branch_namer.rb#L49

It sounds like the problem is how dependabot-core is being executed since it's not done directly but instead via the tinglesoftware/dependabot-azure-devops wrapper... many thanks to @mburumaxwell for documenting how to set this up
https://github.com/tinglesoftware/dependabot-azure-devops/issues/334#issuecomment-1250694422 to preserve the directory names.

Also I closed because I'm reasonably confident this is working as expected and just requires tweaking your config, but if for some reason this isn't resolved via the config mentioned ☝ please comment and we can re-examine...


[Wave Collect] [Xero] Import page - The app crashes when navigating to Xero Import Page for the first time.

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number:
Reproducible in staging?:
Reproducible in production?:
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by:
Slack conversation:
Action Performed:

Go to Workspace => Accounting
Choose Setup button next to Xero.
Continue with Xero setup
Notice that App crashes right after user finished the setup.

Expected Result:
Describe what you think should've happened
Actual Result:
Describe what actually happened
Workaround:
Can the user still use Expensify without this being fixed? Have you informed them of the workaround?
Platforms:

Which of our officially supported platforms is this issue occurring on?

[x] Android: Native
[ ] Android: mWeb Chrome
[ ] iOS: Native
[ ] iOS: mWeb Safari
[ ] MacOS: Chrome / Safari
[ ] MacOS: Desktop

Screenshots/Videos
Add any screenshot/video evidence
https://github.com/Expensify/App/assets/16502320/c93ce660-dee1-44f4-9fd5-54311ffc1bee

View all open jobs on GitHub

cc @lakchote

Looks like the bug is fixed. We can close this issue
https://github.com/Expensify/App/assets/29673073/00f2db22-1ea6-480c-a52b-7e532f3ea721

I've experienced some issues that prevent me from connecting to the IS server right now

Looks like the bug is fixed. We can close this issue

I had trouble with my android environment so to save time, I've asked @rushatgabhane to double check (thank you).
Looks like everything is fine, @hungvu193 could you test it again please?

I'm afk but will test it ASAP

Confirmed it's fixed 🎉. Closing
https://github.com/Expensify/App/assets/16502320/1a9fd6d6-57db-475a-9aaa-23121e400d30


How to test upload speed ?

I didn't find any code about upload-speed-test in your Demo .

This speed is not directly related to your download and upload behavior. The key principle is to calculate the import and export traffic of the network card per unit time.


Add support for subqueries

This request was hidden under another issue in this comment. I'm creating its own dedicated ticket.
From the comment:

I was doing some reading on how people solve this problem and came across this article that talks about how this could be achieved using just a single query and keeping it efficient as well using subqueries.

Although this article is written for PHP (and for Laravel framework), I think this could be added in ktorm as well. I found other examples online where subqueries make writing complex queries very intuitive and keeps it within ORM boundary.

Here is the article (you don't have to read the whole article if you don't want to, you can stop when it starts talking about macros but I highly recommend reading the whole thing as you might find a gem or two to add in ktorm): https://reinink.ca/articles/dynamic-relationships-in-laravel-using-subqueries

We ran into this limitation today - subqueries seem common and important enough that I believe a fix should be prioritized. Is there any known difficulties that one should know about if attempting to implement it?


[Enhancement] Add missing specs to links page

Add missing specs to the links page including:

Hex values for link states (throughout)
Specs for call-to-action link
Simplified styling for destructive link

Before and after
Inline links

Added the hex values so that what a designer sees in code (inspector) matches what's in the specs.

Current
Update

Call-to-action links

No current specs existed.
Consideration: Should we cross link between call-to-action links and list links? Are they the same thing?

Current (no specs)
Update

Destructive links

Optional: Add styling info for states
Bug: Implementation tab is showing even though it contains no content

Current
Update

Looking for review (optional): @meissadia @anselmbradford @jenn-franklin @chaisamantha

Thanks for updating and adding specs! Here are some thoughts:
General: Love the addition of hex codes next to color names. Would it be helpful to write specs that follow CSS formatting? So, instead of 1px dotted bottom border, it would be border-bottom: 1px dotted Pacific Blue (#0072ce). The updated call-to-action specs uses similar formatting. For focus states, it would be outline: thin dotted instead of thin dotted outline.
Call-to-action links: For When links appear as a part of a list section, I think it would be helpful to also add an image that helps visualize the specs between items. Here is a quick mockup:

Destructive links: I think it’d be helpful to include the font weight and size because destructive links aren’t grouped with call-to-action links.

Ok here's a start on those updates:
Inline links

Added the formatting identifiers to more closely align with CSS properties (see note below).

R1
R2

Destructive links

Added font weight and size

R1
R2

If we were to actually add the specs as they appear in the CSS we would actually break it up a lot more than what is described here. I think this is worth discussing as a more global item. How do we want to format specs? Should the properties be labeled and ordered as they appear in CSS?
The link styling includes all of these properties (and more):

Font-family
Font-weight
Font-size:
Color:
Border-width
Border-style:
Border-color:
Outline:

I'll open up another issue to discuss the specs styling more globally. For now I'd like to go ahead and push these iterative updates.

Closing this out because I have updated and published the specs on the links page. I will open a separate discussion issue regarding the way we write UI specs.


AttributeError: 'int' object has no attribute '_root'

C:\Program Files\Python310\lib\runpy.py:126: RuntimeWarning: 'fishy.main' found in sys.modules after import of package 'fishy', but prior to execution of 'fishy.main'; this may result in unpredictable behaviour
warn(RuntimeWarning(msg))
created backup
launching please wait...
Traceback (most recent call last):
File "C:\Program Files\Python310\lib\runpy.py", line 196, in _run_module_as_main
return run_code(code, main_globals, None,
File "C:\Program Files\Python310\lib\runpy.py", line 86, in run_code
exec(code, run_globals)
File "C:\Users\acnig\AppData\Roaming\Python\Python310\site-packages\fishy_main.py", line 105, in
main()
File "C:\Users\acnig\AppData\Roaming\Python\Python310\site-packages\fishy_main.py", line 84, in main
if not gui.check_eula():
File "C:\Users\acnig\AppData\Roaming\Python\Python310\site-packages\fishy\gui\terms_gui.py", line 16, in check_eula
run_terms_window()
File "C:\Users\acnig\AppData\Roaming\Python\Python310\site-packages\fishy\gui\terms_gui.py", line 43, in run_terms_window
check_value = tk.IntVar(0)
File "C:\Program Files\Python310\lib\tkinter_init.py", line 564, in init
Variable.init(self, master, value, name)
File "C:\Program Files\Python310\lib\tkinter_init.py", line 372, in init
self._root = master._root()
AttributeError: 'int' object has no attribute '_root'

All I do with YT tutorial powershell runing as admin and all install and upgrade done without problems just last line with runing bring back this error.
How to solve it ?

You are using Python 3.10. Fishy only works on 3.7.
See https://github.com/fishyboteso/fishyboteso/wiki/Installation


Rate limiting middleware

Description
Middleware to limit amount of incomung requests.
Code reviewers

[ ] @github_username

Second Level Review

[ ] @github_username

Summary of issue
ToDo
Summary of change
ToDo
Testing approach
ToDo
CHECK LIST

[ ]  СI passed
[ ]  Сode coverage >=95%
[ ]  PR is reviewed manually again (to make sure you have 100% ready code)
[ ]  All reviewers agreed to merge the PR
[ ]  I've checked new feature as logged in and logged out user if needed
[ ]  PR meets all conventions

Still in progress. Waiting to dev ops research server capabilities to proper set up mw.


ipad private browsing does not work and does not explain why

Today I had a teacher who used an (recently bought) ipad (safari browser) and wanted to use the pxt editor. The page loaded, but the editor did not load, it was stuck at the black screen with microbit logo. We later found out this was because the browser was in private mode.
Please add a text that explains why the editor does not load, and how to fix this.
(I have seen this explaining text once before when using an iphone, but that was not clear enough; it still took us a lot of time to find the setting)

In general, we should support restricted modes like this. We store the data in memory rather than using localstorage/indexeddb. However, in the case of the iOS, it is going to have some bad side effects:

user writes code, presses download
custom url takes user to microbit app for BLE flashing
microbit app sends user back to safari
page gets reloaded.... and the program is gone!

If it is impossible to use it in private mode I won't stop you from forcing normal mode, but at least explain how to do that. Most people don't even seem to know that private mode exists.

Yup, we'll close that door and update the docs.

The combination of iOS + no local storage should be refused.

I ran into this issue again last week on an iphone. The editor looks stuck in the loading part where it shows the microbit logo on a black background, with no explanation of why it does not load. Impossible to understand as a user if you don't know the reason.


Endpoints / pages being called in Chrome that shouldn't be called while loading page

Describe the bug
Not 100% sure if i'm doing something wrong but i expect this to be a bug since i can only reproduce it in Chrome and not on any other browser (didn't try Edge).
What is going wrong?
While navigating through my project and loading some pages i see endpoints being called that shouldn't be called. This only happens in Chrome and doesn't happen in Firefox or Safari. Easiest way to explain it is via a screen recording that can be found here, https://share.cleanshot.com/CT23BF8lyeiQ1gIJeu7L
I added a console.log in each endpoint that is called when the endpoint is triggered, while clicking through the site with Chrome you will notice that multiple console.logs are logged to the terminal after a click while clicking through the exact same website with Firefox only 1 console.log is logged to the console.
Reproduction
The exact same code as used in the video can be found here, https://github.com/ReindDooyeweerd/sveltekit-bug
Logs
No response
System Info
System:
    OS: macOS 12.4
    CPU: (16) x64 Intel(R) Core(TM) i9-9980HK CPU @ 2.40GHz
    Memory: 984.67 MB / 32.00 GB
    Shell: 5.8.1 - /bin/zsh
  Binaries:
    Node: 16.15.0 - ~/.nvm/versions/node/v16.15.0/bin/node
    npm: 8.5.5 - ~/.nvm/versions/node/v16.15.0/bin/npm
  Browsers:
    Chrome: 102.0.5005.61
    Chrome Canary: 104.0.5096.0
    Edge: 102.0.1245.30
    Firefox: 100.0.1
    Safari: 15.5

Severity
annoyance
Additional Information
No response

@dominikg here's the content of the .env file, GRAPHQL_ENDPOINT=https://cms.sim-racer.nl/graphql. I opened up that API so it's publicly available.
The prefetch, preload and so on is one i haven't thought about that but after checking i don't find any on those pages, only modulepreloads. Strange thing is, in the network tab of Chrome i don't see those endpoints being called multiple times also.
I made another video, network tab of Chrome and the Node process in the terminal, https://share.cleanshot.com/U8cahLrIDNmXupmw8qfQ
So i only see those multiple endpoints being called in the Node process and not in the inspector tab of Chrome itself, also checked in Edge, same behaviour (obvious ;) ).

you also have to add graphql as a devDependency for it to work.
Once you do and add logging of params.slug to your endpoints you can see that the requests stem from favicon.ico requests.
This feels similar to https://github.com/sveltejs/kit/issues/3748
And there is also https://github.com/sveltejs/kit/issues/4968
So you should probably fix your favicon setup (there is no favicon.ico and also no <link rel="icon"> in head of your app.html) and do not call fetch if the slug is a static asset.

@dominikg i think you are right, tested it and that seems to be the solution so i'll close this one. Thanks for the help!


labels: extract common code between slice and stringlabels

This reduces bulk and should avoid issues if a fix is made in one file and not the other.
A few methods now call Range() instead of range, but nothing performance-sensitive.

Thanks!


Python bindings: skip tests that cannot run on PyPy due to the use of sys.getrefcount

On conda-forge we also build with PyPy (https://www.pypy.org/). All tests work fine, except for two that use sys.getrefcount that is an implementation detail of CPython (see https://github.com/conda-forge/pysynphot-feedstock/pull/7#issuecomment-1300329664). This PR propose to skip those tests on PyPy.

Are you 100% sure that the bindings work with PyPy? We have not tested it at all, I'm hesitant to give an impression that this is supported unless you have good reasons to believe that this is actually functioning correctly.

Are you 100% sure that the bindings work with PyPy? We have not tested it at all, I'm hesitant to give an impression that this is supported unless you have good reasons to believe that this is actually functioning correctly.

All the test suite (except for these two tests) pass fine.

Closing anyhow as I had a misunderstanding on the use of pytest/absltest. I will reopen when I will now that also the skip test logic is working.

Ok, now the PR should be working fine. Beside running all the testsuite, I also tried the rendering code in https://github.com/deepmind/mujoco/blob/2.3.0/python/LQR.ipynb with PyPy 3.9 and it was working fine.
Anyhow, clearly any change not related to a configuration that you test in your CI (including for example the use of non-vendored dependencies) is prone to break in the future, either by change in mujoco or in its chain of dependencies. The only reason I submitted this PR is that it seemed quite a minor change that did not interfere in any way with the existing functionality, and could have been useful for other users that used PyPy with MuJoCo. If you fear that this could lead misunderstanding on PyPy being actually officially supported, I think the possible options are:

Not merge anything related to PyPy. Note that probably this could apply also to any other non-tested configuration (CMake option, dependency version, ..)
Merge PyPy-related changes, but clearly documenting that this is not an officially supported configuration. This is what some opensource project do, see "Tier 3" in ROS2 (https://www.ros.org/reps/rep-2000.html#support-tiers), "Community Triplet" in vcpkg (https://vcpkg.readthedocs.io/en/latest/users/triplets/).

I am fine with either choice.

I'm ok with adding these minor PyPy-specific escape hatches, but could you add comments next to the pypy exclusion lines that says PyPy is not supported?

I'm ok with adding these minor PyPy-specific escape hatches, but could you add comments next to the pypy exclusion lines that says PyPy is not supported?

Done!


Removing tmclient.IsTimeoutError.

Instead using the context deadline. The underlying gRPC error code has
been removed in recent gRPC builds.
@michael-berlin this should do it?

This change is

Previously, alainjobart (Alain Jobart) wrote…
> #### Removing tmclient\.IsTimeoutError\.
>
> Instead using the context deadline. The underlying gRPC error code has
>
> been removed in recent gRPC builds.
>
>
>
> @michael-berlin this should do it?
>
>
>

Review status: 0 of 6 files reviewed at latest revision, 1 unresolved discussion.

go/vt/tabletmanager/agentrpctest/test_agent_rpc.go, line 173 [r1] (raw file):

		t.Fatal("agentRPCTestDialExpiredContext: RPC with expired context did not fail")
	}
	select {

This check is not relevant for testing the dial() code because it doesn't change the context.
Because of that maybe add here a comment like this:
"// The context was already expired when we created it. Here we only verify that it returns the expected error."

Comments from Reviewable

Removed the flaky test.
Previously, michael-berlin (Michael Berlin) wrote…
> :lgtm:

Review status: 0 of 6 files reviewed at latest revision, 1 unresolved discussion.

go/vt/tabletmanager/agentrpctest/test_agent_rpc.go, line 173 [r1] (raw file):
Previously, michael-berlin (Michael Berlin) wrote…
> This check is not relevant for testing the dial() code because it doesn't change the context.
>
> Because of that maybe add here a comment like this:
>
> "// The context was already expired when we created it. Here we only verify that it returns the expected error."

Done.

Comments from Reviewable


Add WebAppManifest for browser chrome styling on android

A template for this can be found here though we'll want to update some of the info and not add stuff for web push.

Added in 9a642ef0c78f7e1f5af43fd23332f717ea4cf58b, 749e46985a9c127c63ae642bea98e0f0f17780e1, and 760a7ed1e1fd4d6badb7371569c17561f40cf06e


vswhere not reporting any installs after 2019

I have currently installed Visual Studio Professional 2017. For some odd reason after installing 2019 bricked my 2017 install where it could not find any of the header files. After a complete uninstall of both products and reinstall of ONLY 2017, vswhere refuses to find my install, which is breaking my builds.
I've tried vswhere -all, vswhere -products *, etc to no avail. What does vswhere check so I can fix it?

The query API version is not in the header, which means it is not installed. Try repairing Visual Studio 2017 and see if that fixes the issue.

I have done repair, full uninstall and reinstall with no changes. What query API or which headers should vswhere be checking (that's not getting fixed via repair or reinstall)?

As indicated by the referenced issue above, I have just found issues using vswhere after installing the Visual Studio 2019 build tools inside a container.
For convenience, here's a link to the page containing the steps to produce such a container:
https://docs.microsoft.com/en-us/visualstudio/install/build-tools-container?view=vs-2019
When running vswhere, no output is produced, and the only thing installed in this container was the Visual Studio 2019 build tools.
PS C:\> & 'C:\Program Files (x86)\Microsoft Visual Studio\Installer\vswhere.exe' -all
Visual Studio Locator version 2.6.7+91f4c1d09e [query version 2.0.2250.60958]
Copyright (C) Microsoft Corporation. All rights reserved.

PS C:\>

Just thought I'd mention this here in case you were interested in being able to reproduce the issue locally for debugging purposes.

Same issue here, same cause, remains unfixed after uninstall/re-install. Seems to break some utilities that require visual studio installation detection.

@Rychard, that is a separate issue. -all does not find all products. According to -h, you need to pass -products * to find any products. By design, vswhere.exe finds only Visual Studio SKUs including Community, Professional, and Enterprise.

@kiwidoggie a repair should've fixed the issue, but since it did not, please open an elevated PowerShell prompt and run the following:
install-module -scope currentuser MSI # answer Y to any prompts to install nuget.exe
get-msirelatedproductinfo '{1571205C-BAD1-4237-BFE6-B77E622C51DB}'

If that returns a result, run:
get-msirelatedproductinfo '{1571205C-BAD1-4237-BFE6-B77E622C51DB}' | repair-msiproduct

@Rychard that's a duplicate of #177 and many others and unrelated to this one.

I had the same problem.  VS repair did not work.  However, @heaths' suggestion did work for me.

I had the same problem. VS repair did not work. However, @heaths' suggestion did work for me.

This appears to fix vswhere for me, still is a bug that needs fixing on the VS team's side.

A repair should have fixed it. Please run https://aka.ms/vscollect and attach %TEMP%\vslogs.zip to a new feedback issue you can file from the Feedback icon in the upper-right corner of the Installer UI. Do not share the files via GitHub since they contain PII. With a feedback ticket, it is tied to your account and only we can see them long enough to hopefully diagnose why a repair did not work.

Thank you I will.


Cannot use QuillBaseToolbar because QuillBaseToolbarConfigurations is not exported

Is there an existing issue for this?

[X] I have searched the existing issues

Steps to reproduce
I tried to use QuillBaseToolbar to specify my own sequence of toolbar buttons but I cound not use it because QuillBaseToolbarConfigurations is not exported from package.
Expected results
QuillBaseToolbar(
  configuration: QuillBaseToolbarConfigurations(),
)

Actual results
QuillBaseToolbar(
  configuration: QuillBaseToolbarConfigurations(), // QuillBaseToolbarConfigurations isn't defined
)

Code sample
No code
Screenshots or Video
No response
Logs
No response
Flutter Doctor output (optional)
No response

QuillBaseToolbar

Hi again, did you used the latest version of flutter quill?

Is there an existing issue for this?

[x]  I have searched the existing issues

Steps to reproduce
I tried to use QuillBaseToolbar to specify my own sequence of toolbar buttons but I cound not use it because QuillBaseToolbarConfigurations is not exported from package.
Expected results
QuillBaseToolbar(
  configuration: QuillBaseToolbarConfigurations(),
)

Actual results
QuillBaseToolbar(
  configuration: QuillBaseToolbarConfigurations(), // QuillBaseToolbarConfigurations isn't defined
)

Code sample
No code
Screenshots or Video
No response
Logs
No response
Flutter Doctor output (optional)
No response

This issue is fixed in the latest versions of flutter_quill I think you are using 8.2.0 or something like this
Please try to using the latest version instead which is 8.5.5


Picker fails in a modal

The datetimepicker doesnot open the pop-up in a modal.

This is happening to me as well. It is popping up behind the modal.

Add   z-index:2000 to the  angularjs-datetime-picker class.


:four_leaf_clover: Proposal: Add More ut to the configloader Package

What Would You Like to Add? Why Is This Needed?

We have a function named LoadConfig() in internal/pkg/configloader/config.go:29. This is the entry logic of the configloader package. I'd like to add some ut to this function.
ut samples: internal/pkg/configloader/configloader_test.go
config file format ref: examples/gitops.yaml
Please check gingko's documentation before you start writing ut.
Design
Maybe you can generate some correct wrong configuration files, write them to disk, and then go use them in ut; finally remember to clean up any temporary files generated.
Anything else

About how to test the config logic locally, see #655 for more details.
Take the first step, go for it! Feel free to contact me if you have any difficulties.

I want to do it.

@DunyuSong Go for it, happy coding!

Feel free to ask me for any help. Development is not urgent, just take your time at your pace. @DunyuSong

For this issue we can start by keeping it simple, i.e. testing only the LoadConfig function without testing the three small functions inside it.
You can construct different function inputs (the correct config file can be found in #655, or you can construct some incorrect config file) and then determine if the output of LoadConfig is as expected (return the correct *Config, or return an error when the config file is incorrect).
@DunyuSong

More precisely, for each test case, you can create a string that contains configuration information, such as :
---
# tool file path, you can set it to absolute path or relative path.
toolFile: "" # here is a relative path.
# state config, backend can be local or s3
state:
  backend: local
  options:
    stateFile: devstream.state

---
tools:
  - name: github-repo-scaffolding-golang
    instanceID: default
    options:
      owner: daniel-hutao
      repo: go-webapp-devstream-demo
      branch: main
      image_repo: exploitht/go-webapp-devstream-demo
  - name: githubactions-golang
    instanceID: default
    dependsOn: ["github-repo-scaffolding-golang.default"]
    options:
      owner: daniel-hutao
      repo: go-webapp-devstream-demo
      language:
        name: go
        version: "1.17"
      branch: main
      build:
        enable: True
      test:
        enable: True
        coverage:
          enable: True
      docker:
        enable: False

Then write this string (configuration content details), to a specific file, such as quickstart.yaml.
Then call the LoadConfig("quickstart.yaml") method and determine if the *Config, error returned by the function is responsible for the expectation.
After that, test the other types of configuration examples in #655 in the same way.

You can read this chinese ginko ducument at first if the English ginkgo document is difficult to read. @DunyuSong

@DunyuSong are you already working on this? If so, please assign this issue to yourself so that we know somebody is already on it :) Thanks, and happy coding!

@IronCore864 This is a bit difficult for me for the time being, so I haven't started yet. If anyone wants to do it, it can be assigned to him.

This issue is not assigned to anyone now.

Thanks @steinliber for the contribution. Closing now.


[feature continued- Continue the interconnection between project and timer

I will fix the the problem later and integrate it to the project


Use system include

Thanks for your great library!
This PR change target_include_directories(${TARGET_NAME}) into target_include_directories(${TARGET_NAME} SYSTEM).
Background of this PR
When using clang-tidy, it considers external Python or nanobind header files as part of the module and detects unintended errors.
Reproduction code:
cmake_minimum_required(VERSION 3.15...3.27)
project(my_project)
find_package(Python 3.8 COMPONENTS Interpreter Development.Module REQUIRED)

include(FetchContent)
fetchcontent_declare(nanobind GIT_REPOSITORY https://github.com/wjakob/nanobind.git GIT_TAG master)  # -> errors detected at nanobind/nb_defs.h
# fetchcontent_declare(nanobind GIT_REPOSITORY https://github.com/regen100/nanobind.git GIT_TAG use-system-include)  # -> no error
fetchcontent_makeavailable(nanobind)

file(WRITE ${CMAKE_CURRENT_BINARY_DIR}/my_ext.cpp [[
#include <nanobind/nanobind.h>

auto add(int a, int b) { return a + b; }

NB_MODULE(my_ext, m) {
    m.def("add", &add);
}
]])
nanobind_add_module(my_ext ${CMAKE_CURRENT_BINARY_DIR}/my_ext.cpp)
set_target_properties(my_ext PROPERTIES CXX_CLANG_TIDY "clang-tidy;-checks=-*,modernize-*")

No, sorry, they are not system include files. If such tools spot actual issues, they should be reported to the respective projects (nanobind and Python).
If you need a special workflow to silence warnings in another tool, then this isn't a reasonable change to include in this project. That said, there is a low-level CMake interface (refer to the docs) that you should be able to use achieve your goals.


pynvim-pp: unstable-2023-08-03 -> unstable-2024-03-11

Description of changes
Minor pnvim-pp update. pynvim-pp went through a minor but breaking change and NixOS updated to a version of CHADtree that depends on it in a118538862a91aed41873ebc1dd4c9b390aac128, which unfortunately means they are currently broken. This update should fix them. This probably also unbreaks nvim_coq, but I don't use it, so I'm not sure.
I tested this with my local nixvim config and it does unbreak CHADtree again.
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Result of nixpkgs-review pr 299970 run on x86_64-linux 1

4 packages built:

python311Packages.pynvim-pp
python311Packages.pynvim-pp.dist
python312Packages.pynvim-pp
python312Packages.pynvim-pp.dist


Missed one :-(

Update to #2303 (noticed while browsing the 5.2 release notes)

Thank you @ErikEJ.


Installing sqlc fails

While trying to install sqlc i got this following error message:
.../github.com/kyleconroy/sqlc/internal/mysql/param.go:113:8: undefined: sqlparser.ParenExpr

the issue here seems to be that sqlparser.ParenExpr exists in this package github.com/xwb1989/sqlparser
But the package imported in the ../kyleconroy/sqlc/internal/mysql/param.go is
vitess.io/vitess/go/vt/sqlparser

Duplicate of #545


Make it possible to create a sort struct with a string literal.

Currently to create an array for the fields option on CreateJSONQueryIndexOperation you have the do the following:
[Sort(field:"foo", sort: nil)]

this is painful for someone who wants the default sort. To combat this we could make it possible to create a sort struct from a string literal, where the string would be the field name, this would create the struct with nil sort direction.

This library is now end-of-life and this issue won't be fixed.
This issue has been tagged EOL in case any forks want to import it.