Error page upon exporting change log

Just attempted to export this change log:

and got this error page:

I get this error regardless of whether the program is grouped by RF level or not, or is auto-numbered or manually numbered.

PASSED. Using the program "Desarrollo Rural Inclusivo - Alternative Livelihoods for Coca Growers (ALGO Nuevo)", I was able to successfully export the change log in all three languages, while the program was grouping indicators by RF level and not, auto-numbering and manual numbering.
After chatting with Cameron, it sounds like this was a special characters issue. I added a special character ü to an indicator and was still able to export the change log. (There were already lots of é characters in that program.)


Support --version flag for elm CLI

Should be uniform across all Elm things. Right now elm-repl and elm-reactor have this flag, but elm, elm-make, and elm-package do not.

Hi Evan,
I would like to start contributing to Elm. This seems like an easy bug for me to start with, do you mind if I take this? I've already gotten elm-platform to build from source, and I've signed the contributor agreement.

Hey, sorry I did not get back to you! I was missing a lot of notifications at that time.
I'd say the best way to start contributing is to get involved with the community on slack and see what folks are up to. Make some projects. Make some libraries. Basically, it makes sense to meet folks who are working on things and ramp up by working on things with them or at least in public. Hopefully that helps!


Add directory comparison script for multilingual content

Description
Add a script to compare the differences between files in the multilingual directory and their English versions.

Issue

Closes: #

Did you try scripts/lsync.sh content/zh-cn/docs/concepts for example?

Did you try scripts/lsync.sh content/zh-cn/docs/concepts for example?

I have tried it. lsync.sh uses the existing files in other language directories as the comparison baseline and then compares git diff, while the new script uses the files in the English directory as the baseline, with the intention of finding missing or additional files in other language directories.
lsync.sh:
> ./scripts/lsync.sh content/ja/docs/concepts
18      2       content/en/docs/concepts/configuration/overview.md
96      44      content/en/docs/concepts/configuration/configmap.md
9       22      content/en/docs/concepts/configuration/secret.md
96      20      content/en/docs/concepts/configuration/manage-resources-containers.md
2       2       content/en/docs/concepts/configuration/liveness-readiness-startup-probes.md
**removed**     content/en/docs/concepts/security/overview.md
2       3       content/en/docs/concepts/security/cloud-native-security.md
6       0       content/en/docs/concepts/security/secrets-good-practices.md
16      2       content/en/docs/concepts/security/pod-security-admission.md
...

diff_content_dir.sh:
> ./scripts/diff_content_dir.sh content/ja/docs/concepts
Comparing content/ja/docs/concepts with content/en/docs/concepts :
Added in ja: cluster-administration/cluster-administration-overview.md
Added in ja: cluster-administration/manage-deployment.md
Added in ja: extend-kubernetes/extend-cluster.md
Added in ja: overview/working-with-objects/kubernetes-objects.md
Added in ja: security/overview.md
Added in ja: services-networking/connect-applications-service.md
Missing in ja: architecture/mixed-version-proxy.md
Missing in ja: cluster-administration/cluster-autoscaling.md
Missing in ja: cluster-administration/coordinated-leader-election.md
Missing in ja: cluster-administration/flow-control.md
Missing in ja: cluster-administration/kube-state-metrics.md
Missing in ja: cluster-administration/node-shutdown.md
Missing in ja: cluster-administration/system-metrics.md
Missing in ja: cluster-administration/system-traces.md
...
Comparison complete.

I think these two scripts can be used together. The new script can more conveniently find those files that are not translated in the localized language directory.

So ... in summary ...

we are adding a new script which covers a smaller scope than an existing one
we are adding something new rather than improving the existing one
we do know there is another script doing something similar (written in Python) and we don't like it either

?

ok, draft first


Bump Chicory to 1.0.0-M1

:wave: we just released a first Milestone for Chicory, since it's breaking in many ways, I wanted to check that everything remains aligned.
Notes:

we now have a wasi implementation, so, some more code-paths should be usable (for filesystem operation we suggest to use Jimfs though)
we have a new AOT compiler, I would be happy to set up here, basically we can ship a "ready to run" Jar package for Prism, wdyt? (example: wabt)

Yeah that sounds great! Do you mean add it as an artifact after the build kind of thing? @enebo would you be able to use that?

I think @enebo will be able to use it easily, I would require some help in setting up the automated release CI,.
If that's good for you @kddnewton I'll move forward in the next few days. 😊
BTW, a wonderful experience contributing to this repo! Great job!

Yeah that's fine. I think just uploading it as an artifact to the build to start would be good. That's what we have for JS and it works fine for now https://github.com/ruby/prism/blob/efd3362a91f9fef296e42e931ef637e60cea18d1/.github/workflows/javascript-bindings.yml#L37-L40

Thanks for the feedback, @kddnewton , two comments here:

I was aiming to publish a full-fledged Jar to Maven Central as we are already uploading the wasm file to artifacts
I need more time to finalize this proposal as we are hitting some Java bytecode limitations (we are already working on fixing the issue)

All in all, the current setup is fine for now, I'll come up with something when we are ready :slightly_smiling_face:

Sounds great!


Website enisn-projects.io seems to be dead

When I try opening the project website I end up with a blank page.
Tried with multiple browsers (Safari, Firefox and Chrome) on a MacBook.
Related URL: https://enisn-projects.io/docs/en/uranium/latest/Getting-Started

I'll check quickly

Until the resolution, you can use the docs folder in this repository
https://github.com/enisn/UraniumUI/tree/develop/docs/en

I just roll-back to too old backup. At least it's working now


Small Updates (error messages)

Since dosage files are expected to be gzipped, added code to look for .gz suffix. Keeps non-dosage files with same prefix (i.e. maybe .log files by plink) from being read as input.

Added error message and system exit if user forgets to specify --predict and/or --assoc (elsewise code runs with no output or error).

With the availability of multiple tissues for imputation, we have found it useful to specify the output file (i.e. with tissue name) name when running --predict. If --pred_exp is not specified 'predicted_expression.txt' is the default and it is placed in --output_dir. If --pred_exp is specified with --predict, default behavior did not place in --output_dir.

Added sys.exit(1) if prediction file already exists.

Thank you @hainswor for your contribution.
@ScottPDickinson could you please take care of this pull request?

This all looks good, but for point 3, I wonder if it would be more useful to specify the output with a prefix instead of a directory.  So you could do something like --predict --out_prefix output/liver and then the output file would be output/liver.predicted_expression.txt.  That way you can have all of your tissue analyses in the same directory, but have the different file names.  The --pred_exp option is there mainly for when you have to specify input for performing an association, and it could get confusing to specify an input file and then have the software add the output directory before.

I agree, incorporating an --out_prefix option makes more sense, it would help avoid confusion if needing to specify a file for --assoc. That would a helpful feature.

Hi @ScottPDickinson,  I added an --output_prefix option that will append the specified text with an underscore to the predicted expression file and and association file. See if this addresses the point you previously raised.
Thanks so much!

Thanks @hainswor! I'm merging onto develop for the moment until I can update some of the documentation and example files.

Hey @hainswor, I just made some changes to the 'develop' branch.  I removed the output_dir option all together, so user's will just have to include the directory as part of the output_prefix.  I also changed some default behavior so the software won't stop if you already have a file with the output you specified.  It will just overwrite it, a la unix philosophy.  Would you mind checking it out?

@ScottPDickinson sounds great! I'll look at this weekend or early next week. Thanks!

@ScottPDickinson I made some minor changes to the develop branch. I think your updates made a lot of sense and will be helpful for analysis workflow.  Thanks for your work on this!


Rendering breaks on component with children

Describe the bug
Ladle does not render stories involving a component with children.
Reproduction
How to reproduce the bug:
https://stackblitz.com/edit/ladle-lxnqzy?file=src/basic.stories.tsx
The above StackBlitz project is forked from https://ladle.dev/new. I only edited one file (basic stories).

If you open up the "Hello" story first in the browser, Ladle will render it.
Then, if you open up the "My broken story" story, it will not render. From here on, no stories will render. Something broke.
Then, if you open up the "Hello" story again, it will not render.

Environment
StackBlitz, also had the error on Ubuntu.

Never mind. Fixed it.
I was exporting a JSX literal instead of a component. The difference between <Component/> and () => <Component/>.
I edited the StackBlitz. Commented out the buggy code and added a working story.


Add object patterns

This is an experimental approach to matching objects for #16 by the presence/absence of specified keys.
Specifically see the tests that go along with this to see what syntax would be supported as of this PR.

@Koleok I resolved conflicts for you.
Thanks for your contribuition.


How to add Files in my Json Object?

I construct Json Object with all data I want to send to server by Rest Service. Then I want to add my Uploaded Files. How can I do It?
Thanks a lot

Better to upload the file first alone, send an id back for the uploaded file and then post your json with the file id.

I have two questions : How can I save the file in the local way and upload it in the page each time the page is loaded?
What information allows me to recover the image as Json Object and thus show my image?

thanks Daniel, I understand the better way is to upload files first. But I want just send string to the server. Then I think base64 can be a key. Please how to have the base64 of the file in the way of ng-file-upload.
I'm stuck on it :-(

https://github.com/danialfarid/ng-file-upload/issues/816

You can also use:
Upload.dataUrl(file, function(dataUrl) {
...
});

thanks


Docker-compose could use health checks for service dependencies

Follow up to #507.
According to compose docs (startup-order), there are ways to define not just startup order dependencies, but also introduce health checks.

Tried it, it doesn't help.


[SPARK-23882][Core] UTF8StringSuite.writeToOutputStreamUnderflow() is not expected to be supported

What changes were proposed in this pull request?
This PR excludes an existing UT writeToOutputStreamUnderflow() in UTF8StringSuite.
As discussed here, the behavior of this test looks surprising. This test seems to access metadata area of the JVM object where is reserved by Platform.BYTE_ARRAY_OFFSET.
This test is introduced thru #16089 by @NathanHowell. More specifically, the commit Improve test coverage of UTFString.write introduced this UT. However, I cannot find any discussion about this UT.
I think that it would be good to exclude this UT.
  public void writeToOutputStreamUnderflow() throws IOException {
    // offset underflow is apparently supported?
    final ByteArrayOutputStream outputStream = new ByteArrayOutputStream();
    final byte[] test = "01234567".getBytes(StandardCharsets.UTF_8);

    for (int i = 1; i <= Platform.BYTE_ARRAY_OFFSET; ++i) {
      new UTF8String(
        new ByteArrayMemoryBlock(test, Platform.BYTE_ARRAY_OFFSET - i, test.length + i))
          .writeTo(outputStream);
      final ByteBuffer buffer = ByteBuffer.wrap(outputStream.toByteArray(), i, test.length);
      assertEquals("01234567", StandardCharsets.UTF_8.decode(buffer).toString());
      outputStream.reset();
    }
  }

How was this patch tested?
Existing UTs

cc @NathanHowell, @cloud-fan, @viirya

Test build #88978 has started for PR 20995 at commit b47b861.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/2035/
Test PASSed.

Test build #88979 has started for PR 20995 at commit 04e9d5f.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/2036/
Test PASSed.

@kiszk let's just remove the test. It should have never been added in the first place.

Test build #88984 has started for PR 20995 at commit d2dc70f.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/2042/
Test PASSed.

Test build #88984 has finished for PR 20995 at commit d2dc70f.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/88984/
Test PASSed.

LGTM - merging to master. Thanks!

Seems like this broke lint-java.
[ERROR] src/test/java/org/apache/spark/unsafe/types/UTF8StringSuite.java:[28,8] (imports) UnusedImports: Unused import - org.apache.spark.unsafe.Platform.

@kiszk Could you fix it? Thanks!

@ueshin, sorry for my mistake again. I will fix this at #20871

@ueshin Finally, I found better PR to fix this issue.


sodium-carbonate-omnide-salt does not exist

when trying to use your mods, i got this message error using this mod exactly:
failed to load mods: error in assignID: item with name 'sodium-carbonate-omnide-salt' does not exist
source: clows-ore9-crystall-salting (recipe)
mods to be disabled:

clowns-extended-minerals 1.1.20

This is known, and will be fixed in the next release (or if you get the current version from git)
Im actually waiting on an angels update as i have been keeping the live branch of this up-to-date with angels dev branch, and it is likely to break if i publish this as is.

This is known, and will be fixed in the next release (or if you get the current version from git)
Im actually waiting on an angels update as i have been keeping the live branch of this up-to-date with angels dev branch, and it is likely to break if i publish this as is.


Resolves #3

Implements the frame extractor referenced in #3. Also includes tests for the extractor as well to set up for future changes if needed.

just wondering is this the correct output for the tests, i tried running it on my own system and got this
TEST 1 PASSED
TEST 2 PASSED
TEST 3 PASSED
../src/sceneExtractor.sh: line 84: bc: command not found
TEST 4 PASSED
TEST 5 PASSED
TEST 6 FAILED: Amount Of Frames Created Is Incorrect

i can kinda see where this project is going though :)

just wondering is this the correct output for the tests, i tried running it on my own system and got this
TEST 1 PASSED
TEST 2 PASSED
TEST 3 PASSED
../src/sceneExtractor.sh: line 84: bc: command not found
TEST 4 PASSED
TEST 5 PASSED
TEST 6 FAILED: Amount Of Frames Created Is Incorrect

i can kinda see where this project is going though :)

Haha nah I just assumed that bc (the command line calculator)  was on all systems, are you on linux? I wasn't quite sure if we were targeting a system type or not so I just wrote the script for linux but if its needed I could also do it for windows as well

i actually am on linux lol, i just didn't have bc installed for some reason
it passes now, tho i wonder if we're gonna like build some kinda infrastructure for consistency (like npm?)

Gotcha, I could always add a checker for bc as well, I currently have it checking if ffmpeg/ffprobe exists so bc could just be in that list as well. And depending on how we do the AI part I doubt well need a fancy package manager. At least for this part all you need is bc and ffmpeg~


setup.py pacakge name and library is still called 'dtde'

main package folder is also still called dtde

After discussion, rename toolkit AND command line to 'aztk'


Branding for TimeBook

Change jar branding from AddressBook to time book

Pull Request Test Coverage Report for Build 499

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 53.112%

Totals

Change from base Build 495:
0.0%

Covered Lines:
3848

Relevant Lines:
7245

💛  - Coveralls


Adding more build steps

Signed-off-by: Harsha Vamsi Kalluri<EMAIL_ADDRESS>Description
Adds additional build steps for other clients in hadoop.
Issues Resolved
List any issues this PR will resolve, e.g. Closes [...].
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Merging this in. Will address spark failures in a separate PR.


Conflicting LICENSE

All Cargo.toml files in this repo (for example, ethabi's Cargo.toml) claim that their respective crates are MIT licensed, and it's also the license displayed at https://crates.io. However, the actual LICENSE, only visible if you take the extra step to visit the repo, is GPL V3.0.
Is GPL V3.0 the intended license?

great catch! I believe that the LICENSE file was missing and was added automatically. Personally, I see no reason for this repo to be under GLP V3.0. @5chdn @kirushik do you mind if I change the LICENSE file to MIT?

We use only GPLv3 or APLv2 across our repositories. If this tool is meant to less strict licensed, we should publish it under APLv2 which is pretty similar to MIT.

This tool is developed since mid 2016. Do you know if we need all contributors to agree to change it to APLv2?

We have a CLA bot, don't we? :man_facepalming:

Not for this repo, cause (as a tool) it was intended to be MIT 😅 I added the license to Cargo.toml, but forgot to add a LICENSE file.
But if we assume that all contributions were made as MIT (not GPL), I believe we can do whatever we want.

I only see two external contributors. Yeah, go ahead.


Prefixed Form-Field-Outline-Label-Gap not positioned correctly in Mat-Dialog in 7.0.1

Bug:
Form-Field-Outline-Label-Gap does not reposition correctly when it is opened in a dialog and the Form-Field has a prefix

What is the expected behavior?
The Form-Field-Outline-Label-Gap should be positioned correctly with or without a prefix.
What is the current behavior?
The Form-Field-Outline-Label-Gap does not reposition itself away from the form field prefix like the label does when it is opened in a dialog.
What are the steps to reproduce?
https://stackblitz.com/edit/form-field-outline-label-gap-position-error-in-dialog-701
What is the use-case or motivation for changing an existing behavior?
(not applicable)
Which versions of Angular, Material, OS, TypeScript, browsers are affected?
Angular 7.0.0
Angular Material 7.0.1
Chrome  69, Safari 12.0
Is there anything else we should know?
This seems related to #12782

I don't think mat-dialog has anything to do with it. You can reproduce it by taking the demo and just changing the form fields to use appearance="outline"

@aeslinger0 , I am referring to the gap in the field outline that is for the mat-label when it is raised.
I believe that you are referring to the prefix/suffix not being aligned to the input characters.
For that, I found this issue #11831 that already addresses it.

Yes, you're right. My mistake.

Closing as duplicate of #11831

@josephperrott , this is not a duplicate of 11831.
11831 is about vertical alignment of characters inside the field.
This is about the horizontal repositioning of the outline gap not taking effect in a one off scenario.
Please take a second look at the issue and consider reopening it.

This issue is still there in 7.2.0
To be clear, this happens when ouline gap is calculated before the label and container rendering being stable. I tried pausing the "updateOutlineGap" function when open the dialog and release it after all components are rendered, then the gap is correct.
Please reopen this issue.

It's still an issue on 7.3.1.

This occurs in any scenario using matPrefix - not just mat-dialog.

<mat-form-field appearance="outline" fxFlex>               <mat-label>User Name</mat-label>               <mat-icon matPrefix>account_box</mat-icon>               <input matInput formControlName="userName" maxlength="50" required>               <mat-error>User Name is required</mat-error>             </mat-form-field>

I have the same issue
@josephperrott could you please consider above comments


Use license-check docker image instead of curl

Description
Optimizes Docker builds by copying from license-check Docker image instead of using curl to download the tool.
Ref: https://github.com/openfaas/faas/issues/1440
How Has This Been Tested?

make build and all containers passed license-check
Checklist:
I have:

[x] checked my changes follow the style of the existing code / OpenFaaS repos
[ ] updated the documentation and/or roadmap in README.md
[x] read the CONTRIBUTION guide
[x] signed-off my commits with git commit -s
[ ] added unit tests

Thanks for this PR 👍


Wont let me choose to deploy to either windows/linux

<Please be sure to remove any private information before submitting.>
Repro steps:
<Enter steps to reproduce issue>
Action: appService.Deploy
Error type: Unauthorized
Error Message: You tried creating a site in the 'Basic' SKU but your DreamSpark subscription can only create sites in the 'Free' SKU. You can upgrade your subscription to a pay-as-you-go subscription to create sites in any sku.  You can still create free sites with the upgraded subscription
Version: 0.9.1
OS: win32

@leoporco as a workaround you can set the appService.advancedCreation setting to true and you should get prompted for the os
I'll leave this issue open to discuss our defaults, though. We currently default to 'linux' if you're deploying a node.js app, but we might need to reconsider that since linux doesn't support 'free'

@leoporco as a workaround you can set the appService.advancedCreation setting to true and you should get prompted for the os
I'll leave this issue open to discuss our defaults, though. We currently default to 'linux' if you're deploying a node.js app, but we might need to reconsider that since linux doesn't support 'free'

where exactly do I change the appService.advancedCreation?

File -> Preferences -> Settings

Closing as we made Advanced creation much more discoverable since this was originally filed. It's no longer a setting - it's a separate command


Feature request: vertical item cable connections

can you add a way for storage terminals to be used at different y levels than the chests? i thought i could run a storage cable straight upward but it doesnt connect the inventories to the terminal

You have to place an inventory cable connector behind the terminal on 1.20 and older.


Users can view restricted APIs in API devportal without required role.

The first issue is that any user who has any role can login to the devportal.
Users who have internal roles can view restricted apis in devportal without the required role.

login issue is fixed in https://github.com/wso2/carbon-apimgt/pull/7309

This was not observed in the latest pack.
Note that internal/publisher and internal/creator roles can see all apis even when store visibility was enabled and restricted.


feat: bump zwavejs server beta 7 and show version on ui

cc @frenck

Thanks, @robertsLando 👍

Pull Request Test Coverage Report for Build 575525306

0 of 3 (0.0%)  changed or added relevant lines in 2 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.004%) to 19.589%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

src/store/mutations.js
0
1
0.0%

lib/ZwaveClient.js
0
2
0.0%

Totals

Change from base Build 574883588:
-0.004%

Covered Lines:
2001

Relevant Lines:
10470

💛  - Coveralls


Build failure

With the latest code up to commit 52e06c4, when I run ipdk build --no-cache I see the following obtuse error and it fails:
-- Build files have been written to: /root/P4OVS_DEPS_SRC_CODE/gflags/build
make: *** empty string invalid as file name.  Stop.
The command '/bin/bash -c /root/start_p4ovs.sh /root &&      /root/scripts/run_cleanup.sh /root ${KEEP_SOURCE_CODE}' returned a non-zero code: 2
/git/ipdk/build
vagrant@ubuntu2004:/git/ipdk/build$

I am using Ubuntu 20.04, and my ipdk.env file looks as follows:
#
# IPDK CLI configuration file
# See for more information https://github.com/ipdk-io/ipdk/blob/main/build/IPDK_Container/README_DOCKER.md#CLI-configuration-settings
#
# /git/ipdk/build/scripts contains the location of the 'sourcing' ipdk script when read.
#
# When using ubuntu
BASE_IMG=ubuntu:20.04
IMAGE_NAME=ipdk/p4-ovs-ubuntu20.04
DOCKERFILE=${SCRIPT_DIR}/../Dockerfile.ubuntu

Even with a brand-new VM created, I still am hitting this build error.
@stolsma are you seeing this problem by chance? Note I'm using Ubuntu 20.04, will try 18.04 next.

Same issue with Ubuntu 18.04:
#
# IPDK CLI configuration file
# See for more information https://github.com/ipdk-io/ipdk/blob/main/build/IPDK_Container/README_DOCKER.md#CLI-configuration-settings
#
# /git/ipdk/build/scripts contains the location of the 'sourcing' ipdk script when read.
#

# When using ubuntu20.04
BASE_IMG=ubuntu:18.04
IMAGE_NAME=ipdk/p4-ovs-ubuntu18.04
DOCKERFILE=${SCRIPT_DIR}/../Dockerfile.ubuntu

I am able to build fine on both Ubuntu 20.04 as well as 18.04 container. You will face these issues when there is an empty string in front of make. What's NUM_THREADS on your system? Can you remove quotes around NUM_THREADS after make in install_deps scriupt and see if this error goes away?

@nupuruttarwar Are you using the ipdk script to do the build, e.g. ipdk build? I can't stop the build to make that change. Regardless, I've pushed a branch to OVS to cleanup the os_get_details.sh script, as it's out of sync with the one in IPDK. Lets see if that fixes this. I'd still like to understand how you can get this to build using the ipdk build command however.

yes, using ./ipdk build --no-cache --use-proxy. You can modify start_p4ovs.sh to comment out steps starting installation of dependencies and then execute build command. Like this:
if [ -z "${INSTALL_DEPENDENCIES}" ] || [ "${INSTALL_DEPENDENCIES}" == "y" ]
then
get_p4ovs_repo
build_p4sde
install_dependencies
build_p4c
fi
#build_p4ovs

This fixes the issue: https://github.com/ipdk-io/ovs/pull/17

After discussing with @nupuruttarwar, the problem here is the old version of os_ver_details.sh in the OVS repo only worked if you had > 4 CPU cores. This was fixed in the IPDK repository with #28. ipdk-io/ovs#17 will fix this in the OVS repository.


Translate all code comments to English and convert to UTF8

Description
The encoding topic has always been annoying from the beginning. We can fix this with an automated script and some regex magic.
Also thanks to AI and ML, Google Translate's translation has become quite advanced and accurate.
Tasks
The following steps should follow:

[ ] Write a script that retrieves comments from all source files using regex (pay attention to also block comments /**/)
[ ] Purchase (shouldn't be expensive) or get (if you can) an API key for Google Translate: https://cloud.google.com/translate/
[ ] Once you're able to translate things using a curl requests (RESTful), iterate through all the collected comments and replace each comment with its translated content
[ ] Finally convert all source files to UTF8 and check that nothing broke

I'll pick this one.

Blocking this task for now, as I unfortunately had not much progress in case someone else is going to dig through this. This is a bit complicated parsing C/C++ comments using LLVM and replacing them with translated strings, as there are many different edge cases, such as block and multi-line comments that are formatted under multiple lines.
It's probably easier working under Linux environment implementing this.
I might look into that later again.


[BUG] Admin: Policy: Edit Policy: Tooltip does not display

Summary
When hovering over the "i" icon indicating a tooltip, it does not display. I was told the data is in the system, but it is not displaying.
This file holds the code for the tooltip HTML, but this seems like an issue with js.
Reproduce steps

Hover the cursor over the icon
Expected Results

A popup displaying information as a tooltip
Actual Results

Nothing happens

Hi @PaladinCloudJohn , this issue is resolved. So, closing this issue.


Add support for GitLab 9.3 and above in GitLab integration snippet.

Regarding #354, As GitLab 9.3.0 renamed the build push event to Job, I updated the custom script to support this.
The content of the hook is exactly the same and the script has been tested internally.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Is the use of cookies instead of localStorage justified ?

Hey,
If I didn't miss anything, you are using cookies just as storage on the client side. Even if that works as expected I think there are some drawbacks.
First as the access to cookies is not well supported in JavaScript you need to load an additional library. Also the cookies are sent within each request and if there are not used server-side it is a bit of a shame to have such an overhead.
I know that it will not impact a lot the perfermance but is it not more appropriate to use some kind of client-side only storage like localStorage or sessionStorage ?

Hey,
I'm fact I didn't know this solution. But yes it's more appropriate so I will implement It asap.


Bump versions

Codecov Report

Merging #996 into develop will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             develop     #996   +/-   ##
==========================================
  Coverage      40.55%   40.55%
  Complexity       783      783
==========================================
  Files            158      158
  Lines           5688     5688
  Branches         806      806
==========================================
  Hits            2307     2307
  Misses          3209     3209
  Partials         172      172

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f3cf07d...20bb9d2. Read the comment docs.


Stacking logs (several starts in a row, or several end in a row) has weird behavior

I just started using the software and without realising it started several logs in a row (so multiple start before any end).
This creates logs with a start timestamp but no end timestamp.
Since it was possible to start several logs in a row (I don't think that should be allowed though) I thought if I did several end in a row they would 'close' the logs before, but it just updates the duration of the last entrie. This gives 'orhpan' logs that have a start timestamp but don't and will never have any end timestamp.
https://i.imgur.com/T64D7wa.png
Just to be sure what I'm saying is clear I will use the screenshot as an exemple :

I create a log with the command start test1; test1; test1
I create another log, before ending the first : start test2; test2; test2 (I think the software should just say "you are already in a log" or just do nothing instead of creating another one though)
I end once, this ends test1
I end a second time thinking it will end test2, but instead it just updates test1 end time and duration

Ah yeah. Multiple logs were not in mind when I created this system. I'll patch this. Thanks

This issue should now be fixed with the 1.0.1 update :)


Snyk fix 19b7f0c82d9a7d8dd6304898d4515638

Current base image	node:14.21.3-bullseye-slim
Upgrading base image to	node:14.21.3-bullseye-slim
Open a PR to upgrade the Dockerfile base image.


[Automated] Update actions

Produced via:
# meta: knative/.github
# main: vmware-tanzu/sources-for-knative
cp $(find "${GITHUB_WORKSPACE}/meta/workflow-templates" -type f -name '*.yaml') \
  "${GITHUB_WORKSPACE}/main/.github/workflows/"

Justification, Sync the new releasability workflow -mattmoor
/cc we don't use Prow
/assign we don't use Prow

Codecov Report

Merging #196 (ddb0c2b) into master (4dd8e8c) will increase coverage by 0.27%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #196      +/-   ##
==========================================
+ Coverage   79.97%   80.24%   +0.27%
==========================================
  Files          20       20
  Lines         734      734
==========================================
+ Hits          587      589       +2
+ Misses        134      132       -2
  Partials       13       13

Impacted Files
Coverage Δ

pkg/vsphere/adapter.go
64.84% <0.00%> (+1.56%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4dd8e8c...ddb0c2b. Read the comment docs.


typo

https://github.com/callum-rhodes/gabp_mapping/blob/a8d0f121b048f400454037bb3f93361c0ef61d56/scripts/throttlePID.py#L11-L12
rospy loginfo is mistaken

Yep I doubled up the loginfo so this one should not be there. Since it's not a major issue maybe you can add it to the fix for indentation issue you were seeing and then submit a pull request for both.


unable to use test_search_query with multiple tags

The example given only provide 1 tag, tried to follow the syntax of 'key1:value1,key2:value2,....' for multiple tags which seems does not work.

Hi @fuleinist! You should use exactly the same syntax as you would use to search tests in Datadog. So do not separate with commas, but with spaces :wink:

Closing the issue. Feel free to reopen if using spaces didn't fix your issue!


[Bug] Present omitted if initial mqtt connection fails

Original issue reported by @cimba007 on https://github.com/mycontroller-org/mycontroller/issues/425
If I upload a new sketch the mqtt-client does not logoff from the mqtt-server (buildin mycontroller).
On next sketch run presentation is skipped:
MC[I]: Booting ESP8266 device...<\n>
MC[I]: WIFI not connected, trying connection...<\n>
MC[D]: Searching BSSID for ssid:[FRITZ!Box Fon WLAN 7390]<\n>
MC[D]: Found BSSID[] for ssid:[FRITZ!Box Fon WLAN 7390], RSSI:[-62 -dBm, 76 %]<\n>
MC[D]: Selected bssid:[]<\n>
MC[I]: Connecting to WiFi with ssid[FRITZ!Box Fon WLAN 7390] and with password.....OK<\n>
MC[I]: WiFi BSSID:[], RSSI:[-68 dBm, 64 %], IP:[], StatusCode:[3]<\n>
MC[D]: WiFi connection status: Connected<\n>
MC[I]: Configuration(NodeEUI:[], Mqtt{mDNS-status:[0], Server:[], Port:[], FeedId:[esp], User:[]})<\n>
MC[D]: Attempting MQTT connection...<\n>
MC[I]: MQTT settings(Broker:[], Port:[])<\n>
MC[I]: MQTT authenticating as user:[]<\n>
MC[I]: MQTT connection failed, rc=-4<\n>
MC[D]: Try again in 3 seconds<\n>
MC[I]: Initialization done...<\n>
MC[I]: MQTT failed! Retryting to connect...<\n>
MC[D]: WiFi connection status: Connected<\n>
MC[D]: Attempting MQTT connection...<\n>
MC[I]: MQTT settings(Broker:[], Port:[])<\n>
MC[I]: MQTT authenticating as user:[]<\n>
MC[I]: MQTT connected :)<\n>
MC[I]: MQTT topic subscribed:[in_esp/ESP_C0DE98/#]<\n>

@cimba007 Could you please elaborate this issue?

I will try .. assume I upload my sketch to the esp8266 and everything is working as expected.
Now I want to upload a new sketch .. the upload process resets the esp8266 and leaves an open mqtt-connection on the broker (the client just vanished and did no proper logoff). Now the new sketch is uploaded .. and tries to connect again to the broker.
MC[D]: Attempting MQTT connection...<\n>
MC[I]: MQTT settings(Broker:[], Port:[])<\n>
MC[I]: MQTT authenticating as user:[]<\n>
MC[I]: MQTT connection failed, rc=-4<\n>
MC[D]: Try again in 3 seconds<\n>

The connection fails .. but succeeds after 3 seconds on the next retry.
https://github.com/mycontroller-org/MyControllerDevice/blob/95ea3ea77a9cdb33c846c3f435ec57cea829f426/MyController.cpp#L121
The code presented here will be skipped ...
  if(mqttClient.connected()){
    before();
    sendRSSI();
    sendStatistics();
    mcPresentation();
  }

When the yellow part is called

The only check and chance to run
  if(mqttClient.connected()){
    before();
    sendRSSI();
    sendStatistics();
    mcPresentation();
  }

is gone.
I hope this made it a little bit more clear.

Updated by @cimba007
I am not good with github and pull requests but I suggest to change this:
   mqttClient.connect(WiFi.hostname().c_str(), _mqttUser, _mqttPwd)

to
	  int limit = 0;
	  while(!mqttClient.connect(WiFi.hostname().c_str(), _mqttUser, _mqttPwd) && limit++ < 5)
	  {
		  MC_SERIAL.printf("MC[I]: MQTT retry .. %d\n",limit);
		  mcDelay(500);
	  }

in void MyController::checkMqtt() {

@cimba007 thank you for the tips and code. I will update.
To create this document might help you. https://gist.github.com/Chaser324/ce0505fbed06b947d962

@cimba007 can you check this fix? merged into master.

MC[I]: Booting ESP8266 device...
MC[I]: WIFI not connected, trying connection...
MC[D]: Searching BSSID for ssid:[FRITZ_BOX]
MC[D]: Found BSSID[MAC] for ssid:[FRITZ_BOX], RSSI:[-62 -dBm, 76 %]
MC[D]: Selected bssid:[MAC]
MC[I]: Connecting to WiFi with ssid[FRITZ_BOX] and with password......OK
MC[I]: WiFi BSSID:[MAC], RSSI:[-66 dBm, 68 %], IP:[<IP_ADDRESS>], StatusCode:[3]
MC[D]: WiFi connection status: Connected
MC[I]: Configuration(NodeEUI:[ESP_C0DE98], Mqtt{mDNS-status:[0], Server:[HOST], Port:[1883], FeedId:[esp], User:[MQTT_USER]})
MC[D]: Attempting MQTT connection...
MC[I]: MQTT settings(Broker:[HOST], Port:[1883])
MC[I]: MQTT authenticating as user:[MQTT_USER]
MC[I]: MQTT connection failed, rc=-4
MC[D]: Try again in 3 seconds
MC[I]: Initialization done...
MC[I]: MQTT failed! Retryting to connect...
MC[D]: WiFi connection status: Connected
MC[D]: Attempting MQTT connection...
MC[I]: MQTT settings(Broker:[HOST], Port:[1883])
MC[I]: MQTT authenticating as user:[MQTT_USER]
MC[I]: MQTT connected :)
MC[I]: MQTT topic subscribed:[in_esp/ESP_C0DE98/#]
MC[D]: About to publish a topic:[out_esp/ESP_C0DE98/SENSOR_BC/C_INTERNAL/I_RSSI/0], Payload:[-66 dBm]
MC[D]: About to publish a topic:[out_esp/ESP_C0DE98/SENSOR_BC/C_INTERNAL/I_PROPERTIES/0], Payload:[freeHeap=29968;chipId=12639896;flashChipSize=524288;flashChipRealSize=4194304;flashChipSpeed=40000000;cycleCount=1989731509;localIP=<IP_ADDRESS>;vcc=2780 mV]
MC[D]: About to publish a topic:[out_esp/ESP_C0DE98/SENSOR_BC/C_INTERNAL/I_PROPERTIES/0], Payload:[subnetMask=<IP_ADDRESS>;gatewayIP=<IP_ADDRESS>;macAddress=MAC;ssid=FRITZ_BOX;hostname=ESP_C0DE98;bssid=MAC;rssi=-66 dBm;rssiAsQuality=68]
MC[D]: About to publish a topic:[out_esp/ESP_C0DE98/SENSOR_BC/C_PRESENTATION/S_ARDUINO_NODE/0], Payload:[1.0.0]
MC[D]: About to publish a topic:[out_esp/ESP_C0DE98/SENSOR_BC/C_INTERNAL/I_SKETCH_NAME/0], Payload:[433MHz to Mycontroller GW]
MC[D]: About to publish a topic:[out_esp/ESP_C0DE98/SENSOR_BC/C_INTERNAL/I_SKETCH_VERSION/0], Payload:[1.0.0]
MC[D]: About to publish a topic:[out_esp/ESP_C0DE98/00/C_PRESENTATION/S_DOOR/0], Payload:[433b Haustuer vorne]
MC[D]: About to publish a topic:[out_esp/ESP_C0DE98/01/C_PRESENTATION/S_DOOR/0], Payload:[433b Terrassentuer (Tuer)]
MC[D]: About to publish a topic:[out_esp/ESP_C0DE98/02/C_PRESENTATION/S_MOTION/0], Payload:[433b Terrassentuer (Aussen)]
MC[D]: About to publish a topic:[out_esp/ESP_C0DE98/03/C_PRESENTATION/S_MOTION/0], Payload:[433b Bewegungsmelder vorne]
MC[D]: About to publish a topic:[out_esp/ESP_C0DE98/04/C_PRESENTATION/S_MOTION/0], Payload:[433b Bewegungsmelder Garten (1)]
MC[D]: About to publish a topic:[out_esp/ESP_C0DE98/05/C_PRESENTATION/S_DOOR/0], Payload:[433b Bewegungsmelder Keller (2)]
MC[D]: About to publish a topic:[out_esp/ESP_C0DE98/06/C_PRESENTATION/S_DOOR/0], Payload:[433b D-On Test]
MC[D]: About to publish a topic:[out_esp/ESP_C0DE98/07/C_PRESENTATION/S_DOOR/0], Payload:[433b Reed (2)]
MC[D]: About to publish a topic:[out_esp/ESP_C0DE98/08/C_PRESENTATION/S_DOOR/0], Payload:[433b Reed (3)]
MC[D]: About to publish a topic:[out_esp/ESP_C0DE98/09/C_PRESENTATION/S_DOOR/0], Payload:[433b Reed (4)]
MC[D]: About to publish a topic:[out_esp/ESP_C0DE98/10/C_PRESENTATION/S_DOOR/0], Payload:[433b Keller (Tuer)]
MC[D]: About to publish a topic:[out_esp/ESP_C0DE98/11/C_PRESENTATION/S_MOTION/0], Payload:[433b Keller (Radar)]

Seems to be fine now. Notice how the initial mqtt connection fails and later the sendInitialStatus() function is called.
Nice @jkandasa


feat: change AST of @render tag to match the latest version of svelte v5.

related to https://github.com/sveltejs/eslint-plugin-svelte/issues/686

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

0 of 3 (100.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.004%) to 91.452%

Totals

Change from base Build<PHONE_NUMBER>:
-0.004%

Covered Lines:
2491

Relevant Lines:
2634

💛  - Coveralls


Text layer constantly re-rendered when zooming large PDF (or large zoom)

Attach (recommended) or Link to PDF file here: A1.pdf (it also happens with the Trace-based JIT ... PDF, but you have to be close to the max zoom to see it)
Configuration:

Web browser and its version: Firefox 124, Firefox Android 125, Chrome Android 123
Operating system and its version:
PDF.js version: The one in that firefox version, and the current main
Is a browser extension: no

Steps to reproduce the problem:

Add a logpoint in https://github.com/mozilla/pdf.js/blob/627fe2d82604ac0d2d6918b74cec13dff57fc86a/web/pdf_page_view.js#L710
Zoom enough so that the size is bigger than this.maxCanvasPixels, so zooming becomes css-only

What is the expected behavior? (add screenshot)
It should respect defaultZoomDelay, and do not re-draw the text layer (and not emit pagerendered) until when zooming is done.
When zooming at small enough scales that the size is less than this.maxCanvasPixels (i.e. less than 100% in that A1.pdf), the event handler that handles zoom does very little work:
Stack Chart (over ~300ms)

Flame Graph (over ~300ms)

What went wrong? (add screenshot)
When zooming at big sizes, a lot of the time is spent re-rendering the text layer.
Stack Chart (over ~200ms)

Flame Graph (over ~200ms)

As you can see from the two stack charts, most of the time in the first one is spend doing nothing while in the second one it's doing something. This isn't really noticeable on my desktop, but it introduces some lagging on my phone (both in Firefox and Chrome, but Chrome is doing noticeably worse).
Other info:
The relevant code is https://github.com/mozilla/pdf.js/blob/627fe2d82604ac0d2d6918b74cec13dff57fc86a/web/pdf_page_view.js#L654-L717.
Looking at https://github.com/mozilla/pdf.js/pull/16507, it seems like the "fast" behavior is indeed the expected behavior: page re-rendering shouldn't happen until the "final" rendering. However, a combination of https://github.com/mozilla/pdf.js/commit/7bca3c81a9440ae50d7b37d4f88630b742e8830a and https://github.com/mozilla/pdf.js/commit/0ee2a352ecd0ab587123918f6d5ea29b5feccf47 changed how PDF.js behaves in this case:

7bca3c81a9440ae50d7b37d4f88630b742e8830a disabled the rendering delay when PDF.js is configured to use css-only zoom, because there won't be a "next render"
0ee2a352ecd0ab587123918f6d5ea29b5feccf47 unified the "css-only zoom because configured as such" and "css-only zoom because the canvas would be too big" cases

I think there are two possible solutions, but I saw that there were many regressions related to this rendering delay so I'm not sure about what's best:

onlyCssZoom should only affect whether or not we cancel the ongoing rendering, and not whether or not we delay the text layer and the "pagerendered" event
we distinguish the "onlyCssZoom because of this.maxCanvasPixels === 0" and "onlyCssZoom because the canvas would be too big" cases

@Snuffleupagus I see that you assigned this to yourself -- I'd be happy to provide a PR if you want.
I think the proposed approach 1 is better, because it also avoids the performance problem when maxCanvasPixels === 0, but it only works if .update() is called multiple times also in that case (which I'm not 100% sure about, due to "with CSS-only zooming rendering is only expected to happen once per page." in https://github.com/mozilla/pdf.js/commit/7bca3c81a9440ae50d7b37d4f88630b742e8830a).
If neither (1) nor (2) seem good, I could also help by just writing tests for this.


Determine Loader component color recursively

@fabienjuif it seems to work accordingly to this test. But on dark colors like black contrast is a bit light.

We should detect if the retrieve background color is more light than dark, and then apply the appropriate color transformation from this.

I suggested to use getBrightness from tinycolor


SEARCH-479 Use less memory for n removes in single transaction

Scope & Purpose
n * 1 * 8 + с1 instead of n * 11 * 8 + с2 bytes
c1 = sizeof PrimaryKeysFilter (8*12) + two counters in shared_ptr (8*2), probably can be less (2 score_t, counters, a lot of vptr are unnecessary.
c2 = sizeof PrimaryKeyFilterContainer(8*12) + two counters in shared_ptr (8*2)
So I assume new memory layout always smaller, except zero removes case

[ ] :hankey: Bugfix
[ ] :pizza: New feature
[x] :fire: Performance improvement
[x] :hammer: Refactoring/simplification

Checklist

[ ] Tests

[ ] Regression tests
[ ] C++ Unit tests
[ ] integration tests
[ ] resilience tests

[ ] :book: CHANGELOG entry made
[ ] :books: documentation written (release notes, API changes, ...)
[ ] Backports

[ ] Backport for 3.11: (Please link PR)
[ ] Backport for 3.10: (Please link PR)
[ ] Backport for 3.9: (Please link PR)

Related Information
(Please reference tickets / specification / other PRs etc)

[ ] Docs PR:
[ ] Enterprise PR:
[ ] GitHub issue / Jira ticket:
[ ] Design document:

Local checks shows that memory consumption for removes around 8x times smaller.


Integrate the new Relations Handler in the Ontology Learning Workflos

As it is now the OntologyLearningWorkflow does not take into consideration the curated Knowledge Base when expanding relations


Instructions not complete

Instructions not complete, they should mention that flatpak needs to be installed. On Ubuntu 18.04, getting:
wget https://github.com/sudo-give-me-coffee/flatpak2appdir/archive/master.zip -O flatpak2appdir.zip

unzip flatpak2appdir.zip

cd flatpak2appdir-master

chmod +x flatpak2appdir strace-file appimagetool

./flatpak2appdir com.github.calo001.fondo

Starting application...
./flatpak2appdir: line 77: flatpak: command not found
timeout: failed to run command 'flatpak': No such file or directory
Copying used files from runtime by ''...
Copying /app files...
./flatpak2appdir: line 89: flatpak: command not found
./flatpak2appdir: line 142: flatpak: command not found
cp: cannot stat 'usr/lib/': No such file or directory
cp: cannot stat 'app/share/appdata': No such file or directory
./flatpak2appdir: line 197: flatpak: command not found
./flatpak2appdir: line 200: flatpak: command not found
sed: can't read com.github.calo001.fondo.desktop: No such file or directory
Finished!
Creating AppImage...
appimagetool, continuous build (commit 7392c48), build 2120 built on 2020-03-10 18:42:43 UTC
Desktop file not found, aborting

Solution:
# For Ubuntu:
sudo add-apt-repository -y ppa:alexlarsson/flatpak
sudo apt-get update
sudo apt-get -y  install flatpak

# For other systems, please see:
# https://flatpak.org/setup/

flatpak remote-add --if-not-exists flathub https://flathub.org/repo/flathub.flatpakrepo

Please add these lines to the instructions for true copy-and-paste-ability. Thanks!

Actually, there is still an issue - why?
me@host:~/flatpak2appdir-master$ ./flatpak2appdir com.github.calo001.fondo
Starting application...
error: app/com.github.calo001.fondo/x86_64/master not installed
error: app/com.github.calo001.fondo/x86_64/master not installed
Copying used files from runtime by ''...
Copying /app files...

Note that the directories

'/var/lib/flatpak/exports/share'
'/home/me/.local/share/flatpak/exports/share'

are not in the search path set by the XDG_DATA_DIRS environment variable, so
applications installed by Flatpak may not appear on your desktop until the
session is restarted.

error: app/com.github.calo001.fondo/x86_64/master not installed

Note that the directories

'/var/lib/flatpak/exports/share'
'/home/me/.local/share/flatpak/exports/share'

are not in the search path set by the XDG_DATA_DIRS environment variable, so
applications installed by Flatpak may not appear on your desktop until the
session is restarted.

error: app/com.github.calo001.fondo/x86_64/master not installed
cp: cannot stat 'usr/lib/': No such file or directory
cp: cannot stat 'app/share/appdata': No such file or directory

Note that the directories

'/var/lib/flatpak/exports/share'
'/home/me/.local/share/flatpak/exports/share'

are not in the search path set by the XDG_DATA_DIRS environment variable, so
applications installed by Flatpak may not appear on your desktop until the
session is restarted.

error: app/com.github.calo001.fondo/x86_64/master not installed

Note that the directories

'/var/lib/flatpak/exports/share'
'/home/me/.local/share/flatpak/exports/share'

are not in the search path set by the XDG_DATA_DIRS environment variable, so
applications installed by Flatpak may not appear on your desktop until the
session is restarted.

error: app/com.github.calo001.fondo/x86_64/master not installed
sed: can't read com.github.calo001.fondo.desktop: No such file or directory
Finished!
Creating AppImage...
appimagetool, continuous build (commit 7392c48), build 2120 built on 2020-03-10 18:42:43 UTC
Desktop file not found, aborting

Fixed


[Enhancement] (recycle bin) Support recover partition to a new table

Search before asking

[X] I had searched in the issues and found no similar issues.

Description
Whe drop a partition, we only can recover it to the original table.
But if the original table schema is changed, the partition can not be recovered.
Maybe we can support recover partition to a new table(the table is created use the partition schema), and in this case, users can insert data to the original table by  insert into original_table select ... from new_table.
Solution
No response
Are you willing to submit PR?

[ ] Yes I am willing to submit a PR!

Code of Conduct

[X] I agree to follow this project's Code of Conduct

I'd like to have a try.


Swift 2.3/3.0 support

Just curious if this is being worked on by anyone?
May be a pretty simple conversion after Xcode 8's covert tool.
(I may give it a shot but I really don't know Swift 😅 )

Just tried running with Xcode Beta, the current codebase will work with Swift 2.3 , you can add the following script in your Podfile to make it work with Xcode 8 if you are using cocoapods.
post_install do |installer|
  installer.pods_project.targets.each do |target|
    target.build_configurations.each do |config|
      config.build_settings['SWIFT_VERSION'] = '2.3'
    end
  end
end

Confirmed! Also important to use_frameworks:
target 'MyApp' do
    use_frameworks!
    pod 'TZStackView'
end

Any love for carthage?

Hmm I haven't worked on this for a while, mainly because I don't have the time anymore.
Also, do people still need this? iOS 10 will be coming out soon. You still need iOS 8 support?

Unfortunately my company still wants iOS8 compatibility. I've tried to perform a carthage update using the XCode beta command line tool but it keeps throwing an error saying that I need to check my dependencies (doesn't complain when using XCode 7 CLT).
I'm relatively new to the third-party frameworks side of things and haven't been able to figure out what I need to do.  Problem is I don't want to have two separate solutions to adding this framework into my project. I would rather the solution be applied to Carthage if possible. Is this something that only the author can fix?

So I decided to fork this repo. Ran it through the Swift 2.3 converter and then pushed the update to my own repo.
I then pointed the Cartfile to pull the code off of my repo at: "irvene2000/TZStackView"
When I ran carthage update it still complained about the "Check Dependencies" issue. So I looked a little bit more online and found this solution.
TOOLCHAINS=com.apple.dt.toolchain.Swift_2_3 carthage update --platform iOS
When I did that Carthage no longer complained about the issue and I now have a framework compiled on XCode 8 CLT.

I did this too for Swift 2.3 :)
@tomvanzummeren I still use TZStackView in Blackbox (It's in the credits!) and target iOS 8. Maybe that'll change once iOS 10 is out, but for now I don't want to exclude anyone without good reason.

Any support for Swift 3.0 without the legacy compiler?

Version 1.3.0 has Swift 3 support!

Awesome, thanks!

Thank you @tomvanzummeren! Means a lot to thousands of iOS 8 Blackbox players :)


KeyboardAwareFlatList scrolls to top when keyboard dissapears

I am using KeyboardAwareFlatList with multiline TextInput. When I click on the textInput the list scrolls up to bring the input in view. But when it disappears the list scrolls back to the top index instead of where it was before the keyboard showed
Anyone know how to make it remember its content offset

Solved here https://github.com/APSL/react-native-keyboard-aware-scroll-view/issues/287#issuecomment-410798735
enableResetScrollToCoords={false} might help the problem, while there are still issues with InputTexts which at the bottom of the View.

Why this issue is closed. I am facing exactly same issue and enableResetScrollToCoords={false} does not fix it for me,
www_screencapture_com_2022-9-29_20_49.webm


Make hovering over links have pointers and use routes directly rather than passing callbacks everywhere

It took me a while to realize all the links and especially the buttons at the top were clickable, since hovering over them doesn't change the pointer.

wow! you are definitely a pro with react. Since I don't understand most of these. Let me pull the tree and unit-testing the heck of this!

amazing work! thank you!

Thank you for doing this! This also makes it easier for Google to crawl the pages.


Add __module_version__ to special items in GufeTokenizable dict representation

We currently include __qualname__ and __module__ in the dict, shallow_dict, and keyed_dict representations of any GufeTokenizable. These are necessary for re-instantiating a GufeTokenizable from these forms, identifying the class and source module to use.
In discussion with @ianmkenney this morning, we thought it may be useful for a variety of downstream uses to also include a __module_version__ item in these *dict forms, giving the version of the __module__ that created this form of the object. This would give a gufe-supported way to e.g. check for version mismatches between a serialized Protocol and the version of the corresponding module on a remote executor (such as in alchemiscale).
We could not think of any substantial drawbacks to including __module_version__, other than slightly increasing the size of these objects and their serialized forms.
@ianmkenney can you elaborate on your thinking here as well?

Note that there's already a _schema_version for each object. See https://github.com/OpenFreeEnergy/gufe/pull/227. This is an object-specific version, specifically with the idea that it will handle serialization migrations. I can imagine use cases where __module_version__ provides other/easier to use information (might be harder to map the integer _schema_version to versions of software). However, let's try to avoid maintaining two mechanisms to solve the same problem.


Feedback for “useSignPersonalMessage”

How do we then check that the signature is valid ?

I want to check that the user is really who he say he is (for context)

Hi @0xGoenka! The useSignPersonalMessage hook can be used to prompt a user to sign a message with their wallet, but you'll need to leverage the verifyPersonalMessage function from our TypeScript SDK to verify ownership of a particular wallet address.
Check out our documentation at https://sdk.mystenlabs.com/typescript and https://sdk.mystenlabs.com/typescript/cryptography/keypairs#verifying-signatures-without-a-key-pair 🙂

Thank you boss !

It seems like it's not working with ZkLogin yet, do you have an ETA for this feature ?
Else what is the way to check ownership of an userAccount ?


Update .gitignore for tools folder (Issue #66)

In line with the recommended way of excluding things from the
github example .gitignore
https://github.com/github/gitignore/blob/master/VisualStudio.gitignore
Issue #66

This seems like a small (but important) contribution, so no Contribution License Agreement is required at this point. We will now review your pull request.
Thanks,
.NET Foundation Pull Request Bot

@iHaveBecomeDeath your changes have been merged, thanks for your contribution 👍


[$500] LOW: Thread - You can go to the<EMAIL_ADDRESS>profile and send a private message

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number: 1.4.8-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:
Action Performed:

Open New Expensify app
Navigate to any conversation
Request money from another account by uploading a non-legible receipt (a random pic).
Wait for smartscan to finish. It should fail.
Navigate to the IOU details
Create a thread with a system message about a receipt scanning failure
In the thread header, click on the "Expensify" avatar
In the RHP that appears, click on "Members"
In "Members," click on "Expensify."
In "Profile" click on "Message Expensify"

Expected Result:
<EMAIL_ADDRESS>account should be hidden from user interaction
Actual Result:
Through thread, you can go to the<EMAIL_ADDRESS>profile and send a private message
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

Screenshots/Videos
Add any screenshot/video evidence

https://github.com/Expensify/App/assets/78819774/f69a58b3-d991-4af7-81c5-de9961946e7e
View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~013bd0e1cccedfb977
Upwork Job ID:<PHONE_NUMBER>987237888
Last Price Increase: 2023-12-19

Proposal
Please re-state the problem that we are trying to solve in this issue
Thread - You can go to the<EMAIL_ADDRESS>profile and send a private message
What is the root cause of that problem?
This is due to missing restrictions on email chat in navigateToAndOpenReportWithAccountIDs.
What changes do you think we should make in order to solve the problem?
Add restrictions in the function as well as disable showing message icon at all (Maybe disable reply as well)
What alternative solutions did you explore? (Optional)

Proposal
Please re-state the problem that we are trying to solve in this issue.
The user is able to send a private message to an official Expensify user that is meant to behave such a bot
What is the root cause of that problem?
In ProfilePage we are only not showing up the "message" button to current user and anonymous users
What changes do you think we should make in order to solve the problem?

We should expand and consolidate the condition to not include certain known bot accounts so that the MenuItem is not rendered
What alternative solutions did you explore? (Optional)
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

Proposal
Please re-state the problem that we are trying to solve in this issue.
You can reply to message came from<EMAIL_ADDRESS>profile
What is the root cause of that problem?
We didn't consider about  notification account here
What changes do you think we should make in order to solve the problem?
We need to update like this to disable notification account profile.
isDisabled: ReportUtils.isOptimisticPersonalDetail(participant.accountID) || participant.accountID === CONST.ACCOUNT_ID.NOTIFICATIONS

What alternative solutions did you explore? (Optional)
https://github.com/Expensify/App/assets/65789015/cfef2510-c036-444c-9573-70cb65656556

Posted in #wave5 about what the ideal behavior should be here: https://expensify.slack.com/archives/C05DWUDHVK7/p1702577149414069

Going to assign to @dylanexpensify to figure out ideal behavior and distribute as part of wave5.

Need to confirm behavior this week

Behavior:

you can thread any message, including those from notifications@
you cannot view the profile or message notifications@

@0xmiroslav can we review proposals?

nice, any updates @0xmiroslav

bump @0xmiroslav

bump @0xmiroslav

Bump @0xmiroslav

calling out for volunteer today

@fedirjh reassigning, please take over as C+. If you don't have bandwidth, unassign yourself. Thanks

@fedirjh Can you look over the most recent comments and tell me if @yh-0218's proposal is still your preferred solution? I haven't had the time to look over this issue in depth today and want to make sure your opinion is unchanged before I read through all the comments here and assign.

Okay I read through everything here and also our Expensify internal chats about expected behavior. I like @mkhutornyi's proposal best. I agree that we should try to keep it simple like @fedirjh said but blocking the profile is a good simple addition to this issue's solution, and I also like the suggestion of creating a utility function for when we add more accounts like this to the list. The list of bots like the notifications bot is only going to increase as the app matures, so lets get a head start on abstracting out that logic and making this part of the codebase clean and maintainable.
@dukenv0307 you make great points, but after talking internally we do want it to be in the members list, even though its a bot. This is more a design decision than a engineering decision so its fairly subjective, but we've decided that that is what we want.
The empty list case is interesting. I consider it out of scope for this issue, especially since I'm honestly not sure how that should be handled. I'll bring this up internally and see what we want to do with this empty list scenario. I think what will happen is we will come to a decision internally on how to handle this and then I'll create the issue in GH. When that happens I'll tag you.

@mkhutornyi when can we expect PR?

@fedirjh mind giving an update

payment coming up!

payment today!

Payment summary:

Contributor: @mkhutornyi $500
Contributor+: @fedirjh $500

Please apply

paid!


docs: add org id header in missing requests

On the management api the x-zitadel-orgid header is used to identify  the organization on which the request should happen. This was missing in the API docs of some requests and is added now.
Definition of Ready

[x] I am happy with the code
[x] Short description of the feature/issue is added in the pr description
[x] PR is linked to the corresponding user story
[x] Acceptance criteria are met
[ ] All open todos and follow ups are defined in a new ticket and justified
[ ] Deviations from the acceptance criteria and design are agreed with the PO and documented.
[ ] No debug or dead code
[ ] My code has no repetitions
[ ] Critical parts are tested automatically
[ ] Where possible E2E tests are implemented
[x] Documentation/examples are up-to-date
[ ] All non-functional requirements are met
[ ] Functionality of the acceptance criteria is checked manually on the dev system.

IMO we should also add it to the deprecated calls (AddHumanUser, SetHumanInitialPassword and GetOrgIAMPolicy)


Fix #13531

Description
Add css for Gray toggle button

Visual changes

Functional changes

[x] Code style has been fixed by running the composer cs command.
[x] Changes have been tested to not break existing functionality.
[ ] Documentation is up-to-date.

@danharrin
Sorry for late reply.

Do you think this should be a little darker in dark mode? Otherwise I think it sticks out quite a bit

fix color in dark mode.

Perfect, thank you!


[Security] Workflow preview-book.yaml is using vulnerable action nwtgck/actions-netlify

The workflow preview-book.yaml is referencing action nwtgck/actions-netlify using references v1.2. However this reference is missing the commit 223b5b5981680adfe8ec4c9f471620cbbdbfadec which may contain fix to the some vulnerability.
The vulnerability fix that is missing by actions version could be related to:
(1) CVE fix
(2) upgrade of vulnerable dependency
(3) fix to secret leak and others.
Please consider to update the reference to the action.

<EMAIL_ADDRESS>has been updated to point to 1.2.3. The referenced commit appears in the list of commits now.
Thanks for reporting.


Clean up Exec

Thanks.
Just had the idea to put the debug settings into the property sheet. It's simpler and more widely applied and can be removed from the project files. I can do that as a followup.

I can do that as a followup.

Done: https://github.com/rainers/mago/commit/70893504e18d30714c6df05cdc17837437f07a74


CircuitBreaker pattern

Do you think it is valid for me to implement the CircuitBreaker pattern?

I would happily merge a PR with the pattern! Make sure to add in the 'More' category :)


Use PropertyAccess for get/set position

Fix #69

@nicolasricci ping

@peter-gribanov sorry I must have missed the notification for this PR. Good job 👍


MM-22854 Improve sort order of the channel switcher to prioritize rec…

Summary

Remove sections of my channels and other channels
Remove the check for is channel visible in LHS
Add a new attribute on wrapped channel obj last_viewed_at if it exists in memberships for sorting

Ticket Link
https://mattermost.atlassian.net/browse/MM-22854
Screenshots

@amyblais I think we should push this change for v5.29. It's a horrible user experience that has been brought up by multiple community members and internally, including IJT and CH. I really don't want to wait till December to ship this if possible.
cc// @sudheerDev @jgilliam17

@jgilliam17 can you help prioritize testing on this so we can get it merged?

@sudheerDev Agniva is off this week, perhaps another second dev can review this.

Thank you @sudheerDev
Tested, looks good to merge. More thorough testing will be done after merge.

Verified few channel switcher search ordering rules - prioritizing post time, listing DMs before GMs and channels, searching for channels, DMs, GMs
Verified sections of my channels and other channels have been removed, and all channel are searched for, not just the ones visible on the LHS.

@ali-farooq0 @nevyangelova if you guys can please review this soon as we are trying to merge this for v5.29

Swapping @hmhealey with me.

@nevyangelova Ya, sorry i am adding integration tests but i found an issue with filtering. @esethna @jgilliam17 it does not partial match for users. i.e ason does not match. locally available jason result. Updating it soon

@jgilliam17 Hey, sorry. can you give this another quick review. I fixed the issue of partial matching of user names as mentioned above

@nevyangelova Added some e2e tests.

@hmhealey @saturninoabril please help re-review asap as we'd like to get this merged for v5.29

Thanks all, @sudheerDev is this ready to merge?

@esethna Yes, it is ready to merge. Waiitng for builds to pass

Cherry pick is scheduled.

Error trying doing the automated Cherry picking. Please do this manually
+++ Updating remotes...
Fetching upstream
Failed to add the RSA host key for IP address '<IP_ADDRESS>' to the list of known hosts (/app/.ssh/known_hosts).
From github.com:mattermost/mattermost-webapp
   7a4b64976..c8c40c177  MM-28363   -> upstream/MM-28363
   4fd6b39a9..eb6e70af6  cloud-ga   -> upstream/cloud-ga
   93e7c5d91..8a81e925a  master     -> upstream/master
Fetching origin
Failed to add the RSA host key for IP address '<IP_ADDRESS>' to the list of known hosts (/app/.ssh/known_hosts).
From github.com:mattermost-build/mattermost-webapp
   1ee288018..c38d0fbc4  automated-cherry-pick-of-mattermost-webapp-#6900-upstream-cloud-ga -> origin/automated-cherry-pick-of-mattermost-webapp-#6900-upstream-cloud-ga
+++ Updating remotes done...
+++ Creating local branch automated-cherry-pick-of-mattermost-webapp-#6756-upstream-release-5.29-1603732538
Switched to a new branch 'automated-cherry-pick-of-mattermost-webapp-#6756-upstream-release-5.29-1603732538'
Branch 'automated-cherry-pick-of-mattermost-webapp-#6756-upstream-release-5.29-1603732538' set up to track remote branch 'release-5.29' from 'upstream'.

+++ About to attempt cherry pick of PR #6756 with merge commit 8a81e925ad548df93bcff1fbf5a8f3df3dde2c8c.

error: could not apply 8a81e925a... MM-22854 Improve sort order of the channel switcher to prioritize rec… (#6756)
hint: after resolving the conflicts, mark the corrected paths
hint: with 'git add <paths>' or 'git rm <paths>'
hint: and commit the result with 'git commit'

+++ Conflicts detected:

UU components/admin_console/system_users/list/selectors.jsx
UU components/admin_console/system_users/list/selectors.test.jsx
UU e2e/cypress/integration/archived_channel/archived_leave_channel_spec.js
UU e2e/cypress/support/ui/channel.js
UU package-lock.json
UU package.json
Aborting.

+++ Aborting in-progress git cherry-pick.

+++ Returning you to the master branch and cleaning up.


How can I use my usb_cam?

System information

OS Platform and Distribution (e.g., Linux Ubuntu 14.04): Ubuntu 14.04
Apollo installed from (source or binary): From source (branch --r3.0.0)
Apollo version (1.0, 1.5, 2.0, 2.5, 3.0): 3.0

Issue
Hello guys, I have a usb camera and I want to know how to use it in Apollo.
The Apollo platform seems to support usb camera.
(e.g. In apollo.sh build option, there is build_usbcam. But I don't know  what to do after I build it.)
Could you explain step-by-step how to install usb camera and how to use it (viewing video on Dreamview or any tool) ?
Or is there anything I can refer to this ?
Thanks !

Add,
This is my rostopic list while I run dreamview in simcontrol mode.
And there is no topic about usb camera, additional steps seem necessary.
apollo@in_dev_docker:/apollo$ rostopic list
/apollo/canbus/chassis
/apollo/canbus/chassis_detail
/apollo/control
/apollo/control/pad
/apollo/drive_event
/apollo/guardian
/apollo/hmi/voice_detection_request
/apollo/hmi/voice_detection_response
/apollo/localization/msf_gnss
/apollo/localization/msf_lidar
/apollo/localization/msf_sins_pva
/apollo/localization/msf_status
/apollo/localization/pose
/apollo/monitor
/apollo/monitor/static_info
/apollo/monitor/system_status
/apollo/navigation
/apollo/perception/lane_mask
/apollo/perception/obstacles
/apollo/perception/traffic_light
/apollo/planning
/apollo/prediction
/apollo/relative_map
/apollo/routing_request
/apollo/routing_response
/apollo/sensor/camera/obstacle/front_6mm
/apollo/sensor/camera/traffic/image_long
/apollo/sensor/camera/traffic/image_short
/apollo/sensor/conti_radar
/apollo/sensor/delphi_esr
/apollo/sensor/gnss/best_pose
/apollo/sensor/gnss/corrected_imu
/apollo/sensor/gnss/gnss_status
/apollo/sensor/gnss/imu
/apollo/sensor/gnss/ins_stat
/apollo/sensor/gnss/ins_status
/apollo/sensor/gnss/odometry
/apollo/sensor/gnss/raw_data
/apollo/sensor/gnss/rtk_eph
/apollo/sensor/gnss/rtk_obs
/apollo/sensor/mobileye
/apollo/sensor/velodyne16/compensator/PointCloud2
/apollo/sensor/velodyne64/PointCloud2
/apollo/sensor/velodyne64/VelodyneScanUnified
/apollo/sensor/velodyne64/compensator/PointCloud2
/rosout
/rosout_agg
/tf
/tf_static
/velodyne_nodelet_manager/bond

these three topics are from usb_cam
/apollo/sensor/camera/obstacle/front_6mm
/apollo/sensor/camera/traffic/image_long
/apollo/sensor/camera/traffic/image_short

Hey @CCodie When you plug in the cameras to the IPC and in a terminal run $ ls /dev/video what do you see?

@mickeyouyou Thanks for the reply! Can I get some information for how to use usb_camera?
First, I want to make sure that it is installed properly and I want to see some videos using it.
@rgunjala93 Hi, the contents are shown below.
apollo@apollo:~$ ls /dev/video*
/dev/video0

I previously received image data from my usb camera with ROS outside the apollo image. So I think my usb camera can works with ROS.

@CCodie I think you shouldn't you your camera outside from apollo's container. But if you have to you can refer to #4892

@CCodie If this is the recommended IPC and there is no webcam on the computer, then the computer is picking up the camera. Inside the Apollo docker, you can roscd to usb_cam package and look at the launch file. I think there's a launch file called start_one_leopard.launch that you can use to test the camera inside Apollo docker.  Inside the launch file make sure that the device it is trying to open is /dev/video0. I think the launch file by default tries to open something like /camera/short or /camera/long. In order for this to work, udev rules need to be set but try changing the camera name to /dev/video0 inside start_one_leopard.launch and launch it like you would launch a ROS launch file i.e. $ roslaunch usb_cam start_one_leopard.launch

Hi @gladijos . It seems to be very helpful when I try to use the camera outside the docker image. But now I'm trying to run inside the docker. Anyway thanks for the reply :)
Hi, @rgunjala93 . I'm appreciate for your detail reply! I'm actually installing the apollo kernel and platform for the test on my personal PC, not the reference IPC. But until now it seems to be okay to install without problems.
For the usb camera, it seems that there's no problem for the computer to recognize the camera. As you have mentioned, I'll take a closer look at the launch files and then I'll tell you about the progress.

@johndoe95 Hi, I solved that problem with modifying the launch file.
I'm now using one Leopard camera with modified launch file.
The most simple solution is match your device with device param in launch file.
e.g. If your usb camera is /dev/video0, you can modify your launch file param to /dev/video0.

Hi, @CCodie, thank you very match!

I am trying to use laptop webcam  as usb camera. I changed the camera dev in conf as /dev/video0. but i am getting folowwing error when launching camera.launch
[usb_cam]  E0701 12:39:26.911983 25095 usb_cam.cc:867] [mainboard]Wrong Buffer Len: 1843200,raw_image->width * raw_image->height: 2073600, dev: /dev/video0
[usb_cam]  E0701 12:39:26.949627 25095 camera_component.cc:86] [camera]Running
Also am not getting video in Dreamviewer and cyber_visualizer. Is there any other configurations need to be changed for using laptop webcam?

[mainboard]Wrong Buffer Len: 114264, dev: /dev/camera/front_6mm


Foreground

Provide a foreground layer which the user can draw to like the background layer

https://github.com/chad-autry/hex-widget/commit/4e706b8117f1fa33e3a786411aa5c599ed61763b


#859 fix inherited timed annotation

Suggestion for fixing the the issue #859 that prevented having resources inheriting annotated methods.
Also fixing the support for absolute metric names that apparently was not working properly.

hey folks what's the good word on this PR?

I haven't heard anything regarding my proposed fix for this issue, @rferreira. My suggestion at https://github.com/dropwizard/metrics/issues/746 is still valid. You can import this fix into your project at any time. To make it easier, just add this file: https://raw.githubusercontent.com/mtakaki/metrics/mtakaki_746_fix_inherited_timed_annotation/metrics-jersey2/src/main/java/com/codahale/metrics/jersey2/InstrumentedResourceMethodApplicationListener.java

@mtakaki I did as you suggested, and got
java.lang.NoSuchMethodException: Could not find a suitable constructor in com.mywebservice.InstrumentedResourceMethodApplicationListener class.

@edwardsb which version of dropwizard are you using? I noticed it didn't work as soon as I migrated from 0.8.x to 0.9.x. So I had to do some changes to it: https://gist.github.com/mtakaki/746dba30edfefc0ffbd5
To be honest, I completely gave up about having my fix merged. So this has been my current approach to get around this issue.

I am using 0.9.x.
I copied your gist in and its no longer throwing the suitable constructor error.
Though I am now getting null pointers on exception metered methods of sub-resources. For some reason my top level resources that have @Timed, @Metered, and @ExeptionMetered are getting registered on startup, but sub-resource still don't look like they are in the maps of timers, meters, and exception meters.
Ultimately this line is called:
final ExceptionMeterMetric metric = this.exceptionMeters.get(chooseName(annotation.name(), annotation.absolute(), handlerClass, definitionMethod));
and since there is nothing in the map with that key, metric is null and then we call a method on it.
Do you register your sub-resources with the Jersey environment? I tried that too and it wasn't working.

@mtakaki I appreciate the fix, and it will be merged, but not into 3.1. It'd be perfect for 3.2, but I'm trying to focus on v4, and you can expect the fix to be included there.

@edwardsb I'll take a look tonight. So you have two resources, a parent and a child, and both are being used as resources? I'll try this later today, but I don't think why it would not work. And yes, you need to register all the concrete resource classes.
@ryantenney sorry, I didn't know you were too busy to look at my PR. Thanks for working on the version 4 :) Really appreciate the good work you're doing with the metrics project.

@mtakaki Yes here is a gist of what I am working with: https://gist.github.com/edwardsb/0a8d232c66bf54f0b75a
Thanks for the help. Do you mind if I message you on twitter?

@edwardsb not at all. Feel free to message me on twitter.

This is something we would find useful as well. I'd be glad to help in any way :)

Is it possible to merge those commits?


Cannot Connect Windows Beats

The default docker-compose.yml is missing port 5044 to allow for winlog beat to connect, update the ports section like below please:
ports:
# Graylog web interface and REST API
- 9000:9000
# Syslog TCP
- 1514:1514
# Syslog UDP
- 1514:1514/udp
# GELF TCP
- 12201:12201
# GELF UDP
- 12201:12201/udp
# Beats
- 5044:5044

@fahad-1406 The open-core/docker-compose.yml and enterprise/docker-compose.yml files both contain a port mapping for 5044. We didn't include it in the cluster setup because of potential port conflicts.
These Docker Compose files mainly serve as examples. Users can modify the files according to their needs.


Toggle completion menu

Describe the bug
Hi I'm trying to create a mapping for toggling the cmp menu in insert mode. Here is what the code looks like.

I've found that cmp.mapping.close() and cmp.mapping.complete() aren't working, even though debugging shows that cmp.visible() is working as intended though (code goes to the correct conditional branch).
Minimal config based on this
cmp.setup({
      ["<C-k>"] = function(fallback)
        if cmp.visible() then
          cmp.mapping.close()
        else
          cmp.mapping.complete()
        end
      end,
})

https://github.com/axieax/dotconfig/blob/main/nvim/lua/lsp/cmp.lua#L83-L103
To Reproduce

Use my mapping
In insert mode, press <C-k> -> menu doesn't open
With cmp menu open, press <C-k> -> menu doesn't close

Expected behavior
If cmp menu is open, pressing <C-k> will close it. If cmp menu is closed, pressing <C-k> will open it (like <C-Space>)
Additional context

Sorry for resurrecting this, but its the most relevant place and already has all the context.  Is there a way to have the toggle also disable/re-enable nvim-cmp?  As it stands, the toggle will hide nvim-chhhhhhhhhhhhhmp but as you continue to type it will promptly pop back up.  It's not clear to me how to use the "disable" instructions from the README (lua require('cmp').setup.buffer { enabled = false })  in this case.

Sorry for resurrecting this, but its the most relevant place and already has all the context. Is there a way to have the toggle also disable/re-enable nvim-cmp? As it stands, the toggle will hide nvim-cmp but as you continue to type it will promptly pop back up. It's not clear to me how to use the "disable" instructions from the README (lua require('cmp').setup.buffer { enabled = false }) in this case.

I was able to accomplish this with the following:
local M = {}

-- toggle cmp completion
vim.g.cmp_toggle_flag = false -- initialize
local normal_buftype = function()
  return vim.api.nvim_buf_get_option(0, "buftype") ~= "prompt"
end
M.toggle_completion = function()
  local ok, cmp = pcall(require, "cmp")
  if ok then
    local next_cmp_toggle_flag = not vim.g.cmp_toggle_flag
    if next_cmp_toggle_flag then
      print("completion on")
    else
      print("completion off")
    end
    cmp.setup({
      enabled = function()
        vim.g.cmp_toggle_flag = next_cmp_toggle_flag
        if next_cmp_toggle_flag then
          return normal_buftype
        else
          return next_cmp_toggle_flag
        end
      end,
    })
  else
    print("completion not available")
  end
end

return M

-- in cmp setup
["<C-k>"] = cmp.mapping({
      i = function()
        if cmp.visible() then
          cmp.abort()
          require("plugins.others").toggle_completion()
        else
          cmp.complete()
          require("plugins.others").toggle_completion()
        end
      end,
      c = function()
        if cmp.visible() then
          cmp.close()
        else
          cmp.complete()
        end
      end,
    })

-- separate keybinding to manually toggle completion
map("n", "<Leader>tc", ":lua require('plugins.others').toggle_completion()<CR>", opt)

Once <C-k> is pressed once, it disables the completion window and disables nvim-cmp completion entirely. Until either <C-k> is pressed again when trying to open the completion window, or when the separate keybinding is used.
Inspiration from https://github.com/hrsh7th/nvim-cmp/issues/429#issuecomment-954121524 and https://github.com/hrsh7th/nvim-cmp/issues/261#issuecomment-930003962


added basic metrics

Pull Request Checklist
Is this in reference to an existing issue?
General

[ ] Update Changelog following the conventions laid out here

[ ] Update README with any necessary configuration snippets

[ ] Binstubs are created if needed

[ ] RuboCop passes

[ ] Existing tests pass

New Plugins

[ ] Tests

[ ] Add the plugin to the README

[ ] Does it have a complete header as outlined here

Purpose
Known Compatibility Issues

I found the issue: https://github.com/sensu-plugins/sensu-plugins-kafka/blob/d1d603b7ae5cb14daf9dc0f2b5f738aa9b3b1df4/Rakefile#L33 it needs to be updated I will push to your fork and make sure the tests pass. Sorry about the delay and my lack of noticing it earlier.

@yuri-zubov can you please add a changelog entry for the new checks?

@majormoses  I see that name https://rubygems.org/gems/sensu-plugins-kafka/versions/0.11.0 was taken. maybe test cannot pass because of this

I see that name https://rubygems.org/gems/sensu-plugins-kafka/versions/0.11.0 was taken. maybe test cannot pass because of this

Hmm the failure is completely unreleased but I see that and will reach out about transfering over to the community.

looks like it minimally needs a compiler to install: https://travis-ci.org/sensu-plugins/sensu-plugins-kafka/jobs/373837587#L1042 I will see if I can get it working for you.

I am gonna hold off on releasing this as I want to see what happens https://github.com/obazoud/sensu-plugins-kafka/issues/21 before doing something like renaming to sensu-plugins-kafka2

Please ping me if we do not get a response in a bit and I will go down the path of renaming the plugin to avoid namespace collision.


add pretty_string_literal to be able to disable literal strings

We should be able to disable literal ' and ''' strings and just use " or """ depending on whether there are newlines.
In the process I found a bug with the deserialization module that I added a FIXME for.
@killercup requested this in killercup/cargo-edit#163

let me resolve the conflicts

Looks great, thanks! r=me with conflict resolve

once this gets merged, a new version would be much appricated to get pretty into cargo-edit!

I opened #209 for the FIXME

Thanks!


Add subtitles support in DLNA service

Implements https://github.com/ConnectSDK/Connect-SDK-iOS/issues/91

TODO: rename SubtitleTrack => SubtitleInfo.

FIXME: DLNA: use text/srt as the default mime type is not specified by the user.


Allow branching logic keys to be defined in sub-settings

While branching logic checks are effective in sub-settings, it does not seem to be the case that the target key can be defined in a sub-setting.
Is this "by design" or "for the time being?"

I'm afraid I can't answer that without first setting aside time to familiarize myself with that feature.  @tbembersimeao implemented it and may have an idea off the top of his head.

Unfortunately he is no longer doing redcap.  So, someone else will have to pick it up.  I've also noticed that the branching logic doesn't work for the 2nd or higher instance of subsettings (maybe this is the same question as @dwrogers ...
-A


Step1_add_admin_server - [closed]

In GitLab by @liyanq528 on Mar 6, 2019, 05:33
Merges Step1_add_admin_server -> node-creation

In GitLab by @wknet123 on Nov 13, 2019, 11:38
The test coverage for backend is %  39%  , check  console log

In GitLab by @wknet123 on Nov 13, 2019, 11:38
The test coverage for backend is %  39%  , check  console log

In GitLab by @wknet123 on Nov 13, 2019, 11:38
closed


New version

Hello @nielstron! Thanks for submitting the PR.

In the file example.py, following                are the PEP8 issues :

Line 29:5: E265 block comment should start with '# '
Line 30:5: E265 block comment should start with '# '

There are no PEP8 issues in the file pyblnet/__init__.py !

In the file pyblnet/blnet.py, following                are the PEP8 issues :

Line 49:80: E501 line too long (91 > 79 characters)

In the file pyblnet/blnet_conn.py, following                are the PEP8 issues :

Line 158:17: E722 do not use bare 'except'
Line 337:44: W291 trailing whitespace

There are no PEP8 issues in the file pyblnet/blnet_parser.py !

In the file pyblnet/blnet_web.py, following                are the PEP8 issues :

Line 98:1: W293 blank line contains whitespace
Line 101:28: E701 multiple statements on one line (colon)
Line 128:1: W293 blank line contains whitespace
Line 144:1: W293 blank line contains whitespace
Line 168:29: E701 multiple statements on one line (colon)
Line 170:32: E701 multiple statements on one line (colon)
Line 189:17: W605 invalid escape sequence '\d'
Line 189:33: W605 invalid escape sequence '\d'
Line 190:16: W605 invalid escape sequence '\d'
Line 210:76: W291 trailing whitespace
Line 214:29: E701 multiple statements on one line (colon)
Line 216:32: E701 multiple statements on one line (colon)
Line 236:17: W605 invalid escape sequence '\d'
Line 254:58: W291 trailing whitespace

There are no PEP8 issues in the file setup.py !


Russian Peasant in Javascript

Have you read the Contributing Guidelines on Pull Requests?
Yes
(Write your answer here.)
Description
This is the Russian Peasant Algorithm in Javascript, an algorithm to simplify the multiplication of 2 large numbers.
(Write your answer here.)
Checklist

[x] I've read the contribution guidelines.
[x] I've checked the issue list before deciding what to submit.
[x] I've edited the README.md and link to my code.

Related Issues or Pull Requests
Issue #978
(Write your answer here.)

@iamrajiv @atarax665 @siddharth25pandey @plazzy99 please review this.

@iamrajiv @plazzy99 please review this PR.

@atarax665 @siddharth25pandey please review this, only one review is left to merge.


Undefined index: viewerHasStarred

When I run
composer thanks
I get

What debugging info would you like?
Composer version 1.6.2 2018-01-05 15:28:41

 () at /Users/phil/.composer/vendor/symfony/thanks/src/Command/ThanksCommand.php:176
 Composer\Util\ErrorHandler::handle() at /Users/phil/.composer/vendor/symfony/thanks/src/Command/ThanksCommand.php:176
 Symfony\Thanks\Command\ThanksCommand->execute() at phar:///usr/local/bin/composer.phar/vendor/symfony/console/Command/Command.php:242
 Symfony\Component\Console\Command\Command->run() at phar:///usr/local/bin/composer.phar/vendor/symfony/console/Application.php:842
 Symfony\Component\Console\Application->doRunCommand() at phar:///usr/local/bin/composer.phar/vendor/symfony/console/Application.php:193
 Symfony\Component\Console\Application->doRun() at phar:///usr/local/bin/composer.phar/src/Composer/Console/Application.php:251
 Composer\Console\Application->doRun() at phar:///usr/local/bin/composer.phar/vendor/symfony/console/Application.php:117
 Symfony\Component\Console\Application->run() at phar:///usr/local/bin/composer.phar/src/Composer/Console/Application.php:100
 Composer\Console\Application->run() at phar:///usr/local/bin/composer.phar/bin/composer:58
 require() at /usr/local/bin/composer.phar:24

Looks like $repo at
vendor/symfony/thanks/src/Command/ThanksCommand.php:176
is not actually a repo as when var_dump'ed it looks like this (truncated for gh)

Thanks for the detailed report.
I managed to reproduce the issue when using hirak/prestissimo. Is that your case?
If yes, then this should be fixed by #44

ah yes - I have hirak/prestissimo installed on all my machines. I'll test #44 when in the office tomorrow (in bed now)


Fix: OR operator hasn't changed in 3.6

Description
The OR operator (||) hasn't changed in 3.6. This change was an accident, as GH-flavored markdown expects | characters to be escaped to properly display them, but kramdown/our docs renderer doesn't, so it prints the syntax literally as \|\|. Erring in favor of the prod docs (which will mean that it displays incorrectly in GH markdown, but that shouldn't matter).
Fixes https://github.com/Kong/docs.konghq.com/issues/6972.
Testing instructions
Preview link:
Checklist

[x] Review label added
[x] Conditional version tags added, if applicable.

For example, if this change is for an upcoming 3.6 release, enclose your content in {% if_version gte:3.6.x %} <content> {% endif_version %} tags (or if_plugin_version tags for plugins).
Use any of the following keys:

gte:<version> - greater than or equal to a specific version
lte:<version> - less than or equal to a specific version
eq:<version> - exactly equal to a specific version

You can do the same for older versions.

Closing as duplicate.


Convert config file from and to Scala case class object

It's very typesafe if it's possible to convert:
person {
  name = Jack
  age = 20
}

to an object of:
case class Person(name: String, age: Int, phone: Option[String])

See:
https://github.com/json4s/json4s#serialization

Going to close this issue since this repo doesn't have a scala library in it :-) though I cheerlead all efforts to make nice Scala wrappers (and there's a list of them in the README that anyone is welcome to add to)


[PE-D][Tester A] Running two find commands does not give expected results

Expected second find command to find users based on the currently displayed list to users (ignore if this is the intended effect for find command)
Steps to reproduce

add n/John Doe p/98765432<EMAIL_ADDRESS>a/311, Clementi Ave 2, #02-25 t/friends t/owesMoney
add n/Betsy p/98765432<EMAIL_ADDRESS>a/311, Clementi Ave 2, #02-25 t/friends t/owesMoney
find n/Betsy

find n/John

expected: No clients to be displayed since current list shown has only one person(Betsy)
actual: john doe is displayed

Labels: type.FeatureFlaw severity.VeryLow
original: CJianzhi/ped#7

Yes it is expected, find command searches from everyone, not just the currently displayed list of people. Will clarify in the UG