retry failed request in the onResponse middleware

Hello there! I've been trying to implement the refresh session functionality for quite some time using the response middleware.
The stumbling block is to retry the failed request inside the middleware. In the following code snippet, I am registering the Middleware and in the onResponse handler I'd like to add the retry line of the original request (look for the comment '// retry request here').
Any consultation would be greatly appreciated.
import { authService, TLoginResponse } from '@/shared/auth'
import { Middleware } from 'openapi-fetch'

let refreshPromise: Promise<TLoginResponse | undefined> | null = null

export const middleware: Middleware = {
  async onResponse({ response, request }) {
    if (response.ok) return response
    else {
      if (response.status === 401) {
        try {
          if (!refreshPromise) {
            refreshPromise = authService.refreshSession()
          }
          const refreshResponse = await refreshPromise
          if (refreshResponse) {
            authService.setAccessToken(refreshResponse)
            authService.setRefreshToken(refreshResponse)

            request.headers.set('Authorization', `Bearer ${refreshResponse.accessToken}`)
            try {
              return // retry request here
            } catch (innerError) {
              if (innerError.status === 401) {
                throw innerError
              }
            }
          }
        } catch (error) {
          authService.setRefreshToken({ refreshToken: null })
          authService.setAccessToken({ accessToken: null })
        } finally {
          refreshPromise = null
        }
      }
    }
  },
}

I thought of an ability to call the coreFetch function with fetchOptions passed to the original request.
export const middleware: Middleware = {
  async onResponse({ response, request, originalFetchOptions, schemaPath }) {
    client.coreFetch(schemaPath, initialFeatchOptions)
 }
}

or
export const middleware: Middleware = {
  async onResponse({ response, request }) {
    client.coreFetch(request)
 }
}

This implies that the coreFetch function would have to be returned from the createClient initializer and itself would handle the first parameter by branching using the following condition
if (schemaPath instanceof Request) {
  ...
} else {
  ...
}

Let me know if it makes any sense at all. Or, perhaps, there are easier ways to achieve this w/o making changes to the source code. Thanks!

I've got one more idea and it's to use native fetch just like this. Are there any problems with this?
import { authService, TLoginResponse } from '@/shared/auth'
import { Middleware } from 'openapi-fetch'

let refreshPromise: Promise<TLoginResponse | undefined> | null = null

export const middleware: Middleware = {
  async onResponse({ response, request }) {
    if (response.ok) return response
    else {
      if (response.status === 401) {
        try {
          // ...

          if (refreshResponse) {
            // ...

            try {
              return fetch(request)
            } catch (innerError) {
              if (innerError.status === 401) {
                throw innerError
              }
            }
          }
        } catch (error) {
          // ...
        } finally {
          refreshPromise = null
        }
      }
    }
  },
}


"RequiresCors" method should be "RequireCord"

It was wrongly written.

Thanks for the contribution. Be sure to check out your name as a contributor about the 3rd of next month on the What's new page in the Community contributors section at the bottom.


fix role account filter

We should expand the definition of what constitutes a "role account".

Looks like what I would expect. For future reference, do you have a role account for each use case?

Looks great to me too


Developing for Android, III: The Rules: Performance

推荐理由：Developing for Android, III:The Rules: Performance
原文链接: https://medium.com/google-developers/developing-for-android-iii-2efc140167fd

@dustookk 认领此任务


GoogleCredentials createScoped does not do anything.

Hi,
The class GoogleCredentials createScoped does nothing, is this expected?`I'm following some online examples, and it still failed, after looking into the code, I see the method has no use?
Could the methods be deleted, or the implementation changed?
package com.google.auth.oauth2;
public class GoogleCredentials extends OAuth2Credentials {

  public GoogleCredentials createScoped(Collection<String> scopes) {
    return this;
  }

  public GoogleCredentials createScoped(String... scopes) {
    return this.createScoped((Collection)ImmutableList.copyOf(scopes));
  }

GoogleCredentials is a base type for credentials and in that sense acts as an abstract class. The usual use case is to use GoogleCredentials.getApplicationDefault() which returns a subclass instance as "GoogleCredentials". All relevant sub classes like ServiceAccountCredentials, ComputeEngineCredentials etc have their own createScoped method implemented. Here is an example.


Default Enum values are expensive

Problem
ResponseHeader.Builder has this code:
        private ResponseCodeEnum nodeTransactionPrecheckCode = ResponseCodeEnum.values()[0];
        private ResponseType responseType = ResponseType.values()[0];

Every time the builder is instantiated an array of all values is allocated and populated for each Enum only to get the first (default) value and discard the rest.
Solution
Can generated code for Enums provide a static defaultValue() method?
Alternatives
No response

The method already exists. It's called fromProtobufOrdinal. Simply replace usages such as this:
ResponseCodeEnum.values()[0]

with
ResponseCodeEnum.fromProtobufOrdinal(0)

and that should resolve the issue.

Actually, the Builder in PBJ still uses the old approach.


update pick_channels docstring

Reference issue
Addressed https://github.com/mne-tools/mne-python/issues/6945
What does this implement/fix?
Resolves ambiguity in docstring related to what "good" channels are.

Merged by cherry-pick + extra tweak commit, thanks @c-torre


Mapping to sealed class

Hey,
I've stumbled upon this library a couple of days ago and it looks awesome! I'm experimenting at the moment and so far i was able to make it work with every case i've tried, except one.
I have a Data Model:
@freezed
class ExtendedContactDataModel with _$ExtendedContactDataModel {
  const factory ExtendedContactDataModel({
    required String id,
    required String? phoneNumber,
    required String? remoteId,
    required String name,
  }) = _ExtendedContactDataModel;
}

And a sealed class (Domain model)
@freezed
sealed class ContactModel with _$ContactModel {
  const factory ContactModel.phonebook({
    required final String id,
    required final String name,
    required final String phoneNumber,
  }) = PhonebookContact;

  const factory ContactModel.synced({
    required final String id,
    required final String name,
    required final String remoteId,
  }) = SyncedContact;

  factory ContactModel.fromData({
    required final String id,
    required final String? remoteId,
    required final String name,
    required final String? phoneNumber,
  }) {
    if (remoteId == null) {
      return ContactModel.phonebook(
        id: id,
        name: name,
        phoneNumber: phoneNumber,
      );
    } else {
      return ContactModel.synced(
        id: id,
        remoteId: remoteId,
        name: name,
      );
    }
  }
}

Unfortunately, the generated code from automappr is missing the phonenumber and remoteId:
    return _i8.ContactModel.fromData(
      id: model.id,
      name: model.name,
    );

And here is the definition:
mappr.MapType<ExtendedContactDataModel, ContactModel>(
    constructor: 'fromData',
)

Hi, so I checked this case and it seems it's more less the same like situation mentioned in https://github.com/netglade/auto_mappr/issues/29.
Basically, this package states that it works with freezed, meaning that it can be both used together. Mapping have to be however specified on case to case basis, since I am not sure we can easily generate code that would support mapping of essentially disjunctive cases. So don't try to tell mappr "map A or B or C or D or E... into X or Y or Z..." but rather "map A to X, map B to Y, map C to Z, ..." and that will be both more clear to you as it will do exactly what you want anytime and also mappr don't have to do some black magic and guess :D
Similar thing also applies to sealed classes, where you also don't want to use that sealed class as a source or target but map it's specific types. We should probably clarify that more in docs. 🤔

Since it's a week without a response, I am closing the issue now. Feel free to reopen the discussion.


Allow for 1.x npmlog

Which doesn't break the interface and is only going to 1.x to get
normal semver semantics going forward.

Sounds good. Thanks!


Write tests for AngularJS frontend

Need to write unit tests for frontend angularjs code

We are approx 30-40% code coverage on the frontend.
Need to also write E2E tests with protractor.js

Unit tests are almost done with around 80-90% coverage


⚠ Bofrost.lu has degraded performance

In 7158f7b, Bofrost.lu (https://www.bofrost.lu) experienced degraded performance:

HTTP code: 200
Response time: 1512 ms

Resolved: Bofrost.lu performance has improved in fb67d14 after 50 minutes.


Remove PICO_FLASH_SIZE_BYTES warning from header to allow -Werror

it breaks any build with -Werror; actual uses in C/CXX source that care should warn instead

Doh! This PR reverts the latest commit on the tinyusb submodule. I expect you didn't mean to do that? :confused:

tsk that's what i get for giving myself temporary powers!


feat: Return page slug for default pages in get applications API in home page

Description
The GET /application/new API is used to show list of organizations, applications in home page. The list of pages under each application contains only page id. As we're introducing page slugs in URLs, we need the slug of the default page inside the response of this API. This PR adds default page's slug to the response of GET /application/new API.
Fixes #10779
Type of change

New feature (non-breaking change which adds functionality)

How Has This Been Tested?

JUnit tests
Manually

Checklist:

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[x] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes

/ok-to-test sha=6d1b087

/ok-to-test sha=aaa0833

/ok-to-test sha=b30cdf2


Upgrade ulid because of panics

I was testing out your modern go application, and left a container running for a few weeks (forgot to stop it). Tested again and I noticed some panics in the ulid generation.
It probably has to do with math.Rand not supporting concurrent use?
See issue in underlying package https://github.com/oklog/ulid/issues/54

Thanks for reporting this issue, I'll take a look at it.


Fix #170

Summary of the PR
Fixes the faulty debug utils callback delegate in Vulkan.
What version does this PR target?
1.2
Related issues, Discord discussions, or proposals
#170
Further Comments
Nope.

Awesome, thanks for the conflict fix!


pick up knative/serving 0.36.0

Signed-off-by: Kenny Leung<EMAIL_ADDRESS>

Codecov Report

Merging #74 (4c4d84c) into main (008b94f) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #74   +/-   ##
=======================================
  Coverage   70.76%   70.76%
=======================================
  Files           4        4
  Lines         195      195
=======================================
  Hits          138      138
  Misses         40       40
  Partials       17       17

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


:construction:  WIP: change video render resolution to a lower default to safe space.

This branch changes the default resolution for video rendering.
This is pretty much a hack and might be subject to change.

Not necessary if evaulation is run a resonable amount


Update fsl-topup from 2203.2 -> 2203.5?

For the same reasons mentioned in https://github.com/nipreps/fmriprep/issues/3373
https://github.com/PennLINC/qsiprep_build/blob/cc461275588647647edccaf3290c898cdc32d1eb/fsl.yml#L14

I just noticed this. @mattcieslak do you foresee any issue with making this change?

If it passes tests, then we're good

actually, if there is a new fsl release we probably want to update all of the components we use at the same time. Just in case there is an interaction


Socket.io connection

Hello 👋,
I wondering is it possible to use RxStarscream with a serveur on Socket.io ? I know I should use Socket.io swift client but have you already try to make it work without the socket.io swift client ? I manage to connect but I get instant disconnect with code error 1000 but according to the RFC 6455 1000 is like a normal closure. If you have any idea or help to provide I will really appreciate it 😄 !

Hey @OmeraWasTaken -
RxStarscream is simply a wrapper around Starscream - you might want to point your question there :)


Website https://genji.dev/ is outdated

What version of Genji are you using?
Not relevant
What did you do?
Simple browse from Google to genji website
What did you expect to see?
A representation fo the actual state of the development, because, when you look for information, this is normally the first contact with this project.
What did you see instead?
Some information on the site are outdated, e.g. First Page Documentation, Getting started (part with badgerDB) which will lead you in the wrong direction.
It's not a big issue, but it makes a bad first impression if the initial information on a project are not up-to-date.

Hm,i see, the 0.14.1 version is working with bbolt.

@willie68 Thanks for reporting this issue. The main branch is the development branch and we are in the process of removing support for bbolt and badger and focusing on pebble.
I understand the confusion though, since this is the first thing one sees when they reach the readme.
The website will shortly be updated once the support for pebble will be properly implemented.
In the meantime, 0.14.1 still has support for bolt and badger


Support DROP ... IF EXISTS style DDL

DDL operations on Cloud Spanner is very slow, and supporting DROP ... IF EXISTS could speed up automatic generation of a data model during development significantly.

Support added for version 0.24


[PROBLEM] Update broken usage of llama_index usage.

[optional format]
Identify the file to be fixed
Those scripts use llama-index.
examples/evaluation/Evaluate_RAG_with_LlamaIndex.ipynb
examples/third_party/financial_document_analysis_with_llamaindex.ipynb
And other scripts using llama_index.
Describe the problem
The llama_index version is not specified. Many module imports and usage are deprecated once the user installs the latest llama_index version.
Describe a solution
Specific to the llama_index installation version and update the usages.
Additional context
Llama_index is a very popular and powerful production agent and many people refer to its example usage. Good maintenance is beneficial.

PR is up for how to use the latest llama-index.
https://github.com/openai/openai-cookbook/pull/1615


Error in Godot 3D documentation

Tested versions
Godot 4.2 documentation
Transform 3D was explained incorrectly

System information
Internet
Issue description
There was a mistake in explaining the matrix that transform3D represents

A transform3D is supposed to be a 3x4 matrix

Steps to reproduce
None
Minimal reproduction project (MRP)
None

I may be wrong, but I believe that the documentation is community, but separately, you should send corrections to the documentation as advised in:
https://docs.godotengine.org/en/latest/contributing/documentation/contributing_to_the_documentation.html
Related: https://github.com/godotengine/godot-docs

I may be wrong, but I believe that the documentation is community, but separately, you should send corrections to the documentation as advised in:

This is true, but the contents of the class reference are actually generated from this repository. So it's appropriate to report it here.
If factually correct, I can keep this in mind for https://github.com/godotengine/godot/pull/87334

I found the "offending" paragraph https://github.com/godotengine/godot-docs/blob/62d5d6cddbb2768976abea1cd3420b36ca492003/tutorials/3d/introduction_to_3d.rst#L35 as part of the introduction to 3D. Yes, this issue should be moved to the other repository.


Enhancement -Reading Plan- Display an alert -to scroll up to view previous months

-Currently for reading plan, the down arrow would open the months that comes after the current month. Since there is a limitation that we cant scroll up beyond a particular point in the reading plan page,  adding a message such as ' scroll up to view the previous months' may help the user (enhancement-for discussion)

https://github.com/Bridgeconn/VachanAppReact/issues/94


Which players

This PR starts from @astroash's elm-spa-boilerplate and begins work on the Which Players page, which will render an organisational relationship "solar-system"/view in CSS. It operates and advances #2 and #6

Removed elm-stuff from PR


Split long modules / Improve directory structure

The project has some modules which are too long or have several classes in them which don't relate:

rasa_core/actions/action.py: 11 classes, > 490 lines
rasa_core/events/.__init__.py: 18 classes, > 950 lines
rasa_core/utils.py:4 classes, > 700 lines
rasa_core/evaluate.py: > 660 lines
tests/test_policies: > 600 lines

In case of the test modules it might also be worth to mirror the directory structure of the source code to ease finding tests.

@wochinge what's the status?

Still has to be done. We made some progress for the utils, but not for the rest.

There is someone on it? Can I work on it?

@MarthaDs There is currently nobody working on it so it would be a great help if you could support us 🎉  One thing: I think it would be great if we could do this in small iterations, e.g. one PR per module split. This makes it easier to review and to give feedback on the changes.

@MarthaDs There is currently nobody working on it so it would be a great help if you could support us  One thing: I think it would be great if we could do this in small iterations, e.g. one PR per module split. This makes it easier to review and to give feedback on the changes.
Alright :)

@MarthaDs There is currently nobody working on it so it would be a great help if you could support us  One thing: I think it would be great if we could do this in small iterations, e.g. one PR per module split. This makes it easier to review and to give feedback on the changes.

Alright :)


⚠ St. Lawrence Global Observatory CKAN Sitemap has degraded performance

In c463ea4, St. Lawrence Global Observatory CKAN Sitemap (https://catalogue.ogsl.ca/sitemap/sitemap-1.xml) experienced degraded performance:

HTTP code: 200
Response time: 17278 ms

Resolved: St. Lawrence Global Observatory CKAN Sitemap performance has improved in 7e89555 after 4 minutes.


Fix a grammatical error in status change message.

The whole story:

Github: cc0d391 changed it's status to pending
Github: cc0d391 changed it's status to pending
Github: cc0d391 changed it's status to error
KW: Did we write this message ourselves?!? The grammar error is driving me crazy. :-)
SF: No, it's either Github's fault or Zulip's!
+ Sigh. I assume it's part of the Travis-CI integration?
– I checked, and that message is not in the JSON message that comes from Github
– Look what I found! https://github.com/zulip/zulip/blob/7227f488c8f9d77fb30b9276192f1147e30c981b/zerver/webhooks/github_webhook/view.py#L273
+ Time for a pull request!
– My moment has arrived.

Automated message from Dropbox CLA bot
@sadjad, thanks for the pull request! It looks like you haven't yet signed the Dropbox CLA. Please sign it here.

Automated message from Dropbox CLA bot
@sadjad, thanks for signing the CLA!

Merged!  Thanks @sadjad and @lonerz.  Note that I squashed the two commits into one.  We always put test changes into the same commit as the code changes.

Thank you so much, @showell and @lonerz!


Use bash parser to separate commands instead of just splitting on lines

Otherwise eg the following will break
echo "hello
there"

Using the tree sitter turned out quite nicely
const commands = this.graph
      .getTree(execution.cell.document)
      .rootNode.children.filter((child) => child.type === "command")
      .map((child) => child.text);

nice 😊


Ensure compatibility check readiness

Coming from https://github.com/opensearch-project/opensearch-devops/issues/114#issuecomment-1548868449
Overview
In order to detect the breaking changes between OpenSearch (core/min) and plugins, we recently onboarded a compatibility check gradle task with OpenSearch. See the pull request.
The task is dependent on publishToMavenLocal task (that publishes the core engine artifacts to maven local). It then clones the plugins' repository in temporary directory and runs ./gradlew assemble.
Action Items
In order to avoid false positives and false negatives, we need to make sure the tasks in below checklist are complete:

[ ] The build.gradle file in this repository uses mavenLocal() as the first entry in repositories() section. This will ensure that when core/min dependencies are published to maven local, gradle looks at maven local first and gets the required core/min dependencies rather than fetching from snapshots or maven central resulting in false checks.
[ ] ./gradlew assemble task passes for the plugin build. If the task itself is broken, checking compatitibility is irrelevant as it will always fail.

Please close this issue once the above checklist is complete.
Thanks!

@minalsha @joshpalis can you please provide an update?

Verified both the items.


Docs should be wrapped at 80 chars

This helps with diffs on small changes, and it's also just more friendly to terminal based editors who tend to size around 80 - 120 chars.
I think we can do this phased in, maybe have something lint only changed files, but eventually I'd like to seem them all wrapped.
Quick tip for Vim users:
V-I-P will select the current paragraph. Then typing !fmt will use the unix fmt command to wrap the text at 72 chars.

@SpamapS is this a ticket you are working on or does this need to be tagged as help wanted?

@SpamapS When you say 'docs', I assume you mean all docs across all BonnyCI projects?

Per Jay's comment, this needs to be done for multiple projects, he'll update the ticket with a list and change it to "epic".

we should add a test for this

So, adding a test for this is fairly simple. "line_length": 80 just needs to be added to .markdownlint.js. Note that line_length is an alias for markdown rule MD013.
The troubling part is that altering the offending docs to conform to this will be an undertaking. Besides being tedious, there are architectural diagrams and links to outside sources that will need to be rethought.

Heard this was done?


use sparkjava

Ah maybe the tests passed because i deleted the tests..Hehe. need to readd the tests from git history... but they must be changed to test sparkjava


Possible Issue with the current License

🚀 The feature
I see the library has been released following the Apache-2.0 license. However, it relies on GPLv2+ license dependencies.
Can we remove such dependencies?
Motivation, pitch
To really have Apache 2.0, we must ensure that the library is actually usable with that license!
In particular, pip-installing python-doctr will also install:

pyphen (0.16.0): ['GNU General Public License v2 or later (GPLv2+)', 'GNU Lesser General Public License v2 or later (LGPLv2+)', 'Mozilla Public License 1.1 (MPL 1.1)'] --> installed by weasyprint
Unidecode (1.3.8): ['GNU General Public License v2 or later (GPLv2+)']

Alternatives
No response
Additional context
weasyprint==61.2
    # via python-doctr
pyphen==0.16.0
    # via weasyprint
pyphen==0.16.0
    # via weasyprint

2 packages.
    pyphen (0.16.0): ['GNU General Public License v2 or later (GPLv2+)', 'GNU Lesser General Public License v2 or later (LGPLv2+)', 'Mozilla Public License 1.1 (MPL 1.1)']
      dependency:
          pyphen
    Unidecode (1.3.8): ['GNU General Public License v2 or later (GPLv2+)']
      dependency:
          Unidecode

Hi @gvalvano :wave:
weasyprint is an optional dependency and will be only installed by the html extensions for example:
pip install "python-doctr[torch,html]"

:)  ref.: https://mindee.github.io/doctr/getting_started/installing.html

Nice! :D thanks for your answer! This solved my issue!
Do you think we can add this to the installation guide, somewhere? So it is easier to find it for future users

Hi @gvalvano 🤗
Yes sure would you like to open a PR ?
We could add it here: https://github.com/mindee/doctr/blob/main/docs/source/getting_started/installing.rst


Make alert box into a macro and try to prety up the field name

I tried to find a way to use the field.label in the error messages, but couldn't make that work.  I thought the next best thing would be pretty up the field name. So that crop_size becomes Crop Size.  Looks a little cleaner. Many of the field names are very close to the field.label.  Some are way off.

Here's how to get to field.label.text:
{% for field_name, field in form._fields.iteritems() %}
{% if field.errors %}
<h1>{{ field.label.text }}</h1>
{{ field.errors }}
{% endif %}
{% endfor %}

Really like this. I've been copying and pasting that chunk into new forms that I make.

Made the change to use the label rather than the capitalized field name.


multiple bug fixes

Fixes #593

set new unread messages to false on window focus
make room description editable after room creation
retain room description & bio indentation

wait, what is the point of set new unread messages to false on window focus

@benawad  so if you have chat opened, but you are on a different tab. Somebody mentions you, there is a red dot visible on the chat square on the BottomVoiceControl. Even if you switch to the Doghouse window, that red dot won't go away unless you close the chat and reopen it.
This PR hides the red dot when window is focused.

shouldn't you make the red dot only appear if chat is closed instead?

yeah, that's actually correct, will fix it.


When I parallely upload images, SSD detector print some unexpected error.

error here
something error: Exiting device scope without proper scope nesting.

cpu version fix it


WIP - return Traversal[CallRepr] instead of Traversal[Call]

this may contain ImplicitCalls
re https://github.com/ShiftLeftSecurity/product/issues/7632

will go with https://github.com/ShiftLeftSecurity/codepropertygraph/pull/1223 instead


annotations come off surface when using keyboard controls

If the users zooms in on the model (or pushes part of it off screen) and then uses keyboard controls to go through annotations, the annotations sometimes float out into space. This is self corrected by zooming back out to view the entire model.

This is related to default browser accessibility functionality. WCAG standards say anything that is not on screen when focused needs to be, so it gets automatically "scrolled" into view. That's what's happening with the annotations. We can disable this specifically for annotation tabbing, but also needs consideration on how to satisfy the accessibility requirement. This will be on the list for v0.45.0

Closed for now in v0.45.0, but needs alternative accessibility option.


Merge main to dev/0.5

Please check if the PR fulfills these requirements

[ ] The commit message follows our guidelines
[ ] Tests for the changes have been added (for bug fixes / features)
[ ] Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
What is the current behavior? (You can also link to an open issue here)
What is the new behavior (if this is a feature change)?
Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
Other information:

Codecov Report

Merging #472 (3144549) into dev/0.5 (b3ee207) will decrease coverage by 0.80%.
The diff coverage is 6.13%.

@@             Coverage Diff             @@
##           dev/0.5     #472      +/-   ##
===========================================
- Coverage    48.98%   48.17%   -0.81%
===========================================
  Files          346      349       +3
  Lines        18559    18887     +328
  Branches      2483     2526      +43
===========================================
+ Hits          9091     9099       +8
- Misses        9468     9788     +320

Impacted Files
Coverage Δ

packages/core/src/2d/atlas/types.ts
0.00% <ø> (ø)

packages/core/src/2d/sprite/Sprite.ts
19.07% <ø> (+0.47%)
:arrow_up:

packages/core/src/Scene.ts
27.86% <ø> (-2.29%)
:arrow_down:

packages/core/src/Transform.ts
85.33% <0.00%> (-0.13%)
:arrow_down:

packages/core/src/animation/AnimationClip.ts
10.14% <0.00%> (+0.46%)
:arrow_up:

...es/core/src/animation/AnimationClipCurveBinding.ts
37.50% <0.00%> (ø)

packages/core/src/animation/AnimationCurve.ts
2.66% <0.00%> (ø)

packages/core/src/animation/AnimatorController.ts
12.90% <0.00%> (-1.39%)
:arrow_down:

...ackages/core/src/animation/AnimatorStateMachine.ts
12.90% <0.00%> (-4.49%)
:arrow_down:

packages/core/src/animation/AnimatorTransition.ts
37.50% <0.00%> (ø)

... and 70 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fabd202...3144549. Read the comment docs.


CAS Supplier Integration 0.5 - Technical Setup

User Story
As a SIMS Product Team, we need to validate the integration between SIMS and the Corporate Account System so that our story implementation is straightforward.
Acceptance Criteria:

[ ] Request Access Token from Supplier API
[ ] Create SIMS API to enable integration with CAS Supplier API and mapping of values:

[ ] GET by Last Name and SIN
[ ] Create Supplier with POST Request

Technical

[ ] Firewall rules should be enabled between OpenShift and CAS

[ ] Developers to use VPN to ensure network connectivity

[ ] ClientID and Secret for token generation to be provided by @sslaws.
[ ] Endpoints and JSON example JSON response provided in documentation for Supplier API

[ ] Get by Last Name and SIN: https://< webserviceURL >:<port_no>/ords/cas/cfs/supplier/:snum/site

Doc 1 - Full Onboarding Document
Supplier Web Service RESTful Client Onboarding v02_01.pdf
Doc 2 - Individual Supplier Webservice Field Requirements
Individual Supplier Web Service Field Requirements (All Requests) JAN2023.xlsx
Context:

a student is a supplier and has a 'supplier number'

@sslaws
I don't think appropriate to bring through Dev lather/groom sequencing, so please let me know if you need clarity on any of this. See the rest of the 'CAS Integration' tickets for context, as necessary.

Sample JSON Response - GET Supplier:
{
"SupplierNumber":"2002492",
"SupplierName":"XYZ Supplier",
"SubCategory":"Individual",
"Sin":"",
"ProviderId":"",
"BusinessNumber":"",
"Status":"ACTIVE",
"SupplierProtected":"N",
"StandardIndustryClassification":"Pharma",
"LastUpdated":"2019-11-13 11:09:50",
"SupplierAddress":[
{
"SupplierSiteCode":"001",
"AddressLine1":"3350 CLEARBROOK RD",
"AddressLine2":"",
"AddressLine3":"",
"City":"ABBOTSFORD",
"Province":"BC",
"Country":"CA",
"PostalCode":"V2T4T4",
<EMAIL_ADDRESS>"AccountNumber":"",

Closing and merging details into #3255


fix: use U512 in apply_batch_header for balances

Use U512 instead of U256 in the temporary balances used in apply_batch_header.
Partially fixes #242.
PR Checklist:

[x] I have performed a self-review of my code
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have made corresponding changes to the documentation
[x] I have added or updated tests that comprehensively prove my change is effective or that my feature works

+1. Would be interesting to see how this impacts the cycle counts.

For test_sp1_simple the cycle count goes from 2495476 to 2495795, so 319 additional cycles with this change. For real-world PPs it will obviously be more, but still fairly negligible I think.


Replace Default File Explorer with Files

What's the Problem?
Windows 11 Start Folders File Explorer
Solution/Idea
Replace file explorer with files app on windows completely. if possible when we click on folder in windows 11 start menu of file explorer. instead of file explorer. Files app should open. i am using this files app for daily use its nice looking and fast compare to file explorer.
Thanks for making such a reliable app!
Alternatives
Replacement of File Explorer with Files Completely!
Priorities

Capability
Priority

This proposal will allow developers to accomplish W
Must

This proposal will allow end users to accomplish X
Should

This proposal will allow developers to accomplish Y
Could

This proposal will allow end users to accomplish Z
Won't

Files Version
v<IP_ADDRESS>
Windows Version
New Windows 11
Additional comment
No response

@thisisibini please refer to the documentation https://files-community.github.io/docs/#/articles/replace-file-explorer.


add metadata when creating invoice

when an API user is creating an invoice, there is a way to pass a memo field. This memo is aimed to be included in the boltt11 invoice, and display to both the sender (because it's part of the invoice) and the recipient.
we should add another field called metadata that allow an API user to add more data related to a payment, without the API user to himself have to have an external database to track the payment information.
this would be needed for a service like zaprite.
this metadata should have limited length. based on my discussion with the developer at zaprite, he had a json stringified with 3 values in it. my gutts feeling would be that maybe 1024 characters long would be ok. obvisouly this is an attack vector if the storage is large so we want to keep this small.

Thanks for this Nicolas.
Here's a gist I had wrote up a few days ago for your team. Hope it helps!
https://gist.github.com/john-magill/530d2b07daeca6c0405c38e2dd4f8cd2
The metadata would be simple, just a few key: value pairs should be fine:
"metadata": {
  "userId": "QNmM7hHzi6vjbi15BSu9",
  "docId": "M7hNmHzi15Bidi6vjbSQ",
  "ref": "l4c9wAxjt8A7QUqZr7Dh"
}

after discussing with john during baltic honey badger, it seemed the requirement to get this was not that important.
the most important requirement was the existence of the webhook


Spark library failing to build

The spark library fails to build on certain operating systems. This is due to unnecessary stopping of the spark context at the end of the FilterToOperationConverterTests.

Merged into develop


[BEAM-4142] HadoopResourceIdTest has had a masked failure

fix and activate sickbayed test

Follow this checklist to help us incorporate your contribution quickly and easily:

[ ] Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

It will help us expedite review of your Pull Request if you tag someone (e.g. @username) to look at it.
 I didn't check carefully. If so, please rebase, otherwise I'll merge as-is.

Run Java_Examples_Dataflow PreCommit

run java precommit


[FEATURE REQUEST] Modify Service Principal creation to have an access to only one resource group

Is your feature request related to a problem? Please describe.
On Azure right now we don't have access to only one resource group using Service Principal creation option.
Describe the solution you'd like
We want to have possibility of creation of Service Principal with access only to specific resourge group.
Describe alternatives you've considered
None.
Additional context
Currently, when we create a service principal (in contributor role for sub) we need to have an "owner" role in the subscription. It is very problematic when the user doesn't have owner rights.
So the problem has two folds:

1. SP being "contributor" on sub level have to be created by user with "owner" rights.
2. SP is having too wide permission (to all resources within subscription)

DoD checklist

Changelog

[ ] updated
[ ] not needed

COMPONENTS.md

[ ] updated
[ ] not needed

Schema

[ ] updated
[ ] not needed

Backport tasks

[ ] created
[ ] not needed

Documentation

[ ] added
[ ] updated
[ ] not needed

[ ] Feature has automated tests
[ ] Automated tests passed (QA pipelines)

[ ] apply
[ ] upgrade
[ ] backup/restore

[ ] Idempotency tested
[ ] All conversations in PR resolved
[ ] Solution meets requirements and is done according to design doc
[ ] Usage compliant with license

@pprach there was some discussion about requirements for SP, can you comment more about those requirements? @rpudlowski93 can you verify how it applies to previous researches you've been doing?

Summing up our conversation with @pprach I would recommend to use managed identity which can resolve the metioned problem. Why? Managed identity manages the creation and automatic renewal of a service principal on our behalf and it is highly recommended by azure. There are two kind of managed identity, system-assigned and user-assigned. System-assigned is tied directly to a resource and is automatically removed as soon as the resource is removed. User assigned is created independent of a resource, and can be used between different resources. We have to check, make review and spike the topic, which option could be more appropriate for our usages. The topic is really deep and connecting it with our new approach - modularization, give us many "question marks". Definitely, we should go in the managed approach.

My concern is this sentence from provided link:

Not all Azure services support managed identities, and availability varies by region.

Hi @mkyc @rpudlowski93
I looked into both types of managed identities and it seems that system-managed identity is not something that we need. Example when it can be useful: we have an Azure function app that needs Contributor access to resource group. In that case we don't need to create any identity, (in case of UI) we do following steps:

enable system-managed identity for function app

Go to mentioned resource group, select IAM tab, and grant RG access with necessary role (Contributor in this case) to specific cloud function (in fact to its system-managed identity). How it looks like:

So for me it doesn't seem that it's something we need. Instead, we can create user-assigned identity and assign it to specific resource group with necessary role(s). It will fulfill listed requirements.

After some investigation of this topic, reviewing and reading different documents/articles, I don't understand how you are going to do that the same way as now with managed identities. In  fact I see 2 options:

Use resource group scopes option when create service principal. To do that resource group should be created before applying main Terraform configuration.
Example: az ad sp create-for-rbac -n "<app_name>" --role contributor --scopes "/resourceGroups/<resource_group>"
Doc: https://docs.microsoft.com/en-us/cli/azure/ad/sp?view=azure-cli-latest#az_ad_sp_create_for_rbac

Managed identities are used for access from one Azure service to another without configuring any credentials. So we need to create a VM with managed identity (doesn't matter system or user assigned), configure resource group to grant IAM permissions to that identity and then apply Terraform configuration from mentioned virtual machine. For that approach VM and resource group should also be created before applying main terraform configuration. From documentation:

At this point we assume that Managed Service Identity is configured on the resource (e.g. Virtual Machine) being used - and that you are running Terraform on that resource.

Doc: https://registry.terraform.io/providers/hashicorp/azuread/latest/docs/guides/managed_service_identity
So I would prefer the first option with a note in modules doc that resource group should be created first and scope is defined. Do we need to make changes anywhere outside modules? I'm asking because initially it's not modules related task.
@toszo @mkyc @rpudlowski93 After your comments I think we can move this task from analysis.

I would go with first option as well. My opinion is that we should:

fix documentation
ensure that current code - which creates RG right now - works ok in this scenario
create followup task in CLI repo to initialise service principal and resource group (probably in some way connected with this task)

Created https://github.com/epiphany-platform/cli/issues/16 task.

The thing about this item is: Currently when we create a service principal (in contributor role for sub) we need to have an "owner" role in the subscription. It is very problematic when user doesn't have owner rights.
So the problem has two folds:

SP being "contributor" on sub level have to be created by user with "owner" rights.
SP is having too wide permission (to all resources within subscription)

The thing about this item is: Currently when we create a service principal (in contributor role for sub) we need to have an "owner" role in the subscription. It is very problematic when user doesn't have owner rights.
So the problem has two folds:

SP being "contributor" on sub level have to be created by user with "owner" rights.
SP is having too wide permission (to all resources within subscription)

So there is an ability to provide a list of resource groups in the scope and necessary roles for that. It's still a question for me if steps that Mateusz listed should be applied only for modules or also in classic Epiphany.

Discussed with @przemyslavic. Let's keep this issue for Epiphany classic and create other ones for modules. For Epiphany classic we have a few options to implement this task.

Create SP with necessary role/scopes before running epicli and update documentation with information about how to do that.
Modify automatic SP creation, make it configurable.
Both options above.

Context:

How to use existing SP in Epiphany: create SP, place sp.yml in build/<cluster_name>/terraform, set use_service_principal  config parameter, apply configuration. For more information look at sp.yml that is created automatically.
Where SP is created in Epiphany: https://github.com/epiphany-platform/epiphany/blob/develop/core/src/epicli/cli/engine/providers/azure/APIProxy.py#L46

Not going todo anymore feature requests for Epiphany.


Changing the limit from 10 to something else

Is there an easy way to change the limit short of implementing get_autocomplete_items?

Might be worth adding this to the README or Wiki.


Under which GHC version / libraries is the 0.15 branch compilable?

I've tried my arch-based install, using ghc 7.10, and my older Windows install which has Haskell Platform 2<IP_ADDRESS> (ghc 7.6.3) but the dependencies can't be resolved. I'm using sandboxes and I nuked my locally installed packages, so I'm out of ideas :expressionless:
Here's what I get on Windows:
Resolving dependencies...
cabal.exe: Could not resolve dependencies:
trying: elm-website-<IP_ADDRESS> (user goal)
trying: snap-server-<IP_ADDRESS> (dependency of elm-website-<IP_ADDRESS>)
trying: MonadCatchIO-transformers-<IP_ADDRESS> (dependency of snap-server-<IP_ADDRESS>)
trying: transformers-<IP_ADDRESS>/installed-f99... (dependency of
MonadCatchIO-transformers-<IP_ADDRESS>)
trying: snap-core-<IP_ADDRESS> (dependency of elm-website-<IP_ADDRESS>)
trying: regex-posix-0.95.2/installed-a7b... (dependency of snap-core-<IP_ADDRESS>)
trying: regex-base-0.93.2/installed-6a5... (dependency of
regex-posix-0.95.2/installed-a7b...)
next goal: mtl (dependency of elm-website-<IP_ADDRESS>)
rejecting: mtl-2.2.1/installed-8f1... (conflict: regex-base =>
mtl==2.1.2/installed-678...)
rejecting: mtl-2.1.2/installed-678... (conflict:
transformers==<IP_ADDRESS>/installed-f99..., mtl =>
transformers==<IP_ADDRESS>/installed-df1...)
rejecting: mtl-2.2.1, <IP_ADDRESS>, 2.2, <IP_ADDRESS>, 2.1.2, 2.1.1, 2.1, <IP_ADDRESS>,
<IP_ADDRESS>, <IP_ADDRESS>, <IP_ADDRESS>, <IP_ADDRESS>, <IP_ADDRESS>, <IP_ADDRESS>, <IP_ADDRESS>, 1.0 (conflict:
regex-base => mtl==2.1.2/installed-678...)
Backjump limit reached (change with --max-backjumps).

I'm using 7.8.3 and I haven't tried out 7.10 yet. I'll see if the mtl dependency can go higher?

That would be great. In the mean time I'm going to see if I can download a Haskell Platform for Windows with ghc 7.8.3.

Also, did you try this advice Backjump limit reached (change with --max-backjumps)?
I know there's a solution because it works for me. You can also try adding constraints to the .cabal file to help guide things

The standard backjump value is 200. I tried it with 2000 but it didn't
yelp. I don't have experience with adding constraints to the cabal file.
But updating my Haskell installation is a good idea anyway.

@Apanatshka, I've found that I often have conflicts when using the Haskell Platform, because of the bundled libraries. I don't know how this applies to Elm, but you could try MinGHC, which packs only the internal GHC libraries. Most importantly, MinGHC is capable of compiling Network, which is a nightmare for Windows users.

Thanks for the tip @BethAr. I installed Haskell Platform 2<IP_ADDRESS> to see if it would work. Elm-Platform master installed without a hitch, then I had to --force-reinstalls this repo while building it in the same sandbox. But whatever, they're all built, and I'm running the 0.15 branch of elm-lang.org locally now :)


raise RuntimeError(msg) RuntimeError: jaxlib is version 0.3.25, but this version of jax requires version >= 0.4.7.

I have this bug msg, I couldn't find jaxlib file of 0.4.7 for windows,

hmm, no idea why jax would be needed. what's the stacktrace?

This is the whole Traceback, I don't know if there is something wrong with my python environment or not.
Traceback (most recent call last):
File "F:\New project\barkGUI\bark-gui\webui.py", line 13, in
from bark import SAMPLE_RATE, generate_audio
File "F:\New project\barkGUI\bark-gui\bark_init_.py", line 1, in
from .api import generate_audio, text_to_semantic, semantic_to_waveform, save_as_prompt
File "F:\New project\barkGUI\bark-gui\bark\api.py", line 5, in
from .generation import codec_decode, generate_coarse, generate_fine, generate_text_semantic
File "F:\New project\barkGUI\bark-gui\bark\generation.py", line 17, in
from transformers import BertTokenizer
File "C:\Users\daihao\AppData\Local\Programs\Python\Python310\lib\site-packages\transformers_init_.py", line 26, in
from . import dependency_versions_check
File "C:\Users\daihao\AppData\Local\Programs\Python\Python310\lib\site-packages\transformers\dependency_versions_check.py", line 17, in
from .utils.versions import require_version, require_version_core
File "C:\Users\daihao\AppData\Local\Programs\Python\Python310\lib\site-packages\transformers\utils_init_.py", line 30, in
from .generic import (
File "C:\Users\daihao\AppData\Local\Programs\Python\Python310\lib\site-packages\transformers\utils\generic.py", line 33, in
import jax.numpy as jnp
File "C:\Users\daihao\AppData\Local\Programs\Python\Python310\lib\site-packages\jax_init_.py", line 35, in
from jax import config as _config_module
File "C:\Users\daihao\AppData\Local\Programs\Python\Python310\lib\site-packages\jax\config.py", line 17, in
from jax.src.config import config  # noqa: F401
File "C:\Users\daihao\AppData\Local\Programs\Python\Python310\lib\site-packages\jax_src\config.py", line 24, in
from jax.src import lib
File "C:\Users\daihao\AppData\Local\Programs\Python\Python310\lib\site-packages\jax_src\lib_init.py", line 73, in
version = check_jaxlib_version(
File "C:\Users\daihao\AppData\Local\Programs\Python\Python310\lib\site-packages\jax_src\lib_init.py", line 62, in check_jaxlib_version
raise RuntimeError(msg)
RuntimeError: jaxlib is version 0.3.25, but this version of jax requires version >= 0.4.7.

weird, seems like it's coming from transformers maybe try updating transformers? or just jaxlib directly?

updated transformers does not work, the problem is there is no 0.4.7 version of jaxlib on the internet for windows, the highest  version available is 0.3.7
cuda111/jaxlib-0.3.5+cuda11.cudnn82-cp310-none-win_amd64.whl
The strange thing is that there are almost no questions and answers about the 0.4.7 version of Jaxlib on Google. I maybe the only one have this bug

strange ya sorry, don't really have good idea... did you try a fresh virtual environment to install stuff from scratch? shooting in the dark here a bit though

updated transformers does not work, the problem is there is no 0.4.7 version of jaxlib on the internet for windows, the highest version available is 0.3.7 cuda111/jaxlib-0.3.5+cuda11.cudnn82-cp310-none-win_amd64.whl The strange thing is that there are almost no questions and answers about the 0.4.7 version of Jaxlib on Google. I maybe the only one have this bug

You probably need to downgrade transformers, to make it compatible with your installed jaxlib

closing for inactivity, feel free to reopen if not fixed

Hello @huanggou666 I'm getting the same error, were you able to solve this? I'm running the colab file of ViT.


Filtering variants

Hi there.
When working with my own scATAC-seq data derived from pre FACS-sorted cells I was never able to identify mitochondrial variants which achieve the thresholds (log10(VMR) > -2 & strand > 0.65) used in filtering the called variants e.g. in the IdentifyVariants function in signac (1.0.0) or in the example workflow for mtscATAC-seq data.
I wanted to ask if the thresholds are only suitable when working with mtscATAC-seq data or can also be worked with when using basic scATAC-seq data. And if not, do you have any recommendations which thresholds to use for basic scATAC-seq data?
Thank you and greetings.

I specifically avoid using the regular 10x scATAC data because the coverage is almost always too bad to work with... So I don't have any immediate recommendations...
Did you try filtering for cells that have at least a mean coverage of 10x? I think that there would be better sensitivity with fewer cells but those with decent coverage

Hi Caleb,
even with a high sequencing saturation (>15,000 fragments per cell) and the custom hard-masked reference genome for CellRanger-ATAC, less than 1% of the cells reach a coverage of at least 10x for the mitochondrial genome. Changing this coverage threshold to include more cells or only keep cells with high mt-genome coverage did not improve the detection of high confidence variants. Do you have further suggestions on how to enable lineage tracing with regular 10x scATAC data, or is this currently really just possible with mtscATAC-seq?
Best,
Malte

The standard 10x scATAC-seq protocol is in principle a "single nucleus" prep. So by definition, there aren't going to be a very high abundance for mitochondria. In fact, whatever reads one observes reads aligned to mitochondria, these may also be noise based on the biological input. Further, without cellular fixation, we saw that there is significant "crosstalk" of mitochondria between nuclei (Fig 1 of mtscATAC-seq paper). For all of these reasons, I'm very skeptical that one could get anything sensible from the prescribed 10x scATAC-seq experimental input.

Thanks for your reply. In the first publication on the topic (Ludwig et al. 2019), it was suggested that the workflow can also be used with single cell sequencing protocols other than mtscATAC-seq such as SMART-seq2 or scATAC-seq with the C1 Fluidigm platform.
Would you recommend working with these data to infer the clonal architecture or will the missing information on
strand concordance and possibly a low coverage of the mitochondrial genome prevent the determinaion of high-confidence variants?

I would of course recommend using mtscATAC-seq data if you can :)
We showed in the Supplement of Figure 3 of the mtscATAC-seq paper that the variant filtering approach works with Smart-seq2 data. I didn't try the C1 explicitly, but it should work.
In principle, we optimized the variant filtering strategy that is being discussed based on strand concordance and VMR to specifically utilize properties of mtscATAC-seq (i.e. uniform coverage, high cell number). We employed other filtering strategies in the 2019 paper, and of course, there are straightforward applications of variant callers like FreeBayes to data from other single cell methods. Those may work best depending on exactly your data input.


added custom primary key support

:+1: I've just done excatly the same code, but named it worse ("id_property" :) ). Please, merge it, it is really useful :)

Great stuff, thanks. I was about to do it myself in the next few days after reading your issue.
I want to take a closer look at https://github.com/tetranz/select2entity-bundle/pull/16 in the next few days and then hopefully merge that and tag another release.


'Timeout getting IP address' when running rancher agent on rancher server's host

Rancher Version:
1.2.0
Docker Version:
1.12.3
OS and where are the hosts located? (cloud, bare metal, etc):
Ubuntu 16.04 / Ubuntu 16.10 cloud, bare metal
Setup Details: (single node rancher vs. HA rancher, internal DB vs. external DB)
Single node rancher with internal DB
Environment Type: (Cattle/Kubernetes/Swarm/Mesos)
Cattle
Steps to Reproduce:

Starts rancher server
Configure host registration url through Admin > Settings menu (point to host ip)
Add a host in default env (set host public ip, as we run on the same machine as rancher master)

Results:
Host is correctly added, but infrastructure stacks doesnt start.

Ipsec & scheduler & metadata services fails with "Expected state running but got error: instance is not running : Dependencies readiness error".
healthcheck	stack  fails with "Expected state running but got error: Timeout getting IP address"
no errors on network manager

Expected:
I tried this multiple times on different hosts (even with pre releases) and almost always get the "Timeout getting IP address" resulting in other stacks being "Dependencies readiness error".
It sometimes crash loop saying Timeout getting IP address, sometimes after few retry it works.
I tried to deploy 1.2.0 with rancher master and environment host on different machines and get almost no issues.
So i think there is clearly something wrong when running rancher-agent on rancher master.
Note that on the hosts i used, i tried to :

stop docker
rm -rf /var/lib/docker/*
rm -rf /var/lib/rancher
restart docker

So i'm almost always restarting from a clean state.

I am having a very similar issue:
Except in my case these are nodes that have two net address:

A public internet facing IP
A private internal IP .

Previously I had to force these nodes to use their Internal IP address using      CATTLE_AGENT_IP=10.X.X.X. so that I could access services in the private network, but
I could also access   services using the internet accessible IP address.
At this point I cannot access services on these nodes.
I tried removing CATTLE_AGENT_UP , but no luck .

Similar problems here. I upgraded from 1.1.4 to 1.2.0. A plethora of containers, such as the 'healthcheck', 'ipsec' and other containers are failing with 'Timeout getting IP address'.

Same problems here: 'healthcheck', 'ipsec' etc. are failing with 'Timeout getting IP address'. Did a fresh Rancher install (all containers+images removed) on RHEL 7.2 / docker 1.11.2.

Same error, multiple services in production stopped working after upgrading from:

1.1.4 (Agent 1.0.2)  to ---> 1.2.0 (Agent 1.1.0).

I recreated the environment again, and all settings, But the error persists.
I use the AWS EC2 (m4.2xlarge) + EBS 2(two) + Reserved Elastic IP(attached) + Debian 8.

Related Issue: https://github.com/rancher/rancher/issues/6689 https://github.com/rancher/rancher/issues/6878 https://github.com/rancher/rancher/issues/6858

Same issue here -
Fresh install Rancher v1.2.0/Docker 1.12.3/RHEL7.2/vmware esx vm's

I have the same error with this three stacks (Timeout getting IP address). I tried to upgrade from 1.1.4 to 1.2.0

Here's a log of rancher-agent on a fresh node still getting the error at line 418:
https://gist.github.com/kkvilekval/2c5ab8ec6197e43a3b301b23f5817d3a
This is an ubuntu box with docker 1.12.3 on it and two ethernet ports:
I have tried setting CATTLE_AGENT_IP to both the internal and external address but end up with similar errors.

@jeanlouisboudart I tried to reproduce your scenario (agent and server on same host) locally with a vFusion vm, but couldn't reproduce. Maybe the problem is specific to running in the cloud. Did you say you got this on bare metal as well? If so, on that machine, did you still have a public and private IP address?

We are tracking all the issues realted to "Timeout getting IP" but I think #6858 is becoming the defacto main issue.
@kkvilekval @marvinwankersteen @pulberg @frekele if your issue is not specifically related to running the agent and server on the same host, can you take a look at that issue? No need to repost the same comments there as here, but take a look  at this comment where @ibuildthecloud gives instructions for gathering logs thatll help us debug, If you have the time and inclination to do so: https://github.com/rancher/rancher/issues/6858#issuecomment-264314609

@cjellick
I have running the agent and server on the same host.
I also sent darren a email with the logfiles.

@frekele  allow me to suggest a simple troubleshooting step:   create a security group that allows all traffic out + in  (you will attach it to servers just for few minutes, don't worry :)  ).
Then attach it to your Rancher servers that participate in cluster (the ones you want to run K8s on).
Delete old K8s env, and create new one.  Wait a few minutes and it will become active.
I just went trough exact errors you show - and it was a security group external IP issues of AWS. i'm pretty confident it will help you.  because i just used the same Rancher + Docker versions and also on AWS.
The issue is - when using AWS sec.group that is linked to itself (something like "allow all traffic from 'dev'<->'dev' group") it will not allow access when it can't recognize from where traffic comes.  The route53 will solve this for you, with CNAME to instance external DNS name. Because for servers from within VPC is will resolve them internal IP (then sec.group will work and allow access) and for external access it will show real external IP.
Forgive me if it's unrelated what i just suggested, but i'm just sleepy and noticed this issue just before going to bed so wanted to type a quick reply that will maybe help someone... (played with Rancher and got this error, knew instantly why it happened, and verified by opening all-to-all in AWS.  of course in production you will need to take care and open particular ports, etc' :)  this was just to be sure it's not a Rancher issue).
I hope it helps! :)

LOL indeed i was sleepy, it was answer for here  https://github.com/rancher/rancher/issues/6878
but K8s or not, it's still same issue I think, so will help in both of those cases  ;)   let me know if it didn't help, because I'm on AWS and want to be aware of such bugs if they exist :P , thanks!

Anyone using boot2docker hosts must be running network services v0.0.2, which is running rancher/network-manager:v0.2.13. This will be the new default for new installs, but if you already have Rancher deployed and there is an "Upgrade Available" next to your "Network Services" stack, please upgrade to get your networking working.
For other people having issues, v1.2.0 only works with your docker bridge as docker0 [https://github.com/rancher/rancher/issues/6896] and docker being installed in var/lib/docker [https://github.com/rancher/rancher/issues/6897]. We are looking to make this more flexible in our next release.

and docker being installed in var/lib/docker [https://github.com/rancher/rancher/issues/6897].

Do you mean the executable "docker" has to be in /var/lib or the docker data folder has to be in there?
My bridge is named docker0 and my docker folder is located in /var/lib already (fresh Debian 8 install), yet I still get the error message.

because of disk space constrains i have "asked" docker to use /data/docker instead of /var/lib/docker. so i stopped the docker service, removed the '-g /data/docker' option from the docker startup script, bind mounted /data/docker to /var/lib/docker (mount --bind /data/docker /var/lib/docker), cleaned the directory, started docker again. after reinstalling rachner everything works as expected.

@cjellick i can reproduce it sometimes on my laptop or on my workstation, i'll try to attach the log

@deniseschannon Just tried again with 2 fresh Ubuntu 16.04.1 VMs and I'm still seeing this issue. network-services got updated to 0.0.2 and is active but ipsec/healthcheck/scheduler all won't come online.

just tried fresh install with server and agent on same host, still have issue for healthcheck, ipsec, scheduler
Expected state running but got error: Timeout getting IP address

I have the same issue, used rancher 1.2 to spin up 2 boot2docker vm's on an esxi host and they never stabilize.

+1 Same issue here.

This Issue was resolved for me:
it has been caused by the following:
I just ran

sudo hostnamectl set-hostname

although this changes the hostname, it does not update your  /etc/hosts file.
So you have to change <IP_ADDRESS> to your hostname manually.
After this everything works correctly, I even tried it with VXLAN

but if you already have Rancher deployed and there is an "Upgrade Available" next to your "Network Services" stack, please upgrade to get your networking working.

That worked for me. Thank you @deniseschannon

I solved this problem. 😄 🎉
@Dmitry1987 Thanks for trying to help, but unfortunately this is not the case.
It is not the related case as either TCP / UDP or ICMP ports.
I was with all ports released (<IP_ADDRESS>/0 All Trafic), but the error persisted.
On startup with cloud-init I attach an additional EBS volume, where I maintain persistent data such as nexus artifact repository, Jenkins jobs, and so on.
I was mounting var/lib/docker on my volume, after removing the link from "var/lib/docker" to my second EBS, it worked perfectly.
In my cloud-init I have several steps, this the script of the EBS to attachment step:
https://gist.github.com/frekele/b5de4d8efea3784780bce61230acf2b5
After the remove:

service docker stop && service docker stop && sleep 5
mv /var/lib/docker /var/lib/docker-original
ln -s $MOUNT_DIR/docker /var/lib/docker
service docker start && sleep 1

It worked perfectly.
Just as @cjellick said, my error is more related to issue https://github.com/rancher/rancher/issues/6858;
I hope it helps someone.

@frekele  nice, thanks for reporting back.
I wonder why you had to stop docker twice? :)  just curious

@Dmitry1987 I created this script when docker was in version v1.10.0.
It was necessary to force the stop several times to block the auto start.
It was thus only for guarantee that the service will be stopped.

Having the same issue with a fresh install of Ubuntu 16.04.1. Metadata, Ipsec and healthcheck not starting.

I dig into this further. I have two Ubuntu 16.04.1 LTS.
Ubuntu 16.04.1 LTS server (in VM) is running Rancher ok.
Ubuntu 16.04.1 LTS desktop (on bare metal) is having issue with Rancher.
I noted that my Ubuntu 16.04.1 LTS desktop is running with KVM and also docker has seccomp security profile enabled. Could seccomp interfere? Any idea how to disable this?

+1
I am also facing exact issue..Tried clean install as well..no luck..

Having the same issue with Ubuntu 16.04.1 LTS (4.4.0) Docker 1.12.4

+1
My Setup

_Ubuntu 16.04.1 (4.4.0-53-generic)
Docker version 1.12.4
Rancher Latest Version (1.2)

I have symlink the docker path

ln -s /opt/docker /var/lib/docker_

Destroyed my old setup - when upgraded to rancher latest...I should have waited I guess :D
To clarify this issue, it first happened when upgraded to latest rancher version but even when trying fresh.
I cleaned everything from images/container/volumes/iptables
Used image meltwater/docker-cleanup for cleanup
docker run -v /var/run/docker.sock:/var/run/docker.sock:rw -e CLEAN_PERIOD=2 -e DELAY_TIME=10 meltwater/docker-cleanup:1.8.0
and for iptables
iptables -F
iptables -X
iptables -t nat -F
iptables -t nat -X
iptables -t mangle -F
iptables -t mangle -X
iptables -P INPUT ACCEPT
iptables -P FORWARD ACCEPT
iptables -P OUTPUT ACCEPT

Eventhough,  I started fresh, I have the same issue :(
healthcheck & scheduler are throwing  (Expected state running but got error: Timeout getting IP address)
I upgrade from "UI => All Stacks" the network-services
These are the versions of images
rancher/network-manager    v0.2.14             cd8ad8d4aa0a        8 days ago          239.3 MB
rancher/server             latest              ae0bc36ab32e        2 weeks ago         930.5 MB
rancher/plugin-manager     v0.2.12             7c5bcc8cd612        2 weeks ago         239.3 MB
rancher/agent              v1.1.0              5feacb9a8016        2 weeks ago         231.4 MB
rancher/net                v0.7.5              1236043acf62        2 weeks ago         259.3 MB
rancher/dns                v0.10.8             5ba07a942608        2 weeks ago         237.6 MB
rancher/metadata           v0.6.8              73383c82f7e1        2 weeks ago         244.6 MB
rancher/scheduler          v0.4.0              9f72b8dfceaf        3 weeks ago         182.7 MB
rancher/healthcheck        v0.1.0              6d1b8798c81d        6 weeks ago         290.7 MB

Hope somebody can put some light on this.
This upgrade should've gone smooth, can't imagine what if I was in production (that was my aim).
docker logs -f --tail 10 rancher-server
2016-12-15 13:27:44,247 ERROR [b80fd475-2c4d-443b-af50-f270bbbf5455:1172] [instance:47->instanceHostMap:43] [instance.start->(InstanceStart)->instancehostmap.activate] [] [ecutorService-2] [c.p.e.p.i.DefaultProcessInstanceImpl] Agent error for [compute.instance.activate.reply;agent=1]: Timeout getting IP address
2016-12-15 13:27:44,247 ERROR [b80fd475-2c4d-443b-af50-f270bbbf5455:1172] [instance:47] [instance.start->(InstanceStart)] [] [ecutorService-2] [i.c.p.process.instance.InstanceStart] Failed [2/2] to Starting for instance [47]
2016-12-15 13:27:45,543 ERROR [9af4595e-540a-468e-a79b-3674bdf3813b:106] [service:4] [service.activate] [] [cutorService-13] [c.p.e.p.i.DefaultProcessInstanceImpl] Expected state running but got error: Timeout getting IP address
2016-12-15 13:27:45,552 ERROR [:] [] [] [] [cutorService-13] [.e.s.i.ProcessInstanceDispatcherImpl] Expected state running but got error: Timeout getting IP address
2016-12-15 13:28:57,168 ERROR [0e3dc19d-0a2d-45d2-9d85-6579e12e5e25:1224] [instance:48->instanceHostMap:44] [instance.start->(InstanceStart)->instancehostmap.activate] [] [ecutorService-1] [c.p.e.p.i.DefaultProcessInstanceImpl] Agent error for [compute.instance.activate.reply;agent=1]: Timeout getting IP address
2016-12-15 13:28:57,168 ERROR [0e3dc19d-0a2d-45d2-9d85-6579e12e5e25:1224] [instance:48] [instance.start->(InstanceStart)] [] [ecutorService-1] [i.c.p.process.instance.InstanceStart] Failed [1/2] to Starting for instance [48]
2016-12-15 13:28:57,241 ERROR [0e3dc19d-0a2d-45d2-9d85-6579e12e5e25:1224] [instance:48->instanceHostMap:44] [instance.start->(InstanceStart)->instancehostmap.activate] [] [ecutorService-1] [c.p.e.p.i.DefaultProcessInstanceImpl] Agent error for [compute.instance.activate.reply;agent=1]: Timeout getting IP address
2016-12-15 13:28:57,241 ERROR [0e3dc19d-0a2d-45d2-9d85-6579e12e5e25:1224] [instance:48] [instance.start->(InstanceStart)] [] [ecutorService-1] [i.c.p.process.instance.InstanceStart] Failed [2/2] to Starting for instance [48]
2016-12-15 13:28:58,584 ERROR [727e6a41-dd17-4aa3-a2e7-7aa336766820:107] [service:3] [service.activate] [] [ecutorService-9] [c.p.e.p.i.DefaultProcessInstanceImpl] Expected state running but got error: Timeout getting IP address
2016-12-15 13:28:58,592 ERROR [:] [] [] [] [ecutorService-9] [.e.s.i.ProcessInstanceDispatcherImpl] Expected state running but got error: Timeout getting IP address

Regards,

Interesting...
If I remove the symlink and do fstab bind to the directory, it fixes the healthcheck & scheduler issue but got 2 new :D

# systemctl stop docker
# rm /var/lib/docker
# mkdir -p /var/lib/docker
# echo "/opt/docker /var/lib/docker auto rw,bind 0 0" >> /etc/fstab
# mount -a
# systemctl start docker

Issue 1: Can't register any new hosts (tried 2)
# docker logs -f 27cca4a9bb48
INFO: Running Agent Registration Process, CATTLE_URL=http://<IP_ADDRESS>:8080/v1
INFO: Attempting to connect to: http://<IP_ADDRESS>:8080/v1
ERROR: http://<IP_ADDRESS>:8080/v1 is not accessible
ERROR: http://<IP_ADDRESS>:8080/v1 is not accessible

If I do curl http://<IP_ADDRESS>:8080/v1/scripts/D16E0DE849EC5A8A468F:1481810400000:hwMyxubEKGP4v3aVDChxQqEngw

#!/bin/sh

export CATTLE_REGISTRATION_ACCESS_KEY="registrationToken"
export CATTLE_REGISTRATION_SECRET_KEY="D16E0DE849EC5A8A468F:1481810400000:hwMyxubEKGP4v3aVDChxQqEngw"
export CATTLE_URL="http://<IP_ADDRESS>:8080/v1"
export DETECTED_CATTLE_AGENT_IP="<IP_ADDRESS>"

Issue 2: My server hangs up when I restart it (I guess it has to do with something with mount)
didn't have time to check more
Regards,
lolz

I had 2 hosts that spun up with an unhealthy state, did the network upgrade

switch to port forwarding instead of reverse proxying and that fixed
them. Then I added 2 nodes in the same environment, dynamically spun up
boot2dockers on esxi but they remain unhealthy and the netwerk upgrade is
unavailable.

[image: Inline image 1]
Regards,
Kris
On Thu, Dec 15, 2016 at 3:32 PM, lolziac<EMAIL_ADDRESS>wrote:

Interesting...
If I remove the symlink and do fstab bind to the directory, it fixes the
healthcheck & scheduler issue but got 2 new :D
systemctl stop docker
rm /var/lib/docker
mkdir -p /var/lib/docker
echo "/opt/docker /var/lib/docker auto rw,bind 0 0" >> /etc/fstab
mount -a
systemctl start docker
Issue 1: Can't register any new hosts (tried 2)
docker logs -f 27cca4a9bb48
INFO: Running Agent Registration Process, CATTLE_URL=http://<IP_ADDRESS>:8080/v1
INFO: Attempting to connect to: http://<IP_ADDRESS>:8080/v1
ERROR: http://<IP_ADDRESS>:8080/v1 is not accessible
ERROR: http://<IP_ADDRESS>:8080/v1 is not accessible
If I do curl http://<IP_ADDRESS>:8080/v1/scripts/D16E0DE849EC5A8A468F:
1481810400000:hwMyxubEKGP4v3aVDChxQqEngw
#!/bin/sh
export CATTLE_REGISTRATION_ACCESS_KEY="registrationToken"
export CATTLE_REGISTRATION_SECRET_KEY="D16E0DE849EC5A8A468F:1481810400000:hwMyxubEKGP4v3aVDChxQqEngw"
export CATTLE_URL="http://<IP_ADDRESS>:8080/v1"
export DETECTED_CATTLE_AGENT_IP="<IP_ADDRESS>"
Issue 2: My server hangs up when I restart it (I guess it has to do with
something with mount)
didn't have time to check more
Regards,
lolz
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/rancher/rancher/issues/6864#issuecomment-267341403,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AA9BXoEc1Zbysd33kdWhJgRjVqW_SRErks5rIU-TgaJpZM4LB6UW
.

Dear All,
I can confirm that v1.2.1 fixes also my
Issue 1: Can't register any new hosts (tried 2)
But only if you mount the /var/lib/docker directory ... it doesn't work for me with symlink.
This works OK for me but now I have to find out why that fstab entry is not allowing my hosts to boot properly (they hangup) when rebooted.
echo "/opt/docker /var/lib/docker auto rw,bind 0 0" >> /etc/fstab

If somebody can point me to the right direction I would appreciate it a lot.
Regards,
lolz

I had the same issue. In my case was caused because I'm using a DNS name for my rancher server that resolves to our public IP address. The machine is located behind a router/firewall that doesn't know how to route the packets when I using the public IP address from inside the network.
So I just configured dnsmasq service in out server to resolve our domain name to the server IP address and I got it working.

I solved my issue on Ubuntu 16.04.1 LTS desktop. It seems to be a DNS configuration issue.
It was using localhost instead of external dns.
Here are the steps to fix it:

Edit /etc/NetworkManager/NetworkManager.conf and comment dns=dnsmasq
service network-manager restart
Start your rancher agent.

Ref: http://askubuntu.com/questions/201603/should-i-edit-my-resolv-conf-file-to-fix-wrong-dns-problem

Thank You!  Resolved my issue that I've been stuck on since new release.
On Tue, Dec 20, 2016 at 12:17 PM, courcelm<EMAIL_ADDRESS>wrote:

I solved my issue on Ubuntu 16.04.1 LTS desktop. It seems to be a DNS
configuration issue.
It was using localhost instead of external dns.
Here are the steps to fix it:

Edit /etc/NetworkManager/NetworkManager.conf and comment dns=dnsmasq
service network-manager restart
Start your rancher agent.

Ref: http://askubuntu.com/questions/201603/should-i-
edit-my-resolv-conf-file-to-fix-wrong-dns-problem
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/rancher/rancher/issues/6864#issuecomment-268347064,
or mute the thread
https://github.com/notifications/unsubscribe-auth/APDrqEWtP2mUiYemhXvbhFYiroDOCYZlks5rKDe9gaJpZM4LB6UW
.

--
Kris Kvilekval, Ph.D.
ViQi LLC
(805)-699-6081

Thank you. The issue was resolved after upgrading to v1.3.0. 😄 🎉

I'm on 1.3.1 and experiencing the same Timeout. We don't have access to a Public facing IP and our DNS servers are also internal. Any ideas on what I should check and where?

We're on 1.3.3; HA setup (two servers) behind ALB on AWS, route53; Currently we can't deploy one of our mayor services with 300 containers. Sorry to say but 1.1.4 was better in this respect.

I've been seeing this issue off and on as well, I posted what finally worked for me in a different thread tracking the same error: https://github.com/rancher/rancher/issues/6858#issuecomment-276386087


Runtime can not catch all logs when OOMKilled

When OOMKill happends, container will send:
      [INFO] USER COMMAND START

      /usr/local/pai/runtime: line 28:     7 Killed
      ${PAI_RUNTIME_DIR}/runtime_entry.sh > >(tee -a -i
      ${PAI_LOG_DIR}/runtime.pai.stdout) 2> >(tee -a -i
      ${PAI_LOG_DIR}/runtime.pai.stderr >&2)

to stderr, but in log file, we only can see [INFO] USER COMMAND START

fixed in pure k8s version.


 Preparing to publish those docs.
This can wait till the build https://github.com/qiskit-community/qiskit-translations/actions/runs/1884635449 is successful
Details and comments

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 90.644%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
4069

Relevant Lines:
4489

💛  - Coveralls

Is it stable backport potential? @woodsp-ibm @manoelmarques


New AWS SDK, 1.8.121

Steps to achieve state of code in this branch:

Revert #5, #4, #3, #2, #1
Merge upstream (747f6d69a0929c3ea4c7dcc76f53403bb09d3419)
Cherry-pick #1, #2, #3, modified #4 (38d9b0212839821c107460e2f6468896c42c6061), #5.
Remove attempt to access EC2 metadata to determine region in ClientConfiguration constructor (7d48b2c8193679cc4516e5bd68ae4a64b94dae7d).

When merging that one need to update main ClickHouse repository to point to final commit of this submodule. FYI @alexey-milovidov

When merging that one need to update main ClickHouse repository to point to final commit of this submodule. FYI @alexey-milovidov


Live tracking marker or similar

Hi, Firts of all, congrats on putting together this awesome project
I have been triying to figure it out to do a live tracker marker o something like this, so Is there a way to implement this plugin into dash-leaftlet or make a marker that updates his position on the map like that ?
https://github.com/alexandra-c/leaflet-tracking-marker
https://leavittmapping.com/projectpages/livetrackingdashboard

I believe the answer is yes to both options. I don't see any immediate blockers in writing a small wrapper for the plugin, in which case you would be able to use the functionality "directly". I believe this would be the best solution. An alternative would be to update a marker using a (clientside) callback. I guess it would be possible to emulate the behaviour of the plugin this way, but it would be a bit less elegant (and the performance would be poor, unless you use a clientside callback).


[test] Avoid unspotted API docs changes

Ensure the API is always up to date.

@rosskevin Some broken things I have noticed introduced with #8983

We mark properties required while they are not.

-| component | ElementType | 'div' | The component used for the root node. Either a string to use a DOM element or a component. |
+| component * | ElementType | 'div' | The component used for the root node. Either a string to use a DOM element or a component. |

The classes property is missing in some components.

-| classes | Object |  | Useful to extend the style applied to components. |
+| classes | Object |  |  |

A theme property has been added to all the components.

+| theme | Object |  |  |


Documentatin for Jupyter Book creation sparse

Is your feature request related to a problem? Please describe.
Creating a Jupyter book doesn't seem to work for me, but I also don't know what I would need here. This is what the create book looks like:

Describe the solution or feature you'd like
I'd like to see some more samples, or a link to the structure that we would expect for a Jupyter book on a Windows filesystem (or Linux/OSX as well)
Describe alternatives you've considered
I have tried to look at the documentation at https://jupyterbook.org/guide/01-5_tour.html , but this doesn't seem to be quite clear to me what notebook files and markdowns might be needed. This also doesn't really template things out in the format we might need on a Windows machine. I'd assume that I don't need to escape paths, but I'm not sure.
Additional context
Add any other context or screenshots about the feature request here.

@MaddyDev please work with PMs for how we can make these instructions clearer.

@yualan Did you get a chance to update the documentation?


On the file page, the repository's description, website link, topics list, and statistics bar should be gone

Description
On the file page, the repository's description, website link, topics list, and statistics bar should be gone to make space for the actual file. For example, this is what I expect when I'm linked a license file to read (this was edited/not how it looks like):

Instead, my screen is mostly filled with generic info on the repository that I expect on its main page, not when I'm trying to look at a file of which I can just see a single line of its content:

Oh and I forgot to mention, GitHub does this too. So it's not just some weird idea I came up with myself.
Gitea Version
1.17.2+75-g67c091c
Can you reproduce the bug on the Gitea demo site?
Yes
Log Gist
No response
Screenshots
No response
Git Version
No response
Operating System
No response
How are you running Gitea?
I'm not, I tested this on others' instances
Database
No response

Hi, The fix for this issue has been raised as #21420
The repo description, topics and stats are conditionally hidden when the user is in file view or blame mode


Make Pirant compatible for multiple python versions

Problem statement: Seems like pirant is compatible to only py2.7 currently. We should make it compatible for 3.4 and above also.
Solution suggested: @AmirAliM suggested on using SIX package
Scope of implementation: Fix existing codebase to make it compatible for all python versions.
References:
SIX package: https://pythonhosted.org/six/

Sorry, but doesn't pirant already work with python >=3? At least all tests pass here with python 3.6

@Cogitri We need to recheck once again.
@AmirAliM found out an instance were it fails.
In python 3, response.context returns bytes while in python 2.7, it returns string. Hence, json.loads() works in 2.7 but not in 3.4
Why this was not captured in tests because we only wrote Unit tests and all these external responses using request library are mocked, hence we missed it and all tests passed.

@AmirAliM , @Cogitri mentioned about using future over six. He also provided a reference: http://python-future.org/faq.html#what-is-the-relationship-between-future-and-six
Have a look into it and lets discuss how to resolve this issue or whether its already resolved by @Cogitri commit #18


use Arrays.fill to simplify codes

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Add style to README

Hey Ben @Bonkles, I would be interested in styling the Rapid README. I enjoy organizing and styling markdown files. Let me know if this is something I can contribute to. Thanks! :smile:

Closing here as done in #1184 , but definitely keep improving the README if you want to!  🙏


Error while calling login with one argument

Version info
Angular: 2.0.0
Firebase: 3.4.1
AngularFire: 2.0.0-beta.5
Steps to reproduce
Call login method with only credentials:
let creds  = firebase.auth.FacebookAuthProvider.credential(response.authResponse.accessToken);   this.af.auth.login(creds);
Expected behavior
It uses the given credentials.
Actual behavior
Throws
"You must include credentials to use this auth method. "
I guess the problem is that you can call login with optional config or credentials and optional config
 login(config?: AuthConfiguration): firebase.Promise<FirebaseAuthState>;
 login(credentials: EmailPasswordCredentials | firebase.auth.AuthCredential | string, config?: AuthConfiguration): firebase.Promise<FirebaseAuthState>;

So I guess we need some typecheck in 1 argument case. Of course you can avoid this issue by always defining a configuration with credentials.

@apreg I don't see this as an error. what does your creds object looks like when you receive the authResponse.accessToken from below.
let creds = firebase.auth.FacebookAuthProvider.credential(response.authResponse.accessToken);
Is it an Object with "email and password" attributes or a firebase.auth.AuthCredential object
The below method when passed the arguments correctly, even though one argument of credentials should work just fine.
login(credentials: EmailPasswordCredentials | firebase.auth.AuthCredential | string, config?: AuthConfiguration): firebase.Promise<FirebaseAuthState>;

@apreg I think, I see your point.

Hi @apreg!
Did you configure your provider in the Main Module?

Hi @davideast !
Yes, I did.
const firebaseAuthConfig = {
  provider: AuthProviders.Facebook,
  method: AuthMethods.OAuthToken,
  scope: ['public_profile', 'email', 'user_birthday', 'user_photos']
};

I'm getting the same error in attempting a custom token login:
    this.af.auth.login(this.token, {
      provider: AuthProviders.Custom,
      method: AuthMethods.CustomToken
    })
    .then((success) => {
      console.log("Firebase success: " + JSON.stringify(success));
    })
    .catch((error) => {
      console.log("Firebase failure: " + error);
    });

returns: You must include credentials to use this auth method.


Epic: Foundational UI components

[ ] https://github.com/nautobot/nautobot/issues/1858
[ ] #2586

Following up a conversation with @glennmatthews I have two suggestions/requests here:
Related-objects table
The Provider model has a table at the bottom of the detail view that shows all Circuit instances that belong to it. I am currently using the same pattern in a VPN -> Tunnel relationship and I can imagine it being useful in a multitude of scenarios.

Endpoint view
The Circuit has two panels on its detail view that either allow for the creation of or show the related circuit endpoints. In my plugin development case this could be useful for two TunnelEndpoint instances of a Tunnel, but I could reasonably see usage of this as a future addition to the Cable detail view as an example.

Adding another use case tot he endpoint view, its also re-implemented in the BGP App


armcc - remove libpath from ld flags

libpath is not required for exporters, as they provide default paths.
This caused problems when paths are not correct for mbed tools, a project
fails to build as path is not found.
@mlnx @adbridge @bogdanm @sg-

Tested with a wrong path - to get that error about lib not existing, then with this patch. Run project.py for uvision, and mbed script to compile blinky.

Doesn't this change affect command line compilation?

Ah wait, ld still gets its --libpath. My bad. +1.


xSQLServerDatabaseDefaultLocations: New Resource

Pull Request (PR) description
Created new resource for setting Database Default Locations (Data/Log/Backup) for SQL Server
This Pull Request (PR) fixes the following issues:
Fixes #656
Task list:

[X] Change details added to Unreleased section of CHANGELOG.md?
[X] Added/updated documentation, comment-based help and descriptions in .schema.mof files where appropriate?
[X] Examples appropriately updated?
[X] New/changed code adheres to Style Guidelines?
[X] Unit and (optional) Integration tests created/updated where possible?

This change is

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: PaulFeaser sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.

@msftclas I'm full-time Microsoft employee, not sure why it is asking for a signed CLA.

Codecov Report

Merging #854 into dev will increase coverage by <1%.
The diff coverage is 100%.

@@         Coverage Diff          @@
##            dev   #854    +/-   ##
====================================
+ Coverage    96%    96%   +<1%
====================================
  Files        31     32     +1
  Lines      3407   3453    +46
====================================
+ Hits       3290   3336    +46
  Misses      117    117

@PaulFeaser Contact @mbreakey3 or @kwirkykat and make sure you are in the Microsoft organisation in GitHub (think that's the problem).

@PaulFeaser Could you please rename the resource to 'xSQLServerDatabaseDefaultLocation' (singular). Throughout the files.

I would be happy to rename it.  However, I made it plural because that matches exactly how it is in SQL Server Management Studio.

All other resources are singular and in PowerShell the norm is to use singular in all Cmdlets. So I rather see this as singular too.

Sounds good, I will rename it.


[🐘 gradle-plugin] Use Gradle normalization instead of ours

We don't need internal sourceRoots as FileCollection rightfully includes the normalized path.
This simplifies the code quite a bunch but is unfortunately blocked on https://github.com/gradle/gradle/issues/28147
Also this is a behaviour change for users using both packageNameFromFilePaths and schemaFile that can be mitigated by using schemaFiles instead:
    packageNameFromFilePaths()

    // replace
    schemaFile.set("src/main/graphql/com/example/schema.graphqls")

    // with
    schemaFiles.from(fileTree("src/main/graphql/").apply {
      include("com/example/schema.graphqls")
    })

I found a workaround


Adding support for listing Cosmos DB operations

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.
PR information

[X] The title of the PR is clear and informative.
[X] There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
[X] Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
[X] If applicable, the PR references the bug/issue that it fixes.
[X] Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

[X] I have read the contribution guidelines.
[X] My spec meets the review criteria:

[X] The spec conforms to the Swagger 2.0 specification.
[X] The spec follows the guidelines described in the Swagger checklist document.
[X] Validation tools were run on swagger spec(s) and have all been fixed in this PR.

Looking at this..

One more thing, it seems there is a syntax error with the spec and none of the CI jobs were able to proceed. Please fix this and make sure all documents have well formed json.
See these:
1
2
3

@balajikris applied the fixes

Thanks @dmakwana  -- Merging.

No modification for AutorestCI/azure-sdk-for-node

No modification for AutorestCI/azure-sdk-for-ruby

 https://github.com/Azure/azure-sdk-for-python/pull/1385


Issue 4923 - immutable module variables are modifiable in non-shared module constructors

Check that the right kind of module constructor is used to initialize globals.  Improve error message.
Fixes Issue 4923
http://d.puremagic.com/issues/show_bug.cgi?id=4923

ping

I don't even remember how this works any more.


⚠ Bofrost.at has degraded performance

In 9631a45, Bofrost.at (https://www.bofrost.at) experienced degraded performance:

HTTP code: 200
Response time: 1551 ms

Resolved: Bofrost.at performance has improved in 6f08bb2.


Feature Request - Compatibility with go sql

This mostly involves these tasks:

[x] Register the go sql driver upon import (when simply calling this, but then for SurrealDB:  import 	_ "github.com/go-sql-driver/mysql")
[ ] Create a "SQL connection string" for SurrealDB - e.g. parsing the username, password, database, namespace, etc. from a string (should be relatively easy)

[x] username
[x] password
[x] URL
[ ] database name
[ ] namespace

[ ] Implement the types/methods mentioned at https://pkg.go.dev/database/sql/driver - mostly around converting to/from standard Go values and SurrealDB database values.

This would make using SurrealDB pretty straight forward.

I'd like to help out if possible. Anything I can pick up?

I've been playing around with this and I noticed a couple of things:

It isn't too difficult to get FETCH support for returned objects/structs

type fetch[T any] []T

func (yne *fetch[T]) Scan(value any) error {
	if value == nil {
		*yne = fetch[T]{}
		return nil
	}

	bytes, err := json.Marshal(value)
	if err != nil {
		return err
	}

	items := fetch[T]{}
	err = json.Unmarshal(bytes, &items)
	if err != nil {
		return err
	}

	*yne = append(*yne, items...)

	return nil
}

the fields dont necessarily come back in order, this will be kinda difficult to wrangle when it is time to Scan the data into the values

SELECT name, email, age, ->buys->item as bought from user:1  fetch bought
///
[
  {
    "time": "101.532µs",
    "status": "OK",
    "result": [
      {
        "age": null,
        "bought": [
          {
            "id": "item:1",
            "name": "some item",
            "price": "999.99"
          }
        ],
        "email": null,
        "name": "SurrealDB"
      }
    ]
  }
]


Validate session time zone in Config

Validate configurations when they are being set to reject "bad" settings early
on.

Next step would be to replace generic 'get' API with strongly-typed getXxx APIs.

@mbasmanova Added this function to return timezone ID.

/// Returns session timezone ID. Throws error if the timezone name cannot be
/// recognized. If the timezone is not set, returns -1.
int16_t sessionTimezoneId() const;

validate failed if user pass a "" to default timezone. Should we always pass a valid timezone?


not turning into exe after downloading python.

Describe the bug
ive downloaded python, and when i compile the source the dist has a file named "source_prepared"
i use a windows 11 btw.

could it be the directories or folder name i use as i dont know what to put so i input a random word?

it's because the executable name that you provided in builder is for PySilon executable after it's injected into the victim's OS. You can rename that to whatever you want and the exe name will be used when it's on victims PC.


Add client IP address

It would be good to have the IP address of the Amazon Echo that sent the request in the JSON data. This would allow better automatisations with multiple Echo devices in the same apartment.

To let use the same names to different Echo devices (example soft lights in different rooms/floors) it would be better to specify IP address of the desidered Echo into Node Red Echo HUB, and connect to it the devices that we want only that Echo should recognize.

Not sure how you mean that. You mean during discovery? In this case this won't work as all Echo devices on the same account share the discovered devices.

Yes, and you can't use duplicate names, for example. If you "customize" the HUB for working only with that Echo you can be sure the JSON data will come from only that Alexa

That's not the idea here. I don't want to have multiple hubs. This would complicate things a lot. I want a single hub for all Alexa's. It should just be possible to identify which Alexa sent the command, that's all. A simple attribute with the IP address of the client would be enough for this.

Ok, I patched the code and added the client IP address. Bad news: requests always come from a "master" Alexa device in the network. Other Alexa devices route their requests via the master device. I don't know if there is any other way to identify the "active" Alexa device.

So you mean Alexa are descovering each other into the network and assign between them a master?

Seems like this. All the requests to the Hue emulation always come from a single Alexa device, even if you're talking to another device.
I wouldn't say this is "horrible", but it won't allow an emulated Hue to behave differently for different Alexa devices.

are you maybe using the same amazon account for both Alexa? Have you tried to register the Alexas in different accounts?

Sure I'm using the same account. Setting them up on different accounts doesn't make sense to me.

PLease use a different account, and then check if the IP packet come from different IP, that maybe can make sense to you,.


Remove Clear Button

hi jerosoler, pls tell me how can I remove clear button only from "other"

What do you mean by "other"? And "clear button"????

hi, you can see from image, i need to clear button from other module only.
\

Use events to detect module and hide/show button
editor.on("moduleChanged", function(name) {
  if(name === "other") {
  // Hide button clear
  } else {
  // Show button now
  }
});


Disabling dates by weekday?

Hi,
Is it somehow possible to disable certain days of the week? For example disabling all weekends?
Thanks for any suggestions.

Apologies, I found the answer immediately after by using decorators. Here is the solution in case anyone runs into the same issue:
mMaterialCalendarView.addDecorator(new DayViewDecorator() {
@Override
public boolean shouldDecorate(CalendarDay day) {
return day.getCalendar().get(Calendar.DAY_OF_WEEK) == Calendar.SUNDAY;
}
        @Override
        public void decorate(DayViewFacade view) {
            view.setDaysDisabled(true);
        }
    });


add pipeline

What type of PR is this?
/kind feature
What this PR does / why we need it:
Use go channel mode pipline to control the whole process

MergeRegoRules are used to aggregate Rego's verification rules.
MergeRegoRulesValidate are used to aggregates Rego's verification methods.
MergeValidationResults are used to aggregates the output results
You can extend rules, validate and results.
Which issue(s) this PR fixes:
Special notes for your reviewer:
@ruiyaoOps
@pixiake
@FeynmanZhou

@all-contributors please add @leonharetd for code


Object.assign is not a function

It is not yet supported pretty much anywhere. babel-plugin-object-assign would fix it

See PR for this one

Yep, you're right. Thank you for your contributions!


Update README.md

pluralized 'fisher' to 'fishers' in first few sections, fixed a couple of typos

just a bit of editing of text


pull request for e2e test at 12/21/2016 18:56:21

:white_check_mark: Validation status: passed
For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Release 1.18.4

Fixed

Fixed custom sun angle being rounded to whole integer values when reopening configuration node settings UI.
Fixed width of custom sun angle input field.

Unit test failed, but failure not caused by this pull request. Needs to be further investigated, therefore pull request will be merged.


Export API for programmatically run migrations

Your API for migrations apply is under internal folder. Why not to just give access to developers to apply migrations from code?

Use https://atlasgo.io/integrations/go-sdk


Handle Expired Sessions Gracefully

In 7f21ffb a 404 header was set to fix #131 and more properly handle expired links. When I load an invalid or expired link I see the following JavaScript error:
SyntaxError: "JSON.parse: unexpected character at line 1 column 1 of the JSON data"
    onreadystatechange https://example.com/main.js:271

This is due to the response not being JSON encoded. But if the string is encoded then the service tries to load the link.

Checking for 404 would honestly be a better way to check for expired links rather than a JSON syntax error, I agree. Will look into this.

I've had a lot on my plate and this took way longer than I expected. I'm back now, fix implemented, will be live in next update.


[add-resource] Plugin Tingle-Form

Please consider my new plugin tingle-form.
It takes html content generated by the Form plugin and wraps it inside a Tingle popup.
Works with normal and modal pages.
Details at https://github.com/finanalyst/grav-plugin-tingle-form

Added to GPM.