Child makes DNS request for stale objects

After #1756 we expect that a Child will not make a DNS request for its origin unless it doesn't match parent selection. In 7.1, when a stale object is requested from a child, it will still make a DNS request for the origin, despite a successful matching parent selection.
Can reproduce by:

create remap, parent configs with an origin that doesn't have a DNS entry.
PUSH an object matching that remap to a child and parent.

For the child have it expire quickly. For the parent, have it expire "a long time from now"

A fetch from child before expires should succeed with a 200 status code.
Once the child's expiry time has passed, fetch again from the child.  The status code will be
HTTP/1.1 502 Cannot find server. with no parent in the Via: header.

The expected behavior would be that the child would match the parent selection, and thus does not perform the DNS lookup. As a result the parent would appear in the Via: and it would serve the 200, with the child re-freshing its stale object.

still a thing.

fixed by #8484


How can I build the Kong rpm?

How can I build the Kong rpm?

rpm's are available from bintray per our installation page https://konghq.com/install/
The rpm's are built via the make release task which utilizes https://github.com/Kong/kong-build-tools

Closing this one since the question was answered. For support-type questions like this, we recommend starting a conversation in Kong Nation instead!


v0.4.4 release

[ ] make book point to the latest release
[ ] ???

Agree on how to fix the MaybeUninit UB

Is the mem::uninitialized deprecation warning going to be fixed too? It's kind of difficult to work around right now.

It was now decided and a fix is being merged :)

See #289


Adjust offset based pagination to be exclusive of reference position

The Relay spec expects scrolling to be exclusive of the referenced position. However, offset based scrolling is inclusive of the reference position and also always scrolls forward.
For forward scrolling we need make an adjustment to advance by 1. We have not been doing that from the beginning, and have been returning items from (and including) the reference position.
For backward scrolling we need to advance back by the count and switch to forward. We had been doing that until 1.2.4 when a change was made based on the report in #840 to advance by 1 extra, which is in fact incorrect. We'll need to go back and investigate #840 again once more, but the adjustment needs to be made to correct the behavior.

There is now a 1.2.5-SNASPHOT with the changes in https://repo.spring.io/snapshot.


fixed a bug in create collection in cluster, where transaction result…

… was not checked for success before access

LGTM


Don't try to use ucontext_t on aarch64 with glibc version < 2.20

A study of the glibc source, version by version, shows that there
isn't a aarch64 specific sys/ucontext.h before version 2.20.

This is alternative to #4307 to resolved the issue shown in https://mta.openssl.org/pipermail/openssl-commits/2017-August/016192.html

Wow, that's much harder to understand then the original PR.

Really?  How can I help making it easier?

-1  Wrong fix.

If no-threads is enabled than the posix header files should not be included, and structures which reference context should not be declare/defined.

Have you tried no-threads in current master?

And perhaps you should look one more time at async_posix.h, just a little higher up...  more specifically at this guard:
#if (defined(OPENSSL_SYS_UNIX) || defined(OPENSSL_SYS_CYGWIN)) \
    && defined(OPENSSL_THREADS) && !defined(OPENSSL_NO_ASYNC) \
    && !defined(__ANDROID__) && !defined(__OpenBSD__)

Note defined(OPENSSL_THREADS)

@kaduk, approval noted...  I'm going to wait a bit and see if someone with good knowledge of that platform has anything extra to say (@dot-asm, I think that would be you ;-) )...

I just built no-threads; I don't understand your implied question.

@levitte, you can't go ahead; I wrote -1 and put a hold (which you cleared, not sure why).

So what happened when you build it no-threads?  I did, and it went through smoothly.
I asked if you tried build master without this change with no-threads.  This change shouldn't make a difference, <pthreads.h> was included before as well...

... and like I said, there's a guard making sure that <pthread.h> is only included if OPENSSL_THREADS is defined...  so I figured your complaint didn't hold, that's why I removed the "hold" label

But ok, noted that -1 wasn't retracted.  But please give me some data to support what you say.

I built on master and it worked, yeah.  I still don't understand your point.  I am keeping my -1 because we have an OPENSSL_NO_ASYNC guard and I believe the proper thing is to use that.  Which may mean that arrch64 config needs to be changed.  That's okay, at least it is more clear.
The ifdef mess (technical term :) that you added is amazingly fragile and we'll never be able to get rid of it because how we will know then AARCH64 cross-compile around the world has finally updated?  We never will.  So that code will live forever.  If instead we use the config option, then it is explicit as to what's going on, and our code doesn't have to have uncommon cross-compile environment guards in it.

Since this is apparently contentious, I will note that the grounds for my +1 are as follows
We are querying support for a specific version of POSIX and only including the POSIX header pthread.h if a sufficiently functional version for our needs is supposed to be available.  However, there is a bug on a specific architecture+platform where that platform claims to provide the version of POSIX we need and then fails to do so, which we must work around.  This change is a narrowly targeted workaround that does not introduce a regression in any other supported configuration.
The "supported configuration" hedging is an attempt to respond to any questions about "won't we break something by silently skipping the #include?", and in fact any system+configuration that would be affected is currently broken anyway, by the build failure we are attempting to resolve.  But perhaps this is delving too far into Andy's line of reasoning about supported configurations being precisely the ones which actually work.
(There is also an unrelated whitespace fix which could be separated out, of course.)

I think you didn't get a chance to read my comment; we were posting at the same time.  I believe I addressed the issues you raised.

Ok, @richsalz, I have no idea if your remark about no-threads meant that building this PR with that config breaks for you, or if you just a knee-jerk reaction because I indented include <pthread.h> by one space.
Now you're saying something else, that if we encounter issues regarding the async stuff with a build, we should recommend no-async, and that we should change the linux-aarch64 build on Jenkins accordingly.  Do I read that correctly?

So we're both confused :)   You asked if I built no-threads and I said yes.  Shrug, whatever.  They key point is that the right fix, IMO, is to use no-async.  Yes.  This PR adds a nest of ifdef's that we will never be able to remove.

I have glibc 2.19 in my aarch64 scratchbox and never had problems...

Then perhaps you can explain the build failure in the link I posted above?

Note: we're missing a data point; what glibc version was used in the failing Jenkins build?

Right question probably is if it's actually OpenSSL problem. Give it broken headers and you will get result like that. Or [probably more likely] miss the header, so that cross-compiler picks one from host[!] /usr/include, and you get result like that. This really sounds like they didn't do proper home work...

I have glibc 2.19 in my aarch64 scratchbox and never had problems...

As it turned out I have even older scratchbox with glibc 2.17 littering my hard disk ... yet no problem there either. On related note even if we link with glibc 2.23, ELF version reference to libc.so.6 is GLIBC_2.17. There are GLIBC_2.23 symbols in library, but we don't link with any of them. Which speaks in favour of suggestion that it's not OpenSSL problem we are looking at even more strongly.

BTW, it fails to compile async_null.c[!] complaining about missing ucontext_t[!]. Relevant[?] question is what business does async_null.c have ending up including any implementation-specific headers? Does it mean that even no-async build will fail?

BTW, it fails to compile async_null.c[!] complaining about missing ucontext_t[!]. Relevant[?] question is what business does async_null.c have ending up including any implementation-specific headers? Does it mean that even no-async build will fail?

The whole async stuff auto-detects capabilities by having each separate implementation include ../async_locl.h, which in turn includes all the architecture specific headers, which in turn detect if they should or shouldn't declare their thing.  So what happens is that crypto/async/arch/async_posix.h detects that it is indeed in a posix environment, and this is confirmed since it can include <ucontext.h>, but fails later because said <ucontext.h> failed to defined ucontext_t.
(from what I've read, there was a time when ucontext_t didn't exist and you would use struct ucontext to get to the same structure...  if I understand correctly, that's what the Jenkins build is hitting, i.e. something a bit too old)
However, no-async means that crypto/async isn't even considered for building, just like we do with algos, say crypto/md4.

The whole async stuff auto-detects capabilities...

Of course I understand that. Question is if it would be more appropriate if it was arranged so that async_null.c didn't do anything of the kind. But never mind...

if I understand correctly, that's what the Jenkins build is hitting, i.e. something a bit too old

And I can't confirm it. I have no problems building with glibc 2.17, which is older than alleged non-problematic version. Also note that it's complaining about setcontext being undeclared. Does it mean that there is possibility that we are looking at some kind of diet libc? Either way, I still argue that it should be their problem, either build system needs to be fixed, no-async used, or sensible solution provided by them...

Of course I understand that. Question is if it would be more appropriate if it was arranged so that async_null.c didn't do anything of the kind. But never mind...

Then we need to place detection elsewhere, since null is also autodetected.

Either way, I still argue that it should be their problem, either build system needs to be fixed, no-async used, or sensible solution provided by them...

I agree with you

So, final judgment, I'm dropping this. Let's get back to the Jenkins dudes and help them figure out what needs adding in their environment.

(it's possible that we should document what's needed in a posix  environment)


Add get tracks method to DefaultQueue

Although we can extend the DefaultQueue class we can also access tracks property on the DefaultQueue class by default so there is no sense it not being reachable x)

The tracks array is already public (https://github.com/davidffa/Vulkava/commit/e2b7097383ad3f03c71529705db732229573c676), you don't need the getter.

I was on an older version of vulkava '^^


Hardened Steel Glasses do not have access to findNearestItem function

Most likely related to  https://github.com/codecombat/codecombat/issues/2456.  This is mostly bothersome to me because a lot of the pregenerated code on levels uses this function and thus throws an error when I try to run it.

I'm not familiar with those glasses, but I had the same problem with the best glasses in the game.
I can use var items = hero.findItems();     var item = hero.findNearest(items); to get around that.
While I'm a fan of having better items make worse items irrelevant (so you can hide/sell them), I bought the glasses that let you see through walls very early on and had to figure out a way to deal with the lack of support for these glasses in many many levels. -- I saved a lot of crystals not buying any of the glasses in between, that was the price I paid for that.
Not sure if the stone glasses allow for this work around as well, but if you care for the convenience of using nearest item -- and more importantly nearest enemy (yes that one will go away too!) -- check which of the cheaper glasses still allow you to do that.

I just added findNearestEnemy and findNearestItem to all the higher-level glasses that just had the array-based methods.


feat(starknet_integration_tests): end to end integration test running as executable (not test)

This change is


Add steps to get flow ID for solution-aware flows

Category

[X] Content fix
[ ] New article

What's in this Pull Request?
Added steps for makers to grab the ID of solution-aware flows so that these types of instant flows can also be run from a column-formatted button in lists.

@andrewconnell this doc change will help address an urgent customer ask. If reviewing and merging this could be prioritized, I'd appreciate it. Thanks!

Please see the edits I made for future doc updates @Steven-Jia ... thanks!

Docs Build status updates of commit 49be9e1:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/declarative-customization/formatting-advanced.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

@andrewconnell thank you!


Added log collection support for vanilla Kubeadm clusters

This PR addresses issue/request #209
New functions created:
    kubeadm-k8s
    kubeadm-certs
    kubeadm-etcd

the switch -r now also includes kubeadm as a selector from the list

thanks @leodotcloud for reviewing and for the good suggestions.
My attempt was to reuse parts of the already existent rancher code and not altering things much by keeping the same style/structure.
This PR it's just an attempt to introduce a "fallback" collection that should be sufficient for the most common scenario described in the k8s docs (kubeadm and kubectl binary location, etcd dirs and so on...).
No doubt it can be improved with the help of the wider community to support more environments and i would be willing to help by sending future PRs.
However, may i suggest to accept the code as it is for the time being so at least a log collection from kubeadm is in place? i have tested from a couple of brand new test installs i have and it works.
This PR leaves rancher collection untouched and everything will continue to work as expected.
Perhaps can we create a new issue using your points as a basis for an improvement, hence a new PR?

I appreciate your PR and am glad you could reuse some parts, but the existing code makes some assumptions and those are not applicable to your changes.

may i suggest to accept the code as it is for the time being

That's not how code reviews work anywhere :)
Anyways, I quickly made the changes that I suggested.

Anyways, I quickly made the changes that I suggested.

Thanks appreciated :)

may i suggest to accept the code as it is for the time being

That's not how code reviews work anywhere :)

I welcome your criticism but have you actually tested your modification ? :)
I have tried to fetch it and run it from my kubeadm env, looks like the automatic detection is not working.
wget https://raw.githubusercontent.com/rancherlabs/support-tools/master/collection/rancher/v2.x/logs-collector/rancher2_logs_collector.sh

sudo ./rancher2_logs_collector.sh
2023-02-01 15:30:33: Created ./tmp.jchaD0DGbD
2023-02-01 15:30:33: Detecting available commands... renice ionoice
2023-02-01 15:30:33: Detecting OS... opensuse-leap 15.4
2023-02-01 15:30:33: Detecting k8s distribution...
2023-02-01 15:30:33: couldn't detect k8s distro

It's missing this part in the sherlock function from my original PR:
      if $(command -v kubeadm >/dev/null 2>&1)
        then
          if $(kubeadm version >/dev/null 2>&1)
            then
              DISTRO=kubeadm
              echo "kubeadm"
            else
              FOUND+="kubeadm"
          fi
      fi

I am more than happy to send a new PR to fix this

Yes, I removed that piece of logic.
You have to invoke the script with -r kubeadm

2. I removed that piece of logic. We don't want any unintended side effects as the new code has not been tested thoroughly by our team.

An automatic detection would be more appropriate for my case because the idea was to embed this script into other projects where we have mixed environments, Rancher and Kubeadm.
This is what led me to create this PR in the first place.


fix(storage-resize-images) relax bucket naming rules

Handles #27 & allows for #18
Currently the rules assume the bucket name is always x.x.x, whereas it can actually be anything with letters, numbers, dashes, dots, underscores.
This only checks for characters, it doesn't validate the storage bucket actually exists.

@laurenzlong (or someone she delegates) should be the reviewer on this change.  Thx!


EntrySpan and ExitSpan didn't override all major methods of AbstractingTracingSpan

These following methods:

setOperationName
setOperationId

(Updated) log shouldn't be override.

Fixed.


kafkaJsprotocolERROR on Kafka consumer

Hello All
We are running into kafkaJsprotocolERROR errors and the Consumers are not attached to the partitions once this error is observed on the pods.
We are seeing these errors even though the Kafka servers/brokers are healthy and no issue identified on them.
Note: Observed below errors when there is a sudden spike in traffic numbers.
{"level":"ERROR","timestamp":"2020-09-14T18:01:34.571Z","logger":"kafkajs","message":"[Consumer] Crash: : The coordinator is not aware of this member","groupId":"capture" KafkaJSProtocolError","stack":"KafkaJSProtocolError: The coordinator is not aware of this member\n at createErrorFromCode (/app/node_modules/kafkajs/src/protocol/error.js:537:10)\n at Object.parse (/app/node_modules/kafkajs/src/protocol/requests/joinGroup/v0/response.js:37:11)\n at Connection.send (/app/node_modules/kafkajs/src/network/connection.js:311:35)\n at processTicksAndRejections (internal/process/task_queues.js:97:5)\n at Broker.joinGroup (/app/node_modules/kafkajs/src/broker/index.js:351:12)\n at ConsumerGroup.join (/app/node_modules/kafkajs/src/consumer/consumerGroup.js:93:23)\n at /app/node_modules/kafkajs/src/consumer/runner.js:51:9"}

Can you please share your thoughts on this. This error is giving hard time for us on production.
Thanks
Lakshmi

Hi @LakhsmiC, this is a recoverable error, so it shouldn't bubble up and crash your application. Which version of KafkaJS and Kafka are you using? This error also means that your consumer was marked as dead by Kafka; you probably took too long to process an event without heart beating, making the broker kick the consumer out of the group.

Hello,
Thank you for your prompt response.
The Kafka version is kafka_2.12-2.3.1, Kafkajs client version is "kafkajs": "1.12.0". The heartbeat interval is 4000ms (4seconds).
So, do you think the heartbeat interval is not appropriate and needs to be brought down to a lower value to avoid such issues?

The heartbeat interval value looks ok. KafkaJS doesn't heartbeat in the background, so it heartbeats in between each message, if to process a single message you need more time than the heartbeat interval it is recommended to either increase the value or to switch to each batch and heartbeat while processing the message. The each batch handler gives you access to the heartbeat function.

Thank you so much  for clarifying on that. It helps in analysing the error.  So does it wait for all 300 messages to be committed first and then poll a heartbeat . Or will it poll a heartbeat once each message is consumed .
Note: All the data we consume and process are asynchronous.

No, it tries to heartbeat in between each message if it is necessary. It works differently for eachBatch as you have access to heartbeat, for eachMessage it works like this:
if you have messages: [1, 2, 3]
1
# heartbeat if necessary (now - last heartbeat < interval config)
2
# heartbeat if necessary ...
3
# ...


feat: rotator output file by date

Enhancement
What does this PR do?
支持按日期滚动日志文件
Why is it important?

Checklist

[ ] My code follows the style guidelines of this project
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] I have added an entry in CHANGELOG.md

Author's Checklist

[ ]

Related issues

:grey_exclamation: Build Aborted

The PR is not allowed to run in the CI yet

the below badges are clickable and redirect to their specific view in the CI or DOCS

Expand to view the summary

Build stats

Start Time: 2023-03-02T15:31:33.498+0000

Duration: 2 min 54 sec

Steps errors
Expand to view the steps failures

Load a resource file from a library

Took 0 min 0 sec . View more details here
Description: approval-list/elastic/elastic-agent-libs.yml

Error signal

Took 0 min 0 sec . View more details here
Description: githubApiCall: The REST API call https://api.github.com/orgs/elastic/members/paylm return the message : java.lang.Exception: httpRequest: Failure connecting to the service https://api.github.com/orgs/elastic/members/paylm : httpRequest: Failure connecting to the service https://api.github.com/orgs/elastic/members/paylm : Code: 404Error: {"message":"User does not exist or is not a member of the organization","documentation_url":"https://docs.github.com/rest/reference/orgs#check-organization-membership-for-a-user"}

:robot: GitHub comments
Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

/test : Re-trigger the build.


stack-llama

adds the stack-llama example

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.


Lunr local searcher implemented

With this PR Layer5 Docs shift to the built-in local search by Docsy i.e. Lunr
recording.webm
Signed commits

[x] Yes, I signed my commits.

Thanks @leecalcote

@iArchitSharma looks good. You see on hover over the title of the search results the text is not visible.

Recently, I have added a new shortcut key to the search field.

@leecalcote fixed

@iArchitSharma thank you. Will you implement a clickaway for closing the search panel (clickaway and ESC might be nice, too)


Feature request: nested test case

Hi, I would like to make a feature request to allow for nested test cases, or at least some way to separate tests by namespace (like "context" or "describe" in JS testing frameworks like mocha). My problem is that I'm composing test cases programmatically so as of right now, only 1 level of nesting means I have to bunch a series of asserts into one test case when they can fail independently. These tests are naturally very hierarchical and I have relatively computationally expensive set-up for those series of test cases so I would prefer not to have to rerun the entire set up for each test.
As with Mocha, I would not expect to be able to mutate state defined in an outer test case from an inner test case - I would expect that to fail or to have undefined behavior.
If you believe I can accomplish what I want to do without nesting, then I'd be very appreciative of any suggestions! I will do my best to explain my use case in more detail below.
I'm testing a compiler and I have a set of directories representing a program to test + input state + an expected output. In the MUnit test class, I'm using a Fixture to iterate over the directories and construct a context for each directory. Then in the test itself, I loop over the queries that need to be run, but because nested isn't supported I can't have each query fail independently. However since the context is created in a fixture, I can't move test down a layer because you can't access fixures outside of "test" statements. Further, the compiler itself has various pluggable layers, so I would love a way to nest the tests per layer of the compiler. What I'm doing right now is forcing everything to be at the top level but naming the classes so they are "nested" by in the name, but that ends up with ridiculously long hierarchical test names which doesn't let me take advantage of the nice nesting UI of IntelliJ.
So instead of these lines I would love to be able to write (and nest further, but simplified for this example):
   directories.foreach(testdir => {
      test(testdir) {
        val g = graph()
        g.queries.map((hint, query) => {
          test(hint) { // these can fail independently
            assertTrue(query.solve())
          }
      }

It would be great to be able to have fixtures for each level, but I would be happy even with simply a nested test namespace alone.
Thank you!

for further context, utest's nesting support is described at https://github.com/com-lihaoyi/utest?tab=readme-ov-file#nesting-tests


Remove sizes property from info.json?

serverless-iiif provides both the top-level sizes array and a scaleFactors list within the tileset description. Both of these are calculated starting with the original dimensions of the image and scaling down by half until neither dimension is larger than the tile size.
OpenSeadragon v4.1.0 introduced a bug that results in a corrupted image display (due to some bad internal calculations leading to bad tile requests) when the sizes array is present. Obviously this is OSD’s issue to fix, which they have in HEAD but not yet in a tagged release. But it got me thinking about whether there’s actually any value in providing sizes at all, given that the spec lists it as a “MAY include” and the server offers arbitrary scaling anyway.
At this point, I'm just barely leaning toward removing it, or at least making it configurable with default: false, since I don't think it offers any information that's not available elsewhere. I guess I don't really know what real-world implications there might be either way.

I've been successfully talked out of this by the #technical channel in the IIIF Slack team.


DEV 8927. 2. Admiral should show Architecture field and edit architecture field of SMI from admiral UI.

https://github.com/Shippable/pm/issues/8927

this is done, closing

opening to fix issue where isDefault is being updated for images of same architecture type

this is fixed, closing

this is done


Op status persists after being demoted from group with op permission

A user was promoted to admin group which has permission luckperms.autoop (with vanilla op system disabled). However after demoting the same player to default group (inheriting from only member group), the player is still granted op status (as seen from op chat color from Essentials, and having access to permissions not from the member group). The op status is lost after relogging in.

Yeah - this is a somewhat documented "feature" ;)
I'll see what I can do about changing it, it's a bit of a tricky thing to implement through, and the OP status is stored within the server, and not within LP.
https://github.com/lucko/LuckPerms/blob/7d089cb5f081d3145c880669e84b631b756297cb/bukkit/src/main/resources/config.yml#L471-L473


Skip AST string integration cases on non UTF8

This fixes https://github.com/NVIDIA/spark-rapids/issues/9771.
AST string needs to be UTF8. But in some test cases, locale default is not.

build

The failures seem related to https://github.com/rapidsai/cudf/pull/14402 not being present. A spark-rapids-jni snapshot has not been published since that change went in.

Yes, that's possible. I am doing a test locally to see whether we can produce this issue.

build

JNI already bump up version including commit in https://github.com/NVIDIA/spark-rapids-jni/commit/592e0072b0d704aca241d9bdeb40833e2395398b Verified locally successfully.

build

build


Fix/idam 1522

Description
Changed phone number validation to match the same way notify service validates phone numbers
Moved chs mappings to archive as they where only needed for the alpha for demo purposes and shouldn't make it into live.

FIDC Update Required:

[ ] access config (IDM)
[ ] agents (AM)
[ ] applications (AM)
[ ] auth trees (AM)
[ ] bash scripts
[x] connectors / mappings / scheduled recons (IDM)
[ ] cors (AM/IDM)
[ ] custom endpoints / scheduled scripts or tasks (IDM)
[ ] internal-roles (IDM)
[x] journey scripts (AM)
[ ] managed-objects (IDM)
[ ] managed-users (IDM)
[ ] password-policy (IDM)
[ ] secrets
[ ] services (AM)
[ ] terms and conditions (IDM)
[ ] ui (IDM)
[ ] variables

Does this take into account a leading + sign?

Does this take into account a leading + sign?

Yeah will take that into account. It allows the characters + ( ) -  which are valid characters in phone numbers.


protojson - support custom message marshalling/unmarshalling

There are often times a user of the protojson package may want custom unmarshalling/marshalling of certain message types.
My specific use case of this functionality is to support encoding and decoding of some of the most accepted date types (i.e. https://github.com/googleapis/googleapis/blob/master/google/type/date.proto) into the ISO 8601 format for those types.
I would also like to support flexible decoding to allow multiple Json values to represent the same deserialized data. (i.e. in this example, the date could be specified as an ISO 8601 string or as an object with a "year", "month" and "day" fields).
Currently this is no functionality that allows this.

I have create an initial suggested implementation for this.
https://go-review.googlesource.com/c/protobuf/+/229557
This PR adds a "Marshallers" parameter to MarshalOptions and an "Unmarshallers" parameter to UnmarshalOptions that allows the user to define custom marshalling/unmarshalling functions for specific message types.  I've added a test case to illustrate the use with a custom message type.
Because this relies on the functionality in "internal/encoding/json" package, I have exposed the Kind type and multiple interfaces in the "protojson" package that correspond to the types defined in the internal package.  Since JSON itself is a well defined standard, the Kind(s) are unlikely to change.
This should provide sufficient flexibility in implementations.

The purpose of the protojson package is to encode and decode the canonical protobuf JSON mapping, as described here and elsewhere:
https://developers.google.com/protocol-buffers/docs/proto3#json
The canonical JSON mapping is a portable format that can be consumed by many different protobuf implementations in many different languages. Producing a custom, non-portable encoding is out of scope for the protojson package.

Per our FAQ:

The Go implementation of protocol buffers strives to be consistent with the other language implementations. As such, we tend to shy away from feature that are overly specialized to just Go. Go-specific features hinder the goal of protocol buffers being a language-neutral data interchange format.

As @neild mentioned, this feature would 1) be unique to Go, and 2) goes against protobuf's goal of being a playform neutral way to serialize data. As such, we're unable to accept this feature request.
Some of the well-known types are blessed in the protobuf-to-JSON specification with special output. If you believe that https://github.com/googleapis/googleapis/blob/master/google/type/date.proto is sufficiently common and special that it should receive special treatment, then you should propose to the protobuf team at https://github.com/protocolbuffers/protobuf/issues that it be blessed. Unless it is codified as being treated special, our hands our bound here with regards to what we can do/accept.

I just noticed that you filed an issue at https://github.com/protocolbuffers/protobuf/issues/7411. I'm going to close this issue here 1) since we won't be adding a general purpose way to over-ride JSON serialization and output something different than what is specified, and 2) if the protobuf team accepts the propose changes, we will implement it. If they do not, then we cannot.

I appreciate the time you spent on responding to me (even if it didn't result in my preferred outcome).  I should have started in the with a WKT proposal originally since that was my primary use case.
If you feel obliged, I would also appreciate your opinion on my proposal in:
https://github.com/protocolbuffers/protobuf/issues/7411


Create a VIP request using pools that already exist

When creating a VIP request, we need to have the option to use existing pools instead of specifing the servers:ports and create new pool entries in the DB/API.
Today, deleting the VIP request deletes every server pool associated with it. API calls should have the option to remove the VIP request AND the server pool or to remove ONLY the VIP request, without removing the server pool from the LB and from the API database. The default option should be to delete everything, as this is the most used functionality.

Available in 2.4.0


One more way to format a route type with vite-plugin-kit-routes

Is your feature request related to a problem? Please describe.
I just like concise code whenever possible. And currently, when I have these routes:
const PAGES = {
	"/blog": `/blog`,
	"/blog/[id=integer]": (params: {
		id: Parameters<typeof import("../params/integer.ts").match>[0]
	}) => {
		return `/blog/${params.id}`
	},
}

Then I'd need to use it like this in my svelte component:

Go to post 1

Describe the solution you'd like
Before I found this vite plugin I was working on my own version for this, and I generated my routes firstly as a type and then an object that would work like that type. Which allowed me to generate a route with the type /blog/${number}. So instead of needing to write:
Go to post 1

I only needed to write:
Go to post 1

And it would get correctly type-checked.

This is working with numbers, but I think that it will not work with string as "everything" will be valid.
So I'm not sure what to suggest.
Did you try format_short that could be a good compromise ?

Any update ?


Unable to update CodeSystem resource after updating to 3.6

We just updated to version 3.6.0 and after the update we are getting error messages when we try to update some of our CodeSystems. Here is a simple example.
We have following ValueSet http://hapi.fhir.org/baseDstu3/ValueSet/928619?_pretty=true which contains codes 1 and 2
We have following CodeSystem http://hapi.fhir.org/baseDstu3/CodeSystem/928650?_pretty=true which contains the same codes as ValueSet does.
We are getting error "HTTP 422 Undefined" when we try to create the CodeSystem resource
HTTP 422 Undefined
{
"resourceType": "OperationOutcome",
"issue": [
{
"severity": "error",
"code": "processing",
"diagnostics": "CodeSystem http://phr.kanta.fi/CodeSystem/testcodesystem has a 'all system' value set of http://phr.kanta.fi/CodeSystem/testvalueset, but the include has extra details",
"location": [
"CodeSystem"
]     }   ] }
Operation is successfull if we remove ValueSet field from the resource.

I know that ValueSets have not been working since HAPI 3.3.0. I have no idea what the priority is to get them working in future versions.


SqlRs: [#1258] Fix for Reporting Services initialization

A fix for Reporting Services initialization on SQL Standard and lower editions

Pull Request (PR) description
An explicit call to InitializeReportServer CIM method is not needed when initialising Reporting Services, since the call to SetDatabaseConnection CIM method initialises it.
An explicit call to InitializeReportServer after SetDatabaseConnection on SQL Standard and lower editions fails since SSRS attempts to configure scale-out deployment, which is not supported on SQL Standard and lower editions.

This Pull Request (PR) fixes the following issues

Fixes #1258

Task list

[x] Added an entry under the Unreleased section of the change log in the CHANGELOG.md.
Entry should say what was changed, and how that affects users (if applicable).
[ ] Resource documentation added/updated in README.md.
[ ] Resource parameter descriptions added/updated in README.md, schema.mof
and comment-based help.
[ ] Comment-based help added/updated.
[ ] Localization strings added/updated in all localization files as appropriate.
[ ] Examples appropriately added/updated.
[x] Unit tests added/updated. See DSC Resource Testing Guidelines.
[ ] Integration tests added/updated (where possible). See DSC Resource Testing Guidelines.
[ ] New/changed code adheres to DSC Resource Style Guidelines and Best Practices.

This change is

Codecov Report

Merging #1335 into dev will decrease coverage by <1%.
The diff coverage is n/a.

@@         Coverage Diff          @@
##            dev   #1335   +/-   ##
====================================
- Coverage    98%     98%   -1%
====================================
  Files        36      36
  Lines      4889    4883    -6
====================================
- Hits       4817    4811    -6
  Misses       72      72

@johlju I'm away next week, we'll sort out any outstanding issues the week after.

@bozho, do you have a reference for this?
I believe it's only initialized for 3 scenarios and it's only to create an asymmetric key

When database is first created (service starts for first time)
Node is added to scale out
When keys are recreated

Do you know if that's correct?

@kungfu71186 I have no reference, but your scenarios make sense. However, I don't think the resource currently supports either scaling out or recreating keys (if it did, we'd have to conditionally execute InitializeReportServer for scenarios 2 and 3)

@bozho correct. I'm currently rewriting the entire resource, but was able to find what I needed. Definitely no small task :/


Add Azure

[ ] I followed the contributing guidelines: https://github.com/github/explore/blob/master/CONTRIBUTING.md

I am:

[ ] Suggesting edits to an existing Topic page
[x] Curating a new Topic page

EDITING AN EXISTING TOPIC PAGE*
I'm suggesting these edits to an existing topic:

[ ] Image (and my file is *.png, square, dimensions 288x288)
[ ] Content (and my changes are in index.md)

Please explain why these changes are necessary:
CURATING A NEW TOPIC PAGE

[x] I've formatted my changes as a new folder directory, named for the topic as it appears in the URL on GitHub (e.g. https://github.com/topics/[NAME])
[x] My folder contains a *.png image (if applicable) and index.md
[x] All required fields in my index.md conform to the Style Guide and API docs: https://github.com/github/explore/tree/master/docs

Please explain why you think this Topic page should be curated:
Listed on todo list.
Please note: we will close your PR without comment if you do not check the boxes above and provide ALL requested information.

Thanks again, again, again @alexleventer!


Layout design fixes for Issue 157

Description
Text truncating in labels at NoTransactionsPlaceholderView.
Various text aligment in labels at ChartWalletSlideView.
Related Issue
#157
Screenshots (if appropriate):

Awesome! 👍


Lucky Hit Chance misspelled

on lucky hit chance affix spelled "lucky hit change" which breaks it.

Thanks will change the filename in the next version. But should still work for the time being. It's not the filename that matters but the image.

Fixed in the latest 2560x1440_SMF_en preset.


NSG association does not work: avm/res/network/virtual-network

Check for previous/existing GitHub issues

[X] I have checked for previous/existing GitHub issues

Issue Type?
Bug
Module Name
avm/res/network/virtual-network
(Optional) Module Version
No response
Description
NSG Association to the subnet does not work while using the module. However, it does work if resources are called directly.
I am not sure but i think the piece around NSG is not right in the code:
networkSecurityGroup: contains(subnet, 'networkSecurityGroupResourceId') && !empty(subnet.networkSecurityGroupResourceId)
            ? {
                id: subnet.networkSecurityGroupResourceId
              }
            : null

I might be wrong but it should be:
networkSecurityGroup: contains(subnet, 'networkSecurityGroupResourceId') && empty(subnet.networkSecurityGroupResourceId)
            ? {
                id: subnet.networkSecurityGroupResourceId
              }
            : null

I have deployed multiple times using the module, but its not successful.
(Optional) Correlation Id
No response

Created wrongly.


Materialize isn't compatible with jQuery.nicescroll.

Expected Behavior
I applied jQuery.nicesroll, using this framework and nothing got effect.
Current Behavior
It seems that jQuery.nicescroll has conflict with materialize.js.
Possible Solution
Turn compatible with jQuery.nicescroll.
Steps to Reproduce (for bugs)

You use only the jQuery.nicescroll
Apply the Javascript codes to initialise the nicescroll, using both html or body:

<script type="text/javascript">
$(function() {
    $("body").niceScroll();
});
</script>

The browser scrollbar disappeared and dint get effect.

Also read the issue I open with jQuery.nicescroll's Github: https://github.com/inuyaksa/jquery.nicescroll/issues/682
Your Environment

Version used: 0.99
Browser Name and version: Safari 10.0 and Chrome 59.0.3071.115
Operating System and version (desktop or mobile): macOS Sierra 10.12
Link to your project (if appropriate): https://codepen.io/gusbemacbe/pen/QgXzdR

Not reproducible with the right JavaScript file.
https://codepen.io/anon/pen/YQoBKR
There were warnings in the console.

But in my browser, Chrome said that there was no errors. Strange!

I compared my pen and yours, but they are the same. How did you figure?

https://codepen.io/Dogfalo/pen/awgXdY

https://codepen.io/Dogfalo/pen/awgXdY

That's generally what I posted ;-)

@DanielRuf , but this problem is still unsolved. Not just html, try to apply to body and to side-nav (if you have many items), you will see nothings works. It is absolutely incompatible.

@gusbemacbe it definitely work in Chrome 59 (on Windows 10).
Will try it on macOS in a few hours and in Safari.

@DanielRuf, anther issue that gives reason to the incompatibility between jQuery.nicescroll and Materialize, for example.
Bootstrap has Javascript events, but does Materialize have events?
So see the codes, for example:
    $("#scrollcustom").on("shown.bs.dropdown",function(e){
      nicelist.show().resize();
    });

    $("#scrollcustom").on("hide.bs.dropdown",function(e){
      nicelist.hide();
    });

According to Materialize documentation - http://materializecss.com/side-nav.html:
Try to apply show and hide and nothing worked. Try to apply click and data-activates and nothing works. Also apply .button-collapse and .side-nav, #nav-mobile and #slide-out and nothing works.
It is an issue of compatibility and not an issue of bug. I think the solution only is that Materialize add a compatibility support for jQuery.nicescroll or jquery.nicescrol add a support for Materialize.

No, internally Materialize triggers and uses some custom events. But please do not mix multiple issues in this one.
Let's see if I can reproduce that or not.

OK, @DanielRuf!

You can get my quick pen and analyse the nicescroll problem applied to side-navbar, @DanielRuf:
https://codepen.io/gusbemacbe/pen/QgeWjO

Works in Chrome and Safari on macOS. Not reproducible. The custom scrollbar is shown and works.

The sidenav is another issue.

Do I have to create a new issue about side-nav with nicescroll?

Sorry, I think your code contain many errors.
I made some fixes, now nicescroll showed  with sidebar.
There is a problem with greyed layout, but it's a page layout mistake or materialize issue .
https://codepen.io/anon/pen/Qgebrd?editors=0000


STM32F072 TIM15 PWM not working (MOE bit)

The following code should enable the PWM output on pin PA2:
    let output_green = PwmPin::new_ch1(p.PA2, OutputType::PushPull);
    let mut pwm_green = SimplePwm::new(
        p.TIM15,
        Some(output_green),
        None,
        None,
        None,
        khz(1),
        Default::default(),
    );
    pwm_green.enable(Channel::Ch1);
    pwm_green.set_duty(Channel::Ch1, 10);

However, the pin stays in high impedance mode. Looking around I found other people having the same issue and the suggested fix was setting the "master output enable" (MOE) bit in the BDTR register. The following code makes the PWM output work properly on my hardware:
    const TIM15A: embassy_stm32::pac::timer::TimAdv =
        unsafe { embassy_stm32::pac::timer::TimAdv::from_ptr(0x4001_4000 as usize as _) };
    TIM15A.bdtr().modify(|r| r.set_moe(true))

TIM15 is declared here as TimGp16, which does not have the BDTR register. I'm not sure, however, if is correctly described by TimAdv. Also, other chips are probably affected by this issue as well.
Cheers!

Same issue here with STM32F030C8 TIM16 and TIM17. Setting MOE bit works.

This is also the case for TIM15, TIM16 and TIM17 for STM32F030x4/x6/x8/xC and STM32F070x6/xB. I would love to help here but am relatively new to this ecosystem. I guess we need some timer type between general and advanced timers?

I have a similar problem in my project, that the PWM does not output any signal after updating Embassy.
There used to be a this.inner.enable_outputs(); in SimplePwm::new_inner(), which got removed by PR #2499.
https://github.com/embassy-rs/embassy/pull/2499/files#diff-34e412deccc6f88af9fce995f7c4ef7fc8ce6502ea2df991b562ab205be4a93eL87
Just inserting it again, does not work, because it was also moved to trait GeneralPurpose1ChannelComplementaryInstance, which is not used by SimplePwm.
https://github.com/embassy-rs/embassy/pull/2499/files#diff-d61a69bd589d81e3a1aea8bcddd14f22ce2dcba46d2edbf7fc0adb4722f5e4d0R437-R439
My current approach is to move enable_outputs() back to trait CaptureCompare16bitInstance which is a noop for most of the timers and use it in SimplePwm.
https://github.com/embassy-rs/embassy/compare/main...jr-oss:embassy:fix_regression_simple_pwm_output_enable
But I haven't understood the timer hierarchy introduced by PR #2499 to be sure, that this is the right solution.
Any feedback is appreciated.
BTW: The output enable seems to be fragile, as I already provided a similar fix in PR #2053

My changes have been merged to main (PR #2670).
Does this solve also your problem?

This should now be fixed for all timers/chips after the last timer refactor and fixes in the above linked PRs.
If you find a timer that doesn't work due to this please open a new issue.


fix(#421): avoid using internal function in RepeatComponent.

What kind of change does this PR introduce? Bug fix

This change is

Codecov Report

Merging #422 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #422   +/-   ##
=======================================
  Coverage   92.35%   92.35%
=======================================
  Files          15       15
  Lines         759      759
  Branches      198      198
=======================================
  Hits          701      701
  Misses         58       58

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bde0487...67d302f. Read the comment docs.


How to make the mask?

The mask that each pixel has value 0 or 1 , how to make such mask

Make a black-white mask
divide by 255

photoshop

Hi, This is a mask I made. The background is 0, the object is 1. It looks the same as the sample mask, but it doesn't work when I tried to use it.. any ideas why this didn't work?

Can you show me the error message or results?

Above are the src and target images. Mask is in previous comment. The result image I got is

The src cones didn't seem to be blended into the target image

Can you visualize the mask with black and white ?

above is label * 255

"above is label * 255"   the label here is the one uploaded in the previous reply

Hi, This is a mask I made. The background is 0, the object is 1. It looks the same as the sample mask, but it doesn't work when I tried to use it.. any ideas why this didn't work? The code i used to convert mask is
 image = cv2.imread('images/cone17.jpg') label = cv2.imread('labels/cone17 - safety_cones.png') mask = np.zeros(image.shape, dtype=np.uint8) idx = np.nonzero(label) mask[idx[0], idx[1], idx[2]] = 1

Do you mean this label?

image = cv2.imread('images/cone17.jpg') mask = cv2.imread('labels/cone17 - safety_cones.png')

This is the result we got.. we tried changing the opacity, but still got similar results..
anyway it worked. Thanks!

You can convert it to [0, 1] format and then try top adjust color weight.

Any chance you could write a read me file for creating masks? Or a standard step to creat customised masks? It seems not very clear what format can be used, what cannot.

masks with 0 and 1


fix(radio-button-group): add name and required props

RadioButton will receive properties from group.
Fixes #1036.
Not the prettiest code, though.

Released in v0.81.0


Group by acf group

AFAIK WP already caches queries and objects, so it should only build the group post once.


App renders blank with  node when switching from React to Preact

I can't seem to figure out why when I switch to Preact compat, my app just renders as an undefined node and does nothing.
I've followed the guide for setting up preact-compat with webpack, but alas I'm met with this every time:

Has anybody experienced this? Using webpack 2, with React 15 previously before switching to Preact 8.2.5 and preact-compat 3.17.0
Thanks

Found it. Sorry to waste the space! you can close this.
for those interested the answer was with the inline transformer babel plugin https://github.com/developit/preact-compat/issues/328


I will add Pre-Loader in all Pages.

I will add Pre-Loader in all Pages. Except main page.
Example:-

@Susmita-Dey @myhacktech Please Assign it to me.


Add support for querying the DECAC settings

Summary of the Pull Request
This PR adds support for querying the color indices set by the DECAC
control, using the existing DECRQSS implementation.
References and Relevant Issues
The initial DECRQSS support was added in PR #11152.
The DECAC functionality was added in PR #13058, but at the time we
didn't know how to format the associated DECRQSS query.
Detailed Description of the Pull Request / Additional comments
For most DECRQSS queries, the setting being requested is identified by
the final characters of its escape sequence. However, for the DECAC
settings, you also need to include a parameter value, to indicate which
color item you're querying.
This meant we needed to extend the DECRQSS parser, so I also took this
opportunity to ensure we correctly parsed any parameter prefix chars. We
don't yet support any setting requiring a prefix, but this makes sure we
don't respond incorrectly if an app does query such a setting.
Validation Steps Performed
Thanks to @al20878, we've been able to test how these queries are parsed
on a real VT525 terminal, and I've manually verified our implementation
matches that behavior.
I've also extended the existing DECRQSS unit test to confirm that we
are responding to the DECAC queries as expected.
PR Checklist

[x] Closes #13091
[x] Tests added/passed
[ ] Documentation updated
[ ] Schema updated (if necessary)

I think the CI test failure is just the flaky feature test timeout.

I love it. Thank you! :)


AudioElement rendering issue with 10.0.30

Is this waveform rendering issue a known bug with wavesurfer 10.0.30?
I have my server generate all the waveforms and feed the JSON data into WaveSurfer, all was working before I upgraded recently to 10.0.30

JSON data if required: http://pastebin.com/VUv2NcR7
Here is my setup:
that.wave.init({
            container: '#waveform',
            //    waveColor: /* that.getRandomColour(), */ "#33EEAA",
            //    progressColor: /* that.getRandomColour(), */ "#FF2266",
            waveColor: /* that.getRandomColour(), */ "#00BFFF",
            progressColor: /* that.getRandomColour(), */ "#FF00FF",
            dragSelection: false,
            backend: 'AudioElement',
            hideScrollbar: true,
            cursorWidth: 2,
            //normalize: true
        });

Works perfectly if I comment out the backend tag..

I think it might have to do with changes from #478. @dpwe can you take a look?

I suggest you should use 1.0.29 while we fix it.

Thanks @katspaugh !

@DCDJ : #478 changed the intermediate format for waveform display from a sequence of nonnegative peak values to a sequence of pairs of nonnegative peaks, nonpositive peaks (i.e., max(block of samples), min(block of samples)).  So the length of these vectors doubled.  The nice part about this is that the displayed waveforms can now be asymmetric and more "realistic".
I don't have a good insight into where these vectors are used, but it sounds like you were generating your  own.  Would you be able to modify the vectors you generate to feed (max,min) pairs instead of max(abs) sequences?

@dpwe Cheers, yes I can do that, I'll give it a go and report back here.

Maybe we should introduce a changelog somewhere to make it easier to upgrade.

@DCDJ Any news?

@thijstriemstra Sorry for lack of activity - haven't had a chance to re-generate the data yet but will get on it now and report back!

This issue should be now resolved as we support both types of pre-generated data (with negative peaks and without).


experiment admin error

Sorry for creating another issue, but I am have problem using this app.
The admin gives following error (this example project included in the package which is running after #140):
Data column(s) for axis #0 cannot be of type string×

The charts work for us in production - I've definitely seen them not render in development before. Can you share the JSON you're seeing in the page when you get the error?

Closing as we've not seen this happen and don't have repro steps.


mkdir: /usr/local/bin: Permission denied

Hello! During initial install using the curl script, the install failed at the step to create directory /usr/local/bin. Here is the last few lines of output from the script before it quit the script:
...
bin not found
creating bin directory...
mkdir: /usr/local/bin: Permission denied
error in creating bin directory

I am trying to install Mac-CLI on a clean install of macOS v10.13.3. I had put in my administrator password at the beginning of the script when it asked. I don't think I'm inputting the password wrong as I have installed Mac-CLI on three clean installs of macOS. To work around this, I do the following, which works, but might not be the best user permissions for the bin directory:
sudo mkdir /usr/local/bin
sudo chown [username]:[group] /usr/local/bin'

Then I rerun the curl version of the install command and everything works.

Hi @mrmattson,
That error never happened to me before. I tried on a clean 10.13.4 MacOS installation but I wasn't able to reproduce the issue.
Please feel free to re-open the Github Issue if the error happens again for you and I will investigate further.
Thanks!

I am having this issue on macOS Monterey 12.5 MacBook Pro 14, 2021, M1 Pro
Would you like Mac CLI to show you the commands that are run on each mac command? (Yes / No)Yes
Please enter your favourite text editor (by entering the command that opens your favourite editor. i.e: nano):
Press enter without any value to keep default: vi
sh: line 20: [: subl: binary operator expected
vim
cp: /usr/local/bin/mac: Permission denied
cp: /usr/local/bin/mac-cli: Permission denied
cp: /Users/michaelpporter/mac-cli/mac-cli/: unable to copy extended attributes to /usr/local/bin/mac-cli: Permission denied
cp: /usr/local/bin/mac-cli/misc: No such file or directory
cp: /Users/michaelpporter/mac-cli/mac-cli//misc: unable to copy extended attributes to /usr/local/bin/mac-cli/misc: No such file or directory
cp: /usr/local/bin/mac-cli/misc/help: No such file or directory
cp: /usr/local/bin/mac-cli/tools: No such file or directory
cp: /Users/michaelpporter/mac-cli/mac-cli//tools: unable to copy extended attributes to /usr/local/bin/mac-cli/tools: No such file or directory
cp: /usr/local/bin/mac-cli/tools/install: No such file or directory
cp: /usr/local/bin/mac-cli/tools/update: No such file or directory
cp: /usr/local/bin/mac-cli/tools/uninstall: No such file or directory
cp: /usr/local/bin/mac-cli/plugins: No such file or directory
cp: /Users/michaelpporter/mac-cli/mac-cli//plugins: unable to copy extended attributes to /usr/local/bin/mac-cli/plugins: No such file or directory
cp: /usr/local/bin/mac-cli/plugins/general: No such file or directory
cp: /usr/local/bin/mac-cli/plugins/network: No such file or directory
cp: /usr/local/bin/mac-cli/plugins/brew: No such file or directory
cp: /usr/local/bin/mac-cli/plugins/search: No such file or directory
cp: /usr/local/bin/mac-cli/plugins/ssh: No such file or directory
cp: /usr/local/bin/mac-cli/plugins/performance: No such file or directory
cp: /usr/local/bin/mac-cli/plugins/volume: No such file or directory
cp: /usr/local/bin/mac-cli/plugins/git: No such file or directory
cp: /usr/local/bin/mac-cli/completion: No such file or directory
cp: /Users/michaelpporter/mac-cli/mac-cli//completion: unable to copy extended attributes to /usr/local/bin/mac-cli/completion: No such file or directory
cp: /usr/local/bin/mac-cli/completion/fish_completion: No such file or directory
cp: /usr/local/bin/mac-cli/completion/bash_completion: No such file or directory
chmod: /usr/local/bin/mac-cli/*: No such file or directory


Fix Scala Native for testing libraries

Add missing test-runner in Scala Native tools

Last PR I did, I broke the Scala Native build for testing libraries.. That's because Scala Native, starting from version 0.3.8, has a separate artifact for running tests, test-runner. Upgrading I didn't add it.
Made also a cleanup in the build.sc file.

Thanks!

Thanks!

Thanks to you for having reviewed this so fast!


Connection String Overriding

Allow connection strings to be overridden in user settings. This will allow developers to support other server configurations without messing around with the config file.

This works with console apps, but we'll need to test it with unit test projects.

Look at HEMA Drill Book for the logic that you need to copy. It's just one more package and a one liner.

Well that didn't work. The unit tests are ignoring launchSettings.json file so we'll have to look for an alternative answer.
In the mean time, all of the connection strings (except NHibernate) have been moved into a single shared file. Now you can just change it in one place rather than everywhere.


nixos/doc: convert "Chapter 56. Troubleshooting" to CommonMark

Motivation for this change

Related GitHub project
Related Discourse post

Things done
Do conversion of four files from DocBook to CommonMark per RFC 72.

nixos/doc/manual/administration/maintenance-mode.xml
nixos/doc/manual/administration/network-problems.xml
nixos/doc/manual/administration/rollback.xml
nixos/doc/manual/administration/store-corruption.xml

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
21.11 Release Notes (or backporting 21.05 Relase notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/happy-docsgiving/10214/29

@ofborg eval
(Sorry, ofborg's certs recently had an issue, meaning that it was unable to
react to PRs. This has been fixed, but all PRs filed in this period will need
ofborg to be manually kicked off.)

Will update all options links (if any) to only use the URI fragment tomorrow.


Improve HOMEBREW_BREW_FILE unset failure case.

[ ] Have you followed the guidelines in our Contributing document?
[ ] Have you checked to ensure there aren't other open Pull Requests for the same change?
[ ] Have you added an explanation of what your changes do and why you'd like us to include them?
[ ] Have you written new tests for your changes? Here's an example.
[ ] Have you successfully run brew tests with your changes locally?

Print a better exception message and handle this in more cases rather than producing confusing errors when it’s unset.
@eirinikos hit this recently and @UniqMartin suggested it.

:+1:


Add assumerole

Adding in the AWS assume role cred plugin authored by @derekwaters found in this AWX PR.

@thedoubl3j It should be possible to rebase now. Check what jobs are green on devel and make sure they stay that way in the PR.

FYI, PEP 257-compliant docstrings are always made of triple double-quotes.

@thedoubl3j plz also add the entry point to the smoke test params @ https://github.com/ansible/awx-plugins/blob/82c8c95/tests/importable_test.py#L27-L73

Rebase this. From now on, all the GHA checks are expected to show up green.

@thedoubl3j this will end up in https://github.com/ansible/awx_plugins.credential.aws_assumerole eventually. That repo doesn't yet have Git history, but it will. Still, it's useful to do an interactive rebase with the commit cleanup here and fix the conflicts. This will help re-graft this branch into the new repo.


Revert "[Tizen] Refactor XWalkLauncher for usage of RESET event."

This reverts commit a32332dcc4aa34590e953d84535992e9b823c95a.
This change has several problems, some of which are evident when
Crosswalk is built in debug mode.

Lack of a base::AtExitManager in the main function.
The dbus::Bus is not properly shut down.
Most importantly, the interaction between the D-Bus thread and the
main thread is incorrect: XWalkLauncher and its dbus::Bus are created
in the main thread, so many D-Bus methods end up being called there
instead of in the IO thread. This causes many issues, including the
crash reported in XWALK-3231.

Reverting this commit causes xwalk-launcher to work again, as otherwise
it would crash almost all the time.
BUG=XWALK-3231

@rakuco
Either way, this needs to be implemented for app-control and app debug mode. If not in xwalk-launcher, then in xwalk after dual process architecture introduction.


Suggestion for adding source code

Dear @DongChen06 ,
Thank you very much for making this comprehensive overview. Also appreciate that you have cited our work on Active Learning.
I noticed that you summarize all papers including a link to Google Scholar and to the journal paper. Yet, some papers have software source code attached (like mine: https://github.com/pieterblok/maskal). Can you also for the papers that have source code add them as a link? Sharing methods/software can help people to easily reproduce the methods/software.
An example of a git repo having codes included: https://github.com/baifanxxx/awesome-active-learning
Thank you again!

Hi Pieter, Thank you so much for your suggestion! We will incorporate the open-sourced codes into this repo soon.


Error in CRLI for clustering

the testing stage
crli_results = crli.predict(dataset_for_testing)
crli_prediction = crli_results["clustering"]
--> [2]crli_results = crli.predict(dataset_for_testing)
--> [426]clustering = self.model.kmeans.fit_predict(clustering_latent)
--> [175]raise ValueError(msg_err)
ValueError: Input X contains NaN.
KMeans does not accept missing values encoded as NaN natively. For supervised learning, you might want to consider sklearn.ensemble.HistGradientBoostingClassifier and Regressor which accept missing values encoded as NaNs natively. Alternatively, it is possible to preprocess the data, for instance by using an imputer transformer in a pipeline or drop samples with missing values.

Hi there 👋,
Thank you so much for your attention to PyPOTS and BrewPOTS! You can follow me on GitHub to receive the latest news of PyPOTS. If you find PyPOTS and BrewPOTS helpful to your work, please star our repositories. Your star is your recognition, which can help more people notice PyPOTS and grow PyPOTS community. It matters and is definitely a kind of contribution to the community.
I have received your message and will respond ASAP. Thank you for your patience! 😃
Best,
Wenjie

I'm closing this issue for now because we cannot reproduce this error. I assume this may be caused by the unstable performance of CRLI.
Reopening this issue is welcome if error reproducing is possible.


Reduce Test Resource Size and Number of Files

The test resources for the ImageJ plugin are to large and need to be reduced. As of right now its okay, but if the repo becomes more complicated and large than it'd be best to reduce it.

This problem can be addressed when needed. Also for testing remote exports are now being utilized which involve full round tests, which is more appropriate for this plugin because the libraries are already being tested at the individual unit level.


The text in previous/next buttons has changed

🐛 Bug Report
Prerequisites

[ X ] I'm using the latest version of Docusaurus.
[ X ] I have tried the npm run clear or yarn clear command.
[ X ] I have tried rm -rf node_modules yarn.lock package-lock.json and re-installing packages.

Description
Hi
We updated the documentation to version 2.0.0-beta.ce0764033 and noticed that the text in the previous/next buttons has changed.
When we used version 2.0.0-beta.1decd6f80, the text from the sidebar_label field was put into the button.
And in version 2.0.0-beta.ce0764033 the text is substituted from the title field.
We use the title field for search engine optimization.
This text is good for search engine robots, but not for buttons previous/next.
https://www.screencast.com/t/Q9bpkEv1n
Your Environment

Public source code: https://github.com/DHTMLX/docs-suite/
Public site URL: https://docs.dhtmlx.com/suita/chart/api/chart_eachseries_method
Docusaurus version used: 2.0.0-beta.ce0764033

Hmm, this is actually the expected behavior. Frontmatter title is used by default for page titles, sidebar labels, and pagination buttons.

When we used version 2.0.0-beta.1decd6f80, the text from the sidebar_label field was put into the button.

And this was bug that we fixed (see https://github.com/facebook/docusaurus/issues/4852).
@slorber maybe we need add ability to specify only meta title from new field in the frontmatter?

Thanks @Labirintami
I think this is not 100% correct, we never used sidebar_label for pagination button.
Instead, we were using the title of your markdown content # eachSeries() for the buttons. But in practice this was not a great choice, because your markdown title may contain markdown syntax (for example, yu could use an inline code block for "# eachSeries()" instead of just a regular string) and this syntax should not appear in the button.
Think of the frontMatter.title as the pure string/text version, and the # xyz title as a MD title.
We can only use the text version of the title in meta title, pagination, sidebar etc, and we should avoid showing markdown syntax in such places.
If you really want a pagination label that is different from the frontMatter.title, I suggest we introduce a pagination_label frontmatter for that purpose.
This has already been discussed here: https://github.com/facebook/docusaurus/issues/4895
Do you think it's a good solution to solve your problem? I think it is because it gives clear expectations on how the doc label should be customized in each place, instead of having one 2 values that control 2+ places with unclear rules

@slorber maybe we need add ability to specify only meta title from new field in the frontmatter?

In my opinion frontMatter.title already has this role of page meta title (and is a good fallback value for the md doc h1), so I'd rather introduce a pagination_label rather than a meta_title

Hi, @slorber!
Thank you for such a comprehensive and positive response!
We discussed your suggestion about pagination_label with the team. We like it.
It's a little intimidating to add pagination_label to 1500 pages of documentation, but I think we can handle it.

Just fyi, the documentation for plugin-content-docs (which comes with the default preset irc) says:

sidebar_label: The text shown in the document sidebar and in the next/previous button for this document. If this field is not present, the document's sidebar_label will default to its title

Reading this, I would have expected sidebar_label being used for the pagination to be a feature instead of a bug. :)

Thanks @hkogge
I guess it makes sense to restore that behavior and make sure sidebar_label is used in priority for the next/previous buttons then, particularly because order/navigation of the docs is created thanks to the sidebars file.
Should we still add pagination_label?

I guess it makes sense to restore that behavior and make sure sidebar_label is used in priority for the next/previous buttons then, particularly because order/navigation of the docs is created thanks to the sidebars file.
Should we still add pagination_label to ensure more flexibility?

Personally, I think it makes perfect sense to use sidebar_label for the next/previous buttons (as documented), for the exact reason you mentioned: the buttons are directly related to the sidebar anyway.
Then it wouldn't be needed to have an additional pagination_label, imo.

Thanks, let's not introduce any new frontmatter then, and do what our own doc says
https://github.com/facebook/docusaurus/pull/4970
please test it using the @canary dist tag

Finally, pagination_label will be added in beta.1 with https://github.com/facebook/docusaurus/pull/4982

Thank you so much!


Revisit the current timer APIs design to make it more intuitive

Problem
Currently, SystemLayer provides an abstraction layer to the System::Timer class. We found this APIs design is pretty confusing and not ergonomic

Error NewTimer(Timer *& aTimerPtr);
The purpose of SystemLayer abstraction is to prevent the upper layer access the low level System::Timer class directly.  But this API allow the upper code get a raw handle of timer object and manipulate this object with  System::Timer class APIs directly.

void StartTimer(uint32_t aMilliseconds, chip::Callback::Callback<> * aCallback);
This API start the platform timer with aCallback, but does not provide the relative API to stop the platform timer.

Error StartTimer(uint32_t aMilliseconds, TimerCompleteFunct aComplete, void * aAppState);
void CancelTimer(TimerCompleteFunct aOnComplete, void * aAppState);

These APIs start and stop the timer with combination of TimerCompleteFunct and AppState, most of morden timer design use timer handle to implement similar functions.
One of benefits of this design is each user of system timer does not need to maintain the timer object, it can just use the completeFunc and AppState(this pointer) to identify the timer.
Proposed Solution
Revisit the current timer APIs design to make it more intuitive

This is done as part of #6449


Garden Linux fails to boot on VMware with with non-paravirtualized storage/SCSI

What happened:
Booting the current Garden Linux on VMware only works with para-virtualized storage, not for fully virtualized storage (i.e. LSI Logic SCSI). The initrd image is missing the modules mptspi, mptscsih and mptspi (only vmw_pvscsi for paravirtualized SCSI is present).
$ ls -al ~/gardenlinux/.build/vmware-dev/20210915/amd64/bullseye/initrd-extracted/lib/modules/5.10.0-8-cloud-amd64/kernel/drivers/scsi

total 2068
-rw-r--r-- 1 glbuild users 106011 Sep 15 13:13 gdth.ko
-rw-r--r-- 1 glbuild users  45075 Sep 15 13:13 hv_storvsc.ko
-rw-r--r-- 1 glbuild users 287707 Sep 15 13:13 ipr.ko
-rw-r--r-- 1 glbuild users 137787 Sep 15 13:13 libiscsi.ko
-rw-r--r-- 1 glbuild users 229867 Sep 15 13:13 scsi_debug.ko
-rw-r--r-- 1 glbuild users 486955 Sep 15 13:13 scsi_mod.ko
-rw-r--r-- 1 glbuild users 133819 Sep 15 13:13 scsi_transport_fc.ko
-rw-r--r-- 1 glbuild users 264219 Sep 15 13:13 scsi_transport_iscsi.ko
-rw-r--r-- 1 glbuild users 128899 Sep 15 13:13 sd_mod.ko
-rw-r--r-- 1 glbuild users  73771 Sep 15 13:13 sg.ko
-rw-r--r-- 1 glbuild users  49811 Sep 15 13:13 sr_mod.ko
-rw-r--r-- 1 glbuild users  40163 Sep 15 13:13 virtio_scsi.ko
-rw-r--r-- 1 glbuild users  49819 Sep 15 13:13 vmw_pvscsi.ko
-rw-r--r-- 1 glbuild users  50051 Sep 15 13:13 xen-scsifront.ko

What you expected to happen:
Garden Linux boots successfully on WMware with fully virtualized SCSI.
How to reproduce it (as minimally and precisely as possible):
Build Garden Linux with make vmware-dev and attempt to import the resulting .vmdk or .ova into VMware Player/Workstation/etc. and boot the VM. It will fail trying to mount the root partition.

It seems that the kernel modules for the LSI SCSI adapters that VMware uses in a fully virtualized environment are not even part of the kernel package.

@gehoern : can you build the next kernel with this module: mptspi. This might trigger mptscsih, mptbase and possibly others. Those are part of the non-cloud Debian kernel.

Kernel needs to be built with CONFIG_FUSION_SPI=m.

Status Update: Looks relevant for our bare metal support for VMWare endeavour. Please correct me if I'm wrong @MrBatschner

Not relevant at the moment


Add support for a vector of account infos

This is currently a draft PR with some work left to clean up the code and get features for signing and mutability working
Closes #69

I need this feature for my project. What is needed to merge this? I see there are some tests failing I could work on that if needed.

I need this feature for my project. I see that there is panic when adding a vec in the ctx due to the constraints at the moment. How can I help? :)

@mccjul that would be great! I was also hoping to add docs or an example

Closing as stale.


Remove failing data checks (no need to check for those specific fields)

This PR addresses issue #
Please Check

[ ] Are the JSON schemas updated?
[ ] Are tests passing?

Closed in favor of #887

Closed in favor of #887


Init cap Exoscale in Machine driver docs side menu

Proposed changes
updated Exoscale entry to initial caps, note this was done on vnext-compose branch (should have been on vnext-machine branch) and in master, but somehow was lost or reverted in follow-on PRs.
Related issue
#450
Please take a look
@mstanleyjones
Signed-off-by: Victoria Bialas<EMAIL_ADDRESS>

Deploy preview processing.
Built with commit 84ab8f8b1c9b1b5bb253bbd3edf591f0891745b3
https://app.netlify.com/sites/docker-docs/deploys/5824fa00c4d9cc1bef8614ba

LGTM, merging


Define milestones for program committee

needs to be coordinated with official timeline as per #3.

Here's what the official timeline currently has in terms of "PC" (Program Committee)

28 Apr		Determine session types, session format	PC
Apr		Keynote speakers selected and added to website	PC
May		Deadline for committee to finalize agenda and session types	PC
Apr		[..] requests for the registration form needed
29 May		Abstract submission open (Sessions, Demo, Posters)

While the April dates need to be moved over to May, these bullets can probably serve as reasonable milestones.

I guess now it's a bit too late to do this, so closing.


Lowering data retention period for CSV uploads

Summary | Résumé
After a team talk, we realized that our data retention for CSV uploads does not match our advertised policy.
This change would not match our policy for provinces and territories set at 3 days but would at least improve the situation for now in a quick manner.
Test instructions | Instructions pour tester la modification

Check the S3 bucket once this comes in effect to see if there are documents still in the bucket that are older than  7 days.

I spoke to @yaelberger-commits this morning and she's fine with us merging in staging environment today. That should provide us the long weekend to see if anything goes wrong with lowered retention data configuration within the S3 bucket. We'll check back on Monday.


Issue Fixes. Batch 02

Features Implemented

Token Based Authentication
Swagger Documentation
Item Endpoints

Coverage increased (+46.6%) to 87.432% when pulling 5b76a21b6716153219fe473d6f2227d3fdc9610c on migrate_to_mac into 0cad6338c5535c667812ac377a64503323d230b1 on development.

Coverage increased (+46.6%) to 87.432% when pulling 6d821148de8556b0f389c9bb9a1f075e8a3cc623 on migrate_to_mac into 0cad6338c5535c667812ac377a64503323d230b1 on development.

Coverage increased (+46.6%) to 87.432% when pulling 248b0e17d87b29f464e06f4811a3eea5d0d2fad6 on migrate_to_mac into 0cad6338c5535c667812ac377a64503323d230b1 on development.

Coverage increased (+46.6%) to 87.432% when pulling 68e1263fb18839fb28db4bd8dee9b7c60f25fe5c on migrate_to_mac into 0cad6338c5535c667812ac377a64503323d230b1 on development.

Coverage increased (+46.6%) to 87.432% when pulling 4c677bca39d68a5d57b0997c48a91c9cf86b8df7 on migrate_to_mac into 0cad6338c5535c667812ac377a64503323d230b1 on development.

Coverage increased (+46.6%) to 87.432% when pulling 4c677bca39d68a5d57b0997c48a91c9cf86b8df7 on migrate_to_mac into 0cad6338c5535c667812ac377a64503323d230b1 on development.

Coverage increased (+46.6%) to 87.432% when pulling 29cfb82e7d7f26248d56d8776ff487b4cf5dd9df on migrate_to_mac into 0cad6338c5535c667812ac377a64503323d230b1 on development.

Coverage increased (+46.6%) to 87.432% when pulling 1fde41eaa6717c9a3ef0cf1f9a25ce9b6d5394c2 on migrate_to_mac into 0cad6338c5535c667812ac377a64503323d230b1 on development.

Coverage increased (+46.6%) to 87.432% when pulling 1fde41eaa6717c9a3ef0cf1f9a25ce9b6d5394c2 on migrate_to_mac into 0cad6338c5535c667812ac377a64503323d230b1 on development.


fix:🐛fix the bug cannot read properties of null when cell is not exit

fix the bug cannot read properties of null when cell is not exit
Description
fix the bug cannot read properties of null when cell is not exit
Motivation and Context

Types of changes

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] Enhancement (changes that improvement of current feature or performance)
[ ] Refactoring (changes that neither fixes a bug nor adds a feature)
[ ] Test Case (changes that add missing tests or correct existing tests)
[ ] Code style optimization (changes that do not affect the meaning of the code)
[ ] Docs (changes that only update documentation)
[ ] Chore (changes that don't modify src or test files)

Self Check before Merge

[x] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[x] I have read the CONTRIBUTING document.
[ ] I have added tests to cover my changes.
[ ] All new and existing tests passed.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 0.0%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
0

Relevant Lines:
0

💛  - Coveralls


add unit test for generatePIN

Hi! 👋
I have created an unit test for the generatePIN method.
This is my first ever contribution to an open source project. Could you provide me some feedback? And I would like to write the unit tests for other methods as well.

@diamemorreau Thanks. Left a comment.

closes #271


ReferenceError: pjson is not defined

v6.0.0/lib/node_modules/rnpm/src/findPlugins.js:22
    Object.keys(pjson.dependencies || {}),
                ^

ReferenceError: pjson is not defined
    at e (/Users/sibelius/.nvm/versions/node/v6.0.0/lib/node_modules/rnpm/src/findPlugins.js:22:17)
    at Array.map (native)
    at findPlugins (/Users/sibelius/.nvm/versions/node/v6.0.0/lib/node_modules/rnpm/src/findPlugins.js:35:31)
    at getCommands (/Users/sibelius/.nvm/versions/node/v6.0.0/lib/node_modules/rnpm/src/getCommands.js:16:7)
    at Object.<anonymous> (/Users/sibelius/.nvm/versions/node/v6.0.0/lib/node_modules/rnpm/bin/cli:7:47)

I'm receiving this error on node 6.0.0 with the latest version of rnpm link

Can you release a new version please. I keep getting this error. Thanks

@almasakchabayev you can do this for now:
git clone git@github.com:rnpm/rnpm.git
cd rnpm
npm link
npm link rnpm # this will use your local version instead of npm version

You will also need to do this to with https://github.com/rnpm/rnpm-plugin-link

@almasakchabayev AFAIK @Kureev is planning to do a release today (Alexey - if you dont have time then let me know and I'll just send patch to rnpm itself)

@grabbou eager to get this fix as well.

It's already in npm :)

still broken?

/usr/local/lib/node_modules/rnpm/src/findPlugins.js:22
    Object.keys(pjson.dependencies || {}),
                ^

ReferenceError: pjson is not defined
    at e (/usr/local/lib/node_modules/rnpm/src/findPlugins.js:22:17)
    at Array.map (native)
    at findPlugins (/usr/local/lib/node_modules/rnpm/src/findPlugins.js:35:31)
    at getCommands (/usr/local/lib/node_modules/rnpm/src/getCommands.js:16:7)
    at Object.<anonymous> (/usr/local/lib/node_modules/rnpm/bin/cli:8:47)
    at Module._compile (module.js:541:32)
    at Object.Module._extensions..js (module.js:550:10)
    at Module.load (module.js:458:32)
    at tryModuleLoad (module.js:417:12)
    at Function.Module._load (module.js:409:3)

No, it's not :) https://github.com/rnpm/rnpm/blob/master/src/findPlugins.js#L15-L17
Please update to latest.

I installed it 5 minutes before posting?

Which version are you using, @bradennapier?

You have a problem with pjson, @bradennapier ?

I did until I realized above that the file I had was up to date which made no sense - realized it was loading system version rather than nvm version so had to force uninstall system version.  Works now!  Thanks!


SCons: Reduce spam from x11:can_build

When cross-compiling for non-X11 on Linux, it used to be quite spammy.
Now it will only print errors if you miss more than just pkg-config and x11.

LGTM


Flutter. Face Detection. No face detected on Samsung Galaxy A23 Android 12: Access denied finding property "ro.mediatek.platform"

The application written with Flutter, the Face Detection works ok on many other devices but does not work on Samsung Galaxy A23 Android 12.
Found this line in the Android Studio log
E/libc    (15411): Access denied finding property "ro.mediatek.platform"

Google ML kit is not compatible with the processor?
Full log
I/Camera  (15411): startPreview
I/CameraManagerGlobal(15411): Camera 1 facing CAMERA_FACING_FRONT state now CAMERA_STATE_OPEN for client com.skaiscan.app API Level 2
I/Camera  (15411): CameraCaptureSession onConfigured
I/Camera  (15411): Updating builder settings
D/Camera  (15411): Updating builder with feature: ExposureLockFeature
D/Camera  (15411): Updating builder with feature: ExposurePointFeature
D/Camera  (15411): Updating builder with feature: ZoomLevelFeature
D/Camera  (15411): Updating builder with feature: AutoFocusFeature
D/Camera  (15411): Updating builder with feature: NoiseReductionFeature
I/Camera  (15411): updateNoiseReduction | currentSetting: fast
D/Camera  (15411): Updating builder with feature: FocusPointFeature
D/Camera  (15411): Updating builder with feature: ResolutionFeature
D/Camera  (15411): Updating builder with feature: SensorOrientationFeature
D/Camera  (15411): Updating builder with feature: FlashFeature
D/Camera  (15411): Updating builder with feature: ExposureOffsetFeature
D/Camera  (15411): Updating builder with feature: FpsRangeFeature
I/Camera  (15411): refreshPreviewCaptureSession
I/CameraManagerGlobal(15411): Camera 1 facing CAMERA_FACING_FRONT state now CAMERA_STATE_ACTIVE for client com.skaiscan.app API Level 2
I/Camera  (15411): closeCaptureSession
I/BufferQueueProducer(15411): [SurfaceTexture-0-15411-0](id:3c3300000002,api:4,p:1269,c:15411) queueBuffer: queued for the first time.
I/CameraManagerGlobal(15411): Camera 1 facing CAMERA_FACING_FRONT state now CAMERA_STATE_IDLE for client com.skaiscan.app API Level 2
I/Camera  (15411): startPreviewWithImageStream
I/Camera  (15411): CameraCaptureSession onConfigured
I/Camera  (15411): Updating builder settings
D/Camera  (15411): Updating builder with feature: ExposureLockFeature
D/Camera  (15411): Updating builder with feature: ExposurePointFeature
D/Camera  (15411): Updating builder with feature: ZoomLevelFeature
D/Camera  (15411): Updating builder with feature: AutoFocusFeature
D/Camera  (15411): Updating builder with feature: NoiseReductionFeature
W/om.skaiscan.ap(15411): Long monitor contention with owner main (15411) at void android.hardware.camera2.impl.CameraDeviceImpl.waitUntilIdle()(CameraDeviceImpl.java:1339) waiters=0 in void android.hardware.camera2.impl.CameraDeviceImpl$4.run() for 447ms
I/Camera  (15411): updateNoiseReduction | currentSetting: fast
D/Camera  (15411): Updating builder with feature: FocusPointFeature
D/Camera  (15411): Updating builder with feature: ResolutionFeature
D/Camera  (15411): Updating builder with feature: SensorOrientationFeature
D/Camera  (15411): Updating builder with feature: FlashFeature
D/Camera  (15411): Updating builder with feature: ExposureOffsetFeature
D/Camera  (15411): Updating builder with feature: FpsRangeFeature
I/Camera  (15411): refreshPreviewCaptureSession
I/Camera  (15411): CameraCaptureSession onClosed
I/CameraManagerGlobal(15411): Camera 1 facing CAMERA_FACING_FRONT state now CAMERA_STATE_ACTIVE for client com.skaiscan.app API Level 2
I/BufferQueueProducer(15411): [SurfaceTexture-0-15411-0](id:3c3300000002,api:4,p:1269,c:15411) queueBuffer: queued for the first time.
I/BufferQueueProducer(15411): [ImageReader-1280x720f23m1-15411-1](id:3c3300000004,api:4,p:1269,c:15411) queueBuffer: queued for the first time.
I/flutter (15411): ┌───────────────────────────────────────────────────────────────────────────────────────────────────────────────────────
I/flutter (15411): │ 🐛 onEvent -- HomeBloc,
I/flutter (15411): │ 🐛 HomeCameraFaceChecked, message: cameraImage: ImageFormatGroup.yuv420
I/flutter (15411): └───────────────────────────────────────────────────────────────────────────────────────────────────────────────────────
I/DynamiteModule(15411): Considering local module com.google.mlkit.dynamite.face:10000 and remote module com.google.mlkit.dynamite.face:0
I/DynamiteModule(15411): Selected local version of com.google.mlkit.dynamite.face
D/TransportRuntime.SQLiteEventStore(15411): Storing event with priority=VERY_LOW, name=FIREBASE_ML_SDK for destination cct
D/TransportRuntime.JobInfoScheduler(15411): Upload for context TransportContext(cct, VERY_LOW, MSRodHRwczovL2ZpcmViYXNlbG9nZ2luZy5nb29nbGVhcGlzLmNvbS92MGNjL2xvZy9iYXRjaD9mb3JtYXQ9anNvbl9wcm90bzNc) is already scheduled. Returning...
I/om.skaiscan.ap(15411): Background concurrent copying GC freed 19230(1160KB) AllocSpace objects, 22(14MB) LOS objects, 45% free, 28MB/52MB, paused 406us,119us total 120.821ms
D/TransportRuntime.SQLiteEventStore(15411): Storing event with priority=DEFAULT, name=FIREBASE_ML_SDK for destination cct
D/TransportRuntime.JobInfoScheduler(15411): Scheduling upload for context TransportContext(cct, DEFAULT, MSRodHRwczovL2ZpcmViYXNlbG9nZ2luZy5nb29nbGVhcGlzLmNvbS92MGNjL2xvZy9iYXRjaD9mb3JtYXQ9anNvbl9wcm90bzNc) with jobId=-1387388017 in 629833ms(Backend next call timestamp<PHONE_NUMBER>545). Attempt 1
I/DynamiteModule(15411): Considering local module com.google.mlkit.dynamite.face:10000 and remote module com.google.mlkit.dynamite.face:0
I/DynamiteModule(15411): Selected local version of com.google.mlkit.dynamite.face
V/FaceDetectorV2Jni(15411): initialize.start()
I/native  (15411): I0628 21:10:23.745867   15574 face_detector_v2_jni.cc:33] Loading models_bundled/fssd_medium_8bit_v5.tflite
D/TransportRuntime.SQLiteEventStore(15411): Storing event with priority=VERY_LOW, name=FIREBASE_ML_SDK for destination cct
I/native  (15411): I0628 21:10:23.751617   15574 face_detector_v2_jni.cc:33] Loading models_bundled/fssd_medium_8bit_gray_v5.tflite
D/TransportRuntime.JobInfoScheduler(15411): Upload for context TransportContext(cct, VERY_LOW, MSRodHRwczovL2ZpcmViYXNlbG9nZ2luZy5nb29nbGVhcGlzLmNvbS92MGNjL2xvZy9iYXRjaD9mb3JtYXQ9anNvbl9wcm90bzNc) is already scheduled. Returning...

V/FaceDetectorV2Jni(15411): initialize.end()
V/FaceDetectorV2Jni(15411): initialize.start()
I/native  (15411): I0628 21:10:23.842092   15574 face_detector_v2_jni.cc:33] Loading models_bundled/fssd_medium_8bit_v5.tflite
I/native  (15411): I0628 21:10:23.842937   15574 face_detector_v2_jni.cc:33] Loading models_bundled/fssd_medium_8bit_gray_v5.tflite
I/native  (15411): I0628 21:10:23.845093   15574 face_detector_v2_jni.cc:33] Loading models_bundled/fssd_anchors_v5.pb
I/native  (15411): I0628 21:10:23.845889   15574 face_detector_v2_jni.cc:33] Loading models_bundled/LMprec_600.emd
I/native  (15411): I0628 21:10:23.863184   15574 face_detector_v2_jni.cc:33] Loading models_bundled/BCLlefteyeclosed_200.emd
I/native  (15411): I0628 21:10:23.864038   15574 face_detector_v2_jni.cc:33] Loading models_bundled/BCLrighteyeclosed_200.emd
I/native  (15411): I0628 21:10:23.864741   15574 face_detector_v2_jni.cc:33] Loading models_bundled/BCLjoy_200.emd
I/native  (15411): I0628 21:10:23.865313   15574 face_detector_v2_jni.cc:33] Loading models_bundled/MFT_fssd_fastgray.pb
I/native  (15411): I0628 21:10:23.865536   15574 face_detector_v2_jni.cc:33] Loading models_bundled/contours.tfl
I/native  (15411): I0628 21:10:23.878275   15574 face_detector_v2_jni.cc:33] Loading models_bundled/blazeface.tfl
V/FaceDetectorV2Jni(15411): initialize.end()
V/FaceDetectorV2Jni(15411): detectFacesImageByteArray.start()
E/libc    (15411): Access denied finding property "ro.mediatek.platform"
V/FaceDetectorV2Jni(15411): detectFacesImageByteArray.end()
V/FaceDetectorV2Jni(15411): detectFacesImageByteArray.start()
V/FaceDetectorV2Jni(15411): detectFacesImageByteArray.end()
D/TransportRuntime.SQLiteEventStore(15411): Storing event with priority=VERY_LOW, name=FIREBASE_ML_SDK for destination cct
I/flutter (15411): ┌───────────────────────────────────────────────────────────────────────────────────────────────────────────────────────
I/flutter (15411): │ #0   LoggerService.info (package:skaiscan_log_service/skaiscan_log_service.dart:46:12)
I/flutter (15411): │ #1   HomeBloc._onCameraFaceChecked (package:skaiscan/pages/home/bloc/home_bloc.dart:127:19)
I/flutter (15411): ├┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄
I/flutter (15411): │ 💡 Faces found: 0
I/flutter (15411): └───────────────────────────────────────────────────────────────────────────────────────────────────────────────────────
D/TransportRuntime.JobInfoScheduler(15411): Upload for context TransportContext(cct, VERY_LOW, MSRodHRwczovL2ZpcmViYXNlbG9nZ2luZy5nb29nbGVhcGlzLmNvbS92MGNjL2xvZy9iYXRjaD9mb3JtYXQ9anNvbl9wcm90bzNc) is already scheduled. Returning...

This seems to be related to my comment on issue https://github.com/bharat-biradar/Google-Ml-Kit-plugin/issues/285
It is related to the output coming from the camera plugin.

Similar problem with Samsung S20 #285

Similar problem with Samsung S20

@fbernaly So how to fix this issue? any suggestion?
is that because the resolution output coming from camera that give us the error ?

This sounds related to my issue here: https://github.com/flutter/flutter/issues/118350

this helped https://github.com/flutter/packages/pull/3277 !

Glad it worked! The issue ended up being nobody was implementing YUV to NV21 correctly. The 'concatenatePlanes' approach just doesn't cut it for all cases.

@acoutts , @svonidze : what was the fix for this?

Request streaming in NV21 format from the camera and pass that to the mlkit plugin.

Do we need to update anything in our plugin?

Do we need to update anything in our plugin?

Bump the example app to the latest version of the camera containing NV21 (0.10.5)

Modify the camera controller constructor to stream NV21 on android. This way on both platforms, there will be just a single-plane frame coming back from the native side. On iOS, bgra8888 is already single-plane and appropriate to send directly into MLKit. On android, NV21 is the same.

  Future _startLiveFeed() async {
    final camera = cameras[_cameraIndex];
    _controller = CameraController(
      camera,
      ResolutionPreset.high,
      enableAudio: false,
      inputImageFormat: defaultTargetPlatform == TargetPlatform.android
          ? InputImageFormat.nv21
          : InputImageFormat.bgra8888,
    );
// ...

The function that processes frames can then be simplified simply into this:

Future _processCameraImage(CameraImage image) async {
    final bytes = cameraImage.planes.first.bytes;
// ...

Maybe add some checks that the plane length is 1 but for  bgra8888 and NV21 it will always be one plane.
Of course people are still free to stream in YUV420 (the default format) and do the conversion themselves, but it needs to be noted that this routine to concatenate the planes is not a working solution and will not work when the device camera includes padding in the image plane data like the devices mentioned in this issue.
What will happen is the bytesPerRow will not equal the frame width and the resulting concatenated image won't be a valid frame.
    final WriteBuffer allBytes = WriteBuffer();
    for (final Plane plane in image.planes) {
      allBytes.putUint8List(plane.bytes);
    }
    final bytes = allBytes.done().buffer.asUint8List();

You can see my examples here where I converted these frames into RGB to see what they actually look like to the MLKit plugin and it's very clear they are not valid images and is why the image recognition doesn't work on them.
https://github.com/flutter/flutter/issues/118350
The official MLKit example app by google avoids this issue by using the CameraX camera and streaming directly in NV21, which the latest camera plugin can now do too.

Thanks @acoutts , I think this will solve most of the complains and issues reported when using this plugin. I will work on this changes ASAP.

I am updating InputImage with some breaking changes to only support nv21 and bgra8888 from Camera plugin in this PR: https://github.com/flutter-ml/google_ml_kit_flutter/pull/454. It will be released later this week.

Does there have any way to crop the face when the controller is set to NV21 ? Meet some problem  when convert to image.

How to use the InputImageFormat.nv21 with the following code -
final XFile? photo = await picker.pickImage(           source: ImageSource.camera,           preferredCameraDevice: CameraDevice.front)
What should be the right syntax?  @fbernaly @ghost


Lenovo Yoga C630 Pantheon "no DMIC ep_blob found" in dmesg

I get the following error repeated numerous times in my dmesg:
[   21.234475] snd_soc_avs 0000:00:1f.3: no DMIC ep_blob found [   21.234479] snd_soc_avs 0000:00:1f.3: module-type create failed: -2 [   21.234481] snd_soc_avs 0000:00:1f.3: error creating module -2 [   21.234585] snd_soc_avs 0000:00:1f.3: create path failed: -2 [   21.234586] snd_soc_avs 0000:00:1f.3: ASoC: error at snd_soc_dai_hw_params on DMIC Pin: -2 [   21.234590]  DMIC: ASoC: error at __soc_pcm_hw_params on DMIC: -2 [   21.234593]  Digital Microphone: ASoC: error at dpcm_fe_dai_hw_params on Digital Microphone: -2
Otherwise, most audio works well. The internal microphone is, however, quite quiet and the headphone detection/switching can sometimes be intermittent.
Boardname
Pantheon / nami
Operating System: Fedora Linux 39
KDE Plasma Version: 5.27.9
KDE Frameworks Version: 5.111.0
Qt Version: 5.15.11
Kernel Version: 6.5.12-300.fc39.x86_64 (64-bit)
Graphics Platform: Wayland
Processors: 8 × Intel® Core™ i7-8550U CPU @ 1.80GHz
Memory: 15.5 GiB of RAM
Graphics Processor: Mesa Intel® UHD Graphics 620
Manufacturer: Google
Product Name: Pantheon
System Version: 1.0

That error is only there because of pipewire weirdness, so you can just ignore it. The headphone switching is also just an audio server quirk. As for your mic being quiet, you may need to set the volume to over 100%. ChromeOS has a special value in ucm that lets them do that, we can't do that with a regular audio server though.


The script needs 'google credentials' but your instructions don't mention either changing this or where to get them from.

Are we supposed to have access to yours?
You have this in the script:
STTS.GOOGLE_CREDENTIALS = "C:\Users\Ciaran\Downloads\googletts.json"

Nope you need to setup your own, that's just an example

Do you have instructions on what exactly needs to be done and how?

You need to get your credentials file
https://cloud.google.com/text-to-speech/docs/create-audio-text-command-line
I'd try a Google guide but once you've got you're credentials JSON it's straightforward from there
You need a credit card and billing address etc.


AST implementations for node src checking.

This PR implements AST parsing for source code checking, as mentioned in https://github.com/da-h/miniflask/pull/121#discussion_r1015544633

@da-h It looks like someone force-pushed some important code changes to the source branch, so please make sure to review the merge carefully.

Changes are very minimal, I do not understand why rebasing did fail here.
I will merge this PR with #121 and push the changes there so we have a track record of all changes.


Edge Selenium tests are crashing on Ubuntu

First reported on twitter: https://twitter.com/diegofmolina/status/1509254663215927306
Link to test logs: https://github.com/SeleniumHQ/selenium/runs/5746311483?check_suite_focus=true#step:10:162

@bwalderman thanks for trying to reproduce. I was using bazel to run our tests and it seems we are doing something that causes the issue, I ran a simple test with maven and it all works well under Ubuntu.
Please feel free to close this issue.

Thanks for confirming. I'll go ahead and close this. Feel free to open another issue in this repo if you encounter any Edge-specific bugs.


Set expiring date for hash value

Motivation
I know that we can set the expire date like this for a basic key / value pair :
await client.set("key", "value", { EX : 60 });

But their is no such way to set expire date for a hash value, it would be great to have something like this :
await client.hSet(
        'hash',
        {
          key: 'value',
        },
        {
          EX: 60,
        },
      );

Basic Code Example
await client.hSet(
        'hash',
        {
          key: 'value',
        },
        {
          EX: 60,
        },
      );

This is not supported by Redis at the moment (see SET). You can open an issue in this repository, but I'm pretty sure someone already asked for this feature...
In the meantime you can:
// pipeline
await Promise.all([
  client.hSet('key', {}),
  client.expire('key', { EX: 60 })
]);

// multi
await client.multi()
  .hSet('key', {})
  .expire('key', { EX: 60 })
  .exec();

Thank you so much @leibale , it's exactly what i needed !!!