fix empty description is displayed

Details

fix empty description is displayed
Fixed Issues

$ https://github.com/Expensify/App/issues/48050
PROPOSAL: https://github.com/Expensify/App/issues/48050#issuecomment-2311711164
Tests

Create a room with the sort description as normal text (without any markdown)
Go to the room and open the detail page
Verify that the description is displayed

[x] Verify that no errors appear in the JS console

Offline tests

Same as above
QA Steps

Create a room with the sort description as normal text (without any markdown)
Go to the room and open the detail page
Verify that the description is displayed

[x] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:

[x] I verified that all the inputs inside a form are aligned with each other.
[x] I added Design label and/or tagged @Expensify/design so the design team can review the changes.

[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
https://github.com/user-attachments/assets/3f9dd9cd-79a7-4b25-9fbc-e04326e3a0ea

Android: mWeb Chrome
https://github.com/user-attachments/assets/89039de6-c364-42f8-bf65-79dc1a5d638b

iOS: Native

iOS: mWeb Safari
https://github.com/user-attachments/assets/d1b4e0cc-df8d-424f-a1a9-71b9f47f77c6

MacOS: Chrome / Safari
https://github.com/user-attachments/assets/878689c1-e878-4b43-adfd-2c885d37d233

MacOS: Desktop
https://github.com/user-attachments/assets/5cee9e90-c1e4-4e03-9074-1672faca513e

I have some problems with IOS native build after RN upgrade.

Thanks.

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

I confirmed this is fixed on staging

🚀 Cherry-picked to staging by https://github.com/puneetlath in version: 9.0.25-7 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.


Is it possible to add other attributes to rects in flame graph?

Is your feature request related to a problem? Please describe.
I wanted to implement a flame graph that supports keyboard navigation and voice-over.
Which requires adding tabindex and aria-label attributes on each rect/cell
Describe the solution you'd like
A way to add other attributes.

Closing for inactivity.


Import book

It should be possible to import a book edition to overwrites its contents. This bundle would include the edition metadata, chapter text, and an images folder, all checked against the edition schema. If everything is correct, we'd overwrite the edition content in the database.
The use cases for this features include:

Updating a book that has been exported and modified via other tools
Allowing for book source to be hosted in other places such as GitHub, and then uploading revisions.

Implementation

[x] Create a new admin TypeScript script to import a book
[x] The script should take a path to a book folder and book ID as input and show errors if URL not valid or the book ID is not valid
[x] Verify that all book elements are present, and checking for schema errors, explaining errors if they are not. See bookish-reader's build script for code that verifies book. We could refactor this verification step to have both bookish-reader and this other script use it.
[x] Process all symbols to generate chapter text, since symbols are not supported in the editor.
[x] Delete all existing images in storage for the book; upload all images in storage
[x] Update all image references in the book to newly stored images links
[x] Support dry run to see what will be replaced
[x] Once verified, replace book, editions, chapters in Firestore
[x] Test import in staging with Critically Conscious Computing
[x] Test in production with Critically Conscious Computing

@ferauche, this is one of the features I'll need to build in order to get Critically Conscious Computing into the hosted Bookish.press platform. I hope to start work on it soon.

@ferauche Okay, I implemented this import feature. It works, but it's not a self-service feature yet: I can import into the database from local files, which was enough to get a copy of the book into the hosted environment.


Carousel coming soon?

I have some first implementation, but it is too early to publish. Cannot tell you a date, as this is all happening in my spare time...

Is anyone working on this issue? If not, I could put some effort to make this feature since it is highly desirable to me.

I'm also interested in this feature and willing to help out.

I've reached a point in my project as well where I could use a carousel implementation - happy to help test it out when they code is ready :)

Fantastic! I've been using the standard bootstrap js for carousel and it's super annoying, can't wait for the ember implementation! :)


Add gpuci build script

rerun tests

run tests

run tests

In order for this to work, a github hook needs to be added linking to the gpuci server. The settings in https://github.com/Quansight/dask_gdf show how to do this. If it is still not working, make a comment on a PR saying either "run tests" or "rerun tests".

I think an admin needs to do use the magic words

run tests

Can one of the admins verify this patch?

LGTM, will fix failing tests in a followup PR.


[BUG] - Minio & qdrant storage is not persistant

Describe the bug
In the current docker template file the object storage (minio) & qdrant have not volume attached. This means they are not saved persistently.
To Reproduce
Steps to reproduce the behavior:

Create Project
Let Tokenization finish
Run Labelingfunction (docbin_full is used)
use stop script to shut down the app
use start script to start the app
run the function
Error

Expected behavior
Should work.
Desktop (please complete the following information):

OS:: all
Browser: all
Version: 1.0.0

@JWittmeyer can this be closed?


HADOOP-18329 - Support for IBM Semeru JVM v><IP_ADDRESS> Vendor Name Changes

Description of PR
Applies patches provided in to branch-3.3 via cherry-picking a merge commit of the proposed changes, eg.
git cherry-pick a46b20d25f12dfb6af1d89c6bd8e39220cc8c928 -m 1

The original change request can be found at https://github.com/apache/hadoop/pull/4537

There are checks within the PlatformName class that use the Vendor property of the provided runtime JVM specifically looking for IBM within the name. Whilst this check worked for IBM's java technology edition it fails to work on Semeru since <IP_ADDRESS> due to the following change:
java.vendor system property
In this release, the java.vendor system property has been changed from "International Business Machines Corporation" to "IBM Corporation".
Modules such as the below are not provided in these runtimes.
com.ibm.security.auth.module.JAASLoginModule
This change attempts to use reflection to ensure that a class common to IBM JT runtimes exists, extending upon the vendor check, since IBM vendored JVM's may not actually require special logic to use custom security modules. The same 3.3.3 versions were working correctly until the vendor name change was observed during routine upgrades by internal CI.
How was this patch tested?
CI + Unit test
For code changes:

[x] Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'HADOOP-17799. Your PR title ...')?
[ ] Object storage: have the integration tests been executed and the endpoint declared according to the connector-specific documentation?
[ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
[ ] If applicable, have you updated the LICENSE, LICENSE-binary, NOTICE-binary files?

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
10m 21s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 1 new or modified test files.

_ branch-3.3 Compile Tests _

+0 :ok:
mvndep
15m 31s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
26m 48s

branch-3.3 passed

+1 :green_heart:
compile
18m 46s

branch-3.3 passed

+1 :green_heart:
checkstyle
1m  0s

branch-3.3 passed

+1 :green_heart:
mvnsite
1m  7s

branch-3.3 passed

+1 :green_heart:
javadoc
1m  4s

branch-3.3 passed

+1 :green_heart:
spotbugs
1m 39s

branch-3.3 passed

+1 :green_heart:
shadedclient
25m 22s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 25s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
0m 37s

the patch passed

+1 :green_heart:
compile
17m 54s

the patch passed

+1 :green_heart:
javac
17m 54s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
0m 54s

hadoop-common-project: The patch generated 0 new + 3 unchanged - 1 fixed = 3 total (was 4)

+1 :green_heart:
mvnsite
1m  6s

the patch passed

+1 :green_heart:
javadoc
0m 57s

the patch passed

+1 :green_heart:
spotbugs
1m 48s

the patch passed

+1 :green_heart:
shadedclient
25m 37s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
0m 37s

hadoop-minikdc in the patch passed.

+1 :green_heart:
unit
3m 34s

hadoop-auth in the patch passed.

+1 :green_heart:
asflicense
0m 50s

The patch does not generate ASF License warnings.

158m 35s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5208/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/5208

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux b3f0d71badd5 4.15.0-200-generic #211-Ubuntu SMP Thu Nov 24 18:16:04 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
branch-3.3 / 3774de951867c1c2250851d6eeb21b0ef239e051

Default Java
Private Build-1.8.0_352-8u352-ga-1~18.04-b08

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5208/1/testReport/

Max. process+thread count
527 (vs. ulimit of 5500)

modules
C: hadoop-common-project/hadoop-minikdc hadoop-common-project/hadoop-auth U: hadoop-common-project

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5208/1/console

versions
git=2.17.1 maven=3.6.0 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.


Added July24 for CSR

Cancelling this. Will do a new one and leave the bucket as vanilla ie the one that you guys normally use.


UAI-Support eNAM & Carnot with the implementation process

Description
Following the UAI Winroom outcome, eNAM & Carnot is seeking support for the implementation process. @Kathirvel-ai will confirm the date and time for the NPs call by the end of today (25th Nov). Tentatively, the call is scheduled for either the 27th or 28th of November and will last 4–5 hours.

@ankitShogun - Following the UAI Winroom outcome, eNAM is seeking support for the implementation process. @Kathirvel-ai will confirm the date and time for the NPs call by the end of today (25th Nov). Tentatively, the call is scheduled for either the 27th or 28th of November and will last 4–5 hours.
@faizmagic @viraj89 @emmayank @Kathirvel-ai

@Kathirvel-ai - Kindly let tech team know on the support details.
@faizmagic @viraj89 @emmayank

@yesrag2309 @faizmagic @emmayank @viraj89
We can have a shorter format of winroom on Thursday from 2 PM to 5 PM and Friday from 2 PM to 5 PM

As discussed with @Kathirvel-ai Ankit is primarily required for the above mentioned 2 days support. In case of any blockers he need Prasad and Shrey support in that connect. @viraj89 please set the expectations with them and kindly do the needful.
@faizmagic @emmayank

UAI winroom support was provided by Prasad and Bhanu. Shrey assisted on a case to case basis.
Outcome:
Carnot (equipment rental BPP) - completed the beckn-ONIX setup, pending integration testing
eNAM (price discovery BPP) - beckn-ONIX setup and search request was completed. dropped midway to realign with their team internally and get back.


Porting a new marketing page ⭐

We have a new design for the marketing page (available in this GitHub Repo), and it's time to port that here!
We want to:

Port the main content
Port the footer into the root / without replacing the footer component
Port the banner as a component

We are not porting the nav bar.
Edit: Updated to reflect the comment by @chartgerink 🙌

Ah sorry if I didn't communicate clearly earlier - I meant to say to port the footer into the / but not to replace the footer component as it's used throughout the app! 😅

I see! thanks for clarifying, Chris!


feat: add support for margin-inline-start and margin-inline-end

Summary
Adds support for margin-inline-start and margin-inline-end via ms and me

Test plan
Corresponding tests added

I learned some CSS from this PR :student:
Should we worry about accumulating lots of abbreviated props? Should there be a way for projects to opt in to abbreviations, or even to specify their own, or omit defaults that are problematic? This question isn't specific to this PR, it just makes me wonder about it.
Otherwise this LGTM, although all the extra typings for states highlight the importance of #206.

Should we worry about accumulating lots of abbreviated props? Should there be a way for projects to opt in to abbreviations, or even to specify their own, or omit defaults that are problematic? This question isn't specific to this PR, it just makes me wonder about it.

I think the shortcut is not necessary, this prop represent and advanced usage. I think it is good to support it but for the prefix it is too confusing for me.

It will not be part of xstyled, perhaps in an official i18n plugin. For now you should add the utility by yourself, the v3 let you do it easily https://xstyled.dev/docs/adding-new-utilities/.


change master to main in CLI output when checking out via click

This adds a regex to replace 'master' with 'main' in the command line output when checking out main by clicking on the tag with the branch name.
Resolves issue #821.
FYI: @pcottle - as we discussed in the issue comments, I wasn't able to build the app to test this change

Ah yes this totally works! But I have an idea on how to consolidate the logic a bit. here I'll show in a followup PR

Yep here:
https://github.com/pcottle/learnGitBranching/commit/4148f0b846105a0887142c5ddeda877fa6573ebd
this will use the git engine's logic to do the replacement, so its a bit more centralized :)

Thanks for the update - this is a cleaner approach for sure!


Problem with yargs / Debian - Syntax Error with "const"

installed npm + node using apt-get and ran the command to get "postmark-cli".
$:~# npm --version
3.5.2
$:~# node --version
v4.2.6
Now when i run the command i get this error:
`$:~# postmark
/usr/local/lib/node_modules/postmark-cli/node_modules/yargs/yargs.js:14
const { globalMiddlewareFactory } = require('./lib/middleware')
^
SyntaxError: Unexpected token {
at exports.runInThisContext (vm.js:53:16)
at Module._compile (module.js:374:25)
at Object.Module._extensions..js (module.js:417:10)
at Module.load (module.js:344:32)
at Function.Module._load (module.js:301:12)
at Module.require (module.js:354:17)
at require (internal/module.js:12:17)
at Object. (/usr/local/lib/node_modules/postmark-cli/node_modules/yargs/index.js:5:15)
at Module._compile (module.js:410:26)
at Object.Module._extensions..js (module.js:417:10)`

Hey @cellrok. Are you able to upgrade to a newer version of node? Object spread properties aren't supported in this version. Upgrading to anything above node v7 should work.

Ah, right. I thought it was something like that. It's odd that the official package for Ubuntu is so far behind. I didn't expect that. Had to install another PPA to get the latest version and then the installation was a breeze and i am now all set. Thanks!
For future reference, i followed this guide:
https://tecadmin.net/install-latest-nodejs-npm-on-ubuntu/


[Feature][config] add seatunnel-config-shaded module

Search before asking

[X] I had searched in the feature and found no similar feature requirement.

Description
seatunnel-config module contains all files from lightbend-config project, we can use mvn shade plugin to help us do the same thing, and remove all these source files from seatunnel project.
https://github.com/lightbend/config/tree/main/config/src/main/java/com/typesafe/config
Usage Scenario
No response
Related issues
No response
Are you willing to submit a PR?

[X] Yes I am willing to submit a PR!

Code of Conduct

[X] I agree to follow this project's Code of Conduct

It not a right way that rename the package name directly, but from the readme doc, some changes have been made based on the original code.
We need to discuss about how to solve it gracefully.
https://github.com/InterestingLab/seatunnel/tree/dev/seatunnel-config
* [Keep config item order in ConfigObject](https://github.com/lightbend/config/issues/365)

* Change path token separator from `"."` to `"->""`.

* Added `parseObjectForseatunnel()` to parse config objects in `input`, `filter`, `output` for seatunnel.

* Change package name to avoid implementation conflict when using this code with the official typesafe config used by Apache Flink.

Fixed https://github.com/apache/incubator-seatunnel/pull/906


[MAINT] Restructure setup configuration

Closes #297.

Changes proposed in this pull request:

Add pyproject.toml with build-tools and black configuration.
Move contents of nimare/info.py to setup.cfg.
Remove get_version.py, which I don't think was doing anything.

I have no clue why this is failing. The interpolation step (i.e., using the dependency groups as variables) seems to be the problem, but I copied the pattern from nibabel, so I don't see why it is problematic.

Closed in favor of #303.


Documentation Issues

Hi!
I was reading the documentation and following the sections steps when I saw some typos:
Inside the "Sequence Reconstruction" Section:
In the alignment folder:

There is not a "green-lantern" file. Instead, there is a "region3" file.

In the documentation:

In the alignment step, the green-lantern command fails. It is because the command is described as:

qiime sidle align-regional-kmers
--i-kmers alignment/green-lantern-kmer-db.qza
--i-rep-seq table/green-lantern-rep-seq.qza
--p-region GreenLantern
--p-n-workers 2
--o-regional-alignment alignment/green-lantern-align-map.qza
But it is should be:
qiime sidle align-regional-kmers
--i-kmers database/sidle-db-green-lantern-100nt-kmers.qza
--i-rep-seq data/green-lantern-100nt-rep-set.qza
--p-region GreenLantern
--p-n-workers 2
--o-regional-alignment alignment/green-lantern-align-map.qza
Also, I was wondering where I built the "aligned-sequence-database based file" used in the "Phylogenetic Reconstruction" inside the "Sequence Reconstruction" Section.
Regards,
Elsa

Hi @elsamdea,
Sorry for the long follow up. I think this is fixed in the updated branch (#27). But, I'm waiting for a review. Thank you and i'll keep you updated!
I will try to make sure the database sources are better described and may ask you if you're willing to review when we hit that point, if you're comfortable.

Hi @jwdebelius,
(I answer by email because I can't find the place to do it on github).
Don't worry, I understand there is so much on the way.  Also, I take
advantage of this email to comment that, in the phylogeny step, if the
command fails with the error "conda libraries deprecating
method ".iloc()", you can add that a solution is to update directly in
terminal with the command "conda panda updates". (I can open an issue if
you wish).
It will be an honor to review! And, if there is another way to help, please
let me know :).
Best regards,
Elsa
On Mon, 20 Sept 2021 at 17:25, Justine Debelius @.***>
wrote:

Hi @elsamdea https://github.com/elsamdea,
Sorry for the long follow up. I think this is fixed in the updated
branch (#27 https://github.com/jwdebelius/q2-sidle/pull/27). But, I'm
waiting for a review. Thank you and i'll keep you updated!
I will try to make sure the database sources are better described and may
ask you if you're willing to review when we hit that point, if you're
comfortable.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/jwdebelius/q2-sidle/issues/28#issuecomment-923030895,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AK6LCP4TR26FZD2WS4VHDNTUC5G5VANCNFSM5DD2ZRXQ
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.


Global setting to exclude outbound traffic from sidecar

Describe the feature request
We're on Istio 1.7.2. We're getting database connection issue to external AWS RDS instance. We're getting SSL error ((psycopg2.OperationalError) SSL SYSCALL error: EOF detected) randomly. When searched for a bit we stumbled upon this thread.. We're still analysing the issue. But our initial assumption is Istio may be the reason for this error.
Is there a way to set traffic.sidecar.istio.io/excludeOutboundPorts: 5432 globally for our mesh.
Cheers,
~Ajit
Describe alternatives you've considered
[ ] Docs
[X] Installation
[ ] Networking
[ ] Performance and Scalability
[ ] Extensions and Telemetry
[ ] Security
[ ] Test and Release
[ ] User Experience
[ ] Developer Infrastructure

Yes, --set .values.global.proxy.excludeOutboundPorts will configure the same globally


Feature Request: Colorblind Mode

Hi,
Maybe I could make a PR, but the red & green colors that tell me if my node is synced/healthy are identical. If in the settings I could change to a colorblind mode that would switch them to red/pink/maroon for bad and a blue for good I would easily be able to discern it.
Red/Pink/Maroon for danger.
Blue for everything is good.
From your desktop page I collected form some blue looking colors that you are already using and would be appropriate for a "success" color (for "good" or "operational"):

#4CAAFF
#666AF6
--accent-primary

Here are some reds/whatever from the dashboard that look similar to me and could be used for the opposite color (for "bad" or "not operational"):

#16E1D5
#FF8B5C
#61E884

I am super color blind, so I normally don't suggest colors to use, but you could also use a brown or dark red for danger (#8B0000, #90021D) and a cyan or teal for success (#84BAEC, #F6C1E4)
Thank you for your considerations.

Would be nice to have, but it's really low priority and it's not planned at the moment.


Adding support for the escape char with an empty string via polyfill

@theodorejb I've added a new class RFC4180Iterator in the PR to polyfill the behavior with the Reader class it was easier than I thought anyway. Could you give it a spin .. I've try to keep the behavior as close to fgetcsv as I could.

I tested the branch again and did some benchmarking. The good news is that it seems to be working reliably! I was able to output a large CSV, read it into memory, and write it back again with zero loss of data.
I compared the performance of native reading/writing (passing a null byte to setEscape) with the polyfills (passing a blank string) on an 11MB, ~24K row CSV.  Here are the results (averaged over 5 runs):

Action
Average time (sec)
Percent slower

native read native write
4.552
N/A

native read custom write
5.008
10%

custom read native write
7.496
65%

custom read custom write
7.960
75%

While the custom writer is almost as fast as the native function, the custom reader is noticeably slower. 😢 Correct results are more important than performance, though, and maybe the custom reader can be optimized more in the future.
From reviewing the patch diff, it looks like the custom reader unit tests are just checking that the number of rows is correct. Shouldn't they also verify that the row contents match what is expected?

@theodorejb indeed the test suite should be improved be I kept improving the parsing using local data. I will update them. This is a first implementation and it uses fgetc which is slow but accurate maybe I can improve it by switching to fgets but I wanted first to have an accurate code before optimization

It doesn't seem that fgets is any faster - maybe even a bit slower. With the latest commit it now takes an average of 8.6 seconds to parse and output my CSV.

@nyamsprod For reference here's the code I used for testing:
use League\Csv\{Reader, Writer};

require 'vendor/autoload.php';

$start = microtime(true);
$csv = Reader::createFromPath('test.csv');
$csv->setEscape("");

$copy = Writer::createFromPath('test_copy.csv', 'w');
$copy->setEscape("");
$copy->insertAll($csv->getRecords());

echo 'took ' . (microtime(true) - $start) . ' sec';

I verified that test_copy.csv is byte-for-byte identical to the original file by checking its SHA-256 hash. I'm sure there are edge cases in reading CSVs that my file doesn't cover, though, so hopefully the League/CSV unit tests will catch all of them.

@theodorejb understood you had some chances with your file then :smile:  because the poly fill mimics fputcsv in that it add enclosure if an space character is found in a field content. This means that your CSV does not contains spaces or that they are already quoted. Using your test script with a CSV containing more than 50000 records, a simple md5_file returns false because of that but a check record by records validate that the documents contains the same data. :+1: . I'll let this PR as it is right now and merge it to the master branch hopefully next week.


[Renderer] calc lightstyle sampled color in shader

Related? Or should I create a separate issue?
https://user-images.githubusercontent.com/3608544/217814580-f3523b0c-e767-4a86-a54f-7d61ca1097fa.mp4

Nevermind, seems it also happens in vanilla version. Please ignore :d

Closed as finished


Removed default admin credentials.

Description

Adjusted the password used by the security enabled tests based on this comment https://github.com/opensearch-project/anomaly-detection/pull/1134/files#r1462673941
Adjusted the developer guide based on this comment https://github.com/opensearch-project/anomaly-detection/pull/1134/files#r1462674251

Issues Resolved
https://github.com/opensearch-project/notifications/issues/832
Check List

[x] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Need to backport to 2.x and 2.12. I do not have permissions to add labels.

@AWSHurneyt backport 2.x failed, please help to do manual backport for 2.x, thanks.


Upgraded node version in travis

Description:
This will hopefully fix the angular/cli error found here https://github.com/angular/angular-cli/issues/10897
Improvements

build?

Known Issues:
NONE

Pull Request Test Coverage Report for Build 2591

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 69.931%

Totals

Change from base Build 2587:
0.0%

Covered Lines:
1280

Relevant Lines:
1770

💛  - Coveralls


App termination due to [NSURLResponse allHeaderFields]:  unrecognized selector sent to instance

Description
My app basically crashes after reaching 100% from the code being bundled.
So far what I have done is:

Go thru the upgrade tool to upgrade from 0.61.5 -> 0.62.2
Follow the xcode upgrade instructions here:  https://github.com/react-native-community/upgrade-support/issues/13

If anyone has any idea why I get this issue below, so far I have followed linked issues point to logbox/flipper image issue. There are no useful instructions or hints on how to fix this issue and/or the issue has been closed. I've spent hours trying to figure this issue out 🥺
I'd be super glad if anyone can point me in the right direction to get this figured out:
Terminating app due to uncaught exception 'NSInvalidArgumentException',
reason: '-[NSURLResponse allHeaderFields]:
unrecognized selector sent to instance 0x6000002756e0'
*** First throw call stack:
(
	0   CoreFoundation                      0x00007fff23e3dcce __exceptionPreprocess + 350
	1   libobjc.A.dylib                     0x00007fff50b3b9b2 objc_exception_throw + 48
	2   CoreFoundation                      0x00007fff23e5e9f4 -[NSObject(NSObject) doesNotRecognizeSelector:] + 132
	3   CoreFoundation                      0x00007fff23e426cc ___forwarding___ + 1436
	4   CoreFoundation                      0x00007fff23e449b8 _CF_forwarding_prep_0 + 120
	5   yotie                               0x00000001091de02c +[SKResponseInfo shouldStripReponseBodyWithResponse:] + 76
	6   yotie                               0x00000001091ddf01 -[SKResponseInfo initWithIndentifier:timestamp:response:data:] + 241
	7   yotie                               0x00000001091b7cd9 __71-[FLEXNetworkRecorder recordLoadingFinishedWithRequestID:responseBody:]_block_invoke + 825
	8   libdispatch.dylib                   0x000000010cf6ff11 _dispatch_call_block_and_release + 12
	9   libdispatch.dylib                   0x000000010cf70e8e _dispatch_client_callout + 8
	10  libdispatch.dylib                   0x000000010cf776fd _dispatch_lane_serial_drain + 788
	11  libdispatch.dylib                   0x000000010cf7828f _dispatch_lane_invoke + 422
	12  libdispatch.dylib                   0x000000010cf83b65 _dispatch_workloop_worker_thread + 719
	13  libsystem_pthread.dylib             0x00007fff51b9ea3d _pthread_wqthread + 290
	14  libsystem_pthread.dylib             0x00007fff51b9db77 start_wqthread + 15
)
libc++abi.dylib: terminating with uncaught exception of type NSException
(lldb)

React Native version:
0.62.2
Steps To Reproduce

Go thru the upgrade tool to upgrade from 0.61.5 -> 0.62.2
Follow the xcode upgrade instructions here:  https://github.com/react-native-community/upgrade-support/issues/13

Expected Results
App to open up and run properly

@kennetpostigo is it because of base64 image as https://github.com/facebook/react-native/issues/28583?

@guhungry  I don't even think i'm using a base64 image anywhere

Can this be related to #28454?

Updating flipper to at least 37 fixed this

Using this post I fixed this issue: https://github.com/facebook/react-native/issues/28583#issuecomment-614239427 and https://github.com/facebook/react-native/issues/28583#issuecomment-630519103

@tushar-inno it worked for me as well on RN 0.62.2, thank you.


Disable notification sound

@tonyofrancis in some devices(Android 10) am getting notification sound.
FetchConfiguration fetchConfiguration = new FetchConfiguration.Builder(context).setDownloadConcurrentLimit(3)
.setNotificationManager(new DefaultFetchNotificationManager(context) {
@NotNull
@Override
public Fetch getFetchInstanceForNamespace(@NotNull String namespace) {
return fetch;
}
            }).enableRetryOnNetworkGain(true).build();

any changes i need to do to disable notification sound?
Thanks

I get notification sound each update progress percent, it is crazy

Fix is coming this week.

New version of Fetch has been released. See readme for new version number.


Runtime Type Inspection Limitations

Since type annotations are deferred to strings, any code or library that attempts to use annotations for runtime type inspection or dynamic behavior (like certain ORM libraries, or introspection tools) might fail, as they won’t see the actual types until they are explicitly evaluated. This can lead to unexpected behavior or errors if runtime access to type information is required.
path to file - https://github.com/apify/crawlee-python/tree/master/src/crawlee/_utils /blocked.py

The general argument is being discussed in https://github.com/apify/crawlee-python/issues/645. If you want to elaborate on this particular problem of deferred annotations, please do so here.


Letter Combinations of a Phone Number

Leetcode Question no. - 17
Problem name - Letter Combinations of a Phone Number
Instructions

Create a new folder for your script and file/folder name should be appropriate.
Create a README.md in your folder for program Instructions
add requirements.txt if needed

Programming Language

[x] Python

Happy Coding

Hi, could you assign this to me?


Ssalonen04022021

We have a new feature released yesterday (03.02.2021)in my.csc.fi portal -> 'Extend project' which needs documentation.
There will be more feature coming, for example close project, and they will be added to this page later on.

https://csc-guide-preview.rahtiapp.fi/origin/ssalonen04022021/


k_pivot

CCL should report in the documentation what k_pivot is assumed. This is relevant when the user sets A_s rather than sigma8.
Right now this is set to whatever the default of CLASS is. This is 0.05 Mpc^-1, but it could vary in future versions (or with other versions used by users). We could set it to 0.05 by hand to make sure that whatever we document will not vary with the CLASS version.

It could be included in ccl_params.ini but we need to make sure we pass it to CLASS correctly by adding an initialisation in `ccl_fill_class_parameters'.

This can now be set globally from python. Closing this issue.


Ability to add custom key bindings to the popup

Is your feature request related to a problem? Please describe.
It would be great if it was possible to change the default bindings found in clap_input.vim.  Not everyone would prefer to to use pagedown, <down>, <c-k>, etc. as they are defined in that file
Describe the solution you'd like
I'm not sure what the solution would be here.  One way I've seen this done is to assign a name to each of the bindings and then allow the user to add to a global map variable to pass in the keys they want for it.
Describe alternatives you've considered
Fork coc.nvim and change this file is the only way I see to do this

So you are using neovim? That would be not hard to get this, see https://github.com/liuchengxu/vim-clap/issues/116#issuecomment-549816638.

Ohh ok great, thanks!  Yes I'm using neovim so I'll just use the approach there.  Btw you might consider mentioning this in the Movement/Keybindings section in the docs.  This is where I looked first

Thanks for the suggestion. I'll add that to the docs when it's getting more stable. I'm not a fan of <Plug> things, and unlike neovim's floating_win, vim's popup is unfocusable, so I have not found a good way to add the custom key bindings.


Write explainer doc

Now that I've converted the spec into a DOM PR #19, I should to extract out the explanatory text and justification into a simple explainer doc.

Done


Add a list of components in the Readme

Hi! 👋
love what you are doing here. Maybe we can add a list of available components in the Readme for easy reference?

The components are already listed in the documentation, I think that's enough. https://hexdocs.pm/doggo/Doggo.html


Add VAT-percents to Django Admin

Description
Updates:

Add VAT to OrderItem list view
Add VAT to Order list view (get from first order item if it exists)
Add VAT to single Order view as read-only field
Format Refund VAT to two decimals

Context
PV-870
How Has This Been Tested?
Manually through Django Admin.
Manual Testing Instructions for Reviewers
Check that the updates are effective in Django Admin.
Screenshots

LGTM!


Hotfix of #6 and #7

Changes

Fix #6
Fix #7

@baumeier  as soon as things are a bit more stable I am going to include a comprehensive testing

@baumeier  as soon as things are a bit more stable I am going to include a comprehensive testing


Added Heltec Vision Master T190

See https://github.com/matthias-bs/BresserWeatherSensorReceiver/issues/203#issuecomment-2508963910

Pull Request Test Coverage Report for Build<PHONE_NUMBER>8
Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 100.0%

Totals

Change from base Build<PHONE_NUMBER>9:
0.0%

Covered Lines:
215

Relevant Lines:
215

💛  - Coveralls


User can add a bid to a name that shouldn't be in auction

Describe the bug
User can add a bid to a name that shouldn't be in auction
To Reproduce
Steps to reproduce the behavior:

Go to Auctions page on testnet
Click on yusufseyrek.chain
Add bid
See error

Expected behavior
A clear and concise description of what you expected to happen.
Screenshots
If applicable, add screenshots to help explain your problem.
Desktop (please complete the following information):

OS: MacOS
Browser  chrome
Version 123

Additional context
reproducible on dev branch

https://github.com/superhero-com/superhero-wallet/assets/69896204/16ce12dd-e983-43a9-8abb-7d94631a0a49

Connected to this iusse https://github.com/aeternity/ae_mdw/issues/509

Fixed. LGTM


[NDS] Monster Trucks DS (USA) graphic from the previous screen stuck on the title screen

start a one player game
race for a bit
the pause game then exit to the title screen and the truck and other graphics are still on the screen

from Desmume site
this game uses software rendered voxels. the game generates a depth buffer and passes it to the clear image hardware for the voxels to make geometry (cars, flags, etc.) rendered with the 3d engine to go in front of and behind. when exiting the main engine, the game does not clear its 3d memory. but it does set a depth buffer of frontmost on every pixel and continue passing it to the clear image hardware during the menu, which should prevent the cars from drawing.
the problem is that the real hardware renders 3d continuously, and changes to this depth buffer (which took effect while the screen was fading) happen immediately; whereas, in desmume, 3d renders only each time a frame is submitted by the 3d hardware. that means, in this case, that it never renders again, once the player enters the menu from in-game.
there are a few ways to fix this. one is to correctly emulate the constant-rendering that the hardware does. this is potentially somewhat costly.
next, the aforementioned approach could be made optional. while it fixes this one game, it isn't worth an option. if we find other games that need it, we may reconsider.
finally, we could detect the condition where flags have changed (even though the geometry has not) and take an opportunity to rerender, if so, each frame. But be careful--texture banks or contents may have changed also, since the geometry quit getting submitted, so all those conditions would have to trigger a re-render. I would prefer not to do this, since it is sort of bug city.
dont know if this helps ???

Yes, its definitely helpful


Automatically upload master to a cool subdomain

Something like "beta.elementaryos.org" would be cool

Will be especially important when doing anything server-side, like an email script.


flow_id in sender schema v1.0.x vs v1.1.x/v1.2.x

In v1.1.x and v1.2.x the flow_id of a sender can be null regarding the sender.json-schema. However, in v1.0.x only a valid uuid is allowed.
How to deal with this regarding the output of the Query API?
E.g. registering a v1.2 sender with flow_id: null, what should be the QueryAPI output if I GET <...>/query/v1.0/senders?
Should this resource be ignored for the output or should the resource be displayed even if the output of the API is not perfectly valid regarding the current active schema?
Both alternatives look a bit inconsistent in their own way..

Here's the relevant bits of a previous e-mail exchange I had with @andrewbonney.
At 20 June 2017 17:09, @garethsb-sony wrote:

How about the change that allows a Sender’s “flow_id” to be null in v1.1? When downgrading a v1.1 Sender with “flow_id”: null, what value should be used in a v1.0 representation of the Sender?

At 20 June 2017 17:14, @andrewbonney wrote:

The Sender flow_id one is unfortunate and I hadn’t clocked it as an issue until now. I don’t have a good solution to that off the top of my head, and our implementation (whilst I don’t think it ever sets that to null) would certainly produce an output that isn’t technically v1.0 valid at present.

Our implementation (sony/nmos-cpp) does the same; the sender will have "flow_id": null.

I should add, I'd be happy for the guidance to be omitting the offending Senders if preferred. Either way we should add this case to the docs - I'd clearly failed to log it as an issue on here previously.
I doubt there will be a massive number of v1.0 Query API clients developed at this point, but we should still aim to have a consistent approach.

I believe this was resolved by https://github.com/AMWA-TV/nmos-discovery-registration/pull/83 and will be resolved in the v1.2.x branch by https://github.com/AMWA-TV/nmos-discovery-registration/pull/91


Make job attachments optional

Coverage remained the same at 93.781% when pulling 540cabc97c4a9f40e50a322bda2fc246fde6617f on tgianos:optionalAttachments into b6d6b6a14da81fb25a60743687db966d38c2e1a7 on Netflix:4.1.x.


(maint) Remove dead scripts

The puppetlisten scripts were created to kick puppet agents remotely.
We removed kick functionality in Puppet 4, so these scripts are dead.
Also they do not establish the SSL connection correctly, so better to
remove them.

CLA signed by all contributors.


Unify sanity checks

Fixes #159
@Matrixcoffee /cc
@non-Jedi /cc

Signoff please and fix following PEP8 issues:

matrix_client/checks.py:8:1: E302 expected 2 blank lines, found 1
matrix_client/user.py:3:1: E302 expected 2 blank lines, found 1

Fixed PEP8, rebased and signed off

LGTM. Appreciate this. :)

Where else could potentially "dirty" room_id and user_id values be passed?
Should we add this to deprecated client.set_user_id or wait for it's removal?

Not sure, and I'm ambivalent on that one.

Great stuff.
Just one remark: Although room IDs should be fitted with a domain part on creation, those are only informational, and room IDs should be treated as opaque strings anywhere else. Since the domain part isn't actually used by anything, the utility of checking for it seems marginal at best, and it may cause trouble down the road.

How about an additional defaulted flag?
def check_room_id(room_id, require_domain=False):
We would then pass require_domain=True on creation.

While room IDs may one day be truly opaque and should in general be treated as such by clients, the spec currently says that room ids must have a domain part, so I think leaving the check as-is is reasonable until the spec is changed.


Main Window - Get Data button not working.

No response from scope.

Operational, really a setup issue.


Please review the content of the blog

Please review the content of the blog as below sections are mentioned twice in the same blog:

What is User Interface Integration?
What makes up Unified Service Desk?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 5d50e9f8-66b9-3919-2a5b-23b4eb646c82
Version Independent ID: 7eed3312-683f-dbaf-f55c-aae299114f57
Content: Overview of Unified Service Desk
Content Source: ce/unified-service-desk/admin/overview-unified-service-desk.md
Service: dynamics-365-customerservice
GitHub Login: @kabala123
Microsoft Alias: kabala

@amandeepsingh7 : Thanks for notifying. This has been fixed, and hence closing the comment.


Requesting additional functions from the Keyboard Manager.

Description of the new feature / enhancement
It would be nice to create a new shortcut that is different from the existing Ctrl+ combination and Shift+ combination such as Caps Lock.
Scenario when this would be used?
Using a 60% poker keyboard, I usually install another custom keyboard program to handle office work comfortably using a combination of Caps Lock + h, j, k, l, ;, u, i, o, p, [, W, A, S, D, etc.
WASD -> arrows
h, j, k, l, ;, u, i, o, p, [ -><PHONE_NUMBER>
It would be very convenient if you could use PowerToys without using other external programs.
Supporting information
No response

/dup #3326


[Firebase_Core] Using firebase with flutter web

I created a flutter web project and tried to add it to my firebase project. I followed the instructions provided here https://firebase.flutter.dev/docs/installation/web/.
When I do flutter run this error shows:
Error: [core/not-initialized] Firebase has not been correctly initialized. Have you added the Firebase import
scripts to your index.html file?
Here is the link to the repo: https://github.com/tnchoe98/firebase_core_test.git
Flutter doctor
[✓] Flutter (Channel stable, 2.2.2, on macOS 11.2.3 20D91 darwin-x64, locale en-US)
[✓] Android toolchain - develop for Android devices (Android SDK version 30.0.2)
[✓] Xcode - develop for iOS and macOS
[✓] Chrome - develop for the web
[✓] Android Studio (version 4.1)
[✓] VS Code (version 1.57.0)
[✓] Connected device (1 available)

• No issues found!

Flutter dependencies
Dart SDK 2.13.3
Flutter SDK 2.2.2
firebase_core_test 1.0.0+1

dependencies:
- cloud_functions 1.1.2 [cloud_functions_platform_interface cloud_functions_web firebase_core firebase_core_platform_interface flutter]
- cupertino_icons 1.0.3
- firebase_core 1.3.0 [firebase_core_platform_interface firebase_core_web flutter meta]
- flutter 0.0.0 [characters collection meta typed_data vector_math sky_engine]

dev dependencies:
- flutter_test 0.0.0 [flutter test_api path fake_async clock stack_trace vector_math async boolean_selector characters charcode collection matcher meta source_span stream_channel string_scanner term_glyph typed_data]

transitive dependencies:
- async 2.6.1 [meta collection]
- boolean_selector 2.1.0 [source_span string_scanner]
- characters 1.1.0
- charcode 1.2.0
- clock 1.1.0
- cloud_functions_platform_interface 5.0.7 [firebase_core flutter meta plugin_platform_interface]
- cloud_functions_web 4.0.9 [cloud_functions_platform_interface firebase_core firebase_core_web flutter flutter_web_plugins js]
- collection 1.15.0
- fake_async 1.2.0 [clock collection]
- firebase_core_platform_interface 4.0.1 [collection flutter meta plugin_platform_interface]
- firebase_core_web 1.1.0 [firebase_core_platform_interface flutter flutter_web_plugins js meta]
- flutter_web_plugins 0.0.0 [flutter js characters collection meta typed_data vector_math]
- js 0.6.3
- matcher 0.12.10 [stack_trace]
- meta 1.3.0
- path 1.8.0
- plugin_platform_interface 2.0.0 [meta]
- sky_engine 0.0.99
- source_span 1.8.1 [collection path term_glyph]
- stack_trace 1.10.0 [path]
- stream_channel 2.1.0 [async]
- string_scanner 1.1.0 [charcode source_span]
- term_glyph 1.2.0
- test_api 0.3.0 [async boolean_selector collection meta path source_span stack_trace stream_channel string_scanner term_glyph matcher]
- typed_data 1.3.0 [collection]
- vector_math 2.1.0

Hi @tnchoe98
What do you mean you followed the instructions in the documentation?
I don't see any of the script tags required to set up firebase for web in your index.html?
Thank you


[SPARK-8410][SPARK-8475] remove previous ivy resolution when using spark-submit

This PR also includes re-ordering the order that repositories are used when resolving packages. User provided repositories will be prioritized.
cc @andrewor14

Merged build triggered.

Merged build started.

Test build #36010 has started for   PR 7089 at commit a21f95a.

Test build #36010 has finished for   PR 7089 at commit a21f95a.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

OK, merging into master 1.4, thanks @brkyvz. Do we need a fix for 1.3 as well?


Fix new race in MockZipkinCollector

This race was introduced on the previous PR since HttpListenerException can still be raised if the _listener is disposed of but the code still tries to write to the output stream.

The active test run was aborted. Reason: Test host process crashed : Unhandled exception. System.Net.HttpListenerException (0x80131620): Unable to write data to the transport connection: Cannot access a disposed object.
Object name: 'System.Net.Sockets.Socket'..
   at System.Net.HttpResponseStream.InternalWrite(Byte[] buffer, Int32 offset, Int32 count)
   at System.Net.HttpResponseStream.WriteCore(Byte[] buffer, Int32 offset, Int32 size)
   at System.Net.HttpResponseStream.Write(Byte[] buffer, Int32 offset, Int32 size)
   at Datadog.Trace.TestHelpers.MockZipkinCollector.HandleHttpRequests() in /project/test/Datadog.Trace.TestHelpers/MockZipkinCollector.cs:line 201
   at System.Threading.ThreadHelper.ThreadStart_Context(Object state)
   at System.Threading.ExecutionContext.RunInternal(ExecutionContext executionContext, ContextCallback callback, Object state)
--- End of stack trace from previous location where exception was thrown ---
   at System.Threading.ThreadHelper.ThreadStart()


Add narative to the whisper notebook

Changes made by @scott-griffiths
Writing reviewed by @jaynie-gc and @payoto

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.


HTML DOM not updating

I used Vue JS to change the contents of html its not getting updated in html shader
Live Example https://goo.gl/YLdnPd

you forget material: ...; fps: 30

this issue may be closed

@WellanDraco Yes


Report HTML file has no results and no *.brick files are created after brick run

Hello,
I ran brick against a UEFI image I pulled using chipsec, and I'm seeing that the brick script runs successfully, but there are 0 results in the outputted html file.  I also don't see any *.brick files being created.  This seemed odd that there were no results at all, so I thought I would ask for guidance on where the *.brick files are written to the filesystem so I can debug the issue myself.  Thanks for your help.

I was able to get past this problem by making a small patch:
diff --git a/brick/ida/utils/brick_utils.py b/brick/ida/utils/brick_utils.py
index b40fb67..4535a0d 100644
--- a/brick/ida/utils/brick_utils.py
+++ b/brick/ida/utils/brick_utils.py
@@ -98,9 +98,9 @@ def temp_env():
     finally:
         os.environ = original_env

-try:
-    from builtins import execfile
-except NameError:
-    def execfile(fn, globals=None, locals=None):
-        return exec(open(fn).read(), globals, locals)
+# try:
+#     from builtins import execfile
+# except NameError:
+def execfile(fn, globals=None, locals=None):
+    return exec(open(fn).read(), globals, locals)

\ No newline at end of file

After applying this patch I see the brick files are created.
If this is a desired change I am happy to create a PR.  If not, I will close this issue.  Thanks!


Making the project DROPDOWN NAV BAR better with tailwindcss or Bootstrap

Creating the dropdown menu again.
Improving the UI

Good to go
CSS HTML m hai file to dekh Lena jesa sahi Lage
Assigned @Vansh-kash2023


Ghidra extension lib Dependency Management through Gradle

Is your feature request related to a problem? Please describe.
Ghidra extensions are built using Gradle, but the jars for external dependencies need to be placed in the lib folder manually.
Describe the solution you'd like
A modification to the GhidraBuild/Skeleton/buildTemplate.gradle file to include Gradle tasks that automatically copy the JARs into the lib folder.
Describe alternatives you've considered
Manually copying the dependency JARs over, as is the current workflow.
Additional context
I have a patch for this ready (which I wrote for my own Ghidra plugin's build process), but I am gauging interest in adding this feature first.

The intent was that if your extension requires a jar, you put it in the extension's lib directory and it will get automatically bundled.  When the extension gets installed into Ghidra, Ghidra knows to put anything found in lib directories onto the classpath.  Is this what you are referring to as placing them manually?

That was what I was referring to as "placing them manually". The patch that I have would allow the specification of dependencies in Gradle (e.g. downloading from MavenCentral), and would then copy those jars from Gradle's Jar storage location into the lib folder as part of the build process. If the dependencies were only specified in Gradle, the build would succeed, but Ghidra would throw errors due to being unable to find the dependency Jar at runtime.


Keyboard event updates - Shift Key Check, Capslock & e.code closer to browser

Added shift key check in keyboard event to use the shift key value of keyboard layout instead of key value.
The e.key value was ';' on keyCode 186 for instance, compared to the browser it would be ':'

I could not find an easy way to get the initial caps lock state, so this just toggles it every time and event with keyCode 20 is fired. I think it should work OK like this, unless you think there is a better way?

No, I don't think this is the right path. I'm guessing there is a way to handle this in native GLFW, but I haven't done that research.

Ok i added the caps + alpha check, I also changed it to take the keyCode straight from the keyboard layout file as that was again closer to the browser behavior and i also removed the first 10 entries from the keyboard layout for the digit keys - this allowed the shiftkey to behave correctly when pressing digit keys at the top but possibly means the same shift behavior for the numpad?? not sure i don't have a full keyboard to check handy.

I don't think any of this code should be in Javascript at all -- key handling is the role of the window system (GLFW in this case).
I suspect this doesn't detect an already-enabled capslock, or capslock triggered by the OS, amount other problems.
The correct fix is probably somewhere in the GLFW parameters or callbacks. Failing that, the fix should still probably be implemented close to GLFW bindings, not in the Javascript.

Closing this as discussed 👍

Actually I think there was good code here, just in the wrong place...


Request icons (console warning) with HTTP GET so webpack dev server doesn't 404

Fixes #1388
Additional description
Change url-exists to use GET instead of HEAD
Pull Request Review checklist (do not remove)

[ ] npm run lint:fix has been run and linting passes.
[ ] Mocha, Jest (Storyshots), and components/component-docs.json CI tests pass (npm test).
[ ] Tests have been added for new props to prevent regressions in the future. See readme.
[ ] Review the appropriate Storybook stories. Open http://localhost:9001/.
[ ] Review tests are passing in the browser. Open http://localhost:8001/.
[ ] Review markup conforms to SLDS by looking at DOM snapshot strings.
[ ] Add year-first date and commit SHA to last-slds-markup-review in package.json and push.
[ ] Request a review of the deployed Heroku app by the Salesforce UX Accessibility Team.
[ ] Add year-first review date, and commit SHA, last-accessibility-review, to package.json and push.
[ ] While the contributor's branch is checked out, run npm run local-update within locally cloned site repo to confirm the site will function correctly at the next release.

Thanks @celador !


Allow creating new artifacts from artifact swap UI

Describe your changes
In ArtifactSwapModal.tsx:

Added "Add New Artifact" button to the artifact swap UI underneath the page selector which opens up the artifact editor with the slot selector disabled - This maintains parity with the rest of the site where the general order of buttons is filters then page/sort option selectors and then the "Add New" button.

In ArtifactEditor.tsx:

Added fixedSlotKey as an optional prop for ArtifactEditor - This is used to set the slot if the slot dropdown is disabled.
Modified the logic surrounding assigning slotKey and newValue.slotKey (inside update) to account for the slot dropdown being disabled

Issue or discord link

Resolves https://github.com/frzyc/genshin-optimizer/issues/1252

Testing/validation
Current UI with the "Add New Artifact" button

Artifact Editor when opened through the artifact swap UI

Database showing the artifacts that were added

Checklist before requesting a review (leave this PR as draft if any part of this list is not done.)

[x] I have commented my code in hard-to understand areas.
[x] I have made corresponding changes to README or wiki.
[x] For front-end changes, I have updated the corresponding English translations.
[x] I have run yarn run mini-ci locally to validate format and lint.
[x] If I have added a new library or app, I have updated the deployment scripts to ignore changes as needed

Converting to draft, I hadn't realized disabling the slot in the artifact editor currently locks artifact creation to flowers only, which isn't quite the behavior I want.
(Alternatively, I don't bother locking the slot at all and someone can just create a full set in one go and then go through the individual slots to equip the new artifacts.)

Fixed, should be ready for review.
The Randomize button currently bypasses slot locking in the artifact editor, not going to bother with it since it's a dev-mode only feature anyway.

https://genshin-optimizer-prs.github.io/pr/1501/frontend/

Committed your syntax change, this PR should be good to go then.

I think we can look into removing disableSlot in favor of fixedSlotKey prop in a future PR.

I haven't lined up more issues from the list to tackle yet, so I can definitely look at this next.


[Feature] Quick actions button [move up, move down, remove] on tab items

Is your feature request related to a problem? Please describe.
No, it is not related to a problem. Currently, in order to move or delete a list item in the Work Experience, Education, Hornor, and Certification tab. It requires to expand the item first, which is not that convenient.
Describe the solution you'd like
Add quick action buttons on the list item card
Describe alternatives you've considered
Implement Drag/Drop functionalities to move items.

Have you been working on it? I am planning to work on this problem from today.

@BenChenDev not yet. I am still thinking about the design for it. Before you work on this item, please tell me how you plan to implement it or what it suppose to look like.


BaseRouter.todo raises not implemented

So this appears to make things completely unusable as the NotImplementedError of BaseRouter.todo always raises NotImlementedError
router.py#L41-L43
Where are you going with all that? Do you need me to implement something there?
Nick

How do you use it? BaseRouter is kind of abstract. Currently, Router (file router exactly) is mostly supported.

My main goal was is to store migrations within the application. This is most easily done by providing them in as proper python modules. It simplifies the setup.py and makes it easy to access the migrations after the module has been installed from any python module.
Also because they are modules they do not need to be parsed and run... This makes debugging a migration just like any other python module as well as quickly highlights import errors and other runtime things.
Also not that it matters too much but you can import logging or other modules and they should behave as expected since you are operating within the standard python execution flow.
Simplified example:
Assume:
myapp/migrations/init.py
myapp/migrations/0_1_0.py
myapp/migrations/0_2_0.py
myapp/migrations/0_6_1.py
myapp/migrate.py
from peewee import *
from peewee_migrate.router import ModuleRouter
DB = Proxy()

DB.initialize(connect('sqlite:///mydb.db'))
router = Router(DB, migrate_module='myapp.migrations')

for migration in ('0_1_0', '0_2_0', '0_6_1'):
    router.run(migration)

More verbose example:
Gist

Honestly I would recommend moving to this for the cli as well since you can just specify which python module to import like:
peewee_migrate --module 'myapp.migrations.semantic' --min '0.1.2' --max '3.0.0'
pretty much any migrations directory can be a module by adding the init.py

Back to the BaseRouter... when I added my logic it didn't have those NotImplementedError calls... I am thinking you want intend to define the methods that raise NotImplementedError in each subclass is that correct?

Actually, I did a lot of updates since your last PR. I think you need to reinvestigate how it works and update ModuleRouter as well.


Initial action of Datasource  and custom code

Hello,
Is there any sample code for initial ‘custom code’ section to read data from Postgres db table(the payload is taken from ‘initial Request Payload) and update the panel elements values accordingly?
Your configuration.sql example would be my preference.
The documentations only have custom code for ‘Query’ as the initial acton and nothing for ‘Datasource’
regards
Nima

Hi, @nimaforoughi
In documentation we have description for Datasource witth initial custom code
1)https://volkovlabs.io/plugins/volkovlabs-form-panel/data-flow/#data-source
2) https://volkovlabs.io/plugins/volkovlabs-form-panel/data-flow/#initial-request-custom-code
and reference to code snipets here
Let us know if this solves your problem or not.

thank you Vit,
But the page you are talking about only has a screenshot for my type of question which is not working. That’s why I am looking for a working snip of the code.
I have written the below code to read the response from postgres Datasource and parses the id and values then put it the payload.
my payload finally will be like an object with key and values.
But nothing shows on the panel elements, but they turn red only.
The keys of the payload are exactly matching the elements ids
the elements in the panel are multi select.
Can you please assist to diagnose it.
const payload = {};

elements.forEach((element) => {
  if (!element.value) {
    console.log("no value", element.id)
    payload[element.id] = element.value;
    return;
  }
  console.log('found')
  payload[element.id] = element.value;
})

console.log('payload', payload)
// setInitial(payload)

// Get the first frame from the response
let frame = response.data.results.A.frames[0];
// Iterate over the fields in the response
frame.schema.fields.forEach((field, index) => {
  // If the field name exists in the payload
  if (payload.hasOwnProperty(field.name)) {
    // Assign the corresponding values to the payload
    payload[field.name] = frame.data.values[index];
  }
});

console.log('payload after analysis', payload);

setInitial(payload)
console.log('done')
return;

Hi, @nimaforoughi
setInitial(payload) sets the initial value but does not change the value in the element.
Therefore, when updating and using setInitial, the values in the elements are not changed, but the initial state is changed.
Exmaple:

and Custom Code
I hardcoded testPayload for an example of what happens (in your code sample the same thing happens)

After that my form elements highlights  in red color, which shows that the value of the element is different from the initialial value

when I click on submit button I see my initial values

But I believe your goal is to set values for the elements
I made a new panel. I added three multi select elements. Added options for the sample. And set up an initial query.

Put some code for initial code and use onChangeElements. onChangeElements - set up values on elements.
After adding the code you will see that the values obtained from response will be set.

const contextElements = context.panel.elements

if (context.panel.response) {
  const frame = context.panel.response
    .data.results.A.frames[0]

  // map values from response
  const framevalues = frame.schema.fields.map((value, index) => ({
    field: value.name,
    value: frame.data.values[index]
  }))

// new Elements with values
  const newElements = contextElements.map(element => {
    const frameElement = framevalues.find(frElem => frElem.field === element.id)
    return ({
      ...element,
      value: frameElement.value[0]
    })

  })
  console.log('newElements ', newElements)
  // use onChangeElements
  context.panel.onChangeElements(newElements)
}


Provide method to override exception type for auth filters

Raised for consideration regarding the discussion in #4213.

@jplock did you leave this for me to merge or do have any concerns for holding this back?

Thanks 👍


e2e tests for batteries

This PR extends e2e tests to detect when batteries break.
As suggested, this PR covers just the basic implementation with a test only for the monetization battery. The tests for the other batteries will be added by this other PR https://github.com/getAlby/lightning-browser-extension/pull/1028 at a later time.
EDIT: i've added some code to test if the extension is built and also to skip the e2e batteries test (with a warning) if the extension is built only in production mode. This is to avoid breaking current scripts in case they are expecting to test the extension by building only the production mode.

❤  First up, thanks for your awesome work! 🚀
Takes some time to wrap my head around it.
So far I did not try it locally just yet.
I made some general questions-kinda comments first. Have a look and let me know if something isn't clear please.
Further general points:
Linting
Looks like we should add the tests directory to these npm-scripts:
"lint:js": "eslint src --ext .js,.jsx,.ts,.tsx --max-warnings 0",
"lint:js:fix": "eslint src --ext .js,.jsx,.ts,.tsx --fix",
"format": "prettier --check 'src/**/*.(js|ts|jsx|tsx)'",
"format:fix": "prettier --loglevel silent --write 'src/**/*.(js|ts|jsx|tsx)'",

To make sure we have an aligned format/linting throughout the important code.
Could you give that a try?
If it's too complicated to fix upcoming issues let me know. I can support with that.
JS doc
We don't really need to jsdoc comments. We have TypeScript for this.

Thanks for the review.
Linting
I am not sure how to fix the linting and formatting since i've never used these tools.
But since this is not related to this PR it think it should be fixed with a separated commit by someone who knows how, i can rebase the pr on top of that.
JS doc
I've been asked to comment my code, how am i supposed to do it then?

I am not sure how to fix the linting and formatting since i've never used these tools. But since this is not related to this PR it think it should be fixed with a separated commit by someone who knows how, i can rebase the pr on top of that.

Added eslint/prettier. Please have a look and see if everything still works as expected.

I've been asked to comment my code, how am i supposed to do it then?

I think it's less about the function attributes but on how to actually use these special injected mock-functions during development. As mentioned here. You can remove the jsdocs comments.
You did an awesome job with this PR coming up with a special idea on how to tackle battery testing. I'm worried if the concept of you idea is not well documented it will be hard to maintain or hard to be used by others.
I can also give it a try, extend the README and you check my draft and correct it. What do you think?

I can also give it a try, extend the README and you check my draft and correct it. What do you think?

Sure, fine by me.  Imo this is not needed since it is an internal api as i commented here, but extra documentation doesn't hurt, it is just that i am not sure how to write it (i am bad with documentation).


Optimize icelake validate_utf32 for small inputs using masked AVX512 instructions

Modified the validate_utf32 function to avoid using scalar loop for tail processing and to obtain the result using masked AVX512 instructions. Seems to speed up small inputs as observed below:
Before the changes:
validate_utf32+icelake, input size: 48, iterations: 1000, dataset: temp
   2.521 ins/byte,    0.542 cycle/byte,   10.139 GB/s (15.1 %),     5.492 GHz,    4.654 ins/cycle
  11.000 ins/char,    2.364 cycle/char,    2.323 Gc/s (15.1 %)     4.36 byte/char      4.7 ns

After the changes:
validate_utf32+icelake, input size: 48, iterations: 1000, dataset: temp
   1.333 ins/byte,    0.271 cycle/byte,   20.357 GB/s (1.8 %),     5.513 GHz,    4.923 ins/cycle
   5.818 ins/char,    1.182 cycle/char,    4.665 Gc/s (1.8 %)     4.36 byte/char      2.4 ns

Seems reasonable, merging.


Priority of messages

RabbitMQ supports priority for messages for a half of a year already. They added this feature to implement AMQP 0-9-1 spec and consider it very useful. I know what is written in MassTransit's documentation about priorities but it was written several years ago and the situation is different now. What about supporting priorities too?

Thank you for adding this feature. As I can see SendContext now has SetPriority method, but how can priority be set with Publish method?


[WIP] Improve docs

Description

Enhance documentation
Checklist

[ ] Screenshots added for any UX changes
[ ] Demos attached for animations/interactions
[ ] Pointed at proper branch (develop not main)
[ ] Assigned PR to yourself
[ ] Requested review from code owners
[ ] Relevant labels added (feature, documentation, etc.)
[ ] Closes #<issue-number> added if this resolves a GitHub issue
[ ] Branch is up to date with develop, ran git rebase develop if necessary
[ ] All GitHub Actions are passing
[ ] npm run todo-ci ran if any todo comments were created

Closes #705

I don't have a specific line to comment on for this - but these docs outline in great detail exactly what contributors would need to do, which isn't inherently bad.
However, for the sake of simplicity and being welcoming - should we consider being a little more vague?
a very MINIMAL example:
Welcome to Streamability! To contribute, open a pull request from a fork and we'll review it in a timely manner.

Branching strategy <ticket#>-<branch-name>

we use prettier and ES lint on pre-commits. You can run `npm run lint` and `npm run lint-fix`

Again, this is a very minimal example and we'd obviously include more than just this - but I think this approach is a little less overwhelming. I think it's reasonable to assume that legitimate contributors can navigate Git and GitHub to the degree that we're looking for.
With that being said, I think this is great regardless, and anyone seriously considering contributing I would assume wouldn't mind taking the time to read through this.


Working with symlinks

Is it possible to push a symlink? Now it results in pushing an empty file.

It is, symlinks should not matter.
$ cd ~/my_drive
$ ln -s ~/Desktop/test.txt
$ drive push test.txt

In fact one of the push methods push -m uses symlinks in order to push content that isn't present in your drive, but you'd like to push from an arbitrary path on your file system. A sample usage is:
$ cd ~/my_drive/tests
$ drive push -m ~/Desktop/content ~/angstrom .

If this persists would you mind giving drive version, OS, go version, as well as a screenshot of a test?

It doesn't automatically follow symlinks though:
     $ cd ~/mydrive
     $ drive push somefolder

The result is a file in Drive called somefolder. It's a 0 byte binary file where it should be a folder containing file.

Unfortunately I cannot reproduce this, even going by your steps. Please see the screenshot attached. Maybe I am missing something

What version of drive are you using? What OS?

Your example works for me too. The problem is actually when there is a symlink inside a subdirectory. In my case:
$ ls -lrth dim
   lrwxrwxrwx 1 root root 62 Mar  9 22:20 appm -> /home/ari/Dropbox/wits/appm
$ ls -lrth dim/appm
   -rwxrwxrwx 1 root root 302K Feb 25 18:54 LectureNotes_Student_1.pdf
   drwxrwxrwx 1 root root 4,0K Mar  4 21:52 lab2
$ drive push -ignore-conflict dim
   Resolving...
   X /dim/lab2
   + /dim/appm
   Clashing modification count 1 src: 92.00B
   Addition count 1 src: 62.00B

This results in the problem I described. I also tried drive push dim/appm but then I get errors like
/dim/appm/LectureNotes_Student_1.pdf: googleapi: Error 400: Parent is not a folder: 0B2gbvqIBh4KaMDhyczFQUTN5eE0, invalid

It would be great if you could give me information like the version of drive, OS and any other information, as previously requested.

Sorry forgot to add it's drive 0.1.1 (from Github) on Linux Mint 17.1 x64.

Alright, I'll look at it when I get home in about 10 hours.

Okay, so ReadDir when given a directory does not resolve the symlinks if they are directories. You can try to reproduce this even on your system by doing
$ mkdir -p a/b
$ mkdir -p ~/Desktop/z1/z2 && ls ~ > ~/Desktop/z1/z2/listing.txt
$ ln -s ~/Desktop/z1/z2 a/b
$ ls -R a # Should print only z2 and nothing inside it

This to me is on the OS and not a bug on drive's part. Of course I could try to mitigate this but what happens when the next user who expects system dependent behaviour?

You know what, never mind, I'll just include this in the README with caution to the user.

Please pull from master, and try again.

Fixed by https://github.com/odeke-em/drive/commit/9579c283031d6a3c47ea821371180511ed4c66be with a contribution form @geniass. Thank you very much. Reopen if persists.


Incomplete stack on Windows

When tracking down a segfault, I got a stack trace that only appears to be the callback, and not the faulting stack:
PID 7492 received SIGSEGV for address: 0x13f23b0
SymInit: Symbol-SearchPath: '.;', symOptions: 530, UserName: 'administrator'
OS-Version: 6.1.7601 (Service Pack 1) 0x112-0x3
6C8228EC (segfault-handler): (filename not available): (function-name not available)
6C821617 (segfault-handler): (filename not available): (function-name not available)
773C223E (ntdll): (filename not available): RtlGetProcessHeaps
773AB806 (ntdll): (filename not available): RtlCaptureContext
773AB4C6 (ntdll): (filename not available): RtlMoveMemory
77360133 (ntdll): (filename not available): KiUserExceptionDispatcher

Any ideas why I can't see the offending stack?

Is this everything which got printed?
Since for me it shows some more lines, but only the addresses.
The fault is that the underlying library is searching for the .pdb files (containing the symbol informations on windows) in the wrong directories for me.
(or maybe the node grpc package - which is failing for me - is missing those I dont know).


Fix/random seed simple

This addresses a fix for random failures in the TestRandomstrings and TestRandomHugeStrings. It seems that in the tight loop using the same Random variable creates some issues "randomly". This was not repeatable using a seed so my guess is it is due to the threads or some other concurrency within the subfunctions.
I did a lot of work to prove that the outputs from RandomAnalysisString where consistent. The issue was CheckAnalysisConsistency and I didnt see an obvious or even obscure reason why it would fail.
I havent run into any test fails so far but that doesnt mean there isnt one in the next run.

FindFirstFailing and Seed attribute files allow to specify a particular seed to run a test under

Its a bit strange, but although this seems to have fixed the TestRandomStrings tests for TestICUFoldingFilter and TestThaiAnalyzer, the TestThaiAnalzyer::TestRandomHugeStrings() test still fails. But digging into it, they both terminate in the same place, the only difference is the maxWordLength parameter is increased.
I suspect we may have a difference in behavior somewhere in TestUtil.RandomAnalysisString(Random, int, bool) that may be causing some rare weirdness. Sadly, TestUtil has no tests to verify the behavior is doing what it should be doing.
TestUtil.RandomAnalysisString() is also called by Lucene.Net.Analysis.NGram.EdgeNGramTokenizerTest::TestFullUTF8Range() and Lucene.Net.Analysis.NGram.NGramTokenizerTest::TestFullUTF8Range(), both which are also randomly failing. Perhaps one of the paths that TestUtil.RandomSubString() is going down is broken, which would explain the randomness. I suggest to divide and conquer - keep excluding the random paths until you find the one that causes the failure to stop happening. That would probably be a bit quicker than reviewing every one of those methods and comparing them against the Java implementation.

Its a bit strange, but although this seems to have fixed the TestRandomStrings tests for TestICUFoldingFilter and TestThaiAnalyzer, the TestThaiAnalzyer::TestRandomHugeStrings() test still fails. But digging into it, they both terminate in the same place, the only difference is the maxWordLength parameter is increased.
I suspect we may have a difference in behavior somewhere in TestUtil.RandomAnalysisString(Random, int, bool) that may be causing some rare weirdness. Sadly, TestUtil has no tests to verify the behavior is doing what it should be doing.
TestUtil.RandomAnalysisString() is also called by Lucene.Net.Analysis.NGram.EdgeNGramTokenizerTest::TestFullUTF8Range() and Lucene.Net.Analysis.NGram.NGramTokenizerTest::TestFullUTF8Range(), both which are also randomly failing. Perhaps one of the paths that TestUtil.RandomSubString() is going down is broken, which would explain the randomness. I suggest to divide and conquer - keep excluding the random paths until you find the one that causes the failure to stop happening. That would probably be a bit quicker than reviewing every one of those methods and comparing them against the Java implementation.

I am not seeing the failing tests for TestRandomHugeStrings - can you rerun and perhaps send the seed failing? Ive run this several times and havent hit this issue. However, maybe this is because im using the FindFirstFailingSeed attribute - this sets NUnit.Framework.Internal.Randomizer.InitialSeed and NUnit.Framework.Internal.TestExecutionContext.CurrentContext.CurrentTest.Seed to the same seed which are not under normal conditions.
RandomAnalysisString is producing the same result each time, I verified this by writing the hashed outputs to a file with the iteration and comparing them on subsequent runs. All identical. I can include this code in the pull request if you want to review?
I will take a look at those other tests now (Lucene.Net.Analysis.NGram.EdgeNGramTokenizerTest::TestFullUTF8Range()/Lucene.Net.Analysis.NGram.NGramTokenizerTest::TestFullUTF8Range())

Seems both these tests call RandomUnicodeString which is predictably failing on the same seed. This one is solvable i think.

I will take a look at those other tests now (Lucene.Net.Analysis.NGram.EdgeNGramTokenizerTest::TestFullUTF8Range()/Lucene.Net.Analysis.NGram.NGramTokenizerTest::TestFullUTF8Range())

There's no need. This has been patched already in #316.

I will take a look at those other tests now (Lucene.Net.Analysis.NGram.EdgeNGramTokenizerTest::TestFullUTF8Range()/Lucene.Net.Analysis.NGram.NGramTokenizerTest::TestFullUTF8Range())

There's no need. This has been patched already in #316.

Ack I wish I had checked my email earlier, this does seem to fix the error. I had found a seed that failed but didnt understand why. I suspected IncrementToken() but clearly not the issue

Adding this before the test runs
NUnit.Framework.Internal.Randomizer.InitialSeed = NUnit.Framework.Internal.TestExecutionContext.CurrentContext.CurrentTest.Seed;
seems to stop the tests erroring. Is this hiding something tho? If there is one random using a different seed, this shouldn't cause an issue.

Adding this before the test runs
NUnit.Framework.Internal.Randomizer.InitialSeed = NUnit.Framework.Internal.TestExecutionContext.CurrentContext.CurrentTest.Seed;

seems to stop the tests erroring. Is this hiding something tho? If there is one random using a different seed, this shouldn't cause an issue.

Before the test runs how? I tried adding it to the beginning of the test and it didn't seem to make a difference.
I took a deep dive into this and there were several contributors causing these tests to fail.

The culture sensitivity was broken by the change of default when we switched to J2N.Character in 4.8.0-beta00008 without specifying CultureInfo.InvariantCulture. Fixed in #321.
The ThaiWordBreaker wasn't set up to handle surrogate pairs, so would fail when there were surrogate pairs in the random input. Fixed in #322.
Something is causing ThaiAnalyzer to fail when using concurrency. This one I haven't found the cause, but being that the behavior changed when I added a .Clone() to each of the prototypes, I suspect the issue lies in ICU4N.RuleBasedBreakIterator where it loads the Thai break engine. Adding locking also seems to make it fail less, but it still does occasionally. We need to add some concurrency tests to ICU4N for BreakIterator when using Thai to see if we can make it fail - there were no tests for concurrency in ICU4J.

There doesn't appear to be anything wrong with BaseTokenStreamTestCase, but when I commented out the concurrency check inside CheckAnalysisConsistency(), I ran the TestRandomHugeStrings() and `TestRandomStrings() tests 10000 times in a row each without a failure. Putting the concurrency check back in makes the failure happen after a few hundred runs.

The concurrency issue with ICUTokenizer has now been temporarily addressed in #328.
As for changing the Random class instantiation, there doesn't seem to be any effect when doing it this way. I am closing this because it doesn't address the issues described in #288. Of course, we should have a FindFirstFailingSeed feature to assist with debugging, but depending on what random number generator implementation we use, it may need to be very different than the one here.


Fix the bug of reading NA string as NaN in exists_qlib_data.

Fix the bug of reading string NA as NaN of exists_qlib_data in \qlib\utils_init_.py.
Description

Changed the default reading behavior of pd.read_csv and removed two values from the default NA list.
Motivation and Context

To fix the bug in #1720.
How Has This Been Tested?

[X] Pass the test by running: pytest qlib/tests/test_all_pipeline.py under upper directory of qlib.
[X] If you are adding a new feature, test on your own test scripts.

Screenshots of Test Results (if appropriate):

Pipeline test:

Your own tests:

Place the attached file all.txt under \qlib_data\us_data_made\instruments and test with the following code

import qlib
import pandas as pd
import sys, site
from pathlib import Path
from qlib.utils import exists_qlib_data
from qlib.constant import REG_US

scripts_dir = Path.cwd().parent.joinpath("scripts")
provider_uri = "./qlib_data/us_data_made"  # target_dir
if not exists_qlib_data(provider_uri):
    print(f"Qlib data is not found in {provider_uri}")
    sys.path.append(str(scripts_dir))
    from get_data import GetData

    GetData().qlib_data(target_dir=provider_uri, region=REG_US)
qlib.init(provider_uri=provider_uri, region=REG_US)

Types of changes

[X] Fix bugs
[ ] Add new feature
[ ] Update documentation

@microsoft-github-policy-service agree

@SunsetWolf Hey, can I ask why all tests from sources other than slow failed? Do I need to take care of this? Thank you.


Docs send to #undefined anchor

Migrated from GitLab: https://gitlab.com/meltano/meltano/-/issues/3467
Originally created by @vischous on 2022-05-09 13:54:59

Go to docs.meltano.com
Search something, like "Getting Stated
Click the link, it sends you to https://docs.meltano.com/getting-started#undefined

Undefined anchor on the page. Not a huge deal it just threw me for a second today.

View 1 previous comment from the original issue on GitLab

This is happening again for me, I thought this was fixed but maybe it wasn't


Namespace removed from d3-node-editor/src/index.d.ts

Is there a reason the namespace was removed from the typescript definition after v0.6.10?
I'm using in angular and after updating it caused missing namespace errors for D3NE.

Do you use
/// <reference path="../../../node_modules/d3-node-editor/src/index.d.ts"/>

?
Try simply import * as D3NE from "d3-node-editor"; and TS will import index.d.ts under the specified namespace

https://github.com/Ni55aN/D3NE-examples/commit/5a7071052a2e8321c97d8a3ab1394643e685cf47

Ah! Yes, importing it with the alias fixes that issue.
Having additional webpack related issues due to the changes but I'll troubleshoot before asking.

Is the problem solved? Can I close the issue?


setColumnWidth() does not seem to do anything immediately

Issue
Is there a way to immediately apply setColumnWidth()? In its current state, the column needs to disappear from view in order for the width to be applied.
Attempted solutions
I've already tried requestLayout(), forceLayout(), invalidate(), and a combination of them on the TableView to no avail.
Further info/context
Here's a gif to illustrate. I've set column 3 to 800px using setColumnWidth(), but it does not update until it disappeared from view.

I've found that setColumnWidth() only works with indexes based on the actual table, and not my data's index.
For example, I have columns {0, 1, 2, 3, 4}. I hid column 2. The visible columns would then be {0, 1, 3, 4}.
If I wanted to resize column 3, I would need to call setColumnWidth(2), where 2 is the visible position of column 3.
Maybe this info helps someone out.

Good catch!
I've submitted #376 to fix this issue.


Enhances cli-output-mode doc, Closes #4117

This PR enhances the cli-output-mode doc by adding info about the csv output mode.
It also improves the json & text array output description by changing "getting the list of available app" to "getting the list of available apps".
Closes #4117

Thank you @nicodecleyre
We'll try to review it ASAP

merged manually


Update introducing-jsx.md

This is a proposed change to the  element code. The original includes a closing  tag but the img HTML element is a self-closing empty element.
The original is: const element = ;
My proposed change is: const element = ;
P.S. Thank you so much for the awesome guides! I am learning a lot from it 👍🏻

Seems like a valid ask.
Even MDN specifies Tag omission | Must have a start tag and must not have an end tag.
https://developer.mozilla.org/en-US/docs/Web/HTML/Element/img#technical_summary
@gaearon your  thoughts?

The syntax is in JSX and not HTML. Seems like in HTML you might not need a closing tag and self-close it. But in JSX there is no technical difference between a self-closing tag and a closing tag.


docker111: add 1.11.2 bottle.

[X] Have you followed the guidelines in our Contributing document?
[x] Have you checked to ensure there aren't other open Pull Requests for the same formula update/change?

[X] Does your submission pass brew audit --strict --online <formula> (after doing brew install <formula>)?
[X] Does your submission adhere to Versions "Acceptable Formulae" guidelines?

Please remove docker110 as part of this PR and the bottle-block here (it'll be regenerated when we pull). Thanks!

ok done

Thanks for your contribution to Homebrew!  You rock!


How to properly credit iD in a written guide

Hello,
We are writing a quick guide to mapping as PDF file so people can download from a site. To achieve that, we are using screenshots of the user interface and feature icons (those in /svg/) to illustrate the guide.
How to give credit? It seems a part of the icons are from Font Awesome (under CC-BY 4.0), Maki and Temaki (both under CC0) while iD's source code is under ISC license.
Regards,

I started recently very similar discussion for JOSM screenshots - https://lists.openstreetmap.org/pipermail/josm-dev/2021-March/thread.html#8396 (what may be a bit helpful as most considerations are similar)
OSM Wiki is using https://wiki.openstreetmap.org/wiki/Template:ID_screenshot (though OSM Wiki approach to handling file licensing is substandard - and I am trying to improve it a bit)


Serveur adress in public description

The adress of the discord serveur "La compagnie de l'hydromel" is currenly in the public description of the repository.
I dont think this is a good idea...

Will delete it but i was thinking someone that wanna help create the bot could join and test the bot on the server we can discuss later maybe


expanded README?

Would like to know a bit more on how to get this running? from the main.go I only see variables for us-east-1 but no AWS account id or credentials, how does it know to forward to timestream?
The documentation is a bit lacking, is there anyway to get this working? Was successful in building docker image and also via go and running it listening on 9201. Created prometheus db and table in timestream but no data shows up.

Hi @htsoi-boto, you can use environment variables, a ~/.aws/credentials file or an IAM Role/Policy to access your timestream database.

Hi @htsoi-boto, you can use environment variables, a ~/.aws/credentials file or an IAM Role/Policy to access your timestream database.

Awesome, will try it out. Thanks!

Awesome, will try it out. Thanks!


Valid names in ontology entities (classes, relations, diagrams, etc.)

The files' names must contain only valid characters for Windows and Linux directory paths. The Visual Paradigm allows the creation of diagrams with invalid characters, like ":" - in this case, the generated image is going to have an invalid path name. The substitution has impact on the VPP, JSON, PNGs and TTL files (specific and general for this last one).

Functionality implemented.