Docs for 1.20-1

Issue #, if available:
Description of changes:
HOLD UNTIL RELEASE
TODO

[ ] Update changelog with component versions
[ ] Update index.md with crd
[ ] Update release announcement with specifics
[ ] Update pull-all.sh with versions for 1-20

All of these todo items will be resolved once we figure out the component versions

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

/hold

Closing because I ended up having to change a lot, there were merge conflicts, and it was bad. Reopening in different PR on different branch


Updates submodule ref.

Strange merge conflict when trying to merge datatables-search-sort to master. I had to defer to its notion of where the submodule was supposed to be in order to merge.
This left it one commit behind reality for the actual submodule master commit.
Committing to bring them back into sync.

:+1: verified that this is the TOT I see.

Current coverage is 70.71%

Merging #350 into master will not affect coverage as of e49cf47

@@            master    #350   diff @@
======================================
  Files           84      84
  Stmts         2718    2718
  Branches         0       0
  Methods          0       0
======================================
  Hit           1922    1922
  Partial          0       0
  Missed         796     796

Review entire Coverage Diff as of e49cf47

Uncovered Suggestions

+0.63% via goldstone/views.py#30...46
+0.60% via ...stone/drfes/views.py#134...149
+0.38% via .../drfes/pagination.py#34...43
See 7 more...

Powered by Codecov. Updated on successful CI builds.


[WIP] add /test command to pipelines

Description
This PR adds a /test command to avoid unwanted testing.
Fixes #(issue)
How Has This Been Tested?

[ ] E2E

/test

/test

/merge


StackOverflowException when using a DI container that supports variance.

Describe the bug
I am the author and maintainer of the LightInject DI library and we discovered something strange when upgrading one of our AspNetCore projects to netcoreapp2.2 and setting the compabilitylevel to 2_2.
Then we started to see a StackoverflowException at startup and as fun it is to debug these kind of exceptions, we still managed to track it down to Microsoft.Extensions.Options.IOptions<Microsoft.AspNetCore.Routing.EndpointOptions> recursively being requested from the container causing the StackoverflowException
The object graphs are pretty deep here and we spent a day or so trying to figure out what was going on. I noticed that there are some IEnumerable<T> being injected into the services down the object graph and then it suddenly hit me that this might be related to variance.
A couple of examples just to illustrate what this means.
public interface IFoo<out T> {}

public class FooWithBar : IFoo<Bar> {}

public class FooWithDerivedBar : IFoo<DerivedBar> {}

public class Bar {}

public class DerivedBar : Bar {}

When requesting a IFoo<Bar> from LightInject, it will return 2 instances, FooWithBar and FooWithDerivedBar since they are compatible
For instance we can do this
IFoo<Bar> fb = new FooWithDerivedBar();

Note: Not trying to explain variance here. Just setting the scene.

This feature is very powerful and has worked great up until AspNetCore 2.2 where we now have to turn off support for variance in LightInject (through an option) in order to avoid the StackoverflowException.
I know that this feature is not supported, at least not yet, in MS.DI, but it seems a little strange to require the DI adapter to disable support for variance.
I don't know of this was intentional, but it is maybe something to be aware of as it seems that proper support for open generics might find its way into MS.DI as well according to this PR.
https://github.com/aspnet/Extensions/pull/536
We got around the problem by disabling variance in LightInject, but that also disables a very powerful feature. At the very least there should be a test for this over at the extensions repo that states this requirement. The requirement being that variance is not supported.
The best solution would be to fix this in AspNetCore so that it does not rely on non-variant behaviour.
To Reproduce
Steps to reproduce the behavior:

Using this version of ASP.NET Core '2.2'
dotnet new webapi
UseLightInject() (using the LightInject.Microsoft.AspNetCore.Hosting package)
See error

Expected behavior
Not to throw a StackoverflowException

This is almost certainly connected to using InProcess mode by default in 2.2. CLR inherits stack size of w3wp.exe which is 512K in 64 bit version and 256K in 32bit one.
Seems like LightInject create much deeper stacks when variance is enabled and hits the limit.

@pakrym I am not so sure we are hitting the stack size limit here because of a deep graph.
In my repro project I see this before we die
https://github.com/seesharper/lightinject_aspnetcore2_2
Microsoft.Extensions.Options.IOptions`1[Microsoft.AspNetCore.Routing.EndpointOptions]
Microsoft.Extensions.Options.IOptions`1[Microsoft.AspNetCore.Routing.EndpointOptions]
Microsoft.Extensions.Options.IOptions`1[Microsoft.AspNetCore.Routing.EndpointOptions]
Microsoft.Extensions.Options.IOptions`1[Microsoft.AspNetCore.Routing.EndpointOptions]
Microsoft.Extensions.Options.IOptions`1[Microsoft.AspNetCore.Routing.EndpointOptions]
Microsoft.Extensions.Options.IOptions`1[Microsoft.AspNetCore.Routing.EndpointOptions]
Microsoft.Extensions.Options.IOptions`1[Microsoft.AspNetCore.Routing.EndpointOptions]
Microsoft.Extensions.Options.IOptions`1[Microsoft.AspNetCore.Routing.EndpointOptions]
Microsoft.Extensions.Options.IOptions`1[Microsoft.AspNetCore.Routing.EndpointOptions]
Microsoft.Extensions.Options.IOptions`1[Microsoft.AspNetCore.Routing.EndpointOptions]
Microsoft.Extensions.Options.IOptions`1[Microsoft.AspNetCore.Routing.EndpointOptions]
Microsoft.Extensions.Options.IOptions`1[Microsoft.AspNetCore.Routing.EndpointOptions]
Microsoft.Extensions.Options.IOptions`1[Microsoft.AspNetCore.Routing.EndpointOptions]
Process is terminating due to StackOverflowException.

It looks like it is recursively trying to resolve that service.
Disable variance here and everything is fine.
https://github.com/seesharper/lightinject_aspnetcore2_2/blob/54c2c9dc59e4a87e073558c307e455cbd577f234/LightInject.Microsoft.DependencyInjection.cs#L176-L180
The point I am trying to make here is that the MS.DI specification tests should cover this. If the case is that containers must disable variance, there should be a test that checks this.

@rynowak @JamesNK thoughts?

@seesharper I would like to avoid forcing container authors to actively disable features to pass our spec test.
So first I want to figure out how exactly enabling variance is turning Microsoft.Extensions.Options.IOptions1[Microsoft.AspNetCore.Routing.EndpointOptions]into circular reference. Is it possible to dump which type is being activated to satisfyMicrosoft.Extensions.Options.IOptions1[Microsoft.AspNetCore.Routing.EndpointOptions] service request?

Yeah, I'll have a look at this tomorrow 👍

On the top of my head I think it was the OptionsFactory

There is some IEnumerable's being injected there

The trouble starts at OptionsFactory
https://github.com/aspnet/Extensions/blob/release/2.2/src/Options/Options/src/OptionsFactory.cs
The type being requested is OptionsFactory<Microsoft.AspNetCore.Routing.EndpointOptions>
Injection the following dependencies.
System.Collections.Generic.IEnumerable<Microsoft.Extensions.Options.IConfigureOptions<Microsoft.AspNetCore.Routing.EndpointOptions>>
System.Collections.Generic.IEnumerable<Microsoft.Extensions.Options.IPostConfigureOptions<Microsoft.AspNetCore.Routing.EndpointOptions>>
System.Collections.Generic.IEnumerable<Microsoft.Extensions.Options.IValidateOptions<Microsoft.AspNetCore.Routing.EndpointOptions>>
Later down the graph there is a request for
System.Collections.Generic.IEnumerable<Microsoft.AspNetCore.Routing.EndpointDataSource>
With variance enabled it brings back two types
Microsoft.AspNetCore.Routing.EndpointDataSource
AND
Microsoft.AspNetCore.Routing.CompositeEndpointDataSource
Maybe this is where it starts.
The Microsoft.AspNetCore.Routing.CompositeEndpointDataSource again has a
System.Collections.Generic.IEnumerable<Microsoft.AspNetCore.Routing.EndpointDataSource> dependency which is probably where things starts to become recursive.
So the the elefant in the room seems to be System.Collections.Generic.IEnumerable<Microsoft.AspNetCore.Routing.EndpointDataSource> noyt only bringing back Microsoft.AspNetCore.Routing.EndpointDataSource, but also Microsoft.AspNetCore.Routing.CompositeEndpointDataSource .

Looks like you are right. Resolution path that breaks is ConfigureEndpointOptions -> IEnumerable<EndpointDataSource> --> CompositeEndpointDataSource -> IOptions<EndpointOptions> -> ConfigureEndpointOptions.
Worth noting that in 3.0 things work again because registration pattern changed.
Nevertheless, we don't expect or plan for the behaviour of variance resolution so this might happen again with some other component.
I think we should add a spec test for this case.

Some kind of test that attempts to resolve every registered service with a DI framework that supports variance would be ideal.

Where are we going to put such a test?

I don't know. It is kind of a framework level functional test.
My point of view is it is better to put a fence at the top of the cliff, and have test that checks all registered services and prevents this before we release, than wait until something blows up and add fixes and tests as bugs come in. Right now there is zero test coverage of resolving ASP.NET registered services when using variance, correct?
Another option would be to have an app that uses most of the popular features of ASP.NET Core, use a DI framework with variance, and have functional tests run on it.


docs.tmijs.com not docs.tmijs.org

The documentation link at the top of https://github.com/tmijs/docs/blob/gh-pages/_posts/v1.4.2/2019-03-03-index.md is incorrect and sends you to the wrong page  (docs.tmijs.org)  not docs.tmijs.com. Normally, I wouldn't post an issue for such a trivial error but it seems the person who owns docs.tmijs.org has malicious intentions.

this could be a very quick PR....
also very good first issue for someone to fix........ but im gonna just fix it my self 😂


[Question] Warning "changing an uncontrolled input of type text to be controlled." when using custom inputComponent

Hi,
Currently I'm trying to plug a custom inputComponent to the TextField's inputComponent property. I hooked up the ref={inputRef} and value field, etc. However, whenever I started to type stuff in the input field, the warning showed up.

Warning: A component is changing an uncontrolled input of type text to be controlled.
Input elements should not switch from uncontrolled to controlled (or vice versa).
Decide between using a controlled or uncontrolled input element for the lifetime of the component.

To be clear, I understand what this warning means. Basically I was trying to update the input's value property from undefined to some string, resulting in converting the uncontrolled input to the controlled one.
I have been struggling with this for hours, but still haven't figured out the solution yet. I looked at the source code of Input.js in material-ui project, and it seems like I did the same logic in my code.
Could you help me take a look at my code snippet and see if you can give me some hints on how to properly hook up the input element in my custom inputComponent?
Thanks!
(You can ignore the typescript types :-))
Definition:

const InputComponent = (props: IInputComponentProps & InputProps & WithStyles<classList>) => {
  const { classes, typeAheadText, inputRef, ...rest } = props;
  return (

      {typeAheadText &&
{typeAheadText}
}
      <input ref={inputRef} {...rest} />

  );
};

Usage:

render() {
    const {
      downshiftControllerStateAndHelpers,
      disabled,
      typeAheadText,
      textFieldProps
    } = this.props;
    const { getInputProps } = downshiftControllerStateAndHelpers;
    return (
      <TextField
        {...getInputProps({
          disabled,
        })}
        InputProps={{
          startAdornment: this.startAdornment(),
          endAdornment: this.endAdornment(),
          inputComponent: InputComponent,
          fullWidth: true, // TODO: test
        }}
        inputProps={{
          typeAheadText
        }}

        {...textFieldProps}
      />
    );
  }

I encountered the same issue. Switching the default prop value from null to '' fixed the issue.

@franklixuefei You will experience the very same issue with a native <input> element.
import React from 'react';
import { render } from 'react-dom';

class App extends React.Component {
  state = {
    value: undefined,
  };

  handleChange = event => {
    this.setState({
      value: event.target.value,
    });
  };

  render() {
    return <input value={this.state.value} onChange={this.handleChange} />;
  }
}

render(<App />, document.getElementById('root'));

https://codesandbox.io/s/qynj01z96
@jpetitcolas's solution is great 👌.


[WIP]Speed up nftables via batching

Fixes https://github.com/crowdsecurity/cs-firewall-bouncer/issues/114 .
The backend interface has one more method Commit . This method is supposed to be called to actually commit changes to the system, instead of relying Add and Delete methods. Only nftables currently follows this while other modes still work.
nftables now instead of calling Flush for each Add or Delete does the following:

Compare decision stream with current state. Decisions are filtered off if their ip is already present (for new decision) or if ip is absent(decision is expired)
The filtered decisions are then batched into size of 200 (arbitary for now TBD) and Flush is called only once per batch

Benchmark TODO

Hi @sbs2001 is it necessary to remove the duplicates or is it an additional feature?

@jarppiko  nftables doesn't permit inserting duplicate IPs in single batch. It also errors if the item being inserted is already present in set.

@jarppiko nftables doesn't permit inserting duplicate IPs in single batch. It also errors if the item being inserted is already present in set.

This issue with importing duplicates has been partly fixed in nftables. Importing duplicates in a single batch does not cause errors with recent nftables, but if there is an existing rule, it does not update it.
# cat ip-blocklist-duplicate-test.csv
value
<IP_ADDRESS>
<IP_ADDRESS>
<IP_ADDRESS>
<IP_ADDRESS>
<IP_ADDRESS>
<IP_ADDRESS>
<IP_ADDRESS>
<IP_ADDRESS>
# cscli decisions import  --reason "Test" --duration 3h -i ip-blocklist-duplicate-test.csv
INFO[01-02-2022 02:19:03 PM] 8 decisions successfully imported
#

And var/log/crowdsec-firewall-bouncer.log shows:
time="01-02-2022 14:19:06" level=debug msg="adding '<IP_ADDRESS>' for '2h59m56.957743109s'"
time="01-02-2022 14:19:06" level=debug msg="adding '<IP_ADDRESS>' for '2h59m56.957741101s'"
time="01-02-2022 14:19:06" level=debug msg="adding '<IP_ADDRESS>' for '2h59m56.957740476s'"
time="01-02-2022 14:19:06" level=debug msg="adding '<IP_ADDRESS>' for '2h59m56.957740058s'"
time="01-02-2022 14:19:06" level=debug msg="adding '<IP_ADDRESS>' for '2h59m56.957739793s'"
time="01-02-2022 14:19:06" level=debug msg="adding '<IP_ADDRESS>' for '2h59m56.957739377s'"
time="01-02-2022 14:19:06" level=debug msg="adding '<IP_ADDRESS>' for '2h59m56.957739125s'"
time="01-02-2022 14:19:06" level=debug msg="adding '<IP_ADDRESS>' for '2h59m56.957738878s'"
time="01-02-2022 14:19:06" level=info msg="8 decisions added"
time="01-02-2022 14:19:06" level=debug msg="committed 8 decisions"
time="01-02-2022 14:19:06" level=info msg="committed 8 added decisions, 0 deleted decisions"

So the question is whether this import behavior is for upstream of crowdsec to fix.  What do you guys think?


fix: add url to plugin-add in readme

The opposite of https://github.com/danhper/asdf-python/pull/58. What's the reason for having the URL? This extension is a known extension and can be installed just by name without the URL.

Must not have updated asdf when I saw this error. 👍🏼


v3 release with updated dependencies?

Looks like v3-dev has been used for years with no major issues. Maybe it is time to cut a release?!

@Mihailoff I couldn't agree more. I'm pretty deep in another project right now, but I'll add this to my list to accomplish next.


Adds Front-End iOS Practice docs

This adds docs for the Front-End iOS Practice, addressing the biggest question: why do we have a separate iOS practice? I followed the format of the Front-End Practice docs and added what made sense for us.
I'm going to leave this PR unassigned and leave it open for a while, RFC-style. Take your time providing feedback.

Looks great!

Cool, let's merge 👍


Container width customisable

Hello,
First of all, thanks for creating such a wonderful library.
I am referring to the 'nested' demo example. I believe that example can have container width either 50% or 100%. Is there a straight forward way of controlling the width of the child container?
Thanks,
Vishal

I am able to resize the container-element with following css,
resize:both;
overflow:auto;
However, if I make the container-element less than 50% then although there is space next to it, I am unable to drag-drop another container.
This requirement is fairly standard to have resizable container / item columns, where the width of each cannot extend the parent width and increments in steps of 1 column wide. Pretty much something like a Bootstrap grid.
Any help, would be deeply appreciated !


Documentation does not reflect how the rotation of certificate happes in this case

[EDIT by guardrex to add the metadata]

Issue moved from MicrosoftDocs/feedback#3098

Please respond to @khandelwalbrijesh.

From @khandelwalbrijesh on Tuesday, September 8, 2020 12:25:44 PM
Is your feature request related to a problem? Please describe.
I am following the documentation here which shows how to do https certificate binding in asp.net app inside docker. We are using the same approach in our production containers but It is not explained here what happens when certificate is rotated. What is the best way to configure the rotation here? Will it work by simply updating the certificate at the location ASPNETCORE_Kestrel__Certificates__Default__Path. Or there is something else needs to be done here.
Internally, does this way of binding certificate uses ServerCertificateSelector while doing the binding so, the certificate can be updated after the owner of the app updates the certificate at the ASPNETCORE_Kestrel__Certificates__Default__Path location?
Describe the solution you'd like
Need some guidance on the best way to configure the autorotation here
Describe alternatives you've considered
We are considering to bind the certificate from the code and use Server Selector while doing so, the certificate will get updated without crashing.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: abf7806c-d9e4-1811-3308-b5efb6f159f0
Version Independent ID: 2117dfa1-9e6d-2bc2-2348-e792f3c81806
Content: Hosting ASP.NET Core image in container using docker compose with HTTPS
Content Source: aspnetcore/security/docker-compose-https.md
Product: aspnet-core
Technology: aspnetcore-security
GitHub Login: @ravipal
Microsoft Alias: ravipal

Issue moved from MicrosoftDocs/feedback#3098

Please respond to @welcome[bot].

From @welcome[bot] on Tuesday, September 8, 2020 12:25:45 PM
Thank you for creating the issue! One of our team members will get back to you shortly with additional information. If this is a product issue, please close this and contact the particular product's support instead (see https://support.microsoft.com/allproducts for the list of support websites).

Thank you for contacting us. Due to a lack of activity on this discussion issue we're closing it in an effort to keep our backlog clean. If you believe there is a concern related to the ASP.NET Core which hasn't been addressed, please file a new issue.


Tab emits strange character?

Problem Description
I have a simple tab control that is emitting a Â character with no obvious reason why. The character  disappears depending on what kind of content is in the tab. Adding multiple tabs causes the character to be carried with the highlighter for which tab is selected. I'm using babel to transpile, but the output seems harmless.
app.jsx:
import React from "react";
import ReactDOM from "react-dom";

import injectTapEventPlugin from 'react-tap-event-plugin';
injectTapEventPlugin();

import Tabs from 'material-ui/lib/tabs/tabs';
import Tab from 'material-ui/lib/tabs/tab';

var temp = (
    <Tabs>
        <Tab label="test">

Hello world

        </Tab>
    </Tabs>
);

ReactDOM.render(temp, document.getElementById("app"));

I've included the output html as well, you can see the character getting inserted with a div:
output.txt
Versions

Material-UI: 0.14.4
React: 0.14.7
Browser: Latest chrome & firefox

I tried recreating the issue in the examples project.

i did not face any issue.
heres my code:
Main.js
/**

In this file, we create a React component
which incorporates components providedby material-ui.
*/

import React from 'react';
import RaisedButton from 'material-ui/RaisedButton';
import Dialog from 'material-ui/Dialog';
import {deepOrange500} from 'material-ui/styles/colors';
import FlatButton from 'material-ui/FlatButton';
import getMuiTheme from 'material-ui/styles/getMuiTheme';
import MuiThemeProvider from 'material-ui/styles/MuiThemeProvider';
import Tabs from 'material-ui/tabs/tabs';
import Tab from 'material-ui/tabs/tab';
const muiTheme = getMuiTheme({
palette: {
accent1Color: deepOrange500,
},
});
class Main extends React.Component {
render() {
const standardActions = (

);
return (
  <MuiThemeProvider muiTheme={muiTheme}>
   <Tabs>
    <Tab label="test">

Hello world

    </Tab>
   </Tabs>
  </MuiThemeProvider>
);

}
}
export default Main;
app.js
import React from 'react';
import ReactDOM from 'react-dom';
import injectTapEventPlugin from 'react-tap-event-plugin';
import Main from './Main'; // Our custom react component
//Needed for onTouchTap
//Can go away when react 1.0 release
//Check this repo:
//https://github.com/zilverline/react-tap-event-plugin
injectTapEventPlugin();
// Render the main app react component into the app div.
// For more details see: https://facebook.github.io/react/docs/top-level-api.html#react.render
ReactDOM.render(, document.getElementById('app'));
Also I would suggest upgrade to the latest version of MUI
I am closing this as this is not an issue with the library. Leave a comment below if you have any further issues.


Add clarification about JSONPath syntax to doc

Backport https://github.com/apache/druid/pull/13574 to release branch.

Closing this as Druid 25.0 is already released.


Jquery-growl doesn't parse <>

Jquery-growl doesn't parse <> which causes html tags to be executed in the dom.
POC:
$.growl.error({message:"<script>alert(1)</script>"});

+1

This is by design. It allows you to display images, custom HTML, etc. If you are displaying input from a user in the growl you'll need to sanitize it.
http://stackoverflow.com/questions/24816/escaping-html-strings-with-jquery


A mistranslation in the Japanese Tutorial

Hi!
I found a mistranslation in https://qiskit.org/documentation/locale/ja_JP/tutorials/noise/8_tomography.html#１量子ビットの状態トモグラフィーの例 .
１量子ビットの状態トモグラフィーの例 (= a translation of 1-qubit process tomography example)  must be １量子ビットのプロセストモグラフィーの例.
How should I correct it?

This is wrong place of opening this issue. The correct place is here -> Qiskit/qiskit-tutorials.

Thank you very much. I close this.


Led display oob

I optimized the LedDisplayClient to have a local buffer. Way too many packets were being dropped in the current implementation.  See OOB for usage of LedDisplayClient.

OK. Can you implement this logic after I've pushed for the OOB?

yup


Feat:improve hover effect in nav bar

Describe the feature
the pinkish hover effect doesnot suite with the page theme.
will make it more enhancing.
@Its-Aman-Yadav please assign this me.
Add ScreenShots

Record

[X] I agree to follow this project's Code of Conduct
[X] I'm a GSSOC'24 contributor
[X] I want to work on this issue

@Kalivarapubindusree please look after this and assgin this to me.


Fixed URL used by curl in overlay readme

Signed-off-by: Matt Bentley<EMAIL_ADDRESS>

LGTM, thanks.

LGTM


Don't rely on Warp always being in /Applications, use bundle identifi…

Description
Don't rely on Warp always being in /Applications, use bundle identifiier instead. Fixes #7555.

Well if you don't want this PR you only had to say.

@schwa why did you close the PR? I was referring to the wrong path that seems wrong.


$.format conflict

in line 582 of v1.9.0 of the validation plugin, there appears to be a case where the .format method was not properly renamed.
it reads:
message = jQuery.format(message.replace(theregex, '{$1}'), rule.parameters);
where I believe it should be:
message = $.validator.format(message.replace(theregex, '{$1}'), rule.parameters);
As is, it causes conflicts if another plugin has defined $.format
Apologies if this is a duplicate of an open issue; I searched and found none.

Thanks for the catch! Fixed.


Erro when doing npm install on Linux Mint 18.3

npm ERR<EMAIL_ADDRESS>install: node-gyp rebuild
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>install script 'node-gyp rebuild'.
npm ERR! Make sure you have the latest version of node.js and npm installed.
npm ERR! If you do, this is most likely a problem with the pty.js package,
npm ERR! not with npm itself.
npm ERR! Tell the author that this fails on your system:
npm ERR!     node-gyp rebuild
npm ERR! You can get information on how to open an issue for this project with:
npm ERR!     npm bugs pty.js
npm ERR! Or if that isn't available, you can get their info via:
npm ERR!     npm owner ls pty.js
npm ERR! There is likely additional logging output above.
npm ERR! Please include the following file with any support request:
npm ERR!     /root/pegaswitch/npm-debug.log
gyp: binding.gyp not found (cwd: /root/pegaswitch) while trying to load binding.gyp

npm ERR! Please include the following file with any support request:
npm ERR! /root/pegaswitch/npm-debug.log

npm-debug.log

@dpronyaev in package.json, remove the line containing pty.js and insert     "node-pty": "^0.7.4", instead, then reinstall pegaswitch. Please let us know if it works...

Pull latest master and try again. Please re-open the issue if you're still having problems.


Component

make them, style, them, make them look okay, add in inputchange and handleform submit in the contact section

DONE! Honestly could've been split into a lot more issues, but i eneded up pushing 14 commits in a single branch... not good


Relay initialization should be a privileged action

The relay is currently initializable by anyone, we should only allow root to do this to prevent abuse - this is only a problem after genesis therefore does not affect already running chains.

I think the best would be to set this in the genesis state. This is a trusted operation anyway.


No need to disable TLS in boot2docker anymore.

This fixes #505 . Before this, we would use the docker.NewClient, instead of docker.NewTLSClient,
since no certPath was provided. Also we now provides the path to the ca.pem.

Nice. This works well for me :+1:.

Nice!


Allow for extra env vars in fluentd helm chart.

Is your feature request related to a problem? Please describe.
Hello, I m trying to add some env vars to the fluentd pod trough the helm chart of the fluent-operator.
I see that that feature exists in the fluentbit template but not in the fluentd one.
Describe the solution you'd like
I see here https://github.com/fluent/fluent-operator/blob/master/pkg/operator/sts.go#L144-L146 that fluentd supports the addition of extra environment variables by adding the EnvVars is it possible to have that added in the template here https://github.com/fluent/fluent-operator/blob/master/charts/fluent-operator/templates/fluentd-fluentd.yaml in the same way that is added in the fluentbit template?
Thanks :)
Additional context
No response

Yes，it is the same, you can refer here https://github.com/fluent/fluent-operator/blob/master/apis/fluentd/v1alpha1/fluentd_types.go#L60


Messenger doesn't keep me logged in

Not a problem with my account because I use Messenger for Mac on my desktop, and it keeps me logged in. On my MacBook Pro, it doesn't keep me logged in after I quit out of the app and relaunch it.

Had the same problem.
Logged out, reinstalled Messenger, but didn't work.
Deleted Messenger with all it's library, cache, pref files etc with AppDelete, then reinstalled... Now OK.
Here are the deleted files from the log:
/Applications/Messenger.app
/Users//Library/Caches/me.rsms.fbmessenger
/Users//Library/Cookies/me.rsms.fbmessenger.binarycookies
/Users//Library/Preferences/me.rsms.fbmessenger.plist
/Users//Library/WebKit/LocalStorage/https_www.messenger.com_0.localstorage
/private/var/db/BootCaches/<LONG STRING HERE>/app.me.rsms.fbmessenger.playlist
/Users//Library/Application Support/com.apple.sharedfilelist/com.apple.LSSharedFileList.ApplicationRecentDocuments/me.rsms.fbmessenger.sfl
Hope that helps.


Reimplement dependency graph using Mermaid

Explanation

Rely on GitHub's Mermaid integration to render the dependency graph instead of Graphviz, and update it to incorporate the packages that have been added recently. This prevents developers from needing to install Graphviz in order to regenerate the graph.
👉 See rendered version 👈
References

(none)
Changelog

(none)
Checklist

[x] I've updated the test suite for new or updated code as appropriate
[x] I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
[x] I've highlighted breaking changes using the "BREAKING" category above as appropriate

@legobeat Hmm, what sort of overlap do you mean?
There are different requirements for the extension and this repo that we have to keep in mind. In this case we are interested in producing a graph of packages that this repo houses. Since each package corresponds to a workspace, we can use Yarn's workspaces feature to find all of them. In the extension, however, we are interested in files, so we have to use madge to find all of them.

^ Rebased & squashed to resolve conflicts.


Typescript RequestInformation Headers and Options

Replace Headers: Map<string, string> with Records<string,string>;

In TypeScript objects are generally used when keys are only strings (or numbers, the numbers are silently converted to strings) Maps are considered inconvenient and mildly slower than objects, so records are preferred over maps.

Request libraries in Javascript (axios, undici, node-fetch) commonly use Record type to store headers in their typings.

Request Options should consider and document the use of specific request configurations such as:
Axios : https://axios-http.com/docs/req_config
Fetch Request Options : https://developer.mozilla.org/en-US/docs/Web/API/Request#properties
https://github.com/microsoftgraph/msgraph-sdk-javascript/pull/105

Sorry for backtracking on this one, but after doing some more research on the subject, I don't think we should switch to records

After reading through some of the other http libraries implementation, I really would love to bring that back up for discussion. Converting between Maps to Records on every call seems tedious and will add unnecessary maintenance. Could we agree to go the simpler way for this one to allow focusing on more critical areas? Today, developers are used to Record in almost any http library they are using with Typescript... Let's aligned with the overall community.

export type Headers = Record<string, string | string[] | undefined>;
https://github.com/sindresorhus/got/blob/6eb0fd3a2ccb9545ccc662f44fa1adf7d7cc4da8/source/core/options.ts#L56

export type AxiosRequestHeaders = Record<string, string | number | boolean>;
export type AxiosResponseHeaders = Record<string, string> & {
"set-cookie"?: string[]
};
https://github.com/axios/axios/blob/1163588aa288160282866057efcaef57dbbe417b/index.d.ts#L3

export type HeadersInit = Headers | Record<string, string> | Iterable<readonly [string, string]> | Iterable<Iterable>;
<EMAIL_ADDRESS>

export type HeadersInit = Iterable<[string, string]> | Record<string, string>
https://github.com/nodejs/undici/blob/5d524231ff0fcb8dac761fd710fa08d7d61b1c26/types/fetch.d.ts#L45

type HeadersInit = string[][] | Record<string, string> | Headers; (Fetch definition in TypeScript)
https://github.com/microsoft/TypeScript/blob/main/lib/lib.dom.d.ts#L18725

Again, despite all the advantages Map can have against Object, there is still cases Object will perform better. After all, Object is the most basic concept of Javascript.
Object is the great choice for scenarios when we only need simple structure to store data and knew that all the keys are either strings or integers (or Symbol), because creating plain Object and accessing Object’s property with a specific key is much faster than creating a Map (literal vs constructor, direct vs get() function call — you know who wins already).

https://medium.com/front-end-weekly/es6-map-vs-object-what-and-when-b80621932373

If we are only using string-based keys and need maximum read performance, then objects might be a better choice.

https://dev.to/faisalpathan/why-to-use-map-over-object-in-js-306m

Thanks for the additional evidence. Please go ahead and make the changes in the generator and abstraction/core libraries.


FIX: transform data in find_events for v0

[Current coverage][cc-pull] is 90.48%

Merging [#223][cc-pull] into [master][cc-base-branch] will increase coverage by +<.01%

@@             master       #223   diff @@
==========================================
  Files             7          7
  Lines           869        872     +3
  Methods           0          0
  Messages          0          0
  Branches        144        146     +2
==========================================
+ Hits            786        789     +3
  Misses           52         52
  Partials         31         31

Powered by Codecov. Last updated by [dea5ba5...c8c7241][cc-compare]
[cc-base-branch]: https://codecov.io/gh/NSLS-II/metadatastore/branch/master?src=pr
[cc-compare]: https://codecov.io/gh/NSLS-II/metadatastore/compare/dea5ba55f003615b2d9b4a077c9e805e44f57253...c8c7241a2b88f797f0ba9c7382210ad51cb1c4b5
[cc-pull]: https://codecov.io/gh/NSLS-II/metadatastore/pull/223?src=pr


Use gRPC for SCIOND API

Using gRPC instead of our custom RPC + capnp serialization would yield several benefits:

context.Context support for RPC calls directly from the gRPC library;
cleaner RPC cancellations;
native support for error handling (we don't have a way of propagating server errors right now; it's not hard to add, but we'd get it out of the box with gRPC)
no more reliable socket;
less custom code needed, as a big chunk of the client and server API will be generated from rpc definitions;

The capnp message formats should be ported to protobufs.
It is ok that this is a breaking change (but it is breaking only to the scope of an AS anyway, so as long as ASes are deployed one at a time this is ok).


Remove file server image on plugin uninstall

We brought the file server image to the user's machine during install. Lets remove it when the plugin is being uninstalled.

how would you know the customer does not use the same image out of shared-volume context ?

We can't. I guess we can let the image be there and the user can remove it if no longer needed. Closing the issue.


fetchAssoc does not return expected result

Here is the products.csv file
product_code	name        type	id_group	sku	barcode	unit_price quantity_unit
120	            Product1	Type1	2	        KB1	1111111	11000	   pc
121	            Product2	Type2	2	        KB2	2222222	15000	   kg
122	            Product3	Type3	2	        KB3	3333333	20000	   gr
123	            Product4	Type4	2	        KB4	4444444	30000	   pc

Here is the code
use League\Csv\Reader;
$reader = Reader::createFromPath('uploads/products.csv');
$keys = $reader->fetchOne();
$data = $reader->fetchAssoc($keys);
echo '<pre>', print_r($data, 1), '</pre>';

Here is the result
League\Csv\Modifier\MapIterator Object
(
    [callable:League\Csv\Modifier\MapIterator:private] => Closure Object
    (
        [static] => Array
            (
                [keys] => Array
                    (
                        [0] => product_code
                        [1] => name
                        [2] => type
                        [3] => id_group
                        [4] => sku
                        [5] => barcode
                        [6] => unit_price
                        [7] => quantity_unit
                    )

                [keys_count] => 8
            )

        [this] => League\Csv\Reader Object
            (
                [stream_filter_mode:protected] => 1
                [path:protected] => uploads/products.csv
                [open_mode:protected] => r+
                [delimiter:protected] => ,
                [enclosure:protected] => "
                [escape:protected] => \
                [newline:protected] =>

                [encodingFrom:protected] => UTF-8
                [input_bom:protected] =>
                [output_bom:protected] =>
                [iterator_filters:protected] => Array
                    (
                    )

                [iterator_sort_by:protected] => Array
                    (
                    )

                [iterator_offset:protected] => 0
                [iterator_limit:protected] => -1
                [strip_bom:protected] =>
                [stream_filters:protected] => Array
                    (
                    )

                [stream_uri:protected] => uploads/products.csv
                [stream_regex:protected] => ,^
    php://filter/
    (?P:?read=|write=)?  # The resource open mode
    (?P.*?)           # The resource registered filters
    /resource=(?P.*) # The resource path
    $,ix
            )

        [parameter] => Array
            (
                [$row] =>
            )

    )

)

But according to the documentation the expected result should be:
http://csv.thephpleague.com/reading/
[
      [
             'product_code' => '120',
             'name' => 'Product1',
             'type' => 'Type1',
             'id_group' => '2',
             'sku' => 'KB1',
             'barcode' => '1111111',
             'unit_price' => '11000',
             'quantity_unit' => 'pc',
       ],
       ...
]

Reader::fetchAssoc returns an Iterator since version 8.0 has stated in the documentation. So using a simple foreach on the result of the method call should return the expected results.
I can update the example to highlight that. It's a legacy of version 7.0 :+1:

Oh my. I missed that part. Works fine. Thank you for your response.

the documentation examples have been updated to highlight the change of return type.


Can't show latest dates in Looker for aggregates

Currently with Looker, there are certain score cards, but they can only aggregate doing things like min, max, mean, etc. It's not currently able to get things like the latest value by date. Need to investigate how to solve this, otherwise certain important metrics just won't be calculable.

Adding the Latest Portfolio Value with 0737f7b actually doesn't work, as the spark line is tracking the Portfolio Value, if we change it to it simply becomes a flat line.

This seems to have been fixed by having a scorecard to show the numeric value (with Latest Portfolio Value), then creating a sparkline chart underneath which is using Portfolio Value.

The previous fix only works for the front page, for other pages where there are date filters it doesn't work. We may need to investigate further how the joins work and how we can get it to do what we want.

This seems to be a problem where you can't filter for the max date, relative to the current drill down. We can try to move this to Streamlit, and we can get a new POC going, will open a new issue for this. Closing this issue as of now.


baserow: 1.14.0 -> 1.17.2, baserow-front: init at 1.17.2, nixos/baserow: init, nixos/tests/baserow: init

Description of changes
This brings Baserow to nixpkgs properly.
Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

@lilyinstarlight Building baserow.ui here will fail and I am not able to determine why right now.


Kanban submission

Hi,
We are a team of three
@richardoppiyo Team member #1
@franciscoPonceDev  Team member #2
@franciscoPonceDev Team member #3
Project

Hi,
Your project is complete!  There is nothing else to say other than... it's time to merge it :shipit:
Congratulations! 🎉
Highlights

The Pull Request has a proper title and description. ✔
You have added a descriptive Readme file. Good Job. ✔
There is no linter error is present. ✔
Project has met all the technical aspects you needed for this project. Keep rocking! ✔

Optional suggestions
Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will really improve your application.
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.

As described in the Code reviews limits policy  you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.


Ignore instant as input to loot tracker

Deserializer used in Spring is unable to deserialize Instant.
Signed-off-by: Tomas Slusny<EMAIL_ADDRESS>

This waas solved in better way in https://github.com/runelite/runelite/commit/fe2eba06a70737528daea372a26283ded5ae654e


link: extra space before link text

Hi,
When
You want add a cross reference like ([Software Architecture]({{% ref "/softwareArchitecture.md" %}}))  an extra space is added
Actual output
text before ( Software Architecture) text after -> extra space after the (
Expected output
text before (Software Architecture) text after -> no space after the (

Thanks for reporting. This is now fixed.


Could not plan the operation missing path

I have a federated graph using a version of the federation example as my gateway.
Most of my backends extend the Company-type and add fields to it.
Some queries now fails with the below error but not all and I see no pattern to which fail and which succeed. In some cases it's even different for queries which target the same backend that behaves differently.
internal: bad datasource configuration - could not plan the operation. missing path: [query.company.__typename]
What might be the problem? What can I do to provide more information to identify the problem?

Reverting back to github.com/wundergraph/graphql-go-tools/v2 v2.0.0-rc.46 seems to make it behave correctly again.

Can you publish a test or example that triggers the issue?

Would love to. Not sure really were to begin since I'm not sure what is causing the problem though. Currently looking through the diff between rc.46 and rc.49 to get some kind if hint. :-)

Hi @argoyle
will it be possible for you to share subgraphs involved in your query and query itself?

Sure thing.
 Company!
}

accounting-service schema:
directive @goField(
  forceResolver: Boolean
  name: String
) on INPUT_FIELD_DEFINITION | FIELD_DEFINITION

type Company @key(fields: "id") @extends {
  id: ID!
  entrySeries: [EntrySeries!]! @goField(forceResolver: true)
  fiscalYears: [FiscalYear!]! @goField(forceResolver: true)
}

type EntrySeries {
  id: ID!
  name: String!
}

type FiscalYear {
  id: ID!
  start: String!
  end: String!
}

I have six other subgraphs which also extend the Company type in an identical manner but with other fields of course.

I noticed this in the diff between rc.46 and rc.49:

Could it be that the planning visitor is being used by multiple requests at the same time somehow and the objects and field become reset mid-planning in some of the requests?

Hmmm, no, there is a mutex before that of course. It's iterating until it has tried 100 times without finding the field.

Hmmm, the problem seems to be that when using a fragment spread in Apollo, __typename is automatically included in the query and that messes up the planning. Hope that gives an indication on how to resolve the issue.

It's most definitely the fact that a fragment is present. Just including __typename in the query works correctly.

@jensneuse @devsergiy Added a reproduction test in #837

Or more correct, I just added __typename to an existing test which made it fail with "my" error. 😊

Enabling loads of Planner debug-config it seems to lose __typename when in the ConfigurationVisitor:
Initial node suggestions:

{"ds":0,"path":"query.hero","typeName":"Query","fieldName":"hero","isRootNode":true, "isSelected": true,"select reason": []}
{"ds":0,"path":"query.hero.name","typeName":"Character","fieldName":"name","isRootNode":false, "isSelected": true,"select reason": []}
{"ds":0,"path":"query.hero.__typename","typeName":"Character","fieldName":"__typename","isRootNode":false, "isSelected": true,"select reason": []}
[configurationVisitor]:  EnterSelectionSet ref: 2
[configurationVisitor]:  EnterField ref: 2 fieldName: hero typeName: Query
[configurationVisitor]:  saveAddedPath {"ds":0,"path":"query","shouldWalkFields":true,"pathType":"parent"}
[configurationVisitor]:  saveAddedPath {"ds":0,"path":"query.hero","fieldRef":  2,"typeName":"Query","shouldWalkFields":true,"isRootNode":true,"pathType":"field"}
[configurationVisitor]:  EnterSelectionSet ref: 1
[configurationVisitor]:  EnterField ref: 3 fieldName: name typeName: Character
[configurationVisitor]:  saveAddedPath {"ds":0,"path":"query.hero.name","fieldRef":  3,"typeName":"Character","shouldWalkFields":true,"isRootNode":false,"pathType":"field"}
[configurationVisitor]:  LeaveField ref: 3 fieldName: name typeName: Character
[configurationVisitor]:  EnterField ref: 4 fieldName: __typename typeName: Character
[configurationVisitor]:  LeaveField ref: 4 fieldName: __typename typeName: Character
[configurationVisitor]:  LeaveSelectionSet ref: 1
[configurationVisitor]:  LeaveField ref: 2 fieldName: hero typeName: Query
[configurationVisitor]:  LeaveSelectionSet ref: 2

Operation after initial run:

{
    hero {
        name
        __typename
    }
}

Planning paths after initial run

Should revisit: true
Has new fields: false
Has missing paths: true
Has fields waiting for dependency: false

Missing paths:

query.hero.__typename

And then it iterates 100 times with similar output.

Ok, perhaps one more nugget of information. Each query works on it's own as long as my two subscriptions have not already ran. If I run my three queries from Insomnia directly after starting the federation gateway they also work from my Vue-app including the subscriptions. 🙈

It's my subscription which return the Company-type that is causing the problem.

Which also introduces a third subgraph which extend the Company-type. I'll try to modify my current test to also plan the subscription first.

Still unable to reproduce this in a test 🙁 It's losing the Company.__typename in the secondary run for some reason.

If I add the Company.name to the queries it magically starts to work again. So the problem only exists if I select the key, __typename as well as whatever the other subgraph has extended the Company-type with. As said in an earlier comment this was introduced in rc47.

Adding Company.name would then of course introduce an extra call to the company subgraph which would not really be needed since both id and __typename should be available from any of the already used subgraphs. I'm still at loss of what the problem is here. Would @devsergiy have any thoughts on what part of the rc47 changes might be related?

Here is a 15k lines log with loads of debug-data. To me it looks like it should find Company.__typename in the first planner but still it claims that it's missing. The log also contains the log for the subscription which makes it fail.
goland.log

Hmmm, on the other hand it seems to want to get __typename from another DS<PHONE_NUMBER>4321252452) which is not part of any of the two planners<PHONE_NUMBER>531918615 and<PHONE_NUMBER>761466251).
In the second run.
Initial nodes:
{"ds":5424679272531918615,"path":"query.company.__typename","typeName":"Company","fieldName":"__typename","isRootNode":true, "isSelected": true,"select reason": [stage2: node on the same source as selected parent]} nodes after applying hints
And then after applying hints:
{"ds":12485775574321252452,"path":"query.company.__typename","typeName":"Company","fieldName":"__typename","isRootNode":true, "isSelected": true,"select reason": [provided by planner as required by @key]}
Not sure why it's changing DS at that point.

If I exclude __typename like this it works: https://github.com/wundergraph/graphql-go-tools/pull/847
Not sure what I break by doing it though.

Hi @argoyle
sorry for the big delay
could you try out a version from this PR
I believe it should fix your problems with a typenames
Thanks,
Wundergraph Team

No worries at all. That one works perfectly! 🎉 🚀

Looking forward to a future release. Thanks @devsergiy and the rest of the Wundergraph team. ❤


Implement search functionality

Moved from Jira. Combines two issues. 1 2
Add a navigation bar above the map.
Add a search box.
Search by sa2 region name.
If business data is available, search by business name and address.
See if it is useful to connect to Google Maps API for this.

We can't display any data from the Google Maps APIs unless we switch from Mapbox to Google's JS map, see Google policies re the Places API.
Since we're using Mapbox already, we might as well do the same thing as inequality.media.mit.edu and use the Mapbox Geocoding API. We could merge its address/business name lookups with our own list of SA2s into one autocompleting search field.

Resolved by #38.


some cities are missing

Add the cities for Finland, Ireland, Netherlands, Austria in this table:
https://docs.microsoft.com/de-de/office365/enterprise/o365-data-locations#countryregion-specific-data-center-city-locations

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 82d4d59d-d7b1-81b1-aeaf-6d34f61ae18b
Version Independent ID: 2b2620fa-7e4f-27ee-2655-47da2391296f
Content: Office 365 data locations
Content Source: Enterprise/o365-data-locations.md
Service: o365-solutions
GitHub Login: @dmwmsft
Microsoft Alias: deanw

Thank you for the input.  These updates have been made.

@newsgrep - Thank you for submitting feedback.
From our understanding, the issue you raised has been answered by the author @dmwmsft so we will close this issue.
Thank you for your contribution to make the docs better! Much appreciated!


Ability to fix potential config issues /npc fixconfig

Is your feature request related to a problem? Please describe.
This feature request is based on this issue
Describe the solution you'd like
Relating to the issue opened above, in this instance it would prompt the user what they would like to be fixed, the current option would be 'world' in order to update the npcs.yml world property. Eg. /npc fixconfig world
Describe alternatives you've considered
It doesn't make sense to update/fix all the npcs world property (not sure if this would be the case), perhaps something similar to /npc edit <npc_name> but unfortunately a byproduct of the issue described above is all the npcs affected also disappear from any tab autocomplete functionality. I haven't tested to /npc edit <npc_I_know_exists_in_config_but_does_not_autocomplete>
Additional context
This feature can be used for potential future config issues too

I agree with this approach! You can look forward to seeing something like this in pre-release 10!
Thank you for making a suggestion :)


Ensure uniqueness of query ids

:notebook_with_decorative_cover: Description
A small fixup for a very unlikely issue that @lava and I noticed.
:memo: Checklist

[x] All user-facing changes have changelog entries.
[x] The changes are reflected on docs.tenzir.com/vast, if necessary.
[x] The PR description contains instructions for the reviewer, if necessary.

:dart: Review Instructions
n/t

Did you make sure that there is not code path that checks for a nil UUID (0...0)? IIRC we used that to signal a special case to the exporter, but I'm not sure if it's processed.

Did you make sure that there is not code path that checks for a nil UUID (0...0)? IIRC we used that to signal a special case to the exporter, but I'm not sure if it's processed.

That's actually a great point. The code path exists, is checked, but we don't ensure random doesn't return null here. Will add a second check.

I've implemented the suggested change.

I actually meant something different. I don't think that uuid::random() can return the nil UUID. Instead, I was thinking that we should make sure that a result containing a nil UUID doesn't trigger a special code path at the EXPORTER.

I don't think that uuid::random() can return the nil UUID.

It can, actually. I'll leave the check in place.

I was thinking that we should make sure that a result containing a nil UUID doesn't trigger a special code path at the EXPORTER.

The special codepath retrieves (uuid query_id, uint32_t partitions, uint32_t scheduled), and uses partitions == 0 to check for early exits, much like the index itself does. So we're safe in that regard.


Replace QR app

"QR & Barcode Scanner" sends requests to Sentry, and it has an issue on GitHub about data tracking, but the developer doesn't seem very active. I think it's better to remove it and to add an app that was excluded before because of the lack of the dark theme. A recent update added it and I think it's ready.

[x] Installed and tested by me on my main smartphone and used for about 15 minutes or more.
[x] Has dark theme.
[x] It has x trackers on εxodus.
[x] It has x F-Droid Anti-Features.
[ ] I use the app on a daily basis and I love almost the entirety of it, so I placed next to it a heart.

Hi, thank you for your pull request!
I see. You could put this issue about this Sentry stuff here, please.
I did not know about dark theme update. Thanks. I know they make AWESOME apps, so are there more apps of theirs with dark theme?
Overall I trust you and everything seems fine so merging.

Issue Link.
I know they make great apps, but they published more than 30 on F-Droid, so I can't test them all. Maybe Weather? I've used it for a few days, but then moved to another app.


Produce test report for integration tests

Description
Although success and failures are written to stdout, ./gradlew integrationTest doesn't produce any lasting artifact (i.e. a report) to indicate which tests succeeded and which failed.  BATS has built-in support for reporting, it's just not something that's on by default.
Solution
This commit tweaks our BATS invocation so that a JUnit-style XML report ('report.xml') is produced in the packaging module's 'build/test-output' directory.
Tests
N/A - this is a build-system-only change.  Though I've done manual testing to ensure that the test report is generated under various circumstances, as expected.
Checklist
Please review the following and check all that apply:

[x] I have reviewed the guidelines for How to Contribute and my code conforms to the standards described there to the best of my ability.
[x] I have given Solr maintainers access to contribute to my PR branch. (optional but recommended)
[x] I have developed this patch against the main branch.
[x] I have run ./gradlew check.

I think making the Jenkins jobs aware of the file would require a bit of job configuration?  Though I may be wrong...
This is definitely a step in that direction though!

Yep, looks like in Jenkins there is a setting.  The current pattern is:
**/build/**/test/TEST-*.xml

@gerlowskija what Jenkins job runs the integrationTests ?  I went looking right now and none of the jobs appear to do so -- https://ci-builds.apache.org/job/Solr/


Add endpoint to list existing keyspaces

In the k8ssandra-operator project we have a use case for a new endpoint in the Management API that would simply return a list of the existing keyspaces.
See https://github.com/k8ssandra/k8ssandra-operator/issues/106 for context.
┆Issue is synchronized with this Jira Task by Unito
┆Issue Number: K8SSAND-856
┆Priority: Medium

I think a decent compromise here between creating a new endpoint and having to change the controller in https://github.com/k8ssandra/k8ssandra-operator/issues/106 would be to modify the API so that it can provide a parameter that allows for the behavior to be controlled.
So that the caller can explicitly say that they want the keyspace to be created only if doesn't exists or otherwise fail if it does exist.  We can leave the default to the current behavior so that we don't create a breaking change in the existing API.
What do you think about that @emerkle826 @adutra @adejanovski @jsanda ?

The current implementation of createKeyspace already does a create-if-not-exist (see here).
However, that implementation executes a query on the server. We could change the implementation and have Management API check to see if the keyspace already exists and simply return without executing the query, if that would be more efficient. This would not change the API contract, nor would it require K8ssandra operator to change what API it calls (if/when it starts calling createKeyspace for this purpose).

Fixed by #127


coffeedoc.info is down

Tweeted, but realized a GitHub Issue may be more appropriate.
http://coffeedoc.info/

nodejitsu
400
www.coffeedoc.info is currently stopped

https://github.com/coffeedoc/coffeedoc.info/issues/9

Oh whoops, should have posted there, you're right. Thanks.


Misnamed ports cause ingress gateway to bypass sidecars

(NOTE: This is used to report product bugs:
To report a security vulnerability, please visit https://istio.io/about/security-vulnerabilities
To ask questions about how to use Istio, please visit https://discuss.istio.io)
Bug description
When a VirtualService attached to a Gateway points to a Service whose the port doesn't follow the naming convention, all traffic bypasses the sidecar completely. This was extremely hard to debug and I can't find no mention in the docs of this misconfiguration causing such an issue.
There are mentions of similar issues here and here
Worth noting is it happens only with traffic inside the mesh, we had a TargetGroupBinding from aws-load-balancer-controller pointing directly to a Service and the sidecar was processing and logging the traffic correctly.
[ ] Docs
[ ] Installation
[X] Networking
[ ] Performance and Scalability
[ ] Extensions and Telemetry
[ ] Security
[ ] Test and Release
[X] User Experience
[ ] Developer Infrastructure
[ ] Upgrade
Expected behavior
Ideally communication to the Service should fail and an error should be logged.
Steps to reproduce the bug
apiVersion: networking.istio.io/v1alpha3
kind: Gateway
metadata:
  name: httpbin-api-gateway
  namespace: istio-system
spec:
  selector:
    istio: ingressgateway
  servers:
    - port:
        number: 80
        name: http
        protocol: HTTP
      hosts:
        - "httpbin-dev.somehost.com"
---
apiVersion: networking.istio.io/v1beta1
kind: VirtualService
metadata:
  name: httpbin-api-rules
  namespace: istio-system
spec:
  gateways:
    - httpbin-api-gateway
  hosts:
    - httpbin-dev.somehost.com
  http:
    - name: httpbin-test
      rewrite:
        uri:  /
      match:
        - uri:
            prefix: /httpbin
      route:
        - destination:
            host: httpbin.httpbin.svc.cluster.local
            port:
              number: 8080
---
apiVersion: v1
kind: Namespace
metadata:
  name: httpbin
  labels:
    istio-injection: enabled
---
apiVersion: v1
kind: ServiceAccount
metadata:
  name: httpbin
  namespace: httpbin
---
apiVersion: v1
kind: Service
metadata:
  name: httpbin
  namespace: httpbin
  labels:
    app: httpbin
    service: httpbin
spec:
  ports:
  - name: something-http
    port: 8080
    targetPort: 80
  selector:
    app: httpbin
---
apiVersion: apps/v1
kind: Deployment
metadata:
  name: httpbin
  namespace: httpbin
spec:
  replicas: 1
  selector:
    matchLabels:
      app: httpbin
      version: v1
  template:
    metadata:
      labels:
        app: httpbin
        version: v1
    spec:
      serviceAccountName: httpbin
      containers:
      - image: docker.io/kennethreitz/httpbin
        imagePullPolicy: IfNotPresent
        name: httpbin
        ports:
        - containerPort: 80

Then hit the /httpbin uri, logs appear at the ingressgateway but not at the sidecar of httpbin
Version
Istio 1.8.2
Chart versions:
base-1.1.0
istio-ingress-1.1.0
istio-discovery-1.2.0
How was Istio installed?
Helm
Environment where the bug was observed (cloud vendor, OS, etc)
AWS EKS
Additionally, please consider running istioctl bug-report and attach the generated cluster-state tarball to this issue.
Refer cluster state archive for more details.

I could not reproduce this, and this doesn't align with my expectations of how Istio works. The port name is (supposed to be) irrelevant to whether the traffic is capture by iptables. I used  ~/istio/istio-1.8.6/bin/istioctl install -y --set meshConfig.accessLogFile=/dev/stdout on GKE, then applied the config above (thanks for the easy repro!) and saw access logs in the sidecar after sending requests to the gateway.
Maybe you can attach an istioctl bug-report to give more info

@howardjohn thanks for the quick response.
That is really interesting, could the issue be with the helm charts?
Our installation was the following:
helm upgrade --install -n istio-system istio-base ./istio-${ISTIO_VERSION}/manifests/charts/base
helm upgrade --install -n istio-system istiod ./istio-${ISTIO_VERSION}/manifests/charts/istio-control/istio-discovery --values=./istiod-values.yaml
helm upgrade --install -n istio-system istio-ingress ./istio-${ISTIO_VERSION}/manifests/charts/gateways/istio-ingress --values=./istio-ingress-values.yaml
helm upgrade --install -n istio-system istio-ingress-noauth ./istio-${ISTIO_VERSION}/manifests/charts/gateways/istio-ingress  --values=./istio-ingress-noauth-values.yaml

istiod-values.yaml:
meshConfig:
  accessLogFile: "/dev/stdout"
  accessLogEncoding: "JSON"

global:
  imagePullPolicy: IfNotPresent
  proxy:
    holdApplicationUntilProxyStarts: true
    lifecycle:
      postStart:
        exec:
          # This hook serves the same purpose as holdApplicationUntilProxyStarts.
          # For some reason both need to be present or restarts will happen when the pod is starting.
          command:
          - pilot-agent
          - wait
      preStop:
        exec:
          # This preStop hook will wait for application connections to be drained before stopping the container.
          command:
            - /bin/sh
            - -c
            - sleep 20; while [ $(netstat -plunt | grep tcp | grep -v envoy | wc -l | xargs) -ne 0 ]; do sleep 1; done

pilot:
  autoscaleMin: 2

istio-ingress-values.yaml:
gateways:
  istio-ingressgateway:
    autoscaleMin: 4
    autoscaleMax: 20
    ports:
    - name: status-port
      # setting nodeport so that target group in AWS can be configured to point to this port
      nodePort: 31413
      port: 15021
      protocol: TCP
      targetPort: 15021
    - name: http2
      port: 80
      protocol: TCP
      targetPort: 8080
    - name: https
      port: 443
      protocol: TCP
      targetPort: 8443
    - name: tls
      port: 15443
      protocol: TCP
      targetPort: 15443

istio-ingress-noauth-values.yaml
gateways:
  istio-ingressgateway:
    name: istio-ingressgateway-noauth
    labels:
      app: istio-ingressgateway-noauth
      istio: ingressgateway-noauth
    autoscaleMin: 4
    autoscaleMax: 20
    ports:
    - name: status-port
      nodePort: 30206
      port: 15021
      protocol: TCP
      targetPort: 15021
    - name: http2
      port: 80
      protocol: TCP
      targetPort: 8080
    - name: https
      port: 443
      protocol: TCP
      targetPort: 8443
    - name: tls
      port: 15443
      protocol: TCP
      targetPort: 15443

Notice that we have two ingress gateways, the issue occurred with the one that has the suffix -noauth. Didn't test if the issue manifested in the other ingress, but I'll check soon and report back.
Hopefully this allows you to reproduce the issue.


feat: add support for native SHA-1 and SHA-256 checksums

Issue #, if available:
Description of changes:
Adds support for SHA-1 and SHA-256 via CRT bindings. Note: CRC32/C are not implemented because we don't need to use the CRT bindings:

CRC32 support comes from KMP's platform.zlib.crc32 and will be implemented directly in smithy-kotlin
CRC32C is already implemented in smithy-kotlin's common sourceset and doesn't need a CRT binding

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

CRC32 support comes from KMP's platform.zlib.crc32 and will be implemented directly in smithy-kotlin

Why? Can we not get CRC32 directly from CRT? If we use platform.zlib we end up with a direct zlib dependency required on the host OS. If we can get it from CRT we should.

@aajtodd We can definitely get CRC32 from CRT. Kotlin's documentation made me think platform.zlib is available on all targets but that might not be true?

CRC32 support comes from KMP's platform.zlib.crc32 and will be implemented directly in smithy-kotlin

Why? Can we not get CRC32 directly from CRT? If we use platform.zlib we end up with a direct zlib dependency required on the host OS. If we can get it from CRT we should.

@aajtodd We can definitely get CRC32 from CRT. Kotlin's documentation made me think platform.zlib is available on all targets but that might not be true?

They are but

Kotlin/Native compiler automatically detects which of the platform libraries have been accessed and automatically links the needed libraries.
On the other hand, the platform libs in the distribution are merely just wrappers and bindings to the native libraries. That means the native libraries themselves (.so, .a, .dylib, .dll etc) should be installed on the machine.

I think I'd err on the side of just using CRT if it's easy enough to add.


v0.2.0 release

I reviewed all the new features, all the code checks out. I added a couple of issues but they aren't about functionality and can be resolved in the future.


Shutdown exception

I've been trying to determine a way to cancel any boto3 upload/download calls. When I was checking the underlying "manager" object in the S3Transfer, i found the "shutdown" method.
But calling this method results in an exception being thrown.
client = boto3.client( 's3' )
transfer = S3Transfer( client )
transfer.download_file( bucket, key, to_file )

# Call just after the download starts
transfer._manager.shutdown( True )

The thrown exception is
python-BaseException
Traceback (most recent call last):
  File "/opt/.../lib/python3.8/site-packages/s3transfer/futures.py", line 278, in cancel
    self._exception = exc_type(msg)
TypeError: 'str' object is not callable

From what I found, the shutdown command is calling a protected member. But the called method signature is different.
def shutdown(self, cancel=False, cancel_msg=''):
    self._shutdown(cancel, cancel, cancel_msg)

def _shutdown(self, cancel, cancel_msg, exc_type=CancelledError):

The location the shutdown call is here:
https://github.com/boto/s3transfer/blob/960fc1617882b854b141e368c6b3fc4be6334847/s3transfer/manager.py#L588

Looks like this is already reported and a pull request sent.


Remote value support

Squash merged as LGTM, I'm not able to r+ my own PR (we should avoid doing this again)
Thanks


Save diff image if test fails (all reporters)

With default reporter, there is no evidence of what is the difference between reference and actual images.
As in html reporter there should be also generated images like phantomjs~diff.png in screens directory.

---
Want to back this issue? **[Post a bounty on it!](https://www.bountysource.com/issues/2378724-save-diff-image-if-test-fails-all-reporters?utm_campaign=plugin&utm_content=tracker%2F467695&utm_medium=issues&utm_source=github)** We accept bounties via [Bountysource](https://www.bountysource.com/?utm_campaign=plugin&utm_content=tracker%2F467695&utm_medium=issues&utm_source=github).

was fixed


Cost-model package on NPM does not include required files for local compile

Most users will not need to build the native Rust binaries locally on their machine since there are prebuilt binaries hosted on GitHub. However, for some users (primarily those on M1 or M2 macs) there are no prebuilt binaries and the build falls back to compiling the Rust binary locally.  In this case, the NPM package does not include all the necessary files for compilation.
error: failed to get `cost-model` as a dependency of package `cost-model-node-plugin v0.1.0 (/indexer/node_modules/@graphprotocol/cost-model)`

Caused by:
  failed to load source for dependency `cost-model`

Caused by:
  Unable to update /indexer/node_modules/@graphprotocol/lang

Caused by:
  failed to read<EMAIL_ADDRESS>
Caused by:
  No such file or directory (os error 2)

Resolved in #829


How to use?

Hi, I'm new to Python and scripts and such. I installed imgio through pip but I don't really know how to access and use imgio. I'm wanting to create text images for use with an RGB Matrix on a Raspberry Pi and this would help streamline this immensely if I'm able to do that with this program. Thanks for any help you can give me

Hi, thanks for your interest and sorry for the delay!
Here's a simple piece of code that converts a PNG into a PPM.
import imgio

image, maxval = imgio.imread("foo.png")
imgio.imwrite("foo.ppm", image, maxval)

I'm not sure if the libraries that imgio depends on are available on Raspberry (namely, numpy, piexif and imread), but if they are, then I'm not expecting any problems. This library itself is written in very basic Python.

Okay so you have to import Imgio into a python script, if I’m understanding that correctly. Also, I am wanting to create a PNM image from scratch, vs converting a pre-made png image into one. Is that something that imgio can do or is that not possible?

That's correct, you import imgio the same way you import sys, os, time and all the other Python packages that you need for your script.
To create a PNM image from scratch, you need to write your pixels into a NumPy array and then pass that array to imwrite: imgio.imwrite("myimage.pnm", my_array).
As for how to generate an image with text in it, you probably need to look up a font rendering package, but I have no experience with those so can't help you there.


46_1.7_Additional_Information bugfix

The application as merged in the previous pull request didn't save the new attributes

Coverage remained the same at 100.0% when pulling 47859c1f315de4a10aa3ea7c30aa3873601cd991 on 46_1.7_Additional_Information into 1cf5807c70f36857bf7df4edd7516f310569fb31 on dev.

Coverage remained the same at 100.0% when pulling f3264d70e5e02f84f7b4126c51e695e0e2444edb on 46_1.7_Additional_Information into 1cf5807c70f36857bf7df4edd7516f310569fb31 on dev.

Coverage decreased (-97.2%) to 2.808% when pulling<PHONE_NUMBER>15f9c1b8bd8fac81aba77ed66e2d53 on 46_1.7_Additional_Information into 1cf5807c70f36857bf7df4edd7516f310569fb31 on dev.

Coverage remained the same at 100.0% when pulling 49d3c4aa5e7461bb85109bfe6fbf2a1f7f1f073c on 46_1.7_Additional_Information into 1cf5807c70f36857bf7df4edd7516f310569fb31 on dev.

Reviewer: Please test this locally on your machine to be absolutely sure it works with the current version of you database!

Coverage remained the same at 100.0% when pulling a239d3426fd93d6f2558754da00e57afa6dcccb1 on 46_1.7_Additional_Information into 1cf5807c70f36857bf7df4edd7516f310569fb31 on dev.

As I discussed with @bjrne, it would be nice if someone else could review this

Coverage remained the same at 100.0% when pulling 4e72485ccd0cb5987bee1210cc3cf66b45f0c400 on 46_1.7_Additional_Information into bdd0e79a54e491a5ff176f85b776c83924527bad on dev.

Changes Unknown when pulling 09809ff6706931ede59e3c1c1d41f95c92380516 on 46_1.7_Additional_Information into ** on dev**.

Changes Unknown when pulling 73190eee642ab2b8358b7d1fdfe0cb78470cc44e on 46_1.7_Additional_Information into ** on dev**.

Since 49d3c4aa5e7461bb85109bfe6fbf2a1f7f1f073c, migrations would fail for users using the dev branch after 1cf5807c70f36857bf7df4edd7516f310569fb31. It should now work again for both cases.

Coverage remained the same at 100.0% when pulling 130d6f327dc30e7aa3349df96f6fde3a71db38f8 on 46_1.7_Additional_Information into ab57e0a6256ec30173922193eb50bdbc311fa056 on dev.

Next time please use squash and merge!


New version: StringDistances v0.7.2

Registering package: StringDistances
Repository: https://github.com/matthieugomez/StringDistances.jl
Created by: @matthieugomez
Version: v0.7.2
Commit: 006cb31f81e238650e01dc12d416ba66105fdb0d
Reviewed by: @matthieugomez
Reference: https://github.com/matthieugomez/StringDistances.jl/commit/006cb31f81e238650e01dc12d416ba66105fdb0d#commitcomment-40751838

please close this


Not using my Twitter avatar

If I sign up first using Twitter, it's not using my Twitter avatar as my account avatar.
Since we sign up w/ either Twitter or Facebook, the Locker should grab either one of those as the avatar image. Detailed here in the original spec: https://docs.google.com/a/singly.com/document/d/1R7-e31FyB9wAgd9H-0T5t0cBEjqkssDUBNIcfviAVXM/edit?hl=en_US#bookmark=id.93iqvvddemm9

It does show up, it just sometimes takes a few seconds because when we auth, the locker has to go out and get the profile, so it's not immediate.  Mine below showed up after about 3 seconds:
http://cl.ly/1Q3P3c3g2W0o1G2l1u1H

I'm still seeing this on Locker/Sandbox. I only authed Twitter, went through the new-account-experience and waited several minutes. No avatar. (I only authed Twitter to mimic what most usability participants did.)

While exploring running on windows this weekend I saw some odd behavior here.  I connected twitter and saw my icon for a bit, but then going form gallery -> explore again it went away.

Just so everyone knows, I flipped the default order from Facebook -> Twitter to Twitter -> Facebook. This is entirely to satisfy my own vanity, because I hate my Facebook avatar and don't want to have to futz with Facebook long enough to change it.

Ha! That is both acceptable and funny. It shouldn't really be in an order though, it should be whichever they authed first. If they did FB first, then it's their FB; Twitter first, it's their Twitter ID. I think this relates to the FB/Twitter page being missing from the new account experience - #739

It makes sense to use whichever authed first, but to do this would require more changes than are worth the effort right now, due to the way that the code pulls the profiles from the map. The right way to do it would be to pull the avatar at auth time and cache it within the locker. I'll create a new issue describing how that could be done and we can prioritize accordingly.

Okay thanks. :-)


Add support for List-Unsubscribe

Fixes #2943
This is still a work-in-progress, but I wanted to make this a merge request to get some early feedback as this is my first attempt at working with K-9 Mail's codebase.
There is one main issue with this: for big messages, the List-Unsubscribe header may not be known (related to #5240 and https://github.com/k9mail/k-9/issues/5237#issuecomment-815955904). Currently, the button just isn't shown until the headers are available, which is an awful experience.
What would be the best way to go about this? I see a few options:

Always download all headers (increased data usage)
Don't show an unsubscribe button in the message but move it into the overflow menu at the top (an show an "This email did not contain any unsubscribing instructions" when clicking on lack of List-Unsubscribe?)

I am also wondering if K-9 Mail already contains some kind of helper module to deal with <data_we_want>,<data_we_want> values?

K-9 Mail supports a way of always fetching specific headers. See RealImapFolder.
https://github.com/k9mail/k-9/blob/e619d381437191c87192cd7aad21d449951c9001/mail/protocols/imap/src/main/java/com/fsck/k9/mail/store/imap/RealImapFolder.kt#L539-L543
The most difficult part about a feature like this is figuring out how to integrate it into the UI. Unsubscribing from a mailing list is probably an action that is rarely used. So it shouldn't be displayed prominently. Maybe put it into the toolbar's overflow menu?

K-9 Mail supports a way of always fetching specific headers. See RealImapFolder.

I'm kinda unsure how this works. Could you explain in more detail how I would ensure the List-Unsubscribe header to always be fetched?

Maybe put it into the toolbar's overflow menu?

I've hereby done that.
RFC 2369 allows multiple unsubscribe URLs, my code assumes the first sane (http/https/mailto) option is the preferred option. Is that reasonable? Or should we prefer the first mailto option?
Also, I should probably write tests for this. Would testing parsing the header be sufficient testing? I'm not sure how to do UI testing in K-9 Mail's codebase.

I'm kinda unsure how this works. Could you explain in more detail how I would ensure the List-Unsubscribe header to always be fetched?

The string added to fetchFields is part of the command that will be sent to the IMAP server. The syntax is BODY.PEEK[HEADER.FIELDS (space separated list of header field names)]. Just add list-unsubscribe to the string:
 fetchFields.add(
     "BODY.PEEK[HEADER.FIELDS (date subject from content-type to cc " +
         "reply-to message-id references in-reply-to list-unsubscribe " +
         K9MailLib.IDENTITY_HEADER + " " + K9MailLib.CHAT_HEADER + ")]"
 )

RFC 2369 allows multiple unsubscribe URLs, my code assumes the first sane (http/https/mailto) option is the preferred option. Is that reasonable? Or should we prefer the first mailto option?

I have no strong preference. As an email client we should probably prefer the mailto option (if there is one). There's a remote chance the app could run on a device without a browser. But we know for sure an email app is installed.

Also, I should probably write tests for this. Would testing parsing the header be sufficient testing? I'm not sure how to do UI testing in K-9 Mail's codebase.

We currently don't have UI tests. But the header parsing code should be tested. Please put the code in its own class.
The header parsing should also happen when the message is loaded. The result can then be part of MessageViewInfo.

The unsubscribe button still doesn't show until I click "Download full message".

Actually, it works fine, I just forgot to think about that old emails wouldn't update

The header parsing should also happen when the message is loaded. The result can then be part of MessageViewInfo.

I'm not sure where to hook this up, K-9's codebase is very different than what I'm used to, can you give more pointers?

The general idea is that MessageViewInfo is a data class that hold all information necessary for the UI to display the message. Instances of MessageViewInfo are created by MessageViewInfoExtractor. You need to find the right place in this class to call out to your code to extract the unsubscribe URI if there is one, then add it to MessageViewInfo.

I hope this latest commit is the change as you wanted it to be implemented. The method is now called by the MessageViewInfoExtractor class and added to the MessageViewInfo. However, given MessageList has no direct reference to MessageViewInfo, but a reference to MessageViewFragment I hooked it into the onMessageViewInfoLoad* functions.

The place you found in MessageViewInfoExtractor looks good :+1:

Instead of putting the code to handle the unsubscribe button into MessageList, you could delegate this to MessageViewFragment.

override fun onOptionsItemSelected(item: MenuItem): Boolean {
    …
    } else if (id == R.id.unsubscribe) {
        messageViewFragment!!.onUnsubscribe()
        return true
    }
    …
}

By only returning a Uri, part of the "business logic" is duplicated in the UI layer. Instead, consider creating content-specific data types, e.g.
sealed interface UnsubscribeUri {
    val uri: Uri
}

data class MailtoUnsubscribeUri(override val uri: Uri) : UnsubscribeUri
data class HttpsUnsubscribeUri(override val uri: Uri) : UnsubscribeUri

It doesn't make a huge difference because you still need to create different Intents. But doing different things based on the data type is cleaner than having to look at the contents of a Uri.

Please have a look at RFC 2369 for the syntax of the List-Unsubscribe header field. The tests seem to create messages using multiple header fields. But that's not how List-Unsubscribe is specified or used in practice.

Instead of putting the code to handle the unsubscribe button into MessageList, you could delegate this to MessageViewFragment.

Done

By only returning a Uri, part of the "business logic" is duplicated in the UI layer. Instead, consider creating content-specific data types, e.g.

I think I've implemented this as you asked.

Please have a look at RFC 2369 for the syntax of the List-Unsubscribe header field. The tests seem to create messages using multiple header fields. But that's not how List-Unsubscribe is specified or used in practice.

Oops, I totally messed that up when using the ListHeaders test as a base. Good catch, fixed now.

You can fix issues reported by ktlint by running gradlew ktlintFormat.

Ah nice, I found the command but was trying to find the output. Didn't realize it fixed it automatically :)

Sorry for the failing test, fixed that just now.

Thank you :+1:
Apologies for taking so long to get this merged.

No need to apologize! Thank you for being so patient with me as I was trying to figure out K-9's codebase and merging it in the end. I really appreciate it :)


Strange autosuggestions behaviour on Mac

I am experiencing an issue with ash-autosuggestions for quite some time now. Basically when I tab to activate autosuggest the text that was entered beforehand is unable to be removed. I enclosed a video which might make it more clear: https://youtu.be/vyQoVTQ9iT8
macOS 12.3.1
zsh 5.8 (x86_64-apple-darwin21.0)
My .zshrc is very basic:
export PATH=$PATH:$HOME/.scripts
export PATH=/usr/local/sbin:$PATH
export ZSH="/Users/douwedevries/.oh-my-zsh"
plugins=(git brew sublime sudo zsh-autosuggestions zsh-syntax-highlighting)
source $ZSH/oh-my-zsh.sh

Please let me know if you need more information.

I am facing the same problem as you with quite the same configuration in .zshrc.

this was fixed just see this post
https://github.com/zsh-users/zsh-autosuggestions/issues/683


Feature/lapp 15 Mock HttpClient

Using a Mock instead to make a real Http request for unit tests

Codecov Report

Merging #111 into master will decrease coverage by 1.23%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #111      +/-   ##
==========================================
- Coverage   84.32%   83.09%   -1.24%
==========================================
  Files          32       32
  Lines         587      621      +34
==========================================
+ Hits          495      516      +21
- Misses         92      105      +13

Impacted Files
Coverage Δ

...etStandard20/Request/BlockingRequestHandlerTest.cs
80.64% <ø> (ø)
:arrow_up:

Test.NetStandard20/ConnectionTests.cs
100% <100%> (ø)
:arrow_up:

Analytics/Client.cs
60% <100%> (+0.57%)
:arrow_up:

Test.NetStandard20/ActionTests.cs
100% <100%> (ø)
:arrow_up:

Analytics/Analytics.cs
62.5% <100%> (-37.5%)
:arrow_down:

Test.NetStandard20/FlushTests.cs
92.3% <100%> (-2.82%)
:arrow_down:

Analytics/Request/BlockingRequestHandler.cs
76.92% <0%> (-5.5%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 86b2ad8...ee5ca1c. Read the comment docs.

This PR was included on #112


Object args

Ref: https://github.com/google/oss-fuzz-gen/pull/436

/gcbrun exp -n dk-test-jvm330 -m vertex_ai_gemini-1-5 -b jvm

experiment is looking good


No longer clientside

This mod appears to be incompatible with clients who do not have it as of now. Since v50, this mod causes incompatibility errors when unmodded clients join.

Sorry, I misunderstood. This mod was not the one causing this problem; just some very confusing testing circumstances lead to the belief that it was, when in fact it was General Improvements.

... OK, I'm reopening this because it appears to actually have been both. Strangely, this mod appears to cause conflicts with some clients but not others. Some were able to join me, and others were rejected, but some of those who joined me didn't have any mods. Strange.


Problems with the POS module Available Stock

In versions 9 and 10 does not work. I only work in some dependence python 8. Perhaps you needed? Permits?

Could you send screenshots of your issue? What goes wrong? What do you get and what do you expect?

No hay mucho que decir, instalo el módulo en las v9 y v10 pero el stock no
aparece en el POS, no hay cambios. En la v8 funciona sin problemas. Si me
mandas tu email privado te mando los accesos para que lo veas.
El 1 nov. 2016 6:57 AM, "Ivan Yelizariev"<EMAIL_ADDRESS>escribió:

Could you send screenshots of your issue? What goes wrong? What do you get
and what do you expect?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/it-projects-llc/pos-addons/issues/165#issuecomment-257549206,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AIha3V2z_bPL3MrkXo-lv1zOnL76miy0ks5q5ylBgaJpZM4KlPBb
.

Ok, can you send screenshots:

module record (form where you click "Install" and then see "Installed" label)
screenshot of POS interface

Also, do you have other custom POS modules? Probably they are inconsistent and one override features of pos_product_available

Not working for me either on V10. No errors on install but when using POS the Available stock does not show.

Got it sorted, there was another module stopping it from working.


Leak in memory backend [JIRA: RIAK-1576]

Mailing list messages:
http://lists.basho.com/pipermail/riak-users_lists.basho.com/2014-December/016416.html
http://lists.basho.com/pipermail/riak-users_lists.basho.com/2014-October/016025.html
I have confirmed that you can reproduce this leak using the following bash script to load data into a bucket whose backend is named mem_backend:
https://gist.github.com/lukebakken/65cff6499315dc66d7f7
Untested reproducer from the mailing list:
https://gist.github.com/indpnday/76d99c5852e0100c5a04

Also see #963

Pushing to Jira

I've confirmed that the changes in PR #963 are in the 2.0.5 source.
This issue going forward should be treated as a yet to be identified memory leak affecting the 2.x series.

PROD: Attempt to fix in the 2.1.1 release or 2.2 if no 2.1.1 release.
[posted via JIRA by Seema Jethani]

It seems that we are dealing with the same problem we have with Bitcask TTL. We haven't been able to reproduce this on a one node cluster with n_val of 1, right? AAE is not integrated with backend expiration, and with enough read requests could occasionally resurrect keys that get a fresh new TTL.  Have we tried this with AAE off?

Err, I mean just plain read-repairs would do it too. You don't even need active anti-entropy.

My explanation above doesn't really explain the high memory usage part of this. I'll investigate that.

@engelsanchez Were you able to investigate this issue?

This was dealt with in a chat.  The high memory usage came from having AAE enabled, which enables the eleveldb system, which by default allocates enough memory to run with leveldb as a backend.  The workaround until we change eleveldb to stop being so greedy is to configure it to use less: http://docs.basho.com/riak/latest/ops/advanced/backends/leveldb/#Configuring-eLevelDB
As far as I know, there is no actual memory leak in the memory backend.

[~drohrer]Given Engel's comment above, can we investigate this issue and close if needed?
[posted via JIRA by Seema Jethani]

We have found at least one legit memory leak in the memory backend thanks to [~nbellerophon]- I'll link the branches from 2.0.6/2.1.3 here and we should get them merged forward from 2.0 to 2.1.
[posted via JIRA by Douglas Rohrer]

Please use this branch to pull in to 2.0.7. Maybe just PR directly from this to 2.0 branch if it merges cleanly.
[posted via JIRA by Douglas Rohrer]

PR for 2.0 is at https://github.com/basho/riak_kv/pull/1331
[posted via JIRA by Douglas Rohrer]

Please review PR linked in the comments.
[posted via JIRA by Douglas Rohrer]

This is in both 2.0 and develop-2.2 branch. Now done.
[posted via JIRA by Douglas Rohrer]

Looks great that this problem is solved, but I still not found any release version with this fixes.

@dieu - based on @JeetKunDoug's comment, it will land in Riak 2.2

@lukebakken Yes, but how I understand that commit already merged into 2.0 branch (https://github.com/basho/riak_kv/pull/1331) but nobody build new version for 2.x.

@dieu there will be a new 2.0 release in the coming weeks - we've been working hard on some difficult, rather hard-to-fix issues, but 2.0.7 is in the final review/testing phase right now. I can't give you a definitive date "until it's done" but it shouldn't be long now.

@JeetKunDoug thanks so much for your work!
Also I have question, what about 2.1.x? it's possible to have this patch into 2.1.x release?

@dieu Riak KV 2.2.0 will be the next release after 2.1.4. Because 2.2.0 will be including an upgrade of Solr to 4.10.4 and an updated Erlang (R16B02_basho10) we felt it was appropriate to bump the minor version of Riak. We do not intend to release any additional Riak versions in the 2.1.x series. I realize this is a bit of a change from Basho's previous versioning schemes (we stayed with 1.4.x for a very long time) we believe it more accurately reflects the changes being made in Riak, and better reflects semantic versioning than what we've done in the past.


Enterprise Template Documentation Bug - Main Documentation link is broken

Enterprise Template
https://github.com/microsoft/AI/tree/master/templates/Enterprise-Template
Main Documention link under Get Started is broken.
The link in the readme.md is also broken:
https://docs.microsoft.com/en-us/azure/bot-service/bot-builder-enterprise-template-getting-started?view=azure-bot-service-4.0

Enterprise Template is deprecated in favour of the Virtual Assistant template (which itself is an update Enterprise Template). https://github.com/microsoft/AI/wiki/What's-new-at-Build-2019


Enforce mypy

Enforces mypy throughout the repo making a best-effort attempt to remediate mypy errors.
The PR adds # type: ignore in several places as a workaround.  In these cases, I was unable to remediate the mypy error in a way that preserved tests.  I welcome feedback or alternative suggestions.

gonna try to merge this into the actual latest (https://github.com/algorand/graviton/pull/15)
will keep you posted

I believe this is closeable, as I've merged it into #17

TODO: delete branch after https://github.com/algorand/graviton/pull/17 merged


Add support for watchOS 3, drop support for iOS 7

Heads up: This is part 1 of ??? to add watchOS support to Vokoder, which depends on the core of VOKUtilites.
In order to test this, I added some stuff from each of the core dependencies to a sample watchOS app and made sure it all compiled and didn't barf when it ran. There's not really a good way to unit test watchOS stuff, but since it will be compiled automatically whenever the tests on the sample iOS app run, that should theoretically catch any regressions.
I also dropped iOS 7 support since Xcode 8.x no longer supports building for anything below iOS 8. I consequently bumped to a new major version. I also plan to make this change in Vokoder, so @vokal-isaac now would be a good time to complain if you're against it.

@vokal-isaac @bryanluby @lindelldigital and/or @chillpop, thoughts?

Are you saying it's not possible to set a deployment target below iOS 8 on Xcode 8?

I don't know if it's any more complicated than this, but,

Why my install of San Francisco as a system font is missing the bullet character is a discussion for another time.

This is the warning you get when you go to upgrade:

I suspect you could do it manually, but I don't believe it'll actually archive for anything older than 8.

Since this is now Xcode 8, do we also need to update the Travis osx_image value?

@bryanluby it was already set to osx_image: xcode8.2

@designatednerd 👍 I was looking at an old version of the file

I don't have time to look over the whole diff at the moment.  Here are my comments thus far:

Since Xcode 8.whatever doesn't support a deployment target below iOS 8, upping the minimum deployment target to iOS 8 is fine.
There's a commit message that says "drop iOS 8 support"—should that have been iOS 7 support?
Semantic Versioning says that 0.x / pre-1.x doesn't make any promises about what breaks when, so my inclination is to go with 0.11.x rather than crossing the 1.0 threshold.

@vokal-isaac yes that was a mistake, dropped 7 to 8, not dropped 8
I'm fine with whatever y'all want on the versioning, this just seemed like a big enough change to bump a major version. However, I shall abide by the selections of the crew

If we were post-0.x, I'd agree that it warranted a major version bump.  Since we're still in 0.x, I'm not sure we want to leave 0.x.

The 0.xversioning is fine with me

@vokal-isaac @lindelldigital @chillpop  light is green, trap is clean. thoughts?

I don't have time to review this, I'm just happy to see your names in my inbox.

Miss you, Brock!
Anyone got a second to merge and push up to CocoaPods if y'all are OK with this? I can't start hammering on the Vokoder stuff until this update is available because of the way dependencies work in CP 😛

thank you @bryanluby!

I'm not an owner of this pod so I can't push the pod spec update

Ironically I may still be. Will give it a shot if @vokalisaac doesn't beat me to it
-ES
Hand-delivered by the Mobile Internet Gnomes

On Mar 16, 2017, at 5:40 PM, Bryan Luby<EMAIL_ADDRESS>wrote:
I'm not an owner of this pod so I can't push the pod spec update
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

pod trunk push'd.


Very Slow video playback

Video playback slower than sound
wmv.zip

I found the reason.
It is the player - wmplayer.
I change to  another palyer，and everything goes well.
Strange :(
But everything goes well with mstsc, any player.


Suggestions for the Next Update

I've been thinking a lot about Open Props and how we can make it better. After building numerous components with Open Props, here are some suggestions for the next update:
Add:

font-size: 0.875rem | 14px (Frequently used by designers, especially for links and buttons).
border-radius: 4px.
border-radius: 8px.

More:

Fluid font size.
Fluid size.
Gradients (especially multi-layer gradients).
SVG filters.

I understand that you can create your own props on top of Open Props, but when you encounter certain props frequently with different designs, I think it's time for these props to be included by default.

My wishlist:

All colors specified in oklch() by default.
A 2 minute intro video on the homepage and readme (like the second half of the video on the bulma framework's homepage)
The card code example at the top of the homepage should "animate" it's css variables being switched (e.g. --radius-2 to --radius-4 and the
 containing it's own styles should animate to the new values).
Improve the main website:

I didn't even notice the bottom stickied navigation until my 5th time visiting the site. The website needs a side-nav that highlights the current scroll-position.
The color palete is so unaligned I'm getting trypophobia. A plain ol' color grid will fix this.
No 12-column-grid example. Throw an example in there for people to copy out when they need to as a starting point.

Change name format of color files from props.gray.css to colors.grey.css

This will make it easier at a glance to see which files are color related. (This makes a large difference when the list is alphabetically sorted, e.g. shadows and sizes shouldn't appear between sand and stone.)

@spartanatreyu, I completely agree with all your points. The library is indeed moving to HDR, not only for colors but also for gradients. Additionally, there's a mention of adding logical properties for animation in this issue #390

Opinion. In forms styling move to:
   Name   <input name="name" type="text" />
I don't like annoying  "for" and "id".
Also:

as @mobalti mention font-size: 0.875rem | 14px is must have
reorder --surface-1,2,3. Layers should be like stack of cards. It will also allow to add more layers if someone need (--surface-4 ...)

Button group and icon button styling

my vote is for oklch as default and will great to have a base template (classic landing?) with best practices implemented