KeepassXC doesn't know how to find the login form

Upstream has an issue about sites https://github.com/keepassxreboot/keepassxc-browser/issues/1358 that do not work, which sometimes is due to them presenting the login form through Shadow DOM https://github.com/keepassxreboot/keepassxc-browser/issues/446
Is Conifer using a Shadow DOM to display the login form?

I just logged in with KeePassXC to https://conifer.rhizome.org


adwsteamgtk: init at 0.6.9

Description of changes
Add AdwSteamGtk, an installer for the Adwaita-for-Steam Steam skin.
Fixes https://github.com/NixOS/nixpkgs/issues/228958

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Was this designed to be declarative or is this meant to be installed imperatively? (would a simple user service do the trick?)


composer.lock is redundant for libraries

This library includes composer.lock which is:

Not used when installing any library with Composer. It's just outright ignored.
It hinders testing under different versions of dependencies. Say, Travis CI would normally do composer install for you during CI, with composer.lock present you would have to do composer update additionally. Likewise, contributors would have to do that too.
It pollutes composer.json update diffs, since they both have to be updated.

There's no point to keep it committed in a library, on the contrary with a deployable project, which this project is not.
Here's what the documentation says:

However, this lock file will not have any effect on other projects that depend on it. It only has an effect on the main project.

I believe having a lock file helps in long run and specially when we have multiple people working on same repo
As for the point of using old package/library version, I believe that gets solved by dependabot
I will close this for now, feel free to join the slack and let us know your thoughts!


build: add nameprefix to the controller manager

Signed-off-by: Nitin Goyal<EMAIL_ADDRESS>https://bugzilla.redhat.com/show_bug.cgi?id=2047173

I suppose you mean the controller-manager service account
If that's the case we may need to write a patch file targeting only this serviceAccount and corresponding roles/roleBindings/deployment as I believe we can't set this via kustomize cli
Needs to be investigated further

This works for the controller-manager deployment and pod. Is there any way to do this for the serviceaccount as well?

We could do that, But eventually, it will bring much more complexity in the kustomize and makefile because of rbacs and all, I would suggest that we just change the name of the service account to something appropriate so that it won't conflict with something else.

/lgtm


let cleanOldTestVariations respect project boundaries

this fixes Visual-Regression-Tracker/Visual-Regression-Tracker#382

the failed CI / build isn't due to my changes

@nitschSB gave you permissions to create branch inside repo
otherwise CI will fail

closed because now is's a duplicate of #179


Removing ColliderDisabled component does not re-enable collisions

When ColliderDisabled component is removed collision detection is not getting effectively re-enabled (collider does not affect rigid bodies etc.).
Please see attached code for a minimal reproducible example: rapier-bug-enable-collider.zip
I tried to debug it for a moment and it seems that ColliderDisabled component removal is properly detected so it may be a bug in the Rapier itself.

This issue is fixed by dimforge/rapier#538
Workaround until new version is released: modify transform component (can be set to the same value, it's only important to trigger change detection)


Inline css twice in Vue-CLI 3 with html-webpack-inline-source-plugin

Expected behavior
Size of my css file is 13.8kb, html is 2.8kb. So I wanna that my css file can be inlined with html-webpack-inline-source-plugin.
Current behavior
The size of my html file increased to 30.4kb
And I found that my css file was inlined twice.
Config
Adding this plugin by webpack-chain API
// vue.config.js
const HtmlWebpackInlineSourcePlugin = require('html-webpack-inline-source-plugin')
module.exports = {
    chainWebpack: config => {
        config.plugin('html').tap(args => {
            args[0].inlineSource = '.css$'
            return args
        }
        config.plugin('inline').use(HtmlWebpackInlineSourcePlugin)
    }
}

When I inspecting my project's webpack config
vue inspect > output.js
// output.js
/* config.plugin('html') */
new HtmlWebpackPlugin(
  {
    templateParameters: function () { /* omitted long function */ },
    template: '/Users/logan/tencent/qgact/src/index.html',
    filename: 'index.html',
    inlineSource: '.css$'
  }
),
/* config.plugin('inline') */
new HtmlWebpackInlineSourcePlugin()

Enviroment
Node.js 10.9.0
@vue/cli-service 3.0.0
webpack 4.15.1
html-webpack-plugin 3.2.0
html-webpack-inline-source-plugin 0.0.10

It works when I use html-inline-css-webpack-plugin
// vue.config.js
const HtmlWebpackInlineSourcePlugin = require('html-webpack-inline-source-plugin')
module.exports = {
    chainWebpack: config => {
        config.plugin('inline').use(require('html-inline-css-webpack-plugin').default)
    }
}

I am experiencing the same issue. Using vue-cli and this plugin, both my JS and CSS are being inlined twice.

I am experiencing the same issue. Using vue-cli and this plugin, both my JS and CSS are being inlined twice.
Cuzz Vue-cli 3 will auto add preload link tag to your html like this.
 <link href=js/app.js rel=preload as=script>

I am experiencing the same issue. Using vue-cli and this plugin, both my JS and CSS are being inlined twice.

Vue-cli 3 would use @vue/preload-webpack-plugin to auto add preload link tag to your html like this
 <link href=js/app.js rel=preload as=script>
<link href=css/app.css rel=preload as=style>,
you can modify this plugin's config in vue.config.js(if you don't have this file, create it in your project's root folder)
module.exports = {
  chainWebpack: config => {
    config.plugin('preload')
      .tap(args => {
        args[0].fileBlacklist.push(/\.css/)
        return args
      })
    config
      .plugin('html')
      .tap(args => {
        args[0].inlineSource = inlineSourceReg
        return args
      })
    config.plugin('inline-source')
      .use(require('html-webpack-inline-source-plugin'))
  }
}

@logan70, this did the trick! It looks like this was more of a config issue if anything. Thanks for your help.

I am experiencing the same issue. Using vue-cli and this plugin, both my JS and CSS are being inlined twice.

Vue-cli 3 would use @vue/preload-webpack-plugin to auto add preload link tag to your html like this
 <link href=js/app.js rel=preload as=script>
<link href=css/app.css rel=preload as=style>,
you can modify this plugin's config in vue.config.js(if you don't have this file, create it in your project's root folder)
module.exports = {
  chainWebpack: config => {
    config.plugin('preload')
      .tap(args => {
        args[0].fileBlacklist.push(/\.css/, /app\.js/)
        return args
      })
    config.plugin('inline-source')
      .use(require('html-webpack-inline-source-plugin'))
    config
      .plugin('html')
      .tap(args => {
        args[0].inlineSource = '(\.css|app\.js$)'
        return args
      })
  }
}

If it works, let me know.

This doesn't work for me, it still renders everything in folder dist :/

how you have since resolved this issue? :)


Make Multi-line Field Exclude ending Newline

null
Microsoft Reviewers: Open in CodeFlow

@wingetbot waivers Add Validation-No-Executables

/azp run

@wingetbot waivers Add Validation-No-Executables


Remove lifetime from Event

Is your feature request related to a problem? Please describe.
I'm writing some high-level abstraction that combine multiple contracts in a single struct. In this abstraction I want to use Event and store it in an owned struct. However Event needs a lifetime because it borrows self.client from Contract.
Describe the solution you'd like
self.client of Contract is an Arc, so instead of borrowing we can clone it. This will remove lifetime from Event struct.
If this is acceptable from you, I can open a PR.

that sounds reasonable, please go for it!

SGTM! Doubt that we're at the point where the Arc vs Lifetime performance is the bottleneck, should always be the RPC so is fine


use new icon font subset and replace old icons with more meaningful ones

Thanks for submitting these improvements! Before I merge this in I'd like to make sure that we're ok from a licensing perspective. Could you please share where these new icons came from and if you know it which license they are distributed under?
I'd also be in favour of renaming the font to be font-name-subset.woff2 to make it easier in the future to find the source of these icons as well as providing attribution to the original creators :)

I've updatet the font subset filename.
The icons are from google fonts - see: https://fonts.google.com/icons?icon.set=Material+Icons
These icons are free to use for private and commercial use case.
https://developers.google.com/fonts/faq?hl=de

Sorry for the delay in looking at this and thanks for making those tweaks! Once #369 is merged I'll look at getting this in :)


Update documentation (usage without npx)

Update documentation (README) on how to use the env-linter.
Use env-linter as a regular dev-dependency (not with npx) because of various reasons.

Fixed with https://github.com/namics/env-linter/commit/080efad97c36ccaaa31bf8be8af63a89654353d1


wip: tests in container

blocked on https://github.com/projectatomic/atomic/issues/1113

jenkins/superCI comment

Status: failure, return code = 1
Result url: https://da.gd/Ol4c
Comment: This is testing CI

Will update the PR soon, I hope.
TODO:

[ ] don't implement rw container mounts (not reliable)
[ ] remove functionality to put stuff into container - the use case is not clear

Built on top of #43. So please review that one first.

I removed .travis.yml
I cleaned Makefile and setup.py
Tests now run in a container.


Crash in method implementation of sd_cancelImageLoadOperationWithKey

Issue Info

Info
Value

Platform Name
ios

Platform Version
11.1.2

SDWebImage Version
4.2.2

Integration Method
cocoapods

Xcode Version
Xcode 9.1

Repro rate
sometimes 50,000 crash in a week for half million users

Repro with our demo prj
NO

Issue Description and Steps
App crashes randomly in this method

(void)sd_cancelImageLoadOperationWithKey:(nullable NSString *)key;
At this line
id operations = operationDictionary[key];
Telling EXC_Bad_ACCESS
it happens alot and don't know what's cause and how to solve it. It's a very annoying issue and been for a while

Hi. Coundl you please attach some stack trace for us to analysis ? (Maybe from your app's crash log or some third-party service like Fabric)

I'm not using Fabric and I'm sure it's not because of any other thing
Here is where it crashes

This looks like a multi-thread issue. That SDOperationsDictionary should have a lock or make acesss into the same queue.
Does the previous version SDWebImage also have this crash ? And also about the crash ratio ?(50,000 per week seems really big)

Yes, it's been there forever but from version 4.1.2 it became much more than before.
Here is a chart about last week that increase was after updating to version 4.1.2

@itatawy Well...We can fix it soon by make all the acess(read and write) to that SDOperationsDictionary thread-safe. Maybe in next patch version 4.2.3. I'll create a pull request it later.

Good. I just need to know is there any timeline for that fix. As as you see there is a lot of crashes and our customers are complaining so, We want to take a decision if it's going to be a quick fix will wait if not will downgrade to 4.0.0 till the fix is done.

@itatawy If you can ensure that the earily version crash ratio is lower, you can have a try. The patch version may be released in week.
Or if you really need hot fix, you can try to swizzle that method using Objective-C runtime(really not encouraged, but it's a way). You can check the #2114 for the fix. :)

Wait...I have a question. Do you call any UIView+WebCache/UIView+WebCacheOperation methods from background queue ? If all the operattion happended on main queue. There should not have any multi-thread problem.

No we don't What i call is just
imageView.sd_setImage(with: Foundation.URL(string: encodedURL)!, placeholderImage: placeholderImage, options: SDWebImageOptions.retryFailed , completed: { (image, error, type, url)
from UIView I'll make it in a main block to be 100% sure but it's a straight forward call from CollectionVIewCell

Fixed via #2132


MODRS-186: Make system user creation optional

Purpose
To support a proof of concept for improved provisioning and management of system users, implement the ability to disable the creation, management, and use of system users in modules.
Approach

Add SYSTEM_USER_ENABLED configuration property to control system user creation/usage
Remove redundant classes (they must be deleted with migration to the folio-spring-system-user)

Changes Checklist

[ ] API Changes: List any API paths, methods, request or response bodies changed, added, or removed.
[ ] Database Schema Changes: Specify any database schema changes and their impact.
[ ] Interface Version Changes: Indicate any changes to interface versions.
[ ] Interface Dependencies: Note added or removed dependencies.
[ ] Permissions: Document any changes to permissions.
[ ] Logging: Confirm that logging is appropriately handled.
[ ] NEWS: Ensure that the NEWS file is updated with relevant information about the changes made in this pull request.

Related Issues
List any Jira issues related to this pull request.
Learning and Resources (if applicable)
Discuss any research conducted during the development of this pull request. Include links to relevant blog posts, patterns, libraries, or addons that were used to solve the problem.
Screenshots (if applicable)
If this pull request involves any visual changes or new features, consider including screenshots or GIFs to illustrate the changes.

the feature was merged in scope of https://github.com/folio-org/mod-remote-storage/pull/195


Back button shortcut functionality

Hello,
I normally use the forward and back buttons on my mouse to traverse in Chrome and other web browsers. However, I noticed that this does not work in the GUI. I was hoping that you might be able to implement it for a (very slightly) smoother browsing experience.
Thanks!
PS: Hopefully, you understood what I meant by the dedicated forward and back buttons on my mouse. This mouse feature (also sometimes seen on keyboards) is not specific to this specific brand. It is supported by most browsers (it might be something that is a part of Windows?), and even some programs that aren't browsers but it is still useful with.

Also related to making the GUI more web browser-like, a refresh button or the ability to use F5 would be nice if you have had the program running in the background for a while, and want to refresh the streams currently up without having to navigate back to wherever you were at from one of the default pages on the left.

Hello...
Forward and backward mouse button event listeners are not supported by Chromium or NW.js, and therefore can't be used. These buttons are also not defined by the DOM3 Events specification, see here: https://w3c.github.io/uievents/#widl-MouseEvent-button

a refresh button

It's already there at the top bar and it reloads the model of the current route. F5 or Ctrl+R could be added, though...


Updated CONFIG to v12.331

Some pieces are dependent on the updates in #2926
Does not tackle #2911 or #2593
Also leaves off adding the Region portions of CONFIG

Closes #2572

It's possible we should roll #2932 into this PR.


Regression Tests

Perform regression tests after the 3 big PRs are merged (MoveToESM, Strictnullchecks and XState upgrade)
Scope:

[ ] ACM
[ ] CCM
[ ] TLS
[ ] CIRA
[ ] KVM
[ ] Power Actions
[ ] Maintenance commands (Update AMT password)
[ ] DHCP/Static IP
[ ] Few AMT versions
[ ] Windows/Linux

Question: Just docker-compose deployment or K8s too?

Completed all tests for February release


config file validation

if we could define a json-schema for valid options for the config file, it should be possible to validate the yaml in the config against it, such as like https://json-schema-everywhere.github.io/yaml.

one piece of this that i would like to have in a full solution would be an npm package that can be used as a cli in an npm script for performing the validation.

I would also love this or at least to somehow get errors that my config is wrong. Currently, it just silently doesn't function.


Pulse benchmarks are not actually constructing schedules

Informations

Qiskit version:
Python version:
Operating system:

What is the current behavior?
The current pulse.Schedule behavior is to build an immutable Schedule, all operations build a new Schedule. This new Schedule should be assigned after generation. The current pulse benchmarks such as:
https://github.com/Qiskit/qiskit/blob/a1bb148a5fb9e10279de8ed167660375ccffad64/test/benchmarks/pulse/schedule_construction.py#L37
do not assign the constructed schedule and are therefore dishonest as these operations are expected to not be constant time.
Suggested solutions
To fix
schedule.append(...) should become schedule = schedule.append(...).

Good catch, in fact any immutable object generated must be assigned to be meaningful, by definition or canoe modify some state internally...

While this is getting touched, SamplePulse needs to become Waveform. I know it should be a separate issue 😬

What is the status of this? Can it be closed?

This has been fixed in #1155.


Related to #98 fix

This works it is in test suite.
module task_func_test04(input [7:0] in, output [7:0] out1, out2, out3);

This doesn’t.
module task_func_test04(in, output, out1, out2, out3);
	input [7:0] in;
	output [7:0] output;
	output out1;
	output out2;
	output out3;

Modified existing test with non working module port declaration.
module task_func_test04(in, output, out1, out2, out3);
	input [7:0] in;
	output [7:0] output;
	output out1;
	output out2;
	output out3;
	parameter p = 23;
	function [7:0] test1;
		input [7:0] i;
		parameter p = 42;
		begin
			test1 = i + p;
		end
	endfunction
	function [7:0] test2;
		input [7:0] i;
		parameter p2 = p+42;
		begin
			test2 = i + p2;
		end
	endfunction
	function [7:0] test3;
		input [7:0] i;
		begin
			test3 = i + p;
		end
	endfunction
	assign out1 = test1(in);
	assign out2 = test2(in);
	assign out3 = test3(in);
endmodule

This is not valid Verilog code: You cannot call a port "output". After fixing that, the code provided seems to be working fine..
Feel free to re-open this issue (or open another one) if you feel like I have missed something here.


ARROW-11342: [Python] [Gandiva] Expose ToString and result type information

These methods are intended to make it easier to work with and debug the Gandiva expression builder.
import pyarrow
import pyarrow.gandiva as gandiva

builder = gandiva.TreeExprBuilder()

lit = builder.make_literal(1000.0, pyarrow.float64())
print(lit)
# Before: <pyarrow.gandiva.Node object at 0x7f36fd37ecf0>
# After: (const double) 1000 raw(408f400000000000)

field = builder.make_field(pyarrow.field('a', pyarrow.float64()))
print(field)
# Before: <pyarrow.gandiva.Node object at 0x7ff7daf99f90>
# After: (double) a

print(builder.make_function('greater_than', [field, lit], pyarrow.bool_()))
# Before: <pyarrow.gandiva.Node object at 0x7ff7d24bde70>
# After: bool greater_than((double) a, (const double) 1000 raw(408f400000000000))

@wjones127 sorry for the late review.  This looks OK to me, did you want to add specific tests asserting equality to strings?

@wjones127 sorry for the late review. This looks OK to me, did you want to add specific tests asserting equality to strings?

Yup that makes sense. I will add that.

@wjones127 Really sorry for the delay :-/. I rebased on git master and will merge if CI is green.


Add tests

@se7entyse7en unittest or pytest, I personally prefer Pytest if my opinion carries any weight. Also, I'd like to work on this

There are already some integration tests, closing this in favor of #67.


fix: exported Pager, PagerConsumer, PagerContext, and PagerContextType

Motivation
This allows child PanGestureHandlers to call addGestureHandlerRef using PagerConsumer (and PagerContext), and additionally allows them to waitFor the Pager PanGestureHandler through the addition of gestureHandlerRef to Pager.providerVal

Problems Solved
Using a PanGestureHandler inside a MaterialTopTabNavigator from react-navigation steals pan gesture input from the Pager used by TabView.
Example Usage
Inside a MaterialTopTapNavigator with swipeEnabled = true
import React, { Component } from 'react';
import { PanGestureHandler } from 'react-native-gesture-handler';
import Animated from 'react-native-reanimated';
import { PagerConsumer, PagerContextType } from 'react-native-tab-view';

class Example extends Component {
  private pager: PagerContextType | undefined;
  private panGestureHandlerRef = React.createRef<PanGestureHandler>();
  private y = new Animated.Value(0);

  componentDidMount() {
    this.pager?.addGestureHandlerRef(this.panGestureHandlerRef);
  }

  private handlePan = Animated.event([{
    nativeEvent: ({ translationY: y }: { translationY: number }) =>
      Animated.set(this.y, y)
  }]);

  render() {
    return (
      <PagerConsumer>
        {(pager?: PagerContextType) => {
          this.pager = pager;
          return (
            <View style={{ flex: 1 }}>
              <PanGestureHandler
                ref={this.panGestureHandlerRef}
                simultaneousHandlers={[pager!.gestureHandlerRef]}
                waitFor={pager!.gestureHandlerRef}
                onGestureEvent={this.handlePan}
                onHandlerStateChange={this.handlePan}
              />
            </View>
          );
        }}
      </PagerConsumer>
    );
  }
}

Test plan

Thanks!

@satya164 Any reason this was reverted?

It's not something we want to expose as public API because there are issues with it, like: not being able to remove a ref once you add it, PagerContext is the wrong name for gesture handler context, PagerConsumer doesn't need to be exported separately.

PagerContext is the wrong name for gesture handler context
This was the name that was already in place, I just exported it. Perhaps changing the name would be a better solution?

PagerConsumer doesn't need to be exported separately
Sure, definitely, but the general standard is to export Consumer and Provider components for ease of use. This is still not a reason to revert completely however, you could just remove this export very easily.

Reverting this pull request breaks code that needs to use a PanGestureHandler inside another container that uses GestureHandlers. Can you explain any more specific issues with this PR?

My alternative to using this code is to exclude this library altogether as without this, it does not work. Exporting the context and passing down the GestureHandlerRef should be expected of this library as it is necessary for any advanced usage, and I was both surprised and offended to find that it was not.

not being able to remove a ref once you add it

Is this a common behaviour? Adding this functionality should be approximately three lines of code, if that. Is this a valid reason to revert this PR?

We believe that this change breaks the OCP of the library and we're strongly motivated to not move with having these exports included in the lib.
Can you try maybe come up with some another solution which won't move out of the internals of the library?
Frankly speaking, I have problems with understanding your issue? Can you maybe describe a bit deeper what's your problem?

"I have problems with understanding your issue"

Using a PanGestureHandler inside a MaterialTopTabNavigator from react-navigation steals pan gesture input from the Pager used by TabView.

This means that adding extra gesture functionality inside a MaterialTopTabNavigator causes the left/right swiping in the TabNavigator to be broken.
Please run the example I provided within a MaterialTopTabNavigator. With this PR, the code runs just fine, but without it breaks.
The other solution is to not use this library, which would be a shame.


[AJ-1075] Show Helm chart version and Docker image in WDS troubleshooter

https://broadworkbench.atlassian.net/browse/AJ-1075

Seeing the screenshot … the "Data app image" value will be something like us.gcr.io/broad-dsp-gcr-public/terra-workspace-data-service:eaf3f31, where the eaf3f31 is the most important part. Could you strip off everything before the final "/" or find some other way to shorten it?

Could you strip off everything before the final "/" or find some other way to shorten it?

Done in https://github.com/DataBiosphere/terra-ui/pull/4047/commits/8a49e31ce9223c906e7eca7710065dd7a7a6c279.


swift 2.3

add support to swift 2.3

          1 Warning

:warning:
Consider adding supporting documentation to this change. Documentation can be found in the docs directory.

  Generated by :no_entry_sign: danger

Excuse me, I may be wrong, but why Xcode version in CircleCI is set to "7.3.1"? Tests fail because of that I suppose. Looks like they support Xcode 8 already https://circleci.com/blog/xcode-8-0-beta-support-for-ios-builds/

@charlag because this is a PR to add support for Swift 2.3. We are currently using Swift 2.2, which also means using Xcode 7.3.1. We may need to change the CircleCI file though? (cc @ashfurrow @gustavogervasio)

Xcode 8 supports both Swift 2.3 and Swift 3.0, right? May we do need Xcode 8 then?

Sorry if I wasn't clear - that's what I was trying to say.
Swift 2.2 == Xcode 7
Swift 2.3 == Xcode 8
Swift 3.0 == Xcode 8

Is there any blockers on this besides updating circle.yml?

Is there a plan on updating to 2.3/3.0? Xcode is GM now. I want to help with migration but don't know what is the right way to do it.

@charlag I've opened PR with help wanted on the Swift 3.0 migration for Xcode GM Seed. You can take a look #608, we need some help!

any update on this being released?

I can merge+release this for Swift 2.3 before releasing a separate version for 3.0, or we can just do it for 3.0. What does everyone think?

I think we should have a Swift 2.3 release 💯

2.3 should be awesome. I don't think there will be much support for 3.0 until the middle of October and Moya is one if my 'blockers' (I still love it!).

Okay, will reply from @gustavogervasio's branch and push a tag. Wish me luck!

Rather after #621, I think master is updated for 2.3.

I've cherry-picked the commits from #621 into the 7.0.1 tag and everything looks good. This means we can release just Swift 2.3 support and not also the breaking changes currently on master. I'm downloading the Xcode 8 GM to test locally before releasing. Thanks everyone!

@ashfurrow You probably want to bump Alamofire version to 3.5.0 in the podspec as well 💪
(that PR only bumps in Cartfile)

Cool, will do :+1: What's the trick to get Xcode 8 to use Swift 2.3?

It should prompt you to migrate if SWIFT_VERSION is not set on the project (which #621 set).

Wow, that was a lot of work. I've got 7.0.1 released on Carthage and CocoaPods, would someone be able to verify it's working for them as expected?
I'm going to close this PR.

It seems it's working with CocoaPods, but apparently (at least one) breaking change got in: https://github.com/Moya/Moya/blob/7.0.1/Source/Target.swift#L10

😢 @marcelofabri can you check for other breaking changes? If that's the only one, we can replace the 7.0.0 tag and hopefully no one will be the wiser.

I've pushed the release up to a release-7.0.1 branch.

@ashfurrow I think all of them got in, since there are no commits to master after the tag 😬

Okay, well let's stop the bleeding. Hold on.

I've pushed a 7.0.1 tag with an identical commit to 7.0.0 so no one's projects will break. I'll take another look tomorrow, thanks for pointing out the issue!

Cherry-picking commits turned out to be too complicated, so instead I branched off of the 7.0.0 tag and redid the changes for Swift 2.3: https://github.com/Moya/Moya/compare/7.0.1...release-7.0.1-take-two . I'm going to lint the podspec locally before releasing, I'll let you know.

7.0.2 has been released, could someone take a look and verify it's all good?

All good from what I've seen 👍 🎉

Great, thanks!


how do i change minecraft version

I know that may sound kinda silly but how do I change minecraft version i'm stuck at 1.20.4 but there's almost none neoforge documantion for that version.

Ok, I fixed it so heres the tutorial

click on the minecraft ARM instalation in your prism launcher
on the side bar click the _edit_ option
then click on the Version tab right below the Minecraft log
select on the _Minecraft_ option
in the top right corner there should be an Change version
select your preferd version
boot your game and enjoy!~

I know that may sound kinda silly but how do I change minecraft version i'm stuck at 1.20.4 but there's almost none neoforge documantion for that version.

The reason why i do not have a neoforge/fabric/etc documentation put up is because this project does not focus on modded in general, hence why it's left out.


input plugin for kitsu.io

Motivation for changes:
making Flexget able to accept anime series based on their status in the kitsu.io library (former hummingbird.me)
Detailed changes:

updatted the old hummingbiird plugins here to the new api
Entry fields

always:

title
url = ''

when available:

kitsu_title_en
kitsu_title_en_jp
kitsu_title_ja_jp

if latest is set:

series_episode
series_id_type = 'sequential'

Config usage if relevant (new plugin or updated schema):
Syntax:
    kitsu:
      username: <value>
      lists:
        - <current|planned|completed|on_hold|dropped>
        - <current|planned|completed|on_hold|dropped>
      latest: <yes|no>
      limit_to: <airing|finished>

Example:
    configure_series:
      settings:
        identified_by: sequence
      from:
        kitsu:
          username: NikkyAi
          lists:
            - current
            - planned
          limit_to: airing
          latest: no

possible additional features

authetication (oath)

shows series marked as private
allows to update the series progress

kitsu.io drama (but atm it seems like the drama category is a placeholder)
kitsu.io manga (would people use flexget for that?)

@gazpachoking reminder ping to look over this (i think your change request stop it from being merged)
i will create a second PR once the stable api is rolled out on namespace /v17/

@gazpachoking reminder ping to look over this (i think your change request stop it from being merged)
i will create a second PR once the stable api is rolled out on namespace /v17/

Sorry about that @NikkyAI. Looks pretty good to me. Want to update the wiki?

what kind of info needs to be in the wiki entry ?

Add a link here https://flexget.com/Plugins/#3rd-party-sites-input to a new page with some info on what the plugin does and config options. You can take a peek at some of the other plugin pages for a bit of guidance.

only info that might need to be added apart from the config is that limit_to: araing|finished relies on the fact that there is a finished date on some entries.. this breaks on movies and some shows.. so people might want to just leave out that config option and not limit anything
latest will only add the latest episode to be downloaded..
that is both functionality that was easier achieved with the old api and i tried to emulate it as good as possible
i still hope they add that back in
if its not in when the stable namespace gets deployed i will remove those options though

i added a page for my plugin, based on anidb_list and others as well as a entry in the 3rd party input list
i grouped it with the other anime related input plugins

Awesome, thanks for the contribution!


Create Visual Studio Code extension to save code-snippets to Bookmarks.dev

Similar to IntelliJ plugin - select text, right click save to Bookmarks.dev > open new browser window with selected text as code snippet and metadata for it.
See IntelliJ Plugin in action at - https://www.bookmarks.dev/howto/codelets
The java code for it - https://github.com/BookmarksDev/bookmarks.dev-intellij-plugin/blob/master/src/dev/bookmarks/intellij/plugin/SaveToBookmarksDevAction.java

done


fix: JS middleware page

Middleware jshas not been updated after major update (2.0.0).
Fixes #356

Tested change locally and resolved the issue. Nice! :+1:

Side note:  window.addEventListener is definitely an option, but maybe it would be better to align to the same code in the HTML example


python3Packages.ropgadget: 6.5 -> 6.6

Motivation for this change
Update to latest upstream 6.6
Change log: https://github.com/JonathanSalwan/ROPgadget/releases/tag/v6.6
Renaming from ROPGadget to ropgadget.
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
21.11 Release Notes (or backporting 21.05 Relase notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 129411 run on x86_64-linux 1

5 packages built:

pwndbg
pwntools (python38Packages.pwntools)
ropgadget (python38Packages.ROPGadget)
python39Packages.ROPGadget (python39Packages.ropgadget)
python39Packages.pwntools

@ofborg eval

ping @fabaff

I will address the remaining issues after #135832 is available as it may lead to conflicts.

I will address the remaining issues after #135832 is available as it may lead to conflicts.

that got merged

Is this ready now?


Repeater feature to allow repeatable blocks of varying types

Description
This feature adds the possibility of using an array of block options as repeatable blocks.
Use in a form blade looks like this:
@formField('repeater_array', [
    'name' => 'machine_name_for_field',
    'types' => [
        [
            'key' => 'machine_name_for_repeater_block_type',
            'name' => 'Name for Block Type',
        ],
        ...
    ],
])

Related Issues

Originally had a discussion with @ifox and @antonioribeiro around this feature about a year ago. Finally got around to updating the UI as I had a need for a longer list of block options.

Hi @stiknoltz,
This is cool! I did a quick test on my end and it seems to work well inside the block editor. Am I right in thinking that this can't currently be used outside of the block editor, like a regular repeater?
From this original Spectrum discussion, I'd say the primary use case seems equivalent to nested block editors. Does this make sense? I'm curious to know if nested block_editor fields could cover this use case. (Not supported at the moment, just thinking out loud)

Thanks @pboivin. You're correct that this was intended for use in the block editor context. This feature is probably roughly equivalent to a nested block editor.
I'm sure thinking about it more broadly could yield some interesting additional possibilities, but for my current needs (and the needs discussed in that Spectrum thread) it seemed to fit the bill.
I'd be happy to take a look at expanding its application, but I figured since I'd wrapped up the feature for my current needs, I'd submit it back since it seemed to be useful as-built.

This is a great feature.
I was wondering, can't we make the repeater array the default (so no new type, just update the existing one with the option of having multiple types).
This would be a breaking change but would work well for 3.x?
So it becomes:
@formField('repeater', [
    'name' => 'machine_name_for_field',
    'types' => [
        [
            'key' => 'machine_name_for_repeater_block_type',
            'name' => 'Name for Block Type',
        ],
        ...
    ],
])

Or we could go for nested block editors and then a repeater becomes obsolete for blocks but can still be used for relational data?
If we do nested block editors then we also have to add some options like a limit of the amount of blocks.

Hey @stiknoltz,
Thanks again for taking the time to contribute!
After some discussion, we found that a nested block editor would provide the same functionality but with more control already built into it.
There is a wip pr for this here: https://github.com/area17/twill/pull/1397 and we will further focus on improving that.
Kind regards,


README.md should mention plugin requires neovim >= 0.7.0

The plugin requires neovim >= 0.7.0 since 520776f. For an older version such as 0.6.1, the parent of the previously mentioned commit can be used.

Thank you, updated readme.


Add Dictionary Bot.bas

.bas file of dictionary bot is added!!

[x] added

> .bas file done!!

test1 branch deleted


Add status API for runner pods

Add GET /status API to runner.

Integrated GET /deletion_time and GET /job_result into GET /status.

Move /tmp/github.env to /var/meows/github.env.
Merge the runner/client package to the runner package.
Fix kindtest.

Add some helper functions to reduse redundancy.

Signed-off-by: Masayuki Ishii<EMAIL_ADDRESS>

What is the purpose of this PR? 🤔

What is the purpose of this PR? 🤔

This is a fix for the problem of slack notifications are not sent.
Please see this comment.
https://bozuman.cybozu.com/k/#/space/3801/thread/54750/3064458/5478820


Handle syntax error in Ripper

Ripper might fail to parse a Ruby source even if the current runtime parsed it properly, because some versions of JRuby have different implementation of runtime parser and Ripper parser.
https://github.com/jruby/jruby/issues/2427
So we handle the syntax error in Ripper and fall back to the simple single line extraction in that case.

LGTM.  Merge when green!


Update to @chainsafe/discv5 v3.0.0

Motivation
Several things:

Our ENR api was error-prone, and was refactored in 3.0.0
We had to re-encode ENRs across the worker boundary (which costs us a signature verification in the main thread)
We frequently had errors decoding ENRs (that we had successfully decoded and re-encoded within the worker)

Description

Update to @chainsafe/discv5 v3.0.0
Use new toObject / fromObject to pass ENRs as objects across the thread boundary (no encoding/decoding necessary, no decoding errors possible)

deployed this branch to feat3

From my profiling, https://github.com/ChainSafe/lodestar/issues/5084 is no longer visible in this branch

From my profiling, #5084 is no longer visible in this branch

it does not happen with goerli nodes or prod mainnet node, just test mainnet node subscribing to all subnets

:tada: This PR is included in v1.6.0 :tada:


Week 7 - Raiden Review Ticket

[x] Quiz5 MCQ results >50%
[x] (1 or 0) and test corrections

Proof:
MCQ Results + Corrections

Graded by Nathan Shih: 2/2
MCQ placed higher than a 50% and has test corrections that are thorough and easy to follow.


Update to current Roc and basic-webserver

It is similar to the upgrade-server branch, but it uses the current remote basic-webserver. It seems to be working fine, just the BigTask throws for some operations (pagination, filtering): malloc(): unaligned tcache chunk detected, which seems to be a problem of the platform, not the frontend per se.

Thank you @gree7 😍


DynamicBlurView as subview of modal presented View Controller appear like view with black background

At UIViewController i add DynamicBlurView as subview. After that i present that View Controller modaly and DynamicBlurView looks like just black view.
`
class BlurViewController: UIViewController {
override func viewDidLoad() {
super.viewDidLoad()
view.backgroundColor = .clear
let blur = DynamicBlurView(frame: CGRect(x: 20, y: 20, width: 300, height: 300))
view.addSubview(blur)
blur.blurRadius = 10
blur.dynamicMode = .common

}
`

DynamicBlurView can capture view in superview subviews only. if presented ViewController modaly that superview not has subviews.

@grishamsc Hi, have you fixed this problem?

Actually, if you test the library with >iOS 10 it's not working.

@grishamsc @sssbohdan @Codeido Hi guys.
I'm improving this issue in #23 and supporting swift4.
But, It isn't supported for ios7. Also, it couldn't be completely synchronized with presenting the animation of modal.
Wait for swift4 release or clone this branch and then try it.
Thank you.

2.0.0 was released.

I look like the issue still exist. without the dynamic blur i get a clearscreen after i add the blurview i get all black screen  without the blur

Did you set true to isDeepRendering ?

Yeah I had the same question and set isDeepRendering to true solved that.
Thanks!


cmd/link: Linker gives misleading advice on new -ldflags option when option contains spaces

I am migrating from Go 1.4 to Go 1.5.  When I build my app, the compiler emits a warning that my -ldflags syntax is likely to be deprecated, and offers a misleading suggestion to correct the warning.  My use case is a -X -ldflags value that contains spaces.
$ go build -ldflags "-X main.buildInfo 'Version: 2.9, commitID: 4d203fa, build date: Tue Aug 25 19:54:19 PDT 2015, SDK: go version go1.5 darwin/amd64'" -o stashkins-darwin-amd64
# github.com/xoom/stashkins
link: warning: option -X main.buildInfo Version: 2.9, commitID: 4d203fa, build date: Tue Aug 25 19:54:19 PDT 2015, SDK: go version go1.5 darwin/amd64 may not work in future releases; use -X main.buildInfo=Version: 2.9, commitID: 4d203fa, build date: Tue Aug 25 19:54:19 PDT 2015, SDK: go version go1.5 darwin/amd64

If I take a variant of the warning advice, I get
$ go build -ldflags -X main.buildInfo='Version: 2.9, commitID: 4d203fa, build date: Tue Aug 25 19:54:19 PDT 2015, SDK: go version go1.5 darwin/amd64' -o stashkins-darwin-amd64
can't load package: package main.buildInfo=Version: 2.9, commitID: 4d203fa, build date: Tue Aug 25 19:54:19 PDT 2015, SDK: go version go1.5 darwin/amd64: cannot find package "main.buildInfo=Version: 2.9, commitID: 4d203fa, build date: Tue Aug 25 19:54:19 PDT 2015, SDK: go version go1.5 darwin/amd64" in any of:
	/usr/local/go/src/main.buildInfo=Version: 2.9, commitID: 4d203fa, build date: Tue Aug 25 19:54:19 PDT 2015, SDK: go version go1.5 darwin/amd64 (from $GOROOT)
	/Users/mpetrovic/Projects/go/src/main.buildInfo=Version: 2.9, commitID: 4d203fa, build date: Tue Aug 25 19:54:19 PDT 2015, SDK: go version go1.5 darwin/amd64 (from $GOPATH)
can't load package: package -o: cannot find package "-o" in any of:
	/usr/local/go/src/-o (from $GOROOT)
	/Users/mpetrovic/Projects/go/src/-o (from $GOPATH)
can't load package: package stashkins-darwin-amd64: cannot find package "stashkins-darwin-amd64" in any of:
	/usr/local/go/src/stashkins-darwin-amd64 (from $GOROOT)
	/Users/mpetrovic/Projects/go/src/stashkins-darwin-amd64 (from $GOPATH)

Fiddling around with the quotes, I find this invocation works, which the warning did not help me arrive at:
$ go build -ldflags '-X "main.buildInfo=Version: 2.9, commitID: a03e9a7, build date: Tue Aug 25 20:51:38 PDT 2015, SDK: go version go1.5 darwin/amd64"' -o stashkins-darwin-amd64

@ae6rt Thanks for figuring out the proper quoting.  Having warnings of each flag for all 30 go binaries being built on our CI box was a bit verbose.

Thanks to Ian Taylor for responding to a user on go-nuts list.  That's where I found the solution, and wanted to capture it here for a fix for posterity.

It's not possible to guess what quoting you need. The linker doesn't know. We could make the message less specific by saying
-X <name> <value> may not work in future releases; use -X <name>=<value>

but that's much less helpful. At least with the specifics you can try to grep for the name or value to find where it came from.

The quoting issue makes changing the error difficult.
I propose we do nothing about this for Go 1.6 and then remove the old format entirely in Go 1.7. Then the warning will be gone too.


Key Exchange methods of libsodium

Dear Soatok,
first of all, thanks for your library and the really great blog article. I'm currently trying to learn more about encryption and your blog post together with this repo is a really helpful example.
I just have one question: Although I understand the reasons why you are using ED25519 instead of X25519, wouldn't replacing the crypto_sign_keypair function with the crypto_kx_keypair method provide the use of X25519? Why did you choose not to use crypto_kx_keypair?
Thanks a lot for your help!
EDIT: I just saw that in your blog post you are using crypto_box_keypair which is actually a X25519 - why did you switch back to crypto_sign_keypair then?

Why did you choose not to use crypto_kx_keypair?

To piggyback on an existing protocol for distributing Ed25519 keys.
You can go from Ed25519 to X25519. The reverse is not possible (due to the SHA512 step in Ed25519).
Signal uses X25519 keys instead of Ed25519 keys, and had to build their own X25519-based signature algorithm. It works but it's ugly.

Thanks a lot! That makes sense.


Cross building snappy-java using docker

Based on #137, this PR will add support for cross compiler based native library build:

[x] Windows
[x] Linux x86, x64

[x] Build docker image for g++ built with -fPIC option

[x] Linux arm (armv5, v6, v7 and android-arm)

[x] Fix OSInfo to support various arm arch types

[x] Mac OS X
[x] PowerPC
[x] aarch64
[x] Build native libraries on Travis CI + docker
[x] Upload the latest snapshot to Sonatype in Travis CI
[x] Fix build.sbt (for OSGi)
(TODO) Ask contributions of native libraries for platforms where no cross compiler image of docker is available  (e.g., FreeBSD, IBM s390, AIX, etc.)

Now make native-all can be used.

Do you need any help in building native libraries on s390 and AIX? :-)

@odaira Nice to see you @odaira san :) And yes. Please run make native on s390 and AIX and send the results as PR.

OK, I have just started working on it, but it seems to take some time as I have to start with environment set-up.  Stay tuned....

I think the native libraries for Linux/s390x and AIX/ppc* are up-to-date for 1.1.3, but do you still want me to build them?

@odaira Yes because snappy-java-1.1.3-M1 newly adds BitShuffle API, which needs recompilation. Let's move this discussion to another ticket.

@odaira Created #156


Remove unnecessary default feature getopts

getopts crate is only used for executable, but added to default features. This can reduce number of dependencies when this crate is installed as lib.

Sorry, this requires additional arguments on cargo install so it might not be good for bin users.


Don't understand how to install extensions on Android

I have installed org.ungoogled.chromium.extensions.stable from the repository added to F-Droid.
I expected to be able to install extensions right away, but when I try to open the webstore I am redirected to https://chrome.google.com/webstore/unsupported
So I thought I had to follow this instruction: https://github.com/NeverDecaf/chromium-web-store
But when I come to install the unpacked crx I get the error toast that manifest is not a valid json.
What do I need to do to be able to add extensions?
Installed on Fairphone 3, /e/OS 0.14 (based on Android 10, LineageOS, microG).

Thank you for your answer. If I come to open the web store as desktop browser I don't see Add to Chromium. I tried several extensions.

Are you sure you downloaded the right version?

It is org.ungoogled.chromium.stable Version 88.0.4324.182

Not sure what was going on, try an older version maybe?

That's what didn't work yesterday. Just tried it again and with the changed flag I can install extensions. Thank you very much.
Is it normal that chrome://extensions remains empty? How can I uninstall extensions?

Which version? Versions older than 87.0.4280.141 doesn't have chrome://extensions correctly.

I mixed up the chrome-extension popup via the button at the bottom of the app menu and the manually entered chrome://extensions. The latter shows the installed extensions and also allows to uninstall them.
So at the moment everything looks as it should.
Thanks for your help.


Add SLO alerts for Telemeter

This PR adds alerts & rules for SLO violations using the existing slo-libsonnet library - MON-2153.
The library generates a large number of new rules & alerts, PR reviewers are best advised to primarily review the jsonnet changes.
We'll add alerts for MST once we're happy with this set of alerts & rules for telemeter in staging.

Thanks both for the helpful comments :+1:


Issue in readme for vmap

Hi great Jax team!
I just noticed in the readme file of the repository, in the explanation of vmap, there may be an unintended typo:
def predict(params, input_vec):
  assert input_vec.ndim == 1
  for W, b in params:
    output_vec = jnp.dot(W, input_vec) + b  # `input_vec` on the right-hand side!
    input_vec = jnp.tanh(output_vec)
  return output_vec

I guess it should be:
def predict(params, input_vec):
  assert input_vec.ndim == 1
  for W, b in params:
    output_vec = jnp.dot(W, input_vec) + b  # `input_vec` on the right-hand side!
    output_vec = jnp.tanh(output_vec) # I think this line was intended to be like this
  return output_vec

Thanks for Jax!

Yup, makes sense: prediction_output = jnp.tanh(jnp.dot(W, input_vec) + b) 👍

Thanks for Jax!

Same here!

Hey, thanks for calling attention to this, and for unpacking it so clearly!
Actually, it is written as intended. The value of input_vec is used on the next iteration of the loop, so that one layer's output is the next layer's input.
Perhaps it looks surprising at first because the last iteration's updated value of input_vec is not consumed. But writing it this way lets us avoid special-casing the last layer (to be linear, i.e. not to have an activation). That is, it avoids us having to write it more like:
def predict(params, input_vec):
  assert input_vec.ndim == 1
  for W, b in params[:-1]:
    output_vec = jnp.dot(W, input_vec) + b
    input_vec = jnp.tanh(output_vec)
  W_final, b_final = params[-1]
  output_vec = jnp.dot(W_final, input_vec) + b_final
  return output_vec

We chose to make the example code more concise. Moreover, any dead code is eliminated automatically under a jit, so we don't usually worry about things like an extra jnp.tanh evaluation!
Hope that makes sense. Thanks for the kind words, and for surfacing any possible issue you spot. It's really helpful to have extra checks; false positives are better than missed detections!

Thanks a lot for the detailed explanation!


Error starting debugger when Vscode and Node are installed from Ubuntu Snapstore

VSCode Version: Snap,  details below
OS Version: Ubuntu 20.04
Version: 1.48.0-insider
Commit: cb31fc6ce2b4da3520392b622aa3ebc5b313533b
Date: 2020-07-15T05:32:05.866Z
Electron: 8.3.3
Chrome: 80.0.3987.165
Node.js: 12.13.0
V8: 8.0.426.27-electron.0
OS: Linux x64 5.4.0-40-generic snap

Steps to Reproduce:

Install from snapstore:

VSCode or VScode Insider
Node 14 (!also from snapstore)

2.Create react app or clone my sample clear VSCode React project: https://github.com/mwoz123/test-vsc-snap-react (contains only files generated by create-react-app script + launch.json + settings.json -> see comits)

run npm i

Open in VSC folder test-vsc-snap-react

Try debugging react app in VSC using "Debug ReactJS Dev server" launch config.

Previously I'd
The node version in "/snap/bin/node" is outdated(version), we require atleast Node 8.x
but after applying (commited to repo) workaround:
https://github.com/microsoft/vscode/issues/102355#issuecomment-657675345
I've error:
/snap/bin/node --inspect-brk=49578 node_modules/react-scripts/scripts/start.js --inspect-brk=39841
ℹ ｢wds｣: Project is running at http://<IP_ADDRESS>/
PrefixFactory.js:55
ℹ ｢wds｣: webpack output is served from
PrefixFactory.js:55
ℹ ｢wds｣: Content not from webpack is served from /home/marcin/workspace/test-react/test-vsc-snap-react/public
PrefixFactory.js:55
ℹ ｢wds｣: 404s will fallback to /
PrefixFactory.js:55
Starting the development server...

start.js:157
Error: EACCES: permission denied, read
Emitted 'error' event on ReadStream instance at:
    at internal/fs/streams.js:217:14
    at FSReqCallback.wrapper [as oncomplete] (fs.js:524:5)

Software installed from snapstore:

marcin@dell:~$ snap list
Name                     Version                     Rev   Tracking         Publisher        Notes
canonical-livepatch      9.5.5                       95    latest/stable    canonical✓       -
chromium-ffmpeg          0.1                         15    latest/stable    canonical✓       -
clementine               latest                      890   latest/stable    kz6fittycent     -
code                     485c41f9                    37    latest/stable    vscode✓          classic
code-insiders            cb31fc6c                    482   latest/stable    vscode✓          classic
core                     16-2.45.1                   9436  latest/stable    canonical✓       core
core18                   20200707                    1880  latest/stable    canonical✓       base
gimp                     2.10.20                     281   latest/stable    snapcrafters     -
gnome-3-28-1804          3.28.0-17-gde3d74c.de3d74c  128   latest/stable    canonical✓       -
gnome-3-34-1804          0+git.3009fc7               36    latest/stable/…  canonical✓       -
gtk-common-themes        0.1-36-gc75f853             1506  latest/stable/…  canonical✓       -
kde-frameworks-5-core18  5.61.0                      32    latest/stable    kde✓             -
node                     14.4.0                      2799  14/stable        nodesource✓      classic
opera                    69.0.3686.77                82    latest/stable    opera-software✓  -
qmmp                     1.4.0                       5     latest/beta      the-mentor       -
snap-store               3.36.0-80-g208fd61          467   latest/stable/…  canonical✓       -
snapd                    2.45.2                      8542  latest/stable    canonical✓       snapd
snapdiff                 0.1                         1     latest/stable    mwhudson         classic
teams-for-linux          1.0.5                       105   latest/stable    alarconj         -
marcin@dell:~$

Does this issue occur when all extensions are disabled?:
Yes
Exactly same behaviour for non-insiders version:
Version: 1.47.1
Commit: 485c41f9460bdb830c4da12c102daff275415b53
Date: 2020-07-14T00:13:57.513Z
Electron: 7.3.2
Chrome: 78.0.3904.130
Node.js: 12.8.1
V8: 7.8.279.23-electron.0
OS: Linux x64 5.4.0-40-generic snap

From command line npm start starts react server without any problems.

It seems like one workaround is setting "console": "integratedTerminal", (does not need debug.javascript.usePreview to be false)
Interestingly I don't see this happen even if I use the VS Code electron instance to spawn the start script...
ELECTRON_RUN_AS_NODE=1 /snap/code-insiders/479/usr/share/code-insiders/code-insiders -e 'require("child_process").spawn("/snap/bin/node", ["node_modules/react-scripts/scripts/start"], { stdio: "inherit", env: process.env });' # works

...it only seems to happen (on both the old and new debuggers) when started from the extension host. (Though maybe snap does extra sandboxing when launching the app which the CLI doesn't.)
We can launch Node when it's installed via apt or nvm just fine, only snap node is busted.
cc @joaomoreno / @deepak1556 if you have any idea what's going on here. Daniel isn't sure and I've no familiarity with snap internals. Leaning towards this being an upstream issue in snap or Node's snap image.

@connor4312 Related? https://github.com/microsoft/vscode-vsce/issues/452#issuecomment-656465092

@connor4312 - workaround "console": "integratedTerminal", in launch.json works for me,
but only when I've "debug.javascript.usePreview": falsein settings.json

@mwoz123 if you update to the most recent insiders or use the js-debug nightly build it should work without disabling preview.
@joaomoreno quote possibly. There seem to be multiple 'weird' things about Node Snap.

I don't think there's anything actionable from the VS Code side on this.


Add documentation for fixes

Adds documentation for using ruff check . --fix
Uses the draft of the "Automatic fixes" section from https://github.com/astral-sh/ruff/pull/7732 and adds documentation for unsafe fixes, applicability levels, and https://github.com/astral-sh/ruff/pull/7841
I enabled admonitions because they're nice. We should use them more.

Ah mdformat puts code fences on admonitions... will need to investigate. Maybe relevant https://github.com/cljdoc/cljdoc/issues/95


concussion creepers effects hit everyone on a server not just the person hit

the teleport does not happen to anyone but the player hit
however the wavy animation plays for everyone when a person is hit by one!

Cannot reproduce with the latest version.


IGNITE-14915 Fix packet structure in network and network-processor modules

https://issues.apache.org/jira/browse/IGNITE-14915

@sashapolo Could you please also fix all packages' mentions in *.xml files? E.g. maven-javadoc-plugin contains some exclusions in parent/pom.xml file.


chore(package): update dependencies

Update dependencies as per Greenkeeper's suggestion.

Release as<EMAIL_ADDRESS>


MGMT-8156: Merge translation files from assisted-ui-lib into one file

Related to https://github.com/openshift-assisted/assisted-ui-lib/pull/1399
Related to https://issues.redhat.com/browse/MGMT-8156
Signed-off-by: Montse Ortega<EMAIL_ADDRESS>

/ok-to-test

/lgtm


QA: Fluids Reports: GET with UID Size

EPIC:
#491 Fluids Report Implementation
PARENT:
#492 Get from Store (R) Fluids Report Object
SIZE:
4 hours = 1/2 day =  1 point
QA: Fluids Reports: GET with UID Size – (1pt)

@shehzadsidi what is the current status on this item including the planned ETA?

GetFromStore with UID successfully tested in container 0.17.0.  Closing the card

Reopened since I need to test the "Rheometer" elements for Container 0.17.1


Update getValue in after prepare to ignore attributes

Cordova added an attribute called "short" on the name in the config.xml.  The after prepare script will fail to get the project name because of the added attribute.
https://cordova.apache.org/docs/en/latest/config_ref/#short-name
fixes #723

@kpfecteau please fix merge conflicts


FinallAttack Bug?

Hello, I have the following problem...
If I want to hit a player it only works 2-3 times then it doesn't work anymore. It only works if the player I want to hit gets damaged again by something else (e.g. falling damage) In my opinion this is not normal xD

Hey! This is quite some time ago (I wasn't looking after this project). If this issue is still relevant please open another issue describing exactly what you are doing (give a minimal code example).


Cant run example models in colab due to lightning error

Hi, I've tried a few of the notebooks you provided for the examples but I run in to the same error across all of them in colab with the following error:
ImportError                               Traceback (most recent call last)
[<ipython-input-6-548ac97a7512>](https://localhost:8080/#) in <module>
     15 # dalle classes
     16
---> 17 from dalle_pytorch import DiscreteVAE
     18
     19 # constants

4 frames
[/usr/local/lib/python3.7/dist-packages/taming/main.py](https://localhost:8080/#) in <module>
     10 from pytorch_lightning.trainer import Trainer
     11 from pytorch_lightning.callbacks import ModelCheckpoint, Callback, LearningRateMonitor
---> 12 from pytorch_lightning.utilities.distributed import rank_zero_only
     13
     14 def get_obj_from_str(string, reload=False):

ImportError: cannot import name 'rank_zero_only' from 'pytorch_lightning.utilities.distributed' (/usr/local/lib/python3.7/dist-packages/pytorch_lightning/utilities/distributed.py)

I think the version of lightning that is installed by the script might be incorrect now?
Any help getting this fixed is greatly appreciated!
Thanks

Any solution?

Any solution to this?

any solution to this? facing the same in conda 3.9.7 and python3 (3.11.5) as well.

I got this to work by manually installing pytorch-lightning==1.9.0 instead of >2.0.0 (rank_zero_only is deprecated).


Plugins?

What feature or improvement do you think would benefit Files?
Do you have any plans to allow for the development of plugins?

Requirements

This proposal will accomplish X
This proposal will accomplish Y
This proposal will accomplish Z

Files Version
Any
Windows Version
Any
Comments
No response

Files supports shell extensions in the context menu, we don't have plans for any other plugins though.


finished event not implemented in iOS?

Might be an oversight on my behalf, but I don't think the finished event is plugged in for iOS.
I see code implemented in it for Android, and can confirm it works properly there.  I don't see anything written for iOS, and also cannot get it to fire in iOS at all.
Feel free to close this issue if I've clearly overlooked something.

@bradmartin  - I've been able to get this working by fiddling with the JS in my node_modules dir.  I'd issue a pull request, but I'm having difficulty getting the project running for local dev, and I'm also a total noob to TypeScript.
In the constructor of the Video class for videoplayer.ios, I've added the following code, which fires  the finished event correctly.
If any other contributor could assist in implementing this, that'd be great.
var self = this;

if (this.finishedCallback) {
    //console.log("yo, finished callback exists");
    var nsCenter = NSNotificationCenter.defaultCenter();
    nsCenter.addObserverForNameObjectQueueUsingBlock(AVPlayerItemDidPlayToEndTimeNotification, null, null, function() {
        self._emit(common.Video.finishedEvent);
    });
}

Awesome. I can handle the typescript for this and test to confirm all is
fine. Thanks
On Tue, Jun 21, 2016, 4:53 PM George Huber<EMAIL_ADDRESS>wrote:

@bradmartin https://github.com/bradmartin - I've been able to get this
working by fiddling with the JS in my node_modules dir. I'd issue a pull
request, but I'm having difficulty getting the project running for local
dev, and I'm also a total noob to TypeScript.
In the constructor of the Video class for videoplayer.ios, I've added the
following code, which fires the finished event correctly.
If any other contributor could assist in implementing this, that'd be
great.
var self = this;
if (this.finishedCallback) {
//console.log("yo, finished callback exists");
var nsCenter = NSNotificationCenter.defaultCenter();
nsCenter.addObserverForNameObjectQueueUsingBlock(AVPlayerItemDidPlayToEndTimeNotification, null, null, function() {
self._emit(common.Video.finishedEvent);
});
}
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/bradmartin/nativescript-videoplayer/issues/21#issuecomment-227584154,
or mute the thread
https://github.com/notifications/unsubscribe/AFulhF6kVN8kUZTG2wqhxm1hb20XZN1Jks5qOF1ygaJpZM4I7Khh
.

hey @handlebarcreative just adding this to a pull request now.. for testing purposes, what was your local code to link up the finishedCallback?

this is now working in my latest PR

hey @bnussey - I wasn't doing anything fancy for the finished callback.  In my xml just:
<VideoPlayer:Video src="~/myvideo.mp4" finished="videoFinished" autoplay="false" height="300" width="300" />

Thanks @handlebarcreative my issue was i was using Angular2 but figured it all out, appreciate your assistance.


Move React from dependencies to peerDependencies

At the moment React is in dependencies which means 15.3.2 is being forced on everyone who uses styled-components. They'll end up having two versions of React in their node_modules if they aren't on the same version. I believe this can cause problems with Webpack (this may be fixed now).
This change moves React into peerDependencies like most other libraries that need React do. I also allowed React 0.14.x to be used and apart from some failing tests in validAttr (I've commented them out so you can see which ones) everything seemed fine. I believe the failing tests are just because React 15 has a lot better support for SVG and a few newer HTML attributes.
React has also been added to devDependencies to be more convenient during development and to avoid peer dependency warnings.
So the main benefit of all this is more people can use styled-components even if they're on an older version of React.

I've been wondering if this works as expected, even in the UMD build. Can you test that?

It works as expected for me. React is in the devDependencies so you have it when you generate the UMD build.

I think it's a good idea to move the react dependency to peerDependencies. As for the tests, what are they really testing? It seems like they test React itself more than they test this framework. Thoughts?

As for the tests, what are they really testing?

They are testing that we allow all valid attributes through to the DOM node. That these tests break on react 0.14 means that people will have a horrible experience using styled-components with it, because we won't allow attributes to be attached to the DOM node underneath.
Can we maybe inline the react 15.0 list? We should do that anyway, and it'd mean nothing breaks on 0.14!

OK, I've inlined the list from React 15. I think it's the best thing to do, especially after this comment. It should also reduce file size as other things were being pulled in from the imported files that weren't being used.
Original tests pass with both React 0.14 and 15.

Awesome, thanks!

Thank you!


Get named nodes removed unnecessary sorting

The get_named_nodes of DAGCircuit was unnecessarily sorting the graph nodes in topological order.
Description
I have removed the sorting and replaced it with a list generator.
Motivation and Context
I noticed that a decent amount of time was spent in the get_named_nodes function and noticed that it was sorting the multi_graph for no apparent reason. That's why I rewrote it.
How Has This Been Tested?
I added a simple test case and tested all offline tests locally.
Screenshots (if appropriate):
Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[x] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[x] I have updated the documentation accordingly.
[x] I have read the CONTRIBUTING document.
[x] I have added tests to cover my changes.
[ ] All new and existing tests passed.

We could also use a generator instead, but this could break some use sites which modify the DAGCircuit. Those use cases would then have to instantiate a list explicitly first before modifying the DAG. Otherwise the user gets an error that the dictionary was changed during iteration.

Should get_named_nodes return a set instead of a list, since we don't care about the ordering?

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.1 out of 2 committers have signed the CLA.:white_check_mark: eddieschoute:x: diego-plan9You have signed the CLA already but the status is still pending? Let us recheck it.

I really like the idea of returning a set. The iteration interface is not modified and the lack of order is highlighted. Not mandatory but go ahead if you feel the same.

I have changed it to a set, but now it is also a breaking change.

Why? I don't see anything changed. Is this method intended to be exposed to 3rd party code? If that's the case, we should not introduce a breaking change but I thought this was meant to be used internally-only.

Why? I don't see anything changed. Is this method intended to be exposed to 3rd party code? If that's the case, we should not introduce a breaking change but I thought this was meant to be used internally-only.

I don't see why it should be used internally only, since it's not a private method.

Qiskit is still a pre-release version so I doubt we would need to go through a deprecation process. But I don't really mind since all I want it the code calling get_named_nodes internally in DAGCircuit to use the faster variant.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.5 out of 10 committers have signed the CLA.:white_check_mark: ajavadia:white_check_mark: abdonrd:white_check_mark: jaygambetta:white_check_mark: yaelbh:white_check_mark: nonhermitian:x: eddieschoute:x: diego-plan9:x: eendebakpt:x: delapuente:x: atilagYou have signed the CLA already but the status is still pending? Let us recheck it.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Hopefully this time the CI won't be broken!

Thanks @eddieschoute and @delapuente.


Made release

Hi,,
On the debian side we want to package this tree in order to share this kbibtex.
Could be possible to make tag, thus release
Bastien

I did not know that it was available in kbibtex. Nice to hear 🤩.
This also refs https://github.com/koppor/jabref/blob/about/jabref-in-debian.md.

Here you go: https://github.com/JabRef/abbrv.jabref.org/releases/tag/2021-09


Added 3D click button

Fixes Issue
Closes #1342
Changes proposed
I added a 3D shadow Button
Screenshots

https://github.com/Spyware007/Animating-Buttons/assets/74257754/dd0ad7af-9919-41db-9218-fc9576988a13
Checklist

[x] You've linked this PR to the correct issue.
[x] You have checked that the code is working correctly.
[x] You ⭐ the repository!

Note to reviewers
@Spyware007 @Souravvmishra
I am writing to kindly review and accept my pull request; your feedback  is appreciated.

Removed, please have a look. Thanks

Great Buddy


UX: Add page #s and # of results to pagination component.

Close #158

@Alex-Cannon I cherrypicked the changing commit and tested that. Looks good, merged into master.


Delete local variables?

In class Z2UI5_CL_HLP_TREE_XML Method WRITE( ), the DATA declarations
     mo_document TYPE REF TO if_ixml_document,
     mo_parser   TYPE REF TO if_ixml_parser_core,

overwrite attribute declaration for the same identifiers in the class. I guess it can be outright deleted?
I would appreciate if you could you provide some guidance on this.
regards,
Jacques

yes i think you can also just delete the whole class because it is not used somewhere else:

i forgot to clean this up after i switched to a simple method which is parsing the xml.

@nomssi i updated ABAP2UI5 now to a new versions. you have to do small changes to your apps to make them compatible to the new version, but then you have a lot more freedom and can build better apps ;)
if there are some problems with the on-prem compatibility with the new version, just let me know, that i can fix it.

@oblomov-dev there are two errors I had to fix before getting this version to run:

Class Z2UI5_LCL_UTILITY Method TRANS_REF_TAB_2_TAB( )
you cannot dereference a field symbol in lower releases.
Class Z2UI5_LCL_UTILITY_TREE_JSON Method  GET_ATTRIBUTE( )
Exception CX_ABAP_API_STATE does not exist. I replaced it with CX_UCON_API_STATE but it should probably be more generic.

Thanks for the update

My workaround for TRANS_REF_TAB_2_TAB does not work. It helps to compile and run many demos, but not  all.

Here is an update:

Thanks a lot!
i updated both now and comited it to the main branch.
The CX_UCON_API_STATE does not exist in cloud so i replaced it with a local exception.
The coding change in the loop somehow does not update the value in the table, so the editable table function is not working. Therefore i needed to replace it with that:

Is   = lr_data_ui5->* compatible with your version?

No, I get  the error:" A generic reference cannot be dereferenced (->) in the current statement."
A second field symbol is needed here, I got it to work with

thanks a lot for your work @nomssi!!!
I merged your branch and made some other fixes. so far it works fine on my side. let me know if there are still any problems.

Works for me thanks.


Default configuration providers should apply in a similar order to ASPNET Core defaults

See https://devblogs.microsoft.com/premier-developer/order-of-precedence-when-configuring-asp-net-core/ - specifically, it makes sense to apply environment variables after all configuration files.
There's probably two problems:

In the bootstrapper defaults for Statiq Framework AddEnvironmentVariables() is called before the AddSettingsFile() calls, and so the IConfigurationBuilder applies configuration in the order it's defined. So that's a bug.
But then there's a design problem too in that Statiq Web also needs to add some configuration files of it's own for themes, and those though also come before the environment variables, but by the time Statiq Web gets to configure the initial providers are already added.

As for settings from the CLI (--setting key=value), those are always going to apply after any IConfigurationProvider stuff since it's a different mechanism in Statiq. That probably won't change so we'll need to document the difference.

Turns out the configuration file processing in Statiq Web is done well after the IConfigurationBuilder has been built and applied and only adds settings from theme configuration files if they don't already exist (effectively  making them a lower priority). So the only thing that really needed to be fixed here was the ordering of environment variables vs. default configuration files in Statiq Framework. That's done now and will ship in the next release.


Upgrade to the latest graphsync and datatransfer

Upgrade to the latest graphsync and datatransfer.

Codecov Report

Merging #112 (ae03a5b) into main (537d8c5) will decrease coverage by 0.01%.
The diff coverage is 40.00%.

@@            Coverage Diff             @@
##             main     #112      +/-   ##
==========================================
- Coverage   64.91%   64.89%   -0.02%
==========================================
  Files          21       21
  Lines        2035     2034       -1
==========================================
- Hits         1321     1320       -1
  Misses        550      550
  Partials      164      164

Impacted Files
Coverage Δ

dtsync/voucher_cbor_gen.go
40.41% <0.00%> (ø)

dtsync/voucher.go
53.33% <66.66%> (-2.92%)
:arrow_down:


custom tuple implementation is conditional

We could selectively use <tuple> instead of our slim tuple, on C++ versions / compilers that give us the constexpr and empty base optimization that we need.

Perhaps there is not much to be gained here since we would be effectively be creating an extra implementation combination that needs testing


Relationship field is of type number | MyType

Link to reproduction
No response
Payload Version
3.0.0-beta.46
Node Version
v20.10.0
Next.js Version
15.0.0-rc.0
Describe the Bug
When i try to access a field of type relationship, it is either a number or the actual collection type. I was wondering if the number type is even needed since I always get back the actual object from the collection.
My Collection has this field in it:

export const Tags: CollectionConfig = {
  slug: 'tags',
  fields: [
    {
      name: 'title',
      type: 'text',
      required: true,
      unique: true,
      localized: true,
    },
  ],
}

// somewhere in another collection
export const Events: CollectionConfig = {
  slug: 'events',
{
      name: 'tags',
      type: 'array',
      required: true,
      fields: [
        {
          name: 'tag',
          type: 'relationship',
          relationTo: 'tags',
          required: true,
          index: true,
        },
      ],
}
}

When I query the collection the tags field contains tags typed as number | Tag even though the actual tag always is an object of this form:
{
  createdAt: "2024-06-26T12:41:40.270Z"
  id: 1
  title: "test"
  updatedAt: "2024-06-26T12:41:40.270Z"
}

Reproduction Steps

Create Collection
Create another collection with a field of type "relationship" and reference the other collection
the relationship field will be typed as number | NameOfYourType

Adapters and Plugins
db-postgres

This is intended actually and you need to narrow down the type in your code when dealing with this by checking if it's a string/number or your object.
The reason it's this way is because depending on depth when fetching the data or access permissions, you may not receive back the full object and just the ID which can be a string or a number depending on your DB settings.


Array adapter view is not refreshing after removal of string from content.

Instead of content[] string, I made it as arraylist of string. On far left event, I am deleting that string from   the arraylist. The string gets deleted from the arraylist but the view of ListView is not refreshed event after calling notifyDataSetChanged() in both stringAdapter and mAdapter

There could be a million different things wrong with your code. For example are you sure you're manipulating the actual ArrayList rather than a deep copy of it?
I'm not having any issues with it. You'll have to come up with a code sample that allows me to reproduce this issue.

This is my code, modified version of your example: http://pastebin.com/7SnPrdz2

Try to use the remove method of the ArrayAdapter. I think that's actually keeping a copy of your data rather than a reference to it.

Ok. I replace 'list.remove(position)' with 'stringAdapter.remove(stringAdapter.getItem(position))', now the listView refreshes but if I swipe on row3, row4 gets deleted and if I use position-1, swipe on row5, row4 gets deleted.

The recommended pattern is to modify the ArrayList you're keeping in your application, clear the ArrayAdapter and then re-populate it with the modified ArrayList.

Check my pull request, it solved the problem. No need to re-populate ArrayAdapter.


NextJS Client/Server Environment Variables with multiple environments

Is your feature request related to a problem? Please describe.
When using NextJS with Sanity Preview, the dataset is determined by the environment variable NEXT_PUBLIC_SANITY_DATASET. However, Next permanently bakes public env variables into the javascript bundle. Thus, when I build a docker image with the production dataset, it's not possible to run this image in a development environment using my develop dataset. Using SANITY_DATASET instead fixes the problem with using alternate datasets at runtime, but breaks preview since it's not available on the client.
To rectify this, I ended up using both env variables, using the public variable as a fallback for client code. This enables Next to generate appropriate content on revalidate, though preview is still stuck on the production dataset:
const derivedDataset = process.env.SANITY_DATASET || process.env.NEXT_PUBLIC_SANITY_DATASET;
export const dataset = assertValue( derivedDataset, "Missing environment variable: SANITY_DATASET");

Describe the solution you'd like
I would like to set a single env variable at runtime that would enable me to use an alternate dataset generate page content on revalidate, and to use in preview mode.
Describe alternatives you've considered
My current solution isn't terrible since preview mode in a development environment isn't completely necessary, but it would be nice to at least have a neater way of achieving it with 1 env variable.
Additional context
See Slack conversation: https://sanity-io-land.slack.com/archives/C013NG0UF0B/p1706826945250429?thread_ts=1706803404.802629&cid=C013NG0UF0B

Hi, this is out of scope for us as we have no control over how Next.js handles environment variables.


get_installed_distributions of pip does not exists

This part of document does not work for synapse anymore,
import pip #needed to use the pip functions
for i in pip.get_installed_distributions(local_only=True):
print(i)
The following python code works for the same purpose,
import pkg_resources
for d in pkg_resources.working_set:
print(d)

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 6062879d-b323-e01a-bfc0-b31124e74ea8
Version Independent ID: ba40190c-159c-b29f-4697-77b6275f8cfb
Content: Manage libraries for Apache Spark in Azure Synapse Analytics - Azure Synapse Analytics
Content Source: articles/synapse-analytics/spark/apache-spark-azure-portal-add-libraries.md
Service: synapse-analytics
Sub-service: spark
GitHub Login: @euangms
Microsoft Alias: euang

@xiopeter3345  Thanks for bringing this to our attention. We will investigate and update as appropriate.

Duplicate of #66324


grommet check lint also JSX 💭

Hi, I start using grommet recently and came up with some weird situation.
The test command that under the hood runs grommet check is not linting my .jsx files.
Digging a bit I found the situation is caused apparently by this line on check command:
eslintChild.send('**/*.js');

Am I missing something here? 🤔
Is there a way to tell eslint to check also .jsx files?

good point. sorry for taking such a long time to get back to you on this. are you up for a pull request to change this expression to also handle JSX extensions ?
eslintChild.send('**/*.jsx?');

I believe this will work :)

Just let get back from holidays and I'll issue a PR :)

nice! thank you very much


About us Section improved #77

I have added some hovering effects with transformation scale, color change on hovering  #77
https://github.com/HimanshuNarware/CareerZunction_Intern/assets/164533685/e1d5a999-9145-40d7-997a-2619f0b4463c

@reshamsai150 @PSS2134  Not matching with the UI of the app


Cannot build face module on OS X

System: OS X 10.10.5
Build-Type: Debug
I just pulled the most recent commit a4692a0da5367ace9006a0978dd50fb740f53a10, also updated the opencv_contrib repo, ran make clean and then tried to build. The result is this:
...
[ 38%] Building CXX object modules/core/CMakeFiles/opencv_perf_core.dir/perf/opencl/perf_bufferpool.cpp.o
[ 38%] Linking CXX shared library ../../lib/libopencv_face.dylib
Undefined symbols for architecture x86_64:
  "cv::face::MinDistancePredictCollector::create(double)", referenced from:
      cv::face::FaceRecognizer::predict(cv::_InputArray const&, int&, double&) const in facerec.cpp.o
  "cv::face::MinDistancePredictCollector::getDist() const", referenced from:
      cv::face::FaceRecognizer::predict(cv::_InputArray const&, int&, double&) const in facerec.cpp.o
  "cv::face::MinDistancePredictCollector::getLabel() const", referenced from:
      cv::face::FaceRecognizer::predict(cv::_InputArray const&, int&, double&) const in facerec.cpp.o
ld: symbol(s) not found for architecture x86_64
clang: error: linker command failed with exit code 1 (use -v to see invocation)
make[2]: *** [lib/libopencv_face.3.1.0.dylib] Error 1
make[1]: *** [modules/face/CMakeFiles/opencv_face.dir/all] Error 2
make[1]: *** Waiting for unfinished jobs....

I was able to build debug version of face module with recent versions of OpenCV and contrib on Mac OS X El Capitan. Our buildbot does not show any errors too: builder.
Try to build OpenCV from scratch.

Looks like the problem does not appear anymore.


Higher ranking fake TaskbarX website on Bing.

Not exactly an issue, but on Bing https://taskbarx.org/ ranks higher than the legitimate website when searching just for the term TaskbarX. Just thought I would let you know if something could be done about it.

is it safe though? I just downloaded the app from there, though it was the official website.

is it safe though? I just downloaded the app from there, though it was the official website.

I checked the links and it seems like it does link to the downloads from the official GitHub. Still it isn't the official site, so that could change at any time.


Capitalized brand names

Capitalized brand names for TensorFlow, GitHub and Jupyter
/assign @abhi-g

This change is

/assign
/ok-to-test
/lgtm
/approve
Thanks!


How can I make DateTimeTZRange work?

First Check

[X] I added a very descriptive title to this issue.
[X] I used the GitHub search to find a similar issue and didn't find it.
[X] I searched the SQLModel documentation, with the integrated search.
[X] I already searched in Google "How to X in SQLModel" and didn't find any information.
[X] I already read and followed all the tutorial in the docs and didn't find an answer.
[X] I already checked if it is not related to SQLModel but to Pydantic.
[X] I already checked if it is not related to SQLModel but to SQLAlchemy.

Commit to Help

[X] I commit to help with one of those options 👆

Example Code
from psycopg2.extras import DateTimeTZRange
from pydantic import conlist
from sqlalchemy import Column
from sqlalchemy.dialects.postgresql import TSTZRANGE
from sqlmodel import Field

from app.models.base import BaseModel

class MyModel(BaseModel, table=True):
    # time_range: conlist(datetime, min_items=2, max_items=2) = Field(
    time_range: DateTimeTZRange = Field(
        sa_column=Column(TSTZRANGE()), nullable=False, index=False
    )

    class Config:
        arbitrary_types_allowed = True

Description
I have a model that has a DateTimeTZRange field. When I try to save an instance of this model, I get the following error:
sqlalchemy.exc.DBAPIError: (sqlalchemy.dialects.postgresql.asyncpg.Error) <class 'asyncpg.exceptions.DataError'>: invalid input for query argument $1: DateTimeTZRange(datetime.datetime(2019, ... (list, tuple or Range object expected (got type <class 'psycopg2._range.DateTimeTZRange'>))
[SQL: INSERT INTO my_model (time_range) VALUES (%s) RETURNING my_model.id]
[parameters: (DateTimeTZRange(datetime.datetime(2019, 4, 2, 23, 0, tzinfo=<UTC>), datetime.datetime(2019, 4, 2, 23, 30, tzinfo=<UTC>), '[)'))]

When I use conlist rather than DateTimeTZRange, I don't get errors but the new objects always have None in their time_range. I couldn't find any documentation on how to use custom PostgreSQL fields in SQLModel, and the documentation I found on sqlalchemy doesn't seem to work smoothly on SQLModel.
Operating System
macOS
Operating System Details
No response
SQLModel Version
0.0.4
Python Version
3.9.9
Additional Context
No response

I experienced no problems saving instances with the conlist version of your code. How did you initialize your model? This, for example, worked for me: MyModel(time_range=[datetime.now(timezone.utc), datetime.max])

Which version of PostgreSQL are you using?

This is a bit tricky due to Pydantic need validators etc. Basically the DateTimeTZRange type does not have the required method to convert its data to a dict, so you need to do that manually.

The code I made below adds to Pydantic's ENCODERS_BY_TYPE
It then creates a sub-class of DateTimeTZRange to include required validators
This subclass also modifies the schema for presentation in the api docs correctly (with example)
Because you are sub-classing the type you don't need arbitrary_types_allowed = True or any class Config:

from psycopg2.extras import DateTimeTZRange as DateTimeTZRangeBase
from sqlalchemy.dialects.postgresql import TSTZRANGE
from sqlmodel import (
    Column,
    Field,
    Identity,
    SQLModel,
)

from pydantic.json import ENCODERS_BY_TYPE

ENCODERS_BY_TYPE |= {DateTimeTZRangeBase: str}

class DateTimeTZRange(DateTimeTZRangeBase):
    @classmethod
    def __get_validators__(cls):
        yield cls.validate

    @classmethod
    def validate(cls, v):
        if isinstance(v, str):
            lower = v.split(", ")[0][1:].strip().strip()
            upper = v.split(", ")[1][:-1].strip().strip()
            bounds = v[:1] + v[-1:]
            return DateTimeTZRange(lower, upper, bounds)
        elif isinstance(v, DateTimeTZRangeBase):
            return v
        raise TypeError("Type must be string or DateTimeTZRange")

    @classmethod
    def __modify_schema__(cls, field_schema):
        field_schema.update(type="string", example="[2022,01,01, 2022,02,02)")

class EventBase(SQLModel):
    __tablename__ = "event"
    timestamp_range: DateTimeTZRange = Field(
        sa_column=Column(
            TSTZRANGE(),
            nullable=False,
        ),
    )

class Event(EventBase, table=True):
    id: int | None = Field(
        default=None,
        sa_column_args=(Identity(always=True),),
        primary_key=True,
        nullable=False,
    )

Pydantic issues:

https://github.com/tiangolo/fastapi/issues/1285
https://github.com/samuelcolvin/pydantic/issues/951
https://github.com/samuelcolvin/pydantic/issues/380

Pydantic reading:

https://pydantic-docs.helpmanual.io/usage/schema/#modifying-schema-in-custom-fields
https://pydantic-docs.helpmanual.io/usage/types/#custom-data-types
https://pydantic-docs.helpmanual.io/usage/validators/

We had a similar question for our project, but for a DateRange adapter instead.
We adapted @Zaffer's suggestion, and it worked splendidly for persisting a value. But when the instance was refreshed/reloaded from the db, the field's resulting value on the SQLModel-derived instance was not the expected custom DateRange subclass, but rather a sqlalchemy.dialects.postgresql.ranges.Range instance (i.e., an instance of the DATERANGE used to specify the Column type).
I'm still trying to understand the mechanisms used to hydrate a row of SQL data into a Pydantic instance, but I would've expected it would attempt to cover the loaded data into the specified type on the SQLModel class.
Is this a bug, a misconfiguration, or a misunderstanding of how SQLModel/Pydantic/SQLAlchemy work?
from datetime import date

from psycopg2.extras import DateRange as DateRangeBase
from sqlalchemy.dialects.postgresql import DATERANGE

def _to_date(value: str) -> date:
    vals = map(
        int, value.strip().replace("[", "").replace(")", "").split("-", maxsplit=2)
    )
    return date(*vals)

class DateRange(DateRangeBase):
    """
    A range of dates, used for persisting in a PostgreSQL database.
    """

    @classmethod
    def __get_validators__(cls):
        yield cls.validate

    @classmethod
    def validate(cls, v):
        if isinstance(v, DateRangeBase):
            return v
        if isinstance(v, str):
            lower, upper = map(_to_date, v.split(sep=",", maxsplit=1))
            bounds = v[:1] + v[-1:]
            return DateRange(lower, upper, bounds)
        raise TypeError("Type must be a string or DateRange")

    @classmethod
    def __modify_schema__(cls, field_schema):
        field_schema.update(type="string", example="[2022-01-01,2022-02-02)")

class EventBase(SQLModel):
    date_range: DateRange = Field(sa_column=Column(DATERANGE(), nullable=False))

@shaug - did you ever get any further with this as a solution?

We've ended up needing to create SQLAlchemy TypeDecorators for every type we wanted to properly convert from its database representation into its Python instance.


Suggested edits to documentation text

The following changes were made. See below for requested additions from @zargot and @yulric

Tutorials were renamed to be more descriptive:

Tutorial 1 —> Getting started
Tutorial 2 —> Getting to know the validation library

Edits were made throughout the tutorials. No change in content:

minor rearrangements in the content.
Headings for tutorial 2.
Grammar and spelling.

Added sections to the index page. The added sections are often found in Python library documentation. A better option may be to put the ‘usage’ section on a separate page.

Overview section. This section seems straightforward to add.
Installation. I recommend we add an installation section. Yes, there is an install section in one of the tutorials, but users expect installation on the main page. I suggest that we keep installation in both the index and tutorial. If we want to install instructions in one place, it would be the main index page.
Usage. Again this section is somewhat duplicative of the tutorial and explanation guide. These usage sections would be 'how-tos'. Short and to the point.
FAQ. I suggest that we point people to Discourse and GH Issues. This section seems duplicative of the ‘contributing’ section, but they are different concepts. Thoughts? We would need to add a few FAQs to the Discourse forum.

@zargot, could you add the missing pieces to the index page?

@zargot could you check the links.  I inserted placeholders for a few links. Could you search:

“insert the link to the missing_mandatory_column rule”
“insert the link to data type rule”

Do we need the Jupyter notebook?

I removed it :)

Do we need the Jupyter notebook?

I removed it :)

Jupyter files may have been generated during quarto render, but that should only be an intermediate file. Right?

Do we need the Jupyter notebook?

I removed it :)

Jupyter files may have been generated during quarto render, but that should only be an intermediate file. Right?

Yes, that's correct. I added them to the gitignore now. :)


MAINT: Added clang-format formatting for special C++ files

Reference issue
https://github.com/scipy/scipy/pull/19601
What does this implement/fix?
This adds simple autoformatting for the C++ special files, as discussed in the above PR. It is just clang-format, a widely used tool for C++ code, the standard of which is specified by the added .clang-format file. This only affects the new C++ files in special.
Of course, we can change the formatting standard as we go, it is just nice to have something.

I'm happy with newlines at the end of each file, and there is an option for this in clang-format (InsertNewlineAtEOF). But it is not supported until version 16! I'm on Ubuntu 22.04, and only have version 14.

there is an option for this in clang-format (InsertNewlineAtEOF). But it is not supported until version 16

Will the formatter remove new lines with the current configuration? If so, then no worries. If not, then we can push the manual changes.

@lucascolley Seems like it doesn't touch the newlines if we put them there manually. So have done so!

Could we please stick to 4 spaces? This is extremely difficult also on Fortran files, it's not an urgency but seriously difficult when you are going around like a madman inside very long if blocks. Also we are the python folks afterall

Could we please stick to 4 spaces? This is extremely difficult also on Fortran files, it's not an urgency but seriously difficult when you are going around like a madman inside very long if blocks. Also we are the python folks afterall

Happy with this, will change it when I get a chance.

Sorry, pulled the trigger too soon merging. Yeah, 4 spaces is fine.

In addition, in the next PR, can you please add entries for style-only commits in .git-blame-ignore-revs? We want to keep git blame as useful as possible.
+1 for adding clang-format support though, thanks for doing that.


[WebToolsE2E][Aspire] On a clean Windows machine with only .NET 9 SDK installed, when we open Aspire 8.1 solution, the restore fails and asks us to install aspire workload

Is there an existing issue for this?

[X] I have searched the existing issues

Describe the bug
INSTALL STEPS

Clean machine: Win11 x64 23h2 ENU
Install .NET SDK 9.0 RC2 - latest version

Apply dotnet9rc2feed
Run cred helper to authenticate the feed

Apply feed for Aspire 9.0 packages

Add dotnet8 feed

REPRO STEPS

Clone the repo WebTools-Samples-Aspire and checkout the rel/8.1 branch

This is a simple repo that includes an AspireApp2_withRedis solution created using VS with Aspire 8.1.0

Run dotnet restore in the solution folder

ACTUAL
Message asking the user to install aspire workload

EXPECTED
Clear messages that describe to the user how to upgrade their solution to Aspire 9.0
ADDITIONAL INFO
dotnet --info

dotnet workload list

This is expected. Working on Aspire 8.x projects requires the workload. It's only Aspire 9.x projects that remove the requirement for the workload.

Closing as by design.


Any instead of Count in IIS UrlRewriteFileParser

Resolve the conversation in PR #11533.

@aspnet-hello triage https://dev.azure.com/dnceng/public/_build/results?buildId=237595

This comment was made automatically. If there is a problem contact<EMAIL_ADDRESS>I've triaged the above build. I've created/commented on the following issue(s)
https://github.com/aspnet/AspNetCore-Internal/issues/2303

Thanks!