about booking for train

Hi,
I suspected that the function add_sys_da (https://github.com/ConvLab/ConvLab/blob/919d88aecb5d8ee8c167ae1ba5d6589acd1dce19/convlab/evaluator/multiwoz.py#L78) about booking for train.
MultiWozEvaluator monitor booked state using add_sys_da from https://github.com/ConvLab/ConvLab/blob/919d88aecb5d8ee8c167ae1ba5d6589acd1dce19/convlab/evaluator/multiwoz.py#L94 to https://github.com/ConvLab/ConvLab/blob/919d88aecb5d8ee8c167ae1ba5d6589acd1dce19/convlab/evaluator/multiwoz.py#L102.
In line https://github.com/ConvLab/ConvLab/blob/919d88aecb5d8ee8c167ae1ba5d6589acd1dce19/convlab/evaluator/multiwoz.py#L97,
the condition only handle da == "train-offerbook-ref", not "train-offerbooked-ref".
I understood "train-offerbook" means that the system suggest the user to book, not booked.
and "train-offerbooked" means the system has booked user's ticket.
The reason is, I logged my system and Those are the message.
Case1-1) (train-offerbook),
[Syst] tr8464 arrives at 17:43. would you like to book it?
[SYS_DA] train-inform-id-tr8464
[SYS_DA] train-inform-arrive-17:43
[SYS_DA] train-offerbook-none-none
Case1-2) (train-offerbook)
[Syst] i have train tr8842 that will arrive at 07:52. would you like me to book that for you?
[SYS_DA] train-inform-arrive-07:52
[SYS_DA] train-inform-id-tr8842
[SYS_DA] train-offerbook-none-none
Case2-1) (train-offerbooked)
[Syst] i have booked you for the tr8842 train. the total fee is 8.08 gbp payable at the station. your reference number is : r6h3h3h
[SYS_DA] train-offerbooked-id-tr8842
[SYS_DA] train-offerbooked-ticket-8.08 gbp
[SYS_DA] train-inform-ref-r6h3h3h
Case2-2) (train-offerbooked)
[Syst] i have booked 5 tickets for you. the reference number is : zlm0wvqs. is there anything else i can help you with?
[SYS_DA] train-offerbooked-ref-zlm0wvqs
[SYS_DA] train-offerbooked-people-5
[SYS_DA] general-reqmore-none-none
And, I never saw the case "train-offerbook-ref" just in my system.
If the user simulator need to make those case, the system need to say like below.
"Would you like to book that train which the reference number is 01234567"
=> "train-offerbook-ref-01234567"
Q1. Should my model say like this?
I did the evaluator option (MultiWozEvaluator).
and user simulator(env) spec in baseline.json is MILU(NLU)-Agenda(UserPolicy)-RuleBased(SysPolicy)-TemplateNLG(NLG).
Q2. Could you add the case of condition "train-offerbook-ref"? (If not, could you say the reason?)
Thank you :)

Thanks @jeonggwanlee . It's fixed now. #38

Thank you! @truthless11


Add Lighthouse report history pages

Adds permalinks for each page w/ links to their historical results. It does so by reading all the reports in the docs/reports/ directory and generating a JSON index of all the report data organized by both dates and pages. Webpack reads the JSON file and spits out an HTML file for each page.
Note: Ignore all the changes in the docs/ directory. In a future PR we'll move all those files to their own branch and gitignore the directory.
Changes

Modified index.njk to accommodate the new data format and added page.njk for the new pages.
Added scripts under /scripts for processing the reports. The entry point is scripts/create-reports-index.js.
Tests in test/ to validate the above scripts.

Testing

Pull down this branch
yarn to install dependencies.
yarn test to ensure tests pass.
yarn index-reports to index all the reports in docs/reports/ and generate docs/reports.json. It will also delete extraneous report files.
yarn build to run webpack and generate the website (homepage and individual cf.gov pages) from reports.json.
yarn serve to server the docs/ directory locally and preview the site at http://<IP_ADDRESS>:8080/.
Click the "View report history" links to view individual pages' histories.

Screenshots

Notes

Todos

Checklist

[ ] PR has an informative and human-readable title
[ ] Changes are limited to a single goal (no scope creep)
[ ] Code can be automatically merged (no conflicts)
[ ] Code follows the standards laid out in the development playbook
[ ] Passes all existing automated tests
[ ] Any change in functionality is tested
[ ] New functions are documented (with a description, list of inputs, and expected output)
[ ] Placeholder code is flagged / future todos are captured in comments
[ ] Visually tested in supported browsers and devices (see checklist below :point_down:)
[ ] Project documentation has been updated (including the "Unreleased" section of the CHANGELOG)
[ ] Reviewers requested with the Reviewers tool :arrow_right:

Testing checklist
Browsers

[ ] Chrome
[ ] Firefox
[ ] Safari
[ ] Internet Explorer 8, 9, 10, and 11
[ ] Edge
[ ] iOS Safari
[ ] Chrome for Android

Accessibility

[ ] Keyboard friendly
[ ] Screen reader friendly

Other

[ ] Is useable without CSS
[ ] Is useable without JS
[ ] Flexible from small to large screens
[ ] No linting errors or warnings
[ ] JavaScript tests are passing

With these changes there's some inconsistencies in the various GitHub Actions files:

build-and-push.yml runs yarn index-reports then yarn build.
build.yml runs yarn index-reports then yarn build.
lighthouse.yml runs only yarn index-reports and doesn't run yarn build.

Shouldn't lighthouse.yml also run the build and, if so, is it worth just combining the two commands together into one?

Good call @chosak. I think we want lighthouse to only run once per day while the site should be built and deployed after every merged pr? How about these three workflows:

test.yml that runs against opened pull requests and does yarn lint and yarn test.
build.yml that runs against merged pull requests and builds and pushes the website.
lighthouse.yml that runs nightly via cron and does yarn lighthouse before building and pushing the website.

@contolini that sounds good, but for the first one test.yml, did you mean yarn build instead of yarn test?

Should we also do yarn build on PRs, to make sure the build doesn't break?

Yeah, that makes sense -- build it but not push it. 👍


Include Rails 5.2 support

Fixes https://github.com/collectiveidea/interactor-rails/issues/18
And included the latest Ruby 2.5.1 test for travis.

Great job!
Merge it please! :-)

@GeorgeKaraszi Thank you for your first contribution! :tada: If I may, can I ask you to make a few changes?

Please amend your commit to remove the gemspec version bump. That's best left to the maintainer after your changes are merged. There are a couple reasons for this:

There's no guarantee in which order pull requests will be accepted and merged, so this version number might quickly become incorrect.
The maintainers know best how to bump the version, whether it should be major, minor, or patch. In this particular case, I'd probably only bump the patch version. There are interesting discussions on this topic.

Can you convert gemfiles/rails51+.gemfile to gemfiles/rails52.gemfile using gemfiles/rails51.gemfile as a template? That way, we're sure that Rails 5.2 is covered going forward.
Changing the interactor-rails dependency on rails to < 6.0 is premature. We have no idea whether it will work with Rails 5.3. Although this periodic version bumping process is a little painful, it's also important. Please change the requirement to < 5.3.
For future contributions, I'd keep your PR as focused as possible. Adding support for the newest Ruby version is great and a welcomed change but it also has the potential to hold up Rails support if the maintainers had some concerns around it. In this case, no big deal (if it passes)!

Again, thank you for your great and speedy contribution!
@n-n1ks You forgot step #5.

@laserlemon Yea sorry about the version bump (force of habit >_>). I amended and squashed the changes.

@laserlemon - Anything else blocking this from being merged in + a gem version released? Happy to help out here if anything is needed. Unfortunately, this is currently preventing us from upgrading to Rails 5.2 (which fixes a race condition I've looking forward to getting squashed :)). Thanks!!

@laserlemon Don't mean to be nag, but we are going on week 2 with no official word on what's going on.. Is there anything I or anyone else can do to get this moving?

Sorry, no nothing further than needs to be done. I'll cut a new version this morning! Thank you all for your work to get this out the door and sorry for the delay!! 👏🎊👏

Version 2.2.0 :ship:d! Thank you, @GeorgeKaraszi! I did end up bumping the minor version because I dropped Ruby 2.2 (now EOL) from official support (although there should be nothing breaking as of today).


write a knative build template for bender

@TomasTomecek Do we have an official ansible-bender image?

We don't, because all the services are supporting only dockerfiles.
But we could use github actions for this.


Add Clang support to edgesec

Work in progress trying to get edgesec working with the clang compiler.

Huh, I've got no idea why adding Clang is changing the code-coverage values by so much (maybe it calculates lines slightly differently?). But Clang seems to be working, so I'll mark this PR as ready to review!


Feature Request: enable the "eslint.format.enable" setting by default.

I'm probably misunderstanding the ramifications of this feature request, but I think the default value of eslint.format.enable should be true. Actually, IMHO it should be removed and behave like it's always true. Why wouldn't that be a good idea?
If you already use eslint as a formatter on the command line, it's unintuitive to install this extension and see eslint sorta work. This was my experience:

"It lints like on the command line, but it's not formatting the same way."

Is it coincidentally linting the same way, or is it actually using my .eslintrc.json? Hm, the latter. Well that rules out the ESLint extension as the most likely cause...
Is the prettier extension conflicting with the ESLint extension?
Are vs code settings conflicting with it?
Is vs code using my prettier configuration file when it shouldn't?
...

This would be abated if eslint.format.enable defaulted to true. Just because it's enabled doesn't mean you have to use it. What would be the downsides?

VS Code supports formatting pipelines. If we turn this on by default the eslint formatter will always run even if the user prefers another formatter like TypeScript or prettier. This is why you have to opt into it.
Changing this now will be breaking for all users which keep eslint.format disabled.

VS Code supports formatting pipelines.

I'm unfamiliar with this concept, and when I searched, none of the results seemed definitive. Does this relate to this other extension? If not, where can I learn more about this?


License + npm fields?

Hi,
Would it be possible to add a LICENSE-file to this package, as well as provide the license tag and links to this GitHub repo from package.json?
{
  // ...
  "license": "MIT",
  "repository": {
    "type": "git",
    "url"<EMAIL_ADDRESS>  },
  "homepage": "https://github.com/FrostDigital/mock-nats-client#readme"
}

Thanks!

@rexxars Done 👍

Thanks a bunch!


Improve error messages to include file name having ingestion issues

If a malformed CSV file gets added to a directory, it can fail data ingestion.
In such case the error currently doesn't include the exact file name causing issues.
Add the corrupt file name to the error returned.
Optionally also add the ability to skip corrupted files as well.

If this is caused by DuckDB not showing the file name, we should consider just raising the issue in their issue tracker instead.

Nothing to be done on this from our side. This will already be part of error messages. Sample below :
However the file name is trimmed.

The file name being trimmed will be handled in a separate issue in https://github.com/rilldata/rill/issues/5604


post install failing with typemoq

><EMAIL_ADDRESS>postinstall node_modules/typemoq
> postinstall-build dist

sh: 1: postinstall-build: not found
npm WARN optional SKIPPING OPTIONAL DEPENDENCY<EMAIL_ADDRESS>(node_modules/fsevents):
npm WARN notsup SKIPPING OPTIONAL DEPENDENCY: Unsupported platform for<EMAIL_ADDRESS>wanted {"os":"darwin","arch":"any"} (current: {"os":"linux","arch":"x64"})

npm ERR! file sh
npm ERR! code ELIFECYCLE
npm ERR! errno ENOENT
npm ERR! syscall spawn
npm ERR<EMAIL_ADDRESS>postinstall: `postinstall-build dist`
npm ERR! spawn ENOENT
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>postinstall script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

The above issue is occurring in our Jenkins build when doing npm install, does anyone know why this would be occurring?

any update on this issue?

Same problem here, any updates on fixes?

Might be related to postinstall-build and an incompatible version of npm.
What is your npm/nodejs/os ?

@florinn: @climboid and I are using nodejs 8.9.4 on an AWS CodeBuild Docker container right now to get this error.

I've removed the dependency on postinstall-build.
Please run 'npm install https://github.com/florinn/typemoq' and report back.

Did this ever get push to NPM?

@florinn wrote on Apr 13, 2018:

I've removed the dependency on postinstall-build.
Please run 'npm install https://github.com/florinn/typemoq' and report back.

Tried this but now running into the next issue: "Error: Cannot find module './node_modules/typemoq/build/postinstall.js'
NPM version is 6.4.1. Nodejs version is 11.1.0. OS is Ubuntu 18.04.

Same problem here. Would appreciate a new NPM package release. @florinn

@florinn This is not working for me either. Also running on AWS. I'm seeing the same error that @ManfredLange is when I try installing directly from GitHub like you recommended.


chore(package.json): update eslint version to match airbnb peer dependency

Tiny fix to remove the following warning:
npm WARN<EMAIL_ADDRESS>requires a peer of<EMAIL_ADDRESS>but none was installed.
npm WARN<EMAIL_ADDRESS>requires a peer of<EMAIL_ADDRESS>but none was installed.

Coverage remained the same at 100.0% when pulling aa17451e86a50aa99acb3d0f0cf282786f8d4a41 on mking-clari:eslint into 45b285b5e00b72dc8eda1e3fcf7bbb5f8f057ef3 on reactstrap:master.

Coverage remained the same at 100.0% when pulling eeefb487eb2de827e8ade8d99001045c32d8cb8e on mking-clari:eslint into 2252f6f149d0b8d28561053608cc07a3e5ab10d4 on reactstrap:master.

Sorry for the lack of communication. I held off on this pr because I'd like to take care of this problem by updating the related eslint deps and actually enforcing eslint in the test.

closed via #89


TypeError parsing GML (target.addEventListener is not a function)

In the Method GMLBase.readFeatureElementInternal the nodevalue is put in a wrapper-object, when the node has attributes.
The actual nodevalue has the key "_content_" in the wrapper-object, the attributes are pushed as key-value-pairs.
The "getGeometry"-Method of the Feature doesn't take care about that, it gives back the wrapper instead of the geometry.
This results in a TypeError ("target.addEventListener is not a function") in Feature.handleGeometryChanged_, because the
first argument given to the listen-method is not a geometry.

Can you create a test case that shows the problem?

Thanks, I see. Do you think you'd be able to create a pull request with a fix?

I solved the problem for me by modifying Feature.getGeometry, so that it returns the geometry instead of the wrapper. IMO that would be the best solution.

Do you think you'd be able to create a pull request with a fix?

I didn't do that before. How do I create a pull request?

This should be fixed in the format, not in ol/Feature. See https://github.com/openlayers/openlayers/blob/main/CONTRIBUTING.md#contributing-code for instructions. Thanks in advance.


Change to use Java's default FilePath.

Change to use Java's default FilePath.
The changed file is being kept open and in memory.
These changes correct this type of problem.

Thanks


Plugin relies on database connection when running theme:compile

PHP Version
8
Shopware Version
<IP_ADDRESS>
Actual behaviour
When running ./bin/ci theme:compile --keep-assets -vvv in CI (so when there is no database present), the compiling breaks because of this plugin;
In AbstractMySQLDriver.php line 112:

  [Doctrine\DBAL\Exception\ConnectionException]
  An exception occurred in driver: SQLSTATE[HY000] [2002] php_network_getaddresses: getaddrinfo failed: Name or service not known

Exception trace:
  at /data/client/shopware/vendor/doctrine/dbal/lib/Doctrine/DBAL/Driver/AbstractMySQLDriver.php:112
 Doctrine\DBAL\Driver\AbstractMySQLDriver->convertException() at /data/client/shopware/vendor/doctrine/dbal/lib/Doctrine/DBAL/DBALException.php:182
 Doctrine\DBAL\DBALException::wrapException() at /data/client/shopware/vendor/doctrine/dbal/lib/Doctrine/DBAL/DBALException.php:169
 Doctrine\DBAL\DBALException::driverException() at /data/client/shopware/vendor/doctrine/dbal/lib/Doctrine/DBAL/Driver/PDOMySql/Driver.php:31
 Doctrine\DBAL\Driver\PDOMySql\Driver->connect() at /data/client/shopware/vendor/doctrine/dbal/lib/Doctrine/DBAL/Connection.php:411
 Doctrine\DBAL\Connection->connect() at /data/client/shopware/vendor/doctrine/dbal/lib/Doctrine/DBAL/Connection.php:474
 Doctrine\DBAL\Connection->getDatabasePlatformVersion() at /data/client/shopware/vendor/doctrine/dbal/lib/Doctrine/DBAL/Connection.php:436
 Doctrine\DBAL\Connection->detectDatabasePlatform() at /data/client/shopware/vendor/doctrine/dbal/lib/Doctrine/DBAL/Connection.php:378
 Doctrine\DBAL\Connection->getDatabasePlatform() at /data/client/shopware/vendor/doctrine/dbal/lib/Doctrine/DBAL/Query/QueryBuilder.php:1204
 Doctrine\DBAL\Query\QueryBuilder->getSQLForSelect() at /data/client/shopware/vendor/doctrine/dbal/lib/Doctrine/DBAL/Query/QueryBuilder.php:252
 Doctrine\DBAL\Query\QueryBuilder->getSQL() at /data/client/shopware/vendor/shopware/core/Framework/DataAbstractionLayer/Dbal/QueryBuilder.php:51
 Shopware\Core\Framework\DataAbstractionLayer\Dbal\QueryBuilder->getSQL() at /data/client/shopware/vendor/doctrine/dbal/lib/Doctrine/DBAL/Query/QueryBuilder.php:212
 Doctrine\DBAL\Query\QueryBuilder->execute() at /data/client/shopware/vendor/shopware/core/Framework/DataAbstractionLayer/Dbal/EntitySearcher.php:91
 Shopware\Core\Framework\DataAbstractionLayer\Dbal\EntitySearcher->search() at /data/client/shopware/vendor/shopware/elasticsearch/Framework/DataAbstractionLayer/ElasticsearchEntitySearcher.php:57
 Shopware\Elasticsearch\Framework\DataAbstractionLayer\ElasticsearchEntitySearcher->search() at /data/client/shopware/vendor/shopware/core/Profiling/Entity/EntitySearcherProfiler.php:36
 Shopware\Core\Profiling\Entity\EntitySearcherProfiler->search() at /data/client/shopware/vendor/shopware/core/Framework/DataAbstractionLayer/EntityRepository.php:179
 Shopware\Core\Framework\DataAbstractionLayer\EntityRepository->searchIds() at /data/client/shopware/vendor/shopware/core/Framework/DataAbstractionLayer/EntityRepository.php:120
 Shopware\Core\Framework\DataAbstractionLayer\EntityRepository->search() at /data/client/shopware/vendor/shopware/core/Framework/DataAbstractionLayer/Dbal/Common/RepositoryIterator.php:72
 Shopware\Core\Framework\DataAbstractionLayer\Dbal\Common\RepositoryIterator->fetch() at /data/client/shopware/vendor/shopware/core/System/SystemConfig/SystemConfigLoader.php:67
 Shopware\Core\System\SystemConfig\SystemConfigLoader->load() at /data/client/shopware/vendor/shopware/core/System/SystemConfig/CachedSystemConfigLoader.php:49
 Shopware\Core\System\SystemConfig\CachedSystemConfigLoader->load() at /data/client/shopware/vendor/shopware/core/System/SystemConfig/SystemConfigService.php:372
 Shopware\Core\System\SystemConfig\SystemConfigService->load() at /data/client/shopware/vendor/shopware/core/System/SystemConfig/SystemConfigService.php:95
 Shopware\Core\System\SystemConfig\SystemConfigService->get() at /data/client/shopware/vendor/store.shopware.com/froshplatformthumbnailprocessor/src/Service/ThumbnailUrlTemplate.php:14
 Frosh\ThumbnailProcessor\Service\ThumbnailUrlTemplate->__construct() at /data/client/shopware/var/cache/dev_h3bb1806f88c6b26fd718ee7610b1a192/Container2k1Oi8x/Shopware_Production_KernelDevDebugContainer.php:21678
 Container2k1Oi8x\Shopware_Production_KernelDevDebugContainer->getUrlGeneratorDecoratorService() at /data/client/shopware/var/cache/dev_h3bb1806f88c6b26fd718ee7610b1a192/Container2k1Oi8x/Shopware_Production_KernelDevDebugContainer.php:14260
 Container2k1Oi8x\Shopware_Production_KernelDevDebugContainer->getMedia_RepositoryService() at /data/client/shopware/var/cache/dev_h3bb1806f88c6b26fd718ee7610b1a192/Container2k1Oi8x/Shopware_Production_KernelDevDebugContainer.php:28013
 Container2k1Oi8x\Shopware_Production_KernelDevDebugContainer->getDatabaseConfigLoaderService() at /data/client/shopware/var/cache/dev_h3bb1806f88c6b26fd718ee7610b1a192/Container2k1Oi8x/Shopware_Production_KernelDevDebugContainer.php:28141
 Container2k1Oi8x\Shopware_Production_KernelDevDebugContainer->getThemeServiceService() at /data/client/shopware/var/cache/dev_h3bb1806f88c6b26fd718ee7610b1a192/Container2k1Oi8x/Shopware_Production_KernelDevDebugContainer.php:27935
 Container2k1Oi8x\Shopware_Production_KernelDevDebugContainer->getThemeCompileCommandService() at /data/client/shopware/vendor/symfony/dependency-injection/Container.php:422
 Symfony\Component\DependencyInjection\Container->getService() at /data/client/shopware/vendor/symfony/dependency-injection/Argument/ServiceLocator.php:42
 Symfony\Component\DependencyInjection\Argument\ServiceLocator->get() at /data/client/shopware/vendor/symfony/console/CommandLoader/ContainerCommandLoader.php:45
 Symfony\Component\Console\CommandLoader\ContainerCommandLoader->get() at /data/client/shopware/vendor/symfony/console/Application.php:558
 Symfony\Component\Console\Application->has() at /data/client/shopware/vendor/symfony/console/Application.php:647
 Symfony\Component\Console\Application->find() at /data/client/shopware/vendor/symfony/framework-bundle/Console/Application.php:116
 Symfony\Bundle\FrameworkBundle\Console\Application->find() at /data/client/shopware/vendor/symfony/console/Application.php:255
 Symfony\Component\Console\Application->doRun() at /data/client/shopware/vendor/symfony/framework-bundle/Console/Application.php:82
 Symfony\Bundle\FrameworkBundle\Console\Application->doRun() at /data/client/shopware/vendor/symfony/console/Application.php:167
 Symfony\Component\Console\Application->run() at /data/client/shopware/bin/ci:57

Expected behaviour
This is what happens when this plugin is deactivated (bin/console plugin:deactivate FroshPlatformThumbnailProcessor);
$ ./bin/ci theme:compile --keep-assets -vvv
Start theme compilation

 Compiling theme for sales channel for : 70a4c67afe374daea41a9ad35144c4d8

 ! [NOTE] Took 20.809277 seconds

 Compiling theme for sales channel for : ffaaaacac4e44b2caa5c1cc57e355288

 ! [NOTE] Took 25.155885 seconds

Steps to Reproduce?

Install FroshPlatformThumbnailProcessor
Run CI=1 ./bin/ci theme:compile --keep-assets -vvv without a database (for local testing, comment the DATABASE_URL var in .env out)

Suggested fix
Lazy loading the service that is responsible for instantiating the class that requires a database connection, see #32

I understand the problem regarding the message, but I can't reproduce this on the mentioned way.
Without any DATABASE_URL and plugins I'm getting:
dev@ebb81d810016 /var/www/html/sw6 $ CI=1 ./bin/ci theme:compile --keep-assets -vvv
Start theme compilation

In AbstractMySQLDriver.php line 112:

  [Doctrine\DBAL\Exception\ConnectionException]
  An exception occurred in driver: SQLSTATE[HY000] [2002] php_network_getaddresses: getaddrinfo failed: Name does not resolve

Exception trace:
  at /var/www/html/sw6/vendor/doctrine/dbal/lib/Doctrine/DBAL/Driver/AbstractMySQLDriver.php:112
 Doctrine\DBAL\Driver\AbstractMySQLDriver->convertException() at /var/www/html/sw6/vendor/doctrine/dbal/lib/Doctrine/DBAL/DBALException.php:182
 Doctrine\DBAL\DBALException::wrapException() at /var/www/html/sw6/vendor/doctrine/dbal/lib/Doctrine/DBAL/DBALException.php:169
 Doctrine\DBAL\DBALException::driverException() at /var/www/html/sw6/vendor/doctrine/dbal/lib/Doctrine/DBAL/Driver/PDOMySql/Driver.php:31
 Doctrine\DBAL\Driver\PDOMySql\Driver->connect() at /var/www/html/sw6/vendor/doctrine/dbal/lib/Doctrine/DBAL/Connection.php:411
 Doctrine\DBAL\Connection->connect() at /var/www/html/sw6/vendor/doctrine/dbal/lib/Doctrine/DBAL/Connection.php:1951
 Doctrine\DBAL\Connection->getWrappedConnection() at /var/www/html/sw6/vendor/doctrine/dbal/lib/Doctrine/DBAL/Connection.php:1289
 Doctrine\DBAL\Connection->executeQuery() at /var/www/html/sw6/vendor/doctrine/dbal/lib/Doctrine/DBAL/Query/QueryBuilder.php:212
 Doctrine\DBAL\Query\QueryBuilder->execute() at /var/www/html/sw6/vendor/shopware/core/Framework/DataAbstractionLayer/Dbal/EntityReader.php:262
 Shopware\Core\Framework\DataAbstractionLayer\Dbal\EntityReader->fetch() at /var/www/html/sw6/vendor/shopware/core/Framework/DataAbstractionLayer/Dbal/EntityReader.php:109
 Shopware\Core\Framework\DataAbstractionLayer\Dbal\EntityReader->_read() at /var/www/html/sw6/vendor/shopware/core/Framework/DataAbstractionLayer/Dbal/EntityReader.php:79
 Shopware\Core\Framework\DataAbstractionLayer\Dbal\EntityReader->read() at /var/www/html/sw6/vendor/shopware/core/Profiling/Entity/EntityReaderProfiler.php:36
 Shopware\Core\Profiling\Entity\EntityReaderProfiler->read() at /var/www/html/sw6/vendor/shopware/core/Framework/DataAbstractionLayer/EntityRepository.php:270
 Shopware\Core\Framework\DataAbstractionLayer\EntityRepository->read() at /var/www/html/sw6/vendor/shopware/core/Framework/DataAbstractionLayer/EntityRepository.php:115
 Shopware\Core\Framework\DataAbstractionLayer\EntityRepository->search() at /var/www/html/sw6/vendor/shopware/storefront/Theme/ConfigLoader/DatabaseAvailableThemeProvider.php:36
 Shopware\Storefront\Theme\ConfigLoader\DatabaseAvailableThemeProvider->load() at /var/www/html/sw6/vendor/shopware/storefront/Theme/Command/ThemeCompileCommand.php:43
 Shopware\Storefront\Theme\Command\ThemeCompileCommand->execute() at /var/www/html/sw6/vendor/symfony/console/Command/Command.php:299
 Symfony\Component\Console\Command\Command->run() at /var/www/html/sw6/vendor/symfony/console/Application.php:996
 Symfony\Component\Console\Application->doRunCommand() at /var/www/html/sw6/vendor/symfony/framework-bundle/Console/Application.php:96
 Symfony\Bundle\FrameworkBundle\Console\Application->doRunCommand() at /var/www/html/sw6/vendor/symfony/console/Application.php:295
 Symfony\Component\Console\Application->doRun() at /var/www/html/sw6/vendor/symfony/framework-bundle/Console/Application.php:82
 Symfony\Bundle\FrameworkBundle\Console\Application->doRun() at /var/www/html/sw6/vendor/symfony/console/Application.php:167
 Symfony\Component\Console\Application->run() at /var/www/html/sw6/bin/ci:57

Any idea?
Could you please try this: https://github.com/FriendsOfShopware/FroshPlatformThumbnailProcessor/commit/076ac220bbbf4f504854ffd6cb93503bc6f2883c

@tinect huh weird. That is indeed the error that you should be getting (because you don't have https://developer.shopware.com/docs/guides/hosting/installation-updates/deployments/build-w-o-db#compiling-the-storefront-without-database configured).

@tinect that commit works as a charm! :)

I'm afraid I cannot reproduce the error :-(
But, good it works for you.


Cli: Operation signing + login and whoami

Context

Description

Manually testing the PR

@alanmarkoTrilitech please add context + description (useful for looking back on this PR)

Additionally requesting a review from @sam-finch-tezos


Adding Manual tests

Description
Adding a web page for testing the different library functions manually.

Please link the manual tests to this issue


absolute imports

Codecov Report

Merging #61 (c4beef2) into master (c373e6d) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master      #61      +/-   ##
==========================================
- Coverage   99.11%   99.11%   -0.01%
==========================================
  Files          30       30
  Lines         679      677       -2
==========================================
- Hits          673      671       -2
  Misses          6        6

Flag
Coverage Δ

unittests
99.11% <100.00%> (-0.01%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

stac_pydantic/links.py
100.00% <ø> (ø)

stac_pydantic/api/extensions/query.py
100.00% <100.00%> (ø)

stac_pydantic/api/extensions/sort.py
100.00% <100.00%> (ø)

stac_pydantic/api/landing.py
100.00% <100.00%> (ø)

stac_pydantic/api/search.py
100.00% <100.00%> (ø)

stac_pydantic/api/utils/link_factory.py
100.00% <100.00%> (ø)

stac_pydantic/catalog.py
100.00% <100.00%> (ø)

stac_pydantic/collection.py
100.00% <100.00%> (ø)

stac_pydantic/extensions/collection_assets.py
100.00% <100.00%> (ø)

stac_pydantic/extensions/datacube.py
100.00% <100.00%> (ø)

... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c373e6d...c4beef2. Read the comment docs.


Please add test data

I have seen few minites for Test data shown in State wise. Please add it again.

Done via #699


OKE service CIDR and Pod CIDR selection

Can we use same pods_cidr(<IP_ADDRESS>/16) and services_cidr(<IP_ADDRESS>/16) while creating OKE cluster for multiple environments keeping same VCN CIDR(<IP_ADDRESS>/16). Will their be any conflict in any of the services.

Yes you can. As long as 1) the pods_cidr and services_cidr do not overlap with the vcn_cidr block and worker+load balancer CIDR blocks respectively 2) you do not plan on connecting the multiple environment through peering

The cidr blocks requirements are outlined here: https://docs.cloud.oracle.com/iaas/Content/ContEng/Concepts/contengcidrblocks.htm


Warning duplicated ['image']

I have this warning:
[tiptap warn]: Duplicate extension names found: ['image']. This can lead to issues. ...

I guess it's because the UpdatedImage extended from the @tiptap/extension-image and both have
  name: 'image',

which causes the warning?

I see the same thing.

+1

+1

I am receiving this error


Standardization of Return Types in AIConfigRuntime Methods

Currently, various methods in AIConfigRuntime exhibit inconsistent return types. To enhance code uniformity and clarity, it is proposed to standardize all relevant methods to return a list of prompts (1Prompt[]1).

#343

Just FWIW, pyright is catching a lot of this kind of thing. One way we can proceed here is to fix one particular type of pyright error throughout the codebase, and call it a day. No new tests needed; static checking is the test.


Fix indentation

Set eslint indent to 2 + fix indentation (tabs to spaces)

#452 and this will probably cause conflicts once any of them is merged.


数据问题

请问有没有处理好的数据啊

I will update the repository's readme with more information covering what you asked for.


Please upgrade chrome store plugin

Version: 69.0.3497.81（Official Build） （64 bits）
When Installing this extension from chrome store, it doesn't works well, but installing from source code it works well. It seems store's extension is not latest version. please upgrade.

The same here, fails from Chrome Store, but from here work perfectly.

Which version of Chrome do you have?
It works great for me.

This version: 69.0.3497.100 (Build oficial) (64 bits)

Can you upgrade to Chrome 70?

I got version 70.0.3538.77 (official build) (64 bits), removed the installed extension from source, installed from chrome store and now it works 👍

Thanks!


Software architecture document

User story
As a developer you need to
Prepare a description of the planned software architecture; The document should include:

An overview diagram of runtime components (one page)
An overview diagram of code components (one page)
A summary of the underlying technology stack (one page)
A textual explanation of the diagrams and choices (one page)

Acceptance criteria
All diagrams are available and reviewed by all developers. Underlying technology stack is agreed upon between developers. All diagrams and technology stack are explained.
Definition of done (DoD)
The software architecture document is uploaded to sprint-02/software-architecture.pdf

@Sabo2k my suggestion is to use draw.io diagrams which can be checked in into the project and a markdown file (e.g. architecture.md with the description, which can then be converted to PDF or something similar if you guys need it as a deliverable for the university reviews.

Acceptance criteria All diagrams are available and reviewed by all developers. Underlying technology stack is agreed upon between developers. All diagrams and technology stack are explained.

The architecture was presented to the Industry Partner :)


⚠ Bofrost.be has degraded performance

In 49bd543, Bofrost.be (https://www.bofrost.be) experienced degraded performance:

HTTP code: 200
Response time: 1160 ms

Resolved: Bofrost.be performance has improved in 9722e0e after 10 minutes.


Add Multi-Binding Docs

This PR documents multi-binding, adding to bindable-object-extensions.md

@brminnick : Thanks for your contribution! The author(s) have been notified to review your proposed change.

Docs Build status updates of commit 2a049a6:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/maui/markup/extensions/bindable-object-extensions.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

@brminnick : Thanks for your contribution! The author(s) have been notified to review your proposed change.

Docs Build status updates of commit b9f635d:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/maui/markup/extensions/bindable-object-extensions.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel


Allow updating starter code after groups are created

I have one question for you @david-yz-liu:
I can't get this new starter code form to work with 'post' in react because of some authenticity token quirk (but 'get' just works with it instead), @mishaschwartz was looking at it too and didn't find anything obvious.
Should we extract everything that is not managing the files out of react?

@adisandro can you push your work with the the POST and I can take a look.

@david-yz-liu done (and the code will not work now)


[Bug] Can you please upgrade vaultwarden to the latest version?

Describe the bug
Bitwarden has change some stuff regarding the user connection. Vaultwarden has implemented these changes on version >= 1.27. Currently provided version is 1.24. Can you upgrade it please ?

can you check again?

I can also confirm 1.28.1 is showing for me as well

Closing since it's 1.28.1 now.
PR to bump to newer version is always welcomed.


fix simplified Chinese translations in legal.md

[x] Have you followed the contributing guidelines?
[x] Have you explained what your changes do, and why they add value to the Guides?

Please note: we will close your PR without comment if you do not check the boxes above and provide ALL requested information.

I read the translation of legal.md and found many missing or wrong translations, so I made this PR to fix them.

Seems reasonable based on spot checking with auto-translation only. cc previous contributors @lijiangsheng1 @WillemJiang in case you'd like to review. If not will merge in a few days.


Experiment cancel requested ?

Package Name: azure-ai-ml
Package Version: 1.5.0a20230215003
Operating System: Windows 11
Python Version: Python 3.10.9

Describe the bug
A pipeline I submitted earlier today no problems is now doing something weird when I resubmit it, it auto-cancels after about 1 second with no explanation.  I'm not cancelling it, so who is?  This pipeline is running on my own azure kubernetes cluster and that cluster is running and healthy.
To Reproduce
Steps to reproduce the behavior:

email me at microsoft and I will share the code.

Expected behavior
It should work properly or tell me exactly why it is being cancelled.  I can submit other jobs to the same aml workspace, so I know it's not a workspace issue.
Screenshots
[2023-03-01 01:31:12Z] Submitting 2 runs, first five are: 7e04e95b:1be95c4b-6c5b-4915-9806-d584bf0f76cc,ae8a964a:c3957cf8-fbe9-4abe-811a-cc339fa90f7b
[2023-03-01 01:31:13Z] Experiment cancel requested, checking remained jobs...
[2023-03-01 01:31:14Z] Experiment status is canceled, set experiment status as canceled and return.

Additional context
https://ml.azure.com/runs/affable_leg_339flwgz2t?wsid=/subscriptions/c8b7f913-60fb-4759-a310-fc5630e56f99/resourcegroups/snpe-aml-rg/workspaces/snpe-aml-workspace&tid=72f988bf-86f1-41af-91ab-2d7cd011db47#

Thank you for the feedback @lovettchris . We will investigate and get back to you.
cc @azureml-github

Hi @lovettchris , just sent you email to sync about the repro steps.


Unbinned radial plot added as well as document updates

I updated the radial profile plot to include both binned and unbinned plots of the points around the star. By default, the unbinned results will be plotted, the user can choose binned points by setting the new parameter pixels to False. I still need to add the model fit to the points.
In [8]: a.rimexam()
Out[8]:
{'background': [False, 'Subtract background? [bool]'],
 'center': [True, 'Solve for center using 2d Gaussian? [bool]'],
 'fitplot': [False, 'Overplot profile fit?'],
 'fittype': ['Gaussian2D', 'Profile type to fit (Gaussian2D)'],
 'function': ['radial_profile'],
 'getdata': [False, 'print the plotted data values'],
 'magzero': [25.0, 'magnitude zero point'],
 'marker': ['o', 'The marker character to use, matplotlib style'],
 'pixels': [True, 'Plot all pixels at each radius? (False bins the data)'],
 'pointmode': [True, 'plot points instead of lines? [bool]'],
 'rplot': [8.0, 'Plotting radius in pixels'],
 'skyrad': [10.0, 'Background inner radius in pixels, from center of object'],
 'title': [None, 'Title of the plot'],
 'width': [5.0, 'Background annulus width in pixels'],
 'xlabel': ['Radius', 'The string for the xaxis label'],
 'ylabel': ['Flux', 'The string for the yaxis label']}

I also added scipy.stats.describe to the statistical box function, which can be specified with "describe" and used in addition to the previous np.mean/median/min type single stats.
In [5]: a.mimexam()
Out[5]:
{'function': ['report_stat'],
 'region_size': [5, 'region size in pixels to use'],
 'stat': ['median', 'which numpy stat to return [median, min, max]']}

In [6]: a.set_plot_pars('m','stat','describe')
set report_stat_pars: stat to describe

In [7]: a.imexam()

Press 'q' to quit

2	Make the next plot in a new window
a	Aperture sum, with radius region_size
b	Return the 2D gauss fit center of the object
c	Return column plot
e	Return a contour plot in a region around the cursor
g	Return curve of growth plot
h	Return a histogram in the region around the cursor
j	1D [Gaussian1D default] line fit
k	1D [Gaussian1D default] column fit
l	Return line plot
m	Square region stats, in [region_size],default is median
r	Return the radial profile plot
s	Save current figure to disk as [plot_name]
t	Make a fits image cutout using pointer location
w	Display a surface plot around the cursor location
x	Return x,y,value of pixel
y	Return x,y,value of pixel

Current image /Users/sosey/test_images/iacs01t4q_flt.fits
pressed: m, report_stat
[428:433,476:481] describe:
nobs: 25
minamx: (0.51488268, 0.89496481)
mean 0.6963587403297424
variance: 0.009489892981946468
skew: 0.22983314096927643
kurtosis: -0.49982608081795465

Coverage increased (+0.4%) to 27.18% when pulling c403e0d821085a56d04bdab93347d015d8397a39 on sosey:radialpix into 00540fc9c41021e8da08c784aa0fc76ec924eb47 on spacetelescope:master.

Coverage increased (+0.4%) to 27.18% when pulling fac0298ccbffe152a58813bed46c0ad7549441af on sosey:radialpix into 00540fc9c41021e8da08c784aa0fc76ec924eb47 on spacetelescope:master.

Coverage increased (+0.4%) to 27.18% when pulling afcfcb56e4b18657cb857bee67ab55888165150d on sosey:radialpix into 00540fc9c41021e8da08c784aa0fc76ec924eb47 on spacetelescope:master.

Coverage increased (+0.4%) to 27.18% when pulling afcfcb56e4b18657cb857bee67ab55888165150d on sosey:radialpix into 00540fc9c41021e8da08c784aa0fc76ec924eb47 on spacetelescope:master.


Address execution hot spots

Copies while resizing on push_back() is degrading performance. Calling reserve() allows enough space in the array for the maximum number of items which may be inserted.

Ok, ignore this PR, got some noise in here somehow


_acl not being saved correctly

Issue Description
Create a user:
curl -X POST \
-H "X-Parse-Application-Id: appId" \
-H "X-Parse-REST-API-Key: restKey" \
-H "Content-Type: text/plain" \
-d '{"authData":{"anonymous":{"id":"a"}}}' \
http://myapp.herokuapp.com/parse/users

User is created with following data in db. Note the _rperm and _acl are public read
{
    "_id": "TYy7EUpRtP",
    "_rperm": [
        "*",
        "TYy7EUpRtP"
    ],
    "_auth_data_anonymous": {
        "id": "a"
    },
    "username": "MLKHFez8nvR4vylzb2LGHuo9d",
    "_wperm": [
        "TYy7EUpRtP"
    ],
    "_acl": {
        "TYy7EUpRtP": {
            "w": true,
            "r": true
        },
        "*": {
            "r": true
        }
    },
    "_created_at": {
        "$date": "2016-08-31T17:21:41.644Z"
    },
    "_updated_at": {
        "$date": "2016-08-31T17:21:41.644Z"
    }
}

Set the ACL to just the user, i.e. remove public read:
curl -X PUT \
-H "X-Parse-Application-Id: appId" \
-H "X-Parse-REST-API-Key: restKey" \
-H "X-Parse-Session-Token: r:sessionToken" \
-H "Content-Type: text/plain" \
-d '{"ACL":{"TYy7EUpRtP":{"read":true,"write":true}}}' \
http://myapp.herokuapp.com/parse/users/TYy7EUpRtP

User data now looks like the following.
Note that _rperm is correct and loses the * access, but _acl * still has r:true
{
    "_id": "TYy7EUpRtP",
    "_rperm": [
        "TYy7EUpRtP"
    ],
    "_auth_data_anonymous": {
        "id": "a"
    },
    "username": "MLKHFez8nvR4vylzb2LGHuo9d",
    "_wperm": [
        "TYy7EUpRtP"
    ],
    "_acl": {
        "TYy7EUpRtP": {
            "w": true,
            "r": true
        },
        "*": {
            "r": true
        }
    },
    "_created_at": {
        "$date": "2016-08-31T17:21:41.644Z"
    },
    "_updated_at": {
        "$date": "2016-08-31T17:25:50.179Z"
    }
}

Get the user again, parse-server thinks that the ACL has been changed:
{"objectId":"TYy7EUpRtP","authData":{"anonymous":{"id":"a"}},"username":"MLKHFez8nvR4vylzb2LGHuo9d","createdAt":"2016-08-31T17:21:41.644Z","updatedAt":"2016-08-31T17:25:50.179Z","ACL":{"TYy7EUpRtP":{"read":true,"write":true}}}

The ACL is actually set correctly as far as parse-server is concerned but not parse.com, e.g. viewing the data browser shows the user as Public Read, TYy7EUpRtP
Attempting to get the user with the user's own session token succeeds:
curl -X GET \
-H "X-Parse-Application-Id: appId" \
-H "X-Parse-REST-API-Key: restApiKey" \
-H "X-Parse-Session-Token: r:user-a-session_token" \
-H "Content-Type: text/plain" \
http://myapp.herokuapp.com/parse/users/TYy7EUpRtP

{"objectId":"TYy7EUpRtP","authData":{"anonymous":{"id":"a"}},"username":"MLKHFez8nvR4vylzb2LGHuo9d","createdAt":"2016-08-31T17:21:41.644Z","updatedAt":"2016-08-31T17:25:50.179Z","ACL":{"TYy7EUpRtP":{"read":true,"write":true}},"sessionToken":"r:fc778d100d805889e00ff42fdd51ec83"}

Using user b session token does not succeed as expected:
{"code":101,"error":"Object not found."}

Verbose log of the PUT ACL
verbose: REQUEST for [PUT] /parse/users/TYy7EUpRtP: {
Aug 31 18:42:16 myapp app/web.1:    "ACL": {
Aug 31 18:42:16 myapp app/web.1:      "TYy7EUpRtP": {
Aug 31 18:42:16 myapp app/web.1:        "read": true,
Aug 31 18:42:16 myapp app/web.1:        "write": true
Aug 31 18:42:16 myapp app/web.1:      }
Aug 31 18:42:16 myapp app/web.1:    }
Aug 31 18:42:16 myapp app/web.1:  } method=PUT, url=/parse/users/TYy7EUpRtP, host=myapp.herokuapp.com, connection=close, user-agent=curl/7.35.0, accept=*/*, x-parse-application-id=appId, x-parse-rest-api-key=restKey, x-parse-session-token=r:sessionToken, content-type=text/plain, x-request-id=cd7554fd-b39c-41b8-9fbe-3d21eb6c797b, x-forwarded-for=<IP_ADDRESS>, x-forwarded-proto=http, x-forwarded-port=80, via=1.1 vegur, connect-time=0, x-request-start=1472665335896, total-route-time=0, content-length=49, read=true, write=true
Aug 31 18:42:16 myapp app/web.1:  verbose: RESPONSE from [PUT] /parse/users/TYy7EUpRtP: {
Aug 31 18:42:16 myapp app/web.1:    "response": {
Aug 31 18:42:16 myapp app/web.1:      "updatedAt": "2016-08-31T17:42:15.945Z"
Aug 31 18:42:16 myapp app/web.1:    }
Aug 31 18:42:16 myapp app/web.1:  } updatedAt=2016-08-31T17:42:15.945Z

Environment Setup

Server

parse-server version: 2.2.18
Localhost or remote server? (AWS, Heroku, Azure, Digital Ocean, etc): Heroku

Database

MongoDB version: 3.2.6
Storage engine:  WT
Localhost or remote server? (AWS, mLab, ObjectRocket, Digital Ocean, etc): mLab

We also experienced this issue. Not really sure if the "_acl" property in db is deprecated or something. When viewing the ACLs in the open-source-dashboard it displays them correctly (meaning that parse-server must calculate them from "_wperm" and "_rperm"), but for the hosted dashboard (https://dashboard.parse.com), the ACLs are wrong (meaning that they must read the "_acl" property).

I've tracked the issue down and it was introduced in 2.2.14 via #2021
Will see if I can add a test and fix

Will be released with 2.2.20! Thanks for the PR!


How to use?

How exactly do I use this mod? I'm not exactly knowledgeable when it comes to changing config files and really anything more complicated then just drag and dropping mods. I just need to know exactly where to start and plug in the commands I've seen. I know how the mod works but not how to set it up.

I recommend you use the mod "Configured" by MrCrayfish, it's a very useful tool for this particular config file. You need to open the mod configuration with this mod installed and use the "Edit" button on the "Skill Locks" section, then you need to add the item you want to lock. For example, my mod has X block and i want to set building:6 as requirement. You need to input there "modid:blockid building:6" and click add. You can do this with pretty much anything that has a right-click functionallity. Hope it helps


Many comics deleted from http://thegentlemansarmchair.com/

It leads the script to crash with 404 error.
I'll try to contact the author asap.

For some reason, http://thegentlemansarmchair.com/comic/life-before-facebook/ is the last on the website but on the RSS feed, we can see there there used to be more http://feeds.feedburner.com/TheGentlemansArmchair .
Also, these (and more) can be found on Webtoon: http://www.webtoons.com/en/comedy/the-gentlemans-armchair/list?title_no=469 . Maybe there is an exclusivity deal with webtoon...
Anyway, I've contacted the author and in the meantime, I'll flag local comics as deleted to ensure the retriever doesn't crash on 404 error.

It seems like the website does not exist anymore.

A corresponding tumblr is online though: https://thegentlemansarmchair.tumblr.com

It seems like the original issue does not affect the tumblr.
Let's close this for the time being.


Windows11: OpenOCD from MSDK cannot initialize the MAX32625PICO CMSIS-DAP

On my corporate managed Windows11 laptop, the OpenOCD from the MSDK installer will not open the MAX32625PICO CMSIS-DAP device.
On the same laptop, a VirtualBox VM that we attach the same PICO to as a USB device will work under OpenOCD and PyOCD
At this point I'm not sure if it's a general Windows 11 issue, or if it has to do with the corporate management of USB devices - long story short is I can't do any work with the MAX32690FTHR board until this is working.
I can work around it using a Linux laptop but ideally I would like to use a standard (if somewhat locked down) Windows11 device.
Debug: 87 298 semihosting_common.c:109 semihosting_common_init(): Debug: 88 345 cmsis_dap_usb_bulk.c:105 cmsis_dap_usb_open(): could not open device 0x2109:0x0813: Operation not supported or unimplemented on this platform Debug: 89 345 cmsis_dap_usb_bulk.c:105 cmsis_dap_usb_open(): could not open device 0x27c6:0x63ac: Access denied (insufficient permissions) Debug: 90 345 cmsis_dap_usb_bulk.c:105 cmsis_dap_usb_open(): could not open device 0x8087:0x0033: Operation not supported or unimplemented on this platform Debug: 91 361 cmsis_dap_usb_bulk.c:105 cmsis_dap_usb_open(): could not open device 0x8086:0x51ed: Operation not supported or unimplemented on this platform Debug: 92 361 cmsis_dap_usb_bulk.c:150 cmsis_dap_usb_open(): found product string of 0x0d28:0x0204 'DAPLink CMSIS-DAP' Debug: 93 371 cmsis_dap_usb_bulk.c:170 cmsis_dap_usb_open(): enumerating interfaces of 0x0d28:0x0204 Debug: 94 377 cmsis_dap_usb_bulk.c:237 cmsis_dap_usb_open(): skipping interface 0, endpoint[0] is not bulk out Debug: 95 377 cmsis_dap_usb_bulk.c:230 cmsis_dap_usb_open(): skipping interface 1, has only 1 endpoints Debug: 96 377 cmsis_dap_usb_bulk.c:276 cmsis_dap_usb_open(): skipping interface 2, class 10 subclass 0 protocol 0 Debug: 97 377 cmsis_dap_usb_bulk.c:217 cmsis_dap_usb_open(): found interface 3 string 'CMSIS-DAP v1' Debug: 98 393 cmsis_dap_usb_bulk.c:237 cmsis_dap_usb_open(): skipping interface 3, endpoint[0] is not bulk out Debug: 99 393 cmsis_dap_usb_bulk.c:217 cmsis_dap_usb_open(): found interface 4 string 'WebUSB: CMSIS-DAP' Debug: 100 393 cmsis_dap_usb_bulk.c:230 cmsis_dap_usb_open(): skipping interface 4, has only 0 endpoints Debug: 101 393 cmsis_dap_usb_bulk.c:105 cmsis_dap_usb_open(): could not open device 0x0c45:0x6d1f: Entity not found Debug: 102 408 cmsis_dap_usb_bulk.c:105 cmsis_dap_usb_open(): could not open device 0x8086:0x461e: Operation not supported or unimplemented on this platform Debug: 103 408 cmsis_dap_usb_bulk.c:105 cmsis_dap_usb_open(): could not open device 0x2109:0x2813: Operation not supported or unimplemented on this platform Debug: 104 408 cmsis_dap_usb_bulk.c:105 cmsis_dap_usb_open(): could not open device 0x0b95:0x1790: Operation not supported or unimplemented on this platform Error: 105 424 cmsis_dap.c:293 cmsis_dap_open(): unable to find a matching CMSIS-DAP device Debug: 106 424 command.c:544 run_command(): Command 'init' failed with error code -4

@rhempel I can confirm that our toolchain should work on Windows 11.  I have been using on my home machine successfully.
The error log seems like permission issues on the USB port.  You will need USB read/write access on the machine to connect to the PICO.  I suspect IT has locked this on your managed machine.  If you can write a file to a USB drive you should have equivalent permissions to connect to the PICO.
The "could not open device" messages are standard as OpenOCD iterates across all the USB devices it can find.  The device ID for the PICO is 0x0d28:0x0204, which it is finding successfully during the scan.  I've attached a log from my W11 machine for reference.
win11_connect_log.zip
They key errors in your log are

could not open device 0x27c6:0x63ac: Access denied (insufficient permissions) - indicating permission issues on a different USB device
Error: 105 424 cmsis_dap.c:293 cmsis_dap_open(): unable to find a matching CMSIS-DAP device - indicating OpenOCD failed to open the device.  This is the same message thrown if there's no PICO connected to your machine either.  Since the scan chain is at least iterating across the end-points I think this further confirms a USB permissions issue.

Thanks for the reply @Jake-Carter - I believe it does have something to do with permissions, but it's not read/write permissions on the USB drive. I have an IT-exception for this on my machine, and I can confirm that I am able to create, read, and modify files on the exposed USB drive for both the DAPLINK and MAINTENANCE modes of the PICO.
I understand how the enumeration scan works for OpenOCD and have looked at the AD fork of the source.
Is there a possibility of adding some additional diagnostic output for the -v option when OpenOCD tries an operation on the  0x0d28:0x0204 device? The enumeration works so there is some other operation failing when it tries to add it to the list of valid CMSIS-DAP devices.
By the way, the command line I am using to open the device is:
C:\MaximSDK\Tools\OpenOCD\openocd.exe   -f interface\cmsis-dap.cfg -f target\max32690.cfg -d

Hmm, generally if you can write to a USB drive you shouldn't have any issue with the PICO.
Here are my driver details (Device Manager -> View -> Devices by container -> DAPLink CMSIS-DSP)
Key drivers to check are DAPLINK and WebUSB: CMSIS-DAP.  Do these match?

The main difference is that I am missing:

HID compliant vendor-defined device
USB Input Device

The WebUSB driver I have is slightly different:

The Details.txt contents on my PICO are:
# DAPLink Firmware - see https://daplink.io
Build ID: v0257-51-gdb95667d (armcc)
Unique ID: 04161701d5b7c84700000000000000000000000097969906
HIC ID: 97969906
Auto Reset: 1
Automation allowed: 1
Overflow detection: 1
Incompatible image detection: 0
Page erasing: 1
Daplink Mode: Interface
Interface Version: 0259
Git SHA: db95667ddf740f77536239782e7b4273c90878cf
Local Mods: 0
USB Interfaces: MSD, CDC, HID, WebUSB
Interface CRC: 0x8ecdbe53
Remount count: 0
URL: http://www.analog.com/max32625pico

I have opened a ticket with our IT provider - there are some posts on the web that indicate CrowdStrike may be interfering with some USB endpoint devices. This kind of makes sense, so I'll follow up on this when I hear back ...

Still no update from out IT staff ...

@Jake-Carter UPDATE:
I have looked more closely at the startup logs and there IS one difference - your product string does not match the one I am getting from my PICO.
Here is what I get:
`Debug: 30 139 cmsis_dap_usb_bulk.c:150 cmsis_dap_usb_open(): found product string of 0x0d28:0x0204 'DAPLink CMSIS-DAP'
and you have this in your log
Debug: 96 145 cmsis_dap_usb_bulk.c:150 cmsis_dap_usb_open(): found product string of 0x0d28:0x0204 '**CMSIS-DAP v1**'
Two things - the line numbers don't match up, so maybe you have a different openocd.exe than what is in the MSDK download currently available
Second, the product string does not match, which means my MAX32625PICO probably has different firmware than yours.
Would you be able to point me to a link for the firmware in your PICO and possibly to a link to your openocd.exe (if different from the MSDK build)?

@Jake-Carter - just a follow up, would you be able to point me to a link for the firmware in your PICO?
None of the images PICO firmware repository give the USB Product string in the logs you have shared :-)

@Jake-Carter Here is a little more information from the USB Device Tree Viewer V4.4.3 running on my  Crowdstrike Falcon protected laptop. It looks like the HID descriptor is failing the read operation, which kind of explains why the PICO is not staying on the list of devices that can be opened by OpenOCD
`
---------------- Interface Descriptor -----------------
bLength                  : 0x09 (9 bytes)
bDescriptorType          : 0x04 (Interface Descriptor)
bInterfaceNumber         : 0x03 (Interface 3)
bAlternateSetting        : 0x00
bNumEndpoints            : 0x02 (2 Endpoints)
bInterfaceClass          : 0x03 (HID - Human Interface Device)
bInterfaceSubClass       : 0x00 (None)
bInterfaceProtocol       : 0x00 (None)
iInterface               : 0x06 (String Descriptor 6)
Language 0x0409         : "CMSIS-DAP"
Data (HexDump)           : 09 04 03 00 02 03 00 00 06                        .........
    ------------------- HID Descriptor --------------------

bLength                  : 0x09 (9 bytes)
bDescriptorType          : 0x21 (HID Descriptor)
bcdHID                   : 0x0100 (HID Version 1.00)
bCountryCode             : 0x00 (00 = not localized)
bNumDescriptors          : 0x01
Data (HexDump)           : 09 21 00 01 00 01 22 21 00                        .!...."!.
Descriptor 1:
bDescriptorType          : 0x22 (Class=Report)
wDescriptorLength        : 0x0021 (33 bytes)
Error reading descriptor : ERROR_GEN_FAILURE (due to a obscure limitation of the Win32 USB API, see F1 Help)
    ----------------- Endpoint Descriptor -----------------

bLength                  : 0x07 (7 bytes)
bDescriptorType          : 0x05 (Endpoint Descriptor)
bEndpointAddress         : 0x81 (Direction=IN EndpointID=1)
bmAttributes             : 0x03 (TransferType=Interrupt)
wMaxPacketSize           : 0x0040 (64 bytes)
bInterval                : 0x01 (1 ms)
Data (HexDump)           : 07 05 81 03 40 00 01<EMAIL_ADDRESS>    ----------------- Endpoint Descriptor -----------------

bLength                  : 0x07 (7 bytes)
bDescriptorType          : 0x05 (Endpoint Descriptor)
bEndpointAddress         : 0x02 (Direction=OUT EndpointID=2)
bmAttributes             : 0x03 (TransferType=Interrupt)
wMaxPacketSize           : 0x0040 (64 bytes)
bInterval                : 0x01 (1 ms)
Data (HexDump)           : 07 05 02 03 40 00 01<EMAIL_ADDRESS>`
The F1 Help offers this:

About HID descriptors
HID descriptors usually cannot be read. This is because they must be requested from the interface rather than the device but the IOCTL_USB_GET_DESCRIPTOR_FROM_NODE_CONNECTION call doesn't offer the choice.
The parameters are ignored and filled by the USB stack:
MSDN says: "the USB stack ignores the value of bmRequest and inserts a value of 0x80 which indicates standard USB device request".
https://learn.microsoft.com/en-us/windows-hardware/drivers/ddi/usbioctl/ns-usbioctl-_usb_descriptor_request
For most devices the result is an ERROR_GEN_FAILURE or ERROR_INVALID_PARAMETER.
But some devices return the HID descriptor anyway.

SOLVED! This turned out to be a lot of digging around and finally stumbling on the solution ...
As an embedded developer I have to support devices from multiple vendors - and that sometimes means installing vendor specific tools and drivers. In this case, I had an old vendor specific CMSIS-DAP v1 driver on my laptop, and this was causing the AD/MAX PICO to pick up the wrong driver.
The fix is relatively simple. Go into Device Manager on your Windows machine and choose "View By Driver". The look for ANY and ALL drivers with CMSIS or DAP in the name, right click, and then choose "Remove Driver"
When you have deleted all of them (and you may have dozens if not hundreds of .inf files) then plug in your MAX32625 PICO and you will be able to use OpenOCD to detect and use the device.
Sometimes you have to keep chewing on the bone ...


[Bug][github] Incremental PR Collector fail in plugin github.

Search before asking

[X] I had searched in the issues and found no similar issues.

What happened

Incremental PR Collector fail in plugin github.
What do you expect to happen
collect success
How to reproduce
I guess it's caused by incremental collectors. So:

create a new pr in repo
collect prs by github (not github graphql)
delete this pr
recollect

Anything else
No response
Version
main
Are you willing to submit PR?

[X] Yes I am willing to submit a PR!

Code of Conduct

[X] I agree to follow this project's Code of Conduct

This row in _tool_github_pull_requests:
32,1248460646,384111310,4474,MERGED,fix(config-ui): adjust the plugin config for tapd,2023-02-21 10:00:55,2023-02-21 12:40:53,2023-02-21 12:13:05,0,0,0,0,0,0,2023-02-21 12:13:05,"""### Summary\r\nAdjust the plugin config for tapd.\r\n\r\n### Does this close any open issues?\r\nCloses #4473\r\n\r\n### Screenshots\r\n![screenshot-20230221-175651](https://user-images.githubusercontent.com/37237996/220312569-cca1388c-176c-433a-a9ef-d31f6145fefb.png)\r\n\r\n""","","",86db4ca22593b4117cddce57ff44e67b451213db,fix-4473,main,4f426a960489c5b1e8ef8ab2ecc9ed6fed819aac,2925285a58d4ff0d110d57b19ebdcc9d0e796d41,https://github.com/apache/incubator-devlake/pull/4474,mintsweet,37237996,2023-03-09 09:29:51.877,2023-03-09 09:29:51.877,"{""ConnectionId"":32,""Name"":""apache/incubator-devlake""}",_raw_github_api_pull_requests,124,"",532710813

It should be https://api.github.com/repos/apache/incubator-devlake/pulls/4630 instead of https://api.github.com/repos/apache/incubator-devlake/pulls/1248460646


Opening file with no rows causes panic

When opening a file with no rows, I see the following panic:
panic: runtime error: index out of range [0] with length 0

goroutine 9759 [running]:
github.com/segmentio/parquet-go.(*File).ReadPageIndex(0x4ce8540?)
        file.go:177 +0x705
github.com/segmentio/parquet-go.OpenFile({0x4cc8d40?, 0xc0050541e0}, 0x10c4, {0x0, 0x0, 0x0})
        file.go:84 +0x4dc
github.com/segmentio/parquet-go.openFile({0x4cc8d40?, 0xc0050541e0?})
       reader.go:99 +0x7a
github.com/segmentio/parquet-go.NewGenericReader[...]({0x4cc8d40, 0xc0050541e0}, {0x0, 0xc001311bc0?, 0x4e416d?})
        reader_go18.go:35 +0x85

This line contains the following:
columnIndexOffset := f.metadata.RowGroups[0].Columns[0].ColumnIndexOffset

Hello @bprosnitz and thanks for reporting!
Im curious to hear why you closed the issue, were you able to find a workaround?

Hi!
Sorry, I shouldn't have closed the issue -- I didn't have a simple test example at the time and wanted to confirm.
I created a PR that adds a testcase file with an example of this behavior and a small fix -- see https://github.com/segmentio/parquet-go/pull/408


CLI flag to allow self-signed certificates

reqwest supports disabling certificate verification, such as you might have with simple self-signed certificates - .danger_accept_invalid_certs(true). Should add a CLI flag option to enable/disable this functionality, to make it easier to test stuff before deployment.

Resolved with 42b02170493f98046fc6bd94b136f684961ca8df


Confd binary will not run in Alpine, but will run in Ubuntu

We have a dev build of confd running (Sorry I cannot upload it).
In gliderlabs/alpine trying to execute it gives only the message "not found" as if the file does not exist.  One can clearly see the file exists and is executable however.
The exact error looks like this, though I was calling it "foo" at the time:
sh: ./foo: not found
Put the same binary on the host. confd responds as expected.
Bind mount that binary into a the alpine container, and get the same "not found" error.
Bind mount that binary into a ubuntu container, and get the expected result (confd tries to start and yelps about missing config).
So finally ran ldd.  I suspect one of these .so is missing:
# ldd foo
	linux-vdso.so.1 =>  (0x00007fff489fe000)
	libpthread.so.0 => /lib/x86_64-linux-gnu/libpthread.so.0 (0x00007fbb4ccc3000)
	libc.so.6 => /lib/x86_64-linux-gnu/libc.so.6 (0x00007fbb4c8fe000)
	/lib64/ld-linux-x86-64.so.2 (0x00007fbb4cee6000)

Would be happy to send you the binary if you like.

it's linked against glibc. musl is not (well, not currently) binary-compatible. you'll want either one built for musl or a statically-linked binary.

If VDSO is the only external link, it might be possible to static compile the binary. Check out the static cgo section of http://blog.hashbangbash.com/2014/04/linking-golang-statically/.
Can you give some info on how confd was compiled?

Sorry for the false alarm @andyshinn and thanks @muhmuhten I missed the libc in the output, so its is not statically compiled (my assumption)
I am tagging @karthequian to answer the question on how it was compiled in case there is a nugget here.

Hey guys. To compile the binary, I just used the recommended way to build the confd binary from the project (https://github.com/kelseyhightower/confd) on an ubuntu vm. Confd uses the gb build tool.

Hmm, something must be different in the build process. The 0.10 confd release is a static binary and the ldd output from @behemphi suggests yours is not:
$ dria                                                                                ~/Projects/gliderlabs/docker-alpine
/ # apk-install ca-certificates wget
fetch http://alpine.gliderlabs.com/alpine/v3.2/main/x86_64/APKINDEX.tar.gz
(1/9) Installing run-parts (4.4-r0)
(2/9) Installing openssl (1.0.2d-r0)
(3/9) Installing lua5.2-libs (5.2.4-r0)
(4/9) Installing lua5.2 (5.2.4-r0)
(5/9) Installing ncurses-terminfo-base (5.9-r3)
(6/9) Installing ncurses-widec-libs (5.9-r3)
(7/9) Installing lua5.2-posix (33.3.1-r2)
(8/9) Installing ca-certificates (20141019-r2)
(9/9) Installing wget (1.16.3-r0)
Executing busybox-1.23.2-r0.trigger
Executing ca-certificates-20141019-r2.trigger
OK: 8 MiB in 24 packages
/ # wget -q https://github.com/kelseyhightower/confd/releases/download/v0.10.0/confd-0.10.0-linux-amd64
/ # ldd confd-0.10.0-linux-amd64
ldd: confd-0.10.0-linux-amd64: Not a valid dynamic program

If someone runs across this, here is what I had to do in the end:

Upgrade to golang 1.5.1 (gb did not support cross compiling from Darwin on 1.4.x it would seem)
Remove my packages directory (because many were of the 1.4 flavor)
Install gb sudo GOPATH=/Users/boyd/go go get  github.com/constabulary/gb/...
Cross compile and ensure no use of cgo: GOOS=linux GOARCH=amd64 CGO_ENABLED=0 gb build all

The binary landed in bin/confd-linux-amd64

Also if you dig around there is a glibc package for Alpine that Andy put
together.
On Mon, Oct 5, 2015 at 7:30 PM, Boyd Hemphill<EMAIL_ADDRESS>wrote:

If someone runs across this, here is what I had to do in the end:

Upgrade to golang 1.5.1 (gb did not support cross compiling from
Darwin on 1.4.x it would seem)
Remove my packages directory (because many were of the 1.4 flavor)
Install gb sudo GOPATH=/Users/boyd/go go get
github.com/constabulary/gb/...
Cross compile and ensure no use of cgo: GOOS=linux GOARCH=amd64
CGO_ENABLED=0 gb build all

The binary landed in bin/confd-linux-amd64
—
Reply to this email directly or view it on GitHub
https://github.com/gliderlabs/docker-alpine/issues/78#issuecomment-145706573
.

--
Jeff Lindsay
http://progrium.com

Here is an example of what @progrium is talking about.  Thanks guys!
https://github.com/stackhub/service-prometheus/blob/master/Dockerfile


Delete unused stub class HY_HydroNetwork

The class HY_HydroNetwork has no substance, nor any uses. It contains a spurious reference to a collection of HY_CatchmentArea instances, which threw me off in other refactoring work.
Removals

class HY_HydroNetwork

Testing

CI

Checklist

[x] PR has an informative and human-readable title
[x] Changes are limited to a single goal (no scope creep)
[x] Code can be automatically merged (no conflicts)
[x] Code follows project standards (link if applicable)
[x] Passes all existing automated tests
[x] Any change in functionality is tested
[x] New functions are documented (with a description, list of inputs, and expected output)
[x] Placeholder code is flagged / future todos are captured in comments
[x] Project documentation has been updated (including the "Unreleased" section of the CHANGELOG)
[x] Reviewers requested with the Reviewers tool :arrow_right:

There was a bit of discussion that we may want to keep something like this around for future modeling needs. However, right now, the code that's present supports nothing, and would be pretty trivial to resurrect or reproduce


How to disable trace recording using OpenTelemetry .NET with ApplicationInsights?

Library name and version
Azure.Monitor.OpenTelemetry.AspNetCore 1.2.0
Query/Question
ASP .NET Core 8 app.
OpenTelemetry 1.9.0
Azure.Monitor.OpenTelemetry.AspNetCore 1.2.0
I have the following code to configure OpenTelemetry to collect some metrics and write them to the Azure ApplicationInsights:
builder.Services
	.AddOpenTelemetry()
	.WithMetrics(metrics =>
	{
		metrics.SetResourceBuilder(ResourceBuilder.CreateDefault().AddService(appName));

		metrics.AddAspNetCoreInstrumentation();
		metrics.AddRuntimeInstrumentation();
		metrics.AddProcessInstrumentation();
	})
	.WithLogging()
	.UseAzureMonitor()
;

The issue with this is that I also have a lot of traces in the ApplicationInsights, although I don't want them to be there. If you look inside the UseAzureMonitor() method, you can find .WithTracing() call.
I couldn't find an option how to disable traces. The only idea I have is to duplicate UseAzureMonitor() code, but without WithTracing() call. I think it's not necessary to explain why I don't want to do that.
So, if there a good option how I can use ApplicationInsights with OpenTelemetry .NET but without traces?
Environment
No response

Is there anyone alive here...?


Add more samples, tutorials, or docs to help users onboard

The templates are minimal. Additional guidance to help learn the product or create new projects quickly would be very helpful. Maybe have some starter projects that can be cloned from GitHub?

On a related note, I went ahead and updated some of the wiki pages, and more notably changed the wiki homepage to be more inclusive and easier to navigate.
https://github.com/Microsoft/nodejstools/wiki
This also enables us more easily understand our own doc structure so we can improve it.

I also added some Windows-specific resources and links to other VS extensions, among other things.

Closing as too opened ended. We should create more actionable issues to track any work in this area.
The nodejs guidelines may also cover some of this: https://github.com/Microsoft/nodejs-guidelines


x/net/http2: curGoroutineID is called in production

When I was looking at http2 benchmark profiles, I found calls to curGoroutineID. This should not happen unless DEBUG_HTTP2_GOROUTINES=1, but it is inexplicably happening anyway.
All three calls to curGoroutineID are in gotrack.go, and all three are protected by the boolean. If you make the following patch to gotrack.go, so that the boolean is unambiguously false:
git diff gotrack.go
diff --git a/http2/gotrack.go b/http2/gotrack.go
index 9933c9f..57196da 100644
--- a/http2/gotrack.go
+++ b/http2/gotrack.go
@@ -11,13 +11,12 @@ import (
 	"bytes"
 	"errors"
 	"fmt"
-	"os"
 	"runtime"
 	"strconv"
 	"sync"
 )

-var DebugGoroutines = os.Getenv("DEBUG_HTTP2_GOROUTINES") == "1"
+var DebugGoroutines = false

 type goroutineLock uint64

@@ -49,6 +48,8 @@ func (g goroutineLock) checkNotOn() {
 var goroutineSpace = []byte("goroutine ")

 func curGoroutineID() uint64 {
+	panic("how can we possibly be getting here?")
+
 	bp := littleBuf.Get().(*[]byte)
 	defer littleBuf.Put(bp)
 	b := *bp

And then you run the benchmarks, the panic happens:
$ go test -c && ./http2.test -test.cpuprofile=prof -test.bench=BenchmarkServerPosts -test.run=XXX
BenchmarkServerPosts-4	--- FAIL: BenchmarkServerPosts-4
	http2_test.go:64: 2015/12/19 16:38:31 http: panic serving <IP_ADDRESS>:54702: how can we possibly be getting here?
		goroutine 9 [running]:
		net/http.(*conn).serve.func1(0xc820ad6000)
			/Users/jra/go/src/net/http/server.go:1380 +0xc1
		golang.org/x/net/http2.curGoroutineID(0x0)
			/Users/jra/src/golang.org/x/net/http2/gotrack.go:51 +0x6e
		golang.org/x/net/http2.newGoroutineLock(0x38c620)
			/Users/jra/src/golang.org/x/net/http2/gotrack.go:27 +0x2f
		golang.org/x/net/http2.(*Server).handleConn(0xc8200e2660, 0xc82007a180, 0x949e90, 0xc820ad4000, 0xb26d80, 0xc8203c4080)
			/Users/jra/src/golang.org/x/net/http2/server.go:222 +0x23a

This is with: go version devel +97f854c Sat Dec 19 10:00:04 2015 +0000 darwin/amd64
(I am profiling on MacOS 10.10 with rsc's kernel patch installed. The profile looks correct in all other aspects.)

I just noticed that TestGoroutineLock leaves DebugGoroutines set to true incorrectly, but in my tests above I was using -test.run=XXX to disable it anyway.

Sorry, I missed the fact that DebugGoroutines is set in http2_test.go. That explains the behavior that confused me.


Google shows weird results when you search for covidactnow.org.

Google for e.g. covidactnow.org:

Not sure what all we need to do to fix this.  From first glance though I notice that we're populating meta title/description tags on the model pages (see https://github.com/covid-projections/covid-projections/blob/ddf1929c4b58170c696da5a437f18701f273adc2/src/screens/ModelPage/ModelPage.js#L325), but not on the HomePage, FAQ, etc. Doing so would probably help?
@szhu mentioned a sitemap may help as well. https://support.google.com/webmasters/answer/183668?hl=en

A few observations:

Google calls these things "Sitelinks". https://support.google.com/webmasters/answer/47334
Currently, all pages on the site have have the statically generated title "Covid Act Now", yet they have distinct titles in as sitelinks. So we can probably fix this without changing any of the HTML. (cc #284, issue on server side rendering)
The sitelink titles that say "You must act now", "Keep staying at home" are probably taken from the document title that's set by the React app.
The sitelink titles that say "California", "Virginia"… where are these from? I have two guesses:

A lot of websites have the website name in every page title, so Google is probably factoring them out and keeping just the text that changes between every page… leaving only the state names.
People are linking to these pages with the state names, and Google is using these.
It's inferring it from the URL?

Based on this, I think a good shot at solving this would be to update the title set in ModelPage.js to be of the form "{state name} • Covid Act Now". Google will consistently factor out "Covid Act Now" and leave only the state names.

Another observation: The snippets that are shown under the sitelinks are hard to control, even for major sites.

Discussed with @maxwhenderson. Given that we can't change which pages appear as sitelinks and the order in which they appear, we decided that this is a reasonable target of what we'd like the search result descriptions to look like:

Before
After

Open questions I still have:

What do we want the homepage description to be? There is currently none set in index.html. Here is the title/description we use for sharing

"This model predicts the last day each state can act before the point of no return"
"The only thing that matters right now is the speed of your response"

The descriptions are fairly vague.

There is no target audience. Whose response are we talking about? Previously there was text that said "Public officials:" -- I think that was useful. But also, a narrative can become hard to follow if the POV keeps changing throughout the website. If the page's target audience is everyone, then a message like "The only thing that matters is the how quickly your public officials respond" be less jarring.
All of the titles and descriptions make no explicit references to COVID-19 or Coronavirus. It seems… almost intentionally vague? Not sure if we're leaving it out for some reason. The domain and title of the site contain "Covid" but it's capitalized differently and not referenced directly either. Also, until you click into the site, it's not clear what kind of action "act" is implying.

The word "model" might only have meaning to the stats/data-science community, not politicians or the general public.

Here's my best attempt at resolving the open questions above:

Addendum: the html I used so I can use it for later:

<link href="https://covidactnow.org/" rel="prerender">

Covid Act Now

covidactnow.org

covidactnow.org

Cached

This model predicts the last day each state can act before the point of no return.

California Forecast

Keep staying at home in California.

Hawaii Forecast

Keep staying at home in Hawaii.

Texas Forecast

Keep staying at home in Texas.

About

CovidActNow.org was created by a team of data ...

Florida Forecast

Keep staying at home in Florida.

Model

The U.S. Intervention Model is a data platform that projects ...

South Dakota Forecast

You must act now in South Dakota.

Endorsements

While no projection is perfect, we endorse this tool and model ...

Louisiana Forecast

Keep staying at home in Louisiana.

Virginia Forecast

Keep staying at home in Virginia.

More results from covidactnow.org »

<link href="https://covidactnow.org/" rel="prerender">

Covid Act Now

covidactnow.org

covidactnow.org

Cached

Urge your public officials to quickly take action against the COVID-19 pandemic. These charts predict the last day each state can act before the point of no return.

California Forecast

California: Keep staying at home to protect against the COVID-19 …

Hawaii Forecast

Hawaii: Keep staying at home in to protect against the COVID-19 …

Texas Forecast

Texas: Keep staying at home to protect against the COVID-19 …

About

CovidActNow.org was created by a team of data ...

Florida Forecast

Florida: Keep staying at home to protect against the COVID-19 …

Model

The U.S. Intervention Model is a data platform that projects ...

South Dakota Forecast

South Dakota: Urge your public officials to act now against the …

Endorsements

While no projection is perfect, we endorse this tool and model ...

Louisiana Forecast

Louisiana: Keep staying at home to protect against the COVID-19 …

Virginia Forecast

Virginia: Keep staying at home to protect against the COVID-19 …

More results from covidactnow.org »

cc @Jtensminger as FYI

Made a further discovery while working on solving this: I don't think any of the page-specific Facebook descriptions are working, since (1) Facebook doesn't interpret <meta> tags in JavaScript and (2)
Tested with the following methods:

https://developers.facebook.com/tools/debug/?q=https%3A%2F%2Fcovidactnow.org%2Fus%2Fca
Went to https://covidactnow.org/us/ca and clicked the FB share button
Sent myself https://covidactnow.org/us/ca in Facebook Messenger

With all 3 results, only the title and description for the home page was returned.


stream port

Good afternoon!
Is it possible to forward one port to different subdomains?
For example RDP port:
server1.mysite.com:3389    =>  <IP_ADDRESS>:3389
server2.mysite.com:3389    =>  <IP_ADDRESS>:3389
Only one active rule is created in the stream tab

Don't believe so, streams on nginx are simple forwards, they don't look inside packets to see what hostname was being used only the IP and port that nginx is being hit on. Simply put, you are actually setting up something like <IP_ADDRESS>:3389 => <IP_ADDRESS>:3389 so having server1.mysite.com and server2.mysite.com both pointing at <IP_ADDRESS> doesn't help us get 2 different streams.
Use multiple unique ports on the npm side.


fix indent on video block

issue #22900
remove br for fix indent
en PR
/language ko
/area web-development

before fix
https://kubernetes.io/ko/#video
after
https://deploy-preview-22901--kubernetes-io-master-staging.netlify.app/ko/#video
/assign @pjhwa

It looks good to me.
/lgtm

Thank you @Arhell .
/lgtm
/approve


Depend on tagged version of Iceberg

In Pharo 11 we should depend on the tagged version of Iceberg else Pharo build is breaking

I don't know why Pharo11 branch is testing against Pharo 12. But the Pharo 11 branch passed.


Add support for migrating ui-group & ui-page and add default ui-base and ui-theme

Description

Moves scaffolding into standalone function scripts
Adds support to migrating ui-page and ui-group
Adds in a default ui-base and ui-theme which aren't included in a D1.0 exported flow.json
Adds unit tests for ui-page and ui-group

Related Issue(s)
Close #1
Close #3
Close #4
Close #5

As far as I can see, this is approved. I see there's another reviewer, so I'll have them merge as I'm outmatched in JS skill.


Positive and negative float zero are not ===

This program gives the wrong output:
import ballerina/io;

public function main() {
   io:println("Should be false: ", +0.0 === -0.0);
}

From https://ballerina.io/spec/lang/master/#section_<IP_ADDRESS>:

Positive and negative zero of a floating point basic type are distinct values

Duplicates #17977


[Android] Fix behaviour for Filtered ChoiceSet

Related Issue
Fixes #6483
Fixes #6485
Description
Adds a filter to overrride how does the AutocompleteTextView object used finds matches in the list of options.
The filter checks against lower case versions of the string array to find if the provided string is contained in each string.
Due to the high volume of the elements and the processing time required for comparing each string, the filter has to synchronize the filtered list, otherwise this provokes an application crash.
Finally, tests were added to verify the correct functioning by checking against preffixes, suffixes, substring, case ignoring and empty strings
Sample Card

Input.ChoiceSet.Filtered.json

How Verified
Added UI tests to verify the correct behaviour
Microsoft Reviewers: Open in CodeFlow

/azp run android-ci.yml

/azp run AdaptiveCards-iOS-CI

/azp run android-ci.yml

/azp run android-ci.yml


Nx Lib Index.ts

import { noDependencies, sameTag, SheriffConfig } from '@softarc/sheriff-core';

export const sheriffConfig: SheriffConfig = {
  tagging: {
    'libs': {
      'shared/src': 'nx-lib',
      'shared/src/lib/<shared>': 'shared',
      '<domain>/src': 'nx-lib',
      '<domain>/src/lib/feat-<name>': ['domain:<domain>', 'type:feature'],
      '<domain>/src/lib/<type>': ['domain:<domain>', 'type:<type>'],
    },
  },
  depRules: {
    root: ['type:api', 'shared', ({ to }) => to.startsWith('domain')],
    'domain:*': [sameTag, 'shared'],
    'type:api': ['type:feature', 'type:model', 'type:ui', 'type:data'],
    'type:feature': ['type:model', 'type:ui', 'type:data'],
    'type:ui': ['type:model'],
    'type:data': ['type:model'],
    'type:model': noDependencies,
    shared: 'shared',
  },
};

Fails with
       /Users/rainerh/programming/powerduo-nx-and-sheriff/sheriff-nx/apps/eternal/src/app/app.config.ts
         1:1  error  Dependency Rule (internal error): placeholder for value "domain" does already exist  @softarc/sheriff/dependency-rule

This is when an empty index.ts is defined somewhere in the folder structure. Am I right @rainerhahnekamp ?

Hi @attilacsanyi, I honestly don't know. I just encountered and filed this bug so I don't forget it. It could be as you said.
Do you have this error in your project?

Hi @attilacsanyi, I honestly don't know. I just encountered and filed this bug so I don't forget it. It could be as you said.
Do you have this error in your project?

Yes I got this if I introduce a new index.ts lets say in a components subfolder of src in an Nx lib, beside the library root index.ts
So if I add an empty index.ts (marked as red) I got the following error:
error  Dependency Rule (internal error): placeholder for value "type" does already exist  @softarc/sheriff/dependency-rule

I hope this helps @rainerhahnekamp 🤞 thanks for any hint on this, meanwhile I stick to only using one index.ts per lib

Thanks, that helps. Let me try to find a fix for that.

Update: The error has been found, and a fix has also been provided. However, there is one edge case that I want to verify before I push and release.

Update: The error has been found, and a fix has also been provided. However, there is one edge case that I want to verify before I push and release.

Thank great, thanks @rainerhahnekamp which version have the fix?

Hi @attilacsanyi, fix has been merged and published in version 0.14.4. It would be great if you can check it out and confirm that it works on your machine.

Hi @attilacsanyi, fix has been merged and published in version 0.14.4. It would be great if you can check it out and confirm that it works on your machine.

It seems working I got more specific lint error for the above shared components structure:
error  Dependency Rule (internal error):
No assigned Tag for '.../libs/shared/ui/src/lib/components' in sheriff.config.ts  @softarc/sheriff/dependency-rule

This is expected as I have tags only in lib root index barrel in Nx workspace:
// sheriff.config.ts
...
export const sheriffConfig: SheriffConfig = {
  tagging: {
    libs: {
      'shared/<type>/src': 'shared:<type>',
      ...
    },
  },
  depRules: {
     ...
  },
};
...

Yes, you have to tag every module. There is no way around it. I've discussed mitigation strategies in #69.
I'm still wondering if it would be better not to call it "internal error."" Internal error" sounds like a bug of sheriff itself.

Yes, you have to tag every module. There is no way around it. I've discussed mitigation strategies in #69.
I'm still wondering if it would be better not to call it "internal error."" Internal error" sounds like a bug of sheriff itself.

Maybe "Missing configuration" would be better, but I am fine as I see a more detailed message about the missing tag in the above case.
I also think it's a good idea to keep only one index.ts in the root of the libs, just simpler and less tags and rules needed to be handled. The rest should be relative imports.
Thanks for the quick fix.

Yes, but I think we should rename those kinds of errors to "user error" or similar.
If you use NX and just have one index.ts per lib, then I wouldn't recommend using Sheriff.
Sheriff was made to have multiple modules inside an Nx library. As long as you stick to conventions and every module has the same folder structure, you should be able to achieve that without making it too complicated.
The other option would be modules with index.ts as discussed here #47

Hmmm, "If you use NX and just have one index.ts per lib, then I wouldn't recommend using Sheriff."
I want to achieve separated libs and Sheriff help me to auto tag projects based on the folder naming convention.
So I can skip the manually maintained tags in every Nx project as I would do normally.
Then I create the depRules as I need to allow only specific imports from one library into another.
With this config I have one index.ts barrel per library like in the official Nx Boundaries. I want to utilise the Nx DTE hence I separated out those libraries by domains and types as below:
This version inspired by your full-nx version of Sheriff config.
// sheriff.config.ts
export const sheriffConfig: SheriffConfig = {
  tagging: {
    libs: {
      'shared/<type>/src': 'shared:<type>',
      '<domain>/feat-<name>/src': ['domain:<domain>', 'type:feat'],
      '<domain>/<type>/src': ['domain:<domain>', 'type:<type>'],
    },
  },
  depRules: {
    // app should use any ui lib and any shared
    root: ['type:api', 'shared:*', '*:ui', ({ to }) => to.startsWith('domain')],
    'domain:*': [sameTag],
    // api can use any type from the same domain
    'type:api': ['type:*'],
    'type:feat': ['type:ui', 'type:data', 'type:model', 'shared:*'],
    // ui can use shared ui and model
    'type:ui': ['type:model', 'shared:ui', 'shared:model'],
    // data can use shared data and model
    'type:data': ['type:model', 'shared:data', 'shared:model'],
    'type:model': ['shared:model'],
    'shared:ui': ['shared:model'],
    'shared:data': ['shared:model'],
    'shared:model': noDependencies,
    'shared:*': [sameTag],
  },
};

Appreciate your feedback why this is not recommended in Nx monorepo with multiple libs and what else do I need to achieve the same as above in Sheriff config. @rainerhahnekamp

Hmmm, "If you use NX and just have one index.ts per lib, then I wouldn't recommend using Sheriff."
I want to achieve separated libs and Sheriff help me to auto tag projects based on the folder naming convention. So I can skip the manually maintained tags in every Nx project as I would do normally. Then I create the depRules as I need to allow only specific imports from one library into another.
With this config I have one index.ts barrel per library like in the official Nx Boundaries. I want to utilise the Nx DTE hence I separated out those libraries by domains and types as below:
This version inspired by your full-nx version of Sheriff config.
// sheriff.config.ts
export const sheriffConfig: SheriffConfig = {
  tagging: {
    libs: {
      'shared/<type>/src': 'shared:<type>',
      '<domain>/feat-<name>/src': ['domain:<domain>', 'type:feat'],
      '<domain>/<type>/src': ['domain:<domain>', 'type:<type>'],
    },
  },
  depRules: {
    // app should use any ui lib and any shared
    root: ['type:api', 'shared:*', '*:ui', ({ to }) => to.startsWith('domain')],
    'domain:*': [sameTag],
    // api can use any type from the same domain
    'type:api': ['type:*'],
    'type:feat': ['type:ui', 'type:data', 'type:model', 'shared:*'],
    // ui can use shared ui and model
    'type:ui': ['type:model', 'shared:ui', 'shared:model'],
    // data can use shared data and model
    'type:data': ['type:model', 'shared:data', 'shared:model'],
    'type:model': ['shared:model'],
    'shared:ui': ['shared:model'],
    'shared:data': ['shared:model'],
    'shared:model': noDependencies,
    'shared:*': [sameTag],
  },
};

Appreciate your feedback why this is not recommended in Nx monorepo with multiple libs and what else do I need to achieve the same as above in Sheriff config. @rainerhahnekamp

@rainerhahnekamp I appreciate your feedback on this, thank you so much.

Sorry Attila, missed to answer.
I honestly wasn't aware of your use case. I always thought that Sheriff only becomes interesting, when you want modules inside an Nx lib or module checks in the Angular CLI
I didn't see the convenience of the sheriff.config.ts as reason enough to go with Sheriff, so that's actually very nice to hear.

Sorry Attila, missed to answer.
I honestly wasn't aware of your use case. I always thought that Sheriff only becomes interesting, when you want modules inside an Nx lib or module checks in the Angular CLI
I didn't see the convenience of the sheriff.config.ts as reason enough to go with Sheriff, so that's actually very nice to hear.

Thanks for your feedback @rainerhahnekamp , yes it seems Sheriff is so flexible that we can configure it in different ways.

folders inside one Nx lib with index.ts barrels: sheriff-nx
each Nx lib is the module itself without extra folder barrels full-nx
Still try to understand when 1 .is better over 2. approach or vica - versa.

I spotted in your your full-nx version of Sheriff example that manually adding tags in project.json is not needed at all in order to make Sheriff logic working.
Those tags are needed only if we want to utilize Nx boundaries eslint rule, but it is less flexible than Sheriff folder structure pattern mapping and kind of redundant as Sheriff do similar things already.


LikeCoin: inital base setup

blocking: wait for base-v1.0.4
prefered if we release base first. but will setup colors for now

done


made the hero section responsive for mobile and tablet screens

Related Issue
Fixes:  #986
Description
Fixes the hero section for tablet and mobile screens so the section looks good.

Type of PR

[x] Bug fix
[ ] Feature enhancement
[ ] Documentation update
[ ] Other (specify): _______________

Screenshots / videos (if applicable)
tablets:

mobiles:

Checklist:

[x] I have made this change from my own.
[x] My code follows the style guidelines of this project.
[x] I have performed a self-review of my own code.
[x] My changes generate no new warnings.
[x] I have tested the changes thoroughly before submitting this pull request.
[x] I have provided relevant issue numbers and screenshots after making the changes.

@Stiffpixels While making it responsive, ensure the text also looks good. 'find' should not be split onto a new line, and the same goes for 'adventure'.

@Stiffpixels Do the above changes as suggested by mentor & then open a new PR.

I could have just pushed the changes into this PR. Why close the PR? @anuragverma108


msbot creates an Application Insights resource and should configure it on the qnahost Web App

Tool
Name: Msbot
Describe the problem
msbot creates an Application Insights resource, but does not configure it on the qnahost Web App when using msbot clone services with the Enterprise Bot Template.
Installing and linking the Application Insights site extension to the Application Insights resource enables us to leverage queries for analytics on our QnA Maker knowledge bases
Describe the solution you'd like
I would expect that the Application Insights site extension would be installed and configured on the qnahost Web App.
[enhancement]

@brisebois, we will be releasing ARM template support for all provisioning and configuration activities for Bot Framework.  This will show up in all the samples, all our code generators, and documentation.  We will be deprecating the use of .recipe files, and msbot clone functionality once we release these updates.
Since we are deprecating msbot as a provisioning and deployment option, replaced with ARM template support, I'm going to resolve this issue as "won't fix"


[DM-24662] Set default Gafaelfawr IdP to NCSA

This worked well on nublado.lsst.codes.  The IdP selection screen
is still shown, but NCSA is selected as the default.  Update the
other Gafaelfawr environments to have the same configuration.

We've decided not to do this for the time being because there's no way to just set the default, only constrain the list of IdPs. We may ask for this as a feature from CILogon in the future.


add graph creator

@dydgus9011 Create a new folder for the graphical calculation and data tidying. It would be nice to have a different folder outside of src like in the main path. As laster on if in the future they want to change the graph design, it is not necessary to go through the main data gathering code.

ok


Public facing map fix

[x] allow all public users to see the on-click fields for iapp records and invasivesBC observations, but block the users from opening any records.

[x] if they try to open up the record by clicking on it, provide an error message that says "InvasivesBC Access is required to view complete records. Access can be requested at the top right of the page under the Person Icon" (or something like that).

[x] fix error message as indicated in the comments below

[x] hide the example/fake InvasivesBC donuts from the map in PROD until they are working.

[x] invasivesBC observations are showing

[x] IAPP records are showing

[ ] required for web, optional for mobile.

in prod, as of june 20th, 2022, the public facing map give this error (see attached pic).

Currently checked boxes are in unmerged PRs

Reviews in Progress for changes

@micheal-w-wells to review and push if ready.

Also unsure if works on mobile


Different default feature set on Windows and Linux?

Hi! Not sure if I'm doing something wrong here, but I noticed that, using setup-gstreamer@v1 with the default options, my app can play a video on Windows but not on Ubuntu. Setting GST_DEBUG=3, I can see this:
warning: No decoder available for type `video/x-h264`
warning: No decoder available for type `audio/mpeg`

Should the Action's default gstreamerOptions enable the same decoders on Linux that you'd get in a Windows build? Or is this an intentional difference?
I've been looking at some of the gstreamer meson_options.txt files to figure out what options I'd need to set, but I'm not really sure what I need to get parity between the Windows and Linux builds. If you have any tips, I'd appreciate it 😅

This is basically the same misunderstanding I had in https://github.com/blinemedical/setup-gstreamer/issues/209. My dev machine already has the codecs installed as part of the GStreamer development setup, so it seemed like the build "just worked" on its own. I realize now that enabling the GStreamer options to build the plugins is different than actually bundling them with the app. Sorry for the noise.


Update method signatures and artisan creation

The method signature for newFromBuilder has changed with Laravel 5. The way artisan is called has changed as well. This fixes both issues.
It also fixed the travis-ci builds so that the database table is created before running the tests.

Hi, @EspadaV8! Thank you very much for the PR. As I can see, it resolves artisan in tests only, am I right? I haven't updated generators and migrator yet, so the library is still not prepared for Laravel 5.

@franzose I'm a noobie and can't make it work with laravel 5. Just wondering if the generators and migrator will be updated soon... :-)

@sidyamamoto yes, they will be updated soon, I need more time to do that. I have already created a separate branch for Laravel 4 version of the package, so now master will contain the latest changes for Laravel 5. Stay tuned)

@franzose Thanks man!

Oops. I remember opening this but didn't think I had submitted it. I was mean to hold off on that. Sorry.

@EspadaV8 no prob, thank you for help!