Some storage commands do not output the response body received from the service

Few examples that don't output anything. Both the service and the underlying client library returns results for these requests. Could we output those ?
az storage entity insert -t users --entity RowKey=key PartitionKey=key name=value
az storage message put -q $queue_name --content
az storage file upload --source $full_path_to_file -s $share_name -p $directory_name

Same with this one:
az storage account delete --resource-group $resource_group_name -n $storage_account_name

I also wanted to create an Issues on this.
In my case, 'az group list' also do not return any message.
I know that I don't have any Resource Groups, however, I am expecting some output that will inform me that I don't have resource groups.

@seguler, the problem with az storage account delete is that it is actually incorrectly described in swagger (assuming that the service indeed returns a 200 w. a body for a successful delete). The response schema is not provided, and thus and management SDKs (and thus the CLI) will not be able to get the response.
az storage entity insert should indeed return a value since that is what the SDK does.
In general, we try to avoid making multiple rest calls for any given command.
For the az storage message put command, it does not look like storage message put/QueueService.put_message in the storage data plane library returns anything, nor does FileService.create_file_from_path/az storage file upload return any value. They should ideally be addressed in the Python dataplane SDK since if this is interesting information from a CLI perspective, it stands to reason that other application developers would want the same information returned from the SDK.
@jahongirman, we are intentionally avoiding spurious output from the CLI at this point. We are discussing alternate ways of providing user feedback for primarily interactive use. Feel free to open a separate issue if you want to continue the discussion - we'd like to use this issue to track the specific issues that @seguler mentioned above.

I've created PR #1972 for az storage entity insert.

@seguler file upload  and put queue don't return what the service returns because the storage SDK methods that underpin these commands do not return what the service does. Please file an issue here:  https://github.com/Azure/azure-storage-python

Except for storage entity insert (which has been fixed in #1972) the rest of the commands which return nothing do so because either the service returns nothing or the SDK doesn't pass the response back to the client.


Clean up mapper consents data

[ ] updater should be allowed null and set to that if the last updater is unknown. like the submissions sheet problem, need to see if google exposes data about each cell's last editor
[x] mappers need to be loaded into users database
[x] and beatmapsets

also:

[ ] Clean up migrated data (delete/replace unrelated accounts)

Mostly a result of mappers changing names and new users taking the old names and the data on the Google sheet not being updated to account for it.


Support MacOS

Perhaps this is just a documentation of putting the .so file in a separate Binaries directory, but I'm skeptical the current instructions of putting all of the libraries from the SDK into Binaries/Win64 will work
Looks like there's more documentation about how to support this here

I hope I'll get help on getting this plugin up and running on a macOS since I have no way of testing on Mac (very expensive to get one).


[oh-my-zsh] plugin 'youtube-dl' not found

Os: Manjaro Linux
Error in shell ZSH + Oh my ZSH:
[oh-my-zsh] plugin 'youtube-dl' not found
User@pc~
I follow all the installation steps and I have checked the hidden path /home/user/.oh-my-zsh/custom and the folder 'oh-my-zsh-youtube-dl-aliases' does appear.
How can I solve that?

My bad, I'm sorry. Please try these updated instructions: https://github.com/katrinleinweber/oh-my-zsh-youtube-dl-aliases/pull/3/files


Error while rejecting order from Order details page

Current behavior
When attempting to reject an order from the Order details page of the Open tab, an error message stating "something went wrong" appears.Then the order is not visible on the BOPIS app and it is not rejected in OMS.
Expected behavior
The order should rejected from the Order Details page and it should also be rejected in OMS as well.
Steps to reproduce the issue

Can you handle fixing this bug by yourself?

[ ] YES
[x] NO

Environment details

Browser:
OS:
Code Version:

Additional information

@Pragyad07 As discussed, this is a data issue. Please let us know when that is fixed and issue still occurs. So, we can fix this issue on app side


add open collective link to footer

.deploy to development

For now this is fine and we can ship and iterate. In the future, I'll open a PR to make the linked text a button like the UA one

.deploy


Update versions for Release 10.27.0

Firebase 10.27.0 pods staged in SpecsStaging.
Note: Intentionally skipped from 10.25.0 to 10.27.0 since 10.26.0 will be an SPM-only release; see https://github.com/firebase/firebase-ios-sdk/pull/12873 for context.
#no-changelog

Going to merge in advance of today's nightlies


Update Stack Overflow link on client library ref landing page for PHP

On the current landing page for google-cloud-php there is a Stack Overflow icon:

[Current Result]
That icon currently points to http://stackoverflow.com/questions/tagged/gcloud-php
[Expected Result]
The icon should now point to: http://stackoverflow.com/questions/tagged/google-cloud-platform+php

Hey @omaray,
Searching for multiple tags on StackOverflow does not work if you're logged out. It drops everything but the first tag. See here for more information.
Perhaps sticking to a single tag (i.e. google-cloud-php) would be preferable?

Hey - yes I know. But thanks for pointing that out. It was a conscious decision and is in alignment with other (internal) decisions.
For now we'll start with the multi-tag setup. Later on if it's an issue we can always create more tags (we are also trying to reduce the total number of tags).
Finally, if you want to ask a question, you need to be logged on. The premise is also that a lot of people probably are by default (active developers).


Move P0_(0-30) pin definitions to chip_pins.array

Related to this issue.

@rgrover @marcuschangarm

looks good. I'll go ahead in marcus's absence.


Saltern docking at a port that is unpowered along with other misc silly willy things

Not sure when but there's a third docking area below the main two original ones for Saltern.
Arrivals shuttle ignores the two there and docks at the third one below.
Docking doors on the third are unpowered and also do not align with each other well.

(Personally there's already good docking here)

pro wire
top is intended for evac so if arrivals docked there you dont get trolled and have to go to mining dock

arrivals has its own docking arm now so no longer relevant

@PJB3005 close


Add plugin documents

Change description
Add document for plugin listing and  removal.
Screenshots

  ERROR: 1 dead links found!
  [✖] https://dolphinscheduler.apache.org/zh-cn/docs/1.3.9/system-manual

  2 links checked.
  [✖] https://dolphinscheduler.apache.org/zh-cn/docs/1.3.9/system-manual → Status: 404

This is a false alert. Manually checked the link, it's working.


Deleting builds should also delete the build log file

Describe the bug
Once a user chooses to delete a build, they expect all data about the build to be gone.
Desktop (please complete the following information):

Daytona Version: v0.26.1

Additional context
Using logs for debugging purposes is only relevant when the build entry exists in the database. Once the user chooses to delete it, it is no longer necessary.
Logs should be deleted using a server-level "cleanup" poller and not directly from the service because the runner might fail at deleting the build and log some useful info.

This Issue has been automatically marked as "stale" because it has not had recent activity (for 14 days). It will be closed if no further activity occurs. Thanks for the feedback.


TTFT: Prompt evaluation in parallel

Hi @mukel!
This PR covers the TTFT (time to first token): The tokens of the prompt can be computed in parallel, layer by layer, because the input logits are provided by the prompt.
The time saved depends on the prompt length, the current context window size, and the length of the text to be generated. Some prompts are processed significantly faster with this :-).
Exemplary measurements:
5,81 tokens/s (259) [PrEval 7,33 tokens/s (151), TokGen 4,50 tokens/s (108)]
15,47 tokens/s (36) [PrEval 15,90 tokens/s (24), TokGen 14,67 tokens/s (12)]
12,20 tokens/s (62) [PrEval 21,28 tokens/s (17), TokGen 10,51 tokens/s (45)]
17,81 tokens/s (350) [PrEval 18,70 tokens/s (322), TokGen 11,52 tokens/s (28)]

Hi @srogmann, thanks for the contribution, this effectively introduces batching, but can be even faster.
Allocating the tensors on every token is rather expensive, I'd rather allocate reusable tensors in the state once for prompt ingestion e.g. ingest the prompt in batches of 64 tokens at the time.
Parallelizing the for loops in the forward method has small impact compared to the gains that can be obtained from matmul which now becomes a real matrix-matrix multiplication.
I think that the whole matmul (matrix-matrix) can be rewriten using the vector API, using tiling and a few tricks to speed it up.

Hi @mukel, I agree: A lot of allocating would happen at long prompts. Therefore I introduced a batch-size.

Awesome results! :rocket:
Here are some numbers for Llama-3.2-1B-Instruct on my Linux 6.10-13 13900H 64GB@6400 notebook:
Q4
[PrEval 87.71 tokens/s (563), TokGen 50.11 tokens/s (249)] BATCH_SIZE=32
[PrEval 85.73 tokens/s (563), TokGen 50.61 tokens/s (249)] BATCH_SIZE=16
[PrEval 83.90 tokens/s (563), TokGen 50.51 tokens/s (249)] BATCH_SIZE=8

Q8
[PrEval 97.79 tokens/s (563), TokGen 37.73 tokens/s (179)] BATCH_SIZE=32
[PrEval 93.56 tokens/s (563), TokGen 38.14 tokens/s (179)] BATCH_SIZE=16
[PrEval 88.37 tokens/s (563), TokGen 38.36 tokens/s (179)] BATCH_SIZE=8

Interesting how prompt ingestion runs almost at the same speed on both Q4_0 and Q8_0.
I'm integrating this as-is, I have other optimizations for prompt ingestion e.g. the very last wcls matmul is not needed for prompt injection because the logits are discarded anyway, same for the whole FFN of the last layer...
Excellent work, thanks for this awesome contribution!


Feature/add user role authorization

What do a file editorconfig?

What do a file editorconfig? And works?

It is config file, allow to keep consistence between developers. Allow to set what is warning in editor, for example show warning when you don't use this keyword etc. it has many many possible settings to configure and it can be shared between VS, VSC, Rider etc.

Doesn't work login and register

Why I have to set UserName to api/identity/login with success instead of email?

Why I have to set UserName to api/identity/login with success instead of email?

Could you add a comment in the code? I'm not sure what you're asking


Version bump after release.

Before or while filing an issue please feel free to join our  slack channel to get in touch with development team, ask questions, find out what's cooking and more!
Issue #, if available:
Description of changes:
Testing done:
To run CI tests on your changes refer README.md
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@alexwong : This PR seems to be stuck. Could we verify that this tests are fine and merge this?

@alexwong : This PR seems to be stuck. Could we verify that this tests are fine and merge this?

It's just a version bump so I'm fine with it.


[Bug Report]: Create-Permission in Books

Describe the Bug
Create-Permission in Books does not show up when permission is granted
Steps to Reproduce

Create Shelve
Create Book
Give permission to create (Book)
Look with user that has that permission

Expected Behaviour
A Create-Button should appear on the right side (actions menu)
Screenshots or Additional Context
Create-Button appears with other buttons (edit, delete) if their permission is granted (sometimes)
Exact BookStack Version
21.11
PHP Version
No response
Hosting Environment
Docker container

Hi @Sammysamsi,
Could you confirm exactly where you're attempting to set permissions (Step 3) and exactly where you're looking in regards to Step 4?
Both of these steps are somewhat ambiguous and could mean multiple things so just want to nail down the exact flow to re-produce this.

The role itself has no permissions.

The shelve permissions allows the user to create, edit and delete things.

Now I am navigating into the shelve and the actions menu only displays the edit- and delete-button. The add/create-button is missing

When I am granting these permissions to the role itself...

...its showing all buttons as they should be displayed

If thats not clear enough let me know. I also might have found another problem. I'll check that first before i open another report.

Thanks @Sammysamsi for the detail.
Is this only apparent for shelves? If so I think this may have already been raised under #2690. The shelf create permission is currently redundant.

Thats probably the same issue. I am sorry for that. I did not found any more issues with permissions right now.

@Sammysamsi No worries, that other issue was pretty hard to track down to be fair, but had it in the back of my mind. Thanks for making the effort to report!


Items missing from code-completion when using the await keyword

I was just working on some tests for the vs code validator in flutter doctor and noticed something unexpected with the code completion. The code is part of #14463.
Here's the working/correct code (the validate method returns a Future):

I deleted installedWithExtension and invoked code completion, but installedWithExtension wasn't listed in the completion:

If I remove the await then it showed as expected:

(@bwilkerson lmk if there's value in cc'ing you in cases like this; I don't know how cases are normally triaged and whether this makes it easier/more efficient!)

I don't know how cases are normally triaged ...

We have a (rotating) person assigned to triage issues by adding an area label, then people in each area that do further triage, such as whether the issue represents a bug, what the priority is, etc.
I usually do the triage for area-analyzer, so it's fairly likely that I'll see a report like this without being cc'd, but it also doesn't hurt anything if I see it before the area is assigned because I can also assign the area (and won't triage it twice).

@bwilkerson I'm not sure I feel any more knowledgeable about whether it's better to notify or not =) So, in the interests of adding to the notifications you probably get tons of, I'll skip notifying you (unless it's something I have a specific question for you) - though lmk if you decide you'd prefer the other.

Given the code
class C {
  static Future<int> method() async => 0;
}
void f() {
  String s = await C..toString();
}

(which might be too simple to trigger the bug) we now suggest method both with and without the await, so I'm closing this issue.

Given the code
class C {
  static Future<int> method() async => 0;
}
void f() {
  String s = await C..toString();
}

(which might be too simple to trigger the bug) we now suggest method both with and without the await, so I'm closing this issue.


feat: add support for vector search (ospp 2024)

I noticed that some parts of this PR seem to be directly borrowed from the implementation of HNSW index of Apache Kvrocks [1,2].
I would like to remind you that, Apache Kvrocks is an open source software released under the Apache License, and the use of the code of Kvrocks needs to have appropriate copyright notices and keep the license headers.
[1] https://github.com/OpenAtomFoundation/pika/blob/4e52d6bc9707cde5f2c76a9e0a175c18d07ccd5e/src/storage/src/search_format.h
[2] https://github.com/apache/kvrocks/blob/unstable/src/search/search_encoding.h

@PragmaTwice, sorry for this, I will add the missing license headers both in related source files and the license notice file.

Thank you for adding the license header.
I also noticed #2871, similarly, most of the code is directly copied from Kvrocks without any declaration, even though it has not been merged. Considering that this is an OSPP project, such practices are indeed questionable.
I am considering reporting this matter to the OSPP management team.

@PragmaTwice, sorry for my stupid actions, and I promise won't copy code from kvrocks in the future development of this.

因为最近 OSPP 要结项，近期我们在审核参赛同学题目。这个PR 和当事同学沟通过，学生已经根据评论的要求，学生对原初的代码做了全面的改动，没有任何跟其他项目有关的代码。  大家的诉求都得到了满足，所以删除了此 comment。为了记录这个 PR 完整的审核流程，将之前的评论补上：


horizontal_figure input grid order

It seems the order of the input grids in horizontal_figure has to be swapped and is inconsistent to the provided pool.py test case.
E.g: (before)
figuregen.horizontal_figure([ref_grid, comp_grid], width_cm=15., filename='siggraph/'+scene+'.pdf')

(after)
figuregen.horizontal_figure([comp_grid, ref_grid], width_cm=15., filename='siggraph/'+scene+'.pdf')

To be precise: The problem only appears while using the LaTex backend, html is producing the expected result. pptx was not tested.

Are you using the latest version? This should be fixed by bf848de4ed55108ead004d4fc217139f5b2373fb and better handled by b127e368899ed3e31cd412e0faee5b5c5a130cb1

With the recent version it works.
However, the line in setup.sh has to change from
python -m pip install --upgrade .\dist\figuregen-0.2.1-py3-none-any.whl

to
python -m pip install --upgrade ./dist/figuregen-0.2.2-py3-none-any.whl

to work within the linux environment. The backslash is not valid in bash and the python package has the version 0.2.2

Thanks for checking! Fixed in 69f84ae1f77c4173224a6d89c39f3c7f1decac91


option for changing extension

something like:
gbspack -b 6 -ext rel scene5_init.o scene6_init.o
to produce
scene5_init.rel and scene6_init.rel

Good idea, I've added this as --ext or -e in 5b1b67f080de01daa8cc1b98d752118d5d42bfd7


Copy hidden files in user's app.

This will copy the hidden files in a users repo to the /src dir.
This was preventing me from sending some files into the image.

Thanks!


[Monitor - Opentelemetry Exporter] Integration test libraries fail

Monitor - Opentelemetry Exporter nightly test runs are failing with:

Trace: [Internal Error]
at  (/mnt/vss/_work/1/s/common/tools/dev-tool/src/index.ts:10:11)
at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
Error: Failed calling dev-tool run test:vitest --no-test-proxy -- -c vitest.integration.config.ts.  Exit code: 255
##[error]PowerShell exited with code '1'.

For more details check here:
https://dev.azure.com/azure-sdk/internal/_build/results?buildId=4393687&view=results

Resolved by PR.


Safari hangs on config module with top navbar active

Similar issue in Firefox - it doesn't hang but slows down hugely after going into config module

Possibly connected: github.com/Akryum/vue-apollo/issues/164

Handled in #46


Text rendering performance low due to missing batching

Godot version:

Godot 3.1 compiled with 54988df9ce0227d9f933f6f82e2f9f1d35df28c0
OS/device including version:

Android 7.1.2
Qualcomm® Adreno™ 430 GPU  OpenGL ES 3.1
Issue description:

Text rendering harms the FPS on Android with GLES3.
In the screenshots below the same scene rendered with diffrent text content.
More text rendered less FPS.

Steps to reproduce:

Create a RichTextLabel and fill a long text as its text
Export and run it on Android with GLES3

Minimal reproduction project:

@akien-mga  I don't think this problem is only for Android. It is more obviously on Android as it can reach 60 FPS.
If I didn't limit the max FPS to 60 on my Linux desktop. The FPS can still down with the large text scene.

2D doesn't batch anything so each character is a draw call. It looks like you are working on an app so enabling low processor mode would make it only render when needed.

Related issues:
https://github.com/godotengine/godot/issues/5838
https://github.com/godotengine/godot/issues/11797

@Geequlim Would you have a test project to share for @dragmz to test their text batching WIP?

@akien-mga Of couse yes

@dragmz  You can download this project for testing
text_rendering.zip

Thanks @Geequlim
Here are my first results: (batching vs master FPS with given number of "Add More Text" clicks):
Empty: no change
100 "Add More Text" clicks: 175 vs 53 [~3.3]
200: 65 vs 28 [~2.3]
300: 35 vs 19 [~1.8]
400: 21 vs 14 [~1.5]
500: 14 vs 12 [~1.2]
That's on Intel GPU. I should be able to test on Android but that may take me a few days.

@akien-mga did we not merge a new batching afterwards?

No, #20965 was the "new" batching (the previous one was never merged, it was rejected).

Hold my beer! :sunglasses:
This is the result of my new batching (PR coming soon) with the text_rendering.zip test project posted above, in GLES 2 on desktop (similar gains on Android though):
I rigged it so that each press added 100 lots of the text instead of 1 (I'm guessing this is what dragmz was doing).
Godot 3.2
No clicks 1560 fps
100 clicks 20 fps
200 clicks 10 fps
300 clicks 7 fps
400 clicks 5 fps
Godot 3.2 + new batching
No clicks 2050 fps
100 clicks 525 fps
200 clicks  523 fps
300 clicks 524 fps
400 clicks 524 fps
As you can see, after the first click it became fill rate limited and thus further batches could be added for free. So at 400 clicks there was approx 100x speedup over normal Godot.
This is on Intel Core i5-7500T CPU
Intel HD Integrated Graphics 630 GPU

What are the steps to get this working for gles3?

Although the interesting thing is the rich text should probably cull away the text that isn't on screen, and if this were working, there would in theory be no performance drops after about the 8th click. Still kind of useful as a benchmark.

What are the steps to get this working for gles3? Although it is going away...

Looks pretty simple actually, that part of the renderer is pretty similar, almost a copy and paste job.

I and others who use 2d menus in 3d games on mobile gles3 would very appreciate this! I hope it isn't too hard to do in the same pr. Thanks.

Meanwhile You can use FastText asset. It is a little workaround I did for my projects and it works perfeclty on both Android and desktop. No noticeabily frame drops after stress trst of 1000 FastText label spawns.

Can now test my batching PR on Android, debug build, same test as before, on a Google Nexus 7 2012:
Godot 3.2 without batching
0: 60fps
100: 7fps
200: 3fps
300: 2fps
400: 1fps
Godot 3.2 with batching
0: 60fps
100: 37fps
200: 24fps
300: 17fps
400: 13fps
That's 5.3x speedup.

Good, but if it is an engine builtin batching, it should be better: look at this custom GDscript text batching video for Android

Can now test my batching PR on Android, debug build, same test as before, on a Google Nexus 7 2012:
400: 13fps
That's 5.3x speedup.

Good, but if it is an engine builtin text batching, my newbie opinion is that it could be improved: look at this custom GDscript text batching running on Android video
FastTextStresstest.zip

You are absolutely right, if you mean caching the text as an image. However this isn't what these batching PRs do, they are lower level and intended to accelerate all rects (and eventually all primitives), and letters are still ultimately drawn one at a time. They aren't specifically to address text rendering.
There could be an argument to add the caching you suggest in core (many GUI systems do this for text and other elements), you could propose it on godot proposals (if it is not there)? :blush:

They aren't specifically to address text rendering.

Oh well, I told you I am a newbie 😄 Infact I understood wrong 💭

This should have been closed when #37349 was merged.


Net.Core.App framework issue with OSX leg 3.1 p1 and p2

OSX results in smoke test error when it doesn't find a specific NetCoreApp version while running smoke tests. The was observed in 3.1 p1 and 3.1 p2.

Fixed by https://github.com/dotnet/source-build/pull/1363.


add Docker support

Here is a small PR to add Docker support. If this isn't useful to you, just close the PR.
Also, feel free to use our pre-built Docker image, just be aware that I cannot guarantee to always stay up-to-date: https://hub.docker.com/r/blockdaemon/stacks-dump

thank you @JonasPf this is not something I would use and could break unknowingly as I probably won't use it, but this looks simple enough to add

thank you @JonasPf this is not something I would use and could break unknowingly as I probably won't use it, but this looks simple enough to add


feature: Add support for subfolders

add support for subfolders and nested folders inside the scripts folder to organize scripts

I plan on adding something like this where you can have a folder that contains a main file and you can load scripts inside one another (with Lua's require function) when I finish moving the Lua API to use LuaJava instead of LuaJ. Unfortunately, I am away from home for a few months and won't be able to work on that for a little while.
However, I would happily accept a PR that implements a simpler version of it, which just loads scripts from the scripts folder recursively for the time being.

okey, thx

one doubt that came to my mind now, do you only plan to have support for lua scripts? or do you plan to add other languages like kotlin, java, javascript, ruby or rust or any other language?

one doubt that came to my mind now, do you only plan to have support for lua scripts? or do you plan to add other languages like kotlin, java, javascript, ruby or rust or any other language?
I say this because I am looking for a plugin of this style but for kotlin so I force myself to learn it since I make the scripts in kotlin and then I can make my own plugins or help plugins like this one.

For this project, I only plan on supporting Lua, but I was considering making another project that adds scripting with Kotlin.

the kotlin one interests me a lot because one of the plugins I had in mind to do when I know kotlin was to make one with support for kotlin scripts in both .kts and .kt and gradually add other languages, but for now I don't know much about kotlin and as I'm more focused on configuring my server I leave aside kotlin and programming, so I was interested in one with support for kotlin.

the kotlin one interests me a lot because one of the plugins I had in mind to do when I know kotlin was to make one with support for kotlin scripts in both .kts and .kt and gradually add other languages, but for now I don't know much about kotlin and as I'm more focused on configuring my server I leave aside kotlin and programming, so I was interested in one with support for kotlin.

Yeah, Kotlin scripting is still on my list of things to at least experiment with, so it may be something I do in the near future under a different project.
Adding multiple languages to the same plugin, I feel, would get messy and bloated very quickly.

well I will be happy to try your plugin, in fact my idea to add support for different languages is that you need somehow like an addon to add support for that language.


Remove unused code, optimize imports, fix Codacy issues

Coverage increased (+0.1%) to 87.964% when pulling ab78fb039b891b50ce3543cf6507c18c7fcbe359 on cascer1:master into 852b2ac3b4cbe0aa0c4a066a3f244d3f1f593c39 on Swagger2Markup:master.

Did you remove the DocumentationTest? The test is used by the AsciiDoc documentation.

Looks like it was removed indeed :o
Strange how I didn't get any exceptions when running the tests before submitting this PR. I'll add them again!

Coverage increased (+0.1%) to 87.964% when pulling aabc9f23970b0b4135f5b92175b4c64faff8a361 on cascer1:master into 852b2ac3b4cbe0aa0c4a066a3f244d3f1f593c39 on Swagger2Markup:master.

The DocTest veryfies that the examples, which are included into the documentation, are compileable.

Btw if you plan to contribute more and be part of the contributor team, I can invite you to our Slack channel.

Sure, that'd be cool! I have a few more things on my list that I'd like to implement.
Feel free to invite my profile email on github, without the +github suffix.


Add linter, fix lint issues and add ci github action

This PR includes the following changes:

Adds ESLint rules that extend @grafana/eslint-config

Introduces a ci github action to check that linting, type checks, and tests pass successfully

Fixes various linter issues, including:

Correcting spacing and adding newlines at the end of files
Replacing double quotes (") with single quotes (')
Fixing import statements
Adding .displayName to components that were missing it
Ensuring that component names always start with a capital letter
Removing duplicate types (in some cases, the same type was duplicated within a file)

Addresses some useEffect hooks that are missing dependencies. These issues have not been fixed, as they may require testing to avoid potential unintended side effects. However, TODO comments have been added for future review + // eslint-disable-next-line react-hooks/exhaustive-deps

Lastly, I noticed that in https://github.com/grafana/plugin-ui/pull/98/files we accidentally created a bug in  useEffect in Segment. As you can see [debouncedSegment] was at incorrect position and wasn't doing anything. So this PR brings it back to an original state.

useEffect(() => {
    onDebounce(debouncedSegment), [debouncedSegment]
});

Sorry about the oversight in the useEffect! 😓

No worries at all! I also haven't noticed it when I was doing PR review.


Can someone teach me how to generate 'input' file in the 'input_folder' ?

Hi, I'm a beginner in AFL.
After successfully running the RERS example (although failing at the Protocol example), I want to create my own experiment. However, I don't know how to create the 'input' file, which is essential for an experiment. Can someone teach me? Thanks a lot!

oops! Previously, I only do touch  input_folder/input，And got error
[-] Looks like there are no valid test cases in the input directory! The fuzzer
    needs one or more test case to start with - ideally, a small file under
    1 kB or so. The cases must be stored as regular files directly in the
    input directory.

[-] PROGRAM ABORT : No usable test cases in '/LTL-Fuzzer//experiment/Problem1/input_folder/'
         Location : read_testcases(), afl-fuzz.c:1808

But After execute code below, it works!
echo "" > input_folder/input'

However, I still want to know the way about generating 'input' in RERS example
Can someone teach me?

And how to know whether the LTL property has been violated


Support dark/light mode in Storybook

Hey, I just made a Pull Request!

Toggle between Backstage light and dark theme for the Storybook.
Closes https://github.com/spotify/backstage/issues/543
Screenshots
Dark mode

Light mode

The toggle button is on the top.

:heavy_check_mark: Checklist

[x] All tests are passing yarn test
[x] Screenshots attached (for UI changes)
[ ] Relevant documentation updated
[ ] Prettier run on changed files
[ ] Tests added for new functionality
[ ] Regression tests added for bug fixes

Let's use the deploy preview and test this. 🎉

@OrkoHunter thanks for your work on this! is it possible to make the background behind the components dark as well? if you could make the background color #181818, that would be amazing! also, do you know if it's possible to change the percentage type color to #FFFFFF?

Hi @katz95 !

is it possible to make the background behind the components dark as well?

Yes, I hope so. That must belong to Storybook color configuration. Let me find a way to make Storybook use Backstage theme for its background.

do you know if it's possible to change the percentage type color to #FFFFFF for accessibility?

Sure! I believe, this requires changes to the Progress card component.
The deploy preview is ready here. Can you take a look and let me know if there are more issues? Thank you.

I updated the CircleProgress component to use a textContrast color which is white (#FFF) for dark background, and black (#000) for white background.

@OrkoHunter NICE thank you!

@katz95 As with the color of Storybook background, I am afraid I don't have a quick fix. The method in this PR, wraps the components in Storybook and changes their colors. But the background color (white in the screenshots) is beyond these themes' scope.
I will create another issue to handle it.

@katz95 As with the color of Storybook background, I am afraid I don't have a quick fix. The method in this PR, wraps the components in Storybook and changes their colors. But the background color (white in the screenshots) is beyond these themes' scope.
I will create another issue to handle it.

Can we add a decorator that wraps every page with a themed background?

Can we add a decorator that wraps every page with a themed background?

Oh, interesting! I will give that a try. I'll note this as a Possible Implementation for the new issue. :)

Thanks for the review @Rugvip @katz95 @stefanalund :)


[Core] Update PyTorch to 1.0

https://github.com/pytorch/pytorch/releases/tag/v1.0.0 is out, need to update various operators and shape utilities, in particular wrt now supported broadcasting and 0 dim tensors.

Updated code to 1.0 via merging https://github.com/rlgraph/rlgraph/commit/5e26aefb68cd024c4cae320626c61fa21fcb76bf


De-underline hyperlink on hover-out #2

Testing Windows Terminal Preview 1.6.10412.0
De-underlining now works when the mouse moves away from the link while the window doesn't have the focus (#8925).
But we have a second de-underlining scenario that doesn't work properly...
Regardless of whether the window has the focus or not, hyperlinks are properly de-underlined only if the mouse moves over another character cell within the client area.
If the link is on the top row and the mouse moves higher than the link to the tabs/titlebar area, and/or if the link starts on the leftmost column and the mouse moves left to the margin and out of the window non-client area, or if the link reaches the rightmost column and the mouse moves right over the margin, scrollbar, etc..., the hyperlink stays hot.
Basically, it seems its hover-out handler is called only when the pointer moves over a cell not part of the hyperlink, but doesn't get called when the pointer moves directly to something else than the client area.

More accurately, the hover handler is only called when you over over a thing that is the active terminal area. ;P

you know, we should probably wire this up to a PointerExited handler in TermControl.

you know, we should probably wire this up to a PointerExited handler in TermControl.

Yep. Please assign it to me!


Choose a CSS framework

Bootstrap has been eliminated. They don't have sliders; if Fred wants an analog/continuous thumb scale, we will need sliders.
Foundation has sliders. I'm checking out jQuery Mobile UI now.

https://angular-ui.github.io/bootstrap/#/rating
This looks interesting, but it might not work as well with a touch interface.


interaction feature requests

A few requests (in the Mac OS X build)

consider making rotate option left-right, not option up-down
could both rotate and tilt be accessed via control, so rotate = control left-right and tilt = control up-down?
set a default tilt and rotation angle via the scene file
load scene via file via a URL in the File menu

Always happy to give the OSX demo app some ❤

consider making rotate option left-right, not option up-down

I can look into it, might be easy to try out.

could both rotate and tilt be accessed via control, so rotate = control left-right and tilt = control up-down?

Also easy to try out.

set a default tilt and rotation angle via the scene file

This wasn't included in the scene file syntax because Tangram JS doesn't support tilting and rotation, but we could add it and indicate in the docs that it's "ES-only".

load scene via file via a URL in the File menu

I've got a different solution to this problem in the works already. Stay tuned.

consider making rotate option left-right, not option up-down

Decided we can't really do this because it makes this action much more difficult when you aren't using a trackpad.

could both rotate and tilt be accessed via control, so rotate = control left-right and tilt = control up-down?

Tried this out and it's ... interesting. I'm not sure I like it because it becomes effectively impossible to apply a tilt without a rotation or vice versa.


⚠ Département GEGI website (prod) has degraded performance

In 577df3c, Département GEGI website (prod) (https://www.usherbrooke.ca/genie-electrique-informatique/) experienced degraded performance:

HTTP code: 200
Response time: 4308 ms

Resolved: Département GEGI website (prod) performance has improved in 147f162.


feat: add ConsoleMetricExporter

Which problem is this PR solving?
Adds a new metric exporter ConsoleMetricExporter to export or log the metrics to the console
Fixes #3036
Short description of the changes
Adds ConsoleMetricExporter
Type of change
Please delete options that are not relevant.

[ ] Bug fix (non-breaking change which fixes an issue)
[X] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

[ ] Add unit test has been added to verify the metrics are getting exporter to the console

Checklist:

[X] Followed the style guidelines of this project
[X] Unit tests have been added
[X] Documentation has been updated

You may need to remove the incomplete one defined in experimental/packages/opentelemetry-sdk-metrics-base/src/export/MetricExporter.ts and export the new one in experimental/packages/opentelemetry-sdk-metrics-base/src/index.ts.

Thank you! I have made your requested changes

@hectorhdzg @pichlermarc I think I have accommodated both your feedback on the PR :)


Function Calling

Description of the feature request:
A curl wrapper for function calling for the existing google-generativeai SDK for python. It would be a very good addition as people can continue using this library even for function calling feature. It's already available in api and can be used in vertex. It would be a crucial addition to compete to openai as this library api usage is free too.
What problem are you trying to solve with this feature?
No response
Any other information you'd like to share?
No response

Exactly, support this feature!

This feature is now part of v1beta version of the Gemini API.
See function_calling. Thanks!

https://github.com/google-gemini/cookbook/blob/main/quickstarts/rest/Function_calling_REST.ipynb
https://github.com/google-gemini/cookbook/blob/main/quickstarts/Function_calling.ipynb


The process cannot access the file when editing / saving package

Type (Bug)
NPE version: (3.15)
Installed from: (ClickOnce)
When saving a package after a new edit of a package that has been saved before I get the following.

This is working fine in 3.14 and lower.
Computer is Windows 10 x64.
Oh, I also downloaded and compiled the 3.15 solution and still receive the same error when running NuGetPackageExplorer.exe
When I downloaded and compiled the 3.14 solution it works fine.

Thanks. This is probably due to https://github.com/NuGetPackageExplorer/NuGetPackageExplorer/pull/87
Strange as I did tested saving a package.

It does work on save. It is when I close, reopen, and then try to save again that I get the error.
On Mon, Apr 25, 2016 at 10:04 AM -0700, "Julian Verdurmen"<EMAIL_ADDRESS>wrote:
Thanks. This is probably due to https://github.com/NuGetPackageExplorer/NuGetPackageExplorer/pull/87
Strange as I did tested saving a package.

You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub:
https://github.com/NuGetPackageExplorer/NuGetPackageExplorer/issues/97#issuecomment-214442738

Here are the steps I used to produce the problem.

Open NuGetPackageExplorer.application
Create a new package
Added DLL's to the lib\net40
Save the package as *.nupkg
Exit NuGetPackageExplorer.application
Open the *.nupkg file with NuGetPackageExplorer.application
Change the version
Click File -> Save
Get the Error

Thanks!

+1 on the repro steps from @ImGonaRot

After downgrading to 3.14 'save' is back working.

This is indeed introduced in 3.15, with https://github.com/NuGetPackageExplorer/NuGetPackageExplorer/pull/87
Too bad I had no time to fix this.


Add js-beautify package [skip ci]

reviewer: @amjith since I know you love the circle icons [:

Great addition.


ISPN-10689 RocksDB 6.2.2

https://issues.jboss.org/browse/ISPN-10689

Failures are unrelated

Thanks @tristantarrant


Unbreak the runtime, fix a wrong multiple line spanning

Hi!
Description
This bug has been introduced by 370a50c3e36b091dc2dc2f6cd9161477f3638b31
When running neofetch HEAD, i meet this:
./neofetch: line 3310: syntax error near unexpected token `newline'
./neofetch: line 3310: `"ruby"|"1"|"tmux"*|"systemd"|"sshd"*|"python"*|'

The spanning seems to miss a '\'

Thanks.


readme.rst is needed to install using pip from source

I tried installing from this library, but it needs .rst file.

I updated the setup.py to read the .md file. At some point the .rst file was changed to .md but the setup.py was never updated to reflect the change.


Errors when DEBUG enabled

Hi,
Using Arduino IDE - Compiling the MQTT Gateway with debug enabled (INFO or DEBUG) fails
\EnigmaIOT\src\GatewayAPI.cpp:122:73: error: the address of 'addr' will always evaluate as 'true' [-Werror=address]
DEBUG_INFO ("Node to process is %s", addr ? p->value ().c_str () : "NULL");
Hack - Commented out L122
EnigmaIOT\src\EnigmaIOTNode.cpp:2247:46: error: 'numBytes' was not declared in this scope
DEBUG_INFO ("%u bytes written. Total %u", numBytes, totalBytes);
#if DEBUG_LEVEL >= INFO
size_t numBytes =
#endif
set numBytes = 0; Moved #endif to end of block
compiled OK, running, going to add a node next
WiFi setup process is very nice
Geoffrey Mills

Thanks, I'll check it.

Your hack is correct.
I've corrected directive condition so that no hack is needed.
Fixed on https://github.com/gmag11/EnigmaIOT/commit/301518b982dc19ac5508e912838eb7a9b806925a


Fix the bug

Codecov Report

Merging #142 into master will not change coverage.
The diff coverage is 0%.

@@           Coverage Diff           @@
##           master     #142   +/-   ##
=======================================
  Coverage   94.37%   94.37%
=======================================
  Files          31       31
  Lines        1048     1048
  Branches       45       45
=======================================
  Hits          989      989
  Misses         49       49
  Partials       10       10

Impacted Files
Coverage Δ

datahub/core/exceptions.py
66.66% <ø> (ø)
:white_check_mark:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d9fe844...0438404. Read the comment docs.


Fix for using SuppressedOnly switch - this switch was non-functional due to a bug in the Engine

https://github.com/PowerShell/PSScriptAnalyzer/issues/320

Looks good to me.


iOS 11.4 Safari does not trigger pan when scroll without a break

before iOS 11
Each scroll without a break triggered pan events.
iOS 11
When scrolling without a break,
2nd and follow scrolls don't trigger pan events.

Yes this is a problem mentioned here as well:
https://stackoverflow.com/questions/51815182/hammerjs-in-safari-scroll-issue


fix(state): fix the ability for the site to remember your loaded game

Pull Request Test Coverage Report for Build<PHONE_NUMBER>6
Details

0 of 2 (0.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 3.149%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

src/state/store.js
0
2
0.0%

Totals

Change from base Build<PHONE_NUMBER>6:
0.0%

Covered Lines:
445

Relevant Lines:
16098

💛  - Coveralls


User impersonation in C# code - does it work when "Integrated Security=True"?

This is continuation of issue: https://github.com/dotnet/SqlClient/issues/432
Context: I am unable to fetch data from DB with Integrated Security=True, when I try to impersonate another user (using impersonation code as documented on MSDN https://docs.microsoft.com/en-us/dotnet/api/system.security.principal.windowsidentity.runimpersonated?view=dotnet-plat-ext-3.1)

There are 2 SQL servers: one which is directly connectable in my domain A, and another which is connectable when I impersonate as user in domain B.
When I runas SSMS or SQL Server plugin in VS Code, then I am able to connect to SQL server in domain B, as user of domain B. Connectivity is not an issue here.
When I try to impersonate as user from domain B in C# code, then SQL connection doesn't happen.

Now....
After spending a few months, I understand that WindowsIdentity.GetCurrent() is not returning the user that the code has been launched as. This is not your code's fault, but because you are using it (here: https://github.com/dotnet/SqlClient/blob/a9dfe480eff5dd344518eab5198654eff969fb6e/src/Microsoft.Data.SqlClient/netcore/src/Microsoft/Data/ProviderBase/DbConnectionPoolIdentity.Windows.cs#L23), this affects how you perceive who is using the SqlConnection.
To test, dump info of identity returned by WindowsIdentity.GetCurrent()
            using (WindowsIdentity identity = WindowsIdentity.GetCurrent())
            {
                SecurityIdentifier user = identity.User;
                bool isNetwork = user.IsWellKnown(WellKnownSidType.NetworkSid);
                string sidString = user.Value;
                Console.WriteLine($"User = {identity.Name}, Is Network = {isNetwork}, SID = {sidString}");
            }

This will dump same information when you program is executed from command line as is, and when executed as another user. I used a user from another domain, and executed the code using runas tool.
There was no authentication error, just in case you may be wondering.
I am puzzled because SSMS and SQL Server plugin of VS Code are able to connect and run queries under runas impersonation. Why is this C# code not able to find the right user being run as?
What am I missing, that above 2 applications have mastered?
Please help.

Hi @cnayan ,
I tested running a standalone application runas another userA which is different from the userB I login to my computer. The result I can see is that the identity.Name still shows the userB even though the application is actually runas userA.
SSMS uses System.Data.SqlClient internally and probably SQL Server plugin of VS Code does this too. From the System.Data.SqlClient code, I see the same WindowsIdentity.GetCurrent() is called:
https://referencesource.microsoft.com/#system.data/system/data/providerbase/DbConnectionPoolIdentity.cs,81
This piece of logic in System.Data.SqlClient and Microsoft.Data.SqlClient is the same. There could be some extra steps for identity handled by SSMS and VS Code plugin to cause the WindowsIdentity.GetCurrent() return the expected user when impersonation happens.
Thanks,
Karina

@karinazhou Thank you for responding!
I also have noticed that my query was not returning data on remote SQL server - not an authentication issue :-)
But here is what I have and found:

I don't have control over AD forest and trust relationships.
The domains A & B may not have trust relationship established.. I don't know how it impacts, as I'm not expert in this area.
LogonUser method did not work for me, except for "LOGON32_LOGON_NEW_CREDENTIALS" log on type. Thus, I also opted for log on provider as "LOGON32_PROVIDER_WINNT50". (To understand the relationship, check, PInvoke page, and MS Docs page).
This answer on Stackoverflow solved my problem completely. It helped me understand the missing pieces in the flow. I was mainly missing DuplicateToken call.
I enhanced code in that answer. It has been published here: User Impersonator

I have the functionality working. Sorry for the trouble!


FieldInfo calculation doesn't handle null

This code here:
https://github.com/bodong1987/Avalonia.PropertyGrid/blob/5753f10423dba995c37c0ca940971b2130e84a51/PropertyModels/ComponentModel/EnumDisplayNameAttribute.cs#L56
assumes that GetField will always return a non-null value. This is not always the case, for example in an enum that does not have a value of 0 in the enum definition, or in general when value has a value that is not defined in the enum.
I believe in this case, setting DisplayName to value.ToString(), similar to line 60, would be appropriate here.

thanks .

You didn't make any changes though?

In the next few days, I will submit a new version, which will enable nullable support, and I will do some special unit tests for the issue you raised. Please be patient and wait for a few days.

You didn't make any changes though?

In the next few days, I will submit a new version, which will enable nullable support, and I will do some special unit tests for the issue you raised. Please be patient and wait for a few days.

You didn't make any changes though?

public EnumValueWrapper(Enum value)
{
Debug.Assert(value != null);
        Value = value;

        var fieldInfo = value.GetType().GetField(value.ToString());

        var attr = fieldInfo?.GetCustomAttribute<EnumDisplayNameAttribute>();

        DisplayName = attr?.DisplayName ?? value.ToString();
    }


max file size option

sometimes we may would like to debug compiled js directory by editing build/index.js which can be really big. we don't really want to format this type of file. So is it possible to add an option prettier.maxFileSize?

Close as maybe I can use coc.preferences.maxFileSize


Demo project with working examples of using promises library.

Simple Demo project showing how to use promises, with chaining, and parallel examples.
Main will kick off all the examples while demo.bs is where the examples are. There is also an initResult class which is used as a callback that can be passed in with context and called provide feedback from promises.resolve() or reject().

Oh, I'm so sorry, I totally forgot about this PR (I'm working on too many things at the same time). I'm still open to adding this demo to the repo if you're still interested? In a recent PR we made a ./demos folder (that I just noticed was named incorrectly). If you move this stuff into that folder, I'm happy to merge this as-is.

It's quite all right, I'm back in the land of Roku and as I looked this one over I wasn't crazy about it. I'm working on a better one that I'll try to have ready in a week or so.

Oh, okay cool!


ElvUI / LS GLASS - Hard Game freeze

So i was running into issues trying to load into my alts today as i was setting up UI's and i came across the following condition.
If you have ElvUI and LS Glass enabled at the sametime, the game during loading just hard locks out.
My guess is ELVUI in its default state is fighting for Chat interface with LS Glass.
Easy fix is, first turn elvui, turn off chat, then turn LS Glass.
In a ideal world perhaps LS Glass has a check as it loads with ElvUI that after the game has finished loading, LS Glass warns the user at the start to disable ElvUI Chat and reload. Otherwise the game just completely hangs with a hard lock.

Hi! That's a weird one, I tested this stuff a few weeks ago on beta, and it's fine, like, you'd get a bunch of expected errors, but that's about it. Something must've changed between then and now. Oh well...
I'll release an update tomorrow, it's already almost midnight where I live, so I don't want to fatfinger anything 🤭

Cheers @ls- no major important, i was trying to figure out what on earth was going when i was trying to login to my other characters lol. so i was going addon by addon and then ran into elvui/lsglass combo.


Switch to PostCSS-only stack?

Bearing in mind the sourcemap issues in #27, and also the comment found here, is it worth looking at ditching gulp-sass and gulp-banner in favour of postcss packages like PreCSS and postcss-banner?

The postcss-banner change has been merged into master.
PreCSS isn't a direct replacement for Sass. Mixins are defined differently for instance, so you couldn't have a .(s)css source file which could switch between being parsed as Sass and being parsed with PostCSS.
To switch then, would mean that themes that use this toolkit would need to use "CSS with Sass-like" features, rather then Sass, and I don't think that's the right way to go right now.
I think we could probably still make more use of PostCSS, in terms of stylelinting and so on, but I'd say that replacing Sass is currently not the direction we want to take this.


Unique Jobs

Sidekiq (at least in the enterprise version) has the feature of unique jobs to avoid enqueuing the same job twice.
Does verk come with such a feature or is it planned? Couldn't find anything in the documentation.

Sorry for the super late reply!
No we don't have any sort of unique job processing, but it would be nice to have! I'm not sure which guarantees we would provide. For example, for how long should we guarantee uniqueness? etc

Hi @edgurgel,
This would be wonderful to have, sidekiq_unique_jobs for example have this customizable.
But the default should be until the job has finished. And then if it fails, there should be a delay set in config.


Fix typo in web-threat-protection.md

Docs Build status updates of commit 92ff274:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

microsoft-365/security/defender-endpoint/web-threat-protection.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel


[CSL-1931] Use forward links in getHeadersRange

This should speed up MsgBlock listener on the server side.
I've also fixed a recovery worker that wasn't triggered when we were not in recovery, though too late (it was a bug, apparently).

Let's merge it after CSL-1866 Benchmark block retrieval speed after CSL-1931

@pva701 I've addressed your changes.

@gromakovsky I've addressed things you've asked me to.


feat: add MatchPhraseQuery

add MatchPhraseQuery
see #49

@AlexVanderbist  Can this pr be merged?

Hi @summerKK, thanks for your contribution and sorry for losing track of this. Merging and tagging this now.


一些关于docker的问题

您好，我这边打包docker遇到一些问题。docker 已经可以正常打包了。但是在加载打包好的image验证的时候，会报错。
ValueError: 'ImportError: libSM.so.6: cannot open shared object file: No such file or directorylayer4_3' is not a valid scope name
。一下是我的dockerfile
基于镜像基础
FROM python:3.6
FROM tensorflow/tensorflow:1.14.0-gpu-py3
RUN sed -i s@/archive.ubuntu.com/@/mirrors.aliyun.com/@g /etc/apt/sources.list  &&
sed -i s@/security.ubuntu.com/@/mirrors.aliyun.com/@g /etc/apt/sources.list
设置代码文件夹工作目录 /app
WORKDIR /app
复制当前代码文件到容器中 /app
ADD . /app
RUN apt-get update
RUN apt-get install -y libsm6 libxext6 libxrender-dev
安装所需的包
RUN pip install --no-index --find-links=./pip_packages -r requirements.txt
RUN pip install  ./pip_packages/astropy-1.2.1-cp36-cp36m-linux_x86_64.whl
RUN pip install ./pip_packages/cffi-1.7.0-cp36-cp36m-linux_x86_64.whl
RUN pip install ./pip_packages/cryptography-1.5-cp36-cp36m-linux_x86_64.whl
RUN pip install ./pip_packages/numba-0.28.1-cp36-cp36m-linux_x86_64.whl
RUN pip install ./pip_packages/scikit_learn-0.17.1-cp36-cp36m-linux_x86_64.whl
RUN pip install ./pip_packages/lxml-3.6.4-cp36-cp36m-linux_x86_64.whl
Run app.py when the container launches
CMD ["sh", "predict.sh"]

Please list the building log.
It seems that some packages are not correctly installed.

1.14.0-gpu-py3: Pulling from tensorflow/tensorflow
Digest: sha256:e72e66b3dcb9c9e8f4e5703965ae1466b23fe8cad59e1c92c6e9fa58f8d81dc8
Status: Downloaded newer image for tensorflow/tensorflow:1.14.0-gpu-py3
---> a7a1861d2150
Step 2/14 : RUN sed -i s@/archive.ubuntu.com/@/mirrors.aliyun.com/@g /etc/apt/sources.list  &&     sed -i s@/security.ubuntu.com/@/mirrors.aliyun.com/@g /etc/apt/sources.list
---> Running in fae9918587ce
Removing intermediate container fae9918587ce
---> 82d0f498d4c2
Step 3/14 : WORKDIR /app
---> Running in 50833b8784a4
Removing intermediate container 50833b8784a4
---> 4532d3614e7b
Step 4/14 : ADD . /app
---> 0df42f315bfc
Step 5/14 : RUN apt-get update
---> Running in 7f4e38a8d729
Get:1 file:/var/nvinfer-runtime-trt-repo-5.0.2-ga-cuda10.0  InRelease
Ign:1 file:/var/nvinfer-runtime-trt-repo-5.0.2-ga-cuda10.0  InRelease
Get:2 file:/var/nvinfer-runtime-trt-repo-5.0.2-ga-cuda10.0  Release [574 B]
Get:2 file:/var/nvinfer-runtime-trt-repo-5.0.2-ga-cuda10.0  Release [574 B]
Get:3 http://mirrors.aliyun.com/ubuntu bionic InRelease [242 kB]
Get:5 http://mirrors.aliyun.com/ubuntu bionic-updates InRelease [88.7 kB]
Get:6 http://mirrors.aliyun.com/ubuntu bionic-backports InRelease [74.6 kB]
Get:8 http://mirrors.aliyun.com/ubuntu bionic-security InRelease [88.7 kB]
Get:10 http://mirrors.aliyun.com/ubuntu bionic/multiverse amd64 Packages [186 kB]
Get:11 http://mirrors.aliyun.com/ubuntu bionic/main amd64 Packages [1344 kB]
Ign:7 https://developer.download.nvidia.cn/compute/cuda/repos/ubuntu1804/x86_64  InRelease
Ign:9 https://developer.download.nvidia.cn/compute/machine-learning/repos/ubuntu1804/x86_64  InRelease
Get:12 https://developer.download.nvidia.cn/compute/cuda/repos/ubuntu1804/x86_64  Release [697 B]
Get:13 https://developer.download.nvidia.cn/compute/cuda/repos/ubuntu1804/x86_64  Release.gpg [836 B]
Get:14 https://developer.download.nvidia.cn/compute/machine-learning/repos/ubuntu1804/x86_64  Release [564 B]
Ign:15 https://developer.download.nvidia.cn/compute/cuda/repos/ubuntu1804/x86_64  Packages
Get:16 https://developer.download.nvidia.cn/compute/machine-learning/repos/ubuntu1804/x86_64  Release.gpg [833 B]
Ign:15 https://developer.download.nvidia.com/compute/cuda/repos/ubuntu1804/x86_64  Packages
Get:17 https://developer.download.nvidia.cn/compute/machine-learning/repos/ubuntu1804/x86_64  Packages [73.8 kB]
Get:15 https://developer.download.nvidia.cn/compute/cuda/repos/ubuntu1804/x86_64  Packages [695 kB]
Get:18 http://mirrors.aliyun.com/ubuntu bionic/restricted amd64 Packages [13.5 kB]
Get:19 http://mirrors.aliyun.com/ubuntu bionic/universe amd64 Packages [11.3 MB]
Get:20 http://mirrors.aliyun.com/ubuntu bionic-updates/multiverse amd64 Packages [39.5 kB]
Get:21 http://mirrors.aliyun.com/ubuntu bionic-updates/restricted amd64 Packages [537 kB]
Get:22 http://mirrors.aliyun.com/ubuntu bionic-updates/main amd64 Packages [2694 kB]
Get:23 http://mirrors.aliyun.com/ubuntu bionic-updates/universe amd64 Packages [2194 kB]
Get:24 http://mirrors.aliyun.com/ubuntu bionic-backports/main amd64 Packages [11.3 kB]
Get:25 http://mirrors.aliyun.com/ubuntu bionic-backports/universe amd64 Packages [11.4 kB]
Get:26 http://mirrors.aliyun.com/ubuntu bionic-security/restricted amd64 Packages [505 kB]
Get:27 http://mirrors.aliyun.com/ubuntu bionic-security/main amd64 Packages [2258 kB]
Get:28 http://mirrors.aliyun.com/ubuntu bionic-security/universe amd64 Packages [1420 kB]
Get:29 http://mirrors.aliyun.com/ubuntu bionic-security/multiverse amd64 Packages [26.7 kB]
Fetched 23.8 MB in 40s (600 kB/s)
Reading package lists...
Removing intermediate container 7f4e38a8d729
---> 2751dd329cbb
Step 6/14 : RUN apt-get install -y libsm6 libxext6 libxrender-dev
---> Running in 3affbe9a8313
Reading package lists...
Building dependency tree...
Reading state information...
The following additional packages will be installed:
libbsd0 libice6 libpthread-stubs0-dev libx11-6 libx11-data libx11-dev
libx11-doc libxau-dev libxau6 libxcb1 libxcb1-dev libxdmcp-dev libxdmcp6
libxrender1 x11-common x11proto-core-dev x11proto-dev xorg-sgml-doctools
xtrans-dev
Suggested packages:
libxcb-doc
The following NEW packages will be installed:
libbsd0 libice6 libpthread-stubs0-dev libsm6 libx11-6 libx11-data libx11-dev
libx11-doc libxau-dev libxau6 libxcb1 libxcb1-dev libxdmcp-dev libxdmcp6
libxext6 libxrender-dev libxrender1 x11-common x11proto-core-dev
x11proto-dev xorg-sgml-doctools xtrans-dev
0 upgraded, 22 newly installed, 0 to remove and 143 not upgraded.
Need to get 4104 kB of archives.
After this operation, 19.9 MB of additional disk space will be used.

(Reading database ... 15404 files and directories currently installed.)
Preparing to unpack .../00-libxau6_1%3a1.0.8-1ubuntu1_amd64.deb ...
Unpacking libxau6:amd64 (1:1.0.8-1ubuntu1) ...
Selecting previously unselected package libbsd0:amd64.
Preparing to unpack .../01-libbsd0_0.8.7-1ubuntu0.1_amd64.deb ...
Unpacking libbsd0:amd64 (0.8.7-1ubuntu0.1) ...
Selecting previously unselected package libxdmcp6:amd64.
Preparing to unpack .../02-libxdmcp6_1%3a1.1.2-3_amd64.deb ...
Unpacking libxdmcp6:amd64 (1:1.1.2-3) ...
Selecting previously unselected package libxcb1:amd64.
Preparing to unpack .../03-libxcb1_1.13-2~ubuntu18.04_amd64.deb ...
Unpacking libxcb1:amd64 (1.13-2~ubuntu18.04) ...
Selecting previously unselected package libx11-data.
Preparing to unpack .../04-libx11-data_2%3a1.6.4-3ubuntu0.4_all.deb ...
Unpacking libx11-data (2:1.6.4-3ubuntu0.4) ...
Selecting previously unselected package libx11-6:amd64.
Preparing to unpack .../05-libx11-6_2%3a1.6.4-3ubuntu0.4_amd64.deb ...
Unpacking libx11-6:amd64 (2:1.6.4-3ubuntu0.4) ...
Selecting previously unselected package libxext6:amd64.
Preparing to unpack .../06-libxext6_2%3a1.3.3-1_amd64.deb ...
Unpacking libxext6:amd64 (2:1.3.3-1) ...
Selecting previously unselected package x11-common.
Preparing to unpack .../07-x11-common_1%3a7.7+19ubuntu7.1_all.deb ...
dpkg-query: no packages found matching nux-tools
Unpacking x11-common (1:7.7+19ubuntu7.1) ...
Selecting previously unselected package libice6:amd64.
Preparing to unpack .../08-libice6_2%3a1.0.9-2_amd64.deb ...
Unpacking libice6:amd64 (2:1.0.9-2) ...
Selecting previously unselected package libsm6:amd64.
Preparing to unpack .../09-libsm6_2%3a1.2.2-1_amd64.deb ...
Unpacking libsm6:amd64 (2:1.2.2-1) ...
Selecting previously unselected package libpthread-stubs0-dev:amd64.
Preparing to unpack .../10-libpthread-stubs0-dev_0.3-4_amd64.deb ...
Unpacking libpthread-stubs0-dev:amd64 (0.3-4) ...
Selecting previously unselected package xorg-sgml-doctools.
Preparing to unpack .../11-xorg-sgml-doctools_1%3a1.11-1_all.deb ...
Unpacking xorg-sgml-doctools (1:1.11-1) ...
Selecting previously unselected package x11proto-dev.
Preparing to unpack .../12-x11proto-dev_2018.4-4_all.deb ...
Unpacking x11proto-dev (2018.4-4) ...
Selecting previously unselected package x11proto-core-dev.
Preparing to unpack .../13-x11proto-core-dev_2018.4-4_all.deb ...
Unpacking x11proto-core-dev (2018.4-4) ...
Selecting previously unselected package libxau-dev:amd64.
Preparing to unpack .../14-libxau-dev_1%3a1.0.8-1ubuntu1_amd64.deb ...
Unpacking libxau-dev:amd64 (1:1.0.8-1ubuntu1) ...
Selecting previously unselected package libxdmcp-dev:amd64.
Preparing to unpack .../15-libxdmcp-dev_1%3a1.1.2-3_amd64.deb ...
Unpacking libxdmcp-dev:amd64 (1:1.1.2-3) ...
Selecting previously unselected package xtrans-dev.
Preparing to unpack .../16-xtrans-dev_1.3.5-1_all.deb ...
Unpacking xtrans-dev (1.3.5-1) ...
Selecting previously unselected package libxcb1-dev:amd64.
Preparing to unpack .../17-libxcb1-dev_1.13-2~ubuntu18.04_amd64.deb ...
Unpacking libxcb1-dev:amd64 (1.13-2~ubuntu18.04) ...
Selecting previously unselected package libx11-dev:amd64.
Preparing to unpack .../18-libx11-dev_2%3a1.6.4-3ubuntu0.4_amd64.deb ...
Unpacking libx11-dev:amd64 (2:1.6.4-3ubuntu0.4) ...
Selecting previously unselected package libx11-doc.
Preparing to unpack .../19-libx11-doc_2%3a1.6.4-3ubuntu0.4_all.deb ...
Unpacking libx11-doc (2:1.6.4-3ubuntu0.4) ...
Selecting previously unselected package libxrender1:amd64.
Preparing to unpack .../20-libxrender1_1%3a0.9.10-1_amd64.deb ...
Unpacking libxrender1:amd64 (1:0.9.10-1) ...
Selecting previously unselected package libxrender-dev:amd64.
Preparing to unpack .../21-libxrender-dev_1%3a0.9.10-1_amd64.deb ...
Unpacking libxrender-dev:amd64 (1:0.9.10-1) ...
Setting up libpthread-stubs0-dev:amd64 (0.3-4) ...
Setting up xorg-sgml-doctools (1:1.11-1) ...
Setting up libbsd0:amd64 (0.8.7-1ubuntu0.1) ...
Setting up x11proto-dev (2018.4-4) ...
Setting up xtrans-dev (1.3.5-1) ...
Processing triggers for libc-bin (2.27-3ubuntu1) ...
Setting up libx11-doc (2:1.6.4-3ubuntu0.4) ...
Setting up libxdmcp6:amd64 (1:1.1.2-3) ...
Setting up x11-common (1:7.7+19ubuntu7.1) ...
debconf: unable to initialize frontend: Dialog
debconf: (TERM is not set, so the dialog frontend is not usable.)
debconf: falling back to frontend: Readline
update-rc.d: warning: start and stop actions are no longer supported; falling back to defaults
invoke-rc.d: could not determine current runlevel
invoke-rc.d: policy-rc.d denied execution of start.
Setting up libx11-data (2:1.6.4-3ubuntu0.4) ...
Setting up libxau6:amd64 (1:1.0.8-1ubuntu1) ...
Setting up x11proto-core-dev (2018.4-4) ...
Setting up libxau-dev:amd64 (1:1.0.8-1ubuntu1) ...
Setting up libxdmcp-dev:amd64 (1:1.1.2-3) ...
Setting up libice6:amd64 (2:1.0.9-2) ...
Setting up libxcb1:amd64 (1.13-2~ubuntu18.04) ...
Setting up libsm6:amd64 (2:1.2.2-1) ...
Setting up libx11-6:amd64 (2:1.6.4-3ubuntu0.4) ...
Setting up libxrender1:amd64 (1:0.9.10-1) ...
Setting up libxcb1-dev:amd64 (1.13-2~ubuntu18.04) ...
Setting up libx11-dev:amd64 (2:1.6.4-3ubuntu0.4) ...
Setting up libxext6:amd64 (2:1.3.3-1) ...
Setting up libxrender-dev:amd64 (1:0.9.10-1) ...
Processing triggers for libc-bin (2.27-3ubuntu1) ...
Removing intermediate container 3affbe9a8313
---> f73ecaeb3de4

Could you show more context about the error?

Traceback (most recent call last):
File "app.py", line 99, in
inferencewithsize()
File "app.py", line 49, in inferencewithsize
model_path="log\step1\categorical_focal_losss\model\Vnet3d.pd")
File "/app/Vnet_mutil/model_vnet3d.py", line 53, in init
self.numclass)
File "/app/Vnet_mutil/networks.py", line 129, in _create_conv_net
scope='ImportError: libSM.so.6: cannot open shared object file: No such file or directorylayer4_3')
File "/app/Vnet_mutil/networks.py", line 7, in conv_bn_relu_drop
with tf.name_scope(scope):
File "/usr/local/lib/python3.6/dist-packages/tensorflow/python/framework/ops.py", line 6513, in enter
return self._name_scope.enter()
File "/usr/lib/python3.6/contextlib.py", line 81, in enter
return next(self.gen)
File "/usr/local/lib/python3.6/dist-packages/tensorflow/python/framework/ops.py", line 4312, in name_scope
raise ValueError("'%s' is not a valid scope name" % name)
ValueError: 'ImportError: libSM.so.6: cannot open shared object file: No such file or directorylayer4_3' is not a valid scope name

what is your script of run the docker container?

docker contariner run --name deeplearn --rm -v $PWD/inputs -v $PWD/outputs/ deeplearn:latest /bin/bash/ -c "sh predict.sh"

It seems that your docker image is out of date. tensorflow:1.14.0-gpu-py3 is a very old version and there are no updates for this, can you please upgrade yo a later version and see if you face any issues.

您好，我想问下，现在我的docker在cpu环境下可以正常使用，推理正常，但是使用命令'--gpu'运行报错，无法在gpu环境运行，要怎么解决，错误如下：
Error response from daemon :could not select device driver "" with capabilities :  [[gpu]]

@Godthumb 没有安装nvidia docker
https://docs.nvidia.com/datacenter/cloud-native/container-toolkit/overview.html

thank u.the problem has been solved by install nvidia docker.


Are Database objects automatically closed when leaving the scope?

I know SQLiteCpp acts as a wrapper around sqlite3, which includes a function for closing the database. I am just curious if this library automatically does that for me, so I don't need to worry about any memory leaks.
Edit, I am trying to label this under the question label but my UI seems a bit bugged.

Yes exactly, the Database destructor will close the db automatically.


Debug Launch in Split Terminal Doesn't work

VS Code Version:  1.92.0  to 1.93.1
OS Version:  Windows 10

Hi, I noticed that since Ver. 1.92.0 launching the C++ Debugger in a Split-Terminal no longer works. It will just do the loading animation and give an  Error in the terminal. This happens with Microsoft's "C/C++ Tools" Extension with the GDB Debugger, or the CodeLLDB Debugger.
Steps to Reproduce:

Open Terminal and get a PowerShell Terminal
Click the Debug Launch button, and the Second Terminal appears
Split the Terminal so that the Normal PowerShell is on one side, and the Debug Launch Terminal is on the other
Stop the Debugger and Click the Debug Launch Button again, or click Restart Debugger after the Terminal is Split
The following Error occurs

Error:
Exception:
System.ArgumentOutOfRangeException: The value must be greater than or equal to zero and less than the
console's buffer size in that dimension.
Parameter name: left
Actual value was -1.
at System.Console.SetCursorPosition(Int32 left, Int32 top)
at Microsoft.PowerShell.Internal.VirtualTerminal.set_CursorLeft(Int32 value)
at Microsoft.PowerShell.PSConsoleReadLine.ReallyRender(RenderData renderData, String defaultColor)
at Microsoft.PowerShell.PSConsoleReadLine.ForceRender()
at Microsoft.PowerShell.PSConsoleReadLine.Insert(Char c)
at Microsoft.PowerShell.PSConsoleReadLine.SelfInsert(Nullable1 key, Object arg)    at Microsoft.PowerShell.PSConsoleReadLine.ProcessOneKey(ConsoleKeyInfo key, Dictionary2 dispatchTable,
Boolean ignoreIfNoAction, Object arg)
at Microsoft.PowerShell.PSConsoleReadLine.InputLoop()
at Microsoft.PowerShell.PSConsoleReadLine.ReadLine(Runspace runspace, EngineIntrinsics engineIntrinsics)

This issue was resolved after I installed PowerShell 7.4.6. The old stock version of PowerShell seems to have been the issue,  but now debugging in a split terminal works with no errors.

This issue was resolved after installing PowerShell 7.4.6.  The old-stock version of PowerShell seems to have been the problem, but now debugging in a split terminal works with no errors


slight adjustments to the settings window

settings window does not have a fixed height (less white-space)
brew path view is now locked to one line to avoid a jumping list
brew path: shownthe platform and then the path (light grey)
added spacing to the uninstall view
less spacing the the update view

###Some screenshots for reference:


Configure Pod Limit per node

Supports managing KubeletConfigs
Configures a pod limit of 110 per node using KubeletConfig

Checklist

[x] PR contains a single logical change (to build a better changelog).
[x] Update the documentation.
[x] Categorize the PR by setting a good title and adding one of the labels:
bug, enhancement, documentation, change, breaking, dependency
as they show up in the changelog.

I'm not sure about the label: Is this a feature that can be rolled out without problems or a breaking change because of possible impact?


Task - Citations by Source - enchansments

[x] Make taxon name with a hyperlink in bold (like in Browse nomenclature page)
[x] move invalid marker after the name
[ ] - optional. The invalid marker itself have different meaning on the Browse nomenclature page. I would say if you put something like "Name Author, Year - invalid" it would be better. But different marker will work as well
[x] add "is original" check-box for original citations (in all sections of the page.

@proceps As much as it is painful I'd suggest we start moving away from the checklist format for issues, and break out these issues one at a time.  More painful to submit, less painful to manage as we close them?  Will raise the isse on Gitter at some point.

Make taxon name with a hyperlink in bold (like in Browse nomenclature page)

@proceps not sure what you mean with this, you want to see the names in bold?

@jlpereira Yes, in Browse nomenclature page all TaxonNames are bold (the hyperlink), only the name string (not the author and year) but in the citation by Source name, TaxonName string is not bold. It should be the same formatting in both pages.

@proceps I don't see the bold there, just italics in some names

@proceps can you provide an screenshot to clarified this?

@jlpereira  It is strange. on the other computer they looked different to me. But when I see them now, it looks the same. Some thing with my vision ;)
Could you please just move the invalid marker after the name? Thank

Should be already moved


[asset] Include assets in input files

So they get propagated to depfiles as well.

@chaselatta @jonahwilliams

I think the failure is unrelated I triggered a re-run.

Thanks! Rebased onto the latest master.


IPROTO-103 Not possible to have @ProtoField of type List<byte[]>

https://issues.jboss.org/browse/IPROTO-103

Merged in master (4.3.x)


Substantially (~2x) speedup iteration time for folks working on LSP.

Do not link against LSP, Autogen, Proto & metrics in sorbet-orig.
Motivation
Faster iteration time.
I've tried to do it using smart macros similar to DEBUG_ONLY that we already have, but IMHO it looked worse.
While I hate the implementation of this PR, I think it's worth it as it speeds up folks who work outside of Sorbet core.
Test plan

See included automated tests.

Not 100% clear to me why this speeds up the build, but I'm happy to try it out and report problems if they arise.

why this speeds up the build

Sorbet-orig will no longer even compile LSP. Which means that if someone is working on LSP, their changes will not invalidate sorbet-orig and thus won't invalidate everything downstream including payload.


chore: Modify the file name and add an action.

Description

Modify the file name and add an action.
Related Issue (Optional)
N/A
Changes

Renamed build.yaml to build.yml.
modify build.yml
add ci.yml

Screenshots (Optional)

N/A
Additional Comments (Optional)

N/A

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Feature/Refactoring: Move PostTypes collection from .xaml to .cs on feed page (include it's localization)

Fixed by 53377e8 commit

Fixed by 53377e8 commit


Question on "doNotReplace" in "set" method

I'd like to use this to determine by a boolean whether the "set" operation should take effect.  Two questions:

this isn't documented, so i wanted to ask if this is an official feature, or not meant to be used
if "doNotReplace" evaluates to truthy, would it make sense this is first tested before traversing down?  or am i misunderstanding the usage of "doNotReplace"?

Thanks!

I see this boolean isn't quite what I'm looking for.  Closing.


Scripts that need to be in specific directories are pushded to the right place.

Description
Scripts that parsed PWD or BASH_SOURCE now use pushd with git rev-parse --show-toplevel and end with a popd.
A set -e was added to bin/run-dev to error early because that one has been prone to errors.
Tested by running the scripts from universal-applicantion-tool_0.0.1/app.
Checklist

[ ] Created tests which fail without the change (if possible)
[ ] Extended the README / documentation, if necessary

Issue(s)

Is this dependency on git bad?


Update to v8 12.1

Includes a new patch to the v8 build that ensures that continuation preserved data is always enabled in the bazel build.

Was going to comment here about new_git_repository being deprecated, but I was on mobile and the comment didn't actually get submitted since Github treats it as part of a not yet completed review... – I'll add this to a cleanup PR.


"org.wiremock" on Maven Central - Policy and Automation

Proposal
We would like to Mover WireMock core, extensions and other Java tools to a single location under org.wiremock on Maven Central. It would require some policies and automation so that all maintainers of components could publish there.
Structure

org.wiremock as a root. Core components like wiremock or wiremock-standalone will be under this root

org.wiremock.extensions - groupID for extensions
org.wiremock.tools - groupID for any associated developer tools (e.g. Maven plugins)
org.wiremock.integrations.{type} - groupID for integration libraries

{type}- A subgroup defining type of the integration, for example testcontainers, springboot or kotlin

Acceptance criteria

[x] Define structure of the org.wiremock group and subgroups
[x] Create Automation
[x] Move test components to the new engine: WireMock 3 Beta, WireMock TestContainers module, some extensions
[x] Setup Automation to help with publishing of releases from the wiremock GitHub org. These could be either GitHub Actions or some mirroring of GitHub Packages
[ ] Document releasing extensions in the extension developer guide

References

Docs: https://github.com/wiremock/community/blob/main/infra/maven-central.md
https://github.com/wiremock/wiremock/issues/2237
https://github.com/wiremock/wiremock-testcontainers-java/issues/56
https://github.com/wiremock/wiremock-state-extension/issues/71

Follow-ups:

https://github.com/wiremock/ecosystem/issues/19
Same for Maven?

Gradle Convention Plugin PoC: https://github.com/wiremock/gradle-wiremock-extension-plugins/pull/1

I talked to @tomakehurst as a maintainer, and indeed we are going to fix it. The problem is that the fix will not apply to the historical artifacts, so I guess those ones will stay there forever for old versions

I mostly completed it before changing the job, hence closing


Fixed #3590 infinite loop in parse_datetime

Change Summary

Related issue number

Checklist

[ ] Unit tests for the changes exist
[ ] Tests pass on CI and coverage remains at 100%
[ ] Documentation reflects the changes where applicable
[ ] changes/<pull request or issue id>-<github username>.md file added describing change
(see changes/README.md for details)
[ ] My PR is ready to review, please add a comment including the phrase "please review" to assign reviewers

@samuelcolvin this is a major vulnerability in bringing down sites like this...
I don't know how you'd want to go about testing against the infinite loop. I don't have much time. If anyone else can pick up on this would be great.


Extract an interface for ProtocolState

Also begin to convert this interface into a special purpose service. I'm working towards making it support an alternate mode for guest code that skips the Changes objects.

[ ] CHANGELOG.md's "Unreleased" section has been updated, if applicable.

Next steps:

[ ] Rename ProtocolBridge.Factory to WidgetSystem.Factory and have it produce a WidgetSystem.
[ ] Combine ProtocolBridge and ProtocolState, and name the resulting interface ProtocolBridge. The default implementation can be created by calling a ProtocolBridge() function.
[ ] Create a new implementation of ProtocolBridge that’s optimized for Kotlin/JS and that uses Zipline Dynamic Functions.

Yeah, I think I might best address some design / separation follow-ups after the last PR.


break all std::string and iostream dependencies

They're only for tests and error messages but still.

done!


Create working doc template for each chapter

Chapter template

Template created. Moving back to To Do until we have chapter titles.

@rebeccawoodbury this is great. I think this issue is done and we need to fold the template into the workflow. Do we want to include instructions in the doc, such as word count, recommendations, format, link to style guide? Seems like it would be easier for contributors to just work from the document and have all of that in one place.

@lukefretwell agree, I like the idea of including instructions in the doc


save 2nd point for arrow annotation

Fortunately, TID300 at dcmjs, supports 2nd point in Point class.
https://github.com/dcmjs-org/dcmjs/blob/master/src/utilities/TID300/Point.js
To support ArrowAnnotate at OHiF, OHIF code should be also modified (extensions/cornerstone-dicom-sr/src/tools/DICOMSRDIsplayTool.ts)

@sedghi


Update NugetWrapper.cmd to download nuget.exe

The share we were using internally just disappeared. I don't want to rely on everyone having a specific version of nuget.exe on their path so I think this script still has value, but it should grab nuget from a more stable location.
I'm just downloading from nuget.org for now -- I assume this is a pretty stable url?

But we can package the nuget package without Nuget.exe when we use the new format csproj file.

@lindexi I would definitely love to not depend on nuget.exe -- do you have more specific guidance about how to use this? Currently we programmatically generate a nuspec and the nupkg contents and then invoke nuget.exe, it isn't simply packaging up the outputs of a csproj (see build-nupkg.ps1).
I need to check this in to unblock our build but would be interested to see if a csproj could help simplify our tooling.

@jevansaks In VisualStudio 2017, we can pack the package with the new format csproj file. We can rebuild and pack a package when setting the GeneratePackageOnBuild property. We can also use the nuspec file in a complex project. We can use NuspecFile property to set the nuspec file path. See https://docs.microsoft.com/en-us/nuget/reference/msbuild-targets#pack-target
Create and publish a .NET Standard package using Visual Studio on Windows | Microsoft Docs


doc.prototype

review what is being prototyped and not. feels like most things may be best not prototyped and/or need to review use of Object.keys, hasOwnProperty

done. one can always use namespaces


issue with fire style

~ ❯❯❯ replem sparkly
Installed into REPL context:
 -<EMAIL_ADDRESS>as sparkly
> sparkly([0, 0, 0], { style: 'fire' })
'NaN\u001b[0mNaN\u001b[0mNaN\u001b[0m'
> sparkly([0, 1, 0], { style: 'fire' })
'\u001b[38;5;230m▁\u001b[0m\u001b[38;5;196m█\u001b[0m\u001b[38;5;230m▁\u001b[0m'
> sparkly([0, 0, 0])
''

output with all zeroes is weird

It seems this https://github.com/sindresorhus/sparkly/blob/233d6bf50160c0673435cab566434021e2872188/index.js#L28 returns NaN because it tries to divide 0 by 0. I don't have the time to look into a solution right now, but PR welcome :)

What is the expected output if all are set to 0? All low ticks or just nothing?

@SamVerschueren Lowest tick. Nothing means it's a gap caused by non-number value. See readme examples.


Fix destination query string for multiple optional args

I have two optional arguments in the destination and route string for it is generated wrong:
object EventDetailScreenDestination : TypedDestination<EventDetailArgsDelegate> {

    override fun invoke(navArgs: EventDetailArgsDelegate): Direction = with(navArgs) {
        invoke(eventId, date)
    }

    operator fun invoke(
		eventId: String? = null,
		date: LocalDate? = null,
    ): Direction {
        return object : Direction {
            override val route = "$baseRoute" +
					"?eventId=${DestinationsStringNavType.serializeValue("eventId", eventId)}" +
					"?date=${localDateNavType.serializeValue(date)}"
        }
    }

    @get:RestrictTo(RestrictTo.Scope.SUBCLASSES)
    override val baseRoute = "event"

    override val route = "$baseRoute?eventId={eventId}?date={date}"

    ...
}

There should be & before date arg.

Hey @Mordred! 👋
Thanks for this.
Let me ask you though: did you have an actual bug with this generated Destination? It seems like both ways work, right?

@raamcosta Yes, it is bug. I had notification with deep link and eventId had wrong value, because it wasn't correctly parsed.

Hmm and you are sure that this was the reason? I'm surprised because I have plenty of projects and never had an issue with using always "?" to separate all optional arguments.
How were you creating the deep link?

Ok regardless, using "&" is probably more correct, so I'm gonna accept this. Let me know if this indeed fixed your issue 🙂
Again, thanks for the PR.

Whole navigation is using URLs so yeah & is more correct 😄.
It fixed my issue, because I'm currently using my forked code.
Any idea when you publish new version so I can switch back?

This weekend. I’m trying to do couple other changes first.


fix: semantic-release require node >= 18

See https://github.com/semantic-release/semantic-release/blob/master/docs/support/node-version.md for more details and solutions.

Thanks for the fix


Support for tern-guess-types

https://github.com/angelozerr/tern-guess-types is helpfull when completion is applied. I use it inside tern.java. It should be cool if you could integrate it with atom. Thanks!

Sorry for the late reply. Pretty busy at the moment.
I will have a look at this in the near future and coming back to you, if there are any questions. :)

Cool! I have the intention to improve it again to provide custom guess like showing list of node modules when require is applyed.
Any feedback are welcome:)


playing with powerbi.session.userInfo in CustomVisual

Hi guys,
I've been doing some prototyping with custom visuals and wanting to detect the "current user" - which is available in powerbi.session.userInfo at the top frame level.  I only need to differentiate who is currently using the custom visual, e.g. powerbi.session.userInfo.name<EMAIL_ADDRESS>This disappears in the sandbox frame.  powerbi.session exists but no userInfo.  The utility methods powerbi.session.UserInfoUtils.getFullName etc exists but without context doesn't work.
So I'm just curious if there's a way to read the current user in the PowerBI service that's the officially supported way.  I feel powerbi.session.userInfo would be sufficient, but if I need to do a cross-frame message I'm ok with that too.
I tried also using formula USERNAME() but that's really rubbish on PowerBI Service.  (works well on desktop though).

@johnnliu I'm just curious - why do you need user name in your visual?

There are several scenarios that we are prototyping, but they all pretty much tie around knowing the current user to then do some simple post requests.

PowerBI reports has numerous projects - have a custom visual that allows different managers to select which projects they want to highlight - we store these separately in docdb, and the custom visual brings that back (via shiny Azure Functions).  Knowing who is the current user is useful for both setting the "favourite" and retrieving them.  - note, we are not looking for a row-level user security implemented via a visual - I expect PowerBI to support that in due time, we're just after a "return to your previous highlights".

An alternative is to perhaps store a cookie, or map the user back to their IP address.

I guess if we can see the user's name, we'd have analytics on when did they access the report.

Allow users to apply tags against data entry, again, we store these elsewhere via a separate post request.

We have this requirement to personalize the display for users as well

Information about current user should not be used by custom visuals. As alternative you can use some additional field with list of all users in your dataset and allow users to select themselves from it.