Setup doesn't work with dom-module

Hey @JanMiksovsky, I couldn't get this setup to actually work with Polymer's registration system. Namely, it doesn't respect the dom-module for the element or create shady dom.
<dom-module id="my-element">
  <template>
    my element
  </template>
</dom-module>

class PolymerElement extends Polymer.Class({}) {
  get is() { return 'my-element'; }
}

class MyElement extends PolymerElement {
  created() {
    this.textContent = "Hello, " + this.textContent + "!";
  }
}

document.registerElement('my-element', MyElement);

<my-element>eric</my-element>

I'd just done this as a quick experiment, mostly see if Polymer would play at all nice with ES6. At the time, Polymer 0.8 was still in the works, so I didn't try to get this to work with  and Shady DOM.
As originally written, this experiment used document.registerElement() on its own, but Polymer appears does a bunch of its own registration work. That registration needs to be performed per-class. As originally written, only a single anonymous class, Polymer.Class({}), was getting registered.
Partial progress: I can't claim to really understand the complexities of Polymer's internals. That said, I've just checked in a fix (read: total hack) that manually invokes a function called registerCallback(). This in turn invokes _registerFeatures(), which looks like it forces some preparation of the element template as desired. I've updated the demo so that the sample element's template is now provided via a <dom-module>. That's cool.
This doesn't use Shadow DOM (or Shady DOM), however. More hackery might be able to get that to work, but for today this as far as I can push it. If you're interested in this, let me know. I think even hacky ES6 support for Polymer is kind of cool, but going further will probably involve some advice from the Polymer folks.

Shoot... the dom-module fix works in Polymer 0.8, but when I upgrade the bower.json to use Polymer 1.0, there's a regression. Sigh.

Thanks @JanMiksovsky. I've been playing around with classes a bit. I've come up with 3 different ways: http://jsbin.com/zifituqaxu/edit?html,output. Yours works for me as well in 1.0.
It would be nice if we could get rid of the registration call in each of those. I'll poke around a bit more and inquire with the core team. Thanks for your help!

Glad it works for you. I had an issue with Polymer 1.x (Polymer 1.0.9), but just checked in a fix. Things now mostly work as I expect.
One issue I'm concerned about is class identity. In two of the approaches you show (yours and Scott's), the top-level class doesn't look like it's going to be end up as the actual class of the resulting elements. That is, I suspect that the following:
let elt = document.createElement('my-element');
console.log(elt instanceof MyElement);

will be false for approaches that use pass MyElement.prototype to the Polymer function. The approach I've been pursuing should ensure that instanceof tests pass as expected.
In any event, I'm interested in see where ES6 class support goes. Please keep me looped in.

Hi, thanks for this examples. What I came up with is this. I used Babel with es7.decorators enabled.
/**
 * Component annotation to extend from Polymer base class
 *
 * @decorator
 * @param {string} name - WebComponent name
 * @returns {Function} decorator
 */
function Component(name) {
    if(!name) {
        throw new TypeError('Component name is required');
    }
    if(typeof name !== 'string') {
        throw new TypeError('Component name must be a string');
    }
    if(name.indexOf('-') === -1) {
        throw new TypeError('Component name must have at least one dash "-" character')
    }
    return function decorator(target) {
        Object.defineProperty(target.prototype, 'is', {
            value: name,
            writable: false,
            enumerable: true,
            configurable: false
        });
        Polymer(target.prototype);
    };
}

@Component('my-component')
class MyComponent {
    get properties() {
        return {
            title: String
        }
    }
}

It is basically @ebidel 's way of extending the actual Polymer class with Polymer(MyElement.prototype). Using Es7 decorators I don't have to think about registering the component manually. When I declare my component template I include the following script using System.JS to load the component:
<dom-module id="my-component">
    <template>
        {{title}}
    </template>

</dom-module>

What are your thoughts on this approach?

I think using the Polymer function to register the element is safer. But using 'extends' makes it cleaner. Any new recommendations ?

@myuseringithub No, sorry. Using Polymer 1.0 with ES6 is still a pretty experimental thing. That said, in the past year the browsers have made huge strides towards full ES6 compatibility, so I think it's reasonable to expect the Polymer team to directly address this as a framework feature in a future release. Their next venue is the Polymer Summit this coming October — I'd look for them to share plans at that point.


Keras with TF on a multi GPU machine

I am training a mnist model using keras (2.1.5) with tensorflow (1.6) as backend. I am using g3.8xlarge which has two Tesla M60 GPUs with around 7613 MB of GPU memory. When I start training the model, I can see that both the GPUs are getting used. Below is the output of nvidia-smi command -
+-----------------------------------------------------------------------------+
| NVIDIA-SMI 384.81                 Driver Version: 384.81                    |
|-------------------------------+----------------------+----------------------+
| GPU  Name        Persistence-M| Bus-Id        Disp.A | Volatile Uncorr. ECC |
| Fan  Temp  Perf  Pwr:Usage/Cap|         Memory-Usage | GPU-Util  Compute M. |
|===============================+======================+======================|
|   0  Tesla M60           On   | 00000000:00:1D.0 Off |                    0 |
| N/A   62C    P0    86W / 150W |   7353MiB /  7613MiB |     74%      Default |
+-------------------------------+----------------------+----------------------+
|   1  Tesla M60           On   | 00000000:00:1E.0 Off |                    0 |
| N/A   49C    P0    79W / 150W |   7353MiB /  7613MiB |     67%      Default |
+-------------------------------+----------------------+----------------------+

+-----------------------------------------------------------------------------+
| Processes:                                                       GPU Memory |
|  GPU       PID   Type   Process name                             Usage      |
|=============================================================================|
|    0     10772      C   ...a-4.2.0-py-3.5.3-dl-gpu-full/bin/python  7342MiB |
|    1     10772      C   ...a-4.2.0-py-3.5.3-dl-gpu-full/bin/python  7342MiB |
+-----------------------------------------------------------------------------+

I have a couple of questions -

On a multi GPU node, how is the data distributed among the GPUs?

I haven't written any code for distributed training (specifying cluster spec etc.), still my training is distributed since it's happening on 2 GPUs. Is it using the parameter server architecture to compute final gradients?

If it's not using parameter server architecture, how are the two GPU communicating with each other?

I have also seen cases where during the entire model training, the volatile GPU utilisation stays at 0% for one GPU and remains as high as 84% for the other one. The memory utilization is almost same for both the GPUs. Are there cases when only one GPU is used to train and the other one just keeps the data in memory?

This might not be the right forum to ask this but any documentation or examples would be really helpful. Thanks!

Tensorflow always tries to allocate all gpu memory of every available machine. You can limit the visibile device by setting the env variable CUDA_VISIBLE_DEVICES. Also, it's a good idea to use allow growth in your tensorflow session(keras will relato to it automatically)
config = tf.ConfigProto()
config.gpu_options.allow_growth = True
sess = tf.Session(config=config)

This way will use only as much gpu memory as needed.
What I don't understand is why your second GPU is working. I only know the case, where tensorflow occupy every gpu's memory but only calculate on the first one


Initial version of Helm chart

The initial commit contains the result of helm create only.
I'll add several commits before merging so that it can be a foundation for further collaboration.
NOTES:

diff --unified <(helm template --include-crds actions-runner-controller charts/actions-runner-controller -n actions-runner-system | kubectl sort-manifests -f -) <(cat release/actions-runner-controller.yaml | kubectl sort-manifests -f -) | less is handy to check for differences between the official manifests and the helm chart template output.
You can run ACCEPTANCE_TEST_DEPLOYMENT_TOOL=helm make acceptance to run the same set of tests we run against the official manifests, but with the chart.

Ref #184
Inspired by #91
Related #61

Whoa, it seems working
❯ helm list -n actions-runner-system
NAME                            NAMESPACE               REVISION        UPDATED                                    STATUS          CHART                           APP VERSION
actions-runner-controller       actions-runner-system   1               2020-11-14 21:48:58.773353 +0900 JST       deployed        actions-runner-controller-0.1.0 0.11.2

❯ k -n actions-runner-system get deploy
NAME                        READY   UP-TO-DATE   AVAILABLE   AGE
actions-runner-controller   1/1     1            1           3m37s

❯ k get runnerdeployment
NAME                   DESIRED   CURRENT   READY
example-runnerdeploy   1

❯ k get po
NAME                               READY   STATUS    RESTARTS   AGE
example-runnerdeploy-ndr5s-rrwwh   2/2     Running   0          2m59s

Whoa, it seems working
❯ helm list -n actions-runner-system
NAME                            NAMESPACE               REVISION        UPDATED                                    STATUS          CHART                           APP VERSION
actions-runner-controller       actions-runner-system   1               2020-11-14 21:48:58.773353 +0900 JST       deployed        actions-runner-controller-0.1.0 0.11.2

❯ k -n actions-runner-system get deploy
NAME                        READY   UP-TO-DATE   AVAILABLE   AGE
actions-runner-controller   1/1     1            1           3m37s

❯ k get runnerdeployment
NAME                   DESIRED   CURRENT   READY
example-runnerdeploy   1

❯ k get po
NAME                               READY   STATUS    RESTARTS   AGE
example-runnerdeploy-ndr5s-rrwwh   2/2     Running   0          2m59s

Can I create the runner deployment from helm chart?

Nope. I believe it's a standard helm chart convention to separate k8s operator deployment and custom resource deployment. You'd need to create your own chart, or just use incubator/raw to deploy arbitrary resources including RunnerDeployment, or just use kubectl for simple resources.

Sorry but I'm locking this issue to prevent random questions to outdated pull requests and issues. It happens often and it's a maintenance nightmare from maintainer's perspective!
FYI, there's another issue that asked exactly what you want, and I think I've replied with a similar answer there. See that issue for more context.

@ClenchPaign I spent 10 minutes searching for the issue but I couldn't find one.
Perhaps it was just that I was asked about a chart for RunnerDeployments in some random issue unrelated to the chart? 🤔
Anyway, I'd suggest you create a dedicated issue for that, so that we could at least enhance our chart README to note that it doesn't support managing RunnerDeployments. Or even better ,anyone from the community would chime-in and introduce another chart for managing RunnerDeployments!
Thanks in advance for your cooperation.


Move spdhg to contrib

I suggest we move the implementation of spdhg, which is currently self contained into a contrib directory. This will require also that we decide on how to proceed on ordered subset algorithms #124

This is a good idea, please go ahead with moving to contrib now, and we'll
address ordered subset soon.
On Wed, 17 Apr 2019 at 10:45, Edoardo Pasca<EMAIL_ADDRESS>wrote:

I suggest we move the implementation of spdhg, which is currently self
contained into a contrib directory. This will require also that we decide
on how to proceed on ordered subset algorithms #124
https://github.com/vais-ral/CCPi-Framework/issues/124
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/vais-ral/CCPi-Framework/issues/251, or mute the
thread
https://github.com/notifications/unsubscribe-auth/AJg5COuCFub6tnPcGbZNI-1Oi3hRn5mWks5vhu0dgaJpZM4c0o2-
.


[feat] check if model runs before launching full workflow

Pipeline should not run if data/model/encoders do not run for one epoch, rather, it should throw out an error

Python code done in #108
Waiting for nextflow module to be added


Support both efiInstallAsRemovable and canTouchEfiVariables

Issue description
Suppose you set:
boot.loader.grub.efiInstallAsRemovable = true;
boot.loader.efi.canTouchEfiVariables = true;

You'll get the following error when you run nixos-rebuild:
Failed assertions:
- If you wish to to use boot.loader.grub.efiInstallAsRemovable, then turn off boot.loader.efi.canTouchEfiVariables

However, it's often desirable to both:

Install grub to /boot/efi/EFI/NixOS-boot-efi, setting a EFI boot entry to point to the grubx64.efi therein, and
Install grub directly to /boot/efi/EFI/Boot/bootx64.efi.

Why do both? Because, between hardware quite often being stupid (I'm looking at you, MacBook), and other distros quite often trying to clobber EFI so they're guaranteed to boot instead of e.g. NixOS, it's nice to take a shotgun approach in attempts to ensure NixOS's boot loader takes precedence over all other OSes.
Currently I manually fiddle with my config, flipping the true to false where appropriate (and vice versa), and run nixos-rebuild switch --install-bootloader twice. That's kinda silly, though, when I should be able to specify in my configuration that I want both effects and have nixos-rebuild do the right thing.
The simplest solution I can think of to support this is to allow for users to specify:
boot.loader.grub.efiInstallAsRemovable = true;
boot.loader.efi.canTouchEfiVariables = true;

which would result in the grub installation running twice, once "as removable", and the second not so.
I'll assign this to myself, as I have an interest in seeing this implemented, and I suppose it can't be that difficult to support; however, I don't know when I'll be able to get around to it, so if someone wants to beat me to the punch, go for it.

Still interested in seeing this implemented!

I'm interested in seeing this implemented.

Still interested in seeing this implemented!


workflows: disable rollback on CLI install

By default, cilium install tries to rollback the installation if something goes wrong. We explicitly disable this behaviour in CI as this forbids us to retrieve Cilium's state if something goes wrong at install time.

Link to successful run of workflow changes: https://github.com/cilium/cilium/actions/runs/1546043233/attempts/3
Link to failing run where we see the "no rollback" behaviour in action: https://github.com/cilium/cilium/actions/runs/1546043233/attempts/2
CI passed, removing temporary commit.


[QUESTIONS]: add new nodes in layout graph

Is there a way to add nodes and edges programmatically to a graph when using layout?
According to the documentation a new graph is built by
const newModel = gridLayout.layout(model)

graph.fromJSON(newModel)

However, call graph.addNode() method will not update the graph.
As I understand it, I need to reassemble the nodes and edges into a variable and render graph again?
const newModel = gridLayout.layout(modelUpdated)

graph.fromJSON(newModel)

https://codesandbox.io/s/boring-feather-xxzku?file=/index.js
Probably need to clarify, graph is not updated according to the layout after adding a new node and edge.

https://codesandbox.io/s/boring-feather-xxzku?file=/index.js
Probably need to clarify, graph is not updated according to the layout after adding a new node and edge.

After adding nodes, you need to modify the data and then layout it

After adding nodes, you need to modify the data and then layout it

I.e., reassemble the nodes and edges into a variable and render graph again?
const newModel = gridLayout.layout(modelUpdated)
graph.fromJSON(newModel)

I thought there was something like this method graph.layoutRefresh()

After adding nodes, you need to modify the data and then layout it

I.e., reassemble the nodes and edges into a variable and render graph again?
const newModel = gridLayout.layout(modelUpdated)
graph.fromJSON(newModel)

I thought there was something like this method graph.layoutRefresh() after add new node by graph.addNode()

This can do by your self, using the same logic as you said above.

That's what I do, it's no big deal. I just thought there was another way to update the layout after adding new nodes and edges. Thanks for the clarification.


Question: what is the minimum version of OSTicket required?

What is the minimum version of OSTicket required for the plugin to work?
Thanks in advance.

It should work from version 1.17

@stefanclark thanks!


Backdoor detection + Stop themes flashings

Stops themes flashing (idk if its been fixed)
Added alerts to people using premium Adonis
Anti backdoor system

instead of simply stating PremiumAdonisID as a single variable, make it a table so we can add further malicous models at a later date

Most of this is unnecessary and can be bypassed by the malware maintainer using a custom module instead of lazily calling the current one. I added a warning if PremiumID is found in data but I expect it to be bypassed pretty quickly considering they don't even use it in their require call (and can just remove it, no reason for it to be there at all)


Pluggable search / index

I am thinking if this could be used with LokiJS, which provide different filtering and sorting option.

redux-search only ships with one search library, js-worker-search. All of the interactions with this library though are encapsulated within a single adapter, SearchApi. This adapter exposes the search interface as an observable. You can provide your own, custom SearchApi object so long as it implements the same interface.
The docs actually mention this although they suggest it should only be done for testing purposes. You can see the source code here though where the override could happen.

I'm going to close this issue since what you've requested is already possible given the route I mentioned above. Feel free to ask more questions here though if what I've suggested is not clear.

I have read about the SearchApi, but still not sure if LokiJS could take advantage by implementing the interface, as LokiJS keeps its own index.
Anyway, thank you for your help. I am going to implement the search using LokiJS directly.

You would just need to provide an adapter that sits between LokiJS and redux-search that met the redux-search interface and passed requests through to one or more LokiJS instances. (This is similar to what redux-search does for js-worker-search.)


Improve support for long file names

Sometimes I emit messages from files with long names, and then the log won't be properly aligned anymore. This will look something like this:
2016-09-29 11:51:16.879 (   2.985s) [main thread     ]really_long_source_file_name.cpp:144      0| Some message that is not properly aligned
2016-09-29 11:51:16.879 (   2.985s) [main thread     ]      short.hpp:202              0| Some other message.

Since this is a static property of the project, it would be nice to have a macro to define to control the padding. If you can point me to the relevant part of the source code, I can also have a look at it.

Just update loguru and #define LOGURU_FILENAME_WIDTH 32 before you include loguru.hpp


Option to turn off auto gaining?

Hi Tabahi, your work here is super cool. So great to see a spectral analyzer (and more) running fully inside of a browser.
I was wondering if you considered adding an option to disable auto-gaining? Seems like highest peak dictates the overall gain for the whole audio segment, which is less than ideal for things like singing analysis, because further into the segment it looks as if the volume is going down.

Hi, Thanks for the interest. The auto-gaining only affects the noise-gate and the pixel brightness during plotting. The end features have the raw power as it is (not even converted to DB, something like >10e5). In segmentor.js, the ratio of the pixel power to the context_maximum is used to determine the noise hysteresis. Anything below, local_minimum is filtered out. You can change these two variables to static simply by assigning a static value in function amplitude_control(h_peak_amp) in segmentor.js.
For higher output levels (>Mel-spectrum):
https://github.com/tabahi/WebSpeechAnalyzer/blob/82bce17f3372cc669e9d931abc8daad2ecd57947/app_assets/src/FormantAnalyzer/segmentor.js#L414
function amplitude_control(h_peak_amp)
{
    //h_peak_amp is the peak amplitude of the latest frame.
    context_maximum = 1000000;
    local_minimum = 10;
}

For lower output levels (<=Mel-spectrum):
https://github.com/tabahi/WebSpeechAnalyzer/blob/82bce17f3372cc669e9d931abc8daad2ecd57947/app_assets/src/FormantAnalyzer/segmentor.js#L596
Currently, there are no options on the interface to set the gain. In an old branch of the current fork, there were some options but then I removed them because it worked better dynamically. You can try the older version here. I am trying to make it work in both noisy and clean environments but there seems to be no way without compromising the segmentation process. I will update you here when I update the current fork with a customizable noise-gate, I am working on it. Meanwhile, I welcome any new suggestions.

Awesome, thanks for the answer. I'll await the new version :)

Added new option for disabling auto-gaining. Set auto_noise_gate: false, and set manual values for voiced_min_dB and voiced_max_dB like this:
https://github.com/tabahi/WebSpeechAnalyzer/blob/1d31abf1300350090e052d3308706df8a83a80eb/simple.html#L106
Working demo here.


Before after image slider

https://levelup.gitconnected.com/how-to-create-a-before-after-image-slider-with-css-and-js-a609d9ba77bf
https://github.com/kolibril13/jupyter-splitview
https://johnedchristensen.github.io/WebbCompare/basic.html
https://twitter.com/cpenned/status/1531765015820349442?s=21&t=41g4Hv_FG4ZD2QYRJeU9Iw

https://jimjam-slam.github.io/quarto-experiments/juxtapose/

https://twitter.com/kolibril13/status/1549323953486925824?s=20&t=l3ACKwB2n68dgkOXbXvvPQ


Update MainApp to v1.4

Coverage remained the same at 92.233% when pulling 9d9ba38cab1f7cd10642cdf8fc8658c3aa259e47 on lincredibleJC:release/v1.4Release into 978f433a52f1d3870345438f1564c16173626cb4 on CS2103AUG2017-T16-B2:master.

Coverage remained the same at 92.233% when pulling 8a9ab52aeb4289207de28a93e8ea3031bbcefc49 on lincredibleJC:release/v1.4Release into 7967bfca4d360a89ddc57b809e0061dc70eccff6 on CS2103AUG2017-T16-B2:master.


6.2.2 Wrapper Commands not working - release of Spring Security 6.1.x branch required

add to build.gradle
implementation "org.grails.plugins:spring-security-core:6.1.1"

 ./grailsw
| Resolving Dependencies. Please wait...
[Incubating] Problems report is available at: file:///Users/sheiberg/Documents/workspace/demo-622/build/reports/problems/problems-report.html

Deprecated Gradle features were used in this build, making it incompatible with Gradle 9.0.

You can use '--warning-mode all' to show the individual deprecation warnings and determine if they come from your own scripts or plugins.

For more on this, please refer to https://docs.gradle.org/8.11/userguide/command_line_interface.html#sec:command_line_warnings in the Gradle documentation.

| Starting interactive mode...
| Enter a command name to run. Use TAB for completion:
grails> s2-

s2-create-persistent-token       s2-create-role-hierarchy-entry   s2-quickstart
grails> s2-

s2-create-persistent-token       s2-create-role-hierarchy-entry   s2-quickstart
grails> s2-quickstart
<-------------> 0% CONFIGURING [284ms]
> root project > Resolve dependencies of :runtimeClasspath

FAILURE: Build failed with an exception.

* What went wrong:
Task 's2Quickstart' not found in root project 'demo-622'.

* Try:
> Run gradle tasks to get a list of available tasks.
> For more on name expansion, please refer to https://docs.gradle.org/8.11/userguide/command_line_interface.html#sec:name_abbreviation in the Gradle[Incubating] Problems report is available at: file:///Users/sheiberg/Documents/workspace/demo-622/build/reports/problems/problems-report.html

Deprecated Gradle features were used in this build, making it incompatible with Gradle 9.0.

You can use '--warning-mode all' to show the individual deprecation warnings and determine if they come from your own scripts or plugins.

For more on this, please refer to https://docs.gradle.org/8.11/userguide/command_line_interface.html#sec:command_line_warningg option to get more log output.
> Run with --scan to get full insights.
> Get more help at https://help.gradle.org.

BUILD FAILED in 648ms
s in the Gradle documentation.
| Error Command [s2-quickstart] error: Could not execute build using connection to Gradle distribution 'https://services.gradle.org/distributions/gradle-8.11-bin.zip'. (Use --stacktrace to see the full trace)
grails> quit

Version
6.2.2

https://github.com/grails/grails-spring-security-core/issues/1035

This should be addressed by org.grails.plugins:spring-security-core:6.1.2


Info: The Future of FTL

Hi there!
I was crawling through everything around the tech used in Lightspeed.
I even found https://github.com/obsproject/obs-studio/issues/3881 by @GRVYDEV
As I am somewhat a packaging freak I brought FTL to Arch Linux today with the AUR package obs-studio-ftl.
To get this upstream into Arch I planned to upstream my changes needed for packaging in OBS: https://github.com/obsproject/obs-studio/pull/4018
But looking at comments in my PR, as well as this PR it seems as if FTL is going to be removed soon-ish from OBS, as it is unmaintained and there are competing protocols trying to achieve the same goals.
Therefore I want to propose to move away from FTL to SRT, which could be a really good replacement, that's already supported in OBS through ffmpeg.
To be honest this is really a bummer as Lightspeed is really amazing software. But building on a wonky foundation would probably make maintaining this more and more difficult over time.
There are a few SRT protocol libraries on crates.io. Notably srt-rs which procides bindings for the aforementioned SRT library.
Now I haven't researched anything regarding codecs and how easy the SRT -> WebRTC "translation" will be. I might add more details later

You're awesome! So yes OBS wants to ditch FTL however I am working with a group of people (including the original mastermind behind FTL) in order to canonize it and revive it. I am not sure how long that will take however worst case we will maintain a fork of OBS with FTL support. I don't want to move to SRT since A) its super complicated and B) converting SRT to RTP sounds like a nightmare. This is the reason that I want to keep the ingest decoupled from the WebRTC broadcast though as someone could easily swap another ingest in as long as it outputs RTP packets

You're awesome! So yes OBS wants to ditch FTL however I am working with a group of people (including the original mastermind behind FTL) in order to canonize it and revive it. I am not sure how long that will take however worst case we will maintain a fork of OBS with FTL support. I don't want to move to SRT since A) its super complicated and B) converting SRT to RTP sounds like a nightmare. This is the reason that I want to keep the ingest decoupled from the WebRTC broadcast though as someone could easily swap another ingest in as long as it outputs RTP packets

That sounds double awesome!
I would then really suggest that you chime in on my PR, as that might help to keep the support alive. Because from their perspective it just seems dead right now, which is totally understandable.

That sounds double awesome!
I would then really suggest that you chime in on my PR, as that might help to keep the support alive. Because from their perspective it just seems dead right now, which is totally understandable.

That sounds double awesome!
I would then really suggest that you chime in on my PR, as that might help to keep the support alive. Because from their perspective it just seems dead right now, which is totally understandable.

Done :)

That sounds double awesome!
I would then really suggest that you chime in on my PR, as that might help to keep the support alive. Because from their perspective it just seems dead right now, which is totally understandable.

Done :)

Closing this as "not planned".

Closing this as "not planned".

I am going to reopen this issue since there are some things going on behind the scenes with OBS and FTL. There may potentially be another fork of OBS created in order to maintain FTL support but as of right now it looks like we will have support until Jan 2022

I am going to reopen this issue since there are some things going on behind the scenes with OBS and FTL. There may potentially be another fork of OBS created in order to maintain FTL support but as of right now it looks like we will have support until Jan 2022

I use SRT and wrap it in WebSockets with Nimble Streamer and would be totally up for SRT in Lightspeed but I do imagine there is work that would need to be done on the server side.
It seems just to unwrap the SRT stream (which just wraps around whatever streaming media you send "through" it) and then transmits it over WebSockets, uses minimal CPU also.
There is also https://hjortsberg.org/notes/Sending-UDP-over-Internet-using-SRT.html which should explain it more.

I will say that I probably will not implement SRT. 1) it is not low latency and 2) it would require transmuxing which would add cpu and latency overhead

I get about 100ms encoder-to-decoder but I do agree about the transmuxing bit, Good to know and no worries!

What is the current state of the world for FTL + OBS?

What is the current state of the world for FTL + OBS?

With regards to the current situation on FTL staying in OBS, it seems unlikely at this point.
See this discussion about it

OBS is moving to support this use case via WISH-based WebRTC output. This is essentially the same way that FTL works except you use a WebRTC SDP negotiation instead of the simpler FTL negotiation. It's probably worth implementing a WISH endpoint


How to hide actionable buttons for the Cc'd users in the Actionable messages adaptive card email body?

Currently the actionable messages are getting send to the To and CC'd users. But wanted to hide the actionable buttons for the CC'd users so that only the TO-list recipients can take action on the actionable requests. Where as it is just for information to the CC'd users.
Is there a way to achieve hiding actionable buttons for the CC'd users alone? was there any property already available which does this automatically?

There is no way to do this today. I've forwarded your question to the product team for consideration for the future.

There is no way to do this today. I've forwarded your question to the product team for consideration for the future.

Hi Jasonjoh,
Thank you for your response.

Hi Jasonjoh,
Thank you for your response.


Avoid using webp for images

JOSM core does not support webp. While there are plugins that add support (ImageIO and webp), they are not part of JOSM core.
The specific file at issue is https://upload.wikimedia.org/wikipedia/commons/b/b5/Willmart_Supermarket_Logo_White.png.webp.
See https://josm.openstreetmap.de/jenkins/job/JOSM-Integration/jdk=JDK8/9008/testReport/junit/org.openstreetmap.josm.gui.preferences.map/TaggingPresetPreferenceTestIT/Georgia___https___github_com_komachi_josm_ge_preset_blob_main_ge_xml/ .

Disabled in https://josm.openstreetmap.de/wiki/PresetsSource?action=diff&version=169

Reenabled in https://josm.openstreetmap.de/wiki/PresetsSource?action=diff&version=170


Update tutorial_2mic.md

brief addenda, given that in my case I wasn't expecting a long installation, and the ssh connection reset, making me having to rebuild it all

Thanks!


Remote dnsmasq updater

Hi,
I would like to add a link.
I was going to fork and PR but I found myself unsure of whether it would be better suited in the Networking or Reverse-Proxy category. I was also unsure about whether anyone else might even find it useful - possibly I've missed something obvious and solved a problem no one else but me has. (Also, it's a little bit intimidating looking at a category you think your little Python script might belong to and seeing that category largely consists of full-blown network fabrics. :))
If you think it's worthwhile to add my small project to the list, and can suggest the most appropriate category, I'm happy to go ahead and do the PR. If it's not awesome enough, that's fine too, no skin off my nose. My name resolution problems are solved either way (even if they are problems of my own making due to missing an obvious existing solution :)).
REPO: https://github.com/moonbuggy/docker-dnsmasq-updater
DESCRIPTION: Update a remote dnsmasq server with Docker container hostnames
AUTHOR: moonbuggy

Hi @moonbuggy ,
Thank you for opening an issue.
I think it would be best suited in Reverse-Proxy. I think it is an interesting project.
Just a note, it took me a while to figure out why I would use that but the documentation is good!
That makes it all worthwhile.
Congratulations on that project.
Please make a PR we would love to have your project on the list 😄

Just a note, it took me a while to figure out why I would use that [..]

That's related to the reason I wondered if I'd missed an existing solution, I was surprised I didn't find something that already did this, so I figured either I missed something or not many other people care about automating LAN hostnames for containers. There's some irony either way, if my laziness about editing hosts files caused me to put more time in to a completely unnecessary Python script than I'd have put into editing hosts files manually in the first place. :)
I'm kinda curious to see if anyone else does find it useful or not, and having it on this list should, if nothing else, satisfy that curiosity. One way or the other. :) With a bit of luck, at least some others will have a use for it and waving it around in public will have benefit beyond merely satisfying my curiosity.
Anyway, I've submitted the PR, thanks for your time and attention.

There's some irony either way, if my laziness about editing hosts files caused me to put more time in to a completely unnecessary Python script than I'd have put into editing hosts files manually in the first place. :)

Hahaha, I thought about that, I guess nobody dared to automate that part. Congratulations on being the first 😄


song 9088 should be double coded

Kaluli song - two female singers alternate. Should be coded 10 and 4 (to indicate just two singers), now coded simply 10 (in cldf and raw).
The same performance type is true for 9089, 9096, 9097, 9098, 30097, 30098.

Corrected to double code of 10 and 4 for songs 9088, 9089, 9096, 9097, 9098, 30097, and 30098 (on canto_codings google sheet).


Create new metrics API endpoint for debug-specific metrics

There are some metrics that can be useful for debugging purposes, but because they have a high cardinality, they aren't exposed to the regular API metrics.
Exposing a new local-only API endpoint for debug-specific metrics would allow us to fetch its values and store them in the sysdumps.
This would also allow us to enable all metrics that got disabled by default due high cardinality.

Potentially duplicate of https://github.com/cilium/cilium/issues/27659

Dup of https://github.com/cilium/cilium/issues/27659


Move eslint-plugins to peer/dev dependencies

Moved all eslint-plugin-* to peer/dev dependency section of package.json as stated in the official documentation, see http://eslint.org/docs/developer-guide/working-with-plugins#peer-dependency
Changes are motivated by the following issue of breaking the lint command if packages were installed with yarn, see https://github.com/eslint/eslint/issues/8547
Maybe it would be better to define a more generic version range for the packages, just let me know what you think is best.

Moved all eslint-plugin-* to peer/dev dependency section of package.json as stated in the official documentation

The section you're linking to is about referencing ESLint itself from a plugin.
But react-scripts is not an ESLint plugin, and the packages you’re moving are plugins themselves.
So I don’t see how this doc applies here.

Changes are motivated by the following issue of breaking the lint command if packages were installed with yarn, see eslint/eslint#8547

I don’t have full context there but if you’re defining a custom .eslintrc then it’s not really fully supported. It is possible but if you bump into Yarn bugs or similar, I don’t think there’s something we could do to help you.
We don’t plan to make ESLint plugins peerDependencies of react-scripts because this would add a lot of junk to package.json of non-ejected projects. Keeping generated package.json minimal is an explicit goal of this project (configurability of ESLint is not). Making them peerDependencies would place the burden of updating ESLint plugins on users, and we don’t want people who are happy with the default setup to suffer because of needs of advanced users.
Some people have chosen to customize ESLint configs, but at this point you’re on your own with regards to configuration and package manager issues. If you want to enforce code styling, we recommend using Prettier instead of ESLint. Many JSX accessibility rules are already included in our preset by default too.
Sorry if this isn’t very helpful. I’m happy to consider other fixes on our side, but we won’t be burdening our users with all of these plugins in their package.json, which is what I think we’d have to do if we take this PR.
Please let me know if I misunderstood.


[5.7] Add nullableTimestamp methods to Schema Blueprint

I've found that there is a need to add nullable timestamp columns pretty frequently.
$table->timestamp('banned_at')->nullable();

And since we have nullableTimestamps() method, it's will be good to have nullableTimestamp() for creating only one nullable datetime column.
$table->nullableTimestamp('banned_at');

Whilst I think it would be useful - my only comment is that opens the flood gates and we'll start getting PR's for everything:
->nullableInteger('example')
->nullableString('example')

I don't understand the benefit with this -- This would be too close to  ->nullableTimestamps(), possibly adding some confusion.

Is there a better timestamp
On Dec 16, 2018, at 7:03 PM, Andy Hinkle<EMAIL_ADDRESS>wrote:
I don't understand the benefit with this -- This would be too close to ->nullableTimestamps(), possibly adding some confusion.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

@laurencei I agree with you. It's normal for nullableMorphs because there is no easy way to create them nullable, but for single column creation it might be harmful.


Edit comment to specify for reference

Fixes #111. Let me know if this is okay :) Cheers!

@nahuakang Looks great! It's just a little long. I try to keep the Ziglings columns under 80 for small screens and split screens.
Instead of
        // Loop through every alien by reference by specifying that the capture value is a pointer

Could we shorten it to something like
        // Loop through every alien by reference (* makes a pointer capture value)

Thanks!

Done :) Thanks Dave!

Perfect, thanks!


HBASE-26252: Add option to reload balancer configs when invoking the balancer

I made one important design decision in this implementation: This new option only reloads the balancer's config, not any other observers. It would be easy to simply call configurationManager.notifyObservers instead, but I felt like even with docs it would be too unexpected to have a balancer-specific option reload all configurations for the entire HMaster. If there are strong opposing opinions, perhaps we could name the option setReloadAllMasterConfigs or something. This would probably be safe,r but just feels like scope creep for the balancer command.
I added a test for this new feature and it exposed an existing bug with reloading configs for the balancer. I will call out the fix with a line-item comment below.
I also noticed and fixed another small logging bug which you'll see in StochasticLoadBalancer.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 25s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+0 :ok:
prototool
0m  0s
prototool was not available.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ master Compile Tests _

+0 :ok:
mvndep
0m 16s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
3m 56s
master passed

+1 :green_heart:
compile
7m 18s
master passed

+1 :green_heart:
checkstyle
2m 40s
master passed

+1 :green_heart:
spotbugs
8m  9s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 14s
Maven dependency ordering for patch

-1 :x:
mvninstall
1m 49s
root in the patch failed.

-1 :x:
compile
0m 43s
hbase-server in the patch failed.

-0 :warning:
cc
0m 43s
hbase-server in the patch failed.

-0 :warning:
javac
0m 43s
hbase-server in the patch failed.

-0 :warning:
checkstyle
0m 12s
hbase-balancer: The patch generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)

-0 :warning:
rubocop
0m 12s
The patch generated 11 new + 50 unchanged - 3 fixed = 61 total (was 53)

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

-1 :x:
hadoopcheck
1m 59s
The patch causes 14 errors with Hadoop v3.1.2.

-1 :x:
hadoopcheck
4m  6s
The patch causes 14 errors with Hadoop v3.2.1.

-1 :x:
hadoopcheck
6m 18s
The patch causes 14 errors with Hadoop v3.3.0.

-1 :x:
hbaseprotoc
0m 30s
hbase-server in the patch failed.

-1 :x:
spotbugs
0m 25s
hbase-server in the patch failed.

_ Other Tests _

+1 :green_heart:
asflicense
1m  4s
The patch does not generate ASF License warnings.

52m 45s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3660/1/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/3660

JIRA Issue
HBASE-26252

Optional Tests
dupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile cc hbaseprotoc prototool rubocop

uname
Linux b6c4aa7d3a5d 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / dd293c8ba9

Default Java
AdoptOpenJDK-1.8.0_282-b08

mvninstall
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3660/1/artifact/yetus-general-check/output/patch-mvninstall-root.txt

compile
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3660/1/artifact/yetus-general-check/output/patch-compile-hbase-server.txt

cc
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3660/1/artifact/yetus-general-check/output/patch-compile-hbase-server.txt

javac
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3660/1/artifact/yetus-general-check/output/patch-compile-hbase-server.txt

checkstyle
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3660/1/artifact/yetus-general-check/output/diff-checkstyle-hbase-balancer.txt

rubocop
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3660/1/artifact/yetus-general-check/output/diff-patch-rubocop.txt

hadoopcheck
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3660/1/artifact/yetus-general-check/output/patch-javac-3.1.2.txt

hadoopcheck
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3660/1/artifact/yetus-general-check/output/patch-javac-3.2.1.txt

hadoopcheck
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3660/1/artifact/yetus-general-check/output/patch-javac-3.3.0.txt

hbaseprotoc
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3660/1/artifact/yetus-general-check/output/patch-hbaseprotoc-hbase-server.txt

spotbugs
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3660/1/artifact/yetus-general-check/output/patch-spotbugs-hbase-server.txt

Max. process+thread count
96 (vs. ulimit of 30000)

modules
C: hbase-protocol-shaded hbase-common hbase-client hbase-balancer hbase-server hbase-shell U: .

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3660/1/console

versions
git=2.17.1 maven=3.6.3 spotbugs=4.2.2 rubocop=0.80.0

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m  1s
Docker mode activated.

-0 :warning:
yetus
0m  4s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+0 :ok:
mvndep
0m 17s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
4m 32s
master passed

+1 :green_heart:
compile
3m 49s
master passed

+1 :green_heart:
shadedjars
8m 19s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
2m 21s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 15s
Maven dependency ordering for patch

-1 :x:
mvninstall
2m 12s
root in the patch failed.

-1 :x:
compile
0m 45s
hbase-server in the patch failed.

-0 :warning:
javac
0m 45s
hbase-server in the patch failed.

-1 :x:
shadedjars
6m 13s
patch has 14 errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
2m 17s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
1m  0s
hbase-protocol-shaded in the patch passed.

+1 :green_heart:
unit
1m 51s
hbase-common in the patch passed.

+1 :green_heart:
unit
1m 21s
hbase-client in the patch passed.

+1 :green_heart:
unit
6m 53s
hbase-balancer in the patch passed.

-1 :x:
unit
0m 45s
hbase-server in the patch failed.

-1 :x:
unit
7m 27s
hbase-shell in the patch failed.

56m 19s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3660/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/3660

JIRA Issue
HBASE-26252

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 9d9891a5513b 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / dd293c8ba9

Default Java
AdoptOpenJDK-11.0.10+9

mvninstall
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3660/1/artifact/yetus-jdk11-hadoop3-check/output/patch-mvninstall-root.txt

compile
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3660/1/artifact/yetus-jdk11-hadoop3-check/output/patch-compile-hbase-server.txt

javac
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3660/1/artifact/yetus-jdk11-hadoop3-check/output/patch-compile-hbase-server.txt

shadedjars
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3660/1/artifact/yetus-jdk11-hadoop3-check/output/patch-shadedjars.txt

unit
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3660/1/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt

unit
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3660/1/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-shell.txt

Test Results
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3660/1/testReport/

Max. process+thread count
2240 (vs. ulimit of 30000)

modules
C: hbase-protocol-shaded hbase-common hbase-client hbase-balancer hbase-server hbase-shell U: .

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3660/1/console

versions
git=2.17.1 maven=3.6.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m 52s
Docker mode activated.

-0 :warning:
yetus
0m  3s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+0 :ok:
mvndep
0m 17s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
3m 53s
master passed

+1 :green_heart:
compile
3m 30s
master passed

+1 :green_heart:
shadedjars
8m 43s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
2m  8s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 17s
Maven dependency ordering for patch

-1 :x:
mvninstall
2m  0s
root in the patch failed.

-1 :x:
compile
0m 42s
hbase-server in the patch failed.

-0 :warning:
javac
0m 42s
hbase-server in the patch failed.

-1 :x:
shadedjars
6m 16s
patch has 14 errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
2m  5s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
0m 52s
hbase-protocol-shaded in the patch passed.

+1 :green_heart:
unit
1m 57s
hbase-common in the patch passed.

+1 :green_heart:
unit
1m 32s
hbase-client in the patch passed.

+1 :green_heart:
unit
8m 58s
hbase-balancer in the patch passed.

-1 :x:
unit
0m 47s
hbase-server in the patch failed.

-1 :x:
unit
7m  8s
hbase-shell in the patch failed.

57m 37s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3660/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/3660

JIRA Issue
HBASE-26252

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 33d2e2dab651 4.15.0-65-generic #74-Ubuntu SMP Tue Sep 17 17:06:04 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / dd293c8ba9

Default Java
AdoptOpenJDK-1.8.0_282-b08

mvninstall
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3660/1/artifact/yetus-jdk8-hadoop3-check/output/patch-mvninstall-root.txt

compile
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3660/1/artifact/yetus-jdk8-hadoop3-check/output/patch-compile-hbase-server.txt

javac
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3660/1/artifact/yetus-jdk8-hadoop3-check/output/patch-compile-hbase-server.txt

shadedjars
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3660/1/artifact/yetus-jdk8-hadoop3-check/output/patch-shadedjars.txt

unit
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3660/1/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-server.txt

unit
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3660/1/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-shell.txt

Test Results
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3660/1/testReport/

Max. process+thread count
2279 (vs. ulimit of 30000)

modules
C: hbase-protocol-shaded hbase-common hbase-client hbase-balancer hbase-server hbase-shell U: .

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3660/1/console

versions
git=2.17.1 maven=3.6.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 26s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+0 :ok:
prototool
0m  0s
prototool was not available.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ master Compile Tests _

+0 :ok:
mvndep
0m 14s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
3m 36s
master passed

+1 :green_heart:
compile
7m 21s
master passed

+1 :green_heart:
checkstyle
2m 36s
master passed

+1 :green_heart:
spotbugs
8m 10s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 14s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
3m 38s
the patch passed

+1 :green_heart:
compile
7m 15s
the patch passed

+1 :green_heart:
cc
7m 15s
the patch passed

+1 :green_heart:
javac
7m 15s
the patch passed

-0 :warning:
checkstyle
0m 14s
hbase-balancer: The patch generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)

-0 :warning:
rubocop
0m 12s
The patch generated 11 new + 50 unchanged - 3 fixed = 61 total (was 53)

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
hadoopcheck
18m 18s
Patch does not cause any errors with Hadoop 3.1.2 3.2.1 3.3.0.

+1 :green_heart:
hbaseprotoc
3m 15s
the patch passed

+1 :green_heart:
spotbugs
9m 21s
the patch passed

_ Other Tests _

+1 :green_heart:
asflicense
1m 15s
The patch does not generate ASF License warnings.

77m 49s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3660/2/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/3660

JIRA Issue
HBASE-26252

Optional Tests
dupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile cc hbaseprotoc prototool rubocop

uname
Linux d73e17d0a55f 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / dd293c8ba9

Default Java
AdoptOpenJDK-1.8.0_282-b08

checkstyle
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3660/2/artifact/yetus-general-check/output/diff-checkstyle-hbase-balancer.txt

rubocop
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3660/2/artifact/yetus-general-check/output/diff-patch-rubocop.txt

Max. process+thread count
96 (vs. ulimit of 30000)

modules
C: hbase-protocol-shaded hbase-common hbase-client hbase-balancer hbase-server hbase-shell U: .

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3660/2/console

versions
git=2.17.1 maven=3.6.3 spotbugs=4.2.2 rubocop=0.80.0

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m  1s
Docker mode activated.

-0 :warning:
yetus
0m  3s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+0 :ok:
mvndep
0m 13s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
4m 16s
master passed

+1 :green_heart:
compile
3m 49s
master passed

+1 :green_heart:
shadedjars
8m 10s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
2m 18s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 14s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
4m 16s
the patch passed

+1 :green_heart:
compile
3m 50s
the patch passed

+1 :green_heart:
javac
3m 50s
the patch passed

+1 :green_heart:
shadedjars
8m 15s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
2m 17s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
0m 58s
hbase-protocol-shaded in the patch passed.

+1 :green_heart:
unit
1m 50s
hbase-common in the patch passed.

+1 :green_heart:
unit
1m 21s
hbase-client in the patch passed.

+1 :green_heart:
unit
6m 53s
hbase-balancer in the patch passed.

+1 :green_heart:
unit
143m 49s
hbase-server in the patch passed.

-1 :x:
unit
7m 47s
hbase-shell in the patch failed.

204m 47s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3660/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/3660

JIRA Issue
HBASE-26252

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 18ae5e7a7f9c 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / dd293c8ba9

Default Java
AdoptOpenJDK-11.0.10+9

unit
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3660/2/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-shell.txt

Test Results
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3660/2/testReport/

Max. process+thread count
3788 (vs. ulimit of 30000)

modules
C: hbase-protocol-shaded hbase-common hbase-client hbase-balancer hbase-server hbase-shell U: .

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3660/2/console

versions
git=2.17.1 maven=3.6.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m 13s
Docker mode activated.

-0 :warning:
yetus
0m  3s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+0 :ok:
mvndep
0m 13s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
3m 55s
master passed

+1 :green_heart:
compile
3m 33s
master passed

+1 :green_heart:
shadedjars
8m 45s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
2m 12s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 15s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
3m 58s
the patch passed

+1 :green_heart:
compile
3m 26s
the patch passed

+1 :green_heart:
javac
3m 26s
the patch passed

+1 :green_heart:
shadedjars
8m 48s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
2m  8s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
0m 48s
hbase-protocol-shaded in the patch passed.

+1 :green_heart:
unit
1m 54s
hbase-common in the patch passed.

+1 :green_heart:
unit
1m 31s
hbase-client in the patch passed.

+1 :green_heart:
unit
8m 59s
hbase-balancer in the patch passed.

+1 :green_heart:
unit
159m 44s
hbase-server in the patch passed.

-1 :x:
unit
7m 16s
hbase-shell in the patch failed.

221m 55s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3660/2/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/3660

JIRA Issue
HBASE-26252

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 96960d6c8f0f 4.15.0-65-generic #74-Ubuntu SMP Tue Sep 17 17:06:04 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / dd293c8ba9

Default Java
AdoptOpenJDK-1.8.0_282-b08

unit
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3660/2/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-shell.txt

Test Results
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3660/2/testReport/

Max. process+thread count
4052 (vs. ulimit of 30000)

modules
C: hbase-protocol-shaded hbase-common hbase-client hbase-balancer hbase-server hbase-shell U: .

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3660/2/console

versions
git=2.17.1 maven=3.6.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 25s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+0 :ok:
prototool
0m  0s
prototool was not available.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ master Compile Tests _

+0 :ok:
mvndep
0m 14s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
3m 41s
master passed

+1 :green_heart:
compile
7m 18s
master passed

+1 :green_heart:
checkstyle
2m 36s
master passed

+1 :green_heart:
spotbugs
8m  6s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 15s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
3m 39s
the patch passed

+1 :green_heart:
compile
7m 16s
the patch passed

+1 :green_heart:
cc
7m 16s
the patch passed

+1 :green_heart:
javac
7m 16s
the patch passed

-0 :warning:
checkstyle
0m 14s
hbase-balancer: The patch generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)

-0 :warning:
rubocop
0m 12s
The patch generated 11 new + 50 unchanged - 3 fixed = 61 total (was 53)

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
hadoopcheck
18m 15s
Patch does not cause any errors with Hadoop 3.1.2 3.2.1 3.3.0.

+1 :green_heart:
hbaseprotoc
3m 12s
the patch passed

+1 :green_heart:
spotbugs
9m  8s
the patch passed

_ Other Tests _

+1 :green_heart:
asflicense
1m 14s
The patch does not generate ASF License warnings.

77m 32s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3660/3/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/3660

JIRA Issue
HBASE-26252

Optional Tests
dupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile cc hbaseprotoc prototool rubocop

uname
Linux 7ad2c6e75f67 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / dd293c8ba9

Default Java
AdoptOpenJDK-1.8.0_282-b08

checkstyle
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3660/3/artifact/yetus-general-check/output/diff-checkstyle-hbase-balancer.txt

rubocop
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3660/3/artifact/yetus-general-check/output/diff-patch-rubocop.txt

Max. process+thread count
96 (vs. ulimit of 30000)

modules
C: hbase-protocol-shaded hbase-common hbase-client hbase-balancer hbase-server hbase-shell U: .

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3660/3/console

versions
git=2.17.1 maven=3.6.3 spotbugs=4.2.2 rubocop=0.80.0

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m 11s
Docker mode activated.

-0 :warning:
yetus
0m  3s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+0 :ok:
mvndep
0m 17s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
4m 21s
master passed

+1 :green_heart:
compile
3m 22s
master passed

+1 :green_heart:
shadedjars
9m  0s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
1m 59s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 13s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
4m  8s
the patch passed

+1 :green_heart:
compile
3m 20s
the patch passed

+1 :green_heart:
javac
3m 20s
the patch passed

+1 :green_heart:
shadedjars
9m  0s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
1m 57s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
0m 48s
hbase-protocol-shaded in the patch passed.

+1 :green_heart:
unit
2m 11s
hbase-common in the patch passed.

+1 :green_heart:
unit
1m 35s
hbase-client in the patch passed.

+1 :green_heart:
unit
11m 31s
hbase-balancer in the patch passed.

+1 :green_heart:
unit
213m 57s
hbase-server in the patch passed.

+1 :green_heart:
unit
8m 50s
hbase-shell in the patch passed.

280m 30s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3660/3/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/3660

JIRA Issue
HBASE-26252

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 56f1a00600de 4.15.0-147-generic #151-Ubuntu SMP Fri Jun 18 19:21:19 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / dd293c8ba9

Default Java
AdoptOpenJDK-1.8.0_282-b08

Test Results
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3660/3/testReport/

Max. process+thread count
3469 (vs. ulimit of 30000)

modules
C: hbase-protocol-shaded hbase-common hbase-client hbase-balancer hbase-server hbase-shell U: .

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3660/3/console

versions
git=2.17.1 maven=3.6.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 30s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+0 :ok:
prototool
0m  0s
prototool was not available.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ master Compile Tests _

+0 :ok:
mvndep
0m 16s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
3m 57s
master passed

+1 :green_heart:
compile
7m 33s
master passed

+1 :green_heart:
checkstyle
2m 33s
master passed

+1 :green_heart:
spotbugs
8m 26s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 14s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
3m 42s
the patch passed

+1 :green_heart:
compile
7m 16s
the patch passed

+1 :green_heart:
cc
7m 16s
the patch passed

+1 :green_heart:
javac
7m 16s
the patch passed

-0 :warning:
checkstyle
0m 13s
hbase-balancer: The patch generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)

-0 :warning:
rubocop
0m 11s
The patch generated 11 new + 50 unchanged - 3 fixed = 61 total (was 53)

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
hadoopcheck
18m 25s
Patch does not cause any errors with Hadoop 3.1.2 3.2.1 3.3.0.

+1 :green_heart:
hbaseprotoc
3m 13s
the patch passed

+1 :green_heart:
spotbugs
9m 10s
the patch passed

_ Other Tests _

+1 :green_heart:
asflicense
1m 15s
The patch does not generate ASF License warnings.

78m  9s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3660/4/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/3660

JIRA Issue
HBASE-26252

Optional Tests
dupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile cc hbaseprotoc prototool rubocop

uname
Linux 1ca3ae861866 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / afbdd4115b

Default Java
AdoptOpenJDK-1.8.0_282-b08

checkstyle
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3660/4/artifact/yetus-general-check/output/diff-checkstyle-hbase-balancer.txt

rubocop
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3660/4/artifact/yetus-general-check/output/diff-patch-rubocop.txt

Max. process+thread count
96 (vs. ulimit of 30000)

modules
C: hbase-protocol-shaded hbase-common hbase-client hbase-balancer hbase-server hbase-shell U: .

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3660/4/console

versions
git=2.17.1 maven=3.6.3 spotbugs=4.2.2 rubocop=0.80.0

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
7m 20s
Docker mode activated.

-0 :warning:
yetus
0m  3s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+0 :ok:
mvndep
0m 16s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
3m 53s
master passed

+1 :green_heart:
compile
3m 22s
master passed

+1 :green_heart:
shadedjars
8m 14s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
2m  9s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 16s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
3m 46s
the patch passed

+1 :green_heart:
compile
3m 22s
the patch passed

+1 :green_heart:
javac
3m 22s
the patch passed

+1 :green_heart:
shadedjars
8m 16s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
2m  7s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
0m 45s
hbase-protocol-shaded in the patch passed.

+1 :green_heart:
unit
1m 47s
hbase-common in the patch passed.

+1 :green_heart:
unit
1m 29s
hbase-client in the patch passed.

+1 :green_heart:
unit
8m 57s
hbase-balancer in the patch passed.

+1 :green_heart:
unit
152m 49s
hbase-server in the patch passed.

+1 :green_heart:
unit
7m 19s
hbase-shell in the patch passed.

219m 17s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3660/4/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/3660

JIRA Issue
HBASE-26252

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 47827a860849 4.15.0-65-generic #74-Ubuntu SMP Tue Sep 17 17:06:04 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / afbdd4115b

Default Java
AdoptOpenJDK-1.8.0_282-b08

Test Results
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3660/4/testReport/

Max. process+thread count
4742 (vs. ulimit of 30000)

modules
C: hbase-protocol-shaded hbase-common hbase-client hbase-balancer hbase-server hbase-shell U: .

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3660/4/console

versions
git=2.17.1 maven=3.6.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 25s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+0 :ok:
prototool
0m  1s
prototool was not available.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ master Compile Tests _

+0 :ok:
mvndep
0m 17s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
3m 57s
master passed

+1 :green_heart:
compile
7m 21s
master passed

+1 :green_heart:
checkstyle
2m 40s
master passed

+1 :green_heart:
spotbugs
8m  6s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 14s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
3m 39s
the patch passed

+1 :green_heart:
compile
7m 13s
the patch passed

+1 :green_heart:
cc
7m 13s
the patch passed

+1 :green_heart:
javac
7m 13s
the patch passed

-0 :warning:
checkstyle
0m 15s
hbase-balancer: The patch generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)

-0 :warning:
rubocop
0m 12s
The patch generated 11 new + 50 unchanged - 3 fixed = 61 total (was 53)

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
hadoopcheck
18m 20s
Patch does not cause any errors with Hadoop 3.1.2 3.2.1 3.3.0.

+1 :green_heart:
hbaseprotoc
3m 15s
the patch passed

+1 :green_heart:
spotbugs
9m 16s
the patch passed

_ Other Tests _

+1 :green_heart:
asflicense
1m 17s
The patch does not generate ASF License warnings.

78m 17s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3660/5/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/3660

JIRA Issue
HBASE-26252

Optional Tests
dupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile cc hbaseprotoc prototool rubocop

uname
Linux f471162b31cc 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / fae6261d96

Default Java
AdoptOpenJDK-1.8.0_282-b08

checkstyle
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3660/5/artifact/yetus-general-check/output/diff-checkstyle-hbase-balancer.txt

rubocop
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3660/5/artifact/yetus-general-check/output/diff-patch-rubocop.txt

Max. process+thread count
96 (vs. ulimit of 30000)

modules
C: hbase-protocol-shaded hbase-common hbase-client hbase-balancer hbase-server hbase-shell U: .

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3660/5/console

versions
git=2.17.1 maven=3.6.3 spotbugs=4.2.2 rubocop=0.80.0

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Test failure looks unrelated to this change: TestRSGroupsWithACL (AccessDenied) and TestJMXListener (Shutting down)

Test failure looks unrelated to this change: TestRSGroupsWithACL (AccessDenied) and TestJMXListener (Shutting down)

Agreed, you may want to try again after clearing other checks.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 28s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  1s
No case conflicting files found.

+0 :ok:
prototool
0m  0s
prototool was not available.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ master Compile Tests _

+0 :ok:
mvndep
0m 30s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
3m 44s
master passed

+1 :green_heart:
compile
7m 14s
master passed

+1 :green_heart:
checkstyle
2m 39s
master passed

+1 :green_heart:
spotbugs
8m 19s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 13s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
3m 36s
the patch passed

+1 :green_heart:
compile
7m 14s
the patch passed

+1 :green_heart:
cc
7m 14s
the patch passed

+1 :green_heart:
javac
7m 14s
the patch passed

-0 :warning:
checkstyle
0m 14s
hbase-balancer: The patch generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)

-0 :warning:
rubocop
0m 11s
The patch generated 11 new + 50 unchanged - 3 fixed = 61 total (was 53)

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
hadoopcheck
18m 14s
Patch does not cause any errors with Hadoop 3.1.2 3.2.1 3.3.0.

+1 :green_heart:
hbaseprotoc
3m 14s
the patch passed

+1 :green_heart:
spotbugs
9m 20s
the patch passed

_ Other Tests _

+1 :green_heart:
asflicense
1m 13s
The patch does not generate ASF License warnings.

78m  5s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3660/6/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/3660

JIRA Issue
HBASE-26252

Optional Tests
dupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile cc hbaseprotoc prototool rubocop

uname
Linux c6020ee1b19d 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 4614c7bc57

Default Java
AdoptOpenJDK-1.8.0_282-b08

checkstyle
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3660/6/artifact/yetus-general-check/output/diff-checkstyle-hbase-balancer.txt

rubocop
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3660/6/artifact/yetus-general-check/output/diff-patch-rubocop.txt

Max. process+thread count
96 (vs. ulimit of 30000)

modules
C: hbase-protocol-shaded hbase-common hbase-client hbase-balancer hbase-server hbase-shell U: .

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3660/6/console

versions
git=2.17.1 maven=3.6.3 spotbugs=4.2.2 rubocop=0.80.0

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m  2s
Docker mode activated.

-0 :warning:
yetus
0m  3s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+0 :ok:
mvndep
0m 28s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
4m 19s
master passed

+1 :green_heart:
compile
3m 52s
master passed

+1 :green_heart:
shadedjars
8m 11s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
2m 21s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 15s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
4m 20s
the patch passed

+1 :green_heart:
compile
3m 52s
the patch passed

+1 :green_heart:
javac
3m 52s
the patch passed

+1 :green_heart:
shadedjars
8m 12s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
2m 19s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
0m 59s
hbase-protocol-shaded in the patch passed.

+1 :green_heart:
unit
1m 50s
hbase-common in the patch passed.

+1 :green_heart:
unit
1m 20s
hbase-client in the patch passed.

+1 :green_heart:
unit
6m 53s
hbase-balancer in the patch passed.

+1 :green_heart:
unit
149m 26s
hbase-server in the patch passed.

+1 :green_heart:
unit
7m 54s
hbase-shell in the patch passed.

210m 49s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3660/6/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/3660

JIRA Issue
HBASE-26252

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 27539ee9a725 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 4614c7bc57

Default Java
AdoptOpenJDK-11.0.10+9

Test Results
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3660/6/testReport/

Max. process+thread count
4122 (vs. ulimit of 30000)

modules
C: hbase-protocol-shaded hbase-common hbase-client hbase-balancer hbase-server hbase-shell U: .

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3660/6/console

versions
git=2.17.1 maven=3.6.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m  3s
Docker mode activated.

-0 :warning:
yetus
0m  3s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+0 :ok:
mvndep
0m 31s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
4m 13s
master passed

+1 :green_heart:
compile
3m 21s
master passed

+1 :green_heart:
shadedjars
9m  2s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
1m 57s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 14s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
4m  5s
the patch passed

+1 :green_heart:
compile
3m 19s
the patch passed

+1 :green_heart:
javac
3m 19s
the patch passed

+1 :green_heart:
shadedjars
9m  5s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
1m 58s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
0m 47s
hbase-protocol-shaded in the patch passed.

+1 :green_heart:
unit
2m 12s
hbase-common in the patch passed.

+1 :green_heart:
unit
1m 33s
hbase-client in the patch passed.

+1 :green_heart:
unit
11m 32s
hbase-balancer in the patch passed.

+1 :green_heart:
unit
216m  7s
hbase-server in the patch passed.

+1 :green_heart:
unit
8m 46s
hbase-shell in the patch passed.

282m 40s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3660/6/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/3660

JIRA Issue
HBASE-26252

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux f2fd9f8ddc9b 4.15.0-147-generic #151-Ubuntu SMP Fri Jun 18 19:21:19 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 4614c7bc57

Default Java
AdoptOpenJDK-1.8.0_282-b08

Test Results
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3660/6/testReport/

Max. process+thread count
3994 (vs. ulimit of 30000)

modules
C: hbase-protocol-shaded hbase-common hbase-client hbase-balancer hbase-server hbase-shell U: .

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3660/6/console

versions
git=2.17.1 maven=3.6.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

I'm going to close this for now. The changes requested are simple and I can do them, but we ended up orchestrating reload configs in another way not worth adding this complexity for us. If there is other interest we can certainly reconsider.


BUG: mkinstallp no longer gives correct sizes: Upsize template line

Looking at the archive - from before github days it appears a start was made to update the way the template-line "Upsize" was created.
It looks as if makebff.pl is still doing something - but not what is really needed.
Needs fixing! (So, now I'll look at how I would submit my own PR!)

Hmm. Open issue, but I had already done a branch and merged it.
Must check if it is already fixed.


SIDE-915 - Add Order field to WhisperContentFormInputs

Added Order field to allow users to order the inputs in a form.
The UI will be able to sort on this field to show the form elements in the correct order

Hey Scott, I don't see the Node LDK changes included here. Is this something you'll be taking on yourself or would you like me to handle them?


Refactorings

This issue is used to collect small refactorings that appear while developing new features.

[ ] TestIdentity: extract till you drop
[ ] Remove new lines in Currency.cs, Profile.cs

[ ] New Lines in ErrorResponse.cs

[ ] TradesController: rename MapTo... methods
[ ] TradesContrller: add new lines if necessary
[ ] WebApplicationExtensions.cs: extract till you drop

[ ] DefaultProfileId in Constants.cs löschen


added nginx support

1/ Tested on our dev environment
2/ Running Prometheus nginx installer

List of files that is getting installed under opsverse

List of files that is getting installed under opsverse and process running (nginx-promethus-exporter)

nginx-promethus-exporter as a service

cc: @sat-devopsnow


Mark the listener functions with @discardableResult

Saves users from needing to do _ = ws.onText { _ in /* ... */ } to suppress compiler warnings

Merging once CI passes 👍


Cleaned up small grammatical errors

[x] I have read freeCodeCamp's contribution guidelines.
[x] My pull request has a descriptive title (not a vague title like Update index.md)
[x] My pull request targets the master branch of freeCodeCamp.
[x] None of my changes are plagiarized from another source without proper attribution.
[x] My article does not contain shortened URLs or affiliate links.

If your pull request closes a GitHub issue, replace the XXXXX below with the issue number.
Closes #XXXXX

So I'd love to be able to merge your changes but it looks like you have some merge conflicts. ⚠
Once you resolve these conflicts, I will be able to review your PR and merge it. 😊

If you're not familiar with the merge conflict process, feel free to look over GitHub's guide on "Resolving a merge conflict". 🔍
Also, it's good practice on GitHub to write a brief description of your changes when creating a PR. 📝


Internal server Error | Captcha options

Hi, I'm trying to use this hook but developing locally I get INTERNAL SERVER ERROR and header x-cache: Error from cloudfront when I tried to submit the POST request.
And also, we don't have any property to send the hCaptcha, reCaptchat, etc.

Hello,
Can you send a snippet of your code, please?

Closing this, since you already opened an issue here: https://github.com/formspark/documentation/issues/101
Captcha properties are simply to be sent along in the body.


New persons merging

This incorporates the same mechanics as were introduced in events merging recently.
Fixes #673.

Looks good (there's a lot of duplication in the forms, but I guess
that's inevitable).  I won't be able to set up and run an instance
locally for testing until I'm back in Toronto next week.

@gvwilson sure. I'll probably merge it soon and just fix if any errors should appear.


‼ Convert DS model

[ ] Review repeated use of self.stemmer = PorterStemmer() and likely replace by spacy's .lemma_
[x] Resolve: CoreNLP (used by the java code) creates one single root in the dependency tree. However, spaCy (python) can have more than one root.

Shrikant's DS model linked two sentences by joining their roots (one root per sentence) in addRootLinks. This is a critical design choice of the software. What do we do in the python-spacy code?
--> the only think I can think of a solution now is to cross link all roots, as in, e.g. {sent1_root1, sent1_root2} x {sent2_root1, sent2_root2) ==> {sent1_root1 x sent2_root1, sent1_root1 x sent2_root2, sent1_root2 x sent2_root1, sent1_root2 x sent2_root2}
[x] Test
[x] Verify percentage of sentences that have more than 1 root (as it may be an exception, rather than the norm)

--> Somethings is better to just chill the fuck out 😝 Stats for all DS edges:

8896 ----- 1    i.e. 0.9991015274
   8 ----- 2    i.e. 0.0008984725966

[x] Link combination of Different Sentences

[ ] Test combination of Different Sentences

[ ] Implement all features, see in Mapping by Madhukar

Must take care of at least following attributes to accomodate relationships concerning TWO DIFFERENT sentences:

[x] Edge
[x] label_edges
[x] form_predicted_relations

DS == Different Sentence model
As of now, LocText is semi-implemented in relna repository. It only uses a SS (Same Sentence) model.
We want the combination of the two SS and DS models, which together output better performance.

Original Java code defines head token (of an entity) with a own-calculated score and it's not the first token

Stop as of now -- All current progress directed to master the SS
Overall progress continues in #11


Can we record the current JS state in to error report?

Dear Author,
This plugin is working perfectly. Only thing I am wondering is can we record Javascript state in the part of error message as well? Otherwise it is hard to find out with just the title line of error message.
Thanks

Hey @opp100 By JS state, do you mean the stack trace ?

Hey bro, I have look at the stack. I think that is unreadable, because when we building the project all the JS file has been combined into one. The line code just like the faked. Thus I just wondering if we could report the current Javascript state, such as 'this.state' , that might be helpful for understanding what happened in specific view.

Hey @opp100 . Since this module provides you with a callback on error .You can always access your current redux state . But it would be difficult to do that with the component state.

@master-atul You mention that there is a callback on error, is there an example of passing state to this?

No, there is no redux state example . But it should be fairly straight forward. The place where you initialize redux store with createStore, you just set your js and native error handlers and in the callback put store.getState() . I think that should do the trick.


Using a variable "url"

Hey thanks for making this. I was wondering if there is a way I can do like:
{% youtube video.watch %}

rather than just fixed strings.
I hope it's possible.

Good question. I've not tested it myself, but if you are in a position to do so, please let me know how it turns out. You need to supply only the video ID, not the full URL.
On Sun, Oct 02, 2016 at 3:06 PM Pascal van Kooten
<
mailto:Pascal van Kooten<EMAIL_ADDRESS>
wrote:

a, pre, code, a:link, body { word-wrap: break-word !important; }
Hey thanks for making this. I was wondering if there is a way I can do like:
{% youtube video.url %}
I hope it's possible.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly,
https://github.com/pibby/jekyll-youtube/issues/2
, or
https://github.com/notifications/unsubscribe-auth/ADxx09MPzrKdMInnh8HLXKPk2jqhW_3hks5qwA6ogaJpZM4KMGgn
.

It's not possible, I tried it. I think I found out you would have to include it in the template somehow to do it (expand the variable there). Anyway thanks, I don't think it is conveniently possible.

Ok, thanks for checking it out, much appreciated.
On Wed, Oct 05, 2016 at 12:55 PM Pascal van Kooten
<
mailto:Pascal van Kooten<EMAIL_ADDRESS>
wrote:

a, pre, code, a:link, body { word-wrap: break-word !important; }
It's not possible, I tried it. I think I found out you would have to include it in the template somehow to do it (expand the variable there). Anyway thanks, I don't think it is conveniently possible.
—
You are receiving this because you commented.
Reply to this email directly,
https://github.com/pibby/jekyll-youtube/issues/2#issuecomment-251749635
, or
https://github.com/notifications/unsubscribe-auth/ADxx0_yZqPKjDadRtHs2TFpAV6OIqvtlks5qw-SagaJpZM4KMGgn
.

You can do it with this code:
# Jekyll - Easy Youtube Embed
#
# Katie Harron - https://github.com/pibby
#
#   Input:
#     {% youtube Al9FOtZcadQ %}
#   Output:
#

#

#
#

#

module Jekyll
  class Youtube < Liquid::Tag
    @url = nil

    VIDEO_URL = /(\S+)/i

    def initialize(tag_name, youtube_id, tokens)
      super

      @youtube_id = youtube_id
    end

    def lookup(context, name)
      lookup = context
      name.split(".").each {|value| lookup = lookup[value]}
      lookup
    end

    def render(context)

      if lookup(context, @youtube_id) =~ VIDEO_URL
        youtube_id = $1
      end

      source = "
"
      source += "
"
      source += ""
      source += "
"
      source += "
"
      source
    end
  end
end

Liquid::Template.register_tag('youtube', Jekyll::Youtube)


InvalidClientTokenId: The security token included in the request is invalid.

*** Expected behaviour:**
Create the Facebook-messenger bot
*** What actually happens:**
After exectuting claudia create --region us-east-1 --api-module bot. I've received the error
[InvalidClientTokenId: The security token included in the request is invalid.]
*** Which bot engine (facebook, skype...):**
Facebook
*** Link to a minimal, executable project that demonstrates the problem:**
https://github.com/thierryskoda/claudia-facebook-bot-example
*** Steps to install the project:**
npm install
*** Steps to reproduce the problem:**
execute claudia create --region us-east-1 --api-module bot
*Screenshot

does the AWS profile you run this under have access to IAM?

Hum how can I know that? I'm really beginner with AWS

is the profile you are using for AWS a main account or a sub-account with restricted privileges? Check out https://claudiajs.com/tutorials/installing.html (the part about setting access credentials) to see where AWS SDK looks for profile info

Oh Thank you very much!  It works right now. Those tutorials help a lot!


Make->CMake migration

The repo currently has two build systems which are partially overlapping: Makefile-based and CMake based. To some extent this also applies to submodules: rabit and dmlc-core. Clearly this is no good. The build should be consistent, otherwise it would be confusing both for the users and developers.
Having worked on a cross-platform XGBoost build I strongly prefer CMake, which (usually) is more robust in that setting. However, if core developers/other contributors prefer Makefiles, I'd be fine with that too. And one more thing: the options are surely not mutually exclusive. We can agree on using CMake for core build logic and Makefiles for all the wiring (although going that way could cause some issues on vanilla Windows).
Here's a sketch of Makefile-based build features currently absent in the CMake build:

Configurable rabit backend.
Gtest support.

What do you think?

I support the eventual deprecation of the makefile build system in favour of cmake.

@RAMitchell I've spotted that GPU plugin already uses GTest. Can you generalize it to all of the XGBoost tests?

I will look into it.

i think we will be keeping both atm. I like cmake, and I am all for a full fledged cmake support. but sometim s it is good to have makefile as an alternative

To summarize my points:

It seems to be easy to maintain Makefile system (at least for linux users)
We would advocate CMake for windows users, and it would be great if CMake covers linux case as well
If the cost of maintenance is minimum(around 100-200 lines of Makefile), i prefer to maintain the make build system, but we can remove that if it becomes a burden eventually

Any updates on this issue? It would be more user friendly to have a single build system (=cmake) instead of two parallel build systems which are slightly different.

I think we would have to go with two build systems for reasons @tqchen outlined above, so I'm afraid there isn't much room for updates.

Having two different build systems is super confusing. I've been building and rebuilding XGboost for some time now, and while hunting down performance differences between my environments, I noticed that building the JVM package rebuilds the core library as well which I had built using make. Clearly the library build from cmake did not produce the same library as make due to differences in compiler and linker settings trying to get XGboost to use MKL. Yes, it's all possible in theory but harder than necessary in practice. No sense in making everything that much more complicated for 99% of the users for the sake of 1%.

Yes, it's all possible in theory but harder than necessary in practice. No sense in making everything that much more complicated for 99% of the users for the sake of 1%.

Sorry, could you clarify the final point, please: are you referring to maintaining two build systems or something else?

@superbobry Yes I was referring to maintaining two build systems. Not that I've contributed to it myself so I shouldn't be talking but if the reason to keep make around is only to support platforms cmake doesn't support then we're really talking about 1% of platforms out there .