Environment config tutorial

The goal here (and for all the tutorials) is to utilize tabs to switch between linux/osx/windows commands. I'm still trying to find a sphinx tabs extension that works.
In the mean time, it'd be good to know what the equivalent commands are in osx and windows for the commands on lines 40, 52, and 64.
Another question I have is about switching distros on osx and windows. The tutorial mentions that one of the benefits of sourcing setup files is how easy it makes it to switch between distros. However, just looking at the installation guides for osx and windows, the sourcing commands don't mention the distro.
linux: source /opt/ros/<distro>/setup.bash
osx: . ~/ros2_install/ros2-osx/setup.bash
windows: > call C:\dev\ros2\local_setup.bat
Also wondering if the advice on line 74 (to retry the installation guide if your environment variables aren't set) makes sense.
And any other general feedback is appreciated.
Signed-off-by: maryaB-osr<EMAIL_ADDRESS>

Another question I have is about switching distros on osx and windows. The tutorial mentions that one of the benefits of sourcing setup files is how easy it makes it to switch between distros. However, just looking at the installation guides for osx and windows, the sourcing commands don't mention the distro.

The reason that this doesn't really show up on Windows on macOS is because neither our packaging nor our from-source instructions embed the distribution name.  We should probably update those instructions to do something like:
macOS:
Extract to ~/ros2_dashing/ros2-osx

Windows:
Extract to C:\dev\ros2_dashing

One general comment I have: is it at all possible to get a preview of what these will look like "live"?  It would just make reviewing them easier.  Thanks.
I'll do a review of the actual changes as best I can without it.

Note, I cherry-picked #336 to here, just to verify Heroku behavior.

I was trying to apply this tutorial to everyone (all platforms) but I'm just going to go with the route @jacobperron suggested and assume Linux + installed from debians. So that means we don't need all the macOS and Windows commands as well.

Something that might be worth mentioning in this tutorial is the significance of the variable ROS_DOMAIN_ID.
It is important to set in order to avoid interference between multiple hosts on the same network.
You can read a bit about it in this obscure section of our documentation: https://index.ros.org/doc/ros2/Contributing/ROS-2-On-boarding-Guide/#choose-a-dds-domain-id

Something that might be worth mentioning in this tutorial is the significance of the variable ROS_DOMAIN_ID.
It is important to set in order to avoid interference between multiple hosts on the same network.
You can read a bit about it in this obscure section of our documentation: https://index.ros.org/doc/ros2/Contributing/ROS-2-On-boarding-Guide/#choose-a-dds-domain-id

Oh yeah, this is a good idea.  I think this should be added.

ROS_DOMAIN_ID.

Is it necessary to use ROS 2? It seems a little advanced. I will add it, but can I put (advanced) in the heading?

Honestly, I preferred your previous plan of making tabs for Linux, macOS, and Windows.

I agree that it's not the best idea, and I revoke it, but I think it's a big problem that some of the Windows solutions are basically just "google it". I can try to come up with a way to make it more tactful though. I was also worried about having more and more shortcomings like that pop up throughout the rest of the tutorials.

I agree that it's not the best idea, and I revoke it, but I think it's a big problem that some of the Windows solutions are basically just "google it".

I totally agree that we shouldn't put "google it" into the tutorials.  My previous comments to this effect were more along the lines of "somebody needs to do more research here to figure out what the correct solution is".  And I think we should do that research before releasing the tutorial.

Is it necessary to use ROS 2? It seems a little advanced. I will add it, but can I put (advanced) in the heading?

It's necessary if you are on a network with multiple people using ROS 2, otherwise your turtle in turtlesim might move around unexpectedly if someone else is doing the tutorials at the same time as you :D
I think it's worth suggestion something like, "if your lab or office has multiple computers running ROS 2, you should coordinate with your colleagues in selecting different domain IDs".

The reason that this doesn't really show up on Windows on macOS is because neither our packaging nor our from-source instructions embed the distribution name. We should probably update those instructions to do something like:

@clalancette which repo would be a good place to make an issue about this?

@clalancette which repo would be a good place to make an issue about this?

The from-source instructions would be in this repository, in https://github.com/ros2/ros2_documentation/blob/master/source/Installation/Dashing/ (and the other versions).
The packaging one is trickier.  It may also be the case that we just fix this with documentation in this repository.  For instance, in https://index.ros.org/doc/ros2/Installation/Dashing/Windows-Install-Binary/#downloading-ros-2 where we say "Unpack the zip file", it might be better to assume C:\dev\ros2-dashing to be more specific.  The same goes for all of the instructions for binary archives.

@clalancette @jacobperron
I addressed your comments but I'm not sure if I worded things correctly, would appreciate another review :)


Add device multiplex to nightly tests

Issues:
Fixes #594 #596 #597
Problem: We support a range of devices.  Our nightly infrascture
needs to automatically test each of these devices.
Analysis: I added the changes to the Makefile following the
architecture swormke used in the f5-openstack-lbaasv2-driver repo
which was itself following the practices developed by the velcro
team.   The entrypoint into the nightly build process is that
the buildbot worker container runs (the equivalent of):
cd f5-openstack-agent/systest && make functest
Tests:  The new code was tested by running the above in an
appropriate environement (testenv generated stack on the "lab"
openstack cloud).  This correctly caused 4 separate runs of the
same tests.  Undercloud tests were not relevant for these tests
so the 4 undercloud RULEs simply echoed their names.

Do the targets in #### TESTSBYINFRA SECTION still work as they intended? Or are they run in the nightly?  The reason I am asking is because of the $TEST_RESULTS comment that Matt has above.  It looks like those are just dumping their results into the ./test_results/ directory where as the $(DEPLOYS) targets are dumping them into a deeper directory structure.
export GUMBALLS_PROJECT=$(PROJNAME)_$(BRANCH)-$@ &&
export RESULTS_DIR=$(RESULTS_DIR)/$${GUMBALLS_PROJECT} &&

Just want to make sure that the results/projects structure is right for these tests after the changes for the multiple deployment options.

@mattgreene does this really need over/undercloud iterations? Seems like the issues listed above only talk about versions and the internal Agile board seems to do the same in the headline but the DoD indicates something different. It is fine either way, just wanted to make sure that we are not chewing up cycles at night for topologies that are not required.

Per @swormke 's comment, the difference between the output in the "functest" RULE and the "$(DEPLOYS)" RULEs is that the "functest" RULE only runs unit tests.   These tests should not vary when the device or cloud changes, so those tests do not include that information in their GUMBALLS PROJECT.
If a test is labelled "unit" and it is sensitive to one of those variables it should be renamed (moved) into a functional test.

@pjbreaux example GUMBALLS_PROJECT names:
disconnected_singlebigip_f5-openstack-agent_liberty-12_1_1-overcloud
singlebigip_f5-openstack-agent_mitaka-11_6_0-overcloud
f5-openstack-agent_mitaka-unit
NOTE:  "unit" GUMBALLS_PROJECTs do not include device version or cloud type as this information shouldn't be relevant to unittests
example GUMBALLS_SESSION (parsed apart by gumballs) names:
v8.0.1-434-g5d0c106_20170301-204408

I'm accepting the PR per verbal approval from @richbrowne.


Create JRE builds

I have seen there have been some pulls to allow JRE builds, but I cannot download them. Can you build JRE versions, please?
I'd like to create a MSI setup for JRE asap.

@alexhass Which JRE's are you not seeing?  openjdk11-binaries repo has them for 11...

Oh - I looked only at https://adoptopenjdk.net/
https://github.com/AdoptOpenJDK/openjdk11-binaries/releases/tag/jdk-11%2B28 looks good.

If not for this ticket, I would have never found the JRE downloads. I think the JRE releases should be offered at https://adoptopenjdk.net/

I'll open a website ticket

Any updates? or if there are guides on how to build a .msi off the JRE publised on the site...
I found this guide: http://hg.openjdk.java.net/jdk8/jdk8/raw-file/tip/README-builds.html
but was wondering if it is applicable

Any updates? or if there are guides on how to build a .msi off the JRE publised on the site...
I found this guide: http://hg.openjdk.java.net/jdk8/jdk8/raw-file/tip/README-builds.html
but was wondering if it is applicable

The work to build MSI is over at openjdk-installers repo.


Allow custom ModelAdmin classes to be used to represent flat and main menus in the wagtail admin

With an aim to making it easier to do things like #242, this can be easily achieved by using new app settings.

Implemented in  546e3da. Will close this issue just before releasing 2.11


[BUG] change LinkFree images in GitPod guide to BioDrop

Has this bug been raised before?

[X] I have checked "open" AND "closed" issues and this is not a duplicate

Where did you find this bug?
product on BioDrop
Version of BioDrop (for example "v1.2.3")
2.84.4
Description
For a new person, who wants to try the GitPod route for BioDrop, could find the 'GitPod' instructions confusing, because the following steps to create the BD profile refers to 'LinkFree' in the images and not BioDrop, in following the instructions:
https://www.biodrop.io/docs/environments/gitpod
step 02: url implies this will be 'LinkFree'; not BD
step 03: New Workspace: refers to '/LinkFree'
step 04: VSCode says 'LinkFree' directory, not BG
step 02: Workspaces: references LinkFree in all links, not BG
See screen images below
I checked the 'Issues' by searching for 'gitpod'
Screenshots

Do you want to work on this issue?
Yes
If you want to work on this issue...
Proposal:
Update the images of the instructions to reflect 'BioDrop' instead of 'LinkFree'
This then negates any ambiguity.

Thank you for raising, I have assigned this issue to you

Hi @goobric how are you getting on?

hi @SaraJaoude , I hope that you and Eddie, had a comfortable boat ride  :-) how is Eddie feeling now?
Sorry that I did not see that this issue had been assigned to me! I am not sure why a notification didn't pop up on my GH account.
? Are there specific images that you would like me to use for the solution?

Are there specific images that you would like me to use for the solution?

Not much Ig, your screenshots should be of Good quality & in Light mode to be consistent with the whole documentation.

hi SaraJaoude , I hope that you and Eddie, had a comfortable boat ride :-) how is Eddie feeling now? Sorry that I did not see that this issue had been assigned to me! I am not sure why a notification didn't pop up on my GH account. ? Are there specific images that you would like me to use for the solution?

Hi @goobric it seems we were super lucky with the ferry ride for this time of year and there were no waves! 😅 Eddie is finally on the mend. Thank you for asking!
I've checked the documentation section for Gitpod and it does not seem that there are any specific images which you would need from mine or Eddie's account. I would suggest that you follow the guide and create new images as you go along.

hi @amandamartin-dev thank you for your message.
I am unable to sign up to BioDrop via the GitPod method; even though I have tried on many occasions. Therefore I am unable to screen print the up-to-date images of BioDrop with GitPod that would be required for the documentation.
Sorry I wasn't able to complete this task!
Please assign this to someone who is able to sign up to BioDrop via the GitPod method; who can then create up-to-date images required for the documentation.

hi @amandamartin-dev thank you for your message. I am unable to sign up to BioDrop via the GitPod method; even though I have tried on many occasions. Therefore I am unable to screen print the up-to-date images of BioDrop with GitPod that would be required for the documentation. Sorry I wasn't able to complete this task! Please assign this to someone who is able to sign up to BioDrop via the GitPod method; who can then create up-to-date images required for the documentation.

I'm sorry to hear that this hasn't worked for you. I use gitpod to review PRs and dev on BioDrop so if you would like some help sometime with this, lmk! I am in the Discord community.  Perhaps the documentation can be better to help others too if we figure out where you are getting stuck.
I will unassign for now. Thank you for letting me know.

Hi, I have gone through this issue and I think I can resolve it. Please, assign it to me.
Thanks.

Hi, I have gone through this issue and I think I can resolve it. Please, assign it to me. Thanks.

@dominic-source I have assigned this to you.

Thanks.

Hi @SaraJaoude , I have successfully created the images that are required to update the gitpod issue images. But I need explanation on where I would upload the images so I can update the URL links on the gitpod source code. Can you please provide directions.
Thanks.

Hello @dominic-source. I think you need to update this file: pages/docs/environments/gitpod.mdx; replacing the screenshots with the new ones you took. This would then update the docs (at https://www.biodrop.io/docs/environments/gitpod), reflecting the changes.

Hi SaraJaoude , I have successfully created the images that are required to update the gitpod issue images. But I need explanation on where I would upload the images so I can update the URL links on the gitpod source code. Can you please provide directions. Thanks.

@dominic-source you can drag and drop them into a comment in this issue (please submit your comment) and GitHub will generate the URL for you to use in the MDX file.

Thanks so much, I really appreciate the support. I will forward the images and make the updates.


[BUG]: Console error when starting A1111

Is there an existing issue for this?

[X] I have searched the existing issues

Bug Description
Error loading script: better_styles.py
Traceback (most recent call last):
File "H:\stable-diffusion\extensions\sd-webui-better-styles\scripts\better_styles.py", line 119, in get_git_command
subprocess.run([git, "-v"], cwd=EXTENSION_ROOT, shell=True, stdout=subprocess.PIPE, stderr=subprocess.PIPE,
File "H:\stable-diffusion\python\lib\subprocess.py", line 526, in run
raise CalledProcessError(retcode, process.args,
subprocess.CalledProcessError: Command '['git', '-v']' returned non-zero exit status 1.
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "H:\stable-diffusion\modules\scripts.py", line 263, in load_scripts
script_module = script_loading.load_module(scriptfile.path)
File "H:\stable-diffusion\modules\script_loading.py", line 10, in load_module
module_spec.loader.exec_module(module)
File "", line 883, in exec_module
File "", line 241, in _call_with_frames_removed
File "H:\stable-diffusion\extensions\sd-webui-better-styles\scripts\better_styles.py", line 436, in
initialize()
File "H:\stable-diffusion\extensions\sd-webui-better-styles\scripts\better_styles.py", line 428, in initialize
get_git_command()
File "H:\stable-diffusion\extensions\sd-webui-better-styles\scripts\better_styles.py", line 123, in get_git_command
subprocess.run([git, "-v"], cwd=EXTENSION_ROOT, shell=True, stdout=subprocess.PIPE, stderr=subprocess.PIPE,
File "H:\stable-diffusion\python\lib\subprocess.py", line 526, in run
raise CalledProcessError(retcode, process.args,
subprocess.CalledProcessError: Command '['git\cmd\git.exe', '-v']' returned non-zero exit status 1.
Steps to Reproduce
After installing the extension and rebooting A1111, an error appears in the console.
Screenshot (optional)

This extension has built-in version checking using Git. It's checking for Git by trying to run "git -v". Git no longer has the "-v" shorthand for "--version", so returns a nonzero exit code indicating that an invalid option was sent.
A dirty fix is to just replace that -v on lines 119 and 123 with the proper "--version".
I would argue as the proper fix that the version checking should be removed entirely, as A1111 already has it built-in.


[WIP][TIR] Add support for 0-dim buffer

This PR intends to add support and test cases for 0-dimensional buffer in TVM.
cc: @junrushao1994 @vinx13 @zxybazh

given we have 0-rank support in TIR, we can remove these lines to directly lower to 0-rank TIR https://github.com/apache/tvm/blob/main/src/te/operation/create_primfunc.cc#L105-L109. Please check if we can pass this test case https://github.com/apache/tvm/blob/main/tests/python/unittest/test_te_create_primfunc.py#L286-L300

Overall LGTM, please address comments and get it merged soon


Conflicting chdir

I keep getting warning: conflicting chdir during an other chdir block when I run my tests. This is swallowing any test output. It's coming from lib/ember-cli/app.rb:250.
Seems like a race condition? Seems exec(cmd, method: :spawn) is getting called multiple times. This is a little strange as to my knowledge my app server isn't making multiple threads and I only have one client app.
What application server are you all using?
Will report back once I've found the source.

Hm, that's interesting. spawn call should only happen once and only in dev environment. It shouldn't even happen in test. Are you using unicorn with multiple workers by any chance?

@rwz Nope. Using capybara-webkit. I'll do some more debugging tomorrow.

Seems to be related to some bizarre test setup code. Closing.

Let us know if you figure that out.


privacy-center/config: Use typed constant to ensure modifying the config is typesafe

Fixes: thread
Code Changes

Instead of importing the JSOn config directly, app code imports the typed constant.
A couple places didn't handle potentially-missing actions, just needed some empty checks.

Steps to Confirm

Set config.son > "actions"  to an empty array
Run npm run build -> should build
Serve the built privacy center (npm run cy:start for example)
Only the "Manage your consent" section should show.

Pre-Merge Checklist

[ ] All CI Pipelines Succeeded
Documentation Updated:

[ ] documentation complete, or draft/outline provided (tag docs-team to complete/review on this branch)
[ ] documentation issue created (tag docs-team to complete issue separately)

[ ] Issue Requirements are Met
[ ] Relevant Follow-Up Issues Created
[ ] Update CHANGELOG.md

Description Of Changes
Write some things here about the changes and any potential caveats

Thanks for the quick work here @ssangervasi


example nats-operator-cluster-scoped is missing serviceaccount

When deploying the example nats-operator-cluster-scoped.yaml the replicaset shows the error: Error creating: pods "nats-operator-7b44c857bb-" is forbidden: error looking up service account nats-io/nats-operator: serviceaccount "nats-operator" not found.
The serviceaccount is indeed not present in the example.
After adding the serviceaccount the deploy succeeds:
apiVersion: v1
kind: ServiceAccount
metadata:
  name: nats-operator
  namespace: nats-io

Ooof, I now see that it is present in nats-operator-cluster-scoped-rbac.yaml 😳


Cannot setup country/region for DST account

ads.huawei.com_5_18_2022.har.zip

I am not HQ, I cannot read or undersstand .HAR files.

DTSE requests this issue to be resolved for his App Life Cycle feature.  This is the log file for HQ to debug.  HQ  investigation is in progress. No worries.

I've confirmed that these fiiles can be passed to HQ with no issue.


Automated release is broken but works manually

Something is wrong with the publish CI step. It seems to fail at :core:dokkaHtml, but running that locally works fine.

Seems to be related to using Kotlin 1.9.0

#3 Reverts kotlin to 1.8.20 for Compose Multiplatform, so hopefully that will fix it for now.


mix.exs specifies 'or ~> 1.4' which does not match '1.4.0-rc.0'

mix.exs specifies 'or ~> 1.4' which does not match '1.4.0-rc.0', as seen when trying to mix deps.get
Failed to use "phoenix" (version 1.4.0-rc.0) because
  phoenix_live_reload (version 1.1.7) requires ~> 1.0 or ~> 1.2 or ~> 1.3 or ~> 1.4 *
  mix.exs specifies ~> 1.4.0-rc.0

I literally just pushed 1.1.7 which fixes this! :D Thank you!!!

I think this is still an issue @chrismccord :P
or ~> 1.4 doesn't match ~> 1.4.0-rc

https://github.com/phoenixframework/phoenix_live_reload/blob/master/mix.exs#L39

Yeah are right, sorry :)

I have updated the upgrade guides to instruct {:phoenix, "~> 1.4.0-rc", override: true}. Thank you!

No, no! Thank you :)

We are planning on fixing this in hex: https://github.com/hexpm/hex/issues/613


OBIS and HSBC move to PDF-only Statements

Until the end of 2020, there was a nice screen which OBIS would parse but that screen has been replaced and now the only way to view previous statements is to download the PDF.  I noticed you've done a lot of re-writing of OBIS. Is there a better place to view statements so that OBIS can parse them?  Prhaps amend the README.md to provide more detail as to where exactly to go (maybe I'm missing it).
"Midata" is now available for download (see: https://www.hsbc.co.uk/current-accounts/midata-faqs/) but for some reason, they censor half of the payment type details, so you get a CSV full of asterisks... And so Online Banking continues to be S***.
As always, appreciate your creating OBIS! 😊

Folks don't like the asterisks in midata... I wonder why?!
https://twitter.com/HSBC_UK/status/918790518905110528

Hey Lester,
OBIS now works on any page. :)
The best way to use it now as a Chrome Extension.
Instructions are in the README, but I will paste here in case I update that file in the future:

To build it yourself:

Download the project from Github
Navigate to: chrome://extensions/
Enable Developer mode [ o ]
Click the [ Load unpacked ] button
Choose the downloaded dist/extension/ folder

You'll see the OBIS interface after logging-in to your HSBC account.

OBIS will find all accounts first, then statements, then entries for all statements. It might take some time, but there is a progress-bar now (it's not perfect -- the last 1% might take a few seconds.)
OBIS will also create a midata CSV without asterisks. To me it's crazy that your own data is censored after downloading it. I mean, if you can see it clearly before downloading, or in the PDF, what is the point of adding asterisks to midata only?
Hope this is helpful. Let me know if it works for you!

Hey @shuckster
Just adding to this as I may have an issue using the chrome extension method.
The extension pops up and gatherers the statement however the View statements & Download all buttons are greyed out.
Is this an issue or am I doing something wrong?
Thanks and really appreciate your work!

Hi @Banjanki ,
If downloading many years of transactions, it might be that the progress-bar "freezes" at the last 1% for a long time while it creates the Zip file. Perhaps try downloading just 1 year to see if the buttons become active in this case?
I'm thinking about including the Zip generation in the progress-bar to give the impression that something is still happening when many years of statements are being created. It takes long enough that it can seem like OBIS has broken.
Still, the buttons should still become "active" eventually. Perhaps open the Chrome Developer Tools + Console to see if you get any errors from OBIS before you hit the "Fetch" button?

Thanks for getting back to me @shuckster
It's strange, I don't see any errors on the console. Only when HSBC times out. i waited about 5 minutes while keeping HSBC from timing out. Could be an issue on my end. I'll try and reinstall the extension.
I was going to try the other manual method but I'm not clued up enough to understand the readme for that method when trying to host locally.
Thanks for your help!

Sorry to hear you're still having problems @Banjanki .
It's true that the second method is a little trickier, but I don't think trying it would solve your problem. It loads the exact same code as the Extension version does, although in a slightly different way of course.
Let me know if reinstalling the Extension works. If not, let me know your Chrome version and which Operating System you're using, and I'll see if I can replicate the problem.

Hi @shuckster,
I've been trying to get OBIS to work with the nightmare that is HSBC's online interface (stopped using accounts long ago, just want data for record-keeping), and despite repeated attempts have never got past the installation of the extension - OBIS never shows up on the online banking webpage, regardless of the method used to 'run' it - I can get it to appear at localhost:4000, but that's it. I noted that the statement download page (same PDF version as mentioned here) now has a web address of https://www.hsbc.co.uk/online/customerstatements/, rather than anything matching the default https://*.online-banking.hsbc.co.uk/*. I've tried adding https://*.hsbc.co.uk/online/* to the .json and .js files to no avail, but not being a Chrome extension developer, I may well be looking in the wrong place entirely.
It's by no means urgent, but I'd appreciate any help in getting my data out before anymore of the 6-year history is lost.

Thanks for the report @QuicksilverBR .
It seems HSBC have once again updated their APIs, deprecating the old one that OBIS was using to download transactions, which is why merely updating the URLs will not make it work. 404s now exist where the old APIs used to be.
After an initial investigation I can see that it's not an insurmountable problem to update OBIS to work with the new APIs. But it will take a little time to figure out how to update everything accordingly.

Hi @QuicksilverBR
I've added a new plugin that supports the new HSBC UK API. Please try it out and let me know if the numbers come out right for you. It's working for me as far as I can tell.
There is one regression: You can no longer choose how many years of history you want. For my own accounts, OBIS will download about 6 years worth of data, and it doesn't take very long. (There is a short pause before the View/Download buttons become available, just so you're aware.)
It may be possible to download data from further back, but I've not investigated this much yet. However, the state I've got OBIS to now seems good enough to be useful, so thought I'd share.
Hope it works!

Thanks @shuckster; just tried it out and OBIS seemed to grab all the statements HSBC presents to me, but in a variety of actually useful formats!
I don't have time to fully check the results tonight, but a brief skim shows that all the data should be there. I'll get back you (hopefully!) tomorrow to confirm.

I don't have time to fully check the results tonight, but a brief skim shows that all the data should be there. I'll get back you (hopefully!) tomorrow to confirm.

Alright; I've had a quick look, and most of the history is indeed there. Cross-referencing the data (I've been using CSVs imported into KMyMoney), there are some transactions missing, but these are mainly gross interest listings (the savings account in question has been open a long time - it's changed account types a few times, so not really a surprise.)
It's certainly more than enough to get started with - rather than entering six years of statements by hand, I only have to make a few corrections here and there. Thanks for the update; hopefully HSBC leave the layout alone this time!

Thank you for getting back to me. It's encouraging to hear that most transactions made it, although I'm curious to find out why some are missing! Seems like OBIS should process everything HSBC gives. 🤔  I'll give it another look hopefully at the weekend again. And yes, it would be great if this website update could be the last one for a while. 🤞

I'll close this issue for now as I've not encountered the "missing-transactions" problem myself in these months since the report. Happy to reopen/investigate if it reoccurs.


Error installing Plugin after adding in Experimental

as suggested Reboot has been done but same error pops up

You must've missed the big red text from Dalamud saying it hasn't been updated for Dawntrail yet.

does not show it on my screen


[add] gws/affair

Coverage decreased (-1.3%) to 82.733% when pulling 639375d2161b66d6b52163b8855add5a7e6a4da6 on affair5 into 8417c83337d054605477dce4d49f5f307bb3edef on master.


Add Powered by eBPF Logo.

This patch adds Powered-By-eBPF Logo to the Readme.rst.
This is based on the feedback received on PR-33982. Thanks to Quentin Monnet for the suggestions and logos. This patch is to support eBPF Logo trademark application by eBPF Foundation.
Please ensure your pull request adheres to the following guidelines:

[ ] For first time contributors, read Submitting a pull request
[ ] All code is covered by unit and/or runtime tests where feasible.
[ ] All commits contain a well written commit description including a title,
description and a Fixes: #XXX line if the commit addresses a particular
GitHub issue.
[ ] If your commit description contains a Fixes: <commit-id> tag, then
please add the commit author[s] as reviewer[s] to this issue.
[ ] All commits are signed off. See the section Developer’s Certificate of Origin
[ ] Provide a title or release-note blurb suitable for the release notes.
[ ] Are you a user of Cilium? Please add yourself to the Users doc
[ ] Thanks for contributing!

Fixes: #issue-number
<!-- Enter the release note text here if needed or remove this section! -->

I think a cc @qmonnet is warranted, given he has looked into this in detail.

/test

BPF checks (checkpatch) complains because the author email is different than the one used in the sign-off-by tag, this is fine to ignore.

Unfortunately ci-ginkgo will not pass until you rebase onto latest main, due to https://github.com/cilium/cilium/pull/35193.

@bimmlerd should I do "update branch" (update with merge commit?)

@sknrao Better to do "Update with rebase" instead.

/test


Mod Assistant Startup Bug

All I did was download and start up the app and this appeared

I clicked ok to try to fix the issue but I'm not sure what to do when this pops u

I tried hitting save on right away, while in a folder, and a few other ways but I still couldn't get Mod Assistant to run

You have to be inside the Beat Saber folder, try navigating down inside it, and then clicking Save.

Stale


Update zh translation in  service-catalog.md

Update zh translation in  service-catalog.md

/lgtm
The English upstream has an additional change where the existing translation still makes sense.

see
$ ./scripts/lsync.sh content/zh/docs/concepts/extend-kubernetes/service-catalog.md
diff --git a/content/en/docs/concepts/extend-kubernetes/service-catalog.md b/content/en/docs/concepts/extend-kubernetes/service-catalog.md
index 3aa967578..af0271d9a 100644
--- a/content/en/docs/concepts/extend-kubernetes/service-catalog.md
+++ b/content/en/docs/concepts/extend-kubernetes/service-catalog.md
@@ -26,7 +26,7 @@ Fortunately, there is a cloud provider that offers message queuing as a managed

 A cluster operator can setup Service Catalog and use it to communicate with the cloud provider's service broker to provision an instance of the message queuing service and make it available to the application within the Kubernetes cluster.
 The application developer therefore does not need to be concerned with the implementation details or management of the message queue.
-The application can simply use it as a service.
+The application can access the message queue as a service.

The English upstream has an additional change where the existing translation still makes sense. I  agree
so /approve

/approve


Add UI tests

Questions
Answers

Description?
Add docker compose for UI tests

Type?
refactor

BC breaks?
no

Deprecations?
no

Fixed ticket?
no

Sponsor company
@PrestaShopCorp

How to test?
no need

Steps

[x] Install PS with specific PS & PHP versions with Docker
[x] Install autoupgrade in CLI
[x] Upgrade in CLI
[x] Sanity Tests with ui-testing-library
[x] Check version DB

(In next PRs, we will update the matrix)

Hello @nesrineabdmouleh!
This is your first pull request on autoupgrade repository of the PrestaShop project.
Thank you, and welcome to this Open Source community!

@Progi1984 don't forget the milestone when merging a PR 😉


Connectivity issues

Im really new to pi, and only bought one for this project.
I bought a Raspberry Pi W
I've got it connected to my tv, but it doesnt seem to connect to my wifi. I have a router and inputted the wifi and password in the settings using a microSD card. If anyone can help or I should just buy a new pi lmk. Im struggling hard.
side note: i also tried connecting it to ssh just using raspbian but that was no go, maybe since im not sure what im doing
Twitter: RadioPi1
Ill give you $20 if you help me solve this issue. Ive tried for 2 days (but maybe u can do better since i suck)

First can you run through http://docs.pimusicbox.com/en/latest/troubleshooting/ and also try setting the wifi region setting. You will also need to provide information on the type of WiFi network you have.
We don't accept donations.


Implement blacklist for specific entities

This would allow you to specify only certain derived instances be included in listing/teleporting, or the opposite. This could be required for potential cross-mod interaction where something derives from AbstractHorse but should not be considered (but may implement isHorseSaddled()).

The framework for this basically already exists and can easily be done.

As it stands, new entities need to be added specifically by proxy. Outside of Animania, this excludes any mod that includes entities which are immediately rideable and do not allow ownership or taming of the creature in some way.
Hence, it should only be that entities can be blacklisted. All additional added entities outside of the scope of AbstractHorse (which should automatically be picked up), will require additional handling in the proxy system.

Specifically the global blacklist should be implemented in a way that makes it configurable from the UI.
Further to this, potentially implement a command similar to (or identical to) the one Horse Power has that shows you & copies onto the clipboard the name of the current entity you are facing.


Helm improvement

Description
helm improvement.

Add _helper.tpl and define functions for (Chart Name, etc.)

@evegufy : I got it. I've made the changes, thanks.

@evegufy : I got it. I've made the changes, thanks.

@tunacicek the templates look good to me now :+1:
Probably not related to the templates, but when installing locally (without any additional configuration) the readiness probes for the deployment are failing:

Other than the readiness probe, everything looks fine (pod starts up), at least as far I can tell.

@evegufy : Thank you for your feedback. I checkout the branch again and run it locally. In my case, the health checks (readiness, etc.) are running successfully. I can't reproduce the behavior. It may have taken a while for the service to start.

@evegufy : Thank you for your feedback. I checkout the branch again and run it locally. In my case, the health checks (readiness, etc.) are running successfully. I can't reproduce the behavior. It may have taken a while for the service to start.

@tunacicek I tested a bit more, besides on my mac also on my linux machine.
I didn't observe the behaviour on linux and noticed then that on my mac the container never had enough time to start up entirely before the probes were causing a restart.
As a short term measure, I recommend increasing the initialDelaySeconds for readinessProbe and livenessProbe to 300 seconds as that solved the issue for me.
And you should look into providing the image also for a arm64 cpu architecture, for better performance on newer macs.

@evegufy : Thank you for your feedback. I checkout the branch again and run it locally. In my case, the health checks (readiness, etc.) are running successfully. I can't reproduce the behavior. It may have taken a while for the service to start.

@tunacicek I tested a bit more, besides on my mac also on my linux machine. I didn't observe the behaviour on linux and noticed then that on my mac the container never had enough time to start up entirely before the probes were causing a restart. As a short term measure, I recommend increasing the initialDelaySeconds for readinessProbe and livenessProbe to 300 seconds as that solved the issue for me. And you should look into providing the image also for a arm64 cpu architecture, for better performance on newer macs.

@evegufy ,
for the image arm64 topic i will create a issue.
I made the values for readinessProbe and livenessProbe configurable.


FHOPS-4424 update pr templating for repository rhmap-backups.

https://issues.jboss.org/browse/FHOPS-4424

As per my previous comment, this repository is public so referencing Jira tickets in the subject header and description won't mean much to anyone outside of Red Hat. Perhaps you could use the template in this PR to update the description here :)

In that closing pr. Thanks @pmccarthy


[BEAM-5070] Disable resumeFromCheckpoint test due to flakiness

BEAM-5070
Test flakes in more than 5% of jobs.

Follow this checklist to help us incorporate your contribution quickly and easily:

[ ] Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

It will help us expedite review of your Pull Request if you tag someone (e.g. @username) to look at it.
Post-Commit Tests Status (on master branch)

Lang
SDK
Apex
Dataflow
Flink
Gearpump
Samza
Spark

Go

---
---
---
---
---
---

Java

Python

---

---
---
---
---

r: @tvalentyn, @pabloem
r: @akedin

run java postcommit

Is there a process to fix, review, and re-enable the disabled tests?

I believe we should utilize same process as with rollback.

I think the process would be that these test breakages are tracked by JIRA issues (BEAM-5070 in this case), and these issues should be closed only when the test is reactivated. I think it's worth tracking this internally in Google as well.

I think we should merge this PR and then fix the actual issue with the test.
But I am not sure what underlying problem the process you are describing solves right now and how. By creating a Jira the problem is moved to another place, potential underlying issue is not solved. And the process currently doesn't really help to investigate and solve it . Few problems I have with it:

I will probably forget about this issue unless it's trivial, and will forget to not push the code to this area;
I am not sure how much time I can / want to spend on this, and whether it will be better to spend it on this issue vs some other task;

I think we should extend the process a bit:

create a dashboard of disabled tests / jiras;
define some timelines, mark disabled tests as "green / young", "red / old";
send the dashboard to dev@ periodically, poke assignees (needs specific owner);
triage the dashboard / builds for new failures (needs specific owner);

One other approach I've seen is implementing the timeouts for the disabled tests. E.g. when disabling a test you set the deadline for the fix (specify it with an annotation). After this deadline the test starts failing, forcing someone to look at it.
Without extra visibility, tracking and poking people we will eventually have a pile of jiras no-one is looking at.

FWIW, internal google tracking @P1 will add pressure on Googlers who are reponsible for test fixes. But yea, that doesn't address fixing by contributors in other organizations.

run java postcommit

@akedin
I guess I misunderstood your question initally.
@alanmyrvold is currently working on dashboard plaform that we will use to show status for post-commit tests, Jira tickets, github PRs, etc.
I'm automating Jira tickets creation and working on basic triage guide, will post it to cwiki soon.
Please, check on design doc for set of actions to be implemented.

Thanks Anton


DownloadRequest with Http caching, 304 not modified

What did you do?

Uses DownloadRequest for a large file download.
It is working for the first time.
The second time, the server gives a 304 response because there's no modification on the file.

What did you expect to happen?
DownloadRequest handles the 304 code properly.

If with option .removePreviousFile,  DownloadRequest should do nothing.
If without option .removePreviousFile, Alamofire didn't throw any error.

What happened instead?

If with option .removePreviousFile,  DownloadRequest should do nothing.
If without option .removePreviousFile, Alamofire didn't throw the following error: Failed with error: Error Domain=NSCocoaErrorDomain Code=516, "....tmp" couldn't be moved to "..." because an item with the same name already exists.

Alamofire Environment
Alamofire version: 5.4.1
Xcode version: 12.4
Swift version: 5
Platform(s) running Alamofire: iPhone 12 simulator, iOS 14.4
macOS version running Xcode: Catalina 10.15.7

I'm not sure I'd expect 304 responses to downloads to work correctly, as there's no way for the underlying URLSession to know you've downloaded and moved a particular file.
But can you describe the behavior you're seeing in more detail? If there's already a file, downloading another file without .removePreviousFile is expected to throw an error.

Although the specification doesn't explicitly require this, but a 304 should be generated almost only if the client actively checks/asks for it, such as sending a conditional request with If-Modified-Since or If-None-Match.
Which means unless (A) you already have the cache (downloaded file) somewhere, and (B) know the state of it (e.g. last modification, checksum, entity ID, etc.), and (C) actively asks the server if you can get a 304, the server should not just hand out 304s to random download requests. And if you already have A+B+C, Alamofire should tell you no different than it currently does (that your A is good enough).
It seems there is either some custom-tweaked business logic on the problematic server, or the app generating this issue is expecting something a little different than widely used HTTP standards.

@dabaicaifen, You should determine download behavior by yourself, you can check response status code in
public typealias DownloadFileDestination = (         _ temporaryURL: URL,         _ response: HTTPURLResponse)         -> (destinationURL: URL, options: DownloadOptions)
and return proper DownloadOptions.

Given the solutions provided here and the lack of a generalizable implementation, we're going to leave this to users to implement outside Alamofire, barring new suggestions. Thanks for everyone's input.


td: add proxy.use_ssl option

👍

@danielnorberg I suspect that we should enable SSL proxy by default if protocol is SSL...how does http_proxy env var works for most of systems in the world? I think we should follow the same behavior.


Supports logging with traceID

Feature Request:
Cortex component logs each request's traceID like something below
level=debug ts=2019-12-29T20:00:00.142704226Z caller=logging.go:44 traceID=5b8343e5de934761 msg="GET /metrics (200) 3.837879ms"

And in the new version of Grafana, Loki data source supports derived fields so that users can jump to Jaeger directly from Grafana based on the traceID, see https://grafana.com/docs/grafana/latest/features/datasources/loki/#derived-fields.
So it would be nice that Thanos supports this feature as well.

Seems like a duplicate of https://github.com/thanos-io/thanos/issues/1706 (:

Yes it is a duplicate. Thanks @GiedriusS


Fix for normal binding in 3DS import

Original pull request by Thomas Moeller (Bitbucket: TheHubbit, GitHub: TheHubbit).

Solves issue #67. Corrected normal binding to PER_PART and vertex ordering to counter clockwise. Default parameter was changed to not append normals as vertex normals are unsupported and smoothing groups in 3DS are ignored. Better off letting Coin3D shapes compute the normals instead.

Original comment by Roy Walmsley (Bitbucket: walroy, GitHub: walroy).

One small comment. I note that at line 582 you test "appendNormals" whereas at line 600 the test was "con.appendNormals". I appreciate they are set to be equal so it doesn't really matter, but for conformity could you change line 582 to use "con.appendNormals" please.
Many thanks once again
Roy

Original comment by Thomas Moeller (Bitbucket: TheHubbit, GitHub: TheHubbit).

Thank you Roy for reviewing! I agree that con.appendNormals should be used and made the change.
Best,
Thomas


Updating to Nancy 2

Working PR for updates with Nancy to 2.0.

Waiting for an official prelease before merging back.


eliminate warnings in xcode 8

Xcode 8 presents a warning on several lines when evaluatePlayerCommand() is called:
Result of call to 'evaluatePlayerCommand' is unused
For example, on, line 196:
195 open func mute() {
196     evaluatePlayerCommand("mute()")
197 }

While this doesn't affect client code if you are using Carthage or CocoaPods, it's still easy enough to fix.
The fix is to simply assign the result to a dummy variable:
open func mute() {
    _ = evaluatePlayerCommand("mute()")
}

Awesome, thanks @jaywardell. Want to submit a PR?
I'd be happy to review and merge :)

just adding @discardableResult to evaluatePlayerCommand suppress all the warnings of unused result
    @discardableResult fileprivate func evaluatePlayerCommand(_ command: String) -> String? {

closed via #143


Override bug in find() method

There is a bug in django-pipeline that prevents the files in the PIPELINE settings config from collecting those static assets when running python manage.py collectstatic. See stack overflow: https://github.com/jazzband/django-pipeline/issues/487#issuecomment-132335903

Can you add a comment in the code as well pointing to the SO thread?


Incorrect double reverse in sorted rule C413

The comprehension fixits assume the user was unaware of the reverse=True keyword. This not always the case and it can be caused by an accidental double apply or an unnecessary attempt to ensure sorted is a stable sort (it is in recent Python versions). The fixits generated here are wrong
b = range(10)
c = reversed(sorted(b, reverse=True))

the fixit suggests:
b = range(10)
c = sorted(b, reverse=True)

which obviously wrong. The proper fixit would be:
b = range(10)
c = sorted(b)

Version is ruff 0.0.244.
Command is ruff --select C example.py --fix

Working on a fix


Add a magic comment syntax to set MIRIFLAGS

Based on https://github.com/integer32llc/rust-playground/issues/446#issuecomment-670917927
I really want to be able to set MIRIFLAGS when running code in the playground. The community Discord uses a bot that accesses the playground and we use it for demos. It's a real bummer that any time -Zmiri-tag-raw-pointers is required to demonstrate something, we can't use the bot. I don't think changing the defaults is a particularly good option either, because we may want to make a point about the impact of -Zmiri-tag-raw-pointers. And I recently added -Zmiri-backtrace which should be left as its default, but in a pinch can remove backtraces entirely to make the output fit in Discord message length limit.

Related, but probably is more difficult to handle (and can't be bolted on here): https://github.com/integer32llc/rust-playground/issues/698

Any updates on this?


bug: keys lazy load do not take effect

Did you check docs and existing issues?

[X] I have read all the lazy.nvim docs
[X] I have updated the plugin to the latest version before submitting this issue
[X] I have searched the existing issues of lazy.nvim
[X] I have searched the existing issues of plugins related to this issue

Neovim version (nvim -v)
NVIM v0.10.0 Build type: Release
Operating system/version
MacOS 13.6.4
Describe the bug
keys lazy load do not take effect
Steps To Reproduce
cursor is  inside "kylechui/nvim-surround" press cs"' but there is nothing to do
Expected Behavior
cursor is  inside "kylechui/nvim-surround" press cs"' and become 'kylechui/nvim-surround'
Repro
vim.env.LAZY_STDPATH = ".repro"
load(vim.fn.system("curl -s https://raw.githubusercontent.com/folke/lazy.nvim/main/bootstrap.lua"))()

require("lazy.minit").repro({
  spec = {
    -- add any other plugins here
    {
       "kylechui/nvim-surround",
       keys = {
         { "ys", desc = "Add surround" },
         { "ds", desc = "Delete surround" },
         { "cs", desc = "Replace surround" },
       },
       opts = { move_cursor = false },
    },
  },
})

you're not setting opts or calling setup.
Next time, please ask in discussions.
Issues is not for usage related questions

emmm.... I had set the opts, but adding event = "VeryLazy" works.


Support Laravel 7

Can you please add Laravel 7 support! Thanks!

This is now available in version 1.2.0


CUPY 7.0 fails with Python 2.7

Conditions (you can just paste the output of python -c 'import cupy; cupy.show_config()')

Python version 2.7.15+
CuPy version 7.0.0
Ubuntu 18.04
CUDA version NA
cuDNN/NCCL version (if applicable) NA

Code to reproduce

Run python, issue `import cupy`.

Error messages, stack traces, or logs

  File "<string>", line 1, in <module>
  File "/usr/local/lib/python2.7/dist-packages/cupy/__init__.py", line 47, in <module>
    import cupyx as _cupyx
  File "/usr/local/lib/python2.7/dist-packages/cupyx/__init__.py", line 11, in <module>
    from cupyx._ufunc_config import errstate  # NOQA
  File "/usr/local/lib/python2.7/dist-packages/cupyx/_ufunc_config.py", line 17
    def errstate(*, divide=None, over=None, under=None, invalid=None, linalg=None):
                  ^
SyntaxError: invalid syntax

Hi Janusz.
7.0 only supports Python 3.5-3.8. I think you will have to stay on the 6.x releases for python 2 support.

Hi Gregory,
Thank you for the response. I just noticed that prebuild packages are not available for Python 2.7, and the reason why it installs in my case is that source distribution cannot be limited to a particular python version.
Maybe source distribution installation could fail with python 2.7 with an appropriate message?

Maybe source distribution installation could fail with python 2.7 with an appropriate message?

Good suggestion. I made a PR (#2766) for this.

Thanks!

Rel: https://stackoverflow.com/questions/59276773/cupy-with-tx2-and-cuda-9-0


ST-9 hopefully that's all of them

Added package for axios and mui

Going to force this through as all packages should be fully setup and configured at this point


MeshData.h include no longer valid?

I am following this example:
https://doc.magnum.graphics/magnum/examples-primitives.html
I did set myself up with vcpkg...
MeshData.h doesn't seem to be valid and there are ...2D and ...3D suffixes to that header now.
Is this a known issue?

Installing latest master fixed this \o/
https://doc.magnum.graphics/magnum/building.html#building-packages-vcpkg
Thanks for the great documentation!

Hi, sorry about that -- you had the bad luck of trying out the project right after I did a rather massive breaking change. This doesn't happen often, but here I had to rethink some rather limiting design decisions from the past decade (see mosra/magnum#371) :)
Just a heads up, there's another minor breakage caused by mosra/magnum@32d49db4028eccde901869e480bf1c9c275ccbca. All docs refer to the new API, so you might want to pull latest master again.

Thanks for the heads up! I decided to work with the latest release which worked great and I was surprised how easy it was for emscripten-wasm compiling. I am not too sure if I could use it with ONNX.js however, which seems to be one of the things I will try to integrate to my project. I will perhaps open another discussion for this in the future but how to interop between a js library and cxx wasn't obvious to me.
Cheerrs!

Btw., feel free to join https://gitter.im/mosra/magnum (you can log in with your GitHub account), the response time there is generally much shorter :)


Feat store security keys

Connects to OSGP/Platform#299

SonarQube analysis reported 3 issues:

 3 minor

Watch the comments in this conversation to review them.
Note: the following issues could not be reported as comments because they are located on lines that are not displayed in this pull request:

 Rename this field "HLS4Active" to match the regular expression '^[a-z][a-zA-Z0-9]*$'.
 Rename this field "HLS3Active" to match the regular expression '^[a-z][a-zA-Z0-9]*$'.

All is well.


HV-1706 ISBN-13 algorithm does not handle checksum 10

https://hibernate.atlassian.net/browse/HV-1706

Add special case for '0' checksum of ISBN13

need to make sure that '0' checksum digit is handled correctly for ISBN13. '0' could represent both 0 and 10 checksum.

Hmm, I'm wondering if we have the same issue for the ISBN-10?
Wikipedia says: Therefore, the check digit is (11 minus the remainder of the sum of the products modulo 11) modulo 11. Taking the remainder modulo 11 a second time accounts for the possibility that the first remainder is 0. Without the second modulo operation the calculation could end up with 11 – 0 = 11 which is invalid.

Let me think about this one. It seems that for ISBN10 the algo is different. There's no 11 - smth.

I've changed the check algo for both cases. Instead of trying to find a checksum digit I just calculate the whole sum. This requires less operations. I've also added a few more valid ISBN tests to cover more cases.

Looks good to me. Good idea to take a step back, it's much cleaner now!

Merged and backported to 6.0! Thanks!


WARNING Entity  is using state class 'measurement' which is impossible considering device class ('energy') it is using

Your documentation examples indicate using state_class: measurement with device_class: energy but that seems to be invalid in HA...
023-02-02 22:00:57.838 WARNING (MainThread) [homeassistant.components.sensor] Entity sensor.front_door_lock_total_discharge (<class 'homeassistant.components.template.sensor.SensorTemplate'>) is using state class 'measurement' which is impossible considering device class ('energy') it is using; Please update your configuration if your entity is manually configured, otherwise create a bug report at https://github.com/home-assistant/core/issues?q=is%3Aopen+is%3Aissue+label%3A%22integration%3A+template%22

Entities not representing a total amount
"The state_class property must be set to measurement, and the device_class must not be either of energy, gas, or monetary"
What state_class /device_class: should I be using?
device_class: energy & state-class: total ?

Sorry for the delay.
You're right.
Use
        device_class: energy
        state_class: total

I have updated the documentation

Thanks for your issue, I close it since corrected by documentation.


Add GCP quotas usage measurement

This change adds a GCE-related API quotas usage measurement to the load test.
Underneath, we extend the CL2's capabilities to use the Google Cloud Managed Service for Prometheus as a backend instead of the in-cluster Prometheus instance.
/sig scalability

/sig scalability
/assign @marseel

/lgtm

Some transient gcloud-related issues in pull-perf-tests-clusterloader2.
/retest

/lgtm
/approve

/lgtm
/approve


Why is subscriptions missing from the index declarations?

Duplicate of #79

@donhmorris
The new version has been released with a fixed and new feature.
https://github.com/bhushankumarl/amazon-mws/releases/tag/v0.0.24


nctalk: update go-nc-talk

Update go-nc-talk to fix a few bugs.

Also, what is the standard way to report a fatal error in a bridge? There is now an error report for access to the room being lost but I'm not sure if that should quit Matterbridge or just error.

No, we don't expect fatal errors ;-)
At the moment, does only get checked at startup and will disable the bridge, at runtime there is no option.
I think the best thing to do (at the moment) is to log the error. If access to the room is being lost, this is something the owner probably has done himself?


Backend is down

Hey @devingray
Hope you're doing alright. Can't reach you by email anymore.
There's again an issue with the backend, requests are timing out.
Could you pass on the digital ocean account to us so we (I) can fix it? We can create a new account where we can roll it out from scratch.

Appreciate your help!

I have the docker stuff running locally, but am a bit stuck on fetching data from Airtable. Something with certificates being off. Appreciate any pointers @devingray  🙏

I've restored the backend infrastructure, but we need access to the images, which were on your personal DigitalOcean spaces @devingray. Could you zip up and attach all of the images? Thanks a lot!


How to increase the size of scrollbar and keep it constant

How to increase the size of scrollbar and keep it like that for more items? is there any possibility?

@orhanobut Sorry for late reply.
Consider the bottom usecase from the demo image. When we display the dialogue, It will show the scrollbar and hides it after some time. So my question is can I increase width or height of the scrollbar and can I keep the scrollbar forever without hiding.


webapp: Added PR handler to handle incorrect report of CI module

Fixed issue #557
This commit is to append web-based PR handler in order that
the reviewers directly pass the execution result of the CI modules
that are generated due to pre-mature functions and unexpected
exception cases.
Changelog

Added a PR template
Added input data to change the PR status
Added skeleton of a facility to handling the specified PR

Signed-off-by: Geunsik Lim<EMAIL_ADDRESS>

:memo: Version: 1.3.20190927. Thank you for submitting PR #581. Your PR must pass all verificiation processes of cibot before starting a review process from reviewers. If you are new member to join this project, please read manuals in documentation folder and wiki page. In order to monitor a progress status of your PR in more detail, visit http://nnsuite.mooo.com/.

To reviews,
Here is an evaluation webpage for this PR.

http://nnsuite.mooo.com/nnstreamer/ci/taos/webapp/pr-handler.php

Changelog

V3:

fixed incorrect string handling
Added doxygen annotations
Added debug message
Replaced system() with exec()

V2:

Added webhook send with common APIs
Added a web interface for report and comment

V1:

Added a PR template
Added input data to change the PR status
Added skeleton of a facility to handling the specified PR

To Reviewers,
This PR is ready to be merged as a basic set. The basic functions are tested in the real CI server.
Let's append the additional functions (e.g., Security, WebUI, ID management, and so on.)  as a next step.


Add translation: Russian

Provide the name and the two-letter code of the new language
Russian, ru
Steps to add the translation

Add a folder public/_locales/ru/
Copy the file public/_locales/en/messages.json to your new folder
Translate all values of that file (please leave the keys untouched!) and create a pull request

assign it to me

I am native Russian speaker and would like to take this issue.


Positioning should be absolute by default

The positioning of layers should be absolute by default, not fixed as it is currently the case.
Having fixed positioning for layers causes problems when you have layouts, which don't completely fit into the viewport.
Sebastian

Thanks for the report.
Honza

I see this has been discussed in #49, but I'll keep it here under the right title. Would you please re-open or check, I'm getting this in Aurora/45 and v2.0.9.

I can confirm this. Because this is obviously caused by a change in the browser (as it's working in FF 43.0), I've created a new issue for it.
Sebastian


network: Add BlockService method subscribe_to_blocks, implement for gRPC

Codecov Report

Merging #481 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #481   +/-   ##
=======================================
  Coverage   45.87%   45.87%
=======================================
  Files         131      131
  Lines       13296    13296
=======================================
  Hits         6100     6100
  Misses       7196     7196

Impacted Files
Coverage Δ

network-ntt/src/client.rs
0% <ø> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 760bf0f...936a1d3. Read the comment docs.


Supermarket upload fails when using ridley

There's a very popular Chef API client https://github.com/reset/ridley, we're using it in our environment for establishing specific chef workflow. When I'm enabling "publishcookbooks" in chef-guard it works fine with "knife cookbook upload", but fails with the following errors when using ridley for the same cookbook:
==> /var/log/chef-guard.log <==
ERROR:   2015/06/17 00:34:16 Failed to upload mycookbook to the Supermarket: Multipart POST part 'tarball' must contain a metadata.json entry.;Multipart POST part 'tarball' must contain a non-empty README.

This cookbook has both "README.md" and "metadata.rb", but ridley might be using it's own way to upload metadata and README (looks like it's not uploading it at all).
Here's the code I'm using to upload a cookbook using ridley:
require 'ridley'
ridley = Ridley.new(server_url: @chef_config[:chef_server_url],
  client_name: @chef_config[:node_name],
  client_key: @chef_config[:client_key])
ridley.cookbook.upload(Dir.pwd,
  name:     metadata.name,
  force:    options[:force],
  freeze:   options[:freeze])

It'd be really nice if chef-guard could support uploads through ridley.
As a temporary quick solution it'd be great to have an option in chef-guard to skip those checks.
EDIT: although I'm not 100% if supermarket will accept such cookbook if we skip checks for readme and metadata in chef-guard. So not sure if publishing cookbooks using chef-guard when uploading with ridley can work at all.

@iroller yeah I know the ridley stuff and as far as I know it should work together with CG and the Supermarket.
The error you currently get is not a CG error, but an error passed through from the Supermarket. So there is nothing that we can do in CG to fix this. But I've seen this before so I have a couple of suggestion how to get past these errors.
It seems that the Supermarket is pretty picky when it comes to the layout and naming of the uploaded TAR file. So one thing that you should check is if the Github repo name and the cookbook name (as written in the metadata.rb) are the same? In most cases these kind of errors have to do with the way the Supermarket unpacks and reads the uploaded TAR file.

Oh I thought those errors are coming from CG. Github repo matches the cookbook name. I'll try digging into it more tomorrow

Yeah, then check if you're actually creating the metadata.json in your upload? Maybe it searches for that one and cannot find it?
I know Berkshelf also uses the ridley stuff and uploading (incl. publishing) works just fine with it. So maybe check that source as well for insights?

I know Berkshelf also uses the ridley stuff and uploading (incl. publishing) works just fine with it. So maybe check that source as well for insights?

I didn't find the publishing part in berkshelf. Doesn't look like it can upload cookbooks to supermarket.
Here's how knife performs the upload to supermarket: https://gist.github.com/iroller/fea822f1be740962f511
I checked the list of files being uploaded in ridley https://github.com/reset/ridley/blob/8dfb7b4dd5446f82c4dae73e39d5fc83634e786f/lib/ridley/resources/cookbook_resource.rb#L221 and it contains both  metadata.json and README.md, so these two files should be doing it to CG.
As far as I understand ridley itself doesn't create an archive. @svanharmelen could you point me on where CG gets tgz file here? I want to add some debugging into CG to see what's in tar file prior to uploading to supermarket, but not exactly sure where to add it.

@iroller I think the easiest and fastest way to understand what is going wrong here is if you could share a (dummy) cookbook that gives you this problem. Maybe together with a small cmd tool to upload the cookbook using your approach with the ridley api?
The line you refer to is where the multipart web request is being prepared. A few lines below that you can see that the tarfile is written to the web request. So if you write that same data (the content of `cg.TarFile) to a file on disk, you could inspect the tarfile after the upload failed to see exactly what it looks like.

Hey @svanharmelen. Sorry for a delay. Here's a cookbook with instructions in README.md: https://github.com/iroller/cg-ridley
Could you please try and let me know if it works in your environment? I wonder if it's something specific to my setup or not.

Oh oops. Looks like I haven't looked into this issue since 0.6.0 update. It looks to be fixed and works just fine now. Feel free to close this bug, great work on 0.6.0!

:+1:
Thanks for the feedback!


Gracefully handle failures to access related bill packets on event detail pages

There is one spot where we try to access bill packets without handling an exception from the PDF merger.
https://github.com/datamade/la-metro-councilmatic/blob/9a8c0dd232aac453696281d47d256fcb5d98d0d4/lametro/views.py#L204-L206
This means, if access to the merger is disrupted, event detail pages become inaccessible. We should wrap this request in a try/except block, like we do elsewhere, to ensure these pages remain accessible, even if the merger isn't.

This is handled by the upgrade!


Duplicate entries in the terminal drop-down

Using codespaces PPE with insiders:

cc @sandy081 -- maybe disabled state for built-in extensions is not synced?

It is synced, but Codespaces currently has an issue that it initialises with different Settings Sync Service. Could be because of that. So this shall be fixed with latest bits.


Adding dropout to the model?

So I just took the annotated MNIST example and tried to modify the model in a few ways, however, for some reason I can't just add the dropout to CNN class by x = flax.nn.dropout(x, 0.4) (like in some other examples), as I get the following error for this line:

ValueError: Use the nn.stochastic() context manager to enable stochastic computations.

flax documentation on nn.stochastic is a bit sparse, so for now, it might be helpful to see how the nlp_seq example uses the context manager (here's a snippet).
I believe the context managers for stochastic and stateful computation are still in flux, so any feedback would be much appreciated!

This should be made much simpler by the new Linen API


GIF causes scroll stutter for firefox/edge

When using click scroll and having GIFs on the webpage there is stutter on firefox/edge.

Thanks for reporting the issue.
Not sure how we can remedy this since it's a rendering/painting problem with browsers. But I'll keep this open so others can see it

Also having this issue with multiple raster images while scrolling. The stuttering usually occurs after adding parallax to a third raster image. Would a possible fix be to create and destroy Rellax instances based on scroll position?

@joelhoelting Are these 3 raster images overlapping during parallax, or are they just 3 images separated and on the same page but not overlapping?

@moeamaya. Please disregard my issue, it was being caused by something else.


Ra/po loc/hishamco /8

Fixes https://github.com/dotnet/AspNetCore.Docs/issues/28373
Internal review URL(https://review.learn.microsoft.com/en-us/aspnet/core/fundamentals/portable-object-localization?view=aspnetcore-8.0&branch=pr-en-us-28376)
Public review  of the doc build:

download the HTML files
unzip
view HTML file in a browser.
For links outside the doc, remove the review. from URL.

@hishamco  is this ready to merge?

I need to make a quick review, but I'm unable to navigate the review link which you mentioned above

I need to make a quick review, but I'm unable to navigate the review link which you mentioned above

It's live now, can you review and open an issue if there's a problem?


Not displaying correct name

hello i just downloaded the awesome golden hopper mod but was noticing that it wasnt displaying the correct name from the hotbar or creative inventory or even the golden hoppers inventory. hopefully this helps fix it thanks :)

It turns out I uploaded the wrong file. Simply download the mod again as I have fixed it


Add charset to imap component

Description:
The imap component did not work with office 365 because of the wrong charset.
The default charset is UTF-8 in the imap component, Office 365 does not support this.
(This is my first PR, so a little help is appreciated :) )
Example entry for configuration.yaml:
  - platform: imap
    server: outlook.office365.com
    port: 993
    username<EMAIL_ADDRESS>    password: password
    charset: US-ASCII

Checklist:

[x] The code change is tested and works locally.
[ ] Local tests pass with tox. Your PR cannot be merged unless tests pass
[x] There is no commented out code in this PR.
[x] I have followed the development checklist

If user exposed functionality or configuration variables are added/changed:

[X] Documentation added/updated in home-assistant.io

PR #10967
If the code communicates with devices, web services, or third-party tools:

[ ] The manifest file has all fields filled out correctly. Update and include derived files by running python3 -m script.hassfest.
[ ] New or updated dependencies have been added to requirements_all.txt by running python3 -m script.gen_requirements_all.
[ ] Untested files have been added to .coveragerc.

If the code does not interact with devices:

[ ] Tests have been added to verify that the new code works.

Hi @ZiroNL,
It seems you haven't yet signed a CLA. Please do so here.
Once you do that we will be able to review and accept this pull request.
Thanks!

Why did the checks failed?

It fails the formatting check @ZiroNL. We use Black to format our code.
Please run black --fast homeassistant from the project root.

Uhh, what happend? :) Closing this one!


depend on angular:angular

Hi Urigo,
With the new angular group you published angular:angularpackage. Could you update your package.jsto depend on the new angular group?

Fixed in 0.8.5


visibility problem

Please include the following information in your ticket.

my CloudantClient is the 0.0.1
i'm using java 8
not using okhttp dependency.
public InputStream queryForStream(String query) {
key(query);
URI uri = databaseHelper.build();
HttpConnection get = Http.GET(uri);
get.requestProperties.put("Accept", "application/json");
return client.couchDbClient.executeToInputStream(get);
}
in this method i've just shown, the problem is that tha visibility of the value "couchDbClient" doesn't let me use it in my class that is in another package. Do you know why this appends?

Closing ticket; user is on an old, unsupported version.


Hard terminate pod after configured termination duration

The termination grace period set by the pod is ignored.
Fixes #134

Thank you @asobti I really appreciate the follow up! 🎉


--db option saying No typeconverter registered for java.util.OptionalInt

No TypeConverter registered for java.util.OptionalInt of field java.util.OptionalInt com.redis.riot.RedisOptions.database

Thanks for reporting this issue and for the PR. I have made another modification for the use of OptionalLong and this should be fixed in the next release.


Define the genesis state

closes https://github.com/NethermindEth/juno/issues/1528

Contracts     map[felt.Felt]genesisContractData `json:"contracts"`

May need changed. Unmarshalling into a map[felt.Felt] doesn't seem to work..


Implement the update command to support scheduled task

Dependencies: #81
Format: update schedule INDEX description/date/time/start/end/priority NEW_VALUE
E.g.

update schedule 1 description Buy clothes
update schedule 7 time 2pm
update schedule 9 end 4pm
update schedule 12 priority low

*NOTE:

The INDEX has to be numeric and a valid index of a scheduled task in the current schedule list.
If time is used, it means there is only one timing for that task, no start and end time.

Refer to issue #81

Complete update on schedule task


COUVIS import errors

2018-08-22 22:29:06 | pds.opus_import.main |--| ERROR | [COUVIS_0001 index row 892] time1 (2000-06-28T15:16:21.813) and time2 (2000-06-25T13:43:26.901) are in the wrong order - setting equal
2018-08-22 22:29:06 | pds.opus_import.main |--| ERROR | [COUVIS_0001 index row 893] time1 (2000-06-28T15:16:21.813) and time2 (2000-06-25T13:43:26.901) are in the wrong order - setting equal
2018-08-22 22:29:51 | pds.opus_import.main |-| SUMMARY | 2 ERROR messages
2018-08-22 22:35:10 | pds.opus_import.main |--| ERROR | [COUVIS_0003 index row 12364] time1 (2001-11-29T00:08:16.120) and time2 (2001-11-26T19:00:25.208) are in the wrong order - setting equal
2018-08-22 22:36:51 | pds.opus_import.main |-| SUMMARY | 1 ERROR message

Also:
2018-08-23 10:26:48 | pds.opus_import.main |--| ERROR | [COUVIS_0043 index row 191] Unable to parse Cassini SCLK "1/1744970301.324": Cassini clock trailing field out of range 0-255:<PHONE_NUMBER>.324
2018-08-23 10:26:55 | pds.opus_import.main |--| ERROR | [COUVIS_0043 index row 747] Unable to parse Cassini SCLK "1/1748402051.324": Cassini clock trailing field out of range 0-255:<PHONE_NUMBER>.324
2018-08-23 10:26:56 | pds.opus_import.main |--| ERROR | [COUVIS_0043 index row 921] Unable to parse Cassini SCLK "1/1749744651.324": Cassini clock trailing field out of range 0-255:<PHONE_NUMBER>.324
2018-08-23 10:26:57 | pds.opus_import.main |--| ERROR | [COUVIS_0043 index row 940] Unable to parse Cassini SCLK "1/1749966961.324": Cassini clock trailing field out of range 0-255:<PHONE_NUMBER>.324

We are replacing ".324" with ".000" in the bad spacecraft clock counts for UVIS.


yaoj/add gsm8k data

What does this PR do? Please describe:
Add GSM8K dataset as git lfs and add them as datasets
Fixes #848
Does your PR introduce any breaking changes? If yes, please list them:
N/A
Check list:

[x] Was the content of this PR discussed and approved via a GitHub issue? (no need for typos or documentation improvements)
[x] Did you read the contributor guideline?
[x] Did you make sure that your PR does only one thing instead of bundling different changes together?
[ ] Did you make sure to update the documentation with your changes? (if necessary)
[ ] Did you write any new necessary tests?
[x] Did you verify new and existing tests pass locally with your changes?
[ ] Did you update the CHANGELOG? (no need for typos, documentation, or minor internal changes)

Example
$ conda run -n fairseq2_pt2_4_dev_no_apex --live-stream fairseq2 assets show gsm8k_sft
gsm8k_sft
  source          : 'package:fairseq2.assets.cards'
  dataset_family  : 'generic_instruction'
  data            : '../../../../../data/gsm8k/sft'

Also tested with SFT recipe on FAIR Clusters with success.

In general, we should not be including any datasets in the repository. Ideally, the way to handle datasets is to provide some shell/python scripts for users to download, preprocess, and create the relevant artifacts (e.g. asset cards). For instance, you can check how we were doing it in the past with the original fairseq here.

We will not surface the data in git repo, but with fbaipublicfiles.com


Prognostic run: Fill nans in added tendencies

This PR fills nans in tendencies with zeros in the loops's function to add them to the state at the postphysics step, i.e., from nudging and ML. (Very occasionally coarsened restart files at C384 contain nans in the nudging reference state, which then crash the prognostic run when they propagate into the nudging tendencies.)
Significant internal changes:

Postphysics tendency nans are now filled with zeros before being added to state.

[X] Tests added

Thanks. That's a good idea, I originally had it logging the number of cells with nans at each level for each variable (like for the sphum limiter) but decided that was too much logging.

I agree per-level is a bit much. Maybe an overall fraction of NaN would be a better balance. It would be nice to know if a tendency is 100% NaN or 1%.


Add handling of intermediate certs in x5u

I'm thinking about working on this topic.
Currently we're relying on Cert.new() and Cert.verify_trust() that have been initially contributed by @dhiltgen
According to the RFC "The certificate containing the public key corresponding to the key used to digitally sign the JWS MUST be the first certificate.This MAY be followed by additional certificates, with each subsequent certificate being the one used to certify the previous one."
The use case I'm willing to deal with would be as follows

the x5u url would return something like
-----BEGIN CERTIFICATE-----
CERT_1: Leaf cert
-----END CERTIFICATE
-----BEGIN CERTIFICATE-----
CERT_2: Intermediate cert
-----END CERTIFICATE
-----BEGIN CERTIFICATE-----
CERT_3: Self signed root cert
-----END CERTIFICATE

The trusted cert location store would contain the self signed root cert as well (CERT_3).

I've started to study (a bit) the OpenSSL API and think I should be able to send something allowing this. However, that will be my first encounter with OpenSSL and I'd be very grateful for some help.
Would the following sequence of calls do the trick?

X509_STORE_load_locations(file_containing_CERT_3)
sk_X509_push(CERT_3)
sk_X509_push(CERT_2)
X509_STORE_CTX_set_chain()
X509_STORE_CTX_set_cert()
X509_verify_cert()

Besides, I've got the feeling that the evp.lua Cert API would have to be changed (in order to cope with chains of certs), and I'd prefer to potentially have some feedback regarding how it should shaped (once again, no real experience dealing with chain of certs, so I'm not sure I'd properly think of all the potential use cases and corner cases).
On the other hand, would anyone be already cooking some code in order to make this happen, I'd be happy to beta test it :wink:
Thoughts?

I have only little bit experience on openssl under ms windows, I am not much help.
I'm digging into it right now... lead the way, great @fermaem


Reporting instructors with problems

Displaying instructors whose location we don't know. (Currently doesn't display anyone, which leads me to suspect that my query isn't actually pulling up all instructors...)

This PR and #527 contains the same commits. Let me make sure all of #527 is in here and if so I'll just close it.

Okay, one commit (c3697931539137905d1f160dc608ee23f60040d9) is missing. Let me try to fix that…

Okay, the change from c369793 was introduced in ad21e5622f68d2d5e8399b631d4a20532a1a9765.


Fix image not showing in proteomiqon_peptidespectrummatching

This PR attempts to fix the image not showing in the help section of the Proteomiqon PeptideSpectrumMatching tool, found here: https://usegalaxy.eu/root?tool_id=proteomiqon_peptidespectrummatching
To solve the issue, I took a look at https://github.com/galaxyproject/tools-iuc/blob/master/tools/bedtools/slopBed.xml and saw that they prefixed images with $PATH_TO_IMAGES/ so I followed that practice.
If this is not the cause of the image not showing up, please let me know.

I'm not sure this will fix it on EU. We seem to have a general problem with those images on our deployment ... we will investigate that as soon as possible.


About & contact section are not correctly aligned

Describe the bug
The About us and contact section are not correctly aligned
Expected behavior
Centering both these things will get the website to look good.
Screenshots

Additional context
Also, I'm a GSSoC21 Participant so, please add me under GSSoC21.

Hey @sanjay270899
I'm a GSSoC21 Participant so, please add me under GSSoC21.


fix: remove equipment_profile key from inventory

Note: this is a proposal to open the discussion before 1.3 GA.
While porting my test bed from 1.2 to 1.3-rc1, I had to modify my inventory files because of the major changes we introduced (mainly due to removal of hash_behaviour = merge due to its deprecation in Ansible). I was copying the
values of group_vars/all/equipment_all/equipment_profile.yml to the relevant group_vars/equipment_type*/equipment_profile.yml when I asked myself what is the purpose of the equipment_profile key now.
The equipment_profile key defined in equipment_profile.yml files was useful when the stack was using hash_behaviour = merge. Now, it prevents to inherit values from the global configuration file groups_vars/all/equipment_all/equipment_profile.yml, with no obvious added value (at least to me, I might miss it :sweat_smile:).
This change removes this key from inventory examples and usage of this key in the roles.
It does not change the logic of equipment_profile files.
With the breaking changes we are introducing in 1.3, I guess it is the right time to think about this. Converting an equipment_profile.yml file from a 1.2 inventory to a 1.3 inventory could be as easy as: remove equipment_profile key and decrease indentation by one level.

Hello 😊
Took me time to compute.
I agree with this strategy, as we lost a lot with merge deprecation. It seems now we should avoid big dictionaries.
To keep the equipment_profile philosophy, i.e. variables dedicated to equipment_profile groups, and that should never be used outside of it, I would prefix all these values with 'ep_' .
Also, I would take this opportunity to do the same for authentication, simply using 'authentication_' prefix.
Would that be ok for all ?

Command to update inventory files from 1.2 to 1.3:
$ sed -i -e 's/^equipment_profile:$/---/' \
             -e 's/^  //' \
             -e 's/^\([a-z]\)/ep_\1/' \
  inventory/group_vars/all/equipment_all/equipment_profile.yml \
  inventory/group_vars/equipment_type*/equipment_profile.yml


Edits to "Xarray and Dask"

changes minor points that might be causing confusion to the user (1. variable misnames 2. specifying the directory in the cluster was misleading )

great catch with the mismatched names in the exercise @yutik-nn !

specifying the directory in the cluster was misleading

I agree that client = Client(local_directory='/tmp') is unclear, it makes it seem like we might have data in that folder.
The reason for that setting was discussed here, and it's also good practice to use 'scratch spaces' for temporary files
https://github.com/xarray-contrib/xarray-tutorial/issues/75#issuecomment-1158050289 ,
Instead of removing local_directory='/tmp' what do you think of adding a sentence above saying something like "dask uses the current working directory for writing temporary files by default. We use the argument local_directory='/tmp' below to instead use a temporary scratch folder" ?

Thank you for your comments @scottyhq !
The reasoning behind me removing local_directory='/tmp' altogether was that it appears  in many other tutorials so it seemed like an unnecessarily complicated thing to have a specified folder here, but I see your reasoning now.
Yes, I think adding a sentence explaining it is a good suggestion!

@yutik-nn did we decide that adding info on persist was a distraction?

@yutik-nn did we decide that adding info on persist was a distraction?

I did not do anything to the section yet, honestly. It seems to have appeared in edits because I removed some characters? But I did not touch it consciously. I added the sentence about the scratch directory only.

Nice work! 🥳

@yutik-nn @scottyhq @dcherian Based on this discussion, shouldn't the line of code have stayed as client = Client(local_directory='/tmp') rather than client = Client()?

whoops, i missed that! @yutik-nn would you mind a follow-up PR to add that back in?


Where do I find source .proto files?

I'd like to use the library methods here, and also use the same .proto files that were used to generate these files. While I know that I can simply provide my own, I'd like the assurance of pulling down the same versions of the proto files as these are generated from.
How can I do that? At the readme should contain a link to those files.
Thanks!

Do you mean the proto files defining the well-known types?

Do you mean the proto files defining the well-known types?

Yep!

I think they’re at least available from the mainline protobuf package: https://github.com/protocolbuffers/protobuf
For example, I found here the: any.proto

that is well and good, but what happens if that project ever changes? which version of the project is this repository defined from?

For versions >= 1.20, i.e. https://github.com/protocolbuffers/protobuf-go/, the generated Go code for WKT uses the proto files from a downloaded version of the protobuf source repository that @puellanivis pointed out.  The version used is specified here -- https://github.com/protocolbuffers/protobuf-go/blob/master/integration_test.go#L38.

Perhaps a link to that line in the documentation for the package would be helpful? Or better I'd like to refer to those protos in my project-- is there a way to package them so they are pulled in by go get?


NeuromancerWin64: implement UI control from keyboard.

UI should be controllable with the keyboard.

Done by 776085e6850c0d431c6f08253fa5f9e92ae88822.


Fix for Dashboard Filters for Mysql datasource

Dashboard filters are throwing the following error on filtering on any integer fields.
'int' object has no attribute 'strip'
Converting all the fields to integers before calling strip method.
Addresses: https://github.com/airbnb/superset/issues/2615

Looks like a workaround more than a fix, we are (supposedly) converting to int two lines later

Thanks @mistercrunch, closing this PR.


It tests refactor

Part of #3313

Reassigning bcs @alissapajer is OOO

So the names of the tests that you moved got pretty universally changed to a space-free, semi-mangled encoding.  Is there a particular reason for that?  The names are meant to be human-friendly, so there's no reason to mangle them.

@djspiewak actually in other branch I'm unifying those names like that - it's actually for a reason to be able to run a batch of tests prefixed with given phrase. Whitespaces makes it problematic (too many tests run when actually is needed). Does it make sense?

@djspiewak I in future want to rename it to demo_games_step1.test, so

when I want to run all demo tests I do

it/testOnly **.StreamingQueryRegressionSpec -- -ex demo -
2. whenI want to run all "games" tests I do
it/testOnly **.StreamingQueryRegressionSpec -- -ex demo_games_step --

@rabbitonweb Could we maybe "tag" similar issues with a key, but keep the human readable names e.g. [demo_games] Some nice description for a person.?

Or maybe we add a group key to the test metadata and when we convert the test into a specs2 example, we "tag" the test using the group key automatically, when present. This would keep them as data, which would be nice.

@wemrysi I might go with "tag" first and then maybe in the futue do the second thing you proposed

@djspiewak @wemrysi Are you gusy ok with keeping this order I propse in folder structure:
|-demo
|-regression
|-qa
   |-s01
   |-s02

?

@djspiewak if I "tag" and bring whitespaces back, will this be 👍 ?

@rabbitonweb Yep!

I'm closing this and I will open new PR with more changes because this is already too old and I dont want to backport those changes


Task: set up "all contributors" bot to document contributions in github repo

To better recognize contributors to the project, we should install and configure the All Contributors bot on this GitHub repo, and also add contributors from the UX team who have contributed to things other than code.

App has been added to the GH account. Only steps 3 and 4 now needed: https://allcontributors.org/docs/en/bot/installation.

@all-contributors please add @nlebovits for getting this running!

@all-contributors please add @nlebovits for documentation!


Ui need improvements

Is your feature request related to a problem? Please describe.
I have seen the parts of the ui of some parts is very inconvenient for example google and Facebook are
have too much space between them

this needs to fix please assign me for this section.
Describe the solution you'd like
A clear and concise description of what you want to happen.
Describe alternatives you've considered

A clear and concise description of any alternative solutions or features you've considered.

Additional context
Add any other context or screenshots about the feature request here.

Go Ahead @iamparas0

Hello All, I would like to work on this issue. Can you please give me a chance to work on this project.

Go Ahead @LEARNER-dakshesh

Could you please asign this task to me . I would like to contribute on this issue


SPIKE: Country specific outcomes for marriage-abroad

I've been spiking on country specific outcomes for marriage-abroad. I arbitrarily chose Germany to start with.
I created an outcome template for each of the 18 possible sets of responses that can lead to an outcome for marrying in Germany. I then started to remove some duplication from the templates - at the moment I've only removed some duplication from the opposite sex outcome templates.
I'm interested in taking this spike further - by removing more duplication from these Germany outcome templates and by adding one or two more countries. Are there any obvious reasons why I shouldn't continue?
I've half wondered whether it might even be an improvement to produce response-specific outcomes for all 225 countries (225 countries * 18 templates per country = 4,050 templates) and live with the duplication - at least initially. I don't think it would be too much work to produce all these templates as we can use the complete set of countries in our regression test and then copy the content from the artefacts back to the templates. I can imagine that the duplication would become problematic, but I can also imagine that in the short term it would become much easier to respond to marriage-abroad content change requests.
I'd be interested in any thoughts you have about this spike, @floehopper, @erikse and @ikennaokpala.

In general, I'm really happy that you're having a go at this. And I don't see any reason for you not to take it further - in fact I'd encourage you to do so!
I think the advantage of generating the new outcome templates directly from the regression test artefacts is that we can avoid any preconceptions about how the duplication should best be removed. However, the disadvantage is that we immediately lose all the ways duplication is currently removed, some of which might be good ones!
I don't feel strongly about this, but perhaps there might be some middle ground where we can recognise some existing sensible ways to remove duplication and avoid losing them at the the point where we do the expansion. I was going to say that an example of this might be the outcome title, but looking at the original Germany outcome, I see that this was already hard-coded anyway! So perhaps your approach is the best one!
I think the amount of duplication being introduced in this just this PR is pretty scary. Even merging just this PR, we'd have to make sure that everyone fully understood the implications i.e. being super careful when making a change, that the same change is made to all other copies of that content. It would just be so easy for stuff to get out of kilter and then we'd be in an even worse situation.
So at the moment I'm not convinced that producing response-specific outcomes for all 225 countries. I think I'd like to see this PR for Germany taken a bit further and perhaps a few more for other countries, before we commit to this approach across the board. However, I'm willing to be convinced!
I'd also love to hear what @erikse & @ikennaokpala think, given that they have the most experience of maintaining marriage-abroad.

Thanks for your feedback, @floehopper. I'm going to close this while I concentrate on making some smaller refactoring changes/improvements to marriage-abroad, although I hope to come back to it in the near future.


Read only view in questions/forms are too light.

IMPORTANT: All PRs must be linked to an issue (except for extremely trivial and straightforward changes).
Issue #917
Description

Override default theme text color to improve contrast of disabled text. android:textColor
Override default theme box stroke color to improve contrast of disabled widget. boxStrokeColor

Alternative(s) considered
Have you considered any alternatives? And if so, why have you chosen the approach in this PR?
Type
Choose one:  Feature
Screenshots (if applicable)
Before implementation
Edit text with Mark value

After implementation
Edit text with Mark value

Checklist

[x] I have read and acknowledged the Code of conduct
[x] I have read How to Contribute
[x] I have read the Developer's guide
[x] I have signed the Google Individual CLA, or I am covered by my company's Corporate CLA
[x] I have discussed my proposed solution with code owners in the linked issue(s) and we have agreed upon the general approach
[x] I have run ./gradlew spotlessApply and ./gradlew spotlessCheck to check my code follows the style guide of this project
[x] I have run ./gradlew check and ./gradlew connectedCheck to test my changes locally
[x] I have built and run the reference app(s) to verify my change fixes the issue and/or does not break the reference app(s)

@jing could you please confirm proposed implementation?

please also update the PR name and description

Updating code changes as per review comments.

please mark as ready to review if ready. thanks!

@jingtang10
Implemented contrast change is only visible to questionnaire edit text view (QuestionnaireItemEditTextViewHolderFactory) and not for others. Do we also need to apply it to other questionnaire views?

@jingtang10 Implemented contrast change is only visible to questionnaire edit text view (QuestionnaireItemEditTextViewHolderFactory) and not for others. Do we need to apply it to other questionnaire views?

yeah you do. anything with the edit text you'll need to apply the stroke color, anything with text you'll probably need to apply the text color.

have you also tested this with dark theme? please attach some screenshots. thanks!

also please attach before/after screenshots with other widgets if you do them in the same PR.

have you also tested this with dark theme? please attach some screenshots. thanks!

looking into it.

have you also tested this with dark theme? please attach some screenshots. thanks!

looking into it.

@shelaghm
when #9E9E9E get applied to the disabled text and container it works as expected in light theme (please refer earlier screenshots) but when it switch to the dark theme then contrast/opacity is too high.
To fix this issue, it is required to use alpha value and theme attribute to create color state list resource.
As you mentioned 38% opacity in earlier comments I assumed alpha value is .38 as range is 0 to 1, now it works  in both themes, but if you think alpha value can be greater than .38 please let me know.
Light theme : read only view with alpha .38

Dark theme : readonly view with alpha .38

autocomplete textview, light theme, alpha .38

autocomplete textview, dark theme, alpha .38

Q Hep B y / n readonly view QuestionnaireItemBooleanTypePickerViewHolderFactory, alpha .38, light theme

Q Hep B y / n readonly view QuestionnaireItemBooleanTypePickerViewHolderFactory, alpha .38, dark theme

Q. 1st dose 2nd dose readonly view QuestionnaireItemDateTimePickerViewHolderFactory, light theme, alpha .38

Q. 1st dose 2nd dose readonly view QuestionnaireItemDateTimePickerViewHolderFactory, dark theme, alpha .38

Q.1 & Q.3 readonly view QuestionnaireItemDialogSelectViewHolderFactory, light theme, alpha .38

Q.1 & Q.3 readonly view QuestionnaireItemDialogSelectViewHolderFactory, dark theme, alpha .38

@jingtang10
Can you please it? Thanks!

readonly view QuestionnaireItemDropDownViewHolderFactory alpha .38

readonly view QuestionnaireItemCheckBoxGroupViewHolderFactory alpha .38

Retested "Readonly" changes by adding "readOnly" :  true" attribute in Questionnaire JSON and it is properly visible after adding contrast to text. Working as expected.


feat: implement noInteractiveElementToNoninteractiveRole options

Summary

Add options to rule,
"options": {
       "elementAndRoles": [
           { "element": "span", "roles": ["button", "grid"] },
           { "element": "div", "roles": ["button"] },
        ]
}

Test Plan
No test added

Thank you @vasucp1207, for the contribution. Can you update the description by explaining what these options are for and what are the uses cases? Usually, we tend to add options only if they are needed. We believe it's best for users to suppress a rule instead of adding an option as "expectation".

Thank you @vasucp1207, for the contribution. Can you update the description by explaining what these options are for and what are the uses cases? Usually, we tend to add options only if they are needed. We believe it's best for users to suppress a rule instead of adding an option as "expectation".

Oh! I just added this to provide an extra functionality and I agree that providing options to this rule is not a good idea.

I also think there is no need to add options to noInteractiveElementToNoninteractiveRole and the example mentioned in ESLint docs is very rare case.
By the way, I think it's good to add an option to noNoninteractiveElementToInteractiveRole. (not noInteractiveElementToNoninteractiveRole)  There are common use cases for this option.
 and
, mentioned in the ESLint documentation are actually used to mark up accessible dropdowns. It makes sense that we can ignore a rule with an option.
In summary, when submitting a PR for an option, please include the specific use case in the PR body as well.


Fix #7304: Re-calculate the resolution when the WMS source is reprojected

Fix #7304

Thx for the review.


Contributor Prizes

Contributor Prize List

[x] Chad Bunn (@heyjack88)
[x] Christy (@christyheaton)
[ ] Stan (@smcshinsky)

Are there more, is this correct?

@smcshinsky's has been sent!


release version 2

@ADiex: look here for progress.

release performed, no signing, no maven central, binaries attached

I can not find the binaries for version 2.0. What does "binaries attached" mean?
Tobias<EMAIL_ADDRESS>hat am 14. August 2017 um 09:31 geschrieben:release performed, no signing, no maven central, binaries attached
—You are receiving this because you were mentioned.Reply to this email directly, view it on GitHub, or mute the thread.