Flight error even with update yaml (25/05/23)

Hy, I am trying to implement rosella in my binning workflow, but I have some problems with flight. The error is the following and I attached also the conda environment which I created using the updated yaml (24/05/23).
[2023-05-25T08:34:25Z INFO  rosella] rosella version 0.4.2
[2023-05-25T08:34:25Z INFO  rosella] Using min-covered-fraction 0%
[2023-05-25T08:34:25Z INFO  rosella] Using min-read-aligned-percent 0%
[00:00:03] ████████████████████████████████████████  338614/338614  Read results from previous run. If this is not desired please rerun with --force... ETA: [0s]
[00:00:07] ⠠ Calculating UMAP embeddings and clustering...    3/6
[2023-05-25T08:34:37Z ERROR bird_tool_utils::command] Error when running flight process. Exitstatus was : ExitStatus(unix_wait_status(256))
thread 'main' panicked at 'Failed to grab stderr from failed flight process', /home/conda/.cargo/registry/src/github.com-1ecc6299db9ec823/bird_tool_utils-0.3.0/src/command.rs:17:14
env.txt

Hi @gabrieleghiotto , apologies for the delay I've been swamped but had some inspiration this weekend. v0.5.0 should fix this issue if you create a new conda environment and install from the bioconda channel. If you still get an error from flight, please open a new issue and post the error log that gets produced. The flight error should be exposed to users now.

Dear Rhys,
I finally managed to install it however when trying to use it to perform
the binning (rosella recover) i am getting the following error. Any clues?
Il giorno sab 4 nov 2023 alle ore 21:57 Rhys Newell <
@.***> ha scritto:

Hi @gabrieleghiotto https://github.com/gabrieleghiotto , apologies for
the delay I've been swamped but had some inspiration this weekend. v0.5.0
should fix this issue if you create a new conda environment and install
from the bioconda channel. If you still get an error from flight, please
open a new issue and post the error log that gets produced. The flight
error should be exposed to users now.
—
Reply to this email directly, view it on GitHub
https://github.com/rhysnewell/rosella/issues/37#issuecomment-1793552087,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ASMJI5GNI4ROTB3KJURT5K3YC2TZZAVCNFSM6AAAAAAYOQCQIKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTOOJTGU2TEMBYG4
.
You are receiving this because you were mentioned.Message ID:
@.***>

COMMANDS:
conda activate coverm
coverm contig -m metabat --bam-files ../*.sorted.bam -o coverm.cov
--threads 10
conda activate rosella
rosella recover -i coverm.cov -r ../../assembly_spades/r1_assembly.fa
--output-directory rosella_out/ --threads 10
OUTPUT:
[2023-11-06T08:24:46Z INFO  rosella] rosella version 0.4.2
[2023-11-06T08:24:46Z INFO  rosella] Using min-covered-fraction 0%
[2023-11-06T08:24:46Z INFO  rosella] Using min-read-aligned-percent 0%
[2023-11-06T08:24:46Z INFO  rosella::utils] Generating reference index
thread 'main' panicked at 'Unable to generate index: Failed to read fasta
index from "../../assembly_spades/r1_assembly.fa.fai"
Caused by:
0: No such file or directory (os error 2)
1: No such file or directory (os error 2)', src/utils.rs:734:10
note: run with RUST_BACKTRACE=1 environment variable to display a
backtrace
Il giorno lun 6 nov 2023 alle ore 09:05 Rhys Newell <
@.***> ha scritto:

Hi @gabrieleghiotto https://github.com/gabrieleghiotto , I think you
may have forgot to attach the error you are receiving
—
Reply to this email directly, view it on GitHub
https://github.com/rhysnewell/rosella/issues/37#issuecomment-1794267742,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ASMJI5F7A64E7VAUDPCIM43YDCK4NAVCNFSM6AAAAAAYOQCQIKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTOOJUGI3DONZUGI
.
You are receiving this because you were mentioned.Message ID:
@.***>

Thanks for posting the error, a couple of things. I would highly recommend upgrading to v0.5.0. It is faster, more stable, and should produce slightly better results. You'll need a fresh environment but it should be easily done via conda create -n rosella rosella=0.5.0
If you do update, your new rosella command would just have to change to the following:
rosella recover -C coverm.cov -r ../../assembly_spades/r1_assembly.fa -o rosella_out/ -t 10

The error you posted seems to indicate that rosella is unable to generate the fasta index for the provided assembly. The things you would need to check are:

Does the assembly exist at the location specified? I do this all the time and is always worth double checking.
Do you have write permission in the folder that the fasta file is stored? Rosella won't be able to generate the fasta index if your user does not have permission to write into the assembly folder.
Check that the fasta file isn't corrupted somehow.

If none of that is true then try running samtools faidx ../../assembly_spades/r1_assembly.fa.fai and see what samtools has to say about it.

Hi @gabrieleghiotto,
Interesting, looks like the final part of the error is clipped off. First could you show me what versions of packages conda installed for you (conda list while inside of your new rosella env). When you updated rosella, did you create a fresh environment (delete the old env and then call the new rosella as well) or just reuse the old environment (ran conda install rosella=0.5.0 in the pre-existing rosella env)?
Cheers,
Rhys

When I performed the update I deleted the old environment.  First
could you show me what versions of packages conda installed for you (conda
list while inside of your new rosella env). When you updated rosella, did
you create a fresh environment (delete the old env and then call the new
rosella as well) or just reuse the old environment (ran conda install
rosella=0.5.0 in the pre-existing rosella env)?
Cheers,
Rhys
—
Reply to this email directly, view it on GitHub
https://github.com/rhysnewell/rosella/issues/37#issuecomment-1796852658,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ASMJI5BMJVEAOERVIID4OSTYDFOQ3AVCNFSM6AAAAAAYOQCQIKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTOOJWHA2TENRVHA
.
You are receiving this because you were mentioned.Message ID:
@.***>

Hmm, no incorrect version numbers are jumping out at me so this is perplexing. Would you be able to send me the coverm coverages file and assembly you are using for binning and I'll see if I can reproduce the error on my end?
If you can't send the data, then could you rerun your rosella command but add  2>err.out on to the end of it and put the results of that file here? We might be missing a key piece of information in the original error message that will help us solve this

These are the files
coverm.cov
https://drive.google.com/file/d/1TrMKrujsFrbX9YKRqQspr4P5-eJGPVeb/view?usp=drive_web
r1_assembly.fa
https://drive.google.com/file/d/1sB2u9N25tisd9sX8Pz4HYLfZoBeIaXqg/view?usp=drive_web
Il giorno mar 7 nov 2023 alle ore 22:01 Rhys Newell <
@.***> ha scritto:

Hmm, no incorrect version numbers are jumping out at me so this is
perplexing. Would you be able to send me the coverm coverages file and
assembly you are using for binning and I'll see if I can reproduce the
error on my end?
If you can't send the data, then could you rerun your rosella command but
add 2>err.out on to the end of it and put the results of that file here?
We might be missing a key piece of information in the original error
message that will help us solve this
—
Reply to this email directly, view it on GitHub
https://github.com/rhysnewell/rosella/issues/37#issuecomment-1800111670,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ASMJI5D4DHJKOLKET5ZHCCLYDKOTLAVCNFSM6AAAAAAYOQCQIKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMBQGEYTCNRXGA
.
You are receiving this because you were mentioned.Message ID:
@.***>

Hi @gabrieleghiotto,
Just wanted to check if these are the right files? The contig ids in the coverm.cov file do not match up with the assembly you provided. Additionally, there are 8179 contigs in the coverm.cov file with a min size of 56 base pairs, and then 198614 contigs in the assembly file. Rosella won't run as these files don't match up at all

in the coverm file I saw 198614, I re-lauch it and now I am attaching it to
the email.
coverm_v2.cov
https://drive.google.com/file/d/1gdSwu1BIlRR1PnSucofuvONfoc1FQxyr/view?usp=drive_web
The procedure that I used was assembly with spades, renaming contigs,
generating index with bowtie2-build, align filtered reads on assembly with
bowtie2 and then converting to BAM and sorting. Then I launched coverm as
following:
coverm contig --methods metabat --bam-files *.sorted.bam -o coverm_v2.cov
--threads 10
May I try to use the reads instead of the alignments?
Il giorno mar 7 nov 2023 alle ore 23:37 Rhys Newell <
@.***> ha scritto:

Hi @gabrieleghiotto https://github.com/gabrieleghiotto,
Just wanted to check if these are the right files? The contig ids in the
coverm.cov file do not match up with the assembly you provided.
Additionally, there are 8179 contigs in the coverm.cov file with a min
size of 56 base pairs, and then 198614 contigs in the assembly file.
Rosella won't run as these files don't match up at all
—
Reply to this email directly, view it on GitHub
https://github.com/rhysnewell/rosella/issues/37#issuecomment-1800308588,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ASMJI5ANCD32SUJSSLT7AXLYDKZ2RAVCNFSM6AAAAAAYOQCQIKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMBQGMYDQNJYHA
.
You are receiving this because you were mentioned.Message ID:
@.***>

Okay, my mistake I had two files called coverm.cov in my downloads folder which caused an issue on my end.
But I have figured out what is wrong with your file. The contig names in your coverage file do not match up with the contig names in assembly. They coverage file just has numeric values, I believe this is because you renamed the contigs when performing mapping for some reason.
What you should do is pass the reads directly to rosella or to coverm, both tools will produce the coverage file correctly for you if you do that. Alternatively, you could just not rename the contigs

Thank you. I will try with this approach. However, it is strange since to
perform the alignments i used the assembly with renamed contigs to create
the index for the alignment. I will update you.
Il giorno mer 8 nov 2023 alle ore 01:26 Rhys Newell <
@.***> ha scritto:

Okay, my mistake I had two files called coverm.cov in my downloads folder
which caused an issue on my end.
But I have figured out what is wrong with your file. The contig names in
your coverage file do not match up with the contig names in assembly. They
coverage file just has numeric values, I believe this is because you
renamed the contigs when performing mapping for some reason.
What you should do is pass the reads directly to rosella or to coverm,
both tools will produce the coverage file correctly for you if you do that.
Alternatively, you could just not rename the contigs
—
Reply to this email directly, view it on GitHub
https://github.com/rhysnewell/rosella/issues/37#issuecomment-1800723962,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ASMJI5AA3RHBXVMOIHP6GQTYDLGTPAVCNFSM6AAAAAAYOQCQIKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMBQG4ZDGOJWGI
.
You are receiving this because you were mentioned.Message ID:
@.***>

You are right, the contig ids do match up but I think renaming the contigs to be sequential numeric values is causing issues somewhere. I'm trying to pinpoint where exactly, but I would strongly advise against giving contigs such simple names in general. The IDs given by the assembler used is generally good enough

Dear Rhys,
thank you. This is a step of a metagenomic pipeline that we developed in
our lab where we rename contigs and remove those with length lower than
1000. This avoid issues in the downstream analysis. But i guess I can try.
Thanks again
On Wed, 8 Nov 2023 at 23:29, Rhys Newell @.***> wrote:

You are right, the contig ids do match up but I think renaming the contigs
to be sequential numeric values is causing issues somewhere. I'm trying to
pinpoint where exactly, but I would strongly advise against giving contigs
such simple names in general. The IDs given by the assembler used is
generally good enough
—
Reply to this email directly, view it on GitHub
https://github.com/rhysnewell/rosella/issues/37#issuecomment-1802780864,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ASMJI5GMVGWL7HR67UJQPW3YDQBTTAVCNFSM6AAAAAAYOQCQIKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMBSG44DAOBWGQ
.
You are receiving this because you were mentioned.Message ID:
@.***>

Hi @gabrieleghiotto ,
I actually managed to pinpoint the issue. Python/pandas was reading in the coverage file and setting the type of the contigName column to be an integer whilst the code was operating as if it were a string. Contig IDs would be read in directly from the assembly as strings, and then comparisons to the coverage file would fail.
If you run pip install flight-genome==1.6.1 from within your rosella conda environment it should install a version of flight that will fix your issue and you will be able to run your binning as normal. I would advise maybe amending your in house pipeline to generate more informative contig headers though, perhaps containing sample id information and length information. Contig headers should aim to be unique as it makes for comparison across samples much easier.
I've tested the fix on your assembly and it generated the results as expected, so I'll go ahead and close this issue now

Dear Rhys,
by updating fligth all it is working fine. I have a question however: in
the output folder there are a bunch of bins called rosella_bin_X.fa and
another group called rosella_refined_0_X.fna, where X is the progressive
number given by the software. Which is the final set of bins that I should
consider? I want also to point out that the Documentation section is
lacking some example commands, however I imagine it is a work in progress.
Il giorno gio 9 nov 2023 alle ore 06:48 Rhys Newell <
@.***> ha scritto:

Closed #37 https://github.com/rhysnewell/rosella/issues/37 as completed.
—
Reply to this email directly, view it on GitHub
https://github.com/rhysnewell/rosella/issues/37#event-10908735260, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/ASMJI5ERM7JDDIDUI6IBD3TYDRVDRAVCNFSM6AAAAAAYOQCQIKVHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJQHEYDQNZTGUZDMMA
.
You are receiving this because you were mentioned.Message ID:
@.***>

All of the bins represent the final set of bins. There are just some bins that were unchanged during the initial refining process so they retain their original bin name
Documentation is indeed a work in progress

Thanks, but again the name of bins is the same but the refined 0_ string.
Thus my question is rosella_refined_100.fna and rosella_bin_100.fna are not
the same bin from what you are saying right? I posed myself this question
because with metabat1, metabat2 and vamb I obtained between 140-150 bins,
while by summing all of them they are 264 so a bit strange.
On Thu, 9 Nov 2023 at 20:06, Rhys Newell @.***> wrote:

All of the bins represent the final set of bins. There are just some bins
that were unchanged during the initial refining process so they retain
their original bin name
Documentation is indeed a work in progress
—
Reply to this email directly, view it on GitHub
https://github.com/rhysnewell/rosella/issues/37#issuecomment-1804431656,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ASMJI5DGQ75G2W32XVET6WDYDUSTRAVCNFSM6AAAAAAYOQCQIKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMBUGQZTCNRVGY
.
You are receiving this because you were mentioned.Message ID:
@.***>

You can double check duplicate contigs by running the following in the output directory:
'grep -h '>' *.fna | sort | uniq -d'
As long as that grep command is correct (operating off memory) and it only displays the contig name without the file path or file name, then it will sort and only display contigs that appeared multiple times.

No contig is displayed so I can confirm that they are all different as you
sad. I would suggest, just from a user perspective, to add a renaming step
at the end otherwise the output looks confusing to the fist eye. Thanks
again for all the effort and the exhaustive support.
Il giorno gio 9 nov 2023 alle ore 20:43 Rhys Newell <
@.***> ha scritto:

You can double check duplicate contigs by running the following in the
output directory:
'grep -h '>' *.fna | sort | uniq -d'
As long as that grep command is correct (operating off memory) and it only
displays the contig name without the file path or file name, then it will
sort and only display contigs that appeared multiple times.
—
Reply to this email directly, view it on GitHub
https://github.com/rhysnewell/rosella/issues/37#issuecomment-1804525125,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ASMJI5GEQ3B67M2XGQ3FNFDYDUW7HAVCNFSM6AAAAAAYOQCQIKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMBUGUZDKMJSGU
.
You are receiving this because you were mentioned.Message ID:
@.***>


Licensing information mismatch

Hi there
The licensing info on nuget.org points to LGPL, but here on github is MIT. Can you please specify which one is correct or I am missing something ?

I see that this issue is fixed in develop branch. Will it ever be merged and/or deployed as alpha @crmckenzie ?

@xakpc REF: #127


Add support for rendering raster images

Resolves #29. This extension allows us to render raster images alongside vector graphics.
This can be used to add support for rendering an <image> tag in SVG. An <image> tag contains embedded raster images. Some SVG describe vector geometric shapes on top of raster textures.
https://github.com/sammycage/lunasvg/issues/113
https://github.com/sammycage/lunasvg/issues/13
Here is an example image produced with plutovg_image. There are 4 different raster textures under the vector geometric shape of a face.

Interesting! Looking forward to seeing this merge and the positive impact it brings to SVG rendering! 👏🚀

@sammycage Thank you for the feedback! What is the best way to proceed? Could this code be merged into the main branch of plutovg?
Afterwards, I would love to use it from lunasvg to finish the implementation of <image>. Should this code also be committed in one commit to the repository of lunasvg to patch its copy of plutovg? Alternatively, the repository lunasvg can use plutovg as a submodule. This way the changes will be applied to plutovg only and lunasvg would just reuse them.
https://github.com/sammycage/lunasvg/tree/master/3rdparty/plutovg

Resolved in the latest version.


Fixed #26617 -- Added distinct argument to contrib.postgres's StringAgg.

Patch for ticket https://code.djangoproject.com/ticket/26617

@akki, thanks!

buildbot, add to whitelist.

merged in df8412d2e5c95fe8c8238ebde8e0dbb68fe2ec1d, thanks!


New parameters for survey-text and survey-likert

-Added button_label parameter to survey-likert and survey-text, it allows us to customize the button's label. Default is the same as it was before when it was still hardcoded.
-Added values parameter to survey-text, it allows us to send default values for the textarea. When nothing is sent, default is "".

This solves #361. Other plugins need to implement this to solve #360.

I'll revise the other plugins to implement this feature.
When there is only one button, I'll keep the same parameter's name. When there is more than one, I'll try to name the parameter according to the function it serves. For example, in the instructions plugin, we'll have two parameters: button_label_previous, button_label_next.
Do you have a better idea?

sounds great 👍


[Bug] Injector doesn't load after update

Describe the Bug
The injector script fails to load after the upgrade to 0.0.11 on Linux
To Reproduce
reinstall on 0.0.11
Expected Behavior
Injector should load and provide all the BD functionality
Screenshots
Logs:
Refused to apply style from 'https://cdn.staticaly.com/gh/rauenzi/BetterDiscordApp/c687b97d665ffa24e749c9b04182a99eec96af21/css/main.min.css' because its MIME type ('text/html') is not a supported stylesheet MIME type, and strict MIME checking is enabled. cdn.staticaly.com/gh/rauenzi/BetterDiscordApp/c687b97d665ffa24e749c9b04182a99eec96af21/js/main.min.js:1 Failed to load resource: the server responded with a status of 404 ()
Discord Version
Stable

Based on the error, your injector is quite out of date. You can try and follow the provided instructions here to fix it: https://github.com/rauenzi/BetterDiscordApp/issues/421#issuecomment-670964471
If that still does not work, I would recommend reaching out to those that made the linux installer. https://github.com/bb010g/betterdiscordctl


loop fails to connect to RPC

Receiving an error when trying to run loop.
loopd is not running.
litd UI seems to process swaps correctly.
bitcoin@ln-bitcoin:~$ loop terms
Loop Out
--------
rpc error: code = Unavailable desc = all SubConns are in TransientFailure, latest connection error: connection error: desc = "transport: Error while dialing dial tcp <IP_ADDRESS>:11010: connect: connection refused"

Loop In
------
rpc error: code = Unavailable desc = all SubConns are in TransientFailure, latest connection error: connection error: desc = "transport: Error while dialing dial tcp <IP_ADDRESS>:11010: connect: connection refused"

# lnd.conf

[Application Options]
httpslisten=<IP_ADDRESS>:4567
uipassword=123

lnd.debuglevel=info
lnd.maxpendingchannels=10
lnd.externalip=example.com
lnd.alias=LNBitcoin
lnd.color=#4169e1
lnd.rpclisten=<IP_ADDRESS>:10009
lnd.tlsextraip=<IP_ADDRESS>
lnd.tlsextraip=<IP_ADDRESS>

lnd.bitcoin.active=1
lnd.bitcoin.mainnet=1
lnd.bitcoin.node=bitcoind

lnd.bitcoind.rpcuser=123
lnd.bitcoind.rpcpass=123
lnd.bitcoind.zmqpubrawblock=tcp://<IP_ADDRESS>:28332
lnd.bitcoind.zmqpubrawtx=tcp://<IP_ADDRESS>:28333

faraday.min_monitored=48h

Hey @minvs1 when you run litd it loads loopd internally and shares the same RPC port and LND. It does not use the default port of 11010. So when you run loop, you must set the rpcserver, tlscertpath and macaroonpath  parameters.
An easy shortcut is is to add this line to your .bashrc file, then you can just run loop terms as normal.
alias loop="loop --rpcserver=localhost:10009 --tlscertpath=$HOME/.lnd/tls.cert --macaroonpath=$HOME/.lnd/data/chain/bitcoin/testnet/admin.macaroon"

We probably should have this in the README. I'll get it added.

Great, thanks!


Incorrect lang attribute on Resources page

Bug:
We noticed this exact same problem on the homepage: #284
The language buttons work but the page's lang attribute does not change from en. This matters because CSS needs this to know how to correctly format accents, etc for certain languages (like Greek).

Suggested fix:
We solved this exact issue on the homepage in this PR: #297 . I suspect the identical refactor needs to happen for the resources page:

create a new file for each translation with the corresponding language suffix (ex: resources-it.md)
Update the yaml at the top of each version of the file to include the correct lang value (ex: 'it') and also the title value should be in the same language if we want the html  to be translated.

Note that we don't localize Resources pages so it's always in English, which means that we can expect to see mixed-language pages here.
Do you know what's the right approach in such situation?

I should think about this more, but my first quick thought is that we should use the yaml attributes at the top of each resource entry to specify the language, then set the lang attribute accordingly on each entry. That we could have an entry that’s for Greece, written in Greek, and we won’t have typography problems.
Another option is to just write all the resources in English since they’re mostly external links anyway. If we’re resolved not to localize this page, this may be the best answer.

On Apr 24, 2020, at 11:11 AM, Jan Rous<EMAIL_ADDRESS>wrote:

Note that we don't localize Resources pages so it's always in English, which means that we can expect to see mixed-language pages here.
Do you know what's the right approach in such situation?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or unsubscribe.

The entries are all in English as of today.
On Fri, Apr 24, 2020, 13:06 emersonthis<EMAIL_ADDRESS>wrote:

I should think about this more, but my first quick thought is that we
should use the yaml attributes at the top of each resource entry to specify
the language, then set the lang attribute accordingly on each entry. That
we could have an entry that’s for Greece, written in Greek, and we won’t
have typography problems.
Another option is to just write all the resources in English since they’re
mostly external links anyway. If we’re resolved not to localize this page,
this may be the best answer.

On Apr 24, 2020, at 11:11 AM, Jan Rous<EMAIL_ADDRESS>wrote:

Note that we don't localize Resources pages so it's always in English,
which means that we can expect to see mixed-language pages here.
Do you know what's the right approach in such situation?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or unsubscribe.

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/flattenthecurve/guide/issues/304#issuecomment-619191262,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABYSCGAMPTDGLM54FESDV53ROHPLRANCNFSM4MBGZV4Q
.

I don't think we have mechanism in place to translate these and no plans to
translate them as of today so we can assume that the page will be in
English, possibly with the header/intro section translated?
It seems technically feasible to translate these but I'm not sure if it's
worth our energy and possibly limited translation bandwidth to focus on
that.
So until things change, let's assume this is always English.
On Fri, Apr 24, 2020, 13:08 Jan Rouš<EMAIL_ADDRESS>wrote:

The entries are all in English as of today.
On Fri, Apr 24, 2020, 13:06 emersonthis<EMAIL_ADDRESS>wrote:

I should think about this more, but my first quick thought is that we
should use the yaml attributes at the top of each resource entry to specify
the language, then set the lang attribute accordingly on each entry. That
we could have an entry that’s for Greece, written in Greek, and we won’t
have typography problems.
Another option is to just write all the resources in English since
they’re mostly external links anyway. If we’re resolved not to localize
this page, this may be the best answer.

On Apr 24, 2020, at 11:11 AM, Jan Rous<EMAIL_ADDRESS>wrote:

Note that we don't localize Resources pages so it's always in English,
which means that we can expect to see mixed-language pages here.
Do you know what's the right approach in such situation?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or unsubscribe.

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/flattenthecurve/guide/issues/304#issuecomment-619191262,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABYSCGAMPTDGLM54FESDV53ROHPLRANCNFSM4MBGZV4Q
.

I still think we need to fix the lang attribute on the HTML tag so that the menu works correctly for all languages. But maybe we just wrap the main content in a lang=en-us and be done with it.

On Apr 24, 2020, at 12:08 PM, Jan Rous<EMAIL_ADDRESS>wrote:

The entries are all in English as of today.
On Fri, Apr 24, 2020, 13:06 emersonthis<EMAIL_ADDRESS>wrote:

I should think about this more, but my first quick thought is that we
should use the yaml attributes at the top of each resource entry to specify
the language, then set the lang attribute accordingly on each entry. That
we could have an entry that’s for Greece, written in Greek, and we won’t
have typography problems.
Another option is to just write all the resources in English since they’re
mostly external links anyway. If we’re resolved not to localize this page,
this may be the best answer.

On Apr 24, 2020, at 11:11 AM, Jan Rous<EMAIL_ADDRESS>wrote:

Note that we don't localize Resources pages so it's always in English,
which means that we can expect to see mixed-language pages here.
Do you know what's the right approach in such situation?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or unsubscribe.

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/flattenthecurve/guide/issues/304#issuecomment-619191262,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABYSCGAMPTDGLM54FESDV53ROHPLRANCNFSM4MBGZV4Q
.

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or unsubscribe.


Removes Feature Flag for Robust Item 125A/B/C/D [delivers #164869508]

Description
Explain a little about the changes at a high level.
Reviewer Notes
Is there anything you would like reviewers to give additional scrutiny?
Setup
Add any steps or code to run in this section to help others prepare to run your code:
echo "Code goes here"

Code Review Verification Steps

[ ] Code follows the guidelines for Logging
[ ] The requirements listed in
Querying the Database Safely
have been satisfied.
Any new migrations/schema changes:

[ ] Follow our guidelines for zero-downtime deploys (see Zero-Downtime Deploys)
[ ] Have been communicated to #dp3-engineering
[ ] Secure migrations have been tested using scripts/run-prod-migrations

[ ] There are no aXe warnings for UI.
[ ] This works in Supported Browsers and their phone views (Chrome, Firefox, IE, Edge).
Any new client dependencies (Google Analytics, hosted libraries, CDNs, etc) have been:

[ ] Communicated to @ntwyman
[ ] Added to the list of network dependencies

[ ] Tested in the Experimental environment (for changes to containers, app startup, or connection to data stores)
[ ] User facing changes have been reviewed by design.
[ ] Request review from a member of a different team.
[ ] Have the Pivotal acceptance criteria been met for this change?

References

Pivotal story for this change
this article explains more about the approach used.

Screenshots
If this PR makes visible UI changes, an image of the finished UI can help reviewers and casual
observers understand the context of the changes. A before image is optional and
can be included at the submitter's discretion.
Consider using an animated image to show an entire workflow instead of using multiple images. You may want to use GIPHY CAPTURE for this! 📸
Please frame screenshots to show enough useful context but also highlight the affected regions.

Since this might be our last flag, it might be worth removing robustAccessorialFlag from the feature flags altogether. I know this is a draft PR, so it's possible that work just hasn't been done yet.

I know we were adding the top few robust accessorials now, but will we add additional accessorials in the future? If we do plan on adding more accessorials, do we want to keep the flag around? I'm also fine removing it and re-implementing it later...

@lynzt it doesn't seem like we'll be adding more robust accessorials any time in the near future. I think it should be fairly easy to reintroduce the flags again if we ever need too.


Build Error | A problem occurred evaluating root project

Greetings, can you please help me with this error?

hi i'm having the same issue. Did you find a solution ?

Ok i found it : replace testCompile by testImplementation
so gradle load properly.
Now i'm having an issue when i do : gradle build

@Janloui Thank you !!!


Feature/workflow redirect

Adds redirect code for workflows that do not have the expected git registry.

It seems like the wrong column is being selected. Though I don't know why it would sometimes pass.

Codecov Report

Merging #224 into develop will increase coverage by 0.11%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop     #224      +/-   ##
===========================================
+ Coverage    60.13%   60.25%   +0.11%
===========================================
  Files          115      116       +1
  Lines         3489     3517      +28
  Branches       452      454       +2
===========================================
+ Hits          2098     2119      +21
- Misses        1159     1165       +6
- Partials       232      233       +1

Impacted Files
Coverage Δ

src/app/docs/docs.component.ts
31.81% <ø> (ø)
:arrow_up:

src/app/sponsors/sponsors.component.ts
65.51% <0%> (-7.22%)
:arrow_down:

src/app/sponsors/sponsors.service.ts
100% <0%> (ø)
:arrow_up:

src/app/funding/funding.component.ts
100% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update da1030b...c47ca93. Read the comment docs.


PreTrainedTokenizer.from_pretrained should be more general

I'm trying to implement a general interface to any of these transformer models in AllenNLP.  I would love to be able to do something like PreTrainedTokenizer.from_pretrained(model_name), and have this work for any model name across any of your implemented models.  It looks like what needs to happen for this is to detect which underlying model is being requested, and pass off to that class's _from_pretrained method.  Does this make sense?  In particular, I think the thing that needs to change is here: https://github.com/huggingface/pytorch-transformers/blob/067923d3267325f525f4e46f357360c191ba562e/pytorch_transformers/tokenization_utils.py#L149-L151
It could be changed to something like:
    @classmethod
    def from_pretrained(cls, pretrained_model_name_or_path, *inputs, **kwargs):
        if 'bert' in pretrained_model_name_or_path:
            # import BertTokenizer here to avoid circular dependencies
            return BertTokenizer._from_pretrained(pretrained_model_name_or_path, *inputs, **kwargs)
        # other cases here
        # default to existing behavior if we can't detect the model class
        return cls._from_pretrained(*inputs, **kwargs)

If this looks right to you, I can put together an initial PR for this.
It would be super helpful if there were similar functionality for models, too, but I haven't gotten far enough yet to worry about how exactly that would work =).

Yes, this is a nice idea, I was thinking about implementing something like this for another reason (simplifying the task of maintaining torch.hub configuration files).
Regarding the library architecture, I think it's better to make a new (very simple) class, something like AutoTokenizer in a new file tokenizer_auto.py deriving from PreTrainedTokenizer (no need to avoid circular dependencies in this case).
Then the idea would be to make a new file modeling_auto.py as well with something like AutoModel, pretty much like AutoTokenizer, and AutoModelForSequenceClassification, AutoModelForQuestionAnswering that would encapsulate standard architectures on top of each model.
Maybe the AutoXXX is not the best name, also thought about GenericXXX or UniversalXXX but they convey meanings that could be misleading.

{Generic,Universal,Auto} Tokenizer and Model interfaces would be awesome (I'm also highly interested in that, as I'm currently working on Flair to add support for all six architectures) :heart:

Ok, I've hacked something together for an internal hackathon this week.  I'll see if I can pick this up the way you suggest next week, if no one else gets to it first.  I also don't know much about your PR requirements, so if someone who's more familiar with this repo wants to pick it up, I wouldn't complain =).


Add remaining fixes from #579

Add remaining fixes from #579

s3fs.S3FileSystem() doesn't support region_name
https://github.com/dyvenia/viadot/blob/084af16925343b3ec636205d6f39bc9f27497aed/viadot/sources/s3.py#L40

Remove if to get file type as it results with creating files called
s3://bucket/folder/file.parquet/a734ad32537043af93ba747ab75c01fc.snappy.parquet, which is not desired
https://github.com/dyvenia/viadot/blob/084af16925343b3ec636205d6f39bc9f27497aed/viadot/sources/s3.py#L135

RedshiftSpectrum.rm() doesn't work with remove_files=True > error occurs when removing S3 file
https://github.com/dyvenia/viadot/blob/084af16925343b3ec636205d6f39bc9f27497aed/viadot/sources/redshift_spectrum.py#L115

redshift_source.rm() doesn't remove redshift tables

S3.exists() doesn't work for directories
https://github.com/dyvenia/viadot/blob/084af16925343b3ec636205d6f39bc9f27497aed/viadot/sources/s3.py#L72

Add tests to S3 and RedshiftSpectrum sources


Fixes a canvas item set to clip children being drawn as black if no children are visible

…hildren are visible
Fixes #69179. And a couple of other minor things.

Thanks!

Cherry-picked for 4.0.1.

Possible regression in 4.0.1: Nested clip only nodes do not work correctly. I would expect if both parent and grandparent of a node have clip only, that only the intersect of both parent and grand parent is visible. This was working as expected before 4.0.1.
Is this intended?

Yes you are right, what I described does not work,
However, there is still a difference in behavior not described in this PR (as far as I can tell). For clarity, say I have the described setup:
grandparent (clip only)
. parent (clip only)
.. node
In 4.0.1, changing clip only of parent does not make a difference in how node is clipped, but it swappes the drawing order of parent and node.
Whereas in 4.0.0 the mask of parent is applied to node but inverted.
It can be reproduced with icon.svg in empty 4.0.0 and 4.0.1 projects respectively.
Since I am not deeply into this, it might very well be the case that the behavior of 4.0.0 was a bug that was fixed by this PR. If that's so, how could I reproduce the behavior of 4.0.0 in 4.0.1 in a "correct" way?

This PR doesn't make any changes to draw order. However, if that's the behavior you want, you can simply use "Draw behind parent" on the child node, and that would do the trick. No need to give the parent a clipping that would only be ignored. There was also a report on cascaded clip being inconsistent between renderers in 4.0. So whatever effect you were seeing may have been different between GLES3 and Vulkan, and may have just been an artifact that could just as easily result in corrupt display.


update README with example

This fixes #10

This seems like a small (but important) contribution, so no Contribution License Agreement is required at this point. We will now review your pull request.
Thanks,
Microsoft Pull Request Bot

@paulmey Are you able to accept pull requests?

Yes I am, but I was out of office for a bit. Thanks for adding this example!


[bug] win10,win11 cannot print

打印服务器没有接受请求。作业已中止

I've run into this as well- I made further progress by ensuring that both "LPD Print Service" and "LPR Port Monitor" features are enabled.

However, it appears to still have issues:
> lpr -S <IP_ADDRESS> -P "HP" "C:\\Users\\jonah\\AppData\\Local\\Temp\\8ea19b4b-22df-4063-ab20-1c56ec8abb81"
Error: print server did not accept request.  Job aborted.

Initially, it seems that "HP" is too short of a system name. Was able to determine that the DriverName parsing from wmic has a bug when names have whitespace:
     Running `target\debug\examples\list_printers.exe`
Printer { id: "793c6ff0-8bb6-542a-baba-e82974ceac12", name: "Name", system_name: "DriverName" }
Printer { id: "ed0e594f-e80c-59ca-9a76-d973e6d7a586", name: "Software", system_name: "Microsoft" }
Printer { id: "9928f21e-8775-5504-a46b-4066026b9b4c", name: "LaserJet", system_name: "HP" }
Printer { id: "ed0e594f-e80c-59ca-9a76-d973e6d7a586", name: "XPS", system_name: "Microsoft" }
Printer { id: "ed0e594f-e80c-59ca-9a76-d973e6d7a586", name: "Print", system_name: "Microsoft" }
Printer { id: "ed0e594f-e80c-59ca-9a76-d973e6d7a586", name: "Shared", system_name: "Microsoft" }
Printer { id: "8aec0343-6abb-537b-b8cd-e05e22e9d0b4", name: "CL-S400DTZ", system_name: "Citizen" }

> wmic printer get DriverName,Name
DriverName                         Name
Microsoft Software Printer Driver  OneNote for Windows 10
HP LaserJet M109-M112 PCLm-S       NPI642118 (HP LaserJet M110w)
Microsoft XPS Document Writer v4   Microsoft XPS Document Writer
Microsoft Print To PDF             Microsoft Print to PDF
Microsoft Shared Fax Driver        Fax
Citizen CL-S400DTZ                 Citizen CL-S400DTZ

Note: HP LaserJet M109-M112 PCLm-S vs HP
Interestingly, neither of these work:
> lpr -S <IP_ADDRESS> -P "NPI642118 (HP LaserJet M110w)" "C:\\Users\\jonah\\AppData\\Local\\Temp\\8ea19b4b-22df-4063-ab20-1c56ec8abb81"
Error: print server did not accept request.  Job aborted.

> lpr -S <IP_ADDRESS> -P "HP LaserJet M109-M112 PCLm-S" "C:\\Users\\jonah\\AppData\\Local\\Temp\\8ea19b4b-22df-4063-ab20-1c56ec8abb81"
Error: print server did not accept request.  Job aborted.

Taking a step back, tried to determine whether this is an issue with this library or my hardware configuration. Looked into alternative ways of printing via CLI on Windows and encountered Get-Printer and Out-Printer.
PS C:\Users\jonah> Get-Printer | Format-Table

Name                           ComputerName    Type         DriverName                PortName        Shared   Published  DeviceType
----                           ------------    ----         ----------                --------        ------   ---------  ----------
OneNote for Windows 10                         Local        Microsoft Software Pri... Microsoft.Of... False    False      Print
NPI642118 (HP LaserJet M110w)                  Local        HP LaserJet M109-M112 ... WSD-9a219156... False    False      Print
Microsoft XPS Document Writer                  Local        Microsoft XPS Document... PORTPROMPT:     False    False      Print
Microsoft Print to PDF                         Local        Microsoft Print To PDF    PORTPROMPT:     False    False      Print
Fax                                            Local        Microsoft Shared Fax D... SHRFAX:         False    False      Print
Citizen CL-S400DTZ                             Local        Citizen CL-S400DTZ        USB001          False    False      Print

PS C:\Users\jonah> Get-Content -Path "C:\\Users\\jonah\\AppData\\Local\\Temp\\8ea19b4b-22df-4063-ab20-1c56ec8abb81" |  Out-Printer -Name "NPI642118 (HP LaserJet M110w)"

The following working on both of my test devices

@cheng-io This branch has the changes above applied and I'm now able to print on Windows:
https://github.com/jonahgeorge/rust-printers/tree/jonahgeorge-patch-1
Let me know if you have success with it

Upon further review, I believe the correct way to accomplish this is with the winspool functions within winapi:
https://github.com/retep998/winapi-rs/blob/0.3/src/um/winspool.rs

Thanks for contributing @cheng-io
This issue are fixed by PR #13 (tag v1.2.0)

@jonahgeorge Thanks for your proposal with powershell. The latest version has been adjusted based on your fork :). Feel welcome to open the PR. I opened this project as a simple utility and I can't always handle it quickly.


Plugin trialing

Append an empty paragraph  when  table is the last node

@Saul-Mirone Do you have time to review it

@Saul-Mirone Do you have time to review it

I've already reviewed it a week ago.

I think your PR has two features:

Keep empty lines in markdown
Add trailing node plugin

I don't plan to make feature 1 part of official plugins because I think it's not part of markdown standard and the implementation is a little bit tricky. It would be better to make it as a community plugin.
The feature 2 is a good feature but I think you should make it as a standalone plugin rather than part of commonmark preset.
BTW, the branch has conflicts so it's blocked by github.

But their are relative , if set to trailing and keep empty line , will generate a not expect "" in the last line

But their are relative , if set to trailing and keep empty line , will generate a not expect \ in the last line

But they are relative , if set to trailing and keep empty line , will generate a not expect "" in the last line

I add a auto attr in paragraph to mark the trailing p

This seems a bug related to https://github.com/Saul-Mirone/milkdown/issues/568, and I've been fixed it in latest main branch. Can you please reconfirm the behavior?

It's not same , the problem is when i just look at a table, no editing  at all, but the value changed

I think your PR has two features:

Keep empty lines in markdown
Add trailing node plugin

I don't plan to make feature 1 part of official plugins because I think it's not part of markdown standard and the implementation is a little bit tricky. It would be better to make it as a community plugin.
The feature 2 is a good feature but I think you should make it as a standalone plugin rather than part of commonmark preset.
BTW, the branch has conflicts so it's blocked by github.

If  to make it as a plugin agian. is it ok to keep this code in paragraph ? or any suggestion
                        if (!node.attrs['auto']) {
                            state.addNode('text', undefined, undefined, {
                                value: '\\',
                            });
                        }

It's not same , the problem is when i just look at a table, no editing at all, but the value changed

I think you should check the node level in documentation, which means only add trailing node when you're in top level, similar to plugin-slash, it'll only show placeholder when the cursor at top level of the document

It's not same , the problem is when i just look at a table, no editing at all, but the value changed

I think you should check the node level in documentation, which means only add trailing node when you're in top level, similar to plugin-slash, it'll only show placeholder when the cursor at top level of the document
https://github.com/Saul-Mirone/milkdown/blob/a6405ec1544763a362983d3a5bff6fabef5320f3/packages/plugin-slash/src/prose-plugin/props.ts#L77

Do you mean make a Decoration ? But  as i know It cannot  be focus  and selected

is There a way to detect a node is a top level paragraph where runner toMarkdown?

No, I mean you should do the detection of top level when the editor view update.

I created a PR in https://github.com/Saul-Mirone/milkdown/pull/573 to show what I'm talking about.
I'll add you as the co-author of the PR.

I created a PR in #573 to show what I'm talking about. I'll add you as the co-author of the PR.

thanks

Closed for #573.


Fix bug when FZF_PREVIEW_WINDOW is undefined

Description
Fixes issue caused in https://github.com/unixorn/fzf-zsh-plugin/commit/0578f7e3dda91ae3997cb8066885305be83274c4
Checklist

[x] All new and existing tests pass.
[ ] Rather than adding functions to fzf-zsh-plugin.zsh, I have created standalone scripts in bin so they can be used by non-ZSH users too.
[ ] Any scripts added use #!/usr/bin/env interpreter instead of potentially platform-specific direct paths (#!/bin/sh is an ok exception)
[ ] Scripts are marked executable
[ ] Scripts do not have a language file extension unless they are meant to be sourced and not run standalone. No one should have to know if a script was written in bash, python, ruby or whatever. Not including file extensions makes it easier to rewrite the script in another language later without having to change every reference to the previous version.
[ ] I have confirmed that the link(s) in my PR are valid.
[x] I have read the CONTRIBUTING document.

License Acceptance

[x] This repository is Apache version 2.0 licensed (some scripts may have alternate licensing inline in their code) and by making this PR, I am contributing my changes to the repository under the terms of the Apache 2 license.

Closing - duplicate of https://github.com/unixorn/fzf-zsh-plugin/pull/55


Revert "exec: Use a temp file to pass data to the nft binary"

This reverts commit 3547c49dbb3b75ac19ab04eb21a5098d3584f082.

change: Rebase

Tested with https://github.com/kubevirt/kubevirt/pull/9282 and https://github.com/containernetworking/plugins/pull/902 . Confirmed to work.


Normal map loading code should use strcmp

Describe the bug
We now check if CStringA == CStringB, which simply compares pointers.

This has been resolved #43.
Closing now.


Inference times

Hi, I have been looking into deploying EfficientDet and am curious about the performance of your implementation.  Have you benchmarked inference times, and are they comparable to the times listed on the TF2 Detection Model Zoo page? https://github.com/tensorflow/models/blob/master/research/object_detection/g3doc/tf2_detection_zoo.md
Thanks for all the great work!

@drwaltman I have not done the equivalent benchmarking, but I do know that single image inference times (and throughput) are not very fast, quite a bit of overhead. Large batched inference and training throughput on GPU are competitive with the original (this used to be quite a bit faster but the TF impl has been optimized quite a bit since release).
With ONNX -> TensorRT conversion and a platform specific post-processing impl I'm sure there is significant room for improvement over both the this code and the original TF, but that's likely only a funded goal for this codebase as it's of primary concern for embedded/mobile operation that's generally product focused.

@rwightman thanks for the quick response!  I have been looking into exporting a pretrained model  to ONNX and converting to TensorRT for deploying with NVIDIA's Triton Inference Server.  Have you had any issues exporting to ONNX or converting to TensorRT?  I saw https://github.com/rwightman/efficientdet-pytorch/issues/32 and it looks like the export is possible.

@drwaltman converting the whole predict bench with post-processing would be some work in my opinion, I think someone was successful or close to successful (with a few changes) just converting the model without post process and generate_detections


recommendation

I write both python project and web application.
It would be great if it detects the .gitignore file and respect the rules set in that file.
Also ignore node_modules for npm, coverage for jest etc.

.gitignore is supported - which should help with node_modules etc as well.

Sharing this in case it's helpful.

Ideally, having a .claudeignore or files-to-prompt named config would go a long way.
These files would not be in a .gitignore, but I don't think it's useful context to pass 20 migration files to Claude.


fix(protocol): fix ERC20Airdrop2.sol?

https://github.com/code-423n4/2024-03-taiko-findings/issues/245
@adaki2004 Dani, please take a look at the bug report above...
OR we simply delete this contract if ERC20Airdrop is to be used by genesis airdop.

code-423n4/2024-03-taiko-findings#245
@adaki2004 Dani, please take a look at the bug report above...
OR we simply delete this contract if ERC20Airdrop is to be used by genesis airdop.

Well, we haven't paid too much attention to version 2, because v1 will be used with genesis. But Trailblazer could still use this type and personally i think it should !
(Will adjust the failing test).


add pod-security-admission-config-file parameters to server configuration

A parameter is specified to point to a custome admision config file : https://docs.rke2.io/security/pod_security_standards#pod-security-standards
pod-security-admission-config-file shoud be added to the server documentation

We need to add a workflow to automatically resync the args with the CLI help, adding missing args one by one as folks notice that they are missing is not great.


Fixing: Dart Unhandled Exception: type 'Null' is not a subtype of type 'Map<String, dynamic>' in type cast

This error occurs every time I remove a document on the meteor server.
The stack trace showed me that this error came from these lines:
return Tuple2(_id, null as Map<String, dynamic>);
return Tuple2('', null as Map<String, dynamic>);
This is not null safe because null can't be something else now.
I now changed it into
{} as Map<String, dynamic>
But I'm not completely sure if I break something else with that.

Thans @ruerob!
I'll do some tests and give you feedback.

@ruerob
I did some tests and the changes gave me an error:
Unhandled Exception: type '_InternalLinkedHashMap <dynamic, dynamic>' is not a subtype of type 'Map <String, dynamic>' in type cast
I changed it to:
return Tuple2(_id, Map<String, dynamic>.from({}));
return Tuple2('', Map<String, dynamic>.from({}));

And the error was resolved. What do you think? Do you have any suggestions on how to improve?

Hello @wendellrocha,
sorry for digging up this old pull request. I've found another Null related exception in the DDP class. But since I don't know if it is enough to just change Line 389 of ddp.dart from
Log.error(         'Disconnected code: ${this._socket!.closeCode}, reason: ${this._socket!.closeReason}');
into
Log.error(         'Disconnected code: ${this._socket?.closeCode}, reason: ${this._socket?.closeReason}');
I was not sure if a pull request would be a good idea. And the issues are disabled in this repository.
The error message I receive is the following
I/flutter ( 5519): [DDP] :: Disconnect due to websocket onDone E/flutter ( 5519): [ERROR:flutter/shell/common/shell.cc(103)] Dart Unhandled Exception: Null check operator used on a null value, stack trace: #0      DDP._onDone (package:enhanced_meteorify/src/ddp/ddp.dart:390:43) E/flutter ( 5519): #1      _RootZone.runGuarded (dart:async/zone.dart:1534:10) E/flutter ( 5519): #2      _BufferingStreamSubscription._sendDone.sendDone (dart:async/stream_impl.dart:394:13) E/flutter ( 5519): #3      _BufferingStreamSubscription._sendDone (dart:async/stream_impl.dart:404:15) E/flutter ( 5519): #4      _BufferingStreamSubscription._close (dart:async/stream_impl.dart:291:7) E/flutter ( 5519): #5      _ForwardingStream._handleDone (dart:async/stream_pipe.dart:99:10) E/flutter ( 5519): #6      _ForwardingStreamSubscription._handleDone (dart:async/stream_pipe.dart:161:13) E/flutter ( 5519): #7      _RootZone.runGuarded (dart:async/zone.dart:1534:10) E/flutter ( 5519): #8      _BufferingStreamSubscription._sendDone.sendDone (dart:async/stream_impl.dart:394:13) E/flutter ( 5519): #9      _BufferingStreamSubscription._sendDone (dart:async/stream_impl.dart:404:15) E/flutter ( 5519): #10     _BufferingStreamSubscription._close (dart:async/stream_impl.dart:291:7) E/flutter ( 5519): #11     _SyncStreamControllerDispatch._sendDone (dart:async/stream_controller.dart:741:19) E/flutter ( 5519): #12     _StreamController._closeUnchecked (dart:async/stream_controller.dart:596:7) E/flutter ( 5519): #13     _StreamController.close (dart:async/stream_controller.dart:589:5) E/flutter ( 5519): #14     _RootZone.run (dart:async/zone.dart:1607:54) E/flutter ( 5519): #15     _FutureListener.handleWhenComplete (dart:async/future_impl.dart:179:18) E/flutter ( 5519): #16     Future._propagateToListeners.handleWhenCompleteCallback (dart:async/future_impl.dart:677:39) E/flutter ( 5519): #17     Future._propagateToListeners (dart:async/future_impl.dart:733:37) E/flutter ( 5519): #18     Future._completeWithValue (dart:async/future_impl.dart:542:5) E/flutter ( 5519): #19     Future._asyncCompleteWithValue.<anonymous closure> (dart:async/future_impl.dart:580:7) E/flutter ( 5519): #20     _microtaskLoop (dart:async/schedule_microtask.dart:40:21) E/flutter ( 5519): #21     _startMicrotaskLoop (dart:async/schedule_microtask.dart:49:5)
I hope that helps a little
Robert

@ruerob
I enabled the issues again. I had not seen that they were disabled :(
--
The _socket can be null, so your solution is apparently correct. I will do some tests and give feedback.

Thanks @ruerob 🎉
Release 3.0.1

Thank you @wendellrocha  for your fast response! I already updated my project and everything works fine now!


Port information is not transferred as part of body request

Describe the bug
When a eureka registration is occurring the port number is not being set in the payload however the
Steps to reproduce
Steps to reproduce the behavior:

Define your port information in configuration

Data.Add("eureka:instance:Port", "90");
Data.Add("eureka:instance:NonSecurePortEnabled", true.ToString());
Data.Add("eureka:instance:SecurePortEnabled", false.ToString());

Have an application perform a registration with eureka
Observe payload coming in
Notice port numbers are not set
Observe all other urls are using the port ie info & health address

Expected behavior
The port number number when configured is provided as part of the payload
Environment (please complete the following information):

Steeltoe Version 3.2.6
OS: Windows,
.NET Version Net 8

I'm unable to reproduce this with the provided details. Can you try with the FortuneTeller sample at https://github.com/SteeltoeOSS/Samples/blob/main/Discovery/src/FortuneTeller.sln?

Sure will look at that sample tomorrow my time & report back.

so i have noticed a couple of things while debugging. The IsUnsecurePortEnabled flag is not being respected for some reason and always showing as false even when config is different. I have tried using the property: IsUnsecurePortEnabled and what the docs stated but it hasn't helped. I have pushed my reproduct6ion up to my eureka branch of the samples

The configuration key is named NonSecurePortEnabled, not IsUnsecurePortEnabled (see https://docs.steeltoe.io/api/v3/discovery/netflix-eureka.html).

found the root cause. I was using newtonsoft for my deserialisation rather than system.text.json hence it didn't respect the JsonPropertyName attributes. Hence closing


Make redirection for highly-available-control-plane

CC @sftim

Resolves #28612

[Redirections]

https://deploy-preview-30398--kubernetes-io-main-staging.netlify.app/docs/admin/ha-master-gce/
redirects to https://deploy-preview-30398--kubernetes-io-main-staging.netlify.app/docs/setup/production-environment/#production-control-plane
https://deploy-preview-30398--kubernetes-io-main-staging.netlify.app/docs/admin/ha-master-gce.md
redirects to https://deploy-preview-30398--kubernetes-io-main-staging.netlify.app/docs/setup/production-environment/#production-control-plane
https://deploy-preview-30398--kubernetes-io-main-staging.netlify.app/docs/tasks/administer-cluster/highly-available-control-plane
redirects to https://deploy-preview-30398--kubernetes-io-main-staging.netlify.app/docs/setup/production-environment/#production-control-plane

/lgtm

/approve


Telephone number in footer not place correctly

Where to find the issue

https://www.coronawarn.app/en/ in the footer
Describe the issue

When opening the website on a mobile device, the telephone number is not fully displayed.
Here tested on an iPhone 11 Pro Max

Suggested change

The placement of the telephone number should adapt to smaller screen sizes.

Yes, we are aware of this issue. We will have a look. In the meantime: Contributions are appreciated! :)
Mit freundlichen Grüßen/Best regards,
SW
Corona Warn-App Open Source Team

Someone was 2 min faster, I didn't expect a duplicate to be opened within seconds before I post.
In my case it's Android 10 OnePlus 6T Chrome.

@SebastianWolf-SAP if you give us a slice of the 20 million ;)

@SebastianWolf-SAP Thanks for the update! Sorry for not contributing myself but it has been ages since I’ve worked on a website, I didn’t want to submit something that takes more time reviewing that developing. ;)
Thanks and good luck tomorrow!

Still a lot of activity here. ;) We might all be a little sleepless tonight, I understand that... There is an interim fix ready - it's still not ideal, but at least we shouldn't have the ugly cut-off anymore.
Mit freundlichen Grüßen/Best regards,
SW
Corona Warn-App Open Source Team

Haha, that could be true...!
Confirmed working on my side, thanks for the quick implementation.


update proxy sha

Test will fail. Will retest after proxy postsubmit finishes.

@bianpengyuan: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-telemetry-k8s-tests_istio
a67821a9d7de8382ddbb1f22a4297cb25cabc363
link
/test integ-telemetry-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@bianpengyuan: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-telemetry-k8s-tests_istio
a67821a9d7de8382ddbb1f22a4297cb25cabc363
link
/test integ-telemetry-k8s-tests_istio

integ-conformance-k8s-tests_istio
a67821a9d7de8382ddbb1f22a4297cb25cabc363
link
/test integ-conformance-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@bianpengyuan: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-telemetry-k8s-tests_istio
a67821a9d7de8382ddbb1f22a4297cb25cabc363
link
/test integ-telemetry-k8s-tests_istio

integ-conformance-k8s-tests_istio
a67821a9d7de8382ddbb1f22a4297cb25cabc363
link
/test integ-conformance-k8s-tests_istio

unit-tests_istio
a67821a9d7de8382ddbb1f22a4297cb25cabc363
link
/test unit-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@bianpengyuan: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-telemetry-k8s-tests_istio
a67821a9d7de8382ddbb1f22a4297cb25cabc363
link
/test integ-telemetry-k8s-tests_istio

integ-conformance-k8s-tests_istio
a67821a9d7de8382ddbb1f22a4297cb25cabc363
link
/test integ-conformance-k8s-tests_istio

unit-tests_istio
a67821a9d7de8382ddbb1f22a4297cb25cabc363
link
/test unit-tests_istio

integ-distroless-k8s-tests_istio
a67821a9d7de8382ddbb1f22a4297cb25cabc363
link
/test integ-distroless-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@bianpengyuan: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-telemetry-k8s-tests_istio
a67821a9d7de8382ddbb1f22a4297cb25cabc363
link
/test integ-telemetry-k8s-tests_istio

integ-conformance-k8s-tests_istio
a67821a9d7de8382ddbb1f22a4297cb25cabc363
link
/test integ-conformance-k8s-tests_istio

unit-tests_istio
a67821a9d7de8382ddbb1f22a4297cb25cabc363
link
/test unit-tests_istio

integ-distroless-k8s-tests_istio
a67821a9d7de8382ddbb1f22a4297cb25cabc363
link
/test integ-distroless-k8s-tests_istio

integ-pilot-k8s-tests_istio
a67821a9d7de8382ddbb1f22a4297cb25cabc363
link
/test integ-pilot-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@bianpengyuan: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-telemetry-k8s-tests_istio
a67821a9d7de8382ddbb1f22a4297cb25cabc363
link
/test integ-telemetry-k8s-tests_istio

integ-conformance-k8s-tests_istio
a67821a9d7de8382ddbb1f22a4297cb25cabc363
link
/test integ-conformance-k8s-tests_istio

unit-tests_istio
a67821a9d7de8382ddbb1f22a4297cb25cabc363
link
/test unit-tests_istio

integ-distroless-k8s-tests_istio
a67821a9d7de8382ddbb1f22a4297cb25cabc363
link
/test integ-distroless-k8s-tests_istio

integ-pilot-k8s-tests_istio
a67821a9d7de8382ddbb1f22a4297cb25cabc363
link
/test integ-pilot-k8s-tests_istio

integ-security-k8s-tests_istio
a67821a9d7de8382ddbb1f22a4297cb25cabc363
link
/test integ-security-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@bianpengyuan: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-telemetry-k8s-tests_istio
a67821a9d7de8382ddbb1f22a4297cb25cabc363
link
/test integ-telemetry-k8s-tests_istio

integ-conformance-k8s-tests_istio
a67821a9d7de8382ddbb1f22a4297cb25cabc363
link
/test integ-conformance-k8s-tests_istio

unit-tests_istio
a67821a9d7de8382ddbb1f22a4297cb25cabc363
link
/test unit-tests_istio

integ-distroless-k8s-tests_istio
a67821a9d7de8382ddbb1f22a4297cb25cabc363
link
/test integ-distroless-k8s-tests_istio

integ-pilot-k8s-tests_istio
a67821a9d7de8382ddbb1f22a4297cb25cabc363
link
/test integ-pilot-k8s-tests_istio

integ-security-k8s-tests_istio
a67821a9d7de8382ddbb1f22a4297cb25cabc363
link
/test integ-security-k8s-tests_istio

integ-mixer-k8s-tests_istio
a67821a9d7de8382ddbb1f22a4297cb25cabc363
link
/test integ-mixer-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@bianpengyuan: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-telemetry-k8s-tests_istio
a67821a9d7de8382ddbb1f22a4297cb25cabc363
link
/test integ-telemetry-k8s-tests_istio

integ-conformance-k8s-tests_istio
a67821a9d7de8382ddbb1f22a4297cb25cabc363
link
/test integ-conformance-k8s-tests_istio

unit-tests_istio
a67821a9d7de8382ddbb1f22a4297cb25cabc363
link
/test unit-tests_istio

integ-distroless-k8s-tests_istio
a67821a9d7de8382ddbb1f22a4297cb25cabc363
link
/test integ-distroless-k8s-tests_istio

integ-pilot-k8s-tests_istio
a67821a9d7de8382ddbb1f22a4297cb25cabc363
link
/test integ-pilot-k8s-tests_istio

integ-security-k8s-tests_istio
a67821a9d7de8382ddbb1f22a4297cb25cabc363
link
/test integ-security-k8s-tests_istio

integ-mixer-k8s-tests_istio
a67821a9d7de8382ddbb1f22a4297cb25cabc363
link
/test integ-mixer-k8s-tests_istio

integ-local-tests_istio
a67821a9d7de8382ddbb1f22a4297cb25cabc363
link
/test integ-local-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@bianpengyuan: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-telemetry-k8s-tests_istio
a67821a9d7de8382ddbb1f22a4297cb25cabc363
link
/test integ-telemetry-k8s-tests_istio

integ-conformance-k8s-tests_istio
a67821a9d7de8382ddbb1f22a4297cb25cabc363
link
/test integ-conformance-k8s-tests_istio

unit-tests_istio
a67821a9d7de8382ddbb1f22a4297cb25cabc363
link
/test unit-tests_istio

integ-distroless-k8s-tests_istio
a67821a9d7de8382ddbb1f22a4297cb25cabc363
link
/test integ-distroless-k8s-tests_istio

integ-pilot-k8s-tests_istio
a67821a9d7de8382ddbb1f22a4297cb25cabc363
link
/test integ-pilot-k8s-tests_istio

integ-security-k8s-tests_istio
a67821a9d7de8382ddbb1f22a4297cb25cabc363
link
/test integ-security-k8s-tests_istio

integ-mixer-k8s-tests_istio
a67821a9d7de8382ddbb1f22a4297cb25cabc363
link
/test integ-mixer-k8s-tests_istio

integ-local-tests_istio
a67821a9d7de8382ddbb1f22a4297cb25cabc363
link
/test integ-local-tests_istio

integ-multicluster-k8s-tests_istio
a67821a9d7de8382ddbb1f22a4297cb25cabc363
link
/test integ-multicluster-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@bianpengyuan: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-telemetry-k8s-tests_istio
a67821a9d7de8382ddbb1f22a4297cb25cabc363
link
/test integ-telemetry-k8s-tests_istio

integ-conformance-k8s-tests_istio
a67821a9d7de8382ddbb1f22a4297cb25cabc363
link
/test integ-conformance-k8s-tests_istio

unit-tests_istio
a67821a9d7de8382ddbb1f22a4297cb25cabc363
link
/test unit-tests_istio

integ-distroless-k8s-tests_istio
a67821a9d7de8382ddbb1f22a4297cb25cabc363
link
/test integ-distroless-k8s-tests_istio

integ-pilot-k8s-tests_istio
a67821a9d7de8382ddbb1f22a4297cb25cabc363
link
/test integ-pilot-k8s-tests_istio

integ-security-k8s-tests_istio
a67821a9d7de8382ddbb1f22a4297cb25cabc363
link
/test integ-security-k8s-tests_istio

integ-mixer-k8s-tests_istio
a67821a9d7de8382ddbb1f22a4297cb25cabc363
link
/test integ-mixer-k8s-tests_istio

integ-local-tests_istio
a67821a9d7de8382ddbb1f22a4297cb25cabc363
link
/test integ-local-tests_istio

integ-multicluster-k8s-tests_istio
a67821a9d7de8382ddbb1f22a4297cb25cabc363
link
/test integ-multicluster-k8s-tests_istio

integ-galley-k8s-tests_istio
a67821a9d7de8382ddbb1f22a4297cb25cabc363
link
/test integ-galley-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@bianpengyuan: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-telemetry-k8s-tests_istio
a67821a9d7de8382ddbb1f22a4297cb25cabc363
link
/test integ-telemetry-k8s-tests_istio

integ-conformance-k8s-tests_istio
a67821a9d7de8382ddbb1f22a4297cb25cabc363
link
/test integ-conformance-k8s-tests_istio

unit-tests_istio
a67821a9d7de8382ddbb1f22a4297cb25cabc363
link
/test unit-tests_istio

integ-distroless-k8s-tests_istio
a67821a9d7de8382ddbb1f22a4297cb25cabc363
link
/test integ-distroless-k8s-tests_istio

integ-pilot-k8s-tests_istio
a67821a9d7de8382ddbb1f22a4297cb25cabc363
link
/test integ-pilot-k8s-tests_istio

integ-security-k8s-tests_istio
a67821a9d7de8382ddbb1f22a4297cb25cabc363
link
/test integ-security-k8s-tests_istio

integ-mixer-k8s-tests_istio
a67821a9d7de8382ddbb1f22a4297cb25cabc363
link
/test integ-mixer-k8s-tests_istio

integ-local-tests_istio
a67821a9d7de8382ddbb1f22a4297cb25cabc363
link
/test integ-local-tests_istio

integ-multicluster-k8s-tests_istio
a67821a9d7de8382ddbb1f22a4297cb25cabc363
link
/test integ-multicluster-k8s-tests_istio

integ-galley-k8s-tests_istio
a67821a9d7de8382ddbb1f22a4297cb25cabc363
link
/test integ-galley-k8s-tests_istio

release-test_istio
a67821a9d7de8382ddbb1f22a4297cb25cabc363
link
/test release-test_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/retest

@bianpengyuan: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-telemetry-k8s-tests_istio
a67821a9d7de8382ddbb1f22a4297cb25cabc363
link
/test integ-telemetry-k8s-tests_istio

integ-distroless-k8s-tests_istio
a67821a9d7de8382ddbb1f22a4297cb25cabc363
link
/test integ-distroless-k8s-tests_istio

integ-pilot-k8s-tests_istio
a67821a9d7de8382ddbb1f22a4297cb25cabc363
link
/test integ-pilot-k8s-tests_istio

integ-security-k8s-tests_istio
a67821a9d7de8382ddbb1f22a4297cb25cabc363
link
/test integ-security-k8s-tests_istio

integ-multicluster-k8s-tests_istio
a67821a9d7de8382ddbb1f22a4297cb25cabc363
link
/test integ-multicluster-k8s-tests_istio

release-test_istio
a67821a9d7de8382ddbb1f22a4297cb25cabc363
link
/test release-test_istio

integ-mixer-k8s-tests_istio
a67821a9d7de8382ddbb1f22a4297cb25cabc363
link
/test integ-mixer-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@bianpengyuan: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-telemetry-k8s-tests_istio
a67821a9d7de8382ddbb1f22a4297cb25cabc363
link
/test integ-telemetry-k8s-tests_istio

integ-distroless-k8s-tests_istio
a67821a9d7de8382ddbb1f22a4297cb25cabc363
link
/test integ-distroless-k8s-tests_istio

integ-pilot-k8s-tests_istio
a67821a9d7de8382ddbb1f22a4297cb25cabc363
link
/test integ-pilot-k8s-tests_istio

integ-security-k8s-tests_istio
a67821a9d7de8382ddbb1f22a4297cb25cabc363
link
/test integ-security-k8s-tests_istio

integ-mixer-k8s-tests_istio
a67821a9d7de8382ddbb1f22a4297cb25cabc363
link
/test integ-mixer-k8s-tests_istio

integ-multicluster-k8s-tests_istio
a67821a9d7de8382ddbb1f22a4297cb25cabc363
link
/test integ-multicluster-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@bianpengyuan: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-telemetry-k8s-tests_istio
a67821a9d7de8382ddbb1f22a4297cb25cabc363
link
/test integ-telemetry-k8s-tests_istio

integ-pilot-k8s-tests_istio
a67821a9d7de8382ddbb1f22a4297cb25cabc363
link
/test integ-pilot-k8s-tests_istio

integ-security-k8s-tests_istio
a67821a9d7de8382ddbb1f22a4297cb25cabc363
link
/test integ-security-k8s-tests_istio

integ-mixer-k8s-tests_istio
a67821a9d7de8382ddbb1f22a4297cb25cabc363
link
/test integ-mixer-k8s-tests_istio

integ-multicluster-k8s-tests_istio
a67821a9d7de8382ddbb1f22a4297cb25cabc363
link
/test integ-multicluster-k8s-tests_istio

integ-distroless-k8s-tests_istio
a67821a9d7de8382ddbb1f22a4297cb25cabc363
link
/test integ-distroless-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/retest

@bianpengyuan: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-telemetry-k8s-tests_istio
a67821a9d7de8382ddbb1f22a4297cb25cabc363
link
/test integ-telemetry-k8s-tests_istio

integ-pilot-k8s-tests_istio
a67821a9d7de8382ddbb1f22a4297cb25cabc363
link
/test integ-pilot-k8s-tests_istio

integ-security-k8s-tests_istio
a67821a9d7de8382ddbb1f22a4297cb25cabc363
link
/test integ-security-k8s-tests_istio

integ-mixer-k8s-tests_istio
a67821a9d7de8382ddbb1f22a4297cb25cabc363
link
/test integ-mixer-k8s-tests_istio

integ-multicluster-k8s-tests_istio
a67821a9d7de8382ddbb1f22a4297cb25cabc363
link
/test integ-multicluster-k8s-tests_istio

integ-distroless-k8s-tests_istio
a67821a9d7de8382ddbb1f22a4297cb25cabc363
link
/test integ-distroless-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@bianpengyuan: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-pilot-k8s-tests_istio
a67821a9d7de8382ddbb1f22a4297cb25cabc363
link
/test integ-pilot-k8s-tests_istio

integ-security-k8s-tests_istio
a67821a9d7de8382ddbb1f22a4297cb25cabc363
link
/test integ-security-k8s-tests_istio

integ-mixer-k8s-tests_istio
a67821a9d7de8382ddbb1f22a4297cb25cabc363
link
/test integ-mixer-k8s-tests_istio

integ-multicluster-k8s-tests_istio
a67821a9d7de8382ddbb1f22a4297cb25cabc363
link
/test integ-multicluster-k8s-tests_istio

integ-distroless-k8s-tests_istio
a67821a9d7de8382ddbb1f22a4297cb25cabc363
link
/test integ-distroless-k8s-tests_istio

integ-telemetry-k8s-tests_istio
a67821a9d7de8382ddbb1f22a4297cb25cabc363
link
/test integ-telemetry-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@bianpengyuan: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-pilot-k8s-tests_istio
a67821a9d7de8382ddbb1f22a4297cb25cabc363
link
/test integ-pilot-k8s-tests_istio

integ-security-k8s-tests_istio
a67821a9d7de8382ddbb1f22a4297cb25cabc363
link
/test integ-security-k8s-tests_istio

integ-multicluster-k8s-tests_istio
a67821a9d7de8382ddbb1f22a4297cb25cabc363
link
/test integ-multicluster-k8s-tests_istio

integ-distroless-k8s-tests_istio
a67821a9d7de8382ddbb1f22a4297cb25cabc363
link
/test integ-distroless-k8s-tests_istio

integ-telemetry-k8s-tests_istio
a67821a9d7de8382ddbb1f22a4297cb25cabc363
link
/test integ-telemetry-k8s-tests_istio

integ-mixer-k8s-tests_istio
a67821a9d7de8382ddbb1f22a4297cb25cabc363
link
/test integ-mixer-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@bianpengyuan: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-security-k8s-tests_istio
a67821a9d7de8382ddbb1f22a4297cb25cabc363
link
/test integ-security-k8s-tests_istio

integ-multicluster-k8s-tests_istio
a67821a9d7de8382ddbb1f22a4297cb25cabc363
link
/test integ-multicluster-k8s-tests_istio

integ-distroless-k8s-tests_istio
a67821a9d7de8382ddbb1f22a4297cb25cabc363
link
/test integ-distroless-k8s-tests_istio

integ-telemetry-k8s-tests_istio
a67821a9d7de8382ddbb1f22a4297cb25cabc363
link
/test integ-telemetry-k8s-tests_istio

integ-mixer-k8s-tests_istio
a67821a9d7de8382ddbb1f22a4297cb25cabc363
link
/test integ-mixer-k8s-tests_istio

integ-pilot-k8s-tests_istio
a67821a9d7de8382ddbb1f22a4297cb25cabc363
link
/test integ-pilot-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@bianpengyuan: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-multicluster-k8s-tests_istio
a67821a9d7de8382ddbb1f22a4297cb25cabc363
link
/test integ-multicluster-k8s-tests_istio

integ-distroless-k8s-tests_istio
a67821a9d7de8382ddbb1f22a4297cb25cabc363
link
/test integ-distroless-k8s-tests_istio

integ-telemetry-k8s-tests_istio
a67821a9d7de8382ddbb1f22a4297cb25cabc363
link
/test integ-telemetry-k8s-tests_istio

integ-mixer-k8s-tests_istio
a67821a9d7de8382ddbb1f22a4297cb25cabc363
link
/test integ-mixer-k8s-tests_istio

integ-pilot-k8s-tests_istio
a67821a9d7de8382ddbb1f22a4297cb25cabc363
link
/test integ-pilot-k8s-tests_istio

integ-security-k8s-tests_istio
a67821a9d7de8382ddbb1f22a4297cb25cabc363
link
/test integ-security-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@bianpengyuan: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-distroless-k8s-tests_istio
a67821a9d7de8382ddbb1f22a4297cb25cabc363
link
/test integ-distroless-k8s-tests_istio

integ-telemetry-k8s-tests_istio
a67821a9d7de8382ddbb1f22a4297cb25cabc363
link
/test integ-telemetry-k8s-tests_istio

integ-mixer-k8s-tests_istio
a67821a9d7de8382ddbb1f22a4297cb25cabc363
link
/test integ-mixer-k8s-tests_istio

integ-pilot-k8s-tests_istio
a67821a9d7de8382ddbb1f22a4297cb25cabc363
link
/test integ-pilot-k8s-tests_istio

integ-security-k8s-tests_istio
a67821a9d7de8382ddbb1f22a4297cb25cabc363
link
/test integ-security-k8s-tests_istio

integ-multicluster-k8s-tests_istio
a67821a9d7de8382ddbb1f22a4297cb25cabc363
link
/test integ-multicluster-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Didn't find a registered implementation for name: 'istio.stats'
On Sat, Apr 25, 2020, 12:02 AM Istio Automation<EMAIL_ADDRESS>wrote:

@bianpengyuan https://github.com/bianpengyuan: The following tests
failed, say /retest to rerun all failed tests:
Test name Commit Details Rerun command
integ-distroless-k8s-tests_istio a67821a
https://github.com/istio/istio/commit/a67821a9d7de8382ddbb1f22a4297cb25cabc363
link
https://prow.istio.io/view/gcs/istio-prow/pr-logs/pull/istio_istio/23265/integ-distroless-k8s-tests_istio/5129 /test
integ-distroless-k8s-tests_istio
integ-telemetry-k8s-tests_istio a67821a
https://github.com/istio/istio/commit/a67821a9d7de8382ddbb1f22a4297cb25cabc363
link
https://prow.istio.io/view/gcs/istio-prow/pr-logs/pull/istio_istio/23265/integ-telemetry-k8s-tests_istio/11905 /test
integ-telemetry-k8s-tests_istio
integ-mixer-k8s-tests_istio a67821a
https://github.com/istio/istio/commit/a67821a9d7de8382ddbb1f22a4297cb25cabc363
link
https://prow.istio.io/view/gcs/istio-prow/pr-logs/pull/istio_istio/23265/integ-mixer-k8s-tests_istio/10318 /test
integ-mixer-k8s-tests_istio
integ-pilot-k8s-tests_istio a67821a
https://github.com/istio/istio/commit/a67821a9d7de8382ddbb1f22a4297cb25cabc363
link
https://prow.istio.io/view/gcs/istio-prow/pr-logs/pull/istio_istio/23265/integ-pilot-k8s-tests_istio/11968 /test
integ-pilot-k8s-tests_istio
integ-security-k8s-tests_istio a67821a
https://github.com/istio/istio/commit/a67821a9d7de8382ddbb1f22a4297cb25cabc363
link
https://prow.istio.io/view/gcs/istio-prow/pr-logs/pull/istio_istio/23265/integ-security-k8s-tests_istio/12120 /test
integ-security-k8s-tests_istio
integ-multicluster-k8s-tests_istio a67821a
https://github.com/istio/istio/commit/a67821a9d7de8382ddbb1f22a4297cb25cabc363
link
https://prow.istio.io/view/gcs/istio-prow/pr-logs/pull/istio_istio/23265/integ-multicluster-k8s-tests_istio/2408 /test
integ-multicluster-k8s-tests_istio
Instructions for interacting with me using PR comments are available here
https://git.k8s.io/community/contributors/guide/pull-requests.md. If
you have questions or suggestions related to my behavior, please file an
issue against the kubernetes/test-infra
https://github.com/kubernetes/test-infra/issues/new?title=Prow issue:
repository. I understand the commands that are listed here
https://go.k8s.io/bot-commands.
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
https://github.com/istio/istio/pull/23265#issuecomment-619332946, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AAEYGXM6HNR4OST3MOKAFELROKDIVANCNFSM4MQSEZLA
.

/cherrypick release-1.6

@jacob-delgado: once the present PR merges, I will cherry-pick it on top of release-1.6 in a new PR and assign it to you.

In response to this:

/cherrypick release-1.6

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@bianpengyuan: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-telemetry-k8s-tests_istio
a67821a9d7de8382ddbb1f22a4297cb25cabc363
link
/test integ-telemetry-k8s-tests_istio

integ-mixer-k8s-tests_istio
a67821a9d7de8382ddbb1f22a4297cb25cabc363
link
/test integ-mixer-k8s-tests_istio

integ-pilot-k8s-tests_istio
a67821a9d7de8382ddbb1f22a4297cb25cabc363
link
/test integ-pilot-k8s-tests_istio

integ-security-k8s-tests_istio
a67821a9d7de8382ddbb1f22a4297cb25cabc363
link
/test integ-security-k8s-tests_istio

integ-multicluster-k8s-tests_istio
a67821a9d7de8382ddbb1f22a4297cb25cabc363
link
/test integ-multicluster-k8s-tests_istio

integ-distroless-k8s-tests_istio
d878479f52f4e6bfabcd1b9ab041a6b8a91d7b22
link
/test integ-distroless-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@bianpengyuan: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-telemetry-k8s-tests_istio
a67821a9d7de8382ddbb1f22a4297cb25cabc363
link
/test integ-telemetry-k8s-tests_istio

integ-pilot-k8s-tests_istio
a67821a9d7de8382ddbb1f22a4297cb25cabc363
link
/test integ-pilot-k8s-tests_istio

integ-security-k8s-tests_istio
a67821a9d7de8382ddbb1f22a4297cb25cabc363
link
/test integ-security-k8s-tests_istio

integ-multicluster-k8s-tests_istio
a67821a9d7de8382ddbb1f22a4297cb25cabc363
link
/test integ-multicluster-k8s-tests_istio

integ-distroless-k8s-tests_istio
d878479f52f4e6bfabcd1b9ab041a6b8a91d7b22
link
/test integ-distroless-k8s-tests_istio

integ-mixer-k8s-tests_istio
d878479f52f4e6bfabcd1b9ab041a6b8a91d7b22
link
/test integ-mixer-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@bianpengyuan: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-telemetry-k8s-tests_istio
a67821a9d7de8382ddbb1f22a4297cb25cabc363
link
/test integ-telemetry-k8s-tests_istio

integ-pilot-k8s-tests_istio
a67821a9d7de8382ddbb1f22a4297cb25cabc363
link
/test integ-pilot-k8s-tests_istio

integ-security-k8s-tests_istio
a67821a9d7de8382ddbb1f22a4297cb25cabc363
link
/test integ-security-k8s-tests_istio

integ-distroless-k8s-tests_istio
d878479f52f4e6bfabcd1b9ab041a6b8a91d7b22
link
/test integ-distroless-k8s-tests_istio

integ-mixer-k8s-tests_istio
d878479f52f4e6bfabcd1b9ab041a6b8a91d7b22
link
/test integ-mixer-k8s-tests_istio

integ-multicluster-k8s-tests_istio
d878479f52f4e6bfabcd1b9ab041a6b8a91d7b22
link
/test integ-multicluster-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@bianpengyuan: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-telemetry-k8s-tests_istio
a67821a9d7de8382ddbb1f22a4297cb25cabc363
link
/test integ-telemetry-k8s-tests_istio

integ-pilot-k8s-tests_istio
a67821a9d7de8382ddbb1f22a4297cb25cabc363
link
/test integ-pilot-k8s-tests_istio

integ-security-k8s-tests_istio
a67821a9d7de8382ddbb1f22a4297cb25cabc363
link
/test integ-security-k8s-tests_istio

integ-mixer-k8s-tests_istio
d878479f52f4e6bfabcd1b9ab041a6b8a91d7b22
link
/test integ-mixer-k8s-tests_istio

integ-multicluster-k8s-tests_istio
d878479f52f4e6bfabcd1b9ab041a6b8a91d7b22
link
/test integ-multicluster-k8s-tests_istio

integ-distroless-k8s-tests_istio
1d9658cf8a41ced38c3927352ce09c79d70cb9ad
link
/test integ-distroless-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@bianpengyuan: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-telemetry-k8s-tests_istio
a67821a9d7de8382ddbb1f22a4297cb25cabc363
link
/test integ-telemetry-k8s-tests_istio

integ-pilot-k8s-tests_istio
a67821a9d7de8382ddbb1f22a4297cb25cabc363
link
/test integ-pilot-k8s-tests_istio

integ-security-k8s-tests_istio
a67821a9d7de8382ddbb1f22a4297cb25cabc363
link
/test integ-security-k8s-tests_istio

integ-multicluster-k8s-tests_istio
d878479f52f4e6bfabcd1b9ab041a6b8a91d7b22
link
/test integ-multicluster-k8s-tests_istio

integ-distroless-k8s-tests_istio
1d9658cf8a41ced38c3927352ce09c79d70cb9ad
link
/test integ-distroless-k8s-tests_istio

integ-mixer-k8s-tests_istio
1d9658cf8a41ced38c3927352ce09c79d70cb9ad
link
/test integ-mixer-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@bianpengyuan: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-telemetry-k8s-tests_istio
a67821a9d7de8382ddbb1f22a4297cb25cabc363
link
/test integ-telemetry-k8s-tests_istio

integ-pilot-k8s-tests_istio
a67821a9d7de8382ddbb1f22a4297cb25cabc363
link
/test integ-pilot-k8s-tests_istio

integ-security-k8s-tests_istio
a67821a9d7de8382ddbb1f22a4297cb25cabc363
link
/test integ-security-k8s-tests_istio

integ-multicluster-k8s-tests_istio
d878479f52f4e6bfabcd1b9ab041a6b8a91d7b22
link
/test integ-multicluster-k8s-tests_istio

integ-mixer-k8s-tests_istio
1d9658cf8a41ced38c3927352ce09c79d70cb9ad
link
/test integ-mixer-k8s-tests_istio

integ-distroless-k8s-tests_istio
513f4b84d8028f227f7fa5072cd7acdc41882997
link
/test integ-distroless-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@bianpengyuan: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-telemetry-k8s-tests_istio
a67821a9d7de8382ddbb1f22a4297cb25cabc363
link
/test integ-telemetry-k8s-tests_istio

integ-pilot-k8s-tests_istio
a67821a9d7de8382ddbb1f22a4297cb25cabc363
link
/test integ-pilot-k8s-tests_istio

integ-security-k8s-tests_istio
a67821a9d7de8382ddbb1f22a4297cb25cabc363
link
/test integ-security-k8s-tests_istio

integ-multicluster-k8s-tests_istio
d878479f52f4e6bfabcd1b9ab041a6b8a91d7b22
link
/test integ-multicluster-k8s-tests_istio

integ-distroless-k8s-tests_istio
513f4b84d8028f227f7fa5072cd7acdc41882997
link
/test integ-distroless-k8s-tests_istio

integ-mixer-k8s-tests_istio
513f4b84d8028f227f7fa5072cd7acdc41882997
link
/test integ-mixer-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@bianpengyuan: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-security-k8s-tests_istio
a67821a9d7de8382ddbb1f22a4297cb25cabc363
link
/test integ-security-k8s-tests_istio

integ-multicluster-k8s-tests_istio
d878479f52f4e6bfabcd1b9ab041a6b8a91d7b22
link
/test integ-multicluster-k8s-tests_istio

integ-mixer-k8s-tests_istio
513f4b84d8028f227f7fa5072cd7acdc41882997
link
/test integ-mixer-k8s-tests_istio

integ-telemetry-k8s-tests_istio
136fe7254d618d5a3162bc743fa6c8ba42daa012
link
/test integ-telemetry-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@jacob-delgado: new pull request created: #23276

In response to this:

/cherrypick release-1.6

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.


device: refactor to simplify maintenance

DEVICE_AND_API_INIT and DEVICE_DEFINE are identical except that DEVICE_DEFINE adds a parameter providing the device pm control function, while DEVICE_AND_API_INIT does not.  This requires duplicate implementations where if CONFIG_DEVICE_POWER_MANAGEMENT is enabled then DEVICE_AND_API_INIT delegates to DEVICE_DEFINE with a dummy pm control function, and if it is not enabled then DEVICE_DEFINE discards the parameter and delegates to DEVICE_AND_API_INIT.
DEVICE_INIT is like DEVICE_AND_API_INIT but doesn't provide an API.
Clean this up by refactoring so that DEVICE_DEFINE is the core implementation, providing with and without device power management right next to each other where they can be compared and maintained. Redefine DEVICE_INIT and DEVICE_AND_API_INIT delegate to DEVICE_DEFINE.
Also remove duplicate code by extracting the variations due to enabling device power management into macros.
This is a step intended to simplify providing dependency information for #22545 and related PRs.

@tbursztyka could you please take a quick look?


Bluetooth: Fix default event size when periodic adv sync is enabled

Periodic Advertising reports can be up to 255.
Signed-off-by: Rubin Gerritsen<EMAIL_ADDRESS>

Looks good to me. BT_PER_ADV is for sending and BT_PER_ADV_SYNC is for receiving.
(I think it would be nice if they were called BT_PER_ADV_RX and BT_PER_ADV_TX. But this is out of this PRs scope.)


Does hyper reject trailers that contain pseudo-header fields?

Spotted in RFC 7540 section <IP_ADDRESS>:

Pseudo-header fields MUST NOT appear in trailers.

Does hyper enforce this rule? Should it?
I’d expect this rule to be enforced in the validate_headers() pipeline, but that’s only just learnt how to distinguish between trailers and non-trailers, so I don’t think it would have been able to enforce this rule.

That's easily checked: write a test, see what happens!

It looks like this may have been patched in #289?

I don't know that anyone actually wrote a test for this. @nateprewitt, want to contribute a test for this specific case so that we can really consider this closed?

Sure, I'd be happy to give it a go.

I’m not sure #289 does address this. At least, I can’t see it at a quick glance of the code, and I don’t remember writing anything to explicitly cover this case (test or otherwise).

Resolved by #305.

@Lukasa Err, is this resolved or not?

Yes. I have got exactly no idea why this exploded everywhere.


Pandas version unpin

Reference issue
Fixes #425
What does this implement/fix?
Removed pandas version pinning
Additional information
I recommend devs take a look at pyqt5 dependencies as well.

Thanks for the PR @FuriouslyCurious this is great.
It seems there is some other CI issues that are causing errors. I tried to quickly fix these in #427, but its still not green.
I am on leave until the end of January, so won't be able to knuckle down and tackle this till then. But I can review PRs in the meantime if you can get the CIs green.

@FuriouslyCurious the CI issues should be fixed now. Could you please rebase and see if that fixes the checks.
Thanks for the PR!

Hi @rob-luke , I tried a couple of times to rebase and pull but CircleCI tests are failing.  Latest attempt is in pull req #431 .


Lock has no control

Please check Services, Known Bug / Issues and Troubleshooting over here first: https://github.com/fuatakgun/eufy_security/blob/master/README.md
Describe the bug
There’s no way to unlock the smart lock T8510. All I have is global motion sensor.
To Reproduce
Steps to reproduce the behavior:
Link the lock, and check the available entitles
**

I have the same issue since the update in that the entity has become unavailable.
Thank you

I have the same issue with the lock. No Lock entity is seen in the integration after the update.

The 2.2.6 update appears to have fixed the T8520 not having a lock control entity in HA. All working again 👍

@203Null is it working for you now? If so we will close this case.

@203Null is it working for you now? If so we will close this case.

Fixed, sorry for the late reply. I wasn't at my place during that time and I completely forgot about it until now.


Open calls branch

This PR builds on last year's work to put together a simplified platform for open calls. It isn't meant to be merged, but rather to record the work done so far for easy future reference. In fact, the idea is to have open call devs use the new open-calls branch of this PR. (I deleted the old oc branch from last year since this open-calls branch is an improved version.)
Work done so far

Bootstrap procedure. Got rewritten to make to tailor it to open call devs. New doc here.
No security. Zapped all sec features/services, including Keycloak. But we keep Reloader to be able to automatically reload pods if secrets change.
Plain K8s secrets. Using plain old secrets with a manual procedure, outside of the GitOps pipeline.
App services. The only two we included are Roughnator and Dazzler, mostly to serve as live examples.
IaC. ArgoCD sources build recipes, app, etc. from the open-calls branch instead of main---which is what we use for the kitt4sme.collab-cloud.eu cluster.

@kostasgrevenitis @karikolehmainen @RyanKelvinFord please test thoroughly :-)


improve docs and images in maxmind license docs

Great job, one small suggestion then we can merge! Thank you for the contribution! 🚀

Done 👍