Error using TimeWeightedVectorStoreRetriever.get_relevant_documents with FAISS: 'FAISS' object has no attribute 'similarity_search_with_relevance_scores'

I'm exploring this great notebook and trying to produce something similar, however I get an error when fetch_memories calls self.memory_retriever.get_relevant_documents(observation):
AttributeError: 'FAISS' object has no attribute 'similarity_search_with_relevance_scores'

I'm running langchain 0.0.144 and I've installed faiss using conda install -c conda-forge faiss-cpu (as indicated here) which installed version 1.7.2. Also running python 3.10.
Poking inside faiss.py I indeed can't find a method called similarity_search_with_relevance_scores, only one called _similarity_search_with_relevance_scores.
Which version(s) of langchain and faiss should I be running for this to work?
Any help would be greatly appreciated, thanks 🙏

Same here using Weaviate. And that's not all. The example for "vectorstores" and babyagi for example flat out does not work because the core of langchain isn't keeping track of the new features put in and make sure the old functionality still works. PRs without a single automated test are getting merged to master. The ones that do have tests don't cover the example code in the notebook. I like jupyter but it's getting way overused by everyone at the moment. It's not a substitute for documentation or a real life functioning example. At this moment the dev experience at the moment is not great, because with every error I get I don't know if it's my code, or langchain that's causing the issue.

Hey @Ryangr0 for what it's worth I managed to resolve my issue by re-installing all my dependencies in a fresh conda environment 😅

This is actually still not working for me, and I know why. Weaviate doesn't have this implemented either. Is there any way for me to get this under attention?

I'm no longer facing this issue, thanks. Not sure about @Ryangr0.


Support weekofyear pushdown to tiflash

What problem does this PR solve?
Issue Number: close #4677
Problem Summary:
What is changed and how it works?
Check List
Tests

[x] Unit test
[ ] Integration test
[ ] Manual test (add detailed scripts or steps below)
[ ] No code

Side effects

[ ] Performance regression: Consumes more CPU
[ ] Performance regression: Consumes more Memory
[ ] Breaking backward compatibility

Documentation

[ ] Affects user behaviors
[ ] Contains syntax changes
[ ] Contains variable changes
[ ] Contains experimental features
[ ] Changes MySQL compatibility

Release note

Support weekofyear pushdown to tiflash

/run-all-tests

/merge


Rpi3 Support

line 960 of servod.c needs to check for BCM2835 in order to eliminate the 'cannot parse hardware name'  error and allow the code to work.

Thanks - I've made that change now.


A

.

Related Issues

c #14361 (closed)
.  #17781 (closed)
. #26423 (closed)
. #44665 (closed)
. #66738 (closed)
- #69844 (closed)
- #66830 (closed)
- #68536 (closed)
- #69474 (closed)
- #69755 (closed)

(Emoji vote if this was helpful or unhelpful; more detailed feedback welcome in this discussion.)


CRDL-73 - Store message from the public-soap-proxy in MongoDB

Do we want to change the ttl in configuration to a duration rather than a number of days. From a previous prject you can do in the AppConfig.scala
lazy val journeyRecordTTL: Duration = Duration(servicesConfig.getString("journey.record.duration")) and in the application.conf
journey.record.duration = 7 days

We need to update the README.md


Updates to docs and pre-push

Amend version referenced in README.
Add release notes for 0.4.
Update pre-push to use rustup in lieu of multirust.

Coverage increased (+0.9%) to 83.275% when pulling 43a2df4a13111fb2ba28cb9afa1b1ecda61f8504 on tikue:update-releases into 32e0b0d7f83b9c54df1aaf8aa942a73f4b7f5b29 on google:master.


Update PHP versions for Azure Web Apps

Hello,
I've updated information regarding PHP versions on Azure Web Apps. Indeed, PHP 5.4 is not available anymore (and PHP 7.0 is).
Also, php_mongo.dll is not compatible with PHP 7.0. I've removed this exemple to avoid confusion.
Thanks!

This seems like a small (but important) contribution, so no Contribution License Agreement is required at this point. We will now review your pull request.
Thanks,
Microsoft Pull Request Bot

@aerialls : Thanks for your contribution to the Azure documentation! The author, @rmcmurray, has been notified to review your proposed change.

Any update? / ping @rmcmurray

@aerialls, sorry for the delayed response - I was away on vacation. ;-)
I am checking this now.

The suggested changes look good to me - thanks!
#sign-off


windows: Fixes MAC fetching during gateway-init

There is a known issue with OVS not correctly picking up the
physical network interface MAC address.
Gateway-init will fail on the Windows node when trying to add
the router port with a different MAC than the initial one. This
happens after node reboot.
As a workaround, fetch the MAC address via powershell if
it is not picked up from OVS.
Fixes #516
Signed-off-by: Alin-Gheorghe Balutoiu<EMAIL_ADDRESS>

cc @aserdean

Tested with 1709, 1803 and 2019.


[test] serve static html files

Since this isn't working due to lack of npm packages, I'm not going to merge it yet.


训练Faster RCNN实例cuDNN库报错,MobileNetV3-ssld模型正常

报错信息如下'
Could not load library libcudnn_cnn_train.so.8. Error: /home/xxx/anaconda3/envs/py38-paddle2.1/bin/../lib/libcudnn_ops_train.so.8: symbol _Z22cudnnGenericOpTensorNdILi3EE13cudnnStatus_tP12cudnnContext16cudnnGenericOp_t21cudnnNanPropagation_tPKdPKvPK17cudnnTensorStructS8_S8_SB_S8_S8_SB_Pv version libcudnn_ops_infer.so.8 not defined in file libcudnn_ops_infer.so.8 with link time reference
Please make sure libcudnn_cnn_train.so.8 is in your library path!
Please make sure libcudnn_cnn_train.so.8 is in your library path!

Please make sure libcudnn_cnn_train.so.8 is in your library path!

尝试下把cudnn添加到LD_LIBRARY_PATH


Game tools is not disconnecting all the connections between rig and model

some connections still active and the rig is also exported when the model is exported

the eyelid rigger have a bad naming in the option

the eyelid rigger have a bad naming in the option

this was related to a bad configuration on the eye rigger https://github.com/mgear-dev/rigbits/issues/37

this was related to a bad configuration on the eye rigger https://github.com/mgear-dev/rigbits/issues/37


SessionManager creates instance of $requestedName

In order to extend the behaviour and functionality of the (default) SessionManager in an application, one still wants to use the default factory with all its logic reading config and setting up the manager.
This isn't possible if the class instantiated by the factory is hard-coded. This PR wants to solve this  by considering the $requestedName parameter when creating a SessionManager instance. With a simple alias one can now create extended session managers.

Thanks, @thomascube

Merged to develop for release with 2.8.0.


Restrict resource location fields

(To be labelled spec-datapackage)
Apologies if this has been discussed before.
Can you elaborate on or give a use case as for why resources are allowed to have url, path and data at the same time? I can see how path (plus base) and url might point to the same thing, but all other combinations seem to suggest different versions of the actual data. Regardless of this, you want to make sure that different consumers are getting and working with the same data so allowing ambiguity around its location doesn't seem right to me.
Why not require one and only one of them?

@amercader only one is required. However, users can specific more than one without making the Data Package "Invalid".
I think the point you raise is that only one should be specified. I think there was originally a logic to this in that, for example, you might download a data package that had a url specified and then cache the data locally and set the path. However, I think this is both unlikely and confusing - in such cases delete the url and specify it in some other way.
Thus, thinking about it now I think we should probably state that one and only one of these should be present ;-)

That's exactly what I was suggesting, that publishers need to pick one of the three. It makes life of datapackages consumers much easier and avoid ambiguity.

@amercader do you want to have a stab at a pull request to make this change - should be pretty simple language change. Do remember to note it in the changelog at the top of the file as it is strictly a "breaking change" and please put [!] at the start of the git commit message as it allows me to track breaking changes ;-)

sure, will do

@davidread do you have any views on this? After checking your implementation of a Data Package on DGU I noticed that you use both url and path on the datapackage.json file, url pointing to the online file and path to the local zipped one. That actually makes a lot of sense when you are downloading a zip file with datapackage.json plus data files. I'm now less eager to enforce only one of them, although we can provide some more guidance on the spec.

@morty, you coded the DGU one, do you want to comment?

OK, I included url and path in our datapackage.json file because of the way in which these are used in tools like dpm which download the data from the url and put it into a file defined by the path. This allowed us to specify how files with duplicate names would be stored when downloaded. There is a link to just the datapackage.json for each dataset, but it's tucked away in menu. e.g:
https://test.data.gov.uk/dataset/driving-licence-data/datapackage.json
Likewise if a datapackage.json had inline data in the data field where would a tool processing that file put the data on the file system so that it could be accessed (by non datapackage aware tools) if there is no path specified? Maybe you could use the name, but that's optional and wouldn't result in the correct file ending so would cause problems on Windows for example.
The spec also seems to suggest you could define a base URL for the whole datapackage and then path would give the URL of the resource relative to that base URL.
The three seem to change use depending on the context.
There seems to be a bit of confusion about what a datapackage is. Rufus was surprised that we had zipped up resources along with the datapackage.json and called that a datapackage. Until there is more tooling around datapackage that will show up more concrete use cases it's hard to nail down.

thanks @morty that was really useful. I'm now convinced that given the flexibility (or ambiguity) of the spec it doesn't make sense to enforce only one of the fields. I'll close this now.
As for the "what exactly is a Data Package" question, I agree 100%. All devs I've met so far (myself included) initially thought about the Data Package as a zipped datapackage.json plus data files. I think the spec doesn't do a great job of clarifying what exactly the Data Package is, but that should be a separate issue.

@amercader I'd actually like to reopen at least to clarify order of processing. Based on @morty comment and my own experience i think processing order needs to be corrected to data, url, then path (?). I'm also still concerned that your experience is quite common and that having multiple options will lead to confusion (even in my suggested change there are some issues: e.g. when download from DGU you may want to process url not path - path won't work in fact - but in other circumstances e.g. you now have the data package on your local machine you want to use path not url ...)

OK, I've come to a definite conclusion that one and only one of these should be present on a data package resource at a time -- this issue already demonstrates how the current multiple allowed values results in confusion.
@morty your points are really good and similar to why i originally allowed this (as you note re dpm). However, I now think it leads to too much confusion as it isn't really clear how things should work.
If we want to support things like specifying where a resource with a url should be stored locally I think we probably want a separate field rather than (ab)using path or just define a standard algorithm.

FIXED.

I'm not too excited by this. I think there is a clear use case for allowing url, path and data, as long as we get more explicit on the resolution order across those.
Use Case:
OpenSpending Next stores all data in Data Package format. When a user adds a Data Package, that user can of course include resources from publicly-accessible URLs. However, in order to ensure data is always available, we would like to also store a local copy of that resource. In the Data Package, that means there would be, for each resource, the url field for the original data source the user added, and path would be the local version of the same. If the URL ever went offline, we'd still use the local file accessible via path.
I think this use case is critical considering the distributed nature of data packages and the fact that URLs do die. The pattern I describe is so important to availability of data in data registries that support Data Package that I think we should not only revert this change, but make such a pattern much more explicit :).

@pwalsh do you know of any existing examples for this pattern?
On Feb 1, 2016 09:54, "Paul Walsh"<EMAIL_ADDRESS>wrote:

Reopened #223 https://github.com/dataprotocols/dataprotocols/issues/223.
—
Reply to this email directly or view it on GitHub
https://github.com/dataprotocols/dataprotocols/issues/223#event-533742625
.

@danfowler I just gave a very clear use case, that we really should implement in OpenSpending in order to ensure we always have source data available to rebuild databases that are derived from the datastore. As OpenSpending is already the biggest potential deployment of Data Package to date, is that not a good example?

@danfowler @rgrp I am definitely happy enough if you still decide this is irreversible, but in such a case, for reasons listed above, OpenSpending (and even other data stores like the coming reboot of the Data Package Registry) would likely still implement a local path for a URL to ensure availability of data. In such cases we could store this path on a field called cache or something to make the reasoning clearer and to ensure we are not going against the spec.

@pwalsh very sensible questions. I do have thoughts:

"source" vs "path to the data": you can use the sources property primarily defined on data package on resources. This sources property can be used to point to other "source" version of the data whilst url / path / data point to the actual primary version stored with this data package
"archived / backup" copies: I think this is a definite use case. However, my sense is that we should make this explicit rather than have complex semantics for url / path / data. e.g. we could have a property called archives or similar. If we want this we can open a specific issue for this.

For OS specifically I am increasingly of the view that:

You should copy local the data the user gives you. If it is backup (so url is in the resource) then put it in the archive/ directory and we reference appropriately
Often you will end up with local data as you will need to tweak or transform. In which case just use sources for the original data (though even here i would copy a version locally into archives/)

TBH I never thought of sources like that, and while it def. works, it feels like too much information for this use case (sources has the same footprint as resources, essentially).
For the use case I outline, I agree, let's not overload path, url, data with this (so: let's close this ticket again), but also let's not use archives either, as we already have a convention for archive in DP.
Suggestion: A resource can have a cache property which is always a local path to a file representation of path, url, data. If we want to consider that as part of spec, let's open an issue for it. If not, we can first just implement this pattern in OS and see how it develops.

sources is more limited than a resource in that it only 3/4 properties I think
we have no convention for archive yet in DP afaik. We have a convention for the archives/ directory but no property in the datapackage.json.
I like cache idea and we should open an issue for that i think

FIXED. Re-closing as i think this resolved for now.


WIP - Config doc update

First pass, opening this so folks can comment.  The header levels need some attention but that can be addressed after the actual content.

Random CI failure - I don't want to re-run CI for a README.

Became/superseded by PR #338


Clean up lobby config

Based on max/k8s branch
Site PR:
https://github.com/rivet-gg/site/pull/7
Fixes SVC-2958
Changes

Cleaned up game mode API actions config
Applied default publicity to /create based on lobby config
Added client and IP info to external request verification

@MasterPtato merge conflicts

@MasterPtato merge conflicts

@NathanFlurry fixed

@MasterPtato bolt check still failling

@NathanFlurry oops, fixed


Merge remote-tracking branch 'llvm/master' into upstream-with-swift

It looks like after https://github.com/apple/swift-lldb/commit/cde4416d690b lands in swift-lldb, we need to implement GetBreakpointExceptionPrecondition() also for SwiftLanguageRuntime, just as it was done upstream for ObjCLanguageRuntime in https://reviews.llvm.org/rG7f9c9f226423.

Yeah, we're going to definitely need to implement it for SwiftLanguageRuntime. Let's get this merged in and we can sort it out afterwards.


Pub/Sub PublisherClient.CreateAsync() does not take credentials from clientCreationSettings into account if serviceEndpoint is set

Environment details

OS: Windows 10
.NET version 5.0:
Package name and version: Google.Cloud.PubSub.V1; 2.7.0

Steps to reproduce
PublisherClient.PublishAsync() throws authentication exception because it does not take credentials passed in clientCreationSettings.Credentials into account if clientCreationSettings.ServiceEndpoint is set. It does not throw if I am not setting service endpoint.
Code example (throws exception):
var creds = GoogleCredential.FromJson(_jsonCredentials); // string contains normal service account credentials read from file
var clientCreationSettings = new PublisherClient.ClientCreationSettings(null, null, creds.ToChannelCredentials(), "us-east1-pubsub.googleapis.com:443");
var pubClient = await PublisherClient.CreateAsync(_currentTopic, clientCreationSettings, customSettings);
await pubClient.PublishAsync(orderKey, message); // THROWS EXCEPTION

If use pass null instead of "us-east1-pubsub.googleapis.com:443" then no exception is thrown

Sure. My inference is based on the exception thrown. I am not sure of course what exactly going on behind the scene.
Here please the exception itself with stack trace. Thank you for fast response.
Grpc.Core.RpcException: Status(StatusCode="Unauthenticated", Detail="Request had invalid authentication credentials. Expected OAuth 2 access token, login cookie or other valid authentication credential. See https://developers.google.com/identity/sign-in/web/devconsole-project.", DebugException="Grpc.Core.Internal.CoreErrorDetailException: {"created":"@1644782110.249000000","description":"Error received from peer ipv4:<IP_ADDRESS>:443","file":"..\..\..\src\core\lib\surface\call.cc","file_line":1067,"grpc_message":"Request had invalid authentication credentials. Expected OAuth 2 access token, login cookie or other valid authentication credential. See https://developers.google.com/identity/sign-in/web/devconsole-project.","grpc_status":16}")
   at Google.Api.Gax.Grpc.ApiCallRetryExtensions.<>c__DisplayClass0_0`2.<<WithRetry>b__0>d.MoveNext()
--- End of stack trace from previous location ---
   at Google.Cloud.PubSub.V1.Tasks.ForwardingAwaiter`1.GetResult()
   at Google.Cloud.PubSub.V1.Tasks.Extensions.<>c__DisplayClass5_0`1.<<ConfigureAwaitHideErrors>g__Inner|0>d.MoveNext()
--- End of stack trace from previous location ---
   at Google.Cloud.PubSub.V1.Tasks.ForwardingAwaiter`1.GetResult()
   at Google.Cloud.PubSub.V1.PublisherClientImpl.PublishAsync(PubsubMessage message)
   at ConsoleApp14.Program.Publish(String message, String times) in C:\Users\I540758\source\repos\ConsoleApp11\ConsoleApp11\Program.cs:line 127

Thanx a lot! I'll try it tomorrow and tell you if it works for me.

Yeah. The workaround works like charm. Thanx!

Great - closing now, thanks.


Creating inline validator

This allows you to create a validator inline that validates with a custom function.
This will help when you need to create a one off validation without having to create a custom validator.

This is already supported via validator(function(...))

Oh nice, not sure how I missed that.
Let me know if you want a pull request for the date test fix, or if you want to just add it in.

If you can create a quick pr for it, I can merge it. Why was it failing for milliseconds and not seconds?

And no worries 😸 Thanks for taking the time to put this together!


Large output from event scripts may cripple RabbitMQ or ems

Hi, we were stress testing OpenBaton and we found that when life-cycle event scripts produce large outputs (>2MB) it is possible that some issues will appear. I guess that large outputs may disrupt the RabbitMQ service and strange things start to happen.
To reproduce this issues one can use iperf example with bellow script added to INSTANTIATE event. It also helps to instantiate many NSDs at the same time (more than three for example).
#!/bin/sh
find /

Unable to start new NSR
After stress test users cannot launch additional NSRs because OpenBaton isn't able to find VNFM. Manager is still listed in web GUI, but when NSD is launched we get this error:
2016-07-22 14:15:20.817 ERROR 2080 --- [http-nio-8080-exec-3] o.o.n.a.e.GlobalExceptionHandler         : Exception was thrown -> Return message: VNFManager with endpoint: generic is not registered or not enable or not active.

org.openbaton.exceptions.NotFoundException: VNFManager with endpoint: generic is not registered or not enable or not active.

EMS is getting killed
In some cases the ems was killed because it lost the connection to RabbitMQ after the script was executed. After that NSR stayed in NULL state. Log from ems when it is killed (/var/log/openbaton/ems-receiver.log):
...
WARNING:pika.adapters.base_connection:Socket closed when connection was open
WARNING:pika.connection:Disconnected from RabbitMQ at <IP_ADDRESS>:5672 (501): FRAME_ERROR - type 3, first 16 octets = <<".... 61%  114M 3">>: {invalid_frame_end_marker, 46}
CRITICAL:pika.adapters.blocking_connection:Connection close detected; result=BlockingConnection__OnClosedArgs(connection=<pika.adapters.select_connection.SelectConnection object at 0xa731d0>, reason_code=501, reason_text='FRAME_ERROR - type 3, first 16 octets = <<".... 61%  114M 3">>: {invalid_frame_end_marker, 46}')

This is important, we could look into rabbit features for splitting the message


NativeModules.ReactNativePermissions is undefined

I tried this import Permissions from 'react-native-permissions'; and Permissions is undefined.
Also tried import {NativeModules} from 'react-native'; and NativeModules.ReactNativePermissions is undefined.
And yes I do have it linked in my xcode.

@ahmed1490 what happens if you try requiring it as a const: const Permissions = require('react-native-permissions');

Closing for inactivity. Let me know if you're still having this issue, and I'll re-open

@yonahforst Sorry missed it. I bootstrapped new project and it seemed to work

This problem still exists on my project (RN 0.35, Xcode8)
Have tried const Permissions = require('react-native-permissions'); but still fail.
Checked Xcode have libraries linked properly.
The module does not exist in NativeModules from "react-native"

I reposted my comment to:
[(https://github.com/yonahforst/react-native-permissions/issues/28)]


METRON-680: GeoLiteDatabase incorrectly using country geoname_id instead of city

Swaps out country's geoname_id for city's geoname_id.  Both ids are the same in format (they're the ids for the geonames.org dataset).
The only direct effect I know of from this is the Kibana dashboard uses this field for unique locations (so changing what feeds this changes the dashboard output).  The main wrinkle is that city can be unpopulated, even though a country exists (e.g. if an IP is just assigned to the U.S., it may not have a city).  This isn't always true that (at least one IP range for Japan appears to fill in Japan as the city's geoname id).
I'm opening the PR with just the direct change, but it's definitely open to discussion if we want to adjust.

Can you reopen with the right JIRA prefix: METRON-680 ?

@cestella My mistake, fixed.

I don't mind this change, but could we add another field for "countryLocId" so that, if so desired, people could reconfigure that instead?

@cestella We definitely could. METRON-679 has the details about all the other fields we could be passing, including the current country geoname id being passed.  If we want to start passing additional fields, I'd rather just do it one as part of that ticket.
For this, we could also just change the box to do a unique count of one of the other existing fields, and just ignore locId entirely.  To the best of my knowledge it only gets used in that one Kibana visualization.  Depending on how granular we want the box to be (at least by default), we could always make it a unique count on city or a unique count on location_point (or whatever the actual field for lat,long) is.

Ok, sounds good to me.  +1 by inspection


Dev

Hi Anil,
Can you please recreate this pull request by comparing the branch in your forked repo with our dev branch.
Before we can accept your changes we would need to ask you to sign a collaboration agreement. Can you please fill in the sections highlighted in yellow, sign it and send a scanned version to<EMAIL_ADDRESS>This agreement only needs to be signed once, so for all your future pull requests you're fine. Sorry for the extra hassle, but it is a new requirement from our legal department.

Hi Bert,
I am new to github and placed a pull request accidentally. Please discard
my changes.
Let me know if anything is required from my end.
Thanks,
Anil Kumar
On 30-Jan-2015 3:06 am, "Bert Jansen"<EMAIL_ADDRESS>wrote:

Hi Anil,
Can you please recreate this pull request by comparing the branch in your
forked repo with our dev branch.
Before we can accept your changes we would need to ask you to sign a collaboration
agreement
https://github.com/OfficeDev/PnP/blob/dev/Microsoft Corporation Collaboration Agreement-Officedev Patterns %26 Practices GetHub Project.docx.
Can you please fill in the sections highlighted in yellow, sign it and send
a scanned version to<EMAIL_ADDRESS>This agreement only
needs to be signed once, so for all your future pull requests you're fine.
Sorry for the extra hassle, but it is a new requirement from our legal
department.
—
Reply to this email directly or view it on GitHub
https://github.com/OfficeDev/PnP/pull/412#issuecomment-72108903.

Closing PR per request of creator


3.1.4 install on RoR incomplete

Installed formtastic 3.1.4 on RoR4 and am missing many components (no stylesheets, methods like :select evenlthough successful install. How to correct?

Did you follow the installation instructions here?
Especially this command:
$ rails generate formtastic:install

Before I can help you more I need to see a stack trace or an exception error message or something that can help me understand what might be happening.

Closing due to inactivity. If you can share steps to reproduce please reopen.


add component pane not fixing height

in filterable lists, the height should be calculated when it opens, so filtering the list doesn't make it jump

fixed in commit aa77e70


Extreme Server Lag after version #139

Version of Advanced Rocketry
This seems to only occur starting with versions 149, 150, and 151 (can't test versions 148-140)
Have you verified this is an issue in the latest unstable build
Yes
Version of LibVulpes
Version 59, however problem goes away when I'm just running LibVulpes and not AdvRocketry
Version of Minecraft
1.12.2 (forge-<IP_ADDRESS>38)
Crash report or log (if applicable)
I installed lag goggles and did a dump to my log, this was the result.
https://pastebin.com/kgxsCzVJ
Description of the problem
When using any available version after 139, massive amounts of RAM are used by the server causing some extreme server lag. This is especially present on worlds with a lot of blocks, ESPECIALLY worlds with a lot of water blocks. I first noticed this problem when trying to make a water world- if you try to make a world with a lot of water (from y=128+) this problem gets crazy and I average ~7-9 TPS on the server. The debug screen showed me using about 3 gigs of ram every second in a water world on version 149, and about 1/10 of that on version 139.
I also tried tweaking every one of the various settings in the config file to see if it helped, but none of them made a difference. To recreate this bug yourself, just make a new superflat world and choose 'water world' under presets, then edit the amount of water blocks so it's between 100 and 200.
Its weird cause version 139 works totally smooth, TPS is 20 in the exact same world I tested for version 149+. Hope I've provided enough information to help! Love this mod btw, one of my all time favs

Can you get me a visualVM dump?  Lag goggles isn't really showing anything useful.  See the last half of https://github.com/zmaster587/AdvancedRocketry/issues/1621#issuecomment-510112937 for how to do that.  VisualVM is far superior because it tells me exactly what is lagging in the code, not just a vague 'something in this 700 lines of code that could be called from anywhere is taking a while'.
What confuses me is that not really much changed between 139 and the most recent build.  The only thing I can think of would be the change for rain, but that would only make a difference when its raining.  Other than that, a hovercraft was added, volcanoes generate in certain biomes.  Unless you went and added those biomes they should never spawn.  Fixed a bug with the keybinds.  but that's about it.

Sure thing. I ran VisualVM twice, once on version 149 and once on version 139, both on the same world.
Heres 139 without the lag:
https://www.dropbox.com/s/ufhx21yn2grw34o/advanced_rocketry139.nps?dl=0
And heres 149 with the lag:
https://www.dropbox.com/s/32qbjnccgfvyu7n/advanced_rocketry149.nps?dl=0
Hope this helps

Yeah, same lags on 1.6.0 version

@xlea99 alright, it looks like entity spawning from AR is taking way longer in 149, can you upload your planetDefs.xml file?  Can you also check to see if there's any entries for spawning mobs, if there are can you remove them and see if the lag continues?

@zmaster587 I removed all spawnable tags from my planet defs, but nothing. This lag continues.

I actually didn't make a planetDefs.xml for the pack I made the nps files with, i just put libvulpes and advanced rocketry into vanilla minecraft and made an ocean superflat world. There were 120 or so entities in the world, I think all of them squids, but the number wasn't really fluctuating.
I don't know if this helps, but I tried using In Control! to disable all mobs from spawning in the game, but it didn't seem to help with the lag, even with entities at 0.
lmk if you need anything else to help

@xlea99 would you be able to send me a copy of the world?  I'm having difficulty replicating the issue.

Scratch that, I think I found the issue https://github.com/zmaster587/AdvancedRocketry/blob/1.12/src/main/java/zmaster587/advancedRocketry/event/PlanetEventHandler.java#L133

Yep, that was definitely it.  Sometimes it's hard to tell the difference between a super bogged down PC and a real lag issue.

Since it's a gamebreaking issue I'll have a build out to fix it in a few minutes now that I actually have it working.


added temp file check in done query call

Need to PR against devel. Also it's not a patch for me to just roll in, so you'll need to describe the change as there is quite a bit of legacy code in relating to tracking chunks in the FS.File.


Disappearing analyzer warnings

Just cleaned up an old project with thousands of formatting issues with this analyzer and saved lots of time (thanks!).  However, I have a program down to the last ~100 warnings with an output that looks like:

Position.xaml.cs(1290,9,1290,70): warning SA1201: A event should not follow a method
Position.xaml.cs(1417,30,1417,39): warning SA1201: A field should not follow a method
Position.xaml.cs(1573,36,1573,49): warning SA1201: A method should not follow a struct
Position.xaml.cs(1594,9,1594,66): warning SA1201: A event should not follow a method
Position.xaml.cs(55,5,55,8): warning SA1514: Element documentation header must be preceded by blank line
Position.xaml.cs(1417,30,1417,39): warning SA1203: Constant fields must appear before non-constant fields
Position.xaml.cs(1368,33,1368,43): warning SA1202: 'public' members must come before 'private' members
Record.xaml.cs(103,42,103,48): warning SA1201: A field should not follow a enum
Processor.xaml.cs(884,29,884,36): warning SA1204: Static members must appear before non-static members
Processor.xaml.cs(124,27,124,36): warning SA1201: A field should not follow a struct
Processor.xaml.cs(21,5,21,8): warning SA1514: Element documentation header must be preceded by blank line
Options.xaml.cs(105,21,105,30): warning SA1201: A field should not follow a property
Options.xaml.cs(127,33,127,39): warning SA1201: A field should not follow a property
...etc

Immediately after build, the Error List is populated with randomly somewhere between 20-60 warnings, but when I double click the first one to go to it, they all disappear.  This may not be StyleCop specific, but it's the only analyzer I'm using.
Thanks.

Hi, this sounds like problem in the dotnet/roslyn component itself.
As you are using Visual Studio 2015 Update 1, you may want to try and enable the SA0000 (its disabled by default), which is designed to work around an issue that will sometimes mess up the error window.
If that doesn't work for you, try upgrading to Visual Studio Update 2 to see if that resolves the issue for you. If not, please report the issue in the dotnet/roslyn project, as they are the only ones that can solve it.

Setting the SA0000 to anything except Default or None seems to have fixed my problem.  It's funny to watch the warnings repopulate slowly just as they disappeared.  Thanks!
Will look into updating to VS Update 2.


Edit Profile doesn't work when I use my own Tenant information.

Issue
Hello,
I'm having an issue where the 'Edit Profile' functionality just redirects back to my localhost:3000 app...
The Tasklist feature seems to work, but the Edit Profile feature does not.
I changed the tenant/client-id information to my own. Also to keep it simple on my permissions side, I just have 1 scope permission called 'Scope.All' which I also changed anywhere the ToDoList.Read/ToDoList.ReadWrite shows up.
I did this so I could apply it to all my API's then change it to get more detailed permissions later on.
Note: i also have a separate code-base where i left the ToDoList.Read/ToDoList.ReadWrite scopes in (which I also have in Azure), and still have the same issue.
If it is useful to debug the issue, the url it tries to create in the code to redirect to is in one of the sections below.
This issue is for the sample

    - [ ] 1-1) Sign-in with Azure AD
    - [ ] 1-2) Sign-in with Azure AD B2C
    - [ ] 2-1) Acquire a Token and call Microsoft Graph
    - [ ] 3-1) Protect and call a web API on Azure AD
    - [ x ] 3-2) Protect and call a web API on Azure AD B2C
    - [ ] 4-1) Deploy to Azure Storage and App Service
    - [ ] 4-2) Deploy to Azure Static App Service
    - [ ] 5-1) Call a web API using App Roles
    - [ ] 5-2) Call a web API using Security Groups
    - [ ] 6-1) Call Microsoft Graph using on-behalf-of flow
    - [ ] 6-3) Call a web API using Conditional Access Auth Context
    - [ ] 6-4) Sign-in with Hybrid SPA flow

This issue is for a

    - [ ] bug report -> please search issues before submitting
    - [ x ] question
    - [ ] feature request
    - [ ] documentation issue or request

Minimal steps to reproduce
When i debug via DevTools, AzureB2C creates this navigateUrl url via this code:
           // Create acquire token url.
            const navigateUrl = await authClient.getAuthCodeUrl({
                ...validRequest,
                nativeBroker: NativeMessageHandler.isNativeAvailable(this.config, this.logger, this.nativeMessageHandler, request.authenticationScheme)
            });

that I assume it tries to redirect to in order to edit my profile:
https://patientportalb2cdev.b2clogin.com/patientportalb2cdev.onmicrosoft.com/b2c_1_edit_profile/oauth2/v2.0/authorize?client_id=c1d2e539-4d27-45b9-b10d-163e44036e41&scope=openid profile offline_access&redirect_uri=http%3A%2F%2Flocalhost%3A3000%2F&client-request-id=b20aa729-48a2-4c97-a8e7-ea99fb0d1a6b&response_mode=fragment&response_type=code&x-client-SKU=msal.js.browser&x-client-VER=2.31.0&client_info=1&code_challenge=G2ZxwFmp-1Octau0LlIV9E-0Z_-LhIMAF1ZJwZyqrWY&code_challenge_method=S256&login_hint=acurian.testing%40gmail.com&X-AnchorMailbox=Oid%3Ae8a52a20-57ba-4188-855f-316c09a2af99-b2c_1_susi%4089fe1c88-6121-4253-931c-18b20a0e7807&nonce=00600125-d707-479b-bbe8-1190d74a77ca&state=eyJpZCI6IjFiNmYwZDBlLTUwZmMtNDljMy1hNjViLTNjYWE2OTYxMjNjZiIsIm1ldGEiOnsiaW50ZXJhY3Rpb25UeXBlIjoicmVkaXJlY3QifX0%3D
but it seems like the app immediately redirects back to localhost:3000.
and it also removes my email info from the top-right button:
.
If I manually goto the above url in my browser, it redirects along with this state information:
http://localhost:3000/#state=eyJpZCI6IjFiNmYwZDBlLTUwZmMtNDljMy1hNjViLTNjYWE2OTYxMjNjZiIsIm1ldGEiOnsiaW50ZXJhY3Rpb25UeXBlIjoicmVkaXJlY3QifX0%3D&client_info=eyJ1aWQiOiJlOGE1MmEyMC01N2JhLTQxODgtODU1Zi0zMTZjMDlhMmFmOTktYjJjXzFfZWRpdF9wcm9maWxlIiwidXRpZCI6Ijg5ZmUxYzg4LTYxMjEtNDI1My05MzFjLTE4YjIwYTBlNzgwNyJ9&code=eyJraWQiOiJjcGltY29yZV8wOTI1MjAxNSIsInZlciI6IjEuMCIsInppcCI6IkRlZmxhdGUiLCJzZXIiOiIxLjAifQ..IU7o_pErd-BfHQLK.2GS7gKlD5bV-qw_8wi8xwOAv_2fnSslI3FRO82j403Kce2ywo2R0Duu5GDsqnIIFlH2ZAduOpjRuQbYuW5wVId9EZHx_qAcJaC3TVvQYiv3V6oKCOeVyhNiCpRiZGXN9QIKb_bP56nvS5VVS-y-vYNWoUnn1mqw727eFXh-i_gE_a1QEm1huKYyxUA6n27joKt7vA_KlSdC7x1xoSiPJa2mwPfCnec3wk7RuQYhQy46cSlpBTB4i9CztVIVaGwBIJRP74xVszLcf8GezLaNNIfAPSrYP1FBgAavSHGevs6DX0scru1e5j6oKaSUuWksoWZ0dLCO3QPm2iHA2hf2sJx8xZE-kikSAoxBcuMjaPnJBsUpY_u_QMsW7_gB0UI9VegNsQvpch43FSNLyUQIGP_-258KhITuOXZSwIFUHvO9MrUNg0pFQ2df-EhFEwq54e2J0HabT8cVtpUs3rKbsO3R--hOnCrIZG8i8KB_TYz8P27wu72UyIR3ABMC6-UdTf6uSQ5m-yWlwDjAUcAe82cPT6jX8ireqgHC5lREmn2aSl1hPQ0rGdZxj20j9PVOBQE1z71Js7V4_HCmBK-Ux8Stc5ICuk7-1yEY5IpHVo7am8rP-fM1hq04rKghyXcv51h2bsM8SyqE2mHRl8gDA8xwFglpsoFTaH66R1i_gRA.BnmpVo_-mslZfUnAJZzEkw
Any log messages given by the failure
Nothing really stands out on the console.
Expected/desired behavior
Should show the edit profile page, similar to the original example.
Library version
"@azure/msal-browser": "~2.31.0",
"@azure/msal-react": "~1.4.10",
Browser and version
Chrome
Mention any other details that might be useful
Note: my user flows are called: B2C_1_susi and B2C_1_edit_profile and hence i changed them in the authConfig.js
My client ID of my SPA project is:
c1d2e539-4d27-45b9-b10d-163e44036e41
My client ID of my API project is:
d9552fa1-8ca5-4fdd-82c1-a54d8b956cdc
The Scope.All scope in the API project is:
https://patientportalb2cdev.onmicrosoft.com/d9552fa1-8ca5-4fdd-82c1-a54d8b956cdc/Scope.All
If want to just use the original read/write scopes to keep things simple (so don't have to modify the 3-Authorization-II\2-call-api-b2c code, minus the authConfig.js files), those are at:
https://patientportalb2cdev.onmicrosoft.com/d9552fa1-8ca5-4fdd-82c1-a54d8b956cdc/ToDoList.Read
https://patientportalb2cdev.onmicrosoft.com/d9552fa1-8ca5-4fdd-82c1-a54d8b956cdc/ToDoList.ReadWrite
The b2cPolicies.names are (which also get append onto the b2cPolicies.authorities urls like:
authority: 'https://patientportalb2cdev.b2clogin.com/patientportalb2cdev.onmicrosoft.com/B2C_1_susi'):
signUpSignIn: 'B2C_1_susi',
forgotPassword: 'B2C_1_passwordreset',
editProfile: 'B2C_1_edit_profile',
Note: I may delete some of these above details later after getting help here.

@armyofthe12monkeys apologies for the late response, this one seem to fell through cracks. Your issue is most likely a problem with how you set up the edit profile user flow. As a first step, are you able to launch and test the edit profile user-flow via Azure portal? (see https://learn.microsoft.com/en-us/azure/active-directory-b2c/tutorial-create-user-flows?pivots=b2c-user-flow#test-the-user-flow-1).
Regarding the issue where your email is removed on the navbar ("unkown"), can you confirm you have followed the steps in the warning here: https://github.com/Azure-Samples/ms-identity-javascript-react-tutorial/blob/main/3-Authorization-II/2-call-api-b2c/README.md#create-user-flows-and-custom-policies
Do you have (or can you put together) a repo to reproduce the issue with? That would help me debug it.

Hey @derisen !

As a first step, are you able to launch and test the edit profile user-flow via Azure portal?

I did test my b2c_1_edit_profile via 'Run user flow', and got a valid JSON response back after signing in on the jwt.ms page.

Can you confirm you have followed the steps in the warning here? https://github.com/Azure-Samples/ms-identity-javascript-react-tutorial/blob/main/3-Authorization-II/2-call-api-b2c/README.md#create-user-flows-and-custom-policies

Yes I think so.
Note: the instructions there i don't think mention which User Flow to select once you go into 'User Flows', in this part:
"Then, navigate to the User flows blade. Select the User Attributes tab and make sure Email Address is checked. Then select the Application Claims tab and make sure Email Addresses is checked."
But I checked the susi (which has Email Address in the User Attribute section and Email Addresses in the Application Claims section)
and signin (has just the Application Claims section and saw Email Addresses in there).

Also, do you have (or can you put together) a repo to reproduce the issue with? That would help me debug it.

Yes, I just added you to my private repository on here.
Let me know if anything sticks out.
Thanks again for helping out,
Arian

Hey,
So by default the edit_profile flow doesn't have Email at all in User Attributes section of that flow:

and the Application Claims section of edit_profile had Email Addresses unchecked (maybe by default).
I'm going to check that one now and retest and report back:

Hey @derisen ,
i think the issue where the email address disappears from top-right area is good after above.
But the main issue still occurs where it doesn't open up the Edit Profile popup.
Not sure if its related to the allowed Redirect URIs, but i added a few urls in there like these localhost urls (and the jwt.js site as well for 'Run User Flow' testing).
Note: this is redirect settings for the FrontEnd SPA app in Azure, not the BackEnd API app:

Think thats correct as its mentioned in the docs:

Testing via Run User Flow gives me this result in the jwt.ws:

Anyway, let me know what else to try.
Let me know if you can replicate with a user you signed up yourself... My account is created using the regular Email/Password type of Signup.
If you cannot replicate, then i can give my user/pass maybe privately to you via email.
Thanks!,
Arian

Great! Glad that resolves the "unknown" username issue. I'll try to sign-up with my own account and give it a try.

@armyofda12mnkeys I'm able to reproduce the issue, but couldn't identified the root cause yet. Can you help me with a couple of things:

When you were testing b2c_1_edit_profile via the 'Run user flow' on Azure portal, can you tell me what is the URL/endpoint it navigates you to? Can you share that with me?

Can you confirm that in your app registration, none of the implicit flow boxes are checked (this is on the "Authentication" page). Feel free to share your app manifest as well.

When you were testing b2c_1_edit_profile via the 'Run user flow' on Azure portal, can you tell me what is the URL/endpoint it navigates you to? Can you share that with me?

So the signin popup it goes to is:
https://patientportalb2cdev.b2clogin.com/patientportalb2cdev.onmicrosoft.com/oauth2/v2.0/authorize?p=B2C_1_edit_profile&client_id=c1d2e539-4d27-45b9-b10d-163e44036e41&nonce=defaultNonce&redirect_uri=https%3A%2F%2Fjwt.ms&scope=openid&response_type=id_token&prompt=login
and after signin, it redirects to here (since i choose https://jwt.ms in the Run User Flow's Reply URL dropdown)
https://jwt.ms/#id_token=eyJhbGciOiJSUzI1NiIsImtpZCI6Ilg1ZVhrNHh5b2pORnVtMWtsMll0djhkbE5QNC1jNTdkTzZRR1RWQndhTmsiLCJ0eXAiOiJKV1QifQ.eyJ2ZXIiOiIxLjAiLCJpc3MiOiJodHRwczovL3BhdGllbnRwb3J0YWxiMmNkZXYuYjJjbG9naW4uY29tLzg5ZmUxYzg4LTYxMjEtNDI1My05MzFjLTE4YjIwYTBlNzgwNy92Mi4wLyIsInN1YiI6ImU4YTUyYTIwLTU3YmEtNDE4OC04NTVmLTMxNmMwOWEyYWY5OSIsImF1ZCI6ImMxZDJlNTM5LTRkMjctNDViOS1iMTBkLTE2M2U0NDAzNmU0MSIsImV4cCI6MTY4NzMzMTU0OSwibm9uY2UiOiJkZWZhdWx0Tm9uY2UiLCJpYXQiOjE2ODczMjc5NDksImF1dGhfdGltZSI6MTY4NzMyNzk0OSwiZW1haWxzIjpbImFjdXJpYW4udGVzdGluZ0BnbWFpbC5jb20iXSwidGZwIjoiQjJDXzFfZWRpdF9wcm9maWxlIiwibmJmIjoxNjg3MzI3OTQ5fQ.lKJ5FH57ugZGkax5dbHjAX4chKTkA2BvgKgUxlt5yaEYcMP8FBkX3-AV2pqitcTiKY5hhzEdw9wLl8ZMwHYnq_K6T7hQGlnCrVCFzX0VENmwKzSiA14JT2OBlaQ21NfJqIjuIU1q62t5uv1uJgaTL56UsjN6M-inNfwJAosGnNLHvjMYo6mpISKkafKfvAag0fT0blhhDRXfFj_nx-jY5qJN9MJZLTbq60hoB7S80FAXUO1tpojqL16muNfoVzefyJ27TaR0GE1-DiN2pUEzrMQh72h6h4F4V34tcJqAGMInOBEbat6t7jo1VlVl4aDOiCfmP3Q6Un13FdcjIeHD9A

Can you confirm that in your app registration, none of the implicit flow boxes are checked (this is on the "Authentication" page). Feel free to share your app manifest as well.

Hmmm the 2 checkboxes are checked:

I don't remember checking them but looks like I prob did since that is not the default setting,
Hmmm let me unset for now.
Just tested though, and didn't seem to make a difference.
Btw which file is the App Manifest? something not in the git repo i assume, within the Azure portal?

Found it, Here is the app manifest:
app-manifest-from-azure-portal.txt

@armyofda12mnkeys I'm unable to crack this :/ There seems nothing wrong with the request to B2C, and no visible errors either.
The expectation is:

app navigates the user's browser to https://patientportalb2cdev.b2clogin.com/patientportalb2cdev.onmicrosoft.com/b2c_1_edit_profile/oauth2/v2.0/authorize endpoint.
A UI will prompt the user
user interacts with the UI (next or cancel)
B2C will redirect back to your redirect uri with authZ code

Here, step 2 is just not happening...
Let's try a few more things:

Uncheck the "Allow public client flows" on the Authentication page on app registration portal
Make sure both localhost:3000 and localhost:3000/redirect are registered as SPA redirect URIs
Make sure you are using the latest version of B2C user-flows: https://learn.microsoft.com/en-us/azure/active-directory-b2c/user-flow-versions

If the issue persists after, you might want to open a support ticket with B2C to take a look at your user-flow

so if i uncheck the "Allow public client flows" my real application stops working and gives an error trying to signup:
ServerError: unauthorized_client: AADB2C90058: The provided application is not configured to allow public clients.
Correlation ID: f6f66358-8b63-4a98-97a7-98fb4c51eac6
Timestamp: 2023-06-22 00:37:18Z
When i say my 'real application', i mean not this more simpler test github app i shared thats an exact copy of the repo, minus the authConfig.js, but the actual SPA app we have deployed to real environments. So I had to re-enable it other my QA Team will complain the login isn't working tomorrow in our NonProd envs.
So i switched it back to Enabled. I assume this setting is actually needed?
Yes, both those urls are in my SPA Redirect URls.


Add batchsize utils

Some utilities for having batch size as a hyperparameter as well as (trying) to make sure to select batch sizes which won't make training or validation go oom.
Breaking due to increased Julia compat bound. Previous version was anyways most likely not compatible with Julia 1.0.0.

Don't forget to remove Cbc depencency before merging.


Appstudio update mvp-test-component

Pipelines as Code configuration proposal

Pipelines as Code CI/mvp-test-component-on-pull-request has successfully validated your commit.

StatusDurationName

✅ Succeeded
6 seconds
init

✅ Succeeded
19 seconds
clone-repository

✅ Succeeded
1 minute
build-container

✅ Succeeded
11 seconds
inspect-image

✅ Succeeded
8 seconds
deprecated-base-image-check

✅ Succeeded
17 seconds
clair-scan

✅ Succeeded
1 minute
clamav-scan

✅ Succeeded
11 seconds
sbom-json-check

✅ Succeeded
15 seconds
optional-label-check

✅ Succeeded
15 seconds
label-check

✅ Succeeded
6 seconds
show-summary

Pipelines as Code CI/mvp-test-component-on-pull-request has successfully validated your commit.

StatusDurationName

✅ Succeeded
6 seconds
init

✅ Succeeded
19 seconds
clone-repository

✅ Succeeded
1 minute
build-container

✅ Succeeded
11 seconds
inspect-image

✅ Succeeded
8 seconds
deprecated-base-image-check

✅ Succeeded
1 minute
clamav-scan

✅ Succeeded
17 seconds
clair-scan

✅ Succeeded
11 seconds
sbom-json-check

✅ Succeeded
15 seconds
label-check

✅ Succeeded
15 seconds
optional-label-check

✅ Succeeded
6 seconds
show-summary


Deletion of namespace through UI is unsuccessful with Kubernetes 1.3

Rancher Version:: v1.2.0-pre1-rc1
Docker Version:: 1.10.3
OS and where are the hosts located? (cloud, bare metal, etc):: Ubuntu, Cloud
Environment Type: (Cattle/Kubernetes/Swarm/Mesos): Kubernetes
Steps to Reproduce:

Create a Kubernetes environment using https://github.com/rancher/qa-catalog/
Create a namespace "test1" through UI or through kubectl
Delete a namespace using the UI

Results:
Namespace cannot be deleted through UI. Error message below

Note: Namespace deletion through kubectl works fine.

Error in dev tools for this:
http://<IP_ADDRESS>:8080/r/projects/1a8/kubectld:8091/v1-kubectl/delete?defaultNamespace=default&arg=[object Object]&arg=undefined 500 (Internal Server Error)

Checked other areas and delete is not working anywhere in Kubernetes environment.  Tried replication sets, deployments, pods, etc....

Delete is still not functioning

Version - v1.2.0-pre1-rc4
Checked 1.2 and 1.3 k8s delete functional
Verified fixed


More small spelling corrections

Based on the V4.0.5 branch.

@ividyon merged into :
https://github.com/FRACerqueira/PromptPlus/tree/V4.0.5


Resolve images via webpack

This patch sets up the webpack loader to convert image URLs into require() calls so that webpack can manage images referenced by markdown files.
There was a fair bit of refactoring as part of this, which might help your schema branch.  In particular, now that the loader needs to play with intermediate representations, I think you get to avoid the error disambiguation at https://github.com/andreypopp/reactdown/pull/16/files#diff-821a16d38cf4ff69edc6b5b48313aa0bR49

(rebased off of master)

Sorry for not accepting this PR. I think it's better not to make additional pass over AST and rather plug into Renderer pipeline.
I understand that code is somewhat complex now. I'll reduce complexity over time as code base evolve. Most of it is currently because I'm planning another renderer which renders directly into components rather than code.

👍 makes sense to me


Problem with Bounded Type Parameters and existentials

It's almost like the bound isn't applied when you do: type Obj1<P: Object> = P and use it as Obj1<*>. The workaround I've discovered is to intersect the output with the bound i.e. type Obj2<P: Object> = P & Object
A couple interesting cases:
// @flow
// This passes just fine. Should error
type Obj1<P: Object> = P
const obj1: Obj<*> = 'string'

// By making an intersection you get the correct error
type Obj2<P: Object> = P & Object
const obj2: Obj2<*> = 'string'

const Fn = (p: {foo: number}) => (3)

// This is also interesting
// useful for react function components (getting the props out of a function)

// This wrongly passes
type _TypeOfFirstArgV1<P: Object, C: (p: P) => any> = P
const argv1: _TypeOfFirstArgV1<*, typeof Fn> = 'string'

// this is a workaround
// You get the correct error
type _TypeOfFirstArgV2<P: Object, C: (p: P) => any> = P & Object
const argv2: _TypeOfFirstArgV2<*, typeof Fn> = {}

Thanks, lmk if there's anything I could do to help out!

Yeah, this is a bug... Using flow-inspect, you can see that it should know P is bound to ObjT (object type).
// @flow

type Obj1<P: {}> = P
const obj1: Obj1<*> = 'string'

declare var needsString: boolean => void

needsString(obj1) // NO ERROR

TypeAppT (type application of polymorphic type: type `Obj1`) @ 0,1 - 0,0
  typeArgs: [
    EmptyT (empty) @ 0,1 - 0,0
  ]
  type: PolyT (polymorphic type: type `Obj1`) @ 0,1 - 0,0
    typeParams: [
      P (P) @ 3,11 - 3,15
        bound: ObjT (object type) @ 3,14 - 3,15
          type: {
            flags: {
              frozen: false
              sealed: true
              exact: false
            }
            propTypes: []
            prototype: ObjProtoT (object type) @ 0,1 - 0,0
          }
        polarity: Neutral
    ]
    type: TypeT (type `Obj1`) @ 0,1 - 0,0
      result: BoundT (P) @ 3,20 - 3,20
        typeParam: P (P) @ 3,20 - 3,20
          bound: ObjT (object type) @ 3,14 - 3,15
            type: {
              flags: {
                frozen: false
                sealed: true
                exact: false
              }
              propTypes: []
              prototype: ObjProtoT (object type) @ 0,1 - 0,0
            }
          polarity: Neutral
StrT (string) @ 0,1 - 0,0

Existentials support was gone a long time ago.


[Costs] Idea: create test for checking running EC2 instances

This is just an idea. Maybe we should have a test, that checks all currently running EC2 instances and compares them with list of instances that are expected to run. This would help us to capture earlier if there is some running EC2 instance that should not be running.

This is unfeasible with auto-scaling at our current codebase, it is too complicated for now. It is captured implicitly by the cost test.


Remove padding/space above the header

I took care to only apply this fix to the header and not other instances of this class.

I know this may seem dumb and weird but I like that spacing to maintain consistency when navigating between the main page and the docs pages! Sorry about this!

No worries. Thanks for the explanation.
Really cool project. Keep up the good work!


feat: add matchers to entry datasource

Adds a filtering functionality if multiple entries have the same path (including title) in the database.

Sorry, kind of forgot about this PR. Looks good to me

contained in Release v1.0.0


Retrieve subtitles from youtube instead of amara

Summary
Since Khan Academy is no longer using amara for subtitling we will download the subtitles form YouTube and used youtube-dl to download the subtitles.
TODO

[x] Rebuild all the language packs for testing
[ ] Test by @radinamatic

Issues addressed
#66

@mrpau-eduard Ping me when the contentpacks are ready!

Hi @radinamatic, you can grab the language packs here
https://drive.google.com/open?id=0B-E59G3J_sXmazlqUHljaDVTcTQ

HI @benjaoming I will revise the code base on your comments thanks for reviewing :)

@mrpau-eduard I installed the latest contentpacks, and downloaded several random videos in English, and they all correctly present the subtitles, so since I cannot actually test all 8k+, I'm giving this PR a pass! :wink:
If we discover that some are missing, we'll take it on case-by-case basis.
On another hand (I'll separate this in a new issue if necessary), I'm still seeing (a totally useless) English subtitles on dubbed Spanish videos... :thinking:

@radinamatic I think you are probably using the 0.17.1 release. We disabled it in 0.17.2

Ok, I will re-test with the latest 0.17.2 installer, and report back! :+1:

Hi @benjaoming can you review it again? I update my PR base on your comments.

Looks great! Ready to merge and start building content packs, no?

Re-tested with 0.17.2-rc2 installer, good to merge, but we need to fix #71 before building contentpacks again (partners in south America are expecting this).

@radinamatic Yes, we should address the #71 issue. We will take a look on it.

Hi @benjaoming I made an update on my script. We can merge it now.
I build a new sw to test the updates and it is working.

@cpauya responded to your comment - IMO this PR looks good to go :tada:


Error messages when repository doesn't exist.

At the moment, nothing happens when you enter a repo that doesn't exist. We should have a toast notification that says something along the lines of: "This repository could not be found."

The solution may be to use yar to save error message before redirect to home page. And modify layout to display error if there is.

@ducthienbui97
If we're using jQuery in #20 then we could call the GitHub Page and see if we get GitHub's 404 page and show a tooltip on the home page.

@darshkpatel  querying github in the front end to check if the repo exist or not is a good choice, however jQuery may be too big if you just need to use for api call. I would recommend using axios as I use it all the time.


Document Logging low-level API (GAPIC code)

Types such as v2/logging_service_v2_api.rb are not currently published to the gh-pages documentation.
See GoogleCloudPlatform/gcloud-common#207 for detailed design and mockups.

[ ] Remove exclusions from .yardopts
[ ] Add navigation to GAPIC/gRPC code

Please also make sure the GAPIC/GRPC doc will surface on rubydoc.info website as well. I think once gapic code is included in the .yardopts, they should surface there, right? @quartzmo

@swcloud If you have been wondering why GAPIC/gRPC code is visible in some of the google-cloud gems on rubydoc.info and not in others, it is because the .yardopts file has only been included in the gemspec since around 10/28/16. This is after the latest Datastore release, for example. Now that all gems include .yardopts, and the GAPIC/gRPC code is currently excluded in .yardopts, these excludes will need to be removed before the next release of any gem that needs to expose this code. Thanks for bringing this to our attention!

Here is the list of JSON doc files that will be in the gh-pages site once the exclusions are removed from .yardopts:
jsondoc/google.json
jsondoc/google/cloud.json
jsondoc/google/cloud/logging.json
jsondoc/google/cloud/logging/sink.json
jsondoc/google/cloud/logging/sink/list.json
jsondoc/google/cloud/logging/railtie.json
jsondoc/google/cloud/logging/entry.json
jsondoc/google/cloud/logging/entry/list.json
jsondoc/google/cloud/logging/entry/operation.json
jsondoc/google/cloud/logging/entry/httprequest.json
jsondoc/google/cloud/logging/logger.json
jsondoc/google/cloud/logging/metric.json
jsondoc/google/cloud/logging/metric/list.json
jsondoc/google/cloud/logging/project.json
jsondoc/google/cloud/logging/resource.json
jsondoc/google/cloud/logging/middleware.json
jsondoc/google/cloud/logging/asyncwriter.json
jsondoc/google/cloud/logging/resourcedescriptor.json
jsondoc/google/cloud/logging/resourcedescriptor/labeldescriptor.json
jsondoc/google/cloud/logging/resourcedescriptor/list.json
jsondoc/google/logging.json
jsondoc/google/logging/v2.json
jsondoc/google/logging/v2/loggingservicev2.json
jsondoc/google/logging/v2/loggingservicev2/service.json
jsondoc/google/logging/v2/configservicev2.json
jsondoc/google/logging/v2/configservicev2/service.json
jsondoc/google/logging/v2/metricsservicev2.json
jsondoc/google/logging/v2/metricsservicev2/service.json
jsondoc/google/protobuf.json
jsondoc/google/protobuf/any.json
jsondoc/google/protobuf/duration.json
jsondoc/google/protobuf/timestamp.json
jsondoc/google/cloud/logging/v2.json
jsondoc/google/cloud/logging/v2/configservicev2client.json
jsondoc/google/cloud/logging/v2/metricsservicev2client.json
jsondoc/google/cloud/logging/v2/loggingservicev2client.json
jsondoc/google/api.json
jsondoc/google/api/monitoredresourcedescriptor.json
jsondoc/google/api/monitoredresource.json
jsondoc/google/logging/type.json
jsondoc/google/logging/type/httprequest.json
jsondoc/google/logging/v2/logsink/versionformat.json
jsondoc/google/logging/v2/logmetric/apiversion.json
jsondoc/types.json

@swcloud Does this look correct?

I'm not familiar with jsondoc tool. Can you provide some instructions?
From what I can see, most .rb files under 'lib/google' have a corresponding json file, but I don't seem to find json files for these files:
google-cloud-logging/lib/google/cloud/logging/v2/doc/google/logging/v2/log_entry.rb
google-cloud-logging/lib/google/cloud/logging/v2/doc/google/logging/v2/logging.rb
google-cloud-logging/lib/google/cloud/logging/v2/doc/google/logging/v2/logging_config.rb
google-cloud-logging/lib/google/cloud/logging/v2/doc/google/logging/v2/logging_metrics.rb

The inputs to the jsondoc tool are YARD objects. From the YARD Readme:

Raw Data Output: YARD also outputs documented objects as raw data (the dumped Namespace) which can be reloaded to do generation at a later date, or even auditing on code. This means that any developer can use the raw data to perform output generation for any custom format, such as YAML, for instance.

While the jsondoc outputs should be mostly 1-to-1 with the inputs, the disconnect you are seeing is that the YARD objects are not 1-to-1 with the code files. These are top-level code objects: classes and modules, I believe.


Tensorflow installation

I am installing tensorflow on window machine with the help of Python (version python-3.5.4-amd64).
Command use to install tensorflow  :- pip3 install --upgrade tensorflow
Bellow error getting in Import tensorflow command.
Traceback (most recent call last):
File "C:\Program Files\Python35\lib\site-packages\tensorflow\python\pywrap_tensorflow_internal.py", line 18, in swig_import_helper
return importlib.import_module(mname)
File "C:\Program Files\Python35\lib\importlib_init_.py", line 126, in import_module
return _bootstrap._gcd_import(name[level:], package, level)
File "", line 985, in _gcd_import
File "", line 968, in _find_and_load
File "", line 957, in _find_and_load_unlocked
File "", line 666, in _load_unlocked
File "", line 577, in module_from_spec
File "", line 938, in create_module
File "", line 222, in _call_with_frames_removed
ImportError: DLL load failed: The specified module could not be found.
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "C:\Program Files\Python35\lib\site-packages\tensorflow\python\pywrap_tensorflow.py", line 41, in
from tensorflow.python.pywrap_tensorflow_internal import *
File "C:\Program Files\Python35\lib\site-packages\tensorflow\python\pywrap_tensorflow_internal.py", line 21, in
_pywrap_tensorflow_internal = swig_import_helper()
File "C:\Program Files\Python35\lib\site-packages\tensorflow\python\pywrap_tensorflow_internal.py", line 20, in swig_import_helper
return importlib.import_module('pywrap_tensorflow_internal')
File "C:\Program Files\Python35\lib\importlib_init.py", line 126, in import_module
return _bootstrap._gcd_import(name[level:], package, level)
ImportError: No module named '_pywrap_tensorflow_internal'
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "D:\eclipse\WorkspavePython\study\test.py", line 1, in
import tensorflow as tf
File "C:\Program Files\Python35\lib\site-packages\tensorflow_init_.py", line 24, in
from tensorflow.python import *
File "C:\Program Files\Python35\lib\site-packages\tensorflow\python_init_.py", line 49, in
from tensorflow.python import pywrap_tensorflow
File "C:\Program Files\Python35\lib\site-packages\tensorflow\python\pywrap_tensorflow.py", line 52, in
raise ImportError(msg)
ImportError: Traceback (most recent call last):
File "C:\Program Files\Python35\lib\site-packages\tensorflow\python\pywrap_tensorflow_internal.py", line 18, in swig_import_helper
return importlib.import_module(mname)
File "C:\Program Files\Python35\lib\importlib_init_.py", line 126, in import_module
return _bootstrap._gcd_import(name[level:], package, level)
File "", line 985, in _gcd_import
File "", line 968, in _find_and_load
File "", line 957, in _find_and_load_unlocked
File "", line 666, in _load_unlocked
File "", line 577, in module_from_spec
File "", line 938, in create_module
File "", line 222, in _call_with_frames_removed
ImportError: DLL load failed: The specified module could not be found.
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "C:\Program Files\Python35\lib\site-packages\tensorflow\python\pywrap_tensorflow.py", line 41, in
from tensorflow.python.pywrap_tensorflow_internal import *
File "C:\Program Files\Python35\lib\site-packages\tensorflow\python\pywrap_tensorflow_internal.py", line 21, in
_pywrap_tensorflow_internal = swig_import_helper()
File "C:\Program Files\Python35\lib\site-packages\tensorflow\python\pywrap_tensorflow_internal.py", line 20, in swig_import_helper
return importlib.import_module('pywrap_tensorflow_internal')
File "C:\Program Files\Python35\lib\importlib_init.py", line 126, in import_module
return _bootstrap._gcd_import(name[level:], package, level)
ImportError: No module named '_pywrap_tensorflow_internal'
Failed to load the native TensorFlow runtime.
See https://www.tensorflow.org/install/install_sources#common_installation_problems
for some common reasons and solutions.  Include the entire stack trace
above this error message when asking for help.

You have browse to the directory containing the tensorflow source code and install it using pip.
Alternatively you can do it using Anaconda, refer the documentation for more details.

This is a duplicate of #13196. Please see that issue for more information.


0.5.1? Is New Tag for Session Token coming?

Hi- I see the session_token code on master and i've confirmed that it works - and that i'm unable to use the client without this token.
Is a updated tag available for this?

I tried to publish a new package to hex today but I got some weird errors from the process and I don't really know how to fix them. Hey @tsantero can you give me a hand here?

I was able to publish a new v0.6.0 version to hex.pm.


Extending the db.transaction removal fix to the FhirEngine.search

          > From discussion with @yigit, this particular read api should be executed independently of any transaction.

Reason (in Yigt's words): The transaction you add there doesn't really help with anything because you are only doing a read inside that transaction and it is a single read. SQLite will already do a "read transaction" for it implicitly, which will make that consistent.
Would you like to work on this @LZRS ?

Would it also affect reads using FhirEngine#search , that joins to other tables?
Originally posted by @LZRS in https://github.com/google/android-fhir/issues/2552#issuecomment-2141946794

@LZRS The search api may have to do up to three different database calls to full fill a single search based on the search query.
Because of this, we have to consider one of the three cases.

Don't remove transaction
Remove for single search and keep if include/revInclude is there, so that the all the db queries for a single search happen in database transaction and the results are always correct.
Remove for all and be OK with the consequences of maybe divergent results.


Add viewport value blocks

To integer blocks for the viewport width and height. And one Vecto2 block for the viewport center.

Can be used like this:

Definitely good to have some sort of blocks like these!
One issue I can think of is that the viewport width, height, and center are all in viewport pixel coordinates, not in our 2D scene coordinates. So when we get the viewport center, it is not the same as the 2D scene center that our camera is fixed on. We might want to add some extra conversion there.

Yes, this seems to be the convertion we need: https://forum.godotengine.org/t/how-do-i-get-the-center-of-the-screen-without-using-camera/20545/3?u=manuq
In the current architecture we can't do that easily. I managed to do it with lambda functions. The code looks bad but it works in Pong to reset the ball. See the fixup commit.
I also appended another commit to construct a Vector2 from X, Y float parameters. So these 2 are equivalent:


implement Paths and make Profile a Clone

I'm not sure what's up with the lints.. it seems like you're running clippy from 1.65.. Perhaps we can rebase this once the 1.65 branch is merged.

I'm not sure what's up with the lints.. it seems like you're running clippy from 1.65.. Perhaps we can rebase this once the 1.65 branch is merged.

Yup, and as I was browsing other PRs, I realized you'd addressed these lint issues in https://github.com/radicle-dev/heartwood/pull/81.
Anyway rebased it and omitted the lints commit.


on-premise data gateway installation documentation outdated?

your installation documents for on-premise gateway is outdated it says you can change region during installation but no it's not having this option using the latest installer you might want to check this out

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: dc58ee8d-9650-6a07-8740-e10bf9dc12af
Version Independent ID: ca47ad42-0033-3b26-f7ac-6fb32c3ff8d6
Content: Learn how to install On-premises data gateway for Azure Analysis Services
Content Source: articles/analysis-services/analysis-services-gateway-install.md
Service: analysis-services
GitHub Login: @Minewiskan
Microsoft Alias: owend

@techonelab
Thanks for your feedback! We will investigate and update as appropriate.

@Minewiskan
Could you please review add comments on this, update as appropriate.

@techonelab
Thank you for bringing this to our attention.
I've delegated this to content author @Minewiskan, who will review it and offer their insightful opinions.

The article is correct. Current installer on November 23, 2023 includes the ability to change region.

#please-close


Output file paths configurable in mrack config

Adding a possibility to change Ansible inventory and pytest multihost
configuration output file paths in a mrack config file. So that user
can use directly a custom location.
Example of such config:
[mrack]
mrackdb = config/mrackdb.json
provisioning-config = config/provisioning-config.yaml
metadata = config/metadata.yaml
ansible-inventory = config/test.inventory.yaml
pytest-multihost = config/pytest-multihost-config.yaml

Signed-off-by: Petr Vobornik<EMAIL_ADDRESS>

This needs rebase please, and aware of conflicts.


Allow conditionally enabling the module

Describe the feature
Currently, there doesn't seem to be a way to conditionally enable the module. This is what I would ideally imagine:
gtag: {
  id: import.meta.env.GOOGLE_ANALYTICS_ID,
  enabled: !!import.meta.env.GOOGLE_ANALYTICS_ID
}

Sadly, enabled is used for a different purpose, which is confusing. Could we consider renaming current enabled option to a more descriptive one, please (e.g. initializationMode: 'auto' | 'manual')? (Yes, this would be a breaking change but worth it in my opinion.)
Additional information

[ ] Would you be willing to help implement this feature?
[ ] Can you think of other implementations of this feature?

Final checks

[X] Check existing issues.

Great idea! I've seen enabled being used in other modules. Is this some kind of hidden convention?

From my perspective, it depends on the module. This one sounds like a good one to have the enabled option, as some users might want to enable it conditionally (e.g. based on the presence of the environment variable for the GTAG ID, or their preference on the environment in which the app runs, i.e. dev/stage/prod).
It would be as easy as adding the following snippet at the start of the module setup function:
if (!options.enabled) {
  return
}

What I generally dislike about this approach for a enabled option is that it breaks auto-imports... I mean, if the user want's to disable the model altogether, he might as well remove it from his Nuxt config? Tricky one. 😄
But yeah, if other modules provide this option that it might be best to add support for enabled to keep the ecosystem aligned.

I know what you mean now. Yes, the code using whatever this module exports will break when enabled: false. Other alternative would be:
export default defineNuxtConfig({
  modules: [
    'other-module',
    ...(import.meta.env.GOOGLE_ANALYTICS_ID ? ['nuxt-gtag'] : [])
  ]
})

... but, this would mean we would have to add the config with the same condition:
export default defineNuxtConfig({
  otherConfig: {},
  ...(import.meta.env.GOOGLE_ANALYTICS_ID ? {
    gtag: {
      id: import.meta.env.GOOGLE_ANALYTICS_ID
    }
  } : {})
})

What do you think?

After much consideration and a lot of feedback from the community, I've changed the module API to properly support conditionally disabling the module. Fixed in: https://github.com/johannschopplich/nuxt-gtag/commit/f9080102e9e13b9b66342da0a3ea646b5b44c5f3
In v2.x and earlier, the enabled option was used to control manual initialization of the Google tag script. This option has been replaced with initMode in v3.x. To migrate your configuration, set the initMode option to manual:
export default defineNuxtConfig({
  modules: ['nuxt-gtag'],

  gtag: {
-    enabled: false,
+    initMode: 'manual',
    id: 'GX-XXXXXXXXXX'
  }
})

The enabled option is still available in v3.x, but is now used to disable the Google tag module for the current environment. This is useful if you want to disable the module in development or staging environments:
export default defineNuxtConfig({
  modules: ['nuxt-gtag'],

  gtag: {
    enabled: process.env.NODE_ENV === 'production',
    id: 'G-XXXXXXXXXX'
  }
})


bigtable: emulator does not validate DeleteFromColumn time range.

It is possible to create an invalid (or empty) time range when using google.bigtable.v2.DeleteFromColumn.  The production server rejects such requests, but the emulator accepts them.  Ideally both should have the same behavior.

@jba I think this was closed

@alok-ch Are you saying it was fixed? What is the commit?

@jba https://github.com/GoogleCloudPlatform/google-cloud-go/commit/2bc5ce7068b721f658f2752a5056e542be229cf4

That CL checks that each timestamp is valid, but does not check that the range is valid. According to this issue, the emulator should return an error if start time >= end time. Please test against the real service to confirm and to determine the error code to return.

Just saw that f05ab16 fixed this.


diskspd doesn't have check for 4K-volumes

For your information
diskspd -b512 doesn't check if the tested storage is 4096 PhysicalSectorSize and crashes on trying. Annoying if you create benchmark-scripts that have to differentiate between those as it's not easy doing that from a cmd- or PS-script... Would be nice if it would simply say it can't do what you told it to or something. Output of trying -b512 on a native 4K volume:
t[0] error during read error code: 87)
There has been an error during threads execution
This application has requested the Runtime to terminate it in an unusual way.
Please contact the application's support team for more information.

Howdy,
Yes, DISKSPD's failure paths in the worker threads are not graceful, and this falls into that fairly wide category: most/all of per-file/target checking is deferred into the worker thread that will do the touch.
I'll keep this open to track.
In the meantime, this bit of powershell shows how to get the logical/physical sector sizes. The first is a 512 native HDD, the second is an SSD showing 512e mode. Your device should show as 4K for both.
PS C:\Windows\wttbin> get-physicaldisk -SerialNumber Z1X02H4100009329E3H6 | select *SectorSize | fl
LogicalSectorSize  : 512
PhysicalSectorSize : 512
PS C:\Windows\wttbin>
PS C:\Windows\wttbin> get-physicaldisk -SerialNumber BTHV443503XH400JGN | select *SectorSize | fl
LogicalSectorSize  : 512
PhysicalSectorSize : 4096

Closing old issue. We expect analysts do need to understand the properties of their storage subsystem. This is pretty straightforward for single devices (above) in PS1.
The issue of the (lack of) gracefullness in how DISKSPD errors out when execution fails in a worker thread is still open, but its not a 4KN issue.


Unable to accurately update baseline image

Unable to accurately update baseline image
I generated two pictures in the baseline through the code, img1 and img2, and the same two pictures in the compoarision. At this time, the logic of img2 was deleted in my code, and after using the cli update (cypress run --component && cypress -image-diff.js -u) img2 in baseline is not automatically deleted

deletion of baselines are still manual unfortunately... although this is a feature that could definitely be introduced!

Oh I think I might just use the container to run this way


Missing Windows 11 values

Are there new strings introduced for Windows 11?  If so, can they please be added to this table.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 7eea1fbb-7f7d-d32d-da26-07f6499b3336
Version Independent ID: 3fed902a-fb51-cd76-29d1-3fdaa97d847f
Content: How to Identify the Windows Version in ACPI by Using _OSI - Windows drivers
Content Source: windows-driver-docs-pr/acpi/winacpi-osi.md
Product: windows-hardware
Technology: acpi
GitHub Login: @barrygolden
Microsoft Alias: bagold

Thanks for submitting this issue, @superm1.
I've checked in with the ACPI engineering team. The _OSI string for the next version of Windows is work in progress and has not yet been released to documentation for publication. I will update this topic as soon as I receive the information from the ACPI team.

Closing this issue as no additional action is possible at this time. Will update the issue after the _OSI string for the next version of Windows has been added to this topic.


Spatially partitioned data structures

Right now, Datashader iterates through the entire dataset each time it computes an aggregation of points, lines, or trimesh grids.  This approach allows Datashader to use standard Pandas and Dask dataframes, but it has the major disadvantage that repeated aggregations over a tiny subset of the data (e.g. census data from NYC) are just as expensive as for the full data (e.g. the entire US census data), which makes interactive zooming much slower than it needs to be.
Various spatial data structures have been defined that divide the data into spatial subsets for efficient access, such as RTrees and KDTrees, and it would be great to add optional support for one of these to Datashader.

Done in #702 and #706


Date.getTimezoneOffset returns inconsistent results

This is using the following version:
<dependency>
    <groupId>org.graalvm.js</groupId>
    <artifactId>js</artifactId>
    <version>20.1.0</version>
</dependency>

The following unit test fails:
    @Test
    public void offsetTest() {
        OutputStream stdout = new ByteArrayOutputStream();
        Context context = Context.newBuilder("js").out(stdout).build();
        String func = "function f() { print(new Date().getTimezoneOffset()); print(new Date(0).getTimezoneOffset()); }";
        context.eval("js", func);
        Value function = context.eval("js", "() => f()");
        assert function.canExecute();
        function.execute();
        String[] debug = stdout.toString().split("\n");
        Assert.assertEquals(2, debug.length);
        Assert.assertEquals(debug[0], debug[1]);
    }

On my machine, which is in PST, the two results I get are 420 and 480. The latter is the correct one.

This is a misunderstanding, I believe. Note that getTimezoneOffset() is not supposed to return the same value for all dates. The value depends on daylight saving time changes (and possibly on various timezone-related changes in the past).

On my machine, which is in PST, the two results I get are 420 and 480. The latter is the correct one.

If you are in Pacific area then you have PDT (not PST) by now. So, 420 is the correct result for new Date() (i.e. for the current date). new Date(0) corresponds to 1.1.1970. There was no summer-time that day (I believe). So, 480 looks like a correct result as well. Note that you would see the same results in your browser as well most likely. You can check that other JavaScript engines (for example V8 in the original Node.js) return the same results:
$ TZ=US/Pacific node
Welcome to Node.js v12.18.0.
Type ".help" for more information.
> new Date().getTimezoneOffset()
420
> new Date(0).getTimezoneOffset()
480


Search

Hi,
Do you think it could be possible to add Simple Jekyll Search to this template?
I can work on it :smiley: !
Thanks
PS: For example, this theme uses the plugin.

Sounds like a good idea! How do you plan to implement it in terms of UI level? May be leveraging the existing design of the sidebar-nav.html? What do you think?
Thanks.

It could be on bottom left?


Reciprocal ASUs should have consistent dmins

When multiple files are supplied, the DataFormatter classes which construct ReciprocalASU instances determine the appropriate dmin on a per file basis. This can cause issues with the double-Wilson prior down the line. Particularly, if a child node has a higher resolution cutoff than its parent, you can end up with a nasty error when the prior tries to look up the equivalent for high resolution reflections in the parent. I think the most durable solution here is that the DataFormatter base class simply pick the dmin which is consistent with the highest resolution dataset and use it for all ASUs.
For users running into issues with this, the current workaround is to supply a --dmin which is lower resolution than the lowest resolution data set.

I'm encountering a similar issue in the context of what we discussed earlier today--providing OFF data in a higher-symmetry spacegroup and ON data in a reduced-symmetry spacegroup, while invoking the double-wilson prior. In this case, each individual dataset has data out to about 1.50 A, but I set --dmin=1.7. I checked that all MTZs have the same unit cell parameters. Attached: careless input parameters and error traceback. (the first line is due to my bash script, please ignore).
inputs_params.log.txt
myoutput_39898999.err.txt

I tried v 0.2.4 and 0.2.6 with the same result.

As per our slack discussion, the issue here is that the parent spacegroup has its systematic absences determined in spacegroup 19 and the child spacegroup 4. So, when the model looks up the conditioning reflections from the parent some small number along the principal axes are missing. The workaround for now is to remove systematic absences from the children using the higher symmetry group. However, this is a tad unsatisfactory. We should revisit this later.


⚠ Bofrost.de has degraded performance

In 261b8f1, Bofrost.de (https://www.bofrost.de) experienced degraded performance:

HTTP code: 200
Response time: 1392 ms

Resolved: Bofrost.de performance has improved in 1310188 after 16 minutes.


Error Modal Buttons: change text

Is your feature request related to a problem? Please describe.
The Error Modal (modal-connectivity-error.component) is used in multiple scenarios. The button choices are currently:
Reload: reloads the page
Close: closes the modal
Describe the solution you'd like
Allow different buttons to be specified with different actions and button style.
E.g.
Button Text:
Reload
Close
Cancel
OK
Ignore
Skip
Actions:
reloads the page
closes modal
closes modal and does something

Closing due to archiving repository


Add Error implementation and variants with thiserror

Hello and thanks for this great crate. I added some error variants like issue #3 suggests. However, I also messed up your codebase by changing the edition to 2018 and adding thiserror as a dependency for generating the Display implementation for errors. I also renamed RocketErr to just Error because I believe it's less redundant and more predictable that way. Sorry if you dislike some of my changes in this PR, I can rework it if needed. Also, should we handle at least some of the in-session Errors with returning a Result instead of panicing so that users can try to reconnect?

Also about that Cargo.toml authors field, I don't need to be credited as an author if you don't want to. I can't claim to know how exactly Rocket works so I cannot take too much responsibility

I've looked at your code and it looks great, yes. I think replacing all panics with errors is a good next step but I will merge this for now!


Add deletion blocker operator in CAPVCD default apps

In reference to https://github.com/giantswarm/giantswarm/issues/22246
Same behavior observed with CAPVCD.

The app has been a part of the collection https://github.com/giantswarm/cloud-director-app-collection/blob/main/flux-manifests/deletion-blocker-operator.yaml
We fixed the config issue recently https://github.com/giantswarm/config/pull/1212
Testing now.

While testing, I noticed a small improvement in cluster-cloud-director to get a faster result from deletion-blocker-operator. Other than that, everything is fine.


Type check for kwargs

Addresses #21

There is some eyntax error, probably ; gain was written as ; T(gain) instead of ; gain=T(gain)

true, I forgot to fix the orthogonal call


[RESOLVED] Interface eth0(): High error rate (>2 for 5m)

Problem started at 09:30:29 on 2023.08.15
Problem name: Interface eth0(): High error rate (>2 for 5m)
Host: S100-Primario
Severity: Warning
Operational data: errors in: 3, errors out: 0
Original problem ID: 36170
Event details in Zabbix: http://<IP_ADDRESS>/tr_events.php?triggerid=23483&eventid=36170

Problem has been resolved in 6m 0s at 09:36:29 on 2023.08.15
Problem name: Interface eth0(): High error rate (>2 for 5m)
Host: S100-Primario
Severity: Warning
Original problem ID: 36170


No git binary found in $PATH

When I try to install jspdf, npm complains that no git binary found. Usually npm does not require git executables to be present on the system. However, if I do put git in my path it works. It is a huge impediment during deployment because I can't guarantee that git client is installed on the server.

can repository type be changed?
"repository": {
"type": "git",
"url": "https://github.com/MrRio/jsPDF.git"
},

Hey. Thanks for the ticket. What to?
On Wed, 23 Aug 2017 at 22:14, gbluv<EMAIL_ADDRESS>wrote:

can repository type be changed?
"repository": {
"type": "git",
"url": "https://github.com/MrRio/jsPDF.git"
},
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/MrRio/jsPDF/issues/1389#issuecomment-324464511, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAC5s3J0KVLLCyrmmw-dproRzjIYTKfbks5sbJYwgaJpZM4O-0p2
.

--
James Hall
Director
Parallax Agency Ltd
M.<PHONE_NUMBER>0

something tells npm to start using git executable. Could it be related to dependencies?
"dependencies": {
"adler32cs": "github:chick307/adler32cs.js",
"cf-blob.js": "0.0.1",
"filesaver.js": "github:andyinabox/FileSaver.js"
},
maybe we could give it https path instead of github: ?

Ah ok yeah. Maybe we could bring these deps in as npm modules now.
On Wed, 23 Aug 2017 at 23:07 gbluv<EMAIL_ADDRESS>wrote:

something tells npm to start using git executable. Could it be related to
dependencies?
"dependencies": {
"adler32cs": "github:chick307/adler32cs.js",
"cf-blob.js": "0.0.1",
"filesaver.js": "github:andyinabox/FileSaver.js"
},
maybe we could give it https path instead of github: ?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/MrRio/jsPDF/issues/1389#issuecomment-324476480, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAC5s9U8fcLP1CNWixcn8Xm7eG6biRcpks5sbKKYgaJpZM4O-0p2
.

--
James Hall
Director
Parallax Agency Ltd
M.<PHONE_NUMBER>0

+1

Hi James, just curious, any eta on that?

In the next week I reckon. If you could make and test a PR that would be even better! :)

Fixed in #1432

James, I still get this error is that because release with this change was not generated yet?

@gbluv yea the change hasn't been published yet

Hey there, it should be live in v1.3.5 – can you try?

Thanks Guys, all is there. This was my old comment. Everything works perfectly had to do only one extra require for html2canvas otherwise all is good

yo sigo teniendo el mismo error cuando quiero instalar el npm install nodebots-interchange


enable serverless compute

There is no such configurable item in account<EMAIL_ADDRESS>
https://accounts.cloud.databricks.com/settings/feature-enablement?account_id=beba8dfe-2870-4233-a416-34f13d350f4a

It is enabled by default


Prevent no-op updates of Kube objects

We are currently doing a lot of Update calls for Kube objects that don't
actually change anything and happen because the server defaults fields
and our code resets them to be empty. We prevent this by implementing a
custom CreateOrUpdate that will copy fields that get defaulted from the
object on the server to the locally-modified object, if unset in the
latter.
Additinally, we will log if we detect multiple updates to the same
object without an attempted update that resulted in a no-op. We then
verify in the e2e tests that we don't log this to detect regressions.
Ref https://issues.redhat.com/browse/HOSTEDCP-237

/retest

/retest

We weren't paying attention before. Now we are. I already fixed two examples, it was trivial even in deployment case. So I have a basis for estimating the effort. I agree we should find an SLI to cover these sorts of performance regressions, whether it's a metric or a revision or generation check or something.

I don't think paying attention is a sustainable factor. We need automation to catch this today.

The proposal here has the same no-op testing need as defaulting fixes, so I don't see any difference in that regard. But, in addition, this proposal introduces an entirely new surface area for testing (the generic diff/apply mechanism). It may look simple, but it's certainly not small or necessary, and carries some non zero risk and ongoing burden there in terms of bugs and testing as well.

I agree this coupling is unfortunate https://github.com/openshift/hypershift/pull/543#discussion_r726042701. Can we enumerate alternatives that let us test we don't regress and give us confidence without changing current implementation? e.g:
1 - Move the loopDetector logic once layer above and make it an indivisible part of a library reconciler function?
2 - Check OperationResultNone is logged for all reconcilers?
3 - using envtest envs?
4 - events?
I think 1 make sense. That way we keep current implementation details, we log appropriately and so we can test.

Just to be extra clear, I'm not suggesting just paying attention is the only answer for prevention. I agree we need metrics. If we have some reliable detector, it should be useful and applicable regardless of how the detected problems are fixed, and should be incorporated into our new metrics capabilities. But this PR is about both detection and a generic for the class of problems. I'm saying I'm not yet convinced about the fix. I agree we should add some kind of detection, ideally integrated with monitoring.
For example, if the loop detector is reliable and trustworthy, couldn't it generate a Prometheus metric on which we base an assertion or alert so that tests fail unless the counter or rate or whatever is zero or below some threshold for durations of tests?

But this PR is about both detection and a generic fix for the class of problems. I'm saying I'm not yet convinced about the fix.

Honestly, I don't understand anything about why we have this discussion. It all started with a bunch of comments about complexity. All this change here does is "If new object field is nil || empty string, copy it from old object". I have a hard time understanding how that is complex in any way. And I vastly prefer solving a problem once and for all in a central location than having to constantly keep attention to do it right.

Honestly, I don't understand anything about why we have this discussion. It all started with a bunch of comments about complexity. All this change here does is "If new object field is nil || empty string, copy it from old object". I have a hard time understanding how that is complex in any way. And I vastly prefer solving a problem once and for all in a central location than having to constantly keep attention to do it right.

My only concern with the PR is the maintenance burden for the extra layer introduced which we have no guarantees is bug free and we should ideally unit test, and we deviate from controller runtime rather than build atop. And also the fact that we deviate the ci artifact from prod. But I also agree with your rationale to do that.
It'd be also interesting to try to solve this problem and consolidate this approach with upstream controller runtime.
@alvaroaleman @ironcladlou let's punt on solving this problem and have a discussion all together once @csrwng is around as well since he also had some opinions

/retest
Cleanup failure


Duration & Effort of Introduction to Programming courses problem

Hi there!

Course
Duration (Platform)
Effort (Platform)
Duration (Repo)
Effort (Repo)

Python for Everyone
4 months
12 hours/week
9 weeks
58 hours

Fundamentals of Computing
8 months
6 hours/week
9 weeks
138 hours

I wonder, where do Duration and Effort numbers for both of Introduction to Programming courses come from?
For example, Coursera suggests 4 months with 12 hours/week effort for Python for Everyone, while it is 9 weeks with 58 hours total effort1 in the repository. That's ~6 hours/week.
4 months ≈ 17 weeks times 12 ≈ 200 hours total. Numbers are really really off here, or did I miss something?
Calculations for Fundamentals of Computing: 8 months ≈ 35 weeks times 6 ≈ 210 hours total. In the repo it is 9 weeks and 138 hours, which is ~15 hours/week.
1 Why? Hours/week is used everywhere except in this category. I think, it is more convenient to use what a course platform suggests.

The overall effort was calculated from adding up the hours listed on each course within the specialization*. So for example, the first course in Python for Everything states that it will take 12 hours to complete.
The inclusion of the duration was an oversight. Historically OSSU has listed a duration alongside hours/week. However, many students report working on classes full time. With an overall effort number and knowledge of the number of hours they can devote a week, students can better estimate how long it will take to complete a course. I'm going to remove the duration column from these two courses.

I did not include the time for the 4 hour capstone test of Fundamentals of Computing.

Sounds reasonable, thanks for a quick reply! I've done a quick check, it seems other courses are OK, except I found a similar problem in Core CS section: first two courses —How to Code— are 8-10 hours instead of 2-3 hours stated on their pages. Should we change that also?

It sounds reasonable to me that we change How to Code to 2-3 hours a week, as that is what the course instructors advertise.
@hanjiexi I see that you estimated the courses at 8-10 hours a week in this commit:
https://github.com/ossu/computer-science/commit/9552eb9d4717334d76eb968e20a726b20f532e49?diff=split
Is there any background we should know before changing it?

Actually I think the 2-3 hours for "How to Code" is a mistake. I'm currently doing this course, and have contacted edX about rectifying it.
The actual duration is per the syllabus section of the course, accessible after course commencement. This works out as 44 - 66 hours total over 6 weeks. So the currently stated duration is closer to the truth.
See below for details of the first part (simple data).

@waciumawanjohi I think I generally went with the advertised time duration unless, after enrolling in the course, I found evidence to the contrary. What @Isoaxe found is the likely reason I went with a higher estimate. I also notice that I gave an estimated length of 60 hours on the wiki page for Core Programming, excluding the "duration" column for the same reasons given above.
Realistically, if someone is already comfortable with programming, How to Code can be breezed through much quicker than 60 hours. I would consider it an estimated maximum rather than an average.

Thanks for the information @hanjiexi and @Isoaxe
@hematogender I hope this answers your concerns about How to Code. Based on the information above, there is not a reason to change the time estimates for those classes.


Fix sorting of query history

Clicking "Query history" header doesn't sort, initially at least.

This is fixed for the next website release.


Combine visualizations tutorials

Closes #43
I added the Draw circuit info from the advanced_circuit_visualizations tutorial to the beginning of the Plotting histograms tutorial, then did some wordsmithing and edited punctuation, capitalization, etc. for consistency and readability.

Btw I opened https://github.com/Qiskit/documentation/issues/172 to track my feedback that I think this duplicates API docs a bit. Totally fine to be a later follow up, or to decide it's not worth pursuing.


Bump helm to v3.14.1

bump helm to v3.14.1 and go to 1.21

fixes an issue with helm change in v3.14.1
till helm v3.13.x engine initialization was based on config: ref and because of that the check to create engine's lookup func pass in case of nil config.
but in helm v3.14.x clientprovider is introduced and the clientProvider is not nil even if we pass nil config. ref
and then the check is also modified and now relies on the clientprovider.
So if we initialize Engine using New function with nil config it will cause this lookup function to be used even though the config is nil now. Which can cause issues while rendering templates. That's why replaced the constructor call with type initialization.

bump golangci-lint to v1.54.0

@vardhaman22 Any chance to get this PR merged?

@vardhaman22 Any chance to get this PR merged?

@recena
@adamkpickering has a ticket open for the access to merge in this repo. Once that is done we can merge.