A syntax parsing error when executing SQL queries

Sqlpad version:
6.6.0
Description:

step 1: create a postgresql connection
step 2: create a table

CREATE TABLE employees (
  employee_no integer PRIMARY KEY,
  name text,
  department text
);

CREATE TABLE employee_dept_changes (
  employee_no integer NOT NULL,
  name text,
  department text,
  changed_on TIMESTAMP(6) NOT NULL
);

step3: insert data

INSERT INTO employees VALUES
(1221, 'John Smith', 'Marketing'),
(1222, 'Bette Davis', 'Sales'),
(1223, 'Lucille Ball', 'Operations'),
(1224, 'John Zimmerman', 'Sales');

step4: create a function

CREATE OR REPLACE FUNCTION record_dept_changes()
RETURNS TRIGGER AS
$$
BEGIN
IF NEW.department <> OLD.department
THEN INSERT INTO employee_dept_changes(employee_no, name, department, changed_on)
VALUES(OLD.employee_no, OLD.name, OLD.department, now());
END IF;
RETURN NEW;
END;
$$
LANGUAGE 'plpgsql';

problem snapshot:

reason:
The service program parses the SQL query statements entered by the user in the SQL editor.  When I check the code in server/model/batches.js:

I found the program to use sqlLimiter for determining how to parse out an independently executable SQL statement.
But, PostgreSQL uses specific syntax to embed multiple SQL statements within a single SQL statement to create stored procedures like the following (note the '$$' tag):
CREATE OR REPLACE FUNCTION dummy(IN dummy_arg varchar)
  RETURNS varchar LANGUAGE plpgsql AS $$
DECLARE
  dummy_result varchar;
BEGIN
  select concat('dummy(', dummy_arg, ')') into dummy_result;
  return dummy_result;
END $$;

Please considering optimizing the sql-limiter parser.

Thanks for this thorough repro and analysis @key7men!
Will have to think a bit on how to address this. sql-limiter uses moo to parse SQL, but unfortunately lacks a means of handling dollar quoted strings. https://github.com/no-context/moo/pull/132
Will have to give this some thought. Some ideas in mind:

Add support for $$ for short-term, and treat everything inside as a string, so that it would be included in proper statement
Add some sort of pre-check step that tries to detect dollar quotes. Those specific dollar quotes can be passed in to sql-limiter, and moo parser can be generated on the fly

Thanks for this thorough repro and analysis @key7men!
Will have to think a bit on how to address this. sql-limiter uses moo to parse SQL, but unfortunately lacks a means of handling dollar quoted strings. no-context/moo#132
Will have to give this some thought. Some ideas in mind:

Add support for $$ for short-term, and treat everything inside as a string, so that it would be included in proper statement
Add some sort of pre-check step that tries to detect dollar quotes. Those specific dollar quotes can be passed in to sql-limiter, and moo parser can be generated on the fly

For now, to solve this recognition problem, I added an extra judgment as a temporary solution
  async create(batch) {
    let createdBatch;

    const queryText = batch.selectedText || batch.batchText;

    // sqlLimiter could fail at parsing the SQL text
    // If this happens the error is captured and reported as if it were a query error

    let error;
    let statementTexts = [queryText];
    try {
      statementTexts = sqlLimiter
        .getStatements(queryText)
        .map((s) => sqlLimiter.removeTerminator(s))
        .filter((s) => s && s.trim() !== '');

      if (queryText.includes('$$')) {
        statementTexts = assembleForPG(statementTexts);
      }
    } catch (e) {
      error = e;
    }

...

function assembleForPG(list) {
  let tmp = '';
  let result = [];
  const len = list.length;
  for (let i = 0; i < len; i++) {
    if (list[i].indexOf('$$') !== -1) {
      if (list[i].indexOf('$$') === list[i].lastIndexOf('$$')) {
        if (tmp) {
          tmp = tmp + list[i] + ';';
          result.push(tmp);
          tmp = '';
        } else {
          tmp = tmp + list[i] + ';';
        }
      }
    } else if (tmp) {
      tmp = tmp + list[i] + ';';
    } else {
      result.push(list[i]);
    }
  }
  return result;
}

Next I will try to optimize sql-limiter


How do you use or call the nWidart/module package in a Controller or Livewire Component

`<?php
namespace Modules\Core\Http\Livewire;
use Modules; //here
use Livewire\Component;
class ModuleManagerComponent extends Component
{
public $available_modules;
public function render()
{

    $this->available_modules = Module::all(); //here
    dd($this->available_modules);
    return view('core::livewire.module-manager-component')->layout('layout.demo1.master');
}

}`

I don't see a proper question in the body of your issue here, but the code you pasted looks good.

I solved it was looking for this:

solved. Wanted to know how I can USE the package in the component:

Oh I see ok, great you found it! 😄

Thank for being there, awesome 😃
On Thu, Sep 30, 2021 at 6:02 PM Nicolas Widart @.***>
wrote:

Oh I see ok, great you found it! 😄
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/nWidart/laravel-modules/issues/1287#issuecomment-931456496,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AVBSGVKYM2N6FHGFTOQNPL3UESCYHANCNFSM5EUAPFFQ
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.


portmod: 2.1.0 -> 2.6.2

Description of changes
Lots of change in https://gitlab.com/portmod/portmod/-/blob/master/CHANGELOG.md?ref_type=heads#262-2023-05-06.
This is needed for Python 3.11 support. Since this derivation is a bit complex, I tried to leave the structure of it as untouched as possible for expediency.
Things done

Built on platform(s)

[ ] x86_64-linux
[x] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

@marius851000 do you still use this package and can test it?

Oh! Sorry for not having answered sooner. I now have time to take a look at all this again. For now, this seems to have been merged (or maybe even directly committed), so this PR could be closed. I’ll do the same for mine, and then make a new one for 2.7.0.

Done in #251878.


CI: K8sHealthTest cilium-health Checks status between nodes

/home/jenkins/workspace/Cilium-PR-K8s-GKE@3/src/github.com/cilium/cilium/test/ginkgo-ext/scopes.go:527
Expected
    <string>:
not to be empty
/home/jenkins/workspace/Cilium-PR-K8s-GKE@3/src/github.com/cilium/cilium/test/k8sT/Health.go:101

Edit : I'm unable to attach the sysdump. It keeps giving error " is not included in the list".

@joestringer noted that the health Endpoint was still in the regenerating state when the test failure was reported. Looking at the relevant test code, we don't have retries.
cmd: kubectl exec -n kube-system cilium-7htdv -c cilium-agent -- cilium endpoint list
Exitcode: 0
Stdout:
 	 ENDPOINT   POLICY (ingress)   POLICY (egress)   IDENTITY   LABELS (source:key[=value])                                  IPv6   IPv4           STATUS
	            ENFORCEMENT        ENFORCEMENT
	 143        Disabled           Disabled          4          reserved:health                                                     <IP_ADDRESS>   regenerating
...

Edit : I'm unable to attach the sysdump. It keeps giving error " is not included in the list".

That's GitHub's very intuitive error message to tell you your sysdump file is too big. The limit is 25Mo IIRC. Decompressing and recompressing using 7z is usually enough to go below the limit.

encountered in https://github.com/cilium/cilium/pull/18597#issuecomment-1020371951


Please release a new version

with codes in master, thanks!

Hi @wong2 I will check it and release a new version.

New version was released.

thanks


Default middleware for request validation, like IIS has

Remember this?
<configuration>
   <system.web>
      <pages validateRequest="true" />
   </system.web>
</configuration>

http://www.asp.net/whitepapers/request-validation
The awesome thing about IIS ASP.NET websites is that they prevented html/script injections AS A DEFAULT!
In .NET Core, it isn't even possible.
I think there should be a middleware that does validation on posted form values, http headers, etc.
Maybe some of the Microsoft employees here can ping the IIS team for the code ;)

/cc @blowdart @DamianEdwards

RequestValidation was always rather porous, and eventually we came to the realisation that validate should be an app concern, because what's validate for one application isn't valid for another,
We encode output by default, which is a much better approach to XSS.
It won't make a return.

We encode output by default, which is a much better approach to XSS.

Do you mean in Razor, with the<EMAIL_ADDRESS>
validate should be an app concern

There isn't official guidance on this. I get it, everybody could roll their own, but your not worried about the number of File > New > Project projects that will be exposed? I'm not even seeing MVC action attributes that do request validation.

Yes, I mean the @ in Razor.
Encoding is a far better way to mitigate against XSS than any sort of filtering, which is why I'm not worried File > New Project being exposed.
The request shouldn't be what's validated, it should be the inbound model.

Any updates on whether this will be added to the feature list at some point or not?

We have no plans to ever build a request validation middleware like what existed in System.Web.

"RequestValidation was always rather porous", " we came to the realization that validate should be an app concern"...
I can't even imagine how many newbs were saved by this being enabled by default. In order to shoot yourself in foot you needed to explicitly disable it. Now, anybody writing @Html.Raw needs to be knowledgeable enough to consider every possible XSS scenario.
So, while you are it you should maybe tell "BasicDataware team" to remove SQL Injection protection when using SqlValueParameter... like why not?
It would be much more honest for you guys to say that you are just too lazy to build this... Which I also don't get... it's probably like 1 day project. I'll link here in case I build Interceptor that deals with this, if anyone else form open source community beats me to it - please post link. Thanks.

We don’t think the feature is a good one (otherwise we would have.l built it in again) and we think that there are much better ways to do it. If you want to bring back request validation, feel free to do so as a middleware.

@davidfowl I get it - it's easy to say this is judgment call. But it does make sense to have something that you can easily turn on in config / initialization. That way you save bunch of people from writing BaseRequest classes that do validation + can validate HTTP calls that are not necessarily request DTOs.
Anyways, I'll link here if implement middleware that deals with this & thanks for taking time to reply.


Use 32-bit coordinates throughout the project

Previously this project used a great variety of types to present text buffer
coordinates: short, unsigned short, int, unsigned int, size_t,
ptrdiff_t, COORD/SMALL_RECT (aka short), and more.
This massive commit migrates almost all use of those types over to the
centralized types til::point/size/rect/inclusive_rect and their
underlying type til::CoordType (aka int32_t).
Due to the size of the changeset and statistics I expect it to contain bugs.
The biggest risk I see is that some code potentially, maybe implicitly, expected
arithmetic to be mod 2^16 and that this code now allows it to be mod 2^32.
Any narrowing into short later on would then throw exceptions.
PR Checklist

[x] Closes #4015
[x] I work here
[x] Tests added/passed

Validation Steps Performed
Casual usage of OpenConsole and Windows Terminal. ✅

oh my god I love this image

(A backup of the original submission description)

Codeflow link:
\\codeflow\public\cf.cmd openGitHubPr -webUrl https://github.com/microsoft/terminal/pull/13025

}

ah. okay. that makes sense.

Refers to: src/types/UiaTextRangeBase.cpp:1022 in 6d2f72c. [](commit_id = 6d2f72c71ff2c84e16ce9c4608ad8e65d1b578f8, deletion_comment = False)

can maxLength no longer be -1?

I figured, if we already use signed integers for everything and if we already consider negative considers as "invalid", then I can also just use it as a parameter there. Coincidentally this works really well there, because UiaTextRangeBase::GetText is apparently called with a negative maxLength.

i feel like there's a much better HRESULT for this than "win32 unhandled exception"; perhaps E_BOUNDS or WIN32(ERROR_ARITHMETIC_OVERFLOW)?

I chose this so that it generates the same HRESULT as gsl::narrow would if used with wil's exception helpers. Unfortunately wil has no option to be gsl-aware.
I think this consistency is important so that you can see an ERROR_UNHANDLED_EXCEPTION and already know that a narrowing failure is the most likely cause.
I believe it'd be better if we replace all gsl::narrow calls with til::narrow ones which throw an ERROR_ARITHMETIC_OVERFLOW exception so that everything continues to be consistent.
What do you think? 🤔

Oh no!

StartGroup: FillOutputTests::WriteWideGlyphUnicode
Verify: AreNotEqual(hConsole, INVALID_HANDLE_VALUE): Ensure we got a valid console handle
Verify: IsNotNull(hConsole): Ensure we got a non-null console handle
Verify: Win32BoolSucceeded(FillConsoleOutputCharacterW(hConsole, L'\x304F', 1, { 0, 0 }, &charsWritten))
Error: Verify: AreEqual(1u, charsWritten) - Values (1, 2) [File: C:\a\_work\1\s\src\host\ft_host\API_FillOutputTests.cpp, Function: FillOutputTests::WriteWideGlyphUnicode, Line: 92]
EndGroup: FillOutputTests::WriteWideGlyphUnicode [Failed]


[Windows] Skip oledb test for windows2016

Description
It was forgotten to skip the test for windows 2016 in the https://github.com/actions/virtual-environments/pull/4893
Related issue:
https://github.com/actions/virtual-environments/issues/4881
Check list

[x] Related issue / work item is attached
[ ] Tests are written (if applicable)
[ ] Documentation is updated (if applicable)
[ ] Changes are tested and related VM images are successfully generated

/azp run windows2016


fix compiling on macOS

Compiling on MacOS with nob works fine except for some errors created by voxels

MacOS uses OpenGL/gl.h rather than GL/gl.h

There was a redefine error for M_PI_2

Although this PR fixes those compile-time errors, there is also a runtime error/crash related to rendering when I run ./build/client
The error log for the GLSL compilation says

Version '330' is not supported.

This could be a problem with the macOS machine I'm using or with macOS itself. Testing on a different Mac computer would be able to diagnose this issue.
However, this confuses me because, for the gl33 example, I believe I also used version 330 core.

Update: I believe the issue is that RGFW_setGLVersion(RGFW_GL_CORE, 3, 3); is missing, this line is important because it tells RGFW to tell the APIs to give you a context that supports OpenGL core 3.3.

I included GL/gl.h only for GLfloat. OpenGL's GLfloat is 32 bits wide. But a plain float is often 32 bits wide as well.
When I really need to include gl.h, I should include it like this: #include <glad/gl.h> as in include/render.h.

@TheYahton Okay, the program runs fine on MacOS now btw! (with RGFW_setGLVersion added)

I'm glad to hear that!


make repo subdirectroy of multitenancy optional

Right now, the current multitenancy design mandates a structure in this style: org1/repoa, org2/repoa. While I still think two levels are a good idea in a centralized hosting scenario, I also think that it might be overkill for a corporate scenario where only one chartmuseum is present and one level (the org level) would be used for different teams. It appears that the file structure of the repos could be relaxed when the org separation is enough for simple use cases.
The two levels could be useful for these corporate teams, for providing something like dev / staging / prod, but can also be too fine-grained for a team only wanting a separate namespace.
This issue is opened to discuss the merits of an optional two level separation.

@davidovich that sounds reasonable.
Just to clarify, you are looking for multitenany routes such as

/repo1/index.yaml
/repo2/index.yaml
/repo3/index.yaml

?

@davidovich what if... instead of a --multitenancy flag, we add something such as --depth=<int>? And the routing would change based on that param?
--depth=0 (default) would give you singletenant as it works today:
/index.yaml

--depth=1 would give you what you're looking for:
/<repo>/index.yaml

--depth=2 would give you what multitenant is today:
/<org>/<repo>/index.yaml

And people could even decide to do something with --depth=3 or more:
/<org>/<team>/<repo>/index.yaml

Thoughts?

Yes I think this would provide the wanted value. Could I suggest adding --tenant-depth instead of changing --multitenancy ?

Once we're ready to "release" multitenancy, I'd like to just have the --depth or --tenant-depth flag, which defaults to 0. If things are done correctly the user should see no change, and there will be no multitenancy unless explicitly specified with the flag.
For now, until everything is well tested, the new flag would take no effect unless --multitenancy is also used.
I very much intend to break this API without warning, hence the bold "experimental" in the readme :)


Do you mind if I ask a question?

I wonder how does it works that detect outer of components witch need toggle such as menu, a drawer in layout. I've seen source codes of my curiosity but I couldn't find where except binding click event on components.

Please use StackOverflow for support and integration assistance. This tracker is only for problems with the code provided by Material Design Lite.
Since this is just a general question on how things work and there isn't a specific problem to be acted upon, you should go to more general support places for help. We simply don't have the people-power to handle support within the issue tracker itself.
Thank you.

We simply don't have the people-power to handle support within the issue tracker itself.

every google ticket ever


Additional issues in "ARCore Augmented Images" codelab

Hi,
Below are suggestions for improving the ARCore Augmented Images codelab, along with details of issues that I encountered:
Step 4:
I suggest adding a note that the specified updateModelMatrix() code should be added as a new function rather than replacing the existing updateModelMatrix() (replacing the function causes errors)
Step 5:
The user is asked to add code to AugmentedImageNode.java, but this file has not been supplied. As stated in issue #8, the code needs to added to AugmentedImageRenderer.java instead so suggest updating the codelab accordingly.
Step 6:
The PhysicsController.java file contains build errors; these can be fixed as follows:
a) Update package name: replace
package com.google.ar.sceneform.samples.augmentedimage;
with
package com.google.ar.core.examples.java.augmentedimage;
b) Remove the following lines:
import com.google.ar.sceneform.math.Quaternion;
import com.google.ar.sceneform.math.Vector3;
c) Do Build->Rebuild Project to install jBullet and resolve PhysicsController.java errors
Hope this helps,
Hemal.

Hi,
Thanks for your suggestion. Your suggestion are great. The codelab was originally for sceneform SDK, then ported to Java SDK, so I probably missed a few places to update. Updating the codelab is not very straightforward at the moment, but I'll add your suggestions to the home page for now.
Cheers
Kai

Hi,
Thanks for your suggestion. Your suggestion are great. The codelab was originally for sceneform SDK, then ported to Java SDK, so I probably missed a few places to update. Updating the codelab is not very straightforward at the moment, but I'll add your suggestions to the home page for now.
Cheers
Kai

I added a note in https://github.com/googlecodelabs/arcore-augmentedimage-intro/commit/33be4ecb3997b54c91416461fdb5973d30ed54dd

I added a note in https://github.com/googlecodelabs/arcore-augmentedimage-intro/commit/33be4ecb3997b54c91416461fdb5973d30ed54dd

Hi Kai,
Thanks for getting back to me; I’m glad you found the suggestions useful.
I appreciate that updating the codelab is tricky, but look forward to seeing the new version when it’s ready.
Cheers,
Hemal.
On Monday, 25 January 2021, 07:51:51 GMT, kai-dream<EMAIL_ADDRESS>wrote:

Hi,
Thanks for your suggestion. Your suggestion are great. The codelab was originally for sceneform SDK, then ported to Java SDK, so I probably missed a few places to update. Updating the codelab is not very straightforward at the moment, but I'll add your suggestions to the home page for now.
Cheers
Kai
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or unsubscribe.

Hi Kai,
Thanks for getting back to me; I’m glad you found the suggestions useful.
I appreciate that updating the codelab is tricky, but look forward to seeing the new version when it’s ready.
Cheers,
Hemal.
On Monday, 25 January 2021, 07:51:51 GMT, kai-dream<EMAIL_ADDRESS>wrote:

Hi,
Thanks for your suggestion. Your suggestion are great. The codelab was originally for sceneform SDK, then ported to Java SDK, so I probably missed a few places to update. Updating the codelab is not very straightforward at the moment, but I'll add your suggestions to the home page for now.
Cheers
Kai
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or unsubscribe.

Hi Kai,
Hope all’s well.
Just letting you know that I’ll be presenting your codelab at a Google Developer Group event tomorrow (Thu 11th Feb) at 7pm UK time. You’re extremely welcome to attend; details here:https://gdg.community.dev/events/details/google-gdg-london-presents-gdg-devparty-uki-arcore-augmented-images/#/
Kind regards,
Hemal.
On Tuesday, 26 January 2021, 09:45:20 GMT, Hemal Bodasing<EMAIL_ADDRESS>wrote:

Hi Kai,
Thanks for getting back to me; I’m glad you found the suggestions useful.
I appreciate that updating the codelab is tricky, but look forward to seeing the new version when it’s ready.
Cheers,
Hemal.
On Monday, 25 January 2021, 07:51:51 GMT, kai-dream<EMAIL_ADDRESS>wrote:

Hi,
Thanks for your suggestion. Your suggestion are great. The codelab was originally for sceneform SDK, then ported to Java SDK, so I probably missed a few places to update. Updating the codelab is not very straightforward at the moment, but I'll add your suggestions to the home page for now.
Cheers
Kai
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or unsubscribe.

Thanks for the heads up! I hope it goes well, and please let me know if you encounter problems in the codelab.

Hi,
I've updated the codelab addressed all the issues the you reported. Thanks for providing the reminders!

Step 4:
I suggest adding a note that the specified updateModelMatrix() code should be added as a new function rather than replacing the existing updateModelMatrix() (replacing the function causes errors)

Kai: Added notes to explain this.

Step 5:
The user is asked to add code to AugmentedImageNode.java, but this file has not been supplied. As stated in issue #8, the code needs to added to AugmentedImageRenderer.java instead so suggest updating the codelab accordingly.

Kai: Updated. Thanks for reminding!

Step 6:
The PhysicsController.java file contains build errors; these can be fixed as follows:
a) Update package name: replace
package com.google.ar.sceneform.samples.augmentedimage;
with
package com.google.ar.core.examples.java.augmentedimage;
b) Remove the following lines:
import com.google.ar.sceneform.math.Quaternion;
import com.google.ar.sceneform.math.Vector3;
c) Do Build->Rebuild Project to install jBullet and resolve PhysicsController.java errors

Kai: Updated PhysicsController.java link in codelab description. The link was out-of-date, even though I updated the file in Github. Sorry for the confusion. And good job you fixed those building errors yourself!


Updating Test annotations to use new library.

Import android.support.test.filters.* across all projects instead of deprecated
android.test.suitebuilder.annotation. Also, removed the Test annotations from unit tests.

I signed it!

This addresses https://github.com/googlesamples/android-testing/issues/108.

Thanks Doug!


[stitched uploads] Support individual datachunk upload

This commit includes changes to the frontend to support uploading data
chunks that will eventually be stitched together using a new
"stitchBlob" API that will be introduced in a future PR.
Changes include:

Introducing IdSigningService and reference implementation. This will
allow for the verified metadata to be attached to a blob ID that will
ensure that "stitchBlob" has enough information to safely stitch
together a composite blob.
Related changes to PostBlobHandler and IdConverter to support handling
signed IDs. The signed IDs should be servable even without being
stitched together.
Support for generating signed URLs used to upload chunks of a stitched
blob.
New router PutBlobOptions. These are not yet honored by
NonBlockingRouter, but will be in a future PR.

Codecov Report

Merging #1022 into master will increase coverage by 0.16%.
The diff coverage is 88.16%.

@@             Coverage Diff             @@
##             master   #1022      +/-   ##
===========================================
+ Coverage     68.34%   68.5%   +0.16%
- Complexity     4721    4752      +31
===========================================
  Files           378     381       +3
  Lines         29907   29979      +72
  Branches       3804    3818      +14
===========================================
+ Hits          20440   20538      +98
+ Misses         8434    8397      -37
- Partials       1033    1044      +11

Impacted Files
Coverage Δ
Complexity Δ

...c/main/java/com.github.ambry/rest/RestRequest.java
100% <ø> (ø)
2 <0> (ø)
:arrow_down:

.../src/main/java/com.github.ambry/router/Router.java
100% <ø> (ø)
4 <0> (ø)
:arrow_down:

...github.ambry.frontend/AmbryBlobStorageService.java
93.03% <ø> (+0.21%)
42 <0> (ø)
:arrow_down:

...n/java/com.github.ambry.commons/HelixNotifier.java
81.33% <ø> (ø)
15 <0> (ø)
:arrow_down:

...om.github.ambry/tools/perf/rest/PerfNioServer.java
0% <0%> (ø)
0 <0> (ø)
:arrow_down:

...va/com.github.ambry/account/AccountUpdateTool.java
0% <0%> (ø)
0 <0> (ø)
:arrow_down:

...com.github.ambry/router/PutBlobOptionsBuilder.java
100% <100%> (ø)
4 <3> (+2)
:arrow_up:

....ambry.frontend/AmbryUrlSigningServiceFactory.java
100% <100%> (ø)
2 <0> (ø)
:arrow_down:

...github.ambry.frontend/AmbryIdConverterFactory.java
97.5% <100%> (+1.5%)
2 <2> (ø)
:arrow_down:

...src/main/java/com.github.ambry/rest/RestUtils.java
94.59% <100%> (+0.02%)
74 <3> (+2)
:arrow_up:

... and 45 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6e63688...7b8f783. Read the comment docs.

@vgkholla addressed comments

@vgkholla comments addressed!


Suggestions for improving multiselect

Hey there. I found out about your multiselect script on some Overflow out there and I'm loving and using it a lot!
I've been having some ideas on improving it, but would like to share it here - just in case you or someone with more spare time than me can come up with them... Two I think would be really useful would be keys for select/deselect all options and using column when there are too many options around.
One example I can give is creating a menu for choosing sources for runnning theHarvester. As you can see below, two improvements I've made and I'm looking into how to share are translating the comands used to pt-BR and printing a prompt at the top.

The menu ends up having so many options that it can take over a single terminal screen - column usage would make a real difference here and, for the same reason of too many options, select/deselect all would too.
Thanks for sharing this amazing solution!

Hey @joaociocca,
Thanks for the kind words and for sharing your ideas.
I'm pretty sure this script could be improved in many ways, but what I like about it is its simplicity.
I can see three ways to easily accommodate your use case:

Instead of having a custom shortcut for (de)selecting all items at once, you can simply have a "Select All" (or similar) item at the top of the list.
If you wish to use multiple columns, in case you have more items than would fit on the screen, you could use this script (which is another one of the answers on StackOverflow and is also a pure bash implementation).
If you want to have even more features, then I'd recommend you to have a look at dialog or whiptail (as suggested by this answer).

I hope this helps. 😊

how would I make the "Select All" at the top? You have this documented somewhere?
Thanks for the amazing links, it really helps! Hope you have a fantastic weekend!

Sorry for my slow responses lately.
No, I haven't documented this, but you can have a look at the example of the multiselect.sh file.
You can have "Select All" at the top by making it the first option of the my_options array (i.e. in the example you could replace "Option 1" with "Select All").
Glad the links helped. 😊
Thanks, wish you a great weekend too!

ahhhh ok, I can have a "select all" that I'll treat later a s having all options as true. I had misunderstood your suggestion and thought that there was a "select all" functionality that would mark/unmark all options on the menu XD

Correct. 👍
Oh I see.. probably I wasn't clear enough.


Flicker when zooming

Zooming in causes a flicker whereby the canvas is shown zoomed in, then in the next frame, it's shown usually displaced to the left and up, then in all subsequent frames it remains correct. This occurs just about every time the zoom value changes, which indicates some issue related to the position of the document and when it gets drawn.

This is solved in v3 by switching to virtual coordinates using transform matrix, which is the groundwork for a lot of performance boosts and canvas rotation support


Consistent padding (fixed width)

I would like qmk-vim to be consistent in the number of characters used for keycodes. Currently, it's only consistent over a single layout and not the entire matrix which can result in some weird renders:
[BASE] = LAYOUT_split_3x6_3(
  KC_QUES , KC_Q , KC_W , KC_F , KC_P   , KC_B    ,                          KC_J    , KC_L   , KC_U    , KC_Y   , KC_QUOT , KC_MINS,
  QK_GESC , HR_A , HR_R , HR_S , HR_T   , KC_G    ,                          KC_M    , HR_N   , HR_E    , HR_I   , HR_O    , QK_REP ,
  KC_LPRN , KC_Z , KC_X , KC_C , KC_D   , KC_V    ,                          KC_K    , KC_H   , KC_COMM , KC_DOT , KC_SLSH , KC_RPRN,
                                 KC_ESC , NUM_TAB , NAV_SPC ,     SYM_BSPC , SYM_ENT , QK_REP
),

[SYM] = LAYOUT_split_3x6_3(
  KC_EXCL , KC_1    , KC_2    , KC_3    , KC_4    , KC_5    ,                         _______ , _______ , _______ , _______ , _______ , _______,
  KC_HASH , KC_CIRC , KC_EQL  , KC_UNDS , KC_DLR  , KC_ASTR ,                         _______ , _______ , _______ , _______ , _______ , _______,
  KC_AT   , KC_LT   , KC_PIPE , KC_MINS , KC_GT   , KC_SLSH ,                         _______ , _______ , _______ , _______ , _______ , _______,
                                          _______ , _______ , _______ ,     _______ , _______ , _______
),

See the first layout is much shorter than the second one on the left side because some columns (like 2nd and 3rd) are reduced to 5 chars on the first layout and not the second layout.
Is it possible to have a minimum width of 8?

I'll look into implementing a full colum-wise alignment option 🙂
I don't think a min-width option would solve the issue as you could still have a long key on a particular row that distorts the view 🤔

You're right, I'm just sticking to 8-chars names but that's purely on me.


Self referencing link "$":link

The textpatten docs indicate the following is a valid markup:

If you wish to link to a URL and want the URL itself in the text, you can use the following “dollar” shorthand:

"$":http://example.com/sw
(The above link was slightly changed by me)

Unfortunately, this api doesn't allow it, and renders it as:
$
I expected:
http://example.com/sw
Thanks for a great textile api however! I've been using various versions for quite some time now 👍

This should be simple to add. The only reason it isn't in there already is that I've never seen it before. 😅  I assume it is a "fairly recent" addition (RedCloth doesn't know how to do this and it wasn't there when I did the initial port).
I'll take a look when I can find the time.

Yes, it's new to me too. What would actually be awesome is the automagic recognition of a bare url:
https://some.example.com/folder/
...like markdown extensions do.
I'm not sure if you're interested in that kind of thing however.
I have another suggestion along that line too: eg /some/image/file.jpg should automatically be changed to an  ... ;)
I find textile so naturally awesome to write in: except bare urls and simple images (not that images are hard,really) ;)
I'm in no rush for changes btw. What you've done already is pretty awesome, and as you said, I used to follow the RedCloth version as well.

Yeah, I don't know why Textile doesn't support this by default. My current line is to try to follow the spec/PHP implementation as closely as I can by default. There is nothing wrong with having and allowing this behaviour with flags though.
I have been considering adding some sort of callback hooks/transformers for nodes and attributes. Partly to ease solving things like the issue in #42. Having that, it would be simple to bundle a few built in transformers and allow quickly enabling them with flags.

Many thanks @borgar!


[Bug]: Datasources displays DB's that are not being used on the current app

Is there an existing issue for this?

[X] I have searched the existing issues

Current Behavior
New design change displays datasources that belong to the current app but datasources not being used and tagged in the current app are displayed as seen in the video attached.

Steps To Reproduce

Create multiple datasources and queries across apps in an org
Observe if correct datasources are being tagged to the current app under the entity explorer. We see datasources used in other apps being displayed on the entity explorer

Environment
Deploy Preview
Version
Cloud

The unused datasources are being fetched from other pages on the app that are using them. Closing this issue since it's not an issue


Imagecapture is not defined

Hi, I am using chrome version 55,
it shows TypeError: ImageCapture is undefined in both chrome and firefox. i want to capture image and save it in database.But here not able to capture image.

Hi — are you referring to simpl.info/ic?
As per the note on the demo, ImageCapture is not implemented in Firefox yet and in Chrome you need to enable Experimental Web Platform features: chrome://flags/#enable-experimental-web-platform-features.

Thanks for info. got it.


Use Marlin defaults to prevent false thermal runaway alerts and make them configurable from UI

Still getting thermal runaway alerts after 0.3.7

Hi @gdombiak, Yes I don't get a thermal run away alert when I reprint but I do when I start a print from ambient it seems.  So this morning when I started printing again it threw a thermal runaway notification.  Im printing a lot at the moment so the print may no be reaching low enough temperatures between prints to trigger the alert.  Have had this issue for a week or so.  Hope this helps.
octoprint-9.log

Thanks @bonjipoo for sharing the logs. I see that after 10 seconds the hotend temperature did not increase by even a 0.01 degree.
2021-08-28 10:19:02,495 - octoprint.plugins.octopod - DEBUG - Thermal runaway - Started to track tool0. Temp should go up. Actual 19.6 and Target 210.0
2021-08-28 10:19:07,504 - octoprint.plugins.octopod - DEBUG - Thermal runaway - Tracking tool0. Temp NOT going up. Will wait more time. Actual 19.6 and Target 210.0
2021-08-28 10:19:12,512 - octoprint.plugins.octopod - WARNING - Possible thermal runaway detected for tool0. Actual 19.6 and Target 210.0

Quick workaround until I release a new version.

ssh into OctoPi
open .octoprint/config.yaml with an editor (e.g. vi or nano)
under plugins -> octopod add a new property and set its value thermal_warmup_seconds_threshold: 19. In this example it will wait 19 seconds to warm up a bit before sending the thermal runaway alert. Increment by 5 seconds if needed.
restart OctoPrint

I guess room temperature is cold since after 10 seconds it did not warm up even a bit. I'm curious, do you have thermal runaway protection in the firmware?
Regards,
Gaston

Thanks @bonjipoo for bringing this issue up. I now use Marlin defaults and also made them configurable from UI. Will do a new release now

Great thanks,  Just so you know.  My printer in a Voron V0.1 with 6mm thick aluminium heated bed.  That could be why the temperature sensor is slow to read.  The hotend however consists of a E3D thermistor and cartridge in a dragon hotend.  Pretty standard stuff these days.  Tricky for you when everyone has something different in the 3D printer world.  Many Thanks for your prompt work.

Nice setup @bonjipoo!! New release is out so no need for the manual workaround. Just do an update to 0.3.8 and let me know how it goes. If OctoPrint does not see the update then go here for a force update.


Cookie Notice

Description
Telling our clients we use cookies.
Type of change
Please delete options that are not relevant.

[X] New feature (non-breaking change which adds functionality)

Summary by CodeRabbit

New Features

Implemented a cookie notice for compliance with privacy regulations. Users can now acknowledge and accept the use of cookies on the website.

With the new GDPR, this will not help us.


Fixed typo in lamp-infrastructure/provision.yml

Applied a small grammatical change.

Nice, thanks!


Collapsible Categories

Dear @volkanceylan,
I've implemented the possibility to collapse form categories.
Since this patch use the Serenity.ComponentModel.CategoryAttribute and a System.ComponentModel.CategoryAttribute class already exists , we need in every form (in Serene) to explicitly set the namespace or, if there aren't other System.ComponentModel attributes in such form, directly remove this:
using System.ComponentModel;

Also the TranslationRepository.cs file need a fix (explicitly set the namespace).
This is how it looks like:

Just a note: the flex behaviour it's not fully compatible with the bootstrap collapse functionality, so I had to use a dirty trick: remove the category css class when the category itself is collapsed and re-add such class when the category is expanded.
Hope it helps
Bye

Thanks @marcobisio. I don't recommend adding another Category attribute, please add a new Collapsible attribute and try to use it. Also your pull requests fails in AppVeyor. Last time a csproj file wasn't check in.

Thanks for your feedback @volkanceylan.
I'm not sure: you suggest to add a new CollapsibleCategory attribute or add a property to the already existing category?
Because if I'm not wrong at the moment Serenity use the system.componentmodel one so I cannot modify the base type (only extend).
I'll check for the csproj!
Thanks

Just CollapsibleAttribute, with Collapsed as a property with default value false.
[Category("Something"), Collapsible] // collapsible category, which is initially expanded
[Category("Something"), Collapsible(Collapsed = true)] // collapsible category, which is initially collapsed


Init Tana Extension

Your inclusive approach might make collaborative knowledge graph Tana an interesting candidate to put on the roadmap?!
As referenced in this Reddit comment and which could also have been mentioned here.

Place to get started: Tana


turbo run --help inconsistency

What version of Turborepo are you using?
1.2.4
What package manager are you using / does the bug impact?
npm, pnpm, Yarn v1, Yarn v2/v3 (node_modules linker only)
What operating system are you using?
Mac
Describe the Bug
turbo run --help shows:
Usage: turbo run <task> [options] [-- <args passed to tasks>]

    Run tasks across projects in your monorepo.
...

The thing is that turbo run runs a pipeline, not tasks.
Expected Behavior
I think it could print something like:
Usage: turbo run <pipeline> [options] [-- <args passed to tasks>]

    Run tasks across projects in your monorepo through pipelines.
...

To Reproduce

Run turbo run --help

Hey @Wyatt-Stanke sorry this issue has been open for so long. Seems your suggestion is about using the word pipeline? I think we want to stick to task as the thing you run. A pipeline is a set of tasks (which is really kind of an internal implementation detail in turbo about how it constructs the graph of tasks). I know turbo.json has a top level configuration called "pipeline", but IMO, it should always have been called tasks, because the user isn't designing the pipeline manually, they are declaring a set of tasks and their dependencies. Turbo figures out the pipeline.
Anyway, this reply is a year and a half later, so I'm going to close this down. Thank you for making the effort to file an issue about this!


Improve video rendering for rollout.py

rollout.py gives an encoding error when rendering, and sometimes the videos don't work in certain video players. This should be fixed to be more robust.

@eugenevinitsky This can be closed I think.


#310 Collection dump requires namespace to be in oplog

OplogThread class: the implementation has been updated not to filter the oplog events by namespace name because some oplog events (replica set initialization event, for example) can affect many documents.

Hello
Thank you for contributing! It seems your pull request is a little out of date, would you mind rebasing with master? That will trigger another test run.
At first glance it seems your changes have broken the existing test suite (see here https://travis-ci.org/mongodb-labs/mongo-connector/builds/95393179). Any changes to mongo-connector should pass the test suite, but if that is not possible, fixes for the tests should be included in the pull request. Any breaking changes should be addressed.
Thanks!

@sbrunov thanks for your contribution! I used your changes as a starting point for this commit: https://github.com/mongodb-labs/mongo-connector/commit/2b48c95cb3c7a118c939040e1781cff0677b5019
This fix is included in the 2.4.1 release of mongo-connector.

Dear Anna Herlihy (@aherlihy) and Shane Harvey (@ShaneHarvey),
Sorry for the very-very late response!

At first glance it seems your changes have broken the existing test suite (see here https://travis-ci.org/mongodb-labs/mongo-connector/builds/95393179).

Sorry, I did not have a chance to continue my work on this.
I confirm: yes, please, feel free to use my changes (as you already did).
Thank you for taking care of this work and completing it!
Best regards,
Sergey Brunov.


10 bit color support?

Is it possible to support a 10 bit color context? This is necessary for my work, and I will be forced to use GLFW with raw OpenGL until it is available. I'm sure others would also benefit from this. For clarity, I mean that each color channel has 10-bit color resolution and this would be measurable in the luminance emitted from the monitor. To achieve this with GLFW, I do the following:
GLFWWindowHint(GL_RED_BITS, 10);
GLFWWindowHint(GL_GREEN_BITS, 10);
GLFWWindowHint(GL_BLUE_BITS, 10);
GLFWWindowHint(GL_ALPHA_BITS, 2);

Best and thanks,
Rob

In the past I decided to only expose the number of color bits and alpha bits: https://docs.rs/glutin/0.9.2/glutin/struct.ContextBuilder.html#method.with_pixel_format
The problem is that I don't remember why.

Ah yeah, MacOS as usual: https://github.com/tomaka/glutin/blob/9625c81c359d14458a197b571c3e566a76334084/src/platform/macos/helpers.rs#L54-L55

Hmm... so you mean that if I do something like:
... .with_pixel_format(self, 10, 2);

then, there is a possibility that I could get 10-bit color or no? Regardless, I may test this on our 10-bit monitor later today. I would only be using Linux and Windows.
Best,
Rob

No, it would be .with_pixel_format(30, 2)

Too outdated.


add settings for command history size

Making these settings makes them easier for users to change.

I'm getting some weird errors that might have to do with this code, please don't merge it just yet.

I'm getting some weird errors that might have to do with this code, please don't merge it just yet.

fixed it

fixed it


Template style_mods are ignored if an element also has style_mods

If I have something like
gui_util.add_templates{
  header_button = {type="button", style="dark_button", style_mods={width=80, font_color=core_styles.bold_font_color}}
}

and then somewhere else have an element like
{template="header_button", style_mods={width=200, maximal_width=500},caption="Name"}

Then the template style_mods (specifically font_color) no longer works - I assume the whole template style_mod section is simply ignored or overwritten by the element style_mod.
My expectation would be that individual element style_mod values would overwrite the corresponding template style_mod values - and let the rest (of the template style_mod) carry through.
I.e. a union of the two - with the element style_mod winning if there is overlap.

Yes... this is a deficiency I've known about for a while. However, I'm not going to fix it, because I'm rewriting this module and element templates are going away entirely. I recommend avoiding them and instead using a builder function or other alternative.

I recommend avoiding them and instead using a builder function or other alternative.
Woa - Thanks for the heads up!

Any approximate timeframe idea for that re-write?
Just so I have an idea if I should wait for it - or "roll-my-own" (I'm in no rush)

Lol, the rewrite is hard. I am currently on my seventh attempt, with the previous attempts ranging from slightly more than the current module to a full-blown reactive GUI framework. The rewrite won't come out until after Factorio 1.1 releases, since it relies on new GUI-related features coming in that version.


⚠ Mobitopup has degraded performance

In e179a0b, Mobitopup (https://napcard.voz.tech) experienced degraded performance:

HTTP code: 200
Response time: 3038 ms

Resolved: Mobitopup performance has improved in 936c5e6.


Download: qgis_sample_data.tar.gz is not a gzip, but only a POSIX tar archive

Apart from the wrong file suffix this makes the download needlessly big, so should be fixed.
https://qgis.org/downloads/data/qgis_sample_data.tar.gz

@a17r I've created the tar file (and in my memory I used -z too...)... but you are right, the tar(.gz?) is 39Mb while the zip version (https://qgis.org/downloads/data/qgis_sample_data.zip next to it) is 22Mb.
Gzipped it now... Thanks for pointing out

Thanks for the quick fix!


copying live to archive

Copying all the files from the 2021 live website, prior to the changes for 2022

looking at the changes, it's all whether things are commented out or not, so I'm assuming those are things that need to be set for the /2021 archive and not the main.


Update Request.php

Using isset() in getBodyParams treats null as $defaultValue which is wrong since $defaultValue should be returned only when parameter is missing!

well, null could be interpreted as "not set". we can not change this in 2.0.x as it breaks BC.

@ptheofan could you explain more about why you think this is needed. Show a real case where current behavior causes a problem?


[i1] Remove command line option to enable packed storage

only use #iree_encoding.packed_storage to designate if an i1 tensor is of packed memory layout.
remove iree-experimental-packed-i1-storage command line option.
teach type converters to allow casting into packed tensor types

This is a successor, improving PR to https://github.com/iree-org/iree/pull/19354


Please keep all code lines shorter than 80 chars. (79 chars max.)

Can we close this issue?
Note that flake8, which is run in the Travis build, is checking on that by default. Meant as a help to enforce this policy.


NBT.stringify does not process \n (and possibly other escaped characters) correctly

NBT.stringify({ test: '\n' }) should output '{test:\'\n\'}', not '{test:\'\\n\'}'.

Minecraft does not recognize this NBT as valid.

I'm fairly sure you actually can't have newlines in NBT text. Are you sure there is any valid output?

Yes you can.

Can you show me a detailed example? Minecraft does not seem to accept \n, while \\n is accepted.
This works:

This doesn't:

This NBT is not in a Minecraft command. It's in a string in a JSON file. So \\ represents \.
And as I'm writing this I realize this issue is more complicated that I thought, because it seems escaping needs to be done differently between NBT in a JSON string and NBT in a command.


Move tags to a sub menu flyout

Resolved / Related Issues
Items resolved / related issues by this PR.

Closes #9585

Details of Changes
Add details of changes here.

Moved tags to a standard sub menu flyout
Moved MenuFlyoutItemWithImage to Menus folder
Small refactor of MenuFlyoutHelper

Validation
How did you test these changes?

[x] Built and ran the app

Screenshots (optional)

@yaichenbaum is this better?

It does not need a custom control
Better readability of the checkmark

I liked the previous design, but I think this has better contrast.


chore: Cleaning up code and assets that are not used

Relates to ~

Description

Removes script that was used for migrating the data organization, as it no longer used.
Removes script for converting mrc to zarr and omezarr as it is no longer used
Removes script for converting data between json and yaml that is no longer used
Groups data fetching scripts

fwiw, I'd probably move a bunch of the misc scripts that only get used once in awhile into a utils directory instead of a data_importers directory, basically try to mark them as something we rarely need.


Rotating View appears jagged

Description
Rotating view with border appears to be jagged (confirmed on iOS). No external libraries where used.
Animated.View has jagged edges when being rotated. Does not happen when translated.
Occurs with or without border or shadow being set.

React Native version:
System:     OS: macOS 10.15.2     CPU: (8) x64 Intel(R) Core(TM) i7-4980HQ CPU @ 2.80GHz     Memory: 5.16 GB / 16.00 GB     Shell: 3.2.57 - /bin/bash   Binaries:     Node: 12.14.1 - ~/.nvm/versions/node/v12.14.1/bin/node     Yarn: 1.13.0 - /usr/local/bin/yarn     npm: 6.13.4 - ~/.nvm/versions/node/v12.14.1/bin/npm   SDKs:     iOS SDK:       Platforms: iOS 13.2, DriverKit 19.0, macOS 10.15, tvOS 13.2, watchOS 6.1     Android SDK:       API Levels: 10, 11, 12, 13, 14, 15, 16, 17, 18, 19, 20, 21, 22, 23, 24, 25, 26, 27, 7, 8, 9       Build Tools: 19.1.0, 20.0.0, 21.1.2, 22.0.1, 23.0.1, 23.0.2, 23.0.3, 24.0.0, 24.0.1, 24.0.2, 24.0.3, 25.0.0, 25.0.1, 25.0.2, 25.0.3, 26.0.0, 26.0.1, 26.0.2, 26.0.3, 27.0.0, 27.0.1, 27.0.2, 27.0.3       System Images: a...-tv | Android TV ARM EABI v7a System..., a... | Android TV Intel x86 Atom Syst..., a...ult | ARM EABI v7a, a...-21 | Intel x86 Atom, a... | Intel x86 Atom_64, a...pis | Google APIs ARM EABI v7a Syste..., a...google_apis | Google APIs Intel x86 Atom Sys..., a...gle_apis | Google APIs Intel x86 Atom_64 ..., a...-tv | Android TV ARM EABI v7a System..., a... | Android TV Intel x86 Atom Syst..., a...ear | Android Wear ARM EABI v7a Syst..., a...ndroid-wear | Android Wear Intel x86 Atom Sy..., a...ult | ARM EABI v7a, a...-23 | Intel x86 Atom, a... | Intel x86 Atom_64, a...pis | Google APIs ARM EABI v7a Syste..., a...google_apis | Google APIs Intel x86 Atom Sys..., a...gle_apis | Google APIs Intel x86 Atom_64 ..., a... | Android TV Intel x86 Atom Syst..., a...ndroid-wear | Android Wear Intel x86 Atom Sy..., a...gle_apis | Google APIs Intel x86 Atom_64 ..., a...s_playstore | Google Play Intel x86 Atom Sys..., a... | Android TV Intel x86 Atom Syst..., a...google_apis | Google APIs Intel x86 Atom Sys..., a...s_playstore | Google Play Intel x86 Atom Sys...   IDEs:     Android Studio: 3.0 AI-171.4443003     Xcode: 11.3/11C29 - /usr/bin/xcodebuild   npmPackages:     @react-native-community/cli: 2.9.0 => 2.9.0      react: 16.9.0 => 16.9.0      react-native: 0.61.2 => 0.61.2
Steps To Reproduce
Provide a detailed list of steps that reproduce the issue.

Create an Animated.View
Apply a rotation animation to the animated view

Expected Results
You will see jagged edges on the Animated View

SOLUTION: Simply, add the shouldRasterizeIOS prop to Animated View

@chris9753 Thanks! I've been trying to figure this out for a long time


feat: Watch for custom blocks & components in development

Description
This is a draft PR for a proposed improvement to the twill:dev workflow:

A --copyOnly option is added to the twill:build command

A check to find a project-level install of chokidar-cli is added. If found, a background process is started to trigger twill:build --copyOnly when custom blocks or components are modified. Otherwise, a message is displayed with instructions on how to install the package.

This works for me locally but I'd love to get some feedback to make it more robust.
Would this even be usable on Windows?
Should the chokidar-cli be added to Twill's internal devDependencies instead?

Install instructions:

Watcher started:

Related Issues
Fixes https://github.com/area17/twill/issues/595
Related https://github.com/area17/twill/issues/1014

This is awesome @pboivin, thank you! If we can make this happen without requiring the dependency at the project level, it'd be perfect, but I think it is totally acceptable if not.


99th percentile and worst frame raster time regressed on Pre-Dart SDK roll

See commit https://github.com/flutter/flutter/commit/6a8a73c4fc29616ce4d241e42054f376a086741e and

complex_layout_scroll_perf__timeline_summary 99th_percentile_frame_rasterizer_time_millis
complex_layout_scroll_perf__timeline_summary worst_frame_rasterizer_time_millis
futter_gallery_ios32__transition_perf 99th_percentile_frame_rasterizer_time_millis

This was introduced in https://github.com/flutter/engine/commit/93dac2a88d1695fc9508acabb2e3d4cf5f0429a5 (specifically the change to anti-aliasing)
@liyuqian @GaryQian

Previously, we were not anti-aliasing on all ClipRect, even when the clipBehavior is says it should. After passing the correct anti-aliasing, there is likely a performance hit due to a lot more anti-aliasing being performed where it should have before.

Ah yes, you're correct. doAntiAlias is default to false for SkCanvas::ClipRect

To fix the issue, we'll have to change our default clipBehavior to be hardEdge instead of antiAlias in ClipRect. Gary is on changing that.
This will be a breaking change but most people probably can't tell a visual difference (other than the performance). @Hixie

how will we ensure we don't get ugly clips when the ClipRect is in a transform?

@Hixie We still provide the clipBehavior option to the user. I think most cases doesn't have a perspective/rotated transform so we should default it to hardEdge. If the developer finds the clip ugly, they can always change it to antiAlias.

Fair enough. Please make sure to really clearly document this in the ClipRect widget docs, ideally including sample code and screenshots showing the difference so that people can understand it.

(cc @gspencergoog who may have advice on doing that)

FYI, our ClipRectLayer never had anti-aliased clip (it was https://github.com/flutter/engine/blame/16c56afb09ee1271076e3285be43e83318c328cd/flow/layers/clip_rect_layer.cc#L45 before Gary's change). Nobody seems to have complained. That's probably also why I missed it during the breaking Clip change: everything else was anti-aliased clip while this one was actually non-anti-aliased clip...

Yeah, I can help with the diagrams for the docs if you want.

This bug should have been fixed as https://github.com/flutter/flutter/pull/21703 is merged.

Looks like it's not fixed.


create SubqueryExpressionSegment

Fixes #4582.

Pull Request Test Coverage Report for Build 1993

0 of 82 (0.0%)  changed or added relevant lines in 6 files are covered.
2 unchanged lines in 1 file lost coverage.
Overall coverage decreased (-0.08%) to 59.139%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

shardingsphere-sql-parser/shardingsphere-sql-parser-engine/src/main/java/org/apache/shardingsphere/sql/parser/sql/segment/dml/expr/subquery/SubqueryExpressionSegment.java
0
2
0.0%

shardingsphere-sql-parser/shardingsphere-sql-parser-mysql/src/main/java/org/apache/shardingsphere/sql/parser/visitor/MySQLVisitor.java
0
16
0.0%

shardingsphere-sql-parser/shardingsphere-sql-parser-oracle/src/main/java/org/apache/shardingsphere/sql/parser/visitor/OracleVisitor.java
0
16
0.0%

shardingsphere-sql-parser/shardingsphere-sql-parser-postgresql/src/main/java/org/apache/shardingsphere/sql/parser/visitor/PostgreSQLVisitor.java
0
16
0.0%

shardingsphere-sql-parser/shardingsphere-sql-parser-sql92/src/main/java/org/apache/shardingsphere/sql/parser/visitor/SQL92Visitor.java
0
16
0.0%

shardingsphere-sql-parser/shardingsphere-sql-parser-sqlserver/src/main/java/org/apache/shardingsphere/sql/parser/visitor/SQLServerVisitor.java
0
16
0.0%

Files with Coverage Reduction
New Missed Lines
%

sharding-orchestration/sharding-orchestration-core/src/main/java/org/apache/shardingsphere/orchestration/internal/util/IpUtils.java
2
80.0%

Totals

Change from base Build 10050:
-0.08%

Covered Lines:
12117

Relevant Lines:
20489

💛  - Coveralls

Great


I think the multiple selector will actually cause a similar issue we had with the issue linkification (which I think is still open). In short, review comments in files might have their own code blocks. Those selectors might match them twice.
And no, the rgh- class won't prevent that because the selector picks them all at once and then the class is added inside the loop, at which point it's too late.

These features do share some characteristics, I will try to align the PR for linkify-code and shorten-links with this.

Wow, my 100th commit 🎉 thanks for all these years @fregante!


Create Pull Request ends with 404 HTTP error

Gogs version (or commit ref): <IP_ADDRESS>3 - build from develop branch: commit 491407ddf89fb4182
Git version: <IP_ADDRESS>
Operating system:  CentOS 7
Database (use [x]):

[ ] PostgreSQL
[x] MySQL
[ ] SQLite

Can you reproduce the bug at https://try.gogs.io:

[x] Yes (provide example URL): https://try.gogs.io/TestNETTO/Test/compare/develop...rbukovansky:develop
[ ] No
[ ] Not relevant

Log gist:

I'm trying to create PR from my feature branch to develop branch on org repo, but I'm getting 404 HTTP error. Not sure why. Org repo has master & develop branches, my repo has master, develop and given feature branch.

I confirm this issue on gogs version v0.9.97
Git version: 2.1.4
OS: debian 8.5 64bits
DB: SQLite
creating a fork and trying to compare o create a pull request ends with a 404 HTTP on logs shows this:
[Macaron] 2016-09-06 10:20:06: Started GET /SML/IPN/compare/developer...jacquemc:developer for <IP_ADDRESS>
Sep 06 10:20:06 spiraldev gogs[3492]: 2016/09/06 10:20:06 [D] Session ID: 37f6e9c6e6273fc5
Sep 06 10:20:06 spiraldev gogs[3492]: 2016/09/06 10:20:06 [D] CSRF Token: Ns_rlFpggOTwgX3UVoyzsVbEACM6MTQ3MzE4MjMyNTwerzUzODkwMA==
Sep 06 10:20:07 spiraldev gogs[3492]: 2016/09/06 10:20:07 [...uters/repo/commit.go:230 CompareDiff()] [E] GetCommit: exit status 128 - fatal: ambiguous argument 'jacquemc': unknown revision or path n
Sep 06 10:20:07 spiraldev gogs[3492]: Use '--' to separate paths from revisions, like this:
Sep 06 10:20:07 spiraldev gogs[3492]: 'git  [...] -- [...]'
Sep 06 10:20:07 spiraldev gogs[3492]:
Sep 06 10:20:07 spiraldev gogs[3492]: 2016/09/06 10:20:07 [D] Template: status/404

I am having the same issue. Version is the same as @rbukovansky, <IP_ADDRESS>3, and log is the same as @Jaxmetalmax :
2016/09/27 14:07:59 [...uters/repo/commit.go:230 CompareDiff()] [E] GetCommit: exit status 128 - fatal: ambiguous argument 'prodala': unknown revision or path not in the working tree. Use '--' to separate paths from revisions, like this: 'git <command> [<revision>...] -- [<file>...]'
It appears that when making the PR, if I choose the his feature branch first then choose my upstream development branch, it works just fine.
A thing I noticed is that all his branches work fine when upstream master is selected but only his feature branches in the format of feature/<feature-name> work when upstream development is selected. His branches are master, development, develop, and 2 feature/<feature-name>.
Please advise.

Same issue here, with error as above.
However it seems that if upstream branch is master, then it works just fine. Switching to any other branch makes it drop 404.
Please help, this makes collaboration highly difficult.

OKay so workaround for it for me was:
https://git.3lab.re/mirkots/mirkots-engine/compare/development...marahin:development (returns 404)
https://git.3lab.re/mirkots/mirkots-engine/compare/development...Marahin:development (returns OK)
So basicly capitalizing the first letter of USERNAME. Case insensitivity is bugged.

I also confirm I am receiving this issue as stated above
And I confirm Marahin's solution works when I capitalize the first first character of the word after

OKay so workaround for it for me was:
repo-url/compare/development...marahin:development (returns 404)
repo-urlcompare/development...Marahin:development (returns OK)
So basicly capitalizing the first letter of USERNAME. Case insensitivity is bugged.

That also worked for me, however, it didn't have to be the first letter. Capitalizing any character worked. In my case, a branch with a / in it also worked by default. That may have been a coincidence.

Unfortunately when I create a pull request afterwards, I get a 505 error. Are you getting this as well?

@Unknwon Hi, could you please take a look? Thank you.

@liline yes, not always, but sometimes yes. Even though 505 is returned, pull request is created and PERSISTS, and works just fine. Something is terribly wrong there :)

@Unknwon bump. I believe this is an issue related mainly to MySQL

I tried following steps but couldn't reproduce:

Create a repository under an organization
Fork to my own account
Make some push to my fork
Propose a PR to upstream
Page loads normal

Correct me if I miss something?

@Unknwon just retested on try.gogs.io and the issue seems to be gone. :+1:
Keeping open until I test it on my production Gogs machine.
Thanks.

@Unknwon @rbukovansky I will retest on my production machine as soon as I update it to the bleeding-edge version. Consulting with friends that use GOGS too, however, it would be wise to retest on Ubuntu 12.04 & perhaps on MySQL than on SQLite/PostgreSQL - most issues happen on that particular setup.
Also nginx as reverse proxy.

@Unknwon OK. I new build of Gogs it seems to be gone. Now, could we please get #3604 fixed? Thank you.


Distance Functions (Euclidean+ Notebook)

I added the distance functions to the Notebook + I implemented the Euclidean Distance.
Also, I renamed the arguments in the functions. Previously they were "prediction" and "targets", but I believe the more general "X" and "Y" are better. Especially considering that in some cases the two items compared are technically not a prediction and a target. Like in the k-Nearest Neighbors algorithm, where we are simply calculating the distance between two items.
Note: Since #458 implements tests for the remaining distances, I will wait till that PR is merged before creating a test for the Euclidean Distance.

Adding separate test cases won't cause merge conflicts. You can go ahead and add tests for euclidean distance.

I believe the conflict won't be in the test itself, but in the imports of the file. I will write the tests either way, and I will resolve any conflict afterwards since it's not going to be too much work.
Thanks.


hy3 compatability

any chance for hy3 compatibility?
seems to work great on its own, but it doesn't detect tabbed windows. this plugin would be perfect for my setup otherwise. wish i could try to implement it myself, but im far from being able to understand c or c++ enough to fix this myself

what is that mean that it doesn't detect tabbed windows?

https://github.com/DreamMaoMao/hycov/assets/30348075/e303246e-4262-429c-afb4-cdfd8b4b1ea4
I have no problem when using hy3

BTW I was testing with the latest hy3 release, not hy3-git

what is that mean that it doesn't detect tabbed windows?

As in, when you group windows into tabs the windows that aren't focused are not shown in the preview, and the tabs themselves are left visible, I could make a video later today, but rn I'm off the PC for the rest of the night while I get some sleep

BTW I was testing with the latest hy3 release, not hy3-git

I'm using the stable hyprland build in the extra repos, and using hyprpm to manage my plugins

what is that mean that it doesn't detect tabbed windows?

As in, when you group windows into tabs the windows that aren't focused are not shown in the preview, and the tabs themselves are left visible, I could make a video later today, but rn I'm off the PC for the rest of the night while I get some sleep

Still don't understand what's going on, what is tag?

what is that mean that it doesn't detect tabbed windows?

As in, when you group windows into tabs the windows that aren't focused are not shown in the preview, and the tabs themselves are left visible, I could make a video later today, but rn I'm off the PC for the rest of the night while I get some sleep

Still don't understand what's going on, what is tab?

You can create grups of windows with the hy3:changegroup, toggletab dispatcher in hy3. When making groups it creates tabs for each window in the group, im currently working rn otherwise I'd show you, but you can try it in your hyprland config if you use hy3, I personally bind it to Super+G

emm.. This looks like hy3 implementing a group on its own, But I have no plans to read hy3 code.
so sorry about my helpless.

emm.. This looks like hy3 implementing a group on its own, But I have no plans to read hy3 code.
so sorry about my helpless.

That's ok, I understand. Thanks anyway. Maybe one day I'll learn c and fork this project myself, but in the meantime, this is still a great plugin


What is the purpose of transform_pose_llff()?

Hi, thank you for this work. I am recently starting using NeRF factory. It looks like transform_pose_llff() will inverse the z and y rotation matrix. Why do we need transform_pose_llff() for the llff dataset? I did not see this in load_llff.py from NeRF GitHub.

Sorry for being late.
Our team members were busy for preparing the CVPR submission.
We have integrated our coordinates to OpenCV coordinate.
https://stackoverflow.com/questions/44375149/opencv-to-opengl-coordinate-system-transform
The link above might help your understanding.

Let me know if you have any further questions regarding the coordinate system.

Thanks. That helps a lot. The coordinate system is different between opencv and opengl. Everything makes sense now.

Hello, if the dataset is in MVSNet format and conforms to the opencv coordinate system, is there no need for transform_pose_llff()?


Version by namespace: what to include in each version?

Hi,
I'm implementing versioning by convention (Web API) - I have a folder for each version with its controllers and models (as shown in the sample project with their mappers and resolvers). My question is whether other class types are relevant to version.
In other words, Is it best practice to include in each version also other classes like filters, validation attributes, utilities etc.? These classes can 'break' the existing API when they change.
My intuition tells me that those classes might change but not too often, and in those cases - instead of duplicating these classes per each version - I can just create a new class and delete the old implementation when the older API versions that use it are deleted.
p.s. see more details in the last comment (not replied yet) in [issue 276].(https://github.com/Microsoft/aspnet-api-versioning/issues/276)
Your thoughts are welcome.
Thank you!

Ideally, you'll want constituent components such as these to be version-neutral. The rationale is less about versioning and more about how things map in ASP.NET. Most of these components can be mapped at the global/application, controller, action, and/or parameter level. The global or application level will not have the ability to deal with variations in API version unless you bake it in directly; for example, by querying Request.GetRequestedApiVersion(). If you need version-specific behaviors, you can implement them and apply them at the controller (or below) level as appropriate. In Web API, it is possible to mix global and some sublevel components like filters using overrides, but that can become messy to rationalize about.
A key decision point will be how much effort you want to put into a theoretical future issue. If the issue happens, your early planning is likely to pay off. If it doesn't, you may end up doing a bunch of unnecessary work. Probably the best trade-off is to know how you'll branch behaviors or logic when you need to. Then make sure you have comprehensive test coverage for all of your services. That should largely protect you from regressions while making changes to existing service versions. The use of Consumer-Driven Contracts is a way to help further verify you don't break existing clients. Ultimately, it's a case of pay me now or pay me later and only you know for sure which approach is more economically viable for your scenarios.
If I had the choice, I would likely defer as much of this type of work as possible. Tests to validate and document my APIs are already a must. I would trust in their quality as a means to guard against regressions with future changes.

Between here and #276, I think this has been adequately answered. Feel free to come back for more questions or re-open this issue if there's more to discuss. Thanks!


Replace chalk by picocolors

Replace<EMAIL_ADDRESS>by<EMAIL_ADDRESS>Why

<EMAIL_ADDRESS>depends on ansi-styles and supports-color
chalk add lots of stuff for only 4 calls (green(text), red(text), gray(text), underline(text))
Because you using chalk@4 instead of chalk@5, I wont develop this point.
Stop contributing to the node_modules blackhole paradigm, my 2Tb SSH is almost full :cry:
Reduce CO² Emition, save the :earth_africa:.

Note:

I'm not affiliated with the picocolors project.
I would prefer to use<EMAIL_ADDRESS>rather than<EMAIL_ADDRESS>but that is another discussion.
You can refer to the official readme that explains why picocolors would replace chalk@4, it's a bit different for chalk@5

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Waiting for the completion of https://github.com/denoland/dnt/pull/278

synced with https://github.com/denoland/dnt/pull/278

up


Python extension not working & terminal not loading any environment

Hi I’m trying code-server on my centos7, and I’m having a few problems that I’m not sure are limits of running code-server or rather of my local setup.
I’ve followed this tutorial to install it https://www.digitalocean.com/community/tutorials/how-to-set-up-the-code-server-cloud-ide-platform-on-centos-7
The two problems I’m encountering are (from iOS latest on my iPad):

terminal loads a generic sh but not bash, so is without any environment and many things don’t work properly (git). I tried as well launching bash -l from the terminal, or source .bash_profile, somehow the environment variables are never really loaded

Jupyter extension fails to load Python somehow, although it perfectly works on the machine and the extension can correctly find the interpreter and the right version (attached the error). Once I try to load a notebook and it launches the Python, I see it starts creating many connections to my machine.

I struggled finding a comprehensive guide of all parameters I could possibly use to launch code-server if needed to fix these two problems. Any suggestion or idea? Thanks! :-)

Please use our setup guide instead.
https://github.com/cdr/code-server/blob/master/doc/guide.md
If it still happens let me know and I'll reopen this issue.


Shorthand for Semantic Actions

It would be nice to add shorthand for semantic actions.
Say, instead of writing { return value }, we write, for example { extract } which is defined in the initializer.
For example:
{
  function extract(value) {
    return value;
  }
  function concat(head, tail) {
    return head ? [head].concat(tail) : [];
  }
  function toAddExpr(head, tail) {
    return { type: 'addExpr', expressions: concat(head, tail) };
  }
}

List
  = '(' _ head:Item? tail:( _ ',' _ value:Item { extract } )* _ ')' { concat }

// Another kind of list
Add
  = '(' _ head:Multiply? tail:( _ '+' _ value:Multiply { extract } )* _ ')' { toAddExpr }

First, this will make us able to reuse functions... in a nicer way :smile:
Second, this will make our grammar a bit more readable.
I believe it also will be more useful when the expression contained in the action shorthand is a member expression { foo.bar.baz } instead of just identifier { foo }. So that grammar writers can organize their functions inside of an object or even a module.

Interesting idea, but I personally dont think that would be a clearer way, since it is not obvious which arguments are being passed to the function. Also, if you'd need to pass a "custom" parameter - you'd need to mix those with regular function calls, so it wont look as clean as in the simpler cases.

Someone in #235 suggested the syntax => to go along with arrow functions, which I thought was quite clean and concise.
foo
  = '(' expr:some_expression ')' => expr
  ;

=> expr;

Best in my opinion.

{ => expr }

Conflicts with Javascript syntax IMO. Since it's inside { } you'd expect it to be a full arrow function (() =>).

{ > expr}

A bit orthogonal to any other syntax in either PegJS or Javascript, doesn't immediately read "this returns a value, shorthand" IMO.

Why is the semicolon needed for '=>'? I'd like to return a value in nested code instead of using buildList() for example:
Factor
  = "(" _ head:Expression _ tail:("," _ expr:Expression => expr)* ")" {
      return [head, ...tail]
    }

I find this cleaner than using a magic index (below). Another option is the ability to refer to nested labels. e.g. ("," _ tail:Expression)* ")"
Factor
  = "(" _ head:Expression _ tail:("," _ Expression)* ")" {
      return buildList(head, tail, 2)
    }

I was looking at parser.pegjs, and I see around line 434 there is CodeBlock. What would need to be done to try it out? The rule Code simply reads SourceCharacter, which is just '.'
CodeBlock "code block"
  = "=>" __ @Code // this?
  / "{" @Code "}"

@mikeaustin Yea, that's about right, but there's no way for it to know where to end this sequence then, so will consume evrything after =>

Maybe "Code" could be a little smarter, balancing brackets and braces, and handling LineTerminator? It wouldn't need to know about full JavaScript, but that may be harder than it sounds.

Actually, I have been thinking, these changes might just work:
CodeBlock "code block"
  = "=>" _ expession:CallExpression {
       return `return ${ expession };`;
     }
  / "{" @Code "}"
  / "{" { error("Unbalanced brace."); }

// Will be based on ECMAScript's CallExpression
CallExpression
  = ...
  / MemberExpression

// Will be based on ECMAScript's MemberExpression
MemberExpression
  = ...
  / ValidIdentifier

// Change `LabelIdentifier` into `ValidIdentifier`

This way will still require to integrate some stuff like ECMAScript's primary expressions (numbers, booleans, arrays, etc) to be used as arguments, so will need to carefully figure out what I can add without bloating the PEG.js grammar parser, so probably wont happen till v1.

balancing brackets and braces

This won't be fixed until a proper JavaScript parser is built into the PEG.js parser, but to be honest I'm slightly hesitant about this as there are a few plugin projects that generate parsers in other languages (C, PHP, TypeScript, etc), and I also am working on a computer language that I hope to one day generate parsers in.

Alongside PEG.js v0.12, I will be working on OpenPEG, which will offer an NPM package that is essentially a stripped down version of PEG.js without any JavaScript and parser generation involved, but enough features so that JavaScript-based projects like PEG.js can use it as a backend. When v0.12 comes out I will try and ensure any plugin projects that generate custom parsers are notified of OpenPEG, and before v1 implement a full ECMAScript 2015 parser into the PEG.js grammar parser.

FWIW, I've started using template literals for this. It also helps me with syntax highlighting of JS by my text editor...
exports = module.exports = functionBodies`${grammarScript}
...
objectText =
	head:word
	rest:(_txt_ word)*
	${f=>{
		return new Txt(rest.reduce((a,b)=>([...a,...b]),[head]))
		}}
word = ch:(wordCharacter/escapedCharacter)+ ${chJoin}
...
`
function functionBodies(glue, ...fns){
	return glue.map( (str,i) => str + (fns[i]||'').toString().replace(/^[^{]*/,'').replace(/[^}]*$/, '') ).join('')
	}

function chJoin(ch){return ch.join('')}

How about using the proposed pipe operator (https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Operators/Pipeline_operator)?   There should be no short syntax.
None of this is necessary if we just parse arrows normally, instead of trying to shim them in sideways.
Whereas this is a neat idea, it sets up extensive grammar ambiguities versus JavaScript.
Instead of trying to create fancy new stuff, we should just support Javascript.  Arrow functions are older than ES6 and ES6 is from 2015.  This was solved six years ago.  No invention should happen here.
The pipe operator is badly flawed and probably won't actually make it into Javascript, and the both the language that it originally comes from (F#) and the language that popularized it (Elixir) are backing away from it.  Besides, this isn't piping in any sense.
The reason PEG was so successful was that it was minimal, and stayed close to the language, allowing it to be fast, small, and predictable.

Arrow functions are older than ES6 and ES6 is from 2015. This was solved six years ago. No invention should happen here.

Uh. That's news to me. Care to expand?

The reason PEG was so successful was that it was minimal, and stayed close to the language, allowing it to be fast, small, and predictable.

The reason PEG (as a concept, not this library) is successful is because of its ability to represent complex grammars (recursive, etc.) in a simplistic way. Packrat was not invented with this library; it is not a syntax. It's an algorithm.

Arrow functions are older than ES6 and ES6 is from 2015. This was solved six years ago. No invention should happen here.

Uh. That's news to me. Care to expand?

I don't really know what you're asking.
Arrow functions are older than ES6.  This was the second biggest fight in ES6, is what derailed ES4, and what derailed ES5+.  Everyone had been asking for them, at that point, since the mid-90s, because they did in fact already exist in E4X, and were taken away because Google and Apple threw a fit at Hixie about Microsoft ever inventing anything.
You now know E4X as React, and think Facebook invented it.  Facebook thinks they ripped off Hyperscript.  The Hyperscript guy is clear that he was just reimplementing a useful thing from old IE.
They were going to be left out of ES6 entirely, just like template strings, but then Coffeescript came along and gave the JS community both, and then the JS community yelled until the ECMA folks budged.  Only took 18 months
Arrow functions do everything that needs to happen here.
More importantly to me, if it's done with an arrow function, nothing has been added.
Peg's differences from JS are absolutely minimal.  Supporting this by just doing ES6 stuff means that list doesn't change.
That's extremely valuable.

The reason PEG (as a concept, not this library) is successful is because of its ability to represent complex grammars (recursive, etc.) in a simplistic way.

I don't agree.  Many parsers do a much better job of this, and aren't even slightly popular, even with the people who know about them (like Earley.)
The traditional explanation is a combination of error message quality and speed, but I don't agree with that either, because many parsers have better error messages faster (again, like Earley,) and aren't even slightly popular, even with the people who know about them
Also, note that PEG has three serious complexity ceilings.
One, anything you want to put through a peg grammar has to have a combinatoric expression that doesn't overwhelm the local machine's cache and evaluation throughput (by example #623)
Two, many common jobs, such as parsing BNF, are frequently brutally difficult in peg (by example #489)
Three, it's worth noting that every other JS PEG library, even significantly more powerful ones, have failed.  I tried to switch away, and have come back, many times.  In particular, I've tried to switch to canopy a bunch of times, because it allows me to target c, ruby, and python in addition to javascript
Granted, all I can speak for are the two dozen or so people I know who are using it.  And I can, because I asked a couple days ago, when I realized the new non-maintainer was throwing away the software and replacing it with something he made from scratch, after years of no published changes
But every single one of them said to me either that they need a parser that doesn't have a lot of native conceptual overhead, or that they needed something fast and small whose behavior was reliable
Unreleased 0.11 behaves meaningfully differently in node vs chrome, and node is made of chrome.  Try writing some property tests against it.  It's honestly kind of terrifying.
.

Packrat was not invented with this library; it is not a syntax. It's an algorithm.

I didn't say anything about Packrat, friend.  I'm not sure what you're trying to correct.
Packrat parsing is not, however, an algorithm, for the same reason that sort isn't an algorithm.  Packrat parsing is a task, and there are many ways to go about it.
Indeed, most intro haskell books make you do three or four different packrat parsers, because they're a great way to get really hung up on the performance problems of haskell's approach to monads, and they want to show you how changing the approach to writing packrats (that is, changing the algorithm) yields better results.
.
Please reconsider that thumbs down.  This library has been dead for three years, and I'd like to resurrect it now.
Part of the reason the library is dead is that people keep trying to greenfield invent features, instead of performing simple maintenance, like adding the es() module function that's been sitting in dev for two years
I have to manually modify my PEG parsers by cutting lines and stapling hand-written javascript onto the end of them
The starry eyes should close for a little while, and some practical greasy elbows should start.  PEG's the only major NPM library I've ever seen with declining use.  Given that I'm not aware of a reasonable replacement, that's bizarre and confusing to me.

I have bugfixes that I want to contribute right now, but I can't, because

0.10 hasn't been published since dmajda left,
0.11 is three years old, has never been published, and it was announced a month ago would never be published, and
The replacement, 0.12, isn't peg at all, but something the other guy wrote from scratch in a different programming language, and none of us can see it

I know it's impolite, but we need to face that this library is being killed
It's time to face that we need to accept a normal development process if this library is ever going to see updates again.  It's 2020.  We haven't seen anything since 2017.
No, dev branch doesn't count.  And the new maintainer's gonna have to re-open a whole lot of issues, because 0.11 is not of sufficient quality, and starting over from 10 is a lot less work than fixing 11


Update the sample's README.md and pom.xml to make sure developers use latest SDK package

We have build-tools to make sure each SDK in the repo is built with latest version of dependencies, as collectively decided for this repo. This is done by inserting XML comments like <!-- {x-version-update;com.azure:azure-core;dependency} -->  in the pom.xml that builds the package (with test and samples).
However, I have a separate pom.xml in the samples folder that developers can use to build the samples (and ONLY the samples) against the latest public SDK package. The build-tool does not support an XML comment to auto-update pom.xml with latest public SDK package. Therefore, I added a step in the samples build instructions asking developers to look at the pom.xml and update to SDK version if needed before compiling the samples. Also put a comment in the pom.xml file itself.
Note that we do not plan to have samples in a different repo for Image Analysis. What we have here, is all there will be. Public learn.microsoft pages that discuss Image Analysis will link to the samples here. Therefore, I need to be able to point developers who want to use the SDK to a samples README, with easy instructions on how to build and run simple samples using public SDK package. pom.xml file should already be in the folder. I do not want to ask them to install additional dependencies and compile the whole SDK and test code just to run sample code.  There are a lot of possible failure points if we ask them to do that.

API change check
APIView has identified API level changes in this PR and created following API reviews.
com.azure:azure-ai-vision-imageanalysis


The dark mode button is not toggling in the sign-in and sign-up page[GSSOC'23]

The light and dark mode button is working but it is not toggling , the icon indicates only dark mode , irrespective of it being in light mode .

I will do signup toggle mode functionality work same as sign in page. Could you please assign me this issue under GSSoC'23

Hey..i think similar issue is been assigned..will assign if it was not done!

Hey..i think similar issue is been assigned..will assign if it was not done!

yeah sure , will wait for the reply 🤞

Hey..i think similar issue is been assigned..will assign if it was not done!

Hii @MonalikaPatnaik I again checked it and the issue is still there , Ig I can now be assigned and work on it.

Heyy could u pls check it again..i think it's been fixed now!

Heyy could u pls check it again..i think it's been fixed now!

Umm hi ! I again checked just now on the side , its still the same unfortunately. I am attaching screenshots , where signin page is in lightmode but the icon is stuck on dark mode . Have a look at it @MonalikaPatnaik

Okok pls fix it then!


KSF-88: Data collection bundle - fixed upon developer review.

Can one of the admins verify this patch?


Run Docker in IOS/Android

HI all,
Can we run a docker image in IOS?
Actually, I am working on an offline project using node js and this will be run in mobile using nodejs-mobile(which is a library to run node in mobile). But there is some complication in running it in mobile as one of the dependency of offline db is not working properly in nodejs-mobile.  If I set up a docker image, can I pull it for IOS as well as android and work it as an app.
Thank you

No there's no support currently for iOS or Android


Use TWS for route timing statistics computation

This PR:

Use TimeWindowSegment to compute timings in Individual::Route.
Individual::Route now computes waitDuration assuming the optimal starttime.
Individual::Route now has travelDuration, serviceDuration, waitDuration and totalDuration
Individual::Route now has earliestStart and latestStart
Rename TWS::totalTimeWarp to TWS::timeWarp
Add _ to TWS properties
Make indices in TWS size_t
Add convenient constructor to TWS for single client

[x] Adds and passes relevant tests.
[x] Has well-formatted code and documentation.

Notes:

It is essential that you add a test when making code changes.
This keeps the code coverage level up, and helps ensure the changes work as intended.
When fixing a bug, you must add a test that would produce the bug in the master branch, and then show that it is fixed with the new code.
New code additions must be well formatted. Changes should pass the pre-commit workflow, which you can set up locally using pre-commit.
Docstring additions must render correctly, including escapes and LaTeX.

I don't have much time today, so I cannot review this in full now. But for the route statistics: I think it's very helpful if we do that as start_time() (or similar; is the earliest start time) and slack(). If a user cares about the latest start time they can compute that as start + slack. For users that do not care a fixed start allows us to compute derived values like the end_time(), and e.g. arrival/departure times at clients, which are generally useful to know. Those can then all be shifted to the future by at most slack(), if a user wants.

I'm really not sure about the increase in coupling. Now TWS needs to know about ProblemData(/Client), and Individual::Route about TWS. Would an implementation of start/end and slack computation on top of Individual::Route have been (much) harder?

I'm really not sure about the increase in coupling. Now TWS needs to know about ProblemData(/Client), and Individual::Route about TWS. Would an implementation of start/end and slack computation on top of Individual::Route have been (much) harder?

I can relate to your mixed feelings about TWS depending on Client, although I think it makes the code nicer (constructor just initializes the TWS for a client). As an alternative, since TWS never changes for a Client, how about I add it as a property to Client and we can just use that in LocalSearch etc. rather than the constructor?
For the slack computation, it would not have been much harder, but there are some formulas and I see no point of implementing the slack computation/propagation (which is not difficult but also not trivial) logic twice if we have a nice class for that?

I've added a note about how slack() works to the documentation:

@wouterkool I cannot ask you for review because it's your PR. Do you want to have a look at this again?

Just checked the docs, and those look OK as well!


Will this be kept up to date with Angular2?

Would be interesting what the plans are for keeping TS and Dart in sync from API, bug fixes, ...

From reading some notes from somewhere linked on some subreddit, I have come to believe that there is an AngularDart team, whose job is to keep up to date with Angular.

As per: http://angularjs.blogspot.co.uk/2016/07/a-dedicated-team-for-angulardart.html

Both versions will share the same template syntax and, where appropriate, the same API.

But you'll have the freedom to submit pull requests in the language that you know best, and changes can be made and reviewed without the added burdens of compilation and cross-compatibility to downstream languages.

So I think the goal is to keep them in sync, but there will be some divergence.

I saw that as well, but I guess it would be quite helpful for contributors to know more details. I assume there are many eager to get stuff that already is in TS but not yet in Dart ported, but duplicate work should be avoided.

This feels like another nail in the coffing for 'Dart for the web'. :(

Hi all, thanks for bringing up this issue.
This is not meant to be a definitive answer, but I can answers to the best of my ability:

Angular 2 TS and Dart will be similar, but not the same. As you probably know, lots of patterns that might make sense for one language will make no sense or even conflict with another. We are hoping to maintain the same template syntax and annotations where they make sense, but make no guarantee of 1:1 behavior.

Angular Dart is going to be focusing primarily on a few things, instead of supporting as many features or client targets (e.g. web workers, server, browser, react native). Some are:

Performance (Get as close to possible to that sweet sweet 60FPS)
Code size (Make sure applications are tree-shakeable to the max)
Super easy dev workflow (No complicated dependencies, work out of the box with DDC)

Most of all, we want a clear, concise public API that would make both small developers and enterprise applications very comfortable. Our customers internally will benefit immensely and so will you all.
I hope that is helpful and we should have more updates (including a sync to github) soon.


[Feature Request] cargo tree --blame winapi

I often find myself seeing stuff in the build output (or output from cargo update) that I'm thinking: "That shouldn't be there!".
I then spend quite some time digging through the output of cargo tree to see who pulls that dependency in. Grepping does work with something like cargo tree | grep -B20 winapi, but it might be nice to have a blame mode which just shows the dep paths leading to a given leaf dependency.

cargo tree -p winapi -i
On Thu, Sep 5, 2019 at 5:37 AM Naja Melan<EMAIL_ADDRESS>wrote:

I often find myself seeing stuff in the build output (or output from cargo
update) that I'm thinking: "That shouldn't be there!".
I then spend quite some time digging through the output of cargo tree to
see who pulls that dependency in. Grepping does work with something like grep
-B20 winapi, but it might be nice to have a blame mode which just shows
the dep paths leading to a given leaf dependency.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/sfackler/cargo-tree/issues/77?email_source=notifications&email_token=AALDMUI6TCI4DCWAOYQX5ILQIDHN7A5CNFSM4IT3UWJ2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4HJPKWQA,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AALDMUIRJPVJK72CLDTTLFDQIDHN7ANCNFSM4IT3UWJQ
.

--
Steven Fackler

ok, thanks for pointing that out. I didn't figure that from the usage message.
The results I got where somewhat inconsistent:
$ cargo tree -p winapi -i
error: There are multiple `winapi` packages in your project, and the specification `winapi` is ambiguous.
Please re-run this command with `-p <spec>` where `<spec>` is one of the following:
  winapi:0.2.8
  winapi:0.3.8

$ cargo tree -p winapi:0.2.8 -i
error: package winapi v0.2.8 not found

$ cargo tree -p winapi:0.3.8 -i
winapi v0.3.8
[dev-dependencies]
└── time v0.1.42
    └── chrono v0.4.9
        └── flexi_logger v0.11.5
            [dev-dependencies]
            └── ws_stream_wasm v0.2.1 (/data/doc/code/ws_stream_wasm)

Showing all hits at once rather than returning an error would be more convenient I think.


Fix indenting and results cleanup

Fixes [GHE]/CFGOV/platform/issues/3180
Removals

Removes "rich-text" wrapped paragraphs. Looking at the CSS for this it appears to be for rich text fields in Wagtail so appeared unused in housing counselor.

Changes

Wraps result items in a <ol> to fix indenting.
Fixes issue where result items without a website had a link to "None" for their title (missed in https://github.com/cfpb/cfgov-refresh/pull/4672)
Wraps result item titles in <strong> to bold them.

Testing

Pull this branch down and check housing counselor page. Resize to see mobile and desktop layout.

Screenshots
Before

After

Question for @niqjohnson and @schaferjh should the result items title actually be a link? Since we have a "website" field having the title a link seems mildly confusing to me, and visibly displeasing since there can be a mix of results that have a website and those that don't.
See the below. What if we only had the link on the "Website" field and not the title?
Before:

After:

@anselmbradford yes, the title being a link is a specific request. Please do not undo that.
cc @niqjohnson


Backspace keyboard shortcut working. Editing a cell still behaves normal.

Description of the Pull Request
Enables backspace clearing of the last selected cell.
Issue being fixed:
Fixes #277
Changes proposed:

handler.ts rename to mousehandler.ts
keyhandler.ts added.
paintedGrid now uses a RichMouseHandlerwhich extendsBasicMouseHandler`.
RichMouseHandler overrides onDelete function.

I'm not totally sure why this was happening but having that keybinding overrode the cell editor action on backspace/delete so when you tried to backspace a char in the editor it would clear the whole cell.


Constantly getting missing dep on running on windows

Bug Report
Describe the bug
If I make a MDX file I am getting this wierd missing dep error. I am using the typescript setup
To Reproduce

Install docz on windows
Make a MDX file and run docz

This dependency was not found:

* componentsButtonButton.mdx in ./.docz/app/imports.js

To install it, you can run: npm install --save componentsButtonButton.mdx

https://github.com/javascript-af/ui-lib
It is on the docz branch
Expected behavior
It should bootstrap the site and it should run
Enviroment

OS: Windows 10
Node/npm version: Node 8.11.2

Related to #12

Using bash on windows for noe. I guess PR #31 will close this issue

closing in favour of #12


Does the current license allow a noto emoji to be used as a company logo?

We can't give legal advice.  The standard recommendation would be for you to talk to an attorney.  However it's probably cheaper to find/hire someone to draw a custom version to use as a logo.  Also logos themselves can be trademarked, and I suspect you'd need something a bit less generic.


How does Tesseract OCR fuse results from multiple models?

In the latest Tesseract, the -l option allows for, say, eng+chi_sim. How does Tesseract OCR fuse results from multiple models? Can someone point to the code that does the fusion? Thanks!

저도 궁금했는뎅, please check this :)

doc/combine_tessdata.1.asc
doc/combine_lang_model.1.asc
doc/lstmtraining.1.asc