[upgrading 0.5 to 0.6] ERROR CoreDNSMigration

Failing configurations:

AWS Ubuntu calico
AWS Ubuntu canal
AWS RedHat canal

2020-04-27T12:32:16.8618648Z 12:32:16 INFO cli.engine.ansible.AnsibleCommand - fatal: [ec2-3-248-182-183.eu-west-1.compute.amazonaws.com]: FAILED! => {"attempts": 20, "changed": true, "cmd": "kubeadm upgrade apply -y v1.16.7 --config /etc/kubeadm/kubeadm-config.yml --ignore-preflight-errors=CoreDNSUnsupportedPlugins", "delta": "0:00:00.053159", "end": "2020-04-27 12:32:16.771872", "msg": "non-zero return code", "rc": 2, "start": "2020-04-27 12:32:16.718713", "stderr": "\t[WARNING CoreDNSUnsupportedPlugins]: Get https://<IP_ADDRESS>:6443/api/v1/namespaces/kube-system/configmaps/coredns: dial tcp <IP_ADDRESS>:6443: connect: connection refused\n[preflight] Some fatal errors occurred:\n\t[ERROR CoreDNSMigration]: Get https://<IP_ADDRESS>:6443/api/v1/namespaces/kube-system/configmaps/coredns: dial tcp <IP_ADDRESS>:6443: connect: connection refused\n[preflight] If you know what you are doing, you can make a check non-fatal with --ignore-preflight-errors=...\nTo see the stack trace of this error execute with --v=5 or higher", "stderr_lines": ["\t[WARNING CoreDNSUnsupportedPlugins]: Get https://<IP_ADDRESS>:6443/api/v1/namespaces/kube-system/configmaps/coredns: dial tcp <IP_ADDRESS>:6443: connect: connection refused", "[preflight] Some fatal errors occurred:", "\t[ERROR CoreDNSMigration]: Get https://<IP_ADDRESS>:6443/api/v1/namespaces/kube-system/configmaps/coredns: dial tcp <IP_ADDRESS>:6443: connect: connection refused", "[preflight] If you know what you are doing, you can make a check non-fatal with --ignore-preflight-errors=...", "To see the stack trace of this error execute with --v=5 or higher"], "stdout": "[upgrade/config] Making sure the configuration is correct:\n[preflight] Running pre-flight checks.", "stdout_lines": ["[upgrade/config] Making sure the configuration is correct:", "[preflight] Running pre-flight checks."]}

Cause:
Not enough disk space on master node so pods cannot start.
Disk space usage after upgrade from 0.5.4 to 0.6.0:
/ -> 31GB
/tmp -> 8.2GB
/var/www/html -> 11GB


Python 3 support

Since Python 2 will not be maintained after January 1, 2020, the Wistar code base should be tested in Python 3 and incompatibilities resolved. This will allow users to run Wistar on newer Linux distributions in the future.

"libvirt-python" can not be built as it requires Python 3
This means I can not use it at all. #BlinkingRed
=====
root@wistar:/opt/wistar# source /opt/wistar/bin/activate
(wistar) root@wistar:/opt/wistar# pip install libvirt-python
DEPRECATION: Python 2.7 reached the end of its life on January 1st, 2020. Please upgrade your Python as Python 2.7 is no longer maintained. A future version of pip will drop support for Python 2.7. More details about Python 2 support in pip, can be found at https://pip.pypa.io/en/latest/development/release-process/#python-2-support
Collecting libvirt-python
Using cached libvirt-python-6.1.0.tar.gz (196 kB)
ERROR: Command errored out with exit status 1:
command: /opt/wistar/bin/python -c 'import sys, setuptools, tokenize; sys.argv[0] = '"'"'/tmp/pip-install-tvuTC4/libvirt-python/setup.py'"'"'; file='"'"'/tmp/pip-install-tvuTC4/libvirt-python/setup.py'"'"';f=getattr(tokenize, '"'"'open'"'"', open)(file);code=f.read().replace('"'"'\r\n'"'"', '"'"'\n'"'"');f.close();exec(compile(code, file, '"'"'exec'"'"'))' egg_info --egg-base /tmp/pip-install-tvuTC4/libvirt-python/pip-egg-info
cwd: /tmp/pip-install-tvuTC4/libvirt-python/
Complete output (1 lines):
libvirt-python requires Python 3.x to build
----------------------------------------
ERROR: Command errored out with exit status 1: python setup.py egg_info Check the logs for full command output.


Player can´t defend an arrow of a NPC with a shield

Hello. Nice Plugin, the most things work fine. I have one problem: I equiped an sentinel NPC with a bow and arrows. If he shoot to a player, the player can´t defense it with his shield like normaly. An armor doesn´t have the normal function against these arrows too. An armor reduce the damage of an sentinel with sword but not with a bow. The problem with armor ist not so important but in a fight you must can defend arrows with a shield...
enforce damage in config is false

Do you have an Idea what it could be?
If found the methods tryAttack for bow and the getdamage, but where do you define the damage for the attack with bow? Didnt found it in the tryAttack.

Lines 248+ (whenAttacksAreHappening) control relevant logic.
It has to set damage manually via that event, rather than there being an option to set the damage of an arrow for some reason. Because of that, it makes sense for it to not properly account for all blocking and damage modifying effects :/ Probably the best way to make it work would realistically just be to replicate the shield logic or something... which is awkward

Ok. I have the problem, that i cannot handle your project. When I want to export it, I get only errors... Do you think, u could make a version, where the shields block the arrows?

I´m a beginner in bukkit coding, but I think it´s not so difficult it looks like. You modify the DamageModifier.BASE while checking DamageModifier.ARMOR. Now you have to modify the damage while checking DamageModifier.BLOCKING, DamageModifier.ABSORPTION and DamageModifier.RESISTANCE, too. All the Damageparameters are in these DamageModifers, the Base value also. So I think you have only to add up all Modifiers.
The normal damageeveentlogic seems to be:
HashMap<DamageModifier, Double> MODIFIERS = new HashMap<DamageModifier, Double>();

public final double getFinalDamage() {
	double damage = 0.0D;
	for (DamageModifier modifier : MODIFIERS) {
		damage += getDamage(modifier);
	}
	return damage;
}

To fill the MODIFIERS I would use:
for (DamageModifier modifier : EntityDamageEvent.DamageModifier.values()){
    	MODIFIERS.put(modifier, event.getDamage(modifier));
}

Does it help?

You wrote:
for (DamageModifier modifier : EntityDamageEvent.DamageModifier.values()){
    	MODIFIERS.put(modifier, event.getDamage(modifier));
}

that's useless code (in a literal sense): It takes the damage and sets the damage to the damage.
It literally changes nothing. No effect is resultant.
Also, the SentinelTrait code that deals with armor values is for objects striking the NPC.
The code that handles arrows impacting players does not deal with any damage other base.
Which, in theory, is sufficient: any and all other damage modifiers still have their original values.
I'm going to debug/test an idea I have from that, though, which is to multiply the other damage modifier values by the relative damage scaling. Perhaps the other damage modifiers are still present, but are too weak compared to how the the Sentinel modifies base damage? Or something like that...

Yup, my idea worked nicely. It's been added to build 102, tell me how it goes!

First Test works fine. Blocking is correct and now the player-armor against arrows is correct, too. We will test it more on our server, but it looks very good until now. Thanks a lot :)


Add request handlers to AWS clients

Type: Feature
Description
Currently it's impossible to customize clients created by AmazonWebserviceClientFactoryBean, specifically by adding RequestHandler2 (for example tracing instrumentation handler).
Solution
The class should accept a list of request handlers and add them before building the client.
Alternatives
At the very least, I'd like to have access to the builder before calling the factory calls builder.build() (e.g. overrider the createInstance method's behavior.).
Additional context
If you wish to accept this, I'd be happy to send a PR.

@akefirad that's a very good idea. Lets keep it for 3.0 version, where we are based on AWS SDK v2.

I think we can close this one since it is supported by AwsClientCustomizer


Stop logging exceptions from UKCP API

:tada: This PR is included in version 5.4.1 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


fix: fix ios reload by observing RCT module invalidate

What
Resolves IOS crash on reload

Changes
Store reference to viewTag
Clear CameraView.frameProcessorCallback on RCTBridgeDidInvalidateModulesNotification
Tested on
iPad Pro 2017
Related issues
Fixes https://github.com/mrousavy/react-native-vision-camera/issues/1360
Inspired by
https://github.com/software-mansion/react-native-reanimated/pull/3932
Note that this fix isn't perfect:

There is no further cleanup being done
There is definitively a memory leak

However despite this it should improve things considerably (Until v3), I was able to get around 15 reloads with no memory issues.

Hey thanks for your Pr this is really interesting!


msal node test app and electron 17

Core Library
MSAL Node (@azure/msal-node)
Core Library Version
1.70
Wrapper Library
MSAL Node Extensions (@azure/msal-node-extensions)
Wrapper Library Version
1.70
Description
When taking the electron sample and updating electron to 17.2.0 I am getting the follow error when logging in and trying to open emails.
Error Message
E:\MICROSOFT_WORK\microsoft-authentication-library-for-js\samples\msal-node-samples\ElectronTestApp>npm start

<EMAIL_ADDRESS>start E:\MICROSOFT_WORK\microsoft-authentication-library-for-js\samples\msal-node-samples\ElectronTestApp
npm run build && electron dist/app.js

<EMAIL_ADDRESS>build E:\MICROSOFT_WORK\microsoft-authentication-library-for-js\samples\msal-node-samples\ElectronTestApp
tsc

[Fri, 25 Mar 2022 21:34:43 GMT]<EMAIL_ADDRESS>: Info - getTokenCache called
[Fri, 25 Mar 2022 21:34:48 GMT]<EMAIL_ADDRESS>: Info - getAuthCodeUrl called
[Fri, 25 Mar 2022 21:34:48 GMT]<EMAIL_ADDRESS>: Verbose - initializeRequestScopes called
[Fri, 25 Mar 2022 21:34:48 GMT] : [84fb7100-2d07-4ac1-a864-1f1d620e11a3]<EMAIL_ADDRESS>: Verbose - buildOauthClientConfiguration called
[Fri, 25 Mar 2022 21:34:48 GMT] : [84fb7100-2d07-4ac1-a864-1f1d620e11a3]<EMAIL_ADDRESS>: Verbose - building oauth client configuration with the authority: https://login.microsoftonline.com/08416161-211e-4d03-a6f5-4e12360d74c3
[Fri, 25 Mar 2022 21:34:48 GMT] : [84fb7100-2d07-4ac1-a864-1f1d620e11a3]<EMAIL_ADDRESS>: Verbose - createAuthority called
[Fri, 25 Mar 2022 21:34:49 GMT] : [84fb7100-2d07-4ac1-a864-1f1d620e11a3]<EMAIL_ADDRESS>: Verbose - Auth code client created
[Fri, 25 Mar 2022 21:34:50 GMT]<EMAIL_ADDRESS>: Info - acquireTokenByCode called
[Fri, 25 Mar 2022 21:34:50 GMT]<EMAIL_ADDRESS>: Verbose - initializeRequestScopes called
[Fri, 25 Mar 2022 21:34:50 GMT] : [7365176d-273a-4c60-882b-11cee9b4d959]<EMAIL_ADDRESS>: Verbose - buildOauthClientConfiguration called
[Fri, 25 Mar 2022 21:34:50 GMT] : [7365176d-273a-4c60-882b-11cee9b4d959]<EMAIL_ADDRESS>: Verbose - building oauth client configuration with the authority: https://login.microsoftonline.com/08416161-211e-4d03-a6f5-4e12360d74c3
[Fri, 25 Mar 2022 21:34:50 GMT] : [7365176d-273a-4c60-882b-11cee9b4d959]<EMAIL_ADDRESS>: Verbose - createAuthority called
[Fri, 25 Mar 2022 21:34:50 GMT] : [7365176d-273a-4c60-882b-11cee9b4d959]<EMAIL_ADDRESS>: Verbose - Auth code client created
[Fri, 25 Mar 2022 21:34:50 GMT] : [7365176d-273a-4c60-882b-11cee9b4d959]<EMAIL_ADDRESS>: Info - in acquireToken call
(node:163884) electron: Failed to load URL: msal://redirect/?code=<TOKEN_REDACTED>&session_state=165060c1-98e2-488d-b31a-40d0501c4e72 with error: ERR_FILE_NOT_FOUND
(Use electron --trace-warnings ... to show where the warning was created)
[Fri, 25 Mar 2022 21:34:50 GMT] : [7365176d-273a-4c60-882b-11cee9b4d959]<EMAIL_ADDRESS>: Verbose - Persistence enabled, calling beforeCacheAccess
[Fri, 25 Mar 2022 21:34:50 GMT] : [7365176d-273a-4c60-882b-11cee9b4d959]<EMAIL_ADDRESS>: Verbose - Persistence enabled, calling afterCacheAccess
[Fri, 25 Mar 2022 21:34:55 GMT]<EMAIL_ADDRESS>: Verbose - initializeRequestScopes called
[Fri, 25 Mar 2022 21:34:55 GMT] : [c0d494d7-a0f5-4d8e-944b-4bd117d97410]<EMAIL_ADDRESS>: Verbose - buildOauthClientConfiguration called
[Fri, 25 Mar 2022 21:34:55 GMT] : [c0d494d7-a0f5-4d8e-944b-4bd117d97410]<EMAIL_ADDRESS>: Verbose - building oauth client configuration with the authority: https://login.microsoftonline.com/08416161-211e-4d03-a6f5-4e12360d74c3
[Fri, 25 Mar 2022 21:34:55 GMT] : [c0d494d7-a0f5-4d8e-944b-4bd117d97410]<EMAIL_ADDRESS>: Verbose - createAuthority called
[Fri, 25 Mar 2022 21:34:55 GMT] : [c0d494d7-a0f5-4d8e-944b-4bd117d97410]<EMAIL_ADDRESS>: Verbose - Silent flow client created
Request made at: Fri Mar 25 2022 14:34:55 GMT-0700 (Pacific Daylight Time)
(node:163884) UnhandledPromiseRejectionWarning: Error: Request failed with status code 401
at createError (E:\MICROSOFT_WORK\microsoft-authentication-library-for-js\samples\msal-node-samples\ElectronTestApp\node_modules\axios\lib\core\createError.js:16:15)
at settle (E:\MICROSOFT_WORK\microsoft-authentication-library-for-js\samples\msal-node-samples\ElectronTestApp\node_modules\axios\lib\core\settle.js:17:12)
at IncomingMessage.handleStreamEnd (E:\MICROSOFT_WORK\microsoft-authentication-library-for-js\samples\msal-node-samples\ElectronTestApp\node_modules\axios\lib\adapters\http.js:269:11)
at IncomingMessage.emit (node:events:402:35)
at endReadableNT (node:internal/streams/readable:1343:12)
at processTicksAndRejections (node:internal/process/task_queues:83:21)
(node:163884) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). To terminate the node process on unhandled promise rejection, use the CLI flag --unhandled-rejections=strict (see https://nodejs.org/api/cli.html#cli_unhandled_rejections_mode). (rejection id: 2)
Msal Logs
No response
MSAL Configuration
{
    "authOptions":
        {
            "clientId": "904df931-49c6-404f-ad6c-4fd84a25d1bb",
            "authority": "https://login.microsoftonline.com/08416161-211e-4d03-a6f5-4e12360d74c3"
        },
    "request":
    {
        "authCodeUrlParameters": {
            "scopes": ["user.read"],
            "redirectUri": "msal://redirect"
        },
        "authCodeRequest": {
            "redirectUri": "msal://redirect",
            "scopes": ["User.Read"]
        }
    },
    "resourceApi":
    {
        "endpoint": "https://graph.microsoft-ppe.com/v1.0/me"
    },
    "fileProtocol":
    {
        "name": "msal"
    }
}

Relevant Code Snippets
updating the test msal node app to use electron 17.2.0. only two files were touched.

in createMainWindow in Main.ts I added
contextIsolation: false to the webpreferences.

in package.json I changed electron to
    "electron": "^17.2.0",

Reproduction Steps
Clone the msal repo.
change electron to 17.2.0 in package.json
change contextIsolation to false in CreateMainWindow from the file Main.ts(electron set this default to true after v10)
npm start
login
attempt to open email
Expected Behavior
error is not thrown and access is allowed.
Identity Provider
Azure AD / MSA
Browsers Affected (Select all that apply)
None (Server)
Regression
No response
Source
Internal (Microsoft)

@salman90 Can you please check this?

@hectormmg

@salman90  @hectormmg Is this version not supported?

@jeffj6123 although Electron technically isn't officially supported by MSAL Node yet, we expect MSAL Node still works for the newer versions of Electron. In this case the sample is just outdated, I'm working on an update and will update this issue when we have an up-to-date working version. Thanks!

@jeffj6123

Request made at: Fri Mar 25 2022 14:34:55 GMT-0700 (Pacific Daylight Time)
(node:163884) UnhandledPromiseRejectionWarning: Error: Request failed with status code 401
at createError (E:\MICROSOFT_WORK\microsoft-authentication-library-for-js\samples\msal-node-samples\ElectronTestApp\node_modules\axios\lib\core\createError.js:16:15)
at settle (E:\MICROSOFT_WORK\microsoft-authentication-library-for-js\samples\msal-node-samples\ElectronTestApp\node_modules\axios\lib\core\settle.js:17:12)
at IncomingMessage.handleStreamEnd (E:\MICROSOFT_WORK\microsoft-authentication-library-for-js\samples\msal-node-samples\ElectronTestApp\node_modules\axios\lib\adapters\http.js:269:11)
at IncomingMessage.emit (node:events:402:35)
at endReadableNT (node:internal/streams/readable:1343:12)
at processTicksAndRejections (node:internal/process/task_queues:83:21)

I can see from your last error message that the problem is actually not an MSAL issue, but you're getting a 401 (Unauthorized) error when you make the graph request. Could you check if the token is being added to the request correctly? We're still updating the sample but if your issue is related to user permissions, you may need to sort that out.

@hectormmg can this part be ignored then?
[Fri, 25 Mar 2022 21:34:50 GMT] : [7365176d-273a-4c60-882b-11cee9b4d959]<EMAIL_ADDRESS>: Info - in acquireToken call
(node:163884) electron: Failed to load URL: msal://redirect/?code=<TOKEN_REDACTED>&session_state=165060c1-98e2-488d-b31a-40d0501c4e72 with error: ERR_FILE_NOT_FOUND
(Use electron --trace-warnings ... to show where the warning was created)

@jeffj6123 I believe so. The error comes from the auth window trying to load the URL when it is changed after the redirect. This isn't a URL meant to be navigated to, we just need to extract the auth code from it through the custom file protocol's listener. If you can confirm that the auth code is being extracted by the Custom file protocol listener and then that code is being successfully exchanged for an access token, you can ignore this error.
I'm looking at ways for preventing the auth window from attempting to navigate (or load the file in this case) so this error isn't shown on the console.
Did you get a chance to confirm there's no permission issue based on the 401?

@jeffj6123 I believe this will be fixed by #4684, @hectormmg please confirm.

@jasonnutter there's two separate problems related to this issue, here's a summary:

The 401 when calling the /messages graph endpoint

It turns out that the /messages endpoint is disabled for @microsoft accounts, which is why this error comes up in any/all of our samples that use /messages (Mail.Read).

The "could not load URL" error that happens after the auth code redirect is actually the result of using a file protocol to read the auth code. The protocol's last default action is to attempt to load the file from that address on disk, which doesn't exist, causing the warning even if the auth code was successfully obtained. Switching to the string protocol fixes this.

So yes, #4684 will resolve this issue.


ProcessList should be hashmap

Currently, ProcessList is a list which raises two issues:

There can be multiple processes with the same processID
Getting process from process list is linear time lookup, while with the hashmap it would be constant time.

It should be called ProcessRegistry

Will not be implemented, details:
https://github.com/Dewberry/process-api/blob/17872925f89046bf31677f0df0794ba235f09af1/api/processes/processes.go#L148


Only save when there are project model changes

Problem:
The saving logic for the editor's model is far too sensitive to changes, meaning we are currently saving the project on mouseup events even if there was no change to the actual project.
Fix:
The actual change of interest here is in dispatch.tsx, and is the introduction of the function editorChangesShouldTriggerSave which will check if the project contents, branch contents, or github settings have changed as a result of a given action.
The rest of the changes are around testing that. Without a way to test all possible actions in a way that wouldn't require duplicating the logic in the test for every combination, the solution I've gone with here is to hijack the existing expectNUndoSteps (and its variants) to create expectNUndoStepsNSaves. We now track the total number of saves that have occurred during a given session in the EditorState by replacing the previously existing alreadySaved boolean property with a saveCountThisSession number.

As a user, what should my expectation be when this PR is merged? And should I manually test some things like the "are you sure you want to leave this page" dialogue still firing correctly  (I'm assuming we don't have automated test coverage for that)?


GH-40544: [Dev] Use pre-commit for cmake-format

Rationale for this change
We can maintain cmake-format related configuration by just listing target files and excluded files in YAML instead of writing not only listing paths but also extra codes in Python by using pre-commit.
What changes are included in this PR?
Add cmake-format related pre-commit configuration and remove cmake-format related code from Archery.
Are these changes tested?
Yes.
Are there any user-facing changes?
No.

GitHub Issue: #40544

Hmm, does this mean I have to install and run an additional tool to properly format CMake changes? The selling point of archery lint is that it handles everything by itself.

does this mean I have to install and run an additional tool to properly format CMake changes?

Yes. You need to install pre-commit by conda install -c conda-forge pre-commit/pip install pre-commit/sudo apt install -y pre-commit (Ubuntu 22.04+) and run pre-commit run -a instead of archery lint. Note that you don't need to install cmake_format separately like pip install -e 'dev/archery[lint]'.

The selling point of archery lint is that it handles everything by itself.

This means that archery lint runs all lints (cmake_format, clang-format and so on), right?
pre-commit run -a also does it eventually. I'll open PRs for it. For example, I'll add configurations of clang-format for cpp/ and python/ to .pre-commit-config.yaml like existing configuration of c_glib/: https://github.com/apache/arrow/blob/eecd7797f1d789551fbb000a93504182c47b6baa/.pre-commit-config.yaml#L55-L61
If you don't like removing cmake_format related codes from Archery before pre-commit run -a can replace archery lint entirely, I'll remove Archery related changes from this PR.

If you don't like removing cmake_format related codes from Archery before pre-commit run -a can replace archery lint entirely, I'll remove Archery related changes from this PR.

Please do. It would be annoying to have to use two different commands for linting.

OK. I've reverted Archery changes.

+1
It's executed:
https://github.com/apache/arrow/actions/runs/8306057631/job/22733676937?pr=40545#step:6:17
CMake Format.............................................................Passed


U/lal/hackurdc2 the movie

The following represent a LAL team contribution to the HackUrDC2 challenge

Our preliminary work was to provide to DESC collaborators some simplified ways to use Spark at NERSC: desc-spark. This culminated with the desc-pyspark kernel we built/installed for jupyter users. Note that jupyter-dev is currently limited to 4 threads/users and does not pay tribute (yet) to the full Spark power. Once more data will be available this will become more and more clear...

as an illustration, we wanted to have a look at DC2 3D catalogs since we believe that the eye is a powerful tool to reveal issues but also because it looks so nice and want to train people using Spark. To this purpose we first needed to export the data to a format easily readable by Spark and we choose the "parquet" one. The script for exporting some relevant quantities can be found here.

thanks to the desc-pyspark kernel, we can then have a 3D look at the latest extragalactic CosmoDC2 catalog: the following notebook shows how, and can be view as the "making of" our great CosmoDC2 movie.

Finally we did import the data to our local cluster and used some sophisticated visualization tools (https://gbarrand.github.io) that we plugged into Spark. We plan to make these tools available to the Collaboration in the next year.

The final movie we made to illustrate the display of the catalog is at the end of the
Notebook (see also https://www.youtube.com/watch?v=HC_CQA5cOag) : it
tries to capture the overall "feeling" but we are (clearly) not filmakers. We
also provide a high resolution picture that can be incorporated more
easily within a presentation.
Stephane for the
Spark/LAL team (C. Arnault, G. Barrand, J.E Campagne, J. Peloton, S. Plaszczynski)
On the Spark training side, we also produced the following notebooks that may help people start with:
Accessing the data

object_spark_1_intro
object_catalog_performance_spark

Playing with the data

footprint_Run12p_spark
Colors_Run12p_spark
Number_density_Run1.2
hackurdc2_spark_halos

@plaszczy @JulienPeloton - we are looking to merge the HackurDC2-related PRs in the coming days. Might you be available to address the review comments from Jim by ~early next week? Hopefully they can be done with quite minor modifications.
Thanks!

@rmandelb we are finishing a paper by tomororow. early next week should be ok.

Great, thank you!

Hi @jchiang87 @reneehlozek
thanks for the review, should be clearer for newcommers now

add some intrcduction about spark to put in perspective + usefull docs (as on sql functions)
we actually  wrote another notebook for our paper, so added ref to it
-comment ton the imes observed
-add your comparison with hist: good idea to make feel what distributed computing is

best

Hi @plaszczy,
Thanks a lot for the changes and for providing this helpful illustration of using these tools.  Everything looks good to me.

Thanks @jchiang87 !
One thing I just noticed, which I previously overlooked: this notebook is in tutorials/, not contributed/.  For tutorials/ we have some additional requests to make sure the tutorials are pedagogically useful (the tasks for submitting tutorials are outlined in this README - e.g., the tutorials need to be added to the master list, and there should be some learning objectives outlined at the top).  We've also generally held them to a different review standard.  So @plaszczy , I think there are two ways forward:

You can move the notebook to contributed/, clear the outputs (which we are doing for all notebooks before merging to master, whether they are in contributed/ or tutorials/), and then we merge.
You can do the additional steps to keep this in tutorials/, clear the outputs, and then we merge.

What's your preference?  It is your choice.  And it's a very useful notebook regardless of where it lives.

we already have some notebook about spark in tutorials. Probably it would worth updating the header with this one (and add a link to it). I moved this one  to contributed.

Great!  Once you clear the notebook outputs, we can merge.  :)  Thanks!

OK done


Crunching pokemon results in an error

When trying to put pokemon into the shredder, this error occures:
<IP_ADDRESS> - - [24/Jul/2016 01:49:30] "OPTIONS /api/pokemon/delete HTTP/1.1" 200 -
Argument pokemon_id with value<PHONE_NUMBER>563474000 unknown inside ReleasePokemonMessage (Exception: 'int' object has no attribute 'append')
Argument pokemon_id with value<PHONE_NUMBER>4228714000 unknown inside ReleasePokemonMessage (Exception: 'int' object has no attribute 'append')

fixed


Sunburst Labels show inside it's Area

What problem does this feature solve?
I've working on implementing an sunburst chart.But, there is an issue what is labels are overlapping with it's neighbours.So, Is there any possibilities to get the labels within it's area by wrapper or circular labels.
What does the proposed API look like?

I've working on implementing an sunburst chart. But, there is an issue what is labels are overlapping with it's neighbours.

Did you forget to include your code?
see examples
see hideOverlap


operator cryostat-operator (2.2.1)

Thanks submitting your Operator. Please check below list before you create your Pull Request.
New Submissions

[ ] Are you familiar with our contribution guidelines?
[ ] Have you packaged and deployed your Operator for Operator Framework?

[ ] Have you tested your Operator in all supported installation modes?
[ ] Have you considered whether you want use semantic versioning order?
[ ] Is your submission signed?
[ ] Is operator icon set?

Updates to existing Operators

[ ] Did you create a ci.yaml file according to the update instructions?
[ ] Is your new CSV pointing to the previous version with the replaces property if you chose replaces-mode via the updateGraph property in ci.yaml?
[ ] Is your new CSV referenced in the appropriate channel defined in the package.yaml or annotations.yaml ?
[ ] Have you tested an update to your Operator when deployed via OLM?
[ ] Is your submission signed?

Your submission should not

[ ] Modify more than one operator
[ ] Modify an Operator you don't own
[ ] Rename an operator - please remove and add with a different name instead
[ ] Modify any files outside the above mentioned folders
[ ] Contain more than one commit. Please squash your commits.

Operator Description must contain (in order)

[ ] Description about the managed Application and where to find more information
[ ] Features and capabilities of your Operator and how to use it
[ ] Any manual steps about potential pre-requisites for using your Operator

Operator Metadata should contain

[ ] Human readable name and 1-liner description about your Operator
[ ] Valid category name1
[ ] One of the pre-defined capability levels2
[ ] Links to the maintainer, source code and documentation
[ ] Example templates for all Custom Resource Definitions intended to be used
[ ] A quadratic logo

Remember that you can preview your CSV here.
--
1 If you feel your Operator does not fit any of the pre-defined categories, file an issue against this repo and explain your need
2 For more information see here

/merge possible

/merge possible


FedoraEvent now mints internal UUID for downstream use (FCREPO-1507)

Reversing kernel/mint dependency so FedoraEvent can use UUIDPathMinter to mint IDs.
First step in https://jira.duraspace.org/browse/FCREPO-1507

Resolved with: https://github.com/fcrepo4/fcrepo4/commit/75916010e5dfbdc74e4e415837e3366babbbc834


*: support multiple sources replication for mariadb

leave canal still only support single source replication

@WangXiangUSTC @siddontang PTAL

LGTM

ping @siddontang

please add test for it.

@siddontang test was added, PTAL


Function usbd_ep_ctrl_set_zlp() works incorrect for devices with MPS != 64

Describe the bug
For devices that have EP0 MPS < 64 function usbd_ep_ctrl_set_zlp() will not
set zlp bit when all data was already sent and ZLP is required by host.
static void usbd_ep_ctrl_set_zlp(struct usbd_context *const uds_ctx,
				 struct net_buf *const buf)
   ...
	if (setup->wLength > min_len && !(min_len % USB_CONTROL_EP_MPS)) { // !! Offending line

Definition of USB_CONTROL_EP_MPS is hardcoded this way
#define USB_CONTROL_EP_MPS		64U

This was discovered during implementation #79184 of UDC driver for Smartbond #74662 .
Sample samples/subsys/usb/mass that triggers error since it generates 32 bytes long
descriptor.
It can also be triggered if other descriptors (like string descriptors) have length 8 * n.
I think it can be also tested on other boards if MPS is artificially change to be 8 (this scenario was
tested on previous USB stack on STM32 devices that are capable to be configured
with EP0 MPS < 64.

To Reproduce

west build -b da1469x_dk_pro samples/subsys/usb/mass -DEXTRA_DTC_OVERLAY_FILE="ramdisk.overlay" -DCONFIG_APP_MSC_STORAGE_RAM=y -DCONF_FILE="usbd_next_prj.conf"

Impact

Devices with EP0 MPS < 64 will not work (This applies to Smartbond and some other device)
Environment:

OS: any
Commit SHA or Version used: 2815b6d710ad9c7ba25725ae34c402fc9153c427

Just a note that this issue is a blocker for #74662

Do not panic, the fix is underway.


Comments: Create a Cognito User Pool

Link to chapter - http://serverless-stack.com/chapters/create-a-cognito-user-pool.html

"App" on the left menu has changed to "App clients"

@wilsonmar Thanks, will update it.

@wilsonmar Updated - 8185cefd8f1269b443898eff6f5453c8aaa41b94. Thanks for the feedback.

Question: Update tutorial to use Serverless to setup Cognito?
Like how it's done here?
😄

@jonsaw I see what they are doing but I'm not entirely clear on how we should use it in the tutorial. Could you elaborate a bit?

Cognito was moved from Mobile Services to Security.

@fcostarodrigo Thanks. Updated it.

This issue was moved to https://discourse.serverless-stack.com/t/comments-create-a-cognito-user-pool/91

This issue was moved to https://discourse.serverless-stack.com/t/comments-create-a-cognito-user-pool/148


fix: correct spelling miss takes

Well the IDE I wrote this in did not have a spell check extension installed. 🙉


comment in first line

hi,
line number 1 in node-uuid/bin/uuid
gives my compiler the error:

SyntaxError: Unexpected character '#' (1:0)

so maybe you can change it
from:
#!/usr/bin/env node
to:
// /usr/bin/env node
because it's not valid comment in js file as you know.

It's the shebang, and is standard practice.  See https://stackoverflow.com/questions/20638520/appropriate-hashbang-for-node-js-scripts/28646724#28646724
If you're getting a syntax error, there's something wrong in your node setup.  The node interpreter has been shebang-aware since at least v0.12.


Bug in Partner Organization

[x] Organisation identifier in partner organization suggests that special character isn't accepted.

IMAGE

This issue has been solved.


Error "sage.all_cmdline import *"

Hi, I first want to congratulate you for your work and contribution. For study purposes I implemented in Linux lll-VirtualBox 5.4.0-74-generic #83~18.04.1-Ubuntu SMP Tue May 11 16:01:00 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
It turns out that the first script normally generates the csv containing data.
But the second attack script returns the error below:
lll@lll-VirtualBox:~/BreakingECDSAwithLLL$  python3 crack_weak_ECDSA_nonces_with_LLL.py nonces.csv 176 6 | grep -e 9ec4bc49e828d924af1d1029cacf709431abbde46d59554b62bc270e3b29c4b1
Traceback (most recent call last):
File "crack_weak_ECDSA_nonces_with_LLL.py", line 11, in
from sage.all_cmdline import *
ModuleNotFoundError: No module named 'sage'
Do you have any idea what might be happening and how to solve it? Thanks

It seems that sagemath is not properly installed in your system.


Do not allow alter column commands.

Just want to see how many tests will fail
What changes were proposed in this pull request?
(Please fill in changes proposed in this fix)
How was this patch tested?
(Please explain how this patch was tested. E.g. unit tests, integration tests, manual tests)
(If this patch involves UI changes, please attach a screenshot; otherwise, remove this)

Test build #55645 has started for PR 12332 at commit 1508c33.

Test build #55645 has finished for PR 12332 at commit 1508c33.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/55645/
Test FAILed.

@yhuai, is this pr still actively used for testing purposes? would you mind closing it if not, thx

ok. I am closing it. I will submit a new PR later once I update it.


Upgrade to node 16 + @actions/core to 1.10.0

These updates will prevent GitHub warnings about the deprecation of Node 12 (in favor of Node 16) and also about the deprecation of the set-output command, which earlier versions of @actions/core used.
For more information:
https://github.blog/changelog/2022-09-22-github-actions-all-actions-will-begin-running-on-node16-instead-of-node12/
https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

Thanks

Thanks

No problem. Can you create a 1.1.1 release to include these changes?

Done


SEP-31: make sure we get the amount_in from GET /transactions before …

What
Make sure we get the amount_in from GET /transactions before sending the stellar payment.
Why
To be consistent with https://github.com/stellar/stellar-protocol/pull/1203.

Preview is available here:http://stellar-demo-wallet-client-pr275.previews.kube001.services.stellar-ops.com/

Thank you for your review.
I'm converting this to draft for now while the SEP change https://github.com/stellar/stellar-protocol/pull/1199 is not complete.

Preview is available here:http://stellar-demo-wallet-client-pr275.previews.kube001.services.stellar-ops.com/


collectors: add other collectors (needrestart, debsecan, logcount, apt)

Hi, I'd like to add these new plugins to the list of community-maintained collectors.
As these are maintained in separate repositories, I added an Other collectors section to collectors/README.md.
I have used the needrestart, debsecan and logcount plugins in production for years with good results.

The main point of the needrestart plugin is to raise an alarm when a reboot is necessary to apply a kernel update, or restarting services is required to allow them to load updated shared libraries. These tasks are automatable, but depending on SLAs and other constraints it is not always desirable to automate them fully.
The main point of the debsecan plugin is to have an indication of the global "vulnerability" level of a host over time. Note that all CVEs reported are not always applicable, have different severities, so manual investigation is needed to either fix the underlying issues, or whitelist a particular CVE through debsecan's whitelist. Looking at the chart does not replace reading debsecan reports, but it gives an insight on the attack surface of each host, and allows comaprisons between hosts.
The main point of the logcount plugin is to have quick access to error/warning log message rates on each host. This is a very lightweight alternative to more complex systems like ELK/Graylog, where setting up a full log aggregation/analysis/SIEM is not possible, and is an improvement over reviewing logs manually.
The main point of the apt plugin is to alert when some packages should be upgraded, or when a full distribution upgrade is in order. Again this process can be fully automated, but it is not always desirable (e.g. when using third-party repositories which require reading release notes and possibly applying manual changes). It also mitigates configuration errors in unattended-upgrades configuration (e.g. forgetting to allow automatic upgrades from a specific repository). This is the newest of my netdata plugins but it is working well so far.

The needrestart, debsecan and apt plugins are specific to Debian-based systems. All plugins have tagged releases so it is possible to run them without suffering breaking changes without notice. All plugins can be installed through the nodiscc.xsrv.netdata ansible role which is already listed in this repository.
Please let me know if you have any questions improvements to suggest.

adding here too https://github.com/netdata/netdata/pull/14830


script failed to retrieve security info from dmesg

issue happened on Siena & Genoa platform

Fixed in snp-devel commit 41860d09c901021b503a9b2defe660888684c885


Matrix{RandomVariable} * RandomVariable errors

Hello. I'm trying to extend one of the examples but hitting a wall.
I'm building upon the Gaussian Linear Dynamical System example.
In particular I'm trying to generalise it so that we don't assume to know the transition matrix $A$ a priori (eventually, I'd like to get to a scenario where we learn most of those matrices). In the example $A$ is passed as an input, and then converted to a constantvar to be used in the model. I would like it to be given a prior in the model, and then inferred together with the rest of the parameters.
I tried a couple of things, but I can't make it work. A minimum reproducible example is consist in redefining model and inference as follows:
@model function rotate_ssm(n, x0, B, Q, P)

    # We create constvar references for better efficiency
    cB = constvar(B)
    cQ = constvar(Q)
    cP = constvar(P)

    # `x` is a sequence of hidden states
    x = randomvar(n)
    # THIS IS WHERE I DIVERGE FROM EXAMPLE:
    A = randomvar(2,2)
    # `y` is a sequence of "clamped" observations
    y = datavar(Vector{Float64}, n)

    x_prior ~ MvNormalMeanCovariance(mean(x0), cov(x0))
    x_prev = x_prior

    α ~ Uniform(0.0,3.0)
    β ~ Uniform(0.0,3.0)

    A .~ Gamma(α,β)

    for i in 1:n
        x[i] ~ MvNormalMeanCovariance(A*x_prev, cQ)
        y[i] ~ MvNormalMeanCovariance(cB * x[i], cP)
        x_prev = x[i]
    end

end

And I change the inference function accordingly
result = inference(
    model = rotate_ssm(length(y), x0, B, Q, P),
    data = (y = y,),
    free_energy = true
)

I tried to specify $A$ in a number of ways, but never getting any luck.
When I try to run it, I get the following error:
ERROR: MethodError: no method matching make_node(::typeof(*), ::FactorNodeCreationOptions{FullFactorisation, Nothing, Nothing}, ::RandomVariable, ::Matrix{RandomVariable}, ::RandomVariable)

Hi @gvdr! Thanks for trying out RxInfer.jl. Long story short, broadcasting isn't supported in RxInfer.jl.
The reason is mainly the intricacies of graph construction and inference. I see you are trying to build a hierarchical prior by introducing a Uniform prior on top of the parameters of Gamma. This is currently not supported out of the box as well.
One way to circumvent the current problem is somewhat similar to what was suggested in this discussion:
https://github.com/biaslab/RxInfer.jl/discussions/156
Check docs for Delta node as well:
DISCLAIMER: (1) the code below looks ugly, but this is the only way to enforce Gamma prior for each element of your transition matrix. (2) CVI will be slow, hyperparameter-dependent and inaccurate to mean field constraint in this case; I don't think that inference is accurate, so sampling-based toolboxes (such as Turing or numpyro) could make the inference faster.
# assuming your matrix A has 4 elements.
# ugly, I know
function f(x, a, b, c, d)
    A = [a b; c d]
    A*x
end

@model function rotate_ssm(n, x0, B, Q, P)

    # We create constvar references for better efficiency
    cB = constvar(B)
    cQ = constvar(Q)
    cP = constvar(P)

    # `x` is a sequence of hidden states
    x = randomvar(n)
    x̂ = randomvar(n)
    # `y` is a sequence of "clamped" observations
    y = datavar(Vector{Float64}, n)

    x_prior ~ MvNormalMeanCovariance(mean(x0), cov(x0))
    x_prev = x_prior

    a = randomvar(length(Q))

    for i in 1:length(Q)
        a[i] ~ Gamma(α=1.0, β=1.0)
    end

    for i in 1:n
        # here you'd want to do  x̂[i] ~ f(x_prev, a), but we can't do that yet
        # so we do ugly way
        x̂[i] ~ f(x_prev, a[1], a[2], a[3], a[4])
        x[i] ~ MvNormalMeanCovariance(x̂[i], cQ)
        y[i] ~ MvNormalMeanCovariance(cB * x[i], cP)
        x_prev = x[i]
    end

end

delta_meta = @meta begin
    f() -> CVI(StableRNG(42), 100, 200, Optimisers.Descent(0.01))
end

x0 = MvNormalMeanCovariance(zeros(2), 1.0 * diageye(2))
result = inference(model = rotate_ssm(length(y), x0, B, Q, P), options = (limit_stack_depth = 500, ), constraints=MeanField(),
initmarginals = (x = MvNormalMeanCovariance(zeros(2), 1e4diageye(2)), x̂ = MvNormalMeanCovariance(zeros(2), 1e4diageye(2))),
initmessages=(a = GammaShapeRate(1e-2, 1e2),),
meta=delta_meta, data = (y = y,), free_energy=true, showprogress=true, iterations=5, returnvars=KeepLast())

Initial marginals are needed due to mean-field constraint; the init message is necessary for the CVI approximation method.
I will convert this issue into a discussion. I will create two issues associated with your question: (1) throwing an error on broadcasting, (2) dealing with broadcasting (this will take some time)
There's of always room for creating your node and the associated rules with that.
To get a better idea what RxInfer.jl can or cannot support, the understanding of Forney-style factor graphs helps significantly.


ChefSpec generating warnings about LWRP resources being redeclared

Recently (and with ChefDK 0.8.1 which includes ChefSpec 4.4.0) any cookbook I attempt to test which includes cookbooks with LWRPs generates hundreds of warnings. These warnings are so numerous that all the TravisCI builds for things like chef-cookbooks/chef-client are failing at the rspec logs more than the limit of 4 megabytes.
I'm assuming this is related to the 12.4 changes about this warning being introduced back in June (which said if you redefine a resource and don't want this error you need an override: true parameter in the new resource). Is there anything I can to do mitigate or suppress the warning (or just see it once) during my rspec/ChefSpec run?
The apt cookbook maintainers are already aware of the issue and point out that it only occurs with ChefSpec::ServerRunner but not ChefSpec::SoloRunner.  https://github.com/chef-cookbooks/apt/issues/163
Errors from the rspec of chef-bareos:
WARN: You declared a new resource #<Class:0x007fc884f84388> for resource openssl_dhparam, but it comes alphabetically after LWRP resource openssl_dhparam from cookbook openssl and has the same filters ({}), so it will not be used. Use override: true if you want to use it for openssl_dhparam.
[2015-10-07T14:18:14-07:00] WARN: OpensslDhparam already exists!  Deprecation class overwrites LWRP resource openssl_dhparam from cookbook openssl

And from chef-cookbooks/chef-clients rspec:  (you might need to use my PR: https://github.com/chef-cookbooks/chef-client/pull/343)
 WARN: You declared a new resource #<Class:0x007fd50800aca0> for resource windows_zipfile, but it comes alphabetically after LWRP resource windows_zipfile from cookbook windows and has the same filters ({}), so it will not be used. Use override: true if you want to use it for windows_zipfile.

Apologies if this is not a ChefSpec issue, but it seems to only crop up during rspec runs and it's broken all the lovely TravisCI badges just from the volume logged even if the rspec tests succeed.  Please let me know what I can do to help.
Thank you.

It looks like ChefSpec doesn't do any recycling on the ChefZero instance, so the cookbooks are uploaded for every "runner.converge" triggering that warning. I thought it was just noisy, but maybe it deserves another look if it's killing badges?

I've just heard that this was introduced in chef 12.4 and fixed in 12.5.1. I'm testing it now and will close the issue if it's fixed and was a chef-client issue rather than a ChefSpec one.

Is this the same issue?  these WARN messages started showing up recently, and persist with version 12.5.1
rspec -f d --color
sean-1337::default
When all attributes are default, on an unspecified platform
downloads the web content tarball
[2015-10-16T16:37:33-05:00] WARN: AptPreference already exists!  Deprecation class overwrites LWRP resource apt_preference from cookbook apt
[2015-10-16T16:37:33-05:00] WARN: AptRepository already exists!  Deprecation class overwrites LWRP resource apt_repository from cookbook apt
converges successfully
[2015-10-16T16:37:35-05:00] WARN: AptPreference already exists!  Deprecation class overwrites LWRP resource apt_preference from cookbook apt
[2015-10-16T16:37:35-05:00] WARN: AptRepository already exists!  Deprecation class overwrites LWRP resource apt_repository from cookbook apt
creates index.html
Finished in 6 seconds (files took 9.66 seconds to load)
3 examples, 0 failures

Is this the same issue for the following warnings?
./tmp/d20151024-18416-1fl4wzs/cookbooks/chef-client/libraries/helpers.rb:25: warning: already initialized constant Opscode::ChefClient::Helpers::CHEF_SERVER_USER
/tmp/d20151024-18416-1fl4wzs/cookbooks/chef-client/libraries/helpers.rb:25: warning: previous definition of CHEF_SERVER_USER was here
The only way I can make them go away is to combine all 'it' blocks into one.  My knife version is 12.5.1 but I was getting same error with 12.4.4
I also use berkshelf.  I do not get errors when I run the examples in this (chefspec) git repo

I can confirm this is still happening with chef-client 12.5.1
$ uname -a
Darwin mylappy 14.5.0 Darwin Kernel Version 14.5.0: Tue Sep  1 21:23:09 PDT 2015; root:xnu-2782.50.1~1/RELEASE_X86_64 x86_64

$ chef --version
Chef Development Kit Version: 0.9.0
chef-client version: 12.5.1
berks version: 4.0.1
kitchen version: 1.4.2

$ grep -i chefspec Gemfile.lock
    chefspec (4.4.0)
  chefspec

I also have been running into this issue with Chef 12.5.1. I was able to get these warnings to go away by using SoloRunner instead of ServerRunner as mentioned here:
https://github.com/chef-cookbooks/apt/issues/163

I also have been running into this issue with latest ChefSpec release 4.5.0.

Hey all, a hack workaround for this is to redirect stdout during the chefspec converge, and restore it afterwards.  Code:
  let (:chef_run) do
    # Redirecting stdout to suppress 'Deprecation class overwrites LWRP' noise.
    # (ref https://github.com/sethvargo/chefspec/issues/642)
    old_std_out = $stdout.clone
    $stdout.reopen('tmp_std_out.txt', 'w')
    result = chef_runner.converge(described_recipe)
    $stdout.reopen(old_std_out)
    File.read('tmp_std_out.txt').each_line do |lin|
      puts lin unless lin =~ /Deprecation class overwrites LWRP resource/
    end
    File.delete('tmp_std_out.txt')
    result
  end

Hi everyone, this is being tracked upstream in chef/chef#4668. Thanks! :smile:


Stop scraping emails illegaly from GitHub for spam

This is a clear violation of the GitHub Terms of Services and possibly violates local data protection laws like the GDPR.
DO NOT MASS EMAIL STARGAZERS OF GITHUB REPOSITORIES.

Apologies on behalf of the team. We’ll stop the emails.

This is still happening.


Truncate commits messages to one line in tree view

Consider truncating (with ellipsis) the commit messages in the tree view to one line, as it is annoying that the tree changes after the commit messages has finished loading if some of them takes up more than one line of space.

That would be a really useful feature, however there is no place with the full commit message at the moment. I think it needs be consolidated a little and PR addressing this issue would be super welcomed.

How about something like gitscm's log/shortlog? I think that works pretty well.

Implemented recently


Question:- purpose of using the MockV3Aggregator is unclear

In brownie_fund_me the use of MockV3Aggregator is unclear in the part where he told us to use it so.
As we are already using the AggregatorV3Interface to get the pricefeed in fundMe.sol.
Correct me if I'm wrong.

The Mock contract is used to mock the existing AggregatorV3 contract which exists on the testnets/mainnets. Under local development we can't get the real priceFeed cause there is no such permanent contract which we can look at since the local chains reset every time we load them. The mock simply mimics what the original AggregatorV3 is doing on the persistent networks.
if network.show_active() not in LOCAL_ENVIRONMENTS:
        priceFeedAddress = config["networks"][network.show_active()][
            "eth_usd_priceFeed"
        ]
    else:
        deployMock()
        priceFeedAddress = MockV3Aggregator[-1].address

    fm = FundMe.deploy(
        priceFeedAddress,
        {"from": acc},
    )

The deployMock() is :
def deployMock():
    acc = getAccount()
    if len(MockV3Aggregator) <= 0:
        MockV3Aggregator.deploy(DECIMALS, STARTING_PRICE, {"from": acc})

If we use the local chains, first the Mock is deployed so that there is a contract which can give us the information we need that is the current priceFeed (manually set by specifying the DECIMALS and STARTING_PRICE)
and we use the priceFeed of the local AggregatorV3(the mock). I hope this helps :)

The Mock contract is used to mock the existing AggregatorV3 contract which exists on the testnets/mainnets. Under local development we can't get the real priceFeed cause there is no such permanent contract which we can look at since the local chains reset every time we load them. The mock simply mimics what the original AggregatorV3 is doing on the persistent networks.
if network.show_active() not in LOCAL_ENVIRONMENTS:
        priceFeedAddress = config["networks"][network.show_active()][
            "eth_usd_priceFeed"
        ]
    else:
        deployMock()
        priceFeedAddress = MockV3Aggregator[-1].address

    fm = FundMe.deploy(
        priceFeedAddress,
        {"from": acc},
    )

The deployMock() is :
def deployMock():
    acc = getAccount()
    if len(MockV3Aggregator) <= 0:
        MockV3Aggregator.deploy(DECIMALS, STARTING_PRICE, {"from": acc})

If we use the local chains, first the Mock is deployed so that there is a contract which can give us the information we need that is the current priceFeed (manually set by specifying the DECIMALS and STARTING_PRICE) and we use the priceFeed of the local AggregatorV3(the mock). I hope this helps :)

Thanks for explaination.


VM header bar overlaps breadcrumbs

Header bar overlaps the top half of breadcrumbs.

@jniederm looks like the branding is broken again?


Managed Identity

I think this needs to be here:
https://docs.microsoft.com/en-us/azure/app-service/app-service-web-tutorial-connect-msi

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 500a2c86-b9f9-1e9a-1c22-3579450ba95b
Version Independent ID: ce872fbb-7707-5ff3-e1f9-aa8c170553cc
Content: Securing PaaS Databases in Azure
Content Source: articles/security/fundamentals/paas-applications-using-sql.md
Service: security
Sub-service: security-fundamentals
GitHub Login: @techlake
Microsoft Alias: terrylan

@OlivierInSumma Thanks for the question. We are currently investigating and will update you shortly.

@TerryLanfear Could this be looked into ?

@OlivierInSumma - Thanks for your dedication to our documentation. Unfortunately, at this time we have been unable to review your issue in a timely manner and we sincerely apologize for the delayed response. We are closing this issue for now, but if you feel that it's still a concern, please respond and let us know. If you determine another possible update to our documentation, please don't hesitate to reach out again. #please-close


Zoom: "focal" option doesn't work when "$set" was used on init

Subject
When the "$set" option is used to initialize panzoom, specifically on a child of the main panzoom element, the "focal" option of the zoom command malfunctions--the focal point is not frozen, and the zoom takes a parabolic shape on the Z-axis.
Environment
Using jQuery 3.1.0, panzoom 3.2.0, on latest stable Chrome: 52.0.2743.116 m (64-bit).
Steps to reproduce
See here: http://jsbin.com/xoquwa/edit?html,js,output.
I've taken the template JSbin and the "Use the mousewheel to zoom on a focal point" section from the demo page, and the only thing I changed was to add a "$set" parameter in the panzoom initialization. (I also added a few selectors to make everything work together).
Expected behavior
The focal point should stay in the same screen position while the panzoom element zooms in and out.
Actual behaviour
The focal point moves dramatically, and the viewport zooms in and out along a parabolic curve.

Thanks for opening an issue, but I'm not sure the focal option should support a $set in that way, since the $set element(s) themselves can even be somewhere else on the page, making expected behavior very difficult to define. The $set option is more for additional elements on which to set transforms. If you're going to just have one element, the set should really be #panzoom, not #tiger. Dimensions are always based on the panzoom element, which is good for most cases and bad for yours. I'm not sure your use case, but I suggest leaving the panzoom element as the $set if at all possible.

My use case: I have a big parent div that I want to receive the panzoom events (it covers the whole screen), and a smaller child element (a tree chart) that I want to be panned and zoomed. This gives the illusion of an interactive field of infinite size.
Thanks for explaining why panzoom isn't intended to work this way. I'll figure out an alternate design for the page.


Project Unmaintained?

It looks pretty much that this is full of bugs and no longer maintained. Who is actively using this? Who is satisfied? Also there are more than 300 forks of this project? Is there any more active version?

Yeah. I moved to this:
https://github.com/mikepenz/MaterialDrawer
Mike is prolific about updates. There is a bit more setup and it doesn't quite have the built-ins, however the other side is that it is far more extensible.

Why not using Android Design Library ?
http://android-developers.blogspot.com.br/2015/05/android-design-support-library.html

The design library is great. Hands down.
Mike's MaterialDrawer library offers a lot more features. I would not be surprised in the least if Mike utilizes the design lib as the base if the future if it makes sense.
For me, my clients want sticky footers and custom headers that would require me to extend the design lib in such ways that I'd be replicating Mike's work. I love that Google is finally offering some great libs like this to get Material design more wide-spread though.

@Anatidae-Project Cool, thanks for pointing that out. I was thinking about doing the same. What is your experience of porting an App from MaterialNavigationDrawer to MaterialDrawer?
@filipebezerra I think, that google just gives us the UI controls, but libs like MaterialNavigationDrawer or MaterialDrawer bring some functionality such as  handling fragments, accounts, etc. They should use the Android Design Library under the hood for sure. (If there are no reasons for not doing it).
I might be wring, but this is how I see the things here


Spark: Add tests for identity partition data

This adds missing tests that that identity-partition data values are joined correctly to rows when reading data in Spark. This doesn't test cases where physical columns are missing or partitions based on nested fields.

@rdsr, good to commit this?

+1 . I'll commit this

Thanks for merging and reviewing, @rdsr and @openinx!


disable ssh tests on darwin

Noticed the ssh tests fail when I ran the infra repo devshell on darwin.
entry_points looks like it may have been added by accident?

cc @Mic92

Thx


Batching rules for {view}_copy functions

Tasks
Add vmap support for the following PyTorch operations. That is, each one needs a batching rule.

[ ] view_copy
[ ] narrow_copy

Expected behavior
Currently, when one does vmap over them, they raise a warning suggesting the batching rule is not implemented:
import torch
from functorch import vmap
x = torch.randn(32, 2, 3)
y = vmap(torch.view_copy, (0, None))(x, [6])
#  UserWarning: There is a performance drop because we have not yet implemented the batching rule for aten::view_copy

We expect to not see a warning
Read this!
See this note for more context https://github.com/pytorch/pytorch/blob/master/functorch/writing_batching_rules.md
Testing
(probably the most time consuming part of this)
functorch's vmap tests use the PyTorch OpInfo database to auto-generate tests. Unfortunately the above three operations don't have OpInfos, so we'll have to add some to test this. See the following https://github.com/pytorch/pytorch/wiki/Writing-tests-in-PyTorch-1.8#opinfos-and-the-future-of-testing-tensor-operations for more details; also read the OpInfos in torch/testing/_internal/common_methods_invocations.py

Completed via linked PRs


Claims Based Authentication

Hello,
does DIFS work with a target that only supports Claims Based Authentication?
Thank you and best regards,
Christian

Should do, advise if you experience any problems


Stop rickrolling Chrome users

As a Chrome user, I'd love it if I didn't get rickrolled every other time I visit the website.

I'm sorry Dave, I'm afraid I can't do that.

Yes please

Yes please, it currently has a 40% chance, which seems a tad bit high for a joke.
https://github.com/stefnotch/shakespeares-cats/blob/ab5163c73e14f552623b8d83d76477cc1b325c6f/script.js#L13-L14


The form doesn't work because all of the check-boxes are disabled

URL to the linked Repo/Org:
https://cla-assistant.io/Comcast/Ravel?pullRequest=4
Steps to reproduce the problem:
Open form
What is the expected result?
I can sign the form via the check boxes
What happens instead?
disabled attribute shown; can't click anything

I can't reproduce this issue.

Unfortunately I can not reproduce the issue too... @abgordon do you still face it?

@KharitonOff I do. What do you recommend?

I assume that you've already signed the cla and now the fields are disabled because you can accept the cla only once.
The status of the PR https://github.com/Comcast/Ravel/pull/4 remains "pending" because github can not recognize you as a committer. If you add the email address, which you have used for the commits to your github account then your commits will be associated with your github account and cla status should also be updated

Revisiting this, I added<EMAIL_ADDRESS>which appears to be something my managed laptop added automatically to my local git. Because it's not an actual email address,  I can't verify it, so i'm not sure if adding it to my account will help the status move out of pending.

Hmmm... usually you don't need to verify the email address in order to assign these commits to your account. I don't know why it is not working for you now, the email address seems to be the right one.
I see two ways to solve this:

convince the project owner to accept your PR despite of technical issue with the email address, you have lastly accepted the CLA
follow the instructions here in order to reset your git settings and adjust commit history: https://help.github.com/en/github/using-git/changing-author-info

Update of current state. So it seems that we need to modify the commit

Hi Andrew, I'm very sorry about it! I should have warned you that the second option causes reset of the git history, my fault! I hope you managed to restore it.
I am very confused, that even this step didn't help to assign your commits to your github account.
Unfortunately we can not do much about it on our side, since we fully on information, which GitHub provides us. This means if GitHub doesn't assign these commits to your account, cla assistant can't recognize you as a committer. The gray octocat icon near commits signals such cases as described here: https://help.github.com/en/github/committing-changes-to-your-project/why-are-my-commits-linked-to-the-wrong-user#commits-are-not-linked-to-any-user

Here is the result of reproduced graphQL call, which cla assistant does in order to collect committers of your PR:

Fixed it. The tutorial recommends doing this with a clean repo, which given the state of the repo was a terrible idea.
I freshly-cloned a repo which meant the .git/refs directory was not fully populated. When I rewrote history and force-pushed, it did not rewrite the history of any of the outstanding branches, basically making them orphaned - PRs opened in github from the PR branches showed the error "no changes to show, these two branches have entirely different histories."
Given the outstanding 1000+ lines of code in PR, I panicked a bit and re-pushed the state from the original repo. This meant the author history was not rewritten, but got the repo back to its original state, minus the PRs, but they could be re-opened at least.
This morning I rewrote the history from my working repo with the refs directory populated, and then force pushed that. Fixed the CLA state but still lost the comments & PR's.
So all good here, lost some comments on the working PR but no code is gone. In the future I would make a note of that for people instead of just directing them to the tutorial. If there are outstanding working branches and pull requests, doing the history rewrite from a bare repo will result in code loss. I would recommend doing a full copy with cp -r <repo> <repo>-save and attempting to rewrite history with a backup on your machine.
My 2 cents, but obviously, I'm not as good at git as I thought I was if I did what I did yesterday. Not sure the rationale of starting from a bare repo in the tutorial.

Closing this

Thank you very much for the detailed description. It is very valuable learning! I will keep it in mind.
I'm glad that you have managed to bring the code into more or less acceptable state! 👍


[All hosts](community call) Add January call link

Docs Build status updates of commit 020651a:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/overview/office-add-ins-community-call.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Docs Build status updates of commit 4f8fbc7:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/overview/office-add-ins-community-call.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel


[StyleSheet] Sort valid style props alphabetically

Was there any specific decision behind displaying them in the current way?

Personally having all the properties sorted alphabetically would've helped a lot to find the one wanted in case of a typo.

This has been fixed in https://github.com/facebook/react-native/commit/e2fc7d23628ab8162ae02e35a434dabb13b18968, issue can be closed.


Make use of a separate datasource for Keycloak

Like reported by @sebastienblanc at keycloak-dev, there's an issue after the deployment of Keycloak 1.1.0.Final and UPS pointing to the same database.
Marek suggested to split the datasources, which makes perfect sense.
That said @matzew @edewit @qmx @sebastienblanc would you mind to review?

Schweeet!
the only caveat is that I think it would be wise to do this change on master only, since this has direct impact on the migration work. (this would mean that for 1.0.x users would need to provide two datasources) + we would need to migrate data from our DS to the new DS (doable, but hard work)

(this would mean that for 1.0.x users would need to provide two datasources)

Gaah, confusing comment is confusing:
for the migrator, user needs to provide DB credentials - which essentially means we would need to create a different migrator, one for UPS and another one for keycloak.

I will make sure tomorrow checking if this issue is reproducible on 1.0.x , that will make the decision on what to do easier.
Envoyé de mon iPhone

Le 19 févr. 2015 à 19:19, Douglas Campos<EMAIL_ADDRESS>a écrit :
(this would mean that for 1.0.x users would need to provide two datasources)
Gaah, confusing comment is confusing:
for the migrator, user needs to provide DB credentials - which essentially means we would need to create a different migrator, one for UPS and another one for keycloak.
—
Reply to this email directly or view it on GitHub.

For MySQL and PostGres, the database also needs to be created manually  like mentioned here https://aerogear.org/docs/unifiedpush/ups_userguide/server-installation/#_mysql_database (section 3) .  tracked by https://issues.jboss.org/browse/AGPUSH-1292

Ok, tested on 1.0.x, we don't have the issue so since we are on the critical path for the 1.0.3 I would suggest to do nothing for this branch,
But, let me be completly honest, I just failed to reproduce that issue @lholmquist  and me were having, not sure sure if something happened since then (new parent or smt else)  ... However, I think this is still a nice enhancement having these 2 in a separate databse but only for master.

+1 let's not touch 1.0.x with this
On Fri, Feb 20, 2015 at 10:20 AM, Sebastien Blanc<EMAIL_ADDRESS>wrote:

Ok, tested on 1.0.x, we don't have the issue so since we are on the
critical path for the 1.0.3 I would suggest to do nothing for this branch,
But, let me be completly honest, I just failed to reproduce that issue
@lholmquist https://github.com/lholmquist and me were having, not sure
sure if something happened since then (new parent or smt else) ... However,
I think this is still a nice enhancement having these 2 in a separate
databse but only for master.
—
Reply to this email directly or view it on GitHub
https://github.com/aerogear/aerogear-unifiedpush-server/pull/500#issuecomment-75209791
.

--
Matthias Wessendorf
blog: http://matthiaswessendorf.wordpress.com/
sessions: http://www.slideshare.net/mwessendorf
twitter: http://twitter.com/mwessendorf

@qmx @sebastienblanc @matzew ok, so cherry-pick to master?

@sebastienblanc btw, not merging it, from my pov is a blocker to decouple Keycloak from UPS.

@abstractj sure, I was also thinking that this would be a good one for the decouple task. I'm totally +1 to have this on master.

I'm eager to hear ideas on how to provide a migration path from 1.0.x

I'm eager to hear ideas on how to provide a migration path from 1.0.x

@qmx I understood that the migration work does include going from 1.0.x to 1.1.0 as well

@matzew there's no miracle as in I can ensure schema changes inside the same DS - for us to move keycloak's data over another datasource it needs to be something else

ok, so... I think, having the separation on 1.1.0/master only may be the best.
That way we can have 'smooth' migrations w/in 1.0.x series.
But not sure what's exactly the best migration path from 1.0.3 -> 1.1.0 (with separated datasources)

So, what is the consensus here?

From what I understand , only for master and I really want to test that and provide feedback before the end of the week.
Envoyé de mon iPhone

Le 25 févr. 2015 à 19:36, Bruno Oliveira<EMAIL_ADDRESS>a écrit :
So, what is the consensus here?
—
Reply to this email directly or view it on GitHub.

I think that we should get it on to master. I am not sure for 1.0.x and
our last 1.0.3 release.
At some (later) point we do need to think about going from 1.0.3 to 1.1.x.
But I am not sure we need to separated the DS for our last 1.0.3.
@qmx @sebastienblanc what are you guys thinking?
On Wed, Feb 25, 2015 at 7:36 PM, Bruno Oliveira<EMAIL_ADDRESS>wrote:

So, what is the consensus here?
—
Reply to this email directly or view it on GitHub
https://github.com/aerogear/aerogear-unifiedpush-server/pull/500#issuecomment-76026189
.

--
Matthias Wessendorf
blog: http://matthiaswessendorf.wordpress.com/
sessions: http://www.slideshare.net/mwessendorf
twitter: http://twitter.com/mwessendorf

@matzew Yes let's keep it for master only

Ok, I tested the PR :

With H2 :+1:
With MySql :+1:  but I had to run some extra sql commands :

 create database keycloak default character set = "UTF8" default collate = "utf8_general_ci";
GRANT SELECT,INSERT,UPDATE,ALTER,DELETE,CREATE,DROP ON keycloak.* TO 'keycloak'@'localhost';

For PostGres, I'm currently having really hard time to reinstall it on my fedora, so if anyone want to test it please :)

@matzew @qmx @sebastienblanc landed on master, right here https://github.com/aerogear/aerogear-unifiedpush-server/commit/55e4725d3afcf51f16c7b8a4c1ccde860a9f54b8

Cool but has anyone tested that with postgresql ?

@sebastienblanc yup, but if that only works on my machine. git revert to the rescue ;)

@abstractj Ah cool ! I totally trust you :) , let me PR now for  https://issues.jboss.org/browse/AGPUSH-1292


Allow replacing of Kazan.Client.Imp via configuration

As mentioned in https://github.com/obmarg/kazan/pull/72 we have a wrapper around Kazan.run/2 for instrumentation.
It would be useful if the module that Kazan.run/1 and Kazan.run/2 delegates to could be changed by configuration.  This way we could easy provide our own implementation which wraps calls to Kazan.Client.Imp.run/2 with instrumentation.
This would also be useful to allow Kazan.Client.Imp to be replaced by a mock module for testing an app that uses Kazan.
To do this I would also suggest moving Kazan.Client.Imp.run!/2 to the Kazan module (as it's  just a wrapper around run/2) and leaving run/2 as the only function that is required to be implemented in Kazan.Client.Imp or a mock implementation.  A behaviour could also be added.
@obmarg  I can provide a PR for this if you agree with the approach.

This is an interesting idea, not one I'd considered.  Not sure where I stand: is there a reason to do this in Kazan vs. implementing this in your app?


Add implementation to the Construction Expert perk

I have added the engineering construction expert missing perk. Also, updated the readme.md with new perk category named 'Engineering'.
The implementation reduces the production cost (in 30%) for walls and fortifications when the governor of the castle/city has the construction expert perk active. It also takes in consideration that the 'castle charters' policy might be active, which reduces the cost in 20% by itself. Having both the perk and policy active, will plummet the costs by 50% additively.

I just realized the perk should be increasing the production speed not the cost. Gonna fix that and close this pull request


Ref: 111248741

What do you mean by Injection script?

Oh, sorry, I just realized the comments aren't for Javadoc in this repo. LGTM


feat: get a generator/matching rule from JSON

I haven't tested the generator function yet, but the matching rule function works nicely.
This enables me to pull them out from the following plugin RPCs:

CompareContents
GenerateContent

And therefore would solve the problem for a content matcher plugin, but not a transport one.
i.e. it won't work for the methods that accept the Pact object (e.g. VerifyInteraction or StartMockServer). I had a look at the existing FFI methods, and I don't think there is a way to navigate to a place where you can extract a MatchingRule (that might be possible, and perhaps is a better pathway).
PrepareInteractionForVerification and VerifyInteraction both already have access to the Config struct, and so could use the other FFI methods (e.g. pactffi_parse_matcher_definition(const char *expression)) for this purpose..
So that would leave just StartMockServer lacking a way to get to the expressions.
This can all be worked around by maintaining state of course, but you mentioned this is against the aim of the framework.
What do you think is the best way to make the expressions (in the form of MatchingRules and Generators) available to a Plugin at all stages?
(I also expect the build to fail because the FFI package will need the new functions in the models package)

LGTM. I need to think on this a bit more, there must be a better way to support this requirement

Thanks. Rather than merge this in (and increase the API surface area), should I create an issue out of it so we can track?
The methods themselves aren't exactly problematic, so I guess it wouldn't be the worst thing to bring them in.
I'll take your advice though. No need to rush this.

Yeah, ok, let's do that.


Remote treeview doesn't refresh after 'Sync local -> Remote'

The remote treeview should refresh automatically after e.g. a local directory has been uploaded with Sync local -> Remote, but this doesn't work. One has to manually refresh (e.g. by collapsing the remote directory and re-expanding it).

Ah, this is something I actually noticed after I submitted my last PR. I don't mind making this fix. :)


[apps/movex-demo] Typo in the documentation

Where
movex\apps\movex-docs\pages\docs\how.mdx
What

Definition of done

[ ] Correct spelling
[ ] tests are still passing

Thank you for opening this issue up @Ekep-Obasi! Really appreciate it 🙏


SubscriberStub awaitTerminate() returns before all threads are closed

Hello!
Issue
I run into a problem when using shutdown() and awaitTermination() of a SubscriberStub. When awaitTermination() returns not every grpc thread has actually finished.
I need a way to know when the subscriber and all background threads are actually finised. This is needed because the Apache Flink cluster it is running on will remove classes and if anything is still running this will cause ClassNotFoundExceptions. (See this issue (https://github.com/googleapis/google-cloud-java/issues/3752 for a more thorough explaination)
So my question is two-fold:
Is it correct awaitTerminate() does not wait for all background resources the shutdown?
If this is the intended behavior, is there any other way of knowing when all background resources are done?
Steps to reproduce
This piece of code shows the existence of background threads after awaitTermination() returns:
//no grpc threads obviously
Thread.getAllStackTraces().keySet().stream().filter(Thread::isAlive).map(Thread::getName).forEach(Sy stem.out::println);

SubscriberStubSettings settings = SubscriberStubSettings.newBuilder().build();
GrpcSubscriberStub stub = GrpcSubscriberStub.create(settings);

stub.shutdownNow();
stub.awaitTermination(1, TimeUnit.MINUTES);

//grpc threads, in particular: grpc-shared-destroyer-x, when actual work has been done even more threads are shown like grpc-worker-x-y
Thread.getAllStackTraces().keySet().stream().filter(Thread::isAlive).map(Thread::getName).forEach(System.out::println);

External references such as API reference guides used
https://googleapis.github.io/google-cloud-java/google-cloud-clients/apidocs/com/google/cloud/pubsub/v1/stub/GrpcSubscriberStub.html#awaitTermination-long-java.util.concurrent.TimeUnit-
Thank you for looking into this

@Xeli grpc uses shared event loop if not specified to be used by any number of client. On awaitTermination of client it schedules the destroyer thread which destroys the event loop if no new client is created or exists with in that time. so to make sure that shared resources are destroyed please wait for 3-5 second after calling awaitTermination to remove all grpc threads.

@ajaaym thanks for the quick response. Is there another way besides waiting a few seconds?
I would prefer a more robust check to be sure everything is gone.

@Xeli Unfortunately there is no robust way unless you provide your own TransportChannelProvider. In that case you can create channel builder using NettyChannelBuilder and provide your own event loop which you can shutdown. If you want to go that route I can send you full working sample.

@ajaaym That is too bad. I would appreciate it if you could point me to a working sample!

@Xeli please use below code.
    final EventLoopGroup eventLoopGroup = new DefaultEventLoopGroup(6);
    InstantiatingGrpcChannelProvider
        channelProvider = SubscriberStubSettings.defaultGrpcTransportProviderBuilder().setChannelConfigurator(new ApiFunction<ManagedChannelBuilder, ManagedChannelBuilder>() {
      @Override public ManagedChannelBuilder apply(ManagedChannelBuilder input) {
        NettyChannelBuilder nettyChannelBuilder = (NettyChannelBuilder) input;
        nettyChannelBuilder.eventLoopGroup(eventLoopGroup);
        return nettyChannelBuilder;
      }
    }).build();
    SubscriberStubSettings settings = SubscriberStubSettings.newBuilder().setTransportChannelProvider(channelProvider).build();
    GrpcSubscriberStub stub = GrpcSubscriberStub.create(settings);
    stub.shutdownNow();
    stub.awaitTermination(1, TimeUnit.MINUTES);
    eventLoopGroup.shutdownGracefully();
    eventLoopGroup.terminationFuture().await(1, TimeUnit.MINUTES);

Thank you for this @ajaaym
I am running into a problem when providing an EventLoopGroup. Locally (osx machine) it works fine when I am using DefaultEventLoopGroup.
But if I run the code on the Google Cloud Platform (kubernetes) it fails with the exception:
Caused by: java.lang.IllegalStateException: incompatible event loop type:
io.grpc.netty.shaded.io.netty.channel.DefaultEventLoop
at io.grpc.netty.shaded.io.netty.channel.AbstractChannel$AbstractUnsafe.register(AbstractChannel.java:469)
at io.grpc.netty.shaded.io.netty.channel.SingleThreadEventLoop.register(SingleThreadEventLoop.java:80)
at io.grpc.netty.shaded.io.netty.channel.SingleThreadEventLoop.register(SingleThreadEventLoop.java:74)
at io.grpc.netty.shaded.io.netty.bootstrap.AbstractBootstrap.initAndRegister(AbstractBootstrap.java:333)
at io.grpc.netty.shaded.io.netty.bootstrap.AbstractBootstrap.register(AbstractBootstrap.java:234)
at io.grpc.netty.shaded.io.grpc.netty.NettyClientTransport.start(NettyClientTransport.java:230)
at io.grpc.internal.ForwardingConnectionClientTransport.start(ForwardingConnectionClientTransport.java:33)
at io.grpc.internal.ForwardingConnectionClientTransport.start(ForwardingConnectionClientTransport.java:33)
at io.grpc.internal.InternalSubchannel.startNewTransport(InternalSubchannel.java:266)
at io.grpc.internal.InternalSubchannel.access$700(InternalSubchannel.java:67)
at io.grpc.internal.InternalSubchannel$TransportListener.transportShutdown(InternalSubchannel.java:611)
at io.grpc.netty.shaded.io.grpc.netty.ClientTransportLifecycleManager.notifyShutdown(ClientTransportLifecycleManager.java:53)
at io.grpc.netty.shaded.io.grpc.netty.ClientTransportLifecycleManager.notifyTerminated(ClientTransportLifecycleManager.java:69)
at io.grpc.netty.shaded.io.grpc.netty.NettyClientTransport$4.run(NettyClientTransport.java:248)
at io.grpc.SynchronizationContext.drain(SynchronizationContext.java:101)
at io.grpc.SynchronizationContext.execute(SynchronizationContext.java:130)
at io.grpc.internal.ManagedChannelImpl$NameResolverListenerImpl.onAddresses(ManagedChannelImpl.java:1300)
at io.grpc.internal.DnsNameResolver$Resolve.resolveInternal(DnsNameResolver.java:325)
at io.grpc.internal.DnsNameResolver$Resolve.run(DnsNameResolver.java:225)
... 3 more

This seems to be because it requires a NioEventLoop (https://netty.io/wiki/native-transports.html)
Do you have any tips how to create the correct EventLoop ?

@Xeli can you try to use  NioEventLoopGroup or EpollEventLoopGroup instead of Default? GRPC uses NioSocketChannel by default. Not sure why it worked on mac. I also tried on mac only.

Yes this works perfectly! Thank you so much for your help @ajaaym


Draftail editor disappears when pasting text in a new page

Issue Summary
The Draftail editor disappears when I try to paste some text in a new page.
Steps to Reproduce
From the Wagtail's admin:

Create a new page which has at least one RichTextField
Paste some text in this field, it doesn't matter the source - e.g. enriched text from LibreOffice or simple text from a notepad.

Note that when I edit a page with some content already defined in this field, I do not encounter this bug: I can paste some text without any issue - except some formatting issues, but it is another topic!
Technical details

Python version: 3.5.3
Django version: 2.0.2
Wagtail version: 2.0
Browser version: Firefox ESR 52.6.0

Here is the error I have in the Firefox console when I paste some text:
> DOMException [NotFoundError: "Node was not found"
code: 8
nsresult: 0x80530008
location: http://localhost:8090/static/wagtailadmin/js/vendor.js:1]  vendor.js:1:144547
> NotFoundError: Node was not found  vendor.js:1

Thanks in advance!

Hi @jeromelebleu, thank you for the detailed report! The editor disappears because it crashes. We’ve been working on a “crash recovery” / fallback UI, but it didn’t make the cut for Wagtail 2.0.
There’s been thorough manual testing of copy-pasting in Draftail so I wonder if/how this might be specific to your environment. I’m away from the computer for the next wee while, if you could do further testing it would help a lot:

Does this work in another browser?
If it seems specific to Firefox, does it work with the latest non-ESR version? (I’ve done most tests in v57, which is very different to pre-quantum v52).
What OS are you using?

Finally you mention some formatting issues — could you give more details? The Draftail editor is fairly new so it would be good to know where things break down.

@thibaudcolas, you're welcome! I totally understand that testing all browsers - and all versions! - and trying to make it works with all of them is quite painful...
I am running Debian Buster (testing) and it works indeed with other browsers. I tried with Firefox 58.0.1 and Chromium 62.0.3202.89. It seems to be specific to Firefox ESR version only so.

Finally you mention some formatting issues — could you give more details? The Draftail editor is fairly new so it would be good to know where things break down.

I did not encountered those formatting issues while testing with those browsers - I did not encountered any issue in fact!
Let me know if you need further details. Also, let me know if I should open a bug report on the Draftail repository instead.

Thank you, that's very helpful. Good call to switch back to Hallo for now.
I couldn't manage to reproduce this while pasting plain text or basic HTML 😞. Tried in FF52.6.0 ESR in macOS 10.13, and FF52 not-ESR (though I'd suspect releases to be the exact same, except for the update channel) in Windows 10 and Windows 8.1. Tested in Wagtail (2.0 release) and directly on https://springload.github.io/draftail/.
I suspect there may be something else specific to your case, either the content you copy-paste, how you copy-paste it, or the OS. Before I go figure out how to install Debian Buster, could you:

Provide a small sample of content you used. You said the source doesn't matter but it's worth double checking.
Let how you do the copy-paste – keyboard shortcuts or contextual menu. Ideally via a small screen recording.
See whether it works on https://springload.github.io/draftail/examples/ (I suspect it won't, but let's be certain).

For the bug report, it's best to open them here first and then triage it together depending on what we find out. I expect a lot of Draftail bugs to ultimately be in Draft.js itself (see #4274), but would rather only open bugs there (or in Draftail) once we have been through some troubleshooting.

Thanks for all your tests! I admit that I have an unusual environment, so I've tried on a stock Debian with default configuration for Firefox ESR. I've realized that it's working fine, indeed, as your several tests. I've compared my Firefox configuration so and found the origin of this issue. This bug occurred only when dom.event.clipboardevents.enabled is false... I took my Firefox configuration from the iceweasel package.
I don't know what's the future of this really specific bug - sorry about the time you spent on that - but I would totally understand if you decide to close it and don't want to go further. I will certainly keep this option enabled...!

Nice! We all learned something, so that time was well spent. I've added a note in the Draftail docs about troubleshooting this, and will leave it at that for now.
In an ideal world, I think Draft.js should handle this gracefully instead of crashing because of the missing events. I can see however that customising DOM behavior to that extent is quite advanced (I'm not even sure the DOM clipboard spec allows it), so first let's see whether other people encounter this.

Nice! We all learned something, so that time was well spent. I've added a note in the Draftail docs about troubleshooting this, and will leave it at that for now.

Yes, indeed! Thanks for the note.
I had a deeper look into why this setting was false - by the way, it was from the Parabola iceweasel package, a fully Free (as in freedom) operating system, not Debian. I found several pages which are talking about disabling this setting in Firefox to enforce privacy - see here or here.


Remove "signal-handling" category

Apparently "signal" is a valid category but "signal-handling" is not.
Closes #32

Apparently "signal" is a valid category

Hmm... https://crates.io/categories/signal says:

signal: Category not found

Weird; it was a category for the signal-hook crate so I thought it must've been valid. Oh well, I'll just remove it.


Revised Examples - targetDataType decimal

Note the updated examples have targetDataTime="decimal" for all dataType="decimal" values. Was it intended that way?

Yes, that is intended. See Supported Column Data Type Combinations table specification: https://wiki.cdisc.org/display/DSJSON1DOT1/Dataset-JSON+1.1

I added a comment to the specs:


Fix missing repository warning and add unmet peer dev dependency

I was seeing npm warnings for a missing repository field and for an unmet peer dev dependency (@storybook/react^3.2.12).
There are still two unmet peer dependency warnings for jquery and popper.js due to @edx/edx-bootstrap, which I created a PR for.
TODO

[ ] Should I increase the version for this?

Coverage remained the same at 99.468% when pulling eb3fbdc6df69a36592f008ddcda2a094c6bd145e on fix-npm-warnings into 6ad42ee210bf58c9889ed1ca7fdf7eb0c55db510 on master.

Err I guess this is related to #52

Coverage remained the same at 99.472% when pulling aa98eac97a759b104044ca8eb902c9d0385f7057 on fix-npm-warnings into c1693419c742de823054080c720f1985e2e868e8 on master.


running nanoplish

Hi,
I am trying to run nanopolish for polishing the contig created by Canu. I ran the following command:
nanopolish  consensus  --reads reads.fasta  --bam sorted_reads.bam  --genome  contig.contigs.fasta  -t 4 -w tig00000001:1-4674646
But I got the following error: "consensus: a --models file must be provided"
What is the models file?
Another thing, I showed in the readme the following example:
python nanopolish_makerange.py draft.fa | parallel --results nanopolish.results -P 8
nanopolish variants --consensus polished.{1}.fa -w {1} -r reads.fa -b reads.sorted.bam -g draft.fa -t 4 --min-candidate-frequency 0.1
Is it necessary to run it like this with the parallel command?
Thanks

nanopolish consensus is deprecated, you should follow the instructions here:
https://github.com/jts/nanopolish#computing-a-new-consensus-sequence-for-a-draft-assembly

Thanks for the reply.
As it was suggested I ran the command:
python nanopolish_makerange.py draft.fa | parallel --results nanopolish.results -P 8
nanopolish variants --consensus polished.{1}.fa -w {1} -r reads.fa -b reads.sorted.bam -g draft.fa -t 4 --min-candidate-frequency 0.1
I got the following errors:
Error: could not find path to FAST5 for read ......
Please make sure that this path is accessible: ......
Is it necessary to run before:  "nanopolish extract"? or is it possible like I did to take the fastq reads after demultiplexing and convert them to fasta
Thanks

It is required to run nanopolish extract.
On Sun, Sep 3, 2017 at 8:17 AM, efratca<EMAIL_ADDRESS>wrote:

Thanks for the reply.
As it was suggested I ran the command:
python nanopolish_makerange.py draft.fa | parallel --results
nanopolish.results -P 8
nanopolish variants --consensus polished.{1}.fa -w {1} -r reads.fa -b
reads.sorted.bam -g draft.fa -t 4 --min-candidate-frequency 0.1
I got the following errors:
Error: could not find path to FAST5 for read ......
Please make sure that this path is accessible: ......
Is it necessary to run before: "nanopolish extract"? or is it possible
like I did to take the fastq reads after demultiplexing and convert them to
fasta
Thanks
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/jts/nanopolish/issues/212#issuecomment-326801380, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAXxnzp-0sQerulXDBDtS1OL7UGB6_-Dks5sepjugaJpZM4PEYe9
.

Thanks
I ran nanopolish extract and then I ran bwa:
bwa mem -x ont2d -t 8 draft.fa reads.fa | samtools sort -o reads.sorted.bam -T reads.tmp -
samtools index reads.sorted.bam
But, I got an error: unknown read type 'ont2d'
Is is because I have 1D read? If then how I should run bwa for nanopore reads (1D)?
I ran bwa mem without -x ont2d and then I ran:
python nanopolish_makerange.py draft.fa | parallel --results nanopolish.results -P 8
nanopolish variants --consensus polished.{1}.fa -w {1} -r reads.fa -b reads.sorted.bam -g draft.fa -t 4 --min-candidate-frequency 0.1
But, I got warnings like: Warning: 2934 variants in span, region not called [19798 21072]
Number of variants in span (70) would exceed max-haplotypes. Variants may be missed. Consider running with a higher value of max-haplotypes! and I didn't get the output polished.*.fa files
Thanks

You need a later version of BWA which supports -x ont2d. Would not recommend using without this flag.

Thanks a lot for the answers, I succeeded to run it.

Great


xul styles in html doesn't give same results?

Ask in maildev or any other channel about this.

input type color, menulist and select examples are the ones inwhich there are alot differences


[Feature] Add parcel shipping calculator

Description
calculate the shipping cost based on the distance, weight, size
Screenshots
No response
Checklist

[X] I have checked the existing issues.
[X] I follow Contributing Guidelines of this project.
[X] I am a GSSOC'24 contributor.
[ ] I am a IWOC'24 contributor.
[ ] I am a JWOC'24 contributor.
[ ] I am a SWOC'24 contributor.

Code of Conduct

[X] I agree to follow this project's "Code of Conduct".

@Mayureshd-18  how will you be considering the price? will the price be according to fedex, delhivery or some other service?

@jessicachawla Yeah based on the Fedex Rate chart

Go ahead @Mayureshd-18

Pls provide your PR @Mayureshd-18

Please assign this issue to me

I have assigned you one issue, pls complete that first @nandinipathak2005


fix: avoid unmarshall if external dependencies is null

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 72.72%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
5158

Relevant Lines:
7093

💛  - Coveralls


Make the Metadata mandatory in the SendTransaction

Currently in daemon.rs, the SendTransaction is initialized without metadata and immediately after the metadata is set:
https://github.com/ASU-cubesat/cfdp-rs/blob/main/cfdp-core/src/daemon.rs#L749
That means in practice we never have a SendTransaction without metadata (except a few places in the unit tests).
I propose to initialize directly the SendTransaction with the metadata so it will not be behind and Option anymore. That allows to simplify a lot of methods which now raise an error that the metadata is not set.

If you agree, I can make a pull request for this.
I already did it halfway through when refactoring the SendTransaction to fix #9

Since the Send/Recv transactions have been separated now, I agree there is no reason to keep metadata behind an option for the Send side.


Adnan-Claimed-his-pixel

Checklist

[x] I ran npm test locally and it passed without errors.

[x] I only edited the _data/pixels.json file.

[x] I entered the username in the pixels.json that I'm also using to create this pull request.
[x] I acknowledge that all my contributions will be made under the project's license.

Hi @Adn0s! It seems like someone claimed that pixel in the meantime. I moved your pixel by one to Y: 44. If you'd like a different one, feel free to open another PR


Files use the wrong encoding when opened

VSCode Version: 1.11.0-insider
OS Version: Windows 8.1-Pro

Here is a gif of the bug in action:

TXT Files refrenced: iso-8859-1.txt and shift-jis.txt
Steps to Reproduce:

Open the attached text files with the corresponding encoding.
Verify the characters display properly and the encoding is correct in the bottom-right corner of VS code.
(Re)Save the files using the same encoding.
Close the files.
Open the files normally (Without specifying the encoding).
The encoding used to open the files is not the same encoding used to save the files. The characters do not display properly.
Enabling files.autoGuessEncoding does not resolve the issue, but it does change which encoding is guessed.

Note that if I run file -bi iso-8859-1.txt from Git Bash, I can see the correct encoding is returned.

@duanehutchins this is specifically why we introduced the files.autoGuessEncoding setting. If you are not having this enabled by default, we use the encoding configured in files.encoding for opening and saving files. The only exceptions are UTF-8 with BOM or UTF-16 with BOM.
As for your 2 cases I filed https://github.com/aadsm/jschardet/issues/30 and https://github.com/aadsm/jschardet/issues/31
I leave this open to allow to store an encoding for a specific file path.

As #30857 was closed as a duplicate of (partially) this and there's a real relevance to be able to set the encoding via file-path (although it likely will work for many to set per workspace, but not all people use the workspace approach and you are not unlikely to have files in the same workspace that use a different encoding): "please reconsider and opening this issue".
I guess the biggest point is how to handle conflicting situations (settings in a path vs. file specific extensions). I suggest to give the path specific setting the higher priority but the option to limit it:
        "files.encoding": "utf8",
        "file.encodingPaths": [
           {
              "pattern": "**/folderA/**,
              encoding: "windows1251"
           },
           {
              "pattern": "**/folderA/subFolder/**,
              encoding: "*"
           }
        ]

This way all files in "folderA" would get the windows1251 encoding but the files in "olderA/subFolder" would not have the setting applied (and in this case because of the global setting the utf8 encoding).


Unknown platform winphone & windows

What command are you using to see this error?
I was able to phonegap platform add windows without incident.
The platform name 'winphone' has never been supported in cordova to my knowledge.  (wp8 has!)

There is no phonegap run windows support, only phonegap run wp8. The result is the same, but phonegap run windows is more logical these days, isn't it?