'snappy' is not defined

After installing parquet-1.3.1 on windows 10. The following code was run:
with open("myparquetfile.parquet","rb") as fo:
for row in parquet.reader(fo, columns=['tconst', 'nconst']):
print(",".join([str(r) for r in row])
This errored, stack trace below:
Traceback (most recent call last):
File "c:\working\test.py", line 25, in
for row in parquet.reader(fo, columns=['tconst', 'nconst']):
File "C:\Python\Python38\lib\site-packages\parquet_init_.py", line 464, in reader
values = read_data_page(file_obj, schema_helper, page_header, cmd,
File "C:\Python\Python38\lib\site-packages\parquet_init_.py", line 283, in read_data_page
raw_bytes = read_page(file_obj, page_header, column_metadata)
File "C:\Python\Python38\lib\site-packages\parquet_init.py", line 229, in _read_page
raw_bytes = snappy.decompress(bytes_from_file)
NameError: name 'snappy' is not defined
Thx

Hi, snappy is listed as an optional dependency, but if your file is compressed with snappy then you must install parquet-python[snappy]. See https://github.com/jcrobak/parquet-python#requirements


Add "Terraform - GCP" and "Custom" deployment tabs to the Deploy Gateways page

Terraform tab explains it's a sample configuration and shows the variables pre-populated. Link to terraform/examples/gcp/nat-gateway
Custom shows the env vars needed

Closing in favor of #4019


Canceling jobs through Snakemake profiles?

Is your feature request related to a problem? Please describe.

When running cluster jobs through DRMAA, they are nicely canceled when Snakemake is stopped with Ctrl-C. This is not the case for the Slurm profile.

Describe the solution you'd like

Similarly to when running DRMAA cluster jobs, I'd like to have child jobs being killed (e.g., via scancel).

Describe alternatives you've considered

I don't think there are alternatives. I have not seen any mention of "canceling" in the Slurm or SURF profile.

Additional context

Maybe I'm missing something?

Hi @holtgrewe, I have just been reviewing a related bug report for the slurm profile (referenced above). Much of the solutions you request cannot be implemented in the profile itself, but would require modifications to the job executors, maybe even adding a specific SlurmExecutor; I believe there is an ongoing effort to refactor the executors. scancelling jobs should work, but whereas metadata for failed jobs is removed, incomplete files are not; see Persistence.cleanup. Adding a job.cleanup() statement here seems to fix that particular issue, but there may be a reason for it's absence that I'm unaware of.

Hi @percyfal thanks for your reply.
IMO it's borderline cheeky to mark --cluster/--drmaa support in Snakemake as deprecated without the profiles offering equivalent functionality. Well, the good is the enemy of the better. I'd dearly like to see profile support to reach the same level of features as --drmaa as using --time=7-00 is much nicer than saying --time=168:00:00...


Scraper: remove sections that registrar outright deleted

It seems that sometimes instead of cancelling a section, the registrar actually deletes it outright.

One of my classes (HUM 225) no longer has a lecture on the Registrar's site or TigerHub, but it's still on ReCal.

Indeed, the Registrar's site (https://registrar.princeton.edu/course-offerings/course_details.xml?courseid=013788&term=1172) shows:

But in ReCal we have:

(with enrollment for the lecture as 9/999).

Did we ever get around to this?


Pin packageversions during test project creation.

CodeGenerationPackage version is based on the package version created in
this build.
AspNetCorePackage version is based on the version of
'Microsoft.Extensions.FileProviders.Physical' used to build the test
projects.
cc @mlorbetske

cc @pranavkm, this should also reduce your work of finding/ replacing version numbers during branching.

Updated to use AssemblyInformationalVersionAttribute instead of reading the PackageVersion from a file.


Fix a typo in the podspec file

There was a typo for the deprecated and deprecated_in_favor_of properties that caused an issue when running pod install. I suggest a release type of patch for this update.

@maticzav Just coming back to let you know that I ultimately wasn't able to install the library using cocoapods as the podspec file is missing dependencies. I tried to add dependencies but wasn't able to as some are swift packages. I see that the pod is deprecated anyway, but in that case, I suggest removing the podspec file entirely so people know to only use Swift Package Manager.

@yiyingzz could you help me out - how should I specify the dependencies? Which were missing in your case?


make pre-commit use venv's even for meta hooks

I'm not a seasoned nixpkgs contributor, nor a pre-commit expert, so I'm hoping somebody comes along and shows me a better way.  This is a little hacky.
The Problem
Previously, the nixpkgs pre-commit package propagated its build inputs into user devshells.  This caused problems, so I "fixed it" to make pre-commit more self-contained.
That is, to make it behave more like an app and less like a library.  I made it so that you can't import pre-commit or its dependencies in your python code without explicitly including it in your python environment.  i.e. having it as a package in your nix shell lets you run it like an app, but not import it in your code.
This fix was premature.  It turns out that I broke meta imports(shame on me for not testing more thoroughly).
Most pre-commit hooks live in external repositories, so pre-commit clones them and creates environments for them.  meta hooks, however live in the pre-commit repo and are called directly.  So unlike the others, they're expecting pre-commit to be treated "like a library" and not "like an app".
When I switched the package from library mode to app mode, I removed pre-commit from the environment that the meta hooks were using.  Now they break like so:
Check hooks apply to the repository......................................Failed
- hook id: check-hooks-apply
- exit code: 1

/nix/store/6jx4nc20v3cfphlbypqid30q41i5vh5x-python3-3.10.11/bin/python3.10: Error while finding module specification for 'pre_commit.meta_hooks.check_hooks_apply' (ModuleNotFoundError: No module named 'pre_commit')

I'm uncertain about whether this is better or worse than it was before.  On one hand, the failure is more likely to appear.  On the other hand, it's less of a mystery and easier to work around.    They're more safely ignored than some others.  It's still no fun that they break.
My Solution
The patch included in this PR mutates the pre-commit repo so that it provides the meta hooks in the same way that any other repo might provide any other hook (see comments below for how this works).

I'll be on vacation for a little while, so I may not be working on this for the next few weeks.  I'd love to come back to find that somebody has a smarter way forward, but I wanted to post this as a draft in the meantime in case that ends up being helpful.
I feel bad for having broken this, but maybe reverting it to its previous (also broken state) is just as bad?

I think this might be overkill.  I don't need to convince pre-commit to build a separate venv  that includes... itself.  I just need to hack the path so that it knows about the non-venv instance of itself when it needs to import those internal checks.  I'm going to play around with that idea before continuing with this one.

Poking around a little after seeing this mentioned on discourse:

at first glance your previous change should have been equivalent to changing propogatedBuildInputs to buildInputs. Though you'd still end up with a python reference being passed https://github.com/NixOS/nixpkgs/blob/31b1973dc4eead85949acbfcbab0bf010de168a2/pkgs/development/interpreters/python/mk-python-derivation.nix#L207-L212
changing to buildInputs wouldn't work as buildPythonApplication relies on nix-support/propagated-build-inputs  to build an import path https://github.com/NixOS/nixpkgs/blob/31b1973dc4eead85949acbfcbab0bf010de168a2/pkgs/development/interpreters/python/wrap.sh#L115-L122
pre-commit is using ~sys.executable -m precommit.... to launch meta hooks https://github.com/pre-commit/pre-commit/blob/23df082edcf80f8501d94e8a71e237d1e69ffb15/pre_commit/clientlib.py#L212

It's unclear to me just when PYTHON_PATH is contaminated as part of the mkShell call though that can be ignored for now.
I wonder if the files in https://github.com/pre-commit/pre-commit/tree/23df082edcf80f8501d94e8a71e237d1e69ffb15/pre_commit/meta_hooks can also be wrapped the way the main function is.

Getting a reproducible error case by adding this file to the root of nixpkgs.
# .pre-commit-config.yaml
repos:
  - repo: meta
    hooks:
      - id: identity

$ nix-build -A pre-commit
$ result/bin/pre-commit install #probably?
$ result/bin/pre-commit install-hooks #probably?
$ result/bin/pre-commit run --all-files
# see error loading identity

Looking at the output wrapped program I can see the first level wrapper isn't setting PYTHON_PATH. It does set up and exports PATH and PYTHONNOUSERSITE. ($cat result/bin/precomit) The wrapped/exec'd .pre-commit-wrapped has an import statement that sets up all the needed imports to run the program. (which is why it runs)
Since the meta sub modules are just being invoked with, effectively, python -m pre-comit.... not setting PYTHON_PATH in the wrapping process means the -m call is missing all the import setup in the wrapped import statments. (see https://docs.python.org/3/using/cmdline.html#environment-variables for other envvars python looks for during invocation)
The good news is there's a simple fix to just have the wrapper set PYTHON_PATH via https://github.com/NixOS/nixpkgs/blob/31b1973dc4eead85949acbfcbab0bf010de168a2/pkgs/development/interpreters/python/mk-python-derivation.nix#L64-L66 (not this can be --set or --prefix whichever makes more sense for the expected behaviour)
diff --git a/pkgs/tools/misc/pre-commit/default.nix b/pkgs/tools/misc/pre-commit/default.nix
index ded7b3290d3c..b6fe67715cce 100644
--- a/pkgs/tools/misc/pre-commit/default.nix
+++ b/pkgs/tools/misc/pre-commit/default.nix
@@ -101,6 +101,8 @@ buildPythonApplication rec {
     deactivate
   '';

+  makeWrapperArgs = ''--set PYTHONPATH $PYTHONPATH'';
+
   # Propagating dependencies leaks them through $PYTHONPATH which causes issues
   # when used in nix-shell.
   postFixup = ''

ping @MatrixManAtYrService the above might help

@anund I'll be taking a closer look in a day or two. Thanks very much for this.

@anund As far as I can tell, adding PYTHONPATH in makeWrapperArgs does the trick, and is a much better solution than the direction I was pursuing.  Thanks again.
I have some pre-commit-related work to do.  I'm going to use this change in that work as a way of testing it a bit more thoroughly, and if I still think it scratches the itch after a few days, I'll mark it ready for review.

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/where-did-you-get-stuck-in-the-nix-ecosystem-tell-me-your-story/31415/60

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/where-did-you-get-stuck-in-the-nix-ecosystem-tell-me-your-story/31415/62

I've been testing this and I think it's good. I don't want reviewers to have to wade through the saga above, however, so I'm going to close it and make a nice clean PR.


Wip enr

ENR with nodes entering and exiting the network
changes to ProgresPerTime to update list of LiveNodes

ENR should be ready to run, there is some documentation needed to talk about certain parameters and testing is also needed


E2E: Timeline tests

If you think less scenarios also solve the case, I would prefer that.
Basics

[x] I added a line to /doc/CHANGELOG.md
[x] The PR is rebased with current master.

[x] References to issues, e.g. close #X, are in the commit messages.
[ ] The buildserver is happy.

Checklist

[ ] I have installed and I am using pre-commit hooks
[ ] I fully described what my PR does in the documentation
(not in the PR description)
[ ] I fixed all affected documentation
[ ] I fixed the introduction tour
[ ] I wrote migrations in a way that they are compatible with already present data
[ ] I fixed all affected decisions
[ ] I added unit tests for my code
[ ] I added code comments, logging, and assertions as appropriate
[ ] I translated all strings visible to the user
[ ] I mentioned every code or binary not directly written or done by me in reuse syntax
[ ] I created left-over issues for things that are still to be done
[ ] Code is conforming to our Architecture
[ ] Code is conforming to our Guidelines
(exceptions are documented)
[ ] Code is consistent to our Design Decisions

Review

[ ] I've tested the code
[ ] I've read through the whole code
[ ] Examples are well chosen and understandable

If you think less scenarios also solve the case, I would prefer that.

At least the scenarios where we actually had regressions should be tested.
Aren't they similar enough that it is not much more effort to implement all of them? They all sound useful...

Very good job! :heart:


Exchange Hybrid Writeback PublicDelegates Incorrect Description?

I believe the attribute description for PublicDelegates under the Exchange Hybrid Writeback section is incorrect. My understanding of the feature is that it allows a cloud mailbox to grant SendOnBehalfOf permission to on-premises delegates. The delegate list would then be written back to on-prem remote mailbox user accounts, which would be checked when on-premises mailboxes try to send on behalf of cloud mailboxes. The current description seems to indicate the reverse: a cloud mailbox sending on behalf of an on-premises mailbox. It may be a simple wording error. This links supports my understanding: https://support.microsoft.com/en-us/help/4039613/delegate-cannot-send-on-behalf-of-after-migration-to-office-365-hybrid  -Thanks!

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: e7abde7c-df25-bd14-574c-92858daed39d
Version Independent ID: 6652a5bc-4985-d45e-36fb-54da408e5e54
Content: Attributes synchronized by Azure AD Connect
Content Source: articles/active-directory/hybrid/reference-connect-sync-attributes-synchronized.md
Service: active-directory
Sub-service: hybrid
GitHub Login: @billmath
Microsoft Alias: billmath

@chk1982 , Thanks for raising the issue. We will investigate and update you.

@billmath Could you please help get the details in this query verified with product engineering and the document updated as per the customers recommendations?

@chk1982 Thank you for the feedback.  I have created a backlog work item for this and will be working on this in the coming months.  I will send a follow-up once this has been updated.  Thanks!
#please-close


Functional consumer can't support manual acknowledge

Describe the issue
Functional consumer can't support manual acknowledge when I'm setting the property: "spring.cloud.stream.rabbit.bindings.log-in-0.consumer.acknowledge-mode=MANUAL"
To Reproduce
Steps to reproduce the behavior:

rabbit binder
set property: spring.cloud.stream.rabbit.default.consumer.acknowledge-mode=MANUAL
@Bean with  Consumer<Message>
I can't manual acknowledge.

Version of the framework
spring-cloud-stream Hoxton.SR8
Additional context
Delaying Messages is support?

I can't manual acknowledge.

Please explain why. The channel and delivery tags are in the Message<?> headers.
(You need to consume a spring-messaging Message<?> not a Spring AMQP Message).

Thank you very much for that ! emmm, can I ask an other question? how can I get the current acknowledge-mode ? I want to  ack dynamically...

thank you very much again!


Rebase image on Debian

A number of improvements and updates to the docker image:

Rebase on Debian 8.4
Remove some extraneous packages
Use an entrypoint script instead of initd
Remove boot2docker from the README
Update to MemSQL Ops 5.0.3

LGTM


macOS Sierra crash

On macOS Sierra (10.12.3) every example and other usage fails with: signal: killed.

Turned out that this wasn't an issue with gosigar but an issue with Xcode 8.3 and Golang 1.8 https://github.com/golang/go/issues/19734


Add setSubredditSticky to api/modTools

Adds support for the endpoint needed to sticky/unsticky posts (AKA pin/unpin announcements).
👓 @scarow @birakattack

:haircut_man:

:haircut_man:

:fish:

7efcf0ae25934384e277d57973f8fe09cdebabc3 included in release v3.34.0


Can't disable Oracle Cloud monitoring selectively

Whatever you do it is impossible to disable Oracle Cloud Monitoring.
If you have in application.yml
micronaut:
  metrics:
    enabled: false
    export:
      oraclecloud:
        enabled: false
        namespace: graemerocher
        resourceGroup: ocidemo

And application-oraclecloud.yml contains:
micronaut:
  metrics:
    enabled: true
    export:
      oraclecloud:
        enabled: true
        namespace: graemerocher
        resourceGroup: ocidemo

The monitoring fails to start the application when running on Oracle Cloud.

I think this was fixed in https://github.com/micronaut-projects/micronaut-oracle-cloud/pull/161/files and also we're using it in mushop atm , disabled in application.yaml https://github.com/pgressa/oraclecloud-cloudnative/blob/master/src/api/src/main/resources/application.yml#L11 and enabled in oraclecloud https://github.com/pgressa/oraclecloud-cloudnative/blob/master/src/api/src/main/resources/application-oraclecloud.yml#L5


Adding the same task twice leads to errors.

If you add the same task twice that will lead to the task chain being broken. It is possible to check against this by adding the following here
     if (aTask.iScheduler == this)
         return;

Similarly it might be good in deleteTask to check if the task to be deleted is actually part of the scheduler. Also during deletion set aTask.iScheduler = NULL. Although this would mean you might need to delete high priority task differently (check that they are part of the high priority scheduler).

Fixed in testing branch. Would you please test/confirm?

Implemented in v2.5.0


Allowed digits at the end of method return type

Fixes #188 - inclues tests. The regex for type-annotation was looking for [a-zA-Z_$] (the regex used for the first character) as the pattern for the last character rather than [\w$].
I have a plugin that removes whitespace at the end of lines so there are some rogue changes in here that I missed, which can be removed if required.

Hi @RichieAHB, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!

In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes. I promise there's no faxing. https://cla.microsoft.com.

TTYL, MSBOT;

@RichieAHB, Thanks for signing the contribution license agreement so quickly! Actual humans will now validate the agreement and then evaluate the PR.
Thanks, MSBOT;

Hi @RichieAHB , this PR is similar to PR #199 . I see you have a good test here. You can either leave some comments on PR #199, or wait for that PR to be merged in and send out a PR to improve those changes.

Sorry for the delay. the original issue should be fixed now by https://github.com/Microsoft/TypeScript-TmLanguage/pull/257


O365API Logging Logic App errors

I followed the configuration process to setup and install the logic app to feed data into the custom O365API Log Analytics logging source and read that when there is no data the "Parse JSON" step will fail with":
InvalidTemplate. Unable to process template language expressions in action 'Parse_JSON' inputs at line '1' and column '2868': 'The template language expression 'body('HTTP')[0]' cannot be evaluated because array index '0' cannot be selected from empty array. Please see https://aka.ms/logicexpressions for usage details.'.
It's super annoying because that means a majority of the runs will come back with a failure code.
However the times when there is data and gets to the "Send Data" step I'm finding that these inputs come back with the following as part of my raw OUTPUT:
"body": {
"error": {
"code": 400,
"message": "A value for subdomain must be specified in token:username.",
"source": "logic-apis-eastus.azure-apim.net",
"path": "",
"clientRequestId": xxxxxx
}
When I look thru my raw INPUT i get the following:
{
"method": "post",
"headers": {
"Log-Type": "O365API",
"time-generated-field": "CreationTime"
},
"path": "/api/logs",
"host": {
"connection": {
"name": "/subscriptions/xxxxxxxxxxxxxxxxxxxxxxx/resourceGroups/xxxxxxxxxx/providers/Microsoft.Web/connections/azureloganalyticsdatacollector-Get-O365Data"
}
},
Along with a large blob of data, so I know that its connecting to my tenant but its failing with the 400 error message.
Please advise

Hi @thetootall
I think we have a bug.  Let me take it with @petebryan

Thanks @thetootall we heard the feedback on the failure situation when there is no Teams data to parse, we will look at updating the logic app so that it has a conditional flow where if no data is returned it just ends the execution rather than failing.
With the "Send Data" step issue the input you are seeing is the correct format. Looking at the API documentation the most common cause of the 400 response is an issue with the content or the workspace.
To help with this can you please check that the Send Data Step is correctly connected to the Workspace you have, also can you please confirm if the blob of data you are seeing being sent appears to be json data (it should be). In addition could you let us know what setting you have set of the Send Data step.
Its worth noting that the Send Data action is still in preview and we may just be seeing an issue with the action. One thing you could try is removing this step in the Logic App designer and re-adding it.

@petebryan I checked in Designer view within the Logic App and it had a warning symbol,

so I checked code view to cross reference:
"parameters": {
    "$connections": {
        "value": {
            "azureloganalyticsdatacollector": {
                "connectionId": "/subscriptions/**<subscriptionID>**/resourceGroups/**<resourceGroup>**/providers/Microsoft.Web/connections/azureloganalyticsdatacollector-Get-O365Data",
                "connectionName": "azuresentinel-Get-O365Data",
                "id": "/subscriptions/f**<subscriptionID>**/providers/Microsoft.Web/locations/**<location>**/managedApis/azureloganalyticsdatacollector"
            }
        }
    }
}

Looking at the my Subscription ID, Resource Group name, and Location all of them look accurate.
So edited the step and here it was prompted to provide my workspace ID and workspace key in a new connection

After i saved the changes and generated some activity in Teams, I was able to see the logic app fire with Succeeded however then back to the known error with no data.

One thing of note: I was not prompted for the workspace key when I deployed the Logic App Template at the bottom of this page - only the AAD App Client Id / App Secret / Tenant ID
https://github.com/Azure/Azure-Sentinel/tree/master/Playbooks/Get-O365Data
The Template did seem to do a good job of getting everything else setup - maybe adding additional info to specify the workspace info in a future version?
Thanks again for the help!

@thetootall got it.  I'm researching this now,
{
"type": "Microsoft.Web/connections",
"apiVersion": "2016-06-01",
"location": "[parameters('logicAppLocation')]",
"name": "[parameters('azureloganalyticsdatacollector-2_name')]",
"properties": {
"api": {
"id": "[concat('/subscriptions/',subscription().subscriptionId,'/providers/Microsoft.Web/locations/',parameters('logicAppLocation'),'/managedApis/azureloganalyticsdatacollector')]"
},
"displayName": "[parameters('azureloganalyticsdatacollector-2_displayName')]",
"parameterValues": {
"username": "[parameters('azureloganalyticsdatacollector-2_username')]",
"password": "[parameters('azureloganalyticsdatacollector-2_password')]"
}
}
}
it appears i can provide workspace id and key as username and password parameters!
Im asking making many improvements to handle things like when no data is returned

@thetootall FYI.  Just submitted PR #639
Note, i tried the above and it allowed me to pass the workspace id but not key.  so after deployment, as usual, you need to authorize the connections by going to the resource, click edit api connection.  click authorize or for log a enter the workspace key and click save.
which we shared here.
https://github.com/Azure/Azure-Sentinel/tree/master/Playbooks#each-folder-contains-a-security-playbook-arm-template-that-uses-microsoft-azure-sentinel-trigger


Unnecessary import magic will conflict with other layers

caas_base.import_layer_libs appears to be doing magic imports of charms/layer as a convenience. This will cause conflicts with other layers, which are expecting standard Python packaging rules in this shared location. If caas_base needs magic imports, it should do so in a distinct namespace to avoid conflicts with other layers.

Oh, this is also duplicated in the base layer :-(
Moving there.


Merged PR 32131: Updated changelog for v7.2.23

PR Summary
Updated changelog for v7.2.23
This pull request updates the changelog for version 7.2.23 with new build and packaging improvements and documentation updates.
Changelog Updates:

CHANGELOG/7.2.md: Added a new section for version 7.2.23, including details on build and packaging improvements and documentation updates.

Build and Packaging Improvements:

Bumped .NET to 6.0.425.
Added feature flags for removing network isolation.
Bumped PackageManagement to <IP_ADDRESS>.
Skipped build steps that do not have exe packages.
Used correct signing certificates for RPM and DEBs.
Fixed exe signing with third-party signing for WiX engine.
Fixed error in the vPack release, debug script that blocked release.
Added vPack release.
Fixed nuget publish download path.

Documentation and Help Content:

Updated docs sample nuget.config.

AI description  (iteration 1)
PR Classification
Documentation update.
PR Summary
Updated the changelog for version 7.2.23 with build and packaging improvements, and documentation updates.

CHANGELOG/7.2.md: Added details for version 7.2.23, including .NET bump to 6.0.425, feature flags for network isolation, and various fixes and improvements in build steps and signing certificates. Updated documentation sample nuget.config.

PR Context

PR Checklist

[x] PR has a meaningful title

Use the present tense and imperative mood when describing your changes

[x] Summarized changes
[x] Make sure all .h, .cpp, .cs, .ps1 and .psm1 files have the correct copyright header
[x] This PR is ready to merge and is not Work in Progress.

If the PR is work in progress, please add the prefix WIP: or [ WIP ] to the beginning of the title (the WIP bot will keep its status check at Pending while the prefix is present) and remove the prefix when the PR is ready.

Breaking changes

[x] None
OR
[ ] Experimental feature(s) needed

[ ] Experimental feature name(s):

User-facing changes

[x] Not Applicable
OR
[ ] Documentation needed
- [ ] Issue filed:

Testing - New and feature

[x] N/A or can only be tested interactively
OR
[ ] Make sure you've added a new test if existing tests do not effectively test the code changed

Tooling

[x] I have considered the user experience from a tooling perspective and don't believe tooling will be impacted.
OR
[ ] I have considered the user experience from a tooling perspective and opened an issue in the relevant tool repository. This may include:

[ ] Impact on PowerShell Editor Services which is used in the PowerShell extension for VSCode
(which runs in a different PS Host).

[ ] Issue filed:

[ ] Impact on Completions (both in the console and in editors) - one of PowerShell's most powerful features.

[ ] Issue filed:

[ ] Impact on PSScriptAnalyzer (which provides linting & formatting in the editor extensions).

[ ] Issue filed:

[ ] Impact on EditorSyntax (which provides syntax highlighting with in VSCode, GitHub, and many other editors).

[ ] Issue filed:

@jshigetomi The markdown lint is failing for the file changed in this PR. For a markdown file change, you should have the markdown related CIs successfully pass before merging. Please fix it:


suppress warnings about ignored files

Some files may have been set to be ignored via .eslintignore file, but still make there way thru the Browserify pipeline. This includes items like packages from NPM or Bower.
As a result, you will get a bunch of warnings like:
foo.js
0:0  warning  File ignored because of your .eslintignore file. Use --no-ignore to override.
✖ 1 problem (0 errors, 1 warning)
(See http://eslint.org/docs/user-guide/configuring#ignored-file-warnings)
This change will weed these errors out since we don't report errors on ignored files.

@jardilio I decided to go about this a different way. Thank you for your PR though! This functionality will go out in 2.1 via https://github.com/yaycmyk/eslintify/pull/11

@yaycmyk I believe your commit is a bit different. I was looking to still get feedback on other warnings, just not this 1 warning that was really a side effect of the fact that the transfor runs against all files thru the pipeline and doesn't respect eslints ignore rules. If I'm looking at this correctly, you are just shutting off all warnings which is a different use case.

agreed with @jardilio.  most warnings are desirable.  just not these ones that come from files that are configured to be ignored (like in eslintrc) but are still getting passed through the linter by browserify due to require() statements

Okay - I will look into this and see if there's a solution that doesn't depend on trying to scrape the warning message, as that could change at any time.

@yaycmyk i created https://github.com/eslint/eslint/pull/6305 which would give you a simple flag to pass in for this

Oh sweet, yeah that would be much better!

fyi - https://github.com/eslint/eslint/issues/6356

Awesome!

Eslint 3.0.1, 3.1.1 and 3.2.0 releases now apparently contain this change.


Investigate SSR for RTK Query

We had a couple questions about "will RTK Query support SSR?"
None of us maintainers have any real experience with SSR.  So, requests for more details from the community:

How do you currently handle SSR work with vanilla Redux / RTK?
What's the data flow sequence like there?
How does SSR work with non-Redux options like React-Query, SWR, Urql, or Apollo?
What use cases would you like to have working here?

Possibly related docs/issues:

https://github.com/vercel/swr/issues/11
https://dev.to/able/prefetching-data-in-a-next-js-application-with-swr-c63
https://react-query.tanstack.com/docs/guides/ssr

When I've done SSR with Redux in the past the basic flow has been

dispatch actions on the server (awaiting async thunk actions as necessary: not sure how that would work with other middlewares)
render your react app (rendering on the server is single pass)
serialize the state of the redux store as JSON (sent to the client serialized in the dom or via api call)
use that json as the initial state of the redux store when rendering on the client

There are 2 basic approaches for how the libs you mentioned support SSR.

Fetch initial data outside of React then pass it into the tree via props
Multiple single-pass renders. The first render kicks off fetching (which is then stored in some external data cache outside of the react tree). Once fetches have resolved a second render happens. This time the data is in the cache so your app renders fully.

The first approach has the advantage of being relatively simple to implement and reason about, but because you have to fetch the initial data yourself it can be difficult to know what data deeply nested components need. On the other hand, multiple renders can be very tricky to implement (especially if you're working within the confines of something like Nextjs). Eventually Suspense for Data Fetching™ will give us the utility of the second approach with the simplicity of the first and we can all stop talking about this and take naps instead.
Of the libs you mentioned, only SWR doesn't have any guide or support for the second approach. All support the first approach (React-Query and SWR hooks accept initial data, Urql and Apollo caches can be populated before being provided in the react tree).  https://github.com/FormidableLabs/react-ssr-prepass might be a useful resource for y'all - it's what urql uses to do the multiple renders thing, but has no urql-specific bits in it.
It looks like the first approach should be possible with RTK Query now - just await dispatch(api.getWhatever.initialize()) before rendering the react app on the server. I can try to whip up a simple nextjs example of that to see if I'm completely off-base

K, that was harder than expected but easier than I feared 😅. My efforts can be found at https://github.com/JNaftali/rtk-query-nextjs-example or https://codesandbox.io/s/sad-sun-deczo - data is successfully fetched both server side and client side.
2 issues I ran into:

Something about fetchBaseQuery does not play well with whatever nextjs uses to mimic fetch on the server (https://www.npmjs.com/package/isomorphic-fetch maybe?). I worked around it, but what I did is def not production ready. Assuming this problem also happens when using node-fetch (which is pmuch the standard for using fetch in node) this should probably be fixed in RTK if you're interested in supporting SSR. Restore the default baseQuery in src/services/pokemon.js to reproduce.
Nextjs for some reason has a stick up it's butt about returning undefined from getServerSideProps. I wrote a removeUndefined util to swap in null instead for now. This issue is definitely nextjs specific, up to you if you care.

Most of src/store.js that wasn't copied from the RTK Query docs was copied from https://github.com/vercel/next.js/blob/canary/examples/with-redux/store.js

Used the with-redux-toolkit Next's example as well. Here's my repo So far aso well, it seems to work without errors.

Redux is initialized at server/side, you can also dispatch on the server.
You then pass the redux state via app props.
RTK-Query is simply fetching on the client-side and seems to work correctly.

I was initially worried you might have to do window type check or check if the component has mounted. Problem is, I don't think someone should be using RTK-Query on the server-side right (thats why I'm using RTK client-side)? I think If need be, I'd rather use fetch and pass that to the rtk-query reducer as initial state.
Let me know If I can do anything else that might be helpful.

I think @JNaftali summarized the gist of it perfectly! ❤ Having implemented the react-query SSR-solution, I'll go ahead and add some extra detail/considerations that came up when doing that. This is tricky stuff to both grok and write about, so please ask questions or grab me for a chat if I'm not expressing myself clearly enough. 😁
Hydration on page navigation
While there are a lot of detail and caveats that goes into this, I think RTK Query can support SSR in a bunch of cases in its existing form, with an important exception, Next.js getStaticProps and getServerSideProps. The reason is that Redux currently only supports hydrating data on store creation. So, these would currently work for the initial page load but I don't think the current API's allows for implementing a good solution for page navigations. @JNaftali tries to work around this in the demo by creating a new store on each page navigation with the state from the existing store merged with the state from getServerSideProps. This is a very clever way to try to work around limitations in the existing API, but I don't think it will work for a few reasons, main one being that all existing subscriptions will be towards the old store.
Even if the subscriptions could be moved to the new store, I think performance would be bad and I think another issue would be any asynchronous work currently pending in middlewares.
This really is complex and I'm struggling for a way to express it in a way that makes sense, but, the key thing to note here is that both getServerSideProps and getStaticProps run on each page navigation and they run on the server. Since we want to use the existing API-abstractions from RTK Query to fetch data even in those functions, there needs to be a way to hydrate/merge the serialized output of those functions into an existing store on the client side.
Another caveat with Next.js here is that there are currently no place where you can receive data from the server and do something with it before render. You can see this in the official with-redux example for Next.js (used in @JNaftali's demo), in that the Redux store actually gets created inside of render. The same goes for any hydration that needs to happen on page navigation, any solution needs to happen inside of render. It can't happen in an effect, since those does not run on the server, so initial page render would break for SSR.
The React Query SSR-docs might be a decent source of inspiration for how we designed the API there.
The Hydration tests could also be valuable to look at, at least what different kinds of cases we are trying to cover.
Yet another caveat with Next.js is that since these functions run on the server where you don't have access to client state, you can't really know if you need to fetch new data or not, you will always fetch data on page navigation even if you have "fresh" data in the cache on the client. Not a huge deal and something you kind of have to live with. You might have to account for the case where the client already has fresher data and avoiding merging the "older" data from the server though..
More notes on hydration

You need to create a new store in each getServerSideProps/getStaticProps for the API-abstractions to work. The pattern to document here should probably be to create a "minimal store" with only the RTK Query-reducers added in, to avoid having to create and dehydrate an entire store each time?
You currently de/rehydrate the timestamps etc as well as the data. I think this is nice, since that way determining when a query is "stale" is based on when it was actually fetched, even if that was on the server. This does require the server and client to have the correct time though or you might run into bugs. Also, make sure you use UTC timestamps to avoid timezone pains.
It might be worth thinking about how errors plays into hydration. Error objects are often hard to serialize/deserialize, is there a way for users to catch errors and convert them into something serializeable before they get stored in the state? Should queries with errors be de/rehydrated at all by default, or refetched on the client instead? Should users be able to control this? Also, some errors might be catastrophic and need to send a 500-error or something, while some can be recovered.

Refetching queries after initial render on the client
This is something I'm not sure if RTK Query handles today? I don't really have time to test, but if a query has become stale since it was fetched on the server (for example if the html is cached in a CDN, but the query has a cachetime that is shorter), you probably want to refetch that on the client after the initial render has happened?

Oh, and a note on a part of @JNaftali's example that I know from experience can be hard to understand when not used to Next.js and SSR. On the initial page render that happens on the server, there are actually two stores getting created. One store is created in getServerSideProps when that runs. This store gets dehydrated and then a new store is created inside of render which rehydrates that data. So there is actually a de/rehydration going on between two stores on the server as well.
On the client, yet another store is created which is also initialized with the data from getServerSideProps.

I'll probably need to re-read all this a few more times over the next days (and try stuff out) to completely wrap my head around it, so this are my first thoughts that might be based on completely wrong assumptions.
Errors
For errors, we don't have to assume non-serializable data for now. Everything that is thrown in baseQuery runs through createAsyncThunks miniSerializeError function that strips away everything unexpected/non-serializable.
Errors from non-2xx do not go this way, but in baseFetchQuery they just contain the request status and response body.
Other baseQuery implementations could theoretically return non-serializable errors there, but in that case, RTK's serializableStateInvariantMiddleware would warn in that case.
Rehydration/cache merging
If I have understood this correctly, my theory would be that we could prevent a lot problems by not trying to hydrate/rehydrate the api as a part of the full redux store here (potentially overriding values), but maybe dispatching some kind of rehydrateSSRCache action with server-side cache data. That could be merged selectively by the according reducers into potentially pre-existing api cache state.
That action would probably contain the current api state on the server and current timestamp of the server. This way, the client could just calculate a const diff = clientTimeStamp - serverTimeStamp, adjust all received cache value timestamps accordingly and then only override state that is newer.
Component<->endpoint subscriptions would not be synced, but immediately re-established on the client by rendering anyways. There would need to be a grace period of a few seconds after such a re-hydration-action during which the middleware pruning "state state" would simply pause, to allow all component subscriptions to settle into a good state.

This really is complex and I'm struggling for a way to express it in a way that makes sense, but, the key thing to note here is that both getServerSideProps and getStaticProps run on each page navigation and they run on the server

@Ephem
One small correction here. getStaticProps only runs on each page nagivation on dev mode. In production it only runs  once, during the build time.

I'll probably need to re-read all this a few more times over the next days (and try stuff out) to completely wrap my head around it, so this are my first thoughts that might be based on completely wrong assumptions.

This has taken me years to wrap my head around, it's a really complex domain and hard to communicate. 😄 That said, from your response it does seem you've definitely understood the gist of it!

For errors, we don't have to assume non-serializable data for now

Awesome! I haven't looked at how this is handled in RTK/RTK Query at all so might very well be a non-issue, just thought I'd point out that it's something extra to think about when it comes to SSR.

... but maybe dispatching some kind of rehydrateSSRCache action with server-side cache data

I wanted to focus on the challenges and not go into solutions too much to keep the post manageable, but I definitely think this is the way to go! It's nice that this approach keeps this concern separated into RTK Query.
Since I don't know of any way currently to do this outside of render in Next.js right now, I imagine you might want to abstract away dispatching that action into a useHydrate-hook or <Hydrate>-component or whatever you think makes sense for RTK Query (React Query provides both) to hide the ugliness and avoid teaching users it's okay to dispatch in render..

This way, the client could just calculate a const diff = clientTimeStamp - serverTimeStamp

The problem with this is that the response might be cached indefinitely between the server rendering the html markup and the client hydrating it, so the serverTimeStamp would be outdated. I haven't come up with a way to solve this other than just relying on the server and client having their time set properly. 🤷

@awareness481 Good point, thanks for clarifying!
I think what I meant to say was that from the clients perspective, the code that fetches the data from getStaticProps that was generated during build time runs on every page navigation, so the challenge is still the same. The data that was generated at build still needs to be rehydrated during page navigation. Still a very good clarification, there is so much nuance with this stuff. 🙈

@Ephem's comments were, indeed, right on the money. To sidestep the issues about how nextjs does ssr I decided to make another example which should be free of such bugs using Razzle.  Razzle, if you're not familiar, has much less magic than nextjs - it's pmuch just a preconfigured version of webpack + express.
I believe (although I am not certain) that it would still be possible to do this using nextjs, but when configuring the store I would have to make the reducer handle a global action to replace the state wholesale (since in nextjs I wouldn't be able to get the server rendered data in time to pass it in to preloadedState as I initialize the store).
Notably I still get an error when using fetchBaseQuery - something about how RTK query uses signals is not available in node and I don't know what.
Hope this is helpful!

@Ephem's comments were, indeed, right on the money. To sidestep the issues about how nextjs does ssr I decided to make another example which should be free of such bugs using Razzle - https://github.com/JNaftali/razzle-rtk-query-example.  Razzle, if you're not familiar, has much less magic than nextjs - it's pmuch just a preconfigured version of webpack + express.
I believe (although I am not certain) that it would still be possible to do this using nextjs, but when configuring the store I would have to make the reducer handle a global action to replace the state wholesale (since in nextjs I wouldn't be able to get the server rendered data in time to pass it in to preloadedState as I initialize the store).
Notably I still get an error when using fetchBaseQuery - something about how RTK query uses signals is not available in node and I don't know what.
Hope this is helpful!

Can you share a link to this repo or CSB? If your using node-fetch, the signal usage should be the same.

@msutkowski I made a branch that demonstrates the error - https://github.com/JNaftali/razzle-rtk-query-example/tree/fetchbasequery-not-working. I also copied the error (as copied from the redux state) into a gist  - https://gist.github.com/JNaftali/6b7ca6be39a1374c346c70cd1883bba5

@phryneas @JNaftali Just looked through this. The quickest fix is to swap isomorphic-fetch for cross-fetch.
The longer version is to override the razzle config to not mangle output in the terser plugin, which doesn't seem worth it to me. The redux-toolkit types are correct like @phryneas says, but the razzle config is dropping the class when mangling.

I hadn't heard of cross-fetch! If that works better I'd be happy to use it. Not sure it'd be so easy to switch if I were using something like Nextjs that comes with isomorphic-unfetch built in, but for razzle that seems like a fine solution. Thanks!

@JNaftali I'm going to do some experimenting this weekend and see what I can come up with. I've only used Next for prototypes and debugging misc. things, so my exposure is pretty limited. Thanks for providing the repo to help us solve the razzle case.

Another solution might really be just to import "isomorphic-fetch" at top of all files that use createAsyncThunk.

Couldn't figure out how to get cross-fetch to solve all my problems - the polyfill version (import 'cross-fetch/polyfill') had the same problem as isomorphic-fetch, and if there's a way to pass a fetch implementation for fetchBaseQuery` to use I couldn't figure it out.
Putting the following at the top of my services/pokemon.ts file does indeed seem to fix things:
import fetch, { Headers, Request, Response } from 'node-fetch';
import AbortController from 'abort-controller';

global.fetch = fetch as any;
global.Headers = Headers as any;
global.Request = Request as any;
global.Response = Response as any;
global.AbortController = AbortController;```

I'm confused why putting that at the top of `server.tsx` (or `index.ts`) doesn't work though. It's the entrypoint! It runs before everything else by definition! Maybe there's something about modules in JS that I don't understand 🤔

@JNaftali Thanks for diving into this. I didn't actually try to  yarn start:prod 🤦 . I'm going to open a quick PR to allow fetchBaseQuery to take a custom fetch fn, which solves all of that, minus the AbortController problem. I did try this with cross-fetch as well, and it also works, but that also doesn't set a global AbortController.
I'll try to get a Next.js repro going as well to see what steps are needed there.

Feel free to ping me on Discord in Reactiflux if you run into any more issues :)

@msutkowski Nice work! My understanding was that this issue was broader than just the fetchBaseQuery-thing though, was it accidentally closed prematurely?

Probably an auto-close due to this issue being mentioned in the closed PR :)

Yup, sorry about that. Shouldn't have been closed.

Hello everybody,
Many thanks for this very insightful thread. As rightly catched by @JNaftali , it looks like that there are at least 2 bug to enable SSR with Next.js :

first one is to allow custom fetch based on cross-fetch (AbortSignal error), thanks to @msutkowski  for the fix #105 🎉
the second one seems related to the error field in the apiSlice. Indeed, it seems that error is explicitly set to undefined when the request is fulfilled. However, it appears that error shouldn't return undefined to be able to be supported by getServerSideProps in Next.js (see : https://github.com/vercel/next.js/discussions/11209). Here is a fork of @JNaftali repo where baseQuery returns{ error: await response.json() } instead of {  data: await response.json() } :

https://github.com/gfortaine/rtk-query-nextjs-example
By the way, a PR has also been prepared #152

Hello everybody,
Many thanks for this very insightful thread. As rightly catched by @JNaftali , it looks like that there are at least 2 bug to enable SSR with Next.js :

first one is to allow custom fetch based on cross-fetch (AbortSignal error), thanks to @msutkowski  for the fix #105 🎉
the second one seems related to the error field in the apiSlice. Indeed, it seems that error is explicitly set to undefined when the request is fulfilled. However, it appears that error shouldn't return undefined to be able to be supported by getServerSideProps in Next.js (see : https://github.com/vercel/next.js/discussions/11209). Here is a fork of @JNaftali repo where baseQuery returns{ error: await response.json() } instead of {  data: await response.json() } :

https://github.com/gfortaine/rtk-query-nextjs-example
By the way, a PR has also been prepared #152

@msutkowski it looks like that when using cross-fetch, the prepareHeaders function is not taken into account (the header Authorization is missing in our case, by example). But it seems OK with isomorphic-unfetch.

@msutkowski it looks like that when using cross-fetch, the prepareHeaders function is not taken into account (the header Authorization is missing in our case, by example). But it seems OK with isomorphic-unfetch.

@msutkowski It looks like that Node 15 has built-in support for AbortController and AbortSignal : https://github.com/axios/axios/issues/3506
Thus, by using next branch with Node 15, it seems that we finally managed to get SSR working with RTK Query 🎉  :
https://github.com/gfortaine/rtk-query-nextjs-example

@msutkowski It looks like that Node 15 has built-in support for AbortController and AbortSignal : https://github.com/axios/axios/issues/3506
Thus, by using next branch with Node 15, it seems that we finally managed to get SSR working with RTK Query 🎉  :
https://github.com/gfortaine/rtk-query-nextjs-example

I'm closing everything here now. If there's any need for further discussion, that should take place in a new issue over at https://github.com/reduxjs/redux-toolkit/


failed setting default values for vsphere machine configs: failed importing template into library

What happened:
2022-09-30T15:33:49.479+1100	V0	Creating template. This might take a while.
2022-09-30T15:33:49.479+1100	V6	Executing command	{"cmd": "/usr/bin/docker exec -i -e GOVC_PASSWORD=***** -e GOVC_URL=******** -e GOVC_INSECURE=true -e GOVC_DATACENTER=*** -e GOVC_USERNAME=***** eksa_1664512421858191080 govc library.info -json eks-a-templates/bottlerocket-v1.23.9-kubernetes-1-23-eks-5-amd64-9fd2167"}
2022-09-30T15:33:49.642+1100	V2	Importing template from ova url	{"ova": "https://anywhere-assets.eks.amazonaws.com/releases/bundles/17/artifacts/ova/1-23/bottlerocket-v1.23.9-eks-d-1-23-5-eks-a-17-amd64.ova"}
2022-09-30T15:33:49.642+1100	V4	Importing template	{"ova": "https://anywhere-assets.eks.amazonaws.com/releases/bundles/17/artifacts/ova/1-23/bottlerocket-v1.23.9-eks-d-1-23-5-eks-a-17-amd64.ova", "templateName": "bottlerocket-v1.23.9-kubernetes-1-23-eks-5-amd64-9fd2167"}
2022-09-30T15:33:49.642+1100	V6	Executing command	{"cmd": "/usr/bin/docker exec -i -e GOVC_INSECURE=true -e GOVC_DATACENTER=**** -e GOVC_USERNAME=***** -e GOVC_PASSWORD=***** -e GOVC_URL=***** eksa_1664512421858191080 govc library.import -k -pull -n bottlerocket-v1.23.9-kubernetes-1-23-eks-5-amd64-9fd2167 eks-a-templates https://anywhere-assets.eks.amazonaws.com/releases/bundles/17/artifacts/ova/1-23/bottlerocket-v1.23.9-eks-d-1-23-5-eks-a-17-amd64.ova"}
2022-09-30T15:33:51.502+1100	V9	docker	{"stderr": "govc: POST https://******/rest/com/vmware/content/library/item/updatesession/file/id:?~action=add: 404 Not Found\n"}
2022-09-30T15:33:51.502+1100	V0	❌ Validation failed	{"validation": "vsphere Provider setup is valid", "error": "failed setting default values for vsphere machine configs: failed importing template into library: importing template: govc: POST https://*******/rest/com/vmware/content/library/item/updatesession/file/id:?~action=add: 404 Not Found\n", "remediation": ""}
How to reproduce it (as minimally and precisely as possible):
eksctl anywhere create cluster -f eksa-mgmt-cluster.yaml -v 9
Anything else we need to know?:
apiVersion: anywhere.eks.amazonaws.com/v1alpha1
kind: Cluster
metadata:
  name: mgmt
spec:
  clusterNetwork:
    cniConfig:
      cilium: {}
    pods:
      cidrBlocks:
      - <IP_ADDRESS>/16
    services:
      cidrBlocks:
      - <IP_ADDRESS>/12
  controlPlaneConfiguration:
    count: 2
    endpoint:
      host: "*********"
    machineGroupRef:
      kind: VSphereMachineConfig
      name: mgmt-cp
  datacenterRef:
    kind: VSphereDatacenterConfig
    name: mgmt
  externalEtcdConfiguration:
    count: 3
    machineGroupRef:
      kind: VSphereMachineConfig
      name: mgmt-etcd
  kubernetesVersion: "1.23"
  managementCluster:
    name: mgmt
  workerNodeGroupConfigurations:
  - count: 3
    machineGroupRef:
      kind: VSphereMachineConfig
      name: mgmt
    name: md-0

---
apiVersion: anywhere.eks.amazonaws.com/v1alpha1
kind: VSphereDatacenterConfig
metadata:
  name: mgmt
spec:
  datacenter: "****"
  insecure: true
  network: "*******"
  server: "******"
  thumbprint: "*******"

---
apiVersion: anywhere.eks.amazonaws.com/v1alpha1
kind: VSphereMachineConfig
metadata:
  name: mgmt-cp
spec:
  datastore: "********"
  diskGiB: 25
  folder: "EKS Anywhere"
  memoryMiB: 8192
  numCPUs: 2
  osFamily: bottlerocket
  resourcePool: "Eks_anywhere"
  template: ""
  users:
  - name: ec2-user
    sshAuthorizedKeys:
    - ""
---
apiVersion: anywhere.eks.amazonaws.com/v1alpha1
kind: VSphereMachineConfig
metadata:
  name: mgmt
spec:
  datastore: "********"
  diskGiB: 25
  folder: "EKS Anywhere"
  memoryMiB: 8192
  numCPUs: 2
  osFamily: bottlerocket
  resourcePool: "Eks_anywhere"
  template: ""
  users:
  - name: ec2-user
    sshAuthorizedKeys:
    - ""
---
apiVersion:` anywhere.eks.amazonaws.com/v1alpha1
kind: VSphereMachineConfig
metadata:
  name: mgmt-etcd
spec:
  datastore: "********"
  diskGiB: 25
  folder: "EKS Anywhere"
  memoryMiB: 8192
  numCPUs: 2
  osFamily: bottlerocket
  resourcePool: "Eks_anywhere"
  template: ""
  users:
  - name: ec2-user
    sshAuthorizedKeys:
    - ""
---

Environment:
eksctl version
0.111.0-dev+9a99e9218.2022-09-09T18:36:17Z
eksctl anywhere version
v0.11.3
VMware vCenter Server 7.0.3
govc 0.29.0

Hello,
This is a permission problem.
the permissions in this document were not sufficient for me : https://anywhere.eks.amazonaws.com/docs/reference/vsphere/vsphere-preparation/
I selected all permission in "Content Library" for the global role, and now it works.
regards

Thanks for the feedback. I will verify and update our doc once confirmed.

@antoine-faisandier were you following https://anywhere.eks.amazonaws.com/docs/reference/vsphere/vsphere-preparation/#create-and-define-user-roles and create the right user permission? especially #3 you need a default admin role on the directory that stores the template and VMs. I don't think you need all permission for global role.


Revert "toYaml - Fix #3470 and #3410's trailing \n issues"

Reverts kubernetes/helm#3837
closes #3981

@georgepapas would you mind giving this a test and see if this fixes your issue? Thanks!

@bacongobbler Sure, what is the best way to get a distribution that has this change? Is there a tag I can use, or should I build locally?

@georgepapa you can test using the canary releases for now: https://docs.helm.sh/using_helm/#from-canary-builds

Explanation of error
The following template code with #3837 was problematic I'm confident.
{{- range $key, $value := .Values.serverFiles }}
  {{ $key }}: |
{{ toYaml $value | default "{}" | indent 4 }}
{{- if eq $key "prometheus.yml" -}}
{{- if $root.Values.alertmanager.enabled -}}
    alerting:

Note that all whitespace in between the {{ toYaml ... output and the alerting: line is chomped by the backward and forward comping by lines in between. As #3837 caused toYaml to no longer generate an un-chompable new line in the end, alerting: is suddenly overlapping on top of the output from toYaml.
https://github.com/kubernetes/charts/blob/9667722aba5b1d5e823385db0b3c1d0bfeea2904/stable/prometheus/templates/server-configmap.yaml#L14-L19

Sorry for the trouble caused by my PR!


[RFC] create plasmo --with-*

How do you envision this feature/change to look/work like?

pnpm create plasmo with-stripe

The above command would clone the with-stripe example from the examples repository, and apply necessary install/update.
This is a continuation of #36
What is the purpose of this change/feature? Why?
Better DX for bootstrapping new extension!
(OPTIONAL) Example implementations
No response
(OPTIONAL) Contact Details
No response
Verify canary release

[X] I verified that the issue exists in plasmo canary release

Code of Conduct

[X] I agree to follow this project's Code of Conduct
[X] I checked the current issues for duplicate problems.

yarn create plasmo with-stripe

yup, this will enable that as well as npm create as well. (you will need to do --with-*)


[Don't merge] Remove deprecated sidebar & breadcrumbs

All apps now use components to render the sidebar and breadcrumbs.
https://github.com/search?q=org%3Aalphagov+global-breadcrumb&type=Code
https://trello.com/c/KfgeIRtP

I've discovered that a few apps still use the breadcrumb thing, so let's not merge this yet.

For this to be merged we have to at least remove the old breadcrumbs from collections, feedback and email-alert-frontend.


Add "sortedmulti" descriptor support

Closes #164

@sanket1729 Thanks for your review. Addressed the comments that I could and got CI passing.

Thanks for the review @apoelstra. I added a few commits addressing most of your comments.

Ok @justinmoon can you rebase on master and squash everything? You can break up all the commits however you want ... one big commit is fine ... but please make sure that every commit compiles by itself.

Done


Can't Abandon Claim: Tx fee higher than claim amount

The Issue
When a claim is created with a fractional LBC low enough to be lower than the Tx fee, you cannot abandon the claim.
Steps to reproduce

Create a claim with 0.00001 LBC amount allotted to it.
Publish.
Try to abandon claim.

Expected behaviour
Claim should abandon.
Actual behaviour
"Cannot abandon claim because Tx fee is higher than claim amount."
System Configuration

"build": "release",
"lbrynet_version": "0.13.1",
"lbryschema_version": "0.0.7",
"lbryum_version": "2.8.4",
"os_release": "16.6.0",
"os_system": "Darwin",
"platform": "Darwin-16.6.0-x86_64-i386-64bit",
"processor": "i386",

Anything Else

Screenshots

Claim Details:

Claim Abandon Attempt:

Error in Log File:

This issue was moved to lbryio/lbry#768


Support comments in tsconfig files

Per discussion in #23
Also includes a regex tweak because searching for the import path of rCss would also match something like regularCss (note the ending of the word). We can pull that out into a separate PR if you prefer, just have to tweak my tests here to not trigger that error.

Thanks, released in v1.3.2


Baremetal STM32 driver is broken

We'll probably drop the baremetal support completely unless somebody submits an easy fix soon. The problem is that the file chip.h is missing, possibly something else.

Hi Pavel,
My recollection is that it is for sitting on STLib to support Flow
I think there are just a few constants that were needed.
https://github.com/PX4/Flow/blob/master/src/include/chip.h#L43-L47

Thanks David, let's see if somebody comes up with a fix, as I currently
have no bandwidth to test it myself.
On Nov 17, 2016 10:58 PM, "David Sidrane"<EMAIL_ADDRESS>wrote:

Hi Pavel,
My recollection is that it is for sitting on STLib to support Flow
I think there are just a few constants that were needed.
https://github.com/PX4/Flow/blob/master/src/include/chip.h#L43-L47
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/UAVCAN/libuavcan/issues/97#issuecomment-261352485,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ADJUZBop1B2OJUWXDAuEuYlRWRBvt-iDks5q_LHzgaJpZM4K1KMh
.

Hi.
I have managed to get the baremetal STM32 driver working on an F303 discovery board and an F446 nucleo board. Here are the two chip.h files:
F3:
#include "stm32f3xx.h"

#define STM32F3XX
#define STM32_PCLK1	(24000000ul)		// 24 Mhz
#define STM32_TIMCLK1	(2*STM32_PCLK1)

F4:
#include "stm32f4xx.h"

#define STM32F4XX
#define STM32_PCLK1		(42000000ul)		// 42 MHz
#define STM32_TIMCLK1		(2*STM32_PCLK1)
#define CAN1_TX_IRQHandler	CAN1_TX_IRQHandler	// This isn't defined anywhere
#define CAN1_RX0_IRQHandler	CAN1_RX0_IRQHandler	// This isn't defined anywhere
#define CAN1_RX1_IRQHandler	CAN1_RX1_IRQHandler	// This isn't defined anywhere

As mentioned above, I needed to include the header file for the specific device being used and set a few constants. I am using currently using the CubeMX graphical tool for development so I just read the value of STM32_PCLK1 off the interface and STM32_TIMCLK1 is always x2 of STM32_PCLK1. There is a function in the HAL library called HAL_RCC_GetPCLK1Freq which returns the same value.
The biggest issue I faced getting the bare metal driver working was linking up the interrupt handlers. For the F4 board, none of the CAN interrupt handlers where defined as preprocessor constants so I had to define them in chip.h.
For the F3 board, the interrupt handlers are USB_HP_CAN_TX_IRQHandler (aliased as CAN_TX_IRQHandler), USB_LP_CAN_RX0_IRQHandler (aliased as CAN_RX0_IRQHandler) and CAN_RX1_IRQHandler. To get the F3 board working I had to make these changes to uc_stm32_can.cpp:
@@ -22,7 +22,7 @@
 #endif

 #if (UAVCAN_STM32_CHIBIOS && CH_KERNEL_MAJOR == 2) || UAVCAN_STM32_BAREMETAL
-# if !(defined(STM32F10X_CL) || defined(STM32F2XX) || defined(STM32F4XX))
+# if !(defined(STM32F10X_CL) || defined(STM32F2XX) || defined(STM32F3XX)  || defined(STM32F4XX))
 // IRQ numbers
 #  define CAN1_RX0_IRQn USB_LP_CAN1_RX0_IRQn
 #  define CAN1_TX_IRQn USB_HP_CAN1_TX_IRQn
@@ -64,6 +64,9 @@
 #define CAN1_TX_IRQn           CAN_TX_IRQn
 #define CAN1_RX0_IRQn          CAN_RX0_IRQn
 #define CAN1_RX1_IRQn          CAN_RX1_IRQn
+#define CAN1_TX_IRQHandler     CAN_TX_IRQHandler
+#define CAN1_RX0_IRQHandler    CAN_RX0_IRQHandler
+#define CAN1_RX1_IRQHandler    CAN_RX1_IRQHandler
 #endif

I would like to help getting the bare metal driver working more universally but will need some guidance as to how.
James.

Great job James!

I would like to help getting the bare metal driver working more universally but will need some guidance as to how.

I propose to add a new top-level section in the STM32 platform driver manual. Could you please send your edits as a pull request? Thanks in advance!
It would also help to add some quick reference (perhaps in the form of a link to the above doc page) in the comments near the place where chip.h is included.

STM32_TIMCLK1 is always x2 of STM32_PCLK1

Beware that this does not hold if the bit TIMPRE in RCC_DCKCFGR is set.

Is the plan that libuavcan won't include chip.h so every project will include their own and fill in the appropriate parameters?

Yes that's the plan.

Currently you might have to modify uc_stm32_can.cpp for each new chip so should the interrupt handler definitions be included in chip.h?

should the interrupt handler definitions be included in chip.h?

I propose to support both approaches: provide definitions for popular and tested devices in uc_stm32_can.cpp, and let the user know that if their MCU is not supported, they will have to add definitions themselves in chip.h. I also suggest to include your extensions to uc_stm32_can.cpp described above into upstream.


Imported types are unrecognized in complex typedefs in --checkJs

TypeScript Version:  nightly (2.5.0-dev.20170613)
Code
test-externclassdef.js
class Foo {
  constructor() {}
}

exports.Foo = Foo;

test.js
const {Foo} = require('./test-externclassdef');

// this works
/** @type {Map<string, Foo>}} */
let fooMap = new Map();

// this is an error
/** @type {{foo: Map<string, Foo>}} */
let fooMapHolder = {foo: new Map()};

Expected behavior:
No error
Actual behavior:
test.js(8,30): error TS2304: Cannot find name 'Foo'.

this is going to be a bit hard. we leverage the same TS infrastructure once you have an object type in JSDoc. teasing it out would not be simple.

Should be fixed in latest.


Feature/batch graphql

Implementation of batch GQL request handling, documentation included.

Will create a PR for this branch when batch handling is implemented in full, as opposed to just for GQL queries.


parse private network as plain number

Now if we want to parse string as network we need to use strings "mainnet", "devin" and "private-" ( is an id of private network)
After this PR we can also parse strings "1", "3", "4", etc as Networks

We can already use Network::from(some u64); to get network from a integer, do we also need this? Although I don't see any reason to not implement this.

We can already use Network::from(some u64); to get Network from integer, do we also need this? Although I don't see any reason to not implement this.

yes, we have u64 implementation, but in some places in foundry is uses string name of network. For example in cache:
https://github.com/bchainhub/foundry/blob/master/config/src/cache.rs#L222
So in this test it can either use private-6 or just 6 as network name


Update Lightcurve and non-integrated exposure code

Add more user-friendly constructor for Lightcurve
Add non-integrated exposures to test_compute_lightcurve.jl
Fix bug in gradient version

Codecov Report

Merging #22 (15ffb7b) into main (f50f71c) will increase coverage by 4.27%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main      #22      +/-   ##
==========================================
+ Coverage   90.37%   94.65%   +4.27%
==========================================
  Files           5        5
  Lines         374      374
==========================================
+ Hits          338      354      +16
+ Misses         36       20      -16

Impacted Files
Coverage Δ

src/Lightcurve.jl
94.73% <100.00%> (+12.03%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f50f71c...15ffb7b. Read the comment docs.


Move, Clone, Undraw 3D Shapes

Building upon the grouping of 2D shapes, we can incorporate the move, clone, and undraw function from the graphics package to work on our 3D groups.

Methods for base3D completed


Updated plan for best-effort callback rewrite

The Best-Effort Callback was introduced as an experimental feature. It automatically builds instances of LiveTable, LivePlot, and others to produce a "best effort" visualization of data as it comes it. It can also be used to visualize saved data from databroker.
Known Limitations

The plotting callbacks aren't sufficiently configurable. For example, you can't ask LivePlot to plot one column divided by another column.
The plotting produces many matplotlib figure windows, and it gets messy. A tabbed layout in a single application would be nicer.
We are missing a solid live image and image stack viewer.
The Best-Effort Callback is not extensible; there is no easy way to add user-defined callbacks or modify the default ones.

Plan
We will release a new package, tentatively bluesky-mpl ("mpl" for "matplotlib") that includes:

A new take on LivePlot and friends that are more powerful, able to do things like plot derived quantities
Some optional Qt components to provide a tabbed layout for the Best-Effort Callback plots.
Additional plot types, most importantly image viewing
A configuration system for extending the Best-Effort Callback

Much of this is already prototyped in https://github.com/bluesky/bluesky-browser but that project will be archived out of concern that it has a difficult-to-nail-down scope and overlaps to some degree with functionality that Xi-cam endeavors to cover. Some of the pieces of bluesky-browser have already been moved into Xi-cam. The pieces related to plotting and more generally useful and will go in bluesky-mpl.
By developing this "new take" on the Best-Effort Callback and its components in a separate package, we will be able to put it on a separate release schedule than bluesky itself, likely issuing frequent releases at first. We have long discussed the advantages of separating the core of bluesky (RunEngine, plans) from callbacks. Now seems like a good time to make that pivot.
The existing LivePlot and friends will be maintained in bluesky for backward-compatibility and refactored #859 to use components from bluesky-mpl.

Also, it is very useful to have the PeakStats to be evaluated from a bp.scan(), even when the LivePlot is disabled.  Is this possible?  Seems that the logic to detect x & y axes is shared with LivePlot.
Take the case from our USAXS instrument where they want to observe a slow trend (such as nucleation and growth in a metal alloy) in a particular scan.  Enabling occasional traces (in the LivePlot) is more informative than continuous for such slow trends.  They periodically enable LivePlot as desired (say, once out of every 20 scan repetitions), then disable it until the next graph update is selected.  That allows an overnight run and an observation of trends without having too much information.  They can estimate how many scans will complete overnight, thus at what interval to sample for plots.

After a couple false starts, including the now-archived bluesky-browser and bluesky-mpl, we have a path forward on this that is sticking. See http://blueskyproject.io/bluesky-widgets/. We have deployed it on a trial basis at a couple NSLS-II beamlines and one APS beamline so far. Feedback has been positive. When it reaches feature parity with the Best-Effort Callback, we will recommend all users migrate.


Followup on method census

I think I can stop my nitpicking on this -- just can't find anything significant any more, perhaps later. :) The same thing applies to licensing checks -- so, in my eyes, now seems to be a good time to cut a release candidate for Marpa::R2.

Great work!  Thanks!


Convert wind-gust-diagnostic CLI to use Clize

Description
This PR converts the wind_gust_diagnostic CLI to use Clize.
Testing:

[x] Ran tests and they passed OK
[x] Added new tests for the new feature(s)

Looks good to me - one minor niggle about types, but I'm happy otherwise.


Custom GUI is not injected after window re-docking/maximizing

Seems there is no easy way to track when this re-initialization is actually happening..

Will be fixed in #view-items-refactoring branch by injecting into internal methods using Harmony.


Add support to ChainedTokenCredential  (azidentity)

This PR replaces the authentication mechanism to use the new azidentity SDK and that's nice, but it only added some helper functions to the connection builder for using the authentications. There isn't any option to use a ChainedTokenCredential even though it's a supported azcore.TokenCredential. As it's a legit use case of azidentity SDK, kusto SDK should support it as well.
The use case:
In KEDA we have support for Kusto as a metric sources but we also support multiple types of authentications based on user given options. To handle this, we have created our own ChainedTokenCredential based on our requirements and we have been using it with other upstreams like Azure Service Bus SDK. As azidentity SDK is unifying the authentication across all the azure SDKs, we'd like to use our ChainedTokenCredential in all of them, but this SDK doesn't support any way to provide this ChainedTokenCredential (or at least I haven't seen it, maybe I'm wrong 😄)
If you agree with this feature, I'm willing to contribute with it

Fixed in version 0.12.0 - added support for kcsb.WithTokenCredential(), you can now put in whatever credential you choose

Thanks! I'll update our code asap ❤


FS-2194: Group form controls

On pages 30-34 of the accessibility audit report - a few specific instances are mentioned where there were many inputs that were relevant to one another, but were not grouped appropriately in a fieldset, this caused confusion for screen readers as they weren't informed of the relation between the inputs automatically, and had to snoop around to get an understanding of the grouping and relation.
This change encloses related optional fields in a <fieldset>, and changes any enclosed hints to corresponding a <label>, meaning screen readers will detect the grouping and relation of the inputs automatically, and announce the correct label/information for the user.
Note that this has been change for both English/Welsh forms.

Putting a note here that I'd forgot to force-push a small change, so just done that in https://github.com/communitiesuk/funding-service-design-frontend/commit/515bf2b72780cd00655b0411d158c529feb2ea96 - just fixing the Welsh as it was English in one of the forms.


Contractions

Please note that he'sand she's becomes ['he', 'is'] and ['she', 'is']
but it could also be ['he', 'has'] and ['she', 'has']
stackexchange
• how about ``ìt```?
• shouldn't the negative contractions be handled here too?
"cannot": ["can", "not"] is the only one.
But how about stuff like
"shouldn't": ["should", "not"]
This would affect logic_negate, I assume.

oooh, very nice find.
i guess we could figure it out by the next verb? is it just he's/she's/it's with this ambiguity?

What about who, what, when, where, why & how ?
who is, who has....

just btw: added this project to the corresponding awesomeness:
https://github.com/edobashira/speech-language-processing

figured out a solution for he's, she's, it's, who's,what's,where's,when's,why's,how's
it is 'is' unless the next verb is negative, then it's 'has'
will keep this open until I address "n't" properly.
thanks!


Automated Package Upgrade

:tada: This PR is included in version 2.2.216 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


set resource proposal #51

Implementation of task  #51

will test this once on protocol-substrate before merging.


windows travis coverage

add windows travis
build windows electron distribution on windows travis
test the build

initial support landed in #3332


[WIP] Fix Ansible posthook not creating AnsibleJob CR

Signed-off-by: Mike Ng<EMAIL_ADDRESS>

/hold
Expecting the added e2e to fail. When the actual fix is included in the PR, the e2e will then pass.

/unhold

/lgtm


Enable pre-merge checks

enable CLA bot, Mungegithub bot, and Travis (if applicable) for this repo.
ref: https://groups.google.com/forum/#!searchin/kubernetes-dev/travis-ci|sort:relevance/kubernetes-dev/q-NasTfooPM/Z_1PnFzBAgAJ

CLA bot and CI are enabled. Look like that is enough for now (test/build coverage before merge). We may consider adding Mungegithub later.


Initial front end styles

:art: Doing some simple styles to brush up on the html and css etc. Here are some screenshots for the lazy but they need testing on other browsers, I'm on chrome right now.
Create Session

View Session

Going to go ahead and merge this, I'm not designer but pretty happy with the simple look for now.


Use a custom token for synchronize submodules action

This allows the action to push to the protected master branch. For some reason (still discussing with GitHub support) we have to use the write access token when checking out the repository, not just when pushing.
Note that the introduction of this token in GitHub secrets means that anyone with write access can push to the protected master branch, but only in a very convoluted fashion. We still avoid accidental pushes.
Tested:
Tried this out in a test branch (https://github.com/google/iree/tree/gcmn-test-submodule-sync)

This is a workflow file so should be merged directly. Scott, feel free to press the merge button.


Comments against a Ticket

All users should be able to post comments to the ticket details page. The comment should be captured along with the date-time and the author.
Requesters should only be able to post comments to their own tickets; the server-side code should perform this check to ensure that users aren't able to change the ID being posted to alter another user's ticket

Commenting was added in commit: 43c49e55e34a92ce9682521bd02b9a168c4de3bc
Styling for the commenting UI was added in: d9444cf101f31837eff93b56671e6fb0f03c0113


YAML file parse errror

I have created a YAML file via the discover process and am now deploying, after replacing the necessary FIX ME property values.
I am now getting a parse error which is odd as i have not edited these lines.  Any advice?
        1. WLSDPLY-18018: Parse error for file /opt/app/nfs/build_and_deploy/weblogic-deployment/environments/dev2/discovered_domain.yaml at l
ine 337 position 8: mismatched input '<IP_ADDRESS>' expecting {NAME, LIST_ITEM_OP}
        2. WLSDPLY-18018: Parse error for file /opt/app/nfs/build_and_deploy/weblogic-deployment/environments/dev2/discovered_domain.yaml at l
ine 341 position 8: extraneous input '<IP_ADDRESS>' expecting {<EOF>, NAME, LIST_ITEM_OP}
        3. WLSDPLY-18018: Parse error for file /opt/app/nfs/build_and_deploy/weblogic-deployment/environments/dev2/discovered_domain.yaml at l
ine 344 position 8: extraneous input ' ' expecting {<EOF>, NAME, LIST_ITEM_OP}
        4. WLSDPLY-18018: Parse error for file /opt/app/nfs/build_and_deploy/weblogic-deployment/environments/dev2/discovered_domain.yaml at l
ine 348 position 8: extraneous input ' ' expecting {<EOF>, NAME, LIST_ITEM_OP}
        5. WLSDPLY-18018: Parse error for file /opt/app/nfs/build_and_deploy/weblogic-deployment/environments/dev2/discovered_domain.yaml at l
ine 352 position 8: extraneous input ' ' expecting {<EOF>, NAME, LIST_ITEM_OP}
        6. WLSDPLY-18018: Parse error for file /opt/app/nfs/build_and_deploy/weblogic-deployment/environments/dev2/discovered_domain.yaml at l
ine 356 position 4: extraneous input ' ' expecting {<EOF>, NAME, LIST_ITEM_OP}
        7. WLSDPLY-18018: Parse error for file /opt/app/nfs/build_and_deploy/weblogic-deployment/environments/dev2/discovered_domain.yaml at l
ine 388 position 0: extraneous input '\n' expecting {<EOF>, NAME, LIST_ITEM_OP}
        8. WLSDPLY-09014: deployApps was unable to load the model from /opt/app/nfs/build_and_deploy/weblogic-deployment/environments/dev2/dis
covered_domain.yaml due to a translation error: Unable to parse model from file /opt/app/nfs/build_and_deploy/weblogic-deployment/environments
/dev2/discovered_domain.yaml : The YAML parser encountered 7 error(s) while parsing /opt/app/nfs/build_and_deploy/weblogic-deployment/environm
ents/dev2/discovered_domain.yaml

Here are the lines in question....
    336     UnixMachine:
    337         <IP_ADDRESS>:
    338             NodeManager:
    339                 NMType: Plain
    340                 ListenAddress: <IP_ADDRESS>
    341         <IP_ADDRESS>:
    342             NodeManager:
    343                 NMType: Plain
    344                 ListenAddress: <IP_ADDRESS>
    345         <IP_ADDRESS>:
    346             NodeManager:
    347                 NMType: Plain
    348                 ListenAddress: <IP_ADDRESS>
    349         <IP_ADDRESS>:
    350             NodeManager:
    351                 NMType: Plain
    352                 ListenAddress: <IP_ADDRESS>
    353         <IP_ADDRESS>:
    354             NodeManager:
    355                 NMType: Plain
    356                 ListenAddress: <IP_ADDRESS>
    357     SecurityConfiguration:
    358         NodeManagerPasswordEncrypted: 'fdkfkjdsks'
    359         NodeManagerUsername: s2GdxQrWpL
    360         CredentialEncrypted: 'dfsdflsdjfkl'
    361         EnforceValidBasicAuthCredentials: false
    362         Realm:
    363             myrealm:
    364                 Adjudicator:
    365                     DefaultAdjudicator:
    366                         DefaultAdjudicator:
    367                 AuthenticationProvider:
    368                     DefaultAuthenticator:
    369                         DefaultAuthenticator:
    370                     DefaultIdentityAsserter:
    371                         DefaultIdentityAsserter:
    372                             ActiveType: [ AuthenticatedUser, 'weblogic-jwt-token' ]
    373                 Authorizer:
    374                     XACMLAuthorizer:
    375                         XACMLAuthorizer:
    376                             PolicyDeploymentEnabled: true
    377                 CertPathProvider:
    378                     WebLogicCertPathProvider:
    379                         WebLogicCertPathProvider:
    380                 CredentialMapper:
    381                     DefaultCredentialMapper:
    382                         DefaultCredentialMapper:
    383                 PasswordValidator:
    384                     SystemPasswordValidator:
    385                         SystemPasswordValidator:
    386                 RoleMapper:
    387                     XACMLRoleMapper:
    388                         XACMLRoleMapper:
    389 resources:
    390     JDBCSystemResource:

Hello,
WDT has it's own YAML parser. If I interpret the grammar file correctly, names can not start with an integer:
NAME     : ID_START ID_CONTINUE* WS?     | '\'' QUOTED_ID_START QUOTED_ID_CONTINUE* '\'' WS?     | '"' QUOTED_ID_START QUOTED_ID_CONTINUE* '"' WS?     ;
fragment ID_START     : [_]     | [A-Z]     | [a-z]     | '!'     ;
If you have gotten those machine names from a discovery process, I assume Weblogic allows them and it's a WDT limitation.
-Kai

The problem with the resulting model is that the dotted addresses are not in quotes.  By doing these changes to each UnixMachine entry, I was able to get the model to load and operate:
        '<IP_ADDRESS>':
            NodeManager:
                NMType: Plain
                ListenAddress: '<IP_ADDRESS>'

The discovery tool should be doing this automatically, and we'll look into fixing that.  Let's leave this issue open to track that.

Thanks, I'll try and fix it with another edit

So i made the edit but I am still getting the same error.  Any suggestions?
New YAML section...
    335             Notes: This is a system generated default migratable target for a server.  WLSDPLY-18018: Parse error for file /opt/app/nfs/build_and_deploy/weblogic-deployment/environments/dev2/discovered_domain.yaml at line 337 posi
tion 8: mismatched input ''<IP_ADDRESS>'' expecting {NAME, LIST_ITEM_OP}
        2. WLSDPLY-18018: Parse error for file /opt/app/nfs/build_and_deploy/weblogic-deployment/environments/dev2/discovered_domain.yaml at line 341 posi
tion 8: extraneous input ''<IP_ADDRESS>'' expecting {<EOF>, NAME, LIST_ITEM_OP}
        3. WLSDPLY-18018: Parse error for file /opt/app/nfs/build_and_deploy/weblogic-deployment/environments/dev2/discovered_domain.yaml at line 344 posi
tion 8: extraneous input ' ' expecting {<EOF>, NAME, LIST_ITEM_OP}
        4. WLSDPLY-18018: Parse error for file /opt/app/nfs/build_and_deploy/weblogic-deployment/environments/dev2/discovered_domain.yaml at line 348 posi
tion 8: extraneous input ' ' expecting {<EOF>, NAME, LIST_ITEM_OP}
        5. WLSDPLY-18018: Parse error for file /opt/app/nfs/build_and_deploy/weblogic-deployment/environments/dev2/discovered_domain.yaml at line 352 posi
tion 8: extraneous input ' ' expecting {<EOF>, NAME, LIST_ITEM_OP}
        6. WLSDPLY-18018: Parse error for file /opt/app/nfs/build_and_deploy/weblogic-deployment/environments/dev2/discovered_domain.yaml at line 356 posi
tion 4: extraneous input ' ' expecting {<EOF>, NAME, LIST_ITEM_OP}
        7. WLSDPLY-18018: Parse error for file /opt/app/nfs/build_and_deploy/weblogic-deployment/environments/dev2/discovered_domain.yaml at line 388 posi
tion 0: extraneous input '\n' expecting {<EOF>, NAME, LIST_ITEM_OP}
        8. WLSDPLY-09014: deployApps was unable to load the model from /opt/app/nfs/build_and_deploy/weblogic-deployment/environments/dev2/discovered_doma
in.yaml due to a translation error: Unable to parse model from file /opt/app/nfs/build_and_deploy/weblogic-deployment/environments/dev2/discovered_domain.
yaml : The YAML parser encountered 7 error(s) while parsing /opt/app/nfs/build_and_deploy/weblogic-deployment/environments/dev2/discovered_domain.yaml

The colons are missing from the machine name lines:
    337         '<IP_ADDRESS>'
    338             NodeManager:
    339                 NMType: Plain
    340                 ListenAddress: '<IP_ADDRESS>'

should be:
    337         '<IP_ADDRESS>'**### :**
    338             NodeManager:
    339                 NMType: Plain
    340                 ListenAddress: '<IP_ADDRESS>'

Fix was made to allow digit as the first character in identifier.  Discovery was working correctly, quotes are not required around identifiers or values containing dot.


Test explorer item title can be cut off by inline actions

In the test explorer, items with a long title and inline actions don't render an ellipses, so the actions cut off the text:

Elsewhere e.g. in the remote explorer, items with a long title and inline actions get text-overflow: ellipses treatment:

Duplicated by https://github.com/microsoft/vscode/issues/186320


fix some errors in ConfigFiles.pm

@dg4prez - can you create an issue this so we can understand what the problem was?

https://github.com/Comcast/traffic_control/issues/1871

[2016-09-20 16:38:48,287] [DEBUG] GET "/genfiles/view/772/all".
[2016-09-20 16:38:48,289] [DEBUG] Routing to controller "UI::ConfigFiles" and action "genfiles".
DBIx::Class::Storage::DBI::select_single(): Query returned more than one row.  SQL that returns multiple rows is DEPRECATED for ->find and ->single at /home/dgelin200/cdn/traffic_control/traffic_ops/app/lib/UI/ConfigFiles.pm line 1277
[2016-09-20 16:38:51,649] [DEBUG] MID PARENT.CONFIG:
Removed
[2016-09-20 16:38:52,069] [DEBUG] Rendering template "config_files/genfiles.html.ep".

@dg4prez - if you can get the suggested edits made, I can merge this PR

Changes made.


The attribute 'onclick' may not appear in tag 'a'.

https://wordpress.org/support/topic/the-attribute-onclick-may-not-appear-in-tag-a-2/

This was solved along time back in commit : https://github.com/ahmedkaludi/Accelerated-Mobile-Pages/commit/3fb9e4515833c0cc01ebb588f9299f153e5e70fb


Read Only Mode

Support setting the whole portal in a ReadOnlyMode where no PUT, POST, or DELETE operations are allowed.

Minor bug: clicking Delete first prompts you to confirm, and then tells you that you can't do it. But really, that's no big deal.

It should be fixed now. Also will not display the error sign since it doesn't make sense as well.


BooleanOutput set function is incorrect

Bug Report
Current Behavior

use xgroup delconsumer command to delete a consumer for redis stream, the result returns pending messages count.
but invoke LettuceStreamCommands xGroupDelConsumer, return BooleanOutput object, the BooleanOutput set output function:
public void set(long integer) {
output = (integer == 1) ? Boolean.TRUE : Boolean.FALSE;
}
so, if the pending messages is more than one, this BooleanOutput set Boolean.FALSE! but it is actually success.
Environment

Lettuce version(s): [5.3.0.RELEASE]
Redis version: [5.0.0]

That was fixed with #1377 for version 6.0


Local & Arguments Collapse By Themselves

I'm referring to "Local" & "Arguments" under the Variables section to the left on the image above. The issue is, after setting breakpoints and stepping through my code, those 2 sections keep collapsing without my doing. Locals collapses on each run of a function, and Arguments collapses on each line. Is this the intended behavior?

I have the same behavior, I use watch variables to keep showing a value.

Good workaround! I still wonder if the behavior we experience is by design, however. Ideally we can get this addressed if needed.


pypi upload failing

@axelfahy Looks like the build worked but the upload failed:

I guess that pypi is down for uploads right now? This is probably a one time thing so once pypi get's fixed we should manually upload the package to both npm and pypi

Yes, I have the same error manually...

It was indeed an issue with PyPi servers. I have uploaded on PyPi and NPM, let's hope it uploads automatically next time.
Thank you for the help!


How to use Connect-MicrosoftTeams instead of the deprecated New-CSOnlineSession cmdlet?

[Enter feedback here]
The article says to use Connect-MicrosoftTeams instead of New-CsOnlineSession.
I don't see any way of doing this - it would be great if the article would provide more details.
When I try to use the return value of Connect-MicrosoftTeams with Import-PSSession I get the following:
Import-PSSession : Cannot bind parameter 'Session'. Cannot convert the "Microsoft.Open.Teams.CommonLibrary.PSAzureContext" value of type "Microsoft.Open.Teams.CommonLibrary.PSAzureContext" to type "System.Management.Automation.Runspaces.PSSession"
So our services are blocked due to a breaking change with no guidance.. appreciate an update.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 8c413445-e3d6-d6b8-4671-bd737bbdf130
Version Independent ID: 8c413445-e3d6-d6b8-4671-bd737bbdf130
Content: Teams PowerShell Module - Supported Versions - Microsoft Teams
Content Source: Teams/teams-powershell-supported-versions.md
Service: msteams
GitHub Login: @pbafna03
Microsoft Alias: pbafna

Hi @mwasham,
Import-PSSession is not required with Connect-MicrosoftTeams.  You can directly run the cmdlets after Connect-MicrosoftTeams has completed.
Few examples of the same are in https://docs.microsoft.com/en-us/powershell/module/teams/connect-microsoftteams?view=teams-ps#example-2-connect-to-microsoftteams
Thanks,

Hmm - previously the only way to call the New-CsApplicationAccessPolicy  was after you imported the session from New-CSOnlineSession.
After calling Connect-MicrosoftTeams I get:
New-CsApplicationAccessPolicy : The 'New-CsApplicationAccessPolicy' command was found in the module 'MicrosoftTeams', but the module could not be loaded.
I have updated the cmdlets and ran Import-Module MicrosoftTeams.

Ahh never mind. I just realized I had an old version of MicrosoftTeams installed.

@mwasham - Yes, best to use the latest 4.x.x version.


⚠ Bofrost.lu has degraded performance

In f45eb98, Bofrost.lu (https://www.bofrost.lu) experienced degraded performance:

HTTP code: 200
Response time: 2421 ms

Resolved: Bofrost.lu performance has improved in e033ca3 after 13 minutes.


Parallax Tilt Effect Tools Section

Solves Issue #34
Modifies the tool section

Is that responsive in other screen size
Add GitHub page link

Is that responsive in other screen size Add GitHub page link

Yes!

Add GitHub page link ?? Didn't got you ?

I have updated the screen display in an attempt to make it look more professional while keeping it minimalistic at the same time. Happy to help! :D


?activatemodule Tickets doesn't work

Bugreport:
Bug reported by Fabiooo
Is it a bugreport for the website or for the bot?: bot
What is the title of your bugreport?: ?activatemodule Tickets doesn't work
How can you reproduce the bug? (Explain in steps): ?deactivatemodule Tickets and then activate it
Which result would normally have to be?: It should be activated
What happens if you do the action now?: i't will not activate
ReportID: 76
┆Attachments: http://prntscr.com/l8cc6f

➤ LenoxBot commented:
?deactivatemodule also doesn't work with Tickets
Fabiooo

➤ LenoxBot commented:
fixed - pls approve
Dadi

➤ LenoxBot commented:
Approve:
has been fixed
Monkeyyy11

➤ LenoxBot commented:
Approve:
could be reproduced
Dadi

➤ LenoxBot commented:
Approve:
fixes
Wandi


NullPointerException loading a file a second time via LifecycleObserver

I have pdfview in a fragment. The fragment calls its parent activity when it is created to download a pdf file if necessary and then the activity calls a method in the fragment to actually load the file into pdfview.
I have recently migrated to sdk30 and androidx.lifecycle 2.3 and have faced some weird behavior.
If the fragment calls the activity via onActivityCreated then everything works well. Bu if it does it via the new LifecycleObserver way then pdfview crashes with NullPointerException. It's also worth noting that it starts crashing only after a file was loaded into pdfview once.

Hi @yaugenka were you able to fix it?
@barteksc , any updates on this?

No, I just switched back to using onActivityCreated instead of LifecycleObserver.


Check for authentication value signature does not cover all cases

$result = openssl_verify($concatSignedFields, $decodedSignature, $publicKey, $hashAlgorithm);
if (!$result) {
    throw new AuthTokenSignatureValidationException();
}

If openssl_verify fails for some reason, it returns value -1. In PHP, boolval(-1) returns true. Thus the exception is not thrown and validation result looks like valid, even the error occured.
Reproducible for example  by calling $decodedSignature = AsnUtil::transcodeSignatureToDER($decodedSignature); twice (to make the signature unrecognizable by OpenSSL).

I will probably include this in my PR regarding the EC transcoding condition.


Create detailed readme for new contributors

Depends on #1 and #2
Once above bugs are addressed, we need a readme so that new contributors can start working. README should include at the very minimum the following:

how to get the app running locally
how to clone/fork
list/sink of our custom components
links to resources relative to the work on this project - react/sass/nextjs/etc.
style guide (branding, components, fonts, etc.)

This can optionally be broken down to smaller tasks.

We just finished the branding, so I'll update the README.md to include that soon.


Can you use multiple expect() calls within one test?

It's not clear from the documentation at all. I've used multiple expect()'s within some it() ' s in my tests and it works fine, but for the sake of clarity it would help to add something like "each test can contain several expect() calls" as no example I can see within the documentation demonstrates this.

You absolutely can. I think for most of us who are used to rspec this isn't a surprise (although it's important to note we diverge from rspec in that we don't halt on the first expectation failure).
Point taken, however -- we can try to make this a little more explicit for folks who are unaccustomed to rspec.

ta


Symbol-keyed properties non-reactive

Version
2.6.10
Reproduction link
https://jsfiddle.net/dansebcar/b75n0uw6/16/
Steps to reproduce

Press update to change each item's name to "b"

What is expected?
The list re-renders with the new name
What is actually happening?
The list does not change

If we instead define "symbol" as any non-empty string, the expected re-render is observed, so I think the cause is just the parent list (items) is accessed through a symbol.
Nesting the symbol property an additional level (IE in config, rather than directly on data) is necessary to render the list at all; I guess symbols from data aren't directly transferred?
I noticed in the devtools when I pressed "refresh" after mutating the items that I could see the new name, so I assumed something about the way I was setting the property didn't trigger the update, but even Vue.set did not help.

Because of the way defineproperty works, I don't know why. It should be OK to change defineproperty to proxy in vue 3.0 version.

@Tipwheal  i make a mistake.

@Tipwheal  i made a mistake.

I tried to add some code in the function Observer.prototype.walk to support using Symbol, it works
Observer.prototype.walk = function walk (obj) {
  var keys = Object.keys(obj);
  if (Reflect.ownKeys) {
    Reflect.ownKeys(obj).filter(k => typeof(k) === 'symbol').forEach(k => keys.push(k));
  }
  for (var i = 0; i < keys.length; i++) {
    defineReactive(obj, keys[i]);
  }
};

https://jsfiddle.net/mwrjxLg8/ Vue.set helps

https://jsfiddle.net/mwrjxLg8/ Vue.set helps

Only if set after the object has been made reactive already. If the object is not reactive yet, Vue.set will do a simple property set.

I tried to add some code in the function Observer.prototype.walk to support using Symbol, it works
Observer.prototype.walk = function walk (obj) {
  var keys = Object.keys(obj);
  if (Reflect.ownKeys) {
    Reflect.ownKeys(obj).filter(k => typeof(k) === 'symbol').forEach(k => keys.push(k));
  }
  for (var i = 0; i < keys.length; i++) {
    defineReactive(obj, keys[i]);
  }
};

Or:
Observer.prototype.walk = function walk (obj) {
  var keys = Object.keys(obj);
  if (Object.getOwnPropertySymbols) {
    for (let key of Object.getOwnPropertySymbols(obj))
      keys.push(key);
  }
  for (var i = 0; i < keys.length; i++) {
    defineReactive(obj, keys[i]);
  }
};


Improve the date-fns example in readme

Per date-fns/date-fns#2474, the date-fns example in the readme might've been wrong/broken. I am not familiar with your project, so please double-check that this suggestion is OK!

Sure, we can keep the cherry-picked imports if you prefer. Give me a minute and I'll update the PR.


apt to apt-get

apt is not suitable for use in scripts, use apt-get instead

@mergify backport foxy main