start-api doesn't add the API stage to the routes

Description
When running sam start-api with a template that includes AWS::ApiGateway::Methods, AWS::ApiGateway::RestApi, AWS::ApiGateway::Resource, and AWS::ApiGateway::Stage resources (as announced in 0.21), it doesn't append the Stage name to the mounted endpoints
Steps to reproduce

Define a Lambda serverless app with the resources above (I don't have an MRE at the minute)
Run sam start-api

Observed result
Mounting LambdaFunctionName at http://<IP_ADDRESS>:3000/apiPath [POST]
(Debug output at the bottom)
Expected result
Mounting LambdaFunctionName at http://<IP_ADDRESS>:3000/stageName/apiPath [POST]
Additional environment details (Ex: Windows, Mac, Amazon Linux etc)

I debugged the code and it seems this bit doesn't append the stage name to the Flask routes.
I work at Amazon, I can share an MRE from our codebase if you reach out to me at seoaneg@

OS: Mac
sam --version: 0.23

Add --debug flag to command you are running
Using SAM Template at /Users/seoaneg/Workspaces/PCSecurityReviewService/src/PCSecurityReviewService/packages/infrastructure/template.yaml
Telemetry endpoint configured to be https://aws-serverless-tools-telemetry.us-west-2.amazonaws.com/metrics
local start-api command is called
Collected default values for parameters: {}
Unable to resolve property AllocationId: OrderedDict([('Fn::GetAtt', ['GammaPCSecurityReviewSvcVPCPublicSubnet1EIPA390CEC2', 'AllocationId'])]). Leaving as is.
Unable to resolve property AllocationId: OrderedDict([('Fn::GetAtt', ['GammaPCSecurityReviewSvcVPCPublicSubnet2EIPD44B52EC', 'AllocationId'])]). Leaving as is.
Unable to resolve property AllocationId: OrderedDict([('Fn::GetAtt', ['GammaPCSecurityReviewSvcVPCPublicSubnet3EIP0C16B512', 'AllocationId'])]). Leaving as is.
Unable to resolve property GroupId: OrderedDict([('Fn::GetAtt', ['GammaPCSecurityReviewSvcDbClusterSecurityGroup7FB132DD', 'GroupId'])]). Leaving as is.
Unable to resolve property SourceSecurityGroupId: OrderedDict([('Fn::GetAtt', ['GammaPCSecurityReviewSvcGetSecurityReviewLambdaSecurityGroup61D8C697', 'GroupId'])]). Leaving as is.
Unable to resolve property GroupId: OrderedDict([('Fn::GetAtt', ['GammaPCSecurityReviewSvcDbClusterSecurityGroup7FB132DD', 'GroupId'])]). Leaving as is.
Unable to resolve property SourceSecurityGroupId: OrderedDict([('Fn::GetAtt', ['GammaPCSecurityReviewSvcPutAnswerLambdaSecurityGroup80AACC7C', 'GroupId'])]). Leaving as is.
Unable to resolve property GroupId: OrderedDict([('Fn::GetAtt', ['GammaPCSecurityReviewSvcDbClusterSecurityGroup7FB132DD', 'GroupId'])]). Leaving as is.
Unable to resolve property SourceSecurityGroupId: OrderedDict([('Fn::GetAtt', ['GammaPCSecurityReviewSvcPostReviewStatusLambdaSecurityGroup54DC1DF3', 'GroupId'])]). Leaving as is.
Unable to resolve property GroupId: OrderedDict([('Fn::GetAtt', ['GammaPCSecurityReviewSvcDbClusterSecurityGroup7FB132DD', 'GroupId'])]). Leaving as is.
Unable to resolve property SourceSecurityGroupId: OrderedDict([('Fn::GetAtt', ['GammaPCSecurityReviewSvcPostQuestionsLambdaSecurityGroupD38FCC94', 'GroupId'])]). Leaving as is.
Unable to resolve property GroupId: OrderedDict([('Fn::GetAtt', ['GammaPCSecurityReviewSvcDbClusterSecurityGroup7FB132DD', 'GroupId'])]). Leaving as is.
Unable to resolve property SourceSecurityGroupId: OrderedDict([('Fn::GetAtt', ['GammaPCSecurityReviewSvcPostReviewVersionLambdaSecurityGroup9E615A73', 'GroupId'])]). Leaving as is.
Unable to resolve property GroupId: OrderedDict([('Fn::GetAtt', ['GammaPCSecurityReviewSvcDbClusterSecurityGroup7FB132DD', 'GroupId'])]). Leaving as is.
Unable to resolve property SourceSecurityGroupId: OrderedDict([('Fn::GetAtt', ['GammaPCSecurityReviewSvcPutAnswerStatusLambdaSecurityGroup723D976C', 'GroupId'])]). Leaving as is.
Unable to resolve property VpcSecurityGroupIds: [OrderedDict([('Fn::GetAtt', ['GammaPCSecurityReviewSvcDbClusterSecurityGroup7FB132DD', 'GroupId'])])]. Leaving as is.
Unable to resolve property dbEndpoint: OrderedDict([('Fn::GetAtt', ['GammaPCSecurityReviewSvcDocumentDbCluster', 'Endpoint'])]). Leaving as is.
Unable to resolve property SecurityGroupIds: [OrderedDict([('Fn::GetAtt', ['GammaPCSecurityReviewSvcGetSecurityReviewLambdaSecurityGroup61D8C697', 'GroupId'])])]. Leaving as is.
Unable to resolve property dbEndpoint: OrderedDict([('Fn::GetAtt', ['GammaPCSecurityReviewSvcDocumentDbCluster', 'Endpoint'])]). Leaving as is.
Unable to resolve property SecurityGroupIds: [OrderedDict([('Fn::GetAtt', ['GammaPCSecurityReviewSvcPutAnswerLambdaSecurityGroup80AACC7C', 'GroupId'])])]. Leaving as is.
Unable to resolve property dbEndpoint: OrderedDict([('Fn::GetAtt', ['GammaPCSecurityReviewSvcDocumentDbCluster', 'Endpoint'])]). Leaving as is.
Unable to resolve property SecurityGroupIds: [OrderedDict([('Fn::GetAtt', ['GammaPCSecurityReviewSvcPostReviewStatusLambdaSecurityGroup54DC1DF3', 'GroupId'])])]. Leaving as is.
Unable to resolve property dbEndpoint: OrderedDict([('Fn::GetAtt', ['GammaPCSecurityReviewSvcDocumentDbCluster', 'Endpoint'])]). Leaving as is.
Unable to resolve property SecurityGroupIds: [OrderedDict([('Fn::GetAtt', ['GammaPCSecurityReviewSvcPostQuestionsLambdaSecurityGroupD38FCC94', 'GroupId'])])]. Leaving as is.
Unable to resolve property dbEndpoint: OrderedDict([('Fn::GetAtt', ['GammaPCSecurityReviewSvcDocumentDbCluster', 'Endpoint'])]). Leaving as is.
Unable to resolve property SecurityGroupIds: [OrderedDict([('Fn::GetAtt', ['GammaPCSecurityReviewSvcPostReviewVersionLambdaSecurityGroup9E615A73', 'GroupId'])])]. Leaving as is.
Unable to resolve property dbEndpoint: OrderedDict([('Fn::GetAtt', ['GammaPCSecurityReviewSvcDocumentDbCluster', 'Endpoint'])]). Leaving as is.
Unable to resolve property SecurityGroupIds: [OrderedDict([('Fn::GetAtt', ['GammaPCSecurityReviewSvcPutAnswerStatusLambdaSecurityGroup723D976C', 'GroupId'])])]. Leaving as is.
177 resources found in the template
Found Lambda function with name='GammaPCSecurityReviewSvcGetSecurityReviewLambda2BCA0DDA' and CodeUri='/Users/seoaneg/Workspaces/PCSecurityReviewService/src/PCSecurityReviewService/packages'
Found Lambda function with name='GammaPCSecurityReviewSvcPutAnswerLambdaDF4DE497' and CodeUri='/Users/seoaneg/Workspaces/PCSecurityReviewService/src/PCSecurityReviewService/packages'
Found Lambda function with name='GammaPCSecurityReviewSvcPostReviewStatusLambda4789A865' and CodeUri='/Users/seoaneg/Workspaces/PCSecurityReviewService/src/PCSecurityReviewService/packages'
Found Lambda function with name='GammaPCSecurityReviewSvcPostQuestionsLambdaAD8C7517' and CodeUri='/Users/seoaneg/Workspaces/PCSecurityReviewService/src/PCSecurityReviewService/packages'
Found Lambda function with name='GammaPCSecurityReviewSvcPostReviewVersionLambda52F5BF2A' and CodeUri='/Users/seoaneg/Workspaces/PCSecurityReviewService/src/PCSecurityReviewService/packages'
Found Lambda function with name='GammaPCSecurityReviewSvcPutAnswerStatusLambdaCEDBFDA1' and CodeUri='/Users/seoaneg/Workspaces/PCSecurityReviewService/src/PCSecurityReviewService/packages'
Collected default values for parameters: {}
Unable to resolve property AllocationId: OrderedDict([('Fn::GetAtt', ['GammaPCSecurityReviewSvcVPCPublicSubnet1EIPA390CEC2', 'AllocationId'])]). Leaving as is.
Unable to resolve property AllocationId: OrderedDict([('Fn::GetAtt', ['GammaPCSecurityReviewSvcVPCPublicSubnet2EIPD44B52EC', 'AllocationId'])]). Leaving as is.
Unable to resolve property AllocationId: OrderedDict([('Fn::GetAtt', ['GammaPCSecurityReviewSvcVPCPublicSubnet3EIP0C16B512', 'AllocationId'])]). Leaving as is.
Unable to resolve property GroupId: OrderedDict([('Fn::GetAtt', ['GammaPCSecurityReviewSvcDbClusterSecurityGroup7FB132DD', 'GroupId'])]). Leaving as is.
Unable to resolve property SourceSecurityGroupId: OrderedDict([('Fn::GetAtt', ['GammaPCSecurityReviewSvcGetSecurityReviewLambdaSecurityGroup61D8C697', 'GroupId'])]). Leaving as is.
Unable to resolve property GroupId: OrderedDict([('Fn::GetAtt', ['GammaPCSecurityReviewSvcDbClusterSecurityGroup7FB132DD', 'GroupId'])]). Leaving as is.
Unable to resolve property SourceSecurityGroupId: OrderedDict([('Fn::GetAtt', ['GammaPCSecurityReviewSvcPutAnswerLambdaSecurityGroup80AACC7C', 'GroupId'])]). Leaving as is.
Unable to resolve property GroupId: OrderedDict([('Fn::GetAtt', ['GammaPCSecurityReviewSvcDbClusterSecurityGroup7FB132DD', 'GroupId'])]). Leaving as is.
Unable to resolve property SourceSecurityGroupId: OrderedDict([('Fn::GetAtt', ['GammaPCSecurityReviewSvcPostReviewStatusLambdaSecurityGroup54DC1DF3', 'GroupId'])]). Leaving as is.
Unable to resolve property GroupId: OrderedDict([('Fn::GetAtt', ['GammaPCSecurityReviewSvcDbClusterSecurityGroup7FB132DD', 'GroupId'])]). Leaving as is.
Unable to resolve property SourceSecurityGroupId: OrderedDict([('Fn::GetAtt', ['GammaPCSecurityReviewSvcPostQuestionsLambdaSecurityGroupD38FCC94', 'GroupId'])]). Leaving as is.
Unable to resolve property GroupId: OrderedDict([('Fn::GetAtt', ['GammaPCSecurityReviewSvcDbClusterSecurityGroup7FB132DD', 'GroupId'])]). Leaving as is.
Unable to resolve property SourceSecurityGroupId: OrderedDict([('Fn::GetAtt', ['GammaPCSecurityReviewSvcPostReviewVersionLambdaSecurityGroup9E615A73', 'GroupId'])]). Leaving as is.
Unable to resolve property GroupId: OrderedDict([('Fn::GetAtt', ['GammaPCSecurityReviewSvcDbClusterSecurityGroup7FB132DD', 'GroupId'])]). Leaving as is.
Unable to resolve property SourceSecurityGroupId: OrderedDict([('Fn::GetAtt', ['GammaPCSecurityReviewSvcPutAnswerStatusLambdaSecurityGroup723D976C', 'GroupId'])]). Leaving as is.
Unable to resolve property VpcSecurityGroupIds: [OrderedDict([('Fn::GetAtt', ['GammaPCSecurityReviewSvcDbClusterSecurityGroup7FB132DD', 'GroupId'])])]. Leaving as is.
Unable to resolve property dbEndpoint: OrderedDict([('Fn::GetAtt', ['GammaPCSecurityReviewSvcDocumentDbCluster', 'Endpoint'])]). Leaving as is.
Unable to resolve property SecurityGroupIds: [OrderedDict([('Fn::GetAtt', ['GammaPCSecurityReviewSvcGetSecurityReviewLambdaSecurityGroup61D8C697', 'GroupId'])])]. Leaving as is.
Unable to resolve property dbEndpoint: OrderedDict([('Fn::GetAtt', ['GammaPCSecurityReviewSvcDocumentDbCluster', 'Endpoint'])]). Leaving as is.
Unable to resolve property SecurityGroupIds: [OrderedDict([('Fn::GetAtt', ['GammaPCSecurityReviewSvcPutAnswerLambdaSecurityGroup80AACC7C', 'GroupId'])])]. Leaving as is.
Unable to resolve property dbEndpoint: OrderedDict([('Fn::GetAtt', ['GammaPCSecurityReviewSvcDocumentDbCluster', 'Endpoint'])]). Leaving as is.
Unable to resolve property SecurityGroupIds: [OrderedDict([('Fn::GetAtt', ['GammaPCSecurityReviewSvcPostReviewStatusLambdaSecurityGroup54DC1DF3', 'GroupId'])])]. Leaving as is.
Unable to resolve property dbEndpoint: OrderedDict([('Fn::GetAtt', ['GammaPCSecurityReviewSvcDocumentDbCluster', 'Endpoint'])]). Leaving as is.
Unable to resolve property SecurityGroupIds: [OrderedDict([('Fn::GetAtt', ['GammaPCSecurityReviewSvcPostQuestionsLambdaSecurityGroupD38FCC94', 'GroupId'])])]. Leaving as is.
Unable to resolve property dbEndpoint: OrderedDict([('Fn::GetAtt', ['GammaPCSecurityReviewSvcDocumentDbCluster', 'Endpoint'])]). Leaving as is.
Unable to resolve property SecurityGroupIds: [OrderedDict([('Fn::GetAtt', ['GammaPCSecurityReviewSvcPostReviewVersionLambdaSecurityGroup9E615A73', 'GroupId'])])]. Leaving as is.
Unable to resolve property dbEndpoint: OrderedDict([('Fn::GetAtt', ['GammaPCSecurityReviewSvcDocumentDbCluster', 'Endpoint'])]). Leaving as is.
Unable to resolve property SecurityGroupIds: [OrderedDict([('Fn::GetAtt', ['GammaPCSecurityReviewSvcPutAnswerStatusLambdaSecurityGroup723D976C', 'GroupId'])])]. Leaving as is.
177 resources found in the template
Skipping resource 'GammaPCSecurityReviewSvcApi35B2AC66'. Swagger document not found in Body and BodyS3Location
Extracted Function ARN: arn:aws:lambda:us-east-1:123456789012:function:GammaPCSecurityReviewSvcGetSecurityReviewLambda2BCA0DDA
Extracted Function ARN: arn:aws:lambda:us-east-1:123456789012:function:GammaPCSecurityReviewSvcPutAnswerLambdaDF4DE497
Extracted Function ARN: arn:aws:lambda:us-east-1:123456789012:function:GammaPCSecurityReviewSvcPutAnswerStatusLambdaCEDBFDA1
Extracted Function ARN: arn:aws:lambda:us-east-1:123456789012:function:GammaPCSecurityReviewSvcPostReviewStatusLambda4789A865
Extracted Function ARN: arn:aws:lambda:us-east-1:123456789012:function:GammaPCSecurityReviewSvcPostQuestionsLambdaAD8C7517
Extracted Function ARN: arn:aws:lambda:us-east-1:123456789012:function:GammaPCSecurityReviewSvcPostReviewVersionLambda52F5BF2A
6 APIs found in the template
Mounting GammaPCSecurityReviewSvcGetSecurityReviewLambda2BCA0DDA at http://<IP_ADDRESS>:3000/v1/projects/{project_id}/security_review [GET]
Mounting GammaPCSecurityReviewSvcPutAnswerLambdaDF4DE497 at http://<IP_ADDRESS>:3000/v1/projects/{project_id}/security_review/{question_id}/answer [PUT]
Mounting GammaPCSecurityReviewSvcPutAnswerStatusLambdaCEDBFDA1 at http://<IP_ADDRESS>:3000/v1/projects/{project_id}/security_review/{question_id}/answer/status [PUT]
Mounting GammaPCSecurityReviewSvcPostReviewStatusLambda4789A865 at http://<IP_ADDRESS>:3000/v1/projects/{project_id}/security_review/status [POST]
Mounting GammaPCSecurityReviewSvcPostQuestionsLambdaAD8C7517 at http://<IP_ADDRESS>:3000/v1/security_review/questions [POST]
Mounting GammaPCSecurityReviewSvcPostReviewVersionLambda52F5BF2A at http://<IP_ADDRESS>:3000/v1/security_review/{type}/version [POST]
You can now browse to the above endpoints to invoke your functions. You do not need to restart/reload SAM CLI while working on your functions, changes will be reflected instantly/automatically. You only need to restart SAM CLI if you update your AWS SAM template
Localhost server is starting up. Multi-threading = True
2019-10-25 18:26:19  * Running on http://<IP_ADDRESS>:3000/ (Press CTRL+C to quit)

Forgot to say: I'm happy to contribute in solving this, as I already set up my dev env to debug this

Is the goal behind this to run multiple stages in parallel on one stack, or just consistency? I believe this may have been an intentional design choice.

@awood45 it's mostly consistency between the API path when deploying vs when running locally.
Multiple stages in parallel hadn't occurred to me; this would only add value for people with the same API path across multiple stages, which doesn't sound terribly common.


Comma seperated IP blocks copy paste as Alias return Invalid range error

Important notices
Before you add a new report, we ask you kindly to acknowledge the following:

[ v ] I have read the contributing guide lines at https://github.com/opnsense/core/blob/master/CONTRIBUTING.md
[ v ] I am convinced that my issue is new after having checked both open and closed issues at https://github.com/opnsense/core/issues?q=is%3Aissue

The issue
When trying to import a comma seperated list of IP blocks as an Alias with Network(s) type, the interface returns an invalid range error while it seemingly does seem to accept copy paste as valid.
No idea if previous versions have the problem, but I am on 24.1.9.
To Reproduce
Create a new firewall Alias and select Network(s) as the type. Copy paste mulitiple comma seperated IP blocks e.g.
<IP_ADDRESS>/24,
<IP_ADDRESS>/24,
<IP_ADDRESS>/24
Visually, the interface appears to accept a comma seperated entry as a valid choice. When saving the alias an error is thrown.

Expected behavior
It looks like it would accept comma seperated blocks, therefor it should. But it doesnt.
Describe alternatives you considered
Various seperators but only comma seems to indicate that is an accepted format
There is an existing importer that can do raw imports somewhere, without the need of comma seperation. Maybe this function can also be applied here.

It appears to complain about the embedded newline.


chore: Add nested noop test case

Description

Links

Resolves https://github.com/json-everything/json-everything/issues/836
Checks

[x] I have read and understand the Code of Conduct and Contribution Guidelines.

@gregsdennis now the test passed

@He-Pin Thank you.  Please submit your PRs like this in the future: commit with a failing test to show the need for the change, followed by a commit that makes the test pass.


Missing DLLs in Download Artifacts.

The Windows Download Artifact is missing the discord_game_sdk.dll
Would you like to fix it?

To my knowledge, I am not allowed to provide the discord_game_sdk.dll (and .so and .dylib) files. You have to download them yourself at the link in the README. I will add a note to the README so that this is more obvious.


add comment to spring properties

Fix #2106

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.Renan Meneses de Andrade Franca seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.

@renanfranca : missing unit tests:

@pascalgrimaud , please, let's try one more time ✌

@pascalgrimaud, please, let's try one more time v

You can check it locally:
docker compose -f src/main/docker/sonar.yml up -d
./mvnw clean verify sonar:sonar

@pascalgrimaud, please, let's try one more time v

You can check it locally:
docker compose -f src/main/docker/sonar.yml up -d
./mvnw clean verify sonar:sonar

Thanks, @DamnClin! I ran it here and the uncovered lines were that:

But it is covered by the class tech.jhipster.lite.module.infrastructure.secondary.FileSystemSpringCommentsCommandsHandlerTest. It looks like a known problem, but I don't know how to solve it. Can you help me?

Yep, annotate the method with @Generated (you have some examples of this case)

Is it ok for you @DamnClin ?

Is it ok for you @DamnClin ?

I won't be able to give it a proper look in the upcomming days...

@DamnClin : no worry, so let's wait a few days before merging this one

@renanfranca : can you rebase / update your branch plz? As some change in main branch will need some change here, specially Generated -> ExcludeFromGeneratedCodeCoverage
Thanks in advance :)

It's done @pascalgrimaud 💪

Small test from my side and it works well:

Thanks and congrats for your 1st contribution @renanfranca !
Don't forget to claim your bounty ;)

Claimed https://opencollective.com/generator-jhipster/expenses/117514 😃
Thank you very much @pascalgrimaud !!!

@renanfranca : approved


[AppBar] Put child between the title and the right icon

I currently tweak the style of the components I use in the app bar, but at least now they appear at the right position.
I'am not sure what is the right direction to make everything work perfectly without tweaking.
Should we support ToolbarGroup ?  (currently they do not go on the right or left as expected and I wasn't able to figure out why)

I've had similar problems to me, this will be better

I closing this PR. Let's wait https://github.com/callemall/material-ui/issues/773 to be resolved.


/infraction autocompleted commands fail on mobile

This is a bug inherent to the client behaviour on Discord Mobile. A parameter with autocomplete forces client-side validation and the autocomplete options represent an exhaustive list of allowed values.
For this reason, /infraction view, /infraction delete, and /infraction edit, should not list autocomplete options until such a time that the mobile app is fixed.

This will put a real dampener on UX, in the meantime

Resolved with 8bef646e4ee29f2c215e42a735fe93dc4fa32c36


[Backport 2.x] Well format the raw response when query parameter "pretty" enabled

Backport https://github.com/opensearch-project/sql/commit/aec482577143a327a6dc94e073a0a6cec709a7ed from https://github.com/opensearch-project/sql/pull/2727
The backport by opensearch-trigger-bot failed with exit code 128 (Ref: https://github.com/opensearch-project/sql/pull/2727#issuecomment-2218003068)

The auto-backport process failed with The process '/usr/bin/git' failed with exit code 128, manually backport it. @penghuo @dai-chen @vamsi-amazon. Only MacOS Build failed.

Security IT failed due to https://github.com/opensearch-project/security/actions/runs/9967076404/job/27540175842
Workflows are needed to rerun when above job succeed again.

Security ITs now passed with the help from https://github.com/opensearch-project/security/issues/4576


I already have the property autoCorrect: true in the config.yml file, and the file is being tracked by the command gradle detektCheck successfully. But it seems this command doesn't fix the issues.
Am I missing something here? Thanks in advance.

You missed the plugin.  Try -p /path/to/detekt/detekt-formatting/build/libs/detekt-formatting-1.0.0.RC8.jar or see #925.

Thanks @Mygod :+1:
I will describe what I did here, in case it can help someone else.
1. Added detekt formatting plugin in my root build.gradle:
// ...

plugins {
    id "io.gitlab.arturbosch.detekt" version "1.0.0.RC8"
}

dependencies {
    detekt "io.gitlab.arturbosch.detekt:detekt-formatting:$detektVersion"
}

detekt {
    version = "$detektVersion"
    defaultProfile {
        input = file("../")
        config = file("../detekt-config.yml")
        filters = ".*/resources/.*,.*/build/.*"
    }
}

2. Then just:
gradle detektCheck

@Mygod thanks for helping out!
@arturbosch maybe this should be included in the documentation?


Update docs - Point to .devcontainer folder instead of the Dockerfile file

Ref: https://github.com/devcontainers/images/issues/653#issuecomment-1629823470

Are these supposed to be links?

@joshspicer Yes, From this issue https://github.com/devcontainers/images/issues/653, looks there was a confusion as in which Dockerfile we were referencing to? Hence, linking should avoid any unwanted confusions.
Also, https://github.com/devcontainers/images/issues/653#issuecomment-1629789928

I kept the last sentence more general to avoid needing to link every readme uniquely, though if we're willing to do that and don't think the links will break, that'd also probably help.


Update development setup procedure

Was working with Nate and discovered some unforeseen obstacles along way.

Looks great!


guides: "Start tutorial" link is somewhat lost because of lack of colour contrast

This is something of an accessibility issue, but could also be a problem for first-time users.

Fixed by a4d42cecb2986d13b7e01621bd0b4cabb2e04a54


Announce new GB members

Fill remaining seats on the OpenSSF Governing Board:

Member Representatives
Technical Advisory Council Representative
Security Community Individual Representative

10/15: Nomination Email Sent to all Member Company Voting Contacts

New board members were announced via press release & OpenSSF Website on Oct-29.


docs(Checkbox): change role and add descriptions to Storybook

implements https://zitenote.atlassian.net/browse/UXD-1010

This shouldn't be a "docs" commit as you are actually changing the implementation

This shouldn't be a "docs" commit as you are actually changing the implementation

split to 2 commits, changed messages accordingly


nixos/redmine mercurial integration is broken

Describe the bug
Browsing a hg (mercurial) repository in a redmine project does not work. No repo functionality works when hg is used.
To Reproduce
Steps to reproduce the behavior:

Make use of the redmine module
Add a local hg repo to which redmine has access.
In redmine, go to the project settings page and add the local hg repo
Click the added repo name, or click on the "repository" tab of the project

Now you get to see a 404 page.
Expected behavior
Normally you should be able to browse the repository.
Logs
This issue happens both in the current nixos release and in the unstable, but with different errors:
In release 20.03
Aug 08 18:07:33 nixos bundle[871]: *** failed to import extension redminehelper from /nix/store/c2za42x86iqk8wrxphl4pc2rkb5kbwxq-redmine-4.1.1/share/redmine/lib/redmine/scm/adapters/mercurial/redminehelper.py: unicode 'rhannotate' found in cmdtable
Aug 08 18:07:33 nixos bundle[871]: *** (use b'' to make it byte string)
Aug 08 18:07:33 nixos bundle[871]: hg: unknown command 'rhsummary'
Aug 08 18:07:33 nixos bundle[871]: (did you mean summary?)

In unstable
Aug 08 18:30:38 nixos bundle[1133]: *** failed to import extension redminehelper from /nix/store/3sdqxliq5qd15wfzyiclqs5ax1b6ggnc-redmine-4.1.1/share/redmine/lib/redmine/scm/adapters/mercurial/redminehelper.py: module 'cgi' has no attribute 'escape'
Aug 08 18:30:38 nixos bundle[1133]: hg: unknown command 'rhsummary'
Aug 08 18:30:38 nixos bundle[1133]: (did you mean summary?)

Additional context
The python hg script that is shipped with redmine (redminehelper.py) seems to be incompatible with the python version is being used when it is called.
Possible related upstream bug: https://www.redmine.org/issues/33784
Notify maintainers
@aanderse

I've never used hg so wouldn't know where to start. Can you provide some config that I can reproduce this with and maybe something will occur to me?

Not sure what I can give in terms of config.
In order to reproduce you basically do the same as you would with git:
mkdir repo
cd repo/
hg init
touch testfile
hg add testfile
hg commit -m"Added testfile"

And then add it as a repository in the redmine project config, like so:

If you then click on the repo link "hg", or on "repository" tab of the project you get:

I then checked what the error log was with: journalctl -u redmine
The following archive has the /var/lib/redmine state directory + also the repo directory as described above + redmine_mysql.db , a database dump of the redmine mysql database (login: admin, password: testtest)
redmine.tar.gz
To be honest I'm not sure if this can be solved in NixOS at all. We might just have to wait until compatibility with python3 is improved upstream.

Sounds like an upstream bug - have you tried reporting it upstream?

I think it's already reported: https://www.redmine.org/issues/33784
But I'll add a comment there linking back here...
The patch posted there might solve the issue for us.

I created a draft PR for this, which I verified fixes this issue.
Though I don't know if we really want to carry around a patch ourselves until upstream fixes things...
The current mercurial <-> redmine situation can't really get any worse, and I don't think this patch can break anything else.
But it might also be worth it to wait for a proper fix from upstream.

I think's fine to carry a patch until upstream fixes things if these two things are met:

upstream is already aware of the patch - done
our patch contains reference to the upstream bug report - not done, left you a suggestion in the PR


Bump assets version from v280 to v286

Ticket
https://app.shortcut.com/cartoteam/story/207532/change-the-domain-in-fastly-to-unblock-carto2-in-china
Description
Due to China's Firewall we need to change the domains where the assets are served to libs.cartocdn.com (production) and libs-staging.cartocdn.com (staging), so we need to regenerate the assets.
Related Cartodb-platfom PR : https://github.com/CartoDB/cartodb-platform/pull/7234
The gap between versions is to align Staging and Prod

https://app.shortcut.com/cartoteam/story/207532/change-the-domain-in-fastly-to-unblock-carto2-in-china


Set Servenames and Domains

Hi,
I want to manual set the servername and domain but they are not set.
What i see in your module you only set IPv4.Configuration param can you confirm ?
The connman properties is Nameservers.Configuration and Domains.Configuration.
Thank you for your help.
My connman properties available :
{ Type: 'ethernet',
  Security: [],
  State: 'ready',
  Favorite: true,
  Immutable: false,
  AutoConnect: true,
  Name: 'Wired',
  Ethernet:
   { Method: 'auto',
     Interface: 'eth0',
     Address: 'BB:DC:AA:02:1C:CD',
     MTU: 1500 },
  IPv4:
   { Method: 'manual',
     Address: '<IP_ADDRESS>',
     Netmask: '<IP_ADDRESS>',
     Gateway: '<IP_ADDRESS>' },
  'IPv4.Configuration':
   { Method: 'manual',
     Address: '<IP_ADDRESS>',
     Netmask: '<IP_ADDRESS>',
     Gateway: '<IP_ADDRESS>' },
  IPv6: {},
  'IPv6.Configuration': { Method: 'auto', Privacy: 'disabled' },
  Nameservers: [],
  'Nameservers.Configuration': [],
  Timeservers: [ '<IP_ADDRESS>' ],
  'Timeservers.Configuration': [],
  Domains: [],
  'Domains.Configuration': [],
  Proxy: { Method: 'direct' },
  'Proxy.Configuration': {},
  Provider: {},
  serviceName: '/net/connman/service/ethernet_bbdcaa021ccd_cable' }

That could be true. We've mainly been concerned with ip4. The project we used this in stopped, so we're looking for new maintainers.

Ok, thank you for your answer. Maybe i make a PR for this support.


Integration Dashboard and Quality model

This is the second internal API for dashboard. This time, dashboard will implement many notify messages and quality model have to adapt to these many messages.
It is necessary to develop this integration code in both sides: quality model and dashboard.

JSON definition - Notify Trustworthiness
{
"xData": ["0.001", "0.002", "0.003", "0.004", "0.005", "0.006","0.007", "0.008", "0.009", “0.010", "0.011", “0.012"],
"yData":[{
"name": "Trustworthiness",
"data": [-0.2, 0.8, 5.7, 11.3, 17.0, 22.0, 24.8, 24.1, 20.1, 14.1, 8.6, 2.5]
}]
}
JSON definiton - Notify Metrics
{
"xData": ["xData": ["0.001", "0.002", "0.003", "0.004", "0.005", "0.006","0.007", "0.008", "0.009", "0.010", "0.011", “0.012"],
"yData":[{
"name": "Privacy",
"data": [7.0, 6.9, 9.5, 14.5, 18.2, 21.5, 25.2, 26.5, 23.3, 18.3, 13.9, 9.6]
}, {
"name": "Security",
"data": [-0.2, 0.8, 5.7, 11.3, 17.0, 22.0, 24.8, 24.1, 20.1, 14.1, 8.6, 2.5]
}, {
"name": "Fairness",
"data": [-0.9, 0.6, 3.5, 8.4, 13.5, 17.0, 18.6, 17.9, 14.3, 9.0, 3.9, 1.0]
}, {
"name": "Transparency",
"data": [3.9, 4.2, 5.7, 8.5, 11.9, 15.2, 17.0, 16.6, 14.2, 10.3, 6.6, 4.8]
}]
}


Dockerfile so that ProTECT versions can be validated in Dockstore (re…

…solves issue #223)
Dockerfile so that ProTECT versions can be validated in Dockstore

Hi Arjun @arkal here is the Dockerfile

Commit message too long and improperly grammaticized. See https://chris.beams.io/posts/git-commit/
Add Dockerfile to base directory (resolves #223)

Dockstore validation requires a Dockerfile in the base directory of the
repository.

Hi @arkal Arjun,
The Dockerfile pull request is ready for your review.

It was faster for me to do it.


Docker pull#564: docker run fails to build

% docker run upm
Scanning dependencies of target max31723
[ 56%] Building CXX object src/max31723/CMakeFiles/max31723.dir/max31723.cxx.o
[ 57%] Linking CXX shared library libupm-max31723.so
[ 57%] Built target max31723
Scanning dependencies of target pn532
[ 57%] Building CXX object src/pn532/CMakeFiles/pn532.dir/pn532.cxx.o
[ 58%] Linking CXX shared library libupm-pn532.so
[ 58%] Built target pn532
Scanning dependencies of target lcdks-c
[ 58%] Building C object src/lcdks/CMakeFiles/lcdks-c.dir/lcdks.c.o
In file included from /usr/src/app/src/lcdks/lcdks.c:36:
/usr/src/app/src/lcdks/lcdks.h:41:10: fatal error: 'lcm1602.h' file not found
#include "lcm1602.h"
^
1 error generated.
make[2]: *** [src/lcdks/CMakeFiles/lcdks-c.dir/lcdks.c.o] Error 1
src/lcdks/CMakeFiles/lcdks-c.dir/build.make:62: recipe for target 'src/lcdks/CMakeFiles/lcdks-c.dir/lcdks.c.o' failed
CMakeFiles/Makefile2:6769: recipe for target 'src/lcdks/CMakeFiles/lcdks-c.dir/all' failed
Makefile:127: recipe for target 'all' failed
make[1]: *** [src/lcdks/CMakeFiles/lcdks-c.dir/all] Error 2
make: *** [all] Error 2
--
Running a shell and manually doing a build works.

no longer an issue


Grading table refresh button bugged

Clicking refresh on the grading table causes it to send a backend request with query param group = false even though the drop down is still set to "submissions from my group"

Should be a FE issue


Views checkboxes not displayed in Admin

I've juste updated to v0.25.3
The views checkboxes have disappeared from my admin settings panel.
Screenshot with error:
https://www.dropbox.com/s/e38aj4wteyvj0tv/Capture d'écran 2015-10-19 00.57.06.png?dl=0
Note I've been able to update settings and add my previous selection of views via mongoDB.

I had the same problem... the thing is that if you have any custom views defined... you need to make sure you change the item.label to item.name and label() is a new function..
See below for example on how the views should be...
your views should have name like This!
The label will be a function like This!
and Finally, if you have any custom views defined and copied the views_menus.js you might want to make sure you are checking for item.name and not item.label like This!

Yeah sorry, I had to change things a bit between the name/label properties to make internationalization work better.

Thanks for your info. I had no custom views defined so the problem was different.
I did a temporary fixture that I put in my lib folder for the Settings.schema.
I changed label: view.label()   to  label: view.label for defaultView and postViews objects

Hey, @vayovayo! Telescope has changed a lot in the past months, and there is a new React-based version, Telescope Nova (intro video). If you know Crater, it runs on the latest version.
The Legacy version is no longer supported. I'm closing this issue.
I invite you to check the new version, it's awesome!
Happy hacking! 🚀
Ps: by the way, don't hesitate to join the Slack to ask any question, you are welcome! 👍


Detect redundant equal sign in variable section

I changed the description of the rule so it fits now 2 scenarios (equal sign for return value assignment and for variables section). If you think that it should be done with 2 separate rules, let me know, but I think it's the same issue.

Codecov Report

Merging #265 (1a11883) into master (9732e35) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #265   +/-   ##
=======================================
  Coverage   98.94%   98.94%
=======================================
  Files          33       33
  Lines        2176     2181    +5
=======================================
+ Hits         2153     2158    +5
  Misses         23       23

Impacted Files
Coverage Δ

robocop/checkers/misc.py
98.43% <100.00%> (+0.13%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9732e35...1a11883. Read the comment docs.


Opt avoid timestamp

@RCasatta BTW. If you're using env_logger, you should be aware of https://github.com/rust-cli/env_logger/issues/123 , maybe you want to disable regex cargo feature on it.

oh didn't know... Thanks for the info

I don't see log in perf reports of a another project of mine. I disabled regex feature of env_logger and didn't notice perf difference before/after

Did you set the RUST_LOG to anything? It kicks in only after it's actually filtering. Also - if you don't happen to have any heavy traces etc in hot loops in your deps, it might actually not be a problem.

RUST_LOG is unset, but internally I have
let mut builder = env_logger::Builder::from_env(Env::default().default_filter_or("info"));
So I supposed it could have been affected, but it seems not.


glib: make spawn*() return the SourceId

ssia

Nightly CI will fail because of https://github.com/rust-lang/rust/issues/91489


Web PayIn secure mode: "NO_CHOICE"

How can we use secure mode: "NO_CHOICE" when using thie SDK?
As per my discussion with the support team, for future support and better security/liability reduction, we should use "NO_CHOICE" option in the secure mode.
Currently, I am using "DEFAULT" mode in the secureMode option, now if I want to use secureMode: "NO_CHOICE", how can I use it?
in the index.d.ts it's having 2 options only :(
type SecureMode = "DEFAULT" | "FORCE";
So when I try to assign value of "NO_CHOICE" it's showing unacceptable value.
https://github.com/Mangopay/mangopay2-nodejs-sdk/blob/12171c46032f6809cf3f3e0f4d8c88824d8fbd19/typings/index.d.ts#L86

Hello @HardikDG,
A fix will be added to the next release (early September).
Have a nice day,

Hello @HardikDG,
This has been fixed. More information in this release note.


sqlclient does not close connections in Docker(debian)

We are seeing behaviour form the System.Data.Sqlclient is not closing the connections when its running  on the official mircosoft/dotnet docker image for linux. The connections are accumulating to over 400 connections in a couple of days on a service with little traffic. We have the same code running on a windows platform and there we do not see this behaviour.
We are running dotnet 1.1.0.

As recently announced in the .NET Blog, focus on new SqlClient features an improvements is moving to the new Microsoft.Data.SqlClient package. For this reason, we are moving this issue to the new repo at https://github.com/dotnet/SqlClient. We will still use https://github.com/dotnet/corefx to track issues on other providers like System.Data.Odbc and System.Data.OleDB, and general ADO.NET and .NET data access issues.

@saurabh500 are you confident that this issue is fixed or something the SqlClient team should investigate further?
I see customers reporting that it is fixed but also one customer saying it wasn't for him, at https://github.com/dotnet/SqlClient/issues/104#issuecomment-326533008 and also https://github.com/dotnet/corefx/issues/13422#issuecomment-326532463.

Assigning to @saurabh500 to confirm if the fix is already in.

I'm experiencing this issue as well for an app being migrated to docker+kubernetes.  The app typically has ~30 connections open but that number surges to ~200 at times.  The app is behind a load balancer and the windows version serving the same traffic uses < 10 connections.
Environment info:
<PackageReference Include="System.Data.SqlClient" Version="4.6.1" />
FROM mcr.microsoft.com/dotnet/core/runtime:2.2-alpine3.9

OS-IMAGE                       KERNEL-VERSION   CONTAINER-RUNTIME
Debian GNU/Linux 9 (stretch)   4.9.0-9-amd64    docker://18.6.3

@paalmoest
Although this is an old issue, I'm trying to regain the context. Could you confirm if the issue still exists and if yes, is it related to #129 ?

@saurabh500
Could you confirm if the fix you mentioned above in comment https://github.com/dotnet/SqlClient/issues/104#issuecomment-299057506 made it to the driver? Or it was only added to servicing branch? Please point us to the PR that was merged to address this issue.
Curious as @dbeaulieu reported this issue with S.D.S v4.6.1. We should consider moving it over to S.D.S and M.D.S if it didn't get merged in corefx - 'master' branch.

https://github.com/dotnet/corefx/commit/2e7be0c790fb89411939817ab279f287dbc29eda
According to the process, this fix was first made to master and then ported to servicing branch.

I also see the fix made for the issue in dotnet/SqlClient repo
https://github.com/dotnet/SqlClient/blob/master/src/Microsoft.Data.SqlClient/netcore/src/Microsoft/Data/SqlClient/SNI/SNITcpHandle.cs#L62-L66

@cheenamalhotra  do we have a repro at our end for this bug ?

I cannot reproduce this issue with Sync Connection.Open(), however with SqlConnection.OpenAsync executed 300 times on different tasks, makes some of the connections to leak through. I have a repro posted at https://github.com/saurabh500/sqlclientrepros/tree/master/connectionleak
The async connection paths need to be investigated here.

Update, I see TCP connections lingering around and they are being reused for subsequent connections and operations. The connection pool has a logic to clear out the connections that have been returned to the pool via SqlConnection.Close()/Dispose() after a time period of 3-5 minutes.
If I wait for 5 minutes these connections are killed.
Since there is no concrete repro for this issue, I am going to close. Please comment with a repro that can be used to show the problem.
As far as the original issue was concerned, the TcpStream was not disposed by SqlClient making the connections linger for a really long time. That issue was fixed quite some time ago as I have mention above.


SW-3637 Allow monitoring plots to straddle subzones

Previously, we required each monitoring plot to be completely contained in a
single subzone, but we no longer want to exclude such plots from eligibility
for monitoring.
Update the shapefile importer to assign monitoring plots to the subzones that
they overlap with the most.

Current dependencies on/for this PR:

main

PR #1162   👈

PR #1163

PR #1164

This comment was auto-generated by Graphite.

@sgrimm started a stack merge that includes this pull request via Graphite.

@sgrimm merged this pull request with Graphite.


How can i disable password auth when using dialog?

Such feature is not supported at this moment. Can you maybe tell me what is the specific use case so I can give a more accurate reply?

@mecid another thing you could do is using just the core library and craft the dialog yourself. Let me know!


Sort Output

there is no flag which will sort the output in ascending or descending order
Will work on adding this

Is this fixed?

Not yet
Not sure when I'll get time to work on it


Broken math font

Seems many math fonts are broken. There are a lot of errors in the console failing to load resources from KaTeX.

Their SSL certificate expired yesterday for the CSS.


Enable LO_FLAGS_DIRECT_IO by default on loopback devices

Turning on LO_FLAGS_DIRECT_IO is recommended by hch and axeboe and will improve performance of loop devices singificantly. We should turn this on.

Done!


Update README.md

I have updated the readme with three changes:

Created sections for Installation and Usage to help users on the readme page
Added installation instruction on how to install using pip
Added additional example of using LLM. This will be the primary use case and will help users.

@microsoft-github-policy-service agree


Enhancement - Options to allow key value array

Changes

Implemented functionality to support options arrays consisting of key-value pairs

Dependencies

N/A
UI/UX

Testing notes
Example:
[       { key: "option-a", value: "Option A" },       { key: "option-b", value: "Option B" }     ]

Author checklist before assigning a reviewer

[x] Reviewed my own code-diff.
[ ] Branch has been run in docker.
[x] PR assigned to me or an appropriate delegate.
[x] Relevant labels added to the PR.
[x] Appropriate tests have been added.
[x] Lint and test workflows pass.

@syedsalehinipg maybe Nikitha didn't mention during the handover, but the strategy we have RUI TypeScript migration is that all new components should be written in TypeScript and existing components get migrated when they are touched so that eventually we move everything over bit by bit.
Also, where are you planning to use this Select component? In general we should be moving to the Autocomplete.

I would also expect some updated tests to cater for this new syntax as well as ensuring the old syntax hasn't been broken.

@syedsalehinipg maybe Nikitha didn't mention during the handover, but the strategy we have with RUI TypeScript migration is that all new components should be written in TypeScript and existing components get migrated when they are touched so that eventually we move everything over bit by bit.
Also, where are you planning to use this Select component? In general we should be moving to the Autocomplete.

This was going to be for the Measures dropdown in the Unit Conversion. And regarding changing it to typescript I did think that was the idea but it's just the timeframe I planned to complete this in could be delayed if I get side tracked with changing components to typescript if I have to make any small change, hence why I didn't. But if you are okay if I don't meet what's planned then I am okay doing that.

@syedsalehinipg maybe Nikitha didn't mention during the handover, but the strategy we have with RUI TypeScript migration is that all new components should be written in TypeScript and existing components get migrated when they are touched so that eventually we move everything over bit by bit.
Also, where are you planning to use this Select component? In general we should be moving to the Autocomplete.

Should I be using the autocomplete instead? For the unit conversions I think its easier to have dropdown for a user point of view, no?
If so I can scrap this.

I think its easier to have dropdown for a user point of view, no?

The autocomplete is a dropdown but is also allows to search, thus a much improved UX over Select. Run Storybook and give the Autocomplete component a try.

I think its easier to have dropdown for a user point of view, no?

The autocomplete is a dropdown but is also allows to search, thus a much improved UX over Select. Run Storybook and give the Autocomplete component a try.

Oh yes, I see it. It is better for sure. I might have to make the same changes here too if it doesn't support key value pair options.


Add CM2-O feedstock

@andersy005 if you could merge this asap, that would help me keep my demo at the site visit tomorrow more coherent.

@jbusecke, i'm going to merge this shortly. however, it might not work in the data viewer because it appears this dataset uses the scale_factor and offset feature to store the data. the data viewer doesn't have support for the mask_and_scale(https://docs.xarray.dev/en/stable/generated/xarray.decode_cf.html#xarray.decode_cf)

Got it. That would be a pretty important feature to support? Or would this be sidestepped by the pyramids?

Or would this be sidestepped by the pyramids?

unfortunately no. i just ran a quick smoke test to confirm this

eek!


Useless error when ca-certificates are missing

I was trying to cargo build something in a newly created chroot and got the following output:
    Updating registry `https://github.com/rust-lang/crates.io-index`
warning: spurious network error (2 tries remaining): curl error:
; class=Net (12)
warning: spurious network error (1 tries remaining): curl error:
; class=Net (12)
error: failed to fetch `https://github.com/rust-lang/crates.io-index`

Caused by:
  curl error:
; class=Net (12)

Even with colors, this is not a great error message.
Strace hinted me that /etc/ssl/certs/ca-certificates.crt was missing, and sure enough, it worked after installing the ca-certificates package. But that wasn't thanks to cargo's error message.

This happens on Windows as well, where ca-certificates.crt is not the solution.

Ahh okay, thought it was just me. Yesterday it was working fine and today also got this same error (Win7 x64). Also tried meddling around in the cert-store without any success.

Might this be due to https://github.com/blog/2507-weak-cryptographic-standards-removed ?
If so, this might have just broken a lot of Rust users...

@retep998 pointed me to this Windows update's docs, and I can confirm that applying the reg key mentioned there fixed it for me immediately.
New-ItemProperty 'HKLM:\SOFTWARE\Microsoft\Windows\CurrentVersion\Internet Settings\WinHttp' -Name DefaultSecureProtocols -PropertyType DWORD -Value 0x00000800

We need to put out a huge announcement for this on the rust blog alerting all Windows 7 users to apply that fix, and also make it a prominent entry in any sort of FAQ or troubleshooting guide we have.

An additional thing we should do to reduce the impact of this in the future, whenever Cargo fails in this manner, it should check if it is on Windows 7, and if so check for those registry keys and their values. If the registry keys aren't set appropriately, it should give the user a really loud warning about how they need to fix their Windows 7 and provide detailed instructions on how to fix it.

Because this issue is technically supposed to be about poor error messages when ca-certificates.cert is missing on nix systems, all discussion of the Windows 7 specific issue is being moved to a new issue.
https://github.com/rust-lang/cargo/issues/5066

@glandium where'd you acquire Cargo from and what Linux distribution were you using? Using the officially shipped binaries and Ubuntu I get:
$ docker run -v `rustc +nightly --print sysroot`:/rust:ro -it ubuntu:16.04 /rust/bin/cargo install ripgrep
    Updating registry `https://github.com/rust-lang/crates.io-index`
error: failed to fetch `https://github.com/rust-lang/crates.io-index`

Caused by:
  the SSL certificate is invalid; class=Ssl (16); code=Certificate (-17)

so I'm not sure how to reproduce this :(

I was using the debian packages. Arguably, the cargo package should depend on ca-certificates, and I might file a bug for that.
Anyways, I tried again on another platform, and it turns out I do get the same error as you do. So I tried again on the original platform I tried, and I can confirm it happens there. So I went around, and this is the result: this happens on s390x, arm64, armhf, i386, ppc64el, but not on amd64.

@glandium you mention this reproduces with i386 but I was also unable to reproduce? Are these official builds or debian builds?

Debian packages.

Perhaps this is a misconfiguration in the debian build? Maybe a bug in the libgit2/openssl bindings? Sorry I'm not really sure how to go from this to a more narrow cause which can be fixed.

I was able to reproduce with a fresh build of cargo from master by building with LIBGIT2_SYS_USE_PKG_CONFIG=1 and having libgit2-dev installed.

If that option isn't used does it work?

It does.

If so then libgit2 version is probably mismatched as the crate is only compatible with one at a time

If that's really the case, then it should fail to build if the wrong version is used. However, I'll note that I while I am reproducing when building with LIBGIT2_SYS_USE_PKG_CONFIG=1 on amd64, the Debian cargo package on amd64 does not have the problem, even though it's built against the libgit2 system package, with the same version. Which is puzzling. Plus the fact that it does happen with the Debian cargo package on all other platforms, with the same libgit2 version too.

git2-rs by default doesn't use pkg-config and opting in is allowed for packages who have verified that the version works, but it looks like that hasn't been done here?
In any case sounds like this is https://github.com/alexcrichton/git2-rs/issues/304, so I'm going to close in favor of that.


fix: added cert-manager, acme and external-dns

awesome - I think we can remove the jx-values.yaml files as they are generated, if we do that I think we can merge this


[CRA4] ForkTsCheckerWebpackPlugin causes builds to take 50-100x as long

Describe the bug
On react-scripts build, my builds for a fairly small project now take around 10mins. Obviously this is bad.
I poked around node_modules/react-scripts and deleted this part of the config:
useTypeScript &&
        new ForkTsCheckerWebpackPlugin({
          typescript: resolve.sync('typescript', {
            basedir: paths.appNodeModules,
          }),
          async: isEnvDevelopment,
          checkSyntacticErrors: true,
          resolveModuleNameModule: process.versions.pnp
            ? `${__dirname}/pnpTs.js`
            : undefined,
          resolveTypeReferenceDirectiveModule: process.versions.pnp
            ? `${__dirname}/pnpTs.js`
            : undefined,
          tsconfig: paths.appTsConfig,
          reportFiles: [
            // This one is specifically to match during CI tests,
            // as micromatch doesn't match
            // '../cra-template-typescript/template/src/App.tsx'
            // otherwise.
            '../**/src/**/*.{ts,tsx}',
            '**/src/**/*.{ts,tsx}',
            '!**/src/**/__tests__/**',
            '!**/src/**/?(*.)(spec|test).*',
            '!**/src/setupProxy.*',
            '!**/src/setupTests.*',
          ],
          silent: true,
          // The formatter is invoked directly in WebpackDevServerUtils during development
          formatter: isEnvProduction ? typescriptFormatter : undefined,
        }),

My builds now take about 10 seconds!
Please give us the option to disable this using an env such as DISABLE_TS_CHECKER=true, 10min+ builds are absurd! I can PR but I don't know what the latest CRA4 branch is.

same problem here. Any hints / ideas on how to improve that situation?

@mdugue I just have node_modules/react-scripts/config/webpack.config.ts open in a tab, and whenever I yarn I change
      useTypeScript &&

to
      useTypeScript && false

hehe… nice workaround. Would be great to have a baked-in solution…
Btw: My workaround was transitioning that project to nextjs 😅


Fix reading stdio

lost end of stream when reading in form of
    auto input = std::shared_ptr<arrow::io::InputStream>(new arrow::io::StdinStream());
    arrow::Result<int64_t> res;
    char buffer[16];
    while ((res = input->Read(sizeof(buffer), buffer)) != 0) {
        std::cerr << std::string_view(buffer, *res);
    }

the PR fix the issue

https://github.com/apache/arrow/issues/35007

Hi @resetius, thank you for the patch. Sorry for the delay in getting to this. Would you be willing to add a unit test for your failing example?

Would you be willing to add a unit test for your failing example?

Updated the PR. Not sure if I inserted the tests in the right place.


[ceph] Migrate ceph impl to SinkBinding

ContainerSource is deprecated, SinkBinding is the new way to add the source contract to a PodSpecable.
ContainerSource will be removed in 0.14
/assign yuvalif

In favor of #1255, this also needs to be done.
The doc to follow: https://github.com/knative/docs/blob/master/docs/eventing/migration/sinkbinding.md
The replacement also contains the update of Channel and Subscription v1alpha1 to v1beta1 in the samples.
/assign tom24d


[SPARK-12686][SQL] Support aggregation push down into data sources

What changes were proposed in this pull request?
This PR enable Sum/Count/Average/Max/Min partial aggregation push down into data sources for logical plan nodes like Aggregate -> Project -> (Filter) -> Scan.
The data sources need to implement the new added trait AggregatedFilteredScan and set spark.sql.aggregation.pushdown to true.

Can one of the admins verify this patch?

@rxin any suggestions?

@kisimple We are working on the Data Source API v2. Could you close this PR? Thanks!


Implement log storage across sessions and logs download

Fix #1112
It was implemented using loglevel and idb, a feature library which wraps IndexedDB, an efficient, modern browser storage API which allows us to store the (log) items independently and asynchronously, without requiring serializing the items ourselves.

@nephix There's no follow up issues from my stand point or from the initial requirements.
Please, feel free to open them if you have a different opinion on that and would like to call it for discussion.

These issues result from your PR, not from the requirements of the initial ticket. Therefore, please create them

What issues are you referring to? I can't see an issue resulting from my PR beyond your wish to have done a part of it differently, which couldn't be implied from the original issue nor requirements, nor is a problem with the PR itself but a matter of taste, which I, as the implementer, disagree, and therefore needs discussion with the whole team to decide if or when we're going to change what was done. Therefore, I won't create issues I don't see as existent. Feel free to create them if you see.

The original ticket was created by you, as well as the acceptance criteria and we already discussed the logging feature and what should be done. Looks like you only picked acceptance criteria that suit you?
But your choice 🤷♂

I was asked to write the issue, not offered me, and put as acceptance criteria everything I remembered from the discussion, and I definitely don't remember the points raised by you after you saw the PR ready. I'm not saying it won't be done, but instead that, as our perspective about what were the original requirements diverge, and I'm on the status quo side about it, possible changes can be discussed and decided on appropriate issues, but I'm not the one proposing them and therefore am not the responsible for creating them, but completely support you thinking differently, creating the issues, calling for discussion and, if the majority agrees with the proposal, it'll get implemented, maybe even by me, or whoever gets assigned to the newly decided issue.


Auto fix tags.

Hey there can you provide auto fixing via a cli flag or golangci-lint's built in fix API? So that I can solve all the issues just by a single command.

Hello,
Yes it's something that I want to add.
Right now I'm working on an improvement of the configuration.


[Vulkan] Updated Vortice.Vulkan package to the latest version

PR Details
Updated Vortice.Vulkan package to the latest version (1.2.167 -> 1.9.8)
Related Issue

Types of changes

[x] Docs change / refactoring / dependency upgrade
[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist

[ ] My change requires a change to the documentation.
[ ] I have added tests to cover my changes.
[ ] All new and existing tests passed.
[x] I have built and run the editor to try this change out.

Looks good, thanks a bunch @Feralnex - did you test a game built under vulkan with these changes ?

@Eideren only "New game" example from stride templates. Would be good if somebody with more advanced project could test it before merging

Vortice.Vulkan is now 2.1.0. The linked issue has response fromt the author, if a help is required.

Sorry for the delay, I'm still unpacking things (I moved to a new flat). I'll update it in a new year if nobody wants to take it over ; ) I'll come back to Stride in the second part of January or in February

Thanks for an update. Take your time. Hope to see you around once you are settled 🙂.


Remove box from the playground

Is your feature request related to a problem? Please describe.
After adding boxes with examples in the playground we cannot remove them
Describe the solution you'd like
A small garbage can button on each box that when clicked remove this example from the playground

@mmabrouk You can assign this to me!

Done! Thanks @witehound !


Add color to Typography

This PR implements https://github.com/okp4/ui/issues/472.
It add a color to Typography component to inverse the basic text color theme.

Codecov Report

Merging #473 (42e24bd) into main (33f06a3) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #473   +/-   ##
=======================================
  Coverage   98.27%   98.27%
=======================================
  Files          73       73
  Lines         811      811
  Branches      128      128
=======================================
  Hits          797      797
  Misses         12       12
  Partials        2        2

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

♻ The PR https://github.com/okp4/ui/pull/475 replace this one.


Add atomic locking mechanism to Ephemera Asset

Should allow a cacheAsset calls to lock the asset so that only one can ever be running against it at a time.
Must include a timeout mechanism to guarantee that the lock can be released even if the process holding it fails, and a ConditionCheck to prevent a process whose lock has been timed out from writing to the asset

No longer necessary, after improvements in the concurrent, eventually-consistent processing of cacheAsset


dependent packages requires manifest.yml and doesn't support manifest.yaml

wskdeploy does not support dependent packages which has manifest.yaml file. It only deploys dependent package with manifest.yml. Please add support for manifest.yaml. Refer to integration test on dependency for more info: https://github.com/apache/incubator-openwhisk-wskdeploy/tree/master/tests/src/integration/dependency

@pritidesai , I can't reproduce this issue, could you help confirm.
I forked your repo here.https://github.com/lzbj/openwhisk-app
then I changed the yaml like this:
diff --git a/tests/src/integration/dependency/manifest.yaml b/tests/src/integration/dependency/manifest.yaml
index f76390d..e85bc4b 100644
--- a/tests/src/integration/dependency/manifest.yaml
+++ b/tests/src/integration/dependency/manifest.yaml
@@ -2,7 +2,7 @@ package:
name: TestGitHubDependency
dependencies:
openwhisk-app:

 location: github.com/pritidesai/openwhisk-app

 location: github.com/lzbj/openwhisk-app

triggers:
trigger1:

THen I run the deploy.
2017/08/30 14:15:18 Unmarshal Openwhisk info from internet
2017/08/30 14:15:18 The URL is https://openwhisk.ng.bluemix.net/api, selected from .wskprops
2017/08/30 14:15:18 The auth key is set, selected from .wskprops
2017/08/30 14:15:18 The namespace is<EMAIL_ADDRESS>selected from .wskprops
2017/08/30 14:15:21 Deploying package TestGitHubDependency ...
2017/08/30 14:15:22 Done!

Done!
Done!
Done!
Deploying rule rule1 ... Done!
Deploying rule rule2 ... Done!
2017/08/30 14:15:26
Deployment completed successfully.

I have already changed the yaml file in my repo to .yaml, did I miss some steps to reproduce?

nope @lzbj doesn't look like you missed anything, I am not able to reproduce as well, but now running into different issue, @daisy-ycguo can you please check? I just replaced location with function in manifest file.
go test ./tests/src/integration/dependency/ -tags=integration -run=TestDependency -v
=== RUN   TestDependency
wskdeploy.Path is wskdeploy
==> Executing: wskdeploy -m /Users/pritidesai/Documents/goworkspace/src/github.com/apache/incubator-openwhisk-wskdeploy/tests/src/integration/dependency/manifest.yaml -d
==> Output: 2017/08/30 01:01:48 Unmarshal Openwhisk info from internet
2017/08/30 01:01:48 The URL is https://openwhisk.ng.bluemix.net/api, selected from .wskprops
2017/08/30 01:01:48 The auth key is set, selected from .wskprops
2017/08/30 01:01:48 The namespace is ****, selected from .wskprops
2017/08/30 01:01:48 Deploying package TestGitHubDependency ...
2017/08/30 01:01:48 Done!
Done!
Done!
Deploying rule rule2 ... 2017/08/30 01:01:48 Got error creating rule with error message: The requested resource does not exist. (code 40237943) and error code: 148.
2017/08/30 01:01:48 Got error activating rule with error message: The requested resource does not exist. (code 40237946) and error code: 148.
Done!
Deploying rule rule1 ... 2017/08/30 01:01:49 Got error creating rule with error message: The requested resource does not exist. (code 40237959) and error code: 148.
2017/08/30 01:01:49 Got error activating rule with error message: The requested resource does not exist. (code 40237969) and error code: 148.
Done!
2017/08/30 01:01:49
Deployment completed successfully.

wskdeploy.Path is wskdeploy
==> Executing: wskdeploy undeploy -m /Users/pritidesai/Documents/goworkspace/src/github.com/apache/incubator-openwhisk-wskdeploy/tests/src/integration/dependency/manifest.yaml -d
==> Output: 2017/08/30 01:01:49 Unmarshal Openwhisk info from internet
2017/08/30 01:01:49 The URL is https://openwhisk.ng.bluemix.net/api, selected from .wskprops
2017/08/30 01:01:49 The auth key is set, selected from .wskprops
2017/08/30 01:01:49 The namespace is **** selected from .wskprops
Removing trigger trigger1 ... Done!
Removing trigger trigger2 ... Done!
Removing rule rule2 ... 2017/08/30 01:01:49 Got error deleting rule with error message: The requested resource does not exist. (code 40238025) and error code: 148.
Removing rule rule1 ... 2017/08/30 01:01:50 Got error deleting rule with error message: The requested resource does not exist. (code 40238031) and error code: 148.
Removing package TestGitHubDependency ... Done!

Deployment removed successfully.

--- PASS: TestDependency (2.45s)
PASS
ok      github.com/apache/incubator-openwhisk-wskdeploy/tests/src/integration/dependency        2.471s

@pritidesai  In the specification, the properties under dependencies are: location, version and inputs. So please don't change it to function. Our code doesn't support function under dependencies. We only support function under action.

@lzbj @priti Please see that we no longer use hardcoded "manifest.yaml" in any function when possible.  See grep:
``
grep -r ""manifest.yaml" . --include=*.go
./cmd/add.go:		parsers.Write(maniyaml, "manifest.yaml")
./cmd/add.go:		parsers.Write(maniyaml, "manifest.yaml")
./cmd/add.go:		parsers.Write(maniyaml, "manifest.yaml")
./cmd/init.go:		parsers.Write(maniyaml, "manifest.yaml")
./cmd/root.go:		if _, err := os.Stat(path.Join(projectPath, "manifest.yaml")); err == nil {
./deployers/shared.go:const ManifestFileNameYaml = "manifest.yaml"
./parsers/manifest_parser.go:	if _, err := os.Stat("manifest.yaml"); err == nil {
./parsers/manifest_parser.go:		dat, _ := ioutil.ReadFile("manifest.yam")

verified hardcoding of manifest and deployment is gone with PR #424

/deployers/whiskclient.go:    MANIDESTFILE = "manifest.yml"

./cmd/root.go:          } else if _, err := os.Stat(path.Join(projectPath, "deployment.yml")); err == nil {
./cmd/root.go:          } else if _, err := os.Stat(path.Join(projectPath, "deployment.yml")); err == nil {
./deployers/whiskclient.go:    DEPLOYMENTFILE = "deployment.yml"

./cmd/root.go:          if _, err := os.Stat(path.Join(projectPath, "deployment.yaml")); err == nil {
./cmd/root.go:          if _, err := os.Stat(path.Join(projectPath, "deployment.yaml")); err == nil {

addressing function vs location in issue https://github.com/apache/incubator-openwhisk-wskdeploy/issues/427


Fixes #441 removes the console log error from the test

The exception thrown is expected as we're passing in the invalid directories in the tests, etc.

@designfrontier can you review this again!
I went with whatever is being returned from the error instead of custom formatted string and it includes the routeErrorText also.


"Access Denied - Character 'Char. Name' is Not Authorized to Login"

So I'm trying to sign into pathfinder to find a damn Wormhole, and no matter what I do, I get "Access Denied - Character 'Char. Name' is Not Authorized to Login" every time. I've tried three different browsers, and have tried clearing my cookies + cache. Nothing works. I suspect it might be an issue with the EVE account itself, but I can't find anything to fix the issue. Any help would be great, thank you!

Are you using the official (hosted) pathfinder or running your own instance?

I'm running it from the official website, so I suppose it would be the first one you mentioned.

I also have this issue and I havn't found any solutions so far

Same here, been dealing with this for the past two weeks. Nothing has worked, unfortunately.

Just wait for new PF version, there will be switch to ESI, maybe this will solve your problem.

Hehe I´m getting same error as you now.

:heavy_check_mark: Issue resolved
This issue was resolved by the commit(s) and/or the comments above.
It will be auto-closed with the upcoming release ( merge into master branch). Please check the attached Milestone information.
Many thanks to all participants/contributors for the helpful comments! :+1:
:information_source: Please reopen/comment this, if you have problems/questions about it.

Auto-generated response


No nullbyte character appended on struct discord message->content

I found that there is no nullbyte character appended to struct discord message->content when you get it with discord_get_channel_messages(client, message->channel_id, &params, &msgs);. Here's how I found the bug when trying to implement a counter channel filter system:
void on_message_create(struct discord *client, const struct discord_user *bot, const struct discord_message *message) {
    switch (message->channel_id) {
        case C_COUNTER: {
            size_t val = atoi((char*)message->content);
            if (val) {
                NTL_T(struct discord_message) msgs = NULL;
                struct discord_get_channel_messages_params params = {.limit = 2};
                discord_get_channel_messages(client, message->channel_id, &params, &msgs);
                if (!msgs) break;
                else {
                    // No nullbyte
                    size_t prev_val = atoi((char*)msgs[1]->content);
                    if (val-1 == prev_val) break;
                    else discord_delete_message(client, message->channel_id, message->id);
                }
            }
            else discord_delete_message(client, message->channel_id, message->id);
            break;
        }
        default: break;
    }
}

what is the value of C_COUNTER?
How long is your message?

Just the channel id of the channel as an int literal as following. I tested it with various lengths but mostly 1-5
#define C_COUNTER<PHONE_NUMBER>43655936

connect should be null terminated. Can you please use log_info to print out it's value?

Is that a function of some sort? I am unable to find log_info

I apologize, but may I ask how I can print with the log_info macro? I tried putting content as the argument, but I couldn't figure out how to get it to write to the stdout buffer

I apologize, but may I ask how I can print with the log_info macro? I tried putting content as the argument, but I couldn't figure out how to get it to write to the stdout buffer

Do you have a bot.log file being generated after each execution? You can also edit bot.config and set "quiet" field to true in order to print logging information to your terminal!

I apologize, but may I ask how I can print with the log_info macro? I tried putting content as the argument, but I couldn't figure out how to get it to write to the stdout buffer

log_info is just like the printf function, but it's for logging only.   You  use fprintf(stderr, too.

I dearly apologize, there was nothing wrong with message->content, it was just my code that was bad...

I dearly apologize, there was nothing wrong with message->content, it was just my code that was bad...

Happens to the best of us lol! I'll be closing this one then

You can use strtol to do the conversation and use the 2nd parameter to check if the conversation is successful or not.

On May 14, 2021, at 3:52 PM, Lucas Müller @.***> wrote:

I dearly apologize, there was nothing wrong with message->content, it was just my code that was bad...
Happens to the best of us lol! I'll be closing this one then
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or unsubscribe.

Thank you!


Proposal docs(controller): add users:list endpoint

Fixes #2006
Once this api gets the OK, I will implement it.

docs LGTM

:thumbsup:

Added code but still need to write specs.

I added tests so this is ready to be reviewed again. CI failed but it seems to be broken for everybody with: Error response from daemon: No such container: deis-store-volume

CI failed but it seems to be broken for everybody with: Error response from daemon: No such container: deis-store-volume

That's a bit confusing, but not the error that caused the build to stop. It looks like you hit a sporadic issue while waiting for the containers to come up.
I'm hoping we can rebase this once #3295 is merged, since that should result in more PRs passing regularly.

@Joshua-Anderson Can you rebase this please? We've fixed some test-related things in master and they're passing more smoothly now. Thanks!

Rebased

Jenkins, test this please.

Could somebody with permission please poke Jenkins to re-run the tests on this PR.

on it!
https://ci.deis.io/job/test-ec2/80/

I made a mistake on my tests and fixed it, could you possible poke Jenkins again. :smile:

Thanks for running it again. Do you have any idea what happened with this failure? It happened before my test even ran and it seems unreleated.
Also, do I need to create a new version of the api since I am adding this feature or can my docs just stay in v1.1?

This finally made it through the QA gauntlet successfully. Thanks for your patience @Joshua-Anderson.

do I need to create a new version of the api?

It's a backward-compatible feature, so it can go in a minor release of Deis. But I think any change to the REST API does require its version to be incremented. ping @bacongobbler.

Thanks for the contribution! Please ensure your commits follow our style guide. This code will be tested once a Deis maintainer reviews it.

yep. new feature = API bump

@Joshua-Anderson see https://github.com/bacongobbler/deis/commit/a37644e56fa5f68e612e655cd2faee85737b6d5e for an example

IRT to the test infrastructure, this implementation looks good to me, though I think the endpoints should also be covered in the unit tests so we have the server-side covered when writing out new API features and testing out the endpoints via manage.py. We can do this at a later date though and it's not a blocker IMO

Didn't know about those tests,  I will send another PR once this gets merged for this. I'll bump the API version when I am in front of the computer on Sunday.

Should I add this PR to the v1.2 api version or bump to v1.3?

Let's make it v1.2. I'll orchestrate my PR and update it accordingly as it's gonna need more testing. :)

:+1:

@Joshua-Anderson since API v1.2 did get released with Deis v1.5.0, this should bump the API version to v1.3 instead. Also I agree this should have unit tests in controller covering all endpoints, and it needs a rebase.

@mboersma I bumped the api version to 1.3, added controller tests, and managed a rebase, but CI is not running on the PR. Could you please start a job for it.

code LGTM

https://ci.deis.io/job/test-ec2/450/

@bacongobbler I made your changes and fixed some CI test failures. Could you please run CI again?

Jenkins, add to whitelist.

Code LGTM, but I'd like both @bacongobbler and @mboersma to have eyes on this.

Code LGTM. Thanks for accommodating all our changes!


CLI - Issues upgrading ova to current sift through proxy

After installing the current ova download in vmware, and running apt-get upgrade, I attempted to upgrade it to the current sift version (through our internet proxy) using the CLI. This fails with the following error:
$ sift upgrade

<EMAIL_ADDRESS>sift-version: v2018.16.0

write EPROTO<PHONE_NUMBER>12544:error:140770FC:SSL routines:SSL23_GET_SERVER_HELLO:unknown protocol:../deps/openssl/openssl/ssl/s23_clnt.c:794:
Error: write EPROTO<PHONE_NUMBER>12544:error:140770FC:SSL routines:SSL23_GET_SERVER_HELLO:unknown protocol:../deps/openssl/openssl/ssl/s23_clnt.c:794:
at module.exports.__dirname.sendError (/snapshot/Users/ekristen/Development/sift/sift-cli/node_modules/github/lib/index.js:854:19)
at /snapshot/Users/ekristen/Development/sift/sift-cli/node_modules/github/lib/index.js:865:29
at callCallback (/snapshot/Users/ekristen/Development/sift/sift-cli/node_modules/github/lib/index.js:728:17)
at ClientRequest.<anonymous> (/snapshot/Users/ekristen/Development/sift/sift-cli/node_modules/github/lib/index.js:807:17)
at emitOne (events.js:96:13)
at ClientRequest.emit (events.js:191:7)
at emitErr (/snapshot/Users/ekristen/Development/sift/sift-cli/node_modules/agent-base/agent.js:88:11)
at /snapshot/Users/ekristen/Development/sift/sift-cli/node_modules/agent-base/agent.js:99:9
at TLSSocket.onerror (/snapshot/Users/ekristen/Development/sift/sift-cli/node_modules/https-proxy-agent/https-proxy-agent.js:104:5)
at emitOne (events.js:96:13)
at TLSSocket.emit (events.js:191:7)
at onwriteError (_stream_writable.js:341:10)
at onwrite (_stream_writable.js:359:5)
at fireErrorCallbacks (net.js:481:13)
at TLSSocket.Socket._destroy (net.js:522:3)
at WriteWrap.afterWrite [as oncomplete] (net.js:816:10)

Generally that's the sort of error you get when it's attempting to either talk SSL to something that can't talk SSL or it truly has a version of SSL that's unknown and unsupported.

Still an issue for me... Anyone know of a way to get this to work through a proxy? I was able to get it to work in one previous version, and posted the specific steps required in Issue #236, but they no longer work...


Manipulating images with sharp is causing Node to crash

Possible bug
Is this a possible bug in a feature of sharp, unrelated to installation?

[x] Running npm install sharp completes without error.
[x] Running node -e "require('sharp')" completes without error.

Are you using the latest version of sharp?

[x] I am using the latest version of sharp as reported by npm view sharp dist-tags.latest.

What is the output of running npx envinfo --binaries --system --npmPackages=sharp --npmGlobalPackages=sharp?
  System:
    OS: macOS 12.6
    CPU: (8) x64 Apple M1 Pro
    Memory: 34.55 MB / 16.00 GB
    Shell: 3.2.57 - /bin/bash
  Binaries:
    Node: 18.14.0 - ~/.nvm/versions/node/v18.14.0/bin/node
    Yarn: 1.19.1 - /usr/local/bin/yarn
    npm: 9.3.1 - ~/.nvm/versions/node/v18.14.0/bin/npm
  npmPackages:
    sharp: ^0.32.1 => 0.32.1

What are the steps to reproduce?
I have an endpoint that will manipulate some images that are sent to it. I am cloning and changing the image size and getting the buffer of it using Sharp. Manipulation is done in parallel using Promise.allSettled. When I run only one image through manipulation, I get the result the first time, but next time I get the segfault. Running multiple images I always get errors. I tried both Node 16 and 18 but the issue is still there, and I am using the latest version of sharp 0.32.1. When I turn manipulation off and just return the images (completely removed sharp) I get no errors.
What is the expected behaviour?
to not get SIGSEGV or SEGFAULT

await sharp(image)
        .clone()
        .resize(width)
        .toBuffer()

Please provide sample image(s) that help explain this problem

Seems related to https://github.com/lovell/sharp/issues/3677#issue-1721529341, I was able to resolve it by adding sharp.simd(false) immediately after importing the sharp. However, this is merely a temporary fix rather than a comprehensive solution. Other users may encounter similar issues and waste their time (like I did 😢). It is essential that we take appropriate action to address this problem promptly and incorporate the fix ASAP.

I can still replicate the issue, but not sure how to get backtrace on SIGSEGV. Is report when running it with --report-uncaught-exception --report-on-signal --report-on-fatalerror enough or should I do something else? Can you help?

$ lldb node app.js
...
(lldb) run
...
wait for crash
...
(lldb) bt

$ lldb node app.js
...
(lldb) run
...
wait for crash
...
(lldb) bt

Process 63390 stopped
* thread #19, name = 'libvips worker', stop reason = EXC_BAD_ACCESS (code=1, address=0x0)
    frame #0: 0x0000000115500776
->  0x115500776: pmullw %mm3, %mm5
    0x115500779: paddw  %xmm2, %xmm5
    0x11550077d: psraw  $0x6, %xmm5
    0x115500782: paddsw %xmm5, %xmm6
  thread #22, name = 'libvips worker', stop reason = EXC_BAD_ACCESS (code=1, address=0x7fffffffffffffff)
    frame #0: 0x000000015087b2ec libvips-cpp.42.dylib`orc_executor_run + 27
libvips-cpp.42.dylib`orc_executor_run:
->  0x15087b2ec <+27>: movq   (%rax), %rax
    0x15087b2ef <+30>: testq  %rax, %rax
    0x15087b2f2 <+33>: je     0x15087b2f7               ; <+38>
    0x15087b2f4 <+35>: popq   %rbp
  thread #24, name = 'libvips worker', stop reason = EXC_BAD_ACCESS (code=1, address=0x0)
    frame #0: 0x00000001155015a6
->  0x1155015a6: outsb  (%rsi), %dx
  thread #27, name = 'libvips worker', stop reason = EXC_BAD_ACCESS (code=1, address=0x0)
    frame #0: 0x0000000115500776
->  0x115500776: pmullw %mm3, %mm5
    0x115500779: paddw  %xmm2, %xmm5
    0x11550077d: psraw  $0x6, %xmm5
    0x115500782: paddsw %xmm5, %xmm6
  thread #33, name = 'libvips worker', stop reason = EXC_BAD_ACCESS (code=1, address=0x0)
    frame #0: 0x0000000115500776
->  0x115500776: pmullw %mm3, %mm5
    0x115500779: paddw  %xmm2, %xmm5
    0x11550077d: psraw  $0x6, %xmm5
    0x115500782: paddsw %xmm5, %xmm6
  thread #34, name = 'libvips worker', stop reason = EXC_BAD_ACCESS (code=1, address=0x7fffffffffffffff)
    frame #0: 0x000000015019f49e libvips-cpp.42.dylib`vips_format_sizeof_unsafe + 14
libvips-cpp.42.dylib`vips_format_sizeof_unsafe:
->  0x15019f49e <+14>: movq   (%rcx,%rax,8), %rax
    0x15019f4a2 <+18>: popq   %rbp
    0x15019f4a3 <+19>: retq
    0x15019f4a4 <+20>: nopw   %cs:(%rax,%rax)
Target 0: (node) stopped.
(lldb) bt
* thread #19, name = 'libvips worker', stop reason = EXC_BAD_ACCESS (code=1, address=0x0)
  * frame #0: 0x0000000115500776
(lldb)

Thank you, this looks very much like #3677, let's close this and continue to track it there.


Ability to assert the latest record only?

Allow to assert against just the latest record inserted in the database.

Example:
Then I should have 2 "user" records? with<EMAIL_ADDRESS>in the database?

Another idea could be to introduce this as part of the query language, something like:
Then I should have a "user" where "email:its.inevitable@hotmail.com::order by id limit 1 desc"
This would be an easier approach, with no changes to the step definitions.

We don't want any assertions to be part of the sql extension, this is purely to assist creating of fixture data not asserting.


Use IISPlatformHandler instead Microsoft.AspNet.Server.IIS

Use IISPlatformHandler instead Microsoft.AspNet.Server.IIS

Hi @Kagamine, I'm your friendly neighborhood .NET Foundation Pull Request Bot (You can call me DNFBOT). Thanks for your contribution!

In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes. I promise there's no faxing. https://cla2.dotnetfoundation.org.

TTYL, DNFBOT;

@Kagamine, Thanks for signing the contribution license agreement so quickly! Actual humans will now validate the agreement and then evaluate the PR.
Thanks, DNFBOT;

it seems something wrong with https://github.com/aspnet/IISIntegration

Hi @Kagamine, I'm your friendly neighborhood .NET Foundation Pull Request Bot (You can call me DNFBOT). Thanks for your contribution!
You've already signed the contribution license agreement. Thanks!
The agreement was validated by .NET Foundation and real humans are currently evaluating your PR.
TTYL, DNFBOT;

Also please squash the commits when you have a chance, thanks!


merge from template-esm-only

.github/workflows/ci.yml

chore(deps): remove 18.18.2 (jobs.test-node.strategy.matrix.node-version)

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 86.766%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
2469

Relevant Lines:
2830

💛  - Coveralls


Conda collections not available for Mac OSX

Not sure if you want to support that, but the builds seem to be only available for linux-64, so when you try to run the installer on a Mac system, this is what you get:
(master)guillem@Guillermos-MacBook-Air-2:~/bcbio-docker$ conda install --yes -c https://conda.binstar.org/collections/chapmanb bcbio-nextgen-vm
Error: HTTPError: 404  NOT FOUND  https://conda.binstar.org/collections/chapmanb/osx-64/

I'll have a look and try to build the packages for MacOSx

Guillermo;
We fully support Mac OSX conda packages for bcbio and bcbio-vm now and will keep them up to date with new releases. conda convert allows us to make OSX packages for the regularly changing bcbio conda releases, since they are python-only. We'll manually re-create Mac OSX packages for any new dependency releases with C extensions, since those are infrequent. We're still working on supporting Docker runs on OSX, and I've detailed the current status in the README. Happy to have help or suggestions on the Docker part from any Mac/Docker experts. Thanks much.

Hi Brad,
Really appreciate this work, thanks you very much! And sorry for not having contributed as I would have liked to :-/
As soon as I can I'll try to deploy bcbio-nextgen on my mac and let you guys know if I encounter problems.
Thanks again!


Create an Author account on OctoberCMS.com

For this plugin to be published in the OctoberCMS marketplace, there must be an official Hydrogen account.
Registration can be done here: https://octobercms.com/account/register

Done... Should I proceed to add a project?

Please provide me with the account credentials so I can prepare the plugin for submission to the Marketplace.


Downgrade absence of sub- folders to warning

I could be wrong but I think there is no strict and agreed upon requirement to require having sub- subfolders in BIDS specification. Although odd, thus warranting a warning, I think it is not strictly forbidden, and e.g. a BIDS dataset only with stimuli/ or derivatives/ or sourcedata might still be well legit BIDS dataset.
Check was added in b9ea963df27ded2c4363199c4c030c0229f2d1e2 likely just copying from prior node version of bids-validator.  Asking @effigies for setting me straight ;)

I don't see the use-case for subject-less datasets. Calling a directory that contains opaque sourcedata/ and derivatives/ directories a BIDS dataset seems counter to the goal of BIDS, which is legible neuroimaging data. What's your goal?

immediate, although not mandatory if we do add dedicated DatasetType:

https://github.com/bids-standard/bids-specification/pull/1861
and inline with that -- it could be neuro*-related (BIDS is beyond MRI for a while already) dataset of stimuli/, or purely phenotype/ data and IMHO could still be quite legit without "neuroimaging" or per subject data. Also group level results in derivatives etc.

But also it is a matter of consistency: if there is such a rule it should be clearly described also in the specification, which I think is not the case ATM.
Indeed it might require openneuro specific configuration, but I thought you already have one anyways.


Configure Thumbor to use an AWS S3 bucket

Configure Thumbor to load images from an AWS S3 bucket.

The Thumbor Docker image I'm using may not be popular/well maintained:

beeyev/thumbor-s3 has 610 pulls on Docker Hub
beeyev/thumbor-s3 has 24 stars on GitHub


Scrapy: ModuleNotFoundError: No module named 'scrapoxy'

Hello,
I have integrated scrapoxy into my scrapy project as detailed in the official docs. I tried to run a spider and I ended up with the below error. The error happens only on my server machine Debian 8 but in my local Ubuntu 14.04 development environment no such issue has reviled and every thing runs as expected.
2018-11-16 11:03:44 [scrapy.utils.log] INFO: Scrapy 1.5.1 started (bot: myscraper)
2018-11-16 11:03:44 [scrapy.utils.log] INFO: Versions: lxml <IP_ADDRESS>, libxml2 2.9.8, cssselect 1.0.3, parsel 1.5.1, w3lib 1.19.0, T
wisted 18.9.0, Python 3.6.5 |Anaconda, Inc.| (default, Apr 29 2018, 16:14:56) - [GCC 7.2.0], pyOpenSSL 18.0.0 (OpenSSL 1.0.2p  14
Aug 2018), cryptography 2.3.1, Platform Linux-3.16.0-7-amd64-x86_64-with-debian-8.11
2018-11-16 11:03:44 [scrapy.crawler] INFO: Overridden settings: {'BOT_NAME': 'myscraper', 'CONCURRENT_REQUESTS_PER_DOMAIN': 1,
 'DOWNLOAD_DELAY': 3, 'LOG_FILE': 'trace', 'NEWSPIDER_MODULE': 'myscraper.spiders', 'RETRY_TIMES': 0, 'ROBOTSTXT_OBEY': True,
'SPIDER_MODULES': ['myscraper.spiders']}
2018-11-16 11:03:44 [scrapy.middleware] INFO: Enabled extensions:
['scrapy.extensions.corestats.CoreStats',
 'scrapy.extensions.telnet.TelnetConsole',
 'scrapy.extensions.memusage.MemoryUsage',
 'scrapy.extensions.logstats.LogStats']
2018-11-16 11:03:44 [twisted] CRITICAL: Unhandled error in Deferred:
2018-11-16 11:03:44 [twisted] CRITICAL:
Traceback (most recent call last):
  File "/usr/bin/anaconda3/lib/python3.6/site-packages/twisted/internet/defer.py", line 1418, in _inlineCallbacks
    result = g.send(result)
  File "/usr/bin/anaconda3/lib/python3.6/site-packages/scrapy/crawler.py", line 80, in crawl
    self.engine = self._create_engine()
  File "/usr/bin/anaconda3/lib/python3.6/site-packages/scrapy/crawler.py", line 105, in _create_engine
    return ExecutionEngine(self, lambda _: self.stop())
  File "/usr/bin/anaconda3/lib/python3.6/site-packages/scrapy/core/engine.py", line 69, in __init__
    self.downloader = downloader_cls(crawler)
  File "/usr/bin/anaconda3/lib/python3.6/site-packages/scrapy/core/downloader/__init__.py", line 88, in __init__
    self.middleware = DownloaderMiddlewareManager.from_crawler(crawler)
  File "/usr/bin/anaconda3/lib/python3.6/site-packages/scrapy/middleware.py", line 58, in from_crawler
    return cls.from_settings(crawler.settings, crawler)
  File "/usr/bin/anaconda3/lib/python3.6/site-packages/scrapy/middleware.py", line 34, in from_settings
    mwcls = load_object(clspath)
  File "/usr/bin/anaconda3/lib/python3.6/site-packages/scrapy/utils/misc.py", line 44, in load_object
    mod = import_module(module)
  File "/usr/bin/anaconda3/lib/python3.6/importlib/__init__.py", line 126, in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
  File "<frozen importlib._bootstrap>", line 994, in _gcd_import
  File "<frozen importlib._bootstrap>", line 971, in _find_and_load
  File "<frozen importlib._bootstrap>", line 941, in _find_and_load_unlocked
  File "<frozen importlib._bootstrap>", line 219, in _call_with_frames_removed
  File "<frozen importlib._bootstrap>", line 994, in _gcd_import
  File "<frozen importlib._bootstrap>", line 971, in _find_and_load
  File "<frozen importlib._bootstrap>", line 941, in _find_and_load_unlocked
  File "<frozen importlib._bootstrap>", line 219, in _call_with_frames_removed
  File "<frozen importlib._bootstrap>", line 994, in _gcd_import
  File "<frozen importlib._bootstrap>", line 971, in _find_and_load
  File "<frozen importlib._bootstrap>", line 953, in _find_and_load_unlocked
ModuleNotFoundError: No module named 'scrapoxy'

Please give me hints and help me solve this issue,
Thanks,
Driss

pip install scrapoxy has the issue solved !

thanks for helping!


'>' not supported between instances of 'NoneType' and 'NoneType'

I'm having an issue when client.py tries to compare target_meta.version and self.current_archive.version (here). I'm pretty lost as I am setting the version as far as I'm aware? I largely used this repo and these examples to try and figure everything out.
Here are the files pertaining to the repository side:
Repo Settings
Repo Init
Repo Add bundle
And here are the files pertaining to the client side:
Client Settings
Client Init
And here are the steps I'm taking:

Initialize the repo.
Build the app (ensuring only one bundle is in the dist dir).
Add the bundle to the repo.
Start the server.
Start the app.

Here's some logs that might help:

Full Error
Trusted root metadata copied to cache.
Traceback (most recent call last):
  File "F:\Projects\Active\nazarick-launcher\src\app.py", line 83, in <module>
    main()
  File "F:\Projects\Active\nazarick-launcher\src\app.py", line 19, in main
    tufupClient()
  File "F:\Projects\Active\nazarick-launcher\src\app.py", line 78, in tufupClient
    if client.check_for_updates():
       ^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "%UserProfile%\AppData\Roaming\Python\Python312\site-packages\tufup\client.py", line 163, in check_for_updates
    all_new_targets = dict(
                      ^^^^^
  File "%UserProfile%\AppData\Roaming\Python\Python312\site-packages\tufup\client.py", line 167, in <genexpr>
    and target_meta.version > self.current_archive.version
        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
TypeError: '>' not supported between instances of 'NoneType' and 'NoneType'

HTTP Server Log
F:\Projects\Active\nazarick-launcher>python -m http.server -d pyinstaller/temp/repository
Serving HTTP on :: port 8000 (http://[::]:8000/) ...
::1 - - [22/Oct/2023 06:51:53] code 404, message File not found
::1 - - [22/Oct/2023 06:51:53] "GET /metadata/2.root.json HTTP/1.1" 404 -
::1 - - [22/Oct/2023 06:51:53] "GET /metadata/timestamp.json HTTP/1.1" 200 -
::1 - - [22/Oct/2023 06:51:53] "GET /metadata/snapshot.json HTTP/1.1" 200 -
::1 - - [22/Oct/2023 06:51:54] "GET /metadata/targets.json HTTP/1.1" 200 -

It appears to be trying to find 2.root.json which doesn't exist? This occurs when I run either the bundled app or dev app. Any help would be greatly appreciated, thanks! :)

@ginsm Thanks for taking an interest in tufup.
Could you please edit your question to include the full error and server log as text, instead of linking to pastebin?

...  it appears to be trying to find 2.root.json which doesn't exist?

python-tuf always tries to download a new version of root.json. That's normal. See TUF client workflow.

@ginsm Could you also post the content of the "targets" section from your targets.json?

@ginsm Something is probably going wrong when parsing the version from your target file path.
Could run your app with logging level set to logging.DEBUG, and then post the command line output?
(please make sure to remove any sensitive information from the log before posting)

@ginsm Thanks for taking an interest in tufup. Could you please edit your question to include the full error and server log as text, instead of linking to pastebin?

...  it appears to be trying to find 2.root.json which doesn't exist?

python-tuf always tries to download a new version of root.json. That's normal. See TUF client workflow.

Done and thanks for the info!

@ginsm This is probably caused by the whitespace in your APP_NAME.
Here's how tufup parses the version from the filename:
r'^(?P<name>[\w-]+)-(?P<version>.+)(?P<suffix>\.tar\.gz|\.patch)$'

Yup, that seems to have resolved the issue. Thanks for the quick response! :grin:


Fix macOS PKG architecture

Add hostArchitectures="x86_64,arm64" to the distribution.xml file.
References:

https://developer.apple.com/library/archive/documentation/DeveloperTools/Reference/DistributionDefinitionRef/Chapters/Distribution_XML_Ref.html#:~:text=list of supported architecture codes

Fixed by a766de5


generic.threshold_count and compare

Setup Information

Xclim version: 0.39
Python version: 3.9.13
Operating System: Ubuntu 18

Context
Hi!
I was using the xclim.indices.wetdays function (resampling from daily data to YS frequency). I noticed that years that are missing (i.e., entire years where pr values are NaN) result in outputs of 0 and not NaN.
Digging deeper into the source code, I noticed that the wetdays function uses the generic threshold_count function, which then calls upon the generic compare function. When compare generates the mask for whether the daily value exceeds the threshold, it doesn't seem to do anything to address NaNs, and only outputs boolean, and thus the resulting outputs are just values of 0.
Is this functioning as intended? Are these functions not suitable for data with missing values?
Code of Conduct

[X] I agree to follow this project's Code of Conduct

I don't think that's intended. If values are missing, the result should be a NaN. Will look into it.

I read and answered to fast. You're using indices.wetdays. indices do not perform missing value checks.  Use xclim.atmos.wetdays to deal with missing values, and let us know how it goes.

Interesting - didn't know there was that distinction between .indices and .atmos.
xclim.atmos.wetdays appears to have dealt with the missing values and I'll test .set_options going forward.


Issues running DPR using tevatron.

I am trying to repro the DPR with NQ benchmark but I am hitting errors as following the readme leads to errors. Any idea whats up?
les.json.json -   Failed to read file '/home/spacemanidol/tevatron/nq/biencoder-nq-train.json' with error <class 'pyarrow.lib.ArrowInvalid'>: JSON parse error: Column() changed from object to array in row 0
for obj in iterable:
File "/home/spacemanidol/.local/lib/python3.8/site-packages/datasets/packaged_modules/json/json.py", line 140, in _generate_tables
f"Not able to read records in the JSON file at {file}. "
AttributeError: 'list' object has no attribute 'keys'

Hi, @spacemanidol
For your reference, this upcoming PR may also help.
https://github.com/texttron/tevatron/blob/7a3a05914cbeb8158b2ab8fe4c5f9990e03ef834/examples/dpr/README.md#alternatives-train-dpr-with-our-self-contained-datasets
The preprocessing can be faster if using our datasets hosted in huggingface hub.