sddm: 0.20.0 -> unstable-2023-12-29, add Qt6 support

Description of changes
A bunch of Wayland fixes and one important tmpfiles.d change.
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[x] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[x] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

@ofborg test sddm

@ofborg build libsForQt5.sddm qt6Packages.sddm


Links to Jmol generating error message

http://beta.patricbrc.org/portal/portal/patric/Jmol?structureID=4X54
Never loaded

Actually, you're seeing production website. You need to use http://www.beta.patricbrc.org/portal/portal/patric/Jmol?structureID=4X54
www.beta.patricbrc.org not beta.patricbrc.org
There was a bug and I fixed it in this release.

I had production totally shut down and was using beta.  See attached screenshshot.  The error is at beta.
----- Original Message -----
From: "Harry Yoo"<EMAIL_ADDRESS>To: "PATRIC3/patric3_website"<EMAIL_ADDRESS>Cc: "Rebecca Wattam"<EMAIL_ADDRESS>Sent: Saturday, March 14, 2015 12:04:51 PM
Subject: Re: [patric3_website] Links to Jmol generating error message (#24)
Actually, you're seeing production website. You need to use http://www.beta.patricbrc.org/portal/portal/patric/Jmol?structureID=4X54
www.beta.patricbrc.org not beta.patricbrc.org
There was a bug and I fixed it in this release.

Reply to this email directly or view it on GitHub:
https://github.com/PATRIC3/patric3_website/issues/24#issuecomment-80553416
Rebecca Wattam, Ph.D.
Assistant Professor
Computational Biology, Bioinformatics and Biostatistics Leader
Cyberinfrastructure Division
Virginia Bioinformatics Institute
Virginia Polytechnic Institute and State University
Blacksburg, Virginia 24060
Tel:<PHONE_NUMBER>

It works for me. Don't forget to register www.beta.patricbrc.org to your applet white list.
Preferences -> Java -> Security tab -> Edit Site List -> add "http://www.beta.patricbrc.org" -> click Ok -> click Ok
You may have to restart your browser to make it effective.
Harry


Rely more on profile objects and less on GUIDs

Right now, we store GUIDs in panes and most of the functions for interacting
with profiles on the settings model take GUIDs and look up profiles.
This pull request changes how we store and look up profiles to prefer profile
objects. Panes store strong references to their originating profiles, which
simplifies settings lookup for CloseOnExit and the bell settings. In fact,
deleting a pane's profile no longer causes it to forget which CloseOnExit
setting applies to it. Duplicating a pane that is hosting a deleted profile
(#5047) now duplicates the profile, even though it is otherwise unreachable.
This makes the world more consistent and allows us to eventually support panes
hosting profiles that do not have GUIDs that can be looked up in the profile
list. This is a gateway to #6776 and #10669, and consolidating the profile
lookup logic will help with #10952.
PR #10588 introduced TerminalSettings::CreateWithProfile and made
...CreateWithProfileByID a thin wrapper over top it, which looked up the profile
by GUID before proceeding. It has also been removed, as its last caller is gone.
Closes #5047

looks like the code in Pane::updateSettings will still take care of that

please help make sure that #10997 keeps that consistency :smile:


Fix _compute_inactivity_leak_deltas

What was wrong?
See https://github.com/ethereum/eth2.0-specs/blob/v0.5.1/specs/core/0_beacon-chain.md#rewards-and-penalties: def compute_inactivity_leak_deltas. It should be base_rewards[index] * config.MIN_ATTESTATION_INCLUSION_DELAY // inclusion_infos[index].inclusion_distance.
How was it fixed?
Fix the wrong operator.
Cute Animal Picture

I've rebuilt and rerun many times but still failed to make the irrelevant tests pass. :'(


RFC: core scope (MVP)

In order to prepare MVP version we need to implement core regex features so that the package is useful for typical use cases.
Core scope

[ ] Features

[x] buildRegex, buildPattern top-level APIs
[x] quantifiers

[x] base: one, oneOrMore, zeroOrMore, optionally
[x] repeat

[x] choiceOf alternative
[ ] character classes

[x] base classes: any (.), digit (\d), word (\w), whitespace (\s)
[x] anyOf class
[ ] range class
[ ] inverted modifier (^)

[x] captures:

[x] capture

[ ] anchors

[ ] base: startOfLine (^), endOfLine ($)
[ ] wordBoundary (\b)

[ ] Documentation

[ ] Getting started guide
[ ] API reference

[ ] CI/CD
[ ] Publish to NPM

Things after MVP

[ ] Lookahead / NegativeLookahead
[ ] More exotic character classes
[ ] More exotic anchors
[ ] Local capture (not sure if relevant)
[ ] Character class operations: union, intersection, etc  (not sure if relevant)
[ ] Advanced captures (not sure if relevant)

[ ]  transform option
[ ] tryCapture with transform
[ ] reference (as)

I'll work on startOfLine (^), endOfLine ($) anchors


Add initial basic load testing

Tickets addressed: closes #1095
Review: By commit
Merge strategy: Merge (no squash)

Description
WIP, don't look 👁 👃 👁
Verification

Documentation

Future work

👀


Integration Test - Release - 2022/04/11 08:52:12

Auto create for integration test. IssueCommandFlow

#pri1

Just type '#pri3'

#pri2

#pri3

#assign PRMergerTest1

#assign NonAllowedUser

The following users don't have valid GitHub IDs, or are not collaborators on this repo: nonalloweduser

#reassign PRMergerTest2

#reassign NonAllowedUser

The following users don't have valid GitHub IDs, or are not collaborators on this repo: nonalloweduser

GitHub user PRMergerTest2 has been removed from the MicrosoftDocs organization, so they were automatically removed as an assignee.

#please-close

#unassign NonAllowedUser


Tracking Domain - SSL not working

Hi - I've got postal running, and I'm testing the tracking, but I found that when enabling SSL on my tracking domain, the tracking doesn't work (tracking works fine when this is turned off).
Browsing to port 80 on my tracking IP opens up the "Hello." page, while browsing to port 443 I get "PR_END_OF_FILE_ERROR". Telnet results in an immediate "Connection closed by foreign host.".
I tried generating my own SSL cert for the fast_server and specified them in the postal.yml config, but it made no difference. fast_server.log reports not issues.
Any help would be appreciated.
Thanks

Ok sorted, thanks to https://github.com/postalhq/postal/issues/857#issuecomment-586310259
I'm running Debian 10.4 with ruby2.5 btw.


Open ledger storage in aleo directory

Old path to ledger storage: .ledger-X
New path to ledger storage: .aleo/testnet2/ledger-X

Note - do not merge this PR in until a clear path to migrating existing ledger data over is achieved. Without this, it will cause existing trial network to start over from genesis on boot up.

Closing as this is now deprecated.


Mobile: fill out work preference

User Story
As a user selecting "work" as a preference,
I want to be prompted with a specific input field to describe the type of work I do,
So that I can provide detailed information about my work.
Acceptance Criteria

[ ] If "work" is selected on the preferences screen, a new input box should be displayed after clicking "Next."
[ ] The input box should prompt the user with the question "What kind of work do you do? (be as descriptive as possible)".
[ ] Ensure that the user can input descriptive information about their work in the provided box.
[ ] Verify that the input field for describing work is displayed only when "work" is selected as a preference.
[ ] Test the functionality across different devices and screen sizes to ensure consistency.

Related Issues

None

Notes

Providing a specific input field for describing work enhances the customization of user preferences.
Collaborate with designers to ensure the input box is visually appealing and intuitive.
Test the functionality thoroughly to ensure it works as expected and provides a seamless user experience.

Tasks

[ ] Design the layout and content for the input field asking about the type of work on the preferences screen.
[ ] Implement the input field functionality in the frontend codebase.
[ ] Ensure that the input field is displayed only when "work" is selected as a preference.
[ ] Test the functionality of the input field to verify that users can provide descriptive information about their work.
[ ] Test the responsiveness and usability of the input field across different devices and screen sizes.
[ ] Document and report any issues or bugs discovered during development and testing.

This is done. Issue #72 will cover the testing portion


Add Cloud Computing Streamline microservice management with Istio

What does this PR do?
Add Resource
For resources
Description
Cloud Computing Streamline microservice management with Istio
Why is this valuable (or not)
same as other red hat books
How do we know it's really free?
same as other red hat books
Checklist:

[x ] Not a duplicate
[x] Included author(s) if appropriate
[x] Lists are in alphabetical order
[x] Needed indications added (PDF, access notes, under construction)

Thanks!


Use readline package in neo-cli for history of commands

Hi,
Thanks for developing the neo-cli. I use it beside neo-privnet and it's good.
However, one thing is bothering me. It was that neo-cli cannot maintain the command history.
I wrote a CLI (command line interface) for another project and in that we use the readline package for command history. I'm interested to know, is there any plan to add this capability to neo-cli package?
Also, I can integrate readline package to neo-cli by myself based on my previous experience although is not a hard task

@mlabbaf, would be great to have it, this function is builtin on windows but not yet in linux shell.

@mlabbaf I've added basic readline integration here https://github.com/belane/neo-cli/commit/04d87803a540a6a1b46c9ad7a4b78a9743acd625 and is working well, can you check it and tell me if we need any improvements more?

Thanks for your development and sorry for my delay.
I check it and history is worked, however I think is somehow slow !!
Also, it's lack the tab completion feature.
I previously used ReadLine package in C based CLI and I attach a sample C program that used ReadLine package.
To compile it, use the following command:
gcc TabCompletion.c -lreadline -lncurses -lpthread
To compile this code, readline and ncurses should be installed. (sudo apt-get install libreadline-dev lib32ncurses5-dev)
Also, the following links can be helpful.
http://web.mit.edu/gnu/doc/html/rlman_2.html
https://eli.thegreenplace.net/2016/basics-of-using-the-readline-library/
attached c code:
TabCompletion.c.tar.gz

I test it with and without ReadLine. Unfortunately, when I use up arrow key twice, it's slow ! I didn't see this in C version !
However, if we assume the performance issue is fixed, is ReadLine package be the correct choice?
We use it in our C based CLI. In that project, the important factors were command history and tab completion.

It should have been solved because I'm trying (debian 9.5 and windows 10) and I don't see any performance problem, I will do more testing to try to reproduce.
I have chosen ReadLine nuget package as neo-cli is on C# as will be easy to maintain, do you think it would be a problem?

It's weird. The same as you told, when I use the tmux, the result is different than when I use terminal !!

I've tracked this behavior to these netcore issues, so we have to find a workarround until they fix it or find another solution.
https://github.com/dotnet/corefx/issues/31517
https://github.com/dotnet/cli/issues/10101

I have a basic question. Can I know the main reason that neo-cli is written in C#?
I have advanced experience in developing in C language that biased me to write CLI in C language. Also, based on my short search, python is a good language for developing CLI.

I guess there is no specific answer to this. I think C# is a fully valid language like any other, also you can find implementations in other languages like neo-python.

Hello guys,
This looks solved to me, I'm closing it, ok? If you guys think it is a mistake, please reopen this issue. Thanks.


route.proto: add is_optional field to ClusterSpecifierPlugin

Signed-off-by: Doug Fawley<EMAIL_ADDRESS>Commit Message: route.proto: add is_optional field to ClusterSpecifierPlugin
Additional Description:
When deploying a new cluster specifier plugin, it is often necessary to add it to the configuration before all clients can be updated to support it, with routing rules configured to prevent clients without support from selecting any routes referencing the plugin.  This field will allow those clients to suppress the default behavior of NACKing any resource containing the unknown plugin.
Risk Level: None
Testing: None
Docs Changes: None
Release Notes: None
Platform Specific Features: None
@markdroth @ejona86

This looks great to me.
@lizan, can you please provide a non-Google API review here?  Thanks!

/lgtm api

@dfawley please fix CI.

@ggreenway apologies; I had not noticed the CI failures.  I fixed the formatting, so it should be good to go now.

/lgtm api (based on Lizan's earlier approval, since it's just a formatting change since then)

/lgtm api

@dfawley do you plan to implement this in this PR? If not it should have not-implemented-hide tag.

@lizan The entire ClusterSpecifierPlugin message is already not implemented in Envoy, so this just adds another field to a message that's already not implemented.  There is a not-implemented tag here.  I don't think we need another one for this individual field.

@lizan Any reason not to merge this?  Thanks!


Support for _ as unused parameter

This issue was originally filed by<EMAIL_ADDRESS>
I've seen a convention of using _ to avoid naming an unused parameter (often closure parameter).
It would be nice if the language/tools supported this:
  * allow multiple parameters named _
  * disallow accessing the value of a variable called _
  * editor shouldn't warn about hiding of _ variables

I think it will be great feature and it can also improve performance(if properly implemented), but looks they are a bit lazy to implement this feature. Also (_, _, _, ...)  looks much better than (_, __, ___, ...).
Maybe it can made as ( , , , ...)(without any name) or with any other symbol so it doesn't effect the language styling or whatever.


Add new Kafka Role to the docs

Fixes: #3118
Signed-off-by: Manali Bhutiyani<EMAIL_ADDRESS>Add new Kafka Role to the docs

test-me-please

test-me-please

test-me-please

test-me-please

test-me-please

test-me-please

@ianvernon @joestringer : Addressed review comments. Need an approval if everything looks ok.

@eloycoto : Still seeing this test flake unrelated to my docs changes
21:46:32 • [SLOW TEST:33.240 seconds]
21:46:32 RuntimeValidatedPolicyEnforcement
21:46:32 /home/jenkins/workspace/Cilium-PR-Ginkgo-Tests-Validated/src/github.com/cilium/cilium/test/ginkgo-ext/scopes.go:170
21:46:32   Policy Enforcement Default
21:46:32   /home/jenkins/workspace/Cilium-PR-Ginkgo-Tests-Validated/src/github.com/cilium/cilium/test/ginkgo-ext/scopes.go:170
21:46:32     Default to Never with policy
21:46:32     /home/jenkins/workspace/Cilium-PR-Ginkgo-Tests-Validated/src/github.com/cilium/cilium/test/ginkgo-ext/scopes.go:202
21:46:32 ------------------------------
21:46:32 RuntimeValidatedPolicyEnforcement Policy Enforcement Always
21:46:32   Container creation```

test-me-please

And this one:
jsonpath='{.items[*].metadata.deletionTimestamp}'"
21:46:33
21:46:33 • Failure [200.479 seconds]
21:46:33 K8sValidatedPolicyTestAcrossNamespaces
21:46:33 /home/jenkins/workspace/Cilium-PR-Ginkgo-Tests-Validated/src/github.com/cilium/cilium/test/k8sT/Policies.go:675
21:46:33   Policies Across Namespaces [It]
21:46:33   /home/jenkins/workspace/Cilium-PR-Ginkgo-Tests-Validated/src/github.com/cilium/cilium/test/k8sT/Policies.go:712
21:46:33
21:46:33   Unable to connect between frontend-d9q97 and <IP_ADDRESS>:80/
21:46:33   Expected
21:46:33       <string>: 000command terminated with exit code 7
21:46:33
21:46:33   to equal
21:46:33       <string>: 200
21:46:33
21:46:33   /home/jenkins/workspace/Cilium-PR-Ginkgo-Tests-Validated/src/github.com/cilium/cilium/test/k8sT/Policies.go:855
21:46:33 ------------------------------
21:46:33 SSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSS```

test-me-please

I am seeing a lot of unrelated CI errors. Not sure what's the best route here? Trying CI again.

test-me-please

I am seeing a lot of unrelated CI errors. Not sure what's the best route here? Trying CI again.

All PRs are seeing these right now. Nee to investigate tomorrow.

test-me-please


Can't find dism features in node attributes anymore.

Cookbook version
4.0.1
Chef-client version
13.8.5
Platform Details
Windows 2012r2 and Windows2016
Scenario:
I'm not seeing the windows features that are installed in the node attributes on chef-server or chef-automate like before when they were cached in ohai
Steps to Reproduce:
create server with windows cookbook in run list
Expected Result:
windows features showing up in node attributes on chef-server and chef-automate
Actual Result:
no errors just don't see feautes in node attributes.

@Stromweld 4.0 entirely changed up how the caching works. Previously it was done with an ohai plugin that had the side effect of giving users access to the feature data. I looked at porting this ohai plugin into Ohai itself, but since microsoft uses different names for features on dism and powershell it didn't seem to make sense to bring that into core Chef. If you want to continue to have that data available on nodes you can just add that plugin to a cookbook and ship it out to your nodes.


TestServer_ContinuousQuery is racy

Continuing to hit this on Circle, even with latest changes.
https://circle-artifacts.com/gh/influxdb/influxdb/5561/artifacts/1/tmp/circle-artifacts.CmdRW2c/test_logs_i386.txt

Test skipped in https://github.com/influxdb/influxdb/commit/267f8e6c119739a020a4ae8b1d73bfd31e4713ac

Setting 0.9.4 so we at least decide whether this is a blocker for 0.9.4.

https://circle-artifacts.com/gh/influxdb/influxdb/5561/artifacts/1/tmp/circle-artifacts.CmdRW2c/test_logs_i386.txt


Add button to tolbar

Add edit usages button to the find usages panel

Done https://github.com/funivan/PhpStorm-Refactoring-Plugin/commit/2a183f6cf1f08dab23bc244ce7fad3d6f142a4d7


Improve get_current_stream performance

jenkins, test this please.

Jenkins CI test (for commit 06afb812804304e854bd01b2c6b5842bee1e7d39, target branch master) succeeded!

Jenkins, test this please

Jenkins CI test (for commit 06afb812804304e854bd01b2c6b5842bee1e7d39, target branch master) succeeded!

LGTM


What's the possible min and max length of ens names

For a .eth name, given the current contracts on the Ethereum main network: What is the minimal possible amount of characters permitted and what is the maximum number? Also: Will these two values remain constant over time? On-chain, are they mutable? In the code: where are they checked for?

I believe the only limit is that the name must be greater than or equal to 3 characters: https://github.com/ensdomains/ethregistrar/blob/master/contracts/ETHRegistrarController.sol#L58
Someone recently registered an .eth name with 10,000 characters: https://twitter.com/fuqeth/status/1456800064295391233

ok thanks @ca98am79. Maybe another related question: Do you know where I could quickly get ahold of a list of of all ens names; or rather: Where I could find out which character lengths are most commonly used as ens names?

@TimDaub I don't think there's a convenient dashboard that allows you to filter the names the way you want, but you can use https://etherscan.io/enslookup to find all of the registered names. With a simple js/python script you can fetch this data and parse it to get the answers you're looking for :)


Update the "Customize-non-PHP_INI_SYSTEM directives" section as .htaccess file is not applicable for our current supported PHP version v8.+

Please update the "Customize-non-PHP_INI_SYSTEM directives" section:
https://learn.microsoft.com/en-us/azure/app-service/configure-language-php?pivots=platform-linux#Customize-non-PHP_INI_SYSTEM directives
Previous content:
_To customize PHP_INI_USER, PHP_INI_PERDIR, and PHP_INI_ALL directives (see php.ini directives), add an .htaccess file to the root directory of your app.
In the .htaccess file, add the directives using the php_value   syntax. For example:
Copy
php_value upload_max_filesize 1000M
php_value post_max_size 2000M
php_value memory_limit 3000M
php_value max_execution_time 180
php_value max_input_time 180
php_value display_errors On
php_value upload_max_filesize 10M
Redeploy your app with the changes and restart it. If you deploy it with Kudu (for example, using Git), it's automatically restarted after deployment.
As an alternative to using .htaccess, you can use ini_set() in your app to customize these non-PHP_INI_SYSTEM directives._
However .htaccess configuration file for Apache is no longer working for current supported PHP version v8.+ (using Nginx server) in Azure app service.
Please update the documentation with Nginx configuration instruction and examples.

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: a3209bb1-99cd-9e32-ae48-2605831aee02
Version Independent ID: 743bc03e-d0d1-1e9e-acb1-52ae01daa0cc
Content: Configure PHP apps - Azure App Service
Content Source: articles/app-service/configure-language-php.md
Service: app-service
GitHub Login: @cephalin
Microsoft Alias: cephalin

@TinaHanTH
Thanks for your feedback! We will investigate and update as appropriate.

Doc has been updated. Tweaked in https://github.com/MicrosoftDocs/azure-docs-pr/pull/248421 to completely remove .htaccess mentioning in the doc. #please-close


Segmentation error for tracing

Following code will cause segmentation error when run with tpl --trace:
:- initialization(main).

foo(_).

main :- foo([1|2]), halt.

Backtrace:
Core was generated by `tpl --trace foo.pro'.
Program terminated with signal SIGSEGV, Segmentation fault.
#0  __strcmp_sse2_unaligned () at ../sysdeps/x86_64/multiarch/strcmp-sse2-unaligned.S:31
31      ../sysdeps/x86_64/multiarch/strcmp-sse2-unaligned.S: No such file or directory.
(gdb) bt
#0  __strcmp_sse2_unaligned () at ../sysdeps/x86_64/multiarch/strcmp-sse2-unaligned.S:31
#1  0x00000000004438bc in sprint2_list (depth=4, dstbuf=0x7ffd4b9111f8, bufsize=0x7ffd4b9111f0, _dst=0x7ffd4b90dec0,
    pl=0x2b4a010, q=0x2b59030, n=0x2b5c690, listing=1) at src/print.c:175
#2  0x0000000000445449 in sprint2_term (depth=3, dstbuf=0x7ffd4b9111f8, bufsize=0x7ffd4b9111f0, _dst=0x7ffd4b90efc8,
    pl=0x2b4a010, q=0x2b59030, _n=0x2b5c690, listing=1) at src/print.c:383
#3  0x0000000000444dd4 in sprint2_compound (depth=2, dstbuf=0x7ffd4b9111f8, bufsize=0x7ffd4b9111f0, _dst=0x7ffd4b9100d0,
    pl=0x2b4a010, q=0x2b59030, n=0x2b5c690, listing=1) at src/print.c:323
#4  0x00000000004454ba in sprint2_term (depth=1, dstbuf=0x7ffd4b9111f8, bufsize=0x7ffd4b9111f0, _dst=0x7ffd4b911200,
    pl=0x2b4a010, q=0x2b59030, _n=0x2b5c640, listing=1) at src/print.c:385
#5  0x000000000044693f in term_sprint2 (dstbuf=0x7ffd4b9111f8, bufsize=0x7ffd4b9111f0, dst=0x7ffd4b911200, pl=0x2b4a010,
    q=0x2b59030, n=0x2b5c640, listing=1) at src/print.c:541
#6  0x0000000000408a22 in trace (q=0x2b59030, fail=0, leave=0) at src/trealla.c:891
#7  0x0000000000441591 in call (q=0x2b59030) at src/jela.c:417
#8  0x00000000004417a0 in run_me (q=0x2b59030) at src/jela.c:472
#9  0x0000000000408b53 in query_run (self=0x2b59030) at src/trealla.c:914
#10 0x000000000040a395 in trealla_run_query (self=0x2b4a010, src=0x2b58560 "main.") at src/trealla.c:1403
#11 0x0000000000409f31 in trealla_consult_file (self=0x2b4a010, filename=0x7ffd4b912809 "foo.pro") at src/trealla.c:1306
#12 0x00000000004052aa in main (ac=3, av=0x7ffd4b912168) at tpl.c:363
(gdb)

Fix confirmed, thanks.


[Impeller] slow performance of DRRect on certain Android devices.

Steps to reproduce
Adding a border seems to have a performance issue on my device Xiaomi 11 Lite, removing it makes things return to normal. I also tested this on the master branch, the issue is still there.
Expected results
No janks
Actual results
Heavy janks
Code sample
Code sample
import 'package:flutter/material.dart';

void main() {
  runApp(const MainApp());
}

class MainApp extends StatelessWidget {
  const MainApp({super.key});

  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      home: Scaffold(
        body: SafeArea(
          child: SingleChildScrollView(
            child: Wrap(
              children: [
                for (int i = 0; i < 200; i++)
                  Padding(
                    padding: const EdgeInsets.all(8),
                    child: Material(
                      shape: RoundedRectangleBorder(
                        borderRadius: BorderRadius.circular(8),
                        // This seems to cause performance issues
                        side: BorderSide(
                          color: Colors.red,
                        ),
                      ),
                      child: Text(
                        'Item $i',
                      ),
                    ),
                  ),
              ],
            ),
          ),
        ),
      ),
    );
  }
}

Screenshots or Video

Screenshots / Video demonstration
With border
https://github.com/user-attachments/assets/6eb328d1-dc5c-431f-903d-9612f64bd70e
No border
https://github.com/user-attachments/assets/b581101b-b242-4265-b4d8-ba3215255220

Logs
Logs
[Paste your logs here]

Flutter Doctor output
Doctor output
[✓] Flutter (Channel stable, 3.27.1, on macOS 15.1 24B2083 darwin-arm64, locale en-VN)
    • Flutter version 3.27.1 on channel stable at /Users/khoa/fvm/versions/stable
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 17025dd882 (3 days ago), 2024-12-17 03:23:09 +0900
    • Engine revision cb4b5fff73
    • Dart version 3.6.0
    • DevTools version 2.40.2

[✓] Android toolchain - develop for Android devices (Android SDK version 35.0.0)
    • Android SDK at /Users/khoa/Library/Android/sdk
    • Platform android-35, build-tools 35.0.0
    • Java binary at: /Users/khoa/Applications/Android Studio.app/Contents/jbr/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 21.0.3+-79915917-b509.11)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 16.2)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Build 16C5032a
    • CocoaPods version 1.16.2

[✗] Chrome - develop for the web (Cannot find Chrome executable at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome)
    ! Cannot find Chrome. Try setting CHROME_EXECUTABLE to a Chrome executable.

[✓] Android Studio (version 2024.2)
    • Android Studio at /Users/khoa/Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 21.0.3+-79915917-b509.11)

[✓] VS Code (version 1.96.1)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.102.0

[✓] Connected device (5 available)
    • 2109119DG (mobile)              • <IP_ADDRESS>:42171                  • android-arm64 • Android 14 (API 34)
    • sdk gphone64 arm64 (mobile)     • emulator-5554                        • android-arm64 • Android 15 (API 35) (emulator)
    • iPhone 16 Pro Max (mobile)      • 33B397ED-CCA5-4780-BD6C-E3EF3C8CCE0A • ios           • com.apple.CoreSimulator.SimRuntime.iOS-18-2 (simulator)
    • macOS (desktop)                 • macos                                • darwin-arm64  • macOS 15.1 24B2083 darwin-arm64
    • Mac Designed for iPad (desktop) • mac-designed-for-ipad                • darwin        • macOS 15.1 24B2083 darwin-arm64

[✓] Network resources
    • All expected network resources are available.

! Doctor found issues in 1 category.

I can reproduce this on a Pixel 4. There are three problems here:

We're drawing a multi contour curve with even/odd fill mode. This appears to be very slow (on the GPU) for this case, so most of the overhead is GPU backpressure.
We unecessarily compute the bounds of the drrect despite already having them.
We pay a path conversion cost on each frame.

Fixing 2/3 isn't sufficient to make this fast on its own, since we'd still be blocked by the GPU backpressure. I think at a minimum we'd need to create a specialized drrect geometry that handles the tessellation directly.

I've narrowed this down. Its not related to StC, instead its related to the usage of PrimitiveRestart. This seems to be supppper slow on these older Adrenos.

I can reproduce this on a Pixel 4 (Adreno 640). I'm not sure how high it goes. Since this is a marginal feature we may just need to disable for all Adrenos


How to debug and handle ScalarError?

When I use the hoi4save parser to parse my HOI4 save file, Jomini returns an "AllDigits Error". This error is likely caused by the fact that the value in the "manpower_pool" field can be a string of numbers with dots, which makes it difficult for the parser to recognize it as valid input.
manpower_pool={
	available=95915
	locked=33<IP_ADDRESS>
	total=37<IP_ADDRESS>
}

What are you deserializing locked and total as? The parser can handle numbers and dots just fine 😄
#[test]
fn test_deserialize_manpower_pool() {
    #[derive(Deserialize, Debug, PartialEq)]
    struct Root {
        manpower_pool: ManpowerPool,
    }

    #[derive(Deserialize, Debug, PartialEq)]
    struct ManpowerPool {
        available: i32,
        locked: String,
        total: String,
    }

    let data = br#"
    manpower_pool={
        available=95915
        locked=33<IP_ADDRESS>
        total=37<IP_ADDRESS>
    }
"#;

    let txt_out: Root = jomini::text::de::from_windows1252_slice(&data[..]).unwrap();
    assert_eq!(
        txt_out.manpower_pool,
        ManpowerPool {
            available: 95915,
            locked: String::from("33<IP_ADDRESS>"),
            total: String::from("37<IP_ADDRESS>"),
        }
    );
}

I'm not sure what exactly you're looking for, but most everything is possible if you want to write your own deserializer function. Below shows prototype of how you can get rid of the (potentially omitted) dots and interpret the fields as numbers.
fn deserialize_pool_field<'de, D>(deserializer: D) -> Result<i32, D::Error>
where
    D: Deserializer<'de>,
{
    struct PoolVisitor;

    impl<'de> de::Visitor<'de> for PoolVisitor {
        type Value = i32;

        fn expecting(&self, formatter: &mut fmt::Formatter) -> fmt::Result {
            formatter.write_str("a pool field")
        }

        fn visit_str<E>(self, v: &str) -> Result<Self::Value, E>
        where
            E: de::Error,
        {
            let first = v.split('.').next().unwrap();
            Ok(first.parse::<i32>().unwrap())
        }
    }

    deserializer.deserialize_str(PoolVisitor)
}

#[test]
fn test_deserialize_manpower_pool() {
    #[derive(Deserialize, Debug, PartialEq)]
    struct Root {
        manpower_pool: ManpowerPool,
    }

    #[derive(Deserialize, Debug, PartialEq)]
    struct ManpowerPool {
        available: i32,
        #[serde(deserialize_with = "deserialize_pool_field")]
        locked: i32,
        #[serde(deserialize_with = "deserialize_pool_field")]
        total: i32,
    }

    let data = br#"
    manpower_pool={
        available=95915
        locked=33<IP_ADDRESS>
        total=3782
    }
"#;

    let txt_out: Root = jomini::text::de::from_windows1252_slice(&data[..]).unwrap();
    assert_eq!(
        txt_out.manpower_pool,
        ManpowerPool {
            available: 95915,
            locked: 3379,
            total: 3782,
        }
    );
}

manpower_pool={
	available=95915
	locked=73401974
	total=76930819
}

Oh, I think there may be a bug in Melt. It would be helpful to set the binary with the debug_saves=1 setting to see if this is true.

Here is my saves https://drive.google.com/file/d/1RAOwDeYgVQgg1XOQa_tN49t5p4dRfoy7/view?usp=sharing
the path is states -> 605 ->manpower_pool

Thanks for the saves. It probably is a problem with the melter, as the binary format isn't self descriptive, so we have to rely on heuristics. We've worked around this issue in other games by informing the melter of fields that we either know are dates or know are numbers. I'm assuming we'll be able to do the same fix here 😄

Thank you for your response. This save was melted by pdxtools. I tried to melt it with hoi4save, but I received an error message Error: Hoi4Error(UnknownToken { token_id: 10805 }). Is there an updated version of hoi4save available?

Thank you for your response. This save was melted by pdxtools. I tried to melt it with hoi4save, but I received an error message Error: Hoi4Error(UnknownToken { token_id: 10805 }). Is there an updated version of hoi4save available?

I updated pdx tools, did you want to try it again and let me know if it works?
And yeah when hoi4save is run locally, you need to supply the mapping from binary tokens to text as paradox doesn't allow me to distribute them with the code.

Yes, it works. I have created my own token table for melting HOI4 saves. However, when I compared those save files, I encountered a new issue with pdxtools. Some tokens were missing or incorrect, such as 'rk_token_XXX'.

This is my own token table https://drive.google.com/file/d/1NvMnrI3NAOMSunsdxFyExdPgXTK2ifvD/view?usp=share_link

When I use PDX tools to melt my save file, I notice some incorrect tokens such as rk_token_XXX and aurelien_delay_XXX. For example, the aurelien_delay_14487 token should be can_be_fired, and rk_token_112 should be all_playthrough_data.


Making the SimpleSDMLayers vignette match the ms

I think instead of doing the integrated test as suggested by reviewers we can simply transpose what was originally the SimpleSDMLayers e.g. with the one from the ms?
Type of change

[ ] :bug: Bug fix (non-breaking change which fixes an issue)
[x] :sparkle: New feature (non-breaking change which adds functionality)
[ ] :boom: Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] :book: This change requires a documentation update

Checklist

[ ] The changes are documented

[ ] The docstrings of the different functions describe the arguments, purpose, and behavior
[ ] There are examples in the documentation website

[ ] The changes are tested
[ ] The changes do not modify the behavior of the previously existing functions

If they do, please explain why and how in the introduction paragraph

[ ] For new contributors - my name and information are added to .zenodo.json
[ ] The Project.toml field version has been updated

Change the last number for a v0.0.x series release, a bug fix, or a performance improvement
Change the middle number for additional features that do not break the current test suite (unless you fix a bug in the test suite)
Change the first number for changes that break the current test suite

Codecov Report
Base: 96.80% // Head: 96.80% // No change to project coverage :thumbsup:

Coverage data is based on head (9390b0c) compared to base (b78f877).
 Consider uploading reports for the commit af87c88 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #53   +/-   ##
=======================================
  Coverage   96.80%   96.80%
=======================================
  Files           7        7
  Lines         125      125
=======================================
  Hits          121      121
  Misses          4        4

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


fix: Broken TextFieldArray layout

Looks like sonarcloud isn't happy: https://sonarcloud.io/project/issues?id=inrupt_client-identifier-helper&branch=fix%2Fgenerator-ui%2Farray-field-layout&resolved=false&types=CODE_SMELL

Looks like sonarcloud isn't happy: https://sonarcloud.io/project/issues?id=inrupt_client-identifier-helper&branch=fix%2Fgenerator-ui%2Farray-field-layout&resolved=false&types=CODE_SMELL

Will take a look in a separate PR.


remove indexes overruled by primary key

There can be unique indexes automatically created for join column.
If join column is also primary key we should keep only primary key on this column.
Oracle does not allow having both unique index and primary key on the same column, it is useless for mysql too.
(Previously it was done by DBAL, but now it allows duplicate indexes)

Seems about right, but we need tests for this.

Rebased and updated as part of #1558
Closing this one. Thanks a lot for the patch! =)


Bump version: 3.3.0 → 3.3.1

Bump version to allow deployment to MetaCI.

Can I do that with bump2version or I have to do it "by hand"?

@prescod I always do version updates by hand, so I'm not sure if there's a better way.


Added Consistency Level as required for some calls

ConsistencyLevel | eventual. This header and $count are required when using $search, or when using $filter with the $orderby query parameter. It uses an index that may not be up-to-date with recent changes to the object.
Added this to Authorization Middleware as I found appropriate

This added the ConsistencyLevel header for all calls which is incorrect. This should not be added via the authorization middleware. It should be added on a per call basis.
https://github.com/microsoftgraph/msgraph-sdk-python-core/issues/61

This added the ConsistencyLevel header for all calls which is incorrect. This should not be added via the authorization middleware. It should be added on a per call basis.
https://github.com/microsoftgraph/msgraph-sdk-python-core/issues/61

Thanks @MIchaelMainer reverting.

Thanks @MIchaelMainer reverting.


fix: uneven sizings of cards on chapters page 🛠

Close #1470
Checklist:

[x] I have linked the PR to the correct issue.
[x] I have read the Contribution Guidelines
[x] I have built and tested the changes, and they do not break or show any errors.

Please merge this PR @Vaishnavi-Patil2211

Please merge this PR @Vaishnavi-Patil2211


ipinfo: 2.0.2 -> 2.1.1

Motivation for this change
Update to latest upstream release 2.1.1
Change log: https://github.com/ipinfo/cli/releases/tag/ipinfo-2.1.1
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
21.11 Release Notes (or backporting 21.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 134823 run on x86_64-linux 1

1 package built:

ipinfo


ML camera livestream

This adds a fast camera stream renderer + compositor + streamer for Magic Leap One. This allows opening the full camera view as a regular web page from the device.
This functionality already existed as a hack via the screenshot API, but this is a fully realtime implementation using the camera preview stream.
Included is a frontend example that consumes the jpeg image stream to render it.

Is this just video and no audio?

Correct, this PR at least has nothing to do with audio.


instantaneous hybrid Azure AD join for a federated environment

Is there a reference link for this behavior / feature? We want to ensure the behavior we see if correct:
" instantaneous hybrid Azure AD join for a federated environment"
Does this mean if we are federated, we should see devices hybrid join without device objects explicitly synchronized?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: b9c51404-0a1b-c22e-e220-ce4126ff88d0
Version Independent ID: bd3aab43-4202-bb69-bd1a-580e0464f357
Content: Configure hybrid Azure Active Directory join for federated domains
Content Source: articles/active-directory/devices/hybrid-azuread-join-federated-domains.md
Service: active-directory
Sub-service: devices
GitHub Login: @MicrosoftGuyJFlo
Microsoft Alias: joflore

@Niglb
Thanks for your feedback! We will investigate and update as appropriate.

Hi @Niglb,
Some good additional references for this are here:
https://docs.microsoft.com/en-us/azure/active-directory/devices/hybrid-azuread-join-plan
https://docs.microsoft.com/en-us/azure/active-directory/devices/concept-azure-ad-join-hybrid
If you have met the prerequisites and set up the SCP, the device can communicate with ADFS right away and AAD Connect will not need to synchronize the object from AD to AAD immediately. When the AAD connect wizard is run all of the devices on the domain will start to register themselves in AAD via the ADFS server.
ADFS will create the device object representing the Active Directory device in AAD.
https://docs.microsoft.com/en-us/windows-server/identity/ad-fs/operations/configure-device-based-conditional-access-on-premises
https://docs.microsoft.com/en-us/azure/active-directory/hybrid/plan-migrate-adfs-password-hash-sync
Hope this helps! I am closing this out but feel free to tag me or re-open this if you think more information is needed. You are also welcome to send me an email (in my profile).