Time shift difference

I added a new control to allow comparing comparing the main time series with time shifts. In addition to showing the time shift as individual lines, it's now possible to compute absolute and relative differences.
Current behavior, will be the default option in the selector ("individual lines"):

Absolute difference:

Relative difference, computed as (main - time_shift) / time_shift (for a "1 week" shift" this means that 100 means the value today is double the value last week, and -50 means that the value today is half of what it was last week):

Codecov Report

Merging #5177 into master will decrease coverage by 0.05%.
The diff coverage is 33.33%.

@@            Coverage Diff             @@
##           master    #5177      +/-   ##
==========================================
- Coverage   77.46%   77.41%   -0.06%
==========================================
  Files          44       44
  Lines        8729     8736       +7
==========================================
+ Hits         6762     6763       +1
- Misses       1967     1973       +6

Impacted Files
Coverage Δ

superset/viz.py
80.98% <33.33%> (-0.31%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a3477ab...a4c0dd4. Read the comment docs.

I think this is effectively the same as a superior Period Ratio isn't it? If so we should db migrate to translate the slices.

I'm not familiar with the period ratio, and it doesn't seem to map 1:1 to the comparison types. Should I create a migration script only for those cases that can be mapped?

I know one difference in the backend is that Period Ratio runs 2 queries and merges them. So I could look at the past 28 days and compare with last year's same period. I'm not sure if Time Shift can do that or it would query/show more than 28 days (which may be ok). What do you think?

How I would that with the period ratio? For time shift you would select the last 28 days and then use "1 year" as the time shift.

Some updates to the AA section to improve usability

LGTM apart from the db migration needed comment.

@mistercrunch, I've added a migration script. Here's a dashboard that was saved before the migration:

Note that:

granularity is month;
num_period_compare is 24 (months);
period_ratio_type is "growth" (ie, new/old - 1).

After the migration:

Now:

time_compare is "2 years" (though it doesn't show in the dropdown since it's free form);
comparison_type is "percentage" (same as "growth", just renamed).

LGTM

@betodealmeida this broke my local build, the db migration fails


Minor: Add description about 'timezone' option to README

Coverage remained the same at 96.07% when pulling ddba692d38ab6c01a7a22f006767e4cbe90eb856 on sakama:add-timezone-description into 011ede2432b158a9f811ae78661072b60cb3b813 on civitaspo:master.

Thank you!

Thank you 👍


run_and_get_stdout doesn't take into account quotes when receives a string as cmd

Hi,
The following test should pass:
    def test_run_and_get_stdout_2(self):
        r = ck.run_and_get_stdout({'cmd': 'sh -c "echo abcd && >&2 echo err && exit 2"'})
        self.assertEqual(0, r['return'])
        self.assertEqual(2, r['return_code'])
        self.assertEqual('abcd\n', r['stdout'])
        self.assertEqual('err\n', r['stderr'])

For now, it fails, because run_and_get_stdout doesn't take into account quotes when it splits string into parameters.

Hi Dmitry, do you think you can fix it today (soon)? I would like to release a new CK version today (with all the new updates)! However, if it's not straightforward, we can leave it for the next release ... Thanks!

Initially I thought it would be hard, so created a task for the future. However, after some investigation I realized the fix is really simple. Prepared PR #60, please take a look (also added the test).


Update to main project administration files

This PR cleans up some of the project administration files:

add a PR template
add a CONTRIBUTING.md file
update the README.md
rename appveyor.yml -> .appveyor.yml

Coverage decreased (-0.04%) to 63.972% when pulling e8ad71d8cb6d4517d87071f80918940171667c94 on admin-update into 968d0da176bac3576f5b26847231e6b58ff75020 on master.

Coverage decreased (-0.04%) to 63.972% when pulling e8ad71d8cb6d4517d87071f80918940171667c94 on admin-update into 968d0da176bac3576f5b26847231e6b58ff75020 on master.


Merge older release patch to main

Describe the Improvement:
Patch to non-current release branch should also be patched to main and most recent release-*
Use last gig tag (major/minor version) to determine most recent release-* branch
Should probably only create PRs to be manually merged (in case of conflicts)
Benefits:
Ensures main and most recent release have all patches
Drawbacks:
n/a
How to Compare:
Network graph should show line from older patch branch to most recent release branch (e.g. patch-1.5.8 to release-1.7

example PR: https://github.com/devlinjunker/template.github.semver/pull/142


use-location-state hook & tests

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@6c5ba17). Click here to learn what that means.
The diff coverage is 83.87%.

@@            Coverage Diff            @@
##             master      #14   +/-   ##
=========================================
  Coverage          ?   44.09%
=========================================
  Files             ?        9
  Lines             ?      127
  Branches          ?       22
=========================================
  Hits              ?       56
  Misses            ?       71
  Partials          ?        0

Impacted Files
Coverage Δ

.../examples/use-location-state/01-simple/src/App.tsx
100% <ø> (ø)

...e/src/hooks/useLocationHashQueryStringInterface.ts
100% <100%> (ø)

...se-location-state/01-simple/src/QueryStateTest.tsx
26.66% <50%> (ø)

...kages/use-location-state/src/use-location-state.ts
71.42% <80%> (ø)

.../packages/query-state-core/src/query-state-core.ts
95.23% <83.33%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6c5ba17...de63989. Read the comment docs.


Semver-major changes

I can break this into smaller PR's if that makes it easier to review.  This enables 100% coverage, adds osx to the travis config (lutimes polyfills can only be tested on osx).  Note the first 3 commits in this PR are already submitted to #169.
One thing I'm not thrilled about is how fs.promises.open is implemented.  The first call to fs.promises.open may be slightly delayed while the system finishes patching that function.  Specifically we need the native C++ FileHandle and the JavaScript class FileHandle from lib/internal/fs/promises.js.  The native C++ FileHandle is acquired through the process.binding('fs').FileHandle which is deprecated.  The only way to get class FileHandle is by calling the original await fs.promises.open and finding the constructor of the result.  Access to the native C++ FileHandle is required to support automagic closing of unclosed fd's on garbage collection.  Access to the JS class FileHandle is required to allow us to extend the base class, otherwise we would have to reimplement all functions and this would potentially have other negative effects.
Fixes #152
Fixes #160
Fixes #167
Fixes #170

Breaking Changes

Require node.js 8
Drop legacy polyfilling
Properly handle DEP0013 based on node.js runtime version (warn in node.js 8/9, throw in 10+)

Features

Patch fs.promises where available (node.js 10+).  Note first access to require('graceful-fs').promises accesses fs.promises so in node.js 10 it will trigger the experimental feature warning.

Fixes

Honor autoClose: false in WriteStream.open
Prevent accidental monkey-patching of fs.ReadStream / fs.WriteStream
Prevent multiple patching of process.cwd, process.chdir
Emit ready event upon stream open

Refractors

Modernize code
Unify ENFILE/EMFILE patches
Unify chmod/chown patches
Unify stream patches
Drop TEST_GRACEFUL_FS_GLOBAL_PATCH, test with gfs.gracefulify
Eliminate GRACEFUL_FS_PLATFORM, move Windows polyfills to separate files to allow direct testing
Move lutimes patches to separate file to allow ignoring coverage when unsupported
Use fs.mkdtempSync in tests (this will allow parallel testing once https://github.com/tapjs/node-tap/issues/586 is resolved)

So far the only reaction to nodejs/node#29109 has been negative.  I'm not sure it's a great idea to publish the promises feature without a path out of hack-land.  I'm inclined to say lets hold this for a bit to see what happens over in node.js.

Additionally I'd like to see where things go with some active PR's against node.js fs streams.  In particular I think<EMAIL_ADDRESS>should conditionally use whatever options are eventually provided by nodejs/node#29083, the less we override the better.

Any news on this one?

@brodybits on hold for nodejs/node#29083.  I think the last CI blocker was just fixed in the PR so hopefully that can be merged soon.  Once it's merged and (hopefully) backported to 13.x I'll be updating here to use that feature when possible and will refresh latest versions of all dependencies.

FYI https://github.com/nodejs/node/pull/29083 is now merged

Patch fs.promises where available (node.js 10+).

I would favor dropping Node.js 8 support since it is near EOL.

@ronag thanks for the update.  I'll update this once fs stream overrides are in a release (I will need a check against process.versions.node to detect that feature).
@brodybits node.js support will be up to @isaacs.  Worth noting the detection of fs.promises is relatively simple, dropping node.js 8 would not result in significantly decreased complexity, so really it's only a question of possibly holding back development dependencies (this is not a concern for end users).

Thanks @coreyfarrell. My idea was that dropping Node.js 8 would reduce burden of future updates for the next 1-2 years or so. Just an idea:)

Why does it take so long to merge this?


Fix io_deps bug in rewrite_blockwise

Addresses xarray#4703 (which is alse described in #6931 )
The current rewrite_blockwise code is updating a list of IO-dependencies (io_deps) within a loop that can be escaped before all dependencies are collected.  This is causing CI errors in xarray.  This PR moves the io_deps update to a simple/dedicated loop over all input layers.
TODO:

[ ] come up with a test

cc @dcherian -  I'm hoping this is the only fix needed for the xarray CI failures.  Please do let me know if you already have a simple dask.array test handy :)

I confirmed that xarray's CI passes on this branch locally.
I could not create a pure dask.array test, or even a pure xarray test!

I could not create a pure dask.array test, or even a pure xarray test!

I also tried to create a test, and found it really challenging! The xarray test has some very subtle things going on with null checks in a string array that I wasn't able to untangle.

Yes it's breaking on
bool(
    (
        (arr1 == arr2) | (dask.array.isnull(arr1) & dask.array.isnull(arr2))
    ).any()
)

arr1 and arr2 are dask arrays created using from_array with either str or int64 dtypes, and sometimes there is a slice involved. In one case arr1 had unknown shape and chunksize.

Closing in favor of #7042


{Freeway-Bug}[Adaptive Cards> Agenda.json]: Luminosity ratio of 'Car' and 'Location' icon is 2.646:1 which is less than 3:1.

Target Platforms
Other
SDK Version
3.2.2303.22003
Application Name
Adaptive Cards
Problem Description
Test Environment:
OS version: 22H2 (Build 25324.1011)
Application: AdaptiveCardVisualizer
Application Version: 3.2.2303.22003
Tool: Color Contrast Analyzer through Accessibility Insights for Windows
Repro Steps:

Open the Adaptive Card Visualizer application.
Navigate to the 'Agenda.json' through tab key and activate it.
Pick the color for foreground and background of 'Car' and 'Location' icon.
Observe the issue.

Actual Result:
Luminosity ratio of 'Car' and 'Location' icon is 2.646:1 which is less than 3:1.
Expected Result:
Luminosity ratio of 'Car' and 'Location' icon should be greater than or equals to 3:1.
User Impact:
Person with visual disability will get impacted as user will not be able to see the icon properly and will not be able to undersatnd the purpose which is represented through icon.
Reference link:
https://microsoft.sharepoint.com/:w:/r/sites/accessibility/_layouts/15/Doc.aspx?sourcedoc={B19D1152-56E4-44F4-832A-A650AC312C4E}&file=MAS 1.4.11 – Non-text Contrast.docx&action=default&mobileredirect=true&share=IQFSEZ2x5Fb0RIMqplCsMSxOAdw8bEbepI0ybgODJQURMgM&cid=dde16c11-21dc-42b4-977d-fb72afda0045
“Have feedback to share on Bugs? Please help fill Trusted Tester Bug Feedback (office.com) “
Screenshots

Card JSON
NA

Sample Code Language
No response
Sample Code
No response

Issue is repro'ing in the latest test environment will reactivate on 1 sep.
Test environment:
OS: windows11
Application: AdaptiveCard Visualizer
Application Version: 1.2.2306.30005

This issue is working fine, hence closing this issue.


What is the proper way to escape query when feeding to -query flag?

Hello again,
I'm trying to building my own command around :Grepper, however I don't know how I should escape a query when feeding it to the -query flag. I have tried shellescape and escape but none worked. When I try to grep something using the built-in operator, it seems that the query is shellescaped.
Any insight is appreciated.

The following works with a custom command for me:
 command! -nargs=+ Agopen Grepper -open -noprompt -tool ag -query <args>

I use it through this (Zsh) shell function:
viag () {
(( $# )) || {
	echo "Usage: $0 <arguments to :Ag in vi>"
	return 64
}
local -a vi_cmd
vi_cmd=(Agopen ${(q-)@})
nvim -c "${vi_cmd}"
}

E.g.:
viag -s "reloading Zsh"

@kminh Does the above suggestion work for you?

Please reopen this if you can't get it to work.


Error on password reset in Traffic Portal

The password reset feature in Traffic Portal returns the following error: 500: Internal Server Error
It does an initial check if will correctly report if the email is not registered, but it doesn't do the reset itself as the previous password remains valid.
Sorry, I don't have access to logs.

This is the api endpoint that is called when a password reset is requested in Traffic Portal:
https://github.com/apache/trafficcontrol/blob/master/traffic_ops/app/lib/TrafficOpsRoutes.pm#L867
which calls
https://github.com/apache/trafficcontrol/blob/master/traffic_ops/app/lib/API/User.pm#L358
Password reset creates a token and attaches it to the user (if the user email exists) and sends an email with a link to the user's email. By following the link in the email that has the token attached as a query parameter, the user can login to TP via the link and reset their password to what they want.
my guess is you are getting a 500 because you don't have email configured properly.

If this is determined not to be a bug but rather a set up issue, this issue should be closed.

closing. please reopen if still having this issue after setting up email in traffic ops.

closing. please reopen if still having this issue after setting up email in traffic ops.


Fix Lightning examples

DP/DDP is failing for all https://github.com/PyTorchLightning/pytorch-lightning/tree/master/pl_examples

duplicate to https://github.com/PyTorchLightning/pytorch-lightning/issues/4694


Enhance external mode TCP ping support

Better goroutine synchronization for exit tracking
Code cleanup for handling of warmup run
Support for custom number of warmup connections
Support for custom sleep between successive connections
Option to select -4 or -6 to force IP version
Logging the results in json format

#130 fixes it.


Define milestones for logistics committee

needs to be coordinated with official timeline as per #3.

Looks like they don't use this repo, so closing for now.


README: add note about seeking funding

Updates #2165

This seems to link to https://github.com/golang/dep/blob/master/golang/dep/issue/2165 while I think it was meant to link to https://github.com/golang/dep/issues/2165.


Get Attachments

Please be aware that these issues will be closed if inactive for more then 14 days :)
I need support for get attachments i use getAttachments() method  on single message and return always an empty array. If I count attachments, I got a right number of attachments. Can I have a right step for to get and download the attachments.
Thanks
Sorry for bad English

me too

Try something like this...
$oC=Webklex\IMAP\Facades\Client::account('reception');
$oC->connect();
$oF=$oC->getFolder('INBOX');
$mm=$oF->query()->where("SUBJECT","Code:")->get();
foreach($mm as $m){
    $tb=$m->getTextBody();
    echo $m->from[0]->mail."\n";
    echo $m->subject."\n";
    echo $tb."\n";
    $aa=$m->getAttachments();
    foreach($aa as $a) {
        echo "+++".$a->name."\n";
        $a->save(storage_path('reception'));
    }
    $m->delete();
}

u need to do this in foreach loop
        foreach ($oMessage->getAttachments() as $attach) {
            $masked = $attach->setMask(AttachmentMask::class);
            $temp = [];
            $temp['mask'] = $masked->mask();
            $temp['image_url'] = $temp['mask']->getImageSrc();
            $temp['attachment_name'] = $temp['mask']->getName();
            $temp['disposition'] = $temp['mask']->getDisposition();
            $temp['size'] = $temp['mask']->getSize();
           //array_push()
        }

and push this values  in array and return the array
u will get the all ataachments


Main -> Next (after Release 2024-07-19)

There is a type error in sdk causing the prepack script to fail, and the NPM publish to fail. @ItsMeBrianD is fixing.


Error when getDisplays

When getDisplays is called a error is throwed: type 'Null' is not a subtype of type 'int'

Device: Android Tablet
Version 7.1.2

try {     final values = await displayManager.getDisplays();     print(values);   } catch (error) {     print(error);   }
The _displayMethodChannel?.invokeMethod returns:
[{a: 0, b: 3, c: 0, d: Built-in Screen}, {a: 1, b: 11, c: 0, d: HDMI Screen}]
But the displayFromJson expects a json with "displayId", "flags", "name", "rotation", instead receives "a", "b", "c", "d" fields.

I have solved & Added Custom Methods
Go & check
https://github.com/MUSA-19542/FlutterCustom/tree/main


PageLayout

If a new field is used as anchor for a Standard field in moveafter, the compilation Fails.
layout
{
    addafter(Base_FieldA)
    {
        field(Ext_Field1; Ext_Field1) { }
        // field(Ext_Field2; Ext_Field2 { }
    }
    moveafter(Ext_Field1; Base_FieldC)
}

}
If Moveafter is moved before the "AddAfter", a warning is shown. ({
"message": "Cannot use '"Total Amount (LCY)"' before it is declared",},
if it is moved after the declaration, the compile crashes.
My Goal was to Show the fields in the sequence Base_FieldA, Ext_Field1, Base_FieldC, Ext_Field2
Expection: This should either be working or given an error message.
Processing of message 'al/createPackage' failed with error: 'Object reference not set to an instance of an object.'
Details:
System.NullReferenceException: Object reference not set to an instance of an object.
at Microsoft.Dynamics.Nav.CodeAnalysis.Translation.LabelWriterVisitor.<>c__DisplayClass12_0.b__1(PropertySymbol property) in C:\a\459\s\source\Prod\Microsoft.Dynamics.Nav.CodeAnalysis\Translation\LanguageFile\LabelWriterVisitor.cs:line 77
at Microsoft.Dynamics.Nav.CodeAnalysis.Utilities.EnumerableExtensions.Do[T](IEnumerable1 source, Action1 action) in C:\a\459\s\source\Prod\Microsoft.Dynamics.Nav.CodeAnalysis\Utilities\EnumerableExtensions.cs:line 55
at Microsoft.Dynamics.Nav.CodeAnalysis.Translation.LabelWriterVisitor.VisitSymbolWithProperties(Symbol symbolWithProperties) in C:\a\459\s\source\Prod\Microsoft.Dynamics.Nav.CodeAnalysis\Translation\LanguageFile\LabelWriterVisitor.cs:line 70
at Microsoft.Dynamics.Nav.CodeAnalysis.Translation.LabelWriterVisitor.DefaultVisit(Symbol symbol) in C:\a\459\s\source\Prod\Microsoft.Dynamics.Nav.CodeAnalysis\Translation\LanguageFile\LabelWriterVisitor.cs:line 29
at Microsoft.Dynamics.Nav.CodeAnalysis.Translation.LabelWriterVisitor.VisitMembersOfSymbol(Symbol symbol) in C:\a\459\s\source\Prod\Microsoft.Dynamics.Nav.CodeAnalysis\Translation\LanguageFile\LabelWriterVisitor.cs:line 118
at Microsoft.Dynamics.Nav.CodeAnalysis.Translation.LabelWriterVisitor.VisitMembersOfSymbol(Symbol symbol) in C:\a\459\s\source\Prod\Microsoft.Dynamics.Nav.CodeAnalysis\Translation\LanguageFile\LabelWriterVisitor.cs:line 118
at Microsoft.Dynamics.Nav.CodeAnalysis.Translation.LabelWriterVisitor.VisitMembersOfSymbol(Symbol symbol) in C:\a\459\s\source\Prod\Microsoft.Dynamics.Nav.CodeAnalysis\Translation\LanguageFile\LabelWriterVisitor.cs:line 118
at Microsoft.Dynamics.Nav.CodeAnalysis.Utilities.XmlUtilities.WriteStartEnd(XmlWriter writer, String nodeName, Action action, String namespacee) in C:\a\459\s\source\Prod\Microsoft.Dynamics.Nav.CodeAnalysis\Utilities\XmlUtilities.cs:line 24
at Microsoft.Dynamics.Nav.CodeAnalysis.Utilities.XmlUtilities.WriteStartEnd(XmlWriter writer, String nodeName, Action action, String namespacee) in C:\a\459\s\source\Prod\Microsoft.Dynamics.Nav.CodeAnalysis\Utilities\XmlUtilities.cs:line 24
at Microsoft.Dynamics.Nav.CodeAnalysis.Utilities.XmlUtilities.WriteStartEnd(XmlWriter writer, String nodeName, Action action, String namespacee) in C:\a\459\s\source\Prod\Microsoft.Dynamics.Nav.CodeAnalysis\Utilities\XmlUtilities.cs:line 24
at Microsoft.Dynamics.Nav.CodeAnalysis.Utilities.XmlUtilities.WriteStartEnd(XmlWriter writer, String nodeName, Action action, String namespacee) in C:\a\459\s\source\Prod\Microsoft.Dynamics.Nav.CodeAnalysis\Utilities\XmlUtilities.cs:line 24
at Microsoft.Dynamics.Nav.CodeAnalysis.Translation.XliffOutputter.WriteDefaultNodesAndContinue(XmlWriter writer, String appName, String targetLanguage, Action groupContentWriter) in C:\a\459\s\source\Prod\Microsoft.Dynamics.Nav.CodeAnalysis\Translation\LanguageFile\XliffOutputter.cs:line 65
at Microsoft.Dynamics.Nav.CodeAnalysis.Translation.LanguageFileOutputter.OutputLanguageFile(Compilation compilation, Stream outputStream, String appName) in C:\a\459\s\source\Prod\Microsoft.Dynamics.Nav.CodeAnalysis\Translation\LanguageFile\LanguageFileOutputter.cs:line 33
at Microsoft.Dynamics.Nav.CodeAnalysis.CommandLine.CommonCompiler.OutputLanguageFile(Compilation compilation, CompilerTextWriter consoleOutput, ErrorLogger errorLogger) in C:\a\459\s\source\Prod\Microsoft.Dynamics.Nav.CodeAnalysis\CommandLine\CommonCompiler.cs:line 512
at Microsoft.Dynamics.Nav.CodeAnalysis.CommandLine.CommonCompiler.RunCore(CompilerTextWriter consoleOutput, ErrorLogger errorLogger, CancellationToken cancellationToken) in C:\a\459\s\source\Prod\Microsoft.Dynamics.Nav.CodeAnalysis\CommandLine\CommonCompiler.cs:line 440
at Microsoft.Dynamics.Nav.CodeAnalysis.CommandLine.CommonCompiler.Run(CompilerTextWriter consoleOutput, CancellationToken cancellationToken) in C:\a\459\s\source\Prod\Microsoft.Dynamics.Nav.CodeAnalysis\CommandLine\CommonCompiler.cs:line 313
at Microsoft.Dynamics.Nav.EditorServices.Protocol.LanguageServer.Extensions.CreatePackageRequestHandler.d__4.MoveNext() in C:\a\459\s\source\Prod\Microsoft.Dynamics.Nav.EditorServices.Protocol\LanguageServer\Extensions\CreatePackageRequestHandler.cs:line 47
--- End of stack trace from previous location where exception was thrown ---
at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
at Microsoft.Dynamics.Nav.EditorServices.Protocol.MessageProtocol.RequestHandlerBase`1.d__10.MoveNext() in C:\a\459\s\source\Prod\Microsoft.Dynamics.Nav.EditorServices.Protocol\MessageProtocol\RequestHandlerBase.cs:line 45
--- End of stack trace from previous location where exception was thrown ---
at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
at Microsoft.Dynamics.Nav.EditorServices.Protocol.RequestRegistry.d__6.MoveNext() in C:\a\459\s\source\Prod\Microsoft.Dynamics.Nav.EditorServices.Protocol\Endpoints\RequestRegistry.cs:line 59

Please follow the issue templates


Custom data on FirebaseAdmin.Messaging.Notification?

Hello,
I'm trying to send a notification with this sdk and I'm supposed to set "click_action":"FCM_PLUGIN_ACTIVITY" on the notification object so that our cordova app can handle click events.  Is there any way to do this via the sdk?

click_action is only available for AndroidNotification in the v1 API: https://firebase.google.com/docs/reference/fcm/rest/v1/projects.messages#androidnotification

@chong-shao please see if there's anything missing from this API, and resolve as you see fit.

@hiranya911 I may misunderstood something here, but seems like click action is supported?
https://github.com/firebase/firebase-admin-dotnet/blob/master/FirebaseAdmin/FirebaseAdmin/Messaging/AndroidNotification.cs#L81

Yes, it is supported on AndroidNotification. But the developer also wants it supported on Notification (I think). It seems in the legacy API this was available as general notification option.

That's correct.  Our client app uses cordova-plugin-firebase which requires a click_action to be set on the notification object to trigger events in the app after a user opens the app via a notification.  I tried setting the value in AndroidNotification already but it doesn't have any effect there.

Hi halomademeapc, the fields in Notification object all map to fields in all platforms (Android, iOS, and Webpush). But if I understand it correctly, clieck_action do not have a corresponding field in iOS https://developer.apple.com/library/archive/documentation/NetworkingInternet/Conceptual/RemoteNotificationsPG/PayloadKeyReference.html#//apple_ref/doc/uid/TP40008194-CH17-SW1 therefore it makes less sense to have it in the Notification object.
I assume you have an Android app. Setting it in AndroidNotification should be the correct approach. If it does not have any effect on your Android app, could you double check if your app's implementation in handling the notification's click_action works as intended.


Missing Functionality for 'Status' Mapping Field After Bulk Count File Upload

Current behavior
Currently, there is no implementation of the expected functionality related to the 'Status' mapping field, leading to inconsistencies in record processing.
Expected behavior
Records without a status should default to "draft" and be processed accordingly.
Records explicitly set to "draft" should be processed and visible on the draft page.
Records with an assigned status should require a facility mapping field; otherwise, they should not be processed.(user should be notified about the mandatory field in this case)
Users should receive notifications about any records that were not processed due to invalid status values.
Steps to reproduce the issue
Prepare a bulk count CSV file with varying status values.
Upload the file using the bulk count upload feature.
Observe the behavior of the records based on the provided statuses.
Environment details
App version : v2.1.0
App environment : UAT

I will contibute this


Using Another Display

Is it possible to use Raspberry Pi 7 Inch IPS Lcd Display for this project?

not without modifying/re configuring the code to work with your specific display driver and commands.

thank you.

I ordered one of these from Pimoroni yesterday, I'm really hoping to be
able to use this in the future (just saying).
Remains to be seen if it can be a suitable option ...
Inky Impression (7 colour ePaper/eInk/EPD) – Pimoroni
https://shop.pimoroni.com/products/inky-impression
On Fri, 13 Nov 2020 at 10:05, sonay duman<EMAIL_ADDRESS>wrote:

thank you.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/TomWhitwell/SlowMovie/issues/10#issuecomment-726641010,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAOLALN3IAHHN4H6IC6CO6TSPTZFTANCNFSM4TUJUZKA
.

--
http://www.mjbright.net
Cloud Native Training in English or French

Kubernetes, Docker, Terraform, Ansible, Open Policy Agent
Serverless,  Micro-services
Python, Git

Enregistré sous le numéro 84 38 07189 38. Cet enregistrement ne vaut pas
agrément de l’État

Really nice! @mjbright

Same idea. The brunt of the code/work should work for anything, its a matter of having the script load the drivers that apply to your screen and then changing any code that directly relates to showing the image/clearing the screen and the commands your specific screen understands.


[BUG] There is a display bug

The third level and subsequent titles will exceed the display range.

Hi @ChenYangZuo I'm not facing this in my version of the theme. Can you add the specific steps to re-create the issue.

I also encountered the same problem

+1

I encounter this problem too。

@ChenYangZuo / @YXiandeng / @LetianYuan / @cugjie , this issue is fixed with the latest version (Version 1.0.1). Please check. Also added additional improvements for hover actions for headings. Note that I'm using a mac and no way to check it in Windows / Linux.

Thank you for the update! I’ve also tested the fix in Windows11, and everything works perfectly. I appreciate your hard work on this!


ArrayBuilder is not Send

I'm getting
190 |             let mut insert_builder = Arc::new(ArrayBuilder::new(sas).expect("can build array"));
    |                 ------------------ has type `Arc<serde_arrow::ArrayBuilder>` which is not `Send`

if I try to use ArrayBuilder in async functions (which often have the Send constraint for the things in the closure). I think the problem is the raw pointer here:
https://github.com/chmp/serde_arrow/blob/eb8d37a5bdab748251aa983cb1c1517047f28702/serde_arrow/src/internal/serialization/struct_builder.rs#L23C1-L23C55
Maybe it could be rewritten to not use raw pointers. Or be declared as Send if the raw pointer isn't used in a way that breaks Send guarantees (from a quick glance I don't think it is).

@gz  Thanks for the report. You're right there is no reason for the structure to not be Send. I will fix this issue on the develop-0.12 branch.

Fixed with #227. I will close this issue once I release 0.12. The refactoring of the error messages will take some time though

Awesome thanks for the quick turnaround!

Released with with 0.12.0


Fix FI-297 Add ClinicalNotes sequence to us_ocre_module.yml automatic…

Add ClinicalNotesSequence to module.yml.rb template.
Fix class name from UsCoreR4ClincialNotesSequence to USCoreR4ClinicalNotesSequence

Looks good to me.  Nice catch on capitalizing US.
@czh-orz Are there instructions anywhere on how to run the test generator?  Just wanted to put this through its paces.

No, the instructions aren't up anywhere. You just need to run "ruby generator.rb" in the generator directory.


Add slem4r images in channel

Part of rancher/elemental#1008

This PR switches from elemental-teal-channel to elemental-channel. The new elemental-channel includes all previous Teal images and brings the new SLE Micro 4 Rancher image.
I think this is the cleanest way to migrate. On upgrades this will cause the following:

helm deletes elemental-teal-channel and all the associated versions
helm creates the new elemental-channel including all versions, previous and new ones

On ISO creation the drop down menu with this PR looks like

Finally got green tests for UI and CLI 🎉


fix: duplicate success transfer logic

some people aren't getting the transition out of pending state--this adds a duplicate mechanism for executing that transition

🟡 Heimdall Review Status

Requirement
Status
More Info

Reviews

🟡
0/1

Denominator calculation

Show calculation

1 if user is bot
0

1 if user is external
0

From .codeflow.yml

1

Additional review requirements

Show calculation

Max
0

0

From CODEOWNERS

0

Global minimum
0

Max

1

1

1 if commit is unverified
0

Sum
1


Go - vehicle_purchase - fixed typo

Thanks for this, nice catch!
Can you fix this in the exemplar file too please?


Feature/order page

Description
This page shows order summary to user
Please provide a short summary explaining what this PR is about.
It includes: order Id and status, product name, quantiy, total cost, delivery Info, contact and payment button.
Fixes #93
How to test?
Please provide a short summary how your changes can be tested?
When ready by npm run dev in http://localhost:3000/order/2
Checklist

[x] I have performed a self-review of my own code
[x] I have followed the name conventions for CSS Classnames and filenames, Components names and filenames, Style filenames, if you are in doubt check the the project README.MD and here https://github.com/HackYourFuture-CPH/curriculum/blob/master/review/review-checklist.md
[x] I have commented my code, particularly in hard-to-understand areas, if you code was simple enough mark the box anyway
[x] I have made corresponding changes to the documentation, if you code was simple enough mark the box anyway
[x] This PR is ready to be merged and not breaking any other functionality

It is failed to compile and showing this error -> ERROR in ./src/client/containers/OrderPage/OrderPage.Container.js
[1] Module not found: Error: Can't resolve '../../components/Loader/index' in 'C:\class18\fp-class18\src\client\containers\OrderPage'

Thank you Varsha, I fixed the error.


Add Twitter account IDs to legislators-social-media.yaml

Since we're adding Facebook/Instagram/Youtube ID numbers for the legislators, might as well add Twitter ID numbers, which are helpful when screen_names change as they sometimes do.
 In this run, 3 invalid names were found and removed from the YAML: OlsonPressShop, McCaulPressShop, USRepRussell.
A quickie (Python 3) script is added to show how the reconciliation and batch insertion was done: scripts/fetch_and_insert_twitter_ids.py

I've got no issues with this. +1

Very smart addition, chasing changing Twitter handles is a hassle +1

On Aug 2, 2015, at 4:30 PM, Derek Willis<EMAIL_ADDRESS>wrote:
I've got no issues with this. +1
—
Reply to this email directly or view it on GitHub.

This is a smart addition and I also have no problems with it. I also don't mind that it's standalone and not integrated with social_media.py.
However, I would like to see if we can't make the script integrate properly.

Right now, it's all commented out right now, so as not to break the Travis build. That looks to be fixable just by adding tweepy to scripts/requirements.txt, which Travis is set to use to install dependencies. I was able to run the Travis script successfully on my machine after doing this and installing tweepy.
The output data path is set to /tmp/new-social-media.yaml. The repo already allows scripts to make/use a scripts/cache directory for temporary work. That said, I think you could just have it overwrite the social media YAML file automatically, and only commit the file after verification.
The twitter credentials path is hardcoded to expanduser("~/.creds/twit.json"). This would be a better place to use the scripts/cache directory, like the current social_media.py script does for YouTube API credentials. This way, the path is relative and isn't specific to how the person running it manages their computer.
It'd be nice to update the social media section of the README with a couple lines to mention the new field and the new script.

I think each of these are pretty small tweaks. Game to make them, @dannguyen?

I like IDs!

@konklone Thanks for the lengthy writeup...I can do those tweaks. Sorry, I'm still a Python noob and can't figure out how to set up my project space properly

No problem at all. And if any of them are unexpectedly annoying, let me know and I can address them during the merge process.

Ah OK, I'm about done but now realize I should just add my changes into social_media.py as a new resolvetw() method?

If it's easy enough, that'd be ideal. If it's not, let me know and we can do it post-merge or just document the new command.

OK, I've added to social_media.py. Running:
   python social_media.py --resolvetw

Will:

Resolve twitter entries to Twitter IDs
Verify that existing twitter_id entries have the correct screen_name as the twitter value. If not, the twitter value is updated.

I also added [scripts/social/twitter.py] to keep things from getting too cluttered in social_media.py.

I merged, after adding two commits:

https://github.com/unitedstates/congress-legislators/commit/9067af0790f9763be9a977b11d4727ff2e560c28 - I added tweepy to requirements.txt.
https://github.com/unitedstates/congress-legislators/commit/c8c972d2953e16fd0de066ccc14b92f2f8a7687e - I noticed your commit had removed a couple of no-longer-valid screen names. I went and replaced them by looking at the members' sites (they'd renamed the accounts), and then ran your new --resolvetw command to resolve their IDs.

The ID resolution worked like a charm, after I created a Twitter app and access token and put them in scripts/cache/twitter_client_id as your script's comments told me to.
Thanks for following up and making those changes, @dannguyen! I didn't realize the extent of how helpful the new --resolvetw command is -- using the IDs to detect renames and missing/suspended accounts is fantastic, and will make our data even more reliable going forward. :100:

My pleasure...I use this dataset so much it's the least I can do


[iOS][Font Bug]flutter 3.0 Chinese font FontWeight.w500 not work

Code:
TextSpan(
    text: name,
    style: TextStyle(color: Theme.of(context).textTheme.bodyText2!.color, fontSize: 16, fontWeight: FontWeight.w500, height: 1.0),
)

before 3.0 version, like this:

upgrade to 3.0 version, like this:

English keep medium font weight, but Chinese changed regular.

This probably is similar to https://github.com/flutter/flutter/issues/70164, so please follow-up in it for further updates.
Closing this as a duplicate. If you disagree, write in comments and I'll reopen it.


Per-feature generic permissions system

Is there a specific reason, why only staff/admin users are allowed to create lists? I would like to allow users to create without having access to admin pages. Is that just a lack of permissions or is there an other reason for this?

Interesting question. I think I was just going for a safe "least privilege" scenario, and thinking of it like a Jira board where a manager controls the lists and staff work on those lists (which has been the case everywhere I've worked). But  I can imagine all sorts of permissions / privileges scenarios that are different between projects. The challenge is in tackling that in a clean way that scales to different projects with differently named groups, code that calls a central permissions system without a ton of if/then conditionals all over the place, etc. And I don't have a clear picture in my mind of how that might work. I wouldn't want to dictate the Group names that have to be in place, for example.
The best I can think of would be to have a TODO_PERMISSIONS dictionary in settings, where keys are privilege names and values are lists of groups:
TODO_PERMISSIONS = {
    "can_create_lists": ["Managers", "Coders", "Visitors"],
    "can_delete_lists": ["Managers", "Coders"],
    "can_complete_tasks": ["Stunt Pilots", "Visitors"],
}

And then have a shared function that returns bool by consulting this mapping against the current user, and finally a template tag to wrap that function. So then you could use things like if can_create_lists: blah blah either in python or in template code.
Other ideas?

I welcome contributions on this feature, fwiw - let me know if interested.

Related issues: #5, #25 -- Aka, we've talked about this before. :smirk:

@shacker @ezzra how about https://github.com/dfunckt/django-rules ?

I'm a big fan of django-rules, but since todo is a plugin for existing sites, I'm very interested in keeping the number of dependencies as limited as possible. I'll think about it...


Revamp UI of the Simulator [WIP]

Description:
It's a work in progress.

Coverage remained the same at 84.223% when pulling b32b5f7f52f5a9288a10e0f8dafebfbb2ad59d5e on abstrekt:revampUI into b14f86cbe15aa1b39d0fe2569eff463c8003d8b4 on CircuitVerse:master.

in the last commit I just added some styles, why is coverage being affted?

@abstrekt please resolve the conflicts, I've changed the base branch.

@nitin10s please check


Added default flags

Hi @matthewelwell and @dabeeeenster,
I have added functionality to have default flags. The developer can add a list of feature flag names so that when a call to Flagsmith fails, methods like identifyUserWithTraits() will still return flags with default values.
The default values are either false or null by default, or can be set using existing configuration methods setDefaultFlagPredicate() and setDefaultFlagValueFunction().
    final FlagsmithClient flagsmithClient = builder
        .setDefaultFeatureFlags(new HashSet<String>() {{
          add("feature-flag-name");
        }})
        .build();

Cheers,
Olga

@sw-tracker I'm happy with the PR here now but I'd like to start using release branches more strictly so I've changed the base from main to release/4.0.1. Could you rebase onto that branch and deal with the inevitable conflict in pom.xml then we can get it merged?

Hi @matthewelwell, I see sw-tracker wants to merge 11 commits into Flagsmith:release/4.0.1 from sw-tracker:main and no merge commits. Wont this PR just merge to the release branch? I am not sure what else I should do.


[FEATURE REQ] Add AzureCliCredential to possible Key Vault authentication methods

Is your feature request related to a problem? Please describe.
When developing locally, I would like to re-use my az login when running my Spring Boot application. This way my application can access secrets without including any secrets in the configuration (requiring jasypt or similar).
I would also imagine this to be useful for console applications.
Describe the solution you'd like
I would like com.azure.spring.keyvault.KeyVaultEnvironmentPostProcessorHelper#getCredentials(java.lang.String) to include com.azure.identity.AzureCliCredential as an option. Probably enabled by something like azure.keyvault.enable-cli-auth.
Describe alternatives you've considered
An alternativ would be to override beans, but it seems the Azure Key Vault integration is not using things like @ConditionalOnMissingBean. I guess that is because it is too early in the spring boot startup process?
Another option would be to require the developer to create a service principal and add it as environment variables, but that is not as elegant as az login.
Information Checklist
Kindly make sure that you have added all the following information above and checkoff the required fields otherwise we will treat the issuer as an incomplete report

[X] Description Added
[X] Expected solution specified

(I am happy to attempt a pull request, if the feature sounds good)

Thanks @anderius for filing this.  @stliu from the azure-spring team will follow up with you shortly

@anderius PR is welcome, we appreciate your contribution very much.

@backwind1233 I have made an attempt in the linked Pull requests, and it works when I tested the code in my project.

This issue will be addressed in this PR #22472.

@anderius .
Thank you for your check.
And I'll keep this issue closed, only use one issue/PR to track similar problems.

I am keeping track, as I think this is a really useful feature!
As far as I can tell, the current PR fixing this is https://github.com/Azure/azure-sdk-for-java/pull/23849.

Closing this issue now, please check #24260 for the release of our next major version.


Add files via upload

Add domain .stu for St. Thomas University. Thanks.

@SuperNatural7 file/lib/domains/ca/stu.txt: this request has an incorrect file path format, please ensure that you are familiar with     this repository rules located at the bottom of this page and change     your request accordingly. If you don't know how to change request, close it and open a new one.     If you are not able to make the pull request according the instructions, please send us an email to<EMAIL_ADDRESS>Please mention this request URL in the message.


Modified GetZoneList method to get Zone list using Reflection instead…

Modified GetZoneList method.

thank you!

You're welcome. Now I can see Zone in Korean. Thank you :)


Simplify translation of memory operands

Instead of
| | 0000: [ PSEUDO ]     +0x0     movq     t1           0x0
| | 0001: [ PSEUDO ]     +0x0     addq     t1           $sp
| | 0002: [ PSEUDO ]     +0x0     lddb     t0:8         t1           0x0

we get
| | 0000: [ PSEUDO ]     +0x0     lddb     t0:8         $sp          0x0

So we saved in total 3 instructions including my previous PR.

I refactored the whole thing a bit. It also no longer does multiplication of 1. When only a displacement is used it also simply moves int now.


Support cancelling thumbnail downloading

Or consider deferring it briefly while scrolling to mean we don't do lots of unnecessary work and respond quickly when the user settles on a page.

Pushing this into future; while it would likely have a significant performance improvement, it doesn't stop the app functioning as intended.


Feature/remove filters

Fixed long-awaited issue that dealt with x'ing out filter chips in cases table and reflecting changes in criteria. Tested in multiple ways to try to throw an error but seems consistent in all cases. The reason I tackled this was that it was one of the Trello cards that would significantly boost the user experience using functional components.
Fixes # (issue)

Users can now X out filter chips with ease and not go back into the ANT component and reset. The biggest issue and challenge was abstracting the ANT component and the search and filter functionality because they are separate. Everything inside the table is from ANT design. We have the chips being able to be x'd out outside of the ANT table component which was done using the document object model otherwise it would not have been recognized by Reacts "virtual DOM". We needed to hit the actual DOM to extend changes.

A minor fix that made a big difference which I will include in this pull req. would be depending on what criteria you search it would show up in the filter chip instead of raw JSON from the backend (horrible user experience) Ex: origin_city but now is showing up as Baltimore if you search Baltimore rather than origin_city.

Urgent Front-end change
Please delete options that are not relevant.

[x] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)

Checklist:

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[ ] I have removed unnecessary comments/console logs from my code
[x] My changes generate no new warnings
[x] I have checked my code and corrected any misspellings
[x] No duplicate code left within changed files
[x] Size of pull request kept to a minimum
[x] Pull request description clearly describes changes made & motivations for said changes

Please see the video for this pull below
https://www.loom.com/share/a8073174ab2f42b68aeff51e2e28e424

This looks great! I think the style was done well, and you cleanly solved a problem and provided more functionality.

As a Data Scientist this looks very good way to fix this problem not fully understanding the front end it looks like you did a great job editing the code to make it work


Refactoring crescendo collins13ipcc

resolves #431. ported diagnostics to produce some IPCC AR5 Chapter 12 Figures, comparing historical period and scenarios. No observations needed.
one diagnostic in recipe commented out because waiting for #531 to be resolved.
only a fraction of CMIP5 models included in recipe at the moment, nevertheless takes more than 3 hours to run.

It seems that the automatic tests are not applied.

Anything I need/can to do about that?

@mattiarighi: Yeah, there is a switch in the circleci configuration to also apply it to forked pull requests. To my surprise I found that I could flip it, so I did. It still had to be triggered then, which it was by @ruthlorenz latest push.
@ruthlorenz: It seems the only test failures are due to the ncl style checker. Did you find the relevant error messages?

I have already checked using nclcodestyle and it runs without any complaint on my machine, so no idea where this is coming from.

regarding #692, I have not checked in detail what it does, but I am a bit worried that it messes up a lot in here. I need to pair historical runs with scenarios, no idea how this is supposed to be done without indexing...and I do not have the time to redo everything a third time....

Ok, let's try to merge this PR first, I will take care of adapting it to the new interface.

I don't know why there is a discrepancy between your machine and the automated tests, but if you follow the details link in one of the ci/circleci checks above, you can find the following summary somewhere in the test output:
----------------------------- Captured stdout call -----------------------------
Formatting check of NCL code in directories: esmvaltool, tests

/python3_test/esmvaltool/diag_scripts/shared/ensemble.ncl:458:4: W292 no newline at end of file
/python3_test/esmvaltool/diag_scripts/shared/statistics.ncl:1233:45: E231 missing whitespace after ','
/python3_test/esmvaltool/diag_scripts/shared/statistics.ncl:1292:1: E101 indentation contains mixed spaces and tabs
/python3_test/esmvaltool/diag_scripts/shared/statistics.ncl:1292:1: W191 indentation contains tabs
/python3_test/esmvaltool/diag_scripts/shared/statistics.ncl:1292:15: E128 continuation line under-indented for visual indent
/python3_test/esmvaltool/diag_scripts/shared/statistics.ncl:1293:1: E101 indentation contains mixed spaces and tabs
/python3_test/esmvaltool/diag_scripts/shared/statistics.ncl:1294:1: E101 indentation contains mixed spaces and tabs
/python3_test/esmvaltool/diag_scripts/shared/statistics.ncl:1294:1: W191 indentation contains tabs
/python3_test/esmvaltool/diag_scripts/shared/statistics.ncl:1294:15: E128 continuation line under-indented for visual indent
/python3_test/esmvaltool/diag_scripts/shared/statistics.ncl:1295:1: E101 indentation contains mixed spaces and tabs
/python3_test/esmvaltool/diag_scripts/shared/statistics.ncl:1296:1: E101 indentation contains mixed spaces and tabs
/python3_test/esmvaltool/diag_scripts/shared/statistics.ncl:1296:1: W191 indentation contains tabs
/python3_test/esmvaltool/diag_scripts/shared/statistics.ncl:1296:15: E128 continuation line under-indented for visual indent
/python3_test/esmvaltool/diag_scripts/shared/statistics.ncl:1297:1: E101 indentation contains mixed spaces and tabs
/python3_test/esmvaltool/diag_scripts/shared/statistics.ncl:1298:1: E101 indentation contains mixed spaces and tabs
/python3_test/esmvaltool/diag_scripts/shared/statistics.ncl:1298:1: W191 indentation contains tabs
/python3_test/esmvaltool/diag_scripts/shared/statistics.ncl:1298:8: E128 continuation line under-indented for visual indent
/python3_test/esmvaltool/diag_scripts/shared/statistics.ncl:1299:1: E101 indentation contains mixed spaces and tabs
/python3_test/esmvaltool/diag_scripts/shared/statistics.ncl:1349:41: E203 whitespace before ','

Your NCL code does not follow our formatting standards.

A list of warning and error messages can be found above,
prefixed with filename:line number:column number.

I do not think I can do much about "tas" in esmvaltool/cmor/_fixes/CMIP5/CCSM4.py ?

Not really, no. You could mark it with a #noqa qualifier so that it wouldn't be checked, but really, since we will have this issue with all fixes, there should be a better solution. @jvegasbsc, do you already have a standard procedure for this?

Is there a way we can edit the code of this PR (if @ruthlorenz agrees, of course) and commit the changes?
This is because after #692 quite a lot of changes will be needed to adapt it to the improved interface and the easiest way is that these changes are implemented by @axel-lauer or myself.

@mattiarighi: Probably the most straight forward way to do this is to create a pull request in her repository for the corresponding branch. This way it's also clear how she can approve the changes and the two (somewhat) separate issues are clearly separated.
Alternatively, you can of course wait with the merge of #692 until this one is merged.

I would appreciate it if @axel-lauer or @mattiarighi would help with the changes needed for #692
Just let me know what I need to do so that you can help :-)

This has been reopened in the private repository.

Note that changes that are not specific to this diagnostic/recipe (such as fixes, preprocessor functions, recipe schema, changes to code that is used by other diagnostics such as perfmetrics) should be done in the public repo, or this will lead to conflicts that are impossible to resolve because both repo's will evolve in a different direction.

Yes, we discussed this with @bjoernbroetz.
This is a more general issues, since we synchronize the private repo with the public one on a daily basis, but not the other way round.
Our suggestion would be to open a pull request on regular basis (say, every 2 weeks) and merge all changes not specific to diagnostic/recipes from the private into the public repository.
Would that work?

In addition to that, I think it would be good to enable CircleCI and Codacy also for the private repository, to avoid that pull requests get merged into the private repository that do not adhere to our standards and in that way sub standard code makes it's way into the public repository or the task of cleaning up will end up with you again causing you more work.

@bjoernbroetz do you have the access rights to turn CircleCI and Codacy on?

@mattiarighi @bjoernbroetz If I remember correctly, CircleCI and/or Codacy can only be activated for private repositories if we pay for it.

I think we should follow @bouweandela 's suggestion above.
It has the advantage that the private and public part of the PR are clearly separated and can be discussed at the same time. If we synchronize the public part at a later stage and modifications are needed, these could also affect the private part which has been previously merged in the private repo.

If I remember correctly, CircleCI and/or Codacy can only be activated for private repositories if we pay for it.

I think you can ask them if it would be possible to get it for free, since esmvaltool is an open source project and the private contributions will be made public after the paper they are used for is published. However, if they do not agree, I would suggest simply paying. The cost of a service like this is very small compared to the cost of developing the software.

In addition to that, I think it would be good to enable CircleCI and Codacy also for the private repository, to avoid that pull requests get merged into the private repository that do not adhere to our standards and in that way sub standard code makes it's way into the public repository or the task of cleaning up will end up with you again causing you more work.

@bjoernbroetz do you have the access rights to turn CircleCI and Codacy on?

The owner of the organization ESMValGroup can turn this on.

Maybe we should discuss this here: #769


default selected item

hi there,
I'm trying to set up a default item from dataSource but when I do his in viewdidload :
house.selectedItem = UserDataSingleton.sharedDataContainer.user_house_size
I get an error saying it's a get-only property. Is there any way I set a default value ?
Thank you for your amazing package.

you have to use :
house.selectRow(at: indexOfYourItem)
indexOfYourItem is int


Figure out the optimal way to Layout the menu items

We need to Position the children and then animate them to solve the objective. This task is to figure out what's the best way to position the children within the parent layout.

The layout is done. Great!
We have two things to consider here:

Calculate the size of the Parent
Position the children within the parent

Calculate size of parent
We need the children and the size of the anchor view to determine the size of the parent. The parent will not physically contain the anchor, but while calculating the size of the parent we will assume that the anchor is also part of the parent. We will accommodate Margins and Padding.
Position children in Parent
We need the children and the relative position of the Anchor to the Parent. Using this, we will position the children around or above or ... the parent. Again, margins and padding are accommodated.

To position the children, we also need the position of the parent.


export.sh : xtensa-esp32s2-elf has no installed versions (IDFGH-4987)

I installed the latest idf.
runned install.sh as root, else no permission.
Tools are present.
IDF_PATH is present.
sourced export.sh:
Detecting the Python interpreter
Checking "python" ...
Checking "python3" ...
Python 3.8.5
"python3" has been detected
Adding ESP-IDF tools to PATH...
ERROR: tool xtensa-esp32s2-elf has no installed versions. Please run '/home/dig/projecten/esp32/esp-idf/install.sh' to install it.
ERROR: tool xtensa-esp32s3-elf has no installed versions. Please run '/home/dig/projecten/esp32/esp-idf/install.sh' to install it.
ERROR: tool riscv32-esp-elf has no installed versions. Please run '/home/dig/projecten/esp32/esp-idf/install.sh' to install it.
ERROR: tool openocd-esp32 has no installed versions. Please run '/home/dig/projecten/esp32/esp-idf/install.sh' to install it.
env: ‘idf.py’: No such file or directory
running install again:
dig@dig-desktop:~/projecten/esp32/esp-idf$ sudo ./install.sh
[sudo] password for dig:
Detecting the Python interpreter
Checking "python" ...
Checking "python3" ...
Python 3.8.5
"python3" has been detected
Installing ESP-IDF tools
Installing tools: xtensa-esp32-elf, xtensa-esp32s2-elf, xtensa-esp32s3-elf, riscv32-esp-elf, esp32ulp-elf, esp32s2ulp-elf, openocd-esp32
Skipping<EMAIL_ADDRESS>(already installed)
Skipping<EMAIL_ADDRESS>(already installed)
Skipping<EMAIL_ADDRESS>(already installed)
Skipping<EMAIL_ADDRESS>(already installed)
Skipping<EMAIL_ADDRESS>(already installed)
Skipping<EMAIL_ADDRESS>(already installed)
Skipping<EMAIL_ADDRESS>(already installed)
Installing Python environment and packages
Installing Python packages from /home/dig/projecten/esp32/esp-idf/requirements.txt
Looking in indexes: https://pypi.org/simple, https://dl.espressif.com/pypi
Ignoring python-socketio: markers 'python_version <= "2.7"' don't match your environment
Ignoring None: markers 'sys_platform == "win32"' don't match your environment
Requirement already satisfied: setuptools>=21 in /root/.espressif/python_env/idf4.4_py3.8_env/lib/python3.8/site-packages (from -r /home/dig/projecten/esp32/esp-idf/requirements.txt (line 4)) (54.1.2)
Requirement already satisfied: click>=7.0 in /root/.espressif/python_env/idf4.4_py3.8_env/lib/python3.8/site-packages (from -r /home/dig/projecten/esp32/esp-idf/requirements.txt (line 8)) (7.1.2)
Requirement already satisfied: pyserial>=3.0 in /root/.espressif/python_env/idf4.4_py3.8_env/lib/python3.8/site-packages (from -r /home/dig/projecten/esp32/esp-idf/requirements.txt (line 9)) (3.5)
Requirement already satisfied: future>=0.15.2 in /root/.espressif/python_env/idf4.4_py3.8_env/lib/python3.8/site-packages (from -r /home/dig/projecten/esp32/esp-idf/requirements.txt (line 10)) (0.18.2)
Requirement already satisfied: cryptography>=2.1.4 in /root/.espressif/python_env/idf4.4_py3.8_env/lib/python3.8/site-packages (from -r /home/dig/projecten/esp32/esp-idf/requirements.txt (line 11)) (3.4.6)
Requirement already satisfied: pyparsing<2.4.0,>=2.0.3 in /root/.espressif/python_env/idf4.4_py3.8_env/lib/python3.8/site-packages (from -r /home/dig/projecten/esp32/esp-idf/requirements.txt (line 12)) (2.3.1)
Requirement already satisfied: pyelftools>=0.22 in /root/.espressif/python_env/idf4.4_py3.8_env/lib/python3.8/site-packages (from -r /home/dig/projecten/esp32/esp-idf/requirements.txt (line 13)) (0.27)
Requirement already satisfied: gdbgui==<IP_ADDRESS> in /root/.espressif/python_env/idf4.4_py3.8_env/lib/python3.8/site-packages (from -r /home/dig/projecten/esp32/esp-idf/requirements.txt (line 15)) (<IP_ADDRESS>)
Requirement already satisfied: pygdbmi<=<IP_ADDRESS> in /root/.espressif/python_env/idf4.4_py3.8_env/lib/python3.8/site-packages (from -r /home/dig/projecten/esp32/esp-idf/requirements.txt (line 18)) (<IP_ADDRESS>)
Requirement already satisfied: kconfiglib==13.7.1 in /root/.espressif/python_env/idf4.4_py3.8_env/lib/python3.8/site-packages (from -r /home/dig/projecten/esp32/esp-idf/requirements.txt (line 22)) (13.7.1)
Requirement already satisfied: reedsolo<=1.5.4,>=1.5.3 in /root/.espressif/python_env/idf4.4_py3.8_env/lib/python3.8/site-packages (from -r /home/dig/projecten/esp32/esp-idf/requirements.txt (line 25)) (1.5.4)
Requirement already satisfied: bitstring>=3.1.6 in /root/.espressif/python_env/idf4.4_py3.8_env/lib/python3.8/site-packages (from -r /home/dig/projecten/esp32/esp-idf/requirements.txt (line 26)) (3.1.7)
Requirement already satisfied: ecdsa>=0.16.0 in /root/.espressif/python_env/idf4.4_py3.8_env/lib/python3.8/site-packages (from -r /home/dig/projecten/esp32/esp-idf/requirements.txt (line 27)) (0.16.1)
Requirement already satisfied: construct==2.10.54 in /root/.espressif/python_env/idf4.4_py3.8_env/lib/python3.8/site-packages (from -r /home/dig/projecten/esp32/esp-idf/requirements.txt (line 31)) (2.10.54)
Requirement already satisfied: Flask<1.0,>=0.12.2 in /root/.espressif/python_env/idf4.4_py3.8_env/lib/python3.8/site-packages (from gdbgui==<IP_ADDRESS>->-r /home/dig/projecten/esp32/esp-idf/requirements.txt (line 15)) (0.12.5)
Requirement already satisfied: gevent<2.0,>=1.2.2 in /root/.espressif/python_env/idf4.4_py3.8_env/lib/python3.8/site-packages (from gdbgui==<IP_ADDRESS>->-r /home/dig/projecten/esp32/esp-idf/requirements.txt (line 15)) (1.5.0)
Requirement already satisfied: Pygments<3.0,>=2.2.0 in /root/.espressif/python_env/idf4.4_py3.8_env/lib/python3.8/site-packages (from gdbgui==<IP_ADDRESS>->-r /home/dig/projecten/esp32/esp-idf/requirements.txt (line 15)) (2.8.1)
Requirement already satisfied: Flask-Compress<2.0,>=1.4.0 in /root/.espressif/python_env/idf4.4_py3.8_env/lib/python3.8/site-packages (from gdbgui==<IP_ADDRESS>->-r /home/dig/projecten/esp32/esp-idf/requirements.txt (line 15)) (1.9.0)
Requirement already satisfied: Flask-SocketIO<3.0,>=2.9 in /root/.espressif/python_env/idf4.4_py3.8_env/lib/python3.8/site-packages (from gdbgui==<IP_ADDRESS>->-r /home/dig/projecten/esp32/esp-idf/requirements.txt (line 15)) (2.9.6)
Requirement already satisfied: cffi>=1.12 in /root/.espressif/python_env/idf4.4_py3.8_env/lib/python3.8/site-packages (from cryptography>=2.1.4->-r /home/dig/projecten/esp32/esp-idf/requirements.txt (line 11)) (1.14.5)
Requirement already satisfied: six>=1.9.0 in /root/.espressif/python_env/idf4.4_py3.8_env/lib/python3.8/site-packages (from ecdsa>=0.16.0->-r /home/dig/projecten/esp32/esp-idf/requirements.txt (line 27)) (1.15.0)
Requirement already satisfied: pycparser in /root/.espressif/python_env/idf4.4_py3.8_env/lib/python3.8/site-packages (from cffi>=1.12->cryptography>=2.1.4->-r /home/dig/projecten/esp32/esp-idf/requirements.txt (line 11)) (2.20)
Requirement already satisfied: itsdangerous>=0.21 in /root/.espressif/python_env/idf4.4_py3.8_env/lib/python3.8/site-packages (from Flask<1.0,>=0.12.2->gdbgui==<IP_ADDRESS>->-r /home/dig/projecten/esp32/esp-idf/requirements.txt (line 15)) (1.1.0)
Requirement already satisfied: Jinja2>=2.4 in /root/.espressif/python_env/idf4.4_py3.8_env/lib/python3.8/site-packages (from Flask<1.0,>=0.12.2->gdbgui==<IP_ADDRESS>->-r /home/dig/projecten/esp32/esp-idf/requirements.txt (line 15)) (2.11.3)
Requirement already satisfied: Werkzeug<1.0,>=0.7 in /root/.espressif/python_env/idf4.4_py3.8_env/lib/python3.8/site-packages (from Flask<1.0,>=0.12.2->gdbgui==<IP_ADDRESS>->-r /home/dig/projecten/esp32/esp-idf/requirements.txt (line 15)) (0.16.1)
Requirement already satisfied: brotli in /root/.espressif/python_env/idf4.4_py3.8_env/lib/python3.8/site-packages (from Flask-Compress<2.0,>=1.4.0->gdbgui==<IP_ADDRESS>->-r /home/dig/projecten/esp32/esp-idf/requirements.txt (line 15)) (1.0.9)
Requirement already satisfied: python-socketio>=1.6.1 in /root/.espressif/python_env/idf4.4_py3.8_env/lib/python3.8/site-packages (from Flask-SocketIO<3.0,>=2.9->gdbgui==<IP_ADDRESS>->-r /home/dig/projecten/esp32/esp-idf/requirements.txt (line 15)) (5.1.0)
Requirement already satisfied: greenlet>=0.4.14 in /root/.espressif/python_env/idf4.4_py3.8_env/lib/python3.8/site-packages (from gevent<2.0,>=1.2.2->gdbgui==<IP_ADDRESS>->-r /home/dig/projecten/esp32/esp-idf/requirements.txt (line 15)) (1.0.0)
Requirement already satisfied: MarkupSafe>=0.23 in /root/.espressif/python_env/idf4.4_py3.8_env/lib/python3.8/site-packages (from Jinja2>=2.4->Flask<1.0,>=0.12.2->gdbgui==<IP_ADDRESS>->-r /home/dig/projecten/esp32/esp-idf/requirements.txt (line 15)) (1.1.1)
Requirement already satisfied: bidict>=0.21.0 in /root/.espressif/python_env/idf4.4_py3.8_env/lib/python3.8/site-packages (from python-socketio>=1.6.1->Flask-SocketIO<3.0,>=2.9->gdbgui==<IP_ADDRESS>->-r /home/dig/projecten/esp32/esp-idf/requirements.txt (line 15)) (0.21.2)
Requirement already satisfied: python-engineio>=4 in /root/.espressif/python_env/idf4.4_py3.8_env/lib/python3.8/site-packages (from python-socketio>=1.6.1->Flask-SocketIO<3.0,>=2.9->gdbgui==<IP_ADDRESS>->-r /home/dig/projecten/esp32/esp-idf/requirements.txt (line 15)) (4.0.1)
All done! You can now run:
. ./export.sh
The previous idf ( form may 2020) runs ok.
Ubuntu 20.
Regards, Dig

Hi @DigKleppe. You are installing the tools into /root/.espressif/ so they cannot be found in /home/dig/.espressif for using them as non-root.
Using sudo in this case in not recommended. The install script should install the tools for the "dig" user.

Hi
Thanks for the quick answer.
If I run the install script as non root i get a permission error. The normal (old)  tools folder has normal user rights. ???
I see the tools present in the tools folder.
like /home/dig/.espressif/tools/xtensa-esp32-elf/esp-2020r3-8.4.0/
alongside the tools of the previous installation.

Could you please post the full log to see at what stage the permission error is happening?
Yes, the .espressif folder should have normal user rights. You can examine the output of ls -al and fix the directories by chmod and chown commands.
If you don't care about the content of .espressif then you can remove it and let install.sh re-create it.

Removed .espressif folder, installed tools.
Now everything is ok!
Thanks,
Dig

Thank you @DigKleppe for the feedback. I'm happy that it got resolved.
I don't think that this require any fix. Adding any removal to these scripts would be too invasive. I'm closing this issue.


BUG: fix mapping tags

Fixes #95

@rgommers @peter-urban can you check if things now work properly for you?

@FFY00 This fix resolves the issue for my project
Thanks a lot!

Cool, will just wait for @rgommers to ack and I'll merge and then make a bugfix release.

Thanks @FFY00 and @peter-urban. If it solves things for you then I'd say go ahead and merge. I cannot test this, because I can reproduce the problem only when using build isolation (which makes it impossible to use a dev version). I'll comment on the issue.

Since #111 also got merged, I am gonna do a normal release, not bugfix.

SGTM, thanks. Please ping me for re-testing once that is done.

I have released 0.8.0, which hopefully fixes all issues you were having :pray:

Yes, that fixed it, thanks 😄 🚀

I also want to confirm that 0.8.0 fixes the issue for me. Thanks :-)


Physics world - generate a unique id for ground sensors

Currently we just create a fixture and mark it as sensor. If the user decides to add custom sensors, our check should be made more specific and actually see if the sensor is a ground sensor.

Done in 0.5.2


x-axis

hi,
your program is awesome! I noticed however that the x-axis comes out empty in the .png image produced (there are no dates). I'm new at python so I'm having difficulty understanding how to fix this.. could you fix it or explain to me what to do?
Thank you so much!!

Hi，
did you know how to slove that problem?
I got a same problem like yours.

Hi!
Unfortunately no, I wasn’t able to solve it.
If you figure something out please let me know!
Regards
On Apr 11, 2020, at 6:42 AM, Karim Benzema<EMAIL_ADDRESS>wrote:

Hi，
did you know how to slove that problem?
I got a same problem like yours.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://github.com/Lewuathe/COVID19-SIR/issues/16#issuecomment-612325609, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AO7PPOL6IFAYCIGO6XOWCI3RL7YK3ANCNFSM4LWA73UA.

@theabm12
Hi!
When I run this code on Windows envirment, I got the problem.
Then I run this code on Linux envirment, there are dates in x-axis.
Maybe, there is something wrong with Windows.

@theabm12
Hi!
When I run this code on the Windows environment, I got the problem.
Then I run this code on the Linux environment, there are dates in the x-axis.
Maybe, there is something wrong with Windows.

I tried it on an apple computer and it didnt show me the dates. Tried putting a few commands to show the x-axis but it was wrong so it wasnt showing what i wanted.
On Apr 11, 2020, at 12:45 PM, Karim Benzema<EMAIL_ADDRESS>wrote:

@theabm12https://github.com/theabm12
Hi!
When I run this code on Windows envirment, I got the problem.
Then I run this code on Linux envirment, there are dates in x-axis.
Maybe, there is something wrong with Windows.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com/Lewuathe/COVID19-SIR/issues/16#issuecomment-612390907, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AO7PPOMU65TVZXMQYFPR3XLRMBC5VANCNFSM4LWA73UA.


[TC-TCTL] Automate Temperature Control Cluster Tests

The current tests in YAML are manual.  Update the tests to either use YAML or python as appropriate.

This has already been completed.


Updated the metadata as per instructions.

:warning: Validation status: warnings

File
Status
Preview URL
Details

mixed-reality-docs/spatial-sound-in-directx.md
:warning:Warning
View
Details

mixed-reality-docs/spatial-sound-in-directx.md

[Warning] Author<EMAIL_ADDRESS>cannot be recognized in GitHub.

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

mixed-reality-docs/spatial-sound-in-directx.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Add scale_factor fields to RenderTarget variants

Objective
Currently, if you set RenderTarget to anything other than a window, the render target is treated as having a hardcoded 1.0 scale factor. This means that bevy_ui will always render into that target with a 1x scale factor. My use-case is rendering into an Image which is later drawn onto a window via bevy_egui - but if the scale factor is hardcoded to 1x, UI will look too small if the window actually has a higher scale factor.
Current code:
pub fn get_render_target_info<'a>(
    &self,
    resolutions: impl IntoIterator<Item = (Entity, &'a Window)>,
    images: &Assets<Image>,
    manual_texture_views: &ManualTextureViews,
) -> Option<RenderTargetInfo> {
    match self {
        NormalizedRenderTarget::Window(window_ref) => resolutions
            .into_iter()
            .find(|(entity, _)| *entity == window_ref.entity())
            .map(|(_, window)| RenderTargetInfo {
                physical_size: window.physical_size(),
                scale_factor: window.resolution.scale_factor(),
            }),
        NormalizedRenderTarget::Image(image_handle) => {
            let image = images.get(image_handle)?;
            Some(RenderTargetInfo {
                physical_size: image.size(),
                scale_factor: 1.0, // <-- hardcoded here!
            })
        }
        NormalizedRenderTarget::TextureView(id) => {
            manual_texture_views.get(id).map(|tex| RenderTargetInfo {
                physical_size: tex.size,
                scale_factor: 1.0, // <-- hardcoded here!
            })
        }
    }
}

Solution
This PR adds scale_factor fields to RenderTarget::Image and RenderTarget::TextureView, which is fed directly into RenderTargetInfo (which is used by bevy_ui). Old uses of Image and TextureView constructors are replaced with RenderTarget::from(image) or from(texture_view_handle), which keep the old behaviour of having scale factor 1.0.
Testing
In render_ui_to_texture example, if you press the up or down arrow keys, it will change the scale factor of the RenderTarget by 0.25. Tested this example and it works.

Showcase
RenderTargets which are not Windows can now have a custom scale factor applied. Previously, if you had UI which rendered into a camera which rendered into a RenderTarget, the UI scale factor would be fixed to 1.0. Now you can explicitly specify the scale factor of the render target. This is useful for if you want to, for example, render the game itself (including UI) into an image, then draw that image onto the final window manually.
You can try out these changes in the updated render_ui_to_texture example.
Screencast From 2024-11-03 15-15-34.webm
Migration Guide
RenderTarget::Image and RenderTarget::TextureView have been turned into field enum variants, and a new field scale_factor has been added, letting you change the scale factor of the render target (previously, it was hardcoded to 1.0 unless it was a window).
If you want to keep the old behavior, either set scale_factor to 1.0 explicitly, or use RenderTarget::from(Handle<Image>) or from(ManualTextureViewHandle), which also creates a target with a scale factor of 1.0

This fix is going to be needed by the Bevy Editor: we're doing all sorts of weird viewport things.


Mutex is accidentally quadratic

Locking a Mutex concurrently from N tasks takes O(N^2) time. This test reproduces the issue. The problem is the use of Slab::iter_mut in Mutex::unlock. Slab::iter_mut takes linear time because it must scan through all the vacant entries at the beginning of the Slab. I've started one possible solution which creates a separate VecDeque of wait keys so that scanning for a valid waker takes amortized constant time.
There are a number of other possible implementations (e.g. tokio's stack-allocated linked list). Before diving too deeply into a fix, do we have any clear design constraints for this implementation (e.g. avoiding unsafe code, avoiding synchronous waiting, optimizing throughput with LIFO scheduling, or optimizing latency with FIFO scheduling)?

Thanks for finding this.

do we have any clear design constraints for this implementation (e.g. avoiding unsafe code, avoiding synchronous waiting, optimizing throughput with LIFO scheduling, or optimizing latency with FIFO scheduling)?

There are no specific constraints, but reviews of large patches and patches with a lot of unsafe things tend to be delayed.

How about replacing Slab with something like HopSlotMap? It claims to have fast iteration speed.


Fix wrong value for actornumber in settlement report dropdown

Codecov Report

Merging #1834 (6e3e018) into main (d16af9d) will increase coverage by 10.84%.
The diff coverage is 0.00%.

@@             Coverage Diff             @@
##             main    #1834       +/-   ##
===========================================
+ Coverage   15.98%   26.83%   +10.84%
===========================================
  Files          77       92       +15
  Lines        1870     2184      +314
  Branches      185        0      -185
===========================================
+ Hits          299      586      +287
- Misses       1561     1583       +22
- Partials       10       15        +5

Impacted Files
Coverage Δ

...i-dh/source/DataHub.WebApi/GraphQL/GraphQLQuery.cs
0.00% <0.00%> (ø)

... and 21 files with indirect coverage changes
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


NoSuchRequestHandlingMethodException is deprecated

Hello,
Thank you very much for this very useful lib!
At cz.jirutka.spring.exhandler.RestHandlerExceptionResolverBuilder#getDefaultHandlers there is a reference to the deprecated NoSuchRequestHandlingMethodException which will be removed with the new version of Spring.
Perhaps this class should be loaded only when it exists?

And with the release of spring 5 in the last few days this lib is incompatible with Spring5

@jirutka Please add support spring 5. In package there is import org.springframework.web.servlet.mvc.multiaction.NoSuchRequestHandlingMethodException which is not existing in spring 5


Minor tweaks/feedback

Just s/Github/GitHub/g applied, nothing else.

I should probably not have terraform run for documenation changes


negative thresholds disable alert creation for 3xx,4xx,5xx,target_res…

…ponse_time

Included changes from make readme.


jenkins-job-builder: 3.0.1 -> 3.0.2

Semi-automatic update generated by https://github.com/ryantm/nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/python2.7-jenkins-job-builder/versions.
meta.description for jenkins-job-builder is: '"Jenkins Job Builder is a system for configuring Jenkins jobs using simple YAML files stored in Git"'.
meta.homepage for jenkins-job-builder is: '"https://docs.openstack.org/infra/system-config/jjb.html"

Checks done (click to expand)

built on NixOS

Warning: a test defined in passthru.tests did not pass

0 of 0 passed binary check by having a zero exit code.

0 of 0 passed binary check by having the new version present in output.

found 3.0.2 with grep in /nix/store/glxjcxidj9lkaf484kmsq9ww67r773jd-python2.7-jenkins-job-builder-3.0.2

directory tree listing: https://gist.github.com/4aeaf9a902fa1a3a402bebf0407343a4

du listing: https://gist.github.com/31b6363350cba7e6829c18ac1bf8351e

Rebuild report (if merged into master) (click to expand)

8 total rebuild path(s)
2 package rebuild(s)
2 x86_64-linux rebuild(s)
2 i686-linux rebuild(s)
2 x86_64-darwin rebuild(s)
2 aarch64-linux rebuild(s)
First fifty rebuilds by attrpath
jenkins-job-builder
python27Packages.jenkins-job-builder

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/glxjcxidj9lkaf484kmsq9ww67r773jd-python2.7-jenkins-job-builder-3.0.2 \
  --option binary-caches 'https://cache.nixos.org/ https://r-ryantm.cachix.org/' \
  --option trusted-public-keys '
  r-ryantm.cachix.org-1:gkUbLkouDAyvBdpBX0JOdIiD2/DP1ldF3Z3Y6Gqcc4c=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(r-ryantm's Cachix cache is only trusted for this store-path realization.)
Or, build yourself:
nix-build -A jenkins-job-builder https://github.com/r-ryantm/nixpkgs/archive/9dd7a656bd1cd2089b549dc2d262bcf76b8f360e.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/glxjcxidj9lkaf484kmsq9ww67r773jd-python2.7-jenkins-job-builder-3.0.2
ls -la /nix/store/glxjcxidj9lkaf484kmsq9ww67r773jd-python2.7-jenkins-job-builder-3.0.2/bin

should be closed in favor of #70057, leaving open so ofborg doesn't attempt to rebuild


Issue #2730: Update Methods list [FIX]

Have updated the completed features, preprocesssors, kernels, distance measures and methods based on the implementations found under respective directories in src/shogun instead of only the examples folder. Hope that is alright as it seemed to contain a more complete list than that in examples.

Changes Unknown when pulling f45fb99afad3ff94a775db41bd2c174178abcfbd on adit-39:develop into ** on shogun-toolbox:develop**.

Nice job, @adit-39. Good decision to check the directories instead of the examples. Since you are on it, it would be also nice if you detect the classes that are missing unit tests and/or api examples. Those should be implemented so we can, for instance, start creating entrance issues for them.

@iglesias sure, will get down to it! :)

@iglesias do you want separate lists of those without unit tests, those without examples and those without both?

A GitHub issue sounds reasonable to me. In the issue, you can have two separate lists: one with the missing unit tests, another one with the missing examples.
As they start gradually getting done, we can update those lists. Also, the PRs addressing missing unit tests and/or examples should reference the issue.


Apiview 1.13

Changes to correct issues raised in the v2 AML SDK 1.13.0 apiview review.

API change check
API changes are not detected in this pull request.


Connect to Endpoint

Hi, Im trying to connect to an Endpoint and retrieve a stream with SparqlClient from sparql-http-client. If I connect to http://dbpedia.org/sparql as example everything seems to work. By changing the URL to another Endpoint, I get the error message "Unexpected "!" at position 2 in state STOP". I see that there are different options when creating the SparqlClient and I found some examples, but I cant find any documentation on it. Do you have any reference? Thank you a lot!

Can you provide your example which does not work?

Regarding docs, have you checked https://zazuko.github.io/sparql-http-client/? There is also a DT package @types/sparql-http-client

Maybe helpful
https://github.com/zazuko/sparql-http-client/issues/40

Closed because of inactivity.


fix: use noengine in ci

Description

We should use the --noengine option for Prisma client generation in CI

:tada: This PR is included in version 1.13.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Hard-coded purple color. Maybe a CSS variable instead?

Currently, the sidebar and many other UI components use a hard-coded purple color as their background. This color doesn't work well with a variety of different color schemes. If you want to use something else besides purple, you have to manually override every CSS class that uses said hard-coded color.
I propose creating a new CSS variable, so this process of overriding would be less pain-inducing.

Here's some examples:

Let's override Wagtail's color variables with some user-defined colors.
:root {
    --color-primary: #b71234;
    --color-primary-darker: #980f2a;
    --color-primary-dark: #980f2a;
    --color-primary-lighter: azure;
    --color-primary-light: aliceblue;
    --color-input-focus: #fff4e9;
    --color-input-focus-border: #e6e6e6;
    --color-button-hover: white;
    --color-button-hover-border: #b71234;
}

The end result is this:

That looks quite... hideous.

I'd like to push to get this into 3.0 final if possible - the purpose of introducing CSS variables was to allow overriding the primary colour scheme, and if Wagtail 3 has effectively introduced the purple/indigo as a new primary colour, not having a CSS variable for it seems like an oversight.

This strikes me as a change that would require some consensus before we proceed, so ideally deferred to Wagtail 4.0 or beyond. Our CSS variables setup for colors wasn’t satisfactory even before this change of sidebar color, and it’d be nice for us to have proper time to consider naming (right now we’re using a mixture of brand, descriptive, and semantic names, which feels confusing).
@havardox the specific example you shared is already looking jarring with the default color on the header, so I don’t think another CSS variable would be the correct solution to this either.

This strikes me as a change that would require some consensus before we proceed

I disagree. The ability to customise colour schemes was an advertised feature of Wagtail 2.12. Adding a new non-customisable colour means that it's no longer possible to do that satisfactorily, so it's a regression from previous behaviour - fixing it shouldn't be a contentious decision.
I don't know the background to why the CSS variables setup is considered unsatisfactory, but nevertheless it's a convention that we introduced, and we should continue following it until we have something better - if anything, the decision to not do that is the one should have received consensus before going ahead.

What we introduced in Wagtail 2.12 is the customisation of the primary teal only, all the other colors with CSS variables are meant to be hues derived from it. We’ve had all other colors in the CMS hard-coded so far, and in particular the color scheme of the sidebar has always been specific to the sidebar, and hard-coded.

iI don't know the background to why the CSS variables setup is considered unsatisfactory, but nevertheless it's a convention that we introduced, and we should continue following it until we have something better - if anything, the decision to not do that is the one should have received consensus before going ahead.

We’ve discussed this multiple times in UI team meetings over the last 3 months, I recall in particular:

As a part of the GSoC Windows High Contrast Mode project since that would likely be much simpler to roll out with CSS variables.
More recently as a follow-up to work currently under way to make our fonts available as CSS variables (#8406)

We seemed to have consensus then that when we revisit this it’d be better to roll this out for all other colors at once.

Back to this one color, what we had discussed as needing further validation was:

Whether our usage of design tokens for colors should be based on semantic names or descriptive ones
Whether we use our w- or another prefix for CSS variables
(I have a vague recollection we also wondered whether we should have "immutable" variables for people to reuse Wagtail’s colors as-is, and in addition variables intended to customise the UI)

Someone additionally raised the need for us to be careful with this so we don’t start creating backwards compatibility issues for ourselves as we introduce more variables.
I’d be happy for us to pick all of this up sooner than Wagtail 4.0 but again in my opinion this isn’t a regression to deal with during a release candidate, it needs some agreement on the above points.

First draft from @stevedya: #8457
This needs further tweaking and I think we could use more feedback from people interested in this on which of the following we’d go for:

Switching the existing single color customisation to target indigo rather than teal
Introducing another single color customisation for indigo (and its accent), in addition to what we’re doing with teal (kept as-is)
Introducing a way to change the colors of the sidebar only, keeping the teal color customisation as-is
Make all our colors customisable and leave it up to people to make their pick of which ones to customise

And additionally – do we want to do the same as what we’ve done with the primary teal, where you can set only a single color and all of the lighter/darker tones are automatically derived from it – or leave it up to people to make sure they determine and configure the appropriate lighter and darker hues as well as the main hue of a given color?
@havardox what do you think? @wagtail/ui does anyone have comments about this? We had discussed option 2. for Wagtail 3.0, but now that we’re targeting 4.0 we could go for something more disruptive.

Django CSS custom properties/ dark mode support for reference.
https://docs.djangoproject.com/en/dev/ref/contrib/admin/#admin-theming

For anyone needing this for Wagtail 3.0 – here is a repository describing a workaround for this release: https://github.com/thibaudcolas/wagtail_color_overrides. Screenshot with a blue theme:

We’re still planning to have similar capabilities in Wagtail 4 so this should be a one-off workaround for 3.0.

For people following this – the UI team discussed this again yesterday and came to the following resolutions:

We’ll make all of our colors customisable and leave it up to people to make their pick of which ones to customise
We’ll keep the existing setup for color-primary, where it’s possible to only set one hue variable, or three HSL component variables, and have other accent / lighter / darker colors generated from this.

This will mean on the order of 80 to 100 CSS variables, so we’ll need to think a bit carefully of how to structure and document this.

We’re likely to be replacing quite a few "legacy" colors very soon as part of a rework of the page editor’s forms styles, I think this might get easier to implement afterwards so I’d recommend waiting before we move to implementation.


Remove sig checks for CreateOperation and update protocol doc accordingly.

It is decided that create operation still requires signature validation.


Bash version at prompt

I kinda like that:
https://asciinema.org/

This seems silly now; one can easily just run bash --version. Closing.


fix: fix typing for wrapped async methods

WIP, the bulk of the change is there, will update PR description to help review

coverage: 68.025% (+0.008%) from 68.017%
when pulling 835557c093242e73db859b4147b3452b58b30bc9 on massi/refact-typing
into 1ee388ba032aee89cdb19f662bf4aad87ebf855d on main.


undefined method `size' for nil:NilClass (NoMethodError) when installing

I tried to install thread_safe version 0.3.5, but i got below error:
ERROR:  Error installing thread_safe:
	invalid gem: package is corrupt, exception while verifying: undefined method `size' for nil:NilClass (NoMethodError) in /home/vagrant/.rbenv/versions/2.2.1/lib/ruby/gems/2.2.0/cache/thread_safe-0.3.5.gem

ruby version:
ruby 2.2.1p85 (2015-02-26 revision 49769) [x86_64-linux]
gem version:
2.4.5

Hi, I've just tried install the gem on the same versions (but os x) and all seems to work. Could you try to delete the cached .gem file and reinstall again to eliminate possibility of corrupted files?

@pitr-ch Hi, Thanks for checking, I deleted cached .gem and tried again,  still got above error. but it works if i downgrade to 0.3.4

@lenage could you post here a backtrace of the error? gem install --backtrace could help.

@pitr-ch
vagrant@vagrant-ubuntu-trusty-64:~$ gem install thread_safe -v "0.3.5" --backtrace
ERROR:  Error installing thread_safe:
	invalid gem: package is corrupt, exception while verifying: undefined method `size' for nil:NilClass (NoMethodError) in /home/vagrant/.rbenv/versions/2.2.1/lib/ruby/gems/2.2.0/cache/thread_safe-0.3.5.gem

Here are some informations:
$ uname -a
Linux vagrant-ubuntu-trusty-64 3.13.0-45-generic #74-Ubuntu SMP Tue Jan 13 19:36:28 UTC 2015 x86_64 x86_64 x86_64 GNU/Linux

$ cat /etc/lsb-release
DISTRIB_ID=Ubuntu
DISTRIB_RELEASE=14.04
DISTRIB_CODENAME=trusty
DISTRIB_DESCRIPTION="Ubuntu 14.04.1 LTS"

$ env
XDG_SESSION_ID=5
TERM=xterm-256color
SHELL=/bin/bash
SSH_CLIENT=<IP_ADDRESS> 54044 22
SSH_TTY=/dev/pts/0
USER=vagrant
SSH_AUTH_SOCK=/tmp/ssh-ae4n9pMdHB/agent.20161
MAIL=/var/mail/vagrant
PATH=/home/vagrant/.rbenv/shims:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/usr/games:/usr/local/games
PWD=/home/vagrant
LANG=en_US.UTF-8
SHLVL=1
HOME=/home/vagrant
LOGNAME=vagrant
SSH_CONNECTION=<IP_ADDRESS> 54044 <IP_ADDRESS> 22
LC_CTYPE=en_US.UTF-8
XDG_RUNTIME_DIR=/run/user/1000
_=/usr/bin/env
vagrant@vagran

@lenage Thank you for the detailed info! This is the first problem that's been reported so we'll look into this ASAP. I see that you are using Vagrant. :+1: I use Vagrant extensively at work and to build the concurrent-ruby gem. I'll setup a VM like yours to troubleshoot the error you are experiencing.

@lenage Are you using RVM or another Ruby version manager?

@lenage Thus far I have been unable to reproduce the error. I've setup an Ubuntu VM using vagrant. The version of Linux I used is:
vagrant@vagrant-ubuntu-trusty-64:~/ruby-2.2.1$ lsb_release -a
No LSB modules are available.
Distributor ID:	Ubuntu
Description:	Ubuntu 14.04.2 LTS
Release:	14.04
Codename:	trusty

I installed MRI ruby 2.2.1p85 (2015-02-26 revision 49769) [x86_64-linux] from source and was able to successfully install thread_safe using sudo gem install thread_safe -v "0.3.5" --backtrace. I also installed RVM rvm 1.26.11 (latest) and installed MRI ruby 2.2.1p85 (2015-02-26 revision 49769) [x86_64-linux] under RVM. I was able to successfully install thread_safe using gem install thread_safe -v "0.3.5" --backtrace under that as well.
Can you please download the thread_safe-0.3.5.gem gem package directly from the GitHub release page and try to install it? As @pitr-ch suggested, you may have a corrupt file in your gem cache.

@jdantonio Yes, i'm using rbenv 0.4.0.
Thanks for the help, I downloaded the gem file in release page and it installed successfully.
gem i thread_safe-0.3.5.gem
Successfully installed thread_safe-0.3.5
Parsing documentation for thread_safe-0.3.5
Installing ri documentation for thread_safe-0.3.5
Done installing documentation for thread_safe after 0 seconds
1 gem installed

@lenage I just tried again with rbenv and was able to successfully install thread_safe, so I definitely think your cached gem package was corrupt. Let us know if you have any other problems.


[AAE-11861] add 'Create preview' feature

When a PR is created with preview label, the build creates and publishes maven versions and docker images for the project with a snapshot tag 0.0.1-${GITHUB_PR_NUMBER}-${GITHUB_RUN_NUMBER}-SNAPSHOT. Tested e.g. on https://github.com/Alfresco/alfresco-deployment-service/pull/996

I'm ok with the changes, it's a nice improvement! Please update the README file to advertize this feature.
I do have concerns about the cleanup on the maven and docker artifacts: maybe some refinement could be helpful here to help with cleanup (at least on docker images, adding dedicated labels, for instance).
Also, see my suggestion about making it possible to override the PR label in case caller repositories want to use something other than "Create preview" (or just "preview" if you're ok with it)

@atchertchian thank you. I added a section in README.
About the cleanup, I think it could be done by filtering out the tags with the pattern 0.0.1-$GITHUB_PR_NUMBER-$GITHUB_RUN_NUMBER-SNAPSHOT. Adding a second tag to a docker image would mean changing all the build-and-push-docker-images.sh files in the target repositories to allow an additional tag (or multiple tags). The maven artifacts could be cleaned up the same way I suppose.


gulp

what is the point of having gulp when you could just use the webpack cli?

@nelix good point. Thanks.