My API is not displaying all the versions.

Is there an existing issue for this?

[X] I have searched the existing issues

Describe the bug
In my project, I'm specifying two versions for the CountriesController controller.
I have two classes within the same namespace, one is CountriesV2Controller [ApiVersion("2.0")] and the other is CountriesController [ApiVersion("1.0")]. Both versions have the same route [Route("api/v{version:apiVersion}/countries")], so I don't understand why I have this problem.
But only version 1 is being displayed and accessible.
When I was using Microsoft.AspNetCore.Mvc.Versioning, everything worked fine, without any issues with my current configuration.
Any help is appreciated :)
Expected Behavior
I should be able to access both versions of the controller.
api-supported-versions: 1.0 , 2.0
Steps To Reproduce
No response
Exceptions (if any)
No response
.NET Version
net7.0
Anything else?
Asp.Versioning.Mvc" Version ->7.1.1
Asp.Versioning.Mvc.ApiExplorer ->Version=7.1.0
repo: https://github.com/GProGamer/HotelListing

On the line:
https://github.com/GProGamer/HotelListing/blob/master/HotelListing.API/Program.cs#L52
you need to add .AddMvc(). Starting in API Versioning 6.0, this call is now required to bring in MVC Core. Without this call, only Minimal APIs are considered. The fact that anything works at all is a coincidence. I suspect after you add that, things will work as expected.

Note: this calls IApiVersioningBuilder.AddMvc and not IServiceCollectionBuilder.AddMvc, which does something different

I've forgot to say that I've already try to add .AddMvc(). I've tried again but I still get the same weird behaviour:
it just show version 1

but not version 2:

I browsed over the repro a little too fast. There's actually a number of things missing from your configuration that should be there. This information is provided in the wiki and example projects with OpenAPI and Swashbuckle. Ultimately, you need to use the API Explorer extensions provided by API Versioning to drive the generation of OpenAPI documents with Swashbuckle. There is no formal concept of versioning in the API Explorer, so Swashbuckle does not know how to use the information without a little help.
Since you provided a repro, you can apply the following Git patch and you should be only your way.
fix-config.patch

Hi Chris.
It works, I really appreciated it, thank you


Release 0.10.2

Codecov Report

Merging #1520 (5c5b19a) into release-0.10 (c0235ad) will decrease coverage by 13.13%.
The diff coverage is 31.39%.

@@                Coverage Diff                @@
##           release-0.10    #1520       +/-   ##
=================================================
- Coverage         54.47%   41.34%   -13.14%
=================================================
  Files               119       92       -27
  Lines             11240    10711      -529
=================================================
- Hits               6123     4428     -1695
- Misses             4526     5895     +1369
+ Partials            591      388      -203

Flag
Coverage Δ

integration-tests
?

unit-tests
41.34% <31.39%> (-0.86%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

cmd/antrea-agent/agent.go
0.00% <0.00%> (ø)

cmd/antrea-agent/options.go
22.33% <0.00%> (ø)

cmd/antrea-agent/options_linux.go
0.00% <0.00%> (ø)

pkg/agent/agent.go
13.27% <0.00%> (-0.76%)
:arrow_down:

pkg/agent/openflow/client.go
9.31% <0.00%> (-23.54%)
:arrow_down:

pkg/agent/openflow/packetin.go
0.00% <0.00%> (ø)

pkg/agent/util/iptables/iptables.go
0.00% <0.00%> (-6.25%)
:arrow_down:

pkg/agent/util/iptables/lock.go
81.81% <ø> (ø)

pkg/controller/traceflow/controller.go
62.58% <ø> (ø)

pkg/ovs/openflow/ofctrl_action.go
17.07% <0.00%> (-66.69%)
:arrow_down:

... and 77 more

/test-all

/test-whole-conformance

Waiting for https://github.com/vmware-tanzu/antrea/pull/1526. Will merge after I pick it up and tests have passed.

/test-all

/test-whole-conformance

/test-windows-conformance
/test-windows-networkpolicy

/test-windows-conformance

/test-windows-conformance

/test-windows-conformance

/test-all

/test-whole-conformance

/test-windows-conformance


Git config shared between host and box

As a developper, I commonly work inside the box for many development tasks that doesn't only rely on the file system. So very often, as I'm already into the box, when I use git too, but unfortunately I don't have my git config there. So I have to go outside to be able to use my preferred aliases and my identify.
Can we find a way to shared all or a part of the git config with the box?
One solution I see is to copy the user .gitconfig into the box user home. But maybe we can find something more elegant and propose that as a nice drifter feature?

We already set e-mail and username based on the host : https://github.com/liip/drifter/blob/master/provisioning/roles/base/tasks/main.yml#L74
Copying the file might be an idea, but in the long run they could differ so it would probably lead to confusion (same with the username / email BTW).
From the documentation :

FILES
If not set explicitly with --file, there are four files where git config will search for configuration options:

   $(prefix)/etc/gitconfig
       System-wide configuration file.

   $XDG_CONFIG_HOME/git/config
       Second user-specific configuration file. If $XDG_CONFIG_HOME is not set or empty, $HOME/.config/git/config will be used. Any single-valued variable set in this file will be overwritten by whatever is in ~/.gitconfig. It is
       a good idea not to create this file if you sometimes use older versions of Git, as support for this file was added fairly recently.

   ~/.gitconfig
       User-specific configuration file. Also called "global" configuration file.

   $GIT_DIR/config
       Repository specific configuration file.

Do not forget the "issue" when using ansible_local : #87

This is not an opt-in in the latest yet to be released version.


Fine grained configuration and user notice

Is it any plans to add more fine grained configuration to this project, like series to never delete, if someone started to watch the show, if any tags are set, send message to the user that the show is set for deletion and he can halt it if he wants to keep it for another x days.

Currently the project doesn't have any additional plans for, well, anything really. I consider the project done for what I required personally, and therefore don't really feel like I want to spend the time to develop it further (though I will try to maintain it to work with the latest version of the required software).


Add option to configure the deadline of getSystemInfo

Add option to configure the deadline of getSystemInfo like the Go SDK has
closes https://github.com/temporalio/sdk-java/issues/2132

What was the issue reusing the health check timeout here?

What was the issue reusing the health check timeout here?

Yes the health check timeout is deprecated and it wasn't even using the timeout it was using the attempt timeout


MaterialX cleanup: ramp4, texture mapping

Fix definition of ramp4 top vs bottom.   In recent times, it's been decided that "top" always refers to v=1 and  "bottom" refers to v=0.

Various clean ups to texture mapping nodes:

image node: wasn't honoring addressmode or filtertype params.

Fixes to triplanarprojection: wasn't properly normalizing by the      combined weight of the three views, wasn't honoring filtertype param,      wasn't forcing periodic wrap.

Implement the new "tiledimage" node.

Amended: extend add/sub/mul/div to include matrices per 1.36 spec


fix(mermaid): try to fix Mermaid integration after 9.2 release

Upgrading for 9.1.7 to 9.2 makes the Mermaid theme compilation fails
Unfortunately users are upgraded automatically due to using the semver range ^9.1, and it also fails at runtime for these users that should force v9.1.7 (last version that works)
See:

https://github.com/facebook/docusaurus/issues/8274
https://github.com/mermaid-js/mermaid/issues/3747

Current PR is a draft, still unsolved 😅

Probably unrelated to the issue (according to my local tests) but the theme/client Mermaid apis were not compiled with the correct TS options (ie outputs CJS instead of ESM), so I'm also fixing that here.

Hi,
A temporary workaround : using Yarn, adding resolutions in package.json makes it work :
,   "resolutions": {     "mermaid": "9.1.7"   },
Thanks @Josh-Cena and @homotechsual on #help-and-questions ;)

The issue has been fixed in Mermaid 9.2.2 and everything seems to work fine again now
Had to change a bit the types to make it work again because new official types are not exactly the same as the DefinitivelyTyped ones


“nullable” reference objects are not correctly generated.

The issue is that when I have a type like this:
const personSchema = z.object({
   firstname: z.string(),
   lastname: z.string()
});

const houseSchema = object({
   address: z.string(),
   owner: personSchema.nullable().optional()
});

When the open API spec is generated the owner field is generated like:
"owner": {
  "oneOf": [
    {
      "$ref": "#/components/schemas/Person"
    },
    {
      "nullable": true
    }
  ]
},

But it is incorrect, as when the client uses the spect to generate the typescript code, the owner field is not well recognized. The correct output should be:
"owner": {
  "oneOf": [
    {
      "$ref": "#/components/schemas/Person"
    },
  ],
  "nullable": true
},

Ah nice one.
TIL: https://github.com/OAI/OpenAPI-Specification/issues/1368
I'll raise a PR sometime todayish

Great, thank you so much,
FYI: in my case, this format I've shown you works perfectly using "anyOf", "oneOf" and "allOf". Check this screenshot of the swagger editor using "anyOf":


[Monsterhearts 2] 10 new class options!

Changes / Comments
10 shiny new character classes (Skins) to choose from! These Skins include: Bakeneko, Bedlam, Devil, Dragon, Fomorian, Immortal, Leshy, Prometheus, Siren, and Veela. All playtested, found here.

HTML edited with all details for the new Skins' backstory, moves, etc.
CSS edited to include the new sheets in the selection dropdown menu.
translation.json edited to open the new sheets to future translations.

There's still a matter of some weird double text appearing on some of the sheets, that I can't for the life of me determine the cause of or solution to. I'm really hoping it might just sort itself out with the sheer amount of changes being pushed with this update. If not, well, I guess I'll just have to take another stab at it later.
Roll20 Requests
Comments are very helpful for reviewing the code changes. Please answer the relevant questions below in your comment.

[x] Does the pull request title have the sheet name(s)? Include each sheet name.
[ ] Is this a bug fix?
[x] Does this add functional enhancements (new features or extending existing features) ?
[ ] Does this add or change functional aesthetics (such as layout or color scheme) ?
[ ] If changing or removing attributes, what steps have you taken, if any, to preserve player data ?
[ ] If this is a new sheet, did you follow Building Character Sheets standards ?

If you do not know English. Please leave a comment in your native language.

Character Sheet Info Roll20 Internal Use only.


opensslconf.h and opensslv.h include each other

The subject line says it all.  These two files should be untangled somehow.  One option, probably the simplest (I spent a bit of time trying to do it and failed) is to merge opensslv.h into opensslconf.h.in and make the first one just be a one-liner that includes the second one.

Hmmm, how about something less disruptive?  We could move all the API compat stuff to opensslv.h, that way it won't need to include opensslconf.h

I couldn't make that work, but you're smarter than I, so go for it :)
On the other rand, right now each file includes the other, so the simpler change won't break user-code that depends on that.

I've a question: have you observed an actual issue, such as compilation going berzerk, dependency errors or something like that?  I.e., pragmatically speaking, is there anything more concrete than your own sense of what's right and beautiful?
I'm asking 'cause this can be observed:
opensslv.h:
#ifndef HEADER_OPENSSLV_H
# define HEADER_OPENSSLV_H

...

# include <openssl/opensslconf.h>

...

#endif                          /* HEADER_OPENSSLV_H */

opensslconf.h:
#include <openssl/opensslv.h>

#ifndef HEADER_OPENSSLCONF_H
# define HEADER_OPENSSLCONF_H

...

#endif                          /* HEADER_OPENSSLCONF_H */

In other words, at least one of the includes is done under the protection of guards, and that prevents inclusion loops.  Can you see a scenario where that prevension is circumvented?

Scenario 1:

someone includes opensslv.h
opensslv.h defines HEADER_OPENSSLV_H
opensslv.h includes opensslconf.h

opensslconf.h includes opensslv.h, whose contents are ignored because of HEADER_OPENSSLV_H
opensslconf.h defines HEADER_OPENSSLCONF_H
opensslconf.h finishes

opensslv.h finishes

Scenario 2:

someone includes opensslconf.h
opensslconf.h includes opensslv.h

opensslv.h defines HEADER_OPENSSLV_H
opensslv.h includes opensslconf.h

opensslconf.h includes opensslv.h, whose contents are ignored because of HEADER_OPENSSLV_H
opensslconf.h defines HEADER_OPENSSLCONF_H
opensslconf.h finishes

opensslv.h finishes

opensslconf.h is skipped over because the earlier inclusion by opensslv.h defined HEADER_OPENSSLCONF_H

So yeah, there are a couple of levels of inclusion, but nothing that makes it loop endlessly.
Worth fixing, or shall we invoke the "it works, don't fix it!" mantra?

Worth fixing, or shall we invoke the "it works, don't fix it!" mantra?

Feel free to close the issue if you don't want to address it.
I found it trying to add a guard to the other header file.  It "stuck out" that there was no guard there, and then I fell down the rabbit-hole trying to fix it.

I found it trying to add a guard to the other header file

Uhmmmm, which "other header file" are you referring to?

Oh never mind.  I was hopelessly lost.  Just close this darn thing if you don't care.

Yeah, I think I'll do so.  "It works, don't fix it!" is a good mantra at times.
Of course, if we do find a concrete case where it doesn't work, it will be time to revisit the issue.

Hmmm, how about something less disruptive? We could move all the API compat stuff to opensslv.h, that way it won't need to include opensslconf.h

@richsalz was right, it i causing problems.  And @levitte's first reaction would have bee the appropriate solution.
Fix is now in #9623.


python311Packages.boto3-stubs: 1.34.62 -> 1.34.64

Description of changes

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Result of nixpkgs-review pr 296245 run on x86_64-linux 1

10 packages built:

aws-sam-cli
aws-sam-cli.dist
python311Packages.boto3-stubs
python311Packages.boto3-stubs.dist
python311Packages.dsnap
python311Packages.dsnap.dist
python312Packages.boto3-stubs
python312Packages.boto3-stubs.dist
python312Packages.dsnap
python312Packages.dsnap.dist

@ofborg eval


(fix) Remove collections from features

If you're doing a fixup, can you also remove this from the example and Show => Debug?

@reem yes, I have just seen it

Updated

Amazing.


Review dotnet remove reference documentation

https://docs.microsoft.com/en-us/dotnet/core/tools/dotnet-remove-reference

@marcpopMSFT Do you have an ETA on when this article review will be completed?

@tdykstra actually finished it when we did the doc pass last month. I'll close it out.


Mesa updates! 10.2.9 -> 10.4.4

OK, this probably requires some testing. Works for me so far though.
@vcunat Please review. Some stuff you added I had to remove and I could never figured out why it was there in the first place. I hope you can help me verify I didn't just break ALL THE THINGS ;-).

Travis timed out as usual ...

@vcunat The argument being made in the mesa commit is that egl drivers are mesa exclusive and should be used anywhere else if I'm reading it right. What's the point of taking them out?
BTW, it seems like a large part of the problem came from mesa expecting to be told about LLVM being built without (C++) RTTI through llvm-config --cxxflags by it containing --fno-rtti which was NOT the case.

The drivers are split into another output because of heavy dependencies (mainly LLVM). They aren't needed for most stuff linking against libGL, which is the main use for mesa during builds. Therefore, the drivers even aren't present in $(libdir).
Moreover, we separate the driver choice to NixOS, so we use the impure /run/opengl-driver* links.

Maybe this is my lack of understanding speaking but when I run find /nix/store/*mesa-noglu-10.2.9* -name '*egl*' none of the results are in -drivers/. Same from the other prespective:
libEGL.so -> /nix/store/m1pbnsg9iw0jhb4z0smjsmqvjds3kzlr-mesa-noglu-10.2.9/lib/libEGL.so in /run/opengl-driver/.
What am I supposed to see?

Ah, I'm sorry, it got moved to the main output. Still, the main point is that e.g. my main system is using a different libEGL (provided by nvidia). Therefore the EGL search patch shouldn't be hardcoded under $(libdir) but under ${driverLink}.

Just so I'm getting this right, the point is for mesa to find EGL libraries/drivers under ${driverLink} while the location of mesa's EGL stuff does not need to be modified?

So if I'm reading the mesa code right, the constant is used only once, in src/egl/main/egldriver.c, within _eglGetSearchPath(). It is a constant additional path added to the basename of EGL_DRIVER and EGL_DRIVERS_PATH environment variables. Shouldn't we be using those instead of making unsupported changes to the build system? Also, scons sets the initial path to "" (empty string) instead of of .$(libdir)/egl.

I agree that patching the file is a good and easy solution.

Now I'm running this and some other mass-rebuild changes; it seems good. I expect to polish it and push to staging tomorrow.

Is there an upstream bug open for those check errors? (So that I get some notification when we might try checks again.)

I squashed the mesa updates, including a .5 bump (only tested it builds); and leaving the authorship with you, as it was mostly your work.
It's in staging now, included with some other mass-rebuild changes. My whole system built and runs fine (including KDE4, some Xfce and GNOME3 components), so I expect no further larger problems. I tested nouveau and nvidia to cover both mesa and non-mesa drivers.

Thank you

Thanks @vcunat for fixing this up!
As for the check, I couldn't find the thread :-/. The problem it comes down is that all tests pass but src/glsl/tests/lower_jumps/create_test_cases.py pass. The type of error seemed to be tool related from what I remember. I'll keep watch on this and see how to fix it once I find some time.

I've found through years of nixpkgs work that it doesn't pay off investing much energy into fixing package tests. In most cases I get no reasonable reaction from upstream (I don't count pointless requests for reproducing against latest master as reasonable). Mesa's probably above average in this, but still...


How to set thumbnail and title on background mode

How to set thumbnail and title on background mode

https://github.com/react-native-video/react-native-video/issues/2938#issuecomment-1387182324
According to this discussion, I suggest you to try react-native-music-control or react-native-track-player

Thank you @vargajacint. I think we should follow up in linked ticket

@Odkhuu17 just pass them in the source with metadata
Here's an example
<Video source={{uri:#URL, metadata:{title:#TITLE, imageUri:#thumbnailURL} }} />


Error using react-native-svg with Parcel

Bug
I am encountering an issue when trying to use the react-native-web library with Parcel. The specific error I am receiving is:
@parcel/core: Failed to resolve 'react-native/Libraries/Utilities/codegenNativeComponent' from
'./node_modules/react-native-svg/lib/module/fabric/RectNativeComponent.js'

This issue arises when attempting to integrate react-native-svg in a project that uses react-native-web with expo and Parcel as the bundler for a chrome extension. I have not found solutions in existing documentation or forums.
If anyone has experience or additional insights on setting up react-native-svg with Parcel, I would greatly appreciate your guidance or suggestions. Thank you!

Hey @mikelgarciaurbina, how did you manage to resolve this?


Modified homepage

Changes proposed in this pull request:

Modified the home component to make its UI similar to current EvalAI UI.

Link to live demo: http://pr-140-evalai.surge.sh

@sanketbansal Could you see why the tests are failing?

Working on it

Codecov Report

Merging #140 into master will increase coverage by 0.34%.
The diff coverage is 66.3%.

@@            Coverage Diff            @@
##           master    #140      +/-   ##
=========================================
+ Coverage   53.35%   53.7%   +0.34%
=========================================
  Files          55      55
  Lines        2356    2432      +76
  Branches      253     256       +3
=========================================
+ Hits         1257    1306      +49
- Misses       1026    1048      +22
- Partials       73      78       +5

Impacted Files
Coverage Δ

...onents/home/twitter-feed/twitter-feed.component.ts
100% <ø> (ø)
:arrow_up:

src/app/components/nav/footer/footer.component.ts
62.5% <100%> (+1.2%)
:arrow_up:

src/app/services/endpoints.service.ts
67.18% <100%> (+1.05%)
:arrow_up:

...nents/nav/header-static/header-static.component.ts
71.21% <57.14%> (-2.93%)
:arrow_down:

src/app/services/auth.service.ts
36.75% <57.14%> (+13.46%)
:arrow_up:

src/app/components/home/home.component.ts
85.18% <84.61%> (-14.82%)
:arrow_down:

src/app/services/window.service.ts
70.96% <0%> (-3.23%)
:arrow_down:

Impacted Files
Coverage Δ

...onents/home/twitter-feed/twitter-feed.component.ts
100% <ø> (ø)
:arrow_up:

src/app/components/nav/footer/footer.component.ts
62.5% <100%> (+1.2%)
:arrow_up:

src/app/services/endpoints.service.ts
67.18% <100%> (+1.05%)
:arrow_up:

...nents/nav/header-static/header-static.component.ts
71.21% <57.14%> (-2.93%)
:arrow_down:

src/app/services/auth.service.ts
36.75% <57.14%> (+13.46%)
:arrow_up:

src/app/components/home/home.component.ts
85.18% <84.61%> (-14.82%)
:arrow_down:

src/app/services/window.service.ts
70.96% <0%> (-3.23%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a5c7cae...eab5037. Read the comment docs.

@sanketbansal again 137 file changes! Are all of them for this PR only?

@lunayach No! it includes file changes of static styles and assets for which I have created a separate PR #154, #156, #157.
Please review those PRs first then I will rebase it.

@sanketbansal Yes, I have already reviewed #154. Please see.

@RishabhJain2018 @lunayach @Shekharrajak @galipremsagar please review

205 file changes! Need to review/merge #154, I guess.

@lunayach file changes has been reduced please review

@sanketbansal  I see, that it still has styles-port folder?

Yeah I just kept it to show you the new base styles which needs to be add for the whole project as discussed. I will remove it after your review.

After resolving #141, @sanketbansal resolve conflicts here.

@sanketbansal large no. of conflicts are for this one; please resolve them.


Selecting database is not working

I am trying to select a database before running my codes but none of the databases are coming up. The only message I am getting is "Loading..." and nothing loads. How can I resolve this issue so I can complete my school work?
Version: 1.92.0
Commit: b1c0a14de1414fcdaa400695b4db1c0799bc3124
User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/<IP_ADDRESS> Safari/537.36
Embedder: codespaces

/question please use your course support channel.


Enhancement: Script Automatically Launches Chatbot for New Case

What features would you like to see added?
Discovery
Problem Definition
Currently, the LibreChat open-source chatbot lives in an EC2 instance that must be manually launched. Users have no access to AWS backend or ability to launch instances. Furthermore, instances are not assigned to a particular user with access to a particular OpenAI API Assistant.
Motivations:
User should have EC2 instances assigned for a particular userID_caseID combination with the .yaml and .env files updated to reflect the Assistant thread they are accessing.
Proposed Solution
Write a Python Lambda that: 1. creates an EC2 for a particular userID_caseID combination, 2. updates the librechat.yaml and .env files to reflect the Assistant thread assigned to that userID_caseID combination, 3. Assigns that EC2 to the userID_caseID, 4. launches it each time the user accesses the case, 5. shuts the EC2 down after 10 minutes of inactivity.
It should also trigger the EC2 to run if it already exists. If it does not exist, then it creates it.
Definition of Done
When users create a case or access a case, they have access to a chatbot that uses that particular Assistant thread and has access to case data.
More details
features/manage_chatbot_instances.feature
Feature: Manage LibreChat EC2 Instances
As a user
I want EC2 instances to be assigned for my userID_caseID combination
So that I can access a chatbot with the specific Assistant thread and case data
Background:
Given the Python Lambda function is deployed to manage EC2 instances for LibreChat
Scenario: Create and configure EC2 instance for a new userID_caseID combination
Given a user creates a new case with caseID
When the system detects the new case creation event
Then a new EC2 instance is created for the userID_caseID combination
And the librechat.yaml and .env files are updated to reflect the Assistant thread assigned to the userID_caseID combination
And the EC2 instance is assigned to the userID_caseID
Scenario: Launch EC2 instance when a user accesses a case
Given a user accesses an existing case with caseID
When the system detects the case access event
Then the existing EC2 instance for the userID_caseID combination is launched
And if the EC2 instance does not exist, a new instance is created and configured
Scenario: Automatic shutdown of EC2 instance after inactivity
Given an EC2 instance is running
When there is no activity for 10 minutes
Then the EC2 instance shuts down automatically
Which components are impacted by your request?
No response
Pictures
No response
Code of Conduct

[X] I agree to follow this project's Code of Conduct

@AliSMAmin wouldnt the issue #21 cover this specific case?

@tomasvalererealms yes, this is an old issue that was carried over from the very early EC2 implementation. Fargate and ECS will cover auto-deployments. Will close this.


Added snippet to read RDS files in an R notebook

follow-up on this PR
Currently, the page only provides examples for CSV files. I'd like to add a snippet that I developed to read RDS files from a datastore using a filestore object.

@sdgilley
Can you review the proposed changes?
Important: When the changes are ready for publication, adding a #sign-off comment is the best way to signal that the PR is ready for the review team to merge.
#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

@sdgilley can you please review my proposed changes? I think my PR went inactive.
#sign-off

@sdgilley - nudge. please review. thanks!

@wahalulu - can you verify this addition to the code?  Thanks.

@wahalulu bump


Setting restangular baseURL to a host:port, port is dropped.

RestangularProvider.setBaseUrl('http://localhost:8080/');
...

var postsRoot = Restangular.all("posts/");
postsRoot.getList()

Requests are issued to
http://localhost/posts

Instead of
http://localhost:8080/posts

The correct way of setting base url is
Restangularset.BaseUrl('http://localhost:8080/');


useRedirectToVersionedCube uses wrong dataSource on page load

It seems like useRedirectToVersionedCube uses the default dataSource prod on int.lindas.admin.ch when reaching https://int.visualize.admin.ch/en/browse?dataset=https%3A%2F%2Fpolitics.ld.admin.ch%2Ffch%2Fpolitical-correspondence&dataSource=Int instead of picking the Int dataSource indicated in the URL.
It is visible from the network tab where we can see that the request to Lindas is made to lindas.admin.ch
It leads to the failure of loading the cube.
I cannot yet reproduce on localhost.

To reproduce the issue locally:

set ENDPOINT env variable to point at PROD LINDAS env
restart the application
go to http://localhost:3000/en/browse?dataset=https%3A%2F%2Fenergy.ld.admin.ch%2Fsfoe%2Fbfe_ogd102_fuellstand_gasspeicher&dataSource=Int


Is it possible to obtain an iterator from  a Seq?

Related Closed (solved) Issue:
https://github.com/facebook/immutable-js/issues/254
For instance, when we have a code like below:
var _ = require('lodash');
var __ = require('immutable');

var __natural = __.Range(); //infinite natural numbers sequence
var fibF = _.memoize(function(n) {
  return n <= 1 ? 1 : fibF(n - 2) + fibF(n - 1); //as the math definition of fibonacci
});
var __fib = __natural.map(fibF);

Is it possible to obtain an iterator from  sequences like __natural or __fib?
such as to obtain a value like a = it.next(); with a certain event in a gradual manner?
Regards.

I post some other question,
https://github.com/facebook/immutable-js/issues/272
and coincidently, I had an answer
pluma commented 6 hours ago

You can get an iterator using Range().values().

So I tried.
var _ = require('lodash');
var __ = require('immutable');

var __natural = __.Range();
//infinite natural numbers sequence

var __narural10 = __natural.take(10);
//the first 10 sequence (still no calculation)

console.log(__narural10.toArray());//calculate and output

var fibF = _.memoize(function(n) {
  return n <= 1 ? 1 : fibF(n - 2) + fibF(n - 1);
  //as the math definition of fibonacci
});

var __fib = __natural.map(fibF);
//infinite Fibonacci sequence

var __fib100 = __fib.take(100);
//the first 100 sequence (still no calculation)

console.log(__fib100.toArray()); //calculate and output

var it = __fib.values();

console.log(it.next());  //{ value: 1, done: false }
console.log(it.next());  //{ value: 1, done: false }
console.log(it.next());  //{ value: 2, done: false }
console.log(it.next());  //{ value: 3, done: false }
console.log(it.next());  //{ value: 5, done: false }

Very cool.
Perhaps, does .values() implemented recently?

values(), keys() and entries() exist on all Immutable.js collections, mirroring the same methods on ES6 Map and Set.
However, this is not the same as the "default iterator" function (equivalent to values() for indexed collections and Sets, but equivalent to entries() for Maps).
These functions also are specific to collections and won't be found on any generic iterable where the getIterator function I provided above will always use the default iterator and will work for any generic iterable, not just those found in this library.

@leebyron
I see!
Thanks you. Very informative to study.


[Flaky Test] PodZoneAffinity tests

How to categorize this issue?

/area testing
/kind flake
Which test(s)/suite(s) are flaking:
PodZoneAffinity tests
/home/prow/go/src/github.com/gardener/gardener/test/integration/resourcemanager/podzoneaffinity/podzoneaffinity_test.go:26
  when namespace has zone enforcement label with value
  /home/prow/go/src/github.com/gardener/gardener/test/integration/resourcemanager/podzoneaffinity/podzoneaffinity_test.go:79
    [It] should add nodeAffinity
    /home/prow/go/src/github.com/gardener/gardener/test/integration/resourcemanager/podzoneaffinity/podzoneaffinity_test.go:92
  Expected
      <*v1.Affinity | 0x0>: nil
  not to be nil
  In [It] at: /home/prow/go/src/github.com/gardener/gardener/test/integration/resourcemanager/podzoneaffinity/podzoneaffinity_test.go:96

CI link:
https://prow.gardener.cloud/view/gs/gardener-prow/pr-logs/pull/gardener_gardener/6668/pull-gardener-integration/1569616104525926400
Reason for failure:
Mentioned above.
Anything else we need to know:

cc @timuthy

I tried to find out more about the flaky test and did some stress testing with more logging:
•! [PANICKED] [0.030 seconds]
PodZoneAffinity tests
/Users/tim/go/src/github.com/gardener/gardener/test/integration/resourcemanager/podzoneaffinity/podzoneaffinity_test.go:28
  when namespace has zone enforcement label with value
  /Users/tim/go/src/github.com/gardener/gardener/test/integration/resourcemanager/podzoneaffinity/podzoneaffinity_test.go:81
    [It] should add nodeAffinity
    /Users/tim/go/src/github.com/gardener/gardener/test/integration/resourcemanager/podzoneaffinity/podzoneaffinity_test.go:96

  Begin Captured GinkgoWriter Output >>
    {"level":"info","ts":"2022-09-14T18:09:30.160+0200","logger":"podzoneaffinity-webhook-test","msg":"Pod","pod":{"namespace":"podzoneaffinity-webhook-test-e000d401","name":"test-m5bqq"}}
  << End Captured GinkgoWriter Output

  Test Panicked
  In [It] at: /Users/tim/go/src/github.com/gardener/gardener/test/integration/resourcemanager/podzoneaffinity/podzoneaffinity_test.go:103

  Affinity is nil for pod podzoneaffinity-webhook-test-e000d401/test-m5bqq

  Full Stack Trace
    github.com/gardener/gardener/test/integration/resourcemanager/podzoneaffinity_test.glob..func2.3.2()
    	/Users/tim/go/src/github.com/gardener/gardener/test/integration/resourcemanager/podzoneaffinity/podzoneaffinity_test.go:103 +0x6e8

--> podzoneaffinity-webhook-test-e000d401/test-m5bqq is the pod which doesn't have the expected affinity configuration set.
However, the webhook sends the anticipated patch to the Kube-Apiserver:
{"level":"info","ts":"2022-09-14T18:09:30.182+0200","logger":"webhook.pod-zone-affinity","msg":"Calling webhook","pod":"podzoneaffinity-webhook-test-e000d401/"}
{"level":"info","ts":"2022-09-14T18:09:30.182+0200","logger":"webhook.pod-zone-affinity","msg":"handleNodeAffinity","pod":"podzoneaffinity-webhook-test-e000d401/"}
{"level":"info","ts":"2022-09-14T18:09:30.184+0200","logger":"webhook.pod-zone-affinity","msg":"Namespace Label","pod":"podzoneaffinity-webhook-test-e000d401/","control-plane.shoot.gardener.cloud/enforce-zone":"zone-a"}
{"level":"info","ts":"2022-09-14T18:09:30.184+0200","logger":"webhook.pod-zone-affinity","msg":"Setting","pod":"podzoneaffinity-webhook-test-e000d401/","Affinity":"&Affinity{NodeAffinity:&NodeAffinity{RequiredDuringSchedulingIgnoredDuringExecution:&NodeSelector{NodeSelectorTerms:[]NodeSelectorTerm{NodeSelectorTerm{MatchExpressions:[]NodeSelectorRequirement{NodeSelectorRequirement{Key:topology.kubernetes.io/zone,Operator:In,Values:[zone-a],},},MatchFields:[]NodeSelectorRequirement{},},},},PreferredDuringSchedulingIgnoredDuringExecution:[]PreferredSchedulingTerm{},},PodAffinity:&PodAffinity{RequiredDuringSchedulingIgnoredDuringExecution:[]PodAffinityTerm{PodAffinityTerm{LabelSelector:&v1.LabelSelector{MatchLabels:map[string]string{},MatchExpressions:[]LabelSelectorRequirement{},},Namespaces:[],TopologyKey:topology.kubernetes.io/zone,NamespaceSelector:nil,},},PreferredDuringSchedulingIgnoredDuringExecution:[]WeightedPodAffinityTerm{},},PodAntiAffinity:nil,}"}
{"level":"info","ts":"2022-09-14T18:09:30.184+0200","logger":"webhook.pod-zone-affinity","msg":"Response","pod":"podzoneaffinity-webhook-test-e000d401/","patches":[{"op":"add","path":"/spec/affinity","value":{"nodeAffinity":{"requiredDuringSchedulingIgnoredDuringExecution":{"nodeSelectorTerms":[{"matchExpressions":[{"key":"topology.kubernetes.io/zone","operator":"In","values":["zone-a"]}]}]}},"podAffinity":{"requiredDuringSchedulingIgnoredDuringExecution":[{"labelSelector":{},"topologyKey":"topology.kubernetes.io/zone"}]}}}]}
{"level":"info","ts":"2022-09-14T18:09:30.220+0200","logger":"webhook.pod-zone-affinity","msg":"Calling webhook","pod":"podzoneaffinity-webhook-test-44bc1f69/"}

The Kube-Apiserver logs suspicious messages whenever a test run fails:
W0915 07:43:41.203992       1 dispatcher.go:195] Failed calling webhook, failing closed pod-zone-affinity.resources.gardener.cloud: failed calling webhook "pod-zone-affinity.resources.gardener.cloud": failed to call webhook: Post "https://host.docker.internal:9449/webhooks/pod-zone-affinity?timeout=10s": context canceled
E0915 07:43:41.205446       1 finisher.go:175] FinishRequest: post-timeout activity - time-elapsed: 2.091875ms, panicked: false, err: Internal error occurred: failed calling webhook "pod-zone-affinity.resources.gardener.cloud": failed to call webhook: Post "https://host.docker.internal:9449/webhooks/pod-zone-affinity?timeout=10s": context canceled, panic-reason: <nil>

However, it's not yet clear why:

The context is cancelled (according to the logs) because we pass a context.Background() to the request and the timeout of 10s in the MutatingwebhookConfiguration also didn't exceed.
Why the client.Create call does not fail if Kube-Apiserver has issues contacting the webhook.

Another occurence: https://prow.gardener.cloud/view/gs/gardener-prow/pr-logs/pull/gardener_gardener/6533/pull-gardener-integration/1571723184804204544

I will have another look ASAP.

/assign

Another one: https://prow.gardener.cloud/view/gs/gardener-prow/logs/ci-gardener-integration/1572414255263649792

A different test:
PodZoneAffinity tests
/home/prow/go/src/github.com/gardener/gardener/test/integration/resourcemanager/podzoneaffinity/podzoneaffinity_test.go:26
  when namespace hasn't zone enforcement label
  /home/prow/go/src/github.com/gardener/gardener/test/integration/resourcemanager/podzoneaffinity/podzoneaffinity_test.go:109
    [It] should not add podAffinity
    /home/prow/go/src/github.com/gardener/gardener/test/integration/resourcemanager/podzoneaffinity/podzoneaffinity_test.go:110
  Begin Captured GinkgoWriter Output >>
    {"level":"debug","ts":"2022-09-21T07:34:09.858Z","logger":"controller-runtime.webhook.webhooks","msg":"received request","webhook":"/webhooks/pod-zone-affinity","UID":"18de0c6c-e779-4d95-8a0d-9fa04c76c7cb","kind":"/v1, Kind=Pod","resource":{"group":"","version":"v1","resource":"pods"}}
    {"level":"debug","ts":"2022-09-21T07:34:09.860Z","logger":"controller-runtime.webhook.webhooks","msg":"wrote response","webhook":"/webhooks/pod-zone-affinity","code":200,"reason":"","UID":"18de0c6c-e779-4d95-8a0d-9fa04c76c7cb","allowed":true}
  << End Captured GinkgoWriter Output
  Expected
      <*v1.Affinity | 0xc0009ae5a0>: {
          NodeAffinity: nil,
          PodAffinity: {
              RequiredDuringSchedulingIgnoredDuringExecution: [
                  {
                      LabelSelector: {
                          MatchLabels: nil,
                          MatchExpressions: nil,
                      },
                      Namespaces: nil,
                      TopologyKey: "topology.kubernetes.io/zone",
                      NamespaceSelector: nil,
                  },
              ],
              PreferredDuringSchedulingIgnoredDuringExecution: nil,
          },
          PodAntiAffinity: nil,
      }
  to be nil
  In [It] at: /home/prow/go/src/github.com/gardener/gardener/test/integration/resourcemanager/podzoneaffinity/podzoneaffinity_test.go:114
------------------------------

Ref: https://prow.gardener.cloud/view/gs/gardener-prow/pr-logs/pull/gardener_gardener/6700/pull-gardener-integration/1572488601646665728


General Issue: Increase test coverage for datasets.R

Background Information
@thomas-neitmann We can write tests for these right?

Definition of Done
No response

Also while you are here... @thomas-neitmann ... Should we write tests for these warnings with the joins? Seems like a nice to have?

@bms63 FYI that a new contributor Jen will try and tackle this as she's building up experience with unit testing. I just went through our development process with her, hence the draft commit above and PR.

Just wanted to feedback on this function.
The documentation that I found for it is lacking any usage examples and it is not clear to me what this function should be doing. The reference page suggests that a dataframe is read, though when examining the code only two values are accepted and I could not understand the purpose of it or how this fits in to the developer process.  I would suggest that some more detail needs to be made on the documentation side to make this clear to new developers. Thanks!

Thanks @J-Lox for the feedback.
@bundfussr  @manciniedoardo  some of our admiraldev function documentation are a little weak and some gaps in testing.  Perhaps something we can fix in this release?

@J-Lox , you are right, the documentation is not clear and should be improved. I have created a new issue for this: https://github.com/pharmaverse/admiraldev/issues/271

Thanks @bundfussr


Remove duplicated way to set flag kFlagResponseExpected

Problem
Currently, we have two way to set flag kFlagResponseExpected in ExchangeContext, by calling SetResponseExpected() or set kExpectResponse in sendFlags.
If an outgoing message does expect a response, and the sender calls SetResponseExpected and set  kExpectResponse in sendFlags, the response timer will not be armed since it will find there is already one 'response expected' message outstanding.

Summary of Changes
Make SetResponseExpected/IsResponseExpected private in ExchangeContext since we expect the protocol only set the kFlagResponseExpected flag through sendFlags.

Seems like you moved the get/set methods from public to private.
Could you explain in the PR description how this addresses duplication? I.e. will there be a followup PR that sees some actual removal? Or is this just some avoidance of exposing methods that may not do what people think they do?

With this PR, the client of ExchangeContext can only set kFlagResponseExpected via sendFlags.
I debugged an issue in which the response timer was not armed, I found the root cause is the client called SetResponseExpected(true) after SetResponseTimeout(Timeout timeout). Which make sense to me logically, but this will actually make exchange believes there is already a pending  'response expected' message when it processes sendFlags later.
Moving get/set methods to private will prevent such misuse in future.


Implement active teardowns and add useQuery features to useSubscription

Resolve #407
I think the idea of adding "active teardowns" is pretty valuable. It may be required in the future for someone to actively cancel ongoing queries from exchanges. This is already necessary to correctly implement ending subscriptions.
This hence also adds missing features to the useSubscription hook, like executeSubscription and args.pause. It also ensures that the handler arg is a constant ref, since reexecuting subscriptions when it changes wouldn't make much sense.
Wonka had a slight bug in onEnd. The operator wasn't propagating Close signals correctly, so the use of onEnd would prevent unsubscriptions from propagating upwards.

Turns out I just forgot to use useImmediateEffect, but it should be fine now :+1:

Verified this to be working on CodeSandbox, but more testing needed. There's a prerelease on npm under the next tag with version 1.4.1-next.1


Check default ignore versions

https://internal.almoctane.com/ui/entity-navigation?p=131002/6001&entityType=work_item&id=916303

A developer build has not yet been created for this branch. Click here to go ahead and create the build...

CI Build Link:
https://sou-jenkins2.swinfra.net/job/CAFapi/job/CAFapi~docker-versions-maven-plugin~I916303~CI


Client instrumentation does not finish spans after ConnectionException

It seems that ClientTracingFilter.filter(request, response) is not called after:
javax.ws.rs.ProcessingException: java.net.ConnectException: Connection refused (Connection refused)
ClientRuntime.invoke from jersey client:
    public ClientResponse invoke(final ClientRequest request) {
        ClientResponse response;
        try {
            try {
                response = connector.apply(addUserAgent(Stages.process(request, requestProcessingRoot), connector.getName()));
            } catch (final AbortException aborted) {
                response = aborted.getAbortResponse();
            }

            return Stages.process(response, responseProcessingRoot);
        } catch (final ProcessingException pe) {
            throw pe;
        } catch (final Throwable t) {
            throw new ProcessingException(t.getMessage(), t);
        }
    }

The exception is thrown from the line with response = conn... and the execution skips over Stages.process(response, responseProcessingRoot) which would run the filter.
Maybe there is some other mechanism which can react to this exception.

Oh, it's already reported under https://github.com/opentracing-contrib/java-jaxrs/issues/30
I'm closing this.


type of SetUpdateCallbackFn is invalid

🐛 Bug Report
typescript definition of wrong.
now it is:
export interface SetUpdateCallbackFn<DS extends object> {
  (ds: Partial<UseSpringProps<DS>>): void;
  (i: number): Partial<UseSpringProps<DS>>;
}

but it should be:
export interface SetUpdateCallbackFn<DS extends object> {
  (ds: Partial<UseSpringProps<DS>>): void;
  (f: (i: number) => Partial<UseSpringProps<DS>>): void; // this line
}

To Reproduce
import React, { useState } from 'react';
import { useSprings, animated, UseSpringProps } from 'react-spring';

// interface SetUpdateCallbackFn<DS extends object> {
//  (f: (i: number) => Partial<UseSpringProps<DS>>): void;
//}

const App: React.FC = () => {
  const [springs, set] = useSprings(3, index => ({ opacity: 1 }));
  return (
    <div style={{ padding: 15 }}>
      {springs.map(n => (
        <animated.div
          onClick={e => {
            set((n: number) => ({
              opacity: 2 * n,
            }));
          }}>
          {n.opacity}
        </animated.div>
      ))}
    </div>
  );
};

export default App;

this produce following error:
No overload matches this call.
  Overload 1 of 2, '(ds: Partial<Merge<{ opacity: number; } & UseSpringBaseProps, { from?: Partial<Pick<{ opacity: number; }, "opacity">> | undefined; onRest?(ds: Partial<Pick<{ opacity: number; }, "opacity">>): void; }>>): void', gave the following error.
    Value of type '(n: number) => { opacity: number; }' has no properties in common with type 'Partial<Merge<{ opacity: number; } & UseSpringBaseProps, { from?: Partial<Pick<{ opacity: number; }, "opacity">> | undefined; onRest?(ds: Partial<Pick<{ opacity: number; }, "opacity">>): void; }>>'. Did you mean to call it?
  Overload 2 of 2, '(i: number): Partial<Merge<{ opacity: number; } & UseSpringBaseProps, { from?: Partial<Pick<{ opacity: number; }, "opacity">> | undefined; onRest?(ds: Partial<Pick<{ opacity: number; }, "opacity">>): void; }>>', gave the following error.
    Argument of type '(n: number) => { opacity: number; }' is not assignable to parameter of type 'number'.  TS2769

    13 |         <animated.div
    14 |           onClick={e => {
  > 15 |             set((n: number) => ({
       |                 ^
    16 |               opacity: 2 * n,
    17 |             }));
    18 |           }}>

Steps to reproduce the behavior:
compile above code on typescript environment.
Expected behavior
work well same as on JavaScript.
Link to repro (highly encouraged)
(Please provide either a CodeSandbox demo or an example GitHub repo.)
Environment

react-spring  8.0.27
react v16.12.0
typescript 3.7.3

Please use v9 beta if you're a TypeScript user. The v8 types are unmaintained.


Share ApacheImage with baremetal, octavia, and telemetry

The same http image is already used for these services but is causing bundle warnings at build time. This change updates the OpenStackVersion resource so that a single Apache parameter is shared by Baremetal, Octavia, and Telemetry.

@jlarriba @beagles how does this look?

This PR was a blocker for https://github.com/openstack-k8s-operators/openstack-operator/pull/1012 . I've now rebased 1012 to include this. If CI passes I may just use the larger PR as folks don't seem to get the motivation for these changes.

It was holiday, not motivation, which made this PR unreviewed. Im sorry about that, but I see that the changes were already merged in the other PR.
Thank you @dprince


[Suggestion] More 1 folding and re close folding if other list clicked

Hei, can you provide function it can be more than 1 folding, so i can add 2 more folding cell, and please add boolean optional to make folding cell close if other list of folding cell click to open,
thanks

Hi it was hello world type package now i am getting some feature requests i am planning to rewrite it and make it simple, will add boolean toggle operation

Now you can programmatically open and close cell please see example project.


feat: improve doppelganger protection logs

Motivation
Currently we do not log anything until doppelganger detection is complete. Logging the liveness check each epoch gives the user a bit more insights on what's going on, otherwise it feels a bit like the client is frozen / not doing anything.
Description

Adds more epoch information to existing dp logs, those were quite helpful to debug https://github.com/ChainSafe/lodestar/issues/5675
Log doppelganger liveness check to info instead of debug, only log if there are indices to check

:tada: This PR is included in v1.12.0 :tada:


flutter can not open custom localization file

Steps to reproduce

Install flutter_localization and intl packages
Enable generation in pubspec.yaml
add l10n.yaml at the root of the project
the specified information in this file was

arb-dir: lib/config/localization/l10n
template-arb-file: app_en.arb
output-localization-file: lib/config/localization/localizations.dart

add arb files as specified in the app
run flutter gen-l10n

Expected results
Expected to have AppLocalization classes created on the specified output file
Actual results
Flutter throwed exceptions
flutter_01.log

(This is from flutter_01.log)
command
flutter gen-l10n
exception
PathNotFoundException: PathNotFoundException: Cannot open file, path = '/home/egovridc/Desktop/Ridc-Projects/nhc-mobile/.dart_tool/flutter_gen/gen_l10n/lib/config/localization/localizations.dart' (OS Error: No such file or directory, errno = 2)
#0      _File.throwIfError (dart:io/file_impl.dart:675:7)
#1      _File.openSync (dart:io/file_impl.dart:490:5)
#2      _File.writeAsBytesSync (dart:io/file_impl.dart:644:31)
#3      _File.writeAsStringSync (dart:io/file_impl.dart:668:5)
#4      ForwardingFile.writeAsStringSync (package:file/src/forwarding/forwarding_file.dart:150:16)
#5      ErrorHandlingFile.writeAsStringSync.<anonymous closure> (package:flutter_tools/src/base/error_handling_io.dart:279:22)
#6      _runSync (package:flutter_tools/src/base/error_handling_io.dart:600:14)
#7      ErrorHandlingFile.writeAsStringSync (package:flutter_tools/src/base/error_handling_io.dart:278:5)
#8      LocalizationsGenerator.writeOutputFiles (package:flutter_tools/src/localizations/gen_l10n.dart:1379:20)
#9      generateLocalizations (package:flutter_tools/src/localizations/gen_l10n.dart:79:9)
#10     GenerateLocalizationsCommand.runCommand (package:flutter_tools/src/commands/generate_localizations.dart:264:11)
#11     FlutterCommand.verifyThenRunCommand (package:flutter_tools/src/runner/flutter_command.dart:1772:12)
<asynchronous suspension>
#12     FlutterCommand.run.<anonymous closure> (package:flutter_tools/src/runner/flutter_command.dart:1408:27)
<asynchronous suspension>
#13     AppContext.run.<anonymous closure> (package:flutter_tools/src/base/context.dart:153:19)
<asynchronous suspension>
#14     CommandRunner.runCommand (package:args/command_runner.dart:212:13)
<asynchronous suspension>
#15     FlutterCommandRunner.runCommand.<anonymous closure> (package:flutter_tools/src/runner/flutter_command_runner.dart:420:9)
<asynchronous suspension>
#16     AppContext.run.<anonymous closure> (package:flutter_tools/src/base/context.dart:153:19)
<asynchronous suspension>
#17     FlutterCommandRunner.runCommand (package:flutter_tools/src/runner/flutter_command_runner.dart:364:5)
<asynchronous suspension>
#18     run.<anonymous closure>.<anonymous closure> (package:flutter_tools/runner.dart:130:9)
<asynchronous suspension>
#19     AppContext.run.<anonymous closure> (package:flutter_tools/src/base/context.dart:153:19)
<asynchronous suspension>
#20     main (package:flutter_tools/executable.dart:93:3)
<asynchronous suspension>

flutter doctor
[✓] Flutter (Channel stable, 3.24.3, on Ubuntu 24.04.1 LTS 6.8.0-47-generic, locale en_US.UTF-8)
    • Flutter version 3.24.3 on channel stable at /home/egovridc/snap/flutter/common/flutter
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 2663184aa7 (6 weeks ago), 2024-09-11 16:27:48 -0500
    • Engine revision 36335019a8
    • Dart version 3.5.3
    • DevTools version 2.37.3

[✓] Android toolchain - develop for Android devices (Android SDK version 35.0.0)
    • Android SDK at /home/egovridc/Android/Sdk
    • Platform android-35, build-tools 35.0.0
    • Java binary at: /snap/android-studio/161/jbr/bin/java
    • Java version OpenJDK Runtime Environment (build 17.0.10+0-17.0.10b1087.21-11609105)
    • All Android licenses accepted.

[✓] Chrome - develop for the web
    • Chrome at google-chrome

[✓] Linux toolchain - develop for Linux desktop
    • clang version 10.0.0-4ubuntu1
    • cmake version 3.16.3
    • ninja version 1.10.0
    • pkg-config version 0.29.1

[✓] Android Studio (version 2024.1)
    • Android Studio at /snap/android-studio/161
    • Flutter plugin version 81.0.2
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 17.0.10+0-17.0.10b1087.21-11609105)

[✓] IntelliJ IDEA Community Edition (version 2024.2)
    • IntelliJ at /snap/intellij-idea-community/537
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart

[✓] IntelliJ IDEA Ultimate Edition (version 2024.2)
    • IntelliJ at /snap/intellij-idea-ultimate/532
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart

[✓] VS Code (version 1.94.2)
    • VS Code at /snap/code/current/usr/share/code
    • Flutter extension version 3.98.0

[✓] Connected device (3 available)
    • Pixel 5 (mobile) • 09181FDD40078C • android-arm64  • Android 14 (API 34)
    • Linux (desktop)  • linux          • linux-x64      • Ubuntu 24.04.1 LTS 6.8.0-47-generic
    • Chrome (web)     • chrome         • web-javascript • Google Chrome 130.0.6723.58

[✓] Network resources
    • All expected network resources are available.

• No issues found!

Does this issue occur consistently or only one time? Can you try again? If it persists, can you please share the sample project so that I can try it on my end. Thanks!

I tried it several times, it does the same, but if you let flutter decide the output file destination, nothing goes wrong

Can you share a sample project for this so that I can pull and check it on my end? (you can try my sample project here as well)


Added contributing guide and issue template

Coverage remained the same at 98.797% when pulling 1e3495aff79961a0c00fdaad0334fcc96d574f73 on feature/contributing into d407aa8a73fc33d711fdd4947b5a9874c6d09ed5 on master.

Coverage remained the same at 98.797% when pulling 835390c1cd032f7c8f4b80d4dacb39227085e674 on feature/contributing into d407aa8a73fc33d711fdd4947b5a9874c6d09ed5 on master.


bug: use direct casadi bspline function for 1D & 2D cubic interp

Description
Instead of using the casadi plugin system, use direct bspline function for 1D and 2D cubic interpolation.
I didn't implement 3D cubic interpolation because (a) scipy has no functions for bspline interpolation in 3D, and (b) we only test 3D linear interpolation so didn't think it was neccessary.
Fixes #4570
Type of change

[x] Bug fix (non-breaking change which fixes an issue)

Key checklist:

[x] No style issues: $ pre-commit run (or $ nox -s pre-commit) (see CONTRIBUTING.md for how to set this up to run automatically when committing locally, in just two lines of code)
[x] All tests pass: $ python run-tests.py --all (or $ nox -s tests)
[x] The documentation builds: $ python run-tests.py --doctest (or $ nox -s doctests)

You can run integration tests, unit tests, and doctests together at once, using $ python run-tests.py --quick (or $ nox -s quick).
Further checks:

[x] Code is commented, particularly in hard-to-understand areas
[x] Tests added that prove fix is effective or that feature works

@martinjrobins Thanks, I am testing it now before I review


Improve team draft logs

Two improvements suggested by @tooomm :

Log shows two players as (empty) instead hiding them out for Team Draft logs.
There are no team colors shown in logs for Team Draft logs.

Plus I should just test and look at team draft logs and see if there are other things to improve - I didn't look at logs at all while building team drafts.

Log shows two players as (empty) instead hiding them out for Team Draft logs.
There are no team colors shown in logs for Team Draft logs.

Following the most recent "LR vs. LoL Showdown" Kaldheim Edition I realized that logs for Team Draft show both issues again:

Also note, that ideally the game type in the logs should show Team Draft as well.

Log shows two players as (empty) instead hiding them out for Team Draft logs.
There are no team colors shown in logs for Team Draft logs.

Following the most recent "LR vs. LoL Showdown" Kaldheim Edition I realized that logs for Team Draft show both issues again:

Also note, that ideally the game type in the logs should show Team Draft as well.

I distinctly remember staring at the "a < 6 || a === 7" condition and failing to understand why it was not equivalent to "a < 8"... sigh
We'll just say I was tired :D
Anyway, should be fixed by 7382f481c014eb68fc8a98507b3576af0794a48e and displaying "Team Draft".
Thanks!

I distinctly remember staring at the "a < 6 || a === 7" condition and failing to understand why it was not equivalent to "a < 8"... sigh
We'll just say I was tired :D
Anyway, should be fixed by 7382f481c014eb68fc8a98507b3576af0794a48e and displaying "Team Draft".
Thanks!

Awesome 😄

Awesome 😄


refactor(core): break manager struct into smaller ones

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Docs
[ ] New Binding issue #___
[ ] Code style update
[x] Refactor
[ ] Build-related changes
[ ] Other, please describe:

Does this PR introduce a breaking change?

[ ] Yes, and the changes were approved in issue #___
[ ] No

Checklist

[ ] When resolving issues, they are referenced in the PR's title (e.g fix: remove a typo, closes #___, #___)
[ ] A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.
[ ] I have added a convincing reason for adding this feature, if necessary

Other information

@amrbashir I've done my best with the Arc removals, some are still around because there's some types that are cloned and moved to another thread / closure (mostly callbacks).


docs: adding regtest docs

Description
Adds documentation for the regtest network.
Checklist

[x] Conventional commits were used
[x] New links to files and images were verified
[x] For fixes/refactors: all existing references were identified and replaced
[x] Style guide was reviewed and applied
[x] People were tagged for review

Ideally this issue would be closed before merging this PR.

Once approved we can merge, no need to wait for the issue referenced above to be resolved. I added a warning notice at the top of the running-regtest-node page.


Mail component not bringing up mail client

Hi,
I recently integrated the share button in our site at drinktelula.com to share recipes posted on the site. The Facebook, Twitter, and G+ shares work quite well, however, the mail share does not. When clicked, nothing happens.
Another issue I'm having is that the Facebook component isn't getting any of my customization regarding the caption, title and image.
You can see the share button in action at:
http://drinktelula.com/post.html#2
My JS for the button is:
initShareButton = function(options) {
    var description = options.description,
        title = "Delicious " + options.title + " on drinktelula.com",
        image = options.image;

    config = {

        title : "nothing",
        description : title,

        networks: {
            facebook : {
                title: title,
                caption: "OMG",
                image: image

            },
            linkedin : {

                enabled: false
            },
            reddit : {
                enabled: false
            },
            pinterest : {
                enabled: false
            },
            email: {
                title: "Check out this delicious recipe from Telula!",
                description: "LOVE THIS"
            }
        }

    };

    new ShareButton(config);

}

        var shareButtonOptions = {

//Recipe Data is a JSON object I'm passing in.
            description: recipeData.title,
            title : recipeData.title,
            image : "http://drinktelula.com/uploads/" + recipeData.image
        }

        initShareButton(shareButtonOptions);

Any help on this is much appreciated!
Thanks,
Guillermo from Humanaut

So after some digging into the source code, I managed to get the mail button to open up the mail client after removing this line "&& i.setAttribute("onclick", "return false")" in share-button.min.js.
Is this line necessary/what does it do?

After some digging into the source code, I found this line (937) in share-button.js was causing the issue as it was returning both 'email' and 'enabled' classes:
if (network.className !== 'email') a.setAttribute('onclick', 'return false');
I replaced it with the line below so it targets only the first class of each 'network' element to compare it to 'email' and thus successfully not giving the element the 'return false' attr.
if (network.classList[0] !== 'email') a.setAttribute('onclick', 'return false');
Should this be implemented into master or is there something I'm doing wrong?
Thanks.
Guillermo

:+1:

not yet updated in master

see #260


Add account id on player data base, and handle it accordingly

Add account id on player data base, and handle it accordingly

Hi, I am just going to merge this without checking it - I have no available time these days and I have trust in you. :-)


MAINT: Update deps

https://github.com/mne-tools/mne-installers/pull/236 was red, let's see if we can keep things green. FYI @hoechenberger I usually try to push these updates as part of those PRs. It's a good excuse to make sure everything still works rather than having to wait until later. Always feels good to merge things that are green, too.

Ah all right, got you, @larsoner! I will consider that in the future

Superseded by other PRs


Matching cdsapi library with new CDS request

After reading the documentation from cds and cdsapi I realized that there must be compatibility between them. I locally modified the file environment.yml at 'cdsapi=0.7.0' with 'cdsapi=0.7.3'. Then in the hazard script i put my key api for new CDS. All cells from this script work perfectly and download the data from EUROCORDEX.
My sugestion is to update the cdsapi library from the 'environment.yml'  file.
Thank you!

Another problem I faced is with the risk script 'EXTREME_PRECIPITATION_Risk_Assessment_examples.ipynb'. At begin, I put my bbox (region) and in final all plots are from Catalonia region. Now I have all the necessary input data in this script because I was able to download and clip data on my region from previous hazard script.
Please, after solving with cdsapi, look at the risk script, change the bbox (region) and tell me what you get!
Thank you!

After reading the documentation from cds and cdsapi I realized that there must be compatibility between them. I locally modified the file environment.yml at 'cdsapi=0.7.0' with 'cdsapi=0.7.3'. Then in the hazard script i put my key api for new CDS. All cells from this script work perfectly and download the data from EUROCORDEX. My sugestion is to update the cdsapi library from the 'environment.yml' file. Thank you!

Hello @flor187,
thank you for the suggestion! The 0.7.0 version of cdsapi was still working in our automated dataset tests, but you are right: the documentation states that at least 0.7.2 should be used. I have upgraded the cdsapi package to the latest 0.7.5 version across all CLIMAAX repositories and on the CLIMAAX JupyterHub.

I've created a separate issue for the problem regarding the bbox and plotted region.

Thank you!


fix: battery icon when below 10 percent is not valid

when battery level is below 10 today it selects mdi:battery-level-9 for example and this is not a valid icon so i have changed to utilize the built in icon helper for battery from home assistant.

Nice! Could you rewrite the commit message to follow the conventional commits format and force push to make that check happy?

@argoyle better message now? :)

Thanks for contributing. Released as v1.7.5 now.


Add support for subdirectories

Mainly for mod managers, but can be used by anyone to keep things organized

This breaks VRChat Melon Assistant's approach of moving mods/plugins into a "Broken" subfolder of Mods/Plugins folder to temporarily disable them.

Also this is the master branch.
PR to the alpha branch.

Whoops, sorry

This breaks VRChat Melon Assistant's approach of moving mods/plugins into a "Broken" subfolder of Mods/Plugins folder to temporarily disable them.
Chap in the Discord suggested I add the ability to use a prefix to disable the folder, would that work for MelonAssistant? (assuming they would change the folder name)


feature request

allow multiple items per shop? and random item for a price type thing?

That would be too big of a feature to implement.
I think the basic concept of player shops with a clearly defined product and price should stay the way it is, so only some (more or less) minor changes (e.g. item preview), will happen in the future.

ok thats cool just thought id ask loving the plugin so far :)


steam: switch to the newer steam-runtime packaging

Valve has started releasing tarballs of the steam runtime. It seems a
lot easier to download and extract a single tarball than to download a
buncha debs, extract them, and splat em around a bit.
Let's just use the runtime they build. It's a buncha random binary
packages either way.
Also, the download url for their debs broke, so there's that too.
Motivation for this change
Valve deletes debs from their repos apparently (see  #86892 and #86358).
@tadfisher suggested using the steam-runtime images valve builds in that thread too, and I think it's a great idea!
So yeah, that's what this PR does.
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

Note that I don't actually know how to test the steam-runtime stuff fully. I verified that steam-run seems to give me an environment that looks right? I think?
I verified that a sample game launched correctly (Factorio specifically) both via steam and via steam-run, and it ofc didn't launch outside of the chroot environment.
Running it did print this error: /home/user/.local/share/Steam/ubuntu12_32/steam-runtime/setup.sh: line 22: zenity: command not found
I have no clue if that's new because I can't get the old steam package to work because one of the debs won't download.

cc @hrdinka @abbradar as the maintainers of this derivation.

@euank Thanks for the patch! This looks a lot better than what we have now. I am sorry for not responding earlier. I haven't found any time yet to test this. I will try to give it a closer look this weekend.

So far everything is working for me with this patch. I will give it a few more days for more testing and to checkout your problem with zenity (it’s actually part of the chrootenv and not the runtime, so it should work).

I did some more testing including fresh Steam installs/configs, everything is working as expected. Thanks for this change, this is making things a lot easier.


Add pod affinity note

Fixes #38339

Fixed the indicated header and squashed.

@dshebib would you be willing to push an empty commit so as to retrigger the build? We've been having issues with Netlify & we'd like to get this merged as soon as possible :)

(you can also locally edit your last commit and force push)
I've triggered a build in Netlify, manually.

The best thing to do is to rebase against main though - see https://lwkd.info/2023/20230606#developer-news

@dshebib , please push again to trigger the CI flow by running:
git reset
git commit --amend --no-edit
git push origin pod-affinity -f

@dshebib please rebase against main - see https://github.com/kubernetes/website/pull/40134#issuecomment-1682290500

/close
in favor of #42920


Making it possible to share isolates between contexts

Allocating and then freeing V8 Isolates turns out to be pretty expensive at times.
This patch makes sharing isolates possible by introducing a new MiniRacer::Isolate object,
which can be initialized with a MiniRacer::Snapshot object.
That isolate object can then be used to create a new context: MiniRacer::Context.new(isolate: isolate)
Of course that must be used with special care (probably not used at all, actually)
in multi-threaded code, but works with no particular caveats otherwise.
Example snippet:
snapshot = MiniRacer::Snapshot.new(my_snippet)
isolate = MiniRacer::Isolate.new(snapshot)

# now that isolate can be shared across as many contexts as desired
context1 = MiniRacer::Context.new(isolate: isolate)
context2 = MiniRacer::Context.new(isolate: isolate)

This patch introduces no breaking changes; in particular, contexts still get their
own isolate by default.
Particular care has been taken for memory management, with multiple tests on that.

hmmm what advantage does this offer over simply sharing the context?
Are you able to somehow "reset" an isolate?

@SamSaffron : together with snapshots, that allows creating cheap pre-baked contexts really quick, that you can then pollute as much as you want and then discard as a whole when you're done; and then just get a new pre-baked one for the next request (for example).
Even without bringing snapshots into the picture, V8 isolates are not that cheap to create/destroy; in a single-threaded app it makes sense to re-use the same isolate for all your contexts.
As to resetting isolates, not sure what you mean?

Sorry I mean does this somehow work?
MiniRacer::Context.new(isolate: isolate).eval('a=1')
MiniRacer::Context.new(isolate: isolate).eval('a') => nil

@SamSaffron : sure does. Isolates don't hold the JS context (that's what contexts do). Isolates are just the runtime framework.
irb(main):001:0> require 'mini_racer'
=> true
irb(main):002:0> isolate = MiniRacer::Isolate.new
=> #<MiniRacer::Isolate:0x007fdb6b142618>
irb(main):003:0> MiniRacer::Context.new(isolate: isolate).eval('a=1')
=> 1
irb(main):004:0> MiniRacer::Context.new(isolate: isolate).eval('a')
MiniRacer::RuntimeError: ReferenceError: a is not defined

Can you test what happens with concurrency? I want us to be safe by default even if it means we need to lock on a mutex that lives on the isolate object

@SamSaffron : test what exactly? You shouldn't re-use the same isolate across threads, for sure. But this patch doesn't change that, by default contexts have their own isolate if you don't pass an isolate explicitly when creating them.
As far as testing it still works across threads by default, isn't that what https://github.com/discourse/mini_racer/blob/bddbdcd284f8b1dce8bd0fd303bd15abf23888f9/test/mini_racer_test.rb#L120-L131 does (haven't touched that test in my PR)? Or do you have something else in mind?

Something along the lines of this (but with some warmup code)
isolate = MiniRacer::Isolate.new
(1..10).times do
   Thread.new {
        context = MiniRacer::Context.new(isolate: isolate)
        random = SecureRandom.hex
        context.attach("sleep", proc{sleep(0.01)})
        context.eval("sleep()")
        context.eval("a='#{random}'")
        context.eval("sleep()")
        context.eval("a") => should be same random
   }
end

@SamSaffron : no, I don't expect that to work :) as mentioned above, the same isolate shouldn't be used concurrently. That's why by default each context still has its own isolate. The expectation is that anyone using the ability to re-use isolate across contexts should know what they're doing.

I follow, but why have that restriction? we already protect eval and attach, just instead have the @lock object live on the isolate
https://github.com/discourse/mini_racer/blob/master/lib/mini_racer.rb#L104

@SamSaffron : good point, will change

also, we got to update the readme with all the new fancy things :) ideally with a practical example or 2
very happy with this change it unlocks a bunch of possibilities, gives you certainty that code you are running can never interfere with initial state without a performance cost.

@SamSaffron : will do too :)

Thanks for being so reactive!

@SamSaffron : moved the lock to isolates as discussed, see https://github.com/discourse/mini_racer/pull/22/commits/430b080334b78bc6262f8abb223fec1f46f0141e .
Will add README goodies tomorrow.
Other than that, looking good to you?
Thanks!

@SamSaffron : README updated, https://github.com/discourse/mini_racer/pull/22/commits/41d4b3df4276e1b3d5fc331f3cf75d264d04ad09
Thanks!

give me a few days here, I am taking the rest of the week off, will review
it all on monday, thanks heaps!
On Wed, Jun 22, 2016 at 11:33 AM, Jean Rougé<EMAIL_ADDRESS>wrote:

@SamSaffron https://github.com/SamSaffron : README updated, 41d4b3d
https://github.com/discourse/mini_racer/pull/22/commits/41d4b3df4276e1b3d5fc331f3cf75d264d04ad09
Thanks!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/discourse/mini_racer/pull/22#issuecomment-227619757,
or mute the thread
https://github.com/notifications/unsubscribe/AAAUXX8y9djykeulChQLnR4xYDcqlEIVks5qOJDRgaJpZM4I7E_W
.

@SamSaffron : no worries, no rush! Thanks!

this is looking really good!
Can we document warmup and idle_notification in the readme as well?

@SamSaffron : sure, will do, most likely tomorrow, busy day here :) thanks!

no probs, these are all very exciting changes!
On Tue, Jun 28, 2016 at 8:49 AM, Jean Rougé<EMAIL_ADDRESS>wrote:

@SamSaffron https://github.com/SamSaffron : sure, will do, most likely
tomorrow, busy day here :) thanks!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/discourse/mini_racer/pull/22#issuecomment-228899141,
or mute the thread
https://github.com/notifications/unsubscribe/AAAUXeYls7-Ou0UTgkAHrY4ce2z5759dks5qQFNfgaJpZM4I7E_W
.

@SamSaffron : expanded the README as requested at https://github.com/wk8/mini_racer/blob/3e1c214975bd7aaf5c444291f752f0c819bc35ce/README.md

cool, we need a rebase, but once done feel free to merge this in! :+1:

Thanks ❤  ❤

@wk8  do you have a twitter account? wanted to give you a shout out.

@SamSaffron : I don't, sorry. But thank you for your great work :)

Ouch, stuff appears to be timing out on Mac and failing on Ruby 2, can you
have a look?
On Thu, Jun 30, 2016 at 8:03 AM, Jean Rougé<EMAIL_ADDRESS>wrote:

@SamSaffron https://github.com/SamSaffron : I don't, sorry. But thank
you for your great work :)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/discourse/mini_racer/pull/22#issuecomment-229503099,
or mute the thread
https://github.com/notifications/unsubscribe/AAAUXVSQk86K6Vbw62Tt7PzUH2mGOzHIks5qQuvDgaJpZM4I7E_W
.

@SamSaffron : I've seen this failure (https://travis-ci.org/discourse/mini_racer/jobs/141200273) intermittently in dev too, including from master before my changes. As to mac, the job never seems to get started, maybe a travis issue?

https://www.traviscistatus.com/incidents/rqb906yypnk0

@SamSaffron : there's a fix for the intermittent failure: https://github.com/discourse/mini_racer/pull/24


Excessive memory usage during MERGE when source data has no rows

Environment
I found this weird edge case where if your source data has no data, there will be an excessive amount of memory usage and quickly resulting in OOM. Fyi, @Blajda

Write where source data has rows, with partition predicate:
https://github.com/delta-io/delta-rs/assets/15728914/eb9901bb-c82a-43a1-a696-a85a2821d7c2
Write where source data has no rows, with partition predicate. @Blajda here you can see the memory growing
https://github.com/delta-io/delta-rs/assets/15728914/f72f8abc-aa3e-4c38-8ff7-e6841a89bfd4

+1, I have the same issue on merge.

This may be related to #2522


Godot crashes on Linux with Nvidia GT 1030 [regression from drivers 450.66]

I was told to post this here on the godot forums.
Godot version:
3.2.2 64bit (the official release, both standard and mono version)
OS/device including version:
Manjaro linux
nvidia geforce gt 1030 with the nvidia 450.66-6 drivers
Issue description:
On loading any project, godot crashes, with the following terminal output.
Godot Engine v3.2.2.stable.official - https://godotengine.org
OpenGL ES 3.0 Renderer: GeForce GT 1030/PCIe/SSE2
Editing project: /home/~my username~/Godot-games/B
(::home::~my username~::Godot-games::B)
Godot Engine v3.2.2.stable.official - https://godotengine.org
OpenGL ES 3.0 Renderer: GeForce GT 1030/PCIe/SSE2
handle_crash: Program crashed with signal 11
Dumping the backtrace. Please include this when reporting the bug on https://github.com/godotengine/godot/issues
[1] /usr/lib/libc.so.6(+0x3d6a0) [0x7fabb38716a0] (??:0)
[2] /usr/lib/libnvidia-glcore.so.450.66(+0xee6365) [0x7fabb103a365] (??:0)
[3] /usr/lib/libnvidia-glcore.so.450.66(+0xee75fc) [0x7fabb103b5fc] (??:0)
[4] /usr/lib/libnvidia-glcore.so.450.66(+0xb06282) [0x7fabb0c5a282] (??:0)
[5] /usr/lib/libnvidia-glcore.so.450.66(+0xb064fd) [0x7fabb0c5a4fd] (??:0)
[6] /usr/lib/libnvidia-glcore.so.450.66(+0xb08f2c) [0x7fabb0c5cf2c] (??:0)
[7] /home/~my username~/Godot_v3.2.2-stable_x11.64() [0x239ee5e] (:?)
[8] /home/~my username~/Godot_v3.2.2-stable_x11.64() [0x23a14db] (:?)
[9] /home/~my username~/Godot_v3.2.2-stable_x11.64() [0x100f2c4] (:?)
[10] /home/~my username~/Godot_v3.2.2-stable_x11.64() [0x2a6ad9d] (:?)
[11] /home/~my username~/Godot_v3.2.2-stable_x11.64() [0x85b675] (??:?)
[12] /usr/lib/libc.so.6(__libc_start_main+0xf2) [0x7fabb385c152] (??:0)
[13] /home/~my username~/Godot_v3.2.2-stable_x11.64() [0x86695e] (??:?)
-- END OF BACKTRACE --
Steps to reproduce:
/
Minimal reproduction project:
/

Likely the same Nvidia driver bug as #41742.

Does it work if you start with godot --video-driver GLES (or create a new project using GLES2, if the project manager is working for you)?
Can you try to build the 3.2 branch from source with a target=debug build? That should give a better backtrace (for the Godot code at least).

Nvidia 450.66 seems to be the most up-to-date driver currently, but it was still in Beta a few weeks back. Does Manjaro still provide the previous 440 long-lived branch, and if so does Godot work if you roll back to 440?

neither "godot --video-driver GLES3" nor "godot --video-driver GLES2" changes the behaviour at all.
I'll try it with 440.

Welp, I really hope that we do not have another bug in 450.66.
@ottolulau could you give the backtrace from a debug build as @akien-mga said? That would be very useful to know what makes the editor crash, and if it's the same reason of another issue.

See also https://github.com/godotengine/godot/issues/41614, which is about a NVIDIA dirver regression as well.

Okay. Should I do this with the up-to-date build, or the 3.2.2 release?

@akien-mga refers to the 3.2 branch, so I guess the latest 3.2 version from git

Alright, here you go. Bug persists.
~/.../godot-3.2/bin >>> ./godot.x11.tools.64
Godot Engine v3.2.3.rc.custom_build - https://godotengine.org
OpenGL ES 3.0 Renderer: GeForce GT 1030/PCIe/SSE2
Editing project: /home/~myusername~/Godot-games/A (::home::~myusername~::Godot-games::A)
Godot Engine v3.2.3.rc.custom_build - https://godotengine.org
~/.../godot-3.2/bin >>> OpenGL ES 3.0 Renderer: GeForce GT 1030/PCIe/SSE2
handle_crash: Program crashed with signal 11
Dumping the backtrace. Please include this when reporting the bug on https://github.com/godotengine/godot/issues
[1] /usr/lib/libc.so.6(+0x3d6a0) [0x7f154af0c6a0] (??:0)
[2] /usr/lib/libnvidia-glcore.so.450.66(+0xee6365) [0x7f154311d365] (??:0)
[3] /usr/lib/libnvidia-glcore.so.450.66(+0xee75fc) [0x7f154311e5fc] (??:0)
[4] /usr/lib/libnvidia-glcore.so.450.66(+0xb06282) [0x7f1542d3d282] (??:0)
[5] /usr/lib/libnvidia-glcore.so.450.66(+0xb064fd) [0x7f1542d3d4fd] (??:0)
[6] /usr/lib/libnvidia-glcore.so.450.66(+0xb08f2c) [0x7f1542d3ff2c] (??:0)
[7] RasterizerSceneGLES3::initialize() (/home/~myusername~/godot-3.2/drivers/gles3/rasterizer_scene_gles3.cpp:5092)
[8] RasterizerGLES3::initialize() (/home/~myusername~/godot-3.2/drivers/gles3/rasterizer_gles3.cpp:193 (discriminator 4))
[9] VisualServerRaster::init() (/home/~myusername~/godot-3.2/servers/visual/visual_server_raster.cpp:139)
[10] VisualServerWrapMT::init() (/home/~myusername~/godot-3.2/servers/visual/visual_server_wrap_mt.cpp:124)
[11] OS_X11::initialize(OS::VideoMode const&, int, int) (/home/~myusername~/godot-3.2/platform/x11/os_x11.cpp:594)
[12] Main::setup2(unsigned long) (/home/~myusername~/godot-3.2/main/main.cpp:1263)
[13] Main::setup(char const*, int, char**, bool) (/home/~myusername~/godot-3.2/main/main.cpp:1207)
[14] /home/~myusername~/godot-3.2/bin/godot.x11.tools.64(main+0xe1) [0x14226c7] (/home/~myusername~/godot-3.2/platform/x11/godot_x11.cpp:49)
[15] /usr/lib/libc.so.6(__libc_start_main+0xf2) [0x7f154aef7152] (??:0)
[16] /home/~myusername~/godot-3.2/bin/godot.x11.tools.64(_start+0x2e) [0x142252e] (??:?)
-- END OF BACKTRACE --

Same issue here, exactly the same setup (GT 1030), no idea how to deal with it. Reverting to the version 440 of the driver is easy and for now it's my workaround.

Could you please try and run nvidia-bug-report.sh with 450.66 drivers enabled and provide me with the generated nvidia-bug-report.log.gz file?
Instructions are here: https://forums.developer.nvidia.com/t/if-you-have-a-problem-please-read-this-first/27131
It will help with reporting the issue to nvidia.

@pouleyKetchoupp Sure, my pleasure. I just submitted the data to the nvidia ticketed you liked to =]

I had the exact same problem, but letting Kubuntu's Driver Manager install version 455 solved it.

I'll close this as nobody else has been able to reproduce this recently. Please comment (with the issue template filled) if you can still reproduce this.

@Calinou I think you forgot to close the issue


Add Code Owners

Contributing to the Azure SDK
Please see our CONTRIBUTING.md if you are not familiar with contributing to this repository or have questions.
For specific information about pull request etiquette and best practices, see this section.

/check-enforcer override


encoding/json: optimize isValidNumber

isValidNumber() performance can be optimized by avoiding substring creation in for loop.
benchstat oldBench.txt newBench.txt
name             old time/op    new time/op    delta
NumberIsValid-8    39.3ns ± 1%    28.1ns ± 4%  -28.53%  (p=0.000 n=9+10)

name             old alloc/op   new alloc/op   delta
NumberIsValid-8     0.00B          0.00B          ~     (all equal)

name             old allocs/op  new allocs/op  delta
NumberIsValid-8      0.00           0.00          ~     (all equal)

Duplicate of https://go-review.googlesource.com/c/go/+/425877


Bundlesize increase too much after TS

<EMAIL_ADDRESS>

Fix on<EMAIL_ADDRESS>Seems 4.0.2 is polluted by Babel


callback question

hello
I want to know FormValidator("",[],function(errors){}) callback triggertime .
it's after validation(A callback will always be executed after validation.)
and before form submit?
I find If submit button click fast and more
the callback is not correctl execute
see demo by C# MVC4
use chrome55 broswer
MvcApplication1.zip
Thankyou

sorry today  I can't Reproduce


Ninja can't find libsecp256k1.a for Android

Hi, I followed the setup instructions provided and I seem to encounter a problem with the generated Ninja files. I'm trying to use the tap protocol for a Flutter plugin and consistently run into the same issue. The error I receive for the arm64-v8a and x86_64 abi's is as follows:
> Task :cktap_protocol:buildCMakeDebug[arm64-v8a] FAILED
C/C++: ninja: error: '/home/poops/Programming/Breez/cktap-protocol-flutter/contrib/tap-protocol/contrib/bitcoin-core/src/secp256k1/build/android/arm64-v8a/lib/libsecp256k1.a', needed by '/home/poops/Programming/Breez/cktap-protocol-flutter/example/build/cktap_protocol/intermediates/cxx/Debug/686p6u6f/obj/arm64-v8a/libcktap_protocol_plugin.so', missing and no known rule to make it

> Task :cktap_protocol:buildCMakeDebug[x86_64] FAILED
C/C++: ninja: error: '/home/poops/Programming/Breez/cktap-protocol-flutter/contrib/tap-protocol/contrib/bitcoin-core/src/secp256k1/build/android/x86_64/lib/libsecp256k1.a', needed by '/home/poops/Programming/Breez/cktap-protocol-flutter/example/build/cktap_protocol/intermediates/cxx/Debug/686p6u6f/obj/x86_64/libcktap_protocol_plugin.so', missing and no known rule to make it

Here's the configure step for arm64-v8a where you can see the libsecp256k1 build script does run:
> Task :cktap_protocol:configureCMakeDebug[arm64-v8a]
C/C++: debug|arm64-v8a :CMake Warning at /home/poops/.dev/android-studio/ndk/22.1.7171670/build/cmake/android.toolchain.cmake:449 (message):
C/C++: debug|arm64-v8a :  An old version of CMake is being used that cannot automatically detect
C/C++: debug|arm64-v8a :  compiler attributes.  Compiler identification is being bypassed.  Some
C/C++: debug|arm64-v8a :  values may be wrong or missing.  Update to CMake 3.19 or newer to use
C/C++: debug|arm64-v8a :  CMake's built-in compiler identification.
C/C++: debug|arm64-v8a :Call Stack (most recent call first):
C/C++: debug|arm64-v8a :  .cxx/Debug/686p6u6f/arm64-v8a/CMakeFiles/3.18.1-g262b901/CMakeSystem.cmake:6 (include)
C/C++: debug|arm64-v8a :  CMakeLists.txt:3 (project)
C/C++: debug|arm64-v8a :configure.ac:36: warning: The macro `AC_PROG_CC_C89' is obsolete.
C/C++: debug|arm64-v8a :configure.ac:36: You should run autoupdate.
C/C++: debug|arm64-v8a :./lib/autoconf/c.m4:1652: AC_PROG_CC_C89 is expanded from...
C/C++: debug|arm64-v8a :configure.ac:36: the top level
C/C++: debug|arm64-v8a :configure.ac:15: installing 'build-aux/compile'
C/C++: debug|arm64-v8a :configure.ac:9: installing 'build-aux/missing'
C/C++: debug|arm64-v8a :Makefile.am: installing 'build-aux/depcomp'
C/C++: debug|arm64-v8a :configure: WARNING: using cross tools not prefixed with host triplet
C/C++: debug|arm64-v8a :configure: WARNING: using cross tools not prefixed with host triplet
C/C++: debug|arm64-v8a :configure: WARNING: using cross tools not prefixed with host triplet
C/C++: debug|arm64-v8a :configure: WARNING: using cross tools not prefixed with host triplet

Here's the CMakeLists.txt for my project:
cmake_minimum_required(VERSION 3.16)

project(cktap_protocol_plugin)

add_library(cktap_protocol_plugin

        # Sets the library as a shared library.
        SHARED

        # Provides a relative path to your source file(s).
        src/main/cpp/test.cpp)

execute_process(COMMAND "${CMAKE_SOURCE_DIR}/cmake_requirements.sh" "${CMAKE_ANDROID_NDK}")

add_subdirectory("${CMAKE_SOURCE_DIR}/../contrib/tap-protocol" "${CMAKE_SOURCE_DIR}/../contrib/tap-protocol/build")
target_link_libraries("${PROJECT_NAME}" PUBLIC  tap-protocol)

And the script being called by my CMakeLists.txt:
#!/bin/bash

scriptDir=`dirname '$0'`
echo $0
echo $1

pushd "$scriptDir/../contrib/tap-protocol"
ANDROID_NDK="$1" tools/build_android.sh
popd

Proof that the files exists:
poops@ramuh ~/P/B/c/android (develop)> find ../ -type f -name libsecp256k1.a -exec readlink -f {} \;
/home/poops/Programming/Breez/cktap-protocol-flutter/contrib/tap-protocol/contrib/bitcoin-core/src/secp256k1/build/android/arm64-v8a/lib64/libsecp256k1.a
/home/poops/Programming/Breez/cktap-protocol-flutter/contrib/tap-protocol/contrib/bitcoin-core/src/secp256k1/build/android/armeabi-v7a/lib/libsecp256k1.a
/home/poops/Programming/Breez/cktap-protocol-flutter/contrib/tap-protocol/contrib/bitcoin-core/src/secp256k1/build/android/x86-64/lib64/libsecp256k1.a
/home/poops/Programming/Breez/cktap-protocol-flutter/contrib/tap-protocol/contrib/bitcoin-core/src/secp256k1/build/android/x86/lib/libsecp256k1.a

Oh wow, sorry I see the problem! I've been looking at this for a while and compared the paths of the 32-bit libraries so I thought the files were just being ignored. It seems the script outputs the 64-bit libraries in a lib64 folder but Ninja looks for a lib folder. I'll fix the issue a submit a pull request.


When displaying Google Maps on the second or subsequent FlutterEngine generated by FlutterEngineGroup, the memory is not released.

Is there an existing issue for this?

[X] I have searched the existing issues
[X] I have read the guide to filing a bug

Steps to reproduce

After initializing FlutterEngineGroup, generate the first FlutterEngine to display the initial FlutterViewController.
Transition from the initially displayed FlutterViewController to a native ViewController.
Generate the second FlutterEngine using FlutterEngineGroup and transition from the native ViewController to the second FlutterViewController.

Display Google Maps using google_maps_flutter on the second FlutterViewController.

Pop the second FlutterViewController and return to the previous ViewController.

Expected results
Memory is released when the second FlutterViewController is popped.
Actual results
Memory is not released when the second FlutterViewController is popped, and if this process is repeatedly executed, it can result in an OOM (Out of Memory) crash.
Code sample

AppDelegate.swift
import UIKit
import Flutter
import GoogleMaps

@UIApplicationMain
@objc class AppDelegate: FlutterAppDelegate {
    let engines = FlutterEngineGroup(name: "multiple-flutters", project: nil)

    override func application(
        _ application: UIApplication,
        didFinishLaunchingWithOptions launchOptions: [UIApplication.LaunchOptionsKey: Any]?
    ) -> Bool {
        GMSServices.provideAPIKey("Your API Key.")

        window = UIWindow(frame: UIScreen.main.bounds)
        let navigationController = UINavigationController(rootViewController: MyFlutterViewController(withEntrypoint: nil))
        window?.rootViewController = navigationController
        window?.makeKeyAndVisible()
        return super.application(application, didFinishLaunchingWithOptions: launchOptions)
    }
}

MyFlutterViewController
import Flutter

class MyFlutterViewController: FlutterViewController {

    required init(coder aDecoder: NSCoder) {
        fatalError("init(coder:) has not been implemented")
    }

    init(withEntrypoint entryPoint: String?) {
        let appDelegate: AppDelegate = UIApplication.shared.delegate as! AppDelegate
        let newEngine = appDelegate.engines.makeEngine(withEntrypoint: entryPoint, libraryURI: nil)
        GeneratedPluginRegistrant.register(with: newEngine)
        super.init(engine: newEngine, nibName: nil, bundle: nil)
      }

    override func viewDidLoad() {
        super.viewDidLoad()

        let methodChannel = FlutterMethodChannel(
            name: "methodChannel",
            binaryMessenger: self.binaryMessenger
        )
        methodChannel.setMethodCallHandler({(call: FlutterMethodCall, result: @escaping FlutterResult) -> Void in
            switch call.method {
            case "transitionToNativeScreen":
                let viewController = MyViewController()
                self.navigationController?.pushViewController(viewController, animated: true)
            default:
                result(FlutterMethodNotImplemented)
            }
        })
    }

    override func viewWillAppear(_ animated: Bool) {
        super.viewWillAppear(animated)
        self.navigationController?.setNavigationBarHidden(true, animated: true)
    }
}

MyViewController.swift
import UIKit

class MyViewController: UIViewController {

    override func viewDidLoad() {
        super.viewDidLoad()
        view.backgroundColor = .white

        let button = UIButton(type: .system)
        button.setTitle("Show Flutter Screen", for: .normal)
        button.addTarget(self, action: #selector(buttonTapped(_:)), for: .touchUpInside)
        self.view.addSubview(button)

        button.translatesAutoresizingMaskIntoConstraints = false
        button.centerXAnchor.constraint(equalTo: self.view.centerXAnchor).isActive = true
        button.centerYAnchor.constraint(equalTo: self.view.centerYAnchor).isActive = true
    }

    override func viewWillAppear(_ animated: Bool) {
        super.viewWillAppear(animated)
        self.navigationController?.setNavigationBarHidden(false, animated: true)
    }

    @objc func buttonTapped(_ sender: Any) {
        let viewController = MyFlutterViewController(withEntrypoint: "secondMain")
        self.navigationController?.pushViewController(viewController, animated: true)
    }
}

main.dart
import 'package:flutter/material.dart';
import 'package:flutter/services.dart';
import 'package:google_maps_flutter/google_maps_flutter.dart';

void main() {
  runApp(const MainApp());
}

@pragma('vm:entry-point')
void secondMain() {
  runApp(const MapApp());
}

class MainApp extends StatelessWidget {
  const MainApp({Key? key}) : super(key: key);

  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      title: 'Flutter Demo',
      theme: ThemeData(
        primarySwatch: Colors.blue,
      ),
      home: const MainPage(),
    );
  }
}

class MainPage extends StatelessWidget {
  const MainPage({Key? key}) : super(key: key);

  static const methodChannel = MethodChannel('methodChannel');

  @override
  Widget build(BuildContext context) {
    return Scaffold(
      appBar: AppBar(
        title: const Text('MainPage'),
      ),
      body: Center(
        child: TextButton(
          child: const Text('Transition To Native Screen'),
          onPressed: () async {
            await methodChannel.invokeMapMethod('transitionToNativeScreen');
          },
        ),
      ),
    );
  }
}

class MapApp extends StatelessWidget {
  const MapApp({Key? key}) : super(key: key);

  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      title: 'Flutter Demo',
      theme: ThemeData(
        primarySwatch: Colors.blue,
      ),
      home: const MapPage(),
    );
  }
}

class MapPage extends StatelessWidget {
  const MapPage({Key? key}) : super(key: key);

  @override
  Widget build(BuildContext context) {
    return Scaffold(
      appBar: AppBar(
        title: const Text('Map Page'),
        leading: BackButton(
          onPressed: () => SystemNavigator.pop(animated: true),
        ),
      ),
      body: const GoogleMap(
        initialCameraPosition: CameraPosition(
          target: LatLng(37.42796, -122.08574),
          zoom: 14.4746,
        ),
      ),
    );
  }
}

Screenshots or Video

Screenshot of memory usage

Displaying MyFlutterViewController consumes memory each time.
Memory is not released even when returning to the previous screen.

Flutter Doctor output
Doctor output
Doctor summary (to see all details, run flutter doctor -v):
[✓] Flutter (Channel stable, 3.7.3, on macOS 12.6.1 21G217 darwin-arm64, locale ja-JP)
[✓] Android toolchain - develop for Android devices (Android SDK version 33.0.2)
[✓] Xcode - develop for iOS and macOS (Xcode 14.2)
[✓] Chrome - develop for the web
[✓] Android Studio (version 2022.1)
[✓] VS Code (version 1.78.2)
[✓] Connected device (3 available)
[✓] HTTP Host Availability

• No issues found!

I think this issue might be related, but I'm not sure. so could you please confirm if it is related?
https://github.com/flutter/flutter/issues/77621

I think the linked issue above is similar to what you're describing here. Using Google Maps as a way to make the issue more noticeable as it uses more resources than common/normal views in a FlutterViewController (see this). You can try to remove the maps plugin and check this if possible.
So I will close this issue in favor of https://github.com/flutter/flutter/issues/77621. Please follow up on that issue for further updates. You can leave there your comment and react an upvote to the original comment will help to raise the issue. Thank you!


Keyed File Browser changes

[x] Change name from FileExplorer to KeyedFileBrowser, to match react component's name
[ ] Option for Dir selection
[ ] Include documentation

Option for Dir selection

make onSelectFolder return the selected folder to the selectedPath props


No arguments generated for bind args within transaction

No arguments are generated for the bind-args within a transaction.
For example:
insertStop:
BEGIN;
    INSERT INTO node(type) VALUES("stop");
    INSERT INTO stop(id, stopId) VALUES(last_insert_rowId(), :stopId);
COMMIT;

Generates:
fun insertStop()

Instead of:
fun insertStop(stopId: String)

Do the generated methods from this even contain the actual query?

This is probably due to https://github.com/square/sqldelight/issues/809
The parser seems to stop after the first statement (BEGIN;).