Are these functions useful to add to common-functions.sh?

I have long had a personal Nautilus script that allows me to right-click on a directory and pull out all of the media files to the parent directory. It is sort of like #26, except I only want certain subdirectory files to be pulled out.
Since I started using this project, I have tried to rewrite all of my Nautilus scripts to use the features and functions of this project. Functions like _validate_file_mime_parallel and _run_task_parallel have been very helpful in rebuilding it and even speeding things up.
However, I ran into two trouble spots that I couldn't figure out how to solve with the built-in functions, so I made my own. And the ultimate question is, are these functions useful enough for me to contribute to the project, or not?
Function 1 - _validate_file_ext_parallel
Some file types I'm interested in don't have good MIME type reporting from file. For example, they will only show text/plain, application/octet-stream, or application/zip. These include...

cbz
cbr
srt
xspf

So I copied the _validate_file_mime_parallel function and sub-function _validate_file_mime, and changed them to work with file extensions. The key difference being...
    if [[ -n "${par_select_ext}" ]]; then
        local file_ext=""
        file_ext=$(_get_filename_extension "${input_file}")
        grep --quiet --ignore-case --perl-regexp "(${par_select_ext})" <<<"${file_ext}" || return
    fi

Question 1:  Would you appreciate the contribution of those functions to common-functions.sh?
Function 2 - _get_files_in_dirs
Because the only thing being pulled into $NAUTILUS_SCRIPT_SELECTED_URIS is the directory name(s) I right-clicked on, I needed a way to get the names of files in that directory. I found no function to do that, so I created my own.
_get_files_in_dirs() {
    local input_dirs=$1
    local output_files=""
    for input_dir in ${input_dirs}; do
        output_files+=$( find "${input_dir}" -mindepth 1 -maxdepth 1 -printf "%p${FIELD_SEPARATOR}" )
    done
    printf "%s" "${output_files}"
}

Question 2:  Would you appreciate the contribution of this function to common-functions.sh? If so, I would need to expand my function to be a bit more general (e.g., add a parameter for depth, that kind of thing).
Question 3:  If "yes" to the first two questions, would you like me to submit my script to pull media files out? I would also be willing to create a script for the more general case in #26.

Thank you for sharing your experience and feedback! It’s wonderful to hear how you’ve integrated the project’s features into your workflow. It’s always exciting to see the project being used creatively and effectively.
As for your custom functions, I would absolutely love to see them! Whether or not they get directly incorporated, sharing them could provide valuable insights and inspiration for further development. Feel free to submit them or start a discussion about them—your contributions are greatly appreciated.
Let me first explain the _get_files function's logic before answering your questions. The function processes and validates the input file list through stages:

Stage 1: _validate_file_preselect
This stage allows for validation of file attributes such as extensions, file type (e.g., file or directory), and can also expand directories to include their contents.

Stage 2: _validate_file_mime_parallel
Here, files are filtered based on their MIME types. This function can be used to include or exclude files depending on their MIME type.

Stage 3: _validate_conflict_filenames
In this final stage, the function checks for conflicts where multiple selected files share the same base name (e.g., test.jpg and test.png).

Now, regarding your functions:

Function 1 - _validate_file_ext_parallel
This function appears to overlap with the validation capabilities already provided by _validate_file_preselect. The _validate_file_preselect function allows filtering filenames using a list of extensions, which seems to achieve the same goal.

Question 1: Would you appreciate the contribution of these functions to common-functions.sh?

I’d be interested in seeing a practical example where this function is necessary. Could you provide an example use case? If I understood correctly, it seems possible to achieve the same functionality by leveraging the existing parameters in _validate_file_preselect, making the implementation of _validate_file_ext_parallel redundant.

Function 2 - _get_files_in_dirs

Because the only thing being pulled into $NAUTILUS_SCRIPT_SELECTED_URIS is the directory name(s) I right-clicked on, I needed a way to get the names of files in that directory. I found no function to do that, so I created my own.

It is possible to use the function _get_files with the parameter par_recursive=true. In this way, it is possible to get the names of files in that directory.
See some script examples that use this parameter:

List largest files
List all hashes

Question 2: Would you appreciate the contribution of this function to common-functions.sh? If so, I would need to expand my function to be a bit more general (e.g., add a parameter for depth, that kind of thing).

Before addressing your question, could you provide a practical example where this function would be necessary? Understanding a real use case would help clarify its utility and how it might complement or improve upon the existing functionality.
That said, I truly appreciate your willingness to contribute and your thoughtfulness in considering how to make the function more general, such as by adding parameters for depth. These enhancements could make it more versatile and valuable to the project.

Question 3: If "yes" to the first two questions, would you like me to submit my script to pull media files out? I would also be willing to create a script for the more general case in #26.

I would really love to see your scripts. They could be incredibly helpful in generating new ideas and expanding the possibilities of the project. If you could share them via a fork, it would be much easier to review the new functionalities and better understand their potential applications.
Regarding case #26, I don’t think it would be difficult to implement using the functions already available. The reason for the delay in my response is that I’m still considering whether this functionality could be useful to a broader audience and address common, frequent use cases. This approach is intended to avoid creating scripts that might be too specific and have limited applicability.

Thank you again for your thoughtful feedback and willingness to contribute. I’m looking forward to reviewing your scripts and exploring how they can enrich the project!

Hi
You're right. It looks like _validate_file_preselect seems to work in place of both of my functions. With one difference.
As written, the function either finds files with the provided extension(s) infinitely deep (par_recursive=true) or only in input_files.
My preference for this use case is to set -maxdepth 1. If I could pass in -maxdepth as a parameter, that would be great.
As a test, I replaced the if statement at https://github.com/cfgnunes/nautilus-scripts/blob/5fa968a7a63d96157b79ed9768825b6dbda866ae/common-functions.sh#L2030 with the following. It should work as normal AND allow for -maxdepth to be configurable. Right now it is limited to 1 digit, but I'll expand the case statement if desired.
    case $par_recursive in
        [[:digit:]]) find_command+=" -maxdepth $par_recursive" ;;
        true) ;;
        *) find_command+=" -maxdepth 0" ;;
    esac

I ran my scripts with this change as well as a few of the other scripts you have, and it worked okay.
By the way, is there some reason you don't use -printf "%p${FIELD_SEPARATOR}" in the _validate_file_preselect find command? It would save the later fork to tr.
https://github.com/cfgnunes/nautilus-scripts/blob/5fa968a7a63d96157b79ed9768825b6dbda866ae/common-functions.sh#L2052

Hi @KlfJoat !
Thanks for sharing this modification. I've done a commit in: https://github.com/cfgnunes/nautilus-scripts/commit/ca31c3fcca3e5b2e4ea77fa497fce119ee5c7b48 that add this modification. Could you test if its ok? Now the -maxdepth is configurable.

By the way, is there some reason you don't use -printf "%p${FIELD_SEPARATOR}" in the _validate_file_preselect find command? It would save the later fork to tr.

https://github.com/cfgnunes/nautilus-scripts/blob/5fa968a7a63d96157b79ed9768825b6dbda866ae/common-functions.sh#L2052
In this line, I tried using -printf "%p${FIELD_SEPARATOR}", but I encountered issues in some cases. For some reason, the $FIELD_SEPARATOR (set to \r) didn’t work as expected inside the find command with -printf. If you’re able to identify the problem and help resolve it, that would be awesome! I suspect the issue might be related to the \r symbol, but I’m not entirely sure.

Thanks, your update works just fine.
You said you were interested in the script I created. Here are the operative parts. My first version, before integrating with this project, was a script with a bunch of simple mv *.ext .. lines in it. Not even looping over a list of extensions or multiple extensions on one line; multiple mv commands on separate lines. (despite me having used for loops for 25+ years 😂)
_main() {
    local input_files=""
    local input_dirs=""
    local output_dir=""

    _display_wait_box "2"

    # The name of the dir to move files FROM
    input_dirs=$(_get_files "par_type=directory; par_recursive=false")

    # All of the files in $inputdirs
    input_files=$( _validate_file_preselect "${input_dirs}" "file" "" "" "1" )

    ### Craft $input_files from MIME types and extensions
    # Create $input_files from MIME types
    input_files=$(_validate_file_mime_parallel "${input_files}" "video/|audio/|image/|application/x-ms-reader|application/epub|application/vnd.rn-realmedia|text/vtt|application/x-mobipocket-ebook|application/vnd.ms-htmlhelp|application/pdf|application/x-shockwave-flash|text/rtf|application/vnd.oasis.opendocument|application/vnd.ms-office")

    # $FIELD_SEPARATOR ('\r') seems to get stripped from the final item in the variable. Add it back when there is something in there and the last char is not '\r'.
    if [[ -n ${input_files} ]] && [[ ${input_files:-1:1} != $(printf %s "$FIELD_SEPARATOR") ]]; then input_files+=$(printf %s "$FIELD_SEPARATOR"); fi

    # Add to $input_files from file extensions
    # Do this because sometimes, the mime type isn't exact enough.
    # For example, 'cbz' files only show as 'application/zip' or 'ssa' subtitles show as 'application/x-wine-extension-ini'???
    #
    # Extensions and what they're for...
# <snipped>
    #
    # TODO: Validate case insensitivity

    input_files+=$(_validate_file_preselect "${input_dirs}" "file" "" "cbz|cbr|pdb|azw3|f4v|mp4v|viv|srt|ass|ssa|idx|sub|smi|dfxp|lrc|xspf|afpk" "1")

    # In case I added too many '\r's above to the end of the file list
    input_files=$(_str_remove_empty_tokens "${input_files}")

    # The name of the dir to move files TO
    output_dir=$(_get_output_dir "par_use_same_dir=true")

    ### Execute the function '_main_task' for each file in parallel.
    _run_task_parallel "${input_files}" "${output_dir}"
    _close_wait_box

}

_main_task() {
    local input_file=$1
    local output_dir=$2
    local output_file=""
    local std_output=""

    output_file=$( _get_output_filename "${input_file}" "${output_dir}" "par_extension_opt=preserve" )

    std_output=$(_move_file "rename" "${input_file}" "${output_file}" 2>&1)
    _check_output "$?" "${std_output}" "${input_file}" "${output_file}" || return 1
}

Also, if you're serious about wanting feedback and contributions, I've got some other questions, comments, and ideas. I'll open other Issues for those.

Hi @KlfJoat !
Your script is very good. However, I believe your function _main can be simplified. Instead of calling the functions _validate_file_preselect and _validate_file_mime_parallel, it would be possible to pass all the parameters at once to the _get_files function, since this function already calls these two internally.
For example:
input_dirs=$(_get_files "par_type=file;
                         par_recursive=1;
                         par_select_mime='video/|audio/|image/|application/x-ms-reader';
                         par_select_extension='cbz|cbr|pdb|azw3|f4v|mp4v|viv|srt|ass"
)

In this case, the parameters par_select_mime and par_select_extension acts as an AND operation. To make them work as an OR operation, we would need to modify the _get_files function.
It is interesting to avoid calling the functions _validate_file_preselect and _validate_file_mime_parallel externally, as they are resource-intensive and can significantly delay the task processing.

Finally, I'm interested in hearing your questions and comments. I'd also love to hear your ideas. Feel free to open the other issues, and I'll be happy to engage with them! 🙌

To make them work as an OR operation, we would need to modify the _get_files function.

I just took a look at it, and it does not look like an easy modification.
_validate_file_preselect is the thing that returns all files inside a directory. While it does that, it also filters by extension.
Looks like I would need to find all files, then run the names through a separate extension filter, and then through the MIME filter.
I'll take a closer look later tonight or tomorrow.

About issue #26:
I’ve developed an experimental script that you can find here:  Flatten a Nested Directory
Could you test it and share your feedback?
Key features:

The script ensures no files are overwritten if they have the same name, to prevent data loss.
It also generates an undo-flatten.sh script, allowing you to easily revert the flattening process.


configurable launcher

With MS-Store-based WSL, the launcher is not bash.exe anymore.
It would be useful to add an option to set the desired launcher, e.g. (e.g. -l %LOCALAPPDATA%/Microsoft/WindowsApps/ubuntu.exe).
Another open issue is to find out which incarnations of WSL exist on the system (apparently now multiple installations can coexist, and other distributions than Ubuntu are under preparation).
See wsltty/issues#52.

@rprichard, do you have an idea how to explicitly launch the distros in either the current directory or the home directory, without having to tweak the WSL default distro? See the discussion starting from https://github.com/Microsoft/BashOnWindows/issues/2348#issuecomment-317766221.

I started on a --wsl-launcher option in the wsl-launcher branch.  It doesn't work because bash.exe and the new Store ubuntu.exe parse their command lines differently.
e.g.:
C:\Data>bash.exe -c ls /
LogFiles

C:\Data>bash.exe -c "ls /"
bin  boot  dev  etc  home  init  lib  lib64  media  mnt  opt  proc  root  run  sbin  snap  srv  sys  tmp  usr  var

C:\Data>bash.exe -c 'ls /'
bin  boot  dev  etc  home  init  lib  lib64  media  mnt  opt  proc  root  run  sbin  snap  srv  sys  tmp  usr  var

C:\Data>ubuntu.exe -c ls /
bin  boot  dev  etc  home  init  lib  lib64  media  mnt  opt  proc  root  run  sbin  snap  srv  sys  tmp  usr  var

C:\Data>ubuntu.exe -c "ls /"
bin  boot  dev  etc  home  init  lib  lib64  media  mnt  opt  proc  root  run  sbin  snap  srv  sys  tmp  usr  var

C:\Data>ubuntu.exe -c 'ls /'
/bin/bash: ls /: No such file or directory

Should wslbridge search the PATH for the given program, e.g so that --wsl-launcher ubuntu works?
I wasn't sure it made sense to allocate -l as the WSL launcher option, but -l ubuntu is pretty convenient, so maybe it does.
bash.exe --help shows the help page for WSL's GNU bash, whereas ubuntu.exe --help is an error.  ubuntu.exe /? shows the help page for ubuntu.exe, and it doesn't mention a -c option.  I'm guessing that ubuntu.exe -c ... does the same thing as ubuntu.exe run ....

I agree with your hidden statement that this is all very chaotic and undocumented.
To find the launcher, I guess it's sufficient to look in %LOCALAPPDATA%\Microsoft\WindowsApps (that's also included in the PATH). However, what that means for other users, given that the "app" itself is installed in %PROGRAMFILES%\WindowsApps, I do not know. Maybe you can look up there as well (although the folder is not readable for normal users).
About parameter handling, our main issue is the question how to set the start directory. I would happily leave all other questions of parameter usage to users who want to launch WSL apps directly.

Please check https://github.com/Microsoft/BashOnWindows/issues/2348#issuecomment-318053337;
while this syntax is one of the gruesome Microsoft cryptics, if it works, that should be fine for us.
I can provide those cryptics in the shortcuts and .bat scripts I generate, or you could optionally look them up in the registry by the distro name.

Maybe I should add a --distro-guid option, and if that option is specified, wslbridge should run wsl.exe instead of bash.exe.  With that design, wslbridge would understand that wsl.exe and bash.exe represent command lines differently and do the correct escaping for each.
I need to study what that escaping is.  I wonder if the differences were intentional, or will the next WSL distro cause problems again?
An alternative is to have the wslbridge frontend thoroughly escape shell control characters (spaces, quotes, slashes, etc) and make little-to-no assumptions about how bash.exe and wsl.exe handle command lines.

wsl.exe instead of bash.exe

I've just tried wsl {5131dac2-195d-4720-bdf5-846c2bf311b5} etc and it works for either wsl or bash alike. Both also accept ~ and work as useful.
So a possible wslbridge option (short preferred) could be like
-l {5131dac2-195d-4720-bdf5-846c2bf311b5} (l for launch), or if you like, -l Ubuntu and you could enumerate HKEY_CURRENT_USER\Software\Microsoft\Windows\CurrentVersion\Lxss to match DistributionName=Ubuntu and find the key (as a convenience for others perhaps; the new wsltty installer does the enumeration already and would not need that). The two ways could simply be distinguished by the starting '{'.
I do not see what problem with escaping there is, it doesn't seem to be important for wsltty.

it works for either wsl or bash alike

However, bash accepts a -c option while wsl does not.
Also the order of options used is important; first {...}, then ~, then -c.

I pushed a commit to the wsl-launcher branch that replaces --wsl-launcher with a --distro-guid argument.  Let me know if it works for you.
I think I'm open to having wslbridge scan HKEY_CURRENT_USER\Software\Microsoft\Windows\CurrentVersion\Lxss for a list of distributions.  Maybe it'd allow something like wslbridge -d Ubuntu -t bash --login.
Conceivably, there could be single -d / --distro argument that allows either a distro name or a GUID.
The current GUID parsing is flexible -- see the canonicalGuid function.  Letters can be lower or upper case, and it can be surrounded by braces or not.  I assume mintty would simply pass the value from the registry.
I wonder if two distributions can have the same name (but different GUIDs).

It looks like wsl.exe doesn't do the Press any key to continue... prompt for the Cannot launch because another instance is running elevated. error.  Maybe wslbridge's press-return functionality could be disabled for wsl.exe.

@mintty  Oh, I didn't see your comments before I posted.  Maybe the fix is much simpler, then.  wslbridge continues using bash.exe unconditionally, but adds a GUID as the first argument if it's specified.

Ok, I pushed the simpler --distro-guid implementation to the distro-guid branch.  I don't think I'm going to work on a convenient argument option for now.

Thanks a lot. Just uploaded wsltty updates to support the new WSL distribution model.
No release yet (referring to mintty-master and wslbridge/branch/commit).

Thank you again. I made a release meanwhile, referring to
wslbridge-cb22e3f6f989cefe5b6599d3c04422ded74db664 which is within the distro-guid branch.
I'd close this issue once it's merged to the main branch and released :)

The --distro-guid option is now released in wslbridge 0.2.4.

Great, thanks!


Uninitialized efd field in alloc_handle() leads to undefined behavior

Describe the bug
https://github.com/falcosecurity/libs/blob/56b6e591cf8bf6849c27adfccc1557835daa1529/userspace/libscap/engine/bpf/scap_bpf.c#L118-L135
https://github.com/falcosecurity/libs/blob/56b6e591cf8bf6849c27adfccc1557835daa1529/userspace/libscap/engine/bpf/attached_prog.c#L215-L224
In current code, alloc_handle() doesn't initialize engine->m_attached_progs[j].efd to -1, which leads to detach_bpf_prog() closing those file descriptors which is equal to 0 unexpectedly.

How to reproduce it
The bug was first found in latest version of Falco. Falco will monitor the directories stored rules using inotify and reload rules automatically when modifications are made. To reproduce this bug, just run the latest version of Falco and modify the rules specified in configuration file. Falco would restart and reload rules at the first time. Then we'll get the error message Failed read with inotify handler, shutting down watcher.... and the monitor doesn't work anymore, Falco wouldn't reload rules if we make any modification. If we check entries in /proc/[PID]/fd, we couldn't find any inotify file descriptor.

Expected behaviour

Screenshots

Environment

Falco version: commit 3ff2bb5c2b306c1f81585e53477e1585695b0dc8.

System info:

{
  "machine": "x86_64",
  "nodename": "magma.localdomain",
  "release": "4.18.0-477.10.1.el8_8.x86_64",
  "sysname": "Linux",
  "version": "#1 SMP Wed Apr 5 13:35:01 EDT 2023"
}

Cloud provider or hardware configuration:
OS:

NAME="Red Hat Enterprise Linux"
VERSION="8.8 (Ootpa)"
ID="rhel"
ID_LIKE="fedora"
VERSION_ID="8.8"
PLATFORM_ID="platform:el8"
PRETTY_NAME="Red Hat Enterprise Linux 8.8 (Ootpa)"
ANSI_COLOR="0;31"
CPE_NAME="cpe:/o:redhat:enterprise_linux:8::baseos"
HOME_URL="https://www.redhat.com/"
DOCUMENTATION_URL="https://access.redhat.com/documentation/en-us/red_hat_enterprise_linux/8"
BUG_REPORT_URL="https://bugzilla.redhat.com/"

REDHAT_BUGZILLA_PRODUCT="Red Hat Enterprise Linux 8"
REDHAT_BUGZILLA_PRODUCT_VERSION=8.8
REDHAT_SUPPORT_PRODUCT="Red Hat Enterprise Linux"
REDHAT_SUPPORT_PRODUCT_VERSION="8.8"

Kernel: Linux magma.localdomain 4.18.0-477.10.1.el8_8.x86_64 #1 SMP Wed Apr 5 13:35:01 EDT 2023 x86_64 x86_64 x86_64 GNU/Linux

Installation method: from source

Additional context

This stack trace is at the first close(0) function after inotify_init() in falco::app::restart_handler::start() when reloading rules.

Hi!

In current code, alloc_handle() doesn't initialize engine->m_attached_progs[j].efd to -1, which leads to detach_bpf_prog() closing those file descriptors which is equal to 0 unexpectedly.

This is a great catch; thank you very much for spending the time to discover this issue.
Would you be open to patch it through a PR?
We are approaching a 0.36.2 patch release for Falco; this fix would be great!

/milestone 0.13.4


Container Console works only in non Swarm enviroment

Dear support,
i've two portainer servers,
one in a swarm envirorment, one in a standalone mode.
Same version of portainer 2.15.1
Same distro OS
Portainer in standalone let me use "Exec console"
Portainer in Swarm leave the "Exec console to timeout".
what i can check to fix it?

@andreaconsadoriw
Thank you for the information.  I am going to further investigate.  I will update you as I learn more.
Thanks!

@andreaconsadoriw
Can you post your Portainer docker run install commands for both of those environments?
Thanks!

Or you can just run docker ps -a on Standalone and docker service ls on the Swarm and post.  Thanks!

The working portainer:
docker ps -a | grep portainer
b8351b686a23        portainer/portainer-ce:latest            "/portainer"             4 days ago          Up 4 days               <IP_ADDRESS>:8000->8000/tcp, <IP_ADDRESS>:9000->9000/tcp, 9443/tcp
the non-working portainer:
docker service ls
ID             NAME                  MODE         REPLICAS   IMAGE                           PORTS
mxu11xmevrpe   portainer_agent       global       3/3        portainer/agent:latest
yhp46kvbwr38   portainer_portainer   replicated   1/1        portainer/portainer-ce:latest   *:8000->8000/tcp, *:9000->9000/tcp, *:9443->9443/tcp
The working one has a direct docker connection but through it i can connect console on container over remote docker connected trought the edge agent.

@andreaconsadoriw
Are you trying to exec into the Portainer container?  Or a different container?  Not all containers allow exec console access.
Thanks!

via Swarm portainer i cannot connect to ANY console

@andreaconsadoriw
Are you selecting the Interactive and TTY flags when setting up the container?  Are you able to exec into the container on the CLI outside of Portainer?
Thanks!

on the not swarm envirorment i don't need to change console settings and both works without any issue.
on swarm env even if i activate interactive & TTY never works.
outside the portainer via Linux Bash i can connect to container console.
docker container exec -it 7cac0781fb27 /bin/bash
bash-4.4$

can be a docker swarm networking issue?

@andreaconsadoriw
I am unable to reproduce.  Can you send a screenshot of your Container page?
The Console requires websockets.  Are they open?  And, you may want to check your Swarm networking.
Thanks!

Here my env
If i try to connect to “onetimefiles” container (one where the console works fine from the cli)
It sat forever on “connecting”
@.***
The swarm nodes are on the same subnet and no firewall in the middle
@.***
Console require websocket --> what are the prerequisites?
Da: Tamara Henson @.>
Inviato: giovedì 22 settembre 2022 09:42
A: portainer/portainer @.>
Cc: Andrea Consadori @.>; Mention @.>
Oggetto: Re: [portainer/portainer] Container Console works only in non Swarm enviroment (Issue #7684)
@andreaconsadoriwhttps://whysecurity.urlsand.com/?u=https%3A%2F%2Fgithub.com%2Fandreaconsadoriw&e=400f5e61&h=70223e11&f=n&p=y
I am unable to reproduce. Can you send a screenshot of your Container page?
The Console requires websockets. Are they open? And, you may want to check your Swarm networking.
Thanks!
—
Reply to this email directly, view it on GitHubhttps://whysecurity.urlsand.com/?u=https%3A%2F%2Fgithub.com%2Fportainer%2Fportainer%2Fissues%2F7684%23issuecomment-1254647850&e=400f5e61&h=8d806cd8&f=n&p=y, or unsubscribehttps://whysecurity.urlsand.com/?u=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAHWECNP6PQSRNKMFRRP6DFDV7QET7ANCNFSM6AAAAAAQOEMBHI&e=400f5e61&h=48a18918&f=n&p=y.
You are receiving this because you were mentioned.Message ID<EMAIL_ADDRESS>


Document Sets are Magic 🗂

Article suggestion
Document Sets - and their embrace by your users - are a true sign of SharePoint maturity in your organization.
This article would discuss their creation, changes to them in Modern, and the relationship between metadata in the set vs. the document.  Should provide some sample use cases, and guidance on when/when not to use them.

I want to take this one, but lack clarity on whether Document Sets have a future in Modern. In my GCC tenant, it's sorta half-Classic, half-Modern. Nothing on the Road Map.  Anyone have any info about their future?

It's a fair question. Doc Sets have been partially modernized - which to me is not enough at all. In fact,. we lost some of the main benefits, like customizing the Welcome Page.
Let me see what I can find out - I love the things.

Consider me assigned! Will turn out a first draft in the next few weeks.

I asked in my MVP channels, but it's pre-Ignite, when all the MS folks are under the gun, so no useful replies. Looking forward to what you come up with!


Link not working

Guide to Exploitation of Scenario 1 and other solution is not working currenlty. can u please provide the new link.

Thank you sir for pointing out the issue.
As vulnerable scripts and example directories were moved to the directory "www", link changed to examples and hence issue occurred.
Some other broken links also has been fixed :)
Thank you

Hi @incredibleindishell
I think it's still not working


feat: add bulk execute for mariadb

This is an implementation of https://mariadb.com/kb/en/com_stmt_bulk_execute/
Bulk execute allows reusing the same prepared statement for inserting any number of rows.
It requires an "indicator" before each value, therefore MySqlArguments has changed. Example of usage can be seen in tests.

Closing due to inactivity. Feel free to reopen as a new PR but CI needs to be passing to merge.
IMO, the documentation and method naming needs to make it clear that this feature is only supported by MariaDB, and we need a way to either warn or prevent MySQL users from trying to use it.


Remove version: Ryujinx.Ryujinx version 1.1.1380

Repository has been taken offline
Relevant GitHub organization & project page response with HTTP 404, official download page of the project becomes blank. The package is no longer availalbe for installation.

Resolves #176342

Microsoft Reviewers: Open in CodeFlow

URL: https://github.com/Ryujinx/release-channel-master/releases/download/1.1.1380/ryujinx-1.1.1380-win_x64.zip
Response status code does not indicate success: 404 (Not Found).
(Automated message - build 896)


Remove Announcement model and controller

Its usage is too specific. Should be replaced by Post and Page.

Probably a good idea to keep it. Because it serves a different purpose from Page and Post.

Decided to keep it.


Customer questions in NuGet PackageReference in Visual Studio Project files

https://docs.microsoft.com/en-us/nuget/consume-packages/package-references-in-project-files#comments-container
Five total, dating back to July 22nd.

Bumping to P0 as there are ten open questions (also one in a sidenote).

Gone with the Lyvefire comments


Not using GPU when training NMT model?

Hi, first of all, thank you for providing such a nice library.
I'm currently trying to train NMT model from scratch using fairseq library.  I referred "https://github.com/pytorch/fairseq/blob/master/examples/translation/README.md" in training the transformer model on IWSLT German14 dataset. I managed to get it running, but it seems that my model is not training on GPU. I set CUDA_VISIBLE_DEVICES=0 and checked that the configuration output states "training on 1 GPU". But when I checked by the Linux command "nvidia-smi", nothing seems to be running on GPU. Did I do something wrong? (It takes 2.4 s/it when training on IWSLT14 German by using a single TitanXP, and I'm not sure it is fast or not.)

What is the output of this:
CUDA_VISIBLE_DEVICES=0 python -c 'import torch; print(torch.cuda.device_count())'

If it's not 1, then there's something wrong with your pytorch installation not being setup for GPU use.

Yeap, it seems that my pytorch was not properly installed. I'll try to re-install it. Thanks!


Incorrect path for diff is generated

When trying to open diff from any review, get following exception:
Illegal char <:> at index 5: https://<here is svn repository URL>/somehting/Something.java
java.nio.file.InvalidPathException: Illegal char <:> at index 5: https://<here is svn repository URL>/somehting/Something.java
	at sun.nio.fs.WindowsPathParser.normalize(WindowsPathParser.java:182)
	at sun.nio.fs.WindowsPathParser.parse(WindowsPathParser.java:153)
	at sun.nio.fs.WindowsPathParser.parse(WindowsPathParser.java:77)
	at sun.nio.fs.WindowsPath.parse(WindowsPath.java:94)
	at sun.nio.fs.WindowsFileSystem.getPath(WindowsFileSystem.java:255)
	at java.nio.file.Paths.get(Paths.java:84)
	at com.ritesh.idea.plugin.reviewboard.ReviewDataProvider$1.run(ReviewDataProvider.java:225)
	at com.intellij.openapi.application.impl.ApplicationImpl$8.run(ApplicationImpl.java:369)
	at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
	at java.util.concurrent.FutureTask.run(FutureTask.java:266)
	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
	at java.lang.Thread.run(Thread.java:745)

In UI it shows path of diff like
C:\Program Files\Java\jdk1.8.0_65\jre\bin\https://<here is svn repository URL>/somehting/Something.java

The problem has occured on Intellij Idea version 2016.1.
Reviewboard version is <IP_ADDRESS>.

I am also getting this error with a slightly different path:
Illegal char <:> at index 3<EMAIL_ADDRESS>java.nio.file.InvalidPathException: Illegal char <:> at index 3<EMAIL_ADDRESS>at sun.nio.fs.WindowsPathParser.normalize(WindowsPathParser.java:182)
at sun.nio.fs.WindowsPathParser.parse(WindowsPathParser.java:153)
at sun.nio.fs.WindowsPathParser.parse(WindowsPathParser.java:77)
at sun.nio.fs.WindowsPath.parse(WindowsPath.java:94)
at sun.nio.fs.WindowsFileSystem.getPath(WindowsFileSystem.java:255)
at java.nio.file.Paths.get(Paths.java:84)
at com.ritesh.idea.plugin.reviewboard.ReviewDataProvider$1.run(ReviewDataProvider.java:225)
at com.intellij.openapi.application.impl.ApplicationImpl$8.run(ApplicationImpl.java:366)
at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
at java.util.concurrent.FutureTask.run(FutureTask.java:266)
at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
at java.lang.Thread.run(Thread.java:745)
at org.jetbrains.ide.PooledThreadExecutor$1$1.run(PooledThreadExecutor.java:55)

I have figured out a workaround. When creating a review, it asks for a path. I have been putting in the svn location:
svn://username@<IP_ADDRESS>/var/svn/dev/sandbox
If I just use / (slash) the files can be viewed as diffs in the plugin.


[7.x] Added orderPivotBy for BelongsToMany relation

This PR will allow us to directly order the query results of BelongsToMany relation such as:
class Tag extends Model
{
    public $table = 'tags';
}

class Post extends Model
{
    public $table = 'posts';

    public function tags()
    {
        return $this->belongsToMany(Tag::class, 'posts_tags', 'post_id', 'tag_id')
            ->using(PostTagPivot::class)
            ->withTimestamps()
            ->withPivot('flag');
    }
}

class PostTagPivot extends Pivot
{
    protected $table = 'posts_tags';
}

// Somewhere in a controller
public function getPostTags($id)
{
    return Post::findOrFail($id)->tags()->orderPivotBy('flag', 'desc')->get();
}

Using orderPivotBy will allow us to not having to append the Tag class table name explicitly in case the flag attribute exists in both Tag and PostTagPivot. The results will be ordered based on flag value.
Note: This is a backported #35455
Do I need to make a PR for [6.x] branch?

7.x is closed for new features sorry.


[SWA-185]: Display "Processing" label on an image preview if still processing

When I upload an image and navigate away from the photo upload step, if I return to the photo upload step before Gemini has finished processing a thumbnail for the image, then I see an empty grey box. Now instead text "Processing" will be shown atop of the grey box in > xs version, and in xs version we show Spinner instead
Jira - https://artsyproduct.atlassian.net/browse/SWA-185
https://user-images.githubusercontent.com/79979820/152970059-cb189aa4-f1a1-4345-a63c-9c40e864fb6c.mov
Image refeching:
https://user-images.githubusercontent.com/79979820/153593567-8338bfa1-ce4b-4f33-87aa-69f8b89b7f64.mov

Added image preview refetching. It runs once you come to the upload photos step if your already added photos still processing. It loads submission assets every 2 seconds and checks for photo url, if the photo was processed refetching stops. Refetching runs only 20 times, so if the photo still processing after, the processing label is left.


[Codelab Issue] Testing Codelab 5.1, Step 2 - Wrong Function Name

Describe the problem
There is a typo in the content. The function name stated asgetOrAwaitNextValue however the function name is getOrAwaitValue
Full text is as follows:

You check that the tasksAddViewVisible is true, using the getOrAwaitNextValue method.

In which lesson and step of the codelab can this issue be found?
Lesson number + step number. (ex. 5.2, Step 7)
Lesson: 05.1,  Step 2
How to reproduce?
The typo would be shown each time Step 2 has displayed.
codelab: advanced-android-kotlin

dup #236


Feature Request - get tags of (Hibernated) WebSocket

Hi :wave:,
We began adopting the new Hibernation API in projects, and I have an idea for an improvement of the APIs it has. Currently, the serializeAttachment and deserializeAttachment methods are provided to persist data that needs to be read back. Additionally, the tags attribute of state.acceptWebSocket can be used for retrieving the WebSockets.
And this is where I see a gap in the API - there is no way to retrieve other tags of a WebSocket instance, in a listener or after using getWebSockets. Besides other use cases, it would be useful for libraries which want to label WebSockets somehow (as an example see https://github.com/evanderkoogh/otel-cf-workers/issues/21#issuecomment-1661325331).
Yes, the library could also use the attachment to save its data, however I see the 2048-byte attachment as a much more "valuable" space for developers, that some people (me for sure) are likely to calculate the exact bytes required to stuff in as much data as possible. On a similar note, I haven't yet found a use case which requires 10 tags on a WebSocket for retrieval later, so if one of these tags could be used by libraries (note: the only missing bit here is the retrieval of this tag from the WS instance) like otel-cf-workers to save their data transparently to the user, the 2048 bytes that the user is working with wouldn't have to be edited by libraries.

I'll propose two possible solutions here, as the first one would be adequate for most usecases, but it feels natural to expand to the full suite.
At a minimum I'm thinking of a WebSocket.getTags(): string[] | null method that returns all tags provided when the WS was handed to the runtime for hibernation. This way, I could retrieve all other tags of a WebSocket when it wakes up, for example if the tags are user:1234 and room:ABC, I can get all the sockets from a room (say for broadcasting a message) by getWebSockets('room:ABC') - but maybe I want to know where they are connected from, so I'd look for the country:<something> tag - hard to know in advance, but useful information.
Expanding on the idea, an update method makes sense to me where I can edit the tags of a WebSocket. I don't currently have a use case for this, but it completes the API surface for these tags, same as the serialized attachment.
I know that some of these can be solved with the attachment system, however the 10 tags * 256 bytes are also currently allowed, so this change wouldn't require any new storage per WS.

Getting Tags
Would state.getTags(WebSocket) be alright? We don't want to stray too far from the official spec, so we'd like to avoid extending the WebSocket object if we can.
I think we can support this but it may be tricky to implement. A HibernatableWebSocket wraps a regular jsg::WebSocket, so we'd need a way to access the wrapper (where the tags are) from the inner object. This may sound straightforward (give it a ref!), however there are situations where the HibernatableWebSocket can be dtor'd before the jsg::WebSocket (Ex. in a webSocketClose/Error() handler). In that case, you could see non-deterministic behavior where you can't get the tags back in those handlers.
One way we could get around that is to copy all the tags into the jsg::WebSocket object, but that would increase the memory usage of the DO in the isolate. As you can imagine, if there are a lot of active websockets in an isolate, each with a couple of longer tags, you could eat a good chunk of your memory (worst case 32k ws, 10 tags each 256 chars: almost 84MB!). Maybe this isn't a real concern though... since we could limit this to when we know the HibernatableWebSocket wrapper object is going away -- then it's a once-per-connection increase in memory right before the WebSocket is GC'd.
tl;dr:

WebSocket.getTags() -> state.getTags(WebSocket)
expect slight increase in memory when webSocketClose/webSocketError() run (at most 10 tags * 256 chars ~2560 bytes per ws, maybe scary when processing many simultaneous disconnects?)

Updating Tags
I would slightly push back against providing a way to update tags until we know there's a genuine need to do so. Our mechanism for storing tags (and associating websockets with them) is fairly complicated, as we optimized for accessing websockets by tag, removing disconnected websockets efficiently, and decreasing our memory footprint (both inside and outside of the isolate).
As far as an API for this is concerned, would you prefer having a way to add/remove tags (within the existing limits), rather than just updating existing ones?

Hi Milan :wave:,
Thanks for considering my feature request. I don't see any downside of having the API flipped - code using state.getTags(WebSocket) would look exactly the same in the real world, in my opinion.
I hope I understand the issue you're describing with the non-deterministic behavior, however it's been a while since I've written c++, so even though I've read the relevant runtime code, the the context I have about the memory increase is probably rather limited. Even so, I think that the memory footprint increase is small enough to justify the new feature. My only concern around this is the runtime restarting/stopping, when all hibernated websockets are closed, are the close handlers on each connected socket called at the same time, thus potentially reaching the 84MB increase?
As for the update method, as I mentioned above I don't have a real use case yet, so I understand the reason for not implementing that for now. Since you asked, I was thinking that the simplest (although maybe this is not true given your explanation) to implement is a setTags, that accepts a new array of tags, replacing all the existing ones.

We're tracking this internally, haven't had time to look into the restart issue (not sure if it even is an issue). Will update here when I have some time to dig through the code/run some tests.

Thank you @MellowYarker for implementing this!
I'm going to close this issue since the PR has now been merged (yayy :tada: ) and released - eagerly waiting for this to appear on Workers.


Use 'www' folder if is available in production

I would like know the opinion about this.
Instead of define again a gunt task to copy the files in '.tmp/folder', use www/ folder with static assets compiled.
.cc @davidrivera

Yep, just running into a similar issue over at Sane Stack: https://github.com/artificialio/sane/issues/51
The grunt hook is disabled per default, because using docker, or nginx+pm2 (multi-process apps) it really is just causing issues, but I didn't think about the fact that the assets do not get lifted anymore on a simple sails lift.
This would certainly be an option, or how about having an option in the .sailsrc? Something like assets: assets or assets: www, etc? If it is empty it just defaults to .tmp/public. This makes it simple, new people don't get confused because nothing changes for them and others can customize it.
What are your thoughts?

@Globegitter agreed- so as you probably know, you can do this now by setting sails.config.paths.public- is the issue that it isn't being pulled from the sailsrc file in time to affect the static middleware? Or is it that the path isn't being resolved if it's relative?
ie. in your sailsrc file:
{
  "paths": {
    "public": "./www"
  }
}

Bumped~

What exactly does the "bumped" mean?

@randallmeeker et. al.
It means we are doing what we can to move through the backlog of PRs and get caught up~
bump (verb)
past tense: bumped; past participle: bumped
to push (something) jerkily in a specified direction.
Hopefully we won't do it jerkily but I can't make any promises ;)

@CWyrtzen wat? and what's ~ means?
seriously, bumped doesn't mean nothing, and at the end you says I can't make any promises, so basically you are saying nothing of nothing...
Chocolate~

I'm still confused. Does it mean your doing something with this issue
specifically?
I know what it means for a community member to "bump". They are promoting
an issue or request.
On Mar 17, 2015 9:34 AM, "Courtney Wyrtzen"<EMAIL_ADDRESS>wrote:

@randallmeeker https://github.com/randallmeeker et. al.
It means we are doing what we can to move through the backlog of PRs and
get caught up~
bump (verb)
past tense: bumped; past participle: bumped
to push (something) jerkily in a specified direction.
Hopefully we won't do it jerkily but I can't make any promises ;)
—
Reply to this email directly or view it on GitHub
https://github.com/balderdashy/sails/pull/2206#issuecomment-82386301.

Twas a bit of a joke about not making promises...the note simply means we sorting it through, moving it along intentionally, taking a second and third and fourth look...
All I can say is we are doing what we can to catch up and clean up and shine up so when you see BUMP it means it has been hand-carried on your behalf.
Perhaps my attempt at humor is misplaced but I think a little levity and good will are essential in times like these.
And @randallmeeker yes, promote, absolutely: further the progress of (something, especially a cause, venture, or aim); support or actively encourage. Indeed~
Cheers~

Alright, closing in favor of the solution documented here: https://github.com/balderdashy/sails/pull/2543#issuecomment-69277536


Add getting started section

This PR is in reference to issue #5. I added the initial items that we all discussed. I could use some help describing some of the variables of the Dataset returned from compute_Sv. Also, if you know of a good resource (such as a blog post or YouTube video) for getting familiar with this terminology (i.e. backscattering), please let me know and I can add it.

Thank all of you for your suggested comments. I have incorporated several of them into the getting started section. Please note that in the initial steps we need to modify items 1 and 5 once we have constructed these. Additionally, @lsetiawan did I correctly reference item 4?
Also, @valentina-s  what do you mean by "maybe add some picture of an echogram"? From my understanding, an echogram is a packet of data obtained from the raw file. Is this what you are talking about?

@b-reyes I thought incorporating a picture like figure 2 from this link, but adding lables of the axes: horizontal is ping_time and horizontal is range_bin

@valentina-s thank you for the clarification. I wasn't sure if we could use the image from the link you provided, so I incorporated an echogram from our echopype example: watching a solar eclipse using a moored echosounder. Hopefully this will be useful! If anyone has a better image to use, please let me know.

@b-reyes : Thanks for putting this together! I suggested some changes, most are small except for the first paragraph.
I also have two overall comments:

reduce the line length to ~90, or write each sentence as a continuing text block, or write each paragraph as a continuous text block
netcdf --> netCDF

@leewujung thank you for your suggestions. I have incorporated them into the getting started section. I am unsure how to limit the line length (see my comment above).

Thanks @b-reyes for making all the changes and catching the grammar errors!
I'll take the liberty to merge this PR so that the repo is updated. I'll put the remaining TODOs into issues so that we can keep track of them.


[1.0] Ensure that reference counting works well with the new API.

The problem
Styx uses Netty reference counted ByteBuf for content streams. Netty reference counts are exposed to Styx consumers.
Styx should protect its consumers from accidentally leaking byte buffers.
The dangerous areas are

Removing a body content stream
Transforming the content stream

Detailed Description
Consider this code snippet to transform an UTF8 HTTP content stream to UTF-16. It leaks both buffers buf1A and buf1B. The buffers leak because the content transformation function, implemented as lambda, never releases them.
    ByteBuf buf1A = copiedBuffer("buf-1a", UTF_8);
    ByteBuf buf1B = copiedBuffer("buf-1b", UTF_8);

    // The HTTP request body as UTF 8 encoded byte stream:
    StyxObservable<ByteBuf> utf8Body = StyxObservable.from(ImmutableList.of(buf1A, buf1B));

    HttpRequest req1 = HttpRequest.put("/")
            .body(utf8Body)
            .build();

    // The UTF 8 response body transformed to UTF-16:
    StyxObservable<ByteBuf> utf16Body = req1.body().map(buf -> copiedBuffer(buf.toString(UTF_8), UTF_16));

    FullHttpRequest req2 = req1.newBuilder()
            .body(utf16Body)
            .build()
            .toFullRequest(100)
            .asCompletableFuture()
            .get();

    System.out.println("result: " + Arrays.toString(r2.body()));
    System.out.println("buf1 refcount: " + buf1A.refCnt());
    System.out.println("buf1 refcount: " + buf1B.refCnt());

Acceptance criteria

Ideally, the Netty ByteBuf is wrapped with Styx facade to avoid leaking 3rd party dependencies in the API.
Styx to take care of, or provide some helper methods, to automatically release the reference counts.

One option is to implement a pair of release methods:
static Function<ByteBuf, ByteBuf> release(
        Function<ByteBuf, ByteBuf> usersMapper)
{
    return input -> {
        ByteBuf output= usersMapper.apply(input);
        if (output != input) {
            input.release();
        }
        return output;
    };
}

static Function<ByteBuf, StyxObservable<ByteBuf>> releaseAsync(
        Function<ByteBuf, StyxObservable<ByteBuf>> usersMapper)
{
    return input ->
            usersMapper.apply(input)
                    .map(output -> {
                        if (output != input) {
                            input.release();
                        }
                        return output;
                    });
}

They could be used in the content transformation like this:
    // The UTF 8 response body transformed to UTF-16:
    StyxObservable<ByteBuf> utf16Body = r1.body()
            .map(release(buf -> copiedBuffer(buf.toString(UTF_8), UTF_16)));

Closing all issues over 3 years old. New issues can be created if problems are still occurring.


build: make the CTensorFlow module more SPM friendly

Add the structure expected by SPM to enable building the CTensorFlow
module as part of a Swift Package.  It is no longer possible to build
this package without X10 support.

Feel free to delete any of the #ifdefs related to X10 support. I don't think we do any builds without x10.


A suggestion for a simpler search algorithm for the interpolation

Here's a suggestion for accelerating/simplifying the search algorithm. It's mostly focused on reducing the complexity of the search. There's now just two slice ranges, followed by a closest neighbor search in each of those slices.
I removed unused parameters: c9130c5dacc69a50918ba3b2dbcf062c5ac9c8f6
The biggest thing that I don't have an immediate answer to is how to set what is currently a magic number of the width of the slice. My first vale of 1m didn't find anything below. And my second try at 100m finds way to many. We should find a way to query this resolution from the dataset or parameterize it somehow.
Looking at the output it appears that 5m resolution is our current resolution. So I've set it to that.

The z slice at 5m worked:
1: [Dbg] [ScienceSensorsSystem.cc:757] 295536 points in full cloud
1: [Dbg] [ScienceSensorsSystem.cc:763] 1st z slice 18471 points
1: [Dbg] [ScienceSensorsSystem.cc:841] Found 4 neighbors.
1: [Dbg] [ScienceSensorsSystem.cc:849] Neighbor at (1.39148e-08, -1.1001e-09, -0), distance 1.07004e-06 m
1: [Dbg] [ScienceSensorsSystem.cc:849] Neighbor at (-1812.03, 0.184071, -0), distance 1812.03 m
1: [Dbg] [ScienceSensorsSystem.cc:849] Neighbor at (1812.03, 0.184071, -0), distance 1812.03 m
1: [Dbg] [ScienceSensorsSystem.cc:849] Neighbor at (1.37634e-08, -2218.66, -0), distance 2218.66 m
1: [Dbg] [ScienceSensorsSystem.cc:775] 2nd z slice 18471 points
1: [Dbg] [ScienceSensorsSystem.cc:841] Found 4 neighbors.
1: [Dbg] [ScienceSensorsSystem.cc:849] Neighbor at (1.39148e-08, -1.1001e-09, -5), distance 5 m
1: [Dbg] [ScienceSensorsSystem.cc:849] Neighbor at (-1812.03, 0.184071, -5), distance 1812.04 m
1: [Dbg] [ScienceSensorsSystem.cc:849] Neighbor at (1812.03, 0.184071, -5), distance 1812.04 m
1: [Dbg] [ScienceSensorsSystem.cc:849] Neighbor at (1.37634e-08, -2218.66, -5), distance 2218.66 m
1: [Dbg] [ScienceSensorsSystem.cc:884] diff:

It's hard to find things in the logs now that they're truncated at 55thousand lines
The CI looks like YoYoCircle failed. I'm guessing this hasn't been rebased recently so is still flakey.

So, for speedy reviews, I would really like to have new changes be based on #127, instead of #83, because #83 is not meant to work without #127, so it's very hard to judge whether things are correct based on #83. It has a FIXME that's a big problem, which means the results returned in #83 are actually incorrect - the indices of the points aren't mapped back the original point cloud. So everything downstream from FindTrilinearInterpolators in #83 are just undefined behavior.
I would prefer to address the comments in #83 individually, merge that, and then move additional suggestions to #127, where we have actual interpolation that we trust much more, and have more data to test with.
There had been so many failing edge cases that we had to address - which #127 addresses, I'm very hesitant to look at one data output and declare things working.

Replaced this with #156


Add debug tooling to deploy-doc-tests/run

Add -d and -s options to deploy-doc-tests/run command
If either of these options is invoked, no test is run.

-d, or --shell-in-container starts an interactive docker container with the same 'environment' as where the tests are run.
-s, or --output-shell-script does what it's name implies; write a
shell script containing all the steps (in the correct order) to the
standard output.

I don't think deploydoc is the correct term. The invocation would be deploy-doc-tests/deploy-doc.
I still think that deploy-doc-test/run is better.
A compromise would be to rename it to deploy-doc-test/run-deploy-doc-test

OK, had a chat with Frank. We consider extracting this as a separate project, having a deploydoc command makes sense in that case.

Yes, don't know what happened here, I'm going to investigate the history of this branch a bit.

@moretea @frankscholten Making the doc tool a separate project is good idea. If you can't create a repo in this org, shout & I'll sort it for you.

Closing, will merge these changes into https://github.com/microservices-demo/deploydoc


Set default export results to all items

We need to differentiate two situations in the results-JSON:
(A) An indicator with checkboxes has been shown, but all have NOT been checked. E.g.: A preregistration is present "P_Preregistration": "Yes", but in P_Preregistration_Content nothing was was checked.
(B) An indicator with checkboxes was hidden due to a filter condition. E.g.: For meta-analyses, P_Preregistration_Content is hidden.
Current state
Currently, the results-JSON looks identical: All items from P_Preregistration_Content are missing.
Desired state:

In (A), all checkbox items should be present in the results-JSON, with "false" as value
In (B), all checkbox items should be present in the results-JSON, with "NA" as value.

That means, generally all checkbox items should be present in the results, and either have true, false, or NA.

Done. adcc81958a7adc8b1a0373a37cf8ad8009256e38


[Question] Error: Dialog[*:/] not found

Hello,
So my bot started returning me the following error in the emulator even though I haven't changed anything and it was working fine before.
session.beginDialog(/)
Error: Dialog[*:/] not found.
I'm not sure what the specific problem is, LUIS is working fine so I'm guessing its the code. Please take a look?
var restify = require('restify');
var builder = require('botbuilder');

//=========================================================
// Bot Setup
//=========================================================

// Setup Restify Server
var server = restify.createServer();
server.listen(process.env.port || process.env.PORT || 3978, function () {
   console.log('%s listening to %s', server.name, server.url);
});

// Create chat bot
var connector = new builder.ChatConnector({
    appId: process.env.MICROSOFT_APP_ID,
    appPassword: process.env.MICROSOFT_APP_PASSWORD
});
var bot = new builder.UniversalBot(connector);
server.post('/api/messages', connector.listen());

//=========================================================
// Bots Dialogs
//=========================================================

var model = 'https://westus.api.cognitive.microsoft.com/luis/v2.0/apps/bd0e8c3f-9a91-4f2a-8086-fdbfc05cc4b2?subscription-key=3c1c88e0cd3842a8819a2b92a2921543&timezoneOffset=0.0&verbose=true&q=';
var recognizer = new builder.LuisRecognizer(model);
bot.recognizer(recognizer);

bot.dialog('hello', [
    function (session) {
        session.sendTyping();
        builder.Prompts.text(session, '你好，请问您叫什么名字');
    },
    function (session, results) {
        session.sendTyping();
        session.send('你好' + results.response);
    },
]).triggerAction({matches:'hello'});

You don't have a dialog bound to / (aka default dialog). Anything other than hello intent will try to find a default dialog and your bot doesn't have one. As an alternative to explicitly binding a dialog to /, you can pass it on to the UniversalDialog constructor as a second argument after the connector.

Right, so for this I'm only testing the hello intent and its returning that error. Its weird because it was fine when I lasted tested it but after awhile of not touching it, its not working anymore.
by binding it to / do you mean the line
bot.dialog('/', intents) ?
or do you mean adding / to
bot.dialog('hello', [
like bot.dialog('/hello', [

Try removing the &q= from your LUIS endpoint. I believe the Bot Framework will add that. I am speculating but your LUIS recognizer might not be working the way you expect it and you always, even when you think you say hello, end up in / due to an error.

The bot.dialog('/', intents) will attach an instance of IntentDialog to / and then it will take care of the routing within. That's how I used to do until 3.5 and the new routing system. I meant that you would explicitly (via bot.dialog('/')) or implicitly (via passing your default dialog to the UnivesalBot) define a confused dialog. Something that will handle the None intent. You might as well attach a dialog to the None intent. You have options.

hmm doesn't seem to be the problem with the none intent or the &q=... I will try to set up another bot and fiddle with the LUIS recognizer abit. If you have any recommendations that I can try please let me know. Thanks! P.S. BTW big fan of your eCommerce chatbot-example!

@zwang, try have you tried to reassign your dialogId to '/hello'? If not please do so and let me know what happens. If you were using an IntentDialog then the normal practice would be to create a 'root' dialog: bot.dialog('/', intents)
Since you seem to be following a sample and not using IntentDialog, I believe you should have a / inside of your dialogIds (e.g. '/hello', '/goodbye').
If you want to read more on IntentDialog (I recommend it!), you can find an article/section here and find the actual reference documentation here.

In general, it's good to have a default dialog handler that binds to the '/' route.  You can use this route to start out your Bot's dialog and then redirect to other dialogs based on user input.
For example - the below default dialog ('/') checks for the presence of session.userData.name and redirects the user to the /profile dialog if the name property is not present.
bot.dialog('/', [
    function (session, args, next) {
        if (!session.userData.name) {
            session.beginDialog('/profile');
        } else {
            next();
        }
    },
    function (session, results) {
        session.send('Hello %s!', session.userData.name);
    }
]);

bot.dialog('/profile', [
    function (session) {
        builder.Prompts.text(session, 'Hi! What is your name?');
    },
    function (session, results) {
        session.userData.name = results.response;
        session.endDialog();
    }
]);

More info on dialog configuration can be found here: https://docs.botframework.com/en-us/node/builder/chat/dialogs/

@stevengum97 even when I add the '/' it still doesn't work unfortunately

@zwang454 try: '*:/' instead of '/'


Is node.exe really needed?

Yeah this is the question I had. It's almost the biggest file, why would we have use for it xD

Lol.
Idk, maybe we should remove it from git and tell everyone he MUST use the new version to tell us how it works xD

It's there for the users, so they don't need to install node.js. I tested it in a VM and it works.
Should i remove it anyway?

I wanna see there faces then they havent installed node and it doesnt exist anymore in lvlgen c:

**What r u saying guys...  Node.js is required, 99% of lvlgen is written in JS, so it's required to have Node.js but that file node.exe is the replacement of Node.js so you don't need to install it....   Your choice, that file or Node.js :+1: **

People that use this file should probably have Node.js installed on there PC already. Honestly I think lot's of people already have Node.js (Ogar, feeder-bot, etc) and this file is just there for a VERY small majority. I wouldn't have really cared if it didn't take up most of the package space.


stuck in loading llm

What is the issue?
When you try to run llama3.2:3b, you get an error message:
Error: timed out waiting for llama runner to start
and stuck in loading.
codellama:7b-code-q6_K	e3d8d04437e4	5.5 GB	2 months ago
llama3:latest	a6990ed6be41	4.7 GB	4 months ago
llama3.2:1b	baf6a787fdff	1.3 GB	14 hours ago
llama3.2:3b	a80c4f17acd5	2.0 GB	15 hours ago
nomic-embed-text:latest	0a109f422b47	274 MB	4 months ago
phi3:latest	2ac528a36156	2.3 GB	4 months ago
this is list of my llm.
OS
Linux
GPU
Nvidia
CPU
Intel
Ollama version
0.1.34

llama3.2 needs at least ollama version 0.3.1.  If the problem persists after upgrading, server logs will aid in debugging.


Implementing watch for Config redis CM

For complete implementation of https://github.com/knative-sandbox/eventing-redis/issues/8

@lionelvillard this PR is ready for review. It completes the implementation of config-redis (no dynamic reloading and rolling upgrade of statefulset on controller watch, as discussed*) AND also fixes the build errors in the master branch (since it was a whole bunch of vendor. fmt, codegen issues also applicable to this branch)

We will implement horizontal scaling for Redis source at a later time

/lgtm
/approve


Undefined property: stdClass::$bibtex

I just installed the plugin and got this error:

That is odd, what environment are you testing it with? I created and tested it on Grav v1.1.3, but the back-end library demonstrably fails quickly on slightly improper Bibtex-files without good reason. A better back-end library really is necessary for a better implementation, I've just yet to find a parser that delivers the goods.
Bibtex might also be inherently outdated compared with any modern format, JSON definitely would be better but I haven't dug into whether most or any Bibliography-software supports it as output.

Just pushed a release with fixed plugin-detection, it would fail on pages with bibtex not set.

That did it 👍


MudDataGrid: Fix missing DataGrid reference in FilterDefinition

Description

Fixes #5469
The reference to the DataGrid in FilterDefinition was set only when the FilteredItems were iterated.
I have added the reference to the DataGrid whenever a FilterDefinition is created.
(Maybe in the .net 7 it could be solved with the required modifier)
How Has This Been Tested?

Types of changes

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

[x] The PR is submitted to the correct branch (dev).
[x] My code follows the code style of this project.
[ ] I've added relevant tests.

Can I have a feedback on this PR please? @henon

This looks like an incredibly simple PR. But nevertheless, @tjscience should give it a brief check, I have next to no knowledge of this component.

Btw, @nicoarm93 it would be awesome if you added a test that fails without the references you added and passes with them. This will reinforce the code so that future changes to the component will not accidentally undo this fix.

@henon, this looks good. Thanks for taking care of it, @nicoarm93.


Raise Hand

Students need to be able to notify teachers when they cannot solve the exercise.
Otherwise, teacher must manually inspect each student progress, which is cumbersome.

Related to #60

Resolved in https://github.com/mumuki/mumuki-laboratory/commits/e22c187c0644260526a983b6b4c4ea4382447107


span.badge.pull-right in div.dropdown-menu line-breaks in Firefox

Mozilla/5.0 (X11; Linux x86_64; rv:29.0) Gecko/20100101 Firefox/29.0
http://jsfiddle.net/yF2xn/9/

very thanks..

Hi,
The fix you've suggested is working fine however when I'm using with angularJS it is looking weird.
JSBin link: http://jsbin.com/tabenizono/edit?html,js,output
Could you look into this issue please?

Hi @PassionatePro!
You appear to have posted a live example (http://jsbin.com/tabenizono/edit), which is always a good first step. However, according to the HTML5 validator, your example has some validation errors, which might potentially be causing your issue:

line 1, column 16 thru line 2, column 21: Attribute ng-app not allowed on element html at this point.
line 11, column 1 thru column 35: Attribute ng-controller not allowed on element body at this point.

You'll need to fix these errors and post a revised example before we can proceed further.
Thanks!
(Please note that this is a fully automated comment.)

@PassionatePro Sorry, but we can't help you with Angular-related problems. Try one of the community help forums instead. Good luck.


Add reload icon for vm statistics pane in a sidebar

If an user is unable to reload the statistics then it has almost no useful application.

It may be implemented the same way as in the settings "regenerate keys" is implemented for API.


e2e: Update all end-to-end test configuration versions to latest

What
bump refs to core, js, soroban-examples as needed
Why
keeps e2e relevant against release candidate versions
Known limitations

@sreuland since everything passes I think you can just drop the git ref, leave the beta.2 and force merge w/o waiting for statuses!


Resolving relative images in subdirectories

For markdown documents in subdirectories referring relative images,like

![alt](diagrams/context/context.svg)

tool  is able to find image only in scenario, when it is executed from the same directory where file resides.
If I will try to execute it passing file path, like
mark -u $CF_USER -p $CF_TOKEN -b $CF_DOMAIN -f docs/subdirectory/$file

it will fail.
So far workaround is manual traversing of dirs one by one, but would be nice if relative references could be resolved.
declare -a dirs=("docs", "docs/subfolder1", "docs/subfolder2" )

for d in ${dirs[@]}; do

(
cd $d
for file in $(find -maxdepth 1 -type f -name '*.md'); do
  echo "> Sync $file";
#  echo mark -u $CF_USER -p $CF_TOKEN -b $CF_DOMAIN -f $file
  mark -u $CF_USER -p $CF_TOKEN -b $CF_DOMAIN -f $file || exit 1;
  echo;
done
)

done

The workaround listed does work. I've modified it a bit to make it a little more flexible until I've got time to look for a fix in go:
set -e
while read -r -d '' file; do
  echo "Syncing $file..."
  pushd "$(dirname "$file")" > /dev/null
    filename="$(basename "$file")"
    mark -k -f "$filename"
  popd > /dev/null
done < <(find . -type f -name "*.md" -print0)

The workaround listed does work. I've modified it a bit to make it a little more flexible until I've got time to look for a fix in go:
set -e
while read -r -d '' file; do
  echo "Syncing $file..."
  pushd "$(dirname "$file")" > /dev/null
    filename="$(basename "$file")"
    mark -k -f "$filename"
  popd > /dev/null
done < <(find . -type f -name "*.md" -print0)

Unfortunately this workaround fails when using it in a Bitbucket pipeline yaml file, resulting error is "syntax error near unexpected token `do'"
Without this workaround, I can get the files attached in Confluence by specifying the full path in the  meta tags but they're not embedded in the page itself as the path using in the markdown doesn't exactly match the full path.

Would be really good to have this support in place, right now, having all image assets in the same folder quickly gets problematic for us.

I'm open to merge any feature which will help the community 😺


KOGITO-8766 Updated information about the new interface of Knative custom function

JIRA: https://issues.redhat.com/browse/KOGITO-8766
This PR depends on:

https://github.com/kiegroup/kogito-runtimes/pull/2923
https://github.com/kiegroup/kogito-examples/pull/1631

[x] You have read the contributions doc
[x] Pull Request title is properly formatted: KOGITO-XYZ Subject
[x] Pull Request title contains the target branch if not targeting main: [0.9.x] KOGITO-XYZ Subject
[x] The nav.adoc file has a link to this guide in the proper category
[x] The index.adoc file has a card to this guide in the proper category, with a meaningful description

How to backport a pull request to a different branch?

In order to automatically create a backporting pull request please add one or more labels having the following format backport-<branch-name>, where <branch-name> is the name of the branch where the pull request must be backported to (e.g., backport-7.67.x to backport the original PR to the 7.67.x branch).

NOTE: backporting is an action aiming to move a change (usually a commit) from a branch (usually the main one) to another one, which is generally referring to a still maintained release branch. Keeping it simple: it is about to move a specific change or a set of them from one branch to another.

Once the original pull request is successfully merged, the automated action will create one backporting pull request per each label (with the previous format) that has been added.
If something goes wrong, the author will be notified and at this point a manual backporting is needed.

NOTE: this automated backporting is triggered whenever a pull request on main branch is labeled or closed, but both conditions must be satisfied to get the new PR created.

@fjtirado @MarianMacik @radtriste can you take a second look now after the most recent changes on the interface?

@radtriste @MarianMacik I spoke offline with @fjtirado and we decided to change the interface again.
You don't need to review it for now.
I'm reverting this PR to draft while I do this change.

@ricardozanini @radtriste @MarianMacik this is ready for review.


Creative Pay Option: Not Working

*Description of issue:
Greetings, in the Config, there is an option for enabling/disabling creative pay.
This option seems to be broken. No matter what I set it to, or what permissions I have in place, all users can get exp, money, points for all actions.
CONFIG SECTION (DELETE IF NOT RELEVANT):
# Option to allow payment to be made in creative mode. This ignoring when a group has 'jobs.paycreative' permission.
enable-pay-creative: true/false

Server Type (Spigot/Paperspigot/etc):
Paper
Server Version (using /ver):
Build 118

It's working correctly.

Make sure the player is not an operator. (Double check /deop)
Make sure the player have permission jobs.paycreative, if have then negate that.

enable-pay-creative: true/false

is not a logic value. Please use only one value.


Dynamically setting show property of react-table does not show or hide columns viceversa

I am using react-table for the data-grid purpose. I am implementing a settings icon which shows the list of columns and based on the selection, the column gets shown or hidden. I am manipulating "show" property of columns object for this. While the property is getting set properly, there is no such change in the table.
Code Sandbox: https://codesandbox.io/s/blue-cherry-di3ub

I've gotten this to semi-work by returning a new object to the column prop inside a hook whenever a state variable changes.  By  semi-work I mean the columns inside the body are updating, but the headers are ignoring the show property in columns.


Feature Request  eventCount on Year view

Having an event count (per month) on year view similar to the count displayed on the month view would be great.

Hi @aocneanu, this is now a feature in version 1.47.0,
Please refer to this example: https://antoniandre.github.io/vue-cal/#ex--events-indicators
And this one if you want custom calculations: https://antoniandre.github.io/vue-cal/#ex--custom-events-count.
Hope it helps!

Closing for inactivity. Please reopen if not solved!

Hi!
There seems to be a small inconsistency regarding counting, on year views all day events are omitted.
P.S. Thanks a lot for adding this!


gradle: 5.6.4 -> 6.5.1

Motivation for this change
Upgrade Gradle to latest version 6.5.1
Add gradle_6 to the top level packages.
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[ ] NixOS
[x] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[x] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

@ludovicc thanks for opening your first pr to nixpkgs :)

@jonringer Thanks for the welcome and the review. It looks like you had some kind of transient error while downloading the zip, http://services.gradle.org/distributions/gradle-6.5.1-bin.zip works both from browser and using nix-review on this pr.

I use https for all urls as suggested.

jd-gui should work better, I pinned gradle to version 5 as used by this package.
squashed the commits.

@jonringer I have moved the gradle_5 pinning to #92292, this pr is now dependant of #92292


[Name lookup] Remove NL_VisitSupertypes.

As part of cleaning up name lookup, remove the NL_VisitSupertypes flag, which shouldn't ever be needed.

@swift-ci please smoke test and merge


SAMZA-2320: Samza-sql: Refactor validation to cover more cases and make it more extensible.

Can you add description on

What kind of refactoring is done
What are the more cases it covers?
How is it extensible in future?


[#211] R2dbcType.TIMESTAMP_WITH_TIME_ZONE lists wrong javaType

Signed-off-by: Lukas Eder<EMAIL_ADDRESS>This fixes https://github.com/r2dbc/r2dbc-spi/issues/211
Make sure that:

[x] You have read the contribution guidelines.
[x] You have created a feature request first to discuss your contribution intent. Please reference the feature request ticket number in the pull request.
[x] You use the code formatters provided here and have them applied to your changes. Don't submit any formatting related changes.
[x] You submit test cases (unit or integration tests) that back your changes.

Thank you for your contribution. That's merged now.


[1pt] Create website header with empty nav - Setup (group task)

Download the free image for the app logo.
Create empty navigation (this will be filled in in separate tasks).

https://github.com/oluwatobi-fasasi/react-group-project/pull/27


Use well-known CDNs for delivering some scripts

This uses Google's CDN for jQuery and one provided by MaxCDN for Bootstrap.
This allows the files to be served from a geographically closer location,
increases the chances that the file will already be locally cached, and
makes library updates easier.

:-1: loading js files from external places means to give them full access to the site. They could add tracker scripts or such.

Even if they don't add tracker scripts, they already get usage data from the HTTP requests alone, and the referrer.

:-1:, see @est31 privacy and security concerns.

:-1: this is non performant for browser because this don't permit to use proper HTTP/1.1 pipelining for loading all page content

@nerzhul: Pipelining?  Do you mean HTTP/2?  It would have relatively more overhead on HTTP/2, but the main improvement of this is that it's much more likely that the client will already have these cached, which is true no matter the HTTP version.

:-1: because of reasons already talked about
@ShadowNinja: HTTP/1.1 supports pipelining too: https://en.wikipedia.org/wiki/HTTP_pipelining#Implementation_status

multiple disapprovals here


Show currently selected items

Moved to internal tracker: https://filestack.atlassian.net/browse/FS-3109


Unreliable signal detection?

Great package! One thing I noticed though is that with a beacon that send at a constant rate (e.g. 500ms), the noble scanner starts working correctly, but after short time it "swallows" some signals only to push them out in a row a couple of seconds later, sometimes the delay is a couple of seconds. Usually that's not a big deal but I am trying to get a realtime detector running and it currently triggers a lot of false alarms over a day. I am using the latest version on RPi3. Thanks!
Forgot to mention that in order to rule out problems with the beacon I tried also with python PyBluez package which does not show this kind of behaviour.

@kaYcee maybe you could share your code and an HCI dump capture (sudo hcidump -t -x) along with the debug output.

kaYcee,
I'm trying to get noble running on my Pi3, but get all kinds of errors. Which OS are you running? Did you have to do anything special to get noble going?
Thanks!

We are having the same issue here. Any solutions so far?
It might be the same problem than reported #596
We are using: Raspberrry Pi 3 b, internal Bluetooth sensor, noble 1.8.1, up-to-date raspberian via noobs, Estimote beacons

@bastianleirpo please provide info requested in https://github.com/sandeepmistry/noble/issues/628#issuecomment-309278901 then we can re-open this.
I'm closing it due to lack of activity for now.


Add new New Opt In Filed values (recentDeviceActivity and playProtectVerdict)

Should solve https://github.com/herzhenr/spic-android/issues/5
Feel free to also add descriptions for environmentDetails or change design of the fields 🙂

Thank you very much for your contribution! I will have a look at your code in the next couple of days :)

Hi there after a long time... I am very sorry for my late response. I was very busy over the last couple of month and now I finally took the time and had a look at the project again. I had a look at the code and tested the app with your changes and I really like it. Going to merge it now, will add some localisation from other pull requests, will implement a small additional feature myself as well and then release an updated version of the app.
Again thank you very much for your contribution, it is really nice seeing someone working on a feature for the app :)

@herzhenr can you please release a new version with this implemented?


resolveUri - Minor Edits

Don't expose the ApiCache in the client interface. Reasoning: https://github.com/polywrap/monorepo/pull/610#discussion_r805296344

Also made some minor interface changes:

IUriToApiResolver to UriToApiResolver
Use interfaces instead of types
Use the class constructor's name

All of the changes seem good to me, except for the cache.
I'm definitely hesitant to expose the cache through the client, but I think I'm even more opposed to having the resolvers access to the cache. I do however think we could merge this as is, for now, since it avoids the former and we can talk about the latter through a separate issue.


Remove HelperCheats

Make VMs available as global constant singleton
Remove HelperCheats

Closes #40

@aviggiano could you give this a quick look and check if it aligns how you want things to work?


[Program]: Write a Perl program to print string of ascii values

Description
Write a Perl program to print string of ascii values
ASCII value is the numeric representation of a character. For example, the ASCII value of the character 'A' is 65. The ASCII value of the character 'a' is 97. The ASCII value of the character '0' is 48. The ASCII value of the character ' ' is 32.
Input  : 65 66 67
Output : ABC

How to contribute

Save the solution in program/program/print-string-of-ascii-values/print_string_of_ascii_values.pl file

!assign test

!assign test

once check I have given pull request

I have added I the program files


Maintenance testing for fractions sims

I'd like spot-checks for the following fractions sims, to make sure that the recent maintenance patches work nicely (so they can be production deployed sometime):

[ ] https://phet-dev.colorado.edu/html/fraction-matcher/1.2.0-rc.4/phet/fraction-matcher_en_phet.html
[ ] https://phet-dev.colorado.edu/html/fractions-equality/1.1.0-rc.4/phet/fractions-equality_en_phet.html

This should include iOS-related testing (iPadOS glitches, full-screen, game audio tests)
The last RC testing was done in:

https://github.com/phetsims/QA/issues/413
https://github.com/phetsims/QA/issues/414

And the sim-specific patch issues (auto-generated by the maintenance release process):

https://github.com/phetsims/fraction-matcher/issues/109
https://github.com/phetsims/fractions-equality/issues/7

Additionally @ariel-phet, should I proceed with production deploys once these spot checks are finished? I don't see any non-deferred issues from the earlier RCs or in any relevant repos.

[ ] Win 10 chrome
[ ] Win 10 firefox
[ ] Win 10 edge

[ ] Mac 10.15 safari

[ ] Win 7 IE

[ ] ChromeOS
[ ] iPadOS 13

high priority since should be quick but after #445 (or concurrently with #445 if on the same platform)

QA is done

Thanks, moving forward with production deployments!


why don't remove  for References and Hypotheses  in validate ?

Hi, thank you for the nice work.  I'm new to image caption and  the work helps me a lot.
from Line 298 to Line in train.py when you wrap the list for Hypotheses and References , why don't you remove the , this tag is not part of the caption same to  and .
Thank, you!

Hi @Lzhushuai, sorry for the really delayed reply. Yes, what @soloist97 said is right. I do, however, remove it in the final evaluation in eval.py so it doesn't contribute to the final BLEU scores.

Hi @sgrvinod, i tried to run eval.py but "ValueError: max() arg is an empty sequence"  error msg is displaying. how can i fix this error please!


Add multiple node features in networkx graph

Is it possible to add multiple features to a single node to a networkx graph and then pass the graph to the graph net function utils_np.networkx_to_data_dict()?
In the documentation this case is not explicitly stated:
https://github.com/deepmind/graph_nets/blob/master/docs/graph_nets.md#utils_npnetworkx_to_data_dictgraph_nx-node_shape_hintnone-edge_shape_hintnone-data_type_hintfloat32
Thank you

Hello,
no, this is not currently supported, as utils_np.networkx_to_data_dict will only pull the features contained under the key "features". Moreover the remaining of the graph net library (e.g. the modules) assumes that the node features are single tensors.
You could create several graphs and then concatenate them down the line if that helps.

thank you


Undefined variable

I'm getting this error when I'm trying to generate api crud

OS Ubuntu 17.10.1, PHP version 7.1.11 and Laravel 5.6.5

@AbdusamadTurdiev Thanks for the report will update it on the next release.
Meanwhile you can use from the develop branch.

Fixed at the new release


[REFACTOR] Redesign delta backup & restore implementation in backupstore lib for better maintenance

Is your improvement request related to a feature? Please describe
The current implementation of volume backup/restore delta management is messy and not well-organized design. Need to review and refactor the confusing parts to make the library maintainable.
Context: https://github.com/longhorn/backupstore/pull/94#pullrequestreview-1241482508
Describe the solution you'd like
A clear and concise description of what you want to happen.
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
Additional context
cc @shuo-wu @derekbit @joshimoo @mantissahz

Also refactor https://github.com/longhorn/longhorn-engine/pull/820#discussion_r1070899351


sum-of-multiples: Removing implicit list of multiples

Updates the tests and example solution to require an explicit
declaration of multiples, matching the test cases from x-common/sum-of-multiples.json
To fix Issue #71

Thanks for the fix!


How to translate into Chinese

How to translate into Chinese

I've put together a list of strings in an ini file. But be aware that there are over 600 lines to translate (some of them repeat, so feel free to use a find/replace all feature).
lang_en.zip
If you have any questiones where any of the strings are used, feel free ask me.

In the Chinese version, your plugin cannot display Chinese characters. like "(???)"  this

The language file is not read by the current version but I'm working on it. Sadly I cannot test this on the cinese client but I'll do my best.

Check out this development snapshot:
d3d9_arcdps_sct.zip
Place your language file in /addons/sct/lang.ini
Also note that I was missing one entry in the section [Option_UI]:
General_Enabled = SCT enabled

/n invalid
[X Hits] no translation
incoming events and outgoing events  no translation
The font causes the interface to be too large, please use 12.0f-15.0f size, or increase the settings in the options or configuration file settings.

Addressing those issues:

Reading data from ini file ecaped \n as \n. Fixed this.
Added missing translation. (Also the string "Multiple_Sources")
Those names are saved in sct.ini and therefore can't really be translated. They are only read once when there is no sct.ini file. However, I added under [General] these lines:
Default_Scroll_Area_Incoming = Incoming Events
Default_Scroll_Area_Outgoing = Outgoing Events
SCT Options now tries to use /addons/arcdps/arcdps_font.ttf if it exist. I accidently used font size 22 for this. I fixed this to read the font size from /addons/arcdps/arcdps.ini ([display_altui] section, font_size key) and fall back to 12.

Try this:
d3d9_arcdps_sct.zip

Thank you for your help, and finally there is a question, why getting "Shielded" will show up as "Heal over time"

Why right and left  both  show "Heal over time"?
if you can change to
the left to show the treatment given by other players,
the right side shows player treatment,
I mean to show myself  treatment of my own treatment ,to the right without repeating it to the left.

You are right: shield messages are bugged and I'm working on it (and so are invulnerable message).
As for your suggestion: if you apply anything onto yourself (heal, hot, condi with necro, ...) it is theoretically both: incoming to your character and outgoing from your character. In the options are two ways to prevent this. Both are in the "General" tab - "Show self messages only as incoming" and "Show outgoing messages only for target" - with the latter also removing all outgoing messages which are not applied to current ingame target.

Here is a new build:
d3d9_arcdps_sct.zip
There are 4 new message types and the englich default for some have changed, here is a list:
`[messagePlayerOutgoingShieldGot]
title = Shield Received
Parameter_Description_v = Amount of Shield
Parameter_Description_n = Name of the skills target
Parameter_Description_s = Skillname
Parameter_Description_i = Skillicon
Default_Value = +%v %i
[messagePlayerOutgoingShield]
title = Shielded Damage
Parameter_Description_v = Amount of damage
Parameter_Description_n = Name of the skills target
Parameter_Description_s = Skillname
Parameter_Description_i = Skillicon
Default_Value = %v -=absorb=- %i
[messagePlayerIncomingShieldGot]
title = Shielded
Parameter_Description_v = Amount of damage
Parameter_Description_n = Name of the shield source
Parameter_Description_s = Skillname
Parameter_Description_c = Color for the skills source profession (use: [col=%c]...[/col])
Parameter_Description_i = Skillicon
Default_Value = %i +%v
[messagePlayerIncomingShield]
title = Shield damage
Parameter_Description_v = Amount of damage
Parameter_Description_n = Name of the attacker
Parameter_Description_s = Skillname
Parameter_Description_c = Color for the skills source profession (use: [col=%c]...[/col])
Parameter_Description_i = Skillicon
Default_Value = %i %v -=absorb=-
[messagePetOutgoingShieldGot]
title = Shielded
Parameter_Description_v = Amount of shield
Parameter_Description_n = Name of the skills target
Parameter_Description_s = Skillname
Parameter_Description_p = Name of the pet/clone shielding
Parameter_Description_i = Skillicon
Default_Value = +%v %i
[messagePetOutgoingShield]
title = Shield damage
Parameter_Description_v = Amount of damage
Parameter_Description_n = Name of the skills target
Parameter_Description_s = Skillname
Parameter_Description_p = Name of the pet/clone attacking
Parameter_Description_i = Skillicon
Default_Value = %v -=absorb=- %i
[messagePetIncomingShieldGot]
title = Shielded
Parameter_Description_v = Amount of shield
Parameter_Description_n = Name of the shield source
Parameter_Description_s = Skillname
Parameter_Description_p = Name of the pet/clone attacking
Parameter_Description_c = Color for the skills source profession (use: [col=%c]...[/col])
Parameter_Description_i = Skillicon
Default_Value = %i Pet +%v
[messagePetIncomingShield]
title = Shield damage
Parameter_Description_v = Amount of damage
Parameter_Description_n = Name of the attacker
Parameter_Description_s = Skillname
Parameter_Description_p = Name of the pet/clone attacking
Parameter_Description_c = Color for the skills source profession (use: [col=%c]...[/col])
Parameter_Description_i = Skillicon
Default_Value = %i Pet %v -=absorb=-`

Fixed! But fps is falling too fast. 60fps drops to 18fps or even lower during combat. This is a big problem.

 I usually use these for debugging event data. Here you go:
d3d9_arcdps_sct.zip

ok  all


Each section should have anchors

Each section, like Buttercup for desktop, for instance, should have nav anchors.

This should be taken care by PR 73, commit https://github.com/buttercup/buttercup-website/pull/73/commits/7839e8d768c49917b8d813e0627489edc930c2ee


🎶 Multiple differentping sounds

Is your feature request related to a problem? Please describe.
No ability to distinguish which highlight plays ping sound. Having multiple ping sounds would solve this. For moderation you might want to get notified on certain patterns which have nothing to do with normal pings.
Describe the solution you'd like
Allow selecting Ping sounds per highlight.
Describe alternatives you've considered

Don't do it.
Additional context

An alternative could be adding another fan inside "Moderation" section called  "Blacklisted" which would basicly be the same as highlights, but only available in chats you got sword.


2.0/update errors

Update GaxError to Ruby 2.3

Remove Ruby 2.0 specific code since minimum Ruby is now 2.3.
Move GaxError#status_details to google/gax/grpc/status_details.rb file, so that the method is only loaded when GRPC is.

Codecov Report

Merging #183 into master will decrease coverage by 0.18%.
The diff coverage is 96.73%.

@@            Coverage Diff             @@
##           master     #183      +/-   ##
==========================================
- Coverage      99%   98.81%   -0.19%
==========================================
  Files          29       30       +1
  Lines        1502     1523      +21
==========================================
+ Hits         1487     1505      +18
- Misses         15       18       +3

Impacted Files
Coverage Δ

lib/google/gax/grpc.rb
100% <100%> (ø)
:arrow_up:

test/google/gax/gax_error/status_details_test.rb
100% <100%> (ø)

lib/google/gax/api_call.rb
100% <100%> (ø)
:arrow_up:

test/google/gax/error_test.rb
100% <100%> (ø)
:arrow_up:

lib/google/gax/errors.rb
95.45% <66.66%> (-4.55%)
:arrow_down:

lib/google/gax/grpc/status_details.rb
95% <95%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 24b1332...2a3ec16. Read the comment docs.


@source breaks on certain update queries

EdgeDB Version: 4.7+45e4acc
EdgeDB CLI Version: EdgeDB CLI 5.0.0+c9dfeec
OS Version: Ubuntu 22, OSX 14.4.1

Discord
EdgeQLSyntaxError: unexpected reference to link property 'source' outside of a path expression

with
c := (select C filter .id = <uuid>"ecc71393-0370-11ef-9fcf-eff76ddca10a"),
b1 := (select B filter .id = <uuid>"387e4c34-0366-11ef-b5d7-bf01271f0bc5"),
b2 := (select B filter .id = <uuid>"207c0356-0366-11ef-b5d7-336ae71573b1"),
select {
  b1u := (update b1 set { val := 'asdf' }),
  b2u := (update b2 set { a := c.a,  }),
};

module default {
    type A {
        name: str;
    }

    type B {
        val: str;
        multi a -> A {
            is_active: bool;
            constraint exclusive on ((@source, @is_active));
        }
        c -> C;
    }

    type C {
        multi a -> A;
    }
}

Works if either update line is commented out or if constraint is removed
I'd provide a dump, but this query fails at compile time so my database values don't matter. You can have gibberish in those UUIDs.

The issue is probably being caused by something in our "conflict detection" code, which explicitly enforces exclusive constraints in queries that do multiple inserts/updates to related types. (This is because the triggers we use don't work in this situation, so we do it manually).
I'll dig into it


Subscribe to a publoop with relay crashes

Describe the bug
When I subscribe to a channel with relay as parameters (the example code for sub) my code crashes after 5~ seconds with error:
"Resource temporarily unavailable (RELAY_ERR_IO; cache.c:1091)" (E_ERROR) in "/home/debian/test/virions/Predis/src/Predis/Connection/RelayConnection" at line 269

To Reproduce
Steps to reproduce the behavior:

Connect to client with relay parameters
Subscribe to a publoop
Wait 5~ seconds

Expected behavior
Nothing
Versions (please complete the following information):

Predis: last v2 branch
PHP: 8.1
Redis Server: 6.0.16
Debian 10

Code sample
$pubsub = $this->getDatabase()->pubSubLoop();

$pubsub->subscribe('control_channel', function ($message, Relay $client) {
   var_dump($message);
});

Additional context
My relay diagnostics ?
Relay Support => enabled
Relay Version => 0.6.5
Available cache => 134163328
Available serializers => php, json, igbinary, msgpack
Available compression => lzf, zstd, lz4
Binary UUID => 9353abef-b2f0-4dce-bb13-fb15c332e964
Git SHA =>
Allocator => relay
License state => unknown
License memory cap => 0
License request id =>
relay.enabled => true
relay.key =>
relay.maxmemory => 134217728
relay.maxmemory_pct => 95
relay.eviction_policy => lru
relay.eviction_sample_keys => 128
relay.initial_readers => 128
relay.invalidation_poll_usec => 5
relay.pconnect_default => 1
relay.max_endpoint_dbs => 32
relay.loglevel => none
relay.logfile =>

Resource temporarily unavailable

Seems like Redis Server is offline?

Yes


:grey_question: Import dashboard (curl & docker) :nerd_face:

:grey_question: Context
We have started to create dashboards... and now we'd like to share/distribute them.
:point_right: Of course you can import them by clicking, but what I would like to achieve is to :

Be able to import them within shell, docker volume mount... so the enduser woud just have to clone a repo to be up and running.

:dart: Question/Feature Request
Explain how, from within only script and Docker image we can import a dashboard into a NeoDash instance (at least how to achieve this with curl)
Thank you in advance for any help.

I'm just starting too.  But the dashboard can be saved as a json file.  I would like to get the syntax to load that file via cypher.

Guess I can close this one, no?

Closing this issue now that the dashboards are shareable, feel free to reopen it if you think this issue is still relevant!


[AppConfig] Generate code with the latest autorest

API change check
API changes are not detected in this pull request.


Update mat4.js.html

https://glmatrix.net/docs/module-mat4.html#.getScaling
Changes 'paramter' to 'parameter'.
There is no useful functionality. This is just a spelling mistake in the docs.

Should probably be fixed in the source instead, since the docs are autogenerated https://github.com/toji/gl-matrix/blob/be9e9b5e5ba6603cd7e06b868696a241d003338e/src/mat4.js#L1145