[DRAFT]resume interrupted build (part one RFC)

this part: write org_id to images table

  read back in interrupted loop

next part: make image builder call with limited struct
last part: move to kafka consumer

Signed-off-by: Jonathan Holloway<EMAIL_ADDRESS>Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes # (issue)
Type of change
What is it?

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Documentation update
[ ] Tests update
[ ] Refactor

Checklist:

[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes
[ ] I run go fmt ./... to check that my code is properly formatted
[ ] I run go vet ./... to check that my code is free of common Go style mistakes

Codecov Report

Merging #989 (6b52b5a) into main (a34fc03) will decrease coverage by 0.44%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main     #989      +/-   ##
==========================================
- Coverage   30.66%   30.21%   -0.45%
==========================================
  Files          45       24      -21
  Lines        5492     1049    -4443
==========================================
- Hits         1684      317    -1367
+ Misses       3573      707    -2866
+ Partials      235       25     -210

Impacted Files
Coverage Δ

pkg/dependencies/main.go
0.00% <0.00%> (ø)

pkg/models/images.go
100.00% <ø> (ø)

pkg/routes/common/org_id.go
0.00% <0.00%> (ø)

pkg/routes/images.go

pkg/services/consumers.go

pkg/services/errors.go

pkg/services/images.go

pkg/services/commits.go

pkg/services/devices.go

pkg/services/services.go

... and 15 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a34fc03...6b52b5a. Read the comment docs.

/retest

Test results are available in Ibutsu. The test run IDs are:
75a3d093-aafb-402a-ad8e-ea0815521802
f3e891d8-0645-48c5-a0a2-596dac1ffa1d

Test results are available in Ibutsu. The test run IDs are:
22369eab-0839-46a2-85b0-8c42ec115b3a
4c66de66-a3f3-4326-a771-7b6234ee628a

Test results are available in Ibutsu. The test run IDs are:
f2ab2fa4-e112-43f1-a85f-b79294a681d5
f6f765b1-7bb9-419c-987c-0f6e6c9185ad

Test results are available in Ibutsu. The test run IDs are:
46bd0a9b-01f3-4a69-831f-8db1626e46ea
73e776c4-0b69-443d-bdad-4d9907394e26

Test results are available in Ibutsu. The test run IDs are:
541fbc5d-32e1-48a2-a7b3-6a074ef4ee7d
87cfcd77-d2f7-41e1-bd8a-8ed93c51c340

it looks OK, in the future we may add queries like for images and for the entities that will include org_id
(account = ? OR org_id = ?)

and when ready (when all record will have that org_id)
remove the account from the queries

Test results are available in Ibutsu. The test run IDs are:
08f906ba-601c-4549-a687-a19012bf30a1
fe56982a-78ed-4a0e-bf1d-cf4c4dea7d5d

Test results are available in Ibutsu. The test run IDs are:
1ce1700d-a9dd-43cb-b798-7c92873b736b
c0951744-3d09-4a23-b144-30def10db77c

Test results are available in Ibutsu. The test run IDs are:
c78d4ac9-fb7c-447d-848f-1ebbeaf88bfa
cc4aa93b-4ad7-4654-af62-63460fd20dbb

i like your changes, one more person to review just to be sure

Test results are available in Ibutsu. The test run IDs are:
146ce6f9-926e-43ed-96b5-4805433ddaba
9ee74d7f-4991-4156-a094-f32565ebcb2e


[FEATURE] Accessibility Improvement of website

Why do we need this improvement?
Currently, the website accessibility score is 93. By improving the colour contrast ratio and styling, we can achieve a 100 score.
How will this change help?
We need to be highly accessible for a better user experience.
Screenshots

How could it be implemented/designed?
Relates to #3186
🚧 Breaking changes
No
👀 Have you checked for similar open issues?

[X] I checked and didn't find a similar issue

🏢 Have you read the Contributing Guidelines?

[X] I have read the Contributing Guidelines

Are you willing to work on this issue?
Yes I am willing to submit a PR!

@akshatnema I want to work on this issue. Could you please assign me this?

@aakankshabhende  are you still on it? if not I can take from here
cc @akshatnema

@TenzDelek Yes, I'm working on it.

I'm working on this issue but currently, this issue is waiting on the design team @akshatnema
I have pinged in the channel, once it is unblocked I will resume working on this

@aakankshabhende can you please elaborate your approach

if this issue open can i work on this

Hi @aakankshabhende
Thanks for bringing this up and offering to work on it—I really appreciate it!
Sorry for the delay in responding; I’ve been away for a bit. I agree that the website could use some accessibility improvements, and that’s part of why I’ve been working on redesigning some sections. You can check out more details here
I tried looking for the designs in the design channel, but I couldn’t find them. Would you mind dropping the link to the Figma file here?
Thanks so much! I'm looking forward to reviewing your designs.


Using a push module function leads to error

Description
Hello there,
I noticed that when using a push function from a module into another function I get the error "variables from outside the function are read-only and cannot be modified".
Here is a minimal exemple.
First a module "module.typ":
#let push() = [
  This is a dummy function
]

Then try to use it in another module and in a function, for instance a "call.typ" module:
#import "module.typ" as m

#m.push()  //no problem there

#let mycall() = {
  m.push()  //here is the error
}

#mycall()

The exact error is:
error: variables from outside the function are read-only and cannot be modified
  ┌─ call.typ:6:2
  │
6 │   m.push()
  │   ^

help: error occurred in this call of function `mycall`
  ┌─ call.typ:9:1
  │
9 │ #mycall()
  │  ^^^^^^^^

My feeling is that for some reason it interprets m as being a global array which thus cannot be modified from the function.
Changing the function name to any other name (e.g. add) works like a charm. I was wondering if this is supposed to be normal or a bug.
Reproduction URL
No response
Operating system
Linux
Typst version

[X] I am using the latest version of Typst

You've discovered a cursed part of the Typst compiler. It needs to know upfront whether to evaluate the callee abc of abc.def() as mutable or not, and for this reason the names "push" | "pop" | "insert" | "remove" are currently special-cased when used in method call notation (so that array & dictionary methods work). I didn't find a better solution at the time.


fix: stub every missing function in renderer package tests

What does this PR do?
Fix 'not a function' errors in renderer package tests
Screenshot / video of UI

What issues does this PR fix or reference?

Fix #9288.
How to test this PR?

[ ] Tests are covering the bug fix or the new feature

Updated all occurrences of using wrong mock for resolved value.


Can we please add support for SAM HQ?

Feature request
We have new version SAM HQ that is better than original SAM.
https://github.com/SysCV/sam-hq
Motivation
It will generate better results.

To be able to use it in transformers.js, the models must first be compatible with the python transformers library. I would recommend that you make a feature request either in transformers, or the sam-hq repo to add compatibility with the transformers implementation.

Sure, Thanks!


Adding phpdoc blocks and removing some unneeded lines

Also, when you're ready, would you mind squashing these into a single commit?

I squashed them into one commit @assertchris . Please have a look before you merge it.

Looks good, thanks! :)

Sweet, thanks for merging this in :)


GH-40221: [C++][CMake] Use arrow/util/config.h.cmake instead of add_definitions()

Rationale for this change
It's easy to maintain.
What changes are included in this PR?
Use #cmakedefine in cpp/src/arrow/util/config.h.cmake and #include "arrow/util/config.h" instead of add_definition(...).
Are these changes tested?
Yes.
Are there any user-facing changes?
No.

GitHub Issue: #40221

@github-actions crossbow submit -g cpp -g r -g linux -g python -g r

@github-actions crossbow submit -g cpp -g r -g linux -g python -g r


Fix outdated elasticsearch log file

Elasticsearch seems to crash when using docker-compose to start the application. Steps to reproduce along with the error message:
$ cd docker
$ docker-compose -p rackhd up -d
   # ...now wait a bit
$ docker logs rackhd_elasticsearch_1
ERROR: no log4j2.properties found; tried [/usr/share/elasticsearch/config] and its subdirectories

According to the docs, logging.yml is no longer used in Elasticsearch 5.x as the whole logging system has been replaced with Log4j 2. This PR reflects that change.

thanks for the update Jason! Nice to see code from you again!
👍

👍


Add Role endpoint

Desired Outcome
Add support for Conjur's Role endpoint.
Implemented Changes

Define URI pattern for Role requests
Add wrapper function to generate API calls
Add  relevant unit tests

Connected Issue/Story
Supports ONYX-23085
Definition of Done
At least 1 todo must be completed in the sections below for the PR to be
merged.
Changelog

[x] The CHANGELOG has been updated, or
[ ] This PR does not include user-facing changes and doesn't require a
CHANGELOG update

Test coverage

[x] This PR includes new unit and integration tests to go with the code
changes, or
[ ] The changes in this PR do not require tests

Documentation

[x] Docs (e.g. READMEs) were updated in this PR
[ ] A follow-up issue to update official docs has been filed here: insert issue ID
[ ] This PR does not require updating any documentation

Behavior

[ ] This PR changes product behavior and has been reviewed by a PO, or
[x] These changes are part of a larger initiative that will be reviewed later, or
[ ] No behavior was changed with this PR

Security

[ ] Security architect has reviewed the changes in this PR,
[x] These changes are part of a larger initiative with a separate security review, or
[ ] There are no security aspects to these changes

Code looks great. Just waiting for a draft PR in cyberark-conjur-cli to validate this against an actual conjur instance with integration tests.

cyberark-conjur-cli PR with integration tests


Create a Bearing sensor model

Create a sensor model which will measure the bearing to a target in a 2D planer world

Addressed by functionality in Radar Model and corresponding sensor models #29


Restoring a session whilst using nvim-tree causes invalid buffer error

Describe the bug
When loading up nvim with https://github.com/kyazdani42/nvim-tree.lua with a session immediately loaded gitsigns errors reporting.
Error executing vim.schedule lua callback: ...acker/start/plenary.nvim/lua/plenary/asy
nc_lib/async.lua:14: The coroutine failed with this message: ...im/site/pack/packer/st
art/gitsigns.nvim/lua/gitsigns.lua:542: Invalid buffer id: 2

To Reproduce
init.lua:
-- Presuming both plugins have been installed as vim packages
vim.cmd("packadd gitsigns.nvim")
vim.cmd("packadd nvim-tree.lua")

require("gitsigns").setup()

Steps to reproduce the behavior:

Open a nvim inside a directory
Open some files, then mksession
Close nvim and reopen via nvim -u minimal.lua -S
see error message

Observed output
Error messages, logs, etc
output of :lua require('gitsigns').debug_messages().
setup_highlight: Deriving GitSignsDelete from DiffDelete
setup_highlight: Deriving GitSignsAdd from DiffAdd
setup_highlight: Deriving GitSignsChange from DiffChange
run_job: git --no-pager --version
attach(2): Attaching

Screenshots
If applicable, add screenshots to help explain your problem or to capture error messages.
Additional context
System: Ubuntu 20.10
Neovim version:
Error executing vim.schedule lua callback: ...acker/start/plenary.nvim/lua/plenary/async_lib/async.lua:14: The coroutine failed with this message: ...im/site/pack/packer/star
t/gitsigns.nvim/lua/gitsigns.lua:542: Invalid buffer id: 2Error executing vim.schedule lua callback: ...acker/start/plenary.nvim/lua/plenary/asy
nc_lib/async.lua:14: The coroutine failed with this message: ...im/site/pack/packer/st
art/gitsigns.nvim/lua/gitsigns.lua:542: Invalid buffer id: 2
setup_highlight: Deriving GitSignsDelete from DiffDelete
setup_highlight: Deriving GitSignsAdd from DiffAdd
setup_highlight: Deriving GitSignsChange from DiffChange
run_job: git --no-pager --version
attach(2): Attaching
:version
NVIM v0.5.0-dev
Build type: RelWithDebInfo
LuaJIT 2.1.0-beta3
Compilation: /usr/bin/cc -g -O2 -fdebug-prefix-map=/build/neovim-PEGyaz/neovim-0.5.0+ub
untu2+git202104182337-66f9dd3c6-d569569c9=. -fstack-protector-strong -Wformat -Werror=f
ormat-security -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=1 -O2 -g -Og -g -Wall -Wextra -pedan
tic -Wno-unused-parameter -Wstrict-prototypes -std=gnu99 -Wshadow -Wconversion -Wmissin
g-prototypes -Wimplicit-fallthrough -Wvla -fstack-protector-strong -fno-common -fdiagno
stics-color=auto -DINCLUDE_GENERATED_DECLARATIONS -D_GNU_SOURCE -DNVIM_MSGPACK_HAS_FLOA
T32 -DNVIM_UNIBI_HAS_VAR_FROM -DMIN_LOG_LEVEL=3 -I/build/neovim-PEGyaz/neovim-0.5.0+ubu
ntu2+git202104182337-66f9dd3c6-d569569c9/build/config -I/build/neovim-PEGyaz/neovim-0.5
.0+ubuntu2+git202104182337-66f9dd3c6-d569569c9/src -I/build/neovim-PEGyaz/neovim-0.5.0+
ubuntu2+git202104182337-66f9dd3c6-d569569c9/.deps/usr/include -I/usr/include -I/build/n
eovim-PEGyaz/neovim-0.5.0+ubuntu2+git202104182337-66f9dd3c6-d569569c9/build/src/nvim/au
to -I/build/neovim-PEGyaz/neovim-0.5.0+ubuntu2+git202104182337-66f9dd3c6-d569569c9/buil
d/include
Compiled by buildd@lcy01-amd64-029

Features: +acl +iconv +tui
See ":help feature-compile"

   system vimrc file: "$VIM/sysinit.vim"
  fall-back for $VIM: "/usr/share/nvim"

Run :checkhealth for more info

Can confirm. I use vim.schedule as a workaround.

For a bit more context if needed, this issue seems to be very related to nvim-tree's behaviour, it does some stuff with buffers being created and sometimes destroyed when a session is loaded that might be what is tripping up gitsigns but in my mind gitsigns should be excluding special buffers although I guess nvim tree might not have marked it's buffer in any way that makes it clear that it is special 🤔 ?
I've switched to lazy loading nvim tree and that seems to at least avoid the issue 😅

Funilly enough the error happens during gitsigns buffer validation checks:
local attach = async(function(cbuf: integer)
  await(scheduler())
  cbuf = cbuf or current_buf()
  if cache[cbuf] then
    dprint('Already attached', cbuf, 'attach')
    return
  end
  dprint('Attaching', cbuf, 'attach')

  if api.nvim_buf_line_count(cbuf) > config.max_file_length then -- ERROR HERE
    dprint('Exceeds max_file_length', cbuf, 'attach')
    return
  end

  if api.nvim_buf_get_option(cbuf, 'buftype') ~= '' then
    dprint('Non-normal buffer', cbuf, 'attach')
    return
  end

I guess we need to tweak the ordering and maybe add another check.

I am totally assuming...
Also, it is related with maybe closed floating windows, not sure if nvim-tree use floating window.
The source that calls as I saw https://github.com/lewis6991/gitsigns.nvim/blob/main/lua/gitsigns.lua#L777 list all buffers but on async, the buffer does not exist later.
  for _, buf in ipairs(api.nvim_list_bufs()) do
      if api.nvim_buf_is_valid(buf) and
         api.nvim_buf_is_loaded(buf) and
         api.nvim_buf_get_name(buf) ~= '' then
         await(attach(buf))
         await(scheduler())
      end
   end

I did a speculative fix by just checking the buffer is loaded. Let me know if this fixes the issue.

Just gave it a shot and still seems to persist unfortunately

still having the issue

Arggh, there was a missing not which rendered the plugin useless. Should be ok now.

We shouldn't reach nvim_buf_line_count in the latest change. I forgot to invert the condition on the check.

it is working now! thanks

Just tried it and it's also solved on my end 👍🏿 I can close this out now?


audio signal amplitude might be too large (we might be overmodulating)

Oops, the commit should have fixed issue #10.

Seems to be working fine. I tried changing amplitude from signal generator and it didn't really affect anything.
Need to test if it affects signal strength.


Feat: Smooth Scrolling feature in website

What feature?
Hey, I want to make some improvements to the code and added a smooth scroll feature that provides users with a seamless navigation experience when clicking on links in the navigation bar. I believe this enhancement would greatly benefit our project. Therefore, I kindly request you to assign me this issue.
Add screenshots
none
Record

[X] I agree to follow this project's Code of Conduct
[X] I'm a GSSoC'23 contributor
[X] I want to work on this issue

we are working on nextjs migration so I think we don't need to change any code right now. if needed we will create an issue


Adjust main branch to use respectful language

/kind enhancement
What happened:
Current standard of this repos main branch name master is not respectful to some contributors and/or users of KubeVirt
What you expected to happen:
Please adjust the main branch name to main.
Anything else we need to know?:

Repo admin privledges will be necessary.  Please coordinate with @mazzystr

/close


+https alters state somewhere

Suppose that +http://mysite.com works as expected, but then you do:
~zod:dojo> +https://mysite.com
error code: 14090086
error:14090086:SSL routines:SSL3_GET_SERVER_CERTIFICATE:certificate verify failed

Fair enough, but then subsequent attempts at +http://mysite.com (no s) fail with the same error.
Also, instead of handling the failed verification gracefully, you're left with %dy-no-prompt.

Anton, any comments?
On Thu, Feb 2, 2017 at 2:17 PM, hoclun-rigsep<EMAIL_ADDRESS>wrote:

Suppose that +http://mysite.com works as expected, but then you do:
~zod:dojo> +https://mysite.com
error code: 14090086
error:14090086:SSL routines:SSL3_GET_SERVER_CERTIFICATE:certificate verify failed
Fair enough, but then subsequent attempts at +http://mysite.com (no s)
fail with the same error.
Also, instead of handling the failed verification gracefully, you're left
with %dy-no-prompt.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/urbit/arvo/issues/341, or mute the thread
https://github.com/notifications/unsubscribe-auth/AALyAdAQJ5cb_OuhC1O6Ecp6Al8DY_9Tks5rYlYVgaJpZM4L1tbu
.

Can't immediately find anything in dojo or eyre that would retain hostnames at all, let alone across secure/insecure; does the problem persist if you restart the pier?

Problem persists on fresh fakezod using urbit/master and arvo/master.

Can't reproduce this using various examples from the really convenient https://badssl.com.


Prevent selecting any items when using single select (object)

I'm using Vue-multiselect 2.1.4
It works like a charm when I use single select with array options. But in case of using single select with array of objects, all items are green and they are not selectable! (They have "is-selected" class)
To clarify the problem, I used the sample code from the project website and replace the options with my data.

<multiselect v-model="value" deselect-label="Can't remove this value"
    track-by="name" label="name" placeholder="Select one"
    :options="options" :searchable="false" :allow-empty="false">
    <template slot="singleLabel" slot-scope="{ option }">
        {{ option.name }} is written in
          {{ option.language }}
    </template>
</multiselect>

const config = {
    data() {
        return {
            value: null,
            options: []
        }
    },
    async mounted() {
        await this.getTerminals();
    },
    methods: {
        async getTerminals() {
            await window.axios.get("/api/Operation/GetTerminals")
                .then(resp => {
                    this.$data.options = resp.data;
                })
                .catch(err => {
                    console.error(err);
                });
            },
    }
};
const app = Vue.createApp(config);
app.component('Multiselect', VueformMultiselect);
app.mount('#app');

Same issue here.. Anybody with a solution?

The same here, Any solution??

@masoud86 Unable to reproduce this in latest version. Please provide reproduction repo.

I have the same problem

Closing due to unable to reproduce, as well as it being for an older version.


Update manifest.json

new requirements pycountry from <23 to <24 and version from 0.38.7 to 0.38.8

@andrelr84,
Thanks for the PR, but I already implemented this with some other requirements change in last release v0.39.0.


[now dev] Add server: now response header

Matches production.

Codecov Report

Merging #2646 into canary will not change coverage.
The diff coverage is 0%.

@@          Coverage Diff           @@
##           canary   #2646   +/-   ##
======================================
  Coverage    8.15%   8.15%
======================================
  Files         259     259
  Lines        9434    9434
  Branches     1073    1073
======================================
  Hits          769     769
  Misses       8616    8616
  Partials       49      49

Impacted Files
Coverage Δ

src/util/dev/server.ts
11.24% <0%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 495ba3b...19ca9d6. Read the comment docs.


Windows' taskbar on top of chrome when Mercury Trade is open

I've tried to kill and restart the explorer.exe proccess and it didn't help. When I closed Mercury Trade, the taskbar went back to normal, and once I opened it again, it bugged again. This is not happening right now, so it doesn't happen always. This happens with my PoE aswell sometimes, but I never thought anything about it because but when it does, I usually fix it just by going to the desktop and coming back to the game.
My computer has Mercury Trade on the startup and today, I noticed there were two Java windows open and stuck (nothing would happen when I clicked on them), I closed Mercury Trade and they went away, opened MT again and the reported bug happened.

Problem: Path of Exile constantly loses focus / Windows taskbar springs on top of the game while Mercury is running.
Fix: Disable Windows wallpaper slideshow.

I don't have it on, it just a static wallpaper.

Issue still happening.

if this happens without mercury then you need to look for a problem in another application, mb you are platin in fullscreen or some other "overlay" applications can cause this problem

As soon as I close Mercury Trade, it goes back to normal.


Gherkin language server support

Summary
Gherkin already provides a process to parse feature files from the commandline as well as parsing "in code". This still needs adaption when used, e.g. in an IDE. For some time now there is a Language Server Protocol that allows to support the easy integration in multiple IDEs with less code.
Expected Behavior
The process can be started with 'gherkin --server' behaving according to the LSP4 protocol using the std input/output stream for communication.
Current Behavior
currently it is only possible to parse feature files one-time with a cucumber specific json response
Context & Motivation
See summary, this would allow to integrate advanced editing capabilities to a majority of IDEs without "reinvent the wheel"
Your Environment
The users operating system that is capable of executing the gherkin command.

Hi @laeubi - I think this could be incredibly useful.
Is this something you'd be willing and able to contribute, or kick-start? I personally do not have capacity to do this now.

Hi @laeubi - I think this could be incredibly useful.
Is this something you'd be willing and able to contribute, or kick-start? I personally do not have capacity to do this now.

@aslakhellesoy I'm currently doing some investigations on how this could be archived using LSP4J (java) but if someone else can do it better and faster (e.g. GO, C+++, ...) feel free to raise a hand :-)
I can't promise when I could came up with a prototype but will keep this in mind.

@aslakhellesoy I'm currently doing some investigations on how this could be archived using LSP4J (java) but if someone else can do it better and faster (e.g. GO, C+++, ...) feel free to raise a hand :-)
I can't promise when I could came up with a prototype but will keep this in mind.

@SabotageAndi where is that VSCode LSP implementation you mentioned?

This is the mentioned VS Code Extension: https://marketplace.visualstudio.com/items?itemName=alexkrechik.cucumberautocomplete
Everything with autocomplete is done in VS Code via LSP.

This is in progress: https://github.com/cucumber/common/pull/1689


Is this project no longer maintained?

Is this project no longer maintained?
I will use this Value Object implementation (using #2 #4 #1 ) in my saas toolkit.

Would be a great idea if the project were released as a NuGet package, so the wider community could benefit from using it. Right now, I am assuming, the only way to use it in my project is to just copy the ValueObject.cs file into my project?

@syedsuhaib It's on nuget, I just hadn't release the netstandard version yet. Thanks for the reminder. I published the latest code as 0.6.1

Thanks. There's no mention of the nuget package though in the [readme] (https://github.com/jhewlett/ValueObject/blob/master/README.md). That's probably the first place folks are gonna look.

@jhewlett tks for the response.
#2 is just code style changes, but in my opinion, improve the code readability.
#1 we need more info about it. I didn't understand as well.
I liked your value object implementation and I'm using in my personal project Amplifier.
And sure, I can help to maintain this repo for sure.

I have also refactored the code in my local version making it more readable using expression body for all overloads except the GetHashCode() function. If you're interested @jhewlett, I could send you a pull request?


Legacy: UI elements spawning new threads

In the beginning, pyLCI was basically menu code, input/output drivers and some hard-coded functions. Even at that point, menu actions (move up/down, select element, exit menu) were callbacks. One of problems I stumbled upon at that time was that menus couldn't be nested because the input listener thread (the one to execute callbacks), being busy with the first menu, never got to callbacks of second menu. I solved it, but I didn't understand how - for a year and a half, I was occasionally thinking "It works, but I actually don't know why". Then, after a year and a half, when I was reducing pyLCI CPU consumption, I added some debugging statements to input listener threads and understood that, for each nested menu, a separate thread is started.

Say, we have menu A and its idle loop is run by Thread number 1
There's also an input thread (Thread 2) that's executing menu A callbacks.
ENTER key is pressed, and select_entry callback is executed from Thread 2.
The callback is another menu's (Menu B) activate() method, so it, after setting things up, moves on to another idle loop.
However, while setting everything up, activate() calls InputListener's listen() method.
InputListener.listen() method basically makes the InputListener forget about the currently running listener thread and launch a new one.
Now Thread 2 is running the Menu B idle loop, and there's a new thread, Thread 3, which will execute the Menu B callbacks.

This is not a high-priority problem, but I don't know how to actually solve it - now, all those threads help preserve UI element execution contexts, so that you can actually go back in a menu. If threads will be removed, there'd need to be another way to store execution contexts (and there must be something else I'm missing). For now, having a context actually means any step in UI is done by an object - so all UI elements are objects (and Printer is trying hard to look like one). A context-less approach might yield some nice usage scenarios, but I can't imagine any good scenarios yet. If somebody has an idea on how to re-implement this, maybe a better way of doing what is being done, or is even willing to implement a new execution context scheme, that would help. For a start, this behaviour has to be more explicitly expressed in the code.
Even after solving this issue, it could make sense to leave this "feature" in InputListener anyway - as long as it doesn't break anything, it could be useful in some apps (as long as it's documented and explicitly available).

So, I've been thinking about this for some time now. For simple UI elements like Menus, the threads could be removed while preserving the execution context. It'd entail simply putting something like "self.i.process_callbacks()" in the idle loop, where "i.process_callbacks" would essentially run one iteration of the event loop of the input listener. So, all the Menu callbacks would be run from the menu's activate() function. However, that'd make stack traces very long. It doesn't feel like that would be a suitable decision for tying everything together - especially given that, with #8 , it will only make sense to run applications as separate threads. So, maybe that could be implemented for the "Main app menu" structure (specifically, the Menu tree that is constructed by AppManager, from apps/manager.py), for a start. My vision is adding a keyword argument to BaseListBackgroundableUIElement, that would then enable the idle-loop-callback-processing, then see how it goes (and see if the stacktraces aren't too long, too =) )


Refactor k6 development environment to prepare for regular runs in CD

Fixes

Part of https://github.com/WordPress/openverse-infrastructure/issues/1031
Description

This PR refactors the k6 development environment in preparation for running the k6 frontend suite after staging deployments.
This refactor (hopefully) does the following:

Simplify k6 execution environment by running it in ov instead of using a Docker wrapper. This also includes simpler and more reusable just recipes.

This has the additional benefit of making it easier to use k6 login, as we would need to sort out volumes for k6 to store credentials or otherwise map credentials in.

Improve k6 developer experience generally by adding TypeScript support, linting through ESLint (utilities directory is not linted by ESLint!).
Refactoring the k6 frontend scripts to match k6's code organisation style. Check out this repository as an example: https://github.com/grafana/k6-template-typescript/tree/main/src. Using the file name to choose the scenario(s) rather than passing a new ENV leverages k6's run API, and simplifies scenario selection (makes it more static).

To avoid needing to do a lot more refactoring, I deleted the API scripts. We can and will add these back later, but it was easier to keep the scripts we actually have and plan to consistently use moving forward. Once we organise running the frontend scripts as part of CD, we can do the same for API scripts, which will prevent them from drifting or breaking.
This also got rid of the non-k6 based scripts, which I don't think we used in the last two years, and even if we did, would be better re-written in k6 following the better patterns
Includes using k6 options for user agent (which we weren't doing for the API scripts), and configuring options for scenario vus/iterations

There are probably lots of further improvements to be made that get this closer in line with typical k6 examples. Scenarios seem powerful, but also potentially get in the way of configurability, as they do not support cli options for configuration (see link in code explaining this). k6's docs also have information about grouping tests and such, which we aren't really following. See this section of their docs:
https://grafana.com/docs/k6/latest/using-k6/tags-and-groups/#discouraged-one-group-per-request
We might be able to simplify things a lot further by reading k6 docs and understanding its best practices better, before adding many more scenarios (like for the API). This PR gets us in a better place to do that, because it enhances the developer experience and lays some groundwork for improving the code organisation. In other words, this PR is not the end-all-be-all of k6 improvement, and is just a start!
Testing Instructions

Checkout the repository and run ov init to get the new k6 and words dependency.
Now run ov just k6 frontend static-en -e scenario_vus=1 -e scenario_iterations=1 and confirm it runs! You might get blocked by Cloudflare, but you should see at least the HTML output of the Cloudflare managed challenge page :grin:
Checklist

[x] My pull request has a descriptive title (not a vague title likeUpdate index.md).
[x] My pull request targets the default branch of the repository (main) or a parent feature branch.
[x] My commit messages follow best practices.
[x] My code follows the established code style of the repository.
[x] I added or updated tests for the changes I made (if applicable).
[x] I added or updated documentation (if applicable).
[x] I tried running the project locally and verified that there are no visible errors.
[N/A] I ran the DAG documentation generator (ov just catalog/generate-docs for catalog
PRs) or the media properties generator (ov just catalog/generate-docs media-props
for the catalog or ov just api/generate-docs for the API) where applicable.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.

Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

Oh, of course, I should have been testing that way to begin with! :facepalm:


Feature/descw 420 add change request

Pull Request Considerations
Although some of these things can only be done after merged, please ensure all items have been considered when doing pull requests.

Updated README.md(s) for new functionality or changes.
Did you update .env / create a new environment variable?

Did you update/create an explanation in the appropriate README.md file for it?
Did you make/update an Openshift configmap/secret template for it?

Have you changed any Openshift configurations/templates?

Did you execute the appropriate oc process command on the template to put the configmap/secret in openshift?

Did changes trigger Openshift image rebuilds?

Check Openshift instance of application to ensure your changes are working.

Did you update the changelog CHANGELOG.md.

used to keep track of development changes including (env changes, docker changes, functionality changes)
help developers keep track of new/updating changes in code.

@ASpiteri-BCGov and I discussed the PR and I'm approving the work. There's no linter to check for commented out code so that's a non-blocking issue(although I feel we should either remove it or comment that it needs to stay for some reason).
Also, I really feel we need to be doing validation/sanitization of data with this app. Looks like there isn't really much at the moment. To me, this is crucially important and should be part of MVP.


keep deploying binary of app

PR for https://github.com/tw93/Pake/issues/615, tested ok locally.

Archive it first. I see some messages that have not been answered yet. If you see them, please try again and reopen them. Thank you!

@tw93 How about now? 😄

@liudonghua123 🤔Need you to modify the code here
https://github.com/tw93/Pake/pull/616/files

Hi, I rebased the pr, and it works still.


Incorrect resolutions served for images set as background

Bug Description
Since v1.9.0, the incorrect image resolution is being served for images that are set as background on stories, as reported by a support user. Even when a high-res image is uploaded, the image that is served is for fit=450.
Looks like this goes back to https://github.com/google/web-stories-wp/pull/8099.
Expected Behaviour
Images should display at the correct resolution.
Steps to Reproduce

Create a new story
Set an image as a background image
View in browser

Screenshots
Affected story: https://selectgame.gamehall.com.br/web-stories/anuncio-de-company-of-heroes-3/
Uploaded image: https://i1.wp.com/selectgame.gamehall.com.br/wp-content/uploads/2021/07/Company-of-Heroes-3-PC-Screenshot-03.jpg
Served image (on slides 2 and 3): https://i1.wp.com/selectgame.gamehall.com.br/wp-content/uploads/2021/07/Company-of-Heroes-3-PC-Screenshot-03.jpg?fit=450%2C253&ssl=1
Additional Context

Plugin Version: 1.9.0
WordPress Version: All
Operating System: All
Browser: All

Do not alter or remove anything below. The following sections will be managed by moderators only.
Acceptance Criteria

Implementation Brief

@choumx This seems like a reincarnation of the blurry images issue. Background images are a bit different in final output, so it's possible that the current solution doesn't work well for them. Mind taking a look?

Ah it's because the current sizes generation doesn't account for image zoom factor. Should be a straightforward fix.
Ideally these zoomed images would be cropped instead, which would make image loading faster (avoid downloading parts of the image that won't be seen by users). Something that we can consider for the future.

Verified in QA
Before:

After:


convert Daylight SMILES using indigo api

Describe the solution you'd like
There is the main idea of the issue to start using API call /convert to convert ket format to  Daylight SMILES
Additional context
we've got 2 a bit different realizations Daylight SMILES converter. So we'd like to remove the ketcher implementation of that.

https://github.com/epam/ketcher/issues/1703


[realsense2] Update version to v2.51.1

What does your PR fix?
See release notes of v2.51.1

Which triplets are supported/not supported? Have you updated the CI baseline?
Unchanged

Does your PR follow the maintainer guide?

Yes

All features passed with following triplets:
x86-windows
x64-windows


Mongo driver 4 rc no auth defaults

This was tested locally with a server with authentication on.
The following was the result:
 MONGODB_URL="mongodb://bedrock_mongodb_test-user:password@localhost:27017/bedrock_mongodb_test" npm t
{
  url: 'mongodb://bedrock_mongodb_test-user:password@localhost:27017/bedrock_mongodb_test',
  connectOptions: {
    serverSelectionTimeoutMS: 30000,
    promoteBuffers: true,
    forceServerObjectId: true,
    writeConcern: { w: 'majority', j: true }
  }
}
... test results all passed

THIS PR IS NOT FINISHED DO NOT REVIEW YET

Codecov Report

Merging #93 (ad561c7) into mongo-driver-4-rc (1b4c0e6) will increase coverage by 2.40%.
The diff coverage is 50.00%.

@@                  Coverage Diff                  @@
##           mongo-driver-4-rc      #93      +/-   ##
=====================================================
+ Coverage              87.08%   89.48%   +2.40%
=====================================================
  Files                      8        8
  Lines                    813      742      -71
=====================================================
- Hits                     708      664      -44
+ Misses                   105       78      -27

Impacted Files
Coverage Δ

lib/authn.js
83.72% <ø> (+6.67%)
:arrow_up:

lib/index.js
81.85% <0.00%> (+0.71%)
:arrow_up:

lib/test.config.js
100.00% <ø> (ø)

lib/urls.js
91.48% <ø> (+6.30%)
:arrow_up:

lib/config.js
100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


[11.x] Add a whitelist ips for throttle request

These changes are useful for companies with static IPs and crawlers

You could just define this in your rate limiter definitions.


[Feature] Add Click Through Rate (CTR) Calculator

Description
A CTR Calculator is a tool used to calculate the Click-Through Rate (CTR) of an online advertisement or a website link. CTR is a critical metric in digital marketing that shows how effective an ad or link is in driving users to click on it
Screenshots
No response
Checklist

[X] I have checked the existing issues.
[X] I follow Contributing Guidelines of this project.
[ ] I am a KWOC'24 contributor.

Code of Conduct

[X] I agree to follow this project's "Code of Conduct".

hii @Rakesh9100 I would like to work on this, can you assign it to me.

Go ahead @SanikaBhalerao1345

Any update of your PR @SanikaBhalerao1345

@Rakesh9100 still working on it. will raise a pr by tomorrow

@Rakesh9100 pls check my pr


Enhancement stream tvf support compress

Proposed changes
example:
curl -v --location-trusted -u root: -H "sql: insert into test.t1(c1, c2) select c1,c2 from http_stream(\"format\" = \"CSV\", \"compress_type\" = \"GZ\",\"column_separator\" = \",\")" -T all_types.csv.gz http://<IP_ADDRESS>:8030/api/_http_stream

Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

run buildall

run buildall


Add dl.linspace

Closes #613

This change is

Review status: 0 of 3 files reviewed at latest revision, 2 unresolved discussions, some commit checks failed.

src/math/array_ops.ts, line 325 at r1 (raw file):
Previously, nsthorat (Nikhil Thorat) wrote…
looks like we duplicate with range, can we consolidate and use the same logic (one calls the other)?

I don't think we can. Each one calculates something in a different way (either step, or the number of elements).

Comments from Reviewable

Review status: 0 of 3 files reviewed at latest revision, 1 unresolved discussion.

src/math/array_ops.ts, line 444 at r2 (raw file):

  @operation
  @doc({heading: 'Tensors', subheading: 'Creation'})
  static linspace(start: number, stop: number, num: number, endpoint = true) {

let's get rid of endpoint to be exactly TF

Comments from Reviewable

src/math/array_ops.ts, line 444 at r2 (raw file):
Previously, nsthorat (Nikhil Thorat) wrote…
let's get rid of endpoint to be exactly TF

Okay. I'll keep in mind for future reference that we are targeting TF compat and not numpy.

Comments from Reviewable

src/math/array_ops.ts, line 444 at r2 (raw file):
Previously, tafsiri (Yannick Assogba) wrote…
Okay. I'll keep in mind for future reference that we are targeting TF compat and not numpy.

Though i do use numpy to generate test cases... It should be exactly the same this case though.

Comments from Reviewable


Added map web component shadow paths styling example

Example of web component styling using shadow paths
Screenshot: Styled (top), unstyled (bottom)

Thanks Julia- made those changes.


how to add backend for the app?

start a new project? any suggestions?
What steps will reproduce the problem?
What is the expected result?
What do you get instead?
Additional info

Q
A

Version
1.0.?

PHP version

Operating system

What do you mean by "add backend"?

just like the backend of yii2-app-advanced

In a similar way i.e. create another entry point etc. but there's almost no need for it in Yii 3 since it's way more flexible about directory structure.

@samdark Could you please describe how we might reorganize a large Yii2 advanced app (backend, frontend, console, and single vendor folder) into a directory structure that is recommended for Yii3?  I am reviewing https://github.com/yiisoft/app and this demo, but it is not clear what the migration path is from a Yii2 advanced app to Yii3 single app.
Would each of our top level apps sit side-by-side, each using the Yii3 single app directory structure, so that backend and frontend can each have config/ and a public/ entry point?  If that is done, would there need to be multiple sets of vendor/ and composer.json for each of our backend and frontend apps?  That seems like a lot of redundancy, though flexible.
Also, we rely heavily on the Yii2 concept of modules and routing with a tiered structure: app > modules > controllers.  I see in the demo that src/ has Blog/, and the config/routes.php has a Route Group of /blog and several Blog/*Controller entries named specifically.  In Yii3 Routing, is there a concept of pattern matching of a URI path part to a src/ subdirectory "module" and Controller without specifically naming them all in routes.php?  Could you provide an example of this pattern structure?  This is unclear from https://github.com/yiisoft/router.  Thank you.

We recently added host support to the router, now you can split the admin (aka backend) by specifying the host. For example:
Group::create()->routes(
    // your admin routes here.
)->host('admin.{_host}') // just use FastRoute regex

Will documentation be provided for how to manually migrate a former Yii2 advanced application template to a Yii3 single application?

@jasonkovacs-tim eventually.


issue with fake ban

if anyone can help i been tryna see how to fix it
all it does is change my name but doesnt put the text in chat

u gotta disconnect from the server OR do team damage


MS should be able to claim reward after settle period ends

As per our conversation with @palango and @Dominik1999 in the chat.
It makes no sense to claim a reward after the channel data has been removed. Instead we should only wait until the end of the settlement period.
@pirapira : My system only has solc v0.5.5 and as such I can't run make compile contracts. Got no time to compile solidity by hand for v0.5.4 now so I would like to see if someone else can do it. If not I will just have to bite the bullet at some point.
Also is this the file you are supposed to change to introduce changes?

It makes no sense to claim a reward after the channel data has been removed. Instead we should only wait until the end of the settlement period.

I agree.

Also is this the file you are supposed to change to introduce changes?

Yes, since last week.
#747 supersedes this PR.


[UI] Adapt the slider navigation in dark mode

Category

[ ] Resource Addition
[ ] Documentation
[ ] Codebase
[x] User Interface
[ ] Feature Addition

Description
Currently, slider navigations are not displayed correctly in dark mode (view image below). Adjust its style to fix this.

Hey @Elaa257, you're assigned!

Hey @Sriparno08, please have a look if my changes fit your style :)


Imodulon vs regulon

Adds a new imodulon_vs_regulon plot. Closes #83
Anyone have other functionality that should be added?

Final commit has the specific changes, the previous commits are part of a different pull request

Looks great! My only comment is on the capitalization in the axes labels -- either de-capitalize "Regulon" or capitalize "shared genes" and "size". Given that the rest of the package tends toward more capitalization, I'd say to capitalize all the words in the axes labels.
If possible, a legend with the size ranges would be cool. But I don't think it's necessary.

Looks great! My only comment is on the capitalization in the axes labels -- either de-capitalize "Regulon" or capitalize "shared genes" and "size". Given that the rest of the package tends toward more capitalization, I'd say to capitalize all the words in the axes labels.

Done

If possible, a legend with the size ranges would be cool. But I don't think it's necessary.

I'll add it to the issue tracker


CarouselView with forms-to-fill as Items

Hello, Guys!
Can you help me? I wanna make RegisterPage where user will register his account in my app. And I wanna make page with carouselview. First, user fill first three entries and click button "Next", then carouselview will select second part (second form as item of carouselview), but second form is different by amount of entries (has two entries, not three like in first part), and has button "OK".
Screenshots how it would be are attached.

You need to use a DataTemplateSelector to decide which content to display in the CarouselView. An update to the docs on doing this is underway, courtesy of https://github.com/dotnet/maui/issues/21161


Fix personal voice sample code URL link error.

Purpose
Fix personal voice sample code URL link error.
Pull Request Type
What kind of change does this Pull Request introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[x] Documentation content changes
[ ] Other... Please describe:

/azp run


New template divisions nested-form

User can update label, starting page, and ending page of template divisions from the exam template.

still working on it

Please fix the merge conflicts here.


char-rnn

I am reading the code of https://github.com/dmlc/mxnet/blob/master/example/rnn/char-rnn.ipynb
I am wondering the sym_gen
# generate symbol for a length def sym_gen(seq_len):     return lstm_unroll(num_lstm_layer, seq_len, len(vocab) + 1,                        num_hidden=num_hidden, num_embed=num_embed,                        num_label=len(vocab) + 1, dropout=0.2)
why the input_size of one-hot is len(vocab)+1 not len(vocal) ? and so the num_label?

Hmm, the most recent code doesn't have the + 1.
https://github.com/dmlc/mxnet/blob/master/example/rnn/lstm_bucketing.py#L39
@pluskid @antinucleon  notebook outdated?

+1 is probably reserving a special symbol for zero-padding. If you break your data into equal length chunks, there is no need for padding. But if you use variable-length sentence, and use Bucketing, probably you will need an extra symbol for padding.

This issue is closed due to lack of activity in the last 90 days. Feel free to reopen if this is still an active issue. Thanks!


fix: fix notification/subscription with postgres DB issues

close #4947
close #4952
close #4949
close #4951

If your build fails  due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/edgex-go/blob/main/.github/Contributing.md
PR Checklist
Please check if your PR fulfills the following requirements:

[x] I am not introducing a breaking change (if you are, flag in conventional commit message with BREAKING CHANGE: describing the break)
[x] I am not introducing a new dependency (add notes below if you are)
[ ] I have added unit tests for the new feature or bug fix (if not, why?)
[x] I have fully tested (add details below) this the new feature or bug fix (if not, why?)
[ ] I have opened a PR for the related docs change (if not, why?)

Testing Instructions

New Dependency Instructions (If applicable)

:warning: Please install the  to ensure uploads and comments are reliably processed by Codecov.
Codecov Report
Attention: Patch coverage is 0% with 14 lines in your changes missing coverage. Please review.

Project coverage is 31.84%. Comparing base (5583a75) to head (23a7b39).

Files with missing lines
Patch %
Lines

...ternal/pkg/infrastructure/postgres/subscription.go
0.00%
4 Missing :warning:

.../support/notifications/application/notification.go
0.00%
4 Missing :warning:

.../support/notifications/application/subscription.go
0.00%
4 Missing :warning:

...ternal/pkg/infrastructure/postgres/notification.go
0.00%
2 Missing :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4967      +/-   ##
==========================================
- Coverage   31.87%   31.84%   -0.04%
==========================================
  Files         265      265
  Lines       19351    19357       +6
==========================================
- Hits         6168     6164       -4
- Misses      11782    11790       +8
- Partials     1401     1403       +2

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Adding inverse option to allow drag from the top to the bottom. Impro…

Adding inverse option to allow drag from the top to the bottom.
Improving code, typings and added default props.
Deleting non-used variables.
Updating README for a readable example.
Preventing crashes if the ir not an initial drawer view.

Fixed #13.

@yaraht17 please take a look! :)
Nice library.

@mateoguzmana  Thank for PR. It's look good, i will check soon.


Complication text on Pixel Watch 2 reversed

Don't know if this is PW2 only, but the trend is large while the bg is small which seems reversed from images I've seen from the G-Watch forum.
All faces I've tried are the same (except of course the G-Watch face).
With the PW2 small screen, the actual bg reading is tiny and hard to make out with slightly challenged short term vision.

Sorry, just saw this issue has been posted.


removed UPSTART_JOB test

As per #21:

The /UPSTART_JOB/ check was premature, and doesn't do the right thing.

This PR removes the test for it (needless test).

:+1: Thankd


Eliminate non-inclusive language

Hello, we have a project to eliminate non-inclusive language from the linux-system-roles.
Running a utility woke (now it's supported in tox. please install the latest tox-lsr and run tox -e woke), two non-inclusive words are reported - dummy and slave.
Can we replace them with more appropriate words? For the word dummy, placeholder, and sample are recommended. For slave, secondary, replica, responder, device,worker,proxy, and performer are the candidates. It looks to me that replacing dummy is straightforward. But not certain about slave. I wonder if it is doable? Or if we replace it, does it break the ha cluster? Thanks!

The HA Cluster team have been working on replacing non-inclusive language for several years. Major changes and progress have been done in RHEL 8.0 release, then with 9.0 / 8.5. However, due to the need of backward compatibility, we cannot just simply stop using old terms and keywords.
For the progress done, see for example:

https://bugzilla.redhat.com/show_bug.cgi?id=1542288
https://bugzilla.redhat.com/show_bug.cgi?id=1885293
https://wiki.clusterlabs.org/wiki/Pacemaker_2.0_Configuration_Changes
https://wiki.clusterlabs.org/wiki/Pacemaker_2.1_Changes

When writing the role, I took care to avoid using non-inclusive language as much as possible. I can remove non-inclusive language from the role completely. That would, however, make the role incapable of configuring HA Cluster on older RHEL releases.
For the backward compatibility reasons, master and slave cannot be removed. For example here the role checks if it can use the new term or needs to stick to the old one: https://github.com/linux-system-roles/ha_cluster/blob/2bf1767a9cf2e4d58aa9b0d7625c742402b298f3/tasks/create-and-push-cib.yml#L187-L195
It is a similar story with dummy. I can rename cluster resources in tests and README.md form dummy to sample. However, ocf:pacemaker:Dummy must be kept in place until it is renamed in pacemaker. And even after that, the role would have to keep ocf:pacemaker:Dummy in tests for backward compatibility.

Thank you, @tomjelinek. I've opened a pr https://github.com/linux-system-roles/ha_cluster/pull/97 to introduce the conscious language check action woke.yml and to clean up / workaround the problematic words. To be honest, the latter part is quite invasive. I'd appreciate if you could review the pr. Thanks!

Resolved by #97


liburing seems to compile for ARM despite not being used

I may be wrong - but it seems as tho this is getting compiled on non-x86 platforms - updating the lib causes arm ci to go very slow, whereas i think it should be a noop in terms of ci caches

cc @soulxu

seems i was wrong about the arch thing - closing


Incorrect parsing of IIFE

A fairly common form of IIFE is to enclose the function in parens, followed by another set of parens which are used to pass in a global object, such as window or jQuery. In Babel we can do the following:
(exports) =>  {
  var foo = (msg) => console.log(msg);
  exports.foo = foo;
}(window);

This returns;
(function (exports) {
  var foo = function foo(msg) {
    return console.log(msg);
  };
  exports.foo = foo;
})(window);

But in your TypeScript playground I get this for the same expression:
(function (exports) {
    var foo = function (msg) { return console.log(msg); };
    exports.foo = foo;
});
(window);

Notice that the TypeScript transpiler is incorretly detach the final parens with window and putting it on the next line as a separate statement. This has the effect that window, or any other value, never gets passed to the IIFE. This pattern is often used in conjuction with jQuery or other libraries that use the same $:
($) =>  {
  $('li').addClass('jQuery-is-here');
}(jQuery);

Unfortunately TypeScript is incorrectly creating:
(function ($) {
    $('li').addClass('jQuery-is-here');
});
(jQuery);

Not sure about ES6 IIFE, but for normal IIFE, you need wrap a bracket to function.
((exports) =>  {
  var foo = (msg) => console.log(msg);
  exports.foo = foo;
})(window);

I think babel is wrong here. Babel also works for :
function (exports) {
    var foo = function (msg) { return console.log(msg); };
    exports.foo = foo;
}(window);

Making it :
(function (exports) {
    var foo = function foo(msg) {
        return console.log(msg);
    };
    exports.foo = foo;
})(window);

TypeScript errors which is consistent with how a browser would error

Thanks S-YOU, that works in TypeScript and Babel. Didn't think about wrapping the whole expression in parens ;-)


Deploy latest NitroAdjudicator to Rinkeby

#3016

#3016

Can you place

Fixes https://github.com/statechannels/statechannels/issues/3015
in the description of #3016 instead? This links the issue to the PR.


fw get-path

Get path of project. Usefull for shell scripts.

Implemented with https://github.com/brocode/fw/commit/536729085c48657639a42cf486d6e94b34f19f2f and release in 1.0.4


Error executing lua: /usr/local/share/nvim/runtime/lua/vim/uri.lua:105: URI must contain a scheme: .../About/index.module.css

Info

Operating System: macOS 12.3.1

Shell: zsh

Terminal: Alacritty

nvim --version:
NVIM v0.8.0-dev+33-g116a3f468
Build type: Release
LuaJIT 2.1.0-beta3

fzf --version: 0.30.0 (brew)

[ ] The issue is reproducible with minimal_init.lua: I think this cannot be reproduced via minimal since it will need tsserver, cssmodule_ls, etc.

fzf-lua configuration

require('fzf-lua').setup({
})

Description
I have a shortcut to run vim.lsp.buf.definition(). Initially, it did work. But suddenly it didn't: (Sorry that I cannot have a full-screen video, this is a private project.)
To be more specific, it's this is a TypeScript project and the file I ran against is a foo.module.css file. The problem only happened in such files.(i.e. There is no problem running this shortcut against the Page in the DEMO) I have created a type definition file for it:
declare module '*.module.css'
declare module '*.module.scss'

https://user-images.githubusercontent.com/24765272/164749364-c87549a5-b872-4339-8617-b0fada11270d.mov
E5108: Error executing lua: /usr/local/share/nvim/runtime/lua/vim/uri.lua:105: URI must contain a scheme: /Users/ningwang/Unity/MyProj/src/App/About/index.module.css
stack traceback:
        [C]: in function 'assert'
        /usr/local/share/nvim/runtime/lua/vim/uri.lua:105: in function 'uri_to_fname'
        /usr/local/share/nvim/runtime/lua/vim/lsp/util.lua:1575: in function 'locations_to_items'
        .../pack/packer/start/fzf-lua/lua/fzf-lua/providers/lsp.lua:38: in function 'handler'
        .../pack/packer/start/fzf-lua/lua/fzf-lua/providers/lsp.lua:207: in function 'set_lsp_fzf_fn'
        .../pack/packer/start/fzf-lua/lua/fzf-lua/providers/lsp.lua:300: in function 'v'
        .../pack/packer/start/fzf-lua/lua/fzf-lua/providers/lsp.lua:835: in function 'lsp_definitions'
        [string "..."]: in function <[string "..."]:0>
Press ENTER or type command to continue

The issue seems to come from neovim’s lsp source code,
/usr/local/share/nvim/runtime/lua/vim/uri.lua:105: in function 'uri_to_fname'
/usr/local/share/nvim/runtime/lua/vim/lsp/util.lua:1575: in function 'locations_to_items'

Does this happen only for definitions or for references, symbols, etc?
Does this happen only for specific files or all files?

@ibhagwan: I just got a similar conclusion after some testing. The error only occurs If I have cssmodules_ls installed. I'm pretty sure it's the culprit because I remove all LSP clients when testing.

Does this happen only for definitions or for references, symbols, etc?

There is no problem with lsp_references. It occurs on:

lsp_definitions
lsp_implementations

I just got a similar conclusion after some testing. The error only occurs If I have cssmodules_ls installed. I'm pretty sure it's the culprit because I removed all LSP clients and add them back one by one when testing. So it's good news that this is not related to neovim,tsserver, etc, which I think is harder to fix.

Good find, closing.
If this becomes relvant again you can reopen.

So I should ask the maintainer of cssmodules_ls for help?

So I should ask the maintainer of cssmodules_ls for help?

That would probably be the best guess though if it were me, and since this is lua code, I'd first try to get more details what causes this issue by placing some print statemets around the runtime's /usr/local/share/nvim/runtime/lua/vim/uri.lua:105 to understand what is exaclty causing this failure.

local URI_SCHEME_PATTERN = '^([a-zA-Z]+[a-zA-Z0-9.+-]*):.*'
I know very little about regex. So it seems that foo.module.css will break this scheme?


tekton yaml linting and dependency scanner, outliner ms-vscode

there's a tekton pipelines plugin for ms-vscode which also works in eclipse che https://github.com/eclipse/che/issues/15752#issuecomment-582907777
I see there's a ci/cd project called concourse and they have a work in progress for a yaml linter for pipelines and tasks: https://github.com/spring-projects/sts4/tree/master/vscode-extensions/vscode-concourse
right now using the tekton+kubernetes plugin having a ~/.kube/config in the sidecar container and the tekton controller/webhook pods running in the cluster make the plugin work as expected. pressing F1 and using the "kubernetes apply" action over a pipelinerun.yaml offers to create the resource and taskrun can be seen after updating the tekton pipelines section of the IDE.
I hope there's place and time and interest in adding specific linting for the yaml schemas used by tekton. the default yaml plugin already provides outline function

area/dogfooding

@gattytto thanks for the issue. There is some started work on that (https://github.com/tektoncd/pipeline/pull/1776) I think :wink:
/kind feature
/area yamls

ms-vscode extensions can be deployed in eclipse che (Theia web ide that loads ms-vscode extensions) with the help of sidecars to hold the tools, configs and volumes. development environments called workspaces can be defined using yaml devfiles.
Here is eclipse Che project's issue that follows the adoption of Tekton definitions in the builtin devfile editor.
https://github.com/eclipse/che/issues/16304
and here is che pr regarding first steps of adoption to Tekton and octant:
https://github.com/che-dockerfiles/che-sidecar-tekton/pull/2

/reopen

/remove-lifecycle rotten

/remove-lifecycle stale

/remove-lifecycle rotten


Unparse SubqueryAlias without projections to SQL

Which issue does this PR close?

Closes #.
Rationale for this change
Consider the following SQL
SELECT
  c.custkey,
  c.name
FROM
  (
    SELECT
      c_custkey as custkey,
      c_name as name
    FROM
      customer
  ) c

The unoptimized plan is
Projection: c.custkey, c.name
  SubqueryAlias: c
    Projection: customer.c_custkey AS custkey, customer.c_name AS name
      TableScan: customer

However, after the optimize_projections rule, the top-level projection will be removed like
SubqueryAlias: c
  Projection: customer.c_custkey AS custkey, customer.c_name AS name
    TableScan: customer projection=[c_custkey, c_name]

The unparsing result would like
SELECT
  customer.c_custkey AS custkey,
  customer.c_name AS "name"
FROM
  (
    SELECT
      customer.c_custkey,
      customer.c_name
    FROM
      customer
  ) AS c

It's an invalid SQL because the column qualifier is the table name customer but it's in the alias c scope actually.

What changes are included in this PR?
When unparsing a SubqueryAlias without any projections, we should create another scope for the alias like
SELECT
  *
FROM
  (
    SELECT
      customer.c_custkey AS custkey,
      customer.c_name AS "name"
    FROM
      (
        SELECT
          customer.c_custkey,
          customer.c_name
        FROM
          customer
      )
  ) AS c

Are these changes tested?
yes

Are there any user-facing changes?
The unparsing result is changed.

FYI @phillipleblanc and @sgrebnov

LGTM 👍

Thanks @sgrebnov @findepi and @phillipleblanc  for the review

Thanks @alamb @sgrebnov @findepi @phillipleblanc !


[Low-prio] Add config option for camelCase

A user complained that the variable is called \resultMyVariable, when they expected \resultmyVariable having declared it with the string "my variable". We could add a config flag for that, such that the first letter is not capitalized. However, I like our approach here better as "result" and "my" are two separate words here.

Will close for now. If lots of users want this, we could still introduce it later on.


getting started run_quil.py example needs to clarify download of source requirement

Closed by #477 thanks @vtomole!


added to readme

just made a small change by adding to readme to see if working properly

I'm going to reject this PR. I've asked Luis to fetch the changes from dev and start the process over.


[SPARK-13674][SQL] Add wholestage codegen support to Sample

JIRA: https://issues.apache.org/jira/browse/SPARK-13674
What changes were proposed in this pull request?
Sample operator doesn't support wholestage codegen now. This pr is to add support to it.
How was this patch tested?
A test is added into BenchmarkWholeStageCodegen. Besides, all tests should be passed.

Test build #52460 has started for PR 11517 at commit f14393a.

Test build #52460 has finished for PR 11517 at commit f14393a.

This patch fails PySpark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/52460/
Test FAILed.

Merged build finished. Test FAILed.

Test build #52546 has started for PR 11517 at commit 7d50f5f.

Test build #52546 has finished for PR 11517 at commit 7d50f5f.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/52546/
Test PASSed.

cc @davies @nongli

Test build #52726 has started for PR 11517 at commit 6144810.

Test build #52726 has finished for PR 11517 at commit 6144810.

This patch passes all tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
class GapSampling(
trait PoissonGE
class GapSamplingReplacementIterator[T: ClassTag](
class GapSamplingReplacement(

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/52726/
Test PASSed.

Test build #53665 has started for PR 11517 at commit 0cb714b.

Test build #53665 has finished for PR 11517 at commit 0cb714b.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/53665/
Test PASSed.

Test build #54409 has started for PR 11517 at commit 28073d5.

Test build #54409 has finished for PR 11517 at commit 28073d5.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/54409/
Test PASSed.

@davies This is rebased. Please take a look. Thanks.

@viirya Could you also add numOutputRow for Sample ?

Test build #54614 has started for PR 11517 at commit fa51f62.

Test build #54614 has finished for PR 11517 at commit fa51f62.

This patch fails MiMa tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
class PoissonSampler[T](

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/54614/
Test FAILed.

Merged build finished. Test FAILed.

Test build #54618 has started for PR 11517 at commit 76be6cf.

Test build #54618 has finished for PR 11517 at commit 76be6cf.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/54618/
Test FAILed.

retest this please.

Test build #54620 has started for PR 11517 at commit 76be6cf.

Test build #54620 has finished for PR 11517 at commit 76be6cf.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/54620/
Test FAILed.

Not sure why the test failed..

retest this please.

Test build #54629 has started for PR 11517 at commit 76be6cf.

Test build #54629 has finished for PR 11517 at commit 76be6cf.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/54629/
Test PASSed.

Test build #54686 has started for PR 11517 at commit ef588db.

Test build #54690 has started for PR 11517 at commit 6dfecf1.

Test build #54686 has finished for PR 11517 at commit ef588db.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/54686/
Test PASSed.

Test build #54693 has started for PR 11517 at commit 12e1b37.

Test build #54693 has finished for PR 11517 at commit 12e1b37.

This patch fails MiMa tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/54693/
Test FAILed.

retest this please.

Test build #54696 has started for PR 11517 at commit 12e1b37.

Test build #54690 has finished for PR 11517 at commit 6dfecf1.

This patch passes all tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
case class BatchPythonEvaluation(udfs: Seq[PythonUDF], output: Seq[Attribute], child: SparkPlan)
      // enable memo iff we serialize the row with schema (schema and class should be memorized)

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/54690/
Test PASSed.

Test build #54696 has finished for PR 11517 at commit 12e1b37.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/54696/
Test PASSed.

Merged build finished. Test PASSed.

Chatted with @mengxr , it's OK to remove the class tag.
LGTM, merging this into master, thanks!


rearrange Pause and stop buttons

I like the idea of the pause button but currently I think it might cause problems when playing a script due to the pause and the stop button being next to each other which causes the stop button to be overlaying into the actual game screen (see image)

my suggestion would be to either rearrange those buttons to be above each other or to be able to shift them around separately should you decide to keep the pause button

Stop button always overlays the game for users with 16:9 screens, like on my old phone.
It doesn't cause any problems when both buttons are side-by-side. I considered this before placing them like that.
But, if the pause button is above stop button, the script can click on pause when trying to scroll in support selection.
Moving them around separately isn't a good idea either because pause button is something that disappears when the script is not running and it is not good to mess with the screen when script is running (sure, you could pause the script and do that, but I'm still against it).


Docker issue

Hi !
when I run the below command -
docker run -it --gpus all --shm-size 128G -v "$(pwd)":/workspace zx1239856/uni-3d:0.1.0
I get the following error -
bash: /workspace/.bashrc: Permission denied
can you guide me about the what could be the issue?

It might be because your host UID does not match the one inside docker container, and therefore the privilege is insufficient for the bind mount $(pwd) directory.
You may want to perform the modification as below. If you use vscode dev containers it will automatically handle this for you.
https://code.visualstudio.com/remote/advancedcontainers/add-nonroot-user#_change-the-uidgid-of-an-existing-container-user


Can rustup be used to create a toolchain with nightly Cargo and stable rustc?

If so, how?

I don't believe so, but I'm not 100% sure.

(At the same time, every cargo is a nightly cargo, so every toolchain comes with a nightly cargo and stable rustc, so it's also not 100% clear exactly what you want)

I'm interpreting it as "a toolchain with a stable rust and an arbitrary cargo that's not the one paired with that stable rust"

Yup, that's right. Basically I want to try out this feature from Cargo : https://github.com/rust-lang/cargo/pull/3000 , only available in nightly currently, but otherwise use stable Rust.

That's not possible with rustup, and it's not something that can ever really be supported since cargo is not guaranteed to be compatible with any rustc other than the one it is paired with (although in practice it will probably work with most).
If you want, you could try installing both a stable and nightly toolchain, and manually copy across the cargo binary, but it may just break your toolchain.

@matklad mentioned "However you could use nightly Cargo with stable rustc!" in the PR comments. However, if that's true that using nightly cargo with stable rustc might introduce instabilities of its own, might as well use the entire nightly toolchain. I guess it won't take that long for things to move into beta anyways. 😮

cargo is not guaranteed to be compatible with any rustc other than the one it is paired with (although in practice it will probably work with most).

Hm, is this really so? I always thought that Cargo can use any rustc. At least, there is some code for backward compatibility. @alexcrichton could you clarify backwards/forwards compatibility story between Cargo and rustc?

Let me add two use cases for this feature:

Cargo gains a new useful feature, which you would like to use with otherwise stable toolchain. The recent example would be workspaces.

Rustc gains a new feature, which needs some support from Cargo as well. But support in Cargo is implemented only after the rustc, so they may end up in different releases. This what happened with json errors.


Toolbar icons are missing.

All the toolbar icons are missing, and are replaced with some text. See screenshot, please. I've cloned the repo, installed the theme from within mailspring, and it told me that it was installed. Applied the theme and the icons are missing. Tried rebooting, but that didn't fix it. Are there any additional things I need to do beside installing the theme?

Mailspring version: 1.9.2
Operating System: Manjaro Linux
KDE Plasma Version: 5.24.3
KDE Frameworks Version: 5.91.0
Qt Version: 5.15.3
Kernel Version: 5.15.28-1-MANJARO (64-bit)
Graphics Platform: X11
Processors: 8 × Intel® Core™ i7-8550U CPU @ 1.80GHz
Memory: 15.4 GiB of RAM
Graphics Processor: Mesa Intel® UHD Graphics 620

Hi @KarkanAlzwayed ,
i don't have linux, so i didn't foresee it. To fix this you have 2 options.
Option 1:
Use the original Mailspring icons. Go to the installation folder  ~/11-light/styles/
open the file index.less and comment or delete the line with @import custom-icons ;
Option 2:
Still in the same folder, open the file custom-icon.less  and replace the path where the theme is located.
Original:
@baseurl:" ../../../../../../Roaming/Mailspring/packages/11-light/img  .
Example of your custom path:
@baseurl:" ~/.config/Mailspring/packages/11-light / img  .

@GianniLab The second option actually worked, but not the way you did it. I had to add the full path to the theme before installing it from mailspring. I used this path @baseurl:"/home/kalzi/.config/Mailspring/packages/11-light/img"; So, thanks for that.
I do have a small question if you don't mind, is this icon in the below screenshot supposed to be this big?

@KarkanAlzwayed I was not sure if the path was valid not having familiarity with linux. Still glad to know you solved it. Thanks to your contribution I will now update the description and the file with the path ready for linux.


[TE-276] Introduce an error on exceeding 128 size

This is the fix in the case we don't want to replace base58 crate. Now our base58 refuses to accept data/strings longer than 128 bytes.
This is still a compromised solution. It is possible to introduce a completely new hash type longer than 128 bytes that will cause panic, but that will be discovered very early during development. Also user input does not affect the length of the hashes being encoded. For decoding the error will be reported.

This is the fix in the case we don't want to replace base58 crate. Now our base58 refuses to accept data/strings longer than 128 bytes.
This is still a compromised solution. It is possible to introduce a completely new hash type longer than 128 bytes that will cause panic, but that will be discovered very early during development. Also user input does not affect the length of the hashes being encoded. For decoding the error will be reported.

ok, I will check, and we also need to refactor hash.rs, see this https://simplestakingcom.atlassian.net/browse/TE-228

This is the fix in the case we don't want to replace base58 crate. Now our base58 refuses to accept data/strings longer than 128 bytes.
This is still a compromised solution. It is possible to introduce a completely new hash type longer than 128 bytes that will cause panic, but that will be discovered very early during development. Also user input does not affect the length of the hashes being encoded. For decoding the error will be reported.

ok, I will check, and we also need to refactor hash.rs, see this https://simplestakingcom.atlassian.net/browse/TE-228


FR: Support for adding apps to a Firebase project from a CI server

The CI server adds product flavors to our Android app. When a flavor is added, the project must be sync'ed
using the Firebase plugin in Android Studio, so that the new flavor is added to the Firebase project and the new "google-services.json" file is downloaded to the project.
We would like to be able to do that without Android Studio. If it was added to this project, one could create a custom Gradle plugin or create a command line tool for the task and execute that from the CI server.

I don't see how this could be part of Admin SDK. Can you please elaborate? What would the API for this would look like?

Something like:
FirebaseApp.initializeApp(options)

FirebaseProject.createApp(project, packageName, nickname, debugCertificate)
InputStream stream = FirebaseProject.downloadJson(packageName)

Or should this be in the firebase-tools project instead?

Yeah, this doesn't look like it belong in the Admin SDK. Also the usecase/API suggested here seems very Android-specific. As you mentioned it should probably be done in a separate tool or a Gradle plugin.
Try reporting this at https://github.com/firebase/firebase-tools (although I'm not sure whether that's the right place for this request either). I would also recommend you to reach out to the firebase-talk google group, where more Firebase devs can take a look at your requirement.

It was already there, so I posted a comment.
See:
https://github.com/firebase/firebase-tools/issues/319
You can close this issue.


fixed issue#2147 - [closed]

In GitLab by @liyanq528 on Jun 27, 2019, 09:14
Merges issue#2147 -> dev

In GitLab by @wknet123 on Nov 13, 2019, 11:46
The test coverage for backend is 18.1%  38.48%  , check  console log

In GitLab by @wknet123 on Nov 13, 2019, 11:46
closed


Clean dangling calls to old Point-In-Time APIs

Description
Per #135, there are references to point in time APIs supported by ElasticSearch that we don't support. This PR:

Removes the references to these APIs from the spec
Removes all builders for these APIs from opensearch/src/root

Of note is that there is some documentation I found for PITs in OpenSearch under _search. It may also be worth looking at implementing these structs for the alternative API rather than removing them entirely. For the moment I just took the easy way out.
Issues Resolved
Resolves #135
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@Swiddis not against removal but may be we could refactor those to support PITs create / delete APIs instead, wdyt?

@Swiddis not against removal but may be we could refactor those to support PITs create / delete APIs instead, wdyt?

Would probably be ideal to refactor, though I have to familiarize myself with these APIs first to see how feasible it is. Will look into it. In the meantime can I get the issue assigned to me?

@Swiddis not against removal but may be we could refactor those to support PITs create / delete APIs instead, wdyt?

Would probably be ideal to refactor, though I have to familiarize myself with these APIs first to see how feasible it is. Will look into it. In the meantime can I get the issue assigned to me?

Thank you, for some reasons I cannot assign it to you, seems like the assignee is constrained ...

@Swiddis not against removal but may be we could refactor those to support PITs create / delete APIs instead, wdyt?

Would probably be ideal to refactor, though I have to familiarize myself with these APIs first to see how feasible it is. Will look into it. In the meantime can I get the issue assigned to me?

Thank you, for some reasons I cannot assign it to you, seems like the assignee is constrained ...

You can't assign external users unless they've participated in the issue/PR (i.e. commented on it), so if @Swiddis comments on the issue saying they're working on it, then it'll be able to be assigned to them.

Updated based on my best interpretation of the specification under _search.

Codecov Report

Merging #136 (ed742fe) into main (8885a98) will decrease coverage by 0.58%.
The diff coverage is n/a.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
@@            Coverage Diff             @@
##             main     #136      +/-   ##
==========================================
- Coverage   65.08%   64.51%   -0.58%
==========================================
  Files         312      311       -1
  Lines       51702    51118     -584
==========================================
- Hits        33652    32978     -674
- Misses      18050    18140      +90

Flag
Coverage Δ

integration
64.51% <ø> (-0.58%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.
see 19 files with indirect coverage changes
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

LGTM! Thanks a lot @Swiddis ! @Xtansia mind double checking please?


Fixes crash after remove_line in RichTextLabel

This fixes #32736

Keeps lines.size() > 0

ItemFrame should always have at least one line, even when it's empty.

This is what the constructor and clear function of RichTextLabel keeps.

Other codes assume this is true, using lines[lines.size() - 1] without check.

To reproduce the crash, you can either use the reproduction project in the original issue, or use the following script:
extends RichTextLabel

func _process(_delta: float) -> void:
	remove_line(0)
	push_list(RichTextLabel.LIST_DOTS)

Thanks!


"console": "integratedTerminal" not working

Does this issue occur when all extensions are disabled?: Yes/No

VS Code Version: 1.66.2
OS Version: local win10, remote Linux

Steps to Reproduce:

Set the launch.json as follows. Note that  "console": "integratedTerminal" is specified, so the debug launch should start from the integrated terminal, rather than the debug console.
{
"name": "(cuda-gdb) Launch Leaf Algo",
"type": "cuda-gdb",
"request": "launch",
"program": "${workspaceFolder}/regera/Blazer/MercuryImageComputer/KT/leaf/M31/BrightField/bin/LeafStandalone/Debug/12/LeafStandAlone.x86-64",
"args": "-noForcedPatches ${workspaceFolder}/virgo_dependency/imc_integration/jobdumps_for_ziqi/R0C0S_master_0_cpu0_JobInfoRL_14205_s4_j13_ID_0 ${workspaceFolder}/virgo_dependency/imc_integration/jobdumps_for_ziqi/AlgoParams.xml",
"stopAtEntry": true,
"environment": [],
"console": "integratedTerminal",
"MIMode": "gdb",
"setupCommands": [
{
"description": "Enable pretty-printing for gdb",
"text": "-enable-pretty-printing",
"ignoreFailures": true
},
{
"description":  "Set Disassembly Flavor to Intel",
"text": "-gdb-set disassembly-flavor intel",
"ignoreFailures": true
}
]
}
You may observe that debug starts from the debug console.

This is an issue for the debug extension


Offckb init produces an error on Windows.

The following error is received on Windows when trying to use the command offckb init test:
C:\Users\Username\Desktop>offckb init test
? Select a Dapp template View and Transfer Balance
start cloning the dapp template..
(node:6504) [DEP0147] DeprecationWarning: In future versions of Node.js, fs.rmdir(path, { recursive: true }) will be removed. Use fs.rm(path, { recursive: true }) instead
(Use `node --trace-deprecation ...` to show where the warning was created)
node:fs:1508
  const result = binding.readdir(
                         ^

Error: ENOENT: no such file or directory, scandir 'C:\Users\Username\AppData\Roaming\nvm\v20.12.0\node_modules\@offckb\cli\templates\temp-clone-folder\examples\simple-transfer'
    at Object.readdirSync (node:fs:1508:26)
    at copyFolderSync (C:\Users\Username\AppData\Roaming\nvm\v20.12.0\node_modules\@offckb\cli\dist\util.js:63:22)
    at gitCloneAndDownloadFolderSync (C:\Users\Username\AppData\Roaming\nvm\v20.12.0\node_modules\@offckb\cli\dist\util.js:171:5)
    at init (C:\Users\Username\AppData\Roaming\nvm\v20.12.0\node_modules\@offckb\cli\dist\cmd\init.js:24:46)
    at C:\Users\Username\AppData\Roaming\nvm\v20.12.0\node_modules\@offckb\cli\dist\cli.js:35:28
    at Generator.next (<anonymous>)
    at fulfilled (C:\Users\Username\AppData\Roaming\nvm\v20.12.0\node_modules\@offckb\cli\dist\cli.js:6:58)
    at process.processTicksAndRejections (node:internal/process/task_queues:95:5) {
  errno: -4058,
  code: 'ENOENT',
  syscall: 'scandir',
  path: 'C:\\Users\\Username\\AppData\\Roaming\\nvm\\v20.12.0\\node_modules\\@offckb\\cli\\templates\\temp-clone-folder\\examples\\simple-transfer'
}

This was observed using Node v20.12.0 LTS (newest LTS via nvm) on Windows 11.

https://github.com/RetricSu/offckb/pull/51

@jordanmack can you try if newest version 0.1.0-rc8 solve your issue?

@jordanmack can you try if newest version 0.1.0 solve your issue?

Yes, this is fixed in v0.1.0.


Similar to WSLg #877 but now Illegal instruction at address 0x7fed3c8ac259 on Intel Core i7-14700K

Windows Version
Microsoft Windows [Version 10.0.22631.4541]
WSL Version
<IP_ADDRESS>
Are you using WSL 1 or WSL 2?

[x] WSL 2
[ ] WSL 1

Kernel Version
<IP_ADDRESS>-1
Distro Version
Ubuntu 24.04
Other Software
Inside WSL Ubuntu, GUI apps stopped working after new CPU install.
After several hours of troubleshooting, I determined it's almost the exact problem described at wslg#877 https://github.com/microsoft/wslg/issues/877
(cannot open display: :0, /tmp/.X11-unix empty without symlink)
Except I'm getting "Illegal instruction at address 0x7fed3c8ac259" with a new Intel Core i7-14700K.
I've had to disable the CPU integrated display adapter to get WSLg working again, which is less than ideal, since I generally use both the NVIDIA card and the CPU integrated graphics for separate monitors.
Posting here for others. It's possible this resulted from overclocking configuration, or it's something Intel needs to fix.
Repro Steps

Install Intel Core i7-14700K
Open WSL Ubuntu
Try to run a GUI app

Expected Behavior
GUI app launches
Actual Behavior
$: cannot open display: :0
Diagnostic Logs
No response

/question
Advisory


Add support for "custom" models

Can you add please support for custom models with generic prompts? Its will be great combination with a openai proxy.

Sorry, I'm not sure I understand what you are requesting. Can you provide more details?

thank you for creating Aider. It’s been a great help to me and I’m sure to many others as well.
I was wondering if it’s possible to use other open-source LLMs instead of GPT models or along side GPT models. I think this feature would be useful for other users as well.

like StarCoder with langhcain to replace OpenAI function calling

I recently published a package llm-client that can be very helpful in enabling the support to run other LLM models, including OpenAI, Google, AI21, HuggingfaceHub, Aleph Alpha, Anthropic, Local models with transformers.

This FAQ entry provides some information about using aider with other LLMs:
https://github.com/paul-gauthier/aider/blob/main/docs/faq.md#can-i-use-aider-with-other-llms-local-llms-etc

I'm going to close this issue, but feel free to re-open if there's more you'd like to discuss about this.


Modify context generation slightly (xrefs)

Truncate xrefs, so that the source code of the entire function(s) xref'ing the function under test is not included.
Additionally, modify context generation so we talk about lines where the code is xref'd, as opposed to functions.

/gcbrun request_pr_exp.py -n dg-272

@trashvisor Could you please check if the report:

Has any unexpected behavior (e.g., failed to include certain xrefs)
Significant improvements / regressions?
https://llm-exp.oss-fuzz.com/Result-reports/ofg-pr/2024-05-15-272-dg-272-comparison/index.html
Thanks!

if not, I reckon this is ready to merge.

/gcbrun request_pr_exp.py -n oc-272

A silly question:
What is the intention of this block in the prompt?
I noticed that it adds the function declaration, which is the same as the function signature added earlier.
Related:
https://github.com/google/oss-fuzz-gen/blob/39bebbaad6087a1f1486faa8045c04a6ca268b7b/llm_toolkit/prompt_builder.py#L165

A silly question: What is the intention of this block in the prompt? Is it to mitigate the 'undefined function' error?
I noticed that it adds the function declaration, which is the same as the function signature added earlier.
Related:
https://github.com/google/oss-fuzz-gen/blob/39bebbaad6087a1f1486faa8045c04a6ca268b7b/llm_toolkit/prompt_builder.py#L165

It was originally intended to solve:

Not having the appropriate header file for the function declaration (so we would just embed the function decl itself without a header and things might work).
Compatibility with c programs, as an extern "C" would be added to solve linkage issues.

Should this block be removed or some templating logic added?

It was originally intended to solve:

Not having the appropriate header file for the function declaration (so we would just embed the function decl itself without a header and things might work).

Ah, thanks for the explanation!
I doubt this will help LLM get the correct header file, though:

We already have the signature in the prompt, so this doesn't add new information.
LLM is not good at searching for the corresponding header file given the function signature, it can only guess.

But don't worry; AdaLogic will look into finding the correct header file in a more programmatic way.

Compatibility with c programs, as an extern "C" would be added to solve linkage issues.

In this case, maybe:

Make the instruction more explicit, e.g.,

Include the following extern C linkage specification in the fuzz target, because the function-under-test is defined in C and the fuzz target is written in C++:
extern ''C" <function-signature>

Only add this code if the project-under-test is in C.

Would this sound reasonable? Thanks : )


wd_helper.au3 ++ _WD_GetBrowserVersion() ++ _WD_GetWebDriverVersion()

These feature have been separated into separate functions to make it possible for the user to check it by themself.
MsgBox(0, "", _WD_GetBrowserVersion('chrome') & @CRLF & _
		"@error = " & @error & @CRLF & _
		"@extended = " & @extended & @CRLF & _
		"")
MsgBox(0, "", _WD_GetWebDriverVersion(@ScriptDir,'chromedriver.exe') & @CRLF & _
		"@error = " & @error & @CRLF & _
		"@extended = " & @extended & @CRLF & _
		"")

I'll have to take a closer review of your proposed changes, but a few things on my initial observation --

There are changes to other functions that are unrelated to the described PR.
Since the proposed new functions are being "ripped" from _WD_UpdateDriver, listing yourself as the author is a stretch ;-)

There are changes to other functions that are unrelated to the described PR.

	Local $sData = InetRead($sURL, $iOptions)
	$iErr = $_WD_ERROR_GeneralError

this part was modified because InetRead states:
Failure: | "" (empty string) and sets the @error flag to non-zero.
Which mean that you can not be sure which value will be set to @error

Since the proposed new functions are being "ripped" from _WD_UpdateDriver, listing yourself as the author is a stretch ;-)

fixed

this part was modified because helpfile for InetRead says:
Failure: | "" (empty string) and sets the @error flag to non-zero.
Which mean that you can not be sure which value will be set to @error

That's fine, but IMO it should have been a separate PR because it doesn't have anything to do with the _WD_GetBrowserVersion() and _WD_GetWebDriverVersion(), which is what this PR is concerning.

I hope that now all is fine, because I still learn how github works.

Something went wrong with "Resolve conflict" will check it.