LoadFromString is unnecessary and wrong

In #93 the LoadFromString method was added to the D2D and Pas factories.  This was unnecessary and wrong.
The proper way of loading from a string is to use the Source property of ISVG.  This also sets the FSource field of the underlying D2D implementation.
Please remove LoadFromString.

I'll remove them since only the collection really needs them.. but I'm curious how that is different from LoadFromStream etc... LoadFromString calls LoadFromStream.

It doesn't set the encoding to UTF8 which is assumed by LoadFromStream.

Don't bother removing them.  I will do it since I want to merge some changes and there is a merge conflict.

I already pushed a PR.  I can close it.. but still want to keep the LoadFromString on the collection.


Broken Button component

5.3.1
Webpack

After upgrading from 5.1.8 to 5.3.1 there is a problem with Button component. TS shows an error:
Type error: Type '{ label: string; }' is missing the following properties from type 'Pick<ComponentProps, "onClick" | "ref" | "key" | "defaultChecked" | "defaultValue" | "suppressContentEditableWarning" | "suppressHydrationWarning" | "accessKey" | "className" | ... 349 more ... | "onAuxClickCapture">': onAuxClick, onAuxClickCapture  TS2739
and this is how code looks like:
<Button label="Login"  />
Compilation crashed. Also error shows up in the sandbox.

This has to do with your local package.lock file. I haven't been able to pinpoint what would have changed between versions, but removing your local lock file and re-installing fixes it which leads me to believe it is some internal issue with npm dependency  resolution, not the lib itself

Ok, but take a look here, please: https://codesandbox.io/s/q8334l777j The Button component is underlined and error message is very similar to mine :)

The sandbox and link you sent me is working as expected. This lends more credence to my theory this is a third party issue since I definitely didn't make any changes that would've fixed the broken sandbox. Please reopen if you run into this again.

5.6.0
create-react-app

After updating from 5.2.2 to 5.6.0, I'm experiencing a similar error as the original poster:
'{ children: string; raised: true; className: string; }' is missing the following properties from type 'Pick<ComponentProps, "ref" | "cite" | "data" | "form" | "span" | "style" | "summary" | "title" | "pattern" | "tag" | "theme" | "accept" | "acceptCharset" | "action" | "allowFullScreen" | ... 343 more ... | "onAuxClickCapture">': onAuxClick, onAuxClickCapturets(2739)
I tried re-generating my package-lock.json and manually updating @rmwc/button (I install all modules through rmwc) but those did not fix the issue.

Are you able to create a repro? This would be extremely hard to troubleshoot since it appears to be an isolated issue.
One thing that might be causing problems is multiple versions of the same package. Try running npm dedupe

I was unable to reproduce and npm dedupe didn't work. However, updating my React version from 16.8.4 to 16.9.0 fixed the issue. Maybe onAuxClick was incorrectly non-optional in that version of React.


Broken Link for Spoof Detections Report

The link provided for the Spoof Detections report of https://security.microsoft.com/reports/SpoofMailReportV2 does not work to open the report directly (when already signed into a global admin account with access to the security & compliance center).  Wondering where this report can be found now?
Thanks!
Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: e130b60f-b97b-cfb1-4857-a08e79fdfd59
Version Independent ID: 19e405c4-a6c0-7c75-b925-ff9637f1889e
Content: Anti-spoofing protection - Office 365
Content Source: microsoft-365/security/office-365-security/anti-spoofing-protection.md
Product: m365-security
Technology: mdo
GitHub Login: @chrisda
Microsoft Alias: chrisda

@MidniteA, fixed. The correct link is:
https://security.microsoft.com/reports/SpoofMailReport
Thanks for the feedback.
Closing

Thank you, much appreciated!
From: Chris Davis @.>
Sent: Thursday, March 17, 2022 11:46 AM
To: MicrosoftDocs/microsoft-365-docs @.>
Cc: Miller Bonnie L. @.>; Mention @.>
Subject: Re: [MicrosoftDocs/microsoft-365-docs] Broken Link for Spoof Detections Report (Issue #8045)
*** Use caution responding to or opening attachments and links in this email. It is not from Mukilteo SD.***
@MidniteAhttps://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FMidniteA&data=04|01|millerbl%40mukilteo.wednet.edu|a570021875764f9e6ecf08da08465cba|a2d4d43f15d149d48d873e7d7dc64397|0|0|637831395545487246|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000&sdata=t07wmegNdqLRNWqBfw7nGICLCs7jeWmBzIALRaPi8Ec%3D&reserved=0, fixed. The correct link is:
https://security.microsoft.com/reports/SpoofMailReporthttps://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fsecurity.microsoft.com%2Freports%2FSpoofMailReport&data=04|01|millerbl%40mukilteo.wednet.edu|a570021875764f9e6ecf08da08465cba|a2d4d43f15d149d48d873e7d7dc64397|0|0|637831395545487246|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000&sdata=bDS71ZyK%2BzCEIlPcaAic0T8%2B9LJM48ow114%2B4DVio9I%3D&reserved=0
Thanks for the feedback.
Closing
—
Reply to this email directly, view it on GitHubhttps://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FMicrosoftDocs%2Fmicrosoft-365-docs%2Fissues%2F8045%23issuecomment-1071205649&data=04|01|millerbl%40mukilteo.wednet.edu|a570021875764f9e6ecf08da08465cba|a2d4d43f15d149d48d873e7d7dc64397|0|0|637831395545487246|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000&sdata=FAOnJB%2FKFSVmvOcLJIqGcpUWoqAU6pGC6cv94LImLLU%3D&reserved=0, or unsubscribehttps://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAOXYIKMFCJEWR6S4AR2ASN3VAN4V7ANCNFSM5Q66CT4Q&data=04|01|millerbl%40mukilteo.wednet.edu|a570021875764f9e6ecf08da08465cba|a2d4d43f15d149d48d873e7d7dc64397|0|0|637831395545487246|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000&sdata=uJFVHwHY1hqofFFbLfG46HlZrV341832rDOzMZW27U4%3D&reserved=0.
Triage notifications on the go with GitHub Mobile for iOShttps://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fapps.apple.com%2Fapp%2Fapple-store%2Fid1477376905%3Fct%3Dnotification-email%26mt%3D8%26pt%3D524675&data=04|01|millerbl%40mukilteo.wednet.edu|a570021875764f9e6ecf08da08465cba|a2d4d43f15d149d48d873e7d7dc64397|0|0|637831395545487246|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000&sdata=oszPjoa%2FVq4lrhI2%2FzYvrvTyYUo%2BidW6fMg8yoxnCbg%3D&reserved=0 or Androidhttps://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fplay.google.com%2Fstore%2Fapps%2Fdetails%3Fid%3Dcom.github.android%26referrer%3Dutm_campaign%253Dnotification-email%2526utm_medium%253Demail%2526utm_source%253Dgithub&data=04|01|millerbl%40mukilteo.wednet.edu|a570021875764f9e6ecf08da08465cba|a2d4d43f15d149d48d873e7d7dc64397|0|0|637831395545487246|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000&sdata=WhEU24HoVH4HDbnRKenS50ZQakdgO1VH%2BFHWpCAwXA4%3D&reserved=0.
You are receiving this because you were mentioned.Message ID<EMAIL_ADDRESS>


Statements must return Unit

There's another type which statements should be able to return - it's the other uniquely inhabited type which is always handy when you're returning from a method. It was something I realized after I was no longer interested in improving the compiler, else the warnings about value discarding would exclude it.
I'm referring to this.type. It is used frequently where people would otherwise return Unit because a.b.c is a lot nicer than { a.b ; a.c }. No need to punish people overmuch for that convenience.

:+1:


[Question]: How can I use host or ipvlan?

Is your question not already answered in the FAQ?

[X] I made sure the question is not listed in the FAQ.

Is this a general question and not a technical issue?

[X] I am sure my question is not about a technical issue.

Question
I am currently trying to use ipvlan or host network mode so i can get real local ip from my router (iptime) and set firewall correctly (without <IP_ADDRESS>)
I tried to fix this by myself, but there are some errors such as connection refused, unreachable
is it available to use ipvlan or host mode on virtual dsm?
Here is my docker-compose.yml
version: "3"
services:
    dsm:
        container_name: dsm
        image: vdsm/virtual-dsm:7.04
        environment:
            DISK_SIZE: "48G"
            RAM_SIZE: "2G"
            CPU_CORES: "2"
            URL: "https://global.synologydownload.com/download/DSM/release/7.2.1/69057-1/DSM_VirtualDSM_69057.pat"
            CONSOLE: "Y"
        devices:
            - /dev/kvm
        device_cgroup_rules:
            - 'c *:* rwm'
        cap_add:
            - NET_ADMIN
        ports:
            - 5000:5000
            - 5001:5001
            - 80:80
        volumes:
            - //c/docker_dsm:/storage
        networks:
            vdsm:
                ipv4_address: <IP_ADDRESS>
        restart: always
        stop_grace_period: 2m
networks:
  vdsm:
    driver: ipvlan
    driver_opts:
      parent: eth0
    ipam:
      driver: default
      config:
        - subnet: <IP_ADDRESS>/24
          gateway: <IP_ADDRESS>
          ip_range: <IP_ADDRESS>/24```

Host or ipvlan are not supported, only bridge and macvlan.

If I use macvlan, the console shows wrong IP that is not fit with iptime's DHCP ip range (it starts with <IP_ADDRESS>~)
version: "3"
services:
    dsm:
        container_name: dsm
        image: vdsm/virtual-dsm:7.04
        environment:
            DISK_SIZE: "48G"
            RAM_SIZE: "2G"
            CPU_CORES: "2"
            URL: "https://global.synologydownload.com/download/DSM/release/7.2.1/69057-1/DSM_VirtualDSM_69057.pat"
            CONSOLE: "Y"
            DHCP: "Y"
        devices:
            - /dev/kvm
            - /dev/vhost-net
        device_cgroup_rules:
            - 'c *:* rwm'
        cap_add:
            - NET_ADMIN
        ports:
            - 5000:5000
            - 5001:5001
            - 80:80
        volumes:
            - //c/docker_dsm:/storage
        networks:
            vdsm:
                ipv4_address: <IP_ADDRESS>
        mac_address: 1C:69:74:09:72:E3
        restart: always
        stop_grace_period: 2m
networks:
  vdsm:
    external: true

with this message
dsm  | ❯ -----------------------------------------------------------
dsm  | ❯  You can now login to DSM at http://<IP_ADDRESS>:5000
dsm  | ❯ -----------------------------------------------------------
dsm  |
dsm  | [   55.929172] findhostd uses obsolete (PF_INET,SOCK_PACKET)
dsm  | [   59.761099] fuse init (API version 7.23)

Is there something wrong with what i have done?

Yes, many things look wrong..
Firstly: the container and the VM will both get their own IP if you set DHCP=Y, and they are completely seperated. But you are totally mixing them. You created a macvlan network that has the same range as the iptime, thats not good because it can give conflicts. Next you assign an address to the container (<IP_ADDRESS>) that is in your iptimes range. Dont do it.
Also you are setting a mac address for the container, I dont know why. But dont do that because DHCP servers lease IP based on MAC, so if that MAC is the same as your DSM MAC it will give conflicts.
Also you set CONSOLE: "Y" for some reason? I would not do that because it prevents the container from shutting down gracefully and corrupts the disk, its only for emergencies.

Oh, I thought i would connect to iptime's DHCP with that macvlan
and sorry for questioning a lot ;(
I changed the macvlan network to
docker network create -d macvlan --subnet=<IP_ADDRESS>/24 --gateway=<IP_ADDRESS> --ip-range <IP_ADDRESS>/24 -o parent=eth0 vdsm
and removed CONSOLE: "Y"
version: "3"
services:
    dsm:
        container_name: dsm
        image: vdsm/virtual-dsm:7.04
        environment:
            DISK_SIZE: "48G"
            RAM_SIZE: "2G"
            CPU_CORES: "2"
            URL: "https://global.synologydownload.com/download/DSM/release/7.2.1/69057-1/DSM_VirtualDSM_69057.pat"
            DHCP: "Y"
        devices:
            - /dev/kvm
            - /dev/vhost-net
        device_cgroup_rules:
            - 'c *:* rwm'
        cap_add:
            - NET_ADMIN
        ports:
            - 5000:5000
            - 5001:5001
            - 80:80
        volumes:
            - //c/docker_dsm:/storage
        networks:
            vdsm:
                ipv4_address: <IP_ADDRESS>
        restart: always
        stop_grace_period: 2m
networks:
  vdsm:
    external: true

These options are not working because of download issue
I think this is pretty hard to set, so i need to go back to bridge mode :(

Sadly I tried to use the method you told
default -> set da DSM -> add assign an individual IP command -> addDSM acquire an IP address from my router command
when adding assign an individual IP command i got "You can now login to DSM at http://<IP_ADDRESS>:5000" well
but still got "You can now login to DSM at http://<IP_ADDRESS>:5000" message that is not fit with my iptime's DHCP range lol

Actually, I can't access both on other machine and host
and there is also 100+ problem

What other containers do you recommend? I'm not really used to Docker..

I said i can ping to <IP_ADDRESS> when it was 192.168.0.X not <IP_ADDRESS>
I tried to connect on other PC and host and it showed me refused to connect (same with other browser)
Maybe you're right, Docker Desktop for Windows does not support macvlan even with WSL2


Radix Accordion generated with foreach and external function freezes

Describe the bug
It shows up correctly, but after clicking on any item, all items open at the same time and the whole accordion freezes. No error message on console or backend.
This has worked with Chakra accordion.
To Reproduce
    @rx.cached_var
    def accordion(self) -> list[str]:
        return ['item1','item2','item3']

def accordion_level1(name) -> rx.Component:
    return rx.accordion.item(
        header=name,
        content=name,
    )

rx.accordion.root(
    rx.foreach(State.accordion,accordion_level1)),
),

Expected behavior
Working like chakra accordion.
Screenshots
If applicable, add screenshots to help explain your problem.
Specifics (please complete the following information):

Python Version: 3.9.2
Reflex Version: 0.4.0
OS: debian11
Browser (Optional):

Additional context
Add any other context about the problem here.

Setting the accordion.item.value to a unique value solves the issue. Might be worth to mention in the docs.

This was introduced here https://github.com/reflex-dev/reflex/pull/2616/files#diff-820ba7d7b749dd4c726797c6c9802ee557bb45d16d28fa10ffef0f2c1c59e159R490-R491
We need a better default, users shouldn't have to know this.


Create doxie-2.1.12.yaml

Add Doxie 2.1.12

[Y] Have you signed the Contributor License Agreement?
[Y] Have you checked that there aren't other open pull requests for the same manifest update/change?

[Y] Have you tested your manifest locally with winget install -m <manifest>?

Microsoft Reviewers: Open in CodeFlow

Manifest validation & Installation were tested by Winget v0.1.41331:
PS S:\Git\GitHub\winget-pkgs\manifests\Doxie\Doxie> winget validate .\doxie-2.1.12.yaml
Manifest validation succeeded.
PS S:\Git\GitHub\winget-pkgs\manifests\Doxie\Doxie> winget install -m .\doxie-2.1.12.yaml
Found Doxie [Doxie.Doxie]
This application is licensed to you by its owner.
Microsoft is not responsible for, nor does it grant any licenses to, third-party packages.
Downloading https://download.getdoxie.com/DoxieSetup-2.12.2.exe
██████████████████████████████   208 MB /  208 MB
Successfully verified installer hash
Installing ...
Successfully installed!


allowing multiple request for a task

:tada: This issue has been resolved in version 1.2.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


0.x wip

@sdesai there is an interesting thing in here.  I noticed that wrapNode is called in different order so if the errorSelector returned anything but the value it would remove the whole value from the cache (size becomes 0), unless the errorSelector also provides the size.  By moving wrapNode, all is well in the universe.

Makes sense (James was asking about $size yesterday in general for the transforms he wanted to play around with - would wrapNode fix size also, if the node is already wrapped, but the value changed?).
I think we should think through the implications (does errorSelector need to be renamed, should all values pass through it - not just errors, and it's just a general transformValueForCache, what's the contract for what should be returned - value, atom, anything? etc.) and file an issue for this, if we're thinking of leveraging errorSelector for more than just error => error transforms (which seems like the original intent), and we can go from there in terms of moving it into the code base formally.


UI: All filters are used as 'or' instead of a mix of 'and/or'

Currently, if we try to do a search like Goku's Lineage and we want to add to the search all cards that have also Saiyan as the special trait, we got a search for all Goku's Lineage or all Saiyan cards. As we can see in the image below, we got a Leader card Son Goku & Pan which is a Saiyan/Earthling/Great Ape card.

Acceptance criteria:
Card Type, Color, Energy and Combo Energy should be treated as OR. Other fields should be AND.

Cierren esto


java.lang.NoSuchMethodError: org.apache.spark.sql.types.DecimalType$.Unlimited

spark-xml with spark 2.0 got the error,
Error in invokeJava(isStatic = TRUE, className, methodName, ...) :
  java.lang.NoSuchMethodError: org.apache.spark.sql.types.DecimalType$.Unlimited()Lorg/apache/spark/sql/types/DecimalType;
    at com.databricks.spark.xml.util.InferSchema$.<init>(InferSchema.scala:50)
    at com.databricks.spark.xml.util.InferSchema$.<clinit>(InferSchema.scala)
    at com.databricks.spark.xml.XmlRelation$$anonfun$1.apply(XmlRelation.scala:46)
    at com.databricks.spark.xml.XmlRelation$$anonfun$1.apply(XmlRelation.scala:46)
    at scala.Option.getOrElse(Option.scala:121)
    at com.databricks.spark.xml.XmlRelation.<init>(XmlRelation.scala:45)
    at com.databricks.spark.xml.DefaultSource.createRelation(DefaultSource.scala:66)
    at com.databricks.spark.xml.DefaultSource.createRelation(DefaultSource.scala:44)
    at org.apache.spark.sql.execution.datasources.DataSource.resolveRelation(DataSource.scala:315)
    at org.apache.spark.sql.DataFrameReader.load(DataFrameReader.scala:149)
    at org.apache.spark.sql.DataFrameReader.load(DataFrameReader.scala:122)
    at org.apache.spark.sql.

Thanks for reporting this. I should upgrade this. FYI, here is the related issue https://github.com/databricks/spark-xml/issues/137
I will submit a PR soon.

Let me tag this as a duplicate so that I can manage the similar issue together. If you strongly feel this is not a duplicate, I will remove the tag! Thanks again!

I have the same problem.

I opened a PR hrre, https://github.com/databricks/spark-xml/pull/150 . I will merge some other PRs and release 0.4.0 as soon as this one is reviewed.

I faced the same issue too.

I released 0.4.0 for Spark 2.x and 0.3.4 for Spark 1.x. So, this is resolved (manually tested). I am closing this. Please feel free to reopen if any of you faces this issue again. Thank all!

Hello, i am using "spark-xml_2.11-0.4.1.jar" in python and i am still having the same issue. Can you please help!

@ivaradagit use the 0.4.0 to avoid the error

I am using spark-xml_2.10-0.2.0.jar but still facing the same issue

I had this problem with 0.2.0. Switching to 0.4.0 solved it.

problem got resolved for me as well when switching to 0.4.0

same here with 0.4.0


interpolated-string can't handle an object

Steps to reproduce
Source the following script
vim9script

class C
endclass

var o = C.new()

echo printf("(printf) Object: %s", o)
echo $"(interp)Object: {o}"

Observe the error
(printf) Object: object of C {}
Error detected while processing command line..script /tmp/xxx:
line    9:
E1324: Using an object as a String
(interp)Object:

Expected behaviour
No error.
Version of Vim
9.0.1774
Environment
linux
Logs and stack traces
No response

In a :def you get
Error detected while compiling command line..script /tmp/xxx[17]..function <SNR>34_Foo:
line    4:
E1105: Cannot convert object to string

String interpolation expects the result of evaluating the expression in {} to be a string.  So this is an expected behavior.  You can use the string() function to convert the expression to a string.  You can try using echo $"(interp)Object: {o->string()}"

OK, I'll close it later. But note that the docs say

Any expression returning a value can be enclosed between curly braces.  The value is converted to a string.

Which seems to contradict the statement

expects the result of evaluating the expression in {} to be a string

I wouldn't expect
vim9script

var v = 777
echo $"int: {v}"

to work since v is not a string. But it does.

Only some types can be automatically converted to a string.  Refer to the may_generate_2STRING() function.

Got it, thanks for the reference. Closing not a bug


Added link to environment config

Added link to environment config
This pull request makes the following changes:

Added link to environment config
Added alternate option for using data url on external system through reverse proxy server

@MrIndiaDev I got a couple questions for you unrelated to this PR, but this seems to be the only way to really reach out to you. We noticed you've deployed search.maven.org and used a few hacks to get it working under a new URL. Being that you have the site deployed with our branding, it is at best a bit misleading, and essentially a mirror currently. I am mostly curious if you are using that site for just testing or what your long term plan for it is? You can reach out to me privately if you'd like, I was just unable to find a way to do so easily.
This change itself is innocuous PS, if you sign the CLA I'll get it merged when we have a chance!

@DarthHater To answer your questions

I was just testing the CORS hack I have done.
In no way I am planning to maintain this deployment for a longer, it was just a short term assignment that I picked out of curiosity to see the latest development done on it.
I'll sign the CLA asap.

@MrIndiaDev please sign the CLA as soon as you get a chance. I went ahead and merged this as the change is effectively trivial, but helpful to others! Thanks for the contribution! Also, thanks for the explanation. We were all kind of wondering what you were up to, sort of hard to read minds on the internets :)

CLA signed, Thanks


How to generate new config without manual input?

Hi.
I use Terraform + AWS. In the step, when the Terraform inside the AMI image launches the sudo docker run -v $ OVPN_DATA command: /etc/openvpn --rm -it kylemanna/openvpn ovpn_initpki I get an error because it generates new certificates and needs to be entered manually.
How to solve this problem using terraform?

Hi, you can solve this by using expect. You can use the following code and start automating according to your setup :smile:
#!/usr/bin/env bash
`DATE=$(date +%Y%m%d-%H%M)`
USERNAME=${1}
CAPASS=${2}
USERPASS=${3}
`DATE=$(date +%Y%m%d-%H%M)`
expect <<END
	spawn docker exec -it openvpn easyrsa build-client-full ${USERNAME}
	expect "Enter PEM pass phrase:"
	send ${USERPASS}\r
	expect "Verifying - Enter PEM pass phrase:"
	send ${USERPASS}\r
	expect "Enter pass phrase for /etc/openvpn/pki/private/ca.key:"
	send ${CAPASS}\r
	expect "Data Base Updated"
END

SAVEPATH="/home/$USER"

# For some reason the username contain newline that must be removed
USERNAME=${USERNAME//$'\015'}

# Fetch ovpn file and move to local folder
sudo docker exec -it openvpn ovpn_getclient $USERNAME > "$SAVEPATH/$USERNAME-$DATE.ovpn"

Thank you :+1:


descending date order for ledger snapshots?

We waste a lot developer's time and computing resources paging through the results just to find and fetch the latest ledger snapshot.
Is there way to just get the most recent? Or perhaps add a query parameter to order by metadata.timestamp with the newest timestamp first (or just default to it)?
Yes, you can sort the results you get but it's not always guarantee the newest snapshot will be on the initially returned page.

Hi Darlington,
Thanks for the feedback. This is a known issue and it's actually related to using AWS S3 as a "backend" of sorts. Unfortunately, the S3 API doesn't allow sorting by last modified date, it only supports sorting by lexicographical order. Doing sorting server-side would, of course, defeat the purpose of pagination.
I have a solution in mind, but I'm also the lead SRE and things tend to get busy around here during the fund 😄 . Hopefully I can get a fix out soon. I'll keep this issue open for tracking purposes.

Hi Darlington,
Thanks for the feedback. This is a known issue and it's actually related to using AWS S3 as a "backend" of sorts. Unfortunately, the S3 API doesn't allow sorting by last modified date, it only supports sorting by lexicographical order. Doing sorting server-side would, of course, defeat the purpose of pagination.
I have a solution in mind, but I'm also the lead SRE and things tend to get busy around here during the fund 😄 . Hopefully I can get a fix out soon. I'll keep this issue open for tracking purposes.

Thanks for the reply and background! Makes sense.
While a fix is being queue up, we've mirrored the archive in our system and added  it to our rest api with descending timestamp as the default order for anyone else having the same issue:
https://www.lidonation.com/catalyst-explorer/api#/ledger-snapshots

Nice! I have the solution working in our dev cluster. A few things:

The next field has been removed from the API response
Likewise, the associated query parameter has also been removed

Meaning, pagination is gone. The endpoint will return all archives at once. I will deploy it to production here shortly. Thanks for your patience :)

Changes are live now 😄  Closing this issue.


Added caml_ prefix for allocation functions

The release of OCaml 5.0.0 removed support removed support for old, unprefixed C runtime function names
such as alloc (#10863), preventing correct linking of the functions used in  gpml.c. (I got an error saying that I had an undefined reference to alloc_custom).
This PR fixes the issue by adding the required caml_ prefix for the allocation functions.

Thanks!


Improve handling of transaction index

Various feedback has been received around support for the txindex flag and our recent change to default it back to match Bitcoin Core.
I've defended this decision as I believe it is the right thing to do, but it has caused some users problems whom were relying on our hardcoded txindex value.
Two issues present on this (that I've seen):

Users who struggle to update a configuration file manually
Users who do not know where their configuration file is

Number 2) actually surprised me, but I've assisted a couple of users who for example have run Bitcoin Core before and chosen a custom datadir, subsequently uninstalled it and then when using OmniCore cannot find where the config file is located.
This small PR serves to address those two points by providing the configuration file location directly within the txindex disabled error message, and by offering to update it automatically on behalf of the user.
Feedback welcomed :)
Thanks
Z

I had huge reservation against those types of changes, but you convinced me immediately, not only with the picture, but also with the very un-intrusive code change - I really like it!
I'm going to test it shortly. Quick question in general: "OmniCore" or "Omni Core"? I'd prefer the later.

Quick question

Ah yes, oops - yeah it should be Omni Core :)

Still building locally, but just to outline what I'm looking for: odd scenarios. E.g.: what happens, if the user doesn't use the QT client at all?

Another one, but I think there is no nice way to handle it, and it's too improbable anyway: it's entirely possible that an user has explicitly txindex=0 in config.

E.g.: what happens, if the user doesn't use the QT client at all?

Yeah I tested that to make sure, it's not perfect but it doesn't seem problematic.  Below is output, no input is requested, it just shuts down.
zathras@coredev01:~/github/build/omnicore$ src/bitcoind --server --daemon --testnet
Bitcoin server starting
zathras@coredev01:~/github/build/omnicore$ : Disabled transaction index detected.

Omni Core requires an enabled transaction index. To enable transaction indexing, please use the "-txindex" option as command line argument or add "txindex=1" to your client configuration file within your data directory.

Configuration file: /home/zathras/.bitcoin/bitcoin.conf

Would you like OmniCore to attempt to update your configuration file accordingly?
Error: Please add txindex=1 to your configuration file manually.

OmniCore will now shutdown
2015-05-06 02:05:13 Omni Core shutdown completed

Another one, but I think there is no nice way to handle it, and it's too improbable anyway: it's entirely possible that an user has explicitly txindex=0 in config.

Yeah I tested that too, sadly it looks like a second directive does not override the first.  So:
txindex=0
txindex=1

inside the conf results in a disabled transaction index.  I did toy around with pulling the file into a stream and then manipulating it but it got quite 'clunky' so I figured this would cover 99% of cases.

I really love it, haha! :)

I did toy around with pulling the file into a stream and then manipulating it but it got quite 'clunky' so I figured this would cover 99% of cases.

Let's keep it simple.
One last question: \ntxindex=1\n is added. Do we need the second \n?

One last question: \ntxindex=1\n is added. Do we need the second \n?

I wasn't 100% sure whether it was safe to leave out a newline across all platforms so added it for good measure.

I wasn't 100% sure whether it was safe to leave out a newline across all platforms so added it for good measure.

Good point. This actually brings up another potential pitfall:
Unix uses "\n", Windows "\r\n" and Mac "\r" for a new line.
It was suggested to open the file in "at" mode, whereby "t" stands for text, which appearingly encourages fprintf to "translate" the new line properly. I tested it locally (Ubuntu) and it still works.
I propose the following:
diff --git a/src/init.cpp b/src/init.cpp
index 1725e6e..638e3df 100644
--- a/src/init.cpp
+++ b/src/init.cpp
@@ -1131,7 +1131,7 @@ bool AppInit2(boost::thread_group& threadGroup)
         if (fRet) {
             // add txindex=1 to config file in GetConfigFile()
             boost::filesystem::path configPathInfo = GetConfigFile();
-            FILE *fp = fopen(configPathInfo.string().c_str(), "a");
+            FILE *fp = fopen(configPathInfo.string().c_str(), "at");
             if (!fp) {
                 std::string failMsg = _("Unable to update configuration file at");
                 failMsg += ":\n" + GetConfigFile().string() + "\n\n";
@@ -1139,7 +1139,7 @@ bool AppInit2(boost::thread_group& threadGroup)
                 failMsg += _("Please add txindex=1 to your configuration file manually.\n\nOmni Core will now shutdown.");
                 return InitError(failMsg);
             }
-            fprintf(fp, "\ntxindex=1\n");
+            fprintf(fp, "\ntxindex=1");

Good point. This actually brings up another potential pitfall:

Ahhh the old carriage return line feed jazz hehe...  Cool will apply your patch :)

Just tested a clean install and allowed OmniCore to fix my conf (one didn't exist before) - don't think the CRLF is necessarily working correctly:
zathras@zathras-desktop:~/.bitcoin$ cat bitcoin.conf

txindex=1zathras@zathras-desktop:~/.bitcoin$

@zathras-crypto: isn't this expected?
No line break after the line, but one before?

No line break after the line, but one before?

Yeah I see - I think I just misinterpreted what you were saying & implemented your suggestion directly

I propose the following:

-            FILE *fp = fopen(configPathInfo.string().c_str(), "a");
+            FILE *fp = fopen(configPathInfo.string().c_str(), "at");
...
-            fprintf(fp, "\ntxindex=1\n");
+            fprintf(fp, "\ntxindex=1");

thinking the switch to text mode removed the need for a line break at the end - will add the last \n back in...
Thanks

Sorry, I can't follow? I initially proposed only the line break before the line, to avoid ending up with a scattered config like this:
line

line

line

Without line break at the end:
zathras@zathras-desktop:~/.bitcoin$ cat bitcoin.conf
existingconfigline1
existingconfigline2
existingconfigline3
existingconfigline4

txindex=1zathras@zathras-desktop:~/.bitcoin$

With line break at the end:
zathras@zathras-desktop:~/.bitcoin$ cat bitcoin.conf
existingconfigline1
existingconfigline2
existingconfigline3
existingconfigline4

txindex=1
zathras@zathras-desktop:~/.bitcoin$

To me the second seems 'cleaner'

True, this is cleaner.


feat(core): Added InvalidPropName exception to DynamicBase

Added InvalidPropNameException in DynamicBase.

Implicitly approved by @gjedlicska while I was coding it :D
All tests are a go so I'm merging this in!


Update simple-start-fixed-chart.js

It says Line in the comment, the prev chart was a line so I guess this was a typo.
BTW, nice Jobbs!

You are perfectly right my friend! :-) Thanks for the PR!

No! Thank you guys for this amazing lib!


Add organisation brand colour for Department for Business & Trade

Trello card
This change should be removed after relevant govuk-frontend release.
What
We are updating the labelling of Department of International Trade to Department for Business & Trade.
Why
This is part of the Supporting Government changes work (departments updates).

@baisa the failures in the visual regression tests should disappear if you rebase this branch against main - it uses the main branch as the baseline for testing, and I think another PR with some visual changes got merged ahead of this one.


ngRouteNames applied to all routes in app

My app uses .NET MVC routes for unauthenticated pages, but once a user has been authenticated, they enter Angular SPA land where I had originally been using the built-in $routeProvider.  I accomplish this by applying the ng-view directive in the view for the only authenticated MVC route in my app (Home/Index).
I've implemented ngRouteNames to this app and the route naming works great.  The problem I just noticed is that when I go to the unauthenticated pages outside of my Angular routing, it somehow ends up applying routing to it.
Any idea why it would be doing this?

hmm do you have an otherwise block in your $routeProvider?
Something like:
    $routeProvider.otherwise({
        redirectTo: '/'
    });

Yes.
.otherwise(
{
    templateUrl: 'Content/templates/404.html'
});

What happens when you visit an unauthenticated page?

It's the .when('/', {}) home route that it's running...

So the home / root route is defined?
What is the effect of routes running when you are on that page?

The problem is that the home route has a number of dependencies in it's resolve definition.  When you're on unauthenticated pages now, it incorrectly thinks it's on the home route (when it shouldn't be running the route code at all) and tries to resolve the dependencies.  The dependencies for that route require the user to be authenticated and fail when they run when unauthenticated.

hmm.. You might have to check if authenticated in the resolve code.
Then, if the route doesn't change when authenticated, $watch or $on authentication run the code.
I'm not sure you can turn off routes

This is something the ngRouteNames directive is doing. The second I remove it, it works a expected. I'm not really inclined to do much rewriting of my code because of route naming.

I'll have a look


Typo "～@schema_name～"→"～@schema_name～"

Bold with escape characters
https://docs.microsoft.com/en-us/sql/relational-databases/tables/system-versioned-temporal-tables-with-memory-optimized-tables?view=sql-server-ver15

@hyoshioka0128 : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@hyoshioka0128 : Thanks for your contribution! The author(s) have been notified to review your proposed change.

Formatting fix looks good/verified; thanks @hyoshioka0128.

Formatting fix looks good/verified; thanks @hyoshioka0128.


Update packages to less vulnerable versions

Dev Proxy is pretty straightforward for upgrading. The only package not fully upgraded is http-proxy-middleware because it has a breaking change to remove Node 10.x support. If this is not important, I would strongly suggest taking http-proxy-middleware 2.0.1 in a future change

I have planned to move all my projects to Node 16 soon since thats what I am doing locally too. And maybe transform to ESModules while I am at it.


program immedaitely closing on launch, if HD2 is running

Command window shows for split second.

Can you try starting the program from command prompt? That should allow you to see an error message, hopefully.

Traceback (most recent call last):
File "hd2_macros_main_.py", line 4, in
File "hd2_macros\macro.py", line 108, in main
File "hd2_macros\config.py", line 65, in read_config
File "tomllib_parser.py", line 66, in load
File "tomllib_parser.py", line 102, in loads
File "tomllib_parser.py", line 326, in key_value_rule
File "tomllib_parser.py", line 369, in parse_key_value_pair
File "tomllib_parser.py", line 598, in parse_value
File "tomllib_parser.py", line 409, in parse_one_line_basic_str
File "tomllib_parser.py", line 575, in parse_basic_str
File "tomllib_parser.py", line 494, in parse_basic_str_escape
tomllib.TOMLDecodeError: Unescaped '' in a string (at line 24, column 35)
[13164] Failed to execute script 'main' due to unhandled exception!

It sounds like you may have a problem in the config.toml -- the latest version of the default config file doesn't have anything meaningful on line 24, so I'm guessing you're using your own TOML file that has some kind of syntax error in it.
You can use sites like this one to validate your TOML file and try to fix any issues. Or if you can provide it here, I can try and help spot the issue.

Line 24 is:
autohotkey_executable_path = "C:\Program Files\AutoHotkey\v2\AutoHotkey64.exe"

it started working once i commented this line. thanks for help.


fix: mobile view navbar responsiveness

fix #23

fix #23

Please add a screenshot of the fix

@ankitrout2903


Add manual discovery setting

This patch adds the ability to manually configure the IP address of the Konnected Alarm Panels in the event that the auto discovery process does not work.

Just listing the possible scenarios why the auto discovery wouldn't work:

UPnP is turned off
SSDP is blocked

If there are any more scenarios please advise.

I think I have it working now - I’m on a different project until next week
jwm
Jack W. McClurg
Founder
McClurg Century Investments
303.799.1732 office
Confidentiality Notice: The information contained in this e-mail is legally privileged and confidential information intended only for the use of McClurg Century Investments and its intended recipients. If the possessor of this e-mail is not the intended recipient, you are hereby notified that any dissemination, distribution, or copying of the information in this e-mail is strictly prohibited. If you have received this e-mail in error, please, do not disclose this data to any other person and please notify the sender immediately at<PHONE_NUMBER>.

From: Mike Kormendy @.>
Sent: Monday, May 30, 2022 11:50:55 AM
To: konnected-io/homebridge-konnected @.>
Cc: Subscribed @.***>
Subject: Re: [konnected-io/homebridge-konnected] Add manual discovery setting (PR #3)
Just listing the possible scenarios why the auto discovery wouldn't work:

UPnP is turned off
SSDP is blocked

If there are any more scenarios please advise.
—
Reply to this email directly, view it on GitHubhttps://url.emailprotection.link/?bkzyOaL7BGxVjaV6UeLnorpHv-WuTXnBtnEQ_Qo2v-WLwyfLhbPD07PDH8lN3ZhIzyBcug1NIbg-66HFczFTmEHtdViq7AxO94P-qCjrwOQIXk-KViFUjGBu5MweOqFt_, or unsubscribehttps://url.emailprotection.link/?bktJ8IU6WESX0mb5fsvSrkNg2COxmL66_QGogaeM93k6eWMherg9tFO3WSXr2jyHncSDYz-3KMslAQ39Po5cv35wCpusy02H3froVygxkUKZPeZ98vUokyzUPsOdkx9rqf9dNzMC_5EDx_51j8Ao76ocT6ldMAL_qYKW33uKBVJA~.
You are receiving this because you are subscribed to this thread.Message ID: @.***>

@jackmacdawg I have no idea what you mean.

Mike – I spoke to soon.  Homebridge still can’t find the Konnected controllers.  They show up in my Konnected app even if I’m on another VLAN.  Meraki switches don’t support SSDP but I put an explicit rule in anyway.  I assume you meant to say UPnP is turned on as that is the message I get from the Konnected Pluggin in Homebridge.  I understand it UPnP is also not explicitly supported on my MS210 switches however the Homebridge server and the Konnected devices are on the VLAN.  Here are the messages
Homebridge v1.4.1 (HAP v0.10.2) (Konnected) is running on port 55627.
[31/05/2022, 15:38:27] [Konnected] Listening for zone changes on <IP_ADDRESS> port 42863
[31/05/2022, 15:38:28] [Konnected] Get [Konnected Alarm] (5DFABE27-E552-43EA-909C-753D76477723) 'securitysystem' current characteristic value: 3
[31/05/2022, 15:38:32] [Konnected] Discovery attempt 1 could not find any panels on the network. Retrying...
[31/05/2022, 15:38:37] [Konnected] Discovery attempt 2 could not find any panels on the network. Retrying...
[31/05/2022, 15:38:42] [Konnected] Discovery attempt 3 could not find any panels on the network. Retrying...
[31/05/2022, 15:38:47] [Konnected] Discovery attempt 4 could not find any panels on the network. Retrying...
[31/05/2022, 15:38:52] [Konnected] Discovery attempt 5 could not find any panels on the network. Retrying...
[31/05/2022, 15:38:57] [Konnected] Could not discover any panels on the network. Please check that your panel(s) are on the same network and that you have UPnP enabled. Visit https://help.konnected.io/support/solutions/articles/32000023644-device-discovery-troubleshooting for more information.
jwm
Jack W. McClurg
Founder
McClurg Century Investments
303.799.1732 office
Confidentiality Notice: The information contained in this e-mail is legally privileged and confidential information intended only for the use of McClurg Century Investments and its intended recipients. If the possessor of this e-mail is not the intended recipient, you are hereby notified that any dissemination, distribution, or copying of the information in this e-mail is strictly prohibited. If you have received this e-mail in error, please, do not disclose this data to any other person and please notify the sender immediately at<PHONE_NUMBER>.
From: Jack McClurg @.>
Date: Monday, May 30, 2022 at 12:54 PM
To: konnected-io/homebridge-konnected @.>, konnected-io/homebridge-konnected @.>
Cc: Subscribed @.>
Subject: Re: [konnected-io/homebridge-konnected] Add manual discovery setting (PR #3)
I think I have it working now - I’m on a different project until next week
jwm
Jack W. McClurg
Founder
McClurg Century Investments
303.799.1732 office
Confidentiality Notice: The information contained in this e-mail is legally privileged and confidential information intended only for the use of McClurg Century Investments and its intended recipients. If the possessor of this e-mail is not the intended recipient, you are hereby notified that any dissemination, distribution, or copying of the information in this e-mail is strictly prohibited. If you have received this e-mail in error, please, do not disclose this data to any other person and please notify the sender immediately at<PHONE_NUMBER>.

From: Mike Kormendy @.>
Sent: Monday, May 30, 2022 11:50:55 AM
To: konnected-io/homebridge-konnected @.>
Cc: Subscribed @.***>
Subject: Re: [konnected-io/homebridge-konnected] Add manual discovery setting (PR #3)
Just listing the possible scenarios why the auto discovery wouldn't work:

UPnP is turned off
SSDP is blocked

If there are any more scenarios please advise.
—
Reply to this email directly, view it on GitHubhttps://url.emailprotection.link/?bkzyOaL7BGxVjaV6UeLnorpHv-WuTXnBtnEQ_Qo2v-WLwyfLhbPD07PDH8lN3ZhIzyBcug1NIbg-66HFczFTmEHtdViq7AxO94P-qCjrwOQIXk-KViFUjGBu5MweOqFt_, or unsubscribehttps://url.emailprotection.link/?bktJ8IU6WESX0mb5fsvSrkNg2COxmL66_QGogaeM93k6eWMherg9tFO3WSXr2jyHncSDYz-3KMslAQ39Po5cv35wCpusy02H3froVygxkUKZPeZ98vUokyzUPsOdkx9rqf9dNzMC_5EDx_51j8Ao76ocT6ldMAL_qYKW33uKBVJA~.
You are receiving this because you are subscribed to this thread.Message ID: @.***>

@jackmacdawg You have somewhat hijacked the comment thread of a pull request channel with your own separate issue. This is not typically the place where we provide support for problems and issues. Please visit https://help.konnected.io/support/tickets/new and submit your issue to our support team and we can discuss this further there.

Sorry Mike I thought I just replied to your email
jwm
Jack W. McClurg
Founder
McClurg Century Investments
303.799.1732 office
Confidentiality Notice: The information contained in this e-mail is legally privileged and confidential information intended only for the use of McClurg Century Investments and its intended recipients. If the possessor of this e-mail is not the intended recipient, you are hereby notified that any dissemination, distribution, or copying of the information in this e-mail is strictly prohibited. If you have received this e-mail in error, please, do not disclose this data to any other person and please notify the sender immediately at<PHONE_NUMBER>.

From: Mike Kormendy @.>
Sent: Tuesday, May 31, 2022 4:34:32 PM
To: konnected-io/homebridge-konnected @.>
Cc: jackmacdawg @.>; Mention @.>
Subject: Re: [konnected-io/homebridge-konnected] Add manual discovery setting (PR #3)
@jackmacdawghttps://url.emailprotection.link/?buEq4eyNl9NRYRhKUfm4VcKlBc0OWYiuZiM_YK76_PXvVl8wq0xgVk6_Za50Rl7OrzJFB-JgrRGqQDG84S__DAQ~~ You have somewhat hijacked the comment thread of a pull request channel with your own separate issue. This is not typically the place where we provide support for problems and issues. Please visit https://help.konnected.io/support/tickets/newhttps://url.emailprotection.link/?babImg0bEUxMHpPsxOmCp3C9Chv9zxh-01UmjdkAIuGHVfgMvgo18OJGqI_WvEUzO5PjowtGjF2eQItdWQKkekLjAYYlY1MFLVgsMkVaMzldHcyC09MFqFt7REmtW64l6 and submit your issue to our support team and we can discuss this further there.
—
Reply to this email directly, view it on GitHubhttps://url.emailprotection.link/?bQI8KHr8odYBQP3B9gwFnblo1Epgb5khcFybDVWfoW3l4EP71X6B447GrllwNOCHDT_AbmKbSat8IF3mP3dHVxtIfSBOLKMMqkAV2O4vamGkwzYoKcVRekjM3-F9v0ro_, or unsubscribehttps://url.emailprotection.link/?b3LhM__naxTQblFpnRV1R-n1doUGpFHTyga_nokNN27HNKi5fCAW13KJQmgyZUC47dbK2fr-eJ_U4SpSFCXMrtSv8zKiCboXx1OAhlEhsSigFsiV6axjkpXotin3BmfsIIbJPsWn1KGjr1DES2Kuub4lSc05cgzCdwYDYpCQN1HE~.
You are receiving this because you were mentioned.Message ID: < @.***>


WIP [DUOS-395][risk=no] API Support

WIP
Not ready for review.
Still working on the main UI components here: https://github.com/DataBiosphere/duos-ui/pull/171
Addresses
API changes in support of https://broadinstitute.atlassian.net/browse/DUOS-395
Changes

Due to security testing, we have some invalid data that presents an opportunity to better handle error cases. Log the case of invalid users on a DAR instead of throwing a 404.

Coverage decreased (-0.03%) to 61.647% when pulling 7eab1fc7684ea8ca021737c543c9b2a7a990142a on DUOS-395 into 0c61991d7187b00ac99edafbe51b20f1fc47d17d on develop.


[1/n] fix! Rebuild mobile navigation from ground up

What does this PR do and why?
There was some formatting fudging, as well as just ant design behaving irregularly, so I rebuilt in pure css and used headless ui.
This work was required to fix the update branding on mobile
Screenshots or screen recordings
Before

After

Acceptance checklist

[ ] I have evaluated the Approval Guidelines for this PR.
[ ] I have tested this PR in all supported browsers.
[ ] I have tested this PR in dark mode and light mode (if applicable).

Current dependencies on/for this PR:

main

PR #3215   👈

This comment was auto-generated by Graphite.

@wraeth-eth queued this pull request to merge with Graphite.

@wraeth-eth merged this pull request with Graphite.


Fixed: Synchronise FTL macro parameters for the various output types (OFBIZ-12126)

Following changes to how FTL macro parameter lists for HTML screens, corresponding changes needed to be made for text, xml, pdf (fo), csv and xls screens.
Tested using example and Layout demo screens, exercising exporting of screens to other formats
https://localhost:8443/example/control/main
https://localhost:8443/webtools/control/WebtoolsLayoutDemo

These changes are similar to those carried out under https://issues.apache.org/jira/browse/OFBIZ-6461


emit submitShortcut event when the textarea is focused and user press ctrl/command + enter

Thanks!!

@Combo819 https://github.com/chafan-dev/chafan-vue-editors/commit/97d9a83a274566d142cf7729cb6bed006964749a I added a test here. I think it works. Can you add the support for TiptapCF as well? After that we can release a new version to NPM.

@izgzhen Sure. Will create a pull request once it's done


SARAALERT-581: Prevent multiple patient submissions.

Addresses SARAALERT-581
Summary
Some users on IE were able to submit duplicates of a monitoree by clicking the submit button multiple times.
Important Changes
app/javascript/components/enrollment/steps/Review.js

Calling submit method in setState callback to guarantee button disable before patient submission.

Testing
This fix was tested on the following browsers:

[x] Chrome
[x] Firefox
[x] Safari
[x] IE11

For some reason on IE11 and Safari I get a 500 when enrolling a monitoree on master and this branch, but I did confirm that I was unable to click the button more than once. Would love to know if reviewers can replicate the 500 locally for those two browsers.
You should never be able to click the "Finish" button or "Finish and Add Household Member" button when enrolling a new monitoree more than once. Please also verify it only ever adds a single record for enrolled monitoree when clicking the button.
NOTE: I was unable to replicate this. As a result, I'm not 100% sure this will address the issue but it's a needed change nonetheless.

@holmesie @timwongj Are either of you able to replicate this bug and/or enroll a monitoree locally without error in Safari and IE11?

@holmesie @timwongj Are either of you able to replicate this bug and/or enroll a monitoree locally without error in Safari and IE11?

I was not, but it may have been network related. These setState asynchronous bugs are always really tough to reproduce, but this change makes sense as-is even if we didn't hear anything about it. Please assign yourself to the related JIRA ticket, move to this sprint, and mark as done. Also let the relevant deployment team member (who created it) know it will go into the next release.


[EPIC]: Move BCC tools to a legacy mode

Compile Once - Run Everywhere (CO-RE) is now the preferred way to make eBPF programs portable instead of compiling them at the target machine as (standard) BCC-Python tools do. Inspektor Gadget supports CO-RE and "BCC" modes for almost all our gadgets, we try to use CO-RE and we fallback to the BCC versions when there is an error. Even if this approach allows us to support a wider set of kernel versions, it presents some big challenges from a development / maintenance point of view: It's difficult to keep features on both types of tools aligned, we have to test twice the gadgets, we have to maintain a BCC fork. From a efficiency point of view, it makes the container image very big (~800MB), and BCC tools require higher resources to be used as them need to be compiled on the target machine.
BTF is now enabled on almost all major Linux distributions, even Ubuntu enabled it for 18.04 in the kernel version <IP_ADDRESS> (https://github.com/aquasecurity/btfhub-archive/commit/334a3b230cb6f79a757b8dc8b011d462fb812cd2), Inspektor Gadget is uses BTFGen and BTFHub to be able to run in some kernels without BTF, hence we're proposing to move BCC tools into a "legacy" mode, concentrating our development effort on the new CO-RE tools and making them the default. Specifically, the idea is:

[x] Update all our gadgets to support CO-RE.
[x] Create two different container images for Inspektor Gadget (BCC and CO-RE, ongoing work here https://github.com/kinvolk/inspektor-gadget/pull/608).
[ ] https://github.com/kinvolk/inspektor-gadget/issues/807
[ ] Provide a flag to use the BCC or the CO-RE container image when deploying Inspektor Gadget.
[ ] Use the "CO-RE" container image by default when deploying

I updated this issue to go step by step. Let's start by pushing the CO-RE image to the container registry and provide a flag to choose which one to use. In the future we can make the CO-RE the default.

The time to deprecate and remove BCC tools has finally come, the reasons are:

It's difficult to maintain: From time to time things break in BCC and we have to fix that.
It slows down development: We have some "legacy" logic that we have to take care of each time we update the code.
It increases the image size: 580 vs 280MB.
The new features we're implementing (containerized gadgets, prometheus, etc) don't work with BCC tools.
BTF is enabled in all major distributions now a long time ago (2+ years). It even has been backported previous versions.
We can use BTFHub to cover there cases when BTF is not available for the most popular distros.

The deprecation plan we'll follow is:

Deprecate BCC tools on v0.21.0: Use CO-RE by default and provide a flag to use the legacy BCC tools
Remove BCC support in v0.22.0. We'll point users running incompatible systems to use an older Inspektor Gadget version.


add Keyword interface

Keyword Interface added re: https://github.com/tipoff/seo/pull/82

Note: Might not needed it.. let's not merge yet.


Parquet: Snappy buffer size limitation.

Writing large parquet files can lead to:
ArrowError(ExternalFormat("External format error: underlying snap error: snappy: input buffer (size =<PHONE_NUMBER>2) is larger than allowed (size = **4294967295)**

I believe we already discussed this earlier in a polars issue, but I cannot reproduce it. I open this issue to explore ways to circumvent it.
I assume we can prevent this by passing smaller Chunks to the writer?
Is there a way upfront to estimate the size of a buffer that will be send to snappy?

We need to support splitting the arrays in multiple parquet pages when writing, since each page is compressed independently

Alternatively, split the chunk in smaller parts ^^


Update rollup to v3 and its plugins

~This PR is based on #1464. It should be merged after that one. Please review only 32f23d7.~
To go to rollup v4, we also need to update graphite once it merges and releases the following PR:

https://github.com/paqtcom/graphite-design-system/pull/157

The only caveat is this deprecation notice:
$ yarn build
src/card.ts → dist...
`import sass from 'sass'` is deprecated.
Please use `import * as sass from 'sass'` instead.
created dist in 22.9s

Which I suspect will also be solved with the PR above. It is only a deprecation warning though, it doesn't cause any issues.

Thanks @felipecrs !


Slider DPAD support for Android TV

I am trying to use slider in a video player on Android TV app, testing on Nvidia Shield TV
just upgraded master, with the #53945 change i can now use the slider with remote d-pad, but there  are some issues with DPAD on Android TV platform with remote dpad arrow keys:

slider once focused can't unfocus / move to other widget buttons on screen...
DPAD left and bottom rewinds, right and top forwards but DPAD could be left: rewind, right: forward, top and bottom moves to other widgets...

Also I think another enhancement would be great to add onPressed() to Slider.
use case is a video player where the slider button press pauses / plays video (this is how youtube android tv app functions..)
Thanks !!
related:
https://github.com/flutter/flutter/pull/53945

/cc @gspencergoog

I meet the same problem.
Any solution now?

@JoseAlba or @clocksmith can you take a look at this?

[Triage] @gspencergoog What's the status of this issue? What is left to do?

Any Updates on how to solve the issues stated in the initial post? Any Workarounds?

Any Updates on how to solve the issues stated in the initial post? Any Workarounds?

As far as I know, the DPAD key events should be interceptable on Android, so that they will work even when a text field is focused. Adding the onPressed to the slider I don't think has been done (or evaluated).

As far as I know, the DPAD key events should be interceptable on Android, so that they will work even when a text field is focused. Adding the onPressed to the slider I don't think has been done (or evaluated).

I am trying to use slider in a video player on Android TV app, testing on Nvidia Shield TV just upgraded master, with the #53945 change i can now use the slider with remote d-pad, but there are some issues with DPAD on Android TV platform with remote dpad arrow keys:

slider once focused can't unfocus / move to other widget buttons on screen...
DPAD left and bottom rewinds, right and top forwards but DPAD could be left: rewind, right: forward, top and bottom moves to other widgets...

Also I think another enhancement would be great to add onPressed() to Slider. use case is a video player where the slider button press pauses / plays video (this is how youtube android tv app functions..)
Thanks !!
related: #53945

wrap th slider like this
MediaQuery(
      data: MediaQueryData(
        navigationMode: NavigationMode.directional,
      ),
      child: Slider(),
),

I am trying to use slider in a video player on Android TV app, testing on Nvidia Shield TV just upgraded master, with the #53945 change i can now use the slider with remote d-pad, but there are some issues with DPAD on Android TV platform with remote dpad arrow keys:

slider once focused can't unfocus / move to other widget buttons on screen...
DPAD left and bottom rewinds, right and top forwards but DPAD could be left: rewind, right: forward, top and bottom moves to other widgets...

Also I think another enhancement would be great to add onPressed() to Slider. use case is a video player where the slider button press pauses / plays video (this is how youtube android tv app functions..)
Thanks !!
related: #53945

wrap th slider like this
MediaQuery(
      data: MediaQueryData(
        navigationMode: NavigationMode.directional,
      ),
      child: Slider(),
),

Very helpful, thank you. I was experiencing this problem and just reviewed Slider. I saw NavigationMode in slider file, but I didn't know how to control or change its value. Thank you, this is working solution.


fix: undo doesnt work

export message reset the graph history, the easiest way is to have another export frame.

Hello @shandowc,
can you explain me this fix? why you need a second frame?

how to debug
every time the plugin dialog got an autosave message, it post an "export" message to the drawio iframe. set a breakpoint to the message handler as below(editing an png image):

then:

then:

then:

then:

so everytime we post an export message, we create a new undoable edit. so the last undoable edit will ALWAYS be setGraphXml, which is the result of our "export" message.

how to fix
because we need to get exported image data once we got autosave or  save message, and we can not hack drawio iframe, so the best method may be to create a new iframe, specially for the export message


onRowUpdateCancelled doesn't return any rowData information

Issue
When cancelling a row edit, the OnRowUpdateCancelled function rowData always returns undefined.
This seems to have never returned anything, even since the mbrn days.
Sandbox link
https://codesandbox.io/p/sandbox/material-table-issue-onrowupdatecancelled-vz4r6z
Expected behavior
Since rowData is  shown in the Editable example, it is expected that the rowData would be available.
https://material-table-core.github.io/demos/edit/editable
Screenshots

Desktop:

OS: Windows 10
Browser : Chrome
Version: 120.0.6099.110 (Official Build) (64-bit)

Ah yes, it will be removed from the example in the future.

So, the workaround will still have to be:
                components={{
                    EditRow: (props) => {
                        return (
                            <MTableEditRow
                                {...props}
                                onEditingCanceled={(mode: any, rowData: any) => {
                                    // do stuff here
                                    props.onEditingCanceled(mode);
                                }}
                            />
                        );
                    },
                }}

Ah you mean the whole object, not the rowData key from the object.
That can easily be returned, in my opinion. Would you mind creating a PR with the change to onEditingCanceled material-table.js?

I imagine that onRowAddCancelled has the same issue, but we haven't had a need for that one...
I will attempt to make a PR here shortly.

Done and relased. Thanks


Seeking Event Not Working on Pause

On the youtube player, the seeking is not working when the player is paused. This may be caused due to the sync call rather than a seek call like the vimeo player.

Youtube API does not support an event listener for seeking. Not sure how this can be resolved at the moment.


fix(hack): inline imgs can avoid exp rerendering

While trying to render a 'large' quantity of images (like, 12+), I noticed insanely bad performance, and suspected something exponentially bad was happening. Took me a while to remember that we chain re-render images, and well, i don't think it's technically exponential, but it's much worse than it could be.
This change quickly fixes the issue for images with inline but without with_virtual_padding. However, the problem persists for padded images. I left a TODO with a potential fix, but it would take a little more time than I have before I go to sleep. I'll probably do it tomorrow night instead of paying attention to class :P

Wait. do we even need to re-render like this?

I don't think that we need that code anymore since the change that made all images stick to their extmarks with an auto command.
Let me know if you have a usecase for it still and I can improve it's performance, otherwise I'll just remove it.

okay 12am brain speaking, there's a fair chance that they're not redundant. I'll look at this again in the morning when I'm not about to fall asleep. Will mark this as a draft for now

Pretty sure it's needed if a user re-renders an image with different geometry. So this should be the fix.


Add an infix operator for accept

An infix operator for accept would be nice.  I'm not sure which one it should be.  =~ has been suggested, but we should briefly look for other widespread uses first.

=~ is currently used for matching regular expressions (cf. regex-base).
Though I haven't yet played around with explainable-predicates, I've been thinking it could fit into a linter I'm writing (which essentially type-checks asset files of a game, and should emit hints if things go wrong), which also uses regular expressions, i.e. these would collide (I could also imagine people using regexes in tests, e.g. to check program output or a pretty-printer). That's obviously not a dealbreaker or anything, but it would be nice if it were avoided.

Agreed.  I don't have a strong opinion here.  Hoogle says that ==~ is unused in Stackage.


fix add some keywords #29251

Proposed changes
cherry-pick from #29251

Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

run buildall

run buildall

run buildall

run p0

run buildall

run p0


Load ASDF in CL Makefile and remove QL requirement.

Note it's this asdf, not that one.

Brilliant! Table updated. Figure will be updated later with common lisp.


Can a CanvasVIrtualControl serve as a pageVisual?

When trying to print content of a CanvasVirtualControl it doesn't seem to work as a UIElement for AddPage. Is it possible to use a CanvasVirtualControl as an argument for PrintDocument.AddPage? If not, is there any documentation available on printing a CanvasVirtualControl?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 20435a22-bc4d-aeaa-faee-e35d3a16e86d
Version Independent ID: 9a8207d3-ba6c-8d10-515e-3c38d77d999e
Content: PrintDocument.AddPage(UIElement) Method (Windows.UI.Xaml.Printing) - Windows UWP applications
Content Source: https://cpubwin.visualstudio.com/DefaultCollection/windows-uwp/_git/winrt-api-build?path=%2fwinrt-api-build%2fwindows.ui.xaml.printing.printdocument.yml&version=GBlive&_a=contents
Product: uwp
Technology: winrt-reference
Git Login: jwmsft
Microsoft Alias: jimwalk

Seems like a bug with CanvasVirtualControl itself if it doesn't support printing. Let me see if this is a platform issue or Win2D and i'll get back to you.

jevan (is your name actually Jeff, too?)
I found out that CanvasVirtualControl can’t be used as a UIElement argument for a PrintDocument source - it’s necessary to instead create a CanvasPrintDocument. And the CanvasPrintDocument doesn’t have the Paginate, etc. events so using it is quite a bit different from what is described in the print-from-your-app docs. Works, though.

Jeff

On Apr 19, 2019, at 11:20 AM, Jevan Saks<EMAIL_ADDRESS>wrote:
Seems like a bug with CanvasVirtualControl itself if it doesn't support printing. Let me see if this is a platform issue or Win2D and i'll get back to you.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub https://github.com/MicrosoftDocs/winrt-api/issues/998#issuecomment-484977159, or mute the thread https://github.com/notifications/unsubscribe-auth/AH7S6FS6ES6NRVHYSRF3TWLPRIEODANCNFSM4HCDALJQ.

Ah! Glad you figured it out. I'll close this issue then.
And my name is actually "Jevan", but I assume you're my long lost twin every time I see your github handle. 😁


Ensure that carriage return is part of whitespace calculations.

I will test this tomorrow if it's not already tested.


fix tooltip background

Looks like it works for me on mac

I built on both OSX and Linux and it looks fine :thumbsup:


Python: Fix IndexError in Azure OpenAI stream requests by handling empty choices array

Motivation and Context

Closes #3650
Fixing errors in stream requests with Azure OpenAI API version 2023-06-01-preview and later.
Description

Added handling for cases where the chunk size in stream responses is zero in the Azure OpenAI Service class.
Modified integration tests to cover multiple versions of the Azure OpenAI API.

Added two variables to GitHub Actions for integration testing: AZUREOPENAI__APIVERSIONS and AZUREOPENAI__CHAT__APIVERSIONS. To ensure successful integration tests, these variables need to be added to the repository.
Contribution Checklist

[x] The code builds clean without any errors or warnings
[x] The PR follows the SK Contribution Guidelines and the pre-submission formatting script raises no violations
[x] All unit tests pass, and I have added new tests where possible
[x] I didn't break anyone :smile:

@microsoft-github-policy-service agree

Hi @KanchiShimono, we just upgraded the OpenAI SDK to be 1.0 or higher (#3555). As part of this work (a large PR), we made some improvements around handling responses that may contain empty content, similar to what you show here in your PR. Can you grab latest code and please verify that it works for you -- and if not, you can use this PR to update whatever needs a fix. Thank you!

The issue has been resolved.
Thank you!


Client: Does not support models with name "Type`

Describe the bug
The new prisma client maintains an internal data structure that has the name 'types'. It appears as if each of the root query types from prisma is also added to the client as properties. This can cause naming collisions.
If one were to have a model in their datamodel.graphql with the name Type then prismas root query would have a field on it named types
type Type @model {
  id: ID! @unique
}

generates a schema with:

type Query {
   types(where: TypeWhereInput, orderBy: TypeOrderByInput, skip: Int, after: String, before: String, first: Int, last: Int): [Type]!
}

The naming collision occurs here and the original client.types is overridden.
Expected behavior
Prisma client would not impose any naming restrictions on model names.
Screenshots
You can see here that client.types is the function that fetches the Type model.

Versions (please complete the following information):

OS: OS X High Sierra
prisma CLI: 1.18
Prisma Server: 1.17
prisma-client-lib: 1.17.1

Additional context
If the prisma team is okay with it, I'm happy to put up a PR that adds a _ prefix to the members the of Client class.

Thanks for reporting @ryanquinn3. That is indeed the case! It would be awesome if you could create that PR. Let me know if you have any questions!

Also ran into this. As a temporary hack you can call prisma.buildMethods() just right before your shadowed prisma.types(... call. Hoping to have @ryanquinn3's PR merged soon.

The PR has been merged and released in stable :)


Meteor 1.4 compatibility

Current version of Meteor is 1.4 (as of August 12 2016) and current angular2-meteor (actually the angular2-compilers package) throws a "No compatible binary build found for this package. Contact the package author and ask them to publish it for your platform" error.

Can't confirm that.
I'm successfully running Meteor 1.4 (see Screenshot) and those are my dependencies:
    "@angular/common": "2.0.0-rc.4",
    "@angular/compiler": "2.0.0-rc.4",
    "@angular/core": "2.0.0-rc.4",
    "@angular/forms": "0.2.0",
    "@angular/platform-browser": "2.0.0-rc.4",
    "@angular/platform-browser-dynamic": "2.0.0-rc.4",
    "@angular/router": "3.0.0-beta.2",
    "angular2-meteor": "0.6.3-beta.4",
    "angular2-meteor-auto-bootstrap": "0.6.0",
    "angular2-meteor-polyfills": "0.1.1",
    "bootstrap-sass": "3.3.7",
    "bootswatch": "3.3.7",
    "meteor-node-stubs": "0.2.3",
    "ng2-bootstrap": "1.0.24",
   "reflect-metadata": "0.1.3",
   "rxjs": "5.0.0-beta.10",
    "zone.js": "0.6.12"

But you can use "meteor add<EMAIL_ADDRESS>to install 0.6.0 as a workaround (mind the "="  after @)

Thanx @stefanholzapfel. I managed getting stuff up and running by creating a new project and importing all my stuff into it. The first time I tried to update and older package. Even though we got around, I guess the issue is still valid for future updates.

Can confirm this issue too, the workaround mentioned by @stefanholzapfel  works fine though as for now.

@bergben This is not a workaround. The question still remains. I guess it sounds like: what is the compatible version of meteor for<EMAIL_ADDRESS>I was trying to downgrade meteor to <IP_ADDRESS> with no success.
Subscribe.

I also havent been able to make it work, the work around doesnt work for me.
I get

/images-uploader.component.ts (54, 5): Argument of type '{ selector: string; template: string; styleUrls: string[]; viewProviders: typeof DragulaService[]...' is not assignable to parameter of type 'ComponentMetadataType'.
Object literal may only specify known properties, and 'directives' does not exist in type 'ComponentMetadataType'.
client/services/validation.service.ts (21, 10): Module '"node_modules/@angular/common/index"' has no exported member 'ControlGroup'.

same issue here with 0.6.1.
Windows 10.

<EMAIL_ADDRESS>should fix it

Still getting same issue on Windows 10, meteor <IP_ADDRESS>, node 4.4.6
Also tried using<EMAIL_ADDRESS>no luck.


Use LANG=C for subprocesses

If LANG=de_DE.UTF-8 is used, for example, the command output of fdisk -l will contain unicode characters. This is problematic because Kodi's logging mechanism crashes and the command's output parsing is not reliable.
When LANG=C is used, the commands' output will consist of ASCII-only characters, which is nice.
See #210 for an example of the resulting error message when a unicode string is given to the log() function. As every command output is given to log(), this means bad things.

Unicode problems should be fixed in version 0.4.3 and logging should work with all unicode characters.
This pull request works around a possible problem from a previous InputStreamHelper version, I'm not going to merge this.
If there is still a problem with version 0.4.3, please provide a full debug or make a new pull request which respects unicode support.

I think it is worthwhile to force LANG=C in any case, it helps troubleshooting when command output is not translated and things become a bit more deterministic as we depend on reliable output.
That said, I hope we can rewrite this part of the code at some point.

As this add-on supports multiple languages with different alphabets like Russian and Greek, I'm convinced supporting unicode everywhere is the best solution.
In specific cases I can allow exceptions, but I should first have a full debug log of this problem before I can even think about giving up unicode support.

Nobody's willing to drop unicode support anywhere, I think it's fine.
Still, the plain command output of fdisk -l for example is parsed in the code to retrieve some information out of it, for example the offset for the relevant partition to mount.
While my changes aren't necessary to fix the given problem in particular, it still increases the robustness of the parsing process itself.
I did not have time to test if my problem still exists with the newest version of the plugin, but I'll report my findings in the next couple of days.

@mediaminister This only affects the commands being run, so it should not matter for the rest of our add-on.

I did a quick test on Linux with special chars and I still get UnicodeDecodeError with this.
Converting subprocess output to unicode will fix https://github.com/emilsvennesson/script.module.inputstreamhelper/issues/210

@mediaminister Using LANG=C for me is unrelated to Unicode-processing, the purpose is to ensure the output of commands are more predictable and (error) output is in English.

I think we can merge this one as well.
Thanks @janhicken !


tests: lower self nonblocking iov_payload_size to improve test reliability

Please note that while we are transitioning from travis-ci to AWS CodeBuild, some tests are run on each platform. Non-AWS contributors will temporarily be unable to see CodeBuild results. We apologize for the inconvenience.
Description of changes:
The previous values caused a significant amount more bytes to be allocated:

65536 bytes
131072 bytes
262144 bytes
524288 bytes

This causes some issues on test reliability on smaller machines. Lowering the initial value to 8192 still exercises the "interesting" 65536 value, while writing much less.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Codecov Report

Merging #1878 into master will increase coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1878      +/-   ##
==========================================
+ Coverage   81.44%   81.46%   +0.01%
==========================================
  Files         226      226
  Lines       16905    16905
==========================================
+ Hits        13768    13771       +3
+ Misses       3137     3134       -3


WIP: Move base-image from v1/image/base to v1/baseimage

To be consistent with other resources' URI's, let's move the base-image URI from /v1/image/base to v1/baseimage.
Fixes #271

This change is

WIP: please hold on to review :)


Error while running

I'm hit with below error when running in Ubuntu, python 2.7
python DumpsterDiver.py -p ~/src/sourcedir -s --bad-expressions "test" > result.txt
Traceback (most recent call last):
  File "DumpsterDiver.py", line 143, in <module>
    core.start_the_hunt()
  File "/home/user/Downloads/DumpsterDiver-master/core.py", line 275, in start_the_hunt
    save_output()
  File "/home/user/Downloads/DumpsterDiver-master/core.py", line 326, in save_output
    logger.error("while trying to write to " + str(_file) + " file. Details:\n" + str(e))
NameError: global name '_file' is not defined

Hi @nikhilgeo !
DumpsterDiver requires using Python 3. Please let me know if you have any further comments.

If it requires Python 3, why does the hashbang say python? Many Linux distributions are still keeping /usr/bin/python -> Python 2 for compatibility reasons, and it will be a while until this changes. Better be explicit and say python3.
Also, the hash-bang won't always work well, because env is usually installed in /usr/bin, not /bin on Linux (although the latter can be a symlink to the former in some cases).
I recommend the following patch:
diff --git a/DumpsterDiver.py b/DumpsterDiver.py
old mode 100644
new mode 100755
index 272702f..847e2c5
--- a/DumpsterDiver.py
+++ b/DumpsterDiver.py
@@ -1,4 +1,4 @@
-#!/bin/env python
+#!/usr/bin/env python3

 import advancedSearch
 import core
diff --git a/advancedSearch.py b/advancedSearch.py
index 84f0530..612e742 100644
--- a/advancedSearch.py
+++ b/advancedSearch.py
@@ -1,4 +1,4 @@
-#!/bin/env python
+#!/usr/bin/env python3

 import core
 import fnmatch
diff --git a/core.py b/core.py
index 69eefc1..a568232 100644
--- a/core.py
+++ b/core.py
@@ -1,4 +1,4 @@
-#!/bin/env python
+#!/usr/bin/env python3

 import advancedSearch
 import fnmatch
diff --git a/entropy.py b/entropy.py
index befe393..7ac5286 100644
--- a/entropy.py
+++ b/entropy.py
@@ -1,4 +1,4 @@
-#!/bin/env python
+#!/usr/bin/env python3

 import math
 import sys

Oh, and since that would make the scripts executable, I suggest giving the DumpsterDiver execute permissions as well:
chmod +x DumpsterDiver.py

Hi @onitake ! Thanks for your suggestions. The changes have been just applied.


Implement exogenous processes

[x] Create new custom state space objects.
[x] Define child nodes with changing exogenous processes.
[x] Rewrite tests.
[x] Create new tests.
[x] Polish functions.

marginal_wealth is not used anywhere. Do we need this function still?

marginal_wealth is not used anywhere. Do we need this function still?

marginal_wealth is not used anywhere. Do we need this function still?

Deleted it!


Fixed data type error on firebase-messaging example

@songyiYu Thanks for the PR, however this is working as expected, a data payload is expected for this example. Something like:
data: {status: working, id: ID1}


add typescript template

As requested in the forum, I have here made the changes against your template repos, as a PR.

Thanks!!
Will do a test myself this week and then officially release this template.
You'll be fully credited as this is your work completely.
It currently works if you do $ quasar init default#typescript <folder_name>.

Perfect, it is just a small contribution and nothing compared too all your nice work.
I have a problem using webpack 2 as due to the missing proxy, but I will use the current stable version locally.
tsx files and a more detailed index.d.ts file will be the next goal, and as I start using this nice framework these thing will come sneaking :-)

Let me know when you think this template is ready for a production release ;) I'll chime in to help too if I have time, but as things stand at the moment I don't think this is going to happen any time soon unfortunately.

Ok, just tried to init a fresh new project using your quasartool, and it worked like a charm :-)


Feature Request: Disable the 5Ghz network via Home Assistant

One of the troubleshooting options in the Eero app is to disable the 5Ghz network for about 10 minutes.
This is useful if you have a device that is 2.4Ghz only and has lost the network. I often find that disabling 5Ghz allows it to connect again.
Given a lot of WiFi devices that are compatible with Home Assistant are 2.4Ghz, it would be useful to be able to call the same functionality from Home Assistant.
This could then either be scheduled as a daily task (nightly clean up/reconnect) or called on detection of a device that is known to be 2.4Ghz disconnecting.

Added in 1.6.0

Upgraded and tested. Works like a charm.
Thanks Matt


Lua optimizations

Hi, I'm embarking on a optimization quest to squeeze some more performance out of the Lua part running on every server.
I open this PR to keep track & collect contributions.
First optimization layer was to reference locally whatever is involved in on_tick tasks to cut on referencing times, and to move up in the code some early returns, or avoid repeated computations by saving the reused results. Overall, the logic is 99% unaffected.
Next step would be to spread out the workload over multiple ticks, so instead of updating 100-1000 injectors every tick, I can update just 10, 100 every tick, and just pass the final result to the js part. I think this may not give a clear performance improvement overall, but it could defenitely flatten any lag spikes due to all the computations being carried on the same tick.
I'll be available here & on discord for any communication :)

One piece of feedback straight away - if we want to see the changes to the code for optimisation, it helps if the definitions for the functions are not moved around. Otherwise, we completely lose the ability to see a diff in a function - in this case my eye got caught on the AddEntity.
It's better to do that cleanup at the end if you can help it. If not - well, don't sweat about it, do your thing.

Yeah, unfortunately casting functions from global to local makes it important the order of which they are called (functions can't reference functions that are implemented below themselves). So I had to re-arrange everything in the correct order (which makes git scream, I know)

Question - is it possible to split this file into multiple once? It's quite big, so maybe there are chunks that can be split off and just required via an import?

Totally! In my mods I do everything in modules, this was one big file so I kept it that way. But if you're cool with it, I'm in too

Leave the code in the better state than you found it (c) or something :D

Yeah, unfortunately casting functions from global to local makes it important the order of which they are called (functions can't reference functions that are implemented below themselves). So I had to re-arrange everything in the correct order (which makes git scream, I know)

This is not necessary, you can declare the functions as empty local variables and define them later.
local bar

local function foo()
    return bar()
end

function bar()
    return "spam"
end

print(foo())

@psihius split control.lua into submodules

While I appreciate your enthusiasm here this code change is unreviewable. You are mixing code clean-up, new features, and optimizations all into the same diff sets. We are currently days away from a 100+ player event and cannot afford to spend hours reviewing code changes like this that risks introducing new new game crashing issues.
You need to split up your changes to only do one type change at a time; when optimising only do optimisations. If you need to re-order things make optimisations do it in a separate commit that only does the reordering (but see my previous not about functions not needing to be reordered). Do not add new features and general code-base wide optimisations in the same PR.

Closing this PR because I don't have the git skills to adjust the diffs in a more readable format as I'm into deep into changes/features.
I understand all the concerns related to code reliability and time pressure, especially because of the upcoming event.
If it's a matter of time to review the code, I'd be available for a shared code review together on voice chat in order to get it done quickly. Just because I wouldn't throw away free performance.
Otherwise, if there's no time and other concerns are present, I'll simply leave it close and have someone more skilled pick it up when it'll be time.
👍

@RedRafe maybe just doing multiple pull requests in succession can be how you handle it. Also, you can make a feature branch and make PR against that. When that feature is done, it can then be merged into the master.


Sign out of Zed?

I signed in to Zed from my personal GitHub account, but I want to switch to my work GitHub account (both GitHub accounts are in the Zed alpha). However, I don't see an option anywhere to sign out.
I tried reinstalling zed and that didn't help. I also checked the ~/.zed but that doesn't seem to have the user context details.
Could someone help me sign out, please?

It's a missing feature, but in the short term you can delete the keychain item for Zed in the "Keychain Access" application.

This worked, Thanks a lot for the help @nathansobo!

This is now possible in the latest version of Zed. 🙂

This is now possible in the latest version of Zed. 🙂

Hm, I'm running the latest version Zed 0.86.1 and had to manually remove the keychain item for Zed, there is no feature allowing to switch accounts

You're right. I misspoke on that part. The ability to sign out was added back when I wrote that comment. The ability to switch accounts does not yet exist. As others have pointed out, the "solution" for now is to remove Zed from the Keychain.


Some files it cannot copy while explorer.exe can.

One more thing related to this issue: not all attributes of a file can be shown or changed in Files.
Steps To Reproduce
copy or move a file that has extra attibutes (for example, files downloded from Internet will be recognized 'locked' by default) using Files.
Steps to fix

enhance Files to handle various of file attributes

Files Version
<IP_ADDRESS>
Windows Version
win11 22623.1037
Relevant Assets/Logs
debug.log

Merging with #9423


[FAB-17276] Fix wrong protobuf import in mgr_test.go

Signed-off-by: Zhihao Chen<EMAIL_ADDRESS>

Type of change

Bug fix

Description

Additional details

Related issues

https://jira.hyperledger.org/browse/FAB-17276

Please follow the instructions here to sign-off your commit: https://github.com/hyperledger/fabric/pull/427/checks


Fix binary functions in misc to support complex types

related to #1281

LGTM! @unnonouno Please resolve conflicts.


Colab link?

Do you have a google colab for this?

Thanks for your suggestion, we added colab project in the TODO list.

Colab link now opened. But limited by 16GB GPU memory, I have to lower the training batch size, leading to little worse performance. Does anyone know how to enlarge the GPU memory on Colab?

The A100 machines on Colab have higher RAM, but you might need a Colab Pro account to access those.


Get Resource Name while creating a contact using People API

This is the code im using how can i define or get the server generated ResourceName
$people_service = new Google_Service_PeopleService($client);
    $person = new Google_Service_PeopleService_Person();

    $name = new Google_Service_PeopleService_Name();
    $name->setGivenName('00nirman');
    $name->setFamilyName('weerasinghe');
    $person->setNames($name);

	$email1 = new Google_Service_PeopleService_EmailAddress();
    $email1->setValue('test@example.com');
    $person->setEmailAddresses($email1);

$phone1 = new Google_Service_PeopleService_PhoneNumber();
$phone2 = new Google_Service_PeopleService_PhoneNumber();
$phone1->setValue('0777677305');
$phone2->setValue('0774112128');
$person->setPhoneNumbers([$phone1,$phone2]);

$exe = $people_service->people->createContact($person)->execute;

Use the following:
$exe = $people_service->people->createContact($person);
$name = $exe->getResourceName();

The resource name is assigned by the server and cannot be manually set or modified.

Use the following:
$exe = $people_service->people->createContact($person);
$name = $exe->getResourceName();

The resource name is assigned by the server and cannot be manually set or modified.

Thank you Very much you save lots of time  this code is working

Use the following:
$exe = $people_service->people->createContact($person);
$name = $exe->getResourceName();

The resource name is assigned by the server and cannot be manually set or modified.

Thank you Very much you save lots of time this code is working


Change assertion to check for a pointer (value)

This should close #30 but keep the existing check in place.

Added Andrew to reviewers, since he - as the original author - might have the best overview if this is a good idea or not.
(Sorry Andrew is this stresses you, if, please let me know)

...  just a wild guess. I'm curious to know what led to the value 4096.

we tried to re-construct the reason ....
=> https://github.com/cross-language-cpp/djinni-support-lib/issues/30#issuecomment-840780927
if its better to just check that we do not get a nullptr, I would also be fine to only check the value != 0

Maybe you should add a comment that gives a short explanation of what we think this is all about?

I actually did:  https://github.com/cross-language-cpp/djinni-support-lib/blob/b89b9309b10f824c8242422fca2e4f2d26a43cab/djinni/jni/djinni_support.hpp#L323
Any suggestion on improving that ?

You are right! 🤦♂ No that's perfect!


[FEAT] Recover github pull requests

Is your feature request related to a problem? Please describe.

We'll need a list of PRs from github to start working
Describe the solution you'd like

Use octokit rest api to list Prs
It would be nice to filter list since last release

[x] Recover a list of PRs
[x] Filter PRs since last release

Additional context

:tada: This issue has been resolved in version 1.0.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:

:tada: This issue has been resolved in version 1.0.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Optional characteristics

@ccutrer Thanks a lot for this change! This seems to be quite in line with my proposal for #63. @beowulfe how do you feel about that proposal and this change? I'd really like optional characteristics to not require some trait for the reasons outlined in #63.

@beowulfe I'd really like to get your opinion on this; I'm trying to work towards integrating my openhab2 homekit changes merged in to master; if you think this can make a 1.1.x release, then I'll base my changes on it :)

@beowulfe gentle nudge here! :) I know you're super busy, if there's anything I can do to help get this stuff merged and a release out, let me know. I'm just eager to integrate my openhab contributions before they diverge too far from master.

@ccutrer looks like this breaks backwards compat. Let's hold the merge until we release another 1.1.x version, and then we can bump the base version to 1.2.x and break all the things.

Totes. That was all an attempt to maintain backwards compat (which didn't work out). Breaking that will make it all a lot easier.

PR updated with just the lightbulb refactor, removing the extra interfaces. I'll separate fan into a new PR.


added Dijkstra’s Algorithm

Added Dijkstra’s Algorithm for calculating Shortest distance in graph_tree sub-folder of CPP folder.

Thank you for your contribution!
Regards,
Gantavya Malviya ( https://linktr.ee/gantavyamalviya )


Completely overhauled cleanup code

[x] Fixes https://github.com/pyviz/panel/issues/146

Codecov Report

Merging #151 into master will increase coverage by 0.14%.
The diff coverage is 96.13%.

@@            Coverage Diff             @@
##           master     #151      +/-   ##
==========================================
+ Coverage      90%   90.15%   +0.14%
==========================================
  Files          30       30
  Lines        4474     4559      +85
==========================================
+ Hits         4027     4110      +83
- Misses        447      449       +2

Impacted Files
Coverage Δ

panel/tests/test_vega.py
96.96% <100%> (ø)
:arrow_up:

panel/tests/test_panes.py
95.48% <100%> (+0.54%)
:arrow_up:

panel/vega.py
82.85% <100%> (+0.24%)
:arrow_up:

panel/tests/test_interact.py
100% <100%> (ø)
:arrow_up:

panel/tests/test_layout.py
100% <100%> (ø)
:arrow_up:

panel/widgets.py
97.62% <100%> (+0.01%)
:arrow_up:

panel/plotly.py
100% <100%> (ø)
:arrow_up:

panel/viewable.py
69.81% <100%> (+0.55%)
:arrow_up:

panel/tests/test_param.py
99.63% <100%> (+0.01%)
:arrow_up:

panel/tests/test_plotly.py
97.82% <100%> (+0.04%)
:arrow_up:

... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9bb4644...4b00511. Read the comment docs.


Update README

The steps to setup Flambo locally is a bit more involved than the 3 steps indicated in the README.

Node needs to be installed.
config/local.secret.exs needs to be created

And any other steps/requirements.

Fixed in https://github.com/cschiewek/flambo/commit/79bb5848ea00317a6e5d2e3ee05b0ea7b01c7e5a


js evaluate result check bug

In Editor.js, line 166 has a bug. if result is empty string or 0, it will run through jq.
if (context.result) { ..... }
should be
if (context.result != undefined) { ..... }
test code:
if(""){alert(1)}  //nothing happen
if(0){alert(1)}  //nothing happen
if("1"){alert(1)} // will alert

There are about a million places where people talk about how to check if something is undefined. I'm not even try to convice you that typeof myVar === 'undefined' is the "proper" way but if have some time to kill Google it..

@qifuren1985 is right, if result = x${filter} evaluates to something falsey, the filter is considered invalid.


[AutoPR datamigration/resource-manager] Changes for Microsoft.DataMigration GA stable version 2018-04-19.

Created to sync https://github.com/Azure/azure-rest-api-specs/pull/2936

(message created by the CI based on PR content)

Codecov Report

Merging #2459 into restapi_auto_datamigration/resource-manager will not change coverage.
The diff coverage is n/a.

@@                             Coverage Diff                              @@
##           restapi_auto_datamigration/resource-manager    #2459   +/-   ##
============================================================================
  Coverage                                        54.37%   54.37%
============================================================================
  Files                                             5979     5979
  Lines                                           135523   135523
============================================================================
  Hits                                             73685    73685
  Misses                                           61838    61838

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 677b96c...4f0752a. Read the comment docs.

This PR has been merged into https://github.com/Azure/azure-sdk-for-python/pull/2521


Decouple Spark version upgrade from Azkaban Spark job type config deployment

There should be a way to add new Spark binary without dependency on providing Spark home for that binary. This change covers a way to follow directory to keep all spark binaries and naming pattern using which we can easily add new binary and don't need to add property for it's path.

How should we handle the case where user provided Spark version is not installed?

The existing mechanism will fall back to using the default version.
Throwing an exception might be better here to make sure expectations are met.
It would be better if the exception message also includes valid version Strings so users know which ones are valid.

@zhe-thoughts & @Victsm Yes throwing an exception would be better in this case. So if provided version is not installed then it won't go by default installation. Do we follow same case for other types of jobs? For e.g. Pig or Hive?

Other job types right now do not use the version string approach, but rather require users to specify the full path of Pig/Hive installation.

Ok then throwing an exception would work and won't cause any inconsistency. I will make that change.

It would be even better if we can infer valid version Strings and include these in the exception message.