Make it easier to build the dataset pipeline in Dataset C++ tests

This PR aims to simplify the code of making the dataset pipeline in Dataset C++ tests using the following style:
auto* source_dataset_params = new RangeDatasetParams(...);
auto* target_dataset_params = source_dataset_params->Batch(...)->Map(...)->...->...;
// Handles all the allocated dataset_params (source_dataset_params, batch_dataset_params, map_dataset_params, ... , target_dataset_params)
core::ScopedUnref scoped_unref(target_dataset_params);
Tensor target_dataset;
MakeDatasetTensor(target_dataset_params, &target_dataset);
...
...

One example is as below
// The ownership is transferred to the caller.
MapDatasetParams* MapDatasetParams() {
  auto* range_dataset_params = new RangeDatasetParams(10, 0, -3);
  return range_dataset_params
      ->Batch(
          /*batch_size=*/2,
          /*drop_remainder=*/false,
          /*parallel_copy=*/true,
          /*output_dtypes=*/{DT_INT64},
          /*output_shapes=*/{PartialTensorShape({2})},
          /*node_name=*/"batch_node")
      ->Map(
          /*other_arguments=*/{},
          /*func=*/
          FunctionDefHelper::FunctionRef("XAddX", {{"T", DT_INT64}}),
          /*func_lib=*/{test::function::XAddX()},
          /*type_arguments=*/{},
          /*output_dtypes=*/{DT_INT64},
          /*output_shapes=*/{PartialTensorShape({1})},
          /*use_inter_op_parallelism=*/true,
          /*preserve_cardinality=*/false,
          /*node_name=*/kNodeName);
}

@jsimsa The first commit (https://github.com/tensorflow/tensorflow/pull/31635/commits/79b55fd17b055c4a17737de87db6e0667685e2e5) is as same as #31592, which you have reviewed and is pending for merge. You can just review the second commit (https://github.com/tensorflow/tensorflow/pull/31635/commits/08ebb28d857e425134485487e3c65aeb38f0631c).

@jsimsa Thanks for your suggestion! Now RefCounted is replaced by the smart pointer and the static factory methods are added as below. Could you please have a look at the changes (https://github.com/tensorflow/tensorflow/pull/31635/commits/50624183a1e6c92546c268687afc6c6c817f8777) when you get a chance?
static std::shared_ptr<BatchDatasetParams> Batch(
    const std::shared_ptr<DatasetParams>& input_dataset_params, ...);

static std::shared_ptr<MapDatasetParams> Map(
    const std::shared_ptr<DatasetParams>& input_dataset_params, ...) ;

static std::shared_ptr<RangeDatasetParams> Range(int64 start, int64 stop, int64 step);

Can one of the admins verify this patch?

@jsimsa Thanks for your review! The smart pointers are removed and all the members in DatasetParams are changed to be private. Could you please have a loot at the changes (https://github.com/tensorflow/tensorflow/pull/31635/commits/55afc02a147669a25e462abfafa684b9103476fa) when you get a chance?

@jsimsa Thanks for your suggestions! The comments are addressed here(https://github.com/tensorflow/tensorflow/pull/31635/commits/7003529c6e7bdbc5ad6c493fe755ec8d2a88e44f). Also, clean up DatasetOpsTestBaseV2 a little bit so that the derived test classes do not need to override the functions Initialize() and MakeDatasetOpKernel. Could you please have another look when you have time?

Thanks @rachellim for your review and help! Most of the comments are addressed here (https://github.com/tensorflow/tensorflow/pull/31635/commits/015b45e95dac3047060f698b959083a4dcc6e2b4) except this one (https://github.com/tensorflow/tensorflow/pull/31635#discussion_r320406144). Will do it once we get the answer from @jsimsa.

@rachellim All the comments are addressed now (https://github.com/tensorflow/tensorflow/pull/31635/commits/321e8cdf098d6a5b5645a9e3bbff0e0f6f223caf). Could you please take another look when you get a chance?

I'd suggest making everything consistent to have a space after the colon, not removing the space from everything.

Gotcha. Will change them

Thanks for your changes!

Thanks for the very prompt review, @rachellim! This commit (https://github.com/tensorflow/tensorflow/pull/31635/commits/2bf79a761656e3c64fbaeead39e63e41fd492255) is submitted to address the comments. Please take a look!

The internal checks failed. Could you help check the logs and paste them here?

internal tests are still running

@jsimsa The internal checks are in the failed status. Could you please help check the logs?

./third_party/tensorflow/core/kernels/data/dataset_test_base.h:132:3: error: 'tensorflow::data::DatasetParams' has virtual functions but non-virtual destructor [-Werror,-Wnon-virtual-dtor]
  ~DatasetParams() {}
  ^
./third_party/tensorflow/core/kernels/data/dataset_test_base.h:184:7: error: 'tensorflow::data::RangeDatasetParams' has virtual functions but non-virtual destructor [-Werror,-Wnon-virtual-dtor]
class RangeDatasetParams : public DatasetParams {
      ^
./third_party/tensorflow/core/kernels/data/dataset_test_base.h:208:7: error: 'tensorflow::data::BatchDatasetParams' has virtual functions but non-virtual destructor [-Werror,-Wnon-virtual-dtor]
class BatchDatasetParams : public DatasetParams {
      ^
./third_party/tensorflow/core/kernels/data/dataset_test_base.h:245:7: error: 'tensorflow::data::MapDatasetParams' has virtual functions but non-virtual destructor [-Werror,-Wnon-virtual-dtor]
class MapDatasetParams : public DatasetParams {

@jsimsa The virtual deconstructor is added here and also update some places to use the named constant. Could you please take another look when you get a chance?

@rthadur An error happed while migrating the change. Could you help retrigger the internal checks? Thanks!

done


Bump googleauth dep

Codecov Report

Merging #101 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #101   +/-   ##
=======================================
  Coverage   99.35%   99.35%
=======================================
  Files          18       18
  Lines        1708     1708
=======================================
  Hits         1697     1697
  Misses         11       11

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1398f9a...7f5ae0d. Read the comment docs.


Separated syntax file for better combacibility

some plugins resource vimrc files(such as perdirvimrc) after BufRead, causing NerdTree to lose color.
Separated syntax file makes vim to determin when to highlight colors, reguarding filetype=nerdtree.

Pulled, cheers :)


Migration from amazon-echo-ha-bridge

Hi,
I am trying from amazon-echo-ha-bridge to migrate to the latest ha-bridge, but can't quite work out what needs configured and how.
How/where/what do I populate to duplicate the 'on url' of:
"http://localhost:8080/CMD?Sonoff4=ON"
(happens to be a call into openHab which then goes to mosquito which then goes to a sonoff switch - but I don't think that really matters)
Thanks,
David

Reading is your friend: https://github.com/bwssytems/ha-bridge/blob/master/README.md

Reading is fine. And i appreciate your work on github. Unfortunately my understanding from what i read does not answer my question. That is evidently my fault.
Thanks.
On 24 Mar 2017 8:30 pm, BWS Systems<EMAIL_ADDRESS>wrote:
Reading is your friend: https://github.com/bwssytems/ha-bridge/blob/master/README.md
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://github.com/bwssytems/ha-bridge/issues/567#issuecomment-289135086, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AZYOMxijAeYsgxeMMQiEZ_cnyWwpdgQCks5rpCfXgaJpZM4MoTGj.

Unfortunately I have been pulling my hair out also with the new UI and how to fix all of the items previously working fine with openhab. I have googled my way around for every comment and cannot find much of anything to help, very little openhab feedback for configurating the proper POST arrangements in this new UI and I have everything working fine via postman and browser urls, just cannot make it work in these new versions of ha-bridge. Need some HELP please.

So, in the UI, Type is for the communication selection. in this case it is HTTP device. Target Item is where your URL goes i.e. http://<IP_ADDRESS>/dosomething. HTTP Verb is the PUT/POST/GET. HTTP Body is for the payload that goes with the PUT/POST if there is one and then there is the Headers if you have something special and then the context of text/xml/json or others.
Then hit the Add button to the right of that line. then name your device and save it.
As far as openhab specifics, you would need to refer to their API guide.

Thanks for the response.
I select on the emulator webUI home->Add/edit
On this page I then set Device type as 'switch', Map Type as 'HTTP device', and in the 'On items' section I fill in again the type as 'HTTP device', the HTTP verb as 'GET', and the context type as 'text/html' (see screenshot below).
Where should I put the URL I want it to get?? (the  "http://localhost:8080/CMD?Sonoff4=ON" quoted above)
Clicking 'Add' in the 'On items' section has no effect.
If I them click on the 'Add Bridge Device' at the top the device is added to the list of bridge devices.
If I try and test this device I get the error: "Request error, Pleae look in your habridge log: error ...... could not find url...."
The terminal o/p is: 2017-03-28 23:07:05,073 [qtp1235577049-18] WARN  com.bwssystems.HABridge.hue.HueMulator - Could not find url: 5 for hue state change request: thehabridgeuser from <IP_ADDRESS> body: {"on":true}

To partially answer my own question - if I put "http://localhost:8080/CMD?Sonoff4=ON" in the 'Target item' text box, then the 'Add' button beside will work. I can do a similar thing for the 'Off Items' and then "Update Bridge device".
The 'Test ON' and 'Test OFF' buttons now work.
However if I try to edit this device again the 'On Items' and 'Off Items' are once again blank - may be this is a bug.
Also I notice that the phrase/label "target item" does not appear in the readme: https://github.com/bwssytems/ha-bridge/blob/master/README.md

you need to hit save device at the top

I have tried to find a working configuration for my previously working openhab itesm wit no joy. I had read the wikis and have re-read hat you suggested above . No joy.
To top it off it sounds like everytime i make a change I might not be hitting the correct button? Do i have to click add everytime and enter in a new line when i make a device edit or do i hit update bridge device at top or another button?
I also am not sure of the correct syntacx for things like body, etc for openhab items. Do they need to be in braces or brackets? I do not see where this is clear.
If someone could just post a sample working openhab rest example it would probably help alot of people out there trying to make this new version work. I am by no means a novice with the Openhab 1.x going a few years back and running 2.0 now. I have used the echobridge in early flavors with no issue and even your fork fine up to the UI redesign. I'm just trying to get it working for openhab. I have harmony working etc.
Thanks again for your work and efforts.

Hi ubergeeks,
For the test device I have working my "device.db" entry is as follows:
{"id":"5","uniqueid":"00:17:88:5E:D3:05-05","name":"Shelf light","mapId":"undefined-copy","mapType":"httpDevice","deviceType":"switch","offUrl":"[{\"item\":\"http://localhost:8080/CMD?Sonoff4\u003dOFF\",\"type\":\"httpDevice\",\"httpVerb\":\"GET\",\"contentType\":\"text/html\"}]","onUrl":"[{\"item\":\"http://localhost:8080/CMD?Sonoff4\u003dON\",\"type\":\"httpDevice\",\"httpVerb\":\"GET\",\"contentType\":\"text/html\"}]","httpVerb":"GET","contentType":"text/html","contentBody":"http://localhost:8080/CMD?Sonoff4\u003dON","contentBodyOff":"http://localhost:8080/CMD?Sonoff4\u003dOFF","inactive":false,"noState":false,"offState":false,"description":"shelf light"}
Note, if I try to edit this device through the 'Edit/copy' button the form appears blank.
Perhaps we will not need to use the bridge when the openhab Alexa skill is available - but I have no idea when this will be.

Then again maybe I missed the announcement by 1 month:  https://community.openhab.org/t/official-alexa-smart-home-skill-for-openhab-2/23533
(although looks like OH2 required)

Yes, but that uses the cloud service, prefer all  local but am also looking into it. I did migrate to OH2 a while back but still working with items statically defined in items files.
I just wanted to also report back I looked at my overall install and figured it must be related to the docker. The docker itself is fine, I was using a pipework docker to assign a different IP than the docker host, which for some reason is causing the communication to fail. I have pipework serving IP's to other dockers without issue, but there is something I'm missing. Anyway, set to use host IP now and all is well.
Great work and thanks again to BWS for the contribution and development of this bridge.


Updating existing project with the newer Ingnite-generated scaffolding

A question/discussion/feature request
I've stated a project a few weeks ago, got tons of value from the generated code - thanks! Now there's a new release of Ignite. Other than reading the change log, cherrypicking changes, is there anything that could be done to benefit from a new release?
A lot of files in my project didn't change since they were generated. There could maybe be a way to update those somehow?
A general question - is there an intent to support people who have created the project, or the focus is really on first-time project generation?

It is our ambition to create an update system in version 3.0.   As for now, we are focussed on our 2.0 release, so the upgrade job falls solely on your shoulders 😞    We are open to any feedback on how we could make this simpler before 3.0.
As for your general question.  Our generators will be upgraded in 2.0, and will be updatable!  But the code they generate will not be our concern until 3.0

Gonna close this issue, re-open if this fails to explain something, or comment if you have suggestions on how we could best help.


can not pip install

I'm struggling to pip install this app, I also noticed that there is another app with the same name and both apps use the same pip command to install.
I am on python 3.6 and using django 1.11

(Closing this for now, pending feedback.)


Adds better PyVista -> xarray conversions

Codecov Report

Merging #30 (870bd88) into main (f3727f1) will increase coverage by 0.52%.
The diff coverage is 94.44%.

@@            Coverage Diff             @@
##             main      #30      +/-   ##
==========================================
+ Coverage   90.20%   90.73%   +0.52%
==========================================
  Files           8        8
  Lines         194      205      +11
==========================================
+ Hits          175      186      +11
  Misses         19       19

Impacted Files
Coverage Δ

pvxarray/io.py
85.00% <94.11%> (+5.00%)
:arrow_up:

pvxarray/__init__.py
100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f3727f1...870bd88. Read the comment docs.


05/06/2018 20:53 : Create Pull Request for branch master -> prTesting1_2018050620

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

split/updateTestRef1.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


ggml_cuda_compute_forward: SCALE failed.  CUDA error: invalid configuration argument

./bin/sd -m ../models/sd-v1-4.ckpt --cfg-scale 5 --steps 30 --sampling-method euler  -H 1024 -W 1024 --seed 42 -p "fantasy medieval village world inside a glass sphere , high detail, fantasy, realistic, light effect, hyper detail, volumetric lighting, cinematic, macro, depth of field, blur, red light and clouds from the back, highly detailed epic cinematic concept art cg render made in maya, blender and photoshop, octane render, excellent composition, dynamic dramatic cinematic lighting, aesthetic, very inspirational, world inside a glass sphere by james gurney by artgerm with james jean, joe fenton and tristan eaton by ross tran, fine details, 4k resolution"

results are:
ggml_cuda_init: GGML_CUDA_FORCE_MMQ:    no
ggml_cuda_init: GGML_CUDA_FORCE_CUBLAS: no
ggml_cuda_init: found 8 CUDA devices:
  Device 0: NVIDIA GeForce RTX 2080 Ti, compute capability 7.5, VMM: yes
  Device 1: NVIDIA GeForce RTX 2080 Ti, compute capability 7.5, VMM: yes
  Device 2: NVIDIA GeForce RTX 2080 Ti, compute capability 7.5, VMM: yes
  Device 3: NVIDIA GeForce RTX 2080 Ti, compute capability 7.5, VMM: yes
  Device 4: NVIDIA GeForce RTX 2080 Ti, compute capability 7.5, VMM: yes
  Device 5: NVIDIA GeForce RTX 2080 Ti, compute capability 7.5, VMM: yes
  Device 6: NVIDIA GeForce RTX 2080 Ti, compute capability 7.5, VMM: yes
  Device 7: NVIDIA GeForce RTX 2080 Ti, compute capability 7.5, VMM: yes
[INFO ] stable-diffusion.cpp:195  - loading model from '../models/sd-v1-4.ckpt'
[INFO ] model.cpp:796  - load ../models/sd-v1-4.ckpt using checkpoint format
[INFO ] stable-diffusion.cpp:235  - Version: SD 1.x
[INFO ] stable-diffusion.cpp:266  - Weight type:                 f32
[INFO ] stable-diffusion.cpp:267  - Conditioner weight type:     f32
[INFO ] stable-diffusion.cpp:268  - Diffusion model weight type: f32
[INFO ] stable-diffusion.cpp:269  - VAE weight type:             f32
[INFO ] stable-diffusion.cpp:482  - total params memory size = 2719.24MB (VRAM 2719.24MB, RAM 0.00MB): clip 469.44MB(VRAM), unet 2155.33MB(VRAM), vae 94.47MB(VRAM), controlnet 0.00MB(VRAM), pmid 0.00MB(VRAM)
[INFO ] stable-diffusion.cpp:501  - loading model from '../models/sd-v1-4.ckpt' completed, taking 11.04s
[INFO ] stable-diffusion.cpp:528  - running in eps-prediction mode
[INFO ] stable-diffusion.cpp:655  - Attempting to apply 0 LoRAs
[INFO ] stable-diffusion.cpp:1127 - apply_loras completed, taking 0.00s
[INFO ] stable-diffusion.cpp:1251 - get_learned_condition completed, taking 65 ms
[INFO ] stable-diffusion.cpp:1274 - sampling using Euler method
[INFO ] stable-diffusion.cpp:1278 - generating image: 1/1 - seed 42
ggml_cuda_compute_forward: SCALE failed
CUDA error: invalid configuration argument
  current device: 0, in function ggml_cuda_compute_forward at /root/share/stable-diffusion.cpp/ggml/src/ggml-cuda.cu:2326
  err
/root/share/stable-diffusion.cpp/ggml/src/ggml-cuda.cu:102: CUDA error
Aborted (core dumped)

I am using cuda_12.2,  titan 2080 Ti GPU.

I can run sd_xl_turbo_1.0_fp16.safetensor without error


Upgrade core library to 3.6.1

Fixes edge cases in polyfill and improves polyfill perf in some cases (though not in my current benchmarks).

Pull Request Test Coverage Report for Build 157

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 100.0%

Totals

Change from base Build 156:
0.0%

Covered Lines:
724

Relevant Lines:
724

💛  - Coveralls

The performance improvements really appeared for the very large geofences. And according to Isaac seemed to mostly be Clang vs GCC (I compiled in Clang and got the improvements, GCC was equally fast with both) so it could be more compiler-dependent than I would have expected.

The performance improvements really appeared for the very large geofences. And according to Isaac seemed to mostly be Clang vs GCC (I compiled in Clang and got the improvements, GCC was equally fast with both) so it could be more compiler-dependent than I would have expected.

With my current benchmark on a relatively small polygon, there was no appreciable difference. But since we also get correctness, that's still a good thing :).


fix: now interests are not fallbacks for most used languages

Description
Interests are no longer fallbacks for a user's most languages as interests aren't necessarily languages, e.g. Hacktoberfest. As well aside from Hacktoberfest, the other interests are languages, but it's not reflective of someone's most used languages.
What type of PR is this? (check all applicable)

[ ] 🍕 Feature
[x] 🐛 Bug Fix
[ ] 📝 Documentation Update
[ ] 🎨 Style
[ ] 🧑💻 Code Refactor
[ ] 🔥 Performance Improvements
[ ] ✅ Test
[ ] 🤖 Build
[ ] 🔁 CI
[ ] 📦 Chore (Release)
[ ] ⏩ Revert

Related Tickets & Documents
Fixes #2281
Mobile & Desktop Screenshots/Recordings

Steps to QA

You need to be logged in
Ensure you have no interests set in your user settings, https://deploy-preview-2373--oss-insights.netlify.app/user/settings

3.  If you're not in the grid, add yourself in a test list.
This is actually hard to test as most people will have languages already, so the fallback will not kick in. 🤔 Maybe the unit tests are enough for this.
Added to documentation?

[ ] 📜 README.md
[ ] 📓 docs.opensauced.pizza
[ ] 🍕 dev.to/opensauced
[ ] 📕 storybook
[x] 🙅 no documentation needed

[optional] Are there any post-deployment tasks we need to perform?
[optional] What gif best describes this PR or how it makes you feel?

Curious if we have a fallback of - displayed on the table when a user has no language to prevent an empty column.

I can add that if there are no languages or do our tables handle that out of the box?

I can add that if there are no languages or do our tables handle that out of the box?

The table does not handle that out of the box... You can add that as a fallback 👍

I can add that if there are no languages or do our tables handle that out of the box?

The table does not handle that out of the box... You can add that as a fallback 👍

I've added a fallback.


Profiles Editor: Use for current Window toggle state confusing

I find the Use for ... actions very confusing in the context menu.

I think the Use for Current Window should not be a toggle and should be renamed to activate or something similar and be disabled when it's the current active one. I would also not add the checkbox in the profile editor on the right but move it to the top as a prominent action.
Regarding the Use for New Windows, I don't really think it has to be in the context menu and could be replaced by the action Open in new Window.

/duplicate
Thanks for the feedback.
I am combining this with https://github.com/microsoft/vscode/issues/226732


Version 2.4.1 or 2.5.0 ?

Why npm shows as actual version 2.5.0 , while here in repository in package.json is stated version 2.4.1 ? What is the difference and why it is this way?
npmjs:

github:

I forgot to push tags, that's all. Just updated them now.

Wow, there was tricky "downgrade" 2.4.0 -> 2.3.2  on 3.2.2020. Probably mistake? This should never happen, as local npm would not upgrade to lower version.
...please, create CHANGELOG.md and keep all information about changes there !

Probably some weirdness due to patches/branches being applied. Nothing to worry. :)


fix operator precedence

1. Why is this change necessary?
The method fetchProducts didn't only return the requested products but all product variants in the database. This caused to multiple problems, e.g. very slow indexing.
2. What does this change do, exactly?
It fixes the operator precedence, as AND binds stronger than OR, brackets are needed.
3. Describe each step to reproduce the issue or behaviour.
Start indexing (e.g. with bin/console es:index). Drastic speed improvement with for example 20k product variants.
4. Please link to the relevant issues (if any).
5. Checklist

[ ] I have written tests and verified that they fail without my change
[x] I have squashed any insignificant commits
[x] I have created a changelog file with all necessary information about my changes
[x] I have written or adjusted the documentation according to my changes
[x] This change has comments for package types, values, functions, and non-obvious lines of code
[x] I have read the contribution requirements and fulfil them.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.Pascal Josephy seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.

Hey @pascaljosephy, could you please sign the CLA and add an chengelog?

  I need to look into Monday. Internally and locally is everything green always...

Is green again

Hello,
thank you for creating this pull request.
I have opened an issue on our Issue Tracker for you. See the issue link: https://issues.shopware.com/issues/NEXT-16160
Please use this issue to track the state of your pull request.

Hey,
has been merged with https://github.com/shopware/platform/commit/9bcac003899eb9b735e267dc3a5e79299b172461
Thanks for your contribution! :blue_heart:


[SPARK-33251][FOLLOWUP][PYTHON][DOCS][MINOR] Adjusts returns PrefixSpan.findFrequentSequentialPatterns

What changes were proposed in this pull request?

Changes
pyspark.sql.dataframe.DataFrame

to
:py:class:`pyspark.sql.DataFrame`

Why are the changes needed?

Consistency (see https://github.com/apache/spark/pull/30285#pullrequestreview-526764104).
Does this PR introduce any user-facing change?

User will see shorter reference with a link.
How was this patch tested?

dev/lint-python and manual check of the rendered docs.

cc @huaxingao

@huaxingao, BTW, have you tried to merge PRs? I will leave it for you to try merging :-).

Test build #130858 has started for PR 30313 at commit 5581bb3.

Test build #130858 has finished for PR 30313 at commit 5581bb3.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/130858/
Test PASSed.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35466/

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35466/

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/35466/
Test PASSed.

Merged to master. Thanks! @zero323 @HyukjinKwon

Thanks @huaxingao @HyukjinKwon!


Added Quote of the Day Feature

Added this feature to allow users to retrieve motivational quote each day.
Added new file quote_of_the_day.py
API used Forismatic API
Fixes #144
@suryanshsk

@suryanshsk i received mail that this pr is merged but its not...Am i doing any mistake??


Please provide more instructions

Thanks for the response. i did lot of modifications, but stuck at one point. please find the screenshot, i am not able to move from this point.

bro , contact me @ whatsapp +919176462946


Query number of lanes of a SIMD vector type

Should we add a way to programmatically query the number of lanes of a SIMD vector type?
If so,

should we use an associated function or an associated const?
how should we name it?

The f32x8::len associated function landed on master, we should either resolve this issue or remove it before the next release.

What is the use case for a len method?

The only situation in which I wanted it was to iterate over the lanes of a SIMD vector via a type alias:
type fvec = f32x8;
for i in 0..fvec::len() {
    v.store(i, ...)
}

That way if I later change the vector type to f32x16; the loop remains correct.
If use 0..8 I would need to keep the trip count and the vector type in sync.

Having said this, I think that a ::LANES associated const would be a better fit, and I acknowledge that writing a loop over the lanes is not good style, but sometimes necessary to write portable fallback implementations of some SIMD operations that work on the portable vector types.

I feel like we should not have this unless there is a more compelling use case.

There is a discussion about adding the size and align of the integer types as associated const of those types, so that you can write i32::SIZE instead of ::std::mem::size_of::<i32>(). In some contrived sense, this is similar to that, but I agree that at least my use case isn't very compelling, and I can achieve the same by just implementing a trait for the simd types externally (as in, this doesn't need to be part of stdsimd).

FWIW an associated function would scale better to runtime-sized SIMD vectors like Arm SVE.

I've received a few requests to implement this in faster, mainly for performing reductive operations over a vector. I didnt't want to add it there because it could cause people to write non-portable code, but because that isn't a goal of stdsimd (afaik) I don't see any reason to not add it.

I've renamed this to Self::lanes() -> usize in the portable vector types API rework, and have found it extremely useful when implementing the rest of the API.
@parched

FWIW an associated function would scale better to runtime-sized SIMD vectors like Arm SVE.

I think we shouldn't try to create an API for both packed and scalable vector types. We should try to be consistent with naming, but these two APIs are different enough that I personally consider them to be orthogonal.
That is, we should pursue an API for packed SIMD types that stands on its own first, followed by pursuing architecture-specific APIs for scalable vector types (ARM, RISCV, ..).
Pursuing a portable API for scalable vector types is pretty much an open research problem at this point in time, and trying to come up with a portable API that works for both is another open research problem whose solution necessarily must come afterwards.

I'm closing this, the RFC proposes to use lanes() here and nobody has complained there. If you have an opinion about this, speak up in the RFC PR: https://github.com/rust-lang/rfcs/pull/2366


ARROW-2232: [Python] pyarrow.Tensor constructor segfaults

Test suite is failing for some reason

This PR is ready to go, modulo any more review comments.


Not working inside Bootstrap Tabs

Hi,
I have placed the star rating code inside Bootstrap Tabs.
In Chrome, the star icons only show empty stars, when I click on any tab then the stars rating plugin is initialized and works properly. In Safari, the stars show a black background on page load, again if I click on any tabs then the it renders properly.
I understand this is because it's placed inside tabs which are hidden initially and I have tried the following code but doesn't work. Please help.
$(document).on( 'shown.bs.tab', 'a[data-toggle=\'tab\']', function (e) { $(".product-rating-view").starRating({     starSize: 15,     activeColor: 'red',     readOnly: true,     emptyColor: '#ffffff',     starGradient: {       start: '#ffbd00',       end: '#ffbd00'   } }); });
Thanks for creating this cool plugin.

Hello, any chance you could upload your code so I can give you a couple of options?


templates and static missing when doing pip install

The templates and static are missing once I did a pip install, how can I fix this?

Thanks a lot @JEDuRam :)
It's fixed now. make sure you install version 0.2.6.


SHARED: Language group (default) not visible in CMS group editor

The language group is not visible in the CMS group editor using the default seeded data. It shows when deleting the Luminary cache (from the user settings page) but vanishes after the web-app is refreshed.
Further investigation shows that the document is synced from the API to the CMS but is deleted after first refresh.

To check if the PR is solving the issue, delete the Luminary cache (from settings) and check if the Languages group stays visible after refreshing the page.


Summer of Bitcoin project ideas

Utreexo is part of Summer of Bitcoin but with no C++ project ideas.
After a brief discussion with @kcalvinalvin, I am opening this issue in order to get @dergoegge take on what work needs to be done and if from that a project idea could be potentially created.
Calvin already mentioned that some tests need to be ported to the C++ implementation, so apart from a more solid project idea, it would be great to get a few guidelines on things I can tackle while preparing for my proposal.

Hi Andreas, thank you for your interest!
I have not thought much about concrete projects, so i will just list some things that still need work.

As you mentioned, working on adding tests would be helpful.
I recently added some simple fuzzing tests which could also be built out further.
Adding benchmark tests. This would be helpful to make sure that we don't degrade performance when changing things and would also give us an incentive to improve performance.
Most of the complexity in this library comes from the caching mechanism that helps with reducing the proof sizes. If you have a look at https://github.com/mit-dci/libutreexo/blob/32ef51b2a63e7f74f6054ef1e63d193ca06d6634/src/pollard.cpp#L343 or https://github.com/mit-dci/libutreexo/blob/32ef51b2a63e7f74f6054ef1e63d193ca06d6634/src/pollard.cpp#L480 you can see what i mean, those two functions are not the easiest to understand. Creating an implementation of the accumulator that can't do caching could be nice to have a minimal implementation that is not super complex. This would also be a cool project for you because you get to rewrite some of the algorithms from scratch. (if you like that kind of stuff)

An example for 1. would be to a test for the RamForest that specifically tests RamForest::Undo. The simple_blockchain test already tests RamForest::Undo but i think having a dedicated test would also be good.https://github.com/mit-dci/libutreexo/blob/32ef51b2a63e7f74f6054ef1e63d193ca06d6634/src/test/accumulator_tests.cpp#L433-L441
I think 3. and/or 4. might be candidates for a SoB project. I will try to think of more projects/things to work on and add them to this issue.
I don't know how much you have looked at Utreexo, so if you have any questions about the above let me know. I remember when i first got started with this project a lot of the algos were not the easiest to understand. We have an IRC channel #utreexo on libera, feel free to join and ask questions there as well.

I took some time to deep dive into the codebase to get more familiar and further validate that this interests me. I believe that I now have a pretty good understanding of how everything works. Still, as this is transliteration of the go reference implementation, I think that inevitably I'll have to look that one also.
Regarding adding unit tests, I've run test coverage for the unit tests and it seems that only some unhappy paths are untested. What you mentioned about a specific test for RamForest::Undo seems redundant as apart from simple_blockchain this is also tested in the simple test. I am not sure how a dedicated test adds any more value, however I wrote one and with that I tried to cover another untested path. You can see those changes at #14.
Benchmarking is interesting and if I can do a similar approach to what Bitcoin Core is doing, I could potentially also use that experience there. The minimal implementation is also cool and something that could be used as a baseline for benchmarking the caching mechanism of the accumulator, so I think that those 2 could be combined for a SoB project. I've also noticed a few TODOs in the implementation that I could also work on.
This is an intriguing project and working on it as part of SoB is something that stills interests me.
In the guide section of SoB it says

You are free to propose your own project idea too, as long as that project idea is from one of the participating organizations.

That said, as Utreexo is a participating organization, I am not sure if for me to be able to propose a project idea for this implementation, you must create a new project idea or I can just write a proposal without it. I'll ask in the discord server, but as the proposal process requires the participants to show interested for a specific idea and then assign a proposal to that idea through the dashboard, I think that you might need create a new project idea.

Hey thanks for the PR. I'll take a look.
Regarding Summer of Bitcoin: Utreexo is a participating organization as Tadge and I are mentors. For Summer of Bitcoin specific stuff, do contact either one of us (I'm easier to get hold of).
I'm not aware of exact summer of bitcoin rules but if you need me to make a project, happy to do so.

Thanks for the quick reply.
I asked in the discord server and it seems that the process is simpler if a project idea exists, so if you can create one it would be great!

https://www.summerofbitcoin.org/project-ideas-details?recordId=recd8CF7zeCAAtFIf


[Bug] [API] fix task definition api bug

#8269

Codecov Report

:exclamation: No coverage uploaded for pull request base (2.0.4-prepare@3066896). Click here to learn what that means.
The diff coverage is n/a.

@@               Coverage Diff                @@
##             2.0.4-prepare    #8270   +/-   ##
================================================
  Coverage                 ?   21.03%
  Complexity               ?     1577
================================================
  Files                    ?      536
  Lines                    ?    22420
  Branches                 ?     2641
================================================
  Hits                     ?     4716
  Misses                   ?    17228
  Partials                 ?      476

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3066896...737541e. Read the comment docs.


Remove mergeMetaIntoConfig script

This was a one-time-use script but it imports types type like ConfigReader and RawDiscoveryConfig, so if we don't remove it, we'll start getting build errors when these types change.

Good spot! Fixed.


background theme matched with option selected

Before
https://github.com/Bookingjini-Labs/bookingjini-icons/assets/83714476/e6fbe01d-5bb6-4d5c-8a15-595bfc7cfba5
After
https://github.com/Bookingjini-Labs/bookingjini-icons/assets/83714476/07d748a0-c628-462c-8ac8-6fa5d2b7a7ad

please tag the issue number


Add new typeDetails symbol mixin

Bug/issue #, if applicable: rdar://107432025
Summary
Add new typeDetails symbol mixin to hold type details of weakly-typed dictionary keys and HTTP parameters.
JSON structures and HTTP parameters can define fields that can take values of multiple types,
such as integers or strings. The typeDetails mixin allows the symbol graph to identify the individual types that are supported. DocC will use this information to list the "Possible types" in the rendered pages for the affected keys and parameters.
Dependencies
None.
Testing
To be described in parallel DocC PR.
Checklist
Make sure you check off the following items. If they cannot be completed, provide a reason.

[x] Added tests
[x] Ran the ./bin/test script and it succeeded
[x] Updated documentation if necessary

@swift-ci please test

@swift-ci please test


Fixed minor formatting nitpick

You guys should know better :D
https://github.com/iojs/io.js#is-it-iojs-or-iojs-or-iojs-or-iojs-or-iojs

I respectfully disagree with their readme and use Io because it's the proper formatting for Io the moon of Saturn :)

Closing the, I guess :)


feature/prework

lucas, calculator html is failing. here is an error i found in the console (inspector)
main.js:1          Failed to load resource: the server responded with a status of 404 (Not Found)
index.html:1 Refused to execute script from 'http://<IP_ADDRESS>:5500/main.js' because its MIME type ('text/html') is not executable, and strict MIME type checking is enabled.


fix: Don't call extractable_elements if strategy is ocr_only

fixes #1079 where partitioning is happening twice in the case of strategy="ocr_only"
only calls extractable_elements if we can predetermine that ocr_only is not a possible strategy even if it was the intended strategy.
Adds additional assertion test that _partition_pdf_or_image_with_ocr is not called when falling back to fast from ocr_only

Not sure exactly what your style preference is for changelog, let me know if I've gotten it wrong.

Not sure exactly what your style preference is for changelog, let me know if I've gotten it wrong.

That's exactly correct, thanks!


WIP: New blueprint for retroactive auto labeling

Fix #73
TODO

[ ] Need magic from @astrofrog to set up Heroku incantations
[ ] Need test

Coverage decreased (-1.6%) to 83.348% when pulling 15dcd47b15f763203c9727b6fc5914f9c066846f on pllim:retro-auto-label into d9c3394094a86fab87fba53c65bd9172ef6461a4 on astropy:master.

I realized I will never have time to finish this up, so I decided to follow Brigitta's advice and do this manually given there are only 22 affected.


Does not work in exsisting games (existing players)

Your on_init function should loop through existing players and initialize them

this bug was fixed in 0.2.4


Refactor modal

Coverage decreased (-0.05%) to 92.968% when pulling 7761c80908e0f0fce0cd99b0a6dd545d8b5cccd5 on refactor-modal into 9f7e840ff0983d0a8ac50f45d17d8c5dd7a14f57 on master.


Authorization Error on version 2.6.22

Describe the bug
When running the artifactory provider on version 2.6.22, I'm getting authorization errors against my artifactory instance:
Error:
403 GET https://artifactory.coxautoinc.com/artifactory/api/system/licenses/
{
  "errors" : [ {
    "status" : 403,
    "message" : "Forbidden"
  } ]
}

Requirements for and issue
- Artifactory Version: 6.23.28
- Terraform Version: 0.13.6
- Snippet:

data "artifactory_file" "lambda_artifact" {
  repository      = var.artifactory_repository
  path            = "/${local.artifactory_dir}/${var.lambda_build_tag}/${var.lambda_build_tag}.zip"
  output_path     = "${path.module}/lambda.zip"
  force_overwrite = true
}

Expected behavior
The artifactory provider should successfully authenticate against my artifactory instance and pull the file in qeustion.
Additional context
Testing out when pinning to 2.6.21, it successfully pulls the requested resource:
module.cloudwatch_splunk_logger_lambda.data.artifactory_file.lambda_artifact: Refreshing state... [id=https://.../master-17.zip]

@binelson Does the Artifactory user/API key has admin permission/role?
2.6.22 contains a new provider attribute check_license and you can set it to false to bypass this step.

I was seeing similar behavior after upgrading the provider version from 2.6.21 to 2.6.22.
Terraform version is 1.0.9.
A terraform plan ended up in
400 GET https://rwest.jfrog.io/artifactory/api/system/licenses/
 {
   "errors" : [ {
     "status" : 400,
     "message" : "Artifactory Online does not require license, Please contact<EMAIL_ADDRESS>for further assistance if equired."
   } ]
 }

Adding the check_license = false to the provider made the terraform plan complete successfully.

I'll test that out and see if it fixes it, however can that value just be updated to default to false in the code base?  I feel like that should be the case if the behavior has changed with this release.

Hi, when doing a terraform init, I started to see the same issue as in Incompatible provider version https://github.com/jfrog/terraform-provider-artifactory/issues/240 after which I tried to upgrade from 2.6.21 to 2.6.22. After the upgrade, terraform init worked fine, but when running terraform plan I started to get:
│ Error: Artifactory requires Enterprise license to work with Terraform!
│
│   with provider["registry.terraform.io/jfrog/artifactory"],
│   on main.tf line 12, in provider "artifactory":
│   12: provider "artifactory" {

our type of licence is: "type": "Commercial" self hosted Artifactory Pro.
Everything works fine again if I set: check_license = false in provider section.

Even we are surprised sometimes by RT and it's APIs - @alexhung maybe we can add this as one of the acceptable license types?
@aliculPix4D - the idea is to bail quickly if your version of RT won't support terraform because API access is prevented.

@aliculPix4D I'll add Commercial to the license check.
And judging from the feedback, I'll switch the default value of check_license from true to false.

Thanks @chb0github @alexhung for quick reaction.


chore: use term 'retries' instead of 'retryAttempts' consistently

Motivation
Consistency in naming, and avoiding confusion if this setting is count of retries or count of attempts.
Description
Use term 'retries' instead of 'retryAttempts' consistently

:tada: This PR is included in v1.17.0 :tada:


Use POST inside Exec::resize

Otherwise, the function always returns a serialization error.
What did you implement:
I was trying to resize an exec instance in https://github.com/marhkb/pods/pull/451 but realized that it always failed because GET was used instead of POST. Therefore, I changed to POST.
How did you verify your change:
After implementing the change, the width of the output of ls in an Alpine container could be changed.

LGTM, thank you! I'll fix the errors in the master branch, seems unrelated to this PR.


⚠ Bofrost.de has degraded performance

In e071a5b, Bofrost.de (https://www.bofrost.de) experienced degraded performance:

HTTP code: 200
Response time: 1628 ms

Resolved: Bofrost.de performance has improved in 3d83645 after 6 minutes.


It fixes layout for:
http://training.play-with-docker.com/docker-containers/

Thanks!


run_model_bpa_bulk gives error CalculatedColumn' object has no attribute 'SourceColumn

run_model_bpa_bulk gives error CalculatedColumn' object has no attribute 'SourceColumn
We checked it, we do not have any calculated column in dataset which has error.
Above problem I am facing is with many datasets. Example out of 50 dataset I found this problem in 10 datasets.
It does not collect any data after throwing this error
Collecting Model BPA stats for the 'CHC_PIPE' semantic model within the 'PBI_DMRDXXXXXXXXXXX' workspace.
🔴 Model BPA failed for the 'CHC_PIPE' semantic model within the 'PBI_DMRDXXXXXXXXXXX' workspace.
'CalculatedColumn' object has no attribute 'SourceColumn'
⌛ Saving the Model BPA results of the 'PBI_DMRDXXXXXXXXXXXX' workspace to the 'modelbparesults' within the 'data_powerbi_platform' lakehouse within the 'XXXXXXXXXXXXXX' workspace...

What happens when you run the 'run_model_bpa' function against the CHC_PIPE semantic model?

labs.run_model_bpa(dataset = 'CHC_PIPE',  workspace = 'PBI_DMRD_DEV_CHC_PPIPE')
results are as belwo:
AttributeError                            Traceback (most recent call last)
Cell In[13], line 1
----> 1 labs.run_model_bpa(dataset = 'CHC_PIPE',  workspace = 'PBI_DMRD_DEV_CHC_PPIPE')
File ~/cluster-env/clonedenv/lib/python3.11/site-packages/sempy/_utils/_log.py:310, in mds_log..get_wrapper..log_decorator_wrapper(*args, **kwargs)
307     raise
309 try:
--> 310     result = func(*args, **kwargs)
312     # The invocation for get_message_dict moves after the function
313     # so it can access the state after the method call
314     message.update(extractor.get_completion_message_dict(result, arg_dict))
File ~/cluster-env/clonedenv/lib/python3.11/site-packages/sempy_labs/_model_bpa.py:293, in run_model_bpa(dataset, rules, workspace, export, return_dataframe, extended, language, **kwargs)
291     x = [nm(obj) for obj in tom.all_hierarchies() if expr(obj, tom)]
292 elif scope == "Table":
--> 293     x = [nm(obj) for obj in tom.model.Tables if expr(obj, tom)]
294 elif scope == "Relationship":
295     x = [nm(obj) for obj in tom.model.Relationships if expr(obj, tom)]
File ~/cluster-env/clonedenv/lib/python3.11/site-packages/sempy_labs/_model_bpa.py:293, in (.0)
291     x = [nm(obj) for obj in tom.all_hierarchies() if expr(obj, tom)]
292 elif scope == "Table":
--> 293     x = [nm(obj) for obj in tom.model.Tables if expr(obj, tom)]
294 elif scope == "Relationship":
295     x = [nm(obj) for obj in tom.model.Relationships if expr(obj, tom)]
File ~/cluster-env/clonedenv/lib/python3.11/site-packages/sempy_labs/_model_bpa_rules.py:244, in model_bpa_rules..(obj, tom)
34     print(
35         "The 'workspace' parameter has been deprecated. Please remove this parameter from the function going forward."
36     )
37     del kwargs["workspace"]
39 rules = pd.DataFrame(
40     [
41         (
42             "Performance",
43             "Column",
44             "Warning",
45             "Do not use floating point data types",
46             lambda obj, tom: obj.DataType == TOM.DataType.Double,
47             'The "Double" floating point data type should be avoided, as it can result in unpredictable roundoff errors and decreased performance in certain scenarios. Use "Int64" or "Decimal" where appropriate (but note that "Decimal" is limited to 4 digits after the decimal sign).',
48         ),
49         (
50             "Performance",
51             "Column",
52             "Warning",
53             "Avoid using calculated columns",
54             lambda obj, tom: obj.Type == TOM.ColumnType.Calculated,
55             "Calculated columns do not compress as well as data columns so they take up more memory. They also slow down processing times for both the table as well as process recalc. Offload calculated column logic to your data warehouse and turn these calculated columns into data columns.",
56             "https://www.elegantbi.com/post/top10bestpractices",
57         ),
............XXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX>>>>>>>>>>>>>>>>>>>>
      "Formatting",
809             ["Table", "Column", "Measure", "Partition", "Hierarchy"],
810             "Info",
811             "First letter of objects must be capitalized",
812             lambda obj, tom: obj.Name[0] != obj.Name[0].upper(),
813             "The first letter of object names should be capitalized to maintain professional quality.",
814         ),
815         (
816             "Naming Conventions",
817             ["Table", "Column", "Measure", "Partition", "Hierarchy"],
818             "Warning",
819             "Object names must not contain special characters",
820             lambda obj, tom: re.search(r"[\t\r\n]", obj.Name),
821             "Object names should not include tabs, line breaks, etc.",
822         ),
823     ],
824     columns=[
825         "Category",
826         "Scope",
827         "Severity",
828         "Rule Name",
829         "Expression",
830         "Description",
831         "URL",
832     ],
833 )
835 return rules

File ~/cluster-env/clonedenv/lib/python3.11/site-packages/sempy_labs/tom/_model.py:2280, in TOMWrapper.is_field_parameter(self, table_name)
2270 import Microsoft.AnalysisServices.Tabular as TOM
2272 t = self.model.Tables[table_name]
2274 return (
2275     any(
2276         p.SourceType == TOM.PartitionSourceType.Calculated
2277         and "NAMEOF(" in p.Source.Expression
2278         for p in t.Partitions
2279     )
-> 2280     and all(
2281         "[Value" in c.SourceColumn
2282         for c in t.Columns
2283         if c.Type != TOM.ColumnType.RowNumber
2284     )
2285     and t.Columns.Count == 4
2286 )
File ~/cluster-env/clonedenv/lib/python3.11/site-packages/sempy_labs/tom/_model.py:2281, in (.0)
2270 import Microsoft.AnalysisServices.Tabular as TOM
2272 t = self.model.Tables[table_name]
2274 return (
2275     any(
2276         p.SourceType == TOM.PartitionSourceType.Calculated
2277         and "NAMEOF(" in p.Source.Expression
2278         for p in t.Partitions
2279     )
2280     and all(
-> 2281         "[Value" in c.SourceColumn
2282         for c in t.Columns
2283         if c.Type != TOM.ColumnType.RowNumber
2284     )
2285     and t.Columns.Count == 4
2286 )
AttributeError: 'CalculatedColumn' object has no attribute 'SourceColumn'

I believe the issue is with the is_field_paramter in the TOMWrapper. Do you have a calculated table which uses the NAMEOF function? And this table also has a calculated column? Can you share more on this so I can make the appropriate fix?

yes, I have a calculated table using NAMEOF function and it also has a calculated column.

Thanks. I've put a fix in place for the next release.


Fix tailwindcss

-Create new VM Ubuntu
-Install nodjs with npm
-Install python and poetry
-Fork bunadmin repo
-Build css with tailwindcss

estevanmaito-windmill-dashboard-1.0.2-0-g27e1092.zip

The problem was due to misconfiguration in the tailwindcss.config file for the content section.  The path for html and javascript files was wrong, It was pointing to outside the project folder which created permission issues.
Wrong pattern -> //templates//*.{html, js} - pointing to outside project folder
Corrected pattern  -> ..//templates//*.{html, js}


[MI1 VGA floppy] Modifying the total length of certain lines triggers "BUG: TableOfContent::merge different roomIds"

Summary
In the VGA 1.1 version (also seen in the 1.0 version) there is an issue with translating from ~ line 360 onwards
Removed (59, 0x13AB3) from the index
BUG: TableOfContent::merge: different roomIds

I have narrowed down the issue by taking the original exported text and changing just 1 character.
When you add or remove a even a single character there, it fails with this kind of error:
When compensating for the character removal/addition with an equal amount of characters on one of the next lines, the error does not show up.
in 1.1; line 362 (not counting the two new scummtr header lines):
I just knew you'd be back!\255\003I knew you wouldn't be able to get that little beauty out of your mind!\255\003Come on.  Let's go take another look at her!
in 1.0; line 367:
chickens
This same behavior shows all the way until line 568 (The Sea Monkey in 1.1)
The next lines are fine again to translate/change length... until line 905 where the same kind of error starts (door in 1.1 - while 906 is also chickens as in 1.0... coincidence? Don't think so... In my translation, door had the exact same number of characters, so I got lucky.) Same wrong behavior until line 1033 (It will terrify you) - this is the last line in that section for the Voodoo lady, which also was problematic in the 1.0 game.
Another simple way to trigger the bug is to use the -A ao(v) option to export and reimport the original text, as it is likely to pad one of the lines in the sensitive blocks with @'s.  This also renders that padding option unusable for this game as a side effect.
Note: for the EGA version (also 1.0 - but older), the -A aov option round-trip export is ok. [I still need to match my translation files before I can try with an actual translation on that version]
Impacted games
The Secret of Monkey Island
ScummTR versions
v0.5.1
I own a legitimate game

[X] I promise that my game does NOT come from an illegal source, such as "abandonware" websites

Hi, thank you for your report and the details you provided!
Sorry, it took me some time to look at this and come back to you.
I'm pretty sure that we hit this original Monkey1 VGA bug that ScummPacker fixed many years ago:
https://bitbucket.org/jestar_jokin/scummpacker/commits/96f34dc6a2b947dea259382387c574329c819efe
i.e.,

The new solution will now only read in the first room block contained in an LF block; any other RO blocks are skipped. This is limited to V4 games.

But unfortunately, I didn't manage to do this change inside the ScummRP core; I just don't have a good-enough understanding of the original ScummRP code and the LFL structures to do this change myself, at the moment. If someone wants to help here, that would be very welcome.
In the meantime, if you have a Python 2 interpreter, maybe ScummPacker (documentation) could help; maybe it will fix the original game if you unpack/pack with ScummPacker first, and then use ScummTR on top of the result? (I'm not sure about this). Or maybe NUTCracker will have support for V4 games at some point.

I tried repacking it with ScummPacker, but it looks like it doesn't fix the original files (it just works around their bugs I believe), and ScummPacker event his the #47 glitch in 000.LFL when doing its repack.
So I don't have a fix for this at the moment… unless you work from a verbose language version (such as German) and manually pad each string with @ so that you always keep the original length of every string you're translating… and I'm not even sure that it would work :/
Anyway, what we know is that the VGA floppy version of Monkey1 has multiple format errors that we don't handle yet. I think I'll change the code so that repacks/imports print a big warning, since it's known to cause corruption issues.


Cannot use Sketch cloud

Hi there,
I saw the new 49 version and tried to use the sketch cloud but failed. I click the cloud button and it directed me to the cloud website. After I log in, the site asked me to go back to Sketch to upload the file. But back to the application, the sketch cloud is still asking me to sign up or login.
I tried to restart the application but still can't work. I'll try restarting the computer and see how it will go.
Best,
Jinjia

This is not a Sketch measure problem but Sketch itself. Contact Bohemian instead.


[client] add reconfig commands when we have mint key

Motivation
We add the command for cli to support adding/removing validators when it
has the mint key.
Have you read the Contributing Guidelines on pull requests?
Y
Test Plan
Test against dev net and was able to remove/add validators while do normal txns.
Related PRs
(If this PR adds or changes functionality, please take some time to update the docs at https://github.com/libra/website, and link to your PR here.)

@bors-libra r=sblackshear

:pushpin: Commit 3d0c08f has been approved by sblackshear

@bors-libra retry

:hourglass: Testing commit 3d0c08f9a0c878b806e1435a6835289035b9444a with merge e55dc623113ad353005488a69a2e52750f08e95b...

:sunny: Test successful - checks-circle_commit_workflow
Approved by: sblackshear
Pushing e55dc623113ad353005488a69a2e52750f08e95b to master...

why did we delete consensus_peers from the client in this pr?


[Bug]: Unable to deploy service due to commit hash being to long

Description
Recently a service has stopped being able to deploy due to what looks like an internal coolify issue with the commit hash length.

Minimal Reproduction (if possible, example repository)
See above image
Exception or Error
See above imge
Version
v4.0.0-beta.279

This will be fixed in the upcoming version.


fix typo anargram => anagram

Description
fix typo , anargram => anagram

Seems like we have merge conflict :)

Hello @aalhour it's been a while :)
Are you taking this change in?

Thanks for approving @dmitryvhf  but we still need @aalhour to approve before I'm able to merge!


URLs for Medication Code Set system values

The profile BELMMedProduct (at URL https://www.ehealth.fgov.be/standards/fhir/medication/StructureDefinition/BELMMedProduct) appears to represent medicinal products in the current branch - but does not include information on the intended medication code sets that should be used to exchange between systems.
While I imagine that different use cases will require different code sets, could the group point to the expected 'system' value for some of the more common medication code sets used in Belgium? And can we expand the definition of BELMMedProduct to call out these specific 'system' values?
For example, codesets like:
Virtual Medicinal Product (VMP)
Actual Medicinal Product (AMP)
Virtual Medicinal Product Group (VMP Group)
Typically the system values are URLs. As reference, for Multilex in the United Kingdom the system value is 'https://fhir.hl7.org.uk/Id/multilex-drug-codes ' and for dm+d it is 'https://dmd.nhs.uk '.

We need to create URLs / OIDs for:

AMP
AMPP
VMP
VMPGroup
CNK
CTI-Extended
Formulas (magistral/officinal)
Substances
??

We will engage with SAMv2 team and a) identify which concepts we need to have and b) define the concepts and their URLs. A separate meeting will be held and we will report back to the group.


Tab navigation

How do properly handle tab navigation?
Currently, it's not possible to continue pressing TAB after the last virtual item receives focus.
Check here: https://jsfiddle.net/mx5dzdod/

Hi @fabianonunes! If you set the overacanCount prop, it will render that number of off-canvas buffer rows before and after the visible rows. This also has the effect of enabling tab scrolling. That should make your list fully tab navigable.

Hi, Jason!
I think it's not that simple, because when the DOM element is recycled for another item, the current focus is lost.
Consider a list with 10 visible items and overscanCount={10}. When the 18th item is focused, the next TAB could motivate a scroll, recycling all nodes and the old focus is lost.
Same example, but with overscanCount={30}
https://jsfiddle.net/gnL63f5d/

@fabianonunes Yeah :( I had posted that and then started fiddling with the JSFiddle and realized the recycling kills it.  I did manage to get it working, but it requires a little bit of effort!  First, I added a focus listener to each row and persisted the currently focussed row id (just the index in this case) in the demo component's state.  When rendering a given row (now a <Row> component), a focussed boolean can then be passed in as a prop that tells the row if it is currently the focussed item.  If it is, after rendering it invokes .focus() on itself.
Second, in order to make shift+tab work, I added a componentDidUpdate() hook that just calls the DOM .scrollIntoViewIfNeeded() method on whichever row is focussed.  This scrolls the off-canvas rendered "-1th" item into view where there browser does not (it is not outside the default bounds for the browser's own focus scrolling behavior).
Here's the working JSFiddle with the above two modifications in place:
https://jsfiddle.net/developit/83h1jb2u/5/
Sorry this is so convoluted! I'd love to see something cleaner.

@developit This solution won't work if (i) the component's root isn't a focusable element, (ii) we have two focusable elements by <Row/>.
We could save the document.activeElement reference before render and reinforce focus on componentDidUpdate. But in this case, we need keyed children (to avoid reuse).
Check here: https://jsfiddle.net/Lgd86uaw/1/
Diff: https://github.com/fabianonunes/preact-virtual-list/commit/aedbd1

For the first one, I think just adding tabIndex="0" to each row would make them focussable.
For keyed children though, that sortof defeats the optimization here.  Your document.activeElement technique is definitely on the right track though....

Yes. Keyed elements has a impact on perfomance. It's not an alternative.

@fabianonunes Also I just realized - if the user scrolls the list using the mouse wheel / flick, hitting tab again uses the shifted viewport :(
I'm actually thinking overriding tab is the only way to go here.


Search PR by id/number in sidebar

I know that exists a command to checkout PR using the Command Palette (#1062), but I think that the possibility of search using Ctrl+F in GitHub Pull Requests sidebar would be useful.

Closing as out of scope because we don't intend to address this in the near future.


changes for vbeta1

changes required for vbeta1 crs

will quickly merge to continue with smaller PR in new catalog


id_token_hint not being sent to OIDC provider

Question
Hello. I'm experiencing pretty much the same issue as in #3510, but I've tried the solution mentioned there, and I can't seem to get it to work.
Minimal working example
authenticationBuilder.AddOpenIdConnect(OpenIdConnectAuthenticationSchemes.Scheme, "OIDC", options =>
{
        options.Authority = authority;
        options.ClientId = externalProviderConfiguration.ClientId;
        options.ClientSecret = externalProviderConfiguration.ClientSecret;
        options.ResponseType = "code";
        options.CallbackPath = $"/signin-{OpenIdConnectAuthenticationSchemes.Scheme}";

        options.SaveTokens = true;
        options.RemoteSignOutPath = $"/endsession";

        options.Events.OnRedirectToIdentityProviderForSignOut = async n =>
        {
                n.ProtocolMessage.IdTokenHint = await n.HttpContext.GetTokenAsync("id_token");
        }
}

In OnRedirectToIdentityProviderForSignOut , the id token is always null. I've tried with different schemes, but no luck so far.
In the ExternalLoginCallback method on the AccountController, I've verified that the access and id tokens are available.
Any chance you could give me some pointers as to where things might be going wrong?

you don't need to handle OnRedirectToIdentityProviderForSignOut - if SaveTokens is set, then that's typically done automatically for you.
Either way - that is Microsoft code - not ours.


[Question]Is there any way to just show the request body

Please use the following questions as a guideline to help me answer
your issue/question without further inquiry. Thank you.
Which version of Elastic are you using?
[ - ] elastic.v7 (for Elasticsearch 7.x)
[ ] elastic.v6 (for Elasticsearch 6.x)
[ ] elastic.v5 (for Elasticsearch 5.x)
[ ] elastic.v3 (for Elasticsearch 2.x)
[ ] elastic.v2 (for Elasticsearch 1.x)
Please describe the expected behavior
Because the response content is so big in my scene, it override the request body in terminal screen.
Please describe the actual behavior
Any steps to reproduce the behavior?

You mean, when enabling the trace log? I mean, there might be a way, but tbh: The trace log is for debugging. When debugging, you want to see everything happening on the wire, including the request and the response with all its details. Then you fix the issue, and disable trace logging again.
If you want to have some other kind of requirement for logging, you're probably better of using your own HTTP transport. You can output the HTTP request and response details with net/http/httputil.DumpRequest(Out) and net/http/httputil.DumpResponse and friends.


Add link to other 'lazy' bugfix

oops! published before seeing this!
added it manually. thanks @jpsim ! 💯


Luau crash with constraint debugger "x_as_any_if_x_is_instance_elseif_x_is_table" if x is used as a function

I've taken this code snippet here:
https://github.com/luau-lang/luau/blob/209fd506c9017b9e252408834811c8f5c5529158/tests/TypeInfer.refinements.test.cpp#L1369-L1375
local function f(x)
	--x()
	if typeof(x) == "Instance" and x:IsA("Folder") then
		local foo = x
	elseif typeof(x) == "table" then
		local foo = x
	end
end

Try to remove the -- from x()
if you manage to do that, remain on the same line and type x(), Studio crashes

also x shows up as never, I think this should become a setting, if unknown and never are a reference to any it's sooo confusing, someone explain

This was fixed too

unknown and never are different types, not references to any. unknown and any are very closely related though. unknown is a type that can be ascribed to any value, and any is a type that ignores any type errors it might run into. So, in practice, they look very similar, but the difference is that if you want to take something from the type unknown to a more specific type, you'll have to explicitly cast it, but any will allow you to implicitly cast to a more specific type. never, on the other hand, is the return type of functions that do not return (e.g. the built-in error function). We'll provide more documentation for all of this when we actually ship the new type solver.

unknown and never are different types, not references to any. unknown and any are very closely related though. unknown is a type that can be ascribed to any value, and any is a type that ignores any type errors it might run into. So, in practice, they look very similar, but the difference is that if you want to take something from the type unknown to a more specific type, you'll have to explicitly cast it, but any will allow you to implicitly cast to a more specific type. never, on the other hand, is the return type of functions that do not return (e.g. the built-in error function). We'll provide more documentation for all of this when we actually ship the new type solver.

I saw that the new type solver converts typeof(table.clone()) from  {- -} to {+ +}
Not sure if that's intended. It is gonna break anyone that used table.clone() for {- -} (barely anyone does that probably, other than me)
A cool thing though is that typeof({}) is now an unsealed table.


It is difficult to find a node which is not connected to a link, but on a link

The node looks like connects to the link

However, the node is just on the link

Added OpenLayer style to indicate node-link connection like the following.
Now, it is evident that the node is not connected to the link.


updates to meet match sdk #79

Fix tests that will fail when https://github.com/tablelandnetwork/js-tableland/pull/79 lands.
Add tests for SDK setController

merging this since https://github.com/tablelandnetwork/js-tableland/pull/79 has been merged


Don't subtract fee from balance for incoming Stacks transactions

To reproduce:

Send STX transaction with 0.0025 STX fee to a fresh address
Look at the balance when activity is pending:

@alter-eggo might some of your recent work on balances have resolved this already?

@markmhx don't think so, I haven't touched stx balances

Users are still experiencing this. Incoming transfer with 0.01 fee will result in:

Especially popping up again now with all the testnet faucet use at the moment.


Update sentry-logback to 6.1.4

Updates io.sentry:sentry-logback from 5.7.4 to 6.1.4.
GitHub Release Notes - Version Diff
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "io.sentry", artifactId = "sentry-logback" } ]

labels: library-update, early-semver-major, semver-spec-major, commit-count:1

Superseded by #13.


Check constraint  on create / alter table for named constraints.

Implemented table check constraint for named constraints.

Added named constraint to create table.
Added check constraint to alter table statement.
Added CheckConstraint type.

Tests:
4. Added create table test.
5. Added alter table test.

Coverage decreased (-0.2%) to 83.489% when pulling 401d279ef7e6ef9f6a2313bf6b5f14670d331f3d on meganwoods:master into 04fc3aa9b53c8a935038f6ca8a8f735a3189dd62 on JSQLParser:master.

Looks good. Thx for improving jsqlparser.

No worries.!


Question: Is Castle Windsor still going to be maintained?

Hi,
Just a quick question as the title says: Is this project still going to be actively maintained?

Lately, voluntary (as allways) developers have worked quite a bit on lifting the software:
https://github.com/castleproject/Windsor/pulse/monthly

As @Servox3 mentioned, there has been quite a bit of activity over the last few months with our last release less than 2 weeks ago.
People scratch their own itch, if something doesn't work for you or you'd like something to be better for your use case, please contribute; even a unit test for a scenario or documentation updates helps everyone. There is obviously no vendor here giving you 10 years of support, but Windsor has been going since around 2004.


Adding daily cronjob to run the rake task in publisher

Trello card
Rake task in mainstream publisher
This rake task should publish any missed scheduled editions.

Can you add a bit of randomness into the schedules? - i.e. not on exactly quarter past
Helps distribute the resource usage of jobs.


Improved support for separate out directories

The ceedling project.yml file allows unique global compiler defines for each unit test file. (Referring to build options defines such as gcc's -D on the command line.) When a build option define is given, the current ceedling master branch outputs the .out file to a unique subdirectory under the build/test/out or build/gcov/out directory (or other directory for other tools). The .o files; however, are not output to a subdirectory. Unit tests may successfully run, but gcov coverage fails due to overwritten and mismatched .o, .gcno, and .gcda files.
The changes in this pull request cause the .o files to compile into unique subdirectories for each unit test file only when a special define is given for that unit test file. gcovr and reportgenerator are capable of merging coverage information for each file. We get a combined coverage report showing which lines are covered by running the set of unit test files.
Here is an example defines section in a project.yaml. We have three unit test files to compile our source file(s) with different -D build options.
:defines:
  # When this option is set to true, then the -D<test_name>
  # flag is added to the compiler build options.
  :use_test_definition: true
  :common: &common_defines
    - TEST
    - UNIT_TEST
  :test:
    - *common_defines
  :test_preprocess:
    - *common_defines
  :test_unitTests_defineOption1:
    - *common_defines
    - CUSTOM_DEFINE=1
  :test_unitTests_defineOption2:
    - *common_defines
    - CUSTOM_DEFINE=2
  :test_unitTests_defineOption3:
    - *common_defines
    - CUSTOM_DEFINE=3

Here is an example console output for two source files compiled with three different -D options. The console output shows separate coverage for that file for each unit test. Coverage is not combined on the console while it is combined in the gcovr and reportgenerator outputs. It is not combined on the console because I do not know a way to combine gcov files using gcov tools.
The test name line, such as test_unitTests_defineOption1, is not written to the console for files that were not compiled under a subdirectory.
test_unitTests_defineOption1
sourceOne.c Lines executed:14.15% of 106
sourceOne.c Branches executed:11.11% of 90
sourceOne.c Taken at least once:5.56% of 90
sourceOne.c Calls executed:0.00% of 7

test_unitTests_defineOption2
sourceOne.c Lines executed:8.49% of 106
sourceOne.c Branches executed:6.67% of 90
sourceOne.c Taken at least once:3.33% of 90
sourceOne.c Calls executed:0.00% of 7

test_unitTests_defineOption3
sourceOne.c Lines executed:14.15% of 106
sourceOne.c Branches executed:11.11% of 90
sourceOne.c Taken at least once:5.56% of 90
sourceOne.c Calls executed:0.00% of 7

test_unitTestsA_defineOption1
sourceTwo.c Lines executed:100.00% of 227
sourceTwo.c Branches executed:100.00% of 139
sourceTwo.c Taken at least once:92.81% of 139
sourceTwo.c Calls executed:100.00% of 58

test_unitTestsA_defineOption2
sourceTwo.c Lines executed:27.75% of 227
sourceTwo.c Branches executed:24.46% of 139
sourceTwo.c Taken at least once:12.95% of 139
sourceTwo.c Calls executed:24.14% of 58

test_unitTestsA_defineOption3
sourceTwo.c Lines executed:95.62% of 160
sourceTwo.c Branches executed:95.70% of 93
sourceTwo.c Taken at least once:87.10% of 93
sourceTwo.c Calls executed:92.86% of 42

A different pull request moved defaults from vendor\ceedling\plugins\gcov\config\defaults.yml to vendor\ceedling\plugins\gcov\config\defaults_gcov.rb. After calling ceedling upgrade <project_name> on an existing ceedling project, both defaults.yml and defaults_gcov.rb exist in vendor\ceedling\plugins\gcov\config\. The values in defaults.yml appear to override the values in defaults_gcov.rb, which causes a run time error because I modified defaults_gcov.rb.
How can we modify the ceedling upgrade command to delete an existing defaults.yml?

 I have been looking for a way to generate coverage reports to the same module based on multiple define configurations (different test modules).
It will help me a lot. Hope you can find all the answers and we can see this feature merged as soon as possible!
Thanks!

@aschlicht Idea with separated output directories is great! I'm going to extend it to put other generated files, like mocks, preprocessed headers into separated directories because it should simplify defines dependency tracking, simplify current implementation and also help to build tests parallel.

@mvandervoord,
Is there anything you would like changed in this pull request and / or Cezary's pull request #598? I find these changes to be useful. Members of my project team at work do as well for customizing unit tests within our projects. If you like these changes, then I'd like to see them in a ceedling release because I can say they are vetted and can update our projects to use a formal release.
Thank you,
Aaron

@aschlicht (Aaron) -- thanks for the confirmation. I definitely fall behind on being able to validate some of these features and then they tend to go stale. I appreciate your validation of them!  You are using both PR's mentioned?

@mvandervoord My team at work is using the changes in this PR. I just helped someone modify their project today with these changes, which is why I am revisiting this PR. They also needed a way to force all test outputs to separate directories. I can see making that change with another project.yml option in a future PR.
I have not tested the changes in Cezary's PR; however, I did code review them and they look good to me. I could test them if you'd like me to. Shall I?
Also, please take a look at my comment from May 18. The changes in this PR do not cause an issue when creating a new ceedling project, but there are issues when upgrading an existing project due to defaults.yml remaining after the upgrade. What do you think is the right solution?

Hey guys, any update on this feature @mvandervoord . I'm also needing this update at work, but we don't want to use versions under development. We need to be using the last stable release.
Any plan to integrate that?
Thanks

@mvandervoord,
Other firmware engineers at my company are still finding these separate out directories to be useful. Like beckerzito stated, it is challenging to roll out these changes to everyone when they are not part of the stable ceedling. Is there an aspect of this PR that concerns you or you do not want in your main branch? I could break the changes apart.
One such change is ensuring a gcov data file is paired with a gcov notes file to avoid coverage errors on files without methods. These changes are in gcov.rb.
Thank you,
Aaron

My hope is to roll these changes into the next release. I like this feature a lot (and honestly have wished it was the way it worked for a long time). It's going to be a bit of a challenge, though. This PR is tracking main at the moment. I need to refactor it to track the changes in the release candidate branch (which has a lot of change to support threading, etc)

I am pleased to report that the latest version of Ceedling soon be released (1.0.0 — still known as 0.32 elsewhere) has full support for the idea at the heart of this PR.
Effectively, Ceedling now builds each test executable (corresponding to a single test file) as a mini-project. Each mini-project can have its own defines and compilation/linking flags configured through matchers for test files. Test files can also have their own header search paths by way of a special macro used inside the test file. Each test executable's build generates artifacts to its own subdirectory apart from all others. This means that you can now have different unit testing conditions for the same source file as well as different coverage reporting results.
If you would like to test and run coverage on the same source file under different build conditions, you only need to create multiple test files exercising it and configure the build with the symbols, etc. you want for that test executable build.
See the extensively updated documentation, particularly CeedlingPacket.


[AzureTools][Aspire] Fail to execute the dotnet run command with an error for a .NET Aspire Starter Application with redis checked when the Docker Desktop is Windows container

Regression: Not a regression, this issue also reproduces on VS 17.10.3 with Aspire 8.0.0
Clean machine: Win11 x64 23h2 ENU
VS Version: VS 17.10.3
Aspire Version: 8.0.2
Apply NuGet Feeds
Docker Desktop: 4.32.0
REPRO STEPS:

Make sure the Docker Desktop is Windows container.
Create a new .NET Aspire Starter Application with redis checked -> Run dotnet run in the AppHost.project folder.
Check whether succeeds to execute the command.

Expect:

Succeed to execute the command without any error.
It would be better to make the error message clearer if Aspire does not support Docker Desktop Windows container.

Actual:
Fail to execute the command with an error.

There isn't a Windows container image for the redis:7.2 image, which is what the error is reporting.

By design.


chore: update debian base image to v2.1.3

Reason for Change:

Requirements

[x] squashed commits
[ ] included documentation
[ ] added unit tests and e2e tests (if applicable).

Issue Fixed:

fixes #221
Please answer the following questions with yes/no:

Does this change contain code from or inspired by another project? If so, did you notify the maintainers and provide attribution? no

Special Notes for Reviewers:

/azp run pr-e2e-azure

/azp run pr-e2e-azure


Switching awesome-patched-mode to nerd-fonts

I recently stumbled upon another font-patching project nerd-fonts which looks quite nice and foremost uses the same codepoints as the original fonts. Using this fonts instead of the awesome-terminal-fonts would improve the code in a sustainable way. We just have to test two font-settings and the users would have a nice overview of the available glyphs (in case they want to override one or another).
It still has some issues with the glyph sizes, but once that is cleaned up, I'll give it a chance. This issue is just to remember me (or to inform anybody who wants to get involved).

I found the same thing and tried out a swap the other day. All of the font-awesome icons were narrow and squished, but I was just trying their patched fonts which are about a month old. Might have better luck patching myself. There were also a few glyphs still missing from font-awesome and octicons, but I found suitable replacements for them with what was included.

@rjorgenson I had exactly the same experience with nerd-fonts. Thats why this is a long-term issue. The plan to switch fonts is in #97

I actually didn't have luck with awesome-terminal-fonts before, because I didn't like any of the pre-patched fonts and urxvt does not like the fontconfig fallback approach. nerd-fonts seems like an outright improvement, at least in my case.
The glyph sizes are appropriate in gnome-terminal (seen on the right). However, I think some/most of these are "double-wide glyphs", so urxvt shrinks them to occupy just one cell (seen on the left). I'm not sure how to configure urxvt to handle this properly and I'm out of ideas at this point. ryanoasis/vim-devicons#11 may be relevant.
I'm actually amazed at how annoying and complicated fonts are to deal with in the grand scheme of things, but at least this is something.

It looks like none of powerline9k's modes work with nerd-tools? I'm using a pre-patched nerd-tools font (fontawesome, octicons, pomicons, and implicit devicons), and while awesome-fontconfig comes close, it still has some gaps:

It's pretty clear how to add a new mode to powerline9k, but how can I figure out the corresponding nerd-tools codepoints?

Ah font fun :smirk:
@dritter Yeah unfortunately there are quite a few serious issues still :worried: so I have mostly been focusing on the low hanging fruit to keep the project moving :smile: . I was initially just creating it for another project I had but the more useful others find it the more I try to put into it.
@rjorgenson All of the "pure" mono versions currently have the squished issue/effect. If you can use the double width glyph version (if your terminal allows it) you might get better results
@martinpelikan Yeah the primary driving force behind the "pure" mono versions was to get the glyphs to show up in terminal emulators like urxvt where seems to skip them if they are too wide.
@ariscn see my comment on: https://github.com/ryanoasis/nerd-fonts/issues/40#issuecomment-152863133

@ryanoasis Don't worry, I'll wait till everything is ready :wink:

I tried a few nerd fonts (using Babun with Zsh on Windows via Mintty), but none of them worked properly. Getting these fonts to work with Windows is a big pain.

@DanielGGordon Yeah I have not had a lot of time recently and I never really tested the fonts on Windows fully. Nevertheless your feedback is helpful for me to focus on the pain points :+1:

Meslo LG M for Powerline actually seems to work fine for me - this is a nerd font.
Although all the icons are a bit small.

i tried several nerd fonts and none seem to display the clock:
POWERLEVEL9K_TIME_FORMAT="%D{%H:%M:%S \uE868  %d.%m.%y}"
anyone have the below working?
DejaVu Sans Mono for Powerline Nerd Font Plus Font Awesome Mono Windows Compatible.ttf
all i get is a weird compressed block.

@martinpelikan What unicode symbols are you using in that photo to connect your first and second line? I have something like that but it's not nearly so smooth.

Whats the current status of this?

I will be pulling in a separate font config option for nerd-fonts via @lcorsini's #390 PR!

@bhilburn Could I just send in a pr for it to be on the "next" branch? I'd rather have this sooner than later.

We finally have nerd-fonts support!

The problem is for windows users - I'm trying to use nerd fonts with the new Ubuntu For Windows terminal. A lot of the icons look small - and you have to use monospace.

The problem is for windows users - I'm trying to use nerd fonts with the new Ubuntu For Windows terminal. A lot of the icons look small - and you have to use monospace.

@DanielGGordon Yeah the monospace ones will have to be small to maintain scale to fit as a single-width glyph. As for Windows and non-mono fonts... I don't know too much on what is possible so I'd have to get back to you on that!

@DanielGGordon same issue


Incorrectly accepts invalid LabeledStatement  (ES2015)

If I understand the spec correctly (§13.13) , the following statements should result in a syntax errors:
a: class abc {}
b: let x = 42;
c: function* bar() {}

Grammar:
LabelledStatement:
    LabelIdentifier : LabelledItem

LabelledItem :
  Statement
  FunctionDeclaration

let/const declarations, generation functions and class declarations are neither Statements nor FunctionDeclarations.
FWIW, most other parser seem to be behave the same way. Only shift and traceur are throwing errors. This makes me wonder whether this is an intentional deviation from the spec for compatibility reasons?
http://astexplorer.net/#/E1wX9IZ5Z3

Interesting. At least 3rd one gets parsed without error in FF & Chrome.

This makes me wonder whether this is an intentional deviation from the spec for compatibility reasons?

I don't think so, but it's an easy mistake to make -- initially in ES<6, all statement-like things could follow a label, and it requires a rather close reading of spec to notice that that's no longer the case. Thanks for pointing this out!

Oh, and 13.1.1 also disallows a: function functionDeclartion() {} (early error). Happy to take a stab at this, if you didn't get to it first!

@fkling Instead, it's allowed via B.3.2. I believe we should choose the way that preserves web compat (as we do for many other grammar rules).

@RReverser It's allowed via B.3.2 only outside strict mode.

@michaelficarra Good point, thanks!


Dataset format example

Newbies here, I'm not sure what exactly to put in here?
{
 "input": "[..]",
 "output": "[..]"
}

Something like this?
[
  {
    "input": "Who killed Cedric Diggory?",
    "output": "Peter Pettigrew, acting under the orders of Lord Voldemort, during the Triwizard Tournament in Harry Potter and the Goblet of Fire."
  },
  {
    "input": "What are Dementors?",
    "output": "Spectral guards of Azkaban prison, feeding on human happiness and hope, leaving victims with feelings of despair and hopelessness."
  },
  {
    "input": "What is the Order of the Phoenix?",
    "output": "A secret society led by Albus Dumbledore, formed to oppose Lord Voldemort and his Death Eaters."
  },
  {
    "input": "What is the significance of the Marauder's Map?",
    "output": "A magical map revealing Hogwarts' secrets and the location of its occupants, created by James Potter, Sirius Black, Remus Lupin, and Peter Pettigrew during their school years."
  },
  {
    "input": "What is the purpose of the Triwizard Tournament?",
    "output": "A magical competition between three schools of witchcraft and wizardry, testing magical prowess and courage."
  },
  {
    "input": "Who are Harry's closest friends?",
    "output": "Ron Weasley and Hermione Granger, forming the \"Golden Trio\" who face challenges and adventures together."
  },
  {
    "input": "What is the story behind the Chamber of Secrets?",
    "output": "A hidden chamber under Hogwarts, opened by Tom Riddle (Voldemort) in his youth, unleashing a monstrous basilisk."
  },
  {
    "input": "What is the function of the Ministry of Magic?",
    "output": "The governing body of the magical world in Britain, responsible for regulating magic and maintaining secrecy from Muggles (non-magical people)."
  },
  {
    "input": "What are Horcruxes?",
    "output": "Objects imbued with part of a dark wizard's soul, creating immortality by splitting their soul."
  },
  {
    "input": "What is the prophecy about Harry and the Elder Wand?",
    "output": "The Elder Wand, one of the Deathly Hallows, will only obey a master who has conquered the previous owner, potentially influencing the choice of its wielder."
  }
]

My apologies for not responding earlier.  Yes, your example is correct.  Instruction datasets usually have some question or instruction as the input and an expected response as the output.


Add position() method to mdToastPreset.

Adds a simple method to mdToastPreset.
Resolves #3882.

@tom5760 thanks mate!


DZ2: More pinentry fixes

@keybase/react-hackers @cecileboucheron

[x] Wrong spacings around the passphrase field, around the top sentence and around the bottom button. Should follow the spacing rules on this sheet (first popup): https://zpl.io/Z2bBA6P
[x] Wrong font on top sentence: should be Lato.
[x] Top sentence should be centered, and left/right paddings around should be 30px.
[ ] Copy should say "Enter your passphrase to unlock the secret key for Work Computer."
[ ] Name of device should not have any quotes around and be Semibold italic, see rules at the end of this board: https://zpl.io/Z1bvOTg
[x] Color of placeholder text should be black10 (Black 10%)
[x] Top Keybase logo is now 24x24, asset can be found here in 1x and 2: https://zpl.io/Z2p7znWx.
[x] Continue button should be disabled by default (styling here: https://zpl.io/2rqNgg) and get back to enabled after user starts typing.

I'll open a new JIRA story for the text copy, since it comes from the CORE and we'll need more design work too (there are different strings for different situations).

:+1:

New story for copy: DESKTOP-622

Looking good!
I forgot 2 or 3 little things in the above list:
• Color of the checkbox label should be the usual black75 (unless it's disabled, in which case the box borders should be black10):

• Color of the bottom border on the input should be black10 when not selected (now it looks like a darker grey)

• my own username (here, cjb) should also be Lato Semibold Italic:

@cecileboucheron Both fixed, take another look:

(The text copy isn't fixed because we're going to do that in a different story.)

Looks good! Thanks!
On Thu, Mar 3, 2016 at 4:37 PM Chris Ball<EMAIL_ADDRESS>wrote:

(The text copy isn't fixed because we're going to do that in a different
story.)
—
Reply to this email directly or view it on GitHub
https://github.com/keybase/client/pull/2207#issuecomment-191974939.


[feat] support quantified path patterns

In Neo4j 5.9, QPP is introduced, one of the main features is quantified path patterns ( among others :) ) https://neo4j.com/docs/cypher-manual/current/patterns/reference/#quantified-path-patterns
Eg:
MATCH path=((x:A)-[:R]->(z:B WHERE z.h > 2)){1..3}

Potential cypher-dsl usage as for variable length relationships :
Cypher.path().definedBy(...).min().max()

First I'm gonna update the parser being used (next week).
This feature: Not before summer break.

I sure do hope so. :D

FWIW I did not forget about this, but I do find it quite hard to come up with a good builder for those.

The Cypher syntax is intimidating at the first glance, but I can imagine the usecases already :)

Any update on this?


Gh-2965: Update sketches

Related Issue

Resolve #2965

A note about the getHistoricSerialisationPairs: I created these on develop locally before moving the changes to this branch. This confirms the serialised versions of the sketches from the yahoo datasketches are compatible with the new Apache datasketches dependency.


Changing video resolutions using ffmpeg

How do I achieve the same output as this command using ffmpeg does :
ffmpeg -i sample.mp4 -an -c:v libx264 -x264opts 'keyint=24:min-keyint=24:no-scenecut' -b:v 1060k -maxrate 1060k -bufsize 530k -vf 'scale=-1:478' video-480.mp4

Any leads plz? I wanna change video resolutions but can find proper doc.

See the examples  for how to pass parameters to explicit filters.  In your case you'll be using something like
.filter('scale', width='-1', height='478')
Also be aware that many encoders need specific multiples/ratios of height and width, so you may need to replace width=-1 with something like width=-2 or width=-4


clusterpedia list resources only return metadat

What would you like to be added?
One listOptions, only return matedata information .
Why is this needed?
When I list a resource I find that it gives me the full amount of resource information.
Example:

But I think sometimes I don't need the full amount of resource information in a list query, just the matedata information. Is it possible to add a query option where the list query only fetches the matedata information for the resource?

Very good questions.
clusterpedia supports returning only metadata，use k8s client-go metadata client


Update sbt-version-policy to 1.2.0

Updates ch.epfl.scala:sbt-version-policy from 1.0.1 to 1.2.0.
GitHub Release Notes - Version Diff
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "ch.epfl.scala", artifactId = "sbt-version-policy" } ]

labels: sbt-plugin-update, semver-minor

Superseded by #32.


Multiple Database Support

Issue Type: Feature Request
Appreciated if you could provide native support for various database like MySQL, Oracle, DB2
Azure Data Studio version: Azure Data Studio 1.8.0 (96e214593190071f0b520439929b218f9fa673de, 2019-06-06T01:37:31.184Z)
OS version: Darwin x64 18.6.0

Thanks for the suggestion @azrull! We're currently tracking adding support for other DBs in separate issues such as #4904 - if you'd like to see others added please open a similar separate issue for each of them so we can track the demand for each request separately.


Timestamp to NSDate mapping added

I'm not sure about method naming, but I found this feature very useful, because a lot of REST APIs use unix timestamps as date transferring format.

Be careful though. Must API return the time in milliseconds. NSTimeInterval represents seconds.
Also I am not sure if EasyMapping should be this opnionated but thats not for me to decide.

Actually this is no matter if it seconds or milliseconds, both cases will be transformed into NSDate. So it's up to you to decide what to use. But I've got your idea, thanks.

It matters cause NSDate method accepts only seconds and if you have milliseconds in input you should convert it to seconds first. So there should be some mark (separate method or additional argument) in this method to indicate are there seconds on input or milliseconds.

Oh, I see what you saying. Let me update the pull request. I think I'll add the enum argument which will represent seconds/milliseconds timestamp format. Thanks for feedback.

Please, see second commit. I've fixed it there and moved to EKTransformer.

This seems to be quite complicated implementation for quite simple use case. Adding enum and three new methods to support timestamp conversion is an overkill to me. You could simply wrap this mapping in value blocks, and extract these blocks to helper class. And even more, you could make these methods part of category on EKObjectMapping, that simply calls mapKeyPath:toProperty:withValueBlock: method.
Also, i agree with @florianbuerger, framework should try not to be opinionated. Should we use seconds or milliseconds? Should we use 1 January 1970, GMT as an anchor or reference date - 1 January 2001, GMT?
Thanks for your time, but i think we will not add this functionality to framework for now.

BTW, there's now new class in Foundation called NSDateComponentsFormatter, that allows converting from NSTimeInterval to NSString - this is available on iOS 8 and OS X 10.10.

@DenHeadless  Maybe you are right. But if we look at EKTransformer that is used now we can see that it is also opinionated - locale, timezone are hardcoded. And so I've never used provided method for date mapping as it is. That's why I think it should be refactored. I will try to do that and good start, I think, will be to use NSValueTransformer as a base class for it. Timestamp transformation could be also part of this.
As for NSDateComponentsFormatter this is cool stuff, but it serves, in my opinion, another goals.