[WIP] WPT sharding

Run only a small subset of WPT tests in CI. Preparation for WPT sharding.

Done in https://github.com/GoogleChromeLabs/chromium-bidi/pull/1682


fix: add lastRelease and commits

:tada: This PR is included in version 1.0.0-alpha.9 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Add codecov actions wq

Update cov

Codecov Report

Merging #34 (ed13e01) into main (b75a2a6) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main      #34      +/-   ##
==========================================
+ Coverage   64.63%   64.64%   +0.01%
==========================================
  Files         295      296       +1
  Lines       43838    43840       +2
==========================================
+ Hits        28335    28342       +7
+ Misses      13219    13216       -3
+ Partials     2284     2282       -2

Flag
Coverage Δ

*Carryforward flag

kind-e2e-tests
51.09% <ø> (ø)

Carriedforward from b75a2a6

unit-tests
44.31% <100.00%> (+0.01%)
:arrow_up:

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files
Coverage Δ

pkg/cov.go
100.00% <100.00%> (ø)

pkg/controller/ipam/antrea_ipam_controller.go
76.41% <0.00%> (-2.63%)
:arrow_down:

pkg/agent/cniserver/ipam/antrea_ipam.go
74.02% <0.00%> (-1.74%)
:arrow_down:

pkg/agent/openflow/pipeline.go
73.12% <0.00%> (+0.04%)
:arrow_up:

pkg/ipam/poolallocator/allocator.go
49.15% <0.00%> (+1.92%)
:arrow_up:

pkg/controller/grouping/controller.go
67.10% <0.00%> (+1.97%)
:arrow_up:

pkg/apiserver/handlers/endpoint/handler.go
69.56% <0.00%> (+13.04%)
:arrow_up:


Update sample script

This fixes the occasional "Get-MgBetaApplication : Cannot bind argument to parameter 'ApplicationId' because it is an empty string." on some apps.

@kenwith
Can you review the proposed changes?
Important: When the changes are ready for publication, adding a #sign-off comment is the best way to signal that the PR is ready for the review team to merge.
#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

@occasionallydennis - would you please make the changes mentioned above by Arpad and we can get this merged. Thank you for the PR.


Regarding fix for creating PKCS12 file with FIPS provider.

Hi team,
We are waiting for the fix - https://github.com/openssl/openssl/issues/20072
Could you please update the release date.
Our expectation is - with this fix PKCS12_create API will work in FIPS mode.

#24577 is just merged to master branch. Will be released in some future.

This will be included in the 3.4.0 release that will be done in October 2024.


Thorium eating up to 100% CPU on their (thorium.rocks) home page. on not so fast computers

Because you use "Canvas2D Shadow Demo" on it.
Can it be moved to another place, available by the click on it ?
I come there to that page, using Thorium build for XP using "middle notebook" level of computer power. Without script blockers etc.

Also here:

@IDA-RE-things Yeah, I need to remove some .js, and compress some images. The site is pretty heavy considering it is simple.


Issue with staking when CPU/NET is overused

Lately I've been experiencing an over use of CPU which now renders me unable to stake more, since this transaction requires a small amount of CPU/NET.
I read in another thread with the same title as this one, that his work around was to use another account and delegate CPU to it from there. My problem is i don't know how to use the CPU that is delegated to the account. Can anyone point me in the right direction?

As the network is congested, you may need to stake more CPU (maybe more than 10 EOS) for your account in order to pass the transaction itself.

Yes, it took me a while but I've figured it out... kinda sucks i'll just stick to Eth


Initial export job worker.

Description
Adding the initial export job worker code. The job worker is hosted as a background service and periodically checks to see if there is a new export job available.
To support allowing multiple workers, the logic to determine how many new jobs are available is done the stored procedure. It also handles resuming stale job in case the job process terminates unexpectedly and did not finish processing the job correctly,
Related issues
Addresses #346. Work item: AB#68716
Testing
Unit tests, integration tests, and manual tests were executed.

Adding the initial export job worker code.

General comment: might want to clarify what you mean by"initial". What is out of scope, incomplete etc. to set expectations.

With the new iteration of the PR, I have:

Updated the stored procedure to query and acquire job as suggested.
Updated the CosmosDbFhirStorageTestsFixture to use IAsyncLifetime as well as introducing a semaphore for collection initialization. With Cosmos DB emulator, it throws error if multiple collections are being initialized at the same time.
Removed the IExportJobTaskFactory and replaced it with the built-in IoC Factory pattern.


Fx files not saving, receive error

Hi, I noticed something regarding files saved from Fx directory.  For example I use the Nighttab extension, and when saving the configuration, it suppose to go to a directory on my system.  Also, if I'm printing a page and saving the output as a PDF file, it is also suppose to go to the target directory.
In both these instances, these files are sent over to the aria2 extension and processing fails.  I receive the message:
"An error occurred when adding a file to local host".
I tried adding "localhost" and "<IP_ADDRESS>" to the exclude host list, but that didn't work.  Nighttab exports a .json file, so I was able to specify that to get around the issue, but there may be times when I want to download .json or probably more often .pdf files from other sites, so that probably isn't the best solution.
Any ideas?  Is there another another way of telling aria2 to ignore files that are local?  Thanks much!
P.S.  I also noticed that I can't enter a comma to separate multiple entries on any of the exclude lists as shown in the examples.

Hi @gbcox ,
I have fixed the input problem for excluded options in the linked Pull Request above.
When you are viewing a PDF in Firefox, it uses pdf.js and if you save it, it will use the blob protocol.
When you are viewing local file and you try to download it, it will use the file protocol.
When you are exporting nightTab data, it uses data protocol.

Hi, thank you so much for the quick response.  I tested and it appears to be working.  However, I noticed for nighttab, I needed specifically exclude "data" in the protocols.  Is that what you intended?  I "printed" a pdf to file and it saved correctly without specifically excluding the "blob" protocol.  I haven't saved anything with the "file" protocol.
I can certainly exclude the "data" protocol in the config, but can't think of a valid situation where that would be used for aria2.  Not many people are going to know that it isn't compatible with aria2.  Maybe it would be a better idea to just automatically exclude protocols that aren't compatible.  I would view the exclude protocols option to be used for some reason if people wanted to exclude a protocol that was compatible.   Does that make sense?
Anyway, thanks again for your quick response.  Much appreciated.

You're welcome and sorry for the bug.
Yeah, I can add to the protocols ignore list data, file and blob. I will do that next week.

No worries.  Thanks again for the quick response!

The following protocols data, file & blob are now excluded in 4.8.0


snakemake: 7.14.2 -> 7.25.3

Description of changes
Updating to a new release.
Fix #213024
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[x] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
23.05 Release Notes (or backporting 22.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 230524 run on x86_64-linux 1

10 packages built:

python310Packages.reretry
python310Packages.reretry.dist
python310Packages.throttler
python310Packages.throttler.dist
python311Packages.reretry
python311Packages.reretry.dist
python311Packages.throttler
python311Packages.throttler.dist
snakemake
snakemake.dist


load_searchers documentation is unclear

load_searchers is used in the example, and documented as:

Creates a new generation of searchers after a change of the set of searchable indexes.
This needs to be called when a new segment has been published or after a merge.

The documentation is unclear to me, since I don't know what "generation of searchers" is. I'm also not using segments or merging directly, but only higher-level commit().
But what's most unclear to me is whether it has to be called after commit(), once ever, or whether it has to be called every time when starting search, or every time when starting application.
I'm implementing indexing and searching in separate executables, so I'm also wondering whether this is needed only to update in-memory state of the object, and therefore unnecessary when searching is done by another application only.

The documentation is indeed quite unclear.
So ... regarding your question...  As long as you hold this handle, you are guaranteed that the data is available.
If your search request is complicated and actually requires running more than one request, as long as you hold the same searcher the whole time, you are guaranteed to see a consistent view of your index.
(e.g. a document will not disappear in between to queries).
The index holds a pool of such searcher...
Calling load_searcher checks if the last commit is different, create searcher for the new commit. Add these new searchers in the pool. Also the update appears all at once : you are guaranteed that if you call searcher in a row, the commit associated to the second call to searcher is always fresher than the one for the first call.
We'll eventually make it an internal API and have an IndexReader in charge of loading searchers for you, base on a given policy.
The default policy will do what 95% of users want : the freshest available index automatically.
The implementation will consist in watching meta.json and calling load_searchers() whenever it changes. You probably want to implement somethign like that too.
One more thing : in tantivy 0.6 there is a race condition that can happen when using load_searcher() from a different process. load_searcher() then just returns an Error and retrying is ok.
In master, and in the upcoming tantivy 0.7 the bug is fixed.
The bug technically has never been triggered, so I assume it is low probability, but it exists.

Thanks. That's much clearer.

Leaving the ticket open to make sure the documentation is updated.


Should knownPeripherals() return bondedDevices on Android?

The behavior of knownPeripherals are different on Android and iOS.
In iOS, knownPeripherals means known by System (OS)
In Android, knownPeripheral means known by lib. (Lib should scan first, and keep the scan results)
However, if some peripheral was bonded  and connect to Android first, there are no chance for Lib to scan this peripheral. (Because the connected peripheral cannot scanned)
Therefore, knownPeripheral()'s return value should be equal to bondedDevice() on Android. (Known by OS, not just Lib)
What do you think?

https://github.com/Polidea/FlutterBleLib/issues/428


Simple Anomaly Detection tick script

Hello,
I try to implement simple tick script to compare today's value with the previous day. But have no idea what is wrong.
Details:

Kapacitor RPM version: kapacitor-1.2.0-1.x86_64
Check if InfluxDB query is working

> SELECT mean(value), stddev(value) FROM collectd.autogen.cpu_value WHERE "type_instance" = 'idle' GROUP BY host fill(0)
name: cpu_value
tags: host=kapacitor.novalocal
time mean                  stddev
---- ----                  ------
0    6.831070378727789e+07 8.382580047649062e+06

Kapacitor show:

ID: cpu_value_anomaly_simple
Error:
Template:
Type: batch
Status: enabled
Executing: true
Created: 20 Apr 17 07:00 UTC
Modified: 20 Apr 17 11:07 UTC
LastEnabled: 20 Apr 17 11:07 UTC
Databases Retention Policies: ["collectd"."autogen"]
TICKscript:
// Call it like kapacitor define cpu_value_anomaly_simple -type batch -tick cpu_value_anomaly_simple.tick -dbrp collectd.autogen

// get the yesterday data
var yesterday = batch
    |query('''SELECT mean(value), stddev(value) FROM collectd.autogen.cpu_value WHERE "type_instance" = 'idle' GROUP BY host fill(0)''')
        .offset(1d)
        .period(1h)
        .every(1m)
        .align()
    |shift(1d)

// get current data
var today = batch
    |query('''SELECT mean(value) FROM collectd.autogen.cpu_value WHERE "type_instance" = 'idle' GROUP BY host fill(0)''')
        .period(1h)
        .every(1m)
        .align()

// alert when todays data more or less than 3.5 stddev from yesterday
yesterday
    |join(today)
        .as('yesterday', 'today')
    |alert()
        .info(lambda: "today.mean" > "yesterday.mean")
        .warn(lambda: "today.mean" < "yesterday.mean")
        .crit(lambda: abs("today.mean" - "yesterday.mean") > (3.5 * "yesterday.stddev"))
        .log('/var/log/kapacitor/cpu_value_anomaly_simple_alerts.log')

DOT:
digraph cpu_value_anomaly_simple {
graph [throughput="0.00 batches/s"];

query3 [avg_exec_time_ns="10.628621ms" batches_queried="0" points_queried="0" query_errors="0" ];
query3 -> join5 [processed="0"];

query1 [avg_exec_time_ns="12.955343ms" batches_queried="0" points_queried="0" query_errors="0" ];
query1 -> shift2 [processed="0"];

shift2 [avg_exec_time_ns="0s" ];
shift2 -> join5 [processed="0"];

join5 [avg_exec_time_ns="0s" ];
join5 -> alert6 [processed="0"];

alert6 [alerts_triggered="0" avg_exec_time_ns="0s" crits_triggered="0" infos_triggered="0" oks_triggered="0" warns_triggered="0" ];
}

Log output

tail -f /var/log/kapacitor/cpu_value_anomaly_simple_alerts.log
tail: cannot open ‘/var/log/kapacitor/cpu_value_anomaly_simple_alerts.log’ for reading: No such file or directory
tail: no files remaining

@oldulov Your TICKscript looks good. We try to reserve GitHub Issues for actionable bug reports or feature requests. Please send general questions to the community board at community.influxdata.com. From your output it looks like the script hasn't run any queries yet, can you share the show output after several minutes of operation on the community site?


Injection manager problems with multiple apps and dynamic features

Environment Details

Helidon Version: 2.4.0
Helidon MP
JDK version: 11
OS: Mac OS

Problem Description
When defining multiple Application subclasses and a DynamicFeature, an exception is reported in HelidonHK2InjectionManagerFactory because the parent injection manager's type is not recognized.
IllegalState Invalid parent injection manager

Thanks to Milan Kuchtiak for the test showing the problem.

Fixed in 2.4.1.

PR #3754
PR #3755


Upgrade GOV.UK Frontend to 5.4.0

GOV.UK Frontend should be upgraded from 5.1.0 to 5.4.0.

Done in #94.


Generate from scratch

can you pls add an example for Generate from scratch method . i'm getting false for FlutterWalletCard.addPassKit(samplefile) and don't know where is the issue

Hey, sure. Will add it today by the EOD :)
@Salam-pc

Steps to generate signatures/keys/certificates from scratch:

Create Signer class
For that you will need to have two files which can be created and exported using Apple's KeyChain or OpenSSL.

  final signer = Signer(
    wwdrPem: wwdrPem, // this is File class that represents wwdrPem key
    certificateP12: certP12, // this is File class representing .p12 key
    directory: certificates, // output directory where signer should create signature in the future
  );

Generate required certificates (cert + key)
For that you need to call two signer methods:

await Future.wait([
    signer.generateKey(),
     signer.generateCertificate(), // there is also a possibility to specify password key (argument)
]);

Generate signature
Generate signature that will sign all the generated files

Example manifest file (it is containing sha1 hashes of the files to verify integrity)
https://github.com/WebEferen/flutter_wallet_card/blob/master/test/fixtures/example_passkit/manifest.json
For manifest generation you can also use Creators helper (and it's create manifest method):
https://github.com/WebEferen/flutter_wallet_card/blob/0b65916ba0d22844bd6cee7ea5e0b825384b6673/lib/core/creators.dart#L21
final manifest = File(....);
await signer.generateSignature(manifest: manifest);

With generated signature, instantiate Passkit class:

final outputDirectory = Directory(...);
final passkit = Passkit(directoryName: outputDirectory.path);

final generated = await passkit.generate(
          id: 'some_id',
          pkpass: pkpass, // You should also have pkpass file already generated
          directory: outputDirectory,
          signature: signaturePath, // Path to the previously generated signature
          manifest: manifestPath, // Path to the previously generated manifest
          passkitPass: passkitPath, // Path to the passkit file
        );

For reference you can follow the test suite (to see how it works under the hood):

https://github.com/WebEferen/flutter_wallet_card/blob/master/test/passkit_test.dart
https://github.com/WebEferen/flutter_wallet_card/blob/master/test/signer_test.dart
https://github.com/WebEferen/flutter_wallet_card/blob/master/test/creators_test.dart

Best,
Mike.


YARN-11218. [Federation] Add getActivities, getBulkActivities REST APIs for Router.

JIRA: YARN-11218. [Federation] Add getActivities, getBulkActivities REST APIs for Router.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 38s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

-1 :x:
test4tests
0m  0s

The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ trunk Compile Tests _

+0 :ok:
mvndep
15m 19s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
27m 51s

trunk passed

+1 :green_heart:
compile
4m 14s

trunk passed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04

+1 :green_heart:
compile
3m 31s

trunk passed with JDK Private Build-1.8.0_352-8u352-ga-1~20.04-b08

+1 :green_heart:
checkstyle
1m 14s

trunk passed

+1 :green_heart:
mvnsite
1m 39s

trunk passed

-1 :x:
javadoc
0m 57s
/branch-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdkUbuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04.txt
hadoop-yarn-server-resourcemanager in trunk failed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04.

+1 :green_heart:
javadoc
1m 13s

trunk passed with JDK Private Build-1.8.0_352-8u352-ga-1~20.04-b08

+1 :green_heart:
spotbugs
2m 57s

trunk passed

+1 :green_heart:
shadedclient
19m 57s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 29s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
1m 16s

the patch passed

+1 :green_heart:
compile
3m 43s

the patch passed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04

+1 :green_heart:
javac
3m 43s

the patch passed

+1 :green_heart:
compile
3m 15s

the patch passed with JDK Private Build-1.8.0_352-8u352-ga-1~20.04-b08

+1 :green_heart:
javac
3m 15s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
1m  6s

the patch passed

+1 :green_heart:
mvnsite
1m 23s

the patch passed

-1 :x:
javadoc
0m 40s
/patch-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdkUbuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04.txt
hadoop-yarn-server-resourcemanager in the patch failed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04.

+1 :green_heart:
javadoc
1m  1s

the patch passed with JDK Private Build-1.8.0_352-8u352-ga-1~20.04-b08

+1 :green_heart:
spotbugs
2m 56s

the patch passed

+1 :green_heart:
shadedclient
20m 57s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
98m 27s

hadoop-yarn-server-resourcemanager in the patch passed.

+1 :green_heart:
unit
0m 33s

hadoop-yarn-server-router in the patch passed.

+1 :green_heart:
asflicense
0m 36s

The patch does not generate ASF License warnings.

219m  7s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5284/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/5284

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux c0170fb23f8c 4.15.0-200-generic #211-Ubuntu SMP Thu Nov 24 18:16:04 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 8d7f60048c76fa19f21d38e422c3866e87e74211

Default Java
Private Build-1.8.0_352-8u352-ga-1~20.04-b08

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_352-8u352-ga-1~20.04-b08

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5284/1/testReport/

Max. process+thread count
931 (vs. ulimit of 5500)

modules
C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5284/1/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 38s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 2 new or modified test files.

_ trunk Compile Tests _

+0 :ok:
mvndep
15m 21s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
26m 41s

trunk passed

+1 :green_heart:
compile
3m 57s

trunk passed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04

+1 :green_heart:
compile
3m 29s

trunk passed with JDK Private Build-1.8.0_352-8u352-ga-1~20.04-b08

+1 :green_heart:
checkstyle
1m 13s

trunk passed

+1 :green_heart:
mvnsite
1m 35s

trunk passed

-1 :x:
javadoc
0m 57s
/branch-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdkUbuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04.txt
hadoop-yarn-server-resourcemanager in trunk failed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04.

+1 :green_heart:
javadoc
1m 16s

trunk passed with JDK Private Build-1.8.0_352-8u352-ga-1~20.04-b08

+1 :green_heart:
spotbugs
2m 55s

trunk passed

+1 :green_heart:
shadedclient
20m 14s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 28s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
1m 20s

the patch passed

+1 :green_heart:
compile
4m  5s

the patch passed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04

+1 :green_heart:
javac
4m  5s

the patch passed

+1 :green_heart:
compile
3m 23s

the patch passed with JDK Private Build-1.8.0_352-8u352-ga-1~20.04-b08

+1 :green_heart:
javac
3m 23s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
1m  2s

the patch passed

+1 :green_heart:
mvnsite
1m 26s

the patch passed

-1 :x:
javadoc
0m 42s
/patch-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdkUbuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04.txt
hadoop-yarn-server-resourcemanager in the patch failed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04.

+1 :green_heart:
javadoc
1m  0s

the patch passed with JDK Private Build-1.8.0_352-8u352-ga-1~20.04-b08

+1 :green_heart:
spotbugs
2m 59s

the patch passed

+1 :green_heart:
shadedclient
20m 37s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
98m 31s

hadoop-yarn-server-resourcemanager in the patch passed.

+1 :green_heart:
unit
0m 33s

hadoop-yarn-server-router in the patch passed.

+1 :green_heart:
asflicense
0m 37s

The patch does not generate ASF License warnings.

218m 10s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5284/2/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/5284

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux e4363bae6db5 4.15.0-200-generic #211-Ubuntu SMP Thu Nov 24 18:16:04 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 8249dc628f16f9a230a96efc468976c8216006d1

Default Java
Private Build-1.8.0_352-8u352-ga-1~20.04-b08

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_352-8u352-ga-1~20.04-b08

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5284/2/testReport/

Max. process+thread count
965 (vs. ulimit of 5500)

modules
C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5284/2/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 34s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 3 new or modified test files.

_ trunk Compile Tests _

+0 :ok:
mvndep
16m 14s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
25m 53s

trunk passed

+1 :green_heart:
compile
3m 50s

trunk passed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04

+1 :green_heart:
compile
3m 18s

trunk passed with JDK Private Build-1.8.0_352-8u352-ga-1~20.04-b08

+1 :green_heart:
checkstyle
1m 14s

trunk passed

+1 :green_heart:
mvnsite
1m 37s

trunk passed

-1 :x:
javadoc
0m 57s
/branch-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdkUbuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04.txt
hadoop-yarn-server-resourcemanager in trunk failed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04.

+1 :green_heart:
javadoc
1m 12s

trunk passed with JDK Private Build-1.8.0_352-8u352-ga-1~20.04-b08

+1 :green_heart:
spotbugs
2m 59s

trunk passed

+1 :green_heart:
shadedclient
19m 53s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 28s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
1m 15s

the patch passed

+1 :green_heart:
compile
3m 42s

the patch passed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04

+1 :green_heart:
javac
3m 42s

the patch passed

+1 :green_heart:
compile
3m 13s

the patch passed with JDK Private Build-1.8.0_352-8u352-ga-1~20.04-b08

+1 :green_heart:
javac
3m 13s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
1m  3s

the patch passed

+1 :green_heart:
mvnsite
1m 20s

the patch passed

-1 :x:
javadoc
0m 41s
/patch-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdkUbuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04.txt
hadoop-yarn-server-resourcemanager in the patch failed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04.

+1 :green_heart:
javadoc
1m  1s

the patch passed with JDK Private Build-1.8.0_352-8u352-ga-1~20.04-b08

+1 :green_heart:
spotbugs
2m 52s

the patch passed

+1 :green_heart:
shadedclient
20m  6s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
98m 50s

hadoop-yarn-server-resourcemanager in the patch passed.

+1 :green_heart:
unit
0m 33s

hadoop-yarn-server-router in the patch passed.

+1 :green_heart:
asflicense
0m 37s

The patch does not generate ASF License warnings.

216m 10s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5284/3/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/5284

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux 5b317b4d3ad7 4.15.0-200-generic #211-Ubuntu SMP Thu Nov 24 18:16:04 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 6ae1a9c2dcbae4d3aae191c0925aa273eb49f508

Default Java
Private Build-1.8.0_352-8u352-ga-1~20.04-b08

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_352-8u352-ga-1~20.04-b08

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5284/3/testReport/

Max. process+thread count
959 (vs. ulimit of 5500)

modules
C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5284/3/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

@goiri Can you help review this PR? Thank you very much!

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 35s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 3 new or modified test files.

_ trunk Compile Tests _

+0 :ok:
mvndep
16m  0s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
30m 55s

trunk passed

+1 :green_heart:
compile
3m 51s

trunk passed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04

+1 :green_heart:
compile
3m 19s

trunk passed with JDK Private Build-1.8.0_352-8u352-ga-1~20.04-b08

+1 :green_heart:
checkstyle
1m 15s

trunk passed

+1 :green_heart:
mvnsite
1m 41s

trunk passed

-1 :x:
javadoc
0m 56s
/branch-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdkUbuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04.txt
hadoop-yarn-server-resourcemanager in trunk failed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04.

+1 :green_heart:
javadoc
1m 14s

trunk passed with JDK Private Build-1.8.0_352-8u352-ga-1~20.04-b08

+1 :green_heart:
spotbugs
2m 59s

trunk passed

+1 :green_heart:
shadedclient
23m 10s

branch has no errors when building and testing our client artifacts.

-0 :warning:
patch
23m 29s

Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 29s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
1m 29s

the patch passed

+1 :green_heart:
compile
3m 42s

the patch passed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04

+1 :green_heart:
javac
3m 42s

the patch passed

+1 :green_heart:
compile
3m 10s

the patch passed with JDK Private Build-1.8.0_352-8u352-ga-1~20.04-b08

+1 :green_heart:
javac
3m 10s

the patch passed

-1 :x:
blanks
0m  0s
/blanks-eol.txt
The patch has 6 line(s) that end in blanks. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply

+1 :green_heart:
checkstyle
1m  1s

the patch passed

+1 :green_heart:
mvnsite
1m 22s

the patch passed

-1 :x:
javadoc
0m 41s
/patch-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdkUbuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04.txt
hadoop-yarn-server-resourcemanager in the patch failed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04.

+1 :green_heart:
javadoc
1m  2s

the patch passed with JDK Private Build-1.8.0_352-8u352-ga-1~20.04-b08

+1 :green_heart:
spotbugs
2m 55s

the patch passed

+1 :green_heart:
shadedclient
23m  0s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
98m 34s

hadoop-yarn-server-resourcemanager in the patch passed.

+1 :green_heart:
unit
0m 30s

hadoop-yarn-server-router in the patch passed.

+1 :green_heart:
asflicense
0m 35s

The patch does not generate ASF License warnings.

227m 33s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5284/4/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/5284

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux 360197549a27 4.15.0-200-generic #211-Ubuntu SMP Thu Nov 24 18:16:04 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 213b9ae791e074624006ab55cec82e6ef0fcfa8c

Default Java
Private Build-1.8.0_352-8u352-ga-1~20.04-b08

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_352-8u352-ga-1~20.04-b08

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5284/4/testReport/

Max. process+thread count
950 (vs. ulimit of 5500)

modules
C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5284/4/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 37s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 3 new or modified test files.

_ trunk Compile Tests _

+0 :ok:
mvndep
15m 31s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
31m 40s

trunk passed

+1 :green_heart:
compile
3m 55s

trunk passed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04

+1 :green_heart:
compile
3m 27s

trunk passed with JDK Private Build-1.8.0_352-8u352-ga-1~20.04-b08

+1 :green_heart:
checkstyle
1m 14s

trunk passed

+1 :green_heart:
mvnsite
1m 34s

trunk passed

-1 :x:
javadoc
0m 54s
/branch-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdkUbuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04.txt
hadoop-yarn-server-resourcemanager in trunk failed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04.

+1 :green_heart:
javadoc
1m 12s

trunk passed with JDK Private Build-1.8.0_352-8u352-ga-1~20.04-b08

+1 :green_heart:
spotbugs
2m 57s

trunk passed

+1 :green_heart:
shadedclient
23m 16s

branch has no errors when building and testing our client artifacts.

-0 :warning:
patch
23m 35s

Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 29s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
1m 28s

the patch passed

+1 :green_heart:
compile
3m 52s

the patch passed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04

+1 :green_heart:
javac
3m 52s

the patch passed

+1 :green_heart:
compile
3m 12s

the patch passed with JDK Private Build-1.8.0_352-8u352-ga-1~20.04-b08

+1 :green_heart:
javac
3m 12s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
1m  3s

the patch passed

+1 :green_heart:
mvnsite
1m 23s

the patch passed

-1 :x:
javadoc
0m 40s
/patch-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdkUbuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04.txt
hadoop-yarn-server-resourcemanager in the patch failed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04.

+1 :green_heart:
javadoc
1m  1s

the patch passed with JDK Private Build-1.8.0_352-8u352-ga-1~20.04-b08

+1 :green_heart:
spotbugs
2m 59s

the patch passed

+1 :green_heart:
shadedclient
23m 15s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
99m  5s

hadoop-yarn-server-resourcemanager in the patch passed.

+1 :green_heart:
unit
0m 31s

hadoop-yarn-server-router in the patch passed.

+1 :green_heart:
asflicense
0m 38s

The patch does not generate ASF License warnings.

228m 45s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5284/5/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/5284

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux ea557f6463ff 4.15.0-200-generic #211-Ubuntu SMP Thu Nov 24 18:16:04 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / aa230d2fc3ebd0118f41704551fc6b0e7fecfecf

Default Java
Private Build-1.8.0_352-8u352-ga-1~20.04-b08

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_352-8u352-ga-1~20.04-b08

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5284/5/testReport/

Max. process+thread count
949 (vs. ulimit of 5500)

modules
C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5284/5/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 47s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  1s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 3 new or modified test files.

_ trunk Compile Tests _

+0 :ok:
mvndep
15m  5s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
30m 44s

trunk passed

+1 :green_heart:
compile
3m 54s

trunk passed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04

+1 :green_heart:
compile
3m 20s

trunk passed with JDK Private Build-1.8.0_352-8u352-ga-1~20.04-b08

+1 :green_heart:
checkstyle
1m 14s

trunk passed

+1 :green_heart:
mvnsite
1m 38s

trunk passed

-1 :x:
javadoc
0m 55s
/branch-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdkUbuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04.txt
hadoop-yarn-server-resourcemanager in trunk failed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04.

+1 :green_heart:
javadoc
1m 15s

trunk passed with JDK Private Build-1.8.0_352-8u352-ga-1~20.04-b08

+1 :green_heart:
spotbugs
2m 54s

trunk passed

+1 :green_heart:
shadedclient
23m 26s

branch has no errors when building and testing our client artifacts.

-0 :warning:
patch
23m 45s

Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 28s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
1m 31s

the patch passed

+1 :green_heart:
compile
3m 42s

the patch passed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04

+1 :green_heart:
javac
3m 42s

the patch passed

+1 :green_heart:
compile
3m 11s

the patch passed with JDK Private Build-1.8.0_352-8u352-ga-1~20.04-b08

+1 :green_heart:
javac
3m 11s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
1m  3s

the patch passed

+1 :green_heart:
mvnsite
1m 21s

the patch passed

-1 :x:
javadoc
0m 41s
/patch-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdkUbuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04.txt
hadoop-yarn-server-resourcemanager in the patch failed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04.

+1 :green_heart:
javadoc
1m  1s

the patch passed with JDK Private Build-1.8.0_352-8u352-ga-1~20.04-b08

+1 :green_heart:
spotbugs
2m 50s

the patch passed

+1 :green_heart:
shadedclient
23m 24s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
98m 52s

hadoop-yarn-server-resourcemanager in the patch passed.

+1 :green_heart:
unit
0m 32s

hadoop-yarn-server-router in the patch passed.

+1 :green_heart:
asflicense
0m 37s

The patch does not generate ASF License warnings.

227m 43s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5284/6/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/5284

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux 45395afc4591 4.15.0-200-generic #211-Ubuntu SMP Thu Nov 24 18:16:04 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / c913da88c4cedc40e31ed02d81e824597933d747

Default Java
Private Build-1.8.0_352-8u352-ga-1~20.04-b08

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_352-8u352-ga-1~20.04-b08

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5284/6/testReport/

Max. process+thread count
966 (vs. ulimit of 5500)

modules
C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5284/6/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 38s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  1s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 3 new or modified test files.

_ trunk Compile Tests _

+0 :ok:
mvndep
15m  8s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
31m 59s

trunk passed

+1 :green_heart:
compile
4m 11s

trunk passed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04

+1 :green_heart:
compile
3m 31s

trunk passed with JDK Private Build-1.8.0_352-8u352-ga-1~20.04-b08

+1 :green_heart:
checkstyle
1m 12s

trunk passed

+1 :green_heart:
mvnsite
1m 43s

trunk passed

-1 :x:
javadoc
0m 54s
/branch-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdkUbuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04.txt
hadoop-yarn-server-resourcemanager in trunk failed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04.

+1 :green_heart:
javadoc
1m 10s

trunk passed with JDK Private Build-1.8.0_352-8u352-ga-1~20.04-b08

+1 :green_heart:
spotbugs
3m  7s

trunk passed

+1 :green_heart:
shadedclient
23m  9s

branch has no errors when building and testing our client artifacts.

-0 :warning:
patch
23m 29s

Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 48s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
1m 30s

the patch passed

+1 :green_heart:
compile
4m  5s

the patch passed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04

+1 :green_heart:
javac
4m  5s

the patch passed

+1 :green_heart:
compile
3m 26s

the patch passed with JDK Private Build-1.8.0_352-8u352-ga-1~20.04-b08

+1 :green_heart:
javac
3m 26s

the patch passed

-1 :x:
blanks
0m  0s
/blanks-eol.txt
The patch has 6 line(s) that end in blanks. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply

+1 :green_heart:
checkstyle
1m  4s

the patch passed

+1 :green_heart:
mvnsite
1m 23s

the patch passed

-1 :x:
javadoc
0m 41s
/patch-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdkUbuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04.txt
hadoop-yarn-server-resourcemanager in the patch failed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04.

+1 :green_heart:
javadoc
0m 58s

the patch passed with JDK Private Build-1.8.0_352-8u352-ga-1~20.04-b08

+1 :green_heart:
spotbugs
2m 58s

the patch passed

+1 :green_heart:
shadedclient
22m 57s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
99m 17s

hadoop-yarn-server-resourcemanager in the patch passed.

+1 :green_heart:
unit
0m 32s

hadoop-yarn-server-router in the patch passed.

+1 :green_heart:
asflicense
0m 37s

The patch does not generate ASF License warnings.

230m  1s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5284/7/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/5284

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux 17720e09f0bb 4.15.0-200-generic #211-Ubuntu SMP Thu Nov 24 18:16:04 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 08858e8c497f42fc68b0750ebbcd836204d395c1

Default Java
Private Build-1.8.0_352-8u352-ga-1~20.04-b08

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_352-8u352-ga-1~20.04-b08

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5284/7/testReport/

Max. process+thread count
965 (vs. ulimit of 5500)

modules
C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5284/7/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 39s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  1s

codespell was not available.

+0 :ok:
detsecrets
0m  1s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 3 new or modified test files.

_ trunk Compile Tests _

+0 :ok:
mvndep
15m 25s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
32m 24s

trunk passed

+1 :green_heart:
compile
4m 14s

trunk passed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04

+1 :green_heart:
compile
3m 31s

trunk passed with JDK Private Build-1.8.0_352-8u352-ga-1~20.04-b08

+1 :green_heart:
checkstyle
1m 14s

trunk passed

+1 :green_heart:
mvnsite
1m 36s

trunk passed

-1 :x:
javadoc
0m 53s
/branch-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdkUbuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04.txt
hadoop-yarn-server-resourcemanager in trunk failed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04.

+1 :green_heart:
javadoc
1m 11s

trunk passed with JDK Private Build-1.8.0_352-8u352-ga-1~20.04-b08

+1 :green_heart:
spotbugs
2m 58s

trunk passed

+1 :green_heart:
shadedclient
23m 28s

branch has no errors when building and testing our client artifacts.

-0 :warning:
patch
23m 47s

Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 27s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
1m 36s

the patch passed

+1 :green_heart:
compile
4m 11s

the patch passed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04

+1 :green_heart:
javac
4m 11s

the patch passed

+1 :green_heart:
compile
3m 22s

the patch passed with JDK Private Build-1.8.0_352-8u352-ga-1~20.04-b08

+1 :green_heart:
javac
3m 22s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
1m  1s

the patch passed

+1 :green_heart:
mvnsite
1m 21s

the patch passed

-1 :x:
javadoc
0m 40s
/patch-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdkUbuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04.txt
hadoop-yarn-server-resourcemanager in the patch failed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04.

+1 :green_heart:
javadoc
1m  0s

the patch passed with JDK Private Build-1.8.0_352-8u352-ga-1~20.04-b08

+1 :green_heart:
spotbugs
2m 54s

the patch passed

+1 :green_heart:
shadedclient
23m 36s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
98m 38s

hadoop-yarn-server-resourcemanager in the patch passed.

+1 :green_heart:
unit
1m  5s

hadoop-yarn-server-router in the patch passed.

+1 :green_heart:
asflicense
0m 35s

The patch does not generate ASF License warnings.

231m  2s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5284/8/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/5284

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux b01b646cfa04 4.15.0-200-generic #211-Ubuntu SMP Thu Nov 24 18:16:04 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / fca0c20976db827c4ec5ff617d5eca4abd3c694d

Default Java
Private Build-1.8.0_352-8u352-ga-1~20.04-b08

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_352-8u352-ga-1~20.04-b08

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5284/8/testReport/

Max. process+thread count
937 (vs. ulimit of 5500)

modules
C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5284/8/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 39s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 3 new or modified test files.

_ trunk Compile Tests _

+0 :ok:
mvndep
15m 30s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
30m 50s

trunk passed

+1 :green_heart:
compile
3m 50s

trunk passed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04

+1 :green_heart:
compile
3m 16s

trunk passed with JDK Private Build-1.8.0_352-8u352-ga-1~20.04-b08

+1 :green_heart:
checkstyle
1m 16s

trunk passed

+1 :green_heart:
mvnsite
1m 37s

trunk passed

-1 :x:
javadoc
0m 55s
/branch-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdkUbuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04.txt
hadoop-yarn-server-resourcemanager in trunk failed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04.

+1 :green_heart:
javadoc
1m 12s

trunk passed with JDK Private Build-1.8.0_352-8u352-ga-1~20.04-b08

+1 :green_heart:
spotbugs
2m 56s

trunk passed

+1 :green_heart:
shadedclient
23m  4s

branch has no errors when building and testing our client artifacts.

-0 :warning:
patch
23m 23s

Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 28s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
1m 29s

the patch passed

+1 :green_heart:
compile
3m 43s

the patch passed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04

+1 :green_heart:
javac
3m 43s

the patch passed

+1 :green_heart:
compile
3m 12s

the patch passed with JDK Private Build-1.8.0_352-8u352-ga-1~20.04-b08

+1 :green_heart:
javac
3m 12s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
1m  2s

the patch passed

+1 :green_heart:
mvnsite
1m 23s

the patch passed

-1 :x:
javadoc
0m 40s
/patch-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdkUbuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04.txt
hadoop-yarn-server-resourcemanager in the patch failed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04.

+1 :green_heart:
javadoc
1m  0s

the patch passed with JDK Private Build-1.8.0_352-8u352-ga-1~20.04-b08

+1 :green_heart:
spotbugs
2m 51s

the patch passed

+1 :green_heart:
shadedclient
23m 17s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
98m 25s

hadoop-yarn-server-resourcemanager in the patch passed.

+1 :green_heart:
unit
0m 33s

hadoop-yarn-server-router in the patch passed.

+1 :green_heart:
asflicense
0m 37s

The patch does not generate ASF License warnings.

227m  3s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5284/9/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/5284

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux f06e90bcad82 4.15.0-200-generic #211-Ubuntu SMP Thu Nov 24 18:16:04 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / cbb1d4a53b33018347c4cfdec9324f9939d76c5d

Default Java
Private Build-1.8.0_352-8u352-ga-1~20.04-b08

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_352-8u352-ga-1~20.04-b08

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5284/9/testReport/

Max. process+thread count
945 (vs. ulimit of 5500)

modules
C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5284/9/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

@goiri Can you help to merge this pr into the trunk branch? Thank you very much! I will continue to follow up YARN-11222.

@goiri Thank you very much for helping to review the code!


Fix memory leak in xds_proxy when channels are blocked

Fixes https://github.com/istio/istio/issues/34097
~I have some tests locally but its really hacky, will cleanup and add before submitting~ Tests added. This was a bit tricky to test, but the test fails without the PR and passes with it, so I think its all good.

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

/test all

@howardjohn: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Rerun command

lint_istio
16c82323c525e46ff9813fa4ab7138f96c32d765
link
/test lint_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Rerun command

lint_istio
16c82323c525e46ff9813fa4ab7138f96c32d765
link
/test lint_istio

gencheck_istio
16c82323c525e46ff9813fa4ab7138f96c32d765
link
/test gencheck_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Rerun command

lint_istio
16c82323c525e46ff9813fa4ab7138f96c32d765
link
/test lint_istio

gencheck_istio
16c82323c525e46ff9813fa4ab7138f96c32d765
link
/test gencheck_istio

unit-tests_istio
16c82323c525e46ff9813fa4ab7138f96c32d765
link
/test unit-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Rerun command

gencheck_istio
16c82323c525e46ff9813fa4ab7138f96c32d765
link
/test gencheck_istio

unit-tests_istio
16c82323c525e46ff9813fa4ab7138f96c32d765
link
/test unit-tests_istio

lint_istio
d116114f6e2fd19f8484cc615e4ef209700fc8fa
link
/test lint_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Thanks, removed my logs
On Fri, Jul 16, 2021 at 2:08 PM Yangmin Zhu @.***>
wrote:

@.**** commented on this pull request.
In pkg/istio-agent/xds_proxy.go
https://github.com/istio/istio/pull/34098#discussion_r671516927:

@@ -282,6 +289,16 @@ type ProxyConnection struct {
upstreamDeltas     discovery.AggregatedDiscoveryService_DeltaAggregatedResourcesClient
}

+// safeSendRequest is a small wrapper around sending to con.requestsChan. This ensures that we do not
+// block forever on
+func (con *ProxyConnection) safeSendRequest(req *discovery.DiscoveryRequest) {

select {
case con.requestsChan <- req:
case <-con.stopChan:

log.Errorf("howardjohn: send stopped request")

update the log?
In pkg/istio-agent/xds_proxy.go
https://github.com/istio/istio/pull/34098#discussion_r671517015:

  	if err != nil {

  		con.upstreamError <- err
  		return
  	}

	con.responsesChan <- resp

	select {

	case con.responsesChan <- resp:

	case <-con.stopChan:

		log.Errorf("howardjohn: stop response")

same here
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/istio/istio/pull/34098#pullrequestreview-708737920,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAEYGXJWNFEHNN4AOBYEJ2TTYCNU3ANCNFSM5AOQR2BA
.

@howardjohn: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
5aefda052201a10efcd0f056c7d1557f2bc213b1
link
/test unit-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
5aefda052201a10efcd0f056c7d1557f2bc213b1
link
/test unit-tests_istio

lint_istio
9f792eaca6046fd5cb9f4a06a3470828d33a9cbc
link
/test lint_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
5aefda052201a10efcd0f056c7d1557f2bc213b1
link
/test unit-tests_istio

lint_istio
9f792eaca6046fd5cb9f4a06a3470828d33a9cbc
link
/test lint_istio

gencheck_istio
9f792eaca6046fd5cb9f4a06a3470828d33a9cbc
link
/test gencheck_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/retest

@howardjohn: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Rerun command

gencheck_istio
9f792eaca6046fd5cb9f4a06a3470828d33a9cbc
link
/test gencheck_istio

lint_istio
9f792eaca6046fd5cb9f4a06a3470828d33a9cbc
link
/test lint_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/retest

/cherrypick release-1.11
/cherrypick release-1.10
/cherrypick release-1.9

@howardjohn: new pull request created: #34150

In response to this:

/cherrypick release-1.11
/cherrypick release-1.10
/cherrypick release-1.9

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

/cherrypick release-1.10
It seems backport to 1.9 and 1.10 failed

@hzxuzhonghu: #34098 failed to apply on top of branch "release-1.10":
Applying: Fix memory leak in xds_proxy when channels are blocked
Using index info to reconstruct a base tree...
M	pkg/istio-agent/xds_proxy.go
M	pkg/istio-agent/xds_proxy_test.go
Falling back to patching base and 3-way merge...
Auto-merging pkg/istio-agent/xds_proxy_test.go
Auto-merging pkg/istio-agent/xds_proxy.go
CONFLICT (content): Merge conflict in pkg/istio-agent/xds_proxy.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Fix memory leak in xds_proxy when channels are blocked
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherrypick release-1.10
It seems backport to 1.9 and 1.10 failed

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@hzxuzhonghu: new issue created for failed cherrypick: #36188

In response to this:

/cherrypick release-1.10
It seems backport to 1.9 and 1.10 failed

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

sorry, it is done manually


include pdbstr.exe

What do people think about redistributing pdbstr.exe and including it in both SourceLink.Fake and SourceLink.exe?
C:\Program Files (x86)\Windows Kits\8.1\Debuggers\Redist\X86 Debuggers And Tools-x86_en-us.msi
Using lessmsi (cinst lessmsi) it shows both pdbstr.exe and srcsrv.dll being redistributable.

This would prevent having to look for it:
https://github.com/ctaggart/SourceLink/blob/master/SourceLink/Pdbstr.fs

I'm confident that being the the Redist folder that these are redistributable. I extracted with:
msiexec /a 'X86 Debuggers And Tools-x86_en-us.msi' /qb targetdir='C:\tmp\msi'
pdbstr.exe 569 KB works without dbghelp.dll
srctool.exe 33 KB, requires dbghelp.dll 1203 KB
srcsrv.dll is 90 KB, not required by pdbstr.exe
I'm only going to include pdbstr.exe and srcsrv.dll with SourceLink.exe. For SourceLink.Fake, it will keep the default behavior. That doesn't prevent installing the SourceLink nuget package and using its pdbstr.exe. Use Pdbstr.execWith instead of Pdbstr.exec. It should look something like:
let pdbstr = findToolInSubPath "pdbstr.exe" "packages/SourceLink"
Pdbstr.execWith pdbToIndex p.OutputFilePdbSrcSrv pdbstr


Kotlin DSL reference contains Groovy DSL on some pages

Issue type
Wrong or misleading information
Problem description
See an example, SourceSets
It provides an inline example that is written with Groovy DSL, not Kotlin.
As a user of Kotlin DSL, I want to see Kotlin DSL examples in Kotlin DSL reference.
Context (optional)
No response
Page with the problem
https://docs.gradle.org/current/kotlin-dsl/gradle/org.gradle.api.plugins/-java-plugin-extension/source-sets.html?query=abstract fun sourceSets(closure: Closure): Any

Thank you for your interest in Gradle!
This issue will be closed as a duplicate of

https://github.com/gradle/gradle/issues/24622

Please add your use case and 👍 to that issue.


High Priority Issues

Child Compiler Watch mode is buggy
The server seems to "watch" correctly, but the browser build does not unless I browser to the page first.
https://github.com/module-federation/nextjs-mf/blob/main/packages/nextjs-mf/src/plugins/ChildFederationPlugin.ts#L317

I sometimes get an AddAll error that seems to originate from fileDependencies via runLoaders in webpack core.

error - uncaughtException: TypeError: Cannot read properties of undefined (reading 'addAll')
    at /home/ac/Dev/delete-me/nextjs-mf/node_modules/next/dist/compiled/webpack/bundle5.js:57419:37
    at /home/ac/Dev/delete-me/nextjs-mf/node_modules/next/dist/compiled/webpack/bundle5.js:21091:3
    at iterateNormalLoaders (/home/ac/Dev/delete-me/nextjs-mf/node_modules/next/dist/compiled/webpack/bundle5.js:20917:10)
    at /home/ac/Dev/delete-me/nextjs-mf/node_modules/next/dist/compiled/webpack/bundle5.js:20908:4
    at /home/ac/Dev/delete-me/nextjs-mf/node_modules/next/dist/compiled/webpack/bundle5.js:57400:15
    at eval (eval at create (/home/ac/Dev/delete-me/nextjs-mf/node_modules/next/dist/compiled/webpack/bundle5.js:23493:10), <anonymous>:14:1)
    at Array.<anonymous> (/home/ac/Dev/delete-me/nextjs-mf/node_modules/next/dist/build/webpack/plugins/profiling-plugin.js:111:29)
    at runCallbacks (/home/ac/Dev/delete-me/nextjs-mf/node_modules/next/dist/compiled/webpack/bundle5.js:10192:15)
    at /home/ac/Dev/delete-me/nextjs-mf/node_modules/next/dist/compiled/webpack/bundle5.js:10365:4
    at /home/ac/Dev/delete-me/nextjs-mf/node_modules/next/dist/compiled/webpack/bundle5.js:19744:16

We need to inject some stats data from browser build into server build, would it be possible to do so without string replace remoteEntry?
I was hoping we could do something like exposes: {./chunkMap: './asyncLoader=!data:application/javascript=module.exports={}'}

Ability wrap entrypoints (pages) in async boundary
https://github.com/module-federation/nextjs-mf/issues/234

The idea here is i would take the content of the originalFile:
import { useState, useEffect } from 'react';
import { injectScript } from '@module-federation/nextjs-mf/utils';

export default function ExposedPages() {
  const [pageMap, setPageMap] = useState('');
  const [pageMapV2, setPageMapV2] = useState('');

  useEffect(() => {
    injectScript({
      global: 'home_app',
      url: 'http://localhost:3000/_next/static/chunks/remoteEntry.js',
    })
      .then((container) => container.get('./pages-map'))
      .then((data) => {
        setPageMap(data);
      });

    injectScript({
      global: 'home_app',
      url: 'http://localhost:3000/_next/static/chunks/remoteEntry.js',
    })
      .then((container) => container.get('./pages-map-v2'))
      .then((data) => {
        setPageMapV2(data);
      });
  }, []);

  return (
    <>

This app exposes the following pages:

./pages-map

{JSON.stringify(pageMap, undefined, 2)}

./pages-map-v2

{JSON.stringify(pageMapV2, undefined, 2)}

    </>
  );
}
ExposedPages.getInitialProps = ()=>{}

Move it to another dependency - an AsyncDependnecyBlock
Then replace the content of the page with
const page = import(()=>AsyncDependency)
page.getInitialProps = async (ctx)=>{
return (await import(AsyncDependency)).getInitialProps(ctx)
}

using the webpack internal  module type for remoteEntry

We have very complex remote entry logic that we put in promise new Promise() as a big string.
Id love to use a NormalModule and make all remotes be internal ./src/my-fancy-remote-loader.js, but to do so - I need the custom remote loader to know what config is from module federation. So I would need to pass it through a loader or something and inject global@url from user config so the custom remote module knows what remote I need to load
Improve hooks lifecycle - build is slower than it needs to be due to child compiler being called in later stages. If possible it would be nice to have these compiles take place sooner in the build lifecycle

@alexander-akait these are the high priority items I need expertise on.
There’s a few other things but we can discuss those


change start to run

I Follow the instructions(README.md),  and "./test_runtime.sh -r docker-runc" execute failed. So I have this modify.

runc start failed if it has no runc create ,so change start to run (create+start), it will avoid "**/state.json: no such file or directory" error.
add --tty to command ,the generated config.json will has"terminal: true",  it will avoid the "/dev/console not found" error.
then I can see the validation.

root@ubuntu:****opencontainers/ocitools# ./test_runtime.sh -r docker-runc -l debug
-----------------------------------------------------------------------------------
VALIDATING RUNTIME: docker-runb
-----------------------------------------------------------------------------------
DEBU[0000] validating root filesystem
DEBU[0000] validating container process
DEBU[0000] validating capabilities
DEBU[0000] validating hostname
DEBU[0000] validating rlimits
DEBU[0000] validating mounts exist
DEBU[0000] validating linux default filesystem
DEBU[0000] validating linux default devices
DEBU[0000] validating sysctls
DEBU[0000] validating maskedPaths
DEBU[0000] validating readonlyPaths
Runtime docker-runb passed validation

Signed-off-by: Shukui Yang<EMAIL_ADDRESS>

With runtime-spec 1.0.0-rc1, ‘start’ has been replaced by ‘create’ and
‘start’ (opencontainers/runtime-spec#384).  ‘run’ is specific to runC,
and ocitools should stick to the spec'ed API.

thank you, I think I can close this pr.


[Multi SDFG branch, Fortran frontend] Several par_Decl_Range_Finder() were missing the structure argument (therefore passing a wrong boolean argument in its place).

Additionally:

There were some noop branches that should really be replaced by assertions.
Added an assertion where the type string can really have two possible values (to make it clear and defensive).

@pratyai, I'm not sure I follow - can you show me a simple test case of Fortran where we previously failed?

@pratyai, I'm not sure I follow - can you show me a simple test case of Fortran where we previously failed?

Failure for par_Decl_Range_Finder()? I can show none, however please notice that par_Decl_Range_Finder() has the following signature (I've annotated by their order):
def par_Decl_Range_Finder(node: ast_internal_classes.Array_Subscript_Node,  # 0
                          ranges: list,  # 1
                          rangepos: list,  # 2
                          rangeslen: list,  # 3
                          count: int,  # 4
                          newbody: list,  # 5
                          scope_vars: ScopeVarsDeclarations,  # 6
                          structures: Structures,  # 7
                          declaration=True):  # 8 (kw)
...definition here...

Now, notice the following call (one of the several updated in this changelist; I've broken it up into multiple lines for ease of tracking):
par_Decl_Range_Finder(self.first_array,  # 0
  self.loop_ranges,  # 1
  [],  # 2
  rangeslen_left,  # 3
  self.count,  # 4
  new_func_body,  # 5
  self.scope_vars,  # 6
  True)  # 7 (??? This is the positional argument `structures: Structures`)

My understanding is that these calls are so clearly wrong that they don't even call for a test case. While it is possible that structures is actually a boolean (or an union of boolean and other types), I thought that's unlikely. If that happens to be the case, we should then update the type-hint (and possibly the argument name too).

For the assert hasattr(node, "_fields") part, I just now realize that node is an FNode, so it is always true. I'll be happy to drop that line.
As for the assert i.type in {'ALL', 'RANGE'} line, I can also take it out. However, IMO we could use Enum types for the string types that have a small number of known possible values (e.g., here and also the data types). It is difficult to track down what a string's value is supposed to be when they are all just plain str.


Lecture 2: Developing high-fidelity models of hydraulic systems

Completed lecture 2 notes

Don't forget to update the docs/Project.toml with the new dependencies


BUG: LCD response Status 500 - errUnknownField "*types.MsgCreateJob" after Cosmos SDK 0.50.5 Upgrade

What is happening?

Section description
Provide as much context as you can. Give as much context as you can to make it easier for the developers to figure what is happening.

paloma_sdk.exceptions.LCDResponseError: Status 500 - errUnknownField "*types.MsgCreateJob": {TagNum: 1, WireType:"bytes"}: tx parse error [cosmos/cosmos-sdk@v0.50.5/x/auth/tx/decoder.go:44] with gas used: '6972'
Paloma and pigeon versions and logs

Section description
Write down paloma version.
Write down pigeon version.
Copy and paste pigeon config file as well as relevant ENV variables.

Paloma v1.13.
Pigeion v1.11.o
How to reproduce?

Section description
Please write detailed steps of what you were doing for this bug to appear.

Paloma Message Relay with Cosmwasm Job
What is the expected behaviour?

Section description
If you know, please write down what is the expected behaviour. If you don't know, that's ok. We can have a discussion in comments.

Message relay still functions under Cosmwasm 1.5.2 as it did with 1.3.0

@webelf101 @wc117 it appears we may have to migrate our contracts will you confirm with details here: https://github.com/CosmWasm/cosmwasm/blob/v1.5.2/MIGRATING.md

@byte-bandit from @wc117

No, it is earlier step than CW. The failed transaction was to create a job. So I think Paloma protocol changed and we have to change some part to create a job. I don't know the details so @ByteBandit only can let me know how to change it.

This looks like it's caused by a change in message definition.
Paloma v1.13.0 removed some fields that had been deprecated for about half a year now: https://github.com/palomachain/paloma/compare/v1.12.2...v1.13.0#diff-e70526f754289da7f9ba89f1c44add9c03d5bb6e3fedcfa7e6b0ec74cfdc7d1b
I assume the contract sending this transaction is still using this dropped creator field.

@wc117 reassigned to you.

@byte-bandit - from @wc117
What should I change to work with this update?

I think we need to change paloma.py library and CW too.


support whitelisting

Adding support for whitelisting
:warning: NOT TESTED

can't make the build to pass via GHA. Passes locally, to investigate later


Fix Multiple-Sort Thread Duplicate Elements

When using "Run X Sorts", duplicate elements could appear for seemingly no reason. This was caused by the sorting threads not setting the number of unique elements.
When the number of unique elements is larger than the array size (frequenty the case), this causes some elements to decrease by 1. This means that, on the typically-used linear distribution, duplicate elements often appear.
This is fixed by directly changing the array length slider, which not only auto-updates the uniques slider, but also makes the sliders properly update with the length change.
To achieve this, public methods are created in ArrayFrame.java, and the ArrayFrame instance is made publicly accessible.

👏


Add content to About page

Currently, we are not going to feature an About page. Removed from nav in  https://github.com/trickstercache/trickstercache.org/commit/28d55422a8fc848fd1731c692eb8d231c17fbcbf
The functionality and starter files are still in the repo. To add them back to the nav, add the following to the front matter:
menu:
   main:
     weight: 30


[ES2015 profile]add TypedArray intrinsic object

add %TypedArray% intrinsic object
implement Int8Array
will implement other types and prototype functions
in the following patches.

Each typedarray object has following struct

ecma_object_t
extended_part (it is class type, with class id and array length)
typedarray_info_t (contains the internal arraybuffer object, byteoffset and element size)

Also it fixed a bug for arraybuffer. Each bytes in the buffer should be initialized to 0.
JerryScript-DCO-1.0-Signed-off-by: Zidong Jiang<EMAIL_ADDRESS>

Thank you for the hard work. It is Christmas time so we will be slower to respond.

@zherczeg Merry Christmas and Happy new year :) Totally understand, and just review it after your vacation
I think TypedArray has much diffs with normal Array.

length is fixed after instantiation, and all elements are default zeros
It contains another object instance arraybuffer inside, and multiple typedarray may share the same arraybuffer
the set/get/define prop operation is special from any other JS type. Integer Indexed Exotic Objects

Based on this lot of code typed arrays are not exactly designed for small devices. So we really need to figure out how can we keep the binary size increase and performance drop at bay. Optimization is key for that.

@zherczeg I think we provide different levels of profiles to let users to choose which one is suitable for device and application. For really small devices, typedarray is not suitable, and maybe we had to choose the minimal profile (like we did in curiebsp port).
V8 needs about 10M ram to run, I think JerryScript's target device range should be xx KB ram to x MB ram, and the larger devices may need more features.
TypedArray is designed to handle the raw data in the buffer, and should be useful in embedded/iot/wearable area. For example, W3C;s sensor API and bluetooth API are using it.
Yes, Optimization is very important for those feature enhancement, and I will pay more attention on it. Your suggestions/experiments are very valuable for me. Thanks very much!

I have been thinking on another idea. Non-strict arguments (ECMA_OBJECT_TYPE_ARGUMENTS) could also be a grouping for typed arrays, since they both pseudo arrays. Unless it would make things more complicated.

@zherczeg arguments object is defined in (spec 9.4.4) [http://www.ecma-international.org/ecma-262/6.0/#sec-arguments-exotic-objects], while typedarray is 9.4.5. The details has some differents. e.g
function f(){return arguments}
var a = f(1,2,3)
a[5]=100;
a[5]
>100

while to typedarray obj, the set for index which is exceed the length is invalid operation
But they maybe can share some common functions.

Regarding the arguments object, it has two members, a scope pointer and a length. The length is 32 bit long atm. However, the maximum number of arguments is 255, and I think it will never be bigger than 65535. So it could be reduced to uint16_t, and we would get two extra bytes for the other stuff. Only one bit is needed to tell whether we use an arguments or an exotic array object. This way all pseudo arrays would go into one group.

@zherczeg Do you mean add a new class_id for arguments, and implement its set/get/define/list prop operation which may be similar with typedarray (but not same) ?

Yes, rename it to something else (pseudo array or exotic array). This way we don't need to overload objects with classes.

Yes, rename it to something else (pseudo array or exotic array). This way we don't need to overload objects with classes.

Do you mean that we define a new member of ecma_object_type_t. e.g ECMA_OBJECT_TYPE_EXOTIC_ARRAY, so that typedarray will no longer belong to "ECMA_OBJECT_TYPE_CLASS"?
if so, the bits for ecma_object_type_t is now 3, and we need more bits to support more than 7 types

Do you mean that we define a new member of ecma_object_type_t. e.g ECMA_OBJECT_TYPE_EXOTIC_ARRAY, so that typedarray will no longer belong to "ECMA_OBJECT_TYPE_CLASS"?
if so, the bits for ecma_object_type_t is now 3, and we need more bits to support more than 7 types

No. Change ECMA_OBJECT_TYPE_ARGUMENTS to something more generic, e.g. ECMA_OBJECT_TYPE_PSEUDO_ARRAY and this new type should handle both typed arrays and non-strict arguments.

No. Change ECMA_OBJECT_TYPE_ARGUMENTS to something more generic, e.g. ECMA_OBJECT_TYPE_PSEUDO_ARRAY and this new type should handle both typed arrays and non-strict arguments.

@zherczeg I found it is difficult to design the pseudo array struct to store both typedarray or  arguments.
Arguments need ecma_value_t for lev, and uint16_t for length
typedarray need ecma_value_t for araybuffer, uint16_t for specific typedarray class id (e.g Int8Array), and uint8_t for element_width_shift (the element size length)
Considering the padding thing, my proposed struct is
    struct
    {
      uint8_t type; //pseudo array type, e.g. Arguments, TypedArray or TypedArray _WITH_INFO
      uint8_t extra_info; // only for typedarray to store the element width shift
      union
     {
        uint16_t class_id:// for typedarray
        uint16_t length // for argument
     } u1;
     union
     {
       ecma_value_t lex_env_cp; // for argument
       ecma_value_t arraybuffer; // for typedarray
     } u2;
    } pseudo_array;

What do you think about it?

Your proposal is good for me.

@zherczeg Updated the patch. Now both typedarray and arguments belong to the ecma_object_type_pseudo_array.

@zherczeg I have squashed the commits, and solved the conflict with #1497

@zherczeg Thanks. Updated according to the review comments.


Feat: Update readme.md file Update latest Screenshots of App

Describe the feature
@Yashshukla11 Assign this issue for me to Update the readme.md file ....
Record

[X] I agree to follow this project's Code of Conduct
[X] I'm a GSSoC'24 contributor
[X] I want to work on this issue

@Yashshukla11 Assign this issue for me to Update the readme.md file ....

I want to update readme by latest screenshots

I want to work on this issue, please assign it to me under gssoc24


Fix styling

Fixed styling for better viewability, better indentation

CSS file is generated by SASS, so it wouldn't make sense to indent it since it's generated every new time.


DBZ-5714 tasks.max description now reflects support for multiple task

DBZ-5714
The ability to support multiple tasks was added to the SQL Server connector, but the documentation was not updated. The behavior of the connector in using multiple tasks is similar to the behavior of the MongoDB connector.
Please backport this change to the 1.9 branch so that we include it in the 1.9.7 release.

@roldanbob I think this is misunderstanding. The task assignment is driven by database.names. In SQL Server each database instances can hold multiple logical databases and one or more logical databases are captured by ech task. So the text should not be talking about single/clustered databases as this is a different concept.

Ah, got it. Thanks for the clarification, @jpechane. It was not clear about the extent to which the MongoDB description applied in this context. I've updated the description to reflect your comments.

@roldanbob Applied, thanks! One sentence and such a big discussion :-)


signed u256 - i257

Pull Request type

Please check the type of change your PR introduces:

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, renaming)
[ ] Refactoring (no functional changes, no API changes)
[ ] Build-related changes
[ ] Documentation content changes
[ ] Other (please describe):

What is the current behavior?
We don't have signed u256.
Issue Number: N/A
What is the new behavior?
We have signed u256.
Does this introduce a breaking change?

[ ] Yes
[x] No

Other information

The code and tests for this is largely taken from old i129 int. I've tried to make commits with old pasted code and tweaks made on that commit. Hopefully that will make reviewing easier.
Source: https://github.com/shramee/alexandria/blob/7e0f050b97c42b2a5916d552494d3724ae2c0197/alexandria/math/src/signed_integers.cairo#L1618
Tests come from: https://github.com/shramee/alexandria/blob/7e0f050b97c42b2a5916d552494d3724ae2c0197/alexandria/math/src/tests/signed_integers_test.cairo#L1279

I'm using i257 for Euclidean algorithm implementation of alexandria_math::mod_arithmetics.

https://x.com/shrameetweets/status/1743034431521124704?s=20


Implement voltage biasing for ADS114s08

Implement voltage biasing on the inputs of the ADC ADS114s08.

@anangl Could you please take a look at this PR?

@anangl please take a look

@MaureenHelm what do we do here if assignee and maintainer is not engaging

We have a clear escalation path for this, documented here: https://docs.zephyrproject.org/latest/contribute/contributor_expectations.html#pr-review-escalation


Loading component

Because antify does not support SSR, we need a component to show, while vue is initializing.
May a nice animation?

Use https://lottiefiles.com/ for free animations :D


Migration tool does not exist for Visual Studio for Mac

Visual Studio Community 2017 for Mac
Version 7.7.1 (build 15)

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 75e25f56-15c8-79d7-5e55-d145b7c1159c
Version Independent ID: 06388a58-df68-9438-92d7-17359196f5c8
Content: Migrating from package.config to PackageReference formats
Content Source: docs/reference/migrate-packages-config-to-package-reference.md
Product: nuget
GitHub Login: @karann-msft
Microsoft Alias: karann

@karann-msft @nkolev92 Any recommendations for non-VS scenarios? The doc referenced is VS-specific.

I think the customer should file an issue to developer community asking for this functionality in VS 4 Mac.
NuGet team does not own that tooling.
https://docs.microsoft.com/en-us/visualstudio/mac/report-a-problem?view=vsmac-2019

@garieIt looks like you have product feedback rather than documentation feedback. If you are looking for functionality that isn’t currently provided by the product, please use our new “Suggest a feature” option in the Visual Studio Developer Community. We’d be happy to have this on record, where others can view it and upvote it, too. For more information about this new functionality in the dev community, see our Suggest a feature page.


godot_4: change package naming

Change the package naming scheme to reflect the hierarchical approach from godot3 to have multiple derivatives (godot3-mono/headless).
Description of changes

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

This is simply to make the packages for godot4 have the same naming scheme as godot3 packages. @ilikefrogs101 is making a godot4-mono build, it would be nice if it would show nicely under nixpkgs search.

@ofborg eval

Make sense, but the merge commit has to be dropped.

https://github.com/NixOS/nixpkgs/pull/300712


Add :big_query step to build the request body

I'm not so sure if the name is good

Thanks @aleDsz! Let's continue this on a separate repo.


Taxon constraint: biological process involved in interaction with host

Please provide as much information as you can:

GO term ID label:
GO:0051701 biological process involved in interaction with host
Request to add a taxon constraint:

Never in vertebrates 7742
Never in arabidopsis
should get rid of 262 annotations https://www.ebi.ac.uk/QuickGO/annotations?goUsage=descendants&goUsageRelationships=is_a,part_of,occurs_in&goId=GO:0051701&taxonId=7742,3702&taxonUsage=descendants&evidenceCode=ECO:0000269&evidenceCodeUsage=descendants ?
Although is this correct?
for example
modulation by virus of host process GO:0019048 has taxon restrictions but still has annotations to the restricted taxons e.g.
https://www.ebi.ac.uk/QuickGO/annotations?goUsage=descendants&goUsageRelationships=is_a,part_of,occurs_in&goId=GO:0051701&taxonId=3702&taxonUsage=descendants&evidenceCode=ECO:0000269&evidenceCodeUsage=descendants
are these not filtered?

I thought they were filtered too (at least from QuickGO?)
@pgaudet   do you know how this works?
I can add the taxon constrict you request

I dont think there are taxon constraints yet - this still needs refactoring, because some host proteins are annotated to children of this term because there is no other term to which these can be annotated.
This is something to be discussed at a future multi org call - this is the large part of the refactoring that needs to be done.

Vampire Venom: Vasodilatory Mechanisms of Vampire Bat (Desmodus rotundus) Blood Feeding

the CALCA gene in vampire bats induces vasodilation of resistance vessels such as mesenteric arteries partly via voltage-gated potassium channels and endothelium independent mechanisms, facilitating blood meal feeding by promoting continual blood flow. 🧛 🦇


fix(transformer): arrow func transform use correct spans

[!WARNING]
This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

#3630  👈
#3627
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @overlookmotel and the rest of your teammates on  Graphite


creating two tab navigators is splitting the screen

I am creating an app with two TabNavigators one at the top and one at the bottom.. but When I do that, the selected tab view is not taking the full screen rather than the screen is getting divided horizontally. where the bottom screen corresponds to the bottom TabNavigator and the top screen relates to the top TabNavigator.. is there a way to solve this issue?

TabNavigator was designed to support just one tab bar at a time. You could try nesting the TabNavigators -- in your root component have TabNavigator 1, and then in a tab item's screen you'd put Tab Navigator 2.

But that would mean Tab navigator 2 won't show up unless that tab item which includes the Tab navigator 2 is selected, right?

Yeah. If you want both tabs to always be present on the screen you should fork this component or write your own.

What if I put the 2nd Tab navigator in all the screens of the first Tab navigator items? Would that work?

Will close this as its not in the goals for this library to provide.


CommCare App Template Test Framework

Added a couple helper and utility classes/methods to make it easy to write tests against small shell applications, so we can write tests about session behavior, and other workflow componenents.
Depends on
https://github.com/dimagi/javarosa/pull/144

This is great! It is really nice to have examples of building up CommCare app instances by hand. Not only does it help with tests and debugging, but also with understanding object dependencies.

Yeah, it's revealed some fairly clear weaknesses and couplings that it's a
bit easier to see how to pull out in this frame.
-Clayton
On Mon, Aug 17, 2015 at 9:55 AM, Phillip Mates<EMAIL_ADDRESS>wrote:

This is great! It is really nice to have examples of building up CommCare
app instances by hand. Not only does it help with tests and debugging, but
also with understanding object dependencies.
—
Reply to this email directly or view it on GitHub
https://github.com/dimagi/commcare/pull/133#issuecomment-131825481.


Make squaring corners more obvious or clear

Something I've seen at mapathons, even are repeated reminders and walking around, is that people forget to square corners. Is there some way we can remind or suggest this more overtly? Or maybe this can be done with the building tool I've heard about in #528? Thanks!

yep, the building tool and improvements to the walkthrough can all help here.. these things are ticketed already.


DEC-587, DEC-556 Add external url value to V1 output

What: Added field to API output for external collection urls

:+1:

:+1:


Internal property is exposed as attribute

The primer and web site docs both imply that you need to add a property to the properties object to get deserialization from an attribute: https://github.com/Polymer/polymer/blob/master/PRIMER.md#attribute-deserialization and here: https://www.polymer-project.org/1.0/docs/devguide/properties.html#attribute-deserialization
However, it appears that if I bind a value -- even a "private" property -- it's automatically exposed as an attribute. See:
http://jsbin.com/mecoha/edit?html,console,output
I'm not sure if this is intentional or a side-effect of some other feature, but it seems buggy that you can't not publish something as an attribute, and weird that it's a side-effect of binding the value (i.e., it doesn't work with just any property, only the ones that are bound or in properties).

woah excellent catch @arthurevans I agree, this is unexpected!

This is intentional.  The type in properties has only ever served to determine how attributes are deserialized, not if they are.  Not requiring a property to be in the properties block to deserialize was added as an (undocumented?) shorthand, and the case you suggested in the jsBin -- a user explicitly defining an underscore-prefixed attribute should be considered as bad-form as a user referencing an underscore-prefixed property, i.e. the user knows they're doing something wrong.
That said, the micro-perf branch that will be merged soon will filter out _-prefixed properties from deserialization as a performance optimization (needless attempt at deserializing can add up): https://github.com/Polymer/polymer/compare/micro-perf?diff=split&name=micro-perf?w=1#diff-954b2c8fdbb5ae157e3d0957dd1c5d66R158, which I think should eliminate the main concern you highlighted.

Issue seems to be fixed in Polymer 2: http://jsbin.com/tawudayeda/edit?html,console,output