brew install silently ignores pins

brew config output
HOMEBREW_VERSION: 3.3.10
ORIGIN: https://github.com/Homebrew/brew
HEAD: 385892f3d27dcab0f5a1cb47c3927d9d65ed007c
Last commit: 2 days ago
Core tap ORIGIN: https://github.com/Homebrew/homebrew-core
Core tap HEAD: 531c5269263353310a326f8a7f0c8b0fff94aebd
Core tap last commit: 33 minutes ago
Core tap branch: master
HOMEBREW_PREFIX: /usr/local
HOMEBREW_CASK_OPTS: []
HOMEBREW_CORE_GIT_REMOTE: https://github.com/Homebrew/homebrew-core
HOMEBREW_EDITOR: nvim
HOMEBREW_MAKE_JOBS: 12
Homebrew Ruby: 2.6.8 => /System/Library/Frameworks/Ruby.framework/Versions/2.6/usr/bin/ruby
CPU: dodeca-core 64-bit kabylake
Clang: 13.0.0 build 1300
Git: 2.34.1 => /usr/local/bin/git
Curl: 7.77.0 => /usr/bin/curl
macOS: 12.0.1-x86_64
CLT: <IP_ADDRESS>.1.1638488800
Xcode: N/A

brew doctor output
[Don't think this is relevant]

Warning: "config" scripts exist outside your system or Homebrew directories.
`./configure` scripts often look for *-config scripts to determine if
software packages are installed, and which additional flags to use when
compiling and linking.

Having additional scripts in your path can confuse software installed via
Homebrew if the config script overrides a system or Homebrew-provided
script of the same name. We found the following "config" scripts:
  /Users/et/.local/bin/pre-commit-validate-config

Verification

[X] I ran brew update and am still able to reproduce my issue.
[X] I have resolved all warnings from brew doctor and that did not fix my problem.

What were you trying to do (and why)?
I have a pin on the go formula at v1.17.2. The latest version is v1.17.5. I ran brew install go, expecting it to fail or prompt me due to the pin.
What happened (include all command output)?
brew upgrade, as expected, doesn't upgrade due to the pin

`brew upgrade` output
❯ brew upgrade
Error: Not upgrading 1 pinned package:
go 1.17.5
==> No packages to upgrade

brew install ignores the pin and installs the latest version without warning or confirmation

`brew install go` output
❯ brew install go
go 1.17.2 is already installed but outdated (so it will be upgraded).
==> Downloading https://ghcr.io/v2/homebrew/core/go/manifests/1.17.5
Already downloaded: /Users/et/Library/Caches/Homebrew/downloads/cf2744615eff3cbc7dea57d7f18a41c54c00c2aabe5a6d633f733718a5c0133c--go-1.17.5.bottle_manifest.json
==> Downloading https://ghcr.io/v2/homebrew/core/go/blobs/sha256:7f516d52e4d009e7508fb708ed527674ba8ca447b259a4103a97bf78798309a9
==> Downloading from https://pkg-containers.githubusercontent.com/ghcr1/blobs/sha256:7f516d52e4d009e7508fb708ed527674ba8ca447b259a4103a97
######################################################################## 100.0%
==> Upgrading go
  1.17.2 -> 1.17.5

==> Pouring go--1.17.5.monterey.bottle.tar.gz
🍺  /usr/local/Cellar/go/1.17.5: 10,825 files, 565.8MB
==> Running `brew cleanup go`...
Disable this behaviour by setting HOMEBREW_NO_INSTALL_CLEANUP.
Hide these hints with HOMEBREW_NO_ENV_HINTS (see `man brew`).
Warning: Skipping (old) /usr/local/Cellar/go/1.17.2 due to it being pinned

When I run brew info go I can see that the pin is still present. This in particular is what make this look like a bug to me.

`brew info go` output
❯ brew info go
go: stable 1.17.5 (bottled), HEAD [pinned at 1.17.2]
Open source programming language to build simple/reliable/efficient software
https://go.dev/
/usr/local/Cellar/go/1.17.2 (10,814 files, 565.8MB)
  Poured from bottle on 2021-11-23 at 12:31:58
/usr/local/Cellar/go/1.17.5 (10,825 files, 565.8MB) *
  Poured from bottle on 2022-01-13 at 13:37:36
From: https://github.com/Homebrew/homebrew-core/blob/HEAD/Formula/go.rb
License: BSD-3-Clause
==> Options
--HEAD
	Install HEAD version
==> Analytics
install: 105,860 (30 days), 310,841 (90 days), 1,342,076 (365 days)
install-on-request: 85,846 (30 days), 246,196 (90 days), 1,088,199 (365 days)
build-error: 274 (30 days)

What did you expect to happen?
At least one of

brew install prints a warning about the pin
brew install requires confirmation to override the pin
brew install removes or updates the pin on override, so that we're not left with a pin that doesn't match the installed version

Step-by-step reproduction instructions (by running brew commands)
`brew install formula`
`brew pin formula`
_Wait for upgraded version_
`brew install formula`

I can reproduce this.

Fixed now on master. This will be in the next release of brew.
Thanks for the report!

Thanks for the terrifyingly quick turnaround!


capitalize all checks in exercise 1

Summary
Closes #

-capitalized all the "check" on buttons

Screenshots

@flobythebay for future PRs, put the issue # in the PR and it will link it so the issue gets closed automatically
E.g. #296


v11 update?

any chance for a v11 update?

Yeah, I completely forgot about this, give me a day or so to test and patch it if needed.


moved integrations page to own folder, PR

New integrations page added separately here. (Not yet in sidebar, but will new proposed landing page has its updated location.)

Page to preview: https://deploy-preview-160--astro-docs-2.netlify.app/en/integrations/integrations/
(It's not visible from sidebar yet, so this can be accepted and no one will be able to navigate it until I explicitly add it to the sidebar.)

This looks amazing @sarah11918!
Do you think subheadings dividing up the types of resource (rather than having that inline on each item) would be helpful?
Like:

Production Sites
Blog Posts
Repos

Each of these is quite a different resource, so maybe it’s helpful to be able to quickly locate the kind you’re looking for. The repos seem to all be templates/starters, so you might want to fork one and get started, the blog posts are more practical guides to doing X, while the sites are cool for checking out and seeing what’s possible.

@delucis Please take a look now!  :)
Some slight organization, also added to the sidebar. I'm not loving that it's in "Setup" and will probably move it eventually, but at least it's there, and prominent (so people can see Astro with stuff! Yay!), and can now be linked to from the new Getting Started page proposed in https://github.com/withastro/docs/pull/155

Looks great!
I might use a username/reponame style for the repo links, but that's a tiny stylistic detail.
Re: sidebar link location — would it make sense to have this linked in the “Guides” section rather than “Setup”?

I might use a username/reponame style for the repo links, but that's a tiny stylistic detail.

Done! One was already like that, so I made them all consistent. Good call @delucis !

Re: sidebar link location — would it make sense to have this linked in the “Guides” section rather than “Setup”?

Yeah, I'm not thrilled with this, but I'm also not thrilled with Themes and Astro vs X being up there either, so that area is going to get tidied soon anyway.  :)  And, it's not actually a "guide" either, so I think the lesser evil right now is to put it with the other related stuff that's ALSO not in the best place, then deal with it all together!


Code refactoring

Changes:

Removed this keyword.
Fixed line wrapping.
Fixed class member ordering.

Coverage decreased (-0.01%) to 12.863% when pulling 774aff39d91faa7c32cddd4222d64dc0cb032ca2 on code_refactoring into 4b023fe83af4b57a2c57c905d624e6a1b107a4e9 on development.

👍 Let's merge


Add --download support

This adds site download support to Exokit. With the --download <directory> option, Exokit will dynamically save all GETs it downloads via fetch/XHR. This isn't a static download like wget -- it actually executes the Javascript.
This is useful for packaging support https://github.com/webmixedreality/exokit/pull/612 so we can get all site resources for a URL.
This is basically another take on --mirror (https://github.com/webmixedreality/exokit/pull/622).

This works, other than requiring a DISPLAY head for the engine to run.


Add a cypress test for verify doctor connect functionality

Hey would like to pick up this issue, Can I start working on it?

@Aswinr24 sorry, iam already working on it, feel free to take up any open issue


Jupyter theme doesn't work while using VSCode with remote container

I refer to the issue #1740.
Is there any news? The bug is kind of boring

Duplicate of https://github.com/microsoft/vscode-jupyter/issues/1407. The resolution for this will be our new native notebooks support, which you can currently preview in VS Code Insiders with full theming support, and which we are working to ship out as the default notebook UI ASAP.


Delay in package availability/caching?

Hi there!  I'm one of the contributors to an NPM package katex and we were considering switching our gh-pages page to use unpkg instead of storing the files directly in gh-pages.  Is this considered an OK use of unpkg?
Second, for a few minutes, I was observing this phenomenon:

<EMAIL_ADDRESS>fails to load with message Cannot find module "/dist/katex.min.js" in package<EMAIL_ADDRESS><EMAIL_ADDRESS>lists katex.min.js (and the files look fine on an npm install katex@0.9.0).
A few minutes later<EMAIL_ADDRESS>worked fine.

Is this normal?  Does a first fetch cause a background caching that takes a while to finish?  Was this a fluke? Could it be avoided in the future?
I ask because we'd like to make the switch to the new version part of the release script, so we'd like a short gap between npm publish and availability on unpkg.  If that's too much to ask, then we'll stick to keeping the npm package on gh-pages.

Pretty sure this is a duplicate of #86. Let's follow up there.


crash with <IP_ADDRESS>7

Here is the pastebin to the crash log.
http://pastebin.com/3G2Yaq5t
i am using ftb infinity evolved 2.2.2 on curse and this only occurred when i manually updated to <IP_ADDRESS>7. using <IP_ADDRESS> does not have any problem.

This is not on my end, something funky is going on. I'll have a new minor release out soon.


Supporting custom backbone networks for VisualCore

Because of the way the VisualCore class is written, it only allows backbones to be from the supplied base nets in the default repository. Would it make sense to instead use a registry where inheriting from ConvBase would allow any custom network to be used as a backbone for VisualCore?
backbone_kwargs = extract_class_init_kwargs_from_dict(cls=eval(backbone_class), dic=backbone_kwargs, copy=True)
Perhaps there's a better way to approach this than I'm thinking. My current workout is to define my own Core class that allows for using this sort of registry.

Hi @arhanjain , thanks for the note. I think a register is a great idea. It should be simple to implement too in base_net.py. Would you like to create a PR for it?

Addressed by #190


Could not create task ':shared_preferences_android:generateDebugUnitTestConfig'.

Steps to reproduce
I encountered this problem two years ago, and in order to compile it successfully, I only had a temporary solution. I checked the relevant issues, but found that the problem had not been completely resolved yet. The temporary solution I adopted was: https://stackoverflow.com/questions/69663243/could-not-create-task-this-and-base-files-have-different-roots

example code: https://github.com/android-dev2015/yaml_dependency
repro steps：
1.flutter pub get
2.open android project
3.sync
Expected results
after execute flutter pub get , open android project can sync without error
Actual results
A build operation failed.
Could not create task ':shared_preferences_android:generateDebugUnitTestConfig'.
Could not create task ':shared_preferences_android:generateDebugUnitTestConfig'.
this and base files have different roots: D:\xx\Android\workspace\yaml_dependency\build\shared_preferences_android and C:\Users\xx\AppData\Local\Pub\Cache\hosted\pub.dev\shared_preferences_android-2.3.3\android.
Code sample
Code sample
pubspec.yaml

name: yaml_dependency
description: "A new Flutter project."
publish_to: 'none'

version: 1.0.0+1

environment:
  sdk: ^3.5.3

dependencies:
  flutter:
    sdk: flutter
  cupertino_icons: ^1.0.8
  shared_preferences: ^2.3.3 # only add this dependency

dev_dependencies:
  flutter_test:
    sdk: flutter

  flutter_lints: ^4.0.0

flutter:
  uses-material-design: true

Screenshots or Video

Screenshots / Video demonstration

Logs
Logs
[Paste your logs here]

Flutter Doctor output
Doctor output
Doctor summary (to see all details, run flutter doctor -v):
[√] Flutter (Channel stable, 3.24.3, on Microsoft Windows [版本 10.0.22621.4169], locale zh-CN)
[√] Windows Version (Installed version of Windows is version 10 or higher)
[√] Android toolchain - develop for Android devices (Android SDK version 35.0.0)
[√] Chrome - develop for the web
[√] Visual Studio - develop Windows apps (Visual Studio Community 2022 17.11.5)
[√] Android Studio (version 2022.3)
[√] Android Studio (version 2023.3)
[√] Android Studio (version 2024.1)
[√] Android Studio (version 2024.2)
[√] Android Studio (version 2024.2)
[√] Connected device (3 available)
[√] Network resources

• No issues found!

This is a known issue which is being tracked in https://github.com/flutter/flutter/issues/105395.
Kindly follow up in the issue linked above for updates.
Closing this in favor of the issue linked above.
Thank you


Error in console when typing value in boost link input.

warning.js:33 Warning: A component is changing an uncontrolled input of type undefined to be controlled. Input elements should not switch from uncontrolled to controlled (or vice versa). Decide between using a controlled or uncontrolled input element for the lifetime of the component. More info: https://fb.me/react-controlled-components
    in input (created by Input)
    in div (created by Input)
    in Input (created by BoostLink)
    in div (created by BoostLink)
    in div (created by BoostLink)
    in div (created by If)
    in If (created by BoostLink)
    in div (created by BoostLink)
    in BoostLink (created by LinksList)
    in div (created by LinksList)
    in td (created by LinksList)
    in tr (created by LinksList)
    in tbody (created by LinksList)
    in table (created by LinksList)
    in div (created by Paper)
    in Paper (created by LinksList)
    in div (created by LinksList)
    in LinksList (created by DetailsLists)
    in div (created by DetailsLists)
    in DetailsLists (created by WidgetDetails)
    in div (created by WidgetDetails)
    in Unknown (created by WidgetDetails)
    in Switch (created by WidgetDetails)
    in div (created by WidgetDetails)
    in WidgetDetails (created by Connect(WidgetDetails))
    in Connect(WidgetDetails) (created by RootModal)
    in div (created by Modal)
    in div (created by Modal)
    in Modal (created by RootModal)
    in RootModal (created by Connect(RootModal))
    in Connect(RootModal) (created by Banner)
    in div (created by Banner)
    in Banner (created by Connect(Banner))
    in Connect(Banner)
    in Provider

Not reproducible.


Possible issue with MultiSelect.tsx

Hello,
I'm seeing an error in MultiSelect.tsx that says Module '"./TagGroup"' declares 'TagList' locally, but it is not exported.
It seems that is because MultiSelect.tsx is trying to import it from TagGroup.tsx, here:
https://github.com/zaichaopan/tailwind-react-aria-components-starter-kits/blob/9f7913733d6433513cd689a2eb9bda0f86ba34f7/src/MultiSelect.tsx#L25
Should it instead get it directly from RAC?
import { TagGroup } from "./TagGroup";
import { TagList } from "react-aria-components";

I could add a PR but you may be aware of it and/or prefer to instead export it from TagGroup.
Thanks.

I made a change to reuse the TagGroup and TagList component. So probably missed the export. The issue should be fixed now.  Please let me know if you still see the error.
React Aria  does not suport multi select comboBox.  I don't want to install another lib like https://github.com/JedWatson/react-select/tree/master which will increase the bundle size a lot.  The current implementation is mainly based on the github disucssion https://github.com/adobe/react-spectrum/issues/2140. Let me know if you have any suggestions. Thanks

No problem. I agree adding in extra libraries beyond the React Aria family is not good.
The added export from TagGroup does indeed fix it, thanks :)


prefs.fetch(ok, fail, 'key') returns array if key is not found (iOS 8)

I am trying the plugin on iOS 8.1.2, Cordova iOS 3.8
when I do prefs.fetch(ok, fail, 'key'); and key does not exist, the ok callback is called with an array as value so I need to do an extra check only on iOS to make it work

Fixed some issues for non-existing keys. Please install new version from github repo and report does it work for you.

I see a similar issue. If I fetch a non-existing key in iOS, the ok handler is called with value null. On Android, the fail handler is called. Based on documentation, on iOS the fail handler should be called.

@jacobg can you provide test case? what version you're using? just launched test for android and every test is pass. according to the test source (lines 48 and 78), there is a check for this issue.

No response, have test for this, test passing


DBZ-639 Removing restriction for none snapshot locking mode so that it can be…

… used for all snapshot modes

@gunnarmorling yeah I had kept it commented thinking would remove it once we are ok with the changes. Have removed all the commented code now.

Rebased and applied. Thanks, @vamossagar12. Could you also send a PR for updating the connector docs accordingly?

@gunnarmorling Thanks. Sure would do that. There's another issue I had opened regarding the behaviour with MyISAM engine tables. Here it is:
https://issues.jboss.org/browse/DBZ-652?filter=-2
Should I mention that as well in the docs as part of the PR sent to the documentation?


'unsafe-eval' for strict CSP policy headers

Hi Guys,
I am trying to use the animate package on the website where I'm setting up Content Security Policy headers, sadly it fails due to 'unsafe-eval' check.
It is caused by :
https://github.com/govau/design-system-components/blob/cc5cb0e693b4350061159bdbc15252d99c34aa42/packages/animate/src/js/module.js#L343
Is it any reason why eval is used here? It would be a minor change to exports.default = AU
I am happy to create PR if require.

Thanks for reporting @kozillla, change appears logical and tests are passing.
Will push this into production asap.


UI - Knowledge - Message presented for unsupported file type is presented in orange color (expect it to be in white)

Steps to reproduce the problem:

Create an agent with knowledge files from one drive folder that has unsupported file types like xlsx
Once folder is synced , ingest all files.

Locate the file with unsupported file type and  hover over the "Unsupported" state.
Notice that the message presented for unsupported file type is presented in orange color

Expected Behavior:
Text should be presented in white like it is done in other places like this one

I did this on purpose to show some sort of warning for unsupported files

The orange is harsh on the eyes and hard to read. Let's go with white.


Rename the generated config file to match the mods name

Hey there!
I've noticed that the config file for this mod is named "htm_config.json". Since this isn't "Hey that's mine" it's a little confusing – at least I was wondering for a second why the server plugin would save a config on the client side.
I've attached a small fix just changing the code to have the file be named "nostrip_config.json" instead for clarity.

Lol, did I really leave that in


WIP: New metrics

TBD

Codecov Report

Merging #38 into master will increase coverage by 1.74%.
The diff coverage is 81.81%.

@@            Coverage Diff             @@
##           master      #38      +/-   ##
==========================================
+ Coverage      80%   81.74%   +1.74%
==========================================
  Files          10       10
  Lines        1055     1063       +8
==========================================
+ Hits          844      869      +25
+ Misses        177      152      -25
- Partials       34       42       +8

Impacted Files
Coverage Δ

phono.go
50.84% <ø> (ø)
:arrow_up:

pipe/pipe.go
69.04% <60%> (-2.39%)
:arrow_down:

metric/metric.go
82.85% <82.85%> (ø)

pipe/runner.go
79.78% <85.18%> (-1.23%)
:arrow_down:

wav/wav.go
83.33% <0%> (-1.76%)
:arrow_down:

pipe/state.go
80.42% <0%> (+3.7%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 39f35f2...75c543f. Read the comment docs.


Italian Translation

I've read on Curseforge that you plan on renaming some creepers, I would like to translate the mod to Italian, but I need to know if I can translate now or have to wait for the "new names update"

I plan on renaming Hydrogen to Ballistic and Electric to Lightning. You can translate just off that. There will also be config locale entries that I'll add in shortly. Just star the repo to stay up-to-date w/ my progress; I'll work on the locale stuff ASAP.

Base Italian translation (for creepers name only) has been created, now I'll wait for other strings to tranlate ^^

You should be all set! Please use the en_us format as your template: https://github.com/T145/elemental-creepers/blob/master/src/main/resources/assets/elementalcreepers/lang/en_us.lang

Maybe radius here? https://github.com/T145/elemental-creepers/blob/master/src/main/resources/assets/elementalcreepers/lang/en_us.lang#L6

Radii is the plural of radius; the category contains more than one radius, and you have the option of configuring more than one radius, hence "Radii" for the tooltip.


Task/transaction detail unit test

What was the issue?

missing unit test in transaction detail component.

What's the fix?

Added unit test  TransactionDetails and TransactionOptinPayoutDetails

Codecov Report

Merging #1891 (fcf98c5) into feature/unit-tests-united (1657017) will increase coverage by 0.43%.
The diff coverage is 100.00%.

@@                      Coverage Diff                      @@
##           feature/unit-tests-united    #1891      +/-   ##
=============================================================
+ Coverage                      31.61%   32.05%   +0.43%
=============================================================
  Files                            584      584
  Lines                          13951    13950       -1
  Branches                        2353     2352       -1
=============================================================
+ Hits                            4411     4472      +61
+ Misses                          9467     9405      -62
  Partials                          73       73

Flag
Coverage Δ

wallet-desktop
32.05% <100.00%> (+0.43%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

...ponents/TransactionDetails/TransactionDetailsTs.ts
100.00% <100.00%> (+60.00%)
:arrow_up:

...ansactionDetails/TransactionOptinPayoutDetails.vue
100.00% <0.00%> (+83.92%)
:arrow_up:


Add scrollbar for long algorithm explanations

Fixes problem of:

By using a horizontal scrollbar when the explanation becomes too long.
If you can think of a more elegant solution (within the possibilities of CSS), let me know.

Great, man. I think this is enough.


Refactor/auro banner

Alaska Airlines Pull Request
Fixes: #7
Summary:
In attempting to fix some overflow issues we were seeing when we imported this into an environment outside the demo.  We noticed that images weren't be clipped as expected.  The demo page itself has overflow hidden set on the exampleWrapper and that was masking issues when we would place the CE in the wild.
In addition,  with the previous implementation changes to one version (billboard) would often require changes in other version like hero or marquee to undo a change that might have only been intended for billboard.  This refactor separates that concern.
Common styles are now separate from any specific variant and are imported as needed.  This allows us to more easily change one version without accidently effecting other variants.
This refactor relies on padding instead of changing max-height, or max-width attributes so it will be much more flexible and gives the control to the person entering the content.
This also introduces an alignLeft feature and includes an example.
The slim attributes previously set a smaller max-height.  After this refactor it's primary purposes is to alter the default padding and would primarily be used in conjunction with the alignLeft and alignRight attributes.
Type of change:
Please delete options that are not relevant.

[x] New capability
[x] Revision of an existing capability

Checklist:

[x] My update follows the CONTRIBUTING guidelines of this project
[x] I have performed a self-review of my own update

By submitting this Pull Request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Pull Requests will be evaluated by their quality of update and whether it is consistent with the goals and values of this project. Any submission is to be considered a conversation between the submitter and the maintainers of this project and may require changes to your submission.
Thank you for your submission!
-- Auro Design System Team

:tada: This PR is included in version 1.1.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Wrong deep link example

[Enter feedback here]
The following example of deep link is wrong:
fsmobile://open?jsbridge;msdyn_workorder;9a98d429-fe1e-e911-a977-000d3a370909
In this document: Use deep links with Field Service Mobile
I tested according to the documentation of resco mobile crm app and found that "jsbridge" is undesired. I removed "jsbridge" and it works.
In summary, correct version is: fsmobile://open?msdyn_workorder;9a98d429-fe1e-e911-a977-000d3a370909

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 9c191d27-97ad-5125-ba90-3cbb509ac91f
Version Independent ID: 54796b6b-14e8-2740-1db8-34f4427d1b69
Content: Use deep links with Field Service Mobile
Content Source: ce/field-service/mobile-deeplink.md
Service: dynamics-365-customerservice
Technology: field-service
GitHub Login: @robertipk
Microsoft Alias: daclar

Thank you for raising this issue! We've added an update for this doc to our backlog!


Bootlint & small fixes

Fixed bootlint issues, Bootstrap updated to latest version, removed unused Font Awesome

dik


Setting.change() method suggestion

Currently, changing the value of a setting through means other than the dedicated dialog is a three steps process:

change value
call the attached onChange function
call Setting.save()

I feel this process could be simplified through a dedicated Setting.change() method that would take the setting's name and new value as arguments, very much like State.setVar().
Setting.change('mySetting', 'new value');

//could replace:

settings.mySetting = 'new value';
setup.mySettingChange();
Setting.save();

I can submit a pull request on the develop branch if it is convenient to do so, cordially, Maliface.

I'd want it to be full get/set pair.  E.g., something like:
Setting.get(name: string) → value: any
Setting.set(name: string, value: any) → result: boolean

I'll take care of implementing it—though I appreciate the offer.  I need to make some changes in the API internals anyway and I'll probably want to do some kind of type validation on the set value.

The API additions ended up being:
/*
	Add a value-type setting.

	NOTE: Value-type settings do not receive a control under the Settings menu.
*/
Setting.addValue(name: string, definition: object)

/*
	Returns the value of the given setting name—equivalent to `settings[name]`.
	Works with any setting type.
*/
Setting.getValue(name: string) → value: any

/*
	Sets the value of the given setting name, saves the settings, and calls the
	associated `onChange` handler, if one exists.  Works with any setting type.
*/
Setting.setValue(name: string, value: any) → result: boolean

Value-type settings must be initialized via Setting.addValue() before they may be used:
// You can omit the definition entirely and just initialize the setting.
Setting.addValue('secret1');

// Alternatively, like other setting types, you can specify a definition to get more functionality.
Setting.addValue('secret2', {
	default : 42,

	onInit() {
		console.log(`${this.name} onInit:`, this);
	},
	onChange(data) {
		console.log(`${data.name} onChange:`, data);
	}
});

Very nice!
Love to see settings objects of arbitrary type, thank you for the continued development effort!


ScrobbleItem seems to not work with the current version

Hello,
Unfortunately I can't get ScrobbleItem to work. I am authorized in LastFM in MusicBee (I get new scrobbles automatically), and yet "Scrobble" button does nothing. :(

I tested it with MusicBee 3.5.8698 and it seems to be working fine. Are you able to attach an error log (MusicBee -> Help -> Support -> View Error Log)?

My apologies, working now. Not sure what is was. Simple, yet amazingly useful plugin, thanks for that.

No, not quite right. I narrowed it down a bit further.
So you have different "artist" field in MB... You have "display artist" and "actual artist". The latter is actually a list, where every item is a singular artist who participated in this song.
Anyway, in some cases you may want to have "display artist" different from "actual artist". For all intents and purposes, you want "display artist" to be considered this song's artist, but you want to have all artists in the database. For example, this could be for correct scrobbling: more often than not, Last.fm only accounts for one artist and not the group.
If that's the case, the plugin unfurtunately will ignore "display artist" and will just combine all "actual artists" instead. Here is what I mean.

In this case, instead of expected "Airelle Besson", it will scrobble artist "Airelle Besson, 123".

Should be fixed in 31b14c54128429660ddf8e69f5de99bad8ec2841, will make a new release soon


Convert test vcs to pytest

Split the former classes of test_vcs.py into separate modules and convert them to py.test:

test_identify_repo.py
test_is_vcs_installed.py
test_vcs.py
test_vcs_prompt.py

This PR does not introduce any new concepts. Instead it reuses the skip_if_markers of master and monkeypatch. I highly recommend running these tests on your local setup due to the skipif markers.
As this PR is rather large I completely understand if you decide against merging it for #410.
Please let me know your thoughts! :smiley:

I like how this breaks up the monolithic test module into a number of smaller more manageable ones.

Happy to hear that :blush:


Snyk is reporting high vulnerability in "org.json.json" dependency

What happened?
Snyk is reporting a high vulnerability in "org.json.json:20140107" and recommends upgrading to "org.json.json:20230227" or higher

https://security.snyk.io/vuln/SNYK-JAVA-ORGJSON-5488379
https://security.snyk.io/vuln/SNYK-JAVA-ORGJSON-2841369

Dependency location:
https://github.com/wix/Detox/blob/master/detox/android/detox/build.gradle#L136
What was the expected behaviour?
No response
Was it tested on latest Detox?

[X] I have tested this issue on the latest Detox release and it still reproduces.

Did your test throw out a timeout?

[ ] I have followed the instructions under Identifying which synchronization mechanism causes us to wait too much.

Help us reproduce this issue!
Do snyk test
In what environment did this happen?
No response
Detox logs
No response
Device logs
No response
More data, please!
No response

Thanks for the report @akkadaya. I've opened a PR: https://github.com/wix/Detox/pull/4174


About extension error.

VSCode Version:  1.17.0 (1.17.0)
OS Version: macos 10.12.6

Steps to Reproduce:
1.open extension
2.choose any installed extension
3. uninstall
4. "sure to uninstall" choose no.
5.

Reproduces without extensions: No

Can you please try collecting the full information about this error using  the developer console. To do this: In VSCode run the Toggle developer tools command to open the developer console, then look in the console for any error messages. Please share the full stack of these errors

Closing as not actionable without additional information


Search Overlay broken in Firefox at $phone on Windows

Pseudo element used for vertical-align: middle is breaking this.

assigning to @oknoway as I believe he's working on a fix right now.

will be covered in next release thanks to champion @oknoway


[WIP] Stream filters

Works on #4627.
I have followed the following approach:

Each realm filter has a list of streams it is applicable to (empty = no restrictions).
All realm filters that have restrictions on them would be given higher precedence.
All generic realm filters would be added after the above filters in the inline processor.

However, given how py-markdown works, once a filter matches, it doesn't look ahead for further filters on the same piece of text:
        if not match:
            return data, False, 0

        node = pattern.handleMatch(match)

        if node is None:
            return data, True, len(leftData)+match.span(len(match.groups()))[0]

This particular problem has been fixed upstream and the current logic supports no-op for handleMatch in Python-Markdown/markdown#629:
        new_style:
            match = None
            # Since handleMatch may reject our first match,
            # we iterate over the buffer looking for matches
            # until we can't find any more.
            for match in pattern.getCompiledRegExp().finditer(data, startIndex):
                node, start, end = pattern.handleMatch(match, data)
                if start is None or end is None:
                    startIndex += match.end(0)
                    match = None
                    continue
                break

It IS possible if we have the same regexes for two filters to combine the two filters into one that applies if,else logic to decide which filter to use, however, updating py-markdown should allow for neater and reliable code in this scenario.
Testing Plan:
Partial automated test coverage (first 2 commits).

Do we need the is_stream_filter field on the model?  I would have imagined we'd just use stream_ids = None for the case where there aren't any.
I think also stream_ids should probably be an ArrayField?


Do updates delete the previous version?

Does the act of installing an update first delete the previous version? I am trying to figure out why my app settings (iOS) are not persisting across app updates, and I can't find anything in the docs about it here.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: f3659cbf-c706-9af5-b3ed-9e0cdb5f2819
Version Independent ID: 97d69564-1130-e541-9362-c9272983784d
Content: Install a Build from App Center - Visual Studio App Center
Content Source: docs/distribution/installation.md
Service: vs-appcenter
Sub-service: app-center-distribute
GitHub Login: @JoshuaWeber
Microsoft Alias: JoshuaWeber

Normally for iOS & Android, installing an app that you've previously installed overwrites the app.
However, depending on where & how that data is stored for the app, some data might be preserved. I believe in most cases the logic applied is based on how you're managing the app and you should be able to experiment & test with the scenario locally.

Hi @sublime392 ,
Normally iOS app user data is not removing on app update. If, for example, you store your settings in UserDefaults, then you should be able to access a previously stored data after you update the app using the App Center Distribution service.
If the issue still persists for you, please share more context about the method you use to store your app settings.


macos: use getentropy from libc

This has been added in the mean time.

@bors r+

:pushpin: Commit 5e30f0fcef07e0ebdec31441f61d09a257ad78c9 has been approved by RalfJung
It is now in the queue for this repository.

:sunny: Test successful - checks-actions
Approved by: RalfJung
Pushing d0147ff3fe84cd8c5b47f582478ca7dfde90f14d to master...

:sunny: Test successful - checks-actions
Approved by: RalfJung
Pushing d0147ff3fe84cd8c5b47f582478ca7dfde90f14d to master...


Clone function for In-Memory Grids

I have attempted to use the Clone function for an In-Memory Grid and find that the Save button does not work and that the applyChangesButton is hidden in the GridEditorDialog. I do not get any console errors.
Is this function not yet supported for In-Memory Grids or have I missed something?
Thanks for any assistance provided.

It is not supported for in-memory grids.


MODDCB-97 Adding missing permission in module descriptor

Purpose
The purpose of the PR is to implement MODDCB-97
Approach
Added the missing permission in module descriptor.
TODOS and Open Questions

[ ] Use GitHub checklists. When solved, check the box and explain the answer.

Learning
Describe the research stage. Add links to blog posts, patterns, libraries or addons used to solve this problem.

Created from wrong branch. hence, closing PR


chatClient.onRegister is not a function

Bug Report
Getting chatClient.onRegister is not a function for following the basic "connecting to chat" docs
Code
const twitchClient = Twitch.withClientCredentials(
        process.env.TWITCH_CLIENT_ID || '',
        process.env.TWITCH_CLIENT_SECRET || '
');
const chatClient = await ChatClient.forTwitchClient(twitchClient);
chatClient.onRegister(() => {});

Expected behavior
connecting to chat
Actual Behavior
chatClient.onRegister is not a function
Environment
Tried with latest, and then the new pre-releases, same thing.
Node: 13.1.0
OS: Ubuntu

Found it... my bad


Allow for forward slashes to be present in strings without the escape character preceding it

While JSON allows for the escape character to precede a forward slash; it isn't required. This resulted in a bug where regular forward slashes were being parsed out entirely from valid json:
{"test":"the/quick/brown/fox"} -> {"test":"thequickbrownfox"}
Stack overflow comment on the behavior: https://stackoverflow.com/a/1580664
This pull request checks for forward slashes in a string, but don't have the escape character before them, and adds in the token as is.

@pigeonlaser Thanks for the PRs.


add pix2nerf and ICARUS

Pull requests

add Pix2NeRF: Unsupervised Conditional π-GAN for Single Image to Neural Radiance Fields Translation in Generalization
add ICARUS: A Lightweight Neural Plenoptic Rendering Architecture in fast training

Hi. I've just joined to help maintain the list. Any chance of resubmitting this as there's now conflicts.


[FEA] Remove the need for the spark.rapids.sql.hasExtendedYearValues config

To help support customers with optimal performance out of the box, we want to enable the spark.rapids.sql.hasExtendedYearValues setting to be true by default.
The scope of this will involve any additional implementation and validation to be confident in the setting to be on by default.

Looks like this one is already on by default: https://github.com/NVIDIA/spark-rapids/blob/branch-23.04/sql-plugin/src/main/scala/com/nvidia/spark/rapids/RapidsConf.scala#L730-L738

The spark.rapids.sql.hasExtendedYearValues=true indicates your dataset has extended year values, which we do not support, and we will fall back to the CPU.  To run on the GPU this config needs to be set to false.
We need to add support for handling extended years and remove the need for this configuration.

I have filed the following issues against cudf and spark-rapids-jni. Depending on where this fix will be, the other one should be closed out


Minor update to devtools readme

Hey, I just made a Pull Request!
Adjusted the README for the devtools plugin since this step needs the same permissions as the one prior as well.
The test permissions has also been updated in line with https://backstage.io/docs/permissions/writing-a-policy#conditional-decisions since the user parameter wasn't defined yet
:heavy_check_mark: Checklist

[ ] A changeset describing the change and affected packages. (more info)
[ ] Added or updated documentation
[ ] Tests for new functionality and regression tests for bug fixes
[ ] Screenshots attached (for UI changes)
[ ] All your commits have a Signed-off-by line in the message. (more info)

I'll sort out the changeset / commits in a fresh PR, sorry for the notifications


Action timing out when new node versions are released

I am using this in a job:
name: Use Node.js ${{ matrix.node-version }}
uses: actions/setup-node@v1
  with:
    node-version: ${{ matrix.node-version }}

and node-version 13.x, but my workflow takes 10+minutes just to complete use node. Any idea why or anyone else having this problem?

Same here, It looks like I'm sometimes timing out and getting

Premature close
Waiting 16 seconds before trying again
Premature close
Waiting 18 seconds before trying again
##[error]Premature close

and sometimes it's working fine but still taking 7-11 minutes per install for some reason (12.x)

good to know other people are having issues - seriously stalling my pipeline 😞

Same here, We are using node 12.x.

Same. You can see the workflow on an open source project experiencing this here. From my experience this just started happening recently.
As you can see the setup node step took 7 minutes and 34 seconds 😱

One of the major issues of this action is the fact that there is next to no logs that get printed. I brought this up in #90 for the version it's using. But this is another situation where we need logs!!

This is a serious issue if one's pipeline doesn't have default timeout setup. This will cause a lot of people's CI to hang for up to 6 hours. This is not wasting MS' resource, but is wasting resource for other paying customers. Please fix this!

this did cost us a lot of money already. please have a look!

We have the same problem. Today every pipeline is failing because of this. We are using Node.js 12.x.

Experiencing similar issues with Node 12.x version. The step is either timing out or takes up too much time. (~25 mins)

Cloned the repo and ran the unit tests, it would appear that the issue is with nodejs.org
::debug::Failed to download from "https://nodejs.org/dist/v10.16.0/node-v10.16.0-darwin-x64.tar.gz". Code(500) Message(Internal Server Error)

It's not consistent though, a re-run of tests can get past this issue.

Tried this action for the first time last night and thought 5-10+ minutes setup is natural until i saw this issue. +1

Just browsing random pages on https://nodejs.org sometimes gives a 500 error as well, so it looks like this issue is indeed on their end

It's being tracked in the node upstream repo https://github.com/nodejs/node/issues/32683

@defionscode Thanks for linking to the node repo issue.
 😢

Depending on what you need, you might skip this action completely:
All runners have node 12.16.1 preinstalled (e.g. https://github.com/actions/virtual-environments/blob/master/images/linux/Ubuntu1804-README.md, search for "Node.js")

Another alternative is to run your job in a container :
your_job:
  runs-on: ubuntu-latest
  container: node:10.9

I have to set the registry-url and the scope in my workflow. And I have the same issues since today. Last week it runs in 1-2 min, but today the action fails or it durates up to 20 min. :(

@Raul6469 won't work if you depend on the default dependencies in the Github containers like the AWS CLI. Although I think that's something one should plan half a man-day for..

This definitely warrants a feature request to support mirrors

cc @damccorm @ericsciple @bryanmacfarlane
I'm seeing this issue as well (on Mac and Linux it's taking me 5+ minutes for this action to run, Windows for some reason seems fine)

@konradpabjan Node itself is having an outage right now that is causing this - https://github.com/nodejs/node/issues/32683

Omitting this whole package made it super fast again:
name: Use Node.js ${{ matrix.node-version }}
uses: actions/setup-node@v1
  with:
    node-version: ${{ matrix.node-version }}

It will have node 12.x by default, so no need to use this package when you don't care about the Node.js version.

I had an issue with time out set up to 6h over month ago because my script hanged.
Yes, it ate up all my minutes for the month. Who sets a default timeout to 6h?!
For me it is a trap. I wrote email to github support hoping they could compensate me some minutes because 6h timeout default is not clearly written in the docs but they just redirected my to "Product Team" which did not reply to me since.
Since then I set up all my jobs with a reasonable timeout.
And now/today I am wasting my time and github minutes for trying to run builds multiple times hoping it will pass without Unexpected HTTP response: 500 or ##[error]Premature close. I am really mad at this point.

If you're finding this thread and blocked by timeout issues, two things you may want to try:

Removing this step: base images now have a version of Node installed -- so if you don't specifically need a certain version (for doing asset-type stuff not running your whole app), try removing the step
Setting a timeout: your builds will fail faster, not run up your minutes, etc -- add timeout-minutes to your jobs (try something like 1.5x your normal runtime) https://help.github.com/en/actions/reference/workflow-syntax-for-github-actions#jobsjob_idstepstimeout-minutes

For refereenc software installed on default on runs-on: https://help.github.com/en/actions/reference/software-installed-on-github-hosted-runners

@mieszko4 - yes, if you don't need or want to validate on a specific version or version spec (range) of node, then you can rely on the one that's globally installed on the machine image.
Note that the global version on the image will slide (13, then 14, etc.).
The core value of setup-node is using a specific version I want to test my code against lts 8, 10, 12, and latest in a matrix in parallel.
That said, we are fixing this issue now so that you can have the best of both worlds.  You can lock to an LTS (12.x) and do matrix testing and never do a download.
If it's not matching a major LTS, then it will download.
So part 2 of the work (also starting now) is the build a cache (backed by CDN) of versions so when we do read through, it hits our cache.
I might add a flag in the action to force reading through and getting absolute latest if you need that since there will be some latency on both the images and the cache.

Note that the global version on the image will slide (13, then 14, etc.).

A bit off-topic, but wondering what's the motivation of sliding the node in non-LTS increments in the global images. Since node 8, I have had very few cases in production, when latest-greatest node was desirable (especially without significant amount of testing first).

The core value of setup-node is using a specific version I want to test my code against lts 8, 10, 12, and latest in a matrix in parallel.

Very nice clarification, thank you. I believe it could have some better emphasis in readme (there's a good usage example, but no why motivation).

Thanks for the note about setting timeout. 1.5x your typical time is a good suggestion.

We also have been hit quite hard by this issue, and rigorous timeouts on every job indeed saved our a$$es in this case, otherwise we would certainly hit the limit of minutes quite fast.
\cc @Kerizer

@dentuzhik - I should have clarified that hosted images should be installing LTS globally so the real scenario would be sliding from 10 to 12 and then 12 to 14.
I'll update the readme with all of this but also note that one more variable is self-hosted.

If there will be a PR, I would happily have a look at it 🙇

Seems we already using @actions/tool-cache in master branch 🤔
https://github.com/actions/setup-node/blob/83c9f7a7df54d6b57455f7c57ac414f2ae5fb8de/src/installer.ts#L149

@amio - yes, this action downloads from the node distribution to the tool-cache folder.  It does if it can't match the semver version spec to what's already in the tool-cache folder.  In self-hosted runners, that cache fills up on use and gets faster over time.  In hosted runners, it depends on whether that cache is prepped with likely hits (e.g. latest of every LTS major version line).  Remember that hosted VMs are a fresh machine every time.  Thus the mention of this issue above to prep that cache as part of our image gen process.  Doing that will mean virtual 0 second resolution of 8.x, 10.x, 12.x specs and no reliability issues.
Part 2 of the work refers to a different cache.  An off VM (CDN) where we cache all the node distributions so everyones workflows aren't hitting the node distribution directly (which is not a CDN).  We can also get better locality and more reliability from a CDN.  This is essentially what was suggested in the node issue.  This is not a trivial task but we're working on it now.  You can see the toolkit start here.  The vm gen to populate that cache isn't OSS yet.  It's early and we're sketching it out.
So essentially, it will be (1) check local VM cache (great for self hosted, prepped on hosted) then (2) if no match locally, download from CDN then (3) if still no match, fall back to node dist.
Hope that helps clarify.

I think it would be beneficial if Github was opting to mirror and effectively the Node binaries here if it wants Github Actions to be taken even remotely serious for production use.

I think it would be beneficial if Github was opting to mirror and effectively host the Node binaries if it wants Github Actions to be taken even remotely serious for production use.

its possible to set registry-url: https://registry.npmjs.org/ without uses: actions/setup-node@v1 ?

Update: v2-beta is available which downloads from a releases cache for additional reliability.  It falls back to node dist on miss or failure.  We also added latest of each LTS directly on the image so if you reference a major version binding ('10', '12', etc.) it should be virtually instant with no reliability issues from downloading.
More here: https://github.com/actions/setup-node#v2-beta
Note that this is the planned solution to this problem.

@bryanmacfarlane It looks like v2 has been released (not in beta). What is the status on this issue? Are there still more planned changes to improve the reliability here or does v2 resolve everything you have planned?

@bryanmacfarlane It looks like v2 has been released (not in beta). What is the status on this issue? Are there still more planned changes to improve the reliability here or does v2 resolve everything you have planned?

Hello @patrickk. Thank you for your report. Firstly the action will try use nodejs (LTS) from toolcache preinstalled on the hosted images. If the action do not match version it will try to download nodejs (LTS) from node-versions. If the action does not find a version in the node-versions, it'll try to download it from https://nodejs.org/dist
Could you please create an issue with public repository or repro steps ?

Hello @patrickk. Thank you for your report. Firstly the action will try use nodejs (LTS) from toolcache preinstalled on the hosted images. If the action do not match version it will try to download nodejs (LTS) from node-versions. If the action does not find a version in the node-versions, it'll try to download it from https://nodejs.org/dist
Could you please create an issue with public repository or repro steps ?

sure @dmitry-shibanov! Thanks for your reply.
Unfortunately I can't create a public repo since a lot of it is private but I can detail out the steps:

Workflow checks out code
setup-node@v1 tries downloading 16.11.11
500s

(there is a version discrepancy but I'd intermittently get 500s on nodejs.org's dist for various versions).
Read somewhere that this usually happens with new releases for node, but saw that the latest release in dist url was for Feb 22, while the error above occurred Feb 28.
We were able to get past this by letting the action fail a bunch/letting it run for 5+ minutes, and one of them finally succeeded.
Haven't been able to reproduce (also I updated our workflow files to use v2 as of this morning).

Hello @patrickk. Thank you for your response. Could you please switch to the v2 tag ? For the v1 tag the action tries to download nodejs from dist.

Hello everyone. For now I'm going to close the issue because the support for node-versions repository was added. Besides, lts node versions are pre-cached on the images.


🧑💻: Add Table of Contents to README

Currently, the README lacks a table of contents, making it challenging for users to navigate sections quickly. Adding a table of contents will enhance readability and allow users to locate information faster.
@Avdhesh-Varshney I would like to work on it.
Please assign it to me under gssoc-ext and hacktoberfest.

Assign this to me


Pbi 5526: Standardize passing of distribution name and version

The Android handleRegister method expected these as part of the configuration key's value in the argument map, and iOS was expecting them as the values for the distributionName and distributionVersion keys in the argument map, and the dart code was passing a copy in each spot.
This standardizes it to use the Android convention and removes the copy from the dart code.

LGTM


[Fix] LibreOffice does not support multi-threading

From @hkkenneth on November 14, 2016 17:4
Copied from original issue: KHP-Informatics/cogstack#12

@hkkenneth could we update the docs to show using this for scaling the pipeline for Patient Timeline  although I wonder if this should be treated using the modular mechanism suggested in #17

I wonder if we might investigate another tool?
http://documents4j.com/#/
https://angelozerr.wordpress.com/2012/12/06/how-to-convert-docxodt-to-pdfhtml-with-java/
alternatively a pool of isolated Open Office instances in Docker containers as a temporary workaround

From @hkkenneth on May 12, 2017 23:37
You mean pull this logic out as a plugin? Yes that seems to be a cleaner solution. There was a bit of "history" behind this current implementation... the PDF / thumbnail generation feature was written before I had the "plugin" idea. So this feature went straight into master even though no other projects need it at the moment.
I am a bit hesitate to write this in the doc as "standard feature" yet because I have never confirmed our SLaM jobs really ran stably in a reasonable "multi-threading" scenario (e.g. 8 threads or more).
Some more testing in the new dev VM would be helpful.

On 13 May 2017 at 00:37, Kenneth Lui<EMAIL_ADDRESS>wrote:

I am a bit hesitate to write this in the doc as "standard feature" yet
because I have never confirmed our SLaM jobs really ran stably in a
reasonable "multi-threading" scenario (e.g. 8 threads or more).
Some more testing in the new dev VM would be helpful.

>> ok sure...  I'll see if the dev env is cleared to be used again. Would
be good to test.

--

Amos Folarin


Phase 2 - Initial workflow implementation

Phase 2 items included:

Separate payload converters from payload codecs in data converters
Typed workflow functions on client
Typed workflow definitions
Basic signal/query support including dynamic signal/query
Executing activity, local activity, and child activity
Timers and conditions
Cancellation of things inside workflows
Workflow runtime backed by event loop
API preparing for future sandboxing of workflows

Phase 2 TODO:

~Payload codec~ (EDIT: Done)
Async activity
~Child/external workflow signal~ (EDIT: Done)
~External workflow cancel~ (EDIT: Done)
~Workflow logger~ (EDIT: Done)
~In-workflow signal/query handlers~ (EDIT: Done)
Fatal worker errors
Search attributes
~Continue as new~ (EDIT: Done)
Patching
Stack trace query
Lots of little TODOs sprinkled throughout
More tests
"Real" public documentation (and trim down README to mostly just links)

Notes:

The internals were reworked a few times in order to optimize for maintenance (which is the highest burden of these SDKs in my experience). A lot of effort was spent on clarity and simplicity.
I apologize for such a large PR, but it was the smallest I could make and capture all things needed to be confident in the API design.
The documentation in the README is intentionally sparse and bulleted. The expectation is that the documentation team can take it and run with it. Once public Python documentation appears, I expect to trim the README down to mostly just links and build/dev details.

Don't want to block though with the limited time I have right now.

@bergundy - Since you are the only one probably able to do a deep review here, I think it's best that we wait until you have time. I don't think this is urgent, though I will be adding features while this PR lives but none are huge. Just review when you can, no rush at all.

I apologize for the force pushes. They are minor attempts to fix whatever I have done recently to make tests flaky on top of the custom-signal/query-handler registration that I committed.

Is there a place where you prevent generating new commands after a terminal workflow command has been emitted?

Not directly. Rather I am forcing the loop to stop, which should prevent any other command generation, in the two places that can generate terminal workflow commands - workflow function return or signal handler failure.
See the _force_stop_loop field. Though now I need to revisit it to change the comment I use above its definition (no longer valid) and make sure I set it on workflow success instead of just workflow failure. I will update that shortly.

Is there a place where you prevent generating new commands after a terminal workflow command has been emitted?

See the _force_stop_loop field.

Well, it looks like the _force_stop_loop isn't gonna work because I want to run queries after a terminal workflow command. I have chosen to run the query handler inside the event loop so it has the local event loop as context (technically I allow an async query handler though one could argue I should not).
So I am going to add something that removes non-respond_to_query commands after a complete_workflow_execution or fail_workflow_execution command. Due to how the commands are built in a copy-on-write way, I may just prevent them from being added instead of culling them at the end.

Last call on this PR. While I will be adding more tests throughout the day and maybe also updating the core submodule, it is basically ready to merge (with all outstanding phase 2 TODOs to become issues).

Merging. All outstanding tasks have been created as issues.


[MINOR][DOC] Fix Java example code in Column's comments

What changes were proposed in this pull request?
Fix scaladoc in Column
How was this patch tested?
None

Can one of the admins verify this patch?

Can one of the admins verify this patch?

Can one of the admins verify this patch?

ok to test

Test build #94555 has started for PR 22069 at commit 8520df8.

Test build #94555 has finished for PR 22069 at commit 8520df8.

This patch fails SparkR unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/94555/
Test FAILed.

Test build #4239 has started for PR 22069 at commit 8520df8.

Do we need to update the following similar examples, too?
Column.scala
   * {{{
   *   // Example: encoding gender string column into integer.
   *
   *   // Scala:
   *   people.select(when(people("gender") === "male", 0)
   *     .when(people("gender") === "female", 1)
   *     .otherwise(2))
   *
   *   // Java:
   *   people.select(when(col("gender").equalTo("male"), 0)
   *     .when(col("gender").equalTo("female"), 1)
   *     .otherwise(2))
   * }}}

functions.scala
   * {{{
   *   // Example: encoding gender string column into integer.
   *
   *   // Scala:
   *   people.select(when(people("gender") === "male", 0)
   *     .when(people("gender") === "female", 1)
   *     .otherwise(2))
   *
   *   // Java:
   *   people.select(when(col("gender").equalTo("male"), 0)
   *     .when(col("gender").equalTo("female"), 1)
   *     .otherwise(2))
   * }}}

Test build #4239 has finished for PR 22069 at commit 8520df8.

This patch fails SparkR unit tests.
This patch merges cleanly.
This patch adds no public classes.

Yea if there are more instances found, we better fix them together

retest this please

Test build #94595 has started for PR 22069 at commit 8520df8.

Test build #94595 has finished for PR 22069 at commit 8520df8.

This patch fails due to an unknown error code, -9.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/94595/
Test FAILed.

retest this please

Test build #94613 has started for PR 22069 at commit 8520df8.

Test build #94613 has finished for PR 22069 at commit 8520df8.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

retest this please

Test build #94620 has started for PR 22069 at commit 8520df8.

Test build #94620 has finished for PR 22069 at commit 8520df8.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/94620/
Test PASSed.

I'm going to merge this, as the additional example quoted above should actually work, assuming one imported the 'col' function. In Java, people("foo") would be wrong but col("foo") is not (necessarily).


GoodTwitter suddenly not working anymore

Describe the bug
Twitter is in the new layout again whenever I open it. Have tried all the possible fixes that were listed but to no avail.
To Reproduce
Open twitter.
Expected behavior
Expected twitter to be in the old layout but it is not.
Desktop:

Windows 8.1
Chrome
Version 71.0.3578.98
Not using the GoodTwitter Beta
GoodTwitter Version 2.0

Additional context
Has been working fine since I downloaded it until yesterday. Was even working yesterday just fine until the middle of the afternoon.

Similar using Chromium
Version 65.0.3325.181 (Official Build) Built on Ubuntu , running on LinuxMint 17.1 (64-bit)
Additional: When starting browser from boot the new interface would show, then reloading the old interface would start. This no longer it just starts and runs with the new interface.

For my Chromium 69, I found that extraHeaders is invalid for the extraInfoSpec parameter of AddListener in background.js.
I removed the extraHeaders, then it started working again.
I hope it will help you. Thank you.

ADDITIONAL: Still working on firefox. No issues to report.
66.0.3 (64-bit)
Mozilla Firefox for Linux Mint
mint-1.0

Same issue this morning 11/19/2019. Was working fine on Chrome (old version) yesterday. Now. it's not. Is working in Firefox for latest version.

Having this issue since around the 18th, myself. It was working until then, and it works when logged out, but when I login it breaks. I'm using Chrome 53.

I'm having the same issue, all of a sudden GoodTwitter stopped working 2 days ago on my Chrome and it took me straight to the new twitter which I dislike very much. I've tried every trick in the book to fix this but unfortunately didn't succeed.

Accidental break through. If use the incognito mode with chromium, I am logged out of twitter, but I also get the old interface again.
My info again.
Chromium Version 65.0.3325.181 (Official Build) Built on Ubuntu , running on LinuxMint 17.1 (64-bit)


[PLANNED]: Support for tRPC Version 11

Soon. How soon is soon?
So, as I'm sure some of you are aware, version 11 of tRPC is due imminently (we're currently looking at version 11-rc.447).
However, I'm making no commitment to supporting version 11 until it has passed through rc phase, and is on a stable track and widely used / in circulation.
I anticipate that that shouldn't be too far away, I will update this thread as to progress and discussions.

Just another update from my side to anyone who will read this, tRPC version 11.0.0 still looks to be in rc phase, but it is nearing release. As soon as that drops, I will start work on that ASAP.


undefined symbol: PyFPE_jbuf

ImportError: /root/anaconda3/envs/NLP/lib/python3.5/site-packages/pkuseg/feature_extractor.cpython-35m-x86_64-linux-gnu.so: undefined symbol: PyFPE_jbuf
ubuntu, pip install pkuseg
any ideas?

#73
#51
These two is similar

solved，strange problem.

@LCorleone Hi,could you plz tell me how did you solve this import error of pkuseg?

@qq184861643  reinstall

@qq184861643 My experience using pkuseg with python3.5 asserted this error too, and reinstalling didn't work. Then I swiched to python3.6 and install, everything goes well now.


Multiple FFMPEG instances

Feature request here.
Let's enable multiple camera instances/streams like in FFMPEG CAMERA.
I have (like many others I guess) multiple devices on my HomeKit network where I can see the Intercom camera preview and right now video stream available only on first device there notification/stream was opened. So, if I have enabled camera notifications/preview on my Apple TV - it will be visible there but same time on my watches or on iPhone I can't see video feed.
Is this possible to implement?
Thanks!

i forgot to mention it, but could you check the latest beta to see if that works for you?

@rudyberends It works! Awesome! Any news about two way audio and HKSV?

great. I will close this request.
I haven't really worked at the intercom implementation anymore, but I will look into it.


[WFCORE-5885] Add a transformed elytron subsystem for Jakarta EE 9+

https://issues.redhat.com/browse/WFCORE-5885

CI will probably need to run again once the in progress release has concluded.

Core - Full Integration Build 11536 outcome was FAILURE using a merge of 9f9cf64b3b9a5a50e1f70ce356954568cb13e126
Summary: Exit code 1 (Step: Build core (Maven)) (new) Build time: 00:00:30

Core - Full Integration Build 11396 outcome was FAILURE using a merge of 9f9cf64b3b9a5a50e1f70ce356954568cb13e126
Summary: Exit code 1 (Step: Build core (Maven)) (new) Build time: 00:00:35

Core - Full Integration Build 11397 outcome was FAILURE using a merge of 9f9cf64b3b9a5a50e1f70ce356954568cb13e126
Summary: Exit code 1 (Step: Build core (Maven)) Build time: 00:00:58

@darranl This looks good. It looks like the BC dependencies need to be changed to the *-18on is all. I do see there are some hard-coded dependencies versions in the POM, but that could be okay as well.

I am just fixing the bouncy castle dependencies in the pom, the hard coded dependencies are copied over from the Elytron subsystem - they should probably be fixed at some point but I don't think that needs to happen in this temporary pom.


449/support instrumentation key appinsights

Issue Number: (Link to Github Issue or Azure Dev Ops Task/Story)
Summary
Support configurable logging configuration through instrumentation keys
Changes

List of comprehensive changes

Checklist

[x] Local Tests Passing?
[x] CICD and Pipeline Tests Passing?
[ ] Added any new Tests?
[x] Documentation Updates Made?
[ ] Are there any API Changes? If yes, please describe below.
[x] This is not a breaking change. If it is, please describe it below.

There are no tests added because -
As per Microsoft official documentation, we cannot have 'AddAppInsightsTelemetry()' call as part of setup() or verify() methods of Moq. So, the only thing we can verify is whether appropriate log statements are created based on what is provided - Instrumentation key or Connection string.
This is a static class, making it impossible to create mock of the Logger.
Eventually, we would want an end to end test that works with the real app insights endpoint. But this needs further discussion on whether that should be part of sharing.

There are no tests added because - As per Microsoft official documentation, we cannot have 'AddAppInsightsTelemetry()' call as part of setup() or verify() methods of Moq. So, the only thing we can verify is whether appropriate log statements are created based on what is provided - Instrumentation key or Connection string. This is a static class, making it impossible to create mock of the Logger.
Eventually, we would want an end to end test that works with the real app insights endpoint. But this needs further discussion on whether that should be part of sharing.

At least manually testing was performed with both env vars? I'm asking since the new env (ApplicationInsights_Instrumentation_Key) is not the 'standard' used when setting it.

Yes, verified with both the env variables and ensured that the logs are flowing through.


AM Updates

@amorning3 Thanks Ardia!  Please note that after this merge I changed the course title (as shown on this page) to exclude IBM name, but left ICF in the first paragraph.

Welcome to the Serverless Computing - Developer I - using Cloud Functions
^ I think you have to remove the word "the", unless you put the word "course" at the end.


Expressive 3.0 fixes

Fixes:

added constants visibility (to public)
removed unnecessary type casting
removed default property value
optimized imports

Thanks, @webimpress!


consider using thebelab

https://thebelab.readthedocs.io/en/latest/
https://jupyter-sphinx.readthedocs.io/en/latest/#thebelab-support

kinda redundant with https://github.com/ianhi/mpl-interactions/issues/120


[proposal] Use stable address/account as canonicalId in resolved DID Documents

Is your feature request related to a problem? Please describe.
Top-level names can expire or be detached from the user in other ways, so to ensure a continuance of connections and interactions with others who a person or entity has engaged with, it is best to use a stable Canonical ID.
Describe the solution you'd like
Output the stable account/address as the canonicalId in the resolved DID Document.
Describe alternatives you've considered
There are no other standard or reliable alternatives to this.

Thanks for the proposal!
Is there a way to map a DID to a canonicalId, that is an improvement to the result provided by the DID method resolver?
Or, perhaps I'm not understanding this issue enough. Can you provide some examples?

The canonicalId field would just be set to a DID representation of the base account/address that owns the name (of which I believe there exists one), and using the canonicalId field in the DID Document instructs the resolving party to use that inside their systems to create associations instead of the top-level name. Think of names like your Twitter Display Name, and your actual canonical ID as the unchanging stable GUID in the Twitter db. This is probably just a safer paradigm in my opinion, because, if used properly, it should avoid cases where people lose their names and others can masquerade as them.

I think the reason why I'm still confused a bit is that veramo doesn't enforce a relationship between a name and a did, or between a did and an address.
There are addresses derived from keys that are linked to a did, and I suppose a relationship can be created between them and presented as canonical ID, but these addresses are not stored individually in a db (yet?..). They are just derived when required.
I still feel that I'm misunderstanding your request so if I'm way off base please correct me.

@mirceanis I was made aware by @awoie that this may not be the right repo, and that there is one for ENS DIDs that this is more appropriate for. While I don't personally use ENS, I think it would be good for that method to anchor on canonical IDs that aren't subject to some of the issues I outlined.

Yes, that makes a lot more sense, and I agree!
I suppose this is the right repo for it: https://github.com/veramolabs/did-ens-spec


panic when running README example

When running the quickstart code, I get
$ create-gpui-app --name my-app                                                                                08/12/2024 02:24:50 PM
thread 'main' panicked at /home/nathanmcintosh/.cargo/registry/src/index.crates.io-6f17d22bba15001f/create-gpui-app-0.1.2/src/main.rs:65:60:
called `Option::unwrap()` on a `None` value
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

Looking at the relevant line of code, it looks like it is looking for a template that doesn't exist, even after cargo installing the tool. I'd guess maybe it's not being installed as part of the cargo installation?
Cloning the repo, and running cargo package --list to see what gets included during installation, I get:

.cargo_vcs_info.json
.gitignore
CHANGELOG.md
CODE_OF_CONDUCT.md
CONTRIBUTING.md
Cargo.lock
Cargo.toml
Cargo.toml.orig
LICENSE
README.md
cliff.toml
src/main.rs

But not anything from the template folder.

same error with me

same error with me

+1

Hello, Thanks for the detailed report. Yes I could confirm this on my end. I did some research and it seems like cargo does not track any unused crates with a manifest file and hence none of the templates are being packaged with the tool. I have fixed this in #21 and it should be reflected in the next release.


⚠ Bofrost.de has degraded performance

In 5e02262, Bofrost.de (https://www.bofrost.de) experienced degraded performance:

HTTP code: 200
Response time: 1623 ms

Resolved: Bofrost.de performance has improved in 98c3374.


Link lib and header where ./configure expects

XLA had one test flake due to OOM. Going to just merge this anyways

will someone help to cherry-pick this back to master branch? tks.

@nbcsm yes this will make it's way back to master. Tagging @case540 who will do the merge.


Add support for latest algorithms

There's two new algorithms that have been adopted to the JWT universe, specifically JOSE

~EdDSA~
ES256K

jwt-cpp could be expanded to support these as well

Looking at the spec ES256K is probably identical to ES256, but uses a different curve.
EdDSA seems to be supported by OpenSSL as well so implementing both of them should not be a big deal.
That being said, I dont think its a high priority, unless there is actually someone that needs it.

:100: Just an easy way to track which one's are missing

hi everyone, first actual person that needs it reporting in. o/
I will attempt to integrate EdDSA support, probably next week. :)

But make sure to base it on the new error_code structure which gets merged in #86 probably this afternoon.

This PR could be linked to this issue perhaps.

I think we already support ES256K, just not explicitly. As far as I can tell ES256K is identical to ES256 but with a different curve.
However OpenSSL decides the curve based on the loaded key and we don't verify which on it is (which IMHO we probably should).
So if you pass a key with curve secp256k1 and manually set the algorithm header it should work fine.
Going forward we should probably start checking the curve type inside ecdsa to make sure the matched key curve matches what the user thought. Then we add a subclass of ecdsa that specifies a different name and curve and we should be done.


feat(toggle): add toggle component

Description
Add the Toggle component as defined in the Component Library.

Links
Links to relevent resources.

@maxinteger the build is failing - pls check why :)


pornhub: can't download private favorites

Make sure you are using the latest version: run youtube-dl --version and ensure your version is 2018.08.04. If it's not, read this FAQ entry and update. Issues with outdated version will be rejected.

[x] I've verified and I assure that I'm running youtube-dl 2018.08.04

Before submitting an issue make sure you have:

[x] At least skimmed through the README, most notably the FAQ and BUGS sections
[x] Searched the bugtracker for similar issues including closed ones
[x] Checked that provided video/audio/playlist URLs (if any) are alive and playable in a browser

What is the purpose of your issue?

[x] Bug report (encountered problems with youtube-dl)
[ ] Site support request (request for adding support for a new site)
[ ] Feature request (request for a new functionality)
[ ] Question
[ ] Other

The following sections concretize particular purposed issues, you can erase any section (the contents between triple ---) not applicable to your issue

If the purpose of this issue is a bug report, site support request or you are not completely sure provide the full verbose output as follows:
Add the -v flag to your command line you run youtube-dl with (youtube-dl -v <your command line>), copy the whole output and insert it here. It should look similar to one below (replace it with your log inserted between triple ```):
└> youtube-dl -vu youtube-dl-test -p 'K<HC7bbU`cjzGE^;k~x(1aDaq~6[>%vl' https://www.pornhub.com/users/youtube-dl-test/videos/favorites
[debug] System config: []
[debug] User config: []
[debug] Custom config: []
[debug] Command-line args: ['-vu', 'youtube-dl-test', '-p', 'PRIVATE', 'https://www.pornhub.com/users/youtube-dl-test/videos/favorites']
[debug] Encodings: locale UTF-8, fs utf-8, out UTF-8, pref UTF-8
[debug] youtube-dl version 2018.06.25
[debug] Python version 3.6.3 (CPython) - Linux-4.15.0-30-generic-x86_64-with-Ubuntu-18.04-bionic
[debug] exe versions: ffmpeg 3.4.2-2, ffprobe 3.4.2-2, phantomjs 2.1.1, rtmpdump 2.4
[debug] Proxy map: {}
[PornHubUserVideos] youtube-dl-test: Downloading page 1
[download] Downloading playlist: youtube-dl-test
[PornHubUserVideos] playlist youtube-dl-test: Collected 0 video ids (downloading 0 of them)
[download] Finished downloading playlist: youtube-dl-test

Description of your issue, suggested solution and other information
No videos were downloaded. Try making the favorites videos public in https://www.pornhub.com/user/prefs and try again, and it works.
Workaround: make the favorites videos public, start downloading the videos, and once it starts downloading the first one, make them private again.

Duplicate of #17196?

This should work with the new PH login system and extractor code to handle it. Please open a new issue if not.


Getting No Route to host (113) when running homeassistant with miflora library.

Hi, I'm trying to reproduce this error, and here's what I've been able to do so far.
Please give me some hint of the direction to continue troubleshooting, if possible. Thanks.
root@home:~# gatttool -b C4:7C:8D:61:91:52 --char-read -a 0x35
connect: No route to host (113)
root@home:~# supervisorctl stop homeassistant
omeassistant: stopped
root@home:~# gatttool -b C4:7C:8D:61:91:52 --char-read -a 0x35
connect: No route to host (113)
root@home:~# hcitool lescan
LE Scan ...
...
C4:7C:8D:61:91:52 Flower care
...
root@home:~# gatttool -b C4:7C:8D:61:91:52 --char-read -a 0x35
Characteristic value/descriptor: aa bb cc dd ee ff 99 88 77 66 00 00 00 00 00 00

It almost feels like there is some 'read mode' that is not enabled properly. But after scanning again I can query the data.
Any thoughts?
Cross bug filed to home-assistant until we understand the nature of the problem https://github.com/home-assistant/home-assistant/issues/5918

There might be another BLE operation already running. This can result in all kind of error messages on gatttool.

My "No route to host (113)" issues were caused by another bluetooth device suddenly recognised after a dist-upgrade and taking the position of hci0.

@jmtatsch how were you able to localize this error? I'm still haveng same issue.

@kireevco I couldn't get a manual connection with hci0 anymore because my stray bluetooth adapter didn't support BLE. Thats when i realised that the device behind hci0 must have changed.

@kireevco How far are your Bluetooth dongle and the Xiaomi sensor apart? I had the experience if the distance is larger than 5 meters or if there are obstacles in the way (concrete wall, furniture, TV, ...) there are quire frequent and unpredictable connection issues.

No progress since July --> closing it. If the  problem still exists, please re-open.


Access denied, keybase shell, fresh install, windows 10 (domain admin)

Fresh install of Keybase this afternoon.
Windows 10 Pro.
Domain admin account.
Getting access denied:
C:\Users\gellenburg\AppData\Local\Keybase>keybase sign

ERROR Access is denied.

C:\Users\gellenburg\AppData\Local\Keybase>keybase status

ERROR Access is denied.

C:\Users\gellenburg\AppData\Local\Keybase>keybase login

ERROR Access is denied.

C:\Users\gellenburg\AppData\Local\Keybase>keybase log
NAME:
keybase log - Manage keybase logs
USAGE:
keybase log  [arguments...]
COMMANDS:
send         Send recent debug logs to keybase
help, h      Shows a list of commands or help for one command
C:\Users\gellenburg\AppData\Local\Keybase>keybase log send
This command will send recent keybase log entries to keybase.io
for debugging purposes only.
These logs don’t include your private keys or encrypted data,
but they will include filenames and other metadata keybase normally
can’t read, for debugging purposes.
Continue sending logs to keybase.io? (type 'YES' to confirm): yes

INFO ignoring error getting keybase status: Access is denied.
INFO ignoring UI logs: Access is denied.

Success! Your log ID is:
e0a9f6abe335772f2a6b2d1c
Here's a URL to submit new bug reports containing this ID:
https://github.com/keybase/client/issues/new?body=[write something useful and descriptive here]

my log id: e0a9f6abe335772f2a6b2d1c
Thanks!
C:\Users\gellenburg\AppData\Local\Keybase>
my log id: e0a9f6abe335772f2a6b2d1c

This is puzzling. Was the installer run under elevated permissions, or as a different user?


Forced domain not retaining setting

Running nodebb-plugin-smoothshorts under NodeBB v1.0.2 I am unable to set a "forced domain."
I click the checkbox and enter a domain name yet after clicking "Save Settings" the checkbox and my custom domain name reset back to blank.
I hope you are still actively developing this plugin as it works pretty well.  I do have a few other small issues with it but they are not as severe as this "forced domain" one.
Thanks.

Hi there! :smile:
To be honest, I'm surprised that it works >1.0.0, at all. I was just coming here onto GitHub to get some inspiration for my evening project. I guess I just found it. :+1:
Since my last update, I actually found an HTML5 API that allows us to copy into the clipboard (not read from it, luckily), so my general intention is to rewrite the plugin and maintain those modifier-key acrobatics as a fallback, only.
For now, I'll spin up v1.0.2 and see that I get this one fixed, first. :smile:

Great!  Let me know if you would like me to test anything.
And since you are here I'll mention that I can only get the smoothshorts link when copying the link from the exact category it is in.  If I try to get it while copying from say the homepage, or the "recents" route, etc., it does not work.  Uh, was that even clear?

Yes, I know what you mean. I already know what the problem is: The plugin checks explicitly for the category and topic views to trigger the replacement. I'll put that on the list, 'cause I just decided to refactor the **** out of this. Almost embarrassing what a mess I produced there. :smile:

This fix works great.  Thank you.


store label properties in shared bucket

each label has its own properties right now - instead, it (and all labels with the same name) should reference a bucket that holds property data. This way, updating one label's properties will update for all other resources with the same label name.
I.e. if we were to change a label "kubernetes" to the color green, all other places where that label is used should now show as green

This is old - was fixed in the v2 labels rework.


History search in REPL does not work

Pressing Ctrl+Alt+Up/Down should search the REPL history to find entries with matching prefixes. However, this currently does not work - nothing changes about the current input.
This appears to repro with C# Interactive, so it may be their issues.

These combination keys make the orientation of my monitor change when using C# Interactive.  Anyone else seeing this using VS 2015 Update 1?

@shaggygi I'd guess that's an interaction between a global shortcut from your display driver and the VS shortcut. You probably just need to change one of them (VS's can be changed through Tools, Options, Keyboard, search for "search" and find the interactive ones).

Can't repro this outside of an RDP session, which seems to swallow the default keyboard shortcut.

You are correct, it was global shortcut from graphics.  Just disabled and feature now works in REPL.  Thanks!


"Insufficient resources" alert next to greyed-out "Build" or "Accept" buttons

The buttons for building things and accepting offers are no longer clickable if the player doesn't have resources. This is good. To improve UX a little further by giving the player more information as to why some options are not available. I suggest the following two improvements:

Adding a greyed-out button style. Right now "Build" button doesn't change style when it becomes unclickable, and the "Accept" button turns orange. Orange is better then no colour change, but I would prefer something less vibrant, more grey, to really emphasize that a button is unclickable. A colour like #766756 perhaps. This colour is already used in other places, like in this font and border:

Adding a red label next to the greyed-out button that says "Insufficient resources". Similar alerts could be used in other circumstances.

Fixed in #91


chore(deps): Update Protractor

@googlebot cla yes?

Could you rebase this PR? Thanks

Done.

Thank you for the PR, but meanwhile we have already updated protractor.


TParsingDiagnostics

So I used the --write-diagnostics flag during unpacking which gives me the TParsingDiagnostics key in the fragment tree file. Great. However when I do TParsingDiagnostics().Print() I get:
Total run time of this (sub-)run is 0 s PPG cycle is 0 ms long. Found 0 network packets in range<PHONE_NUMBER> - 0 => -0 % packet survival.,
and TParsingDiagnostics().WriteToFile("out.dat") gives similar results (just zeroes). What I'm really after is the channel by channel DeadTime, which it looks like this provides. It feels like there is an argument/pointer missing here, or perhaps something that has to be loaded in the session first.

I'm not sure what state the TParsingDiagnostics is in. As you can see from the print statement, a lot of information is not set (total run time of 0 s). The print function does loop over the map of dead times and print them. If no dead times were set, none will be printed. My guess is that we are no longer setting any information of the TParsingDiagnostics class.
A quick look through the data parser shows that we do use the GoodFragment and BadFragment methods of TParsingDiagnostics (which should set the information), so I'm not sure what is going on.
Can you try explicitly getting the parsing diagnostics from file:
diag->Print();```

This might be another instance where our singletons (that aren't real singletons due to ROOT) mess things up.

Agreed with @VinzenzBildstein . You might be better off to loop through a fragment tree and just add up the dead time from the various fragments.

@VinzenzBildstein That helps, although as you mentioned it looks like the deadtime information is not set properly (first attachment).

@r3dunlop Unfortunately I tried this first and got the second attachment. I assumed it was because I used the wrong print format or something, but DeadTime appears to be cast as an unsigned short, same as DetectorType which works although everything is LowGain GRIFFIN in the screenshot (occasionally PACES shows up as 5).

I think the dead time got set correctly. If it hadn't got set for the channel, it wouldn't report any dead time (instead of reporting a dead time of zero). My comment about things not getting set had to do with your first post. But there things weren't set correctly, because instead of printing the information of the TParsingDiagnostics stored in the file, you printed the information of a new TParsingDiagnostics instance you've just created.
What you posted now looks to me like there is no dead time reported by the digitizers. Have you looked at the raw data and verified that there is indeed a dead time in the fragments?
Should be bits [14:27] of word VII (which has 0xb as bits [28:31]).

Have you seen that the dead time data in the Midas events are non-zero?

Now that you mention it .. these GRIFFIN fragments appear to show zeroes in the deadtime word. So what is going on here, is it because we set a programmable deadtime? I was under the impression we still need the deadtime word from the fragment.

????
This is a firmware thing, not a GRSISort thing. Maybe @AdamGarnsworthy can provide you with the answer?

I thought I remembered something like this, I just wasn't sure. This is definitely a firmware issue.

Yup, maybe a question for Chris here. This is a run from last year (8889, 19 Apr 2017), just before S1607. If I take a look at a very recent run (10655, 16 Jan) using the latest firmware ... same thing. Odd.

Chris is checking this now. Apparently with the programmable deadtime set in the DAQ ("prg_ddtm" in the ODB file), the deadtime word in the fragment should be inclusive, i.e. it should reflect all times when the channel is dead because of hit processing, a buffer being filled or a 4th piled-up hit etc. We are not sure if this happening at the moment or if only one of these situations is included. Running the parsing diagnostics on a single high-rate sub run from S1607 I get the attached. How does the unpacker deal with the wrap-around for a given channel?

To contribute: I get 0 DeadTime on all channels, but only the first 64 channels give nonzero total time contributions. After that, the total time output is zero with deadtime (channel 0x0040 onwards).
Screenshot from fragment from S1625 (Europium, June 2017). Channels 0x0030-33 show no total time due to missing detector.

@dayates, what do you get when you scan the timestamps of the fragments for those channels with 0 ms total time?
Something like FragmentTree->Scan("GetTimeStamp()","GetChannelNumber()==0x40"). Do you get a number of different timestamps for this channel?
This is a separate issue, but I think we should change TParsingDiagnostics to use maps with channel addresses as keys instead of channel numbers. The former are the electronics channels that recorded the data, whereas the latter are just numbers assigned to these channels which can be changed by reading different cal files.

@VinzenzBildstein No. There appears to only be one entry on the channels showing zero total time (above).

With channels that report a nonzero total recording time, there are numerous timestamp entries.

It’s a known issue that the DAQ throws one event at the start of every run for every channel. That’s why the timestamp for all of these events are 1 as well. Our code looks for an existing channel and starts counting the dead time. Since there is no dead time for this junk, you get what you get.

This explains why those channels give you a total time of 0 ms. The total time is calculated on a per channel basis by using the maximum and minimum timestamp found for that channel. If there is only one timestamp, the difference is 0. With only one hit, this probably isn't a real channel (with a detector connected to it) anyways.

PR #989 changes the way the dead time is reported if the min/max time stamp and the min/max channel ID are the same (this should only apply to those channels with a single event).
@MikeBowry, did Chris find the reason for the missing dead time? Can we close this issue?

Thanks Vinzenz. Yup, we can close this for now. I'm waiting for an update from Chris but he did confirm that the GRIFFIN fragment Deadtime word omits both the enforced deadtime (I guess the typical programmable deadtime of 1.2 us) and the pulseheight module deadtime. Work is ongoing to correct this, hopefully before the next set of experiments. For now though I am estimating the deadtime using:
ChannellD()*1.2e-6 + Deadtime(),
where each word is corrected for wrap-around.


Fixed annoying compiler warnings which partially leak through to consuming app

If you don't want the updates to the project configuration (but why the hell wouldn't one?), please, at least integrate the changes which fix the warnings, which show up in recent versions of Xcode and are very annoying, because some of them actually leak through to the app.
And these obstruct the view onto its own problems and ignoring them actually costs a lot of developer attention, therefore time, therefore money.
Thanks a lot,
Benjamin
Signed-off-by: Benjamin Erhart<EMAIL_ADDRESS>Pull Request Checklist

[x] Pull request is based on the develop branch
[x] Pull request updates CHANGES.rst
[x] Pull request includes a sign off

Thank you very much @tladesignz for your contribution! We will mention you in changes.rst if you are agree.

Thank you very much @tladesignz for your contribution!

Well, thank you for taking it! Could be, that I send you more of this, as I'm a very tidy person... ;-)

We will mention you in changes.rst if you are agree.

Sure! Thanks for the props!


Remove requests from SS deployment in kind-ci.

Secondary scheduler pod sometimes fails to run on master node due to
lack of resources.
Secondary scheduler deployment is created by NROSchedReconciler which
loads a yaml file as template, so we use yq tool to delete the
requests from that file so the pod could be scheduled.

/cc @Tal-or

/hold

changing the deployment like we do in https://github.com/openshift-kni/numaresources-operator/blob/v4.10.0-pre2022012501/.github/workflows/e2e.yml#L55 was already borderline, but changing the source code is too much IMO. This doesn't look like the best direction.

Surely not the best solution, but we did not find any other so the pod could be scheduled on master node.
I tried with kustomize, but this deployment is not deployed directly but created by the scheduler reconciler so kustomize did not seem to work.
I think the need of this kind of workaround will be eliminated when NROS would be deployed by a dedicated operator, but in the meanwhile ci is failing most of the time due to this, so I think we should find a way to mitigate the problem.

changing the deployment like we do in https://github.com/openshift-kni/numaresources-operator/blob/v4.10.0-pre2022012501/.github/workflows/e2e.yml#L55 was already borderline, but changing the source code is too much IMO. This doesn't look like the best direction.

We can't use kustomize as we did in previous changes, so it looked like the most painless option.
Moreover, the scheduler is temporary anyway, so when we will move into SSOP we can come up with more elegant solution.

changing the deployment like we do in https://github.com/openshift-kni/numaresources-operator/blob/v4.10.0-pre2022012501/.github/workflows/e2e.yml#L55 was already borderline, but changing the source code is too much IMO. This doesn't look like the best direction.

Surely not the best solution, but we did not find any other so the pod could be scheduled on master node.

Sure, the problem here is the fact that the free tier of github actions provides us machines too weak for our use case.
Which is fine, when we get things for free we can't complain too much.
So better use these resources in a different way. We can either reorganize the kind lanes or prioritize the tests we want to run. For the purposes of this operator, k8s/kind is a tier-2 platform anyway, so it's OK to run only a subset of tests in there.
OTOH we should not purposefully exclude k8s, but that's a far cry from what we need to do here.

I tried with kustomize, but this deployment is not deployed directly but created by the scheduler reconciler so kustomize did not seem to work.

Indeed, kustomize can't work here. The internal manifests are embedded into the operator. We are effectively changing the source code here, and that's why this change is excessive.

I think the need of this kind of workaround will be eliminated when NROS would be deployed by a dedicated operator, but in the meanwhile ci is failing most of the time due to this, so I think we should find a way to mitigate the problem.

I agree, and I believe the best mitigation is rethink how we run the tests, and which of them we run.

changing the deployment like we do in https://github.com/openshift-kni/numaresources-operator/blob/v4.10.0-pre2022012501/.github/workflows/e2e.yml#L55 was already borderline, but changing the source code is too much IMO. This doesn't look like the best direction.

We can't use kustomize as we did in previous changes, so it looked like the most painless option.
Moreover, the scheduler is temporary anyway, so when we will move into SSOP we can come up with more elegant solution.

Thing is the previous approach was borderline already. CI should test an artifact as close as possible (ideally identical) to the shipped version. The saving grace here was k8s is a tier-2 platform, and we have some slack space wrt the OCP recommended settings. But we were bending the rules a bit already. Let's not move too forward in that direction.

This is not the correct approach. We should find another way to solve this issue without modifying the production code.


Allows Consumer Pass Argument for Return Type of createMutatorStore

Description
Allows consuming code to pass a type argument for the return value of createMutatorStore. Really, it just re-uses the Response argument and passes it through to MutatorCb
Usage
const doThing = async (): Promise<{id: string}> => {
  const r = await fetch("/hello/world");
  return r.json();
};

const $createThing = createMutatorStore<
  { hello: "world" },
  { id: string; description: string }
>(() => doThing()); // will correctly error b/c doThing() is missing `description`

@martinmckenna Thanks! Published in 0.2.10.


fix(plugins): fix typedoc plugin logo and test workflow

Description
Please describe the reason related to the changes:
Type
Please select the type related to the changes:

[ ] bugfix
[ ] build
[ ] continuous delivery (CD)
[ ] continuous integration (CI)
[ ] documentation
[ ] feature
[ ] formatting
[ ] refactoring
[ ] styling
[ ] other (please describe below):

Breaking Change
Does your changes introduce a breaking change?

[ ] no
[ ] yes

Behavior
Please describe the current behavior:
Changes
Please describe the new behavior:
Information (issue, links, logs, etc.)
Please list any other useful information:
Checklist
Please make sure this pull request follow the requirements:

[ ] commit guidelines @commitlint/config-conventional
[ ] 100% code coverage
[ ] tests passing

#docs

/docs

/docs

/docs

/docs

/docs

/docs

/docs

/docs

/docs

/docs

/docs

/docs

/docs

/docs

/docs

/docs

/docs

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

2 of 2 (100.0%)  changed or added relevant lines in 2 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 100.0%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
239

Relevant Lines:
239

💛  - Coveralls

/docs

/docs

/docs