merge master into live-based

OPS Build status updates of commit bf3ddf7:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

.openpublishing.publish.config.json
:white_check_mark:Succeeded

2017-03-09-profile/docs-ref-autogen/TOC.yml
:white_check_mark:Succeeded
View (azure-cli-2017-03-09-profile)

2017-03-09-profile/docs-ref-autogen/ext/application-insights/index.yml
:white_check_mark:Succeeded
View (azure-cli-2017-03-09-profile)

2017-03-09-profile/docs-ref-autogen/ext/application-insights/monitor.yml
:white_check_mark:Succeeded
View (azure-cli-2017-03-09-profile)

2017-03-09-profile/docs-ref-autogen/ext/application-insights/monitor/app-insights.yml
:white_check_mark:Succeeded
View (azure-cli-2017-03-09-profile)

2017-03-09-profile/docs-ref-autogen/ext/application-insights/monitor/app-insights/events.yml
:white_check_mark:Succeeded
View (azure-cli-2017-03-09-profile)

2017-03-09-profile/docs-ref-autogen/ext/application-insights/monitor/app-insights/metrics.yml
:white_check_mark:Succeeded
View (azure-cli-2017-03-09-profile)

2017-03-09-profile/docs-ref-autogen/ext/express-route-cross-connection/network.yml
:white_check_mark:Succeeded
View (azure-cli-2017-03-09-profile)

2017-03-09-profile/docs-ref-autogen/ext/express-route-cross-connection/network/cross-connection.yml
:white_check_mark:Succeeded
View (azure-cli-2017-03-09-profile)

2017-03-09-profile/docs-ref-autogen/ext/express-route-cross-connection/network/cross-connection/peering.yml
:white_check_mark:Succeeded
View (azure-cli-2017-03-09-profile)

2017-03-09-profile/docs-ref-autogen/ext/storage-preview/storage.yml
:white_check_mark:Succeeded
View (azure-cli-2017-03-09-profile)

2017-03-09-profile/docs-ref-autogen/ext/storage-preview/storage/account.yml
:white_check_mark:Succeeded
View (azure-cli-2017-03-09-profile)

2018-03-01-hybrid/docs-ref-autogen/TOC.yml
:white_check_mark:Succeeded
View (azure-cli-2018-03-01-hybrid)

2018-03-01-hybrid/docs-ref-autogen/ams/asset.yml
:white_check_mark:Succeeded
View (azure-cli-2018-03-01-hybrid)

2018-03-01-hybrid/docs-ref-autogen/ext/application-insights/index.yml
:white_check_mark:Succeeded
View (azure-cli-2018-03-01-hybrid)

2018-03-01-hybrid/docs-ref-autogen/ext/application-insights/monitor.yml
:white_check_mark:Succeeded
View (azure-cli-2018-03-01-hybrid)

2018-03-01-hybrid/docs-ref-autogen/ext/application-insights/monitor/app-insights.yml
:white_check_mark:Succeeded
View (azure-cli-2018-03-01-hybrid)

2018-03-01-hybrid/docs-ref-autogen/ext/application-insights/monitor/app-insights/events.yml
:white_check_mark:Succeeded
View (azure-cli-2018-03-01-hybrid)

2018-03-01-hybrid/docs-ref-autogen/ext/application-insights/monitor/app-insights/metrics.yml
:white_check_mark:Succeeded
View (azure-cli-2018-03-01-hybrid)

2018-03-01-hybrid/docs-ref-autogen/ext/express-route-cross-connection/network.yml
:white_check_mark:Succeeded
View (azure-cli-2018-03-01-hybrid)

2018-03-01-hybrid/docs-ref-autogen/ext/express-route-cross-connection/network/cross-connection.yml
:white_check_mark:Succeeded
View (azure-cli-2018-03-01-hybrid)

2018-03-01-hybrid/docs-ref-autogen/ext/express-route-cross-connection/network/cross-connection/peering.yml
:white_check_mark:Succeeded
View (azure-cli-2018-03-01-hybrid)

2018-03-01-hybrid/docs-ref-autogen/ext/storage-preview/storage.yml
:white_check_mark:Succeeded
View (azure-cli-2018-03-01-hybrid)

2018-03-01-hybrid/docs-ref-autogen/ext/storage-preview/storage/account.yml
:white_check_mark:Succeeded
View (azure-cli-2018-03-01-hybrid)

docs-ref-conceptual/azure-cli-extensions-list.md
:white_check_mark:Succeeded
View (azure-cli-latest) View (azure-cli-2017-03-09-profile) View (azure-cli-2018-03-01-hybrid)

latest/docs-ref-autogen/TOC.yml
:white_check_mark:Succeeded
View (azure-cli-latest)

latest/docs-ref-autogen/ams/asset.yml
:white_check_mark:Succeeded
View (azure-cli-latest)

latest/docs-ref-autogen/ext/application-insights/index.yml
:white_check_mark:Succeeded
View (azure-cli-latest)

latest/docs-ref-autogen/ext/application-insights/monitor.yml
:white_check_mark:Succeeded
View (azure-cli-latest)

latest/docs-ref-autogen/ext/application-insights/monitor/app-insights.yml
:white_check_mark:Succeeded
View (azure-cli-latest)

latest/docs-ref-autogen/ext/application-insights/monitor/app-insights/events.yml
:white_check_mark:Succeeded
View (azure-cli-latest)

latest/docs-ref-autogen/ext/application-insights/monitor/app-insights/metrics.yml
:white_check_mark:Succeeded
View (azure-cli-latest)

latest/docs-ref-autogen/ext/express-route-cross-connection/network.yml
:white_check_mark:Succeeded
View (azure-cli-latest)

latest/docs-ref-autogen/ext/express-route-cross-connection/network/cross-connection.yml
:white_check_mark:Succeeded
View (azure-cli-latest)

latest/docs-ref-autogen/ext/express-route-cross-connection/network/cross-connection/peering.yml
:white_check_mark:Succeeded
View (azure-cli-latest)

latest/docs-ref-autogen/ext/storage-preview/storage.yml
:white_check_mark:Succeeded
View (azure-cli-latest)

latest/docs-ref-autogen/ext/storage-preview/storage/account.yml
:white_check_mark:Succeeded
View (azure-cli-latest)

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

OPS Build status updates of commit 2e47472:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

.openpublishing.publish.config.json
:white_check_mark:Succeeded

2017-03-09-profile/docs-ref-autogen/TOC.yml
:white_check_mark:Succeeded
View (azure-cli-2017-03-09-profile)

2017-03-09-profile/docs-ref-autogen/ext/application-insights/index.yml
:white_check_mark:Succeeded
View (azure-cli-2017-03-09-profile)

2017-03-09-profile/docs-ref-autogen/ext/application-insights/monitor.yml
:white_check_mark:Succeeded
View (azure-cli-2017-03-09-profile)

2017-03-09-profile/docs-ref-autogen/ext/application-insights/monitor/app-insights.yml
:white_check_mark:Succeeded
View (azure-cli-2017-03-09-profile)

2017-03-09-profile/docs-ref-autogen/ext/application-insights/monitor/app-insights/events.yml
:white_check_mark:Succeeded
View (azure-cli-2017-03-09-profile)

2017-03-09-profile/docs-ref-autogen/ext/application-insights/monitor/app-insights/metrics.yml
:white_check_mark:Succeeded
View (azure-cli-2017-03-09-profile)

2017-03-09-profile/docs-ref-autogen/ext/express-route-cross-connection/network.yml
:white_check_mark:Succeeded
View (azure-cli-2017-03-09-profile)

2017-03-09-profile/docs-ref-autogen/ext/express-route-cross-connection/network/cross-connection.yml
:white_check_mark:Succeeded
View (azure-cli-2017-03-09-profile)

2017-03-09-profile/docs-ref-autogen/ext/express-route-cross-connection/network/cross-connection/peering.yml
:white_check_mark:Succeeded
View (azure-cli-2017-03-09-profile)

2017-03-09-profile/docs-ref-autogen/ext/mixed-reality/index.yml
:white_check_mark:Succeeded
View (azure-cli-2017-03-09-profile)

2017-03-09-profile/docs-ref-autogen/ext/mixed-reality/spatial-anchors-account.yml
:white_check_mark:Succeeded
View (azure-cli-2017-03-09-profile)

2017-03-09-profile/docs-ref-autogen/ext/mixed-reality/spatial-anchors-account/key.yml
:white_check_mark:Succeeded
View (azure-cli-2017-03-09-profile)

2017-03-09-profile/docs-ref-autogen/ext/storage-preview/storage.yml
:white_check_mark:Succeeded
View (azure-cli-2017-03-09-profile)

2017-03-09-profile/docs-ref-autogen/ext/storage-preview/storage/account.yml
:white_check_mark:Succeeded
View (azure-cli-2017-03-09-profile)

2018-03-01-hybrid/docs-ref-autogen/TOC.yml
:white_check_mark:Succeeded
View (azure-cli-2018-03-01-hybrid)

2018-03-01-hybrid/docs-ref-autogen/ams/asset.yml
:white_check_mark:Succeeded
View (azure-cli-2018-03-01-hybrid)

2018-03-01-hybrid/docs-ref-autogen/ext/application-insights/index.yml
:white_check_mark:Succeeded
View (azure-cli-2018-03-01-hybrid)

2018-03-01-hybrid/docs-ref-autogen/ext/application-insights/monitor.yml
:white_check_mark:Succeeded
View (azure-cli-2018-03-01-hybrid)

2018-03-01-hybrid/docs-ref-autogen/ext/application-insights/monitor/app-insights.yml
:white_check_mark:Succeeded
View (azure-cli-2018-03-01-hybrid)

2018-03-01-hybrid/docs-ref-autogen/ext/application-insights/monitor/app-insights/events.yml
:white_check_mark:Succeeded
View (azure-cli-2018-03-01-hybrid)

2018-03-01-hybrid/docs-ref-autogen/ext/application-insights/monitor/app-insights/metrics.yml
:white_check_mark:Succeeded
View (azure-cli-2018-03-01-hybrid)

2018-03-01-hybrid/docs-ref-autogen/ext/express-route-cross-connection/network.yml
:white_check_mark:Succeeded
View (azure-cli-2018-03-01-hybrid)

2018-03-01-hybrid/docs-ref-autogen/ext/express-route-cross-connection/network/cross-connection.yml
:white_check_mark:Succeeded
View (azure-cli-2018-03-01-hybrid)

2018-03-01-hybrid/docs-ref-autogen/ext/express-route-cross-connection/network/cross-connection/peering.yml
:white_check_mark:Succeeded
View (azure-cli-2018-03-01-hybrid)

2018-03-01-hybrid/docs-ref-autogen/ext/mixed-reality/index.yml
:white_check_mark:Succeeded
View (azure-cli-2018-03-01-hybrid)

2018-03-01-hybrid/docs-ref-autogen/ext/mixed-reality/spatial-anchors-account.yml
:white_check_mark:Succeeded
View (azure-cli-2018-03-01-hybrid)

2018-03-01-hybrid/docs-ref-autogen/ext/mixed-reality/spatial-anchors-account/key.yml
:white_check_mark:Succeeded
View (azure-cli-2018-03-01-hybrid)

2018-03-01-hybrid/docs-ref-autogen/ext/storage-preview/storage.yml
:white_check_mark:Succeeded
View (azure-cli-2018-03-01-hybrid)

2018-03-01-hybrid/docs-ref-autogen/ext/storage-preview/storage/account.yml
:white_check_mark:Succeeded
View (azure-cli-2018-03-01-hybrid)

docs-ref-conceptual/azure-cli-extensions-list.md
:white_check_mark:Succeeded
View (azure-cli-latest) View (azure-cli-2017-03-09-profile) View (azure-cli-2018-03-01-hybrid)

latest/docs-ref-autogen/TOC.yml
:white_check_mark:Succeeded
View (azure-cli-latest)

latest/docs-ref-autogen/ams/asset.yml
:white_check_mark:Succeeded
View (azure-cli-latest)

latest/docs-ref-autogen/ext/application-insights/index.yml
:white_check_mark:Succeeded
View (azure-cli-latest)

latest/docs-ref-autogen/ext/application-insights/monitor.yml
:white_check_mark:Succeeded
View (azure-cli-latest)

latest/docs-ref-autogen/ext/application-insights/monitor/app-insights.yml
:white_check_mark:Succeeded
View (azure-cli-latest)

latest/docs-ref-autogen/ext/application-insights/monitor/app-insights/events.yml
:white_check_mark:Succeeded
View (azure-cli-latest)

latest/docs-ref-autogen/ext/application-insights/monitor/app-insights/metrics.yml
:white_check_mark:Succeeded
View (azure-cli-latest)

latest/docs-ref-autogen/ext/express-route-cross-connection/network.yml
:white_check_mark:Succeeded
View (azure-cli-latest)

latest/docs-ref-autogen/ext/express-route-cross-connection/network/cross-connection.yml
:white_check_mark:Succeeded
View (azure-cli-latest)

latest/docs-ref-autogen/ext/express-route-cross-connection/network/cross-connection/peering.yml
:white_check_mark:Succeeded
View (azure-cli-latest)

latest/docs-ref-autogen/ext/mixed-reality/index.yml
:white_check_mark:Succeeded
View (azure-cli-latest)

latest/docs-ref-autogen/ext/mixed-reality/spatial-anchors-account.yml
:white_check_mark:Succeeded
View (azure-cli-latest)

latest/docs-ref-autogen/ext/mixed-reality/spatial-anchors-account/key.yml
:white_check_mark:Succeeded
View (azure-cli-latest)

latest/docs-ref-autogen/ext/storage-preview/storage.yml
:white_check_mark:Succeeded
View (azure-cli-latest)

latest/docs-ref-autogen/ext/storage-preview/storage/account.yml
:white_check_mark:Succeeded
View (azure-cli-latest)

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

OPS Build status updates of commit 29b75fc:
:clock10: Pending: waiting for processors (33 builds ahead of you)
:warning: OPS Build is busy, currently there are 33 builds ahead of this one, for more information you can view the Build queue graph on the Docs Portal.


RetriableDocumentStorageService.write() is not handling retries correctly

In particular, it does not handle 429s correctly, or any other retryable error.
Can we move away from using DocumentStorageServiceProxy here? It hides details, it's not obvious on initial review what APIs are wrapped vs. not.
As other new APIs would get added, developers would keep missing the need to change that class.

Also we need to ensure there is telemetry in place (number of attempts, total duration, if possible - last error we deal with).
I do not remember if we have dedicated issue to just that. If not, would be great to take care of it here.

Also we need to ensure there is telemetry in place (number of attempts, total duration, if possible - last error we deal with).
I do not remember if we have dedicated issue to just that. If not, would be great to take care of it here.

Moving the telemetry part to other issue: https://github.com/microsoft/FluidFramework/issues/4855

Moving the telemetry part to other issue: https://github.com/microsoft/FluidFramework/issues/4855


Savefile location

Where is the savefile location to import an existing save?

Also, I get a message: "You configure invalid ip address: xxxxx" , but it is my DDNS address. It is valid....


question: multiple tests within subfolders

how do I run multiple tests (within subfolders)
for example:
/src
----/index.ts
----/conf
----/----/file.ts
/test
----/test.ts
----/conf
----/----/file-test.ts

Found it.. as always shortly after asking the question when you have no clue spending multiple hours researching:
just add --recursive to mocha.opts :
--ui mocha-typescript
--require source-map-support/register
--recursive
./test/


Having a chained fk field triggers "unsaved changes" in admin interface

Checklist
Put an x in the bracket when you have completed each task, like this: [x]

[ x ] This issue is not about installing previous versions of django-smart-selects older than 1.2.8. I understand that previous versions are insecure and will not receive any support whatsoever.
[ x ] I have verified that that issue exists against the master branch of django-smart-selects.
[ x ] I have searched for similar issues in both open and closed tickets and cannot find a duplicate.
[ x ] I have debugged the issue to the smart_selects app.
[ x ] I have reduced the issue to the simplest possible case.
[ x ] I have included all relevant sections of models.py, forms.py, and views.py with problems.
[ x ] I have used GitHub Flavored Markdown to style all of my posted code.

Steps to reproduce

Django 2.0.1, django-smart-selects 1.5.3 (or 1.5.4) and django-jet.
Create Chained field (for example "breed" and "species")
Go to admin interface and create new entry (for example "animal")

Actual behavior
When leaving the page without changing anything, a message "You have unsaved changes" appears. This is due to the "change listener" in the django-admin interface:
`onFormInputChanged: function($inputs) {
$inputs.off('change', this.onFormInputChanged);
    if (!self.changeDetected) {
        $(window).bind('beforeunload', this.onWindowBeforeUnload);
    }

    this.changeDetected = true;
},`

To disable this behaviour you can uncomment
$selectField.trigger('change');
but this leads to unexpected behaviour.
The bug is related to #91
Expected behavior
Don't change the content of the field (via 'change'), when nothing is selected but still work as expected.
Has anyone a suggestion how to solve this problem?

@cookieofcode is this still happening with the latest master version?

@manelclos Thanks for asking. I can't check as I have no longer access to the project.


Different ProtoResults

I have two models using from ortools.sat.python import cp_model.
There following variables used:

Method 1: A=NewIntVar, B=NewBoolVar, C=NewBoolVar
Method 2: A=NewIntVarFromDomain, B=NewBoolVar

As you can see, in new Method 2 C type boolean vars are removed. So here is the output of the proto:
// Method 1:
objective_value: 353 311 600.0
best_objective_bound: 187 826 000.0
num_booleans: 186
num_conflicts: 93 575
num_branches: 284 178
num_binary_propagations: 2 513 946
num_integer_propagations: 4 672 584
wall_time: 10.010841777000001
user_time: 10.010841693000001
deterministic_time: 25.35660364
solution_info: "lp_br"

//Method 2
objective_value: 277 051 600.0
best_objective_bound: 105 526 000.0
num_booleans: 230
num_conflicts: 141 409
num_branches: 610 841
num_binary_propagations: 5 703 002
num_integer_propagations: 9 241 822
wall_time: 10.008543676
user_time: 10.00854353
deterministic_time: 14.92037573
solution_info: "lp_br"

Well from my knowledge, I suppose the proto results should be replaced. shouldn`t they? Could you please expain why this happens?

How can you expect me to comment ?
I do not know the model, the types of constraints...
Laurent Perron | Operations Research |<EMAIL_ADDRESS>| (33) 1 42 68 53
00
Le mar. 10 sept. 2019 à 13:07, Shohruh<EMAIL_ADDRESS>a écrit :

I have two models using from ortools.sat.python import cp_model.
There following variables used:
Method 1: A=NewIntVar, B=NewBoolVar, C=NewBoolVar
Method 2: A=NewIntVarFromDomain, B=NewBoolVar
As you can see, in new Method 2 C type boolean vars are removed. So here
is the output of the proto:
// Method 1:
objective_value: 353 311 600.0
best_objective_bound: 187 826 000.0
num_booleans: 186
num_conflicts: 93 575
num_branches: 284 178
num_binary_propagations: 2 513 946
num_integer_propagations: 4 672 584
wall_time: 10.010841777000001
user_time: 10.010841693000001
deterministic_time: 25.35660364
solution_info: "lp_br"
//Method 2
objective_value: 277 051 600.0
best_objective_bound: 105 526 000.0
num_booleans: 230
num_conflicts: 141 409
num_branches: 610 841
num_binary_propagations: 5 703 002
num_integer_propagations: 9 241 822
wall_time: 10.008543676
user_time: 10.00854353
deterministic_time: 14.92037573
solution_info: "lp_br"
Well from my knowledge, I suppose the proto results should be replaced.
shouldn`t they? Could you please expain why this happens?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/google/or-tools/issues/1568?email_source=notifications&email_token=ACUPL3NS4UCLVINCOYJIMWLQI55X5A5CNFSM4IVGHXPKYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4HKNJMTQ,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ACUPL3I2AI5VQSPBTNISRWTQI55X5ANCNFSM4IVGHXPA
.


/lac rmpass still doesn't work

Console LOG:
[11:23:41 INFO]: No player with that name has been registered! [11:23:41 WARN]: Exception in thread "pool-6-thread-1" [11:23:41 WARN]: java.lang.IllegalStateException: User is not registered!
[11:23:41 WARN]:        at com.lenis0012.bukkit.loginsecurity.session.action.RemovePassAction.run(RemovePassAction.java:15) [11:23:41 WARN]:        at com.lenis0012.bukkit.loginsecurity.session.PlayerSession.performAction(PlayerSession.java:168) [11:23:41 WARN]:        at com.lenis0012.bukkit.loginsecurity.session.PlayerSession$2.run(PlayerSession.java:142) [11:23:41 WARN]:        at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
[11:23:41 WARN]:        at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
[11:23:41 WARN]:        at java.lang.Thread.run(Thread.java:745)
Server version: Spigot 1.9.4

please answer @lenis0012

@Tzzzt123 Please be patient. It's currently 7:22 AM here and everyone's still waking up.

@Plazmaz i just watched @lenis0012 location: "NETHERLANDS"
And in there time zone CEST so 15:25

@Tzzzt123 he is currently on vacation in the USA.. Please calm down.

oh sorry @lenis0012

@Tzzzt123 Try the latest dev build.
Also make sure the name is correct. it is case sensitive


Multiple dispenses

Looks good in testing.. a single tx is triggering multiple dispenses as expected.
2023-12-22 18:14:22][INFO] Dispenser: DA7NpDGyQniQ8rjPHmmoBoLajBNcUo4JEG closed dispenser for GANESHA (dispenser empty)
2023-12-22 18:14:22][INFO] Dispense: 3.005 GANESHA from DA7NpDGyQniQ8rjPHmmoBoLajBNcUo4JEG to DUSDPTwKV3xGwVmeQAptUHbLqdRcLJxQoP (575a03c3c45c8473d010f5038a545cb88721d47f1d5a68115f473977b0ec8eb7)
2023-12-22 18:14:22][INFO] Dispense: 1.0 XDP from D75dRsG69uhxGWSdfxTHms5os76MV2VYGr to DUSDPTwKV3xGwVmeQAptUHbLqdRcLJxQoP (575a03c3c45c8473d010f5038a545cb88721d47f1d5a68115f473977b0ec8eb7)
2023-12-22 18:14:24][INFO] Block: 5016906 (5.40s, hashes: L:fe294 / TX:65762 / M:3adf1)


Qwik adds js / ts extension on import

I am interested in helping provide a fix!
Yes
Which generators are impacted?

[ ] All
[ ] Angular
[ ] HTML
[ ] Preact
[X] Qwik
[ ] React
[ ] React-Native
[ ] Solid
[ ] Stencil
[ ] Svelte
[ ] Vue
[ ] Web components

Reproduction case
https://mitosis.builder.io/playground/?code=JYWwDg9gTgLgBAZQiApgYWZAdir8BmUycA5AHQD0AzsigLQDGmEOeZANsDCiQNwBQ%2FFAA9IsOABMU%2BAIYBXdgTlYGMYCzgZwLXDADyANxRQDwFAHcAFAEo4Ab35w4UFDDlQscS46dwAPAB8Pr7%2BSKha2LoBfhRh6MysMEEhMUE%2B1gIAvvxAA
Expected Behaviour
Should not add .jsx or .tsx on import
Actual Behaviour

Additional Information
I have the following setting in my mitosis.config.js
    qwik: {
      typescript: true,
      preserveFileExtensions: false
    },

@bastiW thanks for raising this, we have a helper already for this called explicitImportFileExtension but seems like its not added for qwik
we can reuse explicitImportFileExtension for qwik something like this,
https://github.com/BuilderIO/mitosis/blob/a51cd1bf3f240405ff8291fe9641d64ceeef0d5d/packages/core/src/helpers/component-file-extensions.ts#L150
in
https://github.com/BuilderIO/mitosis/blob/a51cd1bf3f240405ff8291fe9641d64ceeef0d5d/packages/core/src/helpers/component-file-extensions.ts#L136

should specify this demand more clear.


[BUG]: nullable column makes the type optional

What version of drizzle-orm are you using?
0.29.4
What version of drizzle-kit are you using?
0.20.14
Describe the Bug
Using drizzle-zod 0.5.1
Setting a column as text which is nullable makes the type as imageId?: string | null | undefined

Expected behavior
It should be just imageId: string | null
Environment & setup
node v20.10.0

This type is correct for insert. I can't see if this is being used in an insert of or a select.

Actually after making my tsconfig.json stricter this went away!


Help : Play the sound with the notification

const path = require("path");
const { Notify } = require("node-dbus-notifier");

class Notification {
  constructor(header, body, action) {
    this.header = header;
    this.body = body;
    this.action = action;
    this.notification = new Notify({
      summary: this.header,
      body: this.body,
      hints: {
        imagePath: path.join(__dirname, "../assets/icons/Icon_16x16.png"),
        soundFile: path.join(
          __dirname,
          "../assets/sounds/Check-mark-ding-sound-effect.mp3"
        ),
      },
    });
  }
}

Everything works fine, except sound, even the image from the file is fetching properly for all my notifications.

OS - Fedora 38
Desktop Environment - Gnome 44

What is the issue with above implementation

This is resolved, I changed the file format to .wav.

I resolved the issue, change the file format to .wav


/nix/store/[hash]-sshd.conf-validated line 59: Subsystem 'sftp' already defined, and `sshd_config' not being created

Hello! I do sincerely apologize for all these issues! 😭
With the following:
{ config, ... }:
{
    services.openssh = {
        enable = true;
        extraConfig = mkOrder 0 ''
            TCPKeepAlive yes
            ClientAliveCountMax 480
            ClientAliveInterval 3m
        '';
        permitRootLogin = "yes";
    };
    environment.persistence."/persist".directories = [ "/etc/ssh" ];
}

I get the errors in the issue title. While the first is resolved with allowSFTP = false;, the sshd_config file itself is still prevented from being created, and I'd still like to use sftp. I still want the /etc/ssh directory to persist in case I create any manually controlled files down the line. Could you give any insight into what might be happening?
Thank you kindly for all the help, and again, I do sincerely apologize for taking up so much of your time!

I believe I may have solved the first issue, but the second issue persists; what seems to be happening is that the config is being created, then /etc/ssh is being linked, overriding the config. Is there a way to have the persistent directories linked first, then let everything happen?


use  bnd reporter gogo

Hi,
maybe you could use bnd-gogo plugin to generate Questions and answers.
https://github.com/bndtools/bnd/blob/master/biz.aQute.bnd.reporter/src/biz/aQute/bnd/reporter/plugins/entries/bundle/GogoPlugin.java
https://github.com/bndtools/bnd/tree/master/biz.aQute.bnd.reporter/src/biz/aQute/bnd/reporter/gogo/dto
e.g.
here we used it with a template do generate the readme
https://github.com/bndtools/bnd.reporter-demo/tree/master/mvn-workspace/org.domain.gogo#gogo-commands

@stbischof That's really an awesome idea to generate a report containing questions and answers. I will certainly try to introduce a bnd gogo plugin for this purpose. Thanks a lot for the pointer 👍

And if something is Missing its better to improve the descriptions in the bundles of the code.


repair broken links

I'll set up the broken link detector job in the GH pages repo so it can run after a successful deployment.
This draft PR is based on #257 so it needs to wait until that merges before marking the PR ready for review.

The broken link checker is set up to run on the same schedule as the publish.sh job. It's configured and working, and the broken links it's currently detecting are fixed in this branch.


add exceptionsList for Codeception

https://codeception.com/docs/04-FunctionalTests

Failures
 - kb2999226 (exited 1058) - Error while running 'C:\ProgramData\chocolatey\lib\KB2999226\tools\chocolateyinstall.ps1'.
 See log for details.
 - kb2919442 (exited 1058) - Error while running 'C:\ProgramData\chocolatey\lib\KB2919442\tools\ChocolateyInstall.ps1'.
 See log for details.
 - kb3035131 (exited 1058) - Error while running 'C:\ProgramData\chocolatey\lib\KB3035131\Tools\ChocolateyInstall.ps1'.
 See log for details.
Command exited with code 1058

appveyor/pr

@manuelpichler

@wirwolf please do not merge from other branches or tags such as 2.6.1 rebase from master instead.
This results in a cleaner history and focused PRs.

@wirwolf could you squash all these commits (including mine) into one or two? This is one of the situations where I think the commit history profits from a cleanup through a rebase with squash.

No need for a manual squash, we can use GitHub to Squash the PR rather than merge it.

@ravage84 No need for a manual squash, we can use GitHub to Squash the PR rather than merge it.

Doesn't that change the owner of the commit?

It changes the commiter, not the author.

lgtm, just add documentation

I know I'm late to the party, but is it possible to cover this feature with tests?

@wirwolf are you still interested in pursuing this?


Enhancement for EHPA recommendation

What type of PR is this?
feature && enhancement
What this PR does / why we need it:
enhancement for ehpa recommendation
implement recommendation updater
Which issue(s) this PR fixes:

Fixes #
Special notes for your reviewer:

/lgtm


Setting prop using Boolean (to trigger prop over attribute) always sets true

Using an Object form to trigger prop over attribute setting doesn't work with Boolean objects, because they always resolve to true when applied to boolean DOM properties expecting native booleans, such as checkbox.checked.
a = new Boolean( false );
console.log( !!a ); // outputs true
console.log( a.valueOf() ); // outputs false
By adding something like this to the inside of setProp, this can be easily resolved.
// Convert Boolean objects to native boolean values
if ( value instanceof Boolean ) {
  value = value.valueOf();
}

It's kind of costly to always check for boolean. Is it really necessary to create Boolean objects?

I'm not sure if the cost of the check is that great, but it is additional code to compile and ship. There is a cost to allocating the Boolean object however when using new, which applies to every diff regardless of whether or not there is a change.
I think a more promising approach would be to customize the behavior as described here: http://google.github.io/incremental-dom/#setting-values

For our project, we opted to change the default behavior of incremental-dom
to always assign boolean primitives to the property.
If you want to assign the attribute, you just have to convert to a string
literal first. If you want to assign a string property, you just use "new
String()".

Thank you all for the ideas. I ended up making typeof boolean always use setProp, the same way typeof object and typeof function already do. This introduces a typeof check, but it's less costly than constructing the Boolean during the render plus doing an instanceof on the other side.
The customizing behavior seems like a nice idea, but I worry about bugs. If the library behaves differently from project to project in sneaky ways depending on if the same hooks are setup I suspect there will be tricky to diagnose problems from sharing code or practices.

I've been playing around with this a bit more. The patch I'm using adds some code to  applyAttributeTyped, changing...
if (type === 'object' || type === 'function') {

to...
if (type === 'object' || type === 'function' || type === 'boolean') {

This check is very inexpensive, requires no object construction on the calling side and solves the general case of elegantly setting a boolean as a property. It's also easy to document this behavior - just as we already document the same behavior for objects and functions.
The alternative suggested is something like this:
attributes.checked = applyProp;
attributes.selected = applyProp;
attributes.disabled = applyProp;
// and so on for readonly/readOnly, multiple, isMap, defer, declare,
// noResize, noWrap, noShade, compact, etc.

This is a bit complex just to get standard HTML elements to behave as expected. Another problem with hooks is that it introduces potential conflicts when used with other types of elements, such as SVG or shadow-dom, which either have non-boolean attributes or properties with similar names or have boolean attributes or properties not explicitly listed - or both.
Are we sure it's not worth adding the boolean typeof check to the core library to resolve this problem in a simple, general and consistent way?

I've been playing around with this a bit more. The patch I'm using (based on ewinslow's comment) adds some code to applyAttributeTyped, changing...
if (type === 'object' || type === 'function') {

to...
if (type === 'object' || type === 'function' || type === 'boolean') {

This check is very inexpensive, requires no object construction on the calling side and solves the general case of elegantly setting a boolean as a property. It's also easy to document this behavior - just as we already document the same behavior for objects and functions.
The alternative suggested is something like this:
attributes.checked = applyProp;
attributes.selected = applyProp;
attributes.disabled = applyProp;
// and so on for readOnly, multiple, isMap, defer, declare,
// noResize, noWrap, noShade, compact, etc.

This is a bit complex just to get standard HTML elements to behave as expected. Another problem with hooks is that it introduces potential conflicts when used with other types of elements, such as SVG or shadow-dom, which either have non-boolean attributes or properties with similar names or have boolean attributes or properties not explicitly listed - or both.
Are we sure it's not worth adding the boolean typeof check to the core library to resolve this problem in a simple, general and consistent way?

We cannot change to use type === 'boolean'. Take for example:
let expanded = false; // This variable is set to a boolean value at some point.
...
// It now gets set as an attribute, and  converted to a string.
elementOpen('div', null, null, 'aria-expanded', expanded);

This cannot be set as a property and changing this will break existing users in a way that may not be easy to detect. I think for some uses this might not be a big concern, or they might want to have another way around like:
let expanded = false;
...
elementOpen('div', null, null, 'aria-expanded', toString(expanded));

or automatically do that a higher level construct that wraps elementOpen, but I think it all comes back to not using Incremental DOM directly, but rather configured in some sort of way for higher level usage.

@sparhami It seems like the main reason this can't be changed is for backwards compatibility reasons. There is a very clear and cheap (and I'd argue, more correct) solution, which is to use the string value:
elementOpen('div', null, null, 'aria-expanded', 'true');

Or another case, where you just need attribute presence:
elementOpen('button', null, null, 'disabled', '');

But setting-boolean-properties have much more painful workarounds.
I really think setting properties for booleans is the more intuitive behavior here. All code that assumes otherwise can be trivially changed to use strings today and still work fine. But if it's just too much trouble, then I totally get that...


Added new file for line number access

Added new file for line number access
Related to dotnet/docs#13958

@mairaw @rpetrusha How is this file used? Is it an automated system to warn when source code changes affect line numbers or are people supposed to manually look for these files when changing source code?  Is the process documented somewhere, and are there alternatives / has this process been assessed to determine if it's worth the overhead it adds?

Maybe missing parallel changes at c# ?
https://github.com/dotnet/samples/blob/master/snippets/csharp/VS_Snippets_Wpf/HOWTOApplicationModelSnippets/CSharp/access-by-line.txt

The details are in dotnet/docs#10241, @tdykstra. It isn't automated -- it hopefully alerts us that when a change is made to one of the files that's referenced by line number, we can manually update the line number references. So far, AFAIK, no line number references have been updated to assess how it works.


Can it run with Vietnamese corpus?

I have appended a short text in Vietnamese in "DBLP.5K.txt" but it went wrong with those words when I ran train_toy.sh. I don't know why it cannot read Vietnamese words, such as
_"ngành" becomes "ng" and "nh" (2 words) in the result, all letters with signs will be disappeared

We now support English, Spanish, and Chinese. Please subscribe our new method AutoPhrase and we will let you know if we support Vietanmese.


Provide lazy API for adding configuration actions to registered tasks without waiting for them to be configured

Expected Behavior
I'd like an API to access TaskProviders for tasks that will be registered (but not yet) without actually waiting for them to be configured. This way I can line up task dependencies without having to worry about ordering around when tasks are registered.
Current Behavior
no public API available for this.
Context

tasks.named(..) will throw if the task is not currently registered. This is racy, because it creates temporal coupling.
tasks.configureEach { } will only emit when a task is configured - not when a task is registered but not yet configured.

val generateBuildConfigConstantTask: TaskProvider<Task> = //...

// this API is clunky
tasks.configureEach {
    val task = this
    // we want `compileDebugKotlin', not `:myProject:compileKotlin'
    val taskNameWithoutProjectPath = this.name
        .split(":")
        .last()
    if (taskNameWithoutProjectPath == "compileKotlin") {
        dependsOn(generateBuildConfigConstantTask)
    }
}

Something like this would be nicer:
val generateBuildConfigConstantTask: TaskProvider<Task> = //...

tasks.whenRegistered("compileKotlin") {
  val taskProvider: TaskProvider<Task> = this
  taskProvider.configure {
    dependsOn(generateBuildConfigConstantTask)
  }
}

whenRegistered, or an overload of it, could optionally throw if a matching task is never found.
slack convo on this https://gradle-community.slack.com/archives/CAHSN3LDN/p1676670724506999

Thank you for your interest in Gradle!
This issue will be closed as a duplicate of

https://github.com/gradle/gradle/issues/8057

Please add your use case and 👍 to that issue.


Refractor

Refractor made on 3 files. There were several repeated values that could be easily converted to constants

Hi, thanks for contributing to SciPy.
We usually discourage very small fixes like these as explained in our contributing documentation: https://scipy.github.io/devdocs/dev/hacking.html#maintaining-existing-code
The reasoning behind it being that every contribution needs to be reviewed and incur maintainers (we are all volunteers) time and effort.
Could you maybe find more things like these to have something more substantial to contribute here?

Ok @tupui , no problem. I saw a lot of things that can be refractorized.

@JonanOribe the idea is that refactorizing code in a way that does not improve performance is typically undesirable. We do want to improve the style of the code base over time, but changes like this would need to be accompanied by some that e.g. fix a bug, improve accuracy, or make things measurably faster in the code being changed.

Indeed, what @tupui and @mdhaber said. Thanks for contributing though @JonanOribe. We'd love to get actual bug fixes or performance or feature enhancements.
Given that we prefer not to have such refactoring PRs, as explained in the note that @tupui linked to, I will close this PR. Please do open new PRs though if you can @JonanOribe.


fix: client: sending username instead of password for ascii authentic…

Hi I noticed when playing around with the example client that the when using the ascii authentication method the client is replying to the servers TAC_PLUS_AUTHEN_STATUS_GETPASS request with the username rather than the password. This PR addresses that issue

I've read your CLA and IANAL so without knowledge of what i'm signing, I won't be signing it. Feel free to close this PR and make the fix yourselves if you so wish.

thank you raising this to us, this is fixed in commit ce533c66222258bc6532baecfe974c901615bd6c

@PeppyH thanks for raising this, this is fixed in commit ce533c6. Is there a way that we could make the processing of raising PRs smoother for you ?

It purely came down to the CLA agreement. If i was making more large scale contributions to the project I would put the effort in to assess the CLA and sign it. But for a simple 1 line fix I don't like signing an agreement when you can just make the fix yourself


0.3.7-preview8 breaks button text

Description
Updated my model viewer app to use 0.3.7-preview8 and (most) buttons now have a (large) extra character at the start:
Before:

After:

Platform / Environment
Windows
Edit: originally misdiagnosed, now updated

Woah, yeah that doesn't exactly look right! UI.Toggle and UI.Radio all now come with an image to indicate their state and behavior, and to highlight that they're different from just a UI.Button. You can still create a Toggle/Radio behavior without the image using UI.Toggle(UIBtnLayout.None), though I don't believe I have that exact overload directly for Radio. Radio is just a Toggle with a wrapper to remove the ref keyword though.
The sized buttons definitely need some work though, and I'll need to look into how to do that better!

Yeah, pressed color is still high on my list right now! That's #506. I'll make sure Radio gets the same overloads as Toggle here :)


HTTP Error 500: Internal Server Error

Hi,
i actually have the problem that your script response
Traceback (most recent call last):   File "update_status.py", line 249, in <module>     MONITOR.update()   File "update_status.py", line 218, in update     self.send_data_to_catchet(monitor)   File "update_status.py", line 195, in send_data_to_catchet     int(monitor.get('status'))   File "update_status.py", line 102, in update_component     response = request.urlopen(req)   File "/usr/lib/python3.4/urllib/request.py", line 153, in urlopen     return opener.open(url, data, timeout)   File "/usr/lib/python3.4/urllib/request.py", line 461, in open     response = meth(req, response)   File "/usr/lib/python3.4/urllib/request.py", line 571, in http_response     'http', request, response, code, msg, hdrs)   File "/usr/lib/python3.4/urllib/request.py", line 499, in error     return self._call_chain(*args)   File "/usr/lib/python3.4/urllib/request.py", line 433, in _call_chain     result = func(*args)   File "/usr/lib/python3.4/urllib/request.py", line 579, in http_error_default     raise HTTPError(req.full_url, code, msg, hdrs, fp) urllib.error.HTTPError: HTTP Error 500: Internal Server Error
What can i do for fix everything has worked  few hours before this issue appears.

Fixed 5 min are to many responses for my server 10min are ok


Now it's stuck at this screen.

after 20 min its finally showed progress and installed. but when trying to launch this error happens

Please also run the install torch command which you will find in the README.md

i'm sorry i missed that part thank you

it worked


chore: dependabot multiple updates

Description
I marge all the Dependabot to this branch.
So the test run one time after all the five updates.
Not for every single update.

the tests already ran, but ok


Fix issue 118

This PR adds a completion handler for OT.initPublisher method
Contributing checklist

[ ] Code must follow existing styling conventions
[ ] Added a descriptive commit message

Solves issue(s)
#118
Hope this makes sense; We needed this callback to know exactly the moment initPublisher returns so we can publish to session right after that.

@msach22 is the project receiving PR? I've seen some old ones not merged yet, so just wondering :)

@oxcarga Thanks for filing the PR - to keep a consistent code base, how do you feel about making the PR like this:
https://github.com/opentok/cordova-plugin-opentok/blob/master/src/js/OTSession.coffee#L25
This would make sure that we're waiting on the code to complete in the native layer before executing the callback. I would also confirm that these callbacks are being called from the native layer.


Feedback regarding lesson: Basics 2

Please provide your feedback here...
Context
For context, this feedback refers to the lesson "Basics 2" in the course "Getting started with Lojban (alpha)".
I still do not understand the difference between bridi and jufra; if I understand that bridi relates to propositions and jufra to sentences; I understand that a proposition is always a sentence but a sentence is not always a proposition; since interrogative, exhortative, desiderative and exclamative utterances cannot be propositions, since they cannto be affirmated or negated.
Am I right? Am I wrong?
So, were I right, the exercise: "Don't panic" should be only a jufra and not a jufra and a bridi.

still do not understand the difference between bridi and jufra; if I understand that bridi relates to propositions and jufra to sentences; I understand that a proposition is always a sentence but a sentence is not always a proposition; since interrogative, exhortative, desiderative and exclamative utterances cannot be propositions, since they cannto be affirmated or negated.
Am I right? Am I wrong?
So, were I right, the exercise: "Don't panic" should be only a jufra and not a jufra and a bridi.


HIP 109: Hex Boosting by Deployment

HIP 109: Hex Boosting by Deployment

Author(s): Andy Zyvoloski &  Max Gold
Start Date: 2024-01-27
Category: Economic, Technical
Original HIP PR: #884
Tracking Issue: #888
Vote Requirements: veMOBILE Holders

Summary:
This Helium Improvement Proposal (HIP) allows Service Providers to specify what types of deployments their hex boosting can be applied to (i.e. CBRS vs Wi-Fi).
Rendered Text
https://github.com/helium/HIP/blob/main/0109-hex-boosting-by-deployment.md

HIP 109 was approved by the community on 11th April 2024 with a passing rate of 93.20%
https://heliumvote.com/mobile/proposals/EDQNHyLQ2ERkC28oS1EPoyt2pZpCSDU97Gyw42Ga3gQU


[Request]: Extract then delete

Is your request related to a problem?
No
How is the feature request related to the problem?
No response
Describe your proposed solution
Okay, so something I noticed with the official launcher is that you need 2x the download size for extracting the archives.
Collapse Launcher does the same and stores them as .zip.00x.xxxxxx in the game files.
Is it possible for it to extract one archive, delete the archive, then continue with the next one?
Honkai: Star Rail uses 2 archives, so taking the one that is larger and adding to the minimum disk size should be good enough.
Zenless Zone Zero uses 10 archives, so, again, taking the one that is the largest and adding to the minimum disk size should be good enough. This reduces the minimum disk size from 110GB to just about 60GB.
Describe alternatives you've considered
NIL, no alternatives other than to not implement it.
Additional context
No response

The thing with the segmented archive is that it is hard to predict when the extraction phase needs the other segment for a file. You can try it by only opening a merged 001 chunk and the 7z will say that the archive is corrupted.
But not to be afraid, easier (by storage requirements) download mechanism is planned to download all the files individually. But since currently, the API doesn't serve Zenless game files as individual extracted files then it's not possible to make the method for it (same reason Repair function is not there).

Yep, tried opening the archive with 7z and it says it is corrupted. Is it possible for Honkai: Star Rail then?

For HSR its planned to have more storage friendly soon if they refuse to use sophon chunked download system as I said previously


IAB ads.txt metadata

I'm looking forward to expand support of IAB standards for research on privacy and monetisation topics.
Here I'm adding support for Authorized Digital Sellers.
By assisting in the digital advertising supply chain transparency, it may help mitigate the risk of users’ data being misused.
Idea is to look into adoption of these, and correlation with the tracking and compliance tech used.
I started with some basic information, example with https://www.msn.com/:
{
  "ads": {
    "account_count": 1124,
    "account_types": {
      "DIRECT": {
        "domains": [
          "appnexus.com",
          "teads.tv",
          "google.com",
          ...
          "adpushup.com",
          "nativo.com",
          "snigelweb.com"
        ],
        "domains_count": 288
      },
      "RESELLER": {
        "domains": [
          "google.com",
          "indexexchange.com",
          "media.net",
          ...
          "amxrtb.com",
          "connectad.io",
          "mobfox.com"
        ],
        "domains_count": 836
      },
      "other": {
        "domains": [],
        "domains_count": 0
      }
    },
    "line_count": 1268,
    "present": true,
    "redirected": false,
    "status": 200,
    "variables": [
      "INVENTORYPARTNERDOMAIN",
      "MANAGERDOMAIN",
      "OWNERDOMAIN",
      "SUBDOMAIN"
    ],
    "variable_count": 4
  },
  "app_ads": {
    "present": false,
    "redirected": true,
    "status": 200
  }
}

Arrays like $.account_types['DIRECT'].domains can be quite large, so I'm looking forward to your comment whether it's feasible/efficient to keep them to research advertising supply chains.
P.S. While working on it I also found IAB developed their own data explorer. Though I couldn't get access to that data.

It looks like this PR includes all of the other workflow code from #89. Should we put this in Draft mode until that gets merged? To keep things moving we could set this PR to merge into wpt-test-action so we can get a diff of changes only for the custom metric.

@rviscomi Sure, I reset this branch to narrowly scoped changes.
I mistakenly expected we'd have the other one merged by this time.
I've also removed the lists of domains for now.


Diachronic topic words

A user should be able to:

Select a cluster
Generate multiple sub-clusters (e.g. one per year or decade)
Get the topic words for each sub-cluster

Use case: observe the development of a cluster over time.

Might be an issue of visualization and dynamic filtering.

Fixed by #117


Disabling 'export image' functionality if provider is google maps

Basically it will check the map provider and if it is GMaps, 'image export' option won't be available.

Fixes https://github.com/CartoDB/cartodb-management/issues/3818
cc @javisantana @jatorre @saleiva

Frontend tests were OK :+1: (details)

@viddo could you check it? CTO remains busy :).

Looks OK, but why not keep the provider details internally in the map model? I.e. provide some canExport method that internally do that provider.toLowerCase().indexOf("googlemaps") === -1 check?

better @viddo?

Frontend tests were OK :+1: (details)

:+1:


g2o: 20230223 -> 20230806

Description of changes
https://github.com/RainerKuemmerle/g2o/releases/tag/20230806_git
The only package in nixpkgs that depends on g2o is rtabmap, which requires a patch to be compatible with this update. There are ROS distro specific tags of rtabmap 0.21.1 (ie. 0.21.1-rolling, 0.21.1-humble, etc.) that include this patch, but there is no plain 0.21.1 tag, so I decided not to update rtabmap and just backport the patch.

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[x] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

cc @ckiee

thank you! feel free to add yourself to rtabmap's maintainer list if you'd like that (:

Result of nixpkgs-review pr 250016 run on x86_64-linux 1

4 packages built:

g2o
g2o.debug
g2o.dev
rtabmap

rtabmap does run, but I will not be testing with hardware as there's significant setup with mine:

I don't currently use rtabmap, so I don't think I should be a maintainer.

@ckiee Can this be merged?

@lopsided98 no idea why i didn't merge! will rerun tests now (:


ClusterClient.FlushALL() don't work.

I cannot run ClusterClient.FlushALL() to wipe all data on different nodes. It only can wipe one node.

We discussed this at #219 .


Analyze unsummarized ops data from ODSP relay service

Analyze unsummarized op data in couple days, when we have more data (change just deployed fully on Friday 4/15):
https://portal.microsoftgeneva.com/dashboard/PushChannelDOGFOOD/MicroServiceCil/Fluid%2520Counters

Opened #10063 based on looking at the data. We can push this out to re-examine in future.

@GaryWilber, link above does not work anymore. Any chance you can fix it (provide new one)? Thanks!

Link allowing to do queries: https://portal.microsoftgeneva.com/s/4FA34F33
Looks like at the moment around 70% of sessions have 6 or less trailing ops, which in most cases means fully summarized (ops are summarize, summarize ack, leave (smmarizer), leave (main client), noClient).


Make building example optional

Good for me, thanks.
Another step will be to separate all the files in the Ui/Nano subfolder, which is the standalone renderer, and make them optional too. I'll work on it soon


add walking on stairs (animation and script)

most games don't do walking on the stairs right, they just make a flat collision so the character looks like sliding on the stairs instead of walking on them (even with IK it won't look very natural)
I will try to add a system to detect stairs and walk naturally on them.

[script]
[animations]


[1016] Pagination for trainee index page

Context
https://trello.com/c/4cyAQVXw/1016-l-trainee-pagination
Changes proposed in this pull request
This PR:

Adds kaminari gem for basic pagination helpers
Add styles for pagination from MoJ design system
Generates custom views for kaminari to reflect designs
Implements the Paginator component from the Apply codebase. This is  responsible for:

rendering the "Showing 1 to 29 of 50" results" message
passing custom pagination configuration to the kaminari's paginate view helper based on the number of results and pages

Implements a PaginatedFilter component which wraps both the filters and the returned results.
Updates the TraineeController to return a full dataset of trainees so that we can paginated across draft trainees and completed trainees as one list (see guidance to review for thinking).

Guidance to review
Code review: That trainee controller code

Previously we were exposing two datasets to the view - drafts and non-drafts. However, we now need a single dataset @trainees to paginate over.
We cannot use GROUP BY to distinguish the drafts from the non-drafts, because that negates the single dataset.
Therefore, I've used ORDER BY and a CASE statement on trainee state to ensure the draft trainees are returned at the top of the dataset for pagination.
This ordered_by_drafts is then followed by the existing ordered_by_date to ensure the two groups separately ordered by updated at
Then in the controller, you can't use a WHERE clause to return the paginated drafts / non-drafts to render, since this removes kaminari's pagination. The WHERE clause is added to the beginning of query, i.e. before kaminari's LIMIT and OFFSET, resulting in two separate paginated datasets. Hence, I've used select.

Product review: Page size
Currently, I've set the page size to be 30 i.e. there are at most 30 records shown on each page. Is this reasonable?
Product review: Section header counts vs total paginator count
The count in the section headers are the totals for both draft trainees and completed trainees regardless of pagination, which makes sense. However, do they make the total in the paginator confusing?
e.g. in the below example, I have seven draft trainees (more than the page size), so the section header for completed trainees isn't shown. At the bottom is shows "Showing 1 to 3 of 10" which is correct, but potentially confusing.

Product review: Invalid page params
The paginator deals with the situation where a user entered a page param that is greater than the actual number of pages (maybe from a bookmarked URL). It simply shows the number of actual results and links to get back to the 'real' pages. However, we have fallback wording for no trainees that now looks odd in this situation:

@AbigailMcP thoughts on redirecting without pagination if the user loads a page with no results?
We'll probably want to do that anyway if you're on page 4 and then turn on some filters, greatly reducing the count.

 [L] Trainee Pagination

@AbigailMcP thoughts on redirecting without pagination if the user loads a page with no results?
We'll probably want to do that anyway if you're on page 4 and then turn on some filters, greatly reducing the count.

@edwardhorsford - I've gone with the redirect, I think it feels like the best option.
I've made all the changes as per your review here: 2679a6c

@defong @edwardhorsford - all review points should be addressed now! I've also merged in master this morning, so it should now be compatible with @darokel 's data export i.e. the download is of all trainee records, sorted and filtered, but pre-pagination.


[JA Currency] Currency refinements

54 cases pass; 3 cases fail.
Failing cases:

"人民元八千元", "人民元五十元": The unit is split around the number but NumberWihUnitExtractor explicitly prevents to extract both prefix and suffix units for Currency to avoid other issues.
"金融市場で運用する資金運用事業を合わせた財投総額も過去最大の同二％減の四十九兆九千五百九十二億円となっている。": NumberExtractor does not correctly extract the large number.

Modified cases:

A typo, '憶' instead of '億' has been corrected in a few inputs.
"東芝の再編はもう一万憶が必要、取引銀行に借り入れを申請した。"  -> "東芝の再編はもう一万億円が必要、取引銀行に借り入れを申請した。", missing expected unit '円'.

"人民元八千元", "人民元五十元": The unit is split around the number but NumberWihUnitExtractor explicitly prevents to extract both prefix and suffix units for Currency to avoid other issues.

How common is this situation? We may need to have special handling for Japanese.

"金融市場で運用する資金運用事業を合わせた財投総額も過去最大の同二％減の四十九兆九千五百九十二億円となっている。": NumberExtractor does not correctly extract the large number.

Is this a somewhat "typical" case? If so, please open a bug to address it.
Thanks.

"人民元八千元", "人民元五十元": The unit is split around the number but NumberWihUnitExtractor explicitly prevents to extract both prefix and suffix units for Currency to avoid other issues.

How common is this situation? We may need to have special handling for Japanese.

I will check how to handle this pattern, it is used also in Chinese (where is also not supported)

"金融市場で運用する資金運用事業を合わせた財投総額も過去最大の同二％減の四十九兆九千五百九十二億円となっている。": NumberExtractor does not correctly extract the large number.

Is this a somewhat "typical" case? If so, please open a bug to address it.

Actually here the number is extracted correctly by the NumberExtractor in Default mode but it fails in ExtractAll mode used by NumberWithUnit, so it should not be too difficult to fix, I will have a look.

"人民元八千元", "人民元五十元": The unit is split around the number but NumberWihUnitExtractor explicitly prevents to extract both prefix and suffix units for Currency to avoid other issues.

How common is this situation? We may need to have special handling for Japanese.

I will check how to handle this pattern, it is used also in Chinese (where is also not supported)

Any updates on this? Depending on how frequent, we could merge as-is and open an extension issue for this new behaviour.
I believe it's not super common...

Any updates on this? Depending on how frequent the cases and how complex to fix, we could merge as-is and open an extension issue for this new behaviour. I believe it's not super common...

Probably yes, our Japanese linguist said expressions like "人民元10元" sound a bit odd and "10人民元" would be preferable (but on the other hand, a web search returns more results for "人民元10元" than for "10人民元").
I was trying to solve the issue by simply skipping the currency checks in NumberWihUnitExtractor for CJK cultures, but this creates other issues (e.g. "4人民币 5美元" returning a single result instead of 2).
So, I would say to address this in a separate issue because a more careful treatment is needed.


WCTIndexer should not fail silently

The method createIndex in WCTIndexer has a Retryable annotation, yet does not log all errors that can occur. This can make configuration or networking issues hard to pinpoint, since the thread will silently retry the call Integer.MAX_VALUE times. The method should catch all exceptions and log a warning or an error before the next iteration.

This issue no longer occurs in the master branch, due to the way the visualisation code has been implemented


bugfix: fix apply

Describe what this PR does / why we need it
Fix the following two issues:

apply with mode loadImage will also launch the app
apply with no node scale will launch the apps  and do not distribute the image rootfs

Does this pull request fix one issue?

Describe how you did it
Describe how to verify it
Special notes for reviews

Codecov Report
Patch coverage: 100.00% and project coverage change: +0.01 :tada:

Comparison is base (a2ea705) 18.79% compared to head (9be5901) 18.81%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2116      +/-   ##
==========================================
+ Coverage   18.79%   18.81%   +0.01%
==========================================
  Files          96       96
  Lines        8921     8923       +2
==========================================
+ Hits         1677     1679       +2
  Misses       7017     7017
  Partials      227      227

Impacted Files
Coverage Δ

pkg/imageengine/buildah/inspect.go
38.14% <100.00%> (+1.30%)
:arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Modal Has Two Sets of Buttons

I believe that this line is supposed to remove the duplicate set of buttons: https://github.com/sferik/rails_admin/blob/master/app/assets/javascripts/rails_admin/ra.remote-form.js#L73
But https://github.com/sferik/rails_admin/commit/f6d660fae06e97852e61422520e18fb9064f51bd changed .form-actions to .form-group, which probably should not be removed quite so aggressively.

Good shout. .form-actions isn't a class used in Bootstrap anymore, so perhaps we should leave it in on the _submit_buttons.html.erb partial. I've tested locally and it works fine.


Makefile: add explicit make target for gcs.push

enumerate missing PHONY targets
add gcs.push target to replace the push target expansion on HUB set to gcr.io
explicitly call gcs.push where HUB was being set to gcr.io (prow's pre-submit)
reviewed files referencing HUB to see which target to call (may need some follow-up changes on GKE docs)

Fixes #14962
Replaces #15817 which was getting out of hand on rebase (CLA complaining on multiple authors, etc.)
CC @sushicw @utka @howardjohn @linsun

@utka can you verify there isn't anywhere else we need the gcs.push?

Affected areas:
[ ] Configuration Infrastructure
[ ] Docs
[ ] Installation
[ ] Networking
[ ] Performance and Scalability
[ ] Policies and Telemetry
[ ] Security
[X] Test and Release
[ ] User Experience
[X] Developer Infrastructure

/assign @howardjohn @linsun

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: elevran
To complete the pull request process, please assign linsun
You can assign the PR to them by writing /assign @linsun in a comment when ready.
The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS
prow/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@elevran: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

integ-mixer-k8s-presubmit-tests-master
fe17b973435ed59362d0310be088a29fa9527786
link
/test integ-mixer-k8s-presubmit-tests-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

what about postsubmit.sh like in your first pr?

@howardjohn - file prow/istio-postsubmit.sh was removed by #15685 so change is no longer needed.
I grep'ed for make ... invocations in file containing setting of HUB to gcr.io. I think this provides full coverage of affected files.

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: elevran, howardjohn
To complete the pull request process, please assign linsun
You can assign the PR to them by writing /assign @linsun in a comment when ready.
The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS [howardjohn]
prow/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

/assign @linsun
@linsun Can you please take a look? Small change set, so hopefully can be reviewed quickly

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: elevran, howardjohn, linsun
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [howardjohn,linsun]
prow/OWNERS [linsun]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@elevran: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

integ-mixer-k8s-presubmit-tests-master
fe17b973435ed59362d0310be088a29fa9527786
link
/test integ-mixer-k8s-presubmit-tests-master

istio-unit-tests-master
fe17b973435ed59362d0310be088a29fa9527786
link
/test istio-unit-tests-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@elevran: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

integ-mixer-k8s-presubmit-tests-master
fe17b973435ed59362d0310be088a29fa9527786
link
/test integ-mixer-k8s-presubmit-tests-master

istio-unit-tests-master
fe17b973435ed59362d0310be088a29fa9527786
link
/test istio-unit-tests-master

istio-racetest-master
fe17b973435ed59362d0310be088a29fa9527786
link
/test istio-racetest-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/retest

@elevran: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

istio-racetest-master
fe17b973435ed59362d0310be088a29fa9527786
link
/test istio-racetest-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/retest

@elevran: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

integ-security-k8s-presubmit-tests-master
fe17b973435ed59362d0310be088a29fa9527786
link
/test integ-security-k8s-presubmit-tests-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/retest

@elevran: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

istio-racetest-master
fe17b973435ed59362d0310be088a29fa9527786
link
/test istio-racetest-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/retest


pytooling: Bump deps

Fixes issue with compiling python eggs on debian:testing based systems (maybe others).
Fix #21394
Signed-off-by: Ryan Northey<EMAIL_ADDRESS>Commit Message:
Additional Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]

successfull docs/build.sh runs for debian testing/unstable can be seen here:
https://github.com/phlax/ratcatcher/actions/runs/2358679468


azure-stack-get-pki-certs.md discourage SingleCSR

Update to azure-stack-get-pki-certs.md to discourage generating a single CSR with all DNS Names.  This is against best practice and should only be considered in dev/test environments.

@johnerskine : Thanks for your contribution! The author, @mattbriggs, has been notified to review your proposed change.


First pass on documentation

Goal
Give a first pass on the documentation, ensuring all the basics are there.
Context
Agreed by the team, we want to have good documentation from the beginning of the project.
Required features
Each python function under model/src/pyrenew should:

Have a docstring featuring (i) a description, (2) parameters, and (3) outputs following numpy's style.
All functions should have type hints (link)

In the case of the demos under model/docs, these should also be checked.
For the latter, here is an example of a good typed hinted function:
import jax.numpy as jnp
from pyrenew.metaclass import RandomVariable

def myfun(
  x: str,
  y: jnp.array,
  z: RandomVariable
  ) -> None

Specifications
The following files under model/src/pyrenew should be checked:

[ ] convolve.py
[ ] distutil.py
[ ] math.py
[ ] mcmcutils.py
[ ] metaclass.py
[ ] regression.py
[ ] transform.py

Under latent/

[ ] hospitalizations.py
[ ] infection_functions.py
[ ] infections.py

Under model:

[ ] hospitalizations.py
[ ] rtinfectionsrenewal.py

Under observation

[ ] negativebinomial.py
[ ] poisson.py

Under process

[ ] ar.py
[ ] firstdifference.py
[ ] rtrandomwalk.py
[ ] simplerandomwalk.py

Under model/docs:

[ ] getting-started.qmd
[ ] pyrenew_demo.qmd

The PR associated with this issue should use #16 as a baseline.

@cshelley, I would start 1 PR for checking the stuff under docs, but first, wait for #39 to be merged, as I've added lots of docs there. @AFg6K7h4fhy2, let's meet with @cshelley to see how we distribute this.


Merge changes for 26/03/17@1

Fixed/Added javadocs for some classes

DO NOT merge before #17 has been merged.

v0.2.0 is complete, awaiting confirmation by @angelickite or @sozemego.

Theres a few things i consider questionable. Like for example the way the screen setting works or how multiple glyphlayouts are generated even though they are heavy objects among other things.
Though these issues can be addressed later through individual issue tickets. Blocking master branch any longer seems like the worst option so im ok with this for now.

@angelickite good points. I'll merge when you accept the review.


fixes #100 by using object destructuring

At certain places like line 22 in stale.js we haven't used Object destructuring but at other places we do that. This definitely makes the code inconsistent. This PR fixes that

@JasonEtco please can you review my PR

Thanks @JasonEtco for mergin the PR, I'll be trying to make more valuable PRs next time


finish-callback does not work with end-time in

finish-callback only works with countdown. finish-callback does not work with end-time in <timer>. When finish-callback is added, the callback immediately triggered .

I just ran into a similar issue.  It does seem to work with end-time for me.  It triggers the callback immediately if end-time is in the past, and that applies within a digest cycle and everything works as expected.  However, once the end time is actually reached, it seems to trigger the callback but not $apply() the changes, so angular is not aware of them.
Since in one scenario a digets is already running, but not in the other, I ended up doing this as a work around so that the changes in this function are always applied, but it doesn't conflict with an existing digest:
$scope.myCallbackFunction = function() {
        $timeout(function() {
            // Code
        });
}

This is the directive tag:
<timer finish-callback="myCallbackFunction()" end-time="1452126400000" max-time-unit="'hour'" interval="1000">
    ....

Seems a little dirty, but gets the job done and works as expected in all cases.  Maybe the timeout should be extracted into directive itself, or maybe it could be handled another way all together.  I'll try to dig into the code later if I have time and see if I can get a better solution.
Let me know if you found a better solution for your issue.

My app shows, thanks to finish-callback, an "expired" alert if end-time is in the past. It works great if timer tag is in one static place (it means, not inside ng-repeat).
I have a ng-repeat list which prints all homeworks end-times, if all times are in present there aren't problems. But if one time is in past, suddenly ALL times are in past, which is incorrect.
I've made your workaround (for ng-repeat list, like you, in controller) but without success.

+1
Please fix this bug


AVRO-2629: Use Java Collections and Arrays Utilities

Make sure you have checked all steps below.
Jira

[X] My PR addresses the following AVRO-2629 issues and references them in the PR title.

Tests

[X] My PR adds the following unit tests OR does not need testing for this extremely good reason:
No change in functionality

Commits

[X] My commits all reference Jira issues in their subject lines. In addition, my commits follow the guidelines from "How to write a good git commit message":

Subject is separated from body by a blank line
Subject is limited to 50 characters (not including Jira issue reference)
Subject does not end with a period
Subject uses the imperative mood ("add", not "adding")
Body wraps at 72 characters
Body explains "what" and "why", not "how"

Documentation

[X] In case of new functionality, my PR adds documentation that describes how to use it.

All the public functions and the classes in the PR contain Javadoc that explain what it does

Thanks for this one too @belugabehr


⚠ Bofrost.be has degraded performance

In 7955ffb, Bofrost.be (https://www.bofrost.be) experienced degraded performance:

HTTP code: 200
Response time: 2389 ms

Resolved: Bofrost.be performance has improved in e5e37fd.


removing animationsEnabled and highlightsEnabled as they were mostly …

Problem:
@seanparsons and I were digging through some old code and we realized that animationsEnabled and highlightsEnabled are not respected anymore, and the Canvas Strategies' state patching system supersedes them.
Fix:
KILL EM'
Note
Highlights enabled was connected to a Keyboard Shortcut: pressing Z would set highlightsEnabled to false – and releasing Z would set highlightsEnabled to true. I deleted these shortcut alongside the editorState. Oddly enough pressing Z also hides all canvas controls - including highlights, so I think we are not losing any functionality with this deletion. I just wanted to call out to @maltenuhn if he remembers the reason we had a configurable shortcut to hide highlights – pre-set to 'Z'

Holding down z enters zoom mode (mouse pointer changes, click to zoom in). Obviously while in zoom mode, no highlights should trigger or other canvas controls show up, since they can make it harder to see what you want to zoom in on. Especially if you're trying to zoom in in order to see something you know is obscured by canvas controls.

 Obviously while in zoom mode, no highlights should trigger or other canvas controls show up, since they can make it harder to see what you want to zoom in on. Especially if you're trying to zoom in in order to see something you know is obscured by canvas controls.
Okay then I think the new behavior is correct: we still hide all controls while in zoom mode. (while Z is pressed)

(This should IMO be orthogonal to the strategies, unless we consider zoom mode to be a strategy itself?)
Yep it's orthogonal, and for now I think we shouldn't make zoom a strategy, so all is good


Grant everyone can view role to konflux-support

There are people supporting Konflux that do not belong to any official Konflux team that we want to grant view access to our clusters. A new rover group was created to put those people in so grant view role to that new group.
KFLUXINFRA-1173

/lgtm


Link to Purchase from Pool pages

Description
This PR links the "Buy" button from a Project Pool Price to the correct page.
Still, this issue remains:

A price for a project might not be correct, see comment
This can result in the total costs for 1 tonne amount being lower than a single unit price per tonne.
Please double check how the total costs for redeem are retrieved here

E.G.:

https://carbonmark-git-lady-link-to-redeem-klimadao.vercel.app/projects/VCS-191-2008/purchase/pools/bct
https://carbonmark-git-lady-link-to-redeem-klimadao.vercel.app/projects/VCS-1140-2015/purchase/pools/ubo
https://carbonmark-git-lady-link-to-redeem-klimadao.vercel.app/projects/VCS-981-2014/purchase/pools/nct

=> the total costs are lower than a single unit price (with 1 tonne amount)
Related Ticket
Resolves https://github.com/KlimaDAO/klimadao/issues/1219
Checklist

[x] I have run npm run build-all without errors
[x] I have formatted JS and TS files with npm run format-all

I will try to get #1232 merged before this, which will resolve the pricing discrepancy on default projects


NameError: name 'info_size' is not defined

Just FYI... I cloned master (f7179f1bc5a49e17496f58c1848b85f09cf0c022), ran the script, and got this error:
# apt-select.py
Getting list of mirrors ... done.
Testing 73 mirror(s) [73/73] 100%
Traceback (most recent call last):
  File "/root/bin/apt-select.py", line 245, in <module>
    if info_size == 0:
NameError: name 'info_size' is not defined

I'm having trouble reproducing this error.  It seems the only possible cause is if there were an empty dictionary of latency measurements.  The culprit for no successful round trip measurements could be network latency so high that it exceeds the TCP socket timeout (2.5 seconds).  This script is probably not much use if the machine's latency to all servers is over 2.5 seconds.  In that case, an improvement of < 150 ms would likely be insignificant, and downloads would be a crawl regardless of the server they use.
A check for uncommon connectivity issues has been added in 9ee835d348.


nixVersions.latest: 2.22.1 -> 2.23.0

Changes: https://github.com/NixOS/nix/blob/2.23.0/doc/manual/src/release-notes/rl-2.23.md
Description of changes

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Result of nixpkgs-review pr 319395 run on x86_64-linux 1

11 packages built:

nil
nixVersions.latest
nixVersions.latest.debug
nixVersions.latest.dev
nixVersions.latest.doc
nixVersions.latest.man
nixVersions.nix_2_22
nixVersions.nix_2_22.debug
nixVersions.nix_2_22.dev
nixVersions.nix_2_22.doc
nixVersions.nix_2_22.man


Elden Ring mods not working

Extracting every single mfing file directly into ModEngine2's mod folder yet not a single change has happened to my game. The only results seem to come from moving all of the individual files contents into the folder itself and even then nothing is changing besides some icons and menus.

same


Improve dict2imas & isequal

Summary
This PR introduces new dict2imas and isequal methods, where the original counterpart methods are quite slow at the first call due to the long compilation time.
In particular, diff(dd1,dd2) is extremely slow at the first-call (takes more than 1 hour).
The new isequal(dd1,dd2) or equivalent dd1==dd2 is greatly faster at the first-call (takes only 0.27 secs).
In addition, the new method with flag, i.e. isequal(dd1,dd2; verbose=true), can provide more verbose comprehensive information about the differences between two IDS objects.
The followings are quick performance comparisons:
1. dict2imas performance comparison
The new dict2imas is about twice faster at the first-call.

Original dict2imas for sample/omas_sample.json

first-call (with compilation): ~ 20 seconds
after that: ~ 17 ms

New dict2imas for sample/omas_sample.json

first-call (with compilation): ~ 10 seconds
after that: ~ 17 ms

2. diff vs isequal performance comparison
The new isequal is more than 10,000 times faster a the first call.

diff(dd1, dd2)

first-call (with compilation): > 3600 seconds (≈ 1 hour)
after that: ~ 40 ms

isequal(dd1, dd2) or dd1 == dd2

first-call: (with compilation): ~ 0.27 seconds
after that: ~ 8.5 ms

Current feature
# First call
@time dd1 = json2imas("sample/omas_sample.json")

# Benchmark after the first call
@benchmark dd2 = json2imas("sample/omas_sample.json")

@time diff(dd1, dd2) # Note: This will take more than 1 hour

Note that the number of allocations for the first-call of diff is huge (~ 1.75 G allocations), which makes it extremely slow.

# Modify dd2 to compare it with dd1
dd2.equilibrium.time_slice[1].profiles_1d.volume=[1.0,2,3];
dd2.equilibrium.time_slice[1].profiles_1d.psi[[1,7,8,13,15]].= rand(5);
dd2.equilibrium.time_slice[1].profiles_2d[1].psi .= 0.0;
dd2.core_sources.source[1].identifier.name="abcde"

diff(dd1, dd2)

diff briefly shows the differences.

New feature
# First call
@time dd1 = json2imas("sample/omas_sample.json")

# Benchmark after the first call
@benchmark dd2 = json2imas("sample/omas_sample.json")

# First call
@time isequal(dd1, dd2)

# Modify dd2 to compare it with dd1
dd2.equilibrium.time_slice[1].profiles_1d.volume=[1.0,2,3];
dd2.equilibrium.time_slice[1].profiles_1d.psi[[1,7,8,13,15]].= rand(5);
dd2.equilibrium.time_slice[1].profiles_2d[1].psi .= 0.0;
dd2.core_sources.source[1].identifier.name="abcde"

isequal(dd1, dd2; verbose=true)

Notes
[v] all tests passed

@orso82 I reflected on your comments in the last commit. Thanks!


Updating Package Manifest Schema in Private Preview API

MSFT employees can try out our new experience at OpenAPI Hub  - one location for using our validation tools and finding your workflow.

Changelog
Please ensure to add changelog with this PR by answering the following questions.

What's the purpose of the update?

[ ] new service onboarding
[ ] new API version
[x] update existing version for new feature
[ ] update existing version to fix swagger quality issue in s360
[ ] Other, please clarify

When you are targeting to deploy new service/feature to public regions? Please provide date, or month to public if date is not available yet.
When you expect to publish swagger? Please provide date, or month to public if date is not available yet.
If it's an update to existing version,  please select SDKs of specific language and CLIs that require refresh after swagger is published.

[ ] SDK of .NET (need service team to ensure code readiness)
[ ] SDK of Python
[ ] SDK of Java
[ ] SDK of Js
[ ] SDK of Go
[ ] PowerShell
[ ] CLI
[ ] Terraform
[ ] No, no need to refresh for updates in this PR

Contribution checklist:

[ ] I commit to follow the Breaking Change Policy of “no breaking changes
[ ] I have reviewed the documentation for the workflow.
[ ] Validation tools were run on swagger spec(s) and errors have all been fixed in this PR. How to fix?

If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist

[ ] Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.

Adding new API(s)
Adding a new API version
Adding a new service

[ ] Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

[ ] If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist
If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.

[ ] Removing API(s) in stable version
[ ] Removing properties in stable version
[ ] Removing API version(s) in stable version
[ ] Updating API in stable version with Breaking Change Validation errors
[ ] Updating API(s) in preview over 1 year

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
Please follow the link to find more details on PR review process.

hi @ArcturusZhang could you pls confirm Go sdk impact for breakingchange-go? HI @changlong-liu could you pls help to confirm Python SDK impact for breakingchange-python? thanks

Hi @yungezz , Python reported breaking changes exists in previous PR https://github.com/Azure/azure-rest-api-specs/pull/11263.
I think this PR is fine.
CC: @msyyc , @jsntcy

@yungezz breaking changes in go SDK are expected.

Hey folks, this API is still in Private Preview and only used by our Service's Dashboard in the Azure Portal currently.

/azp run


Window borders

Discussion on how best to implement window borders. Two main choices:

Draw them with GL in wlc's pre-render hook
Create rgba surfaces for each window that sit behind each window and draw the border around it

I'm really not convinced either way is the obvious solution. Discuss.

Just a few thoughts. Which is the easiest to implement right now and what
would be the performance of each? We might not know that yet though
On 26 Jan 2016 8:19 am, "Drew DeVault"<EMAIL_ADDRESS>wrote:

Discussion on how best to implement window borders. Two main choices:
Draw them with GL in wlc's pre-render hook
Create rgba surfaces for each window that sit behind each window and draw
the border around it
I'm really not convinced either way is the obvious solution. Discuss.
—
Reply to this email directly or view it on GitHub.

With rgba surfaces, wouldn't that mean that the user could specify the colors too and hence a colored border? I think that would be good choice in terms of customization...

You can specify color in gl too :)
On 26 Jan 2016 8:36 am, "Seth Barberee"<EMAIL_ADDRESS>wrote:

With rgba surfaces, wouldn't that mean that the user could specify the
colors too and hence a colored border? I think that would be good choice in
terms of customization...
—
Reply to this email directly or view it on GitHub
https://github.com/SirCmpwn/sway/issues/477#issuecomment-174674066.

Probably easier to implement with GL. Unsure about the performance.

Probably, but the GL backend for cairo is experimental. Not sure what that implies.

Hmm most wayland client code/tutorials that I have seen all use egl and cairo and they all run ok

Well, if it works, it works.

Would the surface method be something like

Create a surface and attach to a view
When rendering the view also render the surface

The surface method would be to create a new surface every time a view is created that needs window borders and somehow associate it with that window, then move it during the layout arrangement.

I am leaning towards the pre hook method as we only need to calculate and draw the border instead of dealing with creating/linking/moving/drawing another object

I'm just chiming in with my 2 cents, but I really hope Sway is planning to support window buttons at some point in the future, and that whatever decision is made will allow for that feature down the road!!
I know i3 does not do this and has no plans to do so, but it would be great if Sway did

I have no intention of implementing window buttons.

Aww sad.

How will this interfere with client-side window decoration?

@gpyh they will just be inside the borders drawn by sway.

@ViktorNova if you're sad and have the skills, fork it. For something keyboard-operated like Sway, there's no reason to have them.

I'm not very familiar with the current situation, but isn't it basically just using the wallpaper? With i3, there's no “justification” for having wallpaper, as it's never shown while windows (except the floating kind) are up, but here, the wallpaper could be the borders, providing a practical reason to have one.
Basically, I'm suggesting not implementing custom borders at all, but I don't know if that would entail a loss of functionality.

I don't really understand what you're suggesting.

@ke7ofi borders are very helpful to see what window has focus, in i3 the focused window has a blue border while the others have a grey border (by default).
Also the title of the window is nice to have.

Borders are also very useful in the tiled and stacking layouts.

@mikkeloscar I rarely use the titles except when they're forced (in tabbing mode), but I definitely see why that's important. Focus is also important, so I suppose my suggestion didn't make sense, sorry.

Also worth noting is the hide_edge_borders feature, since its potential implementation might affect the consideration of how to implement window borders.

As for the discussion, I see titlebars and borders as two separate features:
Titlebars are definitely needed for stacking/tabbed layouts.
Borders are only necessary as an indicator of focus, but otherwise they're just a cosmetic feature.

As for the discussion, I see titlebars and borders as two separate features:

They aren't, really.

I'm not sure how separate you're thinking of, but I think i3's semi-optional titlebars are a reasonable implementation. (I guess reasonable design is a large part of why I like i3 so much, actually.)

The reason this makes me sad is because right now there is no such thing as a tiling window manager that is touchscreen-friendly. However, i3 accidentally turned out to be damn near perfect for a touchscreen, but because of the main developers ideals, they 'will never add window decoration buttons'.
I was hoping with Sway's broader goals and a different crew that I might be able to persuade you to at least consider this feature that, if implemented, could possible make Sway a major contender in the rapidly growing touchscreen market that is currently only served by window managers that are floating and/or fullscreen only.
Sadly I am not a coder, or I would absolutely fork it myself!

We're going to be adding multitouch bindings in the future, so you could bind a gesture to do whatever the buttons could do.

@ViktorNova what about CSD? Most clients has it enabled by default in wayland so the buttons are already there.

@SirCmpwn - That is EXCELLENT to hear, I will definitely keep my eye on the project! =)
@mikkeloscar - This is unfortunately true only for GTK3 apps, which only accounts for a portion of Linux desktop software


Refactor multimedia configuration and conversion

The handling of multimedia.properties and multimedia conversion is a bit confusing and has duplication.  It could be refactored to greatly simplify and reduce code.

@billingb , I will assign all the various open multimedia processing issues to you since I know you'll be doing some testing to find out where we currently sit in the hopes of closing a few out. I'd be happy to go through things with you to help make sense of the expected processing paths and outcomes. Sarah identified some refactoring that could help and I still remember a little bit of that conversation.


Create ModNeg and CModNeg

PS: ModSub and CModSub are ready but they depend on https://github.com/quantumlib/Qualtran/pull/1295

@mpharrigan I added the comments ... please take a look


Publish to mavenCentral

stop using jCenter as it's going away

follow the guide, https://getstream.io/blog/publishing-libraries-to-mavencentral-2021/

Addressed in #25 and #26


Update index.md

Add markup-inline-loader

Done.
Sorry for my poor English ^_^ .

@asnowwolf, make sure to submit a PR for https://github.com/webpack-contrib/awesome-webpack#loaders as well.

@simon04 Done, Thank you!


Fix FAQ Broken Links

Resolve Issue #69

You shouldn't need to hardcode the full links in the markdown. I believe we just need to remove the ? and ' marks. All spaces in the headers should become - in the links.


ANSI escape codes in output using git for windows

NOTE: I've seen some reports which suggest that this would be fixed by later Windows versions, so I'm on the Windows Insider preview... I've seen this with another application (https://github.com/go-task/task); I've also used ansicon to get around it but that cuts out some of the scrollback
Windows Terminal version
1.12.10983.0
Windows build number
10.0.22621.0
Other Software
No response
Steps to reproduce
Download https://search.maven.org/search?q=a:junit-platform-console-standalone by clicking the Download link

Install java: winget install Microsoft.OpenJDK.11
Install Git for Windows interactively: winget install Git.Git -i
When installing Git for Windows, enable the option to add it to the Microsoft Terminal
Open a Git Bash tab:
Execute the following:
`cd ~/Downloads; 'C:\Program Files\Microsoft\jdk-<IP_ADDRESS>-hotspot\bin\java.exe' -jar ./junit-platform-console-standalone-1.8.2.jar;
The output contains ANSI escape codes:

Expected Behavior
Colored output (or bolded, underlined - not sure what the codes map over to)
Actual Behavior
ANSI escape codes

I believe this is the same issue as #6634 - see over there for more information.

This does look like the same thing as /dup #6634 to me. See https://github.com/microsoft/terminal/issues/6634#issuecomment-647726408 specifically.

That closed issue doesn't really explain things very well for the average user who isn't intimately familiar with the architecture. Is there a TL;DR as to why you can't just fix this by tracking and making PRs against these upstream clients? Why not keep things like this open and track these legacy applications, especially when it's something as huge as java? This team is going to be the most motivated to add flags which specifically target your Windows architecture.
Note that just using the terminal which ships with Git for Windows, ANSI escape codes are displayed properly.
I'm willing to make a PR against the jdk I suppose but it's going to take me far longer and I'd be flying pretty blind in doing so.


[BUG] Cannot able to update a value in a custom field for an existing module Customer

Hi All,
I am using medusa-extender, adding a new column rest_id in customer entity.
Customer.entity.ts
import { Entity as MedusaEntity } from "medusa-extender";
import { Customer as MedusaCustomer } from "@medusajs/medusa";
import { Column, Entity, Index } from "typeorm";

@MedusaEntity({ override: MedusaCustomer })
@Entity()
export class Customer extends MedusaCustomer {
  @Index()
  @Column({ nullable: false })
  rest_id: string;
}

Trying to add rest_id before, whenever the new customer is created. so in the customer.service.ts
@Service({override: MedusaCustomerService})
export default class CustomerService extends MedusaCustomerService {

    private readonly manager: EntityManager;
    private readonly customerRepository: typeof CustomerRepository;
    private readonly addressRepository: typeof AddressRepository;

    constructor(private readonly container: ConstructorParams) {
        super(container);
        this.manager = container.manager;
        this.customerRepository = container.customerRepository;
        this.addressRepository = container.addressRepository;

        CustomerSubscriber.attachTo(container.manager.connection)
    }

    @OnMedusaEntityEvent.Before.Insert(Customer, { async: true })
    public async attachRestaurantToCustomer(
        params: MedusaEventHandlerParams<Customer, 'Insert'>
    ): Promise<EntityEventType<Customer, 'Insert'>> {
        console.log("______________________");

        console.log(params.event.entity.rest_id);
        params.event.entity.rest_id = params.event.entity.rest_id || "";
        return params.event;
    }
}

After the customer creation, when I check the database, rest_id is null. the extended field's value is not updating.
Please help me out here.. !!! :cold_sweat:

import { default as ExtendedCustomerRepository } from './customer.repository';

declare module '@medusajs/medusa/dist/models/customer' {
	declare interface Customer {
		rest_id: string;
	}
}

declare module '@medusajs/medusa/dist/types/customer' {
	declare interface CreateCustomerInput {
		rest_id: string;
	}

	declare interface UpdateCustomerInput {
		rest_id: string;
	}
}

declare module '@medusajs/medusa/dist/repositories/customer' {
	declare class CustomerRepository extends ExtendedCustomerRepository {}
}

My index.d.ts file, will look like this.

I mark it as resolve as you get it to work. Can i get you to share with the other the solution by yourself 😀


test: relax bad_crate_type to only match error message prefix

What does this PR try to resolve?
This PR relaxes the bad_crate_type test to have it only match the prefix of the unknown crate type error message emitted by rustc.
This is so that the cargo test isn't sensitive to (future) suggestions for known crate types that rustc may emit to help the user.
How should we test and review this PR?
This test should already be run as part of cargo CI. (This is definitely run as part of rust-lang/rust CI, lol.)
Additional information
rust-lang/rust side PR that's trying to add a suffix to the bad crate type error message to list all valid --crate-type values: https://github.com/rust-lang/rust/pull/134720.
Without relaxing this test, the rust-lang/rust side PR fails with:

rust-lang/rust CI fail message
(Ignore the missing colon after unknown crate type)
---- bad_config::bad_crate_type stdout ----
running `/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/x86_64-unknown-linux-gnu/release/cargo build -v`
thread 'bad_config::bad_crate_type' panicked at src/tools/cargo/tests/testsuite/bad_config.rs:434:10:

---- expected: tests/testsuite/bad_config.rs:424:27
++++ actual:   stderr
   1    1 | [ERROR] failed to run `rustc` to learn about crate-type bad_type information
   2    2 |
   3    3 | Caused by:
   4    4 |   process didn't exit successfully: `rustc - --crate-name ___ --print=file-names --crate-type bad_type` ([EXIT_STATUS]: 1)
   5    5 |   --- stderr
   6      -   [ERROR] unknown crate type: `bad_type`
Error:      6 +   [ERROR] unknown crate type `bad_type`, expected one of: `bin`, `cdylib`, `dylib`, `lib`, `proc-macro`, `rlib`
   7    7 |

Discussed at https://rust-lang.zulipchat.com/#narrow/channel/246057-t-cargo/topic/Reblessing.20a.20cargo.20test.

r? @weihanglo (sorry forgot to r/?)