SCP-1973: use machine integers for costing

Using machine integers rather than arbitrary-sized Integers gives us a
decent speedup.
However, we do need to worry about overflow. It's hard to find an
existing type that has the semantics that we want. The closest is
Data.SafeInt, but this throws on overflow. We could do with this,
but it's simpler for us to deal with saturating arithmetic, since our
operations are always monotonic. Then we don't have to worry about
exceptions.
Consequently, this PR includes a copy of Data.SafeInt adapted to do
saturated arithmetic instead.
Overall, this is slower than just using Int64, but we need the
safety. I don't know why it's slower than Int64, though, apart from
the overflow checks.

Oh, one other thing I should add: it's backed by Int, not Int64, but I think this is fine because if we're in the situation where we'd overflow an Int32 but not an Int64... we're still going to exceed the budget!
Or maybe this isn't true? Thoughts?

(The reason we need to use Int is that the primops we use are only defined for Int. In GHC 9.something we'll get primops for other sizes, but that's a way off.)

I think the only 32-bit platform we might have to deal with is GHCJS.
 If you set that, we replace SatInt with Integer. That would be slower, but 32bit platforms are going to be slower anyway, so :shrug: And when we get the primops for all sizes we can go back to Int64 in all cases.

I also wonder if there's a potentially simpler option. I think the only operations we really want are + and * (and multiplication by actual integers?), and we could probably safely implement those ourselves using WordLog2# from GHC.Integer.Logarithms. That will tell you the number of bits used in a number (maybe +/-1), and from that you can work out the maximum number of bits that will be required by the sum and product, and hence whether there's a danger of overflow.

We could probably do that... I just suspect that it'll be quite a bit slower than the primops :shrug:

I added a change which picks the type backing costing based on the bit-size of Int on the target platform. If it's less than 64, it uses Integer instead. This should be pretty safe.

I think this is safe enough for now, so let's take it.


Question: does it encode unicode characters?

Does it encode unicode characters or escape those?

Yes, of course. Did you encounter any problems?

Yes
That did not worked, in this snippet.
use scraper::node::Node;
use scraper::Html;

fn main() {
    let input_text: &str = "
Hello
 World 😀 U+1F600";

    println!("{input_text}");

    let frag: Html = Html::parse_fragment(input_text);

    let mut parsed_text: String = String::new();

    for node in frag.tree {
        if let Node::Text(text) = node {
            parsed_text.push_str(&text.text);
        }
    }

    println!("{parsed_text}");
}

The scraper crate does not depend on my html-escape crate. Sorry, I cannot catch it. Could you make it clear?

@magiclen Yes
That did not worked, in this snippet.
use html_escape::encode_safe_to_string;

fn main() {
    let input_text: &str = "
Hello
 World 😀 U+1F600";

    let mut parsed_text: String = String::new();

    encode_safe_to_string(input_text, &mut parsed_text);

    println!("{parsed_text}");
}

You should use the encode_unquoted_attribute* functions if you want to encode emojis. In your example, the emoji character does not need to be encoded.

@magiclen I tried
Its still the same
encode_unquoted_attribute_to_string(input_text, &mut parsed_text);

I have reviewed my code. It turns out only characters which are less than 128 as well as not alphanumeric should be encoded.
All emojis are greater than 127, so none of them needs to be encoded.
Does this rule cause problems?

Causing problem depends on the application.
E.g. if anyone dont want any  of those emoji in their few part of application.
For me I was just testing.

OK, I see. Maybe we could add extra functions like encode_*_emoji* to translate emojis to their shortcode and decode_*_emoji* functions to translate them back.

Yes I think thats a good idea


Failing to build

Hi, I have python2.7 installed via windows-build-tools and I get this error:
npm ERR! node-pre-gyp http 404 status code downloading tarball https://github.com/libxmljs/libxmljs/releases/download/v0.19.7/node-v88-win32-x64.ta
r.gz
It can't be downloaded? Very odd

i can confirm the error on  Ubuntu 20.04.2 LTS
node-pre-gyp http 404 https://github.com/libxmljs/libxmljs/releases/download/v0.19.7/node-v83-linux-x64.tar.gz

I noticed the error because after the 404 the package will try to build from source which was failing as well in my case because my python command was missing.
I managed to get my yarn install working by installing python2 via apt install python2

Same issue!.
error node-pre-gyp http 404 https://github.com/libxmljs/libxmljs/releases/download/v0.19.7/node-v93-win32-x64.tar.gz
error node-pre-gyp WARN Tried to download(404): https://github.com/libxmljs/libxmljs/releases/download/v0.19.7/node-v93-win32-x64.tar.gz
error node-pre-gyp WARN Pre-built binaries not found for<EMAIL_ADDRESS>and<EMAIL_ADDRESS>(node-v93 ABI, unknown) (falling back to source compile with node-gyp)
error node-pre-gyp http 404 status code downloading tarball https://github.com/libxmljs/libxmljs/releases/download/v0.19.7/node-v93-win32-x64.tar.gz
error gyp ERR! build error

I am also getting same issue. Any fix or solution for this?

Any fixes?


Ken Fry Calculator-rspec

Ken Fry

Just 1 thing to change. Your test for subtracting things in a different order only has 1 result. 3 - 5 = -2, but What does 5 - 3 = ?
Everything else is OK. Please make that change and I will regrade.

OK, changes look good.


Make the replica of production the permanent staging database

Working through #1084, we set up a replica of the production database with sanitized email addresses. Folks at OAR were happy to have fresher data in staging and already went through the process of recreating the accounts they use there.
Making this new database the permanent staging database makes sense. The new database is a replica of production, so it's db.t3.small and multi-AZ vs. the smaller db.t3.micro and single-AZ. It also was upgraded to PostgreSQL 12.
The following questions are left unanswered:

Do we want to leave it as-is, or scale it back?
The upgrade process was fairly straight forward, but I didn't document anything as I went through. Do we want to keep the old database around so that we can walk through a PostgreSQL 12 upgrade with more-accurate info on the length of downtime?

The following things need to be done:

Manipulate the Terraform state to remove the old database / parameter group and slot in the new set of resources.

I removed the old RDS instance from the Terraform state and then renamed it in the AWS console with the suffix -old. I renamed the new RDS instance to the old RDS instance's original name and imported it back into the Terraform state. Then, I cycled Terraform using the changes in #1125 to create and apply a new parameter group that is codified in Terraform.
These AWS docs served as a useful sanity check: https://docs.aws.amazon.com/AmazonRDS/latest/UserGuide/USER_RenameInstance.html#USER_RenameInstance.RR
Everything looks clean now. I left the old database instance in a stopped state just in case and set up a 2 week Slack reminder to delete it in its entirety.

I've moved this to in review. @hectcastro If you could take a look at #1125, the description of events in this issue, and the state of things in the AWS console, I think we could then close this out.

Because https://github.com/open-apparel-registry/open-apparel-registry/pull/1125 makes the current staging database default to PostgreSQL 12, I think that now we need to accelerate the effort to get development and production on PostgreSQL 12 as well. There is a draft issue https://github.com/open-apparel-registry/open-apparel-registry/issues/948 to upgrade to PostgreSQL 12, but I think we may need to split that into at least two separate issues (one for upgrading to PostgreSQL 12 in development, and another for production). After they exist, we should aim to slot them into next sprint.

These are up and slotted in.

Can the openapparelregistry-enc-stg-old RDS instance be taken offline now?

I had a Slackbot reminder to do this tomorrow.

It looks like the openapparelregistry-enc-stg-old RDS instance is still online.


Re-edit existing label.....

As per our discussion on discord @gregdavill, I'm just putting this in here as a "possibly one day, maybe in 2027 or something" to re-visit the ability to either be able to edit an existing label, or at least have some viewable meta-data attached to a label footprint to be able to remember what settings were used when generating that specific label.
Cheers!

It's not worth trying to use this branch directly since it's so old. But you can see I did investigate an "edit" feature.
https://github.com/gregdavill/KiBuzzard/tree/feature-edit
The main issue with fully editing footprints was this: https://gitlab.com/kicad/code/kicad/-/issues/7065
But prefilling the UI with the same parameters used to generate a selected footprint should be possible.

apparently fix committed 3 weeks ago.

I've updated that branch to match recent changes. Looks like it is all fixed upstream in KiCad!
Here is how it works so far.

Ensure only 1 KiBuzzard footprint is selected. Open plugin
Edit, and close. Footprint is updated

Note: This will only work on footprint generated on this branch, so you can't open up old design and edit KiBuzzard labels.
Still a few more bugs,issues,testing before it's ready to merge into main.

I've updated that branch to match recent changes. Looks like it is all fixed upstream in KiCad!
Here is how it works so far.

Ensure only 1 KiBuzzard footprint is selected. Open plugin
Edit, and close. Footprint is updated

Note: This will only work on footprint generated on this branch, so you can't open up old design and edit KiBuzzard labels.
Still a few more bugs,issues,testing before it's ready to merge into main.


Host certificate lambda

LGTM. Want to open a PR upstream?

ok, closing this one and opening one upstream.


added http-x-forwarded-for field to nginx parser

Closing #1907, an update to the docs has been proposed in https://github.com/fluent/fluentd-docs/issues/471.

[^ ] and \S are different and \S is bit slower. Please back changes to previous implementation.
In addition, we enabled DCO for our repository. Please add your sign to the commit. See https://github.com/apps/dco

OK, seems I'm gonna have to open a new PR since DCO rejects commits without a sign off, I'm gonna close this one and open a new one with the changes requested + a sign off.


Core || Hybrid search || Fuse the results using configurable weights

Description
The system shall allow the user to assign weights to the results from the sparse vector search and dense vector search, fuse them based on the weighted score of the two search methods and present the results in descending order of the weighted score.
Acceptance criteria

The system shall allow the user to assign a weight for the sparse vector search (Ws).
The system shall allow the user to assign a weight for the dense vector search (Wd).
The system shall computed the weighted score using the formula - (Ws * Sparse search score) + (Wd * Dense vector search score).
The system shall re-order the results based on the descending weighted score.
The system shall present the results to the user query.

Context
Sparse vectors are mathematical representations of data in which most of the elements are zero or empty. They contrast with dense vectors, in which most elements have non-zero values.
Sparse vectors help target search results by honing in on the most relevant features or terms. This helps in prioritizing important words in a document, filtering out noise and improving the relevance of search results.

Checkpoint on 28-Aug-2024
This has not yet been picked up. This will be taken up only when the sparse vector search is complete.


CPC and Communication panel reacts on page refresh even if parent window asks user for confirmation.

Trying to integrate Sinch communication panel with our CRM using CPC.js we faced following issue:
Communication panel is loaded in iframe and main parent window (our CRM's user interface) communicates with that already with help of CPC.js
Then at some moment when end user is in call with customer, he tries to refresh the page (for whatever reason). It of cause causes the call being interrupted and to block that our CRM's UI asks for a confirmation to reload the whole page. We do it by adding window.onbeforeunload event handler.
But communication panel, running in iframe starts the reloading without waiting for a confirmation from end user.
Because of cross origin policy restrictions we cannot add the same event handler to iframe. But CPC also does not provide any option to manage the behaviour of communication panel in this case.
Here you may see the screenshot of a sandbox page I created to reproduce the issue. Main window asks for confirmation to refresh the page, but the communication panel already started to unload (black dots in the middle) and the call is already interrupted!

This is quite annoying issue for our end users and we are expecting CPC to provide an option to define how Communication panel should behave in case of page refresh.

Thank you @semirenko, this a very much valid point and we are aware of this. We have an internal development ticket CC365V1-6611 which (among other things) has this topic listed as an issue. A proper implementation will require work on both the CPC library and also the actual Communication Panel - It seems this unfortunately cannot be properly solved on CPC side alone.
Let's keep this issue open here and we'll follow up when there's news.


[CWS] increase CWS activation test timeout

What does this PR do?

increase the TestFeatureCWSEnabled test timeout to reduce its flakiness.
switch the order the tests are performed to achieve the same goal.

Motivation

Additional Notes

Possible Drawbacks / Trade-offs

Describe how to test/QA your changes

Reviewer's Checklist

[ ] If known, an appropriate milestone has been selected; otherwise the Triage milestone is set.
[ ] Use the major_change label if your change either has a major impact on the code base, is impacting multiple teams or is changing important well-established internals of the Agent. This label will be use during QA to make sure each team pay extra attention to the changed behavior. For any customer facing change use a releasenote.
[ ] A release note has been added or the changelog/no-changelog label has been applied.
[ ] Changed code has automated tests for its functionality.
[ ] Adequate QA/testing plan information is provided. Except if the qa/skip-qa label, with required either qa/done or qa/no-code-change labels, are applied.
[ ] At least one team/.. label has been applied, indicating the team(s) that should QA this change.
[ ] If applicable, docs team has been notified or an issue has been opened on the documentation repo.
[ ] If applicable, the need-change/operator and need-change/helm labels have been applied.
[ ] If applicable, the k8s/<min-version> label, indicating the lowest Kubernetes version compatible with this feature.
[ ] If applicable, the config template has been updated.

/merge


Hangs on right click

DJV 2.0.5 for Windows.
Consistently hangs every time I right click on the image. The program has to be killed and relaunched to keep working.

Hi, thanks for the bug report; it looks like this only happens for single images, with sequences/movies the right mouse button scrubs the current frame without hanging. I'll get this fixed for the next release.

OK, I just checked in a fix for this, it will be included in the next release.


Add option to let Bottle listen on all interfaces

Added option to allow bottle server to listen on all interfaces.  Bottle allows listening on all interfaces when the host is set to '<IP_ADDRESS>' as per documentation
Without this change, setting the host to '<IP_ADDRESS>' via eel options fails because this is not a valid address for the web browser to navigate to in order to access the server.  The added option still allows a single IP address to be specified so that the browser that eel launches can access it, but passes '<IP_ADDRESS>' to the bottle server so that the GUI can be accessed on all IP addresses via browsers on the LAN.  The default value is set so that behavior does not change unless this new options is specifically added and set to True.

@aaknitt Hey mate sorry for very slow response. I have made some breaking changes to the API for start() and got rid of the options dict - everything is now a keyword arg.
Could you possibly update this so it fits with the new code? Then I pull accept.
Thanks for your help with the project, sorry again for ignoring for a while!

Replaced with #155


ZYNQ ZC702 board hangs sometimes at boot

From @agherzan on July 4, 2016 11:47
Copied from original issue: resin-os/resin-zc702#18

No further development is planned for this board.


Handle new caller_location intrinsic the right way

Rebase from #346 found a new caller_location intrinsic in the process. In order to unblock, we codegen this intrinsic as:
            "caller_location" => {
                codegen_unimplemented_intrinsic!("https://github.com/model-checking/rmc/issues/374")
            }

But we can probably codegen it the same way Rust does.

This is a nice explanation on what this does: https://hegdenu.net/posts/track-caller/

Thanks for the update, @celinval !
If adding support for caller_location would allow us to avoid panic messages such as thread 'main' panicked at 'called `Option::unwrap()` on a `None` value', that'd be a major improvement in how we report such failures.
One thing that I don't see mentioned there is the relation to panic strategies. This isn't mentioned in the RFC neither, so I guess it's independent.

I was wondering if it would help with: https://github.com/model-checking/kani/issues/1740

For the current Rust implementation, the compiler will add an extra argument to functions that contain #[track_caller]. Unfortunately, this operation is done in the codegen stage, instead of a MIR pass. :(
My guess is that MIR passes can't really change the function signature, so they push it down to the codegen stage. I'm tempted to just encode this as a global variable for now.
@adpaco-aws I don't think CBMC really supports formatting error messages, so I'm not sure implementing this intrinsic will make much of a difference on how we report failures.
In order to fix that, we would have to either inline these functions or generate a different copy per location they are invoked from.

Implementation notes for myself:

To build a constant that represents a location, use query const_caller_location [1].
To get the type of the caller location, use function: pub fn caller_location_ty(self) -> Ty<'tcx> [2]
We can check if a function requires caller location using requires_caller_location [3]
If we are passing the caller location as an argument, we will need to create a ReifyShim for cases that require dynamic dispatch.


Issue/6182 dont log everytime db pool exhaustion is checked

Description
Adds a mechanism to silence logging "Calling ..." for very frequently called actions
closes #6182
Self Check:
Strike through any lines that are not applicable (~~line~~) then check the box

[x] Attached issue to pull request
[x] Changelog entry
[x] Type annotations are present
[x] Code is clear and sufficiently documented
[x] No (preventable) type errors (check using make mypy or make mypy-diff)
[ ] Sufficient test cases (reproduces the bug/tests the requested feature)
[ ] Correct, in line with design
[ ] End user documentation is included or an issue is created for end-user documentation (add ref to issue here: )
[ ] If this PR fixes a race condition in the test suite, also push the fix to the relevant stable branche(s) (see test-fixes for more info)

Processing this pull request

Merged into branches master in 095734a37f1bf7fad546d2165d43c00ecdb5015f

This branch was not deleted as it seems to still be in use.

Processing #6190.


Support for running attribute and entity bootstrap together

Instead of running two separate jobs for entity & attribute bootstrapping (proposed here https://github.com/hypertrace/config-bootstrapper/pull/33)
This pr adds a new job prefix called attribute-entity, for this job the program argument will be
args: [ "-c", "/etc/config-bootstrapper/application.conf", "-C", "/app/resources/configs/config-bootstrapper", "--upgrade" ]

which allows it to read both entity & attribute configs passed
├── application.conf
├── attribute-service
│   ├── hypertrace
│   │   ├── hypertrace_api_attributes.conf
│   │   ├── hypertrace_api_trace_attributes.conf
│   │   ├── hypertrace_backend_attributes.conf
│   │   ├── hypertrace_backend_trace_attributes.conf
│   │   ├── hypertrace_interaction_attributes.conf
│   │   ├── hypertrace_service_attributes.conf
│   │   └── hypertrace_span_attributes.conf
│   └── hypertrace-core
│       ├── 1_event_attributes.conf
│       └── 1_trace_attributes.conf
└── entity-service
    └── hypertrace
        ├── 1_entityrelationshiptypes.conf
        └── 1_entitytypes.conf

Have verified this change, locally by locally building the chart and testing with https://github.com/hypertrace/hypertrace-service/pull/66/files#diff-34e6fca01efdbade1fa38024afd3860d5fc9b50a177cd884324700c624c8cfdfR128

can we close - https://github.com/hypertrace/config-bootstrapper/pull/33 - as we don't need that, right?

Isse: https://github.com/hypertrace/hypertrace/issues/166


feat: ✨ add insertPort api

Description
add insertPort api
Motivation and Context

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] Enhancement (changes that improvement of current feature or performance)
[ ] Refactoring (changes that neither fixes a bug nor adds a feature)
[ ] Test Case (changes that add missing tests or correct existing tests)
[ ] Code style optimization (changes that do not affect the meaning of the code)
[ ] Docs (changes that only update documentation)
[ ] Chore (changes that don't modify src or test files)

Self Check before Merge

[ ] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[ ] I have read the CONTRIBUTING document.
[ ] I have added tests to cover my changes.
[ ] All new and existing tests passed.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 0.0%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
0

Relevant Lines:
0

💛  - Coveralls

我insertPort的index参数是已经存在的，但是得到上面的报错。如果我自定义了PortMetadata.id就能正常创建


(#235) Implement flyable properly

Fixes #235
To test:

Confirm new unit test fails on main but passes on this branch

This test passes in main for me

Hmm.. Which version of bluesky have you got running?

1.8.3, as specified in pipfile.lock in main

Apologies, try testing against the latest bluesky version (which we're now using after we removed the lock file)


upgrade ocaml lsp to version 1.2.9

Another update to the ocaml lsp (tested locally) - this version included some changes to diagnostic rendering (..for those interested 😆 )

Excellent - thanks @Akin909 👍

Hmm, looks like this change somehow breaks the CSS completion tests:
[00:13:35]    [FAILED]:  AutoCompletionTest-CSS
[00:13:35]       Expected:  undefined
[00:13:35]       Actual:  undefined
[00:13:35]       Path: C:/projects/oni/lib_test/test/ci/AutoCompletionTest-CSS.js

Looks like a bunch of dependencies are updated, in addition to the ocaml-language-server - potentially one of these is breaking our CSS language server.


PR list is not complete

I have Total Pull Requests Created: 125, it's right.
But only 50 of them are listed in the report, is it by design or a bug?

@resouer Thanks for the feedback! I had set the number of PRs to be displayed as 50 so that it did not make everything cluttered. But I guess it makes sense to remove that restriction. Will update it! :+1:

Or configurable, it's depends on you anyway, thank you! Will close this.


Fix NuGet.config

/azp run

/azp where

@alexperovich Awesome!  Seems to be working now!
(I still need to fix this PR, but at least it's working!)


Instead of Vec as return value, use Box<[T]>

Box<[T]> simply consists of a heap pointer, and a length as part of the slice type. I believe this allows better optimizations than if you were to use Vec<T>, which has two fields for keeping track of size.
There's an unstable function to create a boxed slice with uninitialized contents, called Box::new_uninit_slice, which can be used instead of Vec::with_capacity.
For example, the following code:
let mut v = Vec::with_capacity(count as usize);
let err_code = self.swapchain_fn.get_swapchain_images_khr(
    self.handle,
    swapchain,
    &mut count,
    v.as_mut_ptr(),
);
v.set_len(count as usize);
match err_code {
    vk::Result::SUCCESS => Ok(v),
    _ => Err(err_code),
}

can be turned into:
let mut b = Box::new_uninit_slice(count as usize);
let err_code = self.swapchain_fn.get_swapchain_images_khr(
    self.handle,
    swapchain,
    &mut count,
    b.as_mut_ptr(),
);
match err_code {
    vk::Result::SUCCESS => Ok(b.assume_init()), // NOTE: assume_init on Box is also not yet stable!
    _ => Err(err_code),
}

In #358, it was suggested to use a value with the Extend trait as an input parameter instead. That's also a possibility. Returning the value is more idiomatic for Rust, but using Extend is more flexible and allows avoiding a heap allocation.

I'm not sure how Extend could be used without a heap allocation. Vulkan writes results to contiguous memory of dynamic length, and Extend doesn't give you that.

You could combine Extend with AsMut (e.g. AsMut<[DescriptorSet]> + Extend<DescriptorSet>). This would allow you to pass in a &mut Vec<T> for the output and this Vec could be reused. This gives the caller control over the allocation.
pub unsafe fn allocate_descriptor_sets<R>(&self, create_info: &DescriptorSetAllocateInfo, result: &mut R) -> VkResult<()>
    where R: AsMut<[DescriptorSet]> + Extend<DescriptorSet>
{
    // ..
    Ok(())
}

Here's an example: https://play.rust-lang.org/?version=stable&mode=debug&edition=2018&gist=e29d14b5cc71ae4eeb150dd68941abdb

That could work, though it's a noticable reduction in ergonomics for the overwhelmingly common case.

I don't think any of the allocation functions are in the hot path, so we don't really need to optimize for this. AsMut + Extend would work but I am not sure about the additional complexity. I'd rather keep ash as simple as possible.
I'd be open to adding support for allocators once we have them in the std.

This example with Extend seems rather suboptimal. There is no way to use set_len in case the caller has overallocated and initialized a vector with more space than descriptor_set_count, they'd have to sub-slice it themselves after the call. It should also be fine to use uninitialized memory here, like Ash currently does.
Furthermore this example doesn't work for statically allocated arrays either, when knowing at compile-time how many descriptor sets there are going to be. It seems Extend is only used here to increase the size of a collection IF it wasn't large enough in the first place. The caller already knows in advance how many descriptors they are allocating and should just pass in a properly sized (if possible uninitialized) mutable slice.
This is IMO one of the niche cases where ash provides direct access to the function pointers for. There is hardly any wrapping and raw-pointer mangling going on in allocate_descriptor_sets, something like this should shouldn't be too bad to have in ones application:
assert!(preallocated_slice_that_is_large_enough.len() >= create_info.descriptor_set_count);
unsafe {
    device.fp_v1_0().allocate_descriptor_sets(
        device.handle(),
        &create_info,
        preallocated_slice_that_is_large_enough.as_mut_ptr(),
    )
}
.result()?;

It makes more sense to have Extend in functions where Ash is first querying the size of something through the Vulkan API, then calling it again with enough allocated memory (iow: cases where the caller does NOT know in advance what the output size is going to be).
Anyway, this is all better discussed in #358. @MaikKlein is it possible as repository owner to move/migrate the last few comments to that issue?
Back to the OP: I do think that Box<[T]> makes more sense here; get rid of the capacity and dynamic resizing which don't make too much sense for a return value. OTOH the overhead of an extra integer probably isn't worth the added complexity of the lesser-known Box<[T]> API, and might break existing applications that expect to get a vector directly.


Overhaul GitHub Repository Structure

Idea
I think we should merge ipfs/ipfs, ipfs/community, and ipfs/pm into one repository.
Why
There is a lot of feedback going around, here and on IRC, that the GitHub organization is hard to navigate, and it is unclear where to ask questions, where to look for up-to-date information on the community, and where to find information about an implementation and to get a support. We are thinking through several solutions to this: overhauling our examples, or making better mans, or more realistically switching to Discourse or some other platform for having our discussions.
I think that this confusion comes from a different place: people aren't landing where we think they are landing.
Right now, we are supposed to have the following repo structure:

ipfs/ipfs - Landing page

ipfs/go-ipfs
ipfs/js-ipfs
ipfs/community
ipfs/support
ipfs/pm
ipfs/faq
ipfs/reading-list
ipfs/specs
ipfs/website
ipfs/examples
ipfs/blog
And so on...

ipfs/ipfs links to everything. Unfortunately, very few people land there when looking to get involved more fully, and we have only very rarely utilized the issues on it. The content itself grows stale regularly. While it is useful as a document, it could be more useful as a landing pad if it was a living repository, with our community and project management happening there.
Realistically, what we have right now is a flat structure, and people don't necessarily see the useful guides to our repositories in ipfs/ipfs. Further, they may come to ipfs/community looking for that information; or they may be looking for ipfs/pm. Or they may be looking for ipfs/pm information in ipfs/go-ipfs or ipfs/js-ipfs.
I wonder if it might be better if we collapsed ipfs/ipfs, ipfs/community and ipfs/pm into one repository. This way, the project directory would be in the same place as the community and the project management. People would not need to go to multiple repositories to figure out the current state of IPFS or the IPFS community. If they wanted to look at a particular implementation, they can still go to go-ipfs or js-ipfs. But it would be very easy to see that the useful information is in ipfs/ipfs. If you wanted to propose a meetup, you'd go there. Or a new implementation. Or if you wanted to join our community calls.
I think that keeping ipfs/ipfs as a repo that didn't have community and pm resources on it made sense when people were able to easily see it and go to it, and when we were smaller. To date, it still has the most stars and watchers, so this may still be true. However, I think that these people have starred and watched it to keep updated on the state of IPFS - which is something we're not doing for them, right now.
Other possible collapses
I also think that ipfs/website, ipfs/examples, and ipfs/blog should be collapsed. They are all functionally the same to a naïve user. I think separating them out isn't helping us sandbox their usage.

This idea has grown on me. Consolidating those 3 repos into one ipfs/ipfs sounds like a good idea.
Some things that reinforce the idea:

I don't see any content or issues in any of those repos that needs to be kept separate.
This will route visitors to one landing page with lots of supporting reference pages
Maintenance of the Roadmaps will become clearer (ie. I didn't realize there is an old Roadmap.md in ipfs/ipfs!)

Also, looking at the list of repos, if we start using discourse we won't need to maintain ipfs/support or ipfs/faq.  So after all the shuffling it might look like:
ipfs/ipfs absorbs:

ipfs/ipfs
ipfs/community
ipfs/pm

ipfs/websites absorbs:

ipfs/website
ipfs/examples
ipfs/blog

discourse replaces:

ipfs/support
ipfs/faq (maybe we will keep this)

code repositories:

ipfs/go-ipfs
ipfs/js-ipfs
etc...

other:

ipfs/reading-list
ipfs/papers
ipfs/awesome-ipfs
ipfs/specs

I agree very much, and I think we can also collapse repos like libp2p/community

I still like this idea.

People are leaning towards this, what are the next steps?

Feedback from the rest of the team.


Temporary fix multihop

By investigating the logs it looks for me like the Carol node don't have enough time to include the HTLC in commitment transaction and update channel state in channeldb, so the temporary solution proposes to do channel info requests during some time and only after it throw the error.

Hmmm, looks like it not working in Travis


GAIL with CnnPolicy

I tried to use GAIL, but for some reason it don't work with CnnPolicy and an image based env. Probably I made a user error, but I can't find it. So it would be nice if someone could tell me what I did wrong.
EDIT:
according to the documentation GAIL should support all observant types.
code:
from stable_baselines import GAIL, DQN
from stable_baselines.gail import ExpertDataset, generate_expert_traj

record_model = DQN('CnnPolicy', 'BreakoutNoFrameskip-v4')
generate_expert_traj(model=record_model, n_episodes=32,
                     save_path='dataset/dummy_BreakoutNoFrameskip-v4',
                     image_folder='record_image_BreakoutNoFrameskip-v4')
del record_model

dataset = ExpertDataset(expert_path='dataset/dummy_BreakoutNoFrameskip-v4.npz', traj_limitation=10, verbose=1)
model = GAIL('CnnPolicy', 'BreakoutNoFrameskip-v4', dataset, verbose=1)
model.learn(total_timesteps=100000)

error:
Traceback (most recent call last):
  File "/usr/local/lib/python3.5/dist-packages/tensorflow/python/framework/op_def_library.py", line 510, in _apply_op_helper
    preferred_dtype=default_dtype)
  File "/usr/local/lib/python3.5/dist-packages/tensorflow/python/framework/ops.py", line 1146, in internal_convert_to_tensor
    ret = conversion_func(value, dtype=dtype, name=name, as_ref=as_ref)
  File "/usr/local/lib/python3.5/dist-packages/tensorflow/python/framework/ops.py", line 983, in _TensorTensorConversionFunction
    (dtype.name, t.dtype.name, str(t)))
ValueError: Tensor conversion requested dtype uint8 for Tensor with dtype float32: 'Tensor("adversary/obfilter/Cast:0", shape=(210, 160, 3), dtype=float32)'

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/opt/project/GAIL_test.py", line 11, in <module>
    model = GAIL('CnnPolicy', 'BreakoutNoFrameskip-v4', dataset, verbose=1)
  File "/usr/local/lib/python3.5/dist-packages/stable_baselines/gail/model.py", line 55, in __init__
    self.setup_model()
  File "/usr/local/lib/python3.5/dist-packages/stable_baselines/gail/model.py", line 73, in setup_model
    self.trpo.setup_model()
  File "/usr/local/lib/python3.5/dist-packages/stable_baselines/trpo_mpi/trpo_mpi.py", line 126, in setup_model
    entcoeff=self.adversary_entcoeff)
  File "/usr/local/lib/python3.5/dist-packages/stable_baselines/gail/adversary.py", line 77, in __init__
    generator_logits = self.build_graph(self.generator_obs_ph, self.generator_acs_ph, reuse=False)
  File "/usr/local/lib/python3.5/dist-packages/stable_baselines/gail/adversary.py", line 121, in build_graph
    obs = (obs_ph - self.obs_rms.mean) / self.obs_rms.std
  File "/usr/local/lib/python3.5/dist-packages/tensorflow/python/ops/math_ops.py", line 866, in binary_op_wrapper
    return func(x, y, name=name)
  File "/usr/local/lib/python3.5/dist-packages/tensorflow/python/ops/gen_math_ops.py", line 8318, in sub
    "Sub", x=x, y=y, name=name)
  File "/usr/local/lib/python3.5/dist-packages/tensorflow/python/framework/op_def_library.py", line 546, in _apply_op_helper
    inferred_from[input_arg.type_attr]))
TypeError: Input 'y' of 'Sub' Op has type float32 that does not match type uint8 of argument 'x'.

Hello,
As stated in the documentation (https://stable-baselines.readthedocs.io/en/master/modules/gail.html):
"Images are not yet handled properly by the current implementation"

GAIL may be supported for CNN here: https://github.com/HumanCompatibleAI/imitation (it is a repo notably maintained by @AdamGleave that relies on stable baselines)
I did not have the time to check, but we plan to drop GAIL support for V3 when we migrate to tensorflow 2.

imitation should support CNN policies and discriminators, although this feature is not well tested, so do let us know if you run into problems.


postcssPresetEnv debug being captured/surpressed?

I think that it is this plugin that's causing this, but also I might be wrong.
With the following:
async transform(source) {
          const { css } = await postcss([
            autoprefixer,
            postcssPresetEnv({ debug: true, stage: 0 })
          ]).process(source, { from: undefined });
          return css;
        },

I would expect to get the post css debug logged but I don't, I have tried changing the logLevel (currently at info) but doesn't seem to make a difference.

https://github.com/csstools/postcss-plugins/tree/main/plugin-packs/postcss-preset-env#debug
the output goes to stdout and the plugin is not messing with stdout
could this help maybe? https://github.com/evanw/esbuild/issues/1869

Thanks for pointing me at the esbuild issue.


Issues running under Windows

The esbuild executable isn't called "esbuild" but rather "esbuild.exe", which was causing exceptions when attempting to run it. I modified install/0 :
case :os.type() do
      {:win32, _} ->
        File.cp!(Path.join([tmp_dir, "package", "esbuild.exe"]), bin_path)
      _ ->
        File.cp!(Path.join([tmp_dir, "package", "bin", "esbuild"]), bin_path)
end

This way the correct binary is placed in the _build folder. It seems that modifying bin_path/0 and the mix.exs aliases isn't necessary (to add the .exe suffix) as everything seems to be running fine and changes in the stylesheets are being correctly rebuilt.

If you convert it to a PR, Ill gladly merge it!


Incorrect error messages when a function returns one value to two variables.

See the following example, we define a function f(), which returns a dic object l.  When we initialize two variables with the returned value, Codon reports an IndexError instead of the ValueError.
def f(x):
    l = []
    for i in x:
        l.append(x)
    return l

a, b = f('1')

The actual output on Codon v0.16.0
IndexError: list index out of range

Raised from: std.internal.types.ptr.List._idx_check:0
/home/xxm/Desktop/Codon/codon-linux-x86_64/codon-deploy/lib/codon/stdlib/internal/types/collections/list.codon:364:13
Aborted (core dumped)

The expected output (CPython 3.10.8, RustPython 0.2.0):
Traceback (most recent call last):
  File "/home/xxm/Desktop/test.py", line 9, in <module>
    a, b = f('1')
ValueError: not enough values to unpack (expected 2, got 1)

Reproduce step:

download the Pre-built binaries for Linux
Type " codon run --release test.py" in the console.

Environment:
Ubuntu 18.04
Codon v0.16.0
CPython 3.10.8

@xiaxinmeng I believe that happens due to the code simplification process. Maybe it's simplified like this:
t = f(1)
a = t[0]
b = t[1]  # IndexError

Correct. This behaviour will stay as-is; our goal is not to have  1-1 parity with CPython error messages (although we might change the error in this instance to something more readable).


drivers: wifi: Fix four Coverity issues in esp_at/esp.c

Fix following Coverity issues:
Coverity-CID: 219490
Coverity-CID: 219524
Coverity-CID: 219520
Coverity-CID: 219513

They deal with logical expressions always evaluated to false, and unreachable code. They all originate from a single file, drivers/wifi/esp_at/esp.c. Related header drivers/wifi/esp_at/esp.h turns out to be involved as well.
If the preprocessor constant ESP_MAX_DNS is equal to 0, Coverity reports a condition that can never be true, and some dead code as well. This also violates MISRA rules on dead code.
This is caused by this segment in drivers/wifi/esp_at/esp.h:
 #if defined(CONFIG_WIFI_ESP_AT_DNS_USE)
 #define ESP_MAX_DNS	MIN(3, CONFIG_DNS_RESOLVER_MAX_SERVERS)
 #else
 #define ESP_MAX_DNS	0
 #endif

The problematic part is the case of defining ESP_MAX_DNS as 0, and for that case all Coverity issues arise.
Fix this by never setting ESP_MAX_DNS to 0, as is the currently case. Define ESP_MAX_DNS only if it is configured through CONFIG_WIFI_ESP_AT_DNS_USE and CONFIG_DNS_RESOLVER_MAX_SERVERS:
 #if defined(CONFIG_WIFI_ESP_AT_DNS_USE)
 #define ESP_MAX_DNS	MIN(3, CONFIG_DNS_RESOLVER_MAX_SERVERS)
 #endif

Since CONFIG_DNS_RESOLVER_MAX_SERVERS is 1 or greater, ESP_MAX_DNS will always be greater than 0.
If, on the other hand, ESP_MAX_DNS is not defined, relevant functions will be reduced to empty stubs, since in that case they do not make sense.
There could be a cleaner solution to this, but this one is the least intrusive (involves less code changes).

Whole idea of defining ESP_MAX_DNS as 0 in:
 #if defined(CONFIG_WIFI_ESP_AT_DNS_USE)
 #define ESP_MAX_DNS	MIN(3, CONFIG_DNS_RESOLVER_MAX_SERVERS)
 #else
 #define ESP_MAX_DNS	0
 #endif

was to reduce use of #ifdef statements in the code and keep the driver a bit more cleaner to read. Compiler removed most of the unused code anyway.  I don't like this change TBH.


Sparse Volume Textures

Epic Games announced support for sparse volume textures in 5.3.
Could BP_VdbToVolumetricClouds benefit from it, if clouds will be using SVT instead of VT to sample the volume data?
Any benefits of using SVT for VdbMaterialActor/VdbPrincipledActor instead of current VDB assets?
Probably too early to talk about but any plans on implementing support for SVT or it will be out of scope for the project?
Epic Games announced special SVT renderer for path tracing but no such thing for real-time so supporting it might come in handy
https://portal.productboard.com/epicgames/1-unreal-engine-public-roadmap/c/1171-sparse-volume-textures-experimental

Hello,

Could BP_VdbToVolumetricClouds benefit from it, if clouds will be using SVT instead of VT to sample the volume data?

Absolutely

Any benefits of using SVT for VdbMaterialActor/VdbPrincipledActor instead of current VDB assets?

SVT should be faster to sample, so faster to render.

Probably too early to talk about but any plans on implementing support for SVT or it will be out of scope for the project?

Probably not. SVT, it wouldn't change much except maybe for a little performance gain.

Epic Games announced special SVT renderer for path tracing but no such thing for real-time so supporting it might come in handy

Yes this is very cool, Epic's path-tracer is not customizable from a plugin so it's nice that they're the integration themselves


Update architecture diagram

Codecov Report

Merging #27 (4eb8f13) into main (e75290f) will not change coverage.
The diff coverage is n/a.

:exclamation: Current head 4eb8f13 differs from pull request most recent head 6ab1aa3. Consider uploading reports for the commit 6ab1aa3 to get more accurate results

@@           Coverage Diff           @@
##             main      #27   +/-   ##
=======================================
  Coverage   18.98%   18.98%
=======================================
  Files           4        4
  Lines         316      316
=======================================
  Hits           60       60
  Misses        249      249
  Partials        7        7

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e75290f...6ab1aa3. Read the comment docs.


kvm: refactor conn, add to kvm manager

Codecov Report

Merging #154 into 1.1.0-alpha will not change coverage.
The diff coverage is n/a.

@@             Coverage Diff              @@
##           1.1.0-alpha     #154   +/-   ##
============================================
  Coverage        16.73%   16.73%
============================================
  Files               15       15
  Lines             1034     1034
============================================
  Hits               173      173
  Misses             850      850
  Partials            11       11

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 63b1562...d1d1541. Read the comment docs.


Rosdep for libgv-python

Should be available across ubuntu distros that we care about:

http://packages.ubuntu.com/search?keywords=libgv-python

missing a colon. please amend the commit to fix.

Got it, sorry Tully.


APEXCORE-577 Add visitor API to examine the DAG.

@PramodSSImmaneni can you please review this.

@PramodSSImmaneni I have done changes as you have suggested on the Jira.


Push built documentation to GH pages

Looks like I'll need someone with the right permissions to activate GH pages for this repo. And I'll probably also need to create a detached gh-pages branch. Opening anyway just to see what happens.

I'll merge this and try making a test tag. I might need to push to gh-pages manually once, before GH starts hosting its content. (That seems to be a security restriction imposed by Github I hit when I built this for matchers)


Invalid argument: unexpected AUTHZ state 3

mod_md 0.9.7 is trying to renew and was getting errors:
..
..
[md:info] [pid 7072:tid 1964] apachelounge.nl: need certificate
[md:info] [pid 7072:tid 1964] apachelounge.nl: check Terms-of-Service agreement
[md:info] [pid 7072:tid 1964] apachelounge.nl: setup new authorization
[md:info] [pid 7072:tid 1964] apachelounge.nl: setup new challenges
[md:error] [pid 7072:tid 1964] (22)Invalid argument: apachelounge.nl: unexpected AUTHZ state 3 at https://acme-v01.api.letsencrypt.org/acme/authz/iDqjBmUgvLmip0QQDvfSuvQTtZYWJnXjQ87cgURSU28
[md:error] [pid 7072:tid 1964] (22)Invalid argument: AH10056: processing apachelounge.nl
[md:info] [pid 7072:tid 1964] AH10057: apachelounge.nl: encountered error for the 11. time, next run in  1:00:00 hours
I stopped and started Apache again and same error and trying it over and over again:
see trace2:
mod_md-error.txt
I disabled mod_md.

Same error  with 0.9.6, which worked before.
Maybe some changed at letsencypt.org ?
Tried letsencrypt-win-simple other certs, no issues with that.

If you click through to the authorization object, you can see the error:
"error": {
        "type": "urn:acme:error:unauthorized",
        "detail": "Invalid response from http://apachelounge.nl/.well-known/acme-challenge/A8IkI2k9RRd_TxQcgjtvJlPoliAo_MH6aSOWGa9dl5k: \"\u003c!DOCTYPE HTML PUBLIC \"-//IETF//DTD HTML 2.0//EN\"\u003e\n\u003chtml\u003e\u003chead\u003e\n\u003ctitle\u003e404 Not Found\u003c/title\u003e\n\u003c/head\u003e\u003cbody\u003e\n\u003ch1\u003eNot Found\u003c/h1\u003e\n\u003cp\"",
        "status": 403
      },

Is it possible you've got the domain name pointed at a different server than the one you're running mod_md on?
@icing maybe you could improve the error message to print symbolic state names rather than numeric ones? And output the error from the authz directly into the logs?

It is https only server : -sni-01tls
AH10037: server seems not reachable via http: (port 80->80) and reachable via https: (port 443->443)
But s strange :  state=2, can_http=1, can_https=1, challenges='http-01 -sni-01tls'
and in httpd.json:
{
"proto": {
"http": false,
"https": true
}
}
Btw.
The exact same config  was working for more then a month and renewing every 5 days.

I'd recommend enabling port 80 just for redirects to port 443. See https://https.cio.gov/guide/#do-i-need-to-shut-off-port-80%3F for details.
That said, in your current situation, it looks like mod_md is choosing the wrong challenge. If it can figure out that HTTP is not available, it should be using the TLS-SNI challenge. Also, it may be better to just use the TLS-SNI challenge by default if it's implemented, since we know that most people trying to get certificates will have 443 open and available.

Why did you close the issue? Has the problem been solved?
@jsha agree that the log should give more from the server's answer.
@SteffenAL it looks as if the server reports that it gets a 403 response. Someone seems to be responding on port 80, it seems?

Looks like letsencrypt.org is now want to go on port 80 too. So I closed because it looks no mod_md issue, but my config (ssl in front). is not supported anymore. Using now letsencrypt-win-simple.
I did work before.
But still strange:
AH10037: server seems not reachable via http: (port 80->80) and reachable via https: (port 443->443)
....  state=2, can_http=1, can_https=1, challenges='http-01 -sni-01tls'
and in httpd.json:
{
"proto": {
"http": false,
"https": true
}
}

letsencrypt will use the method that mod_md tells it to use. There has been no change regarding that in the v0.9.6 -> 0.9.7 release. And as you said, v0.9.6 worked before.
So, something else is the problem. Can you get me a
LogLevel md:trace2

of such a case?

See second post above: 0.9.6 is also not working anymore.
See first post above : trace 2 log

Here the log and folder md after I removed the md folder
log-md-removed.txt
md-removed.zip.txt (remove.txt)

Think I found it. Could you check release v0.9.8 when you find the time? Thanks!

Still wrong.
I see now:   staging started, state=1, can_http=0, can_https=1, challenges='http-01 tls-sni-01'
And I see that he is using:  "port": "80",
error.txt

Ok, added two new test cases, fixed the issue, release v0.9.9. Sorry about that.

Fine again with 0.9.9:
AH10059: The Managed Domain apachelounge.nl has been setup and changes will be activated on next (graceful) server restart.
Have you an answer why it was suddenly not working anymore ?

As it was, it should have stopped working some releases ago. The new tests will catch it.

Am 04.10.2017 um 18:00 schrieb Steffen<EMAIL_ADDRESS>Fine again with 0.9.9:
AH10059: The Managed Domain apachelounge.nl has been setup and changes will be activated on next (graceful) server restart.
Have you an answer why it was suddenly not working anymore ?
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub, or mute the thread.


ci: only run generate typing job when originating from upstream

It seems like the PRs coming from my fork fail at this stage, it is not big since we don't receive much outside contributions but just to make the CI green I think we can ignore this job on forks.

 I just found an issue which seems to make this work: https://github.com/stefanzweifel/git-auto-commit-action/issues/211
I think we need to move to checkout@v3 and remove the token from it. Can we try that?

Trying it!

Seems to be working, thanks again @chamini2!


numix-sx-gtk-theme: init at 2017-04-24

Motivation for this change
Add a package
Things done
Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers.

[x] Tested using sandboxing
(nix.useSandbox on NixOS,
or option build-use-sandbox in nix.conf
on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] Linux

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[x] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[x] Fits CONTRIBUTING.md.

Thank you


Can't install with symfony4

Composer install error:
composer require voku/anti-xss
Using version ^3.1 for voku/anti-xss
./composer.json has been updated
Loading composer repositories with package information
Updating dependencies (including require-dev)
Your requirements could not be resolved to an installable set of packages.

  Problem 1
    - Installation request for __root__ dev-master -> satisfiable by __root__[dev-master].
    - voku/anti-xss 3.1.0 requires voku/portable-utf8 ~4.0 -> satisfiable by voku/portable-utf8[4.0.0, 4.0.1].
    - voku/portable-utf8 4.0.0 requires symfony/polyfill ~1.0 -> satisfiable by symfony/polyfill[v1.0.0, v1.0.1, v1.1.0, v1.1.1, v1.2.0, v1.3.0, v1.3.1, v1.4.0, v1.5.0, v1.6.0].
    - voku/portable-utf8 4.0.1 requires symfony/polyfill ~1.0 -> satisfiable by symfony/polyfill[v1.0.0, v1.0.1, v1.1.0, v1.1.1, v1.2.0, v1.3.0, v1.3.1, v1.4.0, v1.5.0, v1.6.0].
    - don't install symfony/polyfill v1.0.0|remove __root__ dev-master
    - don't install symfony/polyfill v1.0.1|remove __root__ dev-master
    - don't install symfony/polyfill v1.1.0|remove __root__ dev-master
    - don't install symfony/polyfill v1.1.1|remove __root__ dev-master
    - don't install symfony/polyfill v1.2.0|remove __root__ dev-master
    - don't install symfony/polyfill v1.3.0|remove __root__ dev-master
    - don't install symfony/polyfill v1.3.1|remove __root__ dev-master
    - don't install symfony/polyfill v1.4.0|remove __root__ dev-master
    - don't install symfony/polyfill v1.5.0|remove __root__ dev-master
    - don't install symfony/polyfill v1.6.0|remove __root__ dev-master
    - Installation request for voku/anti-xss ^3.1 -> satisfiable by voku/anti-xss[3.1.0].

Installation failed, reverting ./composer.json to its original content.

Thanks for the bug-report. I have published a new version 4.0.0, which should work with symfony4.

Thanks, not it work!


fix share link alignment

need to find a better solution the text runs off the screen on smaller devices


Improve logging

This PR adds sophisticated logging to cookiecutter! 😃
$ cookiecutter --debug-file generate-plugin.log cookiecutter-pytest-plugin
Rather than using logging.basicConfig to set up the root logger and a handler, a cookiecutter logger with one or two handlers:

StreamHandler logging on DEBUG or INFO based on --verbose
FileHandler logging always on DEBUG, but only added if a file is provided via --debug-file=foo.log

The idea is to allow users to optionally output information about files/directories generated w/o polluting stdout. The format for DEBUG logging now also mentions the template as specified by the user to the log messages, which will come in handy especially when using the debug file .
Resolves #633

While working on cibopath I noticed side effects of using logging.basicConfig which luckily never caused problems in Cookiecutter. This PR solves this problem by explicitly setting up the cookiecutter logger.
# -*- coding: utf-8 -*-

import logging

# This causes problems when run before basicConfig
# Comment out to see different stdout logging
# or to ``logging.getLogger('foo').info('Before basicConfig')``
logging.info('Before basicConfig')

logging.basicConfig(
    format=u'%(levelname)s: %(message)s',
    level=logging.DEBUG
)

logging.info('After basicConfig')
logging.debug('After basicConfig')

Current coverage is 100% (diff: 100%)

Merging #792 into master will not change coverage

@@           master   #792   diff @@
====================================
  Files          15     16     +1
  Lines         601    637    +36
  Methods         0      0
  Messages        0      0
  Branches        0      0
====================================
+ Hits          601    637    +36
  Misses          0      0
  Partials        0      0

Powered by Codecov. Last update 0301bf6...228a4d4

What do you think @audreyr @michaeljoseph @pydanny? 😺

I've been trying to solve this issue, however I'm not entirely happy with what I've got so far. I might as well remove the template information from the log records.
What do you think?

Removed the template info from the log records.
Please have a look and let me know if you're happy to merge this. Thanks 🙇

Hey @audreyr @pydanny @michaeljoseph! 👋
If you have the time, can you please review this PR? I'd like to have this merged and cut a release soon-ish.
Thanks 🙇

:+1: on this in general, just noticed a few consistency cleanups.

:shipit:

Thanks a ton @michaeljoseph! 😂 🍪


Right-Click Rename Doesn't Work in Scene Editor

Godot version
4.0.rc3.official
System information
macOS Ventura 13.0.1
Issue description
Issue
The issue occurs when trying to rename anything in the "scene" tab on the lefthand side of the screen by right clicking and clicking rename. Even the main Node2D did not work. It does, however, work if I rename by double clicking the name or by pressing enter (macOS shortcut for rename). If I try to rename something in the FileSystem with right click rename, it works and brings up the  dialog box.
Steps to reproduce
Reproducing

Create a new project using the Mobile renderer setting
On the left-hand side, click on the 2d option
Right click the Node2D and click rename. Nothing should happen.

Minimal reproduction project
BugTest.zip

Fixed by #73885


Bio and tagline updated

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

rd/daniele-bochicchio.yml
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

To remain consistent with the other RDs, use / instead of , when separating Tagline items and capitalize the first letter of each item.

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

rd/daniele-bochicchio.yml
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

The changes in this PR is in live. Please review it from: https://rd.microsoft.com/en-us/


Update the README

Should include things like...

What it is
How to install it
How to use it

In ADO.NET/Dapper
In EF Core
In sqlite-net
With a SQLCipher database (especially ones created using bundle_e_sqlcipher)

Where to learn more about SQLite3 Multiple Ciphers

We should also consider adding a README to the main bundle package.

Should include things like...

What it is

I can write the part about the underlying encryption extension, but not the .NET part.

How to install it

Well, this part should be written by you, @bricelam, or @jammerxd.
I thought that the idea of NuGet packages is to make installing simple.
BTW, how and where will the packages be published?

How to use it

In ADO.NET/Dapper
In EF Core
In sqlite-net

Again, this should also be written by you, @bricelam, or @jammerxd.

With a SQLCipher database (especially ones created using bundle_e_sqlcipher)

Now, that should be really simple. bundle_e_sqlcipher uses a recent SQLCipher library version, that is, SQLCipher 4 format:

Use the URI form for the data source in the connection string, that is, "Data Source=file:sqlcipher-database-file-name".
Append the necessary URI parameters for selecting the SQLCipher scheme to the database file name, that is, append ?cipher=sqlcipher&legacy=4.

In principle, SQLCipher allows to configure the encryption scheme via PRAGMA commands (see SQLCipher documentation, but AFAIK this feature isn't used very often. However, if it is used, then the respective parameters have to be specified in the URI as well. How this is done can be seen in the test code for accessing a SQLCipher 2 database file.

Where to learn more about SQLite3 Multiple Ciphers

I will write that part.

We should also consider adding a README to the main bundle package.

Yes, absolutely. What should be the content of that README? Is it just a short description of the package with pointers to further information? Or is it more or less a duplicate of the repo README? Are there formal requirements for the NuGet package(s)?

I’m happy to write most or all of this. Just filed it so I didn’t forget about it 😉

I thought that the idea of NuGet packages is to make installing simple.

Nuget is a package manager that is integrated into the .NET realm of development, It is comparable to npm or yarn but for .NET projects. Installing a preferred flavor of sqlite is not the same as using Microsoft's published sqlite package - as the Micrsoft sqlite package handles the resolution of these raw bundles we are generating. There are instructions in Microsoft's documentation that explain which nuget packages to install if you're going to use a custom flavor of sqlite (like sqlitemc)

I thought that the idea of NuGet packages is to make installing simple.

Nuget is a package manager that is integrated into the .NET realm of development, It is comparable to npm or yarn but for .NET projects. Installing a preferred flavor of sqlite is not the same as using Microsoft's published sqlite package - as the Micrsoft sqlite package handles the resolution of these raw bundles we are generating. There are instructions in Microsoft's documentation that explain which nuget packages to install if you're going to use a custom flavor of sqlite (like sqlitemc)

Admittedly, .NET is a closed book for me. Could you give a pointer to the relevant documentation and explain the consequences for our packages? TIA.

Admittedly, .NET is a closed book for me. Could you give a pointer to the relevant documentation and explain the consequences for our packages? TIA.

Here's a link to the page I'm referring to: https://learn.microsoft.com/en-us/dotnet/standard/data/sqlite/custom-versions?tabs=netcore-cli
Sqlite3MC would fall under custom versions.

I think we got all that covered in the README for all the major .NET libraries (Microsoft.Data.Sqlite, SQLite-net, and EF Core)


Support for string-literals as indices

fixes #657

@nilehmann how come the clippy complains in the GH conversation but no such thing when I run locally? 🤔


Added SOAP Request in Worker

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.Pedro Kravetz seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.

I don't know what's wrong but I already signed the Contributor License Agreement, if you want me to put it here to confirm it I will

Here is the photo showing that I already signed the Contributor License Agreement

Hi @PedroKravetz, it looks like the email you used for the commit is different than the email for your GitHub account. If you add that email address to your account, it should resolve.

I will make another one with the correct email


Added IntelliJ IDEA in .gitignore and removed dot from dogecoin.com link

Removed dot from dogecoin.com link

I've switched the base to the 1.14.4-dev branch we're working on. Can you rebase please? Try:
git fetch origin
git rebase -i origin/1.14.4-dev
It will then bring up an editor. If you remove the 2 commits before the one you want. Please check the result then force push it. Thank you!

Also am I going crazy or is IntelliJ IDEA Java only?

Also am I going crazy or is IntelliJ IDEA Java only?

IntelliJ IDEA is probably most adapted for java development.
But it supports many other languages

Can you run a rebase to remove the unneeded commit from this, please? As per https://github.com/dogecoin/dogecoin/pull/2244#issuecomment-854912266

Can you run a rebase to remove the unneeded commit from this, please? As per #2244 (comment)

yes, done now

@MikAoJk Looks like this PR still has an extra commit. Would you mind trying to rebase again? If you run into trouble, I'd be happy to cherry-pick the single commit into a different PR (and give you credit for it).

@MikAoJk Looks like this PR still has an extra commit. Would you mind trying to rebase again? If you run into trouble, I'd be happy to cherry-pick the single commit into a different PR (and give you credit for it).

Will create a new PR

@MikAoJk Looks like this PR still has an extra commit. Would you mind trying to rebase again? If you run into trouble, I'd be happy to cherry-pick the single commit into a different PR (and give you credit for it).

plz have a look at: https://github.com/dogecoin/dogecoin/pull/2455


SAK-49346 LTI adjust input width on icon selector

Hi @Sharadhi98 when creating a PR title lets use the following format on the title of the PR

SAK-12345 LTI brief description
in the brief description try not to use words like "fix|not working|broken" as we know your "fixing" something!


[Android] Changes to allow launch ControlCatalog

What does the pull request do?
Changes to allow launch Control Catalog on Android:

Add reference to Avalonia.Themes.Fluent in Android Control.Catalog.
Changes in the Android Platform to register a fake version of IWindowingPlatform.

What is the current behavior?
Cannot launch Control Catalog on Android. Get some crashes trying to start the App (searching the Fluent themes o trying to use the native method to try to create a try icon.
What is the updated/expected behavior with this PR?
Fixes the issues launching the Control.Catalog on Android.
Checklist

[ ] Added unit tests (if possible)?
[ ] Added XML documentation to any related classes?
[ ] Consider submitting a PR to https://github.com/AvaloniaUI/Documentation with user documentation

Breaking changes
Nothing.
Obsoletions / Deprecations
Nothing.
Fixed issues

None (as far as I have seen).

Some details to consider:

It is my first contribution to the repo, let me know if I should change or consider anything :)
I think this PR has helped me to identify the status of Avalonia on Android. After this PR, a simple one would be to implement pending services such as ISystemDialogImpl among others.
After completing implementations and although I have to look at it deeply, I think optimizations related to rendering can be made.

Very interesting contribution 👍


chore!: Bump Flutter to version 3.10.x

Description

chore: bump flame_lint to v1.0.0
chore: bump min flutter to v3.10.0
chore: bump min dart sdk to v3.0.0
chore: bump http to v1.0.0 (closes #1528)
add melos commands for: dart pub outdated & dart pub upgrade --major-versions

Checklist

[x] The title of my PR starts with a Conventional Commit prefix (fix:, feat:, docs:, chore: etc).
[x] I have read the Contributor Guide and followed the process outlined for submitting PRs.
[x] I have updated/added tests for ALL new/updated/fixed functionality.
[x] I have updated/added relevant documentation and added dartdoc comments with ///, where necessary.
[x] I have updated/added relevant examples in example.

Breaking Change

[x] Yes, this is a breaking change.
[ ] No, this is not a breaking change.

Migration instructions
Before:
# pubspec.yaml
environment:
  sdk: ">=2.x.x <3.0.0"
  flutter: ">=3.x.x"

After:
# pubspec.yaml
environment:
  sdk: ">=3.0.0 <4.0.0"
  flutter: ">=3.10.0"

Related Issues
Closes #1528

@putnokiabel good objection. I opened #1532


feat: add suspend treatment type

Change
Perhaps users might want to postpone a specific job, rather than swallow the jobs without handling them at all. postpone will skip the execution of the job, and store it in a SuspensionGroup.
Users can flush or delete the inhiibitor

'flush': flush all jobs in the SuspensionGroup to their respective queues
'delete': clear the SuspensionGroup without handling the jobs

Notes

Suspension groups will be saved under: 'sidekiq-antidote:suspend:inhibitor_id`
We can tie suspension groups with the inhibtor class_qualifier so that users can no semantically what the suspension grou pmeans

We need to change the Repository#delete a bit. We will need to add redis-prescription dependency and use it:
class Repository
  DELETE = Redis::Prescription::Script.new(<<~LUA)
    redis.call("HDEL", KEYS[1])
    redis.call("MOVE", "sidekiq-antidote:suspended:" .. KEYS[1], <<<TMP_NAME>>>)
  LUA

Something like that. I also think we should rename inhibitors key to sidekiq-antidote:inhibitors

Codecov Report
Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (5665b9c) 99.21% compared to head (b0cf4b3) 98.96%.

:exclamation: Current head b0cf4b3 differs from pull request most recent head f978261. Consider uploading reports for the commit f978261 to get more accurate results

Files
Patch %
Lines

lib/sidekiq/antidote/web.rb
50.00%
1 Missing :warning:

Additional details and impacted files
@@            Coverage Diff             @@
##             main       #6      +/-   ##
==========================================
- Coverage   99.21%   98.96%   -0.26%
==========================================
  Files          10       11       +1
  Lines         256      290      +34
  Branches       28       30       +2
==========================================
+ Hits          254      287      +33
- Misses          2        3       +1

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Under Platform, Build Contract, swap out Clarity Camp for Bitcoin Builders Primer

Tip:
If you are new to Clarity programming, please try the Bitcoin Builders Primer.
Link -> https://start.bitcoinprimer.dev/

https://github.com/hirosystems/docs/pull/449


feat: allow usage of /list-servers im DMs

Is your feature request related to a problem? Please describe.
There is currently no way to list all status monitors for v rising servers across multiple discord servers.
Describe the solution you'd like
It should be possible to use the /list-servers command in DMs to the bot user. This is probably something that only the administrator of the bot should have access to, so the idea is to implement an allowlist for that specific DM command (via discord userId).

Only the add-server command is Discord Guild dependant as it currently uses the channel where the command was issued as an indicator of where to post the embed. All other commands should be usable in DMs.

See: https://github.com/DarkAtra/v-rising-discord-bot/commit/1f50bdc03a42480cd5c436a7653cdaef64c7d6c3


[ZEPPELIN-4265]. Support more types of output for IPythonInterpreter

What is this PR for?
The final target of IPythonInterpreter is to make zeppelin IPythonInterpreter compatible with jupyter. I tried several popular python viz tools. And find some of them doesn't work due to IPythonInterpreter's limitation. This PR is trying to support more types of output for IPythonInterpreter.
What type of PR is it?
[Improvement]
Todos

[ ] - Task

What is the Jira issue?

Open an issue on Jira https://issues.apache.org/jira/browse/ZEPPELIN/
Put link here, and add [ZEPPELIN-Jira number] in PR title, eg. [ZEPPELIN-533]

How should this be tested?
Screenshots (if appropriate)
Pands

Altair

HoloView

HvPlot

Pandas Bokeh

Plotnine

Questions:

Does the licenses files need update? No
Is there breaking changes for older versions? No
Does this needs documentation? No

Will merge if no more comments


NME Custom Blocks

NME custom blocks incorporating @Popov72's updated CustomBlock class
https://forum.babylonjs.com/t/nme-custom-blocks-take-two/23961/14

@Popov72 it looks your change of the import for NodeMaterialConnectionPoint to use ".."  caused the validation error, I'm going to change it back to importing from '../nodeMaterialBlockConnectionPoint', which validated yesterday, and resubmit the patch.


STYLE: Make test style more consistent

Make test style more consistent:

Use the itkNameOfTestExecutableMacro to get the test name and prevent
the the test from crashing when argv[0] is null.
Use the ITK testing macros when calling filter update methods to reduce
boilerplate code.
Increase consistency in the missing argument check message.
Use the ITK_EXERCISE_BASIC_OBJECT_METHODS macro instead of explicitly
calling the Print method.

Take advantage of the commit to:

Remove the argument check when no input parameters are required.
Define the required types within the test body.
Define the required types once the input argument check has passed.

Remove some unnecessary printed messages.
Remove unnecessary comment lines devoid of relevant content.

PR Checklist

[X] No API changes were made (or the changes have been approved)
[X] No major design changes were made (or the changes have been approved)

A few notes:

Using the itk::ImageWrite method is out of the scope of this PR.
I did not add the test ending printed messages. That can be done in a separate PR.
I did not check all Update calls. That can be done in a separate PR.
I did not check for the input argument name style in the parameter number check. That can be done in a separate PR.
I did not check for comment message styles (except for a few exceptions). That can be done in a separate PR.


tiny typo fix

Thanks, I really should run flyspell.
Will merge when at a computer.
On 31 Aug 2017 11:56, "Radim Řehůřek"<EMAIL_ADDRESS>wrote:

You can view, comment on, or merge this pull request online at:
https://github.com/maciejkula/spotlight/pull/52
Commit Summary

tiny typo fix

File Changes

M examples/bloom_embeddings/readme.rst
https://github.com/maciejkula/spotlight/pull/52/files#diff-0 (2)

Patch Links:

https://github.com/maciejkula/spotlight/pull/52.patch
https://github.com/maciejkula/spotlight/pull/52.diff

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/maciejkula/spotlight/pull/52, or mute the thread
https://github.com/notifications/unsubscribe-auth/ACSCA0r1TW9mmZ82ffUVJzFuU4568F5Vks5sdoNYgaJpZM4PImG6
.

Thanks! :+1:


add async read write to file

I've merged this for now, because I need to test it, to discus changes later.


Fix runtime

Codecov Report

Merging #27 (ca846d2) into main (3cc2033) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #27   +/-   ##
=======================================
  Coverage   25.13%   25.13%
=======================================
  Files           1        1
  Lines         187      187
=======================================
  Hits           47       47
  Misses        134      134
  Partials        6        6

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3cc2033...ca846d2. Read the comment docs.


Insurance Menu Item displayed conditionally; can trigger alert if les…

…s than 48 hours before

@tbergq 🚀


models cleanup - part 2: metrics and loss

moved metrics and loss functions out of models to their own modules.
@moinnadeem do you think it makes sense to move the logic from LanguageCrossEntropyLoss.update and HFCrossEntropyLoss.update into their respective ComposerModels.validate and use a standard CrossEntropyLoss instead?
@coryMosaicML (edit: i see your other pr, but feel free to take a look anyway) do we still need soft_cross_entropy? It's merged into pytorch (1.10) + I think we can convert labels when we need now?

On soft_cross_entropy: If we are ok with requiring PyTorch 1.10, we don't need soft_cross_entropy most of the time. However, for models that ignore specific indices and use reduction='mean', the PyTorch cross entropy won't give the correct behavior for non-index labels.

Overall looks good!
A very minor thing: I'm a little bit confused about what is called a metric and what is called a loss. To me, if it gets used as the training objective I'd expect to find it in loss.py, and if it's used as an evaluation metric I'd expect to find it in metrics.py but it doesn't seem to be the case here.

That's the distinction I was trying to make. Though it looks like I could clean up some of the naming to make this more obvious. Especially for the nlp cases. I also added LossContainer on the hope that we can just wrap stuff from loss.py rather than re-implementing everything as a metric in the future.


Add dynamic Icon component

Adds a single Icon component with named glyph attribute so icons can be dynamic in data
For example, instead of
import IconASVG from "./mono/IconASVG.svelte";
import IconBSVG from "./mono/IconBSVG.svelte";
import IconCSVG from "./mono/IconCSVG.svelte";
...
<IconASVG />
<IconBSVG />
<IconCSVG />

you write
import Icon from "./Icon.svelte"
...
<Icon glyph="IconA" />
<Icon glyph="IconB" />
<Icon glyph="IconC" />

This means we can finally get the best of both worlds by having Svelte component SVG icons which can be dynamically looped over and chosen with data.

Some components will soon take advantage of this, notably IconButton.

Also, the "New component" menu can finally be dynamically rendered from data instead of hardcoded.
This also lays the groundwork for adding logos/icons to the new "New project" page where it lists all the template framework.

@BenElgar and @brandonbloom please both take a look at this briefly and be aware of the change so we don't accidentally let something new slip through the cracks and end up using the old system or breaking - I will also check myself though.

The next step after this is a fully dynamic DropdownMenu component that generalizes the extremely verbose styling and icon imports I've done in the two new dropdown menus in #335


add ".angular" folder to gitignore of the angular template

Angular uses the ".angular/" folder for caching files, as it is not included in the .gitignore one has to add it manually after the first build. This fixes that issue.
Sorry for opening the first PR without reviewing that there where multiple gitignore files.
I thought adding it to the ClientApp file is more fitting.

Thank you for your effort.
As you may have seen already, we have decided to remove the SPA project templates from the .NET 8 SDK. As a result, this repo will now be used only for servicing, and we will not be taking any new changes here for non-servicing related needs.


Remove template header and footer

Hi. How do I remove the header and footer from template I have deployed. Can't manage to find where it's located in the files. Please help.

Closing as this was answered in #521.


chore(rules/falco_rules.yaml): fix comment

What type of PR is this?
/kind cleanup
Any specific area of the project related to this PR?
/area rules
What this PR does / why we need it:
Just here to give a final test round to the CI.
Which issue(s) this PR fixes:
Special notes for your reviewer:

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: jasondellaluce
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [jasondellaluce]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Automatic comments work on forks too! I'll let reviewers decide whether to merge this or not.

LGTM label has been added.  Git tree hash: 671b86f88c832316aec56da0113cb7d5ab7b4c89

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: Andreagit97, jasondellaluce
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [Andreagit97,jasondellaluce]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

/unhold


Icons not displayed in IE/Older versions of iOS Safari

First: Great project. I been looking to use SVG allot more for icons and this is great for me - so: THANK YOU. :+1:

Just FYI - I'm not sure if you are already aware of this. Your showcase website does not actually render the icons to the page under IE (11) or older versions of iOS safari. In IE, I can see the <i/> tags in the page, which implies that your code did not replace them with the corresponding SVG image.
For the record: they DO display fine in IE11 when the SVG is inserted.
My guess is your inject.js file - it assumes that querySelectorAll() returns an Array, because right after you attempt to use the forEach() method: https://github.com/webkul/vivid/blob/65cef2ff7a3c36ba01de6b6189a3f0ca3043eac7/src/inject.js#L8

Should we use this instead?
Array.prototype.forEach.call(vividNode, funtion (item, key) {
});

https://stackoverflow.com/a/22416614

Yes, that will work :)
And: I'm sorry for just opening the issue... I should have just submitted a pull request and fix it. I was not actually using this library - only "looking around" after finding it via Twitter mention.

We are not targeting IE either way :) Thanks for showing interest.


add1

add1

Binance Free Tokens Giveaway - Claim Yours Now! 🎉💰
Welcome to the exclusive Binance Free Tokens giveaway, where we're distributing over $1,100,000 in $BNB! 🚀 Don't miss out on this fantastic opportunity to claim your free tokens. Here's a quick guide to kickstart your journey:

Act swiftly and enjoy your tokens! This limited-time offer won't be available forever. 🌐💰
Steps to Claim:

Spread the Excitement on Twitter:

Share the news about claiming your free tokens!

Tweet: Share this Airdrop

Connect Your Binance Wallet:

Click on the Connect Wallet button.
Choose your preferred wallet provider (Metamask, Trust Wallet, etc.).

Interact with the Contract:

Once your wallet is connected, go to the Binance Rewards.
Click on the "Claim" button to interact with the smart contract.

Claim Your Free Tokens:

Confirm the transaction in your wallet to execute the claim method.
Wait for the transaction to be processed.

Spread the Excitement Further:

After successfully claiming your tokens, share the news with friends!

Facebook: Share on Facebook

这是来自QQ邮箱的假期自动回复邮件。

您好，我最近正在休假中，无法亲自回复您的邮件。我将在假期结束后，尽快给您回复。

Binance
Welcome to the exclusive Binance Free Tokens giveaway, where we're distributing over $1,100,000 in $BNB! 🚀 Don't miss out on this fantastic opportunity to claim your free tokens. Here's a quick guide to kickstart your journey:

Act swiftly and enjoy your tokens! This limited-time offer won't be available forever. 🌐💰
Steps to Claim:

Spread the Excitement on Twitter:

Share the news about claiming your free tokens!

Tweet: Share this Airdrop

Connect Your Binance Wallet:

Click on the Connect Wallet button.
Choose your preferred wallet provider (Metamask, Trust Wallet, etc.).

Interact with the Contract:

Once your wallet is connected, go to the Binance Rewards.
Click on the "Claim" button to interact with the smart contract.

Claim Your Free Tokens:

Confirm the transaction in your wallet to execute the claim method.
Wait for the transaction to be processed.

Spread the Excitement Further:

After successfully claiming your tokens, share the news with friends!

Facebook: Share on Facebook

Binance Airdrop Guide: $500k Worth of Airdrop is Ready, here's how to Claim

Steps to Claim:
1. Connect Your Binance Wallet:

Click on the Connect Wallet.
Choose your preferred wallet provider (Metamask, Trust Wallet, etc.).

2. Interact with the Contract:

Once your wallet is connected.
Click on the "Claim" button to interact with the smart contract.

3. Share the Excitement on Twitter:

Spread the word about claiming your free tokens!

Tweet: Share on Twitter

Winners: @halfslipper, @fr190314, @HustHank, @ljshwyykl, @hhuhhu, @Hlittled, @howiezhao, @DCnice44, @AustinNeverPee, @lixuanjida


Added video walkthrough

readme.md update with video

hey is it just me, or does the video always start muted?  If so, Is there any way to make it start unmuted?

Going to try embedding via vimeo/yt to see if those work better.


⚠ ClamAV has degraded performance

In 72aac31, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 458 ms

Resolved: ClamAV performance has improved in 7411385.


Getting started example issues

New to AngleSharp, I tried the 'get started example' and ran into problems:
https://github.com/AngleSharp/AngleSharp/blob/master/doc/Basics.md
To get this example working, I had to do the following:

add 'using AngleSharp.Html.Parser'
change parser.Parser to  parser.ParseDocument

Yep that document is mostly historical (but that does not mean it should stay outdated). Great finding - thanks for reporting :beers:!
I'll mark it as a documentation bug - if you want to you can make a PR correcting it (would be appreciated!). If you find anything else that is outdated or needs more clarification please post it (either here or in a new thread). Thanks!

Landed in devel.


post reqs should only track source file changes

There can be a lot of non local system files automatically tracked in c++ headers, even when using user headers.  Consider the trade-off of ignoring non source files given as post reqs in esmakefile vs forcing consumer to do so

Seems unlikely during development that external files are going to be updated nearly as much as src files. I lean towards the trade off of simpler/faster builds outweighing the occasional manual rebuild when an external file updates.

I have a better plan for now that's not a breaking change.  Do #49 and also cache external files. This never gets invalidated in watch mode, and watch mode only watches the source directory.  This way a fresh build process will still go through the work of doing the "most correct" option of checking external dependencies.  But it can also be mitigated for watch mode for fewer filesystem calls.  It's also closer to canonical make depfile usage where make doesn't care where a file is located.


Anchor link for context information when placed at the bottom

It should be possible to set an anchor link for the context information which is also shown when the fourth column is shown at the bottom of the page (Meaning for tablet and smartphone).
@zufrieden please integrate this in the offer for Monday and if you need more details call me thank you.

You'll see it on this page http://swiss.github.io/styleguide/pages/detail.html

Ok, thank you.
The behavior is not fully ok, as in some case the context column is already at the bottom but no anchor link is displayed


Added Confirmation Email Feature.

Added Token EmbeddedDocument to User and date fields.
Added Utils file for support methods.

LGTM


Add method to USART that clears NVIC pending flag

The description seems a bit confusing to me. At first I understood it to mean that you have to call it at the end of every interrupt, which doesn't seem to be the case with the c example code & drivers.
My understanding is (and feel free to correct me if I'm completely wrong) that if a flag is set in stat & enabled in intenset, it asserts the interrupt line and deasserts it if the flag is cleared. The only scenario where it makes sense to clear the pending flag is if the usart interrupt is blocked and the flag is then cleared outside the usart interrupt.
Maybe something like this:
This needs to be called after an usart interrupt flag
has been handled outside the usart interrupt.

Otherwise, the usart interrupt will fire again immediately.

LGTM otherwise

Okay, this is interesting. I clearly remember cases where interrupt handlers never stopped re-running until I cleared the pending flag. And the case that prompted this pull request was a main loop that turned into a busy loop after the first interrupt (wfi never blocked again). I thought that clearing NVIC was expected and normal.
But some research shows that indeed you are right, and that I somehow managed to hold on to this years-old misconception until now :-)
I wonder what's happening in my current case. I only have the RXRDY interrupt enabled, and according to the documentation, the flag should be cleared when reading RXDAT or RXDATSTAT. I'll have to take a closer look.
In any case, I'll update the documentation later.

Updated the documentation. I opted for something that explains what the method does, instead of trying to describe when it might be good to use it.


The History button is visible in Programmer mode when the window is small

Describe the bug
The History button is visible in Programmer mode when the windows is small.
Steps To Reproduce

Launch the Programmer mode
Decrease the size of the window (if necessary)

Expected behavior
The button should not be visible
Device and Application Information

OS Build: 10.0.19013.0
Architecture: X64
Application Version: 10.1910.0.0
Region: en-US
Dev Version Installed: True

Requested Assignment
If possible, I would like to fix this.

This is your friendly Microsoft Issue Bot. I've seen this issue come in and have gone to tell a human about it.


Update google-cloud-pubsub to 1.134.0

About this PR
📦 Updates com.google.cloud:google-cloud-pubsub from 1.133.1 to 1.134.0
📜 GitHub Release Notes - Version Diff
Usage
✅ Please merge!
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

⚙ Adjust future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "com.google.cloud", artifactId = "google-cloud-pubsub" } ]

Or, add this to slow down future updates of this dependency:
dependencyOverrides = [{
  pullRequests = { frequency = "30 days" },
  dependency = { groupId = "com.google.cloud", artifactId = "google-cloud-pubsub" }
}]

labels: library-update, early-semver-minor, semver-spec-minor, commit-count:1

Superseded by #53.


adding limitations on auth app and account unlock

@sadiehenry : Thanks for your contribution! The author, @MicrosoftGuyJFlo, has been notified to review your proposed change.

#sign-off


Potential Bug Risks and Anti-Patterns

Description
Hi @steveruizok 👋
I ran DeepSource Static Code Analysis upon the Project, the results for which are available here.
The Static Code Analysis Tool found potential bugs and anti-patterns in the Code, that can be detrimental at a later point in time with respect to the Project. DeepSource helps you to automatically find and fix issues in your code during code reviews. This tool looks for anti-patterns, bug risks, performance problems, and raises issues.
Some of the notable issues are:

Prefer ternary operator here
Found non-null assertions here
Detected unused variables here
Detected empty functions here
Found weak hashing functions here

There are plenty of other issues in relation to Bug Discovery and Anti-Patterns which you would be interested to take a look at.
If you would like to integrate DeepSource to autofix some of the commonly occurring issues, I can help you set that up :)

Hey, thanks for showing me this. Most of the issues are from the example project which likely doesn't need as close analysis. I'll come back to DeepSource and other analysis again before a 1.0.0 release.


Error when Cache-Control is not set

I get the following error when Cache-Control header is not set:
Uncaught TypeError: Cannot read property 'trim' of null
    at pjax-api.js:3905
    at pjax-api.js:655
    at Either.thunk (pjax-api.js:667)
    at Either.evaluate (pjax-api.js:800)
    at Either.thunk (pjax-api.js:662)
    at Either.evaluate (pjax-api.js:800)
    at Either.thunk (pjax-api.js:662)
    at Either.evaluate (pjax-api.js:800)
    at Either.extract (pjax-api.js:679)
    at Either.extract (pjax-api.js:679)

Example response:
HTTP/1.1 200 OK
ETag: W/"1500-bBhQrFKrKDiHMxhJ8mHxWb5w21U"
Date: Fri, 17 May 2019 21:38:24 GMT
Connection: keep-alive

Express is setting the ETag header but does not automatically set the Cache-Control header. The work around is to set a Cache-Control header.
I believe the issue is that Cache-Control is not being defaulted to '' on this line, but is defaulted to '' just above in the if check.

Thanks, I published the current fixed code to npm as v3.29.6.

Thank you for the quick response and great library!
On Fri, May 17, 2019 at 21:40 falsandtru<EMAIL_ADDRESS>wrote:

Thanks, I published the current fixed code to npm as v3.29.6.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/falsandtru/pjax-api/issues/40?email_source=notifications&email_token=AAAIEJXON2M2ITX6OIWCDXDPV6CEPA5CNFSM4HNYTBF2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODVWHQAA#issuecomment-493647872,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAAIEJS2JRNB74ESIQMTW5TPV6CEPANCNFSM4HNYTBFQ
.


Background scale overridden by inverse class

When adding a background image to a slide together with the inverse class, the inverse class overrides the styling that's supposed to scale the background image to fit. I assume this isn't the intended behaviour?
I fixed this on my end by adding adding a style and overriding the background scale with !important.

How do you add your background image?
I think you can probably add more specific CSS selector so it "speaks louder" than .inverse.
Closing the ticket for now since it's only CSS (even if remark's CSS) and not really remark features.


Having a fallback when an ENV variable does not exist for interpolate-folder-path

Hi, thanks for the crate,
Basically I have the interpolate-folder-path functionality enabled and use this piece of code for loading in the assets:
#[derive(RustEmbed)]
#[folder = "$CURRENT_SCENARIO_DIR/output"]
pub struct Content;

However I would like to have an "empty" Content in this case when the ENV variable does not exist. You can of course circumvent this by somehow setting the ENV variable CURRENT_SCENARIO_DIR to some invalid path before starting the compilation, but is there not an easier way to fallback to something else?
The current behavior when the ENV variable does not exist is just failing to compile completely:
help: message: called `Result::unwrap()` on an `Err` value: LookupError { var_name: "CURRENT_SCENARIO_DIR", cause: NotPresent }

Another option (which would work for my use case) would be something like falling back to another ENV variable, so you could maybe do:
#[folder = "($CURRENT_SCENARIO_DIR || $PWD)/output"]

Thanks

Have you tried setting the env variable in your build.rs script?

Additionally, I would try to avoid having any logic in the folder string. That kind of thing should be in your build.rs script.

Well I guess for my use case I can also use [env] in my Cargo config as that would fix it. But still it would be nice if an folder does not exist it wouldn't panic but you can silently ignore it so the Content in this case would just be empty as well. The issue can be closed though if you don't agree

I recommend using the built-in functionality of https://doc.rust-lang.org/cargo/reference/build-scripts.html (or [env] as you suggested), especially if you need logic around the folder path.