GenLens for case classes with private[package] members doesn't work

Consider the following example
object A {
  case class B(private[A] val c: Int, private[A] val d: Int)

  def lensOfC: Lens[B, Int] = GenLens[B](_.c)
}

This gives the error message Cannot find method c in A. But c is perfectly visible in the place where GenLens is called, so in my view this should be possible.
The same problem occurs when using private[B] val c and using it in the companion object B.

Are you sure? I'm pretty sure B.c isn't available at that point
scala> :paste
// Entering paste mode (ctrl-D to finish)

object A {
  case class B(private[A] val c: Int, private[A] val d: Int)

  def p = println(B.c)
}

// Exiting paste mode, now interpreting.

<pastie>:31: error: value c is not a member of object A.B
         def p = println(B.c)
                           ^

c is not a member of the object B but of the class B, but that has nothing to do with the private[A] val annotation. The following does indeed compile:
scala> :paste
// Entering paste mode (ctrl-D to finish)

object A {
  case class B(private[A] val c: Int, private[A] val d: Int)

  def p = println(B(1, 2).c)
}

// Exiting paste mode, now interpreting.

defined object A

I researched this a little bit; so the problem appears to be in https://github.com/julien-truffaut/Monocle/blob/bd801df5a51dc02100652e899260842e12d7adb7/macro/shared/src/main/scala/monocle/macros/internal/Macro.scala#L64
val fieldMethod = sTpe.decls.collectFirst {
      case m: MethodSymbol if m.isCaseAccessor && m.name.decodedName.toString == strFieldName => m
}.getOrElse(c.abort(c.enclosingPosition, s"Cannot find method $strFieldName in $sTpe"))

I played around a little bit with the following result:
scala> import reflect.runtime.universe._
import reflect.runtime.universe._

scala> case class B(c: Int, val e: Int, private[B] val f: Int)
defined class B

scala> typeOf[B].decls.collect { case m: MethodSymbol if m.isCaseAccessor => m.name.toString }
res32: Iterable[String] = List(c, e, f$access$2)

so scala seems to append $acces$number to values prefixed with private[package]. I wonder why that is the case. Strange.


Carried velocity is incorrectly applied on iOS

On iOS with BouncingScrollPhysics the carried velocity that is applied at the end of a scroll activity seems to be incorrectly applied. It will always apply the velocity even if the last fling's velocity was substantially less than previous flings. This will cause the visible effect of the scrollview accelerating after a slower fling.
Steps to Reproduce
These steps assumes the usage of the scroll_overlay platform test
For the unxperienced finger this is a bit challenging to intentionally trigger.  Therefor I have included two ways to trigger it and a video at the end (as it was difficult to show how to reproduce with just a screen-capture).

Build momentum by flinging 3-4 times a bit fast
Then while continuing to fling slow down the velocity of the flings
Make one final fling that is slowing that the flings you made 3-4 times
Observe that the scrollview's velocity is a lot more than the native scroll view and in some cases will even have a larger velocity than what you finger had while in contact with the screen.

https://user-images.githubusercontent.com/1550685/112858768-79faf380-90b2-11eb-8133-3d07029d486d.mp4
Expected results:
Somewhat similar velocity to the native iOS scrollview when lifting the finger for the last time
Actual results:
The scrollview simply added the previously carried momentum to the velocity of the current fling. Causing the effect of making the scrollview speed up and scroll for much longer than the native view. This is especially jarring when you barely have any velocity while lifting the finger with carried momentum, like trying to stop a scroll by swiping just a little bit.
[✓] Flutter (Channel beta, 1.25.0-8.3.pre, on macOS 11.1 20C69 darwin-x64, locale en-GB)
    • Flutter version 1.25.0-8.3.pre at /Users/trymnilsen/development/flutter
    • Framework revision 5d36f2e7f5 (2 months ago), 2021-01-14 15:57:49 -0800
    • Engine revision 7a8f8ca02c
    • Dart version 2.12.0 (build 2.12.0-133.7.beta)

[✓] Android toolchain - develop for Android devices (Android SDK version 30.0.2)
    • Android SDK at /Users/trymnilsen/Library/Android/sdk
    • Platform android-30, build-tools 30.0.2
    • Java binary at: /Applications/Android Studio 4.1 Preview.app/Contents/jre/jdk/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b3-6222593)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Xcode 12.4, Build version 12D4e
    • CocoaPods version 1.9.3

[✓] Android Studio (version 4.1)
    • Android Studio at /Applications/Android Studio 4.1 Preview.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b3-6222593)

[✓] Android Studio
    • Android Studio at /Applications/Android Studio Preview.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 11.0.8+10-b944.6842174)

[✓] Android Studio (version 4.0)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin version 46.0.2
    • Dart plugin version 193.7361
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b3-6222593)

[✓] VS Code (version 1.54.3)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.20.0

[✓] Connected device (1 available)
    • iPhone (mobile) • <id redacted> • ios • iOS 14.4.2

• No issues found!

potentially a duplicate of https://github.com/flutter/flutter/issues/77043

Hi @trymnilsen
This indeed looks like a duplicate of https://github.com/flutter/flutter/issues/77043
I can reproduce the issue when following your reproducible as well as using the code sample from  https://github.com/flutter/flutter/issues/77043#issuecomment-788884763
Please follow up on that issue, I'm closing the current one as a duplicate.
If you disagree, please write in the comments and I will reopen it.
Thank you

@TahaTesser Fine by my. Created an suggestion for a fix at https://github.com/flutter/flutter/pull/79382


Improve UX for UNION vs UNION ALL

Is your feature request related to a problem or challenge? Please describe what you are trying to do.
The current support for UNION vs UNION ALL is confusing to me, in the context of trying to map this to another query engine's support for these operators.

The logical plan simply has the Union operator and this is currently assumed to represent UNION ALL.
The SQL planner has logic to wrap a union with an aggregate query and that seems like something we would want in the physical plan but not in the logical plan
The DataFrame API does not have a function for performing a regular UNION. It is possible to manually wrap a union in a distinct to achieve this but that might not be obvious to users. Also, the documentation for distinct is incorrect and says that it performs a union

DataFusion Logical Plan
❯ explain select * from foo union select * from foo;
+---------------+----------------------------------------------------------------------------------------------------------------+
| plan_type     | plan                                                                                |
+---------------+----------------------------------------------------------------------------------------------------------------+
| logical_plan  | Projection: #a, #b                                                                                |
|               |   Aggregate: groupBy=[[#a, #b]], aggr=[[]]                                                                     |
|               |     Union                                                                                |
|               |       Projection: #foo.a, #foo.b                                                                               |
|               |         TableScan: foo projection=Some([0, 1])                                                                 |
|               |       Projection: #foo.a, #foo.b                                                                               |
|               |         TableScan: foo projection=Some([0, 1])                                                                 |
+---------------+----------------------------------------------------------------------------------------------------------------+

Spark Logical Plan
'Distinct
+- 'Union false, false
   :- 'Project ['a]
   :  +- 'UnresolvedRelation [t1], [], false
   +- 'Project [unresolvedalias(1, None)]
      +- 'UnresolvedRelation [t1], [], false

Spark Physical Plan
*(2) HashAggregate(keys=[a#4], functions=[], output=[a#4])
+- Exchange hashpartitioning(a#4, 200), ENSURE_REQUIREMENTS, [id=#26]
   +- *(1) HashAggregate(keys=[a#4], functions=[], output=[a#4])
      +- Union
         :- LocalTableScan [a#4]
         +- LocalTableScan [1#6]

Describe the solution you'd like
I think what we want is:

Introduce a Distinct operator in the logical plan
Have the DataFrame distinct function create the Distinct operator instead of the aggregate query
The DataFrame API should have functions for both union (existing method representing UNION ALL) and union_distinct
The physical planner should translate Distinct to an aggregate query

Describe alternatives you've considered
Leave things as they are and improve the documentation.
Additional context
For users of DataFusion for SQL query planning, it would be easier to map union/union all to other engines rather than trying to reverse engineer the aggregate query wrapping the union.

Given the usecase is trying to map Union plans to what Spark does, using an explicit Distinct in the logical plan (that is converted into a GroupBy when doing physical planning makes sense to me 👍
Doing the UNION --> GroupBy transformation during SQL planning was probably a shortcut.

Will take a look at this


[szip] add definitions for the try_run call for iOS

Describe the pull request

What does your PR fix?
Fixes building szip for iOS

Which triplets are supported/not supported? Have you updated the CI baseline?

arm64-ios and arm-ios were tested, and they build. I currently have no way to confirm functionality, but I have checked that my additions should be correct in theory.

Does your PR follow the maintainer guide?

It seems like it. My comments may be too verbose, but I think they're helpful to know why the cached output is correct and acceptable.

Yes

Thanks!


Next Node.js

Coverage remained the same at 62.302% when pulling 56d80f4875231211fa858ec16dbb48d425cadc56 on next-node.js into 18cea3291ccebd4fe18fd22028f7812903b3a1f3 on master.


Possibly bail when trying to add the same versioned component

In src/ops/fuelup_component/add.rs's add() function, should we warn then bail if the requesting version is what we already have?

Maybe not. I'm thinking clobbering is probably the right thing to do, especially when someone accidently kills their local toolchain

If it's what they already have, I think we should print an info message and do nothing.


chore(storage): reduce reschedule when cancel task

I hereby agree to the terms of the Singularity Data, Inc. Contributor License Agreement.
What's changed and what's your intention?
as title
Please explain IN DETAIL what the changes are in this PR and why they are needed:

avoid reschedule pick compaction when NoAvailCompactor

Refer to a related PR or issue link (optional)

https://github.com/risingwavelabs/risingwave/issues/5303

https://github.com/risingwavelabs/risingwave/pull/5405


dpkg: error processing r-base-core (--configure): causing build error

Hi!
I've been using the r-travis method to run R on travis for awhile now (> year). It's been working like a charm. However, for some reason, the build crapped out today (see https://travis-ci.org/ropensci/rglobi/builds/65928670).  Before jumping into it, I wanted to share the issue publicly, because I think that others (e.g. @sckott) are also experiencing the issue and might have a fix/workaround already.
snippet of build log:
update-alternatives: using /usr/bin/tclsh8.5 to provide /usr/bin/tclsh (tclsh) in auto mode.

Setting up tk8.5 (8.5.11-1) ...

update-alternatives: using /usr/bin/wish8.5 to provide /usr/bin/wish (wish) in auto mode.

Setting up r-base-core (3.2.3-3precise0) ...

Creating config file /etc/R/Renviron with new version

/var/lib/dpkg/info/r-base-core.postinst: 57: /var/lib/dpkg/info/r-base-core.postinst: mktexlsr: not found

dpkg: error processing r-base-core (--configure):

 subprocess installed post-installation script returned error exit status 127

Setting up liblzma-dev (5.1.1alpha+20110809-3) ...

dpkg: dependency problems prevent configuration of r-base-dev:

 r-base-dev depends on r-base-core (>= 3.2.3-3precise0); however:

  Package r-base-core is not configured yet.

dpkg: error processing r-base-dev (--configure):

 dependency problems - leaving unconfigured

dpkg: dependency problems prevent configuration of r-cran-boot:

 r-cran-boot depends on r-base-core (>= 3.2.1-2precise0); however:

  Package r-base-core is not configured yet.

 r-cran-boot depends on r-api-3; however:

  Package r-api-3 is not installed.

This looks like the same root failure as https://github.com/travis-ci/travis-ci/issues/5462#issuecomment-171674080 if I'm reading it right; I think everything is back to working again?

Yep.

Yes this is fixed, @jhpoelen if you restart your build it should not produce this error anymore.

I didn't see any of the reported errors after restarting the build. Thank you @craigcitro @eddelbuettel @jimhester for speedy replies.


Change cache action from default to Swatinem/rust-cache@v1

In first run, the time is 4 min for tests and coverage, 6 min for integration tests : https://github.com/YJDoc2/youki/pull/6/checks?check_run_id=3531671918

After updating and cache hit, test and coverage complete in 2 mins, out of which test seem not to have cgroups cached. integration test were not cached, so still take 6 min

Now after adding cache to integration tests, it takes 5 mins to run, with build time decreased from 3min to 1 min

After separate cache for cgroups, it takes test job 1 min :tada:

Now test and coverage both take 1 min, integration still takes about 5 min, but build time is slightly less, not that much. :tada: :tada: :tada:


Addition of example.md

This commit contains a new document that showcases an example attack on a test AP that I own.

Looking good so far, thanks.
But the usage of the BPF is misleading.
This are simple BPF's
Target: 00c0cab035be
simple BPF to attack this target: "wlan addr 3 00c0cab035be"
simple BPF to protect this target: "not wlan addr 3 00c0cab035be"

This is a an advanced BPF, because it allows hcxdumptool to interact on BROADCAST MACs.
advanced BPF to attack this target and to allow to handle BROADCAST frames: "wlan addr 3 00c0cab035be or wlan addr3 ffffffffffff"
While this BPF is useless:
The full command to create a BPF to _protect_ 00c0cab035be would be as follows:
hcxdumptool --bpfc="not wlan addr3 00c0cab035be or wlan addr3 ffffffffffff" >> protect.bpf

"not wlan addr3 00c0cab035be" == this MAC will be filtered out and all other MACs are allowed - that include the BROADCAST MAC ffffffffffff - so, no need to add  "or wlan addr3 ffffffffffff"
Please note:
hcxdumptool use BLOCK ACK frames to detect connected CLIENTs. This frames do not have an addr 3.
Using this attack filter "wlan addr 3 00c0cab035be" they are filtered out.
To include them to an attack filter: "wlan addr 1 00c0cab035be or wlan addr 2 00c0cab035be or wlan addr 3 00c0cab035be"
Not merged because usage of the BPF is misleading.

Ok, I understand. I'll change the content so it is actually correct.
I'm slightly confused as the output of hcxdumptool --help and hcxdumptool -h do not mention wlan addr 1, wlan addr 2, or wlan addr 3.

That's not really flexible.
hcxdumptool allows to apply a BPF. That is extreme fast (running in kernel space) and allows to filter nearly everything (by MACs on addr1, 2, 3, 4 as well as frames by types or by content) - without changing hcxdumptools source code!

@ZerBea
The requested changes have been made. :)

Now its fine. Thanks. Merged.

@ZerBea
I just tried to use `hcxdumptool --bpfc="not wlan addr 3<PHONE_NUMBER>66"<PHONE_NUMBER>66 is a placeholder MAC) and hcxdumptool threw an error stating that it couldn't compile the BPF.
Ex:
~ $ hcxdumptool --bpfc="not wlan addr 3 e45f0166cd50"
failed to compile BPF

BTW:
I've added "Detailed knowledge of Bolean Operators" to requirements section of README.md.
Correct is "wlan addx" and not wlan "addr x" - that was an ugly copy and paste error.

I'll open another pull request with fixed BPF syntax. Gimme a few.


Fix grammar

Removed superfluous "be"

@paulkel - thank you for submitted this correction!

Thanks @paulkel!


repeat responses are lost with --json formatting option

I am trying to find the response times of repeated request. I saw that the timings in the response would be useful for this.
httpyac send post.http -n post --repeat 2 --repeat-mode serial > .\post-log.json
after cleaning up the file,
jq '.responses[].timings' .\post-log.json
{
  "wait": 3,
  "dns": 10,
  "tcp": 196,
  "tls": 397,
  "request": 1,
  "firstByte": 200,
  "download": 4,
  "total": 811
}
{
  "wait": 3,
  "dns": 11,
  "tcp": 208,
  "tls": 407,
  "request": 0,
  "firstByte": 208,
  "download": 0,
  "total": 837
}

But, if I try to use the option --json to get the response in a easily parsed format, the output does not contain the responses from repeated requests. It only contains one response.
httpyac send post.http -n post --repeat 2 --repeat-mode serial --json > .\post-log.json
jq '.requests[].response.timings' .\post-log.json
{
  "wait": 2,
  "dns": 10,
  "tcp": 205,
  "tls": 407,
  "request": 0,
  "firstByte": 207,
  "download": 4,
  "total": 835
}

Note:  the field is now named response and not responses
Also, with release 5.2.1 as fix for issue https://github.com/httpyac/httpyac.github.io/issues/34, fields count and statusCount were added to the summary. These are also lost if the formatting option --json is used.

@dinurp Actually, it already works as it is designed. The idea of repeat is to quickly send several requests at the same time and thus put the server under load. These are not treated as own requests, but are merged at the end in the body of the first request. In the JSON output, I output the body only as a string and these contain the timings that you are interested in. For this reason it would be better for you to simply use `--output body' here.
I noticed that the timings are not properly merged in the '--json' output . The root element contains only the first timings object. I change this and output the average. And additionally I make it possible that the timings are also output when using --output exchange or --output timings.

Thanks for pointing me to the right direction. I see that I can get what I was looking for by parsing the body.
httpyac send post.http -n post--repeat 25 --json  > out.json
jq "[.requests[].response.body|fromjson|.responses[]|{statusCode,timings}]" out.json


Vultr image does not existing

Hello,
I'm trying to execute this:
sudo coreos-install -d /dev/vda -C stable

But I get
/bin/coreos-install: Image URL unavailable: http://stable.release.core-os.net/amd64-usr/410.0.0/coreos_production_vultr_image.bin.bz2

How I can fix it ? Thank you.

Please reopen if you're still having an issue with the install script.

Hello, i do have an issue, trying to install to HD from image at VULTR using he last command  from user marineam, I am getting this error a while after starting installation . Actualy the last succesfull report is :
gpg: Good signature from "CoreOS Buildbot (Offical Builds<EMAIL_ADDRESS>[ultimate]
and then errors
/bin/coreos-install: line 249: /sbin/blockdev: Input/output error
/bin/coreos-install: line 1: /bin/rm: Input/output error
Please Help


Use rawgit CDN for jasmine dependencies

Currently, browsing https://rawgit.com/tus/tus-js-client/master/test/SpecRunner.html (as advertised in the README) simply fails because jasmine is inserted via ../node_modules:
https://rawgit.com/tus/tus-js-client/master/node_modules/jasmine-core/lib/jasmine-core/jasmine.css
Failed to load resource: the server responded with a status of 404 ()

This PR fixes this by using the rawgit urls for the jasmine dependencies.
I don't know if this can break SauceLabs tests ?

This PR slipped through my eyes, I apologize for that. But I want to thank you for this PR, anyways!


Add non-legacy method names to kefir.Emitter

After doing this I see that Kefir actually ships with up-to-date types, however, many people may not notice this and look to flow-typed for the definitions instead.
In 3.3.0, two methods were renamed. The old names work for now so I've just added new definitions and kept the old ones.

8e74738876de96ff810ef18ab01a96e38d3803b3

For future ref: Since this libdef is 3.x.x, that means it must also be compatible with 3.2.x as well -- but 3.2.x doesn't have these new methods.
So instead of adding these methods here, I went ahead and just created a 3.3.x version of the libdef over in 8e74738876de96ff810ef18ab01a96e38d3803b3 and reverted the changes in the 3.x.x libdef.


Redfish: Thermal

Dev: https://github.com/ibm-openbmc/dev/issues/275

curl -k  https://${bmc}/redfish/v1/Chassis/chassis/Thermal

Thanks @garzam .. Closing it


The current floor() actually rounds towards zero

Expected: floor(-1.5) = -2
Actual: floor(-1.5) = -1

fixed result for negative operands in https://github.com/cicada-mpc/cicada-mpc/commit/4682e162c0fb78942b2905b16e152fe7e0489b79


kernel/idle: Correct SMP_FALLBACK define

Corrected the define of SMP_FALLBACK to prevent llvm warning.
llvm issues a warning as the behaviour of using defined(x) inside a
macro expansion is undefined (https://reviews.llvm.org/D15866).
zephyr/code/zephyr/kernel/idle.c:63:6: error: macro expansion producing 'defined' has undefined behavior [-Werror,-Wexpansion-to-defined]
#if !SMP_FALLBACK

Huh... learn something new every day.

Same here, possibly a none-issue for zephyr but the fix is so trivial it is possibly not worth disabling the warning


Fix typo

Hi @mybayern1974, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!

It looks like you're a Microsoft contributor (Nanxuan Xu). If you're full-time, we DON'T require a Contribution License Agreement. If you are a vendor, please DO sign the electronic Contribution License Agreement. It will take 2 minutes and there's no faxing! https://cla.microsoft.com.

TTYL, MSBOT;

@mybayern1974 : Thanks for your contribution to the Azure documentation! The author, @shizn, has been notified to review your proposed change.

#sign-off @mybayern1974  Thanks. Good catch! :)


server: Do not suppress image repull in cri-o

- What I did and How I did it
The PullImage function is trying to be too smart and as a result suppressing pulls where the imagePullPolicy is Always. This policy is not plumbed down and so we must trust the caller to do this check. This change removes the check from cri-o. This matches the behavior of docker, which does repull if the tag has changed.
While Kubernetes implements the check for an existing image (gated by the imagePullPolicy), performance may be impacted if the caller does not. To avoid that we need the image library to avoid redownloading a layer already in the cache. Unfortunately that doesn't work reliably today: containers/image#155
- How to verify it

Push image to docker registry.
Create pod with image.
Delete pod.
Push a new image with the same tag name to the docker registry.
Create a new pod with the imagePullPolicy as Always (or use the image tag of latest).
Verify the new pod is running the new image.

This involves pushing images to a docker registry, making it difficult to add automated tests.
- Description for the changelog
server: Do not suppress image repull

This is tricky, and I think this is not the right approach unfortunately.
The reason Docker is re-pulling is because the image config (or image ID) is actually different than the one already stored with the same name(:tag). Docker handles this here https://github.com/moby/moby/blob/master/distribution/pull_v2.go#L546
Here in cri-o (with c/image and c/storage) we're not currently storing images ID as digest(image.config) which makes this issue and others... Tricky...
Till we address the image ID fix (using the config digest instead of random ID) I'm afraid we need a way to check config digests here in cri-o "on the fly". I'm currently AFK but I'll probably get at this tomorrow or next week. /cc @nalind

@apilloud PTAL at #1138

@runcom I think this patch is something we'd previously discussed needing, since otherwise cri-o refuses to ever pull a newer version of an image that's already present in local storage.
In earlier cri-o versions, pulling the exact same image twice incorrectly produced two IDs, after downloading all of the layers a second time, but that should largely be fixed by a combination of #654 and #1116.  With this patch added to them, so that cri-o will actually try to pull the image, that second pull attempt should only end up reading the manifest, the configuration blob, and perhaps signatures.

Ack @nalind, but reaching the manifest and all the blobs on a remote location is more costly then just checking storage and just a manifest. I believe the PR I opened addresses this issue better rather than dropping this core altogether (I'll special case the schema1 stuff BTW)

I fully agree on why docker repulls. My understanding is that if the c/image library used cached blobs when pulling a new image (rather then redownloading them) this would have the same network impact as #1138. Seeing as that isn't true and doing the checks at that layer is hard, I'm going to close this in favor of #1138.


Allow multiple nested commands

Subcommands nested more than one level don't work.
#!/usr/bin/env ruby
require 'thor'

module Cli
  class User < Thor
    desc "hello <name>", "Say hello to <name>"
    def hello name
      puts name
    end
  end

  class Remote < Thor
    desc "add <name> <url>", "Adds a remote named <name> for the repository at <url>"
    def add name, url
      puts name
    end

    desc "rename <old> <new>", "Rename the remote named <old> to <new>"
    def rename old, new
    end

    desc "user SUBCOMMAND ...ARGS", "manage set of tracked repositories"
    subcommand "user", User
  end

  class Main < Thor
    desc "fetch <repository> [<refspec>...]", "Download objects and refs from another repository"
    options :all => :boolean, :multiple => :boolean
    option :append, :type => :boolean, :aliases => :a
    def fetch repository, *refspec
      puts repository
    end

    desc "remote SUBCOMMAND ...ARGS", "manage set of tracked repositories"
    subcommand "remote", Remote
  end
end

ARGV.clear
ARGV.push "remote", "user", "hello", "a"
Cli::Main.start(ARGV)

PS: I might as well send a PR later in time.

There was a typo in the code. It works as expected. Just awesome.


⚠ Bofrost.be has degraded performance

In dfb4653, Bofrost.be (https://www.bofrost.be) experienced degraded performance:

HTTP code: 200
Response time: 1398 ms

Resolved: Bofrost.be performance has improved in 0f51894.


Listener TLS customization

Description
Some enterprise scenarios require multiple TLS certs to be served by pinot components. The TLS specification (in Java) limits us to a single certificte per entry point, thus necessitating the creation of dedicated listeners per certificate.
This PR adds listener-specific TLS configuration options. It leverages the existing TLS settings as defaults and enables listener specs to override individual properties, including keystore, truststore, etc. The PR also contains a number of smaller enhancements and bug fixes to TLS support in pinot.
The PR further adds a dedicated integration test for TLS scenarios that test the correctness of accepting and rejecting secure connection attempts.
TlsIntegrationTest.java serves as documentation for the use of the added features
Upgrade Notes
Does this PR prevent a zero down-time upgrade? (Assume upgrade order: Controller, Broker, Server, Minion)

[ ] Yes (Please label as backward-incompat, and complete the section below on Release Notes)

Does this PR fix a zero-downtime upgrade introduced earlier?

[ ] Yes (Please label this as backward-incompat, and complete the section below on Release Notes)

Does this PR otherwise need attention when creating release notes? Things to consider:

[X] Yes (Please label this PR as release-notes and complete the section on Release Notes)

Release Notes
Listener specs can now use arbitrary names if they specify a protocol:

controller.access.protocols=internal,https
controller.access.protocols.internal.protocol=http

Listener specs can now override TLS settings on a per-property basis:

controller.tls.keystore.path=./mykeystore.p12
controller.tls.truststore.path=./mytruststore.p12
controller.access.protocols.external.tls.truststore.path=./mycustomtruststore.p12

keystore.path and truststore.path can now point to URLs instead of local files only
Documentation

Codecov Report

Merging #8082 (29e4860) into master (dd73ee7) will decrease coverage by 34.69%.
The diff coverage is 43.42%.

@@              Coverage Diff              @@
##             master    #8082       +/-   ##
=============================================
- Coverage     71.17%   36.48%   -34.70%
+ Complexity     4261       81     -4180
=============================================
  Files          1607     1607
  Lines         83419    83464       +45
  Branches      12460    12461        +1
=============================================
- Hits          59377    30455    -28922
- Misses        19995    50606    +30611
+ Partials       4047     2403     -1644

Flag
Coverage Δ

integration1
29.00% <43.42%> (+0.05%)
:arrow_up:

integration2
?

unittests1
?

unittests2
14.21% <0.00%> (-0.03%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

...org/apache/pinot/core/util/ListenerConfigUtil.java
47.00% <0.00%> (-40.81%)
:arrow_down:

...a/org/apache/pinot/spi/env/PinotConfiguration.java
0.00% <0.00%> (-95.13%)
:arrow_down:

...main/java/org/apache/pinot/core/util/TlsUtils.java
23.52% <60.00%> (-53.50%)
:arrow_down:

...ava/org/apache/pinot/core/transport/TlsConfig.java
97.50% <100.00%> (+1.34%)
:arrow_up:

.../java/org/apache/pinot/spi/utils/BooleanUtils.java
0.00% <0.00%> (-100.00%)
:arrow_down:

...ava/org/apache/pinot/spi/config/table/FSTType.java
0.00% <0.00%> (-100.00%)
:arrow_down:

...ava/org/apache/pinot/spi/data/MetricFieldSpec.java
0.00% <0.00%> (-100.00%)
:arrow_down:

...va/org/apache/pinot/spi/utils/BigDecimalUtils.java
0.00% <0.00%> (-100.00%)
:arrow_down:

...java/org/apache/pinot/common/tier/TierFactory.java
0.00% <0.00%> (-100.00%)
:arrow_down:

...a/org/apache/pinot/spi/config/table/TableType.java
0.00% <0.00%> (-100.00%)
:arrow_down:

... and 960 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dd73ee7...29e4860. Read the comment docs.


1.0.0-RC

[ ] change TARGET_FOLDER: docs/1.x/ in workflows file

HEY! If you change the major version here be sure to update publish-release.yaml doc target folder!

closed via https://github.com/hoc081098/FlowExt/commit/d25df7b54d0c671371fe087945416809a40df66d


loglevel missing

Hi, I'm just testing your generator and I saw, that it lacks one devDependency: loglevel. In order to run it without errors I need to yarn add loglevel --save-dev

It's an issue with webpack-dev-server which gets installed by this generator: https://github.com/webpack/webpack-dev-server/issues/1000
There's already a PR to fix it, no doub it'll be released in a couple hours 😀


python310Packages.auth0-python: 4.6.1 -> 4.7.0

Automatic update generated by nixpkgs-update tools. This update was made based on information from passthru.updateScript.
meta.description for python310Packages.auth0-python is: Auth0 Python SDK
meta.homepage for python310Packages.auth0-python is: https://github.com/auth0/auth0-python
meta.changelog for python310Packages.auth0-python is: https://github.com/auth0/auth0-python/blob/4.7.0/CHANGELOG.md
Updates performed

Ran passthru.UpdateScript

To inspect upstream changes
Impact

Checks done (click to expand)

built on NixOS
The tests defined in passthru.tests, if any, passed
found 4.7.0 with grep in /nix/store/pkkfjih5h5finf4yvv8qsvxyr58ccm9h-python3.10-auth0-python-4.7.0
found 4.7.0 in filename of file in /nix/store/pkkfjih5h5finf4yvv8qsvxyr58ccm9h-python3.10-auth0-python-4.7.0

Rebuild report (if merged into master) (click to expand)

4 total rebuild path(s)

4 package rebuild(s)

First fifty rebuilds by attrpath
python310Packages.aiobiketrax
python310Packages.auth0-python
python311Packages.aiobiketrax
python311Packages.auth0-python

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/pkkfjih5h5finf4yvv8qsvxyr58ccm9h-python3.10-auth0-python-4.7.0 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A python310Packages.auth0-python https://github.com/r-ryantm/nixpkgs/archive/44909a1816cc9ee1b0fa8bdd184b16fc82f76e49.tar.gz

Or:
nix build github:r-ryantm/nixpkgs/44909a1816cc9ee1b0fa8bdd184b16fc82f76e49#python310Packages.auth0-python

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/pkkfjih5h5finf4yvv8qsvxyr58ccm9h-python3.10-auth0-python-4.7.0
ls -la /nix/store/pkkfjih5h5finf4yvv8qsvxyr58ccm9h-python3.10-auth0-python-4.7.0/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

4 packages built:

python310Packages.aiobiketrax
python310Packages.auth0-python
python311Packages.aiobiketrax
python311Packages.auth0-python

Maintainer pings

Result of nixpkgs-review pr 275178 run on x86_64-linux 1

8 packages built:

python310Packages.aiobiketrax
python310Packages.aiobiketrax.dist
python310Packages.auth0-python
python310Packages.auth0-python.dist
python311Packages.aiobiketrax
python311Packages.aiobiketrax.dist
python311Packages.auth0-python
python311Packages.auth0-python.dist


document steps required to update quill.js version

First, thank you for providing this repo, I've found it very helpful.
I noticed that this repo is now slightly out of date (ships 1.2.4 but QuillJS is currently on 1.2.6). I'd be happy to send PRs to periodically update to latest QuillJS if you could document how to do so.

Hey @tylerkovacs, for now, it doesn't look like the Quill team is interested in supporting web components until there is broader production support in browsers - I guess Chrome and Safari are not enough :)
I will try to get this synced up with the latest QuillJS in the near future. Quite frankly, I need to figure out how do that without losing my changes as well - not a Git expert here.
Is there something urgent you needed from the latest patch?

Thanks for the quick reply @chrismbeckett.
No need to rush anything for my benefit. I just started using this repo today and am perfectly happy with  QuillJS 1.2.4 at the moment. I submitted the request since I wanted to avoid a future scenario where I need something from a new QuillJS release but I'm unable to update it myself. I figure the best way to avoid that is to learn how to do it and send the occasional PR.
How complicated are your changes to QuillJS? If they are fairly simple (ie. one or two commits) then you could get away with just cherry-picking those changes on top of a fresh QuillJS release.
If there a many changes, you might want to maintain the commits on a separate branch which could be rebased on top of a fresh QuillJS release.
Either approach would work. Probably the most important thing is to separate commits for the untouched QuillJS release and your changes. That would make it easier for others to see the exaclt changes you've made, making it easier for us to pitch in ourselves.
Anyhow, no rush on my part, but let me know if I can help!

@chrismbeckett @tylerkovacs
let's make a deal. I port the library to Polymer 3 and you try to cherry pick the changes onto the latest version. Sound good?
I really don't understand why the salesforce guys are not supporting webcomponents, it wouldn't even be hard, there's a pull request on its way. I think they're slowly giving in, but nobody has the time to wait half a year for that to move :)
I appreciate your work btw, woulda dropped quill if this hadn't existed <3

I am happy to help with regard to understanding the changes I made and why. Maybe a gist where I pull out the changes and add some explanatory notes. Really, the number of lines I changed is small (< 40). However, on a personal note I no longer require the purpose of this library:

I am no longer using Polymer. With the preview of Polymer 3 I realized the time had come when I no longer needed it. I have moved to NPM, native custom elements, and ES6 string templating. It only took me a couple of days to build my own base class that replaced everything I found useful about Polymer and in fact imho, embraces much better best practices - https://gitlab.com/arsnebula/nebula-element.

Since Polymer v1/2 only supported data binding in Shadow DOM they encourage what I now consider bad practice... everything being in Shadow DOM. With the move to native binding and ES6 string templates I am now rendering much more into Light DOM. This also helps avoid issues with other components that are not written to support Shadow DOM (like Quill)

well this sounds awesome! Unfortunately, I don't have the chance to switch components right now, so for us, that's not an option. I have a huge favor to ask: My git skills are kind of weak and I'm not sure as to how to extract your changes. Could you maybe point me in the right direction? Then I'll gladly figure out most of the changes myself and maybe drop you a line about things I don't understand yet.
Thanks a lot for your work man!

Thankfully you don't need to be a GIT expert to easily review the changes I made - GitHub compare will do it all for you. The actually changes to the Quill library itself are in a seperate arsnebula/quilljs repository (this one was just for publishing as a web component).
You can see the diff of changes here: https://github.com/quilljs/quill/compare/develop...arsnebula:develop
Let me know if that is enough. I can also do a live chat or web conference if you would like a quick walkthrough/explanation of the code changes and why I made them.


[ci] Run hyperdebug tests in CI

Note that this requires to build the hyperdebug bitstream which adds a nontrivial load to the CI now we are building three bitstreams (cw310, hyperdebug, cw340).

Note that this requires to build the hyperdebug bitstream which adds a nontrivial load to the CI now we are building three bitstreams (cw310, hyperdebug, cw340).

If CI resources are scarce, I think we really shouldn't be building CW340 in PRs right now.
I don't claim to know everyone's needs, but for those I am aware of... The first transition we're interested in is CW310+SAM3X --> CW310+Hyperdebug. Then once the hyperdebug variant becomes stable, we could deprecate the SAM3X variant and relegate its test jobs to master-only or nightly-only, if it is still of passing interest. If we're still lacking resources, that deprecation may free some up to rope in CW340 (which is a candidate for another transition later, but not agreed upon).
We're not quite at feature parity just yet, though: The JTAG work for hyperdebug is nearing completion, but it's not yet merged. In addition, we'll want to decide whether to release the designs for the breakout board to all, then incorporate that board into the CW310 hyperdebug variant. The Pmod connectors are currently only partially connected.
As @msfschaffner mentioned recently, the leads will probably need to have a discussion about the roadmap.

FYI: All the hyper310 tests are marked with manual tags, so they won't get picked up by the wildcard yet ;)

The hyperdebug bitstream build does not seem to consistently work. I have re-run the PR three times, the bitstream has failed to build two out of three so far.

The hyperdebug bitstream build does not seem to consistently work. I have re-run the PR three times, the bitstream has failed to build two out of three so far.

I'm not sure why this has started happening only in the past few days or so, but it looks like placement is getting stuck in a rut, challenging Vivado's ability to close hold timing on our relatively poor clock tree.
The particular failures for this run are actually false failures, as Vivado is timing a transition from clk_main to clk_io through a synchronizer. I'll see if I can model this in the XDC, similar to what I did for CW340 (but without the separately-generated frequency, since that would require more precious buffers).

Note that this requires to build the hyperdebug bitstream which adds a nontrivial load to the CI now we are building three bitstreams (cw310, hyperdebug, cw340).

If CI resources are scarce, I think we really shouldn't be building CW340 in PRs right now.

Yes I agree with this ^^

My constraints PR is merged. You can try rebasing, and this may pass more reliably.

It looks like the manual tag was hiding analysis errors due to an incomplete bitstream cache entry. There are a couple paths we can take:

I can bring over code from the other repo to make the cached entry resolve back to the vivado-built one when it's not present. I think I'd implement it a little differently this time, so there doesn't need to be so many changed lines...
We make the FPGA test jobs dependent on all bitstream jobs and build a full cache entry.

@a-will could we solve the problem by changing the way the bitstreams are imported so that it doesn't touch the cache at all if requested? At the moment, we are creating a target for both the vivado build and the cache entry and then selecting, but it would be better to just have one target that's either vivado or an alias to @bitstreams

@a-will could we solve the problem by changing the way the bitstreams are imported so that it doesn't touch the cache at all if requested? At the moment, we are creating a target for both the vivado build and the cache entry and then selecting, but it would be better to just have one target that's either vivado or an alias to @bitstreams

So I'm not sure what you're requesting there. The vivado build and cache entry are necessarily two different targets, as they are built in different ways.
What I did in the other repo was add yet another mux in every user of the @bitstreams external repo. bitstreams_workspace.py would spit out a Starlark file that contained a list of designs available in the cache, and all the references to @bitstreams in our workspace would have to check whether the design existed in the cache and mux back in the Vivado build.
For this round, I'd write the list of required designs in bitstreams_workspace.py, then for designs that are missing in a cache entry, it would slot in BUILD targets that would alias the Vivado-built targets in our workspace. That way, there's no need for a large set of mux entries in the opentitan workspace's BUILD files.

@a-will could we solve the problem by changing the way the bitstreams are imported so that it doesn't touch the cache at all if requested? At the moment, we are creating a target for both the vivado build and the cache entry and then selecting, but it would be better to just have one target that's either vivado or an alias to @bitstreams

So I'm not sure what you're asking there. The vivado build and cache entry are necessarily two different targets, as they are built in different ways.
What I did in the other repo was add yet another mux in every user of the @bitstreams external repo. bitstreams_workspace.py would spit out a Starlark file that contained a list of designs available in the cache, and all the references to @bitstreams in our workspace would have to check whether the design existed in the cache and mux back in the Vivado build.
For this round, I'd write the list of required designs in bitstreams_workspace.py, then for designs that are missing in a cache entry, it would slot in BUILD targets (in the @bitstreams repo) that would alias the Vivado-built targets in our workspace. That way, there's no need for a large set of mux entries in the opentitan workspace's BUILD files.
Edit: Now in #19756

I had something like #19758 in mind. I am not sure if it solves the problem.

I had something like #19758 in mind. I am not sure if it solves the problem.

 We'd still end up with a reference to the missing hyperdebug bitstream that we expected from the cache. That cleanup will be nice, though!


Failed to compile a simple example

download the example of minimal subscriber from ROS2 project, run colcon build, and got below errors:
mi@lubuntu:/home/jason/work/ros_apps$ colcon build --packages-up-to examples_rclcpp_minimal_subscriber
Starting >>> examples_rclcpp_minimal_subscriber
--- stderr: examples_rclcpp_minimal_subscriber
/home/jason/work/ros_apps/src/examples_rclcpp_minimal_subscriber/member_function_with_type_adapter.cpp:19:10: fatal error: rclcpp/type_adapter.hpp: No such file or directory
#include "rclcpp/type_adapter.hpp"
^~~~~~~~~~~~~~~~~~~~~~~~~
compilation terminated.
make[2]: *** [CMakeFiles/subscriber_member_function_with_type_adapter.dir/member_function_with_type_adapter.cpp.o] Error 1
make[1]: *** [CMakeFiles/subscriber_member_function_with_type_adapter.dir/all] Error 2
make[1]: *** Waiting for unfinished jobs....
/home/jason/work/ros_apps/src/examples_rclcpp_minimal_subscriber/member_function_with_unique_network_flow_endpoints.cpp:92:31: error: ‘NetworkFlowEndpoint’ is not a member of ‘rclcpp’
const std::vectorrclcpp::NetworkFlowEndpoint & network_flow_endpoints) const
^~~~~~~~~~~~~~~~~~~
/home/jason/work/ros_apps/src/examples_rclcpp_minimal_subscriber/member_function_with_unique_network_flow_endpoints.cpp:92:31: error: ‘NetworkFlowEndpoint’ is not a member of ‘rclcpp’
/home/jason/work/ros_apps/src/examples_rclcpp_minimal_subscriber/member_function_with_unique_network_flow_endpoints.cpp:92:50: error: template argument 1 is invalid
const std::vectorrclcpp::NetworkFlowEndpoint & network_flow_endpoints) const
^
/home/jason/work/ros_apps/src/examples_rclcpp_minimal_subscriber/member_function_with_unique_network_flow_endpoints.cpp:92:50: error: template argument 2 is invalid
/home/jason/work/ros_apps/src/examples_rclcpp_minimal_subscriber/member_function_with_unique_network_flow_endpoints.cpp: In constructor ‘MinimalSubscriberWithUniqueNetworkFlowEndpoints::MinimalSubscriberWithUniqueNetworkFlowEndpoints()’:
/home/jason/work/ros_apps/src/examples_rclcpp_minimal_subscriber/member_function_with_unique_network_flow_endpoints.cpp:39:17: error: ‘struct rclcpp::SubscriptionOptionsWithAllocator<std::allocator >’ has no member named ‘require_unique_network_flow_endpoints’
options_1.require_unique_network_flow_endpoints =
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/home/jason/work/ros_apps/src/examples_rclcpp_minimal_subscriber/member_function_with_unique_network_flow_endpoints.cpp:40:9: error: ‘RMW_UNIQUE_NETWORK_FLOW_ENDPOINTS_STRICTLY_REQUIRED’ was not declared in this scope
RMW_UNIQUE_NETWORK_FLOW_ENDPOINTS_STRICTLY_REQUIRED;
.......

It seems there is something wrong with the environment configuration of development. Would someone give some suggestion, please~~~?

Hi, @witchoco. It seems the version of ROS 2 that you are using is Rolling Ridley, but what is running on CyberDog is Foxy Fitzroy.  Hince there is no C++ header named rclcpp/type_adapter.hpp. Please check it. Thanks.


YouTube requirement

It should be noted in the Readme that this program downloads files from YouTube, not from Spotify
https://github.com/insaiyancvk/pymusicdl/blob/0fa1a48a82423b687267d18b4d8c011ce0f2007b/requirements.txt#L2-L7

Yes, I'll add that

Updated :)
271c2ba3a1745e253b3d130e1ba0ea8fbab79731


Issue 211

Based on #211
@stojsavljevic , please review.

@yuranos in #211 I stated that this is a feature not a bug :)
So what's the point of this PR?

HI, @stojsavljevic !
I created a PR before I saw your comment:)
Having said that, I think it's an unnecessary limitation. It's more common to use plural notation, but there's more than one way to skin a cat, i.e., a lot of people will argue otherwise.
My suggestion is not breaking anything that was already there, it's just making the decision based on something that is less debatable than naming convention(id in the path).
Do you see any potential problems with my idea?
Please, check for more evidence that the view is not one-sided:
https://stackoverflow.com/questions/6845772/rest-uri-convention-singular-or-plural-name-of-resource-while-creating-it
https://stackoverflow.com/questions/778203/are-there-any-naming-convention-guidelines-for-rest-apis
People have different views on pluralism vs singularity.

@stojsavljevic , time to get back to this one.


Correction request for the quick start documentation "Create an IoT hub using the Azure portal"

Search for the text "Name your hub" on this page. I think it should be "name your route".

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 110959df-1981-b136-7dc7-25ac9bf19ff3
Version Independent ID: 51acc9c3-277d-26b3-ebe1-161dd417a1ed
Content: Use the Azure portal to create an IoT Hub
Content Source: articles/iot-hub/iot-hub-create-through-portal.md
Service: iot-hub
GitHub Login: @robinsh
Microsoft Alias: robinsh

@miraj0072004, Thank you for sharing this out. We are looking into this and will update the doc after review.

@miraj0072004 Thanks for reporting. PR has been created to fix the naming. Changes will go live once it has been peer reviewed and merged.
We will now proceed to close this thread. If there are further questions regarding this matter, please tag me in your reply. We will gladly continue the discussion and we will reopen the issue.


Error is shown instead of Action for Table Type

System information:

Operating system (distribution) and version win 10 x64
DBeaver version 6.2.5

Connection specification:

Database name and version Oracle

Describe the problem you're observing:
Error is shown at Action tab for Table Type

> /* ERROR WHILE READING SOURCE:
>
> class org.jkiss.dbeaver.ext.oracle.model.OracleDataType cannot be cast to class org.jkiss.dbeaver.ext.oracle.model.OracleSchedulerJob (org.jkiss.dbeaver.ext.oracle.model.OracleDataType and org.jkiss.dbeaver.ext.oracle.model.OracleSchedulerJob are in unnamed module of loader org.eclipse.osgi.internal.loader.EquinoxClassLoader @4eff9398)
> */

verified


File selector UI fix

[x] file selector should be moved above contract selector
[x] selector alignment is not correct

Merged in #118


Allow users to share the app with their family and friends

A share button which will allow users to share the app with their friends and family member.

This exists in the settings for simple text share. Did you want more like social media sharing and things like that? Bring it up at sync with Rafah/Vanessa.

@justinklchan : Sorry, just found it, i think it was not noticeable . Can we move it to main tab , next to settings gear maybe ?. Yes while adding I was thinking if they can a share a picture of themselves with our frame. Sure will bring it up in sync up.

What do you mean by "picture of themselves with our frame"?

@justinklchan : For example this

My main idea was getting that share button, which we have. But it needs  to me more visible.
Hmm, it actually depends on the use case, if there is something which can help other will definitely share. But i will not share apps for my own referral benefits, generally that is the mindset . Sorry, but does that make sense?

I think you should bring it up.
This is an interesting idea, but because COVID is a sensitive issue, we should be thoughtful to see if from a PR perspective it would make sense to do this.
I can tell lots of others will have opinions about this.


Rename symbol (F2) on exported element (js file) doesn't rename named import (vue file).

As in title renaming exported function using F2 in vscode applies only in js files but not in vue script setup named imports

To reproduce

Create js file with named export
Import it inside another js file and in vue script setup scope
Use F2 rename symbol in vscode
Name of imported function changes only in js file

You need to use Volar TS plugin or take over mode.

Using volarTs throws me error while using f2. With take over mode auto file renaming doesnt work. There are no other options available?

It is working because its renaming my named imports accross all js files, except vue ones.
Idk how could I provide repro it this case.
vscode - latest version
volar extension - also latest
plain vue project on vite export from 1 js file to other and to vue file then rename with f2

Please modify https://github.com/johnsoncodehk/volar-starter to create necessary files and code for reproduce the problem.

https://github.com/mitow7821/f2problem

try to change test function name with f2

With take over mode:

With TS plugin (this is consistency result with vanilla js, vanilla js can't rename importtest.js before open importtest.js):

What result actually you got?

With TS plugin it works in this particular project but I'd like to use it in vue JS based project .
In this scenario I am getting this error:

@mitow7821 are you using workspace TS version? Have you try use VSCode bundle TS version?

@johnsoncodehk i am using vscode ts version but as I wrote earlier I want to use this in project where i dont have any TS file only JS ones. Shouldn't f2 feature/volar extension work without any typescript?


ESLint config describing prettier's preferences?

In Atom I want to display inline ESLint errors for stuff that will be corrected by prettier-eslint. I expected this config to be a set of ESLint rules describing prettier preferences, not disabling those rules. Am I missing something?

eslint-config-prettier is all about disabling rules. (If you come up with a better name, please tell me!)
I don't know of an eslint config that tries to mimic prettier.