Change isolatedModules to allow const enum declaration and disallow access

Fixes #20703 with solution suggested in https://github.com/Microsoft/TypeScript/issues/20703#issuecomment-361434795
Previously, --isolatedModules gave an error for any ambient const enum, which
meant that some third-party libraries would always give errors even if the
ambient const enums they declare were never used. Now, we only give an error
when an ambient const enum is referenced, which allows such libraries to still
be used as long as the const enums are never accessed.
Some nuances:

As before, the error is only surfaced for ambient const enums. With
non-ambient const enums, we know that an isolatedModules build will emit the
enum and produce a plain reference rather than inlining the constant, so
everything will still work.
I originally planned to do this check in the code path that inlines the
constant, but that code is only exercised at emit time, so, for example, the
TS language service wasn't giving an error in my editor. Instead, I do the
check at typecheck time next to another const-enum-related check.
This can be a breaking change when using skipLibCheck because the error is
typically moved from a .d.ts file to a .ts file.

Testing done:
I ran this TS build on a large project of mine that previously had disabled
isolatedModules so I could use the chalk library. With isolatedModules
enabled, there was no longer an error in the chalk typedefs, and a reference to
the Level const enum produced an error in my editor.

Sorry, we're trying to merge a ton of PRs right now and it looks like there's one in checker.ts now

@RyanCavanaugh Ok, just updated to resolve the conflict!

Thanks!


Cleanup docs and prepare for v3

Codecov Report

Merging #871 into master will not change coverage.
The diff coverage is 100%.

@@            Coverage Diff            @@
##             master     #871   +/-   ##
=========================================
  Coverage     97.98%   97.98%
  Complexity      811      811
=========================================
  Files            98       98
  Lines          2783     2783
  Branches        308      308
=========================================
  Hits           2727     2727
  Misses           27       27
  Partials         29       29

Impacted Files
Coverage Δ
Complexity Δ

...olver/operations/get/PreparedGetListOfObjects.java
100% <ø> (ø)
4 <0> (ø)
:arrow_down:

...tentresolver/operations/get/PreparedGetCursor.java
100% <ø> (ø)
4 <0> (ø)
:arrow_down:

...orio3/sqlite/operations/get/PreparedGetObject.java
100% <ø> (ø)
6 <0> (ø)
:arrow_down:

...storio3/contentresolver/StorIOContentResolver.java
100% <ø> (ø)
5 <0> (ø)
:arrow_down:

...ite/operations/get/PreparedGetNumberOfResults.java
100% <ø> (ø)
5 <0> (ø)
:arrow_down:

...tentresolver/operations/get/PreparedGetObject.java
100% <ø> (ø)
5 <0> (ø)
:arrow_down:

...com/pushtorefresh/storio3/sqlite/StorIOSQLite.java
100% <ø> (ø)
7 <0> (ø)
:arrow_down:

...qlite/operations/get/PreparedGetListOfObjects.java
100% <ø> (ø)
5 <0> (ø)
:arrow_down:

...orio3/sqlite/operations/get/PreparedGetCursor.java
100% <ø> (ø)
5 <0> (ø)
:arrow_down:

...ver/operations/get/PreparedGetNumberOfResults.java
100% <ø> (ø)
4 <0> (ø)
:arrow_down:

... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 268b517...fc3919e. Read the comment docs.


Crash at startup using new chisel 2 builds...

It seems chisel is making some API changes and using some of the newer builds now results in this crash at startup. Just a heads-up. Thanks!
http://pastebin.com/cj6f38vP

Tip, everything you are doing now can be done through the actual API in the newer builds. This should be released soon.
This means you can get rid of those stub classes you are currently using...

Thanks to both of you. I have been anxiously awaiting the new API!

Good to know, let me know (I'm in IRC as well, #Chisel works) if you have any issues with it, it is still somewhat WIP.

@tterrag1098 API seems to work beautifully. I have only one issue so far. See TheCricket/Chisel-2#314
I still have testing ahead, but this makes things a lot smoother.

more new chisel release crashes! \o/
http://pastebin.com/afkKxZBQ

Looks like chisel2 v2.4.0 is coming out of beta so can we look forward to your wonderful api implementation being released?

Thanks for the heads up. I checked last night but must have just missed the release.
Yes. My update has been waiting in the can. I need to update the api, me the everything and then test. I expect to have something within 24 hours.

Fixed in 18701801ad91941430d1f8fac232463d08c73b30
Released in 1.6.0.


Mirror is black when character is close

Right now the mirror distance is based on the camera, so it turns off when the camera is far. However, it should ideally be activated by proximity of the local player to accomadate third person cameras.

It is working fine and I am unable to reproduce it. Can you please retest?
https://user-images.githubusercontent.com/104460803/170251308-43fd83c9-2bb9-434c-a9d7-b3de63e1e8b7.mp4

I have put the camera far away and mirror turns on when the character is near to it. Can you please test it again?
https://user-images.githubusercontent.com/104460803/170251782-e0b5d918-8e73-45a1-bcab-bb07a3dcaa4f.mp4

I'm actually not sure how to feel about this. I feel like if the camera is far away, regardless of where the avatar is, the mirror should be disabled.
This can be improved with a temp mirror that's an env map or texture or something.


Add GQA contrib module

Codecov Report

Merging #155 (fda56b3) into dev (2487fbb) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##              dev     #155   +/-   ##
=======================================
  Coverage   84.46%   84.46%
=======================================
  Files          45       45
  Lines        2825     2825
  Branches      495      495
=======================================
  Hits         2386     2386
  Misses        335      335
  Partials      104      104

Flag
Coverage Δ

unittests
84.46% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2487fbb...fda56b3. Read the comment docs.


cvdupdate doesn't work without DNS

My environment uses a proxy for access to the internet, and internet DNS lookups are not permitted except from the proxy itself.
(When an HTTP/HTTPS proxy is used, the proxy performs the necessary DNS lookups, and the client does not perform any DNS lookups.  So, for most use cases, clients that are behind a proxy don't technically need to be able to perform DNS lookups themselves.)
Looking through the code and history, I see that cvdupdate intentionally doesn't work without DNS, since DNS is being used to reduce the CloudFlare request count: #19
Unfortunately, that makes it incompatible with my environment.
Could an exception be made for environments that do not support DNS?
Could dns.txt be posted on database.clamav.net so that cvdupdate could pull down the version numbers with a single HTTP request (as an alternative way to help reduce the CloudFlare request count when DNS is unavailable)?

It is intentionally coded this way. Cvdupdate is meant to fetch from the cdn and re-serve the files to your internal clients.

Right, I understand that.  But in my environment, cvdupdate needs to run on a server that is behind the proxy and is unable to perform DNS lookups (although it can pull from the CDN via HTTP through the proxy).

Understood.  Sorry. Cvdupdate is expressly designed to work with DNS to prevent an unnecessary http connection.  Reducing load on the http server.
—
Sent from my  iPhone
On Jul 22, 2021, at 19:59, Paul Donohue @.***> wrote:

Right, I understand that. But in my environment, cvdupdate needs to run on a server that is behind the proxy and is unable to perform DNS lookups (although it can pull from the CDN via HTTP through the proxy).
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHubhttps://github.com/Cisco-Talos/cvdupdate/issues/30#issuecomment-885310793, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AAPPBRMGRF5KGOP5RIDCQJDTZCWGNANCNFSM5A27U54A.


pythonPackages.awkward1: 0.2.19 -> 0.2.23

This fixes the build. The 0.2.23 is the last version compatible with
numba 0.49.

Motivation for this change
Fix the build
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[x] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[x] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

@GrahamcOfBorg build python37Packages.awkward1 python38Packages.awkward1

@GrahamcOfBorg build python37Packages.awkward1 python38Packages.awkward1

@GrahamcOfBorg build python37Packages.awkward1 python38Packages.awkward1

@GrahamcOfBorg build python37Packages.awkward1 python38Packages.awkward1


Disabling library has no effect if someone is using a helper.

If I disable the library in config, but I am using helper, then log messages are still logged in console.
Ideal behavior would be to log messages when library is enabled, but don't log and simply skip the messages if library is disabled. This will make moving from development to production very easy.
For example,
PC::debug("Hello!");
Should send log message to console when library is enabled, but should not do anything if its disabled.

@shashankkrjain I don't have so much time to test it with Laravel. Could you please check if now everything works fine? But don't forget to run composer update because this fix depends on new php-console release 3.1.4. Thank you!

Okay, I am checking this. Will get back to you

This works fine. Thanks for the fix :)

That's great! I published release including this fix https://github.com/barbushin/php-console-laravel/releases/tag/5.1
Thanks for report! :+1: