Shell completion

I would like a command that writes a completion script for any supported $SHELL to stdout.
For example, to enable completion for klog commands in Bash, one would source the output of klog completion bash:
echo '. <(klog completion bash)' >>~/.bashrc

If there is interest, I can implement. I think that Cobra automatically generates shell completion.

I had briefly looked into that topic a while ago, but never got around to it. In general, I think that would be a nice feature to have. If you’d be willing to set something up, that would be cool 👍
Only caveat is that the klog CLI currently uses kong as CLI framework, and for now I wouldn’t want to switch away from that. kong doesn’t support completions out of the box, but there is a separate library called kongplete which provides support, and which seems like the “recommended” way to go with kong.

I will try implementing this feature with kongplete and share my progress.

I have a branch with rudimentary implementation of this feature:
https://github.com/chairmank/klog/tree/shell-completion
There is no test coverage :( I have manually tested a few commands, and only with bash shell.
There are no completions for filter options (e.g. --period, --this-***). I would like feedback on my approach before I try to implement these trickier completion generators.

🎉 Awesome, thanks for figuring this out! I’ve tried this on both bash and zsh (macOS), and it seems to work well:

On bash (3.2), it worked out of the box.
On zsh (5.8), there is one caveat, which is that autoload -Uz compinit && compinit needs to be enabled via .zshrc. I suppose, though, that zsh users know that, and it can additionally be mentioned on the docs website.
kongplete doesn’t support Windows (Powershell). That’s alright, though, and maybe someday a keen Windows user could submit a patch for that to kongplete. (Cobra supports Powershell, btw., so maybe the code can be taken over from there.)

The code structure you suggested seems to fit in very nicely. It makes sense to me how the predictors are separated into the cli/lib/ folder. (diff link for convenience.)
Regarding tests: my feeling is that as long as the predictors are as straightforward as the PredictBookmarks one, no unit tests would be needed.
To me, the current functionality would already be useful enough for it to be merged in. Feel free to add more completion predictors as you like, and open a PR at any point.

Thanks for reviewing my change.

kongplete doesn’t support Windows (Powershell). That’s alright, though, and maybe someday a keen Windows user could submit a patch for that to kongplete. (Cobra supports Powershell, btw., so maybe the code can be taken over from there.)

kongplete uses complete, which is specifically for bash completion by design. kongplete supports zsh and fish with thin wrappers around bash completion, so it is unable to leverage other shell-specific completion capabilities. For example, in fish shell, available commands are displayed with helpful descriptions, but kongplete can not implement this behavior because bash does not have an equivalent capability.
There exists a standalone wrapper for bash completions in PowerShell. I have not investigated whether this wrapper could be used by kongplete to add support for PowerShell. Even if it is feasible, it would lack the richness of "native" PowerShell completions.
Cobra has a different design that involves implementing a function for each shell to leverage shell-specific completion capabilities. I think that using Cobra instead of kong would provide superior ergonomics. Of course, I understand that this is a major change and you are not interested in doing it now.
Anyway, this implementation with kongplete adds useful functionality. I will continue working on this branch and open a pull request.

I noticed a difficulty with the --this-*** and --last-*** filter flags. These are dummy flags that are included for brevity in the help output, while the flags for the actual underlying filters (--this-week, --this-month, etc.) are hidden. Unfortunately, kongplete does not automatically generate completions for the hidden flags, and instead only generates completions for the dummy flags.
I have not determined whether I can override this behavior in kongplete. If it not possible to override, what do you think about removing the dummy filter flags and simply exposing the actual filter flags?

Another problem that I noticed is that the complete.PredictFiles function does not expand the user's home directory (~/some/path) or parent directories (../../some/path). This is an unacceptable limitation. I can try writing my own.

kongplete uses complete, which is specifically for bash completion by design. kongplete supports zsh and fish with thin wrappers around bash completion, so it is unable to leverage other shell-specific completion capabilities.

Ah okay, thanks for all that background info, I wasn’t aware of that.
I’m generally not married to kong in any way, I was only reluctant to invest all the work to migrate to Cobra, when kong is working well overall currently. (Well, except for the limited completion capabilities, that is.)

If it not possible to override, what do you think about removing the dummy filter flags and simply exposing the actual filter flags?

What I like about the dummy flags is how they make the help output concise, and also how they resemble the logical pattern of how the flags work.
However, I’ve tried it out again on your branch, and seeing how it completes to --last-*** doesn’t feel acceptable. If it’s not possible (or too complicated) to override or workaround, then I’d think it’s viable to make the help output explicit. I’d suggest then to only expose the dash’ed flags (--last-week) and keep the non-dash’ed ones hidden (--lastweek), since these were only meant as an implicit fallback for convenience.
Filter (shortcuts)
  --today        Records at today’s date
  --yesterday    Records at yesterday’s date
  --tomorrow     Records at tomorrow’s date
  --this-***     Records of the current week/quarter/month/year (e.g. --this-year)
  --last-***     Records of the previous week/quarter/month/year (e.g. --last-month)

vs.
Filter (shortcuts)
  --today           Records at today’s date
  --yesterday       Records at yesterday’s date
  --tomorrow        Records at tomorrow’s date
  --this-week
  --last-week
  --this-month
  --last-month
  --this-quarter
  --last-quarter
  --this-year
  --last-year

Another problem that I noticed is that the complete.PredictFiles function does not expand the user's home directory (~/some/path, ~user/some/path) or parent directories (../../some/path). This is an unacceptable limitation. I can try writing my own.

Ah, bummer. There is this stale PR to add support for ~ in “complete”. I then also noticed that it cannot handle ../.
I agree with you that flawless file path completion would be critical.
Would it possible to fallback to the shell’s default completion for file paths? (E.g. via compgen -o default. Unfortunately, the “complete” library doesn’t seem to support such mechanism natively, though.) My thinking was, why jump through the loops to re-build something that the shell itself would handle perfectly already. Since processing file paths is no core business of klog, I’d be a bit worried that a custom solution could turn into a source of bugs and follow-up issues down the line.

Would it possible to fallback to the shell’s default completion for file paths? (E.g. via compgen -o default. Unfortunately, the “complete” library https://github.com/posener/complete/issues/131, though.) My thinking was, why jump through the loops to re-build something that the shell itself would handle perfectly already. Since processing file paths is no core business of klog, I’d be a bit worried that a custom solution could turn into a source of bugs and follow-up issues down the line.

I verified that defining the completion specification in bash as
complete -o default -C /path/to/klog klog

enables default shell expansions for file paths. It would be easy to change the kongplete.InstallCompletions Kong command to define the completion specification in this way. I assume (but have not verified) that similar solutions exist for zsh and fish. If I verify that it works, I will create an issue in kongplete and a pull request with a simple change to the kongplete.installCompletion private function.

I assume (but have not verified) that similar solutions exist for zsh and fish. If I verify that it works, I will create an issue in kongplete and a pull request with a simple change to the kongplete.installCompletion private function.

Oh terrific, that sounds like a good solution!
I have confirmed on zsh that your fix works! (complete -o default -C /path/to/klog klog)

Too bad that the kongplete maintainers don’t respond in the issue that you opened. Do you happen to know how complicated it is to fix the kongplete code? Because I think I would just fork the kongplete project and switch the dependency to my fork, in order to move forward with this issue.

Quick update: I created a fork of kongplete and added a patch for the problem based on your suggestion. With that, it seems to work smoothly. I haven’t looked into fish shell yet, though.
The fork can be dropped in relatively easily via the replace directive.
I’ll try to do some more testing throughout the next weeks. It might be nice to file a PR with kongplete (once fish is fixed and tested), but it’s good to know that we would be able to move forward independently from what kongplete.

Thanks for the update! I am sorry that I have not done anything on this issue recently.
What do you think about reimplementing the command-line interface with Cobra? I understand that forking kongplete is easier and a more immediate solution, but Cobra is already maintained and has more features than kongplete. Would you accept a switch to Cobra if it preserves the current behavior of the CLI? If you are okay with the idea, I will explore it and report what I learn.

Oh, don’t worry! You helped tremendously by figuring out all the groundwork, so thanks heaps for that. As far as I see, the remaining todos are:

[ ] Test fish shell and (if need be) fix the file path issue (in the fork: https://github.com/jotaen/kongplete)
[ ] Take care of the magic --this-*** flags

Either by adding a custom predictor, or if that doesn’t work, by abandoning the --this-*** pseudo flag and just enumerate all shortcut flags in the help output

I don’t mean to take this away from you, so let me know if you want to keep working on it. I’m otherwise also happy to collaborate, or take over, depending on your capacity. There is also no rush with this. (Though I have to say the completions are a really cool usability improvement – I’ve started to use them locally now.)
Regarding Cobra, I’ve opened a discussion here, so that we have a dedicated place to discuss: https://github.com/jotaen/klog/discussions/205.

Thanks!
I recently started using fish shell and can test the file path issue with your fork. I will do this soon, within a week.
I am also interested in implementing completion for the various --this-*** flags, but it is somewhat complicated to do so while keeping the abbreviated help output. If you or someone else has time to work on it now, please proceed.
Thanks for opening the discussion of Cobra. I don't have time to pursue it right now, but I will be sure to report any progress that I make in the discussion.

I also played around with fish this weekend, just because I was curious and wanted to check it out in general. While on it, I was able to confirm that the generated completions code seems to work fine 🎉

So I think it’s all good to go now: https://github.com/jotaen/klog/pull/209

I looked at the changes in https://github.com/jotaen/klog/pull/209 and everything looks good to me. Thanks for implementing this feature!


Prep: User Story

This issue will be updated with the user story for wild thorn apothecary.

User Story
As the owner of an apothecary, I want my customers to have an application where they can plan what to buy for when they come into my store.
Acceptance Criteria
Given a web application, when I sign in, then I am able to create a garden of plants.
Given a page for my garden, when I search for plants, then I am able to add plants to my garden.


[Bug]: build problems using puppert-core in extensions

Minimal, reproducible example
vite build

Error string
PassThrough" is not exported by "__vite-browser-external”
Bug behavior

[ ] Flaky
[ ] PDF

Background
Currently i'm building the extension app with vite using pptr-core, and stucked in some modules whether using the example rollup config or not(since node-resolve is already a default vite built-in ). Though i can add externals to rollupOptions to skip these problems in building phase ,i'm not sure these api will works fine without some sort of node polyfills
Expectation
maybe a better bundle example or some compatible browser api replacement?
Reality

currently the build process works fine after adding these externals

Puppeteer configuration file (if used)
No response
Puppeteer version
22.12.1
Node version
18.17.0
Package manager
yarn
Package manager version
3.6.1
Operating system
Windows

Have you tried this example https://github.com/puppeteer/puppeteer/tree/main/examples/puppeteer-in-browser? It’s also important to import the browser-specific entrypoint like in the example and not the main puppeteer-core entrypoint.

I get your point , but in my case i use connect api in my chrome extension with transport options just like the extension demo instead of the examples which using endpoint. Does this affect build phase?

There is an example specifically for extension: https://github.com/puppeteer/puppeteer/tree/main/examples/puppeteer-in-extension. The rollup config https://github.com/puppeteer/puppeteer/blob/main/examples/puppeteer-in-extension/rollup.config.mjs
It builds for me with the following log:
❯ npm run build

><EMAIL_ADDRESS>build
> rollup -c && cp manifest.json out/

background.js → out...
(!) "this" has been rewritten to "undefined"
https://rollupjs.org/troubleshooting/#error-this-is-undefined
../../packages/puppeteer-core/lib/esm/puppeteer/common/HandleIterator.js
4:  * SPDX-License-Identifier: Apache-2.0
5:  */
6: var __addDisposableResource = (this && this.__addDisposableResource) || function (env, value, async) {
                                  ^
7:     if (value !== null && value !== void 0) {
8:         if (typeof value !== "object" && typeof value !== "function") throw new TypeError("Object expected.");
...and 3 other occurrences
../../packages/puppeteer-core/lib/esm/puppeteer/common/QueryHandler.js
4:  * SPDX-License-Identifier: Apache-2.0
5:  */
6: var __addDisposableResource = (this && this.__addDisposableResource) || function (env, value, async) {
                                  ^
7:     if (value !== null && value !== void 0) {
8:         if (typeof value !== "object" && typeof value !== "function") throw new TypeError("Object expected.");
...and 3 other occurrences
../../packages/puppeteer-core/lib/esm/puppeteer/cdp/ElementHandle.js
4:  * SPDX-License-Identifier: Apache-2.0
5:  */
6: var __runInitializers = (this && this.__runInitializers) || function (thisArg, initializers, value) {
                            ^
7:     var useValue = arguments.length > 2;
8:     for (var i = 0; i < initializers.length; i++) {
...and 3 other occurrences

...and 28 other files
created out in 493ms

I think those warnings are not causing any issues.

@elineeen could you perhaps create a demo project on GitHub with your configuration and the bundler so that we could try it out?

@OrKoN sure, i've created a demo project  ,try it with node v18.17.0

So it looks like vite does not allow restricting the module resolution to the provided list (our example only allows 'puppeteer-core' and not other modules). In general, externalizing those dependencies should be alright since they are for Node only and only loaded dynamically if Puppeteer runs in Node. Is there a way to configure Vite to not resolve and bundle dynamically imported modules?

I think we could improve on Puppeteer side to not require so much customization.

This is now addressed. There is only one warning left:
[plugin:vite:resolve] [plugin vite:resolve] Module "crypto" has been externalized for browser compatibility, imported by "/Users/alex/projects/pptr-test/pptr-ext-demo/node_modules/chromium-bidi/lib/cjs/utils/uuid.js". See https://vitejs.dev/guide/troubleshooting.html#module-externalized-for-browser-compatibility for more details.

but that is fine since this is optional if the browser support is not detected. Unfortunately, build tools are not able to detect that.


Python 3.12+ specific syntax is used

With python 3.11 and older any import from fluentogram==1.1.8 raises the following error:
  File "/home/skald/src/schedule/.venv/lib/python3.11/site-packages/fluentogram/src/impl/storages/__init__.py", line 1, in <module>
    from .nats_storage import NatsStorage
  File "/home/skald/src/schedule/.venv/lib/python3.11/site-packages/fluentogram/src/impl/storages/nats_storage.py", line 99
    subject = f'${stream_name.replace('_', self.separator, 1)}.>'

The reason is usage of single quotes inside of single-quoted f-string, what is 3.12+ feature. PyPi marks shows that 3.9 should be supported, so I believe this is a bug.

Check 1.1.9 release

1.1.9 works for me with python 3.11, but still there are some patches required for 3.9 (I've used docker run python:3.9-slim):
import typing
import typing_extensions
typing.Self = typing_extensions.Self
typing.TypeAlias = typing_extensions.TypeAlias

import fluentogram
...  # other code

There weren't any troubles with simple examples after this hack in this container.

https://github.com/Arustinal/fluentogram/pull/28

Merged


incorporate the dlb, ci and pd icd codes yaml

Hi @KaurMahima , I used the icd codes you put together to run get_outcomes for 2017, and 2018, so everything is looking good. I just can't use github from your folder.
Don't forget to push the updated icd_codes_7.yaml file!


Can´t Activate Lens

Describe the bug
Hi, I can´t activate Lens personal edition.
To Reproduce
Steps to reproduce the behavior:

Open Lens
Choose activation method: Lens ID
Clic Activate Button
A window opens in the navigator that points to localhost and after a few secconds I get a "ERR_SSL_PROTOCOL_ERROR" whle the Lens app waits for an activation.

Expected behavior
Lens been successfully activated.
Screenshots

Localhost resolution:

Environment (please complete the following information):

Lens Version:

OS: Windows 10 x64

Installation method (e.g. snap or AppImage in Linux): Installer downloaded from the site.

Logs:
When you run the application executable from command line you will see some logging output. Please paste them here:
Your logs go here...
![image](https://github.com/lensapp/lens/assets/102118305/0b56d183-1661-411f-8334-a7563d89e416)

I don't get any logs when running from command line.

Kubeconfig:
Quite often the problems are caused by malformed kubeconfig which the application tries to load. Please share your kubeconfig, remember to remove any secret and sensitive information.
your kubeconfig here

Additional context
Add any other context about the problem here.

Any update or something ?

Hi, I was able to activate lens through pro trial option.
It was the only way I could use Lens and overcome the issue.
Best regards

Same issue with activation on Ubuntu 20.04 via Chrome.
Successfully activated Lens Personal with Firefox.


Special Characters

There are a few mods out there that use [ ] and the  + sign.  Is it possible to get these added as well?  I am not sure if it's just as easy to go with the number of the mod instead and trying to use the name.  We used ping perfect in the passed and they used numbers instead of the name, considering there is no naming standard.

Can you share a link to one of these mods? Symlinks with these characters shouldn't cause any issues as these are all allowed and supported characters on any filesystem.
The reason why I went with mod names instead of mod IDs is that the official launcher is using mod names as well (or at least has been using - not sure if this has changed). Using IDs makes it rather difficult for humans if you want to know which mods are currently installed and which are not. Mod names don't have this problem.
The only special character which gets replaced is currently ' due to a limitation of Steam's game launch parameters, which doesn't properly escape the inputs.
https://github.com/bastimeyer/dayz-linux-cli-launcher/blob/0.1.2/dayz-launcher.sh#L232

Ok, looks like Steam's launcher script which handles the game parameters doesn't work correctly:
+ steam -applaunch 221100 '-mod=@[Remastered] Arma Weapon Pack'
/media/storage/SteamHome/.local/share/Steam/steam.sh: line 574: no match: -mod=@[Remastered]

So there are three solutions which come to my mind

Use mod IDs instead of mod names
Replace any non-alphanumerical characters
Do both of the above: ${id}-${name}

3 seems to be the best solution, in case there are mod name collisions. I'll have a look a this later.

Take your time!  I just dropped you an email.  Thank you again!!!

Fixed by 4feae2ca32421252ad68680e6555fb307a5b236c
https://github.com/bastimeyer/dayz-linux-cli-launcher/blob/0.2.0/CHANGELOG.md

I just dropped you an email

Thanks. No need to give me your server address, should be working fine now, regardless of the names of the mods being used.
Also thanks for trying to resolve the server API issues. I've already commented on this (I believe on reddit), and ideally I wouldn't have to use a third party JSON API for querying server IPs, but that's a bit difficult to achieve via BASH. If I had chosen Python for example, this would've been quite simple, but writing the launcher in BASH was the quickest solition. Python would've also allowed for creating a simple GUI on top of the CLI. Maybe that's a project for another day.


chore: add Missy Turco and Akshat Nema as codeowners

Description
As in title: add Missy Turco and Akshat Nema as codeowners.
These two people have contributed a lot to the development of this project and I think they should be codeowners of this repository. Anyone against this?
cc @derberg @fmvilas @alequetzalli @mcturco @akshatnema

@mcturco isn't a codeowner yet?!?

👏🏼
agree 100% !!!

@fmvilas Only you left :)

/rtm

@akshatnema according to the official charter document that defined open governance model at AsyncAPI Initiative, now you have also the right to be part of the Technical Steering Community.
Technically, you need to open a PR to get your name in this file https://github.com/asyncapi/community/blob/master/TSC_MEMBERS.json (when you decide to do it, please, with the same PR update info about @mcturco that she is also a maintainer to additional repo).
TSC membership is optional. Some maintainers decided to stay focused on their repositories only.
As a TSC member, you commit to helping decide on things that are done across the whole AsyncAPI Initiative, and not just one repo.


Failure with incomplete SSL chain

If a server has not been correctly configured to provide the full certificate chain for SSL, then the JCR backend will fail to connect with the error message "unable to verify the first certificate."

After investigation, it was noted that the problem can be resolved by setting the strictSSL option to false when making HTTP requests. Submitting a pull request to add a configurable option that will allow setting the value.


remote_billing: Make "plan management" always available.

Just shows a config error page if the bouncer is not enabled. Uses a new endpoint for this so that it can work nicely for both browser and desktop app clients.
It's necessary, because the desktop app expects to get a json response with either an error or billing_access_url to redirect to. Showing a nice config error page can't be done via the json error mechanism, so instead we just serve a redirect to the new error page, which the app will open in the browser in a new window or tab.

I think https://github.com/zulip/zulip/pull/29113#discussion_r1506937516 is the only blocker for this PR; we can remove the illustration from config_error in a follow-up PR just as well, if that's not ready yet.

@timabbott Pushed a commit changing the look of the config pages, with the Configuration error header centered and limiting the width of the white-box, so that text doesn't spill too far.

Also, just flagging https://github.com/zulip/zulip/pull/29113#discussion_r1510416074 for the permissions check discussion

This looks great, marked to merge once CI passes, thanks @mateuszmandera!
@alya it could be worth doing an additional look at the text in the last commit, and the /help/ page it links to.

No changes to make right now. This commit was just fixing a regression.

Backported in https://github.com/zulip/zulip/pull/29232.


conjure-tor: init at 0-unstable-2024-11-11

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

There's a name conflict with another package. I renamed this to conjure-tor. If you have any suggestions for the name let me know.

How about updateScript? (it is applied automatically to all python packages, but not go)

How about updateScript? (it is applied automatically to all python packages, but not go)

What should I set it to? Is passthru.updateScript = nix-update-script { }; enough?

How about updateScript? (it is applied automatically to all python packages, but not go)

What should I set it to? Is passthru.updateScript = nix-update-script { }; enough?

Yes

nixpkgs-review result
Generated using nixpkgs-review.
Command: nixpkgs-review pr 367417

x86_64-linux

:white_check_mark: 1 package built:

conjure-tor

aarch64-linux

:white_check_mark: 1 package built:

conjure-tor

x86_64-darwin

:white_check_mark: 1 package built:

conjure-tor

aarch64-darwin

:white_check_mark: 1 package built:

conjure-tor

Hi @wegank
Is there anything needed for this PR?

nixpkgs-review result
Generated using nixpkgs-review.
Command: nixpkgs-review pr 367417

x86_64-linux

:white_check_mark: 1 package built:

conjure-tor

aarch64-linux

:white_check_mark: 1 package built:

conjure-tor

x86_64-darwin

:white_check_mark: 1 package built:

conjure-tor

aarch64-darwin

:white_check_mark: 1 package built:

conjure-tor


Update clang format

Which issues of this PR fixes:

This PR try to fix #43
Change log:

What's wrong with the previous clang format?

What's wrong with the previous clang format?

After format, code style tool may report some errors.

I think the previous format is fine. Doesn't need to be adjusted.

I believe that clang-format is merely an auxiliary coding tool rather than the entire solution. When certain coding styles conflict with our established code conventions, we should prioritize our code conventions over complete reliance on it.

@nicelulu Auto code format tool is necessary for many developers are accustomed to using it. There will be more developers joining the project in the future. So we must make it ready.

@nicelulu Auto code format tool is necessary for many developers are accustomed to using it. There will be more developers joining the project in the future. So we must make it ready.

It is necessary. It's just an aid. When there are one or two areas that conflict with our coding habits, we should focus on our original coding style.


ops files for valid x-frame-options settings

These mutually-exclusive ops files configure x-frame-options to help
prevent clickjacking attacks.

neat, thanks!


Keystone auth provision

thanks for your review. This patch updates the following:
(1) changes Keystone installation from apt-get to git clone
(2) changes Keystone database from MySQL to sqlite
but I didn't confirm the behavior with old version of Ubuntu.

I tried this out and it works for me. Probably the easiest way to get Keystone working that I've seen.


bitwarden-menu: adopt, 0.4.1 -> 0.4.3

Description of changes
https://github.com/firecat53/bitwarden-menu/releases/tag/v0.4.2
I would like to adopt the package :)

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[x] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/prs-ready-for-review/3032/4011

Result of nixpkgs-review pr 315811 run on x86_64-linux 1

2 packages built:

bitwarden-menu
bitwarden-menu.dist

thanks for taking care & welcome on board :)

Thanks!


[winui3]How to get parent HWND of TextBox in WinUI3? How to use ImmAssociateContext in WinUI3?

I am using winui3 in cpp.
I want to disable IME(Input Method) when using TextBox.
One way I know is using
 ImmAssociateContext(hwnd, NULL);

The problem is thar how I get parent HWND of  TextBox?
or is there another way to disable IME?

There is only one HWND (3 with the window for XAML rendering and the window for the Caption),
which is, from MainWindow, hWnd = WinRT.Interop.WindowNative.GetWindowHandle(this);
But ImmAssociateContext does not work for me (Windows 10 21H1)
(same thing with ImmDisableIME or ImmDisableLegacyIME, which work before main window creation in C++/win32)

There is only one HWND (3 with the window for XAML rendering and the window for the Caption), which is, from MainWindow, hWnd = WinRT.Interop.WindowNative.GetWindowHandle(this); But ImmAssociateContext does not work for me (Windows 10 21H1) (same thing with ImmDisableIME or ImmDisableLegacyIME, which work before main window creation in C++/Win32)

Thanks for your reply.
In my cognition, IME must be attached to a window to display, so that function 'ImmAssociateContext(hwnd, NULL);' should be able to disable it.Unless the HWND does not match.
I also tried calling the VisualTreeHelper::GetParent(TextBOX()); method in a loop to get the parent window of the TextBox, but the result is empty in the first loop.
I noticed that PassWordBox doesn't pop up the IME, can I see how PassWordBox does it? Is his implementation open source and Where can I find his code?

There is only one HWND (3 with the window for XAML rendering and the window for the Caption), which is, from MainWindow, hWnd = WinRT.Interop.WindowNative.GetWindowHandle(this); But ImmAssociateContext does not work for me (Windows 10 21H1) (same thing with ImmDisableIME or ImmDisableLegacyIME, which work before main window creation in C++/Win32)

Thanks for your reply. In my cognition, IME must be attached to a window to display, so that function 'ImmAssociateContext(hwnd, NULL);' should be able to disable it.Unless the HWND does not match. I also tried calling the VisualTreeHelper::GetParent(TextBOX()); method in a loop to get the parent window of the TextBox, but the result is empty in the first loop. I noticed that PassWordBox doesn't pop up the IME, can I see how PassWordBox does it? Is his implementation open source and Where can I find his code?

No, it's not open source yet. The UI library itself have full access to the control implementation. So they can achieve it in any way. But you're not. Probably this should be a feature request that TextBox provides a property like IMEEnabled (or external TextService.IMEEnabled? I don't know).

I posted an answer on MS forums with ShowReadingWindow  but you did not read it...

Thanks for [castorix],I have resolved this problem by using ITfThreadMgr::Deactivate.
If anyone else needs help, you can check out：https://docs.microsoft.com/en-us/answers/questions/900827/winui3-how-to-disable-input-methods-when-using-tex.html


[SPARK-49752][YARN] Remove workaround for YARN-3350

What changes were proposed in this pull request?

Remove the logic of forcibly setting the log level to WARN for org.apache.hadoop.yarn.util.RackResolver.
Why are the changes needed?

The removed code was introduced in SPARK-5393 as a workaround for YARN-3350, which is already fixed on the YARN 2.8.0/3.0.0.
Does this PR introduce any user-facing change?

Yes, previously, the log level of RackResolver is hardcoded as WARN even if the user explicitly sets it to DEBUG.
How was this patch tested?

Review.
Was this patch authored or co-authored using generative AI tooling?

No.

Merged to master.


Library Gradle Sync issue

[ ] I have verified there are no duplicate active or recent bugs, questions, or requests
[ ] I have verified that I am using the latest version of Easy Video Player.
[ ] I have given my issue a non-generic title.
[ ] I have read over the documentation (before asking questions on how to do something).

Include the following:

Easy Video Player version: x.x.x.x
Device OS version: 7.0
Device Manufacturer: Huawei
Device Name: Nexus 6P

Also, please wrap Java with correct syntax highlighting.
System.out.println("Hello, world!");

Reproduction Steps

Expected Result
Actual Result

You need to add in your project's build.gradle. Should look like this -
allprojects {     repositories {         jcenter()         maven { url "https://dl.bintray.com/drummer-aidan/maven" }     } }

I did the same but issue is still remain
Thanks & Regards
Lalit Goswami
Associate Software Engineer
RationalHeads Technologies Pvt. Ltd.
---- On Tue, 13 Sep 2016 04:51:42 +0530<EMAIL_ADDRESS>wrote ----
You need to add in your project's build.gradle. Should look like this -
allprojects {
repositories {
jcenter()
maven { url "https://dl.bintray.com/drummer-aidan/maven" }
}
}
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.

I compile 'com.afollestad:easyvideoplayer:0.2.12' is failed；

Duplicate.


feat: end-to-end modexp, ecadd, ecmul and ecpairing

What?
Implementation of  modexp, ecadd, ecmul and ecpairing precompiles as circuits.
Previous PR
Basically all changes are made to boojum crate's gadgets. Previous PR for deprecated repository which has been reviewed:
era-boojum
Homogeneity with previous PR
Code has certain changes apart from contained in previous PR such as caused by rebasing and noticing missed problems.

Hey there, @Fitznik !
I've marked as resolved all undisputable issues, which I resolved in code, there are left a few ones which I need your agreement/clarification


Stepper: Design component in Figma

Thank you for contributing to the design of the Stepper component @olavflar 🎉🏅


[FEATURE REQUEST] Add Folder Size Monitoring to DiskObserver

Enable specifying folder paths to monitor for size in DiskObserver (with support for specifying folder/file search patterns). Configure FO to warn (in SFX and via telemetry) when some specified folder exceeds a given max size. This will put the related node into Warning (which is what DiskObserver does for total disk space usage today) with all related details in the health event/ and etw/telemetry event. This will require adding new configuration for DiskObserver to be supplied as overridable application parameters.
This feature can be enabled or disabled via setting.

This is now in develop branch.

This feature will ship in the next version of FO, 3.1.24, most likely this week. Here is an example of how to configure DiskObserver to monitor folders for size and warn when supplied threshold for max size is reached or exceeded. In ApplicationManifest.xml:
    <!-- Folder size monitoring. Supply full path/threshold(in MB) pairs here. Format is "fullpath0, size0 | fullpath1, size1 | fullpath2, size2 ..." -->
    <Parameter Name="DiskObserverFolderSizePathsErrorThresholdsMb" DefaultValue="" />
    <Parameter Name="DiskObserverFolderSizePathsWarningThresholdsMb" DefaultValue="E:\SvcFab\Log\Traces, 3000 | C:\MyLogs, 1000" />

Here is example output in SFX (will also be sent via telemetry and ETW):

As always (99% of the time, anyway), this feature is cross-platform. For linux deployments, obviously you would supply linux folder paths (no drive, "/" instead of "\" for directory hierarchy separator...). Since these settings are Application Parameters, you can do versionless parameter-only application upgrades of FO to change the values without having to redeploy FO.

This is now shipped.


Make bot suitable for multiple servers

[x] Change to database for storing guild-related settings
[x] Make bot settings customizable via commands
[x] Fix new bugs due to implemented features

[x] Wrong behavior / missing functionality when joining a new server

[x] Make sure the command permissions can be updated (send authorize URL to executor of /permit command if required)
[ ] Test if everything works as intended

Closes #27
[x] Will have to close #56 because the URL sending needs to be detached from starting the express server

Currently known bug: When live / roles channel exists before the bot joins, it doesn't do anything with them

Edge case: If a user types /permit add <user>, then ignores the info message that authentication is needed and then /permit add <user> is executed again (either by the user themselves or by another user), the commands do not get reloaded (as in: the changes are not applied immediately)

Refresh tokens sometimes do not get stored and the whole permission system doesn't seem to work as the restricted commands don't get any custom roles that are permitted to execute them


Allow action update without a code artifact.

Description
Allows action update without a code artifact.
To address a number of subtleties in the implementation between action create/get and the gap relative to the Apache OpenWhisk CLI (wsk), this patch consolidates the implementation of action create and update so that they are interchangeable.
Summary of changes:
1. action kind determined from file extension
2. disallow action artifact and --sequence
3. dissallow --main on sequence
4. allow update to omit all parameters
5. allow an update to parameters and annotations without replacing code
I have added a number of new tests to cover the changes herein as well.
This PR includes a small patch needed from #69.

Related Issue
Closes #70.

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):
Types of changes

[x] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[x] I have signed the Adobe Open Source CLA.
[x] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[x] I have read the CONTRIBUTING document.
[x] I have added tests to cover my changes.
[x] All new and existing tests passed.

I’m happy to remove the file extension/kind mapping other than node but the change is sound in that a user can specify a kind explicitly with —kind and name a runtime that’s isn’t supported by the server anyway and the server will reject it.

If there is no side-effect, then I am okay with leaving it in.
I see there is no change to the output to the user, my main concern was that I didn't want to imply that we supported some options that would just always be rejected.


NoOp watermark support

use NoOp watermark progressor and avoid nil checks in forwarder.

this is not done, we have nil check in forwarder.

we need to fix sources, they are still passing nil

@vigith - I'll pick this up and check the what's the issue

@kohlisid - I think we are good, we don't need to get rid of those nils particularly, as we implementing WM for all the sources, they will be gone.


several improvements

it can tell if an element is visible to user, by display and visibility styles
fixed rollup error
ignored .idea for webstorm users
renamed scroll-handler to event-handler, which process events and tell if an element is on screen
added debounce toobserveDOM, which takes the same throttle from options
added test cases for is-visible

Please help with the build failure...
I ran npm test locally, it passed.

They most likely are linting isues. I'll take a look.

Current coverage is 90.68% (diff: 90.00%)

No coverage report found for master at 59ad3a7.

Powered by Codecov. Last update 59ad3a7...ddb2146

done by impression.js

some test cases failed because other test cases is running, which have affected the running cases


should togglechange events fire in additional cases?

Right now togglechange events fire only when the fire a toggle activation steps run, which basically means that they only run when toggles change as a result of activation, and only fire on the toggle that was activated.
This means there are some additional cases where toggles change but the event does not fire:

when one toggle changes as a result of activation, and other toggles in its group are set to zero, togglechange does not fire on the toggles that are set to zero,
when a toggle changes as a result of CSSToggle API usage (setting value, valueAsNumber, or valueAsString), and
When other toggles in a toggle group are set to zero as a result of CSSToggle API usage on a different toggle.

I suspect it's desirable to fire togglechange events for at least (1), probably also (3), and perhaps also (2) as well.

Hm, the other toggles in a group being reset should definitely fire.
Unsure about modifying via manual API fiddling, tho. I didn't think we normally did that? I could be wrong, tho.


Update codelabs to webpack 4

This is, in particular, to avoid the security vulnerabilities reported by npm audit. (Once you hit mdc-102, you get 15+ vulnerabilities, including one critical.)
cc @kwalrath

There are even more security vulnerabilities now, new year new vulns. I think its high time to update it to webpack 4.0.0

I've made some changes locally to both package files as well as to the webpack config for MDC 101-103 that update several packages without breaking anything in the tutorial when run (although there's a new one as of yesterday that I now have to address). I haven't contributed a pull request to an open project before so I just want to make sure I do it properly. Would it be better to submit a separate PR for each codelab, or do them all at once? Also, is it OK to make changes to the master branch of my fork, or is it better practice create a dev branch and make the changes there?


ALVR compilation error: FreePIE.Core.Contracts couldn't be resolved

1>------ Build started: Project: ALVRFreePIE, Configuration: Debug Any CPU ------
1>C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\MSBuild\15.0\Bin\Microsoft.Common.CurrentVersion.targets(2110,5): warning MSB3245: Could not resolve this reference. Could not locate the assembly "FreePIE.Core.Contracts". Check to make sure the assembly exists on disk. If this reference is required by your code, you may get compilation errors.
1>D:\sw\Temp\alvr\ALVR\ALVRFreePIE\ALVRFreePIEPlugin.cs(1,7,1,14): error CS0246: The type or namespace name 'FreePIE' could not be found (are you missing a using directive or an assembly reference?)
1>D:\sw\Temp\alvr\ALVR\ALVRFreePIE\ALVRFreePIEPlugin.cs(12,38,12,45): error CS0246: The type or namespace name 'IPlugin' could not be found (are you missing a using directive or an assembly reference?)
1>D:\sw\Temp\alvr\ALVR\ALVRFreePIE\ALVRFreePIEPlugin.cs(239,6,239,12): error CS0246: The type or namespace name 'GlobalAttribute' could not be found (are you missing a using directive or an assembly reference?)
1>D:\sw\Temp\alvr\ALVR\ALVRFreePIE\ALVRFreePIEPlugin.cs(239,6,239,12): error CS0246: The type or namespace name 'Global' could not be found (are you missing a using directive or an assembly reference?)
1>D:\sw\Temp\alvr\ALVR\ALVRFreePIE\ALVRFreePIEPlugin.cs(239,13,239,17): error CS0246: The type or namespace name 'Name' could not be found (are you missing a using directive or an assembly reference?)
1>D:\sw\Temp\alvr\ALVR\ALVRFreePIE\ALVRFreePIEPlugin.cs(11,6,11,16): error CS0246: The type or namespace name 'GlobalTypeAttribute' could not be found (are you missing a using directive or an assembly reference?)
1>D:\sw\Temp\alvr\ALVR\ALVRFreePIE\ALVRFreePIEPlugin.cs(11,6,11,16): error CS0246: The type or namespace name 'GlobalType' could not be found (are you missing a using directive or an assembly reference?)
1>D:\sw\Temp\alvr\ALVR\ALVRFreePIE\ALVRFreePIEPlugin.cs(11,17,11,21): error CS0246: The type or namespace name 'Type' could not be found (are you missing a using directive or an assembly reference?)
1>D:\sw\Temp\alvr\ALVR\ALVRFreePIE\ALVRFreePIEPlugin.cs(36,44,36,59): error CS0246: The type or namespace name 'IPluginProperty' could not be found (are you missing a using directive or an assembly reference?)
========== Build: 0 succeeded, 1 failed, 0 up-to-date, 0 skipped ==========

Make sure you have FreePIE.Core.Contracts.dll in ALVRFreePIE\bin\Debug and ALVRFreePIE\bin\Release.

I am unable to find the FreePie.Core.Contracts.dll file, even within the FreePIE & ALVR github repositories. Is there a direct link where I can find this file?

You need to download msi installer here:
https://github.com/AndersMalmgren/FreePIE/releases
Then you can find FreePie.Core.Contracts.dll in the installed directory.

周鹏 Zhou Peng

From: EJ Mann
Date: 2019-05-02 00:26
To: polygraphene/ALVR
CC: peng; Comment
Subject: Re: [polygraphene/ALVR] ALVR compilation error: FreePIE.Core.Contracts couldn't be resolved (#227)
I am unable to find the FreePie.Core.Contracts.dll file, even within the FreePIE & ALVR github repositories. Is there a direct link where I can find this file?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or mute the thread.


[Feature Request] Provide ScrollbarShow, ScrollbarHide commands or similar

It would be great to add commands to enable/disable the scrollbar on demand. This could be named show/hide or enable/disable or even just toggle.
This might also solve #7 as people can then just create autocommands to enable/disable the scrollbar.

Done, I probably should separate commands to toggle/show/hide the handle, specific marks, and specific handlers


[WIP/DNM] Closes #75 #88 #110

#75

Removes previous implementation which set client_id to foci-<family_id> when RT was an FRT
Beefs-up type safety for RefreshToken saving/restoration + SSO

#88

Fixes inheritance hierarchy of MicrosoftStsTokenResponse  to extend MicrosoftTokenResponse
Shared fields pulled-up to common super

#110

dto.RefreshToken instances no longer track a username field

MSAL changes for this PR located here

familyId already wired up in ADAL -- thanks @shoatman
https://github.com/AzureAD/azure-activedirectory-library-for-android/commit/7d1ec954a6e07dcefee58c9d6147b82a9f99a844

CR feedback incorporated. PMD & Checkstyle are 👍 -- thanks @addev-ashish


Ollie: Watch sofiadate.com

Ollie requests the watch of the watch_keyword sofiadate\.com. See the MS search here and the Stack Exchange search in text, in URLs, and in code.

sofiadate\.com has been seen in 0 true positives, 0 false positives, and 0 NAAs.

Approved by Spevacus in Charcoal HQ


Use easy_install-2.7, update bin search path

Use easy_install-2.7, same as in the pam module
Update easy_install-2.7 binary search path since it's located in /usr/local/bin on Ubuntu

    root@st2enterprise:/home/vagrant# which easy_install-2.7
    /usr/local/bin/easy_install-2.7

Without this change it fails with:
Error: Could not find command 'easy_install'
Error: /Stage[main]/Profile::Enterprise_auth_backend_ldap/Exec[install auth backend]/returns: change from notrun to 0 failed: Could not find command 'easy_install'

+1

Everything passed locally on Ubuntu with this change :)


Add badge for "chat on riot"

A "chat on riot" badge can be added to readme.rst just like "chat on gitter" badge.
See https://shields.io/category/chat
riot chat link : https://riot.im/app/#/room/#einsteinpy:matrix.org

Done!

Not closed until #77 is merged :)

Finally done! #77 meeged


2<IP_ADDRESS>-26 working like normal but still gives blink code

After flashing 2<IP_ADDRESS>-26, my Syncrobit hotspot is online and active on the explorer how ever there still is a flashing green light on the Syncrobit board, it flashes 4 times then stops and repeats. I had saw on one of the other issue posts that 4 flashes means no connection but mine is wired and working like normal. I imagine this is just a bug but I figured I would post it here to make it known.

This isn't an issue that we can fix I don't think... As I think it's built into the balenaOS that we use from upstream.
Which board is this green light on though? The main motherboard or the Raspberry Pi CM4? Or somewhere else?
If you can take a few pictures it would be helpful

Same here, I thought it was an SD Card issue, turns out its working fine? I luckily have two 32gb memory cards I been alternating with. I just reflashed it, the code is 4 green flashing lights... on repeat but seems to be witnessing just fine now.. :)

https://user-images.githubusercontent.com/47010638/229303807-e8a7e2dd-367b-4e16-920e-76f67562d2df.mp4
Ive also installed balenaOS to this syncrobit at one point and it seemed to use the green light as an activity light or on the webpage you were able to tell it to flash for a minute to identify the device. However it also seems the the raspberry pi will also default a 4 blink code for no bootable os found as I had a bad flash at one point and got no response other than that flashing light. Still working as normal so far!

Ah ok so that's the light on the actual Syncrobit main board. Don't think we intentionally use that for anything so it's probably just accidental.
We will look into it though as might be able to make it more useful

@shawaj hello shawaj and hello everyone, how is the last update going?  I have many to flash but I can't flash install and uninstall all the time😔 I wanted to install and not move anymore.  I see nebra's tireless effort and thank you 👏👏 but I'm afraid that not everything is with the ota yet, and now comes the change to solana.. i'm thinking of waiting until the solana migration and change and see if by then everything is going well.. what do you think?  and now the syncrobit are doing the OTA and they are working?? greetings

@joaopaulo529 the auto update is working fine now.
@YoureNotDead are you happy if we close this issue now?

@shawaj certainly! Like I had said at the start, I wasn't sure if this was a real issue or not so I just wanted to point it out.

hello 🙂 everything is great now. 👍👍👍
nebra top 😉🙏🙂🙂
complements
No dia 24/05/2023, às 22:24, YoureNotDead @.***> escreveu:

@shawajhttps://github.com/shawaj certainly! Like I had said at the start, I wasn't sure if this was a real issue or not so I just wanted to point it out.
—
Reply to this email directly, view it on GitHubhttps://github.com/NebraLtd/helium-syncrobit/issues/16#issuecomment-1561945862, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AYMOTWITUZ3GHWF4TDLC3DLXHZ4BVANCNFSM6AAAAAAWPHOV6E.
You are receiving this because you were mentioned.Message ID: @.***>


Improving README

I'm creating this issue to track the discussion started in #186
First thing, I think we have to decide what we want to keep in the main README:

What is it?
Install
where to find the docs?
Documentation (just a summary with the links)

As you suggested, we can move out all the API documentation, I think we have two solutions where we can move it:

Creating a directory Documentation which will contains several markdown files, examples:

Fastlane:
Quick
Moya
Alamofire -> just the migration guide

Put the documentation directly in the wiki

=> I prefer the first one since we already using the wiki with technical stuff. Moreover, it seems to be simpler to use
Whatever our final choice, here a first suggestion of how we can divide the API documentation:

TransitionAnimatable.md
Animatable.md
Designable.md
Extensions.md
Segue.md -> should it be merged in TransitionAnimatable?

@tbaranes thanks for starting this, Do you like Documentation folder more than wiki? I don't mind either way.
I like your groups, may have some more friendly to the user thinking, they match the project's goal.

Animations: Animatable
UI: Designable
Transitions: TransitionAnimatable and Segue
Misc: Extensions

Another important thing I am going to do after release 2.3 is blogging. I am going to write some blog posts about "How to prototype and App Store ready Apps in IB with IBAnimatable", "How to prototype and design animations in Swift Playground", "How to prototype and design transition animations in IB" etc. IBAnimatable is the first library to support designing transition animations in IB. I think it is a very useful tool for prototyping and design since we have a lot of comprehensive features.

Yes, I prefer the Documentation folder, I found them more usable since we can edit it them locally.
Excellent idea for your group names, it's user friendly and really understandable.
I'm looking forward to read your articles, moreover it will be an excellent idea since IBAnimatable is more and more popular, but is clearly missing some tutorials / helpers to get started about advanced usage.

Closing it now since the new structure is already there. We can still open a new issues just to list the documentation missing.


Add or update documentation for the v0.49.0 release

Added notes to UPGRADING.md.
Removed references to the udplog receiver since the Splunk Otel Collector does not currently support it.

We are currently expecting the functional test to fail until we upgrade the Splunk Otel Collector to v0.49.0.


Master monitor

How do I can install a master monitor? Because now, when I start hyprland programs in autostart open on my second monitor.

This unfortunately is not something this plugin (or any? without significant hacks) can fix. Wayland does not have the concept of a master monitor, and I don't really plan on supporting that here.


Development: Fix wrong initial page number in pageable requests

Checklist
General

[x] This is a small issue that I tested locally and was confirmed by another developer on a test server.
[x] I chose a title conforming to the naming conventions for pull requests.

Server

[x] I followed the coding and design guidelines.

Client

[x] I followed the coding and design guidelines.
[x] I added multiple integration tests (Jest) related to the features (with a high test coverage), while following the test guidelines.

Motivation and Context

There is a bug affecting all “import” modals in Artemis, likely introduced two years ago in #1676. The first pageable request sent by the client uses page: 0, which is not correct and results in an error 500 on the server (server subtracts 1 from page size, but it may not be negative).
Users do not experience this bug, since the initialization of the pagination component sets the page to 1 for all follow-up requests. Usually it just takes longer to load the search results.

Description

This PR fixes the bug by setting the page in the initial state of all Import Components to page: 1.
I also updated the tests for the programming exercise import component (taken from the modeling exercise import tests).
In the future, we should maybe think of generalizing the various Import Components. Right now we have some code duplication regarding the implementation and tests of the Import Components for: Modeling Exercises, Text Exercises, Lectures, Programming Exercises.
Steps for Testing

Prerequisites:

1 Instructor

Log in to Artemis as instructor
Navigate to Course Administration and Exercise Overview
Use the Import Modals for various exercises, please test Lecture Importing as well

Review Progress

Code Review

[ ] Review 1
[ ] Review 2

Manual Tests

[ ] Test 1
[ ] Test 2

Test Coverage

Class/File
Branch
Line

programming-exercise-import.component.ts
76%
95%

programming-exercise-paging.service.ts
50%
75%

@bassner I agree… We could of course also adjust the page before making the request, I have no preference if it is done client or server-side. That is the way the ng-bootstrap pagination widget defines it:

Be aware that both page and pageSize have default values, which are respectively 1 and 10.


edgeql: Change FROM to USING keyword.

In contexts where FROM appears to indicate the language or original
used change the syntax to use USING keyword. This primarily affects
function, cast and operator bodies.
In contexts where FROM indicates some initial state, the keyword
remains unchanged. This concernes migrations and cast signatures.

We also need to change expr := for computables and views to USING

Oh, that's right. I don't think we have an issue for this and it's big enough that it needs documentation of our thinking process. I'll make an issue.


CMake pure build on Windows

Building on Windows has long been known to fail (#48), but if we skip the TCP part and do a pure build, it is easy to fix.  This adds a -DPURE_BUILD=ON option to CMake build, and fixes it on Windows, tested with VS 2015.  Personally I use the lib integrated into libuv, these should be enough for me to continue hacking.
Btw tcpdefines.h added by #80 was moved to src/; to me it looks like a simple internal header.  No idea whether you would like to keep it there (and have it installed).

What's the go with this?  Has it been merged in to the main repo?


Review Hydra PHP SDK

We currently have our own custom "integration" using POST requests, see HydraController. We should review whether the newly released Hydra PHP SDK makes this easier (especially considering future Hydra updates

Not an option at the moment since the SDK requires an up-to-date PHP.


Bind publisher to itself

Coverage increased (+56.1%) to 56.129% when pulling aa51519e2c66ba2293a84c26c3772fafcc3ac15a on fix/bind-publisher into 64dcf332409c870a9f208ce912877dba557d2877 on master.


Play icon for multiple actions at the same time

In some cases, multiple activities display the Play icon.
Steps to reproduce the behavior

In random order, start several activities.
Short-press to Add button.
Long-press to Add button.
Create a new activity.

Actual behavior
The created activity appears.
Some activities have a Play icon.
Expected behavior
The created activity appears.
Only the current activity (one) has a Play icon.
Screenshots

Affected versions

v1.1 (build: 20230830)

Fixed in v1.2.


chore: preferred pattern for image tests #trivial #nochangelog

This PR resolves []
Description

use preferred practice for test
#nochangelog
#trivial

Warnings

:warning:

✅ No changelog changes

  Generated by :no_entry_sign: dangerJS against 011b976b04402edff4e0cf434b788d695972601d


[Bug]: Including a device twice makes it inaccessible until excluded and included again

Checklist

[X]  I am not using Home Assistant. Or: a developer has told me to come here.
[X] I have checked the troubleshooting section and my problem is not described there.
[X] I have read the changelog and my problem is not mentioned there.

Deploy method
Manually built (git clone - yarn build - yarn install
Zwavejs2Mqtt version
6.13.0
ZwaveJS version
9.5.0
Describe the bug
Including a device that's already included will make it become inaccessible even if the given name and/or location matches the already included one.
To Reproduce
Include a zwave device, then, include it once again.
Expected behavior
Either the inclusion gets declined or the device gets a new name/location, and it still accessible, even if under a new path/id/mqtt topic.
Additional context
Excluding then Including the device fixes this

Inaccessible as in it doesn't get messages I'd try to send it. Be it just a ping or a value change. This includes sending the message to it's ID and if the location/name changed on the new inclusion, neither the old or the new pairing of name/location mqtt topic, ex.: zwave/office/dimmer/38/1/targetValue/set

when a device is paired for a second time, the UI shows that device with ID shows the ID of the device that was already paired successfully included, but then it can't be controlled from APIs, MQTT, or the UI itself until it gets excluded and re-included under a new ID

I'll try to reproduce next week, but I'm afraid this is either device or controller specific behavior.

Can confirm that weird stuff happens when doing this. Restarting and/or re-interviewing gets things back to normal, but we should probably just not react when a node is "added" with an ID that is already part of the network.


Mechanism to play gm.dls based instruments in non-native tracker on linux

When working on a prod targeting windows with gm.dls use, it's not possible to play back the track on linux.
Maybe Sointu could allow to specify where the non-native tracker & plugin look for gm.dls over a CLI arg and a menu entry? That way it would be possible to at least play and convert to wave correctly on linux (by copying the file over from windows).

(This would make cross-development much easier)

I think it looks first for it from the current directory, if by any magic you get hold of this file on linux ;)
https://github.com/vsariola/sointu/blob/8fd2df19a16d16a7846a7ec02fb33e0422339b43/vm/go_synth.go#L80

Is this not enough?

oh, even better - I'll try that :) didn't look into the source

works perfectly. Thank you! :)


Scrapers stop scraping randomly

Steps to reproduce:
List the minimal actions needed to reproduce the behavior.

Create scrapers in UI
Wait couple hours

Expected behavior:
Scrapers to scrape consistently
Actual behavior:
One or multiple scrappers stops scrapping randomly after 5-10hours, I can see the requests still being made in logs without errors, but no data saved. Only way to fix it, to remove and re-add the scrapper in the UI, even reboot does not solve the issue.
Environment info:

System info: Linux 5.4.0-113-generic x86_64
InfluxDB version: Druid influxdb:latest (InfluxDB v2.2.0 Server: a2f8538 Frontend: cc65325)
(happens on nightly as well)

Looks like tasks started working in nightly[InfluxDB v2.0.0-rc.4+SNAPSHOT.370690307b], so I can scrape using tasks like this:
import "experimental/prometheus"

prometheus.scrape(url: "http://example.com/metrics")
    |> to(bucket: "example-bucket")

also lets you specify scrape interval, which is nice
regular scrapper still fails


Malloc error when using juliacall include

I have a Julia file with the following test code, lets call it classification.jl. This file is inside a folder called modules and has the following code:
# install packages
import Pkg; Pkg.add("Flux")
import Pkg; Pkg.add("BSON")
import Pkg; Pkg.add("Glob")

# import packages
using Flux
using BSON
using Glob
using Base.Threads

function test(a, b)
    return a+b
end

I want to include this file inside a Python module with functions, the name of the file is classification.py and it is also inside modules. It has the following code inside:
from juliacall import Main as julia

def test_function(inputs):
    julia.include("modules/classification.jl")
    s = julia.test(3, 4)
    print(s)

Finally, the Python module will be called by a main Python script.
from modules.classification import *
This is giving me the following error:
python(11210,0x7ff85c3a64c0) malloc: *** error for object 0xffffffff00000000: pointer being freed was not allocated
python(11210,0x7ff85c3a64c0) malloc: *** set a breakpoint in malloc_error_break to debug

But when I ignore the packages it can run...
Do you know how I can debug this? My colleague is using Windows and he doesn't have this problem. I am using mcOS.

So, I put using Flux in comment and it works, the problem is that I need Flux...

This is solved: Now I make the import of the Julia packages in the main Python script and not inside the classification.jl module.


How to access loadings() or reconstruct()?

Hi,
How do you get reconstruct or loadings to work with your package?
## PCA model
PCA = @iload PCA pkg="MultivariateStats"
mach = machine(PCA(), cluster_df[:, Not([:organisation_srg_key, :customer_bucket])])
fit!(mach)

# compute explained variance for each dimension
report(mach).principalvars
report(mach).mean

For MultivariateStats the code would be:
M = fit(PCA, cluster_m)
loadings(M)

Cheers,

Hi @WilliamZimmerman83
To get reconstruct just call inverse_transform(mach, X)
For loadings try doing report(mach).loadings

report(mach) doesn't have a loadings fields:
ERROR: type NamedTuple has no field loadings
The only fields I have available in report are:
indim
outdim
tprincipalvar
tresidualvar
tvar
mean
principalvars
It would be really nice to get the loadings and projection matrix (the same as PCA)

@WilliamZimmerman83 That seems like a bug.
I'll open a PR to fix this

@WilliamZimmerman83 https://github.com/JuliaAI/MLJMultivariateStatsInterface.jl/releases/tag/v0.5.1


Registering model for best epoch on a recovered run

To register the best model in a run we need validation metrics across epochs, which are not available if the run was continued using run recovery.

No longer applicable, because we always store the model at the last epoch.


The function next_step! is using a confusing definition for the wind direction

The function next_step! has the parameter wind_dir, which is defined such that zero means wind from west to east. This is not a standard way to define the wind direction.
Replace this parameter with upwind_direction as defined here: https://ufechner7.github.io/KiteUtils.jl/dev/reference_frames/

Fixed in v0.6.6


docs: fix options typo in iOS frame processor instructions

What

This PR fixes a typo in an iOS Frame Processor instruction doc.

Changes

Change options to withOptions while initializing proxy.

Perfect thanks!


Project depending on JSONWebToken ver 2.2.0 (master) does not compile.

I have just updated my project to Swift 4 and Xcode 9 settings, during the upgrade efforts I also updated JSONWebToken to ver 2.2.0 (cartfile: github "kylef/JSONWebToken.swift" "master").
Unfortunately, the JWT import complains about missing required module 'CryptoCommon' (screenshot attached). This problem becomes especially apparent on my build machine where the project is built "fresh" every single time.

Reverting to version 2.1.0 yields JWT compilation error:

Task failed with exit code 65:
	/usr/bin/xcrun xcodebuild -project /Users/pkijowski/projects/mobile/CFApps_iOS/Carthage/Checkouts/JSONWebToken.swift/JWT.xcodeproj -scheme JWT-OSX -configuration Release -derivedDataPath /Users/pkijowski/Library/Caches/org.carthage.CarthageKit/DerivedData/9.0_9A235/JSONWebToken.swift/2.1.0 ONLY_ACTIVE_ARCH=NO CODE_SIGNING_REQUIRED=NO CODE_SIGN_IDENTITY= CARTHAGE=YES build (launched in /Users/pkijowski/projects/mobile/CFApps_iOS/Carthage/Checkouts/JSONWebToken.swift)

carthage-xcodebuild.6tdkjU.log

We have also run into this problem.  It seems carthage bootstrap is required to have been run once, where typically we just check in the built Carthage products.

Is there a resolution or workaround to this?

@jonbrooks Didn't you say yourself that you need to run carthage bootstrap?

@kylef Since this change, it seems we have to run carthage bootstrap any time we pull changes from git (maybe just changes that touch carthage products? not sure...), or checkout on a fresh system, like a build machine.  It's no longer possible to just check in the contents of Carthage/Build and have that be able to build and run.

I do not use Carthage so I am not entirely sure, but looking the vague documentation for Carthage it says to run carthage bootstrap before running a project using Carthage. Isn't this expected?
https://github.com/Carthage/Carthage#running-a-project-that-uses-carthage

After you’ve finished the above steps and pushed your changes, other users of the project only need to fetch the repository and run carthage bootstrap to get started with the frameworks you’ve added.

I guess the documentation is more vague than I realized, but in general, Carthage builds standalone frameworks that are put in Carthage/Build, so by checking that folder into git, a user can typically just checkout and build with no carthage steps required.  The JSONWebToken build run by Carthage does some sort of side effect that is required for a successful build, and just checking in the built framework is no longer sufficient.  If the rest of the world isn't screaming about this, maybe this process we have is not a good one.  However, the CryptoSwift-dependent version of JSONWebToken worked much better for us in Carthage (and worked like all other dependencies we pull in).
Thanks for engaging on this problem, and thanks for what has been a useful framework for us.


Add legacy upgrade support

Closes: #1287
Description
Adds the verbose flag to allow switching from /ibc.core.client.v1.UpgradeProposal (used in v0.43.0) to /cosmos.upgrade.v1beta1.SoftwareUpgradeProposal (used previously) thereby enabling upgrade support for legacy chains.

For contributor use:

[x] Added a changelog entry, using unclog.
[ ] If applicable: Unit tests written, added test to CI.
[x] Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
[x] Updated relevant documentation (docs/) and code comments.
[x] Re-reviewed Files changed in the Github PR explorer.

The code has been tested with and without the --legacy option for gaiad:colin/fee-event-testing-eb478f7bfc9b2860133c2e740bdfe506f9f77151-eb478f7bfc9b2860133c2e740bdfe506f9f77151 and gaiad-v5.0.5.


Model contrib guidelines

New model contribution guidelines that aim to clarify the process for adding new model architectures or improved model weights.
Feedback welcome, as always, before it gets merged.
cc: @datumbox  @xiaohu2015 @zhiqwang

@xiaohu2015 @zhiqwang since you have been through this process recently your feedback would be very valuable :)


[help] API change when update to the latest version

The new version changed some exports of types, my old code shows lots of errors.

columnTypes

DefaultColumnTypes

jsonInsert and jsonSet shows error

A bug in relation query:
I have a TableActivity which has many TableActivityMembers
export class TableActivity extends BaseTable {
  public readonly table = 'activity';
  public readonly softDelete = true;

  public columns = this.setColumns((t) => ({
  }));

  public relations = {
    members: this.hasMany(() => TableActivityMember, {
      required: true,
      primaryKey: 'id',
      foreignKey: 'activityId',
    }),
  };
}

My old query is db.activity.whereExists('members', (q) => q.where({ 'members.userId': 'xxxxx' })), which now shows type error, but the query result is correct.
The correct type for this version changed to activity_member.userId, but the query shows 500.
It seems the new version has wrong type hint.

Thank you for testing the new build!

columnTypes

You don't have to import it, try this instead:
q.sql`*sql string*`.type((t) => t.string())

DefaultColumnTypes

Is it necessary for cuid to be a separate function?
If not:
export const BaseTable = createBaseTable({
  columnTypes: (t) => ({
    ...t,
    cuid() {
      return t
        .varchar(36)
        .primaryKey()
        .default(() => createId());
    },
  }),
});

If it has to be a separate function:
import { ColumnSchemaConfig } from 'orchid-core';

const cuid = (t: DefaultColumnTypes<ColumnSchemaConfig>) => {

I didn't expect that you may want to use this type, so it's not exported from orchid-orm or pqb, so it's exported from orchid-core. Do you think it's better to export it from orchid-orm?

A bug in relation query:

I'm glad it's not critical and you can temporarily add ts-ignore, I'll try to handle it in the near days.

columnTypes

t => t.string() seems not work

DefaultColumnTypes

DefaultSchemaConfig works well in my code, and it do not need to import from orchid-core, can I write DefaultSchemaConfig instead of ColumnSchemaConfig, if not, I think it's better to re-export ColumnSchemaConfig in orchid-orm

Any clue in jsonInsert and jsonSet query?

I add ts-ignore comment, it works for now, thank you.

Sorry for late reply, I'll have more time from now on;

columnTypes

Column types became more dynamic, that's on purpose, so the Query type doesn't know the exact types you have.
Exact types are defined in the BaseTable (returned by createBaseTable).
I just pushed update so that BaseTable now will have columnTypes prop on it, and you can use your BaseTable in that type callback:
import { Query } from 'orchid-orm';
import { BaseTable } from './path-to-your-base-table';

export const SQLFormat = {
  timeCN(q: Query, column: string, format: string) {
    return q.sql`to_char(${q.column(
      column,
    )} + interval '8 hours', ${format})`.type(() =>
      BaseTable.columnTypes.string(),
    );
  },
};

DefaultColumnTypes

So this is already exported from 'orchid-orm' - good - no changes are needed.

Any clue in jsonInsert and jsonSet query?

Worked with zod config, but apparently, there is a bug when you use default column types.
I pushed a fix for this, should be fine now.

The new version is pleasant to use, typescript hinting is faster and json schema is much easier to write.

I'm so happy to have this feedback from you!
There are more ideas to try to optimize TS further, it will become faster over time.
Just pushed an update to resolve this problem:
db.activity.whereExists('members', (q) => q.where({ 'members.userId': 'xxxxx' }))

Now it should be ok.
Closing this issue, let me know if any problem.


Fixes #4711 - add a namespace configuration option to KCF

A fix for #4711

Description
This change forces the k8s client to use a particular namespace when communicating with the API server.
Related issue and scope

[X] I opened an issue to propose and discuss this change (#4711)

My changes affect the following components

[ ] API
[ ] Controller
[ ] Message Bus (e.g., Kafka)
[ ] Loadbalancer
[X] Invoker
[ ] Intrinsic actions (e.g., sequences, conductors)
[ ] Data stores (e.g., CouchDB)
[ ] Tests
[ ] Deployment
[ ] CLI
[ ] General tooling
[ ] Documentation

Types of changes

[X] Bug fix (generally a non-breaking change which closes an issue).
[ ] Enhancement or new feature (adds new functionality).
[ ] Breaking change (a bug fix or enhancement which changes existing behavior).

Checklist:

[X] I signed an Apache CLA.
[X] I reviewed the style guides and followed the recommendations (Travis CI will check :).
[ ] I added tests to cover my changes.
[ ] My changes require further changes to the documentation.
[ ] I updated the documentation where necessary.

Codecov Report

Merging #4712 into master will decrease coverage by 6.64%.
The diff coverage is 80%.

@@            Coverage Diff             @@
##           master    #4712      +/-   ##
==========================================
- Coverage   84.98%   78.34%   -6.65%
==========================================
  Files         191      198       +7
  Lines        8574     8832     +258
  Branches      599      604       +5
==========================================
- Hits         7287     6919     -368
- Misses       1287     1913     +626

Impacted Files
Coverage Δ

...re/containerpool/kubernetes/KubernetesClient.scala
27.53% <80%> (+1.97%)
:arrow_up:

...core/database/cosmosdb/RxObservableImplicits.scala
0% <0%> (-100%)
:arrow_down:

...enwhisk/connector/kafka/KamonMetricsReporter.scala
0% <0%> (-100%)
:arrow_down:

...e/database/cosmosdb/cache/ChangeFeedConsumer.scala
0% <0%> (-100%)
:arrow_down:

...ore/database/cosmosdb/cache/CacheInvalidator.scala
0% <0%> (-100%)
:arrow_down:

...core/database/cosmosdb/CosmosDBArtifactStore.scala
0% <0%> (-96.23%)
:arrow_down:

...sk/core/database/cosmosdb/CosmosDBViewMapper.scala
0% <0%> (-93.8%)
:arrow_down:

...tabase/cosmosdb/cache/CacheInvalidatorConfig.scala
0% <0%> (-92.31%)
:arrow_down:

...e/database/cosmosdb/cache/KafkaEventProducer.scala
0% <0%> (-77.78%)
:arrow_down:

...whisk/core/database/cosmosdb/CosmosDBSupport.scala
0% <0%> (-74.08%)
:arrow_down:

... and 21 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f304092...6b91bf2. Read the comment docs.


Add a unit test for KaldbQueryParser

Add a unit test for KaldbQueryParser.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.Suman seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.


Add builder for EngineConfig

Signed-off-by: Sachin Kale<EMAIL_ADDRESS>Description

EngineConfig class has 25+ fields and 3 constructors. Adding any new optional field results in addition of one or more constructors to keep the backward compatibility.
To avoid this, we introduced Builder class for EngineConfig.

Issues Resolved

NA

Check List

[ ] New functionality includes testing.

[X] All tests pass

[ ] New functionality has been documented.

[X] New functionality has javadoc added

[X] Commits are signed per the DCO using --signoff
[ ] Commit changes are listed out in CHANGELOG.md file (See: Changelog)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Codecov Report

Merging #5618 (7f77ca6) into main (306b199) will increase coverage by 0.03%.
The diff coverage is 89.68%.

@@             Coverage Diff              @@
##               main    #5618      +/-   ##
============================================
+ Coverage     70.84%   70.88%   +0.03%
+ Complexity    58296    58294       -2
============================================
  Files          4741     4741
  Lines        278541   278642     +101
  Branches      40268    40268
============================================
+ Hits         197322   197503     +181
+ Misses        65068    65025      -43
+ Partials      16151    16114      -37

Impacted Files
Coverage Δ

...va/org/opensearch/index/engine/EngineTestCase.java
86.07% <80.00%> (-0.35%)
:arrow_down:

...java/org/opensearch/index/engine/EngineConfig.java
98.41% <100.00%> (+1.01%)
:arrow_up:

...g/opensearch/index/engine/EngineConfigFactory.java
92.75% <100.00%> (+4.11%)
:arrow_up:

...n/indices/forcemerge/ForceMergeRequestBuilder.java
0.00% <0.00%> (-75.00%)
:arrow_down:

.../indices/forcemerge/TransportForceMergeAction.java
25.00% <0.00%> (-75.00%)
:arrow_down:

...h/action/ingest/SimulateDocumentVerboseResult.java
60.71% <0.00%> (-39.29%)
:arrow_down:

...arch/search/aggregations/pipeline/LinearModel.java
23.07% <0.00%> (-34.62%)
:arrow_down:

...on/admin/indices/forcemerge/ForceMergeRequest.java
50.00% <0.00%> (-31.58%)
:arrow_down:

...rc/main/java/org/opensearch/ingest/IngestInfo.java
51.72% <0.00%> (-27.59%)
:arrow_down:

...a/org/opensearch/index/mapper/MapperException.java
75.00% <0.00%> (-25.00%)
:arrow_down:

... and 481 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


GEODE-6101: Builds module for consumption by Java 9+ modules project.

Produces a merged jar with contents from
geode-common
geode-json
geode-core
geode-cq
Module uses automatic naming for name org.apache.geode

Co-authored-by: Jacob Barrett<EMAIL_ADDRESS>Co-authored-by: Owen Nichols<EMAIL_ADDRESS>Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:

[ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?

[ ] Has your PR been rebased against the latest commit within the target branch (typically develop)?

[ ] Is your initial contribution a single, squashed commit?

[ ] Does gradlew build run cleanly?

[ ] Have you written or updated unit tests to verify your changes?

[ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?

Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and
submit an update to your PR as soon as possible. If you need help, please send an
email to<EMAIL_ADDRESS>

See https://github.com/pivotal-jbarrett/geode-example-java-11 as an example application using this module. This is an iterative work in progress.

Are you planning to merge this PR?  I think the jar version changes are fine (good!) but I'd rather not merge the geode-module stuff until you've finished exploring the other approaches you identified and we get consensus that this approach is the right one.

@metatype what is the harm in merging a solution? I see it as a way to give others the ability to experiment and provide feedback.


Update solver.py

fix tiny typos

@kaleidoscopical why close this? the fix should be right, thanks.

@tornadomeet All of a sudden, I thought it may be rude to modify the naming, which does not reduce the readability.


Flask Traces Sampler Function seems to have no effect

Environment
How do you use Sentry?
Sentry SaaS (sentry.io)
Which SDK and version?
sentry-sdk[flask]==1.4.1
Steps to Reproduce

Changed from previous code:

    sentry_sdk.init(
        dsn=sentry_dsn,
        traces_sample_rate=0.1,
        environment=sentry_environment,
        attach_stacktrace=True,
        integrations=[
            FlaskIntegration(),
            sentry_logging,
        ],
    )

to
    sentry_sdk.init(
        dsn=sentry_dsn,
        traces_sampler=sentry_traces_sampler,
        environment=sentry_environment,
        attach_stacktrace=True,
        integrations=[
            FlaskIntegration(),
            sentry_logging,
        ],
    )

where
def sentry_traces_sampler(sampling_context):
    try:
        # wsgi_environ is populated by sentry flask integration
        # https://docs.sentry.io/platforms/python/guides/flask/configuration/sampling/
        request_uri = sampling_context['wsgi_environ']['REQUEST_URI']
    except KeyError:
        return 0.1

    if request_uri == "/ping":
        # very low rate as these are extremely frequent and pretty useless
        return 0.001

    if request_uri in {
        "/api/xml/home_aaa_request",
        "/api/xml/home_bbb_request",
        "/api/xml/home_ccc_request",
        "/api/xml/home_ddd_request",
    }:
        # lower rate as these are very frequent
        return 0.01

    # default sample rate
    return 0.1

tested locally with Postman to confirm that sentry_traces_sampler goes down correct route for each endpoint
released to production

Expected Result
Number of traced requests to API endpoints should drop to < 10% of previous value.
Actual Result
Number of transactions stays roughly same as before. Screenshots showing the release which was roughly 10:00 (28/09/2021):

Assuming that requests haven't spiked hugely, we should expect to see a dramatic drop in transactions per minute around that time, but it is roughly the same.
One hypothesis is that the try/except catch default value of 0.1 is being hit in production but not locally (I'll test this now), but it seems possible that the sentry_traces_sampler return values are not being interpreted correctly?

Hey @AdamUrbanJungle
Sorry for taking so long to reply.
Can you confirm that this is still an Issue in our newest SDK? If yes, I will try to reproduce this. Thanks!

Hi i'm having same issue as described ( with FastApi)

Hey @mfumagalli68 - could you open a new issue to track with code snippets, versions of sdk + fastapi you're using, and your traces sampler config? Thanks!


Cannot use alias path for images in template

Describe the bug
relative path <img src="./assets/logo.png" /> works
alias path <img<EMAIL_ADDRESS>/> does not
Reproduction
vite-alias-reproduction
System Info
System:
    OS: macOS 12.4
    CPU: (8) arm64 Apple M1
    Memory: 180.63 MB / 8.00 GB
    Shell: 5.8.1 - /bin/zsh
  Binaries:
    Node: 16.15.0 - ~/.nvm/versions/node/v16.15.0/bin/node
    Yarn: 1.22.15 - ~/.nvm/versions/node/v16.15.0/bin/yarn
    npm: 8.5.5 - ~/.nvm/versions/node/v16.15.0/bin/npm
  Browsers:
    Chrome: 102.0.5005.61
    Firefox: 101.0
    Safari: 15.5
  npmPackages:
    @vitejs/plugin-vue: ^2.3.3 => 2.3.3
    vite: ^2.9.9 => 2.9.10

Used Package Manager
pnpm
Logs
No response
Validations

[X] Follow our Code of Conduct
[X] Read the Contributing Guidelines.
[X] Read the docs.
[X] Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
[X] Make sure this is a Vite issue and not a framework-specific issue. For example, if it's a Vue SFC related bug, it should likely be reported to https://github.com/vuejs/core instead.
[X] Check that this is a concrete bug. For Q&A open a GitHub Discussion or join our Discord Chat Server.
[X] The provided reproduction is a minimal reproducible example of the bug.

alias is a simple replace. So you need to change resolve.alias from
	'@': './src'

to
	'@': path.resolve(__dirname, './src')

.

I'm sorry for adding reply to this closed ISSUE, but I have a problem on the same situation. I don't know whether it's a bug or feature limitation.
Here is a reproduction example on StackBlitz: vite custom alias other than @ does not working as expected .
Thanks for your time, ❤.

@kongxiangyan it may be a bug, it works if you first import in


GestureDetector doesn't update correctly

Problem
When rememberOnGestureListener is recomposed, listeners are not updated.
Example
Please see example below.
After "option" is selected by using bottom sheet (e.g. "First"), you would expect that "Single tap confirmed (option: First)" is printed to console. Instead "Single tap confirmed (option: null)" is shown.
import android.util.Log
import androidx.compose.foundation.clickable
import androidx.compose.foundation.layout.Box
import androidx.compose.foundation.layout.fillMaxSize
import androidx.compose.foundation.layout.navigationBarsPadding
import androidx.compose.foundation.layout.padding
import androidx.compose.foundation.lazy.LazyColumn
import androidx.compose.foundation.lazy.items
import androidx.compose.material.icons.Icons
import androidx.compose.material.icons.filled.Menu
import androidx.compose.material3.Icon
import androidx.compose.material3.IconButton
import androidx.compose.material3.ModalBottomSheet
import androidx.compose.material3.SheetState
import androidx.compose.material3.Text
import androidx.compose.material3.rememberModalBottomSheetState
import androidx.compose.runtime.Composable
import androidx.compose.runtime.getValue
import androidx.compose.runtime.mutableStateOf
import androidx.compose.runtime.remember
import androidx.compose.runtime.rememberCoroutineScope
import androidx.compose.runtime.setValue
import androidx.compose.ui.Alignment
import androidx.compose.ui.Modifier
import androidx.compose.ui.unit.dp
import io.github.sceneview.ar.ARScene
import io.github.sceneview.rememberOnGestureListener
import kotlinx.coroutines.launch

private val options = listOf(
    "First",
    "Second"
)

@Composable
fun Main() {
    var selectedOption by remember { mutableStateOf<String?>(null) }

    val sheetState = rememberModalBottomSheetState()
    var isSheetVisible by remember { mutableStateOf(sheetState.isVisible) }
    val scope = rememberCoroutineScope()

    Box(modifier = Modifier.fillMaxSize()) {
        AR(selectedOption)

        MenuButton(
            onClick = {
                scope.launch {
                    isSheetVisible = true
                    sheetState.expand()
                }
            },
            modifier = Modifier
                .align(Alignment.BottomEnd)
                .padding(bottom = 32.dp),
        )
    }

    if (isSheetVisible) {
        BottomSheet(
            state = sheetState,
            onOptionSelected = {
                selectedOption = it
                scope.launch { sheetState.hide() }
                    .invokeOnCompletion { isSheetVisible = false }
            },
            onDismissRequest = { isSheetVisible = false }
        )
    }
}

@Composable
private fun AR(selectedOption: String?) {
    ARScene(
        modifier = Modifier.fillMaxSize(),
        onGestureListener = rememberOnGestureListener(
            onSingleTapConfirmed = { event, node ->
                Log.d("AR", "Single tap confirmed (option: $selectedOption)")
            }
        )
    )
}

@Composable
private fun MenuButton(onClick: () -> Unit, modifier: Modifier = Modifier) {
    IconButton(onClick = onClick, modifier = modifier) {
        Icon(imageVector = Icons.Default.Menu, contentDescription = null)
    }
}

@Composable
private fun BottomSheet(
    state: SheetState,
    onOptionSelected: (String) -> Unit,
    onDismissRequest: () -> Unit,
) {
    ModalBottomSheet(
        onDismissRequest = onDismissRequest,
        sheetState = state,
        modifier = Modifier.navigationBarsPadding(),
    ) {
        LazyColumn(modifier = Modifier.padding(all = 8.dp)) {
            items(options) { option ->
                Text(text = option, modifier = Modifier.clickable { onOptionSelected(option) })
            }
        }
    }
}

I guess code should look like below. But I think this should be handled by rememberOnGestureListener. What do you think?
@Composable
private fun AR(selectedOption: String?) {
    val currentOption by rememberUpdatedState(selectedOption)
    ARScene(
        onGestureListener = rememberOnGestureListener(
            onSingleTapConfirmed = { event, node ->
                Log.d("AR", "Single tap confirmed (option: $currentOption)")
            }
        )
    )
}

Hi,
Yes, you're right, a lambda shouldn't be remembered.
Could you please create a PR to fix it?
Thanks

Could you please create a PR to fix it?

Can't make any promises, sorry. I'm not invested in your library yet. I'm still exploring my options for AR implementation.


Parse dates

Extend stepwise search and edit functions to dates in verbatim label.
1 roughly parallel functionally to parse lat/long
2 help applied to potential other identical dates labels, revealing verbatim label
3 processed verbatim date candidate editable

Coverage decreased (-0.2%) to 89.326% when pulling 6eb3edfb2ab6cc3875b7e438c25d43e99c6f2c76 on parse_dates into 76aff8abee7bb22d5eca88ed9af090f15a3f7046 on development.

Coverage decreased (-0.2%) to 89.325% when pulling f978c52c4d978b218da4ee5ffb0c95332a929943 on parse_dates into f5155e3f3de2e813c4936a8b7953ef166e5b6d82 on development.

Coverage decreased (-0.2%) to 89.325% when pulling cefcd2d2fbd89ca59e534508fa57ef004842cc85 on parse_dates into d6590a623edb8d17bb3ca758324fd61c90321365 on development.

Coverage decreased (-0.2%) to 89.325% when pulling 16567d06df97b5f112db75e003415b969e112c5d on parse_dates into d6590a623edb8d17bb3ca758324fd61c90321365 on development.

Coverage decreased (-0.2%) to 89.325% when pulling e2ef4a584c067f5ee157c521b68cd549347db0d9 on parse_dates into d6590a623edb8d17bb3ca758324fd61c90321365 on development.


validate_on_submit() expects a tuple list for SelectField even though a normal list is a valid argument

Actual Behavior
form.validate on submit() evaluates to False when choices in SelectField is a list of values only. The same form validation evaluates to  True when using (value, label) tuples as used with version 2.2.1

class RegistrationForm(FlaskForm):

    language = SelectField('Language', choices=['python', 'ruby', 'rust'], validators=[DataRequired()])
    submit = SubmitField('Submit')

@app.route('/', methods=['GET', 'POST'])
def index():
    form = RegistrationForm()
    if form.validate_on_submit():
        return redirect(url_for('test'))
    return render_template('index.html', form=form)

The SelectField() is rendered properly in the HTML form and its value can be accessed with form.language.data but form.validate_on_submit() still evaluates to False.
Expected Behavior
form.validate on submit() to evaluate to True when choices in SelectField is a list of values only as well.
Environment

Python version: 3.8.2
Flask-wtf version: 0.14.3
wtforms version: 2.3.1

Duplicate of https://github.com/wtforms/wtforms/pull/598


feat: allow custom namespace for previews

This change allows you to define an environment variable PREVIEW_NAMESPACE which is used in place of the standard jx-org-repo-pr convention.  The inspiration for this was to allow a namespace per build, rather than pr

From looking at the way in which jx preview destroy works, I think this should be ok.  It should only have any effect if you have defined an environment variable PREVIEW_NAMESPACE

@ankitm123 is there anything outstanding for this?  I've been successfully using an image built with this change for about a month now.

Hi @ankitm123, is anything required for this now?  I've been successfully using it in my cluster for about a month without any ill effect

/ok-to-test

/retest


Please add support fot 1.20.6

I updated the server to 1.20.6, but terra is not supporting it.

It looks like you're developer—you might try compiling the 1.20.6 branch:
https://github.com/PolyhedralDev/Terra/tree/dev/1.20.6


How to do we use scheduling tasks and inject them with application?

I wanted to create a scheduler but i am not sure how am I going to register it and deploy it?

You can check the Scheduling APIs https://github.com/simplcommerce/SimplCommerce/tree/master/src/SimplCommerce.Infrastructure/Tasks/Scheduling and HangFireJobs module https://github.com/simplcommerce/SimplCommerce/tree/master/src/Modules/SimplCommerce.Module.HangfireJobs

How to use this APIs and/or HangFireJobs module in another module?
Thank you @hishamco !

How to use this APIs and/or HangFireJobs module in another module?
Thank you @hishamco !


make-based: Add do.sh build script for Redis

Add a do.sh build script for app-redis, similar to the existing ones for app-helloworld, app-httpreply and app-nginx.
Hackathon points: 20

I want to take it.

Closed by #22