Custom mapper doesn´t work

I want to create a custom mapper for assembly language (primary goal) so I follow your example in the wiki to create a generic wrapper for a file extension (I try it with your markdown example first).
My file main.x looks like this

# Test
### Test3

I have a mapper_X.js on my desktop (complete path C:\Users\Daniel\Desktop\mapper_X.js)
 "codemap.md": [     {       "pattern": "^(\\s*)### (.*)",       "clear": "##",       "prefix": " -",       "icon": "level3"     },     {       "pattern": "^(\\s*)## (.*)",       "clear": "##",       "prefix": " ",       "icon": "level2"     },     {       "pattern": "^(\\s*)# (.*)",       "clear": "#",       "prefix": "",       "icon": "level1"     },     {       "pattern": "!\\[image\\]",       "clear": "![image]",       "prefix": "<image>",       "icon": "none"     }   ]
VS code marks the ":" in '"codemap.md": [' red and say ";" expected. Why?
I also add "codemap.X": "C:\\Users\\Daniel\\Desktop\\mapper_X.js", to my settings.json. VS code marks codemap.X green and say Unknown configuration setting.
And I don´t get any result in my Code Map window with the above example.
What goes wrong here?
Thank you!

The idea of any extension configuration is that it is defined in the JSON not JS file. That's why you have a syntax error.
The config file is also must be present in the special location. Not in the desktop folder.
What you need to do is to use VSCode to start editing user settings. This will create the json file where you will need to paste your settings content.

Could you please tell me what I am doing wrong. I first copied the definition of codemap.md to user settings, renamed it to codemap.X, and then created a test.X file where I input some markdown headlines, but they don't appear in the left pane. I make this trail to make the step as small as possible.
"codemap.X": [
{
"pattern": "^(\s*)### (.)",
"clear": "###",
"prefix": " -",
"icon": "level3"
},
{
"pattern": "^(\s)## (.)",
"clear": "##",
"prefix": " ",
"icon": "level2"
},
{
"pattern": "^(\s)# (.*)",
"clear": "#",
"prefix": "",
"icon": "level1"
},
{
"pattern": "!\[image\]",
"clear": "![image]",
"prefix": "",
"icon": "none"
},
{
"pattern": "!\[\]",
"clear": "![]",
"prefix": "",
"icon": "none"
}
],

The following is an extract from Wiki that I have created to assist you and others in the situatuion like yours:

How To
Hint
When creating a custom generic mapper it is difficult to get it right from the first hit because your mapper will depend on the correctness of your regular expressions. Which in turn usually start working only after a few attempts. Thus it will be much easier if you implement a very generic mapper first and only then then start refining your regex patterns.
Creating simple generic mapper
Assume we need to create a mapper for the files with the extension '.x'.
Follow these very simple steps.

Open settings page

Open settings.json file

Insert generic pattern
  . . .
  "codemap.x": [
    {
      "pattern": "function \\w*",
      "icon": "function"
    }
  ],
  . . .

The configuration above will trigger building the code tree with nodes corresponding every line that starts from "function " word.

Trigger code map generation by pressing the refresh button:

Use one of the online regex testing tools  to refine your regex expression to serve your specific syntax.

The regex from the sample above was taken from the PowerShell syntax mapper:
"codemap.ps1": [
  {
    "pattern": "function \\w*",
    "clear": "function ",
    "suffix": "(...)",
    "icon": "function"
  }
],

I accidentally found the solution. The pattern suffix doesn't need to be in the same case as the file extension. If I name the pattern as "codemap.x", and the file as "test.X", it works. If I name the pattern as "codemap.X", it doesn't. So, I can use your extension now. Thank you!

Great.
If you are happy with your R mapper, you can share it and I will include it into the default distro.

Thank you for the encouragement.  As an appreciation of your valuable extension, I want to show that even some most rudimentary pattern for the generic mapper can help a lot. With the following example, I get a wonderful list of functions or unit tests.
Could you please tells me the possible values for the key "icon"? It would help if I or others go on refining the patterns. Thank you!
  "codemap.r": [
    {
      "pattern": ".*<-.*function.*",
      "icon": "function"
    },
    {
      "pattern": ".*test_that.*",
      "icon": "function"
    }
  ],

I found the defined values for the key "icon" in your wiki and therefore deleted my question from my last comment.

icon - name of the predefined icon:
class
interface
function
property
document
level1
level2
level3
none

Excellent, can you also share any realistic/representative R source that I can take, pass through the mapper and use the screenshot for the documentation? It would save me the time for chasing it online.

Don't worry. I got a good code sample now.

Great, it's very kind of you. I would have used some scripts from the testthat package at https://github.com/r-lib/testthat/tree/master/R.

done. he latest version of CopdeMap contains default support for R.
https://github.com/oleg-shilo/codemap.vscode/blob/dd1c1102e0bc6fcb305024089ed61e5f6c753f8e/package.json#L81-L97
Though if you have your mapping defined in settings.json it will take the precedence over the default configuration. To check out the actual configuration you can execute the new "Show mappers" command:

The new version is automatically installed. I love it and removed my pattern definition. Thank you!

Actually VSCode supposed not to remove custom user configuration on extension update. This si rather odd and... unfortunately outside of my control.
Though you can always restore your custom mapper patterns by specifying them (again) in the settings.json file.

No, no, I myself have removed it because yours already does more than mine.
I want to share some information which is off topic in this issue. I newly switched to the portable version of vscode to avoid profile roaming. I noticed

AppData\Roaming\Code\User\codemap.user\syntaxer\<IP_ADDRESS>\syntaxer.exe

is currently the only piece that does not live in the data folder of the portable vscode.

No, no, I myself have removed it ...

Cool, then it makes sense :)

...is currently the only piece that does not live in the data folder...

Correct. syntaxer.exe is a server that is running in background and it needs to be deployed outside of extension dir so it does not interfere with the upgrading steps. When thy are executed.
CodeMap extension deploys it to the dedicated versioned sub folder of the VSCode user folder. The very same folder where persistent user settings are stored. And according VSCode documentation this folder is determined as below:

I am almost confident that even portable VSCode installation stores user data there as well.

Thank you. It's very kind of you to response every time in great detail. I searched but didn't find settings.json in AppData\Roaming\Code and its subfolders. But you must know much more than me.

Not a problem. :)
You did not found settings.json probably because in case of portable install this file is stored somewhere else. I actually would appreciate if you tell me where exactly.
You can find it out by follow these very simple steps.

Open settings page

Open settings.json file

Now note the file full path VSCode active doc settings.json.
I am trying to get this info because syntaxer.exe is a user asset (similarly to settings.json) so it needs to be stored outside of the "extensions" folder and I simply don't know how VSCode solves the location problem for settings.json file.  But if I do, then it can be an opportunity to store syntaxer.json at the same location.

It's in \data\user-data\User\settings.json.

Thank you.

You are welcome and thank you again for your extension!

I am closing this issue but you can reopen it if any further help is required .


Docker Error during migration run

Hello,
I'm trying to setup this project on my machine but I can't get it to work.
I'm new to Docker and this is my first time using it but here is my attempt:
When I run docker-compose up I get an error:
[+] Running 9/9
 - postgres Pulled                                                                                17.1s
   - 59bf1c3509f3 Already exists                                                                                0.0s
   - c50e01d57241 Pull complete                                                                                0.8s
   - a0646b0f1ead Pull complete                                                                                0.9s
   - 08018e47fc43 Pull complete                                                                                12.0s
   - 6014f2775635 Pull complete                                                                                12.1s
   - 85760f97d4b8 Pull complete                                                                                12.2s
   - 3e07f59f91db Pull complete                                                                                12.3s
   - 3f86c399b0a1 Pull complete                                                                                12.5s
[+] Building 1.1s (11/11) FINISHED
 => [internal] load build definition from Dockerfile                                                               0.0s
 => => transferring dockerfile: 32B                                                                                0.0s
 => [internal] load .dockerignore                                                                                0.1s
 => => transferring context: 34B                                                                                0.0s
 => [internal] load metadata for docker.io/library/node:12-alpine                                                  0.8s
 => [dev 1/6] FROM docker.io/library/node:12-alpine@sha256:8fad09b7620b2bc715cbba92e3313c64a797e453f560118576f174  0.0s
 => [internal] load build context                                                                                0.0s
 => => transferring context: 72B                                                                                0.0s
 => CACHED [dev 2/6] RUN apk add --no-cache ffmpeg                                                                 0.0s
 => CACHED [dev 3/6] WORKDIR /usr/src/app                                                                          0.0s
 => CACHED [dev 4/6] RUN npm i -g typeorm                                                                          0.0s
 => CACHED [dev 5/6] COPY package*.json ./                                                                         0.0s
 => CACHED [dev 6/6] RUN npm install                                                                               0.0s
 => exporting to image                                                                                0.1s
 => => exporting layers                                                                                0.0s
 => => writing image sha256:33969ca22b78682d2587143698196cd5c8d48a7290f0514f5b5b91762ef5f182                       0.0s
 => => naming to docker.io/library/jimaku-player_app                                                               0.0s

Use 'docker scan' to run Snyk tests against images to find vulnerabilities and learn how to fix them
[+] Running 4/4
 - Network jimaku-player_default       Created                                                                     0.8s
 - Volume "jimaku-player_postgres"     Created                                                                     0.0s
 - Container jimaku-player_postgres_1  Created                                                                     1.7s
 - Container jimaku-player_app_1       Created                                                                     0.2s
Attaching to app_1, postgres_1
postgres_1  | The files belonging to this database system will be owned by user "postgres".
postgres_1  | This user must also own the server process.
postgres_1  |
postgres_1  | The database cluster will be initialized with locale "en_US.utf8".
postgres_1  | The default database encoding has accordingly been set to "UTF8".
postgres_1  | The default text search configuration will be set to "english".
postgres_1  |
postgres_1  | Data page checksums are disabled.
postgres_1  |
postgres_1  | fixing permissions on existing directory /var/lib/postgresql/data ... ok
postgres_1  | creating subdirectories ... ok
postgres_1  | selecting dynamic shared memory implementation ... posix
postgres_1  | selecting default max_connections ... 100
postgres_1  | selecting default shared_buffers ... 128MB
postgres_1  | selecting default time zone ... UTC
postgres_1  | creating configuration files ... ok
postgres_1  | running bootstrap script ... ok
postgres_1  | performing post-bootstrap initialization ... sh: locale: not found
postgres_1  | 2021-12-21 11:18:42.037 UTC [30] WARNING:  no usable system locales were found
postgres_1  | ok
postgres_1  | syncing data to disk ... initdb: warning: enabling "trust" authentication for local connections
postgres_1  | You can change this by editing pg_hba.conf or using the option -A, or
postgres_1  | --auth-local and --auth-host, the next time you run initdb.
postgres_1  | ok
postgres_1  |
postgres_1  |
postgres_1  | Success. You can now start the database server using:
postgres_1  |
postgres_1  |     pg_ctl -D /var/lib/postgresql/data -l logfile start
postgres_1  |
postgres_1  | waiting for server to start....2021-12-21 11:18:43.144 UTC [36] LOG:  starting PostgreSQL 13.5 on x86_64-pc-linux-musl, compiled by gcc (Alpine 10.3.1_git20211027) 10.3.1 20211027, 64-bit
postgres_1  | 2021-12-21 11:18:43.150 UTC [36] LOG:  listening on Unix socket "/var/run/postgresql/.s.PGSQL.5432"
postgres_1  | 2021-12-21 11:18:43.177 UTC [37] LOG:  database system was shut down at 2021-12-21 11:18:42 UTC
postgres_1  | 2021-12-21 11:18:43.188 UTC [36] LOG:  database system is ready to accept connections
postgres_1  |  done
postgres_1  | server started
postgres_1  | CREATE DATABASE
postgres_1  |
postgres_1  |
postgres_1  | /usr/local/bin/docker-entrypoint.sh: ignoring /docker-entrypoint-initdb.d/*
postgres_1  |
postgres_1  | waiting for server to shut down...2021-12-21 11:18:43.515 UTC [36] LOG:  received fast shutdown request
postgres_1  | .2021-12-21 11:18:43.520 UTC [36] LOG:  aborting any active transactions
postgres_1  | 2021-12-21 11:18:43.521 UTC [36] LOG:  background worker "logical replication launcher" (PID 43) exited with exit code 1
postgres_1  | 2021-12-21 11:18:43.521 UTC [38] LOG:  shutting down
postgres_1  | 2021-12-21 11:18:43.549 UTC [36] LOG:  database system is shut down
postgres_1  |  done
postgres_1  | server stopped
postgres_1  |
postgres_1  | PostgreSQL init process complete; ready for start up.
postgres_1  |
postgres_1  | 2021-12-21 11:18:43.676 UTC [1] LOG:  starting PostgreSQL 13.5 on x86_64-pc-linux-musl, compiled by gcc (Alpine 10.3.1_git20211027) 10.3.1 20211027, 64-bit
postgres_1  | 2021-12-21 11:18:43.676 UTC [1] LOG:  listening on IPv4 address "<IP_ADDRESS>", port 5432
postgres_1  | 2021-12-21 11:18:43.676 UTC [1] LOG:  listening on IPv6 address "::", port 5432
postgres_1  | 2021-12-21 11:18:43.690 UTC [1] LOG:  listening on Unix socket "/var/run/postgresql/.s.PGSQL.5432"
postgres_1  | 2021-12-21 11:18:43.706 UTC [50] LOG:  database system was shut down at 2021-12-21 11:18:43 UTC
postgres_1  | 2021-12-21 11:18:43.717 UTC [1] LOG:  database system is ready to accept connections
app_1       | Error during migration run:
app_1       | TypeORMError: No connection options were found in any orm configuration files.
app_1       |     at new TypeORMError (/usr/local/lib/node_modules/typeorm/error/TypeORMError.js:9:28)
app_1       |     at ConnectionOptionsReader.<anonymous> (/usr/local/lib/node_modules/typeorm/connection/ConnectionOptionsReader.js:38:35)
app_1       |     at step (/usr/local/lib/node_modules/typeorm/node_modules/tslib/tslib.js:143:27)
app_1       |     at Object.next (/usr/local/lib/node_modules/typeorm/node_modules/tslib/tslib.js:124:57)
app_1       |     at fulfilled (/usr/local/lib/node_modules/typeorm/node_modules/tslib/tslib.js:114:62)
app_1 exited with code 1

It says: TypeORMError: No connection options were found in any orm configuration files.
I have tried building an image myself and running it but then I don't have a postgres image and I get the following error when I run it:
Error during migration run:
Error: getaddrinfo EAI_AGAIN postgres
    at GetAddrInfoReqWrap.onlookup [as oncomplete] (dns.js:66:26) {
  errno: 'EAI_AGAIN',
  code: 'EAI_AGAIN',
  syscall: 'getaddrinfo',
  hostname: 'postgres'
}

I have created the following .env file in my project root:
PGUSER=user
PGPASSWORD=password
PGDATABASE=jimaku-player

I don't know what to do now. Any help is very much appreciated!

I think you need to add:
PGHOST=postgres
PGPORT=5432

To the .env file as well, because the app can be run outside of docker in which case you'd use PGHOST=localhost and PGPORT=whatever you want (you'd need to uncomment the port bindings in docker-compose.yml so it will expose the database out of the container).
Additionally instead of just doing docker-compose up you should use ./run.sh dev because it needs to merge two config files (the base docker-compose.yml and either docker-compose.dev.yml or docker-compose.prod.yml). If you're not on linux or something you could probably just do docker-compose -f docker-compose.yml -f docker-compose.dev.yml up --build.
Also, the front end for the dev site expects content in a pretty specific format (an MP4-DASH'd video, and a matching json file  that includes the dash manifest xml, some info about the video itself, and whatever subtitles were extracted from the video). I have a separate project called jimaku-player-ingest for generating these. I think it just works on .mkv source videos at the moment, and I'm pretty sure there are issues if the source video has more than 2 channel audio? Either way it's not really complete at the moment and probably pretty tedious to work with, sorry! Nobody else has been interested in working on it so I haven't improved that stuff in a while.

Actually it looks like those .env config options are the fallbacks in the typeorm config so that part should have worked regardless. I think the issue is the need to run docker-compose merging the two config files.

Sorry for the comment spam, but FWIW I'm planning on doing a major refactor/rewrite somewhat soon so any issues you have now I'll try and fix when I do that.

Okay, so I managed to get both containers to start and run by using ./run.sh dev.
But when I attach a shell to the container jimaku-player-app and try to run npm run build:dev I get this error:
9cc2cc620e3c:/usr/src/app# npm run build:dev

><EMAIL_ADDRESS>build:dev /usr/src/app
> webpack --mode development --watch

webpack is watching the files…

Insufficient number of arguments or no entry found.
Alternatively, run 'webpack(-cli) --help' for usage info.

Hash: 90a9951b0473f336745f
Version: webpack 4.41.6
Time: 50ms
Built at: 12/21/2021 3:03:28 PM

ERROR in Entry module not found: Error: Can't resolve './src' in '/usr/src/app'

And when I look at my container logs in Docker Desktop I see:
query: SELECT * FROM current_schema()
query: SHOW server_version;
query: SELECT * FROM "information_schema"."tables" WHERE "table_schema" = 'public' AND "table_name" = 'migrations'
query: SELECT * FROM "information_schema"."tables" WHERE "table_schema" = 'public' AND "table_name" = 'typeorm_metadata'
query: SELECT * FROM "migrations" "migrations" ORDER BY "id" DESC
No migrations are pending

><EMAIL_ADDRESS>server:dev /usr/src/app
> nodemon server/server.js

[nodemon] 2.0.6
[nodemon] to restart at any time, enter `rs`
[nodemon] watching path(s): *.*
[nodemon] watching extensions: js,mjs,json
[nodemon] starting `node server/server.js index.js`
internal/modules/cjs/loader.js:818
  throw err;
  ^

Error: Cannot find module '/usr/src/app/index.js'
    at Function.Module._resolveFilename (internal/modules/cjs/loader.js:815:15)
    at Function.Module._load (internal/modules/cjs/loader.js:667:27)
    at Function.executeUserEntryPoint [as runMain] (internal/modules/run_main.js:60:12)
    at internal/main/run_main_module.js:17:47 {
  code: 'MODULE_NOT_FOUND',
  requireStack: []
}
[nodemon] app crashed - waiting for file changes before starting...

This error goes away when I add an index.js file in the app root:
[nodemon] restarting due to changes...
[nodemon] starting `node server/server.js index.js`
Hello world
[nodemon] clean exit - waiting for changes before restart

I might have missed a step, maybe I have to add a video to /videos before running ./run.sh dev?
I tried to add an mp4 I had on my drive to /videos while the container was already running to see if something would change but it didn't. I'm thinking that maybe it has to be in that special format you mentioned before.
http://localhost:3500/ does not send any data back and I tried the routes /v, /videos & /image.
I will be grateful for any help you can provide.

I always run the builds on my host machine, and I've never really tried running the builds inside the container. I usually split my terminal up so I can run:

./run.sh dev
npm run build-server:dev
npm run build:dev
all in a column so I can see it all at once.

Out of curiosity, is there something you're looking to do in particular on Jimaku Player?
If you need I could work on generating a demo video/metadata you could use to test stuff.

I intend to work on two things that would be useful to me:
Firstly, I want to fix a bug that makes the subtitles in the subtitle search go out of bounds instead of adding a scroll wheel:

Maybe it has to do with my browser (Chrome), an incompatible extension (Dark Reader, Improve Crunchyroll, Adblock Plus) or that I'm using the Crunchyroll Beta site. I haven't tested these things yet.
Secondly, I want to add a way to input an offset alignment manually:

In my case, this would be useful because I have a list of subtitles for Boruto (LOL) that have 3 different alignments throughout the episode but are similar for each of the episodes.
I would like to collaborate and help out with these things and with your goals if I'm able to.

Ah oops, I guess I hadn't tested Chrome out for that first thing, that's definitely a bug, I don't remember it looking like that!
You can already input an alignment manually, there's a button that's covered up by the subtitle buttons in your first screenshot for that! I actually had a similar problem with One Piece having multiple alignments throughout the episode, which is why there are those "Switch to a previous alignment" buttons along with a preview of what sub is shown then lol. No judgement on Boruto, I've got friends who watch it and I'm considering watching it and Naruto someday.
That'd be cool! I have next week off of work so I was planning on doing a lot of it then. I think it'd be easier to help out once I've done things, as I'll be changing a ton of stuff it'd be hard to collaborate, but after that thing should be more manageable and I'd appreciate any help you're willing to give then! Thanks!

Now I see the manual offset button! ;D
I currently don't have a lot of time because of my midterms until mid-January, so I can't be very active until then.
I also think that it will be easier to help out once you have rewritten things. I will follow your work until then!

@jablazr
I've made most of my big changes now. I still have a few things to do but the bulk of the rewrite is done. I also updated the contributing doc, it was super out of date!
The dev server now supports plain .mp4 files again, no Postgres anymore (so no need for a .env), everything is written in TS, replaced Webpack with Vite (with hot module replacement so your browser auto-updates with changes when developing), I moved a ton of files around, and I updated the general look of things. I still have a few things I want to do in the coming days but it shouldn't be another 120 file commit :wink:
I wasn't able to reproduce that overflow issue you were having though, does that still happen to you with my changes?
Either way, should be more easy to make changes if you're still planning on trying stuff out.

Alright! I will check out the changes and try to get the code running on my machine. I will also see if my overflow problem persists. Thank you for the update!

The subtitles don't overflow anymore :)

I also really like the new UI!

Woo, glad it's fixed, and thanks!


Install Failed:  autoreconf: automake failed with exit status: 1

Ran the install instructions on my RPi4 (Linux rpi 6.1.21-v7).  Install script ended with this:
update-alternatives: using /usr/bin/automake-1.16 to provide /usr/bin/automake (automake) in auto mode
Setting up libglib2.0-dev:armhf (2.66.8-1) ...
Processing triggers for man-db (2.9.4-2) ...
Processing triggers for sgml-base (1.30) ...
Processing triggers for install-info (6.7.0.dfsg.2-6) ...
Processing triggers for libglib2.0-0:armhf (2.66.8-1) ...
Processing triggers for libc-bin (2.31-13+rpt2+rpi1+deb11u7) ...
Setting up libavahi-client-dev:armhf (0.8-5+deb11u2) ...
Setting up libpulse-dev:armhf (14.2-2+rpt1) ...
Cloning into 'alac'...
remote: Enumerating objects: 43, done.
remote: Counting objects: 100% (43/43), done.
remote: Compressing objects: 100% (35/35), done.
remote: Total 43 (delta 7), reused 38 (delta 6), pack-reused 0
Receiving objects: 100% (43/43), 78.32 KiB | 673.00 KiB/s, done.
Resolving deltas: 100% (7/7), done.
aclocal: warning: couldn't open directory 'm4': No such file or directory
libtoolize: putting auxiliary files in '..'.
libtoolize: copying file '../ltmain.sh'
libtoolize: putting macros in AC_CONFIG_MACRO_DIRS, 'm4'.
libtoolize: copying file 'm4/libtool.m4'
libtoolize: copying file 'm4/ltoptions.m4'
libtoolize: copying file 'm4/ltsugar.m4'
libtoolize: copying file 'm4/ltversion.m4'
libtoolize: copying file 'm4/lt~obsolete.m4'
configure.ac:40: installing './compile'
configure.ac:63: installing './config.guess'
configure.ac:63: installing './config.sub'
configure.ac:20: installing './install-sh'
configure.ac:63: error: required file './ltmain.sh' not found
configure.ac:20: installing './missing'
Makefile.am: installing './INSTALL'
codec/Makefile.am: installing './depcomp'
autoreconf: automake failed with exit status: 1

I can play audio through Bluetooth with no issues.

I had the same thing happen just now on a completely clean install of Bookworm fully updated. I had run install-bluetooth.sh and it seemed fine. I got the error on install-shairport.sh
I got the exact same errors, including the m4 directory error.

if I edit out the alac section, it appears to work

Could you try to rename install.sh to something else and run it? I had a similar problem some time ago...
(Unfortunately I cannot test this on Raspbian 12 at the moment, this script was made for Rasbpian 11 Bullseye and may not run at all on Bookworm...)

I just did that and it worked. Thanks! It is documented here: https://github.com/mikebrady/alac/issues/4

Fixed with #163


[WIP] Adding support for Prometheus

Let's use this as a working PR to put together what we'd like future app/addon PR's to look like

We can also enable Calico (Felix) metrics. Maybe as additional conf option, since it's still considered experimental feature AFAIK. In order to do so we need to configure scrape_config section (something like this https://github.com/adidenko/vagrant-k8s/blob/b7d0cf67044735c3ba30e37d40e111a936344c62/playbooks/prometheus-configmap.yaml.j2#L197-L213) and enable Felix metrics server by setting 2 Calico config options via Etcd (no restarts are needed, Felix will implement it on the fly):
etcdctl set /calico/v1/config/PrometheusMetricsEnabled true
etcdctl set /calico/v1/config/PrometheusMetricsPort 9091

If this PR and #1082 will be merged, does it mean then in typical situation there will be two Grafana instances? One from Heapster+Grafana, one from Prometheus-operator.

We could split grafana into an separate role that can be used for both Heapster and Prometheus?

Closing in favor of using helm


Accessibility

The focus states for buttons aren't visible enough.

At the moment, I don't think the buttons even have focus states. Thanks for bringing this to my attention!
What would you suggest for improving accessibility (i.e. how should the focus states look)?

They could just be a box-shadow with a contrasting color that relatively matches the button.


core: fix the ssl verification issue

It is used to fix the SSL verification which should be the default Ture value during scan.

@dongx1x Hi, will this change broke the logic or cause some new issues?

@dongx1x Hi, will this change broke the logic or cause some new issues?

We need to validate this change, it should work for the normal https server, and maybe a certificate should be provided for the self-signed https server.

@Hulongyin Can you help test with the changes to verify if it works or not?

@Hulongyin Can you help test with the changes to verify if it works or not?

Sure, I will verify it.


Problem pane don't show problems

When I typed not existing variable name(typo) or omitted some expression vscode showed me problems. But since yesterday suddenly vscode doesn't show problem in problem pane.
And also when I typed variable name's first few letters it should suggest a list of auto completed variable names or some options like keyword or something, but I didn't see any of it.
I disabled all extensions but it didnt work.
I don't know what is the problem.

It looks like js file only
when writing json file, problem shows me problems about errors

/needsMoreInfo

Sorry for missing info. And I don't major CS and I'm not good at English. So please understand me.
Version: 1.41
OS: Windows 10 pro
Extensions: Without extensions(I disabled all extensions and still have the problems)
When I wrote JS code in .js file the issues came.
If I typed v, it should show me list of keywords that starts with v. But it doesn't show me nothing.
Or if I typo some variable name like userr (correct is user) it should show me a error on problem pane there are no userr variable. But problem pane  shows me nothing.
Below is the screenshot about errors

Some js file (like index.js) shows me a list of auto completed keywords and errors. But my real project doesn't show me errors at all. I'm sorry for not clarifying issues.

@Kang-Jh Can you please share a small example project along with steps to reproduce the problem? This will help us understand if there is a bug in VS Code or if your project needs to be configured

@mjbvz Sorry for late reply. I'm trying to reproduce about this bugs. Now my version is 1.41.1 (previous version was 1.41.0 when I wrote this report.)
https://github.com/Kang-Jh/vscode-bug1.git
above url is github repo for this bugs
I did create new folder for this bugs. and just git init and create readme.txt file and disable all extensions and re-start vscode. So there are no packages or extensions at all.
I couldn't reproduce a list of auto completed keywords like var, let, const or objects like window, document or variables that I defined or etc.
Below picture shows keyword let stands alone with no problem. It doesn't make sense. and I think 1.40.x versions show me errors with this problem.

Below, constant without assigning value still has no problem.

Below, 3rd line shows stand alone keywords. 4th line wrong messages I guess

I think error messages is diffrent from 1.40 versions(It is just my guts. I never saw problem pane thoughtfully and carefully.)
Sorry for not reproducing perfect sample of this bugs. Or is it just me that have this bugs?

@mjbvz Problem pane issues is my mistake. I found out that showing problem in the problems pane that unused variables (as info) and undefined variables but used them in code (as warning) is not built-in features. Is installed extension(ESLint) feature. When I enable ESLint, it solved a issue
But another issue (JS Intellisense issue) is posted #87658  by another user and I commented it too with some my info. Please check #87658


Updating bundled nuget.exe to 4.1.0 to unblock our release process

@davidkwoods,
Thanks for your contribution as a Microsoft full-time employee or intern. You do not need to sign a CLA.
Thanks,
Microsoft Pull Request Bot

:shipit:

https://www.nuget.org/packages/NuGet.CommandLine/

iOS PR build not required because s65 doesn't have the required changes to support it.


Add StatePrep support

Following the work here, we make sure that the pennylane-rigetti plugin supports both operators and defaults to using StatePrep where appropriate until it is deprecated.

[sc-43547]


Fix comments not being applied to increments columns

Addresses #2210
Changes

I first had to remove the explicit check in the getModifiers function that excluded auto-increment columns.

I then abstracted the default column name logic for increments columns to a separate function on the prototype of the generic column compiler. I did this because if a user specified a comment on an increments column with no explicit name, the dialect level comment method could not figure out the default column name. It is implemented with a lookup map for defaults. In the future, if new defaults are added, developers can add a new default key.

Finally, I added a specific assertion in a test case to ensure comments are applied to increments columns in the future

Notes

I added a .vscode/ exclusion to the .gitignore. Visual Studio Code allows developers to set up settings on a workspace basis.

/home/travis/build/tgriesser/knex/src/schema/columncompiler.js
30:1  error  Line 30 exceeds the maximum line length of 100  max-len

Shortened Line Length
Added explicit comment tests for mysql and postgres dialects

This looks great now, thanks!


Add paragraph about cyc

https://github.com/Widdershin/cycle-restart/issues/35

Perfect. Thanks @edge


Synchronize postman collection ids

Synchronizes the ids of the collection to be modified with those of the newly generated collection.
This feature prevents the destination collection from being overwritten. The pull requests are therefore not erroneous (see the updated readme).

hi @Xainon ,
We just saw that you closed the PR? Could you share why?
We were planning on reviewing it, to have it included in the next release.

hi, I have a problem with response objects and I don't see how to manage them. My problem is with responses that do not have an example in their properties and therefore with values generated with a faker. Either I don't replace their ID and when I make a pull request then I have a deletion of the response then a creation, or with the replaceId function I don't have a deletion and modification but a conflict. So I don't see how to deal with this dilemma.

I think the problem can be solved with the exampleParametersResolution in the postman config to disable the faker. Should it default to Schema if my new option is set to true ?

hi @thim81,
after dozens of calls to portman with this option i have not encountered this problem and the elements that have changed following portman are well detected.
Do you see the question I was asking about the sample responses?

I think the problem can be solved with the exampleParametersResolution: Schema in the postman config to disable the faker. Should we force the value to be Schema if my new option(syncPostmanCollectionIds) is set to true ? The SchemaFaker option can solve the problem but is not yet available (here).

Given that to be able to create a "stable" postman collection, it is not ideal that the schema faker function generates new values each conversion, it would make sense to force the disable schemaFaker option when the syncPostmanCollectionIds is used.

A small request, can you also add the new CLI option in the general readme?
If you are building-in the forced disable SchemaFaker, I would mention it with the CLI option in the readme so that the users are aware of the impact.

Do you want me to make the change?
As the option is currently unavailable, it is necessary to set exampleParametersResolution to true so that the type is set to example rather than a faker string.

@Xainon
If it is possible to force the behaviour (without the schemaFaker option being available), like you tried with:

after dozens of calls to portman with this option i have not encountered this problem and the elements that have changed following portman are well detected.

If it is not possible, we need to include it in the read me to guide the users to use the correct configuration.

hi @clement-hvt
The PR looks fine and will be merged.
After the merge, I'm going to move the last changes to an example section to keep the command reference more compact.


Get-DbaBuildReference fix piping issue #4797

Type of Change

[X] Bug fix (non-breaking change, fixes #)
[ ] New feature (non-breaking change, adds functionality)
[ ] Breaking change (effects multiple commands or functionality)
[X] Ran manual Pester test and has passed (`.\tests\manual.pester.ps1)
[ ] Adding code coverage to existing functionality
[ ] Pester test is included
[ ] If new file reference added for test, has is been added to github.com/sqlcollaborative/appveyor-lab ?
[ ] Nunit test is included
[ ] Documentation
[ ] Build system

Purpose

Parameters don't seem to be bound within the begin section of a function when piping. Moved the whole 'region verifying parameters' section from begin to process and it works.
Approach

Screenshots

great move, thank you! 💯


[ISSUE #647]🚧Enhance the functionality of BrokerStatsManager-4

Which Issue(s) This PR Fixes(Closes)

Fixes #647
Brief Description

How Did You Test This Change?

Summary by CodeRabbit

New Features

Introduced a StatisticsItemPrinter to handle printing statistics items with formatting.
Added a new account_stat_manager field to BrokerStatsManager for better statistics management.

Improvements

Enhanced BrokerStatsManager initialization and setup methods to support new statistics kind metadata.

🚀Thanks for your contribution🎉. CodeRabbit(AI) will review your code first🔥

🚀Thanks for your contribution🎉. CodeRabbit(AI) will review your code first🔥

🚀Thanks for your contribution🎉. CodeRabbit(AI) will review your code first🔥


Modals overlap with growlbox error messages

Steps
On develop, in the code for adding a link to a large project, change the submit function so that it fails. I did this by changing this URL to something that does not exist: https://github.com/CenterForOpenScience/osf.io/blob/develop/website/static/js/pointers.js#L95
Expected
I expected the modal to go away, showing the growlbox error message.
Actual
The growlbox error message shows up while the modal is still present, making it difficult to see:

Possible Solutions

Dismiss the modal when an error occurs so that the growlbox can be seen
Show the error message in the modal

All modals on the OSF should be checked for this behavior.

I was expecting that an enterprising intern would take this one on. A simple task repeated, so a good way to learn about variations in bootboxes and knockout and the like.


Fixed bug with error message getting a null pointer on e.getMessage()

https://developer.ibm.com/answers/questions/388685/connecting-own-discovery-collection-to-conversatio/
Not sure whats wrong with this user account, but the null pointer is due to the exception having a null message

Codecov Report

Merging #105 into master will not change coverage.
The diff coverage is 0%.

@@           Coverage Diff            @@
##             master    #105   +/-   ##
========================================
  Coverage      12.5%   12.5%
  Complexity       12      12
========================================
  Files            10      10
  Lines           280     280
  Branches         33      33
========================================
  Hits             35      35
  Misses          238     238
  Partials          7       7

Impacted Files
Coverage Δ
Complexity Δ

...onversation_with_discovery/rest/ProxyResource.java
42.64% <0%> (ø)
7 <0> (ø)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3467442...05aabaa. Read the comment docs.


Updates needed after municipality reform in Norway

Norway changes its administrative borders January 1st 2020. The dataset for the new regions and municipalities was just released. It would be highy appreciated if someone with the knowledge wants to update the topojson files for Norway with these changes.
Regions:
https://kartkatalog.geonorge.no/metadata/f01922f5-bc7b-489f-918c-ca0f789c0dfa
Municipalities
https://kartkatalog.geonorge.no/metadata/f015cd24-a14b-42f3-b695-848cb88d9657

this was  fixed in pull request #33


Content fixes

Remove duplication of SDK section

          1 Warning

:warning:
Found 2 link issues, a project collaborator will take care of these, thanks :)

Link issues by awesome_bot

Line
Status
Link

5
Dupe
https://gitter.im/vsouza/awesome-ios

2697
503
https://boombox.io/

  Generated by :no_entry_sign: Danger

Hey @serhii-londar, nice catch 👍


[ENH] return chroma-trace-id header, include trace ID in thrown errors

Returns a new chroma-trace-id header for both successful and errored responses.
Tested locally with Jaeger.

Yep, if we wanted to make the client the originator we could use this
On Wed, Jul 24, 2024 at 11:35 AM Max Isom @.***> wrote:

Should we follow this convention?
w3.org/TR/trace-context https://www.w3.org/TR/trace-context/
interesting, it seems like this is focused on forwarding trace context
upstream rather than returning it downstream though
—
Reply to this email directly, view it on GitHub
https://github.com/chroma-core/chroma/pull/2570#issuecomment-2248666776,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABKW32JF7BMIN7MMY7UTXPTZN7XWJAVCNFSM6AAAAABLM5FVIOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDENBYGY3DMNZXGY
.
You are receiving this because you commented.Message ID:
@.***>


Update recipe for py312_patch

Preparation for py312 release.

Linter check found the following problems:
The following problems have been found:
ERROR: clone/recipe/meta.yaml:38: incorrect_license: The recipe's about/license key is not an SPDX compliant license or license exception, closest match: BSD-3-Clause
WARNING: clone/recipe/meta.yaml:48: documentation_overspecified: Using doc_url and doc_source_url is overspecified
ERROR: clone/recipe/meta.yaml:48: invalid_url: https://github.com/dabeaz/ply/blob/master/doc/internal.htmls : Not reachable: 404
ERROR: clone/recipe/meta.yaml:48: http_url: http://www.dabeaz.com/ply/index.html is not https
Errors were found

Linter check found the following problems:
The following problems have been found:
ERROR: clone/recipe/meta.yaml:37: invalid_url: https://www.dabeaz.com/ply/index.html : HTTPSConnectionPool(host='www.dabeaz.com', port=443): Max retries exceeded with url: /ply/index.html (Caused by SSLError(SSLCertVerificationError(1, '[SSL: CERTIFICATE_VERIFY_FAILED] certificate verify failed: unable to get local issuer certificate (_ssl.c:1006)')))
ERROR: clone/recipe/meta.yaml:38: incorrect_license: The recipe's about/license key is not an SPDX compliant license or license exception, closest match: BSD-3-Clause
ERROR: clone/recipe/meta.yaml:46: invalid_url: https://www.dabeaz.com/ply/index.html : HTTPSConnectionPool(host='www.dabeaz.com', port=443): Max retries exceeded with url: /ply/index.html (Caused by SSLError(SSLCertVerificationError(1, '[SSL: CERTIFICATE_VERIFY_FAILED] certificate verify failed: unable to get local issuer certificate (_ssl.c:1006)')))
Errors were found

Linter check found the following problems:
The following problems have been found:
ERROR: clone/recipe/meta.yaml:37: invalid_url: https://www.dabeaz.com/ply/index.html : HTTPSConnectionPool(host='www.dabeaz.com', port=443): Max retries exceeded with url: /ply/index.html (Caused by SSLError(SSLCertVerificationError(1, '[SSL: CERTIFICATE_VERIFY_FAILED] certificate verify failed: unable to get local issuer certificate (_ssl.c:1006)')))
ERROR: clone/recipe/meta.yaml:38: incorrect_license: The recipe's about/license key is not an SPDX compliant license or license exception, closest match: BSD-3-Clause
ERROR: clone/recipe/meta.yaml:46: invalid_url: https://www.dabeaz.com/ply/index.html : HTTPSConnectionPool(host='www.dabeaz.com', port=443): Max retries exceeded with url: /ply/index.html (Caused by SSLError(SSLCertVerificationError(1, '[SSL: CERTIFICATE_VERIFY_FAILED] certificate verify failed: unable to get local issuer certificate (_ssl.c:1006)')))
Errors were found


add more statistics

PTAL @zhangjinpeng1987 @siddontang

miss read amplification?

Done. @siddontang

PTAL @zhangjinpeng1987


scalafmt - mostly to ensure joern and ocular versions are identical

looks like scalafmt rules are different between the projects...


Define and document personas

Description

Figure out and describe personas

Cover different roles:  user (operator), content developer (contributor), core contributor

Publish it on our website (maybe in Community subsection) - figure it out

Reason
We should have in a mind target personas to properly document different features, write getting-started guide and tutorials and blog posts.
Links

https://mozillascience.github.io/working-open-workshop/personas_pathways/
https://uxplanet.org/the-reasons-to-create-a-persona-abba501e173
Maybe an inspiration (but not necessarily): https://github.com/kyma-project/community/blob/main/manifesto/personas.md

Current progress

[x] Split community-related files from versioned docs: https://github.com/capactio/website/pull/69
[ ] Create user profiles and personas document


@mixin mat-typography-level-to-styles

Bug, feature request, or proposal:
Bug or proposal
What is the current behavior?
https://github.com/angular/material2/blob/3b41c0c23e10fc74d9f687427f80c46f5da419c9/src/lib/core/typography/_typography-utils.scss#L32
@mixin mat-typography-level-to-styles($config, $level) {
  $font-size: mat-font-size($config, $level);
  $font-weight: mat-font-weight($config, $level);
  $line-height: mat-line-height($config, $level);
  $font-family: mat-font-family($config, $level);

  // Use the shorthand `font` to represent a typography level, because it's the shortest. Notes that
  // we need to use interpolation for `font-size/line-height` in order to prevent SASS from dividing
  // the two values.
  font: $font-weight #{$font-size}/#{$line-height} $font-family;
}

What is the expected behavior?
/ We rewrite the Angular Material mixin because they use the shorthand `font`
// which can't use `inherit` for `font-family`
@mixin mat-typography-level-to-styles($config, $level) {
	$font-size: mat-font-size($config, $level);
	$font-weight: mat-font-weight($config, $level);
	$line-height: mat-line-height($config, $level);
	$font-family: mat-font-family($config, $level);

	font: {
		family: $font-family;
		weight: $font-weight;
		size: $font-size;
	}
	line-height: $line-height;
}

What is the use-case or motivation for changing an existing behavior?
The shorthand font can't use inherit for font-family
// We use 'font-family' on body only and rewrite 'font-family' used Angular Material in components
// It's simple method for translating App and styling whole App
$app-typography: mat-typography-config(
  	$font-family: 'inherit'
);

// Extend Material2 Typography
$font-families: (
	en: (font-family: 'Roboto, "Helvetica Neue", sans-serif'),
	zh: (font-family: 'Roboto, "Noto Sans SC", "Helvetica Neue", sans-serif')
);
$app-typography: map_merge($app-typography, $font-families);

I think it still makes sense to use the shorthand so we can save some bytes, but we can conditionally fall back to the individual properties if the font family is inherit.

PR is #8721


add rest api reference

Docs Build status updates of commit 6e0cb35:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

msteams-platform/bots/how-to/update-and-delete-bot-messages.md
:white_check_mark:Succeeded
View

msteams-platform/resources/bot-v3/bot-conversations/bots-conversations.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

Docs Build status updates of commit 371b507:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

msteams-platform/bots/how-to/update-and-delete-bot-messages.md
:white_check_mark:Succeeded
View

msteams-platform/resources/bot-v3/bot-conversations/bots-conversations.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

Docs Build status updates of commit 52a620f:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

msteams-platform/bots/how-to/update-and-delete-bot-messages.md
:white_check_mark:Succeeded
View

msteams-platform/resources/bot-v3/bot-conversations/bots-conversations.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

Docs Build status updates of commit fa95fe5:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

msteams-platform/bots/how-to/update-and-delete-bot-messages.md
:white_check_mark:Succeeded
View

msteams-platform/resources/bot-v3/bot-conversations/bots-conversations.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

Docs Build status updates of commit 9098d6a:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

msteams-platform/bots/how-to/update-and-delete-bot-messages.md
:white_check_mark:Succeeded
View

msteams-platform/resources/bot-v3/bot-conversations/bots-conversations.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

Docs Build status updates of commit 1e756bc:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

msteams-platform/bots/how-to/update-and-delete-bot-messages.md
:white_check_mark:Succeeded
View

msteams-platform/resources/bot-v3/bot-conversations/bots-conversations.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


AsyncProducer: i/o timeout error when closing (lots of them)

Versions
Please specify real version numbers or git SHAs, not just "Latest" since that changes fairly regularly.
Sarama Version:v1.12  , 55b3f6a77f08038b1e82c3db3c1ce619e46de9b6
Kafka Version:<IP_ADDRESS>
Go Version:1.8.3
Configuration
config.Producer.RequiredAcks = sarama.WaitForAll
config.Producer.Compression = sarama.CompressionSnappy   // Compress messages
config.Producer.Flush.Frequency = 250 * time.Millisecond // Flush batches every 250ms
config.Producer.Retry.Max = 5                            // Retry maximum 5 times
config.Producer.Flush.MaxMessages = 10000
config.Producer.Flush.Bytes = 1024
config.Producer.Return.Successes = true
config.Producer.Return.Errors = true
config.Consumer.Fetch.Min = minMessageSize
config.Consumer.Fetch.Default = defaultMessageSize
config.Consumer.Fetch.Max = maxMessageSize
config.Consumer.Return.Errors = true
config.Consumer.Offsets.Initial = sarama.OffsetOldest
What configuration values are you using for Sarama and Kafka?
Logs
producer/broker/1004 state change to [closing] because EOF\n
"Error while closing connection to broker localhost:9092: write tcp localhost:33268-\u003elocalhost:9092: i/o timeout\n"
Error closing broker -1 : write tcp localhost:33268-\u003elocalhost:9092: i/o timeout\n"
When filing an issue please provide logs from Sarama and Kafka if at all
possible. You can set sarama.Logger to a log.Logger to capture Sarama debug
output.
Problem Description
we see lot of these errors in our sarama logs . Is this due to some messages are missed in publishing or is it because of the configuration parameters we are using are not correct.
There was some reference to this https://github.com/Shopify/sarama/issues/834 do we need to set any specific config from that  .
please advise  or suggest is this some thing to worry about ?

producer/broker/1004 state change to [closing] because EOF

This means the broker closed the connection unexpectedly; there will usually be logs on the broker when this happens explaining what went wrong.

"Error while closing connection to broker localhost:9092: write tcp localhost:33268-\u003elocalhost:9092: i/o timeout\n"

"i/o timeout" means exactly what it sounds like. Either your broker is being very slow to respond, or the connection is flaky (which seems unlikely if the address is on localhost) or you're trying to transfer an enormous amount of data, or...

Is this due to some messages are missed in publishing

I wouldn't think so. Any message that isn't delivered from the producer should be returned on Errors.

is it because of the configuration parameters we are using are not correct.

The configuration you included looks correct to me. You can try increasing config.Net.ReadTimeout and config.Net.WriteTimeout and see if that helps, but I'm not really sure.

mark


Chat - The app fails to display the text as a header within quotation marks

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number: 9.0.67-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team
Action Performed:

Open the app
Open any report
send messages with hash symbol e.g.: > #test

Expected Result:
The app should display the text as a header within quotation marks
Actual Result:
The app fails to display the text as a header within quotation marks
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android: Standalone
[ ] Android: HybridApp
[ ] Android: mWeb Chrome
[ ] iOS: Standalone
[ ] iOS: HybridApp
[ ] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[ ] MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

https://github.com/user-attachments/assets/05415f26-b161-4b9f-a3d1-fee6a96a64d7
View all open jobs on GitHub

This is expected. To create headers you should add a space after the hash symbol 👍

Thanks @FitseTLT!


PP-4969 Upgrade REST Assured library

WHAT YOU DID
Prep for Java11:

Upgraded rest-assured library which also uses transitive dependency groovy-json (version 2.4.15) instead of 2.4.4 which fails on tests for Java 11 (See PR https://github.com/alphagov/pay-adminusers/pull/434 for details)

How to test

CI should pass
Tests should run on Java11

If this works, we should do the same in cardid, publicapi and publicauth


Extendable Elasticsearch queries

What is the motivation for adding / enhancing this feature?

When we are working on more advanced projects. We always need to create some custom stuff in ES queries. Custom aggregations, faceted filters or whole queries, e.g. for category view. It would be amazing if we could easily modify them (maybe from module?). Currently, it requires workarounds which is not a pleasure.
There should be some well-documented standards for that.
I think we should discuss about possibilities and ideas because it looks like big and so useful thing.
What are the acceptance criteria

[ ] Standard for extending queries that VSF uses internally (maybe as one of new hooks?)
[ ] Well documentation of that with use cases (it is essential)

Can you complete this feature request by yourself?

[x] YES
[ ] NO

Which Release Cycle state this refers to? Info for developer.
Pick one option.

[x] This is a normal feature request. This should be available on https://test.storefrontcloud.io and then after tests this can be added to next Vue Storefront version. In this case Developer should create branch from develop branch and create Pull Request 2. Feature / Improvement back to develop.
[ ] (Pick this option only if you're sure) This is an important improvement request for current Release Candidate version on https://next.storefrontcloud.io and should be placed in next RC version. In this case Developer should create branch from release branch and create Pull Request 3. Stabilisation fix back to release.
[ ] (Pick this option only if you're sure) This is a critical improvement request for current Stable version on https://demo.storefrontcloud.io and should be placed in next stable version. In this case Developer should create branch from hotfix or master branch and create Pull Request 4. Hotfix back to hotfix.

there is an option to extend it by adding custom filter in storefront-query-builder https://github.com/DivanteLtd/storefront-query-builder/issues/1#issuecomment-579350403


Might be worth tagging your 1.0.1 release as the latest release.

Homebrew is still pulling the 1.0.0 version as the latest. 👍

Changed by maintainer.

Changed by maintainer.

yes, I've changed it but forgot to comment

yes, I've changed it but forgot to comment


Object.defineProperty(exports ...) is emitted even when exports is not defined

TypeScript Version:  2.3.2
Code
function fn(): void {}
export type MyType = number;

when compiled with a default tsconfig.json emits
"use strict";
Object.defineProperty(exports, "__esModule", { value: true });
function fn() {
}

Expected behavior:
It should not emit
Object.defineProperty(exports, "__esModule", { value: true });

if exports is not emitted in the compiled module.
Actual behavior:
Object.defineProperty(...) is emitted even if exports is not defined for the compiled module. When this code is loaded in a browser, it will throw an exception: Uncaught ReferenceError: exports is not defined.
If the MyType type declaration in the above code is not exported, then Object.defineProperty(...) is not emitted.

what is your target module system?

The default commonjs one for the tsconfig.json generated with tsc --init.

if exports is not emitted in the compiled module.

This isn't how it works. commonjs means there's an exports variable available. You can't run commonjs code directly in a browser.

Ah, I just figured out that I configured my project incorrectly. This whittled down example wasn't the issue as you indicated.
Curious though, why does only the presence of an exported type cause the Object.defineProperty(...) emit?

If it has an export, type or value, it's a module.

Okay, thank you.

I am also facing same issue with the default values of jsconfig.json.   what did you change to resolve this issue?

@Bahetikr If you want to use your transpiled TS in the browser, you could use a module loader like SystemJS.
Example
index.ts
export function fn(): void {
  console.log('fn() called');
}

fn();

index.html
<!DOCTYPE html>
<html>
<head>
  <script type="text/javascript"
    src="https://cdnjs.cloudflare.com/ajax/libs/systemjs/0.20.13/system.js">
  </script>
</head>
<body>
  <script type="text/javascript">
    // index.js is the transpiled index.ts
    SystemJS.import('/index.js');
  </script>
</body>
</html>

If it has an export, type or value, it's a module.

I have no any export, but I imports types only. For what TS exports exports.__esModule in this case?


Typescript

Turn on noImplicitAny and strict in TypeScript type checking.

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 100.00%. Comparing base (9fd922c) to head (572a214).

Additional details and impacted files
@@            Coverage Diff             @@
##              main       #56    +/-   ##
==========================================
  Coverage   100.00%   100.00%
==========================================
  Files            5         5
  Lines         1172      1299   +127
==========================================
+ Hits          1172      1299   +127

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

@gnarea note this set of changes, and that 6.0.3 was just released.
I'm going to stop making fiddly changes on the lib for now, but let me know if this breaks anything of yours, please.


Update TLS doc to use example signer for arbitrary https server

The current doc encourages use of the kubelet-serving signer for arbitrary https serving certificates, which is incorrect.
This updates the doc to use an example signer, and demonstrates how all actors against the CSR API work:

requester submitting CSR
approver
signer
requester retrieving and using the CSR

/sig auth
/cc @deads2k @nckturner

/sig security
BTW build error is that content/en/examples/server-signing-config.json is missing

comments addressed

Thanks for clarifying this @liggitt, this makes a lot more sense now.
I followed the entire tutorial with the new changes and successfully created a CA, signed a server certificate, etc. by using the exact updated commands.
/lgtm

/approve
I'll add the prerequisite in a follow up PR.


FF57+ compatability

Are there any plans to support Firefox 57+?

BBT lives where zotero lives, and zotero only has standalone these days: https://www.zotero.org/blog/zotero-5-and-firefox-faq/
So no, no FF57 support, because Zotero can't have FF57 support, so by extension I can't.


Update README

The CONTRIBUTING markdown file failed to be rendered and only shown as plain text.

Thanks :)


fix empty object literal blue click infinite loop

Description
Fix - when an empty object literal is blue clicked, then a sample key value pair { 'foo' : VALUE } is added

resolved


Integrate IOTA as a paymethod

Standalone prototype completed. Let's see how to integrate into the real firmware


environment variable issues

tony at penguin in ~/cue/gerrit on (no branch)▲
$ env | grep GOCACHE
GOCACHE=/home/tony/.cache/go-build
tony at penguin in ~/cue/gerrit on (no branch)▲
$ gopium ast_go cuelang.org/go/internal/core/adt memory_pack
Error: visiting error happened err: exit status 1: stderr: build cache is required, but could not be located: GOCACHE is not defined and neither $XDG_CACHE_HOME nor $HOME are defined

the other ENV VARs are in my environment as well

Hi @verdverm you can pass env variables to gopium via  -e, --package_build_envs strings Gopium go package build envs, additional list of building envs is expected. cli flag (gopium -e "GOCACHE=/home/tony/.cache/go-build" ast_go cuelang.org/go/internal/core/adt memory_pack should work for you). Env variables implemented via flag to be easy integrated with vscode extension using "gopium.packageBuildEnvs" key in settings.json and because underlying  type parser typepkg.ParserXToolPackagesAst uses exactly the same array format anyway.

Btw I just checked latest gopium binary because I was curious why you even need to setup custom GOCACHE env. And I believe I found an issue. So If you install gopium via extension or inside gomodule it will work as expected. But If you try install gopium outside of any gomodule (let's say just in GOPATH) it will throw an error Error: visiting error happened err: exit status 1: stderr: build cache is required, but could not be located: GOCACHE is not defined and $HOME is not defined and won't work without  -e "GOCACHE=/Users/default/Library/Caches/go-build" -e "GOPATH=/Users/default/dev". Which sounds really weird to me 😞 I need to read what is the difference between installed binary from gomodule and outside of it.

UPD the most weird piece is if I just install gopium from source code with cd $GOPATH/src/github.com/1pkg/gopium && go install it works without extra GOCACHE and GOPATH envs. I would think that go get should do exactly same: download + install ... but it seems something is off for non gomod scenario.

Okay I read go get docs, I couldn't find what can cause the issue ...  for now I created a bandage that will set default GOCACHE and GOPATH values if no env variables were provided. Should be good enough as default if you still need override defaults it could be done via -e flag. I tested it on my local machine: now both go mod installation and GOPATH installation works as expected.

GOPATH is deprecated as Go continues to embrace modules. There is a new directory, typically in $HOME/go, where Go stores stuff

GOPATH is deprecated as Go continues to embrace modules. - this is the fact.
However there are two things say here:

when you install package globally, for example using  go get github.com/1pkg/gopium inside $HOME, it still will be installed into $GOPATH
gopium uses packages.Load from golang.org/x/tools/go/packages that requires both GOCACHE and GOPATH vars set
So simplest solution for now - just artificially set them.

I don't have any GO* environment variables set. Go uses its own defaults
$ go env
GO111MODULE=""
GOARCH="amd64"
GOBIN=""
GOCACHE="/home/tony/.cache/go-build"
GOENV="/home/tony/.config/go/env"
GOEXE=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="linux"
GOINSECURE=""
GOMODCACHE="/home/tony/go/pkg/mod"
GONOPROXY=""
GONOSUMDB=""
GOOS="linux"
GOPATH="/home/tony/go"
GOPRIVATE=""
GOPROXY="https://proxy.golang.org,direct"
GOROOT="/usr/local/go"
GOSUMDB="sum.golang.org"
GOTMPDIR=""
GOTOOLDIR="/usr/local/go/pkg/tool/linux_amd64"
GCCGO="gccgo"
AR="ar"
CC="gcc"
CXX="g++"
CGO_ENABLED="1"
GOMOD=""
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -fmessage-length=0 -fdebug-prefix-map=/tmp/go-build732687623=/tmp/go-build -gno-record-gcc-switches"

$ env | grep GO

Yes but that doesn't change the fact that for some reason for gopium that was goget globally those variables (even go default ones) are not propagated properly to packages.Load golang.org/x/tools/go/packages. I have 0 clue why it's happening only for goget global installation but it's really hard to debug. So I would say current fix with proactive set of env vars for a packages.Load parser is a small enough evil to justify.
Please try update your gopium binary with go get -u github.com/1pkg/gopium it should all work now.

I will consider this fixed then.


gnome-maps: add webkitgtk to buildInputs

Motivation for this change
Per #17143 on GitHub, gnome-maps currently fails due to missing
Webkit2. Adding webkitgtk to buildInputs fixes the issue. Fixes #17143.
Things done

[x] Tested using sandboxing
(nix.useSandbox on NixOS,
or option build-use-sandbox in nix.conf
on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] OS X
[ ] Linux

[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[x] Fits CONTRIBUTING.md.

Looks good to me.

It compiles, but when I try to run this application, I get:
$ gnome-maps
(org.gnome.Maps:29131): GLib-GObject-WARNING **: cannot register existing type 'GIRepository'
(org.gnome.Maps:29131): GLib-CRITICAL **: g_once_init_leave: assertion 'result != 0' failed
(org.gnome.Maps:29131): Gjs-WARNING **: JS ERROR: Error: Unsupported type (null), deriving from fundamental (null)
init@resource:///org/gnome/gjs/modules/package.js:155
start@resource:///org/gnome/gjs/modules/package.js:175
@/nix/store/1fv46xvh1jlzcdq604hl44ws99v8lkfx-gnome-maps-3.20.2/bin/.gnome-maps-wrapped:5
JS_EvaluateScript() failed

Note that for gnome 3.20 the newest version of gnome-maps is 3.20.3. I didn't test it, but it may be worth updating.
I can only confirm that gnome-maps works on 3.22.

@Mic92 I'm not able to reproduce that error locally. If you can help me reproduce it, I'm happy to debug.

@groxxda Agreed that gnome-maps should be updated to the latest version, I'll work on that. That said, if maintainers decide to merge this before I get that change made, this PR should still result in a usable application.

Pushed to master (ecd41c19b85852c7400ba9af7b24d8365bc91ecc) and release-16.09 (37d17e9dd05c50af69b70ad3c5471514147a891a). Thanks! (NixOS 16.03 has a different GNOME version, so the patch didn't apply.)

Ok, it was trivially to backport to release-16.03: fa2e6fec02084b9cb3d8ff6bfa3179d60dc6cd4b. But on NixOS 16.03, we have gnome-maps 3.18.2 that the tile access issue ("MapQuest: As of July 11, 2016, direct tile access has been discontinued.") But at least the application starts :-)


Select input shows option items as White on White

Hi Team,
Great work on the template.
I am facing two issues while using the template for personal use:
1. Input Select options display White on White when open

Markup:

	        SELECT ITEMS
	        <select class="form-control">
	            <option>Item 1</option>
	            <option>Item 2</option>
	            <option>Item 3</option>
	        </select>

2. The focus color on the input control is always set to the pink, even if the Blue theme is selected
Highlighted rectangle in the screenshot above.
Please assist.

Hello webakshar,
Thank you for the interest in our products.
For the first problem, please add a darker color for the form-control:
.form-control{
color: #949494;
}
For the second problem, this is the default color of the input on focus. You change it doing the following change:
.form-control:focus{
border-color: #1d8cf8;
}
If i can help you with anything else, please let me know.
Best,
Rares

Hi,
I've got the same issue with the white on white dropdown menu.
Here what i've changed :
.form-control {   display: block;   width: 100%;   height: calc(2.25rem + 2px);    padding: 0.5rem 0.7rem;   font-size: 0.875rem;   font-weight: 400;   line-height: 1.428571;   color: #949494;   background-color: #27293D;   background-clip: padding-box;   border: 1px solid #cad1d7;   border-radius: 0.25rem;   box-shadow: none; }


Implement weather data retrieval method

A getWeather() method is a foundational method for how we will retrieve weather data to display to the user. For now, a simple temperature readout will suffice, and further aspects of weather data (wind speed, humidity, highs and lows) can be added later on in the form of compartmentalized subroutines.

Completo


Other requests from this IP also matches IP addresses for which this IP is a substring of

For example, <IP_ADDRESS> will also return <IP_ADDRESS>.
Relevant code is the LIKE clause of this query:
https://github.com/enwikipedia-acc/waca/blob/7972f26f2bdc4e55244d997bb4a7a2d5e69eaed5/includes/DataObjects/Request.php#L323-L326

Per @stwalkerster on IRC:
we should probably change it to an RLIKE which matches either $ or ,  at the end of the IP
I suspect that may have performance impact though
the decent fix would be to store the data in that field a little better, so we don't have to do substring checks which are nasty for indices

Storing the IPs as rows in a new table is definitely the better solution here.
On that note, PostgreSQL has an inet column type which can handle searching CIDR ranges etc directly in the database...

Incorrectly closed issue


Reland: "Update outdated runners in the benchmarks folder (#91126)"

Description
This reverts commit b412f6fff89e161a2d56e1b4cfc572d7eede2c3a (#92106), and fixes the build issues for Android builds.
original description:

This PR updates the platform runners in the benchmarks subdir.

I've attempted to replace the entire group with new code as if the project were recreated with flutter create so that they don't become a Frankenstein of minor changes to make it work again, but just plain old generated code that can be replaced and updated in place.

Tests

No tests because we're just updating boilerplate here.

There are some conflicts unfortunately

@blasten, could you take another look, I've resolved the conflicts.

Gold has detected about 20 new digest(s) on patchset 4.
View them at https://flutter-gold.skia.org/cl/github/92535


Fix low glucose suspend

One of the changes merged to dev from the pushover branch attempted to disable low glucose suspend mode when IOB was highly negative, but that change went too far and mostly disabled LGS.  This fixes LGS to only be disabled when IOB is already super negative and BG is rising faster than predicted (such as from a meal eaten after a long period of zero temping).  It also adds that information to the reason field when disabling LGS.

Can you add test cases to prevent LGS from failing in the future?

I could, but with m the current unit test framework all unit tests are by their nature incomplete, and take a lot more effort to write and continually update every time we change anything than they save in end-to-end testing. If anyone want to volunteer the time to figure out a way to do more real-world situation-playback testing, that would be useful...

Would an diabetic simulator help with testing? That is a function that took insulin and food inputs and returned a glucose value? You could put openaps between the glucose output of the simulator and the insulin input.

We installed it last night. Stayed suspended with a significant amount of neg iob during night. Would momentarily start a temp basal with a climb, but as soon as BG leveled off or dropped, it suspended basals again (appropriately)


Writing files to USB from serial

Hi,
I'm trying to write files from serial port on my Elegoo Mars (model without ethernet port), but i'm stuck, i start to think that it's not possible (https://www.elegoomars.com/forum/showthread.php?tid=150&pid=1575#pid1575).
I managed to dump the firmware from the mainboard to explore it.. but it's too difficult for me..
Did you also try ?
M28 command don't act the same as on an Elegoo Mars Pro

The created file is always empty..

Hey! I'm excited you found this repo 😄
I'm cleaning it up to hopefully make a first release soon. This is basically a Web UI for controlling the Elegoo Mars Pro. We could try to get it to work with the Mars if you're interested to help with that.

To your question: I actually haven't tried uploading with M28 even on the Mars Pro.
I've been using Linux's USB Gadget Mode through the g_mass_storage module to share files with my Mars Pro' mainboard through the USB port.
I've found that to be a bit easier to work with, since I can read/write files from the Raspberry Pi itself easily with Python (which has allowed me to upload files remotely with a Web UI).
Have you tried using USB Gadget Mode? I'm planning on writing a tutorial (let me know if that would be helpful), but Adafruit's tutorial on the Pi Zero USB Gadget Mode is a good start.

You're right it could be solve with a Pi Zero and USB Gadget mode and probably no one would like to control an Elegoo Mars from USB (to serial) but  more by the network.. that's because g_mass_storage is a trick for me more than a solution : you have to remount the share folder at every file's change. Someone has made a post about that [here}(elegoomars.com/forum/showthread.php?tid=399) & Python script here. In fact a Zero Pi will be in my Elegoo Mars .. but i'd rather if the oly storage is the USB flash drive. And yes, of course if i could help.
The Pro you have is ethernet capable ?

you have to remount the share folder at every file's change

You don't actually have to remount the share folder on every file change. At least I don't have to with my setup. I've updated the README.md of this repo with some rough instructions on the setup I have.

The Pro you have is ethernet capable ?

No, not at all. I think no Pros have ethernet. I'm just using the serial port like you are. The only difference is I don't use the serial port for uploading files (since I don't see the need for it).
I also keep my Pi Zero W within the printer itself and power it through the printer's power supply, so the entire setup feels super clean.

Wow great !! Thanks a lot Ruiz, that's perfect and your UI is really nice.. you just convince me !

You have been faster than me : i went to put a link to your Github on Elegoo's forum and you had already done it :)

sudo apt update && sudo apt install libxslt1.1

haha :) Let me know if you are able to get it running on the original Elegoo Mars. Happy to make any changes to the code if needed to support it properly

sudo apt update && sudo apt install libxslt1.1

Ah yes. There's a few dependencies for the .deb that need to be installed first. Should I update the README.md with those?

Ah, actually there's at least one feature we need to add support for to get the Elegoo Mars to work: .cbddlp files.
Let me file an issue for that, maybe I'll have some time for it later tonight or next weekend.

Yes for me that's the only dependencie to make the deb install.. After the changes in cmdline.txt and config.txt the pi is stuck during the boot after SD mount.. strange

That sounds about right. I'm using buster too.
What does your cmdline.txt look like? Here's mine after all changes:
console=tty1 root=PARTUUID=18b5dae3-02 rootfstype=ext4 elevator=deadline fsck.repair=yes rootwait modules-load=dwc2

The install instructions I wrote on the repo are also trying to do everything at once. That may be a bit too much. Maybe you can try setting things up one by one to see where the system becomes unusable?

https://www.raspberrypi.org/forums/viewtopic.php?t=264296
That's a clue, no ?
you're right :

First boot OK
marina3d install & reboot OK
dtoverlay=dwc2 > /boot/config.txt  & dwc2 > /etc/modules (for testing) & reboot OK
piusb.bin & fstab & reboot KO

Stuck during piusb.bin's mount because it is not formated, no ?

Oh yeah you're totally right. I forgot that on the instructions! Does that fix the issue you're running into?

It would be nice to identify the printer model by the firmware version (and also showing the version) with M4002

I will try a print later (the mainboard is on my desk for testing), but why would it be different : the GCODE you use are common between pro and non pro.. and i could generate and print CTB files on my Elegoo Mars !

It would be nice to identify the printer model by the firmware version (and also showing the version) with M4002

Is that possible? My firmware version on the Mars Pro is V4.3.4_LCDC (according to M4002).
M115 (which supposedly returns when the firmware was built) gives me: CBD make it.Date:Apr  2 2020 Time:16:30:35
Maybe we can map firmware versions to printers to detect them? Filed #64 to look into that. Feel free to add your own observations from the original Mars to that issue.

i could generate and print CTB files on my Elegoo Mars !

I'm not sure if that's possible, as far as I know the Elegoo Mars only supports .cdbdlp? Unless one of the more recent firmwares adds supports for .ctb too....
If .ctb doesn't work, I think you might be able to get it to print by doing this:

Upload a .cdbdlp
Open it on the file browser from mariner
The file details won't show (we only support .ctb files for now)
You might still be able to hit print regardless of that. Print status might be super wonky/broken because we won't be able to read the .cdbdlp metadata to know which layer is currently being printed

According to the Elegoo Forum there are 3 version of Mars : ORIGINAL with ethernet port, STANDARD and PRO have the same mainboard.

Original up to V<IP_ADDRESS>_LCDM
Normal up to 4.3.4_LCD(F/M/C?)
Pro up to 4.3.4_LCDC

So no, there's no way to identify model by version..
We have the same firmware / mainboard so for the CTB that ok

I had upgraded my Elegoo Mars to v4.3.4 (from v4.3.2) to match yours : First i tried to upload the 2 files (update.SH4, ALFPGA213_SPI_MIPI_P316_CTB_1440P_140M_FF.CBD) with the UPLOAD button of Mariner3D but your filter disable that.. so i SCP the 2 files to /mnt/usb_share.. then (i'm scare of nothing) i print the 2 files (that's the upgrade method) .. and now i'm also in v4.3.4. But i had to delete the 2 files before beeing able to list the file content from Mariner3D.

But i had to delete the 2 files before beeing able to list the file content from Mariner3D.

Ahh, good catch. I filed #74 to fix that.

@dadwarf, going to close this issue since I think we were able to get this working on your printer? Feel free to open more issues if there's more things you would like to see or if you run into more problems!


Question: reconnect

Hi, I want some help. I wrote a steam bot with node-csgo, and sometimes randomly disconnect from steam, and crash. Can you help for me to handle this type of error and reconnect to steam and also restart? node-csgo.
Last log:
2 May 01:06:35 - node-csgo unready.
events.js:160
throw er; // Unhandled 'error' event
^
Error: Disconnected
at SteamClient._disconnected (/xxx/node_modules/steam/lib/steam_client.js:186:24)
at emitOne (events.js:96:13)
at Connection.emit (events.js:188:7)
at TCP._handle.close [as _onclose] (net.js:509:12)
Can you help for me?

var steamClient = new Modules.steam.SteamClient();
steamClient.on('error', function(error) {
if (steamClient.loggedOn == false) steamClient.connect();
});

You handle it by adding an event handler for the 'error' event'.


String change

Change "Add Configure Preset" to "Add Configuration..." to reflect current product behavior

@esweet431 : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@corob-msft : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@esweet431 Thanks, Erika!


Skip TestCreateSimulatedEffectivePom only when java command not exist

Skip TestCreateSimulatedEffectivePom only when java command not exist.
Add "-v" when run "go test".

Closing current PR, because related change has been contained in this PR: https://github.com/azure-javaee/azure-dev/pull/99


npm friendly version of babylon.canvas2d.d.ts

Please add module version of babylon.canvas2d.d.ts so we can do things like:
import { ScreenSpaceCanvas2D } from "babylonjs/babylon.canvas2d";

Hello fancy doing the PR?

Up?


Rely on reset-css package

I think it would be a good idea to just use the reset-css package directly instead of having a separate reset.
There might be different ways to do this instead of using preval, but I thought this was a pretty nice solution overall.

Thanks! This makes sense. I'd never seen preval before, that's neat!

Published in v1.3.0


Include screenshot in readme

A screenshot should be included in the readme to give an idea of what the client looks like

There is a video of how it's work on website link


added knownips

#21  👈
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @leonchike and the rest of your teammates on  Graphite


Is data available？

Is the data used in this available？

Considering the privacy of our data collected from hospitals, we cannot directly disclose the data on the website.


Re-enable OSMOSIS_RPC_OVERWRITE and OSMOSIS_REST_OVERWRITE

In https://github.com/osmosis-labs/osmosis-frontend/pull/3068, I had to manually override the endpoints used by the frontend to test my new one. Previously, we could override them using the OSMOSIS_RPC_OVERWRITE and OSMOSIS_REST_OVERWRITE environment variables, as seen here: https://github.com/osmosis-labs/osmosis-frontend/blob/stage/packages/web/config/env.ts#L3-L6.
Could we ensure that we maintain the ability to specify endpoints?

From what I can tell, #3068 updated URLS only in tests and in mock data for tests.
It appears those overwrite vars are still getting used, and are applied at our chain list generation (pre build step):
https://github.com/osmosis-labs/osmosis-frontend/blob/1c3972730d92a8fb348f44833d19e23483c8dccc/packages/web/config/utils.ts#L347-L354

@niccoloraspa have you tried NEXT_PUBLIC_OSMOSIS_RPC_OVERWRITE and NEXT_PUBLIC_OSMOSIS_REST_OVERWRITE?

Yes, via vercel environment variables

This is the project where I tried: https://vercel.com/osmo-labs/osmosis-frontend-dev/settings/environment-variables

Now I see the endpoints I have specified being used, yesterday was not the case. I also made sure to rebuild the project, so not sure what happened but I think we can close this issue.


Upgrade to Rails <IP_ADDRESS>

In response to
https://groups.google.com/forum/#!topic/rubyonrails-security/ly-IH-fxr_Q

:+1: merge away


Question on efficient model counting

Hi,
Is there an efficient way to count models? The way I am doing now is simply enumerating through all possible models, e.g.
def count(_):
  global x; x += 1

import clingo

C = clingo.Control(["0"])
C.add("base", [], "{a; b; c; d}.")
C.ground()
x = 0
C.solve(on_model = count)

but I was wondering if clingo had a smarter and more efficient way to do this, as I only need the number of models for a program, and not the actual models. I looked at the documentation and couldn't find an option to only do model counting.
Thanks
PS: Thanks for developing and maintaining clingo! :)

Our solver can only count models by enumerating all of them. You can probably avoid some overhead by not passing an on_model callback and simply extract the number of enumerated models from the statistics. There is some work on more clever ways to count models. Maybe @daajoe can give some pointers because he was working on this topic.

I see. Thanks for the quick reply!

You can probably avoid some overhead by not passing an on_model callback and simply extract the number of enumerated models from the statistics.

I'm actually writing everything in C, so no callbacks. Is it wrong of me to assume that passing clingo_solve_mode_yield and doing the counting within the clingo_solve_handle_model loop should be as fast as just querying from the statistics map? Or is there a more efficient way?

Great. Thanks for the info. :)
Closing my question now.


Rename hypothesis-core to fabric8-hypothesis-core

fabric8-hypothesis-bug-id: fabric8-hdd/fabric8-hypothesis-planning#4
Signed-off-by: anmolbabu<EMAIL_ADDRESS>

LGTM


Add support for github.com/pkg/errors interfaces

This PR adds support for two interfaces, implemented by the github.com/pkg/errors package:

The causer interface, which allows unwrapping errors which were wrapped by this package, to find the underlying cause.
The stackTracer interface, which works in spirit the same as the Stacktracer interface introduced by https://github.com/evalphobia/logrus_sentry/commit/162f5c6ab032c7151ea4129cc1d2f22ace3d9a55

Coverage increased (+5.6%) to 65.649% when pulling 8ab1ab00992f46b9afb46fc1e85349d60e467a2d on flimzy:pkgerrors into 16401a02b5b34a236a2feb04ced6bbcb4aec8900 on evalphobia:master.

One possible improvement could be made on this PR, and if requested, I'm happy to implement the changes. And that is that by using the causer interface, it becomes possible to report multiple exceptions, which Sentry supports. Thus, in principle, we could go through all wrapped errors, and generate a Sentry exception interface for each one.
The only reason I didn't do this right away is that for my own application, and possibly for others, all that we really care about is the causing error. The various wrappers around it are often/usually extraneous, and would present duplicate information.

Coverage increased (+4.8%) to 64.844% when pulling efdf33a6c9b6d4b6410cfe47eb73f6fe46fe746e on flimzy:pkgerrors into 16401a02b5b34a236a2feb04ced6bbcb4aec8900 on evalphobia:master.

Coverage increased (+4.8%) to 64.844% when pulling efdf33a6c9b6d4b6410cfe47eb73f6fe46fe746e on flimzy:pkgerrors into 16401a02b5b34a236a2feb04ced6bbcb4aec8900 on evalphobia:master.

Coverage increased (+4.8%) to 64.844% when pulling e5cf1f5ac2d544b4f3739eb085d7b65e31cebac8 on flimzy:pkgerrors into 16401a02b5b34a236a2feb04ced6bbcb4aec8900 on evalphobia:master.

Coverage increased (+4.8%) to 64.844% when pulling e5cf1f5ac2d544b4f3739eb085d7b65e31cebac8 on flimzy:pkgerrors into 16401a02b5b34a236a2feb04ced6bbcb4aec8900 on evalphobia:master.

Coverage increased (+4.8%) to 64.844% when pulling e5cf1f5ac2d544b4f3739eb085d7b65e31cebac8 on flimzy:pkgerrors into 16401a02b5b34a236a2feb04ced6bbcb4aec8900 on evalphobia:master.

I'm not quite sure what to make of the Travis build errors. The seem sporadic, and possibly unimportant?

Coverage increased (+4.8%) to 64.844% when pulling d0adf546fcb25ab26099c0cfb15d18e46f4a82ca on flimzy:pkgerrors into 16401a02b5b34a236a2feb04ced6bbcb4aec8900 on evalphobia:master.

@flimzy Thanks!  🐎

Note: https://github.com/evalphobia/logrus_sentry/releases/tag/v0.2.4


changeable hud

if you turn on logover it will render logo with version crazy

I dont know how github works how do I implement this to my pull req

Just make another commit where you fix it, the PR will be updated.

I think i did it


Add LocalHorizontalCoordinateSystem constructors taking ECEF<->Local matrices.

These matrices are the actual data representation of the class. It's helpful to have these for some refactoring I'm doing in Cesium for Unreal.

This is ready for another review.


[Bug]: eks_blueprints.module.aws_eks.aws_security_group.node not being deleted properly due to orphaned ENI(s)

Welcome to Amazon EKS Blueprints!

[X] Yes, I've searched similar issues on GitHub and didn't find any.

Amazon EKS Blueprints Release version

a421b980c5c7c665ff5c42a805dbe07ecf232d5b

What is your environment, configuration and the example used?

terraform 1.2.3

module "eks_blueprints" {
  # aws-ia/terraform-aws-eks-blueprints
  source = "github.com/aws-ia/terraform-aws-eks-blueprints?ref=a421b980c5c7c665ff5c42a805dbe07ecf232d5b"

  tags                 = local.tags
  cluster_name = local.cluster_name

  # KMS
  cluster_kms_key_additional_admin_arns = local.cluster_kms_key_additional_admin_arns

  # Auth
  map_roles               = local.map_roles
  application_teams = var.application_teams
  platform_teams     = var.platform_teams

  # EKS Cluster VPC and Subnets
  vpc_id                      = var.vpc_id
  private_subnet_ids = var.private_subnet_ids

  # EKS CONTROL PLANE VARIABLES
  cluster_version                               = var.cluster_version
  cluster_endpoint_private_access = false
  cluster_endpoint_public_access  = true

  # EKS MANAGED NODE GROUPS
  managed_node_groups = local.managed_node_groups

  # Change these according to your security requirements if needed
  node_security_group_additional_rules = local.node_security_group_additional_rules
}

What did you do and What did you see instead?

After a successful apply:

$ terraform destroy
...
module.eks_cluster.module.eks_blueprints.module.aws_eks.aws_security_group.node[0]: Still destroying... [id=sg-045d4f0919f27419e, 15m0s elapsed]

│ Error: Error deleting security group: DependencyViolation: resource sg-045d4f0919f27419e has a dependent object
│ 	status code: 400, request id: 7190c7d2-5a08-4415-a9d1-9c56585c08a1

They appear to have been attached to some of the instances from the managed node group, but there is not an ENI for each node that was in the cluster.
At this point, I have tested this twice and ended up with one or two leftover ENIs, which I had to clean up by hand to get the security group to delete.
Additional Information
The core issue may actually be an issue in the upstream aws-eks module.

https://github.com/terraform-aws-modules/terraform-aws-eks

This may be related to a known issue - please see https://github.com/aws-ia/terraform-aws-eks-blueprints/blob/main/KNOWN_ISSUES.md#timeouts-on-destroy

Also see https://github.com/aws/amazon-vpc-cni-k8s/issues/1447

closing out issue - please track https://github.com/aws/amazon-vpc-cni-k8s/issues/1447 for updates


Remove use of awk

It appears that only two places use awk, and their uses are trivial to
replace with grep or cut. this would allow to drop awk from the image.

@dirkmueller , what is the rationale behind removing awk use? I believe awk is widely used and extracting field data in whitespace-separated output reads easier when awk is used over more complex regex with grep.
I know awk doesn't come standard with SLE BCI base image, but it's a quick install to get it added.

@snasovich simply from the principle of "less (code) is more". the first occurrence combined grep, awk and cut to extract a single field from a line of text. grep can do that directly, saving awk and cut. Yes, it does use a bit of a complex regular expression, but I don't believe many people will dive into the detailed line very often, readers stop at "ah this gets the ip address".
the 2nd invocation was just splitting, and cut can do that as well. fewer code, fewer dependencies, smaller containers.

I'd rather just leave the awk usage as it's quite straightforward for anyone to understand or maintain the script.  Honestly I think awk should be in BCI by default.  I personally would expect sed, grep, awk to be in any Linux environment by default.

Great, closing this then.


0036 - Valid Sudoku

Description of the Problem
Determine if a 9 x 9 Sudoku board is valid. Only the filled cells need to be validated according to the following rules:

Each row must contain the digits 1-9 without repetition.
Each column must contain the digits 1-9 without repetition.
Each of the nine 3 x 3 sub-boxes of the grid must contain the digits 1-9 without repetition.

Note:

A Sudoku board (partially filled) could be valid but is not necessarily solvable.
Only the filled cells need to be validated according to the mentioned rules.

Example 1
Input: board =
[["5","3",".",".","7",".",".",".","."]
,["6",".",".","1","9","5",".",".","."]
,[".","9","8",".",".",".",".","6","."]
,["8",".",".",".","6",".",".",".","3"]
,["4",".",".","8",".","3",".",".","1"]
,["7",".",".",".","2",".",".",".","6"]
,[".","6",".",".",".",".","2","8","."]
,[".",".",".","4","1","9",".",".","5"]
,[".",".",".",".","8",".",".","7","9"]]
Output: true

Example 2
Input: board =
[["8","3",".",".","7",".",".",".","."]
,["6",".",".","1","9","5",".",".","."]
,[".","9","8",".",".",".",".","6","."]
,["8",".",".",".","6",".",".",".","3"]
,["4",".",".","8",".","3",".",".","1"]
,["7",".",".",".","2",".",".",".","6"]
,[".","6",".",".",".",".","2","8","."]
,[".",".",".","4","1","9",".",".","5"]
,[".",".",".",".","8",".",".","7","9"]]
Output: false
Explanation: Same as Example 1, except with the 5 in the top left corner being modified to 8. Since there are two 8's in the top left 3x3 sub-box, it is invalid.

Code
class Solution:
    def isValidSudoku(self, board: List[List[str]]) -> bool:

Link To The LeetCode Problem
Valid Sudoku

@vJechsmayr Please assign this issue to me. Will be happy to contribute.

@vJechsmayr Happy to give a python solution to. Big fan of Sudoku.

I like to work on this.Could you please assign me on this?

@Dave-Browne @Kishore-abhimanyu The Creator of the Issue will be prefered to assignment


A notice being generated on $this->Form->input(... ['type' => 'checkbox'])

Bootstrap helper version:  "holt59/cakephp3-bootstrap-helpers": "dev-v4.0.0-alpha", (latest as of 2017-02-08)
PHP version: 7.1
Cakephp version: 3.3.14
When doing
$this->Form->input('xxxxx', ['label' => __('yyy'), 'type' => 'checkbox']).

Im getting a functional checkbox but a Notice is issued:
Notice (8): Undefined index: input [ROOT/vendor/holt59/cakephp3-bootstrap-helpers/src/View/Helper/BootstrapFormHelper.php, line 429]

The v4 branch is currently outdated so it may not work with recent cakephp versions. I will rework it from scratch soon.


have neotest.output stay

This output displays the test for about a second before is disappears.
Is it possible to have it stay?
:h neotest.output tells me i can manually call the "consumer" with..
lua require("neotest").output.open({ enter = true })
That's really cool, but maybe i can make it stay put.
I have a very minimal setup right now:
local M = {}

function M.setup()
  require("neotest").setup {
    adapters = {
      require "neotest-python" {
        dap = {
          justMyCode = false,
          console = "integratedTerminal"
        },
        args = { "--log-level", "DEBUG", "--quiet" },
        runner = "pytest",
      },
      require "neotest-jest",
    },
  }
end

return M

and
{
   "nvim-neotest/neotest",
   dependencies = {
     "nvim-lua/plenary.nvim",
     "nvim-treesitter/nvim-treesitter",
     "antoinemadec/FixCursorHold.nvim",
     "nvim-neotest/neotest-python",
     "haydenmeade/neotest-jest",
   },
   lazy = true,
   config = function()
     require("user.neotest").setup()
   end,
 },

@fdelacruz I don't know why your output window is flickering, but here's a possible workaround.
After you run a test, put your cursor anywhere in the test and try require("neotest").output.open() (I have this mapped to a key mapping). Does it stay up then? If you move the cursor, it should disappear. If you issue the command twice, you should be able to enter into the output window for scrolling.

@albertocerrone I have fixed the same problem by disabling the quick fix in the configuration:
...
quickfix = {
    enabled = false,
},
...

Thank you so much @mszenfeld! That fixed my issue ❤


bugfix platform specifications for installing jaxlib with poetry

I think I specified platform_machine wrong for your setup. Let's get this working together before merging!

We can tag https://github.com/xeb/dalle-mini-tools/issues/4 to this & try to fix it in this branch. Trying on the VM now.

I was able to fix poetry and things are looking good. I'm going to use this comment as my status & keep it updated.

[ x ] Purge all previous poetry installs
[ x ] Install poetry preview
[ x ] poetry install -- the jaxlib 0.3.10+cuda11.cudnn82 wheel installed, yay!
[   ] poetry update for good measure
[   ] poetry run python generate.py "this is a test" worked with GPU
[   ] poetry run python worker.py should work with GPU
[   ] poetry run python server.py
[   ] poetry run python request.py "yet another test"


Kotlin documentation for transformers not working

The Documentation for the kotlin json examples, and potentially others, doesn't compile.

Fixed in #725


1.5 Eradication Goals undercounting in some scenarios

I have a save in which Slime Eradication and Duggy Eradication are now unlocked, but the checkup tool indicates 66  and 4 more are needed respectively. I suspect, but am not 100% certain, that this is because new 1.5 Magma Duggies and Tiger Slimes are not being counted in the tool. I don't know if any other new enemy types also need to be counted for any goals (perhaps Prismatic Slime?)

Hello @jmtar,
I've tried to reach out to you but I couldn't contact, thats why I capture this thread.
Could you please contact me on my e-mail<EMAIL_ADDRESS>I've got some questions about Beanconqueror to you.
Big thank you in advance!
Lars

Hello @jmtar,
I've tried to reach out to you but I couldn't contact, thats why I capture this thread.
Could you please contact me on my e-mail<EMAIL_ADDRESS>I've got some questions about Beanconqueror to you.
Big thank you in advance!
Lars